From xen-devel-bounces@lists.xenproject.org Tue Feb 01 02:11:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 01 Feb 2022 02:11:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.263360.456051 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEid9-0002Wo-RX; Tue, 01 Feb 2022 02:10:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 263360.456051; Tue, 01 Feb 2022 02:10:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEid9-0002Wg-Ly; Tue, 01 Feb 2022 02:10:51 +0000
Received: by outflank-mailman (input) for mailman id 263360;
 Tue, 01 Feb 2022 02:10:49 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nEid7-0002WW-SI; Tue, 01 Feb 2022 02:10:49 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nEid7-0007nb-Ll; Tue, 01 Feb 2022 02:10:49 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nEid7-0005Wd-1m; Tue, 01 Feb 2022 02:10:49 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nEid7-0005Ru-1G; Tue, 01 Feb 2022 02:10:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=tEubqP9w2GkruSd0X55Pfcuje+DEjFo6LHLujDrBP2M=; b=gqH29su0svHS2Z5xLm4frCixM9
	bBMan07QmZ6EPNTjjGBm738rJXeEnCEv9usvk4FbuDvuLYqoKQxK8KW3XGo2DfiFgN9ztDHkDiQYH
	DorkOAOxv+weT8LSTg0wReqt/sDz6fjOa93ynx4MFjkHb5/iE9kvHgPyh/R0rv/pYXiA=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167966-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 167966: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=c78901ab09bd0c469649f4ecbd325a6edb953592
X-Osstest-Versions-That:
    xen=21170a738c11b24815b4afab2151bd3aa2a29acc
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 01 Feb 2022 02:10:49 +0000

flight 167966 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167966/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167961
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167961
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167961
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167961
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 167961
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 167961
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167961
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167961
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167961
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167961
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167961
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167961
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 xen                  c78901ab09bd0c469649f4ecbd325a6edb953592
baseline version:
 xen                  21170a738c11b24815b4afab2151bd3aa2a29acc

Last test of basis   167961  2022-01-31 01:51:51 Z    1 days
Testing same since   167966  2022-01-31 13:08:14 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Dario Faggioli <dfaggioli@suse.com>
  James Fehlig <jfehlig@suse.com>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Rahul Singh <rahul.singh@arm.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   21170a738c..c78901ab09  c78901ab09bd0c469649f4ecbd325a6edb953592 -> master


From xen-devel-bounces@lists.xenproject.org Tue Feb 01 06:08:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 01 Feb 2022 06:08:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.263393.456078 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEmKU-0007fj-Fr; Tue, 01 Feb 2022 06:07:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 263393.456078; Tue, 01 Feb 2022 06:07:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEmKU-0007fc-BS; Tue, 01 Feb 2022 06:07:50 +0000
Received: by outflank-mailman (input) for mailman id 263393;
 Tue, 01 Feb 2022 06:07:48 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=JH7e=SQ=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nEmKS-0007fG-De
 for xen-devel@lists.xenproject.org; Tue, 01 Feb 2022 06:07:48 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 46c422f0-8325-11ec-8f75-fffcc8bd4f1a;
 Tue, 01 Feb 2022 07:07:47 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 3CBF71F380;
 Tue,  1 Feb 2022 06:07:46 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0635F13AE0;
 Tue,  1 Feb 2022 06:07:45 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id w79xOzHO+GHwGQAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 01 Feb 2022 06:07:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 46c422f0-8325-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1643695666; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=hTVk5J06TLwx7tCeGGEC8EKM9vOZdWrFyC4m7J//Ixo=;
	b=QrMfcfMBfQDRKBcmtBAAAbUT3IWfCcx137h+cdL2PRXP1lrkeDugMwLgQUyYCf18JZiUxT
	Qsc7BtIVCG74K/GwsTSoB/P4dSs8Mv0YO1/8QjApxzSaLShXtlnsT7UeylLbDEtmn3F5uO
	Noa8LIPVRJ2g1cu60wC7mRf8RXxIUmE=
Message-ID: <370e3874-d547-acad-924c-87ad8ef00a1d@suse.com>
Date: Tue, 1 Feb 2022 07:07:45 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Subject: Re: [PATCH v2] Improve docs for IOCTL_GNTDEV_MAP_GRANT_REF
Content-Language: en-US
To: Demi Marie Obenour <demiobenour@gmail.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
References: <f66c5a4e-2034-00b5-a635-6983bd999c07@gmail.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <f66c5a4e-2034-00b5-a635-6983bd999c07@gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------4J9FN0TPV6jB8XqXvFNBoDJB"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------4J9FN0TPV6jB8XqXvFNBoDJB
Content-Type: multipart/mixed; boundary="------------VRXR2dHFRLehSpEMOdAQ14S7";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Demi Marie Obenour <demiobenour@gmail.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Message-ID: <370e3874-d547-acad-924c-87ad8ef00a1d@suse.com>
Subject: Re: [PATCH v2] Improve docs for IOCTL_GNTDEV_MAP_GRANT_REF
References: <f66c5a4e-2034-00b5-a635-6983bd999c07@gmail.com>
In-Reply-To: <f66c5a4e-2034-00b5-a635-6983bd999c07@gmail.com>

--------------VRXR2dHFRLehSpEMOdAQ14S7
Content-Type: multipart/mixed; boundary="------------ru0kpdTjRIZZya5rqkMmSBLG"

--------------ru0kpdTjRIZZya5rqkMmSBLG
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMzEuMDEuMjIgMTg6MjMsIERlbWkgTWFyaWUgT2Jlbm91ciB3cm90ZToNCj4gVGhlIGN1
cnJlbnQgaW1wbGVtZW50YXRpb24gb2YgZ250ZGV2IGd1YXJhbnRlZXMgdGhhdCB0aGUgZmly
c3QgY2FsbCB0bw0KPiBJT0NUTF9HTlRERVZfTUFQX0dSQU5UX1JFRiB3aWxsIHNldCBAaW5k
ZXggdG8gMC4gIFRoaXMgaXMgcmVxdWlyZWQgdG8NCj4gdXNlIGdudGRldiBmb3IgV2F5bGFu
ZCwgd2hpY2ggaXMgYSBmdXR1cmUgZGVzaXJlIG9mIFF1YmVzIE9TLg0KPiBBZGRpdGlvbmFs
bHksIHJlcXVlc3RpbmcgemVybyBncmFudHMgcmVzdWx0cyBpbiBhbiBlcnJvciwgYnV0IHRo
aXMgd2FzDQo+IG5vdCBkb2N1bWVudGVkIGVpdGhlci4gIERvY3VtZW50IGJvdGggb2YgdGhl
c2UuDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBEZW1pIE1hcmllIE9iZW5vdXIgPGRlbWlvYmVu
b3VyQGdtYWlsLmNvbT4NCg0KUmV2aWV3ZWQtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0Bz
dXNlLmNvbT4NCg0KDQpKdWVyZ2VuDQo=
--------------ru0kpdTjRIZZya5rqkMmSBLG
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------ru0kpdTjRIZZya5rqkMmSBLG--

--------------VRXR2dHFRLehSpEMOdAQ14S7--

--------------4J9FN0TPV6jB8XqXvFNBoDJB
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmH4zjEFAwAAAAAACgkQsN6d1ii/Ey+/
mwf9Ezqdxdv2UQugbuRD2aFgWkdL316BYADmg13TnOsfox+VYZuCouUiqTya5q4xJC7tR/iambvf
rphc+dCv/oBRuWWbWuHNWlDLyDC/WEhhkJgQdk69SnbmfQzJM5VZ8Z81rUwhd1SWgv+BMtsuE++C
1w85cxqD//gCDgIHB035k1Yir4MgRX+DL3ubVuLDs65x+DiQNk14J0Lo2DfJl9iwa6XIkRgRZQBA
BbyQtA3UiNI0MC9zs5wdggoWd2+dLwHmfO9RIZIncqpbXZVYW2aRLzQ0A421KnWeFQjs9MwLV77n
A1JjcnQI2bCxy2eZzvFwahNRVBWy8/Cup6Zfn45CGQ==
=fpr+
-----END PGP SIGNATURE-----

--------------4J9FN0TPV6jB8XqXvFNBoDJB--


From xen-devel-bounces@lists.xenproject.org Tue Feb 01 06:08:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 01 Feb 2022 06:08:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.263398.456089 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEmL3-0008DD-Sw; Tue, 01 Feb 2022 06:08:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 263398.456089; Tue, 01 Feb 2022 06:08:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEmL3-0008D6-Pf; Tue, 01 Feb 2022 06:08:25 +0000
Received: by outflank-mailman (input) for mailman id 263398;
 Tue, 01 Feb 2022 06:08:25 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=JH7e=SQ=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nEmL3-0007fG-AR
 for xen-devel@lists.xenproject.org; Tue, 01 Feb 2022 06:08:25 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5d5783ba-8325-11ec-8f75-fffcc8bd4f1a;
 Tue, 01 Feb 2022 07:08:24 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 3530A1F380;
 Tue,  1 Feb 2022 06:08:24 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0A0C813AE0;
 Tue,  1 Feb 2022 06:08:24 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id E98WAVjO+GEfGgAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 01 Feb 2022 06:08:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5d5783ba-8325-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1643695704; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=WAGpANrCQlSGFlAJNTGRJkRbBogdKteolJybvtXKEa4=;
	b=aTwRg2W1b1xujyiZMSFXT9BcQF+3VtV7SOZNNHMPzV8huvMMOvj/KniHwr8UF9Wohi8Ao1
	V8CjIA/xnnsgGM8eiHPEZPL+pu3tB6zeojHHWHWPBqFf17jpJdc3PPMaeQNG4RSg8jE8v7
	aYaVtUWDzbXk6TxMP7VCCkXCiDEtwCs=
Message-ID: <f914bc80-48c5-1c3f-8afa-5d1e68bd3880@suse.com>
Date: Tue, 1 Feb 2022 07:08:23 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Subject: Re: [PATCH v2] xen: update missing ioctl magic numers documentation
Content-Language: en-US
To: Randy Dunlap <rdunlap@infradead.org>, patches@lists.linux.dev
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Stefano Stabellini <sstabellini@kernel.org>, xen-devel@lists.xenproject.org
References: <20220131161959.16509-1-rdunlap@infradead.org>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <20220131161959.16509-1-rdunlap@infradead.org>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------xFG2CrSGTAjtrkUfI6YDAYEk"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------xFG2CrSGTAjtrkUfI6YDAYEk
Content-Type: multipart/mixed; boundary="------------2YLbpAeo7w1caMGevXb7Qd3V";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Randy Dunlap <rdunlap@infradead.org>, patches@lists.linux.dev
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Stefano Stabellini <sstabellini@kernel.org>, xen-devel@lists.xenproject.org
Message-ID: <f914bc80-48c5-1c3f-8afa-5d1e68bd3880@suse.com>
Subject: Re: [PATCH v2] xen: update missing ioctl magic numers documentation
References: <20220131161959.16509-1-rdunlap@infradead.org>
In-Reply-To: <20220131161959.16509-1-rdunlap@infradead.org>

--------------2YLbpAeo7w1caMGevXb7Qd3V
Content-Type: multipart/mixed; boundary="------------fdOISzuALhvxzkJtCd6EumJj"

--------------fdOISzuALhvxzkJtCd6EumJj
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMzEuMDEuMjIgMTc6MTksIFJhbmR5IER1bmxhcCB3cm90ZToNCj4gQWRkIG1pc3Npbmcg
aW9jdGwgIm1hZ2ljIG51bWJlcnMiIGZvciB2YXJpb3VzIFhlbiBpbnRlcmZhY2VzDQo+ICh4
ZW5idXNfZGV2LmgsIGdudGFsbG9jLmgsIGdudGRldi5oLCBhbmQgcHJpdmNtZC5oKS4NCj4g
DQo+IFNpZ25lZC1vZmYtYnk6IFJhbmR5IER1bmxhcCA8cmR1bmxhcEBpbmZyYWRlYWQub3Jn
Pg0KPiBDYzogQm9yaXMgT3N0cm92c2t5IDxib3Jpcy5vc3Ryb3Zza3lAb3JhY2xlLmNvbT4N
Cj4gQ2M6IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4NCj4gQ2M6IFN0ZWZhbm8g
U3RhYmVsbGluaSA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz4NCj4gQ2M6IHhlbi1kZXZlbEBs
aXN0cy54ZW5wcm9qZWN0Lm9yZw0KDQpSZXZpZXdlZC1ieTogSnVlcmdlbiBHcm9zcyA8amdy
b3NzQHN1c2UuY29tPg0KDQoNCkp1ZXJnZW4NCg==
--------------fdOISzuALhvxzkJtCd6EumJj
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------fdOISzuALhvxzkJtCd6EumJj--

--------------2YLbpAeo7w1caMGevXb7Qd3V--

--------------xFG2CrSGTAjtrkUfI6YDAYEk
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmH4zlcFAwAAAAAACgkQsN6d1ii/Ey/Z
Ggf8CdJDjgJn6HUi9XE4LUU3SkUT9bBe/UJY7KjpQ83e++oyNIxbdfB9b0gKdbCYwgeKYfheWQOL
HYd5uViRsf7vivYusOaIyixhsLEeFK9tQ3nd0qtLnK1kyhRvy2OOeVryfNUtCaAw3i4vzR0MeYZF
+7H0AZiJ4+HbdrMotmtACxjGRnw1nboAoexIO1KVJEiuNFHM+YwlyF6g1q/dCXyqR5vSw55XeVZ3
I3a2fyxqfj2esMa7jCo46W+gtGn6XznjujImwHQIYhatu4g6rmyvheFZwE07BQuQT8PkiG9mcifh
QvyJZM7UTUt+h6m42HJhzkBZwu6TFbrzxweSyUMSkg==
=Tk4N
-----END PGP SIGNATURE-----

--------------xFG2CrSGTAjtrkUfI6YDAYEk--


From xen-devel-bounces@lists.xenproject.org Tue Feb 01 07:32:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 01 Feb 2022 07:32:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.263409.456100 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEndj-0008Lc-Kl; Tue, 01 Feb 2022 07:31:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 263409.456100; Tue, 01 Feb 2022 07:31:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEndj-0008LU-H8; Tue, 01 Feb 2022 07:31:47 +0000
Received: by outflank-mailman (input) for mailman id 263409;
 Tue, 01 Feb 2022 07:31:46 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7bwX=SQ=epam.com=prvs=4031c7af39=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nEndi-0008LO-DW
 for xen-devel@lists.xenproject.org; Tue, 01 Feb 2022 07:31:46 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 010adcd3-8331-11ec-8eb8-a37418f5ba1a;
 Tue, 01 Feb 2022 08:31:44 +0100 (CET)
Received: from pps.filterd (m0174682.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 20VLTix4028338;
 Tue, 1 Feb 2022 07:31:40 GMT
Received: from eur02-ve1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2053.outbound.protection.outlook.com [104.47.6.53])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3dxqr190mw-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Tue, 01 Feb 2022 07:31:39 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM7PR03MB6546.eurprd03.prod.outlook.com (2603:10a6:20b:1bf::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.22; Tue, 1 Feb
 2022 07:31:32 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6%3]) with mapi id 15.20.4930.022; Tue, 1 Feb 2022
 07:31:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 010adcd3-8331-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=FHn0coy58Nij7DDErEwdDqKWQ5AVwdmnr3StHo+aEouv9vyWqVccSmGjd4J4cZ0108PArKsN2njscv3P/nsOI1nvbl22iUL8sZL3ct2wEgeApal+MipRR4OztID9xuminMf+Pe1YZsGI/EmZR6ZckJNarr0npx/79jqhncL9dOyTo3L0HRSTMqeKm9Vvs9FlLPrqpWx/3/9mGqUc+TGUvfkhKWmP7m8On5ZoZdcnEMRV603jGCpyxrJEDAGI64pLMxScJg4MsDzow8AYInF8g7kx7zpm9lU11FumgWgHGxKg8nuxRIOiR4XOdQG3Zt5PckqKHnvC/yv0N9f+wPiqIA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=sYXmMcxEZyscolsk1qt3re5nHyVHfn2eL1bnW92I+cA=;
 b=nqyXfcyY4gLorWH41bGRdhIBuOHGv4HOJpQc+3YTO7vjx9w0Crb4NZE+Sy2yLGpwaIPGLUIIAGKe+McsvL90kV0Y8s94mxp/Zjp/7ZXth+DzwforqpABCgOYvumAI2qHaGmEPjIxl9qSohBgwPXBotg9hp6X8hWbuCbubMLSiyzDunBUDyouzyuC06GB8yEiheVLgsCoRxogCaeETYV0xhsQfBunfrx4g/8N8uqZao+04x143Z7cupxvVeKupgg0ipeoNa22VrWivvbWHIo+ZNXTzsrmIkA6nWhkZsj/2/235//zoickSK8/mBKmV/nm+dz9YeV59gjAYvpOU+TJWg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=sYXmMcxEZyscolsk1qt3re5nHyVHfn2eL1bnW92I+cA=;
 b=U+M4bVSEr+o0aahrAyX9EP1bKwGwIlrGvgwsy5gNjF6NZtLDtflPeX3bcFnlXIDw2UxkR5tqmw4TotbNf8kRG3mq+q/Jr0BRvJEwZGxYius7LkO23d2qNYGT9nHQTFgnnCW2V4I40fsIHj9WkIj/XYB2LO4vaUlFq8l+p2fWa9l9VT0MdPDI0+eYg8fE4WIRrTFt/QDyzghOI8tqXcwZqqvKsDYWPUTgnAdVmQPFvNEgpA+3aGUCh92ITZbJS/2kotjCrbRB2f4sj3wbga6iPWBEifia0FA3fmA0DU2MpKyaS3fbdJK+UctlrrqNgnhgUtOUgZHuOqbgPf2vkJYyfg==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>,
        =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?=
	<roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v5 06/14] vpci/header: implement guest BAR register
 handlers
Thread-Topic: [PATCH v5 06/14] vpci/header: implement guest BAR register
 handlers
Thread-Index: AQHX4ewHyWAyD811HEGp8pIjUuVWNaxfndGAgB4GiwCAAAxbgIABBueA
Date: Tue, 1 Feb 2022 07:31:31 +0000
Message-ID: <c82f94c4-dadf-7b2d-4d30-a1de2b5f962a@epam.com>
References: <20211125110251.2877218-1-andr2000@gmail.com>
 <20211125110251.2877218-7-andr2000@gmail.com> <Yd7K+9fvnBz+WTXA@Air-de-Roger>
 <082ca110-2ab7-60ff-e705-032d2d472547@epam.com>
 <df36767b-e04f-aa29-82af-87e8624bd29c@suse.com>
In-Reply-To: <df36767b-e04f-aa29-82af-87e8624bd29c@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: f1421744-5630-4268-d339-08d9e554de5e
x-ms-traffictypediagnostic: AM7PR03MB6546:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM7PR03MB6546984CD5809185D336FE5FE7269@AM7PR03MB6546.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 J1gA89T6wU95Ae6iMMtClOGe8C9DSIWJmZ1AnZK5JD5z4w/dLVYJuar+wAkTgc2kGLhOuuM3vACdDxoL1IWX82eGfK6XryAg/dAfBOsf3oW5y36d1OOD3VJxngxEoeT9aFv84MuzdWuXa4l5JCgCgFEnzfNnOPe1XZ2mrDUEHXcDNWUW0bhQlPXjC4sxBTdrYRQssE/mQNlHKF56aDnayEfTafim5HWDb9KCayrSpd5hdaNFYyc2vraFSrdZl1K2CmjEth0LJTXbV+Hv0qhntveRbptYrmarhJNehyRNa2PsxGk/e7iapUp3SulqrPXt8aHp0OrdkQSgkfuJ34bx1KWjk2AyQ+4Y2s5wvaE7una/zFHWltTKwwfpayOw/wmbdbpKDMIdy3/oGTQCBxXnYH8TIYIwaLHJvUx2VjzTQI/k7hZug5EwgQ/X9XLa5iYmQtZzMiAwVFH2g+RpTQmHjMNhA0sl7TaY8mI/HONm5qTHyU9gZWMFsNQWC4CqnOnUlxJfqdoQBAQrdq1dVtUqeu/JeBrEMIKD1VFvRk3RzRQh5xeCfVZJwDnt5Ib1K/jSM2NPCM5RPoeaebj8Mdpcri7JoiwSP7TImsPHvZk9T8Y6fdOkMPTw6xkH1ttxEvJ7iAjtnFils5pyPRarRJn8IS6TrFP3qXDwbwFrDO3pnzbh83YGwIgFlMBs9QUi4X+nST3HtuzenhviJ/Nf1SCSZqIeNk15TXGiIM/fpprmyUEIVRokvPNxf8fEHhPFR1zH
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(508600001)(71200400001)(122000001)(31696002)(6486002)(26005)(186003)(2616005)(6506007)(6512007)(2906002)(38070700005)(38100700002)(53546011)(31686004)(4326008)(91956017)(316002)(66946007)(66556008)(76116006)(66446008)(66476007)(64756008)(110136005)(54906003)(8936002)(107886003)(86362001)(8676002)(36756003)(5660300002)(7416002)(83380400001)(45980500001)(20210929001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?ZFdYdUhmeGRtOGNQVkxFYTBOb0l5QkkrcWE4c3NyS1lkNWxveHJnOTJsMjB0?=
 =?utf-8?B?WDlYNzJLWlk2LzV4Ukl0dFkzSDdnU01CYS9LbGZjL0RKandCNVYrRVdoNE96?=
 =?utf-8?B?bHBXRjJaWW9zWWJScFZvUG1yTnAxUGNZOGZjTVpqZUd3NHFZeVA0K2VOY0Nj?=
 =?utf-8?B?K1IvNHpNajVDMFhNVUZQV1FoaXF0a3FVVDVmTWZrL0ErZ2NqSG10cy9FOWlU?=
 =?utf-8?B?ZUV4cDFZMTNia3JIbUJONmRuRmVUZUtPWlZBMjFIbnJNeHRnWEZtQ1JGa2pL?=
 =?utf-8?B?ZUplanJyaS9Dd2JHZXJzZTU4UVJ5TC9ZU1VmTUkzZ2RuZGQwWEEwOE5Db1JK?=
 =?utf-8?B?WlVlOHNzdDBOT1h5TmFIOEtHSzhOT08rY0ZMM0RJVnF4RFozWlpWWkhGWkIx?=
 =?utf-8?B?N3k5RFlmcnRaMlhPNUdqeW1obmYzMTBpWWVjWjBhSDYrNzk1U3A5Z1dPYWZI?=
 =?utf-8?B?ZzJJZUxZL0dxWjR5T3RPcktmZWtNVlF2SUpHWk1zVzFicEJuNEFNQkl2YkVy?=
 =?utf-8?B?VS9tVVltMDdTSzZNeVVjcFBsd0YvMEEwY09HR3l5bVdUenFoS0IwaE15eXpB?=
 =?utf-8?B?Umh4TTNBYmV1SnZHd0lvL3ZsUnVWemxiRzBnb3kyVFlEWk9iTlNKMG5tZlZw?=
 =?utf-8?B?T21PaFVxMWJWZzFQNjdSb3VNZ3JKcmVYRHVKaVFJR041TmUrL00yaUdrQXM4?=
 =?utf-8?B?K0xFZmNOcDVBNDhsVllZbFdnZ0wvTTVjNnd5YVVsMHZXSnBXTUtQanlTTXBq?=
 =?utf-8?B?bHBUYkpYcUtFai9PUVVIRXlGN01yK05iaW45MDNFc0VGQUk4Mm5WbGlld1Nu?=
 =?utf-8?B?U0tsUVFpMlF2T3M2VlE1c2F6T3R5QXJWMmJ4Vm11eUpSM0hZS3g5dFlJUlBJ?=
 =?utf-8?B?QlJJRGVLUDFqOERlT3cwY2NkMHJXSVJrcUZaOHBoaGpsbmRuNm1FQWhsdVJx?=
 =?utf-8?B?SFZVZWlhRHdzKytsT2wyb3p4QTY3L210a1BaaGhIOGYxZVk2c3A0cS9yRGEy?=
 =?utf-8?B?RTFxSkQxU1RlSVVTU0xwTUpsVVBubTJlbC9CMWtuUTlVUlQ4RXY5VUsvQlpD?=
 =?utf-8?B?ekNIdERCd3Q0Y3dnSnFrdm9CbW1ZNmdmcUN6NmFMeVJLaDhuUUIyWE9BVXha?=
 =?utf-8?B?UmJjMnJMelRkeVRGY2k4MGx3Z28yOGlib2NLUXhocHRid1h6SldFNS9yRHBT?=
 =?utf-8?B?eldWMTNDZ3YrTkVZU0IxS1U2OWl0ck85S2JDZXFDbGk4M2NHd2ZLZkJiWUQ5?=
 =?utf-8?B?ekZYbjhlbk4wb0wvTUxpY1dIcjBIQldJYjg0ZnozQ1htMXJGWUsrejZxOGNs?=
 =?utf-8?B?allMdW5QVm4yZjY0bjAyQzZFSDM1bzAvaDZsc1ZZNWthZkVSTllTVGVTa0pC?=
 =?utf-8?B?SXJtTjI5Ym12cENibWttdUxHUzF1KzhFcHBiNmVEZjFLNzhIUmlXTW5VczQ0?=
 =?utf-8?B?WHAwcU5GSWpFcW9TYXI1MDdkNU1NQXJ4WEROZlRHK3NPS1JCTW10SnVYb3RC?=
 =?utf-8?B?V3lteGFZdnByVUw0KzZ5OHVZeEdPbFRGbXl1cnR6SXdKdHZPSVdpTmg5Mkdn?=
 =?utf-8?B?NjVub3JGR3hLME5ZT0dBRmNudnk1VnpmQkRBQU8yNTg1TWNrSzB1eVBaa0FY?=
 =?utf-8?B?Z2l0czQ4aWRCWTJqOWI5RkxzbThGaVRDdU5XTS82Skw2MWxPeTZTQTRUNlI3?=
 =?utf-8?B?a2JmdXBuK2xreVVjcmtRQllMeHZHOFNBR1UyWWQyZ0QrajlZdHhlRnVnT2pC?=
 =?utf-8?B?WFNUVU5ETHNqV1pjUEhaOFhuT09tK1I2QTI0dmN4ZkRMM0ttMVVnV1Yzc3hU?=
 =?utf-8?B?c01sNW9aQWhjY2d3WXF2alpQN3R1UlRuYVlmZGJNeFE1akZOWWEzTWdQVlhZ?=
 =?utf-8?B?eHhDM0tNajJGRDhoSlBZUjRwYk5uTG5PMnFwNkllRzFvLzEvWXB4TU8vV2FG?=
 =?utf-8?B?N1ZHZ3loSHZJSmpWMmpyRWFQdDJMTFFMQmdva0NLSWJVZmloYXhxZ0pjaTdo?=
 =?utf-8?B?RGpCNUF0cUp5MzU4Q1R4aEZDRjFLeUhNWDVaRXJNMmVjVXgzTllqUGZMR2xh?=
 =?utf-8?B?UWRhSW1rOUtTSjQrUUFWMDBDdWpLWnFZNWFoR0VVejZQVXNXaFBJWjV6OGpL?=
 =?utf-8?B?d0JBdGlRczJHV2FHckRBYjVBd21YZ0E2V1RGaU5xUjYxdDJJc0N5NW5GaGUz?=
 =?utf-8?B?akNnbjJ5S1VSM3F0MEphMWJEVmJleE5mQm0rdmIxcFhkQzAwMUZ4S2gyWlNj?=
 =?utf-8?B?bDhsdm9BWUVPTFh0ZGp1NjUzZ0Nja0lOQWJKY3pvS1R5UzBIZHVoSFkwNkEz?=
 =?utf-8?B?REd4czhmVDNjNTlqS1dXTERsZlR4K1M3MGxsNGFtK3VDWGFMeUM2dz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <83F5242002E404448D3F6F13B7167D72@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f1421744-5630-4268-d339-08d9e554de5e
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Feb 2022 07:31:31.9156
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: YpnsSWhSeWOkunXDRVGR+T384ROYcWYwMbfserFb5dQZ4Al4XZnEBbVS68TF979RCw+Xj6iLqy1ILMPJyfzn9/Nxn+OjnDaK9PFYTczSR5RWsjYyvxx2oPvHi7HIDWbz
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR03MB6546
X-Proofpoint-GUID: --UVtJTU9hyr4V-2DXWUutoN3BCYNVC1
X-Proofpoint-ORIG-GUID: --UVtJTU9hyr4V-2DXWUutoN3BCYNVC1
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-01_02,2022-01-31_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015
 priorityscore=1501 malwarescore=0 mlxlogscore=999 phishscore=0 spamscore=0
 mlxscore=0 adultscore=0 bulkscore=0 suspectscore=0 lowpriorityscore=0
 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202010038

DQoNCk9uIDMxLjAxLjIyIDE3OjUwLCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMzEuMDEuMjAy
MiAxNjowNiwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+PiBIaSwgUm9nZXIhDQo+
Pj4+ICAgICAgICAgICAgICAgIHJvbS0+dHlwZSA9IFZQQ0lfQkFSX0VNUFRZOw0KPj4+PiAgICAg
ICAgfQ0KPj4+PiBkaWZmIC0tZ2l0IGEveGVuL2luY2x1ZGUveGVuL3ZwY2kuaCBiL3hlbi9pbmNs
dWRlL3hlbi92cGNpLmgNCj4+Pj4gaW5kZXggZWQxMjdhMDhhOTUzLi4wYTczYjE0YTkyZGMgMTAw
NjQ0DQo+Pj4+IC0tLSBhL3hlbi9pbmNsdWRlL3hlbi92cGNpLmgNCj4+Pj4gKysrIGIveGVuL2lu
Y2x1ZGUveGVuL3ZwY2kuaA0KPj4+PiBAQCAtNjgsNyArNjgsMTAgQEAgc3RydWN0IHZwY2kgew0K
Pj4+PiAgICAgICAgc3RydWN0IHZwY2lfaGVhZGVyIHsNCj4+Pj4gICAgICAgICAgICAvKiBJbmZv
cm1hdGlvbiBhYm91dCB0aGUgUENJIEJBUnMgb2YgdGhpcyBkZXZpY2UuICovDQo+Pj4+ICAgICAg
ICAgICAgc3RydWN0IHZwY2lfYmFyIHsNCj4+Pj4gKyAgICAgICAgICAgIC8qIFBoeXNpY2FsIHZp
ZXcgb2YgdGhlIEJBUi4gKi8NCj4+PiBObywgdGhhdCdzIG5vdCB0aGUgcGh5c2ljYWwgdmlldywg
aXQncyB0aGUgcGh5c2ljYWwgKGhvc3QpIGFkZHJlc3MuDQo+Pj4NCj4+Pj4gICAgICAgICAgICAg
ICAgdWludDY0X3QgYWRkcjsNCj4+Pj4gKyAgICAgICAgICAgIC8qIEd1ZXN0IHZpZXcgb2YgdGhl
IEJBUjogYWRkcmVzcyBhbmQgbG93ZXIgYml0cy4gKi8NCj4+Pj4gKyAgICAgICAgICAgIHVpbnQ2
NF90IGd1ZXN0X3JlZzsNCj4+PiBJIGNvbnRpbnVlIHRvIHRoaW5rIGl0IHdvdWxkIGJlIGNsZWFy
ZXIgaWYgeW91IHN0b3JlIHRoZSBndWVzdCBhZGRyZXNzDQo+Pj4gaGVyZSAoZ2FkZHIsIHdpdGhv
dXQgdGhlIGxvdyBiaXRzKSBhbmQgYWRkIHRob3NlIGluIGd1ZXN0X2Jhcl9yZWFkDQo+Pj4gYmFz
ZWQgb24gYmFyLT57dHlwZSxwcmVmZXRjaGFibGV9LiBUaGVuIGl0IHdvdWxkIGJlIGVxdWl2YWxl
bnQgdG8gdGhlDQo+Pj4gZXhpc3RpbmcgJ2FkZHInIGZpZWxkLg0KPj4+DQo+PiBJIGFncmVlZCBm
aXJzdCB0byBkbyBzdWNoIGEgY2hhbmdlLCBidXQgdGhlbiByZWNhbGxlZCBvdXIgZGlzY3Vzc2lv
biB3aXRoIEphbiBbMV0uDQo+PiBBbmQgdGhlbiB3ZSBkZWNpZGVkIHRoYXQgaW4gb3JkZXIgZm9y
IGl0IHRvIGJlIGVmZmljaWVudCBpdCBpcyBiZXR0ZXIgaWYgd2Ugc2V0dXAgYWxsIHRoZQ0KPj4g
dGhpbmdzIGR1cmluZyB0aGUgd3JpdGUgcGhhc2UgKHJhcmUpLCByYXRoZXIgdGhlbiBkdXJpbmcg
dGhlIHdyaXRlIHBoYXNlIChtb3JlIG9mdGVuKS4NCj4gU21hbGwgY29ycmVjdGlvbjogVGhlIDJu
ZCAid3JpdGUiIHdhcyBsaWtlbHkgbWVhbnQgdG8gYmUgInJlYWQiLg0KWWVzLCB0aGlzIGlzIGNv
cnJlY3QuDQo+ICAgQnV0DQo+IHBsZWFzZSByZWNhbGwgdGhhdCBSb2dlciBpcyB0aGUgbWFpbnRh
aW5lciBvZiB0aGUgY29kZSwgc28gaGUgZ2V0cw0KPiB0aGUgZmluYWwgc2F5Lg0KQWdyZWUsIGJ1
dCB3b3VsZCB2b3RlIGZvciB0aGUgY3VycmVudCBhcHByb2FjaCBhcyBpdCBzdGlsbCBzYXZlcyBz
b21lDQpDUFUgY3ljbGVzIG1ha2luZyB0aGUgcmVhZCBvcGVyYXRpb24gcmVhbGx5IHRpbnkNCj4N
Cj4gSmFuDQo+DQpUaGFuayB5b3UsDQpPbGVrc2FuZHI=


From xen-devel-bounces@lists.xenproject.org Tue Feb 01 07:45:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 01 Feb 2022 07:45:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.263416.456110 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEnr2-0001Qz-Rn; Tue, 01 Feb 2022 07:45:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 263416.456110; Tue, 01 Feb 2022 07:45:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEnr2-0001Qs-Oq; Tue, 01 Feb 2022 07:45:32 +0000
Received: by outflank-mailman (input) for mailman id 263416;
 Tue, 01 Feb 2022 07:45:32 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nEnr1-0001Qi-Ub; Tue, 01 Feb 2022 07:45:31 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nEnr1-0005jl-Pc; Tue, 01 Feb 2022 07:45:31 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nEnr1-0005VT-77; Tue, 01 Feb 2022 07:45:31 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nEnr1-0005ME-6d; Tue, 01 Feb 2022 07:45:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=zPMu0eruAgJj46OZcOBwr+ejecASBn/FuQl7IOyqcQA=; b=aqBpn6ckAY9PPDvv5VXeLw9r8v
	+KY4VivoS/84D2KBEUSgVnjcsOWNzUhi8mrKirQYq9APnHxMq6gyhabBKJ3AGI1e7IsRrXQ30Ngd7
	MOgbu8mqPJeX6dNorbQwcLk/ZbGCSe4iCUPPRHAkptZsT661gv/o5huHkOxvRHm6Vmmc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167971-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 167971: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=4d5f82ee7bccec6ae90ccaefde0d7dcb555e4831
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 01 Feb 2022 07:45:31 +0000

flight 167971 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167971/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              4d5f82ee7bccec6ae90ccaefde0d7dcb555e4831
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  571 days
Failing since        151818  2020-07-11 04:18:52 Z  570 days  552 attempts
Testing same since   167971  2022-02-01 04:20:11 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brad Laue <brad@brad-x.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Christophe Fergeau <cfergeau@redhat.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Divya Garg <divya.garg@nutanix.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Ivan Teterevkov <ivan.teterevkov@nutanix.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nicolas Lécureuil <neoclust@mageia.org>
  Nicolas Lécureuil <nicolas.lecureuil@siveo.net>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Rohit Kumar <rohit.kumar3@nutanix.com>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  shenjiatong <yshxxsjt715@gmail.com>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tuguoyi <tu.guoyi@h3c.com>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Vineeth Pillai <viremana@linux.microsoft.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yasuhiko Kamata <belphegor@belbel.or.jp>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 95410 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Feb 01 08:57:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 01 Feb 2022 08:57:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.263436.456122 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEoyI-0000SI-Ky; Tue, 01 Feb 2022 08:57:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 263436.456122; Tue, 01 Feb 2022 08:57:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEoyI-0000SB-HC; Tue, 01 Feb 2022 08:57:06 +0000
Received: by outflank-mailman (input) for mailman id 263436;
 Tue, 01 Feb 2022 08:57:05 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7bwX=SQ=epam.com=prvs=4031c7af39=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nEoyH-0000S5-43
 for xen-devel@lists.xenproject.org; Tue, 01 Feb 2022 08:57:05 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ebf08d1a-833c-11ec-8eb8-a37418f5ba1a;
 Tue, 01 Feb 2022 09:57:02 +0100 (CET)
Received: from pps.filterd (m0174681.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 2115xhwb021026;
 Tue, 1 Feb 2022 08:56:53 GMT
Received: from eur02-ve1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2056.outbound.protection.outlook.com [104.47.6.56])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3dxy72rh01-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Tue, 01 Feb 2022 08:56:52 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by DB7PR03MB3929.eurprd03.prod.outlook.com (2603:10a6:5:31::25) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.22; Tue, 1 Feb
 2022 08:56:49 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6%3]) with mapi id 15.20.4930.022; Tue, 1 Feb 2022
 08:56:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ebf08d1a-833c-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=inC7thQC3NqW6sBfOAGgNBnUwNV9dE+O+E/8NdO1J/mTcY8WjLd9ZwqGEd9D1H1CsYc7euFUwtFiI/JjlTlp0iOM77BDGNTsNOyD3AuJ0vCdbbL+Su3a9mBonJ1I36h/BAdCCa8Ssy6G6zINWO6XzngkUDloGtirC5i4czA01JvNSYrjkl2gYY8iALukaEpEtT/Mej3GJyYieJ7mvOJmuOnb3kwg+Psaur5Ke7lGpQG11ZRxwAE4mVjfpHLJAuXrv0YMl9mzvkUqrfO6wnrxxzvWjz35txPNyPsoG6k0BCV7rtT+OuWwHIQF0IClSNhHILu42j5Q8VgXjCjQLOZrQA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=pTEAzn2QKlrnanGbNbEOp+KGNujiJhs8kDtbcRKZ/ZE=;
 b=auR72im0oYth6438RTWl3VSeiegZkv+XKaPi0kANDyKLZTz1IV/lSsMJjtGNLBiWg81Ftwt5nRolMhh78bKrq3z3jETYOYP+DNTb0h7gPrSLALtlFIVi61KsVhaxpQo0r3ISHm+osLGQlC/NYQHKM7KDv3NsU/9A/qk84EwnY6yMJye50qXMmX6fX9dZLUefftDu9Nt/shMWR+CjnijnBJ+wYym5WCa+BBplXvv26suwPJeDrVm7u5tMe5wgGUDtPnteg4stXObsZQQZcBS2Y2i8P4SH7gEb2zX/d3n5XGpU307so27Q3dpkZ2Ohgt5ks7Rokd5eQLJVN2AwiB2PpQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=pTEAzn2QKlrnanGbNbEOp+KGNujiJhs8kDtbcRKZ/ZE=;
 b=C9vuTg9x9PG/GBF4mcBrPiCWDpHMWPNQt330V6stK8eMp4BDwnkkwLlVtRiGG06oCIaKwjEP3jsyjN8CekhCfpwTY7Nk8VYxbVYtrxIOqjsWv+wxqq7q+M6cLRfO/N+xzxjbrgF1TFkaTG7Rxv3dUWTAdxVhNvWBKm/6wWRGEe8l9yiRM+vK5Dk4ppYbd5JPCPmUScaYiM/yLuPenq/hxbMw15JzukmINZ9DfkiITvdx/mgvggo79cdWZHhVOK+ijm0lyiA0oQk9tgd3VO334Ueu+Z5lpP2iGJM2vneH1b3VkyUeePacxch036AIn9CE7h48P8yeNHKc2EumWokicg==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "jbeulich@suse.com" <jbeulich@suse.com>,
        "andrew.cooper3@citrix.com"
	<andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com"
	<george.dunlap@citrix.com>,
        "paul@xen.org" <paul@xen.org>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>,
        Rahul Singh <rahul.singh@arm.com>,
        Oleksandr
 Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v5 05/14] vpci: add hooks for PCI device assign/de-assign
Thread-Topic: [PATCH v5 05/14] vpci: add hooks for PCI device assign/de-assign
Thread-Index: AQHX4ewGcVFZUW6RNkyJ6BxXBZzZQqxhIP0AgBwY6ICAAZWNAA==
Date: Tue, 1 Feb 2022 08:56:49 +0000
Message-ID: <ef8feba1-695f-5cd6-bdf6-8ef6c55e62e1@epam.com>
References: <20211125110251.2877218-1-andr2000@gmail.com>
 <20211125110251.2877218-6-andr2000@gmail.com> <YeAPxA8gZZ/xBYdA@Air-de-Roger>
 <f4ea5ece-551e-8a91-90c6-d9f806c97d5b@epam.com>
In-Reply-To: <f4ea5ece-551e-8a91-90c6-d9f806c97d5b@epam.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: c4cb6705-38f5-41c5-235e-08d9e560c884
x-ms-traffictypediagnostic: DB7PR03MB3929:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <DB7PR03MB3929E4CAFB6E3E9B54CB79FFE7269@DB7PR03MB3929.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 1VpazAIX4YfeWvAY1UtflwSb4X42OMtVzu5IFOAqcoRI54k+9Wgjqxk4xpCDTGK/+lL03c+7fYxYBadlfVhfHqg3KswLkDYZgsH/pVySf8YCNMjhAq1CdVZS8/7bTNzZa9zhTMx2sXmXI13IGUKXd3u9SR5hLgg+5EYEAbHcZQ1cR3YU1lmWBJa0iSjH5lTRdWOHWhx1ANbECK1t4MrsFEFYx4i2zoj1DYgIDMszo2hAIrX3CDhnGELwadrJd2bNsTgay37RoG8q8lNe8jIAfhhhl+GQcfEI2yU8MeCE1O8pybMZytUykHARSTsjaMRGq2ZL3zeG8LojCwiB5J4NXVBi3IaBDpbsM7CNoh1ZBiMhJaYUOYQo1DmsZNy4TPv96K+YegoRafjOPpPrYajsWNgDhGW82mLVoFvBaJZ4G0sZ2eCVHXmLbVYa5y9OSXIVfwg7ERz9LKbqyQt7a8t5zuo7IA08UM/mHKFBbZ/rqSXPCaepgDuqmLkwW+MJXgx/XyPvhwjpw7bb7t5f4cm4fA6S7/+QLkiLRSIAnzQAfrP9+AtM3aCOaiV7IZsyImKzqSh6yalsBNf+74pffrQ6eIImL22twCkE3bQTkUJaSgrbEL/aorR62rDTmAT6VWvF1fUQ4v8JFegWcvnFH17Lw3j2Itc5uy6lBSyrKyKLg4zHaU2oxffyTnm9UfwqQRPA0HgAiOiUs5MFrYSN09sEzhT9fVAoN8KTEs5DQWICtTtTTaAmmzrVjFHvHlVVcFWl
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(316002)(107886003)(54906003)(6512007)(7416002)(508600001)(186003)(5660300002)(6916009)(26005)(31696002)(2616005)(86362001)(83380400001)(2906002)(66946007)(66556008)(6506007)(64756008)(76116006)(36756003)(8936002)(38070700005)(6486002)(66476007)(31686004)(71200400001)(91956017)(53546011)(38100700002)(4326008)(66446008)(122000001)(8676002)(45980500001)(20210929001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?K3JVdm8yNkxoeVZ0Y1FWc2lHWlF3aFNZQlB5Uk9xVDdadThXWEoyekxFUnNL?=
 =?utf-8?B?bytvOHJJekhremgxU3g5Q2tZRUJvZERuUGR5SDEvQ0QxQXRPVnJDeTM2M1NT?=
 =?utf-8?B?Z0E0ek1pcHBWc3RhUFhGRkREV2RscUpPTDlSNHRTeU8zRmhMZ1czVFhHbndJ?=
 =?utf-8?B?L05pZzM1N0hMa3AwaUc1MWMyRHRPSDJ4aDh0NmFSNHkvU1l5aG03TzlIL3dj?=
 =?utf-8?B?NzFFWUcrYVg1MnFHSm9wbW1tTHI0VDF1cnlTUlJWUTF5MitUeFRETEprZTQz?=
 =?utf-8?B?NFIyY01HN0tGV0gvdkIwcWVHL3FsVU9xZnp1MVFJWVUySExDZkVKY3BHWE9G?=
 =?utf-8?B?eUx1VFBIVnNIUVplcUhid2lwaG9yU2RTcS91TUZJWjZDaktySzR0SHp3eUk4?=
 =?utf-8?B?N0hKVno1cE1MQzcwcEJRRXNoemJsYU9KMEZOZndLRkJPdXZ2QnpXdHVoejU2?=
 =?utf-8?B?RHU1am5yY3hEZXBEZzFpZ3BIQzhhUTdxS1pyOERMRUF6Y3FiYnpkSCt3U0RH?=
 =?utf-8?B?aG5FdEVkdFBJelpuak55U0pZQUdSeUMybk4zSlBLcE5Zd0ZIUFJFMTNWWThJ?=
 =?utf-8?B?cEo3Q3hXQVF3VVV0MU5mTytSaDBpQUdWOUMwVGZPSE5PNlJXelhKZWttVUFL?=
 =?utf-8?B?L3BxejBSQTJMdkgrd3QyenBPelJpRlVrd1BTaWUxMGFOYkdyOWtkb2U2bUhY?=
 =?utf-8?B?V1hoZ1Vla3BxMThTdm1OMkpkQTgyQ0hYa2I2OWY4bE5ieURSbDROWmhzTGs2?=
 =?utf-8?B?QUdvMnh6YzJ0MTFYUW4vWkFkYkN0M3lwSlUvUDVOc2Q5dGNuVUlyMWw5ZVZT?=
 =?utf-8?B?cnYvbXVYN0xZZHg2RFBVaVdGUHB0UmN2Z0FoeDN4aHdBckd5MnYveFZtbW5r?=
 =?utf-8?B?ZW5kYTMzVW9tcWpqSVlqdDhLelJrVlVvMm9CZmwrWnQxRDlNYm8yYVUvelNH?=
 =?utf-8?B?aGtZdzVRdGdhUlJuTzllY3RWTnVucTNWRmVwby9PQWxUZlpxSlh0RUZ2N1ZR?=
 =?utf-8?B?RGFMR2NOdS9qcVZtelEwNXJ1ZStvL250Sm9lSWk1dUUvTk5CTlk3ZW5sclVK?=
 =?utf-8?B?OGJlRVg4OWlUSU1peHdRTFc3dVFwRUE0UG91TEpCODFKeWhVQU9kS3Q5QlFT?=
 =?utf-8?B?QXhmcERkWnV0dHBuZno1Mkh4UnlKRkJQZE92NWs2SmhSTUZVUGR6SzBOWGVm?=
 =?utf-8?B?V01FcWdNT1AxcGUxaU9oaXY0NVFsRk94SzBLVnpNdEdJYzBJRGJFd1RsQ0I4?=
 =?utf-8?B?Q093VHkreU4rck1XTjFyc2V0UHJHajFoaXZxQmRmc1J1YWM3azVDWWNFZHZQ?=
 =?utf-8?B?ckhqZjBmTTRieWE3L2dqMmhvZlZudU1aYXM0YnVkaVVVMmxEeTJXWG1HNTFX?=
 =?utf-8?B?QlNGYUU5blRVSXVyR1VhN1JsclVlVUJNRExqb3VPcEo4VjFYNUpkR1A5YjNk?=
 =?utf-8?B?c1lsbVJWQXdVaGRXM2NSRG5EdjZZZDg5QWtreXd5UUd3a1FnOWUxUGpZTzQ0?=
 =?utf-8?B?WVJ1Q2pjejZGbmJSVVBwL3lOdUJLRVFsbnZ4U1ZKMmhjY3dwRDFmclhaejNQ?=
 =?utf-8?B?anE5L24yQlNhN0VmMkFWS3REY2tySHczVFBidnRlTjVROS9VZ3NqM25OSXNI?=
 =?utf-8?B?WmR2Sm93VzJkNWFTeHZOcFp5WXo3Q2k2ZnpnVWxDTjVZSDJ6eUJVelJRSjZU?=
 =?utf-8?B?ME5JaDZJeE5nZ05JNWw0dWFybXBvWHJZOFMySkU3ZXI5U0RGczg1dkc5SlNx?=
 =?utf-8?B?TUNLdXFabGVBRThWdkRxV0hWN3BjbXJHejRhdEExYlRhQm5lOEx4ditQMHV5?=
 =?utf-8?B?YnBaZU5xcUpvOXp0aHZsbG5IUVh2VURjbHZNeFltRUgyZ0FHS0RNT0t3MVA0?=
 =?utf-8?B?dHhkNzkrTHB4Mk4wckNycjhTa2Z3OVFHUkRqZlNHaWg4WkUwd2JSVi8wQjNK?=
 =?utf-8?B?emJYYkNSbTZ0aXoxbDF4WHJsdjNJZ1B4TjdLRHQ3OUxQb1BLRFlVQThOc2xX?=
 =?utf-8?B?Qm5YV1lBcENXSytCWTEvYm4vWkdURmVWVXFqb0luZ1ozMWNrbnozZ3pSUVNv?=
 =?utf-8?B?M1JPNFRxM0pnbGx0M1dJa2tjZmFtWG1MN1RxMlZYZmYzR3Jaa1NvdCtVS3Bp?=
 =?utf-8?B?VDYxMFVmQk1iT0hSWnNvTnQyVndkdnk4dWlsTEZMeS9CQnhTVkJwSUkvWC84?=
 =?utf-8?B?ckdzekZBSXdKbWZPS1JTeEFGaGsxUDFPQUVrNjAxQ0RtdVFPam85QmlwSjlN?=
 =?utf-8?B?UGk2ek5FKzlWNzNjTHRubnRkdDN6aWJJci96N3RRSHVNOGs2ZXBVdFRmY2tq?=
 =?utf-8?B?b3VSQ0xBam9vek0wcUlEVEY2a1NhcFl1TWVRbExQaHJ3U3VGRy9MQT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <1E5FE73DAFC72042A45F4426C3336061@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c4cb6705-38f5-41c5-235e-08d9e560c884
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Feb 2022 08:56:49.2110
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: SU8tTIZZa3ylKQc/dwum49IKy96O5E0hTxqb0yAuTx8WtsZbBwf3MU6cNS+QypDzba/PyB/FR6Tm6B3JNLYwQeGlqmCRnUD4Cxx209j7VAMHwLbNX9q57WyUMkhRNDaz
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR03MB3929
X-Proofpoint-GUID: iElkrQrFAetVdpzHuEuv47a_DAXaf3za
X-Proofpoint-ORIG-GUID: iElkrQrFAetVdpzHuEuv47a_DAXaf3za
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-01_03,2022-01-31_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501
 clxscore=1015 lowpriorityscore=0 mlxscore=0 adultscore=0 malwarescore=0
 mlxlogscore=999 impostorscore=0 spamscore=0 bulkscore=0 phishscore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202010048

SGksIFJvZ2VyIQ0KDQpPbiAzMS4wMS4yMiAxMDo0NSwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28g
d3JvdGU6DQo+IEhpLCBSb2dlciENCj4NCj4gT24gMTMuMDEuMjIgMTM6NDAsIFJvZ2VyIFBhdSBN
b25uw6kgd3JvdGU6DQo+PiBPbiBUaHUsIE5vdiAyNSwgMjAyMSBhdCAwMTowMjo0MlBNICswMjAw
LCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyB3cm90ZToNCj4+PiBGcm9tOiBPbGVrc2FuZHIgQW5k
cnVzaGNoZW5rbyA8b2xla3NhbmRyX2FuZHJ1c2hjaGVua29AZXBhbS5jb20+DQo+Pj4gKyNpZmRl
ZiBDT05GSUdfSEFTX1ZQQ0lfR1VFU1RfU1VQUE9SVA0KPj4+ICsvKiBOb3RpZnkgdlBDSSB0aGF0
IGRldmljZSBpcyBhc3NpZ25lZCB0byBndWVzdC4gKi8NCj4+PiAraW50IHZwY2lfYXNzaWduX2Rl
dmljZShzdHJ1Y3QgZG9tYWluICpkLCBzdHJ1Y3QgcGNpX2RldiAqcGRldikNCj4+PiArew0KPj4+
ICsgICAgaW50IHJjOw0KPj4+ICsNCj4+PiArICAgIC8qIEl0IG9ubHkgbWFrZXMgc2Vuc2UgdG8g
YXNzaWduIGZvciBod2RvbSBvciBndWVzdCBkb21haW4uICovDQo+Pj4gKyAgICBpZiAoIGlzX3N5
c3RlbV9kb21haW4oZCkgfHwgIWhhc192cGNpKGQpICkNCj4+PiArICAgICAgICByZXR1cm4gMDsN
Cj4+PiArDQo+Pj4gKyAgICBzcGluX2xvY2soJnBkZXYtPnZwY2lfbG9jayk7DQo+Pj4gKyAgICBy
YyA9IHJ1bl92cGNpX2luaXQocGRldik7DQo+PiBGb2xsb3dpbmcgbXkgY29tbWVudCBiZWxvdywg
dGhpcyB3aWxsIGxpa2VseSBuZWVkIHRvIGNhbGwNCj4+IHZwY2lfYWRkX2hhbmRsZXJzIGluIG9y
ZGVyIHRvIGFsbG9jYXRlIHRoZSBwZGV2LT52cGNpIGZpZWxkLg0KPj4NCj4+IEl0J3Mgbm90IE9L
IHRvIGNhcnJ5IHRoZSBjb250ZW50cyBvZiBwZGV2LT52cGNpIGFjcm9zcyBkb21haW4NCj4+IGFz
c2lnbmF0aW9ucywgYXMgdGhlIGRldmljZSBzaG91bGQgYmUgcmVzZXQsIGFuZCB0aHVzIHRoZSBj
b250ZW50IG9mDQo+PiBwZGV2LT52cGNpIHdvdWxkIGJlIHN0YWxlLg0KPj4NCj4+PiArICAgIHNw
aW5fdW5sb2NrKCZwZGV2LT52cGNpX2xvY2spOw0KPj4+ICsgICAgaWYgKCByYyApDQo+Pj4gKyAg
ICAgICAgdnBjaV9kZWFzc2lnbl9kZXZpY2UoZCwgcGRldik7DQo+Pj4gKw0KPj4+ICsgICAgcmV0
dXJuIHJjOw0KPj4+ICt9DQo+Pj4gKw0KPj4+ICsvKiBOb3RpZnkgdlBDSSB0aGF0IGRldmljZSBp
cyBkZS1hc3NpZ25lZCBmcm9tIGd1ZXN0LiAqLw0KPj4+ICtpbnQgdnBjaV9kZWFzc2lnbl9kZXZp
Y2Uoc3RydWN0IGRvbWFpbiAqZCwgc3RydWN0IHBjaV9kZXYgKnBkZXYpDQo+Pj4gK3sNCj4+PiAr
ICAgIC8qIEl0IG9ubHkgbWFrZXMgc2Vuc2UgdG8gZGUtYXNzaWduIGZyb20gaHdkb20gb3IgZ3Vl
c3QgZG9tYWluLiAqLw0KPj4+ICsgICAgaWYgKCBpc19zeXN0ZW1fZG9tYWluKGQpIHx8ICFoYXNf
dnBjaShkKSApDQo+Pj4gKyAgICAgICAgcmV0dXJuIDA7DQo+Pj4gKw0KPj4+ICsgICAgc3Bpbl9s
b2NrKCZwZGV2LT52cGNpX2xvY2spOw0KPj4+ICsgICAgdnBjaV9yZW1vdmVfZGV2aWNlX2hhbmRs
ZXJzX2xvY2tlZChwZGV2KTsNCj4+IFlvdSBuZWVkIHRvIGZyZWUgdGhlIHBkZXYtPnZwY2kgc3Ry
dWN0dXJlIG9uIGRlYXNzaWduLiBJIHdvdWxkIGV4cGVjdA0KPj4gdGhlIGRldmljZSB0byBiZSBy
ZXNldCBvbiBkZWFzc2lnbiwgc28ga2VlcGluZyB0aGUgcGRldi0+dnBjaSBjb250ZW50cw0KPj4g
d291bGQgYmUgd3JvbmcuDQo+IFN1cmUsIEkgd2lsbCByZS1hbGxvY2F0ZSBwZGV2LT52cGNpIHRo
ZW4NCkFmdGVyIHRoaW5raW5nIGEgYml0IG1vcmUgb24gdGhpcyBJIGhhdmUgcmVhbGl6ZWQgdGhh
dCB3ZSBjYW5ub3QgZnJlZQ0KcGRldi0+dnBjaSBvbiBkZS1hc3NpZ24uIFRoZSByZWFzb24gZm9y
IHRoYXQgaXMgdGhlIGZhY3QgdGhhdCB2cGNpDQpzdHJ1Y3R1cmUgY29udGFpbnMgdml0YWwgZGF0
YSB3aGljaCBpcyBjb2xsZWN0ZWQgYW5kIG1hbmFnZWQgYXQgZGlmZmVyZW50DQpzdGFnZXM6IGZv
ciBleGFtcGxlLCBCQVIgdHlwZXMgYXJlIGNvbGxlY3RlZCB3aGlsZSB3ZSBydW4gZm9yIHRoZQ0K
aGFyZHdhcmUgZG9tYWluIGFuZCBpbiBpbml0X2JhcnMgd2UgY29sbGVjdCB0aGUgdHlwZXMgb2Yg
dGhlIEJBUlMgZXRjLg0KVGhpcyBpcyB0aGVuIHVzZWQgd2hpbGUgYXNzaWduaW5nIGRldmljZSB0
byBjb25zdHJ1Y3QgZ3Vlc3QncyByZXByZXNlbnRhdGlvbg0Kb2YgdGhlIGRldmljZS4gRnJlZWlu
ZyB2cGNpIHdpbGwgbGVhZCB0byB0aGF0IGRhdGEgaXMgbG9zdCBhbmQgdGhlIHJlcXVpcmVkDQpk
YXRhIGlzIG5vdCBwb3B1bGF0ZWQgaW50byB2cGNpLg0KU28sIGl0IGlzIG5vIHBvc3NpYmxlIHRv
IGZyZWUgdnBjaSBzdHJ1Y3R1cmUgYW5kIEkgYW0gYWJvdXQgdG8gbGVhdmUgdGhlDQphcHByb2Fj
aCBhcyBpdCBpcy4NCj4+IFRoYW5rcywgUm9nZXIuDQo+IFRoYW5rIHlvdSwNCj4gT2xla3NhbmRy
DQpUaGFuayB5b3UsDQpPbGVrc2FuZHI=


From xen-devel-bounces@lists.xenproject.org Tue Feb 01 09:01:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 01 Feb 2022 09:01:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.263442.456133 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEp2F-0001qG-5B; Tue, 01 Feb 2022 09:01:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 263442.456133; Tue, 01 Feb 2022 09:01:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEp2F-0001q9-20; Tue, 01 Feb 2022 09:01:11 +0000
Received: by outflank-mailman (input) for mailman id 263442;
 Tue, 01 Feb 2022 09:01:10 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nEp2D-0001pz-Va; Tue, 01 Feb 2022 09:01:09 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nEp2D-0007dw-Rr; Tue, 01 Feb 2022 09:01:09 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nEp2D-0000bj-8p; Tue, 01 Feb 2022 09:01:09 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nEp2D-0003OL-8O; Tue, 01 Feb 2022 09:01:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=/tuZsgnBTSRNRc8rbZnWaowPxeB9f5q4D2MMCsd5uzY=; b=Lcl7RWABK22xr8Dg33SiwDPY9B
	lue4qYdDzHDIsqZDDMpBzOtUxLjWBs5QXZczMjIWsCbyDPts6JM2dGkCDXmsmyV4/Y5zoQH7w8RxY
	phQ/HPrGVQNxfZ0ydglNCkc2FBrAWu8TOEL5kcV3JfsPVwHDrKPWACYKdcU4i88E1ZcU=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167968-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 167968: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-armhf-armhf-xl-credit1:xen-boot:fail:heisenbug
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=804b30d25f8d70dc2dea951883ea92235274a50c
X-Osstest-Versions-That:
    qemuu=bfc3db5cf64ab538d6b3c56eab6423372758b258
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 01 Feb 2022 09:01:09 +0000

flight 167968 qemu-mainline real [real]
flight 167972 qemu-mainline real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/167968/
http://logs.test-lab.xenproject.org/osstest/logs/167972/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-armhf-armhf-xl-credit1   8 xen-boot            fail pass in 167972-retest

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-xl-credit1 15 migrate-support-check fail in 167972 never pass
 test-armhf-armhf-xl-credit1 16 saverestore-support-check fail in 167972 never pass
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167959
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167959
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167959
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167959
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167959
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167959
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167959
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167959
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                804b30d25f8d70dc2dea951883ea92235274a50c
baseline version:
 qemuu                bfc3db5cf64ab538d6b3c56eab6423372758b258

Last test of basis   167959  2022-01-30 19:39:38 Z    1 days
Testing same since   167968  2022-01-31 19:38:15 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alexey Kardashevskiy <aik@ozlabs.ru>
  Christophe Leroy <christophe.leroy@csgroup.eu>
  Cédric Le Goater <clg@kaod.org>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Fabiano Rosas <farosas@linux.ibm.com>
  Frederic Barrat <fbarrat@linux.ibm.com>
  Peter Maydell <peter.maydell@linaro.org>
  Philippe Mathieu-Daudé <f4bug@amsat.org>
  Vitaly Cheptsov <cheptsov@ispras.ru>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   bfc3db5cf6..804b30d25f  804b30d25f8d70dc2dea951883ea92235274a50c -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Tue Feb 01 09:02:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 01 Feb 2022 09:02:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.263453.456144 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEp3k-0002Vb-NO; Tue, 01 Feb 2022 09:02:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 263453.456144; Tue, 01 Feb 2022 09:02:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEp3k-0002VU-Io; Tue, 01 Feb 2022 09:02:44 +0000
Received: by outflank-mailman (input) for mailman id 263453;
 Tue, 01 Feb 2022 09:02:43 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=JH7e=SQ=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nEp3j-0002VL-Kp
 for xen-devel@lists.xenproject.org; Tue, 01 Feb 2022 09:02:43 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b68a112c-833d-11ec-8f75-fffcc8bd4f1a;
 Tue, 01 Feb 2022 10:02:42 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id ACFFE1F383;
 Tue,  1 Feb 2022 09:02:41 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7239513D18;
 Tue,  1 Feb 2022 09:02:41 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id LFiBGjH3+GGDYwAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 01 Feb 2022 09:02:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b68a112c-833d-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1643706161; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=m5vs36ER6Ri+BF1FUM6MMCWIEyXsaWVxNJYgwdpcovk=;
	b=k5swS/JBANgnOCvLSvxcZcxheBngpIq38q2sYUkfT3NDGG1zCZM4MDHslygdI0opsUv7xN
	a2IGscq+08Ssk8ksjdpOTDV+oy9JKfTVP30oZYq2rWVrEd1D40+vYoPkhKpQLbFzSR5V4v
	9Kpdm5/psKL69xOS8EWNL2BwQoOPEqg=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>
Subject: [PATCH] xen: add option to disable GNTTABOP_transfer
Date: Tue,  1 Feb 2022 10:02:39 +0100
Message-Id: <20220201090239.32067-1-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

The grant table operation GNTTABOP_transfer is meant to be used in
PV device backends, and it hasn't been used in Linux since the old
Xen-o-Linux days.

Add a command line sub-option to the "gnttab" option for disabling the
GNTTABOP_transfer functionality.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 docs/misc/xen-command-line.pandoc | 7 +++++--
 xen/common/grant_table.c          | 6 ++++++
 2 files changed, 11 insertions(+), 2 deletions(-)

diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc
index 6b3da6ddc1..97ddcfa523 100644
--- a/docs/misc/xen-command-line.pandoc
+++ b/docs/misc/xen-command-line.pandoc
@@ -1167,9 +1167,9 @@ does not provide `VM_ENTRY_LOAD_GUEST_PAT`.
 Specify which console gdbstub should use. See **console**.
 
 ### gnttab
-> `= List of [ max-ver:<integer>, transitive=<bool> ]`
+> `= List of [ max-ver:<integer>, transitive=<bool>, transfer=<bool> ]`
 
-> Default: `gnttab=max-ver:2,transitive`
+> Default: `gnttab=max-ver:2,transitive,transfer`
 
 Control various aspects of the grant table behaviour available to guests.
 
@@ -1178,6 +1178,9 @@ version are 1 and 2.
 * `transitive` Permit or disallow the use of transitive grants.  Note that the
 use of grant table v2 without transitive grants is an ABI breakage from the
 guests point of view.
+* `transfer` Permit or disallow the GNTTABOP_transfer operation of the
+grant table hypercall.  Note that disallowing GNTTABOP_transfer is an ABI
+breakage from the guests point of view.
 
 The usage of gnttab v2 is not security supported on ARM platforms.
 
diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c
index ed1e2fabce..d1c225e927 100644
--- a/xen/common/grant_table.c
+++ b/xen/common/grant_table.c
@@ -181,6 +181,7 @@ static int parse_gnttab_max_maptrack_frames(const char *arg)
 
 unsigned int __read_mostly opt_gnttab_max_version = GNTTAB_MAX_VERSION;
 static bool __read_mostly opt_transitive_grants = true;
+static bool __read_mostly opt_grant_transfer = true;
 
 static int __init parse_gnttab(const char *s)
 {
@@ -204,6 +205,8 @@ static int __init parse_gnttab(const char *s)
         }
         else if ( (val = parse_boolean("transitive", s, ss)) >= 0 )
             opt_transitive_grants = val;
+        else if ( (val = parse_boolean("transfer", s, ss)) >= 0 )
+            opt_grant_transfer = val;
         else
             rc = -EINVAL;
 
@@ -2233,6 +2236,9 @@ gnttab_transfer(
     unsigned int max_bitsize;
     struct active_grant_entry *act;
 
+    if ( !opt_grant_transfer )
+        return -ENOSYS;
+
     for ( i = 0; i < count; i++ )
     {
         bool_t okay;
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Tue Feb 01 10:02:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 01 Feb 2022 10:02:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.263464.456154 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEpza-00006L-AM; Tue, 01 Feb 2022 10:02:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 263464.456154; Tue, 01 Feb 2022 10:02:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEpza-00006E-7D; Tue, 01 Feb 2022 10:02:30 +0000
Received: by outflank-mailman (input) for mailman id 263464;
 Tue, 01 Feb 2022 10:02:28 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JAuK=SQ=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nEpzY-000068-AY
 for xen-devel@lists.xenproject.org; Tue, 01 Feb 2022 10:02:28 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0ce21321-8346-11ec-8eb8-a37418f5ba1a;
 Tue, 01 Feb 2022 11:02:24 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0ce21321-8346-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1643709744;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=djRUHFWjamzIyLlwoUItDL9+3Fxg9KgSJvzqlncOssQ=;
  b=RwanlIuEu+ppYz39Wb9H127NrEd215D4QQuPvov1YnS2lFEUIeVU2WMG
   jZ8wiLcQJ5U0uiFkmlDeEWRKC7vSXGFHDGHmQ6sDvT7h4Vbg9fBsEdxj2
   p1MGgBzwdqe/U+a6fBmTyhedQ7LlyAlKEEAOZQS3yT2dwpep0SACxQSp+
   I=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: 83hICaJL37zx4bNXxlqvD5MqOUCuRDQBBCV2wBQ6mdtksAQopDS2pRXiO53GpPJ+xK12tbgRpM
 KfKHMMbd3uOLh1fR4ndqyejAyBlqI3FC+OjwM+UI+oBRp+OxsL6QKCYnt07k1c/EHi7HKMJdgz
 yY7ci7Hg/CImHaPIx8PiXhTKx4jVime6OTXuJEs4qa7ouhgFOWwnAQIcvjeQLSALMVKrbXOjFh
 nWQbpZH3B6so8i5n3UPOA+hZs5ZOHtpOnmaPL2Xrh8+fKWhbLnO4QwScEMmcjUSekq3wVUJnNA
 DM86lsu4ROGt069F6IMwIoli
X-SBRS: 5.2
X-MesageID: 62667785
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:+jdoJKBvAEPakxVW/2Xlw5YqxClBgxIJ4kV8jS/XYbTApDJwhDwDz
 WseXzqAPa6NNGXwc9h2ao6+/UJXsJLTyNJnQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMo/u1Si6FatANl1ElvU2zbue6WL6s1hxZH1c+En970Us7wobVv6Yz6TSHK1LV0
 T/Ni5W31G+Ng1aY5UpNtspvADs21BjDkGtwUm4WPJinj3eH/5UhN7oNJLnZEpfNatI88thW5
 Qr05OrREmvxp3/BAz4++1rxWhVirrX6ZWBihpfKMkQLb9crSiEai84G2PQghUh/ujbOtNBU1
 YV2pcKiRiMpAqTnsccbekwNe81+FfUuFL7vJHG+tYqYzlHccmuqyPJrZK00FdRGoKAtWzgIr
 KFGbmBWBvyAr7veLLaTUO5ji95lNMD2FIgepmth3XfSCvNOrZXrHf+Uu4AHjGpYasZmJ87mR
 JMDMTxWQh2QcR99P0gvVJlgk7L97pX4W2IB8w/EzUYt2EDI1xB42rXpNNvTe/SJSN9Tk0Leo
 XjJl0z7HxUbOdq32TeDtHW2iYfnoyT/X44DEayiwdRjilaT2287BQUfUB2wpvzRokK3Rd93M
 UEf/Ssq668o+ySDUd3VTxC+5nmesXY0S9dWVuE39gyJ4q7V+BqCQHgJSCZbb94rv9NwQiYlv
 neLld70AT1ksJWOVGmQsLyTqFuaOycPKnQZTTQZVgZD6N7myLzflTqWEIwlSvTsyISoR3egm
 FhmsRTSmZ0ijokg14CmrWvX3SCjgpj1RyUcxQP+CzfNAhxCWKapYImh6F7+5PlGLZqEQlTpg
 EXoi/Ry/8hVU8jTyXXlrPElWejwuq3baGG0bUtHQsF5nwlB7UJPamy5DNtWAE5yevgJdjbyC
 KM4kVMAvcQDVJdGgEIeXm5QNyjI5fW6fTgGfqqNBjarXnSXXFXdlM2JTRXIt10BaGB2zckC1
 W6zKK5A90oyB6V91yaRTOwAy7ItzS1W7TqNGcumn0v/geTPOC/9pVI53L2mNLpRAESs+129z
 jqiH5HSl0U3vBPWP0E7DrL/3XhVdCNmVPgaWuRcd/KZIxoOJY3SI6S5/F/VQKQ8x/49vr6Rp
 hmVAxYEoHKi2yGvAVjUOxhLNeO+Nb4i/ClTFXF9Yj6VN40LPNzHAFE3LcVnJNHKNYVLkJZJc
 hXyU5zeWqwREmiWpGV1gFuUhNUKSSlHTDmmZkKNSDM+Y4RhV0rO/NrldRHo7y4AEmy8ss5Wn
 lFq/lqzrUMrS1swAcDIRuioyl/t73ERlPgrBxnDI8VJeVWq+49vcnSjgvgyKsAKCBPC2jrFi
 FrGXUZG/bHA890v7d3EpaGYtIP1QeFwKVVXQjvA5rGsOCiEomf6md1cUPyFdCz2XX/v/Pnwf
 v1cyvzxaaVVnFtDv4dmPaxsyKYyu4nmq7NAl1w2F3TXdVW7TLhnJyDej8VIs6RMwJ5fuBe3B
 R3TqoULZ+3RNZq8QlALJQcjYuCS7t0um2HfvaYvPUH3xC5r577bA09cCAaB1X5GJ7xvPYJ7n
 ep44JwK6xaygwYBO8qdinwG7HyFK3ENXvl1tpweB4O32AMnxksbPM7ZAy7yppqOd89NIg8hJ
 TrN3PjOgLFVx0zjdXsvFCeSgboB1MpW4B0ankUfI1mpm8begq5l1RJcxj07UwBJw0gVyOl0I
 GVqaxV4KKjmE+2EXySfs7RAwz18OSA=
IronPort-HdrOrdr: A9a23:SqiMJ6O92VFZQMBcT07155DYdb4zR+YMi2TDiHoddfUFSKalfp
 6V98jzjSWE8Ar5K0tQ4uxoWZPwCk80kKQY3WB/B8bHYOCLggqVxcRZnPLfKl7bamfDH4xmpM
 BdmsFFYbWeY2SSz/yKhjVQeOxQo+VvhZrY4Ns2uE0dLz2CBZsB0y5JTiKgVmFmTghPApQ0UL
 CG4NBcmjamcXMLKuymG3gsRYH41pH2vaOjRSRDKw8s6QGIgz/twqX9CQKk0hAXVC4K6as+8F
 LCjxfy6syYwr6GI17npiHuBqZt6ZvcI+h4dY+xYw8uW3fRYzOTFcVcsnu5zXUISa+UmRIXeZ
 L30m0d1oxImg7slyeO0FbQMkDboUoTwm6nxlmCjXT5p8vlADo8FspanIpcNgDU8kw6obhHod
 R2Nk+ixu5q5Cn77VPADhnzJmFXv1vxpWBnnf8YjnRZX4dbYLhNrZYH9EcQFJsbBir15I0uDe
 ErVajnlb5rWELfa2qcsnhkwdSqUHh2FhCaQlIassjQ1zRNhnh2w0YR2cRalHYd85A2TYVC+o
 3/Q+1VvaALStVTYbN2Be8HT8fyAmvRQQjUOGbXOljjHLFvAQO5l3c22sRG2AiHQu138HICou
 WzbLoDjx9MR6vHM7z+4KF2
X-IronPort-AV: E=Sophos;i="5.88,333,1635220800"; 
   d="scan'208";a="62667785"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=KwB/rre9aJDmf0I7YzgyDQkeSQ9RekIClmf3hVY01XijuUKf5yU0my00nulg3Wxg6fczkKRc3DGodiz2RowESvMvRloqDa2TO0P3yfsw/CE9NXOFu5FM4B/b5SQIZ8HiX+RzrxIRmnl1e8TdMQsL0N5rhop/WxQTpL57AaqCcYbgugN/IyB0qXQhMsxhY8wQbzM4vREtuMdI8q2f5GHgP/FWvY5w/eYV81zwcx+lS/GWFWrXqxW6Mjg50XyX7/pvWXrZoAmLOoIEK8VOEsKMTazhDPYZJ/AATpZD3vL6nUlMO3FOsg1Je0IlTKS1rZwwcRuwG8M9K0HxddI6bsVkbA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=/JW+YNALTjq8moTTfGgA6NTQWmqlSAMdPhXqxjbZ8u8=;
 b=OHPUnxZHKywdg6I/vH1ld65T8fPgJHcjoKgCOiKr5jcDoL8FMEvvU7EcbYhKSOE+7giMO/ayTOzuZTpcnobwGCv7NdJqU838h2Ka7Qy5LkaVcesxrNDio6DocMDPo3Kwo/9WAU9LoEgRymTHVQpDW3GfuexsDhBmOionJZV+qUVf4LV2bb2kr8JVJTIMmwDIUuYnFjHieEdFoOzUROCHvPrAoQPkzL09dnQxR5PKtR7RT+CKU7a/PeS0L/D1UobrVeDmMJ6WyyeqmcK8v/OV7ArMcjPc43WF334OMhxiu/ZOdOjtmGxUqIS2DBjoVGj7WvAFZSfbj7r1p2nTDint8A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=/JW+YNALTjq8moTTfGgA6NTQWmqlSAMdPhXqxjbZ8u8=;
 b=fQxzDKnNOmNv23I+Zi2FR11zs9zaKX4r/nYdc4+ZB/o6ry4HNwbRRZx4lf1JQsVBnA2RZ8RGK/PP9Tfa3frwL+ziEJnybKshXnGDJEyrNbCwz4u4HEYMBzGdN0S77T4q7qA9a86s8vG7GtTzwJs59LuG85d7krSOWhozatjI09o=
Date: Tue, 1 Feb 2022 11:02:13 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jane Malalane <jane.malalane@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>, Anthony
 PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, Andrew
 Cooper <andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>, Stefano
 Stabellini <sstabellini@kernel.org>, Christian Lindig
	<christian.lindig@citrix.com>, David Scott <dave@recoil.org>, Volodymyr
 Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH 2/2] x86/xen: Allow per-domain usage of hardware
 virtualized APIC
Message-ID: <YfkFJTYXa/7DSTaI@Air-de-Roger>
References: <20220127160133.11608-1-jane.malalane@citrix.com>
 <20220127160133.11608-3-jane.malalane@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220127160133.11608-3-jane.malalane@citrix.com>
X-ClientProxiedBy: LO4P123CA0296.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:196::13) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: bfb0ed65-c189-4bd2-0fc6-08d9e569ee69
X-MS-TrafficTypeDiagnostic: SA2PR03MB5770:EE_
X-Microsoft-Antispam-PRVS: <SA2PR03MB57705C06A8A3ABA55FAFAC088F269@SA2PR03MB5770.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: am58JiogCVHb7hG90ZybG3WEvHgLZjQRPBXGMSyezcIIQFzuZJgMePuFZhyo9ryusgLaxDjwHBHa941YuStimBili/NMQmzhm4Gg45RmfSZvmva8qIXTpil1D9pEAQjNJ5mVPQnHdqOtKb/jAk8vMmUFc9Ea48jKNnWhNHJEiDZ48mBEyhuvDl/v2+EEPUbKluXlvRU46DejaP+T3Gcg160itdCIrCXo74V+Pzu69HmcSfpu73V6pK6cUy0qM6t0pbQTDs5Ite/ICMabo5RzwbnYs3osNc9fFlVNIXjXlcEAfnDBok7fXxTRrtWOnuPRnpOVKva8B/aLY2e7m7wJIrAG1460UUqD3Q4g6R3kBRTVvZo4Lom6LfyB8TETEs+IGKg0HvTo24NPVfzlQmJSy/LB8D1GfGSsmvsEbWeGt8YQn0Yy1v6WlvD07gkVLXhwYWQktJictsOb8RHpZPnnZp7VhnrlHR0Knw8+ITM8NI3SAKdadQyxFRUL4QWopV52Hh0mhq1mMkk4bBjwACgti4pdAlfIMuwhuR05GQSoIyrpr5Lbe6WuPLiUD0Ol97QCEdZ+nadecN/iXWj1sY6Wqe20hDlWHwaNHeYQhIIYw7RKk4ls6V0mesDnhyGq3w8gMmBPefiqJTvVAIoXKTry0w==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(54906003)(6862004)(66476007)(8676002)(86362001)(30864003)(4326008)(33716001)(83380400001)(66946007)(5660300002)(9686003)(316002)(8936002)(6512007)(85182001)(6636002)(2906002)(66556008)(6506007)(6486002)(6666004)(38100700002)(26005)(186003)(82960400001)(508600001)(20210929001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TTNpMGFheDFMN1FCblhMWjNQQThtYjFLdEJyVmRpVysvM3NMOVVPQ0k4ZE5T?=
 =?utf-8?B?bGdoVlJRRStSMXBVejZqRjU5RXhzdVVFL201a0ZxZUg4WGljZFR1OTMwUU9n?=
 =?utf-8?B?VGFpdlEwNlJZTENGZlVRd2tiZFd6SUUwRU1xcExlc3E2YmVpbktkMDFOY3dD?=
 =?utf-8?B?ZGg0eHRwMml3OWJ4OGVDb1RvWmx3NVhkeE9WbEErYjR2V1pCOHhhdzRObWI4?=
 =?utf-8?B?cGdKeGhIVG1BZnRCajh2TzJUTllKZzB4c2FvdDVkNUxSOWEwaGswRXpOc1ls?=
 =?utf-8?B?SS9zSGU2S01YSUtqZTFmSEFUZ0R3U1BHNGZsSDR0T1NVUEl1bjlycjVEVzNp?=
 =?utf-8?B?OEZ3VUdOSVowcDNaNENKNzZmT3lJMWp0b1R2ckh3enVjazJUTXFmRWFhQnFY?=
 =?utf-8?B?QUU1ZlhmV2hjdjJWMFVmUmVWa1AwNk1EQ2lodUJvNURUT3AzUyttRjFCV0pj?=
 =?utf-8?B?eUpSRFE5SmliQmdyN2RvWUVIckJ1cHhMMzlCYnBsL04wMmIyd0IwUGJZR3hh?=
 =?utf-8?B?aE1DWHJhYkkzK3VlM2NnNlIvcndsY3hHbm1kRTlCMmxmVHhJTFB3Z2Rqb2J6?=
 =?utf-8?B?RDFqd2dVVE5zdXozUEpISHY1ZHdCNng0WHcreTNjMmVHK01TYURMbC9JbWtW?=
 =?utf-8?B?NmkrZkEzcTZFVDdrRnVrTEovY3Vva1VwMFU5akpoRkRHNm94UVJGV1lWY2N6?=
 =?utf-8?B?ajZzVjVjV2Y4Z243S1pDR2ErTTFMNnZFUndlUmczUCtEMHM2QnRZc2FSOWd6?=
 =?utf-8?B?MWFiRFZyZC9GVm5uL2RaL0svNkVHUG9lR2NtRmorQ2lRSFNyZ3lVWElYZFA0?=
 =?utf-8?B?ZjNFK0xhdXlBNVcvMGYzQnFNTGdyQlFCZTRFcXZMSW5NWTJTK2ZRSDE0bG8y?=
 =?utf-8?B?WTN5N0poaXRRNnpNQ3dwQW5HS0MxZ1RVbmwyb3lEOGtKc1U5RmQ1NXpjQ0lz?=
 =?utf-8?B?YlozZmdYdTlCQTRtc0JnT3Jxd0E2N25IcGxVNXRlckpYWFFQZUdQU3dnS1hq?=
 =?utf-8?B?d3o1VjZmOGVIS2hhQ3NoUEM2OXc0V3VkeXhjU3duZG10SnhSUm5pNU1MenUy?=
 =?utf-8?B?MFZwSEkwTUtyV3orSWhOa3JCZHU3Y3NPdW4zU3FKRjRyR2R3VEVaUWdWZTc1?=
 =?utf-8?B?M1dEZjg1UDByTUNqTzJkdWlvT0JNeXRMLy9RaUc0OEM4OXpLZWl3UmREZFh0?=
 =?utf-8?B?WTVMK25Za1JmTjdTWit2czF6eWVOWEZyVXZSN285MzJ0elJ5ajlZVlFjRmg4?=
 =?utf-8?B?VnVJanhNSjZIalRNR25MUmVjRmZ0SDQ0TjFCaTJQVDhvazlhR1BIT2hETGdJ?=
 =?utf-8?B?SWdEcW1YdkVsUjNEYUY5Mi9Bbm10SklIM1IrcG5LU0F5N1BVYzVsaVFIQTlu?=
 =?utf-8?B?TUNYamJlNkJXdHVLSmJ0cW1oWU5zT3doRGlweWN2OGZ5SFQwYWJEWi9IU2dx?=
 =?utf-8?B?a0JGQTJ1dXlpbHRzbk01QTNDY3JNekpFWlVrcnlmT2FMRmJGRUdKcVZIMS9i?=
 =?utf-8?B?aFlIZlJvU25pLzdMQ1B6RlNpdTY2R214VUVtMEFXVzdZdDRoMXlTbmczM1oz?=
 =?utf-8?B?MWllcm5kNldmcmRzRkxLQWxpaVUyL3NkRlBtNEg3SEh1NXZSdjgwamdSb1dV?=
 =?utf-8?B?amI5ZDRTejgrR0hnMk9NZ1dxU3htY0JIRUlhWExHT0l2SVh0anpBOU03cld3?=
 =?utf-8?B?b0Q4a1NaMzc2bTBqK2xVTjNta2ZwK2hZSTZZVHRuemF3enBWdXFJSGg4bGI4?=
 =?utf-8?B?M29FMXZyeVoxMWxFYUxEVnZlSUc5bDVTWW5wVHlrWktrQ1IreHYyYkhYOVEv?=
 =?utf-8?B?VHFsV3JyYW9MeW5idVBMS29rMEYwN0J2NWJTZDRzaEJNV2tRSU51RnIwOGlN?=
 =?utf-8?B?UHdPVGl0ZDJCL1orc1VJamVBRXYwdXBOYnpmNGhMaFh3STJIMnhWYkplWWdx?=
 =?utf-8?B?MlZzL3RFQVVPU1lQREdNYlhjOXhpZVBzY01WSk1NQ3dUWG5YcFRRRVQ0aTVE?=
 =?utf-8?B?aEFqNDZPOTF5Z0hyYkpURjg1TFE3ZjB6ZWJ2QkhXc0dCaG1IZVcySWtYeE0v?=
 =?utf-8?B?Q2pQQVVCSEM4d3Q3dmxpMVVJcmtmQ2ZidG9xK3RHVFBUU3Vhb0UreHlrRXpV?=
 =?utf-8?B?M1JnMXI3ZlpGVmNHMUozTUhiUVRuNkkvOUt2Q01QTHlOakxNVzFGMXhWYWxr?=
 =?utf-8?Q?AybUPMvKDWf5j6+Hfbu4pIg=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: bfb0ed65-c189-4bd2-0fc6-08d9e569ee69
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2022 10:02:18.6806
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fjc2SgUMr8trTHJt91Rangmakw9m/JqzPxCLJy5XUprBu9q2R9U7dgM0A8hOlDB9rzt/62QMnU1FI/A7oqHnfg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR03MB5770
X-OriginatorOrg: citrix.com

On Thu, Jan 27, 2022 at 04:01:33PM +0000, Jane Malalane wrote:
> Introduce a new per-domain creation x86 specific flag to
> select whether hardware assisted virtualization should be used for
> x{2}APIC.
> 
> A per-domain option is added to xl in order to select the usage of
> x{2}APIC hardware assisted vitualization, as well as a global
> configuration option.
> 
> Having all APIC interaction exit to Xen for emulation is slow and can
> induce much overhead. Hardware can speed up x{2}APIC by running APIC
> read/write accesses without taking a VM exit.
> 
> Signed-off-by: Jane Malalane <jane.malalane@citrix.com>
> Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
> ---
> CC: Wei Liu <wl@xen.org>
> CC: Anthony PERARD <anthony.perard@citrix.com>
> CC: Juergen Gross <jgross@suse.com>
> CC: Andrew Cooper <andrew.cooper3@citrix.com>
> CC: George Dunlap <george.dunlap@citrix.com>
> CC: Jan Beulich <jbeulich@suse.com>
> CC: Julien Grall <julien@xen.org>
> CC: Stefano Stabellini <sstabellini@kernel.org>
> CC: Christian Lindig <christian.lindig@citrix.com>
> CC: David Scott <dave@recoil.org>
> CC: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
> CC: "Roger Pau Monné" <roger.pau@citrix.com>
> ---
>  docs/man/xl.cfg.5.pod.in              | 10 ++++++++
>  docs/man/xl.conf.5.pod.in             | 12 ++++++++++
>  tools/golang/xenlight/helpers.gen.go  | 12 ++++++++++
>  tools/libs/light/libxl_arch.h         |  5 ++--
>  tools/libs/light/libxl_arm.c          |  5 ++--
>  tools/libs/light/libxl_create.c       | 21 ++++++++++-------
>  tools/libs/light/libxl_types.idl      |  2 ++
>  tools/libs/light/libxl_x86.c          | 43 +++++++++++++++++++++++++++++++++--
>  tools/ocaml/libs/xc/xenctrl.ml        |  2 ++
>  tools/ocaml/libs/xc/xenctrl.mli       |  2 ++
>  tools/xl/xl.c                         |  8 +++++++
>  tools/xl/xl.h                         |  2 ++
>  tools/xl/xl_parse.c                   | 14 ++++++++++++
>  xen/arch/x86/domain.c                 | 27 +++++++++++++++++++++-
>  xen/arch/x86/hvm/vmx/vmcs.c           |  4 ++++
>  xen/arch/x86/hvm/vmx/vmx.c            | 13 +++++++----
>  xen/arch/x86/include/asm/hvm/domain.h |  6 +++++
>  xen/arch/x86/traps.c                  |  6 +++--
>  xen/include/public/arch-x86/xen.h     |  2 ++
>  19 files changed, 174 insertions(+), 22 deletions(-)
> 
> diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in
> index b98d161398..974fe7d2d8 100644
> --- a/docs/man/xl.cfg.5.pod.in
> +++ b/docs/man/xl.cfg.5.pod.in
> @@ -1862,6 +1862,16 @@ firmware tables when using certain older guest Operating
>  Systems. These tables have been superseded by newer constructs within
>  the ACPI tables.
>  
> +=item B<assisted_xapic=BOOLEAN>
> +B<(x86 only)> Enables or disables hardware assisted virtualization for xapic.
> +This allows accessing APIC registers without a VM-exit.
> +The default is settable via L<xl.conf(5)>.
> +
> +=item B<assisted_x2apic=BOOLEAN>
> +B<(x86 only)> Enables or disables hardware assisted virtualization for x2apic.
> +This allows accessing APIC registers without a VM-exit.
> +The default is settable via L<xl.conf(5)>.

Like you do below I would capitalize xAPIC and x2APIC in the option
text.

> +
>  =item B<nx=BOOLEAN>
>  
>  B<(x86 only)> Hides or exposes the No-eXecute capability. This allows a guest
> diff --git a/docs/man/xl.conf.5.pod.in b/docs/man/xl.conf.5.pod.in
> index df20c08137..2d0a59d019 100644
> --- a/docs/man/xl.conf.5.pod.in
> +++ b/docs/man/xl.conf.5.pod.in
> @@ -107,6 +107,18 @@ Sets the default value for the C<max_grant_version> domain config value.
>  
>  Default: maximum grant version supported by the hypervisor.
>  
> +=item B<assisted_xapic=BOOLEAN>
> +
> +If enabled, domains will use xAPIC hardware assisted emulation by default.
> +
> +Default: enabled.
> +
> +=item B<assisted_x2apic=BOOLEAN>
> +
> +If enabled, domains will use x2APIC hardware assisted emulation by default.
> +
> +Default: enabled.

I think for both options this should be:

Default: enabled if supported.

> +
>  =item B<vif.default.script="PATH">
>  
>  Configures the default hotplug script used by virtual network devices.
> diff --git a/tools/golang/xenlight/helpers.gen.go b/tools/golang/xenlight/helpers.gen.go
> index dd4e6c9f14..90e7b9b205 100644
> --- a/tools/golang/xenlight/helpers.gen.go
> +++ b/tools/golang/xenlight/helpers.gen.go
> @@ -636,6 +636,12 @@ x.Passthrough = Passthrough(xc.passthrough)
>  if err := x.XendSuspendEvtchnCompat.fromC(&xc.xend_suspend_evtchn_compat);err != nil {
>  return fmt.Errorf("converting field XendSuspendEvtchnCompat: %v", err)
>  }
> +if err := x.ArchX86.AssistedXapic.fromC(&xc.arch_x86.assisted_xapic);err != nil {
> +return fmt.Errorf("converting field ArchX86.AssistedXapic: %v", err)
> +}
> +if err := x.ArchX86.AssistedX2Apic.fromC(&xc.arch_x86.assisted_x2apic);err != nil {
> +return fmt.Errorf("converting field ArchX86.AssistedX2Apic: %v", err)
> +}
>  
>   return nil}
>  
> @@ -679,6 +685,12 @@ xc.passthrough = C.libxl_passthrough(x.Passthrough)
>  if err := x.XendSuspendEvtchnCompat.toC(&xc.xend_suspend_evtchn_compat); err != nil {
>  return fmt.Errorf("converting field XendSuspendEvtchnCompat: %v", err)
>  }
> +if err := x.ArchX86.AssistedXapic.toC(&xc.arch_x86.assisted_xapic); err != nil {
> +return fmt.Errorf("converting field ArchX86.AssistedXapic: %v", err)
> +}
> +if err := x.ArchX86.AssistedX2Apic.toC(&xc.arch_x86.assisted_x2apic); err != nil {
> +return fmt.Errorf("converting field ArchX86.AssistedX2Apic: %v", err)
> +}
>  
>   return nil
>   }
> diff --git a/tools/libs/light/libxl_arch.h b/tools/libs/light/libxl_arch.h
> index 00cc50394d..2eaff45526 100644
> --- a/tools/libs/light/libxl_arch.h
> +++ b/tools/libs/light/libxl_arch.h
> @@ -71,8 +71,9 @@ void libxl__arch_domain_create_info_setdefault(libxl__gc *gc,
>                                                 libxl_domain_create_info *c_info);
>  
>  _hidden
> -void libxl__arch_domain_build_info_setdefault(libxl__gc *gc,
> -                                              libxl_domain_build_info *b_info);
> +int libxl__arch_domain_build_info_setdefault(libxl__gc *gc,
> +                                             libxl_domain_build_info *b_info,
> +                                             const libxl_physinfo *physinfo);
>  
>  _hidden
>  int libxl__arch_passthrough_mode_setdefault(libxl__gc *gc,
> diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c
> index 52f2545498..4d422bef96 100644
> --- a/tools/libs/light/libxl_arm.c
> +++ b/tools/libs/light/libxl_arm.c
> @@ -1384,8 +1384,9 @@ void libxl__arch_domain_create_info_setdefault(libxl__gc *gc,
>      }
>  }
>  
> -void libxl__arch_domain_build_info_setdefault(libxl__gc *gc,
> -                                              libxl_domain_build_info *b_info)
> +int libxl__arch_domain_build_info_setdefault(libxl__gc *gc,
> +                                             libxl_domain_build_info *b_info,
> +                                             const libxl_physinfo *physinfo)
>  {
>      /* ACPI is disabled by default */
>      libxl_defbool_setdefault(&b_info->acpi, false);
> diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_create.c
> index d7a40d7550..2bae6fef62 100644
> --- a/tools/libs/light/libxl_create.c
> +++ b/tools/libs/light/libxl_create.c
> @@ -264,7 +264,6 @@ int libxl__domain_build_info_setdefault(libxl__gc *gc,
>      if (!b_info->event_channels)
>          b_info->event_channels = 1023;
>  
> -    libxl__arch_domain_build_info_setdefault(gc, b_info);
>      libxl_defbool_setdefault(&b_info->dm_restrict, false);
>  
>      if (b_info->iommu_memkb == LIBXL_MEMKB_DEFAULT)
> @@ -456,15 +455,21 @@ int libxl__domain_build_info_setdefault(libxl__gc *gc,
>          libxl_defbool_setdefault(&b_info->nested_hvm,               false);
>      }
>  
> -    if (b_info->max_grant_version == LIBXL_MAX_GRANT_DEFAULT) {
> -        libxl_physinfo info;
> +    libxl_physinfo info;
>  
> -        rc = libxl_get_physinfo(CTX, &info);
> -        if (rc) {
> -            LOG(ERROR, "failed to get hypervisor info");
> -            return rc;
> -        }
> +    rc = libxl_get_physinfo(CTX, &info);
> +    if (rc) {
> +        LOG(ERROR, "failed to get hypervisor info");
> +        return rc;
> +    }
>  
> +    rc = libxl__arch_domain_build_info_setdefault(gc, b_info, &info);
> +    if (rc) {
> +        LOG(ERROR, "unable to set domain arch build info defaults");
> +        return rc;
> +    }
> +
> +    if (b_info->max_grant_version == LIBXL_MAX_GRANT_DEFAULT) {
>          if (info.cap_gnttab_v2)
>              b_info->max_grant_version = 2;
>          else if (info.cap_gnttab_v1)
> diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl
> index 42ac6c357b..db5eb0a0b3 100644
> --- a/tools/libs/light/libxl_types.idl
> +++ b/tools/libs/light/libxl_types.idl
> @@ -648,6 +648,8 @@ libxl_domain_build_info = Struct("domain_build_info",[
>                                 ("vuart", libxl_vuart_type),
>                                ])),
>      ("arch_x86", Struct(None, [("msr_relaxed", libxl_defbool),
> +                               ("assisted_xapic", libxl_defbool),
> +                               ("assisted_x2apic", libxl_defbool),
>                                ])),
>      # Alternate p2m is not bound to any architecture or guest type, as it is
>      # supported by x86 HVM and ARM support is planned.
> diff --git a/tools/libs/light/libxl_x86.c b/tools/libs/light/libxl_x86.c
> index 33da51fe89..b257fca756 100644
> --- a/tools/libs/light/libxl_x86.c
> +++ b/tools/libs/light/libxl_x86.c
> @@ -23,6 +23,12 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc,
>      if (libxl_defbool_val(d_config->b_info.arch_x86.msr_relaxed))
>          config->arch.misc_flags |= XEN_X86_MSR_RELAXED;
>  
> +    if(libxl_defbool_val(d_config->b_info.arch_x86.assisted_xapic))
> +        config->arch.misc_flags |= XEN_X86_ASSISTED_XAPIC;
> +
> +    if(libxl_defbool_val(d_config->b_info.arch_x86.assisted_x2apic))
> +        config->arch.misc_flags |= XEN_X86_ASSISTED_X2APIC;
> +
>      return 0;
>  }
>  
> @@ -819,11 +825,44 @@ void libxl__arch_domain_create_info_setdefault(libxl__gc *gc,
>  {
>  }
>  
> -void libxl__arch_domain_build_info_setdefault(libxl__gc *gc,
> -                                              libxl_domain_build_info *b_info)
> +int libxl__arch_domain_build_info_setdefault(libxl__gc *gc,
> +                                             libxl_domain_build_info *b_info,
> +                                             const libxl_physinfo *physinfo)
>  {
> +    int rc;
> +    bool assisted_xapic;
> +    bool assisted_x2apic;
> +
>      libxl_defbool_setdefault(&b_info->acpi, true);
>      libxl_defbool_setdefault(&b_info->arch_x86.msr_relaxed, false);
> +
> +    libxl_defbool_setdefault(&b_info->arch_x86.assisted_xapic, false);
> +    libxl_defbool_setdefault(&b_info->arch_x86.assisted_x2apic, false);
> +
> +    assisted_xapic = libxl_defbool_val(b_info->arch_x86.assisted_xapic);
> +    assisted_x2apic = libxl_defbool_val(b_info->arch_x86.assisted_x2apic);
> +
> +    if ((assisted_xapic || assisted_x2apic) &&
> +        b_info->type == LIBXL_DOMAIN_TYPE_PV)
> +    {
> +        LOG(ERROR, "Interrupt Controller Virtualization not supported for PV");
> +        rc = ERROR_INVAL;
> +        goto out;
> +    }
> +
> +    if ((assisted_xapic && !physinfo->cap_assisted_xapic) ||
> +         (assisted_x2apic && !physinfo->cap_assisted_x2apic))
> +    {
> +        LOG(ERROR, "x%sAPIC hardware supported emulation not available",
> +            assisted_xapic && !physinfo->cap_assisted_xapic ? "" : "2");
> +        rc =  ERROR_INVAL;
> +        goto out;
> +    }

I think the logic here is slightly wrong, as you are setting the
default value of assisted_x{2}apic to false, and we would instead like
to set it to the current value supported by the hardware in order to
keep current behavior.

Also the options are HVM/PVH only, so having them set for PV should
result in an error regardless of the set value, ie:

if (b_info->type == LIBXL_DOMAIN_TYPE_PV &&
    (!libxl_defbool_is_default(&b_info->arch_x86.assisted_xapic) ||
     !libxl_defbool_is_default(&b_info->arch_x86.assisted_x2apic)))
     ERROR

libxl_defbool_setdefault(&b_info->arch_x86.assisted_xapic,
                         physinfo->cap_assisted_xapic);
libxl_defbool_setdefault(&b_info->arch_x86.assisted_x2apic,
                         physinfo->cap_assisted_x2apic);

I don't think you need the local assisted_x{2}apic variables.

> +
> +    rc = 0;
> +out:
> +    return rc;

The out label is not really needed here and makes the code longer.
Just 'return ERROR_INVAL' in the error paths or 0 at the end of the
function. You can then also drop the local rc variable.

> +
>  }
>  
>  int libxl__arch_passthrough_mode_setdefault(libxl__gc *gc,
> diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl.ml
> index 7ce832d605..cce30d8731 100644
> --- a/tools/ocaml/libs/xc/xenctrl.ml
> +++ b/tools/ocaml/libs/xc/xenctrl.ml
> @@ -50,6 +50,8 @@ type x86_arch_emulation_flags =
>  
>  type x86_arch_misc_flags =
>  	| X86_MSR_RELAXED
> +	| X86_ASSISTED_XAPIC
> +	| X86_ASSISTED_X2APIC
>  
>  type xen_x86_arch_domainconfig =
>  {
> diff --git a/tools/ocaml/libs/xc/xenctrl.mli b/tools/ocaml/libs/xc/xenctrl.mli
> index a2b15130ee..67a22ec15c 100644
> --- a/tools/ocaml/libs/xc/xenctrl.mli
> +++ b/tools/ocaml/libs/xc/xenctrl.mli
> @@ -44,6 +44,8 @@ type x86_arch_emulation_flags =
>  
>  type x86_arch_misc_flags =
>    | X86_MSR_RELAXED
> +  | X86_ASSISTED_XAPIC
> +  | X86_ASSISTED_X2APIC
>  
>  type xen_x86_arch_domainconfig = {
>    emulation_flags: x86_arch_emulation_flags list;
> diff --git a/tools/xl/xl.c b/tools/xl/xl.c
> index 2d1ec18ea3..b97e491c9c 100644
> --- a/tools/xl/xl.c
> +++ b/tools/xl/xl.c
> @@ -57,6 +57,8 @@ int max_grant_frames = -1;
>  int max_maptrack_frames = -1;
>  int max_grant_version = LIBXL_MAX_GRANT_DEFAULT;
>  libxl_domid domid_policy = INVALID_DOMID;
> +int assisted_xapic = 0;
> +int assisted_x2apic = 0;

This should be initialized to -1, in order to denote the values are
unset...

>  
>  xentoollog_level minmsglevel = minmsglevel_default;
>  
> @@ -201,6 +203,12 @@ static void parse_global_config(const char *configfile,
>      if (!xlu_cfg_get_long (config, "claim_mode", &l, 0))
>          claim_mode = l;
>  
> +    if (!xlu_cfg_get_long (config, "assisted_xapic", &l, 0))
> +        assisted_xapic = l;
> +
> +    if (!xlu_cfg_get_long (config, "assisted_x2apic", &l, 0))
> +        assisted_x2apic = l;
> +
>      xlu_cfg_replace_string (config, "remus.default.netbufscript",
>          &default_remus_netbufscript, 0);
>      xlu_cfg_replace_string (config, "colo.default.proxyscript",
> diff --git a/tools/xl/xl.h b/tools/xl/xl.h
> index c5c4bedbdd..528deb3feb 100644
> --- a/tools/xl/xl.h
> +++ b/tools/xl/xl.h
> @@ -286,6 +286,8 @@ extern libxl_bitmap global_vm_affinity_mask;
>  extern libxl_bitmap global_hvm_affinity_mask;
>  extern libxl_bitmap global_pv_affinity_mask;
>  extern libxl_domid domid_policy;
> +extern int assisted_xapic;
> +extern int assisted_x2apic;
>  
>  enum output_format {
>      OUTPUT_FORMAT_JSON,
> diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c
> index 117fcdcb2b..16ff9e76bc 100644
> --- a/tools/xl/xl_parse.c
> +++ b/tools/xl/xl_parse.c
> @@ -1681,6 +1681,20 @@ void parse_config_data(const char *config_source,
>          xlu_cfg_get_defbool(config, "vpt_align", &b_info->u.hvm.vpt_align, 0);
>          xlu_cfg_get_defbool(config, "apic", &b_info->apic, 0);
>  
> +        e = xlu_cfg_get_defbool(config, "assisted_xapic",
> +                                &b_info->arch_x86.assisted_xapic, 0);
> +        if (e == ESRCH) /* not specified */
> +            libxl_defbool_set(&b_info->arch_x86.assisted_xapic, assisted_xapic);

...because here you only want to use the global values if they have
actually been set by the user (assisted_x{2}apic != -1):

e = xlu_cfg_get_defbool(config, "assisted_xapic",
                        &b_info->arch_x86.assisted_xapic, 0);
if (e == ESRCH && assisted_xapic != -1) /* use global default if present */
    libxl_defbool_set(&b_info->arch_x86.assisted_xapic, assisted_xapic);
else if (e)
    exit(1);

> +        else if (e)
> +            exit(1);
> +
> +        e = xlu_cfg_get_defbool(config, "assisted_x2apic",
> +                                &b_info->arch_x86.assisted_x2apic, 0);
> +        if (e == ESRCH) /* not specified */
> +            libxl_defbool_set(&b_info->arch_x86.assisted_x2apic, assisted_x2apic);
> +        else if (e)
> +            exit(1);
> +
>          switch (xlu_cfg_get_list(config, "viridian",
>                                   &viridian, &num_viridian, 1))
>          {
> diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c
> index ef1812dc14..d08f51e28b 100644
> --- a/xen/arch/x86/domain.c
> +++ b/xen/arch/x86/domain.c
> @@ -619,6 +619,8 @@ int arch_sanitise_domain_config(struct xen_domctl_createdomain *config)
>      bool hvm = config->flags & XEN_DOMCTL_CDF_hvm;
>      bool hap = config->flags & XEN_DOMCTL_CDF_hap;
>      bool nested_virt = config->flags & XEN_DOMCTL_CDF_nested_virt;
> +    bool assisted_xapic = config->arch.misc_flags & XEN_X86_ASSISTED_XAPIC;
> +    bool assisted_x2apic = config->arch.misc_flags & XEN_X86_ASSISTED_X2APIC;
>      unsigned int max_vcpus;
>  
>      if ( hvm ? !hvm_enabled : !IS_ENABLED(CONFIG_PV) )
> @@ -685,13 +687,30 @@ int arch_sanitise_domain_config(struct xen_domctl_createdomain *config)
>          }
>      }
>  
> -    if ( config->arch.misc_flags & ~XEN_X86_MSR_RELAXED )
> +    if ( config->arch.misc_flags & ~(XEN_X86_MSR_RELAXED |
> +                                     XEN_X86_ASSISTED_XAPIC |
> +                                     XEN_X86_ASSISTED_X2APIC) )
>      {
>          dprintk(XENLOG_INFO, "Invalid arch misc flags %#x\n",
>                  config->arch.misc_flags);
>          return -EINVAL;
>      }
>  
> +    if ( (assisted_xapic || assisted_x2apic) && !hvm )
> +    {
> +        dprintk(XENLOG_INFO,
> +                "Interrupt Controller Virtualization not supported for PV\n");
> +        return -EINVAL;
> +    }
> +
> +    if ( (assisted_xapic && !assisted_xapic_available) ||
> +         (assisted_x2apic && !assisted_x2apic_available) )
> +    {
> +        dprintk(XENLOG_INFO, "x%sAPIC requested but not available\n",

This should be a little bit more concise, as Xen does always offer
a fully software virtualized x{2}APIC.

"hardware assisted x%sAPIC requested but not available\n"

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Feb 01 10:10:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 01 Feb 2022 10:10:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.263472.456166 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEq72-0001bN-7F; Tue, 01 Feb 2022 10:10:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 263472.456166; Tue, 01 Feb 2022 10:10:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEq72-0001bG-3x; Tue, 01 Feb 2022 10:10:12 +0000
Received: by outflank-mailman (input) for mailman id 263472;
 Tue, 01 Feb 2022 10:10:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JAuK=SQ=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nEq70-0001bA-1H
 for xen-devel@lists.xenproject.org; Tue, 01 Feb 2022 10:10:10 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 21984442-8347-11ec-8f75-fffcc8bd4f1a;
 Tue, 01 Feb 2022 11:10:08 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 21984442-8347-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1643710208;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=ZvO4up7j1fhOYscExFirfPxO4qeaueZBiDsCaZw2W1M=;
  b=hPf87z9lL6qS+6hB+zc990cskMfy5Ea7mR3CBqaY4VzKzF81IFFXzAlX
   HyOhhZOc+c+9PkOhnJHObWVXZI9tcarTLBIAKBcmy2P6d7H/lo9lTKseX
   3CPkXNyb6RxtbsvoRV5yFHexbyueEohhcxIAn2dI4EJyPGAJxVdwdeFgo
   0=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: 21Nd/g8xtp8wAXzv3ZeXmqYbxidY8GRx0kKvyqa1D5E1BZ/eWFeCys5sQhd77cDs/CCeJeLEmt
 bgelYSbm6/VIXqLpDrrg40QWVrP+X8AL3RUukSIbtnQf6TPg3LMiSzT677Nsv3sc1v4SnMvkqu
 W7Zg/RD8yIk5TJ5O1NqoJqqQ12UG6y1wtTnZu6RKbmqPKCrTLYiD4lyMGQgbfhnf/EnKOE2T8l
 jMZRNh67Dz0ZjeERC36OdjTYdx8sDuBA7mQ7RQ5/qEC31W2W4wqPRJHQHfHms/rr5PaO3dyN1r
 glcoIYuusZi2/sv3AyA54KZm
X-SBRS: 5.2
X-MesageID: 63204372
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:yflj9Kxg7FvZlUgscE56t+cDwCrEfRIJ4+MujC+fZmUNrF6WrkUCz
 GJJXj+CMv2LMzamet9yOtji/ElTuJOAzYVhHQNvqCAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAhLeNYYH1500g7wbZg2tcAbeWRWGthh
 /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL
 wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt/Vf6
 /Rz777hcwIwIJHRmtxaTyRZKz4raMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr
 6ZBbmlQMFbT3Ipaw5riIgVort4kI8TxepsWp1lrzC3DDOZgSpfGK0nPzYEDhm9s3Z8UdRrYT
 +4CZCRVc0T9WSQROAc4AZsXgLfyt3aqJlW0r3rK/PFqsgA/1jdZ+aLxPd/iX82FTMRYgG6Vv
 mvDuW/+B3kyCtubzjaU92O2scXGlyj7RYE6GaWx87hhh1j77nQaFRk+RVa95/6jhSaWQdtfN
 khS4Ssooqga/VauCNL6WnWQqnOeogQVXdYWFuQg8RyM0YLd+QPfDW8BJhZmbNElr8YwSSYd6
 k6Sn9jpCDpst5WYUXuYsLyTqFuaOyIYMGsDbi8sVhYe7p/op4RbpjXLQ9V4Gai5lOrcHz3q3
 iuKpygzgbYUpcMT3qD99lfC6xq8q56MQgMr6wH/WmO+8hg/dIOjf5av61XQ8bBHNonxZkKao
 HEOlsya7eYPJZKAjiqARKMKBr7Bz/SYNDzRh3Z/Ep9n8C6ik0NPZqgJvms4fh0wdJ9ZJ3m5O
 yc/pD+9+rd2EliLU/VVMri0EtoW0KrYUsjYV8jLO48mjodKSCeL+yRnZEi11m/rkVQxnaxXB
 ap3YfpAHl5BV/05kWPeq/M1lOZym3tgnT+7qYXTkkz/uYdyckJ5Xlvs3LGmSukipJ2JrwzOm
 zq0H5vbkk4POAESj8S+zGLyEbzoBSVhbXwVg5YOHgJmHuaAMDt7YxM26eh5E7GJZ4wPyo/1E
 oiVAye0MmbXi3zdMhmtYXt+cr7pVpsXhStlYXdxbQnwiyZyPdfHAEIjm30fJ+NPGAtLlqYcc
 hX4U5/YXqQnpsrvplzxkqURXKQ9LU/21GpizgKuYSQlfo4IeuA60oSMQ+cbzwFXVnDfnZJn+
 9WIj1qHKbJeGVgKJJuIOZqHkgPg1VBAybkadxaZfbFulLDErdICx9rZ1KFneqnh6Hzrm1On6
 uphKU5G/bGT+9Nkr4ihaGLth97BLtaS13FyRgHzxb23KTPb7iykx4pBW/yPZjfTSCX//6DKW
 Amf56iU3CQvkAkYvoxiPaxsyK5itdLjq6UDllZvHWnRbkTtAbRleyHU0c5Kv6xL57lYpQrpB
 R7fpogEYe2EaJH/DVocBAs5deDfh/sarSbfsKYuK0Lg6S4poLfeCRdOPwOBgTB2JaduNN932
 v8ovcMbslTtihcjPtucoDpT8mCAci4JX6k978lIC473kAs7jFpFZMWEWCPx5ZiObfRKM1Urf
 WDI1PaT2ewEyxObIXQpFHXL0e5Mvrg0uUhHnA0YOlCEutvZnftrjhdfxis6E1ZOxRJd3uMtZ
 mUybx9pJb+D9itDjdRYWzz+ABlIARCU9xCjy1YNk2GFHUCkWnaUcT84MOeJuksY73hdbn5Q+
 7TBkDTpVjPjfcfQ2CouWBE696y/HIIprgCSytq6G8mlHoUhZWu3i6CjUmMEth/7DJ5jn0bAv
 +RroL59ZKCT2fT8eEHn5112DYgtdS0=
IronPort-HdrOrdr: A9a23:Bz+Nraswz7sFSPjZsozco4zt7skClIMji2hC6mlwRA09TyXGra
 +TdaUguSMc1gx9ZJhBo7G90KnpewK6yXdQ2/hqAV7CZnichILMFu9fBOTZsl/d8kHFh4tgPO
 JbAtVD4b7LfCZHZKTBkXCF+r8bqbHtmsDY5ts2jU0dNT2CA5sQkDuRYTzrdHGeKjM2YabQQ/
 Gnl7Z6TnebCDwqR/X+IkNAc/nIptXNmp6jSRkaByQ/4A3LqT+z8rb1HzWRwx9bClp0sP0f2F
 mAtza8yrSosvm9xBOZ/2jP765OkN+k7tdYHsSDhuUcNz2poAe1Y4ZKXaGEoVkO0aqSwWdvtO
 OJjwYrPsx15X+UVmapoSH10w2l6zoq42+K8y7uvVLT5ejCAB4qActIgoxUNjHD7VA7gd162K
 VXm0qEqpt+F3r77WvAzumNcysvulu/oHIkn+JWpWdYS5EiZLhYqpFa1F9JEa0HADnx5OkcYa
 VT5fnnlbdrmG6hHjDkVjEF+q3uYp1zJGbKfqE6gL3a79AM90oJjXfxx6Qk7wM9HdwGOtx5Dt
 //Q9RVfYd1P7orhJJGdZY8qPSMex/wqDL3QRSvyAfcZeg600ykke+E3Fxy3pDvRKA1
X-IronPort-AV: E=Sophos;i="5.88,333,1635220800"; 
   d="scan'208";a="63204372"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=b8DawPAwcbuOsTKnPfhaVqt6xbTjxMcxANEU+9yixIu6dFeQLXk4Al3bpLHazbvfkZTvYq61q9HzW3/xIOHYbjTJNpWrCS4xtQ+XH8qGv0fYGYDrR3EtQFIdhTt1SHTkcUiba6UOh/BHeyX6KCgZ8NolrgHAk5uNnRDB0FpqdG7UFL6nSmLax8g6xjQs/PJFqqWLGt+a2o8wedl8UHTz4Zwazle5PEmuQntL0CgX1eaTIwPjwkZuFG78OT2ZXiSJm2ie/00KPjOQmFGqwW9koSnd00iqUk2DQzZ2m0wlXprk9RAP5vkfykOh346TqqsgyoSdhwC1Nc+6FEKkJRy2xQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=bO4jG1GuNrVkD5Sf93b0trfw7GU9uwzI+/wxRehQRJg=;
 b=gXIy/YKScE/kOnjaR8CWbE+9UHgA6MQom7ZUc7HzsRMB+R4WXpOFKmgaLkem883dJS90OXA+DdbOW26Xofc8UWJJmz2qs+WJeUPSW6DUdPaZoTh9QNR+IXBFdZdSURWOhjsqbqLtoy7be8DtpFpcknm2XSpiQaNcd8YjasIdQgcgo/B29fjyrT47zPo/1FSHtbUHMpyjyWNWedZ5G+1OXgRhgbnxyN9eQA35hp0TrRv0Lh6IXKvhSFRsYiUtBJAFJJslaAszDyWXCX7q0SDjtvBqAVWk3O7JICd005aA+aaF5Vs8ZR90GMgdyukan9z3cp0Z36QoWiB4YLBvothIUg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=bO4jG1GuNrVkD5Sf93b0trfw7GU9uwzI+/wxRehQRJg=;
 b=gpJd5siwrIU+oSn07imgEwHCA5Fs6YMq30mG0B8BQUC87RVKT0Cl8moZ/L7HYiZR6PU5boL5q4E1x6U9rnhPXzFc9upxxrXQRxs6OYnJVpILnd2ZJ934eHyzxIDEnYqXTjkuguDx5IaEFOatcpR3Tdts0832xfW6m8IwHIVQGd4=
Date: Tue, 1 Feb 2022 11:10:00 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "julien@xen.org" <julien@xen.org>,
	"sstabellini@kernel.org" <sstabellini@kernel.org>, Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Artem Mygaiev <Artem_Mygaiev@epam.com>,
	"andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
	"george.dunlap@citrix.com" <george.dunlap@citrix.com>, "paul@xen.org"
	<paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>, Rahul Singh
	<rahul.singh@arm.com>
Subject: Re: [PATCH v5 06/14] vpci/header: implement guest BAR register
 handlers
Message-ID: <YfkG91cg+fAHFPGd@Air-de-Roger>
References: <20211125110251.2877218-1-andr2000@gmail.com>
 <20211125110251.2877218-7-andr2000@gmail.com> <Yd7K+9fvnBz+WTXA@Air-de-Roger>
 <082ca110-2ab7-60ff-e705-032d2d472547@epam.com>
 <df36767b-e04f-aa29-82af-87e8624bd29c@suse.com>
 <c82f94c4-dadf-7b2d-4d30-a1de2b5f962a@epam.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <c82f94c4-dadf-7b2d-4d30-a1de2b5f962a@epam.com>
X-ClientProxiedBy: LO2P265CA0036.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:61::24) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7af3de8f-4a10-48fc-a738-08d9e56b03a9
X-MS-TrafficTypeDiagnostic: BY5PR03MB5346:EE_
X-Microsoft-Antispam-PRVS: <BY5PR03MB5346A5222075F3B88952E24F8F269@BY5PR03MB5346.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: QLgq8xbHz1HMxDnIAE2lzO97sH4uZrk+IoRjrrlmAypFoLC56CE3GqJYLOXKThn9395BGJN3gUxyXLGUXNaqapstQDMQShikwiPVQXqjFeGUjUikDOAO9BeL9jOL0wwWbr/KldutWqvTf37LtrbplhVd8aRlvN8yMG5rWU1zRfCRMbehel6J2mW2Blq4D+IUvb5GLxlm1DFFHJ6XqjQeVeEENbuA4VLFP4kRCwh/l4oUEBKQGFH+61jgcZU/Axw9Pw5rjzucdnPHifry6BovRzzIxx/TEuoncJszpYVLB0iDJocDwFqamhz371vneTc2d47SH5bBlGQx//Ri/IktdBEhAL2JOeLKh3tFOMEelbK1GDdMJX0ro8Qbm/Bs8vBwzula4yZywH58338VuMb4DV3QdZJjCqry0BMSzgSwA+rzWq7qpqFfvo42yuAjJkGwUkeIe4wE4ZWs/keL7nYnEC0nhURvjLkMxbim68ygloNuk0Mzg8ROt4YZtBoEchKnleK/PhyYbnu19gVz+lqz747qPpKxIT52egQHrZaYLqU1V8E1khCR959Zadiv17FMDorZU4/U1tkoa06JAhQ125ugPX6M70BhYDsZLnddSc4EUgM151n/yF0XtBeB21iiC0z1fNe9fb+VZM900jgkAc1+5TX2xAClVbRIFvYJZkDUI7A6Q+GIsqJmeabvWDDfWNYmiwcUanptGKZ+JuPFnw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(38100700002)(66556008)(6486002)(66476007)(316002)(86362001)(4326008)(8676002)(66946007)(33716001)(85182001)(8936002)(6916009)(54906003)(82960400001)(508600001)(5660300002)(53546011)(6506007)(186003)(26005)(9686003)(6512007)(7416002)(2906002)(83380400001)(67856001)(20210929001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SHZlMzhqblFKK2FZUUVyWUNSdXBHYnlBMTdzYS9jcXYvMG95NlZmT1gvazRI?=
 =?utf-8?B?c2cvQkNvRmVmVkVqUzErODlPbWNYdzhHOUpFMGxQYUFYTk82bHFQS2lFSGo1?=
 =?utf-8?B?cDNJMXcrU292b0FPSzVUSEtKUVNPVkozYkZtclJKcStMMnNtZkdhdDRybmdV?=
 =?utf-8?B?MnN4dnR2WmVvcHl3VkdsUmF2VE84WTRHemdvNFZBVWFnZnF3MTViZDQ0bVcw?=
 =?utf-8?B?R0hDZDNFNWs0S1NOaUtTQ2tDb1c2M01YWmpGU1dtbzhTNk1vSnJpMTJxeDh6?=
 =?utf-8?B?UlYyRlRmT29HZkpPNHVneW84SHkyRTkzY0t1dVBEZzlMbWpFdTNMUjU3clE1?=
 =?utf-8?B?SjRRWXlGL3YrSzZoK29Zdjd1dDFhUGs3b0pjeGVXTS9zbUpXdm9qRlNtL25r?=
 =?utf-8?B?ODc1OXJFN2tZS1E5eDN0ZERnZGF5WE52eWVzVkI1YmpKWWk0b1MwbjEycDl2?=
 =?utf-8?B?dlU1clM0NFZ6V2FFemNaM3ptVVVSQ0JKQ0JTUHdhY29DTnlQNEpaa2tuNGw4?=
 =?utf-8?B?SjlzNjRPaW04UHNNQXRudTQxSkErTmRoQ2ZOL1NkTDBtMktKamNLWEZlYkg5?=
 =?utf-8?B?c0JXQmNRTjJWMHlGU0J2c0RJTE43RVkvQ2xJekFtNi9jTThQWnRSbXdjbzZ6?=
 =?utf-8?B?amhoWjZZbFdNSWhyQ2c3MG5uVjhjR1pGZTRLWXlFNXF3cFF2NGVidVJYRHRw?=
 =?utf-8?B?VjFEeXgzSXdlM2VRSTdSdnlNU0d0Q1hBdm1BNzB2RHYrek9uT2wva2MxYVhC?=
 =?utf-8?B?SUUrdldqT3Jha1Q5ZE40RnZmRnZZNm9LY3M5ejRpeEZUZ0VYT3kyVkJRNEtp?=
 =?utf-8?B?UG9pZDlPRERjNFFtTUF3Rk81ZHRGcGM4YkZmTk44TVVMa2RtQUtVUkg0OW9L?=
 =?utf-8?B?WWZxWklOMXh6bnBWZ094M0lJZFlnOGsxWkZYcmhCdE1PbGJFT25QaGNFSkNo?=
 =?utf-8?B?Zm1GdTBCSkxrcFIzeVl6MDlKZk5SMHJSaHZBbU5Kb29JeDRFeEExejJ1aEtm?=
 =?utf-8?B?UzJIVnVGMHhhR05OaHcvcjlUZEx0S09zK0pKTWExaWJOSERmSGpFY2lYMTJE?=
 =?utf-8?B?clFKWmp2bnNyazNET3VmclR2dmt5TFBUVitDaXVTWDhCWlNDeE5rbk9PbVhm?=
 =?utf-8?B?UjBUWVNlVG1qdkgxS0doMnh3N0dFWmZLUmRVVXBacTh5YVoxUEhsZ2UxeEsw?=
 =?utf-8?B?VGQ2L0JJUWZQOEhZOGJEeHUyK2pWMWI4YksrdW41OXNQd1V6bWNYaUNyUVFQ?=
 =?utf-8?B?cFZYTmdETWhHUll0WDNNTHh1VUNmWkxMVXRTYm9tUUlSZFdMbU9pT0dma3Na?=
 =?utf-8?B?Q1VxbTh5QStKL3lXY2VvRS9EM1cxWGRMZEhVaWQ3d3p2T2JsQjkwc1ArVGJz?=
 =?utf-8?B?czkvcmlraDBQWldCQWl1NUQ3WHpQMjgvV0xIaEtUNWhkcG9oVVBoT1dIZXhr?=
 =?utf-8?B?NTEwMzNpc2puM0E5YXAvUXd5OXZwYk01MGxWMDdwOEEraHJJWEpUSlZzQW9E?=
 =?utf-8?B?TGV6bGR4VjUvczVVdFZzbVBoSjllTFpwVVVWcCsySFY1bk54dkNwRDhGUmhD?=
 =?utf-8?B?WmpYaitOTkhuWGtwditkeGRzT3hqY1N3cmtZVXVYNTJ1MXc1Wk5wSU1pa3A5?=
 =?utf-8?B?eTYwYldOTU01clhBMHYwaUFES2pGbzQ1YTZ4SGZoNTdlbTBYNEhJUytERUMv?=
 =?utf-8?B?dzFBWFhwSnp6YVcwM3hLeCtMQm50UWtqRGZMWHZ6V1M5bUVIalA4MVJXZFpS?=
 =?utf-8?B?WFNlcWdVZ1EvUi8ycmpteXo0NjJPK2czckw3ZUZFQmgzSE5uekx4dGRBaTRQ?=
 =?utf-8?B?RjcvdkE4VEd2eUFxM3o3SHhYbE9odU5yRU1pdjhmejQxMHpEWmU5dnNpZG5h?=
 =?utf-8?B?ZTJUWS91aC9ZUlJjOWZhdVJIQndCRGZVMytTMFdhUVlaVkZrNFdiV3N6L2hZ?=
 =?utf-8?B?NktrcjVEV2x5VTdRaS9ZQkREUkJ4amlOakVsaGNvZ0ZtMHc2MGJqcnBwTUhz?=
 =?utf-8?B?YzVnMnlLOVBDZ01NQnJJRno3S3htWFpFb01UWWthU0VzQ0E4NzZrQUtzSFUr?=
 =?utf-8?B?bWs0NktWK0VHQnFJZVdCak5KMTZKWG5FOUw5cHJDUmlpZ1dTa3RvWVdpbXVY?=
 =?utf-8?B?aTViTlMreGtSY1dsM3k5YkVpRmVHMDZvaXpSWDEvbSttL2czcGRqUHRKbnRO?=
 =?utf-8?Q?RLmtrNTxUe3jBsTWZL5qm20=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7af3de8f-4a10-48fc-a738-08d9e56b03a9
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2022 10:10:03.6597
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZOGUgu/lODnf+n/GiPQ4CAYKpBmRRTtBqha4JrTESwiZO/ckPNf+SiopEjss0RE0VZHtsDJXg8VpJRBk6FzNAg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB5346
X-OriginatorOrg: citrix.com

On Tue, Feb 01, 2022 at 07:31:31AM +0000, Oleksandr Andrushchenko wrote:
> 
> 
> On 31.01.22 17:50, Jan Beulich wrote:
> > On 31.01.2022 16:06, Oleksandr Andrushchenko wrote:
> >> Hi, Roger!
> >>>>                rom->type = VPCI_BAR_EMPTY;
> >>>>        }
> >>>> diff --git a/xen/include/xen/vpci.h b/xen/include/xen/vpci.h
> >>>> index ed127a08a953..0a73b14a92dc 100644
> >>>> --- a/xen/include/xen/vpci.h
> >>>> +++ b/xen/include/xen/vpci.h
> >>>> @@ -68,7 +68,10 @@ struct vpci {
> >>>>        struct vpci_header {
> >>>>            /* Information about the PCI BARs of this device. */
> >>>>            struct vpci_bar {
> >>>> +            /* Physical view of the BAR. */
> >>> No, that's not the physical view, it's the physical (host) address.
> >>>
> >>>>                uint64_t addr;
> >>>> +            /* Guest view of the BAR: address and lower bits. */
> >>>> +            uint64_t guest_reg;
> >>> I continue to think it would be clearer if you store the guest address
> >>> here (gaddr, without the low bits) and add those in guest_bar_read
> >>> based on bar->{type,prefetchable}. Then it would be equivalent to the
> >>> existing 'addr' field.
> >>>
> >> I agreed first to do such a change, but then recalled our discussion with Jan [1].
> >> And then we decided that in order for it to be efficient it is better if we setup all the
> >> things during the write phase (rare), rather then during the write phase (more often).
> > Small correction: The 2nd "write" was likely meant to be "read".
> Yes, this is correct.
> >   But
> > please recall that Roger is the maintainer of the code, so he gets
> > the final say.
> Agree, but would vote for the current approach as it still saves some
> CPU cycles making the read operation really tiny

I think you need to build the mapping rangeset(s) based on guest
addresses, not host ones, so it's likely going to be easier if you
store the address here in order to use it when building the rangeset.

Overall the cost of the vmexit will shadow the cost of doing a couple
of ORs here in order to return the guest view of the BAR.

If you think storing the guest view of the BAR register will make the
code easier to understand, then please go ahead. Otherwise I would
recommend to store the address like we do for the host position of the
BAR (ie: addr field).

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Feb 01 10:24:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 01 Feb 2022 10:24:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.263479.456176 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEqKO-00037X-FK; Tue, 01 Feb 2022 10:24:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 263479.456176; Tue, 01 Feb 2022 10:24:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEqKO-00037Q-C6; Tue, 01 Feb 2022 10:24:00 +0000
Received: by outflank-mailman (input) for mailman id 263479;
 Tue, 01 Feb 2022 10:23:59 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JAuK=SQ=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nEqKN-00037K-NQ
 for xen-devel@lists.xenproject.org; Tue, 01 Feb 2022 10:23:59 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0fb997f5-8349-11ec-8f75-fffcc8bd4f1a;
 Tue, 01 Feb 2022 11:23:57 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0fb997f5-8349-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1643711037;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=waRVfAc7vidf2MNXlwI1vsYzkwpyFo1xPqibtbJgOu0=;
  b=BtX6t0ACwqNy8b5LIeqmXjRm7ZTSJY7+99pSdlUMKwfFCik3QjzY4TlT
   Ctz5qqLupzehOMoNr/iSqu/DPj6Vg6V83D1j0PTmlQR4N1pdcyuuCa8Bm
   hNpz443jA1P2SqP8qM5C0tXEaEg5S1gdcTtyg/9bA2zLeg9rM/li+5V4M
   U=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: vVc4Uv59KrjVwq98irhOKRHGp3JjtRgyjxJJokmtOKIazOS2JHbqw6zXp9qx9F4dh9Srzi8dBS
 AKMdx88DRt7eDVXdklEDtrQEnL9CnC99tJPWSRooEA6hZqeoLM/dUW5hgn9gXdaZe8qUiyaXN+
 HKEOeWovXr7KTW2PxFKel5QVmIKpI6g85minSPNFTfjTuDbTRx28eM9BuZntU98dFV2g2nrTGP
 rBqgpXJUHCE2aVJxBuVpaiQZURdkmre31KHXnYIfDdAhJgZnWEExDISeOoBjdWyOfj1dDISIkS
 Z5i27vEU1VDgO/Tqx4DT4GUX
X-SBRS: 5.2
X-MesageID: 65388474
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:nrrY5627PuDK6CB/UPbD5ed3kn2cJEfYwER7XKvMYLTBsI5bp2ADz
 mAeWW+AafveYzH0e4wiO96w9h5UsMLUy9VhQAVvpC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkS5PE3oHJ9RGQ74nRLlbHILOCanAZqTNMEn9700o5w7dh2+aEvPDia++zk
 YKqyyHgEAfNNw5cagr4PIra9XuDFNyr0N8plgRWicJj5TcypFFMZH4rHomjLmOQf2VhNrXSq
 9Avbl2O1jixEx8FUrtJm1tgG6EAaua60QOm0hK6V0U+6/TrS+NbPqsTbZIhhUlrZzqhsNdK+
 OtCmsKKdSQiYaP+qs8HQQdaHHQrVUFG0OevzXmXtMWSywvNcmf2wuUoB0YzVWEa0r8pWycUr
 6VecW1TKEDY7w616OvTpu1EnMMsIdOtJIoCknph0SvYHbAtRpWrr6Diu4IDjGds2Zwm8fD2S
 O42MRRDMA38TiIVY0tJEslgk+uYryyqG9FfgA3M/vdmi4TJ9yRz2rXwNNveevSRWN5Y2E2fo
 wru1n7lDxQtEc2QwDuI7FqhnubK2yj8Xeo6DLSl8tZ6jVvVwXYcYDUMXFumpb+ii0ixW/pWM
 UlS8S0rxYA4+Va3VND7U1u9qWSdox8Hc9NKFqsx7wTl4pTT5wGVF20VVAlrYdYttNI1bTEy3
 1rPlNTsbRR/vbvQRX+D+7O8qTKpJTNTPWIEfTUDTwYO/5/kuo5bpjXLQ9V4Gai5lOrcHz3q3
 iuKpygzgbYUpcMT3qD99lfC6xquu5zIQwgd9gjRGGW/4WtRQ4qoZJeh71TB2spRN4aSTlSHv
 38sltCX6aYFCpTlvDeWXOwHEbWt5vCEGD7Rm1hiG98m7TvFxpK4VdkOunckfh4va5taP2+yC
 KPOhe9PzLBUB0uUYoApWb6SAJsk/5rLD8b7VP+BO7KifaNNXAOA+ShvY2uZ0GbsjFUgnMkDB
 HuLTSq/JS1EUPo6lVJaU89YiOZ2nX5mmQs/ULiml0zP7FaIWJKCpV7p2nOqZ/tx0q6LqR69H
 z13Z5rTkEU3vAETj0DqHW8vwbIicCJT6XPe8ZU/mgu/zuxOQjtJ5xj5mutJRmCdt/4J/tokB
 1nkMqOi9HLxhGfcNSKBYW15ZbXkUP5X9CxnZnF8Yg74hSl/MO5DCZvzkbNtJ9HLE8Q4lZZJo
 wQtIZ3cUpyjtByak9jiUXUNhNM7L0n67e5/FyGkfCI+b/Zdq//hobfZkv/U3HBWVEKf7JJmy
 5X5j1+zacddG2xKUZiHANrynwLZlSVMw4paAhqXSuS/jW2xquCG3QSr0K9uSyzNQD2erganO
 /G+WElA/beV/95qobEkR8ms9u+ULge3JWIDd0Hz5reqLyjKuG2lxI5LSuGTej7BEmjz/c2fi
 S99lpkQ6dULwwRHtZRSCbFuwf5s7tfjveYCnA9lAG/KfxKgDbY5eiuK2sxGt6tswL5FuFTpB
 hLTq4cCYbjZatn4FFMxJRY+arjR3/8jhTSPv+8+J1/35XEr8ePfA1lSJRSFlAdUMKBxbNE+2
 e4ktcNPs16/hxMmP8yolCdR82jQfHUMX79+7sMRAZPxixptwVZHOMSOBijz6ZCJStNNLkh1f
 WPE2Puc3+xRnxOQfWAyGH7B2ftmqa4P4B0ankUfI1mpm8begqNl1hNm7jlqHB9eyQ9K0rwvN
 zEzZVF1P6iH4xxhmNNHAzK3AwhECRCUph7xxl8OmDGLRkWkTDWQfmg0OOLL90EF6WNMODNc+
 ejAmmriVD/reuD33zczBhE5+6CyE4Qp+12Qgt2jEuSEA4I+MGjsjaKZbGYVrwfqXJEqj0rdq
 Og2pOt9ZMUX78LLT3HX32VC6YktdQ==
IronPort-HdrOrdr: A9a23:cR8w+a0FcJ188BwLUmNgIAqjBfhxeYIsimQD101hICG9Lfb3qy
 n+ppsmPEHP5Ar5AEtQ4+xoS5PwPE80lKQFrrX5WI3CYOCIghrQEGgP1/qB/9SkIVyEygc/79
 YvT0EdMqyJMbESt6+Ti2PUc6dC/DDuytHxuQ609QYIcegeUdAH0+4PMHf9LqQZfngiObMJUL
 6nouZXrTupfnoaKu6hAGMeYuTFr9rX0Lr7fB8vHXccmUizpALtzIS/PwmT3x8YXT8K66wl63
 L5nwvw4bjmm+2nyyXby3TY4/1t6ZvcI5p4dY+xY/ouW3DRYzWTFcBcsnq5zXcISdSUmRQXeR
 /30lEd1opImirslyqO0GfQMkHboUkTAjnZuASlaDLY0L3EbSN/BMxbiY1DdBzFr0ImodFnya
 pOm3mUrpxNEHr77W7ADnfzJmRXf2eP0DIfeNQo/jdiuEolGctshJ1a+FkQHIYLHSr85oxiGO
 5yDNvE7PITdV+BdXjWsmRm3dTpBx0Ib1u7a1lHvtbQ3yldnXh/wUddzMsDnm0Y/JZ4T5Vf/e
 zLPqlhibkLRM4LaqB2AvsHXKKMeyHwaAOJNHjXLUXsFakBNX6Io5nr4K8t7OXvY5AMxItaou
 WJbHpI8WopP07+A8yH25NGthrERWm7UDz3jttT/Jh0oPn9Q6D3OSqIRBQvnqKb0oUi6w3gKo
 CO0b5tco3exFrVaPF0NlfFKudvwFElIb4ohuo=
X-IronPort-AV: E=Sophos;i="5.88,333,1635220800"; 
   d="scan'208";a="65388474"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=c5d2DQbZJGtPiMrb01XcPPFvczQNYSZzxLyXgElN9kdvMY1IFKcOvtbqYZ5m7xWr71Gu46nSFVFbtUrU9+Kynl1k+ujt9aLRCcebA9ckWdvamHgciKun0Muu5T7ngy6lpEhNQ4ANjGP1JxWaKlaMrin8S6o0eawrwXIOio2MxoU+T3VufCGHtXVAZ1Gw99Koc35IFTDZeTQ7WIh+6/hJ67hk+NXK31d1RwzR7OhIIDdHKUlWk9aA9juXrl2E//lsRRUg2P7gxqieIToC01+3XBdJxJXgn8uzddvmYgSVIzGjkkOe58ArRIzspLTGlZw8GzQAVyQE1YW+/6GX/r85Xg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=fjmKXC02a46b0N4agfLPjg7mRyM64QzovMyqMf83574=;
 b=Vmon9T6SkCCcGP6j0qgZYUvoctVC6iHfB8ImRMA2+1jBPwtLzLMHwVIpRq7q0HUpI43OyHslywl2WmdMEQdon8hp7EK9nosIvXWl/ywBO2e3/x+ITjVU+n4CgFMJUhksnq24mXsQvsktP4wlKbYqCqU6DL+fSrXKDEJOQUMobqWYdZJ/XERq0nITe+VRqmGO1o5pOr0iYhBG6GOjsLn1w2hoOA4RkVQhRJyHy9RYq5REyqLl9tbXakr4T+U1k03k0a+ovBBUHCshil7hQs7Lht5PUfRye6nPfFtPF5qQ+HzfxLuHzjSxDNTy33E+/w1mJX2Zpe9SoFbYD15sYqxXzw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=fjmKXC02a46b0N4agfLPjg7mRyM64QzovMyqMf83574=;
 b=BTJe+ObAY2fMOJNVKm9t2SHfWepADyYmftkpMHvir53bbVHAzsKxmnLdQMW4DSIjIVnWUyQL1k9E1L4+MCD8FYwW+l6NQ10CS8XT4VY74fi5jud+i8fI7v2GDLIHHqkVUWC6cTYbFyj2SOQvqLHDfF2ptrnReuXsUhqzrwN1LSs=
Date: Tue, 1 Feb 2022 11:23:46 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"julien@xen.org" <julien@xen.org>, "sstabellini@kernel.org"
	<sstabellini@kernel.org>, Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Artem Mygaiev <Artem_Mygaiev@epam.com>,
	"jbeulich@suse.com" <jbeulich@suse.com>, "andrew.cooper3@citrix.com"
	<andrew.cooper3@citrix.com>, "george.dunlap@citrix.com"
	<george.dunlap@citrix.com>, "paul@xen.org" <paul@xen.org>, Bertrand Marquis
	<bertrand.marquis@arm.com>, Rahul Singh <rahul.singh@arm.com>
Subject: Re: [PATCH v5 05/14] vpci: add hooks for PCI device assign/de-assign
Message-ID: <YfkKMgul+CrkMQQI@Air-de-Roger>
References: <20211125110251.2877218-1-andr2000@gmail.com>
 <20211125110251.2877218-6-andr2000@gmail.com> <YeAPxA8gZZ/xBYdA@Air-de-Roger>
 <f4ea5ece-551e-8a91-90c6-d9f806c97d5b@epam.com>
 <ef8feba1-695f-5cd6-bdf6-8ef6c55e62e1@epam.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <ef8feba1-695f-5cd6-bdf6-8ef6c55e62e1@epam.com>
X-ClientProxiedBy: LO2P265CA0226.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:b::22) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 80a2a947-f381-4721-b07c-08d9e56cf06c
X-MS-TrafficTypeDiagnostic: SN2PR03MB2255:EE_
X-Microsoft-Antispam-PRVS: <SN2PR03MB2255190707EF6E4A9FD8407E8F269@SN2PR03MB2255.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: Hu0XXdbvalXI76T2Tv4oiWB1n4nk4g5t9iw5yC2s3bQJzbMD9LQzcb5ilvi4N//Qznb2ynupyVAI2vcsurodgSq3lj1/WzoKAO/5zV7LROquVvzDZsxuKw/WD7lBasdM5qg2Dq6SvwOAQl83KBSEO8hOOddXDujcYDqUc0DMXLUoUDURQTRarw9s1Y1YcOP7zGfoVEGP94QdI10O4oKYiT4T3oibBONOVDn5ICwnvdoYEP5YnVNVi2o9dhRg24Tp1R8OHUpVMdazsV5D0xTuPooGrlcKgvmI480gTJMbeLB+Iey8siWNEPAtWJpndlAI/AgztgfFZ8kNfw5wKBgn1uQebT4KWfDuYlAXTseXF4XRJ3zc6xTJJiQb27601RrPLFfdi9pXPKr7A+R4VbBnnXsRIBw0EOzF5U+XyDXOFuh9o5Qq1yfp1C9M+WqVPakriWo3dl27BdxFjQ8eLfZyfJKFVvSZ/WhB7rB+5LWQPxAyJVnfpUKr/oWUL+9IwTnwEKj9GClC04WQf/5Zj8ltiCbMRR1Hk1X3rd6tfquLKpnvdgfztz/lcy+rJhVe791maoXC43j+AHRHmNAQXwNEBt0ZtZ2kMS0fCLdXIfwofv0qV8ulQjyCSVwyvGNIs36rGEXCWvNFDvjTuv9wDoLUnhy04U27O8Fvi+GyyQZhr0Z5EfqKPUh8zk8On8B9BRPzNSZrj96zH86rJDb63Jq26A==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(7416002)(85182001)(38100700002)(83380400001)(6916009)(508600001)(5660300002)(316002)(186003)(26005)(33716001)(6486002)(2906002)(66946007)(4326008)(66476007)(8936002)(8676002)(66556008)(86362001)(53546011)(6506007)(6512007)(9686003)(82960400001)(6666004)(54906003)(67856001)(20210929001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d2ZEeGhSZ0htOGR1NndONWhFcGhOMnVrR3FNdmpNdkVRb2VOb25vc1J0UXRj?=
 =?utf-8?B?VHhTK1B1ejdWdzE1TjZRYVlGZEZzQWNYSTFGUEZBUlNJd2EyWVFoVXVEbFJ2?=
 =?utf-8?B?TzQvWGdIeHdwcU12MmxXQm1wVjFhUzJ1THVYMk5YMzBac2NQMmlxcEozNHpC?=
 =?utf-8?B?eVphTnlUMS9hZndGcDFTMmMvN2NEZHB1QzZWRERhcFU3MzgwZld2aGI3VVND?=
 =?utf-8?B?S3lLK25JcE1VUDR5UFpMY2I3Z3ZSWFo4NERPZWsvMHArL3g4M21FWHV6S05z?=
 =?utf-8?B?Y1VsYmZuSXd0RUpQUkVVWVZzSmFCZnZFZld0RzFUOVJKVEZ4UFJ6S3c5REVr?=
 =?utf-8?B?QXI1N1FnOHhTQjFKbkZoeTNNT29sOWp2QnZCbEZXK0tZcHlsSzY5M3pkSDVo?=
 =?utf-8?B?THBqTFlJNUJJczlFWlo4R0xFR3IrSUxFdVd6UHQwd2VsL0tKbU1hdGh1UktB?=
 =?utf-8?B?NHJueHpOUVprWW9lcGJaemZvRTZML0RFS0dhT21OWTZmV1MxOTgvdlFjQ2E1?=
 =?utf-8?B?WmYvRlhoa2pVVXZueldwaElPY3hxVzh3L0ZpV3pEWXQ3Ym1nZllRaVJNL3VQ?=
 =?utf-8?B?LzRxVys1NmNjb0xNLy9HZDUyR01xcFZVLzl4Q3hlR2NyY1NQUEJ4WFF4bm51?=
 =?utf-8?B?a0pxbG5EaHc0WmRGcnhRb004M2hieHoveHRzczdpVUhWeVZmaWdwSWI4Wlpa?=
 =?utf-8?B?d01DeStiY09ETzFGRnJTUlhZeUhabXJSRThJOUc1c2dyQTN1NUZhRWhSMmI0?=
 =?utf-8?B?cFhRU1V6aWdBeW54czlDaTFBK1hNeXNKSkEzQVU0bjJFZjZYWkw1VVpIeitP?=
 =?utf-8?B?S29yc2VpSW1udXYwajQ5dFF1MnVneTBZZktvUGpQckxlZEE0RnZKQmxHZmdU?=
 =?utf-8?B?VExEUXIzelJIckk1Z1FJeXNZdEdjaGZaUGVCMXRPWUx4cUFiQ0VVK2IyVHd1?=
 =?utf-8?B?ZXVpd0lPdzNDMFdjRmE4UHVBbStaMVZIN01WK2tqL1J5dUVYT0JMeFg0VHly?=
 =?utf-8?B?NHZHM0ovMDBzQUR0cTgvZXY5VkJDNENCOUNXSHh4NkNadlF2b1BsZmxCK3M0?=
 =?utf-8?B?RkFCeGt5aGZDdHI3TlhkcjFWaDVhQnFDdWFpNXZ2WG1QckdHNjhiUHZ0dDla?=
 =?utf-8?B?WXF6UEdlRHZzV28vRFhRRnlyaC9KRVI1WHRoYmZ1UHR3bjJlSzM2ZXVZNWtP?=
 =?utf-8?B?RU1sUWNHRWlTUE93cXpzZWFSN0xtajBmbFVCYzZSbWoxQitrK2NUZDZaT2lB?=
 =?utf-8?B?NnJ6VEVvNWxJOGdadU9aNjhOVWVESVpXeTFubGlZUnMvcjdEZnIzUU4zS05X?=
 =?utf-8?B?M3U3TlVNbTZZaVh5NDF0RjdvR3ZjbW41TW1KNTRyMjNhYXJNVlFhYzhCdkxn?=
 =?utf-8?B?NTJFam8xYUVYMERSd1VWN2N2OXgwQ0RNamx3cEd3T1VkaFg3SUVYL1NFcEJX?=
 =?utf-8?B?S1ZLMDRRamh0djVFaVNzQzlDL2UxTUpMY3YrYlFRblNIY0h3R0VYYi83K2Q0?=
 =?utf-8?B?cWN3U1RRWVRKL3ZtMGVJMkh1d2E2Q2xON1JZUXQzaE9ua0Q0OXJ2bHlzN2hO?=
 =?utf-8?B?L1UyanRvWksySFNlK090b21jWGlSRVpodEFqYUYxVzNiVjRKRDRkVGhQT0Nm?=
 =?utf-8?B?SXk2T1hqcWU4UVNmWlRCcDl0cmFJYm1hZ3RrdkJmZ0k2UERlTVpXNGFsL3NH?=
 =?utf-8?B?aVA2ZmdJcktveTdRcDJSeDduYjR0OVlyeE1aK0d2ZDRTUzRGYnZVM0I1eDIy?=
 =?utf-8?B?RXNraXZlU3Mzc05Ga3BjZTQzbUZaekRBWjdDcS9sV2xPc2xNNko5d3llQlJz?=
 =?utf-8?B?SzhiNHppY0t4WDRZK1paRjBrSjNUZ2NLTGIvUGdadDdjQmlzYlQ1T1FQMUNM?=
 =?utf-8?B?bzk2WGlWWkRaNThsd1dhUll1bUR1WWJacTVEUmpwRzJMN2d3Y2pSTXQ1aGw1?=
 =?utf-8?B?dGdTcENTQUdsRElKcjVQUEZ0WnBDZVZvUXl2Q21ZbktxV0NzMU1RZkJJK015?=
 =?utf-8?B?dHBveVc4Y0xhcmpFT1pia0RpaVpNM0pGY0JsOXk1UmZpcFpjRVlXY3Ivckdt?=
 =?utf-8?B?djEzaUdnQ0hQemgvUzBSRVJqQ2o1WENVbTZITlNkMGNnKzZaNFU3MU10WEVw?=
 =?utf-8?B?K0REK2lvdW1tTyt1SXp6WjdYK2dTaUtqUGpLZVh0YlVwa0hZcExVT2NTVUdH?=
 =?utf-8?Q?/pSgjGTmM0a2AId6vRqphG8=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 80a2a947-f381-4721-b07c-08d9e56cf06c
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2022 10:23:50.4238
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: e/2N5+Us7hIRZiqb6EpJhV+YPHxdzDzCTaPlQpJh3SGilwxMdujXnY1MOYEykGv/ZqVJTxNpvtojEckmgs+K7g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR03MB2255
X-OriginatorOrg: citrix.com

On Tue, Feb 01, 2022 at 08:56:49AM +0000, Oleksandr Andrushchenko wrote:
> Hi, Roger!
> 
> On 31.01.22 10:45, Oleksandr Andrushchenko wrote:
> > Hi, Roger!
> >
> > On 13.01.22 13:40, Roger Pau Monné wrote:
> >> On Thu, Nov 25, 2021 at 01:02:42PM +0200, Oleksandr Andrushchenko wrote:
> >>> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> >>> +#ifdef CONFIG_HAS_VPCI_GUEST_SUPPORT
> >>> +/* Notify vPCI that device is assigned to guest. */
> >>> +int vpci_assign_device(struct domain *d, struct pci_dev *pdev)
> >>> +{
> >>> +    int rc;
> >>> +
> >>> +    /* It only makes sense to assign for hwdom or guest domain. */
> >>> +    if ( is_system_domain(d) || !has_vpci(d) )
> >>> +        return 0;
> >>> +
> >>> +    spin_lock(&pdev->vpci_lock);
> >>> +    rc = run_vpci_init(pdev);
> >> Following my comment below, this will likely need to call
> >> vpci_add_handlers in order to allocate the pdev->vpci field.
> >>
> >> It's not OK to carry the contents of pdev->vpci across domain
> >> assignations, as the device should be reset, and thus the content of
> >> pdev->vpci would be stale.
> >>
> >>> +    spin_unlock(&pdev->vpci_lock);
> >>> +    if ( rc )
> >>> +        vpci_deassign_device(d, pdev);
> >>> +
> >>> +    return rc;
> >>> +}
> >>> +
> >>> +/* Notify vPCI that device is de-assigned from guest. */
> >>> +int vpci_deassign_device(struct domain *d, struct pci_dev *pdev)
> >>> +{
> >>> +    /* It only makes sense to de-assign from hwdom or guest domain. */
> >>> +    if ( is_system_domain(d) || !has_vpci(d) )
> >>> +        return 0;
> >>> +
> >>> +    spin_lock(&pdev->vpci_lock);
> >>> +    vpci_remove_device_handlers_locked(pdev);
> >> You need to free the pdev->vpci structure on deassign. I would expect
> >> the device to be reset on deassign, so keeping the pdev->vpci contents
> >> would be wrong.
> > Sure, I will re-allocate pdev->vpci then
> After thinking a bit more on this I have realized that we cannot free
> pdev->vpci on de-assign. The reason for that is the fact that vpci
> structure contains vital data which is collected and managed at different
> stages: for example, BAR types are collected while we run for the
> hardware domain and in init_bars we collect the types of the BARS etc.
> This is then used while assigning device to construct guest's representation
> of the device. Freeing vpci will lead to that data is lost and the required
> data is not populated into vpci.
> So, it is no possible to free vpci structure and I am about to leave the
> approach as it is.

We discussed this on IRC, and we have agreed that it's possible to
free pdev->vpci on deassign since in any case we need to call
init_bars (and other capability init functions) when the device is
assigned to setup the register traps and fetch the required
information in order to fill pdev->vpci.

Roger.


From xen-devel-bounces@lists.xenproject.org Tue Feb 01 10:42:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 01 Feb 2022 10:42:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.263487.456188 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEqbx-0005Wr-4w; Tue, 01 Feb 2022 10:42:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 263487.456188; Tue, 01 Feb 2022 10:42:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEqbx-0005Wk-1P; Tue, 01 Feb 2022 10:42:09 +0000
Received: by outflank-mailman (input) for mailman id 263487;
 Tue, 01 Feb 2022 10:42:07 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7bwX=SQ=epam.com=prvs=4031c7af39=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nEqbv-0005We-Eu
 for xen-devel@lists.xenproject.org; Tue, 01 Feb 2022 10:42:07 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 981cf660-834b-11ec-8eb8-a37418f5ba1a;
 Tue, 01 Feb 2022 11:42:05 +0100 (CET)
Received: from pps.filterd (m0174679.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 211A7RZ1007395;
 Tue, 1 Feb 2022 10:41:56 GMT
Received: from eur02-he1-obe.outbound.protection.outlook.com
 (mail-he1eur02lp2059.outbound.protection.outlook.com [104.47.5.59])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3dxv6cs5xr-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Tue, 01 Feb 2022 10:41:55 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by HE1PR0301MB2348.eurprd03.prod.outlook.com (2603:10a6:3:6e::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.21; Tue, 1 Feb
 2022 10:41:48 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6%3]) with mapi id 15.20.4930.022; Tue, 1 Feb 2022
 10:41:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 981cf660-834b-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=PP/YbYztSIdnz+ZGLWqESwkVg8E1Udvze2ms+4bRJ9Qk1/f8WxdA4dZOg/A4rPTYwn5B/Su1mon9esGSPJSRWe1NC3WFopSxp34/e94WzVGB2XCF6mc3OjjwXflGf/B/AIiIY7AoGHATGWzvj+kAcU5HQw1tGcgiNVDVWmx4ktk+7y8cQ5t/EDNENNNR8Pcq9Zcg3hODhwa7CdHZGPAKGJJaGIVQC/BDexn2rKQWpNUf8s3SAIQZcuIXZAvAHpHp8mph6MSKKICmSlL/GZftHheW4YmRvgTuGIXJFcnHEPIoJ6FqDrFeOqNJDslebfGpl0rUSF1Pb2fS/wbzp14wPw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=tDKrnjq2JPTwlH9H7M6cNz4lIiafKZCiyjfI1lfVmEc=;
 b=Bp3acx4DOSelFwvXX3Tac9TxvwNOBDovSeUlBRDxIEwUpdicaeJ5ju7bSsxtd6/gY9F/boMkgRIiU4Wm8DAXGFcZK8bBEZGg4Mbyl620T/VbuzipRlpyNyyZkyLi4sj0r+tVRLhWKyvi+0Ptw+ivDE3P8BgiuxHYuxQio4x53r+iLPnMX1Mz8u1ZEtQcDc81hB1rC7XZYr3edesPFTIvlembrswLkoUpL9fcApI3R/hErWKcEw7gOvAuk/JcvpKrOj1qugOOX61PprLv4Re4ffkRH8/Gs0NJLProMwHT6iI6vRZ9NuRGRNQ56804IjGQ7ID17UDTlQhFnXHwg8LFOg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=tDKrnjq2JPTwlH9H7M6cNz4lIiafKZCiyjfI1lfVmEc=;
 b=XXOcGyQ4ie4Pu+uJu/mF1fA9BAx1HNQxgBqNGv1rJpTGvXYPVTpc2kJcyVqZ35bO29r7S8gDX4pz0CcIU2fp7R0+yh96Asct+D7RM3NgzY+RDnQyoC40ayX0WbZ6Ut4LLpuH2O/6ILAtN30Fx4EG741aEfHon5yGx697i44wq7Ro9PT7c1RuOGo/ALB11S6zuD2a/ZrN5lmbjLn45/gnFClu9Iqonpttg3X8xtrtu3tevzscUEKJiFIsvCojJcXwzqfGVWI72Fp9GPfipRBgs9Lmyh4Ng8FIPbh5/7zsao5BzsTi14kz/NFmJQtFIgE9WsFC+K+s05FDH/2C3mOqMQ==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: Jan Beulich <jbeulich@suse.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org" <sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v5 06/14] vpci/header: implement guest BAR register
 handlers
Thread-Topic: [PATCH v5 06/14] vpci/header: implement guest BAR register
 handlers
Thread-Index: 
 AQHX4ewHyWAyD811HEGp8pIjUuVWNaxfndGAgB4GiwCAAAxbgIABBueAgAAsSACAAAjhgA==
Date: Tue, 1 Feb 2022 10:41:47 +0000
Message-ID: <1f123f78-0cf2-3388-4db2-986aaffca389@epam.com>
References: <20211125110251.2877218-1-andr2000@gmail.com>
 <20211125110251.2877218-7-andr2000@gmail.com> <Yd7K+9fvnBz+WTXA@Air-de-Roger>
 <082ca110-2ab7-60ff-e705-032d2d472547@epam.com>
 <df36767b-e04f-aa29-82af-87e8624bd29c@suse.com>
 <c82f94c4-dadf-7b2d-4d30-a1de2b5f962a@epam.com>
 <YfkG91cg+fAHFPGd@Air-de-Roger>
In-Reply-To: <YfkG91cg+fAHFPGd@Air-de-Roger>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: f4a13da5-0456-4ad1-22a0-08d9e56f72d9
x-ms-traffictypediagnostic: HE1PR0301MB2348:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <HE1PR0301MB2348AABF8BC038D66127DCE3E7269@HE1PR0301MB2348.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 MnJaDHlxNCTe1oqkzhc9q7RIoTwrCV82OKNS17PqYfM9YxxXyUU2bAkx6jlNSyAkdtaurFNxK0tmNTD/TxU7UoGti7zU7dFOE2zQpPt9215UL82B0BHUDbFY71wAbcRH5zAfAx9Q+Rry+yfYJg5paFl5cCxn+ln7p9cvy9LZZ/FlUGpN1iElIahsIsJkpcB6xzUT8AFyLr2Xcw8HXH5fmsgxmeg7Cqc2VpRLRo4jjnof5rWxrpCsZ0E0xxbvvxBasbGpuJq3InlqDvhF6JCHS3r/tFEKoe2EmzgccPoI06763MMSpGLZhhSLDPN/MWu5/SnbREM+It/Yt6yPFn5GI4zYcdz4nSm5lTYv+E7kbeZ92fasSq7qdtMRxD2ReH8GqQYW48HGl11+y3B0gzMFqimrTKbM92ASiQlULsv11iENJzd0ZF/RA5LahoZAwwjahNSFRBC5VFEDdKVjsRvTdJVpWqyCrJqE6DdoGsV6Zt85UX3Sb7EUExUSxtwCSpQRpdymFqVMsVeiGeeCrn+hn2NwviDogAcFlIDi1kyrcGfJwLcGVhlLcTVRpC8FXG1PCf3eySO2PXXvQodtAv09uDV5lDaGDzk01MCRZNF1jObqxDqvjRKehPEkJ8NDkNv8Zldzx6UmEd3vVNuWhWksNTzGzX7ehgekIMCAmcoERTXdZzRzQz3X+YAnhl/saB5qdYUuWUWx4BYLw3iOo6Dk38lPVoO9Ipe6iYsNOW746G4w4PNKlm/8V9hrDQ8kaTTy
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(53546011)(38100700002)(4326008)(107886003)(2616005)(8936002)(8676002)(122000001)(76116006)(91956017)(66946007)(6506007)(83380400001)(66446008)(66556008)(64756008)(66476007)(2906002)(316002)(54906003)(86362001)(36756003)(6486002)(5660300002)(38070700005)(7416002)(6916009)(26005)(6512007)(31686004)(186003)(508600001)(31696002)(71200400001)(45980500001)(20210929001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?M25BdnZ6QWd0a1U0bC90U1BkMVZ6dlg4R0o4djRSTnJwb3BxcWpFN2piL1Vj?=
 =?utf-8?B?SUFaM3h5ejUrSkcycnFOUVBDaml3eWFTYm1tbS9YZytkOUVXOWZzdi91WXgx?=
 =?utf-8?B?RWpodUFVbDI3OE9lY1MrNDZZOUZiOVAvamhqclNldXdFT0FWNDhqUUJTNWda?=
 =?utf-8?B?SThBSzhxMnA0SCtaSGgxQTczV2FpMlFSMVllbEJWeVZNR0s1SXJtR3JQenJw?=
 =?utf-8?B?R2tWaFcrcTJ0MlVRcWZaWmRPc1hHTEExL1hZYWxSY05YbmhUNElkUGJtOEFP?=
 =?utf-8?B?YXhmVk45VjVOMnpVT0MvTENodC9rTURnRThQWk5Ta0t6VTVMbzQwNjhNLzFo?=
 =?utf-8?B?YXdOL0Q2Q2JIUlBNQmVTcXo1Nkk3N1RtdWIvVjVZUXpvaGlrRmUwTU83bGIv?=
 =?utf-8?B?d1NWSWhkU3pVUXZyR2xuRlhHQkRycTFrOUdzNnVTdmhYbUVsc0F2UFFFVytn?=
 =?utf-8?B?cVkvNFBKUkxpRXQ1eUJaN1l2TEJSRnA2NnQ1SU5TblhuajlMQ2pqQWFRdWpF?=
 =?utf-8?B?OGl4Tk5yaEVORjYxTjdlWWl4YTR4SWZNMDlPZHl4eWgyU2lma0VPMjg3eU5T?=
 =?utf-8?B?YVlTZUplSGxaNzN3UmROdW5zcmsxSHNzY2VIRnNEZC9HZXNuMUd1MS9aNVV1?=
 =?utf-8?B?OG85cHVCczBQZExadUpoc2Z3Y0FCTlR5NWkzcEdkNnQ1L29oLzJuR003ZHFp?=
 =?utf-8?B?NG13K1FvMFNUTkRaT0NpNDU0MzZZVjBPbk4rVjVsYjROVkhWa292R2hHRXc4?=
 =?utf-8?B?R2E5QTUwOWFNMXhvaVZ4T3oyZ1dkYUZpTXlVdGkyMnlJQmZscHVhNnFkN3g3?=
 =?utf-8?B?TXBUNG9KdW5WTTAxRGZrNVI0MFR2dUFUM1V1MlNIblFpTmRMbW01aEgzbWp4?=
 =?utf-8?B?VFdBMkxOS0pmS1l6Wm4wSFlYNng2TkpRUUV5NDNvQXZGQW9PM3FNL3JuaWZq?=
 =?utf-8?B?eXB0dkdrQnh5bHhOREI5RnJkY3FwaFlTU1lCMlVTK0ZFaFo2bEdGU1oxTWxX?=
 =?utf-8?B?dWI3Wi9WVEpqMHQ3N1VVZzNUbTVma3Rtc2d0cHZ3NlVncW9PN0xkYXR3RkhN?=
 =?utf-8?B?ZFBOdnVkWGQ1V0NONHhRS01mZjJmRWh3RmlNTGdtbEx0cmd6V1RxNUxucGk0?=
 =?utf-8?B?emVMYWpkajhYNndQd1Q1T2dSSEtFVm05UWdQR3kxS1JJV1czb0pQRFdudE9F?=
 =?utf-8?B?cEFzOUlFQXJCeUM1YmgvUGxGY2Z6dHVWTEFpYitUZUVCUkgrQy9scW1CeHNM?=
 =?utf-8?B?YVd4K1BGbm9JZ2k0dDhFaHJMYTRUSjIvc2FWamZCM3REWTg5UWtIaUdtUDN3?=
 =?utf-8?B?cXc5b3RwSnB4NmhGYnRCSjBpN3pMMzFVSmNQYjlBVFVPL29ZWGU3QWxncWNJ?=
 =?utf-8?B?L3hSem1tRmtoeTVkNVFFbU5SVmM0VkFkNjlGWGRUdldVUkhVbTI3aDYwZUwy?=
 =?utf-8?B?MXNFYW5wNjVvMWhRMXNFZjNwTU5keEV6RXh3ak95bmFtblRNSDc3NC91OHFH?=
 =?utf-8?B?QXYxSUxZQUpPTHBqTFNmSUVoT24xWUNxM05LUzBsWURxejR1WWpZb3RBdTI2?=
 =?utf-8?B?c3BhUllmZTBWV3RTSlIzUGdnanE1TGtsVjZxZ2FycnBPc0pISU1NU3RUMGJU?=
 =?utf-8?B?ckJBSVlRODYyRDV3YnFNTjdERDdTV2FDdzFLY1pkR2hBL0ZZZzBXS3RoWlpK?=
 =?utf-8?B?VUJ0YjBEY21JWVFSQnM0WXJmMENkaE91VzhCNlZvQlVTWXNuOXM4dnRKRDNm?=
 =?utf-8?B?Z21QemNpTWE5Z3Y2U3VocSt1a1MwdDRLdnEzdzZwUlk3eFMzVU9ZQzlteWVY?=
 =?utf-8?B?YlBXOHBxaythR1Qwb2ZaYkJvVEpCMGNmRDJ3K3c0TU5aVlpjeFVKTTBFSkta?=
 =?utf-8?B?dVE4T3lBaHVGRWVMcGVMM2VES2ZxQzcvYXdPUnJ5OVI0OW5seVZLT0V3WmIy?=
 =?utf-8?B?YktJQ24zRWRqQTBKOFdvMndBcmN6VXE1MkFua1EvOG9GNVh0dEhPVk1TZmJW?=
 =?utf-8?B?RnFTc25JOEl5UlFYRFBjcmd1Zm5iVmhqZHpJZWY1ZGJld21iWHRpQnB3R2xn?=
 =?utf-8?B?Tzk0ejNnaUVBbkFDNmY5RU9nN3lYQVE4MzloT2N6V1FFR1lpeVVkcmU3elRy?=
 =?utf-8?B?NmNQMW5kQkkyWDA4em9TRnFnOVVnbXpHWnZoNlBZejNueVlleXc1bzc1RG0y?=
 =?utf-8?B?Ky8vWDY2eUFQK3dmR29RR0E0ekJhSDJBVHFvTlliTVBNRitUeGtoZlptR3gz?=
 =?utf-8?B?NzlpN29oTlBMbUxKTTg0VzZTNGxUWFFjVnRHK1N4ajc4SkxxY1ZpeGd3NThy?=
 =?utf-8?B?eUZ0UDZ0THZtcnVuZG9wU0hnRVBpTlFvWFY1bGdlU0RzMFp6b3RJZz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <6F0C035C8067C8439D717CBD807B8BE9@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f4a13da5-0456-4ad1-22a0-08d9e56f72d9
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Feb 2022 10:41:47.9191
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: MbMEw1yCGn2OwsppmbGx4KrOlELkmDBm6MqL999LSAfwaFvdvKILiSa2J/ltv7LUaKv5B+s+5MHsG9m0srpokm5OAoWReY7AUF00LaqIu2TnUzBX+mb9I/ghUFcvTzMl
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0301MB2348
X-Proofpoint-ORIG-GUID: L4N6btNoXX579pL8nF0OrPTa51hTyt6-
X-Proofpoint-GUID: L4N6btNoXX579pL8nF0OrPTa51hTyt6-
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-01_03,2022-02-01_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 suspectscore=0
 clxscore=1015 adultscore=0 lowpriorityscore=0 impostorscore=0
 mlxlogscore=999 priorityscore=1501 mlxscore=0 malwarescore=0 spamscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202010059

SGksIFJvZ2VyIQ0KDQpPbiAwMS4wMi4yMiAxMjoxMCwgUm9nZXIgUGF1IE1vbm7DqSB3cm90ZToN
Cj4gT24gVHVlLCBGZWIgMDEsIDIwMjIgYXQgMDc6MzE6MzFBTSArMDAwMCwgT2xla3NhbmRyIEFu
ZHJ1c2hjaGVua28gd3JvdGU6DQo+Pg0KPj4gT24gMzEuMDEuMjIgMTc6NTAsIEphbiBCZXVsaWNo
IHdyb3RlOg0KPj4+IE9uIDMxLjAxLjIwMjIgMTY6MDYsIE9sZWtzYW5kciBBbmRydXNoY2hlbmtv
IHdyb3RlOg0KPj4+PiBIaSwgUm9nZXIhDQo+Pj4+Pj4gICAgICAgICAgICAgICAgIHJvbS0+dHlw
ZSA9IFZQQ0lfQkFSX0VNUFRZOw0KPj4+Pj4+ICAgICAgICAgfQ0KPj4+Pj4+IGRpZmYgLS1naXQg
YS94ZW4vaW5jbHVkZS94ZW4vdnBjaS5oIGIveGVuL2luY2x1ZGUveGVuL3ZwY2kuaA0KPj4+Pj4+
IGluZGV4IGVkMTI3YTA4YTk1My4uMGE3M2IxNGE5MmRjIDEwMDY0NA0KPj4+Pj4+IC0tLSBhL3hl
bi9pbmNsdWRlL3hlbi92cGNpLmgNCj4+Pj4+PiArKysgYi94ZW4vaW5jbHVkZS94ZW4vdnBjaS5o
DQo+Pj4+Pj4gQEAgLTY4LDcgKzY4LDEwIEBAIHN0cnVjdCB2cGNpIHsNCj4+Pj4+PiAgICAgICAg
IHN0cnVjdCB2cGNpX2hlYWRlciB7DQo+Pj4+Pj4gICAgICAgICAgICAgLyogSW5mb3JtYXRpb24g
YWJvdXQgdGhlIFBDSSBCQVJzIG9mIHRoaXMgZGV2aWNlLiAqLw0KPj4+Pj4+ICAgICAgICAgICAg
IHN0cnVjdCB2cGNpX2JhciB7DQo+Pj4+Pj4gKyAgICAgICAgICAgIC8qIFBoeXNpY2FsIHZpZXcg
b2YgdGhlIEJBUi4gKi8NCj4+Pj4+IE5vLCB0aGF0J3Mgbm90IHRoZSBwaHlzaWNhbCB2aWV3LCBp
dCdzIHRoZSBwaHlzaWNhbCAoaG9zdCkgYWRkcmVzcy4NCj4+Pj4+DQo+Pj4+Pj4gICAgICAgICAg
ICAgICAgIHVpbnQ2NF90IGFkZHI7DQo+Pj4+Pj4gKyAgICAgICAgICAgIC8qIEd1ZXN0IHZpZXcg
b2YgdGhlIEJBUjogYWRkcmVzcyBhbmQgbG93ZXIgYml0cy4gKi8NCj4+Pj4+PiArICAgICAgICAg
ICAgdWludDY0X3QgZ3Vlc3RfcmVnOw0KPj4+Pj4gSSBjb250aW51ZSB0byB0aGluayBpdCB3b3Vs
ZCBiZSBjbGVhcmVyIGlmIHlvdSBzdG9yZSB0aGUgZ3Vlc3QgYWRkcmVzcw0KPj4+Pj4gaGVyZSAo
Z2FkZHIsIHdpdGhvdXQgdGhlIGxvdyBiaXRzKSBhbmQgYWRkIHRob3NlIGluIGd1ZXN0X2Jhcl9y
ZWFkDQo+Pj4+PiBiYXNlZCBvbiBiYXItPnt0eXBlLHByZWZldGNoYWJsZX0uIFRoZW4gaXQgd291
bGQgYmUgZXF1aXZhbGVudCB0byB0aGUNCj4+Pj4+IGV4aXN0aW5nICdhZGRyJyBmaWVsZC4NCj4+
Pj4+DQo+Pj4+IEkgYWdyZWVkIGZpcnN0IHRvIGRvIHN1Y2ggYSBjaGFuZ2UsIGJ1dCB0aGVuIHJl
Y2FsbGVkIG91ciBkaXNjdXNzaW9uIHdpdGggSmFuIFsxXS4NCj4+Pj4gQW5kIHRoZW4gd2UgZGVj
aWRlZCB0aGF0IGluIG9yZGVyIGZvciBpdCB0byBiZSBlZmZpY2llbnQgaXQgaXMgYmV0dGVyIGlm
IHdlIHNldHVwIGFsbCB0aGUNCj4+Pj4gdGhpbmdzIGR1cmluZyB0aGUgd3JpdGUgcGhhc2UgKHJh
cmUpLCByYXRoZXIgdGhlbiBkdXJpbmcgdGhlIHdyaXRlIHBoYXNlIChtb3JlIG9mdGVuKS4NCj4+
PiBTbWFsbCBjb3JyZWN0aW9uOiBUaGUgMm5kICJ3cml0ZSIgd2FzIGxpa2VseSBtZWFudCB0byBi
ZSAicmVhZCIuDQo+PiBZZXMsIHRoaXMgaXMgY29ycmVjdC4NCj4+PiAgICBCdXQNCj4+PiBwbGVh
c2UgcmVjYWxsIHRoYXQgUm9nZXIgaXMgdGhlIG1haW50YWluZXIgb2YgdGhlIGNvZGUsIHNvIGhl
IGdldHMNCj4+PiB0aGUgZmluYWwgc2F5Lg0KPj4gQWdyZWUsIGJ1dCB3b3VsZCB2b3RlIGZvciB0
aGUgY3VycmVudCBhcHByb2FjaCBhcyBpdCBzdGlsbCBzYXZlcyBzb21lDQo+PiBDUFUgY3ljbGVz
IG1ha2luZyB0aGUgcmVhZCBvcGVyYXRpb24gcmVhbGx5IHRpbnkNCj4gSSB0aGluayB5b3UgbmVl
ZCB0byBidWlsZCB0aGUgbWFwcGluZyByYW5nZXNldChzKSBiYXNlZCBvbiBndWVzdA0KPiBhZGRy
ZXNzZXMsIG5vdCBob3N0IG9uZXMsIHNvIGl0J3MgbGlrZWx5IGdvaW5nIHRvIGJlIGVhc2llciBp
ZiB5b3UNCj4gc3RvcmUgdGhlIGFkZHJlc3MgaGVyZSBpbiBvcmRlciB0byB1c2UgaXQgd2hlbiBi
dWlsZGluZyB0aGUgcmFuZ2VzZXQuDQo+DQo+IE92ZXJhbGwgdGhlIGNvc3Qgb2YgdGhlIHZtZXhp
dCB3aWxsIHNoYWRvdyB0aGUgY29zdCBvZiBkb2luZyBhIGNvdXBsZQ0KPiBvZiBPUnMgaGVyZSBp
biBvcmRlciB0byByZXR1cm4gdGhlIGd1ZXN0IHZpZXcgb2YgdGhlIEJBUi4NCj4NCj4gSWYgeW91
IHRoaW5rIHN0b3JpbmcgdGhlIGd1ZXN0IHZpZXcgb2YgdGhlIEJBUiByZWdpc3RlciB3aWxsIG1h
a2UgdGhlDQo+IGNvZGUgZWFzaWVyIHRvIHVuZGVyc3RhbmQsIHRoZW4gcGxlYXNlIGdvIGFoZWFk
LiBPdGhlcndpc2UgSSB3b3VsZA0KPiByZWNvbW1lbmQgdG8gc3RvcmUgdGhlIGFkZHJlc3MgbGlr
ZSB3ZSBkbyBmb3IgdGhlIGhvc3QgcG9zaXRpb24gb2YgdGhlDQo+IEJBUiAoaWU6IGFkZHIgZmll
bGQpLg0KSSBzdGlsbCB0aGluayBpdCBpcyBlYXNpZXIgdG8gdW5kZXJzdGFuZDogaWYgeW91IHRh
a2UgYSBsb29rIGF0IHdoYXQgd2UgZG8NCmZvciBCQVIgd3JpdGUgZm9yIGJvdGggaG9zdCBhbmQg
Z3Vlc3QgeW91J2xsIHNlZSB0aGF0IHdlIGRvIGFsbW9zdCB0aGUNCnNhbWUgb3BlcmF0aW9ucywg
YnV0IGluIGhvc3QgY2FzZSB3ZSBlbmQgdXAgd3JpdGluZyBiYXItPmFkZHIgKyBsb3cNCmJpdHMg
dG8gdGhlIEhXIHJlZ2lzdGVyIGFuZCBpbiBjYXNlIG9mIGEgZ3Vlc3Qgd2Ugc3RvcmUgdGhlIGNv
bXBsZXRlDQp0aGluZyBpbnRvIGJhci0+Z3Vlc3RfcmVnLiBSZWFkIG9wZXJhdGlvbiBkb2Vzbid0
IHJlcXVpcmUgYW55IHByb2Nlc3NpbmcNCmZvciBob3N0LCBzbyBpdCBpcyBlcXVpdmFsZW50IHRv
IGRpcmVjdCBodyByZWFkIGFuZCBpbiBjYXNlIG9mIGEgZ3Vlc3QgaXQNCmlzIGFzIHNpbXBsZSBh
cyBwb3NzaWJsZSBhbmQgaW1wbGVtZW50cyB0aGUgZXF1aXZhbGVudCBieSByZXR1cm5pbmcNCnBh
cnQgb2YgYmFyLT5ndWVzdF9yZWcgKGhpIG9yIGxvKS7CoCBTbywgZnJvbSB0aGlzIFBPViBpdCBp
cyBJTU8gZWFzaWVyIHRvDQp1bmRlcnN0YW5kIHRoZSBsb2dpYy4NClRoYXQgYmVpbmcgc2FpZCwg
SSBkbyBhZ3JlZSB0aGF0IHRoZSBjb250ZW50cyBvZiB0aGUgYmFyLT5hZGRyIGlzIG5vdA0KZXF1
aXZhbGVudCB0byBiYXItPmd1ZXN0X3JlZywgYnV0IHdlIGhhdmUgYWxyZWFkeSB0YWtlbiBjYXJl
IG9mIGl0DQpieSBuYW1pbmcgdGhlIGd1ZXN0J3Mgb25lIHdpdGggZ3Vlc3RfcmVnLCBub3QgZ3Vl
c3RfYWRkci4NCg0KSSB3aWxsIGtlZXAgdGhlIGNvZGUgYXMgaXMgdGhlbi4NCj4NCj4gVGhhbmtz
LCBSb2dlci4NClRoYW5rIHlvdSwNCk9sZWtzYW5kcg==


From xen-devel-bounces@lists.xenproject.org Tue Feb 01 10:45:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 01 Feb 2022 10:45:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.263493.456199 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEqfS-00068W-L9; Tue, 01 Feb 2022 10:45:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 263493.456199; Tue, 01 Feb 2022 10:45:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEqfS-00068P-Ho; Tue, 01 Feb 2022 10:45:46 +0000
Received: by outflank-mailman (input) for mailman id 263493;
 Tue, 01 Feb 2022 10:45:45 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nEqfR-00068J-EQ
 for xen-devel@lists.xenproject.org; Tue, 01 Feb 2022 10:45:45 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nEqfR-00013B-31; Tue, 01 Feb 2022 10:45:45 +0000
Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=[10.95.141.48])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nEqfQ-0007mH-RH; Tue, 01 Feb 2022 10:45:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=ZPCUgDWfXSAAr9lPrx18ihP+HRSLDlvXLGuB2Spz6H4=; b=P55YRVkMyY94EME1GnRJ1oSLT9
	aV9t6gY5p3TMFU8SZbis6R7BdCx9qNz8hhZbNmzFvducmTkn3qfwnyyHGJKsSBPIALwSNu1d2Q4yo
	cOavlf23BsnKN4KX2u3xy6nB7D8ZMCFHXczTXJgfXGxcKaO7RaXZPX6teAkW3UzA5cdo=;
Message-ID: <7d9af246-9338-7862-6fee-b72f2ae6c4cc@xen.org>
Date: Tue, 1 Feb 2022 10:45:42 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.1
Subject: Re: [XEN v5] xen/arm64: io: Decode ldr/str post-indexing instructions
To: Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>,
 xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com,
 bertrand.marquis@arm.com, Ayan Kumar Halder <ayankuma@xilinx.com>
References: <20220131193728.2980-1-ayankuma@xilinx.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220131193728.2980-1-ayankuma@xilinx.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 31/01/2022 19:37, Ayan Kumar Halder wrote:
> At the moment, Xen is only handling data abort with valid syndrome (i.e.
> ISV=0). Unfortunately, this doesn't cover all the instructions a domain
> could use to access MMIO regions.
> 
> For instance, a baremetal OS can use any of the following instructions, where
> x1 contains the address of the MMIO region:
> 
> 1.      ldr     x2,    [x1],    #8
> 2.      ldr     w2,    [x1],    #-4
> 3.      ldr     x2,    [x1],    #-8
> 4.      ldr     w2,    [x1],    #4
> 5.      ldrh    w2,    [x1],    #2
> 6.      ldrb    w2,    [x1],    #1
> 7.      str     x2,    [x1],    #8
> 8.      str     w2,    [x1],    #-4
> 9.      strh    w2,    [x1],    #2
> 10.     strb    w2,    [x1],    #1
> 
> In the following two instructions, Rn could theoretically be stack pointer which
> might contain the address of the MMIO region:-
> 11.     ldrb    w2,    [Rn],    #1
> 12.     ldrb    wzr,   [Rn],    #1
> 
> In order to handle post-indexing store/load instructions (like those mentioned
> above), Xen will need to fetch and decode the instruction.
> 
> Xen will not decode the instructions if the data abort is caused by stage1
> translation table walk or cache instructions. In the former scenario, it will
> try to update the page tables and in the latter scenario, it will ignore the
> instruction (ie simply increment the program counter).
> 
> If Xen is unable to decode the instructions, it will abort the guest.
> 
> This patch only cover post-index store/load instructions from AArch64 mode.
> For now, AArch32 mode is left unimplemented.
> 
> Signed-off-by: Ayan Kumar Halder <ayankuma@xilinx.com>
> ---
> 
> Changelog :-
> v2 - 1. Updated the rn register after reading from it. (Pointed by Julien,
>          Stefano)
>       2. Used a union to represent the instruction opcode (Suggestd by Bertrand)
>       3. Fixed coding style issues (Pointed by Julien)
>       4. In the previous patch, I was updating dabt->sign based on the signedness
>          of imm9. This was incorrect. As mentioned in ARMv8 ARM  DDI 0487G.b,
>          Page 3221, SSE indicates the signedness of the data item loaded. In our
>          case, the data item loaded is always unsigned.
> 
> v3- 1. Handled all the variants of ldr/str (ie 64, 32, 16, 8 bit variants).
>         Thus, I have removed the check for "instr->code.opc == 0" (Suggested by
>         Andre)
>      2. Handled the scenario when rn = SP, rt = XZR (Suggested by Jan, Andre)
>      3. Added restriction for "rt != rn" (Suggested by Andre)
>      4. Moved union ldr_str_instr_class {} to decode.h. This is the header included
>         by io.c and decode.c (where the union is referred). (Suggested by Jan)
>      5. Indentation and typo fixes (Suggested by Jan)
> 
> v4- 1. Fixed the patch as per Stefano's comments on v3. They are as follows :-
>          1.1 Use macros to determine the fixed values in the instruction opcode
>          1.2 Checked if instr != NULL
>          1.3 Changed some data types and added #define ARM_64 for AArch64 specific
>              code
>          1.4 Moved post_increment_register() to decode.c so that the decoding
>              logic is confined to a single file.
>          1.5 Moved some checks from post_increment_register() to
>              decode_loadstore_postindexing()
>          1.6 Removed a duplicate check
>      2. Updated the commit message as per Andre's comments.
>      3. Changed the names of a label and some comments. *32bit* was erroneously
>         mentioned in a label and comments in decode_loadstore_postindexing()
>         although the function handled all variants of ldr/str post indexing.
> 
> v5- 1. Renamed decode_loadstore_postindexing() to decode_arm64(). The reason
>         being this will be extended in future to support more instructions for
>         which hsr_badt.isv = 0
>      2. Introduce a function try_decode_instruction_invalid_iss() to determine
>         if the instruction needs to be decoded before invoking decode_instruction().
> 
>         It checks :-
>         2.1  dabt->s1ptw - Returns IO_UNHANDLED
>         2.2  dabt->cache - Returns IO_IGNORED. (new enum instroduced to let the
>              caller know that the instruction needs to be ignored by Xen. Thus
>              the caller needs to increment the PC and return to the guest.
> 
>      3. Invoked try_decode_instruction_invalid_iss() from the following 2 places :-
>          3.a - try_handle_mmio() - When we have determined that there is a valid
>                mmio handler.
>          3.b - try_fwd_ioserv()
>          When ioserver completes the io request, the acknowledgement is sent via
>          handle_ioserv(). Here, we need to increment the register. As there is no
>          common data shared between try_fwd_ioserv() and handle_ioserv(), we need
>          to decode the instruction again in handle_ioserv() to determine rn, imm9.
> 
>          (NOTE to Reviewers) - This does not feel correct. However, I could not
>          think of a better approach. Please provide your inputs.
> 
>      4. Augumented struct hsr_dabt{} with struct hsr_dabt_instr_details{} to hold
>         rn and imm9. This is passed to post_increment_register() to update rn.
>      5. Other style changes as suggested in v4.
> 
>   Patch has been based on the comments received on the following two patches:-
>   1. https://lists.xenproject.org/archives/html/xen-devel/2022-01/msg01245.html
>   2. https://lists.xenproject.org/archives/html/xen-devel/2022-01/msg01279.html
> 
>   xen/arch/arm/arm32/traps.c  |  7 ++++
>   xen/arch/arm/arm64/traps.c  | 42 +++++++++++++++++++++
>   xen/arch/arm/decode.c       | 73 +++++++++++++++++++++++++++++++++++++
>   xen/arch/arm/decode.h       | 42 ++++++++++++++++++++-
>   xen/arch/arm/io.c           | 66 +++++++++++++++++++++++++++------
>   xen/arch/arm/ioreq.c        | 35 +++++++++++++++++-
>   xen/arch/arm/traps.c        |  1 +
>   xen/include/asm-arm/hsr.h   |  5 +++
>   xen/include/asm-arm/mmio.h  |  1 +
>   xen/include/asm-arm/traps.h |  1 +

I have tried to apply the patch on the latest staging. But this failed 
because xen/include/asm-arm was renamed to arch/arm/include/asm.

When sending e-mail to Xen-devel, please make sure to use the latest 
staging available.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Feb 01 10:46:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 01 Feb 2022 10:46:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.263499.456210 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEqgU-0006hE-Ve; Tue, 01 Feb 2022 10:46:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 263499.456210; Tue, 01 Feb 2022 10:46:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEqgU-0006h5-SX; Tue, 01 Feb 2022 10:46:50 +0000
Received: by outflank-mailman (input) for mailman id 263499;
 Tue, 01 Feb 2022 10:46:49 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JAuK=SQ=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nEqgT-0006gp-NW
 for xen-devel@lists.xenproject.org; Tue, 01 Feb 2022 10:46:49 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 40925db0-834c-11ec-8f75-fffcc8bd4f1a;
 Tue, 01 Feb 2022 11:46:48 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 40925db0-834c-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1643712408;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=UvKDuktzkK+C7c0DPsXKu5pFcyBMKdkkryjYz8rOEgc=;
  b=O5Hoknpp1hK0AtddRA8lfriUs0EbrxrzxkCszPib5RIUK+5Hm/Yp69jX
   jEtQI973z4EH46x9KbO63pMaTPEvXlgjY4vj9XfgKlK8U1RhaOYerKeEL
   B1/2Qk3HnL/y+K6ZRz8u5zzSQ8nsFJTUEPWzDl/+/JdDfJrlEyE7ftoXu
   s=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: xN3ZPd38sdnIDHmbhj/rJeJKXEAVbslWYhp6FZLjNJk3PHDetUAgPKXbtm6OwcgqMgeu/ud9A0
 PGh+AHRcXSNICS9wjHmWANawvVKqvQoMEUSSz/xqkGfc1nJwESgrwGP8/Vwacti9dgOWK//RiD
 U+zFadt3HEslYCDU4fvY9ZIPrVIAoQjeDFgAluu302GISMfnIYjkexxw4MvKwT/qZMDOux/3Ki
 EFuxbCxoxM3ip/LFnf7K3mKSKRc7rs3xPGn+etws1yOg3cPOKh6b/yPJN3DXvcFBealG7XfnnQ
 kP6oPpDIZ4pPjveI/cpset1/
X-SBRS: 5.2
X-MesageID: 63206331
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:e/M4U60c+6XumFjcovbD5TV2kn2cJEfYwER7XKvMYLTBsI5bpzIFm
 DQeCmjVa/2PZWr0etF1O4S1p04E7JHUzIJjTwQ5pC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkS5PE3oHJ9RGQ74nRLlbHILOCanAZqTNMEn9700o5w7dh2+aEvPDia++zk
 YKqyyHgEAfNNw5cagr4PIra9XuDFNyr0N8plgRWicJj5TcypFFMZH4rHomjLmOQf2VhNrXSq
 9Avbl2O1jixEx8FUrtJm1tgG6EAaua60QOm0hK6V0U+6/TrS+NbPqsTbZIhhUlrZzqhp41A5
 tl8io2MUw5yJYn3ybxDQkVKDHQrVUFG0OevzXmXtMWSywvNcmf2wuUoB0YzVWEa0r8pWycUr
 6VecW1TKEDY7w616OvTpu1EnMMsIdOtJIoCknph0SvYHbAtRpWrr6Diu4QChGlr3Zkm8fD2S
 +wpWWdrTjH6SDp9JQlJVZZ9nrzvmSyqG9FfgA3M/vdmi4TJ9yRu1JD9PdyTfcaFLe1Fk0Ddq
 m/Y8mDRBhABKMfZ2TeD6mirhOLEgWX8Qo16PL+y++NugVaT7ncOExBQXly+ycRVkWbnBYgZc
 RZNvHNz8+5iryRHU+URQTWA/U+qsi8jSuZKGrYhzDrckvTFvxSGUz1soiF6VPQqs8o/RDoP3
 1CPns/0CTEHjIB5WU5x5Z/P82rsZHF9wXsqIHZdEFBbu4WLTJQb00qXJuuPBpJZmTEc9dvY5
 zmR5BYziLwI5SLg//XqpAuX695AS3Wgc+LU2uk1dj//hu+aTNT8D2BN1bQ9xawaRGp+ZgLZ1
 EXoY+DEsIgz4WilzURhutklErCz/OqiOzbBm1NpFJRJ323zpyX+Ld8IsG8veBYB3iM4ldnBO
 hW7VeR5v8c7AZdXRfUvP9LZ5zoCkMAM6ugJptiLN4ETM/CdhSeM/T10ZF744oweuBNErE3LA
 r/CKZzEJS9DUcxPlWPqL89Aj+ND7n1glAv7GMCqpzz6gOH2TCPEFt843K6mM7pRAFWs+luFq
 r6y9qKiln1ibQEJSnCJqdZNdQxbcilT6FKfg5U/S9Nv6zFOQQkJI/TQ3akga8pimaFUnf3P5
 XazRglTz1+XuJENAV/ihqlLZOy9UJBhg2g8OCBwb1+k12J6OdSk7bsFdotxdr4irbQxwflxR
 vgDWsOBHvUQFWiXp2VDNcHw/N54aRCmpQOSJC75MjIxSIFtGl7S8dj+cwqxqCRXVnirtdEzq
 qGL3x/ARcZRXBxrCcvbMar9z164sXUHtvh1Wk/EfotadEn2qdA4IC3tlP4nZcoLLEyblDed0
 g+XBzYepPXM/NBpoIWY2/jcot7wQeVkH0dcE23K1pqMNHHXrji53ItNcOeUZjSBBmn6z7qvO
 LdOxPbmPfxZwFsT69hgE6xmxL4V7sf0o+MI1RxtGXjGYgj5Cr5kJXXaj8BDurcUm+1csAqyH
 EmO5sNbKfOCP8a8SAwdIw8sb+Ki0/AIm2aNsaRpcRuivCInrqCaVUhyPgWXjH0PJbR4B4op3
 OM9tZNE8Ae4kBcrbo6Lgy08G75g9ZDcv3HLbq0nPbI=
IronPort-HdrOrdr: A9a23:U9adMKqaWYiSk1EcigSfKFsaV5uzL9V00zEX/kB9WHVpm5Oj+P
 xGzc526farslsssREb+OxpOMG7MBThHLpOkPMs1NCZLXTbUQqTXfpfBO7ZrQEIdBeOlNK1uZ
 0QFpSWTeeAcWSS7vyKkTVQcexQueVvmZrA7Yy1rwYPcegpUdAZ0+4QMHfkLqQcfnghOXNWLu
 v52iIRzADQBkj/I/7LTUUtbqzmnZnmhZjmaRkJC1oO7xSPtyqh7PrfHwKD1hkTfjtTyfN6mF
 K13jDR1+GGibWW2xXc32jc49B/n8bg8MJKAIiphtIOIjvhpw60bMBKWqGEvhoyvOazgWxa2u
 XkklMFBYBe+nnRdma6rV/E3BTh6i8n7zvYxVqRkRLY0LrEbQN/L/AEqZNScxPf5UZllsp7yr
 h302WQsIcSJQ/cnQzmjuK4GS1Cpw6Rmz4PgOQTh3tQXc81c7lKt7ES+0tTDdMpAD/60oY6C+
 NjZfusq8q+SWnqL0wxg1Mfg+BFBh8Ib1W7qwk5y4CoOgFt7TFEJxBy/r1bop8CnKhNPKWsqd
 60dpiAr4s+PfP+W5gNcNvpcfHHelAlfii8Ql56AW6XXZ3vaEi946Ie3t0OlZSXkdozvdwPpK
 g=
X-IronPort-AV: E=Sophos;i="5.88,333,1635220800"; 
   d="scan'208";a="63206331"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=FUpk3FUha+gNtug8o3BdG++LhOsKphvCGgBHc8TBdsXifib2tLZeQCKt+R2OwMkLdUQHBmk/0VjK/oEWq/Zj9W9XumBaPE0wdRqxKBwPOUjAj+tQHs2seedLa9jNF/u5XkOnSdXiW+Kgro+b8Md4Lbhj2VR5TzWv+R5Bw0QHx/bVAi5rmvg6KKlJdmEXw8OXElZaztlYFsIBWT/aP/kJwfL1Ofdz2jNfNlj/JKp5p7SrBQve1GBGCyKviC3Ip/DBBKoUFbKgKLUKpasHqSNf3OWvm3iYm0sNn0mAWV9QkRN/KGbiWVbC/U/Z/Dk1VmgcPMd/Rgbs0eIrOpBZ3go+8A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=e+WMN5BOS0K+xYHBVO/0BL8FhkxwhPDMV5eBp038iCM=;
 b=DbG/6ZpA/9RPaiEUWltINJlHOxUkuMbmuNw7C7jb9nUzh2gkduMDYSbG87hT6vp92g/wuEqoZlbGp2gn/G8amhRWSnyEQ1lKnAcQaR09nIFn5NEFP76gNpy8h5cBlcVHwaz9L1+6djNKVKjnx8vRf9jqM5SZYBDXoK/z9hsoRu0LP2IILnM9xath27hxAmYkUlgvgEai10RK6dZuTivPlCp5cxSXdiLtjRiXIwJypHKtQiMcHrOhLr5ijLfw12WnK+ssSMxJBuDPpKUyXu61AOoAFAdi+XMB3qLBZl4Gh16grRNukgAH4ITCQHyutNxLltvmfI+V5qrSkSqAkDPbfg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=e+WMN5BOS0K+xYHBVO/0BL8FhkxwhPDMV5eBp038iCM=;
 b=plQjLbBm4nDwRhNrL6mREWUMPSbXWi6qdw8e+I/zH4p0S0GC4wKPUkjg+9t1OALPyFyiMA5T9PdLZRi9SDiEqFPQi9Wn7SgaRrTXTDTLc2OWB+3BHC551ja/qYDWs93VBy3wuomu5iqou7gFI0mo45A37a31CXhTzNeOXyTq/NU=
Date: Tue, 1 Feb 2022 11:46:10 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v3 1/2] x86/mwait-idle: enable interrupts before C1 on
 Xeons
Message-ID: <YfkPcm3GFI3MNoH3@Air-de-Roger>
References: <faff6a1e-9f00-e924-9766-deda8f0b38c1@suse.com>
 <379483c7-fe7d-16ee-454f-8f8dd001dc48@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <379483c7-fe7d-16ee-454f-8f8dd001dc48@suse.com>
X-ClientProxiedBy: LO2P265CA0111.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:c::27) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 692806a6-3456-49ec-684d-08d9e5701249
X-MS-TrafficTypeDiagnostic: BN6PR03MB2706:EE_
X-Microsoft-Antispam-PRVS: <BN6PR03MB2706583D2CB59F28E1B9382F8F269@BN6PR03MB2706.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: mp8W+jHiq6nGWF6WRVWrS0ZsTZtqHZvN+V9mpldCy4Wyr3a37MWK+cib67IrkVkg/pnSELL1TVr2UG3eKDD86Nf7JBSTadIKjp1tdNhP6wOMXPrAh2E4X/FuKCcGYDlTaelEIAhi/F2tsEjHVd77H0tddQt2YmftzBgquSVPEPD8vgztBwJGi7NEupyoevkKqAnrJFzaapUaZl2reKQ5GAdX8ILGh5n8BIu81lxQ152SHA2TQSYTKEb5Gh9Spl9h5KgAXAcAiTJxHFJsS2mQ1vQit6SCajHpXMZ0Gvlk7fOfqIr7GxAKSHLLG9o7lh418s4pzuAlSDZRTTDzozRc/VxKUXYAoQuksYGEyKE23bUS9bqiuXNQAPgkS8s+XmFDL8seuCBWHb8RGV2SihHGJ/JjP1JB6W+H+OXFFL0VDmDG5Me8R5iZhjc9vwCDBuIlsHw+zYhT4ET/fnZWtcnajqH6m8U0t3W1iSTBvZ9x5lkw1OjBugRG90jKqPqrK8ZjnnQdoPNF+37Gck4pcbigVU3AiqH22WZvYIIbRVFT2btxAfugQyU1HensYUWbPabFvllqL5Qp/TFr9ZPvDvYGeHzWjERdS3wQsz+TwoICNznwDDLUcPOIr6bbIVlXb+yn/wZzQ8ZcuA++B5YeZmdUm+gM4h6zhYmLbLhrS8Ng6NPLtgwW1WTE0XeWyFQbNzqr4kdcAtQ9RNWR5vPP8Tjasg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(38100700002)(508600001)(33716001)(82960400001)(66476007)(8936002)(86362001)(66556008)(66946007)(6666004)(8676002)(9686003)(6512007)(4326008)(5660300002)(6506007)(83380400001)(54906003)(6916009)(316002)(6486002)(2906002)(186003)(26005)(85182001)(21314003)(20210929001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SXEyYXhzRjR3aHpJZmlFOXVpeG1aa0NRdkk5bXpCY2VnSUd6c3hUc0pITlln?=
 =?utf-8?B?Rkw2SDN4TGZSSU9qbFRjR3hWMmRldVJJbGdvaDJ4VVppdnlKWHd1Vm14cFhu?=
 =?utf-8?B?dGYrK0VKOVJ3Vi9hS3hWSzd0VUMrZWZ6QzJjeE9aYVZaeTR4N0I3SHY5TUhI?=
 =?utf-8?B?NzdCVEpCZjdiSEl6R2NiR1pDL0piQmZ6cHNndXErdDRXaEdRN1V3UEJnSlht?=
 =?utf-8?B?NlVxR0dyTnE2RTFzMk1kTWovSzdXb0U3eGQ5V1dtR3dWYW0vNEJaMnZDeHVE?=
 =?utf-8?B?NzJWNmczUHJvckd1bGxCNEtCR3VVdTRVTzh4c2J0ait6NjZVdEx2Y0hsRWo1?=
 =?utf-8?B?MlArRE1qVnVBNEpCUWUwZUF3bFVadzNISnVocENsTURPTmZlSVNCUmF4L0NF?=
 =?utf-8?B?aE5hV2pGQ3VPRy9YSjJOSW5hQlJJQU9KYm94Snk2TWtmaWYyT1lYN1ZoQkpX?=
 =?utf-8?B?SGZ5RW1odFZSZGJjUi85bVcwRVlVdDZTQ0ZoVjdCa0dUV2Y2TllDSmM2Y3pq?=
 =?utf-8?B?SURuamp0dENtelE5bnd2UHl2Y055ZnBRTVJRak10NlZKTCtqOW8wblkwenFx?=
 =?utf-8?B?QmlJN3FTRVlpcStlaGRDenM4dlpwSHpha3NtZzBHQ3g3cjg4STRJRy8wSjM5?=
 =?utf-8?B?U3dtU1RCcnRUTGFsSjZoRVF4ZGpaRHdDSzRiZXY2UXN1ZUprcG85TWwxMlZj?=
 =?utf-8?B?VE9YSUtYWVlydnA4UUcrL2U1a21HV1E3Qi9jcW5HQU5Vb0tpbEhlWGwxdlZ2?=
 =?utf-8?B?VmJTTVU0VFhXYmo0WEcrSjJVR2FkRkR6bzR3bTFFbUVpa1BPeUZOQ08xaFoz?=
 =?utf-8?B?cG1LTUVIQjA2WSs0aDJIYzZ5M0hZMDFkMUJTcDQySEl3SjBsK1pwd01kWHdr?=
 =?utf-8?B?aEZTUkt4aGJuTVpXcGRqZkpoVjBIVm91WTY1NVh4UCttLzZ6MTd3YjY1UWdC?=
 =?utf-8?B?bUhkS0Q4M1BKeno2MDcyS2QxUGlzbkxxUkRlb2NYYkJrbC9nTkhPeGk2SjBn?=
 =?utf-8?B?ZkZYMGhoLzliQjVmYkZuQit2MEhEMXJoWFlaOFdoNTRrelc2N1grZW0vUnhB?=
 =?utf-8?B?OWNETmNTOU5VNUI4UkFGNEYyYTMwemRQKzBuVFpyeGFwanVTMnVKSVBsdDlP?=
 =?utf-8?B?bW1FVWR2cjRhUHBIK1N3L2FJdVFEdTgrL0NYY3JyQWZWeHdYTUxTbE1mRDQv?=
 =?utf-8?B?SXRLcWlKQmN0K09IZzlIbnJ4M2hCejhYYm1laCtNRlVSTlM1a0FlSWk0bEtG?=
 =?utf-8?B?Vk53RzgrUGc2ZEw5QjVZTHBYZnhFN1RPZnRiVXJWMUVHbzZwZVRJZlJkRVVO?=
 =?utf-8?B?YjhkcVZNYmFYUnJCR2FqeHBBZWxHblJ3RjVDanVyMkpKWUk2dWRVeVlLQTMy?=
 =?utf-8?B?K0xRS2NZcHlYVGpjbjBrR2RYZHdSeElMdnRYM0JJM2hocVJvRnlFMzl6a2Fs?=
 =?utf-8?B?cFlDeDFjckc0TGRIQ0RkOXpUUEIyamFlRVRHcGhkTWNHWGllU05pbzN6bm1T?=
 =?utf-8?B?L2hBUEdpOTZYZEpTa0p6OXRXRlVtWmZLWWVjZlpsOURtMnZkSzBvMlg4clg4?=
 =?utf-8?B?T0N5MjlkWnFrUm5HQ2J0UWMxZk00MFM2WFF4TWszbG9RUFIyNytRSjgySUE1?=
 =?utf-8?B?TDJkMDVkbDFhYXpRRnU5TkVYUXkzU1ZTUnJYNmNGR01GMWNYc1JyRDRweWEr?=
 =?utf-8?B?elVnR3dDenFHUXpKMWFDVk5Tb0duU1ZzbXJmYlhiUWJGR0tZTERkM25lZllM?=
 =?utf-8?B?Z1lUNE1OdHhlaCtRQithb1VDNjF2cS81NEhwOUtKa0FxYTJiY0w4bmpLOTlz?=
 =?utf-8?B?bFBsaHdOcTZROHM3L0xCMVNTeTI3bG05RndPQ2RxZDFVaU16MG9hVDNXZzVN?=
 =?utf-8?B?OHZHcWlYdURBa1pIdWhENnJOMDU1WUUvWmxSRGwwcDdsZ2VwUWQ1QktMWjhs?=
 =?utf-8?B?TkFqQ2RycHRONzdOZzlvTlZzclZYRFRoRlFLOVhtOURDWXJ5YTNjOGRLUU1o?=
 =?utf-8?B?SVdwcmJwR3ZWVjR5azFNYThiY21ZMVlyMVQ2VVVneVBDNUkwTjYyY2ZQa2kz?=
 =?utf-8?B?SU9vSGgya2RObVFZdzVhVHZ2NmJ6dDVXNnlCUGZybDB0ZEVOVm1MRWxjNXJW?=
 =?utf-8?B?ZmlGZUp2aWN2ZzM4ZEorRkYvUGgxeVhyZEdXUmNwdVJQeEdWcEMybFRwRXhn?=
 =?utf-8?Q?uN+z0mWjhUVAQ+bEOlkmOG0=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 692806a6-3456-49ec-684d-08d9e5701249
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2022 10:46:15.6641
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ReLBKocUj++bNuVS3bj9nanPaXyfjhCdX3c7pbmbU7i6Ieeh8BkEN0XDht71Q0y1BWPECewtX5X2E4ECRFb2NQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2706
X-OriginatorOrg: citrix.com

On Thu, Jan 27, 2022 at 04:13:21PM +0100, Jan Beulich wrote:
> From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
> 
> Enable local interrupts before requesting C1 on the last two generations
> of Intel Xeon platforms: Sky Lake, Cascade Lake, Cooper Lake, Ice Lake.
> This decreases average C1 interrupt latency by about 5-10%, as measured
> with the 'wult' tool.
> 
> The '->enter()' function of the driver enters C-states with local
> interrupts disabled by executing the 'monitor' and 'mwait' pair of
> instructions. If an interrupt happens, the CPU exits the C-state and
> continues executing instructions after 'mwait'. It does not jump to
> the interrupt handler, because local interrupts are disabled. The
> cpuidle subsystem enables interrupts a bit later, after doing some
> housekeeping.
> 
> With this patch, we enable local interrupts before requesting C1. In
> this case, if the CPU wakes up because of an interrupt, it will jump
> to the interrupt handler right away. The cpuidle housekeeping will be
> done after the pending interrupt(s) are handled.
> 
> Enabling interrupts before entering a C-state has measurable impact
> for faster C-states, like C1. Deeper, but slower C-states like C6 do
> not really benefit from this sort of change, because their latency is
> a lot higher comparing to the delay added by cpuidle housekeeping.
> 
> This change was also tested with cyclictest and dbench. In case of Ice
> Lake, the average cyclictest latency decreased by 5.1%, and the average
> 'dbench' throughput increased by about 0.8%. Both tests were run for 4
> hours with only C1 enabled (all other idle states, including 'POLL',
> were disabled). CPU frequency was pinned to HFM, and uncore frequency
> was pinned to the maximum value. The other platforms had similar
> single-digit percentage improvements.
> 
> It is worth noting that this patch affects 'cpuidle' statistics a tiny
> bit.  Before this patch, C1 residency did not include the interrupt
> handling time, but with this patch, it will include it. This is similar
> to what happens in case of the 'POLL' state, which also runs with
> interrupts enabled.
> 
> Suggested-by: Len Brown <len.brown@intel.com>
> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
> [Linux commit: c227233ad64c77e57db738ab0e46439db71822a3]
> 
> We don't have a pointer into cpuidle_state_table[] readily available.
> To compensate, propagate the flag into struct acpi_processor_cx.
> 
> Unlike Linux we want to
> - disable IRQs again after MWAITing, as subsequently invoked functions
>   assume so,
> - avoid enabling IRQs if cstate_restore_tsc() is not a no-op, to avoid
>   interfering with, in particular, the time rendezvous.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

> ---
> RFC: I'm not entirely certain that we want to take this, i.e. whether
>      we're as much worried about interrupt latency.

I would assume taking this would make it easier for you to pick
further patches.

> RFC: I was going back and forth between putting the local_irq_enable()
>      ahead of or after cpu_is_haltable().
> ---
> v3: Propagate flag to struct acpi_processor_cx. Don't set flag when TSC
>     may stop whild in a C-state.
> v2: New.
> 
> --- a/xen/arch/x86/cpu/mwait-idle.c
> +++ b/xen/arch/x86/cpu/mwait-idle.c
> @@ -108,6 +108,11 @@ static const struct cpuidle_state {
>  
>  #define CPUIDLE_FLAG_DISABLED		0x1
>  /*
> + * Enable interrupts before entering the C-state. On some platforms and for
> + * some C-states, this may measurably decrease interrupt latency.
> + */
> +#define CPUIDLE_FLAG_IRQ_ENABLE		0x8000
> +/*
>   * Set this flag for states where the HW flushes the TLB for us
>   * and so we don't need cross-calls to keep it consistent.
>   * If this flag is set, SW flushes the TLB, so even if the
> @@ -539,7 +544,7 @@ static struct cpuidle_state __read_mostl
>  static struct cpuidle_state __read_mostly skx_cstates[] = {
>  	{
>  		.name = "C1",
> -		.flags = MWAIT2flg(0x00),
> +		.flags = MWAIT2flg(0x00) | CPUIDLE_FLAG_IRQ_ENABLE,
>  		.exit_latency = 2,
>  		.target_residency = 2,
>  	},
> @@ -561,7 +566,7 @@ static struct cpuidle_state __read_mostl
>  static const struct cpuidle_state icx_cstates[] = {
>         {
>                 .name = "C1",
> -               .flags = MWAIT2flg(0x00),
> +               .flags = MWAIT2flg(0x00) | CPUIDLE_FLAG_IRQ_ENABLE,
>                 .exit_latency = 1,
>                 .target_residency = 1,
>         },
> @@ -842,9 +847,15 @@ static void mwait_idle(void)
>  
>  	update_last_cx_stat(power, cx, before);
>  
> -	if (cpu_is_haltable(cpu))
> +	if (cpu_is_haltable(cpu)) {
> +		if (cx->irq_enable_early)
> +			local_irq_enable();
> +
>  		mwait_idle_with_hints(cx->address, MWAIT_ECX_INTERRUPT_BREAK);
>  
> +		local_irq_disable();
> +	}
> +
>  	after = alternative_call(cpuidle_get_tick);
>  
>  	cstate_restore_tsc();
> @@ -1335,6 +1346,11 @@ static int mwait_idle_cpu_init(struct no
>  		cx->latency = cpuidle_state_table[cstate].exit_latency;
>  		cx->target_residency =
>  			cpuidle_state_table[cstate].target_residency;
> +		if ((cpuidle_state_table[cstate].flags &
> +		     CPUIDLE_FLAG_IRQ_ENABLE) &&
> +		    /* cstate_restore_tsc() needs to be a no-op */
> +		    boot_cpu_has(X86_FEATURE_NONSTOP_TSC))
> +			cx->irq_enable_early = true;
>  
>  		dev->count++;
>  	}
> --- a/xen/include/xen/cpuidle.h
> +++ b/xen/include/xen/cpuidle.h
> @@ -42,6 +42,7 @@ struct acpi_processor_cx
>      u8 idx;
>      u8 type;         /* ACPI_STATE_Cn */
>      u8 entry_method; /* ACPI_CSTATE_EM_xxx */
> +    bool irq_enable_early;

Should you use a bit field here and limit the field to :1 in
expectation of maybe adding more flags at a later point?

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Feb 01 10:57:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 01 Feb 2022 10:57:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.263511.456221 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEqqi-0008K4-6P; Tue, 01 Feb 2022 10:57:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 263511.456221; Tue, 01 Feb 2022 10:57:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEqqi-0008Jx-1Y; Tue, 01 Feb 2022 10:57:24 +0000
Received: by outflank-mailman (input) for mailman id 263511;
 Tue, 01 Feb 2022 10:57:22 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=0oSv=SQ=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nEqqg-0008Jr-NV
 for xen-devel@lists.xenproject.org; Tue, 01 Feb 2022 10:57:22 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id bab23a05-834d-11ec-8eb8-a37418f5ba1a;
 Tue, 01 Feb 2022 11:57:21 +0100 (CET)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2059.outbound.protection.outlook.com [104.47.6.59]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-18-ROVeqREKPG26qUe__Kf3CQ-1; Tue, 01 Feb 2022 11:57:19 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by PAXPR04MB8096.eurprd04.prod.outlook.com (2603:10a6:102:1c7::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.11; Tue, 1 Feb
 2022 10:57:18 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::7cc2:78a3:4d40:9d45]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::7cc2:78a3:4d40:9d45%6]) with mapi id 15.20.4930.022; Tue, 1 Feb 2022
 10:57:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bab23a05-834d-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1643713040;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=pY8BM5zZYdZJ+CGLGhbRBx4Ul0yoDcBNt29Q1qqtf54=;
	b=cp9ZvcFsSuuorNapAKA9c3zuO27jZAFR2AD76xV8ks4LnTZ+B5dKyuf2BWkqjPCgTcTLBy
	ZBlfyraE033PC6B5fsSCbTyeurmUIvAhBZ5p+M/bbITmeJjzS3fAV/hBXyIW284gnBF4m2
	+RGWmIzZ29iFCtetKn7yrcVzeWo3yB4=
X-MC-Unique: ROVeqREKPG26qUe__Kf3CQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=FJJrymzbkByTFbQi7oShfGULSsSWs7h+3bxq0VUCNSSSpTTcRw/HGaIyE72TRtjI3zBwLKAAFX0xWGVTqSocDFwhRR0rOr9Rz23/WOEHcKTgbYXIRsBvf0W8DuyA77P0sLj/bTV2hu+vtxQ0gkNlkY1s5kG8X+mP3ZOpV2Fb0kd4XBd/8wRJVLFjJdjmt3x5u2MIusV2itn3WBEWVwLs9xe5N60YErq2DcZY1Wp33888RxV4ZYMyU3OWeVTgL6F6Msj7RImIbPhbvRnrJ7EHx+AJnWYgUmQzAlmEFbPZgILwJwJaE6UNzFKA73f1uaK/kLCUYlMWeUSp/qllfLZJSA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=pY8BM5zZYdZJ+CGLGhbRBx4Ul0yoDcBNt29Q1qqtf54=;
 b=Y24cK6Ic0mAo3+eqh4RppKxJUHWl8mvF1IX1Fe/rKFhZjIDFuL6DACG/MYZsCMRQFlQkqgn1w6CHQLYrImozlyelIJgq+e06/Fl93Uu37cSI5ZarcPsRpdBmk5ox0zq6oeeLj8RFSc47JY2yYX0hGPi4Azg6TkPUSZORVcJ551CWRtZYw9NCgguHZARqDDJ/sqvffhhxb5MBB0cgv3HR4QiTaYCJWynzZ1QshaMgqzKemwzEgq0mO831SGehSiSHEv4f+Bbek9shdYS3yWn2597k3pQJcAJ/F9wJmyA6KcLGVHNNcPV33/93UuHZPO1DbZRZuhqrgQMsmEg/aMfiDw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <2dbd5f0a-9859-ca2d-085e-a02f7166c610@suse.com>
Date: Tue, 1 Feb 2022 11:57:16 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH] x86/Xen: streamline (and fix) PV CPU enumeration
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0081.eurprd04.prod.outlook.com
 (2603:10a6:20b:313::26) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 8a9a8dd0-5f8f-4b9b-93f0-08d9e5719d0c
X-MS-TrafficTypeDiagnostic: PAXPR04MB8096:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<PAXPR04MB8096ADDD5E49C7588FA0A04EB3269@PAXPR04MB8096.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	WWrlZ2a/yvDFoUiPtRrIrHpsySGnngHB89l0lB/z1ylRuNXunhA79EUO4NWFtnpclXSQEYNSRuMjf4i+HUK/D7VVBAoy/gDwHuqRR4VqS3C6MS6Tt5DGy+uS+PXeU557c7Me1hJpTE++n1MO6t+LnyiqFyw6FW+IEsqiW69q/taoeM6m3PaBrSEawMbCCMhqlHZoH8S/Ug3vyPpF9DrM/PaBu9jcOzbGFrMjVOC4Ck09Vk8iMwnoLfxEPpxWZ7cOBwhsrk+8rX8Iltvnu3EMPbM3shIj1l58kf0N5F6FD2TO9E/GLwwHbBVYY8wm4g9Lgb6NXnE38JVz0TZomUTJUSOMOYlelY6UAKBQ3yd0K48h47n/mzBC3glRxy56iIDMSfGoFSb9SCKtqds+8NnT0QCBN5U8MBLBzXeVwBFeF3h+iSkXsu9wBddd+TI7h1z3bTKuNmh8NVli2YCFNSrveb1N6Y2Gh5f8pT1cxBha6Kd2hGn9JX+IEgMbHk8ulnb5zn08ViH+tkQwP+n0IVSuMTf+ZP3lkfePlHqaOSXyZpJIGXmI+qJ0LeR42wGX6s6a4VjYTxftzAlmSCVTYHzXpyYQop2g4wgsX08G9EMPxr3L56JltCSLOrJsXpEFSSHAY/tFQvkEmhtBbfm0+sCb3ePv4560tbPV54FMDw/fctkXbUTEZFU4hHcRXTpUdxlcBQUQqM84U35MtjfSetZE6v0Yv7CwK3VPBbX6UE83kqk=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(110136005)(38100700002)(316002)(31696002)(186003)(6512007)(6506007)(26005)(66476007)(2616005)(36756003)(83380400001)(508600001)(6486002)(2906002)(8936002)(8676002)(31686004)(4326008)(5660300002)(66946007)(66556008)(86362001)(43740500002)(45980500001)(20210929001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VXRKd2tPczFoMDE0bEtCc01jczR3eERWWGswdndpcHVxS3lrTmFNQit4M0Zj?=
 =?utf-8?B?b3FrTWhhdktMZTJ5Sys5RUNUMHVBWGIrUjdaS3hKTk9uUXh2WlVKRTI4QUMx?=
 =?utf-8?B?OUxZQzJlSXhFZ0ovYU5jQTkyaWJGVEpZYTgvMStnbDZjQ2xibWt5TWphNFR3?=
 =?utf-8?B?V3ZZTDJENTZKVTh4WStLR3Q0bXhFdXZPMytKQ1hKcEt2NXg5aTRxTk03QzJa?=
 =?utf-8?B?aFU2WWIwbDlHRVdTTlY0bHJzQmtJZytYWDNJS25LTVFjTHFncThsQ00vdkhE?=
 =?utf-8?B?NGt6cW4yTmtHOTJTMWxUNEl4T3dkK2o5VThLM25waE9pMmU1amZhajBKODV5?=
 =?utf-8?B?L3NGS2dteGdZQ2FoYXROeHRpbHIwN3IzMWNtbitwOVRkUTVXblBsSFJyVkZV?=
 =?utf-8?B?S2dqQ1phZC9wNzFRUmxtT09vaW9tS0ljYmFJak1Rb3RsWEtOblRwMU5JVXZj?=
 =?utf-8?B?ekVDQUZqNzd2OWpSaWhJT2liTmhOM0l5L3d0Ym1BZ2FDa1NjRFl1QWFaVHN5?=
 =?utf-8?B?SVpUanJYZUNSaUtBaC9tdkdXSG4vUUlFbjNRUjNUUnJwSXFMNG5QZjI5cnpV?=
 =?utf-8?B?SEVqWmlubkpBVERsRXI3LzNxUHlyMVRDVFRzQUdEeUhSVHgvbWFSdTl5RDRI?=
 =?utf-8?B?S0xJVWFrQ1FhQUllZ1FGVkxid1N2UTUzYm9oYXNSaCtMMUFPdFhDM0dYQ3U3?=
 =?utf-8?B?L1dxay9la1dVWXVDM0FqQ1hGYjF5bEFFU0xuZEV4Tk91elpSNWR1NGUrNUc3?=
 =?utf-8?B?dWR0QithVC9GeThxR2I2bko5ZXkzWnd3bllaSDM5a1dnZVNvQ3dJOFNySnNz?=
 =?utf-8?B?b05MQit0NFQvd1JyNHJBMFVVbElBd1RKaW9wRDF0YlA5MWswdkNYZFlINnk1?=
 =?utf-8?B?ZmRlMlNhNTU2ckZoRFhINjg2RGorbHR2YVVjQmFMYzdPR3RHdjRDN2x3amN6?=
 =?utf-8?B?aUtkempNVFZTMXZBUldUZXhoU2ZrdVowMFFVcERTS3lHQm9MMGhmMi9uclpD?=
 =?utf-8?B?STNlTkpieVZBRlBrME96N1dVMjlOWUJuV3pUREp5eGVLb1pOdnFnMTQzRlBD?=
 =?utf-8?B?Qit5M3Q5dHlZOHlaTlk5MndTRGZXbXF2L1RCUDZIZ3JUSzhwd3pFQ0F0Ukl0?=
 =?utf-8?B?czlOWUtWUUdjb2RMV3BWdlhHWFBaTDdsYUFBQXp2MExwdldGb3J1S2tqSmpV?=
 =?utf-8?B?UjU0cjlIaElvNXFjNHBJQjR0M3pTRzJBVkZxWjcxRUVHMlJqY2JUQjJudFlV?=
 =?utf-8?B?OXk1aGs0MGpBcE5TQ3lPd0txUHQvS0VrWmtvL3p5bjdEZWw1N3ppbE9FcUM2?=
 =?utf-8?B?bFJNOU1YNUJpbE5FeEF6Y1d5dEZ1NHkrNVc1R25VSk5WOEwzM2lYdk13b3Vh?=
 =?utf-8?B?aDBzaHljREJ0R1Q5M0VQVCtla3Z3Y0JkcFFDbldOa0tCb1Q5bnU5UmVzdGVH?=
 =?utf-8?B?ZnprNStiK2VlVjk4MzZoMVBlUjdqcDIzZUNOK1k5bHRvalBOaklCS09wRFBE?=
 =?utf-8?B?cUVJYjVsdFZWc0ZuNEtZOFdaa2RQOHYxenVwYktrMFRhemZsT1dYdGxkbFlI?=
 =?utf-8?B?eTVBOHM0Z2JKc29xQTV4UTN3dFc3UXJkQjdKZlNZNDBzUVFQdXNjbjIxMUYw?=
 =?utf-8?B?Z2ZOdTZEcXBHdk1pdnh4WExXS0d1K0QwVjFUSVNGVU9pcnBFamhBVFErNGpq?=
 =?utf-8?B?NE1yaDFlZ0k2clFKOFl6RTRXM3hHZDc3NXUvVml6NTJBL2Jia1RBYyt0NFJp?=
 =?utf-8?B?NWEvaWZOVkcxUGlGcGh1Tm9sR3FmWlRLTXdIUy9GYzBSNXNXMllNTWtuNHFX?=
 =?utf-8?B?emxaSERQbXUxKzZFS2NtSW5DM1hWYndLUHM2Tldady9YTFVQMHNXMnJkSFZz?=
 =?utf-8?B?bldwaHFIUFlHY0pIWk8rK3FQai9ocUd2WmpuOVBJcTE1cUlUa3I4R3ViVHU5?=
 =?utf-8?B?WHFqeE1lQ2syZlJla1RDUFZjdzJ1ODk1clF6R0Zjc1I5YjJkS1FXWFlnSFkx?=
 =?utf-8?B?a3BKZDgrZFBXVVZCelFRQWFFZ0kvUEhyQnFWYjgxZDFTV3ovK3d6MU5Gd2RH?=
 =?utf-8?B?dXhidiswc2hjdkRNU2tXRk92NWhIVStiRDhhK1Q1Y2F0TmVjK1dKcFpyQlRC?=
 =?utf-8?B?OGZiSm5WbEZMV0Y1S2REVUZKQy9qbThYaWFHdCtDUHNoWWFDK2RySFdoM3B0?=
 =?utf-8?Q?ia2JlHlrDIdjj7tb7OeLP6Y=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8a9a8dd0-5f8f-4b9b-93f0-08d9e5719d0c
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2022 10:57:17.9798
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: U6FCIUPcctzQi9463EiVy0IWOHX8xXTJJ+4CZlK/qLiZiX4ZZClJsnPtHbgs06+D7QbyQHwob6uDsI3QD45fzA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8096

This started out with me noticing that "dom0_max_vcpus=<N>" with <N>
larger than the number of physical CPUs reported through ACPI tables
would not bring up the "excess" vCPU-s. Addressing this is the primary
purpose of the change; CPU maps handling is being tidied only as far as
is necessary for the change here (with the effect of also avoiding the
setting up of too much per-CPU infrastructure, i.e. for CPUs which can
never come online).

Noticing that xen_fill_possible_map() is called way too early, whereas
xen_filter_cpu_maps() is called too late (after per-CPU areas were
already set up), and further observing that each of the functions serves
only one of Dom0 or DomU, it looked like it was better to simplify this.
Use the .get_smp_config hook instead, uniformly for Dom0 and DomU.
xen_fill_possible_map() can be dropped altogether, while
xen_filter_cpu_maps() is re-purposed but not otherwise changed.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
v2: Extend description.

--- a/arch/x86/xen/enlighten_pv.c
+++ b/arch/x86/xen/enlighten_pv.c
@@ -1341,10 +1341,6 @@ asmlinkage __visible void __init xen_sta
 
 		xen_acpi_sleep_register();
 
-		/* Avoid searching for BIOS MP tables */
-		x86_init.mpparse.find_smp_config = x86_init_noop;
-		x86_init.mpparse.get_smp_config = x86_init_uint_noop;
-
 		xen_boot_params_init_edd();
 
 #ifdef CONFIG_ACPI
--- a/arch/x86/xen/smp_pv.c
+++ b/arch/x86/xen/smp_pv.c
@@ -148,28 +148,12 @@ int xen_smp_intr_init_pv(unsigned int cp
 	return rc;
 }
 
-static void __init xen_fill_possible_map(void)
-{
-	int i, rc;
-
-	if (xen_initial_domain())
-		return;
-
-	for (i = 0; i < nr_cpu_ids; i++) {
-		rc = HYPERVISOR_vcpu_op(VCPUOP_is_up, i, NULL);
-		if (rc >= 0) {
-			num_processors++;
-			set_cpu_possible(i, true);
-		}
-	}
-}
-
-static void __init xen_filter_cpu_maps(void)
+static void __init _get_smp_config(unsigned int early)
 {
 	int i, rc;
 	unsigned int subtract = 0;
 
-	if (!xen_initial_domain())
+	if (early)
 		return;
 
 	num_processors = 0;
@@ -210,7 +194,6 @@ static void __init xen_pv_smp_prepare_bo
 		 * sure the old memory can be recycled. */
 		make_lowmem_page_readwrite(xen_initial_gdt);
 
-	xen_filter_cpu_maps();
 	xen_setup_vcpu_info_placement();
 
 	/*
@@ -476,5 +459,8 @@ static const struct smp_ops xen_smp_ops
 void __init xen_smp_init(void)
 {
 	smp_ops = xen_smp_ops;
-	xen_fill_possible_map();
+
+	/* Avoid searching for BIOS MP tables */
+	x86_init.mpparse.find_smp_config = x86_init_noop;
+	x86_init.mpparse.get_smp_config = _get_smp_config;
 }



From xen-devel-bounces@lists.xenproject.org Tue Feb 01 11:04:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 01 Feb 2022 11:04:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.263518.456232 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEqxh-0001Kt-VB; Tue, 01 Feb 2022 11:04:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 263518.456232; Tue, 01 Feb 2022 11:04:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEqxh-0001Km-RS; Tue, 01 Feb 2022 11:04:37 +0000
Received: by outflank-mailman (input) for mailman id 263518;
 Tue, 01 Feb 2022 11:04:37 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JAuK=SQ=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nEqxg-0001Kg-Ty
 for xen-devel@lists.xenproject.org; Tue, 01 Feb 2022 11:04:37 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id bb69993a-834e-11ec-8f75-fffcc8bd4f1a;
 Tue, 01 Feb 2022 12:04:33 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bb69993a-834e-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1643713473;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=Un9NHOZ6sp+YcDz0DUU4S6AtNf9ZzBSZmX4SHQ/Uq8Y=;
  b=Go56plv4XNvtTYC26KuHUej0kGJsfzn0lA8eroiQdRYOsdFgx3VrNPf6
   8H5KwrpUqGifiZhXE+IskeEFks1pREsxtvZjStVNBRreQbLx9nejhIyuR
   qS2yMcfreQyZXkT7p5EookPeXfW+wcY0VmLzVtH+vim7golEHjs+5SgA2
   g=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: og8U2H0Qz3Gt9cOgeyWeD5F5UaDEBgaT85D9acbasBiXAOuy5o67OjXMlvywlHziER66or8uWO
 mJuwf9Csjd8VVj56Lw6uPzXqNbmE/9CdEqVDVNWqFTlyMdSrSzQBcePuNcMxYZaCufxO7sURo7
 KvS5EX+TgSxBwsclNkPBkavDpBytuSoGAnlRNlLKOBKyTDyE9x4VdmbOGLAreUVyf0Dh1bgx1E
 c5lKVZpLTNAmqb2SJCWekFr/szExQQDSB3cgecm/cpmJtJomVGA9d406RyIf5tVZ2S3XL/dYcx
 MqldsFafLhq8jMmznxk2W/7c
X-SBRS: 5.2
X-MesageID: 63201479
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:M5epDauCFEH5mRuX4GrhbeOt2OfnVLBZMUV32f8akzHdYApBsoF/q
 tZmKTjVPqmNYmL1Lt0lb4qx/E8GvZ7dy99qHgtlrSA0Fn8R+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZQP0VOZigHtIQMsadUsxKbVIiGHdJZS5LwbZj2NYy2YHhWmthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 Npl7oehTTYlIqL3nr4keUF5TXxaGp909+qSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DJoQQt2sm1TjEJf0nXYrCU+PB4towMDIY2JsURa+CO
 JtxhTxHcwnMWDdlIHorV48mwbuOv3CmL2xykQfAzUYwyzeKl1EguFT3C/LKfvSaSMMTmVyXz
 krW8mK8DhwEOdi3zTue7mnqluLJhTn8Wo8ZCPu/7PECqF+Zy3EXCRYWfUCmuvT/gUm7M++zM
 GRNpHBo9/JrshX2EJ+tBHVUvUJooDZHQMtUIuEm5zqLkJP+uyfHW0wjfAxOPYlOWNANeRQm0
 VqAntXMDDNpsaGIRX/1yop4vQ9eKgBOczZcOHZsoR8tpoC6/dpt1k6nosNLTfbt5uAZDw0c1
 NxjQMIWo7wIxfAG2Kyglbwsq2L9/8OZJuLZC+i+Y45E0u+bTNP/D2BLwQKChRqlEGp/ZgPb1
 JTjs5PGhN3i9bnXyESwrBwlRdlFHcqtPjzGmkJIFJI87Tmr8HPLVdkOvGojdBgxYphVJW6Bj
 KrvVeV5vsU70JyCNvcfXm5MI55ykfiI+SrNC5g4keaikrAuLVTarUmClGab3nz3kVhErE3ME
 czzTCpYNl5DUf4P5GPvH481iOZ3rghjmz+7bc2lnnyPjOrPDFbIGOxtGAbfMYgEAFas/V+9H
 yB3bZXakn2ykYTWP0HqzGLkBQlUdSBlXcyn9J0/myzqClMOJVzNwsT5mNsJU4dkg75UhqHP+
 HS8UVVf013xmTvMLgDiV5ypQOqHsU9XoS1pMCoyE0yv3nR/M4+j4L1GL8k8fKU99fwlxvlxF
 qFXd8KFC/VJazLG5zVCMsWt8N08LEym1VCUIi6oQDkjZJo8FQbHzcDpI1n0/y4UAyvp6cZn+
 ++81hnWSIYoThh5CJqEc+qmyl685CBPmO97U0bSDMNUfUHgrNpjJyDr16dlKMAQMxTTgDCd0
 l/OUxsfoODMpa4z8cXI2v/Y/9v4TbMmExMDTWfB7LuwOS3LxUaZwNdNALSSYDTQdGLo46H+N
 +9b+O7xba8cl1FQvosiT7sylfAi58HirqNxxxh/GCmZdEyiD75tLyXU3cRLsaERlLZVtRHvB
 xCK89hef76IJNnkABgaIw98NraP0vQdmz/z6/UpIRqluH8rreTfCUgCbQORjCF9LaduNNJ3y
 Ogsj8ca9gijh0d4Kd2BlC1VqzyBI3Fov3/LbX3G7FsHUjYW92w=
IronPort-HdrOrdr: A9a23:UbB7r6pGnz4ZlKARVXCDx5IaV5vPL9V00zEX/kB9WHVpm5Oj+f
 xGzc516farslossREb+expOMG7MBXhHLpOkPQs1NaZLXPbUQ6TTb2KgrGSpgEIdxeOktK1kJ
 0QD5SWa+eAfGSS7/yKmDVQeuxIqLLsndHK9IXjJjVWPHpXgslbnnlE422gYzRLrWd9dP0E/M
 323Ls5m9PsQwVdUu2LQl0+G8TTrdzCk5zrJTYAGh4c8QGLyRel8qTzHRS01goXF2on+8ZuzU
 H11yjCoomzufCyzRHRk0fV8pRtgdPkjv9OHtaFhMQ5IijlziyoeINicbufuy1dmpDk1H8a1P
 335zswNcV67H3cOkmzvBvWwgHllA0j7nfzoGXo90fLkIjcfnYXGsBBjYVWfl/y8Ew7puxx16
 pNwiawq4dXJQmoplWy2/H4EzVR0makq3srluAey1ZFV5EFVbNXpYsDuGtIDZY7Gj7g4oxPKp
 ggMCjl3ocXTbqmVQGbgoE2q+bcHEjbXy32DnTqg/blkgS/xxtCvg4lLM92pAZ2yHtycegB2w
 3+CNUaqFh5dL5jUUtMPpZwfSKJMB2+ffvtChPaHb21LtBOB5ryw6SHlYndotvaP6A18A==
X-IronPort-AV: E=Sophos;i="5.88,333,1635220800"; 
   d="scan'208";a="63201479"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=WjlUgElF5Se8UGHM+Jo6PE4TgEr3JOtvI3VcOrSO5jVGHUCDTxK2U4qX3ENeST8iA+pitP8xIXWDmuKMtecC2w39eMzcL+KcTgBrd0B9i8cswyFrbzgCaLRRxEfnrlw5RvUUPbu7PYdTOL1dV2dyt0EspLTxXfsyiSBRq7TwaGp6niiGJfLJNb8MHIFNPGRMUewRRV0/PcrUeFprysEzC666HxvySa08XHEZ1El1jLAK3V7LC9GKlnMU+0I90RSb18CAcOiXAONBJaqnPVaV0E1SQ2ZK/62mke/B6jbXukHjrmEh/5ppoEfOTCPz62hioe7IueGYEFbR2yBtHRhmDw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=tRk7Pr9VrtrcE+pq75pNFroRdOWz6kG2YK+mKpsPAWs=;
 b=KmzvKGyBtbQCM2xxGUEx9sHbhhbavSdc5iHl9iioJPwq7t2prTaMtscRS2xN539fgfSqBZPJbST72F/04GCGVM3gb+hqFiMHU0VU3WCDgHcN0IYvJn+R6UG4NdRLjNdqFAFe8nFwryaxiS7605ry+KbPbtUsdJ2jvzLDp0IX22raZl6Al547kcT4QL2m9SSBeOtoTTRUkJP5BiGk676QFBGuR6qwiMGkg8C0d8PhfhS6awapbYCWnlMLsyK4vhQR/DelOcrTZnY0HCJSjLLsW3ArxEAbitdnDCYz+L6dREUt4TtJzxM2X3r0bW9BfGWZODs7R/rawYU9VY0J2o66ew==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=tRk7Pr9VrtrcE+pq75pNFroRdOWz6kG2YK+mKpsPAWs=;
 b=Q0R6Rd2wyJBT8gSJu8SRLQjM6LgtZblNMAZc6xFXimcsZbiDw8VsvXW9u0+LmvTPPpmA8eRQToVFdDwGqiVM3WyowJogQ2Iq8YHbL49vLuJ9NQiRIW/Egd5LnGz8iK/oefiGKangQ0lqeCBdTdjSBbzl2JfMI79EAQLXa7gnQ+c=
Date: Tue, 1 Feb 2022 12:04:23 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Andrew
 Cooper" <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v3 2/2] x86/mwait-idle: squash stats update when not
 actually entering C-state
Message-ID: <YfkTt1k4XLnZtaJj@Air-de-Roger>
References: <faff6a1e-9f00-e924-9766-deda8f0b38c1@suse.com>
 <6a9152e5-1a7d-c569-3483-66f022027597@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <6a9152e5-1a7d-c569-3483-66f022027597@suse.com>
X-ClientProxiedBy: LO2P265CA0221.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:b::17) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e33fceb5-5dc6-42f1-6be5-08d9e5729d7a
X-MS-TrafficTypeDiagnostic: SJ0PR03MB5871:EE_
X-Microsoft-Antispam-PRVS: <SJ0PR03MB5871A2BBE1FAF9AC1444251C8F269@SJ0PR03MB5871.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: PTW7x7DyNyD58xoSh3UcN3K5rRd70EqA5/TmDNfKwH/dRzWj/ri2Gq5AZyH0wzDWN9/iEr241ouxQ6rbeupkDW0d3snjvk+U38pafT3SarQZZ86fHswyl6cZaPuwf3BC04zFV4LSPvyAY7WkS6Yfwg/hlSjYBhwXgohaRIcZmojEOtRqB4pR03UbYYcWrLaqgBN9f6kyXE0tdBT5fWCFZIUBWDTHyOfr648XcFk1SXCmfXRvRTVl0rjpr9ta4/XsgeuEP3OEl6tTXrjR3eQIzr2JLVzg720Co/diQCDijeEqokRCbTFIABjahS+6f5BLqnw+uboTQo4N//SaCp9csKWGC7h4GMab2rQF0UTp9DMe4ARB6lN3td3bKd7PkbX0ZwIwdX+DhOccGL++eS+HnnWnWxyTnWfZlUGqaItfsqn9S36av3nXGKNhJ/LWVU41pLhtC/FWRw0N2btijTUp/BNtOMnFfWnRMZbsQ3lEyykmNH7GKVB9oQBWP8s6R7RzfOg1QtnA4OZ+Cd5AbfU6vQGxlmFqPeEfyLISkqO6/AjI00aCWPEiJkZuvk641l3T1VzdroPCEQbs+GkXas5l7aP5RuOJLoSPpy0GuB47Hx4UZ7uOl0iRfzZRIkKP5SLIXio1/N0IAbzjyKRDK7w2Cg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(66476007)(8676002)(8936002)(6512007)(6916009)(9686003)(508600001)(66946007)(66556008)(4326008)(6486002)(6666004)(54906003)(316002)(2906002)(85182001)(186003)(26005)(83380400001)(86362001)(6506007)(15650500001)(5660300002)(33716001)(82960400001)(38100700002)(20210929001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TVVGalE4QW8yeHFNdGZpN20wcDZaTndoNzkrVXJPQ0Q2ZUF5NW1LQllBV3pE?=
 =?utf-8?B?aHRNNHM1eTFmaDJYT0VGZ0p4cC9QdEdIczBHV29DZEt1MjU3bjAyODR4NnJU?=
 =?utf-8?B?T1VxL3VsMlVwUDRuemlvVEFuOTZ0M0FmZG14VFJseXNnTnZ4b3oyeDRUdG92?=
 =?utf-8?B?MGxuZm5laitIOUNsTUhmL0luQWVhcTdLQ3g3aW9JNFNpZWhCdWdFVmJDUXVy?=
 =?utf-8?B?MlpiRm5EVWRVRldqa3V6YVdleC8vbXRMc1dVazBaeCsweXFJcStpRmM2S0Nz?=
 =?utf-8?B?MVc0cnBRNEJFMWpkVFZoUTlIUDRzTVRpa2RESysvYUVSaDhQNGZ0Y21ZMEdQ?=
 =?utf-8?B?ZHFiVE1acXVnWFNkNDNFaDZ4dUFMMDFDOUNGdGJWNG5RUjhWWTFScnhYOXNZ?=
 =?utf-8?B?UXBvTUhTQm5jVlA4bXFHdzU4M05wdjZybzlsWGswcFNSRHpEZGRzcTZNOFVt?=
 =?utf-8?B?U3NYUjlEWU8ybUJacnJDazFxSDdmQndQSVlhOC9wTzVRZG1LUnR5Vlo3alJp?=
 =?utf-8?B?VURMNTRLT1l5VFlXMnRZNStYVHFMZGVGcDcyYk5jTktVRE43dDRlK2l4RER6?=
 =?utf-8?B?encwS3h0YnhGZnlmd1hqNU1Dbnlrc3dBR254eUhYNnAzMC9va2ZGcThOTVV2?=
 =?utf-8?B?Vnl3TEYyVkpNd0xxRHBRSStvb25kU3V0UmJDajFiSm9GcEhyaVRMRkZkY085?=
 =?utf-8?B?cm1CYTIvWDB2R3VaZ3Y3MkdTNGcrZkxSR3BiSzMwQkREL3Z4bG9zR0RwZEcx?=
 =?utf-8?B?L21lT1JvSzRHeHpHYzI2bEZCSUVPcDN4NzRzbnpVeUNmN2l3c1dKblFnWGJR?=
 =?utf-8?B?Z29FK0lMbGpTd2xFSWhJQlhneDN2ZlpzY3hrc05YYURZZm9sYnNCZXRmc0Y3?=
 =?utf-8?B?TjRUY25SMHV5bXg0b2luTS9mSnRmRWVBN1pJMURVOVJKUWZ4Z2Rib1FuQ2FN?=
 =?utf-8?B?WmFrRXU3ck1Wbmt5ZE5hc3hOaG05Z0NNbVk1U2RnRWpmeEUrSW55Tk9ZTTF5?=
 =?utf-8?B?WHJWMmcrbUI5UWlVbnRuK2lXcGNwVFBZTHhaUERmSVFRNWx0djlSK2xMbFkw?=
 =?utf-8?B?Q2FqaVdseVV0RTlOSkNGR1crdjZlNXh3ZVFPMGp3cER3WXdjbG5MczRwdTlw?=
 =?utf-8?B?eHFkRDZJMU83aXNNb1JDZnlMWVhlYVVGTGxicDdMZHdKUlFTVHYyb2l0ZHgv?=
 =?utf-8?B?T29Idmc4NFg1OTdIN3pVbVVocHpMMmF5NG5XdVIxOGxJN2M5NG5aa2N5WDBZ?=
 =?utf-8?B?bHpaUHZ3UWFxdENlQjluYlRxZkdHVWhWUE5aRzJ6VytSZkFlOHdNakg3K2hm?=
 =?utf-8?B?YUdCV2k1amJFUi9ZNytGWVJRNi9iTnI3aXZDZENFRFVuN3lWMWZkVUNla3R3?=
 =?utf-8?B?cEFHU09yOVM1YzY3eTlXMUM5YTF5WkFFVUx6QXowTjBZSzloWEdRZ1V4ZW9W?=
 =?utf-8?B?ejRIbHRnVFNrWHdqTHUwSW0xMlRDcVZtc2c2RjMwdkN5Rnp3ekxvckVuTVpI?=
 =?utf-8?B?ZGRVNEtKM2Y4NkNGUG1Ed1BjL0ZrbFVVRWhBYys1TFN3Y09TNlNsSUM5ZWpS?=
 =?utf-8?B?dE1SaktnMVJHbnY3UGM0NU14L1lCTVkrd3c0WE9HendHSUJ6VFMvWkthRHVR?=
 =?utf-8?B?NisrU1lSUGoxdEc0WGx2bktjWGxtTVBhTGZ1NU9LYzFZMnc5cks4U0YzKzR1?=
 =?utf-8?B?R0VFZ3E3MmFOaDljU2h5ejhJY3ZPdXQ1dis5NU1uS0ljUTNjWTg3VHF6NXNC?=
 =?utf-8?B?OThMNWlmL0N3OXFNUVdwZWFUWUpHQzhsdVpwR1BzMTBBb1QxYU9Qc2liK3Q1?=
 =?utf-8?B?QXJzbE5NTk9jMHR3WGwzNzk2Q2NmZVN3QWVuYm5XOFgvNWIyQzNGY21OMlpZ?=
 =?utf-8?B?WGEzV0ZFd3p1dHJVU0pnakVLSG1IVnA0R2FjS0xxWnVWaGZvUUF5d3hoRkR4?=
 =?utf-8?B?dllQOExvbHdkUnNib2dVdmhkRWpiYVJacUlud0RQemVxUjFyMVJ2Y0lkSjZu?=
 =?utf-8?B?NGxpSWxRZ0o0M1c4cnZMVjNxWFhyQjRvdi9CaDFrM1IrYXM3ODVTdTdpb0xR?=
 =?utf-8?B?eXVkR0FqT3VWcHdHUExxMlFKSlZrYkl5MnlJc2h4TEVGcEM0MDBnc0x6SVRC?=
 =?utf-8?B?WnBSanN0bEJZbHQ1M3lEclJld0NEVzh6YWZmaUppN3o2eU04dXJBcnBML1hh?=
 =?utf-8?Q?lALQTcl453OwX9geVi+gJmQ=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e33fceb5-5dc6-42f1-6be5-08d9e5729d7a
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2022 11:04:28.1650
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zrEiVxjp8SP8R7aEg6SwIEqaqLAzSfgNWj//uTNjyVb/rs7rNCr+XA+7nuh3a6b46RnHny7493XuKUgFEglFsQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5871
X-OriginatorOrg: citrix.com

On Thu, Jan 27, 2022 at 04:13:47PM +0100, Jan Beulich wrote:
> While we don't want to skip calling update_idle_stats(), arrange for it
> to not increment the overall time spent in the state we didn't really
> enter.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> RFC: If we wanted to also move the tracing, then I think the part ahead
>      of the if() also would need moving. At that point we could as well
>      move update_last_cx_stat(), too, which afaict would allow skipping
>      update_idle_stats() on the "else" path (which therefore would go
>      away). Yet then, with the setting of power->safe_state moved up a
>      little (which imo it should have been anyway) the two
>      cpu_is_haltable() invocations would only have the lapic_timer_off()
>      invocation left in between. This would then seem to call for simply
>      ditching the 2nd one - acpi-idle also doesn't have a 2nd instance.

It's possible for lapic_timer_off to take a non-trivial amount of time
when virtualized, but it's likely we won't be using mwait in that
case, so not sure it matter much to have the two cpu_is_haltable calls
if there's just a lapic_timer_off between them.

> TBD: For the tracing I wonder if that really needs to come ahead of the
>      local_irq_enable(). Maybe trace_exit_reason() needs to, but quite
>      certainly TRACE_6D() doesn't.

Would be good if it could be moved after the local_irq_enable call, as
it's not as trivial as I've expected, and will just add latency to any
pending interrupt waiting to be serviced. FWIW, I haven't spotted a
need to call it with interrupt disabled.

> ---
> v3: Also move cstate_restore_tsc() invocation and split ones to
>     update_idle_stats().
> v2: New.
> 
> --- a/xen/arch/x86/cpu/mwait-idle.c
> +++ b/xen/arch/x86/cpu/mwait-idle.c
> @@ -854,17 +854,23 @@ static void mwait_idle(void)
>  		mwait_idle_with_hints(cx->address, MWAIT_ECX_INTERRUPT_BREAK);
>  
>  		local_irq_disable();
> -	}
>  
> -	after = alternative_call(cpuidle_get_tick);
> +		after = alternative_call(cpuidle_get_tick);
> +
> +		cstate_restore_tsc();
> +
> +		/* Now back in C0. */
> +		update_idle_stats(power, cx, before, after);
> +	} else {
> +		/* Never left C0. */
> +		after = alternative_call(cpuidle_get_tick);
> +		update_idle_stats(power, cx, after, after);

While adjusting this, could you also modify update_idle_stats to avoid
increasing cx->usage if before == after (or !sleep_ticks). I don't
think it's fine to increase the state counter if we never actually
entered it.

I was also going to suggest that you don't set 'after' and just use
update_idle_stats(power, cx, before, before); but seeing as TRACE_6D
also makes use of 'after' there's not much point without further
rework. I also see the RFC note at the top, so while I think this is
an improvement, I agree it would be nice to avoid the trace altogether
if we never actually enter the state. If you want to rework the patch
or send a followup that's fine for me.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Feb 01 11:28:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 01 Feb 2022 11:28:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.263525.456243 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nErKC-0003lj-TP; Tue, 01 Feb 2022 11:27:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 263525.456243; Tue, 01 Feb 2022 11:27:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nErKC-0003lc-Pj; Tue, 01 Feb 2022 11:27:52 +0000
Received: by outflank-mailman (input) for mailman id 263525;
 Tue, 01 Feb 2022 11:27:50 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nErKA-0003l7-Q1; Tue, 01 Feb 2022 11:27:50 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nErKA-0001pd-M2; Tue, 01 Feb 2022 11:27:50 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nErKA-0004Fc-3e; Tue, 01 Feb 2022 11:27:50 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nErKA-00065h-3E; Tue, 01 Feb 2022 11:27:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=re39D34t/EOHr982enIJr6VeQzG46sZuFr8MGXoPFog=; b=eCD/rUAlQgYlRveQurxBsvotd+
	7Jjb4Te/VvpcMnmdAwKnUezkKzhev7mKhxRjq2GyoQFNR/Z2DSuq5PCroVYfckSSn7b0F87Y4MTWH
	IsoTxRRfGgqRps3Fgk0qdYv2sorjsR50FnGcXfx3IUiYs72aXufb2HCcM4JmrAYip/P4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167970-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 167970: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=481ee6125aa1d5751f52eda677c7bab4719c0ad0
X-Osstest-Versions-That:
    xen=c78901ab09bd0c469649f4ecbd325a6edb953592
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 01 Feb 2022 11:27:50 +0000

flight 167970 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167970/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167966
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167966
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167966
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167966
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 167966
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 167966
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167966
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167966
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167966
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167966
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167966
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167966
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 xen                  481ee6125aa1d5751f52eda677c7bab4719c0ad0
baseline version:
 xen                  c78901ab09bd0c469649f4ecbd325a6edb953592

Last test of basis   167966  2022-01-31 13:08:14 Z    0 days
Testing same since   167970  2022-02-01 02:14:08 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Julien Grall <jgrall@amazon.com>
  Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
  Rahul Singh <rahul.singh@arm.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   c78901ab09..481ee6125a  481ee6125aa1d5751f52eda677c7bab4719c0ad0 -> master


From xen-devel-bounces@lists.xenproject.org Tue Feb 01 11:32:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 01 Feb 2022 11:32:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.263537.456253 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nErOs-0005E5-LX; Tue, 01 Feb 2022 11:32:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 263537.456253; Tue, 01 Feb 2022 11:32:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nErOs-0005Dy-IY; Tue, 01 Feb 2022 11:32:42 +0000
Received: by outflank-mailman (input) for mailman id 263537;
 Tue, 01 Feb 2022 11:32:41 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=0oSv=SQ=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nErOr-0005Ds-Je
 for xen-devel@lists.xenproject.org; Tue, 01 Feb 2022 11:32:41 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a9bda09e-8352-11ec-8eb8-a37418f5ba1a;
 Tue, 01 Feb 2022 12:32:40 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2057.outbound.protection.outlook.com [104.47.14.57]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-11-ZdIFo7EnP-yASwmizFIUkg-1; Tue, 01 Feb 2022 12:32:39 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM0PR04MB4548.eurprd04.prod.outlook.com (2603:10a6:208:74::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.22; Tue, 1 Feb
 2022 11:32:37 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::7cc2:78a3:4d40:9d45]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::7cc2:78a3:4d40:9d45%6]) with mapi id 15.20.4930.022; Tue, 1 Feb 2022
 11:32:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a9bda09e-8352-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1643715159;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=ej4bwyEhVMsXF8OM7gFSoKdRZI3BJFNV/DPDRWgXBSE=;
	b=b7iQm9LPetgrCNJNzBQPrd8dmejQgzUX2T0wWzWRhPf1WoVPx09360LBVYgjwKAcR2YRsc
	3WCn0aaECELOj1cPl4b0RU4afS5FwC8SPUn156Qu9xguv3C9zI14AEuQ0M3Yr5WIEyd3a5
	caL9seKauuYovMjs9SXRtYOO7TyJ/sI=
X-MC-Unique: ZdIFo7EnP-yASwmizFIUkg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=UiU3BALktKdxUgpfNudqE/rYJPe5+mp5qCxl76yUB5Irt/kTKCmKBqxxQgjSnnnudesNLrevfZrg7t6+uScO3F2hJkjEWxmwuhZUsC+EZuOQT9Af0ZTgrSsunHBeEzgWAYkV2H4v65/RL4Vj2PVkfzcu03mF/602jD7HRQQEf0K6N/yHc+wlkSNGSmePTQhp837JUmq0pnhm97MILgGdBCFaqrNtQlCeU6rpjBxvLaNytYPbdd2vJCFIYBQyFsoTN+bdHwqaE5Quwq9ZOzdD3+XzMjRXRq6VTxW2p6cyniklXQtTiSL5FRb1tKLsPXqC5BRoxFSjsBQpUSWkAsk9og==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=OqCvhSF9hIsv92JKdx86mYpexlREtkPCXNGioNF8/Ts=;
 b=j2aeBngcidVpe9/PQU07SoYBRzG3qzlTpO0t/ml2C2gfFfRONrR37aCQT1mwGedA2HrL2XmQJKDWpsff6jnbadjdj5HsiZreWUgv6MQ80xyMMu7ngdfP4FSdhfzkFgvK/Qbdxgf34AIxBxSyXxFRmV84lyGHqwjh2jQygbMyBiYCPsa/rB99b1c40UtOJHDa3Ufum9wZ1eZUosSrZGjsV7RIaXRXK0npZcYsLeL6BbGGfiyx3P+DjTuboF4K+1AzXpJv3byiJ6VqnF4LsTx2MisvqDdPc41w1HDMSxZTFDoHghyMEUbiGKf0S4iyYt2mNPrD3AOYyAgQfB/bSuqqnA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <c4568b11-88ec-18cf-f0ec-7a2dbbd50a80@suse.com>
Date: Tue, 1 Feb 2022 12:32:34 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v3 1/2] x86/mwait-idle: enable interrupts before C1 on
 Xeons
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
References: <faff6a1e-9f00-e924-9766-deda8f0b38c1@suse.com>
 <379483c7-fe7d-16ee-454f-8f8dd001dc48@suse.com>
 <YfkPcm3GFI3MNoH3@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YfkPcm3GFI3MNoH3@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6PR10CA0009.EURPRD10.PROD.OUTLOOK.COM
 (2603:10a6:209:89::22) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f4089152-27ce-40fd-bd43-08d9e5768c39
X-MS-TrafficTypeDiagnostic: AM0PR04MB4548:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB454809D4BD061FA445A5AA1CB3269@AM0PR04MB4548.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Yev7rHXlrcsMVPqV4gamoPx/UVV4AXyXIC+2ACfPJ2PUwijJJbc2d75XN1RRzf9n13BmyTc8p8RSVD9MNA1bSXM2T2EUqvbstVs62drXoTv88y1WWs+1szq8UaMb9uLBilTEBxYIGoeOZ2yrne1SxDPq6tDioAEO0W9XZC0VOqxu5IJefaV6p82foZn/ZHONQsixF6QB+Vc2RIs6FN6V19QBfcdhOUMG5Oqn/bu6ItCrx5VGpubhezrf/LtR9HQfabNAaQl0oqUJZVEOfxizYjLsqW4jyCAzZtHXqhtPumBI4MTOteZnQrMv9KTxhE6CANeEMy2uuG8Qx/CKhi7TTSvyiOiUvrafhxCDfzmerSAOeZ2jnQF27QBcqciEif0ouD+K0mfSBIFvtR+TZGPWSvIFxfJDK3OAWzeJBQJHjkSovXwsYbjkcjO8g02JasJWEHwCiSPGRkO9djJiCZ40P761KVqB2xizzLA4hOuw+r2nwmzOY2tWGJ8spedBrBIDhc5ea9z4+7gXmzxX4sAi7Rn8EhisGglWcour1jMnxqJPVue8/ZA8ShgEPAebNi69f3mkRyfxcH/Q+1ysfZKoKeyWM4/cSH6negbfr/fo8hCcNk9OFSOnWUA1mI+ktCTLdbQPAFGHHnQ5SKWtJ/5ra4QeoM9KRAB0ZXkmLTJnL8Dqb3lHwTkMyjDMLc6F93xKiVCYKlvXr77e0LzNoOpFVvLHYrZ/XQLvH/EpllzoOnGHl+wy5oIODF9nE6aWOWiKzLerY7azZcI2RvNqZWxlsQ==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6506007)(86362001)(2616005)(6916009)(26005)(54906003)(31686004)(38100700002)(31696002)(36756003)(316002)(186003)(83380400001)(53546011)(66476007)(66946007)(6512007)(6486002)(66556008)(4326008)(8936002)(2906002)(508600001)(5660300002)(6666004)(8676002)(21314003)(43740500002)(45980500001)(20210929001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?eBPQLAmac8eZgFVlhlVVoVdnkfIIHuDZY3x8IPqgMuPjeYX0bEYgU6ygiyee?=
 =?us-ascii?Q?qxsob4ldpZQnkyznSIxKITboVI3WAME5UpTSAM3FYAizmLsTDPEwgOSUBnQO?=
 =?us-ascii?Q?TdcJ+rFPqZOM4TxvxYIp5a2VNbe0V7GsYwiA6+YztkkTKBzDLJyTcadeGA/Y?=
 =?us-ascii?Q?Qbs/k60+wsb1RmVc/XD46y5LctMzPy4hGuIn+/meF9gfL+We1rKLWgdV3WMR?=
 =?us-ascii?Q?FnpY5+mzN8K8AKvj2O5QeqH8A9/L6EZY1oWym5lihlo/tGrLnghO3t5O3p34?=
 =?us-ascii?Q?8xAPVMZV4DMbP6NEQb8abHp3v0FbeiXkXtwiXqvQPbk6drWn0+wVlMe3q+ZJ?=
 =?us-ascii?Q?qMwF+Ut8fNJ8PWcg/5kuCqjeFczoOs+NNXuM+nYSfoxfwPMTes1qGrq1EyAT?=
 =?us-ascii?Q?NeT2G3bpDm0sBXzxT6tSlp0n0gMXoKVMw2x1fhzZ8e5EUR9U5Oyj/D+Yrh4u?=
 =?us-ascii?Q?xn7NA6Xn/EmnBLUr0FqfG0Ci66kBfk5ueFBmc+5MxZCCDW/fsI+j9oGoJYY8?=
 =?us-ascii?Q?2tIjLNBx5xqxGn+2pEH0r5iRIKxrTugFiZqbPiH1gZP07CO2Yf4lkZM/qseQ?=
 =?us-ascii?Q?B2gp1PVt2e3ruDg4eyj+/9RCt2k/UirUhZas7J1DtqaaBggMT8HuNGM86jXo?=
 =?us-ascii?Q?doZl2Qdv7hAp988DcFY82aUOS5cI5q1VfUL2IawJnY/xNJrcbfEGo0m12FKP?=
 =?us-ascii?Q?az452wXMCE4TzfnRH2A8TL82h36lljmd57XCOP6dptm6IjhdIETD1boflOBD?=
 =?us-ascii?Q?ikFKdLSRBnQ9vr66U3tOb5fW3ndQ7DHtPyGXiTJ0kHUEGsMeoQoLwWIHrHwz?=
 =?us-ascii?Q?Rd6wAa2wIwfImQpaYhdKqeKr61dyzobZ0bIUJfYNHiPplYCnDceXW2i+Q34O?=
 =?us-ascii?Q?f3A0gWUzY6pyOoji1PNP8hhWTQtSan739ykKEonnfgYeI/NNvZk5YRG18K91?=
 =?us-ascii?Q?l07KIugL59/EjGRkRDLnMfnc0X5U7lzcoAZ6AmVb/lTqNxtQmyEpU/tB7aYY?=
 =?us-ascii?Q?2LrZ+jvu6Fjua/rXnO+zRvIP10CHesbEDo3taYXuhFQgyNCcyMUFPo3AuZFV?=
 =?us-ascii?Q?Hg32npx+K7bfgXu2WsWLJf/OaPvXDeCH9MAnSQWqx2R78gKoE5tq94OUJ9n0?=
 =?us-ascii?Q?0PfLIYPMvhKKrKY+LlSvlzZOwhLznweDuhXeEIJ/aCAFaBF0572OR8PUnYVE?=
 =?us-ascii?Q?nSnWChxjSMWGBtzAn3IdZ4XtGq+rIMs73HFy4hKYEq+dxMgHTyEg3hZBZXmD?=
 =?us-ascii?Q?yFwbhhPpC4ZuV5G2fgjCfr01W2sYHpkkmlQoqg0CdcroURv7Cd4zeHgmBCG+?=
 =?us-ascii?Q?A4ZDXExcAdJeWtHgqM3HNr0NeWHbY7vvRCd3g6frLY1hR8Z5FzxLUE9JgSWY?=
 =?us-ascii?Q?HFj+hfZrq/gu5iP1VoVJUBWEyPvPsqlAH+fhbMscGHE7Gvcw7UDl2sG8v5xh?=
 =?us-ascii?Q?mokVyCuPWHrJergE6Nl8J4wrSo3I6OCrA/0LCCVyDdrIz/PYOBEAbs4iXVkk?=
 =?us-ascii?Q?E20TT1nqVe2lqFROew2kch5Q3tLW6Jt/kTUr2ojwcloS3LgiKXMIeni3duEA?=
 =?us-ascii?Q?72ffTpkkI6022Sm/kyX6fu/TwZeyMDG2P4cVfEh+cDExA4PKQFLucRL0RAe7?=
 =?us-ascii?Q?okcRkmBFE8TqSw1hrJssdn0=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f4089152-27ce-40fd-bd43-08d9e5768c39
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2022 11:32:37.2537
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lprYAYV7jQmAEI4232TSBpKMTM/B0fxwZMQCi5uarmEbAuER88xBp8hbmeRETHi6LXrUoskhCP4iR/baqAj5uw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4548

On 01.02.2022 11:46, Roger Pau Monn=C3=A9 wrote:
> On Thu, Jan 27, 2022 at 04:13:21PM +0100, Jan Beulich wrote:
>> From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
>>
>> Enable local interrupts before requesting C1 on the last two generations
>> of Intel Xeon platforms: Sky Lake, Cascade Lake, Cooper Lake, Ice Lake.
>> This decreases average C1 interrupt latency by about 5-10%, as measured
>> with the 'wult' tool.
>>
>> The '->enter()' function of the driver enters C-states with local
>> interrupts disabled by executing the 'monitor' and 'mwait' pair of
>> instructions. If an interrupt happens, the CPU exits the C-state and
>> continues executing instructions after 'mwait'. It does not jump to
>> the interrupt handler, because local interrupts are disabled. The
>> cpuidle subsystem enables interrupts a bit later, after doing some
>> housekeeping.
>>
>> With this patch, we enable local interrupts before requesting C1. In
>> this case, if the CPU wakes up because of an interrupt, it will jump
>> to the interrupt handler right away. The cpuidle housekeeping will be
>> done after the pending interrupt(s) are handled.
>>
>> Enabling interrupts before entering a C-state has measurable impact
>> for faster C-states, like C1. Deeper, but slower C-states like C6 do
>> not really benefit from this sort of change, because their latency is
>> a lot higher comparing to the delay added by cpuidle housekeeping.
>>
>> This change was also tested with cyclictest and dbench. In case of Ice
>> Lake, the average cyclictest latency decreased by 5.1%, and the average
>> 'dbench' throughput increased by about 0.8%. Both tests were run for 4
>> hours with only C1 enabled (all other idle states, including 'POLL',
>> were disabled). CPU frequency was pinned to HFM, and uncore frequency
>> was pinned to the maximum value. The other platforms had similar
>> single-digit percentage improvements.
>>
>> It is worth noting that this patch affects 'cpuidle' statistics a tiny
>> bit.  Before this patch, C1 residency did not include the interrupt
>> handling time, but with this patch, it will include it. This is similar
>> to what happens in case of the 'POLL' state, which also runs with
>> interrupts enabled.
>>
>> Suggested-by: Len Brown <len.brown@intel.com>
>> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
>> [Linux commit: c227233ad64c77e57db738ab0e46439db71822a3]
>>
>> We don't have a pointer into cpuidle_state_table[] readily available.
>> To compensate, propagate the flag into struct acpi_processor_cx.
>>
>> Unlike Linux we want to
>> - disable IRQs again after MWAITing, as subsequently invoked functions
>>   assume so,
>> - avoid enabling IRQs if cstate_restore_tsc() is not a no-op, to avoid
>>   interfering with, in particular, the time rendezvous.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>=20
> Acked-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>

Thanks.

>> ---
>> RFC: I'm not entirely certain that we want to take this, i.e. whether
>>      we're as much worried about interrupt latency.
>=20
> I would assume taking this would make it easier for you to pick
> further patches.

At least a little, yes.

>> --- a/xen/include/xen/cpuidle.h
>> +++ b/xen/include/xen/cpuidle.h
>> @@ -42,6 +42,7 @@ struct acpi_processor_cx
>>      u8 idx;
>>      u8 type;         /* ACPI_STATE_Cn */
>>      u8 entry_method; /* ACPI_CSTATE_EM_xxx */
>> +    bool irq_enable_early;
>=20
> Should you use a bit field here and limit the field to :1 in
> expectation of maybe adding more flags at a later point?

Well, I had considered doing so but then thought we can easily
switch at such future time, leaving it consistently witout bit
fields for now. The more that there's still a 32-bit padding
field left to put stuff in.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Feb 01 11:37:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 01 Feb 2022 11:37:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.263546.456273 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nErTa-00060O-BC; Tue, 01 Feb 2022 11:37:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 263546.456273; Tue, 01 Feb 2022 11:37:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nErTa-00060H-7R; Tue, 01 Feb 2022 11:37:34 +0000
Received: by outflank-mailman (input) for mailman id 263546;
 Tue, 01 Feb 2022 11:37:33 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=0oSv=SQ=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nErTZ-00060A-5B
 for xen-devel@lists.xenproject.org; Tue, 01 Feb 2022 11:37:33 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 57a1d25e-8353-11ec-8eb8-a37418f5ba1a;
 Tue, 01 Feb 2022 12:37:32 +0100 (CET)
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2059.outbound.protection.outlook.com [104.47.2.59]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-40-tOKrJZYUNieSYNZmWcLV5g-1; Tue, 01 Feb 2022 12:37:30 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB3133.eurprd04.prod.outlook.com (2603:10a6:802:9::23) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.22; Tue, 1 Feb
 2022 11:37:29 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::7cc2:78a3:4d40:9d45]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::7cc2:78a3:4d40:9d45%6]) with mapi id 15.20.4930.022; Tue, 1 Feb 2022
 11:37:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 57a1d25e-8353-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1643715451;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=NHKge63IFJxDzlpfEKA6T4FB8qoBO9BdhvFyYE6CFi4=;
	b=ah/GK2QwRXJkKgm/jMhVFsLz7QLJGJ42zA2jrAZ5E4tR9wVipdjk8t6U/BVrzbB2yzVFHy
	Z195tiuLQG37wZ6yuGS8ygQezLppg61odyoz3gWf7VSrLCaUnffQJtbx27zmaGaY+/iQPO
	iWlvaETzhDgndSggyuPgkJfuFdpYs5g=
X-MC-Unique: tOKrJZYUNieSYNZmWcLV5g-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=JzBpVLTNmbWGU0rwl6vohCMkjckFOdyvQlWCaesiW2XDwl3YaDG1Va3SZtSQs7HnLeqMtTjlgCGwakEGCXVpgu80OtBtMl2xURRQAiHR/xcXmHxdsrPsrXzThIgi/HFS5hcEbyqcf8Sjqq/AVM9V8Nxf4SbrLMWSbMCOK5hEbrSUFeTiIgV0uqY1vw/5X49d4Fqa0mtNxjC3jYZFaICqMry5VQPaRL7Hg+OnBTw+qHmFmZvG1oQc5F//n/+JL7AI90PaqwbUNd4hDuMElARurtKcqPZ13FoVtqCTIQkJKXPauPw+ldES6Mh65ZJ/spxwySyiPsSo+jKEkh0esnvRJw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=97EzxWkjILbC2ZQT0LZkqcNBN6bfE/NJI7hPdxi0FZ0=;
 b=iMAsvyGwHhDMrwWXmCu/PxPfUrUfNLWC4yQcObIebcvGyPj7ifzqcW8z7Rn/mhGpUwJzof/z+Eso8b2cT/UCc6vILEjXgj4gnFRZvdXqqWdvKAT9prrwAtDdCx6vFyPq+XO9g6w5c4WFmtjfJaZOlmEizI65TiJO314mYaq3ZvCRhgAW2a3UcasQH2jrHtXtvCyAUSP1m7iLFsCQPf5CB8sL2L5POdZ++Q4iNeJeIvP9WrWMs332pkxUGR8RDCGCrffRyYfF1UjFj+0n8q4aauIlNPrZo20zdywlxgo8IwsRIAd4/Nd7wh4yUvimoEUbQ/d4WGvkR59x5hRaVHNzGw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <2c6129b8-87ed-a3fa-f819-6318909bf2e1@suse.com>
Date: Tue, 1 Feb 2022 12:37:27 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v3 2/2] x86/mwait-idle: squash stats update when not
 actually entering C-state
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
References: <faff6a1e-9f00-e924-9766-deda8f0b38c1@suse.com>
 <6a9152e5-1a7d-c569-3483-66f022027597@suse.com>
 <YfkTt1k4XLnZtaJj@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YfkTt1k4XLnZtaJj@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6P193CA0092.EURP193.PROD.OUTLOOK.COM
 (2603:10a6:209:88::33) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 1e33089c-3d3c-4f05-2705-08d9e5773a8a
X-MS-TrafficTypeDiagnostic: VI1PR04MB3133:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB31338D7898F1102A997061E6B3269@VI1PR04MB3133.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	iDYbACFxWYzIrkYHEJr/qU3FChxEPNPDj4dF+rp16+9RCk7Ef+W9TVoFOFkxwKdc3jl5PDR27lbebsUg+SoJAROa+ny38zxR4SsgS5UroD9q2FJGAris7PV0Q0dDyHgUg9AVBn90BFSyW2swstMMbtNWAMvXhhEhKJSAW86Jd04rlbKPE7/zPlQumKj8FL6DQziA9MlzO0B8Y18w5XIB8CaOE1gRl3wYon9DYNJTNCXriBEYZ+K6Me/3v02KWvLWBBUO3Sln2QNDYOopbS5d8pyfP0JsxIrf+owwZA+UTcdAyN+BDvFMumzCluptSBOzozNpQ3hztX7s0UpK2eqen+M7c/FB0jsKRBJjdOrnJ/32cYeVMeKVeUNe8VVaDOZjvQRcNDITl8Oc8W8qj67WHN3z/sC+Yhp2GFKpLKSmE86TibVClV4GS+N31sVNaG+D16R/mJkLs5mmMX8X8PRZnUaL8Fgthqai7OwQxub4Mr7I5XkMFAP+hzuQjMK+pSFhYvGsz5Qx3/mPNtLBVL1KavTdEOJnQyfg7+xxeQD793ceIQfvm2QYVsKAkEcjfes3+u4zrhBf8NYzO/QdCt4DODeeSCW1yA0Fupv9GDggMeZ8Q5MsypxviRyWJUT0ZvNjIaSO4g0uDrk+A9/qljvFsT8XxqKe5vvu2YbzjL2oKAddsOVt9Et4wpjOaLRLQBZzbcJ/55XzD8XjrephpJeKKmpcoPe9WviOGplNZUo5feganUi1Ftg7rula+TuwaUNU
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(31686004)(66556008)(8676002)(8936002)(6512007)(6506007)(53546011)(508600001)(6486002)(4326008)(83380400001)(186003)(36756003)(5660300002)(26005)(2616005)(6916009)(54906003)(66476007)(66946007)(86362001)(316002)(2906002)(38100700002)(15650500001)(31696002)(43740500002)(45980500001)(20210929001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?jzvk77xJiQsAvT61cV9ALK5nErH/KS1L/FF/M1LtgI2e388ZyB6qmPwxa6Wm?=
 =?us-ascii?Q?pVva+L+9h655bJ+3ujuW+tFM1goj/Lm4N+VWkhZ5bTwR6L+SlPNLsxa5mqqp?=
 =?us-ascii?Q?SQ1WBvjPy6tEMHkcK7HyMijyE0YtVj2XJfV3uqJiLVsBtHuCIOfhdjUgC2wh?=
 =?us-ascii?Q?734ey9FAvLCIvQrcnehd/vTdsF3r/MEG9tDa4q0sZMjuQYQYeHGb/qs6aBts?=
 =?us-ascii?Q?3qB+vHGIw/7HW8TZwmrZnxKeIYjTMG16iFCeoJ0O/i2ajE8f3SVhg+3FQKUS?=
 =?us-ascii?Q?BriFltAAV0P8vsIIE8HABPxsx129dFOkoVBlLxwmZX6tEAXKkeyuGdBdNr5B?=
 =?us-ascii?Q?F2vw9bSm1m4AOO7fNgnNlYh0IxvG+QEJk3FdXzTztv9pmg6uT8HeTMlVNRBp?=
 =?us-ascii?Q?fqBvsVqQ5YTf5+zw80H+onWOzIPLcyHwwjTgBy50JJOyt2123g1LsZNgP4OS?=
 =?us-ascii?Q?PkFGYaAtGAEtEI4nlBlCOI6h/VpO+VEZaUov/gCVtdgt42tAaNnaXjFGZB92?=
 =?us-ascii?Q?/LbGIJng3rViwz7wSOpBhFRKpr0pwDsDu9+2Uf4LTCfXX4IvVfxcy2vTaWXf?=
 =?us-ascii?Q?kztN+wLnYgraVhPNlr8wg932rLXlp2uWJseNpSPV6fpsLA8+IdkuPXd+BK0H?=
 =?us-ascii?Q?fEUz2z0x4oPtfkPcg6hkq2sKXD1UwbOLo1t6ib1j8tNfD/bIlyDfL/sZWg4u?=
 =?us-ascii?Q?D/vTcICBhOdjMVzd+Q0vjgHdWFxr73LmV+YEYQ95oK9GYfHb1CLBrg3JBOMK?=
 =?us-ascii?Q?C3HIBE+24yfd1owrhnhKyBYKXTSl7ZRoa4ORRxava4Qw7GUnfHf8C72r/Eoe?=
 =?us-ascii?Q?JnTSSE7OpxuLz3U1HoI593Y1bjjWmkebhNoWDAdKa0S45Yr+inOM48wBSLui?=
 =?us-ascii?Q?+nsPx5MnKbmljkI4XHw7mg2r0b+FqKR+MKygN1n4U7wtkrcGMlemtKZ4CeWd?=
 =?us-ascii?Q?euARf9ly3sCnTmD5TNSJRsPLWQrcOSuZ3aJfSdT0KCDyOcvXdN3w/aZFIg1u?=
 =?us-ascii?Q?rQZw+I3AAZ/yLv42NJ5JFlSeiWNvpsaBCrmX7Or+HJ1/Q2G9WVLX/XTL5uQ+?=
 =?us-ascii?Q?LjKTq5CxVWXDOLDulAa2w7n1VR0x/0g3w+Hl4Q9AusuzOX4qF2O9NjfsYwHx?=
 =?us-ascii?Q?TOMs0+73faWYEX1FBijF99RWlH0sD5v7dB+aWxgcA+5UglY4coGrUBEgxe8G?=
 =?us-ascii?Q?5tb9BoEh+HEgwX8dh5bISyKVXgfuiB9Q5jI0JZnqbqhLRPBCVcJ5HhvMt/IF?=
 =?us-ascii?Q?f6YgrqToCnkjCRrvFs3m5Tf3lqJWgfplXvzpb0V6OI9B621ylB2ScED6hjKQ?=
 =?us-ascii?Q?qV1V33AMvg1NPkvfSlDCZbiahnQl7002PFpSAJiLLw6sECRZnqJai5zR0pvV?=
 =?us-ascii?Q?J/Coya/8XSLQ13YwxWA7tgDsoQbLFZHYH8tBwN3gPlvaFmPbLZOiqFdb8JdX?=
 =?us-ascii?Q?Pw6ihY13Xt5ZRq2GnvqWfqkpIs38QSMJPr9/v0ItgsUPn5SP78rE+24zGHM9?=
 =?us-ascii?Q?hf3OyHoDqSd50MtfgIQzJLWxRDrAdeAFuQrQSdJIP5/RqrMUHRUuX/pOWqoT?=
 =?us-ascii?Q?A5kVqIMD5fwEm7Dg7G2uvZqt77diW7+y1Q7Z8LyyZ5Ab7kPtYoV159FhulSP?=
 =?us-ascii?Q?vWB4q++xiZm0E4UJP8+F0mo=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1e33089c-3d3c-4f05-2705-08d9e5773a8a
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2022 11:37:29.6574
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qIZ5zNvWXfstZCKr4E9qxuUH41bEVXcLmKgN01Pwf4M6qbRmOdW+MISSpRqSM81hkxOHWD02xIBTGf84RyGb6g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3133

On 01.02.2022 12:04, Roger Pau Monn=C3=A9 wrote:
> On Thu, Jan 27, 2022 at 04:13:47PM +0100, Jan Beulich wrote:
>> While we don't want to skip calling update_idle_stats(), arrange for it
>> to not increment the overall time spent in the state we didn't really
>> enter.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> ---
>> RFC: If we wanted to also move the tracing, then I think the part ahead
>>      of the if() also would need moving. At that point we could as well
>>      move update_last_cx_stat(), too, which afaict would allow skipping
>>      update_idle_stats() on the "else" path (which therefore would go
>>      away). Yet then, with the setting of power->safe_state moved up a
>>      little (which imo it should have been anyway) the two
>>      cpu_is_haltable() invocations would only have the lapic_timer_off()
>>      invocation left in between. This would then seem to call for simply
>>      ditching the 2nd one - acpi-idle also doesn't have a 2nd instance.
>=20
> It's possible for lapic_timer_off to take a non-trivial amount of time
> when virtualized, but it's likely we won't be using mwait in that
> case, so not sure it matter much to have the two cpu_is_haltable calls
> if there's just a lapic_timer_off between them.
>=20
>> TBD: For the tracing I wonder if that really needs to come ahead of the
>>      local_irq_enable(). Maybe trace_exit_reason() needs to, but quite
>>      certainly TRACE_6D() doesn't.
>=20
> Would be good if it could be moved after the local_irq_enable call, as
> it's not as trivial as I've expected, and will just add latency to any
> pending interrupt waiting to be serviced. FWIW, I haven't spotted a
> need to call it with interrupt disabled.

Okay, I guess I'll to the larger rework then.

>> --- a/xen/arch/x86/cpu/mwait-idle.c
>> +++ b/xen/arch/x86/cpu/mwait-idle.c
>> @@ -854,17 +854,23 @@ static void mwait_idle(void)
>>  		mwait_idle_with_hints(cx->address, MWAIT_ECX_INTERRUPT_BREAK);
>> =20
>>  		local_irq_disable();
>> -	}
>> =20
>> -	after =3D alternative_call(cpuidle_get_tick);
>> +		after =3D alternative_call(cpuidle_get_tick);
>> +
>> +		cstate_restore_tsc();
>> +
>> +		/* Now back in C0. */
>> +		update_idle_stats(power, cx, before, after);
>> +	} else {
>> +		/* Never left C0. */
>> +		after =3D alternative_call(cpuidle_get_tick);
>> +		update_idle_stats(power, cx, after, after);
>=20
> While adjusting this, could you also modify update_idle_stats to avoid
> increasing cx->usage if before =3D=3D after (or !sleep_ticks). I don't
> think it's fine to increase the state counter if we never actually
> entered it.

I did consider it but then decided against. Even leaving this aspect
aside the counter only counts _attempts_ to enter a certain state;
the CPU may find reasons to never actually enter it. And what we have
when before =3D=3D after is still an attempt, albeit an unsuccessful one.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Feb 01 11:47:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 01 Feb 2022 11:47:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.263553.456284 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nErdN-0007TS-9k; Tue, 01 Feb 2022 11:47:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 263553.456284; Tue, 01 Feb 2022 11:47:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nErdN-0007TL-6C; Tue, 01 Feb 2022 11:47:41 +0000
Received: by outflank-mailman (input) for mailman id 263553;
 Tue, 01 Feb 2022 11:47:39 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=0oSv=SQ=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nErdL-0007TD-Ru
 for xen-devel@lists.xenproject.org; Tue, 01 Feb 2022 11:47:39 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c154fdc0-8354-11ec-8eb8-a37418f5ba1a;
 Tue, 01 Feb 2022 12:47:38 +0100 (CET)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2105.outbound.protection.outlook.com [104.47.17.105]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-4-r3V-N44FPmualzorSAiCkQ-1; Tue, 01 Feb 2022 12:47:37 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM8PR04MB7953.eurprd04.prod.outlook.com (2603:10a6:20b:246::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.11; Tue, 1 Feb
 2022 11:47:36 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::7cc2:78a3:4d40:9d45]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::7cc2:78a3:4d40:9d45%6]) with mapi id 15.20.4930.022; Tue, 1 Feb 2022
 11:47:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c154fdc0-8354-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1643716058;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=pDwqnYfO5PggWep5MSjL+lELl+vzJJSRyHeY63WURWQ=;
	b=LsuNSF1gEd4I1pXBf6gupydkHKXi7TNU2NkqL9WJulngX4iaZ7vL+D9ur+c2v7ZsOIeGlW
	lVvL8Nqlv9skZTJ4eGa2CRjnzYhEL00XBEbWcw36r+9FnFw2E1fi8Ncn0MLwvXcmteWtpM
	zh0F7wbWfJCgoXHr/IKiEJNuu3To9n0=
X-MC-Unique: r3V-N44FPmualzorSAiCkQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=JzCAtJ48EfBzo9eIqR/JYntWrfxY7kS8tiMWL072rLKpG5GlCVshLwN9Ojm8r1VDRS/jhEgsH9PbWI7OyEGEvbFRH2AUobgRpPVRH+CzourXnRiBBAbvkHYADzyyMrXtHEsuaFdp0jajApl7OvQ8szWNr4BUt9A5omdeDoJJ9WrotBtXFh43Mqw9c/RIpAoPV2D+upaNcwf04J7bbHAcrbxjx/ncRBz2U/qrwH6SeWUznjb9ZJ2q8GMgDzJThDM9M8S1k+QQK6ATWQY8AhaM2tszN9PrVMh+zU3E7ZN0jwnW9+hoY4BIlvH/WVLeCmdByHzirfmlIj3DIVTYYnwTrQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=pDwqnYfO5PggWep5MSjL+lELl+vzJJSRyHeY63WURWQ=;
 b=O/qTIWf59p+hMGGeoQk1MAiTlAMsyvejWMyWP385WXygDEZrOAzQ954P/GnYsF6y6jONRnd2nXfSte2Yx6gg3Il/h/UFlyqFPneMA5eQJ0nh5/NO4zcKZDO+2fkGmSCdawmJb/+nuGWg5XsOY97CEzLVyqOPnxEtWa1bnL6D2Ca3LIwdj/ryFcCkhbdqgRaHK0aaZwiOgsEXf2DCrji0nkwwZoWuNG2dF1cTA/OgeU28gsszE05axUztzDGGSmiCs4KkL9CEDOx7Xpv7XZlGTahmV2GBlA/iqHc4wM5yQ2Sfu00QFeXRGAsYSiFkYZaRIDIDp0IP3x25hYMHouvNcA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <00aa1f8a-9f2a-96f1-b088-e34c9ec76f3c@suse.com>
Date: Tue, 1 Feb 2022 12:47:34 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v3 7/9] x86/svm: VMEntry/Exit logic for MSR_SPEC_CTRL
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20220128132927.14997-8-andrew.cooper3@citrix.com>
 <20220131153621.8863-1-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220131153621.8863-1-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR10CA0041.EURPRD10.PROD.OUTLOOK.COM
 (2603:10a6:209:80::18) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f80c8be2-f20f-46f2-7c34-08d9e578a40e
X-MS-TrafficTypeDiagnostic: AM8PR04MB7953:EE_
X-Microsoft-Antispam-PRVS:
	<AM8PR04MB7953C959E73CAC11AA3E0857B3269@AM8PR04MB7953.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	pfGyc/+z9pYrhGxwi3dRa2yelbUsQiJHlkLf+ZSlsVBTc6N0A0OZXiQKdvbdWl2lXCeKpjgZRDl2kgqcbFCZxdl+GgN6agj/3yi71PZgtygpY3ggLGG+iDMiORDczcVqtA9qYa3s65gaBusx5RwZiQ12L0knulwOzG+ue3cCAfigODTpCpf/ja+8q8LhJbdeOA0EZwkNlBq+hAuqzWJ/YupeK7uEffqlrYy6Nbr4GxQjGZZo4BTkqKWHWgbo0ZF9IeTcCe1UO/GOUFJuON9HhAhRp9iK2aT0Lqb5RbA4U8m9aIhZJkMFlySzpHH/tFkijpiubHLgL/UbaerWRC4uvPYAojF/pNwFn8lZpZ/k7TDqIUZBq+v5r3MPku42eQeWN1XEKfzi9AY2lPenL+nfq0pzkQuCRtIE0MONLdZtg6S0P+oovxVhdB3k6u+Ga3lcyzp0IimXcohvCuqSeo4f3tnLlbnoYy9Z7yGEXdCUCTXSqoTvjIOWCG6e26yrJ+8MDilhykgBH+y9GgySKcRIorqmsa0mwdtk0iACQL/BKlfhWyCjEZpf54E599xJXysTwrhR7nNU4Loj62YuWUcaeOOfqDNVkqN8VlkvBI4qLgwn6b9y+sP54B6DprAUQ4Sw+mDNlqejB2w4HYd0V2B5dYZXPJ3TvXNaS6LpESlSHpaWgPR6HMuLp5gDuYzkfkQpEpzn0kPEvI4OA2U3p5hiaETbo9WWmQCwLI/fGTcoTMbUqdNW+HWi64ZVGFRrVkNo
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6486002)(31686004)(83380400001)(26005)(316002)(36756003)(38100700002)(186003)(6916009)(54906003)(53546011)(31696002)(6512007)(66476007)(66556008)(8676002)(8936002)(5660300002)(2616005)(4326008)(66946007)(2906002)(508600001)(6506007)(86362001)(43740500002)(45980500001)(20210929001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bFNmM3ZJeTJyL05ZVnEvclJ6YXpZWFJBSGI0NHRSVXlkRlhwajVWTVY3QnU5?=
 =?utf-8?B?RFpYMTNRd3kvMEVGZTI2T2ZLTmt0dm5nUGxwdVhUTHZFY3V1UG5VVGI1Qm5w?=
 =?utf-8?B?clQ5d0REbGx0a0F5dXZOVCtnQ1g3YmhyVXcvS0pkNGJqMm85emhkNkUwNlRQ?=
 =?utf-8?B?NGdnREhIelZtS1hzOTEwR2FzY04vMVF5cFNvYzRBNTVrTHIvSnV5aGhRWWNa?=
 =?utf-8?B?WUlqSGZFQ01aUTNhOHhxSjhoeTRyZ2hvajc2Vm1GSGRHeVFxS09QQ3ZpSmln?=
 =?utf-8?B?aTM2MU14eXJKbkc0VGE3K0VxYjlTUHh4d1h1SkNLWUR4M3lYak5kTTNuWHZy?=
 =?utf-8?B?Z3dxUHIwcEppRXdwZHlFZFNZSHpuM2hPYkg4K1hiY3BYMXZVenV0N2JFck53?=
 =?utf-8?B?RTRhakxmTWZLR243VVM1WUJORnRDdzdKYTJlNXRyKzdUeEJlUEw3SCtZUmYw?=
 =?utf-8?B?NUN4NGpsYU8xSzRrKzJpZzJHOTE3S2k4V1BiK3d1Q2p3N2M4WkYwODRyRDUv?=
 =?utf-8?B?NXVjZjZCOFkxVGZwb2s1VHhqM2VRR3grZTdqY01NUWxDUUlnbS9OQm0rVXAz?=
 =?utf-8?B?N1NnYVZmelhHQmtqbHRHS0cxbXBSczcrK3lGOG9NVHlJSkJmbE5RQ29MdXlP?=
 =?utf-8?B?U3o2aElnVkE2NzM3THl3UXFhNGFqVnppV1B5d1JQckVtTHc0dkZVRXVQemtF?=
 =?utf-8?B?MlZnQ1NmN1drQ091ZWlaRVJXc2JHbnhOYlpTbjNnMTZwVmp4cG83dWxXcWVD?=
 =?utf-8?B?N2p4ejZDZ0ptK1o3UXMyRFVwa0F5T1JlZktUU1E4T28yYmhKekladEJOT2Vr?=
 =?utf-8?B?djBYT3Q4ZXl6eUJkK1Q4bGU3ZVNBMnFOdUdMQTFVeklmb1BzSUZUNEloVnhJ?=
 =?utf-8?B?OVpKSEE3dGpPOXA1dU9jUVdOdkhkOWExYm1qUm5ZYlVMenU0OWNNWGh4eDF5?=
 =?utf-8?B?WHk4TEZLZWU0ZlQrbkQzRkl1QTB1VkZFSzJxaFhOa1NIamY0c1RPemR0YmIz?=
 =?utf-8?B?WmE0blhVL2ZXZ1JrczF6NlEzTHpRSm0veGNxU3JKZWVNVkRxTk5XVUVBcVBT?=
 =?utf-8?B?R1d4M1JFbGYxMlMrZVZ5ZTBzam5GZ3FtOW5kSk4vcFlPaWRvQWc5a0VsaEcx?=
 =?utf-8?B?VVArSE1pZXRIK05ZL25tMlRlRS9PTXg3ZTkxbitJeVl3TW5obVhEVTlNTXQv?=
 =?utf-8?B?WVFINEtNREZSK1hVWU1sZDhvZUVTTHlockJvL2s4aklka2M1Q0dQUGE4RWFZ?=
 =?utf-8?B?eHBBM1BQV01yZ1JFSzZNNSt3Y0lZbmV1MDFVUS9aQ3J3elJrNW9xdjQ5NUNx?=
 =?utf-8?B?SkdKRWtpc1hhT09NVDE3ZFpDajd4ZUZDb3hTZHhuMHFsQlJvQzJueWhCS0ZC?=
 =?utf-8?B?MFo4eFQ5eXdNL2Zkc25Cbms3SzYySEFtdjREdUYxazlLbFBlUGQrUDBmTkpJ?=
 =?utf-8?B?WHFDWW9yTnRBVCs3T2tLQnpsRlVselpFRFRvcDJqeWdwN3VGdDZqcTl5VGVQ?=
 =?utf-8?B?NmxsaVU5TENHT2VJdW1nMFZVb0c5N092L2FCUTU1TG5hQituLzcybU1jakdG?=
 =?utf-8?B?T2NnaG0yVWo4UlRiWCtyZHlUdGJNT0JEZ1M5SDZSOGQwOVVpQVBBL2U1RGRu?=
 =?utf-8?B?TEEvNmg4R0loZzRnb2ZpUzZnN2xNUkdtRitxaEhFV0I0MjV3WWhwYm1rcWo3?=
 =?utf-8?B?L0gwcWZnOVBRNmRvT1ZDUVoraHlZZ1dVdkJPc09STGJrL3g5cGJnSkJONzlW?=
 =?utf-8?B?aENiSkZaNlRLMnJIVzZBNGxiNXpiUERUSWlHRHVLMCtpcmM1LytVdVAxQ3N4?=
 =?utf-8?B?eG5wbk9rWnBSdy9LVjBoYXBSQjl6ejJUeEgxQ290MEUxT0Q4RUdTbitsMWI1?=
 =?utf-8?B?TzBVVG82dmFIMWRkc2dReFZURmFaMGdhbWM3S2FvaVdXYmFrMXVDZFhxbVBh?=
 =?utf-8?B?Mkc5UEtXQW83RHNpSXdBMmF0MmNrMzZlS3I4MEFJUGV3aUpveDlnKytiYWJl?=
 =?utf-8?B?ZFc5ZjJ3YUdid00waC9HZEVFdCt6RXkxTC9PLzYxaVlGUkQ1OFMxVEdFUDZY?=
 =?utf-8?B?RnBLa3VjbzBNR0FwcXM1eU9XSTFlV0RpNnduMTVXMHorUnhUQnhEYWxYQkxS?=
 =?utf-8?B?MUFTbG9rQWxkNkkzRG12akkwRTJGOHF1UmpyNERxUjBlTTRBMFRmczRnNjhY?=
 =?utf-8?Q?eGYFX8HIArNFQhgr9jncqao=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f80c8be2-f20f-46f2-7c34-08d9e578a40e
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2022 11:47:36.2134
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QhZidrHzgZfjZVS2Oi8xEg4LQvN1nz+bdjfcwTD8FE+UjE/cgJHW7aYnJwnmiZp4JcHfhF0NabDlAS7GO68O8g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7953

On 31.01.2022 16:36, Andrew Cooper wrote:
> Hardware maintains both host and guest versions of MSR_SPEC_CTRL, but guests
> run with the logical OR of both values.  Therefore, in principle we want to
> clear Xen's value before entering the guest.  However, for migration
> compatibility,

I think you've explained this to me before, but I can't seem to put
all of it together already now. Could expand on how a non-zero value
behind a guest's back can help with migration compatibility? At the
first glance I would be inclined to say only what the guest actually
gets to see and use can affect its migration.

> and for performance reasons with SEV-SNP guests, we want the
> ability to use a nonzero value behind the guest's back.  Use vcpu_msrs to hold
> this value, with the guest value in the VMCB.
> 
> On the VMEntry path, adjusting MSR_SPEC_CTRL must be done after CLGI so as to
> be atomic with respect to NMIs/etc.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Preferably with the above expansion and with one further style
issue (see below) taken care of
Reviewed-by: Jan Beulich <jbeulich@suse.com>

> --- a/xen/arch/x86/hvm/svm/entry.S
> +++ b/xen/arch/x86/hvm/svm/entry.S
> @@ -55,11 +55,23 @@ __UNLIKELY_END(nsvm_hap)
>          mov  %rsp, %rdi
>          call svm_vmenter_helper
>  
> -        mov VCPU_arch_msrs(%rbx), %rax
> -        mov VCPUMSR_spec_ctrl_raw(%rax), %eax
> +        clgi
>  
>          /* WARNING! `ret`, `call *`, `jmp *` not safe beyond this point. */
> -        /* SPEC_CTRL_EXIT_TO_SVM   (nothing currently) */
> +        /* SPEC_CTRL_EXIT_TO_SVM       Req: b=curr %rsp=regs/cpuinfo, Clob: acd */
> +        .macro svm_vmentry_spec_ctrl
> +            mov    VCPU_arch_msrs(%rbx), %rax
> +            movzbl CPUINFO_last_spec_ctrl(%rsp), %edx
> +            mov    VCPUMSR_spec_ctrl_raw(%rax), %eax
> +            cmp    %edx, %eax
> +            je 1f  /* Skip write if value is correct. */

Wold you mind padding the insn operand properly, in line with all
others nearby?

Jan



From xen-devel-bounces@lists.xenproject.org Tue Feb 01 12:28:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 01 Feb 2022 12:28:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.263561.456294 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEsGi-0003Hq-Kc; Tue, 01 Feb 2022 12:28:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 263561.456294; Tue, 01 Feb 2022 12:28:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEsGi-0003Hj-Hg; Tue, 01 Feb 2022 12:28:20 +0000
Received: by outflank-mailman (input) for mailman id 263561;
 Tue, 01 Feb 2022 12:28:18 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2F7S=SQ=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nEsGg-0003Hd-Ej
 for xen-devel@lists.xenproject.org; Tue, 01 Feb 2022 12:28:18 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6cda2280-835a-11ec-8eb8-a37418f5ba1a;
 Tue, 01 Feb 2022 13:28:16 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6cda2280-835a-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1643718495;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=0UJeKWARNCUtcyjUqQaNonTHuDI9HbUzQ6UuBPM+AfE=;
  b=AZYo4dhOIdsdbFkrGuXIasoYFRhdi42FQ1/m+GS2XLWc7PCaJq9/0CqS
   tobtXsXkKVn2brrB4kdTD6obDJeee72vyprNfflXPo9eU5OKkN4k7uG6k
   Y6oJNaOAUQpS28mjRmAp2ndelg5CvwUhw8newGnjDUGulu02Yro7HXGe2
   8=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: tTRB0ZNaEt3bSneN/l7m2N+qOFT187TSGiF/u8Y91jtSYoj/3yNaswPajDu1dBxxT8YljR2D6X
 /02iPtjCyqikR1++H4tWsBwyKag+h48lwMnku4l0GqCdJZUs803IROQFevIg3BXEdqXj6JE3zp
 c8G6uziTEwlShYjeQVWXENz34UP3mNB0CFhp85HFEznswEt3LqoUIMkF5KQGxcrydMAemQ2Gbx
 BarMJjonAl5v1Ur71SAuVuv6MSJ6SKr/Ka6U4+ZGb/F61F0HKlRWoaPiUE0Dt+II07YFtlxKp0
 RArmX31KHp+XeT1nIcWqAqjz
X-SBRS: 5.2
X-MesageID: 63125858
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:wIfhna3W/549BQgZhPbD5T52kn2cJEfYwER7XKvMYLTBsI5bpz1Vy
 DYXDD+AO6yMMWTxcox1aNm3o0NV7JTcnINkGQZtpC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkS5PE3oHJ9RGQ74nRLlbHILOCanAZqTNMEn9700o5w7dh2+aEvPDia++zk
 YKqyyHgEAfNNw5cagr4PIra9XuDFNyr0N8plgRWicJj5TcypFFMZH4rHomjLmOQf2VhNrXSq
 9Avbl2O1jixEx8FUrtJm1tgG6EAaua60QOm0hK6V0U+6/TrS+NbPqsTbZIhhUlrZzqh2OJf5
 Y5juayJd1knAfPMnfYmaEJpHHQrVUFG0OevzXmXtMWSywvNcmf2wuUoB0YzVWEa0r8pWycUr
 6VecW1TKEDY7w616OvTpu1Er8IvNsT0eqgYvWlt12rxBvc6W5HTBa7N4Le02R9u3ZkUQKaDN
 6L1bxJ2SSbCfxhAEGxPBZQmmfeS22n7dAVx/Qf9Sa0fvDGIkV0ZPKLWGMrYfJmGSNtYmm6cp
 3na5CLpDxcCLtudxDGZtHW2iYfngifTSI8UUrqi+ZZCglee22gSAx0+TkagrL+yjUvWZj5EA
 xVKoGx09/F0rRH1CImmN/GlnJKallkudfcLPeEK0T/TxJWK4wOLPVNffzEUPbTKq/QKbTAt0
 1aImfbgCjpurKCZRBqhy1uEkd+hEXNLdDFfPEfoWSNAuoC++99r0nojW/4+SPbdszHjJd3nL
 9lmRgAajq5bs8ME3r7TEbvv02P1/cihouLYC2zqsoOZAuFROdTNi2+AswGzARN8wGCxFAPpU
 J8swJD20Qz2JcvR/BFhuc1UdF1T296LMSfHnXlkFIQ7+jKm9haLJN4Mu2wuex85bJdYKFcFh
 XM/XysLvve/21PxNcdKj3+ZUZx2ncAM6/y4PhwrUja+SscoL1LWlM2fTUWRw3rsgCARfVIXY
 v+mnTKXJS9CU8xPlWPuL89EiOND7n1gmQv7GM6qpzz6gev2TCPEEt8tbQrRBt3VGYvZ+m05B
 f4FaZvTo/ieOcWjChTqHXk7dA5SdSZjWcGp+qS6tIere2JbJY3oMNeIqZsJcI15haVF0ODO+
 3C2QEhDz1Tjw3bALG23hrpLMdsDhL5z8iA2OzICJ1Gt1yRxaIqj9v5HJZA2YaMm5KpoyvstF
 6sJfMCJA/JuTDXb+mtCMcmh/dI6LBn71xiTOyeFYSQke8IyTQL+5dK5LBDk8zMDD3TruJJm8
 aGgzA7SXbEKWx9mUJTNcPuqwl7o5Sodlet+UlHmON5WfEmwooFmJzao1q08It0WKAWFzTyfj
 l7EDRAdrOjLgok07NiW2vzU89b3S7NzRxMIEXPa4LC6MTjh0lCimYIQAvyVeT39VX/v/Pnwb
 +ti0PyhYuYMm0xHstQgHu8zn74+/dbmu5RT0h9gQCfQd12uB75tfiuG0M1IuvEfz7NVo1LrC
 EeG+90cMrSVIsL1VlUWIVN9POiE0PgVnBjU7Og0fxqmtHMmouLfXBUAJQSIhQxcMKBxYdEsz
 uoWscIL7xCy10gxOdGcgyEIr2mBIxTsiUn8Wk321GMztjcW9w==
IronPort-HdrOrdr: A9a23:9qqwY62eYOB+97YwUH5I0wqjBRRyeYIsimQD101hICG9Lfb3qy
 n+ppsmPEHP5Ar5AEtQ5expOMG7MBfhHQYc2/hRAV7QZniYhILOFvAj0WKC+UyvJ8SazI9gPM
 hbAtBD4bHLfDpHZIPBkXSF+rUbsZq6GcKT9JzjJh5WJGkAAcwBnmRE40SgYzdLrWF9dMcE/f
 Gnl616Tk+bCA0qh7OAdx84tob41rj2vaOjRSRDKw8s6QGIgz/twqX9CQKk0hAXVC4K6as+8E
 De+jaJpJmLgrWe8FvxxmXT55NZlJ/K0d1YHvGBjcATN3HFlhuoXoJ8QLeP1QpF5d1HqWxa1O
 UkkS1Qefib2EmhJ11dZiGdgzUI5QxerEMKD2Xo2kcL7/aJHg7SQPAx+76xOiGpmnbI+usMjJ
 6jlljpxKa+R3n77VTAzsmNWBdwmkWup30+1eYVknxESIMbLKRctIoF4SpuYdo99Q/Bmcsa+d
 NVfYvhDTdtACSnRmGcunMqzM2nX3w1EBvDSk8eutaN2zwTmHxi1UMXyMEWg39FrfsGOtZ5zv
 WBNr4tmKBFT8cQY644DOAdQdGvAmiIRR7XKmqdLVnuCalCMXPQrJz85qkz+YiRCdA15Yp3nI
 6EXEJTtGY0dU6rAcqS3IdT+hSIW2m5VSSF8LAX23G4gMy0eFPGC1z3dLkeqbrXnxxEOLyoZx
 +aAuMjP8Pe
X-IronPort-AV: E=Sophos;i="5.88,333,1635220800"; 
   d="scan'208";a="63125858"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Y5nQDeQ+u1/zxew9evAu9eJoWVHw/V+uCrAEPobDJwCFx4uPZbUF7cDMGU0v1n9usksic5oSRQfLmXjHU2dmmUc79i1KSzIiIEPTukVOsVmS4bLjPIvycVj11kkmkLVyhFWLeHiPwHq70+rAC7Lo97UGG20OHPAC23CsysRWI3IXfhn/RG6sRjba+ncnbRauwM3zyTzLEWprpsN1a1klMJMKqsBhOCjNLXj8UCEtjaaFZEOXXfzg4C/Kt7sMFXQZqfP473s5WwdEUEZRdkzOqkL3MEEgGq36Q2t9qArJrQLqdOM8/soioyRf7figzth1nyEgN3fT5aH7aRjpExBi8w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=0UJeKWARNCUtcyjUqQaNonTHuDI9HbUzQ6UuBPM+AfE=;
 b=mki7C1rsB0TL51LORBn8WggM9aeeVrfaq7wUJHk2c9AnKBOGARNfqZ/iyU0lD4p3s5Cmoe9mukj3mz5bG0Q9IOTgmiy9K8TPFU/mzBr7Aqf6WdEfXxt3v41RfjKyjJA9iCGDxzVd1WmUIED11UqV/NjBakAPoCc9vse3fjyVXha7dDeh7qrkUcxvPS9e4a8y0JgmsKqy5oTkk0Mj7UIULPY1rjZCYjiEjCRX2MycM8cyFeCt57gT2+IAsFcmME7ABqmoirKvAs9FVcp3+3ajvLbl2X/AdJMoegFqUSGQEfPRwdoyoipS/DHX0Cp5XyARpkDy4BWBkeqs3a4Yv9dEqg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=0UJeKWARNCUtcyjUqQaNonTHuDI9HbUzQ6UuBPM+AfE=;
 b=kT8sdXGWBtbewRzEGaZb8HIjyQ9YlZxRSaCUjgk5Z+wRtIdDZutIAw31fxfijTtXMcONPssFs+X+8Ml3Oss24piGI9lCZ8U5xzf6r1sC7pmBvJTk8Fe62+DmIJ3DZJtJ/pp+CgaZBhLpi6VxO19d6tylRrcdYOZxxOr6YwBHcGY=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>, Xen-devel
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v3 7/9] x86/svm: VMEntry/Exit logic for MSR_SPEC_CTRL
Thread-Topic: [PATCH v3 7/9] x86/svm: VMEntry/Exit logic for MSR_SPEC_CTRL
Thread-Index: AQHYFrhnGKPHuYBRW0udTNFT0Cg4lKx+lY8AgAALVgA=
Date: Tue, 1 Feb 2022 12:28:08 +0000
Message-ID: <e48536c0-14c1-1d41-0a9e-4fc0f0aa9c36@citrix.com>
References: <20220128132927.14997-8-andrew.cooper3@citrix.com>
 <20220131153621.8863-1-andrew.cooper3@citrix.com>
 <00aa1f8a-9f2a-96f1-b088-e34c9ec76f3c@suse.com>
In-Reply-To: <00aa1f8a-9f2a-96f1-b088-e34c9ec76f3c@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.1
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 1b74e8b2-a28c-45dd-eb4d-08d9e57e4e2e
x-ms-traffictypediagnostic: CH2PR03MB5351:EE_
x-microsoft-antispam-prvs: <CH2PR03MB53513D5CA8F4EE49122FD405BA269@CH2PR03MB5351.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: GxX+4MeOuCIgDXLFFS8vd+XMH2PCMIUoXCDVjmtlq5leK3E2qAb+02YCmh2I3A0aRFtL0cH5FO+hsvyH2fWaNk9jhH/84MvdmvDW2eh7fVSGSrvUQ+oDuuP9tapesBvB1BEj4AM8VcjSyS1e6RSXcAOVCFTZKV6psiZqzPhOpqyXc78V8ska6uq52gIi1KiTL2c1AgQ6UgsEsmv0xf+XBeHORl0IrQwehi/lB3h65vVkkSRQjjxN93GH639ZeP9Wk1IgVeXFKUWNuXKqSaBuoV9kYmr9ScoFL+JZIB+kXOdqEqn9/rrv+M4dPgWbgIxF6t4e8FkKss1M2JgM4/lSpsrblBZs2/+IsY4R042vkdAlj0db7FwJwL1cfWeXzQJ5pgRJYTcab6++hvFJW9Z06KlTT6xxUJZs8XYBQQ9MQ5T+Jih9BBaG6NnNgf4BgTJo5FT8aqs1VcoHbzSf1fkrISLvPqX6zAMN9+lb+nnmSnME1c7AA9b4NBZsgarvkBkP7cJSkv6tzR8PD7W1NO4feRBXL2lokejLU+FYnbZbJ32V43CL9w9kB/vbHqp1833ZDoj7Eh1ZJDByVrKwLo8SmWclWkLFVYxg5bqe47ca8AH9N//+k+2a28nj1v++Fp5AznS68kTR2hA3pKVH3rfeOjfwsNHIjZK9sKcvUt5YDmZ65O57OOwto/wiz8w8t5JSPbxe0+B2H2DtAS+ciAp4LHni6KIBBqvWpvL1xkytwBZfDT2EDXA1JKD7UD5Yu1v+/otMpKkWpa3+Bo8u9Ww6mA==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(54906003)(2906002)(5660300002)(122000001)(6916009)(316002)(6486002)(508600001)(36756003)(4326008)(26005)(66946007)(91956017)(53546011)(8936002)(76116006)(71200400001)(82960400001)(86362001)(6512007)(2616005)(8676002)(38070700005)(66446008)(64756008)(66556008)(66476007)(31696002)(38100700002)(6506007)(83380400001)(31686004)(186003)(43740500002)(45980500001)(20210929001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?cUYrQy9MWEdtaVVGNzFMR2gwbVRBTy9vSEFRUU55MHpZMjJpWU82RVFSelB0?=
 =?utf-8?B?Ly9xZjRuYUVMOXpZdURUOXJNRTVyMFA5b1dPM3JTM2kyQzJjOVpUZWhkRUxI?=
 =?utf-8?B?ZGo4RmltbFNlU29oOEQ2ekhSWlpnSytFVFZPbDZRQ1h4QXN5RS9MQnpWOFI5?=
 =?utf-8?B?bU1xaUIrT25aSXpMQlpwdk0vd0xwb1JjeHEvQ1U4d0ZMa2ljQnNsUVZFb0wx?=
 =?utf-8?B?ZUZlNXpOR2F3ZWRVVzRLay9oWCtPMDJDVDIvUUVJTzc3TFp2cUtnQTRJcTZU?=
 =?utf-8?B?dllDRklhTUgzYXNvRFRZMTBJM0VzMHBjUGVnMVl5STZIUU83YWRGcGRtVHlB?=
 =?utf-8?B?dzVzdHRDRkYzaDN0U2g2QTBuVTczRUJTcWhhMXBYbVNyckhWdE1kZEI2RVQy?=
 =?utf-8?B?UEJBdFdqdlBySktJaWdvSTZ0UkQvd1JRc1ZBUVVqbTQ0SDlnK1Y1YmhROFpl?=
 =?utf-8?B?ajRwNEtHMnRwemhkUkFOTzVsQ3o3MW1qdnIyeGNZV1poV3Rlb2ZsZEE5SWVX?=
 =?utf-8?B?VWdJdUI5czdpbVFiVmxPM0xnMVpPUmdmT0JnOWVTbDJIUjJwbFQ0ZXYyOVRm?=
 =?utf-8?B?aWJzNk5LcXBKTG00U0xYVVR0WlpHV2M5M0pNc2hSYWpvWk5QSjl3cW1ITjZq?=
 =?utf-8?B?QUJtWmZHUW5sbHhPZGswQ0xwNlZDOUNEdlFlaWRzc0N6QWZBNm5nenFFcUZi?=
 =?utf-8?B?QTA0eG1ydExtNWNKdkhTeFdhTmZnb0hPSEQ5VWVOcndXTTNOc1NkNmpuVEUy?=
 =?utf-8?B?S0Y4YUY4OUx6eCtBYjlUOTlWNmMyL0phZnovYVNuMjl4U0dXZEY0RFdENEdu?=
 =?utf-8?B?TDkwajd1cy9wQ3VOQ0M5TENkeE9CSm5SU0NsVkovbnNiQjhHeFQ5OG5CVHJw?=
 =?utf-8?B?a1hmRXVaR3Nld3ZVUzk1RkR3ZEttbjVNdlhXTXZBRm95bkZIbkNrUEZmWkxB?=
 =?utf-8?B?ZWlZWnJJNW1mVFEwZkc0OEdGUHFtaXR3c1BKNkhMU2lTemVkbGRkb1VwNTYy?=
 =?utf-8?B?MUp2RXRhL21CT2U4OG5WZk8vUjJiQU1ldkl3d0V2LzFaejI5a0laVVk2Y1FC?=
 =?utf-8?B?UFFRNGIxSWJwZWVVTCtjSk5vTnpVa044Sy9zeXVoQVpGK3pFWUJhZDJtQWhK?=
 =?utf-8?B?ek0rUDllelJOSEwwaGpaZFpZL0tPaGNTTXNUOWZqenVzVTBBVnRNeWZYdkhD?=
 =?utf-8?B?cnB2Y3pxdERNdzBpZzY5aFY4aUdIWCtFdU4wVVhjOVFyejhuRnM3eTdNbWk3?=
 =?utf-8?B?ckpSY0M1UnJFMnNQQ2trcXVIRDJBNENJNUw5WTgrcGtJNnkyL0hFU0N6NU82?=
 =?utf-8?B?QWJSaEQydGlmZ2VWdlNwdTBYVkM1M2d3Z3BlajZhNnBGTjJZVnRqRW1NZis4?=
 =?utf-8?B?Tk5sbCtjZHhXUEIzMjV1RW5BVWM0N1FlMWxtM0JkUUZDWWJWVDZDQ1RWcm1s?=
 =?utf-8?B?ZGIzS0NWbHkzN2hwTDZuMW1lZVNDY0lyUlgxZHJ5UktMUExTcTVYVU5TQm4r?=
 =?utf-8?B?RGJ2OE55eFRPUXdwTy8yQmR0TVNYUWh1TnlheUw2K21ia2lmeDVxYmFnbjdN?=
 =?utf-8?B?NlJidko4cHlwMjlDZ2dERlU2TjVINC9QNGUrOERWWDlvODBLT0lvOEVkREh4?=
 =?utf-8?B?VXpuOG9ZOHlPSTBWeFJRSWVpN1BSQUNFQi8wM0FXTXJWUWxPVXZCNndqdlRr?=
 =?utf-8?B?UGVQdWRPZkdKZXpjdVd2MnNyOWkrRCsvVGp5K2FnY0ZoUnJva1dFaVVDVjJj?=
 =?utf-8?B?TzM5a2hOb1EwaHJUeFNmVEg1RGxXcFBjbURQKzZNZUs1R2tMMkhmdmYwMGF3?=
 =?utf-8?B?RHhaZzVpNDJvSnhzZjRuT0s3UzhyVEtBTmduZ3d2RHhrNnA4T05uUmgwemZn?=
 =?utf-8?B?S3hyV21IdGV5cThoYk9iakUwSDU3c1BTcHlacnI3R3c5clo5WU4wcUpMMTlo?=
 =?utf-8?B?N21qdDJ2Q2VxaFFPaW9PZkJBaklTbGUxMFJvb1lQcVU1V0VSVEttd2t1TEZq?=
 =?utf-8?B?ek1md2NMMkVVdWhDZElXMi8xT1hwcStxZmZ2OU1DZ0psU2RCc2cwd2REWDZ6?=
 =?utf-8?B?S1JxUXhDNkhtYVJZNTJOa1grd04yUDgyR0JFSGN3cXJyakxFbjROenQyMjV5?=
 =?utf-8?B?VGgvclE1R0JxVHZaR0p5M2Z4Q05EdGZDMEwvTEJpUjNRWTUvQjBzdTJRdm5C?=
 =?utf-8?B?VlU0cTViNGpPZmRoQURZMXlzampaOWh0eWNveC9ZT0FmNGJMN092V1VKQksw?=
 =?utf-8?B?YXNncjdmTmlCbmJVdnBMK016TlRnPT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <A4F3A745680B5F4FACEF90C99B0722C7@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1b74e8b2-a28c-45dd-eb4d-08d9e57e4e2e
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Feb 2022 12:28:08.8254
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: AJIeEse0LBeO0uCGbqlCmGmwvoJwBf+tFpoW3+WgTRFMZmyVyBfFiBSj8pssshwH9R+vpxElHy5ut9BEXaPSFaOOqy17qR/O5kZDTmtAJWI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR03MB5351
X-OriginatorOrg: citrix.com

T24gMDEvMDIvMjAyMiAxMTo0NywgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDMxLjAxLjIwMjIg
MTY6MzYsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBIYXJkd2FyZSBtYWludGFpbnMgYm90aCBo
b3N0IGFuZCBndWVzdCB2ZXJzaW9ucyBvZiBNU1JfU1BFQ19DVFJMLCBidXQgZ3Vlc3RzDQo+PiBy
dW4gd2l0aCB0aGUgbG9naWNhbCBPUiBvZiBib3RoIHZhbHVlcy4gIFRoZXJlZm9yZSwgaW4gcHJp
bmNpcGxlIHdlIHdhbnQgdG8NCj4+IGNsZWFyIFhlbidzIHZhbHVlIGJlZm9yZSBlbnRlcmluZyB0
aGUgZ3Vlc3QuICBIb3dldmVyLCBmb3IgbWlncmF0aW9uDQo+PiBjb21wYXRpYmlsaXR5LA0KPiBJ
IHRoaW5rIHlvdSd2ZSBleHBsYWluZWQgdGhpcyB0byBtZSBiZWZvcmUsIGJ1dCBJIGNhbid0IHNl
ZW0gdG8gcHV0DQo+IGFsbCBvZiBpdCB0b2dldGhlciBhbHJlYWR5IG5vdy4gQ291bGQgZXhwYW5k
IG9uIGhvdyBhIG5vbi16ZXJvIHZhbHVlDQo+IGJlaGluZCBhIGd1ZXN0J3MgYmFjayBjYW4gaGVs
cCB3aXRoIG1pZ3JhdGlvbiBjb21wYXRpYmlsaXR5PyBBdCB0aGUNCj4gZmlyc3QgZ2xhbmNlIEkg
d291bGQgYmUgaW5jbGluZWQgdG8gc2F5IG9ubHkgd2hhdCB0aGUgZ3Vlc3QgYWN0dWFsbHkNCj4g
Z2V0cyB0byBzZWUgYW5kIHVzZSBjYW4gYWZmZWN0IGl0cyBtaWdyYXRpb24uDQoNCkZvciBWTXMg
d2hpY2ggc2VlIFZJUlRfU1BFQ19DVFJMIChjb21wYXRpYmlsaXR5IHdpdGggRmFtMTUgdGhydSBa
ZW4xKSwNCndyaXRlcyBvZiBWSVJUX1NQRUNfQ1RSTC5TU0JEIChwcm9iYWJseSkgbmVlZCB0byB1
c2UNClNTQkQtYmVoaW5kLXRoZS1ndWVzdCdzIGJhY2suwqAgSSBzYXkgcHJvYmFibHksIGJlY2F1
c2UgSSB0aGluayB0aGlzIGlzDQp0aGUgbGVhc3QgYmFkIGltcGxlbWVudGF0aW9uIG9wdGlvbiwg
YnV0IHVudGlsIHdlIGhhdmUgd29ya2luZyBzdXBwb3J0LA0KaXQncyBzdGlsbCBhIGd1ZXNzLg0K
DQpGb3IgdGhlIHVsdHJhIHBhcmFub2lkLCBhIFZNIG1pZ3JhdGluZyBpbiB3aGljaCBjYW4ndCBz
ZWUgUFNGRCAoZS5nLiBmb3INCmNvbXBhdGliaWxpdHkgd2l0aCBaZW4yKSBzaG91bGQgaGF2ZSBQ
U0ZEIHNldCBiZWhpbmQgaXQncyBiYWNrLsKgIEV4Y2VwdA0KdGhhdCBTU0JEIGFsc28gaGFzIGFu
IGFwcHJvcHJpYXRlIHNpZGUgZWZmZWN0IHNvIHRoYXQgZXhpc3RpbmcgIkknbSBhDQpwaWVjZSBv
ZiBjcml0aWNhbCBjb2RlIiBzaWduYWxzIHRoYXQgaGF2ZSBncm93biBpbiB2YXJpb3VzIE9TZXMg
Y29udGludWUNCnRvIGRvIHRoZSBzYWZlIHRoaW5nIG9uIFBTRkQtY2FwYWJsZSBoYXJkd2FyZS7C
oCBHaXZlbiB0aGF0IHdlIGRvbid0DQphY3RpdmF0ZSBTU0JEIGJ5IGRlZmF1bHQsIHdlIHNob3Vs
ZG4ndCBkZWZhdWx0IGRpc2FibGUgUEZTRCBiZWhpbmQgYW4NCnVuYXdhcmUgZ3Vlc3QgZWl0aGVy
Lg0KDQpUaGF0IHRoZW4gbGVhdmVzIHRoZSBtZWFuaW5nIG9mIHNwZWMtY3RybD1zc2JkLHBzZmQg
YmVjYXVzZSBzc2JkIGlzDQpjdXJyZW50bHkgc3lzdGVtIHdpZGUgKGlmIGVuYWJsZWQpIG9uIEFN
RC7CoCBUaGlzIHNlcmllcyBjaGFuZ2VzIHRoYXQgZm9yDQpIVk0gZ3Vlc3RzLCBhbmQgaXQgd2ls
bCBjaGFuZ2UgYWdhaW4gc2hvcnRseSBmb3IgUFYgZ3Vlc3RzLCBhbmQgdGhpcyBpcw0Kb2J2aW91
c2x5IHRoZSBiZXR0ZXIgZGVmYXVsdCBiZWhhdmlvdXIuwqAgQnV0IHdlIGNvdWxkIGhhdmUgYSBz
eXN0ZW0gd2lkZQ0Kb3B0aW9uIG9uIHRvcCBvZiBndWVzdCBzdXBwb3J0IGluIG1vc3QgY2FzZXMg
aWYgc29tZW9uZSBzZWVzIGEgbmVlZC4NCg0KPj4gYW5kIGZvciBwZXJmb3JtYW5jZSByZWFzb25z
IHdpdGggU0VWLVNOUCBndWVzdHMsIHdlIHdhbnQgdGhlDQo+PiBhYmlsaXR5IHRvIHVzZSBhIG5v
bnplcm8gdmFsdWUgYmVoaW5kIHRoZSBndWVzdCdzIGJhY2suDQoNCkZvciBjb21wbGV0ZW5lc3Ms
IGZvciBTRVYtU05QLCBJQlJTIG5lZWRzIHNldHRpbmcgdG8gYXZvaWQgdm1lbnRyeQ0KaXNzdWlu
ZyBJQlBCLsKgIE1vcmUgc3BlY2lmaWNhbGx5LCB0aGUgVk1leGl0PT5FbnRyeSBwYXRoIG11c3Qg
bm90IGNsZWFyDQpJQlJTLCBhdCB3aGljaCBwb2ludCBoYXJkd2FyZSBrbm93cyB0aGF0IG5vdGhp
bmcgY2FuIGhhdmUgZ290IGludG8gdGhlDQppbmRpcmVjdCBwcmVkaWN0b3IuDQoNCg0KPj4gICBV
c2UgdmNwdV9tc3JzIHRvIGhvbGQNCj4+IHRoaXMgdmFsdWUsIHdpdGggdGhlIGd1ZXN0IHZhbHVl
IGluIHRoZSBWTUNCLg0KPj4NCj4+IE9uIHRoZSBWTUVudHJ5IHBhdGgsIGFkanVzdGluZyBNU1Jf
U1BFQ19DVFJMIG11c3QgYmUgZG9uZSBhZnRlciBDTEdJIHNvIGFzIHRvDQo+PiBiZSBhdG9taWMg
d2l0aCByZXNwZWN0IHRvIE5NSXMvZXRjLg0KPj4NCj4+IFNpZ25lZC1vZmYtYnk6IEFuZHJldyBD
b29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+DQo+IFByZWZlcmFibHkgd2l0aCB0aGUg
YWJvdmUgZXhwYW5zaW9uIGFuZCB3aXRoIG9uZSBmdXJ0aGVyIHN0eWxlDQo+IGlzc3VlIChzZWUg
YmVsb3cpIHRha2VuIGNhcmUgb2YNCj4gUmV2aWV3ZWQtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGlj
aEBzdXNlLmNvbT4NCg0KVGhhbmtzDQoNCj4NCj4+IC0tLSBhL3hlbi9hcmNoL3g4Ni9odm0vc3Zt
L2VudHJ5LlMNCj4+ICsrKyBiL3hlbi9hcmNoL3g4Ni9odm0vc3ZtL2VudHJ5LlMNCj4+IEBAIC01
NSwxMSArNTUsMjMgQEAgX19VTkxJS0VMWV9FTkQobnN2bV9oYXApDQo+PiAgICAgICAgICBtb3Yg
ICVyc3AsICVyZGkNCj4+ICAgICAgICAgIGNhbGwgc3ZtX3ZtZW50ZXJfaGVscGVyDQo+PiAgDQo+
PiAtICAgICAgICBtb3YgVkNQVV9hcmNoX21zcnMoJXJieCksICVyYXgNCj4+IC0gICAgICAgIG1v
diBWQ1BVTVNSX3NwZWNfY3RybF9yYXcoJXJheCksICVlYXgNCj4+ICsgICAgICAgIGNsZ2kNCj4+
ICANCj4+ICAgICAgICAgIC8qIFdBUk5JTkchIGByZXRgLCBgY2FsbCAqYCwgYGptcCAqYCBub3Qg
c2FmZSBiZXlvbmQgdGhpcyBwb2ludC4gKi8NCj4+IC0gICAgICAgIC8qIFNQRUNfQ1RSTF9FWElU
X1RPX1NWTSAgIChub3RoaW5nIGN1cnJlbnRseSkgKi8NCj4+ICsgICAgICAgIC8qIFNQRUNfQ1RS
TF9FWElUX1RPX1NWTSAgICAgICBSZXE6IGI9Y3VyciAlcnNwPXJlZ3MvY3B1aW5mbywgQ2xvYjog
YWNkICovDQo+PiArICAgICAgICAubWFjcm8gc3ZtX3ZtZW50cnlfc3BlY19jdHJsDQo+PiArICAg
ICAgICAgICAgbW92ICAgIFZDUFVfYXJjaF9tc3JzKCVyYngpLCAlcmF4DQo+PiArICAgICAgICAg
ICAgbW92emJsIENQVUlORk9fbGFzdF9zcGVjX2N0cmwoJXJzcCksICVlZHgNCj4+ICsgICAgICAg
ICAgICBtb3YgICAgVkNQVU1TUl9zcGVjX2N0cmxfcmF3KCVyYXgpLCAlZWF4DQo+PiArICAgICAg
ICAgICAgY21wICAgICVlZHgsICVlYXgNCj4+ICsgICAgICAgICAgICBqZSAxZiAgLyogU2tpcCB3
cml0ZSBpZiB2YWx1ZSBpcyBjb3JyZWN0LiAqLw0KPiBXb2xkIHlvdSBtaW5kIHBhZGRpbmcgdGhl
IGluc24gb3BlcmFuZCBwcm9wZXJseSwgaW4gbGluZSB3aXRoIGFsbA0KPiBvdGhlcnMgbmVhcmJ5
Pw0KDQpPb3BzIHllcy7CoCBGaXhlZC4NCg0KfkFuZHJldw0K


From xen-devel-bounces@lists.xenproject.org Tue Feb 01 12:40:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 01 Feb 2022 12:40:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.263568.456305 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEsSI-0005Wj-P9; Tue, 01 Feb 2022 12:40:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 263568.456305; Tue, 01 Feb 2022 12:40:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEsSI-0005Wc-MB; Tue, 01 Feb 2022 12:40:18 +0000
Received: by outflank-mailman (input) for mailman id 263568;
 Tue, 01 Feb 2022 12:40:17 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=0oSv=SQ=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nEsSH-0005WW-TO
 for xen-devel@lists.xenproject.org; Tue, 01 Feb 2022 12:40:17 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1b8205a3-835c-11ec-8eb8-a37418f5ba1a;
 Tue, 01 Feb 2022 13:40:16 +0100 (CET)
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur03lp2053.outbound.protection.outlook.com [104.47.9.53]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-36-gOBB7BTpMw6VAap2u5q1vw-1; Tue, 01 Feb 2022 13:40:15 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM0PR04MB5282.eurprd04.prod.outlook.com (2603:10a6:208:d0::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.22; Tue, 1 Feb
 2022 12:40:13 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::7cc2:78a3:4d40:9d45]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::7cc2:78a3:4d40:9d45%6]) with mapi id 15.20.4930.022; Tue, 1 Feb 2022
 12:40:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1b8205a3-835c-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1643719216;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=avYg0rdtgC1YI1RFwM+yWFrHbEPRW9jAzGZS3O0Byv0=;
	b=hcAdOti2i4x2LwobUxfemGwNKL8ompfsWgQ2dZdssttSx34Pd0XkLm99i9OHRe1h9Pm5Yw
	wVMm6tGREyTQ0DxwMMpmYUqi0tmGgsB8a3dl4Fz0Nlk4dXRZEvL0FF9EVq8gy5hJr2SpJX
	vt8LQbLJwTGHHPmWlLVnoxREY90E/ik=
X-MC-Unique: gOBB7BTpMw6VAap2u5q1vw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Z6/5F5XQeR7+H8Wf+53yvpNe9JZJFDYC2B5frAQTiHX+XPrrYrMWLw/ccVTuR8BQLqgknXN7Tjip5P3MeCmpEPmPkkiLDX8gtm2gPgyvrHfZrkaNKEuCoeYJ5DGFwu/GhImghvQ0u8jFJVvVZNdMX66A2fbJWieWEk1cHFNFEhdzAuH1zmlUMWw01Lt30x1BvcUal1mL2nD/Wf1n4NCFych8v4+sREZg9EkHZPlcxC+jSsJ9jKd08xoHab/suEa5gl/YooFBtBkrZByJzBKoFku/KBL2IyQ3QQ0OsXWhqyHjJrIYswkIKcYA+ygt/bJU6kysmmHv434Sk0aroGok7Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=MDRW/Olnu5E8VPy5W3O0ZgHI1/knDGqygMIYuN6pLBw=;
 b=AC0YEK30+CjUztNhuaOWqNGJhAyWSCsYp/gpORQZmPoFp1AvbLn6brSJT39QBXPgUq27yBUV7RLVt7P7Tin3JOoksrZFU2E1YzhJ13thqxZFAseGxyOqTap87C/6JvCHj5yubyt3yIzceAipxCpbvXrpjATE8U9BpMl+slfnxPIKytC2iXAM27ZqCk2FoEH+gy8cfl1pUd/tVXY4OD0P9AoOkGf5MYzc6t9/fJBGueLzhZJWXt7r+9loR2P9+Qk/szROf7X4E91MHpQyEQmfM7lfHE9aK1Pglhz+cDwaQ/LOVb9xzi+ukVM4Hvfm/8SgeqZfeMreAvM4ktrV9jhT0A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <52587ee4-56a3-3824-75cd-667c35e3109f@suse.com>
Date: Tue, 1 Feb 2022 13:40:11 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v3 7/9] x86/svm: VMEntry/Exit logic for MSR_SPEC_CTRL
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
CC: Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20220128132927.14997-8-andrew.cooper3@citrix.com>
 <20220131153621.8863-1-andrew.cooper3@citrix.com>
 <00aa1f8a-9f2a-96f1-b088-e34c9ec76f3c@suse.com>
 <e48536c0-14c1-1d41-0a9e-4fc0f0aa9c36@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <e48536c0-14c1-1d41-0a9e-4fc0f0aa9c36@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9P194CA0008.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:20b:46d::27) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e843fa62-3481-42d7-ea99-08d9e57ffdd0
X-MS-TrafficTypeDiagnostic: AM0PR04MB5282:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB5282E8477E0B2C049F43B3ABB3269@AM0PR04MB5282.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	/IjDEwQExDL6bCF/nZy4eGtqKJDNPTaFcvDwy6f7p/bZVaCnzxfgAhNGmL1jeEjcVr2E3Twq7GvQUylJIcgb9ofJYBrfiu4dC4O8Lpkn6evTH0R5r5Nv7veIURqgydnBDrRFuvAQhIh9jujJOw8FzqYTrttbT39w3FaqWlee/dyVTFW80DJzs0FdCzRDFLpbdBdXXgXsmTC0baei8530Pu1pi4/sLTIXBiFxNw06g/NSYTOrp6BTFGt7TDMqItMHFIv2n8GlccSmJh8+CScTabZF/7br89joj6wTzRRwspndNgjjTcTOZIrPtqOR0U0eq8kdK9MJ3yPk8f77Bn2bOd6NXDSZ1hMfoJfOrTbst47qW7YIcYkm9AIFDqA6tErWewjvuti5Dh0D/REr4NQChRfaNJRxeF72UFsZOSZwdakr3tk0FjdBVUfVrDO1GAAeoXY2HJA//TQiNzuaXvgYnMaiTVY5vQx9itKzU6LtPu62n0KZISPPZ5MgeDLZD0V0p9XIqRGMOAxcEpu8/d4PvWOB5s/FH2RsvzVRm4IgP4IW92/h/aBylfOef/e6L8MR21p1tvQV5KXL6ecn1cAImS6iNRFRdT9qG6Tsl+Tx0p67ieMKSmO5E/LPXkM5irzk1T0bWNn+OC4CEAcNyen+oqURXH4TTyqHBjvBlaFsR3GIPdUgLsaK8fHENUabEpro5/9iVOR9cLQ/TExVb5YC19YGqeunCIArYafTEcoezctmh8JqNph2kpj59T/ycxGi
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6506007)(2616005)(86362001)(31686004)(6916009)(54906003)(26005)(31696002)(36756003)(38100700002)(186003)(316002)(8676002)(66476007)(6512007)(66946007)(6486002)(4326008)(66556008)(2906002)(508600001)(5660300002)(8936002)(53546011)(43740500002)(45980500001)(20210929001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?JNkeWcewM1hQDMlHBd0AYlhLGD5x5cvE/WrWyFRJh4Saov6bRC0+UpY1fATv?=
 =?us-ascii?Q?B6Uo7Rlgbeq3muYfq71LRDUw91ZCJX3cBUFuci851hS+rb6o5gkwTQmTyp4R?=
 =?us-ascii?Q?Yw/+OcC3ztB2MrykjptIouhYPwcdZcZxYB+ULqnOUhnTJ0BnnBoutHr3olW/?=
 =?us-ascii?Q?c/7jKJOnba2FEHhXVKE8rhqL12cpZI8ufd7jhYBfOvKNJtzPM7OnQp6XUYa+?=
 =?us-ascii?Q?uQCMJ6AJVeAMY8JD54q1OXUHR5/V6vu19evvksG3eoA6+WVdZ5blensJ7NgI?=
 =?us-ascii?Q?1OMLEthkVVwj1u8UyDW/k0Ib7WUAkaQ0+5oGtiV/Zl1vMlHA8IpG1VOWJczT?=
 =?us-ascii?Q?GXrg1C8g3VL6jK9zR86mZJWGsv31m97c94aaRsQY47LKXfEETv0qD6GHxYOL?=
 =?us-ascii?Q?xHb3JJ/E3pP3KgE2UFvystgLnDs9OIlpk0PwcxhAi2sYHf82BaovDgofOt9M?=
 =?us-ascii?Q?C2HTpD/u0ojnr36mgifZie5RzRljCGHlygActgyGTV4oD6LNeD10XMuCJiec?=
 =?us-ascii?Q?qG7RE97vFsVoKFBN76ebBVQI/KyIK11FClNNzzxe9adlCE7QP5IQP1CfJWgA?=
 =?us-ascii?Q?c7VmGDa6+lKfgan86WbF6EO605QnJjkdYO5kr5+09+u6Fk19ww8NRyXwtlLA?=
 =?us-ascii?Q?HXSXzeHllPdlJ/fA5ltf5wf7OvJbu+VJqM6QFPcnlcS3c9mHczzoztwe3AgY?=
 =?us-ascii?Q?Xrmp+x4jKd1ATeVws/0z76pn+r/UeJl+ftPDXn40rmjfNcTd6Cljpg7R6MYq?=
 =?us-ascii?Q?v8/sFSloCvattUNSg8FWGzOl31IkSO46cToZrrNV2YONzxBLTIIYvHPutYdV?=
 =?us-ascii?Q?hDqBJrY1wp4juKRtDMjc+CRkO3fSMFlzn8G0XI2WtGIDKmM4WdGZZJaj9rg5?=
 =?us-ascii?Q?I5VB1/RoHIRuLnGxnG6xN/5cRFPqxAfUG0OXBWTCeHRH3Q0DBiKcIfEi6Xcv?=
 =?us-ascii?Q?0rta9y3jDplYjrbnlrd+T6raDzPV8zAm96RpwUNK9PdnRf+qkwgCYmBtFPDi?=
 =?us-ascii?Q?6TJqmobW60Yz6yBGKVON7Baqd264wOgKFRXRrfPW9w+mFhKLm8lYX63HxZet?=
 =?us-ascii?Q?MRf4T6OjNl7qiLw5np7h3xgGcPYCerEgw+JWPnOigoQVrzUaZdKPyRUa6gND?=
 =?us-ascii?Q?mc7TRsiI2IESeKRcCzA8yejw9MxEbJ/2zw4Su7J7WP7++KetuSSrx+abJSCf?=
 =?us-ascii?Q?cVCoOjG8Y1kwio4pnLDrqt2gbow7VxVgpORLhKd269gJ44PghVf9HaUe4UjK?=
 =?us-ascii?Q?o1Zmx1LZVprSAm0Y+ip8NcZJIdGKppXpYH+Ke96gvMASpD0jN+1X+ljvrfRp?=
 =?us-ascii?Q?hCgEOPtudijfr+LDfc0chgnj22hTpswKxG6fSl/yrT5osqEfy93ScaJRWiv2?=
 =?us-ascii?Q?ORY5StPjRpe0NMC2Pzwz6b5ByhQrVQNGpEj9W36iz8zbedSW8kmdrWv2wm5d?=
 =?us-ascii?Q?uTKNhEBTwcIEdPjuwF+0RaacdebHM+BvwlqfC6ixdDrzoKX7y/9MIDTxrMBL?=
 =?us-ascii?Q?mdZo7U6kbX4e8r/URwhHvwySjXUJvZqUXFLiWFdrOgy1douvD6GLeO+MeieJ?=
 =?us-ascii?Q?gYbDZdBYSGfo+nSqi8F5A3H8phUv4AeHz8gnZNAweNxNnVp9WEhLr9b/A4Bo?=
 =?us-ascii?Q?6Z+GVEkn79iPnAqAGJBzLt0=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e843fa62-3481-42d7-ea99-08d9e57ffdd0
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2022 12:40:13.4070
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dXT1onaHD+1MEQBDwRUhPV72On1XnS+eLY/8qY9Ut04gFn0Bl1l6KYUpJu2is9oxp9d+wj9ytD/8ExEmdMTyOQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5282

On 01.02.2022 13:28, Andrew Cooper wrote:
> On 01/02/2022 11:47, Jan Beulich wrote:
>> On 31.01.2022 16:36, Andrew Cooper wrote:
>>> Hardware maintains both host and guest versions of MSR_SPEC_CTRL, but g=
uests
>>> run with the logical OR of both values.  Therefore, in principle we wan=
t to
>>> clear Xen's value before entering the guest.  However, for migration
>>> compatibility,
>> I think you've explained this to me before, but I can't seem to put
>> all of it together already now. Could expand on how a non-zero value
>> behind a guest's back can help with migration compatibility? At the
>> first glance I would be inclined to say only what the guest actually
>> gets to see and use can affect its migration.
>=20
> For VMs which see VIRT_SPEC_CTRL (compatibility with Fam15 thru Zen1),
> writes of VIRT_SPEC_CTRL.SSBD (probably) need to use
> SSBD-behind-the-guest's back.=C2=A0 I say probably, because I think this =
is
> the least bad implementation option, but until we have working support,
> it's still a guess.

So this is future work (and mentioning just this in the description
would be enough to address my comment), but ...

> For the ultra paranoid, a VM migrating in which can't see PSFD (e.g. for
> compatibility with Zen2) should have PSFD set behind it's back.

... this is something we should be doing right away then?

Jan



From xen-devel-bounces@lists.xenproject.org Tue Feb 01 12:42:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 01 Feb 2022 12:42:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.263574.456317 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEsUl-00068z-66; Tue, 01 Feb 2022 12:42:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 263574.456317; Tue, 01 Feb 2022 12:42:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEsUl-00068s-2t; Tue, 01 Feb 2022 12:42:51 +0000
Received: by outflank-mailman (input) for mailman id 263574;
 Tue, 01 Feb 2022 12:42:50 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JAuK=SQ=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nEsUk-00068k-4d
 for xen-devel@lists.xenproject.org; Tue, 01 Feb 2022 12:42:50 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 75122642-835c-11ec-8f75-fffcc8bd4f1a;
 Tue, 01 Feb 2022 13:42:48 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 75122642-835c-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1643719368;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=EKXA/zXgLXV9z0qkxZpEKH8SfDyWGKeMVqnvCkPibeU=;
  b=cHvqjxhi3vJFB398/oYZ6jzP2HMePtu3gpdPGur8Ox8DMMD9C27IKAfA
   L0ur6ZzO3PJbl4d3ZMBt5LGs5WL/ciJezUh9jpsDwGM79lIl/j6cLti7X
   zuIFmsVuSi92dG8tQTriX5mU1AHynk425dHqXFn/MzI98LD1U1Z6oyfMp
   c=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: pjyNzUDOy2I6UTixsbdiVhblYN7hD7YO4Dmi0BOZiPkxgCza4Sp3IrsvOUmdaYZ0sEpy8o/UzK
 zQ5uG9N5W8Cvx6tIe77x1l9DmfND1myRgly3SsZtyon7x7I3b1zNPRYfPx7YXpqR07PONkOaQt
 njacv4P/K3as6CO0IqSlNGsTU8zrZo1t6MBtgSCJ7WTFtczn7LT7TgmDTFzut+Tn16b2+EpAk0
 M/2iM6k60mQBhu+iIKKw4RlwoI0lbe/z8m9uFJouIgicnd3SchrFMx3xzYsZdxFyRJIvFoazv+
 qI6kLGZRP61WK4rPZFcGTP2j
X-SBRS: 5.2
X-MesageID: 63126644
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:6UQOVK5ixP8et4Bz4KrHsAxRtN7AchMFZxGqfqrLsTDasY5as4F+v
 jEcUWmEb/2DNGryKotzbdi2pxsBvZ6ByN5iSVRk+y80Hi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FV8MpBsJ00o5wbZj2tcw2LBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z6
 OhgmKH3GCwTYKjspM4xTSgfSTxXIvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALNs7kMZlZonh95TrYEewnUdbIRKCiCdpwgmxp3J4QQaq2i
 8wxcQpLMzbGPkF0P0YpVrZlpuLyrGvdfGgNwL6SjfVuuDWCpOBr65DyNPLFd9rMQt9a9m6Iq
 2SD82nnDxUyMN2E1SHD4n+qnvXIny7wRMQVDrLQ3vxgjUCXx2cTIAYLTlb9qv684nNSQPoGd
 RZSoHB36/Fvqgr7FbERQiFUvlakgzMxZp0BONdk7SGx4IbK0kHDG0EbG2sphMMdiOc6Qjkj1
 1msltzvBCByvLD9dU9x5ot4vhvpZ3FLcDZqiTssCFJcvoK9+N1bYgfnE447eJNZmOEZDt0ZL
 9qiiCElz4segscQv0lQ1QCW2mn8znQlo+Nc2+k2Yo5Hxl4jDGJGT9bxgbQ+0RqmBNzDJrVml
 CNc8/VyFMhUUfmweNWlGY3h5o2B6fefKyH7ilVyBZQn/DnF0yf9IdsNsG4mdBk4bpdsldrVj
 Kn741k5CHh7ZyPCUEOKS9jpV5RCIVbISLwJqcw4nvIRO8MsJWdrDQllZFKK3nCFraTfufpXB
 HtvSu71VSxyIf0+lFKeHr5BuZd2mHxW7T6NFPjTkkT2uZLDNSX9YepUbzOzghURsfnsTPP9q
 YgPbqNnCnx3DYXDX8Ug2dVCcAlXfSVnXs2eRg4+XrfrHzeK0VoJUpf56bggZ5Zkj+JSkOLJ9
 Wu6QUhW1Bz0gnivFOlAQikLhGrHUcktoHQlEzYrOFr0iXEvbZz2tPUUdoctfKlh/+tmlKYmQ
 /4AcsSGI/JOVjWYpGhNMcij9NRvJEaxmAaDHyu5ezxjLZRucBPEp43/dQz1+ShQUifu7Zkio
 6et3x/wSIYYQ1gwF97fbf+ilgvjvXUUlO9ocVHPJ91fJBfl/IRwcnSjhf4rOcAcbx7Ew2LCh
 QqRBB4Zo8jLopM0r4aV1fzV8d/xHrInTERAHmTd4bKnDgXg/zKukd1aTeKFXTHBT2eoqq+sU
 vpYkqPnO/odkVcU74clS+R3zbgz7sfErqNBylg2B23CalmmB+8yInSC2sUT5KRByqUA5FmzU
 0OLvNJbJa+IKIXuF1tIfFgpaeGK1Pc1nDjO7KtqfBWmtXEvpLfXA19POxSsiTBGKOonOYwo9
 u4tpcoK5lHtkREtKNuH0nhZ+mnkwqbsiEn7WkX22LPWtzc=
IronPort-HdrOrdr: A9a23:4uotnqp7xJFXkEP/JsLnJuIaV5uzL9V00zEX/kB9WHVpm5Oj+P
 xGzc526farslsssREb+OxpOMG7MBThHLpOkPMs1NCZLXTbUQqTXfpfBO7ZrQEIdBeOlNK1uZ
 0QFpSWTeeAcWSS7vyKkTVQcexQueVvmZrA7Yy1rwYPcegpUdAZ0+4QMHfkLqQcfnghOXNWLu
 v52iIRzADQBkj/I/7LTUUtbqzmnZnmhZjmaRkJC1oO7xSPtyqh7PrfHwKD1hkTfjtTyfN6mF
 K13jDR1+GGibWW2xXc32jc49B/n8bg8MJKAIiphtIOIjvhpw60bMBKWqGEvhoyvOazgWxa2u
 XkklMFBYBe+nnRdma6rV/E3BTh6i8n7zvYxVqRkRLY0LrEbQN/L/AEqZNScxPf5UZllsp7yr
 h302WQsIcSJQ/cnQzmjuK4GS1Cpw6Rmz4PgOQTh3tQXc81c7lKt7ES+0tTDdMpAD/60oY6C+
 NjZfusq8q+SWnqL0wxg1Mfg+BFBh8Ib1W7qwk5y4CoOgFt7TFEJxBy/r1bop8CnKhNPKWsqd
 60dpiAr4s+PfP+W5gNcNvpcfHHelAlfii8Ql56AW6XXZ3vaEi946Ie3t0OlZSXkdozvdwPpK
 g=
X-IronPort-AV: E=Sophos;i="5.88,333,1635220800"; 
   d="scan'208";a="63126644"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=V+r6wUL3KqI4GWB919uZrSodm+now+L9U8G/hwoDnY/PPVfE/T8G+8DFxQ2bcUQGVMvS5f3oy3FpNTdAX8JxutMR2iJURmBPRovIB3lK12sjyvFu57UEi5Dr5CbgN7BX+jqB4ILz/REMFkrHChIGufZrz1tPd9mJsPSSAL+f9lDP93Vn56w1/t2+STdzDuevyNBskgJ+qhPQmGkucsAnQTnF3jXUcFNjuKpgbbYnv1WKkduZgDaax+CmZ/ShcuWPSJ2L+09S4z39LAivAUsrfOcRyix2gdzzBFwHrsNCTAx12tMVbtiESqlOmaFi94t0u2axa3pVf6m1svK8+e7C9A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=MveKamJP1IIkhybTRw7omUmM7WLAurbY3BVisEryNS4=;
 b=CW4xmc6SbE62UJJ+rf0eZLhWjuvdaKwq1JO6blB5qtlJQaN6Etb3+x8SK5V4ekeAckte3tW6unrhmHJ9z8nIxTiSVTFghaMOshsWvddDjT4l9dWrGAZdAr0ANvVXcuelpcMeivdY5RsJVFYOPJ7NKQxRPS2DUz0iDU6V3AJvI3bARyiVT2/BzNLirLKOZR1OW1BdJqSFjtlHRr4s5B/iSqPiHOXxz5mi95QCaVFvMlBizxV1pIILADlEBYkFFgkmZQ87wVaIV2qc6Y8/K+wKb6g65YDXnr7rJtDAcji0REUj/2KtJxaYcG0EI9fEoKA7IXd8n67wNpMescJgjSKvng==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=MveKamJP1IIkhybTRw7omUmM7WLAurbY3BVisEryNS4=;
 b=Ndv0IW8ohzX/JC17C3PZJxcsueTDAXIg5yS9012xbaoJWGsCAmyPXBOHkT3LozcTG6DczH5FgqpSmFSfb2xDTmB45lMGGhPxYeasUXFjEBOztVMWFM9X4P+hKRuq9Doug2TSiLRUX/J8HHbg0Utb7/PF0UBYNZTkF8P3Tlhcm7k=
Date: Tue, 1 Feb 2022 13:42:37 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v3 2/2] x86/mwait-idle: squash stats update when not
 actually entering C-state
Message-ID: <YfkqvddlvAELr0ng@Air-de-Roger>
References: <faff6a1e-9f00-e924-9766-deda8f0b38c1@suse.com>
 <6a9152e5-1a7d-c569-3483-66f022027597@suse.com>
 <YfkTt1k4XLnZtaJj@Air-de-Roger>
 <2c6129b8-87ed-a3fa-f819-6318909bf2e1@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <2c6129b8-87ed-a3fa-f819-6318909bf2e1@suse.com>
X-ClientProxiedBy: LO2P265CA0474.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:a2::30) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4dda22cf-0f95-4754-f9d4-08d9e580573d
X-MS-TrafficTypeDiagnostic: SA0PR03MB5467:EE_
X-Microsoft-Antispam-PRVS: <SA0PR03MB54675F7017A656B269B548E28F269@SA0PR03MB5467.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 2BkRFonu3VAf4JlFWW2ETenSi949Aq00FUayvIJUVqsM0c8aDB/0TcerF0iBo0CjFUkzuy2tVd7OIrlSxW/2rhT3yDlAbcjFO0UZN1IkleQMFsNBfyaIoPQ5cl3RCyYBf34qiS8xW8q3bbO2vIK2YVGJnvrBc+j3ooAJc0NNfCISj7ppApaajIGua1xitbOOGzaDU3kjrNtOVJXjnhNuJ0yxFaWswkslNkDYdIrMIXN71KmC7hxm51WSTXE1U3STEY9zpbvWSMPXk4BLu/ADo3hzh9C9+zkQKlwWU11Axc5IUAU6pK0MJ6o7GTtYobgpeMdkqNPC/HG0fpuWq3ic7jvefGXw6MBLihGBM5DOrGYASuyR8DDeIeJS+eL3w7sVqvFPb5aDDAe5ivcmDZC38r6NVeAQJrDkamIORT/it+LI88TIRGDbkprVTYBX2y4o/xqg7grjBkB+wo3uZ7QWO+DWbJ4euTly1fVxU11bMMCDWu3gCylehVhV6Pqo7JTuB1Ay18tMYitn/sJSC3j7ybncqRIUM0euXaXl8CblKIHGIWrF5jra3y3sZHbt9fip7icAp5e0cTgOdJzJP3otPZrkGyUbv7FErGTXY9uAQ+va5CMVaG4dqSh2aTVTSrGsIQ3aqdQ3vz/anniZ/KOknQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(15650500001)(2906002)(5660300002)(6916009)(54906003)(33716001)(6486002)(6666004)(316002)(8936002)(38100700002)(66476007)(26005)(82960400001)(186003)(86362001)(53546011)(6512007)(9686003)(4326008)(6506007)(508600001)(66946007)(83380400001)(66556008)(85182001)(8676002)(20210929001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K01jay9HcmtmaWV3S0dUZTlVTU1sS0pjV1pZOFM3Yk9FZ1VZYlcwNWFxb1U5?=
 =?utf-8?B?UDIrNDJvR0IwT1V6U1U2OXpnUzQ4b2Z2TlZZSWpWazh3SUJxUlRBdVRQMWxp?=
 =?utf-8?B?NmVHSWRVZWdiSnNRRWNzb1EyUkxEdDlxcnFiQnpiM2cxWE9EM2dtU0RGNGV4?=
 =?utf-8?B?bUZtajMvMVBjTW9ZSlUrQ3JvbmxmRHJtRFI1UEI4VnZKL3lzTXhEZmdFUC9Q?=
 =?utf-8?B?b0hLNWhZV0pacVlKa3FlaGl5R2NvK0JQNWdqU2NqTUtyT1dwOVZGTVRNVnZH?=
 =?utf-8?B?ekQ3cE0xQUhmMnlCQ3l2cXZGV3dxb09nekhIMHdoOUZRM25lVU9MNlh2S3hw?=
 =?utf-8?B?YUZXRzM5ekhEMEVpSVl4VEMzZ3ZYa0dKK2FCc25DbTVXTnpyMGZLR0JtSmhN?=
 =?utf-8?B?cVkvMnhEY1phTW5wYzVwR3FHOVN2TUE4TFVxQk4xRUlRTnJwbEl6VVViYjRy?=
 =?utf-8?B?cHA0WGd1SXhqSmhJcUN4TmViS2tyUnRtUG4yZmt4QkxoWVlDcnNWZTFNdEts?=
 =?utf-8?B?bDBCdEhSNjk0b2V1eGZoblMxemdTamF3MU5MaG51NVNMZWh6UlVrMkdIdzRU?=
 =?utf-8?B?b240bkJuYUdlN29QZVFUbTJ6MXl4NGhkZWVRcFZPellkZnRVeHMwT0ttcW5H?=
 =?utf-8?B?TnhNcFRJL2tyN0k4RjM5MUZ3TW41VzZxWitwWUtwNTFqRFRnN0NHZ29qWm5G?=
 =?utf-8?B?TEJZZ09IcUlTUDk2eW1qcDkycmVYenlMS0hpcGRUMndMNFMxMHdnZ0JYMDFC?=
 =?utf-8?B?MEtmM1Nta0hRODhuNUZ3L09JMnU1SElvWTNIeUJiVkVSRnp2Uy9paTNiZW9P?=
 =?utf-8?B?cUw1Z3dpSS9OVHYzMlJQNUNIMVJPeU0rRmV2SHBwaXo0Qm5VQzBiSTFIOGFn?=
 =?utf-8?B?eUZ4aFZWRnl3WHhvZmRyV3Q3WmpJVjdkL21QanpPOVRuVzN2dXUvRnBYcUMy?=
 =?utf-8?B?VWdsYkExVVVFZVVsVXp6cjZtQjRRa2FRZTVMNEp5WmdxTmhzZFhrK09nSHpQ?=
 =?utf-8?B?YzB2YnhJT1JWSHBBU0NrRDltSGZlcElJTGhSUndFa3FIaE9zanBQVVp3TW5o?=
 =?utf-8?B?YkIxVTFiTXlTdURzVFczM0NEekJ2bUE2alZkcVV5dlNtTFhIVnFRKys4MXNJ?=
 =?utf-8?B?MmUzUUM3M01pNnVNdUU5L0NlalVFTDBnRURGRXZWRzZLSXJxS2RHL0xmL0lJ?=
 =?utf-8?B?QXpiMXRkUFRHNnlOTno0NjduenNOWVNNK2JNa1BYQlpDdFBFMWFocm9TNEdr?=
 =?utf-8?B?Z3pya3pJcFFFVzBtckY2TjlFRlpjMHNja3JvejJ0ZW9jMWxqc2RCb0picVJ2?=
 =?utf-8?B?L1JwbGUwN1NJa050OXZHTXcxTWNFRkUwMlBsY3lHL2Rmd3hTYm5KdDR2aFFR?=
 =?utf-8?B?R242ZnVNWm15cldxM3A2aTFTS09ZOFJMTnZnMjBJRHhsUGR4ZVk0UGxFWXRQ?=
 =?utf-8?B?U1hEZ2lqY3pEM3JYQ0s3NWlWbHMzWVBLSFJSUEhLWFRFVHlhZDRVVjlNNXVK?=
 =?utf-8?B?Z1NZR1B0TXNNNDNETllYQjNWaktFSjlsU3puV2ZYVStoU1JXSWEvMk4yc1JR?=
 =?utf-8?B?Ry9hN3FPcHVQTWlOQlRLd3NQYVZrSzM1YWtvbURJQzBkQklHNmJYWkpYVjgw?=
 =?utf-8?B?cTZORjJIejZKUGJRTHRsSVNsME13ZkYvTmVQN21RZXBNbkk1Z3ROcnlkQ1dr?=
 =?utf-8?B?cldHZ0ErUDlTSkNzQVYzemNGaTUvVG1KOFdHUjh1enkrelBjSDFacENKM1Iv?=
 =?utf-8?B?bGZYYTY4TTNLN3puOTdPYmZNZXJVQTEvVW5Rd3dWRHlGRys2Z3N5NzhEQ002?=
 =?utf-8?B?L1ZSM0VRR3hUTHl2NjZYbUNXa1N3Mm5ybFJSWHA3QjFucVdYZUthVzhORENr?=
 =?utf-8?B?dXc3RTRwTzg4bEx4U29JcVBGNnpic1g3MGlRSkQ3QVBNTHdhZFpKNjNrMVFu?=
 =?utf-8?B?YUh4YUZiNDdaVHlQelhuQjBuWjQyVFcweVNDbjB6d2g0cEN3eHdienpQTmx0?=
 =?utf-8?B?VHZOSDJUOE1YOUxvVXp4ZTFzay9WalBkUFVkNHFZejJmYXJjZ1pwWTMyWDVH?=
 =?utf-8?B?bDBEZzhZbWFtaXdXVlFVY3NDcFhGK0F2T1ZYNUp3RHc4TTVuV0NOTnZaZllC?=
 =?utf-8?B?WnZ4Y3BUT3RXcXpHQldnVUdLUndNcUUyeTJCTG4ySkVXbUJnMFV5aytDTmJW?=
 =?utf-8?Q?E14g7uDm6JTgwkSbVnYHMk8=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4dda22cf-0f95-4754-f9d4-08d9e580573d
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2022 12:42:43.3139
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lisoYtclH9KlK6Jy6XlYAUlxBexIlzJ4fsJuKWnm2Me7IKws63pkRR7HmSjwa102DMdWzk39TXJLAmvGR1d9+Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR03MB5467
X-OriginatorOrg: citrix.com

On Tue, Feb 01, 2022 at 12:37:27PM +0100, Jan Beulich wrote:
> On 01.02.2022 12:04, Roger Pau Monné wrote:
> > On Thu, Jan 27, 2022 at 04:13:47PM +0100, Jan Beulich wrote:
> >> While we don't want to skip calling update_idle_stats(), arrange for it
> >> to not increment the overall time spent in the state we didn't really
> >> enter.
> >>
> >> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> >> ---
> >> RFC: If we wanted to also move the tracing, then I think the part ahead
> >>      of the if() also would need moving. At that point we could as well
> >>      move update_last_cx_stat(), too, which afaict would allow skipping
> >>      update_idle_stats() on the "else" path (which therefore would go
> >>      away). Yet then, with the setting of power->safe_state moved up a
> >>      little (which imo it should have been anyway) the two
> >>      cpu_is_haltable() invocations would only have the lapic_timer_off()
> >>      invocation left in between. This would then seem to call for simply
> >>      ditching the 2nd one - acpi-idle also doesn't have a 2nd instance.
> > 
> > It's possible for lapic_timer_off to take a non-trivial amount of time
> > when virtualized, but it's likely we won't be using mwait in that
> > case, so not sure it matter much to have the two cpu_is_haltable calls
> > if there's just a lapic_timer_off between them.
> > 
> >> TBD: For the tracing I wonder if that really needs to come ahead of the
> >>      local_irq_enable(). Maybe trace_exit_reason() needs to, but quite
> >>      certainly TRACE_6D() doesn't.
> > 
> > Would be good if it could be moved after the local_irq_enable call, as
> > it's not as trivial as I've expected, and will just add latency to any
> > pending interrupt waiting to be serviced. FWIW, I haven't spotted a
> > need to call it with interrupt disabled.
> 
> Okay, I guess I'll to the larger rework then.
> 
> >> --- a/xen/arch/x86/cpu/mwait-idle.c
> >> +++ b/xen/arch/x86/cpu/mwait-idle.c
> >> @@ -854,17 +854,23 @@ static void mwait_idle(void)
> >>  		mwait_idle_with_hints(cx->address, MWAIT_ECX_INTERRUPT_BREAK);
> >>  
> >>  		local_irq_disable();
> >> -	}
> >>  
> >> -	after = alternative_call(cpuidle_get_tick);
> >> +		after = alternative_call(cpuidle_get_tick);
> >> +
> >> +		cstate_restore_tsc();
> >> +
> >> +		/* Now back in C0. */
> >> +		update_idle_stats(power, cx, before, after);
> >> +	} else {
> >> +		/* Never left C0. */
> >> +		after = alternative_call(cpuidle_get_tick);
> >> +		update_idle_stats(power, cx, after, after);
> > 
> > While adjusting this, could you also modify update_idle_stats to avoid
> > increasing cx->usage if before == after (or !sleep_ticks). I don't
> > think it's fine to increase the state counter if we never actually
> > entered it.
> 
> I did consider it but then decided against. Even leaving this aspect
> aside the counter only counts _attempts_ to enter a certain state;
> the CPU may find reasons to never actually enter it. And what we have
> when before == after is still an attempt, albeit an unsuccessful one.

Right, in which case:

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

Not sure whether you would like to commit this now and do the lager
rework as a followup patch. That would be fine by me.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Feb 01 12:45:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 01 Feb 2022 12:45:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.263583.456328 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEsXc-0006og-PV; Tue, 01 Feb 2022 12:45:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 263583.456328; Tue, 01 Feb 2022 12:45:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEsXc-0006oZ-M0; Tue, 01 Feb 2022 12:45:48 +0000
Received: by outflank-mailman (input) for mailman id 263583;
 Tue, 01 Feb 2022 12:45:47 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=0oSv=SQ=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nEsXb-0006oT-2c
 for xen-devel@lists.xenproject.org; Tue, 01 Feb 2022 12:45:47 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id dfe21553-835c-11ec-8eb8-a37418f5ba1a;
 Tue, 01 Feb 2022 13:45:46 +0100 (CET)
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur01lp2056.outbound.protection.outlook.com [104.47.0.56]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-33-ly0RBg74OzS2w5TFB3Cq_w-1; Tue, 01 Feb 2022 13:45:43 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM0PR04MB5282.eurprd04.prod.outlook.com (2603:10a6:208:d0::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.22; Tue, 1 Feb
 2022 12:45:42 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::7cc2:78a3:4d40:9d45]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::7cc2:78a3:4d40:9d45%6]) with mapi id 15.20.4930.022; Tue, 1 Feb 2022
 12:45:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dfe21553-835c-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1643719545;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=VgCSJWhP5AbkvFJXUdUqd4BGuTf70dTzqNd8fgF6Kzc=;
	b=IyupGeH2C8ZtJMWz3vJ6aHGv/p0ZZHLM6BgEaw1dKt9bcqqkQEU4kEUqPVdXToTxT5d0da
	hmAFdWGHkKgooIPM4AQWSSGOHbYo0l5IrFStSMelTbWlLk96xciwsXidzldNH3J5aC76XM
	fQcnpV3TqaQ5S4a4wThJtQKqkOd7R30=
X-MC-Unique: ly0RBg74OzS2w5TFB3Cq_w-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=n8IIROI257uPdoo9B39Zot2v3If09AZSKZILx2PTOAKpwS7mvXh7ZYd/OTW0dB6iVYjWvuu4RcBsjFVXaPTUkgLHslTYaCgtWKU43OrdxIYj63pZa2j98dIDwdAOp4BoaCsbbi/KKH4vu7bMs4s1kiLcMTBWp0Aq4dsiSRBz3/Mst0e2Gf8awm93Eh9/6MOwr8uJldIKYtfAoaWBt2pWmk4v7LY8YYRd5qVAVNALtW+XZH3bPRhXj0ro+TsUvTaGeZazfLMKmu7FWDqk64BMfUmE3uOEYUc53hiGNWLG9xd0ArZhAYNmY2prlvoHwNMuBekOU7xl8TQMUQQOKPpXCg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=lzWQu8Yey2mGbU6hFumi3h2Cej8BlfX6CCzHEdk10pA=;
 b=LiNtpV8JMoeoVeBXZL5cDTGQHuEtfGRW0gAWlwlYeFPKqEm9HyZEyH6t0+CegA6OsIIdUWTZal33j3elt0uIOf/d/ZOzrtPtUcjs3bWkYPKN1RAm+TCpnn+7uSlPOVDatfb/XrAAGc8CsodlFLYdafDWB+yFdBZuCFTXmDyfWkS6FvFXx+PoQiDbGVkX6a3Emkw9KL6XuJQj3wgpZawokqlkLPFITv9kaY+BC65yTA9OS+UFY/kov6Jeba9uHBIgtHi4LXTDMhDXY2eTTVAQKTD2o5K5WH0llPRTndsIUROgw1wHDq2WyGcBYl6pd86hW1NpRKIeYJvBAKXr9VpDzA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <482fa978-d5d2-a069-ecdd-23a212bae57e@suse.com>
Date: Tue, 1 Feb 2022 13:45:40 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v3 2/2] x86/mwait-idle: squash stats update when not
 actually entering C-state
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
References: <faff6a1e-9f00-e924-9766-deda8f0b38c1@suse.com>
 <6a9152e5-1a7d-c569-3483-66f022027597@suse.com>
 <YfkTt1k4XLnZtaJj@Air-de-Roger>
 <2c6129b8-87ed-a3fa-f819-6318909bf2e1@suse.com>
 <YfkqvddlvAELr0ng@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YfkqvddlvAELr0ng@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM5P194CA0020.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:203:8f::30) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: feb505f1-8d6d-4b3a-5c59-08d9e580c1cf
X-MS-TrafficTypeDiagnostic: AM0PR04MB5282:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB52826343241EAA85FFF72383B3269@AM0PR04MB5282.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	bNIvzYCGDOckeaD6lFzuIU6h3pTwL6p/0kbCs8NzDIra4hfAuOHYFRx2PMy+smNkgTJW5u18ha9Hscaq2okH04FPyhE1BN02k9p4oMb+5PM2TzaqQU71qQMt0dSFLAjzOJih0m4LlMKXYPohKbAbnfOWtnrHNkgNPGquRxJCbFkQMELV1PMAiU2WuRlUdZVEmj9D/fShn/Jf8T9v8/n6rwAIFz1aEsVZHXe1SaO/0JclXUgBE7+9i/N8eMSNha9n6Thf14VYANINpMRLq/GboAJEqRFBx6iuaHpFOIJS/T3bAdTpUHsAYP4kbaUvLsuvLdmaOGe8jb4fmPytacpHaNs88vGIjV185YEbIqkgJgIpFCd+WhPXN0WbRcLXnk9zQl88CusW2ZKydcDfHaC43hq+U2SErpPX/UQ+pBzqT2vz0hTEbjej2GkNc48h9Qj8eB6wwmkAwLm4fzodJSmdzF1F0VKsTsYEiob260dH1FzQwpZ6wurxuphxg5wFLrjMeItnwOmgUEIfE/R+i9VH2HSE2RV1tMK95aIW2wUMmQKZZICu1NHoLT1svwKw0ABvvG26gfGTmcJsdiw7gAfjjEAWtVvamCcKt/quF20PFp2XDgUSijvmIE3DgJzjequrbjCfts5pF499l8chaFQ85ep1OUXiRhxi+5U3E2I1QxgmspVSzkaFpuCt138J3c3t1odWW02Hui3yCm+kggjU3JLwI4RoNv6GWNxeRHiU9MVAzMv1jXQeS5o9OyOAAppn
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6506007)(2616005)(86362001)(31686004)(6916009)(54906003)(26005)(31696002)(36756003)(38100700002)(186003)(316002)(8676002)(66476007)(83380400001)(6512007)(66946007)(6486002)(4326008)(66556008)(2906002)(508600001)(5660300002)(8936002)(15650500001)(53546011)(43740500002)(45980500001)(20210929001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?anmngWsknCRnE8KUyZ2a255g35IFiXicAM5smlLkq/XJNdso+MsYfFydi5P+?=
 =?us-ascii?Q?TNdJfrEnbwCpyAaNHxkrnopt9MeG5slYfmCqUkvqvs6TG6BZvDhN/Rl/aiqq?=
 =?us-ascii?Q?pQkxRYmP/FvhSStcxh3LPZuVrPLQYcimia2knhdtUcfTYGi1Ix6jk+cyiDdj?=
 =?us-ascii?Q?hIVX2YSG4qxD/Up/IbY8Tg0vRy9Gh674HUtBZXJnTBO6XQvccPrN36m9Dz0f?=
 =?us-ascii?Q?UUhx8nhwE30hTE5B4DFNC+mA5iKSM8SB50qQ/7tCy56c7cOlHUfk3Ed7PyKY?=
 =?us-ascii?Q?U64vbnzHU8DOOhKINHy/mrsxCDYLtSyO+1sfKackxvZjdowRKUZA3AgYrBz+?=
 =?us-ascii?Q?98L3QZ9SQeUkanHfyEqjY7QuP63/pgpkyoikTPo/6xx/PYa2Nz0MiEKprSJB?=
 =?us-ascii?Q?Qliy+b3IBmDJit+nOH5X+y0jZspA5DG+FG23kwCqqDGWF5YeTV3bAHpUADh5?=
 =?us-ascii?Q?i4sDeb+wP9WQuH+0HektD2MKrD2LQ5qVmQacDZakAzrbD9BmlVpyFqwYLsWS?=
 =?us-ascii?Q?RPLi/cCg4vxUR5ESEsAsPkdA/2VcsrYYVJYLrKQA53KStuPjuUBgHo+Gr82Y?=
 =?us-ascii?Q?AL9j3ZZYZiUVfm9PNTNsoXVlsYOHSVDnv403A1+JvFPwK3Fms2xHd5DAwk25?=
 =?us-ascii?Q?zktDyYIkkmazMCuJUJph38wkSP6ONYOaz8HIJc/0rc93drG7LIOY7+2sOBxY?=
 =?us-ascii?Q?7izP9QqL+MZKLBlRyrlMYMVbfyDqicqlWfNX5ArmhBSduLiZOBQCtCZFzOIs?=
 =?us-ascii?Q?pDf/8utBQJcaLetK9SlkVbVvYKOL+gNa1lCik8aG3OGIDhvQCPh6aFBVyukg?=
 =?us-ascii?Q?bHtnW8VlKEdNo+zQPLC7RuC7sAbFAl1UBeCkRa+6qiLDWqV+Eqw2ohUN2POf?=
 =?us-ascii?Q?a30l9SXRgVaUAir4xkgJw0yTLDyGO5ocFYz3fOt0oWeCDM/gsI0dnswWr1qs?=
 =?us-ascii?Q?sTX2o9qsMyQqui4IS1eMKpYAZq6TzpbnRoEtWhJU+J1GLj/sLOT9GIuV0lSS?=
 =?us-ascii?Q?P1jW83mydOmxxxh9bG4zlzeg/t1LqgUwC7jukMWg+sj2cfNBBnuuN6SPwPHL?=
 =?us-ascii?Q?1+XQVf3ePItvByWDpKeYC/y5Tsnk7SRkOuoHm3HkJINFCCj8CyFKN0AlHRZ8?=
 =?us-ascii?Q?oFLvG1WZz7OzsTk7VU5+sIMew9tjg+WuRYLynb6+bX99KNQCkMR78w60BwXg?=
 =?us-ascii?Q?Kqa0FJvEYWAq8Q2G1j3oUDiTLcJRgXIvi+NvsQjEIxfGprgBNMsOHl2k6/fg?=
 =?us-ascii?Q?WXuaSAkRfrBeaz+eOSYAwIp5pVf+8xszkhIntQczcj8ABwuoF6VOODbB9D8M?=
 =?us-ascii?Q?IDyRJx2l8sjN+pydi4fQUIrhcN+nJ9ssh+A0svKONg528e9FWoybNlil8ZpM?=
 =?us-ascii?Q?84hrrmT/jQJpGCkoMRbgKRWbRtRIc0vLr//kZbFEZxIw+MZ4yeT+WUlvgPtd?=
 =?us-ascii?Q?CK5yNH1TiJlUzHTt6IGc1qX9+gvkSkVpuTPQsvRYmkrkrMyDaUQSv9tWZiFx?=
 =?us-ascii?Q?N8JWTaC4APRBL3GsebT6/3Dyq4KNhoeQPh/+/CClQkxoI/SosXjjGJXnl2O/?=
 =?us-ascii?Q?EOys47/vT2XTOX9w8Bog58ACcAsACtoM422N4wfirDnweLvRXeD0J26Hl/Jg?=
 =?us-ascii?Q?+uMpbl1jPnfKGVr6VOsRPY0=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: feb505f1-8d6d-4b3a-5c59-08d9e580c1cf
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2022 12:45:42.0740
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: azTkfmoKFWwukpduvzUcRpZRFhDKAmhG2Tx6LUviOhZHTvZOLlnzc9NahQmwgiYarp2i84pqerLOQKv4C6kfzg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5282

On 01.02.2022 13:42, Roger Pau Monn=C3=A9 wrote:
> On Tue, Feb 01, 2022 at 12:37:27PM +0100, Jan Beulich wrote:
>> On 01.02.2022 12:04, Roger Pau Monn=C3=A9 wrote:
>>> On Thu, Jan 27, 2022 at 04:13:47PM +0100, Jan Beulich wrote:
>>>> While we don't want to skip calling update_idle_stats(), arrange for i=
t
>>>> to not increment the overall time spent in the state we didn't really
>>>> enter.
>>>>
>>>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>>>> ---
>>>> RFC: If we wanted to also move the tracing, then I think the part ahea=
d
>>>>      of the if() also would need moving. At that point we could as wel=
l
>>>>      move update_last_cx_stat(), too, which afaict would allow skippin=
g
>>>>      update_idle_stats() on the "else" path (which therefore would go
>>>>      away). Yet then, with the setting of power->safe_state moved up a
>>>>      little (which imo it should have been anyway) the two
>>>>      cpu_is_haltable() invocations would only have the lapic_timer_off=
()
>>>>      invocation left in between. This would then seem to call for simp=
ly
>>>>      ditching the 2nd one - acpi-idle also doesn't have a 2nd instance=
.
>>>
>>> It's possible for lapic_timer_off to take a non-trivial amount of time
>>> when virtualized, but it's likely we won't be using mwait in that
>>> case, so not sure it matter much to have the two cpu_is_haltable calls
>>> if there's just a lapic_timer_off between them.
>>>
>>>> TBD: For the tracing I wonder if that really needs to come ahead of th=
e
>>>>      local_irq_enable(). Maybe trace_exit_reason() needs to, but quite
>>>>      certainly TRACE_6D() doesn't.
>>>
>>> Would be good if it could be moved after the local_irq_enable call, as
>>> it's not as trivial as I've expected, and will just add latency to any
>>> pending interrupt waiting to be serviced. FWIW, I haven't spotted a
>>> need to call it with interrupt disabled.
>>
>> Okay, I guess I'll to the larger rework then.
>>
>>>> --- a/xen/arch/x86/cpu/mwait-idle.c
>>>> +++ b/xen/arch/x86/cpu/mwait-idle.c
>>>> @@ -854,17 +854,23 @@ static void mwait_idle(void)
>>>>  		mwait_idle_with_hints(cx->address, MWAIT_ECX_INTERRUPT_BREAK);
>>>> =20
>>>>  		local_irq_disable();
>>>> -	}
>>>> =20
>>>> -	after =3D alternative_call(cpuidle_get_tick);
>>>> +		after =3D alternative_call(cpuidle_get_tick);
>>>> +
>>>> +		cstate_restore_tsc();
>>>> +
>>>> +		/* Now back in C0. */
>>>> +		update_idle_stats(power, cx, before, after);
>>>> +	} else {
>>>> +		/* Never left C0. */
>>>> +		after =3D alternative_call(cpuidle_get_tick);
>>>> +		update_idle_stats(power, cx, after, after);
>>>
>>> While adjusting this, could you also modify update_idle_stats to avoid
>>> increasing cx->usage if before =3D=3D after (or !sleep_ticks). I don't
>>> think it's fine to increase the state counter if we never actually
>>> entered it.
>>
>> I did consider it but then decided against. Even leaving this aspect
>> aside the counter only counts _attempts_ to enter a certain state;
>> the CPU may find reasons to never actually enter it. And what we have
>> when before =3D=3D after is still an attempt, albeit an unsuccessful one=
.
>=20
> Right, in which case:
>=20
> Acked-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>

Thanks, but ...

> Not sure whether you would like to commit this now and do the lager
> rework as a followup patch. That would be fine by me.

... no, I'd rather do this in a single step. In its current shape the
patch is actually moving us in the opposite direction.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Feb 01 12:46:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 01 Feb 2022 12:46:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.263588.456339 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEsYR-0007MA-4Z; Tue, 01 Feb 2022 12:46:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 263588.456339; Tue, 01 Feb 2022 12:46:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEsYR-0007M3-1A; Tue, 01 Feb 2022 12:46:39 +0000
Received: by outflank-mailman (input) for mailman id 263588;
 Tue, 01 Feb 2022 12:46:38 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=+T3c=SQ=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1nEsYQ-0006oT-OF
 for xen-devel@lists.xenproject.org; Tue, 01 Feb 2022 12:46:38 +0000
Received: from ppsw-43.csi.cam.ac.uk (ppsw-43.csi.cam.ac.uk [131.111.8.143])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id fdf73758-835c-11ec-8eb8-a37418f5ba1a;
 Tue, 01 Feb 2022 13:46:37 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:55342)
 by ppsw-43.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.139]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1nEsYO-000rPq-mX (Exim 4.95) (return-path <amc96@srcf.net>);
 Tue, 01 Feb 2022 12:46:36 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id C7F731FA79;
 Tue,  1 Feb 2022 12:46:35 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fdf73758-835c-11ec-8eb8-a37418f5ba1a
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <012e4f44-aa1a-6bce-3d4c-21f234bc3fee@srcf.net>
Date: Tue, 1 Feb 2022 12:46:35 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.1
Subject: Re: [PATCH v3 7/9] x86/svm: VMEntry/Exit logic for MSR_SPEC_CTRL
Content-Language: en-GB
To: Jan Beulich <jbeulich@suse.com>, Andrew Cooper <Andrew.Cooper3@citrix.com>
Cc: Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20220128132927.14997-8-andrew.cooper3@citrix.com>
 <20220131153621.8863-1-andrew.cooper3@citrix.com>
 <00aa1f8a-9f2a-96f1-b088-e34c9ec76f3c@suse.com>
 <e48536c0-14c1-1d41-0a9e-4fc0f0aa9c36@citrix.com>
 <52587ee4-56a3-3824-75cd-667c35e3109f@suse.com>
From: Andrew Cooper <amc96@srcf.net>
In-Reply-To: <52587ee4-56a3-3824-75cd-667c35e3109f@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 01/02/2022 12:40, Jan Beulich wrote:
> On 01.02.2022 13:28, Andrew Cooper wrote:
>> On 01/02/2022 11:47, Jan Beulich wrote:
>>> On 31.01.2022 16:36, Andrew Cooper wrote:
>>>> Hardware maintains both host and guest versions of MSR_SPEC_CTRL, but guests
>>>> run with the logical OR of both values.  Therefore, in principle we want to
>>>> clear Xen's value before entering the guest.  However, for migration
>>>> compatibility,
>>> I think you've explained this to me before, but I can't seem to put
>>> all of it together already now. Could expand on how a non-zero value
>>> behind a guest's back can help with migration compatibility? At the
>>> first glance I would be inclined to say only what the guest actually
>>> gets to see and use can affect its migration.
>> For VMs which see VIRT_SPEC_CTRL (compatibility with Fam15 thru Zen1),
>> writes of VIRT_SPEC_CTRL.SSBD (probably) need to use
>> SSBD-behind-the-guest's back.  I say probably, because I think this is
>> the least bad implementation option, but until we have working support,
>> it's still a guess.
> So this is future work (and mentioning just this in the description
> would be enough to address my comment)

Near future, but yes.

> , but ...
>
>> For the ultra paranoid, a VM migrating in which can't see PSFD (e.g. for
>> compatibility with Zen2) should have PSFD set behind it's back.
> ... this is something we should be doing right away then?

Except for the second half of this paragraph which was an argument as to
why not.

What OSes expose to userspace for "I need speculative safety" works
whether the kernel can see PSFD or not.

~Andrew


From xen-devel-bounces@lists.xenproject.org Tue Feb 01 12:47:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 01 Feb 2022 12:47:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.263591.456350 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEsYq-0007tu-Dp; Tue, 01 Feb 2022 12:47:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 263591.456350; Tue, 01 Feb 2022 12:47:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEsYq-0007tn-A8; Tue, 01 Feb 2022 12:47:04 +0000
Received: by outflank-mailman (input) for mailman id 263591;
 Tue, 01 Feb 2022 12:47:03 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JAuK=SQ=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nEsYo-0007t2-V7
 for xen-devel@lists.xenproject.org; Tue, 01 Feb 2022 12:47:03 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0b8d4151-835d-11ec-8f75-fffcc8bd4f1a;
 Tue, 01 Feb 2022 13:47:01 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0b8d4151-835d-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1643719620;
  h=from:to:cc:subject:date:message-id:
   content-transfer-encoding:mime-version;
  bh=fcvBghjyOGLsyacNTl2K0ZQIQ8llIMor2zIoZP1b0I0=;
  b=XJZ8fIvJLez9YM/OdT2P3aNMUbj3zyNr9IOXuuLhO/YDqNguvTaCyz6N
   3C/wUVt2ALPl+Hf6Ck+n52eCu/MuwMX+sAaSnZjSn+252cMt3GpBcT9Ll
   1KdIb3/ubvvMgJmnAp3jo18ZVnQIylGML7g+rMDYJ3XGDSwsvlffSUZB1
   U=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: aDnl8aZmYzlD/e1iSBLlAKimBc73T77SYCWbMLYOWZ0iEZw/h1aGoRBVLL95hv6DnJQCDKk48c
 157QFgoea88Wj2R6d6/NkdrejtCigeaj+nQRcfnN43sg2f5zxNtL/ebSBwm71waDV4ZhI2EV91
 3VJXbd+SNatda1X4BIG2DDbMGwoZY3R9SlBz0imYm3BPmcWiiagzMvD/NGZdLcbs5NwHHaEib+
 OS+OA/ALgwRPeEF6dF+nFBcWfK8qNpk9a254mFPE4f4ZTaInDdko0nuUK1pwBBVAAMjLg2db0y
 H088K1I/xodOkx+ym4JI5AM/
X-SBRS: 5.2
X-MesageID: 63213698
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:mx+Sja20nvzn+IaX7/bD5U92kn2cJEfYwER7XKvMYLTBsI5bpzNSn
 GIdW2uOPq2PajOnedp1bN6//EoD7JDRz9ZqTAdlpC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkS5PE3oHJ9RGQ74nRLlbHILOCanAZqTNMEn9700o5w7dh2+aEvPDia++zk
 YKqyyHgEAfNNw5cagr4PIra9XuDFNyr0N8plgRWicJj5TcypFFMZH4rHomjLmOQf2VhNrXSq
 9Avbl2O1jixEx8FUrtJm1tgG6EAaua60QOm0hK6V0U+6/TrS+NbPqsTbZIhhUlrZzqhxslyz
 txWtMaLWB4WLLDNidgMYhhEKnQrVUFG0OevzXmXtMWSywvNcmf2wuUoB0YzVWEa0r8pWycUr
 6VecW1TKEDY7w616OvTpu1EnMMsIdOtJIoCknph0SvYHbAtRpWrr6Diu4QChWxu15Am8fD2S
 Js5Vn1vZjf7XDJRH10cM7Imk6CUryyqG9FfgA3M/vdmi4TJ9yRzzbzsPdz9atGMA8JPkS6wv
 Xna9m70BhUbMt23yjef9H+owOjVkkvTQIsPEJWo+/gsh0ecrkQDBRtTWValrP2Rjk+lR8kZO
 0ES4jApr6U56AqsVNaVdx+yrWOAvxUcc8FNCOB84waIooLL5y6JC25CSSROAOHKr+dvG2Zsj
 AXQ2Yq0W3o/69V5VE5x6J/NtDC0MDMUd1QTfBAWUAoU38jSoZ0K20enoslYLIa5idj8GDfVy
 j+MrTQji7h7sfPnx5lX7nic3Wvy+8Ghohodo1yOAzn7tl8RiJuNOtTwgWU3+8qsO2pworOpm
 HEf0/aT4+kVZX1mvHzcGb5ddF1FChvsDdE9vbKNN8R7n9hO0yT6FWy13N2YDB0zWirjUWSxC
 HI/QSsLuPdu0IKCNMebmb6ZBcUw1rTHHt/4TP3SZdcmSsEvKFTarH42NRDBgzGFfK0QfUcXY
 83znSGEVi5yNEia5GDuG7d1PUEDm0jSOl8/tbiklk/6gNJylVaeSKsfMUvmUwzKxPjsnekhy
 P4Gb5Hi40wGCIXWO3CLmaZOcwxiBSVlVPje9pwGHsbec1EOMDxwVJfsLUYJJtYNc1J9zLmYp
 xlQmyZwlTLCuJEwAV7bNyk+OO6zBssXQLBSFXVEAGtEEkMLOO6HxKwea4E2bf8g8ulixuRzV
 P4LZ4OLBfEnd9gN02V1gUDVoNMweRK1qxiJOib5MjEzc4Q5H17C+8P+fxup/y4LV3Llucw7q
 rym9wXaXZtcGFgyUJeIMKqinwGroHwQuONuRE+UcNNdT1rhrdpxICvrg/5pf8xVcUffxiGX3
 hq9CAsDobWfuJc89dTE3PjWr4qgH+ZkMFBdGm3XseS/OSXApzLxyo5cSueYOzvaUTqsqqmlY
 OxUydD6MeEGwwkW49YtTe4zwPtntdX1prJcwgB1J1nxbgymWuF6P32L/chTrakRlLVXjhS7B
 xCU8d5ANLTXZM68SAwNJBAoZ/io3O0PnmWA9uw8JUj36XMl/LeDVkkObRCAhDYEcelwOYIhh
 +wgpNQX+0q0jR9zaoSKiSVd9mKtKH0cUvp46sFGUdGz0gd7mEtfZZH8CzPt5MDdYtpBBUAmP
 zuIifeQnL9b3EfDLyI+GHWlMTCxXnjSVMSmFGM/Gmk=
IronPort-HdrOrdr: A9a23:kRgeYqngFXiroIzINVZXW0MYxW/pDfPAimdD5ihNYBxZY6Wkfp
 +V88jzhCWZtN9OYhwdcLC7WZVpQRvnhPpICO4qTM2ftWjdyRCVxeRZg7cKrAeQfREWmtQtt5
 uIEJIOd+EYb2IK9PoSiTPQe71LoKjlzEnBv5aj854Hd3AMV0gP1XYdNu7NeXcGOTWuSKBJXa
 a0145inX6NaH4XZsO0Cj0sWPXCncTCkNbDbQQdDxAqxQGShXfwgYSKWCSw71M7aXdi0L0i+W
 /Kn0jQ4biiieiyzlv523XI55pbtdP9wp9oBdCKiOISNjLw4zzYLLhJavmnhnQYseuv4FElnJ
 3lpAohBd167zfrcmS8sXLWqn3d+Qdrz0Wn5U6TgHPlr8C8bik9EdB9iYVQdQacw1Y8vflnuZ
 g7k16xht5yN1ftjS7979/HW1VBjUyvu0cvluYVkjh2TZYeUrlMtoYSlXklXavoJBiKprzPLd
 MeTf01vJ1tABOnhjHizyNSKeWXLzsO9kzseDlAhiSXuwIm6UyRgXFohvD3pU1wha7VfaM0ld
 gsAp4Y6o2mcfVmHZ6VfN1xOfdfKla9Ni4kY1jiV2gOKsk8SgHwQtjMkfAI2N0=
X-IronPort-AV: E=Sophos;i="5.88,333,1635220800"; 
   d="scan'208";a="63213698"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=EwBNZOtfBjpgXOHsT+FTLEjAKLkJi0RA6IDvdgL96xaWTyg8stvalAbeC5lmhcEuYvwizWymizcMYwZHXICYdDIJn3p6vCUF9qNgsoLUtY8jr34j7cKqOVNLl0jJegcFdPJMBrzEGAoTm/OtdRcVTMwq8rvlIc5fhURsAPsdZ9mhXkoLFryvOmxQodzeGVvnrqRxGNahlEPdAl9N+uaVEVLqbLtwl6xgzbZXCVJ8wsK506itBvqbJtyia/0lTkgqrleim1LEOZvXecgVQdInrQiBFESepidYkMsANQFYzFsF1imzVTePgdNOY9YykTC0hYq1Vo3F0jpiSqZa20wgng==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=P87PdgwtgUt5chqcGUJFr35ftnlZ0XNCQfK47oOErEo=;
 b=mMH9rEjgcp3Az7wBGDlNChvrLgf03++6uOQOfDOlerz3pdYrBYhuKVl4Yp/fjYdBIDiSaFozztrVspgSFKcOs3XGGBlEx+o0LNzjHDBNe/xNQGydnQtazVDLk7sp9c7j3ymsjhyGS9O3P4B15KbjkahLQ0It9q0O7+8Dbi8/WispPaiRuss4zr9WVQQZHqAYwDswehuZt32liLNp2TYfg7d2dCQrFfGwbJX+2Zfx000txE4JvYq8Zt5RKTYFquMXBgy9IPNZA7GR5cd2UsxaPbpwHFj3wgFuszHVaM5J5Tp05rIjL/Svjr1Q/O0S+4D2HI4NITgEKFUpBLpQAIpDXw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=P87PdgwtgUt5chqcGUJFr35ftnlZ0XNCQfK47oOErEo=;
 b=KBuLd3+FgATPQ2BO/rdHg/y+bts9/DeaY0wbmlIpOUY/m5NWiaRGZizPNIqiCmaf0Zk/ptEMd2AqNdBvUesjb1ktEI+uaHFc2vATyqGG3kv5DupdHzA043uRb/HNIHBfCVufYMAbiH1XR19JdXg/IQQPjdBeBoIcLTvHrrUtdJk=
From: Roger Pau Monne <roger.pau@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Roger Pau Monne <roger.pau@citrix.com>, Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>, George
 Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>, Stefano
 Stabellini <sstabellini@kernel.org>, Paul Durrant <paul@xen.org>
Subject: [PATCH v3] xen/pci: detect when BARs are not suitably positioned
Date: Tue,  1 Feb 2022 13:45:51 +0100
Message-ID: <20220201124551.2392-1-roger.pau@citrix.com>
X-Mailer: git-send-email 2.34.1
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO4P123CA0446.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1a9::19) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 786d5178-04cc-4aaf-b5a6-08d9e580e196
X-MS-TrafficTypeDiagnostic: SA0PR03MB5467:EE_
X-Microsoft-Antispam-PRVS: <SA0PR03MB5467320316F7BC709FF46E6B8F269@SA0PR03MB5467.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1107;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: r0I9L4x2ZejPbuc8jqiF0XCLtBSCBx23Mbd6q7179sAPV7jKPczH76nvu/jiz5dfJzGMBxtotwYqEnF5xcnNipdWrTMyGuywtesX1iynE4k8txkRcHvMPmpc9E59PrtCLi4E0RIRPV/ridoBjUwqco6+JAvWtQ6Aks0yHev/DkMpE85FhLPhJqErCzwEkbMU6BUDWq1cWP70xqC1pCc3K6fKO2cFiY7rKlpPbWRA9ToxY0ERV3rSJKhFoJdKW3DiAD6u3Vy1ZlzkKUlkJFTh8pVpSJeVJnrjxisNle6HWtqiN/yayeenjrk/ItGdJSbX66lPgyzJMoAA1XuYEmWyqP10ij266kq0nGAHPgzjzHIWnaI+QAYmQw5BzcnVCiCfDr2AmslLA1Bq2x2XSRv6lnVWZX180nfPRUW21EFL7lWBWiQHe0p+gBgd0Pdeyj53m8Rru/qe1XJtlVj7UjQVpgCm2AqzLjt0LQHo6Jc65BZ2jRvmsl2rt9AKwXX4djvjZNSt+Iw7h5Go1ecIgr2lMu8JynBot3eozFfElY+IfblbA+7Ff0pHc1QJy59O4T0gJ13r38heDsnAl4l7TFAmK2PZubStAAw8MCSrF+T0bIT1HWFvRu7QDIUHpQjuRFiKCJQQ1D1NP4Z2YdzrCbMhTg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(2906002)(5660300002)(6916009)(54906003)(2616005)(6486002)(6666004)(316002)(1076003)(8936002)(38100700002)(66476007)(26005)(82960400001)(36756003)(186003)(86362001)(6512007)(4326008)(6506007)(508600001)(66946007)(83380400001)(66556008)(8676002)(20210929001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T3FlS01uVUNkbE12K0Uwbmtua0o1MkZDN1BFdEZKQ1BQV09ha0V4a3YzYy8x?=
 =?utf-8?B?bkhxNThCeTZHTjBIZ1ZpSGQydm1sWGFlWG1IemhmL0JwOEdYeUVjdUNaMjRB?=
 =?utf-8?B?QU1LUnJXUkZwZ2h1ejVQeUNuUHVOYk1jRFovNDZxQUpoTGtYWWUwdGo0U1NZ?=
 =?utf-8?B?RmFsYlFuU1h0NExxTzNtQWl0NlhDUHFzYkthbmV4SExDV3Ayd2ZNdkxrL3A4?=
 =?utf-8?B?dFNaYVVtUjdIazZXb2lHb3hJWExCMnowTkFnTWJFdUcrSjdrbktjTExtYzVX?=
 =?utf-8?B?Mm1rZ1B4OGRwQnlnWWhxNnVJMUZJTEppbCtqUDJTdDh0Q1U3V0c2d3JndURn?=
 =?utf-8?B?TkVHTENMNEJwL2lEcVhoSHRLRkRyN0hGenNnNFBoekI3SDF4ZHFPVHI4UTFK?=
 =?utf-8?B?RXNpUmNHQnJkUXFaMUovWGxuQkFuZWpmbFBWMXB4T1ZRcjVuMFVvMElLd1pS?=
 =?utf-8?B?VmdYQmVFV2V6alVHVUtqK0YrUWx4Z1JxakIxZEhrM2lDM010QzA5cWI0Zndo?=
 =?utf-8?B?S2dnK0VsRDlGQ2xjTG9Eei9mNWRkTzk1TWhzR1U5Qm13SW9jQ0JBWjNxVXRC?=
 =?utf-8?B?UUFITkwrMzR0aFlrNDAwcCtwZHFhVzZ6Mi9FU1krUWN0TUZzSHN6YVRFRnZ6?=
 =?utf-8?B?NC92YXEwZzBVTUhGS3dJSUtjVEE5S2s5QTgzRDVrQjIrZlRvNW5rbFQ5cm0x?=
 =?utf-8?B?S3p1OWU3bTdZSks3TXRxKzd4THYxdFlMVTMyQ09RSGcxY01yU1dGRWF6QjV6?=
 =?utf-8?B?SzZvd2hQR2Z4UmlZVVQ1dWZHdVB1L2dYOGRsVW9DMUFJdkNTVE0xbjByR01m?=
 =?utf-8?B?SnRUZUowTldVbmI3SHkwNU9QV1lSalpzS1gwZk1CRkpnUS9xMk5DR1JmWGMz?=
 =?utf-8?B?ZlI3bU5JbFdDdmNlenNZZVYyWCtrRUQwOWhDcVpiYXlJOEdQcDQrYVdIQmFm?=
 =?utf-8?B?NTJwYSt0U04vYXVNa1FFQjNmNTBHMXpQTFdqbjU4cWVjaUhuVUFJTnRIQ3ly?=
 =?utf-8?B?SXdzcGUzV1ZRMjZTZFIzV0pmMzJ6SHJVMytoKzdYZi9ZeldsTzB5LzFYWGVL?=
 =?utf-8?B?aWczeStQVUtaaUVZZGlwU0dUQzgzVDh2SWcrWVJ4Zm5VaDlLOVEwaEdNeW05?=
 =?utf-8?B?SjlrbGdaT0FyNitmSGdYUlczS1F1citwVmhXQkZvT0ZSNHBVemMxc05jY1FO?=
 =?utf-8?B?dFVqWi83T0MyZkE2cXpEWHZLV1JqK3VFNHdZTlp2SStBTllQMUh2eFZiK25U?=
 =?utf-8?B?SUkyRDhVWVFJdkZLckJmcEpwb1JVYVd1Yk1SWDJuOGhEc1VOVjVpZGtjYWdE?=
 =?utf-8?B?Y1NRQUVIUVFhVWMzSHZlcGcrSkJvSm1xdnZzTDVBaGl5RGxkZ2NuYkh1VzVT?=
 =?utf-8?B?ZVdaREVSaFpyRWVNaHd6SjFqRk9pSDg2UnBVQ3o1SU11S2N5N0F5VXY2SmpR?=
 =?utf-8?B?TDBqTHFjQW5Nbk9tNFFPQXpYSU95cStQRzVKZ1Q3ZjIyWTFaREhDTDJLOXFr?=
 =?utf-8?B?T3VwMldlRmFOZ2pPcHI4eU9TazY0cDJWUnk5bmxNRUV2b3pNRDg1d1lIS2pv?=
 =?utf-8?B?ZTBFY0phVW9iZ2hvSWh6VThaMVdLaHpLVE5kbTBHdVdQWnlNSjhiN2dpcWt2?=
 =?utf-8?B?Vkx5ZnFhY2trVmpuSTAyc3NLY1BYaUNodFV5VW95MzdRMWdReWdkTXlkT092?=
 =?utf-8?B?czBSMEFsZjQ2RzFKbVdFMVdQNTBUZzlNalFWTjNRbGlCanMrNFlwQTdsaFhj?=
 =?utf-8?B?ejZBUzM4S2t6UmozRjlxeFlWWWRkWUpYZmRtclZoMjZudDllSmpUQVk3akhC?=
 =?utf-8?B?V1VhSldjL3k1b00xaENtUWxpc1hpbWZqSXJ1biszNmdjMFFPMWp0QXdGd0t1?=
 =?utf-8?B?RXU5dm9tZVlERTBHakhtYXU4TTY2NWRyV0NkOFF6b0RONjljNzd2Y2Rveklx?=
 =?utf-8?B?dk9hbys0QUt2TVNYNzRJN3NHOUZRb3o1YkgyV0dWU2ZYcXFpbkZ2aTlWOWxw?=
 =?utf-8?B?eUZkV0hZUElZcjRaak1qVmwzNEN1T2k0TVkrWVJvRUhFdVpSNFdHajczY0c1?=
 =?utf-8?B?QzhuOG1CbGpaN1JVdFBGbGJxL2ZHSjVmODNjR290czRXakdSU25hVk9QdzM1?=
 =?utf-8?B?Uyt6REgxUXQ2dUVWeFdMTWpxbU43SSs1VkZXaHRpKzU5QVd0TERPUHYxM3Y3?=
 =?utf-8?Q?s5bNFRT78M4DiOD5sFt/81Q=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 786d5178-04cc-4aaf-b5a6-08d9e580e196
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2022 12:46:35.4366
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: l6rMZR9UHWJ3SuI8X5L6xrPdHViQLmMQBgE84bVuCBbzKlvJaOAYvYtKdaZ0JxQZXIMepAV/+a74mMRgNH+ETg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR03MB5467
X-OriginatorOrg: citrix.com

One of the boxes where I was attempting to boot Xen in PVH dom0 mode
has quirky firmware, as it will handover with a PCI device with memory
decoding enabled and a BAR of size 4K at address 0. Such BAR overlaps
with a RAM range on the e820.

This interacts badly with the dom0 PVH build, as BARs will be setup on
the p2m before RAM, so if there's a BAR positioned over a RAM region
it will trigger a domain crash when the dom0 builder attempts to
populate that region with a regular RAM page.

It's in general a very bad idea to have a BAR overlapping with any
memory region defined in the memory map, so add some sanity checks for
devices that are added with memory decoding enabled in order to assure
that BARs are not placed on top of memory regions defined in the
memory map. If overlaps are detected just disable the memory decoding
bit for the device and expect the hardware domain to properly position
the BAR.

Note apply_quirks must be called before check_pdev so that ignore_bars
is set when calling the later. PCI_HEADER_{NORMAL,BRIDGE}_NR_BARS
needs to be moved into pci_regs.h so it's defined even in the absence
of vPCI.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Changes since v2:
 - Unify warning message and store in a static const var.
 - Rename checker function to is_memory_hole.
 - Pass an inclusive MFN range to the checker function.
 - Remove Arm implementation of is_memory_hole due to lack of
   feedback.

Changes since v1:
 - Add comment regarding pci_size_mem_bar failure.
 - Make e820entry const.
 - Move is_iomem_range after is_iomem_page.
 - Reword error message.
 - Make is_iomem_range paddr_t
 - Expand commit message.
 - Move PCI_HEADER_{NORMAL,BRIDGE}_NR_BARS.
 - Only attempt to read ROM BAR if rom_pos != 0.
---
 xen/arch/x86/mm.c             | 17 +++++++++
 xen/drivers/passthrough/pci.c | 71 ++++++++++++++++++++++++++++++++++-
 xen/include/xen/mm.h          |  2 +
 xen/include/xen/pci_regs.h    |  2 +
 xen/include/xen/vpci.h        |  2 -
 5 files changed, 91 insertions(+), 3 deletions(-)

diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c
index 1397f83e41..468efd8fb4 100644
--- a/xen/arch/x86/mm.c
+++ b/xen/arch/x86/mm.c
@@ -783,6 +783,23 @@ bool is_iomem_page(mfn_t mfn)
     return (page_get_owner(page) == dom_io);
 }
 
+bool is_memory_hole(unsigned long start, unsigned long end)
+{
+    unsigned int i;
+
+    for ( i = 0; i < e820.nr_map; i++ )
+    {
+        const struct e820entry *entry = &e820.map[i];
+
+        /* Do not allow overlaps with any memory range. */
+        if ( start < PFN_DOWN(entry->addr + entry->size) &&
+             PFN_DOWN(entry->addr) <= end )
+            return false;
+    }
+
+    return true;
+}
+
 static int update_xen_mappings(unsigned long mfn, unsigned int cacheattr)
 {
     int err = 0;
diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
index 1fad80362f..9a5e6cf842 100644
--- a/xen/drivers/passthrough/pci.c
+++ b/xen/drivers/passthrough/pci.c
@@ -233,6 +233,9 @@ static void check_pdev(const struct pci_dev *pdev)
      PCI_STATUS_REC_TARGET_ABORT | PCI_STATUS_REC_MASTER_ABORT | \
      PCI_STATUS_SIG_SYSTEM_ERROR | PCI_STATUS_DETECTED_PARITY)
     u16 val;
+    unsigned int nbars = 0, rom_pos = 0, i;
+    static const char warn[] = XENLOG_WARNING
+        "%pp disabled: %sBAR [%#lx, %#lx] overlaps with memory map\n";
 
     if ( command_mask )
     {
@@ -251,6 +254,8 @@ static void check_pdev(const struct pci_dev *pdev)
     switch ( pci_conf_read8(pdev->sbdf, PCI_HEADER_TYPE) & 0x7f )
     {
     case PCI_HEADER_TYPE_BRIDGE:
+        nbars = PCI_HEADER_BRIDGE_NR_BARS;
+        rom_pos = PCI_ROM_ADDRESS1;
         if ( !bridge_ctl_mask )
             break;
         val = pci_conf_read16(pdev->sbdf, PCI_BRIDGE_CONTROL);
@@ -267,11 +272,75 @@ static void check_pdev(const struct pci_dev *pdev)
         }
         break;
 
+    case PCI_HEADER_TYPE_NORMAL:
+        nbars = PCI_HEADER_NORMAL_NR_BARS;
+        rom_pos = PCI_ROM_ADDRESS;
+        break;
+
     case PCI_HEADER_TYPE_CARDBUS:
         /* TODO */
         break;
     }
 #undef PCI_STATUS_CHECK
+
+    /* Check if BARs overlap with other memory regions. */
+    val = pci_conf_read16(pdev->sbdf, PCI_COMMAND);
+    if ( !(val & PCI_COMMAND_MEMORY) || pdev->ignore_bars )
+        return;
+
+    pci_conf_write16(pdev->sbdf, PCI_COMMAND, val & ~PCI_COMMAND_MEMORY);
+    for ( i = 0; i < nbars; )
+    {
+        uint64_t addr, size;
+        unsigned int reg = PCI_BASE_ADDRESS_0 + i * 4;
+        int rc = 1;
+
+        if ( (pci_conf_read32(pdev->sbdf, reg) & PCI_BASE_ADDRESS_SPACE) !=
+             PCI_BASE_ADDRESS_SPACE_MEMORY )
+            goto next;
+
+        rc = pci_size_mem_bar(pdev->sbdf, reg, &addr, &size,
+                              (i == nbars - 1) ? PCI_BAR_LAST : 0);
+        if ( rc < 0 )
+            /* Unable to size, better leave memory decoding disabled. */
+            return;
+        if ( size && !is_memory_hole(PFN_DOWN(addr),
+                                     PFN_DOWN(addr + size - 1)) )
+        {
+            /*
+             * Return without enabling memory decoding if BAR position is not
+             * in IO suitable memory. Let the hardware domain re-position the
+             * BAR.
+             */
+            printk(warn,
+                   &pdev->sbdf, "", PFN_DOWN(addr), PFN_DOWN(addr + size - 1));
+            return;
+        }
+
+ next:
+        ASSERT(rc > 0);
+        i += rc;
+    }
+
+    if ( rom_pos &&
+         (pci_conf_read32(pdev->sbdf, rom_pos) & PCI_ROM_ADDRESS_ENABLE) )
+    {
+        uint64_t addr, size;
+        int rc = pci_size_mem_bar(pdev->sbdf, rom_pos, &addr, &size,
+                                  PCI_BAR_ROM);
+
+        if ( rc < 0 )
+            return;
+        if ( size && !is_memory_hole(PFN_DOWN(addr),
+                                     PFN_DOWN(addr + size - 1)) )
+        {
+            printk(warn, &pdev->sbdf, "ROM ", PFN_DOWN(addr),
+                   PFN_DOWN(addr + size - 1));
+            return;
+        }
+    }
+
+    pci_conf_write16(pdev->sbdf, PCI_COMMAND, val);
 }
 
 static void apply_quirks(struct pci_dev *pdev)
@@ -399,8 +468,8 @@ static struct pci_dev *alloc_pdev(struct pci_seg *pseg, u8 bus, u8 devfn)
             break;
     }
 
-    check_pdev(pdev);
     apply_quirks(pdev);
+    check_pdev(pdev);
 
     return pdev;
 }
diff --git a/xen/include/xen/mm.h b/xen/include/xen/mm.h
index 5db26ed477..c434a53daa 100644
--- a/xen/include/xen/mm.h
+++ b/xen/include/xen/mm.h
@@ -554,6 +554,8 @@ int __must_check steal_page(struct domain *d, struct page_info *page,
 int page_is_ram_type(unsigned long mfn, unsigned long mem_type);
 /* Returns the page type(s). */
 unsigned int page_get_ram_type(mfn_t mfn);
+/* Check if a range falls into a hole in the memory map. */
+bool is_memory_hole(paddr_t start, uint64_t size);
 
 /* Prepare/destroy a ring for a dom0 helper. Helper with talk
  * with Xen on behalf of this domain. */
diff --git a/xen/include/xen/pci_regs.h b/xen/include/xen/pci_regs.h
index cc4ee3b83e..ee8e82be36 100644
--- a/xen/include/xen/pci_regs.h
+++ b/xen/include/xen/pci_regs.h
@@ -88,6 +88,8 @@
  * 0xffffffff to the register, and reading it back.  Only
  * 1 bits are decoded.
  */
+#define PCI_HEADER_NORMAL_NR_BARS	6
+#define PCI_HEADER_BRIDGE_NR_BARS	2
 #define PCI_BASE_ADDRESS_0	0x10	/* 32 bits */
 #define PCI_BASE_ADDRESS_1	0x14	/* 32 bits [htype 0,1 only] */
 #define PCI_BASE_ADDRESS_2	0x18	/* 32 bits [htype 0 only] */
diff --git a/xen/include/xen/vpci.h b/xen/include/xen/vpci.h
index 3f32de9d7e..e8ac1eb395 100644
--- a/xen/include/xen/vpci.h
+++ b/xen/include/xen/vpci.h
@@ -80,8 +80,6 @@ struct vpci {
             bool prefetchable : 1;
             /* Store whether the BAR is mapped into guest p2m. */
             bool enabled      : 1;
-#define PCI_HEADER_NORMAL_NR_BARS        6
-#define PCI_HEADER_BRIDGE_NR_BARS        2
         } bars[PCI_HEADER_NORMAL_NR_BARS + 1];
         /* At most 6 BARS + 1 expansion ROM BAR. */
 
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Tue Feb 01 13:41:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 01 Feb 2022 13:41:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.263615.456397 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEtPh-0005yv-UY; Tue, 01 Feb 2022 13:41:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 263615.456397; Tue, 01 Feb 2022 13:41:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEtPh-0005yo-RW; Tue, 01 Feb 2022 13:41:41 +0000
Received: by outflank-mailman (input) for mailman id 263615;
 Tue, 01 Feb 2022 13:41:40 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2F7S=SQ=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nEtPg-0005yf-Lf
 for xen-devel@lists.xenproject.org; Tue, 01 Feb 2022 13:41:40 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ac734252-8364-11ec-8eb8-a37418f5ba1a;
 Tue, 01 Feb 2022 14:41:37 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ac734252-8364-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1643722897;
  h=from:to:cc:subject:date:message-id:mime-version:
   content-transfer-encoding;
  bh=U4K0UzhU4SL7kU1zwxwXEVqUA/udmCQXDwLvLu5FZ2s=;
  b=gwM8z0XHXOfbvcINVH1MnUXNUFLT8HTgnnUoSodN/8Oirx1Ap0odKGh4
   Zm8/ZxqfAiNySNpUhVLlJnOgw25lk/vfBB1QvUPLshPz5XCtt6kjl7CBE
   pMTezpny4M93n7KldXL+npQp0esqhlHjM82MzJ0SEqX7uAUfP/ZF1QwYz
   g=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: EJVsNa/GkbRPp+4juWBuXGIIAzGxfC2Ixs/W5tVpttSxKx7477QRf1AC8t24lGtWF8f2xISCql
 5QGexvJ2Dr1VyxTxDvVLGlbd5XJ2hwiDqBQQs8TkX/5rVkGS/ziG8uGAgePbYdxi1fCLvBMWuu
 s6SbTyy30FO+GkiBMhUuWvcZhbqW9RfIhqqf3AuCQ1luNhM8WIt0bCXAaJF5FkYwMCGp6uH2BQ
 kUbgFegiuxtoZPwSUoQj42JpYtcA3wCw+jTC7bHmbQ1uKimNarUYNa/9hpCSsbJAo0BiwjRuMR
 dXLQL1K4z9R/1cDZP+2E9QCd
X-SBRS: 5.2
X-MesageID: 62681000
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:ah3Clqh9Be7B0gOvjEumkQfTX161mhcKZh0ujC45NGQN5FlHY01je
 htvCGqOOviDNzfyKd0ladyx9E8B65+BnYcxSQs+ri89QXgb9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oAMKRCQ7InQLlbGILes1htZGEk0GE/NtTo5w7Rj2tQw2IDja++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /1fp7XzTTYHL5bc26MgFCN0QgJHEIdZreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHCOo8Ft24m5jbeFfs8GrjIQrnQ5M8e1zA17ixLNaiEO
 ZpAMWI3BPjGSx92EHU6Os0Zp+y53FjtfgZA8l6s/bVitgA/yyQuieOwYbI5YOeiR9hT2ECRp
 WvE/mHwKhAcKNGbjzGC9xqEheLRnCW9RIMbEpW58OJnhBuYwWl7IAISfUu2p7++kEHWc8JSL
 QkY9zQjqYA29Ve3VZ/tUhugunmGsxUAHd1KHIUSyiuA167V6AaxHXUfQ3hKb9lOiSMtbWV0j
 BnTxYqvXGEx9u3OIZ6AyluKhSGgEGsRHEETXj9HCjZC2fWyg7gepA2aG76PD5WJptHyHDjxx
 RWDoy4/m6gfgKY36kmrwbzUq2ny/8aUF2bZ8i2SBzv4tV0hOOZJcqT1sQCz0BpWEGqOorBtV
 lAgktPW0u0BBIrleMelELRUR+HBCxpo3VThbb9T83sJqm7FF52LJ9k4DNRCyKFBaJxsldjBO
 xe7hO+pzMUPVEZGlIcuC25LN+wkzLL7CfPuXe3OY9xFb/BZLVHbp3w+OhbAgTGxwSDAdJ3T3
 7/BK65A6l5BUcxaIMeeHb9BgdfHOAhjrY8seXwL50v+iufPDJJkYbwELEGPfogEAFCs+23oH
 yJkH5LSkX13CbSmCgGOqNJ7BQ1UcRATWM6nw+QKJr/rClc3QwkJVq6OqY7NjqQ4xcy5YM+So
 CHkMqKZoXKi7UD6xfKiMSE+Me6/AMok8BrW/0UEZD6V5pTqWq73hI93Snf9VeBPGDVLwaEmQ
 v8bVd+HB/gTGD3L9y5ENcv2rZB4dQTtjgWLZnL3bD86dp9mZgrI5t67IVe/qHhQVnK65Zkkv
 rmt9gLHWp5fFQ5sO9nbNaC0xFSrsHlDxO8rBxnUIsNecVnH+ZRxL3Cjlec+JswBcE2RxjaT2
 wuMLw0foO3B/908/NXT3PjWpIa1CepuWEFdGjCDv7qxMCDb+EulwJNBD7nULWyMCjus9fz7N
 +tPzvz6PPkWp3pwstJxQ+Rx0KYzx9rzvLsGnA5qK2rGMgawAbR6L3jYgcQW7v9RxqVUsBedU
 16U/oUIIq2APc7oHQJDJAchaejfh/gYliOLsKYwKUT+oiR24KCGQQNZOBzV0H5RK758MYUEx
 +Y9uZFJt1zj20RyatvW3DpJ82msL2AbV/R1v54XN4bnlw43xwwQepfbECL3vMmCZtgk3pPG+
 dNIaH4uX4hh+3c=
IronPort-HdrOrdr: A9a23:HkjOXKP3JaVNdMBcTs2jsMiBIKoaSvp037Eqv3oedfUzSL3+qy
 nOpoV+6faaslYssR0b9exoW5PwJE80l6QFgrX5VI3KNGKN1VdARLsSi7cKqAeAJ8SRzIFgPN
 9bAspDNOE=
X-IronPort-AV: E=Sophos;i="5.88,334,1635220800"; 
   d="scan'208";a="62681000"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>, Jun Nakajima
	<jun.nakajima@intel.com>, Kevin Tian <kevin.tian@intel.com>
Subject: [PATCH] x86/vmx: Drop spec_ctrl load in VMEntry path
Date: Tue, 1 Feb 2022 13:41:17 +0000
Message-ID: <20220201134117.13612-1-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

This is not needed now that the VMEntry path is not responsible for loading
the guest's MSR_SPEC_CTRL value.

Fixes: 81f0eaadf84d ("x86/spec-ctrl: Fix NMI race condition with VT-x MSR_SPEC_CTRL handling")
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>
CC: Jun Nakajima <jun.nakajima@intel.com>
CC: Kevin Tian <kevin.tian@intel.com>
---
 xen/arch/x86/hvm/vmx/entry.S | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/xen/arch/x86/hvm/vmx/entry.S b/xen/arch/x86/hvm/vmx/entry.S
index 7ee3382fd0ab..49651f3c435a 100644
--- a/xen/arch/x86/hvm/vmx/entry.S
+++ b/xen/arch/x86/hvm/vmx/entry.S
@@ -85,9 +85,6 @@ UNLIKELY_END(realmode)
         test %al, %al
         jz .Lvmx_vmentry_restart
 
-        mov VCPU_arch_msrs(%rbx), %rax
-        mov VCPUMSR_spec_ctrl_raw(%rax), %eax
-
         /* WARNING! `ret`, `call *`, `jmp *` not safe beyond this point. */
         /* SPEC_CTRL_EXIT_TO_VMX   Req: %rsp=regs/cpuinfo              Clob:    */
         ALTERNATIVE "", __stringify(verw CPUINFO_verw_sel(%rsp)), X86_FEATURE_SC_VERW_HVM
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Tue Feb 01 14:38:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 01 Feb 2022 14:38:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.263623.456408 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEuI7-0002oz-9M; Tue, 01 Feb 2022 14:37:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 263623.456408; Tue, 01 Feb 2022 14:37:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEuI7-0002os-68; Tue, 01 Feb 2022 14:37:55 +0000
Received: by outflank-mailman (input) for mailman id 263623;
 Tue, 01 Feb 2022 14:37:54 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=0oSv=SQ=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nEuI6-0002oW-5G
 for xen-devel@lists.xenproject.org; Tue, 01 Feb 2022 14:37:54 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 89439bac-836c-11ec-8eb8-a37418f5ba1a;
 Tue, 01 Feb 2022 15:37:53 +0100 (CET)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2054.outbound.protection.outlook.com [104.47.13.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-23-KHbQsY6PNamjA-zoFb01qg-1; Tue, 01 Feb 2022 15:37:51 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM0PR0402MB3617.eurprd04.prod.outlook.com (2603:10a6:208:17::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.22; Tue, 1 Feb
 2022 14:37:43 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::7cc2:78a3:4d40:9d45]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::7cc2:78a3:4d40:9d45%6]) with mapi id 15.20.4930.022; Tue, 1 Feb 2022
 14:37:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 89439bac-836c-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1643726272;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=s1lSl2incW1W5x6++9gPN/yuxYcUETd9XkmHejYJidU=;
	b=TW8SKFgFy1hx9BDauzBHXTKf6fSfLoTt8WTvsUw10oR9lJAOaYLtnNenWaW7TyWP+TEAEV
	+Ob2rtn2YdXljXR094HlWgiKSB1pTc5so2P1/Fm2UtDUxQevXzAbFfAw8grESH4s7XuDdX
	JxJTOqAPA/f3qcV6Ku9UmVFyNwBb+7c=
X-MC-Unique: KHbQsY6PNamjA-zoFb01qg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Z/ltG9BtnSzzDmlj+F5MwZE2jtHqUKRk0kgbritXeq0PTJtsinKCvstNjmORUjJXlknXVapB7LzKLWFmIyKme1hxFVKDTGQ/cCSBhygYj0E1WgrhTjeUowJLvuidoImqwwPss5xU+Lu0pLeL2PlsKIKOGdio81rCR+PHT0zyihY+jBl0ApI0gCFp+kwMxINxHnt/bkIsxGSbLWj0z4d2cOW1OSzvFOcyMZOz6cXprhX2A8w3NEuuChmR5L3mKUglGYn8LQcPdIWuAVKM1n/tT5jvS7QaTL3zSTlarjJgaU3LWZZdCLGp/7yyul9NjA5unxQKmxH/PfthUSYh8LRABQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=s1lSl2incW1W5x6++9gPN/yuxYcUETd9XkmHejYJidU=;
 b=VIR8t/kPinQ9nWiQrqC6Rb55+RyOTTU5qTDTfTurXWPJR0YmRcBLhd7m+aipoKWWO95zak0Ag9cwH4Ua3bB76WB0qRqdSZfo516dnBLHBuQ2X8b843mpRtu6Tvm6FHYirj4bEoNuFWHZTo6sC74YjWv/ESILtTp7nYXj1GY2lDe38v9bq1pXwyTqmocgROQlT7iax6JyDbs8hWzxlM18TfRVIIlyCTIoPdPVJ4Mg1M/qMK6BGDG3LZJAs4RmQyodBjVuihVtPW0Mpq8FVVZ56MsDaXRIN+Qe3PRDVWkjJGNSUyM+TNayzVc2j/EpOizle77ogBNgYiAcsoU5XmX5KQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <5f8ce615-c3f9-4f02-e547-223b775f70ff@suse.com>
Date: Tue, 1 Feb 2022 15:37:40 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH] x86/vmx: Drop spec_ctrl load in VMEntry path
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Jun Nakajima <jun.nakajima@intel.com>,
 Kevin Tian <kevin.tian@intel.com>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20220201134117.13612-1-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220201134117.13612-1-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5P194CA0003.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:203:8f::13) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: cee30734-ec5a-4215-fece-08d9e59067e0
X-MS-TrafficTypeDiagnostic: AM0PR0402MB3617:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR0402MB361743426309F08B6CF9798EB3269@AM0PR0402MB3617.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4125;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	TuTLG3zljumOTNEP0lEALXnwd6ZZyXfPMDhiwNoc/dliyVW0usEkjqeaol3xk+3gcu9inXjrFaWNS4Nyu+RA02YI65QJBOJhtXX+LsdQzN/T21bstfGzRSIeGjzlBHwYY/3ffam4t0ncxbP+elXzPxhPBbD+42t97kj4y0t0qqV/ITxwDRMjzJbPTRvm8MkrXNFWds/J0lTPV73pOS+QXrObHpa10yAxumSbmfS9I34fTLZB3+n8TefM2BvT0utB0gJc/dFFiGeLuw8Pg5haOHqYmPT5X2XepA2BEr90od4vlo6hGQ77bKkWkhnmGyyH9snhH9USVjFu7rUtvmB0bcA5G3d4Uosw5MEZaPDWSnxWXfOoM/RukaLvfAkmMsncCKgQ+Td36aFVRbuIhtWjFK3ZWeugs/aYcLVkGH9JQWyJfJTCeEEhirRks8JhdQ6YO6fcdrE27+9U1floPSWgZW/ygD6cgigOFvK/KmsXwPDyz/PvpJZ2DMnwGClSqIduiy1K+pGzL6msVSn57KM8IKPliU4Z/rvVk41/pQVQk/nGVmpOwAcGEpNqM3/tPDWFravX74/LlSFZB3uWF+IiYIii1JO9nQYvZsQZ8oV1x6W4K3zGXLOWpkOkBWvxqLPxu4FjF5/INtCs0V7srHoaUOiUtCmrjatXd5O2IPOt5PnhnntIkj2mIWL8aUEcDJsspCZ75uDMxXlkfokVlvp7LP12am1IfHZa88B7/UNwxXk=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(508600001)(6506007)(53546011)(5660300002)(8936002)(8676002)(4326008)(4744005)(66556008)(186003)(66946007)(6512007)(66476007)(26005)(2906002)(31696002)(2616005)(6486002)(86362001)(38100700002)(54906003)(6916009)(316002)(31686004)(36756003)(43740500002)(45980500001)(20210929001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?c0ZoSlg2OVRyMUN3WGZoNC9kd0xlOEZKQzhYQjZoaDFmbEcyRjNyZ2ZISFRP?=
 =?utf-8?B?d0E0OUt5R01lOW9BWHZNczNudnNCdzVrOUkvbmdSSUFxazU2OEFWZm03MEpO?=
 =?utf-8?B?dGFnYVNwNDNIN1dGck4rbG9vUk9VeEZrVnRBc3hUL2tFS0t5eHhzMHAyRlFZ?=
 =?utf-8?B?WnpJTlp6Qk5UWmVuNW1aaUpOeE9ocnNLL0dGaTFyTHM1aEptUm5JUnp4S1dY?=
 =?utf-8?B?NG1YVzZMQllIZzdxcW1nM0NiKzcySkJEa21USllQWnVEL0x6VUZPK2ZuSHZX?=
 =?utf-8?B?em1Cb1RpMnUyQTlOakppOURJL2Nnd1FkaEU4L0pnaDRwcHNwMTQ0U0lrVGsv?=
 =?utf-8?B?SWVLVzZjeE5GL01rNGlrekJEQ05DUnFjUk9vRmlkTm0zK004SmNDTFBwNHZX?=
 =?utf-8?B?R3NSelJRMTV2VUJpSUpXS0FaS0pyd25wcEZuSkNScnU1WVhsOHNjZ1ZHcm56?=
 =?utf-8?B?emc2cWlXL3U4RENzRkNXai9zZzlqRVp1TGNsbHhveHJzT295bWs5K2dEdnJE?=
 =?utf-8?B?eUp4ZFNkYzMrTUIzb2syczlTU2hRM3M0REkxUzNhbHJZR0p5MUNpMmpUaUg1?=
 =?utf-8?B?T1d6NmJvWXdhR2JJNkMzVFlMWXVCY2dSTTVlYTBuRW5tZjJKcy9NdlFvNitZ?=
 =?utf-8?B?YzlKU05GeWIrSHdTSjdkb3RLR3VYTnpJeE5MV1QxQWxNTEduYktrNFBVZUxT?=
 =?utf-8?B?djVObWlTaFUyUW9XU3lVVStTVjkyb0U4UlZOY2VpYkIzdXFKZGV0UjBiRzVr?=
 =?utf-8?B?aFovVHEzRVliS1hPVzJXWDNZbDZISU5ZZ1F0SzIwbkpGSGN5b1FPVzNCcStB?=
 =?utf-8?B?YTZ2anVSUlZIY2dzTk1pZDd4SmtJUGN0cTd1dWJLRUczb3ozaVhNUEwxRjl5?=
 =?utf-8?B?NGpjbE4yV0hjTzE0R2w1bStqMFgxVHZRdlRIeVRnMVdzdjJkVTlVU1pyZVlq?=
 =?utf-8?B?MHZ1TGFJRENzaDh1UDZ0dE5tdzFuQ1hIZmJZc1UrQzZQdDFGQTV3VCtOWTlv?=
 =?utf-8?B?dG9tMThCdS9HalcwTnA0TStIQlpGcUIxNGZWZnhLNGRQOVAxWlR4dnRyaTM3?=
 =?utf-8?B?TEUveUZBZEhkUmdpekRxY1lEVEhDNERlUzMzTldVQnhLdDFDMHpOT21MNzNX?=
 =?utf-8?B?elZWNkxvaEVUUTNlRGlwY0hWQkNPWHVyenZDT2NKeXozeG1mbk9UUDVTUXVi?=
 =?utf-8?B?WUNVcGdxMDFOSmxpczlxdG9CS1lDekhIc3RjcHFXMytQazgrTW5JZjkwSkwx?=
 =?utf-8?B?NEl0YkNPcHNXamwySmdERU5jdFlmVnNyS2gyMnZSUlN6Sm10WTVTcWovc3VL?=
 =?utf-8?B?bzNWdmhabUo1QVZGSVJaZ2RCcGF5Yjk3cmhxUWQxaGhzY2xJOG5tRTRjSFBK?=
 =?utf-8?B?L3A3QUsyQmlwQjJYVHh1aDdNWDZVcGFyM0R3V2dacTN5akM5T3YrUEVCdnkr?=
 =?utf-8?B?Q0ZoVll4NmJkZUo3aHRkcXVUaU9TTjQ2ZW5vR2JwaHJXNXNoQkZOYnd3NWVk?=
 =?utf-8?B?dFVUYng5REJzZ0RKTnVid0ZJckhab1RWQjBkV3o4SnJuajNaUnBuaVhKNEVh?=
 =?utf-8?B?VWg4RUxCUU5hL0ZIYUJlcWJnSHhpSHI1K09oRVRjL3BlVmowTTFQQW11UVVa?=
 =?utf-8?B?T05FaWpURTdRNklPZXhaRWNxcFBTd3hTSnZOeE1vaTFuVVlXUi92U0h6US82?=
 =?utf-8?B?OHdnT3NlQVh2Q0FWRmR0VHI2Y01MZDJ2eVFuL2J0NG5mdThRYzJRKzgwMmh6?=
 =?utf-8?B?Y0lac29JdkkvMXNmc3pJb3lidXlxWDI0Ui9PVVNOSGRCRVhvS3cxQy9aam4v?=
 =?utf-8?B?cHVUQWZxZE9PTnhLZjd4cmhXaUdxRWp6c0E4ZXpOWU5lUVN5ODBWQUY4NVlM?=
 =?utf-8?B?eE5TTUF6TldTTTFoS2JoeE1UY2NwQkNGVjdpRmtFNnA3Y24rUjJ5bE1paGh5?=
 =?utf-8?B?TjR6ZGRKWU5FMjZwUitkZWc5cHQzb0wrUkxDV2hYWDEzNzRxS2x4UExPellF?=
 =?utf-8?B?cjlWbGtrVW4yWmZ2aXRDdkpsaDdIdm02dmd5ZTJsRW04aklWRHFPUDgybm1j?=
 =?utf-8?B?dlI4Z3dIcXVkZnYwaDZMd3VjNmFQNHJldHN5UjJ3Q09OZC9sQmM5bWhPSDVK?=
 =?utf-8?B?UkFYY0dLZm9CWmhMbUEwNDhVNW1EekdOckNGSzdHa21kNEVkT2orYzRyemlK?=
 =?utf-8?Q?Iw46yyfJINh8jSdyzxjOtGU=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cee30734-ec5a-4215-fece-08d9e59067e0
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2022 14:37:43.2204
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: R4wXcgJZs9rHDYFSP0+roPY1g4KZV5OTyZSaAX65r4WWJ5b63vcbdTv2wJg0nqQidn0AOs82edGV7AxtW7/fAg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0402MB3617

On 01.02.2022 14:41, Andrew Cooper wrote:
> This is not needed now that the VMEntry path is not responsible for loading
> the guest's MSR_SPEC_CTRL value.
> 
> Fixes: 81f0eaadf84d ("x86/spec-ctrl: Fix NMI race condition with VT-x MSR_SPEC_CTRL handling")
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Tue Feb 01 16:25:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 01 Feb 2022 16:25:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.263633.456433 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEvy0-0005Vb-Jt; Tue, 01 Feb 2022 16:25:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 263633.456433; Tue, 01 Feb 2022 16:25:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEvy0-0005V4-G6; Tue, 01 Feb 2022 16:25:16 +0000
Received: by outflank-mailman (input) for mailman id 263633;
 Tue, 01 Feb 2022 16:25:15 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=scQ7=SQ=gmail.com=andr2000@srs-se1.protection.inumbo.net>)
 id 1nEvxz-0005Ky-Nh
 for xen-devel@lists.xenproject.org; Tue, 01 Feb 2022 16:25:15 +0000
Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com
 [2a00:1450:4864:20::130])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 895883a9-837b-11ec-8eb8-a37418f5ba1a;
 Tue, 01 Feb 2022 17:25:15 +0100 (CET)
Received: by mail-lf1-x130.google.com with SMTP id x23so35118545lfc.0
 for <xen-devel@lists.xenproject.org>; Tue, 01 Feb 2022 08:25:15 -0800 (PST)
Received: from a2klaptop.localdomain ([185.199.97.5])
 by smtp.gmail.com with ESMTPSA id z20sm2037887ljn.92.2022.02.01.08.25.12
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 01 Feb 2022 08:25:13 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 895883a9-837b-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=zf0SXmh7ppwJ/thacBkxdMQhMGMB2nHh2LPFDThcNGk=;
        b=XpJvvbpEUYoLErsZRXX4lG9uNB57vhEPnHdXBzXza3jFxQkF3ceyXYdmRu/zzVxNo9
         wS3WRaDKhYg42tjm37yfrqROI2/XNaY9mFYAeiQmlkQjWTNBYFlRm1bKj1IzsDEabg2Z
         ZXB+4Bu6dchfZJqi0iSgCrkEawgQXCAOWb1NbhfDM9dBa6NSLEO7oVnZ1oG6bIDrRDTp
         TKooKs1VjJxCRogreuWA4kxNK6j3cE98NOO3J5GgH7MgfyFo0b5/6jta7RYuKY6lfLuv
         4lArSFjFF8BG2Ik5HQS9KDhGIEz20Atl8FyxnHj1x1Zu3TrYH6+x11pnvnAF0wgbE1WT
         iIgQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=zf0SXmh7ppwJ/thacBkxdMQhMGMB2nHh2LPFDThcNGk=;
        b=7lakmGsSd5T6hlySshD+HXDI7fOzAY4T7lYUazsOIqV2vXCkCrAICmm93nDJXNw4Mz
         GQ222DUcEcXCrZnmAh/JI3Egqxl8QKPVdpuAodqAdDxYkmWBrmo9scfwWcJQ7I6Ars/o
         1/Tu7+xE5bA8BvV3igEuVKZPVn7BTcdflE7G97urEmfG2aWutC62udmWKDUQEs8hyeXZ
         299WVN4VFPgQ4PYDuBvwt8wqmA7oGbKzSwrUFDyCdGBKatTC5wSNzaL1shAEfiehNR8O
         eUwXW10Bmw1D1y7jkRuoedi6d7sSjJG/ZR/kW5Qq5ErnZ0ZifCA6U0L2EGpgLbYka++y
         UmEw==
X-Gm-Message-State: AOAM533h7JKhhY1vepMcGvpGVmblDkWpatOkkgZ7BmWgyGbbyGzbzCPb
	oG7Ll3SZFN4AUD/AuVng2M7eQdi1/bs=
X-Google-Smtp-Source: ABdhPJyCvek8axmHS9oDXcyCrEQe3WzO0YHajhyUR+ohQ84kFaRbCqkLApNwjlY30/Vp5rNK+RSDQg==
X-Received: by 2002:a05:6512:10d6:: with SMTP id k22mr20503490lfg.243.1643732713986;
        Tue, 01 Feb 2022 08:25:13 -0800 (PST)
From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	sstabellini@kernel.org,
	oleksandr_tyshchenko@epam.com,
	volodymyr_babchuk@epam.com,
	Artem_Mygaiev@epam.com,
	roger.pau@citrix.com,
	jbeulich@suse.com,
	andrew.cooper3@citrix.com,
	george.dunlap@citrix.com,
	paul@xen.org,
	bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: [PATCH 2/4] rangeset: add rangeset_reset helper function
Date: Tue,  1 Feb 2022 18:25:06 +0200
Message-Id: <20220201162508.417008-3-andr2000@gmail.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220201162508.417008-1-andr2000@gmail.com>
References: <20220201162508.417008-1-andr2000@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

This helper destroys all the ranges of the rangeset given.
Please note, that it uses rangeset_remove_range which returns an error
code on failure. This error code can be ignored as while destroying all
the ranges no memory allocation is expected, so in this case it must not
fail.

To make sure this remains valid use BUG_ON if that changes in the future.

Suggested-by: Roger Pau Monné <roger.pau@citrix.com>
Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
---
 xen/common/rangeset.c      | 6 ++++++
 xen/include/xen/rangeset.h | 3 +++
 2 files changed, 9 insertions(+)

diff --git a/xen/common/rangeset.c b/xen/common/rangeset.c
index ea27d651723b..9ca2b06cff22 100644
--- a/xen/common/rangeset.c
+++ b/xen/common/rangeset.c
@@ -525,6 +525,12 @@ void rangeset_swap(struct rangeset *a, struct rangeset *b)
     write_unlock(&b->lock);
 }
 
+void rangeset_reset(struct rangeset *r)
+{
+    /* This doesn't allocate anything and must not fail. */
+    BUG_ON(rangeset_remove_range(r, 0, ~0ULL));
+}
+
 /*****************************
  * Pretty-printing functions
  */
diff --git a/xen/include/xen/rangeset.h b/xen/include/xen/rangeset.h
index f7c69394d66a..e0d70d88bdd7 100644
--- a/xen/include/xen/rangeset.h
+++ b/xen/include/xen/rangeset.h
@@ -95,6 +95,9 @@ bool_t __must_check rangeset_contains_singleton(
 /* swap contents */
 void rangeset_swap(struct rangeset *a, struct rangeset *b);
 
+/* Destroy all ranges. */
+void rangeset_reset(struct rangeset *r);
+
 /* Rangeset pretty printing. */
 void rangeset_domain_printk(
     struct domain *d);
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Tue Feb 01 16:25:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 01 Feb 2022 16:25:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.263634.456455 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEvy3-00067j-1G; Tue, 01 Feb 2022 16:25:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 263634.456455; Tue, 01 Feb 2022 16:25:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEvy2-00067a-TT; Tue, 01 Feb 2022 16:25:18 +0000
Received: by outflank-mailman (input) for mailman id 263634;
 Tue, 01 Feb 2022 16:25:17 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=scQ7=SQ=gmail.com=andr2000@srs-se1.protection.inumbo.net>)
 id 1nEvy0-0005Ky-WE
 for xen-devel@lists.xenproject.org; Tue, 01 Feb 2022 16:25:17 +0000
Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com
 [2a00:1450:4864:20::12d])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8a11fe43-837b-11ec-8eb8-a37418f5ba1a;
 Tue, 01 Feb 2022 17:25:16 +0100 (CET)
Received: by mail-lf1-x12d.google.com with SMTP id x23so35118682lfc.0
 for <xen-devel@lists.xenproject.org>; Tue, 01 Feb 2022 08:25:16 -0800 (PST)
Received: from a2klaptop.localdomain ([185.199.97.5])
 by smtp.gmail.com with ESMTPSA id z20sm2037887ljn.92.2022.02.01.08.25.14
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 01 Feb 2022 08:25:15 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8a11fe43-837b-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=O5iQETph6W13NDJUtDiBUfFdxzLSUx1dcP7y4KZ0Jn4=;
        b=Knowkl1OOo7PkZEnyXfB0uQdghQi1oSTzc8ntrp5jfpt8BnMjo+t1cybbx3gzhczJ4
         rpQJgV4JPsFS3JSxQwcmmphJEUMBkm4Cx6TpvXhoojeZT+sI+WIO7sKQy9qSi/P5AxRg
         lTqJuLdBeNyBw0CRAGUvZieuUDHv5wIi6Vd2b1ZA89AdxnOSBM7ux5lTuyUCOHRxMp0o
         pQtl7ruyA+uUDJNKpkJ4VLl8snI54POPpIyvvBLQxGuL4dLSCMG1sJL9xdwbCbx8XQdy
         gerT5iPbHu5KxKDJRWETvL3F6KNtzdoe25xHTDeM5RyQ8zB7uUmQB2Jy7ocyrsIepEJY
         0Lig==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=O5iQETph6W13NDJUtDiBUfFdxzLSUx1dcP7y4KZ0Jn4=;
        b=03l+PPFZ++vRDbU3RIwTn2YiDAXQv2//BxI+gPMgWU490PfhlxCMWE9uoCA0MYBmHP
         P0QHX+lYnW9zxOFkiUCQdymcFbBF6hSS0hm4NDZbHpKw0XSnULtiC8S3S/2vmWqRTTFY
         Kb6uHFlZFLPAP77X8cWccMUVUTM/Tz5mY15txuqkO2+GUtCheYPDUCyDOH+YVDse6u0H
         x1PIG04QvFirMBwQyRyGXY1i8aDjoTpsIoXV3ACA/Glo0FvFkCpbCcJxGmqz3TZxkb44
         tzigHOOyhtNSeZiJK/n6ylvCWE/F5LuE8JX0hicipnMGggFAwsrexcEhUZJDF3ShGh/I
         6hjA==
X-Gm-Message-State: AOAM530W8kYBK3ubw2Bfe+3UzawcneeewfQ3T/P0czaLRPgQGA4xP9YF
	G5qlKhrmiJ2KiHqo4ZBpno3nk69QEl8=
X-Google-Smtp-Source: ABdhPJxALpiNGj4uqi5Ow3ML9Pg+P88S0Or/Bob/aFSPygbzA+vBkcO/PeE6dA6LrJe4HTVnHNR8Eg==
X-Received: by 2002:a05:6512:1049:: with SMTP id c9mr16194147lfb.554.1643732715753;
        Tue, 01 Feb 2022 08:25:15 -0800 (PST)
From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	sstabellini@kernel.org,
	oleksandr_tyshchenko@epam.com,
	volodymyr_babchuk@epam.com,
	Artem_Mygaiev@epam.com,
	roger.pau@citrix.com,
	jbeulich@suse.com,
	andrew.cooper3@citrix.com,
	george.dunlap@citrix.com,
	paul@xen.org,
	bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: [PATCH 3/4] vpci: shrink critical section in vpci_{read/write}
Date: Tue,  1 Feb 2022 18:25:07 +0200
Message-Id: <20220201162508.417008-4-andr2000@gmail.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220201162508.417008-1-andr2000@gmail.com>
References: <20220201162508.417008-1-andr2000@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

Shrink critical section in vpci_{read/write} as racing calls to
vpci_{read,write}_hw() shouldn't be a problem. Those are just wrappers
around pci_conf_{read,write} functions, and the required locking (in
case of using the IO ports) is already taken care in pci_conf_{read,write}.

Please note, that we anyways split 64bit writes into two 32bit ones
without taking the lock for the whole duration of the access, so it is
possible to see a partially updated state as a result of a 64bit write:
the PCI(e) specification don't seem to specify whether the ECAM is allowed
to split memory transactions into multiple Configuration Requests and
whether those could then interleave with requests from a different CPU.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

---
New in v6
---
 xen/drivers/vpci/vpci.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/xen/drivers/vpci/vpci.c b/xen/drivers/vpci/vpci.c
index 657697fe3406..fb0947179b79 100644
--- a/xen/drivers/vpci/vpci.c
+++ b/xen/drivers/vpci/vpci.c
@@ -370,6 +370,7 @@ uint32_t vpci_read(pci_sbdf_t sbdf, unsigned int reg, unsigned int size)
             break;
         ASSERT(data_offset < size);
     }
+    spin_unlock(&pdev->vpci->lock);
 
     if ( data_offset < size )
     {
@@ -379,7 +380,6 @@ uint32_t vpci_read(pci_sbdf_t sbdf, unsigned int reg, unsigned int size)
 
         data = merge_result(data, tmp_data, size - data_offset, data_offset);
     }
-    spin_unlock(&pdev->vpci->lock);
 
     return data & (0xffffffff >> (32 - 8 * size));
 }
@@ -475,13 +475,12 @@ void vpci_write(pci_sbdf_t sbdf, unsigned int reg, unsigned int size,
             break;
         ASSERT(data_offset < size);
     }
+    spin_unlock(&pdev->vpci->lock);
 
     if ( data_offset < size )
         /* Tailing gap, write the remaining. */
         vpci_write_hw(sbdf, reg + data_offset, size - data_offset,
                       data >> (data_offset * 8));
-
-    spin_unlock(&pdev->vpci->lock);
 }
 
 /* Helper function to check an access size and alignment on vpci space. */
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Tue Feb 01 16:25:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 01 Feb 2022 16:25:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.263632.456427 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEvy0-0005NJ-Ah; Tue, 01 Feb 2022 16:25:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 263632.456427; Tue, 01 Feb 2022 16:25:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEvy0-0005Lm-4v; Tue, 01 Feb 2022 16:25:16 +0000
Received: by outflank-mailman (input) for mailman id 263632;
 Tue, 01 Feb 2022 16:25:14 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=scQ7=SQ=gmail.com=andr2000@srs-se1.protection.inumbo.net>)
 id 1nEvxy-0005Ky-Ns
 for xen-devel@lists.xenproject.org; Tue, 01 Feb 2022 16:25:14 +0000
Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com
 [2a00:1450:4864:20::134])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8833c48b-837b-11ec-8eb8-a37418f5ba1a;
 Tue, 01 Feb 2022 17:25:13 +0100 (CET)
Received: by mail-lf1-x134.google.com with SMTP id b9so34965825lfq.6
 for <xen-devel@lists.xenproject.org>; Tue, 01 Feb 2022 08:25:13 -0800 (PST)
Received: from a2klaptop.localdomain ([185.199.97.5])
 by smtp.gmail.com with ESMTPSA id z20sm2037887ljn.92.2022.02.01.08.25.11
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 01 Feb 2022 08:25:12 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8833c48b-837b-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=fkt1iiffJfOyIvWsY76Bn/20kVLeJA6ML116mlUONbo=;
        b=E5ZvE1ExDici3mLfBGRByMNhSMDR1z1V0Jl1J1xe2WutHFL5N09fhAdb5VLIUW9HK+
         P/lkLUCSA5p4M7u5kSwIuvzRYJV4wZYdiN9pr+Lkkxk/95xSt+agiquiiB5eAmbduPDe
         pv3jHuzZjqHlEVl122Sf6sJuAju4KN3omOsBmbNzSLS34f/KtYRhM98b95hrCgVRbkEp
         xWVMi9jjXf9RaWhY4vp9sYypkMBS1vT4aAqdr/6k5HgbrnZM7MiT6sfq/r4VOGbXqeRP
         kdmqeeQpeAyQUfoIHRQvjCbtRe67gmA1oE10VD36Ctt20olU2eCTxgUxDXRFjOhAIS12
         vfnQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=fkt1iiffJfOyIvWsY76Bn/20kVLeJA6ML116mlUONbo=;
        b=2PUeynavqCW2sADe+r+GRKrj2jVCdQ09NT0uI9DKmG0BaTsqyDNJTkkJo8o7LWmnuK
         bNbk3l6+4pifIgBfR7bHHbbqkXVowvmx7FHiPH0eEO5+grCRRJKx0Tjpc0OcK6Smlu7F
         QpvqfkeaICHwDYVdLR+SID79qNYoe/gl2jb5d20Z+3ksXKl+jnBKq73MttkjiOawCsht
         p6Ud9OoA8P5n0B/FaSg7B+rB2jDqVVQF3de5U8A39K57Iw4cKJG9o/KuKvmS4QDTnyfu
         usc3ddbpcdsva/m2xlQtq8aHqL9Qjy/HEZHtP5Blv/psYYoa2IIqUGA/efVfO/7+6aU0
         bEDQ==
X-Gm-Message-State: AOAM5309QEcrmobCtVqFxJgZogNylz2J+uDBUtWGbYQS3XBdWd6+YhY0
	CqNEv4F/IMlanwAA2O06xjzjCiC1OKk=
X-Google-Smtp-Source: ABdhPJz7aQDwqw7IoCOwv24upNdvgpBXk6PPFLGQPG6c+KV0NT+moFC8V+wUyvqK76n3mynaOJyREg==
X-Received: by 2002:a05:6512:a83:: with SMTP id m3mr19008711lfu.67.1643732712600;
        Tue, 01 Feb 2022 08:25:12 -0800 (PST)
From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	sstabellini@kernel.org,
	oleksandr_tyshchenko@epam.com,
	volodymyr_babchuk@epam.com,
	Artem_Mygaiev@epam.com,
	roger.pau@citrix.com,
	jbeulich@suse.com,
	andrew.cooper3@citrix.com,
	george.dunlap@citrix.com,
	paul@xen.org,
	bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: [PATCH 1/4] rangeset: add RANGESETF_no_print flag
Date: Tue,  1 Feb 2022 18:25:05 +0200
Message-Id: <20220201162508.417008-2-andr2000@gmail.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220201162508.417008-1-andr2000@gmail.com>
References: <20220201162508.417008-1-andr2000@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

There are range sets which should not be printed, so introduce a flag
which allows marking those as such. Implement relevant logic to skip
such entries while printing.

While at it also simplify the definition of the flags by directly
defining those without helpers.

Suggested-by: Jan Beulich <jbeulich@suse.com>
Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
---
Since v5:
- comment indentation (Jan)
Since v1:
- update BUG_ON with new flag
- simplify the definition of the flags
---
 xen/common/rangeset.c      | 5 ++++-
 xen/include/xen/rangeset.h | 5 +++--
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/xen/common/rangeset.c b/xen/common/rangeset.c
index 885b6b15c229..ea27d651723b 100644
--- a/xen/common/rangeset.c
+++ b/xen/common/rangeset.c
@@ -433,7 +433,7 @@ struct rangeset *rangeset_new(
     INIT_LIST_HEAD(&r->range_list);
     r->nr_ranges = -1;
 
-    BUG_ON(flags & ~RANGESETF_prettyprint_hex);
+    BUG_ON(flags & ~(RANGESETF_prettyprint_hex | RANGESETF_no_print));
     r->flags = flags;
 
     safe_strcpy(r->name, name ?: "(no name)");
@@ -575,6 +575,9 @@ void rangeset_domain_printk(
 
     list_for_each_entry ( r, &d->rangesets, rangeset_list )
     {
+        if ( r->flags & RANGESETF_no_print )
+            continue;
+
         printk("    ");
         rangeset_printk(r);
         printk("\n");
diff --git a/xen/include/xen/rangeset.h b/xen/include/xen/rangeset.h
index 135f33f6066f..f7c69394d66a 100644
--- a/xen/include/xen/rangeset.h
+++ b/xen/include/xen/rangeset.h
@@ -49,8 +49,9 @@ void rangeset_limit(
 
 /* Flags for passing to rangeset_new(). */
  /* Pretty-print range limits in hexadecimal. */
-#define _RANGESETF_prettyprint_hex 0
-#define RANGESETF_prettyprint_hex  (1U << _RANGESETF_prettyprint_hex)
+#define RANGESETF_prettyprint_hex   (1U << 0)
+ /* Do not print entries marked with this flag. */
+#define RANGESETF_no_print          (1U << 1)
 
 bool_t __must_check rangeset_is_empty(
     const struct rangeset *r);
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Tue Feb 01 16:25:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 01 Feb 2022 16:25:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.263635.456467 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEvy5-0006Qe-CE; Tue, 01 Feb 2022 16:25:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 263635.456467; Tue, 01 Feb 2022 16:25:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEvy5-0006QQ-8b; Tue, 01 Feb 2022 16:25:21 +0000
Received: by outflank-mailman (input) for mailman id 263635;
 Tue, 01 Feb 2022 16:25:19 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=scQ7=SQ=gmail.com=andr2000@srs-se1.protection.inumbo.net>)
 id 1nEvy3-0005Ky-6T
 for xen-devel@lists.xenproject.org; Tue, 01 Feb 2022 16:25:19 +0000
Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com
 [2a00:1450:4864:20::129])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8b204a2c-837b-11ec-8eb8-a37418f5ba1a;
 Tue, 01 Feb 2022 17:25:18 +0100 (CET)
Received: by mail-lf1-x129.google.com with SMTP id z19so34876964lfq.13
 for <xen-devel@lists.xenproject.org>; Tue, 01 Feb 2022 08:25:18 -0800 (PST)
Received: from a2klaptop.localdomain ([185.199.97.5])
 by smtp.gmail.com with ESMTPSA id z20sm2037887ljn.92.2022.02.01.08.25.15
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 01 Feb 2022 08:25:16 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8b204a2c-837b-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=OjkZoTR61B7utfXrmaTSlHnNCI9PmHivrLzjF3WsrhI=;
        b=YV1tZL4y3q4k8OZTWZxcehM3mB8NFp7Q3Cb8iwqbd7AtzGNfCHVOmBbNr838OjoBdG
         DBH18KUzRWRoE/iCN39IIX3Ez9YF3uLFVnb9cXQ/L4t+2zjdlGCfcW2xfo54nA6gDqyj
         1uYmrndCRqmOxtNqNEbM/dPG7b/PFrJVj3i8aH7CKDl3+xT26Oce3tH8tRE2l60Y/MJr
         a4i40raUGshW+tycYqVZvjYweVMqhL4o9Y2zTvTAYU1RjtWU/lEyd/3KU8II/Gj8uKJ7
         ePIXUN9xFPOWLBzCad4OwO/D86Bkj4q3ZMc/8NDhYyjruXc95IEOdmSw3Q6i1uLH7D5U
         qKFA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=OjkZoTR61B7utfXrmaTSlHnNCI9PmHivrLzjF3WsrhI=;
        b=2ZBNotwJ3yTjanq/5LpvjNRDu5mWtPx0PCxRlBkQQTnmfvdcMLPtQfeK/arWJaj7ZV
         M9Re557GsjS0j84IDcFZJ4K597Vcg7DdLNM2kuNsqahsuPv+EO559OkSUdM7lea0CIiC
         dc1s/Y+qA/L5HrJteJco5OBZG5XRdF5ELXwf64YADfQYaozefBhe+664BRIBYaCtxQ4Q
         NAWR9a8JADTeMkD42hlSlblFMqLt3fC1DPVhiKM1Lvs13zaporXN+kXerhfjHYgn44mL
         DPP4a3RCeztkZttdlnW6v7IplEAIkEkEGfIIeJYnSY+TCOVlJ3CggfPS8UA7Mw4HYZPJ
         Eg6g==
X-Gm-Message-State: AOAM533IE2IIDQ19QtWFLQBuVXYVc6IeBGk4F61gWjVwL0V7coruWBBP
	Afd63Wd06L8RxPY9Z3Kvrnfa0ILuxJQ=
X-Google-Smtp-Source: ABdhPJy4UCne6+TAN6DIconeVQuh4TMk8c/BIMlhpIaYC++3e55rF3rhZFj5G0/OtbhmUrakakPNaQ==
X-Received: by 2002:a05:6512:32ca:: with SMTP id f10mr15292400lfg.329.1643732717478;
        Tue, 01 Feb 2022 08:25:17 -0800 (PST)
From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	sstabellini@kernel.org,
	oleksandr_tyshchenko@epam.com,
	volodymyr_babchuk@epam.com,
	Artem_Mygaiev@epam.com,
	roger.pau@citrix.com,
	jbeulich@suse.com,
	andrew.cooper3@citrix.com,
	george.dunlap@citrix.com,
	paul@xen.org,
	bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: [PATCH 4/4] vpci: move lock outside of struct vpci
Date: Tue,  1 Feb 2022 18:25:08 +0200
Message-Id: <20220201162508.417008-5-andr2000@gmail.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220201162508.417008-1-andr2000@gmail.com>
References: <20220201162508.417008-1-andr2000@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

From: Roger Pau Monne <roger.pau@citrix.com>

This way the lock can be used to check whether vpci is present, and
removal can be performed while holding the lock, in order to make
sure there are no accesses to the contents of the vpci struct.
Previously removal could race with vpci_read for example, since the
lock was dropped prior to freeing pdev->vpci.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
---
Cc: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Jan Beulich <jbeulich@suse.com>
Cc: Julien Grall <julien@xen.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>
---
New in v5 of this series: this is an updated version of the patch published at
https://lore.kernel.org/xen-devel/20180717094830.54806-2-roger.pau@citrix.com/

Changes since v5:
 - do not split code into vpci_remove_device_handlers_locked yet
 - move INIT_LIST_HEAD outside the locked region (Jan)
 - stripped out locking optimizations for vpci_{read|write} into a
   dedicated patch
Changes since v2:
 - fixed pdev->vpci = xzalloc(struct vpci); under spin_lock (Jan)
Changes since v1:
 - Assert that vpci_lock is locked in vpci_remove_device_locked.
 - Remove double newline.
 - Shrink critical section in vpci_{read/write}.
---
 tools/tests/vpci/emul.h       |  5 ++-
 tools/tests/vpci/main.c       |  4 +--
 xen/arch/x86/hvm/vmsi.c       |  8 ++---
 xen/drivers/passthrough/pci.c |  1 +
 xen/drivers/vpci/header.c     | 21 ++++++++----
 xen/drivers/vpci/msi.c        | 11 ++++--
 xen/drivers/vpci/msix.c       |  8 ++---
 xen/drivers/vpci/vpci.c       | 63 ++++++++++++++++++++++-------------
 xen/include/xen/pci.h         |  1 +
 xen/include/xen/vpci.h        |  3 +-
 10 files changed, 78 insertions(+), 47 deletions(-)

diff --git a/tools/tests/vpci/emul.h b/tools/tests/vpci/emul.h
index 2e1d3057c9d8..d018fb5eef21 100644
--- a/tools/tests/vpci/emul.h
+++ b/tools/tests/vpci/emul.h
@@ -44,6 +44,7 @@ struct domain {
 };
 
 struct pci_dev {
+    bool vpci_lock;
     struct vpci *vpci;
 };
 
@@ -53,10 +54,8 @@ struct vcpu
 };
 
 extern const struct vcpu *current;
-extern const struct pci_dev test_pdev;
+extern struct pci_dev test_pdev;
 
-typedef bool spinlock_t;
-#define spin_lock_init(l) (*(l) = false)
 #define spin_lock(l) (*(l) = true)
 #define spin_unlock(l) (*(l) = false)
 
diff --git a/tools/tests/vpci/main.c b/tools/tests/vpci/main.c
index b9a0a6006bb9..26c95b08b6b1 100644
--- a/tools/tests/vpci/main.c
+++ b/tools/tests/vpci/main.c
@@ -23,7 +23,8 @@ static struct vpci vpci;
 
 const static struct domain d;
 
-const struct pci_dev test_pdev = {
+struct pci_dev test_pdev = {
+    .vpci_lock = false,
     .vpci = &vpci,
 };
 
@@ -158,7 +159,6 @@ main(int argc, char **argv)
     int rc;
 
     INIT_LIST_HEAD(&vpci.handlers);
-    spin_lock_init(&vpci.lock);
 
     VPCI_ADD_REG(vpci_read32, vpci_write32, 0, 4, r0);
     VPCI_READ_CHECK(0, 4, r0);
diff --git a/xen/arch/x86/hvm/vmsi.c b/xen/arch/x86/hvm/vmsi.c
index 13e2a190b439..1f7a37f78264 100644
--- a/xen/arch/x86/hvm/vmsi.c
+++ b/xen/arch/x86/hvm/vmsi.c
@@ -910,14 +910,14 @@ int vpci_msix_arch_print(const struct vpci_msix *msix)
         {
             struct pci_dev *pdev = msix->pdev;
 
-            spin_unlock(&msix->pdev->vpci->lock);
+            spin_unlock(&msix->pdev->vpci_lock);
             process_pending_softirqs();
             /* NB: we assume that pdev cannot go away for an alive domain. */
-            if ( !pdev->vpci || !spin_trylock(&pdev->vpci->lock) )
+            if ( !spin_trylock(&pdev->vpci_lock) )
                 return -EBUSY;
-            if ( pdev->vpci->msix != msix )
+            if ( !pdev->vpci || pdev->vpci->msix != msix )
             {
-                spin_unlock(&pdev->vpci->lock);
+                spin_unlock(&pdev->vpci_lock);
                 return -EAGAIN;
             }
         }
diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
index 1fad80362f0e..af648c6a19b5 100644
--- a/xen/drivers/passthrough/pci.c
+++ b/xen/drivers/passthrough/pci.c
@@ -328,6 +328,7 @@ static struct pci_dev *alloc_pdev(struct pci_seg *pseg, u8 bus, u8 devfn)
     *((u8*) &pdev->bus) = bus;
     *((u8*) &pdev->devfn) = devfn;
     pdev->domain = NULL;
+    spin_lock_init(&pdev->vpci_lock);
 
     arch_pci_init_pdev(pdev);
 
diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c
index 40ff79c33f8f..bd23c0274d48 100644
--- a/xen/drivers/vpci/header.c
+++ b/xen/drivers/vpci/header.c
@@ -142,12 +142,13 @@ bool vpci_process_pending(struct vcpu *v)
         if ( rc == -ERESTART )
             return true;
 
-        spin_lock(&v->vpci.pdev->vpci->lock);
-        /* Disable memory decoding unconditionally on failure. */
-        modify_decoding(v->vpci.pdev,
-                        rc ? v->vpci.cmd & ~PCI_COMMAND_MEMORY : v->vpci.cmd,
-                        !rc && v->vpci.rom_only);
-        spin_unlock(&v->vpci.pdev->vpci->lock);
+        spin_lock(&v->vpci.pdev->vpci_lock);
+        if ( v->vpci.pdev->vpci )
+            /* Disable memory decoding unconditionally on failure. */
+            modify_decoding(v->vpci.pdev,
+                            rc ? v->vpci.cmd & ~PCI_COMMAND_MEMORY : v->vpci.cmd,
+                            !rc && v->vpci.rom_only);
+        spin_unlock(&v->vpci.pdev->vpci_lock);
 
         rangeset_destroy(v->vpci.mem);
         v->vpci.mem = NULL;
@@ -285,6 +286,12 @@ static int modify_bars(const struct pci_dev *pdev, uint16_t cmd, bool rom_only)
                 continue;
         }
 
+        spin_lock(&tmp->vpci_lock);
+        if ( !tmp->vpci )
+        {
+            spin_unlock(&tmp->vpci_lock);
+            continue;
+        }
         for ( i = 0; i < ARRAY_SIZE(tmp->vpci->header.bars); i++ )
         {
             const struct vpci_bar *bar = &tmp->vpci->header.bars[i];
@@ -303,12 +310,14 @@ static int modify_bars(const struct pci_dev *pdev, uint16_t cmd, bool rom_only)
             rc = rangeset_remove_range(mem, start, end);
             if ( rc )
             {
+                spin_unlock(&tmp->vpci_lock);
                 printk(XENLOG_G_WARNING "Failed to remove [%lx, %lx]: %d\n",
                        start, end, rc);
                 rangeset_destroy(mem);
                 return rc;
             }
         }
+        spin_unlock(&tmp->vpci_lock);
     }
 
     ASSERT(dev);
diff --git a/xen/drivers/vpci/msi.c b/xen/drivers/vpci/msi.c
index 5757a7aed20f..e3ce46869dad 100644
--- a/xen/drivers/vpci/msi.c
+++ b/xen/drivers/vpci/msi.c
@@ -270,7 +270,7 @@ void vpci_dump_msi(void)
     rcu_read_lock(&domlist_read_lock);
     for_each_domain ( d )
     {
-        const struct pci_dev *pdev;
+        struct pci_dev *pdev;
 
         if ( !has_vpci(d) )
             continue;
@@ -282,8 +282,13 @@ void vpci_dump_msi(void)
             const struct vpci_msi *msi;
             const struct vpci_msix *msix;
 
-            if ( !pdev->vpci || !spin_trylock(&pdev->vpci->lock) )
+            if ( !spin_trylock(&pdev->vpci_lock) )
                 continue;
+            if ( !pdev->vpci )
+            {
+                spin_unlock(&pdev->vpci_lock);
+                continue;
+            }
 
             msi = pdev->vpci->msi;
             if ( msi && msi->enabled )
@@ -323,7 +328,7 @@ void vpci_dump_msi(void)
                 }
             }
 
-            spin_unlock(&pdev->vpci->lock);
+            spin_unlock(&pdev->vpci_lock);
             process_pending_softirqs();
         }
     }
diff --git a/xen/drivers/vpci/msix.c b/xen/drivers/vpci/msix.c
index 846f1b8d7038..5310cc3ff520 100644
--- a/xen/drivers/vpci/msix.c
+++ b/xen/drivers/vpci/msix.c
@@ -225,7 +225,7 @@ static int msix_read(struct vcpu *v, unsigned long addr, unsigned int len,
         return X86EMUL_OKAY;
     }
 
-    spin_lock(&msix->pdev->vpci->lock);
+    spin_lock(&msix->pdev->vpci_lock);
     entry = get_entry(msix, addr);
     offset = addr & (PCI_MSIX_ENTRY_SIZE - 1);
 
@@ -254,7 +254,7 @@ static int msix_read(struct vcpu *v, unsigned long addr, unsigned int len,
         ASSERT_UNREACHABLE();
         break;
     }
-    spin_unlock(&msix->pdev->vpci->lock);
+    spin_unlock(&msix->pdev->vpci_lock);
 
     return X86EMUL_OKAY;
 }
@@ -297,7 +297,7 @@ static int msix_write(struct vcpu *v, unsigned long addr, unsigned int len,
         return X86EMUL_OKAY;
     }
 
-    spin_lock(&msix->pdev->vpci->lock);
+    spin_lock(&msix->pdev->vpci_lock);
     entry = get_entry(msix, addr);
     offset = addr & (PCI_MSIX_ENTRY_SIZE - 1);
 
@@ -370,7 +370,7 @@ static int msix_write(struct vcpu *v, unsigned long addr, unsigned int len,
         ASSERT_UNREACHABLE();
         break;
     }
-    spin_unlock(&msix->pdev->vpci->lock);
+    spin_unlock(&msix->pdev->vpci_lock);
 
     return X86EMUL_OKAY;
 }
diff --git a/xen/drivers/vpci/vpci.c b/xen/drivers/vpci/vpci.c
index fb0947179b79..c015a4d77540 100644
--- a/xen/drivers/vpci/vpci.c
+++ b/xen/drivers/vpci/vpci.c
@@ -35,12 +35,10 @@ extern vpci_register_init_t *const __start_vpci_array[];
 extern vpci_register_init_t *const __end_vpci_array[];
 #define NUM_VPCI_INIT (__end_vpci_array - __start_vpci_array)
 
-void vpci_remove_device(struct pci_dev *pdev)
+static void vpci_remove_device_locked(struct pci_dev *pdev)
 {
-    if ( !has_vpci(pdev->domain) )
-        return;
+    ASSERT(spin_is_locked(&pdev->vpci_lock));
 
-    spin_lock(&pdev->vpci->lock);
     while ( !list_empty(&pdev->vpci->handlers) )
     {
         struct vpci_register *r = list_first_entry(&pdev->vpci->handlers,
@@ -50,15 +48,26 @@ void vpci_remove_device(struct pci_dev *pdev)
         list_del(&r->node);
         xfree(r);
     }
-    spin_unlock(&pdev->vpci->lock);
     xfree(pdev->vpci->msix);
     xfree(pdev->vpci->msi);
     xfree(pdev->vpci);
     pdev->vpci = NULL;
 }
 
+void vpci_remove_device(struct pci_dev *pdev)
+{
+    if ( !has_vpci(pdev->domain) )
+        return;
+
+    spin_lock(&pdev->vpci_lock);
+    if ( pdev->vpci )
+        vpci_remove_device_locked(pdev);
+    spin_unlock(&pdev->vpci_lock);
+}
+
 int vpci_add_handlers(struct pci_dev *pdev)
 {
+    struct vpci *vpci;
     unsigned int i;
     int rc = 0;
 
@@ -68,12 +77,14 @@ int vpci_add_handlers(struct pci_dev *pdev)
     /* We should not get here twice for the same device. */
     ASSERT(!pdev->vpci);
 
-    pdev->vpci = xzalloc(struct vpci);
-    if ( !pdev->vpci )
+    vpci = xzalloc(struct vpci);
+    if ( !vpci )
         return -ENOMEM;
 
-    INIT_LIST_HEAD(&pdev->vpci->handlers);
-    spin_lock_init(&pdev->vpci->lock);
+    INIT_LIST_HEAD(&vpci->handlers);
+
+    spin_lock(&pdev->vpci_lock);
+    pdev->vpci = vpci;
 
     for ( i = 0; i < NUM_VPCI_INIT; i++ )
     {
@@ -83,7 +94,8 @@ int vpci_add_handlers(struct pci_dev *pdev)
     }
 
     if ( rc )
-        vpci_remove_device(pdev);
+        vpci_remove_device_locked(pdev);
+    spin_unlock(&pdev->vpci_lock);
 
     return rc;
 }
@@ -152,8 +164,6 @@ int vpci_add_register(struct vpci *vpci, vpci_read_t *read_handler,
     r->offset = offset;
     r->private = data;
 
-    spin_lock(&vpci->lock);
-
     /* The list of handlers must be kept sorted at all times. */
     list_for_each ( prev, &vpci->handlers )
     {
@@ -165,14 +175,12 @@ int vpci_add_register(struct vpci *vpci, vpci_read_t *read_handler,
             break;
         if ( cmp == 0 )
         {
-            spin_unlock(&vpci->lock);
             xfree(r);
             return -EEXIST;
         }
     }
 
     list_add_tail(&r->node, prev);
-    spin_unlock(&vpci->lock);
 
     return 0;
 }
@@ -183,7 +191,6 @@ int vpci_remove_register(struct vpci *vpci, unsigned int offset,
     const struct vpci_register r = { .offset = offset, .size = size };
     struct vpci_register *rm;
 
-    spin_lock(&vpci->lock);
     list_for_each_entry ( rm, &vpci->handlers, node )
     {
         int cmp = vpci_register_cmp(&r, rm);
@@ -195,14 +202,12 @@ int vpci_remove_register(struct vpci *vpci, unsigned int offset,
         if ( !cmp && rm->offset == offset && rm->size == size )
         {
             list_del(&rm->node);
-            spin_unlock(&vpci->lock);
             xfree(rm);
             return 0;
         }
         if ( cmp <= 0 )
             break;
     }
-    spin_unlock(&vpci->lock);
 
     return -ENOENT;
 }
@@ -311,7 +316,7 @@ static uint32_t merge_result(uint32_t data, uint32_t new, unsigned int size,
 uint32_t vpci_read(pci_sbdf_t sbdf, unsigned int reg, unsigned int size)
 {
     const struct domain *d = current->domain;
-    const struct pci_dev *pdev;
+    struct pci_dev *pdev;
     const struct vpci_register *r;
     unsigned int data_offset = 0;
     uint32_t data = ~(uint32_t)0;
@@ -327,7 +332,12 @@ uint32_t vpci_read(pci_sbdf_t sbdf, unsigned int reg, unsigned int size)
     if ( !pdev )
         return vpci_read_hw(sbdf, reg, size);
 
-    spin_lock(&pdev->vpci->lock);
+    spin_lock(&pdev->vpci_lock);
+    if ( !pdev->vpci )
+    {
+        spin_unlock(&pdev->vpci_lock);
+        return vpci_read_hw(sbdf, reg, size);
+    }
 
     /* Read from the hardware or the emulated register handlers. */
     list_for_each_entry ( r, &pdev->vpci->handlers, node )
@@ -370,7 +380,7 @@ uint32_t vpci_read(pci_sbdf_t sbdf, unsigned int reg, unsigned int size)
             break;
         ASSERT(data_offset < size);
     }
-    spin_unlock(&pdev->vpci->lock);
+    spin_unlock(&pdev->vpci_lock);
 
     if ( data_offset < size )
     {
@@ -414,7 +424,7 @@ void vpci_write(pci_sbdf_t sbdf, unsigned int reg, unsigned int size,
                 uint32_t data)
 {
     const struct domain *d = current->domain;
-    const struct pci_dev *pdev;
+    struct pci_dev *pdev;
     const struct vpci_register *r;
     unsigned int data_offset = 0;
     const unsigned long *ro_map = pci_get_ro_map(sbdf.seg);
@@ -440,7 +450,14 @@ void vpci_write(pci_sbdf_t sbdf, unsigned int reg, unsigned int size,
         return;
     }
 
-    spin_lock(&pdev->vpci->lock);
+    spin_lock(&pdev->vpci_lock);
+    if ( !pdev->vpci )
+    {
+        spin_unlock(&pdev->vpci_lock);
+        vpci_write_hw(sbdf, reg, size, data);
+        return;
+    }
+
 
     /* Write the value to the hardware or emulated registers. */
     list_for_each_entry ( r, &pdev->vpci->handlers, node )
@@ -475,7 +492,7 @@ void vpci_write(pci_sbdf_t sbdf, unsigned int reg, unsigned int size,
             break;
         ASSERT(data_offset < size);
     }
-    spin_unlock(&pdev->vpci->lock);
+    spin_unlock(&pdev->vpci_lock);
 
     if ( data_offset < size )
         /* Tailing gap, write the remaining. */
diff --git a/xen/include/xen/pci.h b/xen/include/xen/pci.h
index b6d7e454f814..3f60d6c6c6dd 100644
--- a/xen/include/xen/pci.h
+++ b/xen/include/xen/pci.h
@@ -134,6 +134,7 @@ struct pci_dev {
     u64 vf_rlen[6];
 
     /* Data for vPCI. */
+    spinlock_t vpci_lock;
     struct vpci *vpci;
 };
 
diff --git a/xen/include/xen/vpci.h b/xen/include/xen/vpci.h
index 3f32de9d7eb3..d06efc3cea46 100644
--- a/xen/include/xen/vpci.h
+++ b/xen/include/xen/vpci.h
@@ -31,7 +31,7 @@ int __must_check vpci_add_handlers(struct pci_dev *dev);
 /* Remove all handlers and free vpci related structures. */
 void vpci_remove_device(struct pci_dev *pdev);
 
-/* Add/remove a register handler. */
+/* Add/remove a register handler. Must be called holding the vpci_lock. */
 int __must_check vpci_add_register(struct vpci *vpci,
                                    vpci_read_t *read_handler,
                                    vpci_write_t *write_handler,
@@ -60,7 +60,6 @@ bool __must_check vpci_process_pending(struct vcpu *v);
 struct vpci {
     /* List of vPCI handlers for a device. */
     struct list_head handlers;
-    spinlock_t lock;
 
 #ifdef __XEN__
     /* Hide the rest of the vpci struct from the user-space test harness. */
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Tue Feb 01 16:25:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 01 Feb 2022 16:25:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.263631.456423 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEvy0-0005LQ-2U; Tue, 01 Feb 2022 16:25:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 263631.456423; Tue, 01 Feb 2022 16:25:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEvxz-0005LJ-Sw; Tue, 01 Feb 2022 16:25:15 +0000
Received: by outflank-mailman (input) for mailman id 263631;
 Tue, 01 Feb 2022 16:25:14 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=scQ7=SQ=gmail.com=andr2000@srs-se1.protection.inumbo.net>)
 id 1nEvxx-0005Kx-R9
 for xen-devel@lists.xenproject.org; Tue, 01 Feb 2022 16:25:14 +0000
Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com
 [2a00:1450:4864:20::12f])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 86e4b828-837b-11ec-8f75-fffcc8bd4f1a;
 Tue, 01 Feb 2022 17:25:11 +0100 (CET)
Received: by mail-lf1-x12f.google.com with SMTP id u14so34939759lfo.11
 for <xen-devel@lists.xenproject.org>; Tue, 01 Feb 2022 08:25:11 -0800 (PST)
Received: from a2klaptop.localdomain ([185.199.97.5])
 by smtp.gmail.com with ESMTPSA id z20sm2037887ljn.92.2022.02.01.08.25.08
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 01 Feb 2022 08:25:09 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 86e4b828-837b-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=Z8QBBgxgg9jgM5JlU/AFTcZzdzBI1+RHxwbZNGkSfGo=;
        b=HHoWplrH2/O/gS5JyrlfY6uF2nC+pDWqd0ZCSbiL2yHExvT3dYcp/oz90ASFwPv/eN
         L8WalXDH+Xog521RaTmxFLe5bVcmtp6BsGLL96m+uGRC5x6bNzrhbBiKKcbA9xt+1/hb
         anpF04WjrdAx5vUFpQhjHqKqNO7Kt2csUaki8Hyk1tUI8lfOwLDoQjUSQeNEWr7Nq7Fe
         70pcC0l+o/nu+HZNX/u7dxDKOjlq1Dh3mRQ8CC15g8fesrg8jCDs+bodVlJd/oV/ulDi
         EjPhEs7c55MVw29NFAeDgK8OQJVdeJa3CW+nGHpFgF8DaYmmTid3oMy2mikTjnyUnPH+
         Av9w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=Z8QBBgxgg9jgM5JlU/AFTcZzdzBI1+RHxwbZNGkSfGo=;
        b=4z3UpNFuGXikEi8Al8P+vBn6jqAMOcp7bDY0c16AVsbNtWzYBzNJ8DnVUkiczKonEo
         ZTv37aa+xeprPL/dvyxlhIIohoy+LOvuP6gE46MiI4GzYdjOVsxsTckyJ8hvVYzckeKv
         u8C8KsF6/C5MfMMUED/XYCQCbYRYYXSBXDRYPXvjESvgznGBUqDe43mcV65dj0/pOyJx
         Iny3m2DQAJPJ3XleeQfTXGHMaqOZHKD0TvKovGRD/2+TALA57pN42pnClmrhDnlDprqc
         kk/h7jQBwa4ok0NTHFEgGFsqwTZMMptOYXsDf4TRtF5kDm9sSqnopOBbR/5bZYVSIvpE
         zOCg==
X-Gm-Message-State: AOAM533YcXumJ1KnFvwAYoG5wBgeeCdhiT+MKNwkblRc4X2R2QYXBvfd
	r4oDszrK+0t8tmRFvvEf6OozOtbSU3g=
X-Google-Smtp-Source: ABdhPJwWYeejKik/e10L3fDwQBEbCw1OKIZ2T71/9ruvwRRi087u1uu4sUMq3x/b1X0MFIyTZZ/gbA==
X-Received: by 2002:a05:6512:32c5:: with SMTP id f5mr14848277lfg.361.1643732710909;
        Tue, 01 Feb 2022 08:25:10 -0800 (PST)
From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	sstabellini@kernel.org,
	oleksandr_tyshchenko@epam.com,
	volodymyr_babchuk@epam.com,
	Artem_Mygaiev@epam.com,
	roger.pau@citrix.com,
	jbeulich@suse.com,
	andrew.cooper3@citrix.com,
	george.dunlap@citrix.com,
	paul@xen.org,
	bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: [PATCH 0/4] PCI devices passthrough pre-req patches
Date: Tue,  1 Feb 2022 18:25:04 +0200
Message-Id: <20220201162508.417008-1-andr2000@gmail.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

Hi, all!

While working on vPCI series [1] I have created number of patches that
either add some useful helpers or serve as the ground for the upcoming
vPCI changes or both.

To ease the task of reviewing the bigger vPCI series I am sending these
now with the hope they can be accepted.

I would like to thank Roger and Jan for providing valuable comments and
ideas, some of which have materialized here.

Thank you,
Oleksandr

[1] https://patchwork.kernel.org/project/xen-devel/list/?series=585781

Oleksandr Andrushchenko (3):
  rangeset: add RANGESETF_no_print flag
  rangeset: add rangeset_reset helper function
  vpci: shrink critical section in vpci_{read/write}

Roger Pau Monne (1):
  vpci: move lock outside of struct vpci

 tools/tests/vpci/emul.h       |  5 ++-
 tools/tests/vpci/main.c       |  4 +--
 xen/arch/x86/hvm/vmsi.c       |  8 ++---
 xen/common/rangeset.c         | 11 +++++-
 xen/drivers/passthrough/pci.c |  1 +
 xen/drivers/vpci/header.c     | 21 ++++++++----
 xen/drivers/vpci/msi.c        | 11 ++++--
 xen/drivers/vpci/msix.c       |  8 ++---
 xen/drivers/vpci/vpci.c       | 64 ++++++++++++++++++++++-------------
 xen/include/xen/pci.h         |  1 +
 xen/include/xen/rangeset.h    |  8 +++--
 xen/include/xen/vpci.h        |  3 +-
 12 files changed, 94 insertions(+), 51 deletions(-)

-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Tue Feb 01 16:47:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 01 Feb 2022 16:47:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.263670.456485 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEwJa-0001nt-Od; Tue, 01 Feb 2022 16:47:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 263670.456485; Tue, 01 Feb 2022 16:47:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEwJa-0001n4-GA; Tue, 01 Feb 2022 16:47:34 +0000
Received: by outflank-mailman (input) for mailman id 263670;
 Tue, 01 Feb 2022 16:47:33 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JAuK=SQ=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nEwJZ-0001jp-OE
 for xen-devel@lists.xenproject.org; Tue, 01 Feb 2022 16:47:33 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a4a4127d-837e-11ec-8eb8-a37418f5ba1a;
 Tue, 01 Feb 2022 17:47:31 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a4a4127d-837e-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1643734051;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:content-transfer-encoding:mime-version;
  bh=u1dO4eBn55di1Lq/HhuItdj6kXzHCzDMo02+M+HL1Is=;
  b=GEXyZXXpbQB8iPefXO+3Hohx1BGBte4GX2IjyACJ4HinwTOGlyQH4ESS
   p44xSPrteRDy7lYPCL6LgaXIgWLDzyli7EhsaBkNPP0pKK3FL5z1rdjJV
   pkiGwKaxgf6RLLDXYC8tAVjP0jzi2H+Yt/NeDczG/sU4X4HP4PA3CsI2D
   A=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: xKtRs4ZYUrK/c+bq0gfX4sZbj+6/mKsP0jxfg61r8htriJsrG0stG9YbJzKKN2daRSOQ6gCSBS
 daSKPakW4vjEqru3uM58aIqXCkexGD8QDf78v/RHLKgkOTHiPPAMw5xebrEnrapoXvLD5q46Bv
 wsE7cjgA4q3gIr2LOMpLEeTizhMOOHvme+a3xaL+hYG2n6lJbxCNqPtYF3bR6d9xPeG7Yb8tXi
 JXg2wqkBaEb3SWYsheApnuB4aCBaEYi/QMGjCYH8sougOIgFKA0WC7I84ut3rvJN5EIoChJCjv
 sleRlMEXzobiUdlXJ4tPaS6U
X-SBRS: 5.2
X-MesageID: 65424817
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:kXljwKJcnOEdMy9uFE+RN5IlxSXFcZb7ZxGr2PjKsXjdYENSg2QGm
 2FLCz3Sb62KYWWmfdxxPIzjoRwFu5fWnNQxGgNlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokcxIn5BC5C5xZVG/fjgqoHUVaiUakideSc+EH170Ug7wrZj6mJVqYPR7z2l6
 IuaT/L3YDdJ6xYsWo7Dw/vewP/HlK2aVAIw5jTSV9gS1LPtvyB94KYkDbOwNxPFrrx8RYZWc
 QphIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbrGvaUXe345iXMfwZ3u7hB21wttR5
 OcOiqahYi0FP5DLweE5dSVHRnQW0a1uoNcrIFC6uM2XiUbHb2Ht07NlC0Re0Y8wo7gtRzsUr
 LpBdW5LPkvra+GemdpXTsF2gcsuNo/zNZ43sXB81zDJS/0hRPgvRo2UuIMCgGdp2aiiG97vI
 JUwOR9maS+bPQxxORQ1Aqsfkdan0yyXnzpw9wvO+PtfD3Lo5BN1+KjgNpzSYNPibcdfk1ucp
 2nG13/kGRxcP9uaoRKV/3TpiuLRkCfTXIMJCKb+5vNsmEeUxGEYFFsRT1TTnBWiohfgAZQFc
 RVSo3dw6/hpnKC2cjXjdyHlq16ojF0jYct7OcE71QbUz47y3xnMUwDoUQV9QNAhscY3Qxkj2
 VmIg87lCFRTjVGFdZ6O3uzK9G3vYED5OUdHPHZZFlVdv7EPtalu1kqnczp1LEKiYjQZ8xnUy
 ivCkiUxjq57YSUjh/TipgCvb95BS/H0ou8JCuf/AzjNAuBRPtfNi2mUBb7zt6wowGGxFQHpg
 ZT8s5LChN3i9LnU/MB3fM0DHauy+9GOOyDGjFhkEvEJrmrxoCPzItgAvmAidS+F1/ronxezO
 ic/XisKvPdu0IaCN/crM+pd9ex3pUQfKTgVfq+NNYcfCnSAXASG4DtvdSatM5PFyyARfVUEE
 c7DK66EVC9CYYw+lWbeb7pDjdcDm35vrUuOFcGT50n2itK2OS/KIYrpxXPTNIjVGove/lWMm
 zueXuPXoyhivBrWOXiKqNNDcAxRcBDWx/ne8qRqSwJKGSI/cEkJAP7N27IxPYtjmqVejODT+
 X+hHERfzTLCabfvcG1ms1hvN+HiW4hRt3U+MXB+NFqkwSF7M42u8L0eZ908erx+rL5vyvt9T
 v8kfcScA6sQFmSbqmpFNZSt/pZ/cBmLhB6VO3b3ajYIYJM9FRfC/cXpf1Wz+XBWXDa3r8Y3v
 5apyhjfHcgYXw1nAcuPMKCvwlq9sGIzguV3W0eUcNBfdF+1qNphKjDrj+9xKMYJcE2Ryjyf3
 geQIBEZueiS/NNlrIiX3fiJ9t77HfF/E0xWG3jgwYy3bSSKrHC+xYJgUfqTeWyPXm3D56j/N
 /5eyOvxMaNbkQ8S4ZZ8Cbti0Yk3+8Dr++1B1g1hEXjGMwarB7dnLiXU1MVDrPQQlLpQuA/wU
 UOT4NhKf76OPZq9QlIWIQMkaMWF1O0VxWaOvahkfh2i6X8l5qeDXGVTIwKI2X5UI7ZCOY84x
 fss5ZwN4Aulhxt2atuLg0i4LYhXwqDsh0n/iqwnPQ==
IronPort-HdrOrdr: A9a23:tUIRvKBdTNCFMs/lHeg0sceALOsnbusQ8zAXPh9KJiC9I/b1qy
 nxppkmPH/P6Qr4WBkb6LS90c67MA/hHP9OkPQs1NKZMjUO11HYSr2KgbGSoQEIXheOjdK1tp
 0QApSWaueAdGSS5PySiGLTc6dC/DDEytHTuQ639QYScegAUdAG0+4WMHf/LqUgLzM2eqbRWa
 DsrfZvln6FQzA6f867Dn4KU6zqoMDKrovvZVojCwQ84AeDoDu04PqieiLokys2Yndq+/MP4G
 LFmwv26uGKtOy68AbV0yv2445NkNXs59NfDIini9QTKB/rlgG0Db4REYGqjXQQmqWC+VwqmN
 7Dr1MJONly0WrYeiWPrR7ky2DboUATwk6n7WXdrWrooMT/Sj5/IdFGn5hlfhzQ7FdllM1g0Y
 pQtljp+aZ/PFflpmDQ9tLIXxZlmg6funw5i9MeiHRZTM83dKJRl4oC50lYea1wUx4S0LpXUN
 WGMfusp8q/KTihHjLkVyhUsZCRt00Ib1a7qhNogL3R79BU9EoJuHfwivZv2kvoz6hNOKWs0d
 60RpiApIs+PvP+UpgNdtvpOfHHclAlYSi8eV56cm6XXJ3uBRr22uvKCfMOlaaXRKA=
X-IronPort-AV: E=Sophos;i="5.88,334,1635220800"; 
   d="scan'208";a="65424817"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=AMeEUCwpWK9VZ+B236nOArdUl6nrYP3ltdqTTEANMOqmH3W2cz8m5NmawTyNyyEmVUxSPFe5iKcAW0CAq82BPD4dnj1VqQlPhr8kwDEEM3/gBbcs8Rtd+Vs9+WrwOlrdKot9zGNpmNiSZX3ghx/0AePs0h4MlL4QciIrCRs/kPcKvHcM2XEqKooRoD4obgnwZtG35HFp6DpT9GbXDEPUzNeQaKEAvnY+HiRHresAkVaZV36SbMmUw4jbcH+J3bwbxzkt8UqTIhRgA0vjkrMxB2Is5ME37JegfYHvy6nJMyCxf3hv+idWRtgjBmsoYIMkx0duWJK39ybp9bPWohtJ8Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=mABKGaVPSIVWoLQWeWEbnGj7m8sKHrppce4L4FKSrdE=;
 b=Gjx12Yj5rG9iIf5XFm39PgaUQ+Rd3WwFX+p173qM4sAl6obYeutKggPc/WY5CgjShYcuV8tPpZNSZbfuCIoV2YftQY1Bq176TyD7b4ozIDL+oie4LXCWVIewk0cU0ta3T2xvV17latpYBctM4t1yNjqkwSm8p/9pyGKy9wdCU9s0DZGZaWqgs9xoLGuJWUsKd8h6oeTvkxDbgIrn2kqo4NUs6njgDnjAJY91HPk0Z3Dam0Q0FEyIcv2ACPGpuZroKJivoOlpBver4lsR9QFTpjbzwP8eNIyVWxMsTenAOX3BAiLBiUgBsPm89uRzbvRdUdY7YdDLi5ASWvMsibia1w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=mABKGaVPSIVWoLQWeWEbnGj7m8sKHrppce4L4FKSrdE=;
 b=cikYRLEVNyli3+/4ITSeTXLE3jQlvS41VI90NwUEgo0hNd7YGIxcdCuNzKIKcQ7YV1jRJp6idsVVECTytIsBTeHTbL0BlTP0LRiZRN7VqC2ybI9GFeDgZIAHpbJNnCc4IFJl518nTI0aUc0PC6D62uhg/wVJFK81urxGXVhuC8U=
From: Roger Pau Monne <roger.pau@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Roger Pau Monne <roger.pau@citrix.com>, Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: [PATCH 2/3] amd/msr: allow passthrough of VIRT_SPEC_CTRL for HVM guests
Date: Tue,  1 Feb 2022 17:46:50 +0100
Message-ID: <20220201164651.6369-3-roger.pau@citrix.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220201164651.6369-1-roger.pau@citrix.com>
References: <20220201164651.6369-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO4P123CA0355.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:18d::18) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e7ac55c3-fec0-4875-3fba-08d9e5a286a2
X-MS-TrafficTypeDiagnostic: SN6PR03MB3565:EE_
X-Microsoft-Antispam-PRVS: <SN6PR03MB3565532E89C9BF1F8629206C8F269@SN6PR03MB3565.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: m0MAStdqIH/um8T17wRymbIvjhBnUCGbQCBc5UeUSTCMgfe9xKO12r8QI0euI4n1gRz1+43HGEUEFSmRyycoL1crX9UckgU7mAqH8cyg6cTymZJTBTAGhO14JQjZK4J68qtIkyHTH0C5xwTj/jt4FfL708z3SFDNY1Kkt19ApfWva1qBnrV8bEfYCV7GOrtNZZh0u485XkR3c2cd9TmImjcJVV7WLTAnTsdwgYU0IDzLhQf75iUSFNkkYymGJAlX402crOuXlbkLd2QtTLLKgCLYIwAsbKQRYPtN6HXmb9WhFhB54kyAfNaRKLjgVQzR0e+wzsgxA8vXw3SpACf0VPY/SpMintOe0XvA5mCdwaLv5N34v8Wx5eCOr7u4Dd2tIVxTkEJIV+xOZ0Z9e2KVxMnoV3okOWNgAwyaClSFmWJWRCIB4kKvXH1UMBNLrwRCph1X09qJVUDnnconDZS+JtNxU1r3yo7Khh6hLHnsa0jVWutVx3RwZReo+u7h1EQNejOq7YBr60whmpDrxcyEjQ6odg9owcQkp/VJJ5QGxCELAd/qezHVC8Buis8lT4SmEYFTmHdFoRPN9oEhQ8p2Lu57ZxHsbcxqvDywRzEONbY4ZZEOM4E5HEi2lCTGdzerA0O9gPYMiZfxZJyiiTxzqw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6666004)(66476007)(66946007)(8936002)(4326008)(8676002)(508600001)(5660300002)(66556008)(6486002)(38100700002)(83380400001)(6506007)(36756003)(6916009)(82960400001)(6512007)(26005)(86362001)(1076003)(186003)(2616005)(2906002)(54906003)(316002)(20210929001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZWNpb290d3dSamR6WCtOZFExazhpZFgwTnVjZXBKWjZ1VlltS3A1YThSa0lv?=
 =?utf-8?B?K2pFWmNxcGhPbTVrRnk4TkRzNG9tYTZlaytsMkRJQVhWQW5DdCtCZVErUGR0?=
 =?utf-8?B?MkhHcjI5VUg1ZEgxajliU2VHOVJrUXJ1L2tJV0FaNnp1SU5hREt4L25zTTl6?=
 =?utf-8?B?aEs1WkRLSEpDSWl6S2I0WkF5OW13ZG1iMVNaVjdXc2dDNU1WbTE1dzd1Rm9Z?=
 =?utf-8?B?M1RXZ2drRGo0NlZ4ZUlPcHcwVGU5ZUVFNGxsV3JzNGd4UGFwYWRNV01JL1Rj?=
 =?utf-8?B?eU00ZVMrWTVTU0w3c2NFb1FZS0JlcklhZHVFak1XRDZTOTRhdlEzS3RRcEpQ?=
 =?utf-8?B?RjROOHZmcHFpOFR5Q2FML2lpU0VsSmZSRVNVdjJDdFhFWEFERTNGc0srNFpH?=
 =?utf-8?B?d2g0am5OM3cvYVBGMGEvZ2J6QUlaN2JjSUJ0L3Y2VmNRYUhDblhrdlpjL2lk?=
 =?utf-8?B?aVJBWk5ucG0xZW1aSENJVDFyR3MrNzd0Z05MSi8xU1RLVThWZW9qZWl2R1lu?=
 =?utf-8?B?ZkxwNnFpTzBkUWRBTndjODI3cmNzVlV6MmJDVWFUUVRobEM2VDZMdk1ENzNE?=
 =?utf-8?B?d2pVbXN5cHp1cW9CV3FFNU9tT0EwMHBVZTVIWm11bHg5Q1ZQQ09RQnE4V0JE?=
 =?utf-8?B?MDh3dkc2Yy9DcXNsNE55Z2VrcVlkT3VJc0tmZ2V2TkkxYlUxV1R6MmJCNjg0?=
 =?utf-8?B?dkZpSEc0ZzhZZ0t5NGNoejI3YlNUWVlqYnd0Z0dvK05wbWFFY0hwOUN4bkZ0?=
 =?utf-8?B?V3gvcEJNSlcyZFUzRFFzQnlCQTNhSEVpd3RiWDRsN3VjOENrdUdZNWZRNzRK?=
 =?utf-8?B?aVExdmppc2RWZXFScVpnWWxvbjdjbXo1Y3J3aU16N2ZOTGdKQm1DckxQQTVP?=
 =?utf-8?B?RnFGUkc0bFZ4TENqWmwranpWUy9FVitGeTZSU0R6SE1OeUZLNmJEOGQ5aUNQ?=
 =?utf-8?B?N1RoaUpXbTZpcVZGY3dreXNDVGdvcnZmS1I2cnR5cEhIR0J5eFdVRVp0M2Zt?=
 =?utf-8?B?VjdoRGdIdXYvR1g3czlqeWVkRlRWOTk0U1FaNnpUZ2lKZjdJbUQ0U1pmZTBJ?=
 =?utf-8?B?Vyt5aXFaSC8zVHptTXFsbmIwYzYzRjZHdmR1U2VIRk0vaWdJZDY5RmVEbXB3?=
 =?utf-8?B?b0xSNDZwVnJCZTNzSE45eHF1REYrSmZwQVl2dVdFK1FQQTE4M1F1UmNiSWFH?=
 =?utf-8?B?eDlrLyt1TzFqTUxKZ3RGS2p3Zm5DWUkwZHhOczNsNGs0aUhybDdDTjVEU0tX?=
 =?utf-8?B?dDJoTWFCZkNPbVMzUzJwNEViZERvQWplQmtnU1VBMmZWdnpFNzNobExLbGxQ?=
 =?utf-8?B?WGJjaDJHTUk4VEFVc2xhWFB6VW5heEh2dHpMdnhRZndPei95VWR1Yyt5ajZ6?=
 =?utf-8?B?bmpmU0dQN1ZYeE1hRmVUUWJlcUp5QzVnTVU2UU03VDhYUk1ZNi9LYk9GQXE4?=
 =?utf-8?B?VWZOZFQvL2g4MUdDQXZ0TVRNL05yOFF3K0JwMjhRbUhvdXRzMmRVaDRNTTZZ?=
 =?utf-8?B?NUErc3RrUHBEUVJFazlWQ1F1TjhZY2V5UFloZS90QnU3MlFlL2VWWlRxSXp2?=
 =?utf-8?B?ZmRCMERUTHlKa1VnTVVVK2ViNGdTMmxwTVV3dlNYbVZCSFRBaHZvRG5yY3Mw?=
 =?utf-8?B?SGVvUVRTMDAwcE9xT1RCKzJnNUdxd21pR1dyUUtRM0E1YS9yczZmUFpONzgv?=
 =?utf-8?B?WDdPQ0ZFSE91Qkg3UE82OW1HaWYvSENZOHJoTWpXSU9VV3J5V0t5NjZRbmhD?=
 =?utf-8?B?dUxZbkhibm8xTzdDS2MrYVkzN3ZvdkpjNi81N1kzTUVDVERhcWw1c05SYjdJ?=
 =?utf-8?B?NU9yNThlTjNPZWoxdmY0VzQyU0ZjQTY5M05CRy8reU5FL2cwZFhhd0tJanJo?=
 =?utf-8?B?MHZ1cUZoUDltbjQzRXgvRHdqQ3lsMU5vUGNrZVY3dURWY0JxK3M5enFFdy9t?=
 =?utf-8?B?YTIvNWJJTnRPbDFPZlZzNkpURkVVbVliNW16ajVjdCtJWVRobGhMdnNYMXVN?=
 =?utf-8?B?T0U1aXlPVnlMQ1ViL05TVU84ejdNbDE3aHlqOEkvL3gvTEwzanhYUTZlT2gv?=
 =?utf-8?B?UlhKR0orT0JmOG15QVc1NmVBUDhna0VBTnhueTd3ZzBhbDhGaDEyS2E1ZXFJ?=
 =?utf-8?B?ZUxta0NTU3JzNU5IY1BYOXJjdEJXVnF5SENHdHRZM2FJZmp6Sm1vQ3FqMHFL?=
 =?utf-8?Q?Mvwp8eqG09doXyJm4/ieH5k=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e7ac55c3-fec0-4875-3fba-08d9e5a286a2
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2022 16:47:25.7284
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UC8rz0vPzWgSc1o/xPRDe7TcCIOcUnvYgnBRPbkR/H2G2EIpp+Ggt2DI1OX1EI3Am+MPShsxS4XON875wPT7Gw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR03MB3565
X-OriginatorOrg: citrix.com

Allow HVM guests untrapped access to MSR_VIRT_SPEC_CTRL if the
hardware has support for it. This requires adding logic in the
vm{entry,exit} paths for SVM in order to context switch between the
hypervisor value and the guest one. The added handlers for context
switch will also be used for the legacy SSBD support.

Note that the implementation relies on storing the guest value in the
spec_ctrl MSR per-vCPU variable, as the usage of VIRT_SPEC_CTRL
precludes the usage of SPEC_CTRL. Also store the current and
hypervisor states of VIRT_SPEC_CTRL in the per-pCPU spec_ctrl fields
at cpu_info in order to properly context switch the values between
Xen and HVM guests.

Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
 xen/arch/x86/cpu/amd.c                 |  7 +++-
 xen/arch/x86/cpuid.c                   | 11 ++++++
 xen/arch/x86/hvm/svm/entry.S           |  8 +++-
 xen/arch/x86/hvm/svm/svm.c             | 55 ++++++++++++++++++++++++++
 xen/arch/x86/include/asm/cpufeatures.h |  1 +
 xen/arch/x86/spec_ctrl.c               |  8 +++-
 6 files changed, 86 insertions(+), 4 deletions(-)

diff --git a/xen/arch/x86/cpu/amd.c b/xen/arch/x86/cpu/amd.c
index a8e37dbb1f..c3fcc0e558 100644
--- a/xen/arch/x86/cpu/amd.c
+++ b/xen/arch/x86/cpu/amd.c
@@ -687,6 +687,7 @@ void amd_init_lfence(struct cpuinfo_x86 *c)
  */
 void amd_init_ssbd(const struct cpuinfo_x86 *c)
 {
+	struct cpu_info *info = get_cpu_info();
 	int bit = -1;
 
 	if (cpu_has_ssb_no)
@@ -699,7 +700,7 @@ void amd_init_ssbd(const struct cpuinfo_x86 *c)
 
 	if (cpu_has_virt_ssbd) {
 		wrmsrl(MSR_VIRT_SPEC_CTRL, opt_ssbd ? SPEC_CTRL_SSBD : 0);
-		return;
+		goto out;
 	}
 
 	switch (c->x86) {
@@ -729,6 +730,10 @@ void amd_init_ssbd(const struct cpuinfo_x86 *c)
 
 	if (bit < 0)
 		printk_once(XENLOG_ERR "No SSBD controls available\n");
+
+ out:
+	info->last_spec_ctrl = info->xen_spec_ctrl = opt_ssbd ? SPEC_CTRL_SSBD
+							      : 0;
 }
 
 void __init detect_zen2_null_seg_behaviour(void)
diff --git a/xen/arch/x86/cpuid.c b/xen/arch/x86/cpuid.c
index 29b4cfc9e6..7b10fbf12f 100644
--- a/xen/arch/x86/cpuid.c
+++ b/xen/arch/x86/cpuid.c
@@ -551,6 +551,9 @@ static void __init calculate_hvm_max_policy(void)
          */
         __set_bit(X86_FEATURE_VIRT_SSBD, hvm_featureset);
 
+    if ( boot_cpu_has(X86_FEATURE_VIRT_SC_MSR_HVM) )
+        __set_bit(X86_FEATURE_VIRT_SSBD, hvm_featureset);
+
     /*
      * With VT-x, some features are only supported by Xen if dedicated
      * hardware support is also available.
@@ -590,6 +593,14 @@ static void __init calculate_hvm_def_policy(void)
     guest_common_feature_adjustments(hvm_featureset);
     guest_common_default_feature_adjustments(hvm_featureset);
 
+    /*
+     * Only expose VIRT_SPEC_CTRL support by default if SPEC_CTRL is not
+     * supported.
+     */
+    if ( boot_cpu_has(X86_FEATURE_VIRT_SC_MSR_HVM) &&
+         !boot_cpu_has(X86_FEATURE_SC_MSR_HVM) )
+        __set_bit(X86_FEATURE_VIRT_SSBD, hvm_featureset);
+
     sanitise_featureset(hvm_featureset);
     cpuid_featureset_to_policy(hvm_featureset, p);
     recalculate_xstate(p);
diff --git a/xen/arch/x86/hvm/svm/entry.S b/xen/arch/x86/hvm/svm/entry.S
index 4ae55a2ef6..2a0c41625b 100644
--- a/xen/arch/x86/hvm/svm/entry.S
+++ b/xen/arch/x86/hvm/svm/entry.S
@@ -71,7 +71,9 @@ __UNLIKELY_END(nsvm_hap)
             mov    %al, CPUINFO_last_spec_ctrl(%rsp)
 1:          /* No Spectre v1 concerns.  Execution will hit VMRUN imminently. */
         .endm
-        ALTERNATIVE "", svm_vmentry_spec_ctrl, X86_FEATURE_SC_MSR_HVM
+        ALTERNATIVE_2 "", STR(call vmentry_virt_spec_ctrl), \
+                          X86_FEATURE_VIRT_SC_MSR_HVM, \
+                      svm_vmentry_spec_ctrl, X86_FEATURE_SC_MSR_HVM
 
         pop  %r15
         pop  %r14
@@ -111,7 +113,9 @@ __UNLIKELY_END(nsvm_hap)
             wrmsr
             mov    %al, CPUINFO_last_spec_ctrl(%rsp)
         .endm
-        ALTERNATIVE "", svm_vmexit_spec_ctrl, X86_FEATURE_SC_MSR_HVM
+        ALTERNATIVE_2 "", STR(call vmexit_virt_spec_ctrl), \
+                          X86_FEATURE_VIRT_SC_MSR_HVM, \
+                      svm_vmexit_spec_ctrl, X86_FEATURE_SC_MSR_HVM
         /* WARNING! `ret`, `call *`, `jmp *` not safe before this point. */
 
         stgi
diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c
index c4ce3f75ab..56c7b30b32 100644
--- a/xen/arch/x86/hvm/svm/svm.c
+++ b/xen/arch/x86/hvm/svm/svm.c
@@ -610,6 +610,14 @@ static void svm_cpuid_policy_changed(struct vcpu *v)
     svm_intercept_msr(v, MSR_SPEC_CTRL,
                       cp->extd.ibrs ? MSR_INTERCEPT_NONE : MSR_INTERCEPT_RW);
 
+    /*
+     * Give access to MSR_VIRT_SPEC_CTRL if the guest has been told about it
+     * and the hardware implements it.
+     */
+    svm_intercept_msr(v, MSR_VIRT_SPEC_CTRL,
+                      cp->extd.virt_ssbd && cpu_has_virt_ssbd ?
+                      MSR_INTERCEPT_NONE : MSR_INTERCEPT_RW);
+
     /* Give access to MSR_PRED_CMD if the guest has been told about it. */
     svm_intercept_msr(v, MSR_PRED_CMD,
                       cp->extd.ibpb ? MSR_INTERCEPT_NONE : MSR_INTERCEPT_RW);
@@ -3099,6 +3107,53 @@ void svm_vmexit_handler(struct cpu_user_regs *regs)
     vmcb_set_vintr(vmcb, intr);
 }
 
+/* Called with GIF=0. */
+void vmexit_virt_spec_ctrl(void)
+{
+    struct cpu_info *info = get_cpu_info();
+    unsigned int val = info->xen_spec_ctrl;
+
+    /*
+     * On AMD we will never use MSR_SPEC_CTRL together with MSR_VIRT_SPEC_CTRL
+     * or any legacy way of setting SSBD, so reuse the spec_ctrl fields in
+     * cpu_info for context switching the other means of setting SSBD.
+     */
+    ASSERT(!boot_cpu_has(X86_FEATURE_SC_MSR_HVM));
+    if ( cpu_has_virt_ssbd )
+    {
+        unsigned int lo, hi;
+        struct vcpu *curr = current;
+
+        /*
+         * Need to read from the hardware because VIRT_SPEC_CTRL is not context
+         * switched by the hardware, and we allow the guest untrapped access to
+         * the register.
+         */
+        rdmsr(MSR_VIRT_SPEC_CTRL, lo, hi);
+        if ( val != lo )
+            wrmsr(MSR_VIRT_SPEC_CTRL, val, 0);
+        curr->arch.msrs->spec_ctrl.raw = lo;
+        info->last_spec_ctrl = val;
+    }
+}
+
+/* Called with GIF=0. */
+void vmentry_virt_spec_ctrl(void)
+{
+    struct cpu_info *info = get_cpu_info();
+    const struct vcpu *curr = current;
+    unsigned int val = curr->arch.msrs->spec_ctrl.raw;
+
+    ASSERT(!boot_cpu_has(X86_FEATURE_SC_MSR_HVM));
+    if ( val != info->last_spec_ctrl )
+    {
+        wrmsr(MSR_VIRT_SPEC_CTRL, val, 0);
+        info->last_spec_ctrl = val;
+    }
+
+    /* No Spectre v1 concerns.  Execution is going to hit VMRUN imminently. */
+}
+
 /*
  * Local variables:
  * mode: C
diff --git a/xen/arch/x86/include/asm/cpufeatures.h b/xen/arch/x86/include/asm/cpufeatures.h
index b10154fc44..a2c37bfdd4 100644
--- a/xen/arch/x86/include/asm/cpufeatures.h
+++ b/xen/arch/x86/include/asm/cpufeatures.h
@@ -39,6 +39,7 @@ XEN_CPUFEATURE(SC_VERW_PV,        X86_SYNTH(23)) /* VERW used by Xen for PV */
 XEN_CPUFEATURE(SC_VERW_HVM,       X86_SYNTH(24)) /* VERW used by Xen for HVM */
 XEN_CPUFEATURE(SC_VERW_IDLE,      X86_SYNTH(25)) /* VERW used by Xen for idle */
 XEN_CPUFEATURE(XEN_SHSTK,         X86_SYNTH(26)) /* Xen uses CET Shadow Stacks */
+XEN_CPUFEATURE(VIRT_SC_MSR_HVM,   X86_SYNTH(27)) /* MSR_VIRT_SPEC_CTRL exposed to HVM */
 
 /* Bug words follow the synthetic words. */
 #define X86_NR_BUG 1
diff --git a/xen/arch/x86/spec_ctrl.c b/xen/arch/x86/spec_ctrl.c
index 64b154b2d3..2c46e1485f 100644
--- a/xen/arch/x86/spec_ctrl.c
+++ b/xen/arch/x86/spec_ctrl.c
@@ -399,9 +399,12 @@ static void __init print_details(enum ind_thunk thunk, uint64_t caps)
            (boot_cpu_has(X86_FEATURE_SC_MSR_HVM) ||
             boot_cpu_has(X86_FEATURE_SC_RSB_HVM) ||
             boot_cpu_has(X86_FEATURE_MD_CLEAR)   ||
+            boot_cpu_has(X86_FEATURE_VIRT_SC_MSR_HVM) ||
             opt_eager_fpu)                           ? ""               : " None",
            boot_cpu_has(X86_FEATURE_SC_MSR_HVM)      ? " MSR_SPEC_CTRL" : "",
-           boot_cpu_has(X86_FEATURE_SC_MSR_HVM)      ? " MSR_VIRT_SPEC_CTRL" : "",
+           (boot_cpu_has(X86_FEATURE_SC_MSR_HVM) ||
+            boot_cpu_has(X86_FEATURE_VIRT_SC_MSR_HVM)) ? " MSR_VIRT_SPEC_CTRL"
+                                                       : "",
            boot_cpu_has(X86_FEATURE_SC_RSB_HVM)      ? " RSB"           : "",
            opt_eager_fpu                             ? " EAGER_FPU"     : "",
            boot_cpu_has(X86_FEATURE_MD_CLEAR)        ? " MD_CLEAR"      : "");
@@ -1053,6 +1056,9 @@ void __init init_speculation_mitigations(void)
             setup_force_cpu_cap(X86_FEATURE_SC_MSR_HVM);
     }
 
+    if ( opt_msr_sc_hvm && cpu_has_virt_ssbd )
+        setup_force_cpu_cap(X86_FEATURE_VIRT_SC_MSR_HVM);
+
     /* If we have IBRS available, see whether we should use it. */
     if ( has_spec_ctrl && ibrs )
         default_xen_spec_ctrl |= SPEC_CTRL_IBRS;
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Tue Feb 01 16:47:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 01 Feb 2022 16:47:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.263669.456478 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEwJa-0001k3-BI; Tue, 01 Feb 2022 16:47:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 263669.456478; Tue, 01 Feb 2022 16:47:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEwJa-0001jw-7G; Tue, 01 Feb 2022 16:47:34 +0000
Received: by outflank-mailman (input) for mailman id 263669;
 Tue, 01 Feb 2022 16:47:33 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JAuK=SQ=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nEwJY-0001jg-O0
 for xen-devel@lists.xenproject.org; Tue, 01 Feb 2022 16:47:33 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a3a158b4-837e-11ec-8f75-fffcc8bd4f1a;
 Tue, 01 Feb 2022 17:47:29 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a3a158b4-837e-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1643734050;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:content-transfer-encoding:mime-version;
  bh=tYlfStrLrbzHtKiANWWxe3HTgEbBnEM//TYWYX+uBeM=;
  b=E7x54TpG/e5gghhCF+80k7h3EckdXkzquxaftxku+wkZ58stjTlau+dx
   enKWTVwBvrIBoEqXSw1UlBIEIm1x6QoBFVrx6skLGTXVZXX4qzSzJtUe/
   8U3za/6a2eTetznYVA6zshWI6m4YrB24dHZ07IsxYxSUNZPbTvZabFWxW
   M=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: UgnSOZDn3Or0tPH+2jb8nlykhHitL4N2m/QjOlD7NnjZCAub/+H2KgUBpv6QmHTOp7eOSci8yv
 TOduuQeISxySBtBbuWs3kWzNBfmSpnx4mf5wHIaZLdPWWOIFofOM5/U+zKBKmRkKSlvOte/vVm
 2E2tAkpNrtMVwEaRvNaR92QOCadN3Llzevf6vX8Ow5Q1dY4g6f2l/82/UkHUeqmghMUBCfvNpd
 I2OkWyvutI+9J9KBUYGE5lPogvbYyHQWsJirI0It/sLEjLQmFIXETPImACaFMyfJar4d+EaugQ
 fb6gBCWRE/IrF3aPcxruPCUD
X-SBRS: 5.2
X-MesageID: 63238769
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:4+waRKx7pgOuquK7jIt6t+e+wSrEfRIJ4+MujC+fZmUNrF6WrkUPz
 WIfDWjUO/yONmr2fNx0Otzi9xxU7cCByIUwHAI/+CAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAhLeNYYH1500g7wbZg2tQAbeWRWGthh
 /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL
 wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt4pOj
 +QcjbKccgkoHJTSg70AaRtoHC4raMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr
 6ZBbmlQMFbT3Ipaw5riIgVort4kI8TxepsWp1lrzC3DDOZgSpfGK0nPzYEDhmxg2Z4fdRrYT
 +4dWzEzMBjaWAZWIg9HB8MYmNiqqnaqJlW0r3rK/PFqsgA/1jdZy6PxOdDYftiLQ8R9nUuCo
 G/CuWPjDXkyK9i32TeDtHW2iYfnnz7/WY8UPK218LhtmlL77nweDlgaWEW2pdG9i1WiQJRPJ
 koM4C0soKMuskuxQbHVXRe1vXqFtR40QMdLHqsx7wTl90bPy1/HXC5eFGcHMYF48p9tLdA36
 rOXt4nWQg0+iJO5cnyc1I6KtmqvAyolImBXMEfoUjA5y9XkpYgyiDfGQdBiDLO5g7XJJN3g/
 9yZhHNg3utO1Kbnw43+pAma2Gz0+vAlWyZovl2/Y46z0u9uiGdJjaSM4EOT0/tPJZ3xorKp7
 CldwJj2AAzj4PiweM2xrAclQevBCxWtamS0bbtT838JrW7FF5mLJtg43d2GDB01WvvogBewC
 KMphStf5YVIIFyhZrJtboS6BqwClPa8Tom1CaiEMIsSM/CdkTNrGgk0PyZ8OEi2yCARfVwXY
 8/HIa5A815HYUiY8NZGb7hEiuJ6rszP7WjSWYr633yaPUm2PxaopUM+GALWNIgRtfrcyC2Mq
 oo3H5bUl313DbOvCgGKod97BQ1bdhATWMGpw/G7g8beeGKK7kl7Va+IqV7gEqQ495loehDgp
 SDgAxIIlQak2BUq62yiMxheVV8mZr4mxVoTNi0wJ1e4nX8lZIek9qAEcJUrO7Ig8YReITRcF
 aJtlxyoDqsdRzLZ1S4aaJWh/oVueA7y3VCFPja/YSh5dJllHlSb9tjhdwrp1S8PEivo6pdu/
 +z+jlvWEcgZWgBvLMfKc/bznVm/imcQxbBpVEzSL9gNJEi1qNp2Kzb8h+McKt0XLUmR3SOT0
 gubWE9KpeTEr4Iv3sPOgKSI89WgH+dkRxIIFGjH97emcyLd+zP7k4NHVe+JexHbVX/1p/r+N
 bkEkamkPaRezlhQsod6H7J69o4E5oPi9+1A0wBpPHTXdFD3WLluFWaLgJtUvapXy74H5QbvA
 hCT+sNXMKmiMd/+FAJDPxIsa+mO2K1GmjTW6vhpckz26DUuoeiCWERWeRKNlDZcPP1+N4Z8m
 bUtv8sf6gqejBs2M4nZ0nAIpjrUdnFQAb86spw6AZPwjlt5w15PVpXQFyvq7czdcN5LKEQrf
 meZiaeqa26wHaYen67fzUTw4Nc=
IronPort-HdrOrdr: A9a23:fdcKPKAAb/xcNavlHeg0sceALOsnbusQ8zAXPh9KJiC9I/b1qy
 nxppkmPH/P6Qr4WBkb6LS90c67MA/hHP9OkPQs1NKZMjUO11HYSr2KgbGSoQEIXheOjdK1tp
 0QApSWaueAdGSS5PySiGLTc6dC/DDEytHTuQ639QYScegAUdAG0+4WMHf/LqUgLzM2eqbRWa
 DsrfZvln6FQzA6f867Dn4KU6zqoMDKrovvZVojCwQ84AeDoDu04PqieiLokys2Yndq+/MP4G
 LFmwv26uGKtOy68AbV0yv2445NkNXs59NfDIini9QTKB/rlgG0Db4REYGqjXQQmqWC+VwqmN
 7Dr1MJONly0WrYeiWPrR7ky2DboUATwk6n7WXdrWrooMT/Sj5/IdFGn5hlfhzQ7FdllM1g0Y
 pQtljp+aZ/PFflpmDQ9tLIXxZlmg6funw5i9MeiHRZTM83dKJRl4oC50lYea1wUx4S0LpXUN
 WGMfusp8q/KTihHjLkVyhUsZCRt00Ib1a7qhNogL3R79BU9EoJuHfwivZv2kvoz6hNOKWs0d
 60RpiApIs+PvP+UpgNdtvpOfHHclAlYSi8eV56cm6XXJ3uBRr22uvKCfMOlaaXRKA=
X-IronPort-AV: E=Sophos;i="5.88,334,1635220800"; 
   d="scan'208";a="63238769"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jtiXVl+vxoX0qx+ZjiP5TpwMAiLEYQcoD6FdyjkkTHZEwKgGuecCTKDwC2xpdNNreC3m6QAMuXH1uNmfYEi1ROgEiNWs7gKYAZiXlhPfUEfOiiJK/QR9COVHM4EkqDAcCF+rYu4/hU+fVDZoPSP7juSItgZ4WbahuFxmRPJ86rOyINda7Aa5MAkgXelhsorf3uq/rwJQEI9EGJDuBZDPvnFkqHJ+UwoF4ew5qdkc98RsmZeLa3nR8SregzccC2iHGOwbtR+oTY/LzRRp/tqQa8P7J7VzF7Tba1N0XYukvGafMHSPdABzak9dWSLXr4ykpdSb7HOBoj/S4TDReS18xA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=uw4nNchZqs0hUl6LILWnvwkTezS63JG+YIFkjLmR6us=;
 b=RfQBi+ice9mdQB+DKppitWjDImE4NEjHSRiFgzEdmS8S2wNXHFtPBSRDP2vGIRq1X12zT8FAolcMgKpJnhbT4AUbKF8P/Wpp0jTE4Q+qBXyL1aZOTOxlTDXoxU6qEcPvXBIjA3k7tNCi7SlqkWhUIro11mEEiOpqUp0fy4pveOSd0u5I1RnPmXJ2QHk+WPiGUxAGc4wDaysSZ/6mIUnDrBXrnyNbGS0c65J7Um+YUprpj8s7/15u6m+Acb5oOnLwo4zPqzYuKoFO6+rcJeoavvp2EAPB3B2h+X8+jyNzB1+0va4KX5xl+B/662NG13zqVePeuNtU6Sy/qGLSKd7SVw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=uw4nNchZqs0hUl6LILWnvwkTezS63JG+YIFkjLmR6us=;
 b=Pyq2crJbO1gyE7b8aUZCFeLELQDfTohqJGg87Fs5mveVMvrg3ov4hSB5t84VlBaS78WzgMkE1kUGPMBSt/88oIHWVG2uiXhKJeIK+WOhy6HH9yga+bVIIDbCRJkdzoHzYFwkY5V2HFbHlDuzFEJs0hwSmrbARU9ywpLT6LBBU0o=
From: Roger Pau Monne <roger.pau@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Roger Pau Monne <roger.pau@citrix.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, Jan
 Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>, Stefano
 Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Subject: [PATCH 1/3] amd/msr: implement VIRT_SPEC_CTRL for HVM guests on top of SPEC_CTRL
Date: Tue,  1 Feb 2022 17:46:49 +0100
Message-ID: <20220201164651.6369-2-roger.pau@citrix.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220201164651.6369-1-roger.pau@citrix.com>
References: <20220201164651.6369-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LNXP265CA0011.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:5e::23) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4f9f5769-2bdc-4f64-f8f7-08d9e5a283e9
X-MS-TrafficTypeDiagnostic: SN6PR03MB3565:EE_
X-Microsoft-Antispam-PRVS: <SN6PR03MB3565C8733C90867C761BEBB08F269@SN6PR03MB3565.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2399;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 49W7SwZ1Om81O+2HnO+IHf51Cm2Mr8umc5ZL3TRSz+cnCS0DTkIX0Ik8s40bGoL51H7QStq2yyBI/r5R2mxg8dYQ1cIcRBnuJ+BLLYkPhsMNYmHDWiTUzKxTsBXxS4oZ7PHxX6dTK24x17a4VGnCjJqAdLQaHr4IDxXR4idhNvyphaluARpfBO45F3lDURbttB/EFKtgb72ujvxk9BvW9wHQmR3+f7RZD211MeHS86h53T/KDtMXFJKOGMsuSqJl/SjbGyOQko79qFEjnOxDKWFVp+wWPuetSV3/TLvh2otVrFfmC829FWb/P9ieRfvQyIG1gqtpKXkJoqu/Gg5Svo9svySUyFyrUYTmFe1lMdqR9JeZVcYchur6YRcKOAm29IB/mQ6yCdIcUXVwcN12TKNMFilKRU0mVvIMeUsTWPRRRP2ONVgQE4P10DwX1MKmF+FEbNvHsli0lmWn2jr6IgiHmQZxEc7bZ/XEIy+eDDs5aB1rWtCh6KPQ0rsIgE+deyYBUIKv69NsPuSzo1C9OXu72HUh07RBPkygtfoOA8YFNaTj5xLBF4ksPqqdUKh3Yyu3FjLsM658Hgaw/FSu9tIDtT+xfDwAOPkez1MbQkMXMxXK1EOQWIRLi9GSmI6JgYi/L2U70wKS84Epkgw6jA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6666004)(66476007)(66946007)(8936002)(4326008)(8676002)(508600001)(5660300002)(66556008)(6486002)(38100700002)(83380400001)(6506007)(36756003)(6916009)(82960400001)(6512007)(26005)(86362001)(1076003)(186003)(2616005)(2906002)(54906003)(316002)(20210929001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dk9vKzRsRzJCWDNFeGpNTlZMUlF3NThzakN4ei9ocEY2Y0hicWxiRmtRdmpv?=
 =?utf-8?B?NnViakQ1VGdWTWplamFvRDVxS0FjQ3VkdVZ0aGR2eXllci9hc00zWlVFK1dh?=
 =?utf-8?B?Smg4dDc0OENWRFpZRmsreDE3VzdWcVBRNkdqQmRjYUtVNExBMEQyS2hpb1Mx?=
 =?utf-8?B?RzRSbEZIbkRRVU9mMnZIczRZK21oUGpmSlFORnUxNStyK0Mxa2QyYUhQY09M?=
 =?utf-8?B?clg5V21yTmdESllUc25kTEgvb0N1YWpPamxob3pSTzlsQTNNZXNRQ1A4R3Qx?=
 =?utf-8?B?bjBBM0h2WTV6czVISDVoWGR4WVYwOGRGWlZFcS80S0F0RzFBMTVzVUZGd0FN?=
 =?utf-8?B?SGRlZXlSQ21aTVdFMXlVOXVIalR0a25JZlhCc2NWWVV6T3VVb29EVnVJOU94?=
 =?utf-8?B?elVsYkVERkhhM0FFY3hhRit1ckxmT1pFNEM1UzRpSW44MVZ4bFZxUm00SFlN?=
 =?utf-8?B?RVFqTE9TNnd4bzhnL3hhZjZBMmJQNDlXazd0ZWNnU2dFZlFid1c5ZzJuTUtF?=
 =?utf-8?B?WXRJR282dTFrZDBkZEVQclF6Z2poc0IvRjkzbDZtOU9ZUmRrUzRzdTAraVN4?=
 =?utf-8?B?S1BTMGx5NVVkSm1xZS9oUi9xK2JvY1UvMy95VzM4aDB6MXlrNkQzRjQ5RGQr?=
 =?utf-8?B?dHZhYWxaSzArdjRaYW80V1lvN09LcFBjYjRqU2hwNmtXdmo1VjJzQ2JGbUxl?=
 =?utf-8?B?NnhJblpzQWxLV2Q1N1VXeDBLdkF0eGFLSlQ3aWRDdlg4QlZYUHd3WUszckcr?=
 =?utf-8?B?eURVMVVXNWJXRkpGVW93TzgwaFB0VzFFOXIyZFpkWVhDYW5KclkrU0w4NnJx?=
 =?utf-8?B?VVNRbnR1M0d4OGVqTGQ1aG1HN0RJaTVSUDhvai9MYmFFYU8rZGVYY041UjBa?=
 =?utf-8?B?ZnFTVEVtOEtnQ2ZJcjBhL05jQkh3NWtEREl2Z2FwdFZ6UFdnOWJXeTFRMDcv?=
 =?utf-8?B?anA3WkJtOWJuYnlPeTd5aEVzVkMreVBvSTM4NDUvMENJalRBeEVYQm5QdDlM?=
 =?utf-8?B?em9PaXRCSHNkTUtOWitVWm5rSHp6c3lCOFpadmxpQVpiaTJVV2Iwa0xFWUpn?=
 =?utf-8?B?RUE2NkQvb0hmSmZEYU51Z1ZKN1Z5SGdtTHpzRDM0TXlUeEMrRDVXdmQ5b05p?=
 =?utf-8?B?YXdjb2tkSy9JbEtHNUg4ZXBuNW5rZHJjMVRxNFRSUnV0Q29SZ0J2RnFqOXhi?=
 =?utf-8?B?WG4rdnpyQitod0FscmVKL2g1bDd0dlBFRnBqUHV0d0k0d1BVZGx6aVZDS1B5?=
 =?utf-8?B?MlBMWXFsYTMrdUpuU05FR2V0aWtVazJTWDhPWGlTdHlUSllheXE3bCtEaUt0?=
 =?utf-8?B?aUFWKy9LRHA1NWQ2Z1VSODJQN2NBb0F6Y24vR3BjTy9wN25PQjVSU3lmQXZs?=
 =?utf-8?B?OVFSUGhsempxS3BYRnR5VzNiOVNrNGFHZHNwWlRjTDBLTlFQdVd0enJ1K21r?=
 =?utf-8?B?Z3l1RkRtOVBLNnFaOHJBSm5Zc2pla1hia215a0pJdHhQNC9acWh0NlJVeFhJ?=
 =?utf-8?B?REc2T2FjZzZXNTZwaDhOVVBoVjhHRFZTWU1JSHJobnpINmd1Z3dOUTZ3cHdU?=
 =?utf-8?B?TWNkOFdKV2ExelFDaTROVWRNUTNxd1FXNXY5bjVYNGNBb2J0ZVRrZElqQndH?=
 =?utf-8?B?SFdNb3ZtVWpydmdRbFlhSVVQWGJKcWJIb0x2NVdGM0kvbVIwMW5oVUFsSGEw?=
 =?utf-8?B?T2xQaVVFdDNhc3JjdU92d0FPYVg1THVmZUJlSEkyWlkzT0d1QVdHcFdVSGhT?=
 =?utf-8?B?MTUwV3hOUWUvb1BpeDBSekk5T3BTRTNaem5WYVNCV0ZJSnpyNjdKN1hWOWZV?=
 =?utf-8?B?aDZEbkhrV0VONUZmNlZRQXBJZ05lL2crTGxMV3loMlI4aWcvZDV4WmM4SER2?=
 =?utf-8?B?TDlWeW1heE5vTExlcXJxVVhXWHJhTzJvWHRxcVJKNlhTR212SjFGekY1VHpN?=
 =?utf-8?B?UEl5M0ZKeGp2N2lHR2k3QkZlU2U0alFDQy9yUlZWeTFrcVlaUk54SE9lTEF5?=
 =?utf-8?B?cTZGNE5VTU0xYWNxaGNTYjM1ajUrNkdOTjhFekhrUFFwRENhSkxET3lsTE9H?=
 =?utf-8?B?V053aUdCRExPVWw4UFlTLzJzNXBjK244RTJnZk5JMzlJQkovZndiOEYzbmhP?=
 =?utf-8?B?bzFhdHcrRHZ3Q25KQk1XOHBqVHRnVjRDQzM4SjFmREpkZCtiRStYMy92aDcv?=
 =?utf-8?Q?uRvcOra/V2ijaG05XNRkbm0=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4f9f5769-2bdc-4f64-f8f7-08d9e5a283e9
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2022 16:47:21.1184
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RLrJImdvFwdp/DERnpT8YRumsTXvj5u7Psmue6uFIHclhnyw/6tdtLfC8YHitURTuVhkuwd4y868rcN0QFdFRw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR03MB3565
X-OriginatorOrg: citrix.com

Use the logic to set shadow SPEC_CTRL values in order to implement
support for VIRT_SPEC_CTRL (signaled by VIRT_SSBD CPUID flag) for HVM
guests. This includes using the spec_ctrl vCPU MSR variable to store
the guest set value of VIRT_SPEC_CTRL.SSBD.

Note that VIRT_SSBD is only set in the HVM max CPUID policy, as the
default should be to expose SPEC_CTRL only and support VIRT_SPEC_CTRL
for migration compatibility.

Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
 docs/misc/xen-command-line.pandoc           |  5 +++--
 xen/arch/x86/cpuid.c                        |  7 +++++++
 xen/arch/x86/hvm/hvm.c                      |  1 +
 xen/arch/x86/include/asm/msr.h              |  6 +++++-
 xen/arch/x86/msr.c                          | 15 +++++++++++++++
 xen/arch/x86/spec_ctrl.c                    |  3 ++-
 xen/include/public/arch-x86/cpufeatureset.h |  2 +-
 7 files changed, 34 insertions(+), 5 deletions(-)

diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc
index 6b3da6ddc1..081e10f80b 100644
--- a/docs/misc/xen-command-line.pandoc
+++ b/docs/misc/xen-command-line.pandoc
@@ -2273,8 +2273,9 @@ to use.
 * `pv=` and `hvm=` offer control over all suboptions for PV and HVM guests
   respectively.
 * `msr-sc=` offers control over Xen's support for manipulating `MSR_SPEC_CTRL`
-  on entry and exit.  These blocks are necessary to virtualise support for
-  guests and if disabled, guests will be unable to use IBRS/STIBP/SSBD/etc.
+  and/or `MSR_VIRT_SPEC_CTRL` on entry and exit.  These blocks are necessary to
+  virtualise support for guests and if disabled, guests will be unable to use
+  IBRS/STIBP/SSBD/etc.
 * `rsb=` offers control over whether to overwrite the Return Stack Buffer /
   Return Address Stack on entry to Xen.
 * `md-clear=` offers control over whether to use VERW to flush
diff --git a/xen/arch/x86/cpuid.c b/xen/arch/x86/cpuid.c
index e24dd283e7..29b4cfc9e6 100644
--- a/xen/arch/x86/cpuid.c
+++ b/xen/arch/x86/cpuid.c
@@ -543,6 +543,13 @@ static void __init calculate_hvm_max_policy(void)
         __clear_bit(X86_FEATURE_IBRSB, hvm_featureset);
         __clear_bit(X86_FEATURE_IBRS, hvm_featureset);
     }
+    else
+        /*
+         * If SPEC_CTRL is available VIRT_SPEC_CTRL can also be implemented as
+         * it's a subset of the controls exposed in SPEC_CTRL (SSBD only).
+         * Expose in the max policy for compatibility migration.
+         */
+        __set_bit(X86_FEATURE_VIRT_SSBD, hvm_featureset);
 
     /*
      * With VT-x, some features are only supported by Xen if dedicated
diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c
index c4ddb8607d..3400c9299c 100644
--- a/xen/arch/x86/hvm/hvm.c
+++ b/xen/arch/x86/hvm/hvm.c
@@ -1332,6 +1332,7 @@ static const uint32_t msrs_to_send[] = {
     MSR_INTEL_MISC_FEATURES_ENABLES,
     MSR_IA32_BNDCFGS,
     MSR_IA32_XSS,
+    MSR_VIRT_SPEC_CTRL,
     MSR_AMD64_DR0_ADDRESS_MASK,
     MSR_AMD64_DR1_ADDRESS_MASK,
     MSR_AMD64_DR2_ADDRESS_MASK,
diff --git a/xen/arch/x86/include/asm/msr.h b/xen/arch/x86/include/asm/msr.h
index ce4fe51afe..98f6b79e09 100644
--- a/xen/arch/x86/include/asm/msr.h
+++ b/xen/arch/x86/include/asm/msr.h
@@ -291,6 +291,7 @@ struct vcpu_msrs
 {
     /*
      * 0x00000048 - MSR_SPEC_CTRL
+     * 0xc001011f - MSR_VIRT_SPEC_CTRL
      *
      * For PV guests, this holds the guest kernel value.  It is accessed on
      * every entry/exit path.
@@ -301,7 +302,10 @@ struct vcpu_msrs
      * For SVM, the guest value lives in the VMCB, and hardware saves/restores
      * the host value automatically.  However, guests run with the OR of the
      * host and guest value, which allows Xen to set protections behind the
-     * guest's back.
+     * guest's back.  Use such functionality in order to implement support for
+     * VIRT_SPEC_CTRL as a shadow value of SPEC_CTRL and thus store the value
+     * of VIRT_SPEC_CTRL in this field, taking advantage of both MSRs having
+     * compatible layouts.
      *
      * We must clear/restore Xen's value before/after VMRUN to avoid unduly
      * influencing the guest.  In order to support "behind the guest's back"
diff --git a/xen/arch/x86/msr.c b/xen/arch/x86/msr.c
index 4ac5b5a048..aa74cfde6c 100644
--- a/xen/arch/x86/msr.c
+++ b/xen/arch/x86/msr.c
@@ -381,6 +381,13 @@ int guest_rdmsr(struct vcpu *v, uint32_t msr, uint64_t *val)
                ? K8_HWCR_TSC_FREQ_SEL : 0;
         break;
 
+    case MSR_VIRT_SPEC_CTRL:
+        if ( !cp->extd.virt_ssbd )
+            goto gp_fault;
+
+        *val = msrs->spec_ctrl.raw & SPEC_CTRL_SSBD;
+        break;
+
     case MSR_AMD64_DE_CFG:
         if ( !(cp->x86_vendor & (X86_VENDOR_AMD | X86_VENDOR_HYGON)) )
             goto gp_fault;
@@ -666,6 +673,14 @@ int guest_wrmsr(struct vcpu *v, uint32_t msr, uint64_t val)
             wrmsr_tsc_aux(val);
         break;
 
+    case MSR_VIRT_SPEC_CTRL:
+        if ( !cp->extd.virt_ssbd )
+            goto gp_fault;
+
+        /* Only supports SSBD bit, the rest are ignored. */
+        msrs->spec_ctrl.raw = val & SPEC_CTRL_SSBD;
+        break;
+
     case MSR_AMD64_DE_CFG:
         /*
          * OpenBSD 6.7 will panic if writing to DE_CFG triggers a #GP:
diff --git a/xen/arch/x86/spec_ctrl.c b/xen/arch/x86/spec_ctrl.c
index ee862089b7..64b154b2d3 100644
--- a/xen/arch/x86/spec_ctrl.c
+++ b/xen/arch/x86/spec_ctrl.c
@@ -395,12 +395,13 @@ static void __init print_details(enum ind_thunk thunk, uint64_t caps)
      * mitigation support for guests.
      */
 #ifdef CONFIG_HVM
-    printk("  Support for HVM VMs:%s%s%s%s%s\n",
+    printk("  Support for HVM VMs:%s%s%s%s%s%s\n",
            (boot_cpu_has(X86_FEATURE_SC_MSR_HVM) ||
             boot_cpu_has(X86_FEATURE_SC_RSB_HVM) ||
             boot_cpu_has(X86_FEATURE_MD_CLEAR)   ||
             opt_eager_fpu)                           ? ""               : " None",
            boot_cpu_has(X86_FEATURE_SC_MSR_HVM)      ? " MSR_SPEC_CTRL" : "",
+           boot_cpu_has(X86_FEATURE_SC_MSR_HVM)      ? " MSR_VIRT_SPEC_CTRL" : "",
            boot_cpu_has(X86_FEATURE_SC_RSB_HVM)      ? " RSB"           : "",
            opt_eager_fpu                             ? " EAGER_FPU"     : "",
            boot_cpu_has(X86_FEATURE_MD_CLEAR)        ? " MD_CLEAR"      : "");
diff --git a/xen/include/public/arch-x86/cpufeatureset.h b/xen/include/public/arch-x86/cpufeatureset.h
index 957df23b65..b9ab878ec1 100644
--- a/xen/include/public/arch-x86/cpufeatureset.h
+++ b/xen/include/public/arch-x86/cpufeatureset.h
@@ -265,7 +265,7 @@ XEN_CPUFEATURE(IBRS_SAME_MODE, 8*32+19) /*S  IBRS provides same-mode protection
 XEN_CPUFEATURE(NO_LMSL,       8*32+20) /*S  EFER.LMSLE no longer supported. */
 XEN_CPUFEATURE(AMD_PPIN,      8*32+23) /*   Protected Processor Inventory Number */
 XEN_CPUFEATURE(AMD_SSBD,      8*32+24) /*S  MSR_SPEC_CTRL.SSBD available */
-XEN_CPUFEATURE(VIRT_SSBD,     8*32+25) /*   MSR_VIRT_SPEC_CTRL.SSBD */
+XEN_CPUFEATURE(VIRT_SSBD,     8*32+25) /*!s MSR_VIRT_SPEC_CTRL.SSBD */
 XEN_CPUFEATURE(SSB_NO,        8*32+26) /*A  Hardware not vulnerable to SSB */
 XEN_CPUFEATURE(PSFD,          8*32+28) /*S  MSR_SPEC_CTRL.PSFD */
 
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Tue Feb 01 16:47:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 01 Feb 2022 16:47:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.263671.456500 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEwJf-0002I0-65; Tue, 01 Feb 2022 16:47:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 263671.456500; Tue, 01 Feb 2022 16:47:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEwJf-0002Hj-1p; Tue, 01 Feb 2022 16:47:39 +0000
Received: by outflank-mailman (input) for mailman id 263671;
 Tue, 01 Feb 2022 16:47:37 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JAuK=SQ=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nEwJd-0001jp-IN
 for xen-devel@lists.xenproject.org; Tue, 01 Feb 2022 16:47:37 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a7aa6c46-837e-11ec-8eb8-a37418f5ba1a;
 Tue, 01 Feb 2022 17:47:36 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a7aa6c46-837e-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1643734055;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:content-transfer-encoding:mime-version;
  bh=Ndn4INHz/j60oQaRgENB/5AM+vR9HliHOz/hdLMStQ4=;
  b=KZQUOFTTP/1XhdDnAv4QuuzJB80UU1uuajjkhwAAcxyJvEk65J+/DOGJ
   8/XM+Dtq5sOovdrnBwLmBhUcwUno2hQF5NLsz77ZhmvSe0U/3qoAUxELR
   k95YQ5lBWBvKcU6qyLRsYrgq+tW3jmSK/TvEGcQUPbJS3XBnZtJRzd9nH
   w=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: /5cyDcjvk/BU1jS0MzZfgzwQPVeZa6+rXcThtrut3f3lM+ojCXJEUwOKUTfv4gyCZ74TwB6GS1
 lvJkItYeVTYR0cyhC/qBK1B68gA6Vy0jHoyn9TcfQaMhL4LkGuTMHEW2zcs+9s2GgpI3pSRNLj
 SQYtLdRrwsFuiVY8swrkiBru6e3M2uSyiws8yVaMonr/NrqNPWMu+rt2Z2X0lfB5EO1L/wq7oK
 CN+mkkF3FbINfLZkYyrqIpjaldJYMYJ+/92nlZvE0RDrZGL05klYQHSpTcqHaujDeDzoonsatb
 FlooQjbpx+go3uRFfDZD5L3x
X-SBRS: 5.2
X-MesageID: 62702189
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:sxnmYahnUh0qQGnEz9ifqXMAX161hhcKZh0ujC45NGQN5FlHY01je
 htvCG7XM6qLM2WgKI12bIrl/EoO6pTdxt9nS1FtqXpkFn8b9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oAMKRCQ7InQLlbGILes1htZGEk0GE/NtTo5w7Rj2tQw2IDja++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /1u7pqIdzsrfZfhhe0cURlXDih5EIhZreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHxO4wSoDd4xCzxBvc6W5HTBa7N4Le02R9u3J8WR6+ON
 qL1bxI0SBjQeUdREG0TBagbstuLmnejKztx/Qf9Sa0fvDGIkV0ZPKLWGMXRUsyHQ4NShEnwj
 mDM8nn9AxoaHMeC0jfD+XWp7sffkCW+VI8MGbmQ8v9xnEbV1mEVEAcRV1awvb++kEHWZj5EA
 xVKoGx09/F0rRH1CImmN/GlnJKalj1HXeJuL+950iyQw6vW4wmED28payEUPbTKq/QKbTAt0
 1aImfbgCjpurKCZRBqhy1uEkd+hEXNLdDFfPEfoWSNAuoC++99r0nojW/4+SPbdszHjJd3nL
 9lmRgAajq5bs8ME3r7TEbvv02P1/cihouLYC2zqsoOZAuFROdTNi2+AswGzARN8wGCxFAPpU
 J8swJD20Qz2JcvR/BFhuc1UdF1T296LMSfHnXlkFIQ7+jKm9haLJN4Mu2wuex85bJdYKFcFh
 XM/XysLvve/21PxNcdKj3+ZUZx2ncAM6/y4PhwrUja+SscoL1LWlM2fTUWRw3rsgCARfVIXY
 v+mnTKXJS9CU8xPlWPuL89EiOND7n1gmQv7GM6qpzz6gev2TCPEEt8tbQrRBt3VGYvZ+m05B
 f4FaZvTo/ieOcWjChTqHXk7dgFXdCVrWMyt9qS6tIere2JbJY3oMNeIqZsJcI15haVF0ODO+
 3C2QEhDz1Tjw3bALG23hrpLMdsDhL5z8iA2OzICJ1Gt1yRxaIqj9v5HJZA2YaMm5KpoyvstF
 6sJfMCJA/JuTDXb+mtCMcmh/dI6LBn71xiTOyeFYSQke8IyTQL+5dK5LBDk8zMDD3TruJJm8
 aGgzA7SXbEKWx9mUJTNcPuqwl7o5Sodlet+UlHmON5WfEmwooFmJzao1q08It0WKAWFzTyfj
 l7EDRAdrOjLgok07NiW2vzU89b3S7NzRxMIEXPa4LC6MTjh0lCimYIQAvyVeT39VX/v/Pnwb
 +ti0PyhYuYMm0xHstQgHu8zn74+/dbmu5RT0h9gQCfQd12uB75tfiuG0M1IuvEfz7NVo1LrC
 EeG+90cMrSVIsL1VlUWIVN9POiE0PgVnBjU7Og0fxqmtHMmouLfXBUAJQSIhQxcMKBxYdEsz
 uoWscIL7xCy10gxOdGcgyEIr2mBIxTsiUn8Wk321GMztjcW9w==
IronPort-HdrOrdr: A9a23:S1hepKMgQnbcb8BcT1v155DYdb4zR+YMi2TDiHoedfUFSKOlfp
 6V8MjztSWVtN4QMEtQ/uxoX5PwPk80lKQFnbX5WI3CYOCIghrQEGgP1/qG/9SkIVyFygc/79
 YRT0EdMqyJMbESt6+Ti2PUYrVQouVvsprY+Ns2p00dPD2CAJsQiTuRZDzrdnGfE2J9dOQE/d
 enl4B6jgvlXU5SQtWwB3EDUeSGj9rXlKj+aRpDIxI88gGBgR6h9ba/SnGjr1sjegIK5Y1n3X
 nOkgT/6Knmm/anyiXE32uWy5hNgtPuxvZKGcTJoMkILTfHjBquee1aKvC/lQFwhNvqxEchkd
 HKrRtlF8Nv60nJdmXwmhfp0xmI6kdm11bSjXujxVfzq83wQzw3T+Bbg5hCTxff4008+Plhza
 NixQuixttqJCKFuB64y8nDVhlsmEbxi2Eli/Qvg3tWVpZbQKNNrLYY4FheHP47bWzHAbgcYa
 pT5fznlbRrmQvwVQGdgoAv+q3iYp0LJGbHfqBY0fbllwS/nxhCvj0lLYIk7zA9HakGOut5Dt
 L/Q9NVfYF1P7wrhJ1GdZI8qLOMexfwqDL3QSqvyAfcZeo600ykke+C3Fxy3pDtRKA1
X-IronPort-AV: E=Sophos;i="5.88,334,1635220800"; 
   d="scan'208";a="62702189"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Xs+L6wDrAU8jRN9wpbAsyg6gCLa5W4hsQPIRVmxr62jqPLA1mwL3jXZC06zqcBbTGHp7LwDtXQ1vQZN7zwrcfkZXU2FroDA6R5qkwuFTDo3ZDj7cgzARaLMmMVfodPo2W6wty9nqC55JcZV81KxB3of+Afsi5MPBLIb/hF/oPSx29u7M80AkkEeM1xOwmd+nbkcFwEpiAULNT0yFeVQBEg62Gel08HRQnRRNMycd4dBOIHDVuqqOPmEEfky++nA2HYae8zD8LvO8vR1m02nXD9gVOiJZVev0wIhAM5iMwPFKuJBAusvVwUwgcR/AX9X2vDNk35KdZnkPaFMQP71r6g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=JC4rmfq1r30JXFzxESWwLWKQBwXbmOrlpdWDDTn7Q+8=;
 b=KBAp61nLAzgw1Za5y9rXW0hAwBQgoNDEMUn1Y5kh89d0cbLXVRuYftl8EBJyHGBAN7Nk4+DEpv0a2fdhjJvqJtk03Q/Yieu1TSBYQWwM+3N+MOBnxa3u4YwCrl8xlrbQLjG6IKSPsxblFuhf5a/FV034irgfA6jdeKJAVfbFZDdWpGnBDIp2kyGfui7jx/E8QI0NGsG6IlLM6H+6GL20qs7Tn/Zl+REIHvQbPgmTa/K9L0ftUhRxb5ZTiLPw50jEk+qVvRNYYzdy4e7Pw0292pj8QJZqplBdIGiAOQ4pCSpT2LD+1S3BkAxipza8YXdtySQZCIwf82KFCvwjqtAmvA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=JC4rmfq1r30JXFzxESWwLWKQBwXbmOrlpdWDDTn7Q+8=;
 b=Qvdb8ZJgeF7Vcq18zm+JxnbaRY0k24uifZtM9fP9SKRgiDdDpXwZ5f0EbyB5mAnnDl/vBEEZg2bspKQF6vrSKQFOTJDuZBRoSpCFVQtUrCwgXW1F+6Lc9HllkhvzyeL8ov5a0dsNE+qJnV0X1eQflXB84M3LUT/QhYc0kFJy8Es=
From: Roger Pau Monne <roger.pau@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Roger Pau Monne <roger.pau@citrix.com>, Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: [PATCH 3/3] amd/msr: implement VIRT_SPEC_CTRL for HVM guests using legacy SSBD
Date: Tue,  1 Feb 2022 17:46:51 +0100
Message-ID: <20220201164651.6369-4-roger.pau@citrix.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220201164651.6369-1-roger.pau@citrix.com>
References: <20220201164651.6369-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO2P265CA0148.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:9::16) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 1ff70a3a-04bb-48fc-3225-08d9e5a28975
X-MS-TrafficTypeDiagnostic: SN6PR03MB3565:EE_
X-Microsoft-Antispam-PRVS: <SN6PR03MB356523C903B9693AE749902F8F269@SN6PR03MB3565.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: BDUjierzUPpuH0nriDbC8i6BpNMS/Rmhzcv9ljNiQXJuJppk4ehTbeONVCXbip3y2T/lrsKJbBIadufywKwglFb9AoHCdzn0SjTEo8tJEZvN3kHGf1ocOrKY7OATngtLYnkWnsUfHd2Nk9fzhDlaDU5hxBZ7y0L3OVSD3SX3nKJ3JljWjTA2OfToa00aeR/LL/ul1pQkbLa00XQM7OwXsOWoJE2a0TXMSKHqKCCeseNJJQK3xP1Sa5im0AkkwO3/dqYomWEh/mnV9yFoq9ZZrj4e4fHllo4lQcBG5rfQJzMMK+3pwz/L/mnL0FScNIchF7q/6Tc3FVUns8K+l4M3q5Z7hhEKvqxBWnPo4qxWZ/O224OfVVBaFeOEnaK5MmPrN8SjTYQq0fgqwNiiTeSlNi3DCIcA2a4lmMuieOKDiGp8FtHJ3UuiPM6afPrb0t21ScvFECZcFGV7PKZRuQiQ5J5lIgWX+cEE46xfWoBkts4VEMTPek1YnYi88vNzRbmNzddVmohtUUKXVwGdb2GfFkA6aP2dXwUB5utxIvRY49Uw7ESo5q7kY8D0BYkQ7QoLCTgtNzfQtCn+dE1K0Xbb9P3XL08GQ/hloEZ3dgNzKFyCNOPDWXRt+VY3Fi38NfpYq3Wm1oDGLckFmeOHoH8dveT4wN5ywbn6XUkX2yxNLjxIOWOc5HW3VCDDP83MiEC2KSGOkOLXCAhft7LL/VIYgm5liTxr5kzdlSOa+/nH1Sc=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6666004)(66476007)(66946007)(8936002)(4326008)(8676002)(508600001)(5660300002)(66556008)(6486002)(966005)(38100700002)(83380400001)(6506007)(36756003)(6916009)(82960400001)(6512007)(26005)(86362001)(1076003)(186003)(2616005)(2906002)(54906003)(316002)(20210929001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Qi9FcjFKUFZmZWNodmRHNEExb3ZMeDl6V0FkUjZGNmF2MnNnZEFjSENkUFVn?=
 =?utf-8?B?N2hHbzRTeEZ4S3J1bmFOUXRXSkRWdU5DLzU4bGZMMjZWaVU5KzdMMEZyMGhs?=
 =?utf-8?B?S2JnWmJzOVlnRVdjYllWNDlmSmoyOC9vOE9UeENJRGc3TnFMQVhyRzI2OHVv?=
 =?utf-8?B?aTVBYkJYN0U2QVNtK3ZFT3pRKzR3SlNEaXJwdW5XWE1xWThnYTQxRS9JUk9N?=
 =?utf-8?B?cGd2K3hDaWxKVWFIUk5jZkJsdkJ0ZXhYWENzTXk3bUQ4bWJqMllhNUZVVGFo?=
 =?utf-8?B?SzZkbHpPajV5eEFNQ3lPMmFxZUo2aHE3U1pSbTBIVW8xbUpveHlvdXB3V2Rl?=
 =?utf-8?B?WkQyUUZaRkg0Z1pYa1drVUo2UVlwK0xVWUVNWmFqUmREZmkvdlNXTWhBUkpH?=
 =?utf-8?B?S1RldnltM0VFeER2aXBNZzRFUFBlcWZpRHBIN0pYNUY4dk02WGZVN29TbnFQ?=
 =?utf-8?B?T2xhUTJNY2gwMnNtWkttRWZjdHFTc2ZnaGRsTVVHbGcyRHNjVUFLWVJhR3NW?=
 =?utf-8?B?amR4MWFjN2hCUDFRYVBzWkxqNC8weTRvM0lDeGUxbHQxbEZmM25ZMXpIL2J0?=
 =?utf-8?B?RURiSUJmVVQvNE54cXlaR0tpaWt5dTQxV2VWb01LSXVCYmlVK2ZkUW9tVVdm?=
 =?utf-8?B?RHl5Mm9ncmVRWVFnT05nWlMvM1QzOHVUUmdvbXlPcExKcnpnbzhIRS9TdjBj?=
 =?utf-8?B?bFdmWXl6SlR3WnE2NHJnZ0Q3bnJFMDg2blZsK0d6bHVKUEJFZFR6NVRUbjdz?=
 =?utf-8?B?L2F2OVFYY0F2RU9Ocm5kRHFPUEIyUDVFa2w3YWx3QUpjY3RYcm0ycjlhR3dK?=
 =?utf-8?B?SWpVMlpIRWx5c1ZuSUlreU9CM2pDZ00xWERIanNhNk1wWk5lOStBekRJY3hZ?=
 =?utf-8?B?Z1kzODlLYzlGaFVETTBVT0RZaThuYUJiSFI0Ung2RkFKU04yaEhqNkM5M2tZ?=
 =?utf-8?B?YTFxVnZyZzN5QkJVS2svK0lsdlVFQVFSWjdRRFA1R3Z6Ni96YmNqZE9NMTBP?=
 =?utf-8?B?ZTdLKytJVkVyZGoyZEFUcmluK1hremJLWlhaSWdOS1BPVzlUVkpWdGxTbEZ5?=
 =?utf-8?B?MlVxSjB3dzh6cmVueC9rb0lueXlqM21mOWdsbE5zVkJsOUVHc2h5OGMwc3lB?=
 =?utf-8?B?ZmdOSXBkbnVQWXJmL1ZaMTNVVGRhNmkwb0wwU1ZmOUkxRE44TWhScHVraGtX?=
 =?utf-8?B?dkdnVGY0UWJYM3d3RDhyM3Y1TjBYREl5czl4QlJNUjNsNzdwQTZoVk1heERw?=
 =?utf-8?B?T1FQRXUzTmEyekdxK0p4dENITWxQSXZUODNuMFZOOVRmdlJPSytnT1RScGJV?=
 =?utf-8?B?dFBWMWU3KzdHb01TOHViOFRuSHhvaXZNNloxeXJpQU9SZTB5amlPOTlkVXE3?=
 =?utf-8?B?Z3JwWHF0TExqQVlIZTh5RUdLWFArUDNpRitLcGJ4eWN2UG9tQTFlRjhKa1gw?=
 =?utf-8?B?OHV1TU9hSmgxd2tDN1h1ank3OC9OTGM2cFRTa2lNc3BsZ2UvWFRVZFN0Ylhv?=
 =?utf-8?B?VFV0S1Znd3dOS1VFd1o3NUtKNDZEb0dSeDllMFZhYjEzZVRKZkpkbElCM2ZS?=
 =?utf-8?B?THN4UHE5cm9kZGJwUW0rNmhFZzFvb2hxZjdhV29UalRycGpDVmFSWStPcnlC?=
 =?utf-8?B?SlQxejN4STBvRDFYcDlyVnFSZFN2TFJYditObjBiT1EybE5tclk0cStqUkxs?=
 =?utf-8?B?WndZMUVkUUhUelNGQ1dqM294eis0SGpuTk9vR1JMNXRZeTAvUWZOZjFmaHlK?=
 =?utf-8?B?TWE4NWcvY3dTMjZnVmhkNGl2cjdwZHY2Y004Y05tTEdXVDMwMnB4Y0Zac0Jl?=
 =?utf-8?B?MXFtUTg1T0tPc3NXbzJsNDBFcXlSOWk5L1BTUTVtRmtkMS9sRUZQSjZvQVBv?=
 =?utf-8?B?TFYrM2NCUWo5UURuaWczbUhrY1J1Mis4bkdzUmZDdHNLMXV5U1lNL09sR0NS?=
 =?utf-8?B?VkdJYWk2Z005MVJmOFRxZHNyTUNwNGl1cXVpQ1dONDVpWVJ4QVhvZ3pBd3Rh?=
 =?utf-8?B?bCtZUGhaMjIxTlRIWHJBN3RKNjB0WThjS1N5WlY5UGtzVnRuSUtUbGx6WFRO?=
 =?utf-8?B?Qlc1UkhrdnRiN3l3aGNrS0lxMHRTMXQ2aHQ3ZDVwWU5SbmVkRlUxUTc2bWdx?=
 =?utf-8?B?K1ZXQXRJSnlDSGthekc5bTNZQXFsM2ZCaEhxNFlkSXZQd2V2ZWs0VXlaekFE?=
 =?utf-8?Q?BnQZypxS7ExLSKOSqbZOfmE=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 1ff70a3a-04bb-48fc-3225-08d9e5a28975
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2022 16:47:30.4507
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DBFq+biCchyuE2/+AQ9Mn0kx0Wem6f2jlZNgFh64FYYxJEJ5KjiPOIK7FpycTTP/BJJp8DmS76xEdP191Vfo8Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR03MB3565
X-OriginatorOrg: citrix.com

Expose VIRT_SPEC_CTRL to guests if the hardware supports setting SSBD
in the LS_CFG MSR. Different AMD CPU families use different bits in
LS_CFG, so exposing VIRT_SPEC_CTRL.SSBD allows for an unified way of
setting SSBD on AMD hardware that's compatible migration wise,
regardless of what underlying mechanism is used to set SSBD.

Note that on AMD Family 17h (Zen 1) the value of SSBD in LS_CFG is
shared between threads on the same core, so there's extra logic in
order to synchronize the value and have SSBD set as long as one of the
threads in the core requires it to be set. Such logic also requires
extra storage for each thread state, which is allocated at
initialization time.

Do the context switching of the SSBD selection in LS_CFG between
hypervisor and guest in the same handler that's already used to switch
the value of VIRT_SPEC_CTRL in the hardware when supported.

Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
 xen/arch/x86/cpu/amd.c                 | 113 +++++++++++++++++++++----
 xen/arch/x86/hvm/svm/svm.c             |  14 ++-
 xen/arch/x86/include/asm/amd.h         |   3 +
 xen/arch/x86/include/asm/cpufeatures.h |   1 +
 xen/arch/x86/spec_ctrl.c               |   4 +-
 5 files changed, 115 insertions(+), 20 deletions(-)

diff --git a/xen/arch/x86/cpu/amd.c b/xen/arch/x86/cpu/amd.c
index c3fcc0e558..7318623874 100644
--- a/xen/arch/x86/cpu/amd.c
+++ b/xen/arch/x86/cpu/amd.c
@@ -685,24 +685,10 @@ void amd_init_lfence(struct cpuinfo_x86 *c)
  * Refer to the AMD Speculative Store Bypass whitepaper:
  * https://developer.amd.com/wp-content/resources/124441_AMD64_SpeculativeStoreBypassDisable_Whitepaper_final.pdf
  */
-void amd_init_ssbd(const struct cpuinfo_x86 *c)
+static bool set_legacy_ssbd(const struct cpuinfo_x86 *c, bool enable)
 {
-	struct cpu_info *info = get_cpu_info();
 	int bit = -1;
 
-	if (cpu_has_ssb_no)
-		return;
-
-	if (cpu_has_amd_ssbd) {
-		/* Handled by common MSR_SPEC_CTRL logic */
-		return;
-	}
-
-	if (cpu_has_virt_ssbd) {
-		wrmsrl(MSR_VIRT_SPEC_CTRL, opt_ssbd ? SPEC_CTRL_SSBD : 0);
-		goto out;
-	}
-
 	switch (c->x86) {
 	case 0x15: bit = 54; break;
 	case 0x16: bit = 33; break;
@@ -716,26 +702,117 @@ void amd_init_ssbd(const struct cpuinfo_x86 *c)
 		if (rdmsr_safe(MSR_AMD64_LS_CFG, val) ||
 		    ({
 			    val &= ~mask;
-			    if (opt_ssbd)
+			    if (enable)
 				    val |= mask;
 			    false;
 		    }) ||
 		    wrmsr_safe(MSR_AMD64_LS_CFG, val) ||
 		    ({
 			    rdmsrl(MSR_AMD64_LS_CFG, val);
-			    (val & mask) != (opt_ssbd * mask);
+			    (val & mask) != (enable * mask);
 		    }))
 			bit = -1;
 	}
 
-	if (bit < 0)
+	return bit >= 0;
+}
+
+void amd_init_ssbd(const struct cpuinfo_x86 *c)
+{
+	struct cpu_info *info = get_cpu_info();
+
+	if (cpu_has_ssb_no)
+		return;
+
+	if (cpu_has_amd_ssbd) {
+		/* Handled by common MSR_SPEC_CTRL logic */
+		return;
+	}
+
+	if (cpu_has_virt_ssbd) {
+		wrmsrl(MSR_VIRT_SPEC_CTRL, opt_ssbd ? SPEC_CTRL_SSBD : 0);
+		goto out;
+	}
+
+	if (!set_legacy_ssbd(c, opt_ssbd)) {
 		printk_once(XENLOG_ERR "No SSBD controls available\n");
+		return;
+	}
+
+	if (!smp_processor_id())
+		setup_force_cpu_cap(X86_FEATURE_LEGACY_SSBD);
 
  out:
 	info->last_spec_ctrl = info->xen_spec_ctrl = opt_ssbd ? SPEC_CTRL_SSBD
 							      : 0;
 }
 
+static struct ssbd_core {
+    spinlock_t lock;
+    unsigned int count;
+} *ssbd_core;
+static unsigned int __read_mostly ssbd_max_cores;
+
+bool __init amd_setup_legacy_ssbd(void)
+{
+	unsigned int i;
+
+	if (boot_cpu_data.x86 != 0x17 || boot_cpu_data.x86_num_siblings == 1)
+		return true;
+
+	/*
+	 * One could be forgiven for thinking that c->x86_max_cores is the
+	 * correct value to use here.
+	 *
+	 * However, that value is derived from the current configuration, and
+	 * c->cpu_core_id is sparse on all but the top end CPUs.  Derive
+	 * max_cpus from ApicIdCoreIdSize which will cover any sparseness.
+	 */
+	if (boot_cpu_data.extended_cpuid_level >= 0x80000008) {
+		ssbd_max_cores = 1u << MASK_EXTR(cpuid_ecx(0x80000008), 0xf000);
+		ssbd_max_cores /= boot_cpu_data.x86_num_siblings;
+	}
+	if (!ssbd_max_cores)
+		return false;
+
+	/* Max is two sockets for Fam17h hardware. */
+	ssbd_core = xzalloc_array(struct ssbd_core, ssbd_max_cores * 2);
+	if (!ssbd_core)
+		return false;
+
+	for (i = 0; i < ssbd_max_cores * 2; i++) {
+		spin_lock_init(&ssbd_core[i].lock);
+		/* Record the current state. */
+		ssbd_core[i].count = opt_ssbd ?
+				     boot_cpu_data.x86_num_siblings : 0;
+	}
+
+	return true;
+}
+
+void amd_set_legacy_ssbd(bool enable)
+{
+	const struct cpuinfo_x86 *c = &current_cpu_data;
+	struct ssbd_core *core;
+	unsigned long flags;
+
+	if (c->x86 != 0x17 || c->x86_num_siblings == 1) {
+		set_legacy_ssbd(c, enable);
+		return;
+	}
+
+	ASSERT(c->phys_proc_id < 2);
+	ASSERT(c->cpu_core_id < ssbd_max_cores);
+	core = &ssbd_core[c->phys_proc_id * ssbd_max_cores + c->cpu_core_id];
+	spin_lock_irqsave(&core->lock, flags);
+	core->count += enable ? 1 : -1;
+	ASSERT(core->count <= c->x86_num_siblings);
+	if ((enable  && core->count == 1) ||
+	    (!enable && core->count == 0))
+		BUG_ON(!set_legacy_ssbd(c, enable));
+	spin_unlock_irqrestore(&core->lock, flags);
+}
+
 void __init detect_zen2_null_seg_behaviour(void)
 {
 	uint64_t base;
diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c
index 56c7b30b32..10a5a77ad7 100644
--- a/xen/arch/x86/hvm/svm/svm.c
+++ b/xen/arch/x86/hvm/svm/svm.c
@@ -3134,6 +3134,15 @@ void vmexit_virt_spec_ctrl(void)
             wrmsr(MSR_VIRT_SPEC_CTRL, val, 0);
         curr->arch.msrs->spec_ctrl.raw = lo;
         info->last_spec_ctrl = val;
+
+        return;
+    }
+
+    ASSERT(boot_cpu_has(X86_FEATURE_LEGACY_SSBD));
+    if ( val != info->last_spec_ctrl )
+    {
+        amd_set_legacy_ssbd(val & SPEC_CTRL_SSBD);
+        info->last_spec_ctrl = val;
     }
 }
 
@@ -3147,7 +3156,10 @@ void vmentry_virt_spec_ctrl(void)
     ASSERT(!boot_cpu_has(X86_FEATURE_SC_MSR_HVM));
     if ( val != info->last_spec_ctrl )
     {
-        wrmsr(MSR_VIRT_SPEC_CTRL, val, 0);
+        if ( boot_cpu_has(X86_FEATURE_LEGACY_SSBD) )
+            amd_set_legacy_ssbd(val & SPEC_CTRL_SSBD);
+        else
+            wrmsr(MSR_VIRT_SPEC_CTRL, val, 0);
         info->last_spec_ctrl = val;
     }
 
diff --git a/xen/arch/x86/include/asm/amd.h b/xen/arch/x86/include/asm/amd.h
index a82382e6bf..823e2f3bd2 100644
--- a/xen/arch/x86/include/asm/amd.h
+++ b/xen/arch/x86/include/asm/amd.h
@@ -151,4 +151,7 @@ void check_enable_amd_mmconf_dmi(void);
 extern bool amd_acpi_c1e_quirk;
 void amd_check_disable_c1e(unsigned int port, u8 value);
 
+bool amd_setup_legacy_ssbd(void);
+void amd_set_legacy_ssbd(bool enable);
+
 #endif /* __AMD_H__ */
diff --git a/xen/arch/x86/include/asm/cpufeatures.h b/xen/arch/x86/include/asm/cpufeatures.h
index a2c37bfdd4..f12d423fe9 100644
--- a/xen/arch/x86/include/asm/cpufeatures.h
+++ b/xen/arch/x86/include/asm/cpufeatures.h
@@ -40,6 +40,7 @@ XEN_CPUFEATURE(SC_VERW_HVM,       X86_SYNTH(24)) /* VERW used by Xen for HVM */
 XEN_CPUFEATURE(SC_VERW_IDLE,      X86_SYNTH(25)) /* VERW used by Xen for idle */
 XEN_CPUFEATURE(XEN_SHSTK,         X86_SYNTH(26)) /* Xen uses CET Shadow Stacks */
 XEN_CPUFEATURE(VIRT_SC_MSR_HVM,   X86_SYNTH(27)) /* MSR_VIRT_SPEC_CTRL exposed to HVM */
+XEN_CPUFEATURE(LEGACY_SSBD,       X86_SYNTH(28)) /* LS_CFG available for SSBD */
 
 /* Bug words follow the synthetic words. */
 #define X86_NR_BUG 1
diff --git a/xen/arch/x86/spec_ctrl.c b/xen/arch/x86/spec_ctrl.c
index 2c46e1485f..c7f8ec29f4 100644
--- a/xen/arch/x86/spec_ctrl.c
+++ b/xen/arch/x86/spec_ctrl.c
@@ -22,6 +22,7 @@
 #include <xen/param.h>
 #include <xen/warning.h>
 
+#include <asm/amd.h>
 #include <asm/hvm/svm/svm.h>
 #include <asm/microcode.h>
 #include <asm/msr.h>
@@ -1056,7 +1057,8 @@ void __init init_speculation_mitigations(void)
             setup_force_cpu_cap(X86_FEATURE_SC_MSR_HVM);
     }
 
-    if ( opt_msr_sc_hvm && cpu_has_virt_ssbd )
+    if ( opt_msr_sc_hvm && (cpu_has_virt_ssbd ||
+         (boot_cpu_has(X86_FEATURE_LEGACY_SSBD) && amd_setup_legacy_ssbd())) )
         setup_force_cpu_cap(X86_FEATURE_VIRT_SC_MSR_HVM);
 
     /* If we have IBRS available, see whether we should use it. */
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Tue Feb 01 16:47:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 01 Feb 2022 16:47:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.263672.456511 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEwJq-0002od-Ie; Tue, 01 Feb 2022 16:47:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 263672.456511; Tue, 01 Feb 2022 16:47:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEwJq-0002oW-Ez; Tue, 01 Feb 2022 16:47:50 +0000
Received: by outflank-mailman (input) for mailman id 263672;
 Tue, 01 Feb 2022 16:47:49 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JAuK=SQ=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nEwJp-0001jp-EM
 for xen-devel@lists.xenproject.org; Tue, 01 Feb 2022 16:47:49 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ae893b9a-837e-11ec-8eb8-a37418f5ba1a;
 Tue, 01 Feb 2022 17:47:47 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ae893b9a-837e-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1643734067;
  h=from:to:cc:subject:date:message-id:
   content-transfer-encoding:mime-version;
  bh=iQ8aKLKi+QRqm0WFp5cY9I2IT2KtztKgt4ISNOrHVJo=;
  b=CnepMP1HNjytUTBCDPC5hdKLWqzSlqRFuLIda0T26xP3pwBJr3uzu0lD
   rpr1EBpE42sSWW2IyF13rgc8RfuWBV6ZBb7NhVAEV9fj0JxHNDUTALAUE
   EEZhCUK9b4v4oPpiu4VcJsM3RBISkVIbj/SjAcSgLE695Ukr8lcKbUaJL
   g=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: rBm4U5mhg7EzJd67m+tOSkD1koJKCPx5b6mkyO5J4Hk32Mvk8mCEo1gp+JaYXLndmlnK/WKAoo
 1IrDWcqdKO+UMUD3vtG0mtsluzZdA7iw1pKsDfP6LlJxXXuXPCDc3CuAD7HSh7vklsIE6HGcGW
 hnJALZOvI7qNpQVpZqK4FLtk7HZzjNMoyP2TqN67bVxPsLH+/HIICuJcr456/4rxCNOAq5l1A+
 5Azl0LsorCbpYTlbYggjtnzAbvUx4e4ZT09TuhKWYHxiZ5QEXKoZGXMoEgGGv2GOv/T+G2cuWE
 k9kSrRwiCab53pWQjHHCsMkq
X-SBRS: 5.2
X-MesageID: 63644287
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:g2qAoaxIveAvFIEdeIp6t+e+wSrEfRIJ4+MujC+fZmUNrF6WrkUEz
 GAaCj+GOfnfNDHyctglb4m19k4FuZXSnYA1QVNs/iAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAhLeNYYH1500g7wbZg2tQAbeWRWGthh
 /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL
 wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt95O1
 vdkiZe/cgECOb/xqP5AAjgfHj4raMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr
 6ZBbmlQMFbT3Ipaw5riIgVort4kI8TxepsWp1lrzC3DDOZgSpfGK0nPzYEDgmts3JARdRrYT
 9UrNzFtXhfHWixSO3MoJIMHzMCF3WaqJlW0r3rK/PFqsgA/1jdZy6PxOdDYftiLQ8R9nUuCo
 G/CuWPjDXkyK9i32TeDtHW2iYfnnz7/WY8UPK218LhtmlL77nweDlgaWEW2pdG9i1WiQJRPJ
 koM4C0soKMuskuxQbHVXRe1vXqFtR40QMdLHqsx7wTl90bPy1/HXC5eFGcHMYF48p9tLdA36
 rOXt93WGx5GjLaacnS28aWpnSnvaAlSIHBXMEfoUjA5y9XkpYgyiDfGQdBiDLO5g7XJJN3g/
 9yZhHNg3utO1Kbnw43+pAma2Gz0+vAlWyZovl2/Y46z0u9uiGdJjaSM4EOT0/tPJZ3xorKp7
 CldwJj2AAzj4PiweM2xrAclQevBCxWtamS0bbtT838JrW7FF5mLJtg43d2GDB01WvvogBewC
 KMphStf5YVIIFyhZrJtboS6BqwClPa8Tom1CaiEMIsSM/CdkTNrGgk0PyZ8OEi2yCARfVwXY
 8/HIa5A815HYUiY8NZGb7hEiuJ6rszP7WjSWYr633yaPUm2PxaopUM+GALWNIgRtfrcyC2Mq
 oo3H5bUl313DbOvCgGKod97BQ1bdhATWMGpw/G7g8beeGKK7kl7Va+IqV7gEqQ495loehDgp
 SDgAxIIlQak2BUq62yiMxheVV8mZr4mxVoTNi0wJ1e4nX8lZIek9qAEcJUrO7Ig8YReITRcF
 altlxyoDqsdRzLZ1S4aaJWh/oVueA7y3VCFPja/YSh5dJllHlSb9tjhdwrp1S8PEivo6pdu/
 +z+jlvWEcgZWgBvLMfKc/bznVm/imcQxbBpVEzSL9gNJEi1qNp2Kzb8h+McKt0XLUmR3SOT0
 gubWE9KpeTEr4Iv3sPOgKSI89WgH+dkRxIIFGjH97emcyLd+zP7k4NHVe+JexHbVX/1p/r+N
 bkEkamkPaRezlhQsod6H7J69o4E5oPi9+1A0wBpPHTXdFD3WLluFWaLgJtUvapXy74H5QbvA
 hCT+sNXMKmiMd/+FAJDPxIsa+mO2K1GmjTW6vhpckz26DUuoeiCWERWeRKNlDZcPP1+N4Z8m
 bUtv8sf6gqejBs2M4nZ0nAIpjrUdnFQAb86spw6AZPwjlt5w15PVpXQFyvq7czdcN5LKEQrf
 meZiaeqa26wHaYen67fzUTw4Nc=
IronPort-HdrOrdr: A9a23:Io519K/3Bij5WvpnrtRuk+E2db1zdoMgy1knxilNoENuHPBwxv
 rAoB1E73PJYVYqOE3Jmbi7Sc69qBTnhONICOgqTM2ftWzd2VdAQ7sSlLcKrweQfhEWldQtq5
 uIEZIOcOEYZGIS5a2RjXjaYrQdKbG8gd+VbIzlvhFQpG9RGsVdB1ATMHfmLqQ6fngPObMJUL
 6nouZXrTupfnoaKuy9G3k+RuDG4/nGjojvbxIqDwMurFDmt0Lj1JfKVzyjmjsOWTJGxrkvtU
 DDjgzC/62m99W20AXV2WP/54lf3PHh1txALsqRjdV9EESmti+YIKBaH5GStjE8p++irH4sjd
 n3uh8le/9+7nvAF1vF1ifF6k3F6nID+nXiwViXjT/IusriXg83DMJHmMZwbgbZw1BIhqAy7I
 t7m0ai87ZHBxLJmyrwo/LSUQtxq0ayqX0+1cYOkn1kV5cEYrM5l/1SwKpsKuZAIMvG0vFmLA
 E3Z/usp8q+MGnqIkwxh1MfjuBFBR8Ib1W7qktrgL3g79EZpgE986Ii/r1uop43zuNJd3B13Z
 W0Dk1WrsA8ciZvV9MHOA4ge7rANoWfe2OEDIqtSW6XZp3vfUi976LK3A==
X-IronPort-AV: E=Sophos;i="5.88,334,1635220800"; 
   d="scan'208";a="63644287"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=nVZn64yVMjR/KyHngXzqdOmfNdtDKiqRqnOWqDJ4Bd/0IDq382Ygi6jYnktIR3WAM1Pfk1acmaTkKKvW1p7Oe5Q7R7rLZRmRiFlYKfuEVM6H8PelONuqtH+rhq5jC4laNGz2X3UOhjP8z1XV5+3E0ZUfvehK+tHocBm80UP4WGSzKAibdScsDmq6nYAzzCqRQmMShLsrKwzy8yzDCTaPh6/T1vxTf0fQcoWR8CiAcwr4cN59pCrG7cFl6xeoIJ4/9l69PSDVDwkYkoj2h62SzFs1TpJozh16jMYJmJXpVAnh578T2e8W7KXOuDHaC2U30kmDz7jJev27VW/4zRHkQw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=hGPY1jN8DxvfaKtqXBqMnzr4TdR32OJ/pPgeJPgLEX4=;
 b=kaxYvJmUBtk4jxsSkM6zeVqOWKPTXk8clMYZ0GSmDVnBTFibFHsXHKcHrL92TWcFQCoXJxDPqFr8NOWg4NiSQDMaNyV9IJpQMpDEQ8FtvVZC6xSunsfSlK4QBARJkY8EBfpcNtjtTjHTWuI3MPCq/7pjzYO0Nl+Cr0LnNKJj3FmW5yv8QvH061EdlcmeKsHGIWD6STiCiAC7VXla3v8/1JeTTlUTWl9EL/hqrk68DvlQT9KSfXcwcj7hHFXrlcK4lE+Vh5z0z8XwV0OweYSFhly3+zZY45VBbtAY15z6iECVaFoDppLBuQWCOYeiiJhs31IH+c9znKe/SiFpP5pTKg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=hGPY1jN8DxvfaKtqXBqMnzr4TdR32OJ/pPgeJPgLEX4=;
 b=PoMM35FnbA8FyTbfKoJr8K9XKz4Il8FXKmbcy8GJN2m1D5G9FG/qjoutbar88+jPxTSqijcph/LuaJtlMfYE+h8M20G2IeWKnAU7S2qr2wjXK504Wy56EX4PT1TwPJWTjGWJUrQMdHZAFrkoPh7ArVnscTjTKBDjC7eGcA8T6IE=
From: Roger Pau Monne <roger.pau@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Roger Pau Monne <roger.pau@citrix.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, "Jan
 Beulich" <jbeulich@suse.com>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Subject: [PATCH 0/3] amd/msr: implement MSR_VIRT_SPEC_CTRL for HVM guests
Date: Tue,  1 Feb 2022 17:46:48 +0100
Message-ID: <20220201164651.6369-1-roger.pau@citrix.com>
X-Mailer: git-send-email 2.34.1
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO4P265CA0009.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:2ad::12) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 67e59fdb-8660-444c-61c3-08d9e5a280ec
X-MS-TrafficTypeDiagnostic: SN6PR03MB3565:EE_
X-Microsoft-Antispam-PRVS: <SN6PR03MB3565335419097738D6A28FAB8F269@SN6PR03MB3565.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3631;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: eGxltsL0f/Za4UVeC5LQRhhNOe7mv+QfrtlZhjmBxpctJvYYIlZsCPGcVPsN3x4OVE5q40uk9Mt4UVRuY9piI2M1WcZf67VyDCmjP7xvvJQUie5/PLR/N+28fI2rBy0U8vBm7HNP2+SzLGyw2ivQuQO2lcdR1b6lMf4nx8i+g8qarfCvwSHfwo4V/e6GZL0LkDTtISd4vOI0ZL4niB8QzI4yqXzUGlc+FfM+jm/ktK7Ln74sUJkqA1aJjAW7PFO/LgmwevS3ZEAsuOVcHz+L0p98ChvgDNsuaqoYBXXGi+oJMqRylVf5fitlN5wxV+xvdJycM9hNElZ+GmWyM7xSqW7e0aguKeqPoTYiIO6fCkQjKjA80ZGzONfbGQwMX9hQRCs8mRWblJSU1XniUGnIlpu4M+rcrl5SFXqnWvU+ErFNeby6j3IhPCHY5aRKfIFOu2luslE3H2Eju+9u5oo+Z3tPr+KtJKer0ZmXVd/wLADRubJBzpEP3bW2k93p60tqsuJYMd4R1HXmAcfQ3q8HFCVAfkuTz5ie364mNLwwvL+/28WdMB0jYZ8WiPRtJd0i9WglBlh2MfAJYVgURQcmZ18saAKKy5ilEuLbdeAc9Ay3um6X2o1efIK8VbdF0KsUBx0Tkkf34E4iWOyybPTNVQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6666004)(66476007)(66946007)(8936002)(4326008)(8676002)(508600001)(5660300002)(66556008)(6486002)(38100700002)(83380400001)(6506007)(36756003)(6916009)(82960400001)(6512007)(26005)(86362001)(1076003)(186003)(2616005)(2906002)(54906003)(316002)(20210929001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SFpPUFZRTDM4RzdPNHBncFY0M2ZDaWoyMTFyNHF5QnhLMEhPSHdoclA5Z1Fm?=
 =?utf-8?B?QlRhcWVnMHdwMy96Tjl6TnE5K3FQQWNmZHlKZVdqcDlkM1lYQWtpcDZCbzBB?=
 =?utf-8?B?RDdiRmd2M3p1NG10TU9wcGpQTmwyV3JuMml3SURycnNpTVpmbFhHTzN2U2RE?=
 =?utf-8?B?MHEwWWU0Z1NiWGM2R0puSk5uaXY4dVZSdmpINlQvcG52bFNSZXhpVDZpOHY4?=
 =?utf-8?B?Y20zSVVIMW1NOXNkaDRnbGcyWVAzVXJ2aEd6Y3JReTZwWEt4bTQwK1JrWGY5?=
 =?utf-8?B?eXZkT21HRStIVG5oY0ZyVVJaTmNKTWxNMGt1bWN5VDlmbHFSY3Z1VmtNT2Jh?=
 =?utf-8?B?MnhKYTNzaUp4cTdZaDFhOXp1WnNKWXJzVFVGek9wVWF0UVF2NndaejJYZUxB?=
 =?utf-8?B?UDZKQUhUVFRmU2J0UmkrTjlVc3lFa0ptaFV5dzRLWThrZ3RBUE1wSmU0aUp3?=
 =?utf-8?B?QjM5V1lMQU4vU2E1M0c4emZ2ZDlMNFM5R1djbTdQcmlzUnJTREtpSzUrL0V3?=
 =?utf-8?B?RkVjNkZ6bStQcmtQMGpFRkZpQlpHdFVPTnZlcmhuaFRXS0JIMjZoUWMwTmNj?=
 =?utf-8?B?dEsxNFRyV3JrZmZtUUttMm01eHNJcTVpOUdBbjU0UnlqbmkxTDVrS0ZtdlQz?=
 =?utf-8?B?eWltN2toRlhZcFBNb29LUnpEcTRWSVVmQ3Bsd291YTlEcnFveUlCT3FIdkgz?=
 =?utf-8?B?Q2tsNnhJNmNlQWNDM1lmbWhhSUl0bjBjbS85RzlaVUYyWGVRY3grT2pZcGxO?=
 =?utf-8?B?SW1UU0ZpekxJZmFVMi9Dd2VjS3I5ajdHcUMrcHBQMmxxREdQN2UxL2E4TW9U?=
 =?utf-8?B?Ykh5dFRjSjVWNkxTdWhCOWo4MXFObUhrTExkZDdmSldTUkpYelFOOFAxc2JI?=
 =?utf-8?B?blY1ODhJNW4vZHhaOG5OMVc3K3MxWHUxNkxkL25WeTJoaE1hK3M1MkJpWVJk?=
 =?utf-8?B?Z05xTW16amtNL0ZSVmtEYkhmcVQ0YWpsRVVkQmUxQkFqRkZrRGs0UVZLbUll?=
 =?utf-8?B?ZGhtTXBIZll3ZG1iN285dGxJM2JWZ0RHRXJtWGZOV3FGUlBwT0ZiRWtQdEJE?=
 =?utf-8?B?NGV1UHdkc0tGZnJLNlVxNUhqcmJmMXZJWlBTZVFQT1dXWHJsd29KVXVDTGlP?=
 =?utf-8?B?TTZIT2RzRTIxdTZvY1B0YXVIcXRjRXlFSm10L1RMTVVSOVdJOEtHWi9kTS8v?=
 =?utf-8?B?WlUvRHR3UjBMTjB5WkMyWGJKaUZuVXpMZzdJUHozRkdLbC9VK2dydXNjUG1s?=
 =?utf-8?B?VDhraXF2b1loaVArcGw3UjNMZGp0TFllTVZiVXgxVmZvSDRxKzlxQ2FFRktx?=
 =?utf-8?B?TkJ6UHA2RndhcERQWldSODVDbitXVW43NUh4d2ZDMVZiekFRNE05UnRwZHlt?=
 =?utf-8?B?d091UUxkanU5ZnRaTFJCTjlUdGIrWDh0K2I2YkV5aXUzaFNLTTVvN3J2TUpB?=
 =?utf-8?B?RVVlbndVaXVYekdsT29yOEFTMmVoNVZXVHpXZ1NZU040Nno2eS91QXhWRnpn?=
 =?utf-8?B?aTlUbW96MHRsNkwzQytxcDUyZ05vdFVTMHRLOHV3QUtlN0FtMjlreGVGZzdF?=
 =?utf-8?B?STFYNXZnS2tLR1BlNzl1QVYxa3czMEppbTV4eEFmbVB5WDcwZ1VpNHMwcXJu?=
 =?utf-8?B?QXlBUjhZUWlvZ3Q0Z1h3Wk1nWVVwcytsd0pmUVlEZko4QVpGb3JLU251eDlh?=
 =?utf-8?B?L2crVi85OWxqZXA1NTYwTGZoYzRGY0hOUjhYVnMzUWZUTmlnNFdDVmZhVUIv?=
 =?utf-8?B?QnBuK1o2T1BBU0MySDhhY2s5OHR0ZzR4dXVINEROTHZNelVWV0ZTOG50Z0ht?=
 =?utf-8?B?STZ4U2o5LzhTL3pmQkMyMzh1ZEphU1dLV0hkNDlIZU4xS2w0TTJvOTNyZmJQ?=
 =?utf-8?B?U1BsUUNVblNkbmJwSXdQY0VVS05xd25nNVBrZ2lnV2Q0c2VJeXZRZDJUZlFz?=
 =?utf-8?B?R0lLY0hpcWVwcklWSUUwSGRFVUh1Qk9RbmlEYnQ4TnZCbGdKdndTbWZrRllr?=
 =?utf-8?B?QmtGSXd1R2FvbzY4REFXb285NDJzdnNqaktzakRnM0JuUmQ1QU9nMGxmRnpJ?=
 =?utf-8?B?VVNYK0FvRmtlZWM1MDIxMHlpeXM5K2c3N29pbnN4SEl3UU9iUHQ5TDJad1U2?=
 =?utf-8?B?NnV6ZFdnMHpKQlBkbjc1UEIwZXlpYnUxSXRYTmozUnlJSUE5K0g4YU9DS0Jz?=
 =?utf-8?Q?zjLxDMKO0bBF8hpc8clz7Tc=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 67e59fdb-8660-444c-61c3-08d9e5a280ec
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2022 16:47:16.1960
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uGcJfQOzqHlEU7tVt7ky2yj5IO7me2txUJ29ntI6JZRSGzyOipS1PXblHX006fwd5vEfnXDEmdAHgAM31pW1tA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR03MB3565
X-OriginatorOrg: citrix.com

Hello,

The following series implements support for MSR_VIRT_SPEC_CTRL on
different AMD CPU families.

Note that the support is added backwards, starting with the newer CPUs
that support MSR_SPEC_CTRL and moving to the older ones either using
MSR_VIRT_SPEC_CTRL or the SSBD bit in LS_CFG.

First patch is quite clean, as it uses the shadow SPEC_CTRL in order to
set the SSBD bit and have it context switched by Xen using the existing
logic recently added.

The next two patches introduce a different way to context switch SSBD
either depending on the underlying SSBD support, so it's either using
VIRT_SPEC_CTRL or the LS_CFG MSR. They also kind of overload the usage of
several spec_ctrl variables in the hypervisor in order to store the
status of SSBD even when not using MSR_SPEC_CTRL itself. I've tried to
document those in the commit messages, but it could be controversial.

Thanks, Roger.

Roger Pau Monne (3):
  amd/msr: implement VIRT_SPEC_CTRL for HVM guests on top of SPEC_CTRL
  amd/msr: allow passthrough of VIRT_SPEC_CTRL for HVM guests
  amd/msr: implement VIRT_SPEC_CTRL for HVM guests using legacy SSBD

 docs/misc/xen-command-line.pandoc           |   5 +-
 xen/arch/x86/cpu/amd.c                      | 116 +++++++++++++++++---
 xen/arch/x86/cpuid.c                        |  18 +++
 xen/arch/x86/hvm/hvm.c                      |   1 +
 xen/arch/x86/hvm/svm/entry.S                |   8 +-
 xen/arch/x86/hvm/svm/svm.c                  |  67 +++++++++++
 xen/arch/x86/include/asm/amd.h              |   3 +
 xen/arch/x86/include/asm/cpufeatures.h      |   2 +
 xen/arch/x86/include/asm/msr.h              |   6 +-
 xen/arch/x86/msr.c                          |  15 +++
 xen/arch/x86/spec_ctrl.c                    |  11 +-
 xen/include/public/arch-x86/cpufeatureset.h |   2 +-
 12 files changed, 230 insertions(+), 24 deletions(-)

-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Tue Feb 01 17:03:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 01 Feb 2022 17:03:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.263699.456521 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEwZD-0005vD-TQ; Tue, 01 Feb 2022 17:03:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 263699.456521; Tue, 01 Feb 2022 17:03:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEwZD-0005v6-QT; Tue, 01 Feb 2022 17:03:43 +0000
Received: by outflank-mailman (input) for mailman id 263699;
 Tue, 01 Feb 2022 17:03:42 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=wubh=SQ=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1nEwZC-0005v0-CG
 for xen-devel@lists.xenproject.org; Tue, 01 Feb 2022 17:03:42 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id e784beee-8380-11ec-8eb8-a37418f5ba1a;
 Tue, 01 Feb 2022 18:03:41 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 15C026D;
 Tue,  1 Feb 2022 09:03:40 -0800 (PST)
Received: from e123311-lin.arm.com (unknown [10.57.1.119])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4C7A23F40C;
 Tue,  1 Feb 2022 09:03:39 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e784beee-8380-11ec-8eb8-a37418f5ba1a
From: Michal Orzel <michal.orzel@arm.com>
To: xen-devel@lists.xenproject.org
Cc: Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>
Subject: [PATCH] tools/configure.ac: Replace macro AC_HELP_STRING
Date: Tue,  1 Feb 2022 18:03:21 +0100
Message-Id: <20220201170321.32510-1-michal.orzel@arm.com>
X-Mailer: git-send-email 2.29.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

... with AS_HELP_STRING as the former is obsolete according
to GNU autoconf 2.67 documentation.

Signed-off-by: Michal Orzel <michal.orzel@arm.com>
---
 tools/configure.ac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/configure.ac b/tools/configure.ac
index 5a4fb9022d..f29c319b42 100644
--- a/tools/configure.ac
+++ b/tools/configure.ac
@@ -215,7 +215,7 @@ AC_SUBST(qemu_xen_path)
 AC_SUBST(qemu_xen_systemd)
 
 AC_ARG_WITH([stubdom-qmp-proxy],
-    AC_HELP_STRING([--stubdom-qmp-proxy@<:@=PATH@:>@],
+    AS_HELP_STRING([--stubdom-qmp-proxy@<:@=PATH@:>@],
         [Use supplied binary PATH as a QMP proxy into stubdomain]),[
     stubdom_qmp_proxy="$withval"
 ],[
-- 
2.29.0



From xen-devel-bounces@lists.xenproject.org Tue Feb 01 17:05:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 01 Feb 2022 17:05:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.263704.456533 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEwac-0006Te-86; Tue, 01 Feb 2022 17:05:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 263704.456533; Tue, 01 Feb 2022 17:05:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEwac-0006TX-4e; Tue, 01 Feb 2022 17:05:10 +0000
Received: by outflank-mailman (input) for mailman id 263704;
 Tue, 01 Feb 2022 17:05:09 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nEwaa-0006TN-VJ
 for xen-devel@lists.xenproject.org; Tue, 01 Feb 2022 17:05:08 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nEwaZ-0008Un-Be; Tue, 01 Feb 2022 17:05:07 +0000
Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=[10.95.141.48])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nEwaZ-0005Oo-4H; Tue, 01 Feb 2022 17:05:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=mCabRdLzecYi21RUKUf8GiXL6En4ciaveMncdhDTlv4=; b=Uozi72T5OVxcxeAPYT1vMnIr1X
	aAC7Ujcqd4GemTnzx2yYdXQJHedCc4vr235MQh7cK2Jufw+rirut2lybcmgwcmHzM1SuwexVgjizv
	8Uyf9430ZNJcGmLYH8SAlwyrmmwXvPus7ca6r1GaIapMam9MY4hldJ2osAdkW26vlgdY=;
Message-ID: <bb5010df-5e5b-9de1-7ad8-1ba5e8e37edc@xen.org>
Date: Tue, 1 Feb 2022 17:05:04 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.1
Subject: Re: [PATCH 2/4] rangeset: add rangeset_reset helper function
To: Oleksandr Andrushchenko <andr2000@gmail.com>,
 xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, oleksandr_tyshchenko@epam.com,
 volodymyr_babchuk@epam.com, Artem_Mygaiev@epam.com, roger.pau@citrix.com,
 jbeulich@suse.com, andrew.cooper3@citrix.com, george.dunlap@citrix.com,
 paul@xen.org, bertrand.marquis@arm.com, rahul.singh@arm.com,
 Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
References: <20220201162508.417008-1-andr2000@gmail.com>
 <20220201162508.417008-3-andr2000@gmail.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220201162508.417008-3-andr2000@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi,

On 01/02/2022 16:25, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> This helper destroys all the ranges of the rangeset given.
> Please note, that it uses rangeset_remove_range which returns an error
> code on failure. This error code can be ignored as while destroying all
> the ranges no memory allocation is expected, so in this case it must not
> fail.
> 
> To make sure this remains valid use BUG_ON if that changes in the future.
> 
> Suggested-by: Roger Pau Monné <roger.pau@citrix.com>
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> ---
>   xen/common/rangeset.c      | 6 ++++++
>   xen/include/xen/rangeset.h | 3 +++
>   2 files changed, 9 insertions(+)
> 
> diff --git a/xen/common/rangeset.c b/xen/common/rangeset.c
> index ea27d651723b..9ca2b06cff22 100644
> --- a/xen/common/rangeset.c
> +++ b/xen/common/rangeset.c
> @@ -525,6 +525,12 @@ void rangeset_swap(struct rangeset *a, struct rangeset *b)
>       write_unlock(&b->lock);
>   }
>   
> +void rangeset_reset(struct rangeset *r)
> +{
> +    /* This doesn't allocate anything and must not fail. */
> +    BUG_ON(rangeset_remove_range(r, 0, ~0ULL));

I vaguely recall some discussion in the past (not related to this 
series) that we wanted to avoid calling function have side-effect in a 
BUG_ON(). So if we decide to remove at compile-time BUG_ON(), there 
would be no issue.

But then I am not sure about the use of BUG_ON(). Can you outline why 
crashing the hypervisor is better than continuing (e.g. use WARN_ON() or 
ASSERT())?

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Feb 01 17:14:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 01 Feb 2022 17:14:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.263713.456543 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEwjv-0007ym-5y; Tue, 01 Feb 2022 17:14:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 263713.456543; Tue, 01 Feb 2022 17:14:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEwjv-0007yf-2e; Tue, 01 Feb 2022 17:14:47 +0000
Received: by outflank-mailman (input) for mailman id 263713;
 Tue, 01 Feb 2022 17:14:45 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7bwX=SQ=epam.com=prvs=4031c7af39=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nEwjt-0007yW-PS
 for xen-devel@lists.xenproject.org; Tue, 01 Feb 2022 17:14:45 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7253c6f9-8382-11ec-8eb8-a37418f5ba1a;
 Tue, 01 Feb 2022 18:14:43 +0100 (CET)
Received: from pps.filterd (m0174683.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 211GWTIt003474;
 Tue, 1 Feb 2022 17:14:38 GMT
Received: from eur04-he1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2059.outbound.protection.outlook.com [104.47.13.59])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3dy8fp04v7-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Tue, 01 Feb 2022 17:14:37 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM6PR03MB4998.eurprd03.prod.outlook.com (2603:10a6:20b:89::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.22; Tue, 1 Feb
 2022 17:14:30 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6%3]) with mapi id 15.20.4930.022; Tue, 1 Feb 2022
 17:14:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7253c6f9-8382-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=P9XaRvIbcC7VQbGOl0r5Wwad7pigIW8k5L47m0m6eDTxr5j2HgvKifCX1uY+e7D5LMdK7l10pyJO0fEgk3JSkS/JxJWj0QTqTvGr9ryrK/AgkmTu5UX7Tz4xKVJqJexkZxitmITVME8972xpqJGWDlcBNI911hVXLnjcjC43a9630cIhSDML+vIM2YcE68a9o3nOV5JLwacepcdzg0GqL15If1C3cLgOq+zCkGITI8H79B8WmROnTQVFffk3fzwxt4EEviImaYZNuCgXQbQHSObWAtJQiRkk9jXDJBcNdNLZbTMvzrxH2DBgwQA2uPTZmU2rk8a4DROiVpBb5QVzZg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=9Us5HEAmlWkR70pK/al8eyk7Pe98hkqDx0KlSN2CRxg=;
 b=KS9jGNRsmIJ0LXWLR69d6FK8Cl/BPb7vmT8LaJEaN+V5kAmS0rSO3Nf1Z7L3a8bezEBkyToKfrUbwQirR9HNnLzGE1ELd++Jjc30dQAIsboBgv2waw93jvGvB91kMgB8irgsi4PCl9YWt8rnveZpZphYn4qBH/5OAwB8Ge4lu3Hnjt9bjjFAJ42w/wc3M8rewD+QZDPBZk6gkI+M7pYGzmUEd/BoP3vFR3yGPOT5zmBGWOTHh+YnMNHNrBjVN8K9fmmGnaES95vySQGSN/uv8AU7uy6kTpTqPtT/P2Xj91ga7PJUuyIz5QYq0IrZm+/6V7w3YD4OypO8zR1s0JzyXw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=9Us5HEAmlWkR70pK/al8eyk7Pe98hkqDx0KlSN2CRxg=;
 b=FR67sxL2wKFjvAikKslWjOsotzWS3CiiOl4Vb4FMY9wBI7wsqVcFf26fIzvwn80qbgFTsLm3CGS3VLHevn+GY7fg39zdmwBzK78wlHSCB5R0oovuk5XZWZKFnmStyuFfcWZmRhiV5P9W+EPHK7s4QGfzcSXbAG/dp11X2HC1tOLL6trjfPngCT3fiYBS1zLJMe8YIJw9NLN6H4CdClqOaNRMl5NsztsOu+DVKVurNwLZmRG2nKPIND2ySG3VSe+Gr40pMEAfVJMpVNNG1nEZbznoSHoeOAFLJmL8+CJ3QOeYGStjI+TB0UX45CtjrKqrzGdFylajP/Tm11ccf8yRmw==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Julien Grall <julien@xen.org>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: "sstabellini@kernel.org" <sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "roger.pau@citrix.com" <roger.pau@citrix.com>,
        "jbeulich@suse.com"
	<jbeulich@suse.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH 2/4] rangeset: add rangeset_reset helper function
Thread-Topic: [PATCH 2/4] rangeset: add rangeset_reset helper function
Thread-Index: AQHYF4hPV7SJ+mLtNUi4YvDbTFD9Qqx+7KUAgAACoYA=
Date: Tue, 1 Feb 2022 17:14:30 +0000
Message-ID: <ef8b93f8-5333-fc84-ac0a-8197d084f99b@epam.com>
References: <20220201162508.417008-1-andr2000@gmail.com>
 <20220201162508.417008-3-andr2000@gmail.com>
 <bb5010df-5e5b-9de1-7ad8-1ba5e8e37edc@xen.org>
In-Reply-To: <bb5010df-5e5b-9de1-7ad8-1ba5e8e37edc@xen.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 9253464f-4e0a-4e3f-2f98-08d9e5a64f3e
x-ms-traffictypediagnostic: AM6PR03MB4998:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM6PR03MB4998915F3E75AAB0F1356B16E7269@AM6PR03MB4998.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 QVjZs792+JABqdIsJARciGAyz5u5V7U7M1UTwPaR2c93hTtclyuWnda2KZJ0Mc8jY55Dty6Ip/3soFUHoUJu2XRjr/owiBPzjxMcFhojmV1OPUN6Es5dLAFDLQRoD0c+pT2COkX+rmFDgprWB/iiSMT0n2UHQgXT0I/YGUVFpJUal0KqGVrEUy5Ik9rNVl6673dJCVVtUgngpkUCiBgoyG2GmknAgItJSNdUV0GqbZOxygO/5XggJwKmGuufYMPMxh9/ka9qCDHSPqut/r9An4Gw2EBn9zXbERKWnd52MLUJw3jxf/EPWy43xXdgJaz2LxeDVFSlq/4jqxFzNUkPD6HcwiX8SiWvHZ9JNX8uIr4+CiYJ37RVk/TFGjo2ILDDADf7UaTvgXTdZjVxld4AlaUGRlsWC6r82d2Cv3kPAW3PqRJ0x1KIJKyb7+B3WxhBtqN7PQAJutTmNCl8sxQypvWOwIfNUhEsEX2BifaXR+xJoWGBJmfpPYUNOD+K1/I8u92vc7cdBll69qjBUNMmFpYY/sIoZX0gSvdJ5FMUMCgq02MTdwcXcYXZf6gSFhB/WEX/9W8JXQthKP2ItKvFkhRau2yA8/W+4iHsxaHYMZinbxHzxN7lQ2H7vyzto+8onqQ85Uh1r4avRAS3pZsvDjMajrb6u+bPmXVrS47t6wfO5XJo/juH/KZjsPvjKVC/sgVsehcaRAIeX96xixAE0swYHvhgU0SeqIqbWtF+rMSvaL0bud8SXmGS2d1oka99
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(8676002)(7416002)(8936002)(54906003)(4326008)(38070700005)(76116006)(31696002)(122000001)(66946007)(316002)(66476007)(66556008)(66446008)(64756008)(86362001)(110136005)(5660300002)(91956017)(38100700002)(31686004)(36756003)(508600001)(71200400001)(53546011)(2616005)(107886003)(186003)(26005)(6506007)(6512007)(2906002)(6486002)(83380400001)(45980500001)(20210929001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?dmhNaGZZdEQrT3ZIVXQwNFZiTG9TeE00dmtuaHlndXJQYklkVDdwa0svaW5q?=
 =?utf-8?B?QUNNYTZqclhOZ1dpYTZZaUh3MklPR3Z3UjhtTnhhYk1UaXZja210VTBUVng4?=
 =?utf-8?B?SFUwU1NNMTlIQXQ2QmFVSWpDRXlTZ0JwVkV4eTk3enlDOXh4dXkzYjVRdE9N?=
 =?utf-8?B?MVBhNFB3NmVCTUUwQ1hQR1lBUFZ0aEd6M0UrUnVGMmp0cTZVTzZOTzdreGhs?=
 =?utf-8?B?b3ZUWHlFaTMzOUlzV25lUDBCR01ZbUM2MjlMUlJPTlFUNkVaYnBTZFFabnBn?=
 =?utf-8?B?TkxVNlhaR2FZcEtWZC9tTHFWcTE4L2RORjI0NEcwa2dUS0ZFVEd2TDZjSE9J?=
 =?utf-8?B?SnNhUmxqOTdITnc1alVRRHEzaThpQit6OVZ2QmhpdnVCMGYvMjJjOThuNHpV?=
 =?utf-8?B?b0lUTE43LzI2UWJ1Y1FIdDJLMkdHL3gzWWw4ZDlvQTBYTjFtRW1mekJhbTdB?=
 =?utf-8?B?K2J0VEMvbDgrcnpNOW10Rkt6My8wZS96MWptRTdINTFjY2VxVld0dGM1ZzBM?=
 =?utf-8?B?ZWRFTzRnL1Q1UXh5RVJ1YTZ6VmIwSkNNamlTNUVRNjVrNWZzTU9WZHJUZWgv?=
 =?utf-8?B?Q2o3WGNZR0g3aVc5RnZIaWhKbXJKS1lpalJKTTVjUzlidUJLdm9ITzA3MzJx?=
 =?utf-8?B?NEFHcjFTMnZybldBdDFDV1BRejhJQjhKVTBjRGpaV3o3NFVTcGoyVC9TKzc1?=
 =?utf-8?B?SFJlc2liWlRHcDNJbGNIN3NkaGZDdVBRNXQxRUlrdDVUK0U2QWlFUmJQRHll?=
 =?utf-8?B?eWh5WDJacXRCVnI4YTNNQWxzUW5HYkFMRVFRemFFUGRzQmNuUUtkekVZUXg4?=
 =?utf-8?B?Z04xdTFPb0hnQ0c4WTlrU0hyWHZnNGl3cXdLV0hMQmhWWFlmL25oRkp3V25F?=
 =?utf-8?B?UE54T2Vwa3dXUTEybUs2a1FWUm5Tb3EzbXZFL2ZvMENUbkZhU1pyeDlkemkr?=
 =?utf-8?B?cDMzWm1nVXo2NVR3eCtmakphVHNVbDh0TUlkMHo2Z1g4UUV5V1dkazRuRkd2?=
 =?utf-8?B?Q0pPL2VuYzdjZENZWmZxZU9hQk5qWHkyOWRSVTBSS1ZmSHNrVXlweHlTeDBs?=
 =?utf-8?B?TGJBQnU3dTBhTW5TQ3lJRUhxbGFRclMzZXl1bFMrQ2JXNzZ4QkRQL1lSRi91?=
 =?utf-8?B?Wk56UEt1OW9zdENqT2NZNDkycjhpS2FZUERrRzJ3OXZuaEljdnpCOHpIckND?=
 =?utf-8?B?UkI1ZDhXK1BnamROTGpNU1lXR01Rc2p3dHR6TVBpa3hGd09wdlZ5NVVUb1I5?=
 =?utf-8?B?czZsZHBvai9aYjFlVlVNL09rSVhTOUYyRUxHVGlrRUIvWjYyMzZzYlVWOUls?=
 =?utf-8?B?U01GVUNzVE1TY0hWTTQ3bFAzSkVlZGdkZU9sdDNKN0wyWU9yR244SFVtaUZq?=
 =?utf-8?B?VHVLTTNreVBVdFpXblBNNEZmVEhUaWhSSVFoNFFYRlVlN0gwbkhWQUFKb2VV?=
 =?utf-8?B?YThqK1V1TTRTUWJIL0xBZXIxV0pLejhwRnMxSlFKN2xVcjN5U0N2aWpjaDh5?=
 =?utf-8?B?RVJjNWEzOS91NjdaZjFHM2FNYlBNZ0VPSDVrWW9yZlR0UlRDQU1DclpIanRT?=
 =?utf-8?B?TlE5bEZIY1lmME9NczdnU2l3RzVPVWhnQmVtRW5zT0NjMFljQUxZN2dWV0Ux?=
 =?utf-8?B?a3BmMG1sNjlRd2pyRFlhaHdvN2R6WXdpMzVoL1Erajk0ZDNmNzNVVUVuNnhR?=
 =?utf-8?B?UXVVaGtheGxhZ3BrZ1pBRFNReEZjQjZMZ2ZQWkNPNHZQYm8rV0ExcmhJMWhj?=
 =?utf-8?B?YzdtcE5yVTAyMVN6b3U5azYza2Y1UktBN0wxMmxLTU5Vc01CbjBjT3QvSVVK?=
 =?utf-8?B?L0RFd002LzFnSkgxVnNTTlpiU0hXd3pQUk1wL3JxZW0reW9NZmJtOW10Y0U5?=
 =?utf-8?B?YWttem5iN3lidEtNbXNXWGYyZEtXMk1iUnZOMmdGZy9KNGR4VzA0WkMzaHEv?=
 =?utf-8?B?V1pObWdtYVp6VklqV3JndndFdWZPd2l2S3N5U0V4Zks4emdBL3FyTGNoUEwv?=
 =?utf-8?B?Zi84UFEwbXpQVlk2MlRoSnd0VG1hRU5KTE1pTmgvT000UzhEVlF2RTZrRy9U?=
 =?utf-8?B?eW03L085cFRuOUtINENjV2Jobld4ZEw5R0pyZlgxaWE3c214azFCUzNybUlV?=
 =?utf-8?B?WXRwbzlkbWVxVklKamJJK1hENkY0NnVXV1d4UFdEQWhXRXdwVXJxQ3REWGhW?=
 =?utf-8?B?dEdia2g2aUYwRG1yeGlwdjR3SHdpY003Yzc0ZmlzZXN4ZUNSOEhxcllCNXdz?=
 =?utf-8?B?b0J5SGkyMU5uaUVjQnlvRTVod251WSs2VHVrMkJZU2dwbXE0a1o5WGhzaitk?=
 =?utf-8?B?MitsMjgwK2hxNS9zMm9oRWh3OFVhN1dTYVdJL1hpRjBQS1hjcmR1dz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <78EBE81DB12B0F4F8D73BB665D1AB566@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9253464f-4e0a-4e3f-2f98-08d9e5a64f3e
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Feb 2022 17:14:30.5037
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 6sqDtYFIQBfPEoPVxBNZkWT7v/5SSXFO7oiQJArQt9adqL0LZuAu1ou2L8ipKqZMoZqFMx7Ms5JsPVR0Q+2SYnmahXCxTlvqFDtOSVvDl8xHTBlaruCviQlU4r2BD8Ri
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR03MB4998
X-Proofpoint-GUID: quTVCld6k0kDT8lDZZQMterlipo8zY2Y
X-Proofpoint-ORIG-GUID: quTVCld6k0kDT8lDZZQMterlipo8zY2Y
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-01_08,2022-02-01_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0
 lowpriorityscore=0 mlxlogscore=999 spamscore=0 malwarescore=0 bulkscore=0
 impostorscore=0 clxscore=1015 mlxscore=0 suspectscore=0 phishscore=0
 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202010097

SGksIEp1bGllbiENCg0KT24gMDEuMDIuMjIgMTk6MDUsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4g
SGksDQo+DQo+IE9uIDAxLzAyLzIwMjIgMTY6MjUsIE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIHdy
b3RlOg0KPj4gRnJvbTogT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gPG9sZWtzYW5kcl9hbmRydXNo
Y2hlbmtvQGVwYW0uY29tPg0KPj4NCj4+IFRoaXMgaGVscGVyIGRlc3Ryb3lzIGFsbCB0aGUgcmFu
Z2VzIG9mIHRoZSByYW5nZXNldCBnaXZlbi4NCj4+IFBsZWFzZSBub3RlLCB0aGF0IGl0IHVzZXMg
cmFuZ2VzZXRfcmVtb3ZlX3JhbmdlIHdoaWNoIHJldHVybnMgYW4gZXJyb3INCj4+IGNvZGUgb24g
ZmFpbHVyZS4gVGhpcyBlcnJvciBjb2RlIGNhbiBiZSBpZ25vcmVkIGFzIHdoaWxlIGRlc3Ryb3lp
bmcgYWxsDQo+PiB0aGUgcmFuZ2VzIG5vIG1lbW9yeSBhbGxvY2F0aW9uIGlzIGV4cGVjdGVkLCBz
byBpbiB0aGlzIGNhc2UgaXQgbXVzdCBub3QNCj4+IGZhaWwuDQo+Pg0KPj4gVG8gbWFrZSBzdXJl
IHRoaXMgcmVtYWlucyB2YWxpZCB1c2UgQlVHX09OIGlmIHRoYXQgY2hhbmdlcyBpbiB0aGUgZnV0
dXJlLg0KPj4NCj4+IFN1Z2dlc3RlZC1ieTogUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNp
dHJpeC5jb20+DQo+PiBTaWduZWQtb2ZmLWJ5OiBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyA8b2xl
a3NhbmRyX2FuZHJ1c2hjaGVua29AZXBhbS5jb20+DQo+PiAtLS0NCj4+IMKgIHhlbi9jb21tb24v
cmFuZ2VzZXQuY8KgwqDCoMKgwqAgfCA2ICsrKysrKw0KPj4gwqAgeGVuL2luY2x1ZGUveGVuL3Jh
bmdlc2V0LmggfCAzICsrKw0KPj4gwqAgMiBmaWxlcyBjaGFuZ2VkLCA5IGluc2VydGlvbnMoKykN
Cj4+DQo+PiBkaWZmIC0tZ2l0IGEveGVuL2NvbW1vbi9yYW5nZXNldC5jIGIveGVuL2NvbW1vbi9y
YW5nZXNldC5jDQo+PiBpbmRleCBlYTI3ZDY1MTcyM2IuLjljYTJiMDZjZmYyMiAxMDA2NDQNCj4+
IC0tLSBhL3hlbi9jb21tb24vcmFuZ2VzZXQuYw0KPj4gKysrIGIveGVuL2NvbW1vbi9yYW5nZXNl
dC5jDQo+PiBAQCAtNTI1LDYgKzUyNSwxMiBAQCB2b2lkIHJhbmdlc2V0X3N3YXAoc3RydWN0IHJh
bmdlc2V0ICphLCBzdHJ1Y3QgcmFuZ2VzZXQgKmIpDQo+PiDCoMKgwqDCoMKgIHdyaXRlX3VubG9j
aygmYi0+bG9jayk7DQo+PiDCoCB9DQo+PiDCoCArdm9pZCByYW5nZXNldF9yZXNldChzdHJ1Y3Qg
cmFuZ2VzZXQgKnIpDQo+PiArew0KPj4gK8KgwqDCoCAvKiBUaGlzIGRvZXNuJ3QgYWxsb2NhdGUg
YW55dGhpbmcgYW5kIG11c3Qgbm90IGZhaWwuICovDQo+PiArwqDCoMKgIEJVR19PTihyYW5nZXNl
dF9yZW1vdmVfcmFuZ2UociwgMCwgfjBVTEwpKTsNCj4NCj4gSSB2YWd1ZWx5IHJlY2FsbCBzb21l
IGRpc2N1c3Npb24gaW4gdGhlIHBhc3QgKG5vdCByZWxhdGVkIHRvIHRoaXMgc2VyaWVzKSB0aGF0
IHdlIHdhbnRlZCB0byBhdm9pZCBjYWxsaW5nIGZ1bmN0aW9uIGhhdmUgc2lkZS1lZmZlY3QgaW4g
YSBCVUdfT04oKS4gU28gaWYgd2UgZGVjaWRlIHRvIHJlbW92ZSBhdCBjb21waWxlLXRpbWUgQlVH
X09OKCksIHRoZXJlIHdvdWxkIGJlIG5vIGlzc3VlLg0KPg0KPiBCdXQgdGhlbiBJIGFtIG5vdCBz
dXJlIGFib3V0IHRoZSB1c2Ugb2YgQlVHX09OKCkuIENhbiB5b3Ugb3V0bGluZSB3aHkgY3Jhc2hp
bmcgdGhlIGh5cGVydmlzb3IgaXMgYmV0dGVyIHRoYW4gY29udGludWluZyAoZS5nLiB1c2UgV0FS
Tl9PTigpIG9yIEFTU0VSVCgpKT8NCk5vbi16ZXJvIHZhbHVlIHdpbGwgaW5kaWNhdGUgd2Ugd2Vy
ZSBub3QgYWJsZSB0byBjb21wbGV0ZSB0aGUgb3BlcmF0aW9uDQp3aGljaCBtdXN0IG5vdCBmYWls
IGJlY2F1c2Ugb2YgdGhlIGNvbmNyZXRlIHVzZS1jYXNlOiB3ZSByZW1vdmUgYWxsIHRoZQ0KcmFu
Z2VzIGFuZCBpdCBpcyBub3QgZXhwZWN0ZWQgdGhhdCB0aGlzIG1heSBmYWlsLg0KSnVzdCB0byBt
YWtlIHN1cmUgdGhpcyBiZWhhdmlvciBkb2VzIG5vdCBjaGFuZ2UgSSB1c2UgQlVHX09OIGhlcmUg
d2hpY2gNCmlmIHRyaWdnZXJlZCBjbGVhcmx5IGluZGljYXRlcyB0aGF0IHRoZSBiZWhhdmlvciBo
YXMgY2hhbmdlZCBhbmQgdGhlcmUgaXMNCmEgbmVlZCBpbiBjb2RlIGNoYW5nZS4NCg0KSSBjYW4g
dHVybiB0aGlzIGludG8gV0FSTl9PTiBpbnN0ZWFkLCBidXQgdGhpcyBtYXkgbGVhZCB0byBtZW1v
cnkgbGVha3MNCm9yIHNvbWUgb3RoZXIgZXJyb3JzIG5vdCBoYW5kbGVkLg0KDQo+DQo+IENoZWVy
cywNCj4NClRoYW5rIHlvdSwNCk9sZWtzYW5kcg==


From xen-devel-bounces@lists.xenproject.org Tue Feb 01 17:34:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 01 Feb 2022 17:34:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.263722.456555 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEx2O-0001wd-VP; Tue, 01 Feb 2022 17:33:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 263722.456555; Tue, 01 Feb 2022 17:33:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEx2O-0001wW-Rw; Tue, 01 Feb 2022 17:33:52 +0000
Received: by outflank-mailman (input) for mailman id 263722;
 Tue, 01 Feb 2022 17:33:52 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nEx2N-0001wQ-VV
 for xen-devel@lists.xenproject.org; Tue, 01 Feb 2022 17:33:52 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nEx2N-0000ZF-Ff; Tue, 01 Feb 2022 17:33:51 +0000
Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=[10.95.141.48])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nEx2N-0007Wu-92; Tue, 01 Feb 2022 17:33:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=Q7S8JzWJShXM23x2rGGHyeGO0g/U6NGpgKHVU53CP00=; b=ivnvz5X5rVQkqAeLDEJQYIg+In
	C4NF3rKFG0OeoLeBgrmDNfN7obLaMlzwJdR2M/6wCfTAxUVerJEcZSRbUHMh6/iiGbSslG/NhpwOa
	MIp0chIbURNFgG6lAGB2MwdZ/WVDj5fjaLZVCM4G6Z37V5ax0ml4GD+nWCvTbtYb5wR0=;
Message-ID: <63d5b282-3826-0c4e-d64f-2495c5a42b22@xen.org>
Date: Tue, 1 Feb 2022 17:33:48 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.1
Subject: Re: [PATCH 2/4] rangeset: add rangeset_reset helper function
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Artem Mygaiev <Artem_Mygaiev@epam.com>,
 "roger.pau@citrix.com" <roger.pau@citrix.com>,
 "jbeulich@suse.com" <jbeulich@suse.com>,
 "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
 "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
 "paul@xen.org" <paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>
References: <20220201162508.417008-1-andr2000@gmail.com>
 <20220201162508.417008-3-andr2000@gmail.com>
 <bb5010df-5e5b-9de1-7ad8-1ba5e8e37edc@xen.org>
 <ef8b93f8-5333-fc84-ac0a-8197d084f99b@epam.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <ef8b93f8-5333-fc84-ac0a-8197d084f99b@epam.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit



On 01/02/2022 17:14, Oleksandr Andrushchenko wrote:
> On 01.02.22 19:05, Julien Grall wrote:
>> On 01/02/2022 16:25, Oleksandr Andrushchenko wrote:
>>> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>>>
>>> This helper destroys all the ranges of the rangeset given.
>>> Please note, that it uses rangeset_remove_range which returns an error
>>> code on failure. This error code can be ignored as while destroying all
>>> the ranges no memory allocation is expected, so in this case it must not
>>> fail.
>>>
>>> To make sure this remains valid use BUG_ON if that changes in the future.
>>>
>>> Suggested-by: Roger Pau Monné <roger.pau@citrix.com>
>>> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>>> ---
>>>    xen/common/rangeset.c      | 6 ++++++
>>>    xen/include/xen/rangeset.h | 3 +++
>>>    2 files changed, 9 insertions(+)
>>>
>>> diff --git a/xen/common/rangeset.c b/xen/common/rangeset.c
>>> index ea27d651723b..9ca2b06cff22 100644
>>> --- a/xen/common/rangeset.c
>>> +++ b/xen/common/rangeset.c
>>> @@ -525,6 +525,12 @@ void rangeset_swap(struct rangeset *a, struct rangeset *b)
>>>        write_unlock(&b->lock);
>>>    }
>>>    +void rangeset_reset(struct rangeset *r)
>>> +{
>>> +    /* This doesn't allocate anything and must not fail. */
>>> +    BUG_ON(rangeset_remove_range(r, 0, ~0ULL));
>>
>> I vaguely recall some discussion in the past (not related to this series) that we wanted to avoid calling function have side-effect in a BUG_ON(). So if we decide to remove at compile-time BUG_ON(), there would be no issue.
>>
>> But then I am not sure about the use of BUG_ON(). Can you outline why crashing the hypervisor is better than continuing (e.g. use WARN_ON() or ASSERT())?
> Non-zero value will indicate we were not able to complete the operation
> which must not fail because of the concrete use-case: we remove all the
> ranges and it is not expected that this may fail.
> Just to make sure this behavior does not change I use BUG_ON here which
> if triggered clearly indicates that the behavior has changed and there is
> a need in code change.

Right, but that change of behavior may not be noticed during 
development. So I think we want to avoid BUG_ON() when this is possible.

> 
> I can turn this into WARN_ON instead, but this may lead to memory leaks
> or some other errors not handled.

IMHO, this is a bit better but not by much. Looking a 
rangeset_destroy(), you should be able to do it without any of the 
issues you described here. Something like:

     if ( r == NULL )
       return;

     while ( (x = first_range(r)) != NULL )
         destroy_range(r, x);

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Feb 01 17:39:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 01 Feb 2022 17:39:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.263729.456566 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEx7x-0002bc-KD; Tue, 01 Feb 2022 17:39:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 263729.456566; Tue, 01 Feb 2022 17:39:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEx7x-0002bV-Gp; Tue, 01 Feb 2022 17:39:37 +0000
Received: by outflank-mailman (input) for mailman id 263729;
 Tue, 01 Feb 2022 17:39:36 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7bwX=SQ=epam.com=prvs=4031c7af39=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nEx7v-0002bP-Uz
 for xen-devel@lists.xenproject.org; Tue, 01 Feb 2022 17:39:36 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ea58cce0-8385-11ec-8f75-fffcc8bd4f1a;
 Tue, 01 Feb 2022 18:39:33 +0100 (CET)
Received: from pps.filterd (m0174678.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 211HXLFu018704;
 Tue, 1 Feb 2022 17:39:30 GMT
Received: from eur01-he1-obe.outbound.protection.outlook.com
 (mail-he1eur01lp2051.outbound.protection.outlook.com [104.47.0.51])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3dy9bx80pp-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Tue, 01 Feb 2022 17:39:30 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM6PR03MB4840.eurprd03.prod.outlook.com (2603:10a6:20b:83::26)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.11; Tue, 1 Feb
 2022 17:39:22 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6%3]) with mapi id 15.20.4930.022; Tue, 1 Feb 2022
 17:39:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ea58cce0-8385-11ec-8f75-fffcc8bd4f1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=E6cTTfjN3Q5ZYgIyOBoDsapDFSkuLv//Y2X0z9rerNW0NpHSOjybdZOqSmdkj9dpmkWKIItUIs36sMY52f91TQ4O+QLmyW4e9CcGcD3RIYf29Ma2abpQXctkxGF9ErsEjnTc5P4W+wGnMouTUYTUqd5+x4KiUMXVWOFFDMHbr36DVvPmFZRts20ZZWo8awMCcfpqzODf9pk1Nr1ujp1BVhcJ2CuCKWhp+J545jmm3jijj8s+j8J8+MOEdqp76uNYJu+kYp65HqRXua/i7mW7K0soMMG7ezn+3ZQJYGc7RCaKxQCxIRq2btsJezOYY66RTj/Y7famFHdf1eNGNAbR9A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=81LxUlPDo2sWHZT7xAoYqcn8XarcMNspnnIrsRV9hPY=;
 b=FY9vkgMqDP6FOqALfJLXOwUbdngZYFENBh1U5TCkZNIPhspUvZ/ZCd0Iu1v15bXeaYQZkeWDE3+uxmMBxFUvW/zXmKU7YlQhMy6hbLGFI7dbDK28nJ2CTzbwD028zyF4p/PH/9gpcxeqjIVE+x+p088OvtENMx80kos1XfhLjDl5TcKeqOqPRUXlQQO19nY7fsrdrM2pGGu9H4Gv9s6q5Cyf99QZx9cl/Pk1AcFvybLbXYaZKxr4E7clQdzC+oyLMrr0XvDOiD665mpqIOZQUYJPwuaPufMzFkaM7Wn5oZXXt+Tf1PathCWMHnZwMG6z09Epv3b/pjf67on1z5IEBg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=81LxUlPDo2sWHZT7xAoYqcn8XarcMNspnnIrsRV9hPY=;
 b=SQgMrtJaqasDAHB9WzUR6RkJAuwnq5mQa7gvXgkCAoMIjUmoyASha/h6xCcF0+JB0STwswxQCLSJu6L9XjJ42EKnfyAEdRaXxn7zw28HMZe7PJjOmj3ims7uuO84Fv2INpbjw244SXz0vbLa1VkwPm4Sd3Z7aelAym9YIHKbdZ2NYW4FLoI6vfuptPTKNl6HcorrCW0mQzLupm8rRct3a/XaOMPB4FcC+FN8QFARqYjIHWIKjEO3iWjcReTdpb6kanQN3jYFW92sY85l29mVKNmTFgF9nKUtz1wxvGuhOVl2+6FP6Ao4zxrkvs76ngUbaUT/fpOAXfYt4C6Iz2BuwQ==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Julien Grall <julien@xen.org>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: "sstabellini@kernel.org" <sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "roger.pau@citrix.com" <roger.pau@citrix.com>,
        "jbeulich@suse.com"
	<jbeulich@suse.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH 2/4] rangeset: add rangeset_reset helper function
Thread-Topic: [PATCH 2/4] rangeset: add rangeset_reset helper function
Thread-Index: AQHYF4hPV7SJ+mLtNUi4YvDbTFD9Qqx+7KUAgAACoYCAAAVmAIAAAY2A
Date: Tue, 1 Feb 2022 17:39:22 +0000
Message-ID: <8207249a-4f51-4ca0-cb53-693df013fb15@epam.com>
References: <20220201162508.417008-1-andr2000@gmail.com>
 <20220201162508.417008-3-andr2000@gmail.com>
 <bb5010df-5e5b-9de1-7ad8-1ba5e8e37edc@xen.org>
 <ef8b93f8-5333-fc84-ac0a-8197d084f99b@epam.com>
 <63d5b282-3826-0c4e-d64f-2495c5a42b22@xen.org>
In-Reply-To: <63d5b282-3826-0c4e-d64f-2495c5a42b22@xen.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 426a5cb9-00e7-4690-0f63-08d9e5a9c87e
x-ms-traffictypediagnostic: AM6PR03MB4840:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM6PR03MB48400A6A5295A7A60EEA6D9AE7269@AM6PR03MB4840.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 dOKa2p35M0wCSE6xOUTOQyScJDsLyIID+cdWyTqPt9t7O7foeoyYTOVeHd7IJ89xvtcWmGL/MuiVzl4USR3TEaKc+Ydo6awWcP1zwZbNBBGVljbKrtaNTLnv9/2YbeMqqq3Uglu+XgV7PkcML1lhZ5Ltu5JXZ2V+R1A290mc71HD8tTmoObfdppIeqioak6FJboolWD09/8cdqEQTs/+mrb3UgQtJiQRGuOVZtgbb7ro0IQ0vYcV8QM54xPbm1xAqhg71teVTs1YSzGL5I0XKX8jPI6HOAU695xfwKh3NBT6ud9da3S9D4XTFuFGM2x/ZNaqEd1eqEfONwNoavacoPmTCVxpceWanu2pK5ZE6vU5FSREVQ3pHrmPvh2ICQvU8OhNCDusThC484xwgt0AQiU7xzyYex6Lf+pJRlr3yDfytw6jaGHKW8X2mrmOmqm/dlo1YNHav3cGhtAIAU0cJLKpw5YJKuZrVCPVUFkWcPIWpZzjS0uX+3yXAAnDnkOxyBGZfTrwDXTto2fvE5a5cMVa+EcsEznuDtbsnmma3rSgUtGZfCqOlIo4HI5bwIK+F8kImtlhtifLEbkV8SbSdiX0Sc2YvX/bxVA7pNUstAio0Mh0I321mRMEdleky0Ac5T4/4wY8OnanuWvHe9ay7koSvwON3M7+Ie3H+tZfRXtXw7awRrpeS312/QRUxA//rl3+GeZYoQ41DuzA4vzTZP7vESk+u9bRSUTnKBYzwLtfSxQnv5kkLNf/JQlf1Ca5
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(53546011)(71200400001)(36756003)(2616005)(107886003)(83380400001)(31686004)(508600001)(6486002)(186003)(26005)(6506007)(6512007)(2906002)(54906003)(4326008)(38070700005)(8676002)(7416002)(8936002)(64756008)(110136005)(5660300002)(91956017)(38100700002)(31696002)(122000001)(76116006)(86362001)(66946007)(66556008)(316002)(66476007)(66446008)(45980500001)(20210929001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?SXpxM1ZrREhxOFplbHFWZDUyWlA4NGpITzVlcjdmNlhQaTVjRkFaQXlIWDQ4?=
 =?utf-8?B?Zm11RFZtdG5YK01hUmNVZ042T1Z4SkJoRlR1eVBFVEkwUUlDQVZHUmNVdCtp?=
 =?utf-8?B?L1hjWkNLK0JFSEtmY285ZmhCeWg2TUF5dlpWYzhLOHJzckJPbmZSNmY3NURV?=
 =?utf-8?B?MzE2WVlwL3ZGdXJPMmFXU1lEbWMzaFVhbWFrblNTOEd0M1Bib2tuS041blZK?=
 =?utf-8?B?WGRyM0w2Z0gzL0ZKZVp6cjFGeXFHelNGcE9YbmtaM25zOWFJcmREOUo0Zzhp?=
 =?utf-8?B?dFUzT3dLNXRmdW16OEtpWGJOaHJ5UGd1d2YwWFcyUktPclk3UlZJZFAvWlRN?=
 =?utf-8?B?MkpuUzJFa0lWMWd3M3FvQ2pvYlNWZHlFdHhqdWhDZXZqNGxHVUpUbkkyU3R1?=
 =?utf-8?B?cFBqNHZicW03SEt3UWNBS01VSmpoREtGeFdqYVV0UldRZ0FhZ3diem00Kys2?=
 =?utf-8?B?U3AwbWZBSXV1dXRNNzRkSWE5RnBtMCtzN2FjSENTWGQ1TU14ckJPRXhwT0Vp?=
 =?utf-8?B?MkJvb1dReHRxRjNzODNETGVpWWx2K3pKdUtuKy9CMWNqN3ZhVGZjcHN2d0lD?=
 =?utf-8?B?NWViUWwwQ2RaRzJ0S1BXYzY0RUJFVDZ6RzVLejE2OEJrZ0xRbkw2azRzOXBM?=
 =?utf-8?B?eVZqRmhES1BIclRjeHZmMkpRM3FOVUhTNkJsMU9vZFlFbXlBL2M0R2lsZDlC?=
 =?utf-8?B?eXE0Wk8xN256ZDBEalFDSFM3cmNEcTJNTERTMjdlcTNwRStpU3VCL2ZQMzB5?=
 =?utf-8?B?NXJ2SHZYQk1NU3YvTUtjWXVzUHZJSkRUWGlZc3d6MGxyNmRtRGZtRWtLSXhH?=
 =?utf-8?B?ek8xcElsRVZZWHFDYWpDVzRRa3VWTVpjSzhid0huY01uWHdIcm8ydXNlUVFU?=
 =?utf-8?B?MlczY2ZlcWJtSWx0SWlxMmliOWRPZUdIMVFtVlF0b3RHZUpMbzhLM2Y1c0tR?=
 =?utf-8?B?L0VWc25SQ1JUT3BxcHdIMGZ1dzZzdzJYQXZtSC82TFlTdUd3dTJMNDZEUkdz?=
 =?utf-8?B?b01ZMVZXYnhmYVV4Q3ZUOVJuTTgrZlhDR0hQT3dINjBoZy9NZm04MGpad1Jv?=
 =?utf-8?B?ZFNuVFlKWmxZQmYyd1E4aitKWllib3U2czUrd2RGTmFzY1VqOStaeGNVY29x?=
 =?utf-8?B?NndZRC9Ma3pKUCtiNkdZZGZvTk1MeUY1b2tSRHFhN1VlMFF5MWlFaW9mdHJh?=
 =?utf-8?B?dkVjcS8yRW11WG0xU1c3RDB6MGJEWjRYejRzSkp6TWdmaXlOcVhmYTFvT1k4?=
 =?utf-8?B?ekNhYW9POWxJeHpjOUlYTjg3WDNVdmtvWE1GMGtJalEzSFJ4QTRTd2dOZW5t?=
 =?utf-8?B?Q3FCSGtEbjNzdkRqMUxPaHpCWXdVQUFuSnV3Tk5vSW84R1hKSEJVWTdhQ0Ey?=
 =?utf-8?B?UTd3ZW1SZmliTmI1M2VPSnBZd3ZxYjErMTYyN09zR2M5Sll2U2RUR0FEVjZX?=
 =?utf-8?B?Vm9TSDZ2UE14MFZXOURGeVEzeWlUNlZOQWhiR3M1R3hqTlA3RDNRYlh5aWU0?=
 =?utf-8?B?b3JSTi9UL0twczBJYmhVSFpSc2t5T3lPa2lLL0hHWVpPR1RzTzMxUnRkeVgy?=
 =?utf-8?B?b0hxTmdDdEIzVS9MKytVQXRGcWRkSVpmNU5nc0p3bjRuTDBxOUo5NWFJSHNO?=
 =?utf-8?B?RFhjemFnd1NpcXdiQnpMS2ZqeEZ5MEMxc2lKNlZCQ0lzNWcxSWZwblhNUmta?=
 =?utf-8?B?NG1YY3VNS3hLSmJZQSszSndhdXlHK3N2R1Z3UVExM2ZZenpxcEU4ekEyV3FB?=
 =?utf-8?B?UEVQdGtxdnREVVlBOVBoaWlGNzRDYnBSTGpBSE5QdGdIbVRnQUxURlJBOWNK?=
 =?utf-8?B?NjduQjQ4TXQ3Nncreko0Znk4R3dQaXc0STB2dWJxbnU0Z0ZSMU9lQkRXaHBR?=
 =?utf-8?B?OHRzclNhL01qYXdJWVZKYnBMOW91Nzdia0I1V2FRM3FEQ3MwdTgxWlhCRmwy?=
 =?utf-8?B?MHdSOW5YQzFWK29RdTAwUUtCNGRJSUZiTVFJMENPVldpRnZoZitHRWkzaUVW?=
 =?utf-8?B?MGhYT3hyQXlxSTZxTS9ER0c3Z2I5eTFoT2wvU1BTdVJDNzgzeDdMYmJ5b2Z2?=
 =?utf-8?B?ZndsdDNhSFRLQ05vOU1HTnp5ZEZVTVpYYUFpN3FXS1pMODRxYzUzdU84eGZw?=
 =?utf-8?B?SUtEd3ZQejl6aVdWT0JJMWREajZhZDBkUVlyQjFmS1BYd0tNY1B5Tklaa3hK?=
 =?utf-8?B?V3pHL3VkQmM5MVVnOHJsKzZ0R201bW1IcFZRbUI1UzVjSGZobDgrM1I4aGhx?=
 =?utf-8?B?U25pb1FVamZpaEFVeW96UllNRkJXMmtGQ3VrZWRyeW03bThadTdUNmpkL2hZ?=
 =?utf-8?B?UENNZUdhYWJaem5WZEJrNnNBT3lLZUVCYy95UEVFS1VtdXNVbTdzQT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <A4287DCB3AD76B42B74716E6407AF542@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 426a5cb9-00e7-4690-0f63-08d9e5a9c87e
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Feb 2022 17:39:22.4480
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: /Rvl+I0DUnXYPIaOzSx+1v4sRWmhRPp3HPmdvG4cbXit6b8xbjKzl/7VWC2SqkAqjbRZ/dgsIK4POk6RzKQCJwbgNUgJfMytvM7AT+hZwVQm47eFBAf91BHebfak4HhL
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR03MB4840
X-Proofpoint-GUID: Q7t_fKVT7Vv5J6QJhJOcU2AxP0a_iScK
X-Proofpoint-ORIG-GUID: Q7t_fKVT7Vv5J6QJhJOcU2AxP0a_iScK
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-01_09,2022-02-01_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 spamscore=0
 adultscore=0 mlxlogscore=999 phishscore=0 clxscore=1015 impostorscore=0
 lowpriorityscore=0 priorityscore=1501 bulkscore=0 suspectscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202010098

DQpPbiAwMS4wMi4yMiAxOTozMywgSnVsaWVuIEdyYWxsIHdyb3RlOg0KPg0KPg0KPiBPbiAwMS8w
Mi8yMDIyIDE3OjE0LCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyB3cm90ZToNCj4+IE9uIDAxLjAy
LjIyIDE5OjA1LCBKdWxpZW4gR3JhbGwgd3JvdGU6DQo+Pj4gT24gMDEvMDIvMjAyMiAxNjoyNSwg
T2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+Pj4+IEZyb206IE9sZWtzYW5kciBBbmRy
dXNoY2hlbmtvIDxvbGVrc2FuZHJfYW5kcnVzaGNoZW5rb0BlcGFtLmNvbT4NCj4+Pj4NCj4+Pj4g
VGhpcyBoZWxwZXIgZGVzdHJveXMgYWxsIHRoZSByYW5nZXMgb2YgdGhlIHJhbmdlc2V0IGdpdmVu
Lg0KPj4+PiBQbGVhc2Ugbm90ZSwgdGhhdCBpdCB1c2VzIHJhbmdlc2V0X3JlbW92ZV9yYW5nZSB3
aGljaCByZXR1cm5zIGFuIGVycm9yDQo+Pj4+IGNvZGUgb24gZmFpbHVyZS4gVGhpcyBlcnJvciBj
b2RlIGNhbiBiZSBpZ25vcmVkIGFzIHdoaWxlIGRlc3Ryb3lpbmcgYWxsDQo+Pj4+IHRoZSByYW5n
ZXMgbm8gbWVtb3J5IGFsbG9jYXRpb24gaXMgZXhwZWN0ZWQsIHNvIGluIHRoaXMgY2FzZSBpdCBt
dXN0IG5vdA0KPj4+PiBmYWlsLg0KPj4+Pg0KPj4+PiBUbyBtYWtlIHN1cmUgdGhpcyByZW1haW5z
IHZhbGlkIHVzZSBCVUdfT04gaWYgdGhhdCBjaGFuZ2VzIGluIHRoZSBmdXR1cmUuDQo+Pj4+DQo+
Pj4+IFN1Z2dlc3RlZC1ieTogUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+
DQo+Pj4+IFNpZ25lZC1vZmYtYnk6IE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIDxvbGVrc2FuZHJf
YW5kcnVzaGNoZW5rb0BlcGFtLmNvbT4NCj4+Pj4gLS0tDQo+Pj4+IMKgwqAgeGVuL2NvbW1vbi9y
YW5nZXNldC5jwqDCoMKgwqDCoCB8IDYgKysrKysrDQo+Pj4+IMKgwqAgeGVuL2luY2x1ZGUveGVu
L3Jhbmdlc2V0LmggfCAzICsrKw0KPj4+PiDCoMKgIDIgZmlsZXMgY2hhbmdlZCwgOSBpbnNlcnRp
b25zKCspDQo+Pj4+DQo+Pj4+IGRpZmYgLS1naXQgYS94ZW4vY29tbW9uL3Jhbmdlc2V0LmMgYi94
ZW4vY29tbW9uL3Jhbmdlc2V0LmMNCj4+Pj4gaW5kZXggZWEyN2Q2NTE3MjNiLi45Y2EyYjA2Y2Zm
MjIgMTAwNjQ0DQo+Pj4+IC0tLSBhL3hlbi9jb21tb24vcmFuZ2VzZXQuYw0KPj4+PiArKysgYi94
ZW4vY29tbW9uL3Jhbmdlc2V0LmMNCj4+Pj4gQEAgLTUyNSw2ICs1MjUsMTIgQEAgdm9pZCByYW5n
ZXNldF9zd2FwKHN0cnVjdCByYW5nZXNldCAqYSwgc3RydWN0IHJhbmdlc2V0ICpiKQ0KPj4+PiDC
oMKgwqDCoMKgwqAgd3JpdGVfdW5sb2NrKCZiLT5sb2NrKTsNCj4+Pj4gwqDCoCB9DQo+Pj4+IMKg
wqAgK3ZvaWQgcmFuZ2VzZXRfcmVzZXQoc3RydWN0IHJhbmdlc2V0ICpyKQ0KPj4+PiArew0KPj4+
PiArwqDCoMKgIC8qIFRoaXMgZG9lc24ndCBhbGxvY2F0ZSBhbnl0aGluZyBhbmQgbXVzdCBub3Qg
ZmFpbC4gKi8NCj4+Pj4gK8KgwqDCoCBCVUdfT04ocmFuZ2VzZXRfcmVtb3ZlX3JhbmdlKHIsIDAs
IH4wVUxMKSk7DQo+Pj4NCj4+PiBJIHZhZ3VlbHkgcmVjYWxsIHNvbWUgZGlzY3Vzc2lvbiBpbiB0
aGUgcGFzdCAobm90IHJlbGF0ZWQgdG8gdGhpcyBzZXJpZXMpIHRoYXQgd2Ugd2FudGVkIHRvIGF2
b2lkIGNhbGxpbmcgZnVuY3Rpb24gaGF2ZSBzaWRlLWVmZmVjdCBpbiBhIEJVR19PTigpLiBTbyBp
ZiB3ZSBkZWNpZGUgdG8gcmVtb3ZlIGF0IGNvbXBpbGUtdGltZSBCVUdfT04oKSwgdGhlcmUgd291
bGQgYmUgbm8gaXNzdWUuDQo+Pj4NCj4+PiBCdXQgdGhlbiBJIGFtIG5vdCBzdXJlIGFib3V0IHRo
ZSB1c2Ugb2YgQlVHX09OKCkuIENhbiB5b3Ugb3V0bGluZSB3aHkgY3Jhc2hpbmcgdGhlIGh5cGVy
dmlzb3IgaXMgYmV0dGVyIHRoYW4gY29udGludWluZyAoZS5nLiB1c2UgV0FSTl9PTigpIG9yIEFT
U0VSVCgpKT8NCj4+IE5vbi16ZXJvIHZhbHVlIHdpbGwgaW5kaWNhdGUgd2Ugd2VyZSBub3QgYWJs
ZSB0byBjb21wbGV0ZSB0aGUgb3BlcmF0aW9uDQo+PiB3aGljaCBtdXN0IG5vdCBmYWlsIGJlY2F1
c2Ugb2YgdGhlIGNvbmNyZXRlIHVzZS1jYXNlOiB3ZSByZW1vdmUgYWxsIHRoZQ0KPj4gcmFuZ2Vz
IGFuZCBpdCBpcyBub3QgZXhwZWN0ZWQgdGhhdCB0aGlzIG1heSBmYWlsLg0KPj4gSnVzdCB0byBt
YWtlIHN1cmUgdGhpcyBiZWhhdmlvciBkb2VzIG5vdCBjaGFuZ2UgSSB1c2UgQlVHX09OIGhlcmUg
d2hpY2gNCj4+IGlmIHRyaWdnZXJlZCBjbGVhcmx5IGluZGljYXRlcyB0aGF0IHRoZSBiZWhhdmlv
ciBoYXMgY2hhbmdlZCBhbmQgdGhlcmUgaXMNCj4+IGEgbmVlZCBpbiBjb2RlIGNoYW5nZS4NCj4N
Cj4gUmlnaHQsIGJ1dCB0aGF0IGNoYW5nZSBvZiBiZWhhdmlvciBtYXkgbm90IGJlIG5vdGljZWQg
ZHVyaW5nIGRldmVsb3BtZW50LiBTbyBJIHRoaW5rIHdlIHdhbnQgdG8gYXZvaWQgQlVHX09OKCkg
d2hlbiB0aGlzIGlzIHBvc3NpYmxlLg0KPg0KPj4NCj4+IEkgY2FuIHR1cm4gdGhpcyBpbnRvIFdB
Uk5fT04gaW5zdGVhZCwgYnV0IHRoaXMgbWF5IGxlYWQgdG8gbWVtb3J5IGxlYWtzDQo+PiBvciBz
b21lIG90aGVyIGVycm9ycyBub3QgaGFuZGxlZC4NCj4NCj4gSU1ITywgdGhpcyBpcyBhIGJpdCBi
ZXR0ZXIgYnV0IG5vdCBieSBtdWNoLiBMb29raW5nIGEgcmFuZ2VzZXRfZGVzdHJveSgpLCB5b3Ug
c2hvdWxkIGJlIGFibGUgdG8gZG8gaXQgd2l0aG91dCBhbnkgb2YgdGhlIGlzc3VlcyB5b3UgZGVz
Y3JpYmVkIGhlcmUuIFNvbWV0aGluZyBsaWtlOg0KPg0KPiDCoMKgwqAgaWYgKCByID09IE5VTEwg
KQ0KPiDCoMKgwqDCoMKgIHJldHVybjsNCj4NCj4gwqDCoMKgIHdoaWxlICggKHggPSBmaXJzdF9y
YW5nZShyKSkgIT0gTlVMTCApDQo+IMKgwqDCoMKgwqDCoMKgIGRlc3Ryb3lfcmFuZ2UociwgeCk7
DQo+DQpZZXMsIHRoaXMgaXMgYWN0dWFsbHkgd2hhdCBSb2dlciBzdWdnZXN0ZWQgdG8gbWUgcHJp
dmF0ZWx5IG9uIElSQy4NCk9rLCBzbyBJJ2xsIHJlLXdvcmsgdGhlIHBhdGNoIGFzIGFib3ZlDQoN
ClRoYW5rIHlvdSwNCk9sZWtzYW5kcg==


From xen-devel-bounces@lists.xenproject.org Tue Feb 01 17:40:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 01 Feb 2022 17:40:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.263734.456577 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEx96-0003uo-V9; Tue, 01 Feb 2022 17:40:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 263734.456577; Tue, 01 Feb 2022 17:40:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEx96-0003uh-Qg; Tue, 01 Feb 2022 17:40:48 +0000
Received: by outflank-mailman (input) for mailman id 263734;
 Tue, 01 Feb 2022 17:40:47 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=4rj0=SQ=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nEx95-0003uS-1K
 for xen-devel@lists.xenproject.org; Tue, 01 Feb 2022 17:40:47 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 14f9bc61-8386-11ec-8eb8-a37418f5ba1a;
 Tue, 01 Feb 2022 18:40:45 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 14f9bc61-8386-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1643737245;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=rSakzW8F1T/IHOqc59Wxu5gOKZD94g7wpSbjHNYv9ZU=;
  b=BUt+p2v4Fs+LskU/aoj8XhY5yiHRYLpFfqzJGdPgvxV14TRxA569owjy
   bwF2+0Z+p/zlhBpt7xxWtlo2OYfCaSMGXWFAAJZpX9v2JQF0A79mYSd7e
   Msy0iO/wTeGE+9yEdqsJRcJVQzm/qlPmtfwLJL9xzT42DoGv3H/Zja9lV
   w=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: AafiltsoL0TguCcVzZa34CYbGrxYH+KZ96q+N5bfX8CxPg2UNPaUA9TYLhRwZQQQSsnvbOpP/w
 FMO7d9Jos18CmX+7tclA1jvno+5kFDBPM0tmHvGq4VIjSFzpMo27HsrVf9OUZMorMyNavHTV5h
 3u4Y5iu09/9up8b7DmSh9HICjmcKEMdMCtsiF/kg4RLXa1nL2AtwWgUPdEyBLr+D8OJB71tSZM
 zPXZ2C5YnafZ1/gkOeQv0+NJBEJtYgEDS6bsXLPBMTdbPpTZhhrEyTTe8zqYKUa3lUPGl9QG/H
 ZGYj0J/oBfFeS+W18BlaNgaF
X-SBRS: 5.2
X-MesageID: 63649787
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:3ovbk6yuXsLzEpYUqfR6t+fmwSrEfRIJ4+MujC+fZmUNrF6WrkUPy
 mZNCjzSbK3ZNGH3ftlybY2z908FscDQn4BhGQc9ryAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAhLeNYYH1500g7wbZg2tQAbeWRWGthh
 /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL
 wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt+9Y8
 eVPsraecCASOK3xqMgjTxd7TD4raMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr
 6ZBbmlQMFbT3Ipaw5riIgVors0lMMnsOpJZonx6xCvVJf0nXYrCU+PB4towMDIY2JsQQaeBN
 5VxhTxHaRDmYAx2CF4sB6kQgPuNt1jBaC1akQfAzUYwyzeKl1EguFT3C/LKfvSaSMMTmVyXz
 krW8mK8DhwEOdi3zTue7mnqluLJhTn8Wo8ZCPu/7PECqFiSzWwaDFsRT0m2pdGwkEv4UNVaQ
 3H44QJ38/J0rhbyCICgAVvo+xZooyLwRfJvOtQK6gan5JPz2ACZO1gocCJPS4M54ZpeqSMR6
 neFmNbgBDpKubKTSG6A+rr8kQ5eKRT5PkdZO3ZaEFJtD83L5dhq00mRFooL/Lud04WtcQwc1
 Qxmu8TXa187qccQn5u28lnc695HjsiYF1Vljuk7s4/M0++YWGJHT9HygbQ4xawZRGp8crVnl
 CJe8yR5xLtWZaxhbATXHI0w8EiBvp5pygH0j191BIUG/D+w4XOldo04yGggeBw0YplcKWG4P
 B67VeZtCHl7ZiHCgUhfONrZNijX5fK4SYSNug78M7KinaSdhCfYpXozNCZ8LkjmkVQ2kLFXB
 HtoWZ3EMJruMow+lGDeb75EidcDn3lirUuOG8yT50n5gNK2OS7EIZ9YYQDmRr1os8u5TPD9r
 ow32z2ikUsPCYUTo0D/rOYuELz9BSNqWMmr+5ELLbPrz8gPMDhJNsI9CIgJI+RN95m5XM+Ul
 p1kckMHmlf5m1PdLgCGNiJqZL/1BM4tpnMnJy08e12v3iF7M4qo6a4ecboxfKUmq7M/naIlE
 aFddpXSGOlLRxTG5y8ZMcv3ort9eUn5ngmJJSekPmQyJsYyWwzT99b4VQLz7y1SXDGvvM4zr
 uT4hAPWSJYOXSp4C8PSZK79xl+9pyFFyulzQ1HJMp9Yf0C1qNpmLCn4j/kWJcAQKEqcmmvGh
 ljOWRpB/LvDuY449tXNlJuolYbxHrssBFdeEkna8a2yaXvQ8F28zNISS+2PZz3cCj/5of3we
 eVPwvjgG/Qbh1IW4ZFkGrNmwK9itdvio7hWklZtEHnRNgn5D7phJj+N3NVVt70Lzbhc4FPkV
 kWK89hcGLOIJMK6TwJBeFt7NryOhaMOhz3fzfUpO0GrtiZ48Y2OXVhWIxTR2jdWK6F4Md99z
 Oos0CLMB9dTVvb+3g66sx1p
IronPort-HdrOrdr: A9a23:VHVWdavOluyVrwEcuQC+/vnf7skDdtV00zEX/kB9WHVpmszxra
 6TddAgpHvJYVcqKRQdcL+7VZVoLUmxyXcx2/h3AV7AZniFhILLFuFfBOLZqlWKcREWtNQttp
 uIG5IObuEYZmIasS+V2maFL+o=
X-IronPort-AV: E=Sophos;i="5.88,334,1635220800"; 
   d="scan'208";a="63649787"
Date: Tue, 1 Feb 2022 17:40:35 +0000
From: Anthony PERARD <anthony.perard@citrix.com>
To: Michal Orzel <michal.orzel@arm.com>
CC: <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH] tools/configure.ac: Replace macro AC_HELP_STRING
Message-ID: <Yflwk30RLgUWECFF@perard>
References: <20220201170321.32510-1-michal.orzel@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220201170321.32510-1-michal.orzel@arm.com>

On Tue, Feb 01, 2022 at 06:03:21PM +0100, Michal Orzel wrote:
> ... with AS_HELP_STRING as the former is obsolete according
> to GNU autoconf 2.67 documentation.
> 
> Signed-off-by: Michal Orzel <michal.orzel@arm.com>

Acked-by: Anthony PERARD <anthony.perard@citrix.com>

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Tue Feb 01 17:48:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 01 Feb 2022 17:48:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.263743.456588 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nExG5-0004jU-M7; Tue, 01 Feb 2022 17:48:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 263743.456588; Tue, 01 Feb 2022 17:48:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nExG5-0004jN-IM; Tue, 01 Feb 2022 17:48:01 +0000
Received: by outflank-mailman (input) for mailman id 263743;
 Tue, 01 Feb 2022 17:48:01 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nExG5-0004jD-6N; Tue, 01 Feb 2022 17:48:01 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nExG5-0000qD-3T; Tue, 01 Feb 2022 17:48:01 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nExG4-0005gN-Lx; Tue, 01 Feb 2022 17:48:00 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nExG4-0004Qq-LX; Tue, 01 Feb 2022 17:48:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Y1aIN3dm3ChL1J+XfTtXwZMxeDFa4V58wd7PK+B08ZQ=; b=hdQWf9dJDMEsLLRS1tfjiPw/YV
	5QTgtX2BxKTO6varhTq16VC2tQAc9NUeZaxvW9gDr9v+B7KVwX7Qkj172Zx0pzA9TO40wQW1Nn98w
	kYu+bsOku6YRJqfAHvFn/MTJREr/cDSJplpiWtxRsnQLpY7TPfCUlnMyB4OHfaKwzUKo=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167973-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 167973: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=a7e7c7260cde78a148810db5320cbf39686c3e09
X-Osstest-Versions-That:
    xen=481ee6125aa1d5751f52eda677c7bab4719c0ad0
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 01 Feb 2022 17:48:00 +0000

flight 167973 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167973/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  a7e7c7260cde78a148810db5320cbf39686c3e09
baseline version:
 xen                  481ee6125aa1d5751f52eda677c7bab4719c0ad0

Last test of basis   167967  2022-01-31 19:02:57 Z    0 days
Testing same since   167973  2022-02-01 14:01:49 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   481ee6125a..a7e7c7260c  a7e7c7260cde78a148810db5320cbf39686c3e09 -> smoke


From xen-devel-bounces@lists.xenproject.org Tue Feb 01 19:06:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 01 Feb 2022 19:06:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.263756.456599 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEyU1-00040X-P0; Tue, 01 Feb 2022 19:06:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 263756.456599; Tue, 01 Feb 2022 19:06:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEyU1-00040Q-Ll; Tue, 01 Feb 2022 19:06:29 +0000
Received: by outflank-mailman (input) for mailman id 263756;
 Tue, 01 Feb 2022 19:06:28 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=sVqt=SQ=xilinx.com=ayankuma@srs-se1.protection.inumbo.net>)
 id 1nEyTz-00040K-VN
 for xen-devel@lists.xenproject.org; Tue, 01 Feb 2022 19:06:28 +0000
Received: from NAM10-MW2-obe.outbound.protection.outlook.com
 (mail-mw2nam10on20624.outbound.protection.outlook.com
 [2a01:111:f400:7e89::624])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0b327560-8392-11ec-8f75-fffcc8bd4f1a;
 Tue, 01 Feb 2022 20:06:23 +0100 (CET)
Received: from DM3PR12CA0138.namprd12.prod.outlook.com (2603:10b6:0:51::34) by
 BYAPR02MB3943.namprd02.prod.outlook.com (2603:10b6:a02:fc::14) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4930.15; Tue, 1 Feb 2022 19:06:18 +0000
Received: from DM3NAM02FT054.eop-nam02.prod.protection.outlook.com
 (2603:10b6:0:51:cafe::34) by DM3PR12CA0138.outlook.office365.com
 (2603:10b6:0:51::34) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.20 via Frontend
 Transport; Tue, 1 Feb 2022 19:06:18 +0000
Received: from xir-pvapexch02.xlnx.xilinx.com (149.199.80.198) by
 DM3NAM02FT054.mail.protection.outlook.com (10.13.5.135) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.4930.15 via Frontend Transport; Tue, 1 Feb 2022 19:06:17 +0000
Received: from xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) by
 xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2176.14; Tue, 1 Feb 2022 19:06:16 +0000
Received: from smtp.xilinx.com (172.21.105.197) by
 xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server id
 15.1.2176.14 via Frontend Transport; Tue, 1 Feb 2022 19:06:16 +0000
Received: from [10.71.116.56] (port=57245)
 by smtp.xilinx.com with esmtp (Exim 4.90)
 (envelope-from <ayan.kumar.halder@xilinx.com>)
 id 1nEyTm-0002eH-UT; Tue, 01 Feb 2022 19:06:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0b327560-8392-11ec-8f75-fffcc8bd4f1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=L9Wqf6r6I3pAisw0p8pmltaH9OfEJvoxeDnlKFnw3V3TzGzw+e1c/QMY1TN82vdfKHuNrdo80JAjyngIcvmi4F2UBKMsHn0Bv9hcHETwDT1JdmQFG7AmQHr1ezvcyOro9tCtdRTIEL9xs3quR5TpHj1IwjUwiFEAAfy83Lm7PMcIA16HtYgB4JI+5JmWJZektnC9RP3nn7e91O2ace7Vl34IVsyCTEdMvlPZkzdGS3KGM7ygiXJH3v+wN7UUXUV4f6lFJ3gx8j+G840EW5iPKhH4WqYIy83p59n136rcYl2dVeqdtTQAon4KtvAIyWpKaiIW331kAWhBOXCosT7JoQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Frnyfubl7FDb2kPFykZU2ss4Re/A4iYMFFkasOkrWbE=;
 b=GPQ10U8p4gQ9Yo2DsfvZPDECZ53V2imAqFAoCF1O1Z141aPoSuhDSN3+2sEODGmX2Wm8nAuHm0f9tuA0sEGyxwh4vYgXm/n0/HsjikFfjxQaY9nQE55re75IxuZPGIIEmkyp0mzJuWBqPreez8jXxKYRD6d7AfvJZ4YqEPcIQbZrVLi+ZeoKmfb2mwsOQBTVQjHxfYudTDWfLUXzgQnZBLKnsLqwewJNb2txR65SK2VB6mycs3h8PmgCtnG1oF73/UCyQFj0ntSOXXhemec8L3+0G4/IsXPMor2COu7QOuWQZJOdKP4vftp95tg/pkjQ4gcSJ+Kgj9yzM5RTBB9Vzw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 149.199.80.198) smtp.rcpttodomain=xen.org smtp.mailfrom=xilinx.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Frnyfubl7FDb2kPFykZU2ss4Re/A4iYMFFkasOkrWbE=;
 b=VbQcjUNo/pKLkR9N4de9xJ5OsOuZL91PdOwZVbjoPcHdRT94R7S3f3WUcIDZ/74BDbG/sSBO0P90FO7FU+vXlfTJJYPw/ynNO6KjCCOdWpbADpopJJYw/u+jS2PlZJOzqqOMge4MZ4uhDg8iuZCBRsonm6znxuhf/wQ+ZWj7TD0=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198)
 smtp.mailfrom=xilinx.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=xilinx.com;
Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates
 149.199.80.198 as permitted sender) receiver=protection.outlook.com;
 client-ip=149.199.80.198; helo=xir-pvapexch02.xlnx.xilinx.com;
Message-ID: <33bda050-9b9f-5840-282b-6f591988a09f@xilinx.com>
Date: Tue, 1 Feb 2022 19:06:14 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.1
Subject: Re: [XEN v5] xen/arm64: io: Decode ldr/str post-indexing instructions
To: Julien Grall <julien@xen.org>, Ayan Kumar Halder
	<ayan.kumar.halder@xilinx.com>, <xen-devel@lists.xenproject.org>,
	<stefanos@xilinx.com>
CC: <sstabellini@kernel.org>, <Volodymyr_Babchuk@epam.com>,
	<bertrand.marquis@arm.com>
References: <20220131193728.2980-1-ayankuma@xilinx.com>
 <e07068aa-91b8-ebdf-db17-7173f417ad33@xen.org>
From: Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>
In-Reply-To: <e07068aa-91b8-ebdf-db17-7173f417ad33@xen.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f79b416a-0bd1-4f9c-69e6-08d9e5b5ed2f
X-MS-TrafficTypeDiagnostic: BYAPR02MB3943:EE_
X-Microsoft-Antispam-PRVS:
	<BYAPR02MB3943A574661603EB1DEB3FE6B2269@BYAPR02MB3943.namprd02.prod.outlook.com>
X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	pF3lwWItccISIf5mvUyyj/KUogEh76wEsWsfO7+aWHPecf3GkH7hH9Nt0gCMfiUn5J45Sp7CWFnDCAGvb+Fxznu+31JTQXiq52oPTTkUJvceHlretZgkna7e9O/2Yz/MUaMwZUpRgAYoU199MDHa7aXq6cxG1xLZSsNFGk6WR6pPNTmPD3z1mk4Fx/dXDWr2W5l0zi2ruoG3+3MpHBratvppOMtYYi7RIrUG/3UBezr+mQvZbLqtFncJQORoV0s+OfTq7rwRTYz1F4gIqHb7aMcbboKnBDdQBaW4DhHGGIA36kZ4Dqbt/7tmZ4p0bvJR9W7/yYFv7+KVVF72YuAqSmcaKNVo92bPoHF2oix7+4LqXeIc2Ljf8yHcw7iii/xs7Keo5P1wpmmf8683KxrO9lrt1OK7xLu0WABdiof9N6whSlrVPOqZktXJzU1rNRFha8td+SmmGi20Ik0rP1lOa/chHukScCbiQkK9+XZsipVQTFLYB1EulCblUM9E8nZfjjhmFrat11+x/Xgw3dXWiOZwhkZ5Hvj5i3TtpNV9hFq02pDfJRJIPi6UM2ZuGSFVKHu8LP6hsfOGy/Cq9BqKnLUJPMApcHKgswntmshJsqj9pkvMskipEtnmNYJ9PrBZhhKj26V/UbLWJFieSqF0I7NAl4fCa0nmC1+vlY0bHHmeiHfqmm0DD+EfX7iezVZAs9p8K4akd5Lmcp9bxMFgne+pI56LGkmIW1BYwlUfsZHgXuVy1ZDl0Dp6ItRKanJG/7q9PCtsEynlRQ0p4vc62ZBUgsjiGgdWCYx1efcncMv79ElHAmuxgZ8yMULDqodqO3WzM73MsgWZHP+XN609ETQz+KJDY0bB+c13YNRbSUM=
X-Forefront-Antispam-Report:
	CIP:149.199.80.198;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:xir-pvapexch02.xlnx.xilinx.com;PTR:unknown-80-198.xilinx.com;CAT:NONE;SFS:(13230001)(4636009)(84040400005)(46966006)(36840700001)(8676002)(8936002)(9786002)(6636002)(4326008)(2616005)(47076005)(70206006)(70586007)(31686004)(966005)(508600001)(54906003)(110136005)(316002)(186003)(2906002)(26005)(83380400001)(30864003)(426003)(336012)(36860700001)(31696002)(82310400004)(36756003)(53546011)(5660300002)(7636003)(356005)(50156003)(43740500002)(473944003)(20210929001);DIR:OUT;SFP:1101;
X-OriginatorOrg: xilinx.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2022 19:06:17.8597
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: f79b416a-0bd1-4f9c-69e6-08d9e5b5ed2f
X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.80.198];Helo=[xir-pvapexch02.xlnx.xilinx.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DM3NAM02FT054.eop-nam02.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR02MB3943

Hi Stefano,

I need your input on one thing.

On 31/01/2022 21:55, Julien Grall wrote:
> Hi,
>
> On 31/01/2022 19:37, Ayan Kumar Halder wrote:
>> At the moment, Xen is only handling data abort with valid syndrome (i.e.
>> ISV=0). Unfortunately, this doesn't cover all the instructions a domain
>> could use to access MMIO regions.
>>
>> For instance, a baremetal OS can use any of the following 
>> instructions, where
>> x1 contains the address of the MMIO region:
>>
>> 1.      ldr     x2,    [x1],    #8
>> 2.      ldr     w2,    [x1],    #-4
>> 3.      ldr     x2,    [x1],    #-8
>> 4.      ldr     w2,    [x1],    #4
>> 5.      ldrh    w2,    [x1],    #2
>> 6.      ldrb    w2,    [x1],    #1
>> 7.      str     x2,    [x1],    #8
>> 8.      str     w2,    [x1],    #-4
>> 9.      strh    w2,    [x1],    #2
>> 10.     strb    w2,    [x1],    #1
>>
>> In the following two instructions, Rn could theoretically be stack 
>> pointer which
>> might contain the address of the MMIO region:-
>> 11.     ldrb    w2,    [Rn],    #1
>> 12.     ldrb    wzr,   [Rn],    #1
>>
>> In order to handle post-indexing store/load instructions (like those 
>> mentioned
>> above), Xen will need to fetch and decode the instruction.
>>
>> Xen will not decode the instructions if the data abort is caused by 
>> stage1
>> translation table walk or cache instructions. In the former scenario, 
>> it will
>> try to update the page tables and in the latter scenario, it will 
>> ignore the
>> instruction (ie simply increment the program counter).
>>
>> If Xen is unable to decode the instructions, it will abort the guest.
>>
>> This patch only cover post-index store/load instructions from AArch64 
>> mode.
>> For now, AArch32 mode is left unimplemented.
>>
>> Signed-off-by: Ayan Kumar Halder <ayankuma@xilinx.com>
>> ---
>>
>> Changelog :-
>> v2 - 1. Updated the rn register after reading from it. (Pointed by 
>> Julien,
>>          Stefano)
>>       2. Used a union to represent the instruction opcode (Suggestd 
>> by Bertrand)
>>       3. Fixed coding style issues (Pointed by Julien)
>>       4. In the previous patch, I was updating dabt->sign based on 
>> the signedness
>>          of imm9. This was incorrect. As mentioned in ARMv8 ARM DDI 
>> 0487G.b,
>>          Page 3221, SSE indicates the signedness of the data item 
>> loaded. In our
>>          case, the data item loaded is always unsigned.
>>
>> v3- 1. Handled all the variants of ldr/str (ie 64, 32, 16, 8 bit 
>> variants).
>>         Thus, I have removed the check for "instr->code.opc == 0" 
>> (Suggested by
>>         Andre)
>>      2. Handled the scenario when rn = SP, rt = XZR (Suggested by 
>> Jan, Andre)
>>      3. Added restriction for "rt != rn" (Suggested by Andre)
>>      4. Moved union ldr_str_instr_class {} to decode.h. This is the 
>> header included
>>         by io.c and decode.c (where the union is referred). 
>> (Suggested by Jan)
>>      5. Indentation and typo fixes (Suggested by Jan)
>>
>> v4- 1. Fixed the patch as per Stefano's comments on v3. They are as 
>> follows :-
>>          1.1 Use macros to determine the fixed values in the 
>> instruction opcode
>>          1.2 Checked if instr != NULL
>>          1.3 Changed some data types and added #define ARM_64 for 
>> AArch64 specific
>>              code
>>          1.4 Moved post_increment_register() to decode.c so that the 
>> decoding
>>              logic is confined to a single file.
>>          1.5 Moved some checks from post_increment_register() to
>>              decode_loadstore_postindexing()
>>          1.6 Removed a duplicate check
>>      2. Updated the commit message as per Andre's comments.
>>      3. Changed the names of a label and some comments. *32bit* was 
>> erroneously
>>         mentioned in a label and comments in 
>> decode_loadstore_postindexing()
>>         although the function handled all variants of ldr/str post 
>> indexing.
>>
>> v5- 1. Renamed decode_loadstore_postindexing() to decode_arm64(). The 
>> reason
>>         being this will be extended in future to support more 
>> instructions for
>>         which hsr_badt.isv = 0
>>      2. Introduce a function try_decode_instruction_invalid_iss() to 
>> determine
>>         if the instruction needs to be decoded before invoking 
>> decode_instruction().
>>
>>         It checks :-
>>         2.1  dabt->s1ptw - Returns IO_UNHANDLED
>>         2.2  dabt->cache - Returns IO_IGNORED. (new enum instroduced 
>> to let the
>>              caller know that the instruction needs to be ignored by 
>> Xen. Thus
>>              the caller needs to increment the PC and return to the 
>> guest.
>>
>>      3. Invoked try_decode_instruction_invalid_iss() from the 
>> following 2 places :-
>>          3.a - try_handle_mmio() - When we have determined that there 
>> is a valid
>>                mmio handler.
>>          3.b - try_fwd_ioserv()
>>          When ioserver completes the io request, the acknowledgement 
>> is sent via
>>          handle_ioserv(). Here, we need to increment the register. As 
>> there is no
>>          common data shared between try_fwd_ioserv() and 
>> handle_ioserv(), we need
>>          to decode the instruction again in handle_ioserv() to 
>> determine rn, imm9.
>>
>>          (NOTE to Reviewers) - This does not feel correct. However, I 
>> could not
>>          think of a better approach. Please provide your inputs.
>>
>>      4. Augumented struct hsr_dabt{} with struct 
>> hsr_dabt_instr_details{} to hold
>>         rn and imm9. This is passed to post_increment_register() to 
>> update rn.
>>      5. Other style changes as suggested in v4.
>>
>>   Patch has been based on the comments received on the following two 
>> patches:-
>>   1. 
>> https://lists.xenproject.org/archives/html/xen-devel/2022-01/msg01245.html
>>   2. 
>> https://lists.xenproject.org/archives/html/xen-devel/2022-01/msg01279.html
>>
>>   xen/arch/arm/arm32/traps.c  |  7 ++++
>>   xen/arch/arm/arm64/traps.c  | 42 +++++++++++++++++++++
>>   xen/arch/arm/decode.c       | 73 +++++++++++++++++++++++++++++++++++++
>>   xen/arch/arm/decode.h       | 42 ++++++++++++++++++++-
>>   xen/arch/arm/io.c           | 66 +++++++++++++++++++++++++++------
>>   xen/arch/arm/ioreq.c        | 35 +++++++++++++++++-
>>   xen/arch/arm/traps.c        |  1 +
>>   xen/include/asm-arm/hsr.h   |  5 +++
>>   xen/include/asm-arm/mmio.h  |  1 +
>>   xen/include/asm-arm/traps.h |  1 +
>>   10 files changed, 258 insertions(+), 15 deletions(-)
>
> This patch is continuing to grow and it is getting more difficult to 
> review. Can it be split in at least two parts?
>
> 1) Decode ldr/str
> 2) Plumb the code
>
>>
>> diff --git a/xen/arch/arm/arm32/traps.c b/xen/arch/arm/arm32/traps.c
>> index 9c9790a6d1..62a91e8728 100644
>> --- a/xen/arch/arm/arm32/traps.c
>> +++ b/xen/arch/arm/arm32/traps.c
>> @@ -24,6 +24,8 @@
>>   #include <asm/processor.h>
>>   #include <asm/traps.h>
>>   +struct hsr_dabt_instr_details;
>
> Please don't do that. If you need to forward declare it, then it 
> should be in traps.h.
>
>> +
>>   void do_trap_reset(struct cpu_user_regs *regs)
>>   {
>>       do_unexpected_trap("Reset", regs);
>> @@ -82,6 +84,11 @@ void do_trap_data_abort(struct cpu_user_regs *regs)
>>           do_unexpected_trap("Data Abort", regs);
>>   }
>>   +void post_increment_register(const struct hsr_dabt_instr_details 
>> *instr_details)
>> +{
>> +    ASSERT_UNREACHABLE();
>> +}
>> +
>>   /*
>>    * Local variables:
>>    * mode: C
>> diff --git a/xen/arch/arm/arm64/traps.c b/xen/arch/arm/arm64/traps.c
>> index 9113a15c7a..482751496f 100644
>> --- a/xen/arch/arm/arm64/traps.c
>> +++ b/xen/arch/arm/arm64/traps.c
>> @@ -18,9 +18,11 @@
>>     #include <xen/lib.h>
>>   +#include <asm/current.h>
>>   #include <asm/hsr.h>
>>   #include <asm/system.h>
>>   #include <asm/processor.h>
>> +#include <asm/regs.h>
>>     #include <public/xen.h>
>>   @@ -31,6 +33,8 @@ static const char *handler[]= {
>>           "Error"
>>   };
>>   +struct hsr_dabt_instr_details;
>
> Same here.
>
>> +
>>   void do_bad_mode(struct cpu_user_regs *regs, int reason)
>>   {
>>       union hsr hsr = { .bits = regs->hsr };
>> @@ -44,6 +48,44 @@ void do_bad_mode(struct cpu_user_regs *regs, int 
>> reason)
>>       panic("bad mode\n");
>>   }
>>   +void post_increment_register(const struct hsr_dabt_instr_details 
>> *instr_details)
>> +{
>> +    struct cpu_user_regs *regs = guest_cpu_user_regs();
>> +    register_t val;
>> +
>> +    /*
>> +     * Handle when rn = SP
>> +     * Refer ArmV8 ARM DDI 0487G.b, Page - D1-2463 "Stack pointer 
>> register selection"
>> +     * t = SP_EL0
>> +     * h = SP_ELx
>> +     * and M[3:0] (Page - C5-474 "When exception taken from AArch64 
>> state:")
>> +     */
>> +    if (instr_details->rn == 31 )
>> +    {
>> +        if ( (regs->cpsr & PSR_MODE_MASK) == PSR_MODE_EL1h )
>> +            val = regs->sp_el1;
>> +        else if ( ((regs->cpsr & PSR_MODE_MASK) == PSR_MODE_EL1t) ||
>> +                    ((regs->cpsr & PSR_MODE_MASK) == PSR_MODE_EL0t) )
>> +            val = regs->sp_el0;
>> +        else
>> +            ASSERT_UNREACHABLE();
>> +    }
>> +    else
>> +        val = get_user_reg(regs, instr_details->rn);
>> +
>> +    val += instr_details->imm9;
>> +
>> +    if ( instr_details->rn == 31 )
>> +    {
>> +        if ( (regs->cpsr & PSR_MODE_MASK) == PSR_MODE_EL1h )
>> +            regs->sp_el1 = val;
>> +        else
>> +            regs->sp_el0 = val;
>> +    }
>> +    else
>> +        set_user_reg(regs, instr_details->rn, val);
>> +}
>> +
>>   /*
>>    * Local variables:
>>    * mode: C
>> diff --git a/xen/arch/arm/decode.c b/xen/arch/arm/decode.c
>> index 792c2e92a7..63376adc7c 100644
>> --- a/xen/arch/arm/decode.c
>> +++ b/xen/arch/arm/decode.c
>> @@ -84,6 +84,76 @@ bad_thumb2:
>>       return 1;
>>   }
>>   +static int decode_arm64(register_t pc, struct hsr_dabt *dabt)
>> +{
>> +    union instr opcode = {0};
>> +
>> +    if ( raw_copy_from_guest(&opcode.value, (void * __user)pc, 
>> sizeof (opcode)) )
>> +    {
>> +        gprintk(XENLOG_ERR, "Could not copy the instruction from 
>> PC\n");
>> +        goto bad_loadstore;
>> +    }
>> +
>> +    /*
>> +     * Refer Arm v8 ARM DDI 0487G.b, Page - C6-1107
>> +     * "Shared decode for all encodings" (under ldr immediate)
>> +     * If n == t && n != 31, then the return value is implementation 
>> defined
>> +     * (can be WBSUPPRESS, UNKNOWN, UNDEFINED or NOP). Thus, we do 
>> not support
>> +     * this. This holds true for ldrb/ldrh immediate as well.
>> +     *
>> +     * Also refer, Page - C6-1384, the above described behaviour is 
>> same for
>> +     * str immediate. This holds true for strb/strh immediate as well
>> +     */
>> +    if ( (opcode.ldr_str.rn == opcode.ldr_str.rt) && 
>> (opcode.ldr_str.rn != 31) )
>> +    {
>> +        gprintk(XENLOG_ERR, "Rn should not be equal to Rt except for 
>> r31\n");
>> +        goto bad_loadstore;
>> +    }
>> +
>> +    /* First, let's check for the fixed values */
>> +    if ( (opcode.value & POST_INDEX_FIXED_MASK) != 
>> POST_INDEX_FIXED_VALUE )
>> +    {
>> +        gprintk(XENLOG_ERR,
>> +            "Decoding instruction 0x%x is not supported",opcode.value);
>
> Coding style. The string should start on the same column as 
> XENLOG_ERR. Also, missing space after the comma.
>
>> +        goto bad_loadstore;
>> +    }
>> +
>> +    if ( opcode.ldr_str.v != 0 )
>> +    {
>> +        gprintk(XENLOG_ERR,
>> +            "ldr/str post indexing for vector types are not 
>> supported\n");
>
> Same here.
>
>
>> +        goto bad_loadstore;
>> +    }
>> +
>> +    /* Check for STR (immediate) */
>> +    if ( opcode.ldr_str.opc == 0 )
>> +        dabt->write = 1;
>> +    /* Check for LDR (immediate) */
>> +    else if ( opcode.ldr_str.opc == 1 )
>> +        dabt->write = 0;
>> +    else
>> +    {
>> +        gprintk(XENLOG_ERR,
>> +            "Decoding ldr/str post indexing is not supported for 
>> this variant\n");
>
> Same here.
>
>> +        goto bad_loadstore;
>> +    }
>> +
>> +    gprintk(XENLOG_INFO,
>> +        "opcode->ldr_str.rt = 0x%x, opcode->ldr_str.size = 0x%x, 
>> opcode->ldr_str.imm9 = %d\n",
>> +        opcode.ldr_str.rt, opcode.ldr_str.size, opcode.ldr_str.imm9);
>
> Same here.
>
>> +
>> +    update_dabt(dabt, opcode.ldr_str.rt, opcode.ldr_str.size, false);
>> +
>> +    dabt->dabt_instr.rn = opcode.ldr_str.rn;
>> +    dabt->dabt_instr.imm9 = opcode.ldr_str.imm9;
>> +
>> +    return 0;
>> +
>> + bad_loadstore:
>> +    gprintk(XENLOG_ERR, "unhandled Arm instruction 0x%x\n", 
>> opcode.value);
>> +    return 1;
>> +}
>> +
>>   static int decode_thumb(register_t pc, struct hsr_dabt *dabt)
>>   {
>>       uint16_t instr;
>> @@ -155,6 +225,9 @@ int decode_instruction(const struct cpu_user_regs 
>> *regs, struct hsr_dabt *dabt)
>>       if ( is_32bit_domain(current->domain) && regs->cpsr & PSR_THUMB )
>>           return decode_thumb(regs->pc, dabt);
>>   +    if ( !psr_mode_is_32bit(regs) )
>> +        return decode_arm64(regs->pc, dabt);
>> +
>>       /* TODO: Handle ARM instruction */
>>       gprintk(XENLOG_ERR, "unhandled ARM instruction\n");
>>   diff --git a/xen/arch/arm/decode.h b/xen/arch/arm/decode.h
>> index 4613763bdb..7080da9ab6 100644
>> --- a/xen/arch/arm/decode.h
>> +++ b/xen/arch/arm/decode.h
>> @@ -23,9 +23,47 @@
>>   #include <asm/regs.h>
>>   #include <asm/processor.h>
>>   -/**
>> +/*
>> + * Refer to the ARMv8 ARM (DDI 0487G.b), Section C4.1.4 Loads and 
>> Stores
>> + * Page 318 specifies the following bit pattern for
>> + * "load/store register (immediate post-indexed)".
>> + *
>> + * 31 30 29  27 26 25  23   21 20              11   9 4       0
>> + * ___________________________________________________________________
>> + * |size|1 1 1 |V |0 0 |opc |0 |      imm9     |0 1 |  Rn |  Rt   |
>> + * |____|______|__|____|____|__|_______________|____|_________|_______|
>> + */
>> +union instr {
>> +    uint32_t value;
>> +    struct {
>> +        unsigned int rt:5;     /* Rt register */
>> +        unsigned int rn:5;     /* Rn register */
>> +        unsigned int fixed1:2; /* value == 01b */
>> +        signed int imm9:9;            /* imm9 */
>> +        unsigned int fixed2:1; /* value == 0b */
>> +        unsigned int opc:2;    /* opc */
>> +        unsigned int fixed3:2; /* value == 00b */
>> +        unsigned int v:1;      /* vector */
>> +        unsigned int fixed4:3; /* value == 111b */
>> +        unsigned int size:2;   /* size */
>> +    } ldr_str;
>> +};
>> +
>> +#define POST_INDEX_FIXED_MASK   0x3B200C00
>> +#define POST_INDEX_FIXED_VALUE  0x38000400
>
> The union and POST_INEX_FIXED_* defines only seem to be used within 
> decode.c. So can they be moved to avoid polluting the header? (This 
> was my original aim with avoid to use the union).
>
>> +
>> +/*
>> + * Try to decode an instruction when ISS is invalid
>> + * This function determines if the instruction is to be decoded on 
>> the basis of
>> + * the attributes in 'struct hsr_dabt'. If so, then invokes 
>> decode_instruction().
>> + * If not, it returns an appropriate io_state.
>> + */
>> +enum io_state try_decode_instruction_invalid_iss(const struct 
>> cpu_user_regs *regs,
>> +                                                 struct hsr_dabt 
>> *dabt);
>> +
>> +/*
>>    * Decode an instruction from pc
>> - * /!\ This function is not intended to fully decode an instruction. It
>> + * This function is not intended to fully decode an instruction. It
>
> Why is /!\ is dropped? But then, is this comment still accurate given 
> that you will now fully decode an instruction?
>
>>    * considers that the instruction is valid.
>>    *
>>    * This function will get:
>> diff --git a/xen/arch/arm/io.c b/xen/arch/arm/io.c
>> index 14d39222f2..dede7d59b0 100644
>> --- a/xen/arch/arm/io.c
>> +++ b/xen/arch/arm/io.c
>> @@ -95,6 +95,35 @@ static const struct mmio_handler 
>> *find_mmio_handler(struct domain *d,
>>       return handler;
>>   }
>>   +enum io_state try_decode_instruction_invalid_iss(const struct 
>> cpu_user_regs *regs,
>> +                                                 struct hsr_dabt *dabt)
>> +{
>> +    int rc;
>> +
>> +    /*
>> +     * Xen should not decode the instruction when it was trapped due to
>> +     * translation fault.
>> +     */
>> +    if ( dabt->s1ptw )
>> +        return IO_UNHANDLED;
>> +
>> +    /*
>> +     * If the fault occurred due to cache maintenance or address 
>> translation
>> +     * instructions, then Xen needs to ignore these instructions.
>> +     */
>> +    if ( dabt->cache )
>> +        return IO_IGNORED;
>
> IMO, IO_IGNORED is the same as IO_HANDLED because ignoring an access 
> is a form of handling it. We are using it like that in a few places.
>
>> +
>> +    rc = decode_instruction(regs, dabt);
>> +    if ( rc )
>> +    {
>> +        gprintk(XENLOG_ERR, "Unable to decode instruction\n");
>> +        return IO_ABORT;
>> +    }
>> +    else
>> +        return IO_HANDLED;
>
> I think you are misusing io_state here. The I/O has not been handled 
> yet. You only managed to decode it... IOW, the I/O access may still 
> technically fail afterwards.
>
>> +}
>> +
>>   enum io_state try_handle_mmio(struct cpu_user_regs *regs,
>>                                 const union hsr hsr,
>>                                 paddr_t gpa)
>> @@ -106,21 +135,14 @@ enum io_state try_handle_mmio(struct 
>> cpu_user_regs *regs,
>>           .gpa = gpa,
>>           .dabt = dabt
>>       };
>> +    int rc;
>> +    bool instr_decoded = false;
>>         ASSERT(hsr.ec == HSR_EC_DATA_ABORT_LOWER_EL);
>>   -    /* All the instructions used on emulated MMIO region should be 
>> valid */
>> -    if ( !dabt.valid )
>> -    {
>> -        gprintk(XENLOG_DEBUG, "No valid instruction syndrome for 
>> data abort\n");
>> -        return IO_ABORT;
>> -    }
>> -
>
> It looks like this patch is based on your other patch. However, you 
> said there will be no v2. So please rebase it.
>
>>       handler = find_mmio_handler(v->domain, info.gpa);
>>       if ( !handler )
>>       {
>> -        int rc;
>> -
>>           rc = try_fwd_ioserv(regs, v, &info);
>>           if ( rc == IO_HANDLED )
>>               return handle_ioserv(regs, v);
>> @@ -128,6 +150,21 @@ enum io_state try_handle_mmio(struct 
>> cpu_user_regs *regs,
>>           return rc;
>>       }
>>   +    /*
>> +     * Armv8 processor does not provide a valid syndrome for 
>> decoding some
>> +     * instructions. So in order to process these instructions, Xen 
>> must
>> +     * decode them.
>> +     */
>> +    if ( !dabt.valid )
>> +    {
>> +        rc = try_decode_instruction_invalid_iss(regs, &info.dabt);
>> +
>> +        if ( rc != IO_HANDLED)
>> +            return rc;
>> +        else
>> +            instr_decoded = true;
>> +    }
>> +
>>       /*
>>        * Erratum 766422: Thumb store translation fault to Hypervisor may
>>        * not have correct HSR Rt value.
>> @@ -146,9 +183,16 @@ enum io_state try_handle_mmio(struct 
>> cpu_user_regs *regs,
>>       }
>>         if ( info.dabt.write )
>> -        return handle_write(handler, v, &info);
>> +        rc = handle_write(handler, v, &info);
>>       else
>> -        return handle_read(handler, v, &info);
>> +        rc = handle_read(handler, v, &info);
>> +
>> +    if ( instr_decoded )
>> +    {
>> +        post_increment_register(&info.dabt.dabt_instr);
>> +    }
>
> I thought I mentionned before. I don't think this is correct to call 
> post_increment_register() if rc is not equal IO_HANDLED. We want to 
> let the guest know there was an abort and let the guest handling it 
> (and possibly retry).
>
> If you increment/decrement the register, then the next execution would 
> end up to be wrong.
>
>> +
>> +    return rc;
>>   }
>>     void register_mmio_handler(struct domain *d,
>> diff --git a/xen/arch/arm/ioreq.c b/xen/arch/arm/ioreq.c
>> index 308650b400..f19fb46f72 100644
>> --- a/xen/arch/arm/ioreq.c
>> +++ b/xen/arch/arm/ioreq.c
>> @@ -23,16 +23,35 @@
>>     #include <public/hvm/ioreq.h>
>>   +#include "decode.h"
>> +
>>   enum io_state handle_ioserv(struct cpu_user_regs *regs, struct vcpu 
>> *v)
>>   {
>>       const union hsr hsr = { .bits = regs->hsr };
>> -    const struct hsr_dabt dabt = hsr.dabt;
>> +    struct hsr_dabt dabt = hsr.dabt;
>> +
>>       /* Code is similar to handle_read */
>>       register_t r = v->io.req.data;
>>         /* We are done with the IO */
>>       v->io.req.state = STATE_IOREQ_NONE;
>>   +    /*
>> +     * Note that we have already decoded the instruction in 
>> try_fwd_ioserv().
>> +     * We decode the instruction again to obtain rn and imm9. This 
>> will be used
>> +     * to do the post increment.
>> +     * Also there is no need to check whether the instruction can be 
>> decoded or
>> +     * was successfully decoded. The reason being if there was an 
>> error, then
>> +     * try_fwd_ioserv() would have returned error and this function 
>> would not
>> +     * have been called. Thus, there is an assumption that 
>> handle_iosev() is
>> +     * invoked when try_fwd_ioserv() has returned successfully.
>
> I am afraid this is not a correct assumption. Another vCPU can modify 
> the instruction between the two decoding. So the right solution is to 
> stash the information for latter consumption.
>
>> +     */
>> +    if ( !dabt.valid )
>> +    {
>> +        decode_instruction(regs, &dabt);
>> +        post_increment_register(&dabt.dabt_instr);
>> +    }
>> +
>>       if ( dabt.write )
>>           return IO_HANDLED;
>>   @@ -65,6 +84,8 @@ enum io_state try_fwd_ioserv(struct cpu_user_regs 
>> *regs,
>>       };
>>       struct ioreq_server *s = NULL;
>>       enum io_state rc;
>> +    bool instr_decoded = false;
>> +    const union hsr hsr = { .bits = regs->hsr };
>>         if ( vio->req.state != STATE_IOREQ_NONE )
>>       {
>> @@ -76,8 +97,18 @@ enum io_state try_fwd_ioserv(struct cpu_user_regs 
>> *regs,
>>       if ( !s )
>>           return IO_UNHANDLED;
>>   +    /*
>> +     * Armv8 processor does not provide a valid syndrome for 
>> decoding some
>> +     * instructions (for eg post-indexing ldr/str instructions). So 
>> in order to
>> +     * process these instructions, Xen must decode them.
>> +     */
>>       if ( !info->dabt.valid )
>> -        return IO_ABORT;
>> +    {
>> +        rc = try_decode_instruction_invalid_iss(regs, &info->dabt);
>> +
>> +        if ( rc != IO_HANDLED)
>> +            return rc;
>> +    }
>
> As you pointed out previously, the field SAS (Syndrome Access Size) is 
> invalid when the ISV=0. So the decoding needs to be done *before* we 
> select the IOREQ server.
>
> But as I said, this would result to decode the instruciton when this 
> is not necessary. This is where Stefano's suggestion in [1] is useful.
>
> For ISV=0, it will be a lot more common to trap because of a P2M 
> translation fault (of the MMIO is not mapped). So we should call that 
> first and then, if it still not resolved, try to decode the instruction.
>
> With that in place, you are avoiding the issue in try_fwd_ioserv().
>
> Can you please coordinate with Stefano?

Can you let me know which suggestion Julien is referring here ?

[1] does not point to a valid url.

- Ayan

>
>>         vio->req = p;
>>   diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c
>> index 219ab3c3fb..2958e4b697 100644
>> --- a/xen/arch/arm/traps.c
>> +++ b/xen/arch/arm/traps.c
>> @@ -1979,6 +1979,7 @@ static void do_trap_stage2_abort_guest(struct 
>> cpu_user_regs *regs,
>>               {
>>               case IO_ABORT:
>>                   goto inject_abt;
>> +            case IO_IGNORED:
>>               case IO_HANDLED:
>>                   advance_pc(regs, hsr);
>>                   return;
>> diff --git a/xen/include/asm-arm/hsr.h b/xen/include/asm-arm/hsr.h
>> index 9b91b28c48..2d1fbec2ab 100644
>> --- a/xen/include/asm-arm/hsr.h
>> +++ b/xen/include/asm-arm/hsr.h
>> @@ -143,6 +143,11 @@ union hsr {
>>           unsigned long valid:1; /* Syndrome Valid */
>>           unsigned long len:1;   /* Instruction length */
>>           unsigned long ec:6;    /* Exception Class */
>> +
>> +        struct hsr_dabt_instr_details {
>> +            unsigned long rn:5;
>> +            signed int imm9:9;
>> +        } dabt_instr; /* Data abort details obtained from instr 
>> decoding */
>
> The header hsr.h is describing structure used by the Arm Arm. In 
> particular, this change will at least impact the size of union hsr and 
> I am concerned there may be other consequences.
>
> What I meant by augmented dabt is something like:
>
> struct {
>    hsr_dabt dabt;
>    struct instr_details {
>    }
> }
>
> In fact looking at the code, I think we can add your new structure in 
> mmio_info_t.
>
>>       } dabt; /* HSR_EC_DATA_ABORT_* */
>>         /* Contain the common bits between DABT and IABT */
>> diff --git a/xen/include/asm-arm/mmio.h b/xen/include/asm-arm/mmio.h
>> index 7ab873cb8f..0cf00bc5a7 100644
>> --- a/xen/include/asm-arm/mmio.h
>> +++ b/xen/include/asm-arm/mmio.h
>> @@ -36,6 +36,7 @@ enum io_state
>>   {
>>       IO_ABORT,       /* The IO was handled by the helper and led to 
>> an abort. */
>>       IO_HANDLED,     /* The IO was successfully handled by the 
>> helper. */
>> +    IO_IGNORED,     /* The IO was ignored by the helper. */
>>       IO_UNHANDLED,   /* The IO was not handled by the helper. */
>>       IO_RETRY,       /* Retry the emulation for some reason */
>>   };
>> diff --git a/xen/include/asm-arm/traps.h b/xen/include/asm-arm/traps.h
>> index 2ed2b85c6f..bd22c6575d 100644
>> --- a/xen/include/asm-arm/traps.h
>> +++ b/xen/include/asm-arm/traps.h
>> @@ -109,6 +109,7 @@ static inline register_t sign_extend(const struct 
>> hsr_dabt dabt, register_t r)
>>       return r;
>>   }
>>   +void post_increment_register(const struct hsr_dabt_instr_details 
>> *instr_details);
>
> Coding style: Let's keep the newline before #endif.
>
>>   #endif /* __ASM_ARM_TRAPS__ */
>>   /*
>>    * Local variables:
>
> Cheers,
>
> [1] alpine.DEB.2.22.394.2201271327430.27308@ubuntu-linux-20-04-desktop
>


From xen-devel-bounces@lists.xenproject.org Tue Feb 01 19:13:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 01 Feb 2022 19:13:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.263764.456610 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEyb5-0005WW-NE; Tue, 01 Feb 2022 19:13:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 263764.456610; Tue, 01 Feb 2022 19:13:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nEyb5-0005WP-JM; Tue, 01 Feb 2022 19:13:47 +0000
Received: by outflank-mailman (input) for mailman id 263764;
 Tue, 01 Feb 2022 19:13:45 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nEyb3-0005WJ-OE
 for xen-devel@lists.xenproject.org; Tue, 01 Feb 2022 19:13:45 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nEyb3-0002N1-9H; Tue, 01 Feb 2022 19:13:45 +0000
Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=[10.95.141.48])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nEyb3-00073v-3F; Tue, 01 Feb 2022 19:13:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=NjJkq9wLlhYxpB/gsVbbyWQ5Brt4xDzzbjoROOJzpgw=; b=i+QqQmW9b/skl1VJ6/aMaFIOrM
	tWbTo7QBFFoWBmJr1YZLaAXmxa0g3y1gCvMR9ldXuho9YvzFZ2ieZL+1bTXTypFzWrSNOhAqlxEza
	BB6Q1im5mXgSePJfALuvXfE7VMxD17Bp6FVmABd1/UJ5amcvEam1JKpAJA6Id/FWXFfE=;
Message-ID: <4551a66f-7de6-6230-d5f9-460d5d62ccdc@xen.org>
Date: Tue, 1 Feb 2022 19:13:43 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.1
Subject: Re: [XEN v5] xen/arm64: io: Decode ldr/str post-indexing instructions
To: Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>,
 xen-devel@lists.xenproject.org, stefanos@xilinx.com
Cc: sstabellini@kernel.org, Volodymyr_Babchuk@epam.com,
 bertrand.marquis@arm.com
References: <20220131193728.2980-1-ayankuma@xilinx.com>
 <e07068aa-91b8-ebdf-db17-7173f417ad33@xen.org>
 <33bda050-9b9f-5840-282b-6f591988a09f@xilinx.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <33bda050-9b9f-5840-282b-6f591988a09f@xilinx.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 01/02/2022 19:06, Ayan Kumar Halder wrote:
>> As you pointed out previously, the field SAS (Syndrome Access Size) is 
>> invalid when the ISV=0. So the decoding needs to be done *before* we 
>> select the IOREQ server.
>>
>> But as I said, this would result to decode the instruciton when this 
>> is not necessary. This is where Stefano's suggestion in [1] is useful.
>>
>> For ISV=0, it will be a lot more common to trap because of a P2M 
>> translation fault (of the MMIO is not mapped). So we should call that 
>> first and then, if it still not resolved, try to decode the instruction.
>>
>> With that in place, you are avoiding the issue in try_fwd_ioserv().
>>
>> Can you please coordinate with Stefano?
> 
> Can you let me know which suggestion Julien is referring here ?
> 
> [1] does not point to a valid url.

This is a message-id. They are unique, so you can easily find the 
message on public archives (e.g. lore.kernel.org) or in your inbox.

I tend to use lore.kernel.org for the archives. The URL looks like:

https://lore.kernel.org/<ml>/<message-id>

In your case, <ml> would be xen-devel (they also archives may other MLs) 
and the <message-id> would be the one I put in [1].

The message-id can be really useful if you use it in combination of 
tools like b4 [1]. With a single ID, it allows you to pull a series, 
fetch tags and then you can apply with 'git am'.

Cheers,

[1] 
https://people.kernel.org/monsieuricon/introducing-b4-and-patch-attestation

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Feb 01 21:19:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 01 Feb 2022 21:19:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.263773.456621 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nF0YH-0008PJ-09; Tue, 01 Feb 2022 21:19:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 263773.456621; Tue, 01 Feb 2022 21:19:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nF0YG-0008PC-TE; Tue, 01 Feb 2022 21:19:00 +0000
Received: by outflank-mailman (input) for mailman id 263773;
 Tue, 01 Feb 2022 21:18:59 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nF0YF-0008P2-KI; Tue, 01 Feb 2022 21:18:59 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nF0YF-0004bf-IS; Tue, 01 Feb 2022 21:18:59 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nF0YF-0007ZY-5G; Tue, 01 Feb 2022 21:18:59 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nF0YF-0000cz-4d; Tue, 01 Feb 2022 21:18:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Vdidew0LvqA3l5MrtpDLXTpZ+56XNFYAqmug5QeW89U=; b=6HOQpnzo5v2gRN1l1PVJiiqIDU
	sKR3CKTp7ktEaQw7cGDNFeINUWpnPcLM/wnZa72G0UmyCeMtZx1UZgB8IZtwuR53LAnQoo7Xh4y3S
	AWN5KCPseMm800wr6eiifvfi6oAYORvXRnIz+/EOFUPrYX49KrSDXoFtP5CQLUCQmMvA=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167977-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 167977: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=9ce3ef20b4f085a7dc8ee41b0fec6fdeced3773e
X-Osstest-Versions-That:
    xen=a7e7c7260cde78a148810db5320cbf39686c3e09
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 01 Feb 2022 21:18:59 +0000

flight 167977 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167977/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  9ce3ef20b4f085a7dc8ee41b0fec6fdeced3773e
baseline version:
 xen                  a7e7c7260cde78a148810db5320cbf39686c3e09

Last test of basis   167973  2022-02-01 14:01:49 Z    0 days
Testing same since   167977  2022-02-01 18:00:26 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   a7e7c7260c..9ce3ef20b4  9ce3ef20b4f085a7dc8ee41b0fec6fdeced3773e -> smoke


From xen-devel-bounces@lists.xenproject.org Tue Feb 01 23:37:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 01 Feb 2022 23:37:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.263784.456632 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nF2hw-0004Pr-NI; Tue, 01 Feb 2022 23:37:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 263784.456632; Tue, 01 Feb 2022 23:37:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nF2hw-0004Pk-KG; Tue, 01 Feb 2022 23:37:08 +0000
Received: by outflank-mailman (input) for mailman id 263784;
 Tue, 01 Feb 2022 23:37:07 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nF2hv-0004Pa-Bk; Tue, 01 Feb 2022 23:37:07 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nF2hv-0006vU-7r; Tue, 01 Feb 2022 23:37:07 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nF2hu-0005bm-PQ; Tue, 01 Feb 2022 23:37:06 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nF2hu-0001j8-M9; Tue, 01 Feb 2022 23:37:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=tlCgDh6sQRGaOsDxj4ydA88gEZA3ep8kFTA9i39opjI=; b=EtKz7puKqI+7M4cuQg5+V4PlC+
	sRi9tidubBXzPv33LUePEayHebDD/cRT5qRQr7O3vvcDmPn5bRLj6DeGyKW3Jh32OurpVP8iGqtBf
	OPQLi7aDQbKOR0lmYpDC7XKtglw9aWCGbw6NtSP1HpNJyU8N1vNyxzoj9cZ3iVPrfyt4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167974-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-5.4 test] 167974: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=2570bb2729c7cbcecf9a4abc1e740b02a722b6e6
X-Osstest-Versions-That:
    linux=7cdf2951f80d189e9a0a5b6836664ccc8bfb2e7e
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 01 Feb 2022 23:37:06 +0000

flight 167974 linux-5.4 real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167974/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167945
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167945
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 167945
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167945
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167945
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167945
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167945
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167945
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 167945
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167945
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167945
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167945
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 linux                2570bb2729c7cbcecf9a4abc1e740b02a722b6e6
baseline version:
 linux                7cdf2951f80d189e9a0a5b6836664ccc8bfb2e7e

Last test of basis   167945  2022-01-29 09:42:03 Z    3 days
Testing same since   167974  2022-02-01 16:40:36 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alan Stern <stern@rowland.harvard.edu>
  Amir Goldstein <amir73il@gmail.com>
  Anna Schumaker <Anna.Schumaker@Netapp.com>
  Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
  Badhri Jagan Sridharan <badhri@google.com>
  Bjorn Andersson <bjorn.andersson@linaro.org>
  Brian Gix <brian.gix@intel.com>
  Cameron Williams <cang1@live.co.uk>
  Catalin Marinas <catalin.marinas@arm.com>
  Christophe Leroy <christophe.leroy@csgroup.eu>
  Congyu Liu <liu3101@purdue.edu>
  D Scott Phillips <scott@os.amperecomputing.com>
  Daniel Starke <daniel.starke@siemens.com>
  daniel.starke@siemens.com <daniel.starke@siemens.com>
  David Howells <dhowells@redhat.com>
  David S. Miller <davem@davemloft.net>
  Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
  Eric Dumazet <edumazet@google.com>
  Erwan Le Ray <erwan.leray@foss.st.com>
  Florian Fainelli <f.fainelli@gmail.com>
  Florian Westphal <fw@strlen.de>
  Geert Uytterhoeven <geert@linux-m68k.org>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Guangbin Huang <huangguangbin2@huawei.com>
  Guangwu Zhang <guazhang@redhat.com>
  Guenter Roeck <linux@roeck-us.net>
  Gurucharan G <gurucharanx.g@intel.com>
  Hangyu Hua <hbh25y@gmail.com>
  Heikki Krogerus <heikki.krogerus@linux.intel.com>
  Ido Schimmel <idosch@nvidia.com>
  Jakub Kicinski <kuba@kernel.org>
  Jan Kara <jack@suse.cz>
  Jaroslaw Gawin <jaroslawx.gawin@intel.com>
  Jedrzej Jagielski <jedrzej.jagielski@intel.com>
  Jens Axboe <axboe@kernel.dk>
  Jianguo Wu <wujianguo@chinatelecom.cn>
  Joe Damato <jdamato@fastly.com>
  John Meneghini <jmeneghi@redhat.com>
  Jon Hunter <jonathanh@nvidia.com>
  José Expósito <jose.exposito89@gmail.com>
  Kiran Bhandare <kiranx.bhandare@intel.com>
  Konrad Jankowski <konrad0.jankowski@intel.com>
  Linux Kernel Functional Testing <lkft@linaro.org>
  Lucas Stach <l.stach@pengutronix.de>
  Maksym Yaremchuk <maksymy@nvidia.com>
  Marc Dionne <marc.dionne@auristor.com>
  Marc Kleine-Budde <mkl@pengutronix.de>
  Marcel Holtmann <marcel@holtmann.org>
  Marek Behún <kabel@kernel.org>
  Martin K. Petersen <martin.petersen@oracle.com>
  Mateusz Palczewski <mateusz.palczewski@intel.com>
  Matthias Kaehlcke <mka@chromium.org>
  Maurizio Lombardi <mlombard@redhat.com>
  Miaoqian Lin <linmq006@gmail.com>
  Michael Ellerman <mpe@ellerman.id.au>
  Miquel Raynal <miquel.raynal@bootlin.com>
  OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
  Pablo Neira Ayuso <pablo@netfilter.org>
  Pavankumar Kondeti <quic_pkondeti@quicinc.com>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Robert Hancock <robert.hancock@calian.com>
  Sasha Levin <sashal@kernel.org>
  Shuah Khan <skhan@linuxfoundation.org>
  Sing-Han Chen <singhanc@nvidia.com>
  Slawomir Laba <slawomirx.laba@intel.com>
  Steffen Maier <maier@linux.ibm.com>
  Steven Rostedt (Google) <rostedt@goodmis.org>
  Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
  Sujit Kautkar <sujitka@chromium.org>
  Sukadev Bhattiprolu <sukadev@linux.ibm.com>
  Sylwester Dziedziuch <sylwesterx.dziedziuch@intel.com>
  Tom Zanussi <zanussi@kernel.org>
  Tony Nguyen <anthony.l.nguyen@intel.com>
  Trond Myklebust <trond.myklebust@hammerspace.com>
  Valentin Caron <valentin.caron@foss.st.com>
  Vasily Gorbik <gor@linux.ibm.com>
  Wayne Chang <waynec@nvidia.com>
  Xianting Tian <xianting.tian@linux.alibaba.com>
  Xiaoke Wang <xkernel.wang@foxmail.com>
  Xin Long <lucien.xin@gmail.com>
  Yufeng Mo <moyufeng@huawei.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   7cdf2951f80d..2570bb2729c7  2570bb2729c7cbcecf9a4abc1e740b02a722b6e6 -> tested/linux-5.4


From xen-devel-bounces@lists.xenproject.org Wed Feb 02 02:43:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 02:43:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.263797.456643 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nF5cG-0001Uy-2W; Wed, 02 Feb 2022 02:43:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 263797.456643; Wed, 02 Feb 2022 02:43:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nF5cF-0001Uq-TB; Wed, 02 Feb 2022 02:43:27 +0000
Received: by outflank-mailman (input) for mailman id 263797;
 Wed, 02 Feb 2022 02:43:26 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nF5cE-0001Ug-PM; Wed, 02 Feb 2022 02:43:26 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nF5cE-0006VO-Nf; Wed, 02 Feb 2022 02:43:26 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nF5cD-0007K1-S4; Wed, 02 Feb 2022 02:43:26 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nF5cD-0001Un-Pg; Wed, 02 Feb 2022 02:43:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Nd0rbmG2iB42xgSREHi30bvdKLcj/AsQJ4NMMl7eayw=; b=45Tb6BsOGCsrWPO8O1jWsIviG1
	LRvz3IBSaGUkA/e0dotYjG7yS+HtQ2Kx+Xk/BRup52M4kWXbCwx1E7K9N5NEGcvzR+ouyPqv49TrR
	lCymJcm7mThhUGjZkxZViVxCAyAWqNyVjRaekKrbkN7xGO+r0HXiF9+yUuaslPjfeMOo=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167976-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167976: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=5b3c682d91bd699a3144d36258565ccaa2036db7
X-Osstest-Versions-That:
    ovmf=103fa647d159e3d76be2634d2653c2d215dd0d46
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 02 Feb 2022 02:43:25 +0000

flight 167976 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167976/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 5b3c682d91bd699a3144d36258565ccaa2036db7
baseline version:
 ovmf                 103fa647d159e3d76be2634d2653c2d215dd0d46

Last test of basis   167956  2022-01-30 11:13:00 Z    2 days
Testing same since   167976  2022-02-01 17:41:44 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Laszlo Ersek <lersek@redhat.com>
  Pierre Gondois <Pierre.Gondois@arm.com>
  Sami Mujawar <sami.mujawar@arm.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   103fa647d1..5b3c682d91  5b3c682d91bd699a3144d36258565ccaa2036db7 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Wed Feb 02 02:55:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 02:55:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.263808.456654 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nF5oG-0002yd-5X; Wed, 02 Feb 2022 02:55:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 263808.456654; Wed, 02 Feb 2022 02:55:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nF5oG-0002yW-2G; Wed, 02 Feb 2022 02:55:52 +0000
Received: by outflank-mailman (input) for mailman id 263808;
 Wed, 02 Feb 2022 02:55:50 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nF5oE-0002yM-5c; Wed, 02 Feb 2022 02:55:50 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nF5oE-0006iJ-3p; Wed, 02 Feb 2022 02:55:50 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nF5oD-0007oW-HW; Wed, 02 Feb 2022 02:55:49 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nF5oD-0008Ql-H7; Wed, 02 Feb 2022 02:55:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=VgDVOs73alEHFgXkhSbFNO6rWRNWByZZERGXjIRjRLc=; b=2m4ib08L+Wi/Q1Ood+uVpJiwA1
	XeW0ppyNp+1peoIeq0cCpnE0TCeIqrdkzyCgS1oe5Lz5P31Sr7PiKCIxX55d5DHha+bvqD3bQ6t5+
	t2Sa01zlvDYXdT+CO0k8J/4A+IBwffvwju7U8rEvkqDOpD4MTv+4xvVEd2upyGGxHHXg=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167975-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 167975: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=5cbe64110dbe27f82d30552001acdc5eeaade11c
X-Osstest-Versions-That:
    qemuu=804b30d25f8d70dc2dea951883ea92235274a50c
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 02 Feb 2022 02:55:49 +0000

flight 167975 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167975/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167968
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167968
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167968
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167968
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167968
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167968
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167968
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167968
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                5cbe64110dbe27f82d30552001acdc5eeaade11c
baseline version:
 qemuu                804b30d25f8d70dc2dea951883ea92235274a50c

Last test of basis   167968  2022-01-31 19:38:15 Z    1 days
Testing same since   167975  2022-02-01 17:07:09 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Kyle Evans <kevans@freebsd.org>
  Peter Maydell <peter.maydell@linaro.org>
  Stacey Son <sson@FreeBSD.org>
  Warner Losh <imp@bsdimp.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   804b30d25f..5cbe64110d  5cbe64110dbe27f82d30552001acdc5eeaade11c -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Wed Feb 02 06:45:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 06:45:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.263820.456664 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nF9Nx-0007Pf-QH; Wed, 02 Feb 2022 06:44:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 263820.456664; Wed, 02 Feb 2022 06:44:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nF9Nx-0007PY-NB; Wed, 02 Feb 2022 06:44:57 +0000
Received: by outflank-mailman (input) for mailman id 263820;
 Wed, 02 Feb 2022 06:44:56 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1p3Q=SR=epam.com=prvs=40324c57ab=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nF9Nw-0007PS-6s
 for xen-devel@lists.xenproject.org; Wed, 02 Feb 2022 06:44:56 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9f3804e1-83f3-11ec-8f75-fffcc8bd4f1a;
 Wed, 02 Feb 2022 07:44:52 +0100 (CET)
Received: from pps.filterd (m0174680.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 2126hGgZ014335;
 Wed, 2 Feb 2022 06:44:46 GMT
Received: from eur05-db8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2106.outbound.protection.outlook.com [104.47.17.106])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3dymxc002d-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 02 Feb 2022 06:44:45 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM0PR03MB4596.eurprd03.prod.outlook.com (2603:10a6:208:c2::25)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.22; Wed, 2 Feb
 2022 06:44:42 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6%3]) with mapi id 15.20.4951.012; Wed, 2 Feb 2022
 06:44:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9f3804e1-83f3-11ec-8f75-fffcc8bd4f1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=VlUmozGU3GB363ea5P7zmZP2UwPdV8itaGAgu8JMiChP9qS4f6hqcwS49OQ0BpI9+uR8xQzbs+6aBu2W+JqNQnMlXblDmdO/2UyCEe5kxh+SBftjxbvqefoloWDQVESaclmBxWCXl+AiNm9NxfigN28f3UpAXAm8T9GZT3anZ1bciOniFJX5TeJK9sy26OG4rY2qZCmeFDlf+Je5pSDb8Bc+724cI859y04aIYZ57Z9rcbw7HpoVDha5qWXsHhuYj8MdV+ucfQS6AjC73xPP+Wz0aiS+ZJTlmw5s/HELQWNzodiRMi1ZIaRdfHNbgeb8EtdTmSE07GF2eXjCM+NTMQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=UF8EgjwalmJNNsL4ipjrYzCtnM8lp4EIHaATluSJzJA=;
 b=EMd1S0Fudn/WA4ySrV6XYGaWG7WzrMxGaXTZxFU2Yl1SiogT7H3g//sJNikwmTaSaiQsFy1wts1W/N/SQrHd1CtNH8NTVD8DAGUEPKXFvcUma4IFS0R7WxOJud4pG5kgFBki+3fhwedU51P8yLwR0ujDHpohTGrZZ2KVgXAQ10JQkgDlBMWgAzAr1cMHJnVDj5YkYe+LCSSopFgT34hoiqUwSFhzpj1KCLjSO4RFEgMNaP2vGajOZAOl7hWp4Lti3mF0Iv8X1iAHn5N6xr7FrIzciU9EnxgcqRtjsuEJMM5bLEFklktR34WiZgDflaX3vpRiOZo5cNRxTGUHn+Yn8A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=UF8EgjwalmJNNsL4ipjrYzCtnM8lp4EIHaATluSJzJA=;
 b=mn+ME2Ne3sPENp0N+n46AzOUkwLK8a5bE09MD1IwLfLT5mB+awHtN2CK1ldZPcm+acZBqWmxqgygnFktkf5jSKl13dabfP6mkP/HgGFSBSv98nVZ1+vEwcpMkX/BUg42uA2yxMpdC/GAdKlcPAhcvBi4xsSj1tHzE84fQQaNMruRGxV8ktvZf1YuacqHjAEe2pPW2P1mH0G7Ky0aIb3uXTUZOKvafEgwNGf/z1kPsJ+mnp0wpswMNfdavc+q/3SwUd38iJ9YkmHO2dKMrce9ykjgnRzDrfUS1qNIMC5ORwjt2ARdGg9T3BW+td4J11RAM64EvPNFGHiiBSDgzkza0g==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "jbeulich@suse.com" <jbeulich@suse.com>,
        "andrew.cooper3@citrix.com"
	<andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com"
	<george.dunlap@citrix.com>,
        "paul@xen.org" <paul@xen.org>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>,
        Rahul Singh <rahul.singh@arm.com>,
        Oleksandr
 Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v5 07/14] vpci/header: handle p2m range sets per BAR
Thread-Topic: [PATCH v5 07/14] vpci/header: handle p2m range sets per BAR
Thread-Index: AQHX4ewHO5mM8SE93ki3ObXvstqjIqxfypkAgCByRIA=
Date: Wed, 2 Feb 2022 06:44:41 +0000
Message-ID: <9c8ea4bc-feeb-dfa0-9265-83ff724b216d@epam.com>
References: <20211125110251.2877218-1-andr2000@gmail.com>
 <20211125110251.2877218-8-andr2000@gmail.com> <Yd7wjP8WLWQxzLbq@Air-de-Roger>
In-Reply-To: <Yd7wjP8WLWQxzLbq@Air-de-Roger>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 2ca9b7dd-b208-4a40-fb41-08d9e6177ddb
x-ms-traffictypediagnostic: AM0PR03MB4596:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM0PR03MB45961DFC782CE7C13BFE39F5E7279@AM0PR03MB4596.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:7219;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 fNUF+Qw2X4MuFyftsmzb7clvHpv9TWlThFsjK4HQuVsr8uar+73lY6o8dUPaX5C5LsQ/STUNRNg+hntCAHFSlTMS4HB8yjIaZ/cpSxoP8C7PZiHZClPdyPEEjoPx0/DMPoX1IUjUNb0tAkOWfV6cZJUVk0GGjvROPSnpFygc6w1T8xhgfdTusElp+wBJ81gBwltZiUt4Lzbkcj8WbbZowLEnlbPP+GM38zYQ39drOICDfzlP/CNZiiAqaczqWArZy0roA1tDzoTEI+PBVOCyupFId0pMnWvQRuN17NgmgkxGoooK46iYbBjcblIhCiD3bUc8CcDBlAZSlfchY0MJjixR1bbxjCIS0yJQa1lgIHj2mBWDgH3QVvn3eDM2g1H5jfERLcYBW3gb3P+6tHICwezMXeu0fBRyuHfIBtMDrFsBlKvBsXFXTYK+YWDa1vZA1kJ2fbH7yVPKtH4W7wd241rFhxrjt/PPTZZKPYJGOUlJ75S7yEoeiMj0rhuCJox6eQu56JKfwTFrScGJ6KZJgiJvg+9FbuVKm1UN0/0RjyllYAQOfvabB5+dw9i2A303O/t8sNc3meisck6CXd+pD4/rk9R1FVIiUsoZ+/3vFiOwZjHWl0L5dnQWQiD/xDZjtyaNKgSGGxLZqknt+L3uqLzqDTVPcc37Cfa8sNfEV1iQOc3JQDMBivLLBOkjTgTTCK3RX38ZCOLZgxL9vDp8OBjPxL9UfS8Alot+iQ6db2mhzgO0mCywRXJR7DkHacsZ
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(4326008)(31686004)(66446008)(83380400001)(7416002)(91956017)(5660300002)(36756003)(64756008)(66556008)(76116006)(66946007)(6916009)(66476007)(316002)(107886003)(8936002)(86362001)(30864003)(54906003)(8676002)(71200400001)(2616005)(186003)(26005)(508600001)(122000001)(31696002)(38070700005)(38100700002)(2906002)(6486002)(6506007)(6512007)(53546011)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?dmF5YWFGNkFpVGIyWDdoWGFzUEhrS0ExNEdGanRsT3hLT0RQNnNsdEtqNXNS?=
 =?utf-8?B?UTl2aE5YTnh5ZVdaSkY5UGFKVUVKZy83a3A2YjJ1NFBrODZuakNyUDBKM1Vn?=
 =?utf-8?B?T0t0bU4wN0pEb21PWUVDRVVybXBNb29wWjBMNUhzeXZZRFY3azNUaUx2WXRw?=
 =?utf-8?B?R0w5QWd2QmU3ZXZOb3dmUlBDNFdZZE9ZQjY0QWZ6cmVBRUhRRnJMS24xWlBq?=
 =?utf-8?B?Uk0wMEtVWWVDTmw3ck5DNlEwK1JIT0grU2tSRkh2Q0Nnd2lwTTlCalZqaWhO?=
 =?utf-8?B?MmY4OTRja0N5VWpmRXpnTm5CZGRFTU5tY24rV091Q3BSaTBubDMyaU9TZ2R1?=
 =?utf-8?B?SWFXSk1yNWJodUFpNGJHdDQ2bjVCU2lXbC9HN2ZydzgvTHdkUldBTlhYaGVI?=
 =?utf-8?B?Z29LMHZQSWRTV1l6QnFrNmZjclRBNUxqNjFCelZ0VklKZ3Bhei9Ea29tMmRa?=
 =?utf-8?B?N3oyRi85bjRma3dkU2t4bVhoNStzVjNDck9LT1F4emxNRitJTEp5RWF0NnM4?=
 =?utf-8?B?elBIdWZjL2poM2k4bDNlVkQyZlFYMG0rQW15T002L0dVQTRZbUR4eEMrMHZ0?=
 =?utf-8?B?dXBZU2tKOVhaT2gwemhFRmN3MlhSTE55ZkZRRjI3OWxZZ0s1WEEyYUwvTkdi?=
 =?utf-8?B?RHA3M2laTk9MT1J2TnlabUpzcXd2eis1Vy9rY3lMS1gxTnY5WVk1UlRTbGln?=
 =?utf-8?B?RUdTbGhtYUpqZDMxckU4a2NabHo4UGRteENianRUeis1RzhTdkk1QjlGTHc1?=
 =?utf-8?B?dUdHRE5HSDFSczVjSEV0QzEyZVFkZElRQ1Mrc3N5VjVZUmZGdmxYN3FYdWFm?=
 =?utf-8?B?T0d2ZFlwMC9HRWlySjNaTDUyWjlmNXhFUE1YakxiaXVwSGNIdkJDZkV4bEtH?=
 =?utf-8?B?SGxCZnZCVUZXZnZRSnQ1bGorWjNZQVBuVmJWK0lXZVdsbnJIb0JYeFNjMmZk?=
 =?utf-8?B?dnhDVnBZSFk1Z1RFU3RPMWMvUGVIRWsyRG40ZlNINEtnV0pMd2gzbmZPNytv?=
 =?utf-8?B?cUg2LzQ5dm9DbVUxQmxSMmJPTVJxYnpvbWNLck9qQlBsR0VQNzhQYWhESEl5?=
 =?utf-8?B?TjJoS3NJOVNlbjg4TkdzVzZLYkZoakIyaUs5S05nSHM5OFE1TVJwa1VNMHlE?=
 =?utf-8?B?VVRMdStveW9FK0trTklZakdqbjBNRFRqdHl3cUpFMFB3QVp6UVpTS2ZQNDFJ?=
 =?utf-8?B?SVc3YVlTcFpuaERVVldERlFFRkJ5TXY4M3REWEY3dmY1TUZxc0REc1NZZGdB?=
 =?utf-8?B?ZTlKMGpBUy84NTJ6M1pTdExyallPd1gvc3JSU2FwREtKMDhiN3JHU05xK1Zu?=
 =?utf-8?B?N0hmYWpJYitQTDkvZyt6cWpPSEl2RmFkZiticy80OWlZY0JvcmVqS0pSZXJ4?=
 =?utf-8?B?eTlRNnpFRU5XQy9TYkdDZ0ZuWVlvcWh4K05jdXVCbnFvQ0FIZkU3Vzc3Y3VE?=
 =?utf-8?B?R1BTYkJ2MWk4OTkzRkdURU5rY3F0N1BUYkd4eXFFTEJ4Z0djQm1ZRkZyLzBO?=
 =?utf-8?B?eUYyQW96UDhIYTBDeFFsbXNCMWc1ZXZYZ0lFTHlKZENlQ0NEdlR1c0ZiWWFJ?=
 =?utf-8?B?b3R0ZXZZaEgvem1vcVpUUlRCR0NmNFJ0RWhLUmFaL0lxK3FiSW5BZFJyb3Iv?=
 =?utf-8?B?NEpoemVRMXZETTRzaGNES1RQZVZqTjE3UDBHMnF1QkY3TUFmdFVPVDkzNEJB?=
 =?utf-8?B?RkZONXFMbmM5M3lJak9IZSt4SWVzdGo3V2N2TkdyKzlRN25VZmRqKzJwWDly?=
 =?utf-8?B?T04wd0Y2MGxnMlJ2bGlMajN3bnJrTitrT0NmTndxWmJiM2FIR3E5ZSs1T2JZ?=
 =?utf-8?B?MCtLMjJ1WmVtY1kwdVlta2RuSWtreTNqOGdEbm1XRlk1N0lyYjdoeXNML2Q2?=
 =?utf-8?B?eUh3aDUxTFhZeDBnMTRjd2xlZnMxczRoOEpVa3RoM0w4QWM1OEsrQk9FZDZL?=
 =?utf-8?B?dFN0MVFSZHlPdUdyenl3Z3c0MWd4NDNEaDIvT0hicUE0NnVRd01POGx2U0hy?=
 =?utf-8?B?OGU2aEFidTJlWGZkQ2FvRDV0MC9KN3lTbGVFb1J5YVduVTNoTTR5ZzN6S3dq?=
 =?utf-8?B?bDEyeTFzakdtb1BvMTc5cC9sY2o5K09kWS9xQmFjNzhTcGtwajdSTVNEd3g3?=
 =?utf-8?B?MHEvckhqZU9jVUliN2JNZ1dLUmZvQjNQcGZZRmhVTm1LTzk1eFlDYmg2Vk9m?=
 =?utf-8?B?YmlnaW12UkJXU0lITzlFTEVGOE9laVphWmZhODd3RGZkWjZGN0RSUnFxY1ow?=
 =?utf-8?B?amZyeWhVejRMUnhONnpjZnoyOWRJUXY2NmM0ckhvWThJaVNvdXF4UFEvQS82?=
 =?utf-8?B?SU9DUnVLcWhUV1EzQkhybCs5bWF4WmVyMU91ZkhNZkZUVzJXRVF5QT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <A72026AAA9C5914D9393F1143E958245@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2ca9b7dd-b208-4a40-fb41-08d9e6177ddb
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Feb 2022 06:44:41.8747
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: skqPYZfKPG8UCb2/0REoIgzSf7o1jFXQh2/+GNNxrmFSZQ6DJMB7amLvGk3pGoS1zt5+4lSMlSeZ7urCu+7GTXVurSr8exgSdizsqZ157IwKbk8jb2YuqpcyZW2Pr3iq
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB4596
X-Proofpoint-GUID: Wvko_SqMJwwi7yApPlz7lwot1IXs1Iij
X-Proofpoint-ORIG-GUID: Wvko_SqMJwwi7yApPlz7lwot1IXs1Iij
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-02_02,2022-02-01_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015
 lowpriorityscore=0 suspectscore=0 malwarescore=0 impostorscore=0
 priorityscore=1501 bulkscore=0 mlxlogscore=999 spamscore=0 mlxscore=0
 adultscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202020033

SGksIFJvZ2VyIQ0KDQpPbiAxMi4wMS4yMiAxNzoxNSwgUm9nZXIgUGF1IE1vbm7DqSB3cm90ZToN
Cj4gT24gVGh1LCBOb3YgMjUsIDIwMjEgYXQgMDE6MDI6NDRQTSArMDIwMCwgT2xla3NhbmRyIEFu
ZHJ1c2hjaGVua28gd3JvdGU6DQo+PiBGcm9tOiBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbzxvbGVr
c2FuZHJfYW5kcnVzaGNoZW5rb0BlcGFtLmNvbT4NCj4+DQo+PiBJbnN0ZWFkIG9mIGhhbmRsaW5n
IGEgc2luZ2xlIHJhbmdlIHNldCwgdGhhdCBjb250YWlucyBhbGwgdGhlIG1lbW9yeQ0KPj4gcmVn
aW9ucyBvZiBhbGwgdGhlIEJBUnMgYW5kIFJPTSwgaGF2ZSB0aGVtIHBlciBCQVIuDQo+PiBBcyB0
aGUgcmFuZ2Ugc2V0cyBhcmUgbm93IGNyZWF0ZWQgd2hlbiBhIFBDSSBkZXZpY2UgaXMgYWRkZWQg
YW5kIGRlc3Ryb3llZA0KPj4gd2hlbiBpdCBpcyByZW1vdmVkIHNvIG1ha2UgdGhlbSBuYW1lZCBh
bmQgYWNjb3VudGVkLg0KPj4NCj4+IE5vdGUgdGhhdCByYW5nZXNldHMgd2VyZSBjaG9zZW4gaGVy
ZSBkZXNwaXRlIHRoZXJlIGJlaW5nIG9ubHkgdXAgdG8NCj4+IDMgc2VwYXJhdGUgcmFuZ2VzIGlu
IGVhY2ggc2V0ICh0eXBpY2FsbHkganVzdCAxKS4gQnV0IHJhbmdlc2V0IHBlciBCQVINCj4+IHdh
cyBjaG9zZW4gZm9yIHRoZSBlYXNlIG9mIGltcGxlbWVudGF0aW9uIGFuZCBleGlzdGluZyBjb2Rl
IHJlLXVzYWJpbGl0eS4NCj4+DQo+PiBUaGlzIGlzIGluIHByZXBhcmF0aW9uIG9mIG1ha2luZyBu
b24taWRlbnRpdHkgbWFwcGluZ3MgaW4gcDJtIGZvciB0aGUNCj4+IE1NSU9zL1JPTS4NCj4gSSB0
aGluayB3ZSBkb24ndCB3YW50IHRvIHN1cHBvcnQgUk9NIGZvciBndWVzdHMgKGF0IGxlYXN0IGlu
aXRpYWxseSksDQo+IHNvIG5vIG5lZWQgdG8gbWVudGlvbiBpdCBoZXJlLg0KV2lsbCBhZGQNCj4+
IFNpZ25lZC1vZmYtYnk6IE9sZWtzYW5kciBBbmRydXNoY2hlbmtvPG9sZWtzYW5kcl9hbmRydXNo
Y2hlbmtvQGVwYW0uY29tPg0KPj4NCj4+IC0tLQ0KPj4gU2luY2UgdjQ6DQo+PiAtIHVzZSBuYW1l
ZCByYW5nZSBzZXRzIGZvciBCQVJzIChKYW4pDQo+PiAtIGNoYW5nZXMgcmVxdWlyZWQgYnkgdGhl
IG5ldyBsb2NraW5nIHNjaGVtZQ0KPj4gLSB1cGRhdGVkIGNvbW1pdCBtZXNzYWdlIChKYW4pDQo+
PiBTaW5jZSB2MzoNCj4+IC0gcmUtd29yayB2cGNpX2NhbmNlbF9wZW5kaW5nIGFjY29yZGluZ2x5
IHRvIHRoZSBwZXItQkFSIGhhbmRsaW5nDQo+PiAtIHMvbnVtX21lbV9yYW5nZXMvbWFwX3BlbmRp
bmcgYW5kIHMvdWludDhfdC9ib29sDQo+PiAtIEFTU0VSVChiYXItPm1lbSkgaW4gbW9kaWZ5X2Jh
cnMNCj4+IC0gY3JlYXRlIGFuZCBkZXN0cm95IHRoZSByYW5nZXNldHMgb24gYWRkL3JlbW92ZQ0K
Pj4gLS0tDQo+PiAgIHhlbi9kcml2ZXJzL3ZwY2kvaGVhZGVyLmMgfCAxOTAgKysrKysrKysrKysr
KysrKysrKysrKysrKysrLS0tLS0tLS0tLS0NCj4+ICAgeGVuL2RyaXZlcnMvdnBjaS92cGNpLmMg
ICB8ICAzMCArKysrKy0NCj4+ICAgeGVuL2luY2x1ZGUveGVuL3ZwY2kuaCAgICB8ICAgMyArLQ0K
Pj4gICAzIGZpbGVzIGNoYW5nZWQsIDE2NiBpbnNlcnRpb25zKCspLCA1NyBkZWxldGlvbnMoLSkN
Cj4+DQo+PiBkaWZmIC0tZ2l0IGEveGVuL2RyaXZlcnMvdnBjaS9oZWFkZXIuYyBiL3hlbi9kcml2
ZXJzL3ZwY2kvaGVhZGVyLmMNCj4+IGluZGV4IDg4ODBkMzRlYmY4ZS4uY2M0OWFhNjg4ODZmIDEw
MDY0NA0KPj4gLS0tIGEveGVuL2RyaXZlcnMvdnBjaS9oZWFkZXIuYw0KPj4gKysrIGIveGVuL2Ry
aXZlcnMvdnBjaS9oZWFkZXIuYw0KPj4gQEAgLTEzNyw0NSArMTM3LDg2IEBAIGJvb2wgdnBjaV9w
cm9jZXNzX3BlbmRpbmcoc3RydWN0IHZjcHUgKnYpDQo+PiAgICAgICAgICAgcmV0dXJuIGZhbHNl
Ow0KPj4gICANCj4+ICAgICAgIHNwaW5fbG9jaygmcGRldi0+dnBjaV9sb2NrKTsNCj4+IC0gICAg
aWYgKCAhcGRldi0+dnBjaV9jYW5jZWxfcGVuZGluZyAmJiB2LT52cGNpLm1lbSApDQo+PiArICAg
IGlmICggIXBkZXYtPnZwY2kgKQ0KPj4gKyAgICB7DQo+PiArICAgICAgICBzcGluX3VubG9jaygm
cGRldi0+dnBjaV9sb2NrKTsNCj4+ICsgICAgICAgIHJldHVybiBmYWxzZTsNCj4+ICsgICAgfQ0K
Pj4gKw0KPj4gKyAgICBpZiAoICFwZGV2LT52cGNpX2NhbmNlbF9wZW5kaW5nICYmIHYtPnZwY2ku
bWFwX3BlbmRpbmcgKQ0KPj4gICAgICAgew0KPj4gICAgICAgICAgIHN0cnVjdCBtYXBfZGF0YSBk
YXRhID0gew0KPj4gICAgICAgICAgICAgICAuZCA9IHYtPmRvbWFpbiwNCj4+ICAgICAgICAgICAg
ICAgLm1hcCA9IHYtPnZwY2kuY21kICYgUENJX0NPTU1BTkRfTUVNT1JZLA0KPj4gICAgICAgICAg
IH07DQo+PiAtICAgICAgICBpbnQgcmMgPSByYW5nZXNldF9jb25zdW1lX3Jhbmdlcyh2LT52cGNp
Lm1lbSwgbWFwX3JhbmdlLCAmZGF0YSk7DQo+PiArICAgICAgICBzdHJ1Y3QgdnBjaV9oZWFkZXIg
KmhlYWRlciA9ICZwZGV2LT52cGNpLT5oZWFkZXI7DQo+PiArICAgICAgICB1bnNpZ25lZCBpbnQg
aTsNCj4+ICAgDQo+PiAtICAgICAgICBpZiAoIHJjID09IC1FUkVTVEFSVCApDQo+PiArICAgICAg
ICBmb3IgKCBpID0gMDsgaSA8IEFSUkFZX1NJWkUoaGVhZGVyLT5iYXJzKTsgaSsrICkNCj4+ICAg
ICAgICAgICB7DQo+PiAtICAgICAgICAgICAgc3Bpbl91bmxvY2soJnBkZXYtPnZwY2lfbG9jayk7
DQo+PiAtICAgICAgICAgICAgcmV0dXJuIHRydWU7DQo+PiAtICAgICAgICB9DQo+PiArICAgICAg
ICAgICAgc3RydWN0IHZwY2lfYmFyICpiYXIgPSAmaGVhZGVyLT5iYXJzW2ldOw0KPj4gKyAgICAg
ICAgICAgIGludCByYzsNCj4+ICsNCj4gWW91IHNob3VsZCBjaGVjayBiYXItPm1lbSAhPSBOVUxM
IGhlcmUsIHRoZXJlJ3Mgbm8gbmVlZCB0byBhbGxvY2F0ZSBhDQo+IHJhbmdlc2V0IGZvciBub24t
bWFwcGFibGUgQkFScy4NCkFuc3dlcmVkIGJ5IEphbiBhbHJlYWR5OiBubyBuZWVkIGFzIHJhbmdl
c2V0X2lzX2VtcHR5IGFscmVhZHkgaGFuZGxlcw0KTlVMTCBwb2ludGVyDQo+PiArICAgICAgICAg
ICAgaWYgKCByYW5nZXNldF9pc19lbXB0eShiYXItPm1lbSkgKQ0KPj4gKyAgICAgICAgICAgICAg
ICBjb250aW51ZTsNCj4+ICsNCj4+ICsgICAgICAgICAgICByYyA9IHJhbmdlc2V0X2NvbnN1bWVf
cmFuZ2VzKGJhci0+bWVtLCBtYXBfcmFuZ2UsICZkYXRhKTsNCj4+ICsNCj4+ICsgICAgICAgICAg
ICBpZiAoIHJjID09IC1FUkVTVEFSVCApDQo+PiArICAgICAgICAgICAgew0KPj4gKyAgICAgICAg
ICAgICAgICBzcGluX3VubG9jaygmcGRldi0+dnBjaV9sb2NrKTsNCj4+ICsgICAgICAgICAgICAg
ICAgcmV0dXJuIHRydWU7DQo+PiArICAgICAgICAgICAgfQ0KPj4gICANCj4+IC0gICAgICAgIGlm
ICggcGRldi0+dnBjaSApDQo+PiAgICAgICAgICAgICAgIC8qIERpc2FibGUgbWVtb3J5IGRlY29k
aW5nIHVuY29uZGl0aW9uYWxseSBvbiBmYWlsdXJlLiAqLw0KPj4gLSAgICAgICAgICAgIG1vZGlm
eV9kZWNvZGluZyhwZGV2LA0KPj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICByYyA/IHYt
PnZwY2kuY21kICYgflBDSV9DT01NQU5EX01FTU9SWSA6IHYtPnZwY2kuY21kLA0KPj4gKyAgICAg
ICAgICAgIG1vZGlmeV9kZWNvZGluZyhwZGV2LCByYyA/IHYtPnZwY2kuY21kICYgflBDSV9DT01N
QU5EX01FTU9SWSA6IHYtPnZwY2kuY21kLA0KPiBUaGUgYWJvdmUgc2VlbXMgdG8gYmUgYW4gdW5y
ZWxhdGVkIGNoYW5nZSwgYW5kIGFsc28gZXhjZWVkcyB0aGUgbWF4DQo+IGxpbmUgbGVuZ3RoLg0K
U3VyZSwgd2lsbCB0cnkgdG8gZml0DQo+PiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAh
cmMgJiYgdi0+dnBjaS5yb21fb25seSk7DQo+PiAgIA0KPj4gLSAgICAgICAgaWYgKCByYyApDQo+
PiAtICAgICAgICB7DQo+PiAtICAgICAgICAgICAgLyoNCj4+IC0gICAgICAgICAgICAgKiBGSVhN
RTogaW4gY2FzZSBvZiBmYWlsdXJlIHJlbW92ZSB0aGUgZGV2aWNlIGZyb20gdGhlIGRvbWFpbi4N
Cj4+IC0gICAgICAgICAgICAgKiBOb3RlIHRoYXQgdGhlcmUgbWlnaHQgc3RpbGwgYmUgbGVmdG92
ZXIgbWFwcGluZ3MuIFdoaWxlIHRoaXMgaXMNCj4+IC0gICAgICAgICAgICAgKiBzYWZlIGZvciBE
b20wLCBmb3IgRG9tVXMgdGhlIGRvbWFpbiBuZWVkcyB0byBiZSBraWxsZWQgaW4gb3JkZXINCj4+
IC0gICAgICAgICAgICAgKiB0byBhdm9pZCBsZWFraW5nIHN0YWxlIHAybSBtYXBwaW5ncyBvbiBm
YWlsdXJlLg0KPj4gLSAgICAgICAgICAgICAqLw0KPj4gLSAgICAgICAgICAgIGlmICggaXNfaGFy
ZHdhcmVfZG9tYWluKHYtPmRvbWFpbikgKQ0KPj4gLSAgICAgICAgICAgICAgICB2cGNpX3JlbW92
ZV9kZXZpY2VfbG9ja2VkKHBkZXYpOw0KPj4gLSAgICAgICAgICAgIGVsc2UNCj4+IC0gICAgICAg
ICAgICAgICAgZG9tYWluX2NyYXNoKHYtPmRvbWFpbik7DQo+PiArICAgICAgICAgICAgaWYgKCBy
YyApDQo+PiArICAgICAgICAgICAgew0KPj4gKyAgICAgICAgICAgICAgICAvKg0KPj4gKyAgICAg
ICAgICAgICAgICAgKiBGSVhNRTogaW4gY2FzZSBvZiBmYWlsdXJlIHJlbW92ZSB0aGUgZGV2aWNl
IGZyb20gdGhlIGRvbWFpbi4NCj4+ICsgICAgICAgICAgICAgICAgICogTm90ZSB0aGF0IHRoZXJl
IG1pZ2h0IHN0aWxsIGJlIGxlZnRvdmVyIG1hcHBpbmdzLiBXaGlsZSB0aGlzIGlzDQo+PiArICAg
ICAgICAgICAgICAgICAqIHNhZmUgZm9yIERvbTAsIGZvciBEb21VcyB0aGUgZG9tYWluIG5lZWRz
IHRvIGJlIGtpbGxlZCBpbiBvcmRlcg0KPj4gKyAgICAgICAgICAgICAgICAgKiB0byBhdm9pZCBs
ZWFraW5nIHN0YWxlIHAybSBtYXBwaW5ncyBvbiBmYWlsdXJlLg0KPj4gKyAgICAgICAgICAgICAg
ICAgKi8NCj4+ICsgICAgICAgICAgICAgICAgaWYgKCBpc19oYXJkd2FyZV9kb21haW4odi0+ZG9t
YWluKSApDQo+PiArICAgICAgICAgICAgICAgICAgICB2cGNpX3JlbW92ZV9kZXZpY2VfbG9ja2Vk
KHBkZXYpOw0KPj4gKyAgICAgICAgICAgICAgICBlbHNlDQo+PiArICAgICAgICAgICAgICAgICAg
ICBkb21haW5fY3Jhc2godi0+ZG9tYWluKTsNCj4+ICsNCj4+ICsgICAgICAgICAgICAgICAgYnJl
YWs7DQo+PiArICAgICAgICAgICAgfQ0KPj4gICAgICAgICAgIH0NCj4+ICsNCj4+ICsgICAgICAg
IHYtPnZwY2kubWFwX3BlbmRpbmcgPSBmYWxzZTsNCj4+ICAgICAgIH0NCj4+ICAgICAgIHNwaW5f
dW5sb2NrKCZwZGV2LT52cGNpX2xvY2spOw0KPj4gICANCj4+ICAgICAgIHJldHVybiBmYWxzZTsN
Cj4+ICAgfQ0KPj4gICANCj4+ICtzdGF0aWMgdm9pZCB2cGNpX2Jhcl9yZW1vdmVfcmFuZ2VzKGNv
bnN0IHN0cnVjdCBwY2lfZGV2ICpwZGV2KQ0KPj4gK3sNCj4+ICsgICAgc3RydWN0IHZwY2lfaGVh
ZGVyICpoZWFkZXIgPSAmcGRldi0+dnBjaS0+aGVhZGVyOw0KPj4gKyAgICB1bnNpZ25lZCBpbnQg
aTsNCj4+ICsgICAgaW50IHJjOw0KPj4gKw0KPj4gKyAgICBmb3IgKCBpID0gMDsgaSA8IEFSUkFZ
X1NJWkUoaGVhZGVyLT5iYXJzKTsgaSsrICkNCj4+ICsgICAgew0KPj4gKyAgICAgICAgc3RydWN0
IHZwY2lfYmFyICpiYXIgPSAmaGVhZGVyLT5iYXJzW2ldOw0KPj4gKw0KPj4gKyAgICAgICAgaWYg
KCByYW5nZXNldF9pc19lbXB0eShiYXItPm1lbSkgKQ0KPj4gKyAgICAgICAgICAgIGNvbnRpbnVl
Ow0KPj4gKw0KPj4gKyAgICAgICAgcmMgPSByYW5nZXNldF9yZW1vdmVfcmFuZ2UoYmFyLT5tZW0s
IDAsIH4wVUxMKTsNCj4gTWlnaHQgYmUgaW50ZXJlc3RpbmcgdG8gaW50cm9kdWNlIGEgcmFuZ2Vz
ZXRfcmVzZXQgZnVuY3Rpb24gdGhhdA0KPiByZW1vdmVzIGFsbCByYW5nZXMuIFRoYXQgd291bGQg
bmV2ZXIgZmFpbCwgYW5kIHRodXMgdGhlcmUgd291bGQgYmUgbm8NCj4gbmVlZCB0byBjaGVjayBm
b3IgcmMuDQpXZWxsLCB0aGVyZSBpcyBhIHNpbmdsZSB1c2VyIG9mIHRoYXQgYXMgb2Ygbm93LCBz
byBub3Qgc3VyZSBpdCBpcyB3b3J0aCBpdCB5ZXQNCkFuZCBpZiB3ZSByZS1hbGxvY2F0ZSBwZGV2
LT52cGNpIHRoZW4gdGhlcmUgbWlnaHQgYmUgbm8gbmVlZCBmb3IgdGhpcw0KYXQgYWxsDQo+IEFs
c28gSSB0aGluayB0aGUgY3VycmVudCByYW5nZXNldF9yZW1vdmVfcmFuZ2Ugc2hvdWxkIG5ldmVy
IGZhaWwgd2hlbg0KPiByZW1vdmluZyBhbGwgcmFuZ2VzLCBhcyB0aGVyZSdzIG5vdGhpbmcgdG8g
YWxsb2NhdGUuDQpBZ3JlZQ0KPiAgIEhlbmNlIHlvdSBjYW4gYWRkDQo+IGFuIEFTU0VSVF9VTlJF
QUNIQUJMRSBiZWxvdy4NCg0KPj4gKyAgICAgICAgaWYgKCAhcmMgKQ0KPj4gKyAgICAgICAgICAg
IHByaW50ayhYRU5MT0dfRVJSDQo+PiArICAgICAgICAgICAgICAgICAgICIlcGQgJXBwIGZhaWxl
ZCB0byByZW1vdmUgcmFuZ2Ugc2V0IGZvciBCQVI6ICVkXG4iLA0KPj4gKyAgICAgICAgICAgICAg
ICAgICBwZGV2LT5kb21haW4sICZwZGV2LT5zYmRmLCByYyk7DQo+PiArICAgIH0NCj4+ICt9DQo+
PiArDQo+PiAgIHZvaWQgdnBjaV9jYW5jZWxfcGVuZGluZ19sb2NrZWQoc3RydWN0IHBjaV9kZXYg
KnBkZXYpDQo+PiAgIHsNCj4+ICAgICAgIHN0cnVjdCB2Y3B1ICp2Ow0KPj4gQEAgLTE4NSwyMyAr
MjI2LDMzIEBAIHZvaWQgdnBjaV9jYW5jZWxfcGVuZGluZ19sb2NrZWQoc3RydWN0IHBjaV9kZXYg
KnBkZXYpDQo+PiAgICAgICAvKiBDYW5jZWwgYW55IHBlbmRpbmcgd29yayBub3cgb24gYWxsIHZD
UFVzLiAqLw0KPj4gICAgICAgZm9yX2VhY2hfdmNwdSggcGRldi0+ZG9tYWluLCB2ICkNCj4+ICAg
ICAgIHsNCj4+IC0gICAgICAgIGlmICggdi0+dnBjaS5tZW0gJiYgKHYtPnZwY2kucGRldiA9PSBw
ZGV2KSApDQo+PiArICAgICAgICBpZiAoIHYtPnZwY2kubWFwX3BlbmRpbmcgJiYgKHYtPnZwY2ku
cGRldiA9PSBwZGV2KSApDQo+PiAgICAgICAgICAgew0KPj4gLSAgICAgICAgICAgIHJhbmdlc2V0
X2Rlc3Ryb3kodi0+dnBjaS5tZW0pOw0KPj4gLSAgICAgICAgICAgIHYtPnZwY2kubWVtID0gTlVM
TDsNCj4+ICsgICAgICAgICAgICB2cGNpX2Jhcl9yZW1vdmVfcmFuZ2VzKHBkZXYpOw0KPj4gKyAg
ICAgICAgICAgIHYtPnZwY2kubWFwX3BlbmRpbmcgPSBmYWxzZTsNCj4+ICAgICAgICAgICB9DQo+
PiAgICAgICB9DQo+PiAgIH0NCj4+ICAgDQo+PiAgIHN0YXRpYyBpbnQgX19pbml0IGFwcGx5X21h
cChzdHJ1Y3QgZG9tYWluICpkLCBjb25zdCBzdHJ1Y3QgcGNpX2RldiAqcGRldiwNCj4+IC0gICAg
ICAgICAgICAgICAgICAgICAgICAgICAgc3RydWN0IHJhbmdlc2V0ICptZW0sIHVpbnQxNl90IGNt
ZCkNCj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgdWludDE2X3QgY21kKQ0KPj4gICB7
DQo+PiAgICAgICBzdHJ1Y3QgbWFwX2RhdGEgZGF0YSA9IHsgLmQgPSBkLCAubWFwID0gdHJ1ZSB9
Ow0KPj4gLSAgICBpbnQgcmM7DQo+PiArICAgIHN0cnVjdCB2cGNpX2hlYWRlciAqaGVhZGVyID0g
JnBkZXYtPnZwY2ktPmhlYWRlcjsNCj4+ICsgICAgaW50IHJjID0gMDsNCj4+ICsgICAgdW5zaWdu
ZWQgaW50IGk7DQo+PiArDQo+PiArICAgIGZvciAoIGkgPSAwOyBpIDwgQVJSQVlfU0laRShoZWFk
ZXItPmJhcnMpOyBpKysgKQ0KPj4gKyAgICB7DQo+PiArICAgICAgICBzdHJ1Y3QgdnBjaV9iYXIg
KmJhciA9ICZoZWFkZXItPmJhcnNbaV07DQo+PiAgIA0KPj4gLSAgICB3aGlsZSAoIChyYyA9IHJh
bmdlc2V0X2NvbnN1bWVfcmFuZ2VzKG1lbSwgbWFwX3JhbmdlLCAmZGF0YSkpID09IC1FUkVTVEFS
VCApDQo+PiAtICAgICAgICBwcm9jZXNzX3BlbmRpbmdfc29mdGlycXMoKTsNCj4+IC0gICAgcmFu
Z2VzZXRfZGVzdHJveShtZW0pOw0KPj4gKyAgICAgICAgaWYgKCByYW5nZXNldF9pc19lbXB0eShi
YXItPm1lbSkgKQ0KPj4gKyAgICAgICAgICAgIGNvbnRpbnVlOw0KPj4gKw0KPj4gKyAgICAgICAg
d2hpbGUgKCAocmMgPSByYW5nZXNldF9jb25zdW1lX3JhbmdlcyhiYXItPm1lbSwgbWFwX3Jhbmdl
LA0KPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAmZGF0
YSkpID09IC1FUkVTVEFSVCApDQo+PiArICAgICAgICAgICAgcHJvY2Vzc19wZW5kaW5nX3NvZnRp
cnFzKCk7DQo+PiArICAgIH0NCj4+ICAgICAgIGlmICggIXJjICkNCj4+ICAgICAgICAgICBtb2Rp
ZnlfZGVjb2RpbmcocGRldiwgY21kLCBmYWxzZSk7DQo+PiAgIA0KPj4gQEAgLTIwOSw3ICsyNjAs
NyBAQCBzdGF0aWMgaW50IF9faW5pdCBhcHBseV9tYXAoc3RydWN0IGRvbWFpbiAqZCwgY29uc3Qg
c3RydWN0IHBjaV9kZXYgKnBkZXYsDQo+PiAgIH0NCj4+ICAgDQo+PiAgIHN0YXRpYyB2b2lkIGRl
ZmVyX21hcChzdHJ1Y3QgZG9tYWluICpkLCBzdHJ1Y3QgcGNpX2RldiAqcGRldiwNCj4+IC0gICAg
ICAgICAgICAgICAgICAgICAgc3RydWN0IHJhbmdlc2V0ICptZW0sIHVpbnQxNl90IGNtZCwgYm9v
bCByb21fb25seSkNCj4+ICsgICAgICAgICAgICAgICAgICAgICAgdWludDE2X3QgY21kLCBib29s
IHJvbV9vbmx5KQ0KPj4gICB7DQo+PiAgICAgICBzdHJ1Y3QgdmNwdSAqY3VyciA9IGN1cnJlbnQ7
DQo+PiAgIA0KPj4gQEAgLTIyMCw3ICsyNzEsNyBAQCBzdGF0aWMgdm9pZCBkZWZlcl9tYXAoc3Ry
dWN0IGRvbWFpbiAqZCwgc3RydWN0IHBjaV9kZXYgKnBkZXYsDQo+PiAgICAgICAgKiBzdGFydGVk
IGZvciB0aGUgc2FtZSBkZXZpY2UgaWYgdGhlIGRvbWFpbiBpcyBub3Qgd2VsbC1iZWhhdmVkLg0K
Pj4gICAgICAgICovDQo+PiAgICAgICBjdXJyLT52cGNpLnBkZXYgPSBwZGV2Ow0KPj4gLSAgICBj
dXJyLT52cGNpLm1lbSA9IG1lbTsNCj4+ICsgICAgY3Vyci0+dnBjaS5tYXBfcGVuZGluZyA9IHRy
dWU7DQo+PiAgICAgICBjdXJyLT52cGNpLmNtZCA9IGNtZDsNCj4+ICAgICAgIGN1cnItPnZwY2ku
cm9tX29ubHkgPSByb21fb25seTsNCj4+ICAgICAgIC8qDQo+PiBAQCAtMjM0LDQyICsyODUsNDAg
QEAgc3RhdGljIHZvaWQgZGVmZXJfbWFwKHN0cnVjdCBkb21haW4gKmQsIHN0cnVjdCBwY2lfZGV2
ICpwZGV2LA0KPj4gICBzdGF0aWMgaW50IG1vZGlmeV9iYXJzKGNvbnN0IHN0cnVjdCBwY2lfZGV2
ICpwZGV2LCB1aW50MTZfdCBjbWQsIGJvb2wgcm9tX29ubHkpDQo+PiAgIHsNCj4+ICAgICAgIHN0
cnVjdCB2cGNpX2hlYWRlciAqaGVhZGVyID0gJnBkZXYtPnZwY2ktPmhlYWRlcjsNCj4+IC0gICAg
c3RydWN0IHJhbmdlc2V0ICptZW0gPSByYW5nZXNldF9uZXcoTlVMTCwgTlVMTCwgMCk7DQo+PiAg
ICAgICBzdHJ1Y3QgcGNpX2RldiAqdG1wLCAqZGV2ID0gTlVMTDsNCj4+ICAgICAgIGNvbnN0IHN0
cnVjdCB2cGNpX21zaXggKm1zaXggPSBwZGV2LT52cGNpLT5tc2l4Ow0KPj4gLSAgICB1bnNpZ25l
ZCBpbnQgaTsNCj4+ICsgICAgdW5zaWduZWQgaW50IGksIGo7DQo+PiAgICAgICBpbnQgcmM7DQo+
PiAtDQo+PiAtICAgIGlmICggIW1lbSApDQo+PiAtICAgICAgICByZXR1cm4gLUVOT01FTTsNCj4+
ICsgICAgYm9vbCBtYXBfcGVuZGluZzsNCj4+ICAgDQo+PiAgICAgICAvKg0KPj4gLSAgICAgKiBD
cmVhdGUgYSByYW5nZXNldCB0aGF0IHJlcHJlc2VudHMgdGhlIGN1cnJlbnQgZGV2aWNlIEJBUnMg
bWVtb3J5IHJlZ2lvbg0KPj4gKyAgICAgKiBDcmVhdGUgYSByYW5nZXNldCBwZXIgQkFSIHRoYXQg
cmVwcmVzZW50cyB0aGUgY3VycmVudCBkZXZpY2UgbWVtb3J5IHJlZ2lvbg0KPj4gICAgICAgICog
YW5kIGNvbXBhcmUgaXQgYWdhaW5zdCBhbGwgdGhlIGN1cnJlbnRseSBhY3RpdmUgQkFSIG1lbW9y
eSByZWdpb25zLiBJZg0KPj4gICAgICAgICogYW4gb3ZlcmxhcCBpcyBmb3VuZCwgc3VidHJhY3Qg
aXQgZnJvbSB0aGUgcmVnaW9uIHRvIGJlIG1hcHBlZC91bm1hcHBlZC4NCj4+ICAgICAgICAqDQo+
PiAtICAgICAqIEZpcnN0IGZpbGwgdGhlIHJhbmdlc2V0IHdpdGggYWxsIHRoZSBCQVJzIG9mIHRo
aXMgZGV2aWNlIG9yIHdpdGggdGhlIFJPTQ0KPj4gKyAgICAgKiBGaXJzdCBmaWxsIHRoZSByYW5n
ZXNldHMgd2l0aCBhbGwgdGhlIEJBUnMgb2YgdGhpcyBkZXZpY2Ugb3Igd2l0aCB0aGUgUk9NDQo+
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXiAnYWxsJyBkb2Vzbid0
IGFwcGx5IGFueW1vcmUuDQpXaWxsIGZpeA0KPj4gICAgICAgICogQkFSIG9ubHksIGRlcGVuZGlu
ZyBvbiB3aGV0aGVyIHRoZSBndWVzdCBpcyB0b2dnbGluZyB0aGUgbWVtb3J5IGRlY29kZQ0KPj4g
ICAgICAgICogYml0IG9mIHRoZSBjb21tYW5kIHJlZ2lzdGVyLCBvciB0aGUgZW5hYmxlIGJpdCBv
ZiB0aGUgUk9NIEJBUiByZWdpc3Rlci4NCj4+ICAgICAgICAqLw0KPj4gICAgICAgZm9yICggaSA9
IDA7IGkgPCBBUlJBWV9TSVpFKGhlYWRlci0+YmFycyk7IGkrKyApDQo+PiAgICAgICB7DQo+PiAt
ICAgICAgICBjb25zdCBzdHJ1Y3QgdnBjaV9iYXIgKmJhciA9ICZoZWFkZXItPmJhcnNbaV07DQo+
PiArICAgICAgICBzdHJ1Y3QgdnBjaV9iYXIgKmJhciA9ICZoZWFkZXItPmJhcnNbaV07DQo+PiAg
ICAgICAgICAgdW5zaWduZWQgbG9uZyBzdGFydCA9IFBGTl9ET1dOKGJhci0+YWRkcik7DQo+PiAg
ICAgICAgICAgdW5zaWduZWQgbG9uZyBlbmQgPSBQRk5fRE9XTihiYXItPmFkZHIgKyBiYXItPnNp
emUgLSAxKTsNCj4+ICAgDQo+PiArICAgICAgICBBU1NFUlQoYmFyLT5tZW0pOw0KPj4gKw0KPj4g
ICAgICAgICAgIGlmICggIU1BUFBBQkxFX0JBUihiYXIpIHx8DQo+PiAgICAgICAgICAgICAgICAo
cm9tX29ubHkgPyBiYXItPnR5cGUgIT0gVlBDSV9CQVJfUk9NDQo+PiAgICAgICAgICAgICAgICAg
ICAgICAgICAgOiAoYmFyLT50eXBlID09IFZQQ0lfQkFSX1JPTSAmJiAhaGVhZGVyLT5yb21fZW5h
YmxlZCkpICkNCj4+ICAgICAgICAgICAgICAgY29udGludWU7DQo+PiAgIA0KPj4gLSAgICAgICAg
cmMgPSByYW5nZXNldF9hZGRfcmFuZ2UobWVtLCBzdGFydCwgZW5kKTsNCj4+ICsgICAgICAgIHJj
ID0gcmFuZ2VzZXRfYWRkX3JhbmdlKGJhci0+bWVtLCBzdGFydCwgZW5kKTsNCj4+ICAgICAgICAg
ICBpZiAoIHJjICkNCj4+ICAgICAgICAgICB7DQo+PiAgICAgICAgICAgICAgIHByaW50ayhYRU5M
T0dfR19XQVJOSU5HICJGYWlsZWQgdG8gYWRkIFslbHgsICVseF06ICVkXG4iLA0KPj4gICAgICAg
ICAgICAgICAgICAgICAgc3RhcnQsIGVuZCwgcmMpOw0KPj4gLSAgICAgICAgICAgIHJhbmdlc2V0
X2Rlc3Ryb3kobWVtKTsNCj4+IC0gICAgICAgICAgICByZXR1cm4gcmM7DQo+PiArICAgICAgICAg
ICAgZ290byBmYWlsOw0KPj4gICAgICAgICAgIH0NCj4gSSB0aGluayB5b3UgYWxzbyBuZWVkIHRv
IGNoZWNrIHRoYXQgQkFScyBmcm9tIHRoZSBzYW1lIGRldmljZSBkb24ndA0KPiBvdmVybGFwIHRo
ZW1zZWx2ZXMuIFRoaXMgd2Fzbid0IG5lZWRlZCBiZWZvcmUgYmVjYXVzZSBhbGwgQkFScyBzaGFy
ZWQNCj4gdGhlIHNhbWUgcmFuZ2VzZXQuIEl0J3Mgbm90IHVuY29tbW9uIGZvciBCQVJzIG9mIHRo
ZSBzYW1lIGRldmljZSB0bw0KPiBzaGFyZSBhIHBhZ2UuDQo+DQo+IFNvIHlvdSB3b3VsZCBuZWVk
IHNvbWV0aGluZyBsaWtlIHRoZSBmb2xsb3dpbmcgYWRkZWQgdG8gdGhlIGxvb3A6DQo+DQo+IC8q
IENoZWNrIGZvciBvdmVybGFwIHdpdGggdGhlIGFscmVhZHkgc2V0dXAgQkFSIHJhbmdlcy4gKi8N
Cj4gZm9yICggaiA9IDA7IGogPCBpOyBqKysgKQ0KPiAgICAgIHJhbmdlc2V0X3JlbW92ZV9yYW5n
ZShoZWFkZXItPmJhcnNbal0ubWVtLCBzdGFydCwgZW5kKTsNCkdvb2QgcG9pbnQNCj4+ICAgICAg
IH0NCj4+ICAgDQo+PiBAQCAtMjgwLDE0ICszMjksMjEgQEAgc3RhdGljIGludCBtb2RpZnlfYmFy
cyhjb25zdCBzdHJ1Y3QgcGNpX2RldiAqcGRldiwgdWludDE2X3QgY21kLCBib29sIHJvbV9vbmx5
KQ0KPj4gICAgICAgICAgIHVuc2lnbmVkIGxvbmcgZW5kID0gUEZOX0RPV04odm1zaXhfdGFibGVf
YWRkcihwZGV2LT52cGNpLCBpKSArDQo+PiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICB2bXNpeF90YWJsZV9zaXplKHBkZXYtPnZwY2ksIGkpIC0gMSk7DQo+PiAgIA0KPj4g
LSAgICAgICAgcmMgPSByYW5nZXNldF9yZW1vdmVfcmFuZ2UobWVtLCBzdGFydCwgZW5kKTsNCj4+
IC0gICAgICAgIGlmICggcmMgKQ0KPj4gKyAgICAgICAgZm9yICggaiA9IDA7IGogPCBBUlJBWV9T
SVpFKGhlYWRlci0+YmFycyk7IGorKyApDQo+PiAgICAgICAgICAgew0KPj4gLSAgICAgICAgICAg
IHByaW50ayhYRU5MT0dfR19XQVJOSU5HDQo+PiAtICAgICAgICAgICAgICAgICAgICJGYWlsZWQg
dG8gcmVtb3ZlIE1TSVggdGFibGUgWyVseCwgJWx4XTogJWRcbiIsDQo+PiAtICAgICAgICAgICAg
ICAgICAgIHN0YXJ0LCBlbmQsIHJjKTsNCj4+IC0gICAgICAgICAgICByYW5nZXNldF9kZXN0cm95
KG1lbSk7DQo+PiAtICAgICAgICAgICAgcmV0dXJuIHJjOw0KPj4gKyAgICAgICAgICAgIGNvbnN0
IHN0cnVjdCB2cGNpX2JhciAqYmFyID0gJmhlYWRlci0+YmFyc1tqXTsNCj4+ICsNCj4+ICsgICAg
ICAgICAgICBpZiAoIHJhbmdlc2V0X2lzX2VtcHR5KGJhci0+bWVtKSApDQo+PiArICAgICAgICAg
ICAgICAgIGNvbnRpbnVlOw0KPj4gKw0KPj4gKyAgICAgICAgICAgIHJjID0gcmFuZ2VzZXRfcmVt
b3ZlX3JhbmdlKGJhci0+bWVtLCBzdGFydCwgZW5kKTsNCj4+ICsgICAgICAgICAgICBpZiAoIHJj
ICkNCj4+ICsgICAgICAgICAgICB7DQo+PiArICAgICAgICAgICAgICAgIHByaW50ayhYRU5MT0df
R19XQVJOSU5HDQo+PiArICAgICAgICAgICAgICAgICAgICAgICAiRmFpbGVkIHRvIHJlbW92ZSBN
U0lYIHRhYmxlIFslbHgsICVseF06ICVkXG4iLA0KPj4gKyAgICAgICAgICAgICAgICAgICAgICAg
c3RhcnQsIGVuZCwgcmMpOw0KPj4gKyAgICAgICAgICAgICAgICBnb3RvIGZhaWw7DQo+PiArICAg
ICAgICAgICAgfQ0KPj4gICAgICAgICAgIH0NCj4+ICAgICAgIH0NCj4+ICAgDQo+PiBAQCAtMzI1
LDcgKzM4MSw4IEBAIHN0YXRpYyBpbnQgbW9kaWZ5X2JhcnMoY29uc3Qgc3RydWN0IHBjaV9kZXYg
KnBkZXYsIHVpbnQxNl90IGNtZCwgYm9vbCByb21fb25seSkNCj4+ICAgICAgICAgICAgICAgdW5z
aWduZWQgbG9uZyBzdGFydCA9IFBGTl9ET1dOKGJhci0+YWRkcik7DQo+PiAgICAgICAgICAgICAg
IHVuc2lnbmVkIGxvbmcgZW5kID0gUEZOX0RPV04oYmFyLT5hZGRyICsgYmFyLT5zaXplIC0gMSk7
DQo+PiAgIA0KPj4gLSAgICAgICAgICAgIGlmICggIWJhci0+ZW5hYmxlZCB8fCAhcmFuZ2VzZXRf
b3ZlcmxhcHNfcmFuZ2UobWVtLCBzdGFydCwgZW5kKSB8fA0KPj4gKyAgICAgICAgICAgIGlmICgg
IWJhci0+ZW5hYmxlZCB8fA0KPj4gKyAgICAgICAgICAgICAgICAgIXJhbmdlc2V0X292ZXJsYXBz
X3JhbmdlKGJhci0+bWVtLCBzdGFydCwgZW5kKSB8fA0KPj4gICAgICAgICAgICAgICAgICAgIC8q
DQo+PiAgICAgICAgICAgICAgICAgICAgICogSWYgb25seSB0aGUgUk9NIGVuYWJsZSBiaXQgaXMg
dG9nZ2xlZCBjaGVjayBhZ2FpbnN0IG90aGVyDQo+PiAgICAgICAgICAgICAgICAgICAgICogQkFS
cyBpbiB0aGUgc2FtZSBkZXZpY2UgZm9yIG92ZXJsYXBzLCBidXQgbm90IGFnYWluc3QgdGhlDQo+
PiBAQCAtMzM0LDE0ICszOTEsMTMgQEAgc3RhdGljIGludCBtb2RpZnlfYmFycyhjb25zdCBzdHJ1
Y3QgcGNpX2RldiAqcGRldiwgdWludDE2X3QgY21kLCBib29sIHJvbV9vbmx5KQ0KPj4gICAgICAg
ICAgICAgICAgICAgIChyb21fb25seSAmJiB0bXAgPT0gcGRldiAmJiBiYXItPnR5cGUgPT0gVlBD
SV9CQVJfUk9NKSApDQo+PiAgICAgICAgICAgICAgICAgICBjb250aW51ZTsNCj4+ICAgDQo+PiAt
ICAgICAgICAgICAgcmMgPSByYW5nZXNldF9yZW1vdmVfcmFuZ2UobWVtLCBzdGFydCwgZW5kKTsN
Cj4+ICsgICAgICAgICAgICByYyA9IHJhbmdlc2V0X3JlbW92ZV9yYW5nZShiYXItPm1lbSwgc3Rh
cnQsIGVuZCk7DQo+PiAgICAgICAgICAgICAgIGlmICggcmMgKQ0KPj4gICAgICAgICAgICAgICB7
DQo+PiAgICAgICAgICAgICAgICAgICBzcGluX3VubG9jaygmdG1wLT52cGNpX2xvY2spOw0KPj4g
ICAgICAgICAgICAgICAgICAgcHJpbnRrKFhFTkxPR19HX1dBUk5JTkcgIkZhaWxlZCB0byByZW1v
dmUgWyVseCwgJWx4XTogJWRcbiIsDQo+PiAgICAgICAgICAgICAgICAgICAgICAgICAgc3RhcnQs
IGVuZCwgcmMpOw0KPj4gLSAgICAgICAgICAgICAgICByYW5nZXNldF9kZXN0cm95KG1lbSk7DQo+
PiAtICAgICAgICAgICAgICAgIHJldHVybiByYzsNCj4+ICsgICAgICAgICAgICAgICAgZ290byBm
YWlsOw0KPj4gICAgICAgICAgICAgICB9DQo+PiAgICAgICAgICAgfQ0KPj4gICAgICAgICAgIHNw
aW5fdW5sb2NrKCZ0bXAtPnZwY2lfbG9jayk7DQo+PiBAQCAtMzYwLDEyICs0MTYsMzYgQEAgc3Rh
dGljIGludCBtb2RpZnlfYmFycyhjb25zdCBzdHJ1Y3QgcGNpX2RldiAqcGRldiwgdWludDE2X3Qg
Y21kLCBib29sIHJvbV9vbmx5KQ0KPj4gICAgICAgICAgICAqIHdpbGwgYWx3YXlzIGJlIHRvIGVz
dGFibGlzaCBtYXBwaW5ncyBhbmQgcHJvY2VzcyBhbGwgdGhlIEJBUnMuDQo+PiAgICAgICAgICAg
ICovDQo+PiAgICAgICAgICAgQVNTRVJUKChjbWQgJiBQQ0lfQ09NTUFORF9NRU1PUlkpICYmICFy
b21fb25seSk7DQo+PiAtICAgICAgICByZXR1cm4gYXBwbHlfbWFwKHBkZXYtPmRvbWFpbiwgcGRl
diwgbWVtLCBjbWQpOw0KPj4gKyAgICAgICAgcmV0dXJuIGFwcGx5X21hcChwZGV2LT5kb21haW4s
IHBkZXYsIGNtZCk7DQo+PiAgICAgICB9DQo+PiAgIA0KPj4gLSAgICBkZWZlcl9tYXAoZGV2LT5k
b21haW4sIGRldiwgbWVtLCBjbWQsIHJvbV9vbmx5KTsNCj4+ICsgICAgLyogRmluZCBvdXQgaG93
IG1hbnkgbWVtb3J5IHJhbmdlcyBoYXMgbGVmdCBhZnRlciBNU0kgYW5kIG92ZXJsYXBzLiAqLw0K
Pj4gKyAgICBtYXBfcGVuZGluZyA9IGZhbHNlOw0KPj4gKyAgICBmb3IgKCBpID0gMDsgaSA8IEFS
UkFZX1NJWkUoaGVhZGVyLT5iYXJzKTsgaSsrICkNCj4+ICsgICAgICAgIGlmICggIXJhbmdlc2V0
X2lzX2VtcHR5KGhlYWRlci0+YmFyc1tpXS5tZW0pICkNCj4+ICsgICAgICAgIHsNCj4+ICsgICAg
ICAgICAgICBtYXBfcGVuZGluZyA9IHRydWU7DQo+PiArICAgICAgICAgICAgYnJlYWs7DQo+PiAr
ICAgICAgICB9DQo+PiArDQo+PiArICAgIC8qDQo+PiArICAgICAqIFRoZXJlIGFyZSBjYXNlcyB3
aGVuIFBDSSBkZXZpY2UsIHJvb3QgcG9ydCBmb3IgZXhhbXBsZSwgaGFzIG5laXRoZXINCj4+ICsg
ICAgICogbWVtb3J5IHNwYWNlIG5vciBJTy4gSW4gdGhpcyBjYXNlIFBDSSBjb21tYW5kIHJlZ2lz
dGVyIHdyaXRlIGlzDQo+PiArICAgICAqIG1pc3NlZCByZXN1bHRpbmcgaW4gdGhlIHVuZGVybHlp
bmcgUENJIGRldmljZSBub3QgZnVuY3Rpb25hbCwgc286DQo+PiArICAgICAqICAgLSBpZiB0aGVy
ZSBhcmUgbm8gcmVnaW9ucyB3cml0ZSB0aGUgY29tbWFuZCByZWdpc3RlciBub3cNCj4+ICsgICAg
ICogICAtIGlmIHRoZXJlIGFyZSByZWdpb25zIHRoZW4gZGVmZXIgd29yayBhbmQgd3JpdGUgbGF0
ZXIgb24NCj4gSSB3b3VsZCBqdXN0IHNheToNCj4NCj4gLyogSWYgdGhlcmUncyBubyBtYXBwaW5n
IHdvcmsgd3JpdGUgdGhlIGNvbW1hbmQgcmVnaXN0ZXIgbm93LiAqLw0KT2sNCj4+ICsgICAgICov
DQo+PiArICAgIGlmICggIW1hcF9wZW5kaW5nICkNCj4+ICsgICAgICAgIHBjaV9jb25mX3dyaXRl
MTYocGRldi0+c2JkZiwgUENJX0NPTU1BTkQsIGNtZCk7DQo+PiArICAgIGVsc2UNCj4+ICsgICAg
ICAgIGRlZmVyX21hcChkZXYtPmRvbWFpbiwgZGV2LCBjbWQsIHJvbV9vbmx5KTsNCj4+ICAgDQo+
PiAgICAgICByZXR1cm4gMDsNCj4+ICsNCj4+ICtmYWlsOg0KPj4gKyAgICAvKiBEZXN0cm95IGFs
bCB0aGUgcmFuZ2VzIHdlIG1heSBoYXZlIGFkZGVkLiAqLw0KPj4gKyAgICB2cGNpX2Jhcl9yZW1v
dmVfcmFuZ2VzKHBkZXYpOw0KPj4gKyAgICByZXR1cm4gcmM7DQo+PiAgIH0NCj4+ICAgDQo+PiAg
IHN0YXRpYyB2b2lkIGNtZF93cml0ZShjb25zdCBzdHJ1Y3QgcGNpX2RldiAqcGRldiwgdW5zaWdu
ZWQgaW50IHJlZywNCj4+IGRpZmYgLS1naXQgYS94ZW4vZHJpdmVycy92cGNpL3ZwY2kuYyBiL3hl
bi9kcml2ZXJzL3ZwY2kvdnBjaS5jDQo+PiBpbmRleCBhOWU5ZThlYzQzOGMuLjk4YjEyYTYxYmU2
ZiAxMDA2NDQNCj4+IC0tLSBhL3hlbi9kcml2ZXJzL3ZwY2kvdnBjaS5jDQo+PiArKysgYi94ZW4v
ZHJpdmVycy92cGNpL3ZwY2kuYw0KPj4gQEAgLTUyLDExICs1MiwxNiBAQCBzdGF0aWMgdm9pZCB2
cGNpX3JlbW92ZV9kZXZpY2VfaGFuZGxlcnNfbG9ja2VkKHN0cnVjdCBwY2lfZGV2ICpwZGV2KQ0K
Pj4gICANCj4+ICAgdm9pZCB2cGNpX3JlbW92ZV9kZXZpY2VfbG9ja2VkKHN0cnVjdCBwY2lfZGV2
ICpwZGV2KQ0KPj4gICB7DQo+PiArICAgIHN0cnVjdCB2cGNpX2hlYWRlciAqaGVhZGVyID0gJnBk
ZXYtPnZwY2ktPmhlYWRlcjsNCj4+ICsgICAgdW5zaWduZWQgaW50IGk7DQo+PiArDQo+PiAgICAg
ICBBU1NFUlQoc3Bpbl9pc19sb2NrZWQoJnBkZXYtPnZwY2lfbG9jaykpOw0KPj4gICANCj4+ICAg
ICAgIHBkZXYtPnZwY2lfY2FuY2VsX3BlbmRpbmcgPSB0cnVlOw0KPj4gICAgICAgdnBjaV9yZW1v
dmVfZGV2aWNlX2hhbmRsZXJzX2xvY2tlZChwZGV2KTsNCj4+ICAgICAgIHZwY2lfY2FuY2VsX3Bl
bmRpbmdfbG9ja2VkKHBkZXYpOw0KPj4gKyAgICBmb3IgKCBpID0gMDsgaSA8IEFSUkFZX1NJWkUo
aGVhZGVyLT5iYXJzKTsgaSsrICkNCj4+ICsgICAgICAgIHJhbmdlc2V0X2Rlc3Ryb3koaGVhZGVy
LT5iYXJzW2ldLm1lbSk7DQo+PiAgICAgICB4ZnJlZShwZGV2LT52cGNpLT5tc2l4KTsNCj4+ICAg
ICAgIHhmcmVlKHBkZXYtPnZwY2ktPm1zaSk7DQo+PiAgICAgICB4ZnJlZShwZGV2LT52cGNpKTsN
Cj4+IEBAIC05Miw2ICs5Nyw4IEBAIHN0YXRpYyBpbnQgcnVuX3ZwY2lfaW5pdChzdHJ1Y3QgcGNp
X2RldiAqcGRldikNCj4+ICAgaW50IHZwY2lfYWRkX2hhbmRsZXJzKHN0cnVjdCBwY2lfZGV2ICpw
ZGV2KQ0KPj4gICB7DQo+PiAgICAgICBzdHJ1Y3QgdnBjaSAqdnBjaTsNCj4+ICsgICAgc3RydWN0
IHZwY2lfaGVhZGVyICpoZWFkZXI7DQo+PiArICAgIHVuc2lnbmVkIGludCBpOw0KPj4gICAgICAg
aW50IHJjOw0KPj4gICANCj4+ICAgICAgIGlmICggIWhhc192cGNpKHBkZXYtPmRvbWFpbikgKQ0K
Pj4gQEAgLTEwOCwxMSArMTE1LDMyIEBAIGludCB2cGNpX2FkZF9oYW5kbGVycyhzdHJ1Y3QgcGNp
X2RldiAqcGRldikNCj4+ICAgICAgIHBkZXYtPnZwY2kgPSB2cGNpOw0KPj4gICAgICAgSU5JVF9M
SVNUX0hFQUQoJnBkZXYtPnZwY2ktPmhhbmRsZXJzKTsNCj4+ICAgDQo+PiArICAgIGhlYWRlciA9
ICZwZGV2LT52cGNpLT5oZWFkZXI7DQo+PiArICAgIGZvciAoIGkgPSAwOyBpIDwgQVJSQVlfU0la
RShoZWFkZXItPmJhcnMpOyBpKysgKQ0KPj4gKyAgICB7DQo+PiArICAgICAgICBzdHJ1Y3QgdnBj
aV9iYXIgKmJhciA9ICZoZWFkZXItPmJhcnNbaV07DQo+PiArICAgICAgICBjaGFyIHN0clszMl07
DQo+PiArDQo+PiArICAgICAgICBzbnByaW50ZihzdHIsIHNpemVvZihzdHIpLCAiJXBwOkJBUiVk
IiwgJnBkZXYtPnNiZGYsIGkpOw0KPj4gKyAgICAgICAgYmFyLT5tZW0gPSByYW5nZXNldF9uZXco
cGRldi0+ZG9tYWluLCBzdHIsIFJBTkdFU0VURl9ub19wcmludCk7DQo+PiArICAgICAgICBpZiAo
ICFiYXItPm1lbSApDQo+PiArICAgICAgICB7DQo+PiArICAgICAgICAgICAgcmMgPSAtRU5PTUVN
Ow0KPj4gKyAgICAgICAgICAgIGdvdG8gZmFpbDsNCj4+ICsgICAgICAgIH0NCj4+ICsgICAgfQ0K
PiBZb3UganVzdCBuZWVkIHRoZSByYW5nZXMgZm9yIHRoZSBWUENJX0JBUl9NRU0zMiwgVlBDSV9C
QVJfTUVNNjRfTE8gYW5kDQo+IFZQQ0lfQkFSX1JPTSBCQVIgdHlwZXMgKHNlZSB0aGUgTUFQUEFC
TEVfQkFSIG1hY3JvKS4gV291bGQgaXQgYmUNCj4gcG9zc2libGUgdG8gb25seSBhbGxvY2F0ZSB0
aGUgcmFuZ2VzZXQgZm9yIHRob3NlIEJBUiB0eXBlcz8NCkkgZ3Vlc3Mgc28NCj4gQWxzbyB0aGlz
IHNob3VsZCBiZSBkb25lIGluIGluaXRfYmFycyByYXRoZXIgdGhhbiBoZXJlLCBhcyB5b3Ugd291
bGQNCj4ga25vdyB0aGUgQkFSIHR5cGVzLg0KU28sIGlmIHdlIGFsbG9jYXRlIHRoZXNlIGluIGlu
aXRfYmFycyBzbyB3aGVyZSBhcmUgdGhleSBkZXN0cm95ZWQgdGhlbj8NCkkgdGhpbmsgdGhpcyBz
aG91bGQgYmUgdnBjaV9yZW1vdmVfZGV2aWNlIGFuZCBmcm9tIHRoaXMgUE9WIGl0IHdvdWxkDQpi
ZSBnb29kIHRvIGtlZXAgYWxsb2MvZnJlZSBjb2RlIGNsb3NlIHRvIGVhY2ggb3RoZXIsIGUuZy4N
CnZwY2lfYWRkX2hhbmRsZXJzL3ZwY2lfcmVtb3ZlX2RldmljZSBpbiB0aGUgc2FtZSBmaWxlDQoN
Cj4gVGhhbmtzLCBSb2dlci4NClRoYW5rIHlvdSwNCk9sZWtzYW5kcg==


From xen-devel-bounces@lists.xenproject.org Wed Feb 02 08:23:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 08:23:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.263836.456675 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFAva-0000WK-5r; Wed, 02 Feb 2022 08:23:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 263836.456675; Wed, 02 Feb 2022 08:23:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFAva-0000WD-2n; Wed, 02 Feb 2022 08:23:46 +0000
Received: by outflank-mailman (input) for mailman id 263836;
 Wed, 02 Feb 2022 08:23:44 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1p3Q=SR=epam.com=prvs=40324c57ab=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nFAvY-0000W7-5X
 for xen-devel@lists.xenproject.org; Wed, 02 Feb 2022 08:23:44 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6d2ba473-8401-11ec-8eb8-a37418f5ba1a;
 Wed, 02 Feb 2022 09:23:42 +0100 (CET)
Received: from pps.filterd (m0174676.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 2128Muhs010498;
 Wed, 2 Feb 2022 08:23:37 GMT
Received: from eur05-db8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2106.outbound.protection.outlook.com [104.47.17.106])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3dyp38r1mc-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 02 Feb 2022 08:23:37 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by VE1PR03MB5568.eurprd03.prod.outlook.com (2603:10a6:803:11a::32)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.11; Wed, 2 Feb
 2022 08:23:32 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6%3]) with mapi id 15.20.4951.012; Wed, 2 Feb 2022
 08:23:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6d2ba473-8401-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=iHcM9/9sVGB5t6y0lLxaik5ZftcBpZIlug+UdWtwIbxb+FQ+g4MGag2ZzDOcCyc8OYGym/ALRVrxWYFsXt2EhYQdJPjyoTCuG06W3cRgW6a9o8+MKKSO+7q248HaSMguqCn6DNaXq29GNPWCaXfXVjnvDXgc2ZGNT9QfIso+kddIXEofF8FK0d0MeqPRImHIhJDVNTIkOOJH8UUYPYkSmhNaBHmdKtmSXCqNOO5zl1XNax3f0mEIHz+IUUP4vyRQmbnC7fX1aoSt0KzCgms1LhKfiLCIobmWivtFq2V3R5akjWAsB/ahBczu2g8V70ZnCoLUgnNodLPpFtkTZV+9eg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=NLB2xqn41dMA3V0oLXKQ/veiWOKFctfhomoTghrNCiE=;
 b=E2ZXeDT81f3GMJ3c8VeOItmT0sjpXbuxbaO8lPibmcv0UkMz9KwOX4rCTqTeNMRm0K4yODje+on50WBUZ/zeIYMl2oV8UZnWnden/FMNCLU5a/enbe2V7p0r/QnDLqmu3K4GRuB/tLqxNnubwXav+BC9+qpru2XGRGv+gOM/cYidgEddz8XihWsv+A63AkHUAp6cbr8mGbp5sFWFvdC4iSBPIFm9yfqY05VgHPnf+Wo+yuZmADoikLXraQo8IP6BrTCQcj8S5Nro3q0bUWNVKVUN9MRx037xJru+8tkCjSbGgl/5WhRYA2t77uANdsJI64aVmylPb7MXULPeRzQnzg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=NLB2xqn41dMA3V0oLXKQ/veiWOKFctfhomoTghrNCiE=;
 b=DKbWfVxipmBegW40ukzObeUdiSbUIkMhDTEknXOT+1Tg9IkVb1biXzlaCILeSAGcOEcaNC0JWloE+zLGwQbgQEQFvAtAHsmUtvjV+hHL5WlctLIlP4diEnTzCQ9AZ5T8tcCwCy63GbV8sfoqxy+ksto/a4LeKUOw4hLWOLWhHU3ha8tUVKANTSnWnQWjnp7JDGGcKuoJqKkEsJvnkFcuDd6yfiGzGUTGpxKG/zmLeA0fw6myFbkEpoKN0+bHxucO5Ce10HnSpagbmj5N4RKR1QJWHquSur/Z1IDFTHEGgKU4gXIOMRInWl0L7QpobHxKaqVwhwY9kghD3XQ2uHmAtw==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "jbeulich@suse.com" <jbeulich@suse.com>,
        "andrew.cooper3@citrix.com"
	<andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com"
	<george.dunlap@citrix.com>,
        "paul@xen.org" <paul@xen.org>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>,
        Rahul Singh <rahul.singh@arm.com>,
        Oleksandr
 Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v5 08/14] vpci/header: program p2m with guest BAR view
Thread-Topic: [PATCH v5 08/14] vpci/header: program p2m with guest BAR view
Thread-Index: AQHX4ewInH3i1A85zUqSOqe7J03BoaxhCwuAgB9Nb4A=
Date: Wed, 2 Feb 2022 08:23:32 +0000
Message-ID: <37c2374d-c0f7-23b6-d2f8-e94d1348807c@epam.com>
References: <20211125110251.2877218-1-andr2000@gmail.com>
 <20211125110251.2877218-9-andr2000@gmail.com> <Yd/9W7GFO51GE0ch@Air-de-Roger>
In-Reply-To: <Yd/9W7GFO51GE0ch@Air-de-Roger>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: a99a6232-fbae-49b6-6696-08d9e6254ceb
x-ms-traffictypediagnostic: VE1PR03MB5568:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <VE1PR03MB5568E904F24D282367135FF0E7279@VE1PR03MB5568.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:6430;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 FtOTmkgGHYQaHm35VKOYWDeJtr+cIRinq7x16s6dNzjrAssp/rjSvy93noxeOYxYKq2MfA7j07uIqWUHiKmlszwffDUdj2gh/DyTY3I/T2gOFJJ0F0+0mzTABtjnC+S6YenmkQVIxxZD3dUzFgqyRWloJ7p+E5YbljVfLTTVfiyAspvwWDGpVHtH0YXxYOhX3ihXGOmZ9QOToFdyBTpLHQykXOii8GOw29pwazC10oYpMeNRY/zHVMv6dPBiwdJoxAquo9SIR42UI6aT2/mgJUpBfzr0VWrC1PfMlD0eeIW3Y/jwXLFtQbFWX5FIMw2nNGfLn/Se//fDPw0eLosRXB2WYCSCN9AYuJUEsZEZOq6BdqXzfVVbgxBimT0w57hLzD0LhWwTtjiDJfTBfoIzPLv+D24nzPJhmCjyIUTFeVFvGKlYmJqZdjzeR17Ffga+YKQoqBulBVqPhQke1m9zclF/US70M3AO/LwZtrtqYMujckr8uuis5fGf56izzdRTsUVfJGc+BHrpy8/lHApHgHuwAhkES0YMlM+Sq7IEcOLYjJ72BWtdC79Gqirh5WqBSF9UBGuVVhY0WJxfwDqwgM3V4/0+NT0ITcXbn2r9MH4eVFEvDIYqZ+EXQ6WNYgSL5bR9+XlOle/fvQh2F7t5GFOVb3BTUvD7hIxveQISHDOa6cVQNVzJQO/Kd02eL913DW/YbEb6gwZzJ0YEgf/pt46sPHQd0CCwzColS/4rNCLu9psI7xgHkWamXqicWd0OXKHAdHT2gUYVW3QEb1+kakUwk0despclyXlZ1zL/zeU=
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(31686004)(316002)(6916009)(54906003)(31696002)(508600001)(86362001)(7416002)(38070700005)(36756003)(122000001)(38100700002)(6486002)(66946007)(107886003)(8936002)(66556008)(2906002)(186003)(66446008)(26005)(4326008)(8676002)(53546011)(71200400001)(91956017)(66476007)(76116006)(5660300002)(2616005)(6512007)(64756008)(83380400001)(6506007)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?dlpOb25HdzJvZXdsZHRZR05FRVcramFDT2pSd0Rqd3lzMks3U1JEam9BaC92?=
 =?utf-8?B?K1QzT09VTEdiZ3BxRWNLUlQ0RjNFczdKeWd1aHBZcEg3R282L1BrVnJ1ampG?=
 =?utf-8?B?ZGIyVkdmMWExd3daSkFrTU94K2V2Z0pFMjBaSTYyb1dQUkxCUkh1RE16TkRR?=
 =?utf-8?B?Q2srRGp2blBBbEVnNUpMd1R1NHdCeXhWRGZNeXMxMXRUb0RQSGZZcU1qRWE2?=
 =?utf-8?B?K3NxbUhOYXRCc3pDRXUwckplbzk2WkhlUnZROXZJMXRsU0VDT3NJYUNBR2VD?=
 =?utf-8?B?N0VpZ1lxN3hnRFFpZTZWRmxkdnVNeDNneEk0a2J3d3RGR3F4Z2NEWWtiakpN?=
 =?utf-8?B?Q21lSWJ5UkNFbXpoNFgybHJoLzZCd251L3lMQzNwTFlUSmdWWDFXWFJYcldH?=
 =?utf-8?B?aXJDbEVjbWN1RENVa216WEVEa0lTZ2trNWZWclltUUk2Vjc4N3Qvc3haLzdG?=
 =?utf-8?B?OU5CNjVtRENQcHZMem92RXl3VzBVOWlkU2NRYk1UUmhzRzRRdFltUXdQR3hq?=
 =?utf-8?B?RmYxa3A3b2t4K0huR2Vhak1sN1JCQnZ6OHpEMVBCdkRzUVRrbkxFdWxrdXcv?=
 =?utf-8?B?c1F3U2ZPdDhCUERnblgxTlFTeFRJUDlqL1JsS21pOTE4ZWJkalVMdm9uYW90?=
 =?utf-8?B?YlZzVlI0eFZ0ZjZiVWZsZEVhY3Q1SFJmZGlWRmFkMWp1VEc3QzBjWllRYjVx?=
 =?utf-8?B?TmVreFhPOGU5MllVbVFZVnNHQ2pZNm02Q1N6WVdyS2hlMitVdllRb2x3Q0h5?=
 =?utf-8?B?N21tSk45STdzbkM2QVZCRUJNNERoVFZpZ3IrOGNGN2I1MUZrQktXaXpEVzlw?=
 =?utf-8?B?dEM2RmdJM0VqdTcxQktMTFFKa0huN21ieGxPNHZ4Z2dJY3dLMjhzankyQTdC?=
 =?utf-8?B?c01aY2g4TTFvdHVEcUpoNUxSaTBIMWpKbmRtS3VqSDhTYUN6MkI0d0czMW5z?=
 =?utf-8?B?VzU1VTRQRXM3eExhcm5UcU9NQjRRRWtWK0NidU81Qk5KeExremxFN3ppK1FC?=
 =?utf-8?B?blkxR3RZVm1lb0xrNVBOWm9sVmtsdUE1TkEwaWNHVk9DNHlLVGU3eGs3UGh3?=
 =?utf-8?B?UFplSVI0NWZhWG1VZlpwa1dSNTA3OVROazNtenNacGM1MU9waGJVSFdidzdX?=
 =?utf-8?B?VldBVEJSdllZcVNzQkZaVVJ4ZGhVcWU2TDVHMEZnaXFqME9xWFJCVHV2WDF4?=
 =?utf-8?B?K0tZSFB5Z2xNZXVMcllSM001dWV6QmVOc1pYdVpYQVcxcmpYVmh4RUU4eUVR?=
 =?utf-8?B?Z0NDWXlycEhBQzdyRTd3U3RqZmkvbXl3K0FTaTZhb0cxeW5Xd1VpUVV0cHhL?=
 =?utf-8?B?KytsRUpRdkI1Q3Q4V0xOeUhYamNJeXMxWmNTcDBTS3JZM3hDcjFpWE5VUjdF?=
 =?utf-8?B?SXczVlZaZVVXdXRsR3lOMi8raWZaTVhFN3h5QzVQWFFLY0dpTlBJc01KQ1Z2?=
 =?utf-8?B?eWFRcGpmdVBDVmRHL3hTeTZpNmVBK0VpMjhISGJMVXVvd2w0a0J3aHYyOGFP?=
 =?utf-8?B?RTZKRjdvNlNhRWl5TWpORnNwVUpDVHYvYXRvMC9NTTFmQThkR0U5ZTJRTmRx?=
 =?utf-8?B?U1FrSjBnRjJTb3A4Q0Z1VGhNWmJ5NjZ0K0FUN3BUbk5jS3dKcVE3bGdoNFlj?=
 =?utf-8?B?Sm44dENVeEw0SkU0ZndLZDg4blBETmZNa05NOWlMckNnV0puZlZNMzgvMERU?=
 =?utf-8?B?b3JLTjFZR0FHSTZrOGpEQTdLOU12OE81dFlnM1Y4S2ptbll0bU51R2ZLYXdB?=
 =?utf-8?B?NGVJeTJCWGNCUzVEOUFZaVBnaVRRM2ZIdlNMN0k4a250STZMdk1HcEpIaE1l?=
 =?utf-8?B?amNwSkNNZlpFTGlHTzIyUWpEblVLWkh5RW1RYkxaYk5jQmczZDU0L1dvRkhB?=
 =?utf-8?B?M2E3YVBOdmp1eXoxSC8wL1V0NGFvOWpzREhVcFZYRGp4OFFwd052U0VmTlZB?=
 =?utf-8?B?SmIxdHN3MXE0NEliQkRDMElXSmZZdnZBR3V5TDcxVklwSEpXSGlINEg3NWI2?=
 =?utf-8?B?TWpJWWNRY2VsQlExampRU3lTTFBMcHAvR0FOMjRqSmRaRkhNNkd6bVVZNFlh?=
 =?utf-8?B?R3lhSFB3a01iOFZtbU13SS9MaXpGSUNsZWRFdzd1ZWViS3F5SDhzRytYQXpr?=
 =?utf-8?B?V0w1Q3M1emhhVUdqRXdWd0NmR0hHMHJCNVdnNUR2YTV0N1YwTFExQkpnS3NI?=
 =?utf-8?B?QlRpS3NyZzVHblVVSGh5TVlIVFowRG5jYmExWXlxa3FpZno5b2VzQjdTZitl?=
 =?utf-8?B?UTZzZFVTaXNRRGNueTVReWVVclFMR2U4QTRFa3lJOHRlbzVqZG1YR1V2c1dU?=
 =?utf-8?B?S1BhZCt2QWlVN29YNHErK2J2RzNaWkl6djBzNWxiZmhQUk0rVGNEQT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <FDDECC986CE42E4080AB80F54777B7FA@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a99a6232-fbae-49b6-6696-08d9e6254ceb
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Feb 2022 08:23:32.7372
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: jh072d5CrUkY13hunhuLo4f4RuwKm3t6/s9mOdotJ9wNIL4UGHFHKagQLIiYs9CyKwWdTIL3zIPOdRBOmPvZGTvKUbgmFeuLMshC8vVx63xQhlZY7hNpltvs8nJgAFwm
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR03MB5568
X-Proofpoint-ORIG-GUID: mxSjUUYPFUpTwzcrL-LzHeVRtVzm34Nt
X-Proofpoint-GUID: mxSjUUYPFUpTwzcrL-LzHeVRtVzm34Nt
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-02_03,2022-02-01_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 malwarescore=0
 impostorscore=0 lowpriorityscore=0 mlxlogscore=999 suspectscore=0
 phishscore=0 priorityscore=1501 clxscore=1015 adultscore=0 spamscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202020042

SGksIFJvZ2VyIQ0KDQpPbiAxMy4wMS4yMiAxMjoyMiwgUm9nZXIgUGF1IE1vbm7DqSB3cm90ZToN
Cj4gT24gVGh1LCBOb3YgMjUsIDIwMjEgYXQgMDE6MDI6NDVQTSArMDIwMCwgT2xla3NhbmRyIEFu
ZHJ1c2hjaGVua28gd3JvdGU6DQo+PiBGcm9tOiBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyA8b2xl
a3NhbmRyX2FuZHJ1c2hjaGVua29AZXBhbS5jb20+DQo+Pg0KPj4gVGFrZSBpbnRvIGFjY291bnQg
Z3Vlc3QncyBCQVIgdmlldyBhbmQgcHJvZ3JhbSBpdHMgcDJtIGFjY29yZGluZ2x5Og0KPj4gZ2Zu
IGlzIGd1ZXN0J3MgdmlldyBvZiB0aGUgQkFSIGFuZCBtZm4gaXMgdGhlIHBoeXNpY2FsIEJBUiB2
YWx1ZSBhcyBzZXQNCj4+IHVwIGJ5IHRoZSBQQ0kgYnVzIGRyaXZlciBpbiB0aGUgaGFyZHdhcmUg
ZG9tYWluLg0KPj4gVGhpcyB3YXkgaGFyZHdhcmUgZG9tYWluIHNlZXMgcGh5c2ljYWwgQkFSIHZh
bHVlcyBhbmQgZ3Vlc3Qgc2Vlcw0KPj4gZW11bGF0ZWQgb25lcy4NCj4+DQo+PiBTaWduZWQtb2Zm
LWJ5OiBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyA8b2xla3NhbmRyX2FuZHJ1c2hjaGVua29AZXBh
bS5jb20+DQo+PiAtLS0NCj4+IFNpbmNlIHY0Og0KPj4gLSBtb3ZlZCBzdGFydF97Z2ZufG1mbn0g
Y2FsY3VsYXRpb24gaW50byBtYXBfcmFuZ2UNCj4+IC0gcGFzcyB2cGNpX2JhciBpbiB0aGUgbWFw
X2RhdGEgaW5zdGVhZCBvZiBzdGFydF97Z2ZufG1mbn0NCj4+IC0gcy9ndWVzdF9hZGRyL2d1ZXN0
X3JlZw0KPj4gU2luY2UgdjM6DQo+PiAtIHVwZGF0ZWQgY29tbWVudCAoUm9nZXIpDQo+PiAtIHJl
bW92ZWQgZ2ZuX2FkZChtYXAtPnN0YXJ0X2dmbiwgcmMpOyB3aGljaCBpcyB3cm9uZw0KPj4gLSB1
c2Ugdi0+ZG9tYWluIGluc3RlYWQgb2Ygdi0+dnBjaS5wZGV2LT5kb21haW4NCj4+IC0gcmVtb3Zl
ZCBvZGQgZS5nLiBpbiBjb21tZW50DQo+PiAtIHMvZCVkLyVwZCBpbiBhbHRlcmVkIGNvZGUNCj4+
IC0gdXNlIGdkcHJpbnRrIGZvciBtYXAvdW5tYXAgbG9ncw0KPj4gU2luY2UgdjI6DQo+PiAtIGlt
cHJvdmUgcmVhZGFiaWxpdHkgZm9yIGRhdGEuc3RhcnRfZ2ZuIGFuZCByZXN0cnVjdHVyZSA/OiBj
b25zdHJ1Y3QNCj4+IFNpbmNlIHYxOg0KPj4gICAtIHMvTVNJL01TSS1YIGluIGNvbW1lbnRzDQo+
Pg0KPj4gLS0tDQo+PiAtLS0NCj4+ICAgeGVuL2RyaXZlcnMvdnBjaS9oZWFkZXIuYyB8IDMwICsr
KysrKysrKysrKysrKysrKysrKysrKysrLS0tLQ0KPj4gICAxIGZpbGUgY2hhbmdlZCwgMjYgaW5z
ZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkNCj4+DQo+PiBkaWZmIC0tZ2l0IGEveGVuL2RyaXZl
cnMvdnBjaS9oZWFkZXIuYyBiL3hlbi9kcml2ZXJzL3ZwY2kvaGVhZGVyLmMNCj4+IGluZGV4IGNj
NDlhYTY4ODg2Zi4uYjA0OTlkMzJjNWQ4IDEwMDY0NA0KPj4gLS0tIGEveGVuL2RyaXZlcnMvdnBj
aS9oZWFkZXIuYw0KPj4gKysrIGIveGVuL2RyaXZlcnMvdnBjaS9oZWFkZXIuYw0KPj4gQEAgLTMw
LDYgKzMwLDcgQEANCj4+ICAgDQo+PiAgIHN0cnVjdCBtYXBfZGF0YSB7DQo+PiAgICAgICBzdHJ1
Y3QgZG9tYWluICpkOw0KPj4gKyAgICBjb25zdCBzdHJ1Y3QgdnBjaV9iYXIgKmJhcjsNCj4+ICAg
ICAgIGJvb2wgbWFwOw0KPj4gICB9Ow0KPj4gICANCj4+IEBAIC00MSw4ICs0MiwyNSBAQCBzdGF0
aWMgaW50IG1hcF9yYW5nZSh1bnNpZ25lZCBsb25nIHMsIHVuc2lnbmVkIGxvbmcgZSwgdm9pZCAq
ZGF0YSwNCj4+ICAgDQo+PiAgICAgICBmb3IgKCA7IDsgKQ0KPj4gICAgICAgew0KPj4gKyAgICAg
ICAgLyogU3RhcnQgYWRkcmVzcyBvZiB0aGUgQkFSIGFzIHNlZW4gYnkgdGhlIGd1ZXN0LiAqLw0K
Pj4gKyAgICAgICAgZ2ZuX3Qgc3RhcnRfZ2ZuID0gX2dmbihQRk5fRE9XTihpc19oYXJkd2FyZV9k
b21haW4obWFwLT5kKQ0KPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICA/IG1hcC0+YmFyLT5hZGRyDQo+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgIDogbWFwLT5iYXItPmd1ZXN0X3JlZykpOw0KPj4gKyAgICAgICAgLyogUGh5c2ljYWwg
c3RhcnQgYWRkcmVzcyBvZiB0aGUgQkFSLiAqLw0KPj4gKyAgICAgICAgbWZuX3Qgc3RhcnRfbWZu
ID0gX21mbihQRk5fRE9XTihtYXAtPmJhci0+YWRkcikpOw0KPj4gICAgICAgICAgIHVuc2lnbmVk
IGxvbmcgc2l6ZSA9IGUgLSBzICsgMTsNCj4+ICAgDQo+PiArICAgICAgICAvKg0KPj4gKyAgICAg
ICAgICogUmFuZ2VzIHRvIGJlIG1hcHBlZCBkb24ndCBhbHdheXMgc3RhcnQgYXQgdGhlIEJBUiBz
dGFydCBhZGRyZXNzLCBhcw0KPj4gKyAgICAgICAgICogdGhlcmUgY2FuIGJlIGhvbGVzIG9yIHBh
cnRpYWxseSBjb25zdW1lZCByYW5nZXMuIEFjY291bnQgZm9yIHRoZQ0KPj4gKyAgICAgICAgICog
b2Zmc2V0IG9mIHRoZSBjdXJyZW50IGFkZHJlc3MgZnJvbSB0aGUgQkFSIHN0YXJ0Lg0KPj4gKyAg
ICAgICAgICovDQo+PiArICAgICAgICBzdGFydF9nZm4gPSBnZm5fYWRkKHN0YXJ0X2dmbiwgcyAt
IG1mbl94KHN0YXJ0X21mbikpOw0KPiBXaGVuIGRvaW5nIGd1ZXN0cyBtYXBwaW5ncyB0aGUgcmFu
Z2VzZXQgc2hvdWxkIHJlcHJlc2VudCB0aGUgZ3Vlc3QNCj4gcGh5c2ljYWwgbWVtb3J5IHNwYWNl
LCBub3QgdGhlIGhvc3Qgb25lLg0KU28sIGl0IGRvZXMNCj4gICBTbyB0aGF0IGNvbGxpc2lvbnMg
aW4gdGhlDQo+IGd1ZXN0IHAybSBjYW4gYmUgYXZvaWRlZC4gQWxzbyBhIGd1ZXN0IHNob3VsZCBi
ZSBhbGxvd2VkIHRvIG1hcCB0aGUNCj4gc2FtZSBtZm4gaW50byBtdWx0aXBsZSBnZm4uIEZvciBl
eGFtcGxlIG11bHRpcGxlIEJBUnMgY291bGQgc2hhcmUgdGhlDQo+IHNhbWUgcGh5c2ljYWwgcGFn
ZSBvbiB0aGUgaG9zdCBhbmQgdGhlIGd1ZXN0IG1pZ2h0IGxpa2UgdG8gbWFwIHRoZW0gYXQNCj4g
ZGlmZmVyZW50IHBhZ2VzIGluIGl0J3MgcGh5c21hcC4NClRoZXJlIGlzIG5vIHN1Y2ggcmVzdHJp
Y3Rpb24gaW1wb3NlZA0KPg0KPj4gKw0KPj4gKyAgICAgICAgZ2RwcmludGsoWEVOTE9HX0dfREVC
VUcsDQo+PiArICAgICAgICAgICAgICAgICAiJXNtYXAgWyVseCwgJWx4XSAtPiAlIyJQUklfZ2Zu
IiBmb3IgJXBkXG4iLA0KPj4gKyAgICAgICAgICAgICAgICAgbWFwLT5tYXAgPyAiIiA6ICJ1biIs
IHMsIGUsIGdmbl94KHN0YXJ0X2dmbiksDQo+PiArICAgICAgICAgICAgICAgICBtYXAtPmQpOw0K
PiBUaGF0J3MgdG9vIGNoYXR0eSBJTU8sIEkgY291bGQgYmUgZmluZSB3aXRoIHByaW50aW5nIHNv
bWV0aGluZyBhbG9uZw0KPiB0aGlzIGxpbmVzIGZyb20gbW9kaWZ5X2JhcnMsIGJ1dCBub3QgaGVy
ZSBiZWNhdXNlIHRoYXQgZnVuY3Rpb24gY2FuIGJlDQo+IHByZWVtcHRlZCBhbmQgY2FsbGVkIG11
bHRpcGxlIHRpbWVzLg0KT2ssIHdpbGwgbW92ZSB0byBtb2RpZnlfYmFycyBhcyB0aGVzZSBwcmlu
dHMgYXJlIHJlYWxseSBoZWxwZnVsIGZvciBkZWJ1Zw0KPg0KPj4gICAgICAgICAgIC8qDQo+PiAg
ICAgICAgICAgICogQVJNIFRPRE9zOg0KPj4gICAgICAgICAgICAqIC0gT24gQVJNIHdoZXRoZXIg
dGhlIG1lbW9yeSBpcyBwcmVmZXRjaGFibGUgb3Igbm90IHNob3VsZCBiZSBwYXNzZWQNCj4+IEBA
IC01Miw4ICs3MCwxMCBAQCBzdGF0aWMgaW50IG1hcF9yYW5nZSh1bnNpZ25lZCBsb25nIHMsIHVu
c2lnbmVkIGxvbmcgZSwgdm9pZCAqZGF0YSwNCj4+ICAgICAgICAgICAgKiAtIHt1bn1tYXBfbW1p
b19yZWdpb25zIGRvZXNuJ3Qgc3VwcG9ydCBwcmVlbXB0aW9uLg0KPj4gICAgICAgICAgICAqLw0K
Pj4gICANCj4+IC0gICAgICAgIHJjID0gbWFwLT5tYXAgPyBtYXBfbW1pb19yZWdpb25zKG1hcC0+
ZCwgX2dmbihzKSwgc2l6ZSwgX21mbihzKSkNCj4+IC0gICAgICAgICAgICAgICAgICAgICAgOiB1
bm1hcF9tbWlvX3JlZ2lvbnMobWFwLT5kLCBfZ2ZuKHMpLCBzaXplLCBfbWZuKHMpKTsNCj4+ICsg
ICAgICAgIHJjID0gbWFwLT5tYXAgPyBtYXBfbW1pb19yZWdpb25zKG1hcC0+ZCwgc3RhcnRfZ2Zu
LA0KPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc2l6ZSwgX21m
bihzKSkNCj4+ICsgICAgICAgICAgICAgICAgICAgICAgOiB1bm1hcF9tbWlvX3JlZ2lvbnMobWFw
LT5kLCBzdGFydF9nZm4sDQo+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgIHNpemUsIF9tZm4ocykpOw0KPj4gICAgICAgICAgIGlmICggcmMgPT0gMCApDQo+PiAg
ICAgICAgICAgew0KPj4gICAgICAgICAgICAgICAqYyArPSBzaXplOw0KPj4gQEAgLTYyLDggKzgy
LDggQEAgc3RhdGljIGludCBtYXBfcmFuZ2UodW5zaWduZWQgbG9uZyBzLCB1bnNpZ25lZCBsb25n
IGUsIHZvaWQgKmRhdGEsDQo+PiAgICAgICAgICAgaWYgKCByYyA8IDAgKQ0KPj4gICAgICAgICAg
IHsNCj4+ICAgICAgICAgICAgICAgcHJpbnRrKFhFTkxPR19HX1dBUk5JTkcNCj4+IC0gICAgICAg
ICAgICAgICAgICAgIkZhaWxlZCB0byBpZGVudGl0eSAlc21hcCBbJWx4LCAlbHhdIGZvciBkJWQ6
ICVkXG4iLA0KPj4gLSAgICAgICAgICAgICAgICAgICBtYXAtPm1hcCA/ICIiIDogInVuIiwgcywg
ZSwgbWFwLT5kLT5kb21haW5faWQsIHJjKTsNCj4+ICsgICAgICAgICAgICAgICAgICAgIkZhaWxl
ZCB0byBpZGVudGl0eSAlc21hcCBbJWx4LCAlbHhdIGZvciAlcGQ6ICVkXG4iLA0KPj4gKyAgICAg
ICAgICAgICAgICAgICBtYXAtPm1hcCA/ICIiIDogInVuIiwgcywgZSwgbWFwLT5kLCByYyk7DQo+
IFlvdSBuZWVkIHRvIGFkanVzdCB0aGUgbWVzc2FnZSBoZXJlLCBhcyB0aGlzIGlzIG5vIGxvbmdl
ciBhbiBpZGVudGl0eQ0KPiBtYXAgZm9yIGRvbVVzLg0KU3VyZQ0KPg0KPiBUaGFua3MsIFJvZ2Vy
Lg0KVGhhbmsgeW91LA0KT2xla3NhbmRy


From xen-devel-bounces@lists.xenproject.org Wed Feb 02 08:37:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 08:37:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.263843.456687 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFB91-00022C-E8; Wed, 02 Feb 2022 08:37:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 263843.456687; Wed, 02 Feb 2022 08:37:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFB91-000225-Aw; Wed, 02 Feb 2022 08:37:39 +0000
Received: by outflank-mailman (input) for mailman id 263843;
 Wed, 02 Feb 2022 08:37:38 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nFB8z-00021v-UF; Wed, 02 Feb 2022 08:37:37 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nFB8z-0005HO-RS; Wed, 02 Feb 2022 08:37:37 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nFB8z-0007ye-Dc; Wed, 02 Feb 2022 08:37:37 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nFB8z-0004At-D9; Wed, 02 Feb 2022 08:37:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=+/OG1pHUZyKlH8AwWBWveLnKtdRFJGaIVF5elO+d1Gs=; b=ldzGxcb2FsI1THf7AU/iiOzlRC
	r9YN8wXykfvoKX8Qdv8KHHselhO6BoWcEO/BEPKn+5UNfsmOM8ThU3jCx5agjaPigx8TVHTiLHxGk
	WiKk2npWDNYL/IUDJt8RmiWq+nDqjEkXS/T7Tuw4jT9vSG+XL+GmrDN7ojJq9CB+kF3M=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167980-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167980: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=017564d637e9c3051c2796d1d5b4d5df7179434c
X-Osstest-Versions-That:
    ovmf=5b3c682d91bd699a3144d36258565ccaa2036db7
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 02 Feb 2022 08:37:37 +0000

flight 167980 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167980/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 017564d637e9c3051c2796d1d5b4d5df7179434c
baseline version:
 ovmf                 5b3c682d91bd699a3144d36258565ccaa2036db7

Last test of basis   167976  2022-02-01 17:41:44 Z    0 days
Testing same since   167980  2022-02-02 02:46:38 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alexander Graf <agraf@csgraf.de>
  Ard Biesheuvel <ardb@kernel.org>
  Leif Lindholm <leif@nuviainc.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   5b3c682d91..017564d637  017564d637e9c3051c2796d1d5b4d5df7179434c -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Wed Feb 02 08:45:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 08:45:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.263854.456698 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFBGM-0003RM-AC; Wed, 02 Feb 2022 08:45:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 263854.456698; Wed, 02 Feb 2022 08:45:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFBGM-0003RF-5C; Wed, 02 Feb 2022 08:45:14 +0000
Received: by outflank-mailman (input) for mailman id 263854;
 Wed, 02 Feb 2022 08:45:13 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HAZh=SR=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nFBGL-0003R8-6I
 for xen-devel@lists.xenproject.org; Wed, 02 Feb 2022 08:45:13 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6d63fffb-8404-11ec-8eb8-a37418f5ba1a;
 Wed, 02 Feb 2022 09:45:11 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6d63fffb-8404-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1643791510;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=Svkr3g4I0IlUiRrpN97bOo4KOqfsvL537oiSq1vPLyQ=;
  b=DpjVyngbyL47BlnQU5/n1F+JNB8DAdCxi3VKgwMWzbKpHQaS5WkXtJ6s
   TUKKBQwnGmo1SabzxFaxLsc0O1syGmiM6ZmBUZf/WSLQ+iQU/+DGOQAks
   AtfVmm7XYuI8BxcER35doQxoCBqGDm+9pG3h9T6G3QrJhCjdkqHocB5ia
   4=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: LdmeYZvTmsolQRO6kAXOFtIinXGVr4kt+acDfSkSF6UvZNQaJRlpl02T16DQcMWqX1bFZc2f1P
 S2UmfniOytnDEBKYimTUk6dP+E2Muq7vz475p4wxJ3zKD2nPWLfYvM3HoJru5pNZfMXO3OBa37
 cGbbgiwKpNbo7MdEDmUr/JIqzeCsrUS0ZHdyj9d1G+jxH3tiRlWeZq221FKxvLFjBWRzTkyuqv
 AURMHmJELLlEYCXgxku/sPjoYf4CF0tdoVb1wpTV6YYoQcdm1Sm+xlqH7TU0NfcXWSy3Kf4pa4
 ashCZsh1lea0TGFwqFg96DJI
X-SBRS: 5.2
X-MesageID: 63214442
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:0eq5Ea7FuB7v6WwjtYut4QxRtBzBchMFZxGqfqrLsTDasY5as4F+v
 mcfCDiFbvuMNDT2eI8nPY3nph4OvZOGnYJgTlRs+S4wHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FV8MpBsJ00o5wbZj2tQw2LBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zk
 NhgpJnhV1kQGJaQ38UBAhRkPQJbFPgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALNs7kMZlZonh95TrYEewnUdbIRKCiCdpwgmxq35wSQay2i
 8wxQGdtdgjeQwd2G1ocVblgpvXzuiLNbGgNwL6SjfVuuDWCpOBr65D1OcfRUsyHQ4NShEnwj
 nzB+2P1ExQLLuuVwDCO8m+vruLXlCa9U4UXfJWy++R2mlSVyioWAQcPSFqgifCjjwi1XNc3A
 0sQ9yk1pK4+7nuiSNXnQga4q36JuB0bc9dIGuh84waIooLO6gaEAi4fTzhOaPQvrspwTjsvv
 neOm97qHjVpvKeiVWOG9ryUoDWxPgAYNWYHIyQDSGMt4dPuvYUyhRLnVct4Hei+ididMTj2z
 yrQ9HBmr7oWhM8Pka68+Djvkz+q45TEUAMxzgHWRX6+qBN0Ypa/YI6l4kSd6uxPRK6CVUWIt
 nUAn8mY7cgNAIuLmSjLR/8CdJmr+vKEPTv0kVNpWZ47+FyQF2WLJN4KpmskfQEwb5hCKWSBj
 FLvVR15vJJ+LX77c/FORbntTOU2nKXcO/fAf6WBBjZRWaRZeAiC9SBoQEef2WHxjUQh+Z0C1
 YenndWEVihDV/k+pNaib6JEiOJwmHhirY/Gbc2jl3yaPayiiGl5oFvvGH+HdagH4ayNu205G
 P4PZpLRm32zvAATCxQ7ELL/z3hWfBDX5ris8qS7k9JvxSI9QAkc5wf5m+9JRmCct/09eh301
 n+8QFRE71H0mGfKLw6HAlg6Nu+0Asom/CNmZHJ8VbpN55TESd33hJrzirNtJeV3nACd5aIco
 wY5lzWoXa0UF2WvF8U1Zpjhto1yHClHdirVVxdJlAMXJsY6LySQo4eMVlK2qEEmU3Tr3eNj/
 ezI/l6LEPIrGlU5ZO6LOa3H8r9ElSVH8A6EdxGWcoA7lYSF2NUCFhEdeddscpxVdEWemmDHv
 +tUaD9BzdTwT0YO2IChrYiPrpuzEvs4GUxfHmLB6q2xOzWc9W2mqbKsms7RFdwEfG+rqqike
 8tPyPTwbK8OkFpQ6tIuGLd316MuodDoouYCnAhjGXzKaXWtC69hfSbajZUe6PUVy+8LoxayV
 2KO5sJeZeeDNvT6HQNDPwEidOmCi60Zw2GA8fQvLUzmzyZr577bA15KNhyBhXUFfrt4OY8o2
 8k7v8sS51DtgxYmKI/e3CtV636NPjoLVKB+7sMWB4riiwwKzFBeYMODVn+qsc/XM9gVaxskO
 D6ZgqbGlo9w/EuafiphD2XJ0MpcmY8K5EJAwmgdKgnbgdHCnPI2gkFcqGxlUgRPwxxb+OtvI
 Ww3ZVZtLKCD8jo01shOW2egR1NICBGDoxGjzlIIkCvSTlWyV3yLJ2o4YL7f8Ecc+mNaXz5a4
 LDHlzq1DWe0JJn8jnkoREpoi/3/VtggpATNlfeuE9mBA5RnMyHuhbWjZDZQphbqaS/raJYre
 QW+ED5MVJDG
IronPort-HdrOrdr: A9a23:X2yfma2gS0XPFZC+Kz6L0AqjBShyeYIsimQD101hICG9Lfb3qy
 n+ppsmPEHP5Ar5OEtBpTiBUJPwJ0800aQFnLX5Wo3SIDUO2VHYVr2KiLGC/9SOIVyaygcw79
 YFT0E6MqyOMbEYt7eL3ODbKadZ/DDvysnB7o2yvhQdLz2CKZsQlDuRYjzrY3GeLzM2fKbReq
 Dsgfau8FGbCAoqh4mAdzM4dtmGg+eOuIPtYBYACRJiwA6SjQmw4Lq/NxSDxB8RXx5G3L9nqA
 H+4kDEz5Tml8v+5g7X1mfV4ZgTsNz9yuFbDMjJrsQOMD3jhiuheYwkcbyfuzIepv2p9T8R4Z
 TxiiZlG/42x2Laf2mzrxeo8w780Aw243un8lOciWuLm72xeBsKT+56wa5JeBrQ7EQt+Ptm1r
 hQ4m6fv51LSTvdgSXU/bHzJlBXv3vxhUBnvf8YjnRZX4dbQqRWt5Yj8ERcF4pFND7m6bogDP
 JlAKjnlbhrmGuhHjPkV1RUsZ6RtixZJGbCfqFCgL3b79FupgE486NCr/Zv2kvp9/oGOu95Dq
 r/Q+NVfYp1P70rhJRGdZA8qPuMex/wqC33QRevyHTcZek60iH22tXKCItc3pDfRHVP9up1pK
 j8
X-IronPort-AV: E=Sophos;i="5.88,336,1635220800"; 
   d="scan'208";a="63214442"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jr5dkQRWswLmcCAgy00CaKQzCxjHXxcHk1vr/JmZkFqUy9+UeDR5dFHZc0oAHa/mvG1ueFwgQdcRAdId35PK+tKt6p3FlKaF18EN16eS2qCe6+XQxsMfhh/HDnmpZUjsWhS1RMyHmlQxnNf7Z/J/fsFzISF5cqPdWPM3jnouLJ1WSu/xeijOa9RA4CIqEIi70P1X0aEsPdwwlgZ1mT7BrKdKt377P+UjaJ6czEwMLl8SPBHIhKcMi+oQPhZI5kDbKCHdRwEmNYOMPJeo+m6ToCxpgBS7ghVbrn5YzRR8YkZmx140pnDlKWpTtMIHh8uMQD3+sHYhYy1/9B41mOHB5w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=IFcgdBGfb4DtEg6ovNwaYcvVpsSukS5gpllFSMMnfyk=;
 b=D6B1KVED2cm4OyOfd9plLG80WjLefnfCUwoKwSNn7WnRBGGjVb2ToBdZ75SjjyLPJjruCtnJ5yGwgI0xhg80r1DJwkmc5gUpEnsvBtmalQrQWXEB2FZDgEfssQi7u8SwD5NKDJj2MBKunY4w8yVO6nVZEF/CYDOxWM2uNclxeAQFIUd7xdfCAKu1XgXWKD0IdQcw2V+tlSjpg7ZonJsYbGMczu6v4KZArpRYsmYeJCAh8gWiecUTRr14RclRGnR5hakA7lonCbW3+z2c49Uxjd8TjO2cGzpedLrA1Ik+4AvmHmkwfoLh3qRHgyrbs5tSsUl4zE4WJvIOB+vNngneug==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=IFcgdBGfb4DtEg6ovNwaYcvVpsSukS5gpllFSMMnfyk=;
 b=aLx8hJED7bLpOwkwLdUwjY7zV7L/0XhpKvx06e7RK3KSC2aN5J1uriCRnk3fifrRCOgzJyOv+vaTF0peoEhJiZcEUqj+pQX/gw43TRBYYzbLO0LjJhY4Wdn/XVpOEf7J1xaMwOvDigbunsJXPTWG/OsIQaUlxttmeOBNHnrAhl0=
Date: Wed, 2 Feb 2022 09:44:57 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Oleksandr Andrushchenko <andr2000@gmail.com>, <jbeulich@suse.com>
CC: <xen-devel@lists.xenproject.org>, <julien@xen.org>,
	<sstabellini@kernel.org>, <oleksandr_tyshchenko@epam.com>,
	<volodymyr_babchuk@epam.com>, <george.dunlap@citrix.com>, <paul@xen.org>,
	<bertrand.marquis@arm.com>, <rahul.singh@arm.com>, Oleksandr Andrushchenko
	<oleksandr_andrushchenko@epam.com>
Subject: Re: [PATCH 3/4] vpci: shrink critical section in vpci_{read/write}
Message-ID: <YfpEiWT0NpYNSAks@Air-de-Roger>
References: <20220201162508.417008-1-andr2000@gmail.com>
 <20220201162508.417008-4-andr2000@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220201162508.417008-4-andr2000@gmail.com>
X-ClientProxiedBy: MR2P264CA0192.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501::31)
 To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9a2301a4-ce7c-4091-013d-08d9e6284e3b
X-MS-TrafficTypeDiagnostic: SN6PR03MB4048:EE_
X-Microsoft-Antispam-PRVS: <SN6PR03MB40487DC9BA22711287C0643C8F279@SN6PR03MB4048.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: MnQGvMLbJG0dscIkc2UohiRC843eeEr7zjJNnasv9qYcOANRGmjFdFl7iCK8+8tNW47WuXJwdI6ftlPg44OjBVoFAQaeUpI3GM3AsPlKtB6FUnVUYMrPWSQ8dbPIoXixuww1jiPUi6eWH4UX2Ztgo4/UV6hyaapdYxd0fPRptdGH5qeOMK8vvX88zUGJnl+zKb0D+B3dji+RGlsSDDFa9H9bf7Xtl/HsYd2cgPydLr5siGhTxmsU6Fo0NOPkoanQ+U7nHOdXPCiss559oJJqkmG2ZB33zXF7YoHso/d7yvrCgNdHhwU0bwQk5m7ONGHGNAmg3qclQSXyV8xPYeGDBwAHNQCHcSue8nIrAeiA8YN2BA2gXi4NMYPQ4Bgjo1wFFv9glSzM2hZyEJh2hU50x3qgd2pBm+mR0ECUdggQvisD2c4eu63jtvloX7HV761xf2YExV3cCiAIN6i4Lr+O1fJ7SK5LiwBpkY9oB7GDidwQL8FMYgwC86KEx3DoqnVp+zRq+L+4H+Qca/GqjZofjmETEBOKSLSdTsssUfsxFK8H9ZyNVZBLFtz081yqxrydcFYMzKk67g2uPKCuScIymuCLVds4QwGmyuKAa9qIy/2C8nF/wnCWcacHDij103TTCRiOPnigbzXcpxxVr/wUuA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(7416002)(66476007)(2906002)(66946007)(66556008)(8676002)(4326008)(8936002)(82960400001)(85182001)(6506007)(186003)(26005)(33716001)(508600001)(5660300002)(38100700002)(316002)(83380400001)(6486002)(86362001)(9686003)(6666004)(6512007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZFFWZyttTnpVRGJHNW1zNURTUTNhaUIvQ2FPejhNR09MYlJFcXJOTjBabHJ1?=
 =?utf-8?B?cmpZT2tmY29hUkgvRndpcDlOUHRwT011UDRHeWJuRWRqOHNPUFM4U1RHU0ow?=
 =?utf-8?B?MHFaMkNoZGlsZkp0L2tQSUZuOC9UN3BXVitjS2lwVzVxbWhZaEVRUHlmYUh3?=
 =?utf-8?B?Vkp0Y2E1UDd4TFc4eFBKYkRjV3lvNC82Wm5iY3Vod1F2THB4T1lzcU40VUpP?=
 =?utf-8?B?VUd4dXdyQldVZEQ1THFZS1g4cElBZXcybDJ0dHZueDdlRFl4LzdYeUVBVUF1?=
 =?utf-8?B?eFp3N09lZ3Fndk5ROEsvTXRYYnZrQWp2ZjRQdnJLRmpHakpla0NmeFlMbyt3?=
 =?utf-8?B?aU1uODV3QzUwODk2ZzRnbWh1MmNnbVJaL3VvQlBsWEVaK2MrVE0vREgrVUx0?=
 =?utf-8?B?d09ORGhKaytVN1Z6WnFJV2JCRUc3cUZuMjdzMWNuVUVRaG5OMDRrUDZ4NnBu?=
 =?utf-8?B?eTFMazNwNy9sTk50cTlIeHpEMWxvY2F2S2lrWENvNUd3bGFQUHVzV0JqcXFM?=
 =?utf-8?B?UThnWTk2SVpHcENkdEdSeEQ0anVDSWYvMVE5d1UvbFE3R0REWERyUHUvS05s?=
 =?utf-8?B?QVVUTU5MZVcxbDJsL2dDQjJiK1pLR0t4K0RmclZ0bzRTMG1hTEZmcExibjd0?=
 =?utf-8?B?K2pNbTQyVEhzTVBrTVlWYWJNVmxSNVIvVzdmV3d5S1FiMy9MSGNPNmZYWXRM?=
 =?utf-8?B?QWdhczdIYlNwNFNPQWd6T2NnMUZaNlp2OG5abGxWcXY3SklKdDIxMGdCQWRE?=
 =?utf-8?B?ODF6dkFudTNHSjhydXJnT3dtYXVIUG55ekNNVithNjRETE13bWdxSCtpdWxT?=
 =?utf-8?B?a3dxTENHbFpvdjdlRGJpaGt2TkdPbXJuNklQdVUvY1pkWUlveG14UnpWK1Rt?=
 =?utf-8?B?VlQvdzZmUXJGQU16Z1NDbTZFMk9yUitNeDZZQjNDNjhsZE05ZjJKZXA2VkRq?=
 =?utf-8?B?K1NnNk4vK1dnM0RuSU5DN1hlS1hOVGN0VnFPTFJYM0ozWTRxNGJNM2ZlN0Yv?=
 =?utf-8?B?WFZVamw3VXNiV2dRMXJqRHZrUVlXZ0lUQVRrS0JMelh0SWVQS2Vwd3QzYzNV?=
 =?utf-8?B?RGZDYzFDS0lNL082M3ZueldEdXpuU0VtWDYwUWxlQlhSNGVLNXNDMi8zdFgr?=
 =?utf-8?B?ZmZXTjZFZS80SDRkZTAzTDRSLzA4ZkdyaEV3TG5wdVFhSmlvNVRsSEdBQjlj?=
 =?utf-8?B?QUR2SEJIcUVHNzZGb1krSzRkbDBZemw2d2k3M1RiNTVMVmRHbEpPL0x1YUVn?=
 =?utf-8?B?d2ZtVlRVZ3YzSnhPd3lQZVhHM3NUQUdZN0FDclFpZm9hcjZoR1Y4NE9ySXBK?=
 =?utf-8?B?ZVppanNrQVo1ZTBYU0ZnQzhhNjU2RFpZV050SFRlMGl3Z3JSTWhZaFJtRDl0?=
 =?utf-8?B?M1NVdy9lZDdreE1Hc3F1TVIxR21kaks2SlFBb3ljbWZHZ2hzbUUrcVBaWHI0?=
 =?utf-8?B?TnhhcnF1RjEwMXVpNG5ZQkszbkxPL2RiejM4dDVRVmlLRS93UGw4MmhJcGox?=
 =?utf-8?B?d1VwRjY4MmFMdG9QbWVsT0Nja1VhSzdSelgzWE9aemFVNWI0Q0xTZmZtV2VS?=
 =?utf-8?B?V094dTdWVnRkSTdMdGt6b2lPblNoYjRLcVRJMnBuWks3Tk5Cam9pL1lFWnNm?=
 =?utf-8?B?cUZHWVpKSTY4aTZXR0RaQ3hlRHRLOWRMYzBEWGhacUQyUkU4SlNPUHE0KzFO?=
 =?utf-8?B?cE5RbjN3MFhiYTFaL1lXYVZBN3U4MnhvY1M1dVo2U2VSKzI5QzBDSlNwY0VM?=
 =?utf-8?B?MllVR3JzSHR4eTNnOWM4Y3ZPbS9GRlpXUTd3aVhndHZMbDlidDBCTGVnQjB0?=
 =?utf-8?B?V0FYM3Fob0hqWGI0ais4L3JuRStYdHVLRW9rREFSSmFabTJ6ZlJBaFFLbzUw?=
 =?utf-8?B?elJaZW50blYvNEdWcmhtbWRsVCtpYkZUYTBOYXdjOG03cjRsRzFiQ2l4SVlL?=
 =?utf-8?B?Nkpvb3VsRmI4eUV6UFUyOTdhNWQ5VkFnRzJnNmtkUitKdklCQmtaODN6cXJk?=
 =?utf-8?B?NjZjUHV3U21JaTRuT1Y2YVZKd0hLS25JcTNHd3dLUlBpaStpUXJ2V0xhN2M3?=
 =?utf-8?B?U1ZzeXJrdWhvWXZsZCtRYzB0M0ZQdERXOXZsUm1zb1NKQisvQ0x2anRiK1c2?=
 =?utf-8?B?ZGFkUHR2WTE1N25tbUFKdXp3cGh4OFZtNmQ3ZURQRmRCRzJMaXVzWWRvV2Er?=
 =?utf-8?Q?fsCKH3bWHeU97vdGNJhCa0c=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9a2301a4-ce7c-4091-013d-08d9e6284e3b
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2022 08:45:04.0049
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ThXmhI6biQS+9YQSiMdiQ25UVDrsrij4H7iDJ+gUrJpu+Y0Rd5zN4Fqa4mTsqYhmIpW70QJW4AP8lG+Tn7uUhA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR03MB4048
X-OriginatorOrg: citrix.com

On Tue, Feb 01, 2022 at 06:25:07PM +0200, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> Shrink critical section in vpci_{read/write} as racing calls to
> vpci_{read,write}_hw() shouldn't be a problem. Those are just wrappers
> around pci_conf_{read,write} functions, and the required locking (in
> case of using the IO ports) is already taken care in pci_conf_{read,write}.
> 
> Please note, that we anyways split 64bit writes into two 32bit ones
> without taking the lock for the whole duration of the access, so it is
> possible to see a partially updated state as a result of a 64bit write:
> the PCI(e) specification don't seem to specify whether the ECAM is allowed
> to split memory transactions into multiple Configuration Requests and
> whether those could then interleave with requests from a different CPU.
> 
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

Would like to make sure whether Jan still have concerns about
splitting accesses though. Also since I'm the maintainer we need a
Reviewed-by from someone else.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Feb 02 08:48:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 08:48:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.263862.456709 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFBJL-00048q-V8; Wed, 02 Feb 2022 08:48:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 263862.456709; Wed, 02 Feb 2022 08:48:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFBJL-00048j-QG; Wed, 02 Feb 2022 08:48:19 +0000
Received: by outflank-mailman (input) for mailman id 263862;
 Wed, 02 Feb 2022 08:48:18 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nFBJK-00048Z-8B; Wed, 02 Feb 2022 08:48:18 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nFBJK-0005Th-5b; Wed, 02 Feb 2022 08:48:18 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nFBJJ-0008J6-Q8; Wed, 02 Feb 2022 08:48:17 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nFBJJ-000319-Ph; Wed, 02 Feb 2022 08:48:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=QM1/g8u96eEYWnqvzKBsW58ZuvUO+BDlktp1nytcGeQ=; b=dh4YyO2KaBH8lQmKkaZA3elHuV
	FrGMb7ccOKouVoPUz/ByAerTV2i1aQUOoWuylxqoJkXkSboc04eKdFl1EHHt8R9SOyeaQJUwoDXsf
	ST0GVcXeghleg59YNDO5t7cdR5gyQzEEFwqXQwJ8kMH7ACw99n1spRcM+Lvq4uZIOONI=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167979-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 167979: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=9f7fb8de5d9bac17b6392a14af40baf555d9129b
X-Osstest-Versions-That:
    linux=26291c54e111ff6ba87a164d85d4a4e134b7315c
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 02 Feb 2022 08:48:17 +0000

flight 167979 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167979/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167958
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167958
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167958
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167958
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167958
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167958
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167958
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167958
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                9f7fb8de5d9bac17b6392a14af40baf555d9129b
baseline version:
 linux                26291c54e111ff6ba87a164d85d4a4e134b7315c

Last test of basis   167958  2022-01-30 17:39:44 Z    2 days
Testing same since   167979  2022-02-01 21:12:14 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alain Volmat <alain.volmat@foss.st.com>
  Alexander Kobel <a-kobel@a-kobel.de>
  Benjamin Gaignard <benjamin.gaignard@collabora.com>
  Christian Brauner <brauner@kernel.org>
  Christoph Fritz <chf.fritz@googlemail.com>
  Christoph Hellwig <hch@lst.de>
  Dan Carpenter <dan.carpenter@oracle.com>
  Dongliang Mu <mudongliangabcd@gmail.com>
  Florian Fainelli <f.fainelli@gmail.com>
  Gabriel Krisman Bertazi <krisman@collabora.com>
  Gaosheng Cui <cuigaosheng1@huawei.com>
  Geert Uytterhoeven <geert@linux-m68k.org>
  Hans de Goede <hdegoede@redhat.com>
  Kamal Dasu <kdasu.kdev@gmail.com>
  Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Lubomir Rintel <lkundrak@v3.sk>
  Mario Limonciello <mario.limonciello@amd.com>
  Mark Brown <broonie@kernel.org>
  Mark Pearson <markpearson@lenovo.com>
  Maximilian Luz <luzmaximilian@gmail.com>
  Miaoqian Lin <linmq006@gmail.com>
  Miklos Szeredi <mszeredi@redhat.com>
  Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
  Patrice Chotard <patrice.chotard@foss.st.com>
  Paul Moore <paul@paul-moore.com>
  Randy Dunlap <rdunlap@infradead.org>
  Rob Herring <robh@kernel.org>
  Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
  Xin Tan <tanxin.ctf@gmail.com>
  Xin Xiong <xiongx18@fudan.edu.cn>
  Xiyu Yang <xiyuyang19@fudan.edu.cn>
  Yuka Kawajiri <yukx00@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   26291c54e111..9f7fb8de5d9b  9f7fb8de5d9bac17b6392a14af40baf555d9129b -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Wed Feb 02 08:49:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 08:49:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.263871.456720 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFBK7-0004h0-83; Wed, 02 Feb 2022 08:49:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 263871.456720; Wed, 02 Feb 2022 08:49:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFBK7-0004gt-4h; Wed, 02 Feb 2022 08:49:07 +0000
Received: by outflank-mailman (input) for mailman id 263871;
 Wed, 02 Feb 2022 08:49:05 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=6WyI=SR=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nFBK5-0004cD-D1
 for xen-devel@lists.xenproject.org; Wed, 02 Feb 2022 08:49:05 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f979f597-8404-11ec-8f75-fffcc8bd4f1a;
 Wed, 02 Feb 2022 09:49:04 +0100 (CET)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2108.outbound.protection.outlook.com [104.47.17.108]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-2-ja2oO9fLOHGNsCmMcofMGw-1; Wed, 02 Feb 2022 09:49:03 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM6PR04MB5111.eurprd04.prod.outlook.com (2603:10a6:20b:4::19) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.22; Wed, 2 Feb
 2022 08:49:01 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.012; Wed, 2 Feb 2022
 08:49:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f979f597-8404-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1643791744;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=ka3evPuYLhnNwNVZgIhb7VxqemjDCxXUOySBJWAlEGE=;
	b=aHfWXOantCSwzLeOHW61u3WqPeevVriuISsI/IrILYapnUGESBvDUTt9TV1PDVk+hp9Bps
	liVt4mPC+kdaTL8eo6UEoDwMIgwugNYV89WWauJ3oU+OWXC/plYVkfwmifA5c85kbQ0Sq2
	UVPG4eNK+mz4oa5jA034zWGPZpJcjQY=
X-MC-Unique: ja2oO9fLOHGNsCmMcofMGw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=W1140+XM0UMagsZCPfwwXVfriaexr5Ux73awan066/412RqF5dETDN+xGcmhmhK4qoRC2dUNgKp/Nl5exTQtkEM8+OyFS1xYK38U8LmoSKiUzobH+VIs95gdJFcCSnY58g9zg5AXbGR9Dvap9V/4rwyGicm7v7oXuM8s/TnZE5DBTenJPFwLKPPEtcqHweEDP6NtvLYTBFRTcYgZ06ZZtEAArEPJ/9o8ZFXREIDHh8zyi3EYsbxiPIjbZSqJtSAJEm9AFnZSJa6L3AZmiYpFVGaf5ETRwofAmUR9M8Yf0guA6D/weeyknBFzy29kU5w2MFmzrxigL0UglZ6KnmMkAw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ka3evPuYLhnNwNVZgIhb7VxqemjDCxXUOySBJWAlEGE=;
 b=bLMIwQkMNhmmh80HV7GxAePk87KMf1d0FgNKGi3tNCriAhUYbG3P3mOPrwtq5nVq1OcfpQ0qwmB5SbFn5RBwql2I44D8HvujyEmWDypwe93HqoNkLZu0AwyPhbjSF1F5xCji0CZ7JCQJ3v1agGt6UazS1NOwWk3xdFM1EG01GNgZeI/cXaa+Dvs0v0zGldJoczG0zPD23nRtd2mRnbvHKwUDzKHRwWgP8edsRFtWez0/dKNi1pdEj7cGS+6374ij0RuqqQYcWozbByuManzte5/T4mrZUeKEkhA7kguZDl46nL9YXa0PfEBVu+AQTmfhP/K6gTCcPP/NN0ZhxsM9jw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <5be7a1d9-0d59-d099-a5ab-f4ca550de78c@suse.com>
Date: Wed, 2 Feb 2022 09:48:58 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH 0/4] PCI devices passthrough pre-req patches
Content-Language: en-US
To: Oleksandr Andrushchenko <andr2000@gmail.com>
Cc: julien@xen.org, sstabellini@kernel.org, oleksandr_tyshchenko@epam.com,
 volodymyr_babchuk@epam.com, Artem_Mygaiev@epam.com, roger.pau@citrix.com,
 andrew.cooper3@citrix.com, george.dunlap@citrix.com, paul@xen.org,
 bertrand.marquis@arm.com, rahul.singh@arm.com,
 Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>,
 xen-devel@lists.xenproject.org
References: <20220201162508.417008-1-andr2000@gmail.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220201162508.417008-1-andr2000@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR05CA0001.eurprd05.prod.outlook.com
 (2603:10a6:20b:2e::14) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 0665b915-dead-4980-d119-08d9e628dba6
X-MS-TrafficTypeDiagnostic: AM6PR04MB5111:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB5111CCBDE8063278AB2F6B59B3279@AM6PR04MB5111.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1051;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	gm+e80knnKOKt2+AagYd7k15ArkIrmqPu6oYVkI6wJ+p8ncyimfvv0NJOZQALDN0detdA5TspqRipSQtk3gYr91FTodzk7bC3lfNrXj9uNu+tnkC3jMwc0QfB0tZ6JyERJVN9NDXCWqKyyoNX+msaAzHRmM+lKxQCB2n1hhUZ5b49a0gd6iKr8+jYSR9OKBok4ZOSipC56X0HMWaU/87Ru0aovycIlDJYD5klDQnqnhr7VyrxDWZswx8DYg7HgxyRbjhMt7cfXHql70+qFFdiho1207WPfzEEmftHiu0IY7BY1S8tMuK5VyankIg/ekFTvX6RaA0Wuke+XAIlp/pQIJfDNl0o3hH617Bv1/k/epyWRWmw3s0IQwuOKrdwaCSii7vlrGNIP6XK9C93BKr9LYQ4JTTob7ofPssZMP0mkeV+/Tn6qShqC6VzuvohmJ1lJ5p6bopmvATyb5WNvD8WVyOFDoqcd9Oj4hfHO6tf/a22l3f9I1G68PjmeaELO+CjKCFVmg4QcED9ZcrGJWwGdtTxFAXACBs29CtxkA7fF8hLb17RLiKF2dP9oCi0YOjDG3pIxAW71zXfQh4XbY4AzC8LhYgd2Kh+WOu51JZf/TlwSiA2Z1+QrCFcwq8pJKeGPVQ7Okh10YxlyVY+1PWYPNxJQb7OpAvi4zg+okRlAO6WzsZVauXOh8z7L2UIWlWMVEvz8WpFm1G0F3S1haszmYfcVUCXvuDKafsHTwN2UhwOnzXTB2xoZv9q+lLcoKV
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6506007)(6666004)(6512007)(186003)(53546011)(5660300002)(83380400001)(2906002)(4744005)(2616005)(26005)(7416002)(6916009)(31686004)(86362001)(316002)(508600001)(66946007)(66556008)(31696002)(66476007)(8676002)(8936002)(4326008)(38100700002)(6486002)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aTQ4Q3hmdStYQytLd01KM0hTWUxhRzgxdEtyS2J1b0NuMHFBdFVBa1g3cUQz?=
 =?utf-8?B?SmpjU3daRzJoZlVwNkR6VDJodDd6Y1l1KzJHcnlmKzRPbmdQemttZDdtZ3lE?=
 =?utf-8?B?aXU2a2o3eUozRHRURGdHdVgrRU8yRlBpMHVzZjBVKzJNOGtZYm81VWpjWUhh?=
 =?utf-8?B?MUJQcloyZnlZMWwwKzFZVVVJamlBcXAxMTFzakhGYzc3dzQ2c0Q0WDN2Qnlt?=
 =?utf-8?B?RGk1dUFJZHhMcWtIMjAvSGQwaFFRa2dBU0h3bnJieloxZlFMbUNITFhKQ3ZD?=
 =?utf-8?B?L0tPbktTZ1M0OExlNVAvM3VkYkc0NlhXMldrYldLMC8yWXh4cDFta0xnUjgy?=
 =?utf-8?B?cEttYmxKMWV5MGt5aDNFSGgzQW9hdDk4RkVxeGk2TEFLbmM1akpFMTgrSnVp?=
 =?utf-8?B?WTNrVzR4SHhqTW9sZElEU3Y0T1kyRENQMmNPdE5jaHRIYldsck5iOXk3dXd2?=
 =?utf-8?B?bVY1MWxzdmxuWWwwODE1dWNHbGp4dmxiVnBoRE5DRExBa2g5SGxXMGd5YmpW?=
 =?utf-8?B?WklZdjBORndYQ3g5S0hlVTNwOEhGQmxPQ0NBRjd6Z0ViTE9Ka2E5clNyMGVO?=
 =?utf-8?B?TnVNUkdxWWNZUGZKYkF3eVVuYTZsU2h4YVFXeis3eDRUejI2V1pEVEtvUjB5?=
 =?utf-8?B?VnJEWW1ja0hvbWFzaEtSRVJMZFR4WGdPL2E5UHY4a281ZjdsVVN3dkN1Qk5U?=
 =?utf-8?B?TzZBTForSmZUMERObnYva2duejEwbGJ1OVJIUzN3bFBEbkhBZ25KYWFrUDJZ?=
 =?utf-8?B?Y3cvM05SYjVpSk5HTTV4R2h1aWJqSGtUTmR4eUFxSk4vOWlPdHNZZ0xLYTFn?=
 =?utf-8?B?RWtpSXlmb1IzRUsydUxoYzlVeWRmTDR4eTZoNHFOOE85NlYxdlNVUXlqQkJh?=
 =?utf-8?B?bmRpRWx2bU9kTzlHRGNqbHdBQitMMXFOZVVDNGpxQ2RrQ0xKNUZVYjdsVUpU?=
 =?utf-8?B?d0g4MEY4dGw0UnFiL1NxVXlMUU50dHJZM2l0RWxhaWR2aWdsT3FWNXVQWVY0?=
 =?utf-8?B?TDkxMmpzNVV1S0VWbUxkdzZxSG1qcFdtN1N3WW5FclBpS0Uxa2xFR1VCd3Zp?=
 =?utf-8?B?MGR5bkN5eWYzbUZQQ2xnMHlWc1hUVzZQUjNmcVZMVFdJQWIycGs5UnV3dy9R?=
 =?utf-8?B?TnZwa0V0anRkVCtoOXJ5VW1hYmFMR2dhOS85YTlMaEJnelVsNVdpcXZFTGtJ?=
 =?utf-8?B?NXBvMjM5RWFwWWVqbzVRQ1NlYVNXaVVJTDJlRGtrMjRtU3VCazBDM002azc1?=
 =?utf-8?B?Z0g5dHV5N2FSMWVEL3grWU5uemFPMjNseHl3NStQQldPaktob05DQnhEQkx6?=
 =?utf-8?B?dkpaWjZNMnByQjVPMGF1L1RBT0NoYk1oUC9tMHYwRmZsWDRkcGpHTFZLREF2?=
 =?utf-8?B?ZmhCN2JEdnp6WHJsNi9qN24vTGhudEorUEVSVGZKWml3MU9OWlVyZHcrVFlP?=
 =?utf-8?B?WTN1blNaSjFzb0tMY1c5Qk5nUUJvamxEMkd4WkRHV20zR0FmeEtBQ3NBVi81?=
 =?utf-8?B?YmdwK2hZc0lrbmJBeDI0SUVCTXovR0FFS0c0WDZuVDZ4RE9SbGlnaThrdlN4?=
 =?utf-8?B?UVF3TlozVkxvZkxsMWZJaFJHQWd0RTN0YVVSaWlJUmx2R2NIZm1KdWpPbHRq?=
 =?utf-8?B?dmlZSzFDRGFGdEVjSmtQZWVxSnhUVHlaWHF0TEttWGk3SzNkT2dlcURvbDRt?=
 =?utf-8?B?VTdGVTRRYVpsclB5MzNpS3c3bHZkZnhGeXRJSHBqemQrUmFERzRIMmdZTWpQ?=
 =?utf-8?B?TGs1SUI5TEdvYjdXSVF0NmphRVBNWW42NDkwemtBNkFncEFrbTlrZWM2NmZm?=
 =?utf-8?B?UG43eGdiOXk0MWQxd1lQZHhiaXJ6cVpDeEV3RzFWT3pOMWc1SGZ0bnBqZTU2?=
 =?utf-8?B?RHRudDNIcEdCQWxiRWtGZE9MVWVIcFg3OSttMVVSRS9UR2dVZXVjWnBCVmRq?=
 =?utf-8?B?eDFCakxWWUIwNVZ4UHZyV1NHQlIyeWFzV3pHQVdZT0Z0eUhuRmdrWTlpZTMr?=
 =?utf-8?B?ZWhkYXpMTmVwZ0RRajFqUFQveE0rVUliZGZDaVZOaUViN09xZXhkbmZwYTdJ?=
 =?utf-8?B?RlpzeXpVSFNraHR6RzdPUU1ycWI2NjhHcUJZRUZjbEJkenFWR3JxNlZSdlQ3?=
 =?utf-8?B?eXR6Y25RRG00VzN4OWpvWlNBemFJQkFkMzY2eTU5VVp2SHBTaTFoQ0tDZklk?=
 =?utf-8?Q?MjQtqKcF/sMr6O/itIgMIZE=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0665b915-dead-4980-d119-08d9e628dba6
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2022 08:49:00.9421
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FMZ8+0ohnvIjSF1fBRRcnRHcWnlW0/dvQpetmRqLCADexxHvTY/mpIDOKpk2Pqj9bSnSH7qEs6FARs0GcoL6ow==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5111

On 01.02.2022 17:25, Oleksandr Andrushchenko wrote:
> Oleksandr Andrushchenko (3):
>   rangeset: add RANGESETF_no_print flag
>   rangeset: add rangeset_reset helper function
>   vpci: shrink critical section in vpci_{read/write}
> 
> Roger Pau Monne (1):
>   vpci: move lock outside of struct vpci

Btw, while I'll let Roger judge for the latter two, for the former
two while I appreciate you breaking this out from the larger series
I'm not convinced these will want committing without a user
appearing at least in close succession. Hence also why so far I
didn't commit patch 1, which as per its tags could have been put in
already.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Feb 02 09:04:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 09:04:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.263880.456731 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFBYo-00071R-Cf; Wed, 02 Feb 2022 09:04:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 263880.456731; Wed, 02 Feb 2022 09:04:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFBYo-00071K-9S; Wed, 02 Feb 2022 09:04:18 +0000
Received: by outflank-mailman (input) for mailman id 263880;
 Wed, 02 Feb 2022 09:04:16 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1p3Q=SR=epam.com=prvs=40324c57ab=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nFBYm-00071E-DO
 for xen-devel@lists.xenproject.org; Wed, 02 Feb 2022 09:04:16 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 177c06e3-8407-11ec-8eb8-a37418f5ba1a;
 Wed, 02 Feb 2022 10:04:14 +0100 (CET)
Received: from pps.filterd (m0174679.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 2128xLwr030539;
 Wed, 2 Feb 2022 09:04:06 GMT
Received: from eur05-vi1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2174.outbound.protection.outlook.com [104.47.17.174])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3dypx4g0pg-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 02 Feb 2022 09:04:05 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM0PR03MB6305.eurprd03.prod.outlook.com (2603:10a6:20b:157::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.11; Wed, 2 Feb
 2022 09:03:43 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6%3]) with mapi id 15.20.4951.012; Wed, 2 Feb 2022
 09:03:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 177c06e3-8407-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=FlGSN8jOIM9nkQOaoUYBW+VZ9DVfGzYa1MAuKqOQ8n4TjXexIdrn9H5CyKr2r01y8wDH2jae3ioSktdlt7r6h4T6zwjpRgnyiD4kBzhCKK5EdwXOp8eIbdV1mrxdUn9Yh4d+jppWEkcJVF8VKGTxxC0utq3P9rMvGELXA8Lk2L4Ov9U00RBuyoVgDGUG6YRU71BwXBd9ON6h7kr5U+WGAZwuQKhJcslIFN7th6m53xFCFevIyq6FAlgi03mCMHPoxsdBX9XKcw7gr27waMdf5hdhTdbsr8d+lfiYhxyyEtZULivwM7hRK0UpRbpnG2bJnycOYb0n47Ls2hJckAcuZA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=i+KT4wm+7ICt7Rpnun5Yk3jRcuBS8sCIzjxZ/3iPc0w=;
 b=ogH0HU+JeksYbaF+IrRx3+5kBYMb7oU6CrgiawMK2bS+uw56t/Ba86rCsNMs8TcsuQ3+A6jygYo+G7jKCJROIlNfCYzlbHPHpiFwAuHMEJnhoFm1EIipIC8yxG7Mvs48qBYUOP4t0SRhTCCHUEvw9KSvpVo9GmB/tugrsIkzcboTjfo0NpUbeypF8BkclG8wQtSK9/LBF/AKTB+VOWzPScc4VP9tfqLOhKmmQwMhBbtIn9K8XVx+kO/TDcwOo3UB4tu5R32P1a4nF1CXd68ZIUw6Y8KlVeN4t7XDx9VGZyGVR6GlhtyM/AwWcc4S3q0RJYK6ddyYoLHWZd3CbtXjzQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=i+KT4wm+7ICt7Rpnun5Yk3jRcuBS8sCIzjxZ/3iPc0w=;
 b=EeyE9cyROR+NAuxNgtG1+3BX8c1C3wEX42n40DpetRifY4PSbFTaGYDtHhSGRu3uE30tOxfeTetdB+M/RK14+3F3HUpgTllBSu6YbC2oHh3xQPNp4D9FSn0mUgL4A5QYCIa4JcN8t2w6OJ6kfSwweoPFEbka5/lQEoBi91Oc66Seb/q4KRGW9aY/AkoFkHEoaSR5EB3vh2wsq2F54/JxFi7qOhkrQ1TQfWaVnXNY383bUgs6s85RTvWz67mV+UrnJisJP18IetlENzYxWIHyVzGQqZTAozseJB+G/36KoYF9Pjo8uXN2wwECzqoovBNuOiv7YjkZnyrM7HxsieBxPw==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "roger.pau@citrix.com" <roger.pau@citrix.com>,
        "andrew.cooper3@citrix.com"
	<andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com"
	<george.dunlap@citrix.com>,
        "paul@xen.org" <paul@xen.org>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>,
        Rahul Singh <rahul.singh@arm.com>,
        "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        Oleksandr
 Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH 0/4] PCI devices passthrough pre-req patches
Thread-Topic: [PATCH 0/4] PCI devices passthrough pre-req patches
Thread-Index: AQHYF4hNdg5dcISE9UKKPLIP6ozan6x/9F4AgAAEHgA=
Date: Wed, 2 Feb 2022 09:03:43 +0000
Message-ID: <c504ecec-ac59-f357-365c-df48129680a1@epam.com>
References: <20220201162508.417008-1-andr2000@gmail.com>
 <5be7a1d9-0d59-d099-a5ab-f4ca550de78c@suse.com>
In-Reply-To: <5be7a1d9-0d59-d099-a5ab-f4ca550de78c@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: eecb1236-173e-44af-540d-08d9e62ae9bf
x-ms-traffictypediagnostic: AM0PR03MB6305:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM0PR03MB630517CBDC0BD55B5ACE3AE8E7279@AM0PR03MB6305.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:3968;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 FiVKyuSJTX/Z1i0h2m/YxtmOhqGlDG5rorsfRhV9Y4W3lqHj4SnI0pKA/rtPurOh9qd9GzIN2PzzWiPdkounS9Cc6yb5DzBKErbXlE8z1WdN0DqnrM6/PKhtykCEQAeHXwB80bIsZCwwWykVF8M07/O1GSdBcD4vuJprLq0ZV5tjkvHpwV88GEtMQr4r/KP8Xq0cSSENh0ZVbH4733n5v6GF1cjQmuGyQfrv0Zjyn6URq6Gv9UtW1ILzJllxkINYsBp4SzrJeOh2XU7x2XlSnCUQ4H8jlrzGm0LrM1D4i8jflmWBZWOuy8McpKFPzxp2xA0QsF2oGv8G3PyioypPQv4ASMNwbMGRoUNhEONQchez0k/Ki5Iu1kFwmn5fxaOFAUhyhv/neCRVS2VEpod1dihSgERGKlyAWpORbaxzvfZaQMQEjW0a4sFJ+bVnLInKX+5mJWVv3PU+ZpM/sv0BHYHhW2jY4WauA1cSQqk6V/a0VFOL0jTIL2bzYpy0lM8owFF+zd1xGLnOvwpzEjfHz5GAYLd+4qZGzPg6BdHJV7YeV8PIYJh2X/YqKZr4PyZIlg8MN54WpBGcdz6cd4fDByhsUyNKF8hBnOVNCfWD/14T1cMvzS46+Zd27dkzmmoGfuyX1DwwESL5+uEM0D/JMjTWUWFz1nVMPKoTUzIre/a+F+UqxjYIYqIDA2r8rGyruiKlq7Fzz2YcimQkCixFDRYb0cM1YTFFw/vzKlfiME3XpqY80HBhVyoCYs6m8g2w
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(26005)(508600001)(86362001)(31696002)(53546011)(4326008)(31686004)(4744005)(6486002)(186003)(2906002)(76116006)(2616005)(122000001)(8676002)(91956017)(5660300002)(64756008)(83380400001)(8936002)(66476007)(36756003)(66446008)(7416002)(66946007)(66556008)(6916009)(54906003)(38070700005)(316002)(38100700002)(107886003)(71200400001)(6512007)(6506007)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?bmFEdGpzWnQ5bGFrcjZFazNlaDVUVEVpNXg1OENndEdoVTZlbzJTVkRNeFBy?=
 =?utf-8?B?ajFZMXVZY095Y3haM2RNMmZpSE11UlhkWEJ2VlpCOGwydUpyUW5semUyeFo2?=
 =?utf-8?B?Yi9rQ2s1Y1J5dnZVd3g3M3Rkdnh3MThRWWlIcjB1WHV4WUVIQytKSUEyOS9v?=
 =?utf-8?B?NWY5TUtyTDViYURrWDJSNjJFTEh4K1ZPWjVydFZ1VjNudHRkcHhnRlRqZUVr?=
 =?utf-8?B?KzJKVFE4dUxsM1VJY0Rwa1RGcVM4NUd4dGlFeXM4NG96cmtNUks0VWw1SW1y?=
 =?utf-8?B?N1V6UDBqVDA5YjdwQ0Vmdk5LL2FzRFZKeW11L1VOZFBwcXA2bTczU2d6dHcv?=
 =?utf-8?B?SkJKK2tEZXZHcXh6VGgwTXdSendFS1ArY2t4R0J0ektxbEcxRjdMYzNWc3gw?=
 =?utf-8?B?cEJBU1RHZ3QxVTRvTEp2TE5PRHpkeG1acFRLZUwyb1J6WDNWSFJzazdZSWpL?=
 =?utf-8?B?cmUxclNtZk16cWNVd29CTUhUc3NVTWRYMXlhWVpoSzJINHl5RFNWU0hERlZu?=
 =?utf-8?B?dGtQZ1FPMDEvL3JMVmc2by9EMk9TQVBLbVFWSzVEbldwcmh2SnNubTBvQk5H?=
 =?utf-8?B?WjhHQkU3ZElDU2xtakkxcXg4Z096SStOaDc5a2kvNnVHTy9lTFZ5T1hPU1JG?=
 =?utf-8?B?TnJNZHJFV3JwUkRDOWRlcW81VUp1U25oc0MweDJORE5zVjRyYVI2NUZqOTRz?=
 =?utf-8?B?NDNQekl5dnI2ck1GQUhGTWxNbGtVWE5DWVpYQWJMYUpuTEVtOFBBMzlqNDhv?=
 =?utf-8?B?eHlpV0d2OG80YkhSTnhqbVhMQjJTQ09jUWVOZUNpS0hCb0svcGZkUUhsR0VB?=
 =?utf-8?B?Mm1pWXF6NUpxbHlWNU41TGt3dVZueVhnZjRHRmZvaVN0R1crZEZtWFNuSW9h?=
 =?utf-8?B?WWhlenBvRDZjNE55RC9uUjZscTF1SlFwV1NYS0xaa2NzSlE1VDRwK0oyUHg0?=
 =?utf-8?B?NVlSc3ZyWXJiemgxc0RPWDYxSTBTaGhKeEZhSXBjUjgyL2NxakREcHNQWklN?=
 =?utf-8?B?amVsd1NoL2JtU0Y0d3R4d3RDeU12QmViWEpMMnRhdi90V1hRc3ZWN2RIM3gv?=
 =?utf-8?B?Zy9FZFAyVDhPclkydWVkaktXZmNoeCtEOHMwUXpCMU5KcVRsWmlUWkV3c1Fo?=
 =?utf-8?B?MVNlTTNMYjVjV3YvRHFDWHNteWRZR3lHY3VITUxJaVVEdHA0RW8wR2ZrakRM?=
 =?utf-8?B?TGNHMnR5TGRVMkEwUHR2SmpyLytUekZDOHlRRFplL1FMUm1XYXE4QS9oNHU1?=
 =?utf-8?B?dzV5QnFvS3ladE1saHZnaHprYzRVOC9IcG41ZnA4UWM5eUplbXFHVFRhOE1S?=
 =?utf-8?B?Si8zZEU2TXdyQ3dZMW1HbHdDemJrUXhEaDBqdHZIQk81V0MvT3lnM0pkc2sw?=
 =?utf-8?B?TDY5d3FpSmtLNUtkbUJXNTc5L08zOG1GMk9pU2k4Mms3Rjkza3JTbEhlQ1pk?=
 =?utf-8?B?VXRsVVowNGkxeEpEbjdNS0pvVTBzMkc1RTVOUWJqWlZZZldzSkRXQU93SWRS?=
 =?utf-8?B?YWZIVGgxc2t3alhJVFZIdEd3ZmIvcTRMSncvT1UybHJmMDZOL3ZHTlF1SE53?=
 =?utf-8?B?R3lYb2tTQXIzenloQk1kbTZoTjNSYVF1WFYvcWRvQ3JKUTZKdHRkUGtEWk44?=
 =?utf-8?B?RVM3anB3aXpwQmcwbzBMTGoyR1JINWZzUzNXdHJ2ZXNEcGZCREh0ajdYSWVH?=
 =?utf-8?B?U0F4S1dGRklyT0NpZ2l3ekhrU0pVODJKa3NwNktWT3dBYWNIODJyT1dEWjRa?=
 =?utf-8?B?V0JYQ1BQcEhqdGdmbkdjdFUyaWh2NXh0SFB4YytBeVFVMVNzMlhYNnRGWWp6?=
 =?utf-8?B?NS9wdzlhUWliNGhHZGJBODRhcjk1Y3lhTCtYRDNheDdyclhqb2I4cndoUW1Z?=
 =?utf-8?B?bkIydXJweVpVa1YyQUhxS2hLcDdjZ0E4K05VNkx0TE5mVFJQRkJqb2syYjlx?=
 =?utf-8?B?RDhXN2ZEaEZmQjh5alFaNHZpay80NzlCQjhrVzUwbjgrcjBEL3Npd1NhVlQ4?=
 =?utf-8?B?Rk5FcHBOTEVwM2YwN0ZuVkQxeVRxdGwzam5Sc0xtWFI2YmJHNkdkTjhOem5i?=
 =?utf-8?B?NFJFQmFUa2NNZnIzOUE5UXR4RElyZXdjRWNGZnJtZndKOHJiNTQ1ZDArOTRi?=
 =?utf-8?B?ZVZkL0gwNXB0ZTJocEtTQmNOQ1FsMHI3NWZ2SU15M2diZkkwdTFEaDE5Z2dV?=
 =?utf-8?B?K1dTMWRlZXV3cnVSQ0tLY3VtQnJIV3BERzFzQkRCUmI2MmpCOEx3Mi9xU3hY?=
 =?utf-8?B?QW5wZlpudEZGWXRmVnY3TkNZZGZRN0JPZHVuOHAvNWlYOFBiSUk5RkZrYkx1?=
 =?utf-8?B?cG54djh4ektPUW1UUUcwWUJQUitwZ0pwNnVJMkxxZHhPVVFoU2RhZz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <D16570BE60BC9842AA921194C780A1CA@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: eecb1236-173e-44af-540d-08d9e62ae9bf
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Feb 2022 09:03:43.3187
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 1EMur4ei5iQat3ZoR0KcJmsqH9/FTk5KdeH9g1H5UJ561EcSLG1mwVWHDrb/t3ScXz1ouZpPl1jT1wyIVpEMggjM7eE9FUWwuMYfmKDjXWJiXj2xTwEGCe0zc7J56gmU
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB6305
X-Proofpoint-GUID: 8RR3YaggSVw8w_owd815M_LNKWAT_3-N
X-Proofpoint-ORIG-GUID: 8RR3YaggSVw8w_owd815M_LNKWAT_3-N
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-02_03,2022-02-01_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 clxscore=1015
 adultscore=0 lowpriorityscore=0 malwarescore=0 bulkscore=0 impostorscore=0
 mlxscore=0 spamscore=0 mlxlogscore=743 phishscore=0 priorityscore=1501
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2202020047

SGksIEphbiENCg0KT24gMDIuMDIuMjIgMTA6NDgsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAw
MS4wMi4yMDIyIDE3OjI1LCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyB3cm90ZToNCj4+IE9sZWtz
YW5kciBBbmRydXNoY2hlbmtvICgzKToNCj4+ICAgIHJhbmdlc2V0OiBhZGQgUkFOR0VTRVRGX25v
X3ByaW50IGZsYWcNCj4+ICAgIHJhbmdlc2V0OiBhZGQgcmFuZ2VzZXRfcmVzZXQgaGVscGVyIGZ1
bmN0aW9uDQo+PiAgICB2cGNpOiBzaHJpbmsgY3JpdGljYWwgc2VjdGlvbiBpbiB2cGNpX3tyZWFk
L3dyaXRlfQ0KPj4NCj4+IFJvZ2VyIFBhdSBNb25uZSAoMSk6DQo+PiAgICB2cGNpOiBtb3ZlIGxv
Y2sgb3V0c2lkZSBvZiBzdHJ1Y3QgdnBjaQ0KPiBCdHcsIHdoaWxlIEknbGwgbGV0IFJvZ2VyIGp1
ZGdlIGZvciB0aGUgbGF0dGVyIHR3bywgZm9yIHRoZSBmb3JtZXINCj4gdHdvIHdoaWxlIEkgYXBw
cmVjaWF0ZSB5b3UgYnJlYWtpbmcgdGhpcyBvdXQgZnJvbSB0aGUgbGFyZ2VyIHNlcmllcw0KPiBJ
J20gbm90IGNvbnZpbmNlZCB0aGVzZSB3aWxsIHdhbnQgY29tbWl0dGluZyB3aXRob3V0IGEgdXNl
cg0KPiBhcHBlYXJpbmcgYXQgbGVhc3QgaW4gY2xvc2Ugc3VjY2Vzc2lvbi4gSGVuY2UgYWxzbyB3
aHkgc28gZmFyIEkNCj4gZGlkbid0IGNvbW1pdCBwYXRjaCAxLCB3aGljaCBhcyBwZXIgaXRzIHRh
Z3MgY291bGQgaGF2ZSBiZWVuIHB1dCBpbg0KPiBhbHJlYWR5Lg0KVGhpcyBpcyBmYWlyDQo+DQo+
IEphbg0KPg0KVGhhbmsgeW91LA0KT2xla3NhbmRy


From xen-devel-bounces@lists.xenproject.org Wed Feb 02 09:06:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 09:06:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.263886.456742 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFBaV-0007fp-Sa; Wed, 02 Feb 2022 09:06:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 263886.456742; Wed, 02 Feb 2022 09:06:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFBaV-0007fi-P1; Wed, 02 Feb 2022 09:06:03 +0000
Received: by outflank-mailman (input) for mailman id 263886;
 Wed, 02 Feb 2022 09:06:02 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=6WyI=SR=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nFBaU-0007fU-FW
 for xen-devel@lists.xenproject.org; Wed, 02 Feb 2022 09:06:02 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 579eb9f9-8407-11ec-8f75-fffcc8bd4f1a;
 Wed, 02 Feb 2022 10:06:01 +0100 (CET)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2058.outbound.protection.outlook.com [104.47.13.58]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-10-NXOM6CnOOXWQpImrHV4kvw-1; Wed, 02 Feb 2022 10:05:59 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM5PR04MB2996.eurprd04.prod.outlook.com (2603:10a6:206:6::29) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Wed, 2 Feb
 2022 09:05:58 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.012; Wed, 2 Feb 2022
 09:05:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 579eb9f9-8407-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1643792761;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=bodEIfNAta5lT/azx38LUKokU+eaK1hP+Iy2qPpiy6I=;
	b=CkPdZjtO3YHGUdPLky/o5+UQ1QxkAuTS35Dy7wn9qWVo6PLfil9CjrShyIusMcMRDHSva/
	ASPAOzkLdnQvbYvCN0tnWOHvnSB31KkfEAX7t1ObXsCM2SmsOfAle5EblMoM9npNuqnJie
	VA909qS5/2hDqkWq2Ux+w6ybuHe+5JA=
X-MC-Unique: NXOM6CnOOXWQpImrHV4kvw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=EKFHTS6vfvY6SuPCd+T3+45mJtftWtG3Bj2OsUx27uaCUPRm4mMv1wpbQX1Bd9jXdm5n9ZEr+iEDEww45HfneqRbqnskBl9hygKF7Gs7bjnFEpwJOB4049nyrnjEP912gw7TrayAfrKQ7CS84bxAbizXXav2vgQekSe9I7QopFGu+om5XaH82GQnqZ50SDYGBF9U5jiCkxn5EI4WJq1BCxTEpwDjIxVrginWJOKcKxcgdHzpPreyVQA4pozSeJ8DPqs83+IzebWp5gN9j/gxu+rST9iEmJ697D1fgAJBVkWa7re1RiumXxDBPab/yEVL7s9s0wvk8mD4wrB2g2yp1Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=h/YBpmxmbKgzLPZLm2sFypR7msJ3r+ccScFC6rDGFVk=;
 b=mfJvDslpIlpn6gTcX6mL4bOEcVBAi7UF5Cl6zAH+mk8qY9mpUGy1mQKeMVqGL6WO5BNHonkmFh29QGrCXGK1/cbFtPJRcHJc9A38ooKQLDSKuO4qGqIX/Wo2zvWpndWatp9VkDbxbxqGEczo1KWiidY7B5YDeP1pW/gbjLX+6Y6NQ8zIkya9w/igP0YnIS3M3j0ETXaLZFomadcnSelsFqpicI/phoL8qJKoKQDUrWRPhgO5g3Y/qs5GqDz+P+hIRQA09MoIIaPqZJ1UYohwJoXxQ5HaYAwb0585tp7FcHozWuz8FHF0pDxISD3KEvbPBQp9vj1yxoiqlA7RCkjkKA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <5ed821ac-0a38-3c1a-a28a-c46295c2ffb4@suse.com>
Date: Wed, 2 Feb 2022 10:05:55 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH 3/4] vpci: shrink critical section in vpci_{read/write}
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Oleksandr Andrushchenko <andr2000@gmail.com>
CC: xen-devel@lists.xenproject.org, julien@xen.org, sstabellini@kernel.org,
 oleksandr_tyshchenko@epam.com, volodymyr_babchuk@epam.com,
 george.dunlap@citrix.com, paul@xen.org, bertrand.marquis@arm.com,
 rahul.singh@arm.com,
 Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
References: <20220201162508.417008-1-andr2000@gmail.com>
 <20220201162508.417008-4-andr2000@gmail.com> <YfpEiWT0NpYNSAks@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YfpEiWT0NpYNSAks@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: FR0P281CA0087.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:1e::12) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 3f5911da-498d-4b0e-f553-08d9e62b39e2
X-MS-TrafficTypeDiagnostic: AM5PR04MB2996:EE_
X-Microsoft-Antispam-PRVS:
	<AM5PR04MB29961EE7E47C9A56A9CCECBEB3279@AM5PR04MB2996.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	chjc+xO5wJWekWMoqRMbH0Lik8Ts8BaMp9UkuylYCiF+2/UMfj1x/ALEeupb3XUAD84tEH88pQUlj6cVjWpxGINNlNlWjaoi4Wgrn8pCuMgq/lnxU/9YqtFqIcJ7ADS5Qd2QoGJ7TiCSSt8HzOIhuprIi8VZAU10c90Kamrc9wLaQW3uVVlioQXQWBtbVH4tk3tVaNc/DtwZxaYp2yTecvka/NfAsYG95609kE5151O2ara5lmF3ua4wbHfq2yp4dI46NA1lAav6gKwfPdRFMvnQLLNNROO3V54znuFQCsgZg5hbOhphGKnrriQwe7fXYER8e/RFdFy1VE7rWpj6zzqUWs6vqhaNtXVUcskjWTfKHK9+vGE7chGacmmzPcyRpFYPDOBRWmsvHczhfEfsyKrSjaYjhSinBG/j3gxVF5d0RxWrlh4qJI531Un2Z66D5nrQfMlgVrwPTKgE5IJG1V18U5x07XU6SgmLHQyCcQwKECKBBWvERUp23cMiHBVizQ2YusGM+ExFYJsAGVWIU9me7lpR5t9AJui8H6Zq6ulAvzyLGKSr3ZSNSwwvGe3q6g+URwOEpST5W4NONeMS1yqlRTXEOaUiXPq9b0Iy4FRSdOLOkNSuHYxJNpw2UWQ1sNlJ6s/9hJAfK1fzqdSFCDpQbAeLB4QSAeZjQFSXoI8OwUia03Imb9hPXwuuhxOaeaBGcMtMPiAAXA/qJAo12bIZHZNG2H1YM+9EQLPE+8QDO3IBLlTM0LG+1MmmTQA5
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(26005)(186003)(4326008)(6486002)(86362001)(66946007)(8676002)(66476007)(2616005)(8936002)(110136005)(66556008)(316002)(83380400001)(38100700002)(508600001)(31696002)(7416002)(53546011)(5660300002)(31686004)(2906002)(6666004)(6506007)(36756003)(6512007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?aLm84U0AWxYAAtAihveum6SlxsE7TqPVIH213deXZ5giseKVFkJehPBfB35s?=
 =?us-ascii?Q?2BPT4PEboIPzi8PrSAhAZ+wUzhQuSv8TdcDU2XYCqjjSl/vUhcSEsIWv6UGp?=
 =?us-ascii?Q?iX5GAvfk+YUUImN1K7jLdIMibxskkVCPsuyzGj4Ryyir2pmZJk6WDFF0mavp?=
 =?us-ascii?Q?esWYK9bDsx/zDl1TPh10ImA786HkIhEtVL61mEVsWCkfJDcH/QoeFJ0d3YLF?=
 =?us-ascii?Q?4g5jI5j0YEPBrkDONXBmSXH3xmLjtI8yNNy0vAl1xoM/oumCjrVYy8Vm7bY9?=
 =?us-ascii?Q?BXIrcTuqU2/vTsZKZdjbd44TjZG54Afcj54N142t+f+ym1/qghPVXSLIjxvS?=
 =?us-ascii?Q?p0FXQZTCrgTDuuhWNMSJI6/5ZSPi01dC3o3k8zRwxftSFeIKGzwyQDDfOCTz?=
 =?us-ascii?Q?NDeuLNqH4AOFLhG0STb7lh7GIMKuUYSJec0voJpDxkpudnI5QzgRw5b5i8GK?=
 =?us-ascii?Q?mpaw5BLnl0ptA1IGtnId1ObTjZi2lOXZJCVTKSG0iT1q/8HmonGP++dqNBju?=
 =?us-ascii?Q?RaJK9vKhTyI/sapRghIhVS+DDGMOiWGIklb149O/HiBTPpeA8Z0FgTChQpuT?=
 =?us-ascii?Q?1AhIz8L/0MChNLjmLoyCyZUz6kcJXSM7sBKC9fs3ozzSzdNZS5F5UBxjCZgQ?=
 =?us-ascii?Q?n/ATG2VI+eTNRLw+jlulwWRPWDVNI/Ph1yVf/Mf7eCFg5fMor9LkP6SLtcpg?=
 =?us-ascii?Q?65t/osemnzz/jPol6DkuGN1GE7g9L3UNAl+P7pHB7KvxlWWRoekUiu3ykazF?=
 =?us-ascii?Q?rBcl5rX02GaQLAB1i4o4ePQPg4TlnEvBdR46UD1uWXecT7WQiTmsEjaF5p24?=
 =?us-ascii?Q?nqj3/EdQkZyObXJNGl9S4NFGja/fNJXd5Th5nJW5azBKuPH/7qwZRkfiX2rK?=
 =?us-ascii?Q?fdiwSQqpPt5fOSXqIGknClC9DWOutssFGAg2rplxfp2KyrzATfWRQ2RseY3A?=
 =?us-ascii?Q?9uMdqBuyxOVSlBqudaOl6NHzrZAlckHm+KfKi/oX9gqrSsSkxJr2vswQ8apw?=
 =?us-ascii?Q?q59Ggk/3dE4bK1EszJjKh5TO/vCdL9Y+Z2SR/IhuO4kl8TRd0abALcnkePlk?=
 =?us-ascii?Q?Lzj+j11q7z9lSn4tCFM//vcLIFppt9eYOQRmG1pxD5fgmwMNnjM/j66uu9eG?=
 =?us-ascii?Q?RsqTorPxsa4phdGRvQoUAI6PXjTiG8UBeZ9eVSpwT/vsGaGWUf4N7uCgf6I7?=
 =?us-ascii?Q?8pMj5/9EezjXmzfgXrzCsUW6GKAXHFXe31KMjp/JRzy1AX/vjJvu6E6DNBIb?=
 =?us-ascii?Q?JIDc72/6KV17qxG9fyQ4BRiIQ6URETbP71eY7fWFc+5Etsb0gCXuB7l+pRYf?=
 =?us-ascii?Q?6IWsLdgW2UeHNE5DwOlP8nS+LLeSEfbfc1ATekwdkoYCrF+WUevQ9Hfqg5f9?=
 =?us-ascii?Q?Hrlt7mlHwZXguZSmuDyL7Ksc1WI2wFZrP+7utYkY2yf5wKKrZKk2tZu+VVFu?=
 =?us-ascii?Q?CtXjZ6XpSLfXuko2r1lWmTvIiU5YlAJtTR4bj2UNtvOSRanu0NjimKEbwibF?=
 =?us-ascii?Q?xevqPNbwo5r9IbShPp7k9ZJ8zR58Xhy2qUZ2LvoceuWT/KhevxcAsHwMVzzl?=
 =?us-ascii?Q?8Xyvh61XOzEIoPWBX1xVVUJJFNrT56y1jblCTECeD7n+cX2xBfzZ4iicUq6E?=
 =?us-ascii?Q?79FHvmeOlZIdXNh/VbkvEFA=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3f5911da-498d-4b0e-f553-08d9e62b39e2
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2022 09:05:57.9886
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oDJrU8tttz6rnlmmkQTqquqJaZ/4UrbwC3lu6W7DuwHXF79uTPcrqQ/YrVKwJuv+lBBezXCHUgQXyyBkBAymHA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR04MB2996

On 02.02.2022 09:44, Roger Pau Monn=C3=A9 wrote:
> On Tue, Feb 01, 2022 at 06:25:07PM +0200, Oleksandr Andrushchenko wrote:
>> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

Oleksandr, can you please clarify authorship here? The rule of thumb is
that From: matches ...

>> Shrink critical section in vpci_{read/write} as racing calls to
>> vpci_{read,write}_hw() shouldn't be a problem. Those are just wrappers
>> around pci_conf_{read,write} functions, and the required locking (in
>> case of using the IO ports) is already taken care in pci_conf_{read,writ=
e}.
>>
>> Please note, that we anyways split 64bit writes into two 32bit ones
>> without taking the lock for the whole duration of the access, so it is
>> possible to see a partially updated state as a result of a 64bit write:
>> the PCI(e) specification don't seem to specify whether the ECAM is allow=
ed
>> to split memory transactions into multiple Configuration Requests and
>> whether those could then interleave with requests from a different CPU.
>>
>> Signed-off-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>
>> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com=
>

... the first S-o-b, as these are expected to be in chronological
order.

> Acked-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>

I'll take your unconstrained ack to indicate that you're also fine
with this going in right away; see my reply to 0/4 as to the earlier
two patches. Please let me know (soonish) if I shouldn't make this
implication, but I shall wait with committing for clarification of
the question further up anyway.

> Would like to make sure whether Jan still have concerns about
> splitting accesses though.

I continue to be a little concerned, but as long as the decision is
taken consciously (and this is recorded in the description), which
clearly is the case now, I have no objections. In the end well
behaved OSes will suitably serialize accesses to config space anyway.

> Also since I'm the maintainer we need a Reviewed-by from someone else.

Reviewed-by: Jan Beulich <jbeulich@suse.com>

I'm not sure this is strictly needed though: I'd generally consider
a 2nd (later) S-o-b as valid stand-in for R-b, at least as long as
the 2nd author doesn't scope-restrict their tag.

One further remark though: The resulting asymmetry of the locking
(covering the "head" hw read but not the "tail" one) looks a little
odd, but I will admit that I don't see a good way to restore symmetry.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Feb 02 09:23:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 09:23:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.263895.456753 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFBqv-0001YR-BA; Wed, 02 Feb 2022 09:23:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 263895.456753; Wed, 02 Feb 2022 09:23:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFBqv-0001YK-84; Wed, 02 Feb 2022 09:23:01 +0000
Received: by outflank-mailman (input) for mailman id 263895;
 Wed, 02 Feb 2022 09:22:59 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=6WyI=SR=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nFBqt-0001YE-Qa
 for xen-devel@lists.xenproject.org; Wed, 02 Feb 2022 09:22:59 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b5db7590-8409-11ec-8f75-fffcc8bd4f1a;
 Wed, 02 Feb 2022 10:22:58 +0100 (CET)
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur02lp2055.outbound.protection.outlook.com [104.47.4.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-35-j6mh_N_rNZ--Yr20cVtsJQ-1; Wed, 02 Feb 2022 10:22:57 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DU2PR04MB8902.eurprd04.prod.outlook.com (2603:10a6:10:2e1::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Wed, 2 Feb
 2022 09:22:54 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.012; Wed, 2 Feb 2022
 09:22:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b5db7590-8409-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1643793778;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=C3FgSpAFmC/6n5eHJQiaNCxiCVxC6E41jAbdjHwgLgI=;
	b=m4IvCHput46kVqMlFnpcpCJoY8jrYktgVOmUbGsylbVZzONTaZZeaDoasms2Sok5GddGJD
	8tRhuPaZAsuNXbvWGyC4DcmMG/JSbtkJ1bg9HKjb7Wh7zGCf4zizclDW2tZ39zWdzxQiwA
	98qC+NyJ2qWi6e5EKnoh6RPHvmI8nC0=
X-MC-Unique: j6mh_N_rNZ--Yr20cVtsJQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=CFZB1c57sm5CMdlcQNb3/vZa6GfqHrmyusLLgIFl8+tOhIwCTEz6ObRGSq9u44T1rCtSVcQHZYkUXZa1+yWk2z74gE2uC+Weye09JGnsibqp9Qes9Mkg825JgH2Srw194c645JWsf2JQMxPYsotdGEYbdkDKXJgczclWdL3CE8yVDfeVLixMNIs/XwuAWp+DKTuniUXpyeOkD4/32SaHCfKm6uWdxyJn1snMHvqpnITKDAb3KwJtpc0n+w1K1c+HXzEb46XcKkcz7oyMl8s56hy9YQju/7Y/SekAEpfJiuLIPQv8RxhcBiWCkprtnqfWxQzEE11t20uDrj6sBbEN7g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=6d010bprS5cb8KzyWEqozQZY38xeveGQHFF/5nPemqw=;
 b=j9As4jHGh3ZLdeKslEBZlX8tE+KSxPf6Eb1Dx6FHdPQchNw2qAgXj2kYLXrTyGynwIl3joBMCuzSPDAk7PWCr9KmV3RdOFQwzyjSRCeneMCUw/inzEDu8GH9nPJou+8saVTBUze+j5DSRwqfErjpEtKhsnACbSj+MtK5braByjIkH6MvsIVJMyJ6MSd0/QLeyvb0NvAAm5ppJNlE5mHKU3ZpkhJtGXm9goPR8US4p9pk94/N/JqQMRQIxX+oVoSMC/krcVVY1n2DAjXqb0kiTkBmrBkxw8WQt77gMCkY/K94Gzo800ViSc+34IdLocBl0uTALdL/WsKoZrQND7iJuQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <fc3df33c-d1e5-8c74-01e9-7ea7cea41521@suse.com>
Date: Wed, 2 Feb 2022 10:22:51 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH 4/4] vpci: move lock outside of struct vpci
Content-Language: en-US
To: Oleksandr Andrushchenko <andr2000@gmail.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: julien@xen.org, sstabellini@kernel.org, oleksandr_tyshchenko@epam.com,
 volodymyr_babchuk@epam.com, Artem_Mygaiev@epam.com,
 andrew.cooper3@citrix.com, george.dunlap@citrix.com, paul@xen.org,
 bertrand.marquis@arm.com, rahul.singh@arm.com,
 Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>,
 xen-devel@lists.xenproject.org
References: <20220201162508.417008-1-andr2000@gmail.com>
 <20220201162508.417008-5-andr2000@gmail.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220201162508.417008-5-andr2000@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: FR3P281CA0077.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:1f::10) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 696fc09a-6b34-4430-ef30-08d9e62d9770
X-MS-TrafficTypeDiagnostic: DU2PR04MB8902:EE_
X-Microsoft-Antispam-PRVS:
	<DU2PR04MB8902AA4D0C7CD39E1DCDBE12B3279@DU2PR04MB8902.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	szrdVW3xingEjffFnkjZBaNeXG16bb53PhzW+Kud7PGMEEeiBoobCt5AvTg6TFGNBcYDpAVjeqD5KLXBUCdAmjvZsTpnor5rKXbk/AfvSkq22I1b0qgOjj7AC0H37gbo/q2oktSNJWY7zwHVLWgVF74Yb1Eps2XsTUU5TTbm6dKV3XjYKo7f1a8D4Usk/vmbXk3JDl8zageme2fMv8yqAWEZRql1fr3Z64xhzyUJjHTfjNu0IkjeYFA6ZqYznmlmMRuTKmS4L2omfTmOH46k01dIAF5gpS8YZF5NFDEK0yp5IE3Mw/FvPGVCFX46qUIG3lwg4euCEvyF6j16bw0o79grdGmQM3D65NQV7StEEnNvsY60AqyuLeqY/wy9Jzpca9NJLHhgw0pkWB191sQ+iExRXDPHu0WYeTRAYecLSiSodnijGOYg5FZp2DsFUhdyO5FmJSQ2moTui2l6L5cOOqiTFJI2Eury7AAuzJgYTzzjG/9asQi5N5RStPWSV1WQUs2cYrmAUzl6CeHA+eakRG+xB6BmboRcS5pC6HBqicC+l3lbGF/wzcPakjI47DLcOLLo6uswh6xvvRXKjEUSeukPFlkx80rgvg9YbcaJq3xcecKK7l2ugpW/5WmM9dr2iQSCxRHerWtfjnTKaU7rEgk/xnhgU2YaQUCCVE4GfRMSbJbQcqeQn1UrpAMZKHB5KIrhOkvS0FKy8q+q9IQynoJX9HAYWN9w1tGUycjZ6HG5PGPv6BGe5BWgQakqRXSkH8de7aIIAQDhbJij+b+KOUk58qILoMy4RwWAq5fvupHLSYBHoMF+tIMsYi/dp3bq
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(83380400001)(110136005)(36756003)(2906002)(66946007)(6512007)(66476007)(38100700002)(66556008)(4326008)(86362001)(31696002)(8936002)(8676002)(508600001)(6486002)(316002)(966005)(26005)(186003)(5660300002)(7416002)(2616005)(6506007)(6666004)(53546011)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?IFJbny5yB2kuWly8dai58yyHXKclxsxJPTXo8eAyO7Oq5m4TU/jffhlwNr/V?=
 =?us-ascii?Q?+noihNiA2hKxa83yk8YaeQ4WvbFuUROPfv+Dkfqn0aOClAIjPklg4gohHSEy?=
 =?us-ascii?Q?rl+ZCxK3NOdpqhkfEiBHhkvH7xo8QPlsLoaUYXkhRtfMHKsGkh7pM++kPvpd?=
 =?us-ascii?Q?6rM9xm4ZwgusxKMdSt1VEDY0YJ3Z2RgYPJMQCnSssvEjq5Bt+SyuqUPtE/xK?=
 =?us-ascii?Q?DnpD4UwQhAFUoQkoxsZoMwUMvK0cwY39K2EUlIS4iesjr9CmzcDRhzHbfPi1?=
 =?us-ascii?Q?Tota2p8alnypUg056CDndw3Cc7+hhiHvVYQBnR0q1/kCwShMLu1EVSHQmSDj?=
 =?us-ascii?Q?NwYDNH9A6aK3pwM05Mk1B7J3+ldWqC0+PUPbaSkccfkW9lbtKvWrf7BrpjWv?=
 =?us-ascii?Q?okKMwzVZX1DPRDAgo01cnqUQTwnG69VVOym2JzsgJ1qVr+c0HYPbeg9BHJhI?=
 =?us-ascii?Q?wPKt/Ej2cMTolzIAlkMtrehMJxrjAda04DjuzfnQvwXGEPeXkpEpH5HwPUv9?=
 =?us-ascii?Q?hgLvk9BZ2EW0/Rbc0MJhpXEphCLGMrvEjBLzHV02VACax3c6GYT8VRM8R34E?=
 =?us-ascii?Q?+8d9kuwIe2x/rG7w8flQITXHBJqspc9Sqlpmjyn9vipzqrDiTzuAKwH4vR6Z?=
 =?us-ascii?Q?AqnqCLnXb7u49MzPebI+0ubbHM6ysscJ12+I8YMHVKaLMemj0HMZFE0WzkKw?=
 =?us-ascii?Q?/otyyI0UpbrS4nud4+WNBWhHufEI3wBa7aCYatVkkrwf826GbgYWz51JTEZf?=
 =?us-ascii?Q?VY4bgvFy2c89CLxUHzm20e1ZtdDXlB6OS09WHO6auQBNV1zPQSa68VLCK7gm?=
 =?us-ascii?Q?z6QjX8cO4Gjm7mDs8FuPZVSCInCzCQEkwZ3MDxRnVXL5VRRL1qT67meliKAs?=
 =?us-ascii?Q?jwzjDlh8d75NpJLr83KR4w96neadKf+lij9a6Qjqm9RxejzgkgFm3YQHJDcP?=
 =?us-ascii?Q?d7ahzOmbrBJrxlmA+KPqDOY9fzeNSEFRfAePly+8x7zrIARQZ86hezuYaJxg?=
 =?us-ascii?Q?xASovLMN5duOJLTkekEYljYTnR3oS0Yj+TBQeIoJe5hGZLEhZ5+6G7dmODtO?=
 =?us-ascii?Q?MAHrNrpBOYnmGmIqCY2x6r0y5Tyiws1pE6PsfGtO496q6Sw+eWM/kh02WGeX?=
 =?us-ascii?Q?P0K5kgOL2bBnARCwgmSUdtisnuDdpc6RYGWPe1ifCupb7V8M130S8RUkZEx1?=
 =?us-ascii?Q?uF4cf+8PwcKeySJk9ptL5hVIzTzE0BinmOoaDwilyotI803aS5T6RKFuN3gz?=
 =?us-ascii?Q?WsgpgzFmH+qNth3LRescpGOorG9FQ1T+hy9At3ZxLMLTkMZGbdUhojS7J1/G?=
 =?us-ascii?Q?kYdRzhrxdKOVEJ9gBfHT2TG4TGeaqrhuX3Fq5A+k8e6rMiXTamPg2jg2SFPh?=
 =?us-ascii?Q?DkJJjfFYbrFn7YSYJRqsv8y0XrjHMW/+xOP7EgbGvO9thK82nO5yIvSeLIs4?=
 =?us-ascii?Q?kSJPjqfVOwi1DmZfZ8RRbWZL3zr/j6w/vOmAcYdk+Pu1K0281eqGFAV+B1zo?=
 =?us-ascii?Q?XEQGNZRQICZq8MKsbzkEsIE3w9FV11QvveMr8JBbAQpU/rkfSuRK8h8FODrc?=
 =?us-ascii?Q?5NMhml+Zmk/CfDcwwFf8vQHifLhmu8xhOGdx80otilqgrfVWmYNJK+S2k7py?=
 =?us-ascii?Q?dmL4gPK8T86lSpcMPm9Pyag=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 696fc09a-6b34-4430-ef30-08d9e62d9770
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2022 09:22:54.0500
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Lcaie914OXpKKHOOtMtPISJtEXuyUjFd26h3pinsLGsM2KGl5CSqWn7NJkuXJ4T4ckIdJCc7m5tn8f/BP3R0nQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8902

On 01.02.2022 17:25, Oleksandr Andrushchenko wrote:
> From: Roger Pau Monne <roger.pau@citrix.com>
>=20
> This way the lock can be used to check whether vpci is present, and
> removal can be performed while holding the lock, in order to make
> sure there are no accesses to the contents of the vpci struct.
> Previously removal could race with vpci_read for example, since the
> lock was dropped prior to freeing pdev->vpci.
>=20
> Signed-off-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> ---
> Cc: Andrew Cooper <andrew.cooper3@citrix.com>
> Cc: Jan Beulich <jbeulich@suse.com>
> Cc: Julien Grall <julien@xen.org>
> Cc: Stefano Stabellini <sstabellini@kernel.org>
> ---
> New in v5 of this series: this is an updated version of the patch publish=
ed at
> https://lore.kernel.org/xen-devel/20180717094830.54806-2-roger.pau@citrix=
.com/
>=20
> Changes since v5:

This is a little odd in a series implicitly tagged as v1.

> --- a/xen/drivers/vpci/header.c
> +++ b/xen/drivers/vpci/header.c
> @@ -142,12 +142,13 @@ bool vpci_process_pending(struct vcpu *v)
>          if ( rc =3D=3D -ERESTART )
>              return true;
> =20
> -        spin_lock(&v->vpci.pdev->vpci->lock);
> -        /* Disable memory decoding unconditionally on failure. */
> -        modify_decoding(v->vpci.pdev,
> -                        rc ? v->vpci.cmd & ~PCI_COMMAND_MEMORY : v->vpci=
.cmd,
> -                        !rc && v->vpci.rom_only);
> -        spin_unlock(&v->vpci.pdev->vpci->lock);
> +        spin_lock(&v->vpci.pdev->vpci_lock);
> +        if ( v->vpci.pdev->vpci )
> +            /* Disable memory decoding unconditionally on failure. */
> +            modify_decoding(v->vpci.pdev,
> +                            rc ? v->vpci.cmd & ~PCI_COMMAND_MEMORY : v->=
vpci.cmd,
> +                            !rc && v->vpci.rom_only);
> +        spin_unlock(&v->vpci.pdev->vpci_lock);

While I certainly see the point, the addition of this if() (and a
few more elsewhere) isn't covered by title or description.

> --- a/xen/drivers/vpci/vpci.c
> +++ b/xen/drivers/vpci/vpci.c
> @@ -35,12 +35,10 @@ extern vpci_register_init_t *const __start_vpci_array=
[];
>  extern vpci_register_init_t *const __end_vpci_array[];
>  #define NUM_VPCI_INIT (__end_vpci_array - __start_vpci_array)
> =20
> -void vpci_remove_device(struct pci_dev *pdev)
> +static void vpci_remove_device_locked(struct pci_dev *pdev)
>  {
> -    if ( !has_vpci(pdev->domain) )
> -        return;
> +    ASSERT(spin_is_locked(&pdev->vpci_lock));

While, unlike here, ...

> @@ -152,8 +164,6 @@ int vpci_add_register(struct vpci *vpci, vpci_read_t =
*read_handler,
>      r->offset =3D offset;
>      r->private =3D data;
> =20
> -    spin_lock(&vpci->lock);

... you did explain why you don't want to add a similar assertion
here, I think in return the function wants to have a comment added
that it's required to be called with the respective lock held. I
notice you did so for the declaration, but I think such a comment
would better be present at the definition as well. Same for
vpci_remove_register() then, obviously.

> @@ -311,7 +316,7 @@ static uint32_t merge_result(uint32_t data, uint32_t =
new, unsigned int size,
>  uint32_t vpci_read(pci_sbdf_t sbdf, unsigned int reg, unsigned int size)
>  {
>      const struct domain *d =3D current->domain;
> -    const struct pci_dev *pdev;
> +    struct pci_dev *pdev;
>      const struct vpci_register *r;
>      unsigned int data_offset =3D 0;
>      uint32_t data =3D ~(uint32_t)0;
> @@ -327,7 +332,12 @@ uint32_t vpci_read(pci_sbdf_t sbdf, unsigned int reg=
, unsigned int size)
>      if ( !pdev )
>          return vpci_read_hw(sbdf, reg, size);
> =20
> -    spin_lock(&pdev->vpci->lock);
> +    spin_lock(&pdev->vpci_lock);
> +    if ( !pdev->vpci )
> +    {
> +        spin_unlock(&pdev->vpci_lock);
> +        return vpci_read_hw(sbdf, reg, size);
> +    }

In this case as well as in its write counterpart it becomes even more
important to justify (in the description) the new behavior. It is not
obvious at all that the absence of a struct vpci should be taken as
an indication that the underlying device needs accessing instead.
This also cannot be inferred from the "!pdev" case visible in context.
In that case we have no record of a device at this SBDF, and hence the
fallback pretty clearly is a "just in case" one. Yet if we know of a
device, the absence of a struct vpci may mean various possible things.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Feb 02 09:38:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 09:38:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.263905.456776 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFC5s-0003Dw-Sv; Wed, 02 Feb 2022 09:38:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 263905.456776; Wed, 02 Feb 2022 09:38:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFC5s-0003Dp-Pt; Wed, 02 Feb 2022 09:38:28 +0000
Received: by outflank-mailman (input) for mailman id 263905;
 Wed, 02 Feb 2022 09:38:27 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1p3Q=SR=epam.com=prvs=40324c57ab=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nFC5r-0003Dj-55
 for xen-devel@lists.xenproject.org; Wed, 02 Feb 2022 09:38:27 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id dcf03928-840b-11ec-8f75-fffcc8bd4f1a;
 Wed, 02 Feb 2022 10:38:24 +0100 (CET)
Received: from pps.filterd (m0174678.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 2129EEWG005986;
 Wed, 2 Feb 2022 09:38:14 GMT
Received: from eur05-vi1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2169.outbound.protection.outlook.com [104.47.17.169])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3dyq55g43c-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 02 Feb 2022 09:38:13 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by PR3PR03MB6652.eurprd03.prod.outlook.com (2603:10a6:102:5f::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Wed, 2 Feb
 2022 09:38:08 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6%3]) with mapi id 15.20.4951.012; Wed, 2 Feb 2022
 09:38:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dcf03928-840b-11ec-8f75-fffcc8bd4f1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=lDMTBMUsNmafXnOXFrQdpDyKOMCM0Mmd0BwWF+tZp4F29Cgnr7RYSxJWZ+neXNmmW+XRIkzQMednmEeyfBTdrdRigFhzD8FR7+F/iqd9PlFWzS4/eFF02Qb8VBVt1VnMTocumCv4X0ou1Le8PbyS9/vFsT8nzudymwaSINQytdq+y7b9PZgUPr4QU3ovIoZXWkYMNsrk1eXaVtVVKNnboYazBvJ6+DbDamQXM9SJ841KU0QrOjJ+9/foYmq7syjzMBjuoVmtxuffzC0nfdAT4Jlh+gFn9lnpfoxpw4cZEWAtaJ++k+q9Dd1EM8vccjoYBgmgTHnc+EBV4Xfad1IxDg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=GBRvPtEtgxqSu2mxwcRM/E8VUzwcld2hq0NFrRgnua8=;
 b=NOz3gULKQ3jzLHN981PbpOE0qEpyXRziD+MvpBUdpbDFKtjUK0Jm4sauQQtyZ6UoPWd1feOUc8fli7aUTxUKJ6He2F4inAnXQ3StFG8vUks/fkLuNUCweSAYrrdvn5KpsMr1nST4YzANcuNMYhspe/u2waqd8OZhD8afXss+CXPw6aM2aYpYKMMg2l0V6zpNf07jsxpCVKFKA9xfpJVcUbOcFc8Fg7+Yt2sUPbChIw4Ws/EIz3JVNNmcsbyvecrzvx4slAzQi9wdeSixmkQAcjVvbiKGckzzw+oUykj8SNdM4WIGoZX4vB2lYTScntO4zIjfT25J+Ot+Feul24wyoQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=GBRvPtEtgxqSu2mxwcRM/E8VUzwcld2hq0NFrRgnua8=;
 b=JRUFQ6GlGwzHRZ6TqWFDpzyULTbtEzDTsEvD79Hz+GcgJPiBrHLOfENDrbjkbfstSvTZ7JiPHfIOvyTSZP8kr3c2GHgTgxHH12o1Mo1vEOtxXjsllAKQ1opYD1dw9ASYz7KiZXeaLhPRwCMrEUyuFaImZkmWdVx0KMU/tNNA8N8t0tNO8+NM+E+XBxXeZ+PEywE/76iyqvg+qBDHW37NSHhJXK+KIafy/EO0BHR075OwkA72EW9Jkm80WoacYFFgnID8i81zu2UPUU8lIp2wOjijtf+FOpkDrmyNjwO8g4KG7+mpySFgr2Klpj1S0rFpOeBkWCUzvR1AJxmzZbo6fg==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>,
        =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?=
	<roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        "george.dunlap@citrix.com"
	<george.dunlap@citrix.com>,
        "paul@xen.org" <paul@xen.org>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>,
        Rahul Singh <rahul.singh@arm.com>,
        Oleksandr
 Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH 3/4] vpci: shrink critical section in vpci_{read/write}
Thread-Topic: [PATCH 3/4] vpci: shrink critical section in vpci_{read/write}
Thread-Index: AQHYF4hObbqxIjaQNUeSdaSEPmZTi6x/8z+AgAAF24CAAAj/gA==
Date: Wed, 2 Feb 2022 09:38:08 +0000
Message-ID: <5ec87648-2783-d21a-ca7d-dc59180543d9@epam.com>
References: <20220201162508.417008-1-andr2000@gmail.com>
 <20220201162508.417008-4-andr2000@gmail.com> <YfpEiWT0NpYNSAks@Air-de-Roger>
 <5ed821ac-0a38-3c1a-a28a-c46295c2ffb4@suse.com>
In-Reply-To: <5ed821ac-0a38-3c1a-a28a-c46295c2ffb4@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 5f0d8cf8-169b-40b3-8543-08d9e62fb87f
x-ms-traffictypediagnostic: PR3PR03MB6652:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <PR3PR03MB6652EF3FA9786A6D2DF22926E7279@PR3PR03MB6652.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 2AWrG5sOwpPurVHpSTuNKL9qApiETJZ03icTtcsfg2VNGa3AQG7xIP5+SM8lKkdKzvKNR7kzITajRKIdhAa0NilWDpo32B1Ef1+BUCI1j4OdoXPybHJOMkJe3ULvRgJP788kmTrWocTEQF3Zys92M8537Jhmj3wJ7IuA6IGNSC2E/8v4sdhfOqWcxwGtCf/rojqFme5TR2RT/TfXNurZ2u22XEWB28GUaYrphFwotDZMNG5QVNAGhzN3J5iulAvokDgwXb/xVdok2ioNdbyp4n3BNXcu+FDoANx5T/XkjemZdKX+wv0WdYvs3HhFByFPuQ/r0+1QYUcE7Zm5TzTQzT73JltXbgY9iE3xVN1/IVyJU52MQMNnCISFBeFwXAgvYf99qeHjbIdYOfepPaP0HfJW+52LpAFof05Nrtd0zmF0xCVw/LPZfHpr/UZbQfY4zXzGo+Av9rcoYO5FXfCv+E4r3bpEQW0MgcRXTPOhmjSHIveSjcCdaEGzjdPRy1Y54Mr4UY2l/emv2dw2dVIRFENOwLGRRqlXs31D7D7wLQ62iroI0m7d/faO67aKt89T7ieJsKKapMEMqlSFbU2eSn/lI0Ab51esuzlFAi2imr6AETXhnIOZkZVPk74YimNaWA606an7QIvImCv7TWxs52HG6hUce1ggFFJ6RVEmK8dUwNLMXCSjbIcxSN378lV197VubBhOT6JVl1ZfSY5Z6zU262LLYR54ciaVXsYxlpvVBtW4SJSLvMtVGJUzSnc3cCHGVYy/IftYT1jcc53y/TXa1XET/Sv4A67Arvz3GuA=
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(186003)(83380400001)(26005)(2906002)(31686004)(5660300002)(36756003)(8936002)(8676002)(53546011)(31696002)(38070700005)(122000001)(110136005)(316002)(64756008)(66946007)(91956017)(71200400001)(4326008)(2616005)(107886003)(66556008)(66476007)(76116006)(66446008)(508600001)(6506007)(86362001)(6512007)(38100700002)(54906003)(6486002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?cURIVVlQRy91NWVReTA2eEVRYWNZWXM3T2xKTzZKMHo1bVUxSk52RDRBQjZ6?=
 =?utf-8?B?dDRuZkNzOHlsM3NYZENUWkRSQVpIUXZRRlpjcmpEc0piUnoyMCtRYmNubDFw?=
 =?utf-8?B?bXpnbFlVZkwxbjlYK24xbE9lYzFtaHVMdTBlMk9ZN1prc1JQSm5GRUsrRkhG?=
 =?utf-8?B?R3QwWGYvTnpwanhvV1hrMVplZUZRQlJjWnkrRFc3TWVZZ2pVWTA2NS9JWU1U?=
 =?utf-8?B?c25tN2lzWjZtTTRaZkN1MURidlJlKzVoQlhraWpGdGFEejNQK29WWGVwRGsw?=
 =?utf-8?B?T0JBaXJReTVTaVlxVWt4Q2ZocXFTa1RwUjYzdk1WODQ5STRPZm9CZVpVbXpO?=
 =?utf-8?B?UExBOGM1OWhZYlFWdnRFQTgrcWpCUjROVGZFQVlkMDR2Q2dQc3F1NnlWVGVD?=
 =?utf-8?B?Qis0NnpYTHdGdzdLeDc4N1pUUUpJTm10czdIMmExMzZlQ1NGSUZvb243OGox?=
 =?utf-8?B?MWl1WDF4ZVhvQVNkdndEdHcyTHpVTjdMQTcyeldwb2xxUmlUYXBQQTBtZHo1?=
 =?utf-8?B?ekZweG5ZS3dJUVVmTWgzVzU4ckZ2QjZ4VEsvdTNGVm90Y0pkS1JkSUtrSUVL?=
 =?utf-8?B?TEhwbEdwSlB2ZitjRUROU0FKSGo5bkVNQ2R5SzMybFd5S3Brb2pIU2piT1VV?=
 =?utf-8?B?RWR3akI5VkMxcmNLbnl6UkxKNWZqWUdUQyswY3RLRzBOeUhZc2lxQXRXbk9a?=
 =?utf-8?B?a3pBQXUvRVNjNDZiVEljQStjY0EvWHNEd0VVL2xRTjcwTEJKLzdua1A3MURs?=
 =?utf-8?B?ekZwNGtHU3NuVXU4R1VYUkJOb0FTSkpteHQ3UkJVOHFLaUZIOGUwOUZWd01q?=
 =?utf-8?B?NU01SFNzTEFuTk5WMFR5emdBY0RJYmxXWkEwUnl6ZDVNVDBaVGJodlMrdTVo?=
 =?utf-8?B?ZUZRZTRJQ1lCcW1qemgrUnVCbmlacTJ1QkhWS2Npc3I4dHJqTnl6NUFiRlA2?=
 =?utf-8?B?eVdmaUxvUmxOT0hZZEdOSFVMSXJoWFB5bDFMc010cEg2RGtUOUxZdUVocXJK?=
 =?utf-8?B?V1BDYmNZVXp2SnRWNWt0Zytxc1Z6ZlJWblRWMFJYb2psZyt1NkhoWmRGN29V?=
 =?utf-8?B?Njk1NGhBQnNiUklUTk1ydlJYVTlFVXFRSmlYd1ZWN21FWGJZQlFHeitLNUV2?=
 =?utf-8?B?bmZNWEtOMTZhdVQyRkFyZzJJS1Z1Q25vSTJ2TkNuRXNlWmloR1JvSzNtakQ4?=
 =?utf-8?B?cHJCSCs0eHhncENDQnYxaVUyY0pOa2JycEhGZFFYZzRYOTBRck5CK0swRWkr?=
 =?utf-8?B?TjBmUE5BRUZWdDJUcHBwdTlqdWZPTzhuRTRCUjNRZDFlN0pIdnEyeFlKTXl6?=
 =?utf-8?B?SWl1a1dSLzRPWHlPV25mSXdYcG1KVldCWkxUdnZHd0N3cUx6SjI2VC9qUlJ4?=
 =?utf-8?B?REV0STRDMCsvRXg4a0FyK3FKVG5EV1ZuWFBrRlpBMFhkN0ZWVGJ1OUZtV1dS?=
 =?utf-8?B?Z3pVM1dwZUxqTW5aVDRaQXJlcXl6cnR5eURCcXQxKzVJSEpMbnFtMGJUMUxQ?=
 =?utf-8?B?SjhxQ3VHb0dNOTdYVGljcldNaS9IOHdBbDlMUWVLK08zYWI2T3EyMUdZUXk2?=
 =?utf-8?B?NTdBWmxZcjFIZHQ4RllOTyt5SDNsYjB5ZzJNb1pQNy9SR3BFbG9FQVJYYnp2?=
 =?utf-8?B?YjZFVG9tVXNURlJpUndJK2ZMcmVvaVhMTmYvUnh5QWtjNnhOQTBsMXpLczdt?=
 =?utf-8?B?cys3M0pzZkpWblVXZEhLQjZoVlJZR1dZa0xUNUFJV3VTNEJCV0Rsazdqa0d1?=
 =?utf-8?B?eHplRDlxNjQzUDI0WmJwblBrVWFSazlKSndwajJlbTZpZi9qcHZoTUhQMnZY?=
 =?utf-8?B?R05aOXNlQll2c01GTmF4cjY4MldWUVo4SXo1MmU4QjB1b2FtYmxhcEtGUHJn?=
 =?utf-8?B?dzMzZ21iNmlPVVh3Ym82b2N6MWpLZ1VLM201bW9lSkZ1a0FIaEFRMU1lUEpE?=
 =?utf-8?B?WEl6ck5xekF3VExrcXN2T2VOOHRMT1NGQlEwbEpGWjVaNzhLNVNCSmVBVWlE?=
 =?utf-8?B?MWFvUUtwQU9Wa1lOSTZaSVJCOGFSYkZxTU1KTFNHMk82d2pHdUlRdWNoR29q?=
 =?utf-8?B?a3hUcUtUWktwSmoxTVBvYnd1MlBQM3Exa1lxWWJLdnpsMm1zejRaS3RNMThW?=
 =?utf-8?B?b2V4b2ZzOXRZUW9LckZKTlppUGRtTnRJcmQrSEJjT244K2x6RnpDS20wdEwv?=
 =?utf-8?B?UWVIUkdZNk9YMlhSR3FoUFVYYVFlUU04T01NZlQ0T1o0dm95TlhqTW85ZUlJ?=
 =?utf-8?B?M3U1QTZEMW53VFErT3VtWkl2K2RycUtGaHJEL1NhbXd2czFQNkFTaElZQUt0?=
 =?utf-8?B?Z09PaXhrSkJjaVg2blNsWDJxbGdZSjB2MG5QZ3NYT1o5akdocnJpQT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <0FC12A04115EBF458D1B11F6D39712DA@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5f0d8cf8-169b-40b3-8543-08d9e62fb87f
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Feb 2022 09:38:08.1602
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: PNGbC+wJtzYojUuZmII4UCevhWyAsBu38Jj/Q1wx2fkO4l4tSucx4GkfagMxJPGoeoSPNojL0HYpvMl0hbfJyTF1Cleo9jPktarfAkUXfePfLtyNJh4wOrEwCYGvsNmN
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR03MB6652
X-Proofpoint-GUID: Ix54LoGBQsHGCW7CHnVOb3-Yezd1uS89
X-Proofpoint-ORIG-GUID: Ix54LoGBQsHGCW7CHnVOb3-Yezd1uS89
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-02_03,2022-02-01_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501
 malwarescore=0 clxscore=1015 lowpriorityscore=0 mlxlogscore=999
 spamscore=0 impostorscore=0 phishscore=0 mlxscore=0 bulkscore=0
 adultscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2201110000 definitions=main-2202020049

SGksIEphbiENCg0KT24gMDIuMDIuMjIgMTE6MDUsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAw
Mi4wMi4yMDIyIDA5OjQ0LCBSb2dlciBQYXUgTW9ubsOpIHdyb3RlOg0KPj4gT24gVHVlLCBGZWIg
MDEsIDIwMjIgYXQgMDY6MjU6MDdQTSArMDIwMCwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3Jv
dGU6DQo+Pj4gRnJvbTogT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gPG9sZWtzYW5kcl9hbmRydXNo
Y2hlbmtvQGVwYW0uY29tPg0KPiBPbGVrc2FuZHIsIGNhbiB5b3UgcGxlYXNlIGNsYXJpZnkgYXV0
aG9yc2hpcCBoZXJlPyBUaGUgcnVsZSBvZiB0aHVtYiBpcw0KPiB0aGF0IEZyb206IG1hdGNoZXMg
Li4uDQo+DQo+Pj4gU2hyaW5rIGNyaXRpY2FsIHNlY3Rpb24gaW4gdnBjaV97cmVhZC93cml0ZX0g
YXMgcmFjaW5nIGNhbGxzIHRvDQo+Pj4gdnBjaV97cmVhZCx3cml0ZX1faHcoKSBzaG91bGRuJ3Qg
YmUgYSBwcm9ibGVtLiBUaG9zZSBhcmUganVzdCB3cmFwcGVycw0KPj4+IGFyb3VuZCBwY2lfY29u
Zl97cmVhZCx3cml0ZX0gZnVuY3Rpb25zLCBhbmQgdGhlIHJlcXVpcmVkIGxvY2tpbmcgKGluDQo+
Pj4gY2FzZSBvZiB1c2luZyB0aGUgSU8gcG9ydHMpIGlzIGFscmVhZHkgdGFrZW4gY2FyZSBpbiBw
Y2lfY29uZl97cmVhZCx3cml0ZX0uDQo+Pj4NCj4+PiBQbGVhc2Ugbm90ZSwgdGhhdCB3ZSBhbnl3
YXlzIHNwbGl0IDY0Yml0IHdyaXRlcyBpbnRvIHR3byAzMmJpdCBvbmVzDQo+Pj4gd2l0aG91dCB0
YWtpbmcgdGhlIGxvY2sgZm9yIHRoZSB3aG9sZSBkdXJhdGlvbiBvZiB0aGUgYWNjZXNzLCBzbyBp
dCBpcw0KPj4+IHBvc3NpYmxlIHRvIHNlZSBhIHBhcnRpYWxseSB1cGRhdGVkIHN0YXRlIGFzIGEg
cmVzdWx0IG9mIGEgNjRiaXQgd3JpdGU6DQo+Pj4gdGhlIFBDSShlKSBzcGVjaWZpY2F0aW9uIGRv
bid0IHNlZW0gdG8gc3BlY2lmeSB3aGV0aGVyIHRoZSBFQ0FNIGlzIGFsbG93ZWQNCj4+PiB0byBz
cGxpdCBtZW1vcnkgdHJhbnNhY3Rpb25zIGludG8gbXVsdGlwbGUgQ29uZmlndXJhdGlvbiBSZXF1
ZXN0cyBhbmQNCj4+PiB3aGV0aGVyIHRob3NlIGNvdWxkIHRoZW4gaW50ZXJsZWF2ZSB3aXRoIHJl
cXVlc3RzIGZyb20gYSBkaWZmZXJlbnQgQ1BVLg0KPj4+DQo+Pj4gU2lnbmVkLW9mZi1ieTogUm9n
ZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+DQo+Pj4gU2lnbmVkLW9mZi1ieTog
T2xla3NhbmRyIEFuZHJ1c2hjaGVua28gPG9sZWtzYW5kcl9hbmRydXNoY2hlbmtvQGVwYW0uY29t
Pg0KPiAuLi4gdGhlIGZpcnN0IFMtby1iLCBhcyB0aGVzZSBhcmUgZXhwZWN0ZWQgdG8gYmUgaW4g
Y2hyb25vbG9naWNhbA0KPiBvcmRlci4NCldlbGwsIEkgd2FzIG5vdCBzdXJlIGhlcmU6IHRoZSBp
ZGVhIGFuZCB0aGUgb3JpZ2luYWwgY29kZSBiZWxvbmdzDQp0byBSb2dlciBhbmQgaXQgd2FzIGEg
cGFydCBvZiBhIGRlZGljYXRlZCBvdGhlciBwYXRjaC4gU28sIHRlY2huaWNhbGx5LA0KdGhpcyBw
YXRjaCBkaWRuJ3QgZXhpc3QgYmVmb3JlIGFuZCBSb2dlciBoYXNuJ3QgY3JlYXRlZCBpdCAodGhl
IHBhdGNoKS4NClNvLCB0aGlzIGlzIHdoeSBJJ20gaW4gZG91YnQgaGVyZTogc2hvdWxkIEkgY2hh
bmdlIHRoZSBhdXRob3JzaGlwDQp0byBSb2dlcidzPyBJIGhhZCBubyBtZWFucyB0byBvZmZlbmQg
YW55b25lIGhlcmUgbm9yIEkgcHJldGVuZA0KZm9yIHRoZSBhdXRob3JzaGlwIGluIGFueSBmb3Jt
Lg0KDQpJIHdvdWxkIGxpa2UgdG8gYXBvbG9naXplIGlmIGFueW9uZSBmZWVscyBvZmZlbmRlZCBi
ZWNhdXNlIG9mIHRoZSBhdXRob3JzaGlwDQoNClBsZWFzZSBoZWxwIG1lIHVuZGVyc3RhbmQgd2hh
dCBpcyB0aGUgcmlnaHQgYXBwcm9hY2ggaGVyZS4NCj4NCj4+IEFja2VkLWJ5OiBSb2dlciBQYXUg
TW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT4NCj4gSSdsbCB0YWtlIHlvdXIgdW5jb25zdHJh
aW5lZCBhY2sgdG8gaW5kaWNhdGUgdGhhdCB5b3UncmUgYWxzbyBmaW5lDQo+IHdpdGggdGhpcyBn
b2luZyBpbiByaWdodCBhd2F5OyBzZWUgbXkgcmVwbHkgdG8gMC80IGFzIHRvIHRoZSBlYXJsaWVy
DQo+IHR3byBwYXRjaGVzLiBQbGVhc2UgbGV0IG1lIGtub3cgKHNvb25pc2gpIGlmIEkgc2hvdWxk
bid0IG1ha2UgdGhpcw0KPiBpbXBsaWNhdGlvbiwgYnV0IEkgc2hhbGwgd2FpdCB3aXRoIGNvbW1p
dHRpbmcgZm9yIGNsYXJpZmljYXRpb24gb2YNCj4gdGhlIHF1ZXN0aW9uIGZ1cnRoZXIgdXAgYW55
d2F5Lg0KSSB3b3VsZCBwb3N0cG9uZSBwYXRjaGVzIFswOyAxXSBhbmQganVzdCBnbyB3aXRoIFsz
OyA0XSBpZiB5b3VyIHdpbGwNCklmIG5vdCwgdGhlbiB0aGUgd2hvbGUgc2VyaWVzIGNhbiBiZSBw
b3N0cG9uZWQgdW50aWwgSSBoYXZlIHRoZQ0KYmlnZ2VyIG9uZSByZWFkeS4NCj4NCj4+IFdvdWxk
IGxpa2UgdG8gbWFrZSBzdXJlIHdoZXRoZXIgSmFuIHN0aWxsIGhhdmUgY29uY2VybnMgYWJvdXQN
Cj4+IHNwbGl0dGluZyBhY2Nlc3NlcyB0aG91Z2guDQo+IEkgY29udGludWUgdG8gYmUgYSBsaXR0
bGUgY29uY2VybmVkLCBidXQgYXMgbG9uZyBhcyB0aGUgZGVjaXNpb24gaXMNCj4gdGFrZW4gY29u
c2Npb3VzbHkgKGFuZCB0aGlzIGlzIHJlY29yZGVkIGluIHRoZSBkZXNjcmlwdGlvbiksIHdoaWNo
DQo+IGNsZWFybHkgaXMgdGhlIGNhc2Ugbm93LCBJIGhhdmUgbm8gb2JqZWN0aW9ucy4gSW4gdGhl
IGVuZCB3ZWxsDQo+IGJlaGF2ZWQgT1NlcyB3aWxsIHN1aXRhYmx5IHNlcmlhbGl6ZSBhY2Nlc3Nl
cyB0byBjb25maWcgc3BhY2UgYW55d2F5Lg0KPg0KPj4gQWxzbyBzaW5jZSBJJ20gdGhlIG1haW50
YWluZXIgd2UgbmVlZCBhIFJldmlld2VkLWJ5IGZyb20gc29tZW9uZSBlbHNlLg0KPiBSZXZpZXdl
ZC1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KPg0KPiBJJ20gbm90IHN1cmUg
dGhpcyBpcyBzdHJpY3RseSBuZWVkZWQgdGhvdWdoOiBJJ2QgZ2VuZXJhbGx5IGNvbnNpZGVyDQo+
IGEgMm5kIChsYXRlcikgUy1vLWIgYXMgdmFsaWQgc3RhbmQtaW4gZm9yIFItYiwgYXQgbGVhc3Qg
YXMgbG9uZyBhcw0KPiB0aGUgMm5kIGF1dGhvciBkb2Vzbid0IHNjb3BlLXJlc3RyaWN0IHRoZWly
IHRhZy4NCj4NCj4gT25lIGZ1cnRoZXIgcmVtYXJrIHRob3VnaDogVGhlIHJlc3VsdGluZyBhc3lt
bWV0cnkgb2YgdGhlIGxvY2tpbmcNCj4gKGNvdmVyaW5nIHRoZSAiaGVhZCIgaHcgcmVhZCBidXQg
bm90IHRoZSAidGFpbCIgb25lKSBsb29rcyBhIGxpdHRsZQ0KPiBvZGQsIGJ1dCBJIHdpbGwgYWRt
aXQgdGhhdCBJIGRvbid0IHNlZSBhIGdvb2Qgd2F5IHRvIHJlc3RvcmUgc3ltbWV0cnkuDQo+DQo+
IEphbg0KPg0KVGhhbmsgeW91LA0KT2xla3NhbmRy


From xen-devel-bounces@lists.xenproject.org Wed Feb 02 09:42:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 09:42:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.263912.456786 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFC9l-0004eS-HJ; Wed, 02 Feb 2022 09:42:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 263912.456786; Wed, 02 Feb 2022 09:42:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFC9l-0004eL-EL; Wed, 02 Feb 2022 09:42:29 +0000
Received: by outflank-mailman (input) for mailman id 263912;
 Wed, 02 Feb 2022 09:42:28 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=6WyI=SR=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nFC9k-0004eF-17
 for xen-devel@lists.xenproject.org; Wed, 02 Feb 2022 09:42:28 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6e637348-840c-11ec-8f75-fffcc8bd4f1a;
 Wed, 02 Feb 2022 10:42:27 +0100 (CET)
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2058.outbound.protection.outlook.com [104.47.1.58]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-26-L2hrBIFkOEyJ0bf15smVWA-1; Wed, 02 Feb 2022 10:42:25 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB3120.eurprd04.prod.outlook.com (2603:10a6:802:e::11) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.21; Wed, 2 Feb
 2022 09:42:24 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.012; Wed, 2 Feb 2022
 09:42:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6e637348-840c-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1643794946;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=PkXxk37QoNgrDyPWLzP47ETl9eFQV0Qt63FMS3/VkKY=;
	b=Pi1gKDKPui8v1tUd06duMgxNughQeCMV5IznuiPBwyAtCOW5wgDveoOch0tgIZREzTuq+S
	jKQwyf9xxhe0a6+ldEbmFTS7KjN+JReIPAVJENK2CmDnkasPQ6GUYvU+wEigkm8Tkfnq5x
	y2oFXbBtPYgONoeG6a2yGvdYe4/EbCk=
X-MC-Unique: L2hrBIFkOEyJ0bf15smVWA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=hEQ/76nkD2YfsOnJ5aM45YbMQrABGyl9P6UokBdnoqU0nVALJGdMgCKaRZn7Hzlyv0FhvGXt3jF7ZU39UA2EhkZVJi1GCqk5nooD7Znl4MbrzE/4B0yLDcohf3EaQYcBi2ZZLnow6P9e/V6WeohHFM/knxdheXeT0dUbwG3DQM16zvgrCxDleHtvQTKOcyGtYz+CRwIrjoTQIR2dxsjYiEYkamhOM5imJyGMIBtFtXKvcGikTDIx7i7a5OBXDyO5NaFNiVKr6GTajoZ0h9R+So024iftmi4OneeKPwkfjPVDTGqrNu9j2wFef5cwyvE/KQmqpPsGHIAhfS2rfyGx7A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=PkXxk37QoNgrDyPWLzP47ETl9eFQV0Qt63FMS3/VkKY=;
 b=RptBkwi3ThnrtdpSYrVO2w0aInbzec94ZyfZGBQR9acnXGrGUQp20MrfRCiSVqGpmlSGvE27th+huVj9/o8eXdZxriiMEQMeXOhHkh0urUr9tDAvlZ63LbLGERuU/536Md2qR/QkUveyn3EmU0I5/XLw3kWKn0ABbnm83OAuj3FIKbCwnelP/xJgsRV2Sec+AoZEFqdSIqd1Dk9ONnjTKUzEJLtWtX1xBr3kMtclVqFh12gaMm94Ktlw+MzX13RKvnyap9/b1zx7JzBYRgqUZpQge6smJzxXjpuWMdWGMiYpVJX07rx+rKfl+efkxGP03Hf4bDWW/LLo5IZWXYjmAg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <59685ca1-0587-a975-bf5b-56058b650c3a@suse.com>
Date: Wed, 2 Feb 2022 10:42:22 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v3] xen/pci: detect when BARs are not suitably positioned
Content-Language: en-US
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Paul Durrant <paul@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220201124551.2392-1-roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220201124551.2392-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P195CA0055.EURP195.PROD.OUTLOOK.COM
 (2603:10a6:209:87::32) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 8599ff4d-45dc-4afd-1c49-08d9e6305127
X-MS-TrafficTypeDiagnostic: VI1PR04MB3120:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB31207A09C1CEA0CE797D930EB3279@VI1PR04MB3120.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6108;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	y4/RW+xgTHhWfkejPQb5JIIeu/CRQPf2CM8zKvkFrhe8gG0n8/CLqILtNQiMwAVuZCS1QqGWPztTn4JmeUFN9HeqN8GEbRPpx9DdwQP7+Q89rbuJMX4a8taqHQ06xzqzb87iQk6PU2B5G7nf8hOnv5TAuZFiGTPdfQ0qMbeOENkOAVJrf3BVEDsrscudr5/6FRSoEBynGwBoLVtxCeNYbCCPMIYbTVRWlYhKbIOEa7EIXQat1iEmAv7yzJGwAPI+J1OO+7kN4Ft/Ow8xq6drW8Yv6EIz699O7wmCCBncyDAvXPvT/BYn8auUhKC63pO8MrkPrdi5iPTYYySE5tOZgfrMOqL5pgk7ntLpq9VVnW9vARbSki8vhR/+ji4Q+lOXxwHG/c2CN+YtQdqOr27dUOmeEHzH8aGI5apCGGXhCHd3kERhXCdIzoauG50UZBkUCPcsy6LgmkckWeoIDYJUrWli0gX65vN7VGXp+CEgeLJDnfzbS+7WUpzwOBSKb0sCsTscnIh3cq1fVeBFCyxNG3PvORk9jZy/p2Hb7k8AFTXClnvJhZRQH2eiWWUw3/7JBtYL1gDpBAjlNMiGnbDyjbndKdGMZD/EXwGp4YLE1TOy0aQ6bNoVBu+RrN/wobwPU6saWVRHZQSI8ZopBM0Q1nlORH6IhmNoyd+25B/RZm/yYZGJIAXvuE9Xja/K4JDfCaRIxk5wXEkXHVkn+4VnKtgprlFCU/XoVZ4OFx0BvGw=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(508600001)(6486002)(38100700002)(186003)(26005)(6506007)(2906002)(5660300002)(66946007)(36756003)(2616005)(66476007)(54906003)(86362001)(53546011)(31696002)(4326008)(31686004)(8936002)(6512007)(316002)(66556008)(8676002)(6916009)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UktZMkR6ekx6OEhUVThCVk1rYld6WEhpNFdXVkwrbUZEWEIvdGp5SjN5cUFK?=
 =?utf-8?B?UGZRREsvbllmZ0ZSbmVKQU9Xempsb2c3WjdHM2ZKa2x3Mkthb0tBVXhrVXhO?=
 =?utf-8?B?SCtnMEpsdkh2bExaZk94RWROQmlFN1d4SnA3ZDEwMEJOMTB0ZWY4bmpFdEF6?=
 =?utf-8?B?N2xPSDBGWnNocFMrNzJqS0hVazM3NEVWV3VXdkJCbStKVkIxckUyV2ZlSFQ4?=
 =?utf-8?B?TDlTUis4UW9OR21FRmljRXl0WWF0VDlvMEF2b05wSjZHb2tsVkFRd280ZjRw?=
 =?utf-8?B?czhrNVcrQTY4ak1Mc2ltVWl1UTFCSklaOURoNnlSNVovbWU2cG5BclVSRFIz?=
 =?utf-8?B?RlRWT1FyS3NNeEFsbG4wSTZ6RkpNSHd3TXhHZCtYUkF1amZ0N3NxZk1rSjBQ?=
 =?utf-8?B?ZnRGdTJJQ0h4U0pQdm5UY054K1ZrcFRZUUR4eHpaRFRtWXpFQkFZcEtvT2dQ?=
 =?utf-8?B?a1Q0SXdTM1Njd3YxdWJ2YXA1aElseDJZSXdOeXo2NUMzY0QzaFVXd1JMNGJG?=
 =?utf-8?B?THJ2VUdwRE40TThZZTlVcnhsVnRzUlplbStoRVRjTVlNVVRLK2xQdzJkc0Q4?=
 =?utf-8?B?RXRXazQ1cU5Ya1J6TCtOOHVFRGFRSXJWMzNWSlNBUlc4RXVHVUVteTFsdlhh?=
 =?utf-8?B?bERwbWlIR2dGRzdIOVZydk9veVVSem5DOXBHR09OOVpFNms3Y1FrRGtOUkNQ?=
 =?utf-8?B?MHVWV2RlKzRKOEFTSldBRElDTHdNWWtZL1hDR0o4cVJWd3Jnbm1XeGkwanRv?=
 =?utf-8?B?MGpvMzkvdjNvZjE2LzI5VU9pRTNiUnE3RmZTRkVhdzJ2N1BncVVmQTFIL2g4?=
 =?utf-8?B?cC9wQXI4VGhvZWlXWjE5dXZGdnR5YXkzelZXSXpteThBMm1PYkMwRW02RGhC?=
 =?utf-8?B?SERCcE9kN2VIZ3RkQ3BXbU05YTV0Tzc0dHVwd3JYVFdWdFlJVWhzbTFXZWVY?=
 =?utf-8?B?bC90bStzQWpIb0hLbm5DNkZ6SHQ4Q1B4QWUyVWpTTlZIOTc5SUZZdVFzN3NH?=
 =?utf-8?B?bFg5aHpCcUxqTnMxaTBjUXZKbG5SVUFqbytsblN1NEZqQUtGcktmTVRsb0Vm?=
 =?utf-8?B?WXpIcDR5bWdmRUg5bEZ0V1ZXeEhpRFFEVmVHUklxdkZHUzgwYjg1d2JjSlph?=
 =?utf-8?B?R3N1dnpaQlRVWHR5ZG90L1pZYm1ZOFF3WExvM3RyT2loT21lZFk4b3ozdDlt?=
 =?utf-8?B?NWh3R1h4UlFua1JiM0hrcWhtbDMyNkI3MmNkMjhocmQyMXQxRWVEb3lDK2Rq?=
 =?utf-8?B?Ylo3V2RJNEQvTStWNkwwTjN5Nm5sd0p1REpQMnluMS9kOTZaNVNpOU9PaThC?=
 =?utf-8?B?Qi9FVTAxallSVkxhYUowR0tQaEM4SFNCMXhJMytsTWkvY2RTeTUwQUg1STFU?=
 =?utf-8?B?N0dTUlR1M3lzSGt1NGR5QWdsY3d3S1lyOUh0MWZBenI0Z1dUV3REREhpTklY?=
 =?utf-8?B?bThvdnFIUUVwTGQ0clZFRTNaTldPdUhSWk9CbFFuaUdZc0R0cXZXWXY5aWtB?=
 =?utf-8?B?SWYvWVdrcUR2azJFQXR6akpPN1NSVXl6MFZDeUxVbmR6V1BXQktSTElVeW9L?=
 =?utf-8?B?dlBBTUlicFpLWU9Qc0pibTFTSmwyR1RxWTFMYklacjlIL21YYzAyUWdSdStq?=
 =?utf-8?B?WHQ0K3pOK3MwamFkRDhTM0w1b3NSdmFkZlpNYjk1clpnTURLVXFUY3FKZ01S?=
 =?utf-8?B?Z01jUWRKTHluYkgveWN2QkRGOHJuaFREeU9MWTRPL083SGZNMlVJaE02RE5J?=
 =?utf-8?B?MjE2bVlwTU5KTUNRZy9Gci9Lek9ndkQyOG9yQ1NJbGFjY3I0enNYSFY4eFBl?=
 =?utf-8?B?QWxWMlhRWkRBaU1IZ1hib2Vvd0FiNmxCMmpNMlR3OXBvR3Q2TzlUSExLSVVZ?=
 =?utf-8?B?Z0Z4UkhXbDNLem4xeklPYlVwMHFjZEpuK1NTNisyeGtHa3FaZDBzZXhkbkNQ?=
 =?utf-8?B?djRqK3lGT0lHekV5SVBUUVdXK2VuR1ozODB1NGFzVW1IT1NuZXZCZGc5R2I2?=
 =?utf-8?B?cjZpOGQ2bldiNUp3YlZBQUptN1krL3R3a0xMdmh1SXluL2haYkhHN3NNTFZI?=
 =?utf-8?B?aXVMV0IzdlQrUnRzMzQ3Rmt3d2NsN1E0T1orQjltM1JPaVdGZWFReVRBbEZi?=
 =?utf-8?B?bk1YQVNOOVFYdWxxTzRnY2Jvb3NzRWF2ZTBtNHk0b0Ria0cwZ2dPeml6c2NB?=
 =?utf-8?Q?U2wLz5vb3H9nPBB7S/F5GAU=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8599ff4d-45dc-4afd-1c49-08d9e6305127
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2022 09:42:24.5222
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dEaFyUQDgqQrLzRdK9KDWU4UH9o3caIKjzaBfTg7LRvx84ao5ydkyibxXeReYp7zMixDCZVXnkxiLXu62s0cBg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3120

On 01.02.2022 13:45, Roger Pau Monne wrote:
> --- a/xen/arch/x86/mm.c
> +++ b/xen/arch/x86/mm.c
> @@ -783,6 +783,23 @@ bool is_iomem_page(mfn_t mfn)
>      return (page_get_owner(page) == dom_io);
>  }
>  
> +bool is_memory_hole(unsigned long start, unsigned long end)
> +{
> +    unsigned int i;
> +
> +    for ( i = 0; i < e820.nr_map; i++ )
> +    {
> +        const struct e820entry *entry = &e820.map[i];
> +
> +        /* Do not allow overlaps with any memory range. */
> +        if ( start < PFN_DOWN(entry->addr + entry->size) &&
> +             PFN_DOWN(entry->addr) <= end )
> +            return false;
> +    }
> +
> +    return true;
> +}

Doesn't the left side of the && need to use PFN_UP()?

I also think it would help if a brief comment ahead of the
function said that the range is inclusive. Otherwise the use
of < and >= gives the impression of something being wrong.
Then again it may be better to switch to <= anyway, as I
think you want to avoid possible zero-size regions (at which
point subtracting 1 for using <= is going to be valid).

Finally I wonder whether the function parameters wouldn't
better be named e.g. spfn and epfn, but maybe their units can
be inferred from their types being unsigned long (which,
however, would build on the assumption that we use appropriate
types everywhere).

> --- a/xen/include/xen/mm.h
> +++ b/xen/include/xen/mm.h
> @@ -554,6 +554,8 @@ int __must_check steal_page(struct domain *d, struct page_info *page,
>  int page_is_ram_type(unsigned long mfn, unsigned long mem_type);
>  /* Returns the page type(s). */
>  unsigned int page_get_ram_type(mfn_t mfn);
> +/* Check if a range falls into a hole in the memory map. */
> +bool is_memory_hole(paddr_t start, uint64_t size);

While resolving to the same type, these now also want to be
"unsigned long".

Jan



From xen-devel-bounces@lists.xenproject.org Wed Feb 02 09:45:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 09:45:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.263919.456798 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFCCV-0005G5-0I; Wed, 02 Feb 2022 09:45:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 263919.456798; Wed, 02 Feb 2022 09:45:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFCCU-0005Fy-TR; Wed, 02 Feb 2022 09:45:18 +0000
Received: by outflank-mailman (input) for mailman id 263919;
 Wed, 02 Feb 2022 09:45:18 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HAZh=SR=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nFCCT-0005Fs-RM
 for xen-devel@lists.xenproject.org; Wed, 02 Feb 2022 09:45:18 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d19be293-840c-11ec-8eb8-a37418f5ba1a;
 Wed, 02 Feb 2022 10:45:15 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d19be293-840c-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1643795115;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=qy4CHoMERCfhJBZVO4KXL3yj+XIpuSQO1pU/ZWIsUcs=;
  b=Q1iM/RK4hpjjR9h42D30thBzC8A47qcHXpvZLkrPu/+g80O1pMTyFW6R
   OrLQMt3laAnlfiuHNzNvoW1sCX8aU6cn9xSiDb90PE5Xpe3XOvkS58yYm
   vk5oIrn6FhZfPyQAi3z4zQmIYm+ZAqlm54W63TPlIU5vMw+F3vi2ly9X7
   0=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: lNZrdtPnl3IxEKApYEvHBGFKJJmh43hGDiHONqY2da/qJ2gVnrYf3Bg0OG4x17hOuW9D0s1eiH
 FudRBRRf97zNeC+qn+ADK1DanHzQVQ+VWssvl0wQcJmlELUAJkzcuZdon5wVHG23kRrtAfiPjW
 8IZ2IDBa9nkpYoxRH+5ahVvp7OsVTuHHGgqbVeoXTSI6/8mIw0mhYPyaXUd9BtnTQ7qv2kJc4a
 o5FgDEVkDCXpZDA3t3xVZIIqat10gfROguI6yca4PfV1fVJ74lmJkI4vq0ZWkbLg/oo2m7SUAn
 CH3c2E+EHemvUgJRdTP7bnef
X-SBRS: 5.2
X-MesageID: 62766875
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Dip8R6KMCS8fUcXUFE+R7ZMlxSXFcZb7ZxGr2PjKsXjdYENS1GQBx
 zFLW2mBb/bYYjaje9wjOo3noU8DucSGyNMySwFlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokcxIn5BC5C5xZVG/fjgqoHUVaiUakideSc+EH170Ug7wbZg6mJVqYPR7z2l6
 IuaT/L3YDdJ6xYsWo7Dw/vewP/HlK2aVAIw5jTSV9gS1LPtvyB94KYkDbOwNxPFrrx8RYZWc
 QphIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbrGvaUXe345iXMfwZ3u7hB22k48rz
 ox9i6ePTAoGZPHHneNDTBtxRnQW0a1uoNcrIFC6uM2XiUbHb2Ht07NlC0Re0Y8wo7gtRzsUr
 LpBdW5LPkvra+GemdpXTsF2gcsuNo/zNZ43sXB81zDJS/0hRPgvRo2Uv4AGgmdv26iiG978Z
 vs+Wyd+Mi/jeiJNK0cuFcoYrLqR0yyXnzpw9wvO+PtfD3Lo5BR4zbzFINfTPNuQSq19nEyVu
 2bH9GTRGQwBOZqUzj/t2lu2muLKqgbqV4sTGaOQ++ZjhRuYwWl7IBoSWFigqP+1kHm3Xd5FN
 lcU8Sojq6s13EGzR9y7VBq9yFaetx4BX5xLEus16CmE0K+S6AGcbkAOQyRdctUguIkzTCYzy
 16St9rzAHpkt7j9YXCA8raZqxuiNC5TKnUNDQcUQA1A79T9rYUbihPUUs0lAKOzlsfyGzz73
 3aNtidWr7wVgdRRj/3j1V/CijOo4JPOS2Yd+ALTWW606xJjU4SsbYeo9Fvz4O5JKcCSSVzpl
 H8AlsuF5eYCF6aRhTeNS+UAGrKuz/udOTiaillqd7E67Cik8XOneYFW4Rl9KV1vP8JCfiXmC
 HI/oisIusUVZiHzK/YqPcThUKzG0JQMC/zaWq+OaIN+XKNOcQKopn1lYEnOwGLExR1Efb4EB
 b+XdsOlDHA/AKthzSarS+p17YLH1hzS1kuIG8mlkk3PPa62ISfMFOxbaAfmgvURsfvcyDg55
 eqzICdjJ/93dOTlKhfa/ocIRbzhBShqXMumwyC7mwPqH+aHJI3DI6OAqV/CU9Y890iwqgsv1
 irlMnK0MHKl2RX6xfyiMxiPko/HU5dltm4cNicxJ1uu0HVLSd/xsPxAK8JmLOR+qrwLIRtIo
 x4tIJ3oPxiyYm6fp2R1gWfV8OSOiyhHdSrRZnH4MVDTjrZrRhDT+8+MQ+cc3HJmM8ZDjuNn+
 +fI/lqCGfIrHl0+ZO6LNq7H5w7v7BA1xbIjN2OVc4I7UBi9r+BXx9nZ06Vfzzckc0uTn1N3F
 m++XH8lmAU6i9RkrYCU1f3Y9NrB/ikXNhMyIlQ3JI2ebEHy1mGi3ZVBQKCPezXcX3nz46Kse
 aNeyPSUDRHNtA8iX1NUH+k5wKQgycHoorMGnA1oEG+SNwagC696I2nA1s5K7/UfyrhcsAqwe
 0SO5tgFZunZZJK7SAYcdFg/c+CO9fAIgT2Ov/47F1r3uX1s972dXEQMYxTV0H5BLKF4OZ8Oy
 Ps6vJJE8BS2jxcna47Uji1d+2mWAGYHVqEr6sMTDIPx01J5wVBee53MTCTx5cjXOdlLN0ArJ
 B6ShbbD2OsAlhaTLSJrGCGUj+RHhJkItBRb93M4JgyEyojfm/s6/BxN6jBrHA5b+QpKjrBoM
 W9xOkwreajXp2V0hNJOVnyHEh1aAEHL4VT4zlYEmTGLT0SsUWCRfmQxNfzUoRIc+mNYODNa4
 KuZ2CDuVjOzJJP92S47WEhErf3/TIMuql2eyZ7/R8nVTYMnZTfFg7O1YTtaohTqNso9mUnbq
 LQ45+13c6D6aXYdrqBT51N2DljMpMRo/FB/fMw=
IronPort-HdrOrdr: A9a23:6p0YS6rMMiCaQ9+ON/hwT3YaV5uzL9V00zEX/kB9WHVpm5Oj+P
 xGzc526farslsssREb+OxpOMG7MBThHLpOkPMs1NCZLXTbUQqTXfpfBO7ZrQEIdBeOlNK1uZ
 0QFpSWTeeAcWSS7vyKkTVQcexQueVvmZrA7Yy1rwYPcegpUdAZ0+4QMHfkLqQcfnghOXNWLu
 v52iIRzADQBkj/I/7LTUUtbqzmnZnmhZjmaRkJC1oO7xSPtyqh7PrfHwKD1hkTfjtTyfN6mF
 K13jDR1+GGibWW2xXc32jc49B/n8bg8MJKAIiphtIOIjvhpw60bMBKWqGEvhoyvOazgWxa2u
 XkklMFBYBe+nnRdma6rV/E3BTh6i8n7zvYxVqRkRLY0LrEbQN/L/AEqZNScxPf5UZllsp7yr
 h302WQsIcSJQ/cnQzmjuK4GS1Cpw6Rmz4PgOQTh3tQXc81c7lKt7ES+0tTDdMpAD/60oY6C+
 NjZfusq8q+SWnqL0wxg1Mfg+BFBh8Ib1W7qwk5y4CoOgFt7TFEJxBy/r1bop8CnKhNPKWsqd
 60dpiAr4s+PfP+W5gNcNvpcfHHelAlfii8Ql56AW6XXZ3vaEi946Ie3t0OlZSXkdozvdwPpK
 g=
X-IronPort-AV: E=Sophos;i="5.88,336,1635220800"; 
   d="scan'208";a="62766875"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=SP9OYwr9XzMRDEH3zZoDT4YA0X6D+t2eFE20aZgS7B4Nqq/B0Ho+lxojp3ZjGwLw0coLJVF5gq3LtuFQE7rAuvTC1ycIR+ZUOBdK/diKPfi4+Jmo0tfc9LGOIPB84ANobaPWF2Uwia+h5S4N9IwV54mYW2sTuhfQkUyE/32Mut8CGdnk8td49GWDhvKklZQ6PtNxviemWwWHspDj4tzwLHDkA00CT7iXNnAwiW81CfuZmDBnqRwqEBFKh+xLH5ejKPmXXy6xjFBnYO1UP1AbaOKV/0ya3SHtWuAzcBKzDjGbfEoJWjvzUJQg2NMcVUCaUMhbBc37Zg9wu55tkwVtnw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=WiuF1apECAnbhAM7S6UWj9N5RR/vCYnE9hCPsKt8K+Q=;
 b=IhTbqLMj7kc2t9dpKPQci2MCuEaKGJYsXDjgKfvUWCeZt2n3vFhWBVOmtinB/QgsqaNltidSIm2HFJ5BlsIy2i+UPzjAEKihXeM2UtaB9PUaMaCi7hKEiyLbg0thRjGProtW5iMMMrzV2N/f0wrATeRdyiYyuPNyAEFEmHMY++RccNNoULNOizUgcpOms81XKUb+g4qxexXacrKQSJKopu4oyGhFhdjEa2AublGVqQGJDTMgae+a3wJOBnZplCcrygsIc0oNpRkNg4n0wZFWEAZSi0NtMbIKw/L0aekBEpb3pEIDLbtvo+hjc51pWIkxk23ZWUKQC7qPM1t5MQf9uQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=WiuF1apECAnbhAM7S6UWj9N5RR/vCYnE9hCPsKt8K+Q=;
 b=OxQxPUDjUrk6piNA0yDd/0fzfDD55eEqmSnXgbrQgtxwDJmEJqZoBuU8jHkqw5VqqfaHXXmAL5zmfXeJ4kANPqHDTsqnkd4M9nySCBtSt/nUITysSVGVWKuNZIwu8fcZtQF6jaYjOknCN1K6VDXZVU0rK4Q3w3X2r3aTAtQmP2I=
Date: Wed, 2 Feb 2022 10:45:01 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Oleksandr Andrushchenko <andr2000@gmail.com>
CC: <xen-devel@lists.xenproject.org>, <julien@xen.org>,
	<sstabellini@kernel.org>, <oleksandr_tyshchenko@epam.com>,
	<volodymyr_babchuk@epam.com>, <Artem_Mygaiev@epam.com>, <jbeulich@suse.com>,
	<andrew.cooper3@citrix.com>, <george.dunlap@citrix.com>, <paul@xen.org>,
	<bertrand.marquis@arm.com>, <rahul.singh@arm.com>, Oleksandr Andrushchenko
	<oleksandr_andrushchenko@epam.com>
Subject: Re: [PATCH 4/4] vpci: move lock outside of struct vpci
Message-ID: <YfpSnTrh6dcbrNNX@Air-de-Roger>
References: <20220201162508.417008-1-andr2000@gmail.com>
 <20220201162508.417008-5-andr2000@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220201162508.417008-5-andr2000@gmail.com>
X-ClientProxiedBy: MR1P264CA0135.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:501:51::12) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 390b6aa3-9358-4940-4d0c-08d9e630b1e6
X-MS-TrafficTypeDiagnostic: MN2PR03MB4911:EE_
X-Microsoft-Antispam-PRVS: <MN2PR03MB49110029DF32A81739500F6A8F279@MN2PR03MB4911.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: eJffYKopixjmvQQJDEkj8ErMB0BdPyD5h7jwOW2g69FY+sAHKQlI4oVlWsNqT+1kyanKhIMtHSynrlhTJy/t3px1sm+7A7WTts3M8iDoA7Yb0N2olWEoFaaT/s7yauRpTc9RsipPq5XPcg62gLzegMOnYmtsT6IiMKF0XriueBfQBz4UQps0SxuEFf8ZSKpMuX7qgKzg09/fUsc6yxqGp7AM98e4JGDMcoDQLnwq/y+QR9g6Th+kn1GjZYl1Nx1tss70WypEhYxPNbz35YomVM6iLFdipbgk7zATXDz1zxmNNhLLRwfnI+11j1RlJzH150+F9ycy1CM1/ME5+XKIoSBjZqbZhacpvIfkRnKAXpHJnLRF5/2PjOzFh7Ng7FPF4xDgvjCgePKQFWfCmErAC8i/ONo7b7Gz7ZKk3tEkmHvLYgs6I6C4w+NZkML1W6yYcXyNqg0NQl9SD+bUdY5TY2BGqtiB8D1t9BTHjADE+8MZPO5wgQMkTOa885KPHzS25xCq/DyGRJ+Upo8iV2N/pb7U4zELVA2q5xZ1zZIs41xBp+cn92IWbahf/aCGkQNx2KOUwAI4t66TruWWzgbE90gtOULF1x3TQQbYSJXjNP7zHcvedcUE5/MHH3Bl8EUh7pZG3Vn0Eu6sVbiZfoW8s6+LRHn1v/E90y6VstfiEsMOwjX1n8I8roEn/BG8piP5jxXnxw5q9kDJsyMvB4Et1MJ++1RF7dgkHORat68b3B8=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(5660300002)(8676002)(6512007)(86362001)(7416002)(6666004)(4326008)(85182001)(9686003)(66946007)(26005)(186003)(8936002)(6506007)(66476007)(2906002)(66556008)(6486002)(966005)(38100700002)(82960400001)(33716001)(508600001)(83380400001)(6916009)(316002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SHFwY1JSN293WUFsckVwWDhLWW41OS9pcmJ5YkJ2Q2swZFE1OUJlMDZxUndw?=
 =?utf-8?B?WEl2UFhjdWVzOTNvTnJPMGQyeDN0VGU4NFFHWlRYZXU1a1NGcEZ5emM5MzBZ?=
 =?utf-8?B?cU5WVnRDZzlRQTNGRVlSOTZZWXdxQ1RodWxGVnM3N04zTHBKMmRaaXg4bWo4?=
 =?utf-8?B?SWxBREhveU1QSjNXZlpiTnNPbzZrUW1XR0I5S05aZ1F1MldoM3l3aG1kU0F2?=
 =?utf-8?B?K1I4SWZwWmp6OHJ6T25UMUJaNVVYcDR2cnV4N0VoQndXMk8xTklYaGFvbjEx?=
 =?utf-8?B?ME1PT0FxUjBCYmNyaG5DUjkrVU51L05OOUpHS2JWakRnK0lsYTg1YWoydExn?=
 =?utf-8?B?K1VMbi9MRDRxRFlLREZ3YUlFL1RFYllCdS80eUMvbW1oYmJDazJXcGV3bVhP?=
 =?utf-8?B?MHlaOHVwTCt0OXFnWTBMUjJVRmNmRnlTa2FyblVoLytsZmxNeXBTb2JGODl5?=
 =?utf-8?B?U0NjODVhaUVNaTlBZXdDMkRPZC9TTHRWNzcvbGdCREVHMzl6R1BPTHZJOHAx?=
 =?utf-8?B?bzBLUnRtNm1FcWdMalVFN3hXYjdCa3B1ZStBMHhFTDg5SC9XWVZ4dWdwNFIr?=
 =?utf-8?B?ZXRVSWlON3IvblVNWU5QM1AwVzY1dFd4S2RkelM2NzFmZDJIUXVTY0JZQ2Z5?=
 =?utf-8?B?NWpSQjBsb2RVK05zRFdJUS9uMkcySzMvK2gvYUxyTjhrUUMxUkl4WTRnRy9D?=
 =?utf-8?B?MXhUcStZM3Nqa201UkRBQlQ0MEFkeEFGMUVlSXlwN1NzQnY5d015elhOSzAy?=
 =?utf-8?B?RDJNWUVnci9oZWRPTndNRFcxQTJWN3NROWw5cng2YUhDbnpsQncyVlZ5Nm5a?=
 =?utf-8?B?Vlhab1FRdWpRVE1PaWlsNEUwTFkxYTh5OVhKc055bUFaYjV4anBLelpLOUM0?=
 =?utf-8?B?YXROUmFKS2ZEaTN1WFlZQkQzcVdVdkxMZmc5aGJzS3hzL2Q5Wm9yR2Jsa1Jk?=
 =?utf-8?B?T201UzEyL1U3SmYvdzlvSlBDNngvN28zcVdnUy9sQ3JtMi9TSVBNNnh4dmJD?=
 =?utf-8?B?UlVaNk1TbUhhbmxUT0ZqU0F2T1FuSzlVTm9ud3FvcFNGSEIzRWxMd0RwalhM?=
 =?utf-8?B?N2x5OG1rWERZS3V0UzU1eDE5eFZzbTVScXZ3aXkybVFCcVpTVUN6S3FUSUdy?=
 =?utf-8?B?L2pPWEEvL1V1S0RWMDhXR0ZIalpCLzZ3M29haTBRZDVpWERwcXM0cVlockpz?=
 =?utf-8?B?TS93Qmx5K0pHSVBVR2ZaNUVyNVRKS2k2M2RONzduUWJMMS9hQlFEV3pPbVVL?=
 =?utf-8?B?SmpXMnJPN0RaLyttNEFNekZhYlRQSzFjMGIvN3Vubmpobm90R3krb2ZuN0k3?=
 =?utf-8?B?Z1ZVVEMxYkVEM0pVUjdQemNpR1l3QWhmMXJJZ0JrZ1VrOUxiQlQxOS9MSHBP?=
 =?utf-8?B?NVVnZE5oWm81S2p5SG5VNEl6VHJqVFFLZWl5UXlHUjB6VE96TFBtTU1yWFFR?=
 =?utf-8?B?YmNaNW5taExJdXMrK0s1NFAwTXdUcWJKYngwWWJoZGxzSmppSkpkMnB3c3dj?=
 =?utf-8?B?UWZlQmdIa1RGZGhFMFAyRDB4am1IMjc0RHRxNlUvQlBMMFpwcmk2bmZiamVj?=
 =?utf-8?B?Wks3MVdhOEJ3d2ZEb1FFVHkxZlJnUHl1NzQzKzBvdkN1SmV4TXFITHJGck9s?=
 =?utf-8?B?M0tLSTJrZW13Y0oxRHg0ZGZGSXUzbUVCb0k0ck55VzFQTEM2OXRSdmhWTWJD?=
 =?utf-8?B?aFQ5V2g5dEtEV3U4MndYSEFqNTJYd2xSTGozdFNqd0hXeHVVVy9jRWE0TDZU?=
 =?utf-8?B?M09CWnlRcXh2ZnIyUHpNMWxvNFBHYWdkdzZXbm94RG9ZVFZPSjNJQWhuTTdT?=
 =?utf-8?B?WnNybEc1bHBUNWdyeUdBZGlZOG8wQWN4NVFSNmRvcWR3c0pCaVpLdWRvK2cr?=
 =?utf-8?B?ajdwY21nWlNrOG9uUzJ2S0s5Z0d6UmZnbngzYit3ZlNQU3pMYjZaQ2FUcWpt?=
 =?utf-8?B?eXkwTGJzVUYzamJZQzFsTWtUVXBIWEdRa2NxaHdoaVZRNk5MWEZUSW1YMExK?=
 =?utf-8?B?cDl5NHZrQ0pRM1dNK0lmMng0SW9CM2tZS05USUY2K2pIT09IWTEza1pOSkVR?=
 =?utf-8?B?dDc5bkZEU3duLzhnR2xzY3BJdGY3Um9MOGFrRjJFR3JJY1lPdEZYd1QvTHJN?=
 =?utf-8?B?QTBSMEJaMDA3d2NoTThjSGU5Rm9vTnlKb09LalAzbXlNR3hWOEZCUFBqeWxu?=
 =?utf-8?Q?x5JVMsaXwuZx8E061wRvo8I=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 390b6aa3-9358-4940-4d0c-08d9e630b1e6
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2022 09:45:06.8364
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oAn8tXkdYcaECT6ykbst5PqcKBv4/zjFQwBtCBBoj5645ZIi14ExAByyVXUmG62T7RJpBqmrmePTlwfNpNnDbA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB4911
X-OriginatorOrg: citrix.com

On Tue, Feb 01, 2022 at 06:25:08PM +0200, Oleksandr Andrushchenko wrote:
> From: Roger Pau Monne <roger.pau@citrix.com>
> 
> This way the lock can be used to check whether vpci is present, and
> removal can be performed while holding the lock, in order to make
> sure there are no accesses to the contents of the vpci struct.
> Previously removal could race with vpci_read for example, since the
> lock was dropped prior to freeing pdev->vpci.
> 
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> ---
> Cc: Andrew Cooper <andrew.cooper3@citrix.com>
> Cc: Jan Beulich <jbeulich@suse.com>
> Cc: Julien Grall <julien@xen.org>
> Cc: Stefano Stabellini <sstabellini@kernel.org>
> ---
> New in v5 of this series: this is an updated version of the patch published at
> https://lore.kernel.org/xen-devel/20180717094830.54806-2-roger.pau@citrix.com/
> 
> Changes since v5:
>  - do not split code into vpci_remove_device_handlers_locked yet
>  - move INIT_LIST_HEAD outside the locked region (Jan)
>  - stripped out locking optimizations for vpci_{read|write} into a
>    dedicated patch
> Changes since v2:
>  - fixed pdev->vpci = xzalloc(struct vpci); under spin_lock (Jan)
> Changes since v1:
>  - Assert that vpci_lock is locked in vpci_remove_device_locked.
>  - Remove double newline.
>  - Shrink critical section in vpci_{read/write}.
> ---
>  tools/tests/vpci/emul.h       |  5 ++-
>  tools/tests/vpci/main.c       |  4 +--
>  xen/arch/x86/hvm/vmsi.c       |  8 ++---
>  xen/drivers/passthrough/pci.c |  1 +
>  xen/drivers/vpci/header.c     | 21 ++++++++----
>  xen/drivers/vpci/msi.c        | 11 ++++--
>  xen/drivers/vpci/msix.c       |  8 ++---
>  xen/drivers/vpci/vpci.c       | 63 ++++++++++++++++++++++-------------
>  xen/include/xen/pci.h         |  1 +
>  xen/include/xen/vpci.h        |  3 +-
>  10 files changed, 78 insertions(+), 47 deletions(-)
> 
> diff --git a/tools/tests/vpci/emul.h b/tools/tests/vpci/emul.h
> index 2e1d3057c9d8..d018fb5eef21 100644
> --- a/tools/tests/vpci/emul.h
> +++ b/tools/tests/vpci/emul.h
> @@ -44,6 +44,7 @@ struct domain {
>  };
>  
>  struct pci_dev {
> +    bool vpci_lock;
>      struct vpci *vpci;
>  };
>  
> @@ -53,10 +54,8 @@ struct vcpu
>  };
>  
>  extern const struct vcpu *current;
> -extern const struct pci_dev test_pdev;
> +extern struct pci_dev test_pdev;
>  
> -typedef bool spinlock_t;
> -#define spin_lock_init(l) (*(l) = false)
>  #define spin_lock(l) (*(l) = true)
>  #define spin_unlock(l) (*(l) = false)
>  
> diff --git a/tools/tests/vpci/main.c b/tools/tests/vpci/main.c
> index b9a0a6006bb9..26c95b08b6b1 100644
> --- a/tools/tests/vpci/main.c
> +++ b/tools/tests/vpci/main.c
> @@ -23,7 +23,8 @@ static struct vpci vpci;
>  
>  const static struct domain d;
>  
> -const struct pci_dev test_pdev = {
> +struct pci_dev test_pdev = {
> +    .vpci_lock = false,

Nit: vpci_lock will already be initialized to false by default, so
this is redundant.

>      .vpci = &vpci,
>  };
>  
> @@ -158,7 +159,6 @@ main(int argc, char **argv)
>      int rc;
>  
>      INIT_LIST_HEAD(&vpci.handlers);
> -    spin_lock_init(&vpci.lock);
>  
>      VPCI_ADD_REG(vpci_read32, vpci_write32, 0, 4, r0);
>      VPCI_READ_CHECK(0, 4, r0);
> diff --git a/xen/arch/x86/hvm/vmsi.c b/xen/arch/x86/hvm/vmsi.c
> index 13e2a190b439..1f7a37f78264 100644
> --- a/xen/arch/x86/hvm/vmsi.c
> +++ b/xen/arch/x86/hvm/vmsi.c
> @@ -910,14 +910,14 @@ int vpci_msix_arch_print(const struct vpci_msix *msix)
>          {
>              struct pci_dev *pdev = msix->pdev;
>  
> -            spin_unlock(&msix->pdev->vpci->lock);
> +            spin_unlock(&msix->pdev->vpci_lock);
>              process_pending_softirqs();
>              /* NB: we assume that pdev cannot go away for an alive domain. */
> -            if ( !pdev->vpci || !spin_trylock(&pdev->vpci->lock) )
> +            if ( !spin_trylock(&pdev->vpci_lock) )
>                  return -EBUSY;
> -            if ( pdev->vpci->msix != msix )
> +            if ( !pdev->vpci || pdev->vpci->msix != msix )
>              {
> -                spin_unlock(&pdev->vpci->lock);
> +                spin_unlock(&pdev->vpci_lock);
>                  return -EAGAIN;
>              }
>          }
> diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
> index 1fad80362f0e..af648c6a19b5 100644
> --- a/xen/drivers/passthrough/pci.c
> +++ b/xen/drivers/passthrough/pci.c
> @@ -328,6 +328,7 @@ static struct pci_dev *alloc_pdev(struct pci_seg *pseg, u8 bus, u8 devfn)
>      *((u8*) &pdev->bus) = bus;
>      *((u8*) &pdev->devfn) = devfn;
>      pdev->domain = NULL;
> +    spin_lock_init(&pdev->vpci_lock);
>  
>      arch_pci_init_pdev(pdev);
>  
> diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c
> index 40ff79c33f8f..bd23c0274d48 100644
> --- a/xen/drivers/vpci/header.c
> +++ b/xen/drivers/vpci/header.c
> @@ -142,12 +142,13 @@ bool vpci_process_pending(struct vcpu *v)
>          if ( rc == -ERESTART )
>              return true;
>  
> -        spin_lock(&v->vpci.pdev->vpci->lock);
> -        /* Disable memory decoding unconditionally on failure. */
> -        modify_decoding(v->vpci.pdev,
> -                        rc ? v->vpci.cmd & ~PCI_COMMAND_MEMORY : v->vpci.cmd,
> -                        !rc && v->vpci.rom_only);
> -        spin_unlock(&v->vpci.pdev->vpci->lock);
> +        spin_lock(&v->vpci.pdev->vpci_lock);
> +        if ( v->vpci.pdev->vpci )
> +            /* Disable memory decoding unconditionally on failure. */
> +            modify_decoding(v->vpci.pdev,
> +                            rc ? v->vpci.cmd & ~PCI_COMMAND_MEMORY : v->vpci.cmd,
> +                            !rc && v->vpci.rom_only);
> +        spin_unlock(&v->vpci.pdev->vpci_lock);
>  
>          rangeset_destroy(v->vpci.mem);
>          v->vpci.mem = NULL;
> @@ -285,6 +286,12 @@ static int modify_bars(const struct pci_dev *pdev, uint16_t cmd, bool rom_only)
>                  continue;
>          }
>  
> +        spin_lock(&tmp->vpci_lock);
> +        if ( !tmp->vpci )
> +        {
> +            spin_unlock(&tmp->vpci_lock);
> +            continue;
> +        }
>          for ( i = 0; i < ARRAY_SIZE(tmp->vpci->header.bars); i++ )
>          {
>              const struct vpci_bar *bar = &tmp->vpci->header.bars[i];
> @@ -303,12 +310,14 @@ static int modify_bars(const struct pci_dev *pdev, uint16_t cmd, bool rom_only)
>              rc = rangeset_remove_range(mem, start, end);
>              if ( rc )
>              {
> +                spin_unlock(&tmp->vpci_lock);
>                  printk(XENLOG_G_WARNING "Failed to remove [%lx, %lx]: %d\n",
>                         start, end, rc);
>                  rangeset_destroy(mem);
>                  return rc;
>              }
>          }
> +        spin_unlock(&tmp->vpci_lock);
>      }
>  
>      ASSERT(dev);
> diff --git a/xen/drivers/vpci/msi.c b/xen/drivers/vpci/msi.c
> index 5757a7aed20f..e3ce46869dad 100644
> --- a/xen/drivers/vpci/msi.c
> +++ b/xen/drivers/vpci/msi.c
> @@ -270,7 +270,7 @@ void vpci_dump_msi(void)
>      rcu_read_lock(&domlist_read_lock);
>      for_each_domain ( d )
>      {
> -        const struct pci_dev *pdev;
> +        struct pci_dev *pdev;
>  
>          if ( !has_vpci(d) )
>              continue;
> @@ -282,8 +282,13 @@ void vpci_dump_msi(void)
>              const struct vpci_msi *msi;
>              const struct vpci_msix *msix;
>  
> -            if ( !pdev->vpci || !spin_trylock(&pdev->vpci->lock) )
> +            if ( !spin_trylock(&pdev->vpci_lock) )
>                  continue;
> +            if ( !pdev->vpci )
> +            {
> +                spin_unlock(&pdev->vpci_lock);
> +                continue;
> +            }
>  
>              msi = pdev->vpci->msi;
>              if ( msi && msi->enabled )
> @@ -323,7 +328,7 @@ void vpci_dump_msi(void)
>                  }
>              }
>  
> -            spin_unlock(&pdev->vpci->lock);
> +            spin_unlock(&pdev->vpci_lock);
>              process_pending_softirqs();
>          }
>      }
> diff --git a/xen/drivers/vpci/msix.c b/xen/drivers/vpci/msix.c
> index 846f1b8d7038..5310cc3ff520 100644
> --- a/xen/drivers/vpci/msix.c
> +++ b/xen/drivers/vpci/msix.c
> @@ -225,7 +225,7 @@ static int msix_read(struct vcpu *v, unsigned long addr, unsigned int len,

I think you also need to add locking to msix_find, otherwise it will
dereference pdev->vpci without holding the vpci_lock.

It might be a better approach to rename msix_find to msix_get and
return the vpci_msix struct with the vpci_lock taken, so we can assert
it's not going to disappear under our feet. Then you will also need to
add a msix_put function that releases the lock.

>          return X86EMUL_OKAY;
>      }
>  
> -    spin_lock(&msix->pdev->vpci->lock);
> +    spin_lock(&msix->pdev->vpci_lock);
>      entry = get_entry(msix, addr);
>      offset = addr & (PCI_MSIX_ENTRY_SIZE - 1);
>  
> @@ -254,7 +254,7 @@ static int msix_read(struct vcpu *v, unsigned long addr, unsigned int len,
>          ASSERT_UNREACHABLE();
>          break;
>      }
> -    spin_unlock(&msix->pdev->vpci->lock);
> +    spin_unlock(&msix->pdev->vpci_lock);
>  
>      return X86EMUL_OKAY;
>  }
> @@ -297,7 +297,7 @@ static int msix_write(struct vcpu *v, unsigned long addr, unsigned int len,
>          return X86EMUL_OKAY;
>      }
>  
> -    spin_lock(&msix->pdev->vpci->lock);
> +    spin_lock(&msix->pdev->vpci_lock);
>      entry = get_entry(msix, addr);
>      offset = addr & (PCI_MSIX_ENTRY_SIZE - 1);
>  
> @@ -370,7 +370,7 @@ static int msix_write(struct vcpu *v, unsigned long addr, unsigned int len,
>          ASSERT_UNREACHABLE();
>          break;
>      }
> -    spin_unlock(&msix->pdev->vpci->lock);
> +    spin_unlock(&msix->pdev->vpci_lock);
>  
>      return X86EMUL_OKAY;
>  }
> diff --git a/xen/drivers/vpci/vpci.c b/xen/drivers/vpci/vpci.c
> index fb0947179b79..c015a4d77540 100644
> --- a/xen/drivers/vpci/vpci.c
> +++ b/xen/drivers/vpci/vpci.c
> @@ -35,12 +35,10 @@ extern vpci_register_init_t *const __start_vpci_array[];
>  extern vpci_register_init_t *const __end_vpci_array[];
>  #define NUM_VPCI_INIT (__end_vpci_array - __start_vpci_array)
>  
> -void vpci_remove_device(struct pci_dev *pdev)
> +static void vpci_remove_device_locked(struct pci_dev *pdev)

Nit: since it's a static function you can drop the vpci_ prefix here.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Feb 02 09:45:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 09:45:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.263924.456809 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFCCv-0005mn-E4; Wed, 02 Feb 2022 09:45:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 263924.456809; Wed, 02 Feb 2022 09:45:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFCCv-0005mg-Ac; Wed, 02 Feb 2022 09:45:45 +0000
Received: by outflank-mailman (input) for mailman id 263924;
 Wed, 02 Feb 2022 09:45:43 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=6WyI=SR=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nFCCt-0005Fs-FV
 for xen-devel@lists.xenproject.org; Wed, 02 Feb 2022 09:45:43 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e30fe425-840c-11ec-8eb8-a37418f5ba1a;
 Wed, 02 Feb 2022 10:45:42 +0100 (CET)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2105.outbound.protection.outlook.com [104.47.17.105]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-20-DrNSgyfJMGGvBPgYwvXOMQ-1; Wed, 02 Feb 2022 10:45:41 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DB7PR04MB5434.eurprd04.prod.outlook.com (2603:10a6:10:82::16) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Wed, 2 Feb
 2022 09:45:39 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.012; Wed, 2 Feb 2022
 09:45:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e30fe425-840c-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1643795142;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=6xf/y63tjY8CmS0eXssPU4mrQyX/p6vWs8DnJwQvzOY=;
	b=XsBu0iqWD7v+V5O2OCZW4XMccMN9gRW0WZOni0ea6CQ4F9oGSikQJIDLZX7Q7WTEjR5VcP
	cfU/Lm9Aa5ecHX60lkhjFdnp4vPlxb+e1sQci/IxJ4H7obPJCi/IlFHfze6AzK4zSq2cgL
	WEbjIlfvMA4p30A9xrHgDVLBBvEpmMk=
X-MC-Unique: DrNSgyfJMGGvBPgYwvXOMQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=bxgIiNl7+BI5SNndMyX5JFXt6+oGrUA7eAjeLdOmxEFZa+YTr5ZLu5ZzsLmAox5kHfvZcEOzU5beMF+OTodKagCzaX+yZVPJMKLq/ux1bQFArMRM75wUoPMT+BjBtY4ZkFgPLxKcgnUBsGGJuBNS+8HqNgkKgY3A3gbjIrAQ2ovwHXIX1AI7n0+0jC2y4Sxcl9imy+pcqh+UoLXkZlCjzX35aT7mt/I5bVBbHhhY0TBRkJpp1TyTx0A6a98DoOEBYZtILbegXv/ApHwxIULDThnpHwM0W7wryAYipM4YbWSi1QwYYNyERFheghPUJh6LF0R45GwoKnXKq9ivA5ssMw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=38KqB/pz7E1R24DzSWB/rtLbom9TUxNVmGGRWGYAytw=;
 b=FP1zQkqlDtz3AsDjxI8z6Nuu6+DAdZWn01iyglK0ELXdpJFF745edv7iYh1k+fUEYRDWcIgTdbLNlxHY/qPlyANq3uO63dHK0K4sEU9KmmpkwbvKbo8MxqNr7QABgF4v03i7sQpsYLk/wbI/sCxRiV6pFYTNYXQqhjjoMcgo7RdC2c8oBteFiODo8lFRSkbHniyyiK4GZuzzvnnJAbeQtMhkgUG3ZfJlQvwbA/s3ACL2A8vgNTBdL/NoeHlmXpywVD0U6IepFN6q2Y6q9NKPy2TpiK8bFgUXzC19M4DlIi4vP0EXuiuQSeJlFqHM4IpyVYzr3A1BmFl+xYoO1l5ZMQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <a4a78b7f-126a-3c18-6f93-2d0bd768f74a@suse.com>
Date: Wed, 2 Feb 2022 10:45:36 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH 3/4] vpci: shrink critical section in vpci_{read/write}
Content-Language: en-US
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "julien@xen.org" <julien@xen.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
 "paul@xen.org" <paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>
References: <20220201162508.417008-1-andr2000@gmail.com>
 <20220201162508.417008-4-andr2000@gmail.com> <YfpEiWT0NpYNSAks@Air-de-Roger>
 <5ed821ac-0a38-3c1a-a28a-c46295c2ffb4@suse.com>
 <5ec87648-2783-d21a-ca7d-dc59180543d9@epam.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <5ec87648-2783-d21a-ca7d-dc59180543d9@epam.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0245.eurprd06.prod.outlook.com
 (2603:10a6:20b:45f::13) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5ea827a2-8d58-46f7-c059-08d9e630c539
X-MS-TrafficTypeDiagnostic: DB7PR04MB5434:EE_
X-Microsoft-Antispam-PRVS:
	<DB7PR04MB54345FA5D5E6B8B60D2E3EE6B3279@DB7PR04MB5434.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	w6pWqBt134avTBpk79StwhoDWVnmpaLsOlW5sGlyR7ZbrkxN3Pl1fw0AZX915bY2hSh08iu5AEBDTPHho0TWuOMw3lCPVgBeYLY0D0mMfwSXN5J/xe9mkaJJQ8ql+EJzjciLfGp2uqH8aXToCXLxkSLI4aL34dl4/soZor5AP91AHxqAEwjvX76ATwEup+33U/XPQAuHE/fA0QHUnXUOgCtoVqqwYILJREK+KEiGcXlSzz1JTDOyUDyy25eVGvHvKwuxHzugT8I1uHEA+rm6mbX5kqh+3GiOKeCt2T+f4Ne79mzJ/jIou8mUfnjnWak1V5VvJ5JoI39tfKTNPoTyoKFst97Oou7JTwlnmEPStBxdB2OFdi4tQn5dFjwKfRBhART6KP5eVoWnl9l3U70SsPUn98OiPDNTS6zoT6Z5TUCleNLjnOzGOcwJYuOjqHXsNHJNW4vaosvdO/Ve+6Ey+n/nZCRngWJDnpNazkHhd1HAEmKl6VFkPPnhzfDsLQw72C5ohJ5zbyT4XiwgdN/rLrfA+gSKtY2/7M7yk4IrTblayB6s8RYq5GxYx7TcBpPPTnKjxmVRpPpbRR0CbYn6q4vrzM2hi2u0d4zHaTZpABW2qfDN4VCKaS18l9Kxbo+wkjHRFQkSoueucDicuAVFcODv/L8D3UGuK/2M/g3ouVGu4End0ruCmKcItlti7pArKjBGKt9MvRD3SzkFcwxugzXB2IAAJY3BxQmmKc6L9z4=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(7416002)(186003)(26005)(5660300002)(2616005)(6486002)(316002)(6666004)(53546011)(31686004)(6506007)(6512007)(66946007)(54906003)(36756003)(6916009)(83380400001)(2906002)(8936002)(8676002)(508600001)(66556008)(4326008)(31696002)(38100700002)(66476007)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?MUWovWxHqPVyMrr+mO/yz3fYNh1efSIquloiX3YdHtHRrKP9Q6d94PLMlXIW?=
 =?us-ascii?Q?5Gm2xo0fPyWqy7DDc15BVlJLx+B4hd+L4DSCLG3C9lFhMSrdA0k3VUqDgQpQ?=
 =?us-ascii?Q?P2cA/JdEmSf0Au7j/YfXEtOBgDwqlnEaHaoDpG+7wu0fVDJ69XUyxHbWPH/u?=
 =?us-ascii?Q?Ym3Sm7lOf1aPeYC5LKQS3wKCXZApa42Z81O2N5qXHUd/f7QI9IYcx85l95Hr?=
 =?us-ascii?Q?rPAliUoJFL6bxpD0rStoJRtcjDuvJJ753tY4PmnqO1DMerqZkjobW4Kiw3WB?=
 =?us-ascii?Q?cNIWXJgovCocOR6W8rkVu+/nFzyL6gIdJaxu+Fo23WntYBttR3VYImsrFqMi?=
 =?us-ascii?Q?BGI7sGRtMHqiRz4wD1mdfRI5x61H/qW95vUIHtRmb4ITdKb20YQihGIfEyQi?=
 =?us-ascii?Q?Ljv1pCEEwsQ540cyebobuncUDKtRXEc0oCdzyk4ly2ApZ7vJPK6zVuDIJELC?=
 =?us-ascii?Q?sKQTW28MW3Zt05yLUJJZY/AQAsXXcRfrtjEJXTqMZjgQHSeGwJH624GwpzP2?=
 =?us-ascii?Q?QOIp9wpJ+oKAzj0+w0SiBgI4UrXH9rLDTBFcs8fm/pd2zcDCkd66dztIfx/C?=
 =?us-ascii?Q?TbQOnqCkdJ1NudpMzXm3L0FvM599BrF7tY6xT5CDsAB74R945WZ7J7/3TTY3?=
 =?us-ascii?Q?Q+vnPwy+yv5T+95mNrjJuWBENfh/n0ZFaA7BadKxuX/ok4XQgfkgVll74glV?=
 =?us-ascii?Q?f9FQ/xUMlH6P4iAUV3uqwA82GGGKu4tr3YXhsZJZ1xlaT9G698hGAhWhDiGq?=
 =?us-ascii?Q?hvE+KMfhXI58gEV/eLqJFRCbmOJ1KjSn18+viV09VenjHZCWUgZmJA9C/zX1?=
 =?us-ascii?Q?gzg9eneDdJblOm7MBECr3v1EqGbWi+CiGu/ofhlGJEhEPAied857zX+94rNp?=
 =?us-ascii?Q?JGy2gDGSwSPNH9Gp9IiYPnKinkJUbiSMBBCA3IxFNMVzNOH9jPCO4u4gr8Sk?=
 =?us-ascii?Q?1LoPi8tKp6AJwaH96YFRv1QxomlBcPQJsaT+9x9j/rahzbYb5/7Q1rjapan3?=
 =?us-ascii?Q?2tc7PVywVhkyAVC1OiZuiCMqpX8BDpciSlKrZVbG0TX5/T0yS4/R/GwvTR3e?=
 =?us-ascii?Q?Dqt7YM1IqLKX/BBiCgbBf51QHmEeLAQDFXBfiYw2ugWbCm2PUBZlHdH4C0+c?=
 =?us-ascii?Q?K4GUkChwYkaMhY5KDlbj5xn7DaNyq3j2/8BXXfhmhl5pWlwag9oIQLEp3Htm?=
 =?us-ascii?Q?Ij0kRauuYPYEMilJ8lfMg9EZYOLZd6w+DIRpAwecTo+3x2VOnvePX6igcSbN?=
 =?us-ascii?Q?7n0GGxc1hPGENO2vlQ519mEfWfbG/5Ta69M6KYVZ9cxRJi5HtV0QRiqykBRR?=
 =?us-ascii?Q?or+SdfmDyu0IoewugXzxrNZRn3cXz4jaFAoaTRB5rLjnyjWZmYqvinhMSu0t?=
 =?us-ascii?Q?JVhUQxgjrRPphQ0JPGS6DO0dTD3ZZzi0LFisKKERRj8MCcVwA8ii3E+zh4Ne?=
 =?us-ascii?Q?FOSIi4Ry0jXlAd+w0ZaHf0+wlSzKmGSS/yx3cY7hDroxwQksnLxv9bGtfZao?=
 =?us-ascii?Q?lJXRq4o7qUQax5/CgDjlBLXg7/BNmkPg/cY/x3w4lhKJa1A1KCexm4ZKfCsD?=
 =?us-ascii?Q?oVPqB1zVKqrdQGljkDyYsUw33x3ZFpBeKDLrtfh3l8sS1w8vWwmPWDtj0FBy?=
 =?us-ascii?Q?eGZ7pM6xkV9wsZPk43h+/zE=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5ea827a2-8d58-46f7-c059-08d9e630c539
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2022 09:45:39.2757
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pbQ/ZKZhOlzm/cVe9NJhc+cfLBnOD+rGQH6MowYQM3UTdWcsy5UkRI4fTcvByfS1gAL+90ISYEevbL6iMx3HEA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB5434

On 02.02.2022 10:38, Oleksandr Andrushchenko wrote:
> On 02.02.22 11:05, Jan Beulich wrote:
>> On 02.02.2022 09:44, Roger Pau Monn=C3=A9 wrote:
>>> On Tue, Feb 01, 2022 at 06:25:07PM +0200, Oleksandr Andrushchenko wrote=
:
>>>> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>> Oleksandr, can you please clarify authorship here? The rule of thumb is
>> that From: matches ...
>>
>>>> Shrink critical section in vpci_{read/write} as racing calls to
>>>> vpci_{read,write}_hw() shouldn't be a problem. Those are just wrappers
>>>> around pci_conf_{read,write} functions, and the required locking (in
>>>> case of using the IO ports) is already taken care in pci_conf_{read,wr=
ite}.
>>>>
>>>> Please note, that we anyways split 64bit writes into two 32bit ones
>>>> without taking the lock for the whole duration of the access, so it is
>>>> possible to see a partially updated state as a result of a 64bit write=
:
>>>> the PCI(e) specification don't seem to specify whether the ECAM is all=
owed
>>>> to split memory transactions into multiple Configuration Requests and
>>>> whether those could then interleave with requests from a different CPU=
.
>>>>
>>>> Signed-off-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>
>>>> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.c=
om>
>> ... the first S-o-b, as these are expected to be in chronological
>> order.
> Well, I was not sure here: the idea and the original code belongs
> to Roger and it was a part of a dedicated other patch. So, technically,
> this patch didn't exist before and Roger hasn't created it (the patch).
> So, this is why I'm in doubt here: should I change the authorship
> to Roger's? I had no means to offend anyone here nor I pretend
> for the authorship in any form.

My personal view on it is that if you've broken this out of a larger
patch coming from Roger, then he should be named as the author.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Feb 02 09:46:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 09:46:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.263930.456820 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFCDh-0006PP-NK; Wed, 02 Feb 2022 09:46:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 263930.456820; Wed, 02 Feb 2022 09:46:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFCDh-0006PI-Jp; Wed, 02 Feb 2022 09:46:33 +0000
Received: by outflank-mailman (input) for mailman id 263930;
 Wed, 02 Feb 2022 09:46:31 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1p3Q=SR=epam.com=prvs=40324c57ab=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nFCDf-0006NI-AG
 for xen-devel@lists.xenproject.org; Wed, 02 Feb 2022 09:46:31 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id fe9f85fc-840c-11ec-8eb8-a37418f5ba1a;
 Wed, 02 Feb 2022 10:46:30 +0100 (CET)
Received: from pps.filterd (m0174677.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 2129hDSd002309;
 Wed, 2 Feb 2022 09:46:25 GMT
Received: from eur05-db8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2104.outbound.protection.outlook.com [104.47.17.104])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3dyqb383ht-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 02 Feb 2022 09:46:25 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by DB6PR0302MB2695.eurprd03.prod.outlook.com (2603:10a6:4:ac::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.11; Wed, 2 Feb
 2022 09:46:21 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6%3]) with mapi id 15.20.4951.012; Wed, 2 Feb 2022
 09:46:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fe9f85fc-840c-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=i4ZRstFd4NjMm+0N3pE8pWDGSkydhfhtUXpCeuVEVGabFuC9vqHT+AktvwI9W3yz47FLITOgDs1hbCmY3GyemxhHApKCeB5hL6KyyK2VI7hxrSYaU3p0qpcw/HigH3wlh7HzAaYOZY+7zrqXZ6C8FZzOz6WXFY2IOahLHwx6r1EpzzjmaufLjuWUvKTk9yMX1k0M5Kkr/KbmY9n4e8RGO/iLDpCnvdzp56CoUlmQ+0/HCgJSXdAML7VJR2gbdi2jgeVqzTeph0bEeqL8jj3tAm201ayMuynN6vkeg5UHyyk8xrlldAfgQPIDsoMWR0eGxgkrgL5eep8U2U/CCJZOIQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=iA4LZTax/R3jrd0l/GKf+9pGXojd8gXV7E28ZZHIn3w=;
 b=JEOEBRfKOvYPRhVBkr1BNQHwiVVxQqzxzpgSgQHSjGWy1yjAR3RNN0jIDznkJf5ZSKrJ1d20YyTiSOgv1h9XkU+EYqVZhXYqV0RUczAwkXpMorf/ndUfkGBq2OEI2mJSLwKjzBJUfrfETX75AU6Ffce/f8uU10EoW9f0Sxr64RH3Bao4A8kyMWWoXWmuLRVZ6orJaE6Q+iE65gpVSRluQjMWxgycrbMAdQYuH8HAg6xQJ425CsCotFe2bmBmBILLmva5BLxzlfTsgjBl8pyk6XEdkUTYL8FlyAZ/4iSLnkY/qqgAEHivKlGenEkVG5iZleuFd9u1uAGxoFSppnFDVg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=iA4LZTax/R3jrd0l/GKf+9pGXojd8gXV7E28ZZHIn3w=;
 b=iDWSmYmMPTAM+Yl1Cg1nJ+YLv/qOU3wo/8dMcLVEvEFDXD1xGkrONbnZM0QOQWfXDLT+0mVyfzJxdc7z1gykGYjBq5KF1u3JWb80oS0Y29WLpRqAX1D8bE21YDxau45VQaLruCa2BJLLo9oqqHQklSBLgT144SPwvW9XWh5hiaBfZEtj6NmjsmGUXGyUjziAixz9J/PipiWszbgsyau1ion8svVW4hLig+jtgjzv609oK05x388QE31YOzFa16TzZm2vZgeJLP7DR2qZtCIA95uYgoplmAjUN3GMBbMNJoLoCkm0V+dHqZZe6B15nVjRUOhLruGHakDoatQmhnmE1w==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "jbeulich@suse.com" <jbeulich@suse.com>,
        "andrew.cooper3@citrix.com"
	<andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com"
	<george.dunlap@citrix.com>,
        "paul@xen.org" <paul@xen.org>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>,
        Rahul Singh <rahul.singh@arm.com>,
        Oleksandr
 Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v5 08/14] vpci/header: program p2m with guest BAR view
Thread-Topic: [PATCH v5 08/14] vpci/header: program p2m with guest BAR view
Thread-Index: AQHX4ewInH3i1A85zUqSOqe7J03BoaxhCwuAgB9Nb4CAABckAA==
Date: Wed, 2 Feb 2022 09:46:21 +0000
Message-ID: <2282e7c5-ba1b-e2a2-af4a-84a894211870@epam.com>
References: <20211125110251.2877218-1-andr2000@gmail.com>
 <20211125110251.2877218-9-andr2000@gmail.com> <Yd/9W7GFO51GE0ch@Air-de-Roger>
 <37c2374d-c0f7-23b6-d2f8-e94d1348807c@epam.com>
In-Reply-To: <37c2374d-c0f7-23b6-d2f8-e94d1348807c@epam.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 28e42b1b-0c42-4491-a49a-08d9e630deb2
x-ms-traffictypediagnostic: DB6PR0302MB2695:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <DB6PR0302MB269536A43D3A58A2B55284C0E7279@DB6PR0302MB2695.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:4714;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 z/3CeMkG0s+HgH6Xrk2upYtvDwyfeO81XsVZvBjZV/jT80V16xcHODwH/WE+WCdIYTRJnoMl/VeG3w/jxuVe5eY11JNRvp4Qfnzc2KqSgud7W+s283+IxsrrFu0r/2O8Re1qq1UBVdOVcHcu6lLxIpX++9J18mCBBXunOFocaF4T1khSRbninE6eMvSolrZAkDk8GweOyQwKeVp4e5SSdOWgQaPwrXf41Zdm8ZAE66jVdHqAqsG922rfb4NbGBGX7c+XoegmSHZe+RAZGra8mn3BdOv+XPebge2kxWsBOkqDrI8wa0kPi9lansp/rxA9qbQ4zh3W4bBVkKm6JHpc54Sb+0frl+M+D4ZGdHVFPUkXHP75ftc3BWFM4p69GICZTkHKdiCPg/8HLdRtU6f7b1cm5KwDAAQ0ny8pe1TvTvOLF1URyUuP7SCBunjwPVDTOy/rfKs2pYHNK2rr4YTCdBa+lJc1u3tBSkV6CmaKRwKPWan7nXYg3NnEOpy0gHXVjwPxZrHPF7LgeGvEkPx0tAws7jGrF08K7i1yE6H+ygBZ9Sq8Xi66OXAm2wan+XhopXcHb3Or4aOk+6xVsi2qn0vCoMMkEr+rrJNHhU3Lghb+CYB/R+3eDrRyZoKuYMfoeQ4qwMwxjMKuvyeIWQmU10W1++ohjc250wrSLG9uiDBIASu3zhwgqZ6YmC3Ph9EtCA4oytHfG0Zt4MX1OKX903pl1RP0PcmqRDBT2No6b3k7dBIeL4unCt6NN7C/lvEW
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(71200400001)(107886003)(36756003)(2616005)(6486002)(508600001)(31686004)(26005)(6512007)(6506007)(186003)(2906002)(7416002)(8936002)(8676002)(66446008)(6916009)(66476007)(38070700005)(4326008)(5660300002)(38100700002)(91956017)(76116006)(66946007)(31696002)(64756008)(66556008)(54906003)(316002)(86362001)(122000001)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?TFpJRExXSmFnSDI0RVJjQ2NYYVBySmlNYWl0WlRXNldZTjQ0SU5McU9rZlRw?=
 =?utf-8?B?VjRUZGlJVUQ2cU02UmQzNVhLR2R2MGhldDBQM3hBekN2eitiTVhGakpWUjVV?=
 =?utf-8?B?Q0crcWt3ck9Za2RYT1dSeWVpMGlva2VYanJIb1pCVEpYSTEyVlpzZHdnanNz?=
 =?utf-8?B?SnM1bEJpTTdES0RxdFlqcVZaa2NTR3NIK2VkODhVTTFNSzFDSHNVN01zZERI?=
 =?utf-8?B?TG9RTmlnZ2RZSTNtOVRGeU5YNXVrbVpXRzY2QXNxZ3RvdVM3cVNGSjUvalZv?=
 =?utf-8?B?Z2oxNEczVzU2VkU5OWtLNllhTEZGeEh0eHVYRDQvU1hXM1ZRNmJ1YTdPTTcy?=
 =?utf-8?B?ZHY5dmp2UDJQd0ExV2YydjRBUndQc2UzM1Ywd2dCNVAwRUZ5SllxRzFLa2kx?=
 =?utf-8?B?Yk42REQ5UmoyZjdteW9Uc3BCN2c2bUtqWnlzTnh6UytlTllTVFZQaWV5K2Rx?=
 =?utf-8?B?YkVjN09GdEREakJOQ3I2VThKdzNkWTY5WVBwUmtHZjFONnZ6QVJCV3JZUGNK?=
 =?utf-8?B?dThiZkc5RlQ4cDVzWXNHVW5MVjFrWm1QbGtkT280Q3h6cm1TckJmRzMwclJZ?=
 =?utf-8?B?R0Q4QVlQTWdJOFZYOWhXbHBGMm5EczlNMzRkeGpnSjEvOGVZZjdqYVRSNE9v?=
 =?utf-8?B?dTNRTnhGMHlvOXdXOEJKRWo5WDM2ZjR0Y1hSdUZNOE9ZMlB2UEFENGFJckln?=
 =?utf-8?B?Y2lNWDJvOFM4bmJSenhsWnIyRGRWM2lWbkFsYXRLMHYrcjZMVURxRzdXdUdG?=
 =?utf-8?B?cVJRT2dESTFDTEpZcm5QUCtITmJOcnU2OXhCMkxVSk9UVnVaSFQzNkx3a1o1?=
 =?utf-8?B?QXdpbVk4T3BwV20zWGlWMVZZNko2Tk5pNDVtSlo3dDd1TitTbHgwRVhpMGlC?=
 =?utf-8?B?M3RnZUp4MllKcjMvYk5Qb0cvMzIzcWppeElYQUExSnFmUnhxL0IzclljeWJF?=
 =?utf-8?B?WVBKNFU5VzFqd01vY3BNYmdZNzBNVWcvVzFEMi9PZGtWTUtISi9FNnZSc1E0?=
 =?utf-8?B?MkNoR3JUNUlVbnNSYjZCZFIxc1JtaCsvVWd6WERCdHJBR3pVdGN1Q2Zud2VR?=
 =?utf-8?B?L28wbVdpZk5xWFBuRVEveHl1djhtOUNZcFdtaS9kSUtHeW5aTmQ3MmZBTm80?=
 =?utf-8?B?ZXF4SVNMN05vWTFLTGNpd1c1VkJJQk84UVNrVkhFSGoza1dvdVBsbTRGdGtQ?=
 =?utf-8?B?Z3ozb2VWNXFab3ZiTGdRZUUyTjNTWnRpZ2d2dThwVjhMaU56UEtocFJFd09y?=
 =?utf-8?B?NW4vOU91ZS8zTHVlTUZPSTQ4TmVjb1pzR2kzSHg2ZUdBcFFmWGtlc3pKZ1dt?=
 =?utf-8?B?b3JtdEdhVm1nYnlPZUcwY01iYmI2akdmdzljTEw3WHV5MmxFMVhIKzY3d0hM?=
 =?utf-8?B?SjRRZG50cFdzQ2RWd0J2cnR1N1dzTUtsb3lPUWIrNW9lMWxDNUlPejBqL09B?=
 =?utf-8?B?cmMrMmd3dVR3Q0V4WW9uSEZTOU5Cb0xOTklCU0Vvc0d1QnFSRWFOMnRhNkRz?=
 =?utf-8?B?QXpKSWRTU3lub1pxNWlyNm1mdDFKWGtoMmdBMWZub01VZGJpTlJaRUFoZ1Fk?=
 =?utf-8?B?VVh2WElOU09aNTloVDVrRUVxUEtuMjFNcTJkVTNnN0ZFTTFGcGFjTkZnVXdK?=
 =?utf-8?B?RzF4UXpnWEgzSTdqelRVRHVBMkV3Ui9TRWNvQmliUHFvdzl6MWtuR2dYbHQ4?=
 =?utf-8?B?emJOTTljL29zL1QycXBoNWRObDAxMmorOFRtR0FrS3l6ejdXZUVXTHVKaVJj?=
 =?utf-8?B?d05pbWduN3BWek5KZ2VPRWVHc2VuYjNQQWtDcVVBN0xjaTlMays5NkI2OUlx?=
 =?utf-8?B?UXRQaGZickp1Uk1ibCtqZ2lJRUwzTjFramg5U2l6U3doVHlEcys2YkcwYmVR?=
 =?utf-8?B?YWlvWlAzeUNnSnEvNzcwcmtsN0QwZEJRQURVa2JtUGtHQ1RDODRSVlhyZ3VD?=
 =?utf-8?B?cE82VWIxVWtqNXVHVmRsNE1Kb3BTcHlYTld1RVNZakFaK09EeEQreXYvejVN?=
 =?utf-8?B?UDJvTXR3WG4xdUpQeDEyN0RKYU5CNy9xUC9WVjZzUjEybXduRmM3Z3QzRlpR?=
 =?utf-8?B?cXMwUFd0V2JYbGx6aFJxUnpMZHVXRndzS3J4UmdDTkkxeXlrM2dKOTFNUDVZ?=
 =?utf-8?B?SE1JT05OUVRSWmVIc3VtaWlGbU5uVGRpSnNBU0FqM0Q0VlBKbkRWeVFMQXJi?=
 =?utf-8?B?bXNicURNSUF2ZmJ1RW9QYlA2dXMzNjFFRVk2blljU1JiZzF6QmU3MjdONzFq?=
 =?utf-8?B?RG5tV2ZxYnFKWVlEUHhZamRJb3dCd3A3cmtJK1lsa29UVmppN1ZhWWFYZ0l6?=
 =?utf-8?B?amRyYkNPYmxCV25QTEl0TUppc2FUTlowbE5EWW5aZFlUZXVBUXpVQT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <17E953E294306A4596583D6020BB04C8@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 28e42b1b-0c42-4491-a49a-08d9e630deb2
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Feb 2022 09:46:21.7922
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 6OWBWstaJgxA9rZI7XVjz1c05mYEMkV39uSx1RXTJori5huRvYYD8LS6QF5tQIFaLOzBuePmhderw2N+45g+z17FB+rhhXaex6pV+HJenyO9qFeGWbhmJTmY/BCA9nnX
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0302MB2695
X-Proofpoint-GUID: rQ43dJEl3QSHUoqpK2BbUsHpzsipGWKq
X-Proofpoint-ORIG-GUID: rQ43dJEl3QSHUoqpK2BbUsHpzsipGWKq
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-02_03,2022-02-01_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501
 lowpriorityscore=0 phishscore=0 mlxscore=0 suspectscore=0 impostorscore=0
 bulkscore=0 clxscore=1015 malwarescore=0 adultscore=0 mlxlogscore=999
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202020051

DQo+Pj4gKyAgICAgICAgZ2RwcmludGsoWEVOTE9HX0dfREVCVUcsDQo+Pj4gKyAgICAgICAgICAg
ICAgICAgIiVzbWFwIFslbHgsICVseF0gLT4gJSMiUFJJX2dmbiIgZm9yICVwZFxuIiwNCj4+PiAr
ICAgICAgICAgICAgICAgICBtYXAtPm1hcCA/ICIiIDogInVuIiwgcywgZSwgZ2ZuX3goc3RhcnRf
Z2ZuKSwNCj4+PiArICAgICAgICAgICAgICAgICBtYXAtPmQpOw0KPj4gVGhhdCdzIHRvbyBjaGF0
dHkgSU1PLCBJIGNvdWxkIGJlIGZpbmUgd2l0aCBwcmludGluZyBzb21ldGhpbmcgYWxvbmcNCj4+
IHRoaXMgbGluZXMgZnJvbSBtb2RpZnlfYmFycywgYnV0IG5vdCBoZXJlIGJlY2F1c2UgdGhhdCBm
dW5jdGlvbiBjYW4gYmUNCj4+IHByZWVtcHRlZCBhbmQgY2FsbGVkIG11bHRpcGxlIHRpbWVzLg0K
PiBPaywgd2lsbCBtb3ZlIHRvIG1vZGlmeV9iYXJzIGFzIHRoZXNlIHByaW50cyBhcmUgcmVhbGx5
IGhlbHBmdWwgZm9yIGRlYnVnDQpJIHRyaWVkIHRvIGltcGxlbWVudCB0aGUgc2FtZSwgYnV0IG5v
dyBpbiBpbml0X2JhcnM6DQoNCmRpZmYgLS1naXQgYS94ZW4vZHJpdmVycy92cGNpL2hlYWRlci5j
IGIveGVuL2RyaXZlcnMvdnBjaS9oZWFkZXIuYw0KaW5kZXggNjY3YzA0Y2VlM2FlLi45MjQwN2U2
MTc2MDkgMTAwNjQ0DQotLS0gYS94ZW4vZHJpdmVycy92cGNpL2hlYWRlci5jDQorKysgYi94ZW4v
ZHJpdmVycy92cGNpL2hlYWRlci5jDQpAQCAtNTcsMTAgKzU3LDYgQEAgc3RhdGljIGludCBtYXBf
cmFuZ2UodW5zaWduZWQgbG9uZyBzLCB1bnNpZ25lZCBsb25nIGUsIHZvaWQgKmRhdGEsDQogwqDC
oMKgwqDCoMKgwqDCoMKgICovDQogwqDCoMKgwqDCoMKgwqDCoCBzdGFydF9nZm4gPSBnZm5fYWRk
KHN0YXJ0X2dmbiwgcyAtIG1mbl94KHN0YXJ0X21mbikpOw0KDQotwqDCoMKgwqDCoMKgwqAgZ2Rw
cmludGsoWEVOTE9HX0dfREVCVUcsDQotwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAg
IiVzbWFwIFslbHgsICVseF0gLT4gJSMiUFJJX2dmbiIgZm9yICVwZFxuIiwNCi3CoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBtYXAtPm1hcCA/ICIiIDogInVuIiwgcywgZSwgZ2ZuX3go
c3RhcnRfZ2ZuKSwNCi3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBtYXAtPmQpOw0K
IMKgwqDCoMKgwqDCoMKgwqAgLyoNCiDCoMKgwqDCoMKgwqDCoMKgwqAgKiBBUk0gVE9ET3M6DQog
wqDCoMKgwqDCoMKgwqDCoMKgICogLSBPbiBBUk0gd2hldGhlciB0aGUgbWVtb3J5IGlzIHByZWZl
dGNoYWJsZSBvciBub3Qgc2hvdWxkIGJlIHBhc3NlZA0KQEAgLTI1OCw2ICsyNTQsMjggQEAgc3Rh
dGljIHZvaWQgZGVmZXJfbWFwKHN0cnVjdCBkb21haW4gKmQsIHN0cnVjdCBwY2lfZGV2ICpwZGV2
LA0KIMKgwqDCoMKgIHJhaXNlX3NvZnRpcnEoU0NIRURVTEVfU09GVElSUSk7DQogwqB9DQoNCitz
dGF0aWMgaW50IHByaW50X3JhbmdlKHVuc2lnbmVkIGxvbmcgcywgdW5zaWduZWQgbG9uZyBlLCB2
b2lkICpkYXRhKQ0KK3sNCivCoMKgwqAgY29uc3Qgc3RydWN0IG1hcF9kYXRhICptYXAgPSBkYXRh
Ow0KKw0KK8KgwqDCoCBmb3IgKCA7IDsgKQ0KK8KgwqDCoCB7DQorwqDCoMKgwqDCoMKgwqAgZ2Zu
X3Qgc3RhcnRfZ2ZuID0gX2dmbihQRk5fRE9XTihpc19oYXJkd2FyZV9kb21haW4obWFwLT5kKQ0K
K8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoCA/IG1hcC0+YmFyLT5hZGRyDQorwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgIDogbWFwLT5iYXItPmd1ZXN0X3JlZykpOw0KK8KgwqDCoMKgwqDCoMKgIG1mbl90IHN0
YXJ0X21mbiA9IF9tZm4oUEZOX0RPV04obWFwLT5iYXItPmFkZHIpKTsNCisNCivCoMKgwqDCoMKg
wqDCoCBzdGFydF9nZm4gPSBnZm5fYWRkKHN0YXJ0X2dmbiwgcyAtIG1mbl94KHN0YXJ0X21mbikp
Ow0KKw0KK8KgwqDCoMKgwqDCoMKgIGdkcHJpbnRrKFhFTkxPR19HX0RFQlVHLA0KK8KgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgICIlc21hcCBbJWx4LCAlbHhdIC0+ICUjIlBSSV9nZm4i
IGZvciAlcGRcbiIsDQorwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgbWFwLT5tYXAg
PyAiIiA6ICJ1biIsIHMsIGUsIGdmbl94KHN0YXJ0X2dmbiksDQorwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqAgbWFwLT5kKTsNCivCoMKgwqAgfQ0KKw0KK8KgwqDCoCByZXR1cm4gMDsN
Cit9DQorDQogwqBzdGF0aWMgaW50IG1vZGlmeV9iYXJzKGNvbnN0IHN0cnVjdCBwY2lfZGV2ICpw
ZGV2LCB1aW50MTZfdCBjbWQsIGJvb2wgcm9tX29ubHkpDQogwqB7DQogwqDCoMKgwqAgc3RydWN0
IHZwY2lfaGVhZGVyICpoZWFkZXIgPSAmcGRldi0+dnBjaS0+aGVhZGVyOw0KQEAgLTQyMyw3ICs0
NDEsMjUgQEAgc3RhdGljIGludCBtb2RpZnlfYmFycyhjb25zdCBzdHJ1Y3QgcGNpX2RldiAqcGRl
diwgdWludDE2X3QgY21kLCBib29sIHJvbV9vbmx5KQ0KIMKgwqDCoMKgIGlmICggIW1hcF9wZW5k
aW5nICkNCiDCoMKgwqDCoMKgwqDCoMKgIHBjaV9jb25mX3dyaXRlMTYocGRldi0+c2JkZiwgUENJ
X0NPTU1BTkQsIGNtZCk7DQogwqDCoMKgwqAgZWxzZQ0KK8KgwqDCoCB7DQorwqDCoMKgwqDCoMKg
wqAgc3RydWN0IG1hcF9kYXRhIGRhdGEgPSB7DQorwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAuZCA9
IHBkZXYtPmRvbWFpbiwNCivCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIC5tYXAgPSBjbWQgJiBQQ0lf
Q09NTUFORF9NRU1PUlksDQorwqDCoMKgwqDCoMKgwqAgfTsNCisNCivCoMKgwqDCoMKgwqDCoCBm
b3IgKCBpID0gMDsgaSA8IEFSUkFZX1NJWkUoaGVhZGVyLT5iYXJzKTsgaSsrICkNCivCoMKgwqDC
oMKgwqDCoCB7DQorwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBjb25zdCBzdHJ1Y3QgdnBjaV9iYXIg
KmJhciA9ICZoZWFkZXItPmJhcnNbaV07DQorDQorwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBpZiAo
IHJhbmdlc2V0X2lzX2VtcHR5KGJhci0+bWVtKSApDQorwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgIGNvbnRpbnVlOw0KKw0KK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgZGF0YS5iYXIgPSBi
YXI7DQorwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCByYyA9IHJhbmdlc2V0X3JlcG9ydF9yYW5nZXMo
YmFyLT5tZW0sIDAsIH4wdWwsIHByaW50X3JhbmdlLCAmZGF0YSk7DQorwqDCoMKgwqDCoMKgwqAg
fQ0KKw0KIMKgwqDCoMKgwqDCoMKgwqAgZGVmZXJfbWFwKGRldi0+ZG9tYWluLCBkZXYsIGNtZCwg
cm9tX29ubHkpOw0KK8KgwqDCoCB9DQoNCiDCoMKgwqDCoCByZXR1cm4gMDsNCg0KDQpUbyBtZSwg
dG8gaW1wbGVtZW50IGEgc2luZ2xlIERFQlVHIHByaW50LCBpdCBpcyBhIGJpdCBhbiBvdmVya2ls
bC4NCkkgZG8gdW5kZXJzdGFuZCB5b3VyIGNvbmNlcm5zIHRoYXQgInRoYXQgZnVuY3Rpb24gY2Fu
IGJlDQpwcmVlbXB0ZWQgYW5kIGNhbGxlZCBtdWx0aXBsZSB0aW1lcyIsIGJ1dCB0YWtpbmcgbG9v
ayBhdCB0aGUgY29kZQ0KYWJvdmUgSSB0aGluayB3ZSBjYW4gYWNjZXB0IHRoYXQgZm9yIERFQlVH
IGJ1aWxkcy4NCg0KQ291bGQgeW91IHBsZWFzZSBsZXQgbWUga25vdyBpZiBJOg0KMS4gU3RpbGwg
bmVlZCB0byBpbXBsZW1lbnQgKHRoZSBwYXRjaCBhYm92ZSkNCjIuIERyb3AgREVCVUcgcHJpbnRz
ICh0aG9zZSBhcmUgcmVhbGx5IHVzZWZ1bCB3aGlsZSBkZWJ1Z2dpbmcpDQozLiBMZWF2ZSB0aGUg
cHJpbnQgd2hlcmUgaXQgd2FzIGluIG1hcF9yYW5nZQ0KDQpUaGFuayB5b3UgaW4gYWR2YW5jZSwN
Ck9sZWtzYW5kcg==


From xen-devel-bounces@lists.xenproject.org Wed Feb 02 09:49:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 09:49:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.263942.456831 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFCGn-00078X-8u; Wed, 02 Feb 2022 09:49:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 263942.456831; Wed, 02 Feb 2022 09:49:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFCGn-00078Q-4w; Wed, 02 Feb 2022 09:49:45 +0000
Received: by outflank-mailman (input) for mailman id 263942;
 Wed, 02 Feb 2022 09:49:44 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1p3Q=SR=epam.com=prvs=40324c57ab=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nFCGm-00078H-6a
 for xen-devel@lists.xenproject.org; Wed, 02 Feb 2022 09:49:44 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 71b3c716-840d-11ec-8eb8-a37418f5ba1a;
 Wed, 02 Feb 2022 10:49:42 +0100 (CET)
Received: from pps.filterd (m0174676.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 2129gtS2031611;
 Wed, 2 Feb 2022 09:49:35 GMT
Received: from eur03-db5-obe.outbound.protection.outlook.com
 (mail-db5eur03lp2057.outbound.protection.outlook.com [104.47.10.57])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3dyqh2820s-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 02 Feb 2022 09:49:35 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by VE1PR03MB5918.eurprd03.prod.outlook.com (2603:10a6:803:10f::33)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Wed, 2 Feb
 2022 09:49:31 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6%3]) with mapi id 15.20.4951.012; Wed, 2 Feb 2022
 09:49:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 71b3c716-840d-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=iMBWMVZgsjk8196TUjwqJxpMQ5NeXRAvoohqMmhqsJlcwMHV7B+q6Mt90fj/l1nCsyp7i/jzQ3ThZD3pvAn9YvpVArIFVICPhp6W/gGsfUUKPOmzbb6ryXCTSdTSEzt2K2DMlfIuf+yO8NPXZO+Kqp8CQVr/vmRMxoyUMW+vSkjYEMsvMMdO0Y0bymAKA/GtfKWTzPa/d37/Ngv6YD5CYkyW4yMr7VszBbBSy+IDO1x7PDzrS0T26Ni58C68GlViG3AU7PyQx7pLNzP51qfRNSSCOHno5+sJ/9TP4OZ6zCk7EXLDPHBbMLA2vKkySJ2covzTDtO89Kr2YI8FMq1kEQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=djgND/Km+5ZIzq00YTQiIvJ4KwA3bl7qGtnEljP9KAg=;
 b=mU2U60gaS01M2iqosICdaT/mhHiNVO8YD28jzMb4gNsug8A/lTxiFiqNpzjNNEjR8e3Bjb74BY+s3DLsJJ/4M+r0c9a/71vCL7s9wGiK+Nb8rewaaUEJDCEK+VBXV99E/F9nvmlFtiu+zRux+rDOhpZtieKo6bbh5XjgPqNgCBU6CmvXVcgQm73oPuob0PjEyN7/Pc+11xmjb93yRKmTdc8sLR/Az3VrwlRtiHx/vq+C5/I1R5JrfEa1NZN1swilQFRvfFGdYJMoWAa2Xm483wdIzDhedCyx+GozWtnJT3CLo1UGn52eXFp1m/0wARlvoYSFJX04WurUDXHso01T3g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=djgND/Km+5ZIzq00YTQiIvJ4KwA3bl7qGtnEljP9KAg=;
 b=KzbsaC/F2/WrwsnBWoA4C9KQn01tmS5ADFqLAd1q9uz/P94vdUTj4Urn/Hf2SiI1+XXcOoDK8PjRbetBWOfpj50t5LmFqEX1JXZZCj6Du1TjbAir/m3PyxeoToOUmVQZkH37vHddGneCPeVVZhhFb+CWXDMS02rKgbvUbj1v179grwRLcKGlSwftNspG3yG0GL6iGSQY54AL7i9j015HHymiHniUOQMEivF6fnwTIMIzVXgqaxLhbO7aCOEe00qYpOiCuX7Hjqo7wiPG1gRePcCws23blY4nwQupQ3xgO/GzckcaiXrMKLl2mvSV5Un3Cno9v1K+RrWnhjlbsdiO8w==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>,
        =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?=
	<roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        "george.dunlap@citrix.com"
	<george.dunlap@citrix.com>,
        "paul@xen.org" <paul@xen.org>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>,
        Rahul Singh <rahul.singh@arm.com>,
        Oleksandr
 Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH 3/4] vpci: shrink critical section in vpci_{read/write}
Thread-Topic: [PATCH 3/4] vpci: shrink critical section in vpci_{read/write}
Thread-Index: AQHYF4hObbqxIjaQNUeSdaSEPmZTi6x/8z+AgAAF24CAAAj/gIAAAhgAgAABDwA=
Date: Wed, 2 Feb 2022 09:49:24 +0000
Message-ID: <e5d12099-99aa-f0cd-2180-68377ede510d@epam.com>
References: <20220201162508.417008-1-andr2000@gmail.com>
 <20220201162508.417008-4-andr2000@gmail.com> <YfpEiWT0NpYNSAks@Air-de-Roger>
 <5ed821ac-0a38-3c1a-a28a-c46295c2ffb4@suse.com>
 <5ec87648-2783-d21a-ca7d-dc59180543d9@epam.com>
 <a4a78b7f-126a-3c18-6f93-2d0bd768f74a@suse.com>
In-Reply-To: <a4a78b7f-126a-3c18-6f93-2d0bd768f74a@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: ad6bfc5c-6cda-4b54-c42c-08d9e6314bdb
x-ms-traffictypediagnostic: VE1PR03MB5918:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <VE1PR03MB5918368B9BC6817E44190D18E7279@VE1PR03MB5918.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 KV6oU9clYfHS7z7eXRaeTrp45iq2VT607ZpODwQ/dwaLbuTAQTZuS1pdbhcgSef4t+dvLa2/4q2yscL8hGcWhUJSdeL4FPNa7Az6qh3UL0efiP/4MuIMdYEMaLNagRXK8wD29Px1GsltG62g1NDFkJ2jhq8fm0tYmV10pZg1JTeMSPOAxGNX3pbXyTW1P23JSdSHoQA4AGx9MUwtFtzb6pO0LZIK4wbdXreHbHZGhF9lQ0OF2UEK1r+XOLgg42viAspRhnpgqYWWb8tB4k8NeXNnUqy4JN+j0bjSb2ASqQBDovQAu9LKcjOTnrTPM6efFumpES17Ip3UEw8hQY8YWu0iyl2X/PU2OWtj/1zMTHX8IZa/2WLUpc5Pt8EMSDzYpO/yM8+8GGiExK9t6m0nhO+ZCsONMjXkittVZC2SW6SwEWSwtgOTwD1GVPuyISE0hiCP7XPccWNCN8WLRvuWCqo0wXub/1h8K9jhO/0lNAAL7VwYTlR7cLo5ms0jpLmxNanzt0+ZNvX3aKw6Ws8d4pWP1exXcv8woTOCw4Mbh2PFJ7N4AUuXhRuGBONHEny46TPknij1liEBtq6K5P7k/8492oPW64BU28lnqUZVzMlLDaf/GkLxP8vfwc7cKdyn3A3dVcS+gBCWDt1XzXMEiIppxBQGRqMJfF3gze7eWpjmCqKZDzHrcgLYDP5WKXWHIW5qB2BBJ88EpQfx14FqAr6xPZiglmptx063GucK9+0=
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(31686004)(6486002)(83380400001)(316002)(508600001)(122000001)(53546011)(54906003)(36756003)(110136005)(38100700002)(66946007)(91956017)(2616005)(2906002)(86362001)(31696002)(107886003)(8676002)(26005)(5660300002)(186003)(66446008)(8936002)(66476007)(71200400001)(4326008)(66556008)(64756008)(76116006)(38070700005)(6512007)(6506007)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?aXlTQ0VpY21MNTQwcTRRMHhWUHpZVmYrbGlxS25iL1JULzNSYlVaemlMNXUr?=
 =?utf-8?B?Q2I5MEZ0UDdwMXBqWXRweW9kK0Z1cXNVOFlvd0xCa2crdzBzVWJFdlFsaU9T?=
 =?utf-8?B?TTRCNVpwVmRMdkppSks2YVVobEJTT1JLRE9TczFCODFPdlVtSTUxOVFGNGRk?=
 =?utf-8?B?NGowQjNDdTBMaVJ6bEtOYmZxS2RqaDVqZ2w1NnlRT2lHRHM0eDZ3SHRzeEhm?=
 =?utf-8?B?enE3elcvQzhwa0g0OTFObDR3Nkt2ZjFieEhPZzcyQ3ZRTEd1eFJkb0l1WDBZ?=
 =?utf-8?B?YVpPYVRCNSs2eVIzdXpFMWYvNHhlUTF3ZGNLamxaMXJHNFlydEJYNnprZ3gv?=
 =?utf-8?B?elVIbDBHYzRnRk9XZWc2Y0tHbW5UbUhuanlCUU9xMG1wUm5qL2kxd01peVpl?=
 =?utf-8?B?d1hWV2EwUit3UGo3R2VQdFBMcVNTNk53akdoUXlQYjJyZmgvQjJMeW84R3RC?=
 =?utf-8?B?SnlKZ1l6SXJ3Z3lBWm00UytORlpIMks1K2pFVXg5cmpLL1d6dTk0V2lwYzFt?=
 =?utf-8?B?Y0VzVGhyNzgwKzBhWnpDZUcvWVF4b2xjclg5M2VtRm45SVdZNWh5QmNHU2pr?=
 =?utf-8?B?engyOFRzR0hEZmFrRmlqemVtbjFwWXFUREluK2tlelVML3daWkpjQ3FYUitI?=
 =?utf-8?B?ZHlVUDZOYTBNK2RaYWpub2xYQnBEYnozTHVseDNONldJUW85bE1ObXhvOElV?=
 =?utf-8?B?Rmc2eUVCMUJrenBnd3luYjd5RThhYy95am1ad204NGRSUnpOMnhGUmluY2xE?=
 =?utf-8?B?cmtCanJ3MHhnMGVkRXRPNWovNXlVRlB2WkFDODV1UzMzbW04SVRJZmlmME9X?=
 =?utf-8?B?UW9aVjArcmFGQVk1WnNrSFI0aHgzd1M1T3BrbW1OMFpuc1FaWmdVYTkrUnJo?=
 =?utf-8?B?cER2Zm1DRy9XSTIzWUhXV1UwbHlnQnkyb29sS3M1U1RvNEJlOE0yYUFmZ2JX?=
 =?utf-8?B?TnZIaTlYT1ljNXVPL0lFdnpIRmxXTkVhYUZob0RoMHFzMVcvL1hTWlZXMFNh?=
 =?utf-8?B?czkyTERocGhFeDVaR3JHSUQ5Wm9pRWZ4bGRZQjBMc0E5VzhxRXVtbzFnM2J1?=
 =?utf-8?B?Z1hwcUg3OUc5TjB5ODVyRXpwN2VnZlVOREhlWWQ4QlF2SUYrTWpmdTMvTUIx?=
 =?utf-8?B?UmFxZk9FbEtMYjR1Y0xUaVVaYy8wZnRMQUlDRG5nVXBxSGdTVmFwemJJd1Fj?=
 =?utf-8?B?b1pKbHBWY1crdTJFbWZqc1o2UlVSL1o4Y3NLejlFTEFtUUtDeWZDRmZiak8x?=
 =?utf-8?B?b1RJSE9kQzViSXNOVjNkU0NMS1o2azQ4NTdUVVRkUFRITUw0VTQ0SUZxVkto?=
 =?utf-8?B?VjdsQXJVMGhTTVRqUHJIVTRQRHl3N1Jjcm5CTWpDZ3JUVWk5UVFtdXNpMnhy?=
 =?utf-8?B?L1F5MDFtbVdDQmFIVTNjVm1ybDJ4MCtkL3pCNmdYdXQvSzU3bHlLQmxPL0RZ?=
 =?utf-8?B?eFpkNE9pamphR0hvaHF6U2gwb2prcFFhVWFsTUkxdngyM3pvMThYZlFxOHRm?=
 =?utf-8?B?VklQbUhyY2J1SUx1R21EL1RaYVF5elpyUjljeVhYbEJGK0pibGticXpnd3pF?=
 =?utf-8?B?TzVZcDQ2bm5wbVpmSmZVSFY2ei9NTW1YYzZDU2YrVjRUbXM5NUVWWGJ1NytP?=
 =?utf-8?B?SjVKdWswd2RDck5lakJMaUl2eVhscDc4bmo3aW5NV0Z2OU9XNmlVSG9OR3FT?=
 =?utf-8?B?c3J6NnJOb0s1STdlSXlyWVhPUGlLdEUwRzVKbDJnNVBBeWJUbTNSUVZvMWNo?=
 =?utf-8?B?c2FrR1htenE4cC9uY1VQc21SdmtSeFB2YWIxUldQZ3FqK3k2SFJ1cythOGp3?=
 =?utf-8?B?ZTZqSmVTemZ6eTNOTnpUQlhwTWo1dFRLRktBSUFSMldFWmFxUy9oVVBIL2U3?=
 =?utf-8?B?cWoxek5WR2pxdHN6M1N3RENQUG40MjU3NGxQUTNxSS96ZWZmbGRMWGxEUmE0?=
 =?utf-8?B?ZnhzS2J0VUxYOTc4WE9RY09RL1FoeGMvMmJKYWVrcXJPOW9PV3BEVzN3Ui9I?=
 =?utf-8?B?eFpCT0ZNVndMYkxtLzc0OG9DRjlzSFdYVWhCVzg1NXVoYTBUYkI4Y0RsbEdR?=
 =?utf-8?B?YVdlTW9NMmNLMVoxY3FSaTc0dGpUUEFYTWkyZm4xSlJ2eUhtaGF5bHBmR3lY?=
 =?utf-8?B?RGphOVdTRXBUNWIvbVVxbXUyZXVteE1jaW1jc2FRWkIzNzlUZGwxeUZFSGd6?=
 =?utf-8?B?a0ljOEFwTkpjdTZzWTYzYVlzQ2JBenhxT1RvWDlEVlk2eXB2R3FSVlRySHY4?=
 =?utf-8?B?THZTZUdOSU5PaHJEVjYyRlIrQUJVYjRNanRUc1Vqc0tsbmVxS2dhYWttQ0Za?=
 =?utf-8?B?aVBaSWo5UXRmTW9oVmh2WTVxdWM2ZldlL3h6ZUw3bWxnNmlYODJSUT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <B733A1E93C9CA44997DD163E1A02C09B@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ad6bfc5c-6cda-4b54-c42c-08d9e6314bdb
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Feb 2022 09:49:24.9334
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: kpZfBs2lxqbuWmlMo1KDjR1hn3hVnDK/15J9FSTQzMajutyuwW01ZmJo4uxSviwQ6GewahqIFYPfHHJ94wmqbNfVNj2B1F6HOdNP/ttahF1vkA9ERrAK6SqtDUlCQCAx
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR03MB5918
X-Proofpoint-GUID: 8mod4xD1jH-wihTMjsw5DiUuFNyqdRHg
X-Proofpoint-ORIG-GUID: 8mod4xD1jH-wihTMjsw5DiUuFNyqdRHg
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-02_03,2022-02-01_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0
 priorityscore=1501 lowpriorityscore=0 phishscore=0 mlxscore=0 adultscore=0
 spamscore=0 clxscore=1015 mlxlogscore=999 malwarescore=0 bulkscore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202020051

DQoNCk9uIDAyLjAyLjIyIDExOjQ1LCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMDIuMDIuMjAy
MiAxMDozOCwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+PiBPbiAwMi4wMi4yMiAx
MTowNSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+Pj4gT24gMDIuMDIuMjAyMiAwOTo0NCwgUm9nZXIg
UGF1IE1vbm7DqSB3cm90ZToNCj4+Pj4gT24gVHVlLCBGZWIgMDEsIDIwMjIgYXQgMDY6MjU6MDdQ
TSArMDIwMCwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+Pj4+PiBGcm9tOiBPbGVr
c2FuZHIgQW5kcnVzaGNoZW5rbyA8b2xla3NhbmRyX2FuZHJ1c2hjaGVua29AZXBhbS5jb20+DQo+
Pj4gT2xla3NhbmRyLCBjYW4geW91IHBsZWFzZSBjbGFyaWZ5IGF1dGhvcnNoaXAgaGVyZT8gVGhl
IHJ1bGUgb2YgdGh1bWIgaXMNCj4+PiB0aGF0IEZyb206IG1hdGNoZXMgLi4uDQo+Pj4NCj4+Pj4+
IFNocmluayBjcml0aWNhbCBzZWN0aW9uIGluIHZwY2lfe3JlYWQvd3JpdGV9IGFzIHJhY2luZyBj
YWxscyB0bw0KPj4+Pj4gdnBjaV97cmVhZCx3cml0ZX1faHcoKSBzaG91bGRuJ3QgYmUgYSBwcm9i
bGVtLiBUaG9zZSBhcmUganVzdCB3cmFwcGVycw0KPj4+Pj4gYXJvdW5kIHBjaV9jb25mX3tyZWFk
LHdyaXRlfSBmdW5jdGlvbnMsIGFuZCB0aGUgcmVxdWlyZWQgbG9ja2luZyAoaW4NCj4+Pj4+IGNh
c2Ugb2YgdXNpbmcgdGhlIElPIHBvcnRzKSBpcyBhbHJlYWR5IHRha2VuIGNhcmUgaW4gcGNpX2Nv
bmZfe3JlYWQsd3JpdGV9Lg0KPj4+Pj4NCj4+Pj4+IFBsZWFzZSBub3RlLCB0aGF0IHdlIGFueXdh
eXMgc3BsaXQgNjRiaXQgd3JpdGVzIGludG8gdHdvIDMyYml0IG9uZXMNCj4+Pj4+IHdpdGhvdXQg
dGFraW5nIHRoZSBsb2NrIGZvciB0aGUgd2hvbGUgZHVyYXRpb24gb2YgdGhlIGFjY2Vzcywgc28g
aXQgaXMNCj4+Pj4+IHBvc3NpYmxlIHRvIHNlZSBhIHBhcnRpYWxseSB1cGRhdGVkIHN0YXRlIGFz
IGEgcmVzdWx0IG9mIGEgNjRiaXQgd3JpdGU6DQo+Pj4+PiB0aGUgUENJKGUpIHNwZWNpZmljYXRp
b24gZG9uJ3Qgc2VlbSB0byBzcGVjaWZ5IHdoZXRoZXIgdGhlIEVDQU0gaXMgYWxsb3dlZA0KPj4+
Pj4gdG8gc3BsaXQgbWVtb3J5IHRyYW5zYWN0aW9ucyBpbnRvIG11bHRpcGxlIENvbmZpZ3VyYXRp
b24gUmVxdWVzdHMgYW5kDQo+Pj4+PiB3aGV0aGVyIHRob3NlIGNvdWxkIHRoZW4gaW50ZXJsZWF2
ZSB3aXRoIHJlcXVlc3RzIGZyb20gYSBkaWZmZXJlbnQgQ1BVLg0KPj4+Pj4NCj4+Pj4+IFNpZ25l
ZC1vZmYtYnk6IFJvZ2VyIFBhdSBNb25uw6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPg0KPj4+Pj4g
U2lnbmVkLW9mZi1ieTogT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gPG9sZWtzYW5kcl9hbmRydXNo
Y2hlbmtvQGVwYW0uY29tPg0KPj4+IC4uLiB0aGUgZmlyc3QgUy1vLWIsIGFzIHRoZXNlIGFyZSBl
eHBlY3RlZCB0byBiZSBpbiBjaHJvbm9sb2dpY2FsDQo+Pj4gb3JkZXIuDQo+PiBXZWxsLCBJIHdh
cyBub3Qgc3VyZSBoZXJlOiB0aGUgaWRlYSBhbmQgdGhlIG9yaWdpbmFsIGNvZGUgYmVsb25ncw0K
Pj4gdG8gUm9nZXIgYW5kIGl0IHdhcyBhIHBhcnQgb2YgYSBkZWRpY2F0ZWQgb3RoZXIgcGF0Y2gu
IFNvLCB0ZWNobmljYWxseSwNCj4+IHRoaXMgcGF0Y2ggZGlkbid0IGV4aXN0IGJlZm9yZSBhbmQg
Um9nZXIgaGFzbid0IGNyZWF0ZWQgaXQgKHRoZSBwYXRjaCkuDQo+PiBTbywgdGhpcyBpcyB3aHkg
SSdtIGluIGRvdWJ0IGhlcmU6IHNob3VsZCBJIGNoYW5nZSB0aGUgYXV0aG9yc2hpcA0KPj4gdG8g
Um9nZXIncz8gSSBoYWQgbm8gbWVhbnMgdG8gb2ZmZW5kIGFueW9uZSBoZXJlIG5vciBJIHByZXRl
bmQNCj4+IGZvciB0aGUgYXV0aG9yc2hpcCBpbiBhbnkgZm9ybS4NCj4gTXkgcGVyc29uYWwgdmll
dyBvbiBpdCBpcyB0aGF0IGlmIHlvdSd2ZSBicm9rZW4gdGhpcyBvdXQgb2YgYSBsYXJnZXINCj4g
cGF0Y2ggY29taW5nIGZyb20gUm9nZXIsIHRoZW4gaGUgc2hvdWxkIGJlIG5hbWVkIGFzIHRoZSBh
dXRob3IuDQpBZ3JlZSwgd2lsbCBjaGFuZ2UuDQpSb2dlciwgSSBhbSBzb3JyeSBJIGRpZG4ndCBk
byBpdCBmcm9tIHRoZSBzdGFydA0KPiBKYW4NCj4NClRoYW5rIHlvdSwNCk9sZWtzYW5kcg==


From xen-devel-bounces@lists.xenproject.org Wed Feb 02 09:50:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 09:50:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.263946.456842 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFCHG-0008Rj-L9; Wed, 02 Feb 2022 09:50:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 263946.456842; Wed, 02 Feb 2022 09:50:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFCHG-0008Rc-Hc; Wed, 02 Feb 2022 09:50:14 +0000
Received: by outflank-mailman (input) for mailman id 263946;
 Wed, 02 Feb 2022 09:50:13 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HAZh=SR=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nFCHF-0007X9-3A
 for xen-devel@lists.xenproject.org; Wed, 02 Feb 2022 09:50:13 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8281c76e-840d-11ec-8f75-fffcc8bd4f1a;
 Wed, 02 Feb 2022 10:50:11 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8281c76e-840d-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1643795411;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=hSW7uwBYLxiQutlbu2p75DF0z93hV46jP5cxJ1EP+Q8=;
  b=iIG8YsAj7oqqZzC6KUvBJPU3O/V7lHCeSZZTykZRNWByN69I/RsVPfbw
   JOTO+MFJTehI1FYQKZ7Z5T2x539jMq8MYBGC3nnCAmc7mhryoa0H/XPdw
   rLjG0GPJW8uiNs1usbvv46ZU+mwKYMge8Scf+9LAvRkFMOvT22f7/xSBH
   E=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: yU9N1HeSF/bzkFRSZauNJZqa1gdzcbF0TFRe4Enbh65xaAAjriQP9qLfKgqbzCaAr6nxnHJZpl
 QVS6uaUfCz/Mpah5IhC+6KObarxptJBglqY/rK5uU2pUyX3Bz+rIzOLnK+eOcu+sF1286fcOrt
 +xkSuuuSmvnw+fx0JXUz8tXyE5pPWhi1h0H+8gLznB+GazEU8RgO2FQiKOjKboN1sUdRI02ZaN
 rslyUzXyWujcwEydJ1fxZZCXWY16tKCGpx3psQsNbrHNzZeTJs+Rqe17C295N0wXdVHGOTz3SW
 pC+xeTGGfkiQPkcPQZkC0xIa
X-SBRS: 5.2
X-MesageID: 63218577
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:9jjWVqLMv/KWqqR2FE+R9ZMlxSXFcZb7ZxGr2PjKsXjdYENS0T0Hm
 GpLX2nSPvzZZmHwetxzbo23pkIDvMPTxtRnGVRlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokcxIn5BC5C5xZVG/fjgqoHUVaiUakideSc+EH170Ug7wbZg6mJVqYPR7z2l6
 IuaT/L3YDdJ6xYsWo7Dw/vewP/HlK2aVAIw5jTSV9gS1LPtvyB94KYkDbOwNxPFrrx8RYZWc
 QphIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbrGvaUXe345iXMfwZ3u7hB2jz5M20
 e8QmKaUEyR5MYzxnfkdDjZXRnQW0a1uoNcrIFC6uM2XiUbHb2Ht07NlC0Re0Y8wo7gtRzsUr
 LpBdW5LPkvra+GemdpXTsF2gcsuNo/zNZ43sXB81zDJS/0hRPgvRo2UvoUBjGpv2aiiG96AZ
 5cZcAY1PSj9SDRFOQYNKaIDw7u30yyXnzpw9wvO+PtfD3Lo5BR4zbzFINfTPNuQSq19gEGco
 W7X+nXjNRsTPtef1Dmt/2qlg6nEmiaTcIgfDqGi//hmxlia3HUOCQY+XEG+5/K+jyaWXNZSK
 Fcd/CY0mqE0+Fa2Vdn2XxC+o3msswYVXpxbFOhSwBuEyrfQpR2YAGcEZjdbbZots8pebTsu2
 1ySltXlHwtzoaaVQnKQ8LSThT6qMC1TJmgHDQcNSwcfuYG7+Kk8ixvOSpBoF6vdpt//FCz0w
 juKhDMjnLhVhskOv42r8FaCjz+yq5zhSg8u+h6RTm+j9hl+ZoOue8qv81ezxe1bMI+TQ12Fv
 X4Fs8uT9uYDCdeKjiPlaOcQGLCk4d6VPTuahkRgd6TN7Bz0pSTlJ9oJpmgjegE5aa7oZAMFf
 mf56UAW/aUOEUGON4wnbKOMDtkqkIfvQIGNuu/vUvJCZZ14dQmi9S5oZFKN022FrHXAgZ3TK
 r/AL5/yUC9y5bBPiWPvGrxDieNDKjUWmDuLLa0X2ShLxlZ3iJS9bb4eeGWDYekihE9viFWEq
 o0PXydmJvg2bQEfXsU12dJCRbzpBSJibXwTlyCwXrXbSjeK4El7V5fsLUoJIuSJZZh9mObS5
 W2aUURF0lf5jnCvAVzUNis8NOq+DMsm8yJT0ckQ0bGAgCBLXGpSxP1HK8tfkUcPqISPMsKYv
 9FaIp7dU5yjuxzM+igHbImVkWCRXE/DuO56BAL8OGJXV8c5H2Tho4a4FiOyqnVmJnfp5KMW/
 u3xviuGEMFrb1kzU67rhAeHkgnZUY41wrwiBiMl47B7JS3RzWSdA3eg06Zqc5xQckirK/nz/
 1/+PCr0bNLl+ucd2NLImbqFv8GuFe5/FVBdBG7V8fC9Miyyw4Zp6dUovD+gcW+PWWXq1r+lY
 OkJnfjwPOdexARBspZmEqYtxqU7voO9q7hfxwViPXPKc1X0Ve8wfijYhZFC5v9X27tUmQqqQ
 UbTqNNUDqqEZZH+G1kLKQt7MunajaMImiPf5OgeKVnh4HMl56KOVEhfZkHeiCFUILZvHpkix
 OMt5Jwf5wCl00J4OdealCFEsW+LKyVYAakgs5gbBq7tixYqlQ4eMcCNVHeu7cjWOdtWM0QsL
 juFv4b4huxRlhjYbn4+NXnRxu4B154Ajw9HkQ0ZLFOTl9ub2vJuhE9N8S46Rxh+xwlc174hI
 XBiMkB4KPnc/zpsg8QfDWmgFxsYWU+c8031jVAIiHfYXw+jUWmUdD8xPuOE/UY49WNAf2cEo
 OHEmTi9CTu6Ltvs2iYSWFJ+r62xRNN8wQTOhcS7EpnXBJI9ezfk3vejaGdgR8EL2i/taJkrf
 dVXwds=
IronPort-HdrOrdr: A9a23:GQf6/KEJoJNAHZB9pLqFcJHXdLJyesId70hD6qkvc3Nom52j+/
 xGws536faVslcssHFJo6HmBEClewKnyXcT2/htAV7CZnichILMFu9fBOTZsl/d8kHFh4tgPO
 JbAtRD4b7LfClHZKTBkXCF+r8bqbHtmsDY5ts2jU0dNT2CA5sQkTuRYTzrdHGeKjM2YabQQ/
 Gnl7V6TnebCD8qR/X+IkNAc/nIptXNmp6jSRkaByQ/4A3LqT+z8rb1HzWRwx9bClp0sPof2F
 mAtza8yrSosvm9xBOZ/2jP765OkN+k7tdYHsSDhuUcNz2poAe1Y4ZKXaGEoVkO0auSwWdvtO
 OJjwYrPsx15X+UVmapoSH10w2l6zoq42+K8y7vvVLT5ejCAB4qActIgoxUNjHD7VA7gd162K
 VXm0qEqpt+F3r77WrAzumNcysvulu/oHIkn+JWpWdYS5EiZLhYqpFa1F9JEa0HADnx5OkcYa
 ZT5fnnlbZrmG6hHjPkVjEF+q3vYp1zJGbLfqE6gL3V79AM90oJinfxx6Qk7wA9HdwGOt15Dt
 //Q9dVfYd1P7srhJJGdZc8qPSMex7wqDL3QSuvyAfcZek600ykke+D3Fxy3pDsRKA1
X-IronPort-AV: E=Sophos;i="5.88,336,1635220800"; 
   d="scan'208";a="63218577"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=j2nsDnJeRS9rDnoHUSUiDP/mBdKW8p7Md2o7TNj3fJhUHwygv/X07HHcGoAgIMFqywsy5CPiNVmWPK6ZoyY3J1uTs/e7aF+MSz41GrEPHn2AXedID6hxeKdg5nM8m9CzJTwkNCanKUaSvB6pG9WKq4xRrlg6AJUAB7Ez66sorC9rzWsb1gcvkRs8MxGmltxcSCGboBmHDKAqPmEessQjY5VBigSnchgQaO53WJn3L5xK9hZK/IjQjp9d+nFUja0xSi0tgxxBwSSlb6QMG0WKYMGsEN9HkIMp+L2xttWziA12T7JgNPau0ckNRpyi3pRmICQywuUwiqnTsKvzhNK3yg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=GMTs6TmJI+d5slk+yBtZIzCzL4m77upsgD/DgXXlER8=;
 b=P+gByGj8lc64SpI95TCEdJ+TD6Ee/lFhbe9VaR/N64OiJ+1iveuX8SNudSk5BE4BjvfXH/x2SXAwOB5oEYYAFz9b+318u7OoV6APFuzxUG/Eu0DitSsFD3DeEgakXxQCvRnIf6V/AcfE9jhD1cEdr+fJMiUx8463Xo4hnYRkTYHXd8AbQ463uARpxRz9ZEjunvG7xEU5EKNGQB6dJ+3sSDKNr+1U+ODRlj4jxcGPlnDA16p3MicinKjNuSS4uY5D4O9vMGq0qBOjO+x0xISgQ3NbLK/z1WGeJtmHFY1RoTmMYMJeGsBnbJFB/1/Z5sPUQcQRlB9dJVa9gauoVh1CoA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=GMTs6TmJI+d5slk+yBtZIzCzL4m77upsgD/DgXXlER8=;
 b=xQVCIXQOWYoqL7vR117BB0esNuKiawmp56LTIHBftEa1Q/nx8Jau68FzHQVl6ppAO/kuzTlkaADGOOMER4E1A7SbxdypKb4QyaYnsSQ+DUeyR32mH3UOlOxvYTMFdy9ng62S0TCSjVarXev7MBwZlzEhv14RpDHmJpim4qp2YVs=
Date: Wed, 2 Feb 2022 10:49:57 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Oleksandr Andrushchenko <andr2000@gmail.com>,
	<xen-devel@lists.xenproject.org>, <julien@xen.org>, <sstabellini@kernel.org>,
	<oleksandr_tyshchenko@epam.com>, <volodymyr_babchuk@epam.com>,
	<george.dunlap@citrix.com>, <paul@xen.org>, <bertrand.marquis@arm.com>,
	<rahul.singh@arm.com>, Oleksandr Andrushchenko
	<oleksandr_andrushchenko@epam.com>
Subject: Re: [PATCH 3/4] vpci: shrink critical section in vpci_{read/write}
Message-ID: <YfpTxT+uylPGw/Mi@Air-de-Roger>
References: <20220201162508.417008-1-andr2000@gmail.com>
 <20220201162508.417008-4-andr2000@gmail.com> <YfpEiWT0NpYNSAks@Air-de-Roger>
 <5ed821ac-0a38-3c1a-a28a-c46295c2ffb4@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <5ed821ac-0a38-3c1a-a28a-c46295c2ffb4@suse.com>
X-ClientProxiedBy: MR1P264CA0110.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:501:50::19) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 62c9eaaf-d51f-47a7-0560-08d9e63161f5
X-MS-TrafficTypeDiagnostic: MN2PR03MB4911:EE_
X-Microsoft-Antispam-PRVS: <MN2PR03MB4911F556240D4147A1C2B87F8F279@MN2PR03MB4911.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: vj3k6TOXCOM73BkVosvtCbudCorqUlYE+84EWsr9UUBExS6nB3WqRZARYEPytAiiR5s4hCPowOk5sbBY5voGsCdaFwmA90ErvUWFE6dK1WTTX56B/i6O/3wBLtVkBvYK1zvyVV+zX9hutpJPadvuw19GeoifLHHdXjLiivM5KCqWaQrCGRiLlYSWMdSfKauMPrObHzBE6iLA2muwvRPAj7TVbUSbaowFgdEtcZa929UCLKXYBOq8Apk5fUGot/je1CcPW1Zf9pV5kg4QS7IxiQ3W/2QfAA5yWa/cBAfm/MMA4fc/wUqxI7bCiQcgjt30NzDg4gMISwrNsfXC1yBazEd+AohzEs2Lgv01snRFLnZl1VPTBOyrodtVRNT35QoqR/UfugEHQ5AwKd9loOuS6gX5sImXtlEd0xejselX8pnqVc49Kcmy8pOpLXHzzCcgs69oTcs4/hSBc59UYv4oNfRBRtXP6Ct18JNmrsKA6718v7V9GwM5ujK5bz+vLUTXmRP5YTwju+HW4fR5+BIUEfntpiFOlBLet2esGjLvqS1+Os5lIZupUeQfyxXTXwcmO+U27whvdTWSP/RRtff8T5VzVXQTbpSEmdOPm8n3qXI1lKSPYGXbA0kCnG67CsP+SDDa6s9Zx0Er0BvtYde8yg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(82960400001)(38100700002)(54906003)(6486002)(6916009)(316002)(33716001)(508600001)(83380400001)(7416002)(6512007)(86362001)(4326008)(6666004)(53546011)(8676002)(5660300002)(2906002)(66476007)(66556008)(85182001)(9686003)(66946007)(186003)(6506007)(8936002)(26005);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OUZjWmtxUDh6SDZaUmFxMVJxUmg3d3JlOTE5ajdidDk3TzY3cVpsQm5sY1V1?=
 =?utf-8?B?U0s3MS8xRitZclNjdUZtZFIzS1Q3MW9WRlFCZThjSWxralRRZVh2N29Qc0Fa?=
 =?utf-8?B?Qlp4NFhCbFF3SzF6WCtTYmRjNC9kdnlrQU1COGYyREdxYUpNV0xidW41UEFK?=
 =?utf-8?B?NHdOUWVDaUY4SU1oRC9FNzhWRHhXdSsyc2NvSG8wdlBEY0poZHdZMDNJYnJN?=
 =?utf-8?B?WnZpMGFuSXpFZ3VhVWFWdjRtQmo0Y01uU1ZRaG1TNUVJL0VxeHhmTWJSdE0y?=
 =?utf-8?B?MENPd3pvSHYyZmc3U2xHTXcyZ2k5WXpwcXlOYkJtT0VsRkhYNlRxb2RlTzlX?=
 =?utf-8?B?QjY5RjJLT0pwa0FMbmREV0ZyNHAxK1MzS3JqSnl0WUZWcXprU0JPdUlhRUtO?=
 =?utf-8?B?bEYwQUlwRVlacDNTR2poQVI1ZW5kZ0Q5bjhFQjZIRzBZWU9uYXpIR1BybjZR?=
 =?utf-8?B?ZlRtNVBGU1V3MHA1ekZhbjAvNXlSd2s2RzRkanVNYStSbzNXWEZnUldZbW5n?=
 =?utf-8?B?RkNBSUdiQ28zSDhVWk5nZytSWHliL2NabkdYTTB1cWkwQ0dQalFNMmRKU1Ur?=
 =?utf-8?B?dUY0Y1VDak4xUlBNRkVmaGs4YlFBbkcwVmtVRkt2aDN6d3ZXb3BBNkJrNWMw?=
 =?utf-8?B?OWU2V1ZHbjJFUkdCRU4xLzZQTDVDa25qWjZCN2Z5bUhoWDl2RVJHRHpTUTV3?=
 =?utf-8?B?a2s4V2dNNk5SeHN2S1VJNnZDUkxIMm1IUndJUHptYVJJU1JxMjVtZU1CczNV?=
 =?utf-8?B?ZnM2RmNmNEhQS056OHpZNjNmTkN6a0gwcDlURmkxQUJtNDFTL0twYmNSa3NO?=
 =?utf-8?B?WWN0TG12cEYxVGhLZjAyTXk4QktoYm1SYjMvOTVmbmk4VEg0eEhYOWRXWGxT?=
 =?utf-8?B?UUdubTBxVnF6UkJaamwvZ2o4STVnSGtsc2tUeVJtajYyUWlnWFhQUmZuOHhU?=
 =?utf-8?B?eFdDbnZUYkdPUnFPYlhqU0h5R2U0MDhUOXE4NzBmSXMya0Vzd1lSODUvQVNK?=
 =?utf-8?B?T3BnczFGYVB5NWk5NWNjeDY4LzBzalorWXZST29CalJoQ2pidVNSUXBIOWJK?=
 =?utf-8?B?ZkZxUk95KzFYQTcrNGVKRk5ZRmZDaVpGOFhHNktqTDRNeXNsNWdTeSszN2w4?=
 =?utf-8?B?Q3IvWVY0c2JnMG9lQzZRZE1mb3FJQ1lRaTF5Ym1JNTJneklRcFNmRFZMODJk?=
 =?utf-8?B?amtkQ0ZmVWEvUUQ5T0hRSzVzTGNUT2dxWTljR0JzUXBTcFg4TlpYVVEzRlRQ?=
 =?utf-8?B?akZsekZPck8xRVRsZ3g5bms1R0RQSFdTL1BISWVweTY3UzlkTW1aZ1ZHbjlq?=
 =?utf-8?B?MmRBYlhYTUFZQUlubFdnR2RMZDlVZGo2cEQ1dndTNCtYUjN4RVZWM1ptV3Fz?=
 =?utf-8?B?aHRtTzl1anF5Ti83ZWEyRW9VN2dYYlFxZU5FdW5XeDJpRG9uL1hMQStjb2tz?=
 =?utf-8?B?R1dLRmhVVi9nRy9ndmoxa1lVbm5GRWJWT1pESlE2c0doLzdjZ3RSTCsrZWEy?=
 =?utf-8?B?SUI0M3NGaEJiOU91bUNEcTR1NGNxblcraEhMeG5ORkNBRkIvQW5HZzVqdjFv?=
 =?utf-8?B?cURmcm9sY2YwQWpUUUc4SnlldWxQc2RPRWd1M3JJWmVpczNMcGZKZkZhL3lP?=
 =?utf-8?B?Vm9tdzNadkxvc1grUmZubFhxUkRROVk4WGsyVi9hVUJIc3FVRVJ0d3hQUVNG?=
 =?utf-8?B?bTRGaXlOYWJtam5XcUZMYkZXcWpKOE1keVNraFJ6TjlUUU9OR0NUN3Bhc0NR?=
 =?utf-8?B?bm5JYUF4OVVoUVRUWnRJekN0RjZ1Zi81QllRbEFFYWg4MDg1NlpJVjBIcEla?=
 =?utf-8?B?cXQ5bVpMcFgvZVRYTGJLbHJ2T3pLUklvSjZVNkVRaXVJVHJna2N5RmxVV1BL?=
 =?utf-8?B?eEM1Z201RXdRZUVGeTE1d05VQjBIMWpNQ0Y2SGNtWFFpNHNsKzFpUzhsdzdj?=
 =?utf-8?B?Z3dKbWh6ZkIwazRabHIyYkgrV1hvbytnZmZUdmQ2VVNxRlpzejRMeC9VaHdE?=
 =?utf-8?B?KzJabzFCblJpUStzWmhqNjJRK3RHdnlmN0NTaVJOeXVHQjQwM2ZSemh0c0h0?=
 =?utf-8?B?VjVzS3dFWFJsaS9QTlh5ckxjWTdzaTRzNnBIOUdwTkNtUVQrbnNmcDdtMXdQ?=
 =?utf-8?B?cVpZa0syd3N3RlhpaWE2TGpzQlBoWWFqcVZEYjBGN1pySi93dUJHK1FyNlV4?=
 =?utf-8?Q?s5nCJ5HukIlnXVvci+qQ72s=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 62c9eaaf-d51f-47a7-0560-08d9e63161f5
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2022 09:50:02.2744
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yR8LofVrSwakergg4Van9lYJxBUJvnU1m2w112kCVboqsLU12JSac1bEWiKALD3MLa8yp0q3AJ3oYg3INyrk0Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB4911
X-OriginatorOrg: citrix.com

On Wed, Feb 02, 2022 at 10:05:55AM +0100, Jan Beulich wrote:
> On 02.02.2022 09:44, Roger Pau Monné wrote:
> > On Tue, Feb 01, 2022 at 06:25:07PM +0200, Oleksandr Andrushchenko wrote:
> >> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> Oleksandr, can you please clarify authorship here? The rule of thumb is
> that From: matches ...
> 
> >> Shrink critical section in vpci_{read/write} as racing calls to
> >> vpci_{read,write}_hw() shouldn't be a problem. Those are just wrappers
> >> around pci_conf_{read,write} functions, and the required locking (in
> >> case of using the IO ports) is already taken care in pci_conf_{read,write}.
> >>
> >> Please note, that we anyways split 64bit writes into two 32bit ones
> >> without taking the lock for the whole duration of the access, so it is
> >> possible to see a partially updated state as a result of a 64bit write:
> >> the PCI(e) specification don't seem to specify whether the ECAM is allowed
> >> to split memory transactions into multiple Configuration Requests and
> >> whether those could then interleave with requests from a different CPU.
> >>
> >> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> >> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> ... the first S-o-b, as these are expected to be in chronological
> order.
> 
> > Acked-by: Roger Pau Monné <roger.pau@citrix.com>
> 
> I'll take your unconstrained ack to indicate that you're also fine
> with this going in right away; see my reply to 0/4 as to the earlier
> two patches. Please let me know (soonish) if I shouldn't make this
> implication, but I shall wait with committing for clarification of
> the question further up anyway.

I think both vPCI patches in the series could go in when ready. They
are improvements on their own.

> > Would like to make sure whether Jan still have concerns about
> > splitting accesses though.
> 
> I continue to be a little concerned, but as long as the decision is
> taken consciously (and this is recorded in the description), which
> clearly is the case now, I have no objections. In the end well
> behaved OSes will suitably serialize accesses to config space anyway.
> 
> > Also since I'm the maintainer we need a Reviewed-by from someone else.
> 
> Reviewed-by: Jan Beulich <jbeulich@suse.com>
> 
> I'm not sure this is strictly needed though: I'd generally consider
> a 2nd (later) S-o-b as valid stand-in for R-b, at least as long as
> the 2nd author doesn't scope-restrict their tag.
> 
> One further remark though: The resulting asymmetry of the locking
> (covering the "head" hw read but not the "tail" one) looks a little
> odd, but I will admit that I don't see a good way to restore symmetry.

I did realize about such asymmetry also, but I don't think it can be
solved.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Feb 02 09:57:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 09:57:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.263958.456852 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFCNk-0000mn-CF; Wed, 02 Feb 2022 09:56:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 263958.456852; Wed, 02 Feb 2022 09:56:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFCNk-0000mg-9B; Wed, 02 Feb 2022 09:56:56 +0000
Received: by outflank-mailman (input) for mailman id 263958;
 Wed, 02 Feb 2022 09:56:54 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HAZh=SR=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nFCNi-0000ma-IP
 for xen-devel@lists.xenproject.org; Wed, 02 Feb 2022 09:56:54 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 71c17c70-840e-11ec-8f75-fffcc8bd4f1a;
 Wed, 02 Feb 2022 10:56:53 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 71c17c70-840e-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1643795813;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=sPmT3JDIaL/uh2kaOHhkZ/VZsaKC9kh/h9aOVL7jNjM=;
  b=fMunAhdb95FOLKCdKhIbYDQfikKVpp2H7s2shcuqRBZsyLDg5CUT7pFi
   Unp168lmCrwzgBiYeLylPUIZPWaEnQpE4JdKdrbmHai4F1DrBzroFVDck
   /fYYJdLieNJEA/4+5TX0zXFsLEyu/LgQbZW/Moizeb9Le9Jw0BD21TOa1
   Y=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: cK9s+8wVzQB4yNCjkQTu+DYRabqvepeJ6S85EImQ2VmHk8xTFG1L1GBpccM/Udhx712pP5xAOc
 CI9E0gEF13zNjRtaMT1tdnLvKr32INYjoiPkSOelsn+xZ5MSVmGQzTBjNepXEUuGlEuVht7KLV
 4XPiEh7Y+BjwgyaVI99Zq0rbEN+SK3yGonWWZwTyNUCcR1xadZ3tIC4ykxFuKdVLIWNO8hjX1i
 yYJpvlGmdmHviNtUELGrU8xymHcbXPzT1UYkahqzRdMafkziSGQ+U4lMRKrBJDx2tfKr9lediM
 9X7IFnra/opdLyfGNykeA51I
X-SBRS: 5.2
X-MesageID: 63710980
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Ehl+c6t/mP+AozK4Y//yrjLTGufnVHZYMUV32f8akzHdYApBsoF/q
 tZmKWqHPvaMZGH1KYx2OY3ip04Ou8Dcm4NqTAY4+HxjF34R+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZQP0VOZigHtIQMsadUsxKbVIiGHdJZS5LwbZj2NYy2YLhWmthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 NplsL6AET8XEfDwl/UEUBJ9DB4vZfZn0eqSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DJoQQt2sm1TjEJf0nXYrCU+PB4towMDIY2JsRRK6PN
 5JxhTxHQjLYfRlLZ2wsJJcXpNeN3VfCcwUFgQfAzUYwyzeKl1EguFT3C/LXcNGXQcRenm6Du
 3nLuW/+B3kyHcaDxD+y12Ojj+7Cgwv2QIsXUra/85ZCmFSOwkQDBRtQUkG0ydGjg06jX5REK
 kob+gInt610/0uuJvH3UgekuneCslgZUsBJDuwhwAiXz+zf5APxLlYDSjlNedk3rvgcTDYh1
 kKKt97xDDkpu7qQIVqN+7HRoT6sNCw9KW4ZeTRCXQYD+8Pkoow4klTIVNkLOImxg97uEDf82
 QejqiQkmq4Ths4G0aa81V3fijfqrZ/MJiY3+wHWU2SN/g5/Iom/aOSAzlzW7u1JKoqDeWWQp
 3gPm8WY7+cmAImEkWqGR+BlNKqy+/+PPTnYgFhuN5os7TKg/zikZ4843d1lDB43aIBeI2avO
 RKN/1MKjHNOAJe0RapVU9qJNet38afxDNfuc+/rP4IVQ7EkIWdr4xpSTUKX2mnslm0lnqc+J
 YqXfK6QMJoKNUh05GHoHrlAiNfH0gh7nDqOHs6jk3xLxJLDPCb9dFsTDLeZggnVBougqR6dz
 dtQPtDiJ/53ALynOXm/HWL+wDk3wZkH6XLe950/mg2reFMO9IQd5xj5mutJRmCdt/4J/tokB
 1nkMqOi9HLxhGfcNSKBYW15ZbXkUP5X9CxnZnNwZAf5hiF9Me5DCZvzkLNsJdEaGBFLl6YoH
 5Hphe3cahiwdtg302tENsSsxGCTXB+qmRiPL0KYjMsXJPZdq/jy0oa8JGPHrXBWZgLu7JdWi
 +D+imvzHMRSLyw/XJe+QK/+lDuZ4ClC8N+eqmOVeLG/jm22rtgzQ8Ew59dqS/wxxeLrnWrHj
 lvGXEtD+IEgYeYdqbH0uExNlK/we8NWFUtGBWjLq7GwMCjR5G24xoFcFu2PeFjguKncos1Ov
 M1ZkKPxNuMphlFPv9YuGrpn1/tmtdDuu6Vb3kJvG3CSNwanDbZpI3+n28hTt/ISmu8F6FXuA
 k/fqMNHPbipOd/+FAJDLgQSceneh+ofnSPf7KppLRyitjN35reOTW5bIwKI1H5GNLJwPY58m
 bUhtcca5haRkB0vNtra3ClY+37Vdi4LUrk9t4FcC4ju01J5xlZHaJ3aKyn3/JDQNIkcbhh0e
 meZ3fOQia5dy0zOd2sIOULMhecN144TvB1qzUMZIwjbkNTymfJqjgZa9i46T1oJw0wfgf5zI
 GViK2Z8Ob6Ko2VznMFGUm2hR1NBCRme9hCjwlcFjjSEHUyhV2iLJ2whI+edukse9jsELDRc+
 biZzkfjUCrrI56tjndjBxY9pqyxV8F1+y3DhNujTpaMEJQNaDb4hrOjODgToBz9DMJt3EDKq
 IGGJgqrhXEX4cLIn5AGNg==
IronPort-HdrOrdr: A9a23:wM/+/qht/gdl+YXshJbR1TzYlXBQX0J13DAbv31ZSRFFG/FwyP
 rAoB1L73PJYWgqNU3I+ergBEGBKUmskqKdxbNhR4tKOzOWxVdATbsSlrcKpgePJ8SQzJ8+6U
 4NSdkaNDS0NykHsS+Y2njILz9D+qj/zEnAv463pB0MPGJXguNbnn9E426gYzNLrWJ9dPwE/f
 Snl656T23KQwVpUi33PAhPY8Hz4/nw0L72ax8PABAqrCGIkDOT8bb/VzyVxA0XXT9jyaortT
 GtqX212oyT99WAjjPM3W7a6Jpb3PPn19t4HcSJzuwYMC/lhAqEbJloH5eCoDc2iuey70tCqq
 iHnz4Qe+BIr1/BdGC8phXgnyHmzTYV8nfnjWSVhHPyyPaJMg4SOo5kv8Z0YxHZ400vsJVXy6
 RQxV+UsJJREFfpgDn9z8KgbWAlqmOE5V4Z1cIDhX1WVoUTLJVLq5YEwU9TGJAcWArn9YEcFv
 V0Bs203ocYTbqjVQGYgoBT+q3uYpxqdS32AHTq+/blnwS+pUoJjnfxn6ck7zI9HJFUcegy2w
 2LCNUtqFh0dL5kUUtKPpZ0fSKGMB28ffvyChPhHb3GLtBPB5ufke++3F0KjNvaDaDgiqFC36
 j8bA==
X-IronPort-AV: E=Sophos;i="5.88,336,1635220800"; 
   d="scan'208";a="63710980"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=GEulqdUaSaTjz1xSCp85JJYRIQByJo6BmA0nJbtOkCbq1277XGkOwoa4fRcvp116SNbt3Rcx39eeKdivlzIoSk2Y5ABgUhwPSH7t1o4Cyk0YvH/6m7Iz9JjoBQV3n1GLKxyLqxKEukdS6tqL0XXIxbC64cKjkAWuUxbXSHC6E5EJt4FvhxO7uvHHpaWORMt9uULRlcewKfWx3h64AqtFDmraVGyG73xo+BdB606PQQiLG2QO2F6q3m4tyPxcIZQ/VBNM5eMMmfp4Qi8lFkDxrflBZSgTYx21/vAkKpHN81yVcm7kmtNDiEpMjXrwy8t0X1Y/Cj8tAfFcSzNvrtPJ8g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Up3aWVFT11Jy+6A9UtW39ucH1Hrxvt0rVS1nPyaag3Q=;
 b=DfoC9CsqA7m1hschcSc/Vt9pw4OCzjSMi5Dwum4BIt73atpNJYmBtLLrI6O7oN2i3XQBFrwa9cPrZ8mGI/aywU4r9rwvc6RxRGUWRgcjNcgSPZUpbiYSkEH7ze1s62zhywse96yoweuaoXw2+Ew7x+Pbi7Ka25CndDMwmEqaD2cNDBX/VEog63ByLuXjlk3eNCio0nCYnGIIAuRJLNBw7PVSUlXb0CW5YWd3iVG+FHhjaXvvU+QlAgLb0KsO2y/sfQ0x7FNFwu6ZxNdjzJXbf6is+hXXDAEprwZh5StbjvBYNzK58xT7cQu3FIw4HOeP2CqSEs2or0UFFYImQsWXxg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Up3aWVFT11Jy+6A9UtW39ucH1Hrxvt0rVS1nPyaag3Q=;
 b=CDZyUZwV6cGbC0MXzCSc5S5aRHpT0g4J/cuaM3eyOu71TTC9JaCEi4Xf9VOklhZb58er2yGhZJ3FdNWaDFIB1U4j+QOLf4H7ifrUtAfh9XXm1YDOUng87ajjbgXTvFYgc8v0HHyEf/mdnO5EKkEFkdgAGxbGzu20VrWqcI/+1GE=
Date: Wed, 2 Feb 2022 10:56:41 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"julien@xen.org" <julien@xen.org>, "sstabellini@kernel.org"
	<sstabellini@kernel.org>, Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Artem Mygaiev <Artem_Mygaiev@epam.com>,
	"jbeulich@suse.com" <jbeulich@suse.com>, "andrew.cooper3@citrix.com"
	<andrew.cooper3@citrix.com>, "george.dunlap@citrix.com"
	<george.dunlap@citrix.com>, "paul@xen.org" <paul@xen.org>, Bertrand Marquis
	<bertrand.marquis@arm.com>, Rahul Singh <rahul.singh@arm.com>
Subject: Re: [PATCH v5 07/14] vpci/header: handle p2m range sets per BAR
Message-ID: <YfpVWdITDHpz+bW6@Air-de-Roger>
References: <20211125110251.2877218-1-andr2000@gmail.com>
 <20211125110251.2877218-8-andr2000@gmail.com> <Yd7wjP8WLWQxzLbq@Air-de-Roger>
 <9c8ea4bc-feeb-dfa0-9265-83ff724b216d@epam.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <9c8ea4bc-feeb-dfa0-9265-83ff724b216d@epam.com>
X-ClientProxiedBy: MR1P264CA0097.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:501:50::18) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 8609c017-47fb-4889-74e7-08d9e6325376
X-MS-TrafficTypeDiagnostic: DM5PR03MB2569:EE_
X-Microsoft-Antispam-PRVS: <DM5PR03MB2569998DA8AC406B24CF843A8F279@DM5PR03MB2569.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 1zqU78KSgK10ACpfyelNAJHJx4IvFYrwsi/mXRFD2NhhqzkQNCtERws72JyBnF97noAyNv974lTKrjnG2YIpZ48osqefK8Qcnot4DpmatYNVJhDZ5yDB10UtU5qwSJseyGMa3kMAUkxru7Qe3g6CCZwRu2/Y16E5z9h0Q/uTgokWq/MVRDXhFm3J3VtDkuFJFzkrUuXNddRn/HyhmIe4j1ykWUsHn7+C/g5bD79uvCUYqRnv/5hFm2yrMrwCBaXxlVkX21fNQa1eymXQwxfcrIbIDNcHTP1eOZBHkrYlO8Kob0fHIAAVyQuYyoAIZl3tQoBETBPKzeJH8Xv42Ds1KnoNEl0hy9WPt/j8RC1xSQx1zyjUx51IUpbzIRpXhvrd9rDuhyhSfZBgvKNeGI7zeUEgbeIqABVNpN5nqVzdzrORvGcQk1fiMvFaGDobdziBS7NK1/f0CIHQH04AV/Zs8OziQ528lSApnfk7kCqz9ZKenYuvv1YLQbm5c5dzT2yfNvHigVVlVEuWYo679mPH/N7x3dvs3NYuvvCfmQbWL3d/wReg4gYjho+58t9RLg37N2aV5Qnrp7fFG58n/EBojOj45Lu/bCpVcrQ1M8hyBzM7K4IwueTAuRpmhbsC7/AfcnYhhOKUHYN7uxvplFeBbG4n6iStQFmJ4CcuW8x2OcvWQKM7Ck+Z1Jvl+85FJrmehlYzRTx+oDCa9R73sHlYCQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(86362001)(85182001)(26005)(8936002)(4326008)(316002)(8676002)(82960400001)(186003)(33716001)(53546011)(83380400001)(508600001)(6486002)(54906003)(66556008)(6916009)(9686003)(6666004)(38100700002)(66946007)(7416002)(5660300002)(6512007)(2906002)(6506007)(66476007)(67856001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NTd4amFWZ0N4U3B2ZVEzSlVSbHh4WXdQQ2JGTE5RcnU2SStIUzlIVzRaVnVS?=
 =?utf-8?B?RVhISUhNOS9HQjdYb2V1Y3JVUlRTcUNHK0ZXSVZOZ3VjQlVRZ1ViRnZHY21Q?=
 =?utf-8?B?MHFUNXlWOVdIVStVK2J0SVZwandoU3BIbHdQUk54c2RYWUNUKzY4RU5heWhq?=
 =?utf-8?B?NzI2K0RIWmVpUDkvMGd3Mmc0RWdVUlN2MGdNN3RrNGdwK1lXZUczOFBqekhB?=
 =?utf-8?B?bUNtTUU2enA3REJjNzd2N1h0ekxzbkQra0tLUk1ZZC96K09JdW5CL2pjOGxn?=
 =?utf-8?B?dTRCRHlSZFZnV2ltNUtIZVBRY3dndkZ2eC9ZbUZ1SzNiMzlCNFcrN3J4ZU1n?=
 =?utf-8?B?T3VxcGsrZ005TS9DWDkwUzByNUJhdmlGU05GdHlGVnplOTlOMmJqSGdRMmZN?=
 =?utf-8?B?Z1c4WldRMXVQLyt3RGdJMTNKTjAwVTR3WitMejFFSVYzdVpYdUYxWFRXcGRS?=
 =?utf-8?B?aUs2a0JQeXljNktaazQ2ZWEzd1JvUWcrT1h0Vm00ZFVxYk1vNDBHbTFsMDZz?=
 =?utf-8?B?aFRZV2xZUDhmQVQySk03d0tXQXlPd002S1F5RFpta2tCT21MUWJzdlR0aWwx?=
 =?utf-8?B?Ymt1dkt4NTcwK1FPYzZQSEhRN1ZFYkY5NGlqdVFPYlpYNStmOHI4UitjZW9O?=
 =?utf-8?B?blo0K1RkS1VCVGNRYXREVzErdVhmWEpUejJjdlJjTG90L0d5Q3ZINjZkRURh?=
 =?utf-8?B?YVFTaGVxeXhMVk1KVjVSM3hxNVN6SXI2RStmVGNPeUZxVkFCMG03SGtiQURn?=
 =?utf-8?B?U1c3ZlVxdVh6Qm5FcjlNVkFMUDlXdGJEdVBGZm4vTndsTEFuSzVrakhVRExP?=
 =?utf-8?B?QUZoSkNXRVhJRnVkdGV4dkN5Y1NBUjQxTEllS2dkRVhoSlRkQWRiSTRRVlB3?=
 =?utf-8?B?ekpZZkpVU3hSK0RXdEpTYlkvMmNMVGM2T0ErdWU0dm1BYXNLbXdUTHpYMGMv?=
 =?utf-8?B?aVF3N0FjVytmSjFoNzJJZ216T2tTNVlDbVorUTh2VWVPaFVLY2puaDJBVjJa?=
 =?utf-8?B?dVVZb1ZtQkFhK004ZW5TQ2plUVAyTmpZNWJVVmNHYURGYzFtZlpiWGFWZ0xI?=
 =?utf-8?B?dnU5L3hkR250WDFlR2FmNERzZEx6TkNkZ1JadEN6UGxHcVk2UHNQNGRhZzVK?=
 =?utf-8?B?M05CVG1MNEE3MDA3TkVKNzJtV1hBQjIyQ01jcUpaV1BGcXJ0OWtaTi9ma2p0?=
 =?utf-8?B?OXQwajgwVDA4WjkxT2ZZdU9PdzlXZE9zZGpDQ3diNUJ3Z1BFQkpaN1BBOHJ5?=
 =?utf-8?B?MXZqRkZGMVNhVHM3RS9pREthT1BXUUtZSWN2WllQa0twalA2VEkxREVRQmpY?=
 =?utf-8?B?ZXlyaUhCL2lncVN6VlZMUklNYVhnUzZFZEowenlaWkxncFJOK0cwdE9GY0hE?=
 =?utf-8?B?cUxHUE1zcTJMcWFFTWFDWnlJZ0JxcC9pQ3czdVgvRDU2UnFoQ3JDa0VQekpJ?=
 =?utf-8?B?Umc5T1A2MVNhdklxOEhNM1NYaEpSdzVMNExaWGRHeDBXdXFQSGI5akNicmFC?=
 =?utf-8?B?b3MrUUt4c2I4b0gvM0pOcVZQTjJsVVVxOG85ZDBBd2FhbVZHRmNVYnRXOFZK?=
 =?utf-8?B?QzFtTktaay8wT1Frd1VnQjF2NGJIek5aSmpGMmI0OW1IeHlCYWx5RHU5a0Vk?=
 =?utf-8?B?SUYwcytYYm12TmdWY1Z6QXNIM3ljRTFjbHBYMmVHcHl0cU91eEk3NitUZWcy?=
 =?utf-8?B?Z2Q4bFVpeDVTcWNaN1VYY3FBcnpTL3NnemdCMFJnTjRzeU96UTNhb1p3cTdn?=
 =?utf-8?B?QnpMTDZuQ3RsNHZVb2kzNngxSlB1bHl0c0dHbFZpQ3FjQ3hFbCt3MWIyd0lH?=
 =?utf-8?B?dFgrdFcyZVlKcUpCVGp1cVNqR2VMdzlrbnNiR0RaUExiUWJrLys1ckRFOFhr?=
 =?utf-8?B?SCtmQlNKZDdlUHVZV1ozMDluQWlES2NJdytiSWFRUzRBUmNlR0ZBcUNTYm44?=
 =?utf-8?B?OUdLZVl4bk9WRkZLWVNyL0ZSTDlMeU5hRE1kNmg0QzZnTEtlZWRIOUhqTytI?=
 =?utf-8?B?SktEcW5HWVphbStvdHJsM00zMlB5SWFJcnAzQmhkOFpPaStjNmRWUHNZK0U3?=
 =?utf-8?B?WUxKQ2EzNzFPZy9mOUFpWi9EVXZ3OGVRQUNFVkhuc1laejVmNDJ6cXBoQzNw?=
 =?utf-8?B?N0VYZzhteXRpeXNRbENsY2NoL2RSMXZrR2hnK3k2c3QyVEgyWDc3c0xOazVq?=
 =?utf-8?Q?K9a/AgfP0Spc6gmd3TmCPdg=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8609c017-47fb-4889-74e7-08d9e6325376
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2022 09:56:47.4535
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ErlwKHjgRhHoqAVrfYKshRBco2AW1lj1Mmgz/j05Wb6ndwD5oIU2XlU4r9nsmqC1w/QLvwqheM2aIbsjtQa3xA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2569
X-OriginatorOrg: citrix.com

On Wed, Feb 02, 2022 at 06:44:41AM +0000, Oleksandr Andrushchenko wrote:
> Hi, Roger!
> 
> On 12.01.22 17:15, Roger Pau Monné wrote:
> > On Thu, Nov 25, 2021 at 01:02:44PM +0200, Oleksandr Andrushchenko wrote:
> >> @@ -108,11 +115,32 @@ int vpci_add_handlers(struct pci_dev *pdev)
> >>       pdev->vpci = vpci;
> >>       INIT_LIST_HEAD(&pdev->vpci->handlers);
> >>   
> >> +    header = &pdev->vpci->header;
> >> +    for ( i = 0; i < ARRAY_SIZE(header->bars); i++ )
> >> +    {
> >> +        struct vpci_bar *bar = &header->bars[i];
> >> +        char str[32];
> >> +
> >> +        snprintf(str, sizeof(str), "%pp:BAR%d", &pdev->sbdf, i);
> >> +        bar->mem = rangeset_new(pdev->domain, str, RANGESETF_no_print);
> >> +        if ( !bar->mem )
> >> +        {
> >> +            rc = -ENOMEM;
> >> +            goto fail;
> >> +        }
> >> +    }
> > You just need the ranges for the VPCI_BAR_MEM32, VPCI_BAR_MEM64_LO and
> > VPCI_BAR_ROM BAR types (see the MAPPABLE_BAR macro). Would it be
> > possible to only allocate the rangeset for those BAR types?
> I guess so
> > Also this should be done in init_bars rather than here, as you would
> > know the BAR types.
> So, if we allocate these in init_bars so where are they destroyed then?
> I think this should be vpci_remove_device and from this POV it would
> be good to keep alloc/free code close to each other, e.g.
> vpci_add_handlers/vpci_remove_device in the same file

The alloc/free is asymmetric already, as vpci->{msix,msi} gets
allocated in init_msi{x} but freed at vpci_remove_device.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Feb 02 09:57:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 09:57:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.263963.456863 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFCOW-0001KL-Ma; Wed, 02 Feb 2022 09:57:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 263963.456863; Wed, 02 Feb 2022 09:57:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFCOW-0001KD-Ij; Wed, 02 Feb 2022 09:57:44 +0000
Received: by outflank-mailman (input) for mailman id 263963;
 Wed, 02 Feb 2022 09:57:43 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nFCOV-0001K3-4o
 for xen-devel@lists.xenproject.org; Wed, 02 Feb 2022 09:57:43 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nFCOS-0006iv-Ax; Wed, 02 Feb 2022 09:57:40 +0000
Received: from 54-240-197-225.amazon.com ([54.240.197.225] helo=[192.168.2.82])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nFCOS-0000qO-54; Wed, 02 Feb 2022 09:57:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=Oey0PCOI8QHWUaQwcTboAGM4woj2EYAoAcKXQ1jtsRI=; b=Lk9tRbPVurL5jW6bwgvSvn94Oe
	NTZn3zNSFzaSyWU972+y9L0HgiPSfQgRzZZYZTI+A9SNdD2LPhZZyixEAVG1bo63RD/TJd7bR0aze
	QAjo6dWvk6103BoCcmT+cgDrKwuJe/6BiQ0mcOoeARavB6weQB003wexsUoG2948EPDs=;
Message-ID: <64474de4-d9c2-ef16-e0d1-b59d5967ee20@xen.org>
Date: Wed, 2 Feb 2022 09:57:38 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.1
Subject: Re: [PATCH v3] xen/pci: detect when BARs are not suitably positioned
To: Jan Beulich <jbeulich@suse.com>, Roger Pau Monne <roger.pau@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Paul Durrant <paul@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220201124551.2392-1-roger.pau@citrix.com>
 <59685ca1-0587-a975-bf5b-56058b650c3a@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <59685ca1-0587-a975-bf5b-56058b650c3a@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 02/02/2022 09:42, Jan Beulich wrote:
> On 01.02.2022 13:45, Roger Pau Monne wrote:
>> --- a/xen/arch/x86/mm.c
>> +++ b/xen/arch/x86/mm.c
>> @@ -783,6 +783,23 @@ bool is_iomem_page(mfn_t mfn)
>>       return (page_get_owner(page) == dom_io);
>>   }
>>   
>> +bool is_memory_hole(unsigned long start, unsigned long end)
>> +{
>> +    unsigned int i;
>> +
>> +    for ( i = 0; i < e820.nr_map; i++ )
>> +    {
>> +        const struct e820entry *entry = &e820.map[i];
>> +
>> +        /* Do not allow overlaps with any memory range. */
>> +        if ( start < PFN_DOWN(entry->addr + entry->size) &&
>> +             PFN_DOWN(entry->addr) <= end )
>> +            return false;
>> +    }
>> +
>> +    return true;
>> +}
> 
> Doesn't the left side of the && need to use PFN_UP()?
> 
> I also think it would help if a brief comment ahead of the
> function said that the range is inclusive. Otherwise the use
> of < and >= gives the impression of something being wrong.
> Then again it may be better to switch to <= anyway, as I
> think you want to avoid possible zero-size regions (at which
> point subtracting 1 for using <= is going to be valid).
> 
> Finally I wonder whether the function parameters wouldn't
> better be named e.g. spfn and epfn, but maybe their units can
> be inferred from their types being unsigned long (which,
> however, would build on the assumption that we use appropriate
> types everywhere).

I think this a case where mfn_t would be useful to use.

> 
>> --- a/xen/include/xen/mm.h
>> +++ b/xen/include/xen/mm.h
>> @@ -554,6 +554,8 @@ int __must_check steal_page(struct domain *d, struct page_info *page,
>>   int page_is_ram_type(unsigned long mfn, unsigned long mem_type);
>>   /* Returns the page type(s). */
>>   unsigned int page_get_ram_type(mfn_t mfn);
>> +/* Check if a range falls into a hole in the memory map. */
>> +bool is_memory_hole(paddr_t start, uint64_t size);
> 
> While resolving to the same type, these now also want to be
> "unsigned long".
> 
> Jan
> 

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Feb 02 10:02:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 10:02:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.263982.456911 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFCT0-0003Kd-Qr; Wed, 02 Feb 2022 10:02:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 263982.456911; Wed, 02 Feb 2022 10:02:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFCT0-0003KW-Ng; Wed, 02 Feb 2022 10:02:22 +0000
Received: by outflank-mailman (input) for mailman id 263982;
 Wed, 02 Feb 2022 10:02:21 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1p3Q=SR=epam.com=prvs=40324c57ab=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nFCSz-0003KQ-QN
 for xen-devel@lists.xenproject.org; Wed, 02 Feb 2022 10:02:21 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 35375cea-840f-11ec-8eb8-a37418f5ba1a;
 Wed, 02 Feb 2022 11:02:20 +0100 (CET)
Received: from pps.filterd (m0174681.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 2129h6Bv012220;
 Wed, 2 Feb 2022 10:02:09 GMT
Received: from eur04-vi1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2050.outbound.protection.outlook.com [104.47.14.50])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3dyqgp03f3-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 02 Feb 2022 10:02:09 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by DB7PR03MB3884.eurprd03.prod.outlook.com (2603:10a6:5:31::10) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.22; Wed, 2 Feb
 2022 10:02:03 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6%3]) with mapi id 15.20.4951.012; Wed, 2 Feb 2022
 10:02:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 35375cea-840f-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=W04uuupOcY4ppkBvVBXJG/YHeZJ98M3cABnBdXXhxAbxaycEx0npBlvel4gC7LeBEJrEZwXvOBvD7+5CypWMITd3GohgtNVpy+KWnI3GnkcATQg5S0KKD/vrQ7SwrqOSjkvpbR9LGPEuWGWE6TTCQOsQF/b/kD1A7vaOxHDSbk0lX3pJQ0AJpYVIvhSem2NInNiMLSDf9xRQjGQDASOoiilMqazeyUyj0JsDIvOBQ6LLN3iUSQffBPFyVl4qdmqIyM/nJMC2QIjMT+ByILI6jHGc4Em6KIuvvS8N/JCnS6ND2j2+okzRmlZzinQsb6Chkt25PgQpJkroDmb3LHb/ig==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=UVYeBeFZyGtHQvuHSu/itqdBMcmCDHzatlyWxpEYyEc=;
 b=FP+0vPK+GBundmvKNodvWBCjcgFvmz+NdJgODP9bIdyU68qcLMle2CpcKsOz8ZfmWkX5YUXVzLCWHF4PX7yql6WqdDz/QrQhBHADONQl67zD/kvYc6Kyka/ePL9YQFAQUPZj2ej6isWneXuQY6ph/1rCJxvFaQ4Wd8PCmMs5Wbp8PUBC5+h99/xcQtgaMa9+tHVl7bLNvlSyz3Sh/iMLw7CPLQfPvZAhkedLH0sulH45ohIvRvFIB+LZmBDjRJp7OiXk/RhGn1IktuP10YcBM5ps5M+fq+AIaemUb/3ZZ9LX6o3wFv53QFx1pmySLOVoXiOSjQaKBliMP3Can8tfAA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=UVYeBeFZyGtHQvuHSu/itqdBMcmCDHzatlyWxpEYyEc=;
 b=HQCtaBn6kSfTKRqLHx/kG1VTBlx18lL8KXK9ihsH1AUTxvKhRratmgo69dotMYeDhAYzzU0qh9yxVtOwfdatlAL9ZNN6sA+9YLjSefKXxHM+KDHd9zlrnDTc/ajNJIiwHFqfCLDcvwitxCr2eKgF1/AMX4j6xWB15N+ufMNR7H1Pi6QzMV4nGILIF+QfefvXDtCue6PBGMS9GuPVwce7gsTHIzDiKixcPZ+ZQSaSnPZVDOtdgfRpHdfWNuikAsLYMumijh6CNx8PllySKlJ5oXgEJb3gAXyTEbjLGAFCCfD87wfWH+hxr+DoHsS26nL0IXFbnUH5RHGI9weoXJ5ysQ==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "jbeulich@suse.com" <jbeulich@suse.com>,
        "andrew.cooper3@citrix.com"
	<andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com"
	<george.dunlap@citrix.com>,
        "paul@xen.org" <paul@xen.org>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>,
        Rahul Singh <rahul.singh@arm.com>,
        Oleksandr
 Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v5 07/14] vpci/header: handle p2m range sets per BAR
Thread-Topic: [PATCH v5 07/14] vpci/header: handle p2m range sets per BAR
Thread-Index: AQHX4ewHO5mM8SE93ki3ObXvstqjIqxfypkAgCByRICAADWlgIAAAX8A
Date: Wed, 2 Feb 2022 10:02:03 +0000
Message-ID: <2fcfc3a4-0794-21aa-d915-d353cba7354b@epam.com>
References: <20211125110251.2877218-1-andr2000@gmail.com>
 <20211125110251.2877218-8-andr2000@gmail.com> <Yd7wjP8WLWQxzLbq@Air-de-Roger>
 <9c8ea4bc-feeb-dfa0-9265-83ff724b216d@epam.com>
 <YfpVWdITDHpz+bW6@Air-de-Roger>
In-Reply-To: <YfpVWdITDHpz+bW6@Air-de-Roger>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 4547e705-9d82-4c0c-54c1-08d9e6330feb
x-ms-traffictypediagnostic: DB7PR03MB3884:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <DB7PR03MB3884A147C193A3E367C1D3F9E7279@DB7PR03MB3884.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8882;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 4Fw9M5dWMinxfdRU45/Q1F6DLDF6ChFy0OpR3I70FBKZ+e8G5dLNAPQ1gkjsSnPlElaNTvNTyi8hqoJN8Y2D3W9UuvzRgHUH4zpZHmL+veEKS7jQnTrstVHBJW0vtcrZ3l96OfbZvFCn5KUete4Q1+aOkqkP+2MaCas2T703d1cc2nI5GjUk7QJf8F3YJTHDPqstbFzTUMIS076sIxXGts1CvnpZss8fQ9Z30qM8WUdhn/cegv4JCXKLRvwY9Fh/47RhZfMszLmpNtKhC0Ockjchff7iDOpsTbZHkOOWdlIaJ8HCWrEvfJSy8PhDsjas+SFhZxpmL5E0uXhIO05nuG2WhilVDsH/hYbwaTPP7SYz8ZBkK9aZwu7tpJEPFYFatb+tv50Om3k2Zz9qR2ktuDYTBHtOU8+eaUjTLo/14dTjI2E/Py5DvDeAmAP5nEPJX9/866j6NZO60if9NUenc2oEmf8HHV9cY6+urW1pRX1G5PxNOXb1Kc1zJ5zPk5Nahv95zQ/2la/ypcG4AParomQsJQF+8nAFEUaXUyB/1e8ZanvU9h2/8Dp/hc2dF34QWUX1/NWybTmxKzPde+ZP0JujTE8CVnTMOHVDlPVE9FrAEV8nJF98aZfhks/J9FfT7bnvMgF9AVYj3PNH1/1Bb63ljE5fK66pBlQVr2y2YaUe9VW//yDuSI3uQCm3XBTjmx4eUsdmhHY9UljoEEU8vtXiAGk7WRYj80ckkvPh0oY9Y50laXvuqqsO/+67ejZf
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(31696002)(122000001)(71200400001)(86362001)(83380400001)(66476007)(6486002)(76116006)(316002)(6916009)(38100700002)(36756003)(64756008)(8936002)(508600001)(66446008)(91956017)(66946007)(54906003)(66556008)(4326008)(8676002)(31686004)(7416002)(107886003)(6512007)(2906002)(6506007)(2616005)(5660300002)(53546011)(38070700005)(186003)(26005)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?d2dMWlZ2R28yWnc2OGhjMHprNXh5VC9zWnVtNCtpVEN3QjkwS3hQY0s0WWo4?=
 =?utf-8?B?ektBWkxDUmRiVTZ5VUczRTh5a1lXeWhFSmVYd3ZUVlNScTErcGJKRVZnTDlF?=
 =?utf-8?B?Vk52cE16d2lyUXFYaHFaOHdoS0doYW42c2h3Q2l5Q2RMTXRQTmZ0cHNVTW1S?=
 =?utf-8?B?TFc4UU1lM3VoQlU4ZEpKWDd6NU9Ra1pPeVc1Z2NjVWFFcjZXVy9tTHJvczRJ?=
 =?utf-8?B?K0xVOVNhY1N1L3FmbXNPKy9waUtPRkVwMXdEbGlKdURENngrRHQvWWNKVU5J?=
 =?utf-8?B?Qk4yMkVIRS9ZYTR1SGhIRjdxa3ZiV2JmM1lWMEpOUERSRVR6TGVzZEdzMzlI?=
 =?utf-8?B?SDN2bjV3VGlZWWVnVnU0S2tDcGFkTDFCNFZtVDVQNjZyRTcvQU9McWxFYUxo?=
 =?utf-8?B?YndxcEx1UllnZzR3V0tFcE5lRElBdzlNdU9JZTVTdm1xQUxpSitheE5GYXJw?=
 =?utf-8?B?VERTSFJleFpFSWJ6bk4yeWFkNE5WdzF4YVYzWWpZcThOUHNITWlRMzVjK0Zm?=
 =?utf-8?B?RjBFU1pPK0dzZXRRT3ZabnpNanJKQVpiMkVKeFJLNERIOERyVFV4c2EzOW0w?=
 =?utf-8?B?eklJTGhWK0hPb05JQ1cyRjZCWGtNQUtSSG0xVlY3NUhJRW1FSEo4Y3NvVWRU?=
 =?utf-8?B?bVdlOVpGZ3M1NU0zRjR1REVITVVuSGJuc3VENEQxUUJMYWp5ZnhLSWV0b1Vq?=
 =?utf-8?B?MHprUE13SXpBK0hYWCtKWmRBZWovUEVIMU9Pc0ZqWWt5R0dhMUdiZEVKSnZo?=
 =?utf-8?B?Vk1sRk5MMFRETzMvYzFrby9sRFVoVVozNGlneTdEcStINUtkR2w1MDd0MEp4?=
 =?utf-8?B?ZWFLWFlwKzQxeGQyMmI2cmV5NW4yT1hjdm0zMTNlV0hPOVgweVJaQjJURFRH?=
 =?utf-8?B?ci9hOVlTV1FjcnprRlloTTExWTE4SjdDbWdBaFYxeDRBcVY2Q01tU1BVUElC?=
 =?utf-8?B?SmhSUWpMM1RXU05TaUtOaXlpUm94SHZIVTBxM1BaL21hL1R2WDFYYmtMQlRM?=
 =?utf-8?B?eHdOcUZpM1NLeE5VWnpROTNJTnRLaTJiTTQ3S3V3YStsYzZqR3FRVUhZUUIy?=
 =?utf-8?B?cE1RQUhoR2pCZUNsQnJSVE52Rm5BdjVYME93NlZCWUF1cGpGUkNmSURvbnV4?=
 =?utf-8?B?SWQ4YWlVV1dTb0g1U2FtYUNKMWdnT3VpTlhCSVg3SkxNV1J6OEs1V2lFa1cw?=
 =?utf-8?B?NzJ4cGoza3Y4SEV4VmlPcTlhSVo3WGlHM0ZmUjErb0cvclFDNWFpSWtSRUxm?=
 =?utf-8?B?Rmt4WnRrWVEwTmFud2ZyVndpKzVFNmN3dCs5OEs4ZjNMV1VkLzIzSmhSc0to?=
 =?utf-8?B?QmdLbXBWSCsvb2FxZ0xqaXBqeDdGT3RyRStZUTRFWTJLNC9rQW9FQXEzTFRa?=
 =?utf-8?B?OGprSG45Zm5rNWR2dllXNSs5bWJObVBMVkk4djJNRW42djliVmh2WnRCZzZK?=
 =?utf-8?B?ckdDV0JRNVlGcVU3aHJBRXNxRDNmNEtLSFdhVVpQZS9JN3RCTUt3R3B4QU5x?=
 =?utf-8?B?aGtpamptd0E1ZmRvK2ZFT1ZhT1N1WWgzVjdQSXcyR0Zjd2RBY080dG5vU2JE?=
 =?utf-8?B?R0ZTeGd6N0J0Rmd0SW0vQlNKc0dJZnRyT013cysxQ1ViOUNBY1pTbFcxTU9x?=
 =?utf-8?B?TFZWdkVIV3NjN2RUeVh3WDRSd1J2L25uWnNLODBHd1U3N3VqVGU4WVRuZTBk?=
 =?utf-8?B?ZjFDaDNjSHFsS1o0enJyVzRyRE01dmZraGdaNnN3Q1Q5akNTOVkvckJMTS9D?=
 =?utf-8?B?ODhVNUxkS2lNbWlDRWRaMjRDUExCbnZYRFNFeks4Vjk0cnVSd0dYWWRTdHBC?=
 =?utf-8?B?M1VBTldZZk9qTmZ2SkhNMlFmaDFCaWhSMlFhT21vZFFnRFJCM004dTNId050?=
 =?utf-8?B?QmhuL1hYUVNzN3pNYzlqTTU5dC9WOG1VUnRZaVNQeDArWFhDOWZHdHROYzkz?=
 =?utf-8?B?cVkrV1p1OVpnaHEzZkVLVFJBenk0NlVoYzE3U2dKMVV3aXE2NEFZYUxGUlYz?=
 =?utf-8?B?aVZDQ1BzQWZCbXVtZGw0RzVrdlg4RWZEeVFTRDd6TVN1S01RUUFlV2lkNm9B?=
 =?utf-8?B?eHNZN2RPK2tHSjdpamxzSkVmNXBxVyt1UFVKcFZjUitlZFJ6cVgzbHorYjBI?=
 =?utf-8?B?dEFKRXEwblltTld2T1h1WXVKVDJWakxDcnpJVXdaM0VKQzdlNk9iQXJjdVVI?=
 =?utf-8?B?dTdITXNrWXM1RG91OWE5UDZhempjNjlVSS9BQUhOTkdHems0ZTFkcmFpRUtE?=
 =?utf-8?B?ZkpOTkxmNFJwSTE1bHc3UGxoNW9ic3ovTE1Jd2d4QmdXclhsZitxWFVWY2tN?=
 =?utf-8?B?RmRKU3JVemh3bHp2a3ZyMDBmQVlzZnFzemdmV2xoZGhnd2lyOW11QT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <36535AABA840C446A422D46E6BA859B4@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4547e705-9d82-4c0c-54c1-08d9e6330feb
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Feb 2022 10:02:03.3343
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: leYxd5uZXyoMSGDYxVyXDtrUb3ltehYG7AANdWeh906M1Jh0U4TDhb43vEuurE8jZf05gw6oDFwg/pzupGrw3C6MIExRbARV9dLWaeamF/snme5dRKNnUNbDWl/WQswk
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR03MB3884
X-Proofpoint-GUID: Fi7pHaY4mcF9lA0MEozS7HZYkG3qE8uW
X-Proofpoint-ORIG-GUID: Fi7pHaY4mcF9lA0MEozS7HZYkG3qE8uW
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-02_03,2022-02-01_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 mlxlogscore=999
 impostorscore=0 malwarescore=0 adultscore=0 priorityscore=1501
 suspectscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 phishscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202020052

SGksIFJvZ2VyIQ0KDQpPbiAwMi4wMi4yMiAxMTo1NiwgUm9nZXIgUGF1IE1vbm7DqSB3cm90ZToN
Cj4gT24gV2VkLCBGZWIgMDIsIDIwMjIgYXQgMDY6NDQ6NDFBTSArMDAwMCwgT2xla3NhbmRyIEFu
ZHJ1c2hjaGVua28gd3JvdGU6DQo+PiBIaSwgUm9nZXIhDQo+Pg0KPj4gT24gMTIuMDEuMjIgMTc6
MTUsIFJvZ2VyIFBhdSBNb25uw6kgd3JvdGU6DQo+Pj4gT24gVGh1LCBOb3YgMjUsIDIwMjEgYXQg
MDE6MDI6NDRQTSArMDIwMCwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+Pj4+IEBA
IC0xMDgsMTEgKzExNSwzMiBAQCBpbnQgdnBjaV9hZGRfaGFuZGxlcnMoc3RydWN0IHBjaV9kZXYg
KnBkZXYpDQo+Pj4+ICAgICAgICBwZGV2LT52cGNpID0gdnBjaTsNCj4+Pj4gICAgICAgIElOSVRf
TElTVF9IRUFEKCZwZGV2LT52cGNpLT5oYW5kbGVycyk7DQo+Pj4+ICAgIA0KPj4+PiArICAgIGhl
YWRlciA9ICZwZGV2LT52cGNpLT5oZWFkZXI7DQo+Pj4+ICsgICAgZm9yICggaSA9IDA7IGkgPCBB
UlJBWV9TSVpFKGhlYWRlci0+YmFycyk7IGkrKyApDQo+Pj4+ICsgICAgew0KPj4+PiArICAgICAg
ICBzdHJ1Y3QgdnBjaV9iYXIgKmJhciA9ICZoZWFkZXItPmJhcnNbaV07DQo+Pj4+ICsgICAgICAg
IGNoYXIgc3RyWzMyXTsNCj4+Pj4gKw0KPj4+PiArICAgICAgICBzbnByaW50ZihzdHIsIHNpemVv
ZihzdHIpLCAiJXBwOkJBUiVkIiwgJnBkZXYtPnNiZGYsIGkpOw0KPj4+PiArICAgICAgICBiYXIt
Pm1lbSA9IHJhbmdlc2V0X25ldyhwZGV2LT5kb21haW4sIHN0ciwgUkFOR0VTRVRGX25vX3ByaW50
KTsNCj4+Pj4gKyAgICAgICAgaWYgKCAhYmFyLT5tZW0gKQ0KPj4+PiArICAgICAgICB7DQo+Pj4+
ICsgICAgICAgICAgICByYyA9IC1FTk9NRU07DQo+Pj4+ICsgICAgICAgICAgICBnb3RvIGZhaWw7
DQo+Pj4+ICsgICAgICAgIH0NCj4+Pj4gKyAgICB9DQo+Pj4gWW91IGp1c3QgbmVlZCB0aGUgcmFu
Z2VzIGZvciB0aGUgVlBDSV9CQVJfTUVNMzIsIFZQQ0lfQkFSX01FTTY0X0xPIGFuZA0KPj4+IFZQ
Q0lfQkFSX1JPTSBCQVIgdHlwZXMgKHNlZSB0aGUgTUFQUEFCTEVfQkFSIG1hY3JvKS4gV291bGQg
aXQgYmUNCj4+PiBwb3NzaWJsZSB0byBvbmx5IGFsbG9jYXRlIHRoZSByYW5nZXNldCBmb3IgdGhv
c2UgQkFSIHR5cGVzPw0KPj4gSSBndWVzcyBzbw0KPj4+IEFsc28gdGhpcyBzaG91bGQgYmUgZG9u
ZSBpbiBpbml0X2JhcnMgcmF0aGVyIHRoYW4gaGVyZSwgYXMgeW91IHdvdWxkDQo+Pj4ga25vdyB0
aGUgQkFSIHR5cGVzLg0KPj4gU28sIGlmIHdlIGFsbG9jYXRlIHRoZXNlIGluIGluaXRfYmFycyBz
byB3aGVyZSBhcmUgdGhleSBkZXN0cm95ZWQgdGhlbj8NCj4+IEkgdGhpbmsgdGhpcyBzaG91bGQg
YmUgdnBjaV9yZW1vdmVfZGV2aWNlIGFuZCBmcm9tIHRoaXMgUE9WIGl0IHdvdWxkDQo+PiBiZSBn
b29kIHRvIGtlZXAgYWxsb2MvZnJlZSBjb2RlIGNsb3NlIHRvIGVhY2ggb3RoZXIsIGUuZy4NCj4+
IHZwY2lfYWRkX2hhbmRsZXJzL3ZwY2lfcmVtb3ZlX2RldmljZSBpbiB0aGUgc2FtZSBmaWxlDQo+
IFRoZSBhbGxvYy9mcmVlIGlzIGFzeW1tZXRyaWMgYWxyZWFkeSwgYXMgdnBjaS0+e21zaXgsbXNp
fSBnZXRzDQo+IGFsbG9jYXRlZCBpbiBpbml0X21zaXt4fSBidXQgZnJlZWQgYXQgdnBjaV9yZW1v
dmVfZGV2aWNlLg0KTWFrZXMgc2Vuc2UsIEkgd2lsbCBpbXBsZW1lbnQgYXMgeW91IHN1Z2dlc3QN
Cj4NCj4gVGhhbmtzLCBSb2dlci4NClRoYW5rIHlvdSwNCk9sZWtzYW5kcg==


From xen-devel-bounces@lists.xenproject.org Wed Feb 02 10:05:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 10:05:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.263988.456921 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFCVe-0003uM-8b; Wed, 02 Feb 2022 10:05:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 263988.456921; Wed, 02 Feb 2022 10:05:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFCVe-0003uF-5U; Wed, 02 Feb 2022 10:05:06 +0000
Received: by outflank-mailman (input) for mailman id 263988;
 Wed, 02 Feb 2022 10:05:04 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nFCVc-0003u5-5r; Wed, 02 Feb 2022 10:05:04 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nFCVc-0006yY-0Z; Wed, 02 Feb 2022 10:05:04 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nFCVb-0002Sy-Ec; Wed, 02 Feb 2022 10:05:03 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nFCVb-0001Al-Dr; Wed, 02 Feb 2022 10:05:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=NCaf2x5xZs1AHfmHSjwbixP8DMmgi8ob143CidLmOGU=; b=zphLE1mcVrlUjoMTGuhCyUvJtJ
	mU3XDNesPwJqHsr0jOwyUV8/7dKmKUNF0eVvGgJf4lGy0RPJZ/B3YhtS8oHVra6f+KkV9YPuEYAJ6
	XIr8y1GeCGc+v4QCEzp8JA632bAlK7JoMa4y8xVmvT+nvqN+ekddn1fCPHEIuhDguN3U=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167978-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 167978: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-localmigrate/x10:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=a7e7c7260cde78a148810db5320cbf39686c3e09
X-Osstest-Versions-That:
    xen=481ee6125aa1d5751f52eda677c7bab4719c0ad0
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 02 Feb 2022 10:05:03 +0000

flight 167978 xen-unstable real [real]
flight 167983 xen-unstable real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/167978/
http://logs.test-lab.xenproject.org/osstest/logs/167983/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-qemuu-debianhvm-amd64 18 guest-localmigrate/x10 fail pass in 167983-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167970
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167970
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167970
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167970
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 167970
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 167970
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167970
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167970
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167970
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167970
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167970
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167970
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 xen                  a7e7c7260cde78a148810db5320cbf39686c3e09
baseline version:
 xen                  481ee6125aa1d5751f52eda677c7bab4719c0ad0

Last test of basis   167970  2022-02-01 02:14:08 Z    1 days
Testing same since   167978  2022-02-01 18:07:14 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    fail    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   481ee6125a..a7e7c7260c  a7e7c7260cde78a148810db5320cbf39686c3e09 -> master


From xen-devel-bounces@lists.xenproject.org Wed Feb 02 10:05:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 10:05:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.263991.456933 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFCVu-0004LO-Mi; Wed, 02 Feb 2022 10:05:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 263991.456933; Wed, 02 Feb 2022 10:05:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFCVu-0004LF-Iu; Wed, 02 Feb 2022 10:05:22 +0000
Received: by outflank-mailman (input) for mailman id 263991;
 Wed, 02 Feb 2022 10:05:21 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nFCVt-0004JY-DG; Wed, 02 Feb 2022 10:05:21 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nFCVt-0006z2-CR; Wed, 02 Feb 2022 10:05:21 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nFCVt-0002Tc-2Q; Wed, 02 Feb 2022 10:05:21 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nFCVt-0001dr-1t; Wed, 02 Feb 2022 10:05:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=IhWjaQVTpxC8y0I1FLsDhAHU05+oZDYtsN3QsbkigPI=; b=Z7QOHCnWUlhPp8O0JZNTOXkxVu
	ZwXZ/G4lV6XpHs+rjk7rQ5XY/jozy6XRFUqfK+t2eR5IoQBWTF1RZRiZ0F7gDdJL80wdfiLiTwupJ
	FkRNSnpwfGXW+vj5A5uRXi9wPSRs9UOEn0hLXLi2DbO/K0W3nm1bLj5ECHP1QkJ2OLvs=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167984-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-coverity test] 167984: all pass - PUSHED
X-Osstest-Versions-This:
    xen=9ce3ef20b4f085a7dc8ee41b0fec6fdeced3773e
X-Osstest-Versions-That:
    xen=21170a738c11b24815b4afab2151bd3aa2a29acc
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 02 Feb 2022 10:05:21 +0000

flight 167984 xen-unstable-coverity real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167984/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 xen                  9ce3ef20b4f085a7dc8ee41b0fec6fdeced3773e
baseline version:
 xen                  21170a738c11b24815b4afab2151bd3aa2a29acc

Last test of basis   167953  2022-01-30 09:20:52 Z    3 days
Testing same since   167984  2022-02-02 09:19:38 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Dario Faggioli <dfaggioli@suse.com>
  James Fehlig <jfehlig@suse.com>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Julien Grall <jgrall@amazon.com>
  Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
  Rahul Singh <rahul.singh@arm.com>

jobs:
 coverity-amd64                                               pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   21170a738c..9ce3ef20b4  9ce3ef20b4f085a7dc8ee41b0fec6fdeced3773e -> coverity-tested/smoke


From xen-devel-bounces@lists.xenproject.org Wed Feb 02 10:05:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 10:05:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264007.456944 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFCWQ-00054a-2p; Wed, 02 Feb 2022 10:05:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264007.456944; Wed, 02 Feb 2022 10:05:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFCWP-00054T-V8; Wed, 02 Feb 2022 10:05:53 +0000
Received: by outflank-mailman (input) for mailman id 264007;
 Wed, 02 Feb 2022 10:05:53 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=6WyI=SR=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nFCWO-0004Kz-V1
 for xen-devel@lists.xenproject.org; Wed, 02 Feb 2022 10:05:53 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b3d49012-840f-11ec-8eb8-a37418f5ba1a;
 Wed, 02 Feb 2022 11:05:52 +0100 (CET)
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur03lp2052.outbound.protection.outlook.com [104.47.9.52]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-29-pq8nFPP_PEynSv8jMUVkRQ-1; Wed, 02 Feb 2022 11:05:50 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AS1PR04MB9502.eurprd04.prod.outlook.com (2603:10a6:20b:4d0::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.20; Wed, 2 Feb
 2022 10:05:49 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.012; Wed, 2 Feb 2022
 10:05:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b3d49012-840f-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1643796351;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=ratNYSfrRorbiM7zyzZLpSz4meXwcrFeqbTdcFve2ao=;
	b=cxy2/Yna7qjdfjbfmG0LZAyJbKg1RRn9kg1OyG3t1270tYgGqy/qshYzzflN9TcH2loPtl
	Yp47j8I1FPJgv1d6ZL0mGLs7oq1+80iIk2b8y/gE0DzRaq/NigArKhjbXJUrLf7e6yMkF5
	xrrpjMFT0RZ0ejDdvdGSOwori1siaCw=
X-MC-Unique: pq8nFPP_PEynSv8jMUVkRQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=TdojwcLHDrxxH0sXLUnVo3Gs0YKZbi/UKdsVBN3dQCQX2Tynm/k5OiRtUbtaFfK8h/mW0pzc7z3uz/i6kiTi+CE90KMDnxB8YjOyYg8XfSGjpbjvOIu6iZINRh2Yi0adpVYLOFWtJJSgsBjA8AVWOnprKHXPIMckpTVSn0zJDq/2uW0+dxj5k5i7LavUDuliDhyI2jD6+fZ8YR3z8BiTFe/s07Ed/RKj6EI4HjMdI8TGOWVgob2ALG+5S3Lno7EXhwmP24debBcEbP5JuDxjRxHrjb0t1GDJOuaXABLUyw78XfqFZvKuoQGJKcxo/58zH+8XBNJMARRLfxD5YZ278w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ratNYSfrRorbiM7zyzZLpSz4meXwcrFeqbTdcFve2ao=;
 b=DBGX/uU1P+QtgkPjD/zKjVVaRol/c5ehRDdsgJLUevfhVAzEwW/jLsp5ctz7pEpO7Ox/brNLPKEgRucbV9HY0ZB0VKn3VBK/Gut2g30K3k4yxaodDG0SLMxPZwCWXWxE8I/78bJjy5F+Npg/bfao3iLi0GwnsOdiTd/6JeEifEyjUAuuGp2g4KQGkwHvbqumWIQMd/Bikl7OI8F9fouGtAzrfPYLbkWYh7Rt/TKzzTTexPsUM3/IyMyVE1Ge56+Xqm7X472BzmiJaPq66tyCztE8keJmepbcGJ3tRC750QMmv67k9FTBccoEvBXXZoT2EDu/Nud8oXx6z+gBSBQrxA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <1252be7b-2b32-db39-7c90-c56d96b5a17c@suse.com>
Date: Wed, 2 Feb 2022 11:05:46 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v3] xen/pci: detect when BARs are not suitably positioned
Content-Language: en-US
To: Julien Grall <julien@xen.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Paul Durrant <paul@xen.org>,
 xen-devel@lists.xenproject.org, Roger Pau Monne <roger.pau@citrix.com>
References: <20220201124551.2392-1-roger.pau@citrix.com>
 <59685ca1-0587-a975-bf5b-56058b650c3a@suse.com>
 <64474de4-d9c2-ef16-e0d1-b59d5967ee20@xen.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <64474de4-d9c2-ef16-e0d1-b59d5967ee20@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9P194CA0027.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:20b:46d::22) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 095d8c6d-53b5-4852-5717-08d9e633963f
X-MS-TrafficTypeDiagnostic: AS1PR04MB9502:EE_
X-Microsoft-Antispam-PRVS:
	<AS1PR04MB9502EAEC0B45736DA62BD2CBB3279@AS1PR04MB9502.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6790;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	/6xgQL7vlzfXVRJ2sKDMQC9vExvAbgddRMC47SPOqBz7bdrcrUV+9PoEVO8kleXa59MVR9VUQMsTptvzTpCsNyuh2KEpuTA+uy5rkK2a1/OmPG65ZIYp6lhQXFHZhLWm58eXpzQAMgaLptBi5fQiymtE+xXVG7K/rdi3WAn6ILzutN1x9xGqTkA+klbS9tZ9M75UMo3MSL6iYwRWid87Yq2glLYjEam5wYobl3xazrewYVDe7v6QaBwG/+d7SCrlIh8qm1kNks3RV1xdT5vumimNYvY4B1fktqblYZdWoJ64h1tBzlSAzLdXPOQfadhTdy0l+3rNopJ6rzLhCAWVWs02/1YMakKGK493yxTfkwJ2nqYoGPP7U6vIn0Njjz6UREuWdtiAHgP+oHRBBCK2CueKdX2E7BhPpy8+HNiQ5vh2WIi6/b+1SO5VrcECOJnkkcs0HvufwGG3KLnI1L25LioTasTW1hiTAV0o/y0F8fwxP8MMUD3N47vbICSGAQjAeqOvpOKHtB1F7CuOKkiJvi/6eaVB03X8t43WBEYaHg+INuUtFGj9AFZ5UEFI3N0V0B1kxrvvkTcHuHE8mwqKvL6bTEuVZ3eBfw91KkOsSCA2BATpqGQGQ1yhZBJVmRZvWAnyz74JU2qaQgcSyqKgsbxPnD6NYdjfEfoyyTS80/HjzBxznaHbL71dxVu83Tpo0Fpm5/33KK/6yGOlk2JSpmtRNnGmY09luErDGQUNXhGhVpXeUvyOZ0kDCJh1oz+n
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(36756003)(6506007)(6666004)(38100700002)(53546011)(31686004)(86362001)(2616005)(66946007)(31696002)(8676002)(66556008)(66476007)(6512007)(8936002)(2906002)(4326008)(508600001)(26005)(5660300002)(186003)(6486002)(316002)(6916009)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dFpUdFJhUzdlN3NPY2hqeUoxTDl1bDVTZ21KTWFET0drZGNZMWVwUGpIdkg3?=
 =?utf-8?B?ZDVQTURDanBnWjZqbHpUbWorQTNLeHg3NkNOc1Niem5HRXNMUVdZZDM5Rjlq?=
 =?utf-8?B?ajBQN0lxblNscjhxa2tJcGkzbm1CSkcvM29OREwyUkszMFhLZCsvNVc4Tzl4?=
 =?utf-8?B?akoyQ0RsTDlrNy9USGUxNmZaSUtRZDB3VCtKV2RLRDN3RzlLOHVzamVob1Ja?=
 =?utf-8?B?SzlNUW12Tlh0ZkVhbWFETnNKbXpGU0JDNkdqS25aeW5Eekd2ajNWY2JCN2lS?=
 =?utf-8?B?akxjZURkb3ZWZzRRNzhXZ2thMENBSUFKTXlWVzBCTUJOSlpRaTkzOGs4RGYx?=
 =?utf-8?B?OWNJaXBRYTZGZmJJKzdWTWtLNFF4WDVyZVVUYVBJcGIzRkJkdThhT1RYb0pZ?=
 =?utf-8?B?RTc0ZFZLcTlZNHRvczZYTzhMSXpPQ3FCd0EzUWVXU3hnWmVYYXhjcEJBTXBQ?=
 =?utf-8?B?RVNsVmJxNnIzNDhERnM3RDBFTk50TElRNE8yV0RkTTlROHNRanVRYW9nSXBu?=
 =?utf-8?B?MUFaaCtiSXRkWmxubWtWMDEyM1BaL1p1MWdja2tmZy9lTnd3dUtHZXlFdjlR?=
 =?utf-8?B?NkxEVmorYW5qUitlMVdLU2U1TmNrTW9kNExUbVRMZ0R1YTJrc0FFUGgvTmVa?=
 =?utf-8?B?YndZRndTSTZrUXNaWkdCNFdxSURNUWIweXIzN1VCSjVNNVlldnlFZkg2cDBC?=
 =?utf-8?B?OWJrMmhqTjEwclQ0OW9yWGtPNE1mazlLYStuZERET3Byc3cvaXhXaXNSMEM5?=
 =?utf-8?B?Q1RuOVk0UERUaVJVVTB5MWUrVTdrWWJvcjd0MVZqZUxJZWhUTENVenpTQ3pp?=
 =?utf-8?B?SFF1RS9KMlhLRGVCeU4wT0Z3NDJhdkJYcHB2eFh3aEVUSHh4bklLcDBua0ZZ?=
 =?utf-8?B?RFhqNXg3TEZUTXJxMXJ5R1J4L3pZUXZMM3htdjQwVTNET1A3VHlYanBFUjhT?=
 =?utf-8?B?REJxaGpMRFlXYXRyOUowckkrYXlFaWhmTDlVVzRvK0NLR3RVY29sQkJhQkVr?=
 =?utf-8?B?eGcweGRLWHJnek1oMXI1WGdkOHN0alB5U0p2a3dJbzJicHF0ZzQ1L2dlQnU1?=
 =?utf-8?B?ZkVrdHBBNHk0akR5dFZVMDRTUWFROXV0T2FMQzhISXlzZm9oQmkyOGtGb2VJ?=
 =?utf-8?B?WS8yQ2tlSW85OGFnQkduTjEzbm9neEhpWE53QzFYU1RJSlpyTDlRRTJMc0dM?=
 =?utf-8?B?N0hUbnIzNlZWVEFMRkMvekt2Ty9idnN3MExsenJkMUI1RGwrelZaUTZoTkJG?=
 =?utf-8?B?NlpGdGFDOUY5UURWZUJSb2M2M2k5d3B1aG5IQUR2WENBYlpuQmV5ZkNFT0xJ?=
 =?utf-8?B?RkpOa3praGM5NTNheHRUOXBxWUFhNlFFcFJqSFIzcUF5R25INTNsMllxakNJ?=
 =?utf-8?B?dS9NUjU2TlNUYlc1VzZLbDk2T0NvN2Z5KzhxV3FFUVJOamxjQThCNmtBWk52?=
 =?utf-8?B?cUw3VTBPMU1aYVNQNStTOGNPd1dtekxmNGM3SzdBNGIwbGF1MEQra2src2di?=
 =?utf-8?B?aDZIVWhxRWdJK244WkJCNjNSZE5KNC9HWTJiV1RHQ3orcmlLS2tpRDNnZS9X?=
 =?utf-8?B?Tit1R3M4RVFBSk0zR3lJdEVidmVUSWx0MU1ndHAyVjM0bStmOW0vK0hXZmdC?=
 =?utf-8?B?T0xEQzJCZmVYTkRVRUZhYi8xNUs4MzNhU3QxYWpxZFhreVFUdkFqV1lXYnJB?=
 =?utf-8?B?cmlIMmVqL2NiZnhNQis5THQwNFY4a1F2NGFHNTllVEZJUlpFUmt3eXV3VFpH?=
 =?utf-8?B?N1pkOXI4TEphdVlQRDRydUwvTW1meU5pQ0JCN0lxS0kzbzY2d3hIKytpQXRl?=
 =?utf-8?B?dUllMEdZaytVSWoxRDgxY0FvSjVSR2pGSXNxNXF4SWxTSkJNV1BzK0pjYkE0?=
 =?utf-8?B?L0ExTUd5TDRybTVvSitpUmVTRXpnczJ6Z0szYW0yeGp6cndkaHkxZXN0cDJV?=
 =?utf-8?B?b1ZzVitDeDM1cnJjOE90OE5yUEIxZWFjNGl6bUFrcU5IMDJ6Qm1OM2tvWkZz?=
 =?utf-8?B?WlhKMmE5QlM0ak5LaXdiQnJQRWt1cURZOXpYMXRhUGtISDVmdUlia0VYWSsv?=
 =?utf-8?B?RFBiRXY5Sjk1Z0hqc1loQnk2YWZmR2lWVkVZeXNSLzJLQnF5M1AwZjA0dXNG?=
 =?utf-8?B?VkxTSWswR0dEOUVVdXhjQ0JVV2dkVFBEbktyalVFbmErcG9rYkVtbWlaaHlV?=
 =?utf-8?Q?fEmLMo/B23o36oZr2BTRuhc=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 095d8c6d-53b5-4852-5717-08d9e633963f
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2022 10:05:48.9652
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zSexMqiDvamtZydKdO6VAUHTjbscaIuJ6dXVv6FOA306o4s2Cff0DgV6QCPJIDe96H0UXRwUVjrIWucr8UZlFw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9502

On 02.02.2022 10:57, Julien Grall wrote:
> On 02/02/2022 09:42, Jan Beulich wrote:
>> On 01.02.2022 13:45, Roger Pau Monne wrote:
>>> --- a/xen/arch/x86/mm.c
>>> +++ b/xen/arch/x86/mm.c
>>> @@ -783,6 +783,23 @@ bool is_iomem_page(mfn_t mfn)
>>>       return (page_get_owner(page) == dom_io);
>>>   }
>>>   
>>> +bool is_memory_hole(unsigned long start, unsigned long end)
>>> +{
>>> +    unsigned int i;
>>> +
>>> +    for ( i = 0; i < e820.nr_map; i++ )
>>> +    {
>>> +        const struct e820entry *entry = &e820.map[i];
>>> +
>>> +        /* Do not allow overlaps with any memory range. */
>>> +        if ( start < PFN_DOWN(entry->addr + entry->size) &&
>>> +             PFN_DOWN(entry->addr) <= end )
>>> +            return false;
>>> +    }
>>> +
>>> +    return true;
>>> +}
>>
>> Doesn't the left side of the && need to use PFN_UP()?
>>
>> I also think it would help if a brief comment ahead of the
>> function said that the range is inclusive. Otherwise the use
>> of < and >= gives the impression of something being wrong.
>> Then again it may be better to switch to <= anyway, as I
>> think you want to avoid possible zero-size regions (at which
>> point subtracting 1 for using <= is going to be valid).
>>
>> Finally I wonder whether the function parameters wouldn't
>> better be named e.g. spfn and epfn, but maybe their units can
>> be inferred from their types being unsigned long (which,
>> however, would build on the assumption that we use appropriate
>> types everywhere).
> 
> I think this a case where mfn_t would be useful to use.

Actually I did consider to suggest it when asking to convert
to frame numbers, and specifically didn't because its use will
clutter the code here quite a bit. Which isn't to mean I'd
object if the adjustment was made ...

Jan



From xen-devel-bounces@lists.xenproject.org Wed Feb 02 10:13:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 10:13:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264019.456955 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFCde-0006eI-T6; Wed, 02 Feb 2022 10:13:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264019.456955; Wed, 02 Feb 2022 10:13:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFCde-0006eB-PX; Wed, 02 Feb 2022 10:13:22 +0000
Received: by outflank-mailman (input) for mailman id 264019;
 Wed, 02 Feb 2022 10:13:21 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nFCdd-0006e5-Nr
 for xen-devel@lists.xenproject.org; Wed, 02 Feb 2022 10:13:21 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nFCdb-000781-9A; Wed, 02 Feb 2022 10:13:19 +0000
Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.2.82])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nFCdb-0002FG-2g; Wed, 02 Feb 2022 10:13:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=cshVmSzzWOb2/21edFaniUMC9KZ8CQPR9wf0pIRG724=; b=aLIdqjw+tWNYMQt2BLzsMItnZW
	fngloMDgQ/Ym7LW/o59o4Ee/tibRTxM5/7wqtCTgCOvDLF0Cfh4nwT1bup0p9KWCAdO+f8LbLW4sP
	kWTaXV51ylAjT1OAC/uB2x6lcyb1nY9h1E+eEzUmrB5p+mUYbC6icV58wDYofeprAbwc=;
Message-ID: <dbee8f31-d520-b60c-2773-876239e1f9c1@xen.org>
Date: Wed, 2 Feb 2022 10:13:17 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.1
Subject: Re: [PATCH v3] xen/pci: detect when BARs are not suitably positioned
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Paul Durrant <paul@xen.org>,
 xen-devel@lists.xenproject.org, Roger Pau Monne <roger.pau@citrix.com>
References: <20220201124551.2392-1-roger.pau@citrix.com>
 <59685ca1-0587-a975-bf5b-56058b650c3a@suse.com>
 <64474de4-d9c2-ef16-e0d1-b59d5967ee20@xen.org>
 <1252be7b-2b32-db39-7c90-c56d96b5a17c@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <1252be7b-2b32-db39-7c90-c56d96b5a17c@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Jan,

On 02/02/2022 10:05, Jan Beulich wrote:
> On 02.02.2022 10:57, Julien Grall wrote:
>> On 02/02/2022 09:42, Jan Beulich wrote:
>>> On 01.02.2022 13:45, Roger Pau Monne wrote:
>>>> --- a/xen/arch/x86/mm.c
>>>> +++ b/xen/arch/x86/mm.c
>>>> @@ -783,6 +783,23 @@ bool is_iomem_page(mfn_t mfn)
>>>>        return (page_get_owner(page) == dom_io);
>>>>    }
>>>>    
>>>> +bool is_memory_hole(unsigned long start, unsigned long end)
>>>> +{
>>>> +    unsigned int i;
>>>> +
>>>> +    for ( i = 0; i < e820.nr_map; i++ )
>>>> +    {
>>>> +        const struct e820entry *entry = &e820.map[i];
>>>> +
>>>> +        /* Do not allow overlaps with any memory range. */
>>>> +        if ( start < PFN_DOWN(entry->addr + entry->size) &&
>>>> +             PFN_DOWN(entry->addr) <= end )
>>>> +            return false;
>>>> +    }
>>>> +
>>>> +    return true;
>>>> +}
>>>
>>> Doesn't the left side of the && need to use PFN_UP()?
>>>
>>> I also think it would help if a brief comment ahead of the
>>> function said that the range is inclusive. Otherwise the use
>>> of < and >= gives the impression of something being wrong.
>>> Then again it may be better to switch to <= anyway, as I
>>> think you want to avoid possible zero-size regions (at which
>>> point subtracting 1 for using <= is going to be valid).
>>>
>>> Finally I wonder whether the function parameters wouldn't
>>> better be named e.g. spfn and epfn, but maybe their units can
>>> be inferred from their types being unsigned long (which,
>>> however, would build on the assumption that we use appropriate
>>> types everywhere).
>>
>> I think this a case where mfn_t would be useful to use.
> 
> Actually I did consider to suggest it when asking to convert
> to frame numbers, and specifically didn't because its use will
> clutter the code here quite a bit. Which isn't to mean I'd
> object if the adjustment was made ...
I thought about code cluterring, but there are two use
of the variables. So it would not look too bad.

But I care more about the external interface to be typesafe. So an 
alternative would be:

unsigned long smfn_ = mfn_x();
unsigned long emfn_ = mfn_x();

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Feb 02 10:15:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 10:15:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264025.456966 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFCfs-0007Ew-B4; Wed, 02 Feb 2022 10:15:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264025.456966; Wed, 02 Feb 2022 10:15:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFCfs-0007Ep-6O; Wed, 02 Feb 2022 10:15:40 +0000
Received: by outflank-mailman (input) for mailman id 264025;
 Wed, 02 Feb 2022 10:15:38 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1p3Q=SR=epam.com=prvs=40324c57ab=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nFCfq-0007Ef-Iz
 for xen-devel@lists.xenproject.org; Wed, 02 Feb 2022 10:15:38 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0fdc2003-8411-11ec-8f75-fffcc8bd4f1a;
 Wed, 02 Feb 2022 11:15:36 +0100 (CET)
Received: from pps.filterd (m0174676.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 212ADfFX010847;
 Wed, 2 Feb 2022 10:15:32 GMT
Received: from eur04-he1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2059.outbound.protection.outlook.com [104.47.13.59])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3dyr0w005m-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 02 Feb 2022 10:15:32 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by DB7PR03MB4025.eurprd03.prod.outlook.com (2603:10a6:5:30::17) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Wed, 2 Feb
 2022 10:15:27 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6%3]) with mapi id 15.20.4951.012; Wed, 2 Feb 2022
 10:15:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0fdc2003-8411-11ec-8f75-fffcc8bd4f1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=BNF2ZP7pesvF9S/SwHBbp077TTxSkWbNR8aN0Uc0D4viDcEoW+qA6rqLeCS/RsWHJMzgwSGK6IdFL3R4lc0ajsmdCNR4McLx3gUmNEXh93boSp2cyTIXcuGp562Jj3d6uUMx8UFEDTQOgNFyWjm9FMR2fcX+0R8en7T/wsoUYGQeSU1zkHMYLOYBkx/iObmvagyU1/V/Nq4O0vgmrzESaLAkYtZGCdmIjFBM1JCycoTglRAgAPa8WNU9aM6SY5yaJKhcSn45Ius3zN7rUpLamZxFKSQoVXbs2CgvFWEy2IELHxuAP1N5tabF85uxtGI/t6aKLy0gYDCYZBkUfsddHQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=SLR4do8NQvI0fUkNmlr17FsmiOVcderP6+yy8MZznZU=;
 b=Gbb51kTv+Ge9r6Wz03K9eiZ2xaQ5rNhs347H4dRpgrzAmEqdsyo3KGX36ncEdTK/mOzpKv3RwRwWscfs+lD05rX6orhb1F/wLX4d/61frluqcW/2H2kzPPWDUqtf4Bga8+te0HgQsW8Whc3YnwdXEHuFldLedIqls1pRw2I96Op0n749El5o52xSI+6W/73f5863dRjyCoDAy6XpqVlHPGkOBHzIOqp5Gqutuj+tx0RM6uTQzunJmDc1RZCMqcNNHmYKamB0hMZ0n/wrdzkYX23afzxfx0pV1no3JGbZrqEj5PwW353jsNpphOqq4fCcnnoh0kzQk78hfO8HKNHfvg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=SLR4do8NQvI0fUkNmlr17FsmiOVcderP6+yy8MZznZU=;
 b=sYwrZzzxLuZGC83uVZktsxuoUFTCs3AaDRKhncK85aaSE1p7U5F9B9yi69MtYgsvdsEv6ZDqUYAljBlCrhA/e7gNqWAZteRixwkMio5Y074lUoqL4t03AawbTmqoai9uCS+cIy9xBEBU4Mv0nNf5WwZia2J1UY7cD7uvzotOfLbNVItbtOXjzOah5X5AYJcyz8+etSIl2U5cIBRwQ/gBep5xAMPaFIKzWQju2PrmYqIkFOs6JdDIyGqUNy4YKn7Zacn7OuQtGWjLi8U2EeAsdMdfud0tTwYOayivM/fnmtvw1VNM+pm7Txahcv4F6PBF1r71FQNLU4phZR3iUlhd9Q==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "jbeulich@suse.com" <jbeulich@suse.com>,
        "andrew.cooper3@citrix.com"
	<andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com"
	<george.dunlap@citrix.com>,
        "paul@xen.org" <paul@xen.org>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>,
        Rahul Singh <rahul.singh@arm.com>,
        Oleksandr
 Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH 4/4] vpci: move lock outside of struct vpci
Thread-Topic: [PATCH 4/4] vpci: move lock outside of struct vpci
Thread-Index: AQHYF4hPRx/tX4vEOUaqhaVglKUz1ayABAeAgAAIgAA=
Date: Wed, 2 Feb 2022 10:15:27 +0000
Message-ID: <d810bed0-b58d-4438-b7f4-e9c160a4570e@epam.com>
References: <20220201162508.417008-1-andr2000@gmail.com>
 <20220201162508.417008-5-andr2000@gmail.com> <YfpSnTrh6dcbrNNX@Air-de-Roger>
In-Reply-To: <YfpSnTrh6dcbrNNX@Air-de-Roger>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 3862b056-4d34-42a5-9074-08d9e634eefe
x-ms-traffictypediagnostic: DB7PR03MB4025:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <DB7PR03MB4025D801E22A64EE8C6BD0A7E7279@DB7PR03MB4025.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 QmCK+WwBI0WMELWJsAmj3FtMxF1rXUcSbaQrMUHvjkt+KkBdlIBp8dbx2EbtW/QnaPrpMB1BrLWiBVS8wYHHaM2zXOyj9wp6R/tOsd0kxXe8tMVXznRzr+jJAFiUlYCAMckxSWyEbEqpXulhSUrPI5gRKQAtj2a/xyOAgMgA8UMcsxij/BdROvsSHfV82YxIKlGwA7NDCdTlaZGd++Ltx4Q5r8sHILuc2uQVijOI2sbwDFclJ5nOQP4K8GTOpTp9vSXK7u+qa7vBQjiLGwHWEq7E1TL7FiLV5mB0tKi3PH8APX8QlqJ5S2PbX4ejAvTRAkWM28XbTjwbXEt7+F4IlMfaKId+Ke85u+iPNUxgv22jw7QrfPJMfW7b52asUJmFkW1W42BT3PfjQ2NVxGygIH462+X6xy6xErPaozKjggMpxIk9zFs1uTXxgse5K0itUL8IrsJNnGuEqGPpd4oZoH9PmmNtojBxO5GrPm2eActmt4WnpfYVdgRpUIsvgNCz7nLi5JigOABVEw2E4Sgcyz7yGMoSwBnRrMzJMbRo0epDL6pLH3sKUqW4xUfVcs871XT5XGjhJkZIZo7foCjS7cg3j9duHBCFBNbYcG529OQzw/4RdF3Lif8BWCGExynIqZKCDsEXUl4wqwaGo39Q9nu0+gYcLG9Nrt9CQ7h9dCbeoKy9zq91Zv8IA+6rQ3Eo2w2CCABcFy3h7r9S+H6NUj5RK+UyPY7ldsnYFm8ixrYUUPl7RyQPN4rU4oULIPl37KxeIo8PwYwoLK8N9hoJ0veZMlH9EwOwGpPH8PjVPKdYUpirn5qEo6G0sm9VQQ8CuY7jYaXJ1/yV/Rq8f+okTA==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6512007)(71200400001)(6506007)(508600001)(8676002)(316002)(4326008)(66446008)(7416002)(6486002)(966005)(54906003)(6916009)(36756003)(31686004)(8936002)(53546011)(66476007)(91956017)(66556008)(76116006)(66946007)(64756008)(38100700002)(86362001)(31696002)(122000001)(2906002)(2616005)(186003)(26005)(83380400001)(107886003)(5660300002)(38070700005)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?YjBGc2FIUXBDUlVmSHNPUzVHMHZHWk95aHdaLzBaamRqcVczdXJrYVVkWTRp?=
 =?utf-8?B?dzlIb3N2L1hXdkY5aWt1Y1VnTnl5K1JvTUs0eEtialZjaDRiZ0lhVVdVQjRB?=
 =?utf-8?B?OFl2b0E3Tkh2bzU2aHJEVnh2VktFUk5ldVgyTlVCTDJzQUJSVmk5S3h2NmRJ?=
 =?utf-8?B?LzRPMjhDR1pZa1EranRrN3diRTBEazNEVFVRUU55Q0ZCREo5OW1Yazh6VVg1?=
 =?utf-8?B?QlpiQ0Q4czZxTFBoblhoR1hsbGN4cTVGTFpPQTZKbytkaktKWWQ3THlpNklM?=
 =?utf-8?B?Zno4YVFkU3JvL2tmMFdVRlp5VXpZd00zdy90MnIyclBrWXRhOE4yeGorWVJ5?=
 =?utf-8?B?Zk9XWXp2eGI1WndMMlNpRnJmR1ZHYzJHUUdFUlg2VGRKT0RWL2Z4Q1VTRHFB?=
 =?utf-8?B?SGpyV3FFc1JaRStvbnZ3K0lpMUhqMVZaRjUvUUVxa1dkeDFpZHhJNUdFOHNJ?=
 =?utf-8?B?Y0FDc1luNnZsRWxTU2EvZkRIN0ZpeG8rSmpHM1JwejN3cmNaUTV5M0dxNUxr?=
 =?utf-8?B?V2JTVXB1NWlqbWl6SVJkQVNkS3ZTb2svelN6VjY1YkthRWJPS000aUJjcEhw?=
 =?utf-8?B?Z014bnFGdHlFYWEzSXdDL3NsQld5d0dDT2F5cWpaRWVtZStjbjNubWRGdXl5?=
 =?utf-8?B?eDlidzAvMHNkbUJ6ZTZHdjdVMEpZRGpRdUxCQ3l6cFJwSXdpb2g3STV5dkdX?=
 =?utf-8?B?KzA4eHFBNE9hcVg4S1FpZktvUm01aTRpdUpWVk1ZSXNtckdhM3c2aHVSaG5G?=
 =?utf-8?B?d0JreENnTnBUazdRdjNKZVhFa1kyVFI3MWEwSk5zTVhoQWVVZG1Qbk1Ja1dR?=
 =?utf-8?B?aFNlMnc1U1NLUVZHMERVaUZOaEE5cU1yWG9UTTVDQW1hMFh1THRsSUlydVdm?=
 =?utf-8?B?SDVaL3hPUkt2SHNDWnBZWTRpTUVxNHdQNk5pMTBEUTlacnB1aTBZWFYwUzlu?=
 =?utf-8?B?YjlDY3l4Q256Vi9QSFlVbWIvTWNjd0ZFV2JscFRQMU5zYWhsTk41V1lnWWhN?=
 =?utf-8?B?UzJKRlFmWmZtV3Q2WThkYUplREV0OE93dVZGUGRhaEJxZmlnYmNXR29xaDI0?=
 =?utf-8?B?bVRPeE9Ua0Q3d0dOL3hVR3N3RmRLeERqVHpsTnFsQjlJWUFkNGhmYVpxVE8w?=
 =?utf-8?B?OXRHbHRWeCtZK05qWnZvM3dHeEN1Um1FUGVwVGNFMEIwREN1a2d2OEhzc0xK?=
 =?utf-8?B?TThnK0l4RDBuUWZkb3VBWTkwbnduRGx6RDkxYzJsZ1JXbWNjSjJrU1BlenZJ?=
 =?utf-8?B?bTVlQzZaRHV1bHJ6dGFjVVJoMFdQaS9aQ1FyNGQzV2FMbGRxbit4NTlxR082?=
 =?utf-8?B?ZVd3TE1MSlE1NnpGc1JGUE11Ui9YU3dyeXRVSG1BSUI3cDFQSzJoeE9oUVdi?=
 =?utf-8?B?elVuMHBadVFLVndtaGNHU2t2M1Nyc01XbFo1SUxOUTVtOWlWUTlYSDc0SXlY?=
 =?utf-8?B?YWltRzJteWhRVFI0dnhnWnNXODBCbEs3SVcwUXVvV1J0TVBRajRLZjJNSGd3?=
 =?utf-8?B?Y3VyOXRRZGxNU29TMmJPcFdzajdOaWFFWFhWQklLS2RiKzNOK21hMWRDQVFk?=
 =?utf-8?B?Vzh1SXdCMTlFakFHdEdsSWRqdG50SmFkZFlnSXM3SVA3YTFXTUF2b0FzcDhS?=
 =?utf-8?B?a0tBSTdrNk5qMVJHT2EybDVNNVFkdDliSFBDMHFSYlVwc2JUMUQ1OVhCSDRj?=
 =?utf-8?B?bUNVNGc0bU5MOUJBVVJFMTNWSGEyYlNPTnEvakZRTnFKRFhlejh0c3I4WHJW?=
 =?utf-8?B?WTlNb2tJRXhPT203ZFZMYnVoM0tMUlFjVHhKNkJTUWRkL1I2KzQ2WU14V2Vt?=
 =?utf-8?B?c1VUWjFJRUhwQUVuRzFQNFl2cE0vbjBXN3BvZGZGY1g3MS8rS1pDN1JpN05R?=
 =?utf-8?B?VjEweExyK2VUQnNGVFVtbkxMdFJxZGM1bWdMWnhMMnhxS1ZwQ0ZkSUxCZXNl?=
 =?utf-8?B?Z2hkSW4rY29vN05GYVI1WjY3cTd1Rlpzc3duUnZINkJxZVFyYTdtUXpUZW05?=
 =?utf-8?B?dDFyUVE1eEVVYTU3U3JXSEo2RHFlc0JsMkhpaUJZQlA5ZTUvVUx2U0dycUtN?=
 =?utf-8?B?Rlh3L29UKzFUUGlwQ3VkRFphK0tLeG1rNGNKbEs1UC9RVjV2MzdXNlZmdDNi?=
 =?utf-8?B?ZXZnTHpTMHFSK0dKdGZxMzRqOE41Q0JKekhJdUw3UmVUbVRGUHFjeVRtZnIy?=
 =?utf-8?B?ZURjRzdtdlBldjEzU2QzQVpKaFFPNmN0dU9kbzRVTUN5U1UvYzJ2cnRMekFw?=
 =?utf-8?B?bnVxYXRlSm4vM0xCRCt4R2JnbTB2T25CeGtqZTluUndlcWhEOUovU2x3OGZH?=
 =?utf-8?B?dHpHcEpPV3dzZXpxSFlmcStGVGxpYUhiWnFYSUcvV3UyMHNzR2hPUT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <C6F6E02AEF5969498BD0AC2F710CDC1A@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3862b056-4d34-42a5-9074-08d9e634eefe
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Feb 2022 10:15:27.0578
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: C7wKCeVXUzG0zvbzI2lT0gQ5zCSGfXz6W3XM34g+5JpXB8RpKFRNA/nTHF4E63ZhR0ViBpi5EkQ8qksyBOgaeFuj8wUt01n5uf8qXSzECXXDQk16Zyo7Kb7YPAI9jhIh
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR03MB4025
X-Proofpoint-ORIG-GUID: IrCc5TJKdX3dJzVnvIBILTFr4mBxVKUq
X-Proofpoint-GUID: IrCc5TJKdX3dJzVnvIBILTFr4mBxVKUq
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-02_03,2022-02-01_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 mlxscore=0
 priorityscore=1501 lowpriorityscore=0 bulkscore=0 clxscore=1015
 mlxlogscore=999 phishscore=0 suspectscore=0 spamscore=0 adultscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202020054

SGksIFJvZ2VyIQ0KDQpPbiAwMi4wMi4yMiAxMTo0NSwgUm9nZXIgUGF1IE1vbm7DqSB3cm90ZToN
Cj4gT24gVHVlLCBGZWIgMDEsIDIwMjIgYXQgMDY6MjU6MDhQTSArMDIwMCwgT2xla3NhbmRyIEFu
ZHJ1c2hjaGVua28gd3JvdGU6DQo+PiBGcm9tOiBSb2dlciBQYXUgTW9ubmUgPHJvZ2VyLnBhdUBj
aXRyaXguY29tPg0KPj4NCj4+IFRoaXMgd2F5IHRoZSBsb2NrIGNhbiBiZSB1c2VkIHRvIGNoZWNr
IHdoZXRoZXIgdnBjaSBpcyBwcmVzZW50LCBhbmQNCj4+IHJlbW92YWwgY2FuIGJlIHBlcmZvcm1l
ZCB3aGlsZSBob2xkaW5nIHRoZSBsb2NrLCBpbiBvcmRlciB0byBtYWtlDQo+PiBzdXJlIHRoZXJl
IGFyZSBubyBhY2Nlc3NlcyB0byB0aGUgY29udGVudHMgb2YgdGhlIHZwY2kgc3RydWN0Lg0KPj4g
UHJldmlvdXNseSByZW1vdmFsIGNvdWxkIHJhY2Ugd2l0aCB2cGNpX3JlYWQgZm9yIGV4YW1wbGUs
IHNpbmNlIHRoZQ0KPj4gbG9jayB3YXMgZHJvcHBlZCBwcmlvciB0byBmcmVlaW5nIHBkZXYtPnZw
Y2kuDQo+Pg0KPj4gU2lnbmVkLW9mZi1ieTogUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNp
dHJpeC5jb20+DQo+PiBTaWduZWQtb2ZmLWJ5OiBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyA8b2xl
a3NhbmRyX2FuZHJ1c2hjaGVua29AZXBhbS5jb20+DQo+PiAtLS0NCj4+IENjOiBBbmRyZXcgQ29v
cGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPg0KPj4gQ2M6IEphbiBCZXVsaWNoIDxqYmV1
bGljaEBzdXNlLmNvbT4NCj4+IENjOiBKdWxpZW4gR3JhbGwgPGp1bGllbkB4ZW4ub3JnPg0KPj4g
Q2M6IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz4NCj4+IC0tLQ0K
Pj4gTmV3IGluIHY1IG9mIHRoaXMgc2VyaWVzOiB0aGlzIGlzIGFuIHVwZGF0ZWQgdmVyc2lvbiBv
ZiB0aGUgcGF0Y2ggcHVibGlzaGVkIGF0DQo+PiBodHRwczovL3VybGRlZmVuc2UuY29tL3YzL19f
aHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcveGVuLWRldmVsLzIwMTgwNzE3MDk0ODMwLjU0ODA2LTIt
cm9nZXIucGF1QGNpdHJpeC5jb20vX187ISFHRl8yOWRiY1FJVUJQQSFpbGhFbjJNLTQ0ZEtZOHJz
Vk83cUdtVVNZMjJ2U0h3TmFHSk5VcWh3dnItVjJrZGItRkRZTDZmMzlGUzhwS0ptM3E4SG5Penl1
QSQgW2xvcmVbLl1rZXJuZWxbLl1vcmddDQo+Pg0KPj4gQ2hhbmdlcyBzaW5jZSB2NToNCj4+ICAg
LSBkbyBub3Qgc3BsaXQgY29kZSBpbnRvIHZwY2lfcmVtb3ZlX2RldmljZV9oYW5kbGVyc19sb2Nr
ZWQgeWV0DQo+PiAgIC0gbW92ZSBJTklUX0xJU1RfSEVBRCBvdXRzaWRlIHRoZSBsb2NrZWQgcmVn
aW9uIChKYW4pDQo+PiAgIC0gc3RyaXBwZWQgb3V0IGxvY2tpbmcgb3B0aW1pemF0aW9ucyBmb3Ig
dnBjaV97cmVhZHx3cml0ZX0gaW50byBhDQo+PiAgICAgZGVkaWNhdGVkIHBhdGNoDQo+PiBDaGFu
Z2VzIHNpbmNlIHYyOg0KPj4gICAtIGZpeGVkIHBkZXYtPnZwY2kgPSB4emFsbG9jKHN0cnVjdCB2
cGNpKTsgdW5kZXIgc3Bpbl9sb2NrIChKYW4pDQo+PiBDaGFuZ2VzIHNpbmNlIHYxOg0KPj4gICAt
IEFzc2VydCB0aGF0IHZwY2lfbG9jayBpcyBsb2NrZWQgaW4gdnBjaV9yZW1vdmVfZGV2aWNlX2xv
Y2tlZC4NCj4+ICAgLSBSZW1vdmUgZG91YmxlIG5ld2xpbmUuDQo+PiAgIC0gU2hyaW5rIGNyaXRp
Y2FsIHNlY3Rpb24gaW4gdnBjaV97cmVhZC93cml0ZX0uDQo+PiAtLS0NCj4+ICAgdG9vbHMvdGVz
dHMvdnBjaS9lbXVsLmggICAgICAgfCAgNSArKy0NCj4+ICAgdG9vbHMvdGVzdHMvdnBjaS9tYWlu
LmMgICAgICAgfCAgNCArLS0NCj4+ICAgeGVuL2FyY2gveDg2L2h2bS92bXNpLmMgICAgICAgfCAg
OCArKy0tLQ0KPj4gICB4ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9wY2kuYyB8ICAxICsNCj4+ICAg
eGVuL2RyaXZlcnMvdnBjaS9oZWFkZXIuYyAgICAgfCAyMSArKysrKysrKy0tLS0NCj4+ICAgeGVu
L2RyaXZlcnMvdnBjaS9tc2kuYyAgICAgICAgfCAxMSArKysrLS0NCj4+ICAgeGVuL2RyaXZlcnMv
dnBjaS9tc2l4LmMgICAgICAgfCAgOCArKy0tLQ0KPj4gICB4ZW4vZHJpdmVycy92cGNpL3ZwY2ku
YyAgICAgICB8IDYzICsrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tDQo+PiAgIHhl
bi9pbmNsdWRlL3hlbi9wY2kuaCAgICAgICAgIHwgIDEgKw0KPj4gICB4ZW4vaW5jbHVkZS94ZW4v
dnBjaS5oICAgICAgICB8ICAzICstDQo+PiAgIDEwIGZpbGVzIGNoYW5nZWQsIDc4IGluc2VydGlv
bnMoKyksIDQ3IGRlbGV0aW9ucygtKQ0KPj4NCj4+IGRpZmYgLS1naXQgYS90b29scy90ZXN0cy92
cGNpL2VtdWwuaCBiL3Rvb2xzL3Rlc3RzL3ZwY2kvZW11bC5oDQo+PiBpbmRleCAyZTFkMzA1N2M5
ZDguLmQwMThmYjVlZWYyMSAxMDA2NDQNCj4+IC0tLSBhL3Rvb2xzL3Rlc3RzL3ZwY2kvZW11bC5o
DQo+PiArKysgYi90b29scy90ZXN0cy92cGNpL2VtdWwuaA0KPj4gQEAgLTQ0LDYgKzQ0LDcgQEAg
c3RydWN0IGRvbWFpbiB7DQo+PiAgIH07DQo+PiAgIA0KPj4gICBzdHJ1Y3QgcGNpX2RldiB7DQo+
PiArICAgIGJvb2wgdnBjaV9sb2NrOw0KPj4gICAgICAgc3RydWN0IHZwY2kgKnZwY2k7DQo+PiAg
IH07DQo+PiAgIA0KPj4gQEAgLTUzLDEwICs1NCw4IEBAIHN0cnVjdCB2Y3B1DQo+PiAgIH07DQo+
PiAgIA0KPj4gICBleHRlcm4gY29uc3Qgc3RydWN0IHZjcHUgKmN1cnJlbnQ7DQo+PiAtZXh0ZXJu
IGNvbnN0IHN0cnVjdCBwY2lfZGV2IHRlc3RfcGRldjsNCj4+ICtleHRlcm4gc3RydWN0IHBjaV9k
ZXYgdGVzdF9wZGV2Ow0KPj4gICANCj4+IC10eXBlZGVmIGJvb2wgc3BpbmxvY2tfdDsNCj4+IC0j
ZGVmaW5lIHNwaW5fbG9ja19pbml0KGwpICgqKGwpID0gZmFsc2UpDQo+PiAgICNkZWZpbmUgc3Bp
bl9sb2NrKGwpICgqKGwpID0gdHJ1ZSkNCj4+ICAgI2RlZmluZSBzcGluX3VubG9jayhsKSAoKihs
KSA9IGZhbHNlKQ0KPj4gICANCj4+IGRpZmYgLS1naXQgYS90b29scy90ZXN0cy92cGNpL21haW4u
YyBiL3Rvb2xzL3Rlc3RzL3ZwY2kvbWFpbi5jDQo+PiBpbmRleCBiOWEwYTYwMDZiYjkuLjI2Yzk1
YjA4YjZiMSAxMDA2NDQNCj4+IC0tLSBhL3Rvb2xzL3Rlc3RzL3ZwY2kvbWFpbi5jDQo+PiArKysg
Yi90b29scy90ZXN0cy92cGNpL21haW4uYw0KPj4gQEAgLTIzLDcgKzIzLDggQEAgc3RhdGljIHN0
cnVjdCB2cGNpIHZwY2k7DQo+PiAgIA0KPj4gICBjb25zdCBzdGF0aWMgc3RydWN0IGRvbWFpbiBk
Ow0KPj4gICANCj4+IC1jb25zdCBzdHJ1Y3QgcGNpX2RldiB0ZXN0X3BkZXYgPSB7DQo+PiArc3Ry
dWN0IHBjaV9kZXYgdGVzdF9wZGV2ID0gew0KPj4gKyAgICAudnBjaV9sb2NrID0gZmFsc2UsDQo+
IE5pdDogdnBjaV9sb2NrIHdpbGwgYWxyZWFkeSBiZSBpbml0aWFsaXplZCB0byBmYWxzZSBieSBk
ZWZhdWx0LCBzbw0KPiB0aGlzIGlzIHJlZHVuZGFudC4NCldpbGwgcmVtb3ZlDQo+DQo+PiAgICAg
ICAudnBjaSA9ICZ2cGNpLA0KPj4gICB9Ow0KPj4gICANCj4+IEBAIC0xNTgsNyArMTU5LDYgQEAg
bWFpbihpbnQgYXJnYywgY2hhciAqKmFyZ3YpDQo+PiAgICAgICBpbnQgcmM7DQo+PiAgIA0KPj4g
ICAgICAgSU5JVF9MSVNUX0hFQUQoJnZwY2kuaGFuZGxlcnMpOw0KPj4gLSAgICBzcGluX2xvY2tf
aW5pdCgmdnBjaS5sb2NrKTsNCj4+ICAgDQo+PiAgICAgICBWUENJX0FERF9SRUcodnBjaV9yZWFk
MzIsIHZwY2lfd3JpdGUzMiwgMCwgNCwgcjApOw0KPj4gICAgICAgVlBDSV9SRUFEX0NIRUNLKDAs
IDQsIHIwKTsNCj4+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC94ODYvaHZtL3Ztc2kuYyBiL3hlbi9h
cmNoL3g4Ni9odm0vdm1zaS5jDQo+PiBpbmRleCAxM2UyYTE5MGI0MzkuLjFmN2EzN2Y3ODI2NCAx
MDA2NDQNCj4+IC0tLSBhL3hlbi9hcmNoL3g4Ni9odm0vdm1zaS5jDQo+PiArKysgYi94ZW4vYXJj
aC94ODYvaHZtL3Ztc2kuYw0KPj4gQEAgLTkxMCwxNCArOTEwLDE0IEBAIGludCB2cGNpX21zaXhf
YXJjaF9wcmludChjb25zdCBzdHJ1Y3QgdnBjaV9tc2l4ICptc2l4KQ0KPj4gICAgICAgICAgIHsN
Cj4+ICAgICAgICAgICAgICAgc3RydWN0IHBjaV9kZXYgKnBkZXYgPSBtc2l4LT5wZGV2Ow0KPj4g
ICANCj4+IC0gICAgICAgICAgICBzcGluX3VubG9jaygmbXNpeC0+cGRldi0+dnBjaS0+bG9jayk7
DQo+PiArICAgICAgICAgICAgc3Bpbl91bmxvY2soJm1zaXgtPnBkZXYtPnZwY2lfbG9jayk7DQo+
PiAgICAgICAgICAgICAgIHByb2Nlc3NfcGVuZGluZ19zb2Z0aXJxcygpOw0KPj4gICAgICAgICAg
ICAgICAvKiBOQjogd2UgYXNzdW1lIHRoYXQgcGRldiBjYW5ub3QgZ28gYXdheSBmb3IgYW4gYWxp
dmUgZG9tYWluLiAqLw0KPj4gLSAgICAgICAgICAgIGlmICggIXBkZXYtPnZwY2kgfHwgIXNwaW5f
dHJ5bG9jaygmcGRldi0+dnBjaS0+bG9jaykgKQ0KPj4gKyAgICAgICAgICAgIGlmICggIXNwaW5f
dHJ5bG9jaygmcGRldi0+dnBjaV9sb2NrKSApDQo+PiAgICAgICAgICAgICAgICAgICByZXR1cm4g
LUVCVVNZOw0KPj4gLSAgICAgICAgICAgIGlmICggcGRldi0+dnBjaS0+bXNpeCAhPSBtc2l4ICkN
Cj4+ICsgICAgICAgICAgICBpZiAoICFwZGV2LT52cGNpIHx8IHBkZXYtPnZwY2ktPm1zaXggIT0g
bXNpeCApDQo+PiAgICAgICAgICAgICAgIHsNCj4+IC0gICAgICAgICAgICAgICAgc3Bpbl91bmxv
Y2soJnBkZXYtPnZwY2ktPmxvY2spOw0KPj4gKyAgICAgICAgICAgICAgICBzcGluX3VubG9jaygm
cGRldi0+dnBjaV9sb2NrKTsNCj4+ICAgICAgICAgICAgICAgICAgIHJldHVybiAtRUFHQUlOOw0K
Pj4gICAgICAgICAgICAgICB9DQo+PiAgICAgICAgICAgfQ0KPj4gZGlmZiAtLWdpdCBhL3hlbi9k
cml2ZXJzL3Bhc3N0aHJvdWdoL3BjaS5jIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvcGNpLmMN
Cj4+IGluZGV4IDFmYWQ4MDM2MmYwZS4uYWY2NDhjNmExOWI1IDEwMDY0NA0KPj4gLS0tIGEveGVu
L2RyaXZlcnMvcGFzc3Rocm91Z2gvcGNpLmMNCj4+ICsrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJv
dWdoL3BjaS5jDQo+PiBAQCAtMzI4LDYgKzMyOCw3IEBAIHN0YXRpYyBzdHJ1Y3QgcGNpX2RldiAq
YWxsb2NfcGRldihzdHJ1Y3QgcGNpX3NlZyAqcHNlZywgdTggYnVzLCB1OCBkZXZmbikNCj4+ICAg
ICAgICooKHU4KikgJnBkZXYtPmJ1cykgPSBidXM7DQo+PiAgICAgICAqKCh1OCopICZwZGV2LT5k
ZXZmbikgPSBkZXZmbjsNCj4+ICAgICAgIHBkZXYtPmRvbWFpbiA9IE5VTEw7DQo+PiArICAgIHNw
aW5fbG9ja19pbml0KCZwZGV2LT52cGNpX2xvY2spOw0KPj4gICANCj4+ICAgICAgIGFyY2hfcGNp
X2luaXRfcGRldihwZGV2KTsNCj4+ICAgDQo+PiBkaWZmIC0tZ2l0IGEveGVuL2RyaXZlcnMvdnBj
aS9oZWFkZXIuYyBiL3hlbi9kcml2ZXJzL3ZwY2kvaGVhZGVyLmMNCj4+IGluZGV4IDQwZmY3OWMz
M2Y4Zi4uYmQyM2MwMjc0ZDQ4IDEwMDY0NA0KPj4gLS0tIGEveGVuL2RyaXZlcnMvdnBjaS9oZWFk
ZXIuYw0KPj4gKysrIGIveGVuL2RyaXZlcnMvdnBjaS9oZWFkZXIuYw0KPj4gQEAgLTE0MiwxMiAr
MTQyLDEzIEBAIGJvb2wgdnBjaV9wcm9jZXNzX3BlbmRpbmcoc3RydWN0IHZjcHUgKnYpDQo+PiAg
ICAgICAgICAgaWYgKCByYyA9PSAtRVJFU1RBUlQgKQ0KPj4gICAgICAgICAgICAgICByZXR1cm4g
dHJ1ZTsNCj4+ICAgDQo+PiAtICAgICAgICBzcGluX2xvY2soJnYtPnZwY2kucGRldi0+dnBjaS0+
bG9jayk7DQo+PiAtICAgICAgICAvKiBEaXNhYmxlIG1lbW9yeSBkZWNvZGluZyB1bmNvbmRpdGlv
bmFsbHkgb24gZmFpbHVyZS4gKi8NCj4+IC0gICAgICAgIG1vZGlmeV9kZWNvZGluZyh2LT52cGNp
LnBkZXYsDQo+PiAtICAgICAgICAgICAgICAgICAgICAgICAgcmMgPyB2LT52cGNpLmNtZCAmIH5Q
Q0lfQ09NTUFORF9NRU1PUlkgOiB2LT52cGNpLmNtZCwNCj4+IC0gICAgICAgICAgICAgICAgICAg
ICAgICAhcmMgJiYgdi0+dnBjaS5yb21fb25seSk7DQo+PiAtICAgICAgICBzcGluX3VubG9jaygm
di0+dnBjaS5wZGV2LT52cGNpLT5sb2NrKTsNCj4+ICsgICAgICAgIHNwaW5fbG9jaygmdi0+dnBj
aS5wZGV2LT52cGNpX2xvY2spOw0KPj4gKyAgICAgICAgaWYgKCB2LT52cGNpLnBkZXYtPnZwY2kg
KQ0KPj4gKyAgICAgICAgICAgIC8qIERpc2FibGUgbWVtb3J5IGRlY29kaW5nIHVuY29uZGl0aW9u
YWxseSBvbiBmYWlsdXJlLiAqLw0KPj4gKyAgICAgICAgICAgIG1vZGlmeV9kZWNvZGluZyh2LT52
cGNpLnBkZXYsDQo+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJjID8gdi0+dnBjaS5j
bWQgJiB+UENJX0NPTU1BTkRfTUVNT1JZIDogdi0+dnBjaS5jbWQsDQo+PiArICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICFyYyAmJiB2LT52cGNpLnJvbV9vbmx5KTsNCj4+ICsgICAgICAgIHNw
aW5fdW5sb2NrKCZ2LT52cGNpLnBkZXYtPnZwY2lfbG9jayk7DQo+PiAgIA0KPj4gICAgICAgICAg
IHJhbmdlc2V0X2Rlc3Ryb3kodi0+dnBjaS5tZW0pOw0KPj4gICAgICAgICAgIHYtPnZwY2kubWVt
ID0gTlVMTDsNCj4+IEBAIC0yODUsNiArMjg2LDEyIEBAIHN0YXRpYyBpbnQgbW9kaWZ5X2JhcnMo
Y29uc3Qgc3RydWN0IHBjaV9kZXYgKnBkZXYsIHVpbnQxNl90IGNtZCwgYm9vbCByb21fb25seSkN
Cj4+ICAgICAgICAgICAgICAgICAgIGNvbnRpbnVlOw0KPj4gICAgICAgICAgIH0NCj4+ICAgDQo+
PiArICAgICAgICBzcGluX2xvY2soJnRtcC0+dnBjaV9sb2NrKTsNCj4+ICsgICAgICAgIGlmICgg
IXRtcC0+dnBjaSApDQo+PiArICAgICAgICB7DQo+PiArICAgICAgICAgICAgc3Bpbl91bmxvY2so
JnRtcC0+dnBjaV9sb2NrKTsNCj4+ICsgICAgICAgICAgICBjb250aW51ZTsNCj4+ICsgICAgICAg
IH0NCj4+ICAgICAgICAgICBmb3IgKCBpID0gMDsgaSA8IEFSUkFZX1NJWkUodG1wLT52cGNpLT5o
ZWFkZXIuYmFycyk7IGkrKyApDQo+PiAgICAgICAgICAgew0KPj4gICAgICAgICAgICAgICBjb25z
dCBzdHJ1Y3QgdnBjaV9iYXIgKmJhciA9ICZ0bXAtPnZwY2ktPmhlYWRlci5iYXJzW2ldOw0KPj4g
QEAgLTMwMywxMiArMzEwLDE0IEBAIHN0YXRpYyBpbnQgbW9kaWZ5X2JhcnMoY29uc3Qgc3RydWN0
IHBjaV9kZXYgKnBkZXYsIHVpbnQxNl90IGNtZCwgYm9vbCByb21fb25seSkNCj4+ICAgICAgICAg
ICAgICAgcmMgPSByYW5nZXNldF9yZW1vdmVfcmFuZ2UobWVtLCBzdGFydCwgZW5kKTsNCj4+ICAg
ICAgICAgICAgICAgaWYgKCByYyApDQo+PiAgICAgICAgICAgICAgIHsNCj4+ICsgICAgICAgICAg
ICAgICAgc3Bpbl91bmxvY2soJnRtcC0+dnBjaV9sb2NrKTsNCj4+ICAgICAgICAgICAgICAgICAg
IHByaW50ayhYRU5MT0dfR19XQVJOSU5HICJGYWlsZWQgdG8gcmVtb3ZlIFslbHgsICVseF06ICVk
XG4iLA0KPj4gICAgICAgICAgICAgICAgICAgICAgICAgIHN0YXJ0LCBlbmQsIHJjKTsNCj4+ICAg
ICAgICAgICAgICAgICAgIHJhbmdlc2V0X2Rlc3Ryb3kobWVtKTsNCj4+ICAgICAgICAgICAgICAg
ICAgIHJldHVybiByYzsNCj4+ICAgICAgICAgICAgICAgfQ0KPj4gICAgICAgICAgIH0NCj4+ICsg
ICAgICAgIHNwaW5fdW5sb2NrKCZ0bXAtPnZwY2lfbG9jayk7DQo+PiAgICAgICB9DQo+PiAgIA0K
Pj4gICAgICAgQVNTRVJUKGRldik7DQo+PiBkaWZmIC0tZ2l0IGEveGVuL2RyaXZlcnMvdnBjaS9t
c2kuYyBiL3hlbi9kcml2ZXJzL3ZwY2kvbXNpLmMNCj4+IGluZGV4IDU3NTdhN2FlZDIwZi4uZTNj
ZTQ2ODY5ZGFkIDEwMDY0NA0KPj4gLS0tIGEveGVuL2RyaXZlcnMvdnBjaS9tc2kuYw0KPj4gKysr
IGIveGVuL2RyaXZlcnMvdnBjaS9tc2kuYw0KPj4gQEAgLTI3MCw3ICsyNzAsNyBAQCB2b2lkIHZw
Y2lfZHVtcF9tc2kodm9pZCkNCj4+ICAgICAgIHJjdV9yZWFkX2xvY2soJmRvbWxpc3RfcmVhZF9s
b2NrKTsNCj4+ICAgICAgIGZvcl9lYWNoX2RvbWFpbiAoIGQgKQ0KPj4gICAgICAgew0KPj4gLSAg
ICAgICAgY29uc3Qgc3RydWN0IHBjaV9kZXYgKnBkZXY7DQo+PiArICAgICAgICBzdHJ1Y3QgcGNp
X2RldiAqcGRldjsNCj4+ICAgDQo+PiAgICAgICAgICAgaWYgKCAhaGFzX3ZwY2koZCkgKQ0KPj4g
ICAgICAgICAgICAgICBjb250aW51ZTsNCj4+IEBAIC0yODIsOCArMjgyLDEzIEBAIHZvaWQgdnBj
aV9kdW1wX21zaSh2b2lkKQ0KPj4gICAgICAgICAgICAgICBjb25zdCBzdHJ1Y3QgdnBjaV9tc2kg
Km1zaTsNCj4+ICAgICAgICAgICAgICAgY29uc3Qgc3RydWN0IHZwY2lfbXNpeCAqbXNpeDsNCj4+
ICAgDQo+PiAtICAgICAgICAgICAgaWYgKCAhcGRldi0+dnBjaSB8fCAhc3Bpbl90cnlsb2NrKCZw
ZGV2LT52cGNpLT5sb2NrKSApDQo+PiArICAgICAgICAgICAgaWYgKCAhc3Bpbl90cnlsb2NrKCZw
ZGV2LT52cGNpX2xvY2spICkNCj4+ICAgICAgICAgICAgICAgICAgIGNvbnRpbnVlOw0KPj4gKyAg
ICAgICAgICAgIGlmICggIXBkZXYtPnZwY2kgKQ0KPj4gKyAgICAgICAgICAgIHsNCj4+ICsgICAg
ICAgICAgICAgICAgc3Bpbl91bmxvY2soJnBkZXYtPnZwY2lfbG9jayk7DQo+PiArICAgICAgICAg
ICAgICAgIGNvbnRpbnVlOw0KPj4gKyAgICAgICAgICAgIH0NCj4+ICAgDQo+PiAgICAgICAgICAg
ICAgIG1zaSA9IHBkZXYtPnZwY2ktPm1zaTsNCj4+ICAgICAgICAgICAgICAgaWYgKCBtc2kgJiYg
bXNpLT5lbmFibGVkICkNCj4+IEBAIC0zMjMsNyArMzI4LDcgQEAgdm9pZCB2cGNpX2R1bXBfbXNp
KHZvaWQpDQo+PiAgICAgICAgICAgICAgICAgICB9DQo+PiAgICAgICAgICAgICAgIH0NCj4+ICAg
DQo+PiAtICAgICAgICAgICAgc3Bpbl91bmxvY2soJnBkZXYtPnZwY2ktPmxvY2spOw0KPj4gKyAg
ICAgICAgICAgIHNwaW5fdW5sb2NrKCZwZGV2LT52cGNpX2xvY2spOw0KPj4gICAgICAgICAgICAg
ICBwcm9jZXNzX3BlbmRpbmdfc29mdGlycXMoKTsNCj4+ICAgICAgICAgICB9DQo+PiAgICAgICB9
DQo+PiBkaWZmIC0tZ2l0IGEveGVuL2RyaXZlcnMvdnBjaS9tc2l4LmMgYi94ZW4vZHJpdmVycy92
cGNpL21zaXguYw0KPj4gaW5kZXggODQ2ZjFiOGQ3MDM4Li41MzEwY2MzZmY1MjAgMTAwNjQ0DQo+
PiAtLS0gYS94ZW4vZHJpdmVycy92cGNpL21zaXguYw0KPj4gKysrIGIveGVuL2RyaXZlcnMvdnBj
aS9tc2l4LmMNCj4+IEBAIC0yMjUsNyArMjI1LDcgQEAgc3RhdGljIGludCBtc2l4X3JlYWQoc3Ry
dWN0IHZjcHUgKnYsIHVuc2lnbmVkIGxvbmcgYWRkciwgdW5zaWduZWQgaW50IGxlbiwNCj4gSSB0
aGluayB5b3UgYWxzbyBuZWVkIHRvIGFkZCBsb2NraW5nIHRvIG1zaXhfZmluZCwgb3RoZXJ3aXNl
IGl0IHdpbGwNCj4gZGVyZWZlcmVuY2UgcGRldi0+dnBjaSB3aXRob3V0IGhvbGRpbmcgdGhlIHZw
Y2lfbG9jay4NCj4NCj4gSXQgbWlnaHQgYmUgYSBiZXR0ZXIgYXBwcm9hY2ggdG8gcmVuYW1lIG1z
aXhfZmluZCB0byBtc2l4X2dldCBhbmQNCj4gcmV0dXJuIHRoZSB2cGNpX21zaXggc3RydWN0IHdp
dGggdGhlIHZwY2lfbG9jayB0YWtlbiwgc28gd2UgY2FuIGFzc2VydA0KPiBpdCdzIG5vdCBnb2lu
ZyB0byBkaXNhcHBlYXIgdW5kZXIgb3VyIGZlZXQuIFRoZW4geW91IHdpbGwgYWxzbyBuZWVkIHRv
DQo+IGFkZCBhIG1zaXhfcHV0IGZ1bmN0aW9uIHRoYXQgcmVsZWFzZXMgdGhlIGxvY2suDQpPaywg
c291bmRzIGdvb2Q6IHNvLCBJJ2xsIGltcGxlbWVudCBtc2l4X3tnZXR8cHV0fSB0aGVuDQo+DQo+
PiAgICAgICAgICAgcmV0dXJuIFg4NkVNVUxfT0tBWTsNCj4+ICAgICAgIH0NCj4+ICAgDQo+PiAt
ICAgIHNwaW5fbG9jaygmbXNpeC0+cGRldi0+dnBjaS0+bG9jayk7DQo+PiArICAgIHNwaW5fbG9j
aygmbXNpeC0+cGRldi0+dnBjaV9sb2NrKTsNCj4+ICAgICAgIGVudHJ5ID0gZ2V0X2VudHJ5KG1z
aXgsIGFkZHIpOw0KPj4gICAgICAgb2Zmc2V0ID0gYWRkciAmIChQQ0lfTVNJWF9FTlRSWV9TSVpF
IC0gMSk7DQo+PiAgIA0KPj4gQEAgLTI1NCw3ICsyNTQsNyBAQCBzdGF0aWMgaW50IG1zaXhfcmVh
ZChzdHJ1Y3QgdmNwdSAqdiwgdW5zaWduZWQgbG9uZyBhZGRyLCB1bnNpZ25lZCBpbnQgbGVuLA0K
Pj4gICAgICAgICAgIEFTU0VSVF9VTlJFQUNIQUJMRSgpOw0KPj4gICAgICAgICAgIGJyZWFrOw0K
Pj4gICAgICAgfQ0KPj4gLSAgICBzcGluX3VubG9jaygmbXNpeC0+cGRldi0+dnBjaS0+bG9jayk7
DQo+PiArICAgIHNwaW5fdW5sb2NrKCZtc2l4LT5wZGV2LT52cGNpX2xvY2spOw0KPj4gICANCj4+
ICAgICAgIHJldHVybiBYODZFTVVMX09LQVk7DQo+PiAgIH0NCj4+IEBAIC0yOTcsNyArMjk3LDcg
QEAgc3RhdGljIGludCBtc2l4X3dyaXRlKHN0cnVjdCB2Y3B1ICp2LCB1bnNpZ25lZCBsb25nIGFk
ZHIsIHVuc2lnbmVkIGludCBsZW4sDQo+PiAgICAgICAgICAgcmV0dXJuIFg4NkVNVUxfT0tBWTsN
Cj4+ICAgICAgIH0NCj4+ICAgDQo+PiAtICAgIHNwaW5fbG9jaygmbXNpeC0+cGRldi0+dnBjaS0+
bG9jayk7DQo+PiArICAgIHNwaW5fbG9jaygmbXNpeC0+cGRldi0+dnBjaV9sb2NrKTsNCj4+ICAg
ICAgIGVudHJ5ID0gZ2V0X2VudHJ5KG1zaXgsIGFkZHIpOw0KPj4gICAgICAgb2Zmc2V0ID0gYWRk
ciAmIChQQ0lfTVNJWF9FTlRSWV9TSVpFIC0gMSk7DQo+PiAgIA0KPj4gQEAgLTM3MCw3ICszNzAs
NyBAQCBzdGF0aWMgaW50IG1zaXhfd3JpdGUoc3RydWN0IHZjcHUgKnYsIHVuc2lnbmVkIGxvbmcg
YWRkciwgdW5zaWduZWQgaW50IGxlbiwNCj4+ICAgICAgICAgICBBU1NFUlRfVU5SRUFDSEFCTEUo
KTsNCj4+ICAgICAgICAgICBicmVhazsNCj4+ICAgICAgIH0NCj4+IC0gICAgc3Bpbl91bmxvY2so
Jm1zaXgtPnBkZXYtPnZwY2ktPmxvY2spOw0KPj4gKyAgICBzcGluX3VubG9jaygmbXNpeC0+cGRl
di0+dnBjaV9sb2NrKTsNCj4+ICAgDQo+PiAgICAgICByZXR1cm4gWDg2RU1VTF9PS0FZOw0KPj4g
ICB9DQo+PiBkaWZmIC0tZ2l0IGEveGVuL2RyaXZlcnMvdnBjaS92cGNpLmMgYi94ZW4vZHJpdmVy
cy92cGNpL3ZwY2kuYw0KPj4gaW5kZXggZmIwOTQ3MTc5Yjc5Li5jMDE1YTRkNzc1NDAgMTAwNjQ0
DQo+PiAtLS0gYS94ZW4vZHJpdmVycy92cGNpL3ZwY2kuYw0KPj4gKysrIGIveGVuL2RyaXZlcnMv
dnBjaS92cGNpLmMNCj4+IEBAIC0zNSwxMiArMzUsMTAgQEAgZXh0ZXJuIHZwY2lfcmVnaXN0ZXJf
aW5pdF90ICpjb25zdCBfX3N0YXJ0X3ZwY2lfYXJyYXlbXTsNCj4+ICAgZXh0ZXJuIHZwY2lfcmVn
aXN0ZXJfaW5pdF90ICpjb25zdCBfX2VuZF92cGNpX2FycmF5W107DQo+PiAgICNkZWZpbmUgTlVN
X1ZQQ0lfSU5JVCAoX19lbmRfdnBjaV9hcnJheSAtIF9fc3RhcnRfdnBjaV9hcnJheSkNCj4+ICAg
DQo+PiAtdm9pZCB2cGNpX3JlbW92ZV9kZXZpY2Uoc3RydWN0IHBjaV9kZXYgKnBkZXYpDQo+PiAr
c3RhdGljIHZvaWQgdnBjaV9yZW1vdmVfZGV2aWNlX2xvY2tlZChzdHJ1Y3QgcGNpX2RldiAqcGRl
dikNCj4gTml0OiBzaW5jZSBpdCdzIGEgc3RhdGljIGZ1bmN0aW9uIHlvdSBjYW4gZHJvcCB0aGUg
dnBjaV8gcHJlZml4IGhlcmUuDQpUaGlzIGZ1bmN0aW9uIGlzIGdvaW5nIHRvIGJlIHVzZWQgb3V0
c2lkZSBsYXRlciBvbiwgYnV0IG5vdCB5ZXQuDQpTbywgSSBjYW4gY2hhbmdlIHRoZSBuYW1lIGFu
ZCB0aGVuIGNoYW5nZSBpdCBiYWNrIG9uY2UgaXQgaXMNCnVzZWQgYnkgb3RoZXJzLg0KV2hhdCdz
IHlvdXIgcHJlZmVyZW5jZSBoZXJlPw0KPg0KPiBUaGFua3MsIFJvZ2VyLg0KVGhhbmsgeW91LA0K
T2xla3NhbmRy


From xen-devel-bounces@lists.xenproject.org Wed Feb 02 10:35:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 10:35:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264034.456977 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFCyq-0001D8-5T; Wed, 02 Feb 2022 10:35:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264034.456977; Wed, 02 Feb 2022 10:35:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFCyp-0001D1-W4; Wed, 02 Feb 2022 10:35:15 +0000
Received: by outflank-mailman (input) for mailman id 264034;
 Wed, 02 Feb 2022 10:35:14 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HAZh=SR=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nFCyo-0001Cp-FU
 for xen-devel@lists.xenproject.org; Wed, 02 Feb 2022 10:35:14 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id cc5b31ec-8413-11ec-8eb8-a37418f5ba1a;
 Wed, 02 Feb 2022 11:35:12 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cc5b31ec-8413-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1643798112;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=JaNgHiiT2CUPXEFlQPWamLdsisXh6TwyCUAtSiC4Kvk=;
  b=bREdVRxovmRkgzq+r8qc3mZjcpWQy3FVNujHMCxRfW9fPbLR6jqGasDI
   mQtQeqfNEq/TdYAOKzMJVg4ENSeIWg9eRGG4zk1NWS6jaYQ69RnWcaNwg
   r7TQ/B0iabOhKY+YjD/InMLSwd9pY11cw0IfYHZ/uAnIsqkeOVva66S4G
   c=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: HOhXjLI1DNdmgZ5v6J5Iv9CX1v160vwBuYyfuDaLqEe2UkpaDf2zsRJv3n7k5VuL6UTbUNWmPC
 7IE4HnPZgoSx/jy2P1ktgYGBo7D7ePgzoq84LkdiYbnV7CJmXupvlF1HErWvjuX+nVQNA+bneB
 Kn6y5LMQUvTHxCn7c7PtZ6rv9a6OG7lfgOANVQHQfgovFTRvkF/QEKDyxLgnU0U4IRRasQfsCv
 aAuzvsK38+05h/uFZY4lT2xBmwDhdWsRXKU2je4T8UDtN9Th30yq2yPlntEOl7Vr88NsNAhmxz
 V/flmrfKbHgggeMD2its9+J1
X-SBRS: 5.2
X-MesageID: 63222047
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:l+blKa4MpKfqsnX4MsILowxRtBjBchMFZxGqfqrLsTDasY5as4F+v
 mJLUDjVMv3ZY2ujcot0OY+ypEtXuJXcxtMyQQZo+HthHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FV8MpBsJ00o5wbZj2tQw2LBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zl
 8cQhMG0Vy4QM7SWnqdHXyhfQwR0BPgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALNs7kMZlZonh95TrYEewnUdbIRKCiCdpwgmxq3JoWQam2i
 8wxNSBgbAWbUix0eVIKS8gUnfbzj1n4WmgNwL6SjfVuuDWCpOBr65DvOtfIft2BRe1Og12V4
 GnB+gzRKwsGOdmo7CuK+3OhmMfChSr+HokVEdWQ7vd3hHWDy2pVDwcZPXOhqPmkjgilWtRQK
 2Qd4C9opq83nGShQ8PhRRS+rDiBtwQFRttLO+Qg7UeGza+8yzieAm8IXztQcusMvcU9RSEp/
 lKRltavDjtq2JWFRHTY+rqKoDeaPSkOMXREdSICVREC4dTovMc0lB2nZvFnHa2uh9v5AwbZx
 TyQsTM+jLUei80M/6ij9FWBiDWpzrDLUwo06wP/Tm+jqARja+aNQIil6kPS6/paG7qIVVmKv
 HUCmM+24fgHCNeGkynlaP4WALij6vKBMTvdqV1iBZ8s83Kq4XHLQGxLyGggfgEzaJ9CIGK3J
 h+I0e9M2HNNFCS4MJ4qZ5yYMskzl66jT9jUUaDxZOMbN/CdazS71C1pYEeR2UXkn04tjbwzN
 P+nTCq8MZoJIf85lWTrHo/xxZdun3ljnj2LGfgX2jz6ieL2WZKDdVsS3LJihMgd5bjMngja+
 s032yCim0QGC72WjsU6HOcuwbE2wZoTWcGeRy9/LLfrzu9a9IYJUKe5/F/ZU9Y595m5b8+Rl
 p1HZmdWyUDkmVrMIhiQZ3ZoZdvHBMgj9i1nZH19YA/2ixDPhLpDC49EL/MKkUQPrrQ/nZaYs
 dFZEyl/Phi/YmueoGlMBXUMhIdjaA6qlWqz09mNO1ACk2pbb1WRoLfMJ1K3nAFXV3bfnZZg/
 9WIi12KKbJeF1UKJJuHM5qHkgLu1UXxbcovBSMk1PEJJhW1mGWrQgSs5sIKzzYkckSen2bKi
 lrNXH/1Z4Dl+ucIzTUAvojdx6+BGOpiBEtKWW7d6Le9Ly7B+WS/h4RHVY61kfr1DgsYIY2uO
 rdYye/SKvoCkAoYuoZwCe8zn6k/+8Hut/lRyQE9RCfHaFGiC7VBJHia3JYQ6v0Rl+EB4QbmC
 FiS/tR6OKmSPJ+3GlAmOwd4PP+I0usZm2eO4K1tcln6/iJ+4JGOTV5WY0uXkCVYIbYsaNElz
 O4ttdQ48Qu6jhZ2YN+KgjoNrzaHL2AaUrVhvZYfWde5hg0uw1BEQJrdFi6pv83fN4QSahEne
 2bGirDDirJQwlv5X0AyTXWdj/BAgZkuuQxRyANQLVq+hdeY1OQ82wdc8GprQ10NnAlHye96J
 kNiK1ZxefeV5z5ticVOAzKsFgVGCEHL80D90QJUxmjQTk3uXW3RNmwtf+2K+RlBoW5bezFa+
 pCeyXrkDmm2LJ2ggHNqVB43seHnQPxw6hbGyZKuEMmyFpUnZSbo3/21bm0Sphq7Wc48iSUrf
 wWxEDqcvUEjCRMtng==
IronPort-HdrOrdr: A9a23:WX4+X6z6WE6jNfe72py+KrPxtOskLtp133Aq2lEZdPULSKOlfp
 GV8MjziyWYtN9wYhAdcdDpAtjmfZr5z+8O3WB3B8beYOCGghrSEGgG1+XfKlLbak/DH4JmpM
 Jdmu1FeaHN5DtB/LfHCWuDYq8dKbC8mcjC74eurEuFDzsaE52Ihz0JdDpzeXcGIjWua6BJcK
 Z1saF81kWdkDksH4+GL0hAe9KGi8zAlZrgbxJDLxk76DOWhTftzLLhCRCX0joXTjsKmN4ZgC
 X4uj28wp/mn+Cwyxfa2WOWx5NKmOH5wt8GIMCXkMAaJhjllw7tToV8XL+puiwzvYiUmRwXue
 iJhy1lE9V46nvXcG3wiRzx2zP42DJr0HPmwU/wuwqUneXJABYBT+ZRj4NQdRXUr2A6ustn7a
 5N12WF87JKEBLphk3Glpb1fiAvsnDxjWspkOYVgXAae5AZcqVtoYsW+14QOIscHRj99JssHI
 BVfY7hDc5tABOnhk3izypSKITGZAVwIv7GeDlPhiWt6UkWoJgjpHFogfD2nR87heUAotd/lq
 D5259T5cJzp/ktHNZA7dc6MLuK41P2MGDx2UKpUB3a/fI8SjrwQ6Ce2sRB2AjtQu1O8KcP
X-IronPort-AV: E=Sophos;i="5.88,336,1635220800"; 
   d="scan'208";a="63222047"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Lw5N+buo2mgJVfZM9GR8Ts+UuGK9Yn6N5nqmdJE1HOlAivZJ8n+uWEYVBYVaQ4LqYENPD9s/pAnyv2AoQHm8xf4N+s/O5pCUGwtfyQjOV62fUWFFecFQLHEthwUOh2cxQC7MTHpfe9PbVqGszOZHOxP2b8IvqxwIcTywPnymx/TG6oji2l/CvHcuBwMxF7hDghczvOeV+mfuxcywyzUDHZ3QgnVLa5eBc0zUNhlMW6AH+RQ31Uqkna5obwmkv27aaa3PCCWAJbyPv1F8vJa45Uq4M4WeA7HvTBLIIjfhdoIpyp7zrc0e7N1irV252Ng/22l8iyVTBK36WIBsVeTVcA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=95PsvAmeP66izDrqOuCBE2Q9rk6iqZqhlUDjN1UpJ/I=;
 b=kxofX+uLlwRSG0c8Gpfr/k0NVH9UG9vTY0STotr+KJ1YIg2CRTaeZj3SlMZcasx1VDgsfeHaTdMXHiqt14Ft/sBXWgXonRBwMqTHx76PQlqL9lHX/H3u9Re4J5oxdPTtSPIS1/cscc+fHZHtQVRuQHab1wbB7p9yUP07wslK2SgIUTKQlyV8wK9lN1BDR2fthtn36A1Fz4SF6nrFUf8mFsw/auQ3KRMq2f/KU0fjD3Inqo3Wh8updrhYn083WSBXeL6Iv67JxEuOwPZTKcxNQgRQq/g5PkgXCdH0gq1GRqurrApYZp46kTdOaqIJg86TSQXeBaGlDXUfvo2DVrnrrw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=95PsvAmeP66izDrqOuCBE2Q9rk6iqZqhlUDjN1UpJ/I=;
 b=sLd7ZvkQ5UL8DYAmyEkK38Ni4NOAntLUre5OdgKVQyzCou/oPp03Jo6evoDKC8mS9xaeOhUQ+WH+uF6LE869GNVjUGiOGaE23XAE9Jv1RS0pF8CrbZmunSonbqcIT3GRBie/sbnJityxwodtEPWFSQdxuuRxgvTNXOLaSCPgqdM=
Date: Wed, 2 Feb 2022 11:34:55 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"julien@xen.org" <julien@xen.org>, "sstabellini@kernel.org"
	<sstabellini@kernel.org>, Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Artem Mygaiev <Artem_Mygaiev@epam.com>,
	"jbeulich@suse.com" <jbeulich@suse.com>, "andrew.cooper3@citrix.com"
	<andrew.cooper3@citrix.com>, "george.dunlap@citrix.com"
	<george.dunlap@citrix.com>, "paul@xen.org" <paul@xen.org>, Bertrand Marquis
	<bertrand.marquis@arm.com>, Rahul Singh <rahul.singh@arm.com>
Subject: Re: [PATCH v5 08/14] vpci/header: program p2m with guest BAR view
Message-ID: <YfpeT+VMWiklDWGf@Air-de-Roger>
References: <20211125110251.2877218-1-andr2000@gmail.com>
 <20211125110251.2877218-9-andr2000@gmail.com> <Yd/9W7GFO51GE0ch@Air-de-Roger>
 <37c2374d-c0f7-23b6-d2f8-e94d1348807c@epam.com>
 <2282e7c5-ba1b-e2a2-af4a-84a894211870@epam.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <2282e7c5-ba1b-e2a2-af4a-84a894211870@epam.com>
X-ClientProxiedBy: LO3P265CA0012.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:bb::17) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5eb340f5-6110-4732-15bb-08d9e637aa94
X-MS-TrafficTypeDiagnostic: SN6PR03MB4111:EE_
X-Microsoft-Antispam-PRVS: <SN6PR03MB41113DCFF7448DF1810F5A318F279@SN6PR03MB4111.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:425;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 03L4jZRaFpkQkO9s2oRsBLdzhDs3cF4rkwXlUm3vR3g62lRbTHVJUqepHLGKcy5ncQmKALSrKhDZ4gMdLxPICj1wW0PwchGjPxy1olFMfmh0PTgNHQWkXbkJNYRJJmdH6j7yEHzkYO+8/kOC+PqQLTykRyx9ZIKXzX4EOhD6ecTZW8DzgOZzorrhhlVlTGGfQsLXQbYaVBKCv3TdJ2oDUR1W2/gRhGe4GljfeEid0v8Tc8UH6lnBOKU9rQ/Pp9O6r8nOX/x+buQhgx+BLRUkFkSAB3roc+zTkyfT767Wsimmo6PYBq4a1NA25dryUtt3sabIZS3yZQKpNTBT6j2X+c4QnqPdUCUaQjknd7Fq44MLutw1moklD6SUKMC5uk6fcl/phtHGkegoJoP2rxYbxZAKhdrSF2BBRtyCCRcfK9m3glG9MrA3YoYgHpA7zcwAFsu2guV0uXKXJLEVJF1/XuaL/YQlBodZA6MiCiFNiAlOsONG2a1uSFttmVXVUDT1YBM3QbYqix+K+rjNdG693Clhyhz9L5teS0O91RtI6RDEzRpEkuKaV+gEW4SNBg35ytAOExhfCi7yniutWnZs4ou0BKm+e8Hbxt1Fvs2JRqR51XYueS/kSlDueDzgjSX/bMgajaOptsRDHp0MMYZ9tlZRFFMZ8KNven9Fm20QIVO3c81JtkBe7fRn/ZQFOZjnaVXnFrMq4Xa8t8FPJCQA9g==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(186003)(54906003)(85182001)(6916009)(26005)(86362001)(5660300002)(8936002)(7416002)(2906002)(316002)(6666004)(38100700002)(66946007)(66556008)(6506007)(33716001)(9686003)(82960400001)(6486002)(8676002)(66476007)(4326008)(6512007)(508600001)(67856001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cTd2SzViTlNJTWlkRFlLejNoNTg0WEJyclh3Tkw3MnlHRm14UTBRQXdnb016?=
 =?utf-8?B?Tm81V2o5blFUMitqcTV4aUdHL2RESXNtRDFEVDZ3MnJQSTdnNVVPOWpWeFBr?=
 =?utf-8?B?ekZ5bXJMTjVvVjFsNHF4VXNLaEJjdzVmNi9lTFBwV0ZQWGtjYWlCbmtvcVEr?=
 =?utf-8?B?TU9OakpKUkp5cm42ZFoxakw3d3JuRDdkMWt2K3podzdZUFJlYjVoK094T2l1?=
 =?utf-8?B?L3dOWjlPSXdpRFBIbzZYQVZMKzdhN1dFcVp1OUVQY0RHSW1pb0p0enJPMFpZ?=
 =?utf-8?B?d1p4NHIxdWN0eXRqZisrclV4VDQyV2dwRVRqUm1aV1owY2VwS1B4NGRJbFRr?=
 =?utf-8?B?NFcwWmZXbFlLQk9ISlZWMERYLzBYUlNlaVFkTWlPK3hCQmU5TzFvQkxiZ3V1?=
 =?utf-8?B?K250bzdqMkNjQkhBTVBQNko0UW5neVo1V095S1E3aUhrTW4zaS9wS2pYZngz?=
 =?utf-8?B?aW9Uei9uV2hjR25GT1ZsTzBEL0d5bGI2aW8vOVJ6d1lKNFY0S2dYSnROcXBi?=
 =?utf-8?B?dkV4Y1pyR0R5Nk1sYkVBYldQZXpuT0lRZ0RtMW9OT0ZHZEp1MGlvVXlJRVRn?=
 =?utf-8?B?SE1XKzhQM29FUjJPL1NETVRhSGxMTW81T0FMWUxoVHFzOWpmR1hSWjBPNUZu?=
 =?utf-8?B?emh6TlJ0YTNDYkJrdHFQWWMvVzE4MHNQTTJXc3hVOWhRaTZJK2ZNSS9tWHEr?=
 =?utf-8?B?L0RPN01pNFB0QytzckZUZm1TWVROVjVGRFMrRHZPWUdSOWVCYTZjWmlrR2ho?=
 =?utf-8?B?eUttdGlySGhFdEY2VjZTeFpVQSs1S09nQmlBaGRIWU9wM0hPbEZySHphZ3Bj?=
 =?utf-8?B?SnpqUEZYejNLbjFIRkVCODgxb1l0N2c0MllMazltR0JFRktmK3h4Q01iSXdn?=
 =?utf-8?B?QVJRTDh4dlJhSzVCZDJpRkFsdWJ0K0VrbktUZG8waDY3blVvLzEvbUt3cW1h?=
 =?utf-8?B?RE1yWHZlRGErWlZHdmplaDRRakNJUjNhbWNORUdrQ0NGRng3ckpEQlE2b25D?=
 =?utf-8?B?ZnVleVhKQlMraUIxaW9DblVvaFhLa1BlV2EvU2QrSXFWNEZxZ2Vrdm1Wai9L?=
 =?utf-8?B?RmNLM3EzV09OMXcyenZDMXR4TStvcG8xcFdnM0JxcDJPWHgrS0pYbitWVmF1?=
 =?utf-8?B?eUl0WU91QWpISkRGMkxGVEhxblplOXhCamJsWHRvYzNCUHJUZGlJakNpT2J4?=
 =?utf-8?B?WkZxYkNmT05TMlFYOUVwR2FFUHpjQStUemM5aXY0SlNzd0R0L0xPOXlhSTZs?=
 =?utf-8?B?OStLQUxNZE5aQm81LzY3TGNSMXFiQktHWnpwTmIzZ2YyL0RiVlR6a2g1ditF?=
 =?utf-8?B?WWtjTnQrTVRndlNvaXpFenlRYU80eEdPT2JISW9rUE1KemNodklPVlNJWi9I?=
 =?utf-8?B?c29wQ2I1Rjd4Y1VvcWhLQ21NZkRybXQ3eExvWURidjE1NlM4eG94eXNVRERM?=
 =?utf-8?B?MFdxM1lOZkxiS2dEd2R0eCt6NGZpODBoaFVIVXBTaSt2UytDWG5Cckx1c1Nx?=
 =?utf-8?B?bXhpdUw3WDlKK0NxejBXRXNqVDlJcGFzT0ltSm5nZTF3eGtjV3IzQW9oTFNt?=
 =?utf-8?B?MVZqY2EwZWhjQkVWSTB6STh1VGdaS2VvdU9WSmNrNkJFRmcvem5VMnVHUzM4?=
 =?utf-8?B?c1pCbGthOUxSMlpvczlqQUJISWI5YURHUFY5VVkrSGFDejk1NGtQbmM4VTc3?=
 =?utf-8?B?eGJRamtjK3lDUXkyOHJZS2Z1TkFiRGRJTGpYQ29kU2JnaGNRSVE1bVFrcUxF?=
 =?utf-8?B?NmxzNksrUW4zS2trS3p0TGcrQ3k1djQxbmZqZ0NscStUYktBTjh1ck9jREFv?=
 =?utf-8?B?Q1dLWlJHQnYyYUp4eWUyQ3VybVh2Y3dNTXo0ekZSbEErNlk2eGNIbCtraXg2?=
 =?utf-8?B?aE1pWTR5Ukl4VHhKVUtVVUpLN2l2aTJ6VXdkZ05hNzRaZXhqb2JHOFFuWFN1?=
 =?utf-8?B?Y2Zza09oUFY1c1gzbTdaMS9rWFRuL2FpbzhFTFBycXFPdTNBSkQ2a3BIRlpR?=
 =?utf-8?B?TE1nVlYwaFRLOUhIYWdYZkUvL1Vvekc2QnJqUnBpNE03MGJDSlpPYlcrYjlJ?=
 =?utf-8?B?MjgxV09IS05aemFBVkpRckJjOExSWTZEbjJsazlxZ3NKWW5QaWZhMDR5Z0Yv?=
 =?utf-8?B?cDA0dVJseDVNRTFGVlo2UzNkRFZadFhnZ3d3cHhkRFRVdjA4UHRVZ2pxZ0Jr?=
 =?utf-8?Q?dZHDRJcVD+EwaKuAdGGSRIQ=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5eb340f5-6110-4732-15bb-08d9e637aa94
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2022 10:35:01.1087
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zddPJGIvOnICywMS1Ycg0b8QM6M3u0V9ougncLQclUgZhYUdd78tG8hXkdGv6BFajO+yXa8Na5QrA3T2Nk+g2w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR03MB4111
X-OriginatorOrg: citrix.com

On Wed, Feb 02, 2022 at 09:46:21AM +0000, Oleksandr Andrushchenko wrote:
> 
> >>> +        gdprintk(XENLOG_G_DEBUG,
> >>> +                 "%smap [%lx, %lx] -> %#"PRI_gfn" for %pd\n",
> >>> +                 map->map ? "" : "un", s, e, gfn_x(start_gfn),
> >>> +                 map->d);
> >> That's too chatty IMO, I could be fine with printing something along
> >> this lines from modify_bars, but not here because that function can be
> >> preempted and called multiple times.
> > Ok, will move to modify_bars as these prints are really helpful for debug
> I tried to implement the same, but now in init_bars:
> 
> diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c
> index 667c04cee3ae..92407e617609 100644
> --- a/xen/drivers/vpci/header.c
> +++ b/xen/drivers/vpci/header.c
> @@ -57,10 +57,6 @@ static int map_range(unsigned long s, unsigned long e, void *data,
>            */
>           start_gfn = gfn_add(start_gfn, s - mfn_x(start_mfn));
> 
> -        gdprintk(XENLOG_G_DEBUG,
> -                 "%smap [%lx, %lx] -> %#"PRI_gfn" for %pd\n",
> -                 map->map ? "" : "un", s, e, gfn_x(start_gfn),
> -                 map->d);
>           /*
>            * ARM TODOs:
>            * - On ARM whether the memory is prefetchable or not should be passed
> @@ -258,6 +254,28 @@ static void defer_map(struct domain *d, struct pci_dev *pdev,
>       raise_softirq(SCHEDULE_SOFTIRQ);
>   }
> 
> +static int print_range(unsigned long s, unsigned long e, void *data)
> +{
> +    const struct map_data *map = data;
> +
> +    for ( ; ; )
> +    {
> +        gfn_t start_gfn = _gfn(PFN_DOWN(is_hardware_domain(map->d)
> +                                        ? map->bar->addr
> +                                        : map->bar->guest_reg));
> +        mfn_t start_mfn = _mfn(PFN_DOWN(map->bar->addr));
> +
> +        start_gfn = gfn_add(start_gfn, s - mfn_x(start_mfn));
> +
> +        gdprintk(XENLOG_G_DEBUG,
> +                 "%smap [%lx, %lx] -> %#"PRI_gfn" for %pd\n",
> +                 map->map ? "" : "un", s, e, gfn_x(start_gfn),
> +                 map->d);
> +    }

This is an infinite loop AFAICT. Why do you need the for for?

> +
> +    return 0;
> +}
> +
>   static int modify_bars(const struct pci_dev *pdev, uint16_t cmd, bool rom_only)
>   {
>       struct vpci_header *header = &pdev->vpci->header;
> @@ -423,7 +441,25 @@ static int modify_bars(const struct pci_dev *pdev, uint16_t cmd, bool rom_only)
>       if ( !map_pending )
>           pci_conf_write16(pdev->sbdf, PCI_COMMAND, cmd);
>       else
> +    {
> +        struct map_data data = {
> +            .d = pdev->domain,
> +            .map = cmd & PCI_COMMAND_MEMORY,
> +        };
> +
> +        for ( i = 0; i < ARRAY_SIZE(header->bars); i++ )
> +        {
> +            const struct vpci_bar *bar = &header->bars[i];
> +
> +            if ( rangeset_is_empty(bar->mem) )
> +                continue;
> +
> +            data.bar = bar;
> +            rc = rangeset_report_ranges(bar->mem, 0, ~0ul, print_range, &data);

Since this is per-BAR we should also print that information and the
SBDF of the device, ie:

%pd SBDF: (ROM)BAR%u %map [%lx, %lx] -> ...

> +        }
> +
>           defer_map(dev->domain, dev, cmd, rom_only);
> +    }
> 
>       return 0;
> 
> 
> To me, to implement a single DEBUG print, it is a bit an overkill.
> I do understand your concerns that "that function can be
> preempted and called multiple times", but taking look at the code
> above I think we can accept that for DEBUG builds.

It might be better if you print the per BAR positions at the top of
modify_bars, where each BAR is added to the rangeset? Or do you care
about reporting the holes also?

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Feb 02 10:44:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 10:44:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264041.456988 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFD7m-0002eG-1b; Wed, 02 Feb 2022 10:44:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264041.456988; Wed, 02 Feb 2022 10:44:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFD7l-0002e9-Ud; Wed, 02 Feb 2022 10:44:29 +0000
Received: by outflank-mailman (input) for mailman id 264041;
 Wed, 02 Feb 2022 10:44:29 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1p3Q=SR=epam.com=prvs=40324c57ab=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nFD7k-0002e3-KJ
 for xen-devel@lists.xenproject.org; Wed, 02 Feb 2022 10:44:28 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 15a446fc-8415-11ec-8f75-fffcc8bd4f1a;
 Wed, 02 Feb 2022 11:44:24 +0100 (CET)
Received: from pps.filterd (m0174680.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 212AdEk4009771;
 Wed, 2 Feb 2022 10:44:18 GMT
Received: from eur04-vi1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2056.outbound.protection.outlook.com [104.47.14.56])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3dyrctr0x6-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 02 Feb 2022 10:44:18 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by PR3PR03MB6506.eurprd03.prod.outlook.com (2603:10a6:102:5f::6) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Wed, 2 Feb
 2022 10:44:14 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6%3]) with mapi id 15.20.4951.012; Wed, 2 Feb 2022
 10:44:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 15a446fc-8415-11ec-8f75-fffcc8bd4f1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=al0qtxIpIsOnqt8kHuQ7h5IiUMIMky2axFWYHvQ/+jkI2xzvpBqXtcj1e3EeS158OW5IKTHf16ML4FuzKnRXwBdIiULV9PGSZaXvtcZNJ/wXIdjGPCswOB6/LZyYAUyF5Wi5Id2QFFXRDke0TIKAjRqwwP/pEqKLii/x0fF9BycwbTwWxwNE6T1uEf2xPmOEGfUxzDKUk2HkIUNCjv6WrKFTeVF3JQBQYbPQo6d80LAy+NgvR4Y1Zxv9WzXflWO7PFSEzFXQ3JM8KLhILPQsmRofCMMsBnvnf7/+En2IZVx6if0fLNUIfpSLC5mJQQ/PG+JWZFsvMMpS+W4Cz2NgTw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=YFCmh+ZeVUGVjX0A9gmlwS/HRScuGSTWJcBrgJK92js=;
 b=f+7Q1XjNMl23IVGhm5ZTYmJkE1n25xDoETZ2DHy2I41dZjFOGC4iLo6PqlPAXQMqpecJ/WNQRuYkIEQBYampXfWqTsntlvUz8wBS6DljR2itJwcmZdpDGoUq2/JAl5Y1VK3FUq8unYz3y9Uds5LEGt2nhbLl0ZtIxprE8GHZ/e7vhkVjQmotv7C7uV9zx/geNwOgtodzGhDS3ycs+JXJ5h8P5NUUiryxPhm5+rF5vaHI2cSetzC0+tchjOaYPlR3ezk4UlPxHDknBHqzI++8KcWyrOkFm3RNGqDYJ9rPUQ4D8JTfhspPxNRime/imjyZeT4z2h3fpGgg0e4/+25oDA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=YFCmh+ZeVUGVjX0A9gmlwS/HRScuGSTWJcBrgJK92js=;
 b=YbOzN6L7+gizx4MnFqLP+nlKx9ViribtQFixSqgHwmZbuU1YZYDtH2QXcnC2NlSAdJ32LRtPjgIQ7HPQdWuYISPVfZvIiPJx+Q4lMa3O+xW4Jux96/k1kq0yvsInAu9rrnaBJkNSDrWWIPzgK4lBZqMSudN8tstlWv+4V5nSVZ9xAzXOTw+TD7PXaN+M8oP4rlSOM2TMGFuPDkeTTkRZJihbykkOle7d6Qo8UEC1zGTkLKWh5Q3p50eEvk5pfW6HgGGiP/HEUEZFdXQzRwSoBMatBBMzSsIgfMzczLkGPZsS4Ont6tdlhUu5ieXwLzOQrl9n2eWjdL1hgZw97aQjPg==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "jbeulich@suse.com" <jbeulich@suse.com>,
        "andrew.cooper3@citrix.com"
	<andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com"
	<george.dunlap@citrix.com>,
        "paul@xen.org" <paul@xen.org>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>,
        Rahul Singh <rahul.singh@arm.com>,
        Oleksandr
 Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v5 08/14] vpci/header: program p2m with guest BAR view
Thread-Topic: [PATCH v5 08/14] vpci/header: program p2m with guest BAR view
Thread-Index: AQHX4ewInH3i1A85zUqSOqe7J03BoaxhCwuAgB9Nb4CAABckAIAADZOAgAACmgA=
Date: Wed, 2 Feb 2022 10:44:14 +0000
Message-ID: <7d4c128d-f6f0-8dca-8ab4-6138ed6cd61d@epam.com>
References: <20211125110251.2877218-1-andr2000@gmail.com>
 <20211125110251.2877218-9-andr2000@gmail.com> <Yd/9W7GFO51GE0ch@Air-de-Roger>
 <37c2374d-c0f7-23b6-d2f8-e94d1348807c@epam.com>
 <2282e7c5-ba1b-e2a2-af4a-84a894211870@epam.com>
 <YfpeT+VMWiklDWGf@Air-de-Roger>
In-Reply-To: <YfpeT+VMWiklDWGf@Air-de-Roger>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 4ccc7837-6c43-46c9-0db7-08d9e638f4cc
x-ms-traffictypediagnostic: PR3PR03MB6506:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <PR3PR03MB6506D6D844B376F21B9DAD46E7279@PR3PR03MB6506.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:1201;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 NqdyR44nZsI46ThYL4FgqofC6D9yiJKr7EjjVIB/wgbK409zXf0jMpOM9f+6npnO/Ecz25CUlUR9dFDOwn0ILHBUWaHFt2iZZT21mFlA+6vsIcoMa0Q7zU0pu/ZXFhkG1EqY4h0BgjEvbgl66eboihntKf7OxdDa7ZWfMIumCPvONFmpoj2h3CrgBrgbiwi01PMfIELXIf6sYQA1SuyvWFDH0rTrr0giOQPRkBODIYgagYGbKKhsvdgLUCcOZTA/KcCgxyRbMdNb1xB9j5k3U9LNVYN9GbmK9mrRwmZA1vXRwgVhQTjowJb6DFR+4tsFzDIz0+GdqDPiYioJYOy5n5ykfbQxs6a2N+JjtqCYoG3nl2EjybQqJ5b+tt9X0/t4kZ66hIZCQMDGzy8V4127dTRGyCQMcU/syqEWHc9aPxN1NDNUh5pX2ckfZz/vICiwNXqJNEcuRli9OhnwZu0wM7oR+PVfPUBO2k6z4YVTPJSiUil6jHndtGm0qEXoGndPUbzLih6DrEY/3KzpXFLrGZfwakDh3iBFJ8zAHzndbIBtX3r072OYVtp5Tu5Q55ggW1JnGh7HomzOtrqJ4LmL1ECZtYQsF+z4jtU30Ob5o1U012qdfpr/bKowjXDTdKplnep7t9LgA6wktXP4TEAw11XLS1aISxWR3f9i33pJ6fiQ7h+PumwZAcP+G8Xgl+z3TWAy63w2KfQCKTwxT/lUNuHNB/CylOOz7edbqtolGNj5lY1pO8215Tb9P7JNy8S7
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(4326008)(8676002)(66556008)(66476007)(66446008)(107886003)(2906002)(6512007)(64756008)(53546011)(6486002)(91956017)(26005)(186003)(122000001)(86362001)(31696002)(38100700002)(36756003)(2616005)(8936002)(38070700005)(31686004)(83380400001)(54906003)(6916009)(508600001)(66946007)(316002)(76116006)(6506007)(71200400001)(7416002)(5660300002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?STdvaVlhc0trazUreEx1Qi9wMmFBYjJFdXFDbVVDa0VhRTRUb2dMTXQrTTgx?=
 =?utf-8?B?S1dpOE52Zjd2NEJscE4xcmk0dkFsYVMza0NXRHNSa2Y5K3NSUFVXWFY1WW9o?=
 =?utf-8?B?aGNrVWF6Y0lGKzBCQmdsUzBLS1lBOEd3bUdTY2ZCNjZ4TzVVMm4xNnRkRGE3?=
 =?utf-8?B?dVkxalRIc1haVCtNME9hbldpT2NBVllZOVlxV0IyMVU5MUpQRDBTYWw3ellG?=
 =?utf-8?B?bTBwbmNPZW1LbUxuZGlBSm8vem80cU5nbTBwYWZhOGRFWFNkZHFlVzVRdlRO?=
 =?utf-8?B?TnZaWGZSQllIUlBCN0Jna1psenZXM0RDYTdiN2h5WFBZQ3lmWFkzKzZ3MGJ0?=
 =?utf-8?B?OUpDc21iVlRqN1RMMy81WElXdlFvVFJ5NGVtampDWFV6ZFVSa0ZJUVo4dU9J?=
 =?utf-8?B?cFhlSzlSZm5TQkVCTXZldWZwclhvVk1oQjFaZ2M2TTk5bVdFd0gxZlF3bHJQ?=
 =?utf-8?B?ZzAySUt3NEozNnBzZUhtYXJNRVVidmdQeEsyWFNhRXdHTG1qUlJGZnFsY0xC?=
 =?utf-8?B?U05OdEdnWCtnN1hqQVJiTkMrZHQ2dVYzR3JlcElpL1Nlb3ZobGNMcmxQL2Ix?=
 =?utf-8?B?QkFKNlhqODF0NjZzb2lKRE14NE0xbDkzVW1rbGN3MEJBdnB4YzJyS3lDRlM4?=
 =?utf-8?B?SXRJYm13L1g1OU5aM1NkTU5EZEpJdk9SVS9LS29mNUxOUklkL0ljZHdsTTNB?=
 =?utf-8?B?bnZkcmFteEYxWEVuSmFsa2grWldTWVBwT1F4c2RFZzZKbUx0aWtaN3FBdFlu?=
 =?utf-8?B?ZVUvSUJRU1BJVDg3MHRkWW95dCt2bk40WExmMG1uanBzMEV6Y2cyVGR2TEI4?=
 =?utf-8?B?ZzVBZHd1R2FIWFA5RGJTQmhOdHpRN1lvWUFDeGdSYnRTdm54VmJRMXFmM3Ja?=
 =?utf-8?B?ZHpCdTJRRk5jZ3BqUDBXcFhQb0lkRjduOU1mM3dFS2hHYjFES0JtZmYxMEd0?=
 =?utf-8?B?dXl4bXBZRE1Lbnc1Z212R0pETVJYUHhrN3NDbkE1Yk00L3Vyd252VnNrQVVq?=
 =?utf-8?B?N1RmZVR4dCt4Y24xQWRSQjAzMnljR2lJdXYwK3NOUHBaSDNKek1CQ2ZnOC9a?=
 =?utf-8?B?N0t3VEUyWnd3WW9DUTlzM2dqeXZKbmhvSVp3cS82TzYvWHdpMGlvMWVKaXV6?=
 =?utf-8?B?V0lVVFAxWm5Zc3ViN0Z0ZVpBMzh0eUhOV0VRNWdmWWdwOW9GTzk4UVpmSTgr?=
 =?utf-8?B?RXgyOUpyOG91ZmkrZHI3QjgzUllZUVEvdEdpNksvM25ZU3JoSGtndHRibjFp?=
 =?utf-8?B?MGhjTEF1aEVNaU4weS96Z3JXU0ZFS0QycGtRRnNwZTM1em1PQnc3eURmUzdv?=
 =?utf-8?B?eit0Z0RxZ1pKUlp4SFJmMVdUbDk5bmhReXBCd0VvSkg2WjE5RjRvVlNOalhy?=
 =?utf-8?B?VjZsTXRPVFhsWndFNFNZQWJuK3dONVhkVm1EZExpOFpLRkc1RUNJa3huOTFF?=
 =?utf-8?B?NVRNWUQ1dVZpUVlRbE5OVVRCRXd6VzhKMzY4VkhQand2MjFBVGxDMmV6OXNN?=
 =?utf-8?B?V25VUEk4V0UyaVo5V1NDR3g0QmpSM2VETGtmRzNBa0U0VFdUOFAxeTZyUHR5?=
 =?utf-8?B?WnZSN2k3ZU4yOEF5MFBmQmVQODRhUUwwKzlNL0pqZ2pCVURCVDdsclA1MEpU?=
 =?utf-8?B?eS9YNXJYTFkxd0w1cmxZY3N3ZnYrYUwwVCtVK1FxajZCYnJXVDFJci9pbG85?=
 =?utf-8?B?ell5cTJWek8zSjVocHBlZlNLZk5xM0lBaXdXYU1wRUs1R0VTdStoZjNIMFRj?=
 =?utf-8?B?a1JqNHB2OHk2akg1WlVxZHNFRi8rQXp6eFdIUjRnckZqVzRFNFdiQjc5Q0hQ?=
 =?utf-8?B?ZW1Wc2MwUks2c0FBQytXc0hNWUxHUmRMSnhTUnJsMTVsd3FxdFhsSDBiTEly?=
 =?utf-8?B?VHorUzJ6SitTdTZ5YU04UlVIbXlhMXNqRTY1d1NjTUpzYVJTQ1MxWGR5bG4y?=
 =?utf-8?B?RVNtcTlnb2lFMmpZZGg0NDg5MVlKKzJhYzlQUjJCdGI1WTQyeDkyQW5EUTlt?=
 =?utf-8?B?aUIxYlhpLzRDTVE0eXJjS21vcTNIZ1dabllWa3Y0cTFIMStVQnBMbEkvUnZM?=
 =?utf-8?B?Wm1FMmRtcUE2emZLVzhjRlFEcEEzS3VaeDhXdGVoeS9mdVJMZFNXcGgrSWdp?=
 =?utf-8?B?Z0pJOEY4TVdkK0VlM2tkNWUvNXZCeHZ1ODY2SjRBT2poRkYyS016RS9INGxv?=
 =?utf-8?B?UTlROXkvNXVxcndUMWo1bWtpcWJyb0Y5Z2xlY0ZpZ0ppeUFHR1l2a29zRm9i?=
 =?utf-8?B?Q2c4R29vb2o1VWxVYllzMEVmREZjVExjT3VuMFN4VFBrZWMrNkRhbzRRNElK?=
 =?utf-8?B?WHI4N2ZFSXVVdmNzaWFvbnRkQ0hzRDJWTEFJOFZIVHRsOVNwNGF4dz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <9372CB71C728F34C9D89219539F8C99C@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4ccc7837-6c43-46c9-0db7-08d9e638f4cc
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Feb 2022 10:44:14.8269
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Y62sGD2+VLPyNedCE5Mi6LED35t4JP654NpiRaSIivimLb07draGRGVjZBsavzNWZ+TPQL3TM3cuBdcX/kFuiKnik8q9O613SOxqyPDLzBjlCakKiyzqva4HYGo5A2V9
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR03MB6506
X-Proofpoint-ORIG-GUID: Yf-SpjmATLgiBHoTv9qnafYjU_qHQy-Q
X-Proofpoint-GUID: Yf-SpjmATLgiBHoTv9qnafYjU_qHQy-Q
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-02_04,2022-02-01_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0
 bulkscore=0 impostorscore=0 mlxscore=0 suspectscore=0 spamscore=0
 adultscore=0 lowpriorityscore=0 mlxlogscore=999 malwarescore=0
 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202020057

DQpPbiAwMi4wMi4yMiAxMjozNCwgUm9nZXIgUGF1IE1vbm7DqSB3cm90ZToNCj4gT24gV2VkLCBG
ZWIgMDIsIDIwMjIgYXQgMDk6NDY6MjFBTSArMDAwMCwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28g
d3JvdGU6DQo+Pj4+PiArICAgICAgICBnZHByaW50ayhYRU5MT0dfR19ERUJVRywNCj4+Pj4+ICsg
ICAgICAgICAgICAgICAgICIlc21hcCBbJWx4LCAlbHhdIC0+ICUjIlBSSV9nZm4iIGZvciAlcGRc
biIsDQo+Pj4+PiArICAgICAgICAgICAgICAgICBtYXAtPm1hcCA/ICIiIDogInVuIiwgcywgZSwg
Z2ZuX3goc3RhcnRfZ2ZuKSwNCj4+Pj4+ICsgICAgICAgICAgICAgICAgIG1hcC0+ZCk7DQo+Pj4+
IFRoYXQncyB0b28gY2hhdHR5IElNTywgSSBjb3VsZCBiZSBmaW5lIHdpdGggcHJpbnRpbmcgc29t
ZXRoaW5nIGFsb25nDQo+Pj4+IHRoaXMgbGluZXMgZnJvbSBtb2RpZnlfYmFycywgYnV0IG5vdCBo
ZXJlIGJlY2F1c2UgdGhhdCBmdW5jdGlvbiBjYW4gYmUNCj4+Pj4gcHJlZW1wdGVkIGFuZCBjYWxs
ZWQgbXVsdGlwbGUgdGltZXMuDQo+Pj4gT2ssIHdpbGwgbW92ZSB0byBtb2RpZnlfYmFycyBhcyB0
aGVzZSBwcmludHMgYXJlIHJlYWxseSBoZWxwZnVsIGZvciBkZWJ1Zw0KPj4gSSB0cmllZCB0byBp
bXBsZW1lbnQgdGhlIHNhbWUsIGJ1dCBub3cgaW4gaW5pdF9iYXJzOg0KPj4NCj4+IGRpZmYgLS1n
aXQgYS94ZW4vZHJpdmVycy92cGNpL2hlYWRlci5jIGIveGVuL2RyaXZlcnMvdnBjaS9oZWFkZXIu
Yw0KPj4gaW5kZXggNjY3YzA0Y2VlM2FlLi45MjQwN2U2MTc2MDkgMTAwNjQ0DQo+PiAtLS0gYS94
ZW4vZHJpdmVycy92cGNpL2hlYWRlci5jDQo+PiArKysgYi94ZW4vZHJpdmVycy92cGNpL2hlYWRl
ci5jDQo+PiBAQCAtNTcsMTAgKzU3LDYgQEAgc3RhdGljIGludCBtYXBfcmFuZ2UodW5zaWduZWQg
bG9uZyBzLCB1bnNpZ25lZCBsb25nIGUsIHZvaWQgKmRhdGEsDQo+PiAgIMKgwqDCoMKgwqDCoMKg
wqDCoCAqLw0KPj4gICDCoMKgwqDCoMKgwqDCoMKgIHN0YXJ0X2dmbiA9IGdmbl9hZGQoc3RhcnRf
Z2ZuLCBzIC0gbWZuX3goc3RhcnRfbWZuKSk7DQo+Pg0KPj4gLcKgwqDCoMKgwqDCoMKgIGdkcHJp
bnRrKFhFTkxPR19HX0RFQlVHLA0KPj4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
ICIlc21hcCBbJWx4LCAlbHhdIC0+ICUjIlBSSV9nZm4iIGZvciAlcGRcbiIsDQo+PiAtwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgbWFwLT5tYXAgPyAiIiA6ICJ1biIsIHMsIGUsIGdm
bl94KHN0YXJ0X2dmbiksDQo+PiAtwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgbWFw
LT5kKTsNCj4+ICAgwqDCoMKgwqDCoMKgwqDCoCAvKg0KPj4gICDCoMKgwqDCoMKgwqDCoMKgwqAg
KiBBUk0gVE9ET3M6DQo+PiAgIMKgwqDCoMKgwqDCoMKgwqDCoCAqIC0gT24gQVJNIHdoZXRoZXIg
dGhlIG1lbW9yeSBpcyBwcmVmZXRjaGFibGUgb3Igbm90IHNob3VsZCBiZSBwYXNzZWQNCj4+IEBA
IC0yNTgsNiArMjU0LDI4IEBAIHN0YXRpYyB2b2lkIGRlZmVyX21hcChzdHJ1Y3QgZG9tYWluICpk
LCBzdHJ1Y3QgcGNpX2RldiAqcGRldiwNCj4+ICAgwqDCoMKgwqAgcmFpc2Vfc29mdGlycShTQ0hF
RFVMRV9TT0ZUSVJRKTsNCj4+ICAgwqB9DQo+Pg0KPj4gK3N0YXRpYyBpbnQgcHJpbnRfcmFuZ2Uo
dW5zaWduZWQgbG9uZyBzLCB1bnNpZ25lZCBsb25nIGUsIHZvaWQgKmRhdGEpDQo+PiArew0KPj4g
K8KgwqDCoCBjb25zdCBzdHJ1Y3QgbWFwX2RhdGEgKm1hcCA9IGRhdGE7DQo+PiArDQo+PiArwqDC
oMKgIGZvciAoIDsgOyApDQo+PiArwqDCoMKgIHsNCj4+ICvCoMKgwqDCoMKgwqDCoCBnZm5fdCBz
dGFydF9nZm4gPSBfZ2ZuKFBGTl9ET1dOKGlzX2hhcmR3YXJlX2RvbWFpbihtYXAtPmQpDQo+PiAr
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgID8gbWFwLT5iYXItPmFkZHINCj4+ICvCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqAgOiBtYXAtPmJhci0+Z3Vlc3RfcmVnKSk7DQo+PiArwqDCoMKgwqDCoMKgwqAgbWZu
X3Qgc3RhcnRfbWZuID0gX21mbihQRk5fRE9XTihtYXAtPmJhci0+YWRkcikpOw0KPj4gKw0KPj4g
K8KgwqDCoMKgwqDCoMKgIHN0YXJ0X2dmbiA9IGdmbl9hZGQoc3RhcnRfZ2ZuLCBzIC0gbWZuX3go
c3RhcnRfbWZuKSk7DQo+PiArDQo+PiArwqDCoMKgwqDCoMKgwqAgZ2RwcmludGsoWEVOTE9HX0df
REVCVUcsDQo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgIiVzbWFwIFslbHgs
ICVseF0gLT4gJSMiUFJJX2dmbiIgZm9yICVwZFxuIiwNCj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoCBtYXAtPm1hcCA/ICIiIDogInVuIiwgcywgZSwgZ2ZuX3goc3RhcnRfZ2Zu
KSwNCj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBtYXAtPmQpOw0KPj4gK8Kg
wqDCoCB9DQo+IFRoaXMgaXMgYW4gaW5maW5pdGUgbG9vcCBBRkFJQ1QuIFdoeSBkbyB5b3UgbmVl
ZCB0aGUgZm9yIGZvcj8NCj4NCj4+ICsNCj4+ICvCoMKgwqAgcmV0dXJuIDA7DQo+PiArfQ0KPj4g
Kw0KPj4gICDCoHN0YXRpYyBpbnQgbW9kaWZ5X2JhcnMoY29uc3Qgc3RydWN0IHBjaV9kZXYgKnBk
ZXYsIHVpbnQxNl90IGNtZCwgYm9vbCByb21fb25seSkNCj4+ICAgwqB7DQo+PiAgIMKgwqDCoMKg
IHN0cnVjdCB2cGNpX2hlYWRlciAqaGVhZGVyID0gJnBkZXYtPnZwY2ktPmhlYWRlcjsNCj4+IEBA
IC00MjMsNyArNDQxLDI1IEBAIHN0YXRpYyBpbnQgbW9kaWZ5X2JhcnMoY29uc3Qgc3RydWN0IHBj
aV9kZXYgKnBkZXYsIHVpbnQxNl90IGNtZCwgYm9vbCByb21fb25seSkNCj4+ICAgwqDCoMKgwqAg
aWYgKCAhbWFwX3BlbmRpbmcgKQ0KPj4gICDCoMKgwqDCoMKgwqDCoMKgIHBjaV9jb25mX3dyaXRl
MTYocGRldi0+c2JkZiwgUENJX0NPTU1BTkQsIGNtZCk7DQo+PiAgIMKgwqDCoMKgIGVsc2UNCj4+
ICvCoMKgwqAgew0KPj4gK8KgwqDCoMKgwqDCoMKgIHN0cnVjdCBtYXBfZGF0YSBkYXRhID0gew0K
Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgLmQgPSBwZGV2LT5kb21haW4sDQo+PiArwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoCAubWFwID0gY21kICYgUENJX0NPTU1BTkRfTUVNT1JZLA0KPj4gK8Kg
wqDCoMKgwqDCoMKgIH07DQo+PiArDQo+PiArwqDCoMKgwqDCoMKgwqAgZm9yICggaSA9IDA7IGkg
PCBBUlJBWV9TSVpFKGhlYWRlci0+YmFycyk7IGkrKyApDQo+PiArwqDCoMKgwqDCoMKgwqAgew0K
Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgY29uc3Qgc3RydWN0IHZwY2lfYmFyICpiYXIgPSAm
aGVhZGVyLT5iYXJzW2ldOw0KPj4gKw0KPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgaWYgKCBy
YW5nZXNldF9pc19lbXB0eShiYXItPm1lbSkgKQ0KPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoCBjb250aW51ZTsNCj4+ICsNCj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGRhdGEu
YmFyID0gYmFyOw0KPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcmMgPSByYW5nZXNldF9yZXBv
cnRfcmFuZ2VzKGJhci0+bWVtLCAwLCB+MHVsLCBwcmludF9yYW5nZSwgJmRhdGEpOw0KPiBTaW5j
ZSB0aGlzIGlzIHBlci1CQVIgd2Ugc2hvdWxkIGFsc28gcHJpbnQgdGhhdCBpbmZvcm1hdGlvbiBh
bmQgdGhlDQo+IFNCREYgb2YgdGhlIGRldmljZSwgaWU6DQo+DQo+ICVwZCBTQkRGOiAoUk9NKUJB
UiV1ICVtYXAgWyVseCwgJWx4XSAtPiAuLi4NCj4NCj4+ICvCoMKgwqDCoMKgwqDCoCB9DQo+PiAr
DQo+PiAgIMKgwqDCoMKgwqDCoMKgwqAgZGVmZXJfbWFwKGRldi0+ZG9tYWluLCBkZXYsIGNtZCwg
cm9tX29ubHkpOw0KPj4gK8KgwqDCoCB9DQo+Pg0KPj4gICDCoMKgwqDCoCByZXR1cm4gMDsNCj4+
DQo+Pg0KPj4gVG8gbWUsIHRvIGltcGxlbWVudCBhIHNpbmdsZSBERUJVRyBwcmludCwgaXQgaXMg
YSBiaXQgYW4gb3ZlcmtpbGwuDQo+PiBJIGRvIHVuZGVyc3RhbmQgeW91ciBjb25jZXJucyB0aGF0
ICJ0aGF0IGZ1bmN0aW9uIGNhbiBiZQ0KPj4gcHJlZW1wdGVkIGFuZCBjYWxsZWQgbXVsdGlwbGUg
dGltZXMiLCBidXQgdGFraW5nIGxvb2sgYXQgdGhlIGNvZGUNCj4+IGFib3ZlIEkgdGhpbmsgd2Ug
Y2FuIGFjY2VwdCB0aGF0IGZvciBERUJVRyBidWlsZHMuDQo+IEl0IG1pZ2h0IGJlIGJldHRlciBp
ZiB5b3UgcHJpbnQgdGhlIHBlciBCQVIgcG9zaXRpb25zIGF0IHRoZSB0b3Agb2YNCj4gbW9kaWZ5
X2JhcnMsIHdoZXJlIGVhY2ggQkFSIGlzIGFkZGVkIHRvIHRoZSByYW5nZXNldD8gT3IgZG8geW91
IGNhcmUNCj4gYWJvdXQgcmVwb3J0aW5nIHRoZSBob2xlcyBhbHNvPw0KRmlyc3Qgb2YgYWxsIEkg
ZGlkbid0IHJ1biB0aGlzIGNvZGUsIHNvIGl0IGlzIGp1c3QgdG8gc2hvdyB0aGUgY29tcGxleGl0
eQ0KSWYgdGhlIGFwcHJvYWNoIGl0c2VsZiBpcyBvay4gSWYgaXQgaXMgdGhlbiBJJ2xsIGdldCBp
dCB3b3JraW5nOiBwbGVhc2UNCmRvIG5vdCByZXZpZXcgaXQgbGl0ZXJhbGx5IHlldC4NCg0KVGhl
IG9yaWdpbmFsIHByaW50IHdhcyB1c2VkIHRvIHNob3cgb25seSB0aG9zZSB7dW59bWFwcGluZ3Mg
dGhhdA0Kd2UgYWN0dWFsbHkgZG8sIG5vIGhvbGVzIGV0Yy4sIHNvIHdlIG5lZWQgdG8gcHJpbnQg
YXQgdGhlIGJvdHRvbSBvZg0KdGhlIGluaXRfYmFycywgZS5nLiB3aGVuIHRoZSByYW5nZXNldHMg
YXJlIGFsbCByZWFkeS4NCg0KQWdhaW4sIElNTywgYWRkaW5nIHN1Y2ggYSBiaWcgcGllY2Ugb2Yg
REVCVUcgY29kZSBpbnN0ZWFkIG9mDQpwcmludGluZyBhIHNpbmdsZSBERUJVRyBtZXNzYWdlIGNv
dWxkIGJlIGEgYml0IGV4cGFuc2l2ZS4NCkkgc3RpbGwgaGVhciB5b3VyIGNvbmNlcm5zIG9uICp3
aGVuKiBpdCBpcyBwcmludGVkLCBidXQgc3RpbGwgdGhpbmsgd2UgY2FuDQphbGxvdyB0aGF0Lg0K
Pg0KPiBUaGFua3MsIFJvZ2VyLg0KVGhhbmsgeW91LA0KT2xla3NhbmRy


From xen-devel-bounces@lists.xenproject.org Wed Feb 02 11:03:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 11:03:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264049.456999 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFDQ5-00054X-OV; Wed, 02 Feb 2022 11:03:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264049.456999; Wed, 02 Feb 2022 11:03:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFDQ5-00054Q-LP; Wed, 02 Feb 2022 11:03:25 +0000
Received: by outflank-mailman (input) for mailman id 264049;
 Wed, 02 Feb 2022 11:03:24 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1p3Q=SR=epam.com=prvs=40324c57ab=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nFDQ3-00054K-SK
 for xen-devel@lists.xenproject.org; Wed, 02 Feb 2022 11:03:23 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id bc1699d0-8417-11ec-8f75-fffcc8bd4f1a;
 Wed, 02 Feb 2022 12:03:22 +0100 (CET)
Received: from pps.filterd (m0174682.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 212Ap4Oh004245;
 Wed, 2 Feb 2022 11:03:17 GMT
Received: from eur05-am6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2104.outbound.protection.outlook.com [104.47.18.104])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3dyrjfg24k-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 02 Feb 2022 11:03:17 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AS8PR03MB7891.eurprd03.prod.outlook.com (2603:10a6:20b:422::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Wed, 2 Feb
 2022 11:03:14 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6%3]) with mapi id 15.20.4951.012; Wed, 2 Feb 2022
 11:03:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bc1699d0-8417-11ec-8f75-fffcc8bd4f1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XqPi1s5h+0F70yL5sHMFoljDbCSgKCtXVR40pwE8QCt0uMkKabFLwhwWh8QWszn/+3cY4QjnJaz6vUDZnxtm9F5psQG+jceqE4Bl7IqndiKZVz1c6W/X83AYpDcAVKRN2evhn/xajYBiXJKy8Vp3r/2S2nNu7AhdaCTEBWanzoqW+ISr1DdVuF9b88zgJTgrMSjBhQLcK7KxUkBQjs+O0sA9WrZ/lvvW8FA5Y27jxoHBKzs6GmgNXFcodohLUqEeoLs6om5YFL3webh8YTcb8aoWP3WVGyiVDgBml20gQDbzNS9UYi83V19JXnmbp+zdQJ3IfYaF9qEO85bZW7UgOg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=zCID1JbPiDqEq8PtEn9va1XZ14Alrt4jM3y//e+EYhc=;
 b=PKlnrZfMXggjCkTOosgG9mXx7tIl/GUBNpSFmQJVudeNQg9m5ILqHsmUntXNLlAlKEfKYeBOspzorrQPtdO5Ywf3VVInsftdyCXip5emN1oG4ljliYzKtD2/I577nhGGr+nxIBMYp06D3umLGA7b9HxkmIYQOB/fcpuXyxwLvE7FLI+RwmJLykId+0wB5Q6M6jxRonrQGgMh4rv0rDIx9NvrQhVbJ9JiTNBczsnvAMv1snrEANY4MC23GMdtDgaIE2fak2a/RGwYV2gl8AEKW/ishZ/MHeQd7FoQE6DVDATR3KwEBuAxSprNWKmUL8DgHrxWNLlFvwvpFLkNDZmPlg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=zCID1JbPiDqEq8PtEn9va1XZ14Alrt4jM3y//e+EYhc=;
 b=sXwaRJpxx06P7ljkHq/6F6rglfaz4u258KaV+FqHr86pwN3hbja6Gm7pIiDvbarzVwXLEJ//zws4jGFR/0h96Jn8zKG6z1dXTHWZ6m+SM1Cvy9uL6ecVh+zdgHyhRYIzct6KtSi6WZKblPqJR+40reCvI3Qvqvel/TWwYdd8E5M1UOLo/RvdDw3/BX0BgggA1dAfG9t6QEFFlE4QcW52jKGnhZ1AjjiOZnukmrMBqr+jwStCLcauyFH/DCdBEFPSbMY15hb7RH/9DwgTlWsx5MNTJl2RQz7IQjVET1CgGISJBavdcQ9Wgu4FtSY9pAazR9AfkLBpnRMtv1xjio74iQ==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>,
        =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?=
	<roger.pau@citrix.com>
CC: "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH 4/4] vpci: move lock outside of struct vpci
Thread-Topic: [PATCH 4/4] vpci: move lock outside of struct vpci
Thread-Index: AQHYF4hPRx/tX4vEOUaqhaVglKUz1ax//dWAgAAcC4A=
Date: Wed, 2 Feb 2022 11:03:14 +0000
Message-ID: <e19a0f7a-651e-09a6-c03d-ea5286fe03ba@epam.com>
References: <20220201162508.417008-1-andr2000@gmail.com>
 <20220201162508.417008-5-andr2000@gmail.com>
 <fc3df33c-d1e5-8c74-01e9-7ea7cea41521@suse.com>
In-Reply-To: <fc3df33c-d1e5-8c74-01e9-7ea7cea41521@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 5f01d493-f33d-43b3-b988-08d9e63b9bdc
x-ms-traffictypediagnostic: AS8PR03MB7891:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AS8PR03MB78915F08160E235977ECABE1E7279@AS8PR03MB7891.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 sj6+1ll06/0iKImsZffVyMUvj2weC5Oy2QWqMni4KyWH5w/UhaH0vuz269UtBhLFDrLuuX/bzCu9rwcLLzgew0puTttup8k5ZRp1QP/lshfkxxN0obsBROROHko3Xdbq027qHYXRKMxdB/iFwsEs1yiCcXG4EBpPbJE2H7fqI8WMYQckWgNsPdHhIxwe4/5rILAuWUqqNNnkuuc+6AcK9cybNmOgqgICa676zr2zPL2IflfLpwJmZCRBkQNctALTRoJUelEpUIHu78B3PeSceMu+NjYxrRo1wz0I5iMugwICQ5mD5hrfNhCF/TuoatER+jKZ9twI1NXE8FHFEK5Yxie6NAG3f0xo+SzdFNtG/S3DRWG2ZqblSSVAPReAnyZR5UJA/k+WZiby5DFBJysmVoWKZPWxeJZjB/3uQ0xbUfA/Mfn8YnvbdTxysZJJAP8EZ5bzxD3FwVNzq0hRokZNdfrrupHjqmxN9TVgWHQJW8qfE/39KNpeXRhxFVC6JXqXDUOrmbVO1KJOVYzMzM83rS/+I9ZXfzgQkAO5hsHwpYej0Q5CN/D0muqC7ToRZ5zoQPTYBqbe4x2zRWUTyWtp255TXhTbhhCjcioxr8YidiEcdNqRzTLhxIldjupnS6uweqgaCg27vWh7LTIDSGVN2Y4Z2O9qqXSSIMYUrXdeEpna8163QNpPrWr81iH5okJ3KQs0tdkJe3WwVum530WEoRQlENkAxuehQPH9Gka2bQJASIT42JBfcIEgt+iFUqIYdMxV/9aMIrL0rkNUEOzrKF+OlZhsIgXWtpqS4xgvB9rotpm+UjlaZIuPa3eFtc3j
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(83380400001)(186003)(26005)(4326008)(6506007)(8936002)(8676002)(66476007)(64756008)(66446008)(91956017)(71200400001)(66946007)(31696002)(76116006)(86362001)(6512007)(66556008)(7416002)(5660300002)(107886003)(53546011)(2906002)(36756003)(2616005)(122000001)(110136005)(508600001)(54906003)(316002)(38070700005)(966005)(38100700002)(6486002)(31686004)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?WTZMeEhsWXJWc3FqcnhxZEpYbWZ1ZnB4Wnc3VmdETlVqY0lzOUJvWVpkQzcx?=
 =?utf-8?B?aFUrSlJpZm5IQ1lFUEhjeWNncUU5MnF3cDlzQnNwKzZmSFIvRmlycjRGbTAw?=
 =?utf-8?B?bFJMM0kwUUM2WWdiUGw2QW5Qa08vRzFUNlp1RDQ3cm9QanBHTzVldHdHbGp3?=
 =?utf-8?B?RVZxRzFEZWFtL0FjVWRqaituRUl6b29TM3prQk5GK0I5WFFPQnBCNGxaeG1s?=
 =?utf-8?B?d3RmMUhxTmJlWlBGR1lmV28xY0t5SkpJYnlGUWJEd1JDaXphOG1EZVMwQng2?=
 =?utf-8?B?dFVuWGNDVUM1SlZLaEpjczNkeGJLa3BJY0VMUUxqTzNUS000cE8xYTd0UEV3?=
 =?utf-8?B?NVp5eTJWUElzdmZSb3lDMFFycExQZGg3ZS9JV0VnK3FPalRmNDJkWldRUFp3?=
 =?utf-8?B?WWlCbUhHRjRBdWxQYnZVM3VNTnRNcUNKbk82a3doZDVGY1RySXBnV1I4UVQr?=
 =?utf-8?B?WTZXNm5EY2tub2VhakZ4eWVtd0FDVEpVQXpFdDhsdnB5Zzd4MStTbCs5a1NI?=
 =?utf-8?B?VDlsTjRQOExYQXptWXNjaW8vUFh2Znk4UTFaTUR0b3FJclRld0xqWHgrV0tE?=
 =?utf-8?B?OVJBYjh6aTZoY3NSQy9oVHZIYjRGNWVQV0YvcHR2MU8xNXhhVFVtZEJRQjU4?=
 =?utf-8?B?M3V1WSt5cnVoOFNkZUZxTEZ1aFlUdGFNSkczYmo5bFNubDA2SXNEVVFTMUZ4?=
 =?utf-8?B?Z2VZUS9zbldta3NSTWhUMzRiYWdWYkU3WWhRRHYzL1JxWFh2eGVFR2dRL3h4?=
 =?utf-8?B?K0RrTEJ1V2dDR1BSQnd2WENoeE9jVlJvdzZoTHkrbVRPaDcwNWQxamNHaVFY?=
 =?utf-8?B?VVNMZjg0Ky9KLzY3U2pGTVFwRW5Fc0ZITmhtdlI1dTkvcHZKdkpSQXovazRa?=
 =?utf-8?B?R3hrZkdOdko4U3NmOFBEdytjZ0tIR1p0L3pCQWJ0bGtrQmE1YW83M1k1OWxz?=
 =?utf-8?B?U29WUGFnWHJFRk1zUDZKbnFaVFgxN3MzUmJPZzJqK0NydVQ2SHhJL1Bla3pk?=
 =?utf-8?B?ZzA0QzF1YlYxcmd0cmJQZXJ0VzRCT3NvMERJckMrRHpLRnVXY2JUUnZ5MzRs?=
 =?utf-8?B?WVBUVDFYQVg0MnhjOXlEWWg1dk9TaTNlYS9lMk1DNWE0aW12ZnJpSHlBZEZW?=
 =?utf-8?B?Wkl2VVNsU29hRXBBd09ncjE0WXhlenlDWWN3cldLUGJLOEJmSVZxdFRIZlVy?=
 =?utf-8?B?MHEvZHNQc0hyT1dzcXlkeWpjVFhsUS93VGJwaWxaVkVhN1FST28zY3Y1ME5O?=
 =?utf-8?B?MXV4Wnc4M3p3RWc3T3FkZVlNbUJ2RmJNN2JUQ0xYaVpkZEZLaHNXVmgvOHNY?=
 =?utf-8?B?RWs1U2JlUHc3aFVuYW9wY3Awc1dvVzZHcUdHYUttUHdqZ1M4ZmhGRHVzVXlH?=
 =?utf-8?B?TmphWnlBakptREJXb3dsS28yaTRLZmw3S0h1R1IzTEJPaDlSUEtWQmtpSXBl?=
 =?utf-8?B?VmgraEtteTJoU1plazVSQUNrcHBWUHFjTTIvaGR0aFBWUmp0eWxaZjVIT084?=
 =?utf-8?B?cU9XRkpxdjdkQUo3UEljbXMyc21sbjhoZlA2eXdwT3JPZ0lIRVRKWHFnUjk5?=
 =?utf-8?B?dmFxSUFHWkRLd1p6R0gweGQxVjVtNjdTNlpLbEZRT0IzcE5Fc0Y5VEtla2lV?=
 =?utf-8?B?S2laTmNRVGpaZDNnY0pJN1k2TUFFeVpkbkRBNDNhOGNmdWRwSFdNcGEyeW9Y?=
 =?utf-8?B?QjJPYitvS252Y1pDb2NtRHd4N1A5VHBadjJSeEhPRzFxUXdVOFVjM1lCcjEz?=
 =?utf-8?B?eEtLMkFLZkM2L28yNGNQTWY4K1JncU1KbWtNdUlDRjZ4Q29tK1RSc1FscFJ2?=
 =?utf-8?B?NHJMb2FWa2ZkNWNHckJpb2hBU3pEbjlaRHlGbmtxQkdZUEZGSkJaNS8rRlUy?=
 =?utf-8?B?dXFxUzY1RkRtdnBRMWxOelBocGdEY2MxUkFNZjkwcTNhVUVRU2szQzlRRHRq?=
 =?utf-8?B?RHNLNGx0UlRCMGNpTmhrRW5QWGpuWk5IbGQvZ05IM3I1eUpYSm9Za1VGYWFU?=
 =?utf-8?B?Z2lGSnYzQ2tvYllsbUNnSDRDZjFuN2VhK2E0TjBlYUlUMktycmRnYURCbjVT?=
 =?utf-8?B?NVd4R1NCS1MweEZXbUlhK1hjbjlKOFUrMncxMDdDZDdZQWdWWlVaSU9wSUNl?=
 =?utf-8?B?OFVVa3JTbFpuTHRwTU42dExNMHZaVTcyRllHVGQxd05nMVVRNjhSUDRCVUpq?=
 =?utf-8?B?dWY1QkNYNUl1MWxMM2tUSmpBZUlZWFNuelVoZUEvZXNScm8vNWUzd3c0eXVm?=
 =?utf-8?B?Um81UnRXb3dza2hnV3ladDhTYklRa003NmMzL3FRMDhmWVgvM1ltOWJETEs0?=
 =?utf-8?B?bEE5enl3bTNnVWREd3YzUWVMaTdhSm1IcDZ0LzdwYlpZbGVQWm13UT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <26683A6487432A46ABA669D5E86A73B7@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5f01d493-f33d-43b3-b988-08d9e63b9bdc
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Feb 2022 11:03:14.1560
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Cn3Sim0lZvo9A473dLtaxYT4PLagaTJiNtwO2HjrtTeIsv4M6fh2ta4q2ayjcj3PjzGnO+J1btbE+4qB7k/c58k8CIVIT34u2o2yYbTyhmD6JJZDLXjPiJB52pxV2itg
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR03MB7891
X-Proofpoint-ORIG-GUID: udF-F0vuxdc83QacmVanjNYovD4J18QL
X-Proofpoint-GUID: udF-F0vuxdc83QacmVanjNYovD4J18QL
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-02_05,2022-02-01_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015
 lowpriorityscore=0 spamscore=0 mlxlogscore=956 suspectscore=0
 malwarescore=0 bulkscore=0 priorityscore=1501 mlxscore=0 impostorscore=0
 adultscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202020059

SGksIEphbiENCg0KT24gMDIuMDIuMjIgMTE6MjIsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAw
MS4wMi4yMDIyIDE3OjI1LCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyB3cm90ZToNCj4+IEZyb206
IFJvZ2VyIFBhdSBNb25uZSA8cm9nZXIucGF1QGNpdHJpeC5jb20+DQo+Pg0KPj4gVGhpcyB3YXkg
dGhlIGxvY2sgY2FuIGJlIHVzZWQgdG8gY2hlY2sgd2hldGhlciB2cGNpIGlzIHByZXNlbnQsIGFu
ZA0KPj4gcmVtb3ZhbCBjYW4gYmUgcGVyZm9ybWVkIHdoaWxlIGhvbGRpbmcgdGhlIGxvY2ssIGlu
IG9yZGVyIHRvIG1ha2UNCj4+IHN1cmUgdGhlcmUgYXJlIG5vIGFjY2Vzc2VzIHRvIHRoZSBjb250
ZW50cyBvZiB0aGUgdnBjaSBzdHJ1Y3QuDQo+PiBQcmV2aW91c2x5IHJlbW92YWwgY291bGQgcmFj
ZSB3aXRoIHZwY2lfcmVhZCBmb3IgZXhhbXBsZSwgc2luY2UgdGhlDQo+PiBsb2NrIHdhcyBkcm9w
cGVkIHByaW9yIHRvIGZyZWVpbmcgcGRldi0+dnBjaS4NCj4+DQo+PiBTaWduZWQtb2ZmLWJ5OiBS
b2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT4NCj4+IFNpZ25lZC1vZmYtYnk6
IE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIDxvbGVrc2FuZHJfYW5kcnVzaGNoZW5rb0BlcGFtLmNv
bT4NCj4+IC0tLQ0KPj4gQ2M6IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5j
b20+DQo+PiBDYzogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KPj4gQ2M6IEp1bGll
biBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+PiBDYzogU3RlZmFubyBTdGFiZWxsaW5pIDxzc3Rh
YmVsbGluaUBrZXJuZWwub3JnPg0KPj4gLS0tDQo+PiBOZXcgaW4gdjUgb2YgdGhpcyBzZXJpZXM6
IHRoaXMgaXMgYW4gdXBkYXRlZCB2ZXJzaW9uIG9mIHRoZSBwYXRjaCBwdWJsaXNoZWQgYXQNCj4+
IGh0dHBzOi8vdXJsZGVmZW5zZS5jb20vdjMvX19odHRwczovL2xvcmUua2VybmVsLm9yZy94ZW4t
ZGV2ZWwvMjAxODA3MTcwOTQ4MzAuNTQ4MDYtMi1yb2dlci5wYXVAY2l0cml4LmNvbS9fXzshIUdG
XzI5ZGJjUUlVQlBBIWptbWNld1k2eTlVcjRyZ3ZPZ3FzY3o4Z0JXYW9kMkpuUU9rSHZXdFlLZ25x
ZVU2Qm9XSlRxQ04zVURwQ3czaW84WW5rLXdCWGhBJCBbbG9yZVsuXWtlcm5lbFsuXW9yZ10NCj4+
DQo+PiBDaGFuZ2VzIHNpbmNlIHY1Og0KPiBUaGlzIGlzIGEgbGl0dGxlIG9kZCBpbiBhIHNlcmll
cyBpbXBsaWNpdGx5IHRhZ2dlZCBhcyB2MS4NCj4NCj4+IC0tLSBhL3hlbi9kcml2ZXJzL3ZwY2kv
aGVhZGVyLmMNCj4+ICsrKyBiL3hlbi9kcml2ZXJzL3ZwY2kvaGVhZGVyLmMNCj4+IEBAIC0xNDIs
MTIgKzE0MiwxMyBAQCBib29sIHZwY2lfcHJvY2Vzc19wZW5kaW5nKHN0cnVjdCB2Y3B1ICp2KQ0K
Pj4gICAgICAgICAgIGlmICggcmMgPT0gLUVSRVNUQVJUICkNCj4+ICAgICAgICAgICAgICAgcmV0
dXJuIHRydWU7DQo+PiAgIA0KPj4gLSAgICAgICAgc3Bpbl9sb2NrKCZ2LT52cGNpLnBkZXYtPnZw
Y2ktPmxvY2spOw0KPj4gLSAgICAgICAgLyogRGlzYWJsZSBtZW1vcnkgZGVjb2RpbmcgdW5jb25k
aXRpb25hbGx5IG9uIGZhaWx1cmUuICovDQo+PiAtICAgICAgICBtb2RpZnlfZGVjb2Rpbmcodi0+
dnBjaS5wZGV2LA0KPj4gLSAgICAgICAgICAgICAgICAgICAgICAgIHJjID8gdi0+dnBjaS5jbWQg
JiB+UENJX0NPTU1BTkRfTUVNT1JZIDogdi0+dnBjaS5jbWQsDQo+PiAtICAgICAgICAgICAgICAg
ICAgICAgICAgIXJjICYmIHYtPnZwY2kucm9tX29ubHkpOw0KPj4gLSAgICAgICAgc3Bpbl91bmxv
Y2soJnYtPnZwY2kucGRldi0+dnBjaS0+bG9jayk7DQo+PiArICAgICAgICBzcGluX2xvY2soJnYt
PnZwY2kucGRldi0+dnBjaV9sb2NrKTsNCj4+ICsgICAgICAgIGlmICggdi0+dnBjaS5wZGV2LT52
cGNpICkNCj4+ICsgICAgICAgICAgICAvKiBEaXNhYmxlIG1lbW9yeSBkZWNvZGluZyB1bmNvbmRp
dGlvbmFsbHkgb24gZmFpbHVyZS4gKi8NCj4+ICsgICAgICAgICAgICBtb2RpZnlfZGVjb2Rpbmco
di0+dnBjaS5wZGV2LA0KPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICByYyA/IHYtPnZw
Y2kuY21kICYgflBDSV9DT01NQU5EX01FTU9SWSA6IHYtPnZwY2kuY21kLA0KPj4gKyAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAhcmMgJiYgdi0+dnBjaS5yb21fb25seSk7DQo+PiArICAgICAg
ICBzcGluX3VubG9jaygmdi0+dnBjaS5wZGV2LT52cGNpX2xvY2spOw0KPiBXaGlsZSBJIGNlcnRh
aW5seSBzZWUgdGhlIHBvaW50LCB0aGUgYWRkaXRpb24gb2YgdGhpcyBpZigpIChhbmQgYQ0KPiBm
ZXcgbW9yZSBlbHNld2hlcmUpIGlzbid0IGNvdmVyZWQgYnkgdGl0bGUgb3IgZGVzY3JpcHRpb24u
DQpUaGUgY29tbWl0IG1lc3NhZ2Ugc2F5czoNCiJUaGlzIHdheSB0aGUgbG9jayBjYW4gYmUgdXNl
ZCB0byBjaGVjayB3aGV0aGVyIHZwY2kgaXMgcHJlc2VudCwgYW5kDQpyZW1vdmFsIGNhbiBiZSBw
ZXJmb3JtZWQgd2hpbGUgaG9sZGluZyB0aGUgbG9jaywgaW4gb3JkZXIgdG8gbWFrZQ0Kc3VyZSB0
aGVyZSBhcmUgbm8gYWNjZXNzZXMgdG8gdGhlIGNvbnRlbnRzIG9mIHRoZSB2cGNpIHN0cnVjdC4i
DQpTbywgSSB0aGluayB0aGlzIGlzIGVub3VnaCB0byBkZXNjcmliZSB0aGUgZmFjdCB0aGF0IGFm
dGVyIHlvdSBoYXZlIGxvY2tlZA0KdGhlIHByb3RlY3RlZCBzdHJ1Y3R1cmUgbWF5IGhhdmUgZ29u
ZSBhbHJlYWR5IGFuZCB3ZSBuZWVkIHRvDQpyZS1jaGVjayBpdCBpcyBzdGlsbCBwcmVzZW50Lg0K
Pg0KPj4gLS0tIGEveGVuL2RyaXZlcnMvdnBjaS92cGNpLmMNCj4+ICsrKyBiL3hlbi9kcml2ZXJz
L3ZwY2kvdnBjaS5jDQo+PiBAQCAtMzUsMTIgKzM1LDEwIEBAIGV4dGVybiB2cGNpX3JlZ2lzdGVy
X2luaXRfdCAqY29uc3QgX19zdGFydF92cGNpX2FycmF5W107DQo+PiAgIGV4dGVybiB2cGNpX3Jl
Z2lzdGVyX2luaXRfdCAqY29uc3QgX19lbmRfdnBjaV9hcnJheVtdOw0KPj4gICAjZGVmaW5lIE5V
TV9WUENJX0lOSVQgKF9fZW5kX3ZwY2lfYXJyYXkgLSBfX3N0YXJ0X3ZwY2lfYXJyYXkpDQo+PiAg
IA0KPj4gLXZvaWQgdnBjaV9yZW1vdmVfZGV2aWNlKHN0cnVjdCBwY2lfZGV2ICpwZGV2KQ0KPj4g
K3N0YXRpYyB2b2lkIHZwY2lfcmVtb3ZlX2RldmljZV9sb2NrZWQoc3RydWN0IHBjaV9kZXYgKnBk
ZXYpDQo+PiAgIHsNCj4+IC0gICAgaWYgKCAhaGFzX3ZwY2kocGRldi0+ZG9tYWluKSApDQo+PiAt
ICAgICAgICByZXR1cm47DQo+PiArICAgIEFTU0VSVChzcGluX2lzX2xvY2tlZCgmcGRldi0+dnBj
aV9sb2NrKSk7DQo+IFdoaWxlLCB1bmxpa2UgaGVyZSwgLi4uDQo+DQo+PiBAQCAtMTUyLDggKzE2
NCw2IEBAIGludCB2cGNpX2FkZF9yZWdpc3RlcihzdHJ1Y3QgdnBjaSAqdnBjaSwgdnBjaV9yZWFk
X3QgKnJlYWRfaGFuZGxlciwNCj4+ICAgICAgIHItPm9mZnNldCA9IG9mZnNldDsNCj4+ICAgICAg
IHItPnByaXZhdGUgPSBkYXRhOw0KPj4gICANCj4+IC0gICAgc3Bpbl9sb2NrKCZ2cGNpLT5sb2Nr
KTsNCj4gLi4uIHlvdSBkaWQgZXhwbGFpbiB3aHkgeW91IGRvbid0IHdhbnQgdG8gYWRkIGEgc2lt
aWxhciBhc3NlcnRpb24NCj4gaGVyZSwgSSB0aGluayBpbiByZXR1cm4gdGhlIGZ1bmN0aW9uIHdh
bnRzIHRvIGhhdmUgYSBjb21tZW50IGFkZGVkDQo+IHRoYXQgaXQncyByZXF1aXJlZCB0byBiZSBj
YWxsZWQgd2l0aCB0aGUgcmVzcGVjdGl2ZSBsb2NrIGhlbGQuDQpXaWxsIGFkZCB0aGUgY29tbWVu
dHMNCj4gICBJDQo+IG5vdGljZSB5b3UgZGlkIHNvIGZvciB0aGUgZGVjbGFyYXRpb24sIGJ1dCBJ
IHRoaW5rIHN1Y2ggYSBjb21tZW50DQo+IHdvdWxkIGJldHRlciBiZSBwcmVzZW50IGF0IHRoZSBk
ZWZpbml0aW9uIGFzIHdlbGwuIFNhbWUgZm9yDQo+IHZwY2lfcmVtb3ZlX3JlZ2lzdGVyKCkgdGhl
biwgb2J2aW91c2x5Lg0KT2sNCj4NCj4+IEBAIC0zMTEsNyArMzE2LDcgQEAgc3RhdGljIHVpbnQz
Ml90IG1lcmdlX3Jlc3VsdCh1aW50MzJfdCBkYXRhLCB1aW50MzJfdCBuZXcsIHVuc2lnbmVkIGlu
dCBzaXplLA0KPj4gICB1aW50MzJfdCB2cGNpX3JlYWQocGNpX3NiZGZfdCBzYmRmLCB1bnNpZ25l
ZCBpbnQgcmVnLCB1bnNpZ25lZCBpbnQgc2l6ZSkNCj4+ICAgew0KPj4gICAgICAgY29uc3Qgc3Ry
dWN0IGRvbWFpbiAqZCA9IGN1cnJlbnQtPmRvbWFpbjsNCj4+IC0gICAgY29uc3Qgc3RydWN0IHBj
aV9kZXYgKnBkZXY7DQo+PiArICAgIHN0cnVjdCBwY2lfZGV2ICpwZGV2Ow0KPj4gICAgICAgY29u
c3Qgc3RydWN0IHZwY2lfcmVnaXN0ZXIgKnI7DQo+PiAgICAgICB1bnNpZ25lZCBpbnQgZGF0YV9v
ZmZzZXQgPSAwOw0KPj4gICAgICAgdWludDMyX3QgZGF0YSA9IH4odWludDMyX3QpMDsNCj4+IEBA
IC0zMjcsNyArMzMyLDEyIEBAIHVpbnQzMl90IHZwY2lfcmVhZChwY2lfc2JkZl90IHNiZGYsIHVu
c2lnbmVkIGludCByZWcsIHVuc2lnbmVkIGludCBzaXplKQ0KPj4gICAgICAgaWYgKCAhcGRldiAp
DQo+PiAgICAgICAgICAgcmV0dXJuIHZwY2lfcmVhZF9odyhzYmRmLCByZWcsIHNpemUpOw0KPj4g
ICANCj4+IC0gICAgc3Bpbl9sb2NrKCZwZGV2LT52cGNpLT5sb2NrKTsNCj4+ICsgICAgc3Bpbl9s
b2NrKCZwZGV2LT52cGNpX2xvY2spOw0KPj4gKyAgICBpZiAoICFwZGV2LT52cGNpICkNCj4+ICsg
ICAgew0KPj4gKyAgICAgICAgc3Bpbl91bmxvY2soJnBkZXYtPnZwY2lfbG9jayk7DQo+PiArICAg
ICAgICByZXR1cm4gdnBjaV9yZWFkX2h3KHNiZGYsIHJlZywgc2l6ZSk7DQo+PiArICAgIH0NCj4g
SW4gdGhpcyBjYXNlIGFzIHdlbGwgYXMgaW4gaXRzIHdyaXRlIGNvdW50ZXJwYXJ0IGl0IGJlY29t
ZXMgZXZlbiBtb3JlDQo+IGltcG9ydGFudCB0byBqdXN0aWZ5IChpbiB0aGUgZGVzY3JpcHRpb24p
IHRoZSBuZXcgYmVoYXZpb3IuIEl0IGlzIG5vdA0KPiBvYnZpb3VzIGF0IGFsbCB0aGF0IHRoZSBh
YnNlbmNlIG9mIGEgc3RydWN0IHZwY2kgc2hvdWxkIGJlIHRha2VuIGFzDQo+IGFuIGluZGljYXRp
b24gdGhhdCB0aGUgdW5kZXJseWluZyBkZXZpY2UgbmVlZHMgYWNjZXNzaW5nIGluc3RlYWQuDQo+
IFRoaXMgYWxzbyBjYW5ub3QgYmUgaW5mZXJyZWQgZnJvbSB0aGUgIiFwZGV2IiBjYXNlIHZpc2li
bGUgaW4gY29udGV4dC4NCj4gSW4gdGhhdCBjYXNlIHdlIGhhdmUgbm8gcmVjb3JkIG9mIGEgZGV2
aWNlIGF0IHRoaXMgU0JERiwgYW5kIGhlbmNlIHRoZQ0KPiBmYWxsYmFjayBwcmV0dHkgY2xlYXJs
eSBpcyBhICJqdXN0IGluIGNhc2UiIG9uZS4gWWV0IGlmIHdlIGtub3cgb2YgYQ0KPiBkZXZpY2Us
IHRoZSBhYnNlbmNlIG9mIGEgc3RydWN0IHZwY2kgbWF5IG1lYW4gdmFyaW91cyBwb3NzaWJsZSB0
aGluZ3MuDQpPaywgSSdsbCBkZXNjcmliZSB0aGlzIGNoYW5nZQ0KPg0KPiBKYW4NCj4NClRoYW5r
IHlvdSwNCk9sZWtzYW5kcg==


From xen-devel-bounces@lists.xenproject.org Wed Feb 02 11:12:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 11:12:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264056.457010 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFDYP-0006Vl-L8; Wed, 02 Feb 2022 11:12:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264056.457010; Wed, 02 Feb 2022 11:12:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFDYP-0006Ve-Hw; Wed, 02 Feb 2022 11:12:01 +0000
Received: by outflank-mailman (input) for mailman id 264056;
 Wed, 02 Feb 2022 11:12:01 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=6WyI=SR=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nFDYP-0006VY-83
 for xen-devel@lists.xenproject.org; Wed, 02 Feb 2022 11:12:01 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f0f6f79c-8418-11ec-8f75-fffcc8bd4f1a;
 Wed, 02 Feb 2022 12:12:00 +0100 (CET)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2055.outbound.protection.outlook.com [104.47.12.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-7-hVKG5FloPZG4GNNS6gmDEw-1; Wed, 02 Feb 2022 12:11:58 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AS8PR04MB9207.eurprd04.prod.outlook.com (2603:10a6:20b:44e::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Wed, 2 Feb
 2022 11:11:57 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.012; Wed, 2 Feb 2022
 11:11:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f0f6f79c-8418-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1643800319;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=9zs0xCb6mFQbQyXIWsB4X6l675Xqy9x4YoPO6Zjx2mo=;
	b=YnzgUTrhMhsfU5QzvkY+l3eGKvLXBgpUvBKJW9ul3gTfH1jNmT6w3+vdrnNRoFN4ZfT4aO
	5ktnoAzOGfKofg2xta53zCj+gdkYp5td8s9owZFVEQmnyIOJ5/SnLMos8EMCqdrPrWz9UF
	JxfGeuV/GE+vV54L1Wdf6/VXGBk7KNQ=
X-MC-Unique: hVKG5FloPZG4GNNS6gmDEw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cXODshrHtmJG8hSvNBXk3WMVDd2Lw8Lv3AIFcaH2iyCsuhZhjBEqWailQu62Swov9IRfxLGiBFgjImtKNh8OxRPVqsU1UIzbA7naGRQpUjqr2bCEHjR2JImRXuuYiZX1W/lVDdO5l7Zq0rxdZM2Ip8sR4zhM2lXv3gjkspU6WMG7kLZ2KRAjEOEvq15vxSmFPtS63knTE8zMqP6ur88yl3OHZTkFQIAfv28wRvtFM7mMpoci069/qBe85mbqephe5J19CZdPjehsvvwAocZmzQF3GqEknthZKV6sNS/7oxfBkrxuppuotIBA7pJjZQ/Ml99CuFQw66htuty2QtA4Qg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=9zs0xCb6mFQbQyXIWsB4X6l675Xqy9x4YoPO6Zjx2mo=;
 b=bhnVMLTM4BFrxGq+EDe/LcMLqMQVv7m9eGDLNf2hcRYznf3jcPqUQRVDxs+KUhf1S+HCHSot0GjUG6mt4joAy204wKMql5E5+8OC6NurdKT12rtqf7tm3txdYfIzlBMqhjS2KwedVqUS0AM9kzQh8shYEPguVf1nJqFqA3wODpfzmD2JKgkP/3hlrSHECzbJseQklywJip4oA6SrSMx2jQtUcpqccDf24sN4G4KzD5MlJfCy9RHQMsn0ii+p+ZdFyGa0AL6EPJWUejLN5kRBlNissLthgC/VXS/E7QCwoXOyONtNcouWjk3191TEr+MnFKCqSqIyq9VLJBaXsEEmwg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <0161ac2f-e0f2-378a-4931-98e554bd9353@suse.com>
Date: Wed, 2 Feb 2022 12:11:54 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v5 08/14] vpci/header: program p2m with guest BAR view
Content-Language: en-US
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "julien@xen.org" <julien@xen.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Artem Mygaiev <Artem_Mygaiev@epam.com>,
 "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
 "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
 "paul@xen.org" <paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>
References: <20211125110251.2877218-1-andr2000@gmail.com>
 <20211125110251.2877218-9-andr2000@gmail.com> <Yd/9W7GFO51GE0ch@Air-de-Roger>
 <37c2374d-c0f7-23b6-d2f8-e94d1348807c@epam.com>
 <2282e7c5-ba1b-e2a2-af4a-84a894211870@epam.com>
 <YfpeT+VMWiklDWGf@Air-de-Roger>
 <7d4c128d-f6f0-8dca-8ab4-6138ed6cd61d@epam.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <7d4c128d-f6f0-8dca-8ab4-6138ed6cd61d@epam.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR04CA0036.eurprd04.prod.outlook.com
 (2603:10a6:20b:46a::29) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 395889b9-a60e-46a5-5bf8-08d9e63cd37b
X-MS-TrafficTypeDiagnostic: AS8PR04MB9207:EE_
X-Microsoft-Antispam-PRVS:
	<AS8PR04MB9207DFEAE2661ADF4A40453BB3279@AS8PR04MB9207.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6430;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	5lvxZrQ3ubfXed3HV7ChXruwfuRB28+/VEz5hSO5lkpOHcbSVSCsvwfZyyCuraWCbWijGY9kH2QhAGkKC6FdMrvRk1MZAKR7nowfm+zxupyLVxlIWSc6/NKnZQLtVe/d0KftJLq9IPNymg/oAZZvmajHwFfS/dJqeHbWjSBW7mx7XvWP6CQWtHTkaHmp+aIFshRh9LMArMBJcFux/fP/R47HXCeSdU7k+V4Sey8o7gyX8WW/0MI19QZ3WdsY3hUzULXsjQsMkOFn+0LNJX0IQxqVxgCQhLP4OPzcNASC8QhyxXvcriWcoEOJC6/cB1oP2zmkBxutiYUPvbG8lcuMlkgn6D3UlzYNcKzFVSTaKmDcI82TJeOQs/L1vbsNzpFKYurznw2f2hhjFpOlDdlcnnCGAddIns5Hxe1OQAWQ0TPhxF6DaE/Zqk8ssXnOCwInMWeNbmX9jMbsdjNH1v2Uw4a5ciuJ7XA0C7RTgnwYAoc+v2sJNe3mefV9uWA/2097Pm42t3s2YquC6hCXgUFp3Zu7DlE5BczuW983YAXrQDuD01hIv0NUt7ZvI/6lmN4Mv/KjkTojN3MklZ2s86VeNIGwek5L9dnrUqJytKwGzdI6nF0ZzPrlq9b2MB+MI3s0N2g8w+5U6E1+rnqr4LLNNH3uviqLqwFWx2RupAvEOC+NDMulGLuLTzgUcKCTzXx6w5OZt/rgIxe6GwNzQ5Hammr84mb37Na860gWq/8eaBA=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(31696002)(4326008)(7416002)(66946007)(38100700002)(508600001)(66476007)(66556008)(26005)(186003)(53546011)(6666004)(83380400001)(5660300002)(6506007)(36756003)(8676002)(316002)(6916009)(2906002)(6512007)(54906003)(2616005)(6486002)(8936002)(31686004)(86362001)(4744005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?azNqWjRUVEFKdFRERHk5R0xNcHdhMy9Uanl1N0lkWU1zcTJFbUd4aGpkOTBC?=
 =?utf-8?B?TENveTVxdkhPUFhjVWxVMjVheXovNE9aeHNDc2VmSklmY01YTTJEVHk2bTIz?=
 =?utf-8?B?SDdEZjNiVmZ2YnVyV2xHWWNBY0U5QUYzMHZyaUQ0M3RLbHVuTVNkSnQwemRl?=
 =?utf-8?B?R2JEdmNNUHB1OHkrNExUU21XRUR0NUlyb3l5THBteUxjWENTQmhPbUI2S2lX?=
 =?utf-8?B?NFc1Y2lmUjdqc1BFTy9wTTg5M005eU1Tcis5QlQ1NlM3aWc3MTZhQjd6V0VW?=
 =?utf-8?B?WURqQUpIUHVtRGQ2Q3ozN2NlSnd0WUZqOWxnbno1R2VUcDl3OUtiajdDeVB4?=
 =?utf-8?B?bkhzZmFYUnY5TjV6V0t1NTFwQWVDek9wV3kzVFY2eS9VQUtyQWhJMjBGVGJY?=
 =?utf-8?B?TGtjTEZWbmM0MHlJbEU1dU9IR2xKWG1hODduaXFzRmxWR3BnVFNIK2J4U1px?=
 =?utf-8?B?VEtyeURESHZXYzVOZXFIRm04VEZIOEo4cVpmcDRHWHRtaWlrWXZkdjRGa2VH?=
 =?utf-8?B?S05MVTVCM0xWRVR0ZW43V2FWUUVOdndkMG1PK3g3U2t2OFhEcWZ3bzZEbkIr?=
 =?utf-8?B?ZjgvVWFMTGdldUkwcnFzTnkwQUVNallCUFBVVHN5Z1p1TThBdkVjTHRTekZY?=
 =?utf-8?B?bVRDWUd1cEFRZTFEUjN0Um5pUVhBVG5rNUl2NjM5aUEvZzIxMTRtUHlRZi9j?=
 =?utf-8?B?RjE5bTRWT3gyQ0RITGp0dHF0SW5BQWIwQy94eVhNTnl4a1dGSVBGSm80RGZD?=
 =?utf-8?B?MzZqckJud2R2ZkhNTGN4b1pObFRKTFNMTGRwNGpCZlFIcVpsdGliRHZFSTFo?=
 =?utf-8?B?ak9KNC9iZlNrTTRzNTYyWStGSDlxL2o3TGFmRGZUbEhQVjYyb0Rma2FmOEVN?=
 =?utf-8?B?eHhRY0x4bFdvZkozWnNnam9sRXcvSFhBeG5OY1phVXR1Q3BSUGlzQTNwRTNr?=
 =?utf-8?B?RG1PTnhiaGFHRGZMWG9yNy9WTVVrd1hVRm1wd3dLNDFjcFpiV1NqZ2VRWHkx?=
 =?utf-8?B?TjN5OHJydjhFck9lZjVGSnEyaGxIVHh6MCt6ZlRSSUV1Z2k4aU1ERTI0UWVn?=
 =?utf-8?B?OFhqcHBBOGwrTmJUd0o4aDZMb2UzSjVBMFk5am5hTlN6VEs5a241K1lCbGVs?=
 =?utf-8?B?b2owejh6MHMzMnlXQkN6aVUxTVlpZkJ5QnFCOWV4MElLZHNGb3U5ZXZPYnJm?=
 =?utf-8?B?QkgyOUNRTzlJSmhFSEVwSnZuaTJVUGNyZlloUi9NRmNHNVkxckZJWlBJcGdr?=
 =?utf-8?B?R3lzZjl5Q0ZQY3p4MGtOZG4wOUM0SkZCaHAvRjRyOFMzbkh6TWFoZm9FaWRn?=
 =?utf-8?B?MFVWWnBtYTlzMHgvdDZmdDFxZlBxbEZrN3NtSjVVYTFody9CMUhqQWM3aU9w?=
 =?utf-8?B?UlYrb1BUQXIweW8yMndVdUlkSnhLOUkrTy8vT2FwdVVSdmNoMDArb3d2NHk4?=
 =?utf-8?B?UnZ3cGt6K0hvKzJZUDNKOGNPZjdtWG9PTUVOZGVsMjJYMVNadVhmNyt0MEVv?=
 =?utf-8?B?dSt6TEF6aU5NN1dSa3FZT0N3eGJjNmVlaUY3eHNCNzU5VVBheWtUSDI5ZTRJ?=
 =?utf-8?B?YXR3TitUSzVsbEhXTmw3YnpVTzVCbTZTeGJmd1pGcFZvK0c1RHpSbXBhbGJQ?=
 =?utf-8?B?TU0zM1pEWGorNVp4UnhBNk9BczFkTzR5b0tzcjVDOTVCSW9DbUw4VldUcFVw?=
 =?utf-8?B?elZrMmljYmVNUUo3OHhBbDIvRzNkQW02cFFqQllYdmI5UVRqZU5QTVBXbE5N?=
 =?utf-8?B?QS94aXFvMERHaFhNbUZDUHExMjhVdzdjSW44UW0wbWM1UVRaRzlNK3RLSm9h?=
 =?utf-8?B?L3gxQVFEQ2FESmlkSnVwRm1jRlI0SlNUckVJSjdMdHJtWVFNSGp6T3QwOTY1?=
 =?utf-8?B?ekRpVzNDUUtuQ3p5anZoREpjVEU1NlRQdXg5bFFYUjV4VG53ejBiRDFPL3Z0?=
 =?utf-8?B?bmE0S3ZKL3g2ekJzeTZjcG9QL0J1Nm1DdlV3QXU4emkyWEx2c2E5Nm9kMG9o?=
 =?utf-8?B?WFlxUVVqVit5eXZTbTVPZFVJZWlZR3RBRUVGVnc4NXZnMStDYVNFSTdvakFj?=
 =?utf-8?B?ZzVicGlxZSsyRVVvK2crTjU0dG1HRFUza01hTXNKZUxTSzcrUjdvcjNKNTdW?=
 =?utf-8?B?Q2VDOWcwRm5aK3QvSUxTTFFidG5yRXR3RXg3V2tDVFJEOVg3NHhUNHFBV0kz?=
 =?utf-8?Q?icXvXCbj3RaTMn0aC6pTMWw=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 395889b9-a60e-46a5-5bf8-08d9e63cd37b
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2022 11:11:57.1857
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: X0Gwhvy1peqbv3FZn/DXFqw/B+A7armOh2G1/aIIi3n1tHVzqHwPogPN0R1t6IHgLU2/d6XnqQD3Of8fqodnZg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB9207

On 02.02.2022 11:44, Oleksandr Andrushchenko wrote:
> Again, IMO, adding such a big piece of DEBUG code instead of
> printing a single DEBUG message could be a bit expansive.
> I still hear your concerns on *when* it is printed, but still think we can
> allow that.

You do realize though that the mere act of logging a message may cause
the need for preemption, and hence logging messages in such cases is
detrimental to forward progress?

Jan



From xen-devel-bounces@lists.xenproject.org Wed Feb 02 11:14:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 11:14:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264063.457021 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFDbF-00078w-3f; Wed, 02 Feb 2022 11:14:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264063.457021; Wed, 02 Feb 2022 11:14:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFDbF-00078p-0M; Wed, 02 Feb 2022 11:14:57 +0000
Received: by outflank-mailman (input) for mailman id 264063;
 Wed, 02 Feb 2022 11:14:56 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=6WyI=SR=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nFDbE-00078j-1B
 for xen-devel@lists.xenproject.org; Wed, 02 Feb 2022 11:14:56 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 59311b35-8419-11ec-8f75-fffcc8bd4f1a;
 Wed, 02 Feb 2022 12:14:54 +0100 (CET)
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur03lp2057.outbound.protection.outlook.com [104.47.9.57]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-15-1pQ6CSccPBeVr_0oipdxCQ-1; Wed, 02 Feb 2022 12:14:53 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AS8PR04MB9207.eurprd04.prod.outlook.com (2603:10a6:20b:44e::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Wed, 2 Feb
 2022 11:14:52 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.012; Wed, 2 Feb 2022
 11:14:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 59311b35-8419-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1643800494;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=9t01eeFkiarElCelzuu7bD0UEGtOl1v1SX0++MOjowg=;
	b=MPGPkEhN7CUcUCS+jOr1gorfXMaMDAQbmkxtsvVdWWezjGGk9ZhUzIv5XMfEaYx/KIpk2g
	p9tSbQEHOqZ/lRmNQefObDDXVvKC7vaZ3zs3VhyjmoFUzbc2gMekItng0HjyaAOvL1BBzI
	RabdORwUbb6DGCBw5vppVDFxmUpSHXk=
X-MC-Unique: 1pQ6CSccPBeVr_0oipdxCQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=C0n0cHm3krHtTbtD7EnIhSMRNQlVRmRxhvH1ukyymQqP0B1JSd78TPnAV4qfUT1382N5ls9QfyIvvG8OkOXq0OJ+gM4LhX5e/IPcHwMYcF2frEKb9gt3lssxCriIPC7CO+cMUz0FUlNeSZQ2Kw0uaDk5NLi5cA7uI6P4u/11CMgaBMCJRegXL4ibDhVwkMdb/bQYrVRt48whOUzPbx5a5PAudxFnva00TwUwKEpGgy4HRueN2gFPcYHE0vSEcUMrU/ONoiOXSuM6mU9iTgcIZdP4lAvwxDPsENXTKRLy9/70dqeJotC7efENS0ztBXahG1t1+bV2LEhBxkLXGOeIkQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=LFH66RMYlzBVjpL0aGpWug9AljITc3neqTV1mJx/ELU=;
 b=ZNJnlo3zUgA0R+NqlOy8SJV+rlDIqlo9LnPfXXNxVG83zJsHbNzmlHd5svko+REnBembyhyNVTgKcIETCGg6vIWpDOcN843Svyb4mVA87AyDMZ9r4bH1wwZVjIIqTsJ+cv0SLGAn0QQ3g/C/YVn9ElasG9FXuzJGMf4Zpyd4uv+tvpHus4Q1lZTVtPFQHnNXUASTSdzRcGDl4Pg/5st6ELmKgFH3QSS2zTT1tnfj/NP/PofValzo24KAWjTBTDWgvNQDmuUD1aNwglmfmqHy0M1dqqJHjB+IWQzzaa5YVBOXf4QlhEaoYQqEU3KXHNzhPEqQOQFogJ8wGJnHxPsJrw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <58209ef8-59e7-129d-c8d5-3edc975892ac@suse.com>
Date: Wed, 2 Feb 2022 12:14:49 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH 4/4] vpci: move lock outside of struct vpci
Content-Language: en-US
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: "julien@xen.org" <julien@xen.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Artem Mygaiev <Artem_Mygaiev@epam.com>,
 "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
 "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
 "paul@xen.org" <paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <20220201162508.417008-1-andr2000@gmail.com>
 <20220201162508.417008-5-andr2000@gmail.com>
 <fc3df33c-d1e5-8c74-01e9-7ea7cea41521@suse.com>
 <e19a0f7a-651e-09a6-c03d-ea5286fe03ba@epam.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <e19a0f7a-651e-09a6-c03d-ea5286fe03ba@epam.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6PR04CA0008.eurprd04.prod.outlook.com
 (2603:10a6:20b:92::21) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b75f569d-2dff-40d4-9704-08d9e63d3ba9
X-MS-TrafficTypeDiagnostic: AS8PR04MB9207:EE_
X-Microsoft-Antispam-PRVS:
	<AS8PR04MB9207E9DC1324146775BADC7BB3279@AS8PR04MB9207.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4714;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	keFHDFWkV6OliBgy91ooO5+HrnICMHR+SURikb3XkLpXvTB9ifaER8acMu54kTFsVFZxWZD0vIm7xh41JShiUk7VEnKB2QdV4rtqz40XHpKtp+KxDc0ubNsSTf8SLG+rCRByximW1MSFgsP3PwD4BT2+VUscY+okwqN5D3pKRhsEvAoP4FZP7svyQpoxksqbyC+enQv82Jvd02VvjJZxaehRzm8IHJ0So3N0EzvpJo1h/uENXf4vlvhwCh+BzMyDccHZ07Ij60CFod/VLqHcJQmciR6ZN2MQ+U0YDmRJJiyH3qjo6mXArIF3A1OxNaRUSdEuUwy4zrCLv3W4/6gIjcJ2YX9Alt+6fEJ7X9M+wxUd2ES2UWV3VuXxnXty2T4gYc04Qn6EiCs8eMOZhFJZvVe/8iPjjOYEaz4/t5cMSghimzTvTzDpCFlG4wZTQj+vIS5ev0cDJoQOpcvtL/g1MMv5eS3W7IdEek/p7+MsO/bVwdDCDg0IihrOBOEbYPsgiz90FMvJnwzkvTO1zrXic50O/IWYMeVk24kk3m69Lkwj3cbfqBxTEbx/pjFcG5MvU3XFkDK6MGhQN6Txapm57O4m0fmj2OwJTXaKp1e+9GqsYzYuW7DJGTHXf9e+ujABrleJ5cizF6QI7vsWkIDDWstO7bC9taLy2RAZ1z2+4tyxnP6ptymbB9UPZ1nh4LhI1p+M2KpCN/0kjvaKW9VZFLHy6fr/swOomRNfjbxw1FwISET9O4Tt4wWIFhvDw0bKk0kgyzSCXEOMDEcg0G7ASzJ5n7gixqv9xnb5qzQqhz7jOM4T/CLES/yIZL+pAzN/
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(31696002)(4326008)(7416002)(66946007)(38100700002)(508600001)(66476007)(66556008)(26005)(186003)(53546011)(966005)(6666004)(83380400001)(5660300002)(6506007)(36756003)(8676002)(316002)(6916009)(2906002)(6512007)(54906003)(2616005)(6486002)(8936002)(31686004)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?VF13qYTpkyh+wfFDe9CQP308NHyVndvOWwaqWcc0Qfek3hSyKlSy0oX9zsZz?=
 =?us-ascii?Q?m9VR2Xd4oo/1zC12MmBSHuxsc1zXXx5EU5z47ufes7yrq3oomire6/+ZxXlG?=
 =?us-ascii?Q?gQceXbzI5/e+SBewWrgFtyw581W2guxyIoVnBo7yww+Mp27m/wHZ8yQjRBWl?=
 =?us-ascii?Q?SZKlXf1npYk+WglRI29StNagD146Rt8wibPVstuS0AvRLzidkNejI2hXlTA+?=
 =?us-ascii?Q?GJsMDaBNbtaUUGIOIoYnKSjLV+VYNVuz3zxm7i2+8LI67mApu4o9Qz0WMugj?=
 =?us-ascii?Q?rNba9a8jhbGvxSGn52bByUH3ezSa/7fwzqjooKwRj28uwk6cCCkZ5AaJx4hb?=
 =?us-ascii?Q?EozWXlgFiNZ0cVcrDkdP0a+HFx2VRvrQPaVa7yZ0ySfuEjMeBUAJIR3hoY1E?=
 =?us-ascii?Q?eYQI98aAYZRHZl6D350IekeABk/mllzMp+tCZcwvdypug9s8ECdTD3Tvdl9c?=
 =?us-ascii?Q?eBH+r8vFsOTgj6cpZ9Qn2Wi6vtwDKmFjR8A1T0MqarHJZCKjfKO+m5MTXkAK?=
 =?us-ascii?Q?QK8QOENztgUilZ9TzQptjIzFqTGgs1eRqBJLodZyCgADL7eS/V2XJbvsf5oL?=
 =?us-ascii?Q?AeV0Ne+SrCAa8EZhN3xtrvDApbAvHUjEv++qpGGJiacvLVmG8qitxgODWIoh?=
 =?us-ascii?Q?X8xn8nvxN6L8SG+DNyYUGShDW/Hr7dzZLqB+G/+V/TF58Am/es1NKjj+wBE2?=
 =?us-ascii?Q?dOf6rDxiChQ+KuyXSfSC0IS6Kk8vy3AG2uJ5YLekFsFecxCju/B4M+2lB6zI?=
 =?us-ascii?Q?HPSlLH+8GkphXbUWs+k5yZwgZj3nttMeebkiOMm5p9kJsmWCQM2TeLM0ZKTg?=
 =?us-ascii?Q?XGsIqvDVoD1kMuixAs9xvLQ/b/LTjIvj4SuCwb3EiZPSljV7jzRyy4BHDikf?=
 =?us-ascii?Q?HGGCWGm/8O+1plMUMeR89gmZ0TRZ4H+0gzc4jpXEOh51jTC44Qx3T7O7P9v2?=
 =?us-ascii?Q?Rom0v+RrQSD7gK+zYCwLoCBnKgT7CqbXScet2MHkXkhLP2dG++RcqnlBrW+n?=
 =?us-ascii?Q?2MYIE1I5UIXObKFY9Dvs5W0Wt51k5J0BpdPzohIVP62vELyHvhtZ7+C7beiq?=
 =?us-ascii?Q?DvnJ34kLkyqeLQeKx4JFsg99YjBTQGlYL1aaS/LYYuDf9vW9pSQre+1uhn26?=
 =?us-ascii?Q?OlrcUbnWaM/5B4hea6oQZV1vI5QTcYCvUf0Sm20HmEfijSlzdDroXY1qNcN8?=
 =?us-ascii?Q?7J5mnZRPKibj2xUn5ESB06uNM6AE0eAqaWykCo8Lw46FvGwo6Cvc8mWbvfA3?=
 =?us-ascii?Q?0gYEfMJ4w+/tkAhXnMAqigC9layGnvvN2nVevKe+zZK4NFO5aiJNDvoLeXAM?=
 =?us-ascii?Q?IAEt4xllb5HTHQwanSgA2zfM2Coj4TN3jgzFLATJPw305yC7wvK0efLiBxF7?=
 =?us-ascii?Q?4Pukpy0A5DZSnQFUrzlsILhjOYjCCxDQs805+jS19yDW36BlO6+lW1ucmvfQ?=
 =?us-ascii?Q?9NgpPdoYXaPB3yFQXIZa7c6pIYVMYPygagl9WfPt662COy5IWv11a56BCxns?=
 =?us-ascii?Q?QdfYo+A+R9xzksDrOKC89E/U6e3Sc2nIWYBijbcy35PQomPRqsFpADys/5Wx?=
 =?us-ascii?Q?GQUhusl6Kb1p3QgETTUw94cS7Nfz/s+4JSwxXrq9LRPT1nPmX3B+c7PSTYT4?=
 =?us-ascii?Q?gWEKHscdqN2fH65YiE9BetU=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b75f569d-2dff-40d4-9704-08d9e63d3ba9
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2022 11:14:51.9405
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jzvuvrd+81WMTZGC0du51rRAil4GZLco6lO7eesQHAj5G4hDo5Ywzet+FXT2ERKnbqgw/Md+EB0I7tnLKeX31A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB9207

On 02.02.2022 12:03, Oleksandr Andrushchenko wrote:
> On 02.02.22 11:22, Jan Beulich wrote:
>> On 01.02.2022 17:25, Oleksandr Andrushchenko wrote:
>>> From: Roger Pau Monne <roger.pau@citrix.com>
>>>
>>> This way the lock can be used to check whether vpci is present, and
>>> removal can be performed while holding the lock, in order to make
>>> sure there are no accesses to the contents of the vpci struct.
>>> Previously removal could race with vpci_read for example, since the
>>> lock was dropped prior to freeing pdev->vpci.
>>>
>>> Signed-off-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>
>>> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.co=
m>
>>> ---
>>> Cc: Andrew Cooper <andrew.cooper3@citrix.com>
>>> Cc: Jan Beulich <jbeulich@suse.com>
>>> Cc: Julien Grall <julien@xen.org>
>>> Cc: Stefano Stabellini <sstabellini@kernel.org>
>>> ---
>>> New in v5 of this series: this is an updated version of the patch publi=
shed at
>>> https://urldefense.com/v3/__https://lore.kernel.org/xen-devel/201807170=
94830.54806-2-roger.pau@citrix.com/__;!!GF_29dbcQIUBPA!jmmcewY6y9Ur4rgvOgqs=
cz8gBWaod2JnQOkHvWtYKgnqeU6BoWJTqCN3UDpCw3io8Ynk-wBXhA$ [lore[.]kernel[.]or=
g]
>>>
>>> Changes since v5:
>> This is a little odd in a series implicitly tagged as v1.
>>
>>> --- a/xen/drivers/vpci/header.c
>>> +++ b/xen/drivers/vpci/header.c
>>> @@ -142,12 +142,13 @@ bool vpci_process_pending(struct vcpu *v)
>>>           if ( rc =3D=3D -ERESTART )
>>>               return true;
>>>  =20
>>> -        spin_lock(&v->vpci.pdev->vpci->lock);
>>> -        /* Disable memory decoding unconditionally on failure. */
>>> -        modify_decoding(v->vpci.pdev,
>>> -                        rc ? v->vpci.cmd & ~PCI_COMMAND_MEMORY : v->vp=
ci.cmd,
>>> -                        !rc && v->vpci.rom_only);
>>> -        spin_unlock(&v->vpci.pdev->vpci->lock);
>>> +        spin_lock(&v->vpci.pdev->vpci_lock);
>>> +        if ( v->vpci.pdev->vpci )
>>> +            /* Disable memory decoding unconditionally on failure. */
>>> +            modify_decoding(v->vpci.pdev,
>>> +                            rc ? v->vpci.cmd & ~PCI_COMMAND_MEMORY : v=
->vpci.cmd,
>>> +                            !rc && v->vpci.rom_only);
>>> +        spin_unlock(&v->vpci.pdev->vpci_lock);
>> While I certainly see the point, the addition of this if() (and a
>> few more elsewhere) isn't covered by title or description.
> The commit message says:
> "This way the lock can be used to check whether vpci is present, and
> removal can be performed while holding the lock, in order to make
> sure there are no accesses to the contents of the vpci struct."
> So, I think this is enough to describe the fact that after you have locke=
d
> the protected structure may have gone already and we need to
> re-check it is still present.

I'm afraid that to me "can be used" describes future behavior, as
opposed to e.g. "is used". If you want to point out both aspects,
maybe "... can be used (and in a few cases is used right away) ..."?

Jan



From xen-devel-bounces@lists.xenproject.org Wed Feb 02 11:15:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 11:15:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264064.457032 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFDbL-0007Rr-Im; Wed, 02 Feb 2022 11:15:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264064.457032; Wed, 02 Feb 2022 11:15:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFDbL-0007Rk-En; Wed, 02 Feb 2022 11:15:03 +0000
Received: by outflank-mailman (input) for mailman id 264064;
 Wed, 02 Feb 2022 11:15:02 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1p3Q=SR=epam.com=prvs=40324c57ab=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nFDbK-0007QY-Gw
 for xen-devel@lists.xenproject.org; Wed, 02 Feb 2022 11:15:02 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5c1a8253-8419-11ec-8eb8-a37418f5ba1a;
 Wed, 02 Feb 2022 12:15:00 +0100 (CET)
Received: from pps.filterd (m0174677.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 212AnEBj013947;
 Wed, 2 Feb 2022 11:14:52 GMT
Received: from eur02-am5-obe.outbound.protection.outlook.com
 (mail-am5eur02lp2059.outbound.protection.outlook.com [104.47.4.59])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3dyrhh83g1-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 02 Feb 2022 11:14:51 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by DB7PR03MB3673.eurprd03.prod.outlook.com (2603:10a6:5:b::11) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4951.12; Wed, 2 Feb 2022 11:14:48 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6%3]) with mapi id 15.20.4951.012; Wed, 2 Feb 2022
 11:14:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5c1a8253-8419-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=g9W5v1E+WAI8irt+PjgMfm/34LHtU5r6Ep9o8cltoU3owXJkN3kQ7z9HPC7IjZeCBMQ6NabI07/e4lw1BP0hbi7R19Kan9Wx1FKeT47LPa6fZZnsdjcPOOLKNpFGx7+FrZNGgIyyzub/PtSZhigZeNKzm0BSQQQimgJQOPuMOwcSmg+3x7EGY7rpZi721X3Yc4Y8/yNSR/PKsfEnMJ1mgTwq71jFOxcWVOpoK+ISoPNv2cL2VSo/aavhU11D79rWVpm9eqJ/34rKCZZPIW2V5DwA1pzlEzpLdSSnO4hRhNGEQp4kYSqaIa1SiS/H/FXy/29/17w+4PVr7QcvRsmJ9w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=HEb8Jtri2uE9kdSPgc2OGHiXKPtMXiLg165QYU4HIso=;
 b=SadoGRSlwbQi7vLxhggwidV8scd+7tFFbF7S7fbHpp7U1P5D95ddCdnCkvVXbsnJ6+hMbSj0RtTxqx/x+/CI1qSNfverU2PDgR3J4wAh85APD5h7weAlCCb0uy+STEa6+PeXX9fM179Rn/FMhKSHWJZB9wSEV+vF8fqiZiANKwT7BzK4C2YAvGrv0NNHIICKPhLfPQnzh9TULnkGoLnuOq1z4/mgk05sEAglA9Y9vNKxXRBUvIXmdQ+JIPSYbXXa2gOu/N+JWvcNKKNhz610gWDqR4+7GDFHxnd0vGbUHVkyMP3Qf5AwCs89CRJaUpbYTmY/kP9f5jNL6F47FEIKwQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=HEb8Jtri2uE9kdSPgc2OGHiXKPtMXiLg165QYU4HIso=;
 b=JJ8AF3oVOJ5GYtNdT3C5pO04qvyxgR0dgnJEx4vpjY4VuIIIZGwH01BB1Tbq6Q1O4uM7+VVbCM/2pA8Jl6sw0MU/0/Xtf8Kh8SLVd6FceOKCUkcNI+9LfbocyG5WDhMPMr9GZUt3Kc6BVkDlU2aaQEfGyw9HUHcAcDWnoo2MZ1CzENuMAnqpnpit+Ld3I69U4nOwGdJleywneqDIoemtxc0uj7S4vhGA9DNT4hkp4YBwYUMAy1qfhw39cJa3wJGgvsRY3j0y0bpVeVwVoFzqYhZ7eB4Pp1BGTvE948tW9gwB4UU+imlbxLEqXwXJeigZR+jJbnLsztv6QnbshmiAdw==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?=
	<roger.pau@citrix.com>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v5 08/14] vpci/header: program p2m with guest BAR view
Thread-Topic: [PATCH v5 08/14] vpci/header: program p2m with guest BAR view
Thread-Index: 
 AQHX4ewInH3i1A85zUqSOqe7J03BoaxhCwuAgB9Nb4CAABckAIAADZOAgAACmgCAAAe7AIAAAM6A
Date: Wed, 2 Feb 2022 11:14:48 +0000
Message-ID: <66fc1da2-a4f5-8648-c5dc-beee5e7951c6@epam.com>
References: <20211125110251.2877218-1-andr2000@gmail.com>
 <20211125110251.2877218-9-andr2000@gmail.com> <Yd/9W7GFO51GE0ch@Air-de-Roger>
 <37c2374d-c0f7-23b6-d2f8-e94d1348807c@epam.com>
 <2282e7c5-ba1b-e2a2-af4a-84a894211870@epam.com>
 <YfpeT+VMWiklDWGf@Air-de-Roger>
 <7d4c128d-f6f0-8dca-8ab4-6138ed6cd61d@epam.com>
 <0161ac2f-e0f2-378a-4931-98e554bd9353@suse.com>
In-Reply-To: <0161ac2f-e0f2-378a-4931-98e554bd9353@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 921fccf2-10c5-4e24-3852-08d9e63d398d
x-ms-traffictypediagnostic: DB7PR03MB3673:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <DB7PR03MB3673F33633F5E84923D77912E7279@DB7PR03MB3673.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8882;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 lRssHSsPhSNn9Pe8VuDGZadvGztVb/j7TzhJM9ZqXiXGqIte7spVo1FqzzKegg7OuXawB6hG0ttYtinNqRuYF30j7LTkAzEWtAerbPq3YdNuLyETgKFXotbQdo7heho8vjv+q+aDre2AZCPhWjKsGMiRUSU0Aiw7GQ5JlUDjXPVhit8lmzr6NgjeVs2fzCmsbm7u3XQ8XLzYaOjuLiongdYuTco/3zY98fFZpdfL3A3+erFSg1qVCsRlEo22yS370XYKdva3m6OeRtpF4Eazj6inbG4WyFhKOj5XYFtB4QPOZNdgjFbRfl2uhsB4ZFv4Dg/gI/ntxIPXK3Ibrjv8qt6ltVZwgAHozTQU+z/dm1uyb2shx1W7butQ734iwLMwagit5bxHxndtIC7R8DQs+h6aKidrruCc7Kv5vxkF9idvJEUFJ3akIWYmSZif123Qt8+n5xXP0wxYAdvHXXm9gYYScpARBXiTdC/KwcZG/yRgPwCRZ+GkSCp+jLHGqfPYLuc+oDf61JvDX0w8vygjNCECwDPpGJF1Y6utDpfZsyWwZk5rtRNmyO/cPJ7eFzbnjQGpIzQffbkAgI4HbJxaTdluRHvvbfXMGzCFRUMbpBTJXLb2uO0a3gMAwBAr9FHnQVY0XWC9ABA4oX0AIKMXo0SyrqeTZwzGmTMS9LD0wi9hrMFpkBsQ+ExHYWscD55X60g72+9KdRBZOiMu6advzia9BqYewJrH1Pk+60F0YZslOJ0TVW8EWndM7FaQCjVO
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(122000001)(107886003)(31686004)(83380400001)(26005)(6506007)(6512007)(186003)(36756003)(71200400001)(53546011)(38070700005)(2616005)(31696002)(8936002)(316002)(4326008)(2906002)(66556008)(64756008)(91956017)(66446008)(66476007)(76116006)(66946007)(6486002)(86362001)(4744005)(7416002)(38100700002)(54906003)(508600001)(5660300002)(8676002)(6916009)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?Tjd0NjVjblFjSi8xby94bGMwOTltMWwwNnBWWGNjc0JrSkQwd0tWeWMrLzV3?=
 =?utf-8?B?RC9yY2ZXZTRjcFkvWDBnbGpKT2xBZzdBTVI0WmllNTBwMldXMjFxWWRoUVhV?=
 =?utf-8?B?cm1FSmdtVVZTWnhEdHhoRk9TaHgxWWNSdSttbDNDRXJ3Y0NQNzVUQTRwWEFo?=
 =?utf-8?B?RmZFanYwa3FDZVZ4bTUwU2hySE5WYlExQmdTN3NCc01LNEZ3WFU4SXZ0S2hp?=
 =?utf-8?B?ZVVSVVpNQnl2WmN3M1ZrZ3RURWtuQWxKOVJYeUp4SVhSZWRabjVYeU5HYVRC?=
 =?utf-8?B?aXJhWGVKRjd4U3VhVHVXYWFUMDU5M25uN2V6RE1BYXl3QVVYUFZKdENvSFFQ?=
 =?utf-8?B?ckhzTDBKbFJ6c2FCMHg2L2tZRTVORzBDY3N6MGZIQmdwQ0t6alYzWkh2K0Z5?=
 =?utf-8?B?Q1A2Vlp2K0tiaFJtVjVXaEI3MkRNWExjK2M3R083a0JUVXNPak9VdmtCQmNh?=
 =?utf-8?B?OEIwS3pXMmoweDdnS0ZEMzRTU1NRbmZiN2xlRk1UOGFHaktZa3RJMWJ0bWxy?=
 =?utf-8?B?eVJQZ3BvdHBWZ3MxNEhiaTBuSmpCM1RhWWYyWkJTdElIOXdSOVRFbUwwd2pC?=
 =?utf-8?B?R1BRKytMdi9CWE1tTGpIcHRsQ1dNREdwOWRIN29CNkYwd3FRVll5a2FaVEx1?=
 =?utf-8?B?dkpCMy91UGx5V1VsQkJ3Ykt1dGhQaEdOSTNFT0lKVVpseTk0Z2lyVDlndkg3?=
 =?utf-8?B?Z0orYlJCTjhFemlhUkFhY285UGw5bnVZQVFsVmdzWDVNenJPdHUvVDRtY2FQ?=
 =?utf-8?B?ZnpvS1ZkaUJNRWFRTTFpbUl5dUhLeXZoejUxdGlTRlJmRzVUNnFLeDNWeGJi?=
 =?utf-8?B?dEZRM2RKeFVnWEh2dzlrYkJvaGNUdm4rdTlLZ1h3RWNqanVhNGlaaGIybnY2?=
 =?utf-8?B?ZVhFd2JHcUpiVmZDaDFYa3UvSnFnYU5CMnoxK0V2aWd0bzd1Skg5N0MvV1ps?=
 =?utf-8?B?TVBCM2hDTG13ajdYNFNqTDBMVk0zcHdkdG9HZFY2cDRDM0U4ZnArb0RlcVVO?=
 =?utf-8?B?ZkZ1TWpESUp0a3VvdWFJR3pGNTllN2k1d092N0J1R0xsYUVpVGpLMEpjR0p4?=
 =?utf-8?B?R29UZmpkZWVVbFNySStTQWNYYmVoMXR0RitTQWJ6WFpSTXJWdmQ0REpoaXhu?=
 =?utf-8?B?RjdLL1RkdlloeW1rYW10dzAyd25LeVdieUxiNVBNTEh6NW8xdmZtamZiYzFG?=
 =?utf-8?B?dnFlM20rcmVsWS9RdlB6eXRYSFkvOFE5S292ZUhuRHNSSHREWnUvZGlNNTg1?=
 =?utf-8?B?dW5vYWFSenU3a1VNRzJ1SmQyT2hmK0NnSS9CQzZjU2RTdXNEcytHNjJPNmlm?=
 =?utf-8?B?U0crZHBrRkhVT2lZUVVneENVZXc4MllaMGxBZ0dDVVc0WjVHeVlxMjllL0Ey?=
 =?utf-8?B?OFV6OWRCS3B1dXN1NzZRSktBeWVjaHV0TG8yODBocDJ6WVV2R1RiYS9vWktt?=
 =?utf-8?B?cHkwdkVTMkJVbExjaDZROG02UlhEbGp3MkNqcmk2citxN2Vhb2hVOHRFWGNG?=
 =?utf-8?B?ZWhqeDZzVWR0RGFOVnJBOEN4OGIrRGxpbHB5U3Rxa0Y1cmE3dEszL0xEajE4?=
 =?utf-8?B?MEVoK1B3U0VRODk0Vlh6R0hGRy95bVU1V0JQYXhaWmswTDRiWUVkbnZvTXBy?=
 =?utf-8?B?UU55YmxQdW5XQzduL0lYMCtzL0lwODFtTWl4TVVtQURkOHdYZE5kSEdCQnBT?=
 =?utf-8?B?VC9Fbjg5S3Y5ejJ5c1B3OHl1d0pUUTFLZi9ZalQ3ckp4TS9mUk1jTitnSWEv?=
 =?utf-8?B?clhPdkdDQ3BqVGtIS1Z2akVpMWZxTXl2Q3VCVDREUDhmYWpyV1plWmxxVmJ2?=
 =?utf-8?B?a3B6T0V2NG5uZ1V4NU1kT2VqbmphQ2VBbDRxbFNhMitTK2NQbEoxSWZkSjMr?=
 =?utf-8?B?SEZ5dndFR0txRkRzY28yQStiVktEMEFodDJ5NUFES2pOcEIvL1ZJNzhTZklO?=
 =?utf-8?B?RkIrSVJ2YVlvUHFXOWp0ai80azJYSzhPdHdEUVNyb0p2bTFJTHNUZmFISUJy?=
 =?utf-8?B?RkthM2RkMjVtNEl0K0oyMTN3djFueENyYy92MTdCMnBsem5EN21JaXptOFh3?=
 =?utf-8?B?ckZMRzZDR3RpejdwN1lIRnFvRktmbGlMM2RKbGlZRFpiTDdFRVhtZVJpVkw2?=
 =?utf-8?B?MHJtM3hEcFEzeHhyMmJ0M2pyOC9OM1J2ekEySXJnajhMVFdqaDVJb3dhd1ky?=
 =?utf-8?B?VEt0dnVkVW5Yd1dLdzVnbXJtS2lhWnhEQ1B5d3Q0dmF5TzRmTm54NzFHd1pF?=
 =?utf-8?B?RUpuaTZRODlQckhxdzA2MUxtM1N6ZU5oMlZxZXhvZmNYRktGeFlQWFh5SEF3?=
 =?utf-8?B?a1I2MDNBZk9OTlRrQ1BaRitKUlU4SkI1Q2w5RFMyeURBeElRSUUrUT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <1DB68AC701DF2D409E1F7A46AD7940E7@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 921fccf2-10c5-4e24-3852-08d9e63d398d
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Feb 2022 11:14:48.2117
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: pYufOJ73UQDVxW0N8C0AlbDQE+TGpKeRigH1NH/B/3qmGZUEiJj29wgw6PrDkIYkkhuL/3/LNYlLeT2rjnMt0C/1yMob/L4CfvnZf8aakv7CHdMSQYu+8xRPKTo4zffT
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR03MB3673
X-Proofpoint-GUID: 8gWGFjKLTkwGD0Z0WMPF9dB9STaABY-Z
X-Proofpoint-ORIG-GUID: 8gWGFjKLTkwGD0Z0WMPF9dB9STaABY-Z
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-02_05,2022-02-01_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=831 clxscore=1015
 lowpriorityscore=0 bulkscore=0 priorityscore=1501 impostorscore=0
 malwarescore=0 spamscore=0 suspectscore=0 phishscore=0 mlxscore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202020060

DQoNCk9uIDAyLjAyLjIyIDEzOjExLCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMDIuMDIuMjAy
MiAxMTo0NCwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+PiBBZ2FpbiwgSU1PLCBh
ZGRpbmcgc3VjaCBhIGJpZyBwaWVjZSBvZiBERUJVRyBjb2RlIGluc3RlYWQgb2YNCj4+IHByaW50
aW5nIGEgc2luZ2xlIERFQlVHIG1lc3NhZ2UgY291bGQgYmUgYSBiaXQgZXhwYW5zaXZlLg0KPj4g
SSBzdGlsbCBoZWFyIHlvdXIgY29uY2VybnMgb24gKndoZW4qIGl0IGlzIHByaW50ZWQsIGJ1dCBz
dGlsbCB0aGluayB3ZSBjYW4NCj4+IGFsbG93IHRoYXQuDQo+IFlvdSBkbyByZWFsaXplIHRob3Vn
aCB0aGF0IHRoZSBtZXJlIGFjdCBvZiBsb2dnaW5nIGEgbWVzc2FnZSBtYXkgY2F1c2UNCj4gdGhl
IG5lZWQgZm9yIHByZWVtcHRpb24sIGFuZCBoZW5jZSBsb2dnaW5nIG1lc3NhZ2VzIGluIHN1Y2gg
Y2FzZXMgaXMNCj4gZGV0cmltZW50YWwgdG8gZm9yd2FyZCBwcm9ncmVzcz8NClRoZW4gSSB3aWxs
IHByb2JhYmx5IHJlbW92ZSB0aGUgcHJpbnQgYXQgYWxsLiBJdCBpcyBlYXN5IHRvIGFkZCBpZiBu
ZWVkZWQNCj4NCj4gSmFuDQo+DQpUaGFuayB5b3UsDQpPbGVrc2FuZHI=


From xen-devel-bounces@lists.xenproject.org Wed Feb 02 11:26:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 11:26:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264078.457042 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFDmk-0000wk-MI; Wed, 02 Feb 2022 11:26:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264078.457042; Wed, 02 Feb 2022 11:26:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFDmk-0000wd-JF; Wed, 02 Feb 2022 11:26:50 +0000
Received: by outflank-mailman (input) for mailman id 264078;
 Wed, 02 Feb 2022 11:26:49 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1p3Q=SR=epam.com=prvs=40324c57ab=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nFDmi-0000wX-Rw
 for xen-devel@lists.xenproject.org; Wed, 02 Feb 2022 11:26:48 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 016c9ee0-841b-11ec-8f75-fffcc8bd4f1a;
 Wed, 02 Feb 2022 12:26:47 +0100 (CET)
Received: from pps.filterd (m0174681.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 212BJJSe005153;
 Wed, 2 Feb 2022 11:26:42 GMT
Received: from eur04-db3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2054.outbound.protection.outlook.com [104.47.12.54])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3dyrypg25u-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 02 Feb 2022 11:26:41 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by PA4PR03MB7120.eurprd03.prod.outlook.com (2603:10a6:102:e9::6) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.22; Wed, 2 Feb
 2022 11:26:26 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6%3]) with mapi id 15.20.4951.012; Wed, 2 Feb 2022
 11:26:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 016c9ee0-841b-11ec-8f75-fffcc8bd4f1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=CFu8x3ASkHeYMgH5Q7Qgi4x0j9QhkBJf3LaEUT1D8vQnwLQF95EN676VHONDjAnAfTO3gCE11kClccvnKht3sk8RqNeAd6rWxXxq8fl4Rpbgk6E+24abArDSsGnT/QHu3PdRMJI74+SAqGRUwhOTqFZbc8UyQ7tSxn+mMKX1SQW4UISjX43mpwj0Y/xwataiW8Kk2fmV7zanr07PO527pbkvacOfeTMqilO708IUzw0xDGiM7w0AedoF66vpeu743LIC+BXw+GF2gWgeJB0bRFWvd0ohcplNqLTQWVJoAUzRNfPxNxmFtoB4AiJY0jowsCmmg0YeGWNko5iUrH+qpw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=r3A+7eRfDvBKHyYUPWc+GJ7pS8L/KWZXVM1Pf8myuqM=;
 b=JuXNN326MgyV+w9vKx8j+Mh4IMLR5QiKUt8WIqbeA1jcHF8vOoSBaXcfkrqI/6bI4NHaKPldUEoqtE6UfbyyEp6eHXFxZ3WQ5jnHnJC0FFaA0oUv2MXOAxWXW5t8jcqxx677hIGPRtG4mlpn5ennOe6l8TmUwcJSrLxE72Na9jNCmviLagxKv/X1316V2ecNzUmT1nBn8zO+XM0DvLH7trKtNrDyDyz68/i9GnNJ6obU8pdBbiC6s3vGxghJut8Pk2BuvxwGhkAdKXyOuemVDoB/W0RC4ASwf6TeaXGr8mQjFeWmQGLfZCDVZgJFzqt2kbFswXkURdETodFHCM/Ttw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=r3A+7eRfDvBKHyYUPWc+GJ7pS8L/KWZXVM1Pf8myuqM=;
 b=cT6yUGahEHcSmw0DCYcVGOfETlJoxFq5iecHkCNa52rjC481Yr2wZfrWb6I+C+4pM0N9m0AuDyjxW3NnQMVy90AKyD1gBRa/6Tny6nWZLWRm4fks7J34vHLKythP2xfRMVTQ1f607Qcu4gcUPWDTattiMf91VOAm9Nxhy+JSVTOzVIs0vRvqpoq/MN2KijRwbqdynWuOOAxv8/4+0eCC39S5glZZrEsIzU7YJyMh4UePO3QFjB9035B9j6iFJME/qAGgwzcJEOfWJTONtMa2bFkc2xngmrTqb2kv+3jxipNrrhBvBOgWEnhBjpWtNaZls3R0iD6OI0MzKroAd5eheA==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?=
	<roger.pau@citrix.com>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH 4/4] vpci: move lock outside of struct vpci
Thread-Topic: [PATCH 4/4] vpci: move lock outside of struct vpci
Thread-Index: AQHYF4hPRx/tX4vEOUaqhaVglKUz1ax//dWAgAAcC4CAAAM+gIAAAz8A
Date: Wed, 2 Feb 2022 11:26:26 +0000
Message-ID: <8830b7dc-f75b-25e4-c170-9351a4cd0139@epam.com>
References: <20220201162508.417008-1-andr2000@gmail.com>
 <20220201162508.417008-5-andr2000@gmail.com>
 <fc3df33c-d1e5-8c74-01e9-7ea7cea41521@suse.com>
 <e19a0f7a-651e-09a6-c03d-ea5286fe03ba@epam.com>
 <58209ef8-59e7-129d-c8d5-3edc975892ac@suse.com>
In-Reply-To: <58209ef8-59e7-129d-c8d5-3edc975892ac@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 307cc03e-24f3-4e16-9ebe-08d9e63eda04
x-ms-traffictypediagnostic: PA4PR03MB7120:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <PA4PR03MB712095CBB51F70777557D48FE7279@PA4PR03MB7120.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:6108;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 5Pa3c9R6a3z/B2qc1hHc/CnWA7vBvoqqzIjuspcP3TrWuG5LtNUbgjCpnwmr/toQRN2g4aJ6GUQJmlBQDqK/eNeYkzPV2/ZTH4DU/HYheLVVNqXle4usmG6lwrX6McrxkQ5z6vSXIiIUWZ/V0Q8SHz1U2otmgOCRHqX7mWJAPYyVUUIkiL+N2OoWcA8L05bgmdLz8bwnnwEQFYaf2pbUOwPXgpGjyi8jUN/7sjSuNqiJQ3XD/gIRo3mK8ddT8wvEJUy+zUq0O4f789OEvqfJQxvZxd9dN0XA2eOLEn0EMh0mKW5up51djY2/pKb0tM/tWVb6mrE554LeBHm7K45w+3YwRmi/wzEzTXOCGHGUSKyDFyWE6+0Y2T4sU8dq/5Wq1Zbf0OZkPIdB4F5dOITa/p0tPK+mGia8zTPFr9e71/pXrQVKc/0h7wyywztdt6sAisof76FxEHCBAItn2s0yPXfy5uj+hha2UfdRHHTQMpUyjKe2MqW8iTPkJTTL0g+3qs/ORu0n/xYKMXjmd+ZlreRRSoXExZ7Y1378suGuto4596ArT7dlnVUKzulfaDwO2FEn0AvGLXaUYI7eO3xoQlbHRaXcroqz91IAHMVcYS4/Aw6AaiZ6LjySwd4E8XKpG7GYSWCob/sXV/3HCrgv39WIa2GWfauSxOPe6+bzR5nCy6bKjWJ5MK9/qdFBLHhqbTdf01ugNSyepMUPOSt7Lyk8Sv0DUSJOE1WRGLj8c+ku6aKz+We1d7VZyxbRgzray5xnuHMr9ewwgkd//yuvICFwr3Z+6agmxg6OMX9mjnOjGRMjnIre5LM56RMQESbe
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(86362001)(38070700005)(71200400001)(83380400001)(53546011)(6506007)(31696002)(6916009)(2906002)(36756003)(6512007)(54906003)(966005)(316002)(4326008)(107886003)(66476007)(2616005)(66556008)(64756008)(186003)(8936002)(8676002)(76116006)(91956017)(122000001)(66946007)(508600001)(31686004)(7416002)(66446008)(5660300002)(6486002)(26005)(38100700002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?UGcxTlhJd2NFL0YyK0J3QWtOV2V4TDlGb1dFOVBVYzRMSk5VSHdsQm1lUGRR?=
 =?utf-8?B?QmJYYUlqV1JJaXRnZ1l4VW1VOTdkeFFYVkxFZlAyek9TK2xNL1gyWmRNSmEw?=
 =?utf-8?B?SG9ZT3NWakxmZWZoSzdSSVpBaFJCaS83clpvM1AwN0FJMHNxdlVqTjA3M0ZK?=
 =?utf-8?B?SnNXYUs1ZVFqek8xN0twTWpGMFVaZGZvVVppVWpNTWlJdGh1ZGxxS0lDalFr?=
 =?utf-8?B?bnBkcUpGNFVRYm9SeEZsUXpTbkR3aWFrQ055Qmx2bWtmcGtwV3F3cXZ0dHNP?=
 =?utf-8?B?WWN2WXBaSkY3SFdJdkxjWXpXWGNabk9QdVZIUEhjMS9JQ0RVQkJSdkhPRzNF?=
 =?utf-8?B?dVduYzNrNUNBZmlZOTlKM0FXelZWM0hKVUdBRXZZMmdxdUdESGNjMlF3YVNp?=
 =?utf-8?B?OG5FVGhTOTFlcDFRcGVZdU1mUEFDZE9DOWlid1hFZG95aStKNmVnZWNkM0RZ?=
 =?utf-8?B?VXZXaVBmMkFZU1NkOTNmd1BoVFRVdk1sTWRVUEFZSVpna05MRTBBOVZHcUpZ?=
 =?utf-8?B?dUtnME9qVmRHSmk5RGR5ZlRKWVhxbFVxeG1vU09xbEZhOENLRW8yM0lWM0VQ?=
 =?utf-8?B?cmVjQjhZbDltWFhaWmluQk9zSEZPK2NYVDE1VU91RXZodU5tNHJQK1YyWEN1?=
 =?utf-8?B?Q0RuUEdWdGJVckhHYmxNRmN5MklkU0RPcmRFTFlaeVZ6Q1Ntc0ZSaUMvSkFW?=
 =?utf-8?B?cHdoL2RBZHZ0cEpwQmdhajc4QTJTN0NmZXVTTTNNV0VlTmhtMytwSDZqSXJW?=
 =?utf-8?B?S0pPdHFueVVlZXlabEdtZ2JYQW0zSlhTM0RpY1BDL2ZvODhWd2l2ZkVDeWtN?=
 =?utf-8?B?a3oydlROcGJhNTQ5WTlPK1VXS0duRjBNM2hWVmdFblZZZzJGblBVeG5iN3B4?=
 =?utf-8?B?RkF6dFdVQnNsUzVLTEJ4SGFLZVRMdkxvVWlkV0hRMExuUFE4K2FkT0pxUDRv?=
 =?utf-8?B?YUNkdWFiYkxWMkxOSStGczg4dWlIdkhMYisra1B0WUN6anN4K0paMzYraUt6?=
 =?utf-8?B?RXhzRVZOSmI5d0d0czh3SXg3aWdKMjY2Qm5HN0tEdTF6VUJVR05oS253TVZT?=
 =?utf-8?B?SUFxTGk2VytHeEpXQzJPZXcxcE5YY0FPWlM4Z2Z1U3YvSHpVdW9jQ01uT3Jk?=
 =?utf-8?B?UGc1N0l2S2FjblpjRWhJODRHNlpHRkF4VDFrOGFLWnNZaTYxc2VIckp6bWxl?=
 =?utf-8?B?QjJoTjZMcitPaFVGZVo0TTZYOG5melJXdU5MSWV0VEsxTFJ0dTNpWTNmSW82?=
 =?utf-8?B?amdnTWM3VEQ3cjJ4THA2ZXloT1dHSHBHa0hXNFFOUW9HeVRWQ3RCUnhsNG5F?=
 =?utf-8?B?Vmo5OVZvRmRwVC95U3pDWWdnT3c0VkJFQzFJaStPd3hmSGE4b3ZEWkJ5QnpB?=
 =?utf-8?B?RmkweVd3eHdxWVBPSWd0eFNaMHNZeWsvVnVaWm9DU21VMU5GemZRRThpZ0I3?=
 =?utf-8?B?cEdCdEk0eGdBMktXNDZUWkZ4YnNMcGRSS3NJSnJhL0pBVDllZlRmVmxtY05w?=
 =?utf-8?B?Z1hzK3N6bTUySWxhTUNTdzFpYlR3TXRWdVFHOWdFWFpiWGRHdFNTUTJjeW5N?=
 =?utf-8?B?TW1oOVMzQ0gwaDVlVUY1N21jVnJuemZiR0JKbElsQkYrWlErcVdiRC9aYUdH?=
 =?utf-8?B?eUprRVRzV0Z0d2hLWWZlM2laUHRaMEhrdENzVjQ1OWZ4MktxVC9BZkJBdVJF?=
 =?utf-8?B?cFpsV2t4MjNLRzFhZ0Z5YmlxWjdGMFRuQmg2R3A0d2N0Y0JDNUVZVVhja3N2?=
 =?utf-8?B?UzZHa1RuYkxRTXdHQU45bHltNk5xNmsxaUEvS0wzWUR6UHozZk9pTWR3VzJl?=
 =?utf-8?B?OU1yTEUzVytHT3ZobDIyb0s1MzB3MStGUDd5ZlhJUjJQMGNtVU9NZjlXMEg4?=
 =?utf-8?B?RHFOeEplMWNXVWp2MWdTZ28ycUR0bXEzRTVjNjBhbEZMU1dBbUlORXc4VTQ2?=
 =?utf-8?B?R1pPcWxJTXJ1TXNDbkNMVWJhMWRUZ0pnRHZ0TDRmbUphanV2N21KbmQ5SkNH?=
 =?utf-8?B?YVNQSk55RldOWStHV0lOMHk3dExEMVQva2JvTk1pYXFNZ05GeS8yWkw0MXVt?=
 =?utf-8?B?WWc1aHJTbHBLWWlia2l4czFURlV3OU5VOE4zYVN2STFRNGhvbHU5RFp0Y1V3?=
 =?utf-8?B?ek4rMXI2OU4yQ0tGSmZSdW14QTRIT2NtMnFDTkFBQkRxeTZLWjM1dmd2UnFl?=
 =?utf-8?B?MERHd1VnL2x2bm1MUkR6SGtZZjNIRXdhN1dWN1pRVGhvVHFSbmNiNE1BaFpx?=
 =?utf-8?B?SDlqUnpLWVdLUnFpbTJKeWJGRDF4bGUybDZVNTN6ajV5aEpHdkNaZE5Ic2Vs?=
 =?utf-8?B?VXdvdmlkaURSazB1ZEVPM0NnekZOMXhQWkY1Q1ZCejZIMlByWXY4Zz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <0C44FA22FF59104CB120D48100AE2E23@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 307cc03e-24f3-4e16-9ebe-08d9e63eda04
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Feb 2022 11:26:26.9263
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: OpplnLo4gHYPbK4k0P0Buy6CKqnoxSVMTk9lmp7UrM2m97V80M9dWYlU31aGpuc3Aez/i555R4w+U/aSltFMGUE+N7OAZnH2wG47ZU6Qo8qI5SgX7SdfN/Eh6cHiWeyP
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR03MB7120
X-Proofpoint-GUID: aL2zA0VJhZohaI2iGqrwADLKvwqO1vsk
X-Proofpoint-ORIG-GUID: aL2zA0VJhZohaI2iGqrwADLKvwqO1vsk
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-02_05,2022-02-01_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 mlxscore=0
 mlxlogscore=843 suspectscore=0 phishscore=0 adultscore=0 impostorscore=0
 lowpriorityscore=0 priorityscore=1501 bulkscore=0 clxscore=1015
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202020060

DQoNCk9uIDAyLjAyLjIyIDEzOjE0LCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMDIuMDIuMjAy
MiAxMjowMywgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+PiBPbiAwMi4wMi4yMiAx
MToyMiwgSmFuIEJldWxpY2ggd3JvdGU6DQo+Pj4gT24gMDEuMDIuMjAyMiAxNzoyNSwgT2xla3Nh
bmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+Pj4+IEZyb206IFJvZ2VyIFBhdSBNb25uZSA8cm9n
ZXIucGF1QGNpdHJpeC5jb20+DQo+Pj4+DQo+Pj4+IFRoaXMgd2F5IHRoZSBsb2NrIGNhbiBiZSB1
c2VkIHRvIGNoZWNrIHdoZXRoZXIgdnBjaSBpcyBwcmVzZW50LCBhbmQNCj4+Pj4gcmVtb3ZhbCBj
YW4gYmUgcGVyZm9ybWVkIHdoaWxlIGhvbGRpbmcgdGhlIGxvY2ssIGluIG9yZGVyIHRvIG1ha2UN
Cj4+Pj4gc3VyZSB0aGVyZSBhcmUgbm8gYWNjZXNzZXMgdG8gdGhlIGNvbnRlbnRzIG9mIHRoZSB2
cGNpIHN0cnVjdC4NCj4+Pj4gUHJldmlvdXNseSByZW1vdmFsIGNvdWxkIHJhY2Ugd2l0aCB2cGNp
X3JlYWQgZm9yIGV4YW1wbGUsIHNpbmNlIHRoZQ0KPj4+PiBsb2NrIHdhcyBkcm9wcGVkIHByaW9y
IHRvIGZyZWVpbmcgcGRldi0+dnBjaS4NCj4+Pj4NCj4+Pj4gU2lnbmVkLW9mZi1ieTogUm9nZXIg
UGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+DQo+Pj4+IFNpZ25lZC1vZmYtYnk6IE9s
ZWtzYW5kciBBbmRydXNoY2hlbmtvIDxvbGVrc2FuZHJfYW5kcnVzaGNoZW5rb0BlcGFtLmNvbT4N
Cj4+Pj4gLS0tDQo+Pj4+IENjOiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXgu
Y29tPg0KPj4+PiBDYzogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KPj4+PiBDYzog
SnVsaWVuIEdyYWxsIDxqdWxpZW5AeGVuLm9yZz4NCj4+Pj4gQ2M6IFN0ZWZhbm8gU3RhYmVsbGlu
aSA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz4NCj4+Pj4gLS0tDQo+Pj4+IE5ldyBpbiB2NSBvZiB0
aGlzIHNlcmllczogdGhpcyBpcyBhbiB1cGRhdGVkIHZlcnNpb24gb2YgdGhlIHBhdGNoIHB1Ymxp
c2hlZCBhdA0KPj4+PiBodHRwczovL3VybGRlZmVuc2UuY29tL3YzL19faHR0cHM6Ly9sb3JlLmtl
cm5lbC5vcmcveGVuLWRldmVsLzIwMTgwNzE3MDk0ODMwLjU0ODA2LTItcm9nZXIucGF1QGNpdHJp
eC5jb20vX187ISFHRl8yOWRiY1FJVUJQQSFqbW1jZXdZNnk5VXI0cmd2T2dxc2N6OGdCV2FvZDJK
blFPa0h2V3RZS2ducWVVNkJvV0pUcUNOM1VEcEN3M2lvOFluay13QlhoQSQgW2xvcmVbLl1rZXJu
ZWxbLl1vcmddDQo+Pj4+DQo+Pj4+IENoYW5nZXMgc2luY2UgdjU6DQo+Pj4gVGhpcyBpcyBhIGxp
dHRsZSBvZGQgaW4gYSBzZXJpZXMgaW1wbGljaXRseSB0YWdnZWQgYXMgdjEuDQo+Pj4NCj4+Pj4g
LS0tIGEveGVuL2RyaXZlcnMvdnBjaS9oZWFkZXIuYw0KPj4+PiArKysgYi94ZW4vZHJpdmVycy92
cGNpL2hlYWRlci5jDQo+Pj4+IEBAIC0xNDIsMTIgKzE0MiwxMyBAQCBib29sIHZwY2lfcHJvY2Vz
c19wZW5kaW5nKHN0cnVjdCB2Y3B1ICp2KQ0KPj4+PiAgICAgICAgICAgIGlmICggcmMgPT0gLUVS
RVNUQVJUICkNCj4+Pj4gICAgICAgICAgICAgICAgcmV0dXJuIHRydWU7DQo+Pj4+ICAgIA0KPj4+
PiAtICAgICAgICBzcGluX2xvY2soJnYtPnZwY2kucGRldi0+dnBjaS0+bG9jayk7DQo+Pj4+IC0g
ICAgICAgIC8qIERpc2FibGUgbWVtb3J5IGRlY29kaW5nIHVuY29uZGl0aW9uYWxseSBvbiBmYWls
dXJlLiAqLw0KPj4+PiAtICAgICAgICBtb2RpZnlfZGVjb2Rpbmcodi0+dnBjaS5wZGV2LA0KPj4+
PiAtICAgICAgICAgICAgICAgICAgICAgICAgcmMgPyB2LT52cGNpLmNtZCAmIH5QQ0lfQ09NTUFO
RF9NRU1PUlkgOiB2LT52cGNpLmNtZCwNCj4+Pj4gLSAgICAgICAgICAgICAgICAgICAgICAgICFy
YyAmJiB2LT52cGNpLnJvbV9vbmx5KTsNCj4+Pj4gLSAgICAgICAgc3Bpbl91bmxvY2soJnYtPnZw
Y2kucGRldi0+dnBjaS0+bG9jayk7DQo+Pj4+ICsgICAgICAgIHNwaW5fbG9jaygmdi0+dnBjaS5w
ZGV2LT52cGNpX2xvY2spOw0KPj4+PiArICAgICAgICBpZiAoIHYtPnZwY2kucGRldi0+dnBjaSAp
DQo+Pj4+ICsgICAgICAgICAgICAvKiBEaXNhYmxlIG1lbW9yeSBkZWNvZGluZyB1bmNvbmRpdGlv
bmFsbHkgb24gZmFpbHVyZS4gKi8NCj4+Pj4gKyAgICAgICAgICAgIG1vZGlmeV9kZWNvZGluZyh2
LT52cGNpLnBkZXYsDQo+Pj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgcmMgPyB2LT52
cGNpLmNtZCAmIH5QQ0lfQ09NTUFORF9NRU1PUlkgOiB2LT52cGNpLmNtZCwNCj4+Pj4gKyAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAhcmMgJiYgdi0+dnBjaS5yb21fb25seSk7DQo+Pj4+ICsg
ICAgICAgIHNwaW5fdW5sb2NrKCZ2LT52cGNpLnBkZXYtPnZwY2lfbG9jayk7DQo+Pj4gV2hpbGUg
SSBjZXJ0YWlubHkgc2VlIHRoZSBwb2ludCwgdGhlIGFkZGl0aW9uIG9mIHRoaXMgaWYoKSAoYW5k
IGENCj4+PiBmZXcgbW9yZSBlbHNld2hlcmUpIGlzbid0IGNvdmVyZWQgYnkgdGl0bGUgb3IgZGVz
Y3JpcHRpb24uDQo+PiBUaGUgY29tbWl0IG1lc3NhZ2Ugc2F5czoNCj4+ICJUaGlzIHdheSB0aGUg
bG9jayBjYW4gYmUgdXNlZCB0byBjaGVjayB3aGV0aGVyIHZwY2kgaXMgcHJlc2VudCwgYW5kDQo+
PiByZW1vdmFsIGNhbiBiZSBwZXJmb3JtZWQgd2hpbGUgaG9sZGluZyB0aGUgbG9jaywgaW4gb3Jk
ZXIgdG8gbWFrZQ0KPj4gc3VyZSB0aGVyZSBhcmUgbm8gYWNjZXNzZXMgdG8gdGhlIGNvbnRlbnRz
IG9mIHRoZSB2cGNpIHN0cnVjdC4iDQo+PiBTbywgSSB0aGluayB0aGlzIGlzIGVub3VnaCB0byBk
ZXNjcmliZSB0aGUgZmFjdCB0aGF0IGFmdGVyIHlvdSBoYXZlIGxvY2tlZA0KPj4gdGhlIHByb3Rl
Y3RlZCBzdHJ1Y3R1cmUgbWF5IGhhdmUgZ29uZSBhbHJlYWR5IGFuZCB3ZSBuZWVkIHRvDQo+PiBy
ZS1jaGVjayBpdCBpcyBzdGlsbCBwcmVzZW50Lg0KPiBJJ20gYWZyYWlkIHRoYXQgdG8gbWUgImNh
biBiZSB1c2VkIiBkZXNjcmliZXMgZnV0dXJlIGJlaGF2aW9yLCBhcw0KPiBvcHBvc2VkIHRvIGUu
Zy4gImlzIHVzZWQiLiBJZiB5b3Ugd2FudCB0byBwb2ludCBvdXQgYm90aCBhc3BlY3RzLA0KPiBt
YXliZSAiLi4uIGNhbiBiZSB1c2VkIChhbmQgaW4gYSBmZXcgY2FzZXMgaXMgdXNlZCByaWdodCBh
d2F5KSAuLi4iPw0KVGhpcyBzb3VuZHMgZ29vZCB0byBtZSwgdGhhbmsgeW91IGZvciBzdWdnZXN0
aW5nIHRoYXQNCj4NCj4gSmFuDQo+DQoNClRoYW5rIHlvdSwNCk9sZWtzYW5kcg==


From xen-devel-bounces@lists.xenproject.org Wed Feb 02 11:45:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 11:45:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264085.457054 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFE4E-0003G5-9N; Wed, 02 Feb 2022 11:44:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264085.457054; Wed, 02 Feb 2022 11:44:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFE4E-0003Fy-5q; Wed, 02 Feb 2022 11:44:54 +0000
Received: by outflank-mailman (input) for mailman id 264085;
 Wed, 02 Feb 2022 11:44:53 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=CazJ=SR=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nFE4D-0003Fs-4o
 for xen-devel@lists.xenproject.org; Wed, 02 Feb 2022 11:44:53 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 87f84f96-841d-11ec-8eb8-a37418f5ba1a;
 Wed, 02 Feb 2022 12:44:51 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id C51F321114;
 Wed,  2 Feb 2022 11:44:50 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 83BBB13E14;
 Wed,  2 Feb 2022 11:44:50 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id kB23HrJu+mGbDwAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 02 Feb 2022 11:44:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 87f84f96-841d-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1643802290; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=cCSPusOGm6qPQ6mVAN8rR9lkFSLkMYCqcl/n5Rr3lnI=;
	b=p6cr4PmHDoyn2o76NcCOyKiI2xTkm8n9oIigkZn8lnqCWHzI5hpcp4q6hqbfG7BLs/lauF
	WUAYh0X+wAIDARY14nlAmuOel6ThxbGrWDFMAKjf/yR64Zks/RWRoqFdfooX9RXbd89mik
	SHJfwjFqgHqL6kPvyWVThm5kBeF51x4=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>
Subject: [PATCH] docs: document patch rules
Date: Wed,  2 Feb 2022 12:44:48 +0100
Message-Id: <20220202114448.8608-1-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Add a document to describe the rules for sending a proper patch.

As it contains all the information already being present in
docs/process/tags.pandoc remove that file.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 docs/process/sending-patches.pandoc | 284 ++++++++++++++++++++++++++++
 docs/process/tags.pandoc            |  55 ------
 2 files changed, 284 insertions(+), 55 deletions(-)
 create mode 100644 docs/process/sending-patches.pandoc
 delete mode 100644 docs/process/tags.pandoc

diff --git a/docs/process/sending-patches.pandoc b/docs/process/sending-patches.pandoc
new file mode 100644
index 0000000000..4cfc6e1a5b
--- /dev/null
+++ b/docs/process/sending-patches.pandoc
@@ -0,0 +1,284 @@
+# How a proper patch should look like
+
+This is a brief description how a proper patch for the Xen project should
+look like. Examples and tooling tips are not part of this document, those
+can be found in the
+[Xen Wiki](https://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches).
+
+## The patch subject
+
+The first line at the top of the patch should contain a short description of
+what the patch does, and hints as to what code it touches. This line is used
+as the **Subject** line of the mail when sending the patch.
+
+The hint which code is touched us usually in form of a relative path inside
+the Xen git repository, where obvious directories can be omitted or replaced
+by abbreviations, or it can be a single word describing the topic:
+
+    <path>: <description>
+
+E.g.:
+
+    xen/arm: increase memory banks number define value
+    tools/libs/evtchn: Deduplicate xenevtchn_fd()
+    MAINTAINERS: update my email address
+    build: correct usage comments in Kbuild.include
+
+The description should give a rough hint *what* is done in the patch.
+
+The subject line should in general not exceed 80 characters. It must be
+followed by a blank line.
+
+## The commit message
+
+The commit message is free text describing *why* the patch is done and
+*how* the goal of the patch is achieved. A good commit message will describe
+the current situation, the desired goal, and the way this goal is being
+achieved. Parts of that can be omitted in obvious cases.
+
+In case additional changes are done in the patch (like e.g. cleanups), those
+should be mentioned.
+
+When referencing other patches (e.g. `patch xy introduced a bug ...`) those
+patches should be referenced via their commit id (at least 12 digits) and the
+patch subject:
+
+    Commit 67d01cdb5518 ("x86: infrastructure to allow converting certain
+    indirect calls to direct ones") introduced a bug ...
+
+The following ``git config`` settings can be used to add a pretty format for
+outputting the above style in the ``git log`` or ``git show`` commands:
+
+        [core]
+                abbrev = 12
+        [pretty]
+                fixes = Fixes: %h (\"%s\")
+
+Lines in the commit message should not exceed 75 characters, except when
+copying error output directly into the commit message.
+
+## Tags
+
+Tags are entries in the form
+
+    Tag: something
+
+In general tags are added in chronological order. So a `Reviewed-by:` tag
+should be added **after** the `Signed-off-by:` tag, as the review happened
+after the patch was written.
+
+Do not split a tag across multiple lines, tags are exempt from the
+"wrap at 75 columns" rule in order to simplify parsing scripts.
+
+### Taken-from:
+
+Xen has inherited some source files from other open source projects. In case
+a patch modifying such an inherited file is taken from that project (maybe in
+modified form), the `Taken-from:` tag specifies the source of the patch:
+
+    Taken-from: <repository-URL> <commit-id>
+
+E.g.:
+
+    Taken-from: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git f093b08c47b3
+
+All tags **above** the `Taken-from:` tag are from the original patch (which
+should all be kept), while tags **after** `Taken-from:` are related to the
+normal Xen patch process as described here.
+
+### Fixes:
+
+If your patch fixes a bug in a specific commit, e.g. you found an issue using
+``git bisect``, please use the `Fixes:` tag with the first 12 characters of
+the commit id, and the one line summary.
+
+    Fixes: <commit-id> ("<patch-subject>")
+
+E.g.:
+
+    Fixes: 67d01cdb5518 ("x86: infrastructure to allow converting certain indirect calls to direct ones")
+
+### Backport:
+
+A backport tag is an optional tag in the commit message to request a
+given commit to be backported to the released trees:
+
+    Backport: <version> [# <comment>]
+
+E.g.:
+
+    Backport: 4.9+
+
+It marks a commit for being a candidate for backports to all released
+trees from 4.9 onward.
+
+The backport requester is expected to specify which currently supported
+releases need the backport; but encouraged to specify a release as far
+back as possible which applies. If the requester doesn't know the oldest
+affected tree, they are encouraged to append a comment like the
+following:
+
+    Backport: 4.9+ # maybe older
+
+Maintainers request the Backport tag to be added on commit. Contributors
+are welcome to mark their patches with the Backport tag when they deem
+appropriate. Maintainers will request for it to be removed when that is
+not the case.
+
+Please note that the Backport tag is a **request** for backport, which
+will still need to be evaluated by the maintainers. Maintainers might
+ask the requester to help with the backporting work if it is not
+trivial.
+
+### Reported-by:
+
+This optional tag can be used to give credit to someone reporting an issue.
+It is in the format:
+
+    Reported-by: name <email@domain>
+
+E.g.:
+
+    Reported-by: Jane Doe <jane.doe@example.org>
+
+As the email address will be made public via git, the reporter of an issue
+should be asked whether he/she is fine with being mentioned in the patch.
+
+### Suggested-by:
+
+This optional tag can be used to give credit to someone having suggested the
+solution the patch is implementing. It is in the format:
+
+    Suggested-by: name <email@domain>
+
+E.g.:
+
+    Suggested-by: Jane Doe <jane.doe@example.org>
+
+As the email address will be made public via git, the reporter of an issue
+should be asked whether he/she is fine with being mentioned in the patch.
+
+### Signed-off-by:
+
+This mandatory tag specifies the author(s) of a patch (for each author a
+separate `Signed-off-by:` tag is needed). It is in the format:
+
+    Signed-off-by: name <email@domain>
+
+E.g.:
+
+    Signed-off-by: Jane Doe <jane.doe@example.org>
+
+The author must be a natural person (not a team or just a company) and the
+`Signed-off-by:` tag must include the real name of the author (no pseudonym).
+
+By signing the patch with her/his name the author explicitly confirms to have
+made the contribution conforming to the `Developer's Certificate of Origin`:
+
+    Developer's Certificate of Origin 1.1
+    
+    By making a contribution to this project, I certify that:
+    
+    (a) The contribution was created in whole or in part by me and I
+        have the right to submit it under the open source license
+        indicated in the file; or
+    
+    (b) The contribution is based upon previous work that, to the best
+        of my knowledge, is covered under an appropriate open source
+        license and I have the right under that license to submit that
+        work with modifications, whether created in whole or in part
+        by me, under the same open source license (unless I am
+        permitted to submit under a different license), as indicated
+        in the file; or
+    
+    (c) The contribution was provided directly to me by some other
+        person who certified (a), (b) or (c) and I have not modified
+        it.
+    
+    (d) I understand and agree that this project and the contribution
+        are public and that a record of the contribution (including all
+        personal information I submit with it, including my sign-off) is
+        maintained indefinitely and may be redistributed consistent with
+        this project or the open source license(s) involved.
+
+### Reviewed-by:
+
+A `Reviewed-by:` tag can only be given by a reviewer of the patch. With
+responding to a sent patch adding the `Reviewed-by:` tag the reviewer
+(which can be anybody) confirms to have looked thoroughly at the patch and
+didn't find any issue (being it technical, legal or formal ones). If the
+review is covering only some parts of the patch, those parts can optionally
+be specified (multiple areas can be covered with multiple `Reviewed-by:`
+tags). It is in the format:
+
+    Reviewed-by: name <email@domain> [# area]
+
+E.g.:
+
+    Reviewed-by: Jane Doe <jane.doe@example.org>
+    Reviewed-by: Jane Doe <jane.doe@example.org> # xen/x86
+
+In case a patch is being resent an already given `Reviewed-by:` tag can and
+should be included, if the patch didn't change the portions of the patch
+covered by the tag, or if the reviewer already made clear it would be fine
+to make specific changes and no *other* changes have been made.
+
+### Acked-by:
+
+Similar to `Reviewed-by:` the `Acked-by:` tag is given by someone having looked
+at the patch. The `Acked-by:` tag can only be given by a **maintainer** of the
+modified code, and it only covers the code the maintainer is responsible for.
+For this reason there is no optional area possible. With the `Acked-by:` tag
+the maintainer states, that he/she is fine with the changes in principle, but
+didn't do a thorough review. The format is:
+
+    Acked-by: name <email@domain>
+
+E.g.:
+
+    Acked-by: Jane Doe <jane.doe@example.org>
+
+Including the `Acked-by:` tag in a patch is done under the same rules as for
+the `Reviewed-by:` tag, with the implied code area the maintainer who gave the
+`Acked-by:` tag is responsible for.
+
+### Tested-by:
+
+The `Tested-by:` tag is another tag given by someone else. The one giving it
+confirms to have tested the patch without finding any functional issues. The
+format is:
+
+    Tested-by: name <email@domain> 
+
+E.g.:
+
+    Tested-by: Jane Doe <jane.doe@example.org>
+
+Including the `Tested-by:` tag in a patch is done under the same rules as for
+the `Reviewed-by:` tag, now limited to the patch not having been modified
+regarding code logic (having changed only coding style, comments, or message
+texts is fine).
+
+## Patch version history (change log), further comments
+
+When sending revised versions of a patch it is good practice to include a
+change log after a line containing only `---` (this line will result in the
+following text not being included in the commit message). This change log
+will help reviewers to spot which parts of the patch have changed. Attributing
+changes due to reviewer comments will help the reviewer even more, e.g.:
+
+    ---
+    Changes in V2:
+    - changed function foo() as requested by Jane Doe
+    - code style fixed
+
+In some cases it might be desirable to add some more information for readers
+of the patch, like potential enhancements, other possible solutions, etc.,
+which should not be part of the commit message. This information can be
+added after the `---` line, too.
+
+## Recipients of the patch
+
+A patch should always be sent **to** the xen-devel mailing list <xen-devel@lists.xenproject.org> and all maintainers of all touched code areas should get a
+copy of the mail via **Cc**. In case some other recipients are known to be
+interested in the patch, they can be added via **Cc**, too.
diff --git a/docs/process/tags.pandoc b/docs/process/tags.pandoc
deleted file mode 100644
index 1841cb87a8..0000000000
--- a/docs/process/tags.pandoc
+++ /dev/null
@@ -1,55 +0,0 @@
-Tags: No line splitting
------------------------
-Do not split a tag across multiple lines, tags are exempt from the
-"wrap at 75 columns" rule in order to simplify parsing scripts.  For
-example:
-
-        Fixes: 67d01cdb5518 ("x86: infrastructure to allow converting certain indirect calls to direct ones")
-
-
-Fixes Tag
----------
-
-If your patch fixes a bug in a specific commit, e.g. you found an issue using
-``git bisect``, please use the 'Fixes:' tag with the first 12 characters of
-the SHA-1 ID, and the one line summary.
-
-The following ``git config`` settings can be used to add a pretty format for
-outputting the above style in the ``git log`` or ``git show`` commands:
-
-        [core]
-                abbrev = 12
-        [pretty]
-                fixes = Fixes: %h (\"%s\")
-
-
-Backport Tag
-------------
-
-A backport tag is an optional tag in the commit message to request a
-given commit to be backported to the released trees:
-
-    Backport: 4.9+
-
-It marks a commit for being a candidate for backports to all released
-trees from 4.9 onward.
-
-The backport requester is expected to specify which currently supported
-releases need the backport; but encouraged to specify a release as far
-back as possible which applies. If the requester doesn't know the oldest
-affected tree, they are encouraged to append a comment like the
-following:
-
-    Backport: 4.9+ # maybe older
-
-Maintainers request the Backport tag to be added on commit. Contributors
-are welcome to mark their patches with the Backport tag when they deem
-appropriate. Maintainers will request for it to be removed when that is
-not the case.
-
-Please note that the Backport tag is a **request** for backport, which
-will still need to be evaluated by the maintainers. Maintainers might
-ask the requester to help with the backporting work if it is not
-trivial.
-
-When possible, please use the Fixes tag instead (or in addition).
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Wed Feb 02 11:53:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 11:53:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264093.457064 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFECU-0004l9-79; Wed, 02 Feb 2022 11:53:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264093.457064; Wed, 02 Feb 2022 11:53:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFECU-0004l2-3i; Wed, 02 Feb 2022 11:53:26 +0000
Received: by outflank-mailman (input) for mailman id 264093;
 Wed, 02 Feb 2022 11:53:25 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=pBNc=SR=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nFECT-0004kw-3q
 for xen-devel@lists.xenproject.org; Wed, 02 Feb 2022 11:53:25 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b7cedd2c-841e-11ec-8f75-fffcc8bd4f1a;
 Wed, 02 Feb 2022 12:53:23 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b7cedd2c-841e-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1643802802;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=O/6X3jHKLr8LTR8yzsrI6ghWjdK/+KOdEFRkyxZnB68=;
  b=QV8P+UscRfPWRsKfI8wtYsLL76Jl1PqRBXWsoklRwhtQNvDrQfB1PDl5
   Y8E9pVUdqFV8l9zpIbRbOyAcrGL9+pit5LTtI4YcP2zaCyCevvWgj8Icu
   P7vt4JpmpZZbUyXrfd9a+Mx0izrc2Fpnu/6kDj0tLSEKBoA+WXwPVjwZB
   Y=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: 2GbORDwZQW+g0RHvpGJA2HQ7HnV5DA4zvdQo8KB/kEgA8DQgt0dUgmGgQ1S6UdmsPjX+wZGbRq
 kqrF5YfFWRwTnAGMqh9wlckqL0slBSQyam5W/yVua4LpwtUbu2kfY4fKcbWafRdx8yfH2dFMf2
 xY8LCi0j3i39lYp0sjhQZpIaw0gIxQfM4AsA6Qbq2tA2861mk5G+EJzkjOddHo37pjWwoJiHiZ
 9bTqXUKNsna3D8lgBG3yHJ87lAnYW7M1uw0ElCiExjvoBhqf12EpXjS788AogJlIba9qPcx3c6
 WiqxgdSX2snbdlCJFoYFeQNS
X-SBRS: 5.2
X-MesageID: 63718401
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:pp51uK6GdWpmhPOrdOb0qAxRtMPAchMFZxGqfqrLsTDasY5as4F+v
 jAXXT2COq7bYDT3eopzPoTl9xlXuJ/SmN9lHFc+qS9gHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FV8MpBsJ00o5wbZj2tQw2LBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z6
 9sd6Ja/GToVGu7cncUbeSdEGRt+BPgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALJc/3PIQZqzd4wCvQF/oOSpHfWaTao9Rf2V/cg+gQRqmHN
 5ZBMFKDajzBXR5LNAoNDKlmv+usg2bRQmZTi0C88P9fD2/7k1UqjemF3MDuUt6ASNhRn02Yj
 nnb5Gm/CRYfXPSd1D6E/3SEluLJ2yThV+o6D6ak//RnhFmSwG07CxAMU1a/5/6jhSaWWd1FL
 FcP0jEztqV0/0uuJvHtUhv9rHOasxo0X9tLD/Z8+AyL0rDT4QuSGi4DVDEpQMMinN87Q3otz
 FDhoj/yLWUx6vvPEyvbr+rK62PpUcQIEYMcTQwKHVYP7InenKVwnhfuSPxdDKSPjuSgTFkc3
 Au2hCQ5grwSi+sC2KO64U3LjlqQm3TZcuImzl6JBzz4t2uVcKbgPtX1sgaDsZ6sOa7EFgHpg
 ZQSpySJAAni57mpnTfFfugCFarBCx2tYGyF2g4H83XMGl2QF5+fkWJ4vGAWyKRBaJ9sldrVj
 Kj74ls52XOrFCH2BZKbmqroYyjQ8YDuFM7+StffZcdUb556eWevpX8yPhHMhjG8zRFywcnT3
 Kt3lu73VR4n5VlPlmLqF4/xL5d3rszB+Y8jbc+ilEn2uVZvTHWUVa0EIDOzghMRt8u5TPHu2
 48HbaOikkwHOMWnO3W/2dNNcTgicCZqbbir+50/XrPSeWJORTB+Y8I9NJt8IeSJaYwPyLeRl
 px8M2cFoGfCaYrvclTXMy0zNe+0AP6SbxsTZEQRALph4FB7Ca7H0UvVX8JfkWAP+LMxwPhqY
 eMCfsncUP1DRi6eo2YWbIXnrZwkfxOu3FrcMy2gaTk5XphhWw2WpYO0IlqxrHEDXnitqM8zg
 7y8zQeHE5ANcBtvUZTNY/W1wlLv4XVEwLBuX1HFK8V4cVn39NQ4MDT4i/I6epleKRjKyjaA+
 RyRBBMU+bvEr4MvqYGbjqGYtYa5VeB5GxMCTWXc6L+3Mwjc/3aintAcALrZI2iFWTqtqqu4Z
 OhTw/XtC9E9nQ5H49hmDrJm7aMi/N+z9bVU+RtpQSfQZFOxB7I+fnTfhZtTtrdAz6NysBetX
 h7d4cFTPLiENZ+3EFMVIwZ5PO2P2etNx2vX5PUxZk77+DV27PyMVkALZ0uAjylULb1UNoI5w
 Lh+5J5KulLn0hd6YMybii109niXKi1SWqoqgZgWHYv3h1d50VpFe5HdVnf77Zznhw+g6aX2z
 ut4XJb/uok=
IronPort-HdrOrdr: A9a23:syhGfKCRCGvr6v/lHegosceALOsnbusQ8zAXPh9KJiC9I/b1qy
 nxppkmPEfP+U4ssQIb6Ku90ci7MDjhHPtOj7X5Uo3SOjUO1FHYT72KjrGSiQEIeReOj9K1vJ
 0IG8MVab3N5DBB/ILHCWKDYrMdKay8gceVbJDlvhNQpG9RGsNdxjY8LjzePlx9RQFAC5Z8Po
 Gb/NB7qz2pfmlSRtinB1EeNtKz6uHjpdbDW1orFhQn4A6BgXeD87jhCSWV2R8YTndm3aoiy2
 7YiAb0j5/T/81TiyWsmFM73a4m2ecJ+eEzRPBkTfJlaQkEvzzYKriJnYfy/gzd7tvfrWrC2+
 O82SvId/4Dlk85OFvF5icEn2LboXATAjbZuCOlqGqmrsrjSD0gDc1dwYpfbxvC8kIl+Mpxya
 RRwguixuxq5D777VDADuLzJmZXf4uP0AofuP9Wi2YaXZoVabdXo4Ba9ERJEI0YFCa/7Iw8Cu
 FhAMzV+f4TKDqhHjjkl3gqxMbpUmU4Hx+ATERHssuJ0yJOlHQ8y0cD3sQQknoJ6Zp4QZhZ4O
 bPNLhuidh1P4YrRLM4AP1ETdq8C2TLTx6JOGWOIU7/HKVCIH7Jo46f2sRB2AhrQu178HIfou
 W+bLpojx9AR6u1M7zw4HRiyGG9fFmA
X-IronPort-AV: E=Sophos;i="5.88,336,1635220800"; 
   d="scan'208";a="63718401"
Date: Wed, 2 Feb 2022 11:53:16 +0000
From: Anthony PERARD <anthony.perard@citrix.com>
To: Juergen Gross <jgross@suse.com>
CC: <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, "Jan
 Beulich" <jbeulich@suse.com>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>
Subject: Re: [PATCH 0/5] tools: remove include/xen-external directory
Message-ID: <YfpwrHRwcHQHFyw0@perard>
References: <20220130084343.19070-1-jgross@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220130084343.19070-1-jgross@suse.com>

On Sun, Jan 30, 2022 at 09:43:38AM +0100, Juergen Gross wrote:
> The tools/include/xen-external directory contains a header file from
> FreeBSD used to generate Xen header files. This series is replacing the
> complete directory by a single header with the same semantics.
> 
> Juergen Gross (5):
>   tools/libs/light: replace _libxl_list.h with _xen_list.h
>   tools/libs/toolcore: replace _xentoolcore_list.h with _xen_list.h
>   tools/libs/evtchn: use _xen_list.h
>   tools/include: remove xen-external directory
> 
>  tools/include/_xen_list.h                     |  523 +++++++++
>  tools/include/libxl.h                         |    4 +-

Hi,

While this looks like a good cleanup, I'm not sure whether this is a
good idea with regards to the change in libxl's public headers.

The LIBXL_TAILQ_* macro are exposed via libxl.h, and it seems that using
`libxl_event.link` is explicitly allowed (via "libxl_types.idl") to make
a list of event in a application. But there isn't really a reason to use
the macro.

I didn't find any use of the macros in libvirt, so maybe it's fine to
change it?

What do people think?

Cheers,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Wed Feb 02 12:13:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 12:13:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264101.457076 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFEVj-0007AU-WC; Wed, 02 Feb 2022 12:13:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264101.457076; Wed, 02 Feb 2022 12:13:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFEVj-0007AN-TD; Wed, 02 Feb 2022 12:13:19 +0000
Received: by outflank-mailman (input) for mailman id 264101;
 Wed, 02 Feb 2022 12:13:18 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HAZh=SR=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nFEVi-0007AH-AO
 for xen-devel@lists.xenproject.org; Wed, 02 Feb 2022 12:13:18 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7f7fd35e-8421-11ec-8eb8-a37418f5ba1a;
 Wed, 02 Feb 2022 13:13:16 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7f7fd35e-8421-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1643803996;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=5VSuoYYIRLnkthysacxmvjpKuvKYPQAjYtm5ea8sqoY=;
  b=NdA98NMD9woS614NldH8+cZ8ePKT/pxMyjvXZOsrKNSGpkXZ0GG8k48B
   D5MmpqmqQYFhgVMT8ZeBrpAkBL6EuC8b8yewsa49gSFwxbA277cUi/E90
   6WvTSdarpSeq4ddFuNRAcQl3vM5lv3MYSv9vKphkGkHflzjTQz3npSq3U
   g=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: NutfG0mFnQDs/QMpkKUbO/t0aahJKnxr453SVZ4IoVYmkUQsqT9CTzC0KWU30NViCNHKHFWDtJ
 HQkyBBYep9uk2Pq4TKwKytiHdNVHdd9Rtw4r1tjMPC9c8umaB4pNCm27u5H9dCVoKyVPCVP33R
 kFJ6UseTiD3UhrsQhS79rSOiDw+LeoYA9WVIpUIaUkRgTwFBsI5pa6EncLFEXSupiaICO4sTRM
 I+/XC7oIJ/t4v9ZWsx9Im0w9WHrS/ITQ8261hiDbkL5KwfDukScFnZnm67VgA3nq85nLWbd11m
 LC2E7kZ9/1e34iRZhQ2SY2bQ
X-SBRS: 5.2
X-MesageID: 63719973
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:y+pM9KqnHatkz2GuNsUJIfxPNJ9eBmKQYhIvgKrLsJaIsI4StFCzt
 garIBmDa6mCN2P8eNtwO4rkpBhT65GDztYwSQdspSg2FyJE9JuZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlZT4vE2xbuKU5NTsY0idfic5Dndx4f5fs7Rh2NQw24DjW1rlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCnYPoW0QrOqzUosMmXiIBSS15I/Fe+KCSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFJkYtXx6iynQEN4tQIzZQrWM7thdtNs1rp4VQq+PN
 pVCAdZpREnaRC9/awtINMIdg/eSj0bjcWUEk3vA8MLb5ECMlVcsgdABKuH9YceWTM9YmkKZo
 GPu/GnjBBwectuFxlKt6nuxgsffkCW9X5gdfJWo+/gvjFCNy2g7DBwNSUD9sfS/klS5Wd9UN
 woT4CVGhao4+VGvT9L9dwalu3PCtRkZM/JPF8Uq5QfLzbDbiy6bG2wFQzhpeNEg8sgsSlQXO
 kShxo2zQ2Y16fvMFCzbpuz8QS6O1TY9MjcQJi0ATBM/xOLum9hpghXREs5jD/vg5jHqIg3Yz
 zePpSk4orwci88Xyqm2lWz6byKQSovhFVBsuFiONo6xxkYgPdP+OdT0gbTOxasYdO6kok+9U
 G/ociR0xMQHFtmzmSOEW43h95n5tq/eYFUwbbOCdqTNFghBGVb/LOi8AxkkfS+F1/ronheyO
 CfuVft5vsM7AZdTRfYfj3iNI8or17P8Mt/uS+rZaNFDCrAoKlPco303NB/Nhj69+KTJrU3YE
 czDGftA8F5AUfg3pNZIb7t1PUAXKtAWmjqIGMGTI+WP2ruCfn+FIYrpw3PVBt3VGJis+V2Pm
 /4GbpPi40wGDIXWP3eLmaZOcwFiBSVrVPje9p0MHsbec1UOJY3UI6KLqV/XU9Y7z/09eyah1
 izVZ3K0P3Kk1CCedFXXNis+AF4tNL4mxU8G0eUXFQ/A81AoYJq17bdZcJ0yfLI98/dkw+IyR
 P4AE/hsyNwWItge0zhCP5T7sqJ4cxGn2VCHMya/OWBtdJ98XQ3ZvNTje1K3piUJCyO2s+o4o
 qGhiVyHEcZSGVw6AZaEcu+rwnOwoWMZxLB4UXzXL4QBY07r6oVrdXD816dlP8EWJBzf7TKGz
 ALKUwwArOzArtZtotnEjKyJtamzFO56EhYIFmXX9+/uZyLb4nCi0clLV+PRJWLRU2b9+aODY
 +RJzq6jbK1bzQgS64clSuRl16Mz4dfrtoR29AU8ESWZdUmvB5NhPmKCgZtFuJpSy+ILogCxQ
 E+OpIVXYO3bJMP/HVcNDwM5deDfh+oMkzzf4PlpckX34Ch7oOiOXUlIZkTejSVcKP1+MZ8/w
 Pdns8kTslTthh0vO9eAryZV62XTcSBQD/R57skXUN3xlw4m6lBeepiNWCb57aaGZ8hILkR3c
 CSfg7DPhugEy0fPG5bp+aMhAQaJaUwyhS13
IronPort-HdrOrdr: A9a23:V3dF+K2Ex4KiutrO4GU8tAqjBVByeYIsimQD101hICG9Lfb2qy
 n+ppgmPEHP5Qr5OEtApTiBUJPwJk800aQFm7X5XI3SJzUO3VHHEGgM1/qB/9SNIVyaygcZ79
 YcT0EcMqyPMbEZt7eC3ODQKb9Jq7PmgcOVbKXlvg9QpGlRGt5dBmxCe2Cm+yNNNW177c1TLu
 vh2iMLnUvpRV0nKuCAQlUVVenKoNPG0LrgfB49HhYirC2Dlymh5rLWGwWRmk52aUIE/Z4StU
 z+1yDp7KSqtP+2jjfaym/o9pxT3P/s0MFKCsCggtUcbh/slgGrToJ8XKDqhkF/nMifrHIR1P
 XcqRYpOMp+r1vXY2GOuBPonzLt1T4/gkWSvmOwsD/Gm4jUVTg6A81OicZyaR3C8Xctu9l6ze
 Ziw3+Zn4A/N2KOoA3No/zzEz16nEu9pnQv1cQJiWZEbIcYYLhN6aQC4UJuFosaFi6S0vFqLA
 BXNrCc2B9qSyLbU5iA1VMfg+BEH05DUytue3Jy9PB8iFNt7TJEJ0hx/r1qop5PzuN5d3B+3Z
 W1Dk1frsA6ciYnV9MNOA4/e7rFNoXse2O7DIvAGyWvKEk4U0i92aIfpo9FoN2XRA==
X-IronPort-AV: E=Sophos;i="5.88,336,1635220800"; 
   d="scan'208";a="63719973"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=g9q+5JgozLD0V+8Vqc2X2ITwCtfBGz/GpTBy/8sJx1ThtzLN7I/3KaKn74/AfW+md1u7RmgFyshdxSLVIglgSqe69+HeZ8+D8/KSCGNxHre+8USwpATdghUl1e3xpiuzW+XBvWDCcM5QM6Vsx2HzxxR9mYHzl2THtYinct6nLqoARCRvzRK9GFsIATufx2vx19uMjGeLzOaWeNxVN4eyxqOpLprNAOQXeTykRXpdli/ojz/U/XJ83AILYmy+/BszH5qwz7CS5ztT0JI/Mkudgnrch4poSRSCxz3OhXv9R5RelzDLgl2ChAxGOOR5iIMKfrYunSft5HVyaw/VyF+oCg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=bH0J20QjsZiQMz+fLCrHrEdzdiz/5UYpEWCXb66QQYI=;
 b=PzgWFh25zV0LKhoJbf4uS+xtjSptqVFfcJeB3CcYB+Z+KCiThU3pzB5ZrIfWe3CrbeoMSuwdxZMgLmM6yw6WXph0D0sSjDHvAgfm9yYMJhSHi58ybQq9b4MquIZzOFYaQMz7dCy8vRGHFwW2ZNGbfYJ7z1MauIhDq5SqQYhBuH+SX+ElznGymNpVB78S0A5q91/fL5ApTp5Iq2mDJws5rTR+YVnixx2f6i6vbqpqPP9j0L89QcMXD+H1sKXrCE+Syy5Q+fuwgkIA/BHXm5e0OkRStAODqSRK8s3oq0PVVU+XArmFLt7e/UBn3ufKkPhpkxXPp1H84+ZFZMVSOSpKOQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=bH0J20QjsZiQMz+fLCrHrEdzdiz/5UYpEWCXb66QQYI=;
 b=LPIDKeWpp7dCkCopcwRjWJ/4X98ZTaV9ePUSScopPnFRkCixe3Kfx9mYoi1Jhun9PHR5sMX+/lb8X4q6HNCrJ2R+Zr2r3xamw0peYolxJKCgihqkIktYRGvu29DYVzvwCVO+VCcor3a2KB6iFyeMa/QMgQmk8ExZvjKtrvdCbM8=
Date: Wed, 2 Feb 2022 13:13:06 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>, George
 Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>, Stefano
 Stabellini <sstabellini@kernel.org>, Paul Durrant <paul@xen.org>,
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v3] xen/pci: detect when BARs are not suitably positioned
Message-ID: <Yfp1Unn9rIrwf78I@Air-de-Roger>
References: <20220201124551.2392-1-roger.pau@citrix.com>
 <59685ca1-0587-a975-bf5b-56058b650c3a@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <59685ca1-0587-a975-bf5b-56058b650c3a@suse.com>
X-ClientProxiedBy: LO4P123CA0024.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:151::11) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e116e578-5294-44ef-e027-08d9e645619d
X-MS-TrafficTypeDiagnostic: BL1PR03MB6133:EE_
X-Microsoft-Antispam-PRVS: <BL1PR03MB61335ED11C944E2852B765408F279@BL1PR03MB6133.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4125;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: s4LHKR45b3a99/+JyEEN8RESvHW7Rghp/MysPVSbiXoqrWNo2S2xQkvlu/O/KMwqMp+A9O4lJb0L8ANfrfL/5Yqsf6uLvVAyDIhPGNJ9bxUZNOI387Q1Kmh6Co+os5Zvf58dW2W6deB+fRyL6CnOhSmkPpFo7Tikimg7t/N3p2GhLt/MbLXGelo4in+PTsOj48hYONDDo9K592UxDEeOsVqR8m/His5NeDfJmKULCqUm0NKM329NHP2wEnpihRyTrDHSqAjuazfAmje1+x9BVLZvLtbo6xG1g4zW9gwAHvDX3Cqdmzf4wWz3/d883X/u+7lLhvxQupEwwBBcKdQ0EdoWbvR7IkbxvLjr2NmuRz/ghmBH5SKL1SGhXwIu9Pj4Lm3Rsv5XWvAo0I0xN9Ftuf8bVJiFllHtl1mYgsPX2iiRZMbBafK7ZTVekTOUyD3gmFS4tpqjexLE1cQk7+j17mnmPK4LcJm4LYUmRHovAo7mmTEFoOBxNJsfSDbnDCX8uugsiMaUf4wOkN2cUgQD9K18rr3pWV21digF/Imynpa/qSl5NonsIYqVbs3876Rzs+sZlOs5ioT1O6OzMksjrfdjKBWjBexrha+zIm5TVRyKFfRSp+X0UaNbEJ9M8DaLS1ojZL0JsLk+EeeLT330dw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(66556008)(66476007)(8936002)(8676002)(54906003)(26005)(186003)(4326008)(6486002)(6916009)(33716001)(85182001)(86362001)(508600001)(66946007)(38100700002)(2906002)(53546011)(316002)(6506007)(6512007)(6666004)(9686003)(82960400001)(5660300002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NlBZSWJOMkV0Rnk1eHUxQ3Uwc1U3R3ZQQ2FuSEsySGQxVVM2Y1BSMUNBWmFI?=
 =?utf-8?B?eVVqQmh6eFFPaFFWdFRDa2JEVm14WWtWWEZxQUZLam0xNEJJd1B6Z0loZGtT?=
 =?utf-8?B?Y1hKSzc3L05ZN2JmWU9lSDFhQUVUMk0xUjlZRjB2NFhydjFoS0VyVWFsNG1B?=
 =?utf-8?B?RzJHRitTYVg2aktxYmRUZWh5OTJ2eWVGNU9CNHo2ODFFRS9FYk5HekVKcHAr?=
 =?utf-8?B?aWFpVUdESmp4dFZXajR1RnVlb0hpVEZTN09vTjFQZEpOcTlmblBMZ3BQZy9S?=
 =?utf-8?B?SzJqZGFpU0NMdVF5MFlaWkwyY0FPdlZUV0hNcVJHTDFyL3BoM0g4bmUvZUIx?=
 =?utf-8?B?ZzVYa2JjeUhNTlNXaWxzUSswQzhJVUUwUjg2MHIyQmw2bVp6Z0VncEhORHB1?=
 =?utf-8?B?YmwzOXYrazZMY0x2VFV3VTNUemtXTURoRDJaZXUyU1h5YmFrb1JyUW1IUEQy?=
 =?utf-8?B?a29pV3pnMzJ3T3dxaDJNSGs3Ky91aVpZQ3cxQ09RNzl1MHFId3pLb2p5a255?=
 =?utf-8?B?SVZpamF0Y0xvMUIyMVUxTXdka3RUWWRZVmJUQnllTDhhQ2d6N2xtOVFuMjJj?=
 =?utf-8?B?RHlwTDhCK0dacDhYYzhFSllPUGlkTXhlSzZLQlJHQW1Fa212aHV1RWUrMUdX?=
 =?utf-8?B?eml2UXZyTFZBVVNQUFgzZVpPU3ZMSEIyN1RtUnQ1M2g0ZUh5VU16bG9aQzVY?=
 =?utf-8?B?WStoV1R4M1lvYWtNVGg5eUttZlFPd1BkNkYwMGExOUo0cHBTMU5WcnYremVW?=
 =?utf-8?B?YnhMMDZpeHF3akVlWjI4cGo0NzUzZ3JiUjJGeXJIYzVGWldET2NZWklPR1Bo?=
 =?utf-8?B?WDMvSmZPR09Ec28xZDdPWTlaMmtRelpRVTQ1L1lIZlJmU2NDTlVzcDZlMzNo?=
 =?utf-8?B?Q1hBN2FyRnpBSkJEVjh6UEpEamtNZjdJeE5tZzdDQ3BtME5ZcHpVSklNbm1Z?=
 =?utf-8?B?NW1FT1dIdW9RZ0h3eFBqekNxby9zOUl0ajRBT2NIN3dMNGdFaHd1ZVBvYVRi?=
 =?utf-8?B?N2RUOUFoMzBsVjFyRjJ3ZUMxQnhQTzdabnJHRm9QUDNPVCtFQjJiYjk1NmRp?=
 =?utf-8?B?TnNxNysxSklFRXBzZmlWZmhweUVqZ2pPbnFDU3VEWHJoT2ZrOHg4cG95Uy9U?=
 =?utf-8?B?dVplbGdsRHdMZnFwUDFhZ0xtZ1dDL241ekpBdk9RY0ZBMGp1ZkpheVBMZFY2?=
 =?utf-8?B?Q0JxWnRqMG5uZXZRVEM0MEF6VThHQjBuZ2VnMG4zN1RHbVFDYmJHWjRmT3Ba?=
 =?utf-8?B?enFWQUJVSmFUUlRXQ09KajNJY3dYM01oVU8ySlB4aS94UlJmUHU4NStmRlBs?=
 =?utf-8?B?TVdrMEVXQXpDNUo4US9LNDlMcHRKbTNDWlZZY3Q4ZEFsVnRoVFBjZmxoZ2p1?=
 =?utf-8?B?N3ZDdkdoS25JelZub3hpcVFvYVM4M09FSThGblRvK0ZEWjhWUHJPaWJpNkdM?=
 =?utf-8?B?bnNCZkdmUjVwZWJXRDJ0WVFyVWFVMEI4RmVEbHhVRFY5ZHc2dUdJbmU4TnNV?=
 =?utf-8?B?aU01b2NndUZkRlZ3S3RmRTZBVU9jYmc0a0hXQUFuSW5COU5Hcno0QklkcWdh?=
 =?utf-8?B?aElueUNXUGp4eEdQWkJITDA3bEZCQVVIdXl2SkluQnliRjF1ZnBob3ROMlB4?=
 =?utf-8?B?aEVSOVFWS0QyejhSdlo5SUlpdFg2Q0tRZWlxcEZleW01LzNKZ1pJSXZwQU02?=
 =?utf-8?B?aHROY3JTMTV5cjIyczBhMkZEZGZIUXBjUWhFZDFPdU9LYXhOWkpPemlqWkdZ?=
 =?utf-8?B?T2VLT0tMZTQ0amtWa2FMU0Ztbi9FSTZOb1JJTG1XcVhPeGdjOHdRWGdBRyts?=
 =?utf-8?B?NGlMUDJWNnF5ck4yVFpFcEc2RThOT2xWZzh2b0NwUFBSczFLWW9HMGRMN3Y4?=
 =?utf-8?B?Rjk1Uy9XMC9oUFh6MFVxSmM3VlpnYnQwNTQweDFMaVQ1NEVraHFSYWhBZW9u?=
 =?utf-8?B?NG5XbmF0OVRtUHpXS1VZM05UUE1ldnRIWUpPUktMZlMyR0RJNVJwaFg3aWQx?=
 =?utf-8?B?aktIdkNFMlF6Nzh2N1BGUGlhUHl4Z0VvTzJsQUJ2alJvczFrempNMTVqYkNG?=
 =?utf-8?B?UVJsZ1cvREVVcWRJNXgzNE8xVkhQR2lsa0FQUExTQ0V2Z0RUckx0TEJUZ1hM?=
 =?utf-8?B?U1lpZnRUZlpYRWp0b29sMnNjUWFFMDZXc3NoOWs0OE5UczRFY2d4bkRxYWVm?=
 =?utf-8?Q?rTJHTO6m31tOgtp0cK41uNI=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e116e578-5294-44ef-e027-08d9e645619d
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2022 12:13:11.5753
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sPSo+FiZwxrs/woZXiCeX3zdkGriEwIzkGGJ7rWRtK5vg0lIofVxuoSvY4/Dl/CLYoIpErpu6Ykndw0YSCgAfA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR03MB6133
X-OriginatorOrg: citrix.com

On Wed, Feb 02, 2022 at 10:42:22AM +0100, Jan Beulich wrote:
> On 01.02.2022 13:45, Roger Pau Monne wrote:
> > --- a/xen/arch/x86/mm.c
> > +++ b/xen/arch/x86/mm.c
> > @@ -783,6 +783,23 @@ bool is_iomem_page(mfn_t mfn)
> >      return (page_get_owner(page) == dom_io);
> >  }
> >  
> > +bool is_memory_hole(unsigned long start, unsigned long end)
> > +{
> > +    unsigned int i;
> > +
> > +    for ( i = 0; i < e820.nr_map; i++ )
> > +    {
> > +        const struct e820entry *entry = &e820.map[i];
> > +
> > +        /* Do not allow overlaps with any memory range. */
> > +        if ( start < PFN_DOWN(entry->addr + entry->size) &&
> > +             PFN_DOWN(entry->addr) <= end )
> > +            return false;
> > +    }
> > +
> > +    return true;
> > +}
> 
> Doesn't the left side of the && need to use PFN_UP()?

Hm, I had is using PFN_UP before and switched to PFN_DOWN for some
weird reasoning.

> 
> I also think it would help if a brief comment ahead of the
> function said that the range is inclusive. Otherwise the use
> of < and >= gives the impression of something being wrong.
> Then again it may be better to switch to <= anyway, as I
> think you want to avoid possible zero-size regions (at which
> point subtracting 1 for using <= is going to be valid).

Right, so that would end up being:

start <= PFN_DOWN(entry->addr + entry->size - 1) &&

Rejecting entries with size == 0 beforehand.

> Finally I wonder whether the function parameters wouldn't
> better be named e.g. spfn and epfn, but maybe their units can
> be inferred from their types being unsigned long (which,
> however, would build on the assumption that we use appropriate
> types everywhere).

I guess I should switch to using mfn_t for the types and convert them
locally to unsigned long for the comparisons.

> > --- a/xen/include/xen/mm.h
> > +++ b/xen/include/xen/mm.h
> > @@ -554,6 +554,8 @@ int __must_check steal_page(struct domain *d, struct page_info *page,
> >  int page_is_ram_type(unsigned long mfn, unsigned long mem_type);
> >  /* Returns the page type(s). */
> >  unsigned int page_get_ram_type(mfn_t mfn);
> > +/* Check if a range falls into a hole in the memory map. */
> > +bool is_memory_hole(paddr_t start, uint64_t size);
> 
> While resolving to the same type, these now also want to be
> "unsigned long".

Doh, yes, sorry. Will convert them to mfn_t if we agree on that.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Feb 02 12:50:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 12:50:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264108.457087 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFF5U-0002lI-Re; Wed, 02 Feb 2022 12:50:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264108.457087; Wed, 02 Feb 2022 12:50:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFF5U-0002lB-OR; Wed, 02 Feb 2022 12:50:16 +0000
Received: by outflank-mailman (input) for mailman id 264108;
 Wed, 02 Feb 2022 12:50:15 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1p3Q=SR=epam.com=prvs=40324c57ab=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nFF5S-0002kz-Lt
 for xen-devel@lists.xenproject.org; Wed, 02 Feb 2022 12:50:14 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a854a65f-8426-11ec-8f75-fffcc8bd4f1a;
 Wed, 02 Feb 2022 13:50:11 +0100 (CET)
Received: from pps.filterd (m0174682.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 212CJYdf032376;
 Wed, 2 Feb 2022 12:50:07 GMT
Received: from eur02-am5-obe.outbound.protection.outlook.com
 (mail-am5eur02lp2057.outbound.protection.outlook.com [104.47.4.57])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3dysmcr5y3-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 02 Feb 2022 12:50:06 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by DB7PR03MB4363.eurprd03.prod.outlook.com (2603:10a6:10:17::10) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Wed, 2 Feb
 2022 12:49:36 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6%3]) with mapi id 15.20.4951.012; Wed, 2 Feb 2022
 12:49:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a854a65f-8426-11ec-8f75-fffcc8bd4f1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=YrTy+1XFG129aH20J/oCa99pd6EbH6lNb95YiJNYXw7FCxWUNl0l1sYxSb5ZZlJ3m8Rbiyk8/Ky/lrj4WOE0o4vv4beRb5XjZVm26Y4K/j/aicsXv8BbAIbzgYVmrehMVj6XiKOvbOFL2HCaKe5qV1/pV6BrRER/MRbBv4UZACPYVDRrwAfhfw/wTZT3y1K6c6HimPRXHWoJ9CTAIpUn0tpB1oOsaSPSblRTEo2CNkCjwIH1nKNbH8kFFFyv92TYy8xTPEndNX/KjXJsLjebiDdj9wLE/0A3vMprlphASte5tjzhLJ/0A7W25n8na5LqrmbfeFf2Bue0woLEB5m4Fw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=JdwM/IjxZ8Zh3OgHK1J9dw1fGKQCbiTgpygXmiWkaCQ=;
 b=dTehYAOxpOZejyLSzskBjc/tzhbrlpE28Vr22LzRcHiAmhIfv3lONJADe7SN0i2EoE/U+vTDkokUJ3vcp5CCORezAo+E6dn3xWoirG+IpJYaduj2N+4YPeeavyZZG1qd9669aoQrHtLy3ShOV8aMPew7fgdQJ44wkvfsFeEBv9TIZHPBWHVxcM4/wCRGIpbtat7jReEnHpyD/2Z5luGJn9PwxrMzYmi+B04wpIOi9rp7j6a48HDIFyCgQ0mLoDJ1qmFGGWEhjQaHZ+0ZUtIA1AXAyMdz022KqNdxBTPALFXJ7txoI1Ut1rwXN3yJn/2YzAbrushLqfNHjjlm7d88Ug==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=JdwM/IjxZ8Zh3OgHK1J9dw1fGKQCbiTgpygXmiWkaCQ=;
 b=h/Te4jx4+BGJrlTTnQAxaNXfBaojdI3PxAw783ykvS3C6Thi3orWQn6CBXEGc3Uaj/ysyshSUzi6d0DhFkcTG5y2uyjI9YJX8d4jSRvwCnoE1dL/gNA29HFkcmD7lvWQDGJZfEuji5Qvit6ZmDKo+//2wmUTQkWdc3WX9OfU4B7zxhEOSd8TXxcbQTOEViR/EMsQdz7YKAOXlnAEoyOlC4sUO9/Q9fxsSU1qxkdgHcn5zGFxnzfPwM2gLfZmD/QF+aKAdYf5yTxrmvn0c+D4hOt6WwAfCff60Qs5x3eScG8U1HlnO8iqLsxTeGJAGJJ6NwV1MYe6EOCpmc9rrZXURA==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "jbeulich@suse.com" <jbeulich@suse.com>,
        "andrew.cooper3@citrix.com"
	<andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com"
	<george.dunlap@citrix.com>,
        "paul@xen.org" <paul@xen.org>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>,
        Rahul Singh <rahul.singh@arm.com>,
        Oleksandr
 Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v5 09/14] vpci/header: emulate PCI_COMMAND register for
 guests
Thread-Topic: [PATCH v5 09/14] vpci/header: emulate PCI_COMMAND register for
 guests
Thread-Index: AQHX4ewK3mPSKCsK30iVfRQpWoVIB6xhEugAgB+P6YA=
Date: Wed, 2 Feb 2022 12:49:36 +0000
Message-ID: <6a31eb29-81b6-7553-897f-2e5e54bab9b8@epam.com>
References: <20211125110251.2877218-1-andr2000@gmail.com>
 <20211125110251.2877218-10-andr2000@gmail.com>
 <YeAD9PH9o65o+M+w@Air-de-Roger>
In-Reply-To: <YeAD9PH9o65o+M+w@Air-de-Roger>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: b9e70575-7ce8-4d81-7ce3-08d9e64a77d1
x-ms-traffictypediagnostic: DB7PR03MB4363:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <DB7PR03MB4363E0B86A55A9ECD465848FE7279@DB7PR03MB4363.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8882;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 lBrrSiW0ahkq3R1qOKhW5vU6OkTwnncuPWGVnJehetBISOtcWogWPnI11kNdQaweebyhn2ZVrX+QLh6NUjkMRnsnYIrOnqb4wRu8iTPO4G4YLrAjwavvFHPgFoFQdNqAJpo3+JJ2ciruD26tcB0vKaxXndM0cfsKdn9Zm+JhzBZGW3WDWNfJKWzLzERZ8Lqtvva0v/6YW1kix0K7KwdaYvRKD+sG3MmsGpFQhdipS1NbAIr24g7+n9E785pjx2THfgpa9D+KwF6MUBOSp4yb19cZvBTEtQCwgpAawUcxOMIg/L/uGMLwanxQRdtVINionQGFx45DZrYJxD69bs8Mdo2/B1SPC1SlUTUEoyP2GaMEnBofZJRxlfonoH1SCTWybrG/FbDvwsMzeNTy4wFcSQO6zcLem2PZlFYHujqkgxhDp1Ci3pbqU/PuQvFlo4z6auBbzmsedPe+OLP32aW2LFaO1MzSw6eulr5S6rSxEP9QYOxatz2NEHTzuaLzUcmwVDEFDdHPy9BGllrlQHvduNVj/9Tiflqc2rWxk5wza6dDotQ0HkZCik3fZ3QIddAZ1o0xDxNs8W1VucBqyK5KRWRox3AFd33Q4ReyASY76mersv94thGbh3waXrrX65kibK2/CL9FFUUxBNirItSSwv/qiFlXEU15FCMzFzMOWwi6E7t87KDbLh0OgyeHTKCbsfDXO6Y1JMuowTzR6FsHfSLVx61e5u1nKAMAyiWVtgI=
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(83380400001)(38070700005)(8676002)(186003)(26005)(4326008)(38100700002)(76116006)(8936002)(5660300002)(66946007)(54906003)(64756008)(66446008)(66476007)(91956017)(316002)(31686004)(6916009)(66556008)(7416002)(36756003)(122000001)(6512007)(53546011)(508600001)(2906002)(107886003)(86362001)(2616005)(71200400001)(31696002)(6486002)(6506007)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?RDJyNGFyR29uTEtrYm0ySkxyZnpmMzlTMzVFYkFKUDduMXhHRUJkaHJsUWM0?=
 =?utf-8?B?VGtsQXRMVE5Mc3dhQXNtemtxK2RaYXZHa2syczFkK0w5aHA5cXFGQ2ZWdjgr?=
 =?utf-8?B?K0pnKzNIMndHVFNKMWRCaWtZUzI1Sm8rZHhjS01FcC84dXRHYThuTTQ4Vklk?=
 =?utf-8?B?MXZmTVFrLzYyTmplcU5tSzh0TkNFblNjNDhQQWsxOEhweC8vSHEzdWRFVVND?=
 =?utf-8?B?eHFhRUdDVUVUaklhQnl5TU5LYXByTXBRQXAwNHVWWWRDV0w3SFUzY1lLZ1RB?=
 =?utf-8?B?bGtLVkFlb0VXanduZWUwWlM5NmpmNjlJb3JOcmtJN2kvUVBkNkRYT2JseVdu?=
 =?utf-8?B?R0lVeW84OEJIcVY4Y3VtZmdsNlVCb0x3bmFVZWhaaE5KLzl3RWt6YlgwdnRz?=
 =?utf-8?B?MkdLVTBsZytZV3FmQnp5NnhDaG5mK1dJR0cvR3B0VE8zaFQzdndLNU9YU1RO?=
 =?utf-8?B?QmE4Q2kwQzFiRk1vUVN3eXdKTmgvN0YvMVVCTUcyMFpMRDgyNGJFV1BINk9X?=
 =?utf-8?B?Q1l1V3FNUlN5eXBLZWh3eW96SHgxSW5tak9TMHU3RWxCRlpMbGN5THhKYTdk?=
 =?utf-8?B?N010RGNDck0wK2Y1TG4zNkJxbGhKcXZudEoySTU2WGdYRnkyNzBlbVZmeERi?=
 =?utf-8?B?dUxrTjlyRDZsVXViTmowdXRZQ1VxS0pMOG5aUUVTY2pqZVovUW80VTNhVGQr?=
 =?utf-8?B?SXRiMUQ5MXlGalJPeWU5Qm04L3FkZUEySHEvZzRQRmhHTU40OVJNQUgxeWlu?=
 =?utf-8?B?MWQvNFZmYjN2dTBUVEVKdDhjalAvelpSQWhiVnl0RnlJTmJyeUlkZDdGZ1c0?=
 =?utf-8?B?blVVK0tVMncrSDBQOVRDL2xuQmd1U3R4NEF0bVNneElKbVgvcjJXVzRQWUlm?=
 =?utf-8?B?VTdZMnJRNVFxdUVTSHBONEx0Ulo3cTZjRGZ3cVlMZERwZFh1N0w5eVZHU0Qx?=
 =?utf-8?B?cmI1bFlUcE5CVCtESUZtYnB2MU1wdnp3R2R0RmxxeEJDbWdnVjl3YVdKeitN?=
 =?utf-8?B?eGhIVVpyTmVvSTV2OEdTcGw0Wm9mZWg3dEx1TW1RZ2s4aGZ1TStPZlZkMG5O?=
 =?utf-8?B?YTI5dEZVU3FVWHJWbklMSGNaN3N5b2dPTVZXdDF6a0R6T0g4WnJJeXA3ckhx?=
 =?utf-8?B?Z2xwYmhPMnd3TU9XTWtUM3IwYTFuVHdmQnNnMCtzdW1waWRkTC96SFdjRHdV?=
 =?utf-8?B?VGM1bGFsa1d4cVNoV1YyT0kxM3ZjRWlvQ3R0aHBTRTNqTVZpa1JYZWlRMUV4?=
 =?utf-8?B?YzZ6YVN0TEJ5NlZaWmVsVHFvZ3N4Unp1OFNIcXFqMENCdHpGQXhzcWJNbWxn?=
 =?utf-8?B?NlVqWFF5VzBPc202Z3hIT0x6N3d0b1RGMTE2cEFHWnZ0NGlBbEJNemprUHdu?=
 =?utf-8?B?OUdCUGdUV01udEsxTUg5TXBad1ZwTmQ5RlJ1a29qMG1nT2dFdnJQaWRjRXV1?=
 =?utf-8?B?c0RERlJBVWNIY2o2S2lkb2xKUm1EQmszdGNoRVFTZWhKVkNGUUhWdE5zd1JP?=
 =?utf-8?B?SWR0Y3AwaXNaMlVPTjNzRTRPV3lyK2diUVl2Q2g1Uk1vQ3hQVmozbm1rajVW?=
 =?utf-8?B?TTlPdWxkOGpWMUNxRHFCeHh0OGROU1h2UncycHlEMk80b1VNVnNlSVo4T085?=
 =?utf-8?B?VHM0am1ZVGxycnBZY0szUG5jUkxaRnlMRWpNU28yVytnZzNvdm4xZXBZdnVK?=
 =?utf-8?B?NjczMkgxeUEyMVo5ZEc0ZHJ0eHhhSEVIRXpzSE91anYzTjdPcVI0dFZCVGpa?=
 =?utf-8?B?NFpKRGJwL2ZxbkFzMDlKQngzTnp1MVFMQys0NFp5OWw4a1lnZjQzQk44d3pW?=
 =?utf-8?B?eUlnekdiTEhRTEtra21KdUFWby9lQkR1akQ5UDQyak9zeU94MTJaN2hLOC9w?=
 =?utf-8?B?UFRmNnNEMDJxOHpBaS8rckIvWDVZUXY1MzBlRXIzNEc3RmxkQnlUNzBSczdU?=
 =?utf-8?B?eTNPZUxVRnFOZURvdWsxVUNzTStTL3pQZDFORVgxUVlTTkJyd1U5MWR5S2hj?=
 =?utf-8?B?azVEVHBDbmNnZ0lyVE5NQ094QXlhZGxRby8rM3VRdUc5Z0NoQ1I5WmVtVkpC?=
 =?utf-8?B?U0t0OFB3ZUNsZ2plYkY1OU9Xa0huNGlHUFdpVUFtenkvTTQ5UWdqajA0aEU2?=
 =?utf-8?B?OGxIdHRPU0x1S0FyVHEzd2p4RmhTb0hRalllQnlLWDZ5UWhPTkZDeXlMMkFx?=
 =?utf-8?B?aFVObVpXRXFNRDJMOXdXUCtxVmw0U0k2NVF0aVlOQitESCtMbVZZRE1vOFhZ?=
 =?utf-8?B?anEvdHN3ak5DaWh6SnlDTDNFTUNxcEtIWDNPVVVHZmlVVW1KN3ZoTS8vdGFl?=
 =?utf-8?B?WWtLOHk1WUVRa2FOejl0Mmo5ekFvUVFaekNJeWM5MmVjengwQ0ZqQT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <E7B351846772D947ABAA61F058C6E719@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b9e70575-7ce8-4d81-7ce3-08d9e64a77d1
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Feb 2022 12:49:36.0415
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: TTBYNhbE2Kp+MuI/dFYGFDUq5gpQkin1CvmwYT2zc+g2tzfux8YHxM77aeWdELUfc8czbzjJUb2LgnaQUDZcnfF1wfzeo0AUv2Ky+nqy/bapCeWavjqzbIqEjLXDM5s0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR03MB4363
X-Proofpoint-GUID: 967UGXEYKNpeqlTme2SzzMop4NpgsMux
X-Proofpoint-ORIG-GUID: 967UGXEYKNpeqlTme2SzzMop4NpgsMux
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-02_06,2022-02-01_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 mlxlogscore=999
 bulkscore=0 malwarescore=0 lowpriorityscore=0 suspectscore=0 phishscore=0
 mlxscore=0 priorityscore=1501 adultscore=0 impostorscore=0 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2202020070

SGksIFJvZ2VyIQ0KDQpPbiAxMy4wMS4yMiAxMjo1MCwgUm9nZXIgUGF1IE1vbm7DqSB3cm90ZToN
Cj4gT24gVGh1LCBOb3YgMjUsIDIwMjEgYXQgMDE6MDI6NDZQTSArMDIwMCwgT2xla3NhbmRyIEFu
ZHJ1c2hjaGVua28gd3JvdGU6DQo+PiBGcm9tOiBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyA8b2xl
a3NhbmRyX2FuZHJ1c2hjaGVua29AZXBhbS5jb20+DQo+Pg0KPj4gQWRkIGJhc2ljIGVtdWxhdGlv
biBzdXBwb3J0IGZvciBndWVzdHMuIEF0IHRoZSBtb21lbnQgb25seSBlbXVsYXRlDQo+PiBQQ0lf
Q09NTUFORF9JTlRYX0RJU0FCTEUgYml0LCB0aGUgcmVzdCBpcyBub3QgZW11bGF0ZWQgeWV0IGFu
ZCBsZWZ0DQo+PiBhcyBUT0RPLg0KPj4NCj4+IFNpZ25lZC1vZmYtYnk6IE9sZWtzYW5kciBBbmRy
dXNoY2hlbmtvIDxvbGVrc2FuZHJfYW5kcnVzaGNoZW5rb0BlcGFtLmNvbT4NCj4+IC0tLQ0KPj4g
U2luY2UgdjM6DQo+PiAtIGdhdGUgbW9yZSBjb2RlIG9uIENPTkZJR19IQVNfTVNJDQo+PiAtIHJl
bW92ZWQgbG9naWMgZm9yIHRoZSBjYXNlIHdoZW4gTVNJL01TSS1YIG5vdCBlbmFibGVkDQo+PiAt
LS0NCj4+ICAgeGVuL2RyaXZlcnMvdnBjaS9oZWFkZXIuYyB8IDIxICsrKysrKysrKysrKysrKysr
KystLQ0KPj4gICAxIGZpbGUgY2hhbmdlZCwgMTkgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMo
LSkNCj4+DQo+PiBkaWZmIC0tZ2l0IGEveGVuL2RyaXZlcnMvdnBjaS9oZWFkZXIuYyBiL3hlbi9k
cml2ZXJzL3ZwY2kvaGVhZGVyLmMNCj4+IGluZGV4IGIwNDk5ZDMyYzVkOC4uMmU0NDA1NTk0NmIw
IDEwMDY0NA0KPj4gLS0tIGEveGVuL2RyaXZlcnMvdnBjaS9oZWFkZXIuYw0KPj4gKysrIGIveGVu
L2RyaXZlcnMvdnBjaS9oZWFkZXIuYw0KPj4gQEAgLTQ5MSw2ICs0OTEsMjIgQEAgc3RhdGljIHZv
aWQgY21kX3dyaXRlKGNvbnN0IHN0cnVjdCBwY2lfZGV2ICpwZGV2LCB1bnNpZ25lZCBpbnQgcmVn
LA0KPj4gICAgICAgICAgIHBjaV9jb25mX3dyaXRlMTYocGRldi0+c2JkZiwgcmVnLCBjbWQpOw0K
Pj4gICB9DQo+PiAgIA0KPj4gK3N0YXRpYyB2b2lkIGd1ZXN0X2NtZF93cml0ZShjb25zdCBzdHJ1
Y3QgcGNpX2RldiAqcGRldiwgdW5zaWduZWQgaW50IHJlZywNCj4+ICsgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgdWludDMyX3QgY21kLCB2b2lkICpkYXRhKQ0KPj4gK3sNCj4+ICsgICAgLyog
VE9ETzogQWRkIHByb3BlciBlbXVsYXRpb24gZm9yIGFsbCBiaXRzIG9mIHRoZSBjb21tYW5kIHJl
Z2lzdGVyLiAqLw0KPj4gKw0KPj4gKyNpZmRlZiBDT05GSUdfSEFTX1BDSV9NU0kNCj4+ICsgICAg
aWYgKCBwZGV2LT52cGNpLT5tc2ktPmVuYWJsZWQgKQ0KPiBZb3UgbmVlZCB0byBjaGVjayBmb3Ig
TVNJLVggYWxzbywgcGRldi0+dnBjaS0+bXNpeC0+ZW5hYmxlZC4NCkluZGVlZCwgdGhhbmsgeW91
DQo+DQo+PiArICAgIHsNCj4+ICsgICAgICAgIC8qIEd1ZXN0IHdhbnRzIHRvIGVuYWJsZSBJTlR4
LiBJdCBjYW4ndCBiZSBlbmFibGVkIGlmIE1TSS9NU0ktWCBlbmFibGVkLiAqLw0KPj4gKyAgICAg
ICAgY21kIHw9IFBDSV9DT01NQU5EX0lOVFhfRElTQUJMRTsNCj4gWW91IHdpbGwgYWxzbyBuZWVk
IHRvIG1ha2Ugc3VyZSBQQ0lfQ09NTUFORF9JTlRYX0RJU0FCTEUgaXMgc2V0IGluIHRoZQ0KPiBj
b21tYW5kIHJlZ2lzdGVyIHdoZW4gYXR0ZW1wdGluZyB0byBlbmFibGUgTVNJIG9yIE1TSVggY2Fw
YWJpbGl0aWVzLg0KSXNuJ3QgaXQgZW5vdWdoIHRoYXQgd2UganVzdCBjaGVjayBhYm92ZSBpZiBN
U0kvTVNJLVggZW5hYmxlZCB0aGVuIG1ha2UNCnN1cmUgSU5UWCBkaXNhYmxlZD8gSSBhbSBub3Qg
Zm9sbG93aW5nIHlvdSBoZXJlIG9uIHdoYXQgZWxzZSBuZWVkcyB0bw0KYmUgZG9uZS4NCj4NCj4g
VGhhbmtzLCBSb2dlci4NClRoYW5rIHlvdSwNCk9sZWtzYW5kcg==


From xen-devel-bounces@lists.xenproject.org Wed Feb 02 12:58:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 12:58:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264115.457098 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFFDa-0003ZU-La; Wed, 02 Feb 2022 12:58:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264115.457098; Wed, 02 Feb 2022 12:58:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFFDa-0003ZN-IO; Wed, 02 Feb 2022 12:58:38 +0000
Received: by outflank-mailman (input) for mailman id 264115;
 Wed, 02 Feb 2022 12:58:37 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1p3Q=SR=epam.com=prvs=40324c57ab=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nFFDZ-0003ZH-Ib
 for xen-devel@lists.xenproject.org; Wed, 02 Feb 2022 12:58:37 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d4b7786e-8427-11ec-8f75-fffcc8bd4f1a;
 Wed, 02 Feb 2022 13:58:36 +0100 (CET)
Received: from pps.filterd (m0174677.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 212CsArY019864;
 Wed, 2 Feb 2022 12:58:33 GMT
Received: from eur05-db8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2110.outbound.protection.outlook.com [104.47.17.110])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3dytc580pj-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 02 Feb 2022 12:58:32 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AS8PR03MB7127.eurprd03.prod.outlook.com (2603:10a6:20b:29d::5)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Wed, 2 Feb
 2022 12:58:25 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6%3]) with mapi id 15.20.4951.012; Wed, 2 Feb 2022
 12:58:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d4b7786e-8427-11ec-8f75-fffcc8bd4f1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=AuWYtvz8EVxAotU53Zl2VRzISAr3CTrstOMUvto+yfeTTgsmN6ZWvVfiWXg0smJYoRNpFOw42gymz4zYuX0ewieIb+gEoMFvKJSUiYsqASbrbhBGZc1z6yAM+pf+JESDRU2wgo/NAs1tz6eto4P1RMqKiPs+0ubQ9Y7X1WpStwKmpwAZNwNen2gLq2Ab/fyyx6sye7bnMF93dAUacY3HbbwZqY6ih+mOVdoYc//PhyE1DToy6aBbX09TSLA80DImRBHTVUo0WYbBitYwxB8CuxSTBMG7QYwN0qXIOrln0NmVCRqwZMYoFW4CfgPg2MtTIId4U57RTCbfKlpyxtMWvw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ztv0ZcHTX9trR9ppj29bdhj4k1r8U4xU23CcABS6DXU=;
 b=Bm+N/7MTcAZ4JTSqXeqUjnuPR24wPk+h9oQhLTJ51u7N1rLJrTbVb/YEUFwuFbCY7FFQyTLU6afc8g00Fg4zBry7rgHdgnSuL9gAl42RFEoKoG0SKyowYAduEv5XtiYtpaz8i/LxoSl+aY/4m8Kd/JeQqM29kpI/Y5Yl4u1h25XP2EBBOoD/lk0jEdiTsGXvaBz3fW0a3u+uzXuiN39wwJHkP9DzDV4gGF/6x8EiyBK9XGIUXe/ml8oClQTtCBLt+LNKKLfRGSpAqAhVQzLiKcE6MWShSu60XnXPCjaK7IupQneBM2rPJrXyD+4KEdyX0XLb3kK1gnqqy3TTbUmSzg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ztv0ZcHTX9trR9ppj29bdhj4k1r8U4xU23CcABS6DXU=;
 b=HEwjgc7ZzyaC61j1b47IL7NL35zGcbJ/pnWw/OssJUMeijU1o/LOGDOjkhxrhLKWFrPq5W1D9QMb1rMSZ2rJ4e22Hp7m9hAGDQWCb8bv35G9aPfGQ70YVd5R5dE0HT+Pi560inOBjd8bzbKZEfSSv7jiURi/8MsP55jzrohHyZNeJd7wIIJb1e5OK7kGnkBLdscgVedrJHYV3joYOgtAoMUMhsswvtjjofuft0/9isJSAXxF7a1SDLQqaTjmpTlnY6goufsWHLosZXr8V9VPqcNZjkLRy1JKdshPx5YMXYuetUPmmM605Op/4nmTDydcu8/gPuB2aMyTeAjVY5z1dQ==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "jbeulich@suse.com" <jbeulich@suse.com>,
        "andrew.cooper3@citrix.com"
	<andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com"
	<george.dunlap@citrix.com>,
        "paul@xen.org" <paul@xen.org>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>,
        Rahul Singh <rahul.singh@arm.com>,
        Oleksandr
 Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v5 10/14] vpci/header: reset the command register when
 adding devices
Thread-Topic: [PATCH v5 10/14] vpci/header: reset the command register when
 adding devices
Thread-Index: AQHX4ewKKrjJdBpwck6ciSQTpymsh6xhF7QAgB+NkoA=
Date: Wed, 2 Feb 2022 12:58:24 +0000
Message-ID: <7dc49d44-2de2-896a-4d7e-35bffe90f2df@epam.com>
References: <20211125110251.2877218-1-andr2000@gmail.com>
 <20211125110251.2877218-11-andr2000@gmail.com>
 <YeAH+h1ngDwze2+c@Air-de-Roger>
In-Reply-To: <YeAH+h1ngDwze2+c@Air-de-Roger>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 73228d1b-7dfa-45cd-5166-08d9e64bb308
x-ms-traffictypediagnostic: AS8PR03MB7127:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AS8PR03MB7127B703B01B65F33E34404CE7279@AS8PR03MB7127.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 z/4ThK9vf4yyZ2S7e/oaOl1zW3ABTSiVwMpAu83tZpQfkGZoGWfNvUfxpDROcv3gi27hbcQLVHfj9G0Wdv4ryotZNElYFACD8n4G/V52Xj1hD5N7gOWTOgEyGE4ARxa/KVPWTDCQBIIZeOmcGPm5aXpz5AgV6O2SDOjMUzZ0l0O/O9zd2UcczQpWxW1l4tdEepglEyrZ2ISmB7CVJSZurxJhmxOVRcfSVqXhTfkBuxG76R4MnDVE8cC+EpjCh/zAH/puWBHk7ZZDJ1HuSI92FzA1OU0kZ9mXC1TyxblOs30fedDwxBRW7CvSoB4yEQxTIOOVGQF0CzPoGFr0FMsxD2uy5ivifPfmMLkMX3cMvjhhTWzN19ogPIL56f5UtfvZDyglYYffs2us5CG3Y5laFsYAYFhMYwT7OGqUKeOKFNmCWHeVv6QYzspEN9S2Y9ZiCn9Oh5eb9l/TJhVjeBKujaTczRlDj2zvWPHJxQO1rCzTSOjMrs8geZTiX/ykxS0zsGGaH4AOa9TMEG2kvnDsVjd/ZCON2c4bQ1d3VTo50AHML7EK/Bj4kNqWDi0ooy/r/eY7/87ruS5UQT57w1IVYDjGHuSALjqdw5oG1RzqL/LS9Q1XnX/lmBE7LBVtTnwbLOAwmWDtCE38ViLZHG92ZSZw1Y8J2xY+wEbG8CHPpO95/+c9eIomoXIQuxt5VsityqhN6cDx5pKY3WHMAYlosjNRDvsS+hv+fLDfo3tLCzMWPdtUmFZLZrAvNsZtHkAO
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6512007)(53546011)(2616005)(6506007)(107886003)(71200400001)(26005)(6916009)(54906003)(508600001)(186003)(122000001)(38070700005)(316002)(6486002)(38100700002)(83380400001)(66556008)(66946007)(31696002)(86362001)(8676002)(36756003)(8936002)(4326008)(2906002)(31686004)(91956017)(66476007)(66446008)(64756008)(5660300002)(76116006)(7416002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?T1U1T0xkWlh5Ujh2TVZDNkViOWJUbjA1SktiQjliWXNVRDI0aElNdkd1a0Fq?=
 =?utf-8?B?anVCdHVrVWNWYzdxT0RTTmhUMFpmcmxpUkdOaDFLMUpNOGNBSUZRWC9tNDNU?=
 =?utf-8?B?bUdzSXFrOVR0REJDaGlCUWZ6azNlalZYZ0NSdXA2TWRVSVR0N3ovbjhEaS9K?=
 =?utf-8?B?a2Iwd0pEK3g3ZXg2SVR2Z2c3SHhDOE1ZS045bXR6T3hyTWlpNUN6NDdLeGdx?=
 =?utf-8?B?SjVaVTJPVEFOWjVRR2xhaG9ibmRVYVNrc1h5QUJtaHlTbDVoa21Jd1dWbmg0?=
 =?utf-8?B?YVJFVUwxNXdONVdrcno3djdGYS9xOFZTcHlxemFoYTFsVXN3K2ZMcVcwUEVS?=
 =?utf-8?B?ZzRZaFJ3UnVkVDhjWTR4MUxjRlJ3OXdVdkZDZnpsb1RuZEJKYW84WFR1Q1BG?=
 =?utf-8?B?VWVhTThvOS8zWVp0QTVidmZISkN1SXJmbTZUaU9EdTJtb0tqL2FpNXFOMHhL?=
 =?utf-8?B?d3hybTRDZ1pteE50b0hzdE5rV0N1V0djdkYycHppREpLN3BPaW5mNjVvNDk1?=
 =?utf-8?B?WmEzVTJpWE4vVDVoRlZ1dFlaQm9hd2UxTGNQejdodkdSaHQyc1dPWFJjZG54?=
 =?utf-8?B?alFDM2htTkV1YW41UXBBdHVsWEtnbWZqSmRBaWI4SmxjMTFya2lyRTNJSDlN?=
 =?utf-8?B?SDFZY2dGQzBmbEliOTBwaEwxQkVFeDhHdG1tenJ6RThIM1pRUW5YU1ZnY1Jt?=
 =?utf-8?B?VVJzbSsrT3ZaQXpyMWFaeWRmU3huK01NaVRCVGJnU2craFFoelh2WS9DWCt4?=
 =?utf-8?B?R1FwRGRweDdwRFpEcDNVZ2hmb0ExQ1BQdjdwc1B5Ymk0TVVMdHVMNFZCM2FX?=
 =?utf-8?B?TzFZQTVYTGZOZGo5cnhjdmpYUzNMNDNCVkxsTVlGN0x0bjVwVkNtanUwbXlO?=
 =?utf-8?B?TUJjMVJSWGFrNVo0emZBUXJkU0FJMnpERXJCbnVhMkxQeGtBNFQxTVF0UmRX?=
 =?utf-8?B?QnR2bHdrVUkzS1poeWx2KzBMZmw4dW9LTDJGL2xjdjJMaGRlcmtKeHpOV0Nz?=
 =?utf-8?B?eVZFU29LVGlwMWpRSUorOGkwNHUzL2Z2bzFkZnRCT0o1ZzN4Ny9hdTV2WEdY?=
 =?utf-8?B?K2Z0SHNZcFUyb0ZtdytUZGxhaFZrRXBzMzA3bWJkVnVLZXZud3NxQ1dyZnlL?=
 =?utf-8?B?dGY2eVd5Q0R1L3dNMzkyVXpjVFM5V0hydG1DWDBMZlZ4UlVlaVdoQUlEU3pN?=
 =?utf-8?B?YjhnRzZoaXR4eE4xeFJGU2Z6KzBIVkdHdkNXUnpwSXRSaHgyTFA3bWg0ZU9a?=
 =?utf-8?B?Tmp4djNYNGZIV0lxNWFwNVdhWld1ZGpCdkQ1R3lieURLNXRpdm5XWEh1R1pB?=
 =?utf-8?B?TFZ6KzNadDNkVjdQVVlKazVnM1JiWmRBb2szQ0hicjRFNjgvSUUxRlo0YmVG?=
 =?utf-8?B?UFhzOHdQNFFucjZJTzNQY2Z4NXNFcldxS2dUNmJFV3BNYTEva1lmTllxYzZw?=
 =?utf-8?B?U28vcFFDcUN6aUhmRnd5SkxrTWtFRTJrdDFyWkhZMENQb0ZwbUwzay9td2I3?=
 =?utf-8?B?TnB1cDE3aU1zTi9KTEd3ays2RnZSZ0FtcjlLcFBLV3lrYkJudHNmTFhDTVBy?=
 =?utf-8?B?UVErZWRrQjQ1T1UzaklIZ0wvUjNDZStGQ3VFTmo3YlU2blFxSWNYL052dDlz?=
 =?utf-8?B?bmtkaHJuZ1BRY0gvQlFPR0xIdFJDaHZ5M0JJVStpNFo1c1I5a3RVMnp3S3lj?=
 =?utf-8?B?bmxJb2pyenJGR1FETC9Ka2c0ZzNlTmxFZ1VRZHF6bnBOazgyS3hqRHlNT20w?=
 =?utf-8?B?VXgwZ0U1dkpieGtGdTA1NWp3SDhIcHhkaUxqdkh1ZWJYalFOeW1xZ2dOcncv?=
 =?utf-8?B?NTlPRHg1Y01DS2dxbDZQN2thM1V4L1Bkc0l3ZWhIc0JhRlZtREQvOGgxb2wz?=
 =?utf-8?B?QlA0M2NqcjJFV3F6U2lhYlBEQ0Z6SkFIL01Pam1Xa2d6cWdubjZBT0Y0MFBH?=
 =?utf-8?B?RXo0V3R2U0JkN050bFBOV3VYclRhSVUydkZOR2VycjQvM0JNdjV6K1Z2d2VR?=
 =?utf-8?B?eW5TZDJLOEk1MFZ4WTl4V2YySGpGeTlMYjMxbnIrSkJEbGdrSGQySXlQdkI2?=
 =?utf-8?B?TFZZQjFCeWl1VFFINEZ3TElzYnpBdXg0VlpKMHBnM2t4cGJzNjg2aFpGamFU?=
 =?utf-8?B?cmNuTitETjFvNHlBR05WQUd6TmZmYThobVJjc09GeVVDcnY0MzYxZnRlUDFX?=
 =?utf-8?B?anFWVW1SYVRmK2VSS1ozWXgyWDlaZ2dMRDJYd1BsQjh5Skk4WGdCQlpKMUdI?=
 =?utf-8?B?L2ltZW1wbExjTU43TUt4Y3ROcDIvNEhIc1J4VEs1Z21mUnZEWW9TS1FZRnJm?=
 =?utf-8?B?WnVlN0JCVmtRZkhYOGloYUFiOHBKM0RzOGl1R2ZEVlBvbUhhWXpDdz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <7DDC1329BF341641ADA9F631DCF82296@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 73228d1b-7dfa-45cd-5166-08d9e64bb308
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Feb 2022 12:58:24.5551
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: N4J84R3rAWM2eHTJ+BoORDGgp+Yyfpb2d8mN1EQwxfvZuQjNok4ycH6EWaZvjuUVAmHIy6K1T/GMLf13yZZZim63bfyb42yFscJY6wS8bo6+0x509g+o05ZQL2gZDBVc
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR03MB7127
X-Proofpoint-GUID: knZGPBEh3NcNIH9aUXAVh-VGBql7XCoh
X-Proofpoint-ORIG-GUID: knZGPBEh3NcNIH9aUXAVh-VGBql7XCoh
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-02_06,2022-02-01_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 malwarescore=0
 lowpriorityscore=0 bulkscore=0 clxscore=1015 mlxlogscore=643 adultscore=0
 impostorscore=0 mlxscore=0 suspectscore=0 phishscore=0 priorityscore=1501
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2202020071

SGksIFJvZ2VyIQ0KDQpPbiAxMy4wMS4yMiAxMzowNywgUm9nZXIgUGF1IE1vbm7DqSB3cm90ZToN
Cj4gT24gVGh1LCBOb3YgMjUsIDIwMjEgYXQgMDE6MDI6NDdQTSArMDIwMCwgT2xla3NhbmRyIEFu
ZHJ1c2hjaGVua28gd3JvdGU6DQo+PiBGcm9tOiBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyA8b2xl
a3NhbmRyX2FuZHJ1c2hjaGVua29AZXBhbS5jb20+DQo+Pg0KPj4gUmVzZXQgdGhlIGNvbW1hbmQg
cmVnaXN0ZXIgd2hlbiBwYXNzaW5nIHRocm91Z2ggYSBQQ0kgZGV2aWNlOg0KPj4gaXQgaXMgcG9z
c2libGUgdGhhdCB3aGVuIHBhc3NpbmcgdGhyb3VnaCBhIFBDSSBkZXZpY2UgaXRzIG1lbW9yeQ0K
Pj4gZGVjb2RpbmcgYml0cyBpbiB0aGUgY29tbWFuZCByZWdpc3RlciBhcmUgYWxyZWFkeSBzZXQu
IFRodXMsIGENCj4+IGd1ZXN0IE9TIG1heSBub3Qgd3JpdGUgdG8gdGhlIGNvbW1hbmQgcmVnaXN0
ZXIgdG8gdXBkYXRlIG1lbW9yeQ0KPj4gZGVjb2RpbmcsIHNvIGd1ZXN0IG1hcHBpbmdzIChndWVz
dCdzIHZpZXcgb2YgdGhlIEJBUnMpIGFyZQ0KPj4gbGVmdCBub3QgdXBkYXRlZC4NCj4+DQo+PiBT
aWduZWQtb2ZmLWJ5OiBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyA8b2xla3NhbmRyX2FuZHJ1c2hj
aGVua29AZXBhbS5jb20+DQo+PiAtLS0NCj4+IFNpbmNlIHYxOg0KPj4gICAtIGRvIG5vdCB3cml0
ZSAwIHRvIHRoZSBjb21tYW5kIHJlZ2lzdGVyLCBidXQgcmVzcGVjdCBob3N0IHNldHRpbmdzLg0K
PiBUaGVyZSdzIG5vdCBtdWNoIHJlc3BlY3Qgb2YgaG9zdCBzZXR0aW5nIGhlcmUsIGFyZSB5b3Ug
YXJlIGJhc2ljYWxseQ0KPiB3cml0aW5nIDAgZXhjZXB0IGZvciB0aGUgSU5UWF9ESVNBQkxFIHdo
aWNoIHdpbGwgYmUgc2V0IGlmIE1TSShYKSBpcw0KPiBlbmFibGVkLg0KWWVzLCBhbmQgdGhpcyBp
cyBiZWNhdXNlIHdlIG9ubHkgc3VwcG9ydCBJTlRYIGVtdWxhdGlvbiBhdCB0aGUNCm1vbWVudA0K
Pg0KPiBJIHdvbmRlciB3aGV0aGVyIHlvdSByZWFsbHkgbmVlZCB0aGlzIGFueXdheS4gSSB3b3Vs
ZCBleHBlY3QgdGhhdCBhDQo+IGRldmljZSB0aGF0J3MgYmVpbmcgYXNzaWduZWQgdG8gYSBndWVz
dCBoYXMganVzdCBiZWVuIHJlc2V0IGdsb2JhbGx5LA0KPiBzbyB0aGVyZSBzaG91bGQgYmUgbm8g
bmVlZCB0byByZXNldCB0aGUgY29tbWFuZCByZWdpc3RlciBleHBsaWNpdGx5Lg0KIEZyb20gbXkg
ZXhwZXJpZW5jZSBpdCB3YXMgYSByZWFsIGNhc2Ugd2hlbiB0aGUgZGV2aWNlIHdhcyBub3QNCnJl
c2V0IG1ha2luZyB0cm91Ymxlcy4gSSdsbCByZW1vdmUgdGhpcyBwYXRjaCBmb3Igbm93IGFuZCBz
ZWUgaWYNCkkgY2FuIHN0aWxsIHJ1biB3aXRob3V0IGl0IHJlbHlpbmcgb24gdGhlIGRldmljZSBy
ZXNldCB3aGljaCBtdXN0DQpiZSBpbiBwbGFjZSB3aGlsZSBhc3NpZ25pbmcgYSBQQ0kgZGV2aWNl
IChoZXJlIHdlIHJlbHkgb24gdGhlDQp0b29sc3RhY2ssIHJpZ2h0PykuDQo+DQo+IFRoYW5rcywg
Um9nZXIuDQpUaGFuayB5b3UsDQpPbGVrc2FuZHI=


From xen-devel-bounces@lists.xenproject.org Wed Feb 02 13:05:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 13:05:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264123.457109 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFFKF-00053S-Fo; Wed, 02 Feb 2022 13:05:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264123.457109; Wed, 02 Feb 2022 13:05:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFFKF-00053L-C3; Wed, 02 Feb 2022 13:05:31 +0000
Received: by outflank-mailman (input) for mailman id 264123;
 Wed, 02 Feb 2022 13:05:30 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=FkQ0=SR=xilinx.com=ayankuma@srs-se1.protection.inumbo.net>)
 id 1nFFKE-00053F-Bl
 for xen-devel@lists.xenproject.org; Wed, 02 Feb 2022 13:05:30 +0000
Received: from NAM04-DM6-obe.outbound.protection.outlook.com
 (mail-dm6nam08on20624.outbound.protection.outlook.com
 [2a01:111:f400:7e8b::624])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ca863ec2-8428-11ec-8eb8-a37418f5ba1a;
 Wed, 02 Feb 2022 14:05:29 +0100 (CET)
Received: from BN6PR19CA0103.namprd19.prod.outlook.com (2603:10b6:404:a0::17)
 by SN6PR02MB4654.namprd02.prod.outlook.com (2603:10b6:805:aa::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.18; Wed, 2 Feb
 2022 13:05:24 +0000
Received: from BN1NAM02FT042.eop-nam02.prod.protection.outlook.com
 (2603:10b6:404:a0:cafe::53) by BN6PR19CA0103.outlook.office365.com
 (2603:10b6:404:a0::17) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12 via Frontend
 Transport; Wed, 2 Feb 2022 13:05:24 +0000
Received: from xir-pvapexch02.xlnx.xilinx.com (149.199.80.198) by
 BN1NAM02FT042.mail.protection.outlook.com (10.13.2.153) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.4951.12 via Frontend Transport; Wed, 2 Feb 2022 13:05:24 +0000
Received: from xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) by
 xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2176.14; Wed, 2 Feb 2022 13:05:23 +0000
Received: from smtp.xilinx.com (172.21.105.197) by
 xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server id
 15.1.2176.14 via Frontend Transport; Wed, 2 Feb 2022 13:05:23 +0000
Received: from [10.71.118.184] (port=11473)
 by smtp.xilinx.com with esmtp (Exim 4.90)
 (envelope-from <ayan.kumar.halder@xilinx.com>)
 id 1nFFK6-0007ac-LU; Wed, 02 Feb 2022 13:05:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ca863ec2-8428-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XfcZYzjJFawgkCu+j7KmfxzyIsK1me+DjJT91PW8HvmjDDCD+JWVvMR/It1/7DFBDbBwe+x9ZCQy00N2tIl0gAi49soiJGqaJzfJ1H1fbgPhGZvXL3lbZu+7Hwgqg0GhiCRoD/+2j6vE3FVpqYC4dFMm3+3sCIEeVYj4nAoT0JBIH0jWiWF/c+H2v2W7qdWc2ZzLiKHOoIiPt646KrSf32buezCbO01WkiowZShuZN6WsKLfomziWd8Zx050rnBw4ikRpzw2li1BdyoctvMEdthSTxukGEZUSyjFgPFbivnCM7MF0fyPX17MG/JMe2zQv86L2pABWa/IgPDdjPKfng==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=BM/Hm2dDrulzU4PiPd7pKZq0LqWuFnahVAuLDnzu5zo=;
 b=m02K6GCwWV/hLN8lcCI+V28BxNHQi2Cpo9HnDup9dkKZ3aOBGFsCi0aU3T+TmzzYwSQYy91qG4NPk//3TTWH684Gkg9ktyQMwaZJpoDjsOqCE7/WFfGu9h7MqL20bcb2gcuL27Mydfw4Ty4m+JgaAmFUDZ7kO/KR750DTfiTHFct6201ruL/r7sS7bxAQ+Dh2jM4aWAeUDqYSyK6NUeTtszHdB2nhMtSD4+OtSyNDG8v1crZ1KRnXjYQhnwgAunF3NgiYSkvmMCdSxkaPQ1wL2pa6ekbU9noG5a7VNFwNcQ29Pi+XLgUj8WkIuBFnCH7ljlNix42tFHU6hwrKxn0Dg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 149.199.80.198) smtp.rcpttodomain=xen.org smtp.mailfrom=xilinx.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=BM/Hm2dDrulzU4PiPd7pKZq0LqWuFnahVAuLDnzu5zo=;
 b=GkNv0Co40wD7KTvz5FdTADO9RS7Y6IMMXTc1McstKIEzReGeQQTyemi65isoHozq+3dH3FtiKTvMnpXZbKNmSsb41e20e23t0CKArBb+yAGAJibSOcRhtKF2wY6DiC2asXfbAWnpCkWciPaH9w1ZVhH8/yd8qN2KOmZ2HxhFfwg=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198)
 smtp.mailfrom=xilinx.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=xilinx.com;
Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates
 149.199.80.198 as permitted sender) receiver=protection.outlook.com;
 client-ip=149.199.80.198; helo=xir-pvapexch02.xlnx.xilinx.com;
Message-ID: <453fa8d1-6d12-ea23-6b35-e556f72fe0cf@xilinx.com>
Date: Wed, 2 Feb 2022 13:05:22 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.1
Subject: Re: [XEN v5] xen/arm64: io: Decode ldr/str post-indexing instructions
To: Julien Grall <julien@xen.org>, Ayan Kumar Halder
	<ayan.kumar.halder@xilinx.com>, <xen-devel@lists.xenproject.org>
CC: <sstabellini@kernel.org>, <stefanos@xilinx.com>,
	<Volodymyr_Babchuk@epam.com>, <bertrand.marquis@arm.com>
References: <20220131193728.2980-1-ayankuma@xilinx.com>
 <e07068aa-91b8-ebdf-db17-7173f417ad33@xen.org>
From: Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>
In-Reply-To: <e07068aa-91b8-ebdf-db17-7173f417ad33@xen.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 0c5ba134-1440-48ba-a6a7-08d9e64cace1
X-MS-TrafficTypeDiagnostic: SN6PR02MB4654:EE_
X-Microsoft-Antispam-PRVS:
	<SN6PR02MB465466ADA461D4A1FD84B1ABB2279@SN6PR02MB4654.namprd02.prod.outlook.com>
X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply
X-MS-Oob-TLC-OOBClassifiers: OLM:6108;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	q6US5tDiebB0A7j0CvXEXiUIig+zFSGF7k4iP/R9IfiF8UM892tcgo16BUFb6CzPrfYQNsFtIaC/X/Do9S6eDsAfn0p8K8sv2jyHJoaSG2SX/8z+S+AuX87EODt1BYMBhFUVdNi4n86AufhxLIBm97tNwFlCaWAVspEe+cozl4sqUysdhlgltNjY4W0zQi5dg4xAOnEeGAezqt6n8SEu+0pUEx8OUDSeLF6kCRwLqkMHtujI4Fyaqjv8jmAPaK6pdNUszUQEvzBV67UlwIBR0RYRRbz7zLYjfKZYq8FCpCgXUuf4niFNiq8gxc/DLNYFLvWyHfwJpYn+6bcHchtI7nIi27PdGIZGcT1pyD1qdNmcPYZAje+olAIcO2AZwztgYTx3WQIkhULu6Cc7CakPVWdag0wZ2bqSbNv9XGmaZQzRCwb5qXAlqcg9wDDPRzAd8dO+becwJhUinKadT5mRWk/cDEqe7hG/aX6a5TihO29IFCe/jqJHHEr8//Ucr9R3MKhf7iCmL7zopnTpiwK2KGaHVm+1AtL+YeXeMMwI4O7kfNYE8hVowBLgp9LAy/au7lSIn9iCLD99zMv9aBl2HessGO3rYeIo36X3CMGMmvSucmwsSxjz1n9UhqsC40c/XXHQeKFkpsTJfR6skscakiBtXQZVYbGeWKNJNzxI9zIYCqK9RMN8PFUKbCif5N+PUqsigAAcIh5mow2TzhdNpw==
X-Forefront-Antispam-Report:
	CIP:149.199.80.198;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:xir-pvapexch02.xlnx.xilinx.com;PTR:unknown-80-198.xilinx.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(4326008)(36860700001)(70586007)(7636003)(426003)(8676002)(82310400004)(8936002)(5660300002)(47076005)(70206006)(508600001)(53546011)(9786002)(316002)(36756003)(31686004)(110136005)(2906002)(186003)(2616005)(31696002)(83380400001)(356005)(26005)(336012)(54906003)(50156003)(43740500002);DIR:OUT;SFP:1101;
X-OriginatorOrg: xilinx.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2022 13:05:24.0289
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 0c5ba134-1440-48ba-a6a7-08d9e64cace1
X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.80.198];Helo=[xir-pvapexch02.xlnx.xilinx.com]
X-MS-Exchange-CrossTenant-AuthSource:
	BN1NAM02FT042.eop-nam02.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR02MB4654

Hi Julien,

I have a question.

On 31/01/2022 19:37, Ayan Kumar Halder wrote:
>> diff --git a/xen/arch/arm/ioreq.c b/xen/arch/arm/ioreq.c
>> index 308650b400..f19fb46f72 100644
>> --- a/xen/arch/arm/ioreq.c
>> +++ b/xen/arch/arm/ioreq.c
>> @@ -23,16 +23,35 @@
>>     #include <public/hvm/ioreq.h>
>>   +#include "decode.h"
>> +
>>   enum io_state handle_ioserv(struct cpu_user_regs *regs, struct vcpu 
>> *v)
>>   {
>>       const union hsr hsr = { .bits = regs->hsr };
>> -    const struct hsr_dabt dabt = hsr.dabt;
>> +    struct hsr_dabt dabt = hsr.dabt;
>> +
>>       /* Code is similar to handle_read */
>>       register_t r = v->io.req.data;
>>         /* We are done with the IO */
>>       v->io.req.state = STATE_IOREQ_NONE;
>>   +    /*
>> +     * Note that we have already decoded the instruction in 
>> try_fwd_ioserv().
>> +     * We decode the instruction again to obtain rn and imm9. This 
>> will be used
>> +     * to do the post increment.
>> +     * Also there is no need to check whether the instruction can be 
>> decoded or
>> +     * was successfully decoded. The reason being if there was an 
>> error, then
>> +     * try_fwd_ioserv() would have returned error and this function 
>> would not
>> +     * have been called. Thus, there is an assumption that 
>> handle_iosev() is
>> +     * invoked when try_fwd_ioserv() has returned successfully.
>
> I am afraid this is not a correct assumption. Another vCPU can modify 
> the instruction between the two decoding. So the right solution is to 
> stash the information for latter consumption.
>
>> +     */
>> +    if ( !dabt.valid )
>> +    {
>> +        decode_instruction(regs, &dabt);
>> +        post_increment_register(&dabt.dabt_instr);
>> +    }
>> +
>>       if ( dabt.write )
>>           return IO_HANDLED;
>>   @@ -65,6 +84,8 @@ enum io_state try_fwd_ioserv(struct cpu_user_regs 
>> *regs,
>>       };
>>       struct ioreq_server *s = NULL;
>>       enum io_state rc;
>> +    bool instr_decoded = false;
>> +    const union hsr hsr = { .bits = regs->hsr };
>>         if ( vio->req.state != STATE_IOREQ_NONE )
>>       {
>> @@ -76,8 +97,18 @@ enum io_state try_fwd_ioserv(struct cpu_user_regs 
>> *regs,
>>       if ( !s )
>>           return IO_UNHANDLED;
>>   +    /*
>> +     * Armv8 processor does not provide a valid syndrome for 
>> decoding some
>> +     * instructions (for eg post-indexing ldr/str instructions). So 
>> in order to
>> +     * process these instructions, Xen must decode them.
>> +     */
>>       if ( !info->dabt.valid )
>> -        return IO_ABORT;
>> +    {
>> +        rc = try_decode_instruction_invalid_iss(regs, &info->dabt);
>> +
>> +        if ( rc != IO_HANDLED)
>> +            return rc;
>> +    }
>
> As you pointed out previously, the field SAS (Syndrome Access Size) is 
> invalid when the ISV=0. So the decoding needs to be done *before* we 
> select the IOREQ server.
>
> But as I said, this would result to decode the instruciton when this 
> is not necessary. This is where Stefano's suggestion in [1] is useful.
>
> For ISV=0, it will be a lot more common to trap because of a P2M 
> translation fault (of the MMIO is not mapped). So we should call that 
> first and then, if it still not resolved, try to decode the instruction.
>
> With that in place, you are avoiding the issue in try_fwd_ioserv().
>
> Can you please coordinate with Stefano?

I am a bit confused regarding where we need to handle to post increment 
of Rn in case of ioreq.

I can see the following two places where PC gets incremented :-

1. handle_ioserv() returns IO_HANDLED via try_handle_mmio(). And then in 
"case IO_HANDLED:", PC is incremented.

2. leave_hypervisor_to_guest() ---> check_for_vcpu_work() --> 
vcpu_ioreq_handle_completion() --> arch_ioreq_complete_mmio(). Here PC 
is incremented as well.

So, do I need to update Rn in both the above places.

And if I understood your previous comment "Another vCPU can modify the 
instruction between the two decoding....", you are suggesting to save 
the instruction opcode (from PC) before invoking try_fwd_ioserv(). So, 
that it can be decoded again in arch_ioreq_complete_mmio() without 
reading PC.

- Ayan

>
> [1] alpine.DEB.2.22.394.2201271327430.27308@ubuntu-linux-20-04-desktop
>


From xen-devel-bounces@lists.xenproject.org Wed Feb 02 13:05:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 13:05:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264126.457120 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFFKZ-0005Ro-Ne; Wed, 02 Feb 2022 13:05:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264126.457120; Wed, 02 Feb 2022 13:05:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFFKZ-0005Rh-Ka; Wed, 02 Feb 2022 13:05:51 +0000
Received: by outflank-mailman (input) for mailman id 264126;
 Wed, 02 Feb 2022 13:05:50 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nFFKX-0005Qs-Ui; Wed, 02 Feb 2022 13:05:49 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nFFKX-0001k7-Oi; Wed, 02 Feb 2022 13:05:49 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nFFKX-0003Wo-C1; Wed, 02 Feb 2022 13:05:49 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nFFKX-0002Zc-BY; Wed, 02 Feb 2022 13:05:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=kfKJ5jqEn3HPGQlry0Sr8NagIX4MCrKkt0orh+Yz65g=; b=YIXN7IXJeSPC874IzczFphtxUq
	E7f+xpLv8OMabqlMgW3Tyw+5sspH/CKD1YGHXOd1bxvwzESpWQQtjKanfx9RQX4/Dmu/0dyRl7XlL
	kC9Zc1p/c43L6FWFyeJeVJtd3qki4NDGF9zc0Cz30w7kjaLe+1rbjoxM8OB2djftTe3A=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167985-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 167985: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=b17e0ec72eded037297f34a233655aad23f64711
X-Osstest-Versions-That:
    xen=9ce3ef20b4f085a7dc8ee41b0fec6fdeced3773e
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 02 Feb 2022 13:05:49 +0000

flight 167985 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167985/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  b17e0ec72eded037297f34a233655aad23f64711
baseline version:
 xen                  9ce3ef20b4f085a7dc8ee41b0fec6fdeced3773e

Last test of basis   167977  2022-02-01 18:00:26 Z    0 days
Testing same since   167985  2022-02-02 10:00:30 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
  Jan Beulich <jbeulich@suse.com>
  Luca Fancellu <luca.fancellu@arm.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Sergey Temerkhanov <s.temerkhanov@gmail.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   9ce3ef20b4..b17e0ec72e  b17e0ec72eded037297f34a233655aad23f64711 -> smoke


From xen-devel-bounces@lists.xenproject.org Wed Feb 02 13:15:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 13:15:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264142.457131 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFFUE-00076Y-OL; Wed, 02 Feb 2022 13:15:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264142.457131; Wed, 02 Feb 2022 13:15:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFFUE-00076R-LR; Wed, 02 Feb 2022 13:15:50 +0000
Received: by outflank-mailman (input) for mailman id 264142;
 Wed, 02 Feb 2022 13:15:49 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1p3Q=SR=epam.com=prvs=40324c57ab=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nFFUD-00076L-3x
 for xen-devel@lists.xenproject.org; Wed, 02 Feb 2022 13:15:49 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 3b60683c-842a-11ec-8eb8-a37418f5ba1a;
 Wed, 02 Feb 2022 14:15:47 +0100 (CET)
Received: from pps.filterd (m0174676.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 212D4fCF028654;
 Wed, 2 Feb 2022 13:15:42 GMT
Received: from eur01-he1-obe.outbound.protection.outlook.com
 (mail-he1eur01lp2051.outbound.protection.outlook.com [104.47.0.51])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3dyth0r1r3-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 02 Feb 2022 13:15:42 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by VI1PR0302MB3488.eurprd03.prod.outlook.com (2603:10a6:803:1d::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Wed, 2 Feb
 2022 13:15:38 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6%3]) with mapi id 15.20.4951.012; Wed, 2 Feb 2022
 13:15:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3b60683c-842a-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=b+Na9ktr1SSjQ5Dfg3W+2/VRhU2Hm6gZiQ4xSAXom8dKGQ/cDht/fWeMJgz4j0yF5Ds917xSHd7OiqM4FSYrjo/05Cdg4xTr/hcr62etuErzL8aHK17hZMEersUP6A+2t/zQGVgSECHmhNx/VsedvZVaSnq7h2oONG8BpFqxiFy3Ujlsvx6IB8pVJ+oBSShmnXRKmKNBy9AhC1y5Xaykd++7OLQ3OXMedk/VgcWDjpukTPEkJa4p11zTBAcMgZsqEkhTBgtcKgggMW1kQmrm4IqLcOMd8K6uteWgWJexyuDO5T0mzeWvHfnR90X8rNJOpZdQQHEHV5Wc43Ev0MyvJA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=RAV4m35Tz3r4nzVT+GPAx09cya+fWlo6iXU3D/rPMdE=;
 b=cf7miCQIDJdWxuBXLBxHv4OsTXkoTFgzT+QofYzJdVtubyNhfurng1z921xESK2d5VUsisChnBwqjlmoOjz3KpLrSg8u2fdaUdG8KULVUt60zqnaAksDGlLuUk1R9QZoUe1ji/xLyaBuqtxqfjS94PPe8A/ginOQRMt/UcOMS024T+nLCTKISIHqBB7SkThD9NnbP9XHGs1hZsmRiRGAJiyt1R8VXdojKh6ELAi1SDUTOuDDvRkTOXmsRylNAxIQWkcvBmQRiBVWQxig1lduyNkTbw0naK7kjWInyQfZzIMcPrIJRhYrB2rb+tJaTjnd9N0pOEK5RM3u1czGUUGgcA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=RAV4m35Tz3r4nzVT+GPAx09cya+fWlo6iXU3D/rPMdE=;
 b=RMC5i2MG/Uvx+K70IUCfEcjT6GKd+2mOd9/gmZQ45R+lL0gJbOY2xwAdBhU9WO/3G2vHd/iyt1TKSxsqSAb1k1R9JwfJpb2TqARm9ebRlPmPF/UiXeg0J7zLhO8YZRCXqoS35jEK0adbUqmuYOM1WhfyQqDhvRrDhqH/Ym1sS7iyGwrlEWIg+45nPnIOEfdiYi3a2+eMlq9fjlpMobdBcF32FuZFQPn7J8ZFVxSEQQERcN1p5nxe2Qe4pAD0/pOrN+cz/w8t1mJcuLJSGu+eMvHYreFy0wig9DECsC2cF7kBu2UD6f+XPtXYn1QZGn45SO3XRl4x8TtXG/B3enqEMw==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "roger.pau@citrix.com" <roger.pau@citrix.com>,
        "andrew.cooper3@citrix.com"
	<andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com"
	<george.dunlap@citrix.com>,
        "paul@xen.org" <paul@xen.org>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>,
        Rahul Singh <rahul.singh@arm.com>,
        "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        Oleksandr
 Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v5 11/14] vpci: add initial support for virtual PCI bus
 topology
Thread-Topic: [PATCH v5 11/14] vpci: add initial support for virtual PCI bus
 topology
Thread-Index: AQHX4ewLCr4mT3CEwkeKGdBUjNnfXqxf0T8AgCDY2IA=
Date: Wed, 2 Feb 2022 13:15:37 +0000
Message-ID: <af801609-12ca-9908-3bb1-03d4fe75f2bd@epam.com>
References: <20211125110251.2877218-1-andr2000@gmail.com>
 <20211125110251.2877218-12-andr2000@gmail.com>
 <a6caa134-cef4-f6b2-378e-759c10a37c0a@suse.com>
In-Reply-To: <a6caa134-cef4-f6b2-378e-759c10a37c0a@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 80f65a48-0130-4103-b1ad-08d9e64e1ab7
x-ms-traffictypediagnostic: VI1PR0302MB3488:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <VI1PR0302MB3488579F3CE7E652F5103158E7279@VI1PR0302MB3488.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 AvQ0U7JR6mr4nU3RABnLfKWVcI0C79A5vbVBOuECR3YF/ROeycik4BpostEJFTTvgITKRhd1hpalr87vbAKIxLodfnyc+BcjyhOlPNKZi1yxNMGif6odQ8i7zGMbdKQZ1PRVY4lrYuRTAOoOxLl+pSkcD7CMl/bNnVBJpYr/qNDJQyHXr44VFZ9KJXD59lhOOlFxeVz3Hb5wm16iNNAUZnmZx7HSFmM/Ckj/qDAjOJGSnP6j1KraynFzRWJNFHMZ7caxFEX9fpSjaAFL3CC8pVV+FXrAvWlJERFR7acH8kLYFXEIp7bqs31eYI1gVrkrZlfEHBjvPMKkRBN0qD4Z2tSNGU8BRipYyAyvqPdjQ9hxRO5w99C7CFdHTJKKwKW4Dr0Ij1Tbs/aIGEY5BN4RV+4AjXy7giHuQZvd/Y722JadbPD1s0NNiWI3io1hhT4fSykYHESbNoEfiHrsQ2a2WkmT4FzScscpS8ttnnZnA69YfQD7+PvJSMO+XlocYNalqNhO+2W8QjShlTfL71Oenb6We9JIWWFZPnBGJ+S1kRA+Tog0vS+gih/MfUgIanZyQEUadfqmrzAYV/TTWBz2VewAWoW7+8EBTGa2TgEPcITi42nsTWAhGJOyBWRknm7ESEqI87Y32mF5/TaaPzanxlF+bZmgaiM3zvz6YU5nDAAs81HWsvq6gWnCIXajLIywEiaRqz4Nkj2WneUBfCzd/i9W3Nfkh6unbHjPvXqv9jrDPFuTbQ3vixK+UbrcTgTQ
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(71200400001)(66556008)(66476007)(8676002)(6486002)(4326008)(66946007)(38100700002)(86362001)(38070700005)(64756008)(31696002)(66446008)(76116006)(508600001)(107886003)(8936002)(186003)(26005)(2616005)(7416002)(6512007)(91956017)(53546011)(31686004)(2906002)(122000001)(5660300002)(36756003)(54906003)(6916009)(316002)(6506007)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?VnhacnIxQnc5eFBrSVJaM1FHV0Jjd2V4MG1seGZqT2hYUG16OHlkTk1HQ1Q5?=
 =?utf-8?B?ZWYveVE5YmhFQnMvWGszL3oxblNpditGZjIzSmpINTJ0emxWUjZhdXU2bkI1?=
 =?utf-8?B?cTVNSlFnTERRSnlyVFhIZE5MVlZMeE5MdDVTajk5RndNSitEdVpRSytqSWVS?=
 =?utf-8?B?dnk1dWZtSHU0U0tGWFQzWGVERVF4ZEJqa3F4TTVCUnY1NVlCaWJ2b1J3RHpB?=
 =?utf-8?B?TkltMHZzanc0UVFhRVEwU0VwcStxUVRxcnExaFd0UEdpRW1GY2RrOThidWNL?=
 =?utf-8?B?QzhlRjh4UGpObTJLNWErTVZZVW95RWNSYU55NU40ZVJyMmdWeVZGV0pTQXla?=
 =?utf-8?B?UFRoeWZYYkpKSlVWOUMwcmVjSGpaUk1jTlNEdkM0c0VhSTVNVmZMMFRDT2JZ?=
 =?utf-8?B?OTRFWGRtUTRMOTFONnlxc3NSb2RnMmxwWjVFMnB1WURaeXFFOEI2Tnk0VXoz?=
 =?utf-8?B?K0xUajlZOVlBS0IvTHVqS09yblZidTJVdlN5VmlMODBVWnhqOVFIN3JzUWc2?=
 =?utf-8?B?QWp2bENwdnBHU3grR3BSNG4xczJWNFQzNHR4UUJWSzFENUFpbUdGQXpQejJw?=
 =?utf-8?B?TEdhOTErNjB0ZmdhZjBGVGRQZitDVUNtbXdMSmYwalFuY0JyUmo0OEg3Uzcx?=
 =?utf-8?B?ejRNVytxd0doN05hQ0I3SzNrd0FrT1EzdDZXRmY4SGVLQWUvUDVzeGtmckkw?=
 =?utf-8?B?Rzl6aTdxTHZsNnl6QStSZ1NSRSt0S2RuL0N1VTB2WS9oTEpGdSs0TUlOWGhv?=
 =?utf-8?B?M0ZBOUZHeEE1cVJaR3RXZW1CK0YxT1RCckM3dnhWMmJCb3FSeFNrTjVZWDRP?=
 =?utf-8?B?d2NRSFFncStWb3RkYkFEblRsMmVZZEVrNnc2cVlkQnMrWEhFbElaRUJ1Z0t2?=
 =?utf-8?B?NUNDM0hVQUtWY1E4OUxSSGV0UVl5RDg3ZnVua3hBR1ZyOXJERnRaRkZKbit1?=
 =?utf-8?B?YUV0Z1gxY0FMMnBIalNFZ1lGNjd5SE1UNGFoanJmYVIyRFBjUHRPVHRpcUJY?=
 =?utf-8?B?NmFUK0VNY0ZhWWorOFZGcHJZR3hmSlN6Nnp0UUszTGNCVHZPSXZNdTVWWjZI?=
 =?utf-8?B?a2x3bStwRnZ6TGVDSldWbU9TOFRMRnk0R1NPNHl0anFRNXZUb1plODZvVmV0?=
 =?utf-8?B?Ly9yQ3hKNVNoYVhNbE50bU1oSDV6ZHB1MTB3TWJXWUtFd2dlWC9HRzVaZ1VK?=
 =?utf-8?B?WS9mRDNoZlQ5NUtwNmdkS2NjN0NNb3pmb3QvYzEvZW9TYmdCUFFNL0pUeWpn?=
 =?utf-8?B?R0RjQ0RMTExiTG5EZlgxSmpGdlBvWncvZzA1UUlxaGtMZFc5UWZjRGxLY05Q?=
 =?utf-8?B?OTNud1BQdFVIa2R5b09NUWQ4eDl6dlNEcktqbTNkYWZyU253SWNMeVcrcVEw?=
 =?utf-8?B?YlpIQUhXbWVzWXlTaklWUEdHWDdwVUJ0TStyR24xR25OemIrL1dLWlRjcmo4?=
 =?utf-8?B?SElvanErVUcvU2UxbWpNdE9GWVpDYkVLd2xTb1R5VXQyUmN1SHdicUlhN2dC?=
 =?utf-8?B?SFhDckVKZ3g0WmVERjVEb2d3ZXBlRzRPeStvMHhmdjJIMFNURFpBVSs2ZG9o?=
 =?utf-8?B?aFNBYnd0Nys1ckVnYSs1UEFjZUl0c2VCVmh4TzVzdHdRaVhRdkhKdklRTnFM?=
 =?utf-8?B?Vnh6cGd4cmtONHNUTDZRUThITWN5bnRNYU93WXM0YzJDSFVGdllxWm94NE82?=
 =?utf-8?B?eVVuR1dpclcrdTU1TkN1ZXJiTXdETFFybjlxMC9nb1pUbVpqb2NFU3hRd0o3?=
 =?utf-8?B?M3NlR0Fvdng5SU0xd3BSY1RJOXVRRC9VTHJzNnF0N0dZMEZJTGIvMzllMFVE?=
 =?utf-8?B?U3NIYi9QcTdYODJrUWJoMmNKSTVHUkthU0hQSWxYeUpJMnltc1p1SVFxRmln?=
 =?utf-8?B?akE0UG9pUHUzVXlnL3RIOXN5WGRlMGwvNUNtWTYwbTV5QUpzcXFvcjJpUWFl?=
 =?utf-8?B?SUsxVUowNUZETCt2Q0YzQnNYUEVTbGEzRVpOdzkyRVZSMndnMXZtY2xIZlZP?=
 =?utf-8?B?VC9kbG1RUDZXRmtqeWdjR2RqbU44SE5hTTg3UTRtcGFVVERwOGpTUVVLSEZJ?=
 =?utf-8?B?Ulhta1U3RUZSMndWWEFza1Vyb05VeFRuRWRnaVhrc3FyUnJ0cnU3S0xybGtl?=
 =?utf-8?B?TjlROWthREVGWkRRTWs3dnBaWGR2THNVV1hwRWJqNXM0aFdYYUlYT0pXelh4?=
 =?utf-8?B?T1h4QmRwRkNwbVVUd3hwaHhRb1V1SEdQMTQyQ082d0cwQVVuWnMvalFacVov?=
 =?utf-8?B?Vnp0MjRJcGFvR2dzT092Z1ZKaXJaOFFlRklXV0ZaKy9rdFpLWmE3ZVVNMmVP?=
 =?utf-8?B?c0FnaEJLZGtTTXhON0JtOER6dm13enFHWkNvVDN5WVFxTElEV0ZEZz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <DD41529E15C2D4479A4F4D193690140B@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 80f65a48-0130-4103-b1ad-08d9e64e1ab7
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Feb 2022 13:15:37.9250
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: phtHEOMZuYLLAUkUMZG9wy7nMEXs6H1LBlOaNGrQPDDvU+a3Az3sBRbwtgG2EXSsHPgaO0gjKgHPIvC5VxhjtUMj7koV/KqTV/+T61Sobuwtt4SukTae5rfySlyKcf6g
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0302MB3488
X-Proofpoint-GUID: q_2YwYKgcc7ISvvmhmvvGJ0aRe2OKJ5d
X-Proofpoint-ORIG-GUID: q_2YwYKgcc7ISvvmhmvvGJ0aRe2OKJ5d
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-02_06,2022-02-01_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 bulkscore=0
 phishscore=0 impostorscore=0 lowpriorityscore=0 priorityscore=1501
 adultscore=0 mlxlogscore=999 suspectscore=0 mlxscore=0 clxscore=1015
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202020073

SGksIEphbiENCg0KT24gMTIuMDEuMjIgMTc6MzksIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAy
NS4xMS4yMDIxIDEyOjAyLCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyB3cm90ZToNCj4+IEBAIC0x
NDUsNiArMTQ4LDUzIEBAIGludCB2cGNpX2FkZF9oYW5kbGVycyhzdHJ1Y3QgcGNpX2RldiAqcGRl
dikNCj4+ICAgfQ0KPj4gICANCj4+ICAgI2lmZGVmIENPTkZJR19IQVNfVlBDSV9HVUVTVF9TVVBQ
T1JUDQo+PiAraW50IHZwY2lfYWRkX3ZpcnR1YWxfZGV2aWNlKHN0cnVjdCBwY2lfZGV2ICpwZGV2
KQ0KPj4gK3sNCj4+ICsgICAgc3RydWN0IGRvbWFpbiAqZCA9IHBkZXYtPmRvbWFpbjsNCj4+ICsg
ICAgcGNpX3NiZGZfdCBzYmRmID0geyAwIH07DQo+PiArICAgIHVuc2lnbmVkIGxvbmcgbmV3X2Rl
dl9udW1iZXI7DQo+PiArDQo+PiArICAgIC8qDQo+PiArICAgICAqIEVhY2ggUENJIGJ1cyBzdXBw
b3J0cyAzMiBkZXZpY2VzL3Nsb3RzIGF0IG1heCBvciB1cCB0byAyNTYgd2hlbg0KPj4gKyAgICAg
KiB0aGVyZSBhcmUgbXVsdGktZnVuY3Rpb24gb25lcyB3aGljaCBhcmUgbm90IHlldCBzdXBwb3J0
ZWQuDQo+PiArICAgICAqLw0KPj4gKyAgICBpZiAoIHBkZXYtPmluZm8uaXNfZXh0Zm4gKQ0KPj4g
KyAgICB7DQo+PiArICAgICAgICBnZHByaW50ayhYRU5MT0dfRVJSLCAiJXBwOiBvbmx5IGZ1bmN0
aW9uIDAgcGFzc3Rocm91Z2ggc3VwcG9ydGVkXG4iLA0KPj4gKyAgICAgICAgICAgICAgICAgJnBk
ZXYtPnNiZGYpOw0KPj4gKyAgICAgICAgcmV0dXJuIC1FT1BOT1RTVVBQOw0KPj4gKyAgICB9DQo+
PiArDQo+PiArICAgIG5ld19kZXZfbnVtYmVyID0gZmluZF9maXJzdF96ZXJvX2JpdCgmZC0+dnBj
aV9kZXZfYXNzaWduZWRfbWFwLA0KPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgVlBDSV9NQVhfVklSVF9ERVYpOw0KPj4gKyAgICBpZiAoIG5ld19kZXZfbnVtYmVy
ID49IFZQQ0lfTUFYX1ZJUlRfREVWICkNCj4+ICsgICAgICAgIHJldHVybiAtRU5PU1BDOw0KPj4g
Kw0KPj4gKyAgICBfX3NldF9iaXQobmV3X2Rldl9udW1iZXIsICZkLT52cGNpX2Rldl9hc3NpZ25l
ZF9tYXApOw0KPj4gKw0KPj4gKyAgICAvKg0KPj4gKyAgICAgKiBCb3RoIHNlZ21lbnQgYW5kIGJ1
cyBudW1iZXIgYXJlIDA6DQo+PiArICAgICAqICAtIHdlIGVtdWxhdGUgYSBzaW5nbGUgaG9zdCBi
cmlkZ2UgZm9yIHRoZSBndWVzdCwgZS5nLiBzZWdtZW50IDANCj4+ICsgICAgICogIC0gd2l0aCBi
dXMgMCB0aGUgdmlydHVhbCBkZXZpY2VzIGFyZSBzZWVuIGFzIGVtYmVkZGVkDQo+PiArICAgICAq
ICAgIGVuZHBvaW50cyBiZWhpbmQgdGhlIHJvb3QgY29tcGxleA0KPj4gKyAgICAgKg0KPj4gKyAg
ICAgKiBUT0RPOiBhZGQgc3VwcG9ydCBmb3IgbXVsdGktZnVuY3Rpb24gZGV2aWNlcy4NCj4+ICsg
ICAgICovDQo+PiArICAgIHNiZGYuZGV2Zm4gPSBQQ0lfREVWRk4obmV3X2Rldl9udW1iZXIsIDAp
Ow0KPj4gKyAgICBwZGV2LT52cGNpLT5ndWVzdF9zYmRmID0gc2JkZjsNCj4+ICsNCj4+ICsgICAg
cmV0dXJuIDA7DQo+PiArDQo+PiArfQ0KPj4gK1JFR0lTVEVSX1ZQQ0lfSU5JVCh2cGNpX2FkZF92
aXJ0dWFsX2RldmljZSwgVlBDSV9QUklPUklUWV9NSURETEUpOw0KPiBJcyB0aGlzIGZ1bmN0aW9u
IGd1YXJhbnRlZWQgdG8gYWx3YXlzIGJlIGludm9rZWQgYWhlYWQgb2YgLi4uDQo+DQo+PiArc3Rh
dGljIHZvaWQgdnBjaV9yZW1vdmVfdmlydHVhbF9kZXZpY2Uoc3RydWN0IGRvbWFpbiAqZCwNCj4+
ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBzdHJ1Y3QgcGNp
X2RldiAqcGRldikNCj4+ICt7DQo+PiArICAgIF9fY2xlYXJfYml0KHBkZXYtPnZwY2ktPmd1ZXN0
X3NiZGYuZGV2LCAmZC0+dnBjaV9kZXZfYXNzaWduZWRfbWFwKTsNCj4+ICsgICAgcGRldi0+dnBj
aS0+Z3Vlc3Rfc2JkZi5zYmRmID0gfjA7DQo+PiArfQ0KPiAuLi4gdGhpcyBvbmUsIGV2ZW4gd2hl
biBjb25zaWRlcmluZyBlcnJvciBwYXRocz8gT3RoZXJ3aXNlIHlvdSBtYXkNCj4gd3JvbmdseSBj
bGVhciBiaXQgMzEgaGVyZSBhZmFpY3QuDQpBY2NvcmRpbmcgdG8gUm9nZXIncyBjb21tZW50IEkg
d2lsbCBub3QgdXNlIFJFR0lTVEVSX1ZQQ0lfSU5JVA0KbWFjaGluZXJ5IGZvciB0aGlzLg0KPg0K
PiBKYW4NCj4NClRoYW5rIHlvdSwNCk9sZWtzYW5kcg==


From xen-devel-bounces@lists.xenproject.org Wed Feb 02 13:18:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 13:18:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264149.457141 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFFWW-0007ob-9H; Wed, 02 Feb 2022 13:18:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264149.457141; Wed, 02 Feb 2022 13:18:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFFWW-0007oU-6G; Wed, 02 Feb 2022 13:18:12 +0000
Received: by outflank-mailman (input) for mailman id 264149;
 Wed, 02 Feb 2022 13:18:11 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1p3Q=SR=epam.com=prvs=40324c57ab=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nFFWV-0007oO-J8
 for xen-devel@lists.xenproject.org; Wed, 02 Feb 2022 13:18:11 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 908bc752-842a-11ec-8eb8-a37418f5ba1a;
 Wed, 02 Feb 2022 14:18:10 +0100 (CET)
Received: from pps.filterd (m0174677.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 212CsOnK025015;
 Wed, 2 Feb 2022 13:17:51 GMT
Received: from eur02-am5-obe.outbound.protection.outlook.com
 (mail-am5eur02lp2055.outbound.protection.outlook.com [104.47.4.55])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3dytc5845b-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 02 Feb 2022 13:17:51 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM0PR03MB5489.eurprd03.prod.outlook.com (2603:10a6:208:177::28)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Wed, 2 Feb
 2022 13:17:47 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6%3]) with mapi id 15.20.4951.012; Wed, 2 Feb 2022
 13:17:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 908bc752-842a-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jgmVJXvuL101P17SBuCJsEiyd0NUEuZhSLPjrCIkDNPPy1AcbKGWndePjTl6MF3VJuOYPRI3BWFb5mZ3pwCXZS6A6JKSNoX/lrOpGnuke6ouaxXXLlDsea5LzFzR8pNGI1R6HuUoNy2WRmC/7K/Fw74JY4Sz6X1UACySKb3sSYyKcRUupfShtq5X6MGZk4W592h6/+GcsTObt4Mi8GsawLU0lrwSDEe6fnhwXDzzxYgwMF0WuOvn3tiUuw5ozqS2JxSk26FHcfW0LgrTwg1szTc6JnP4mUSn4CzTzNZK4/For0qXNvPkDpJinLMbat7Bs1LFXmOti0vE6CrdLN7jbw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=efJJ31+sbdYb5kwxlWVyHEgE5bPdrJf6sXYHflpwslQ=;
 b=ceNtzHTGoup0EsSASLVx162hdFVDvxgVuHjjmMty9JHRZXVoN7vhId2SyUZIoBIlDyFfCvfZYTX/jrOu9nOaJPqvdMyEaTVOCXzd152yo+3Sc36B1+L03Nh4AZPfTBg9L79J/e4iqOY1Tvmy37fGqE+FDrmJufEHIGbtFdZkfww2R5E7ZLu2en1m0EczOS7svt6dSY+OnGf8ew86nmE92NOgldkXwWRy7vKRjPLxtR2eavdLi3rDPwhRuTt2TfUTErlEY3jExExpDLR2DPXWLpZWx6b4E+GiHA2HKzIFn01J9dmGaz710SO2KdRgsTn1JUqGajv/E++JmWxH6CA2Tg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=efJJ31+sbdYb5kwxlWVyHEgE5bPdrJf6sXYHflpwslQ=;
 b=NZ3Iv9XXcl9omdRYtSRxFYj3VK9Jgc8+uhWI5iXXVYPu/m9OuYUXq/8+iCKZXHY/db5URo3BvieB8MyxBwClzT9Iawwi+kScvOrgLfUM4l/Qcs1rET4Dcy8sbukrY3y5w/mb6YBvd6j6X6iXs3MvvK8FSZu+uzSJ1TrM2XtVm0ey3qDisCdAfgQFgVRzeaan7dovSChoQutP1LY/fdEGZpZuPuix8bs6zbmadpNzOe1vYA9d0lYvYQve0lZoUVEE3m36/iubtOa8MXqCLhqJ1tJW0EheUWX6JM4cQBd1goZ/zRfrb8BpjA7IYXFUHglEE1HkwTw5fzvz3aF4D3C1SQ==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "jbeulich@suse.com" <jbeulich@suse.com>,
        "andrew.cooper3@citrix.com"
	<andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com"
	<george.dunlap@citrix.com>,
        "paul@xen.org" <paul@xen.org>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>,
        Rahul Singh <rahul.singh@arm.com>,
        Oleksandr
 Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v5 11/14] vpci: add initial support for virtual PCI bus
 topology
Thread-Topic: [PATCH v5 11/14] vpci: add initial support for virtual PCI bus
 topology
Thread-Index: AQHX4ewLCr4mT3CEwkeKGdBUjNnfXqxhH4IAgB+LLwA=
Date: Wed, 2 Feb 2022 13:17:47 +0000
Message-ID: <d5101222-26b1-f08f-1aee-d1677a2cd483@epam.com>
References: <20211125110251.2877218-1-andr2000@gmail.com>
 <20211125110251.2877218-12-andr2000@gmail.com>
 <YeAOhksC1rRuYl4x@Air-de-Roger>
In-Reply-To: <YeAOhksC1rRuYl4x@Air-de-Roger>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 2a952f78-95fb-45dc-5f6b-08d9e64e67b5
x-ms-traffictypediagnostic: AM0PR03MB5489:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM0PR03MB5489DFE7CE1446B2B75A2E45E7279@AM0PR03MB5489.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:6108;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 o4JMg6vnXVd3gX3JUzB0ElWvfneOV+Qvf08abnxdPwG0B3ZiKnTtXoeuJ+YyztjtsgFtsgi/EtVhhob7nKtELe73QktWzHuVyHozDUPlelXJTAwf/2xJyX//okgAQRKbLhRBBpiRSF8fJcmBSdsnFcgAGU9XDaOKqVor+OXYKumW/sXGacerYD6qzX8geFtvRJNdcdI8YPPpv4LxM7BMOG60/tzubbRpy0vmPbd47C9b/IflwcM+BSAYMRahSO7P0I7KqgD7cwLdMBHkLwhZzt5x12Oux49vqfci4IF0a6y+Sw7cFS+fzaY1zNjgamhP3Os8nOrEAhoxuJWuDYfMQm7URQpZSPhFeI4sQ46cG5mKt2ZsLjsbk6DoJBG/blZ44OBpuo6lydmoCFF7N6sF9dOAr7dRmoa/vNiJNPEro8ytN8oUEYXu4A8VQdN44k0PbwTyyU5WrZK0MxYW+w5N0gPKooAXvwJfO7f+UCBD1IR0y3WmrERB7ulHCVw4YPH1G1NSCMcBm6SN/vE5gkM75usVPoHAPoqRdydqKdZ9/goLH8NgILjhe5OSQcXIdHAszQCcqgpKj9pWXXROIXRAGs606vu2IzBMDoHO+vyBOwfiJCoBMRZOKJ7PB09cul/Rr6VTFbvd0RzYbYd2N2zIz4Nm6D9CteX7z106820RI2wGoHm47Q5hHGSV9YuS5vOItZ6tFEih/z/jgUkAAzHjPSDtqsUMPHcSOJt0pKZt0K4GNrhkF6wItvDT8PbmPVQU
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(86362001)(107886003)(26005)(186003)(2616005)(31696002)(71200400001)(83380400001)(4326008)(31686004)(5660300002)(91956017)(36756003)(66446008)(66476007)(8936002)(76116006)(122000001)(66556008)(7416002)(66946007)(2906002)(8676002)(64756008)(38100700002)(38070700005)(508600001)(6512007)(6506007)(53546011)(6486002)(6916009)(316002)(54906003)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?cUU4anhuNVVqOGRSZEtWbFM1MEIxT21KRGc0d0VRUWpKREtwRlRENVNkc3hX?=
 =?utf-8?B?VCtGcjBGRTFvejcyL2puYmNaaTZSZHcvTjlIa2QxYnk3cTdMWDJJa3dSYi9D?=
 =?utf-8?B?V2ZsWWZaQU00TS9mSjhRVUtyRnlGMkVwOU9DVy9icDZVN3dwNi9OVDBTMU1z?=
 =?utf-8?B?Qk44OC9jdjBSTDRHR25hOFFWekd6WllQQlFyVkNHcjArM2dna1orbXJSc09K?=
 =?utf-8?B?aWYwMllvYzBjOUFiQms3MFdQOXdBSkY2bjdySVk3cDhhY0V5VndvRHN3aVlj?=
 =?utf-8?B?N3p5alB5OGpKMGFjWDN3WFoyRTlzdG9Od2YvMEh0N0FLWm9Mb0xuTGlYVllO?=
 =?utf-8?B?UHpGYkdTOU52N2N3dExZTy92SUx6SkhXTFJBTnpwRzlXQ2hXS2RKWmpacnpp?=
 =?utf-8?B?M1gyQ3Zrdk1XY25kTHBXRGlWY0dFZ0NUa0toS29mQTlMNlN4S0FCbm5ESUVY?=
 =?utf-8?B?QlcvbFk5SVZNcEFMeW9UMzJTN25acnRab1JMaEtEb0hrbWhWeTh1MCsxcFdn?=
 =?utf-8?B?SUhQc3JyOU0xeHcyTWk4L3Y4MXNpTDdSWGV0dkl0Wks2bjIxMDFmWjg2M3NV?=
 =?utf-8?B?WVVmVlJuR0pIc3RrT0dwUnZLNUI2Z0ZFVVBsWjVJaUhGZmxJMFhBd3liRFBu?=
 =?utf-8?B?TUZNbnZYd2FTWklIZTRoQmpCWEJlTWNUbnRNL2NBZGdnRURDVDRjcEFCd0ho?=
 =?utf-8?B?b1BVdS9lWEN2KzJYTW1aZWhpRlc0RHRITElEVHcrcW4vbE5tR0ErWkp0eEx0?=
 =?utf-8?B?TWdnREptazJzMnN0elhidjFBYm5BTmNvaTNQMjBrYjMwQk9PMTVFZFpFclJy?=
 =?utf-8?B?Y0xjeHJXSitqYmUrWnZXT1pFSzk1ZEZxcXNSUy83ZXdWR1lxemtqa1YyTDNo?=
 =?utf-8?B?TkRpdDhoY0NOWjErcHIwZ2RWUWVRL09zQXpJTEhBbHd1QURmaEliNHdHTSt1?=
 =?utf-8?B?Znd5UGVib1lYbUtyYnFPQUlzZ3JxSVNWNWF5VDZESldsUG02OEt2QzVRU1BC?=
 =?utf-8?B?RUtXY2h4SDJiYUpoOWxJQWk4UE1wVFFuQzJ1ZzZhcmpJenhoQ0JLaG9ZczZl?=
 =?utf-8?B?ZkY5TnFTK05yUmJEOFpwYXoyUkZOV2dPSFE4Z0hPSUNBeVR0bnhnaG5DVFpR?=
 =?utf-8?B?WjdJZ3Q1Yytacjl2eHZnTWhSclRRZm1iK0pya09aUElMRHNKdVNTdFd2Q0VO?=
 =?utf-8?B?OGNZTUN4RGR0U0ZWSjcydUdPNFlCSU9DNDR4UUYvWUpmd0VCZHduY1VoWlFq?=
 =?utf-8?B?dm5RN01SZjBCTXNmZXJkaWdJRnFyVmdFTkd3MExac293bDdpZzVVdE5Rakpy?=
 =?utf-8?B?OG01bVVsN2EzNWdqTEtkek56MDZKdTRoZG5WNnd2dWdJMVBab2ZQRW9nQ0Nk?=
 =?utf-8?B?TCtUL0F6cFdQeHNVcWhMWFBldC9Pd1Q1LzhmcDBGNFBIckl4dkt3U0tCcmVD?=
 =?utf-8?B?cWN4YVpOL2RBMEh6dHFKSDhrUnpFdmFlWUFxK1dhUGJKdlpCdHY2UjVHZkpj?=
 =?utf-8?B?czZ3MzRFRU9lWlJhMVFscmVIc1l3SGNzdXBBcFpSM1hjVFluRm10MCtjVDI1?=
 =?utf-8?B?YjRTaHFkNmZzdno1RGFuNlUyTndkUU5FMTJjM01aaXc5ZU1wb2RXQzJkckRZ?=
 =?utf-8?B?ZHltOHNnWmxxM2JleTRWSnMwYWtNWE9TQTdNSTNuRTZUejRraEtKR0pGK3J1?=
 =?utf-8?B?T0t3eGRSWGtNWUZtcFN4MHhDdldsbjVoOUZ5Z2QweVhlYzFLSzd1VFgvUnFT?=
 =?utf-8?B?dTlHSXBUK1FqQ0hEbTVTWmVPbEpORk04aTFuRDVIMC9QQllkL3V0WDd4WXAv?=
 =?utf-8?B?ZzhISU5MT1FLSWFwSXJZTXNwdkxXTHBqcmJqMXZNdEEvOUZLZld3Z0F0MFNU?=
 =?utf-8?B?WXBwVVpRTkJmQUJIOXY4L1FVcmF5S0F1UnlFUDB2eGJXdUVoem1hcmRIdEE4?=
 =?utf-8?B?TGVWdkIwK3NPRFUyckthZDVQNE5yWEJVRkN3ZFExSWR1Z00xYVgreHdiVnBC?=
 =?utf-8?B?aEFvODQxRnpXMDFNbkZ6WDZtbmhIWWFRNlV2THl5NUxRQUMwRURPbEhWQnBW?=
 =?utf-8?B?YWRCRUhSaEdnNnFiZk9nZEVZUjVlWkp2RzdjLzdFd3VGT09RcXZObEg2c21G?=
 =?utf-8?B?Vk5pNndIcXM1Q2hmM2hKaFVaODdGbHQzdnpqT0U0cytoajdNTzBlM1ZHYlRi?=
 =?utf-8?B?bytuUzh3T2VTYnNvK3lsZG8yaTVMS2ZtNGVCRDNuT3hXT0dKb2V0RjlkNEt4?=
 =?utf-8?B?a0Q1aFVsNmZoeGQ0N3JldnoxR1pPLzRqWDdGOW44endmQlcvbk1FVjlISUFG?=
 =?utf-8?B?MWRsZTVlTWxKbzVTR25EbjZ3eTNvQ0xQRVlYZXJzM0dQTFdLWitWZz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <CD2821F7E198DB4C94E94134DF3DE780@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2a952f78-95fb-45dc-5f6b-08d9e64e67b5
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Feb 2022 13:17:47.0475
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: oPx8BfRF/FTpB2ckIOpIUqqXF3MqnD0oTDSrL1Dd2BqJvPqDCZPatCsU8MK4RcZJ2lDOi8HucOfufsFeyiShHLv5UoFh8CzJK+h3NcciuV1H32Bnos2Ck4VpNFQgSZBP
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB5489
X-Proofpoint-GUID: qQQd6bHqZs3QkXf_ThDudl2iMvXApkyr
X-Proofpoint-ORIG-GUID: qQQd6bHqZs3QkXf_ThDudl2iMvXApkyr
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-02_06,2022-02-01_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 malwarescore=0
 lowpriorityscore=0 bulkscore=0 clxscore=1015 mlxlogscore=999 adultscore=0
 impostorscore=0 mlxscore=0 suspectscore=0 phishscore=0 priorityscore=1501
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2202020073

SGksIFJvZ2VyIQ0KDQpPbiAxMy4wMS4yMiAxMzozNSwgUm9nZXIgUGF1IE1vbm7DqSB3cm90ZToN
Cj4gT24gVGh1LCBOb3YgMjUsIDIwMjEgYXQgMDE6MDI6NDhQTSArMDIwMCwgT2xla3NhbmRyIEFu
ZHJ1c2hjaGVua28gd3JvdGU6DQo+PiBGcm9tOiBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyA8b2xl
a3NhbmRyX2FuZHJ1c2hjaGVua29AZXBhbS5jb20+DQo+Pg0KPj4gQXNzaWduIFNCREYgdG8gdGhl
IFBDSSBkZXZpY2VzIGJlaW5nIHBhc3NlZCB0aHJvdWdoIHdpdGggYnVzIDAuDQo+PiBUaGUgcmVz
dWx0aW5nIHRvcG9sb2d5IGlzIHdoZXJlIFBDSWUgZGV2aWNlcyByZXNpZGUgb24gdGhlIGJ1cyAw
IG9mIHRoZQ0KPj4gcm9vdCBjb21wbGV4IGl0c2VsZiAoZW1iZWRkZWQgZW5kcG9pbnRzKS4NCj4+
IFRoaXMgaW1wbGVtZW50YXRpb24gaXMgbGltaXRlZCB0byAzMiBkZXZpY2VzIHdoaWNoIGFyZSBh
bGxvd2VkIG9uDQo+PiBhIHNpbmdsZSBQQ0kgYnVzLg0KPj4NCj4+IFBsZWFzZSBub3RlLCB0aGF0
IGF0IHRoZSBtb21lbnQgb25seSBmdW5jdGlvbiAwIG9mIGEgbXVsdGlmdW5jdGlvbg0KPj4gZGV2
aWNlIGNhbiBiZSBwYXNzZWQgdGhyb3VnaC4NCj4+DQo+PiBTaWduZWQtb2ZmLWJ5OiBPbGVrc2Fu
ZHIgQW5kcnVzaGNoZW5rbyA8b2xla3NhbmRyX2FuZHJ1c2hjaGVua29AZXBhbS5jb20+DQo+PiAt
LS0NCj4+IFNpbmNlIHY0Og0KPj4gLSBtb3ZlZCBhbmQgcmUtd29ya2VkIGd1ZXN0IHNiZGYgaW5p
dGlhbGl6ZXJzDQo+PiAtIHMvc2V0X2JpdC9fX3NldF9iaXQNCj4+IC0gcy9jbGVhcl9iaXQvX19j
bGVhcl9iaXQNCj4+IC0gbWlub3IgY29tbWVudCBmaXggcy9WaXJ0dWFsL0d1ZXN0Lw0KPj4gLSBh
ZGRlZCBWUENJX01BWF9WSVJUX0RFViBjb25zdGFudCAoUENJX1NMT1QofjApICsgMSkgd2hpY2gg
d2lsbCBiZSB1c2VkDQo+PiAgICBsYXRlciBmb3IgY291bnRpbmcgdGhlIG51bWJlciBvZiBNTUlP
IGhhbmRsZXJzIHJlcXVpcmVkIGZvciBhIGd1ZXN0DQo+PiAgICAoSnVsaWVuKQ0KPj4gU2luY2Ug
djM6DQo+PiAgIC0gbWFrZSB1c2Ugb2YgVlBDSV9JTklUDQo+PiAgIC0gbW92ZWQgYWxsIG5ldyBj
b2RlIHRvIHZwY2kuYyB3aGljaCBiZWxvbmdzIHRvIGl0DQo+PiAgIC0gY2hhbmdlZCBvcGVuLWNv
ZGVkIDMxIHRvIFBDSV9TTE9UKH4wKQ0KPj4gICAtIGFkZGVkIGNvbW1lbnRzIGFuZCBjb2RlIHRv
IHJlamVjdCBtdWx0aWZ1bmN0aW9uIGRldmljZXMgd2l0aA0KPj4gICAgIGZ1bmN0aW9ucyBvdGhl
ciB0aGFuIDANCj4+ICAgLSB1cGRhdGVkIGNvbW1lbnQgYWJvdXQgdnBjaV9kZXZfbmV4dCBhbmQg
bWFkZSBpdCB1bnNpZ25lZCBpbnQNCj4+ICAgLSBpbXBsZW1lbnQgcm9sbCBiYWNrIGluIGNhc2Ug
b2YgZXJyb3Igd2hpbGUgYXNzaWduaW5nL2RlYXNzaWduaW5nIGRldmljZXMNCj4+ICAgLSBzL2Rv
bSVwZC8lcGQNCj4+IFNpbmNlIHYyOg0KPj4gICAtIHJlbW92ZSBjYXN0cyB0aGF0IGFyZSAoYSkg
bWFsZm9ybWVkIGFuZCAoYikgdW5uZWNlc3NhcnkNCj4+ICAgLSBhZGQgbmV3IGxpbmUgZm9yIGJl
dHRlciByZWFkYWJpbGl0eQ0KPj4gICAtIHJlbW92ZSBDT05GSUdfSEFTX1ZQQ0lfR1VFU1RfU1VQ
UE9SVCBpZmRlZidzIGFzIHRoZSByZWxldmFudCB2UENJDQo+PiAgICAgIGZ1bmN0aW9ucyBhcmUg
bm93IGNvbXBsZXRlbHkgZ2F0ZWQgd2l0aCB0aGlzIGNvbmZpZw0KPj4gICAtIGdhdGUgY29tbW9u
IGNvZGUgd2l0aCBDT05GSUdfSEFTX1ZQQ0lfR1VFU1RfU1VQUE9SVA0KPj4gTmV3IGluIHYyDQo+
PiAtLS0NCj4+ICAgeGVuL2RyaXZlcnMvdnBjaS92cGNpLmMgfCA1MSArKysrKysrKysrKysrKysr
KysrKysrKysrKysrKysrKysrKysrKysrKw0KPj4gICB4ZW4vaW5jbHVkZS94ZW4vc2NoZWQuaCB8
ICA4ICsrKysrKysNCj4+ICAgeGVuL2luY2x1ZGUveGVuL3ZwY2kuaCAgfCAxMSArKysrKysrKysN
Cj4+ICAgMyBmaWxlcyBjaGFuZ2VkLCA3MCBpbnNlcnRpb25zKCspDQo+Pg0KPj4gZGlmZiAtLWdp
dCBhL3hlbi9kcml2ZXJzL3ZwY2kvdnBjaS5jIGIveGVuL2RyaXZlcnMvdnBjaS92cGNpLmMNCj4+
IGluZGV4IDk4YjEyYTYxYmU2Zi4uYzJmYjRkNGRiMjMzIDEwMDY0NA0KPj4gLS0tIGEveGVuL2Ry
aXZlcnMvdnBjaS92cGNpLmMNCj4+ICsrKyBiL3hlbi9kcml2ZXJzL3ZwY2kvdnBjaS5jDQo+PiBA
QCAtMTE0LDYgKzExNCw5IEBAIGludCB2cGNpX2FkZF9oYW5kbGVycyhzdHJ1Y3QgcGNpX2RldiAq
cGRldikNCj4+ICAgICAgIHNwaW5fbG9jaygmcGRldi0+dnBjaV9sb2NrKTsNCj4+ICAgICAgIHBk
ZXYtPnZwY2kgPSB2cGNpOw0KPj4gICAgICAgSU5JVF9MSVNUX0hFQUQoJnBkZXYtPnZwY2ktPmhh
bmRsZXJzKTsNCj4+ICsjaWZkZWYgQ09ORklHX0hBU19WUENJX0dVRVNUX1NVUFBPUlQNCj4+ICsg
ICAgcGRldi0+dnBjaS0+Z3Vlc3Rfc2JkZi5zYmRmID0gfjA7DQo+PiArI2VuZGlmDQo+PiAgIA0K
Pj4gICAgICAgaGVhZGVyID0gJnBkZXYtPnZwY2ktPmhlYWRlcjsNCj4+ICAgICAgIGZvciAoIGkg
PSAwOyBpIDwgQVJSQVlfU0laRShoZWFkZXItPmJhcnMpOyBpKysgKQ0KPj4gQEAgLTE0NSw2ICsx
NDgsNTMgQEAgaW50IHZwY2lfYWRkX2hhbmRsZXJzKHN0cnVjdCBwY2lfZGV2ICpwZGV2KQ0KPj4g
ICB9DQo+PiAgIA0KPj4gICAjaWZkZWYgQ09ORklHX0hBU19WUENJX0dVRVNUX1NVUFBPUlQNCj4+
ICtpbnQgdnBjaV9hZGRfdmlydHVhbF9kZXZpY2Uoc3RydWN0IHBjaV9kZXYgKnBkZXYpDQo+PiAr
ew0KPj4gKyAgICBzdHJ1Y3QgZG9tYWluICpkID0gcGRldi0+ZG9tYWluOw0KPj4gKyAgICBwY2lf
c2JkZl90IHNiZGYgPSB7IDAgfTsNCj4+ICsgICAgdW5zaWduZWQgbG9uZyBuZXdfZGV2X251bWJl
cjsNCj4gSSB0aGluayB0aGlzIG5lZWRzIHRvIGJlIGxpbWl0ZWQgdG8gbm9uLWhhcmR3YXJlIGRv
bWFpbnM/DQo+DQo+IE9yIGVsc2UgeW91IHdpbGwgcmVwb3J0IGZhaWx1cmVzIGZvciB0aGUgaGFy
ZHdhcmUgZG9tYWluIGV2ZW4gaWYgaXQncw0KPiBub3QgdXNpbmcgdGhlIHZpcnR1YWwgdG9wb2xv
Z3kgYXQgYWxsLg0KWWVzLCB0aGlzIHdhbnRzIGFuIGlzX2hhcmR3YXJlX2RvbWFpbiBjaGVjaw0K
Pg0KPj4gKyAgICAvKg0KPj4gKyAgICAgKiBFYWNoIFBDSSBidXMgc3VwcG9ydHMgMzIgZGV2aWNl
cy9zbG90cyBhdCBtYXggb3IgdXAgdG8gMjU2IHdoZW4NCj4+ICsgICAgICogdGhlcmUgYXJlIG11
bHRpLWZ1bmN0aW9uIG9uZXMgd2hpY2ggYXJlIG5vdCB5ZXQgc3VwcG9ydGVkLg0KPj4gKyAgICAg
Ki8NCj4+ICsgICAgaWYgKCBwZGV2LT5pbmZvLmlzX2V4dGZuICkNCj4+ICsgICAgew0KPj4gKyAg
ICAgICAgZ2RwcmludGsoWEVOTE9HX0VSUiwgIiVwcDogb25seSBmdW5jdGlvbiAwIHBhc3N0aHJv
dWdoIHN1cHBvcnRlZFxuIiwNCj4+ICsgICAgICAgICAgICAgICAgICZwZGV2LT5zYmRmKTsNCj4+
ICsgICAgICAgIHJldHVybiAtRU9QTk9UU1VQUDsNCj4+ICsgICAgfQ0KPj4gKw0KPj4gKyAgICBu
ZXdfZGV2X251bWJlciA9IGZpbmRfZmlyc3RfemVyb19iaXQoJmQtPnZwY2lfZGV2X2Fzc2lnbmVk
X21hcCwNCj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFZQQ0lf
TUFYX1ZJUlRfREVWKTsNCj4+ICsgICAgaWYgKCBuZXdfZGV2X251bWJlciA+PSBWUENJX01BWF9W
SVJUX0RFViApDQo+PiArICAgICAgICByZXR1cm4gLUVOT1NQQzsNCj4+ICsNCj4+ICsgICAgX19z
ZXRfYml0KG5ld19kZXZfbnVtYmVyLCAmZC0+dnBjaV9kZXZfYXNzaWduZWRfbWFwKTsNCj4gSG93
IGlzIHZwY2lfZGV2X2Fzc2lnbmVkX21hcCBwcm90ZWN0ZWQgZnJvbSBjb25jdXJyZW50IGFjY2Vz
c2VzPyBEb2VzDQo+IGl0IHJlbHkgb24gdGhlIHBjaWRldnMgbG9jayBiZWluZyBoZWxkIHdoaWxl
IGFjY2Vzc2luZyBpdD8NCkl0IGRvZXMgcmVseSBvbiBwY2lkZXZzIGxvY2ssIEknbGwgYWRkIGFu
IGFzc2VydCBoZXJlDQo+DQo+IElmIHNvIGl0IG5lZWRzIHNwZWxsaW5nIG91dCAoYW5kIGxpa2Vs
eSBhbiBhc3NlcnQgYWRkZWQpLg0KPg0KPj4gKyAgICAvKg0KPj4gKyAgICAgKiBCb3RoIHNlZ21l
bnQgYW5kIGJ1cyBudW1iZXIgYXJlIDA6DQo+PiArICAgICAqICAtIHdlIGVtdWxhdGUgYSBzaW5n
bGUgaG9zdCBicmlkZ2UgZm9yIHRoZSBndWVzdCwgZS5nLiBzZWdtZW50IDANCj4+ICsgICAgICog
IC0gd2l0aCBidXMgMCB0aGUgdmlydHVhbCBkZXZpY2VzIGFyZSBzZWVuIGFzIGVtYmVkZGVkDQo+
PiArICAgICAqICAgIGVuZHBvaW50cyBiZWhpbmQgdGhlIHJvb3QgY29tcGxleA0KPj4gKyAgICAg
Kg0KPj4gKyAgICAgKiBUT0RPOiBhZGQgc3VwcG9ydCBmb3IgbXVsdGktZnVuY3Rpb24gZGV2aWNl
cy4NCj4+ICsgICAgICovDQo+PiArICAgIHNiZGYuZGV2Zm4gPSBQQ0lfREVWRk4obmV3X2Rldl9u
dW1iZXIsIDApOw0KPj4gKyAgICBwZGV2LT52cGNpLT5ndWVzdF9zYmRmID0gc2JkZjsNCj4+ICsN
Cj4+ICsgICAgcmV0dXJuIDA7DQo+PiArDQo+PiArfQ0KPj4gK1JFR0lTVEVSX1ZQQ0lfSU5JVCh2
cGNpX2FkZF92aXJ0dWFsX2RldmljZSwgVlBDSV9QUklPUklUWV9NSURETEUpOw0KPiBJJ20gdW5z
dXJlIHRoaXMgaXMgdGhlIHJpZ2h0IHBsYWNlIHRvIGRvIHZpcnR1YWwgU0JERiBhc3NpZ25tZW50
LCBteQ0KPiBwbGFuIHdhcyB0byB1c2UgUkVHSVNURVJfVlBDSV9JTklUIGV4Y2x1c2l2ZWx5IHdp
dGggUENJIGNhcGFiaWxpdGllcy4NCj4NCj4gSSB0aGluayBpdCB3b3VsZCBiZSBiZXR0ZXIgdG8g
ZG8gdGhlIHZpcnR1YWwgU0JERiBhc3NpZ25tZW50IGZyb20NCj4gdnBjaV9hc3NpZ25fZGV2aWNl
Lg0KT2ssIHdpbGwgZG8NCj4NCj4+ICsNCj4+ICtzdGF0aWMgdm9pZCB2cGNpX3JlbW92ZV92aXJ0
dWFsX2RldmljZShzdHJ1Y3QgZG9tYWluICpkLA0KPj4gKyAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgIGNvbnN0IHN0cnVjdCBwY2lfZGV2ICpwZGV2KQ0KPj4gK3sNCj4+ICsg
ICAgX19jbGVhcl9iaXQocGRldi0+dnBjaS0+Z3Vlc3Rfc2JkZi5kZXYsICZkLT52cGNpX2Rldl9h
c3NpZ25lZF9tYXApOw0KPj4gKyAgICBwZGV2LT52cGNpLT5ndWVzdF9zYmRmLnNiZGYgPSB+MDsN
Cj4+ICt9DQo+PiArDQo+PiAgIC8qIE5vdGlmeSB2UENJIHRoYXQgZGV2aWNlIGlzIGFzc2lnbmVk
IHRvIGd1ZXN0LiAqLw0KPj4gICBpbnQgdnBjaV9hc3NpZ25fZGV2aWNlKHN0cnVjdCBkb21haW4g
KmQsIHN0cnVjdCBwY2lfZGV2ICpwZGV2KQ0KPj4gICB7DQo+PiBAQCAtMTcxLDYgKzIyMSw3IEBA
IGludCB2cGNpX2RlYXNzaWduX2RldmljZShzdHJ1Y3QgZG9tYWluICpkLCBzdHJ1Y3QgcGNpX2Rl
diAqcGRldikNCj4+ICAgICAgICAgICByZXR1cm4gMDsNCj4+ICAgDQo+PiAgICAgICBzcGluX2xv
Y2soJnBkZXYtPnZwY2lfbG9jayk7DQo+PiArICAgIHZwY2lfcmVtb3ZlX3ZpcnR1YWxfZGV2aWNl
KGQsIHBkZXYpOw0KPj4gICAgICAgdnBjaV9yZW1vdmVfZGV2aWNlX2hhbmRsZXJzX2xvY2tlZChw
ZGV2KTsNCj4+ICAgICAgIHNwaW5fdW5sb2NrKCZwZGV2LT52cGNpX2xvY2spOw0KPj4gICANCj4+
IGRpZmYgLS1naXQgYS94ZW4vaW5jbHVkZS94ZW4vc2NoZWQuaCBiL3hlbi9pbmNsdWRlL3hlbi9z
Y2hlZC5oDQo+PiBpbmRleCAyODE0NmVlNDA0ZTYuLjEwYmZmMTAzMzE3YyAxMDA2NDQNCj4+IC0t
LSBhL3hlbi9pbmNsdWRlL3hlbi9zY2hlZC5oDQo+PiArKysgYi94ZW4vaW5jbHVkZS94ZW4vc2No
ZWQuaA0KPj4gQEAgLTQ0NCw2ICs0NDQsMTQgQEAgc3RydWN0IGRvbWFpbg0KPj4gICANCj4+ICAg
I2lmZGVmIENPTkZJR19IQVNfUENJDQo+PiAgICAgICBzdHJ1Y3QgbGlzdF9oZWFkIHBkZXZfbGlz
dDsNCj4+ICsjaWZkZWYgQ09ORklHX0hBU19WUENJX0dVRVNUX1NVUFBPUlQNCj4+ICsgICAgLyoN
Cj4+ICsgICAgICogVGhlIGJpdG1hcCB3aGljaCBzaG93cyB3aGljaCBkZXZpY2UgbnVtYmVycyBh
cmUgYWxyZWFkeSB1c2VkIGJ5IHRoZQ0KPj4gKyAgICAgKiB2aXJ0dWFsIFBDSSBidXMgdG9wb2xv
Z3kgYW5kIGlzIHVzZWQgdG8gYXNzaWduIGEgdW5pcXVlIFNCREYgdG8gdGhlDQo+PiArICAgICAq
IG5leHQgcGFzc2VkIHRocm91Z2ggdmlydHVhbCBQQ0kgZGV2aWNlLg0KPj4gKyAgICAgKi8NCj4+
ICsgICAgdW5zaWduZWQgbG9uZyB2cGNpX2Rldl9hc3NpZ25lZF9tYXA7DQo+IFBsZWFzZSB1c2Ug
REVDTEFSRV9CSVRNQVAgd2l0aCB0aGUgbWF4aW11bSBudW1iZXIgb2Ygc3VwcG9ydGVkDQo+IGRl
dmljZXMgYXMgcGFyYW1ldGVyLg0KV2lsbCB1c2UNCj4NCj4+ICsjZW5kaWYNCj4+ICAgI2VuZGlm
DQo+PiAgIA0KPj4gICAjaWZkZWYgQ09ORklHX0hBU19QQVNTVEhST1VHSA0KPj4gZGlmZiAtLWdp
dCBhL3hlbi9pbmNsdWRlL3hlbi92cGNpLmggYi94ZW4vaW5jbHVkZS94ZW4vdnBjaS5oDQo+PiBp
bmRleCAxODMxOWZjMzI5ZjkuLmU1MjU4YmQ3Y2U5MCAxMDA2NDQNCj4+IC0tLSBhL3hlbi9pbmNs
dWRlL3hlbi92cGNpLmgNCj4+ICsrKyBiL3hlbi9pbmNsdWRlL3hlbi92cGNpLmgNCj4+IEBAIC0y
MSw2ICsyMSwxMyBAQCB0eXBlZGVmIGludCB2cGNpX3JlZ2lzdGVyX2luaXRfdChzdHJ1Y3QgcGNp
X2RldiAqZGV2KTsNCj4+ICAgDQo+PiAgICNkZWZpbmUgVlBDSV9FQ0FNX0JERihhZGRyKSAgICAg
KCgoYWRkcikgJiAweDBmZmZmMDAwKSA+PiAxMikNCj4+ICAgDQo+PiArLyoNCj4+ICsgKiBNYXhp
bXVtIG51bWJlciBvZiBkZXZpY2VzIHN1cHBvcnRlZCBieSB0aGUgdmlydHVhbCBidXMgdG9wb2xv
Z3k6DQo+PiArICogZWFjaCBQQ0kgYnVzIHN1cHBvcnRzIDMyIGRldmljZXMvc2xvdHMgYXQgbWF4
IG9yIHVwIHRvIDI1NiB3aGVuDQo+PiArICogdGhlcmUgYXJlIG11bHRpLWZ1bmN0aW9uIG9uZXMg
d2hpY2ggYXJlIG5vdCB5ZXQgc3VwcG9ydGVkLg0KPj4gKyAqLw0KPj4gKyNkZWZpbmUgVlBDSV9N
QVhfVklSVF9ERVYgICAgICAgKFBDSV9TTE9UKH4wKSArIDEpDQo+PiArDQo+PiAgICNkZWZpbmUg
UkVHSVNURVJfVlBDSV9JTklUKHgsIHApICAgICAgICAgICAgICAgIFwNCj4+ICAgICBzdGF0aWMg
dnBjaV9yZWdpc3Rlcl9pbml0X3QgKmNvbnN0IHgjI19lbnRyeSAgXA0KPj4gICAgICAgICAgICAg
ICAgICBfX3VzZWRfc2VjdGlvbigiLmRhdGEudnBjaS4iIHApID0geA0KPj4gQEAgLTE0Myw2ICsx
NTAsMTAgQEAgc3RydWN0IHZwY2kgew0KPj4gICAgICAgICAgICAgICBzdHJ1Y3QgdnBjaV9hcmNo
X21zaXhfZW50cnkgYXJjaDsNCj4+ICAgICAgICAgICB9IGVudHJpZXNbXTsNCj4+ICAgICAgIH0g
Km1zaXg7DQo+PiArI2lmZGVmIENPTkZJR19IQVNfVlBDSV9HVUVTVF9TVVBQT1JUDQo+PiArICAg
IC8qIEd1ZXN0IFNCREYgb2YgdGhlIGRldmljZS4gKi8NCj4+ICsgICAgcGNpX3NiZGZfdCBndWVz
dF9zYmRmOw0KPj4gKyNlbmRpZg0KPj4gICAjZW5kaWYNCj4+ICAgfTsNCj4+ICAgDQo+PiAtLSAN
Cj4+IDIuMjUuMQ0KPj4NClRoYW5rIHlvdSwNCk9sZWtzYW5kcg==


From xen-devel-bounces@lists.xenproject.org Wed Feb 02 13:20:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 13:20:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264155.457153 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFFZ1-0000iw-Nz; Wed, 02 Feb 2022 13:20:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264155.457153; Wed, 02 Feb 2022 13:20:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFFZ1-0000ip-L0; Wed, 02 Feb 2022 13:20:47 +0000
Received: by outflank-mailman (input) for mailman id 264155;
 Wed, 02 Feb 2022 13:20:47 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nFFZ1-0000if-1r; Wed, 02 Feb 2022 13:20:47 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nFFZ0-00021G-U4; Wed, 02 Feb 2022 13:20:46 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nFFZ0-00041E-F8; Wed, 02 Feb 2022 13:20:46 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nFFZ0-00066O-Ee; Wed, 02 Feb 2022 13:20:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=APP8YDyDmPZQakGy0GVu2kIx7yAO4KAD5TUwIQSsPkc=; b=k901syQeq5P2NvJNMfnI8WCXcm
	GR5bSjiE1ZHM/uyTwlFw/nncB6epf+aSLjMSgNrrmAEQFFeKPXbYJV6qAWzrH/FHmPsMNyS//sR2F
	3PsZ4qGTbTquPSabDl9Bn9NGtKAU+imrccWeUaSOA2OWpp8ORMEQt3awBhHzjmXo8xjg=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167981-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 167981: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=3bbe296c1c7a6ddce7a294e006b8c4a53b385292
X-Osstest-Versions-That:
    qemuu=5cbe64110dbe27f82d30552001acdc5eeaade11c
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 02 Feb 2022 13:20:46 +0000

flight 167981 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167981/

Failures :-/ but no regressions.

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds    18 guest-start/debian.repeat fail REGR. vs. 167975

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167975
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167975
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167975
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167975
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167975
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167975
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167975
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167975
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                3bbe296c1c7a6ddce7a294e006b8c4a53b385292
baseline version:
 qemuu                5cbe64110dbe27f82d30552001acdc5eeaade11c

Last test of basis   167975  2022-02-01 17:07:09 Z    0 days
Testing same since   167981  2022-02-02 02:57:48 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Emanuele Giuseppe Esposito <eesposit@redhat.com>
  Hanna Reitz <hreitz@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Maydell <peter.maydell@linaro.org>
  Thomas Huth <thuth@redhat.com>
  Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   5cbe64110d..3bbe296c1c  3bbe296c1c7a6ddce7a294e006b8c4a53b385292 -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Wed Feb 02 13:21:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 13:21:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264165.457164 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFFZp-0001Kj-7y; Wed, 02 Feb 2022 13:21:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264165.457164; Wed, 02 Feb 2022 13:21:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFFZp-0001Kc-4z; Wed, 02 Feb 2022 13:21:37 +0000
Received: by outflank-mailman (input) for mailman id 264165;
 Wed, 02 Feb 2022 13:21:35 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=6WyI=SR=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nFFZn-00013U-AY
 for xen-devel@lists.xenproject.org; Wed, 02 Feb 2022 13:21:35 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0abaffbc-842b-11ec-8eb8-a37418f5ba1a;
 Wed, 02 Feb 2022 14:21:34 +0100 (CET)
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur02lp2052.outbound.protection.outlook.com [104.47.4.52]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-24-DjTnkOKNMgGyxK7OJb9y1Q-1; Wed, 02 Feb 2022 14:21:19 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM6PR0402MB3368.eurprd04.prod.outlook.com (2603:10a6:209:a::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Wed, 2 Feb
 2022 13:21:16 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.012; Wed, 2 Feb 2022
 13:21:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0abaffbc-842b-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1643808093;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=6zlLrFmQ+qOU0teSgTbZsYIGloJOdwYOn1YdOyUgAuI=;
	b=kS6n/RYa85pv9b0wwE1uWMLcEa0KOX4LNrwnPSkcGgFNcClPEc/1l7Mkd/VzZgUXg/eEt7
	czGlIbRP4+BX+3i4+iueKJQjSthQoqFJvC2JJOpzvDSrQbH7W7VZXK79BIB+ybtkcNHEjA
	zhvVZ1mACfCKd5LHe11seRqvwpV3JJ8=
X-MC-Unique: DjTnkOKNMgGyxK7OJb9y1Q-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Y6tE9MYgd/N1BvHK9dLh+/jESXyeAsfmg6/WsxXlXuT8OBqPEBNowYPGItOjZoLKmLmKEWJH6XjQPMduJ1fZA6saiIq+2nDx238innQliJ9vv3hCTZfBvRvNCsZtpEKQAOuapY/UC2e+ZXXh0NfOMZ98mL8e/5Y/kbGgcP21w8kklVQZScyHo1IJkGnDQzbHz7f692rlDBMcJ1xmR7crgSBL28vwO+qbw8zNTTJmwsUwDOWD4G1uEJl7xjTkCzvO0Nm9pciE9lKXvGECOKKMvXISAY54aqTLxiuny0NYJWBMh0C4Q7P2tB3ZlQrSJW8LPmj0YdwT44BCCVXv62jDLA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=MvCMUBlsWjf8kbdnJF6lsZiPWn0BJc9zVPZpXdap5yk=;
 b=WxqqBDDNGIMzjMSz/Uje3dfcxvvCwe53aq/cyQX2mYMknz/wfbgrErNgjXFbmWmggCsC+ix33Yd6nv+kP6COq+l7eCdYzXJO5pHdrxaHHog12+o0tRWMPdK99W2DwNlPrHfi5suTWNVncP6d/uldAZ63F0dya6Ql5C79jKHnXw/yr/sQ18ZX23tNc8JNOwFEK8tSXXQsu+xzixUr3NhtxsR+/kFh1OBVUphLuqTDOCoAOi1ZoHb7ps+7WkROtSfNA7/NMWrHV6dTflLawW8ImIbInP9A0NBWJfxfN1w9MEUCOEKJK82LZ9WQhQGCpZtN1rTa/eBj9LJD9wV5idPDLw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <44592911-0f78-d4ea-9c37-22dda98aed66@suse.com>
Date: Wed, 2 Feb 2022 14:21:13 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v3] xen/pci: detect when BARs are not suitably positioned
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Paul Durrant <paul@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220201124551.2392-1-roger.pau@citrix.com>
 <59685ca1-0587-a975-bf5b-56058b650c3a@suse.com>
 <Yfp1Unn9rIrwf78I@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Yfp1Unn9rIrwf78I@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: FR0P281CA0015.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:15::20) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9354aa72-77b7-43d5-e8bb-08d9e64ee477
X-MS-TrafficTypeDiagnostic: AM6PR0402MB3368:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR0402MB3368F3EA2C00D2F48BF76FB1B3279@AM6PR0402MB3368.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	zMV9BgAfD0fYakdKwmN0lv5RymcWpwLBrfx1VJx2OtEiSbIUkaFd8PQuDp1IIDzd9YrQKMBXLH14MOn6uVdfKBqLbZZDaJJgRcgIPfu0AvuOuCr/jyFjaGOZikd4fKlz7Ug72QCeBOdgkWCsM2NFVuoCP23PLGptZLqKwsdossG4TeMDmrmBX+tF7uoXBxxxpyHOasbXXzVLTmCQC9LAzLQVYdCtgisvqFp6GaWYY6DRsLeUkMoGKX+p5u5YO8tCEC5+LZW3k3zquoUMv6VPCHT3Ghw1hlsa5TiImnsxJlJrd4CqNVAyAW3JJutcusN6ZoFNFVHRkBxDHeelk/hCxUCf9fVviPo54kVQ/XV84QhaQqIO92al6e7xga1zcjE7nB24Q8d4XPbzJG3CyMhfomEev5faGUr79WxTMcZFB14Nk9wev6wLVAKlTgx/aHC+OnNPkpPtYVBxlKkyBxBMuXgiSPDtNYRXxsUkDQQ+cdJ3s+dvJnsTuEF4Ws+jh41irp3CIs3DX1B8JDQk7FSkvIogLQBSWXCUKMxfMPI3OuAtIPsidyJudXHp7cS4yQIx52nRKveggmKg1Kpwfb+VZoi9waNSEguAVb7GiAZDt+vsCk3+A0ebPBbFD3isdowAIwANYIN/MnAcQQksxQ6/jUY6hp2EhBSvWGI4mmBuBO1CnM0xsGjpJP68wA9UW7MKGhp2Lb64/MvScvg/b4O7GlG2IVwQ3rf3if/lgBqv+WI=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(316002)(38100700002)(54906003)(8936002)(8676002)(66556008)(4326008)(6916009)(66946007)(36756003)(66476007)(31696002)(5660300002)(86362001)(2616005)(2906002)(31686004)(6506007)(53546011)(6666004)(4744005)(6512007)(26005)(186003)(6486002)(508600001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?w8LCia/WaVDGboaX1r8XzS2vLi0SBsIFdzK500k9IQxLl4Am6pftoxNZlODW?=
 =?us-ascii?Q?3paM9/FagQuFHzg7VcF9MaYSwqPRRyd4aFH7q0FR4V1OfPMJtiFJGfJiApyQ?=
 =?us-ascii?Q?LZaWI5Ts5qbJ+p01tDTqHfvMLlTh5opScTIfyrtfwF/GEbnKXZ3jafvluAZR?=
 =?us-ascii?Q?lTlLkf/fkm5ZmQYoRwxICWgDsz8P4ykEPndx7zB23M49pgsSNjqV7zb3/EL+?=
 =?us-ascii?Q?RyGu+YyvstvTelIYgKvUpYHFufiW9EkF4ClIlygF/vd3ZeqtE6etACFrWbdN?=
 =?us-ascii?Q?p7P2b/UnuoqHIWUZwkI9mWiH2z8uJ/vmrWATisAEzXiVeGjX91ehdsHekCrB?=
 =?us-ascii?Q?uioN3QrnkJImMEs34ab7cmG/s/EMWZqcsJV97Llz3Zy9gDUfRjHfO6mLFPPS?=
 =?us-ascii?Q?gC3Nc/FWJJoU84jEEbzrh95rqpZ5N9L/tzAI1hqrZf2HLVDl0miFh/xTcEUT?=
 =?us-ascii?Q?8OOikeuLhTdrLQS5XTybCAEy3u5gqwrFyn5lU4NP+L3761KZ1k04DApoiyFc?=
 =?us-ascii?Q?wUQzy+Zuk7N5Vhq4BEcjgMfZvjvPTfUwIWqSNzIGXBisu5Peypxnb4WSlQrg?=
 =?us-ascii?Q?KmNkxUhQGZXAuWgj7E2BVubedAv5Jl3uXH7ua9GVszUaB34Qh6t5s6EwY43V?=
 =?us-ascii?Q?RAZPyuKyPyflyFsMNtduINLY5chXGOkdcP06kevw1Fv+ziR1UHewaisBTgwc?=
 =?us-ascii?Q?HzwsD2PMqcwV9mTVLMPHeoZ5QOBAOaWvf8x8YurFZ4sZUwCQuW4c7lnx5P0g?=
 =?us-ascii?Q?KCK534EA31R/dJW8TpaO/OM8jOrA+ze1RyWkAQZBWccQCwps9uox1am4kv2b?=
 =?us-ascii?Q?b0BPpScy2CDE2MKP+mF/3xDPgUGKlzj4zfQASHJloVt4GQNsTGcXjk1luRM+?=
 =?us-ascii?Q?4y5cEfse/Gn3LP1q3crB1jyOxd7MYCeSg/XH2JO95Ca3QBp+GgYlvJxtH8Cj?=
 =?us-ascii?Q?f87+baxU1xUrZ4swnI+jjZYA1ys/qspUUofi5c/HaM2boJqsZbWzvc+zOVjQ?=
 =?us-ascii?Q?HYD3uDw67lgrtPTE2mp6S6kC/dqDpyI27unUzqreyi8HNQBk/A6lPnkkivg6?=
 =?us-ascii?Q?kkTNddEqgIQl/MoPgHS+ZYyKOZybCUOO/sVd7ZwtEHF4F8/8ueCZhfSbvXeJ?=
 =?us-ascii?Q?J1CHC1HNBbnQ4CwwpYWNxH2js2brHTaoEt3FtRTB9Crs1mCEnFkdnfuNBfJe?=
 =?us-ascii?Q?+45wnq6bfmWAgaZoJ51t5072/Im+9NF+XOleUM7XZQscxygLUQJrWmSW+ltj?=
 =?us-ascii?Q?h/uzV91iEhMBtSBvPC8yqUgFF8B4l8+FAvNFuauhQpYk/pJV4k4qFdW5vcaa?=
 =?us-ascii?Q?o4na5py0dQrKJ2BaQhpZXS5M9W8eM4p5YMtrKdZhTSk3mXuI6bsJ/8DGtNlD?=
 =?us-ascii?Q?SCl+5NPBcjFrhSr8+VqB1XhMKlXRpWhMets8yaL44rrrq8ssagSo9prJly5G?=
 =?us-ascii?Q?qAulWwlGyzaTVMRUw1ifMhS0HxMItHQXhIEpKrivn6kynL3WrcIucKklvVyr?=
 =?us-ascii?Q?v0e8yhFdv2tC2f4KrYbAfQyVFFyJwGb5OPVjfcOGVUKa8u9LUhkaHuw+a8xx?=
 =?us-ascii?Q?WlLOcSGr98Lw22m5RHGZ7O/BP7ULRmKjFMfiKKLY0FoiJd6CxeLyQQjGocIO?=
 =?us-ascii?Q?Mg/xIePSMMofy1muYNSD2uQ=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9354aa72-77b7-43d5-e8bb-08d9e64ee477
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2022 13:21:16.6724
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8HLBpt5DVKT/DL70OJxmQBQzBb+DkQkWwoIyMqdjCSRkWA50fDfMDBLjG8yiyPPMV6ENeW7ojE94btzqK/ys6w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR0402MB3368

On 02.02.2022 13:13, Roger Pau Monn=C3=A9 wrote:
> On Wed, Feb 02, 2022 at 10:42:22AM +0100, Jan Beulich wrote:
>> On 01.02.2022 13:45, Roger Pau Monne wrote:
>>> --- a/xen/include/xen/mm.h
>>> +++ b/xen/include/xen/mm.h
>>> @@ -554,6 +554,8 @@ int __must_check steal_page(struct domain *d, struc=
t page_info *page,
>>>  int page_is_ram_type(unsigned long mfn, unsigned long mem_type);
>>>  /* Returns the page type(s). */
>>>  unsigned int page_get_ram_type(mfn_t mfn);
>>> +/* Check if a range falls into a hole in the memory map. */
>>> +bool is_memory_hole(paddr_t start, uint64_t size);
>>
>> While resolving to the same type, these now also want to be
>> "unsigned long".
>=20
> Doh, yes, sorry. Will convert them to mfn_t if we agree on that.

As said in reply to Julien - I don't mind the change, but in this
particular case I also don't view it as strictly necessary / useful.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Feb 02 13:22:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 13:22:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264173.457174 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFFb3-0001yN-Hv; Wed, 02 Feb 2022 13:22:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264173.457174; Wed, 02 Feb 2022 13:22:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFFb3-0001yG-Ez; Wed, 02 Feb 2022 13:22:53 +0000
Received: by outflank-mailman (input) for mailman id 264173;
 Wed, 02 Feb 2022 13:22:51 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=CazJ=SR=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nFFb1-0001y5-LY
 for xen-devel@lists.xenproject.org; Wed, 02 Feb 2022 13:22:51 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 369ca52b-842b-11ec-8f75-fffcc8bd4f1a;
 Wed, 02 Feb 2022 14:22:48 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id D1633212B9;
 Wed,  2 Feb 2022 13:22:49 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id AD6AD13E48;
 Wed,  2 Feb 2022 13:22:49 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id PlVeKKmF+mFCRQAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 02 Feb 2022 13:22:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 369ca52b-842b-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1643808169; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=gi5sr4L3f+kSSumZliFKKqERlJ5d9Kjr87jme9eoCio=;
	b=YPmJUdA6WSWwlwV5aHNix+gPwGGfbKQhymsBwzmGHlkqKaAki9kiL9hzlaC+LxpBrDudJh
	R06+z2vOPF9kt1CBU7t96H7z2NGXx1ZDjv9GVOURL/PGB8oKeTbU+DafRUmYLzBgLQJvLM
	3JgbI54R4Zfo+uGksk3gxsyq/4yqVxM=
Message-ID: <a47d10ac-15f4-65a1-afef-813c15d88a78@suse.com>
Date: Wed, 2 Feb 2022 14:22:49 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Subject: Re: [PATCH 1/5] tools/include: generate a _xen_list.h file
Content-Language: en-US
To: xen-devel@lists.xenproject.org
Cc: Wei Liu <wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>
References: <20220130084343.19070-1-jgross@suse.com>
 <20220130084343.19070-2-jgross@suse.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <20220130084343.19070-2-jgross@suse.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------EVFoQKlMPjDOK32MqIi0l3xJ"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------EVFoQKlMPjDOK32MqIi0l3xJ
Content-Type: multipart/mixed; boundary="------------yv055hrw4vZbU5014i25qK51";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Wei Liu <wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>
Message-ID: <a47d10ac-15f4-65a1-afef-813c15d88a78@suse.com>
Subject: Re: [PATCH 1/5] tools/include: generate a _xen_list.h file
References: <20220130084343.19070-1-jgross@suse.com>
 <20220130084343.19070-2-jgross@suse.com>
In-Reply-To: <20220130084343.19070-2-jgross@suse.com>

--------------yv055hrw4vZbU5014i25qK51
Content-Type: multipart/mixed; boundary="------------xBCMaiDQTgYCBQx2YjgGioke"

--------------xBCMaiDQTgYCBQx2YjgGioke
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMzAuMDEuMjIgMDk6NDMsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+IFRvZGF5IHRvb2xz
L2luY2x1ZGUgY29udGFpbnMgdHdvIGJhc2ljYWxseSBpZGVudGljYWwgaGVhZGVyIGZpbGVz
DQo+IGdlbmVyYXRlZCBmcm9tIHRoZSBzYW1lIHNvdXJjZS4gVGhleSBqdXN0IGRpZmZlciBi
eSB0aGUgdXNlZCBuYW1lIHNwYWNlDQo+IGFuZCB0aGV5IGFyZSBiZWluZyBnZW5lcmF0ZWQg
ZnJvbSBkaWZmZXJlbnQgTWFrZWZpbGVzIHZpYSBhIHBlcmwNCj4gc2NyaXB0Lg0KPiANCj4g
UHJlcGFyZSB0byBoYXZlIG9ubHkgb25lIHN1Y2ggaGVhZGVyIGJ5IHVzaW5nIGEgbW9yZSBn
ZW5lcmljIG5hbWVzcGFjZQ0KPiAiWEVOIiBmb3IgX3hlbl9saXN0LmguDQo+IA0KPiBBcyB0
aGUgb3JpZ2luYWwgaGVhZGVyIGhhc24ndCBiZWVuIHVwZGF0ZWQgaW4gdGhlIFhlbiB0cmVl
IHNpbmNlIGl0cw0KPiBpbnRyb2R1Y3Rpb24gYWJvdXQgMTAgeWVhcnMgYWdvLCBhbmQgdGhl
IHVwZGF0ZXMgb2YgRnJlZUJTRCBzaWRlIGhhdmUNCj4gbW9zdGx5IGNvdmVyZWQgQlNEIGlu
dGVybmFsIGRlYnVnZ2luZyBhaWRzLCBqdXN0IGRvbid0IGdlbmVyYXRlIHRoZQ0KPiBuZXcg
aGVhZGVyIGR1cmluZyBidWlsZCwgZXNwZWNpYWxseSBhcyB1c2luZyB0aGUgY3VycmVudCBG
cmVlQlNEDQo+IHZlcnNpb24gb2YgdGhlIGZpbGUgd291bGQgcmVxdWlyZSBzb21lIHVwZGF0
ZXMgb2YgdGhlIHBlcmwgc2NyaXB0LA0KPiB3aGljaCBhcmUgcG90ZW50aWFsbHkgbW9yZSB3
b3JrIHRoYW4ganVzdCBkb2luZyB0aGUgbmVlZGVkIGVkaXRpbmcgYnkNCj4gaGFuZC4gQWRk
aXRpb25hbGx5IHRoaXMgZW5hYmxlcyB0byByZW1vdmUgdGhlIG5vdCBuZWVkZWQgZGVidWdn
aW5nDQo+IGV4dGVuc2lvbnMgb2YgRnJlZUJTRC4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IEp1
ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4NCj4gLS0tDQo+ICAgdG9vbHMvaW5jbHVk
ZS9NYWtlZmlsZSAgICB8ICAgMiArDQo+ICAgdG9vbHMvaW5jbHVkZS9feGVuX2xpc3QuaCB8
IDUyMyArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKw0KPiAgIDIgZmls
ZXMgY2hhbmdlZCwgNTI1IGluc2VydGlvbnMoKykNCj4gICBjcmVhdGUgbW9kZSAxMDA2NDQg
dG9vbHMvaW5jbHVkZS9feGVuX2xpc3QuaA0KPiANCj4gZGlmZiAtLWdpdCBhL3Rvb2xzL2lu
Y2x1ZGUvTWFrZWZpbGUgYi90b29scy9pbmNsdWRlL01ha2VmaWxlDQo+IGluZGV4IGQ3YjUx
MDA2ZTAuLmQ5NjU5ODdmNTUgMTAwNjQ0DQo+IC0tLSBhL3Rvb2xzL2luY2x1ZGUvTWFrZWZp
bGUNCj4gKysrIGIvdG9vbHMvaW5jbHVkZS9NYWtlZmlsZQ0KPiBAQCAtNzAsMTEgKzcwLDEz
IEBAIGluc3RhbGw6IGFsbA0KPiAgIAkkKElOU1RBTExfREFUQSkgeGVuL2lvLyouaCAkKERF
U1RESVIpJChpbmNsdWRlZGlyKS94ZW4vaW8NCj4gICAJJChJTlNUQUxMX0RBVEEpIHhlbi9z
eXMvKi5oICQoREVTVERJUikkKGluY2x1ZGVkaXIpL3hlbi9zeXMNCj4gICAJJChJTlNUQUxM
X0RBVEEpIHhlbi94c20vKi5oICQoREVTVERJUikkKGluY2x1ZGVkaXIpL3hlbi94c20NCj4g
KwkkKElOU1RBTExfREFUQSkgX3hlbl9saXN0LmggJChERVNURElSKSQoaW5jbHVkZWRpcikN
Cj4gICANCj4gICAuUEhPTlk6IHVuaW5zdGFsbA0KPiAgIHVuaW5zdGFsbDoNCj4gICAJZWNo
byAiW0ZJWE1FXSB1bmluc3RhbGwgaGVhZGVycyINCj4gICAJcm0gLXJmICQoREVTVERJUikk
KGluY2x1ZGVkaXIpL3hlbg0KPiArCXJtIC1mICQoREVTVERJUikkKGluY2x1ZGVkaXIpL194
ZW5fbGlzdC5oDQo+ICAgDQo+ICAgLlBIT05ZOiBjbGVhbg0KPiAgIGNsZWFuOg0KPiBkaWZm
IC0tZ2l0IGEvdG9vbHMvaW5jbHVkZS9feGVuX2xpc3QuaCBiL3Rvb2xzL2luY2x1ZGUvX3hl
bl9saXN0LmgNCj4gbmV3IGZpbGUgbW9kZSAxMDA2NDQNCj4gaW5kZXggMDAwMDAwMDAwMC4u
NzlhY2FmNGNmMw0KPiAtLS0gL2Rldi9udWxsDQo+ICsrKyBiL3Rvb2xzL2luY2x1ZGUvX3hl
bl9saXN0LmgNCj4gQEAgLTAsMCArMSw1MjMgQEANCj4gKy8qDQo+ICsgKiBETyBOT1QgRURJ
VCBUSElTIEZJTEUNCj4gKyAqDQo+ICsgKiBHZW5lcmF0ZWQgYXV0b21hdGljYWxseSBieSBi
c2Qtc3lzLXF1ZXVlLWgtc2VkZGVyeSB0bw0KPiArICogIC0gaW50cm9kdWNlIFhFTl8gYW5k
IFhFTl8gbmFtZXNwYWNlIHByZWZpeGVzDQo+ICsgKiAgLSB0dXJuICJzdHJ1Y3QgdHlwZSIg
aW50byAidHlwZSIgc28gdGhhdCB0eXBlIGFyZ3VtZW50cw0KPiArICogICAgIHRvIHRoZSBt
YWNyb3MgYXJlIHR5cGUgbmFtZXMgbm90IHN0cnVjdCB0YWdzDQo+ICsgKiAgLSByZW1vdmUg
dGhlIHJlZmVyZW5jZSB0byBzeXMvY2RlZnMuaCwgd2hpY2ggaXMgbm90IG5lZWRlZA0KPiAr
ICoNCj4gKyAqIFRoZSBwdXJwb3NlIG9mIHRoaXMgc2VkZGVyeSBpcyB0byBhbGxvdyB0aGUg
cmVzdWx0aW5nIGZpbGUgdG8gYmUNCj4gKyAqIGZyZWVseSBpbmNsdWRlZCBieSBzb2Z0d2Fy
ZSB3aGljaCBtaWdodCBhbHNvIHdhbnQgdG8gaW5jbHVkZSBvdGhlcg0KPiArICogbGlzdCBt
YWNyb3M7IHRvIG1ha2UgaXQgdXNhYmxlIHdoZW4gc3RydWN0IHRhZ3MgYXJlIG5vdCBiZWlu
ZyB1c2VkDQo+ICsgKiBvciBub3Qga25vd247IHRvIG1ha2UgaXQgbW9yZSBwb3J0YWJsZS4N
Cj4gKyAqLw0KDQpTb3JyeSwgZm9yZ290IHRvIHJlbW92ZSBhYm92ZSBjb21tZW50LiBJJ2xs
IHdhaXQgZm9yIG1vcmUgY29tbWVudHMNCmJlZm9yZSByZXNlbmRpbmcuDQoNCg0KSnVlcmdl
bg0K
--------------xBCMaiDQTgYCBQx2YjgGioke
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------xBCMaiDQTgYCBQx2YjgGioke--

--------------yv055hrw4vZbU5014i25qK51--

--------------EVFoQKlMPjDOK32MqIi0l3xJ
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmH6hakFAwAAAAAACgkQsN6d1ii/Ey91
Bgf/Yo0gId47r6U8zgb4SOfaOq6tuZ+JQst8ZUHdfJxKGbTMbz+f9WJCeEEg8NOuUQVI+UpJCG1p
BWH12TnJfktLG14+8uDxmOeOAM7bcbe/bLCy015Mrm8hXACFdLeSukXT6qnl/+04RwO1w6Ze/Huk
g2QSAlcOSno59PzpvpkjW86CLJB3bEZ8HREEkPOtwIIn+cBut7Md9HLxcoIqwii7egpH+WEKhdtL
CIJafnHUaCmx5+A2h+6xCnHv2lpftv10VUamk2Ck1MMlDm8nQ1CJLQ8S3PUq4Jch9GVAfMWbGIOh
q0oYulMqLOhXRDxEHeTK+kOsEmdk76qNmIziDnCskw==
=yhot
-----END PGP SIGNATURE-----

--------------EVFoQKlMPjDOK32MqIi0l3xJ--


From xen-devel-bounces@lists.xenproject.org Wed Feb 02 13:26:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 13:26:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264183.457186 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFFeK-0002bx-4e; Wed, 02 Feb 2022 13:26:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264183.457186; Wed, 02 Feb 2022 13:26:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFFeJ-0002bq-VN; Wed, 02 Feb 2022 13:26:15 +0000
Received: by outflank-mailman (input) for mailman id 264183;
 Wed, 02 Feb 2022 13:26:14 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=CazJ=SR=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nFFeI-0002bk-U8
 for xen-devel@lists.xenproject.org; Wed, 02 Feb 2022 13:26:14 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b1860abb-842b-11ec-8eb8-a37418f5ba1a;
 Wed, 02 Feb 2022 14:26:14 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id B05E521155;
 Wed,  2 Feb 2022 13:26:13 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 690A213E48;
 Wed,  2 Feb 2022 13:26:13 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id Eo7UF3WG+mE6RwAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 02 Feb 2022 13:26:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b1860abb-842b-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1643808373; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=66/i9/7BChVSjKsIp/tZStWJ4Mb9HCZtM3YchF7iVO8=;
	b=Dr7iZIwZhw6WRGOhU2Y5HIcT8BNL7+Ea4Wb6y7G186V3bR2VfEfOmnI0v/QjBuurNF1hAy
	At13Ch7H6PE1YQkKQCCJnzeGT1IZkBzlnhL9hFVsDCUIdslca/UZdAjk/0qo0vuyAJklsk
	tOocpUjM+qvcOUSfPLabV3NBW7dxQKk=
Message-ID: <ce722a8a-2bc3-9450-0965-1eadb119d42f@suse.com>
Date: Wed, 2 Feb 2022 14:26:12 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Subject: Re: [PATCH 0/5] tools: remove include/xen-external directory
Content-Language: en-US
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: xen-devel@lists.xenproject.org, Wei Liu <wl@xen.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>
References: <20220130084343.19070-1-jgross@suse.com> <YfpwrHRwcHQHFyw0@perard>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <YfpwrHRwcHQHFyw0@perard>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------pFxJ4l6PBEchwaj84yBS4GyZ"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------pFxJ4l6PBEchwaj84yBS4GyZ
Content-Type: multipart/mixed; boundary="------------c0tB3o3EfEWEGShNMvmsBU5G";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: xen-devel@lists.xenproject.org, Wei Liu <wl@xen.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>
Message-ID: <ce722a8a-2bc3-9450-0965-1eadb119d42f@suse.com>
Subject: Re: [PATCH 0/5] tools: remove include/xen-external directory
References: <20220130084343.19070-1-jgross@suse.com> <YfpwrHRwcHQHFyw0@perard>
In-Reply-To: <YfpwrHRwcHQHFyw0@perard>

--------------c0tB3o3EfEWEGShNMvmsBU5G
Content-Type: multipart/mixed; boundary="------------WUWyyx7du2eCgORIu9Q0uXnX"

--------------WUWyyx7du2eCgORIu9Q0uXnX
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMDIuMDIuMjIgMTI6NTMsIEFudGhvbnkgUEVSQVJEIHdyb3RlOg0KPiBPbiBTdW4sIEph
biAzMCwgMjAyMiBhdCAwOTo0MzozOEFNICswMTAwLCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0K
Pj4gVGhlIHRvb2xzL2luY2x1ZGUveGVuLWV4dGVybmFsIGRpcmVjdG9yeSBjb250YWlucyBh
IGhlYWRlciBmaWxlIGZyb20NCj4+IEZyZWVCU0QgdXNlZCB0byBnZW5lcmF0ZSBYZW4gaGVh
ZGVyIGZpbGVzLiBUaGlzIHNlcmllcyBpcyByZXBsYWNpbmcgdGhlDQo+PiBjb21wbGV0ZSBk
aXJlY3RvcnkgYnkgYSBzaW5nbGUgaGVhZGVyIHdpdGggdGhlIHNhbWUgc2VtYW50aWNzLg0K
Pj4NCj4+IEp1ZXJnZW4gR3Jvc3MgKDUpOg0KPj4gICAgdG9vbHMvbGlicy9saWdodDogcmVw
bGFjZSBfbGlieGxfbGlzdC5oIHdpdGggX3hlbl9saXN0LmgNCj4+ICAgIHRvb2xzL2xpYnMv
dG9vbGNvcmU6IHJlcGxhY2UgX3hlbnRvb2xjb3JlX2xpc3QuaCB3aXRoIF94ZW5fbGlzdC5o
DQo+PiAgICB0b29scy9saWJzL2V2dGNobjogdXNlIF94ZW5fbGlzdC5oDQo+PiAgICB0b29s
cy9pbmNsdWRlOiByZW1vdmUgeGVuLWV4dGVybmFsIGRpcmVjdG9yeQ0KPj4NCj4+ICAgdG9v
bHMvaW5jbHVkZS9feGVuX2xpc3QuaCAgICAgICAgICAgICAgICAgICAgIHwgIDUyMyArKysr
KysrKysNCj4+ICAgdG9vbHMvaW5jbHVkZS9saWJ4bC5oICAgICAgICAgICAgICAgICAgICAg
ICAgIHwgICAgNCArLQ0KPiANCj4gSGksDQo+IA0KPiBXaGlsZSB0aGlzIGxvb2tzIGxpa2Ug
YSBnb29kIGNsZWFudXAsIEknbSBub3Qgc3VyZSB3aGV0aGVyIHRoaXMgaXMgYQ0KPiBnb29k
IGlkZWEgd2l0aCByZWdhcmRzIHRvIHRoZSBjaGFuZ2UgaW4gbGlieGwncyBwdWJsaWMgaGVh
ZGVycy4NCj4gDQo+IFRoZSBMSUJYTF9UQUlMUV8qIG1hY3JvIGFyZSBleHBvc2VkIHZpYSBs
aWJ4bC5oLCBhbmQgaXQgc2VlbXMgdGhhdCB1c2luZw0KPiBgbGlieGxfZXZlbnQubGlua2Ag
aXMgZXhwbGljaXRseSBhbGxvd2VkICh2aWEgImxpYnhsX3R5cGVzLmlkbCIpIHRvIG1ha2UN
Cj4gYSBsaXN0IG9mIGV2ZW50IGluIGEgYXBwbGljYXRpb24uIEJ1dCB0aGVyZSBpc24ndCBy
ZWFsbHkgYSByZWFzb24gdG8gdXNlDQo+IHRoZSBtYWNyby4NCj4gDQo+IEkgZGlkbid0IGZp
bmQgYW55IHVzZSBvZiB0aGUgbWFjcm9zIGluIGxpYnZpcnQsIHNvIG1heWJlIGl0J3MgZmlu
ZSB0bw0KPiBjaGFuZ2UgaXQ/DQo+IA0KPiBXaGF0IGRvIHBlb3BsZSB0aGluaz8NCg0KSWYg
dGhvdWdodCB0byBiZSBuZWVkZWQgSSBjb3VsZCBzdGlsbCBhZGQgdGhlIExJQlhMX1RBSUxR
XyogbWFjcm9zDQp0byBsaWJ4bC5oIGJ5IGRlZmluaW5nIHRoZW0gYXMgYWxpYXNlcyBvZiB0
aGUgWEVOX1RBSUxRXyogbWFjcm9zLg0KDQoNCkp1ZXJnZW4NCg==
--------------WUWyyx7du2eCgORIu9Q0uXnX
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------WUWyyx7du2eCgORIu9Q0uXnX--

--------------c0tB3o3EfEWEGShNMvmsBU5G--

--------------pFxJ4l6PBEchwaj84yBS4GyZ
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmH6hnQFAwAAAAAACgkQsN6d1ii/Ey+Z
yQf/R4PN7lOd/F7yD/ln3aT4fKH+DcM6lpN6orx/frWTCdjLm0LBEFGAN+8ceaTmQics+BQ8a/hI
4lyUcwfjii96plSpCsQ5kZk/mAf035rRvhxM9lsMewhxP0TuBBQ7vqUHkgo2VzAAVb3uhzXfNaFF
xkkVa0FZjCBIL5w6adHU5/j5MBSK+SvyNXvxDVn7JjUoxDBcxp3+XPcKO5MYo0f0E0sizXVOZlCq
+Lc1sPwYSJJpGg+Sg+pulsSHyptQq/rbQYHyb/N6VHqebcAK3VrQbJdnrb3GegXv4UwfJZqhsf7E
fyup1YZnZ5tgt2hZV8RITajdAAI/WEQ90cWO1vGjYw==
=xUjy
-----END PGP SIGNATURE-----

--------------pFxJ4l6PBEchwaj84yBS4GyZ--


From xen-devel-bounces@lists.xenproject.org Wed Feb 02 13:32:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 13:32:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264192.457196 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFFkJ-00045u-Te; Wed, 02 Feb 2022 13:32:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264192.457196; Wed, 02 Feb 2022 13:32:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFFkJ-00045n-Qd; Wed, 02 Feb 2022 13:32:27 +0000
Received: by outflank-mailman (input) for mailman id 264192;
 Wed, 02 Feb 2022 13:32:27 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=6WyI=SR=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nFFkI-00045h-Ut
 for xen-devel@lists.xenproject.org; Wed, 02 Feb 2022 13:32:26 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8d9c193b-842c-11ec-8f75-fffcc8bd4f1a;
 Wed, 02 Feb 2022 14:32:23 +0100 (CET)
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur02lp2058.outbound.protection.outlook.com [104.47.4.58]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-9-CBMyLV-vMNaNiXAOwk0sjg-1; Wed, 02 Feb 2022 14:32:24 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5648.eurprd04.prod.outlook.com (2603:10a6:803:e5::30)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Wed, 2 Feb
 2022 13:32:21 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.012; Wed, 2 Feb 2022
 13:32:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8d9c193b-842c-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1643808745;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=6dZFPXHzyV1w5nw7aX4Rx3VsQwiM3dzoSMzPJww+Z3U=;
	b=nFALlBoD7cUWJ45CFpCl/GZhS8uzu+vxWtgbL2h9H5nkmIFxIHIR75bLP5ON9y720vdOB0
	nwHzQBu5VyQFTLzDSlZPnru3TkQojkqjZsRFIggyLJp+pKvemzveAdH4gLLQaAUf8pYPD9
	fxB5iFS1JJaSHSprjgi1RP+zPf2M8xk=
X-MC-Unique: CBMyLV-vMNaNiXAOwk0sjg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=CYpXwL4i077OTTN48dOEvD65TjE3mmgJQXdC+ioniYAAJJTJ72zi8M92qhp/YPawFTgUJCCMP9vfNN4N3rZQrvzUHRAcokdhdwsR+BFjhSwM+N2ndnj/YbQklpLF/65vRSXi+HK2eSWRe2ExIkbPL87wMKvYbsVl14SF81xhqCL/SnvQCIL/jBnwirnMPgw2IuVKdW1l8mFLLhNr7+2qgATaU72b99DHrIfgvGoUeFCfmkF9lS/nBE5h1QTSJWBWjpCaXSpQ+w8+pOPP7Qm49v60KrU/IRsZKTucxV12IU4N8i+d6/VqZd+AiPuJyCtTCo2u4JBZnTwg1AHS0/Rgug==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=TZVvidwyhH4G2wqsKLBS1yy9f/2iV7LGiUjXMLEWH/4=;
 b=Klg8xVpJSEAZsN85JEK+oIkEqmpKgbnqiw6c5obiVakOnuLNEmm/q6XMLiuXpBxOcEe5vdTSQ/uQ/S6udCtiQf1tu0c9KwS3j6I3IGPXodM79Is33KWkm8Q7eDJ5H+fELkbtewsC6OZaJ7dP8hjxHtjaVUZ6aMxTDJswtTnFsML7cg+5CBh2j6rjRGp+neTi9f52nG29utJ01qk9+hOLom+MqivGsyy+nz/rJQQsLRzGG708aEufWAjrj7c5AY2iBf0IH4ZeEAKjV53lxw3XsSxOy5ripKoMBnyL1CSMNWuS/wb7X2kJ5NHYh4CAKVBYlw4Oz4efJT3saAz3rV4yqg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <d527740a-4d90-4155-13dc-5888e8acfa72@suse.com>
Date: Wed, 2 Feb 2022 14:32:18 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v5 09/14] vpci/header: emulate PCI_COMMAND register for
 guests
Content-Language: en-US
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "julien@xen.org" <julien@xen.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Artem Mygaiev <Artem_Mygaiev@epam.com>,
 "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
 "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
 "paul@xen.org" <paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>
References: <20211125110251.2877218-1-andr2000@gmail.com>
 <20211125110251.2877218-10-andr2000@gmail.com>
 <YeAD9PH9o65o+M+w@Air-de-Roger>
 <6a31eb29-81b6-7553-897f-2e5e54bab9b8@epam.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <6a31eb29-81b6-7553-897f-2e5e54bab9b8@epam.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR05CA0011.eurprd05.prod.outlook.com
 (2603:10a6:20b:488::19) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 1140030d-51ce-4a1e-3090-08d9e650709c
X-MS-TrafficTypeDiagnostic: VI1PR04MB5648:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB56489A7D05A80A0D189F7992B3279@VI1PR04MB5648.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Pd4jn5qAnc74KMbTstGDlblJ8+fD32QwO8mwXHLUrqxyhiQbHBYBHkhFHOhpzYmOcMvbvOrrIxGw5J5PhNtk0x/T+33o2rAQcMKN54P19tjGg/KXksBOaBCf1lbZnceIU9W9Nou4f641NE/fqqRZd0ogxDIA+UaeibfwCcbd1steqywKq+icy/vMJ27nHAOU5lLJRBgFc+YqXfASv8VE76Vei4J0oLJVQ8GLnyLL5faLCPexokFFt/FSLJ2UI3NzayCKD9GVrrehx5cQ7wgtcQ/oWTHk6u5xUcLXbVQ9DwLqdrSOFoROSyech7CUD31YiwkAaG+Qm/4//YUx918/ozODkg0eu4F3bnKwIECMHg15OqOBVp1M0NnRXGJxINf4EoWfSo/jUSWlWcDU2VojokHWDGr9SjsbPHfgRHtvR8UpNEgCCRhwlUfQRZKRI1GgK+7fn8Tp42hRD/NhbTVbTpjqrIxsNBWNb+7nhU17hxI4RJGzFzcgAs0+GoDQqPtuaD/vXqglW0O4a8l/Yae5nbvlJHEMNDvNHMNwiNSsGIJrkilZiouIxKg/uS0hP63a5D5fYNZY7z3QlgwJ7pQ9l1PyBjusnEFcDgfsS48KsJusuXGvpGbxc1zmXnUfR0UniSEK70AekdLwjqT+3/U5TwnPNhTJicuNlCSTLV+aeL7Pizc1jI47lPvq7U+XBeNI7Lv6uUDciB5C/jaiVzfkD9oERXOiqLBYi2se9z2E6fkNTbZDYD8ypYqbqmQDNoWi
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2906002)(38100700002)(54906003)(8936002)(8676002)(66946007)(66556008)(7416002)(66476007)(6506007)(53546011)(508600001)(6512007)(6666004)(6486002)(6916009)(316002)(31696002)(86362001)(26005)(186003)(2616005)(4326008)(31686004)(36756003)(5660300002)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?6lRAhK3e64In4RlddyMS8v/A/dA5PeMolBX/Ao+fnC5Snlu34W0RGyuS0OSH?=
 =?us-ascii?Q?uORuTP/b51rY5KBDAC1USIY4PjMa4IEFl464MZ1MN02XmWSiZUxgqaAIWMvT?=
 =?us-ascii?Q?bvBzvHrgCeDKhsQFbs3O6QJnqHWg/BAkoeuhvrRpuqZPA9L9uS0yaLVc3l7t?=
 =?us-ascii?Q?73aOfXtps2y1p6JOR4M3RrqdYqx4lrKFMgDOw4gDtxNe9rOzx3UADREE0ZEk?=
 =?us-ascii?Q?IRvB+xtbisXmqZD4/dyMVsAZESK3jvV3VWwleYA1woruNPtymVxlRPhWpx1S?=
 =?us-ascii?Q?PdITuZXDDmDJPgQeLScS7kGs3m2yRu6ROh8ES7tOWfRObBTS5JXMZsTlUVeq?=
 =?us-ascii?Q?Ois6G7Pn17FGDFnqtOG7sQeSVnEhH8N00XxAqKZy/edaYRuj98UtaZ0qG/nv?=
 =?us-ascii?Q?/0mA4IA68uWS6ToGdeSZcXPVCIH4sn2a3FUs7eNlGbp9hLB4Jz6bkAYUp5ZV?=
 =?us-ascii?Q?yr5ohMCp3Ynw7a5i3Oz8val6rPkK1p/Fuypa/QitTryVZBEDPvrDiMFmMvRY?=
 =?us-ascii?Q?YCkjIC2gpjC4IHnSErXA4Q78qq1z2rUOQ/+SzMvIUKfefvWBvas8O9++8Jit?=
 =?us-ascii?Q?WBu7sexJohi0t6N4yGhYas64XdhHrrhc9R/1AWuuFZ8VJx/EXzgWK+V4IA1j?=
 =?us-ascii?Q?Qfn9SvXi4AyTngdETDPviOG4nfM05/dds+ENJAdhQwBDn6K2wpH4JiPuH8Da?=
 =?us-ascii?Q?ZOJQjKV3EUZEWKJSVrQCMjWOSLhBXVQZA7s1AMT8JKXurw+pESieNeQTyl3q?=
 =?us-ascii?Q?UgmYExVMZ1DT3tPewy0Qultvmtu6LbCyj8XoHlNEeuUYcBLcYa+q7o41E3tw?=
 =?us-ascii?Q?VQm2h15PPunyzblozIICugiaSre+H9DQ47Q1NksYTEj4OPptO6y9Wh1EhivK?=
 =?us-ascii?Q?YkEjGa1x6K4HSEhgYIUzzoLXml3ccsgfnzdeEgt2rrbZ/nim2aZBtAg5+fs7?=
 =?us-ascii?Q?3B69Qryktr4casFN9ErEdVPeVPVy6AEJYPUnd4HxV2RxgdvpEmUnP4Rj+viv?=
 =?us-ascii?Q?rSRTbLKilveJH0qjlXJPT2N9mNk3TyfZfZ8PYxg2mD2J1k4iOwvASaDxPaH4?=
 =?us-ascii?Q?jHagaZ4kDDMQiE6NYNzH8UvdW0Dsyq1kC81aXorUTLJ61z+7kDia+7ZJSHVx?=
 =?us-ascii?Q?2XZCVXlnw8gOwXzJk40OT/wIrGA/PaNg34XU3FHLhi2MOPxFIOiAcNYzbrvk?=
 =?us-ascii?Q?xLOrCZFCDEI8Jdf0gxZbIZwryt9gEr23Fi5HqiJQRNdxjYVISVwBJ+PXvSPA?=
 =?us-ascii?Q?42fry1S32MIBkrVsdAIFpscsNQEU4pPhRqovNj71laIetKRklM/mUqoU3Efb?=
 =?us-ascii?Q?JMABGVpRaGmQOpN9jYKdhbxpG2oiw0qAxcZAjhRwEYfhuV/L4i/W/MyuIJ7+?=
 =?us-ascii?Q?hBU66STtG29ycomWxkTEsJVrZ2TRpzDTTlfYSkibnGN7e1VOjaeGmbVJGND0?=
 =?us-ascii?Q?aI48odRuOofR+Pc/xhrUtPr4apCEGtx9loCNdtUBduNz+ReCoGlO6C/P5TCP?=
 =?us-ascii?Q?A2ahmPv9uG+OZQJDQ+xQ0zT8Cp17E2eaxkr+cT9JL1MnxjHMClK/n2bxavoL?=
 =?us-ascii?Q?zxJric5E2GaY1tdCrxZcqxSTPdvv34F2EquQbcSjMATtGW0PoacjuqWbqE1n?=
 =?us-ascii?Q?zcsXwruacoGqOoQqPHfa8to=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1140030d-51ce-4a1e-3090-08d9e650709c
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2022 13:32:21.2567
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: w8nPJLF8tmGpmc/yX1PVd7VP50ntV9BGFz1loFcBO30M5UfXaAm6b102hx+j8O4F+fU9dysqwuWmc6vgRVvicA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5648

On 02.02.2022 13:49, Oleksandr Andrushchenko wrote:
> On 13.01.22 12:50, Roger Pau Monn=C3=A9 wrote:
>> On Thu, Nov 25, 2021 at 01:02:46PM +0200, Oleksandr Andrushchenko wrote:
>>> --- a/xen/drivers/vpci/header.c
>>> +++ b/xen/drivers/vpci/header.c
>>> @@ -491,6 +491,22 @@ static void cmd_write(const struct pci_dev *pdev, =
unsigned int reg,
>>>           pci_conf_write16(pdev->sbdf, reg, cmd);
>>>   }
>>>  =20
>>> +static void guest_cmd_write(const struct pci_dev *pdev, unsigned int r=
eg,
>>> +                            uint32_t cmd, void *data)
>>> +{
>>> +    /* TODO: Add proper emulation for all bits of the command register=
. */
>>> +
>>> +#ifdef CONFIG_HAS_PCI_MSI
>>> +    if ( pdev->vpci->msi->enabled )
>> You need to check for MSI-X also, pdev->vpci->msix->enabled.
> Indeed, thank you
>>
>>> +    {
>>> +        /* Guest wants to enable INTx. It can't be enabled if MSI/MSI-=
X enabled. */
>>> +        cmd |=3D PCI_COMMAND_INTX_DISABLE;
>> You will also need to make sure PCI_COMMAND_INTX_DISABLE is set in the
>> command register when attempting to enable MSI or MSIX capabilities.
> Isn't it enough that we just check above if MSI/MSI-X enabled then make
> sure INTX disabled? I am not following you here on what else needs to
> be done.

No, you need to deal with the potentially bad combination on both
paths - command register writes (here) and MSI/MSI-X control register
writes (which is what Roger points you at). I would like to suggest
to consider simply forcing INTX_DISABLE on behind the guest's back
for those other two paths.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Feb 02 13:47:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 13:47:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264199.457208 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFFz8-0005cN-AP; Wed, 02 Feb 2022 13:47:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264199.457208; Wed, 02 Feb 2022 13:47:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFFz8-0005cG-76; Wed, 02 Feb 2022 13:47:46 +0000
Received: by outflank-mailman (input) for mailman id 264199;
 Wed, 02 Feb 2022 13:47:45 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1p3Q=SR=epam.com=prvs=40324c57ab=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nFFz7-0005cA-8R
 for xen-devel@lists.xenproject.org; Wed, 02 Feb 2022 13:47:45 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b1b02b40-842e-11ec-8eb8-a37418f5ba1a;
 Wed, 02 Feb 2022 14:47:44 +0100 (CET)
Received: from pps.filterd (m0174683.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 212DNlD9017992;
 Wed, 2 Feb 2022 13:47:39 GMT
Received: from eur04-he1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2051.outbound.protection.outlook.com [104.47.13.51])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3dytsxr3a5-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 02 Feb 2022 13:47:38 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM6PR03MB5361.eurprd03.prod.outlook.com (2603:10a6:20b:d2::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Wed, 2 Feb
 2022 13:47:30 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6%3]) with mapi id 15.20.4951.012; Wed, 2 Feb 2022
 13:47:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b1b02b40-842e-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=OnjhgqQSifvPtAl1+mXtHrrBQwj4YKEvi716pcZNDBxkKDU7gzvMHb+5p5125O14ygJCZsHQkspo7G6w5Jyg43le/WyPH0w0pfSQPGPifT6xAkgnjQLLccAOo7w0pHFzBS9hP6d625PD3ikA+mhfCQJKHa3G23piIIVgkvhRCz0u1ssChR67tymXrtTdCRiVYmvKWp8PheEBHJGz/s97NKSxZ5kRQ9cR/KxhuxI9+hrwfYYIPeUY58n0jzxMxdCReIk8Q4bC1c5iR2i8QBwvZ18QGT42ffGN1DFnJvvnS1vo5dQJwRG8Z46OPG6LH+WKor69vNvow2R1j49W1+4/6A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=s6/lA93fP10M4FAaIluQ/bEW8BXxpm2V0acpTdVAvbw=;
 b=U4xcSTcDLQd6iVgomHKPSTvwaljaoNSrbniZVZKrMF+7cq/AblyNrHCuB+IP3cjD2gyyH08IWleOjkTjSing8um+VWY8M6v/DKAbT0DYcIdMtQma+KkPogY76YXgjadEYlhB/n7WjGsZh/cNIKnFsn1Dhn13EsLsLEJsOMelEcTFXAoPQa7gEywlSpQkVO9oF/FTZLD/SmXWg00xHR5Ngag2PCIdPZqNLGY9IsbkvMGbFO4vJ0odQcYXnV0Dpb2utgGk1mN0l/g9/3nlc2kl5HNPCtwjuQISSJDiSO+SCpkItbkOit+gcIbV9yDM7/dxy38VmKfxZorMVvpQfTh6+w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=s6/lA93fP10M4FAaIluQ/bEW8BXxpm2V0acpTdVAvbw=;
 b=O/OxHTcXsAIIAa+bwKPCF59ZII1NhSmEzzopTJl+c7gFyiCpGIadqCl/FcuISNmFPZ5NY12/HbOsZ5Zb9uvLAchoObhsW0KNCkcq/PwH+TlgNlLdERoH/VvfBkeD3yFwFNbUAvklha/R6lq83zrqeuS3RabzdSgfaNxqgpZkdU2a8QmB7L/2dFNBF2gSD0N7Gd1skY6779vj36hfr462/zLFDcNFodQLExuiW6ck8uEOshggvBbe8eBz+MTakbN6eJdp+OLqks+lxMF0KHVGw0LD1DAA3If3Mne9v8OqIv3B/xqXyFi6JEmGXtScb/fVtRSzg7hZYjFPlyrEJCOICg==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?=
	<roger.pau@citrix.com>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v5 09/14] vpci/header: emulate PCI_COMMAND register for
 guests
Thread-Topic: [PATCH v5 09/14] vpci/header: emulate PCI_COMMAND register for
 guests
Thread-Index: AQHX4ewK3mPSKCsK30iVfRQpWoVIB6xhEugAgB+P6YCAAAvvAIAABD6A
Date: Wed, 2 Feb 2022 13:47:30 +0000
Message-ID: <b9661d86-f084-9ad1-59d5-538113000393@epam.com>
References: <20211125110251.2877218-1-andr2000@gmail.com>
 <20211125110251.2877218-10-andr2000@gmail.com>
 <YeAD9PH9o65o+M+w@Air-de-Roger>
 <6a31eb29-81b6-7553-897f-2e5e54bab9b8@epam.com>
 <d527740a-4d90-4155-13dc-5888e8acfa72@suse.com>
In-Reply-To: <d527740a-4d90-4155-13dc-5888e8acfa72@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: b2a69c6f-eea4-4fa6-3fd8-08d9e6528e81
x-ms-traffictypediagnostic: AM6PR03MB5361:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM6PR03MB53610669E062815C93F4B66AE7279@AM6PR03MB5361.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8882;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 Dj9RQmIC/j8QTupKH9sx2T+DuzqJY4omPSGPJgG9WGbgTp/Rp9u6Pdb7ZFKXljSdebvCCSgSGbVxPNxj9rRIN0DkRYBKCKIuTeUxQCyDKk+KfATQKLrKjAwkGWp3NQY3dXjDALUceqlUicNBEQXG5SgsUx6Nhv1j2TTwU50h6+j1r15fVg6tHeOtGr8nzhncMiiLjBhMzRrIcoJFXRSSUZCFuwGow/NKbdDEHWRwQBXK9CPojSyepD+hrLbQGOC+1ajU2Nbx3zfVdd4X+xcohArfFLYYvoZxXT5A9U3qiIRWV3kTky9UFxiz2W7uXpFXvi7Y03DYNvp3DNWoJTeDuJjIpriVAbi9fLN9r5nDvuYyjc5WFtFTshLm5JTO661St+uuZ+pAQfMbFY+9k4QxKFn8xrZcK4H3+hJAA6QiOuHISX2qnzHPyHlZrZZ4aO6GO/hxe7AFUeYMMBCC7b4S6H48xxNBpuOMsnYOoYKjaj2CVTJBDIS5cbPFIaONPU133pPZUYyletvBgHuAavBwFRSmsl/ehzv/u75zsUoQ9ItFVXtdGdOhNefMXciUI3XAteGmTFHH5Azhdam4zHCwSmMZ0UAXSRM4c0yYNUCGyGq8ZMIn8VejqsT/gpZrfZYB3QFm9m1ulQfWVWdalxCK0WGCLALSdNK9841vaS+HVGhOYliffC3S18j0QnCmu5GjEzOCLtlB2K1O9ely3B8w013YzfD8ttytCt7tLbdwqIr1JO7nJQKFSEW32G/0zMWk
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(2906002)(8676002)(71200400001)(31696002)(38070700005)(8936002)(86362001)(26005)(36756003)(4326008)(186003)(31686004)(83380400001)(2616005)(107886003)(122000001)(7416002)(66556008)(53546011)(5660300002)(66446008)(508600001)(6486002)(38100700002)(54906003)(76116006)(6506007)(64756008)(6512007)(316002)(6916009)(66476007)(66946007)(91956017)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?VWZwd25IbFF1MHdnU1NNY1BZY0RPSmNrR000Zm9qUmN0YU80NmVhSE93S2dm?=
 =?utf-8?B?dWUwSUU5bm15ZkxidUJGQy9ndUU2NWh5d3N5b1VnL2U1TS9UWjY3aFlkcnZO?=
 =?utf-8?B?VDQxSFk3cWU3RHVOSDZjc0cweC82c1lxbkZRcVhBb0VTTGMxRlIxOG5nb1dT?=
 =?utf-8?B?dWhSRjFLVGRtU1l5QnBvbi9jT0FZWVZGSFNQbHdYdENWREZ4SkY0V0dBVjcy?=
 =?utf-8?B?NENybzVWNUJsRGJ1N0t1YmptUUFsWGFFUW9QcjdjVFUxNThHTTNhcm1XWGZC?=
 =?utf-8?B?SnJ3a093VzBKZmJYSWU2amlxT3duNnA1OGE0SVlyUlBXYmlaL3c5K1JYWjE1?=
 =?utf-8?B?ejdaY051UjUvL0RVdDF0eUoreG5yZXlsOTExZ01nQ1RucWVsSFQ3RWJ1blBn?=
 =?utf-8?B?N2ZHcVZ6Z2MwaGZZVXEzU2R1QzE2N09uQUFYbnVMb0pNTERHQUovVXBqdmpz?=
 =?utf-8?B?MmE3ZFdkMzk2L1lxb2NHSVRSenVXZzF6RU1Gc0sxeHRHcVA5VUx0T1ZGUy9Z?=
 =?utf-8?B?YlpoMzZzTm1mdmF4cXVGRVo3VGVmQzI2cEtQK1JtNWE1Y0FJR0wrUTlJMGt5?=
 =?utf-8?B?RE4wclhOaG15VGZkRVlMT05SRWdtdEJieHg5R1pVM2ltSUI3cTY2M1NXbTlv?=
 =?utf-8?B?cEpsZituY2JXeDI0UzI5QzdHTWZOa2ZwMWZFaHFlNE90Uk1ZOXFuRG1pQ2RH?=
 =?utf-8?B?STZhcHV1R3hZVTRiTlN5c1JtSDI5YlhNSytQYk4yL29jakZuajRzclFjVUVI?=
 =?utf-8?B?Z2JmLzdPdWVVaFFxc2pMU0FwUVEyVWliQml4L2JtaHRwaUhYY1FGTGVaR2hE?=
 =?utf-8?B?NHEzUHR5SU1YQXZEYUlQNnFzbys2dVoxaWxPbTlzd2xHREVLbGRSR20zU0ND?=
 =?utf-8?B?Y0tMbG5ZRXRyMGlmWmVsUUZxRUVJdDFmeGNMQXZNcnpLNnVlUlNtY3l4RFNX?=
 =?utf-8?B?M3hoaWFxVFRtRFpBN1dNUEpGem4vK3ZNd05VQUtJZnZFYUFrRWhKTjVKbDdw?=
 =?utf-8?B?UUpxK3FmSXlNTzBXWUZuMFVkeHQ2dVR4K21XUVI3TXorWm5lTXJUQi9LeEhw?=
 =?utf-8?B?b3FBOXo3R05xSjZrNmJ3LzlWaTNEanZBeWJsV0F4SDJ1ZGxiWnpRYi94dDFj?=
 =?utf-8?B?dE9EUVhyc0JyY0VrV1hCUlJYYlQwRkFZQm1jNlB6YzZPb0NUSTVDSHNnOG5n?=
 =?utf-8?B?WFRkV0pVbGUrYXptTmNOMzB6NlVXamJZZ0FJUEpDNXZmRWZtWlJoQ09qRmFw?=
 =?utf-8?B?VFowUEtXaXZJU0k4bEF4cjVac05OL3psSmgxTkt4RjNPOE5EQzVXMkJXalMr?=
 =?utf-8?B?TjVoUjBpVzF1V1BVYjAyc1V5ZVNlZ3IvQVB4UzBTcitHSXB2aGlDUFBnejUz?=
 =?utf-8?B?NUUraFgrcWRtb0pDL0l2MGZSc2NUeGpvd3E5cUR0a3N2T0FvSUtZTkN0TjJr?=
 =?utf-8?B?N2syODhLdzdnMUhRZU5QQmdDbnZ1eEZiQ0I0YThpS2ExcnNub1BGOUtVb3d0?=
 =?utf-8?B?VDk5cUNvZ3REbWYxT0tOQ1MrOW5mR05QL0FabkUwaFdaMXlnZ1JXemZHWjVD?=
 =?utf-8?B?djFlSEcwa1hZVjkvRjhUZU9vOHVwMzdpbVdQekx1UEZKd0J4a2VUZzltdnp2?=
 =?utf-8?B?MmtTejh6aXlERU9adkdMZXByYVN5VzlROGthLzgwNjA4cDVpT3Qyd3N0OTJ4?=
 =?utf-8?B?RERyVHR3STJ1WnI5ZGRTNitub2d2QWs0QUFTakdXRmlWellPNzJTYTI5ektV?=
 =?utf-8?B?ZHVKZHZnUGNxVXl0Y3lxc0hFbUdJTnNOaVlGR3cwaCtqdTRwcXBTY3JhamdV?=
 =?utf-8?B?R2FxMUxmekJzM05UekEvaHZDRWp0U1lQMVNsVjg4bDN5WS84ZzlOSnllVjVY?=
 =?utf-8?B?eVpXNXh5ODQrdC9iZmhSMVF1UFkwb3F0RzhRTENYQkhlRWcwR2lUc3ZrQmhq?=
 =?utf-8?B?Q21uZTFtZThyamF5QzFRcFJnaWdUTDBtYTZKUDk4bkpIQitLbGx1eUFoUm1E?=
 =?utf-8?B?NkhldWh4SW9JVEdGWmlOREt3Zmx2eG1WbnRxVC9OSUJremIxSHlxblY1dzFj?=
 =?utf-8?B?dStYc0ZYSEZoWHZiUGxmQ01PdEg0VTJuSmVOSWc2RVduV09aY1RPcVFwWmhX?=
 =?utf-8?B?d0hXZjFFbXJIVFppR3BiK1N6MENDUGFyZEZDNVlYcVlsK0kyMkJRUEl1ekEz?=
 =?utf-8?B?MnV0aHNWeXlleFVYTXhkeXlCUDZFb0dUZTZYM0x3bDhJaG9MVU83djZmOSts?=
 =?utf-8?B?KzhXMnFncjBJWXBldC81a003ZUNPcHQyaEF5dG1rV0NHcnJVL3NROHJtZ3F2?=
 =?utf-8?B?U2p0cmliaHEyaGs4SFhPSHpOZHhJMVNwU2lxTmRyaVZZbVpBYU9Zdz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <C34B09810ECF9F419AA156A76CC841B1@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b2a69c6f-eea4-4fa6-3fd8-08d9e6528e81
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Feb 2022 13:47:30.1396
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 9KKZZniq6OvW2DvlBog3cxUETlHw/MVTtpfHff+O3gsca+7qW4FFkYjZPzf5p0iEozuA7U7PpeCeDpdlFyWl30y3CWxl9l+0X8rILU/Bmo2qjorAfKbba3apuky/yJoY
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR03MB5361
X-Proofpoint-GUID: JxdFqVAg8D4GozmnnM_OyeQDhM7gFlDN
X-Proofpoint-ORIG-GUID: JxdFqVAg8D4GozmnnM_OyeQDhM7gFlDN
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-02_06,2022-02-01_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 mlxlogscore=835
 adultscore=0 impostorscore=0 mlxscore=0 spamscore=0 malwarescore=0
 priorityscore=1501 clxscore=1015 suspectscore=0 lowpriorityscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202020075

DQoNCk9uIDAyLjAyLjIyIDE1OjMyLCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMDIuMDIuMjAy
MiAxMzo0OSwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+PiBPbiAxMy4wMS4yMiAx
Mjo1MCwgUm9nZXIgUGF1IE1vbm7DqSB3cm90ZToNCj4+PiBPbiBUaHUsIE5vdiAyNSwgMjAyMSBh
dCAwMTowMjo0NlBNICswMjAwLCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyB3cm90ZToNCj4+Pj4g
LS0tIGEveGVuL2RyaXZlcnMvdnBjaS9oZWFkZXIuYw0KPj4+PiArKysgYi94ZW4vZHJpdmVycy92
cGNpL2hlYWRlci5jDQo+Pj4+IEBAIC00OTEsNiArNDkxLDIyIEBAIHN0YXRpYyB2b2lkIGNtZF93
cml0ZShjb25zdCBzdHJ1Y3QgcGNpX2RldiAqcGRldiwgdW5zaWduZWQgaW50IHJlZywNCj4+Pj4g
ICAgICAgICAgICBwY2lfY29uZl93cml0ZTE2KHBkZXYtPnNiZGYsIHJlZywgY21kKTsNCj4+Pj4g
ICAgfQ0KPj4+PiAgICANCj4+Pj4gK3N0YXRpYyB2b2lkIGd1ZXN0X2NtZF93cml0ZShjb25zdCBz
dHJ1Y3QgcGNpX2RldiAqcGRldiwgdW5zaWduZWQgaW50IHJlZywNCj4+Pj4gKyAgICAgICAgICAg
ICAgICAgICAgICAgICAgICB1aW50MzJfdCBjbWQsIHZvaWQgKmRhdGEpDQo+Pj4+ICt7DQo+Pj4+
ICsgICAgLyogVE9ETzogQWRkIHByb3BlciBlbXVsYXRpb24gZm9yIGFsbCBiaXRzIG9mIHRoZSBj
b21tYW5kIHJlZ2lzdGVyLiAqLw0KPj4+PiArDQo+Pj4+ICsjaWZkZWYgQ09ORklHX0hBU19QQ0lf
TVNJDQo+Pj4+ICsgICAgaWYgKCBwZGV2LT52cGNpLT5tc2ktPmVuYWJsZWQgKQ0KPj4+IFlvdSBu
ZWVkIHRvIGNoZWNrIGZvciBNU0ktWCBhbHNvLCBwZGV2LT52cGNpLT5tc2l4LT5lbmFibGVkLg0K
Pj4gSW5kZWVkLCB0aGFuayB5b3UNCj4+Pj4gKyAgICB7DQo+Pj4+ICsgICAgICAgIC8qIEd1ZXN0
IHdhbnRzIHRvIGVuYWJsZSBJTlR4LiBJdCBjYW4ndCBiZSBlbmFibGVkIGlmIE1TSS9NU0ktWCBl
bmFibGVkLiAqLw0KPj4+PiArICAgICAgICBjbWQgfD0gUENJX0NPTU1BTkRfSU5UWF9ESVNBQkxF
Ow0KPj4+IFlvdSB3aWxsIGFsc28gbmVlZCB0byBtYWtlIHN1cmUgUENJX0NPTU1BTkRfSU5UWF9E
SVNBQkxFIGlzIHNldCBpbiB0aGUNCj4+PiBjb21tYW5kIHJlZ2lzdGVyIHdoZW4gYXR0ZW1wdGlu
ZyB0byBlbmFibGUgTVNJIG9yIE1TSVggY2FwYWJpbGl0aWVzLg0KPj4gSXNuJ3QgaXQgZW5vdWdo
IHRoYXQgd2UganVzdCBjaGVjayBhYm92ZSBpZiBNU0kvTVNJLVggZW5hYmxlZCB0aGVuIG1ha2UN
Cj4+IHN1cmUgSU5UWCBkaXNhYmxlZD8gSSBhbSBub3QgZm9sbG93aW5nIHlvdSBoZXJlIG9uIHdo
YXQgZWxzZSBuZWVkcyB0bw0KPj4gYmUgZG9uZS4NCj4gTm8sIHlvdSBuZWVkIHRvIGRlYWwgd2l0
aCB0aGUgcG90ZW50aWFsbHkgYmFkIGNvbWJpbmF0aW9uIG9uIGJvdGgNCj4gcGF0aHMgLSBjb21t
YW5kIHJlZ2lzdGVyIHdyaXRlcyAoaGVyZSkgYW5kIE1TSS9NU0ktWCBjb250cm9sIHJlZ2lzdGVy
DQo+IHdyaXRlcyAod2hpY2ggaXMgd2hhdCBSb2dlciBwb2ludHMgeW91IGF0KS4gSSB3b3VsZCBs
aWtlIHRvIHN1Z2dlc3QNCj4gdG8gY29uc2lkZXIgc2ltcGx5IGZvcmNpbmcgSU5UWF9ESVNBQkxF
IG9uIGJlaGluZCB0aGUgZ3Vlc3QncyBiYWNrDQo+IGZvciB0aG9zZSBvdGhlciB0d28gcGF0aHMu
DQpEbyB5b3Ugc3VnZ2VzdCB0aGF0IHdlIG5lZWQgdG8gaGF2ZSBzb21lIGNvZGUgd2hpY2ggd2ls
bA0Kd3JpdGUgUENJX0NPTU1BTkQgd2hpbGUgd2Ugd3JpdGUgTVNJL01TSS1YIGNvbnRyb2wgcmVn
aXN0ZXINCmZvciB0aGF0IGtpbmQgb2YgY29uc2lzdGVuY3k/IEUuZy4gY29udHJvbCByZWdpc3Rl
ciBoYW5kbGVyIHdpbGwNCm5lZWQgdG8gd3JpdGUgdG8gUENJX0NPTU1BTkQgYW5kIGdvIHRocm91
Z2ggZW11bGF0aW9uIGZvcg0KZ3Vlc3RzPw0KDQpJZiBzbywgd2h5IGRpZG4ndCB3ZSBoYXZlIHRo
YXQgYmVmb3JlPw0KSWYgaXQgd2FzIG9rIGJlZm9yZSwgdGhlbiBJIGd1ZXNzIHRoZSBjb2RlIEkg
YWRkIGRvZXMgZW5zdXJlIElOVFgNCmlzIHNldCBpZiBwZGV2LT52cGNpLT5tc2ktPmVuYWJsZWQg
fHwgcGRldi0+dnBjaS0+bXNpeC0+ZW5hYmxlZA0Kd2hpY2ggaXMgZW5vdWdoIGF0IGxlYXN0IGZv
ciBQQ0lfQ09NTUFORCB3cml0ZXMuDQoNClNvcnJ5IGlmIEkgc3RpbGwgZGlkbid0IGdldCB0byB0
aGUgcG9pbnQgaG93IHRvIGRvIHRoYXQNCj4NCj4gSmFuDQo+DQpUaGFuayB5b3UsDQpPbGVrc2Fu
ZHI=


From xen-devel-bounces@lists.xenproject.org Wed Feb 02 13:59:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 13:59:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264206.457219 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFGAC-00074x-Cz; Wed, 02 Feb 2022 13:59:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264206.457219; Wed, 02 Feb 2022 13:59:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFGAC-00074q-9n; Wed, 02 Feb 2022 13:59:12 +0000
Received: by outflank-mailman (input) for mailman id 264206;
 Wed, 02 Feb 2022 13:59:11 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1p3Q=SR=epam.com=prvs=40324c57ab=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nFGAA-00074k-Qa
 for xen-devel@lists.xenproject.org; Wed, 02 Feb 2022 13:59:11 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 49758a89-8430-11ec-8eb8-a37418f5ba1a;
 Wed, 02 Feb 2022 14:59:09 +0100 (CET)
Received: from pps.filterd (m0174678.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 212DsA9g019609;
 Wed, 2 Feb 2022 13:59:04 GMT
Received: from eur05-db8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2107.outbound.protection.outlook.com [104.47.17.107])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3dyu8br0ku-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 02 Feb 2022 13:59:04 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by VE1PR03MB5869.eurprd03.prod.outlook.com (2603:10a6:803:10e::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Wed, 2 Feb
 2022 13:58:57 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6%3]) with mapi id 15.20.4951.012; Wed, 2 Feb 2022
 13:58:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 49758a89-8430-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=dchvt6cL95V1nsYX64sDT93HuCrsxPUX/Ub/+8seBPJG0VlaCTCn8SHn5oR25fquy78FGBBt/5sdqPPeTre/dPyWjJQSW0KHKXFOWz+2pRAtsGbEc4YFFORoAZ1Zvl9nGP555OFUIHk2df7GI0JBGhRsJOUnO/OCFPPXRtuZbgFvDMHKo9TnDZ5+SIwM4mx2pFFstG9GppwnpJTEzh+5f/Q1PGuCL6sQQvcZxrnGjEPhpSYFfVhGZ/1nVwKsKVb8q04j2Yg+pKHUKAityI8yZjYwNJqa0+sG+zCqlssyv3m6t+vjprDM8CIys7qLnpgbrTDPTJD+0Zc0tPPw8o+n0A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=tEX7bMHqxQ/o97vtOjdKYBDo51tHiWvSXrPEGS91wVM=;
 b=IfRV8PJzBw0W0ZsAu1HYIK0AVe3YtxyomRMyZh3mpvlWpN0fkmaXZPKHnqIt/qyoWIM9KGcUJ6C03HTX68O8AW/DXMiLYM5PL7T6fTMgJqx/y5LHonUH+Apq+ln1Mw6Doq7vi1jvEJCXVg+dP95oj+2IRsmk9gTXdqFAhORgJY8c4Ry+kEAtcbnPq+KM2HRLlIp/EnAJFNaJ5L7OSdO73RDMxo8DipP2G0qu0ArDT7WEf1/9Sz4iO8X9fYMFpgmumZI3kq3KOaNFhsNFK9+Z4RPJSrYt/FwSbZiIQkxtT4uhv2OV0G430AHz2gJqmW0pHs1ZyRvBNl7dXiHxR7FcTA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=tEX7bMHqxQ/o97vtOjdKYBDo51tHiWvSXrPEGS91wVM=;
 b=LIbH3RFFV5I0a8YYrj5A9TeCeQZRbpHoDMuWVmNDRyOlrFrhUZ4Q3k85r4B543EvmeWo14QQLlcbqDrmQn2mkclNnFCd4y8Ye1IANoJe13XSLBXP+A6edREIUG3lKetiPu8K4uqKCW+7qnlTYibggQ0pXqcB24UIHylJ313GJbAoICDcia2dGSpaKU7sYiQDhfYBQQuhRw2aj7JMeWOT/9s5zk+w95lum+qvwjKKTskKfxxFjnqF92DoHSTdXWDfuwPI6aL+0MeEH0IjlRz56J+bhtsRCUn9oKJoEdj9u0PbrtW1nUxtfsx2vTA8IzYxJn1jPbrdqB+eHu9P8Mx1Zg==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "jbeulich@suse.com" <jbeulich@suse.com>,
        "andrew.cooper3@citrix.com"
	<andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com"
	<george.dunlap@citrix.com>,
        "paul@xen.org" <paul@xen.org>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>,
        Rahul Singh <rahul.singh@arm.com>,
        Oleksandr
 Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v5 12/14] xen/arm: translate virtual PCI bus topology for
 guests
Thread-Topic: [PATCH v5 12/14] xen/arm: translate virtual PCI bus topology for
 guests
Thread-Index: AQHX4ewLsn+7Z5q1aEWJccddnxyCV6xhK2cAgB+KygA=
Date: Wed, 2 Feb 2022 13:58:56 +0000
Message-ID: <41e2189e-b421-e6cb-42d7-6e3ec08e980e@epam.com>
References: <20211125110251.2877218-1-andr2000@gmail.com>
 <20211125110251.2877218-13-andr2000@gmail.com>
 <YeAYgOIcBMjMeWU9@Air-de-Roger>
In-Reply-To: <YeAYgOIcBMjMeWU9@Air-de-Roger>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: f93ea099-3caa-4298-5180-08d9e6542828
x-ms-traffictypediagnostic: VE1PR03MB5869:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <VE1PR03MB58693A1383670DDC18933444E7279@VE1PR03MB5869.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 DTd7CmcjuGhfwuoBcpaU5/KMKSC83uTQ91+ZJejT+6RoEBNeQYAuWRgVgmSIqLsZst0y84rSDg+OVOf6oUSFzr+FtWf4MV7f/ofPQzELdl4Fq2ft5aoCmoXx1mm5bDdfrE5W59euaeVjLVLbtlgB8b2OTdS2gZGiNZXNSKKVlsHHM4RB/qczJgb2fXcY7+O0UVkTKHkDjmrMKKtY3XV0JS7S81XurPOxkiZl1Wm/n2oPoruuUBd8SB/Qh6LExJXthIchx5MtDsnzjUwLwIgVfie7n3cjz3m/NlD0AvYD2UTpOK8BvonhTHo9oE9sUdROcIh3ya/5Y2HV5/G81LoKa/OTjfNmzYG9itHP9sWdfnRKURw3w13s9G4gJ8FlbNNNAVYKSECRqSNYYjdP6z5VVpcgWwIc/DclkkmBl2W8U0W+TH5bW/edWAdxfgp2rtlZllRbeuSqc6KHN6SvL5pNZmW/m4HfubDkXPmFcIUGf/WiusD0EnPDTD2hnEv0eILrXo2VoBa8ZxeMCB/JQC+gquPCDGcRhhX1+5LviIvSW7/GHp/xonZL0YkVTRJVh8t4TDsdLa1XpWKJEqiZ9v1VNCrZUNKmmNPnMJFManr2WjpkAT/5DvLdq0mk6PEJJ9BtcPqYwbeYnw6hVdZytEfcFIBjpnotOZQhcxY7pT5meuhYGPc70pkO3ZWuuEEbACFehdvVBU8izdtj+jB/m0BpyjAj/SoDNA51UW7kaXVYZEwClfb9CAjTGtDDciCA5V2fnksnxw07vESlo4I86rvCVg==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(7416002)(71200400001)(26005)(186003)(122000001)(38100700002)(83380400001)(5660300002)(6506007)(31686004)(36756003)(2906002)(53546011)(86362001)(8676002)(4326008)(8936002)(2616005)(54906003)(66446008)(6916009)(66476007)(31696002)(66556008)(76116006)(64756008)(66946007)(6512007)(91956017)(316002)(508600001)(107886003)(38070700005)(6486002)(45980500001)(309714004);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?ci9OazgyYmR6Y3psYTkwSGhObFkrSUtyc0NWKzZ1bnhUcSt5OStTMlExZEEy?=
 =?utf-8?B?bTZLdTQyWVJQMXFKSHgwVnhQVnY2dGJkaDQwTzFXdVJhUVc4a2k0bnpaaUlN?=
 =?utf-8?B?VjZ3MVBCaVJiUk9OWVZNdUhFS08yY3FJL0ZQMXlHM2hVSHhmZ1ZqekN2M1Nx?=
 =?utf-8?B?Q3FqdHdudkNsQmFiYXFGdkVBMmxzZ2NTWWtwZ2hTOHVuejRJa0ZxTDM1RkYx?=
 =?utf-8?B?OTNQSkM1ZENqYzg4ZVRrU0RIVHFreVlpRGprcWIrZjBvTHBVbXRoL1VzUXVj?=
 =?utf-8?B?TmJCYml2WjRDNm5qd0luYVhOVm8rRjc2Yk9wZkxQQU9BcWMwRkJDREFkaXBM?=
 =?utf-8?B?Y1RCUWNnZEc1MkJoZFNhU1QwYlBwNHpZMnVDR21JblB6a0VabXg2L1pMa2tY?=
 =?utf-8?B?YWRHV3Era1kyaEtDMm1DQjJCc2todURvT2MreUs2ZXhYZFZjSTJmcU92ekdo?=
 =?utf-8?B?azIxSWF2alB3Y0FlQTR6a0hiTVc1WCt4ZkJvSm5CMmthclRQSXYvNmF1US9N?=
 =?utf-8?B?S3o1U1dRQ3Z0UkJNZDVwOE92dEtxaTlWVlpyMkorMGw4aDE1VTVuSzlQenJW?=
 =?utf-8?B?emNrNm40L25JZVE5YTdyODJRWGJuVHhRMXJNakF4Um8vckdhbFA0RVNVQ0pa?=
 =?utf-8?B?M0d4QnFSRXVuc2NXbjAvK1dTTk5oY2NVUDRnT1ludkszcmNkQmlac2VVMUdn?=
 =?utf-8?B?ZmFBcm14ZnprdWhVTlNrOExnbGJrWXR1Rk5UeW5BQzdCT0s0c3RBaks3aTlw?=
 =?utf-8?B?aU1XZDArUWhTSFhPNGN3RW5yck5QOFN1a0FSR3BEaFpsRnNJYWdTVTlmamtt?=
 =?utf-8?B?bk41Zis1U050b3puQWlydGdGTnNlalk3TXppNVZnMFdzUTl1TnNESnJkdUhx?=
 =?utf-8?B?ekozbnE1eFpZQVVkMWdZOWIySXBnQk94TUl3aFZsVWl0VEJZQ2hyb3NBK1o2?=
 =?utf-8?B?WTZyMlJIQVZUOENvUDhWWGRKQnBvcnIyam4vMG11bDNxVlJSQlo5MCtKekhl?=
 =?utf-8?B?MGtkWXd6VVNTRVFBQ3pXNjB3NTNhQmpNYkorTU8yL1BhMEp4SmRUR0ppZm54?=
 =?utf-8?B?cHRJYnZZL1hndk5tSHkxL3kvTzJtejl0S0YvRmdUOU5KRERKWXJtc1JvM1E0?=
 =?utf-8?B?akJTQVFYL3lFZTFOc1pCaGk1RDYwTWZSeFhtZkZSSEs1MlBUUk9VMXFDOXBL?=
 =?utf-8?B?bXk1RFd5Zy9lWFhyTjV4ZWxJcGpjWEZRMG9ncGd0NmJQMkYyNkdTS3BobnA2?=
 =?utf-8?B?c2R2NndERXI1azlFRlQ5VHBDYUZ0SU1PM3Z4WXZYUW5IK1BBZnRSdkpmN083?=
 =?utf-8?B?cSs2THVlMHlpOENHNkNzYkZxUzRnakhRQ2RsZEVaR0R6aEtNL2E3eGFkRmZo?=
 =?utf-8?B?eVFjS21LQk5VY3JmeHFHQWJ1NXJVQ3N1bi8yYnBHQUUzdmJVc1Q4eG1xTmlJ?=
 =?utf-8?B?akE2WHBpVWd4VVg5anhrY2xLM3hKclFOMjViWEhycXduZ1FVbTUzVmlhZ0pU?=
 =?utf-8?B?V29zdzg0QkJUcnkzdTNteFkrNmMyVlkvTDVUUlEyYndOS29ETDZES284UFVF?=
 =?utf-8?B?SlpxNHlHVWVXODliRCtEdml2VVhWQ1dLR1NaUGtsSEFSaHBqTjhpbUtDRmVS?=
 =?utf-8?B?NHViYjZsWnVvWU1VMVBaZCt4dEhZUngwbG9LZG9DeXZ6OGtFU3M4bTJhSitj?=
 =?utf-8?B?RVJDMW5nby9jcmtQdWJCOEt2bXFpRUtEc3hjRnNEdGtwNGxlNWpaOWFJQUpi?=
 =?utf-8?B?Q3o4L1ZhYk8wVCs3OUdyejV4UmNYVUczeDg1bFYyQ1NLeFdDTVhXMnkrVGNa?=
 =?utf-8?B?NUVlUWhNZGk0T2tYVW5wYzNGUVhGS1FPVXpvTitodWdwbXJ2TWdXZ2NRejFr?=
 =?utf-8?B?NlVZemM2OFo0Q0ZFMzdxQnJWeE5semN5V1N1c2E5Y1hKaHJFRllrMkQ2SU5v?=
 =?utf-8?B?S3ZYcGlhU2VqeUlJcWtVVHRmL0tETU10aVpQbnM1ak56R1lNWFR6YTVjdHYy?=
 =?utf-8?B?Y3laNkM4NW8zMnBoM1NQeTdnMnZqVVZWOGhza0I4VXk5ZGJ5a1JtOC9nMWxX?=
 =?utf-8?B?UUZ0NlVtUjUybWorSk1mWkR2b00yaHJlbDYrMFpUeUozM2FQcThnZDA2eUt5?=
 =?utf-8?B?aVRXczVVelNPS09nMXB4R2lhNjZCdmZtTEdMbkVPS3c5U3YrTnhrOUVBU3hn?=
 =?utf-8?B?ckNRWTVMTnU2MFJQWU8wVnhMSndaek1sWjBJenE0ejJraWJqNmVQUitXUkNu?=
 =?utf-8?B?eDhRYms4K2pUcmRXKytBOUJwSnBZYzlGYWZvc3JDdGp1NXRtRmNVelVHSnZr?=
 =?utf-8?B?c3RtV3llYUg1RWYyWXBkYkJId25sV0NtYXdGY096TFQzcTBFS2NhZz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <672BD0FDBC46C5408D5ECEFB5D911FFC@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f93ea099-3caa-4298-5180-08d9e6542828
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Feb 2022 13:58:56.8915
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Gw0/DVZm96XKWWk6E2V4lBnSJo05yyMeYgRCewMTqlnThzTx6Ic0HrWpTKJYp8OIB4haimTCoGpygZU8HVcE13LG2k76pFO8R8Fhe7U7RTgITsakiTuvQHeESuD3kadb
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR03MB5869
X-Proofpoint-GUID: ocGucHB67hxXHIqAw46WcMdh1fks12ei
X-Proofpoint-ORIG-GUID: ocGucHB67hxXHIqAw46WcMdh1fks12ei
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-02_06,2022-02-01_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 adultscore=0
 malwarescore=0 impostorscore=0 suspectscore=0 mlxscore=0 spamscore=0
 priorityscore=1501 mlxlogscore=986 lowpriorityscore=0 clxscore=1015
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202020077

SGksIFJvZ2VyIQ0KDQpPbiAxMy4wMS4yMiAxNDoxOCwgUm9nZXIgUGF1IE1vbm7DqSB3cm90ZToN
Cj4gT24gVGh1LCBOb3YgMjUsIDIwMjEgYXQgMDE6MDI6NDlQTSArMDIwMCwgT2xla3NhbmRyIEFu
ZHJ1c2hjaGVua28gd3JvdGU6DQo+PiBGcm9tOiBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyA8b2xl
a3NhbmRyX2FuZHJ1c2hjaGVua29AZXBhbS5jb20+DQo+Pg0KPj4gVGhlcmUgYXJlIHRocmVlICBv
cmlnaW5hdG9ycyBmb3IgdGhlIFBDSSBjb25maWd1cmF0aW9uIHNwYWNlIGFjY2VzczoNCj4+IDEu
IFRoZSBkb21haW4gdGhhdCBvd25zIHBoeXNpY2FsIGhvc3QgYnJpZGdlOiBNTUlPIGhhbmRsZXJz
IGFyZQ0KPj4gdGhlcmUgc28gd2UgY2FuIHVwZGF0ZSB2UENJIHJlZ2lzdGVyIGhhbmRsZXJzIHdp
dGggdGhlIHZhbHVlcw0KPj4gd3JpdHRlbiBieSB0aGUgaGFyZHdhcmUgZG9tYWluLCBlLmcuIHBo
eXNpY2FsIHZpZXcgb2YgdGhlIHJlZ2lzdGVycw0KPj4gdnMgZ3Vlc3QncyB2aWV3IG9uIHRoZSBj
b25maWd1cmF0aW9uIHNwYWNlLg0KPj4gMi4gR3Vlc3QgYWNjZXNzIHRvIHRoZSBwYXNzZWQgdGhy
b3VnaCBQQ0kgZGV2aWNlczogd2UgbmVlZCB0byBwcm9wZXJseQ0KPj4gbWFwIHZpcnR1YWwgYnVz
IHRvcG9sb2d5IHRvIHRoZSBwaHlzaWNhbCBvbmUsIGUuZy4gcGFzcyB0aGUgY29uZmlndXJhdGlv
bg0KPj4gc3BhY2UgYWNjZXNzIHRvIHRoZSBjb3JyZXNwb25kaW5nIHBoeXNpY2FsIGRldmljZXMu
DQo+PiAzLiBFbXVsYXRlZCBob3N0IFBDSSBicmlkZ2UgYWNjZXNzLiBJdCBkb2Vzbid0IGV4aXN0
IGluIHRoZSBwaHlzaWNhbA0KPj4gdG9wb2xvZ3ksIGUuZy4gaXQgY2FuJ3QgYmUgbWFwcGVkIHRv
IHNvbWUgcGh5c2ljYWwgaG9zdCBicmlkZ2UuDQo+PiBTbywgYWxsIGFjY2VzcyB0byB0aGUgaG9z
dCBicmlkZ2UgaXRzZWxmIG5lZWRzIHRvIGJlIHRyYXBwZWQgYW5kDQo+PiBlbXVsYXRlZC4NCj4g
SSdtIGtpbmQgb2YgbG9zdCBpbiB0aGlzIGNvbW1pdCBtZXNzYWdlLiBZb3UgYXJlIGp1c3QgYWRk
aW5nIGENCj4gdHJhbnNsYXRlIGZ1bmN0aW9uIGluIG9yZGVyIGZvciBkb21VcyB0byB0cmFuc2xh
dGUgZnJvbSB2aXJ0dWFsIFNCREYNCj4gdG8gdGhlIHBoeXNpY2FsIFNCREYgb2YgdGhlIGRldmlj
ZS4gSSByZWFsaXplIHlvdSBkbyB0aGF0IGJhc2VkIG9uDQo+IHdoZXRoZXIgJ2JyaWRnZScgaXMg
c2V0IG9yIG5vdCwgc28gSSBhc3N1bWUgdGhpcyBpcyBqdXN0IGEgd2F5IHRvDQo+IHNpZ25hbCB3
aGV0aGVyIHRoZSBkb21haW4gaXMgYSBoYXJkd2FyZSBkb21haW4gb3Igbm90LiBJZToNCj4gISFi
cmlkZ2UgPT0gaXNfaGFyZHdhcmVfZG9tYWluKHYtPmRvbWFpbikuDQpTaW1wbHkgcHV0OiB5ZXMN
Cj4NCj4+IFNpZ25lZC1vZmYtYnk6IE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIDxvbGVrc2FuZHJf
YW5kcnVzaGNoZW5rb0BlcGFtLmNvbT4NCj4+IC0tLQ0KPj4gU2luY2UgdjQ6DQo+PiAtIGluZGVu
dGF0aW9uIGZpeGVzDQo+PiAtIGNvbnN0aWZ5IHN0cnVjdCBkb21haW4NCj4+IC0gdXBkYXRlZCBj
b21taXQgbWVzc2FnZQ0KPj4gLSB1cGRhdGVzIHRvIHRoZSBuZXcgbG9ja2luZyBzY2hlbWUgKHBk
ZXYtPnZwY2lfbG9jaykNCj4+IFNpbmNlIHYzOg0KPj4gLSByZXZpc2l0IGxvY2tpbmcNCj4+IC0g
bW92ZSBjb2RlIHRvIHZwY2kuYw0KPj4gU2luY2UgdjI6DQo+PiAgIC0gcGFzcyBzdHJ1Y3QgZG9t
YWluIGluc3RlYWQgb2Ygc3RydWN0IHZjcHUNCj4+ICAgLSBjb25zdGlmeSBhcmd1bWVudHMgd2hl
cmUgcG9zc2libGUNCj4+ICAgLSBnYXRlIHJlbGV2YW50IGNvZGUgd2l0aCBDT05GSUdfSEFTX1ZQ
Q0lfR1VFU1RfU1VQUE9SVA0KPj4gTmV3IGluIHYyDQo+PiAtLS0NCj4+ICAgeGVuL2FyY2gvYXJt
L3ZwY2kuYyAgICAgfCAxOCArKysrKysrKysrKysrKysrKysNCj4+ICAgeGVuL2RyaXZlcnMvdnBj
aS92cGNpLmMgfCAyNyArKysrKysrKysrKysrKysrKysrKysrKysrKysNCj4+ICAgeGVuL2luY2x1
ZGUveGVuL3ZwY2kuaCAgfCAgMSArDQo+PiAgIDMgZmlsZXMgY2hhbmdlZCwgNDYgaW5zZXJ0aW9u
cygrKQ0KPj4NCj4+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vdnBjaS5jIGIveGVuL2FyY2gv
YXJtL3ZwY2kuYw0KPj4gaW5kZXggOGU4MDFmMjc1ODc5Li4zZDEzNGY0MmQwN2UgMTAwNjQ0DQo+
PiAtLS0gYS94ZW4vYXJjaC9hcm0vdnBjaS5jDQo+PiArKysgYi94ZW4vYXJjaC9hcm0vdnBjaS5j
DQo+PiBAQCAtNDEsNiArNDEsMTUgQEAgc3RhdGljIGludCB2cGNpX21taW9fcmVhZChzdHJ1Y3Qg
dmNwdSAqdiwgbW1pb19pbmZvX3QgKmluZm8sDQo+PiAgICAgICAvKiBkYXRhIGlzIG5lZWRlZCB0
byBwcmV2ZW50IGEgcG9pbnRlciBjYXN0IG9uIDMyYml0ICovDQo+PiAgICAgICB1bnNpZ25lZCBs
b25nIGRhdGE7DQo+PiAgIA0KPj4gKyNpZmRlZiBDT05GSUdfSEFTX1ZQQ0lfR1VFU1RfU1VQUE9S
VA0KPj4gKyAgICAvKg0KPj4gKyAgICAgKiBGb3IgdGhlIHBhc3NlZCB0aHJvdWdoIGRldmljZXMg
d2UgbmVlZCB0byBtYXAgdGhlaXIgdmlydHVhbCBTQkRGDQo+PiArICAgICAqIHRvIHRoZSBwaHlz
aWNhbCBQQ0kgZGV2aWNlIGJlaW5nIHBhc3NlZCB0aHJvdWdoLg0KPj4gKyAgICAgKi8NCj4+ICsg
ICAgaWYgKCAhYnJpZGdlICYmICF2cGNpX3RyYW5zbGF0ZV92aXJ0dWFsX2RldmljZSh2LT5kb21h
aW4sICZzYmRmKSApDQo+PiArICAgICAgICByZXR1cm4gMTsNCj4gSSdtIHVuc3VyZSB3aGF0IHJl
dHVybmluZyAxIGltcGxpZXMgZm9yIEFybSBoZXJlLCBidXQgeW91IGxpa2VseSBuZWVkDQo+IHRv
IHNldCAnKnIgPSB+MHVsOycuDQpHb29kIGNhdGNoLCB3aWxsIGFkZA0KPg0KPj4gKyNlbmRpZg0K
Pj4gKw0KPj4gICAgICAgaWYgKCB2cGNpX2VjYW1fcmVhZChzYmRmLCBFQ0FNX1JFR19PRkZTRVQo
aW5mby0+Z3BhKSwNCj4+ICAgICAgICAgICAgICAgICAgICAgICAgICAgMVUgPDwgaW5mby0+ZGFi
dC5zaXplLCAmZGF0YSkgKQ0KPj4gICAgICAgew0KPj4gQEAgLTU5LDYgKzY4LDE1IEBAIHN0YXRp
YyBpbnQgdnBjaV9tbWlvX3dyaXRlKHN0cnVjdCB2Y3B1ICp2LCBtbWlvX2luZm9fdCAqaW5mbywN
Cj4+ICAgICAgIHN0cnVjdCBwY2lfaG9zdF9icmlkZ2UgKmJyaWRnZSA9IHA7DQo+PiAgICAgICBw
Y2lfc2JkZl90IHNiZGYgPSB2cGNpX3NiZGZfZnJvbV9ncGEoYnJpZGdlLCBpbmZvLT5ncGEpOw0K
Pj4gICANCj4+ICsjaWZkZWYgQ09ORklHX0hBU19WUENJX0dVRVNUX1NVUFBPUlQNCj4+ICsgICAg
LyoNCj4+ICsgICAgICogRm9yIHRoZSBwYXNzZWQgdGhyb3VnaCBkZXZpY2VzIHdlIG5lZWQgdG8g
bWFwIHRoZWlyIHZpcnR1YWwgU0JERg0KPj4gKyAgICAgKiB0byB0aGUgcGh5c2ljYWwgUENJIGRl
dmljZSBiZWluZyBwYXNzZWQgdGhyb3VnaC4NCj4+ICsgICAgICovDQo+PiArICAgIGlmICggIWJy
aWRnZSAmJiAhdnBjaV90cmFuc2xhdGVfdmlydHVhbF9kZXZpY2Uodi0+ZG9tYWluLCAmc2JkZikg
KQ0KPj4gKyAgICAgICAgcmV0dXJuIDE7DQo+PiArI2VuZGlmDQo+PiArDQo+PiAgICAgICByZXR1
cm4gdnBjaV9lY2FtX3dyaXRlKHNiZGYsIEVDQU1fUkVHX09GRlNFVChpbmZvLT5ncGEpLA0KPj4g
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAxVSA8PCBpbmZvLT5kYWJ0LnNpemUsIHIpOw0K
Pj4gICB9DQo+PiBkaWZmIC0tZ2l0IGEveGVuL2RyaXZlcnMvdnBjaS92cGNpLmMgYi94ZW4vZHJp
dmVycy92cGNpL3ZwY2kuYw0KPj4gaW5kZXggYzJmYjRkNGRiMjMzLi5iZGM4YzYzZjczZmEgMTAw
NjQ0DQo+PiAtLS0gYS94ZW4vZHJpdmVycy92cGNpL3ZwY2kuYw0KPj4gKysrIGIveGVuL2RyaXZl
cnMvdnBjaS92cGNpLmMNCj4+IEBAIC0xOTUsNiArMTk1LDMzIEBAIHN0YXRpYyB2b2lkIHZwY2lf
cmVtb3ZlX3ZpcnR1YWxfZGV2aWNlKHN0cnVjdCBkb21haW4gKmQsDQo+PiAgICAgICBwZGV2LT52
cGNpLT5ndWVzdF9zYmRmLnNiZGYgPSB+MDsNCj4+ICAgfQ0KPj4gICANCj4+ICsvKg0KPj4gKyAq
IEZpbmQgdGhlIHBoeXNpY2FsIGRldmljZSB3aGljaCBpcyBtYXBwZWQgdG8gdGhlIHZpcnR1YWwg
ZGV2aWNlDQo+PiArICogYW5kIHRyYW5zbGF0ZSB2aXJ0dWFsIFNCREYgdG8gdGhlIHBoeXNpY2Fs
IG9uZS4NCj4+ICsgKi8NCj4+ICtib29sIHZwY2lfdHJhbnNsYXRlX3ZpcnR1YWxfZGV2aWNlKGNv
bnN0IHN0cnVjdCBkb21haW4gKmQsIHBjaV9zYmRmX3QgKnNiZGYpDQo+PiArew0KPj4gKyAgICBz
dHJ1Y3QgcGNpX2RldiAqcGRldjsNCj4+ICsNCj4gSSB3b3VsZCBhZGQ6DQo+DQo+IEFTU0VSVCgh
aXNfaGFyZHdhcmVfZG9tYWluKGQpKTsNCj4NCj4gVG8gbWFrZSBzdXJlIHRoaXMgaXMgbm90IHVz
ZWQgZm9yIHRoZSBoYXJkd2FyZSBkb21haW4uDQpXaWxsIGFkZA0KPg0KPj4gKyAgICBmb3JfZWFj
aF9wZGV2KCBkLCBwZGV2ICkNCj4+ICsgICAgew0KPj4gKyAgICAgICAgYm9vbCBmb3VuZDsNCj4+
ICsNCj4+ICsgICAgICAgIHNwaW5fbG9jaygmcGRldi0+dnBjaV9sb2NrKTsNCj4+ICsgICAgICAg
IGZvdW5kID0gcGRldi0+dnBjaSAmJiAocGRldi0+dnBjaS0+Z3Vlc3Rfc2JkZi5zYmRmID09IHNi
ZGYtPnNiZGYpOw0KPj4gKyAgICAgICAgc3Bpbl91bmxvY2soJnBkZXYtPnZwY2lfbG9jayk7DQo+
PiArDQo+PiArICAgICAgICBpZiAoIGZvdW5kICkNCj4+ICsgICAgICAgIHsNCj4+ICsgICAgICAg
ICAgICAvKiBSZXBsYWNlIGd1ZXN0IFNCREYgd2l0aCB0aGUgcGh5c2ljYWwgb25lLiAqLw0KPj4g
KyAgICAgICAgICAgICpzYmRmID0gcGRldi0+c2JkZjsNCj4+ICsgICAgICAgICAgICByZXR1cm4g
dHJ1ZTsNCj4+ICsgICAgICAgIH0NCj4+ICsgICAgfQ0KPj4gKw0KPj4gKyAgICByZXR1cm4gZmFs
c2U7DQo+PiArfQ0KPj4gKw0KPj4gICAvKiBOb3RpZnkgdlBDSSB0aGF0IGRldmljZSBpcyBhc3Np
Z25lZCB0byBndWVzdC4gKi8NCj4+ICAgaW50IHZwY2lfYXNzaWduX2RldmljZShzdHJ1Y3QgZG9t
YWluICpkLCBzdHJ1Y3QgcGNpX2RldiAqcGRldikNCj4+ICAgew0KPj4gZGlmZiAtLWdpdCBhL3hl
bi9pbmNsdWRlL3hlbi92cGNpLmggYi94ZW4vaW5jbHVkZS94ZW4vdnBjaS5oDQo+PiBpbmRleCBl
NTI1OGJkN2NlOTAuLjIxZDc2OTI5MzkxZiAxMDA2NDQNCj4+IC0tLSBhL3hlbi9pbmNsdWRlL3hl
bi92cGNpLmgNCj4+ICsrKyBiL3hlbi9pbmNsdWRlL3hlbi92cGNpLmgNCj4+IEBAIC0yODAsNiAr
MjgwLDcgQEAgc3RhdGljIGlubGluZSB2b2lkIHZwY2lfY2FuY2VsX3BlbmRpbmdfbG9ja2VkKHN0
cnVjdCBwY2lfZGV2ICpwZGV2KQ0KPj4gICAvKiBOb3RpZnkgdlBDSSB0aGF0IGRldmljZSBpcyBh
c3NpZ25lZC9kZS1hc3NpZ25lZCB0by9mcm9tIGd1ZXN0LiAqLw0KPj4gICBpbnQgdnBjaV9hc3Np
Z25fZGV2aWNlKHN0cnVjdCBkb21haW4gKmQsIHN0cnVjdCBwY2lfZGV2ICpwZGV2KTsNCj4+ICAg
aW50IHZwY2lfZGVhc3NpZ25fZGV2aWNlKHN0cnVjdCBkb21haW4gKmQsIHN0cnVjdCBwY2lfZGV2
ICpwZGV2KTsNCj4+ICtib29sIHZwY2lfdHJhbnNsYXRlX3ZpcnR1YWxfZGV2aWNlKGNvbnN0IHN0
cnVjdCBkb21haW4gKmQsIHBjaV9zYmRmX3QgKnNiZGYpOw0KPj4gICAjZWxzZQ0KPj4gICBzdGF0
aWMgaW5saW5lIGludCB2cGNpX2Fzc2lnbl9kZXZpY2Uoc3RydWN0IGRvbWFpbiAqZCwgc3RydWN0
IHBjaV9kZXYgKnBkZXYpDQo+PiAgIHsNCj4gSWYgeW91IGFkZCBhIGR1bW15IHZwY2lfdHJhbnNs
YXRlX3ZpcnR1YWxfZGV2aWNlIGhlbHBlciB0aGF0IHJldHVybnMNCj4gZmFsc2UgdW5jb25kaXRp
b25hbGx5IGhlcmUgeW91IGNvdWxkIGRyb3AgdGhlICNpZmRlZnMgaW4gYXJtL3ZwY2kuYw0KPiBB
RkFJQ1QuDQpXaWxsIHRyeSB0byBkbyBzbw0KPg0KPiBUaGFua3MsIFJvZ2VyLg0KVGhhbmsgeW91
LA0KT2xla3NhbmRy


From xen-devel-bounces@lists.xenproject.org Wed Feb 02 14:06:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 14:06:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264214.457230 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFGGx-0000C2-AW; Wed, 02 Feb 2022 14:06:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264214.457230; Wed, 02 Feb 2022 14:06:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFGGx-0000Bv-6Z; Wed, 02 Feb 2022 14:06:11 +0000
Received: by outflank-mailman (input) for mailman id 264214;
 Wed, 02 Feb 2022 14:06:09 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nFGGv-0000BU-Tt; Wed, 02 Feb 2022 14:06:09 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nFGGv-0002wi-Jl; Wed, 02 Feb 2022 14:06:09 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nFGGu-0006DK-Vl; Wed, 02 Feb 2022 14:06:09 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nFGGu-0003L3-VN; Wed, 02 Feb 2022 14:06:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=13sfHgUAU7mqJSaMDlgB/M+creJJ0YiltBO/iyvp86I=; b=ApVC9PsFxPakMUPZVWIH6b6E5n
	DfOQsxFxaiFYO8uE1Psb+aohqKcxV1L4FbvG9V9BOzsmG3mvO3uhhBmzXc4m0OEo1odvY23TReVxm
	Ku9ghjG6SaREsN+62qpzwMU5Stl3JXAl9/NOF1w/KXjw6sh817a+qcABUYNLKpeGCjZM=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167982-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 167982: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=2c0898ff4ebe58d49d496806c000a85874cc283e
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 02 Feb 2022 14:06:08 +0000

flight 167982 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167982/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              2c0898ff4ebe58d49d496806c000a85874cc283e
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  572 days
Failing since        151818  2020-07-11 04:18:52 Z  571 days  553 attempts
Testing same since   167982  2022-02-02 04:18:57 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brad Laue <brad@brad-x.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Christophe Fergeau <cfergeau@redhat.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Divya Garg <divya.garg@nutanix.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Emilio Herrera <ehespinosa57@gmail.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Ivan Teterevkov <ivan.teterevkov@nutanix.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nicolas Lécureuil <neoclust@mageia.org>
  Nicolas Lécureuil <nicolas.lecureuil@siveo.net>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Rohit Kumar <rohit.kumar3@nutanix.com>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  shenjiatong <yshxxsjt715@gmail.com>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tuguoyi <tu.guoyi@h3c.com>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Vineeth Pillai <viremana@linux.microsoft.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yasuhiko Kamata <belphegor@belbel.or.jp>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 95714 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Feb 02 14:08:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 14:08:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264224.457240 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFGJT-0000qA-PN; Wed, 02 Feb 2022 14:08:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264224.457240; Wed, 02 Feb 2022 14:08:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFGJT-0000q3-MC; Wed, 02 Feb 2022 14:08:47 +0000
Received: by outflank-mailman (input) for mailman id 264224;
 Wed, 02 Feb 2022 14:08:46 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1p3Q=SR=epam.com=prvs=40324c57ab=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nFGJS-0000px-26
 for xen-devel@lists.xenproject.org; Wed, 02 Feb 2022 14:08:46 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a159b3aa-8431-11ec-8eb8-a37418f5ba1a;
 Wed, 02 Feb 2022 15:08:44 +0100 (CET)
Received: from pps.filterd (m0174678.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 212DsAVc019829;
 Wed, 2 Feb 2022 14:08:40 GMT
Received: from eur04-db3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2052.outbound.protection.outlook.com [104.47.12.52])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3dyu8br38k-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 02 Feb 2022 14:08:38 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by DB7PR03MB4700.eurprd03.prod.outlook.com (2603:10a6:10:1c::25) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.11; Wed, 2 Feb
 2022 14:08:29 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6%3]) with mapi id 15.20.4951.012; Wed, 2 Feb 2022
 14:08:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a159b3aa-8431-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=WI/iQiYtZcFBeQbQy1Fvy+6H4rXi+YrAdRnuif/m73tCvvRBA3CsKUKo0x6vvVA8O00D9p62R0cPLTdVWVRHEIybxpknZsOG6gauZkDJtudCoCbXLJEwp38OfLMn41UuGjp97gmS4FSohIKEOibIcmZQQ+rcSdCgCODEXQqyOxOHLCe/suk9noH9uvygmaRLVMwBjY8U41DTkOiFFLurW8hNjnhhb0FcK1tLmSbWA645JNBEAv7B1R/9fYsLgOpwTY1YiCQXmr6zko8RFvX7Mx9GQ3vtPomOWAioMPhJCiT8yNYjYQyk1ZLaIc/nMbqagO8JWMlVe9FrzAYOysBpdw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=EsK5JEw4uol7jvopYR4wghYE0SKCQvUUk6OTqoTlstw=;
 b=E7sQSL0FcUJQLGPcqte3dOkq71PjYmMnVKocGClrmvz3I5wD5DCxPsGcYmTILHKu9Tz8OOcv7GjR0rFcNMHk/wJB7kUDzndN/Gl9rKad1sXXqR9ny3N32pelRYhRCYjlJKkzCNFy02vY7fClSYRJTxf6cCdmOW27t/5O3ctKz/LDBP+RZfytjmNHiYdcgHi7RfgI9HkTmZybnemqKFlwd9r4pWSCzDqTqQeO/y5Y06j5q6O5r/2o/tUhRz9T8+552GtREQfPeepFJDO4XsrM9Yx3l/SMpVekORuqm+k6JYgpsNr/5+/o77t3LKJvONPbYiKuOXrUuIKLZ5ACuHDDRQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=EsK5JEw4uol7jvopYR4wghYE0SKCQvUUk6OTqoTlstw=;
 b=jCIQNeAFKqv0uuD1fLg50jQHBXLITz0uV0XUEK+sasZ0ZksSEJEAvdtqbLD7ZbtQUBS0GmJjsFFIiT4tqHyfCc9FdqJDwxn83bKZbD3yxDq42n7z8nFtUpF0foqy7jCS8s4yNvHI+qRPgtCwgqClTThTsQAOfhAU1NoDQI7JGjdB9DzxNJg2SDIkrlVDXD0V9IZT/b9RAQZjQenAJET6FHNxMxc9lmppifGBJf6J7J0vzdUF9cLP4y+9fk8aRE5Jhdo5jHRLkDc54i0gIh0ST+hMETSOqYYIdk1SZTKVmJ4LJH+dOXoxx/B/QBMnvgeP/RIuXZN3MUiIB8FQ+HZFgQ==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "jbeulich@suse.com" <jbeulich@suse.com>,
        "andrew.cooper3@citrix.com"
	<andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com"
	<george.dunlap@citrix.com>,
        "paul@xen.org" <paul@xen.org>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>,
        Rahul Singh <rahul.singh@arm.com>,
        Oleksandr
 Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v5 13/14] xen/arm: account IO handlers for emulated PCI
 MSI-X
Thread-Topic: [PATCH v5 13/14] xen/arm: account IO handlers for emulated PCI
 MSI-X
Thread-Index: AQHX4ewM3E9Hca8G9ECzl5GuB0PchKxhPaoAgB97MoA=
Date: Wed, 2 Feb 2022 14:08:29 +0000
Message-ID: <e5428b6b-a254-c360-bc7c-cdc7e2a12290@epam.com>
References: <20211125110251.2877218-1-andr2000@gmail.com>
 <20211125110251.2877218-14-andr2000@gmail.com>
 <YeAn0k1HbYFUGeMj@Air-de-Roger>
In-Reply-To: <YeAn0k1HbYFUGeMj@Air-de-Roger>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 4c060d28-cecc-4169-7c4a-08d9e6557d5d
x-ms-traffictypediagnostic: DB7PR03MB4700:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <DB7PR03MB47008ABA0D0981597FA1B150E7279@DB7PR03MB4700.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8882;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 nljte0qEiqtSmLUJGjYe2F1eNn6ynyN6wtSllqDAq6UkIi6t81xbGGufIhsTKerWPaHACPl5oIgOA08dy9XzQceBI6c1YGlkHaadCNjBl2UMsFhaPfbD/fLrpTNzur98+ShHMDKEEtTHUu+BrFKzxcmshYmtfGJYWoeS4b8b2OXTDrgzXV1N2DVxH8KoJ1e0zc9ZljAzcAfDyfctQeKnEaNUIU/GEtK1nqrGOlZRvuUyp+EC77j0+/UbPzHLkXPlVjJiQzyKh5Y2JUtIG4iW5S6yJtXqf/6BlKmCAvbtkGXnafPJIL6HYsOd3gbKzmcicDJSWFPTL2NY82+EBut+UHOFNtXnszilnuudJrXVD42NZvxnvu2ImzBipO0jG7PuABdLQiUPHRs1aNnrEOydG4a1PaXhZkEk8iJOB19gHP+iGzE+5xlVho/LUYn/b4utjcL+I2sBjVu60zKH0n9DzSmqHqlw51CCOwOJxvY8D8QHoEZcziWTBD1WJw5dN+Aqn2eCdNA+LqHiEIG7N4MFi+IdQ/BarWqAZI70WKp8D1qUHX2bXgPkRZvSREjT2nEPg0Rx70hUWKSoO1rsuYTUDRZYHmR5hCEmgodSx8yZc5cvwCyvuN+lSCeKlBN7Jub8sjHoP23J8LibVq0Ei4+krB+yjDCpPNZfiFY2t/K6XA+6uDdU7AxYpKxeRuStBCiUYWd8WpiGeXx+JSn7YUoaPm5egYacs+FFl9R0ZgDBoDfnjMIGcn+4ORLItq/Q9XHz
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(53546011)(107886003)(71200400001)(2616005)(36756003)(508600001)(6486002)(83380400001)(2906002)(186003)(6506007)(26005)(6512007)(31686004)(7416002)(8676002)(66476007)(316002)(6916009)(66556008)(4326008)(66946007)(38070700005)(8936002)(5660300002)(91956017)(38100700002)(31696002)(15650500001)(76116006)(54906003)(122000001)(86362001)(64756008)(66446008)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?dWQ3bzhxRTJBUzJrQ05WK0RuVVA3TTBPUWM5ZThtMjVJQUwyOHJVR2prK3do?=
 =?utf-8?B?QWVQSWRYNnpGUHRpcTNCMmJJU0UxM05ZQ1ZBS0piMmZMODI4bVl3TUVVdlFa?=
 =?utf-8?B?YjcxcXpRMVV1WXZsUHViVjdQS3c5MktiQnlWN0xIT3Z0NERYK3pJc2NHSFdu?=
 =?utf-8?B?L1B3ZkRCZHNISDFzcnlMM1Q0REZ5b0lTbTJia3hkaGdlbUQwSjV0c1U1ZWk5?=
 =?utf-8?B?aDZYSVFVZkpnaVJYMms0UjFYSHpqYzB1VitVbFpuam16SExNRExwZEN5Nll6?=
 =?utf-8?B?UmIxbHRia2w5cGFWcEZkbmtuK3dCckVCVy90VkNxRmlkSU5mSnBISGZSOG5D?=
 =?utf-8?B?Q2ZDemdnQ2lHT1paK0V4WEFSQ2lYWnUyS1hmak0ydGFtWXhNR0N6RFFYVFlC?=
 =?utf-8?B?TjkvNEwvUXhKZGdqUzhGS1oxVW5CV0NiVkE3OVU0Smw0MDRISzVoY04vVndF?=
 =?utf-8?B?dkowRjJtMU5UOE1tNlV5NXZjYjVZeTNFMGl3U2YwZkNWMHRJditUQXFDVlQx?=
 =?utf-8?B?OUxoS0RzUWxaM3NUb0pyZTNxT3UzazRhN3Q4WFZub3RXTWk2OG05ZDd3OWRn?=
 =?utf-8?B?Z0N1VjUwaG1ENFFuKzFPVWYyYnNQQVdKSnphTU4yQVRBTlVONys5blJlRDF5?=
 =?utf-8?B?S1d6dmVaNlhCcjJhS0FJMHJCUVFoZUhIMjNaVTFVN3B5czVSdXA3dkZNM0Nv?=
 =?utf-8?B?aERjU2ZEZFc5U1JhK1lzcHRQNXpOSldtNWFvaW0ySnVkOEpLTC95QU45Sk5T?=
 =?utf-8?B?OTJqWVdEdlZteW9RdFNITTNSYU16citDclFUbWREbmZFUFJzL3UvL3R6bzUx?=
 =?utf-8?B?Y1V1UkRuT3kvTmVrUytRdDR2SjhMbnBJSFdWZ2RIbGU3UUJDTHRMUTF1SVlz?=
 =?utf-8?B?ZkFBMEd1bU1BcENsd216RjUwd2VFYzFDNVJmb0djMW9iY3BXN0ZHcFB4dGgv?=
 =?utf-8?B?czBnQkxBajREQmY1OWRtQzQyNTZJNUZSakVlRndpNTkweUtKUHdQaTJHak51?=
 =?utf-8?B?UW9JUjFWdDdISnhtelN2ams2L2liY2NCUjAvMzUydU9qUEp0OGpSSi85a1M4?=
 =?utf-8?B?VjdPelhQbzJ3NXF4N0h6ejEybjhZSkVFTWozSXlQS2dUTkw2dU9TZ1Babmp2?=
 =?utf-8?B?Y2Zuem0rMVFOVlV2MFJWQnNYV2ZTV2JxVFpaVldYSXNJZFZUYXkreHBXdUx5?=
 =?utf-8?B?ZFNORm4xbU9VZThoSlVzWWlIaE84UWI4Y012ekNxNE1HbkxCT1BTdmw3MkhH?=
 =?utf-8?B?MlRwd3VlVi9DQmVKV2pzMFFmUmtTWnFoUHRaVW1zRXgrSmZ4Z2NTT3ZXRTgr?=
 =?utf-8?B?cDRXNG9wOEsrV0ZOUThGV3R6VStZMFAwUU43RjRHTWJrRnQ3MGRtV3YzdWlU?=
 =?utf-8?B?VzVEMjJWZXh3UzZFcjVGZkZTR3NBK2VKc3NESHA5VzVtc3lybkkrcWU2TTJu?=
 =?utf-8?B?Yy9POTRWMis2T2Joc1MyeThhejB4b1p2bzhxK1hPT1JycnVBRG9DV2VEa0VV?=
 =?utf-8?B?dkpsNGVCUkNIWlFrUyttMFN6b3EwTXJuODhBVTU5M1NQZElGSXFpRDg0MFh1?=
 =?utf-8?B?dXdWb3lyVitwMCt2dHJtU0dGRVJ0b1ZkZHloTTJCdTUxcGRYR2E0REZhMXIr?=
 =?utf-8?B?c2JxYUJXaFZJUHRYVUVyMEJITGJmZ3ZmblFjN21uT2F4bUQrN1FNWGozMVZj?=
 =?utf-8?B?TmE3NFNKOURQdWNOaDNPSy9UUG5ySnBGQk5mVUZvbGZTdGJmWFFXekJNVTZh?=
 =?utf-8?B?alRLUnJMWjA1dXgyNmRQNVkyQ0NTR3JTU09sNnN5bmJqaHVDZEhicmVjTVlt?=
 =?utf-8?B?Y2hoczBpL1V3R254Nm5qZ1hjZGNLU0lZV2NYMnVIOW4rSU1DNHZKOU9HMXBN?=
 =?utf-8?B?VGg3MEpmakh5elN4VjY3RGhXY1dkYUxZLzlVV0paNlBVZEQySnNtV0E2V0pM?=
 =?utf-8?B?UVhFblNHeitITTBtZVdRaDhqcHpKVWxvMGltQ0UyQUJ5cWJLTnlxbmxCRGpz?=
 =?utf-8?B?TVJ4a3RpMk0xU2xnMDFSVEVPS1dJNVMyTnVoaFFVTU42OUora3RJMTRqL215?=
 =?utf-8?B?TCtHZlJTMThqek81dG1iamliNWpscnJ0MVA1T1Ntem5pcVdXc3htZkxkYmV5?=
 =?utf-8?B?WWJEZkpRRitzQ1hXZXZETzY2NGJwdVA4QWVYZ3l2RWMzYVlWZ0NzR0pnSEZN?=
 =?utf-8?B?RjEyOGZ4NmY3MlVjRDNBbVVmSURHOUhmY25aSm0xRk53MStQb3Zmc3IzVU9x?=
 =?utf-8?B?VHlPYWV0TGZaY2t0Nng1SzVxeENHVXhGOUJ1UUU5aTNzOWk5VFJNM2JJRXZZ?=
 =?utf-8?B?RU5IR3g2WGhjWnJ5NTdLN0YxTGlHdTdvVldsN0VWaGZzL0M5bndrUT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <E0DF2C893DC1CA45967FE86F2C216B56@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4c060d28-cecc-4169-7c4a-08d9e6557d5d
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Feb 2022 14:08:29.8585
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: HDqSes3v6G/1215AE9TqfLh/+MG6r6V/Zd7wULZq6OvRdrud7Nh/MM5aSPIarHj52lAVTzqIPZ0iiKXrB+tI+e9wMKJi2qCpPHAnZMnawhLWIIXkfRABwGYB77ao6JCk
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR03MB4700
X-Proofpoint-GUID: GHu6xdae0zfAOc04Qg_jSXe1BlpNEnP5
X-Proofpoint-ORIG-GUID: GHu6xdae0zfAOc04Qg_jSXe1BlpNEnP5
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-02_06,2022-02-01_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 adultscore=0
 malwarescore=0 impostorscore=0 suspectscore=0 mlxscore=0 spamscore=0
 priorityscore=1501 mlxlogscore=753 lowpriorityscore=0 clxscore=1015
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202020078

SGksIFJvZ2VyIQ0KDQpPbiAxMy4wMS4yMiAxNToyMywgUm9nZXIgUGF1IE1vbm7DqSB3cm90ZToN
Cj4gT24gVGh1LCBOb3YgMjUsIDIwMjEgYXQgMDE6MDI6NTBQTSArMDIwMCwgT2xla3NhbmRyIEFu
ZHJ1c2hjaGVua28gd3JvdGU6DQo+PiBGcm9tOiBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyA8b2xl
a3NhbmRyX2FuZHJ1c2hjaGVua29AZXBhbS5jb20+DQo+Pg0KPj4gQXQgdGhlIG1vbWVudCwgd2Ug
YWx3YXlzIGFsbG9jYXRlIGFuIGV4dHJhIDE2IHNsb3RzIGZvciBJTyBoYW5kbGVycw0KPj4gKHNl
ZSBNQVhfSU9fSEFORExFUikuIFNvIHdoaWxlIGFkZGluZyBJTyB0cmFwIGhhbmRsZXJzIGZvciB0
aGUgZW11bGF0ZWQNCj4+IE1TSS1YIHJlZ2lzdGVycyB3ZSBuZWVkIHRvIGV4cGxpY2l0bHkgdGVs
bCB0aGF0IHdlIGhhdmUgYWRkaXRpb25hbCBJTw0KPj4gaGFuZGxlcnMsIHNvIHRob3NlIGFyZSBh
Y2NvdW50ZWQuDQo+Pg0KPj4gU2lnbmVkLW9mZi1ieTogT2xla3NhbmRyIEFuZHJ1c2hjaGVua28g
PG9sZWtzYW5kcl9hbmRydXNoY2hlbmtvQGVwYW0uY29tPg0KPiBMR1RNLCBqdXN0IG9uZSBjb21t
ZW50IGJlbG93LiBUaGlzIHdpbGwgcmVxdWlyZSBhbiBBY2sgZnJvbSB0aGUgQXJtDQo+IGd1eXMu
DQo+DQo+PiAtLS0NCj4+IENjOiBKdWxpZW4gR3JhbGwgPGp1bGllbkB4ZW4ub3JnPg0KPj4gQ2M6
IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz4NCj4+IC0tLQ0KPj4g
VGhpcyBhY3R1YWxseSBtb3ZlZCBoZXJlIGZyb20gdGhlIHBhcnQgMiBvZiB0aGUgcHJlcCB3b3Jr
IGZvciBQQ0kNCj4+IHBhc3N0aHJvdWdoIG9uIEFybSBhcyBpdCBzZWVtcyB0byBiZSB0aGUgcHJv
cGVyIHBsYWNlIGZvciBpdC4NCj4+DQo+PiBOZXcgaW4gdjUNCj4+IC0tLQ0KPj4gICB4ZW4vYXJj
aC9hcm0vdnBjaS5jIHwgMTUgKysrKysrKysrKysrKystDQo+PiAgIDEgZmlsZSBjaGFuZ2VkLCAx
NCBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pDQo+Pg0KPj4gZGlmZiAtLWdpdCBhL3hlbi9h
cmNoL2FybS92cGNpLmMgYi94ZW4vYXJjaC9hcm0vdnBjaS5jDQo+PiBpbmRleCAzZDEzNGY0MmQw
N2UuLjkwMmY4NDkxZTAzMCAxMDA2NDQNCj4+IC0tLSBhL3hlbi9hcmNoL2FybS92cGNpLmMNCj4+
ICsrKyBiL3hlbi9hcmNoL2FybS92cGNpLmMNCj4+IEBAIC0xMzQsNiArMTM0LDggQEAgc3RhdGlj
IGludCB2cGNpX2dldF9udW1faGFuZGxlcnNfY2Ioc3RydWN0IGRvbWFpbiAqZCwNCj4+ICAgDQo+
PiAgIHVuc2lnbmVkIGludCBkb21haW5fdnBjaV9nZXRfbnVtX21taW9faGFuZGxlcnMoc3RydWN0
IGRvbWFpbiAqZCkNCj4+ICAgew0KPj4gKyAgICB1bnNpZ25lZCBpbnQgY291bnQ7DQo+PiArDQo+
PiAgICAgICBpZiAoICFoYXNfdnBjaShkKSApDQo+PiAgICAgICAgICAgcmV0dXJuIDA7DQo+PiAg
IA0KPj4gQEAgLTE0NSw3ICsxNDcsMTggQEAgdW5zaWduZWQgaW50IGRvbWFpbl92cGNpX2dldF9u
dW1fbW1pb19oYW5kbGVycyhzdHJ1Y3QgZG9tYWluICpkKQ0KPj4gICAgICAgfQ0KPj4gICANCj4+
ICAgICAgIC8qIEZvciBhIHNpbmdsZSBlbXVsYXRlZCBob3N0IGJyaWRnZSdzIGNvbmZpZ3VyYXRp
b24gc3BhY2UuICovDQo+PiAtICAgIHJldHVybiAxOw0KPj4gKyAgICBjb3VudCA9IDE7DQo+PiAr
DQo+PiArI2lmZGVmIENPTkZJR19IQVNfUENJX01TSQ0KPj4gKyAgICAvKg0KPj4gKyAgICAgKiBU
aGVyZSdzIGEgc2luZ2xlIE1TSS1YIE1NSU8gaGFuZGxlciB0aGF0IGRlYWxzIHdpdGggYm90aCBQ
QkENCj4+ICsgICAgICogYW5kIE1TSS1YIHRhYmxlcyBwZXIgZWFjaCBQQ0kgZGV2aWNlIGJlaW5n
IHBhc3NlZCB0aHJvdWdoLg0KPj4gKyAgICAgKiBNYXhpbXVtIG51bWJlciBvZiBlbXVsYXRlZCB2
aXJ0dWFsIGRldmljZXMgaXMgVlBDSV9NQVhfVklSVF9ERVYuDQo+PiArICAgICAqLw0KPj4gKyAg
ICBjb3VudCArPSBWUENJX01BWF9WSVJUX0RFVjsNCj4gWW91IGNvdWxkIGFsc28gdXNlIElTX0VO
QUJMRUQoQ09ORklHX0hBU19QQ0lfTVNJKSBzaW5jZQ0KPiBWUENJX01BWF9WSVJUX0RFViBpcyBk
ZWZpbmVkIHVuY29uZGl0aW9uYWxseS4NClllcywgd2lsbCB1c2UsIHRoYW5rIHlvdQ0KPg0KPiBU
aGFua3MsIFJvZ2VyLg0KVGhhbmsgeW91LA0KT2xla3NhbmRy


From xen-devel-bounces@lists.xenproject.org Wed Feb 02 14:18:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 14:18:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264233.457252 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFGSn-0002MW-SJ; Wed, 02 Feb 2022 14:18:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264233.457252; Wed, 02 Feb 2022 14:18:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFGSn-0002MP-OU; Wed, 02 Feb 2022 14:18:25 +0000
Received: by outflank-mailman (input) for mailman id 264233;
 Wed, 02 Feb 2022 14:18:24 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=6WyI=SR=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nFGSm-0002MJ-BX
 for xen-devel@lists.xenproject.org; Wed, 02 Feb 2022 14:18:24 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f955531b-8432-11ec-8eb8-a37418f5ba1a;
 Wed, 02 Feb 2022 15:18:23 +0100 (CET)
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2052.outbound.protection.outlook.com [104.47.2.52]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-11-znqRr157O0y87EEKSpY9SQ-1; Wed, 02 Feb 2022 15:18:19 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM6PR04MB4280.eurprd04.prod.outlook.com (2603:10a6:209:42::31)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Wed, 2 Feb
 2022 14:18:17 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.012; Wed, 2 Feb 2022
 14:18:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f955531b-8432-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1643811500;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Bq3Ul5blrR1MuEd2qetGcSMKyjnhTuROl6skuAmKufs=;
	b=DC4Xa7aoMJuFyHJlI7pZi0MLsuDsn0qcbafkTfvbJzkTu2v/CGC5kxRsHXYaA2f+89yeYY
	UMRJ0D/hgBSN9aR+JpojYSpvXXqfiIJh2+BGzlDOw5rz+4gqhO3TlgZ/T+QeQsP52kFhAF
	cQQ8hodC2FhrOlrmkblUJj1f2Gn16LY=
X-MC-Unique: znqRr157O0y87EEKSpY9SQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Ece+AvnxhSCp05wVxtXGEvRbraoA4R88z48dRArY/BNaJYk6jU6YgZRvs2/F50m0aFDEKUBX45QAfL5MZ4KkVvRXqX6bL5vV1+H2HlTA1GlWI+g+ttj4dHXGPJ9uy2WbXjIty0GgTQA/Jz8vj8SadkwimyEUg2W/w/YDfRSFcl1ED7PZl1rQYFt8pTpvaHbEh45jbijZnku8kPMZ62M3A4q94ERkRvHyN2x7GrC9d38EKKgSFrwMfJG5AYm2oXnKN5PEN25WSgTq6/fNnUO/VTL7HWIrYw76q89+Hp9LhS0UPzxgJTPvqzQjIZc6FR62RGMn0j8xGMk9kxyFIXnLYw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=bWENDfE9O1EWll9ieWo90xtr6HRhe66hQlUL2GIvXrs=;
 b=bmaWZw/y+hCuVOL1JtZnNCJPzy5ZS/RcnIANMcKxgfn5EHi2OLKlmfDhg6xTpwcj5RfTG9v21jv2rGH+iPV9w/ip5HFUnjYP3UvVbTW6tqcHd6pRwQepTDUdc1ATUmKedo+Xw2HyskEdUA12xgWYNx3xXwbC7BQXxY0qkM2oyCPaXS9GZDIwwrwmt45d++n3fVt8i4Hbg1WfvVntbrstYKsaKFUDyX9bNcdMSF1sCgkn02LXaVTkUbS6B/cp1/y29CtUhuS88LHumBnOJypLb4poA9kQWdDjrEK/OSZIb8t3h3Wd8dsx0aLEeycDChLC6KxSUOqK7uX3xVTjnDGqyA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <ab68568c-461e-bef5-4218-07db8e837bcc@suse.com>
Date: Wed, 2 Feb 2022 15:18:14 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v5 09/14] vpci/header: emulate PCI_COMMAND register for
 guests
Content-Language: en-US
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "julien@xen.org" <julien@xen.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Artem Mygaiev <Artem_Mygaiev@epam.com>,
 "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
 "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
 "paul@xen.org" <paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>
References: <20211125110251.2877218-1-andr2000@gmail.com>
 <20211125110251.2877218-10-andr2000@gmail.com>
 <YeAD9PH9o65o+M+w@Air-de-Roger>
 <6a31eb29-81b6-7553-897f-2e5e54bab9b8@epam.com>
 <d527740a-4d90-4155-13dc-5888e8acfa72@suse.com>
 <b9661d86-f084-9ad1-59d5-538113000393@epam.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <b9661d86-f084-9ad1-59d5-538113000393@epam.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS8PR04CA0081.eurprd04.prod.outlook.com
 (2603:10a6:20b:313::26) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c99d8298-602f-4ebe-010c-08d9e656db72
X-MS-TrafficTypeDiagnostic: AM6PR04MB4280:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB4280311DB6CE8C84E90906B5B3279@AM6PR04MB4280.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6790;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	uDAw3nJFTsjDX7bdAhhXROPtGY8bsnpXPxgihcWINgPfZny/EUFiXCgIhGZyXXtanpjfx/2+ko2OAnEMj0yzkIgr85AgK2eab55SOi21A/xFWo+kc9oT4mjUvqe9MFYlod+2MH2dW3HEKiMpDjL3xoUFtj8vRFsk0jb4Pg9IW0dE7f+OgbSL021k7qdPm1e+T5SazOutWG7swD6fWFOEU5y3twwmIqouch3eTLhw11vGVg4F0r/qqsoRTwDMkG9RPJvIN+VHA9ORTD2T6dL6GN0SDkMl1Ztf1GhRLyOwsJIrmpblolF5//k7Y/ZjjY4NGme1m4PFe75kWA6g6o9+txVmKUMqfaHbPvn1zGRE02c4Evviur+M0/UpImVUFHd2WqcS4fBCrUCzFLdSVa9sNtsZ6RrJJ4KbTuM+KjlRnsEznmvfXRiBERyLXeW1m6ET4dpPQsbeDBrVSLl/MuHOl1eWYvaEqxd9lZPAbZGoeBgacSiyK73UaUsCpmn2WG69Y4l0ky84cEDZ4UIZUpXhnrEucReJ0VD7PvH7madPi9j8BIqBjq3a1OlA2G1MmTybipkn8iK4Q2dnO75A+HmLKUxZ9v5nO3jLmrQqNCsYaSztZYwGsEbHm1gYVd/8i+9sBfzu+Hs142KA/ibQZq+BOZ44GGlsgmJfC1FIDUWXjUaLJ7pGReYkh0iN5ltamiDHZRHQZ2qOPSRPaNIgjs9GBVqgO4HhNGkwiG2MmgjrXCE=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(5660300002)(186003)(31696002)(53546011)(6916009)(2616005)(26005)(86362001)(6486002)(54906003)(316002)(8676002)(6506007)(4326008)(6512007)(6666004)(66946007)(8936002)(508600001)(66476007)(66556008)(2906002)(7416002)(36756003)(31686004)(83380400001)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?FWUKtgCuCoxvLihKIWuCduyS19lgwBsCxv9xg7PfQ4NRDyED1NuIWl1vQ+My?=
 =?us-ascii?Q?rw9VjbZ9bgM0vBVKAq2kpyNbK9FlUqh88lsTNoHX2B5t1eJjSNmzBeDmh3CP?=
 =?us-ascii?Q?f70Xzhxpxk+wE7z+gq8aX46VFHw+DrwLp4v3hMKiyBzUqKGsKpmWHMIjVNX8?=
 =?us-ascii?Q?34t+cJAuzwWT8H60/Mv8cWuFECuvXM/YS8lhfguqzkLeENoIgtaLv5oAYwP2?=
 =?us-ascii?Q?X7IFs926xTFQUnLzVTyWr/cB8OGNGvZsEpxn8Me8i149uB+zDi7+/1uHeKWu?=
 =?us-ascii?Q?Ca3OiApQZh4SOX52JJ1F6NZgkJbYw1vGPPm7PLEPB3BVOhn8Zaw5XZCmo/IR?=
 =?us-ascii?Q?/KtMQ8rU8ENizZlGqAgML7o8IzgC2Fp3L2gtpJjFdKRAs/IiWQ3Yewats/ES?=
 =?us-ascii?Q?I1gDUqI9VHczHG1FFMoqygcY9EPqIPojdISUF602HMAcywcOWy0x+FKKY5QE?=
 =?us-ascii?Q?ExefNo/EnuDE3hYcLzxbSA1bKcIkIgFyZM6xI3cvzXnzx38lTHHYkcWz2gXz?=
 =?us-ascii?Q?0bf3djjz4igX9XYSHXJZn+icqSiFreyl5gMUwLNs0WRiyNQkI5PxTT8nuCb2?=
 =?us-ascii?Q?GyEL/dVTuofO84KmNysH8mQs8YEKbRSs2itxFNry/gfPADhGV7dUeF9WEQCh?=
 =?us-ascii?Q?qmWAbSxMfsN7ebvPgddQoy9gzW75o0Vqo5O3kkQlhRsjAwe7W1S4ZPc0DdL9?=
 =?us-ascii?Q?7rhsdEhklOHS8vcgMTUy+E7eZBEgBZFG5tKcsKG87HtlZ1GwEZJVAa6DB2EI?=
 =?us-ascii?Q?1beOBUdpTHrruP6aNw7pFn6pIkwn7rbt1ipMtwUPl3gCGHNOo3LoO0Ja+wn0?=
 =?us-ascii?Q?zGkqk8l7kaw36s0Qp7HbUyHLpJ21bEnOhun1cuP5Rn2W857gElJUKJVZwqcq?=
 =?us-ascii?Q?Fc6DIVnOL68lR/5Jhb6z6p6Ai64dJn16xwvJVgUlZFwCPhE+boYWZSRc2UoM?=
 =?us-ascii?Q?HqVXW7UWUEyFvz9Es8vNrxUcZ/grtO2PWFt/XYJupgn2y+Iwug3xY6VOq0LH?=
 =?us-ascii?Q?nFybTrm+mHIOzozmYxFIOqtien9qmf4auDgZyysc82N4ReZHUS+gVxiyxJkv?=
 =?us-ascii?Q?GOj3OTODf12J7it9ZhNhMLS95AX0cNSYkRK8OJYlUMHigrEn/xhwCugvuYK8?=
 =?us-ascii?Q?Vj3Vqp66gFc7KhtEXFi8ttVV8pr6xJYg77pFCGjuYOlC0CjiZ1ny2H6Mf1AG?=
 =?us-ascii?Q?hGgaGm+KTUjXsAx9lzzYWe6mPok5/+heSBMAeiqm4ykqMEuk+CmYV9hhcp38?=
 =?us-ascii?Q?4xPStDahPbzbFPRziVvx4iCE7VqMSlqTVxWc3r05X/2gCrDCGo2mij9zljv5?=
 =?us-ascii?Q?j3oyaCfdjIV7ZiMCYJ8zwrWwjh3Fd1mTF6dcC2x7JBCwkyBJWQRTYdi5ybfy?=
 =?us-ascii?Q?s0qZnSgFccMWxsL4UHnnCle+qu7eITDti6wP6h3tHjUk8OI01A5CIjev+ioU?=
 =?us-ascii?Q?xlwsGufJuo1RYkeJwv8P6u3OOJJx90+xSsq9YMvDiINUP9bmdEDdaHc/2FRV?=
 =?us-ascii?Q?jdV4bzI7XOIY2jJMbce9OuaCZRQchouvfNTPXLduYhRgMy6Hudayeda333fq?=
 =?us-ascii?Q?3heCP5juVImeYXSaDy0BgyH9z+ue7Wb6kyLilAaD+VxffcuyndZaYHI6SNTg?=
 =?us-ascii?Q?mE8ShdL7b1nGCIHQPrGqV30=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c99d8298-602f-4ebe-010c-08d9e656db72
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2022 14:18:17.4612
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Noyjxh9q9pOb8IOYacsGMVK2lnEcyYPg/rj/PHwPnH+ZZSGiYlSNoM72rwCXyJGrnVLFjrba/J25rwewsAg+bw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4280

On 02.02.2022 14:47, Oleksandr Andrushchenko wrote:
>> On 02.02.2022 13:49, Oleksandr Andrushchenko wrote:
>>> On 13.01.22 12:50, Roger Pau Monn=C3=A9 wrote:
>>>> On Thu, Nov 25, 2021 at 01:02:46PM +0200, Oleksandr Andrushchenko wrot=
e:
>>>>> --- a/xen/drivers/vpci/header.c
>>>>> +++ b/xen/drivers/vpci/header.c
>>>>> @@ -491,6 +491,22 @@ static void cmd_write(const struct pci_dev *pdev=
, unsigned int reg,
>>>>>            pci_conf_write16(pdev->sbdf, reg, cmd);
>>>>>    }
>>>>>   =20
>>>>> +static void guest_cmd_write(const struct pci_dev *pdev, unsigned int=
 reg,
>>>>> +                            uint32_t cmd, void *data)
>>>>> +{
>>>>> +    /* TODO: Add proper emulation for all bits of the command regist=
er. */
>>>>> +
>>>>> +#ifdef CONFIG_HAS_PCI_MSI
>>>>> +    if ( pdev->vpci->msi->enabled )
>>>> You need to check for MSI-X also, pdev->vpci->msix->enabled.
>>> Indeed, thank you
>>>>> +    {
>>>>> +        /* Guest wants to enable INTx. It can't be enabled if MSI/MS=
I-X enabled. */
>>>>> +        cmd |=3D PCI_COMMAND_INTX_DISABLE;
>>>> You will also need to make sure PCI_COMMAND_INTX_DISABLE is set in the
>>>> command register when attempting to enable MSI or MSIX capabilities.
>>> Isn't it enough that we just check above if MSI/MSI-X enabled then make
>>> sure INTX disabled? I am not following you here on what else needs to
>>> be done.
>> No, you need to deal with the potentially bad combination on both
>> paths - command register writes (here) and MSI/MSI-X control register
>> writes (which is what Roger points you at). I would like to suggest
>> to consider simply forcing INTX_DISABLE on behind the guest's back
>> for those other two paths.
> Do you suggest that we need to have some code which will
> write PCI_COMMAND while we write MSI/MSI-X control register
> for that kind of consistency? E.g. control register handler will
> need to write to PCI_COMMAND and go through emulation for
> guests?

Either check or write, yes. Since you're setting the bit here behind
the guest's back, setting it on the other paths as well would only
look consistent to me.

> If so, why didn't we have that before?

Because we assume Dom0 to be behaving itself.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Feb 02 14:26:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 14:26:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264240.457262 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFGam-0003lF-MV; Wed, 02 Feb 2022 14:26:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264240.457262; Wed, 02 Feb 2022 14:26:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFGam-0003l8-JS; Wed, 02 Feb 2022 14:26:40 +0000
Received: by outflank-mailman (input) for mailman id 264240;
 Wed, 02 Feb 2022 14:26:40 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1p3Q=SR=epam.com=prvs=40324c57ab=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nFGam-0003kz-03
 for xen-devel@lists.xenproject.org; Wed, 02 Feb 2022 14:26:40 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 219286d1-8434-11ec-8eb8-a37418f5ba1a;
 Wed, 02 Feb 2022 15:26:38 +0100 (CET)
Received: from pps.filterd (m0174681.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 212EPgO5007516;
 Wed, 2 Feb 2022 14:26:33 GMT
Received: from eur04-he1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2058.outbound.protection.outlook.com [104.47.13.58])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3dyu8f06ha-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 02 Feb 2022 14:26:32 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM6PR03MB4472.eurprd03.prod.outlook.com (2603:10a6:20b:7::31) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.22; Wed, 2 Feb
 2022 14:26:28 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6%3]) with mapi id 15.20.4951.012; Wed, 2 Feb 2022
 14:26:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 219286d1-8434-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gBRNT6xorAXLxlhuA+daPF0dGeVxmTXjyzMoW3F4iQhtS78EfBcMO0HgyE3xmMwemE+AdH7lHAY9R6izVNoD9a/qjkFQjCDcdHT0HU395sItrrVQVIewbicVJ+bLUgfIKF1TEDm91DDEIfO2K7rwlMoWPtZG6K4dPniSbhFxWLBKJqZfN8QA1b81/XNClgrOiQmijRpZWE4sa1qLgJQJkZ1ctahU1ScdWRBWrWpMZJSiammYNBXBuj6EtJ8MlmmQK2kbQBVItwgGPtVfP3FnLz6ESDKKNjpbMlc3LCKbEX0lOJyweBXhY6feF99aakgnGMN50bzmH1lMrHo2ESWYZA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=z/X+1QhiN0fdyjex7rVdhD1GO2tIRkk5nPQlaePxIvQ=;
 b=bmKHQA4heBAHSgZLswkNAlKwSBN4IoqF4I4xrz6Evb2kT975h5mtFo2L4RYdJ/I/0gPyvtFOYrqHsXmX05UYHwQbKc7xD++B5dcoB4g6MKqizf+i+/HtrucX+k8vY/Cggk7Sfg5moyc5BArWenzPPg806kQbiNg07SkNMIHwgPpjon0kG+Jl3qB18FtIFoCAYWrinYlQ9NJ733ig2xqi6/xVIJWjoxI0Viqm8auOSauMssTQZs9XjalP6OeGsanns0gzRySqgcfjj6JTgp6qO/h4XIQspDnSjJS95GTrxDgNJu9I6EZia4eGpvP80Zji44gg7cgj2bjjiIqB4eVEUQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=z/X+1QhiN0fdyjex7rVdhD1GO2tIRkk5nPQlaePxIvQ=;
 b=jfYkx7FkizDQcFJBbpV7eb+0LbNSegMQJ2VEzHMxB1nFbpLWgKRmSgEXxPOOSdHccrx6sUNHpM+ApQm72BULi3D2G9PLilwSldsafT1jcM8v/0mPiYpERWlEtsBRlJTgWCBYndTRZDWG9yEvFl/KlcX+ezdXVx5QOESDlq7FQBAmmdLZd+iZeCtTikzOBJQGq2YopX9aYg89QbZiv8NTjeq2syAx1nm/H7K3LT+zPTt7EWUr+aijIDihb96kEhAFYuwRXYaOYAa8sDVzsWCrCSvkrIVaynr7AIevSsiJV1jD16M3poyU2uhm8MTpzj+w43l4lZyKkcYGgc3x7SVV/A==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?=
	<roger.pau@citrix.com>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v5 09/14] vpci/header: emulate PCI_COMMAND register for
 guests
Thread-Topic: [PATCH v5 09/14] vpci/header: emulate PCI_COMMAND register for
 guests
Thread-Index: 
 AQHX4ewK3mPSKCsK30iVfRQpWoVIB6xhEugAgB+P6YCAAAvvAIAABD6AgAAIlwCAAAJMgA==
Date: Wed, 2 Feb 2022 14:26:28 +0000
Message-ID: <37313b25-ccbe-fbfd-8306-7a96ce83c818@epam.com>
References: <20211125110251.2877218-1-andr2000@gmail.com>
 <20211125110251.2877218-10-andr2000@gmail.com>
 <YeAD9PH9o65o+M+w@Air-de-Roger>
 <6a31eb29-81b6-7553-897f-2e5e54bab9b8@epam.com>
 <d527740a-4d90-4155-13dc-5888e8acfa72@suse.com>
 <b9661d86-f084-9ad1-59d5-538113000393@epam.com>
 <ab68568c-461e-bef5-4218-07db8e837bcc@suse.com>
In-Reply-To: <ab68568c-461e-bef5-4218-07db8e837bcc@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: b39e1197-5dda-4f2e-fcc5-08d9e6580044
x-ms-traffictypediagnostic: AM6PR03MB4472:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM6PR03MB44727709E8D0104E213017EAE7279@AM6PR03MB4472.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8882;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 qoqsXE3+izKsKWWCjTalywr7Cx+SF6PTRVEUKZ7nK4krTjskyiTIwwIXww9It7IWeJwQVgFCS3LsGNe7VjPCV7fusZwrxW6SuqS7a8M26AwlMi0BrZZjAYS/O7L3QgdK+w2zgoJ3iFaedFb6gxZkRQyZffniYGUg56j7SPf1oa1AiMqoDS1YtjKUBJS0i5I+dVO5sDMCV8Xs+yQ/AGPT3W2NUZMIuLtya/XZzfvZfh2IkhMPwsSTgrkWStp/ho3h4gOtjaj8bqPm+qIgtV5zsc+CcbZ4MWulptK9lwXpUX6nrgFn+GO2gC5zl4+O48UXfPDL+u+nMNB9lttXRI7VSeo7oDPf8Tc7yPgPG7VyzgkaYDXvv/s4cHf763AopuG5nJrhT8gKOeB15dlbSQnxRe6MEePSR8R8Pc6tTXDdz9/DrDQJXeicGEpoSdLgAdc+v8QldYOkwSP2IR4yyAGIU1Kh1KS9R+MTvDyM/6lZFAPexw/UYt4ahJk9iLFvClJDbU1VFEHL1su91c0TvqjUbrCneOc6LjBY8PxyE5X/zxR500m6lvboOfczdcyRc2Ta5O+FEirCxNB2PRGCFK58y8PBbVn40hnOxhgoyw76FyKengY7UN/IP5yHcucNazjC7iA7uLSMmlgjnd40VXnXK3iREqNF2nfwjS7/400mM1QBeqEuKltmNZCDExn2g17o2lBs14R0ITKaob5rO/RKnUv+rQhnA3oQKBPCnueyo8CDQ4O9u5w4rLgOoRYJscyo
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66556008)(76116006)(4326008)(8936002)(8676002)(26005)(6486002)(64756008)(186003)(54906003)(66946007)(66476007)(2616005)(86362001)(2906002)(91956017)(31696002)(6916009)(66446008)(107886003)(53546011)(508600001)(71200400001)(316002)(7416002)(6506007)(6512007)(36756003)(122000001)(31686004)(83380400001)(5660300002)(38100700002)(38070700005)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?SWZZYkZmcXVmNi9vZ0wyZ250aGJrWGptcXhnVEFRUjBlclhKU1NTd2xrZDVI?=
 =?utf-8?B?ak9MY0piM0kwQTlWMG5hS01UR3ozUGw0OXpyZlpBWlgwZStKR3BRZGxia1R4?=
 =?utf-8?B?cWRSaDZwaENYNFh5QlFId1h2RFFudS9xbnJvcnBybEY2YTd4dDFreHh1RWV3?=
 =?utf-8?B?VjNkR1BiQmM5OWQ1clozVXpCaGp5RUNGaHoxN2JBWXM1R3UrQnJXeGUrYmNU?=
 =?utf-8?B?aUs0TnJCV2pqOWlwcnNxUlVGekNSQnlTbmdDK0tITFVJYW5IN3NZeEQ0NTB5?=
 =?utf-8?B?bnFSWFJRY0lyb0dSd0ZFVERNU0JEZ1p0cnFVSkVuS29Na3ZYb0c2TTEwVVA2?=
 =?utf-8?B?Z015Q3gwdnVPRzNzQjVaY0xBLy9TVTAvV3NVcGFhYnNxR1NUOG5PZllqckJO?=
 =?utf-8?B?YkRHL3pKbU1VeGo0czlQN0dwMnJ3YW9oNnVFaDUrUjV2N3hVcUZBZEs2d0lH?=
 =?utf-8?B?VXJTd2FWdFlGekpHMjZ2aUVkVUE3VXNlYUQ2bUJjZWJpbWRLT2dkWEh3TGRu?=
 =?utf-8?B?NkEzK3k0WVk0UnpQRE53Y3BkSm04cVJBZnhDT2xuWUNKYVA0d0crS3pMZjl3?=
 =?utf-8?B?d0RwSTZuVWNna3g5Um93cm10QXd5VjhKMEVjdmxuaDFFTC9XVFVUMUp0UTM2?=
 =?utf-8?B?VGh2VzBKUVdHUENqWUFQL1N3dFNTY3pxa0FLUGd1eDExWmh0am43UnliRWlC?=
 =?utf-8?B?ZXhhSmdtUkFpRzVaaGJxNFFmYnNXSlhQTnltTEpMUjRTMWRpWGIyeHViZTFQ?=
 =?utf-8?B?a2lTVkJJUlhZV3UxcncyN1d1YllvY1QvTGRFd1c4ajYwUmIxdGQrWDVIMWps?=
 =?utf-8?B?YlQwRDlpcU1iOXl1aXZ0cUpRcWRBRlY4SFNvd1NmYTA2WlhXKzJMckc4UEp4?=
 =?utf-8?B?SGFjYWdXYmU0alU3c1JrNlBoLzZ2c3ZEREV6QXdmU2VVc1dFWHFSb1VORm5Z?=
 =?utf-8?B?ejFLWXBQOGRrZ0FZN3NpQmZWejBlVXVZeUllOTdic2w2UlBrNVRzMlVxK0FU?=
 =?utf-8?B?N0NuRHJNZkNFZlJUc3Buckd4RXhKYkc2cC9FdDBxMHkwbTMzc1k5alVVbVJj?=
 =?utf-8?B?bisyUTN1VmN2Tm1WMjJFVjUvQUhHZnFPUFBrZitBMSs1MHk2NWRObnhlZGdP?=
 =?utf-8?B?UDVSa204K0JTWko2UlEzWWxDU3djZjNVZStmQ1dqa0JRUTgzUGFnWW92czdM?=
 =?utf-8?B?S3NYWURiWkJvRG1SbmFGb1o3OEUvNEh3blJHcHVqT3lUbkQ0Q3pIdk1NTDc3?=
 =?utf-8?B?ZVB3cHVKT1RaZU55cjBsVWlyeEx1d25qdkliY3ZLRm9McWM1MDZ6Q1pmc01w?=
 =?utf-8?B?OXcvS0w1NFNCV3lmT2pTcG9WN01iT3F1c0R2VmpHS0I3T3JiQTIwQ3YwNUtD?=
 =?utf-8?B?dFB1UjZCVWdFOHJXVkhRMEFZQk1sUmRBTlZmYWVzWStuMkJ2aGZsY3B1SU9s?=
 =?utf-8?B?WGxPdHNmQzRmQmlnbzN3KytMMnEzNzlsY3gvSDhFc2JoZ1lXSGhVNXQxMExD?=
 =?utf-8?B?RUt1NzIrcm9wT1NNWGtBa2RXNnVuMnVaZDVtVVEybk80VmhQeUR6QnFNNG5u?=
 =?utf-8?B?MWxOdUdsSmVWaUtIdDBlZnIzanR2V0JjS0ZZaURUeXU5cDN3MXpDUXBTalA1?=
 =?utf-8?B?eTVzMkNpalVhVFdrS3RjZlg2UXRQYXBzaTZLOTJLamJBWjB5Y0lRSlkyVFov?=
 =?utf-8?B?WE8yTTBQczlBVHJFalpQblBTQ3V4NlNReHhtY1BQQ2swNTNmdjZNRTJBb0lx?=
 =?utf-8?B?dGJ0ODJuU0VaT015amZYUVRoYkNxNHd1RlJMKzB6TGx1bWh1SE5ab1lrZC9E?=
 =?utf-8?B?RXJ4Uk5WWUtEKzV3QnVxTWkwczRCMWlJbm16KzArVTNOZC9majBiTkxJb2o5?=
 =?utf-8?B?SGVJNDFhYWwwTUtBRmFiU2FCbnFra2xHUVZTeUl1ME43WkR6UWZoUUtTRlA5?=
 =?utf-8?B?Q2VVc1lwOG9EQ1lCOGZQd0UwNE1GQ1FIQ2ZncE5qVXNaOUV2Sk5zRm5wY1N5?=
 =?utf-8?B?azZtMzZ4dHoxMEhINHdBZXkwQklmTTNCN09TZlI2UllNd0wyZVJtR3lSWVhm?=
 =?utf-8?B?VjljMlZkdkhIUHhxY2RkNTBCS2dOc0lsOWxncnRmVTdKQWh2SHhxS3pERU15?=
 =?utf-8?B?eStJNDNIL05NVERPQ1N0QUZPNVVSU3RCd3JkaVVxbjZ5ZDA0RFlQbWlpVW14?=
 =?utf-8?B?ZXQyVU52R01vNysrT2k1STlCcmhPbjVWMklkZFNRMlpXdE5kZTdHVjg4M29p?=
 =?utf-8?B?S1pSL24vaVZuaHhSV0g3MUtRSVl1YXY0VzljekZpR3JkTmV0VDVSYmIxcE1j?=
 =?utf-8?B?USs1OTdrY3F1QVZkOUsyQW1rL3dMS0U2UmNRRlJ3M2VBbVBTK0lsZz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <294577FC709F0B448A282BE835E64043@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b39e1197-5dda-4f2e-fcc5-08d9e6580044
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Feb 2022 14:26:28.4730
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: btw2DWS83V9EiG6J38y8hIU26FjH/C2b7A4N5KjPIvuLlg+tvJHWJn6CFz4k6/bLdyOx64Da3RXFjLCwiVV+7cepTUp0yKKudrAvGQvZxFise3KrlIlTCVQcCUNkKazf
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR03MB4472
X-Proofpoint-GUID: ybQD3JNRZHLoIJUCV91O9oNqpInG41mE
X-Proofpoint-ORIG-GUID: ybQD3JNRZHLoIJUCV91O9oNqpInG41mE
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-02_07,2022-02-01_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 adultscore=0
 priorityscore=1501 bulkscore=0 lowpriorityscore=0 suspectscore=0
 malwarescore=0 mlxlogscore=941 impostorscore=0 phishscore=0 spamscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202020079

DQoNCk9uIDAyLjAyLjIyIDE2OjE4LCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMDIuMDIuMjAy
MiAxNDo0NywgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+Pj4gT24gMDIuMDIuMjAy
MiAxMzo0OSwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+Pj4+IE9uIDEzLjAxLjIy
IDEyOjUwLCBSb2dlciBQYXUgTW9ubsOpIHdyb3RlOg0KPj4+Pj4gT24gVGh1LCBOb3YgMjUsIDIw
MjEgYXQgMDE6MDI6NDZQTSArMDIwMCwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+
Pj4+Pj4gLS0tIGEveGVuL2RyaXZlcnMvdnBjaS9oZWFkZXIuYw0KPj4+Pj4+ICsrKyBiL3hlbi9k
cml2ZXJzL3ZwY2kvaGVhZGVyLmMNCj4+Pj4+PiBAQCAtNDkxLDYgKzQ5MSwyMiBAQCBzdGF0aWMg
dm9pZCBjbWRfd3JpdGUoY29uc3Qgc3RydWN0IHBjaV9kZXYgKnBkZXYsIHVuc2lnbmVkIGludCBy
ZWcsDQo+Pj4+Pj4gICAgICAgICAgICAgcGNpX2NvbmZfd3JpdGUxNihwZGV2LT5zYmRmLCByZWcs
IGNtZCk7DQo+Pj4+Pj4gICAgIH0NCj4+Pj4+PiAgICAgDQo+Pj4+Pj4gK3N0YXRpYyB2b2lkIGd1
ZXN0X2NtZF93cml0ZShjb25zdCBzdHJ1Y3QgcGNpX2RldiAqcGRldiwgdW5zaWduZWQgaW50IHJl
ZywNCj4+Pj4+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVpbnQzMl90IGNtZCwgdm9p
ZCAqZGF0YSkNCj4+Pj4+PiArew0KPj4+Pj4+ICsgICAgLyogVE9ETzogQWRkIHByb3BlciBlbXVs
YXRpb24gZm9yIGFsbCBiaXRzIG9mIHRoZSBjb21tYW5kIHJlZ2lzdGVyLiAqLw0KPj4+Pj4+ICsN
Cj4+Pj4+PiArI2lmZGVmIENPTkZJR19IQVNfUENJX01TSQ0KPj4+Pj4+ICsgICAgaWYgKCBwZGV2
LT52cGNpLT5tc2ktPmVuYWJsZWQgKQ0KPj4+Pj4gWW91IG5lZWQgdG8gY2hlY2sgZm9yIE1TSS1Y
IGFsc28sIHBkZXYtPnZwY2ktPm1zaXgtPmVuYWJsZWQuDQo+Pj4+IEluZGVlZCwgdGhhbmsgeW91
DQo+Pj4+Pj4gKyAgICB7DQo+Pj4+Pj4gKyAgICAgICAgLyogR3Vlc3Qgd2FudHMgdG8gZW5hYmxl
IElOVHguIEl0IGNhbid0IGJlIGVuYWJsZWQgaWYgTVNJL01TSS1YIGVuYWJsZWQuICovDQo+Pj4+
Pj4gKyAgICAgICAgY21kIHw9IFBDSV9DT01NQU5EX0lOVFhfRElTQUJMRTsNCj4+Pj4+IFlvdSB3
aWxsIGFsc28gbmVlZCB0byBtYWtlIHN1cmUgUENJX0NPTU1BTkRfSU5UWF9ESVNBQkxFIGlzIHNl
dCBpbiB0aGUNCj4+Pj4+IGNvbW1hbmQgcmVnaXN0ZXIgd2hlbiBhdHRlbXB0aW5nIHRvIGVuYWJs
ZSBNU0kgb3IgTVNJWCBjYXBhYmlsaXRpZXMuDQo+Pj4+IElzbid0IGl0IGVub3VnaCB0aGF0IHdl
IGp1c3QgY2hlY2sgYWJvdmUgaWYgTVNJL01TSS1YIGVuYWJsZWQgdGhlbiBtYWtlDQo+Pj4+IHN1
cmUgSU5UWCBkaXNhYmxlZD8gSSBhbSBub3QgZm9sbG93aW5nIHlvdSBoZXJlIG9uIHdoYXQgZWxz
ZSBuZWVkcyB0bw0KPj4+PiBiZSBkb25lLg0KPj4+IE5vLCB5b3UgbmVlZCB0byBkZWFsIHdpdGgg
dGhlIHBvdGVudGlhbGx5IGJhZCBjb21iaW5hdGlvbiBvbiBib3RoDQo+Pj4gcGF0aHMgLSBjb21t
YW5kIHJlZ2lzdGVyIHdyaXRlcyAoaGVyZSkgYW5kIE1TSS9NU0ktWCBjb250cm9sIHJlZ2lzdGVy
DQo+Pj4gd3JpdGVzICh3aGljaCBpcyB3aGF0IFJvZ2VyIHBvaW50cyB5b3UgYXQpLiBJIHdvdWxk
IGxpa2UgdG8gc3VnZ2VzdA0KPj4+IHRvIGNvbnNpZGVyIHNpbXBseSBmb3JjaW5nIElOVFhfRElT
QUJMRSBvbiBiZWhpbmQgdGhlIGd1ZXN0J3MgYmFjaw0KPj4+IGZvciB0aG9zZSBvdGhlciB0d28g
cGF0aHMuDQo+PiBEbyB5b3Ugc3VnZ2VzdCB0aGF0IHdlIG5lZWQgdG8gaGF2ZSBzb21lIGNvZGUg
d2hpY2ggd2lsbA0KPj4gd3JpdGUgUENJX0NPTU1BTkQgd2hpbGUgd2Ugd3JpdGUgTVNJL01TSS1Y
IGNvbnRyb2wgcmVnaXN0ZXINCj4+IGZvciB0aGF0IGtpbmQgb2YgY29uc2lzdGVuY3k/IEUuZy4g
Y29udHJvbCByZWdpc3RlciBoYW5kbGVyIHdpbGwNCj4+IG5lZWQgdG8gd3JpdGUgdG8gUENJX0NP
TU1BTkQgYW5kIGdvIHRocm91Z2ggZW11bGF0aW9uIGZvcg0KPj4gZ3Vlc3RzPw0KPiBFaXRoZXIg
Y2hlY2sgb3Igd3JpdGUsIHllcy4gU2luY2UgeW91J3JlIHNldHRpbmcgdGhlIGJpdCBoZXJlIGJl
aGluZA0KPiB0aGUgZ3Vlc3QncyBiYWNrLCBzZXR0aW5nIGl0IG9uIHRoZSBvdGhlciBwYXRocyBh
cyB3ZWxsIHdvdWxkIG9ubHkNCj4gbG9vayBjb25zaXN0ZW50IHRvIG1lLg0KSSBjYW4ndCBmaW5k
IGFueSBhY2Nlc3MgdG8gUENJX0NPTU1BTkQgcmVnaXN0ZXIgZnJvbSB2TVNJL3ZNU0ktWA0KY29k
ZSwgc28gd2hhdCdzIHRoZSBjb25jZXJuPyBUaGlzIHNlZW1zIHRvIGJlIHRoZSBvbmx5IHBsYWNl
IGluIHZQQ0kNCndoaWNoIHRvdWNoZXMgUENJX0NPTU1BTkQgcmVnaXN0ZXIuDQo+DQo+PiBJZiBz
bywgd2h5IGRpZG4ndCB3ZSBoYXZlIHRoYXQgYmVmb3JlPw0KPiBCZWNhdXNlIHdlIGFzc3VtZSBE
b20wIHRvIGJlIGJlaGF2aW5nIGl0c2VsZi4NCm9rLi4uDQo+DQo+IEphbg0KPg0KVGhhbmsgeW91
LA0KT2xla3NhbmRy


From xen-devel-bounces@lists.xenproject.org Wed Feb 02 14:27:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 14:27:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264245.457273 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFGbu-0004MI-0a; Wed, 02 Feb 2022 14:27:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264245.457273; Wed, 02 Feb 2022 14:27:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFGbt-0004MB-To; Wed, 02 Feb 2022 14:27:49 +0000
Received: by outflank-mailman (input) for mailman id 264245;
 Wed, 02 Feb 2022 14:27:48 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Xpw6=SR=oracle.com=boris.ostrovsky@srs-se1.protection.inumbo.net>)
 id 1nFGbs-0004Lz-95
 for xen-devel@lists.xenproject.org; Wed, 02 Feb 2022 14:27:48 +0000
Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com
 [205.220.165.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 495b96cd-8434-11ec-8eb8-a37418f5ba1a;
 Wed, 02 Feb 2022 15:27:45 +0100 (CET)
Received: from pps.filterd (m0246627.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 212DTRvZ008544; 
 Wed, 2 Feb 2022 14:27:44 GMT
Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80])
 by mx0b-00069f02.pphosted.com with ESMTP id 3dxjatx9ks-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Wed, 02 Feb 2022 14:27:43 +0000
Received: from pps.filterd (userp3030.oracle.com [127.0.0.1])
 by userp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 212EFRSp020343;
 Wed, 2 Feb 2022 14:27:42 GMT
Received: from nam11-co1-obe.outbound.protection.outlook.com
 (mail-co1nam11lp2174.outbound.protection.outlook.com [104.47.56.174])
 by userp3030.oracle.com with ESMTP id 3dvtq2qsmc-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Wed, 02 Feb 2022 14:27:42 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10)
 by BLAPR10MB5089.namprd10.prod.outlook.com (2603:10b6:208:330::5)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.11; Wed, 2 Feb
 2022 14:27:40 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::d914:c494:66ac:a5b1]) by BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::d914:c494:66ac:a5b1%7]) with mapi id 15.20.4951.012; Wed, 2 Feb 2022
 14:27:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 495b96cd-8434-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date :
 subject : to : cc : references : from : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2021-07-09;
 bh=Tx+QcyU2eQsx0hhVOn9OV1f95Rvuz1MJe7mrx1LcNw4=;
 b=IKrSyC3jwyHKTjtFGr+fUVKIYV7EsRWNocj9mWM+fFZvCSs73VH+WYZj1KirIhOFBfYs
 SGd9RAtLp8R0iDHGmsNZpA0TDcwdG53LgSY7VA351BN+DxF8l/JhD9PL/SDu+CkFOl/l
 fG7FkdQ1KgL4ilgM4CG4Ap7FfZR9I/OUjFHnsySAxeyzGYjnkgaKMs1LAeAnskWcjMOD
 sLIQjPk8cNQHNOEemcYwjJ2s3yGiBSezXukgWDke+U2j2WhxM3oemdmtpHIAfQmbvuTV
 TvAkdBfsIPU5k2XLRECma1iB4Nt7Iyh0XO6NAhyVp48SqoQbL11eszgoRKFSi168FFCI TA== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=biBCqjUv6RJXHRxQuGoVnXOhs/dSvkQxGO29g/nWzFzSyjxf3CRBk9U2EtLA7RC807+k3jHuTwVIVNXjdiP//cbPVGLy2+iyGD72iCKokSjTZZ1AWvgjAxqv9Sr8wbcOc1x3s4yNrlsCvapEVKIQX9JTzJng8NY+C70RGYoDkMo/slD5Qo6SwqXoratSL+lGH9LoCj8TrtjTkwHkMdn/jS24avNplh1yd98xvGKOCceFT62UC4qAXEWhqwHThIMvxLeOZCQGp8kXqYSTeJj2VZNC84rZJ5uAIMJssG1lWBzg4Ef9EAuIJrIVJcM2fKaDG06KijN1Kbvbt11KstGj4A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Tx+QcyU2eQsx0hhVOn9OV1f95Rvuz1MJe7mrx1LcNw4=;
 b=kQ2HwD1cqdz7Ow4T82KLDEt0raXopISR1SmJcvb+GbBZLRM+qE4fJaBu2cWULgKHZs+OLqxLT1LbMexIge9DCIzrU5Kme0st3GoZdB6EVdnv7Ge0s/0RDSwqabbRThITAMK4r1cs/ZQhmOQadeVwLFWaMXASmZXfFNEEKhW1W2iK/zqpetONgYlhKfqh4dlyyb+3wDxyBrcZLLwmH7d1jOBFWTbXuHYSz8RaFzJbz8EbR73Gi6+R84wuf5C3OHsy8bw89WclEGHIXpVbZJ5pkOdgPMFu+HB9FEx0iN5DMb9TUNNUlcZwTxY1F0Tp6XY0jedA9CxMKZIUI5YbomEQhQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Tx+QcyU2eQsx0hhVOn9OV1f95Rvuz1MJe7mrx1LcNw4=;
 b=XhsTwVgtEJ+fKKS7R+o3Lni3/Q/c4RurNKTxYnjj6vww+tGNbkSKGpFTqNO1DVEGfkW1t96VaW965EfvicIV1Zf28Zt2RCJBxhvEGS8Tb3SDQwrUunGP0wddnshhxztFnYBU6WxbKo2v2MonNnUJu1dDReaK8pOor/AwSUc4fik=
Message-ID: <bba4b96b-2d0c-6fe6-4580-2b62f0d635bc@oracle.com>
Date: Wed, 2 Feb 2022 09:27:36 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.1
Subject: Re: [PATCH] x86/Xen: streamline (and fix) PV CPU enumeration
Content-Language: en-US
To: Jan Beulich <jbeulich@suse.com>, Juergen Gross <jgross@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <2dbd5f0a-9859-ca2d-085e-a02f7166c610@suse.com>
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <2dbd5f0a-9859-ca2d-085e-a02f7166c610@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: SN2PR01CA0058.prod.exchangelabs.com (2603:10b6:800::26) To
 BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e495548c-05df-4db1-4fec-08d9e6582aee
X-MS-TrafficTypeDiagnostic: BLAPR10MB5089:EE_
X-Microsoft-Antispam-PRVS: 
	<BLAPR10MB5089F567E191C22C077021AB8A279@BLAPR10MB5089.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6430;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	EC7KYn7rUvhuAZ6fjxpJt0c+nfyVAUCbLHS5Gkoy5HUXYdfxDVPQRJSZuGJncmqws3ljoRh+Rj8awlMNXQg6K3X34rEH4TJr/0oOheCVIr7forc4GQJ7Vlj231fnL8inGCuG6bo/7DTjS0jYYZHlVTRdiez+ukHJ22g1r+3udtpDAeEuq18wF2TORyTiSLYGmo773TTz8A0Pf/n/nNIrC1Ll0dHrlpVR7Ej56Pz51w12AO3nII/W+hA3elcV5bxc3/eNJVJe1LkHktYpyVKh9qSHSK1cmi/df+XQwRDHFZSc/vZFD4PsG1SDoUJTjBvd/g0VE8WLpwwJwEn5cHVXneX90cOxQq6AOjImLZ+1CViUVdxd6eEdTixPxTLISBsOc8fnw24V/ktrwfOBiVQuD85uMrpBTKMBt4mm0v+jZJwsCiRAm+BHy9OBaeCNNx19ZBlK2iQV2BKv8ValPJKqUhkPXvV9Enm2KxiyRymtpZZ4ch9TYCdk9/6/Kk2Uyr6D82jMSe29M0T7rJKrr3GPi+jqcmvQvceF0OHYWBrb4JzceFzJCobsGXwiLSyQZc+gCAHeDPgOpJ5zmhiRC7n+/8Ey7w7aSWK356WN8p4yfh9djHpkVS3HIIr/TEx+zws5/Jd1fYKlUUxGo9PrAPe/VTiOz+76kVTRjVRRdrIDhsahB1q0XpgJlupmXdk596xxDPpGaQRP93erpsBBGrEmV+Z7saMD8hT+TCQ5PyMVD9EJVPqWjPsj5vPwYHWpFcUW
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(53546011)(2906002)(38100700002)(6666004)(6506007)(6512007)(5660300002)(508600001)(31696002)(31686004)(44832011)(83380400001)(66476007)(86362001)(6486002)(36756003)(66556008)(2616005)(8676002)(8936002)(66946007)(4326008)(110136005)(186003)(26005)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?K0dtRDBOeTEyRWt0ajVpMXFldjVCcGxOK0ZSekx3dnZkTGVPT2k1N1FaS25W?=
 =?utf-8?B?TEF3V01CWE1oS0IxYk1QMjNUU1ZNaWJNMmNsQjhVaWwzN2VrTFdVQnpwMWtM?=
 =?utf-8?B?ZUJCWWN5eTJFWnFoZ3hYS1E4RW5JLzh4alNSczd3VlFPOElLMytzVHRSM3Ev?=
 =?utf-8?B?SStSdlc0dG03VjkvYXZtbExQQjlYK1FMZ3lPem83THRQdnkvenE5dkl3anNS?=
 =?utf-8?B?QjY4c0VEWmVyYVJDd1k2WFNOZFNuWmNFYnpEbGd3dlNZZTF2Z2h2azF4eGZa?=
 =?utf-8?B?N1RlZUxWekdsVlU4bFloQmZNN1MwcVAwNGxpMm5ONkJZelp3NTJlaFc0akFK?=
 =?utf-8?B?ZENzdWhaanl1MzY2aC82eXpOcVRJRllvaDFOU214bU45UERaSmVVWGFjZmNH?=
 =?utf-8?B?R0VldDBHZzNFcWdEWG8wOTlBQm5tVVZETEsvaWZNSDB6YXh4WmlZODFzTlRo?=
 =?utf-8?B?eC9Bc2hpWEVIdWV1S0UxeWdQbno0Ym1GbERocFRBeWxRdVJFTUZWdTQyR0tV?=
 =?utf-8?B?TVJXbDlzRDVLNmF0WG9WazZoa0k2ZGJUc3IrZVh1V2VZQW91L3BCZ2t4STRh?=
 =?utf-8?B?MHBCZlh5NHhqWnBmQ1FXS00vUmVPNXdFcFF5SDZUN0Fndm9yTzFmb2swZ0c1?=
 =?utf-8?B?WURkZUdNQlJaLzBWNElCUnFNb05rRm4rSlpjMVJnUHNZellvbVU0cWhWNTFE?=
 =?utf-8?B?RVpCUFNrYUhIYlkxc3FOMWU5c00rcGlVcXVya2o1ZmVzMlNodkN3UWE5Z1Nm?=
 =?utf-8?B?dEdqbFBsanB6NWVrS2hjTmRqN1hQNDEzdTF4NlhMd2tEWmhrdm5RL0FWcXpJ?=
 =?utf-8?B?N0dpTlJGem5sUC9iaGdocFZjeWMzVXhMTlQzcGYrSUl0NUp3SnRkd2lVc001?=
 =?utf-8?B?K25DY29RS2srdmE5UU9GWUcrL2FTYUVpR2NzRHFpaFAxSzh6SHlhb2g4UWtZ?=
 =?utf-8?B?N2paYVFyZWJXN1JNRnU0MnJhMkRJbHRJdmZRclkweFhvZHdoWDlLU0tLTzJD?=
 =?utf-8?B?U0VsSy9pYis0ZWx6TzlkZ0ZJaTl5U3BwWkZuMWxIMUdEM2NXTFpQMHoyaGR0?=
 =?utf-8?B?dGtnN0RHdE5rZTdCbWg0eHdzb0lMeVlPeWpuN1lDbVNRUFFJejhXZ2FmVjB1?=
 =?utf-8?B?VTVkTGcyS0xHQzZHQWR4STZ1VTVjVms0dWE3RStDM3FBSG9yeGdTcUpOOGhs?=
 =?utf-8?B?T1JFb1cveUkxSkdTdFJiMS9pQjN5Y2p3SmYyWW54UGlBMHk5L3FTelhGMzJY?=
 =?utf-8?B?QytKRGRnRHh6cm9ibDNvd3ZBZ0prallyR0s0KzViYWxHekw1YlZLTnV4eEpn?=
 =?utf-8?B?bnBLTXlUOU1SOGt5K2FGUUVMNFRuaGQ4Rmp5YkIyTXAvTFRMNkR0S3dvYlRX?=
 =?utf-8?B?aW5HSGVmSmpxdUQwTTd4S0pXMTluNnpMdjZsczMrUmF6T281K1hDK3NqcmlI?=
 =?utf-8?B?Y3dNMW9JbzJnUFRHczM0NUtrM29nZWdnNW1oY1JLVUVmNDhUUWlEcG92QW04?=
 =?utf-8?B?L1JkYkVkMkxNN29WNWJzY0JGTzJiaDlaYSt6dlJJWDZtZW8yWU1RSm9EZENr?=
 =?utf-8?B?ZlFuNkxUUExUOG9rTG1uejcvMy9jeXkrMy9FRmhUNS9FWm00Mm1zL0NhS2xp?=
 =?utf-8?B?bEZvR3gzMjJzdk9VUVpWWXd6bFNNam9WRTVCUEQ4Y2VaY3FqQUZ1Mlpsci80?=
 =?utf-8?B?RkFody9ZamJwQ0laeDBOeDd2TTVwaHFEdytSVUNlWjduaEpENE9qcUhCQVBG?=
 =?utf-8?B?T2I2VGtWV1pYeSs3ZkJtY2JkRGlRbTNtd3ZaSUltY3RWQXlmOHFoRzVHOGk1?=
 =?utf-8?B?bDg4bk5EN0ZIeTVVOEYwL1d2ZkNodVJWUXJaeFRPc1h4RnFFM0E2dTlMaWk2?=
 =?utf-8?B?Y2N2VXdTOEhDRUlqR1lEZ1R6c3lwdGM3Nk5rb2hYeFAyTEtvai9UTjVGNTZK?=
 =?utf-8?B?WmxDZzF5T0J5MUhGT3FPVGc1bUV0eUpidStPSkRiVENUQ1JrcUZ6Q3k3a2h1?=
 =?utf-8?B?bGR1UThsNXk4YVJiaUo3Q010MWVrTVQ2OUhIVnI3bGRLNUVHQmtFL0d4Smt2?=
 =?utf-8?B?MG9SWVBEZlQzVU5wV1QycUZuNlExdkpMM213T0RXdHFZanI5U2VwMnUySzl1?=
 =?utf-8?B?T2FGTTNreENzekoyNG8wVXVVQnh5KzNpMmV4VkNmLzNaVTZNV0JjM29YWXk2?=
 =?utf-8?B?TVNnY1p1WVNXWllUL1o3eFdPS0xYZEdWRDJiSFVTYlJLRUM0SS9RNmNyWWFo?=
 =?utf-8?B?dmNtTTc2QW8vdzYreFRDVVFhbkhBPT0=?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e495548c-05df-4db1-4fec-08d9e6582aee
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2022 14:27:40.2657
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tklxQOdYokwjkE/R2rcByQiQ4B+o6MpvZ2Md+T5NCoCgXxcxXQX6d7XmB/P9l2FbvFASlvJPdFshlEOV5DtKodC+e1ZqUYVkKFev6qdAcdw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5089
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10245 signatures=673430
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxlogscore=999
 adultscore=0 malwarescore=0 bulkscore=0 suspectscore=0 mlxscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202020079
X-Proofpoint-GUID: 7icpuLJcofmP0oP8mhigbWwIhlS9Zuny
X-Proofpoint-ORIG-GUID: 7icpuLJcofmP0oP8mhigbWwIhlS9Zuny


On 2/1/22 5:57 AM, Jan Beulich wrote:
> This started out with me noticing that "dom0_max_vcpus=<N>" with <N>
> larger than the number of physical CPUs reported through ACPI tables
> would not bring up the "excess" vCPU-s. Addressing this is the primary
> purpose of the change; CPU maps handling is being tidied only as far as
> is necessary for the change here (with the effect of also avoiding the
> setting up of too much per-CPU infrastructure, i.e. for CPUs which can
> never come online).
>
> Noticing that xen_fill_possible_map() is called way too early, whereas
> xen_filter_cpu_maps() is called too late (after per-CPU areas were
> already set up), and further observing that each of the functions serves
> only one of Dom0 or DomU, it looked like it was better to simplify this.
> Use the .get_smp_config hook instead, uniformly for Dom0 and DomU.
> xen_fill_possible_map() can be dropped altogether, while
> xen_filter_cpu_maps() is re-purposed but not otherwise changed.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> v2: Extend description.


That's been a while ;-)


Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>



From xen-devel-bounces@lists.xenproject.org Wed Feb 02 14:31:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 14:31:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264255.457285 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFGfY-0005ni-KE; Wed, 02 Feb 2022 14:31:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264255.457285; Wed, 02 Feb 2022 14:31:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFGfY-0005nb-H4; Wed, 02 Feb 2022 14:31:36 +0000
Received: by outflank-mailman (input) for mailman id 264255;
 Wed, 02 Feb 2022 14:31:35 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=6WyI=SR=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nFGfX-0005nV-3d
 for xen-devel@lists.xenproject.org; Wed, 02 Feb 2022 14:31:35 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d1e95166-8434-11ec-8eb8-a37418f5ba1a;
 Wed, 02 Feb 2022 15:31:33 +0100 (CET)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2104.outbound.protection.outlook.com [104.47.17.104]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-15-sLycvX0FOeyQGLAszdIdzA-1; Wed, 02 Feb 2022 15:31:32 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DB7PR04MB4953.eurprd04.prod.outlook.com (2603:10a6:10:13::28) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Wed, 2 Feb
 2022 14:31:30 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.012; Wed, 2 Feb 2022
 14:31:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d1e95166-8434-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1643812293;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=dla6MFIwFsSOaafl0EwGcx9ODvGl+MP2ItxZYXhsbUQ=;
	b=OfALM8p6gW4iFaptApZf+yh+3IQAuYKPAtizLIyH63U4MGFv9tdIMBngclGN5vG2UVL8j8
	P9CxhFEUS7zHgBREsGpPfk+ofdYB4bRPlkaHL4CibxC5NxjpsvYh+ReIz28/DtZytdNM8B
	ugMMoQaPNynu3eAGUH2ndoqqlwl+P+I=
X-MC-Unique: sLycvX0FOeyQGLAszdIdzA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=fv8rGW/FLy/r9KUhPGMZLw0tET0xYSw9t2TKX3kxeEGfOsJdx9nHhIJVCxrNrJYxJsVtMou6DX5jokx1hTDFE6+tThWQ7sU6oKXNWvmluMUaxxyV76WCjyhWRc6fcov40RAS7AYyDKRxAfOJNl3xTlFAO/PTm9ViCjIp870MS5LKLQv89p/A9ZprCcaWQ+XycIFGT6dnQzFrh70+wOpMrj3Oxtkd+1ITjiZb7u+EDbccYdxNkHQdrLvUgG8fUhO3fZNrpGEYqZ48V7SJKrxhDsXHvDplAu6TSvR+DvJkm1NJMn3z5zRzuJOR0kx6ZFiubnQ88Ns/yvr2YKnOkOTp/w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Ti1bMBx7a2i/zNYmFa1dzLTaNNOtGLdK5K0f87OaDxk=;
 b=Gi1lDzah3132ZeLXxeCJDFigiOfpZbMFtfPLvKiZuSc1Y+uKrZ4uu9unflY3QKOeEqPbI7Irhy0M4UZGuozLIAcLY04LOgAz6P7HuW+KmrMTWXvwJW0aZdntqDfbZto+CD302vV6WKhL/8qMKZe8e/swxcTGKKVHN4VBwJYbGhVHqUmvd8tr8mL6zo+oTt6LaBRBHpPbwNNZEYsefxyLLvrpgtYEbDp6CBcF278h2bwzkCyKbsAY05RtyJiXiFOGD2fosvTURBfJX+7T6Wfl0hWnNjUx3QtbtG24wDUXEfujFk/hYHHRytnwFy90wmRwuxYMgS+6jbuYVDWbobtfJA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <f93d4d54-a2ac-67c0-8a04-d8321b0828e5@suse.com>
Date: Wed, 2 Feb 2022 15:31:26 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v5 09/14] vpci/header: emulate PCI_COMMAND register for
 guests
Content-Language: en-US
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "julien@xen.org" <julien@xen.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Artem Mygaiev <Artem_Mygaiev@epam.com>,
 "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
 "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
 "paul@xen.org" <paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>
References: <20211125110251.2877218-1-andr2000@gmail.com>
 <20211125110251.2877218-10-andr2000@gmail.com>
 <YeAD9PH9o65o+M+w@Air-de-Roger>
 <6a31eb29-81b6-7553-897f-2e5e54bab9b8@epam.com>
 <d527740a-4d90-4155-13dc-5888e8acfa72@suse.com>
 <b9661d86-f084-9ad1-59d5-538113000393@epam.com>
 <ab68568c-461e-bef5-4218-07db8e837bcc@suse.com>
 <37313b25-ccbe-fbfd-8306-7a96ce83c818@epam.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <37313b25-ccbe-fbfd-8306-7a96ce83c818@epam.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS8PR04CA0010.eurprd04.prod.outlook.com
 (2603:10a6:20b:310::15) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4658e11a-d2ee-41e7-5495-08d9e658b406
X-MS-TrafficTypeDiagnostic: DB7PR04MB4953:EE_
X-Microsoft-Antispam-PRVS:
	<DB7PR04MB4953C0844B29953D3EEE064AB3279@DB7PR04MB4953.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	/09zYTIpWUKqMXISZy7bizSAFRXS7Jw4D2XUYC2/S94JK7EW3QwxsqatAI7h3j+zc8vtoFnnpHaJH5yo/0SnuDru0dxOr0t9MkjgqrSyCsKPaMgzjboy2nXUqMTjn07/N9itAJ8vx/6ILLNgGKrDT6UtOj2L6cXzQJROxHQ5PGVwApBwYwOnm6tBtzNlJq3S75puQGrgsTODXxQpfp7RV7vlcG6GOumguBmx3pu8D/KUY9jpubejr50SEPyEmR07btIorOvsW2akh3Jh2nyqz58LSF5VD9oqmNea1YqEMouB4S+J4uwHnOWHzTfDokGbcaoWy08k6BOc7VkMxKJmelTHah2FZBXTnyuTFZAT1A965n0YT0jrT0imFOZPB+jSJrQcLxR9WLnZpdT/jDThQfuFUCyote3c/GNcnCdBywhNpwgDNEC0ntRKu5tFqdfsYeg8/FGBe+SVpTAxFopbGyTf3VNLWA7iXtEb9MbKreisCCSH3eC63rJqupRNJafsrfCKHPOA41R/j1rGfC2Z2oThKmJ/4HmeddpBG7gEu8lStJtlgrUdQDtMkbLbFokhEsciaShl5oDg0Le2Ldtv20rBY28FA7rJblwYvlv2/8UBHQabPu1lmEi2q8i6hgiV6X++Y8cL6qT60AaAUhh+tZm+sgdcd7H//1zY19JREYzQilkYpHbl8HRb5a8oVtFzD5VL8cL2rTPsSWcQ+CDeNSKD8I2e7FqqyztEQ719xOE=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8676002)(54906003)(31696002)(6916009)(4326008)(508600001)(86362001)(6666004)(6486002)(53546011)(6512007)(6506007)(38100700002)(8936002)(2616005)(66946007)(66556008)(66476007)(316002)(83380400001)(36756003)(26005)(186003)(31686004)(7416002)(5660300002)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?IWT/vqv/F+s60K4TvB1EIBD/09mSRLb4ekdpwH0GuB4jmx7VsF2IqN7oqrMF?=
 =?us-ascii?Q?/EoUm13VhoGuAXs5MnPrwZUa143iT78rGT1jl9SWKj8dQb2K42LR5H0zb0CT?=
 =?us-ascii?Q?BDFuEtjlQxmXetEk4Euns0U8sAsi8B5ykKSyEvRqrzoc70ZvQisLlKD762Je?=
 =?us-ascii?Q?2YJ+twj4AJdOARkXrZRrvo0asIc9DqMc5B4sUWC6rMV8/egt1eVgBshf7ae4?=
 =?us-ascii?Q?8AGATEhoFu8ZBkloZMSA73HYufG3V5CTOiWvShbhLFxXAuFTHAJgzKtWgpHu?=
 =?us-ascii?Q?uJYhEvd3govwkxIcP61WMmTOqO2ZGujXQZ97AqYwUnaJycM+urEtEqEZIDau?=
 =?us-ascii?Q?S4TDT551hlBJhJSpTkoABRh98okHdxXMhqITDmyBrvs1WMYyuaeCh3QvrDCl?=
 =?us-ascii?Q?iP9bS3q8doyDwyL0m19NTKWTZxS0qkaRkJjEyhAOX7+Wd5YlQSvAajo6V/jp?=
 =?us-ascii?Q?wdJrHb6dhDj53y6bFz49h6XE5IUepKByLVft89jJGFynKfnSjJI2ZyIK8Xbm?=
 =?us-ascii?Q?VS/0UYcPolEOM7MJItl1wIKfS4IoQ3YWFL3sTGRbz/Qg7whIZVBDfhq97IcN?=
 =?us-ascii?Q?1FZp8NBmMd0pVg9U5DMZtFDhPlPxjH+FzECYcC1JHam4yx1ayT4NU0huN1Fm?=
 =?us-ascii?Q?5Dz+/U6wvm70qJ+4Tkg4rPHiVw7gPJcpw9lHHemEGwyL6q2zgnUlt9wvv1MC?=
 =?us-ascii?Q?Dj6Hwq1+rWCJt3Gn5RlKhbfF4vM78RGxkqHxqLeivQiOvbZp1/yb4n8zWFya?=
 =?us-ascii?Q?Lre1A9VZ3JRpSiCpH/8kSV5ztK/anIRqnm3BAJao5jNU5BCK4G2OHKNaX7Ng?=
 =?us-ascii?Q?x6t+O6ILPp/JyQoODfbhOw17oofWkB757YpSXFNWGHiOGcLHayZJRFcTwa6l?=
 =?us-ascii?Q?SQ0trgBnehTVlUjRlNHOhRW010l4w0IGzh3K1KetF31q94mFD0Gz3Da+ERkn?=
 =?us-ascii?Q?3hq5WrZ5aGr2hQjm7fgHv2KE/WSpyyeBO3fACu4HkTXJO/0LEtE29ArQHmmK?=
 =?us-ascii?Q?wRQioEwZXlHL8Rumsv9TpQN4ulwxPxIYEDfsHsjMBtyGWSJmLQAchIEaZHY7?=
 =?us-ascii?Q?dkUkEiTl86w+fA10PFsdsD/Yh6jRLKkySJiB43WjY2t/fM593dyLFsn2M39Z?=
 =?us-ascii?Q?nm4ZOb3oFWFDTCsDDRGIMqxxPoEtZy1kmHqWnFa3Ycy6tXhhKzT7Akp6xe0p?=
 =?us-ascii?Q?M8/RHYh3gQC61GMSTOM5u/0j33DZZOCkuMmTZ0ttkcTJ4/VYKUSADpiEXreY?=
 =?us-ascii?Q?4PqSBv1ILWlpWFfCE/D0M/lU9UuwEfFxYt39jddcGVghE4Or7sI951QsJUkV?=
 =?us-ascii?Q?cDLIiidsuEnGoMXVnr43J3ym2tu5a3ytSUUYkTUeZuexIUGJi2cS6c2ssYa5?=
 =?us-ascii?Q?+gQ24kRQPv8Nue+Oz+MlP9J34bU9IqHpVhTa4D0IQDF6RRu9DUjcJuFJN+vz?=
 =?us-ascii?Q?mMdK4Ytp+MpLS/yytIWnvkIstjZ+qccZ2aQmNHD7unsmY5W/SifdxWrW9ZfV?=
 =?us-ascii?Q?DDShYFEYad10n/jJkJgsqHNfyFCWkssT/bYff8bmDZoPo8/MJqKm75H9wNPg?=
 =?us-ascii?Q?qgnbF1CpgbyfwNRsd1M1WyE5T/MYbmtzI1Lu+uHv7oHXwEtALR3qVtc87NlP?=
 =?us-ascii?Q?Ml2qxNXRI5bnnizarxkffgw=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4658e11a-d2ee-41e7-5495-08d9e658b406
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2022 14:31:30.2553
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JQ9l79qFPScDACMKogynEaNl7Pxgbuw1dqm4I9vriibEirzyFFUGPJYWCdKW+YFoNKjKgsNI4ONL6CldiQPgvw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4953

On 02.02.2022 15:26, Oleksandr Andrushchenko wrote:
>=20
>=20
> On 02.02.22 16:18, Jan Beulich wrote:
>> On 02.02.2022 14:47, Oleksandr Andrushchenko wrote:
>>>> On 02.02.2022 13:49, Oleksandr Andrushchenko wrote:
>>>>> On 13.01.22 12:50, Roger Pau Monn=C3=A9 wrote:
>>>>>> On Thu, Nov 25, 2021 at 01:02:46PM +0200, Oleksandr Andrushchenko wr=
ote:
>>>>>>> --- a/xen/drivers/vpci/header.c
>>>>>>> +++ b/xen/drivers/vpci/header.c
>>>>>>> @@ -491,6 +491,22 @@ static void cmd_write(const struct pci_dev *pd=
ev, unsigned int reg,
>>>>>>>             pci_conf_write16(pdev->sbdf, reg, cmd);
>>>>>>>     }
>>>>>>>    =20
>>>>>>> +static void guest_cmd_write(const struct pci_dev *pdev, unsigned i=
nt reg,
>>>>>>> +                            uint32_t cmd, void *data)
>>>>>>> +{
>>>>>>> +    /* TODO: Add proper emulation for all bits of the command regi=
ster. */
>>>>>>> +
>>>>>>> +#ifdef CONFIG_HAS_PCI_MSI
>>>>>>> +    if ( pdev->vpci->msi->enabled )
>>>>>> You need to check for MSI-X also, pdev->vpci->msix->enabled.
>>>>> Indeed, thank you
>>>>>>> +    {
>>>>>>> +        /* Guest wants to enable INTx. It can't be enabled if MSI/=
MSI-X enabled. */
>>>>>>> +        cmd |=3D PCI_COMMAND_INTX_DISABLE;
>>>>>> You will also need to make sure PCI_COMMAND_INTX_DISABLE is set in t=
he
>>>>>> command register when attempting to enable MSI or MSIX capabilities.
>>>>> Isn't it enough that we just check above if MSI/MSI-X enabled then ma=
ke
>>>>> sure INTX disabled? I am not following you here on what else needs to
>>>>> be done.
>>>> No, you need to deal with the potentially bad combination on both
>>>> paths - command register writes (here) and MSI/MSI-X control register
>>>> writes (which is what Roger points you at). I would like to suggest
>>>> to consider simply forcing INTX_DISABLE on behind the guest's back
>>>> for those other two paths.
>>> Do you suggest that we need to have some code which will
>>> write PCI_COMMAND while we write MSI/MSI-X control register
>>> for that kind of consistency? E.g. control register handler will
>>> need to write to PCI_COMMAND and go through emulation for
>>> guests?
>> Either check or write, yes. Since you're setting the bit here behind
>> the guest's back, setting it on the other paths as well would only
>> look consistent to me.
> I can't find any access to PCI_COMMAND register from vMSI/vMSI-X
> code, so what's the concern?

Again: Only one of INTX, MSI, or MSI-X may be enabled at a time.
This needs to be checked whenever any one of the three is about
to change state. Since failing config space writes isn't really
an option (there's no error code to hand back and raising an
exception is nothing real hardware would do), adjusting state to
be sane behind the back of the guest looks to be the least bad
option.

> This seems to be the only place in vPCI which touches PCI_COMMAND registe=
r.

How is this relevant?

Jan



From xen-devel-bounces@lists.xenproject.org Wed Feb 02 14:35:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 14:35:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264261.457296 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFGjQ-0006Qr-4J; Wed, 02 Feb 2022 14:35:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264261.457296; Wed, 02 Feb 2022 14:35:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFGjQ-0006Qk-1J; Wed, 02 Feb 2022 14:35:36 +0000
Received: by outflank-mailman (input) for mailman id 264261;
 Wed, 02 Feb 2022 14:35:34 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=6WyI=SR=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nFGjO-0006Qe-Gi
 for xen-devel@lists.xenproject.org; Wed, 02 Feb 2022 14:35:34 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 60ace059-8435-11ec-8eb8-a37418f5ba1a;
 Wed, 02 Feb 2022 15:35:33 +0100 (CET)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2059.outbound.protection.outlook.com [104.47.13.59]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-25-J48epH4TP124jraBD5XEuA-1; Wed, 02 Feb 2022 15:35:32 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM6PR04MB5351.eurprd04.prod.outlook.com (2603:10a6:20b:29::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Wed, 2 Feb
 2022 14:35:29 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.012; Wed, 2 Feb 2022
 14:35:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 60ace059-8435-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1643812533;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=G1UgrMmjUR/x017Ro/iQt0Tz87XGFU0Ky7vnfzyPvUk=;
	b=k9i8yiRV9N2zKHW4JCF7QlsieC2y1E2BUQEqDBptnTdNd30EyF2N6dM/YCbkURBx1oKJ8y
	F2RGUQLdpPhdelnepYpTJTJ8wcy7LPYFTjORP9e+aiB3h404u3jXaug39rPVMJp+/CSwWW
	QactihbmPOt0C8XTNjlEwmiahJlaljQ=
X-MC-Unique: J48epH4TP124jraBD5XEuA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Q3ww0gTGrhM8QGGoBYd5Ble/q8zXZhXSxBEoDUIM/QqUmMPx+8vlYZHY6d91Q9qdSEntBG6Yz/gvdaSHovidAUh0EjsQWk0WS/j8n5c3iSUoDrwVMEZnjhmCRFvqVk3fjqd2D9iwaaU2E2drGkCgtchJyX7nIz36gRxc+tMJ0Gb22QdnCf4GLrmtBnIk08ntyZoRE5Ynrebrj+5gR6TiVJ213QJ9s5cmzzUjAltoLXm74yBVdSnRR4NhpwPthdYqpzBvHB8cmqGkbeDvs7C8SgeSiUoN9vtO+7nfAUZaPP0Xyz/tMCcmUU7lbl5F9Cu/ky/ujNYF6YV2cRIdgJD83A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=G1UgrMmjUR/x017Ro/iQt0Tz87XGFU0Ky7vnfzyPvUk=;
 b=Ckbg0qup+U5Hx9fTkh1FOegdk4pWT8FFWkhPgrHqAgg9xt6D8qgcm8fOweHoNiKs6AXu3sDd1xWscJ/UhuKvUiHB/5HU0c4uV16InUo4Jd+TGuH0pPjH7qT6CGoDAJ7u26+a1ZI+y/g+uU49NgFppfdWtMqNY8U0j3zKXeGuPnD+AmINhG8mGXHCUm3bjGfyDn30D6zp5QmeSenNQ1O7iZai/5Pc8a/S6W0XnlwD6JtnDDylENxyo3omdM2JdmQ6AGrLv6S9fISO6Hy3E3vE+6BrdsKqv3vc98HUS4rrZID8HEyCFveFMLH8yD+1WHz32VGqzI3i66t0bWA2OJgWUA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <46486c52-9475-90b8-9f2c-f8947cfd6cc8@suse.com>
Date: Wed, 2 Feb 2022 15:35:27 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH] x86/Xen: streamline (and fix) PV CPU enumeration
Content-Language: en-US
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Juergen Gross <jgross@suse.com>
References: <2dbd5f0a-9859-ca2d-085e-a02f7166c610@suse.com>
 <bba4b96b-2d0c-6fe6-4580-2b62f0d635bc@oracle.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <bba4b96b-2d0c-6fe6-4580-2b62f0d635bc@oracle.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR05CA0002.eurprd05.prod.outlook.com
 (2603:10a6:20b:488::35) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 722ef648-79f3-4bf3-570c-08d9e65942c7
X-MS-TrafficTypeDiagnostic: AM6PR04MB5351:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB5351CBA32D90DA84F4F9C643B3279@AM6PR04MB5351.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	zfbDatymmjHqjNV8zo1Ftt0C7j3pdTMEJJkHuz3hD4OLXPRGYIMa/XpnKeCiidvsoeOWXzJIjd13AdBtaOQibfpnMG6Vv22djh/4KgrS8oE4TTBE/Inokx96+Y9mHbVgo5sA1I67RF69wur3YPdDRAoO5VRrXE1o/JzF2chk/2mpnJBCyHJcRxkwyDrUiqATvVka9FjwCeljWbI2FBxeVlc8ok2RnT/WAGqHq7AtrQB7thTHO3oMxUBW9fRlUbcMkDlLDxRTEFV3/PBTHnLI0fhuUr675TxU5A2n+rmwQGXdcESEKLdiyuQlLewJvMDW4IKUgxH8kJ7q4XDKdTmKdwhktrRDka/L8wlv//Wj8pFKbXhLvjMYjdgsId20NxVm5f0ftBPHoVOj/D4vGYjaXj9O1e+OyS7ZISFjwa7rVFBEMrbWlUoE6VgDkUr7cR9qw4c0TwU5OBtwalyueuY+Rr0YtLLDfnucz0nSVL3KWALyeq+fUgblLSqc/cJkUMye8FA9icCYYnWsVD4QR/zH8zrRYcXxeaFEoRRpSGWWeXJjtj2PydLXXcJh/e+0ViwkOa3Tn7IxbGjAMKVDukp6pS9d+UdV6Hg0vqL4gcgoLHYdZRPnsHwAJXFkeWWtqOJiR0Xts5BNhnMPqct1LsaI7K7k9G7NLP737k8ojKMnxpWFvRgr6+xc3bARX14SlXKcl1ZYeGM+Uh7EBr0azFE+P0CaNS0nJ7yOFCT2n3P19Rw=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(83380400001)(66556008)(66476007)(8676002)(54906003)(26005)(186003)(4326008)(8936002)(6486002)(6916009)(31686004)(86362001)(36756003)(31696002)(2616005)(107886003)(66946007)(508600001)(38100700002)(2906002)(53546011)(316002)(6506007)(6512007)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Nmcra1Q3M04vQnRhdEZSekEyT3VUZ29RRm9Qd1dxbEVzTEtVLzlsb2xyWExF?=
 =?utf-8?B?Z1ZvbGxKZm9aWXNCVFFFTWFEb1gvSlhURlVZd21tejZIYzVldjVGZVBteUhW?=
 =?utf-8?B?V3RBRXFXbUw4VmVyYkhLeG4xVHdBTy8xb1Zsb3hRelJPU0dSa3M3OE1DbHF6?=
 =?utf-8?B?Tmx2QWg0STN1cC9PQkpXSytlSmhEZmdMSlFhdXR2SkFreDh2VjVqRHZ1WHdL?=
 =?utf-8?B?QVlzT3hrdW1Gd0plNDNNSTdEdzBxRWlBa0l2MjUvQklBYXpGbi9seFdUaDNX?=
 =?utf-8?B?ZkRJK1Y5QzVyUjVhTFN0TXJMdDhWOVp1bmhkTWZHdXBPdnk3UEhPL2M2TDhE?=
 =?utf-8?B?bVZubk5mRy95TzZrUi9BanpZeURIZEoxWnlIaEZsRXdlOVJWVVBVa0VBYlVz?=
 =?utf-8?B?ZVVtOFhRdUFMb1Y0c3NmZjlVS0pFNDRiR08vU3pGN3E0WW1lQnk5dkdrOFhk?=
 =?utf-8?B?dFhhTzluUllOUlArd0FXTE5DQTZ2VG1BOVFETVgyU0UzaW53QUR1Q3QvdERM?=
 =?utf-8?B?TjhyT0tDSFZ3dkM5YXdJTE8rbmxqTXpmem4rTWFqZUlMc1hQcGlHaUVVeUpq?=
 =?utf-8?B?RmpvWlRVdDNTN0NlaldjZGV2dTcvUGRwQUNQN1NRUEJrc1hDZzlhTTA1d0s1?=
 =?utf-8?B?R284c0xUMjJNWnlySUtvNTFNYnhoMStzM2lKMVJKUlNxc3pid3BHTzJZVXNs?=
 =?utf-8?B?LzFUZmpDdEhHbHBjRGxrSWY3dnZMa0pvVTBlM0lkVEhybTh4UHkyM0VDQVRY?=
 =?utf-8?B?VUZkcEIzQW1mY0dRNkU4UlhrSFhGQlNldzdQOTBVUzZjSTVwSmRtVnVvdmQ0?=
 =?utf-8?B?WnRTb3I3alM1Wkc1YThOaE1RbnFRdjBjNHVtYUNRK1Rramo5UGJXbDZaYzNt?=
 =?utf-8?B?WjI5ZGJCcEgrK0pjZUhFYVhuRHVhZS9NVTdmOXhTbGEwYzd6a25pNE85UUZ3?=
 =?utf-8?B?b0VwdGdSS2VHWG50RnFnMGk5Zzk5SnJDcm1SS1p6S090MVBNN2h4SEJEeEVu?=
 =?utf-8?B?NG1Hc21HSGtWZlFMUmhQOEs1U0UwZ2duZkNWWVJRaEdQWlM5cEUzK3VldnRF?=
 =?utf-8?B?OXdEWXFyc1BwUmxyYUJ5M2hJVklwalpyaEV3eW9DTmRROFo4TnRZOGV0dmRa?=
 =?utf-8?B?S3hKL0NYTURoOGRhZCsvWDFVdStxWnBWL2pIQ2UxZXhjeHZ0YWJOQlVxRzhp?=
 =?utf-8?B?Mm1iajM4WkJkdUlaZEx2em4rakFNUTFRQUVzVkdRcFM5QmRoK2ZnUzhtOWpZ?=
 =?utf-8?B?R3lhRVMzYXZsazd3KzJBenN5MkhHeTVjZGF6b21hOW9ZNW0vZ01vTmhRc2JC?=
 =?utf-8?B?bGU5VEFkckdDK2xlbitDK0lBUVQxZkp3RWJGWitiMU1KckdZbEFWMWFMdXc1?=
 =?utf-8?B?NDNjV2JIRFFDYmRObUNOVkZJYUxHMllTb05VMnJkOGVzL0ZwSSt4RE9JSG1k?=
 =?utf-8?B?VU81NVpjTFZkV2xwM2lXcm8ybmZkUHRtWUlLODZBWkxoM3Eyai9ualVRUTlw?=
 =?utf-8?B?cFpBVkw5ODM1bWpUWVlPMGtMYVNOTmV1V0hiYmFlak5CSzRLN2RSTE9ieFFO?=
 =?utf-8?B?N2FYcW5Td3FQL1EzSjFPakdvdG90R1JGWmNtdkpwamtVTzRGaHpxbXU0VXB0?=
 =?utf-8?B?ZjNPS3FSYjI4a3NWT2E0WGxFOGcvTm03Y2NDaTkvYmRYcldiZk9EeFJkRGRY?=
 =?utf-8?B?WmRwczhlTTgyL0FjZENEUVhuYkhENk5kc3VEQTVsZTFHY2dBQWdoUmN6QU8z?=
 =?utf-8?B?MHRUUW5ONktXWStNK0lJeTBxUmFYcXZ4bUFlZDFBWW1VZHdvNU1FSlhHNmNi?=
 =?utf-8?B?ay96ZHNBUjArRHJwQTBlWjNTVjhnTlpxNVhmRDhqOFlGZHJrSnBkOXRtNmtY?=
 =?utf-8?B?OFY0Mi9hQ3RBL0s0Uk5sVnZoUnpzR2hBeVpXQTNpU0V3ci83djlXWjVRcXZv?=
 =?utf-8?B?cElyUFNyajFIcU80R0dqRjMySCtuaGI2OWpJaEcrQUhJNG9PSXpHcFhHTTBK?=
 =?utf-8?B?RnB6Z1ZVNS8wdGFSTkNDREMvLzFPdzdQeXp4eDZZNUZid0xSbEhEK2thUnFr?=
 =?utf-8?B?WHZRNVZkTlFyU01IWGlHeUxRM0lGY1ZaT0ZvNEJFcFVtb2ttOGdWb2x5NXlW?=
 =?utf-8?B?eVBmWk1NQ3lucU15UVhobjZCTjQ0TExaZjBmM29mZzU1RkxtTGkvcitqMy9J?=
 =?utf-8?Q?+ezO1EZaYfK+hs3ljIfB9Hk=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 722ef648-79f3-4bf3-570c-08d9e65942c7
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2022 14:35:29.7567
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XfDwuDOVbKRvuYxzoj0u4EScW8DYBDnvm/ZTbdnMLZDZjPhqtutvPxpBfkR1le7w3IK0dSL6fYQM5hE5ZxYWnQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5351

On 02.02.2022 15:27, Boris Ostrovsky wrote:
> 
> On 2/1/22 5:57 AM, Jan Beulich wrote:
>> This started out with me noticing that "dom0_max_vcpus=<N>" with <N>
>> larger than the number of physical CPUs reported through ACPI tables
>> would not bring up the "excess" vCPU-s. Addressing this is the primary
>> purpose of the change; CPU maps handling is being tidied only as far as
>> is necessary for the change here (with the effect of also avoiding the
>> setting up of too much per-CPU infrastructure, i.e. for CPUs which can
>> never come online).
>>
>> Noticing that xen_fill_possible_map() is called way too early, whereas
>> xen_filter_cpu_maps() is called too late (after per-CPU areas were
>> already set up), and further observing that each of the functions serves
>> only one of Dom0 or DomU, it looked like it was better to simplify this.
>> Use the .get_smp_config hook instead, uniformly for Dom0 and DomU.
>> xen_fill_possible_map() can be dropped altogether, while
>> xen_filter_cpu_maps() is re-purposed but not otherwise changed.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> ---
>> v2: Extend description.
> 
> 
> That's been a while ;-)

Indeed. For some reason I had stored in the back of my memory that
you asked me for splitting the patch. That's something that would
have required at least as much time (to make sure I get it right)
as it took to put together (and test) the patch. Which was more
than I could afford in all this time. Recently I decided to check
with you whether I could talk you into withdrawing that (supposed)
request. But when going back through the old thread, I was
surprised to find that all you did ask for is extending the
description to point out that the CPU map management isn't the
primary purpose of the change.

> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>

Thanks.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Feb 02 14:45:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 14:45:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264272.457307 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFGtF-0007vC-4E; Wed, 02 Feb 2022 14:45:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264272.457307; Wed, 02 Feb 2022 14:45:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFGtF-0007v5-14; Wed, 02 Feb 2022 14:45:45 +0000
Received: by outflank-mailman (input) for mailman id 264272;
 Wed, 02 Feb 2022 14:45:43 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HAZh=SR=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nFGtC-0007uz-V9
 for xen-devel@lists.xenproject.org; Wed, 02 Feb 2022 14:45:43 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c7dec8da-8436-11ec-8f75-fffcc8bd4f1a;
 Wed, 02 Feb 2022 15:45:37 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c7dec8da-8436-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1643813140;
  h=from:to:cc:subject:date:message-id:
   content-transfer-encoding:mime-version;
  bh=6kXWJHyQ9JH1ETeavJLNiKUEZ8f6LOBjCmX/ZvyRE18=;
  b=bRMVq1px5weeJe1Y3Iun1GAFYWkxjcxMe7Ik+NejXhB0YarfuLB5xY3w
   LXP+YFoD/1MKzoI/DII+4NI4YYL6qu+nm//KLbhc/1ehW7tkaK5DrmOMj
   D5qcPAQQe/DnqnyZywPyRzdYsQpcejbn099kSJCKhUou2le8MQTHhPf6j
   s=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: MkPhPY26NqdhySkiQOxXoGDFIPCHkHrQ14JS6IaGTGP5Li2/FmyKwKKqVACbnrIgQHHg/od6wm
 J2uHnP8GR9RKTTcm6t6Bhuiq+alENWnVA+tFgtBMm4kEbEB4KCwy4zixR+4jbJgTfbqJel9/xt
 O72DEkC/7zGQ2pOrGqG2J1mr9RZKTzbi/eyH4Pm8iLLd6atiG1+Kh6ir/cS69I2lnr6OoNJfIa
 DfcMvggcoBAMvZvr6C7JGokf3AfE6nbzg0LPz+jXkYBXz7OYb+ZfojUPB7529hVowO8PYga6Mp
 aZRvWUqb6FmmfcuUw7X7e8th
X-SBRS: 5.2
X-MesageID: 63329457
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:k+eqLqvbcwwXU6uUKJ9Ndryzu+fnVN5ZMUV32f8akzHdYApBsoF/q
 tZmKWGCaarfZjD8Kd1/aIy/900GvcDWnNIxSlQ9qChjRXgQ+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZQP0VOZigHtIQMsadUsxKbVIiGHdJZS5LwbZj2NYy2YLhWWthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 NplsaC/VSN5Aq/wqssjFCIJASBxZbZ4weqSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DJoQQt2sm1TjEJf0nXYrCU+PB4towMDIY2JsVR6eCO
 pVxhTxHVDHxZTBgIEUsFYNkxcuwjz7PV34HtwfAzUYwyzeKl1EguFT3C/LXZ9iLSMN9jkue4
 GXc8AzRGQoGPdaSzT6E9HOEheLVmy7/HoUIG9WQ7vd3hHWDy2pVDwcZPXOrrP/8hkOgVtZ3L
 00P5jFovaU07FasTNT2Q1u/unHslhwWVsdUEuY6wBqQ0aeS6AGcbkAbShZRZdpgs9U5LQHGz
 XfQwYmvX2Y29uTIFzTNrd94sA9eJwAREWAeQX84Tzc3zOekm9Ahjx2XVehaRfvdYsLOJRn8x
 DWDrS4bjroVjNIW26jTwW0rkw5AtbCSEFdru1y/snaNq1ogOdX7P9DABU3zsK4YRLt1WGVtq
 5TtdyK2yOkVRa+AmyWWKAnmNOH4vq3VWNEwbLMGInXAy9hP0yLyFWyzyGsnTKuMDirjUWSxC
 HI/QSsLuPdu0IKCNMebmb6ZBcUw1rTHHt/4TP3SZdcmSsEvKFTYoHg/NBPJgTCFfK0QfUYXY
 s/zTCpRJSxCVfQPIMSeG4/xLoPHNghhnDiOFPgXPjys0KaEZW79dFv2GADmUwzN14vd+F+92
 48Gb6OikkwDOMWjPHW/2dNNfDgicChqbbir+pc/XrPSfWJb9JQJVqW5LUUJIdI1xsy4V47go
 xmAZ6Ov4AGu2CSaeVjWMS0LhXGGdc8XkE/X9BcEZD6A83MifZyu/OEYcZ42dqMg7+tt0bh/S
 PxtRilKKq0npu3v92tPYJ/jgpZlcRj31wuCMzD8OGo0foJ6RhyP8djhJ1O9+C4LByuxlM0/v
 7z/iV+LHctdH1xvXJTMdfai71KtpnxByuh8aFTFf4tIc0L2/Yk0dyGo1q0rI9sBIAnozyeB0
 1rEGg8RoOTA+tdn8NTAia2egZ2uFu9yQhhTE2XBtO7kPijG5Guzh4RHVb/QLzzaUWr1/oSkZ
 PlUkK6gYKFWwg4SvtMlQbhxzK8469/+nJNgz1xpTCfRclCmKrJ8OX3aj8NBgbJAm+1CsgysV
 0PRptQDYeeVONnoGUI6LRY+arjRzukdnzTf4KhnIEj+4yMrrrOLXV8LYkuJgS1ZarB0LJkk0
 aEqv8tPs16zjR8jM9CniCFI9jvTcixcAvt/7pxKUpX2jgcLy01ZZc2OAyD715iDdtFQPxR4O
 TSTnqfD2+xRy0eqn6DfzpQRMT6xXagzhS0=
IronPort-HdrOrdr: A9a23:+VPMEaCr9U3JOYblHehAsceALOsnbusQ8zAXPh9KJiC9I/b1qy
 nxppkmPH/P6Qr4WBkb6LS90c67MAnhHP9OkPIs1NKZMjUO11HYSr2KgbGSoQEIeBeOidK1t5
 0QCpSWYeeYZTMR7beY3ODRKadd/DDtytHOuQ6x9QYJcek8AJsQkjuRRzzrW3FedU1jP94UBZ
 Cc7s1Iq36JfmkWVN2yAj0gU/LYr9PGuZr6aVpebiRXozWmvHeN0vrXAhKY1hARX3dmxqojy3
 HMl0jc6r+4u/+25xfA3yv47ohQmvHm1txfbfb8wvQ9G3HJsEKFdY5hU7qNsHQcp/yu0k8jlJ
 32rxIpL61ImgfsV1DwhSGo9xjr0T4o5XOn40Sfm2HfrcvwQy9/I9ZdhKpCGyGpp3YIjZVZ6u
 ZmzmiZv51YAVfrhyLm/eXFUBlsiw6dvWciq+gOlHZSOLFuJYO5lbZvsn+9La1wXR4TsOscYa
 lT5YDnlbxrmGqhHj/kVjIF+q3uYpwxdi32N3Tq9PblkQS+p0oJvnfw8vZv7EvoxKhNNaWs2N
 60QpiA7Is+NvP+TZgNc9vpEvHHfFAkf3r3QRGvyBLcZeQ6B04=
X-IronPort-AV: E=Sophos;i="5.88,337,1635220800"; 
   d="scan'208";a="63329457"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Q3hX2pVMidF2987nRF7KtkXtyoijNnd3Vq1Q7S9ZM+UbSE91CL/bxomMQ4wYrQ4+BSQsMKICApu+CdZbzO7aOH62o7qO7jBYYkWqZuN07V6uaKobqe1/hhdXSFJxvUmlBfA2sKeO2kjCd28vq17oC3aDDblk4VJV7luCBtURgwy2I9sfOZ94SJyfTv/RJnQJdB+RrVCcaE9Q5B5kZ/Hb3nfUlv67RrLUlB9wTv43YBzWu0c0xRsb5fL7hC6RkGb9rncn10c7Rn0nWeuC37cVNiYu7T0sbM+oya0r+y95sPoJbDPV3WMbi0B/CN1tjbQHdpobJ9VnHwnLrKTTFXYXyg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=0sZyzVC3JRNwT9aRZuSsyTGUzKM7BvPWaKzuv2Xg9fc=;
 b=XqrPzk208Cg8zSmU20t4tpDDbG5H1czHkKEPBHi+OH9Ph8NhOKGLMK25XOIITaDQr9IgeulC/r2RcJwa99+jpFRl4I9Wzh1W/H3GA6kwSeb3MjwkKVvtpXFW2PuLp9COJ4Ip8pBl8H/xN7JUwubiQG27ed9fkASV5y9v4o1TaP4n/NqEKguH3CpHo7edoN6oWYaOOCC02KDtwJ/gbQE5DLBqHZEW/NkrDPQJCfBxuXNw/KmA1j70QSMwPUem1xrUFUJC/dTFc5GtfUxSrJ7B5+DYAD0P1ivXNMA3LmMMxGco+y5rXEvEC+dt30r+nxhjPsuWOhZRj8+GG7ZIQivoSA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=0sZyzVC3JRNwT9aRZuSsyTGUzKM7BvPWaKzuv2Xg9fc=;
 b=Pn6lL25e33yI+hxG5yP06TSnr1V6Lw7ebhdA6DopVLURQDJ8M+ivUwYLbQF9rjcqcJjDr3rEbHRD6OefYAMLP7gAwfyweV73c7VnAxT6BbBS6/f2Fx1L0wZdWQQ0BUN3PdA/u4n/TC1cYAreWu4KJTmtg2GawArl0WTAGDDxSCA=
From: Roger Pau Monne <roger.pau@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Roger Pau Monne <roger.pau@citrix.com>, Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>, George
 Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>, Stefano
 Stabellini <sstabellini@kernel.org>, Paul Durrant <paul@xen.org>
Subject: [PATCH v4] xen/pci: detect when BARs are not suitably positioned
Date: Wed,  2 Feb 2022 15:45:23 +0100
Message-ID: <20220202144523.10709-1-roger.pau@citrix.com>
X-Mailer: git-send-email 2.34.1
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO2P265CA0389.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:f::17) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 50011865-f1c2-4854-7d1f-08d9e65aab4c
X-MS-TrafficTypeDiagnostic: DM6PR03MB4506:EE_
X-Microsoft-Antispam-PRVS: <DM6PR03MB450650827E6F4ADA3EB3E1C28F279@DM6PR03MB4506.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:167;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: cY9TLLqpUAncW3G/7ItAtTJjasMo/Pvvv1KMkZuv4kXf1hAc2goBgQzQ+sulDPDdoon7Yqgya2hUEcljdSXclQyNfeTzpA0+ML21qeErQtsXWtKFWKgruTsVDyvKZIz+fCFEEXFlTvfs7SO9zdv0JDcmbmiFwuq/sXVg4TdoD6XeaoQ+9L9wTX4yxEvayPiyzgC3edKNShp+/HPlbBD24iIrFgJF/mHnDXEwrSPnA+eA6veoElMtYbyrN8ddetfwHyzAZf7Yw/XjdkkfLf8u/UqYHaYtgT/dZJeuSgSojUxPNcQZg5P4HHMQmqhoI6Olsg7j/nTI3q7s30D2lbzpOl0hUVp4DiP+1+JX6mvFZS9wTBmRYp2J7tfTcrN3jnbfex8pYnSSHU3BzVIrB1eSaX9EbLN7zzlJCJUVezHQ3TsSxvSX4e1+LbfjzMLPva9wR3MHqaysPJRb7eBc7esys7vFnLJ4EUEoEi+Woq5Boq149jUNaTMqqxFLu+IV9AWTaMeyl1cxM2Eae8a905Wfr8qzkMEb0uyriZzpap7uN3kmc94UYS+X4IyMDv5aGlehKRqLpvxayhiafwuauU7YA3hud0tSFvH7qo4uTfEpGprMm/GVjpiKUpgBkJVJ4IMHf3jKqx0PzphX2iAKxwZF1A==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(2906002)(26005)(86362001)(2616005)(186003)(5660300002)(1076003)(6486002)(6506007)(83380400001)(508600001)(8676002)(66476007)(6666004)(66556008)(36756003)(8936002)(6512007)(4326008)(316002)(82960400001)(6916009)(38100700002)(66946007)(54906003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V1pBSlJGMjlQVU5MWUdTZThBRDFQbjRYMEJmcFJjRGFKZDJTZjU5WjdEbE1D?=
 =?utf-8?B?WlJ5UGZsOWoya3FrY0NaMjRPN0tnQk5yaGdaR0ZYQzZsenhJQW53WFhOTTN4?=
 =?utf-8?B?K2FBZDVVSFhSa0NQek5sS0hWTU9yRFRVVFZBWEF0RkxPUTRGOGY5UzVWOU03?=
 =?utf-8?B?Vi9OSFpBZ0RwVTAzcGpxcjN0ZUJ1VWw5ckZQcWk4elBuV3dsZ2lZWW12aVdU?=
 =?utf-8?B?TzlwQnl5K09TUVRrVjNNc1diNjVPajlKN3lWSVgyVlQreEx3ay8rNlJud3pq?=
 =?utf-8?B?SzRpSnQ4NEtKdEJMOEdXTW1ud1UxRVNIa3Fnck5vS29sYWVmSkxtYUtwaVph?=
 =?utf-8?B?cnYyVlNNb21TTDZhWWU4MCsxZ254TFhSWXBuQm5tNTEvaGRRSEhsT1JPeW8w?=
 =?utf-8?B?VE0yRGlKOEZKL2JVQkFoYnJkQzA3ZzRxelBOZlpNT0o4RGRIanFGdC9yZkdt?=
 =?utf-8?B?RlFPSU5NSjluenBRRDdYV3dXd2VJZ3hBR2c1b0YvN21wMnhZSWx6eGRiRmJn?=
 =?utf-8?B?RlZQR3QrZ0g2ZjVhV01zRnhKcjg3dVBKdVhXZkVicVMvWHRHNVExYXlIdnBR?=
 =?utf-8?B?V1ZOL0JkMjJVWHZCM0Y2dmNldkNBZFd2QkRFRndJajQvWEVTaGthdGhtN0Vw?=
 =?utf-8?B?ZU5SRGExY3FjM3poWVE1UkFKd0Npamo5azlzSVZrS3ZYemhLRGxIVzJWbzZ4?=
 =?utf-8?B?OTEyc3BUOGNjY3d5VTYzNzk0TWJjTjZyU052YzVYUXNHWi9xNGErTkpQM3A4?=
 =?utf-8?B?KzJ0ZUk5cm9hL0hhemM2dWRGWjNNcGtKN2NnaUhnSzE0SnF0b0Z3L1J1SEZh?=
 =?utf-8?B?cEZwRk1JY2ZQdm9hSHE3cXNWZ2UzSE11MnNFcjdUY20rV3BIQzZEM1pFa1Rz?=
 =?utf-8?B?MWhna2pkUVpINEhzL1RISS9wMmNJUHJtamdoQTJnRjBhSnB6T0ErT3ZmN05h?=
 =?utf-8?B?NEh6V29mbWlibXlyVjFOMGc5WlllUFlZTFVmWWJTencyYU1LcjNZOWV6bG9j?=
 =?utf-8?B?RmlyWE4zbHNNdGV6ZjNQZWtRN1RZU2ZaWGdPT0F6TEhRYzZ3LzBucFptM1BY?=
 =?utf-8?B?dDBKdk1FZHpaQTdhUXlUVjNRMzBhTUlQM21KUVdxQ1U5YlVBWUxpbkU5NURt?=
 =?utf-8?B?cU14V2R5UEhNaEZIempuWWppV3liN3hJWFp6MmpseGFKUkRMWjFwSWlYUEd4?=
 =?utf-8?B?Smg3VDFCR1NvNTlBekdBNHdxN1Zsb1lBTXhSYVlVZlNmQ3BnaDlxZEJiTVU4?=
 =?utf-8?B?Q1ZBSlV4WitzR2dtLyt4MndYUTc3LzFlZFhyTGh3QTNyOFhEdUVSMWdidXQw?=
 =?utf-8?B?NUN2b3V0VCsxaVdvTVRQdGsyb1dMTXEwZjVMWFg1RW1XaW9qd2hWNDRMSHpX?=
 =?utf-8?B?ZEdIZ0crMko2THNwZXEvMFhPRENsaWIyWG40aVZVRVVXU29Oaml6TE13b3dV?=
 =?utf-8?B?VDFMUmdmYVYzMTRaUDZiRWdQbGVGa0Y5RXpJU2h1MGZtOUpEenp6RytZWVNF?=
 =?utf-8?B?TEx1b1dHb01OVzZvYXlGZGtVKzJmM0pkWjBya3pvU2hNLzQrQ1FnTms3M2J4?=
 =?utf-8?B?aE1KYlBhZ2JqaHB0UG92aFE1SDJJdHJabE9xM3U4YXJyNzV6U21qT1JrMFlC?=
 =?utf-8?B?Qmo4S0FJTUl6VnE4eGFLanY0L01xVUFlTkZvT00ya2ZzZEo1Y0xuaitlWVpu?=
 =?utf-8?B?MmVuT2ZYQ2laWGtyUWlydFNacUpLOUprNEZ5ZzJHMVJYaElBY0RGYmRVaEFU?=
 =?utf-8?B?Zkd4b0txVGxmOWJMdUQ2UExSVlZOSG1Tck9yd2RKLzFNclpuZHR0UFNiL200?=
 =?utf-8?B?UHBOSStGT0YzZWt6YkNnYUtWdmtoeVBOdEtydUE0RHRiRkNDQmk5SW5LTHc4?=
 =?utf-8?B?c290N3JuTHcxU2lXYnZUdm5QVnhTNzR3Ym1INmQwOW1sMGlBM0Q5bVZ1bUQ5?=
 =?utf-8?B?OEU0anBlVC93UXdPbXI2aWtRWjhkYnFyek55aVlQaW5od3VIelZ1U1Qwd1d0?=
 =?utf-8?B?bVowR0tPQ29UOGhoQUlyTC9yK21rSU9mNHowTHRscU81bXdaMXdOMU56elNx?=
 =?utf-8?B?RW1ZRTJ5dzh5YkgxSzcwQnRvVXZkUzM3TCt3b0s3am5wQmUxRTdBMi9mZi9n?=
 =?utf-8?B?Y056d1JpMG9oM3ZGd1RjMzJSeGtFWjEvSUhVTzV4UnVJM09iZDUxbGc4eTU1?=
 =?utf-8?Q?4cIR76ZeOgtrZnspkVcUGqg=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 50011865-f1c2-4854-7d1f-08d9e65aab4c
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2022 14:45:34.6872
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Kirfvs8Nc8e2tJHnyBZyCovx/yFGl9Lx4S5e67OnSMD+kNSCCAT49uPTNX4l4pyrPd6Iu6E8bW5PzYoHHK0tiQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4506
X-OriginatorOrg: citrix.com

One of the boxes where I was attempting to boot Xen in PVH dom0 mode
has quirky firmware, as it will handover with a PCI device with memory
decoding enabled and a BAR of size 4K at address 0. Such BAR overlaps
with a RAM range on the e820.

This interacts badly with the dom0 PVH build, as BARs will be setup on
the p2m before RAM, so if there's a BAR positioned over a RAM region
it will trigger a domain crash when the dom0 builder attempts to
populate that region with a regular RAM page.

It's in general a very bad idea to have a BAR overlapping with any
memory region defined in the memory map, so add some sanity checks for
devices that are added with memory decoding enabled in order to assure
that BARs are not placed on top of memory regions defined in the
memory map. If overlaps are detected just disable the memory decoding
bit for the device and expect the hardware domain to properly position
the BAR.

Note apply_quirks must be called before check_pdev so that ignore_bars
is set when calling the later. PCI_HEADER_{NORMAL,BRIDGE}_NR_BARS
needs to be moved into pci_regs.h so it's defined even in the absence
of vPCI.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Changes since v3:
 - Use mfn_t parameters.
 - Fix boundary checks.
 - Ignore memory ranges with 0 size.

Changes since v2:
 - Unify warning message and store in a static const var.
 - Rename checker function to is_memory_hole.
 - Pass an inclusive MFN range to the checker function.
 - Remove Arm implementation of is_memory_hole due to lack of
   feedback.

Changes since v1:
 - Add comment regarding pci_size_mem_bar failure.
 - Make e820entry const.
 - Move is_iomem_range after is_iomem_page.
 - Reword error message.
 - Make is_iomem_range paddr_t
 - Expand commit message.
 - Move PCI_HEADER_{NORMAL,BRIDGE}_NR_BARS.
 - Only attempt to read ROM BAR if rom_pos != 0.
---
 xen/arch/x86/mm.c             | 23 ++++++++++++
 xen/drivers/passthrough/pci.c | 71 ++++++++++++++++++++++++++++++++++-
 xen/include/xen/mm.h          |  2 +
 xen/include/xen/pci_regs.h    |  2 +
 xen/include/xen/vpci.h        |  2 -
 5 files changed, 97 insertions(+), 3 deletions(-)

diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c
index 1397f83e41..98edf5b89c 100644
--- a/xen/arch/x86/mm.c
+++ b/xen/arch/x86/mm.c
@@ -783,6 +783,29 @@ bool is_iomem_page(mfn_t mfn)
     return (page_get_owner(page) == dom_io);
 }
 
+/* Input ranges are inclusive. */
+bool is_memory_hole(mfn_t start, mfn_t end)
+{
+    unsigned long s = mfn_x(start);
+    unsigned long e = mfn_x(end);
+    unsigned int i;
+
+    for ( i = 0; i < e820.nr_map; i++ )
+    {
+        const struct e820entry *entry = &e820.map[i];
+
+        if ( !entry->size )
+            continue;
+
+        /* Do not allow overlaps with any memory range. */
+        if ( s <= PFN_DOWN(entry->addr + entry->size - 1) &&
+             PFN_DOWN(entry->addr) <= e )
+            return false;
+    }
+
+    return true;
+}
+
 static int update_xen_mappings(unsigned long mfn, unsigned int cacheattr)
 {
     int err = 0;
diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
index 1fad80362f..e8b09d77d8 100644
--- a/xen/drivers/passthrough/pci.c
+++ b/xen/drivers/passthrough/pci.c
@@ -233,6 +233,9 @@ static void check_pdev(const struct pci_dev *pdev)
      PCI_STATUS_REC_TARGET_ABORT | PCI_STATUS_REC_MASTER_ABORT | \
      PCI_STATUS_SIG_SYSTEM_ERROR | PCI_STATUS_DETECTED_PARITY)
     u16 val;
+    unsigned int nbars = 0, rom_pos = 0, i;
+    static const char warn[] = XENLOG_WARNING
+        "%pp disabled: %sBAR [%#lx, %#lx] overlaps with memory map\n";
 
     if ( command_mask )
     {
@@ -251,6 +254,8 @@ static void check_pdev(const struct pci_dev *pdev)
     switch ( pci_conf_read8(pdev->sbdf, PCI_HEADER_TYPE) & 0x7f )
     {
     case PCI_HEADER_TYPE_BRIDGE:
+        nbars = PCI_HEADER_BRIDGE_NR_BARS;
+        rom_pos = PCI_ROM_ADDRESS1;
         if ( !bridge_ctl_mask )
             break;
         val = pci_conf_read16(pdev->sbdf, PCI_BRIDGE_CONTROL);
@@ -267,11 +272,75 @@ static void check_pdev(const struct pci_dev *pdev)
         }
         break;
 
+    case PCI_HEADER_TYPE_NORMAL:
+        nbars = PCI_HEADER_NORMAL_NR_BARS;
+        rom_pos = PCI_ROM_ADDRESS;
+        break;
+
     case PCI_HEADER_TYPE_CARDBUS:
         /* TODO */
         break;
     }
 #undef PCI_STATUS_CHECK
+
+    /* Check if BARs overlap with other memory regions. */
+    val = pci_conf_read16(pdev->sbdf, PCI_COMMAND);
+    if ( !(val & PCI_COMMAND_MEMORY) || pdev->ignore_bars )
+        return;
+
+    pci_conf_write16(pdev->sbdf, PCI_COMMAND, val & ~PCI_COMMAND_MEMORY);
+    for ( i = 0; i < nbars; )
+    {
+        uint64_t addr, size;
+        unsigned int reg = PCI_BASE_ADDRESS_0 + i * 4;
+        int rc = 1;
+
+        if ( (pci_conf_read32(pdev->sbdf, reg) & PCI_BASE_ADDRESS_SPACE) !=
+             PCI_BASE_ADDRESS_SPACE_MEMORY )
+            goto next;
+
+        rc = pci_size_mem_bar(pdev->sbdf, reg, &addr, &size,
+                              (i == nbars - 1) ? PCI_BAR_LAST : 0);
+        if ( rc < 0 )
+            /* Unable to size, better leave memory decoding disabled. */
+            return;
+        if ( size && !is_memory_hole(maddr_to_mfn(addr),
+                                     maddr_to_mfn(addr + size - 1)) )
+        {
+            /*
+             * Return without enabling memory decoding if BAR position is not
+             * in IO suitable memory. Let the hardware domain re-position the
+             * BAR.
+             */
+            printk(warn,
+                   &pdev->sbdf, "", PFN_DOWN(addr), PFN_DOWN(addr + size - 1));
+            return;
+        }
+
+ next:
+        ASSERT(rc > 0);
+        i += rc;
+    }
+
+    if ( rom_pos &&
+         (pci_conf_read32(pdev->sbdf, rom_pos) & PCI_ROM_ADDRESS_ENABLE) )
+    {
+        uint64_t addr, size;
+        int rc = pci_size_mem_bar(pdev->sbdf, rom_pos, &addr, &size,
+                                  PCI_BAR_ROM);
+
+        if ( rc < 0 )
+            return;
+        if ( size && !is_memory_hole(maddr_to_mfn(addr),
+                                     maddr_to_mfn(addr + size - 1)) )
+        {
+            printk(warn, &pdev->sbdf, "ROM ", PFN_DOWN(addr),
+                   PFN_DOWN(addr + size - 1));
+            return;
+        }
+    }
+
+    pci_conf_write16(pdev->sbdf, PCI_COMMAND, val);
 }
 
 static void apply_quirks(struct pci_dev *pdev)
@@ -399,8 +468,8 @@ static struct pci_dev *alloc_pdev(struct pci_seg *pseg, u8 bus, u8 devfn)
             break;
     }
 
-    check_pdev(pdev);
     apply_quirks(pdev);
+    check_pdev(pdev);
 
     return pdev;
 }
diff --git a/xen/include/xen/mm.h b/xen/include/xen/mm.h
index 5db26ed477..3be754da92 100644
--- a/xen/include/xen/mm.h
+++ b/xen/include/xen/mm.h
@@ -554,6 +554,8 @@ int __must_check steal_page(struct domain *d, struct page_info *page,
 int page_is_ram_type(unsigned long mfn, unsigned long mem_type);
 /* Returns the page type(s). */
 unsigned int page_get_ram_type(mfn_t mfn);
+/* Check if a range falls into a hole in the memory map. */
+bool is_memory_hole(mfn_t start, mfn_t end);
 
 /* Prepare/destroy a ring for a dom0 helper. Helper with talk
  * with Xen on behalf of this domain. */
diff --git a/xen/include/xen/pci_regs.h b/xen/include/xen/pci_regs.h
index cc4ee3b83e..ee8e82be36 100644
--- a/xen/include/xen/pci_regs.h
+++ b/xen/include/xen/pci_regs.h
@@ -88,6 +88,8 @@
  * 0xffffffff to the register, and reading it back.  Only
  * 1 bits are decoded.
  */
+#define PCI_HEADER_NORMAL_NR_BARS	6
+#define PCI_HEADER_BRIDGE_NR_BARS	2
 #define PCI_BASE_ADDRESS_0	0x10	/* 32 bits */
 #define PCI_BASE_ADDRESS_1	0x14	/* 32 bits [htype 0,1 only] */
 #define PCI_BASE_ADDRESS_2	0x18	/* 32 bits [htype 0 only] */
diff --git a/xen/include/xen/vpci.h b/xen/include/xen/vpci.h
index 3f32de9d7e..e8ac1eb395 100644
--- a/xen/include/xen/vpci.h
+++ b/xen/include/xen/vpci.h
@@ -80,8 +80,6 @@ struct vpci {
             bool prefetchable : 1;
             /* Store whether the BAR is mapped into guest p2m. */
             bool enabled      : 1;
-#define PCI_HEADER_NORMAL_NR_BARS        6
-#define PCI_HEADER_BRIDGE_NR_BARS        2
         } bars[PCI_HEADER_NORMAL_NR_BARS + 1];
         /* At most 6 BARS + 1 expansion ROM BAR. */
 
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Wed Feb 02 14:50:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 14:50:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264280.457317 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFGxw-0000xJ-SH; Wed, 02 Feb 2022 14:50:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264280.457317; Wed, 02 Feb 2022 14:50:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFGxw-0000xC-PK; Wed, 02 Feb 2022 14:50:36 +0000
Received: by outflank-mailman (input) for mailman id 264280;
 Wed, 02 Feb 2022 14:50:36 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=RYPV=SR=kernel.dk=axboe@srs-se1.protection.inumbo.net>)
 id 1nFGxv-0000x6-Qz
 for xen-devel@lists.xenproject.org; Wed, 02 Feb 2022 14:50:35 +0000
Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com
 [2607:f8b0:4864:20::631])
 by se1-gles-sth1.inumbo.com (Halon) with UTF8SMTPS
 id 79424c87-8437-11ec-8eb8-a37418f5ba1a;
 Wed, 02 Feb 2022 15:50:34 +0100 (CET)
Received: by mail-pl1-x631.google.com with SMTP id z5so18464965plg.8
 for <xen-devel@lists.xenproject.org>; Wed, 02 Feb 2022 06:50:34 -0800 (PST)
Received: from [192.168.1.116] ([66.219.217.159])
 by smtp.gmail.com with ESMTPSA id u18sm27070556pfi.185.2022.02.02.06.50.31
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 02 Feb 2022 06:50:32 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 79424c87-8437-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=kernel-dk.20210112.gappssmtp.com; s=20210112;
        h=from:to:cc:in-reply-to:references:subject:message-id:date
         :mime-version:content-transfer-encoding;
        bh=IAkJ25VWGHpvo748Ps3jmA0wCxSeGiRhv8GghNIjjCc=;
        b=hs9vTLYzgYWsMhdo7W/FDStWSbFMCMMt9vdgv5sV/q3umnsqiQSEfCqrNim48rcYWQ
         WNUzTuvQAJ0sDihfOuWS0QOGzEsxWAr0Pnjrw3bWTt/51G0aCscpb7N28MkQRP+Ybw9U
         QUpyn0NBNkrO1Q8uaUOF4/JbxnMJQMYZShxwVUBk5pnNiEY/YiQ7cSsKkCnJMjsZFJ/R
         LprEgdjYCoVAPMbCYjcK+kwaAwkWQZ3f8+251u1es631aToqil8P8oY4xfroCSVLk1zW
         IhfRx5mM6vd7nGUMlO9XrmmP0F0ELYksOi6VL8XXDhWNI42+96xLTzvukOHXjddiZQYF
         NiVQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:in-reply-to:references:subject
         :message-id:date:mime-version:content-transfer-encoding;
        bh=IAkJ25VWGHpvo748Ps3jmA0wCxSeGiRhv8GghNIjjCc=;
        b=HGVlespg4a9xxHeVwJ6IGlhAtaADCoiBJ17wUtM7GXIAZCV16GuqK5rCsrvEBBtP3I
         39D9A575UZh8l9dzyhUbGvisPy1GfsPjqhWkC6DJv/UaUa56Ty9yEyONScOLuJwLdl8d
         WHSdNWPr6lTcuUNvsMT3wPpangw0fsoSc48T5ZbhedBO4wMQizEtj6p6EduZQknqVM/m
         yz1d6lFaAJGcVFXu9NIRfodUhqHmVTrUasROs5Ae6F3Q8/eJIEjHjRCrhEJDN/z8GKBW
         5KSnXpB2EBsGmWtulHt8exSiSfFnZk1MY0s1Sx41nVmG8BIlFdtSXl8HdYu9Z6ZbiGv3
         iiSA==
X-Gm-Message-State: AOAM532GOBRFf7Z0Pv67VCS5YcSRbQWyQI4ED8wlDQcM7X1AtOSjqJnr
	S+cO64uvFvtByG92z4YFulLmyMBELsNMAQ==
X-Google-Smtp-Source: ABdhPJwSLudBNjLMeTvPHLIsOXD+1k6FRXpLWDFks6w4HVgPtg5F+Tt+QBkGoHPVlgrjEzbfwYXf1A==
X-Received: by 2002:a17:903:2305:: with SMTP id d5mr30165640plh.122.1643813432532;
        Wed, 02 Feb 2022 06:50:32 -0800 (PST)
From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@lst.de>
Cc: Ryusuke Konishi <konishi.ryusuke@gmail.com>, xen-devel@lists.xenproject.org, "Md . Haris Iqbal" <haris.iqbal@ionos.com>, Jack Wang <jinpu.wang@ionos.com>, dm-devel@redhat.com, ntfs3@lists.linux.dev, linux-nilfs@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>, Roger Pau Monné <roger.pau@citrix.co>, linux-fsdevel@vger.kernel.org, Philipp Reisner <philipp.reisner@linbit.com>, Konstantin Komarov <almaz.alexandrovich@paragon-software.com>, Lars Ellenberg <lars.ellenberg@linbit.com>, linux-nfs@vger.kernel.org, Mike Snitzer <snitzer@redhat.com>, Pavel Begunkov <asml.silence@gmail.com>, drbd-dev@lists.linbit.com, linux-block@vger.kernel.org
In-Reply-To: <20220124091107.642561-1-hch@lst.de>
References: <20220124091107.642561-1-hch@lst.de>
Subject: Re: improve the bio allocation interface v2
Message-Id: <164381343094.170143.694743005104706258.b4-ty@kernel.dk>
Date: Wed, 02 Feb 2022 07:50:30 -0700
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

On Mon, 24 Jan 2022 10:10:48 +0100, Christoph Hellwig wrote:
> this series is posted early because it has wide-ranging changes and could use some
> early ACKs before -rc1.
> 
> It changes the interface to the bio allocators to always pass a block_device and
> the operation, which is information needed for every bio submitted through
> bio_submit.  This means the fields can be directly initialized in bio_init instead
> of first being zeroed and thus should help to micro-optimize even better than the
> __bio_set_dev that Pavel proposed while also cleaning up code.
> 
> [...]

Applied, thanks!

[01/19] fs: remove mpage_alloc
        commit: d5f68a42da7a4516e7503c281a54a58727f07dc3
[02/19] nilfs2: remove nilfs_alloc_seg_bio
        commit: f0d911927b3c7cf5f9edb5941d0287144a602d0d
[03/19] nfs/blocklayout: remove bl_alloc_init_bio
        commit: 5d2ca2132f889bc2c90d6d07fc9fc129cfee8955
[04/19] ntfs3: remove ntfs_alloc_bio
        commit: 39146b6f66ba5c107d5c5758a17f290846165b4d
[05/19] dm: bio_alloc can't fail if it is allowed to sleep
        commit: 53db984e004c7116ce69e2f4a163664453336ae1
[06/19] dm-crypt: remove clone_init
        commit: 3f868c09ea8f40f800c4c644c072d91c9eee0d71
[07/19] dm-snap: use blkdev_issue_flush instead of open coding it
        commit: eba33b8ef1b90d8996eceb0569c06a4f784ef2b5
[08/19] dm-thin: use blkdev_issue_flush instead of open coding it
        commit: 28d7d128aad5cd2178b158900d58365d1fd3de94
[09/19] drbd: bio_alloc can't fail if it is allow to sleep
        commit: 4b1dc86d1857f1007865cab759f2285280692eee
[10/19] rnbd-srv: simplify bio mapping in process_rdma
        commit: 1fe0640ff94feae6d21417e2f4f2829b882274b1
[11/19] rnbd-srv: remove struct rnbd_dev_blk_io
        commit: d7b78de2b1552e3e7ce3a069f075cc2729aa5c34
[12/19] xen-blkback: bio_alloc can't fail if it is allow to sleep
        commit: 7d8d0c658d48705fca35238a8ff601b7c5cbc0de
[13/19] block: move blk_next_bio to bio.c
        commit: 3b005bf6acf009abd700e2c652c86e5c209cf63d
[14/19] block: pass a block_device and opf to blk_next_bio
        commit: 0a3140ea0fae377c9eaa031b7db1670ae422ed47
[15/19] block: pass a block_device and opf to bio_alloc_bioset
        commit: 609be1066731fea86436f5f91022f82e592ab456
[16/19] block: pass a block_device and opf to bio_alloc_kiocb
        commit: b77c88c2100ce6a5ec8126c13599b5a7f6663e32
[17/19] block: pass a block_device and opf to bio_alloc
        commit: 07888c665b405b1cd3577ddebfeb74f4717a84c4
[18/19] block: pass a block_device and opf to bio_init
        commit: 49add4966d79244013fce35f95c6833fae82b8b1
[19/19] block: pass a block_device and opf to bio_reset
        commit: a7c50c940477bae89fb2b4f51bd969a2d95d7512

Best regards,
-- 
Jens Axboe




From xen-devel-bounces@lists.xenproject.org Wed Feb 02 15:04:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 15:04:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264287.457329 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFHB1-0002UC-0R; Wed, 02 Feb 2022 15:04:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264287.457329; Wed, 02 Feb 2022 15:04:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFHB0-0002U5-Ta; Wed, 02 Feb 2022 15:04:06 +0000
Received: by outflank-mailman (input) for mailman id 264287;
 Wed, 02 Feb 2022 15:04:05 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=6WyI=SR=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nFHAz-0002Tx-Fr
 for xen-devel@lists.xenproject.org; Wed, 02 Feb 2022 15:04:05 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5b538ea5-8439-11ec-8f75-fffcc8bd4f1a;
 Wed, 02 Feb 2022 16:04:02 +0100 (CET)
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2057.outbound.protection.outlook.com [104.47.2.57]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-10-T-kNNkshO1iliHAiZevC2A-1; Wed, 02 Feb 2022 16:04:01 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by PAXPR04MB8095.eurprd04.prod.outlook.com (2603:10a6:102:1c6::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.22; Wed, 2 Feb
 2022 15:03:59 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.012; Wed, 2 Feb 2022
 15:03:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5b538ea5-8439-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1643814242;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=5enuSN3lUVUJwJE3Qj/nC6/vUsvH3Ym5GqhOFLC5Ur8=;
	b=LpJ8qf0NC6a6AT/TaKhXgQrSC5lCGgHA2kWvm6PcIU/Z4LD5S441R/IQCrDBRaVOIIfum6
	Ho6UD8zAS9DWIPGGO02xVtnZxOj3X+qHxJ/y0IrMUwF+Ic5ENbXGzYK37CTGFV3qy0W4/h
	eBgItGFXcVSnXLdYyb01MlI9FyO4VKY=
X-MC-Unique: T-kNNkshO1iliHAiZevC2A-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=oIsfJvmOAsWrl6u79wNwf5pVm74vX+OXE7L6JrVwESNNFqSgR8ekoJpHXBLJNKFuYeWIZ07cxYa7OH55xvboY8956CVqaUikjXxO0kjC7hZbqeOOUmgCqqAuIrJvCv6Ms65qtRJh1uQi9ughwi4wbBW0c6OArF7j29ju3QY7gbZz3OhCh1oRhCoWwb4OFxxCs2/Nr0EWebIyo4uhGMXrBwTORjjFJy5jSMjyHyTUOQ/v7L6fmm+n+Qt+M8v7YQxQ0hdLGaLURl15VDcZ4IuiCFI7xzAAuwkasi4kLFmc7Z1trOUS9SdpCodgwPAk1tMo1WhmnbmfQcfnc0IY2DH2PA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=hBRyNp+ZlYONfsxjoAJA1EX+KoUvSPBAcmhaPQR8834=;
 b=hDrtR06dQ1dBzZ2HUPEKEJAXnGXyDkZtjdEKh2XcUqKSOCnTy5Whnc2NKtVSubXZyRpuiLDqjlQlbpksUjZMTZ0TfScxekEm62uQMittUoHXu6anntPFQEZw0xzCir1/HRnITLC/fQR/DBQLmVAFy/6EB8zGQY/mfMUQ45AJ241fX0eUKXAORDwBVYkcUrtK/Rb2UqzhZpukSXULB6TBXnvKKZVlEwcXf4f1CtWxe9TOdw2iamF1qEVfYXD/7VZvRien1z++Y8T7hgz6VkuA3hZl6HacPOnyJiBCuOxZKC661iX+elj9gLopwxKmFHSnE4SYxjJYSBYeERuJAOnc5A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <a3043ad7-e72f-1314-a51f-812d73cb6afb@suse.com>
Date: Wed, 2 Feb 2022 16:03:57 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v4] xen/pci: detect when BARs are not suitably positioned
Content-Language: en-US
To: Roger Pau Monne <roger.pau@citrix.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Paul Durrant <paul@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220202144523.10709-1-roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220202144523.10709-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS8PR05CA0020.eurprd05.prod.outlook.com
 (2603:10a6:20b:311::25) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b580814d-3a05-4daf-fd1a-08d9e65d3dfd
X-MS-TrafficTypeDiagnostic: PAXPR04MB8095:EE_
X-Microsoft-Antispam-PRVS:
	<PAXPR04MB80954FF3D7034CAE0B913DE0B3279@PAXPR04MB8095.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	MNVHyvwdlXe/jIXfLQbGXuJyghNk4djpYs52nnPLWPOg9aOIiJu9M+4NEPAyZJEWCH5B0gwdwoe5Pkk+ydfxsOB6EHnZJVs2+yZSmAAV0u5PfXGPjH8LAIvQkp/O9b6LDFxDQCwvvrBU7AdIRpBYBrqLdWWeclqqg+JBWZibGaWxa+MCRHoSk0A3xc3qeLGzj5WCDkIf7F1TyegnrckuN2jU3IKcFwMjb1oaPj1NYfQSQuVgQmuGi+TKXvkGKair6/t3JUWV1K+cUfN4Oa/RADedq+bmdZgGby2CoBJvBWRZYmAYuE0iO7Vb9Jci8Q4TKH7cYuwhjNInTtCF0+2pboVGppqiaeslB/P83OcNMj05WksXCxEPsNvmf03bU72Cv1fTnzbxMz7sSuD6V3yRX1o6oWQoWpXXIqiTlvjSrMrdclCtIZCevK50ZwGcHaU0iyD9nh2/aqvykXjTiwSbkVs9Maj1epGWOcZBkJICoZrKAgWbDdX3kiJAzBYxgJbYGxphdUWFOPtSZ4n7b4ZCjRXiHv5O07A0p1oI9Rf/qYuIadhQoQtYV77WpgjaA1o/S3QyAYZzKg/3eYrTLWqL2NHEJbQiZw1StHaUImRQu66Ff6mjmCWLH7aJwzD2EKuyXfx07a4Sm0vbov4kAt0mrbetKxBGkdKW4oZr+w++vbpkfByEoYE/A5E+TZKxjUFq2XXazQ93K+7b3Qj+fSAQzpM7E9XHh5xXPkvREndZf+A=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(83380400001)(54906003)(66556008)(316002)(31686004)(66476007)(38100700002)(6916009)(66946007)(86362001)(2906002)(508600001)(2616005)(6486002)(186003)(26005)(53546011)(8676002)(8936002)(36756003)(4326008)(5660300002)(31696002)(6506007)(6512007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?R/Y3St0AGdY58UsSOuaCJRGSCxJBy5dAAWpVjDp4m/NyDyNxcvFRxJ0ToEQn?=
 =?us-ascii?Q?DKjOheEjBmbt1wyMkefsvsO5ej/d1YC4hqWjZ5y1fu0pbpXdGZpMFCFWSdyM?=
 =?us-ascii?Q?uLPjU/jbhyc8E9L1gouK1C/Q+29mZApVrbNb7G6kUJWTQgHw+a/taWhj+x9J?=
 =?us-ascii?Q?qsQ2HKVwcxqa+au1nS4pWESKisUmTm3u/dCxB5b9GxebwgjUlXhyFPDob27+?=
 =?us-ascii?Q?MsVquUzfZEZjsa34Pz2KhlkDFJhyU4DrjS4dNN7Aa4pOKBXNssN5rlWNrPl8?=
 =?us-ascii?Q?PQ7A0CGBEz77l/p2fJXtO/IWct3ffXNc1XArrpVnzCrGKqovYsc/Khy34AkC?=
 =?us-ascii?Q?+zIzx8IZgZNntqXfPm6HoANQ5wzavPBhzBSxrjJ3XcJOKnw1Jg/4CRH1NeRx?=
 =?us-ascii?Q?mNui7R6guitOvx6to9A5Tkp8GpIQ0qv6/6OFiBk+K/ldMAL+ta1UwpQ0Wc1R?=
 =?us-ascii?Q?NXhrrfOAjOqi4+6lEyBbVgvwjiuLZgXTEpl8avSOooiBpKkRegLI1D+Uqc4M?=
 =?us-ascii?Q?czcufWinfVaD0Bb1ZYzDwRRQiZOCJq6zNtDh7ZiJ5fQoXkozkRedfH5dK04O?=
 =?us-ascii?Q?ZT6a+UXDaXxuDqqaCzUUjdUQuvzvV2EH6FFjI+kyblRbnNJ4xJzQg3wZeqw7?=
 =?us-ascii?Q?lIkILLjHCLI4DuWluRHT8aRbeHMNs+mwZ/fZNAZqOKvk3l1IbM+wa2U+ueEq?=
 =?us-ascii?Q?gPgZax5Eukkak2/yXwYFly2NCNJrwraQBruZgaTzc1KE3/yD1vnVAmzYPBTR?=
 =?us-ascii?Q?IW2W//oGMr9hvsReyzMpD5nC7szzhOBqN4wsaET1eD+2Zmc3NEY/+7elgMqg?=
 =?us-ascii?Q?GMwi6EYIxrnR2Acii1Aqu54Xf8MeyubcjSWT2b7tW7yTCKNNU6gthqm/1YgW?=
 =?us-ascii?Q?QZcnmYv2puUkHwvInMexDCt/fEpOvD8SKgkjTqteSUYMYjyyckdmXzlCI+bJ?=
 =?us-ascii?Q?riwkNbE+NmtUVqmTXLYffkiB/MZuoo55W+y56fYeGjeBsm9CUXtoy6rBzEV8?=
 =?us-ascii?Q?83XMJJw/LLDH9AnG5uBBL0FgTd6YncdVl2ShcMDE+n4Se8X1meMxlAJuFznY?=
 =?us-ascii?Q?+6HcJ14SWZE/G3IdFJ8CST72uTy8mgyN+ufAFblvq+uzq106WYdczDM/c2bQ?=
 =?us-ascii?Q?Ym7YqjZyhWsfVcqO0JLbpdr1KUZqmcn0MSv+hlydgaMN/TW8usTZQxORYMMI?=
 =?us-ascii?Q?MCWEuoGH3bMRMKXfmYDT49gggUYIKFi3ZcrPTkC+V6342/t3tc4qx/en5wnB?=
 =?us-ascii?Q?Ri/S7GARA+aTv/Zrt74niyulRRovkGQRZNv5CNuF58dsE0Mdn/laFPFo4GDG?=
 =?us-ascii?Q?TadM5zyyCIXIseanrdXeOSj8+hzkp9g8TzC0fK7yZOy4xoJkitxIgEH37XlN?=
 =?us-ascii?Q?HqvPSagHHv6TBveyLGo/cp9c0SgRZBjVXpWoU0hAIhXgpiYo2ITMUAli2l1I?=
 =?us-ascii?Q?LO2uZv6dgXBRcwpXwlMjHwhRoXF/aCAIrmYHGjl23vgPoA7DPGzlgCJTp9Oo?=
 =?us-ascii?Q?niUi9PEHqK+/QcDMg4Agw3/NNgbMYCcEMV9deGFl7DPL5Rm+BPbMBIZnSduI?=
 =?us-ascii?Q?gvWz611R80Ib/xGvn4n85jmz/WBsBsa4BEDNo4XVgXf4Y6UbdBWWykbKF29W?=
 =?us-ascii?Q?zX6PcXbNkfRQHHxbCnnc/Qc=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b580814d-3a05-4daf-fd1a-08d9e65d3dfd
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2022 15:03:59.6975
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CCkpB3avXkO8VdDny0BOnb1qArEOQTNrvzL33ZWs4iStVPkTzf3CkwzlUzNgCTTcQ8bvFB/hJrlUc6W1u3sz7g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8095

On 02.02.2022 15:45, Roger Pau Monne wrote:
> One of the boxes where I was attempting to boot Xen in PVH dom0 mode
> has quirky firmware, as it will handover with a PCI device with memory
> decoding enabled and a BAR of size 4K at address 0. Such BAR overlaps
> with a RAM range on the e820.
>=20
> This interacts badly with the dom0 PVH build, as BARs will be setup on
> the p2m before RAM, so if there's a BAR positioned over a RAM region
> it will trigger a domain crash when the dom0 builder attempts to
> populate that region with a regular RAM page.
>=20
> It's in general a very bad idea to have a BAR overlapping with any
> memory region defined in the memory map, so add some sanity checks for
> devices that are added with memory decoding enabled in order to assure
> that BARs are not placed on top of memory regions defined in the
> memory map. If overlaps are detected just disable the memory decoding
> bit for the device and expect the hardware domain to properly position
> the BAR.
>=20
> Note apply_quirks must be called before check_pdev so that ignore_bars
> is set when calling the later. PCI_HEADER_{NORMAL,BRIDGE}_NR_BARS
> needs to be moved into pci_regs.h so it's defined even in the absence
> of vPCI.
>=20
> Signed-off-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Wed Feb 02 15:04:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 15:04:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264288.457340 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFHB8-0002lC-AH; Wed, 02 Feb 2022 15:04:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264288.457340; Wed, 02 Feb 2022 15:04:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFHB8-0002l5-5Z; Wed, 02 Feb 2022 15:04:14 +0000
Received: by outflank-mailman (input) for mailman id 264288;
 Wed, 02 Feb 2022 15:04:12 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1p3Q=SR=epam.com=prvs=40324c57ab=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nFHB6-0002kO-33
 for xen-devel@lists.xenproject.org; Wed, 02 Feb 2022 15:04:12 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5ea3b1c7-8439-11ec-8eb8-a37418f5ba1a;
 Wed, 02 Feb 2022 16:04:09 +0100 (CET)
Received: from pps.filterd (m0174676.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 212F3h5D011332;
 Wed, 2 Feb 2022 15:04:05 GMT
Received: from eur04-db3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2053.outbound.protection.outlook.com [104.47.12.53])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3dyv8sg02x-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 02 Feb 2022 15:04:05 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM7PR03MB6449.eurprd03.prod.outlook.com (2603:10a6:20b:1b8::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Wed, 2 Feb
 2022 15:04:00 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6%3]) with mapi id 15.20.4951.012; Wed, 2 Feb 2022
 15:04:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5ea3b1c7-8439-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=SlqyO1fDGvIXvL2HEAYIkf47B+NAq70HFhadsp+Z91jF2TEephe9krstsqJVrK4Q6G+4wT3Go2ZDDFK1Dom5VGmwjZE0cc47cE8dQ6Uxd+GMhK3z9CEYy6MEVSXNOQ6QTQx4c+YWFonOc7kcr49vMofxbphdPolmrpDX7R0TK5pNIBKQ/71QprA0/7/5aeD0f2fTARMFpF3dd4FESkdgCNxD5sh2L8jZKkzMBtRb3zTEfKgHKkb26d+j9w9rDfmq54cmxxig+8i0mozzv9QDCx7ZQS2hvsnu8kv6+7mduppnEMaQEi9Sb4YlFsgmgZUDICp3OV433gvby9dH9AdEVw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=3EXQpTdl3vySurWP/Ig0nJ165OAD/mbvn9iQcC5noqc=;
 b=DBUV7D4IAfK2jzfkmkj7xupmqqSZVEBMcIsHkxO8vRDD45M2QffxnCauO+qbmF0Zd6UU/d497Sn+qj4ksjlzoFFTXLLE7F4PlAxH6bFFiZM5wcJb7lYU+fRpV3yXJ5R+vIixQPKdWWCSRhRqK7P4wtrrBWo+ReVNW5V27nXxvd6bloEWTOeowfAHgec0IN7crBvyQNdJcsF9YVpGV3At7zNnWUe2/dfqN82FhMKEawuqAA8fa0s7OfifnaiPJN0hUvegON5gMfAEUTJLyff0Ianz2bbRWlayux0ztwDm3+0A0Gn9IWQ82yAib0l+mshL26xORfDKtogdJeJHa8ww8g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=3EXQpTdl3vySurWP/Ig0nJ165OAD/mbvn9iQcC5noqc=;
 b=qzX58h5iPTuutOD1pCX5ceq7JB0wJd4l40xAqaR9unXnvYVjXMM5jwfpEo6OwjCij8mi/fmiM86j+uTOpalypvUxIZlGoElbE8iuTDtQbm07DP77qjYF3yJOWSMVZ+9qJj4SiargcaCpUSpmIMvDeuB+FD50pvzHMVuHLvRGeAkv1H7wDk3WXZslfpLEVgndR3D6qgJUgZhQ44zbCO3qP7wR6SUu61Mles7tuLbtnnzLcH5xbjim7sDOnUHo1dTg7qD6ZesBp+ioMa5QhxUrc95X2NfxsplZfEyqQLx9zOBtfwdeWY/TZbXPx0Qb5wYTNn2A5o+BvVcKstmmhqF2Kg==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?=
	<roger.pau@citrix.com>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v5 09/14] vpci/header: emulate PCI_COMMAND register for
 guests
Thread-Topic: [PATCH v5 09/14] vpci/header: emulate PCI_COMMAND register for
 guests
Thread-Index: 
 AQHX4ewK3mPSKCsK30iVfRQpWoVIB6xhEugAgB+P6YCAAAvvAIAABD6AgAAIlwCAAAJMgIAAAWUAgAAJGIA=
Date: Wed, 2 Feb 2022 15:04:00 +0000
Message-ID: <4fb06bb7-442f-e041-ef95-daec81e1d3a0@epam.com>
References: <20211125110251.2877218-1-andr2000@gmail.com>
 <20211125110251.2877218-10-andr2000@gmail.com>
 <YeAD9PH9o65o+M+w@Air-de-Roger>
 <6a31eb29-81b6-7553-897f-2e5e54bab9b8@epam.com>
 <d527740a-4d90-4155-13dc-5888e8acfa72@suse.com>
 <b9661d86-f084-9ad1-59d5-538113000393@epam.com>
 <ab68568c-461e-bef5-4218-07db8e837bcc@suse.com>
 <37313b25-ccbe-fbfd-8306-7a96ce83c818@epam.com>
 <f93d4d54-a2ac-67c0-8a04-d8321b0828e5@suse.com>
In-Reply-To: <f93d4d54-a2ac-67c0-8a04-d8321b0828e5@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: e6b17009-0abb-432f-149e-08d9e65d3e92
x-ms-traffictypediagnostic: AM7PR03MB6449:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM7PR03MB64492AFD46EBFA409207E78EE7279@AM7PR03MB6449.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 FhYuWAr+BSNYWYzkkmYqiZFc46pMhj5ZN6WSCQNJzvan3YWc5D1js77I4c0BUMimOxsHzV5xAiLWt2AM//NFySTPMR7EjFIjHguuv/xb0jSC7U6LBMBwiz5JKyqUwbfZh2+n//pA1I40UlYUgvcBaHXEKvyJijqzEpYnjKjwdCKEPG2hnjU8kp6OthF4EY6EGmDz2NScMIZ6fhRDct7ODWxnRQHavS2EKz4boh41RJdu27cYTDl5rzR6SK5965bMCUH9A1wrTXvCaC3zfpbO2X8NUbBe5TFH7oeQWD6HLAPMDj11rUihDHJG5fzJRrMM/AqMmybCOFZGDuPoqW/iOAA0iwDF/XiOrwV4tMj8vg7qhc0x8ph61kds7ngAJuiTi1niS50qYoDVlcYO4HBZq5iPleJseaKHaVFhjFoCqhpfa5TazcWZ2yzle4m2SP6khdDF26bqHnSVlFvF6KL4VvsTHLGppda8IatHI0m4SN2fsLvlH36tB97VxjUhO3/u70APdPnch37VB/K4KFJDWhWTdyM/p2SfHkuJuTEXyWJO3q6lzA4BDUStvaYGve29FzFcC8razuBErQuCWqjROMsQ6E7DYbBYJ9tj74qaUyJfimKaE0nzyCwLm6JTxcGrhUttknHDLd8AFrfm9v2qdQpqLCkVTljKzyxe0ZjA9Odr/1um0DvYcvHo/m3aDnBpuzptJmufICf5uzWk4rNswZaHlIIzq6Z3j1KucjypHoJD+t5qYP7+C1ylLCIccPS9
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(508600001)(66556008)(7416002)(6486002)(5660300002)(66946007)(53546011)(316002)(6916009)(91956017)(66476007)(122000001)(6512007)(38100700002)(54906003)(76116006)(6506007)(66446008)(64756008)(38070700005)(31696002)(8936002)(36756003)(8676002)(2906002)(71200400001)(83380400001)(31686004)(107886003)(2616005)(186003)(26005)(4326008)(86362001)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?Smk4a2diL00wbzZSOThyMkVZTTNQOVVtYUozSllmTXFFdlVISC93c0FVcW8y?=
 =?utf-8?B?K2tnTU1PSmhua0RwVjFkejB0VURoVzZYMkdGZnlmMDN4YktISnJEcm9UNzF0?=
 =?utf-8?B?SEpKL21mSHNMRllJMDVYKzhxTUxNTkk3WVpFOFVlZjllVW5kb2VTN0gwNnZh?=
 =?utf-8?B?elc2VWI2dlhmNExZZEJYbm9wMUhXSnVqRjF3aXkwcnM2WGlZL2ptdDE5SFds?=
 =?utf-8?B?VTkvbW00L1JnK0wrdEJ6aDVCSGZHbUZGUG5nZVRzZ2lVNXZiNjdWYWs4eUZK?=
 =?utf-8?B?SVdBblh5dzN4cGFJZm93eEUzZTZjbEx5MnVRVUw2dWhLMmIyUGFaM1p5OERP?=
 =?utf-8?B?aW5KNnJGS2lqdkZ6cEdDTWxpbDBSdFhlbkRmdVVqN1pxeVk5aENaSTJNKzZP?=
 =?utf-8?B?Ri9mSzZJOGdxUUc5d05XSXQ1RVZKalVNeDRrdTMrY3J6ekM2VGVqN1dXRW9m?=
 =?utf-8?B?eFhSdFlOQ3R4d1FiMDQzL25FNDNPYUxsS0hmSE9STFJJTXF5ZjN2UVZWQ0lR?=
 =?utf-8?B?SnB1OVVVSkF2Y0J2bktuODJ4d1JnQXZXV3VVbGVMbkxOL2J3ek9IUUtia0FL?=
 =?utf-8?B?c3hBTUF4ZlNvNk16cEU3eS9CVi9DaWdsc1VuQWRwZkxxMEw0M1dNbDcxeXNG?=
 =?utf-8?B?QXJzOGJrdU1qRjAwQ2tVM1B0eThYcHk5ZHg2bVI1UEdhTHZQSmkzeHg5LzJT?=
 =?utf-8?B?RHhzT3dTeGk0MHRvWVl5d0JGTlNzRzByb0xnaFpWMC9kRjEvU21FUS9La2Rh?=
 =?utf-8?B?WmRXU2pRd0JlWldEU0xEL25mRGExcWIyaUQvRnVQeE9YdXY4RUF2VVdxOTlG?=
 =?utf-8?B?Q2JoblRxc2pLZU5BaFVJU3M3ZlFwdzFGaWFKVlVWNTJGdFJhVWtqZWFGR0Fh?=
 =?utf-8?B?U0tQcWRjOUxwdTVwSGlZaitQaVV5S2hvRFo3QThOaFFERzlZUkFYV29hWjlC?=
 =?utf-8?B?UkpmczBmNmtVN29QTWR6eGtrM0dCQ2grNVI0dXA1S0VyTGlLb3hzaGFob2Fo?=
 =?utf-8?B?RHhzeWpNOVhhdEFZYVM0dnk5SEUwa0pSVzNIbE5wdS9JaHdYcEJzRW5ySlFo?=
 =?utf-8?B?cHd3S09MMXJiSzhpeFpVREFnSFFnV1p6V2tWMmdrdWo4Z2ZNZ2xTaldhaURP?=
 =?utf-8?B?T21MSEJGZUlkOUNCRkhsU1dBdXY3c3hTK1hYL3JLTnp1dDNxbGU1dFI1Q1dX?=
 =?utf-8?B?TUhHdEhZVFRQc09veUYvSUFwYTU4WXNzbTY1dXJzZ2I4VVpodjBGQVNRcVdF?=
 =?utf-8?B?dXNOeWUvSkZ0ZkJoa3hHRVZ0SSthbXVhTm1xTEFRTEhPK3k0MVZTSzQ5Y3Vq?=
 =?utf-8?B?Rkw5ZlI4ZUkzck1ybDRIQ1dpN05HdUp5RURrME1BamdWME9CdlF3NlRXbWVu?=
 =?utf-8?B?QkFQazlWWnpkUVZpWDduc1N0cEgvdzZUZUs0b2dTMTg4dlZIazV3YWVVRmJL?=
 =?utf-8?B?RFBHeGJsOHhZcU14RFZVU1BQY1hnTk1LejFaSmtWOU9vUVh1SnQwS1F4WjRF?=
 =?utf-8?B?OG5CVEZBVEhYQXdiMjF3MjZKTmMweWhLWTNIKzdQaDJ2VWIyOWV3UEM0NDk1?=
 =?utf-8?B?NThkT2s0STZVbVdrUmF0Q3hhQjdROTAzeEI1VlZQckJoVVgvN3ZJdHpZSmpW?=
 =?utf-8?B?bFErK05NeGhOaW1sUW5hOWZuUVhzVGR0ZnU0N0hPd3UveVRrZ3hnOXpYZ253?=
 =?utf-8?B?cDIyVUdSc0hFNXZYK3gvbmtiTjJnSjBJWTczeEVkZFVrMUFNWjFiUmdCbDRX?=
 =?utf-8?B?RXl4TEt2ekN3QnFEdytGb1R4RVpsRHpJdGpicTYwYkZSSDA4cXhVbGZpT25L?=
 =?utf-8?B?bFhraUczclBKcSsvMkRHWWVLVHBWeUJEeTJmbWhsOUhoMzBRdGRyOHlmSGNS?=
 =?utf-8?B?dzUyQWZ3VlhPTXVONFFIWUpLSk9pRWtsbGVNcHJWS3R2NUlaUjFKRE15Y2I2?=
 =?utf-8?B?OXJja2VDZHJudXdSaFh4bktSRldta3JkZzByamdoL3RnVTAzditaZ0VsdDFS?=
 =?utf-8?B?amc2SU8wam5tbi9YUDVGOGdmQ3MvNjMxR0NwdHpSNndkdTYwNndxNkx5UkZG?=
 =?utf-8?B?dHFFZWNZaUs1c216VHQ4MWxBcGxuWFFSd1g4TStHQWZOdXdCbWJ5WUppU212?=
 =?utf-8?B?dnVRaHR1V2ptQmlnR0FVYWVLQmZaTXkzMVNwV1BGMTFDNXR2b2p6TGxYTmY1?=
 =?utf-8?B?ZjBvWHJBVlNJRktnT0I5NGxINFhDMVJXWHVSZ215SnhLSzNyRDFHVkpLcE05?=
 =?utf-8?B?cXhvTFpSRGhEb3JRWURZcGh4UkRhbDM3b2RSRjBYRWJrWXplTkVPczg2TTVL?=
 =?utf-8?B?SHFkYjgzeHlCQitpNnIxNEMwZm4wQ0pTVmxER2RNUWF1b1p1eXovZz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <A5E6063C5860074C946135552DF88455@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e6b17009-0abb-432f-149e-08d9e65d3e92
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Feb 2022 15:04:00.4962
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 34AbWKsBpNsRsqI8W2izk9iHfTWz0MAWddHtEjj+eSk3ZOdebrCKfjUYYgW0hS4RVrjODQtCQ22kWory8KPDol6gr1UN0TGrf+GnBPicOvoouiX4/UGuPMLfZN91o8Zq
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR03MB6449
X-Proofpoint-ORIG-GUID: L95Nq_gZJjbmkbTtN-LWEYY2szv1eHw9
X-Proofpoint-GUID: L95Nq_gZJjbmkbTtN-LWEYY2szv1eHw9
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-02_07,2022-02-01_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 clxscore=1015
 adultscore=0 mlxlogscore=999 phishscore=0 priorityscore=1501 spamscore=0
 impostorscore=0 suspectscore=0 mlxscore=0 lowpriorityscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2202020084

DQoNCk9uIDAyLjAyLjIyIDE2OjMxLCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMDIuMDIuMjAy
MiAxNToyNiwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+Pg0KPj4gT24gMDIuMDIu
MjIgMTY6MTgsIEphbiBCZXVsaWNoIHdyb3RlOg0KPj4+IE9uIDAyLjAyLjIwMjIgMTQ6NDcsIE9s
ZWtzYW5kciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4+Pj4gT24gMDIuMDIuMjAyMiAxMzo0OSwg
T2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+Pj4+Pj4gT24gMTMuMDEuMjIgMTI6NTAs
IFJvZ2VyIFBhdSBNb25uw6kgd3JvdGU6DQo+Pj4+Pj4+IE9uIFRodSwgTm92IDI1LCAyMDIxIGF0
IDAxOjAyOjQ2UE0gKzAyMDAsIE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4+Pj4+
Pj4gLS0tIGEveGVuL2RyaXZlcnMvdnBjaS9oZWFkZXIuYw0KPj4+Pj4+Pj4gKysrIGIveGVuL2Ry
aXZlcnMvdnBjaS9oZWFkZXIuYw0KPj4+Pj4+Pj4gQEAgLTQ5MSw2ICs0OTEsMjIgQEAgc3RhdGlj
IHZvaWQgY21kX3dyaXRlKGNvbnN0IHN0cnVjdCBwY2lfZGV2ICpwZGV2LCB1bnNpZ25lZCBpbnQg
cmVnLA0KPj4+Pj4+Pj4gICAgICAgICAgICAgIHBjaV9jb25mX3dyaXRlMTYocGRldi0+c2JkZiwg
cmVnLCBjbWQpOw0KPj4+Pj4+Pj4gICAgICB9DQo+Pj4+Pj4+PiAgICAgIA0KPj4+Pj4+Pj4gK3N0
YXRpYyB2b2lkIGd1ZXN0X2NtZF93cml0ZShjb25zdCBzdHJ1Y3QgcGNpX2RldiAqcGRldiwgdW5z
aWduZWQgaW50IHJlZywNCj4+Pj4+Pj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgdWlu
dDMyX3QgY21kLCB2b2lkICpkYXRhKQ0KPj4+Pj4+Pj4gK3sNCj4+Pj4+Pj4+ICsgICAgLyogVE9E
TzogQWRkIHByb3BlciBlbXVsYXRpb24gZm9yIGFsbCBiaXRzIG9mIHRoZSBjb21tYW5kIHJlZ2lz
dGVyLiAqLw0KPj4+Pj4+Pj4gKw0KPj4+Pj4+Pj4gKyNpZmRlZiBDT05GSUdfSEFTX1BDSV9NU0kN
Cj4+Pj4+Pj4+ICsgICAgaWYgKCBwZGV2LT52cGNpLT5tc2ktPmVuYWJsZWQgKQ0KPj4+Pj4+PiBZ
b3UgbmVlZCB0byBjaGVjayBmb3IgTVNJLVggYWxzbywgcGRldi0+dnBjaS0+bXNpeC0+ZW5hYmxl
ZC4NCj4+Pj4+PiBJbmRlZWQsIHRoYW5rIHlvdQ0KPj4+Pj4+Pj4gKyAgICB7DQo+Pj4+Pj4+PiAr
ICAgICAgICAvKiBHdWVzdCB3YW50cyB0byBlbmFibGUgSU5UeC4gSXQgY2FuJ3QgYmUgZW5hYmxl
ZCBpZiBNU0kvTVNJLVggZW5hYmxlZC4gKi8NCj4+Pj4+Pj4+ICsgICAgICAgIGNtZCB8PSBQQ0lf
Q09NTUFORF9JTlRYX0RJU0FCTEU7DQo+Pj4+Pj4+IFlvdSB3aWxsIGFsc28gbmVlZCB0byBtYWtl
IHN1cmUgUENJX0NPTU1BTkRfSU5UWF9ESVNBQkxFIGlzIHNldCBpbiB0aGUNCj4+Pj4+Pj4gY29t
bWFuZCByZWdpc3RlciB3aGVuIGF0dGVtcHRpbmcgdG8gZW5hYmxlIE1TSSBvciBNU0lYIGNhcGFi
aWxpdGllcy4NCj4+Pj4+PiBJc24ndCBpdCBlbm91Z2ggdGhhdCB3ZSBqdXN0IGNoZWNrIGFib3Zl
IGlmIE1TSS9NU0ktWCBlbmFibGVkIHRoZW4gbWFrZQ0KPj4+Pj4+IHN1cmUgSU5UWCBkaXNhYmxl
ZD8gSSBhbSBub3QgZm9sbG93aW5nIHlvdSBoZXJlIG9uIHdoYXQgZWxzZSBuZWVkcyB0bw0KPj4+
Pj4+IGJlIGRvbmUuDQo+Pj4+PiBObywgeW91IG5lZWQgdG8gZGVhbCB3aXRoIHRoZSBwb3RlbnRp
YWxseSBiYWQgY29tYmluYXRpb24gb24gYm90aA0KPj4+Pj4gcGF0aHMgLSBjb21tYW5kIHJlZ2lz
dGVyIHdyaXRlcyAoaGVyZSkgYW5kIE1TSS9NU0ktWCBjb250cm9sIHJlZ2lzdGVyDQo+Pj4+PiB3
cml0ZXMgKHdoaWNoIGlzIHdoYXQgUm9nZXIgcG9pbnRzIHlvdSBhdCkuIEkgd291bGQgbGlrZSB0
byBzdWdnZXN0DQo+Pj4+PiB0byBjb25zaWRlciBzaW1wbHkgZm9yY2luZyBJTlRYX0RJU0FCTEUg
b24gYmVoaW5kIHRoZSBndWVzdCdzIGJhY2sNCj4+Pj4+IGZvciB0aG9zZSBvdGhlciB0d28gcGF0
aHMuDQo+Pj4+IERvIHlvdSBzdWdnZXN0IHRoYXQgd2UgbmVlZCB0byBoYXZlIHNvbWUgY29kZSB3
aGljaCB3aWxsDQo+Pj4+IHdyaXRlIFBDSV9DT01NQU5EIHdoaWxlIHdlIHdyaXRlIE1TSS9NU0kt
WCBjb250cm9sIHJlZ2lzdGVyDQo+Pj4+IGZvciB0aGF0IGtpbmQgb2YgY29uc2lzdGVuY3k/IEUu
Zy4gY29udHJvbCByZWdpc3RlciBoYW5kbGVyIHdpbGwNCj4+Pj4gbmVlZCB0byB3cml0ZSB0byBQ
Q0lfQ09NTUFORCBhbmQgZ28gdGhyb3VnaCBlbXVsYXRpb24gZm9yDQo+Pj4+IGd1ZXN0cz8NCj4+
PiBFaXRoZXIgY2hlY2sgb3Igd3JpdGUsIHllcy4gU2luY2UgeW91J3JlIHNldHRpbmcgdGhlIGJp
dCBoZXJlIGJlaGluZA0KPj4+IHRoZSBndWVzdCdzIGJhY2ssIHNldHRpbmcgaXQgb24gdGhlIG90
aGVyIHBhdGhzIGFzIHdlbGwgd291bGQgb25seQ0KPj4+IGxvb2sgY29uc2lzdGVudCB0byBtZS4N
Cj4+IEkgY2FuJ3QgZmluZCBhbnkgYWNjZXNzIHRvIFBDSV9DT01NQU5EIHJlZ2lzdGVyIGZyb20g
dk1TSS92TVNJLVgNCj4+IGNvZGUsIHNvIHdoYXQncyB0aGUgY29uY2Vybj8NCj4gQWdhaW46IE9u
bHkgb25lIG9mIElOVFgsIE1TSSwgb3IgTVNJLVggbWF5IGJlIGVuYWJsZWQgYXQgYSB0aW1lLg0K
VGhpcyBpcyBjbGVhciBhbmQgSSBkb24ndCBxdWVzdGlvbiB0aGF0DQo+IFRoaXMgbmVlZHMgdG8g
YmUgY2hlY2tlZCB3aGVuZXZlciBhbnkgb25lIG9mIHRoZSB0aHJlZSBpcyBhYm91dA0KPiB0byBj
aGFuZ2Ugc3RhdGUuIFNpbmNlIGZhaWxpbmcgY29uZmlnIHNwYWNlIHdyaXRlcyBpc24ndCByZWFs
bHkNCj4gYW4gb3B0aW9uICh0aGVyZSdzIG5vIGVycm9yIGNvZGUgdG8gaGFuZCBiYWNrIGFuZCBy
YWlzaW5nIGFuDQo+IGV4Y2VwdGlvbiBpcyBub3RoaW5nIHJlYWwgaGFyZHdhcmUgd291bGQgZG8p
LCBhZGp1c3Rpbmcgc3RhdGUgdG8NCj4gYmUgc2FuZSBiZWhpbmQgdGhlIGJhY2sgb2YgdGhlIGd1
ZXN0IGxvb2tzIHRvIGJlIHRoZSBsZWFzdCBiYWQNCj4gb3B0aW9uLg0KV291bGQgaXQgYmUgZW5v
dWdoIGlmIEkgcmVhZCBQQ0lfTVNJWF9GTEFHU19FTkFCTEUgYW5kDQpQQ0lfTVNJX0ZMQUdTX0VO
QUJMRSBpbiBndWVzdF9jbWRfd3JpdGUgdG8gbWFrZSBhDQpkZWNpc2lvbiBvbiBJTlRYPw0KDQpP
biB0aGUgb3RoZXIgaGFuZCBtc2ktPmVuYWJsZWQgYW5kIG1zaXgtPmVuYWJsZWQNCmFscmVhZHkg
aGF2ZSB0aGlzIGluZm9ybWF0aW9uIGlmIEkgdW5kZXJzdGFuZCB0aGUNCk1TSS9NU0ktWCBjb2Rl
IGNvcnJlY3RseS4NCg0KT3IgZG8gd2Ugd2FudCBzb21lIGFkZGl0aW9uYWwgY29kZSBpbiBNU0kv
TVNJLVgncyBjb250cm9sX3dyaXRlDQpmdW5jdGlvbnMgdG8gc2V0IElOVFggYml0IHRoZXJlIGFz
IHdlbGw/DQoNCkkgbWVhbiB0aGF0IGluIHRoaXMgZ3Vlc3RfY21kX3dyaXRlIGhhbmRsZXIgd2Ug
Y2FuIG9ubHkgc2VlDQppZiB3ZSB3cml0ZSBhIGNvbnNpc3RlbnQgd3J0IE1TSS9NU0ktWCBQQ0lf
Q09NTUFORCB2YWx1ZQ0KDQpJZiB3ZSB3YW50IHNvbWUgbW9yZSBjaGVja3Mgd2hlbiB3ZSBhbHRl
ciBQQ0lfTVNJWF9GTEFHU19FTkFCTEUNCmFuZC9vciBQQ0lfTVNJX0ZMQUdTX0VOQUJMRSBiaXRz
LCB0aGlzIG1lYW5zIHdlIG5lZWQgYSByZWxldmFudA0KUENJX0NPTU1BTkQgd3JpdGUgdGhlcmUg
dG8gYmUgYWRkZWQgKHdoaWNoIGRvZXNuJ3QgZXhpc3Qgbm93KQ0KdG8gbWFrZSBzdXJlIElOVFgg
Yml0IGlzIHNldC4NCg0KUGxlYXNlIGhlbHAgbWUgdW5kZXJzdGFuZCBob3cgeW91IGdlbnRsZW1l
biB3YW50IGl0DQo+DQo+PiBUaGlzIHNlZW1zIHRvIGJlIHRoZSBvbmx5IHBsYWNlIGluIHZQQ0kg
d2hpY2ggdG91Y2hlcyBQQ0lfQ09NTUFORCByZWdpc3Rlci4NCj4gSG93IGlzIHRoaXMgcmVsZXZh
bnQ/DQo+DQo+IEphbg0KPg0KVGhhbmsgeW91LA0KT2xla3NhbmRy


From xen-devel-bounces@lists.xenproject.org Wed Feb 02 15:08:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 15:08:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264302.457351 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFHFH-0003nd-V6; Wed, 02 Feb 2022 15:08:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264302.457351; Wed, 02 Feb 2022 15:08:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFHFH-0003nW-S2; Wed, 02 Feb 2022 15:08:31 +0000
Received: by outflank-mailman (input) for mailman id 264302;
 Wed, 02 Feb 2022 15:08:30 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=6WyI=SR=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nFHFG-0003nN-87
 for xen-devel@lists.xenproject.org; Wed, 02 Feb 2022 15:08:30 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id fa41519b-8439-11ec-8eb8-a37418f5ba1a;
 Wed, 02 Feb 2022 16:08:29 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2173.outbound.protection.outlook.com [104.47.17.173]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-41-aPEP3yAlNtKkTk7dwbn47A-1; Wed, 02 Feb 2022 16:08:27 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM0PR04MB6209.eurprd04.prod.outlook.com (2603:10a6:208:13a::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Wed, 2 Feb
 2022 15:08:25 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.012; Wed, 2 Feb 2022
 15:08:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fa41519b-8439-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1643814508;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=ThYbJT0IgisMLHZ/euYfCsDOZ0Y0F3i6dvBsHAQaIV4=;
	b=UVFei1x7oKXRCOfDuvXVmdbcEdeFwU/3R/I3c4jpX9K04Skyz0cA4XVLwEjYhDqBTbVimB
	WW8HLgv8CaimcdceaILrKd3D0fNYAbeYoRvSKEt8HIJEkgcE8SaJd2xbm9rg6iGLkgLVZX
	uWZaexMon332rMGonQ6QLeSOtRcqhPI=
X-MC-Unique: aPEP3yAlNtKkTk7dwbn47A-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=L7hTUaPS16wkbiOoKK39GXFocFDiBxANUhQQs7jgKeOk9tkubPbn8/u+2uq2Yjyu3T3Ac/uEIlLsMqrN3CtIz6hDtiKnlRctKetmZYJrGsC43SOv/HnUG9WF5m4iPC212FhB0bR1LtfT4UJ/qc3qcXmPGo3ZZvhDtSVpyJ86a0BtXdHfDl9EaABa0YdV2Cw1GQH/ZRZLIPHGO1097KxmSYm5FH4/EgJa5Z5mj/uro6IMy0rszv3aPzT0+2eNa7HLE7XenNR9vpImbauvwu2mrFmHYRxHJZfEVkI3/N1r39e7/31Us/On+NBzEUUw5aidNkcGvrfWGQ/hXWzystIHaA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=9QbiUjGSTTJqOTiUgoBgq3ceIp0qh/vJbe085BXrORo=;
 b=IIdfCiLM/p7FCR9M599vBsJeCruU7pIP67sAbLsfG+p8XkV6WleFHw7bHN4fDUHGmrsjRDL0K7ErJvB78IYJA8aSl76nE0RB9On1iJLJxpk5c2DgZoIdDY/w3z8WrPrvuKpBiH8l83/LJINwElDArnPFKvfhd6jLtDDKFnpQ24AV8boV7Gcp/rKRtqFXQQw+u/PO9cYd6X7s0rOWKggwuNS9s51mc4dlER/tcmysyvb8Mt7VmEceWfupoEQ/HnpmdOTQWpeOBvUTiDhHdp+lm6HjIl/acHY8D8DbZ13KZMad/X/NU01jIiMa6WjBncsmnxanIqVDuBn4nmvGWhHZ5w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <3f75acfe-bb88-5982-5f8e-04e0d1755c1a@suse.com>
Date: Wed, 2 Feb 2022 16:08:22 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v5 09/14] vpci/header: emulate PCI_COMMAND register for
 guests
Content-Language: en-US
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "julien@xen.org" <julien@xen.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Artem Mygaiev <Artem_Mygaiev@epam.com>,
 "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
 "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
 "paul@xen.org" <paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>
References: <20211125110251.2877218-1-andr2000@gmail.com>
 <20211125110251.2877218-10-andr2000@gmail.com>
 <YeAD9PH9o65o+M+w@Air-de-Roger>
 <6a31eb29-81b6-7553-897f-2e5e54bab9b8@epam.com>
 <d527740a-4d90-4155-13dc-5888e8acfa72@suse.com>
 <b9661d86-f084-9ad1-59d5-538113000393@epam.com>
 <ab68568c-461e-bef5-4218-07db8e837bcc@suse.com>
 <37313b25-ccbe-fbfd-8306-7a96ce83c818@epam.com>
 <f93d4d54-a2ac-67c0-8a04-d8321b0828e5@suse.com>
 <4fb06bb7-442f-e041-ef95-daec81e1d3a0@epam.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <4fb06bb7-442f-e041-ef95-daec81e1d3a0@epam.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6PR10CA0088.EURPRD10.PROD.OUTLOOK.COM
 (2603:10a6:209:8c::29) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 1a20dec7-aaaf-4ef5-8388-08d9e65ddc09
X-MS-TrafficTypeDiagnostic: AM0PR04MB6209:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB6209F3D3DB2FC32454DD1845B3279@AM0PR04MB6209.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	1DRm1KA4imnDF7At5+Yoqfv27KW5H4tZOniAKgRnnob903WhCCZrsSeSvzNKhVU6uHmXPrXCXcGhNjG0xOF+PHMvmAFlTUsJEEu1DjI9gBfmkghTE8bR4WLU1yXNGv26ETUCfgAVZvdU2evZmDL4o//CiH5nwoTLZyz5nETrmSt3u3Ki6UKfXSsaSVVHyUdbr6VzcXxmf+ZD3f+LY2ZUUDvx37O6ZkngKzy20PX70z9qlAQ7mY00M4gimvTqr8Fit8OQAGUe7XHMIFGHJKsK4RA6Kv+y5i86yIHbwJtL5HR7SFRcKQyRG0uHXvT7f3CFG8ydjz6Zphbez1a13d5MRpEBbqey5rDka3++c+roF2LC2ke9ONhciMRKYArpaWdeGLDJD+GZxPcvKUj3qQpwBj9zE67B2FzEwWfQtkFNVeHb/ONjm1uoW+zefA1v+ODl65vdLkr5DLsX8YpCnkT1tgHE2H8kVmRVZMRY7d6bW3LcBbMzNB92vXGJdbGg3Nf7PnVuptE2Vk9wBgKEpZiGACKXzux3YIMBvXCjiAiI4k/vXoyrYKsS//LEsn8OYTqwVBR7EluqyNjsY+WAOeW44yTTNQxOREGS+ar5wPuy14wS/7Gmi4oHSi5hLEnxKgsV3HzKei6V+eSBOlLVlyhh4GS1eJ+ov8q06xmnZU8gPM9NniFQgOrhZTp4v9c8iNmazGP0UcyhFJo0xicWlDQqRM1/2Tp05LJKOO6/0BemPfg=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(83380400001)(36756003)(54906003)(6916009)(2906002)(8936002)(6512007)(66476007)(66946007)(86362001)(66556008)(4326008)(38100700002)(31696002)(8676002)(508600001)(31686004)(316002)(7416002)(2616005)(5660300002)(186003)(26005)(6486002)(6506007)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?2C72zXBW/UK3dBBubSEs4Q8rtca9nK7WpkEVIvbFNERZ9YpxDXIKcuvXOGYX?=
 =?us-ascii?Q?DtWPwi5WNO5dNarg3wxtsq/gBd58P66DgdvVDOLyUSM3Mhd5IzVsxix1Blsg?=
 =?us-ascii?Q?KXg/dFQEkPjU5BjAX8RCuTIB2pcmQ9rLFf+iG3XksVPHkrfPf1dbVDQcAzDx?=
 =?us-ascii?Q?bOEvJflBotMJaBKbm7h4ah34kfD7mxa0tSbtXSWkDJUJ3lFb+pMtPQpqSKAc?=
 =?us-ascii?Q?jARaWLJsb0OGMiBERbiwqAXOtVxkJT4O+3n6IlE9ppntRcxqzFPC+h9jze/s?=
 =?us-ascii?Q?/GWhlN7oLITjBN4BGuHmmtmJTZa1HhgbjK/0EpRW1miwo9ckxzXuTGuKpa/G?=
 =?us-ascii?Q?afNYp29+BKnbMWrTVc6TjdVNvjeBdH7t/4BBh52OlOOcfLHwQu/LNNftn4Jb?=
 =?us-ascii?Q?szGOtlP5RynfqhSxDob87OWGZfk3wOHGg2x8iy3nglSLP6E8kTJUAe0z61P9?=
 =?us-ascii?Q?/USc5H2bn9mYVACp2vQWDSO496dlZ5cYHC3NgvtwkhsYXH6fOJ6/5wyNFNsf?=
 =?us-ascii?Q?fFv+KLvjcPW3WVtlMfV5vDTXhDuVZRR26jHsyTYAE6kCApT/+5dc056zajuf?=
 =?us-ascii?Q?gzWDKBoyVY/WvY/l+4xttIqLxheXDpwFadH6Y0/icrigiUiQzcVCt3tlTij4?=
 =?us-ascii?Q?UrRjGYhduT6EtA+jd5e319DooH5rHu6WDZZvJqb6a82JxJJcvw0yyREO67h2?=
 =?us-ascii?Q?mDK8DnEWTgleCx4wCZqknAZaIDMhSOfKSlBGKUPmMjXDqrdC6Bf74Sy7oBKS?=
 =?us-ascii?Q?pP98ChdwU4VCx8w1H3FKalAIUiHnZyaLokxTBCwbJQEWdzDfhciYcxAWtAxe?=
 =?us-ascii?Q?8E9YsZL1M/sJfw186jtSeJOCyRZjtAOasp80o1gE5yQuvHnzdNkukk6s97+c?=
 =?us-ascii?Q?5rtXq1sKQsJbDChdyxXzuLyZNREJBMq0+u/Q0MKw+ZyRPfFm6NNzQ8pW5ah5?=
 =?us-ascii?Q?vWK1s9IrSVsa6Or1ZfFTWwnIB1K24yNC0JQiW/zrciet4OosswL0a9yk9a4Q?=
 =?us-ascii?Q?jd/6+RUOoYa5/Gc/MUuA60rluXmwLu6eazo1hy4FtrwMD1q6VsJpJ/hrc0BX?=
 =?us-ascii?Q?UZC73jafcGQD3QRgwN6cF8Jj77NgMogc4/LyeXg8xSKSjYCB9l75QGr+Nwga?=
 =?us-ascii?Q?q7G5xjK3Tg5GFkkRvv6ZjnXM0ChWeaCQ6MRefUPIruATAvfbFYm8PFF6ReXL?=
 =?us-ascii?Q?/+3LRLQM2oiW1hXLbTd+JStyPkT4kWkTpMD4zGAhKDZS2u8gaQjbl/y9yKI0?=
 =?us-ascii?Q?fbZmMscmkpQ0z5UZyt0rTWRbpvVgA24SmeNFFEVHA3G1LNwV8GUTzdDj/OrI?=
 =?us-ascii?Q?7yE0yos14tBA/n5Ak7BeMvpkWwrKiVqTnRayBt3FN9mhOfdiB0sd1gga5SjE?=
 =?us-ascii?Q?Vx5EeEKRkAqccaw2Q1lTfBfR3qyY03+WaRYk7PW52vE7upFQFLGvzr+IwLG9?=
 =?us-ascii?Q?iV4ZAecijQqSMOxzu07nD1UmB6w1Ge1CCelLg/XiBt9Dv/KEkXSQO8ca9YQ2?=
 =?us-ascii?Q?D0oJZLte2ItqvTFOTclCtJ8LTAcQulQLPcyOR6d0oxQh3vbAU/XRaC4KJC4a?=
 =?us-ascii?Q?nKkzWxhztC4YSHLZLLNj95RNi3Ul1mmWkYjeSUEcsft4UY2uD6WOFW5ytjgl?=
 =?us-ascii?Q?NbuMfmORtb2gqNXH+tW5X48=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1a20dec7-aaaf-4ef5-8388-08d9e65ddc09
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2022 15:08:24.8687
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: S4Ki6bXQok0hEVbYXo5z1Rd0/on0IFDj4UJDHo5J+YDpKoa18GOSt9ZcPPDuGxrpWh1gNBRZ4swt0kwotibFmw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6209

On 02.02.2022 16:04, Oleksandr Andrushchenko wrote:
>=20
>=20
> On 02.02.22 16:31, Jan Beulich wrote:
>> On 02.02.2022 15:26, Oleksandr Andrushchenko wrote:
>>>
>>> On 02.02.22 16:18, Jan Beulich wrote:
>>>> On 02.02.2022 14:47, Oleksandr Andrushchenko wrote:
>>>>>> On 02.02.2022 13:49, Oleksandr Andrushchenko wrote:
>>>>>>> On 13.01.22 12:50, Roger Pau Monn=C3=A9 wrote:
>>>>>>>> On Thu, Nov 25, 2021 at 01:02:46PM +0200, Oleksandr Andrushchenko =
wrote:
>>>>>>>>> --- a/xen/drivers/vpci/header.c
>>>>>>>>> +++ b/xen/drivers/vpci/header.c
>>>>>>>>> @@ -491,6 +491,22 @@ static void cmd_write(const struct pci_dev *=
pdev, unsigned int reg,
>>>>>>>>>              pci_conf_write16(pdev->sbdf, reg, cmd);
>>>>>>>>>      }
>>>>>>>>>     =20
>>>>>>>>> +static void guest_cmd_write(const struct pci_dev *pdev, unsigned=
 int reg,
>>>>>>>>> +                            uint32_t cmd, void *data)
>>>>>>>>> +{
>>>>>>>>> +    /* TODO: Add proper emulation for all bits of the command re=
gister. */
>>>>>>>>> +
>>>>>>>>> +#ifdef CONFIG_HAS_PCI_MSI
>>>>>>>>> +    if ( pdev->vpci->msi->enabled )
>>>>>>>> You need to check for MSI-X also, pdev->vpci->msix->enabled.
>>>>>>> Indeed, thank you
>>>>>>>>> +    {
>>>>>>>>> +        /* Guest wants to enable INTx. It can't be enabled if MS=
I/MSI-X enabled. */
>>>>>>>>> +        cmd |=3D PCI_COMMAND_INTX_DISABLE;
>>>>>>>> You will also need to make sure PCI_COMMAND_INTX_DISABLE is set in=
 the
>>>>>>>> command register when attempting to enable MSI or MSIX capabilitie=
s.
>>>>>>> Isn't it enough that we just check above if MSI/MSI-X enabled then =
make
>>>>>>> sure INTX disabled? I am not following you here on what else needs =
to
>>>>>>> be done.
>>>>>> No, you need to deal with the potentially bad combination on both
>>>>>> paths - command register writes (here) and MSI/MSI-X control registe=
r
>>>>>> writes (which is what Roger points you at). I would like to suggest
>>>>>> to consider simply forcing INTX_DISABLE on behind the guest's back
>>>>>> for those other two paths.
>>>>> Do you suggest that we need to have some code which will
>>>>> write PCI_COMMAND while we write MSI/MSI-X control register
>>>>> for that kind of consistency? E.g. control register handler will
>>>>> need to write to PCI_COMMAND and go through emulation for
>>>>> guests?
>>>> Either check or write, yes. Since you're setting the bit here behind
>>>> the guest's back, setting it on the other paths as well would only
>>>> look consistent to me.
>>> I can't find any access to PCI_COMMAND register from vMSI/vMSI-X
>>> code, so what's the concern?
>> Again: Only one of INTX, MSI, or MSI-X may be enabled at a time.
> This is clear and I don't question that
>> This needs to be checked whenever any one of the three is about
>> to change state. Since failing config space writes isn't really
>> an option (there's no error code to hand back and raising an
>> exception is nothing real hardware would do), adjusting state to
>> be sane behind the back of the guest looks to be the least bad
>> option.
> Would it be enough if I read PCI_MSIX_FLAGS_ENABLE and
> PCI_MSI_FLAGS_ENABLE in guest_cmd_write to make a
> decision on INTX?
>=20
> On the other hand msi->enabled and msix->enabled
> already have this information if I understand the
> MSI/MSI-X code correctly.
>=20
> Or do we want some additional code in MSI/MSI-X's control_write
> functions to set INTX bit there as well?

Well, yes, this is what Roger and I have been asking you to add.

> I mean that in this guest_cmd_write handler we can only see
> if we write a consistent wrt MSI/MSI-X PCI_COMMAND value
>=20
> If we want some more checks when we alter PCI_MSIX_FLAGS_ENABLE
> and/or PCI_MSI_FLAGS_ENABLE bits, this means we need a relevant
> PCI_COMMAND write there to be added (which doesn't exist now)
> to make sure INTX bit is set.

Exactly.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Feb 02 15:13:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 15:13:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264309.457362 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFHJg-0005An-HF; Wed, 02 Feb 2022 15:13:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264309.457362; Wed, 02 Feb 2022 15:13:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFHJg-0005Ag-Df; Wed, 02 Feb 2022 15:13:04 +0000
Received: by outflank-mailman (input) for mailman id 264309;
 Wed, 02 Feb 2022 15:13:03 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1p3Q=SR=epam.com=prvs=40324c57ab=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nFHJf-0005Aa-P3
 for xen-devel@lists.xenproject.org; Wed, 02 Feb 2022 15:13:03 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9c7e490d-843a-11ec-8f75-fffcc8bd4f1a;
 Wed, 02 Feb 2022 16:13:02 +0100 (CET)
Received: from pps.filterd (m0174676.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 212F3iBF011355;
 Wed, 2 Feb 2022 15:12:58 GMT
Received: from eur01-db5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2054.outbound.protection.outlook.com [104.47.2.54])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3dyv8sg2y5-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 02 Feb 2022 15:12:57 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM0PR03MB5588.eurprd03.prod.outlook.com (2603:10a6:208:169::24)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Wed, 2 Feb
 2022 15:12:50 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6%3]) with mapi id 15.20.4951.012; Wed, 2 Feb 2022
 15:12:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9c7e490d-843a-11ec-8f75-fffcc8bd4f1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=iISk6llah5Q1WiQXpILThIWfZRZztQmAvu5ciux23swPfdoV6/T0bkAJolum4Cc3THi5JudO3iRaq1rxBmPdnxjPrwtPuRAxBBC4WuhLogeqR1NKW9Pax5bGLbwXEENvVNGlWdOtDK/84l54Z1buOGkYXznBeOb3LhM2wVAw/wq1of4B9lNK8kOPYQHF6DIq4RUYjq5EC41oWNGkgWYli0Cy3cWmEGUl6Ar26OGX23Ax3U3epbnRTX/sLK9wT3JKnPn5av7dTruLBxHCAt1GT7zK+Xse7MLfbvp7GhHe+BI87z+9l/ycJVznI7YNlJ0B99ObD0yezDThnPirQE+YFg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=GgzRHKqqQ2C66rWBFNOEo/b3u7BEPjwLbpKyLxBVUME=;
 b=eHUZKKIREwN903bSHFHTiNY+iYx1d1WfT0nbQEfnX5ssaeKrg0EvFmoIJMn3oCqId5WOSs44aIgoF7aYq05YtjvmV87DrDF4VX8IkZDt/0OpajuA5wS/niaJBfNxyarEyuJV5H2E4ujzsjsX5L63a0sdaVEOyWIWXG9wd/GIZfNWZXDoYLxUCO71cFChXbLEEfv4WjJvf1ryhCwFj20FIK4tUhQscYUaQOicIMmvyS2T9cMEs9k5nPmvLRgV42E35xVwkBbhLR+JzUO8PxtJ43SR3ONDpzf43gPVajg6r98I6LJUAJ7qhhfg3Sx5AmdV9N/IE5eVcAluVqWSTp8DiA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=GgzRHKqqQ2C66rWBFNOEo/b3u7BEPjwLbpKyLxBVUME=;
 b=Lw869QYQCjZy5d0U2NG+84GhguxVIXypANiV5Ng1psVUs9hVM31E2YhmedqWBAGn0D/5ROJIQcHyZfNdIXWiiy46Cz6g6vp43QyN9JlsM5RhX6klKgvMrehW9pxMxabbAjb4nbw2wBS6WoSYkR+d0GxtaWTFNLyPuo+qhdqu1xNG0cNP+r4wkd+LDTLu5N9TMm/TPH7R3nknr5126QrzCIAUcOwkzdvMGSkBX+l53o/fghXYeJgRNi9V0bTzYeJudvGssUApn7oWp0Z/y1aeZk3cqQe5qSRUbPmSQfbiZVFojSgrJOs46wP699Qd/YJq4VZCmXT3lV3y1Ngl/FhKQA==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?=
	<roger.pau@citrix.com>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v5 09/14] vpci/header: emulate PCI_COMMAND register for
 guests
Thread-Topic: [PATCH v5 09/14] vpci/header: emulate PCI_COMMAND register for
 guests
Thread-Index: 
 AQHX4ewK3mPSKCsK30iVfRQpWoVIB6xhEugAgB+P6YCAAAvvAIAABD6AgAAIlwCAAAJMgIAAAWUAgAAJGICAAAE5AIAAAT0A
Date: Wed, 2 Feb 2022 15:12:50 +0000
Message-ID: <6cc0d636-8cbe-22b0-01fe-b43e92ba7a98@epam.com>
References: <20211125110251.2877218-1-andr2000@gmail.com>
 <20211125110251.2877218-10-andr2000@gmail.com>
 <YeAD9PH9o65o+M+w@Air-de-Roger>
 <6a31eb29-81b6-7553-897f-2e5e54bab9b8@epam.com>
 <d527740a-4d90-4155-13dc-5888e8acfa72@suse.com>
 <b9661d86-f084-9ad1-59d5-538113000393@epam.com>
 <ab68568c-461e-bef5-4218-07db8e837bcc@suse.com>
 <37313b25-ccbe-fbfd-8306-7a96ce83c818@epam.com>
 <f93d4d54-a2ac-67c0-8a04-d8321b0828e5@suse.com>
 <4fb06bb7-442f-e041-ef95-daec81e1d3a0@epam.com>
 <3f75acfe-bb88-5982-5f8e-04e0d1755c1a@suse.com>
In-Reply-To: <3f75acfe-bb88-5982-5f8e-04e0d1755c1a@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 76529cef-fbb9-4341-f0df-08d9e65e7a4a
x-ms-traffictypediagnostic: AM0PR03MB5588:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM0PR03MB5588A22949C909D03CF88999E7279@AM0PR03MB5588.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 +h/vWnIoznwSg/J0RGlbZJuD4yeIruf4xEca3BOM2sbNX3zFYSphl5oYyhLpSYrudWMBT9f5awbHIZxB9kyyhegYTadDnseglJ7nXMQwsNQiR2Uy1oCAca+NJdy5BjDk2KEAEvQ/8ilhAn0uTW1sxrJPccB3J/zdd2TlRKzYN6skNzbxFBYr8O6EFBIFVd20M1bSrdeSKEqfO03WCI9O+U63XVkqXbLIsM6L7R7TmVwE9Lfhx0NuoIEF+pv7b5/7uLLa8gFE5I39eOHw1NzM+AVU9GGLgZxlpMq0B4Jj6AMFNpJ7x5HxpmaCSrPADniulwmq/Q83JXdyhU+MDBUI8bcyNxZIGI4mGFYkLLLNiwlB8Bl4adqTCaijPuD058XATKUh9DYpKb1SuwwyxG+FR9JPGk2aXr/4Miko79xmc+exrV35BJTMak1vQ4s+1IoCHS5obzHq8Ncc7YGr3q3MKv9LOTmKQ1Rxsc2MSRZtJF30HGnTa2GXy6l/jTxT5hE03x//yJKef4wQXwBZfMM8vEJBWttP30Hbe8lbIoid9fBqL0isJxG+yOE3uN90nAPhSUFvASjKZf0WUMAkjovnmbYEJuf5JBT+Oz3YsMWoaVm6ND6ghLWqRlN1yTkMRns/Y614bLc9UHQXfZ2E+soCJCcJm5UMjrQefMZ7AekJQ1dfkcBBW1y4IIgmuCm/4lDXXsb5Gg2FSzPcLCkDMh1ZkNYzKVe9yEq9ehDs/emCSOrJQd+QajMBwb5JVwUvPuIv
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(7416002)(71200400001)(186003)(26005)(38100700002)(122000001)(83380400001)(5660300002)(6506007)(31686004)(36756003)(2906002)(53546011)(86362001)(8676002)(8936002)(2616005)(54906003)(66446008)(6916009)(66476007)(31696002)(66556008)(6512007)(76116006)(64756008)(66946007)(4326008)(91956017)(316002)(508600001)(107886003)(6486002)(38070700005)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?RjVVcFA3TVdKbGRuTloweUEwd3piVzVIdlZ1ZTdHZCtJTDZLQ1FuNjlIYm00?=
 =?utf-8?B?R3J4NlJPZEgydFFKaHNTK1F0RjRhYVAzWnc4UjdYSGJtOWhrZGFhNHBtYlFP?=
 =?utf-8?B?N2ZleWJsVVhPc3NzVmNaVXp2Z1hLTFhKeTZIUEpBbi8yNUJ3MEJZWnpWSHhD?=
 =?utf-8?B?N3VrcUtQcHNPNXJIeE5vcTJJMUZKMENjMXNWYlRlVmd2SHdtYUtRNUtleHdO?=
 =?utf-8?B?TG1lYkN2OE5KQUhlYmpFdkhwSEdKQmd6T3d0UklKN2o1aWpxNFE1R1RuK1Rj?=
 =?utf-8?B?WkdBdVh4MUNRak83U1ozeHd6WXkxWHVwVHI3Q2ovc0wvaCs4bHZJMVJVQlk3?=
 =?utf-8?B?b0FZdmVaM0dYcEdQVHFZSXlXMEUvem1DcTJCY3ZUUmdUMkhQMUxQVEp0bGxC?=
 =?utf-8?B?RnJPMUNuNGRFd2VtdFJSUU5JTEV4clQxUnp0WHNvUlpmTEVpM3lnRFhNK2tz?=
 =?utf-8?B?RXBpczZDOFpVT2ZnbUpYazR1WWcwVitrNHFsb1JJSytZdFZWcVVrRlQyODI5?=
 =?utf-8?B?T2F4U1Fhc2NBLzM5QVFMWDY5c1NhVTg3aTFMOHlkTXVNczViOEFnQU5pS0c3?=
 =?utf-8?B?dHQ3bExiZmxwc2pwVW9JcXdKU1JPdFRjYzlBZ25oUGVKMDYyQ1BKaXVVNjZk?=
 =?utf-8?B?RzZnaTE1OXI2YWRRcC85WTgvWUVYQ3hQNDk5SkoxVitkQkN0Y2grampRMlFq?=
 =?utf-8?B?WTZQWnNqRVdnbEtQWjZoNmkzM0IwYWZQSm9UK0M3QVdiTXdGYnlqSmJwZ1hu?=
 =?utf-8?B?b0gxYTltT2ZDaEtFN0RDTEI1KzMxTzVGWFY1N2IxZ0U0VmhyZzlWMVBZaitl?=
 =?utf-8?B?S2E4WjV6bEJhUjVaSDkzQUVVd2gvSkdtRmg1U2cwYWtEWTZzZEkzWUxCMWZx?=
 =?utf-8?B?Qm5xTHIwRnZUWnhNVTkrNk5zUENHTG40cVJYUlU4QUUzYWovKzZqdVp3UUxF?=
 =?utf-8?B?QXBjaW02M01QVXVXKzlkZExremZmQ1drZUxaMjV4VThCNkVrV0NUcElUaEtj?=
 =?utf-8?B?K3hVdVhPY0dZQUxXRkhmUmVUL1FsSmw1aS80akFlRVAyNTNnRFRMWDZvcTVV?=
 =?utf-8?B?OXJrK1pwRzJpWlJjWjlYVVpVcFVVRDVOcTNXSFdNaVdyb1FxUVN3UlZLcFZo?=
 =?utf-8?B?bmxZVDA0ZWFJSkFGRWl1TndUTVFPMXluSVI5TmhKZHVwdHVoTVdsNUg3MGJo?=
 =?utf-8?B?TFdYeGpkVWtPWkNvMHduM0FJTW5ZSHBmcGF2OXNWQXg2b0RYK2J5Y2NmT1hS?=
 =?utf-8?B?OXZYYkt5RUdYbDA1MkZpUlhFNXgwZ0dMQ1hFaDlzWE1LZDNiZGFpam1pNUdw?=
 =?utf-8?B?dDk4V1I3aXE1VGkvaXA5RWh0OFlMaElLWVFSVFFFVmp4SExDbzhjaDM4Y3JI?=
 =?utf-8?B?bGJ3cjRjc0s4alNQMjFmT2FOTXB0aUVrSmpxNU1scThhbkx6MXlRcUMxVVE4?=
 =?utf-8?B?N0J4QUJ6amNTY0NiQXYzc05lc3F0N29sUHAwdVpGN21yRnc5c2YzNlpVWnBK?=
 =?utf-8?B?aHpmKzFOTm1mNllHOGhpUVk0bk5UWElmK2tGVE5XVC9FVXlEQ3RVanl1dUha?=
 =?utf-8?B?cXRHZFNpM25kMCtyWDZ0RWp5R0t0SVBEaTRJSkZvVDQ3bzFnSjc3RUE0Skor?=
 =?utf-8?B?c0ZXeldHbDBYY0c0eGU0UmIraDBoNDF5QW5RemxYTHUrTm4wN3lpcWxwUU11?=
 =?utf-8?B?cGZrVmdoVVhzZSthVTJLeFZqNlBDclRKd3hDT2lKVkMzZG1YRzZuSVFnb1V4?=
 =?utf-8?B?UE1yU3V2aGlVUFJjRWpVM0xqR2txaEt0VzZZalRpWjJmSHhnMmFpYzdkY01o?=
 =?utf-8?B?aWFEelpxRm50WTdxK1J6dTRuWUdjYjByUjdZSDdKYzQwZUlkWjR0akNaMzhz?=
 =?utf-8?B?VC9DaWJMOXVKNlNKYm4yVGZaWXZpajY1RUg3cHBHQkRNR0p6UFptaEM0MlU5?=
 =?utf-8?B?MUR3a085aVJRMXpuZlpDM2tJdW8rNlBKM1FUR3A5M25ZMy9sZ2hrZVFsa3ZI?=
 =?utf-8?B?UG1XRUtBM0NsQWVUT0VPaXpIVWZ2WVdSeHRJdzVwNERRWGlHSXpZMWRaajNI?=
 =?utf-8?B?MURyalFkMWZOdGtQcnpqRzNkQjNpTmRycVU4cWYvZzdySjJUODBsaDRkZi9B?=
 =?utf-8?B?ZFprbHd3bDNWbWQ3VEtETnMra1prd21kRVNPQXllVVh2bGtDc2RsbEFzTGYr?=
 =?utf-8?B?bThTR1NubzJVL0dLdlc1VW1UeTRJNUFSaDdpclBDcy9RdHU4alFCYmQxS3o0?=
 =?utf-8?B?b1B2bG1VdzFTZ1A3cTk0d0NOcHcrTjY1WlJCZklqUm9GbGVrUzFmZWJlMUFt?=
 =?utf-8?B?R2pBb3BjOUd0Mk9tcFUrQjc4NGxsQjJTQWtTbWhsREZkZ2dneWRqUT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <A65D317045377E40B5DC5AA70423DE6D@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 76529cef-fbb9-4341-f0df-08d9e65e7a4a
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Feb 2022 15:12:50.2213
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: e6LeGhX0gbYMeVmKawVp9Y11iLqRmHznp0HIAMDc2Tc+Jto9iEVh9DDPn4nB9NSN90bHshecp1Uvbp1tNFUroxuEm0XoTeOctX+4BpzFRNZ/d1cj3Igjvreyvqx5mNw8
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB5588
X-Proofpoint-ORIG-GUID: vpO2yYcSjKEOl2qeRHicNy-91gZh8rBZ
X-Proofpoint-GUID: vpO2yYcSjKEOl2qeRHicNy-91gZh8rBZ
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-02_07,2022-02-01_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 clxscore=1015
 adultscore=0 mlxlogscore=810 phishscore=0 priorityscore=1501 spamscore=0
 impostorscore=0 suspectscore=0 mlxscore=0 lowpriorityscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2202020085

DQoNCk9uIDAyLjAyLjIyIDE3OjA4LCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMDIuMDIuMjAy
MiAxNjowNCwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+Pg0KPj4gT24gMDIuMDIu
MjIgMTY6MzEsIEphbiBCZXVsaWNoIHdyb3RlOg0KPj4+IE9uIDAyLjAyLjIwMjIgMTU6MjYsIE9s
ZWtzYW5kciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4+PiBPbiAwMi4wMi4yMiAxNjoxOCwgSmFu
IEJldWxpY2ggd3JvdGU6DQo+Pj4+PiBPbiAwMi4wMi4yMDIyIDE0OjQ3LCBPbGVrc2FuZHIgQW5k
cnVzaGNoZW5rbyB3cm90ZToNCj4+Pj4+Pj4gT24gMDIuMDIuMjAyMiAxMzo0OSwgT2xla3NhbmRy
IEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+Pj4+Pj4+PiBPbiAxMy4wMS4yMiAxMjo1MCwgUm9nZXIg
UGF1IE1vbm7DqSB3cm90ZToNCj4+Pj4+Pj4+PiBPbiBUaHUsIE5vdiAyNSwgMjAyMSBhdCAwMTow
Mjo0NlBNICswMjAwLCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyB3cm90ZToNCj4+Pj4+Pj4+Pj4g
LS0tIGEveGVuL2RyaXZlcnMvdnBjaS9oZWFkZXIuYw0KPj4+Pj4+Pj4+PiArKysgYi94ZW4vZHJp
dmVycy92cGNpL2hlYWRlci5jDQo+Pj4+Pj4+Pj4+IEBAIC00OTEsNiArNDkxLDIyIEBAIHN0YXRp
YyB2b2lkIGNtZF93cml0ZShjb25zdCBzdHJ1Y3QgcGNpX2RldiAqcGRldiwgdW5zaWduZWQgaW50
IHJlZywNCj4+Pj4+Pj4+Pj4gICAgICAgICAgICAgICBwY2lfY29uZl93cml0ZTE2KHBkZXYtPnNi
ZGYsIHJlZywgY21kKTsNCj4+Pj4+Pj4+Pj4gICAgICAgfQ0KPj4+Pj4+Pj4+PiAgICAgICANCj4+
Pj4+Pj4+Pj4gK3N0YXRpYyB2b2lkIGd1ZXN0X2NtZF93cml0ZShjb25zdCBzdHJ1Y3QgcGNpX2Rl
diAqcGRldiwgdW5zaWduZWQgaW50IHJlZywNCj4+Pj4+Pj4+Pj4gKyAgICAgICAgICAgICAgICAg
ICAgICAgICAgICB1aW50MzJfdCBjbWQsIHZvaWQgKmRhdGEpDQo+Pj4+Pj4+Pj4+ICt7DQo+Pj4+
Pj4+Pj4+ICsgICAgLyogVE9ETzogQWRkIHByb3BlciBlbXVsYXRpb24gZm9yIGFsbCBiaXRzIG9m
IHRoZSBjb21tYW5kIHJlZ2lzdGVyLiAqLw0KPj4+Pj4+Pj4+PiArDQo+Pj4+Pj4+Pj4+ICsjaWZk
ZWYgQ09ORklHX0hBU19QQ0lfTVNJDQo+Pj4+Pj4+Pj4+ICsgICAgaWYgKCBwZGV2LT52cGNpLT5t
c2ktPmVuYWJsZWQgKQ0KPj4+Pj4+Pj4+IFlvdSBuZWVkIHRvIGNoZWNrIGZvciBNU0ktWCBhbHNv
LCBwZGV2LT52cGNpLT5tc2l4LT5lbmFibGVkLg0KPj4+Pj4+Pj4gSW5kZWVkLCB0aGFuayB5b3UN
Cj4+Pj4+Pj4+Pj4gKyAgICB7DQo+Pj4+Pj4+Pj4+ICsgICAgICAgIC8qIEd1ZXN0IHdhbnRzIHRv
IGVuYWJsZSBJTlR4LiBJdCBjYW4ndCBiZSBlbmFibGVkIGlmIE1TSS9NU0ktWCBlbmFibGVkLiAq
Lw0KPj4+Pj4+Pj4+PiArICAgICAgICBjbWQgfD0gUENJX0NPTU1BTkRfSU5UWF9ESVNBQkxFOw0K
Pj4+Pj4+Pj4+IFlvdSB3aWxsIGFsc28gbmVlZCB0byBtYWtlIHN1cmUgUENJX0NPTU1BTkRfSU5U
WF9ESVNBQkxFIGlzIHNldCBpbiB0aGUNCj4+Pj4+Pj4+PiBjb21tYW5kIHJlZ2lzdGVyIHdoZW4g
YXR0ZW1wdGluZyB0byBlbmFibGUgTVNJIG9yIE1TSVggY2FwYWJpbGl0aWVzLg0KPj4+Pj4+Pj4g
SXNuJ3QgaXQgZW5vdWdoIHRoYXQgd2UganVzdCBjaGVjayBhYm92ZSBpZiBNU0kvTVNJLVggZW5h
YmxlZCB0aGVuIG1ha2UNCj4+Pj4+Pj4+IHN1cmUgSU5UWCBkaXNhYmxlZD8gSSBhbSBub3QgZm9s
bG93aW5nIHlvdSBoZXJlIG9uIHdoYXQgZWxzZSBuZWVkcyB0bw0KPj4+Pj4+Pj4gYmUgZG9uZS4N
Cj4+Pj4+Pj4gTm8sIHlvdSBuZWVkIHRvIGRlYWwgd2l0aCB0aGUgcG90ZW50aWFsbHkgYmFkIGNv
bWJpbmF0aW9uIG9uIGJvdGgNCj4+Pj4+Pj4gcGF0aHMgLSBjb21tYW5kIHJlZ2lzdGVyIHdyaXRl
cyAoaGVyZSkgYW5kIE1TSS9NU0ktWCBjb250cm9sIHJlZ2lzdGVyDQo+Pj4+Pj4+IHdyaXRlcyAo
d2hpY2ggaXMgd2hhdCBSb2dlciBwb2ludHMgeW91IGF0KS4gSSB3b3VsZCBsaWtlIHRvIHN1Z2dl
c3QNCj4+Pj4+Pj4gdG8gY29uc2lkZXIgc2ltcGx5IGZvcmNpbmcgSU5UWF9ESVNBQkxFIG9uIGJl
aGluZCB0aGUgZ3Vlc3QncyBiYWNrDQo+Pj4+Pj4+IGZvciB0aG9zZSBvdGhlciB0d28gcGF0aHMu
DQo+Pj4+Pj4gRG8geW91IHN1Z2dlc3QgdGhhdCB3ZSBuZWVkIHRvIGhhdmUgc29tZSBjb2RlIHdo
aWNoIHdpbGwNCj4+Pj4+PiB3cml0ZSBQQ0lfQ09NTUFORCB3aGlsZSB3ZSB3cml0ZSBNU0kvTVNJ
LVggY29udHJvbCByZWdpc3Rlcg0KPj4+Pj4+IGZvciB0aGF0IGtpbmQgb2YgY29uc2lzdGVuY3k/
IEUuZy4gY29udHJvbCByZWdpc3RlciBoYW5kbGVyIHdpbGwNCj4+Pj4+PiBuZWVkIHRvIHdyaXRl
IHRvIFBDSV9DT01NQU5EIGFuZCBnbyB0aHJvdWdoIGVtdWxhdGlvbiBmb3INCj4+Pj4+PiBndWVz
dHM/DQo+Pj4+PiBFaXRoZXIgY2hlY2sgb3Igd3JpdGUsIHllcy4gU2luY2UgeW91J3JlIHNldHRp
bmcgdGhlIGJpdCBoZXJlIGJlaGluZA0KPj4+Pj4gdGhlIGd1ZXN0J3MgYmFjaywgc2V0dGluZyBp
dCBvbiB0aGUgb3RoZXIgcGF0aHMgYXMgd2VsbCB3b3VsZCBvbmx5DQo+Pj4+PiBsb29rIGNvbnNp
c3RlbnQgdG8gbWUuDQo+Pj4+IEkgY2FuJ3QgZmluZCBhbnkgYWNjZXNzIHRvIFBDSV9DT01NQU5E
IHJlZ2lzdGVyIGZyb20gdk1TSS92TVNJLVgNCj4+Pj4gY29kZSwgc28gd2hhdCdzIHRoZSBjb25j
ZXJuPw0KPj4+IEFnYWluOiBPbmx5IG9uZSBvZiBJTlRYLCBNU0ksIG9yIE1TSS1YIG1heSBiZSBl
bmFibGVkIGF0IGEgdGltZS4NCj4+IFRoaXMgaXMgY2xlYXIgYW5kIEkgZG9uJ3QgcXVlc3Rpb24g
dGhhdA0KPj4+IFRoaXMgbmVlZHMgdG8gYmUgY2hlY2tlZCB3aGVuZXZlciBhbnkgb25lIG9mIHRo
ZSB0aHJlZSBpcyBhYm91dA0KPj4+IHRvIGNoYW5nZSBzdGF0ZS4gU2luY2UgZmFpbGluZyBjb25m
aWcgc3BhY2Ugd3JpdGVzIGlzbid0IHJlYWxseQ0KPj4+IGFuIG9wdGlvbiAodGhlcmUncyBubyBl
cnJvciBjb2RlIHRvIGhhbmQgYmFjayBhbmQgcmFpc2luZyBhbg0KPj4+IGV4Y2VwdGlvbiBpcyBu
b3RoaW5nIHJlYWwgaGFyZHdhcmUgd291bGQgZG8pLCBhZGp1c3Rpbmcgc3RhdGUgdG8NCj4+PiBi
ZSBzYW5lIGJlaGluZCB0aGUgYmFjayBvZiB0aGUgZ3Vlc3QgbG9va3MgdG8gYmUgdGhlIGxlYXN0
IGJhZA0KPj4+IG9wdGlvbi4NCj4+IFdvdWxkIGl0IGJlIGVub3VnaCBpZiBJIHJlYWQgUENJX01T
SVhfRkxBR1NfRU5BQkxFIGFuZA0KPj4gUENJX01TSV9GTEFHU19FTkFCTEUgaW4gZ3Vlc3RfY21k
X3dyaXRlIHRvIG1ha2UgYQ0KPj4gZGVjaXNpb24gb24gSU5UWD8NCj4+DQo+PiBPbiB0aGUgb3Ro
ZXIgaGFuZCBtc2ktPmVuYWJsZWQgYW5kIG1zaXgtPmVuYWJsZWQNCj4+IGFscmVhZHkgaGF2ZSB0
aGlzIGluZm9ybWF0aW9uIGlmIEkgdW5kZXJzdGFuZCB0aGUNCj4+IE1TSS9NU0ktWCBjb2RlIGNv
cnJlY3RseS4NCj4+DQo+PiBPciBkbyB3ZSB3YW50IHNvbWUgYWRkaXRpb25hbCBjb2RlIGluIE1T
SS9NU0ktWCdzIGNvbnRyb2xfd3JpdGUNCj4+IGZ1bmN0aW9ucyB0byBzZXQgSU5UWCBiaXQgdGhl
cmUgYXMgd2VsbD8NCj4gV2VsbCwgeWVzLCB0aGlzIGlzIHdoYXQgUm9nZXIgYW5kIEkgaGF2ZSBi
ZWVuIGFza2luZyB5b3UgdG8gYWRkLg0KRG8gd2Ugb25seSB3YW50IHRoaXMgZm9yICFpc19oYXJk
d2FyZV9kb21haW4oZCkgb3IgdW5jb25kaXRpb25hbGx5Pw0KPg0KPj4gSSBtZWFuIHRoYXQgaW4g
dGhpcyBndWVzdF9jbWRfd3JpdGUgaGFuZGxlciB3ZSBjYW4gb25seSBzZWUNCj4+IGlmIHdlIHdy
aXRlIGEgY29uc2lzdGVudCB3cnQgTVNJL01TSS1YIFBDSV9DT01NQU5EIHZhbHVlDQo+Pg0KPj4g
SWYgd2Ugd2FudCBzb21lIG1vcmUgY2hlY2tzIHdoZW4gd2UgYWx0ZXIgUENJX01TSVhfRkxBR1Nf
RU5BQkxFDQo+PiBhbmQvb3IgUENJX01TSV9GTEFHU19FTkFCTEUgYml0cywgdGhpcyBtZWFucyB3
ZSBuZWVkIGEgcmVsZXZhbnQNCj4+IFBDSV9DT01NQU5EIHdyaXRlIHRoZXJlIHRvIGJlIGFkZGVk
ICh3aGljaCBkb2Vzbid0IGV4aXN0IG5vdykNCj4+IHRvIG1ha2Ugc3VyZSBJTlRYIGJpdCBpcyBz
ZXQuDQo+IEV4YWN0bHkuDQpPaw0KPg0KPiBKYW4NCj4NClRoYW5rIHlvdSwNCk9sZWtzYW5kcg==


From xen-devel-bounces@lists.xenproject.org Wed Feb 02 15:15:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 15:15:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264316.457373 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFHLa-0005oW-1V; Wed, 02 Feb 2022 15:15:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264316.457373; Wed, 02 Feb 2022 15:15:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFHLZ-0005oP-TL; Wed, 02 Feb 2022 15:15:01 +0000
Received: by outflank-mailman (input) for mailman id 264316;
 Wed, 02 Feb 2022 15:15:01 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HAZh=SR=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nFHLY-0005oJ-SJ
 for xen-devel@lists.xenproject.org; Wed, 02 Feb 2022 15:15:00 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e21ae6bb-843a-11ec-8eb8-a37418f5ba1a;
 Wed, 02 Feb 2022 16:14:59 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e21ae6bb-843a-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1643814899;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=HgEdGVe4YFt/O82PFXP+0au2sF6rKSNyOnjwa/NZzLQ=;
  b=Lo6lKNHnkFT/S66PYUA/ReqruXTZzoMz6ruVl2svzxFIYZlOSC0cgE0m
   Pa0pTgXJVoitFmFib78Y2BLfnYY8CraFsUD5mvo4FnKLXHlwSmCdEF27N
   4yDXt/rKqib96NbLyJmVoibpSiagVeNXFkcdsH6BeCBWop45PxdD7+E4u
   g=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: pXzJWqyKZr+9btlBIQKiCgtLHrP5nA6RNQ6LmBipJSIXM+B3/N9l6A3gmkfQnhRsQvJ4EeGeIR
 FHyHgz+PIJ9u2N1XQombOsdWePP4/RRS7UoF/8uj5wiYKYkj+U/G2jIdHi1+Er4PTvlxz97qGk
 gGvqqjpdEYRNKLBPC33q888AdeRMsbTsJjeLu6GB5OsyzuJGgS2N/fPTaed4kJ7tc9HkMw+G20
 F2xAdpwNf+/T8Ebm3bU9HSo/1vnjxOKAhzxazk+2Mbj/g3Qu6YyOd2TQt2PFNmG/3nufFxrsJy
 9LX53Z3iHq443NV9ckQEgLWC
X-SBRS: 5.2
X-MesageID: 63333418
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:nuvooaBRbnp0OhVW//Tkw5YqxClBgxIJ4kV8jS/XYbTApGgihj0Px
 mMXUGuCbqqKM2L3fot3bYW09kMDvpHdndY3QQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMo/u1Si6FatANl1ElvU2zbue6WL6s1hxZH1c+En970Ug7wYbVv6Yz6TSHK1LV0
 T/Ni5W31G+Ng1aY5UpNtspvADs21BjDkGtwUm4WPJinj3eH/5UhN7oNJLnZEpfNatI88thW5
 Qr05OrREmvxp3/BAz4++1rxWhVirrX6ZWBihpfKMkQLb9crSiEai84G2PQghUh/timPsdtwl
 8505LeQTF0xY7fTt+E9akwNe81+FfUuFL7vJHG+tYqYzlHccmuqyPJrZK00FdRGoKAtWzgIr
 KFGbmBWBvyAr7veLLaTUO5ji95lNMD2FIgepmth3XfSCvNOrZXrHf6RvoQEhWdYasZmLaz6T
 uxJYCFUTw3tYx9LY1MJS5wStbL97pX4W2IB8w/EzUYt2EDMyCRh3b6rN8DaEvSaSMMQkkuGq
 2bu+2XiHgpcJNGZ0SCC8H+nmqnIhyyTcIAYGaC89/VqqEaO3WFVAxoTPWZXutHg1BT4AYgGb
 RVJpGx+9sDe6XBHUPHAQxuWq3/bpSdNcPpVSfVn8h6iz4rttlPx6nc/chZNb9kvtckTTDMs1
 0OUk96BOQGDoIF5WlrGqO7K8Gra1Tw9aDZbOHRaFVdtD8zL/dlr5i8jWOqPB0JcYjfdPTjri
 w6HoyEl71n4pZ5ajv7rlbwrbt/Fm3QocuLXzlmGNo5GxlkgDGJAW2BPwQODhcus1K7DEjG8U
 IEswqByFtwmA5CXjzCqS+4QBryv7PvtGGSC3QUwQ8Bwpmn0pS7LkWVsDNZWfx8BDyr5UWWxP
 B+7Vf15uPe/w0dGnYcoOtnsWqzGPIDrFMj/V+C8Uza9SsMZSeNzxwk3PRT49zm0yCAEyPhjU
 b/GL5rEJStEWMxPkWrnL89AgORD7n1vmgvuqWXTkk7PPUy2PiDFEN/o8TKmM4gE0U9ziF6Er
 o8CZ5bWkEg3vS+XSnC/zLP/5GsidBATLZv3t9ZWZqiEJA9nE3smEPjf3fUqfIkNokifvr2Ql
 p1kckMHmlf5m1PdLgCGNiJqZL/1BM4tpnMnJy08e12v3iF7M4qo6a4ecboxfKUmq7M/naIlE
 aFddpXSGOlLRxTG5y8ZMcv3ort9eUn5ngmJJSekPmQyJsYyWwzT99b4VQLz7y1SXDGvvM4zr
 uT4hAPWSJYOXSp4C8PSZK79xl+9pyFFyulzQ1HJMp9Yf0C1qNpmLCn4j/kWJcAQKEqcmmvGh
 ljOWRpB/LvDuY449tXNlJuolYbxHrssBFdeEkna8a2yaXvQ8F28zNISS+2PZz3cCj/5of3we
 eVPwvjgG/Qbh1IW4ZFkGrNmwK9itdvio7hWklZtEHnRNgn5D7phJj+N3NVVt70Lzbhc4FPkV
 kWK89hcGLOIJMK6TwJBeFt7NryOhaMOhz3fzfUpO0GrtiZ48Y2OXVhWIxTR2jdWK6F4Md99z
 Oos0CLMB9dTVvb+3g66sx1p
IronPort-HdrOrdr: A9a23:8BPSd63wMyLhm+szph5YRgqjBVByeYIsimQD101hICG9Lfb2qy
 n+ppgmPEHP5Qr5OEtApTiBUJPwJk800aQFm7X5XI3SJzUO3VHHEGgM1/qB/9SNIVyaygcZ79
 YcT0EcMqyPMbEZt7eC3ODQKb9Jq7PmgcOVbKXlvg9QpGlRGt5dBmxCe2Cm+yNNNW177c1TLu
 vh2iMLnUvpRV0nKuCAQlUVVenKoNPG0LrgfB49HhYirC2Dlymh5rLWGwWRmk52aUIE/Z4StU
 z+1yDp7KSqtP+2jjfaym/o9pxT3P/s0MFKCsCggtUcbh/slgGrToJ8XKDqhkF/nMifrHIR1P
 XcqRYpOMp+r1vXY2GOuBPonzLt1T4/gkWSvmOwsD/Gm4jUVTg6A81OicZyaR3C8Xctu9l6ze
 Ziw3+Zn4A/N2KOoA3No/zzEz16nEu9pnQv1cQJiWZEbIcYYLhN6aQC4UJuFosaFi6S0vFqLA
 BXNrCc2B9qSyLbU5iA1VMfg+BEH05DUytue3Jy9PB8iFNt7TJEJ0hx/r1qop5PzuN5d3B+3Z
 W1Dk1frsA6ciYnV9MNOA4/e7rFNoXse2O7DIvAGyWvKEk4U0i92aIfpo9FoN2XRA==
X-IronPort-AV: E=Sophos;i="5.88,337,1635220800"; 
   d="scan'208";a="63333418"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=R+DMPe/VPiUR3obl3B3XVpjVY64uhO8IVK/Q9LLOrtIgIurcoR3hRpGfDvcWMhWbPhMTM7IUTK5p/ocYMOnTBwjS5tQtrhduWd1970U/6Ll9UhNE9b1Ysg8VuAxEWN6sRUypj/5mdasYlW2Hu6Lu/zT1mwwNbKWURtmiTWuRMqZAoCxdcW6sYCwL/kePuMaP+XmEqVDJi/HtEZ+vjR4zyPbqNg/KG/70T6f22bACDtEw9WpsI0KKT5SAs6wxOtZW2xEJmcIn8pSMXxTZIjIP4Nwc1o9jj3HoakfkTjyYIrZTpFoyam1A5tZTUILaOv8oo6D2dGcX9FC0B6mv9YQZug==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=3JtSTh7t3cVGnSGxaJCada0ZD+PemwdU4u58v5gELL0=;
 b=ezEr15apGXiUcy3QKMfBqoMzSxvGINzmhVpOMUptLpwiiIpVfo70ocGJper2tZF3lEe2wwEWRs4XY7TTdSak8UEGgObUwuXyR7rPREtwLaAZMwad4bWw+uPpEdLp2CvNkg+2lYDg3P7e4D1Trnk0FsqZzlxj6OEAmmSu9yLPc7OOpBe6MDm6H7v2pzFabjO+wekiFnlWALWdWT7p5pFZIQ9LuHqNwyMMd3qmnHYUxrqCegTxw1mkWkH4bFE4IrvqeuWbUhoJK9W+BOkYJ9IHClItxoL63q4SBQU/M8trnfqsu7tsMIXXDZt4aaiEJLpIaD7W6DyMCsJ7YiDpIrFzCg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=3JtSTh7t3cVGnSGxaJCada0ZD+PemwdU4u58v5gELL0=;
 b=xClUHifQyUECki6b6QcpCjANZCq/AlfdnyMcpwEDFSVKPym/b7nuMv9SWpDdANc6hQ2YJD+D+/UedmtGrq4UMlU7js6VTMBYEHPjC1AM4hMQEuLug2aTXHRqFwfO3i3isazv+CzwKIyGs1xtLxtDAUaAX1dlEVvk7QOez9yeJQI=
Date: Wed, 2 Feb 2022 16:14:46 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>, George Dunlap
	<george.dunlap@citrix.com>
Subject: Re: [PATCH v3 2/2] x86/mm: tidy XENMEM_{get,set}_pod_target handling
Message-ID: <Yfqf5jiO0cHjR6gR@Air-de-Roger>
References: <6fe7b036-2bdb-b391-4e6c-1b5d7e05a119@suse.com>
 <8cba4cd0-d218-da1b-dcea-4cc3047c0946@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <8cba4cd0-d218-da1b-dcea-4cc3047c0946@suse.com>
X-ClientProxiedBy: LO2P265CA0268.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:a1::16) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c0d5515f-d7e0-4f8e-1147-08d9e65ec257
X-MS-TrafficTypeDiagnostic: BYAPR03MB4248:EE_
X-Microsoft-Antispam-PRVS: <BYAPR03MB42481C1E6336CABF9FAB56B78F279@BYAPR03MB4248.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:136;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: qgObVhAc5Uml9MwwFIMKvHmBSPWIrV+/43nAYtSniaQ/NS6cGFwgShLssgPorGeynUHwX2W9BRcXL7IJ5R+UJtIjxUqVN3gJU7+GMOuIzOxl02UQNXrQCN72XGiklwBYDU4I0b0tO36SMY7EZ7Nn9pWltW6ltLeEhMGYELpmyOIqQ+VpdY9PGoh9sa6bcXFY6Yfft1m8/2U7BUmAT2fKgmveaqVlHma6nVcR5UEG9LnhxBmcFfm6IM8PsK2VZX47noGZw6YKPbDq7ejCfHAFO+3iIIdMU47FyTSs9i4U1rhhNfh6gwthhyaZ1rKdG056m5eL+q1A5iXOXaUx0vZCNFDSfSOzJnTqvIJ+M+/8KC73sQ01oqhdxVkpcnG9ADQyUpSHFgn+OgVIuLJEu5LJ0wuHvOj/QGNFSAl8rLTgxZ16YDu/YMoSRrS8QPEk/8PmdQC9JHASKng65adFOE/UR2H8Sw1v1LPXBSLT470WVdzLnrE65oFEx85rL3jjEeQ4cC43JY6JxosntE0Pvmvo1CDJgf8Zi56uK4WwyiHLgwf8XU4lKlRKbWPVpvhkCCE/aDiDGjDGy2rYC8JnuFsGcUtuwVdh1IosKKy3P6vwec6Y9tZER0coOJom+uUy0ayvr8sR6iKC4e7Hhx5SDuFmCQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(66476007)(8936002)(4326008)(6666004)(82960400001)(66946007)(8676002)(9686003)(54906003)(6506007)(86362001)(66556008)(6512007)(83380400001)(107886003)(6916009)(508600001)(85182001)(6486002)(2906002)(33716001)(4744005)(38100700002)(26005)(316002)(5660300002)(186003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SlR5Y2M0aEpabUhabWhabWVpOCthazJyS3R5QVhhbUZ4c09HNGhBV0hlVXox?=
 =?utf-8?B?VlMzaXdWL1g4aE43UzhBaHptTnJmNzFhbnppNHNZRFBYQWtmZkRKOFVtb1E0?=
 =?utf-8?B?eE5rOERkakUzUG1qSGxoK080clAxSEthMjdVMjlnS2c2SzJERFpFQ1VlOHZT?=
 =?utf-8?B?Yjk1Z05JZ2dZb0hKSEtuUVdDNnpFTnNzbS80OWF1ODd4V09mVm1henhjU0RN?=
 =?utf-8?B?WWFMbENVeFNEeTJWeVpoQmZxR25lUDdRdGJOek9uRnBybzZqQncxSFdOdlVn?=
 =?utf-8?B?TmV6UlhRZTg2eSt0TUg2T1RpVmg5RmJvZHh6T2lCS1d6anZxRk9HK25jOHdn?=
 =?utf-8?B?Z3hEZ1R1R1JwVEs3S1JzRnFLTUxGMENtZ0lkcXM2TUJEMUtYdEt0Z1BOUEpn?=
 =?utf-8?B?NHd3MGNMZDJSYVFKL1hLQmlzRlBRS0Y5c0hTcU1Nc2dReWJNYTVWME5tVEc2?=
 =?utf-8?B?bzJJZlFCZmtNdXlQeWlOcU8zK25jdXpiWlRqZ0REM2JsTW92MTMwN3NoMlF4?=
 =?utf-8?B?eEhBa1NKdjBjTWZLaTFZUnBEMkJhdUYvdG5UTzFCeUNoQllacVEzeDBRUkM3?=
 =?utf-8?B?R1JpaFk1YmFxbUJ5ZUFNSVcwVGF5NHZhdithY0ViaVFVZHR3WVZ0TEhoNVNP?=
 =?utf-8?B?b0ZRS2FKUlN5L1BZaTBWcVdFUUYxN1M2ZlkwcTJjU0k5UTdwb3Q3dGxqSXh0?=
 =?utf-8?B?RWpvNlVPZEs1Qmt1eGV4ZEZoVXIzN2VNbk1wam0ybHlURmY3S2gvaS96TWdY?=
 =?utf-8?B?WVNoL1hDdXI0OW5jeUpJcSs3MDZ4ckZqSXBmQUpPeitZMjR6cVRYNDdXUlAz?=
 =?utf-8?B?R0dvUExsTmpIWEljcnFWSFZLa0NCa3NENGwraVhNcEZuMEJEb0l5WlAvb29N?=
 =?utf-8?B?N2VPS1MvSS9QMmYyRVZKMlA1eTFXMlJReXFudFFZWWdpRVBFNnJpWGJqM2Ix?=
 =?utf-8?B?dTM0VjRXZndIT1hNSDFlRzVVUG5BVk5oUGZodFYzaUtYTlRwb0hlY1cvUW1G?=
 =?utf-8?B?ekxSNzhaaHF6cDN3K2dJOFZIZ0dVNy9BcGdneEhuS3lvUVVFZU90aWRSRHBs?=
 =?utf-8?B?eWxFYjM5eW5tOGw0VUkvcjZXTHQwa040TDNVRjdOcHdtb09UejFhQnRTelli?=
 =?utf-8?B?YlVKTVhkOWk2ZFl1UWhlUE90Nm5tQzdQREFTeWg2S2Z3eHpqMlUyOUlnOTVY?=
 =?utf-8?B?Z3FreXR1REplWXBHVWV3SkU5VmZlTCtvV051SE1WSGRqRFprdEkwZDhjM1Ez?=
 =?utf-8?B?V0hWbWsvL2hoc2ZvZnMzY3RGaWV0SFNyamdMK2s4YXhiQjFNWkVidFFGKzdi?=
 =?utf-8?B?cFpmMHFsU2xLUm5NQ3lVQlA5SU1zZGlPUmZ2elY3UXM0V1RLZDJHWWRuREYr?=
 =?utf-8?B?NlN1L2hObkRBYnVwTHYvdkFvRGhRUVJEcHNnQ0lDRTR2NDRhaGNMOUpoOGVI?=
 =?utf-8?B?dDJqS3BvQjhSRVRnN1ZVTklMUUN0TEZ6UEVTODZFVm1pcGlFSmVpTTRESHpP?=
 =?utf-8?B?ZkZaeEVUMUlOMzBYbEJvZEZZOHVzcS9UWi9oYUJUYWdvdHNxQmZYdTQ0WG9V?=
 =?utf-8?B?YnBBaFA1VytJUDZkWmY4NWxuMjljZGNqTjJ4b2NTYzgwVnE4UkxlcFRrTEYr?=
 =?utf-8?B?TjUycEtqWDZaSGxHd0VESUVYbW9rbmZ3M1U1VGVRbXlPUm1IWHQrdXNhZG5F?=
 =?utf-8?B?ZE5HdXFFYWMydDZWVVBlR3ZpT3RkMjRYVWlEMUo2dkJnWG11eUFpWlA3QXFm?=
 =?utf-8?B?ZU9ReDdHNDJ1VDlLQkpLNlM5K2dZSDRRRXVoT2pOUjNtU1pwQkxRb2tsUHE2?=
 =?utf-8?B?VzMwUlFDVWlDdmZXSkRLYTRXb09FK01xOU40c244TjVkZTZBNEx2UEpxcEgv?=
 =?utf-8?B?L2xpTnQyMU9hemluOWF1V2kyNHlhSXlWOG5uaE1vaUZaZVFFeVZLM1MzdWQ2?=
 =?utf-8?B?M2pmZ3h2NTltbUdJOFdGQkNUbDdIaWtzSlpWdjdCbmxncjd4b1JCbE50Vm5o?=
 =?utf-8?B?VEpwUWFxQUxOQThXYTM5WHVVby9mVk9iV05yamQ1d1dDNWgvMXBzUllUbkJ1?=
 =?utf-8?B?dFNPTmFkZnBZRGN1cDY5a3NHVHdadnY2OEtuSGRORGhoRnBSY3hHNkozUHRR?=
 =?utf-8?B?ZXBxM0o1M0kyWVR3Y056Qi83VU9YcDZpUkRZUXY1S2VGTWlGZ3BEMTliM0ll?=
 =?utf-8?Q?XpztCLlfSi7fjYmI8GQTm8w=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c0d5515f-d7e0-4f8e-1147-08d9e65ec257
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2022 15:14:51.2529
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qb1l+Ro6Hg7yGLIEKkfjJqWA3Y8uON6fsdLwPG0xtGCQAjy6pmmhi8QA35yxyCtZQcEEd1OsNvTRSWr63w2vkA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4248
X-OriginatorOrg: citrix.com

On Tue, Jan 04, 2022 at 10:41:53AM +0100, Jan Beulich wrote:
> Do away with the "pod_target_out_unlock" label. In particular by folding
> if()-s, the logic can be expressed with less code (and no goto-s) this
> way.
> 
> Limit scope of "p2m", constifying it at the same time.

Is this stale? I cannot find any reference to a p2m variable in the
chunks below.

> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Code LGTM, but commit message likely needs dropping of that last
sentence or the block using p2m needs to be adjusted.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Feb 02 15:19:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 15:19:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264324.457384 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFHPp-0006UT-IZ; Wed, 02 Feb 2022 15:19:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264324.457384; Wed, 02 Feb 2022 15:19:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFHPp-0006UM-Fa; Wed, 02 Feb 2022 15:19:25 +0000
Received: by outflank-mailman (input) for mailman id 264324;
 Wed, 02 Feb 2022 15:19:24 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=J8cE=SR=citrix.com=Jane.Malalane@srs-se1.protection.inumbo.net>)
 id 1nFHPo-0006UG-1h
 for xen-devel@lists.xenproject.org; Wed, 02 Feb 2022 15:19:24 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7e1bebb4-843b-11ec-8f75-fffcc8bd4f1a;
 Wed, 02 Feb 2022 16:19:21 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7e1bebb4-843b-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1643815161;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=e99LSN4D6DagAsXWqsoyVLBFkSl0wPe3DNkHcfIwdgE=;
  b=Kt3qRNtS3zGnMAw8MlwJ5h3cOBLskiINPKoCihOflDZGON+VMOwkJ/Ol
   gTu3fGb5x43EwJF24KCrpHLh10zYrCacQvpufJvtE3YQyXbtII/9XzHpe
   iTsWviX8fZbbGGR5gK0tLvgUn+W90EavWfaqDH45A8IIOrLYMWndaCENR
   k=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: +6F5xza2VnTPhpC6RHfoWCvtjj+ALrKImDga2vTO9Z/wNhCHEpJ0GQYbN9i6BWE62JqVU/shu5
 jEKNkIgXphXEcBI68zWok/O4GVgGQJ/zbkJaqNT0JYVMI3Qt87tUC2FRSyJic3h+TFC3djFkBT
 2phB8sjHlQqWZfeDc1dyGgPNouVGNH5lLCmvqVjN8vE0hOt9Y8jlSiL02/ma0l14bU5co9QARS
 CHMmsIfEGlUSu8XScdu+CaT2pK80Ehfek3k2Bjg/OZicGFPFyYZ9UZt9EleIoPpWcuOqtlNmGI
 dj+D6v+o160La1FdPOaydKsy
X-SBRS: 5.2
X-MesageID: 62793496
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:dOMFiq3/hxRU+sPZv/bD5Zd3kn2cJEfYwER7XKvMYLTBsI5bp2MBz
 TMXXW+DMq6DYDb9L99yOovkoBkDsMPdy9ExTVdvpC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkS5PE3oHJ9RGQ74nRLlbHILOCanAZqTNMEn9700o5w7Rh2OaEvPDia++zk
 YKqyyHgEAfNNw5cagr4PIra9XuDFNyr0N8plgRWicJj5TcypFFMZH4rHomjLmOQf2VhNrXSq
 9Avbl2O1jixEx8FUrtJm1tgG6EAaua60QOm0hK6V0U+6/TrS+NbPqsTbZIhhUlrZzqhxc9yz
 dJnnLaJYjgXfafsxv5CaDxRKnQrVUFG0OevzXmXtMWSywvNcmf2wuUoB0YzVWEa0r8pWycUr
 6VecW1TKEDY7w616OvTpu1EpM0lIY/ONYcWvnhmwBnSDOo8QICFSKLPjTNd9Glq2ZEVQaeAD
 yYfQWFqMyTRcQZpA1lUUagYjdqLvybwNAQN/Tp5ooJoujOOnWSdyoPFK8HJc9aHQcFUmEewp
 W/c+Wn9RBYAO7S3yyeB83+qrv/Cm2X8Qo16PIO/8vlmkViC3Fs5ARcdVUa4ifShg0v4UNVaQ
 2QY8zQjhbI//0uqSp/6RRLQiGGAlg4RXZxXCeJSwBGAzO/Y7hiUAkAATyVdc5o2uckuXzso2
 1SV2dTzClRHsreYVHac/be8ti6pNG4eKmpqTS0LVwwe+PH4vZo+yBnIS75e/LWd14OvX2uqm
 nbT8XZ41+57YdM3O7uTp0/EhjWGj7LwZTELpQ/3AHj61SZwXdvwD2C30mTz4fFFJYefa1COu
 nkYhsSThNwz4YGxeD+lG7tUQuzwjxqRGHiF2AM0QcF9n9i40yP7JehtDCdCyFCF2yruURvge
 wfttAxY//e/11P6PPYsM+pd5ynHpJUM9OgJtNiIP7KigbArLWdrGR2CgmbLhwjQfLAEy/1XB
 HtiWZ/E4YwmIapm1iGqYOwWzKUmwCszrUuKG8ygkEj+gOvDPSDFIVvgDLdpRrthhJ5oXS2Pq
 4oPXyd040k3vBLCjtn/rtdIcAFiwYkTDpHqsc1HHtNv0SI9cFzN/8T5mOt7E6Q8xvw9vr6Ro
 hmVBxEEoHKi2yyvAVjaOxhLNeK0Nb4i/C1TAMDZFQvys5TVSdzxvP53mlpeVeRPydGPOtYvH
 qRcJpXdXq8SItkFkhxEBaTAQEVZXE3DrSqFPja/YSh5eJhlRgfT/cTjcBep/y4LZhdbf+Nly
 1F5/g+EE5cFWSp4C8PaNKCmw1+r5CBPk+NuRUrYZNJUfRy0ooRtLiXwiN4xIt0NdkqflmfLi
 V7ODEdKv/TJrq807MLN2fKOobC2HrYsBUFdBWTas+q7bHGI4mq5zIZce++UZjSBBnjs8aCva
 LwNnfHxOfEKhnhQtI94H+o5xK4y/YK39bRb0h5lDDPAaFHyUuFsJXyP3M9usKxRx+AG5VvqC
 xzXotQDYOeHIsLoFlIVNTEJVOXb2KFGgCTW4NQ0PF7+uH198o2YXBgAJBKLkiFccud4adt33
 ec7tccKwAWjkR52YM2ehyVZ+mnQfHwNV6Ir6sMTDIPx01d5z1hDZdrXCzPs4YHJYNJJaxF4L
 jiRjavEprJd2kudLCZjSSmThbJQ1cYUpRRH7F4ePFDYyNPKi8g+0ABV7TlqHB9eyQ9K0r4rN
 2VmX6GvyX5iI9u8aBB/Yl2R
IronPort-HdrOrdr: A9a23:jwBlvKiAjM6VMb5wC11uQychD3BQX3d13DAbv31ZSRFFG/FwyP
 rAoB1L73PJYWgqNU3IwerwRZVpQRvnhPtICRF4B8bsYOCUghrVEGgE1/qt/9SAIVyzygc578
 ldmsdFeaTN5DRB/KXHCUyDYqwdKbq8geGVbIXlvg9QpGhRAskKhWYYNu/YKDwMeOAvP+tjKH
 P23Lsim9PUQwVwUi3NPAhjYwGsnayoqLvWJTo9QzI34giHij2lrJTgFQKD4xsYWzRThZ8/7G
 nsiWXCl+WemsD+7iWZ+37Y7pxQltek4MBEHtawhs8cLSipohq0Zb5mR6aJsFkO0aKSARcR4Z
 vxSiUbToBOAkDqDyaISNzWqk/dOQMVmjrfIJmj8CLeSILCNWoH4oF69P1km1PimjQdVZdHof
 h2NiuixutqJAKFkyLn69fSURZ20kKyvHo5iOYWy2dSSI0EddZq3MciFW5uYd499RjBmcga+S
 hVfbThzecTdUnfY2HSv2FpztDpVnMvHg2eSkxHvsCOyTBZkH1w0kNdnaUk7zo93YN4T4MB6/
 XPM6xumr0LRsgKbbhlDONERcesEGTCTR/FLWrXK1X6E6MMPW7LtvfMkf8IzfDvfIZNwIo5mZ
 zHXl8dvWkue1j2AcnLx5FP+gClehTKYd0s8LAo23FUgMyOeFPbC1z2dLl1qbrRnxw2OLyoZ8
 qO
X-IronPort-AV: E=Sophos;i="5.88,337,1635220800"; 
   d="scan'208";a="62793496"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=n4dzm2eYUaTWq/nPmQLbRn1/K/qVmYngpyx+23M9m8dpUgDTXqSKSHuCKGZaaKUkkuDWrhN/fTUNi/+MTrLqMyl5tVGepLE5rQ7hADjWwENgo7AsrGORVfBUFpHpfQeSiYPD3sPyfTR3LEw9FpRgLY0jS766f5I4wmh1fWC8wK1ytgtLyxoSCJKTpOu9GG5QLGcBb0QeZIRmQvyI2yXqUHEISspcROY3NI3TnVPr+z0Lqp9I46qfSow6mOXrC0tU+LV5fJAXOjKknwU9y3UgYcX8ZT4l1/d3CO+pLt0z5idMuZ+GlBDKpmPJEAnJ4xSaCHMRtv1/9aFJnkLosA5Utg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=e99LSN4D6DagAsXWqsoyVLBFkSl0wPe3DNkHcfIwdgE=;
 b=QNNDhG1PJha1sGCd0UZrJaVFrWR1XDMkXwOUN+rjS4V/fhkC1CAhf0DeLGaRNH3cNrqpBfX0Yk4UK+h/qbo7fOwKbNDbWPwLYFbTnaUf40b/6LW2Kw5SR3es0LwYhaBnMlbiLh2vqQZKPh7WogvGlT/v9Cgjq45LnX1VEhHnPW/Z84Yptb85cV7np1jG4iWj2nzicYh9Ijy7cSFQm2YZsvwxsotPa1icvftYeSGkMAcKsaJ+S+BDeZG+l+3wQOiUZmkuSkbmpQbuJ005H/nCgOUWLZiW7sFosfJIQaE9YwwmDZLBKOYUbei5rFLYgJ93riBAQ5+A5GSGHloXNn4Nug==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=e99LSN4D6DagAsXWqsoyVLBFkSl0wPe3DNkHcfIwdgE=;
 b=mc3k/biL9Dj4va1VBVpZO+/rcHREulEWmcLtDnVMa5wtAa0ygQn6iiB4lWWDMKRIVLgeqrkiKVylZsOX65p2mpaOwhiCUOfS5Jqi++UhyeHAzjIiYsNNFjvnMzeeKQY5LgC6MrIxisgzLDOys4KLVmzFb5r7pLT8d0QYDSMVgyE=
From: Jane Malalane <Jane.Malalane@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>, "Anthony
 Perard" <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, "Andrew
 Cooper" <Andrew.Cooper3@citrix.com>, George Dunlap
	<George.Dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, Julien Grall
	<julien@xen.org>, "Stefano Stabellini" <sstabellini@kernel.org>, Christian
 Lindig <christian.lindig@citrix.com>, David Scott <dave@recoil.org>,
	"Volodymyr Babchuk" <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH 2/2] x86/xen: Allow per-domain usage of hardware
 virtualized APIC
Thread-Topic: [PATCH 2/2] x86/xen: Allow per-domain usage of hardware
 virtualized APIC
Thread-Index: AQHYE5eVWWLwfSz8JEi35sISHqV9YKx+fmKAgAHq4YA=
Date: Wed, 2 Feb 2022 15:19:13 +0000
Message-ID: <1364444e-aeed-7e0c-dc81-67365324350b@citrix.com>
References: <20220127160133.11608-1-jane.malalane@citrix.com>
 <20220127160133.11608-3-jane.malalane@citrix.com>
 <YfkFJTYXa/7DSTaI@Air-de-Roger>
In-Reply-To: <YfkFJTYXa/7DSTaI@Air-de-Roger>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: a4cee1e4-5b55-4621-ffee-08d9e65f5eb1
x-ms-traffictypediagnostic: MWHPR03MB2624:EE_
x-microsoft-antispam-prvs: <MWHPR03MB2624FCC1B0FF01FCBF21C2C481279@MWHPR03MB2624.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: HxR2URhan+jNmGvjNzjeVWdsel+X6psVmoNIjLtZzOO7qcgdQuW02TNcRGh5zuIRMFgB5W2Mt+uI50hB5kVOiCquTQ4YDX5m/JwopA1GNq8De5DA/kWggl9IwySFXQDasjj01Z6AnqFCmwcq9RcTRYWITy2hEE3AOad6jxcUU2uOCdZFOGmzACBDcs6Qd9RQNkPRRQXEREdmsQ+ThZaxW7KAcyCrQwPyckHQfT+rF9hIvuhbWgHDCPMS73ybAX0rfT6N0TmNTpFWf8qVOQQxj3sc1iDnQeTePlKHmo2BU7nWzq3Qg+LTRn5u40cY+Gc3sH7ctvpKNfmd3BovkOdczAB1yXcSWk0NYtVBWkKpsvYE50LXGRV0KkylQZ7VuUsc6+PBiTvxulUDGIJ5hFs/NXxm8joWLip7YqDrKZkxHg7OmHk3rQ8gXq2R1VKKaGEQ6LwrnZTkeJmZod0IrKDaOeAEOJAzA1q2h8HgFcBh7Y03jzMYRwvUwyI48A1ub09fwoGDkj55I2IStlsCPJwbQcCl5ut37sJyRaMcPu6zi+Tdb4ojYoV2GxzvcBybCdwVMHWR8xar6hSEr7W+R+EvyWo2MQJsP5+xLY2JRw+cXdN2XXUS6GFtXr+/PAk9sTgvA9cRIDYbXyK6RUp81VRlm4LdL8QlegvvAlzK/RjRC+orJfahV/matVnzfqpEGd28LxPQkIChyzdnT8CSxy7YA6IHmkfV025gIpzvZ+9qGzn9Fd0Jfu/gg7ovjPBNrUmI
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR03MB3386.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(91956017)(4326008)(64756008)(66446008)(8676002)(6862004)(66946007)(8936002)(6636002)(54906003)(316002)(37006003)(30864003)(31696002)(66556008)(66476007)(2906002)(76116006)(71200400001)(26005)(2616005)(6486002)(508600001)(186003)(31686004)(6506007)(55236004)(53546011)(6512007)(36756003)(38100700002)(122000001)(82960400001)(83380400001)(38070700005)(86362001)(5660300002)(45980500001)(579004);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Sk5rcjNQR251bHJNMVJ4NklzWXJzYlNqZGhEVytvNWlETzZmOGQ3c0RPRElj?=
 =?utf-8?B?a3pIQ3o5QWRKbXRyV0xFS25mR0JBV0NDR3htMXM3cE53OE9sQWY5cHhKcWxl?=
 =?utf-8?B?V3QvNWhiNzQ5R2t6U0F2MENWeWNnTkhqZDZLUWtoWjB1Vi9XWFhNYXdybm10?=
 =?utf-8?B?QW40NGVxdUQxWDZkN2tta1pNVFNhQzJZdzVJL1dGY3dJbnhMdWZyUUVPM1FJ?=
 =?utf-8?B?OVlCUEtabGtVZE0xSVVQN0c2MUlPR21GblBicDNmeld1MU90aXR3TXVJYWNv?=
 =?utf-8?B?c3I4eFk5NXZFME9xdGltNXBKR2VnM3NFMVVldkVzdXRncUFhS3A4RkxVNEN1?=
 =?utf-8?B?TmZ0UjhmMytid2dDeGJ3UUtjZlFYZlh3bFR4ZE1HU2ZPdFc3c2JQNG05eGFD?=
 =?utf-8?B?UVdhMkhaRnVlV0FxenJGd0tIN1FSRGtaVjVpR3FyUFVxTVpYL3UzUUxqTWJs?=
 =?utf-8?B?R0FSYjlyWXZ0WEVxeVBCM1kvT29kcVhFdyt6QUpKTzNVYWN0UElyQi82dlUv?=
 =?utf-8?B?SHlJNTVveUxLbGRTazU4dVpuUHFIb252UlhYN0lVQnhSQkJyNU1lWDdwZ3pV?=
 =?utf-8?B?QlN4S0plZ01rQUJjUHNKZHpXOElOeGJOcXRNSEp4dkozNjNUWjV3cFZvRWRY?=
 =?utf-8?B?TVBsUVRnT1RKN1hYWlVjeGhCWGV2VXdUdUFjRXFTT1VzSVN6bUl5bXdaVWhY?=
 =?utf-8?B?dnhXMnZFU3A0STM2VGlwK3g5RzVzemZNWldCOHBDWkhwa09WZGZxTWtsV3Z0?=
 =?utf-8?B?NVhtRWR3UWw1aUxVUHBIMmVybUxpL0ZMUEJFT0l2WHBXbGtBa1JwdVpYNXlM?=
 =?utf-8?B?WDVzb0g3azZEV1ptTmtxVHAwTU41ZWkrdUk2aEYyS045TDdxdWZSajljdHJk?=
 =?utf-8?B?MG8yREpuNE9Lc1lib2E4QWVZNy93UERZaHJWd0E5bGF5SVRKczFzS1BpQU9h?=
 =?utf-8?B?NGRqQmtoV3JGTVZhTGxjeVl1Tks1b2lZeTU5K0xmS3hwb3AvR21yQzZ1WXlu?=
 =?utf-8?B?RlptWmd0OW92ZllzVExoa3piMXZEUEYwUitaYkwvNlpoMEcrdHVBV2QwZnRm?=
 =?utf-8?B?c2xGQmpoVTdFTzkrbENGc1QxNmczU29GRU12Z2wvU0tPYk1vNlJoQkZ6ajJo?=
 =?utf-8?B?RCtIYkVlUGNxeTRSQ3FaRFdxSDBVT3pvK2IyYnhpMjFiL2NMZmxIRitvUlI3?=
 =?utf-8?B?VSsvYitwM3JJZGlGTzJGYWhLeVZhd1A1L3lZd1g3bjVBelVrTkFyNjNIV0c2?=
 =?utf-8?B?NnR5R2dqb0xQclBacjhZRTZHRllzQmF5bk40dTJ4Wjg3V3ROdVhsVzhsSzNC?=
 =?utf-8?B?eWVWcVVVNHVKdjUxOUpodWJZYU51R00rQUhLWDVUYnlMRXJJVUUwTUkrWDF0?=
 =?utf-8?B?SE5BNG43YUZobjRZUC8rcUpZV1FBTEFhVE9mL3RHZzJPR0Y3RUx0UUlJRTRz?=
 =?utf-8?B?QkREMFNLRVlxYU45b1JlelZoQ040Y0FuZFZiUmRUY3EyOVFHT2lrdExXZ1By?=
 =?utf-8?B?YzQyeHFJOTFLL2NWK3JjK3NsdXNaT21tMXdlN1pmcWpidVNwMHA1Q3RybVBG?=
 =?utf-8?B?Q253YkNYeFlndGppaDZRT2xudVQvemxHWHIycDNOU0ZOSlFGUCszcWFPdjVi?=
 =?utf-8?B?TU5NRGlPK3BQRjFJSDdNMEZLS3JwdHNKQ2liOUpSR0I3NlFNT3M4bmtMa0M4?=
 =?utf-8?B?eHoyVkVyaFJtRlQxRlh6YUt5RHBKY0RtaDMzaXRKSFJyRFZHY2F6cVFnb0Fw?=
 =?utf-8?B?RkJJanZFMEV1YjVxY2RIa0NKOTJBUXNoeFJFY1hvUjhRSGYxSkk4bmFuRmlu?=
 =?utf-8?B?ZExwVm8yWlpXOGlIbGh6RTFzSG5PcVVFS3BxK0VHN0lhM3BuMXgwczVVbk1H?=
 =?utf-8?B?Ylo0d1hKZC9Ccmh3a0xpd01pNHp4OHcwUERPL0JrTHJpRE0vQTBGYWw0SFV4?=
 =?utf-8?B?TWdWVjdIQXViRmMyZVN3eXhKRTFJNWdPYkk1QnVtSER2ZCtHZFNwUUVTWEN6?=
 =?utf-8?B?bGdiN2VKU2d5R2RkYncxYnlyaEhkcUIvRkJDbEJmMEtHMWU5UUYzNjBWcG5C?=
 =?utf-8?B?QmIzTmw2Y2JUZVUvRUVQdllOaFo0MUhadjUyTEF1ZTNNMTNLeE1HNjA1NjRk?=
 =?utf-8?B?bkJMZVI3dWF1Z2N3MHNRZ3BSaW45cTB0bGFTUFZUSWM2YUJ4N1FTenBsa1d3?=
 =?utf-8?B?Q2hNZUZnWnk4MkRJRjA3bWZ4Vk05WVl3M0JvZktSbFFRcGphV0loUEZVa24y?=
 =?utf-8?Q?CCFPB1sDbYSG3Eu8zEfZVs3vmTF661sOObVmYdKwUQ=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <F6A05843A2F97944A3E204A95013D66D@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM5PR03MB3386.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a4cee1e4-5b55-4621-ffee-08d9e65f5eb1
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Feb 2022 15:19:13.3391
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: v/fBlot4I4g3O7Zjo8iB088irgr5LtE6p7IaxzjpclEmGpsyzJo9omAJmnp2yBUVU0cuVU5zfIQUEtzo8JS3ALQX7o+axHj/pXn3isDhTuE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2624
X-OriginatorOrg: citrix.com

T24gMDEvMDIvMjAyMiAxMDowMiwgUm9nZXIgUGF1IE1vbm7DqSB3cm90ZToNCj4gT24gVGh1LCBK
YW4gMjcsIDIwMjIgYXQgMDQ6MDE6MzNQTSArMDAwMCwgSmFuZSBNYWxhbGFuZSB3cm90ZToNCj4+
IEludHJvZHVjZSBhIG5ldyBwZXItZG9tYWluIGNyZWF0aW9uIHg4NiBzcGVjaWZpYyBmbGFnIHRv
DQo+PiBzZWxlY3Qgd2hldGhlciBoYXJkd2FyZSBhc3Npc3RlZCB2aXJ0dWFsaXphdGlvbiBzaG91
bGQgYmUgdXNlZCBmb3INCj4+IHh7Mn1BUElDLg0KPj4NCj4+IEEgcGVyLWRvbWFpbiBvcHRpb24g
aXMgYWRkZWQgdG8geGwgaW4gb3JkZXIgdG8gc2VsZWN0IHRoZSB1c2FnZSBvZg0KPj4geHsyfUFQ
SUMgaGFyZHdhcmUgYXNzaXN0ZWQgdml0dWFsaXphdGlvbiwgYXMgd2VsbCBhcyBhIGdsb2JhbA0K
Pj4gY29uZmlndXJhdGlvbiBvcHRpb24uDQo+Pg0KPj4gSGF2aW5nIGFsbCBBUElDIGludGVyYWN0
aW9uIGV4aXQgdG8gWGVuIGZvciBlbXVsYXRpb24gaXMgc2xvdyBhbmQgY2FuDQo+PiBpbmR1Y2Ug
bXVjaCBvdmVyaGVhZC4gSGFyZHdhcmUgY2FuIHNwZWVkIHVwIHh7Mn1BUElDIGJ5IHJ1bm5pbmcg
QVBJQw0KPj4gcmVhZC93cml0ZSBhY2Nlc3NlcyB3aXRob3V0IHRha2luZyBhIFZNIGV4aXQuDQo+
Pg0KPj4gU2lnbmVkLW9mZi1ieTogSmFuZSBNYWxhbGFuZSA8amFuZS5tYWxhbGFuZUBjaXRyaXgu
Y29tPg0KPj4gU3VnZ2VzdGVkLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRy
aXguY29tPg0KPj4gLS0tDQo+PiBDQzogV2VpIExpdSA8d2xAeGVuLm9yZz4NCj4+IENDOiBBbnRo
b255IFBFUkFSRCA8YW50aG9ueS5wZXJhcmRAY2l0cml4LmNvbT4NCj4+IENDOiBKdWVyZ2VuIEdy
b3NzIDxqZ3Jvc3NAc3VzZS5jb20+DQo+PiBDQzogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3Bl
cjNAY2l0cml4LmNvbT4NCj4+IENDOiBHZW9yZ2UgRHVubGFwIDxnZW9yZ2UuZHVubGFwQGNpdHJp
eC5jb20+DQo+PiBDQzogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KPj4gQ0M6IEp1
bGllbiBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+PiBDQzogU3RlZmFubyBTdGFiZWxsaW5pIDxz
c3RhYmVsbGluaUBrZXJuZWwub3JnPg0KPj4gQ0M6IENocmlzdGlhbiBMaW5kaWcgPGNocmlzdGlh
bi5saW5kaWdAY2l0cml4LmNvbT4NCj4+IENDOiBEYXZpZCBTY290dCA8ZGF2ZUByZWNvaWwub3Jn
Pg0KPj4gQ0M6IFZvbG9keW15ciBCYWJjaHVrIDxWb2xvZHlteXJfQmFiY2h1a0BlcGFtLmNvbT4N
Cj4+IENDOiAiUm9nZXIgUGF1IE1vbm7DqSIgPHJvZ2VyLnBhdUBjaXRyaXguY29tPg0KPj4gLS0t
DQo+PiAgIGRvY3MvbWFuL3hsLmNmZy41LnBvZC5pbiAgICAgICAgICAgICAgfCAxMCArKysrKysr
Kw0KPj4gICBkb2NzL21hbi94bC5jb25mLjUucG9kLmluICAgICAgICAgICAgIHwgMTIgKysrKysr
KysrKw0KPj4gICB0b29scy9nb2xhbmcveGVubGlnaHQvaGVscGVycy5nZW4uZ28gIHwgMTIgKysr
KysrKysrKw0KPj4gICB0b29scy9saWJzL2xpZ2h0L2xpYnhsX2FyY2guaCAgICAgICAgIHwgIDUg
KystLQ0KPj4gICB0b29scy9saWJzL2xpZ2h0L2xpYnhsX2FybS5jICAgICAgICAgIHwgIDUgKyst
LQ0KPj4gICB0b29scy9saWJzL2xpZ2h0L2xpYnhsX2NyZWF0ZS5jICAgICAgIHwgMjEgKysrKysr
KysrKy0tLS0tLS0NCj4+ICAgdG9vbHMvbGlicy9saWdodC9saWJ4bF90eXBlcy5pZGwgICAgICB8
ICAyICsrDQo+PiAgIHRvb2xzL2xpYnMvbGlnaHQvbGlieGxfeDg2LmMgICAgICAgICAgfCA0MyAr
KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKystLQ0KPj4gICB0b29scy9vY2FtbC9saWJz
L3hjL3hlbmN0cmwubWwgICAgICAgIHwgIDIgKysNCj4+ICAgdG9vbHMvb2NhbWwvbGlicy94Yy94
ZW5jdHJsLm1saSAgICAgICB8ICAyICsrDQo+PiAgIHRvb2xzL3hsL3hsLmMgICAgICAgICAgICAg
ICAgICAgICAgICAgfCAgOCArKysrKysrDQo+PiAgIHRvb2xzL3hsL3hsLmggICAgICAgICAgICAg
ICAgICAgICAgICAgfCAgMiArKw0KPj4gICB0b29scy94bC94bF9wYXJzZS5jICAgICAgICAgICAg
ICAgICAgIHwgMTQgKysrKysrKysrKysrDQo+PiAgIHhlbi9hcmNoL3g4Ni9kb21haW4uYyAgICAg
ICAgICAgICAgICAgfCAyNyArKysrKysrKysrKysrKysrKysrKystDQo+PiAgIHhlbi9hcmNoL3g4
Ni9odm0vdm14L3ZtY3MuYyAgICAgICAgICAgfCAgNCArKysrDQo+PiAgIHhlbi9hcmNoL3g4Ni9o
dm0vdm14L3ZteC5jICAgICAgICAgICAgfCAxMyArKysrKysrLS0tLQ0KPj4gICB4ZW4vYXJjaC94
ODYvaW5jbHVkZS9hc20vaHZtL2RvbWFpbi5oIHwgIDYgKysrKysNCj4+ICAgeGVuL2FyY2gveDg2
L3RyYXBzLmMgICAgICAgICAgICAgICAgICB8ICA2ICsrKy0tDQo+PiAgIHhlbi9pbmNsdWRlL3B1
YmxpYy9hcmNoLXg4Ni94ZW4uaCAgICAgfCAgMiArKw0KPj4gICAxOSBmaWxlcyBjaGFuZ2VkLCAx
NzQgaW5zZXJ0aW9ucygrKSwgMjIgZGVsZXRpb25zKC0pDQo+Pg0KPj4gZGlmZiAtLWdpdCBhL2Rv
Y3MvbWFuL3hsLmNmZy41LnBvZC5pbiBiL2RvY3MvbWFuL3hsLmNmZy41LnBvZC5pbg0KPj4gaW5k
ZXggYjk4ZDE2MTM5OC4uOTc0ZmU3ZDJkOCAxMDA2NDQNCj4+IC0tLSBhL2RvY3MvbWFuL3hsLmNm
Zy41LnBvZC5pbg0KPj4gKysrIGIvZG9jcy9tYW4veGwuY2ZnLjUucG9kLmluDQo+PiBAQCAtMTg2
Miw2ICsxODYyLDE2IEBAIGZpcm13YXJlIHRhYmxlcyB3aGVuIHVzaW5nIGNlcnRhaW4gb2xkZXIg
Z3Vlc3QgT3BlcmF0aW5nDQo+PiAgIFN5c3RlbXMuIFRoZXNlIHRhYmxlcyBoYXZlIGJlZW4gc3Vw
ZXJzZWRlZCBieSBuZXdlciBjb25zdHJ1Y3RzIHdpdGhpbg0KPj4gICB0aGUgQUNQSSB0YWJsZXMu
DQo+PiAgIA0KPj4gKz1pdGVtIEI8YXNzaXN0ZWRfeGFwaWM9Qk9PTEVBTj4NCj4+ICtCPCh4ODYg
b25seSk+IEVuYWJsZXMgb3IgZGlzYWJsZXMgaGFyZHdhcmUgYXNzaXN0ZWQgdmlydHVhbGl6YXRp
b24gZm9yIHhhcGljLg0KPj4gK1RoaXMgYWxsb3dzIGFjY2Vzc2luZyBBUElDIHJlZ2lzdGVycyB3
aXRob3V0IGEgVk0tZXhpdC4NCj4+ICtUaGUgZGVmYXVsdCBpcyBzZXR0YWJsZSB2aWEgTDx4bC5j
b25mKDUpPi4NCj4+ICsNCj4+ICs9aXRlbSBCPGFzc2lzdGVkX3gyYXBpYz1CT09MRUFOPg0KPj4g
K0I8KHg4NiBvbmx5KT4gRW5hYmxlcyBvciBkaXNhYmxlcyBoYXJkd2FyZSBhc3Npc3RlZCB2aXJ0
dWFsaXphdGlvbiBmb3IgeDJhcGljLg0KPj4gK1RoaXMgYWxsb3dzIGFjY2Vzc2luZyBBUElDIHJl
Z2lzdGVycyB3aXRob3V0IGEgVk0tZXhpdC4NCj4+ICtUaGUgZGVmYXVsdCBpcyBzZXR0YWJsZSB2
aWEgTDx4bC5jb25mKDUpPi4NCj4gDQo+IExpa2UgeW91IGRvIGJlbG93IEkgd291bGQgY2FwaXRh
bGl6ZSB4QVBJQyBhbmQgeDJBUElDIGluIHRoZSBvcHRpb24NCj4gdGV4dC4NCj4gDQo+PiArDQo+
PiAgID1pdGVtIEI8bng9Qk9PTEVBTj4NCj4+ICAgDQo+PiAgIEI8KHg4NiBvbmx5KT4gSGlkZXMg
b3IgZXhwb3NlcyB0aGUgTm8tZVhlY3V0ZSBjYXBhYmlsaXR5LiBUaGlzIGFsbG93cyBhIGd1ZXN0
DQo+PiBkaWZmIC0tZ2l0IGEvZG9jcy9tYW4veGwuY29uZi41LnBvZC5pbiBiL2RvY3MvbWFuL3hs
LmNvbmYuNS5wb2QuaW4NCj4+IGluZGV4IGRmMjBjMDgxMzcuLjJkMGE1OWQwMTkgMTAwNjQ0DQo+
PiAtLS0gYS9kb2NzL21hbi94bC5jb25mLjUucG9kLmluDQo+PiArKysgYi9kb2NzL21hbi94bC5j
b25mLjUucG9kLmluDQo+PiBAQCAtMTA3LDYgKzEwNywxOCBAQCBTZXRzIHRoZSBkZWZhdWx0IHZh
bHVlIGZvciB0aGUgQzxtYXhfZ3JhbnRfdmVyc2lvbj4gZG9tYWluIGNvbmZpZyB2YWx1ZS4NCj4+
ICAgDQo+PiAgIERlZmF1bHQ6IG1heGltdW0gZ3JhbnQgdmVyc2lvbiBzdXBwb3J0ZWQgYnkgdGhl
IGh5cGVydmlzb3IuDQo+PiAgIA0KPj4gKz1pdGVtIEI8YXNzaXN0ZWRfeGFwaWM9Qk9PTEVBTj4N
Cj4+ICsNCj4+ICtJZiBlbmFibGVkLCBkb21haW5zIHdpbGwgdXNlIHhBUElDIGhhcmR3YXJlIGFz
c2lzdGVkIGVtdWxhdGlvbiBieSBkZWZhdWx0Lg0KPj4gKw0KPj4gK0RlZmF1bHQ6IGVuYWJsZWQu
DQo+PiArDQo+PiArPWl0ZW0gQjxhc3Npc3RlZF94MmFwaWM9Qk9PTEVBTj4NCj4+ICsNCj4+ICtJ
ZiBlbmFibGVkLCBkb21haW5zIHdpbGwgdXNlIHgyQVBJQyBoYXJkd2FyZSBhc3Npc3RlZCBlbXVs
YXRpb24gYnkgZGVmYXVsdC4NCj4+ICsNCj4+ICtEZWZhdWx0OiBlbmFibGVkLg0KPiANCj4gSSB0
aGluayBmb3IgYm90aCBvcHRpb25zIHRoaXMgc2hvdWxkIGJlOg0KPiANCj4gRGVmYXVsdDogZW5h
YmxlZCBpZiBzdXBwb3J0ZWQuDQo+IA0KPj4gKw0KPj4gICA9aXRlbSBCPHZpZi5kZWZhdWx0LnNj
cmlwdD0iUEFUSCI+DQo+PiAgIA0KPj4gICBDb25maWd1cmVzIHRoZSBkZWZhdWx0IGhvdHBsdWcg
c2NyaXB0IHVzZWQgYnkgdmlydHVhbCBuZXR3b3JrIGRldmljZXMuDQo+PiBkaWZmIC0tZ2l0IGEv
dG9vbHMvZ29sYW5nL3hlbmxpZ2h0L2hlbHBlcnMuZ2VuLmdvIGIvdG9vbHMvZ29sYW5nL3hlbmxp
Z2h0L2hlbHBlcnMuZ2VuLmdvDQo+PiBpbmRleCBkZDRlNmM5ZjE0Li45MGU3YjliMjA1IDEwMDY0
NA0KPj4gLS0tIGEvdG9vbHMvZ29sYW5nL3hlbmxpZ2h0L2hlbHBlcnMuZ2VuLmdvDQo+PiArKysg
Yi90b29scy9nb2xhbmcveGVubGlnaHQvaGVscGVycy5nZW4uZ28NCj4+IEBAIC02MzYsNiArNjM2
LDEyIEBAIHguUGFzc3Rocm91Z2ggPSBQYXNzdGhyb3VnaCh4Yy5wYXNzdGhyb3VnaCkNCj4+ICAg
aWYgZXJyIDo9IHguWGVuZFN1c3BlbmRFdnRjaG5Db21wYXQuZnJvbUMoJnhjLnhlbmRfc3VzcGVu
ZF9ldnRjaG5fY29tcGF0KTtlcnIgIT0gbmlsIHsNCj4+ICAgcmV0dXJuIGZtdC5FcnJvcmYoImNv
bnZlcnRpbmcgZmllbGQgWGVuZFN1c3BlbmRFdnRjaG5Db21wYXQ6ICV2IiwgZXJyKQ0KPj4gICB9
DQo+PiAraWYgZXJyIDo9IHguQXJjaFg4Ni5Bc3Npc3RlZFhhcGljLmZyb21DKCZ4Yy5hcmNoX3g4
Ni5hc3Npc3RlZF94YXBpYyk7ZXJyICE9IG5pbCB7DQo+PiArcmV0dXJuIGZtdC5FcnJvcmYoImNv
bnZlcnRpbmcgZmllbGQgQXJjaFg4Ni5Bc3Npc3RlZFhhcGljOiAldiIsIGVycikNCj4+ICt9DQo+
PiAraWYgZXJyIDo9IHguQXJjaFg4Ni5Bc3Npc3RlZFgyQXBpYy5mcm9tQygmeGMuYXJjaF94ODYu
YXNzaXN0ZWRfeDJhcGljKTtlcnIgIT0gbmlsIHsNCj4+ICtyZXR1cm4gZm10LkVycm9yZigiY29u
dmVydGluZyBmaWVsZCBBcmNoWDg2LkFzc2lzdGVkWDJBcGljOiAldiIsIGVycikNCj4+ICt9DQo+
PiAgIA0KPj4gICAgcmV0dXJuIG5pbH0NCj4+ICAgDQo+PiBAQCAtNjc5LDYgKzY4NSwxMiBAQCB4
Yy5wYXNzdGhyb3VnaCA9IEMubGlieGxfcGFzc3Rocm91Z2goeC5QYXNzdGhyb3VnaCkNCj4+ICAg
aWYgZXJyIDo9IHguWGVuZFN1c3BlbmRFdnRjaG5Db21wYXQudG9DKCZ4Yy54ZW5kX3N1c3BlbmRf
ZXZ0Y2huX2NvbXBhdCk7IGVyciAhPSBuaWwgew0KPj4gICByZXR1cm4gZm10LkVycm9yZigiY29u
dmVydGluZyBmaWVsZCBYZW5kU3VzcGVuZEV2dGNobkNvbXBhdDogJXYiLCBlcnIpDQo+PiAgIH0N
Cj4+ICtpZiBlcnIgOj0geC5BcmNoWDg2LkFzc2lzdGVkWGFwaWMudG9DKCZ4Yy5hcmNoX3g4Ni5h
c3Npc3RlZF94YXBpYyk7IGVyciAhPSBuaWwgew0KPj4gK3JldHVybiBmbXQuRXJyb3JmKCJjb252
ZXJ0aW5nIGZpZWxkIEFyY2hYODYuQXNzaXN0ZWRYYXBpYzogJXYiLCBlcnIpDQo+PiArfQ0KPj4g
K2lmIGVyciA6PSB4LkFyY2hYODYuQXNzaXN0ZWRYMkFwaWMudG9DKCZ4Yy5hcmNoX3g4Ni5hc3Np
c3RlZF94MmFwaWMpOyBlcnIgIT0gbmlsIHsNCj4+ICtyZXR1cm4gZm10LkVycm9yZigiY29udmVy
dGluZyBmaWVsZCBBcmNoWDg2LkFzc2lzdGVkWDJBcGljOiAldiIsIGVycikNCj4+ICt9DQo+PiAg
IA0KPj4gICAgcmV0dXJuIG5pbA0KPj4gICAgfQ0KPj4gZGlmZiAtLWdpdCBhL3Rvb2xzL2xpYnMv
bGlnaHQvbGlieGxfYXJjaC5oIGIvdG9vbHMvbGlicy9saWdodC9saWJ4bF9hcmNoLmgNCj4+IGlu
ZGV4IDAwY2M1MDM5NGQuLjJlYWZmNDU1MjYgMTAwNjQ0DQo+PiAtLS0gYS90b29scy9saWJzL2xp
Z2h0L2xpYnhsX2FyY2guaA0KPj4gKysrIGIvdG9vbHMvbGlicy9saWdodC9saWJ4bF9hcmNoLmgN
Cj4+IEBAIC03MSw4ICs3MSw5IEBAIHZvaWQgbGlieGxfX2FyY2hfZG9tYWluX2NyZWF0ZV9pbmZv
X3NldGRlZmF1bHQobGlieGxfX2djICpnYywNCj4+ICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICBsaWJ4bF9kb21haW5fY3JlYXRlX2luZm8gKmNfaW5mbyk7
DQo+PiAgIA0KPj4gICBfaGlkZGVuDQo+PiAtdm9pZCBsaWJ4bF9fYXJjaF9kb21haW5fYnVpbGRf
aW5mb19zZXRkZWZhdWx0KGxpYnhsX19nYyAqZ2MsDQo+PiAtICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgIGxpYnhsX2RvbWFpbl9idWlsZF9pbmZvICpiX2luZm8p
Ow0KPj4gK2ludCBsaWJ4bF9fYXJjaF9kb21haW5fYnVpbGRfaW5mb19zZXRkZWZhdWx0KGxpYnhs
X19nYyAqZ2MsDQo+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgbGlieGxfZG9tYWluX2J1aWxkX2luZm8gKmJfaW5mbywNCj4+ICsgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBsaWJ4bF9waHlzaW5mbyAqcGh5c2lu
Zm8pOw0KPj4gICANCj4+ICAgX2hpZGRlbg0KPj4gICBpbnQgbGlieGxfX2FyY2hfcGFzc3Rocm91
Z2hfbW9kZV9zZXRkZWZhdWx0KGxpYnhsX19nYyAqZ2MsDQo+PiBkaWZmIC0tZ2l0IGEvdG9vbHMv
bGlicy9saWdodC9saWJ4bF9hcm0uYyBiL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfYXJtLmMNCj4+
IGluZGV4IDUyZjI1NDU0OTguLjRkNDIyYmVmOTYgMTAwNjQ0DQo+PiAtLS0gYS90b29scy9saWJz
L2xpZ2h0L2xpYnhsX2FybS5jDQo+PiArKysgYi90b29scy9saWJzL2xpZ2h0L2xpYnhsX2FybS5j
DQo+PiBAQCAtMTM4NCw4ICsxMzg0LDkgQEAgdm9pZCBsaWJ4bF9fYXJjaF9kb21haW5fY3JlYXRl
X2luZm9fc2V0ZGVmYXVsdChsaWJ4bF9fZ2MgKmdjLA0KPj4gICAgICAgfQ0KPj4gICB9DQo+PiAg
IA0KPj4gLXZvaWQgbGlieGxfX2FyY2hfZG9tYWluX2J1aWxkX2luZm9fc2V0ZGVmYXVsdChsaWJ4
bF9fZ2MgKmdjLA0KPj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICBsaWJ4bF9kb21haW5fYnVpbGRfaW5mbyAqYl9pbmZvKQ0KPj4gK2ludCBsaWJ4bF9fYXJj
aF9kb21haW5fYnVpbGRfaW5mb19zZXRkZWZhdWx0KGxpYnhsX19nYyAqZ2MsDQo+PiArICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbGlieGxfZG9tYWluX2J1aWxk
X2luZm8gKmJfaW5mbywNCj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICBjb25zdCBsaWJ4bF9waHlzaW5mbyAqcGh5c2luZm8pDQo+PiAgIHsNCj4+ICAgICAg
IC8qIEFDUEkgaXMgZGlzYWJsZWQgYnkgZGVmYXVsdCAqLw0KPj4gICAgICAgbGlieGxfZGVmYm9v
bF9zZXRkZWZhdWx0KCZiX2luZm8tPmFjcGksIGZhbHNlKTsNCj4+IGRpZmYgLS1naXQgYS90b29s
cy9saWJzL2xpZ2h0L2xpYnhsX2NyZWF0ZS5jIGIvdG9vbHMvbGlicy9saWdodC9saWJ4bF9jcmVh
dGUuYw0KPj4gaW5kZXggZDdhNDBkNzU1MC4uMmJhZTZmZWY2MiAxMDA2NDQNCj4+IC0tLSBhL3Rv
b2xzL2xpYnMvbGlnaHQvbGlieGxfY3JlYXRlLmMNCj4+ICsrKyBiL3Rvb2xzL2xpYnMvbGlnaHQv
bGlieGxfY3JlYXRlLmMNCj4+IEBAIC0yNjQsNyArMjY0LDYgQEAgaW50IGxpYnhsX19kb21haW5f
YnVpbGRfaW5mb19zZXRkZWZhdWx0KGxpYnhsX19nYyAqZ2MsDQo+PiAgICAgICBpZiAoIWJfaW5m
by0+ZXZlbnRfY2hhbm5lbHMpDQo+PiAgICAgICAgICAgYl9pbmZvLT5ldmVudF9jaGFubmVscyA9
IDEwMjM7DQo+PiAgIA0KPj4gLSAgICBsaWJ4bF9fYXJjaF9kb21haW5fYnVpbGRfaW5mb19zZXRk
ZWZhdWx0KGdjLCBiX2luZm8pOw0KPj4gICAgICAgbGlieGxfZGVmYm9vbF9zZXRkZWZhdWx0KCZi
X2luZm8tPmRtX3Jlc3RyaWN0LCBmYWxzZSk7DQo+PiAgIA0KPj4gICAgICAgaWYgKGJfaW5mby0+
aW9tbXVfbWVta2IgPT0gTElCWExfTUVNS0JfREVGQVVMVCkNCj4+IEBAIC00NTYsMTUgKzQ1NSwy
MSBAQCBpbnQgbGlieGxfX2RvbWFpbl9idWlsZF9pbmZvX3NldGRlZmF1bHQobGlieGxfX2djICpn
YywNCj4+ICAgICAgICAgICBsaWJ4bF9kZWZib29sX3NldGRlZmF1bHQoJmJfaW5mby0+bmVzdGVk
X2h2bSwgICAgICAgICAgICAgICBmYWxzZSk7DQo+PiAgICAgICB9DQo+PiAgIA0KPj4gLSAgICBp
ZiAoYl9pbmZvLT5tYXhfZ3JhbnRfdmVyc2lvbiA9PSBMSUJYTF9NQVhfR1JBTlRfREVGQVVMVCkg
ew0KPj4gLSAgICAgICAgbGlieGxfcGh5c2luZm8gaW5mbzsNCj4+ICsgICAgbGlieGxfcGh5c2lu
Zm8gaW5mbzsNCj4+ICAgDQo+PiAtICAgICAgICByYyA9IGxpYnhsX2dldF9waHlzaW5mbyhDVFgs
ICZpbmZvKTsNCj4+IC0gICAgICAgIGlmIChyYykgew0KPj4gLSAgICAgICAgICAgIExPRyhFUlJP
UiwgImZhaWxlZCB0byBnZXQgaHlwZXJ2aXNvciBpbmZvIik7DQo+PiAtICAgICAgICAgICAgcmV0
dXJuIHJjOw0KPj4gLSAgICAgICAgfQ0KPj4gKyAgICByYyA9IGxpYnhsX2dldF9waHlzaW5mbyhD
VFgsICZpbmZvKTsNCj4+ICsgICAgaWYgKHJjKSB7DQo+PiArICAgICAgICBMT0coRVJST1IsICJm
YWlsZWQgdG8gZ2V0IGh5cGVydmlzb3IgaW5mbyIpOw0KPj4gKyAgICAgICAgcmV0dXJuIHJjOw0K
Pj4gKyAgICB9DQo+PiAgIA0KPj4gKyAgICByYyA9IGxpYnhsX19hcmNoX2RvbWFpbl9idWlsZF9p
bmZvX3NldGRlZmF1bHQoZ2MsIGJfaW5mbywgJmluZm8pOw0KPj4gKyAgICBpZiAocmMpIHsNCj4+
ICsgICAgICAgIExPRyhFUlJPUiwgInVuYWJsZSB0byBzZXQgZG9tYWluIGFyY2ggYnVpbGQgaW5m
byBkZWZhdWx0cyIpOw0KPj4gKyAgICAgICAgcmV0dXJuIHJjOw0KPj4gKyAgICB9DQo+PiArDQo+
PiArICAgIGlmIChiX2luZm8tPm1heF9ncmFudF92ZXJzaW9uID09IExJQlhMX01BWF9HUkFOVF9E
RUZBVUxUKSB7DQo+PiAgICAgICAgICAgaWYgKGluZm8uY2FwX2dudHRhYl92MikNCj4+ICAgICAg
ICAgICAgICAgYl9pbmZvLT5tYXhfZ3JhbnRfdmVyc2lvbiA9IDI7DQo+PiAgICAgICAgICAgZWxz
ZSBpZiAoaW5mby5jYXBfZ250dGFiX3YxKQ0KPj4gZGlmZiAtLWdpdCBhL3Rvb2xzL2xpYnMvbGln
aHQvbGlieGxfdHlwZXMuaWRsIGIvdG9vbHMvbGlicy9saWdodC9saWJ4bF90eXBlcy5pZGwNCj4+
IGluZGV4IDQyYWM2YzM1N2IuLmRiNWViMGEwYjMgMTAwNjQ0DQo+PiAtLS0gYS90b29scy9saWJz
L2xpZ2h0L2xpYnhsX3R5cGVzLmlkbA0KPj4gKysrIGIvdG9vbHMvbGlicy9saWdodC9saWJ4bF90
eXBlcy5pZGwNCj4+IEBAIC02NDgsNiArNjQ4LDggQEAgbGlieGxfZG9tYWluX2J1aWxkX2luZm8g
PSBTdHJ1Y3QoImRvbWFpbl9idWlsZF9pbmZvIixbDQo+PiAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAoInZ1YXJ0IiwgbGlieGxfdnVhcnRfdHlwZSksDQo+PiAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgIF0pKSwNCj4+ICAgICAgICgiYXJjaF94ODYiLCBTdHJ1Y3QoTm9u
ZSwgWygibXNyX3JlbGF4ZWQiLCBsaWJ4bF9kZWZib29sKSwNCj4+ICsgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgKCJhc3Npc3RlZF94YXBpYyIsIGxpYnhsX2RlZmJvb2wpLA0KPj4gKyAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoImFzc2lzdGVkX3gyYXBpYyIsIGxpYnhsX2Rl
ZmJvb2wpLA0KPj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBdKSksDQo+PiAgICAg
ICAjIEFsdGVybmF0ZSBwMm0gaXMgbm90IGJvdW5kIHRvIGFueSBhcmNoaXRlY3R1cmUgb3IgZ3Vl
c3QgdHlwZSwgYXMgaXQgaXMNCj4+ICAgICAgICMgc3VwcG9ydGVkIGJ5IHg4NiBIVk0gYW5kIEFS
TSBzdXBwb3J0IGlzIHBsYW5uZWQuDQo+PiBkaWZmIC0tZ2l0IGEvdG9vbHMvbGlicy9saWdodC9s
aWJ4bF94ODYuYyBiL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfeDg2LmMNCj4+IGluZGV4IDMzZGE1
MWZlODkuLmIyNTdmY2E3NTYgMTAwNjQ0DQo+PiAtLS0gYS90b29scy9saWJzL2xpZ2h0L2xpYnhs
X3g4Ni5jDQo+PiArKysgYi90b29scy9saWJzL2xpZ2h0L2xpYnhsX3g4Ni5jDQo+PiBAQCAtMjMs
NiArMjMsMTIgQEAgaW50IGxpYnhsX19hcmNoX2RvbWFpbl9wcmVwYXJlX2NvbmZpZyhsaWJ4bF9f
Z2MgKmdjLA0KPj4gICAgICAgaWYgKGxpYnhsX2RlZmJvb2xfdmFsKGRfY29uZmlnLT5iX2luZm8u
YXJjaF94ODYubXNyX3JlbGF4ZWQpKQ0KPj4gICAgICAgICAgIGNvbmZpZy0+YXJjaC5taXNjX2Zs
YWdzIHw9IFhFTl9YODZfTVNSX1JFTEFYRUQ7DQo+PiAgIA0KPj4gKyAgICBpZihsaWJ4bF9kZWZi
b29sX3ZhbChkX2NvbmZpZy0+Yl9pbmZvLmFyY2hfeDg2LmFzc2lzdGVkX3hhcGljKSkNCj4+ICsg
ICAgICAgIGNvbmZpZy0+YXJjaC5taXNjX2ZsYWdzIHw9IFhFTl9YODZfQVNTSVNURURfWEFQSUM7
DQo+PiArDQo+PiArICAgIGlmKGxpYnhsX2RlZmJvb2xfdmFsKGRfY29uZmlnLT5iX2luZm8uYXJj
aF94ODYuYXNzaXN0ZWRfeDJhcGljKSkNCj4+ICsgICAgICAgIGNvbmZpZy0+YXJjaC5taXNjX2Zs
YWdzIHw9IFhFTl9YODZfQVNTSVNURURfWDJBUElDOw0KPj4gKw0KPj4gICAgICAgcmV0dXJuIDA7
DQo+PiAgIH0NCj4+ICAgDQo+PiBAQCAtODE5LDExICs4MjUsNDQgQEAgdm9pZCBsaWJ4bF9fYXJj
aF9kb21haW5fY3JlYXRlX2luZm9fc2V0ZGVmYXVsdChsaWJ4bF9fZ2MgKmdjLA0KPj4gICB7DQo+
PiAgIH0NCj4+ICAgDQo+PiAtdm9pZCBsaWJ4bF9fYXJjaF9kb21haW5fYnVpbGRfaW5mb19zZXRk
ZWZhdWx0KGxpYnhsX19nYyAqZ2MsDQo+PiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgIGxpYnhsX2RvbWFpbl9idWlsZF9pbmZvICpiX2luZm8pDQo+PiAraW50
IGxpYnhsX19hcmNoX2RvbWFpbl9idWlsZF9pbmZvX3NldGRlZmF1bHQobGlieGxfX2djICpnYywN
Cj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBsaWJ4bF9k
b21haW5fYnVpbGRfaW5mbyAqYl9pbmZvLA0KPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgIGNvbnN0IGxpYnhsX3BoeXNpbmZvICpwaHlzaW5mbykNCj4+ICAg
ew0KPj4gKyAgICBpbnQgcmM7DQo+PiArICAgIGJvb2wgYXNzaXN0ZWRfeGFwaWM7DQo+PiArICAg
IGJvb2wgYXNzaXN0ZWRfeDJhcGljOw0KPj4gKw0KPj4gICAgICAgbGlieGxfZGVmYm9vbF9zZXRk
ZWZhdWx0KCZiX2luZm8tPmFjcGksIHRydWUpOw0KPj4gICAgICAgbGlieGxfZGVmYm9vbF9zZXRk
ZWZhdWx0KCZiX2luZm8tPmFyY2hfeDg2Lm1zcl9yZWxheGVkLCBmYWxzZSk7DQo+PiArDQo+PiAr
ICAgIGxpYnhsX2RlZmJvb2xfc2V0ZGVmYXVsdCgmYl9pbmZvLT5hcmNoX3g4Ni5hc3Npc3RlZF94
YXBpYywgZmFsc2UpOw0KPj4gKyAgICBsaWJ4bF9kZWZib29sX3NldGRlZmF1bHQoJmJfaW5mby0+
YXJjaF94ODYuYXNzaXN0ZWRfeDJhcGljLCBmYWxzZSk7DQo+PiArDQo+PiArICAgIGFzc2lzdGVk
X3hhcGljID0gbGlieGxfZGVmYm9vbF92YWwoYl9pbmZvLT5hcmNoX3g4Ni5hc3Npc3RlZF94YXBp
Yyk7DQo+PiArICAgIGFzc2lzdGVkX3gyYXBpYyA9IGxpYnhsX2RlZmJvb2xfdmFsKGJfaW5mby0+
YXJjaF94ODYuYXNzaXN0ZWRfeDJhcGljKTsNCj4+ICsNCj4+ICsgICAgaWYgKChhc3Npc3RlZF94
YXBpYyB8fCBhc3Npc3RlZF94MmFwaWMpICYmDQo+PiArICAgICAgICBiX2luZm8tPnR5cGUgPT0g
TElCWExfRE9NQUlOX1RZUEVfUFYpDQo+PiArICAgIHsNCj4+ICsgICAgICAgIExPRyhFUlJPUiwg
IkludGVycnVwdCBDb250cm9sbGVyIFZpcnR1YWxpemF0aW9uIG5vdCBzdXBwb3J0ZWQgZm9yIFBW
Iik7DQo+PiArICAgICAgICByYyA9IEVSUk9SX0lOVkFMOw0KPj4gKyAgICAgICAgZ290byBvdXQ7
DQo+PiArICAgIH0NCj4+ICsNCj4+ICsgICAgaWYgKChhc3Npc3RlZF94YXBpYyAmJiAhcGh5c2lu
Zm8tPmNhcF9hc3Npc3RlZF94YXBpYykgfHwNCj4+ICsgICAgICAgICAoYXNzaXN0ZWRfeDJhcGlj
ICYmICFwaHlzaW5mby0+Y2FwX2Fzc2lzdGVkX3gyYXBpYykpDQo+PiArICAgIHsNCj4+ICsgICAg
ICAgIExPRyhFUlJPUiwgInglc0FQSUMgaGFyZHdhcmUgc3VwcG9ydGVkIGVtdWxhdGlvbiBub3Qg
YXZhaWxhYmxlIiwNCj4+ICsgICAgICAgICAgICBhc3Npc3RlZF94YXBpYyAmJiAhcGh5c2luZm8t
PmNhcF9hc3Npc3RlZF94YXBpYyA/ICIiIDogIjIiKTsNCj4+ICsgICAgICAgIHJjID0gIEVSUk9S
X0lOVkFMOw0KPj4gKyAgICAgICAgZ290byBvdXQ7DQo+PiArICAgIH0NCj4gDQo+IEkgdGhpbmsg
dGhlIGxvZ2ljIGhlcmUgaXMgc2xpZ2h0bHkgd3JvbmcsIGFzIHlvdSBhcmUgc2V0dGluZyB0aGUN
Cj4gZGVmYXVsdCB2YWx1ZSBvZiBhc3Npc3RlZF94ezJ9YXBpYyB0byBmYWxzZSwgYW5kIHdlIHdv
dWxkIGluc3RlYWQgbGlrZQ0KPiB0byBzZXQgaXQgdG8gdGhlIGN1cnJlbnQgdmFsdWUgc3VwcG9y
dGVkIGJ5IHRoZSBoYXJkd2FyZSBpbiBvcmRlciB0bw0KPiBrZWVwIGN1cnJlbnQgYmVoYXZpb3Iu
DQo+IA0KPiBBbHNvIHRoZSBvcHRpb25zIGFyZSBIVk0vUFZIIG9ubHksIHNvIGhhdmluZyB0aGVt
IHNldCBmb3IgUFYgc2hvdWxkDQo+IHJlc3VsdCBpbiBhbiBlcnJvciByZWdhcmRsZXNzIG9mIHRo
ZSBzZXQgdmFsdWUsIGllOg0KPiANCj4gaWYgKGJfaW5mby0+dHlwZSA9PSBMSUJYTF9ET01BSU5f
VFlQRV9QViAmJg0KPiAgICAgICghbGlieGxfZGVmYm9vbF9pc19kZWZhdWx0KCZiX2luZm8tPmFy
Y2hfeDg2LmFzc2lzdGVkX3hhcGljKSB8fA0KPiAgICAgICAhbGlieGxfZGVmYm9vbF9pc19kZWZh
dWx0KCZiX2luZm8tPmFyY2hfeDg2LmFzc2lzdGVkX3gyYXBpYykpKQ0KPiAgICAgICBFUlJPUg0K
PiANCj4gbGlieGxfZGVmYm9vbF9zZXRkZWZhdWx0KCZiX2luZm8tPmFyY2hfeDg2LmFzc2lzdGVk
X3hhcGljLA0KPiAgICAgICAgICAgICAgICAgICAgICAgICAgIHBoeXNpbmZvLT5jYXBfYXNzaXN0
ZWRfeGFwaWMpOw0KPiBsaWJ4bF9kZWZib29sX3NldGRlZmF1bHQoJmJfaW5mby0+YXJjaF94ODYu
YXNzaXN0ZWRfeDJhcGljLA0KPiAgICAgICAgICAgICAgICAgICAgICAgICAgIHBoeXNpbmZvLT5j
YXBfYXNzaXN0ZWRfeDJhcGljKTsNCj4gDQo+IEkgZG9uJ3QgdGhpbmsgeW91IG5lZWQgdGhlIGxv
Y2FsIGFzc2lzdGVkX3h7Mn1hcGljIHZhcmlhYmxlcy4NCg0KTWFrZXMgc2Vuc2UuIEluIHRoYXQg
Y2FzZSwgY291bGQgSSBpbnN0ZWFkIGp1c3QgaGF2ZSB0aGlzPw0KDQppZiAoYl9pbmZvLT50eXBl
ICE9IExJQlhMX0RPTUFJTl9UWVBFX1BWKQ0Kew0KICAgICBpZiAocGh5c2luZm8tPmNhcF9hc3Np
c3RlZF94YXBpYykNCiAgICAgICAgIGxpYnhsX2RlZmJvb2xfc2V0ZGVmYXVsdCgmYl9pbmZvLT5h
cmNoX3g4Ni5hc3Npc3RlZF94YXBpYywgdHJ1ZSk7DQogICAgIGlmIChwaHlzaW5mby0+Y2FwX2Fz
c2lzdGVkX3gyYXBpYykNCiAgICAgICAgIGxpYnhsX2RlZmJvb2xfc2V0ZGVmYXVsdCgmYl9pbmZv
LT5hcmNoX3g4Ni5hc3Npc3RlZF94MmFwaWMsIHRydWUpOw0KfQ0KDQpPciBkbyBpIHN0aWxsIG5l
ZWQgdG8gYWxzbyBjaGVjayB0aGF0IGFzc2lzdGVkX3h7Mn1hcGljIGhhc24ndCBiZWVuIHNldCAN
CmVsc2V3aGVyZSBmb3IgUFYgZG9tYWlucywgaW4gd2hpY2ggY2FzZSwgSSdtIGhhcHB5IHRvIGFk
ZCB0aGUgY29kZSB5b3UgDQpwcm9wb3NlZCBhYm92ZSB3aXRoIHRoaXMgY29kZSBJIGhhdmUgaGVy
ZSB0b28uDQo+IA0KPj4gKw0KPj4gKyAgICByYyA9IDA7DQo+PiArb3V0Og0KPj4gKyAgICByZXR1
cm4gcmM7DQo+IA0KPiBUaGUgb3V0IGxhYmVsIGlzIG5vdCByZWFsbHkgbmVlZGVkIGhlcmUgYW5k
IG1ha2VzIHRoZSBjb2RlIGxvbmdlci4NCj4gSnVzdCAncmV0dXJuIEVSUk9SX0lOVkFMJyBpbiB0
aGUgZXJyb3IgcGF0aHMgb3IgMCBhdCB0aGUgZW5kIG9mIHRoZQ0KPiBmdW5jdGlvbi4gWW91IGNh
biB0aGVuIGFsc28gZHJvcCB0aGUgbG9jYWwgcmMgdmFyaWFibGUuDQo+IA0KPj4gKw0KPj4gICB9
DQo+PiAgIA0KPj4gICBpbnQgbGlieGxfX2FyY2hfcGFzc3Rocm91Z2hfbW9kZV9zZXRkZWZhdWx0
KGxpYnhsX19nYyAqZ2MsDQo+PiBkaWZmIC0tZ2l0IGEvdG9vbHMvb2NhbWwvbGlicy94Yy94ZW5j
dHJsLm1sIGIvdG9vbHMvb2NhbWwvbGlicy94Yy94ZW5jdHJsLm1sDQo+PiBpbmRleCA3Y2U4MzJk
NjA1Li5jY2UzMGQ4NzMxIDEwMDY0NA0KPj4gLS0tIGEvdG9vbHMvb2NhbWwvbGlicy94Yy94ZW5j
dHJsLm1sDQo+PiArKysgYi90b29scy9vY2FtbC9saWJzL3hjL3hlbmN0cmwubWwNCj4+IEBAIC01
MCw2ICs1MCw4IEBAIHR5cGUgeDg2X2FyY2hfZW11bGF0aW9uX2ZsYWdzID0NCj4+ICAgDQo+PiAg
IHR5cGUgeDg2X2FyY2hfbWlzY19mbGFncyA9DQo+PiAgIAl8IFg4Nl9NU1JfUkVMQVhFRA0KPj4g
Kwl8IFg4Nl9BU1NJU1RFRF9YQVBJQw0KPj4gKwl8IFg4Nl9BU1NJU1RFRF9YMkFQSUMNCj4+ICAg
DQo+PiAgIHR5cGUgeGVuX3g4Nl9hcmNoX2RvbWFpbmNvbmZpZyA9DQo+PiAgIHsNCj4+IGRpZmYg
LS1naXQgYS90b29scy9vY2FtbC9saWJzL3hjL3hlbmN0cmwubWxpIGIvdG9vbHMvb2NhbWwvbGli
cy94Yy94ZW5jdHJsLm1saQ0KPj4gaW5kZXggYTJiMTUxMzBlZS4uNjdhMjJlYzE1YyAxMDA2NDQN
Cj4+IC0tLSBhL3Rvb2xzL29jYW1sL2xpYnMveGMveGVuY3RybC5tbGkNCj4+ICsrKyBiL3Rvb2xz
L29jYW1sL2xpYnMveGMveGVuY3RybC5tbGkNCj4+IEBAIC00NCw2ICs0NCw4IEBAIHR5cGUgeDg2
X2FyY2hfZW11bGF0aW9uX2ZsYWdzID0NCj4+ICAgDQo+PiAgIHR5cGUgeDg2X2FyY2hfbWlzY19m
bGFncyA9DQo+PiAgICAgfCBYODZfTVNSX1JFTEFYRUQNCj4+ICsgIHwgWDg2X0FTU0lTVEVEX1hB
UElDDQo+PiArICB8IFg4Nl9BU1NJU1RFRF9YMkFQSUMNCj4+ICAgDQo+PiAgIHR5cGUgeGVuX3g4
Nl9hcmNoX2RvbWFpbmNvbmZpZyA9IHsNCj4+ICAgICBlbXVsYXRpb25fZmxhZ3M6IHg4Nl9hcmNo
X2VtdWxhdGlvbl9mbGFncyBsaXN0Ow0KPj4gZGlmZiAtLWdpdCBhL3Rvb2xzL3hsL3hsLmMgYi90
b29scy94bC94bC5jDQo+PiBpbmRleCAyZDFlYzE4ZWEzLi5iOTdlNDkxYzljIDEwMDY0NA0KPj4g
LS0tIGEvdG9vbHMveGwveGwuYw0KPj4gKysrIGIvdG9vbHMveGwveGwuYw0KPj4gQEAgLTU3LDYg
KzU3LDggQEAgaW50IG1heF9ncmFudF9mcmFtZXMgPSAtMTsNCj4+ICAgaW50IG1heF9tYXB0cmFj
a19mcmFtZXMgPSAtMTsNCj4+ICAgaW50IG1heF9ncmFudF92ZXJzaW9uID0gTElCWExfTUFYX0dS
QU5UX0RFRkFVTFQ7DQo+PiAgIGxpYnhsX2RvbWlkIGRvbWlkX3BvbGljeSA9IElOVkFMSURfRE9N
SUQ7DQo+PiAraW50IGFzc2lzdGVkX3hhcGljID0gMDsNCj4+ICtpbnQgYXNzaXN0ZWRfeDJhcGlj
ID0gMDsNCj4gDQo+IFRoaXMgc2hvdWxkIGJlIGluaXRpYWxpemVkIHRvIC0xLCBpbiBvcmRlciB0
byBkZW5vdGUgdGhlIHZhbHVlcyBhcmUNCj4gdW5zZXQuLi4NCj4gDQo+PiAgIA0KPj4gICB4ZW50
b29sbG9nX2xldmVsIG1pbm1zZ2xldmVsID0gbWlubXNnbGV2ZWxfZGVmYXVsdDsNCj4+ICAgDQo+
PiBAQCAtMjAxLDYgKzIwMywxMiBAQCBzdGF0aWMgdm9pZCBwYXJzZV9nbG9iYWxfY29uZmlnKGNv
bnN0IGNoYXIgKmNvbmZpZ2ZpbGUsDQo+PiAgICAgICBpZiAoIXhsdV9jZmdfZ2V0X2xvbmcgKGNv
bmZpZywgImNsYWltX21vZGUiLCAmbCwgMCkpDQo+PiAgICAgICAgICAgY2xhaW1fbW9kZSA9IGw7
DQo+PiAgIA0KPj4gKyAgICBpZiAoIXhsdV9jZmdfZ2V0X2xvbmcgKGNvbmZpZywgImFzc2lzdGVk
X3hhcGljIiwgJmwsIDApKQ0KPj4gKyAgICAgICAgYXNzaXN0ZWRfeGFwaWMgPSBsOw0KPj4gKw0K
Pj4gKyAgICBpZiAoIXhsdV9jZmdfZ2V0X2xvbmcgKGNvbmZpZywgImFzc2lzdGVkX3gyYXBpYyIs
ICZsLCAwKSkNCj4+ICsgICAgICAgIGFzc2lzdGVkX3gyYXBpYyA9IGw7DQo+PiArDQo+PiAgICAg
ICB4bHVfY2ZnX3JlcGxhY2Vfc3RyaW5nIChjb25maWcsICJyZW11cy5kZWZhdWx0Lm5ldGJ1ZnNj
cmlwdCIsDQo+PiAgICAgICAgICAgJmRlZmF1bHRfcmVtdXNfbmV0YnVmc2NyaXB0LCAwKTsNCj4+
ICAgICAgIHhsdV9jZmdfcmVwbGFjZV9zdHJpbmcgKGNvbmZpZywgImNvbG8uZGVmYXVsdC5wcm94
eXNjcmlwdCIsDQo+PiBkaWZmIC0tZ2l0IGEvdG9vbHMveGwveGwuaCBiL3Rvb2xzL3hsL3hsLmgN
Cj4+IGluZGV4IGM1YzRiZWRiZGQuLjUyOGRlYjNmZWIgMTAwNjQ0DQo+PiAtLS0gYS90b29scy94
bC94bC5oDQo+PiArKysgYi90b29scy94bC94bC5oDQo+PiBAQCAtMjg2LDYgKzI4Niw4IEBAIGV4
dGVybiBsaWJ4bF9iaXRtYXAgZ2xvYmFsX3ZtX2FmZmluaXR5X21hc2s7DQo+PiAgIGV4dGVybiBs
aWJ4bF9iaXRtYXAgZ2xvYmFsX2h2bV9hZmZpbml0eV9tYXNrOw0KPj4gICBleHRlcm4gbGlieGxf
Yml0bWFwIGdsb2JhbF9wdl9hZmZpbml0eV9tYXNrOw0KPj4gICBleHRlcm4gbGlieGxfZG9taWQg
ZG9taWRfcG9saWN5Ow0KPj4gK2V4dGVybiBpbnQgYXNzaXN0ZWRfeGFwaWM7DQo+PiArZXh0ZXJu
IGludCBhc3Npc3RlZF94MmFwaWM7DQo+PiAgIA0KPj4gICBlbnVtIG91dHB1dF9mb3JtYXQgew0K
Pj4gICAgICAgT1VUUFVUX0ZPUk1BVF9KU09OLA0KPj4gZGlmZiAtLWdpdCBhL3Rvb2xzL3hsL3hs
X3BhcnNlLmMgYi90b29scy94bC94bF9wYXJzZS5jDQo+PiBpbmRleCAxMTdmY2RjYjJiLi4xNmZm
OWU3NmJjIDEwMDY0NA0KPj4gLS0tIGEvdG9vbHMveGwveGxfcGFyc2UuYw0KPj4gKysrIGIvdG9v
bHMveGwveGxfcGFyc2UuYw0KPj4gQEAgLTE2ODEsNiArMTY4MSwyMCBAQCB2b2lkIHBhcnNlX2Nv
bmZpZ19kYXRhKGNvbnN0IGNoYXIgKmNvbmZpZ19zb3VyY2UsDQo+PiAgICAgICAgICAgeGx1X2Nm
Z19nZXRfZGVmYm9vbChjb25maWcsICJ2cHRfYWxpZ24iLCAmYl9pbmZvLT51Lmh2bS52cHRfYWxp
Z24sIDApOw0KPj4gICAgICAgICAgIHhsdV9jZmdfZ2V0X2RlZmJvb2woY29uZmlnLCAiYXBpYyIs
ICZiX2luZm8tPmFwaWMsIDApOw0KPj4gICANCj4+ICsgICAgICAgIGUgPSB4bHVfY2ZnX2dldF9k
ZWZib29sKGNvbmZpZywgImFzc2lzdGVkX3hhcGljIiwNCj4+ICsgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICZiX2luZm8tPmFyY2hfeDg2LmFzc2lzdGVkX3hhcGljLCAwKTsNCj4+ICsg
ICAgICAgIGlmIChlID09IEVTUkNIKSAvKiBub3Qgc3BlY2lmaWVkICovDQo+PiArICAgICAgICAg
ICAgbGlieGxfZGVmYm9vbF9zZXQoJmJfaW5mby0+YXJjaF94ODYuYXNzaXN0ZWRfeGFwaWMsIGFz
c2lzdGVkX3hhcGljKTsNCj4gDQo+IC4uLmJlY2F1c2UgaGVyZSB5b3Ugb25seSB3YW50IHRvIHVz
ZSB0aGUgZ2xvYmFsIHZhbHVlcyBpZiB0aGV5IGhhdmUNCj4gYWN0dWFsbHkgYmVlbiBzZXQgYnkg
dGhlIHVzZXIgKGFzc2lzdGVkX3h7Mn1hcGljICE9IC0xKToNCj4gDQo+IGUgPSB4bHVfY2ZnX2dl
dF9kZWZib29sKGNvbmZpZywgImFzc2lzdGVkX3hhcGljIiwNCj4gICAgICAgICAgICAgICAgICAg
ICAgICAgICZiX2luZm8tPmFyY2hfeDg2LmFzc2lzdGVkX3hhcGljLCAwKTsNCj4gaWYgKGUgPT0g
RVNSQ0ggJiYgYXNzaXN0ZWRfeGFwaWMgIT0gLTEpIC8qIHVzZSBnbG9iYWwgZGVmYXVsdCBpZiBw
cmVzZW50ICovDQo+ICAgICAgbGlieGxfZGVmYm9vbF9zZXQoJmJfaW5mby0+YXJjaF94ODYuYXNz
aXN0ZWRfeGFwaWMsIGFzc2lzdGVkX3hhcGljKTsNCj4gZWxzZSBpZiAoZSkNCj4gICAgICBleGl0
KDEpOw0KDQpPaCByaWdodCBJIHNlZS4NCj4gDQo+PiArICAgICAgICBlbHNlIGlmIChlKQ0KPj4g
KyAgICAgICAgICAgIGV4aXQoMSk7DQo+PiArDQo+PiArICAgICAgICBlID0geGx1X2NmZ19nZXRf
ZGVmYm9vbChjb25maWcsICJhc3Npc3RlZF94MmFwaWMiLA0KPj4gKyAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgJmJfaW5mby0+YXJjaF94ODYuYXNzaXN0ZWRfeDJhcGljLCAwKTsNCj4+
ICsgICAgICAgIGlmIChlID09IEVTUkNIKSAvKiBub3Qgc3BlY2lmaWVkICovDQo+PiArICAgICAg
ICAgICAgbGlieGxfZGVmYm9vbF9zZXQoJmJfaW5mby0+YXJjaF94ODYuYXNzaXN0ZWRfeDJhcGlj
LCBhc3Npc3RlZF94MmFwaWMpOw0KPj4gKyAgICAgICAgZWxzZSBpZiAoZSkNCj4+ICsgICAgICAg
ICAgICBleGl0KDEpOw0KPj4gKw0KPj4gICAgICAgICAgIHN3aXRjaCAoeGx1X2NmZ19nZXRfbGlz
dChjb25maWcsICJ2aXJpZGlhbiIsDQo+PiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICZ2aXJpZGlhbiwgJm51bV92aXJpZGlhbiwgMSkpDQo+PiAgICAgICAgICAgew0KPj4gZGlm
ZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9kb21haW4uYyBiL3hlbi9hcmNoL3g4Ni9kb21haW4uYw0K
Pj4gaW5kZXggZWYxODEyZGMxNC4uZDA4ZjUxZTI4YiAxMDA2NDQNCj4+IC0tLSBhL3hlbi9hcmNo
L3g4Ni9kb21haW4uYw0KPj4gKysrIGIveGVuL2FyY2gveDg2L2RvbWFpbi5jDQo+PiBAQCAtNjE5
LDYgKzYxOSw4IEBAIGludCBhcmNoX3Nhbml0aXNlX2RvbWFpbl9jb25maWcoc3RydWN0IHhlbl9k
b21jdGxfY3JlYXRlZG9tYWluICpjb25maWcpDQo+PiAgICAgICBib29sIGh2bSA9IGNvbmZpZy0+
ZmxhZ3MgJiBYRU5fRE9NQ1RMX0NERl9odm07DQo+PiAgICAgICBib29sIGhhcCA9IGNvbmZpZy0+
ZmxhZ3MgJiBYRU5fRE9NQ1RMX0NERl9oYXA7DQo+PiAgICAgICBib29sIG5lc3RlZF92aXJ0ID0g
Y29uZmlnLT5mbGFncyAmIFhFTl9ET01DVExfQ0RGX25lc3RlZF92aXJ0Ow0KPj4gKyAgICBib29s
IGFzc2lzdGVkX3hhcGljID0gY29uZmlnLT5hcmNoLm1pc2NfZmxhZ3MgJiBYRU5fWDg2X0FTU0lT
VEVEX1hBUElDOw0KPj4gKyAgICBib29sIGFzc2lzdGVkX3gyYXBpYyA9IGNvbmZpZy0+YXJjaC5t
aXNjX2ZsYWdzICYgWEVOX1g4Nl9BU1NJU1RFRF9YMkFQSUM7DQo+PiAgICAgICB1bnNpZ25lZCBp
bnQgbWF4X3ZjcHVzOw0KPj4gICANCj4+ICAgICAgIGlmICggaHZtID8gIWh2bV9lbmFibGVkIDog
IUlTX0VOQUJMRUQoQ09ORklHX1BWKSApDQo+PiBAQCAtNjg1LDEzICs2ODcsMzAgQEAgaW50IGFy
Y2hfc2FuaXRpc2VfZG9tYWluX2NvbmZpZyhzdHJ1Y3QgeGVuX2RvbWN0bF9jcmVhdGVkb21haW4g
KmNvbmZpZykNCj4+ICAgICAgICAgICB9DQo+PiAgICAgICB9DQo+PiAgIA0KPj4gLSAgICBpZiAo
IGNvbmZpZy0+YXJjaC5taXNjX2ZsYWdzICYgflhFTl9YODZfTVNSX1JFTEFYRUQgKQ0KPj4gKyAg
ICBpZiAoIGNvbmZpZy0+YXJjaC5taXNjX2ZsYWdzICYgfihYRU5fWDg2X01TUl9SRUxBWEVEIHwN
Cj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgWEVOX1g4Nl9BU1NJU1RF
RF9YQVBJQyB8DQo+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFhFTl9Y
ODZfQVNTSVNURURfWDJBUElDKSApDQo+PiAgICAgICB7DQo+PiAgICAgICAgICAgZHByaW50ayhY
RU5MT0dfSU5GTywgIkludmFsaWQgYXJjaCBtaXNjIGZsYWdzICUjeFxuIiwNCj4+ICAgICAgICAg
ICAgICAgICAgIGNvbmZpZy0+YXJjaC5taXNjX2ZsYWdzKTsNCj4+ICAgICAgICAgICByZXR1cm4g
LUVJTlZBTDsNCj4+ICAgICAgIH0NCj4+ICAgDQo+PiArICAgIGlmICggKGFzc2lzdGVkX3hhcGlj
IHx8IGFzc2lzdGVkX3gyYXBpYykgJiYgIWh2bSApDQo+PiArICAgIHsNCj4+ICsgICAgICAgIGRw
cmludGsoWEVOTE9HX0lORk8sDQo+PiArICAgICAgICAgICAgICAgICJJbnRlcnJ1cHQgQ29udHJv
bGxlciBWaXJ0dWFsaXphdGlvbiBub3Qgc3VwcG9ydGVkIGZvciBQVlxuIik7DQo+PiArICAgICAg
ICByZXR1cm4gLUVJTlZBTDsNCj4+ICsgICAgfQ0KPj4gKw0KPj4gKyAgICBpZiAoIChhc3Npc3Rl
ZF94YXBpYyAmJiAhYXNzaXN0ZWRfeGFwaWNfYXZhaWxhYmxlKSB8fA0KPj4gKyAgICAgICAgIChh
c3Npc3RlZF94MmFwaWMgJiYgIWFzc2lzdGVkX3gyYXBpY19hdmFpbGFibGUpICkNCj4+ICsgICAg
ew0KPj4gKyAgICAgICAgZHByaW50ayhYRU5MT0dfSU5GTywgInglc0FQSUMgcmVxdWVzdGVkIGJ1
dCBub3QgYXZhaWxhYmxlXG4iLA0KPiANCj4gVGhpcyBzaG91bGQgYmUgYSBsaXR0bGUgYml0IG1v
cmUgY29uY2lzZSwgYXMgWGVuIGRvZXMgYWx3YXlzIG9mZmVyDQo+IGEgZnVsbHkgc29mdHdhcmUg
dmlydHVhbGl6ZWQgeHsyfUFQSUMuDQo+IA0KPiAiaGFyZHdhcmUgYXNzaXN0ZWQgeCVzQVBJQyBy
ZXF1ZXN0ZWQgYnV0IG5vdCBhdmFpbGFibGVcbiINCj4gDQo+IFRoYW5rcywgUm9nZXIuDQoNClRo
YW5rIHlvdSBmb3IgeW91ciBjb21tZW50cy4NCg0KSmFuZS4=


From xen-devel-bounces@lists.xenproject.org Wed Feb 02 15:29:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 15:29:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264332.457395 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFHZo-00081J-NS; Wed, 02 Feb 2022 15:29:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264332.457395; Wed, 02 Feb 2022 15:29:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFHZo-00081C-Jv; Wed, 02 Feb 2022 15:29:44 +0000
Received: by outflank-mailman (input) for mailman id 264332;
 Wed, 02 Feb 2022 15:29:44 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=6WyI=SR=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nFHZo-000816-6g
 for xen-devel@lists.xenproject.org; Wed, 02 Feb 2022 15:29:44 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f1895a3b-843c-11ec-8f75-fffcc8bd4f1a;
 Wed, 02 Feb 2022 16:29:42 +0100 (CET)
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur01lp2050.outbound.protection.outlook.com [104.47.0.50]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-32-D687-Jn0OKq2wVFXdMj0aw-1; Wed, 02 Feb 2022 16:29:41 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DB7PR04MB4249.eurprd04.prod.outlook.com (2603:10a6:5:19::25) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.22; Wed, 2 Feb
 2022 15:29:39 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.012; Wed, 2 Feb 2022
 15:29:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f1895a3b-843c-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1643815782;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=TptP1pfm7DD/12XIWwHI552QXwohCJKla0Qt31WDE1E=;
	b=UcmsMuZftLrfOewdg3g3huZfBrY8aOz6fQJJOIvONUhjg6jUA1HmAeCDWOuNuxnXvUZdRT
	tw8da2lT3fZoY8511MAxA/+5ogAjAhQpibFsbizn60gc/lnspFrqi1QFahzilDKAI+hqaN
	phTbCsVtO93x3yxmBT24BH+jxszwYcs=
X-MC-Unique: D687-Jn0OKq2wVFXdMj0aw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=kz0xSPbLXva2fjgNbe5TSioDlLCHM1RyEGMEAlTn4huVewklL91Gx3/pzJlmQ6KKKM9w0o05eXoZF/rFm1GwagjqT2ntjjePFqK3Cv+DkMFdpyLkaKZhoTmBIubTNbkMe4CwA5VozRjrC5cQSbdEkMwCxR1rASypShNOb5rOfWBxpImN3UWftnbBF+n6d6x6XYthej3g0EjHd6PYT39zmk88ppie1RJd5TUX+1Emf4V5LPbzWR1VJSXmyAn6vg37Wq9bQFVas1i8ZXwZRrSoVM8zWQKKc3runHNn1ZeOZwzW3Y/GdSLiKiGeyt7aA6a7BlWpzxgBP0k/9lMOXYE9Xw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=6KY+SS1IYWFi1LjRPIQdaTJLaih+KVVlSXmR3CEpSGw=;
 b=bgfdsaLp9YuQb7llvpyiri+q2+vV6H4Iq7RYJPAw/5MX6d3O3yroXXJT1V8YiEpj8F4YFqndQG0YbFMFM1j0Rql0u8/46xOZmSUptskeUDmqVABGzuHszcLACbaDzUIhE8R0mEpoJ5yO8S6/63LdCQk993xwy3VwB7Bg98Etx1b3BIG8qGcPSV97W8pcez9qNAUlvFWj1h9NT5kX96ooJ8aRHSTrwJNvxNnZ8psdv9dHLUHOi/MS124ABJRJdNou1aRQ5V2N6DixMwr2TxmVWnK/QeFRH/ATOddH38dC2ZIf203SMTW3uPZUAXkV9lss2LjKkJwXmEElrrdwPNBfTg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <4a325d1e-85e0-09ea-e2ab-f0aae123d4c9@suse.com>
Date: Wed, 2 Feb 2022 16:29:37 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v3 2/2] x86/mm: tidy XENMEM_{get,set}_pod_target handling
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 George Dunlap <george.dunlap@citrix.com>
References: <6fe7b036-2bdb-b391-4e6c-1b5d7e05a119@suse.com>
 <8cba4cd0-d218-da1b-dcea-4cc3047c0946@suse.com>
 <Yfqf5jiO0cHjR6gR@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Yfqf5jiO0cHjR6gR@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6P195CA0104.EURP195.PROD.OUTLOOK.COM
 (2603:10a6:209:86::45) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 597d6a37-56c2-47a4-37da-08d9e660d3db
X-MS-TrafficTypeDiagnostic: DB7PR04MB4249:EE_
X-Microsoft-Antispam-PRVS:
	<DB7PR04MB4249720F99C42EF90FFCE291B3279@DB7PR04MB4249.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1148;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	8WlC91kKqkSbXVG8TDDyz8pBK9pNae+yau6w+9ufQ359NsSvjMfn7/eK6hI1qkV3lDipBQDXI8cxedXnzsr7EtXpl2HpHYGxC6x70D6vjnGlx7YtTZgyFVChAhJ8gkRW3TU3oHhq/sI0HR365/WJkuSVjrKhnwkOS8MoDmysTkLY0vWBglzraHKIpJT7IsYdy0ZTt/76DoLMw3d21bFF4jDOmdnpxLFsBwq/hYqHeZ/RFb9aY+Ul4MC2v+dE/pVjR0bn8kzvSCrmgh7/+m2p2DicIL4ApgvsL5CMsi//1zhwm1rewpBOVuZOzbUSQf9TqE7r12wFBapedY/zIpDOsshN2NvSzj3ksbzmV9q+zf81ut17BogcG7g3BnRNU/aBZZ9atYsrpN36i/fazRcb3DGrmfvG3arK6xlYXqZtHjXT21ib1NuTUHyVwGYTa4jV01oqkPZBBPo/RF4/RLB09d6DzQs44vdgr8VcFyj6hQNYvmvy6til7MRwNZwKdL+2ePJ3Ji6ofKkRzbRWFsrbBa9lDngOHdM4cMj8ivr+h1/thM4gbMKx7MQckHb73J89nlHA7IxqFBCeIfmnXUfJbGJT6qh6FrwSfpKSHqMfx/g5yxgtnGvgc2AllB6CVIr4ENaAAao7ppNOysxO3y1UsHUrUZJ3p6ceiq3z1F5QFfGwe0nA6oCWn5FBO3eI5ajknIeONsEy06gfpspVbMqOGB/mKMbk3EGARVuX4gCYq6o=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8676002)(31696002)(2616005)(6512007)(8936002)(86362001)(66946007)(66476007)(4326008)(26005)(2906002)(5660300002)(66556008)(4744005)(186003)(53546011)(6506007)(38100700002)(31686004)(6486002)(508600001)(316002)(36756003)(54906003)(6916009)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?AL3sp1YwllGAregOUkcLMfychvLPAFjmdIyPNsnqJDYsxEUJe8/T8QH4G99S?=
 =?us-ascii?Q?F0OALqc6+Yt8dPo9u38loAAZNm1U+8jrwd/luzFurxwbVSDOELXfAVo1RYJu?=
 =?us-ascii?Q?dN9NJKBuPwDmL2cC4hAx6EgxPKHlP/lOIBdk6pE9/b7R57DFqjq3iIK5koZB?=
 =?us-ascii?Q?NooGTYjCwu021frv8AKM5mLdVRkWUn5OIZGYnqg7/HIz/qO+3Q/VuFi9Z/us?=
 =?us-ascii?Q?DHXsI30UGZHs8EVA0g7LN+L8oQ6C0taTwCrFsk9EWva1t9cAt8ChafzWIHWQ?=
 =?us-ascii?Q?pdVdOxOJV7nWbtAoj7U2+jAMEGYgJB33pBndrBA585hWEK5MpXfO6aVzuSc/?=
 =?us-ascii?Q?zyX64qIPb6gGHitVcztI1TdDeBir4pC5Mom+pT7TT9hjYn7Ni1/JfNEW4OgE?=
 =?us-ascii?Q?BxBNtdkYx++kwbE4yrXvEMWsur6FHeCfuSBtdpqYyKAS0HlGaL68GOp7EBF7?=
 =?us-ascii?Q?qoD5UR/Mc+kz2BJNiPatujYK7+T8NTmyGQlXVWMfUwIw48H7Y2rZ0mAL9fRZ?=
 =?us-ascii?Q?3YFnrPGCG3sDrPcLg1Vwkkk2VhaGi77U43p6ItFHU3DPvNGAJq8p5IEZ/ym3?=
 =?us-ascii?Q?7AXuCuKuJ5/IQZXRDp2t9UpGlTCjPwo0Vqa9b3JlibetZoYKjPxyxCoDoYH4?=
 =?us-ascii?Q?O4CBIE8iXL2jyyseFpuhDdlKzZKKb/9/degS4AamM20CHfBqyE20AhgJy7Of?=
 =?us-ascii?Q?fpYHD8nqHIrww95r5a47swz55tKGxRnbfsoEyng3Q27jfBrkEckvrNmx2qC3?=
 =?us-ascii?Q?IqL/9rv8rY6VZ3RsBbA/QZ0GFrGrjCIMubdKof4JDjNKzeN6GqNqaJ/nDZug?=
 =?us-ascii?Q?X4jhZjC/pVn5DGp09STqVoWmNmc9PetSfKe0ZoP51t78Y/1hEd7CeBPoEyJv?=
 =?us-ascii?Q?9Xc1MeJWdtpkuiAgFbxszDRbEm1CL8tAIsafVXoQyyXmju/ax50oC5LTR5ke?=
 =?us-ascii?Q?jcvvQ/0lPP2Z3Cvxuk+g+Tvt0k4yvcXm32ysAKYs9CPHjTbKV2YmRBzFcsSG?=
 =?us-ascii?Q?Y201coT81c42uWdjX/WnRxZgKGOYXWrq/b97Yd9xL0G5ynTf3Zhub29Yz0wZ?=
 =?us-ascii?Q?3+0iL4PkvaaPb18E9ftSQEs2BUYYbrBCw2cDqHdM4hM5dkCjIJtPLsrsv530?=
 =?us-ascii?Q?SG8uPdxs0lIzwLnKuT1ArIo8yX2aztN27Y7IhbUiigxw9LLqcUx56W+Kt/zb?=
 =?us-ascii?Q?lm9H0mUKQVuzhsq/Scbyq6gYzFgavGth9RkpXXwOt9JL5RSo3XmXr871hK6h?=
 =?us-ascii?Q?86AlRCNBydN2fZmRlIw75OkVfE1oSBZfe0NHI6A+HrLP0Vz+VSlxGwK2B2lI?=
 =?us-ascii?Q?xI/IPCzD1E+cM6orDa7bwWzIsrwCn1wET4xjjN2xu2ThzzN+IMuHEFoJ1b9N?=
 =?us-ascii?Q?mGx0hHQkxo30g7Akc90rwqQfMBSgl2oT/pVHIpiQpdGlYw63OJIm1THoKucb?=
 =?us-ascii?Q?VSjdc1krNDUcSqtpqdwIzpEP+mugRhePw0rgu2lkB32vcCLSThNO3Ph4UNcx?=
 =?us-ascii?Q?y8Ogv6H0WIwtr3zV5xliMzCbR5qZhqb2R3+2JXrr6Yb1F/brs88hsjZc/E71?=
 =?us-ascii?Q?jF3ErhujWVjM6nZSJ6rfptOasc4J7w83jNF4DC/W/cdSTu89kzqOl0S80KIO?=
 =?us-ascii?Q?rJwZeGzzuW6vEn/P2JLbwD0=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 597d6a37-56c2-47a4-37da-08d9e660d3db
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2022 15:29:39.6337
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4LV/bX4nJyatIrz/vUZg9WxMD1FAVX1ZtLoTx07k0rw/TqdrUXVjMNJ9aif2/es8MwvMuxn20lnYl76rwctr4Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4249

On 02.02.2022 16:14, Roger Pau Monn=C3=A9 wrote:
> On Tue, Jan 04, 2022 at 10:41:53AM +0100, Jan Beulich wrote:
>> Do away with the "pod_target_out_unlock" label. In particular by folding
>> if()-s, the logic can be expressed with less code (and no goto-s) this
>> way.
>>
>> Limit scope of "p2m", constifying it at the same time.
>=20
> Is this stale? I cannot find any reference to a p2m variable in the
> chunks below.

Indeed it is, leftover from rebasing over the introduction of
p2m_pod_get_mem_target() in what is now patch 1. Dropped.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Feb 02 15:31:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 15:31:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264337.457406 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFHbM-0000u5-3C; Wed, 02 Feb 2022 15:31:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264337.457406; Wed, 02 Feb 2022 15:31:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFHbL-0000ty-VV; Wed, 02 Feb 2022 15:31:19 +0000
Received: by outflank-mailman (input) for mailman id 264337;
 Wed, 02 Feb 2022 15:31:19 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=6WyI=SR=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nFHbL-0000ts-3h
 for xen-devel@lists.xenproject.org; Wed, 02 Feb 2022 15:31:19 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2a392f49-843d-11ec-8eb8-a37418f5ba1a;
 Wed, 02 Feb 2022 16:31:18 +0100 (CET)
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur03lp2054.outbound.protection.outlook.com [104.47.9.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-8-PM_Vl_j9NoyB7TQU74MzwA-1; Wed, 02 Feb 2022 16:31:16 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DB7PR04MB4249.eurprd04.prod.outlook.com (2603:10a6:5:19::25) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.22; Wed, 2 Feb
 2022 15:31:14 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.012; Wed, 2 Feb 2022
 15:31:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2a392f49-843d-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1643815877;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=8kX6TwZNrNHLpw1o6tkilJNOMi9HA4GsmXheN76YrI8=;
	b=afN6p1On+hXf8yR6hMMI7bSl8GSqcu70U4p0WFHQlOMWFeAuObuQUlRMlzGiVltp/PiTEm
	m4zeoYRfxptVfVgCKJcYFUXU61eeq4Hddm9Qx7KFF/LViwILQCFdfRA/ryzhvPBF0XMOZQ
	gzwmEh3ZW+XiCb1C0T8Xy/Ox1YLtasM=
X-MC-Unique: PM_Vl_j9NoyB7TQU74MzwA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XBwRm6BuYS2XvcYSqD0xY0vymxfGutbexafmCRKiz6azrfhmpSpV4//plVPXbPtsIQ/GZNZNNSV8T1Gub8IFe6y1ws47LKvlW31qjUK9prAq8pNd+upg8KnMaylZY/iyQyd8GbHPRc+7g0D6EgXViD0MPpRsnF7ylvLsO8PzH/Sp92wKFKKVtAiyrXkn4fz3lCOhVWFeuTGBRx/IC0wANiyk2+5++P5GkM9tnoKmVObled8EYEAMFAhtxISrsEmElURFqvthVj/7qGLlTn+cSfYLq7c55BH0WdnGEM+xpR0qAs11r319NWq+PvOlr0o3qJLYJqIfIUiuUxVq1aN8yg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=8kX6TwZNrNHLpw1o6tkilJNOMi9HA4GsmXheN76YrI8=;
 b=PGLpROiDMOIW0HQWBFqWufeD3PlqvsJX8RK70vlo9m/U5TEexN31oRgoRWwCLZqWy+WvLfT4Bsgfb9tWUsqfkrjCGtEZG4vS9330qV6E+300bVyimJiGNGhrjii+WCWwx4wX0Bu6SaEyeLpSsgT4DNx/DYf5qKXdxBr49RkFcLpSskzWyKMLmstOro6J2d4Pe0z4R5LqoYsbAQC8rhrVuze87A/ZByvN+RHY+t8yemeyJfvdkBc2w0h1khK+TFIjuC70RRgtUEzaKmca958V2q6DAFv0wOxnDBMbDpNv18RdE9TKWGYfgXBpl+PeoleJPNFrMfLWXh+mbbUDiaNouw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <fd668a40-c765-a8bb-e0e1-59d7d336fceb@suse.com>
Date: Wed, 2 Feb 2022 16:31:12 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v5 09/14] vpci/header: emulate PCI_COMMAND register for
 guests
Content-Language: en-US
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "julien@xen.org" <julien@xen.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Artem Mygaiev <Artem_Mygaiev@epam.com>,
 "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
 "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
 "paul@xen.org" <paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>
References: <20211125110251.2877218-1-andr2000@gmail.com>
 <20211125110251.2877218-10-andr2000@gmail.com>
 <YeAD9PH9o65o+M+w@Air-de-Roger>
 <6a31eb29-81b6-7553-897f-2e5e54bab9b8@epam.com>
 <d527740a-4d90-4155-13dc-5888e8acfa72@suse.com>
 <b9661d86-f084-9ad1-59d5-538113000393@epam.com>
 <ab68568c-461e-bef5-4218-07db8e837bcc@suse.com>
 <37313b25-ccbe-fbfd-8306-7a96ce83c818@epam.com>
 <f93d4d54-a2ac-67c0-8a04-d8321b0828e5@suse.com>
 <4fb06bb7-442f-e041-ef95-daec81e1d3a0@epam.com>
 <3f75acfe-bb88-5982-5f8e-04e0d1755c1a@suse.com>
 <6cc0d636-8cbe-22b0-01fe-b43e92ba7a98@epam.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <6cc0d636-8cbe-22b0-01fe-b43e92ba7a98@epam.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR3P281CA0044.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:4a::7) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 3922f6ad-ad61-4e53-defc-08d9e6610c4c
X-MS-TrafficTypeDiagnostic: DB7PR04MB4249:EE_
X-Microsoft-Antispam-PRVS:
	<DB7PR04MB424958C8130B85DAB0A09E91B3279@DB7PR04MB4249.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7219;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	dLRbW3gy9h0Im4cO6/ZRSaaNGB4SGVNYzM4Qj4Fyd+SGU2D/tPTmYlrJpG92TAxU7l6B+n1wAYnyju94dAhYxG/i0sIp8z4J8/26901WV38KX51t9jLDpGGgTQg5ylZdicmW0pR9BnhrRwAHT8A0TOmZdGF/WOluh+Err0Na6QF4xEJC9utnYF/2diVQLPVVkZ3/rSVbB08E4+leC3yEpnfFH+CbmmgWbM53AfGiwM/kNm4hSFPbB6sJBS5IXfU+AKryusjHf1AaIIzZOFOV+ryvUC0IxDI49Vog3/t4vWLwdumoU1vsghYJ2sc6LEzj1aWMFALRijmoFEzIoLe7ndi+wv6qR0RiwcWD02j0JlyZQyRz93YOqdnx1CPKxongvVO32e7ksgrIUQG+bl+dYMYBgu5oIr/S0X7g4VdM9QotQO3ezX/XsKvo+H1qz3oyoVeG+8cxxfHpG1/b0Aq0RM6FwB63sDsoLJIOA/Z0vlPcX/i1U84cuF5GfSHKbCWVMrcH+0cz5XhgrCM5kct9GU12FGYPkG9UVSDo3MYCt6seOEObOfp1E99HFUKHufYYCBlkpqOwx/cmsL39ynJ00dy6SNeqKzpy9DN8I6RHiX1Dr2PGgTg1AjLNccnEGtZ/BOM4gxjztImbEAcFZQSyUxCWCt9zBwMbdyo6TncUsc2wpjmfQx+YntUhPYsteWrmYMMj0bEO2qMl8iWSbw/oK8xzmE9AObvWLMFKtCx3npI=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8676002)(31696002)(2616005)(6512007)(8936002)(86362001)(66946007)(66476007)(4326008)(26005)(2906002)(7416002)(5660300002)(66556008)(4744005)(186003)(53546011)(6506007)(38100700002)(31686004)(6486002)(508600001)(316002)(36756003)(54906003)(6916009)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aVFGUFJDQWh1NUxOUGZYRTU2bC9zVmVtUW1WSTZpb3pXaWVjVVJoYzc2aHBI?=
 =?utf-8?B?Q0V1WE1aSnNmMVcxU3pJRnhDYlc4KzZtU0FUaWNCNm9abDlNUFNvR24wTVJp?=
 =?utf-8?B?YWQ1QmRpbjFuVE5aOFNpM3pnblJKd1FMcnJOR0daWGFQK2dQSUJiZGZPb2Fy?=
 =?utf-8?B?c0Rhcnp3ckF6eFNBdWFIQmRVN1dpMXVVY0huNk1aaEdhM21VT056bDVrN3VK?=
 =?utf-8?B?RkRFMXZuNHhsWURUSHNsdndWRzFjOUp1TENReTFIdGZYQlU3NnllMVFOMkY1?=
 =?utf-8?B?eGVGUUJPc2VrdXVNZlJ0TGh4RC81ZXkyZHhPWjc4SFZ5QWR3Rm93aXdUQVJa?=
 =?utf-8?B?TGhtbzRLNHpBQ2kyOFNmNWpmdkFNcS9XY2Y3amZXL3ZIS2VWak5PeWdyMWZ1?=
 =?utf-8?B?L2FhWFo5SjVlSys0blFGZTExVmpxNUxlVGxYZk4yaHBlQW8vYm5YTmg5WXlz?=
 =?utf-8?B?SlNXZm1aU0wxbWJBYmFqYlQ0V2JNR0cwMXcrR0lubS9zU0t0d2R3QjBnM3A3?=
 =?utf-8?B?K2VlSmc2cFAzWXI5UU5PSERmTlV4ZGNkSkFyTWk1M1U3UkVLOHAxZTBUejlZ?=
 =?utf-8?B?aVdGV1ZpSkc2Vm5lK2hlb1lvb3JtdnRlbnRPNWVEZDlvb211ekYvTjVQb1dV?=
 =?utf-8?B?NzlZckh3S0pCNzVwS3o1MWFrMS9lQ0F4WnNTdDQ1VnpTRDlqVnZZTGZLVXh4?=
 =?utf-8?B?ZVNBOUJmeEdzYk9PS1plTkl3bFpRRnBTRnRLU1FURXdjU3RaT04rQXNtU1E4?=
 =?utf-8?B?L0U4L0V0WkM4elJzNkxNRkJ2V0VSdmkrbU9YNVpqSUdrQUZURFNSN0JpN3Ex?=
 =?utf-8?B?Y29jUElTOG1JdklaVUdrcHFseU5lbW15SHcwejl3ZjhjY09HckxQR0VqV0gz?=
 =?utf-8?B?Y3VXOUg1VndPcXB4UUt1SDhSNDVLT1doWGhXWjlhV1NPcHVyaDJ2MGF3L1JH?=
 =?utf-8?B?azVEN0lFbXh2WmhCTit0bmcrS3EyTmdEdWlPMEpkQ2dPeXRwbmFlWjVlNjZJ?=
 =?utf-8?B?UjYyT1pmL2U4eWwwSWdGMkNmV2VxcisxUGM4bmVrZnlJalgzbjkreWFnSFFo?=
 =?utf-8?B?Y0VEdzFxRmFtSWJHTWd2SmY5VjMyeGVyWSsvR01vMDYraXg5MTBOV1UxVUt2?=
 =?utf-8?B?Q2xvdytpRUhMa1ZvY0QwdTlDSUJNakZxbFZTZEs1bmhFU1VqS1JtV3UrM09Z?=
 =?utf-8?B?ZnRZQUYxaTdBc1ExR212eHlvUWk3clgzOVpGNm92aWZ1YmtDTFdzWWQzM0ln?=
 =?utf-8?B?L1F3ZFpEZFpDZDArTkpMZnAwRG5UdFozNnlwRVpZOGdINnR4U0Y5UlNiRUMz?=
 =?utf-8?B?YS8rdFB0dHhsRDhkcHBHcWp3Rm9URWl5SVI3VzZ6MGxnV0xaNVZ3Y2NTd0VB?=
 =?utf-8?B?QkRBMXpKQ1JVcEQwR0IreDU2WXJzc1lxWnl0RExHMFRJTlBZbmNHZFY0OFpI?=
 =?utf-8?B?VWsxNWRKbldsYUFXdzQwRm5vRnVCOEZTNlBETFRIRmZvVXlZbUZvUXIrcEVI?=
 =?utf-8?B?TXpLbU9FSlE2OHYzMHFrUVNXM1VUY1BmWThCUFh2QkIrYkFQSndoZGR1YVYz?=
 =?utf-8?B?aTh3cXgxNzFkcmpYTlJyNUVtZDdKeGduVXZyQmloeHlLamEzOHcxcENMcFho?=
 =?utf-8?B?b0lFZkp1d3VseitnbGpvUVNteXFnR0creUg2SHJveHRiLzhUTUxwQ3MzMVhn?=
 =?utf-8?B?SXVFM0xQK0RPaU9wRHNQY3FUNEp4QUQzdHpzOVZrcURBVnBFVHRXTDl4b3k2?=
 =?utf-8?B?MjRlVFJBMTE1bHlaQk42RGpwNG0zN2ZYS0YvKytpZU1Wc1pXcGdLS2tjU1lV?=
 =?utf-8?B?d3JHaDZzN3didFJGblk5TmF3c1pnckNrWmpqWkVXQUwvODFEbWZ3M2hXSkgw?=
 =?utf-8?B?a1pyWVdIampWaFB2cmlZTEJtY2hkMkZ3OUNoQUx2RGJla0NGbVFRMkJrVUhW?=
 =?utf-8?B?d0xrZm5lNkU4bjVqRHRTSlBWNkNVb3ZZekY3SXNhRE5VODhSdW96WkNtb1VL?=
 =?utf-8?B?d1oyTmdwTm93YTVtWDZvSzdtZW9VL0cyYWprL2RuVzg3K1JPSmM1aXFCNjhm?=
 =?utf-8?B?U2lSOVlPRVFGM25CTW9UWmZHdTh2N2lvYlE4YWI2YVQxYzhpVjFISHYvdE14?=
 =?utf-8?B?eVdjMG5COXdaNkswVytxcWZNOXViY2QxSzFac0dHUnZzb0FmZjBKblJCWDZI?=
 =?utf-8?Q?TPI4LYmW4BQyEsG2UF4r2cI=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3922f6ad-ad61-4e53-defc-08d9e6610c4c
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2022 15:31:14.3153
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: v+N08SdNxFvh6idbZKYDXIhlXUSS19dep5nDecIiekaC9zzHRSY+r0hMb1hqMkkUUO47vTWUQVpYRFnh0Cz4Ug==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4249

On 02.02.2022 16:12, Oleksandr Andrushchenko wrote:
> On 02.02.22 17:08, Jan Beulich wrote:
>> On 02.02.2022 16:04, Oleksandr Andrushchenko wrote:
>>> Or do we want some additional code in MSI/MSI-X's control_write
>>> functions to set INTX bit there as well?
>> Well, yes, this is what Roger and I have been asking you to add.
> Do we only want this for !is_hardware_domain(d) or unconditionally?

To keep present behavior unaltered, I'd suggest to do it only
conditionally.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Feb 02 16:13:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 16:13:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264346.457416 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFIGD-0005Z0-Ay; Wed, 02 Feb 2022 16:13:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264346.457416; Wed, 02 Feb 2022 16:13:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFIGD-0005Yt-7r; Wed, 02 Feb 2022 16:13:33 +0000
Received: by outflank-mailman (input) for mailman id 264346;
 Wed, 02 Feb 2022 16:13:31 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HAZh=SR=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nFIGB-0005Yk-BS
 for xen-devel@lists.xenproject.org; Wed, 02 Feb 2022 16:13:31 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0dd6e8ca-8443-11ec-8f75-fffcc8bd4f1a;
 Wed, 02 Feb 2022 17:13:28 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0dd6e8ca-8443-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1643818408;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=sq4c3yben27DwdS4YR4p3uZnSL++3geId4sKdu5V/34=;
  b=a5+PdnOx5/zc289mJNMbQns7158FUFiqCOSoXqQdyjSarR6meQgP826u
   iwOTVw7/L0Dd9aaTeOvpRIFwP5rcWYd3uKnxyZH+vkVx7JiToPD7DNt91
   jzZETJxXuZLzra2l8fyn9UjPTcEzSaaT2i/R8WNN0uCaXm2pC607y+8VN
   E=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: wBIQR5nyzNMDc+p6JVKXU9CGFc/LH1xrLFzdk9Ca3gEtutfErZL5cljCCO2rCibV3JdrJvG7lj
 tJfbRYYckcoR3mHgFxfp6w5YQFm9XNLx0RP1vm7Yl+cnP798+KX3V2kqfr7DELU+nhPxPQe2Gj
 sUGy2l/OjrQHhToLPd/kqmTwuXOb9VgoRovmkWaUMTDbncoYN5YWCTCSMahj/I/rTGzjWFZw74
 ArcAyCoiPQx5q6BNWe/RgP/BM6s/ZoXbE3L4RUeBnRLUydDUzW2gZXQNDwavRjnAse2ECnY66t
 iqMSbk4Wpsm/1SsmJoH6kQ82
X-SBRS: 5.2
X-MesageID: 62799540
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:8kUUHKzqS6oH3DFZLr56t+eCwSrEfRIJ4+MujC+fZmUNrF6WrkUGn
 DQeWWGPP/yCZzH8coonPN7l/R8EucSHyYcyHldu/iAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAhLeNYYH1500g7wbZj2tQAbeWRWGthh
 /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL
 wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt817m
 MQWkoWJcgYWPbXrof4ZXxhyLggraMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr
 6ZBbmlQMFbT3Ipaw5riIgVort4kI8TxepsWp1lrzC3DDOZgSpfGK0nPzYECg2Zh25wWdRrYT
 9ETaQU+fC/eWTtOHggVMq1ug9X03ECqJlW0r3rK/PFqsgA/1jdZzLHoOcH9Zt+OSMNaj0uc4
 GnB+gzRGgkbLteWzTOP71qmh/PDkC32Xo4fDvuz8fsCqFSS3WUSDBQ+X1qnrfS3h0iyVsgZI
 EsRkgI2pLU23FymSJ/6RRLQiHyOswMYWtFQO/Yn8wzLwa3Riy6JC25BQjNfZdgOsM4tWSdsx
 lKPh8nuBzFkrPuSU3313qiQhSO/P24SN2BqWMMfZVJbuZ+5+th110+RCIY4eEKosjHrMSz6k
 yHRizEHvLQsjtYs7r+/8VHtvhv58/AlUTUJzgnQW2uk6CZwa4ike5Gk5DDn0BpQEGqKZgLf5
 SZZwqBy+MhLVMjQz3LVHI3hCZn0v67tDdHKvbJ483DNHRyJ8mXrQ41f6SoWyKxBYpddIm+Bj
 KM+VGpsCH5v0JmCMf4fj2GZUZ1CIU3c+TPNDai8Uza2SsItHDJrBQk3DaJq40jjkVI3jYY0M
 oqBfMCnAB4yUPo7l2XqHrZMjOZ1lkjSIF8/origl3yaPUe2PibJGd/pznPSBgzG0E90iFqMq
 IsOXyd74x5eTPf/ckHqHX07djg3wYwALcmu8aR/L7fbSiI/QT1JI6KPndsJJtI094wIxrag1
 izsASdwlQug7UAr3C3XMBiPnpu1A8YmxZ/6VARxVWuVN48LOtfytfpPKsdsINHKNoVLlJZJc
 hXMQO3ZatxnQTXb4TUNK577qY1pbhOwggySeSGiZVACk1RIHVWhFgbMclS9+S8QIDCwsMdi8
 bSs2hmCGcgIRhh4DdaQY/WqlgvjsX8YkeN0fk3JPtgMJxm8rNk0c3T83q0tPsUBCRTf3T/Gh
 QyYNggV+LvWqIgv/diX2a3d99W1E/FzF1ZxFnXA6erkLjHT+2eumNcSUOuBcT3Hennz/aGuO
 bdcw/3maaVVl1dWqYtsVb1syPtmtdfoorZbyCViHWnKMAv3Wu8xfCHe0JAW5KNXx7JftQ+nY
 W61+4FXaeeTJcfoMF8NPw55PO6N4u4Zx2vJ5vMvLUSkuCIupOibUV9fNgWngTBGKOcnK5ssx
 OostZJE6wG7jRZ2YN+KgjoNqjaJJ30EFa4mqosbEMngjQ9ykgNOZpnVCynX5pCTaooTbhl2c
 2HM3KeS1a5BwkficmYoESmf1OVQsp0CpRRWwQJQPF+OgNfE2qc60RA5He7bleiJIsGrC95OB
 1U=
IronPort-HdrOrdr: A9a23:n90JJq/Ei7nYLXYaiIpuk+FAdb1zdoMgy1knxilNoENuHfBwxv
 rDoB1E73LJYVYqOU3Jmbi7Sc69qFfnhORICO4qTMqftWjdyRCVxeRZg7cKrAeQeREWmtQtsJ
 uINpIOdOEYbmIK/PoSgjPIaurIqePvmMvD5Za8854ud3ATV0gJ1XYGNu/xKDwReOApP+tcKH
 LKjfA32AZINE5nJfiTNz0gZazuttfLnJXpbVovAAMm0hCHiXeN5KThGxaV8x8CW3cXqI1SvF
 Ttokjc3OGOovu7whjT2yv66IlXosLozp9mCNaXgsYYBz3wgkKDZZhnWZeFoDcpydvfomoCoZ
 3pmVMNLs5z43TeciWcpgbs4RDp1HIU53rr2Taj8A3eiP28YAh/J9tKhIpffBecwVEnpstA3K
 VC2H/cn4ZLDDvb9R6NqeTgZlVPrA6ZsHAimekcgzh0So0FcoJcqoQZ4Qd8DIoAJiTn84oqed
 MeQ/003MwmMW9yUkqp/VWGmLeXLzYO91a9MwQ/U/WuonlrdCsT9Tpc+CQd9k1wg67VBaM0o9
 gsCZ4Y542mePVmGZ6VNN1xMfdfNVa9My4kEFjiaGgPR5t3c04klfbMkcAIDaeRCds18Kc=
X-IronPort-AV: E=Sophos;i="5.88,337,1635220800"; 
   d="scan'208";a="62799540"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=nPUzUjBfe5PtrgZpf1ME/IVffgNvoPNY2BM8Zd2lYl1abwrmYyHlkm9Ji2JvFkVP56vJUb57o8+E7QPy7G7ZxO2HzzoQxTsdsY4lTL/EC7t41ciNvM5wW1xojujYIZ6t2OuWsVgBscKf5797bUF6MEMK4h1Wm5RzNlbKsJguvHqw3uqPEpsc7ZL/32LvqYARgWFqhRzfLAi1hgGHP8WiA9awvtaJvLPVHoFZdqAtuzYpVoJNS2ea6NDnItBp7Dz8BGDxdZPFDq3yvDrB3Y0ljLovx2EOjrWQtq2mSLZbd6paN+ahMJcvIcR8QzJrXioAyS8gNkacGuo7cJD0PtmFLg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=wI/5xrT1lExdJ0pV+JJXv2YQ/AZnziy2JyXWmQQBDF4=;
 b=CJlosZLmUjVioBJxZbzpGMDPkO0U4aoTp99Q4jd/HtwmBUj3lVHJkdwcOVclbPKqJgxP8tazbvNLPGF/bm4DavkBYpsPFh/GBrQKC2kuMvE/Z3l85fdt7s/nFJLTIdEAost1Z4MZqQ7/r66IU+U+erh1JtvvxI8v3jv0c+vuW9dUOtwj44zcoHbiJx8yv4pOOQ8Z9O027OJySLbRrCXmFiDEvmhZg+d7BqiwQW8fOvdrpCAnuM7qIDWzaAFMn157lctUaARA1WffKWlbYoZ5En2YSYOnp1rtcIzlk6M9t3jhgVqHZiibGBTW9QodL4ZavpbD9Jmf+W/OBJ6XVtIOfw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=wI/5xrT1lExdJ0pV+JJXv2YQ/AZnziy2JyXWmQQBDF4=;
 b=Bp4xyZ53TZQlK64Lt88JTTvJC51VNYRb5w2Wto30Sv1PbGIGMIAdRXplhv2mPVlXNuWQI2lqBhSx18rsfCSkYQXOUjAr9m8o3JQ3iL+X78PigzzjoonhsKEx/7P0mtkdK3hS6L47d22iRV6LDHdLs9LzakV20m3asGMLFUyOZ5M=
Date: Wed, 2 Feb 2022 17:13:09 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>, George Dunlap
	<george.dunlap@citrix.com>, Paul Durrant <paul@xen.org>, Tamas K Lengyel
	<tamas@tklengyel.com>, Petre Pircalabu <ppircalabu@bitdefender.com>,
	Alexandru Isaila <aisaila@bitdefender.com>
Subject: Re: [PATCH v3 1/2] IOMMU/x86: disallow device assignment to PoD
 guests
Message-ID: <YfqtlZMAKd/HXsgf@Air-de-Roger>
References: <6fe7b036-2bdb-b391-4e6c-1b5d7e05a119@suse.com>
 <b0a77526-17f2-a5ab-6f7f-1b3caeb4a59b@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <b0a77526-17f2-a5ab-6f7f-1b3caeb4a59b@suse.com>
X-ClientProxiedBy: LO4P123CA0204.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1a5::11) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: dc815b8b-6157-4bc3-25cc-08d9e666ea8b
X-MS-TrafficTypeDiagnostic: BYAPR03MB3957:EE_
X-Microsoft-Antispam-PRVS: <BYAPR03MB39571CEB8A1EF8496612E74A8F279@BYAPR03MB3957.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: TygixpSyqK8+uSOeXBCJUYfSbpskw1s8fV2YsKv00/koeVOjjgEe+VaewtR6EXCvCWGvrFKZp1AREiujEcXmjfXCDI2Nj/0qc/YOCj2wNxPn+Ji8OkpNhndGePriXWhtu5EE8ykeobTW7fejLZeiMhyapD30N1dxqPvhb1xbTExqhmLPMCvEnwJylqig7NVha9NmoGSVXi/zWmDFHL3gi58NVDUCwaRz6xyrwQ6ydQHLRELSwuiI0pyNOzKg+97xysm4TtUY3Bb++0tTDNkgbdcS60i+sZAkSmrO2xlqlddhXENmeAKKukkX7CnIO4hbgqdc8ygmUTGsX0QfKclZjkEBReKqihNrh+sR1QKuaUh9vD4uQpyego013WtHRkNTwcThfQvkj6lzseOd5VZd19ut+97QNXoiNgxZhIWYC81aytOOFRZOEfS50a6aOlOyzR2TjXWV+AQDYK5DwEaRD5VltWJf+aR1+7KN3QU4hb2hxXfiqgGsXVw1PwMq7VDTjiNaterLMmdJ2Jm2W7KB9E7ldQ7rsxBRNkmNjhJy6bdhMgCrJzNttEWbMGBI27/WN9tYA3GvgjR0c9p4gzntf0JmMSkDdUfU40N3W8CvxEBFkD9voU0dHx6nsIvcIjJgCmFIeh/d0crKrbhz/fP88w==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(6486002)(5660300002)(186003)(83380400001)(2906002)(6666004)(9686003)(85182001)(6506007)(6512007)(26005)(508600001)(33716001)(66946007)(38100700002)(6916009)(82960400001)(8936002)(8676002)(66476007)(4326008)(54906003)(316002)(86362001)(66556008);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VlJ2bHRDVllONFZyaTFqMlRyNGVyUm5Dd1N1Q2cxZW14V0Y5NGFtT2xOV1Zv?=
 =?utf-8?B?VlRQV3hnKytlQk1EcXh6eWQxdlNidG5nRjdLNE9TS2QzUGhQaXpiczJDR2kx?=
 =?utf-8?B?NXpLVW5qalNDam5ZT3hrN3M0dkp1Uk5ENHlIcFF2V3IyUWJ2d0tFa3JzOXpP?=
 =?utf-8?B?OUtmWktSUzRqRFE1T1NSa3RQcU9VZHcwM01qZGlVNHY4OUxWZmxHdW9jblNn?=
 =?utf-8?B?NkVUbDlxVDZZeU9zdHhCNEVjUjk1YldUTVMxNEk3NldXVHlsTUo0dVFjdVpr?=
 =?utf-8?B?dzZpTG5zRWREWEY5NjdxQ1FvVTBSVnl3UVUyU1pQaFNMc09iRFlXYVo0cGRn?=
 =?utf-8?B?cDRsU01zMTBncW1CTWpOQ00yVzNUSzV0dE42YjY5L3FDWFhqN1BHM1FsUEFu?=
 =?utf-8?B?aUZ0UTQydU4rdlhBRmpkYzl4OE9aZjdlRlpHaVFWS0JHdTQyaFhRSG1WRmxp?=
 =?utf-8?B?ZVNrbGRqK3hib2xyM2NMSGUwTVl3RU0wNVk2VGpSNDJRNEFQUjJIRkNySmFh?=
 =?utf-8?B?WnRlb0QzM1pqZFdFMDlTQ1AzVVR6bkpaQ1ZzczJ4V2tBWmVuK2xNdEZGWVQr?=
 =?utf-8?B?UlVEUnVncklQSWVocGQ0WVVzN2F0SEJaUlhlcEtWb2hQZDlvcUZ1MFlGWEZ6?=
 =?utf-8?B?TnpBaU96cW9KaGJGME8vSXk2N3lrSUUzSzFLenNBNWxmaGpyZVJVcE85a1Yw?=
 =?utf-8?B?OUcrbmkvTVdrdzM3MGVSNVdyU1RkOEN1ZFlIZC9CWU5zZk9BVXFwWCtqV1Jw?=
 =?utf-8?B?Y0ljUmdUQlBQeCtzS0xnOFdheVVFS214azRkQkNVckN4SytnMitQWklySHNp?=
 =?utf-8?B?SllySThxR2hqdE9XNTBiSjJ2RFR0MGE4dVVPNW1WbkR0S3MvWDlEeGNaaGdI?=
 =?utf-8?B?emNIa0lWZGcwcjNZekRkSlo2WFoxeU9QaFdjOFlUNkNYdXJHeEgvQWY1Z1Y1?=
 =?utf-8?B?ZGdJTkNpQkFOWDZJWnNTWGxQOUVBWm5PbWYzclJZM2l3WWtjVlRCODYzdzFR?=
 =?utf-8?B?Nkc0aWNGZzhRZHRPWHBWQTBNWUZITjdxa0NqOWZmTWlTZFpLYkMrTExBYmx0?=
 =?utf-8?B?OERTcTh1aFp0aXlrb1dpamNPYjNodmtjVzl0WXhITVEvc0xOUE02cU9yTXVM?=
 =?utf-8?B?WmhtYVhRS2FLMlBNWTFWdUpDc3NSaUxTQ1FnaTVHVnpPWWhCRXUycHh3Qk8w?=
 =?utf-8?B?S0F4RkxkeFB0NUtzOEIrRUt0TFdvRE9tb2dBWkU3cFR6ZWhWTW55YWdaelZM?=
 =?utf-8?B?MzBYcjBJeDh3TmtHZjdDODl2N3lVbmlRbjA4WnREbmtjZXpsdVlJdWZBNERp?=
 =?utf-8?B?V2FEdFU3eUhUL2RVWmVTaFBvWGRXWjVBcytHb2JwSDNFVERiRVhSbnQyWUI2?=
 =?utf-8?B?cFluM3pGMEVmRjJpTi9RQUZDZ3crSFpDY2QyWGtUYlVuc1grYWQ5aG0yaG1X?=
 =?utf-8?B?THQvRnI1ZDhELzFUemZQMlJwSXRhTmpXQUxIU29pMi9FY3RTV0hsaWQ1Tk9k?=
 =?utf-8?B?UC9MVCtrZ2hpUlRrbVJlUnFuVStGNzE5OEpFeVc5Mjl2dFFlcDRvb0E2RTBu?=
 =?utf-8?B?STBKOG1OMzJRL3Zuc2VSdVBjZHdZaDNYR2tWcXZGRVlHUENvK0RaM1puOWtS?=
 =?utf-8?B?TEtPemlLd0luTGhtMzJObVFsNFdIR0hkbWNBdE53YkxCeVEvWW1mVVp2U3Fz?=
 =?utf-8?B?WnhpOE90YnpNVm1DbTFhSUxPdXVtenJXT21OSEpSbkFFVjM4RmpuWER6ZUdC?=
 =?utf-8?B?Z09nNGsyWjZ2NmRtYXA0TWI2Zkpwb1h2bFJjZUlYU1kyU05ScU1YditheGFq?=
 =?utf-8?B?WkZJR3NKbTF5ei9VdEIwYjNsaS9pcHF6eDVCOVlhcDVGOERwOUJuY085aUdo?=
 =?utf-8?B?MVdYSTYvY1MzbWZESnQ3a2cza2h4ZTJJYlZDTHRsekVkYWVxc3ZJNHRrQmww?=
 =?utf-8?B?U05ncUdEVWxDNi9yZGRPZ2UvTkhRcVh2SFdXUWRoWWVWbXFMSkpWU2xjbWhC?=
 =?utf-8?B?Sm5WT1lKY1oxTTlqb1NOdEptM1ZzOEFYQk5ZM3ExME01bGFtLzBqR3ZwTnBz?=
 =?utf-8?B?REF1RDRMckw0cmNDcHhNT1l6YjN6Sm9vdXZWZ1hhU2RwdmhIanJ3UHhUWk9S?=
 =?utf-8?B?TWZkUDhHN3hnRHpDQk5xOVBiTEVjUnc1dFhKMGwyTy9kMklLVjhaTDVGWFly?=
 =?utf-8?Q?pkQEyf6jxsrn1XYm5k2GwXE=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: dc815b8b-6157-4bc3-25cc-08d9e666ea8b
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2022 16:13:14.8019
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vYzLPCxijTda5mxFZ66BGGKJWuta/vJFuF5zKt8Ks7WbYJX+XSSqGjxsAfbMiDbsxYMIyiss0+OhRz5a7qbrCg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB3957
X-OriginatorOrg: citrix.com

On Tue, Jan 04, 2022 at 10:41:32AM +0100, Jan Beulich wrote:
> While it is okay for IOMMU page tables to get set up for guests starting
> in PoD mode, actual device assignment may only occur once all PoD
> entries have been removed from the P2M. So far this was enforced only
> for boot-time assignment, and only in the tool stack.
> 
> Also use the new function to replace p2m_pod_entry_count(): Its unlocked
> access to p2m->pod.entry_count wasn't really okay (irrespective of the
> result being stale by the time the caller gets to see it).
> 
> To allow the tool stack to see a consistent snapshot of PoD state, move
> the tail of XENMEM_{get,set}_pod_target handling into a function, adding
> proper locking there.
> 
> In libxl take the liberty to use the new local variable r also for a
> pre-existing call into libxc.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> If p2m->pod.entry_count == p2m->pod.count it is in principle possible to
> permit device assignment by actively resolving all remaining PoD entries.
> 
> Initially I thought this was introduced by f89f555827a6 ("remove late
> (on-demand) construction of IOMMU page tables"), but without
> arch_iommu_use_permitted() checking for PoD I think the issue has been
> there before that.
> ---
> v3: In p2m_pod_set_mem_target() move check down.
> v2: New.
> 
> --- a/tools/libs/light/libxl_pci.c
> +++ b/tools/libs/light/libxl_pci.c
> @@ -1619,8 +1619,13 @@ void libxl__device_pci_add(libxl__egc *e
>      pas->callback = device_pci_add_stubdom_done;
>  
>      if (libxl__domain_type(gc, domid) == LIBXL_DOMAIN_TYPE_HVM) {
> -        rc = xc_test_assign_device(ctx->xch, domid, pci_encode_bdf(pci));
> -        if (rc) {
> +        int r;
> +        uint64_t cache, ents;
> +
> +        rc = ERROR_FAIL;
> +
> +        r = xc_test_assign_device(ctx->xch, domid, pci_encode_bdf(pci));
> +        if (r) {
>              LOGD(ERROR, domid,
>                   "PCI device %04x:%02x:%02x.%u %s?",
>                   pci->domain, pci->bus, pci->dev, pci->func,
> @@ -1628,6 +1633,22 @@ void libxl__device_pci_add(libxl__egc *e
>                   : "already assigned to a different guest");
>              goto out;
>          }
> +
> +        r = xc_domain_get_pod_target(ctx->xch, domid, NULL, &cache, &ents);
> +        if (r) {
> +            LOGED(ERROR, domid, "Cannot determine PoD status");
> +            goto out;
> +        }
> +        /*
> +         * In principle it is sufficient for the domain to have ballooned down
> +         * enough such that ents <= cache.  But any remaining entries would
> +         * need resolving first.  Until such time when this gets effected,
> +         * refuse assignment as long as any entries are left.
> +         */
> +        if (ents /* > cache */) {
> +            LOGD(ERROR, domid, "Cannot assign device with PoD still active");
> +            goto out;
> +        }
>      }
>  
>      rc = libxl__device_pci_setdefault(gc, domid, pci, !starting);
> --- a/xen/arch/x86/mm/p2m-pod.c
> +++ b/xen/arch/x86/mm/p2m-pod.c
> @@ -20,6 +20,7 @@
>   */
>  
>  #include <xen/event.h>
> +#include <xen/iocap.h>
>  #include <xen/ioreq.h>
>  #include <xen/mm.h>
>  #include <xen/sched.h>
> @@ -359,7 +360,10 @@ p2m_pod_set_mem_target(struct domain *d,
>  
>      ASSERT( pod_target >= p2m->pod.count );
>  
> -    ret = p2m_pod_set_cache_target(p2m, pod_target, 1/*preemptible*/);
> +    if ( has_arch_pdevs(d) || cache_flush_permitted(d) )

Is it possible to have cache flush allowed without any PCI device
assigned? AFAICT the iomem/ioport_caps would only get setup when there
are device passed through?

TBH I would be fine if we just say that PoD cannot be used in
conjunction with an IOMMU, and just check for is_iommu_enable(d) here.

I understand it's technically possible for PoD to be used together
with a domain that will later get a device passed through once PoD is
no longer in use, but I doubt there's much value in supporting that
use case, and I fear we might be introducing corner cases that could
create issues in the future. Overall I think it would be safer to just
disable PoD in conjunction with an IOMMU.

> +        ret = -ENOTEMPTY;
> +    else
> +        ret = p2m_pod_set_cache_target(p2m, pod_target, 1/*preemptible*/);
>  
>  out:
>      pod_unlock(p2m);
> @@ -367,6 +371,23 @@ out:
>      return ret;
>  }
>  
> +void p2m_pod_get_mem_target(const struct domain *d, xen_pod_target_t *target)
> +{
> +    struct p2m_domain *p2m = p2m_get_hostp2m(d);
> +
> +    ASSERT(is_hvm_domain(d));
> +
> +    pod_lock(p2m);
> +    lock_page_alloc(p2m);
> +
> +    target->tot_pages       = domain_tot_pages(d);
> +    target->pod_cache_pages = p2m->pod.count;
> +    target->pod_entries     = p2m->pod.entry_count;
> +
> +    unlock_page_alloc(p2m);
> +    pod_unlock(p2m);
> +}
> +
>  int p2m_pod_empty_cache(struct domain *d)
>  {
>      struct p2m_domain *p2m = p2m_get_hostp2m(d);
> @@ -1384,6 +1405,9 @@ guest_physmap_mark_populate_on_demand(st
>      if ( !paging_mode_translate(d) )
>          return -EINVAL;
>  
> +    if ( has_arch_pdevs(d) || cache_flush_permitted(d) )
> +        return -ENOTEMPTY;
> +
>      do {
>          rc = mark_populate_on_demand(d, gfn, chunk_order);
>  
> @@ -1405,3 +1429,20 @@ void p2m_pod_init(struct p2m_domain *p2m
>      for ( i = 0; i < ARRAY_SIZE(p2m->pod.mrp.list); ++i )
>          p2m->pod.mrp.list[i] = gfn_x(INVALID_GFN);
>  }
> +
> +bool p2m_pod_active(const struct domain *d)
> +{
> +    struct p2m_domain *p2m;
> +    bool res;
> +
> +    if ( !is_hvm_domain(d) )
> +        return false;
> +
> +    p2m = p2m_get_hostp2m(d);
> +
> +    pod_lock(p2m);
> +    res = p2m->pod.entry_count | p2m->pod.count;
> +    pod_unlock(p2m);
> +
> +    return res;
> +}
> --- a/xen/arch/x86/mm.c
> +++ b/xen/arch/x86/mm.c
> @@ -4778,7 +4778,6 @@ long arch_memory_op(unsigned long cmd, X
>      {
>          xen_pod_target_t target;
>          struct domain *d;
> -        struct p2m_domain *p2m;
>  
>          if ( copy_from_guest(&target, arg, 1) )
>              return -EFAULT;
> @@ -4787,7 +4786,9 @@ long arch_memory_op(unsigned long cmd, X
>          if ( d == NULL )
>              return -ESRCH;
>  
> -        if ( cmd == XENMEM_set_pod_target )
> +        if ( !is_hvm_domain(d) )
> +            rc = -EINVAL;
> +        else if ( cmd == XENMEM_set_pod_target )
>              rc = xsm_set_pod_target(XSM_PRIV, d);
>          else
>              rc = xsm_get_pod_target(XSM_PRIV, d);
> @@ -4813,10 +4814,7 @@ long arch_memory_op(unsigned long cmd, X
>          }
>          else if ( rc >= 0 )
>          {
> -            p2m = p2m_get_hostp2m(d);
> -            target.tot_pages       = domain_tot_pages(d);
> -            target.pod_cache_pages = p2m->pod.count;
> -            target.pod_entries     = p2m->pod.entry_count;
> +            p2m_pod_get_mem_target(d, &target);
>  
>              if ( __copy_to_guest(arg, &target, 1) )
>              {
> --- a/xen/common/vm_event.c
> +++ b/xen/common/vm_event.c
> @@ -639,7 +639,7 @@ int vm_event_domctl(struct domain *d, st
>  
>              rc = -EXDEV;
>              /* Disallow paging in a PoD guest */
> -            if ( p2m_pod_entry_count(p2m_get_hostp2m(d)) )
> +            if ( p2m_pod_active(d) )

Isn't it fine to just check for entry_count like you suggest in the
change to libxl? This is what p2m_pod_entry_count actually does
(rather than entry_count | count).

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Feb 02 16:22:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 16:22:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264354.457428 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFION-00073t-BG; Wed, 02 Feb 2022 16:21:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264354.457428; Wed, 02 Feb 2022 16:21:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFION-00073m-7Q; Wed, 02 Feb 2022 16:21:59 +0000
Received: by outflank-mailman (input) for mailman id 264354;
 Wed, 02 Feb 2022 16:21:57 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HAZh=SR=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nFIOL-00073g-JK
 for xen-devel@lists.xenproject.org; Wed, 02 Feb 2022 16:21:57 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 3b1f5cac-8444-11ec-8eb8-a37418f5ba1a;
 Wed, 02 Feb 2022 17:21:55 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3b1f5cac-8444-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1643818915;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=NuQHegXm7Ik4y7VVZynrjLwz4N8D5X/RJeOs54iO/6M=;
  b=FpFLwSTgxLFoc7KN7wWU6srqv2jxCEQJi2AJ2nd5mrmZndJK5A5MJM8o
   hm3qG3oS8iigCqVc7uG7fm16ZYVRdbUWJPH1Kp/vxL1XPSUtt+SoYBOX3
   eV9txgNIaZlncsXDdGRo7xhjMjLHSXS0Xi3ifGhwUP5W90Cz/V+9wIm2G
   4=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: ANsPVcZJiRCn47DXYyUQQ1W6NMHmhKTb7WQdUXLBvd8pcQGBDucRxMFOLSCQnB1/z/XKah1hZh
 CQUgauqG9i8MDeGqU3ugPyA03h7bCfNzS3pQCF3zsHuHs+LzqbE55j0vZFczjF65N6l7cGlkwJ
 /NXdAQ288rTl0qaHjQomBNaHhf38J+9xuv6sWSgXf0DNoCMqmBtFqWBspTCpgm2FOKUj2AssK3
 bVnbNFSU/nvd+4fOB2d3qM4V0mrTG90YZittA6/weA+pdksh3LGAmztCmmpZIbBa99opa7YavC
 KP488YNQilTx30S6r/8xy+QH
X-SBRS: 5.2
X-MesageID: 63336349
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:xTDdAaMKnnXClLTvrR0dkMFynXyQoLVcMsEvi/4bfWQNrUpxhDIEn
 GQaC22Ha6neZWT9f4sjPIvipx4GusDVmII1Twto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6UUsxNbVU8En1500o5w7RRbrNA2rBVPSvc4
 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq
 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYoyiZkd8t8
 /4XjJW5TV4ZbpfHn/wwCDANRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs
 6VFdnZdNXhvhMrvqF6/YvNrick5atHiIasUu216zCGfBvEjKXzGa/uRvoQGh2th7ixINfnMb
 OcWZHlGUEyDYURMP1o+Eb07vPj90xETdBUH8QnI9MLb+VP71xdt2bLgNN7UfN2iRshPmEuc4
 GXc8AzRAAweNdGZ4SqI9DSrnOCntR38XIUeBbip7MlAiVeYxnEQIBAOXF79qv684mayUsxSA
 1YZ8S0vqe417kPDZsb5dw21pjiDpBF0c8pdFag25R+AzoLQ4h2FHS4UQzhZctskucQqAzsw2
 TehndnkGDhuu729Um+G+/GfqjbaESoaN2gZfgcfUBAIpdLkpekOYgnnF4g5VvTv15usRG+2k
 2viQDUCa6s7kN4F2PmA1gr+ijuo/6iZdAUy/iiMdzfwhu9mX7KNa4ut4FndyP9PKoeFU1WM1
 EQ5d9iiAPMmVs/UynHUKAkZNPTwvqvebmWA6bJ6N8R5r1yQF2ifkZe8Cd2UDGNgKY46dDDge
 yc/UisBtcYIbBNGgUKaCr9d6vjGL4C8RLwJtdiON7Kih6SdkyfcpElTiba4hTyFraTVufhX1
 W2nWcitF20GLq9s0SC7QewQuZdymHxlmj+KFMGmlkr3uVZ7WJJyYexdWGZik8hjtP/UyOkr2
 4o32zS2J+V3D7SlP3i/HX87JlEWN3krba0aWOQMHtNv1jFOQTl7Y9eImOtJU9U8w8x9y7mUl
 lngBB4w4Aev1BXvdFTRAlg+OeyHYHqKhS9hVcDaFQz2iyFLjEfGxPp3SqbbipF8pbE6kK4pE
 6JYEyhCa9wWIgn6F/0mRcCVhKRpdQixhBLIOCygYTMleIVnSRCP8djhFjYDPgFTZsZuncdh8
 bCmyC3BRp8PG1ZrAMrMMar9xFKtp3kN3ul1WhKQcNVUfUzt9qlsKjDw0aBrc51dd02by2vIz
 RuSDDcZufLJ/90//u7WiP3WtIyuCeZ/QBZXRjGJ8basOCDG1WO/2oscAv2QdDXQWTqsqqWvb
 OlY1d/mN/gDkAoYuoZwCe8zn6k/+8Hut/lRyQE9RCfHaFGiC7VBJHia3JYQ6v0Rl+EB4QbvA
 xCB4NhXP7mNKfjJKl9JKVp3dPmH2NEVhiLWsaY/LnLl6XIl57GAS0hTYUWB0XQPMLtvPYo56
 u49o8pKuRengx8nP9va3CBZ82OAci4JX6k978xIBYbqjkwgy01YYIyaASjzucndZ9JJO0gsA
 zmVmKud2OgMmhucKyI+RSrXwO5QpZUSoxQbnlYNKmOAlsfBmvJqjgZa9i46T1gNwxhKuw6p1
 rOH66GhyX2ywgpV
IronPort-HdrOrdr: A9a23:C8Zfeqyvt/HOkozXvp5nKrPxtOskLtp133Aq2lEZdPULSKOlfp
 GV8MjziyWYtN9wYhAdcdDpAtjmfZr5z+8O3WB3B8beYOCGghrSEGgG1+XfKlLbak/DH4JmpM
 Jdmu1FeaHN5DtB/LfHCWuDYq8dKbC8mcjC74eurEuFDzsaE52Ihz0JdDpzeXcGIjWua6BJcK
 Z1saF81kWdkDksH4+GL0hAe9KGi8zAlZrgbxJDLxk76DOWhTftzLLhCRCX0joXTjsKmN4ZgC
 X4uj28wp/mn+Cwyxfa2WOWx5NKmOH5wt8GIMCXkMAaJhjllw7tToV8XL+puiwzvYiUmRwXue
 iJhy1lE9V46nvXcG3wiRzx2zP42DJr0HPmwU/wuwqUneXJABYBT+ZRj4NQdRXUr2A6ustn7a
 5N12WF87JKEBLphk3Glpb1fiAvsnDxjWspkOYVgXAae5AZcqVtoYsW+14QOIscHRj99JssHI
 BVfY7hDc5tABOnhk3izypSKITGZAVwIv7GeDlPhiWt6UkWoJgjpHFogfD2nR87heUAotd/lq
 D5259T5cJzp/ktHNZA7dc6MLuK41P2MGDx2UKpUB3a/fI8SjrwQ6Ce2sRB2AjtQu1O8KcP
X-IronPort-AV: E=Sophos;i="5.88,337,1635220800"; 
   d="scan'208";a="63336349"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=U8PHBfuGW3FT7deHRf+chzbWa/6TDM0DH1mNPyCC/JEoeuwOXFnlCT+XHsomQ8+cROcPKXFYmM12q91COhuh+zARcF/gl029IToOAxMiB//1lYAG+VmOSIhVxpvahOar1n5bf/Y7JHnj4m6Fu5ewBqXDgEZQXBhUPTwOq/XTWVangmPsUfR44ZlwZsTq9UwAqbrRqE7sLx/ad/vyxKK/43lWZimqcdIwAT36HUfTrsgpz0yJqh9gINeCKIGgcCr0Y24mkJTu1TTflKerF6hdCmjEBCz2ZuGjKAyvhmsdYOI4U83b73Y8sTiyYrsTab51Nz8BFe8bhSFTBFtA+MIc0A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=oX2XUgQZLdvJTKeETKdvaH3bGnwRKUNefaD29Rt6NWc=;
 b=CJKwiQTPScSfNmi9fA5E9VckzONDKfK2CTv9f4k8dZYXz+uQGGs61cCfXzTnt6FvrgD1ZTNbEAK6cjFlkJK8QTH7ABWaAtFNnVzh+R/GxpCgLdUV614g5ipQio4y6iNG6b4oPy39YtXZ8eFaa8ajuhiZS5+ayrPC224BLeBKwvO8fuLZsAxtqAf9i4lPRjcIcn1O7rKjP+OTu20MowTc6A4LJMrktqHV9OshdxfXxQEzTaGUXaGfiiTqzCBb8TarnD32lqZYwC5VSeqtKHXs57iEZG9jwacAyEJnIpmWLcz4/bKBRtcgVVKSX+Jvlzkt36bxtFrtWtC+xKhx8dAYUA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=oX2XUgQZLdvJTKeETKdvaH3bGnwRKUNefaD29Rt6NWc=;
 b=KUhmD3UTKxyZDIrKtiOQVwB6gRCQXc6vPlloPlh98iTMtsKclyer4OLA+4vViXjdXqeak+tIMyxkNu1bfJqVtMUe0V3IYFL2D9M4OXnamPjKNOwjiL1lofuy6lXjaQgu+Hc6G4SU+xivpg0HxqJjN65r7mZQSL2KRcIwCc+pxzQ=
Date: Wed, 2 Feb 2022 17:21:22 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jane Malalane <Jane.Malalane@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>, Anthony
 Perard <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, Andrew
 Cooper <Andrew.Cooper3@citrix.com>, George Dunlap <George.Dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>, Stefano
 Stabellini <sstabellini@kernel.org>, Christian Lindig
	<christian.lindig@citrix.com>, David Scott <dave@recoil.org>, Volodymyr
 Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH 2/2] x86/xen: Allow per-domain usage of hardware
 virtualized APIC
Message-ID: <YfqvgvnKvkLCuupA@Air-de-Roger>
References: <20220127160133.11608-1-jane.malalane@citrix.com>
 <20220127160133.11608-3-jane.malalane@citrix.com>
 <YfkFJTYXa/7DSTaI@Air-de-Roger>
 <1364444e-aeed-7e0c-dc81-67365324350b@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1364444e-aeed-7e0c-dc81-67365324350b@citrix.com>
X-ClientProxiedBy: LO4P123CA0405.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:189::14) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 09d1b435-3dac-4062-0f2e-08d9e6680f29
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6389:EE_
X-Microsoft-Antispam-PRVS: <SJ0PR03MB63897F26018971B2964D29D08F279@SJ0PR03MB6389.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: ZtzRv1ZCFHKiKhgFeP8cfvu1T0GEGoXvKuPVHJko4xXhF1HU1FTT4nU9Y6hDrTJ8oyxnPoIPASAzW+tWQAiXy9pYz4ZMudPDiBvph84FKBIup4vva7oW0153TvU/bOcBKc+/VfMkbIQdT1d1ZvxuZCoHtDulqEAmEeDYvU5HF65x5n+SEvvGBweQZP9ra2XQa1pd7MGKHOeWK+yFX45+KfXZoXO9uj7uwzIECuaIMZ7p6G0iTk0Q4ePPPcahS2OPTKJnCg+h0J4RNaXlaMEKSJV5VU6nYO7UjeQJ5Tu0yH4pfOH3zdjVMzkjVTiyRii1OIL5b5YNY0niyjhvxT4K8xpiEkBeUfHFBI04R5DTrbGO9IWAvIsevzebiEMiJmI4Hy2qfoZ05FBXhQdeShdBHldIjq2aMrKgeD9+uLWydYjeAPg5Qf9JcWtkhi2EhdaIxLeBeAZeIK0CsBEDKf5kGHSKrHwtpZ0Xis14xbEm7mXgYffPqp1ndnscQ+95UTypQOkoflv3Yhu8t/MSku57CpSKN4iWanvn17uvadJyFsKRLaKiy/PjR/1C2YqWpXOnvzpJw2C0vsOUcCfXJkudpA9O3qTEoeRDO4zyotiGZ4wbh90f6Ri969B4EpYIdKY2yClC2ZxB1QbN+JB2+5opTg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(86362001)(33716001)(38100700002)(82960400001)(53546011)(6506007)(5660300002)(4326008)(66946007)(66556008)(54906003)(85182001)(66476007)(508600001)(6862004)(8676002)(8936002)(6666004)(6636002)(9686003)(6512007)(316002)(186003)(26005)(83380400001)(2906002)(6486002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Qzlyek41bnpjcnJ2MDBuWDdnNDBKOWoxRHc5WlQxU2tBOUdYWVRlMFlXa0pB?=
 =?utf-8?B?YldnZ0Z0YTVmcVd0VnFsN2NPYnl2UEFOL3pBU1hKcGNLYXNwMEJJNklheG5Z?=
 =?utf-8?B?b25jb2hFNk1yU25pR0VBV0pQbE95OUtLRWxYL29lcXZjeFN5c3ZqMnF0cUd3?=
 =?utf-8?B?SzlReVA1NXJScjcxRGozT1RZb2w1TWRXUjRoSzNBNFFuR0ZJVitTWFdob3p6?=
 =?utf-8?B?YklKZ3lySmJtbkw3WXppSjg4eGZreWl6UzY3aVNJcUF5d08yZzdoNjBBNzJH?=
 =?utf-8?B?bTVOQmxkZVRUT1Z1MzhCTE44OEZ0dFB2RVJhcmp2RnNxUUNOc2VWdTBlTThl?=
 =?utf-8?B?UGpaMitwZnhqbUZmZU0rUEk1M1RBbUFQU2pheXdWWTk5UnpheDNiVkZNR2xv?=
 =?utf-8?B?eFhGWit6ZE5UQnBMOVBMQmphRnVwc3habEl1NXhsc2R4TlJGMmpEOExTUmtH?=
 =?utf-8?B?bzNldFBPVmZadGw1L2t1NjNHOTZuWTIzQ0pwSkJ5all6RndYaWxaMXdSVERr?=
 =?utf-8?B?Ym1sM3lXeG9MeXYyTS9ZRVdKYUFCK210TWQ3RkdpYW5mQkdRSFpjQkU0Nmxn?=
 =?utf-8?B?L25zWG5TUzhaSmxzeEtoZDYySThtTmJYaU1xSU1UaGlRTVVwQUdPM2c5TUM5?=
 =?utf-8?B?TTE2TlJGWmpINTIyRjV4UGEyMnhuVFdkd01QTzlwQWlOb1VvczY4MUNDeXQ2?=
 =?utf-8?B?aG0zY003TitrMStTelo5UzVBUXlNVTd6Rlh4b1NmTENSVTdONm5xVDUwMlRu?=
 =?utf-8?B?Y3JWRmNMbkFsVmVOOGF3TlBudlA0M3E0Y3RpWTFIdGVFQzlnM2VKYVZ0RTJS?=
 =?utf-8?B?WTQra3l5aFlnOWdEZFdydUswM2k5a1Y2MGxkZ1haNlNRYmRhTHlJYWRMbDNN?=
 =?utf-8?B?bStNSWwrc0NnRlRNZCtZMDB4UnRTTi9FUk9BQ1RudDgyR25ZRTdkMVI2VHNk?=
 =?utf-8?B?anNnNDRadXNHUkdjUHpGOE1jQ2hUNjJLbVVsenNTRkRqUVNGRE00WnlMYjdp?=
 =?utf-8?B?ejJDRmZNemQxZkQwQnd6U2MzdnU2d1BjSnNNOGw1K3lTK09ZOEJxQnl1T1RW?=
 =?utf-8?B?NllaTVM1bVVFbUZlR1VQNXRrcE5jNk9nMFFVK1p0WWtkMmwvb2tQTUFFNlNm?=
 =?utf-8?B?NFF6SjBDUjZBMnB6Y3lWdkJWNlR2VUpQSmNkMXBQUTNseGZ5RFkxaXlQYWdj?=
 =?utf-8?B?TmJtQTdUdDY3bmdIUmhZdDlTWGNCc1Nud3JxMXppNGZjOERyaU1qMFQ3c1RN?=
 =?utf-8?B?NEkzdFVTdTBPeUFSb2tXbFJDRTJGWWhnbXEzOVI1OStsRlM2cUNndUYvOSsv?=
 =?utf-8?B?VXVyWGhqcXBtZzF4ZGFTUTVwbVJvTktVdlN0RDZhSTAzUFpqRXRyaWNtQWp1?=
 =?utf-8?B?NEJGNmtMMHNvRTdGWExscDJPY29IYkwyakFpUGlOMmlzaS9vdUpvQnFwUnZr?=
 =?utf-8?B?TlVlZ0doanExaEVmVzFHQk9lSWxodDlEQWthTElWSGx2UEhtRitHYzZzZWlV?=
 =?utf-8?B?VFpKU3YxRHBHNDA2dGZBTVU4VG9VSzlnTmsydlY4TGt0MzVVcElKcXlhRk9E?=
 =?utf-8?B?RG1hQVI2cVk5VjUvRHhOazdFSzRUKzVFUEVtS1RCeFpLcHltK01kWlp4UjMv?=
 =?utf-8?B?bUM5Y3pDZW5ZckFuTWUyenVNYlRUMW5Qc0VsVFY1VkZoOFh4MW5tUFZKQXUy?=
 =?utf-8?B?RDh2VU95K3NhOXhTQzlhcHl0WnVnbFhaZk83SVVoMUNIcDMyM3JRbkJ1QWJ1?=
 =?utf-8?B?TjJHZW8vMnpnUDdpL3BBU3ZCZGx1NUFaQXNmQ0xvMUF4MVpJb0plRVN5Z3dl?=
 =?utf-8?B?WEQ0SHptZnY4UVkydDB2c0N1cEU5enNVQ2laVGZiMUpNdUkybzdURUkwS3Rv?=
 =?utf-8?B?L0JXeTBBckh2Sjl2TTJPSEF6UnZydEpnRDB6U3JZQUlIUGQvOHpmZmM5bEk1?=
 =?utf-8?B?NzZOZTBMZ3BCdHl1YnAzWGZiSVpQZkJ4U2I2NjcvQytOczM3Sm1ZeFY0UTA5?=
 =?utf-8?B?aUJYaGpoRUppYVg1WTl1SG5KUVJnanVybEpnS2ZWY2dVSm9NOWR0UDA1MCs1?=
 =?utf-8?B?KytqemhBV09HNytGbzI2TjBCZHZBSUNBOWZYQ1Q0YkRXZGNTVWcxQ0pZM2hW?=
 =?utf-8?B?OFNDZ01keGJ0TTNkY1h2QmpSZjZBb3dHMFY4TzRNU2NZK2ZpL3dIblNROFZF?=
 =?utf-8?Q?kKNHCGhhf4jzrt2/euvCMOE=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 09d1b435-3dac-4062-0f2e-08d9e6680f29
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2022 16:21:25.7159
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4mH6pm45+gLbGE90mR5Hea82C3E+cTDWAEByt6UEWmLqyqXR0/gX2igs3b4SZKRcCH8aMQoJTjKXZZmddBFnwg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6389
X-OriginatorOrg: citrix.com

On Wed, Feb 02, 2022 at 03:19:13PM +0000, Jane Malalane wrote:
> On 01/02/2022 10:02, Roger Pau Monné wrote:
> > On Thu, Jan 27, 2022 at 04:01:33PM +0000, Jane Malalane wrote:
> >> diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl
> >> index 42ac6c357b..db5eb0a0b3 100644
> >> --- a/tools/libs/light/libxl_types.idl
> >> +++ b/tools/libs/light/libxl_types.idl
> >> @@ -819,11 +825,44 @@ void libxl__arch_domain_create_info_setdefault(libxl__gc *gc,
> >>   {
> >>   }
> >>   
> >> -void libxl__arch_domain_build_info_setdefault(libxl__gc *gc,
> >> -                                              libxl_domain_build_info *b_info)
> >> +int libxl__arch_domain_build_info_setdefault(libxl__gc *gc,
> >> +                                             libxl_domain_build_info *b_info,
> >> +                                             const libxl_physinfo *physinfo)
> >>   {
> >> +    int rc;
> >> +    bool assisted_xapic;
> >> +    bool assisted_x2apic;
> >> +
> >>       libxl_defbool_setdefault(&b_info->acpi, true);
> >>       libxl_defbool_setdefault(&b_info->arch_x86.msr_relaxed, false);
> >> +
> >> +    libxl_defbool_setdefault(&b_info->arch_x86.assisted_xapic, false);
> >> +    libxl_defbool_setdefault(&b_info->arch_x86.assisted_x2apic, false);
> >> +
> >> +    assisted_xapic = libxl_defbool_val(b_info->arch_x86.assisted_xapic);
> >> +    assisted_x2apic = libxl_defbool_val(b_info->arch_x86.assisted_x2apic);
> >> +
> >> +    if ((assisted_xapic || assisted_x2apic) &&
> >> +        b_info->type == LIBXL_DOMAIN_TYPE_PV)
> >> +    {
> >> +        LOG(ERROR, "Interrupt Controller Virtualization not supported for PV");
> >> +        rc = ERROR_INVAL;
> >> +        goto out;
> >> +    }
> >> +
> >> +    if ((assisted_xapic && !physinfo->cap_assisted_xapic) ||
> >> +         (assisted_x2apic && !physinfo->cap_assisted_x2apic))
> >> +    {
> >> +        LOG(ERROR, "x%sAPIC hardware supported emulation not available",
> >> +            assisted_xapic && !physinfo->cap_assisted_xapic ? "" : "2");
> >> +        rc =  ERROR_INVAL;
> >> +        goto out;
> >> +    }
> > 
> > I think the logic here is slightly wrong, as you are setting the
> > default value of assisted_x{2}apic to false, and we would instead like
> > to set it to the current value supported by the hardware in order to
> > keep current behavior.
> > 
> > Also the options are HVM/PVH only, so having them set for PV should
> > result in an error regardless of the set value, ie:
> > 
> > if (b_info->type == LIBXL_DOMAIN_TYPE_PV &&
> >      (!libxl_defbool_is_default(&b_info->arch_x86.assisted_xapic) ||
> >       !libxl_defbool_is_default(&b_info->arch_x86.assisted_x2apic)))
> >       ERROR
> > 
> > libxl_defbool_setdefault(&b_info->arch_x86.assisted_xapic,
> >                           physinfo->cap_assisted_xapic);
> > libxl_defbool_setdefault(&b_info->arch_x86.assisted_x2apic,
> >                           physinfo->cap_assisted_x2apic);
> > 
> > I don't think you need the local assisted_x{2}apic variables.
> 
> Makes sense. In that case, could I instead just have this?
> 
> if (b_info->type != LIBXL_DOMAIN_TYPE_PV)
> {
>      if (physinfo->cap_assisted_xapic)
>          libxl_defbool_setdefault(&b_info->arch_x86.assisted_xapic, true);
>      if (physinfo->cap_assisted_x2apic)
>          libxl_defbool_setdefault(&b_info->arch_x86.assisted_x2apic, true);

I think you actively need to set assisted_x{2}apic if they are using
default values, or else a later call to libxl_defbool_val will cause
an assert to trigger.

libxl_defbool_setdefault(&b_info->arch_x86.assisted_xapic,
                         physinfo->cap_assisted_xapic);


assisted_x{2}apic need to either resolve to true or false past this
point, but must not be left using it's default (uninitialized) value.

> }
> 
> Or do i still need to also check that assisted_x{2}apic hasn't been set 
> elsewhere for PV domains, in which case, I'm happy to add the code you 
> proposed above with this code I have here too.

I would prefer if we actively rejected options that don't make
sense.

It's wrong to try to set assisted_x{2}apic for PV because there's no
APIC at all in that case. I will defer to the maintainer, but I would
prefer if an error was reported in that case. I know we are not
consistent in that regard, so I'm not going to block what you propose.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Feb 02 17:30:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 17:30:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264368.457457 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFJSi-0005da-7s; Wed, 02 Feb 2022 17:30:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264368.457457; Wed, 02 Feb 2022 17:30:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFJSi-0005ck-37; Wed, 02 Feb 2022 17:30:32 +0000
Received: by outflank-mailman (input) for mailman id 264368;
 Wed, 02 Feb 2022 17:30:30 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=FkQ0=SR=xilinx.com=ayankuma@srs-se1.protection.inumbo.net>)
 id 1nFJSg-0005L1-KN
 for xen-devel@lists.xenproject.org; Wed, 02 Feb 2022 17:30:30 +0000
Received: from NAM10-BN7-obe.outbound.protection.outlook.com
 (mail-bn7nam10on20602.outbound.protection.outlook.com
 [2a01:111:f400:7e8a::602])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id cf8c5d90-844d-11ec-8eb8-a37418f5ba1a;
 Wed, 02 Feb 2022 18:30:28 +0100 (CET)
Received: from BN1PR10CA0024.namprd10.prod.outlook.com (2603:10b6:408:e0::29)
 by BY5PR02MB7059.namprd02.prod.outlook.com (2603:10b6:a03:235::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Wed, 2 Feb
 2022 17:30:25 +0000
Received: from BN1NAM02FT032.eop-nam02.prod.protection.outlook.com
 (2603:10b6:408:e0:cafe::fc) by BN1PR10CA0024.outlook.office365.com
 (2603:10b6:408:e0::29) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12 via Frontend
 Transport; Wed, 2 Feb 2022 17:30:24 +0000
Received: from xir-pvapexch02.xlnx.xilinx.com (149.199.80.198) by
 BN1NAM02FT032.mail.protection.outlook.com (10.13.3.192) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.4951.12 via Frontend Transport; Wed, 2 Feb 2022 17:30:24 +0000
Received: from xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) by
 xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2176.14; Wed, 2 Feb 2022 17:30:23 +0000
Received: from smtp.xilinx.com (172.21.105.198) by
 xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server id
 15.1.2176.14 via Frontend Transport; Wed, 2 Feb 2022 17:30:23 +0000
Received: from [10.108.8.223] (port=56994 helo=xcbayankuma41x.xilinx.com)
 by smtp.xilinx.com with esmtp (Exim 4.90)
 (envelope-from <ayan.kumar.halder@xilinx.com>)
 id 1nFJSZ-0004a1-Ex; Wed, 02 Feb 2022 17:30:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cf8c5d90-844d-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Ecr0UWO4SyOlSiknVVcc+mMeSm6YDy1WGbIqZTjCsehAUh1NZmzu8zC2WtroeeEvk0c+JFSDQ6YxLyZWnINnz30EyxxPzns+o6JHv3+Amr8X9i/CbikJJcct+PL0yeyFDr4LuClyJidy9D7oIGNbV7+o14fHpaZ+PscH3e5/qhwK+wuPG2pJQ6NcENBIYFKHlV1vH32txKjj0xIhgvG3jGsUwIz6zwJyKWN/RVGs0DzSdpvWPlzSaM0t1yYj1AnxPZrlB8abbpnflXb7MZwoKhOkKYnbqGihDegDx/c5MuWrc30k4dM08/9jRAnLM3HiFYdE/qmn5rnEjXg1khs8kg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=4YH8/TrWz9r2OfPhgV0o4hdK3ZeJHqkEfhXElLsPw90=;
 b=AQxsYg+UT8wU6xAxwV+mJS5VVWhMpfYJAJrROWe8u8pTxbbSTtzxk155kTe4p3OvF9Vk8LqoWvnqUnOncNk/Z8byyvoe6+wjk2VYLbi56cKltcT0sP5ugmLWawwNPhjhpgafaQ/+eGfdpoARYYPPHtjvSj4xejLG+TaSZ+on7+2u9AS0476mTpn973GJQ5Uy94q5uPbsBGBArWcutbSpPYrAiTrRBjRE8s+Db5nitZPbpcY1e77OGfcAw7HgiKcFaH47dGLvgsBYMC8aYcZ1m2B8RB47WbKxbn0ZjjJ9EDVzEYupY2G/hFyZsspN25xQcePw0CKdIWDaEEXuafDYoA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 149.199.80.198) smtp.rcpttodomain=lists.xenproject.org
 smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none
 header.from=xilinx.com; dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=4YH8/TrWz9r2OfPhgV0o4hdK3ZeJHqkEfhXElLsPw90=;
 b=o3Dfco2M8+r0G5do2elLljl/5DAg8rHmrxK4/2v/H/lyGuEOMNN15/E4I/qyVF/mwmXafWOqYmMj18aIaqv9NFsJ7he4BPPGTfffVmz85EgcX3sO9cYn4QJNJPd2HuNeAJbktmna2er7ooK586YKsDnVMnE9VC42FiVJOxO6J20=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198)
 smtp.mailfrom=xilinx.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=xilinx.com;
Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates
 149.199.80.198 as permitted sender) receiver=protection.outlook.com;
 client-ip=149.199.80.198; helo=xir-pvapexch02.xlnx.xilinx.com;
From: Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>
To: <xen-devel@lists.xenproject.org>
CC: <sstabellini@kernel.org>, <stefanos@xilinx.com>, <julien@xen.org>,
	<Volodymyr_Babchuk@epam.com>, <bertrand.marquis@arm.com>, Ayan Kumar Halder
	<ayankuma@xilinx.com>
Subject: [XEN v6 2/3] xen/arm64: io: Support instructions (for which ISS is not valid) on emulated MMIO region using MMIO handler
Date: Wed, 2 Feb 2022 17:30:16 +0000
Message-ID: <20220202173017.48463-3-ayankuma@xilinx.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20220202173017.48463-1-ayankuma@xilinx.com>
References: <20220202173017.48463-1-ayankuma@xilinx.com>
MIME-Version: 1.0
Content-Type: text/plain
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 8f3963ef-38f8-40c3-ddbc-08d9e671b249
X-MS-TrafficTypeDiagnostic: BY5PR02MB7059:EE_
X-Microsoft-Antispam-PRVS:
	<BY5PR02MB70592840D48237728856B050B2279@BY5PR02MB7059.namprd02.prod.outlook.com>
X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	J53F8qZaLUKi8WWrGKTSjg1Nnids8JVZDRyDH+E+DwlqdDXXW/yJR4uroenFaCayNSCy6v91NZoHUdSr4QHx+2QXnqs0VbYdE4mKT5IEeyZuAv7R4sSaskx53cmOXa5Kclm1LeEZmlu30xeJ7+BUBUkhtpdiZ97C33VFxs/t3HBfnBLlQyRz+V+xMBJc1zb870glpgKlwJ9mrMiKsvAomXitQkZbDUlz17Wel2Sn7tSBuU+84vfthgi6Meabh86YG+MUXN95R+avMthc7g9DVzcKv86w57pscouy8g8NkR1yS/OOqSZWp96Do/jqPlCGAT/vn7CfNGnyvGohPlrUVo8pREau3lzigyvloMTQJ5f1/RIhfBhA/iWhCrKLqptedocooewktJhli6zqhHwEjZYNv+MR9TdjT8l1OBstvdIRVQr7cnOia+gNhdZTtChQlNjDPC+g17bK3gPkhEyo1iEmooP8kL7FoAq6tF2Zz4UAneUEqQ6DhxW3/rCDPQox3DvxEBN1y8pCya17D8GMosVCOGPK33RTBwb2itwsPsw/Q9ch39gp5739lqUPdDw+V7nQafEScSUFEkAs+8XSGzUUJ/9G/nB3CETjjdN6VPURrqGEKaMXLhAbDl6CwVlC5qLhD/sramyP9XFjbD+d8Kdbq6HPVl3t8YjHPJkIs12y/ceIFPhAbQPKLLpJ5BBU4/R4Ke1FUaFSifDy5W0C9g==
X-Forefront-Antispam-Report:
	CIP:149.199.80.198;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:xir-pvapexch02.xlnx.xilinx.com;PTR:unknown-80-198.xilinx.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(2616005)(2906002)(36756003)(6666004)(36860700001)(508600001)(26005)(186003)(1076003)(6916009)(107886003)(7696005)(316002)(54906003)(426003)(83380400001)(7636003)(47076005)(70206006)(70586007)(4326008)(8936002)(8676002)(82310400004)(336012)(356005)(5660300002)(9786002)(102446001)(473944003);DIR:OUT;SFP:1101;
X-OriginatorOrg: xilinx.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2022 17:30:24.4795
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 8f3963ef-38f8-40c3-ddbc-08d9e671b249
X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.80.198];Helo=[xir-pvapexch02.xlnx.xilinx.com]
X-MS-Exchange-CrossTenant-AuthSource:
	BN1NAM02FT032.eop-nam02.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR02MB7059

For instructions on MMIO regions emulated by Xen, Xen reads the
remaining bits of the HSR. It determines if the instruction is to be
ignored, retried or decoded. If it gets an error while decoding the
instruction, then it sends an abort to the guest.

If the instruction is valid or successfully decoded, Xen tries to
execute the instruction for the emulated MMIO region. If the instruction
was successfully executed, then Xen determines if the instruction needs
further processing. For eg:- In case of ldr/str post indexing on arm64,
the rn register needs to be updated.

Signed-off-by: Ayan Kumar Halder <ayankuma@xilinx.com>
---

Changelog :-

v2..v5 - Mentioned in the cover letter.

v6 - 1. Mantained the decoding state of the instruction. This is used by the
caller to either abort the guest or retry or ignore or perform read/write on
the mmio region.

2. try_decode() invokes decoding for both aarch64 and thumb state. (Previously
it used to invoke decoding only for aarch64 state). Thus, it handles all the
checking of the registers before invoking any decoding of instruction.
try_decode_instruction_invalid_iss() has thus been removed.

 xen/arch/arm/arm32/traps.c       |   6 ++
 xen/arch/arm/arm64/traps.c       |  41 ++++++++++++
 xen/arch/arm/decode.h            |  12 +++-
 xen/arch/arm/include/asm/traps.h |   2 +
 xen/arch/arm/io.c                | 108 +++++++++++++++++++++++++------
 5 files changed, 148 insertions(+), 21 deletions(-)

diff --git a/xen/arch/arm/arm32/traps.c b/xen/arch/arm/arm32/traps.c
index 9c9790a6d1..6ad9a31499 100644
--- a/xen/arch/arm/arm32/traps.c
+++ b/xen/arch/arm/arm32/traps.c
@@ -21,6 +21,7 @@
 
 #include <public/xen.h>
 
+#include <asm/mmio.h>
 #include <asm/processor.h>
 #include <asm/traps.h>
 
@@ -82,6 +83,11 @@ void do_trap_data_abort(struct cpu_user_regs *regs)
         do_unexpected_trap("Data Abort", regs);
 }
 
+void post_increment_register(const struct instr_details *instr)
+{
+    ASSERT_UNREACHABLE();
+}
+
 /*
  * Local variables:
  * mode: C
diff --git a/xen/arch/arm/arm64/traps.c b/xen/arch/arm/arm64/traps.c
index 9113a15c7a..4de2206801 100644
--- a/xen/arch/arm/arm64/traps.c
+++ b/xen/arch/arm/arm64/traps.c
@@ -18,9 +18,12 @@
 
 #include <xen/lib.h>
 
+#include <asm/current.h>
 #include <asm/hsr.h>
+#include <asm/mmio.h>
 #include <asm/system.h>
 #include <asm/processor.h>
+#include <asm/regs.h>
 
 #include <public/xen.h>
 
@@ -44,6 +47,44 @@ void do_bad_mode(struct cpu_user_regs *regs, int reason)
     panic("bad mode\n");
 }
 
+void post_increment_register(const struct instr_details *instr)
+{
+    struct cpu_user_regs *regs = guest_cpu_user_regs();
+    register_t val;
+
+    /*
+     * Handle when rn = SP
+     * Refer ArmV8 ARM DDI 0487G.b, Page - D1-2463 "Stack pointer register selection"
+     * t = SP_EL0
+     * h = SP_ELx
+     * and M[3:0] (Page - C5-474 "When exception taken from AArch64 state:")
+     */
+    if (instr->rn == 31 )
+    {
+        if ( (regs->cpsr & PSR_MODE_MASK) == PSR_MODE_EL1h )
+            val = regs->sp_el1;
+        else if ( ((regs->cpsr & PSR_MODE_MASK) == PSR_MODE_EL1t) ||
+                    ((regs->cpsr & PSR_MODE_MASK) == PSR_MODE_EL0t) )
+            val = regs->sp_el0;
+        else
+            ASSERT_UNREACHABLE();
+    }
+    else
+        val = get_user_reg(regs, instr->rn);
+
+    val += instr->imm9;
+
+    if ( instr->rn == 31 )
+    {
+        if ( (regs->cpsr & PSR_MODE_MASK) == PSR_MODE_EL1h )
+            regs->sp_el1 = val;
+        else
+            regs->sp_el0 = val;
+    }
+    else
+        set_user_reg(regs, instr->rn, val);
+}
+
 /*
  * Local variables:
  * mode: C
diff --git a/xen/arch/arm/decode.h b/xen/arch/arm/decode.h
index fe7512a053..5efd72405e 100644
--- a/xen/arch/arm/decode.h
+++ b/xen/arch/arm/decode.h
@@ -52,7 +52,17 @@ union instr {
 #define POST_INDEX_FIXED_MASK   0x3B200C00
 #define POST_INDEX_FIXED_VALUE  0x38000400
 
-/* Decode an instruction from pc
+enum instr_decode_state
+{
+    INSTR_ERROR, /* Error encountered while decoding the instruction */
+    INSTR_VALID, /* ISS is valid, so there is no need to decode */
+    INSTR_SUCCESS, /* Instruction is decoded successfully */
+    INSTR_IGNORE, /* Instruction is to be ignored (similar to NOP) */
+    INSTR_RETRY /* Instruction is to be retried */
+};
+
+/*
+ * Decode an instruction from pc
  * /!\ This function is intended to decode an instruction. It considers that the
  * instruction is valid.
  *
diff --git a/xen/arch/arm/include/asm/traps.h b/xen/arch/arm/include/asm/traps.h
index 2ed2b85c6f..95c46ad391 100644
--- a/xen/arch/arm/include/asm/traps.h
+++ b/xen/arch/arm/include/asm/traps.h
@@ -109,6 +109,8 @@ static inline register_t sign_extend(const struct hsr_dabt dabt, register_t r)
     return r;
 }
 
+void post_increment_register(const struct instr_details *instr);
+
 #endif /* __ASM_ARM_TRAPS__ */
 /*
  * Local variables:
diff --git a/xen/arch/arm/io.c b/xen/arch/arm/io.c
index a289d393f9..1011327058 100644
--- a/xen/arch/arm/io.c
+++ b/xen/arch/arm/io.c
@@ -95,6 +95,59 @@ static const struct mmio_handler *find_mmio_handler(struct domain *d,
     return handler;
 }
 
+enum instr_decode_state try_decode_instruction(const struct cpu_user_regs *regs,
+                                               mmio_info_t *info)
+{
+    int rc;
+
+    /*
+     * Erratum 766422: Thumb store translation fault to Hypervisor may
+     * not have correct HSR Rt value.
+     */
+    if ( check_workaround_766422() && (regs->cpsr & PSR_THUMB) &&
+         info->dabt.write )
+    {
+        rc = decode_instruction(regs, info);
+        if ( rc )
+        {
+            gprintk(XENLOG_DEBUG, "Unable to decode instruction\n");
+            return INSTR_ERROR;
+        }
+    }
+
+    /* If ISS is valid, then no need to decode the instruction any further */
+    if (info->dabt.valid)
+        return INSTR_VALID;
+
+    /*
+     * Xen should not decode the instruction when it was trapped due to
+     * translation fault.
+     */
+    if ( info->dabt.s1ptw )
+        return INSTR_RETRY;
+
+    /*
+     * If the fault occurred due to cache maintenance or address translation
+     * instructions, then Xen needs to ignore these instructions.
+     */
+    if ( info->dabt.cache )
+        return INSTR_IGNORE;
+
+    /*
+     * Armv8 processor does not provide a valid syndrome for decoding some
+     * instructions. So in order to process these instructions, Xen must
+     * decode them.
+     */
+    rc = decode_instruction(regs, info);
+    if ( rc )
+    {
+        gprintk(XENLOG_ERR, "Unable to decode instruction\n");
+        return INSTR_ERROR;
+    }
+    else
+        return INSTR_SUCCESS;
+}
+
 enum io_state try_handle_mmio(struct cpu_user_regs *regs,
                               const union hsr hsr,
                               paddr_t gpa)
@@ -106,14 +159,14 @@ enum io_state try_handle_mmio(struct cpu_user_regs *regs,
         .gpa = gpa,
         .dabt = dabt
     };
+    int rc;
+    enum instr_decode_state state;
 
     ASSERT(hsr.ec == HSR_EC_DATA_ABORT_LOWER_EL);
 
     handler = find_mmio_handler(v->domain, info.gpa);
     if ( !handler )
     {
-        int rc;
-
         rc = try_fwd_ioserv(regs, v, &info);
         if ( rc == IO_HANDLED )
             return handle_ioserv(regs, v);
@@ -121,31 +174,46 @@ enum io_state try_handle_mmio(struct cpu_user_regs *regs,
         return rc;
     }
 
-    /* All the instructions used on emulated MMIO region should be valid */
-    if ( !dabt.valid )
+    state = try_decode_instruction(regs, &info);
+
+    /*
+     * If the instruction was to be ignored by Xen, then it should return to the
+     * caller which will increment the PC, so that the guest can execute the
+     * next instruction.
+     */
+    if ( state == INSTR_IGNORE )
+        return IO_HANDLED;
+    /*
+     * If Xen could not decode the instruction for any reason, then it should
+     * ask the caller to abort the guest.
+     */
+    else if ( state == INSTR_ERROR )
         return IO_ABORT;
+    /* When the instruction needs to be retried by the guest */
+    else if ( state == INSTR_RETRY )
+        return IO_UNHANDLED;
 
     /*
-     * Erratum 766422: Thumb store translation fault to Hypervisor may
-     * not have correct HSR Rt value.
+     * At this point, we know that the instruction is either valid or has been
+     * decoded successfully. Thus, Xen should be allowed to execute the
+     * instruction on the emulated MMIO region.
      */
-    if ( check_workaround_766422() && (regs->cpsr & PSR_THUMB) &&
-         dabt.write )
-    {
-        int rc;
+    if ( info.dabt.write )
+        rc = handle_write(handler, v, &info);
+    else
+        rc = handle_read(handler, v, &info);
 
-        rc = decode_instruction(regs, &info);
-        if ( rc )
-        {
-            gprintk(XENLOG_DEBUG, "Unable to decode instruction\n");
-            return IO_ABORT;
-        }
+    /*
+     * If the instruction was decoded and has executed successfully on the MMIO
+     * region, then Xen should execute the next part of the instruction. (for eg
+     * increment the rn if it is a post-indexing instruction.
+     */
+    if ( (rc == IO_HANDLED) && (state == INSTR_SUCCESS) )
+    {
+        post_increment_register(&info.dabt_instr);
     }
 
-    if ( info.dabt.write )
-        return handle_write(handler, v, &info);
-    else
-        return handle_read(handler, v, &info);
+    return rc;
 }
 
 void register_mmio_handler(struct domain *d,
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Wed Feb 02 17:30:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 17:30:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264367.457452 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFJSh-0005ar-Tx; Wed, 02 Feb 2022 17:30:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264367.457452; Wed, 02 Feb 2022 17:30:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFJSh-0005ak-R0; Wed, 02 Feb 2022 17:30:31 +0000
Received: by outflank-mailman (input) for mailman id 264367;
 Wed, 02 Feb 2022 17:30:30 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=FkQ0=SR=xilinx.com=ayankuma@srs-se1.protection.inumbo.net>)
 id 1nFJSg-0005L1-0u
 for xen-devel@lists.xenproject.org; Wed, 02 Feb 2022 17:30:30 +0000
Received: from NAM12-MW2-obe.outbound.protection.outlook.com
 (mail-mw2nam12on2060e.outbound.protection.outlook.com
 [2a01:111:f400:fe5a::60e])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id cf6604af-844d-11ec-8eb8-a37418f5ba1a;
 Wed, 02 Feb 2022 18:30:27 +0100 (CET)
Received: from BN6PR1401CA0022.namprd14.prod.outlook.com
 (2603:10b6:405:4b::32) by MN2PR02MB6047.namprd02.prod.outlook.com
 (2603:10b6:208:186::12) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.18; Wed, 2 Feb
 2022 17:30:23 +0000
Received: from BN1NAM02FT016.eop-nam02.prod.protection.outlook.com
 (2603:10b6:405:4b:cafe::1b) by BN6PR1401CA0022.outlook.office365.com
 (2603:10b6:405:4b::32) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12 via Frontend
 Transport; Wed, 2 Feb 2022 17:30:23 +0000
Received: from xir-pvapexch01.xlnx.xilinx.com (149.199.80.198) by
 BN1NAM02FT016.mail.protection.outlook.com (10.13.2.133) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.4951.12 via Frontend Transport; Wed, 2 Feb 2022 17:30:23 +0000
Received: from xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) by
 xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2176.14; Wed, 2 Feb 2022 17:30:22 +0000
Received: from smtp.xilinx.com (172.21.105.198) by
 xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server id
 15.1.2176.14 via Frontend Transport; Wed, 2 Feb 2022 17:30:22 +0000
Received: from [10.108.8.223] (port=56994 helo=xcbayankuma41x.xilinx.com)
 by smtp.xilinx.com with esmtp (Exim 4.90)
 (envelope-from <ayan.kumar.halder@xilinx.com>)
 id 1nFJSX-0004a1-Pg; Wed, 02 Feb 2022 17:30:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cf6604af-844d-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=RLXFXSiieKmMTa5slGorqqR7bhw0nLW01YbH1O4Nzp5ZoYzM+1jRUnVwCsdBMhUg0aTsY7PO6aCO29pBkBFNFzqq631vmU+ahy8O5rMvruPYmChJr9spOECrxLYj4bBU53dUWs3ldUTNKzbAln3UZpsX95bbOdj7AWrXwtnuYMnRoJdRd/musX+ReoeEZWkctutT5l4sG3a4oLj/RwbEog5279C8ht6NZY2+/WuQhNudB1gjNmTVjWwWCnDBQU2OL2iRitJfMspDR7CBt4P7VOmXXAaNFEAex23FU0jjLCX7wzpwfZPWBPMvNGKq087Nw0/Sm4Hh4IMj/IehQmD29g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=iHcAHp3QwX/xhztHCNTGGIUaHDk5FJxGg7bcpcAGof4=;
 b=Tq5EQI0tKGqtgLQe14UYJoWp3txg/Jp8waHRMZu2lIzuDxo9SuZt+SJGwbKfOWaDH/gpk6DlLVMKQ5JzsdKWW0zvbp/A6CJ2opssqCFsUz49e7/j3vP13Jj/ZNMmW/16noyc4mJOvxt0RQMiPhSYhCa/lqAJwPtFPckRHLruuiWaUlpC3XNx5fXfBhrCR4LpAagDt3F//j3H7EXF0PZO1aLCMvozorFQgjGxIIRwSzg8mRmCcqeNVY55PbN8F00YwyPBWhkY+WWqb06hki5FJNL21MfUFjg5JNFbZqZVMUa03KQCXiI+YOYW9GImIFEQDy4FKR4r8WJkOovHqldQlQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 149.199.80.198) smtp.rcpttodomain=lists.xenproject.org
 smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none
 header.from=xilinx.com; dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=iHcAHp3QwX/xhztHCNTGGIUaHDk5FJxGg7bcpcAGof4=;
 b=PI1hjXZL34e3DBVVYNRqnbr7HklYqk+0t9v5MxSHi0McK865EPpi1iCqHb0gPzQI+ly3nzoGC9G8i0nefHcNJ4o12BW6uvoLMo6YVddG2/2JDlZ1BZFSlVRKJqe+HElKbtTZTpFu8s4w7S9roI+uyr+lmD0EAilVU8OGOgPhlKQ=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198)
 smtp.mailfrom=xilinx.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=xilinx.com;
Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates
 149.199.80.198 as permitted sender) receiver=protection.outlook.com;
 client-ip=149.199.80.198; helo=xir-pvapexch01.xlnx.xilinx.com;
From: Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>
To: <xen-devel@lists.xenproject.org>
CC: <sstabellini@kernel.org>, <stefanos@xilinx.com>, <julien@xen.org>,
	<Volodymyr_Babchuk@epam.com>, <bertrand.marquis@arm.com>, Ayan Kumar Halder
	<ayankuma@xilinx.com>
Subject: [XEN v6 1/3] xen/arm64: Decode ldr/str post increment operations
Date: Wed, 2 Feb 2022 17:30:15 +0000
Message-ID: <20220202173017.48463-2-ayankuma@xilinx.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20220202173017.48463-1-ayankuma@xilinx.com>
References: <20220202173017.48463-1-ayankuma@xilinx.com>
MIME-Version: 1.0
Content-Type: text/plain
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 0f04e706-26ab-4a20-21be-08d9e671b1a9
X-MS-TrafficTypeDiagnostic: MN2PR02MB6047:EE_
X-Microsoft-Antispam-PRVS:
	<MN2PR02MB604798173E39ED48130AC3B2B2279@MN2PR02MB6047.namprd02.prod.outlook.com>
X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	pp/qUUdgAi7skKAeTWLv0CX0i9P/+CsvvoZHkLFkvNFh5IY3yXw/lEHFAH4gWI3p/MoTL2xhRBuiEQdPaMn0J2WvU6eU8AJuRdtVNM/lQ6D3DiuUS0oYY7QqOxkM77N2pgcD4buvHraXHOdiy0b0JJ5ygyEl/wg2ia7ZNY6OPCaWMt8mQmnvQfkn9P105V1kWddmhGA9PZJ5G1vnkeWI4HVxyo/HpwKoCDf/x142ru6GkOWNZztCXnctdu9bSRYecmpta/KC3PwJe7JF2KiGAQKXKU2p+S7ijUDmts5cdhe5DvKUdYWhzupB2iS0uUtYGSEpMne3XFaqtcnNOBaA0w+0XvdCCnxjzQBEkr4yGj5TYy5ZU3TwBczGQCrZ99mSEGlzbeiWkLARAp0+7EW86a+x7CtN+Q/oSh87s+aDvGkAWezR3H3nw14LW/01/zHX25XKF+ZBEn7ipC43/+vzqGWfkgi5+ByKjSwZHKgN4zeNAvZ8gqPPDaQ83UlHsAA59Hwnc2Qm1my7zuZkbDSFbdB3QU3vqlc4J9nSGmMIiR8xjwN56Tkx0W6tX+7q2Q4a4mIeQ6VVwmLMByNUidhBWbDbZqDB+aw4hOfanZBKR+Ll5ro6cPOLKY0q19gzMNTkN+HttyLS4hEoW++fOrkJOvdMzED1efFZYowc0S0jSRid4og+dS4HD6vrP4hP/MrU
X-Forefront-Antispam-Report:
	CIP:149.199.80.198;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:xir-pvapexch01.xlnx.xilinx.com;PTR:unknown-80-198.xilinx.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(83380400001)(7696005)(426003)(36756003)(2906002)(316002)(26005)(336012)(54906003)(6916009)(2616005)(186003)(1076003)(356005)(107886003)(36860700001)(7636003)(70206006)(47076005)(5660300002)(8676002)(82310400004)(4326008)(8936002)(9786002)(508600001)(70586007)(6666004)(102446001);DIR:OUT;SFP:1101;
X-OriginatorOrg: xilinx.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2022 17:30:23.4261
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 0f04e706-26ab-4a20-21be-08d9e671b1a9
X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.80.198];Helo=[xir-pvapexch01.xlnx.xilinx.com]
X-MS-Exchange-CrossTenant-AuthSource:
	BN1NAM02FT016.eop-nam02.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR02MB6047

At the moment, Xen does not decode any of the arm64 instructions. This
means that hsr_dabt.isv = 0, Xen cannot handle those instructions. This
will lead to Xen abort the guests (from which those instructions
originated).

With this patch, Xen is able to decode ldr/str post indexing instructions.
These are a subset of instructions for which hsr_dabt.isv = 0

The following instructions are now supported by Xen :-
1.      ldr     x2,    [x1],    #8
2.      ldr     w2,    [x1],    #-4
3.      ldr     x2,    [x1],    #-8
4.      ldr     w2,    [x1],    #4
5.      ldrh    w2,    [x1],    #2
6.      ldrb    w2,    [x1],    #1
7.      str     x2,    [x1],    #8
8.      str     w2,    [x1],    #-4
9.      strh    w2,    [x1],    #2
10.     strb    w2,    [x1],    #1

In the subsequent patches, decode_arm64() will get invoked when
hsr_dabt.isv=0.

Signed-off-by: Ayan Kumar Halder <ayankuma@xilinx.com>
---

Changelog :-

v2..v5 - Mentioned in the cover letter.

v6 - 1. Fixed the code style issues as mentioned in v5.


 xen/arch/arm/decode.c           | 80 ++++++++++++++++++++++++++++++++-
 xen/arch/arm/decode.h           | 49 +++++++++++++++++---
 xen/arch/arm/include/asm/mmio.h |  4 ++
 xen/arch/arm/io.c               |  2 +-
 4 files changed, 125 insertions(+), 10 deletions(-)

diff --git a/xen/arch/arm/decode.c b/xen/arch/arm/decode.c
index 792c2e92a7..3f2d2a3f62 100644
--- a/xen/arch/arm/decode.c
+++ b/xen/arch/arm/decode.c
@@ -23,6 +23,7 @@
 #include <xen/types.h>
 
 #include <asm/current.h>
+#include <asm/mmio.h>
 
 #include "decode.h"
 
@@ -84,6 +85,78 @@ bad_thumb2:
     return 1;
 }
 
+static int decode_arm64(register_t pc, mmio_info_t *info)
+{
+    union instr opcode = {0};
+    struct hsr_dabt *dabt = &info->dabt;
+    struct instr_details *dabt_instr = &info->dabt_instr;
+
+    if ( raw_copy_from_guest(&opcode.value, (void * __user)pc, sizeof (opcode)) )
+    {
+        gprintk(XENLOG_ERR, "Could not copy the instruction from PC\n");
+        goto bad_loadstore;
+    }
+
+    /*
+     * Refer Arm v8 ARM DDI 0487G.b, Page - C6-1107
+     * "Shared decode for all encodings" (under ldr immediate)
+     * If n == t && n != 31, then the return value is implementation defined
+     * (can be WBSUPPRESS, UNKNOWN, UNDEFINED or NOP). Thus, we do not support
+     * this. This holds true for ldrb/ldrh immediate as well.
+     *
+     * Also refer, Page - C6-1384, the above described behaviour is same for
+     * str immediate. This holds true for strb/strh immediate as well
+     */
+    if ( (opcode.ldr_str.rn == opcode.ldr_str.rt) && (opcode.ldr_str.rn != 31) )
+    {
+        gprintk(XENLOG_ERR, "Rn should not be equal to Rt except for r31\n");
+        goto bad_loadstore;
+    }
+
+    /* First, let's check for the fixed values */
+    if ( (opcode.value & POST_INDEX_FIXED_MASK) != POST_INDEX_FIXED_VALUE )
+    {
+        gprintk(XENLOG_ERR,
+                "Decoding instruction 0x%x is not supported", opcode.value);
+        goto bad_loadstore;
+    }
+
+    if ( opcode.ldr_str.v != 0 )
+    {
+        gprintk(XENLOG_ERR,
+                "ldr/str post indexing for vector types are not supported\n");
+        goto bad_loadstore;
+    }
+
+    /* Check for STR (immediate) */
+    if ( opcode.ldr_str.opc == 0 )
+        dabt->write = 1;
+    /* Check for LDR (immediate) */
+    else if ( opcode.ldr_str.opc == 1 )
+        dabt->write = 0;
+    else
+    {
+        gprintk(XENLOG_ERR,
+                "Decoding ldr/str post indexing is not supported for this variant\n");
+        goto bad_loadstore;
+    }
+
+    gprintk(XENLOG_INFO,
+            "opcode->ldr_str.rt = 0x%x, opcode->ldr_str.size = 0x%x, opcode->ldr_str.imm9 = %d\n",
+            opcode.ldr_str.rt, opcode.ldr_str.size, opcode.ldr_str.imm9);
+
+    update_dabt(dabt, opcode.ldr_str.rt, opcode.ldr_str.size, false);
+
+    dabt_instr->rn = opcode.ldr_str.rn;
+    dabt_instr->imm9 = opcode.ldr_str.imm9;
+
+    return 0;
+
+ bad_loadstore:
+    gprintk(XENLOG_ERR, "unhandled Arm instruction 0x%x\n", opcode.value);
+    return 1;
+}
+
 static int decode_thumb(register_t pc, struct hsr_dabt *dabt)
 {
     uint16_t instr;
@@ -150,10 +223,13 @@ bad_thumb:
     return 1;
 }
 
-int decode_instruction(const struct cpu_user_regs *regs, struct hsr_dabt *dabt)
+int decode_instruction(const struct cpu_user_regs *regs, mmio_info_t *info)
 {
     if ( is_32bit_domain(current->domain) && regs->cpsr & PSR_THUMB )
-        return decode_thumb(regs->pc, dabt);
+        return decode_thumb(regs->pc, &info->dabt);
+
+    if ( !psr_mode_is_32bit(regs) )
+        return decode_arm64(regs->pc, info);
 
     /* TODO: Handle ARM instruction */
     gprintk(XENLOG_ERR, "unhandled ARM instruction\n");
diff --git a/xen/arch/arm/decode.h b/xen/arch/arm/decode.h
index 4613763bdb..fe7512a053 100644
--- a/xen/arch/arm/decode.h
+++ b/xen/arch/arm/decode.h
@@ -23,19 +23,54 @@
 #include <asm/regs.h>
 #include <asm/processor.h>
 
-/**
- * Decode an instruction from pc
- * /!\ This function is not intended to fully decode an instruction. It
- * considers that the instruction is valid.
+/*
+ * Refer to the ARMv8 ARM (DDI 0487G.b), Section C4.1.4 Loads and Stores
+ * Page 318 specifies the following bit pattern for
+ * "load/store register (immediate post-indexed)".
+ *
+ * 31 30 29  27 26 25  23   21 20              11   9         4       0
+ * ___________________________________________________________________
+ * |size|1 1 1 |V |0 0 |opc |0 |      imm9     |0 1 |  Rn     |  Rt   |
+ * |____|______|__|____|____|__|_______________|____|_________|_______|
+ */
+union instr {
+    uint32_t value;
+    struct {
+        unsigned int rt:5;     /* Rt register */
+        unsigned int rn:5;     /* Rn register */
+        unsigned int fixed1:2; /* value == 01b */
+        signed int imm9:9;            /* imm9 */
+        unsigned int fixed2:1; /* value == 0b */
+        unsigned int opc:2;    /* opc */
+        unsigned int fixed3:2; /* value == 00b */
+        unsigned int v:1;      /* vector */
+        unsigned int fixed4:3; /* value == 111b */
+        unsigned int size:2;   /* size */
+    } ldr_str;
+};
+
+#define POST_INDEX_FIXED_MASK   0x3B200C00
+#define POST_INDEX_FIXED_VALUE  0x38000400
+
+/* Decode an instruction from pc
+ * /!\ This function is intended to decode an instruction. It considers that the
+ * instruction is valid.
  *
- * This function will get:
- *  - The transfer register
+ * In case of thumb mode, this function will get:
+ *  - The transfer register (ie Rt)
  *  - Sign bit
  *  - Size
+ *
+ * In case of arm64 mode, this function will get:
+ * - The transfer register (ie Rt)
+ * - The source register (ie Rn)
+ * - Size
+ * - Immediate offset
+ * - Read or write
  */
 
 int decode_instruction(const struct cpu_user_regs *regs,
-                       struct hsr_dabt *dabt);
+                       mmio_info_t *info);
 
 #endif /* __ARCH_ARM_DECODE_H_ */
 
diff --git a/xen/arch/arm/include/asm/mmio.h b/xen/arch/arm/include/asm/mmio.h
index 7ab873cb8f..3354d9c635 100644
--- a/xen/arch/arm/include/asm/mmio.h
+++ b/xen/arch/arm/include/asm/mmio.h
@@ -29,6 +29,10 @@
 typedef struct
 {
     struct hsr_dabt dabt;
+    struct instr_details {
+        unsigned long rn:5;
+        signed int imm9:9;
+    } dabt_instr;
     paddr_t gpa;
 } mmio_info_t;
 
diff --git a/xen/arch/arm/io.c b/xen/arch/arm/io.c
index 729287e37c..a289d393f9 100644
--- a/xen/arch/arm/io.c
+++ b/xen/arch/arm/io.c
@@ -134,7 +134,7 @@ enum io_state try_handle_mmio(struct cpu_user_regs *regs,
     {
         int rc;
 
-        rc = decode_instruction(regs, &info.dabt);
+        rc = decode_instruction(regs, &info);
         if ( rc )
         {
             gprintk(XENLOG_DEBUG, "Unable to decode instruction\n");
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Wed Feb 02 17:30:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 17:30:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264369.457475 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFJSk-00067g-MA; Wed, 02 Feb 2022 17:30:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264369.457475; Wed, 02 Feb 2022 17:30:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFJSk-00067X-Ij; Wed, 02 Feb 2022 17:30:34 +0000
Received: by outflank-mailman (input) for mailman id 264369;
 Wed, 02 Feb 2022 17:30:33 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=FkQ0=SR=xilinx.com=ayankuma@srs-se1.protection.inumbo.net>)
 id 1nFJSj-0005L1-85
 for xen-devel@lists.xenproject.org; Wed, 02 Feb 2022 17:30:33 +0000
Received: from NAM12-MW2-obe.outbound.protection.outlook.com
 (mail-mw2nam12on20619.outbound.protection.outlook.com
 [2a01:111:f400:fe5a::619])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d15def38-844d-11ec-8eb8-a37418f5ba1a;
 Wed, 02 Feb 2022 18:30:31 +0100 (CET)
Received: from BN6PR17CA0019.namprd17.prod.outlook.com (2603:10b6:404:65::29)
 by MW2PR02MB3723.namprd02.prod.outlook.com (2603:10b6:907:2::32) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Wed, 2 Feb
 2022 17:30:27 +0000
Received: from BN1NAM02FT059.eop-nam02.prod.protection.outlook.com
 (2603:10b6:404:65:cafe::55) by BN6PR17CA0019.outlook.office365.com
 (2603:10b6:404:65::29) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12 via Frontend
 Transport; Wed, 2 Feb 2022 17:30:26 +0000
Received: from xir-pvapexch01.xlnx.xilinx.com (149.199.80.198) by
 BN1NAM02FT059.mail.protection.outlook.com (10.13.2.167) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.4951.12 via Frontend Transport; Wed, 2 Feb 2022 17:30:26 +0000
Received: from xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) by
 xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2176.14; Wed, 2 Feb 2022 17:30:25 +0000
Received: from smtp.xilinx.com (172.21.105.198) by
 xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server id
 15.1.2176.14 via Frontend Transport; Wed, 2 Feb 2022 17:30:25 +0000
Received: from [10.108.8.223] (port=56994 helo=xcbayankuma41x.xilinx.com)
 by smtp.xilinx.com with esmtp (Exim 4.90)
 (envelope-from <ayan.kumar.halder@xilinx.com>)
 id 1nFJSb-0004a1-40; Wed, 02 Feb 2022 17:30:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d15def38-844d-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=K/xXI7VBDuHNUcEW09Pw1ZV/ca2/buIrkWbnM/kAEGyegdmLNjEbqrZwAp+aHnpJlWI1Pp0D5HHXfLHQNuxlBm9eQ12u0a3gsUbrZZvrDT43H1E8ZcIh/4sSSPFy7fm+ybuC4Bz4T99oGXSEokIihXTwLCwO3EesdV2mfVzpWuLauLI56QQDt1qIsSsolG51HRhleXS9fr6RrLXDpMegIEmVAnOXrQfC4Gbh7Q3KCQxIIMYM2dN4hNfjZstaRL22v1R3L6KpdB9GvYfb5t3nVS1UEXCiG1uyTOdkTlbNYpjuRV7c2d0UHJMHKdvfz7vMGrbwaMIbJhuLk8LD2J0c7A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=tbCuvUCFusZf+eCXK+aysJFXbfAHB5vy5OzbqrLtyaI=;
 b=PO9UHz0QMO5H08b7doM1oo1RdfsFCRCYrk/w8LAwTnveuV5ueY5ca3Wcg89kBFB2raC0FlmFEZ70DZOXe/dh7mZqnrjMXhqX0ir/SHtrLRtFQfXtywXSImjjGZR7yGlmu8SUo0IpAHdiCM/9QlJcS89VQbMoMHXwI7n1CKD5T4eczBFPHVRI6wPwXj8vmCiTSqzRYM3fTCRGjOKtKFdDDlCCEMThwOWSxxj+jK2EgHmt9WeyvHeHG+zmEdJLXXVbU8JSFXCaFhAaxgRuiV0eYvEy7YgwA2QBKlEtM1K9/EOXnVFgDC8OQrvhFP6Hz5AD9hY5jRNGhTBe6LtMyD1JJg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 149.199.80.198) smtp.rcpttodomain=lists.xenproject.org
 smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none
 header.from=xilinx.com; dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=tbCuvUCFusZf+eCXK+aysJFXbfAHB5vy5OzbqrLtyaI=;
 b=SMxxHNGZRLH06eLu1RF9MiSdrY2tQ3XpRzYwjRNtMskpSnn6uV+gxwlOaNAdQmo1QrE3jdRJFTH2+Ubk3GU8tvjo/KOACnob9MGArRSRJ6sqzFtVlhiEetIvYnGSzq+zk/aOG5dwu5UkHpJEGOfvnSQIA76Dfjpx815ttQsirq8=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198)
 smtp.mailfrom=xilinx.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=xilinx.com;
Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates
 149.199.80.198 as permitted sender) receiver=protection.outlook.com;
 client-ip=149.199.80.198; helo=xir-pvapexch01.xlnx.xilinx.com;
From: Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>
To: <xen-devel@lists.xenproject.org>
CC: <sstabellini@kernel.org>, <stefanos@xilinx.com>, <julien@xen.org>,
	<Volodymyr_Babchuk@epam.com>, <bertrand.marquis@arm.com>, Ayan Kumar Halder
	<ayankuma@xilinx.com>
Subject: [XEN v6 3/3] xen/arm64: io: Support instructions (for which ISS is not valid) on emulated MMIO region using ioreq handler
Date: Wed, 2 Feb 2022 17:30:17 +0000
Message-ID: <20220202173017.48463-4-ayankuma@xilinx.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20220202173017.48463-1-ayankuma@xilinx.com>
References: <20220202173017.48463-1-ayankuma@xilinx.com>
MIME-Version: 1.0
Content-Type: text/plain
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9ccfdd79-e2d4-4e90-5ac6-08d9e671b360
X-MS-TrafficTypeDiagnostic: MW2PR02MB3723:EE_
X-Microsoft-Antispam-PRVS:
	<MW2PR02MB3723B59FB274AC04A6D085E0B2279@MW2PR02MB3723.namprd02.prod.outlook.com>
X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply
X-MS-Oob-TLC-OOBClassifiers: OLM:6108;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	wd1Ryo6gPBmRpXWngbYO46x8ZFXKawG6/21eIeZqz+toOQrbWs24X9o2N3nP+l1RzWIKy8llJ36y+D0V5JYZuFtelPg7pFwQSjgg2jfBCiAe5MdY661Va9w148ARP/r/I5qCweZ33uKNCXYq+H+6eun888CM5NVnEKTzB8NKbshD3pBCNBHCbYxp4C/hVbIL9rwUKhwYkDh/MDd5uGS9owyX7MeBqj2R5nXsF0JL8A3TPXQNtU0xtb5dxJoR061NgtC1i4stSzrbTHFcK1QcSpblZhVYmP723oern1Ma+o/vYYgWoLykqjTE8gAq8fBWNes1002L6Pxb+Sq0m+KO2lA/Fy16pMaFXLtsUjUfCy9o2AThKhP+qxpdnvM0v6jajsSpncvhyMHBhcPqQKWgYTLH4YTWWALspxW1DQ24JZ74ueAu98HuVpq2qJa0vPhg/1bI1EZUmBxi3aZSLUEIu2geKO/la8kRCdJLcH6+C4uHhQph4Dxe1pc3n4QZ1O+y1CTYf9WPFZSaddMEurFNByvCn96NTzAlsVxWTx4tMETTLts1LN/5z8CHR8og6tuDt7cAdE7Bs9tvYFHIa9+xPkSHXXlv2Ml/6s34yD7sNOfdFPY+O0ilSIYGkgfCxc6GwkDVtkRKzn4qZL/3ksDo2zX+Bdl+RWKP6eeVGzGMRFuVp0jQxNQncwCmJ2emWJZn9AC59hWCrBwc6N55Pyy+lg==
X-Forefront-Antispam-Report:
	CIP:149.199.80.198;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:xir-pvapexch01.xlnx.xilinx.com;PTR:unknown-80-198.xilinx.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(7636003)(82310400004)(2906002)(356005)(7696005)(6666004)(5660300002)(2616005)(9786002)(36860700001)(336012)(107886003)(47076005)(83380400001)(70586007)(70206006)(1076003)(8936002)(8676002)(54906003)(36756003)(4326008)(6916009)(426003)(186003)(316002)(26005)(30864003)(508600001)(102446001)(473944003);DIR:OUT;SFP:1101;
X-OriginatorOrg: xilinx.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2022 17:30:26.3046
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 9ccfdd79-e2d4-4e90-5ac6-08d9e671b360
X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.80.198];Helo=[xir-pvapexch01.xlnx.xilinx.com]
X-MS-Exchange-CrossTenant-AuthSource:
	BN1NAM02FT059.eop-nam02.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR02MB3723

When an instruction is trapped in Xen due to translation fault, Xen checks if
the ISS is valid. If not, Xen tries to resolve the translation fault using
p2m page tables. In case if it is a data abort, Xen will try to map the mmio
region to the guest (ie tries to emulate the mmio region).

If it is not successfull, then it tries to decode the instruction.
It saves the decoding state, rn and imm9 to ioreq. Whenever the vcpu handles
the ioreq successfully, it will read the decoding state to determine if the
instruction decoded was a ldr/str post indexing (ie INSTR_LDR_STR_POSTINDEXING).
If so, it uses these details to post increment rn.

Signed-off-by: Ayan Kumar Halder <ayankuma@xilinx.com>
---

Changelog :-

v2..v5 - Provided in cover letter.

v6 - 1. Introduced a new field('enum instr_decode_state state') inside
'struct instr_details'. This holds the decoding state of the instruction.
This is later read by the post_increment_register() to determine if rn needs to
be incremented. Also, this is read by the callers of try_decode_instruction()
to determine if the instruction was valid or ignored or to be retried or
error or decoded successfully.

2. Also stored 'instr_details' inside 'struct ioreq'. This enables
arch_ioreq_complete_mmio() to invoke post_increment_register() without decoding
the instruction again.

3. Check hsr.dabt.valid in do_trap_stage2_abort_guest(). If it is not valid,
then decode the instruction. This ensures that try_handle_mmio() is invoked only
when the instruction is either valid or decoded successfully.

4. Inside do_trap_stage2_abort_guest(), if hsr.dabt.valid is not set, then
resolve the translation fault before trying to decode the instruction. If
translation fault is resolved, then return to the guest to execute the instruction
again.

 xen/arch/arm/arm64/traps.c      |  4 +++
 xen/arch/arm/decode.c           |  1 +
 xen/arch/arm/decode.h           |  9 ------
 xen/arch/arm/include/asm/mmio.h | 13 ++++++++
 xen/arch/arm/io.c               | 56 ++++++++++-----------------------
 xen/arch/arm/ioreq.c            | 13 +++++---
 xen/arch/arm/traps.c            | 56 +++++++++++++++++++++++++++++++--
 xen/include/public/hvm/ioreq.h  | 19 +++++------
 8 files changed, 108 insertions(+), 63 deletions(-)

diff --git a/xen/arch/arm/arm64/traps.c b/xen/arch/arm/arm64/traps.c
index 4de2206801..505a843b07 100644
--- a/xen/arch/arm/arm64/traps.c
+++ b/xen/arch/arm/arm64/traps.c
@@ -52,6 +52,10 @@ void post_increment_register(const struct instr_details *instr)
     struct cpu_user_regs *regs = guest_cpu_user_regs();
     register_t val;
 
+    /* Currently, we handle only ldr/str post indexing instructions */
+    if ( instr->state != INSTR_LDR_STR_POSTINDEXING )
+        return;
+
     /*
      * Handle when rn = SP
      * Refer ArmV8 ARM DDI 0487G.b, Page - D1-2463 "Stack pointer register selection"
diff --git a/xen/arch/arm/decode.c b/xen/arch/arm/decode.c
index 3f2d2a3f62..0a4d9d2772 100644
--- a/xen/arch/arm/decode.c
+++ b/xen/arch/arm/decode.c
@@ -147,6 +147,7 @@ static int decode_arm64(register_t pc, mmio_info_t *info)
 
     update_dabt(dabt, opcode.ldr_str.rt, opcode.ldr_str.size, false);
 
+    dabt_instr->state = INSTR_LDR_STR_POSTINDEXING;
     dabt_instr->rn = opcode.ldr_str.rn;
     dabt_instr->imm9 = opcode.ldr_str.imm9;
 
diff --git a/xen/arch/arm/decode.h b/xen/arch/arm/decode.h
index 5efd72405e..6a09b07b46 100644
--- a/xen/arch/arm/decode.h
+++ b/xen/arch/arm/decode.h
@@ -52,15 +52,6 @@ union instr {
 #define POST_INDEX_FIXED_MASK   0x3B200C00
 #define POST_INDEX_FIXED_VALUE  0x38000400
 
-enum instr_decode_state
-{
-    INSTR_ERROR, /* Error encountered while decoding the instruction */
-    INSTR_VALID, /* ISS is valid, so there is no need to decode */
-    INSTR_SUCCESS, /* Instruction is decoded successfully */
-    INSTR_IGNORE, /* Instruction is to be ignored (similar to NOP) */
-    INSTR_RETRY /* Instruction is to be retried */
-};
-
 /*
  * Decode an instruction from pc
  * /!\ This function is intended to decode an instruction. It considers that the
diff --git a/xen/arch/arm/include/asm/mmio.h b/xen/arch/arm/include/asm/mmio.h
index 3354d9c635..f7cdf66a5b 100644
--- a/xen/arch/arm/include/asm/mmio.h
+++ b/xen/arch/arm/include/asm/mmio.h
@@ -26,12 +26,23 @@
 
 #define MAX_IO_HANDLER  16
 
+enum instr_decode_state
+{
+    INSTR_ERROR,                    /* Error encountered while decoding the instruction */
+    INSTR_VALID,                    /* ISS is valid, so there is no need to decode */
+    INSTR_LDR_STR_POSTINDEXING,     /* Instruction is decoded successfully.
+                                       It is ldr/str post indexing */
+    INSTR_IGNORE,                   /* Instruction is to be ignored (similar to NOP) */
+    INSTR_RETRY                     /* Instruction is to be retried */
+};
+
 typedef struct
 {
     struct hsr_dabt dabt;
     struct instr_details {
         unsigned long rn:5;
         signed int imm9:9;
+        enum instr_decode_state state;
     } dabt_instr;
     paddr_t gpa;
 } mmio_info_t;
@@ -77,6 +88,8 @@ void register_mmio_handler(struct domain *d,
 int domain_io_init(struct domain *d, int max_count);
 void domain_io_free(struct domain *d);
 
+void try_decode_instruction(const struct cpu_user_regs *regs,
+                            mmio_info_t *info);
 
 #endif  /* __ASM_ARM_MMIO_H__ */
 
diff --git a/xen/arch/arm/io.c b/xen/arch/arm/io.c
index 1011327058..46726637c6 100644
--- a/xen/arch/arm/io.c
+++ b/xen/arch/arm/io.c
@@ -95,8 +95,8 @@ static const struct mmio_handler *find_mmio_handler(struct domain *d,
     return handler;
 }
 
-enum instr_decode_state try_decode_instruction(const struct cpu_user_regs *regs,
-                                               mmio_info_t *info)
+void try_decode_instruction(const struct cpu_user_regs *regs,
+                            mmio_info_t *info)
 {
     int rc;
 
@@ -111,27 +111,37 @@ enum instr_decode_state try_decode_instruction(const struct cpu_user_regs *regs,
         if ( rc )
         {
             gprintk(XENLOG_DEBUG, "Unable to decode instruction\n");
-            return INSTR_ERROR;
+            info->dabt_instr.state = INSTR_ERROR;
+            return;
         }
     }
 
     /* If ISS is valid, then no need to decode the instruction any further */
     if (info->dabt.valid)
-        return INSTR_VALID;
+    {
+        info->dabt_instr.state = INSTR_VALID;
+        return;
+    }
 
     /*
      * Xen should not decode the instruction when it was trapped due to
      * translation fault.
      */
     if ( info->dabt.s1ptw )
-        return INSTR_RETRY;
+    {
+        info->dabt_instr.state = INSTR_RETRY;
+        return;
+    }
 
     /*
      * If the fault occurred due to cache maintenance or address translation
      * instructions, then Xen needs to ignore these instructions.
      */
     if ( info->dabt.cache )
-        return INSTR_IGNORE;
+    {
+        info->dabt_instr.state = INSTR_IGNORE;
+        return;
+    }
 
     /*
      * Armv8 processor does not provide a valid syndrome for decoding some
@@ -142,10 +152,8 @@ enum instr_decode_state try_decode_instruction(const struct cpu_user_regs *regs,
     if ( rc )
     {
         gprintk(XENLOG_ERR, "Unable to decode instruction\n");
-        return INSTR_ERROR;
+        info->dabt_instr.state = INSTR_ERROR;
     }
-    else
-        return INSTR_SUCCESS;
 }
 
 enum io_state try_handle_mmio(struct cpu_user_regs *regs,
@@ -160,7 +168,6 @@ enum io_state try_handle_mmio(struct cpu_user_regs *regs,
         .dabt = dabt
     };
     int rc;
-    enum instr_decode_state state;
 
     ASSERT(hsr.ec == HSR_EC_DATA_ABORT_LOWER_EL);
 
@@ -174,25 +181,6 @@ enum io_state try_handle_mmio(struct cpu_user_regs *regs,
         return rc;
     }
 
-    state = try_decode_instruction(regs, &info);
-
-    /*
-     * If the instruction was to be ignored by Xen, then it should return to the
-     * caller which will increment the PC, so that the guest can execute the
-     * next instruction.
-     */
-    if ( state == INSTR_IGNORE )
-        return IO_HANDLED;
-    /*
-     * If Xen could not decode the instruction for any reason, then it should
-     * ask the caller to abort the guest.
-     */
-    else if ( state == INSTR_ERROR )
-        return IO_ABORT;
-    /* When the instruction needs to be retried by the guest */
-    else if ( state == INSTR_RETRY )
-        return IO_UNHANDLED;
-
     /*
      * At this point, we know that the instruction is either valid or has been
      * decoded successfully. Thus, Xen should be allowed to execute the
@@ -203,16 +191,6 @@ enum io_state try_handle_mmio(struct cpu_user_regs *regs,
     else
         rc = handle_read(handler, v, &info);
 
-    /*
-     * If the instruction was decoded and has executed successfully on the MMIO
-     * region, then Xen should execute the next part of the instruction. (for eg
-     * increment the rn if it is a post-indexing instruction.
-     */
-    if ( (rc == IO_HANDLED) && (state == INSTR_SUCCESS) )
-    {
-        post_increment_register(&info.dabt_instr);
-    }
-
     return rc;
 }
 
diff --git a/xen/arch/arm/ioreq.c b/xen/arch/arm/ioreq.c
index 308650b400..d8909aa903 100644
--- a/xen/arch/arm/ioreq.c
+++ b/xen/arch/arm/ioreq.c
@@ -23,10 +23,13 @@
 
 #include <public/hvm/ioreq.h>
 
+#include "decode.h"
+
 enum io_state handle_ioserv(struct cpu_user_regs *regs, struct vcpu *v)
 {
     const union hsr hsr = { .bits = regs->hsr };
-    const struct hsr_dabt dabt = hsr.dabt;
+    struct hsr_dabt dabt = hsr.dabt;
+
     /* Code is similar to handle_read */
     register_t r = v->io.req.data;
 
@@ -61,10 +64,13 @@ enum io_state try_fwd_ioserv(struct cpu_user_regs *regs,
          */
         .df = 0,
         .data = get_user_reg(regs, info->dabt.reg),
+        .dabt_instr = &info->dabt_instr,
         .state = STATE_IOREQ_READY,
     };
     struct ioreq_server *s = NULL;
     enum io_state rc;
+    bool instr_decoded = false;
+    const union hsr hsr = { .bits = regs->hsr };
 
     if ( vio->req.state != STATE_IOREQ_NONE )
     {
@@ -76,9 +82,6 @@ enum io_state try_fwd_ioserv(struct cpu_user_regs *regs,
     if ( !s )
         return IO_UNHANDLED;
 
-    if ( !info->dabt.valid )
-        return IO_ABORT;
-
     vio->req = p;
 
     rc = ioreq_send(s, &p, 0);
@@ -95,6 +98,7 @@ enum io_state try_fwd_ioserv(struct cpu_user_regs *regs,
 bool arch_ioreq_complete_mmio(void)
 {
     struct vcpu *v = current;
+    struct instr_details *dabt_instr = v->io.req.dabt_instr;
     struct cpu_user_regs *regs = guest_cpu_user_regs();
     const union hsr hsr = { .bits = regs->hsr };
 
@@ -106,6 +110,7 @@ bool arch_ioreq_complete_mmio(void)
 
     if ( handle_ioserv(regs, v) == IO_HANDLED )
     {
+        post_increment_register(dabt_instr);
         advance_pc(regs, hsr);
         return true;
     }
diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c
index 9339d12f58..6cce2379fa 100644
--- a/xen/arch/arm/traps.c
+++ b/xen/arch/arm/traps.c
@@ -1906,6 +1906,7 @@ static void do_trap_stage2_abort_guest(struct cpu_user_regs *regs,
     paddr_t gpa;
     uint8_t fsc = xabt.fsc & ~FSC_LL_MASK;
     bool is_data = (hsr.ec == HSR_EC_DATA_ABORT_LOWER_EL);
+    mmio_info_t info;
 
     /*
      * If this bit has been set, it means that this stage-2 abort is caused
@@ -1959,6 +1960,51 @@ static void do_trap_stage2_abort_guest(struct cpu_user_regs *regs,
         return;
     }
     case FSC_FLT_TRANS:
+
+        info.gpa = gpa;
+        info.dabt = hsr.dabt;
+
+        /* Check if the ISS is valid. */
+        if ( !hsr.dabt.valid )
+        {
+
+            /*
+             * Assumption :- Most of the times when we get a translation fault
+             * and the ISS is invalid, the underlying cause is that the page
+             * tables have not been set up correctly.
+             * First check if the translation fault can be resolved by the
+             * P2M subsystem. If that's the case nothing else to do.
+             */
+            if ( p2m_resolve_translation_fault(current->domain,
+                                           gaddr_to_gfn(gpa)) )
+                return;
+
+            if ( is_data && try_map_mmio(gaddr_to_gfn(gpa)) )
+                return;
+
+            try_decode_instruction(regs, &info);
+
+            /*
+             * If the instruction was to be ignored by Xen, then it should return to the
+             * caller which will increment the PC, so that the guest can execute the
+             * next instruction.
+             */
+            if ( info.dabt_instr.state == INSTR_IGNORE )
+            {
+                advance_pc(regs, hsr);
+                return;
+            }
+            /*
+             * If Xen could not decode the instruction for any reason, then it should
+             * ask the caller to abort the guest.
+             */
+            else if ( info.dabt_instr.state == INSTR_ERROR )
+                goto inject_abt;
+            /* When the instruction needs to be retried by the guest */
+            else if ( info.dabt_instr.state == INSTR_RETRY )
+                return;
+        }
+
         /*
          * Attempt first to emulate the MMIO as the data abort will
          * likely happen in an emulated region.
@@ -1975,6 +2021,13 @@ static void do_trap_stage2_abort_guest(struct cpu_user_regs *regs,
                 goto inject_abt;
             case IO_HANDLED:
                 advance_pc(regs, hsr);
+                /*
+                 * If the instruction was decoded and has executed successfully
+                 * on the MMIO region, then Xen should execute the next part of
+                 * the instruction. (for eg increment the rn if it is a
+                 * post-indexing instruction.
+                 */
+                post_increment_register(&info.dabt_instr);
                 return;
             case IO_RETRY:
                 /* finish later */
@@ -1985,8 +2038,7 @@ static void do_trap_stage2_abort_guest(struct cpu_user_regs *regs,
             }
         }
 
-        /*
-         * First check if the translation fault can be resolved by the
+        /* First check if the translation fault can be resolved by the
          * P2M subsystem. If that's the case nothing else to do.
          */
         if ( p2m_resolve_translation_fault(current->domain,
diff --git a/xen/include/public/hvm/ioreq.h b/xen/include/public/hvm/ioreq.h
index c511fae8e7..e4183960d8 100644
--- a/xen/include/public/hvm/ioreq.h
+++ b/xen/include/public/hvm/ioreq.h
@@ -50,19 +50,20 @@
  * SEGMENT |BUS   |DEV   |FN    |OFFSET
  */
 struct ioreq {
-    uint64_t addr;          /* physical address */
-    uint64_t data;          /* data (or paddr of data) */
-    uint32_t count;         /* for rep prefixes */
-    uint32_t size;          /* size in bytes */
-    uint32_t vp_eport;      /* evtchn for notifications to/from device model */
+    uint64_t addr;                   /* physical address */
+    uint64_t data;                   /* data (or paddr of data) */
+    uint32_t count;                  /* for rep prefixes */
+    uint32_t size;                   /* size in bytes */
+    uint32_t vp_eport;               /* evtchn for notifications to/from device model */
     uint16_t _pad0;
     uint8_t state:4;
-    uint8_t data_is_ptr:1;  /* if 1, data above is the guest paddr
-                             * of the real data to use. */
-    uint8_t dir:1;          /* 1=read, 0=write */
+    uint8_t data_is_ptr:1;           /* if 1, data above is the guest paddr
+                                      * of the real data to use. */
+    uint8_t dir:1;                   /* 1=read, 0=write */
     uint8_t df:1;
     uint8_t _pad1:1;
-    uint8_t type;           /* I/O type */
+    uint8_t type;                     /* I/O type */
+    struct instr_details *dabt_instr; /* when the instruction is decoded */
 };
 typedef struct ioreq ioreq_t;
 
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Wed Feb 02 17:30:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 17:30:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264366.457442 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFJSg-0005LJ-Lo; Wed, 02 Feb 2022 17:30:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264366.457442; Wed, 02 Feb 2022 17:30:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFJSg-0005LC-Is; Wed, 02 Feb 2022 17:30:30 +0000
Received: by outflank-mailman (input) for mailman id 264366;
 Wed, 02 Feb 2022 17:30:29 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=FkQ0=SR=xilinx.com=ayankuma@srs-se1.protection.inumbo.net>)
 id 1nFJSf-0005L1-6i
 for xen-devel@lists.xenproject.org; Wed, 02 Feb 2022 17:30:29 +0000
Received: from NAM12-DM6-obe.outbound.protection.outlook.com
 (mail-dm6nam12on20630.outbound.protection.outlook.com
 [2a01:111:f400:fe59::630])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ce5826b9-844d-11ec-8eb8-a37418f5ba1a;
 Wed, 02 Feb 2022 18:30:26 +0100 (CET)
Received: from BN6PR1401CA0010.namprd14.prod.outlook.com
 (2603:10b6:405:4b::20) by CH2PR02MB6168.namprd02.prod.outlook.com
 (2603:10b6:610:a::18) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.17; Wed, 2 Feb
 2022 17:30:22 +0000
Received: from BN1NAM02FT016.eop-nam02.prod.protection.outlook.com
 (2603:10b6:405:4b:cafe::4e) by BN6PR1401CA0010.outlook.office365.com
 (2603:10b6:405:4b::20) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12 via Frontend
 Transport; Wed, 2 Feb 2022 17:30:22 +0000
Received: from xir-pvapexch01.xlnx.xilinx.com (149.199.80.198) by
 BN1NAM02FT016.mail.protection.outlook.com (10.13.2.133) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.4951.12 via Frontend Transport; Wed, 2 Feb 2022 17:30:22 +0000
Received: from xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) by
 xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2176.14; Wed, 2 Feb 2022 17:30:21 +0000
Received: from smtp.xilinx.com (172.21.105.198) by
 xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server id
 15.1.2176.14 via Frontend Transport; Wed, 2 Feb 2022 17:30:21 +0000
Received: from [10.108.8.223] (port=56994 helo=xcbayankuma41x.xilinx.com)
 by smtp.xilinx.com with esmtp (Exim 4.90)
 (envelope-from <ayan.kumar.halder@xilinx.com>)
 id 1nFJSW-0004a1-1X; Wed, 02 Feb 2022 17:30:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ce5826b9-844d-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jv0yguxRbqIapmtJ/KoNIJKOIeAe1kAR0e6J5Nm5q6Id2uE/Dj9zAQFSoUn6kPcv1VICczaX4TIGl+8gwnuCKdstUXQVsAB/SezFhlNfk1uBPgztdWXDjmrrEzOjyrs71vGMI/Ft6QHb31fvlJGr3UUN7oYgoS8H3X51KR+4VIUtNPI9f9j4i5XRA5szvXWxNJb2xLnP8h3fcJhq/sqxujlwFWEx0m1auRtHQPpQcuHh1N5yhp9K/n5u6yWiw/h5ZnVV3Hy7QxWxUAKuT6h9P/hlAVXoAkosZ3XxZDIonKjuDS6vs9CVSSIYPff637gJI83Yhj2+Ei2uaMx8NAnVfg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=q0l0VgEygkT2jSFeBt8xFaCn5y1Wf34uWHniJq3qmLA=;
 b=RWUtMhtsO0NFtDhHxxcp1wi0BfL9iu8U2QutfdcupTUGq5XRQrWS1ZGoZQDDW+STnh9yI59Eez4WnOdcQU/O9tSBYpp2ZudK2w+3/yPVWjN/mmmdj+5Uullu2AKdtwfrVTi4bFXpAYz2pyp8/vXXW2EkcJlLnlotBkUqNalMgFqCNRWyXcoIsQFzU6x9h1+VCfixvLl3tMvBQPO2H63iH/XsVsetzDKURPv0ZGvZLR+00vfXSPwGbjvD3jB0l68vryCh/sT+dT92yHm/E+1zre9HNjEprZTjfDOkagSz2IAh1eKeIHGUaot7zMFRu9/aCI2p2EETAtZDja+H2fAT1w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 149.199.80.198) smtp.rcpttodomain=lists.xenproject.org
 smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none
 header.from=xilinx.com; dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=q0l0VgEygkT2jSFeBt8xFaCn5y1Wf34uWHniJq3qmLA=;
 b=C0Ky1AEdkgRFHlJ4CF/D4kbxyLopQkaC/2q91SW5iz0BJpBbW3+Iv2I5I3wW7VCU4E08dpgXUl/Ff88vv70ck6cROgOWUk1cn2+tcBonnCFFZM/RYR3gfihI/e0hEZEPNAkSI5X5XG6sopkp7jHNRsNBmU422ExH2PtvFQmy8hs=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198)
 smtp.mailfrom=xilinx.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=xilinx.com;
Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates
 149.199.80.198 as permitted sender) receiver=protection.outlook.com;
 client-ip=149.199.80.198; helo=xir-pvapexch01.xlnx.xilinx.com;
From: Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>
To: <xen-devel@lists.xenproject.org>
CC: <sstabellini@kernel.org>, <stefanos@xilinx.com>, <julien@xen.org>,
	<Volodymyr_Babchuk@epam.com>, <bertrand.marquis@arm.com>, Ayan Kumar Halder
	<ayankuma@xilinx.com>
Subject: [XEN v6 0/3] xen/arm64: io: Decode ldr/str post-indexing instruction
Date: Wed, 2 Feb 2022 17:30:14 +0000
Message-ID: <20220202173017.48463-1-ayankuma@xilinx.com>
X-Mailer: git-send-email 2.17.1
MIME-Version: 1.0
Content-Type: text/plain
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 414c7be7-6b18-42a2-5498-08d9e671b0f6
X-MS-TrafficTypeDiagnostic: CH2PR02MB6168:EE_
X-Microsoft-Antispam-PRVS:
	<CH2PR02MB6168F3E64A7F6C7B9630165BB2279@CH2PR02MB6168.namprd02.prod.outlook.com>
X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply
X-MS-Oob-TLC-OOBClassifiers: OLM:5516;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Gwz0cKObIpaSIZFN1eCEo/AjZUJGIr+77ZTunuOzKEfDd35AcuXN3cZV91f1Z5/5zIPJMz3OgfbczYxXsDkvFw67Nwi6AhRmEB8cexVrsn9PenjX11Ftcl7z9wHeslSa03hFWjkdqEvMH60651DuEoFMW3754AcDZ/6RXWxudLL0++DxAJAsnsEMSbdoSzsH7b0zc4LzHRPaDeVuwYbF9YD9FAyysdeJGI9zDH5D680spKt4iUPEOFYAl+4aYqTWFQhl3wyOyGuB8helqNbMdNl+ieQ0AJQZ+ZjYPQDkGPwu7BNoT+U3a5skYaZqKhWGLF7lZBIcuCwBjDJf4bcjw9iBO1sZ09NoKvq29i3xeXJYzhmWP2/5/tg7qNTtFlMrplSy6tjt4mXeidFy6N6cCBTfC+/ovZ5y1s0Y8vciNs281y5AsIHuv7AKcez7TZEfhgjl2OjFcVR1bM37DJ0qv4AGhgU7Vah9mLc5uTH+a2NezaBCtjYG1BXUdZsHdfIzd//Q23d1132SIjT7GScGkrgYqh7lImpQ55o5EGLr8+4JuIWdiLntvhXHwXk+6Hf0D1Cd5JnjTPmiobB7mArqHBzBhg4J5PG6PIhYpAPwXXvkTlm/se4Oe9h3KHLG6AztR2BgwhCZNtNVQbv2X4drpp1ftIlcYJjLJueOfq0AS1FgCopxRVQMNGP+Kg6Q6SXrLG3bs/ohOPDWcbkHd3H3cw==
X-Forefront-Antispam-Report:
	CIP:149.199.80.198;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:xir-pvapexch01.xlnx.xilinx.com;PTR:unknown-80-198.xilinx.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(6666004)(1076003)(26005)(2906002)(2616005)(8676002)(70586007)(8936002)(4326008)(5660300002)(186003)(82310400004)(7696005)(9786002)(107886003)(70206006)(36860700001)(47076005)(426003)(83380400001)(336012)(7636003)(508600001)(356005)(6916009)(316002)(36756003)(54906003)(102446001)(473944003);DIR:OUT;SFP:1101;
X-OriginatorOrg: xilinx.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2022 17:30:22.2543
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 414c7be7-6b18-42a2-5498-08d9e671b0f6
X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.80.198];Helo=[xir-pvapexch01.xlnx.xilinx.com]
X-MS-Exchange-CrossTenant-AuthSource:
	BN1NAM02FT016.eop-nam02.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR02MB6168

Hi All,

I have split "[XEN v5] xen/arm64: io: Decode ldr/str post-indexing instructions"
into the following three patches :-

Ayan Kumar Halder (3):
  xen/arm64: Decode ldr/str post increment operations
  xen/arm64: io: Support instructions (for which ISS is not valid) on
    emulated MMIO region using MMIO handler
  xen/arm64: io: Support instructions (for which ISS is not valid) on
    emulated MMIO region using ioreq handler

The third patch introduces quite a bit of complexity. So, I decided to keep
it separate to ease the review and help me to understand better.

I haven't tested the patches. I am sending it out to get a feedback to see
if it is going in the correct direction.

 xen/arch/arm/arm32/traps.c       |  6 +++
 xen/arch/arm/arm64/traps.c       | 45 ++++++++++++++++
 xen/arch/arm/decode.c            | 81 +++++++++++++++++++++++++++-
 xen/arch/arm/decode.h            | 48 ++++++++++++++---
 xen/arch/arm/include/asm/mmio.h  | 17 ++++++
 xen/arch/arm/include/asm/traps.h |  2 +
 xen/arch/arm/io.c                | 92 ++++++++++++++++++++++++--------
 xen/arch/arm/ioreq.c             | 13 +++--
 xen/arch/arm/traps.c             | 56 ++++++++++++++++++-
 xen/include/public/hvm/ioreq.h   | 19 +++----
 10 files changed, 333 insertions(+), 46 deletions(-)

Changelog :-
v2 - 1. Updated the rn register after reading from it. (Pointed by Julien,
        Stefano)
     2. Used a union to represent the instruction opcode (Suggestd by Bertrand)
     3. Fixed coding style issues (Pointed by Julien)
     4. In the previous patch, I was updating dabt->sign based on the signedness
        of imm9. This was incorrect. As mentioned in ARMv8 ARM  DDI 0487G.b,
        Page 3221, SSE indicates the signedness of the data item loaded. In our
        case, the data item loaded is always unsigned.

v3- 1. Handled all the variants of ldr/str (ie 64, 32, 16, 8 bit variants).
       Thus, I have removed the check for "instr->code.opc == 0" (Suggested by
       Andre)
    2. Handled the scenario when rn = SP, rt = XZR (Suggested by Jan, Andre)
    3. Added restriction for "rt != rn" (Suggested by Andre)
    4. Moved union ldr_str_instr_class {} to decode.h. This is the header included
       by io.c and decode.c (where the union is referred). (Suggested by Jan)
    5. Indentation and typo fixes (Suggested by Jan)

v4- 1. Fixed the patch as per Stefano's comments on v3. They are as follows :-
        1.1 Use macros to determine the fixed values in the instruction opcode
        1.2 Checked if instr != NULL
        1.3 Changed some data types and added #define ARM_64 for AArch64 specific
            code
        1.4 Moved post_increment_register() to decode.c so that the decoding
            logic is confined to a single file.
        1.5 Moved some checks from post_increment_register() to
            decode_loadstore_postindexing()
        1.6 Removed a duplicate check
    2. Updated the commit message as per Andre's comments.
    3. Changed the names of a label and some comments. *32bit* was erroneously
       mentioned in a label and comments in decode_loadstore_postindexing()
       although the function handled all variants of ldr/str post indexing.

v5- 1. Renamed decode_loadstore_postindexing() to decode_arm64(). The reason
       being this will be extended in future to support more instructions for
       which hsr_badt.isv = 0
    2. Introduce a function try_decode_instruction_invalid_iss() to determine
       if the instruction needs to be decoded before invoking decode_instruction().

       It checks :-
       2.1  dabt->s1ptw - Returns IO_UNHANDLED
       2.2  dabt->cache - Returns IO_IGNORED. (new enum instroduced to let the
            caller know that the instruction needs to be ignored by Xen. Thus
            the caller needs to increment the PC and return to the guest.

    3. Invoked try_decode_instruction_invalid_iss() from the following 2 places :-
        3.a - try_handle_mmio() - When we have determined that there is a valid
              mmio handler.
        3.b - try_fwd_ioserv()
        When ioserver completes the io request, the acknowledgement is sent via
        handle_ioserv(). Here, we need to increment the register. As there is no
        common data shared between try_fwd_ioserv() and handle_ioserv(), we need
        to decode the instruction again in handle_ioserv() to determine rn, imm9.

        (NOTE to Reviewers) - This does not feel correct. However, I could not
        think of a better approach. Please provide your inputs.

    4. Augumented struct hsr_dabt{} with struct hsr_dabt_instr_details{} to hold
       rn and imm9. This is passed to post_increment_register() to update rn.
    5. Other style changes as suggested in v4.

v6 - 1. Split the patch into three parts.
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Wed Feb 02 17:38:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 17:38:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264396.457486 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFJZw-0007vf-G4; Wed, 02 Feb 2022 17:38:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264396.457486; Wed, 02 Feb 2022 17:38:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFJZw-0007vY-Cu; Wed, 02 Feb 2022 17:38:00 +0000
Received: by outflank-mailman (input) for mailman id 264396;
 Wed, 02 Feb 2022 17:37:59 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=FkQ0=SR=xilinx.com=ayankuma@srs-se1.protection.inumbo.net>)
 id 1nFJZv-0007vS-G0
 for xen-devel@lists.xenproject.org; Wed, 02 Feb 2022 17:37:59 +0000
Received: from NAM10-MW2-obe.outbound.protection.outlook.com
 (mail-mw2nam10on20611.outbound.protection.outlook.com
 [2a01:111:f400:7e89::611])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id db7de41e-844e-11ec-8f75-fffcc8bd4f1a;
 Wed, 02 Feb 2022 18:37:58 +0100 (CET)
Received: from BN6PR18CA0003.namprd18.prod.outlook.com (2603:10b6:404:121::13)
 by MWHPR02MB3262.namprd02.prod.outlook.com (2603:10b6:301:66::33)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.20; Wed, 2 Feb
 2022 17:37:54 +0000
Received: from BN1NAM02FT053.eop-nam02.prod.protection.outlook.com
 (2603:10b6:404:121:cafe::5f) by BN6PR18CA0003.outlook.office365.com
 (2603:10b6:404:121::13) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12 via Frontend
 Transport; Wed, 2 Feb 2022 17:37:53 +0000
Received: from xir-pvapexch01.xlnx.xilinx.com (149.199.80.198) by
 BN1NAM02FT053.mail.protection.outlook.com (10.13.2.161) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.4951.12 via Frontend Transport; Wed, 2 Feb 2022 17:37:53 +0000
Received: from xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) by
 xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2176.14; Wed, 2 Feb 2022 17:37:51 +0000
Received: from smtp.xilinx.com (172.21.105.198) by
 xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server id
 15.1.2176.14 via Frontend Transport; Wed, 2 Feb 2022 17:37:51 +0000
Received: from [10.71.116.197] (port=62189)
 by smtp.xilinx.com with esmtp (Exim 4.90)
 (envelope-from <ayan.kumar.halder@xilinx.com>)
 id 1nFJZn-0004jd-1M; Wed, 02 Feb 2022 17:37:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: db7de41e-844e-11ec-8f75-fffcc8bd4f1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=A3lnTgVlhKDuKDtLqOVMNhMzCegZaSqazPoGDlbqzE/i/0rCdG7NufNn/M6nUpCqdMosFOD/JWdhCSAD6zCc5a/YvlV1DEit6Rmiv+2KMjxSgoEy0vHbAtM50TgWBB8LKqF62jISZxfD9B5yfvLxr1xT7PMY+VqtXB0kbmxLU8RUwZtiJViU8HSImURcAWGKI06VNj20BM2vLJ8/Mw/3vtLirYHfiG0WZK2fhj8pbOUyVc7fC9ddbAEaG2IuT5wAV6kpsw6KEQnkX6NttFT5o6vNTGPpyxQqmqsIlUZRG41Btt+rrTQab/RuImySNpDUlX4azbgghN4TcAoYjBtKJA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=uR6Dld2R5zdgQ6q7r/fIFkr6ym1F5HYIxbrTSkx++dU=;
 b=kkxuFAkZbQPquZ0QAklFj6ijZyChyc+LXi3F5S0FRmg/bNEAr858O8Yk8M7Vd/ai72uwkjRJWsKbarRhYNYMsvO3Dp2FTOIgyA5nfKzdJPhKYgnKN0grcX8X/MG7r4XSO7wdpzDSVdnfSaEvtI/c9EyXufofKX+BCrmjvb478dRVrZXo+AOl1ORutvqPjW4ptJ0sxHADHdiTxAuRu/G1vCIk1q5f8EEengu4zQUAAX4aB+o293LC+hKUIVYJe9TXP3ssjEqNUpb2+VWrmsKiXH/Up279jrPmUfmW1HabuUs3geFE7ZGcsE2cE+LPKhDkJjIWUzMGYoE7mBtjd2ItBg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 149.199.80.198) smtp.rcpttodomain=xen.org smtp.mailfrom=xilinx.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=uR6Dld2R5zdgQ6q7r/fIFkr6ym1F5HYIxbrTSkx++dU=;
 b=pKyB+nA5QwJfyY4B8H59PihnH8L8aluOg3+T24y9GlC9K0IgO7ujd+WsqCToh4Dwio0EWlu985PFGdwanJ2EvheUiUx9ZPJDDdH+leoNNdzsm7z1pdVvvmzBobXfRS1xs/yuEoz/xJu422Oo9wOYRTdbWNDluCJBpb2zibd9p1M=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198)
 smtp.mailfrom=xilinx.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=xilinx.com;
Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates
 149.199.80.198 as permitted sender) receiver=protection.outlook.com;
 client-ip=149.199.80.198; helo=xir-pvapexch01.xlnx.xilinx.com;
Message-ID: <409713cc-10e0-728f-0498-116292faa8b7@xilinx.com>
Date: Wed, 2 Feb 2022 17:37:50 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.1
Subject: Re: [XEN v5] xen/arm64: io: Decode ldr/str post-indexing instructions
To: Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>, Julien Grall
	<julien@xen.org>, <xen-devel@lists.xenproject.org>
CC: <sstabellini@kernel.org>, <stefanos@xilinx.com>,
	<Volodymyr_Babchuk@epam.com>, <bertrand.marquis@arm.com>
References: <20220131193728.2980-1-ayankuma@xilinx.com>
 <e07068aa-91b8-ebdf-db17-7173f417ad33@xen.org>
 <453fa8d1-6d12-ea23-6b35-e556f72fe0cf@xilinx.com>
From: Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>
In-Reply-To: <453fa8d1-6d12-ea23-6b35-e556f72fe0cf@xilinx.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 648d3378-5706-48fd-b6d0-08d9e672bda0
X-MS-TrafficTypeDiagnostic: MWHPR02MB3262:EE_
X-Microsoft-Antispam-PRVS:
	<MWHPR02MB3262F74D413999FA1C4D844EB2279@MWHPR02MB3262.namprd02.prod.outlook.com>
X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply
X-MS-Oob-TLC-OOBClassifiers: OLM:6108;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	F13P8m7Iky9MOkE7I2WQVDTgK89HdvuMfWwzlrErKqFGfc9wNsalhMzkjlN2VIz9npvshrrXuXAvZB1ebjVnZMusVM2fwb8Rt7qpMhg+6Pliq8sZkKoOXdpsgRSUzcgdDIknIiMZWgBeevUYYPs7y8C/4i48Xc9uDpvJZFsrTBRt29JZsCN/JC7rimYvJqK5jrjj8GzWzvld3DU+5yP+qAsQOo5ZPT3uTKZeCOyqvKw10ZmH58tc3mj6l+v/mZ8lqqYdiSf9FI8THoQDEbex3AyZ+HiUsZWmCzovDHzaeH+gJRWsfabWhOxwtzPnJJl65YhD4ahhBObBEHgc00LFXBjG0b10T2UcEKVOrf7kOnfrTXvFoxmTheEykin2xluy1TeWH4vQYBKF3HxU2CqyVcuVJbcMs4UE7N+DENzQ54mLTwNmWCgdiw82A+hpeeldgG1Z1ucwU4ZQh9F9Fny2ccdGvCIYIIxzXWgVITCPjfYKdh1FUwQl5K0n+/OOM+PAHCR5xDfuPkQ2mbwPHzqdtwbKrT37Y40DS0yCipsFn4TI3iGzNh+OHLX+eY2NnziHE4oNk2L4q/21pvoAx4/0VzQDmgRwl/B3DgSbXo2y58e22iFFo5JOy92IIh/Ce7KGZ1OkRDjn2sL0ZgNKYHI0VAmboU8Ih/b/FHaaTB/u7PXVMn0m/UWYHVPveNUKkUeIR7MSF+FP70pN6ItImodi1g==
X-Forefront-Antispam-Report:
	CIP:149.199.80.198;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:xir-pvapexch01.xlnx.xilinx.com;PTR:unknown-80-198.xilinx.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(36756003)(5660300002)(70586007)(70206006)(4326008)(8936002)(31696002)(83380400001)(53546011)(356005)(9786002)(8676002)(82310400004)(7636003)(110136005)(336012)(36860700001)(31686004)(47076005)(426003)(54906003)(2616005)(508600001)(26005)(186003)(316002)(2906002)(50156003)(43740500002);DIR:OUT;SFP:1101;
X-OriginatorOrg: xilinx.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2022 17:37:53.0003
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 648d3378-5706-48fd-b6d0-08d9e672bda0
X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.80.198];Helo=[xir-pvapexch01.xlnx.xilinx.com]
X-MS-Exchange-CrossTenant-AuthSource:
	BN1NAM02FT053.eop-nam02.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR02MB3262

Hi Julien/Stefano,

On 02/02/2022 13:05, Ayan Kumar Halder wrote:
> Hi Julien,
>
> I have a question.
>
> On 31/01/2022 19:37, Ayan Kumar Halder wrote:
>>> diff --git a/xen/arch/arm/ioreq.c b/xen/arch/arm/ioreq.c
>>> index 308650b400..f19fb46f72 100644
>>> --- a/xen/arch/arm/ioreq.c
>>> +++ b/xen/arch/arm/ioreq.c
>>> @@ -23,16 +23,35 @@
>>>     #include <public/hvm/ioreq.h>
>>>   +#include "decode.h"
>>> +
>>>   enum io_state handle_ioserv(struct cpu_user_regs *regs, struct 
>>> vcpu *v)
>>>   {
>>>       const union hsr hsr = { .bits = regs->hsr };
>>> -    const struct hsr_dabt dabt = hsr.dabt;
>>> +    struct hsr_dabt dabt = hsr.dabt;
>>> +
>>>       /* Code is similar to handle_read */
>>>       register_t r = v->io.req.data;
>>>         /* We are done with the IO */
>>>       v->io.req.state = STATE_IOREQ_NONE;
>>>   +    /*
>>> +     * Note that we have already decoded the instruction in 
>>> try_fwd_ioserv().
>>> +     * We decode the instruction again to obtain rn and imm9. This 
>>> will be used
>>> +     * to do the post increment.
>>> +     * Also there is no need to check whether the instruction can 
>>> be decoded or
>>> +     * was successfully decoded. The reason being if there was an 
>>> error, then
>>> +     * try_fwd_ioserv() would have returned error and this function 
>>> would not
>>> +     * have been called. Thus, there is an assumption that 
>>> handle_iosev() is
>>> +     * invoked when try_fwd_ioserv() has returned successfully.
>>
>> I am afraid this is not a correct assumption. Another vCPU can modify 
>> the instruction between the two decoding. So the right solution is to 
>> stash the information for latter consumption.
>>
>>> +     */
>>> +    if ( !dabt.valid )
>>> +    {
>>> +        decode_instruction(regs, &dabt);
>>> +        post_increment_register(&dabt.dabt_instr);
>>> +    }
>>> +
>>>       if ( dabt.write )
>>>           return IO_HANDLED;
>>>   @@ -65,6 +84,8 @@ enum io_state try_fwd_ioserv(struct 
>>> cpu_user_regs *regs,
>>>       };
>>>       struct ioreq_server *s = NULL;
>>>       enum io_state rc;
>>> +    bool instr_decoded = false;
>>> +    const union hsr hsr = { .bits = regs->hsr };
>>>         if ( vio->req.state != STATE_IOREQ_NONE )
>>>       {
>>> @@ -76,8 +97,18 @@ enum io_state try_fwd_ioserv(struct cpu_user_regs 
>>> *regs,
>>>       if ( !s )
>>>           return IO_UNHANDLED;
>>>   +    /*
>>> +     * Armv8 processor does not provide a valid syndrome for 
>>> decoding some
>>> +     * instructions (for eg post-indexing ldr/str instructions). So 
>>> in order to
>>> +     * process these instructions, Xen must decode them.
>>> +     */
>>>       if ( !info->dabt.valid )
>>> -        return IO_ABORT;
>>> +    {
>>> +        rc = try_decode_instruction_invalid_iss(regs, &info->dabt);
>>> +
>>> +        if ( rc != IO_HANDLED)
>>> +            return rc;
>>> +    }
>>
>> As you pointed out previously, the field SAS (Syndrome Access Size) 
>> is invalid when the ISV=0. So the decoding needs to be done *before* 
>> we select the IOREQ server.
>>
>> But as I said, this would result to decode the instruciton when this 
>> is not necessary. This is where Stefano's suggestion in [1] is useful.
>>
>> For ISV=0, it will be a lot more common to trap because of a P2M 
>> translation fault (of the MMIO is not mapped). So we should call that 
>> first and then, if it still not resolved, try to decode the instruction.
>>
>> With that in place, you are avoiding the issue in try_fwd_ioserv().
>>
>> Can you please coordinate with Stefano?
>
> I am a bit confused regarding where we need to handle to post 
> increment of Rn in case of ioreq.
>
> I can see the following two places where PC gets incremented :-
>
> 1. handle_ioserv() returns IO_HANDLED via try_handle_mmio(). And then 
> in "case IO_HANDLED:", PC is incremented.
>
> 2. leave_hypervisor_to_guest() ---> check_for_vcpu_work() --> 
> vcpu_ioreq_handle_completion() --> arch_ioreq_complete_mmio(). Here PC 
> is incremented as well.
>
> So, do I need to update Rn in both the above places.
>
> And if I understood your previous comment "Another vCPU can modify the 
> instruction between the two decoding....", you are suggesting to save 
> the instruction opcode (from PC) before invoking try_fwd_ioserv(). So, 
> that it can be decoded again in arch_ioreq_complete_mmio() without 
> reading PC.
>
> - Ayan

I have sent out the v6 patch  "[XEN v6 0/3] xen/arm64: io: Decode 
ldr/str post-indexing instruction".

- Ayan

>
>>
>> [1] alpine.DEB.2.22.394.2201271327430.27308@ubuntu-linux-20-04-desktop
>>


From xen-devel-bounces@lists.xenproject.org Wed Feb 02 18:21:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 18:21:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264403.457497 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFKG1-0004Oa-Rf; Wed, 02 Feb 2022 18:21:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264403.457497; Wed, 02 Feb 2022 18:21:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFKG1-0004OT-Oo; Wed, 02 Feb 2022 18:21:29 +0000
Received: by outflank-mailman (input) for mailman id 264403;
 Wed, 02 Feb 2022 18:21:28 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nFKG0-0004ON-Gz
 for xen-devel@lists.xenproject.org; Wed, 02 Feb 2022 18:21:28 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nFKFz-000881-VK; Wed, 02 Feb 2022 18:21:27 +0000
Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.2.82])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nFKFz-0000kU-Mv; Wed, 02 Feb 2022 18:21:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=uapE0SCN1j90Ug6oJSnZZdAlP8j3B77iTnpSFf4PEtY=; b=xNbJ41pWafJjEc1lKYapUHiynn
	7YOCLieSYJdpo/X/RJmucD1rR22qNai3VItx5X+AR4ctPloTkkcQZg5gFe0tdeGTuAOm3edfhBxhK
	Hy4S/2sAKP8hbFqfeaG+APdIDuy4aLHpdVTh97SoIiSc5K6RGuXZjGh3R2P4S1gs+xKk=;
Message-ID: <e0b3cf63-360e-9625-a74e-b728e3de5c55@xen.org>
Date: Wed, 2 Feb 2022 18:21:25 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.1
Subject: Re: [XEN v5] xen/arm64: io: Decode ldr/str post-indexing instructions
To: Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>,
 xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com,
 bertrand.marquis@arm.com
References: <20220131193728.2980-1-ayankuma@xilinx.com>
 <e07068aa-91b8-ebdf-db17-7173f417ad33@xen.org>
 <453fa8d1-6d12-ea23-6b35-e556f72fe0cf@xilinx.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <453fa8d1-6d12-ea23-6b35-e556f72fe0cf@xilinx.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi,

On 02/02/2022 13:05, Ayan Kumar Halder wrote:
> On 31/01/2022 19:37, Ayan Kumar Halder wrote:
>>> diff --git a/xen/arch/arm/ioreq.c b/xen/arch/arm/ioreq.c
>>> index 308650b400..f19fb46f72 100644
>>> --- a/xen/arch/arm/ioreq.c
>>> +++ b/xen/arch/arm/ioreq.c
>>> @@ -23,16 +23,35 @@
>>>     #include <public/hvm/ioreq.h>
>>>   +#include "decode.h"
>>> +
>>>   enum io_state handle_ioserv(struct cpu_user_regs *regs, struct vcpu 
>>> *v)
>>>   {
>>>       const union hsr hsr = { .bits = regs->hsr };
>>> -    const struct hsr_dabt dabt = hsr.dabt;
>>> +    struct hsr_dabt dabt = hsr.dabt;
>>> +
>>>       /* Code is similar to handle_read */
>>>       register_t r = v->io.req.data;
>>>         /* We are done with the IO */
>>>       v->io.req.state = STATE_IOREQ_NONE;
>>>   +    /*
>>> +     * Note that we have already decoded the instruction in 
>>> try_fwd_ioserv().
>>> +     * We decode the instruction again to obtain rn and imm9. This 
>>> will be used
>>> +     * to do the post increment.
>>> +     * Also there is no need to check whether the instruction can be 
>>> decoded or
>>> +     * was successfully decoded. The reason being if there was an 
>>> error, then
>>> +     * try_fwd_ioserv() would have returned error and this function 
>>> would not
>>> +     * have been called. Thus, there is an assumption that 
>>> handle_iosev() is
>>> +     * invoked when try_fwd_ioserv() has returned successfully.
>>
>> I am afraid this is not a correct assumption. Another vCPU can modify 
>> the instruction between the two decoding. So the right solution is to 
>> stash the information for latter consumption.
>>
>>> +     */
>>> +    if ( !dabt.valid )
>>> +    {
>>> +        decode_instruction(regs, &dabt);
>>> +        post_increment_register(&dabt.dabt_instr);
>>> +    }
>>> +
>>>       if ( dabt.write )
>>>           return IO_HANDLED;
>>>   @@ -65,6 +84,8 @@ enum io_state try_fwd_ioserv(struct cpu_user_regs 
>>> *regs,
>>>       };
>>>       struct ioreq_server *s = NULL;
>>>       enum io_state rc;
>>> +    bool instr_decoded = false;
>>> +    const union hsr hsr = { .bits = regs->hsr };
>>>         if ( vio->req.state != STATE_IOREQ_NONE )
>>>       {
>>> @@ -76,8 +97,18 @@ enum io_state try_fwd_ioserv(struct cpu_user_regs 
>>> *regs,
>>>       if ( !s )
>>>           return IO_UNHANDLED;
>>>   +    /*
>>> +     * Armv8 processor does not provide a valid syndrome for 
>>> decoding some
>>> +     * instructions (for eg post-indexing ldr/str instructions). So 
>>> in order to
>>> +     * process these instructions, Xen must decode them.
>>> +     */
>>>       if ( !info->dabt.valid )
>>> -        return IO_ABORT;
>>> +    {
>>> +        rc = try_decode_instruction_invalid_iss(regs, &info->dabt);
>>> +
>>> +        if ( rc != IO_HANDLED)
>>> +            return rc;
>>> +    }
>>
>> As you pointed out previously, the field SAS (Syndrome Access Size) is 
>> invalid when the ISV=0. So the decoding needs to be done *before* we 
>> select the IOREQ server.
>>
>> But as I said, this would result to decode the instruciton when this 
>> is not necessary. This is where Stefano's suggestion in [1] is useful.
>>
>> For ISV=0, it will be a lot more common to trap because of a P2M 
>> translation fault (of the MMIO is not mapped). So we should call that 
>> first and then, if it still not resolved, try to decode the instruction.
>>
>> With that in place, you are avoiding the issue in try_fwd_ioserv().
>>
>> Can you please coordinate with Stefano?
> 
> I am a bit confused regarding where we need to handle to post increment 
> of Rn in case of ioreq.
> 
> I can see the following two places where PC gets incremented :-
> 
> 1. handle_ioserv() returns IO_HANDLED via try_handle_mmio(). And then in 
> "case IO_HANDLED:", PC is incremented.
> 
> 2. leave_hypervisor_to_guest() ---> check_for_vcpu_work() --> 
> vcpu_ioreq_handle_completion() --> arch_ioreq_complete_mmio(). Here PC 
> is incremented as well.
> 
> So, do I need to update Rn in both the above places.
> 
> And if I understood your previous comment "Another vCPU can modify the 
> instruction between the two decoding....", you are suggesting to save 
> the instruction opcode (from PC) before invoking try_fwd_ioserv(). So, 
> that it can be decoded again in arch_ioreq_complete_mmio() without 
> reading PC.
We should not need to decode the instruction twice. Instead, we could 
add the instruction details in vcpu_io as there can only be one I/O 
inflight per vCPU.

Note that vcpu_io is an arch-agnostic structure. So you would want to 
embedded an arch specific structure (e.g. arch_vcpu_io) that would 
defined in arch/arm/include/asm/ioreq.h.

For x86, you could define a dummy structure in arch/x86/include/asm/ioreq.h.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Feb 02 19:42:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 19:42:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264410.457508 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFLVj-0003fF-RW; Wed, 02 Feb 2022 19:41:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264410.457508; Wed, 02 Feb 2022 19:41:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFLVj-0003f8-ON; Wed, 02 Feb 2022 19:41:47 +0000
Received: by outflank-mailman (input) for mailman id 264410;
 Wed, 02 Feb 2022 19:41:46 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nFLVi-0003ex-9X; Wed, 02 Feb 2022 19:41:46 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nFLVi-00017P-4j; Wed, 02 Feb 2022 19:41:46 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nFLVh-000609-JI; Wed, 02 Feb 2022 19:41:45 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nFLVh-00065e-Ik; Wed, 02 Feb 2022 19:41:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=GHfNKgyBtWK2SsXyunQxLIC4nIgF7PzI/19UJCXH1hw=; b=bQI9Kdr6yS0eM7VmDgMxrzU4IR
	MB/W/PIAXY9N2IyEOEQjqXwC1l/fj4iO+D1w4Wo9rzcEUMtr79eBwEF38kdbmZmN3p83q/8QQXtTR
	41atlAa4qMUjIIbIRhZ6sVhtCk3Fdzfb+3d8C3hQEQ40SAOzoBxjqJku2OkmQ5LsEDPM=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167986-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 167986: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=9ce3ef20b4f085a7dc8ee41b0fec6fdeced3773e
X-Osstest-Versions-That:
    xen=a7e7c7260cde78a148810db5320cbf39686c3e09
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 02 Feb 2022 19:41:45 +0000

flight 167986 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167986/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167978
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167978
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167978
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167978
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 167978
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 167978
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167978
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167978
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167978
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167978
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167978
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167978
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 xen                  9ce3ef20b4f085a7dc8ee41b0fec6fdeced3773e
baseline version:
 xen                  a7e7c7260cde78a148810db5320cbf39686c3e09

Last test of basis   167978  2022-02-01 18:07:14 Z    1 days
Testing same since   167986  2022-02-02 10:07:45 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   a7e7c7260c..9ce3ef20b4  9ce3ef20b4f085a7dc8ee41b0fec6fdeced3773e -> master


From xen-devel-bounces@lists.xenproject.org Wed Feb 02 21:54:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 21:54:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264424.457522 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFNZl-0007QA-IO; Wed, 02 Feb 2022 21:54:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264424.457522; Wed, 02 Feb 2022 21:54:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFNZl-0007Q3-FV; Wed, 02 Feb 2022 21:54:05 +0000
Received: by outflank-mailman (input) for mailman id 264424;
 Wed, 02 Feb 2022 21:54:04 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nFNZk-0007Pt-JY; Wed, 02 Feb 2022 21:54:04 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nFNZk-0003RH-IU; Wed, 02 Feb 2022 21:54:04 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nFNZj-0003xD-Tk; Wed, 02 Feb 2022 21:54:03 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nFNZj-0004vc-TI; Wed, 02 Feb 2022 21:54:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=8kRiXSld8/Du0Lkr8j5563llich04mil6VsSubszsC0=; b=l1fvtOwzy214L6eVmxtz3POA3J
	/Am17x7awBG32FdoIb6aha0KZ6V12/HTnfWhb1AFaivKE97dKlFICEa83rDswIGuPZEHjMwTxHOF5
	O0h2usHBH4pi508t08lQ/b88RIb1cHymNAihndn4/P6l6gD8XVaAHM4C/iOfWyjw161A=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167989-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167989: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=33189f05278345eab608ff56e87905bdeacdbd47
X-Osstest-Versions-That:
    ovmf=017564d637e9c3051c2796d1d5b4d5df7179434c
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 02 Feb 2022 21:54:03 +0000

flight 167989 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167989/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 33189f05278345eab608ff56e87905bdeacdbd47
baseline version:
 ovmf                 017564d637e9c3051c2796d1d5b4d5df7179434c

Last test of basis   167980  2022-02-02 02:46:38 Z    0 days
Testing same since   167989  2022-02-02 18:40:35 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Rebecca Cran <quic_rcran@quicinc.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   017564d637..33189f0527  33189f05278345eab608ff56e87905bdeacdbd47 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Wed Feb 02 23:21:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 02 Feb 2022 23:21:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264437.457533 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFOwT-0007Pv-6Q; Wed, 02 Feb 2022 23:21:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264437.457533; Wed, 02 Feb 2022 23:21:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFOwT-0007Po-3R; Wed, 02 Feb 2022 23:21:37 +0000
Received: by outflank-mailman (input) for mailman id 264437;
 Wed, 02 Feb 2022 23:21:36 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nFOwS-0007Pe-8z; Wed, 02 Feb 2022 23:21:36 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nFOwS-0004xP-1K; Wed, 02 Feb 2022 23:21:36 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nFOwR-0007Oy-GF; Wed, 02 Feb 2022 23:21:35 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nFOwR-0000dW-FS; Wed, 02 Feb 2022 23:21:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=C72QhyDfeEjkDKvQjuB3ddefVi+45zycd3jHo1rnp6k=; b=XFGriEaFrzlqjgG/D1mN0Y7BCL
	O6wFKs3ofRMZAIeIroKbAwpcMXpgUq3ezxu9vn9eWuz1izGwvlSJDduayHprNHYVLDj16WU6P7NRY
	GP/BXPRSNYeNPZzF+XEeoBnEnA8U2UCIyUhHvayzYHKZFEsQvtcauM9qHm9FEd38hX4g=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167987-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 167987: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=47cc1a3655135b89fa75c2824fbddd29df874612
X-Osstest-Versions-That:
    qemuu=3bbe296c1c7a6ddce7a294e006b8c4a53b385292
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 02 Feb 2022 23:21:35 +0000

flight 167987 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167987/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167981
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167981
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167981
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167981
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167981
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167981
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167981
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167981
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                47cc1a3655135b89fa75c2824fbddd29df874612
baseline version:
 qemuu                3bbe296c1c7a6ddce7a294e006b8c4a53b385292

Last test of basis   167981  2022-02-02 02:57:48 Z    0 days
Testing same since   167987  2022-02-02 13:39:33 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Emanuele Giuseppe Esposito <eesposit@redhat.com>
  Hanna Reitz <hreitz@redhat.com>
  Kevin Wolf <kwolf@redhat.com>
  Peter Lieven <pl@kamp.de>
  Peter Maydell <peter.maydell@linaro.org>
  Philippe Mathieu-Daudé <f4bug@amsat.org>
  Stefano Garzarella <sgarzare@redhat.com>
  Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   3bbe296c1c..47cc1a3655  47cc1a3655135b89fa75c2824fbddd29df874612 -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Thu Feb 03 00:07:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 03 Feb 2022 00:07:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264450.457545 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFPeX-0003l3-8M; Thu, 03 Feb 2022 00:07:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264450.457545; Thu, 03 Feb 2022 00:07:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFPeX-0003kw-4f; Thu, 03 Feb 2022 00:07:09 +0000
Received: by outflank-mailman (input) for mailman id 264450;
 Thu, 03 Feb 2022 00:07:07 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=VklA=SS=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nFPeV-0003kq-IO
 for xen-devel@lists.xenproject.org; Thu, 03 Feb 2022 00:07:07 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3869c18b-8485-11ec-8f75-fffcc8bd4f1a;
 Thu, 03 Feb 2022 01:07:05 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 955C6B832C3;
 Thu,  3 Feb 2022 00:07:04 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id E1103C004E1;
 Thu,  3 Feb 2022 00:07:02 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3869c18b-8485-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1643846823;
	bh=P/Iwp88jWaDKicsvk67MIe6PPYwAofo8PY1OVyQH3VU=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=hdY5fHzKYZeAQbjhwwOONnBPxqpUhKmDzXmaksPAcHsqAOrt69mC7yf+IA7p8zqqj
	 HjettDzAneKilo2XQv3QnOSDomuZSwKduHDLA6Cot7q7Pqw7SuC4LAbnX4i9kweATm
	 cqbRmDIFPS9JwY1iphkDvlmfBkHKN28r69AGG7eN6BppC2y/65DrgBZBF103Qm5MSZ
	 SEjElL1GFqJHeY4MIn92CyrwSMDrvYagphsRDXizjVB9VpAaw0XTZWkPjnlIBUfyMO
	 OD2otBhDF3PZ4IkW542qhbS8aTkw4fC97l6opmDxoHv/Ap/jvQdsvpnn6UQISl7r+E
	 AiVyfaqR/aVRg==
Date: Wed, 2 Feb 2022 16:07:02 -0800 (PST)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>
cc: xen-devel@lists.xenproject.org, sstabellini@kernel.org, 
    stefanos@xilinx.com, julien@xen.org, Volodymyr_Babchuk@epam.com, 
    bertrand.marquis@arm.com, Ayan Kumar Halder <ayankuma@xilinx.com>
Subject: Re: [XEN v6 2/3] xen/arm64: io: Support instructions (for which ISS
 is not valid) on emulated MMIO region using MMIO handler
In-Reply-To: <20220202173017.48463-3-ayankuma@xilinx.com>
Message-ID: <alpine.DEB.2.22.394.2202021553210.4074808@ubuntu-linux-20-04-desktop>
References: <20220202173017.48463-1-ayankuma@xilinx.com> <20220202173017.48463-3-ayankuma@xilinx.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Wed, 2 Feb 2022, Ayan Kumar Halder wrote:
> For instructions on MMIO regions emulated by Xen, Xen reads the
> remaining bits of the HSR. It determines if the instruction is to be
> ignored, retried or decoded. If it gets an error while decoding the
> instruction, then it sends an abort to the guest.
> 
> If the instruction is valid or successfully decoded, Xen tries to
> execute the instruction for the emulated MMIO region. If the instruction
> was successfully executed, then Xen determines if the instruction needs
> further processing. For eg:- In case of ldr/str post indexing on arm64,
> the rn register needs to be updated.
> 
> Signed-off-by: Ayan Kumar Halder <ayankuma@xilinx.com>
> ---
> 
> Changelog :-
> 
> v2..v5 - Mentioned in the cover letter.
> 
> v6 - 1. Mantained the decoding state of the instruction. This is used by the
> caller to either abort the guest or retry or ignore or perform read/write on
> the mmio region.
> 
> 2. try_decode() invokes decoding for both aarch64 and thumb state. (Previously
> it used to invoke decoding only for aarch64 state). Thus, it handles all the
> checking of the registers before invoking any decoding of instruction.
> try_decode_instruction_invalid_iss() has thus been removed.
> 
>  xen/arch/arm/arm32/traps.c       |   6 ++
>  xen/arch/arm/arm64/traps.c       |  41 ++++++++++++
>  xen/arch/arm/decode.h            |  12 +++-
>  xen/arch/arm/include/asm/traps.h |   2 +
>  xen/arch/arm/io.c                | 108 +++++++++++++++++++++++++------
>  5 files changed, 148 insertions(+), 21 deletions(-)
> 
> diff --git a/xen/arch/arm/arm32/traps.c b/xen/arch/arm/arm32/traps.c
> index 9c9790a6d1..6ad9a31499 100644
> --- a/xen/arch/arm/arm32/traps.c
> +++ b/xen/arch/arm/arm32/traps.c
> @@ -21,6 +21,7 @@
>  
>  #include <public/xen.h>
>  
> +#include <asm/mmio.h>
>  #include <asm/processor.h>
>  #include <asm/traps.h>
>  
> @@ -82,6 +83,11 @@ void do_trap_data_abort(struct cpu_user_regs *regs)
>          do_unexpected_trap("Data Abort", regs);
>  }
>  
> +void post_increment_register(const struct instr_details *instr)
> +{
> +    ASSERT_UNREACHABLE();
> +}
> +
>  /*
>   * Local variables:
>   * mode: C
> diff --git a/xen/arch/arm/arm64/traps.c b/xen/arch/arm/arm64/traps.c
> index 9113a15c7a..4de2206801 100644
> --- a/xen/arch/arm/arm64/traps.c
> +++ b/xen/arch/arm/arm64/traps.c
> @@ -18,9 +18,12 @@
>  
>  #include <xen/lib.h>
>  
> +#include <asm/current.h>
>  #include <asm/hsr.h>
> +#include <asm/mmio.h>
>  #include <asm/system.h>
>  #include <asm/processor.h>
> +#include <asm/regs.h>
>  
>  #include <public/xen.h>
>  
> @@ -44,6 +47,44 @@ void do_bad_mode(struct cpu_user_regs *regs, int reason)
>      panic("bad mode\n");
>  }
>  
> +void post_increment_register(const struct instr_details *instr)
> +{
> +    struct cpu_user_regs *regs = guest_cpu_user_regs();
> +    register_t val;
> +
> +    /*
> +     * Handle when rn = SP
> +     * Refer ArmV8 ARM DDI 0487G.b, Page - D1-2463 "Stack pointer register selection"
> +     * t = SP_EL0
> +     * h = SP_ELx
> +     * and M[3:0] (Page - C5-474 "When exception taken from AArch64 state:")
> +     */
> +    if (instr->rn == 31 )
> +    {
> +        if ( (regs->cpsr & PSR_MODE_MASK) == PSR_MODE_EL1h )
> +            val = regs->sp_el1;
> +        else if ( ((regs->cpsr & PSR_MODE_MASK) == PSR_MODE_EL1t) ||
> +                    ((regs->cpsr & PSR_MODE_MASK) == PSR_MODE_EL0t) )
> +            val = regs->sp_el0;
> +        else
> +            ASSERT_UNREACHABLE();
> +    }
> +    else
> +        val = get_user_reg(regs, instr->rn);
> +
> +    val += instr->imm9;
> +
> +    if ( instr->rn == 31 )
> +    {
> +        if ( (regs->cpsr & PSR_MODE_MASK) == PSR_MODE_EL1h )
> +            regs->sp_el1 = val;
> +        else
> +            regs->sp_el0 = val;
> +    }
> +    else
> +        set_user_reg(regs, instr->rn, val);
> +}
> +
>  /*
>   * Local variables:
>   * mode: C
> diff --git a/xen/arch/arm/decode.h b/xen/arch/arm/decode.h
> index fe7512a053..5efd72405e 100644
> --- a/xen/arch/arm/decode.h
> +++ b/xen/arch/arm/decode.h
> @@ -52,7 +52,17 @@ union instr {
>  #define POST_INDEX_FIXED_MASK   0x3B200C00
>  #define POST_INDEX_FIXED_VALUE  0x38000400
>  
> -/* Decode an instruction from pc
> +enum instr_decode_state
> +{
> +    INSTR_ERROR, /* Error encountered while decoding the instruction */
> +    INSTR_VALID, /* ISS is valid, so there is no need to decode */
> +    INSTR_SUCCESS, /* Instruction is decoded successfully */
> +    INSTR_IGNORE, /* Instruction is to be ignored (similar to NOP) */
> +    INSTR_RETRY /* Instruction is to be retried */
> +};
> +
> +/*
> + * Decode an instruction from pc
>   * /!\ This function is intended to decode an instruction. It considers that the
>   * instruction is valid.
>   *
> diff --git a/xen/arch/arm/include/asm/traps.h b/xen/arch/arm/include/asm/traps.h
> index 2ed2b85c6f..95c46ad391 100644
> --- a/xen/arch/arm/include/asm/traps.h
> +++ b/xen/arch/arm/include/asm/traps.h
> @@ -109,6 +109,8 @@ static inline register_t sign_extend(const struct hsr_dabt dabt, register_t r)
>      return r;
>  }
>  
> +void post_increment_register(const struct instr_details *instr);
> +
>  #endif /* __ASM_ARM_TRAPS__ */
>  /*
>   * Local variables:
> diff --git a/xen/arch/arm/io.c b/xen/arch/arm/io.c
> index a289d393f9..1011327058 100644
> --- a/xen/arch/arm/io.c
> +++ b/xen/arch/arm/io.c
> @@ -95,6 +95,59 @@ static const struct mmio_handler *find_mmio_handler(struct domain *d,
>      return handler;
>  }
>  
> +enum instr_decode_state try_decode_instruction(const struct cpu_user_regs *regs,
> +                                               mmio_info_t *info)
> +{
> +    int rc;
> +
> +    /*
> +     * Erratum 766422: Thumb store translation fault to Hypervisor may
> +     * not have correct HSR Rt value.
> +     */
> +    if ( check_workaround_766422() && (regs->cpsr & PSR_THUMB) &&
> +         info->dabt.write )
> +    {
> +        rc = decode_instruction(regs, info);
> +        if ( rc )
> +        {
> +            gprintk(XENLOG_DEBUG, "Unable to decode instruction\n");
> +            return INSTR_ERROR;
> +        }

It looks like we want a "return" here? But it should work either way
because it should return with the if ( info->dabt.valid ) check right
after anyway.


> +    }
> +
> +    /* If ISS is valid, then no need to decode the instruction any further */
> +    if (info->dabt.valid)
> +        return INSTR_VALID;

code style


> +    /*
> +     * Xen should not decode the instruction when it was trapped due to
> +     * translation fault.
> +     */
> +    if ( info->dabt.s1ptw )
> +        return INSTR_RETRY;
> +
> +    /*
> +     * If the fault occurred due to cache maintenance or address translation
> +     * instructions, then Xen needs to ignore these instructions.
> +     */
> +    if ( info->dabt.cache )
> +        return INSTR_IGNORE;
> +
> +    /*
> +     * Armv8 processor does not provide a valid syndrome for decoding some
> +     * instructions. So in order to process these instructions, Xen must
> +     * decode them.
> +     */
> +    rc = decode_instruction(regs, info);
> +    if ( rc )
> +    {
> +        gprintk(XENLOG_ERR, "Unable to decode instruction\n");
> +        return INSTR_ERROR;
> +    }
> +    else
> +        return INSTR_SUCCESS;
> +}
> +
>  enum io_state try_handle_mmio(struct cpu_user_regs *regs,
>                                const union hsr hsr,
>                                paddr_t gpa)
> @@ -106,14 +159,14 @@ enum io_state try_handle_mmio(struct cpu_user_regs *regs,
>          .gpa = gpa,
>          .dabt = dabt
>      };
> +    int rc;
> +    enum instr_decode_state state;
>  
>      ASSERT(hsr.ec == HSR_EC_DATA_ABORT_LOWER_EL);
>  
>      handler = find_mmio_handler(v->domain, info.gpa);
>      if ( !handler )
>      {
> -        int rc;
> -
>          rc = try_fwd_ioserv(regs, v, &info);
>          if ( rc == IO_HANDLED )
>              return handle_ioserv(regs, v);
> @@ -121,31 +174,46 @@ enum io_state try_handle_mmio(struct cpu_user_regs *regs,
>          return rc;
>      }
>  
> -    /* All the instructions used on emulated MMIO region should be valid */
> -    if ( !dabt.valid )
> +    state = try_decode_instruction(regs, &info);

We still have the issue that try_fwd_ioserv (called above) doesn't work
properly if !dabt.valid. I think we need to call try_decode_instruction
and do the "state" checks before find_mmio_handler/try_fwd_ioserv.


> +    /*
> +     * If the instruction was to be ignored by Xen, then it should return to the
> +     * caller which will increment the PC, so that the guest can execute the
> +     * next instruction.
> +     */
> +    if ( state == INSTR_IGNORE )
> +        return IO_HANDLED;
> +    /*
> +     * If Xen could not decode the instruction for any reason, then it should
> +     * ask the caller to abort the guest.
> +     */
> +    else if ( state == INSTR_ERROR )
>          return IO_ABORT;
> +    /* When the instruction needs to be retried by the guest */
> +    else if ( state == INSTR_RETRY )
> +        return IO_UNHANDLED;
>  
>      /*
> -     * Erratum 766422: Thumb store translation fault to Hypervisor may
> -     * not have correct HSR Rt value.
> +     * At this point, we know that the instruction is either valid or has been
> +     * decoded successfully. Thus, Xen should be allowed to execute the
> +     * instruction on the emulated MMIO region.
>       */
> -    if ( check_workaround_766422() && (regs->cpsr & PSR_THUMB) &&
> -         dabt.write )
> -    {
> -        int rc;
> +    if ( info.dabt.write )
> +        rc = handle_write(handler, v, &info);
> +    else
> +        rc = handle_read(handler, v, &info);
>  
> -        rc = decode_instruction(regs, &info);
> -        if ( rc )
> -        {
> -            gprintk(XENLOG_DEBUG, "Unable to decode instruction\n");
> -            return IO_ABORT;
> -        }
> +    /*
> +     * If the instruction was decoded and has executed successfully on the MMIO
> +     * region, then Xen should execute the next part of the instruction. (for eg
> +     * increment the rn if it is a post-indexing instruction.
> +     */
> +    if ( (rc == IO_HANDLED) && (state == INSTR_SUCCESS) )
> +    {
> +        post_increment_register(&info.dabt_instr);
>      }

We need to call post_increment_register also from arch_ioreq_complete_mmio for the IOREQ case.


> -    if ( info.dabt.write )
> -        return handle_write(handler, v, &info);
> -    else
> -        return handle_read(handler, v, &info);
> +    return rc;
>  }
>  
>  void register_mmio_handler(struct domain *d,
> -- 
> 2.17.1
> 


From xen-devel-bounces@lists.xenproject.org Thu Feb 03 00:44:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 03 Feb 2022 00:44:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264459.457556 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFQEs-0007rO-4t; Thu, 03 Feb 2022 00:44:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264459.457556; Thu, 03 Feb 2022 00:44:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFQEs-0007rH-1H; Thu, 03 Feb 2022 00:44:42 +0000
Received: by outflank-mailman (input) for mailman id 264459;
 Thu, 03 Feb 2022 00:44:41 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=VklA=SS=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nFQEr-0007rB-3p
 for xen-devel@lists.xenproject.org; Thu, 03 Feb 2022 00:44:41 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 76bdf27b-848a-11ec-8f75-fffcc8bd4f1a;
 Thu, 03 Feb 2022 01:44:38 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id B64D060F6D;
 Thu,  3 Feb 2022 00:44:36 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id BE2A2C004E1;
 Thu,  3 Feb 2022 00:44:35 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 76bdf27b-848a-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1643849076;
	bh=mBlyg4NA2FUdQEXT3MfDiueasuutyPNVUNbFYnChHng=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=jvN/YSe5jNIOrg9315rj8jNRwC/qNPGgMZ6WekIlxsqxZPvf1uQD23LkqvpcFWm6I
	 XiG6IaywyNDYrDYeWuS2Xok4HBI9dMcOOciNdUg0iZFmeE6RqY9x+v8qQlDwHu6w8b
	 xSSTFPKqRizUqN/zVskdACBKld1ubb0ivXs2cJi8FxYGrAdU4LfZ3UTKz/9NR2NEbh
	 ZF2jK4gih0/ngpb4hlrIFGHNEmUTeDnXdPmr90eFfvaFokCVLDV7kCXIvpuUNUxg+n
	 C5e2cdw4hHs+PyG4HIaQECKzJBGvlouHYg0FAPKU57osLLtd9ELRGiPKN0ABFHhKEP
	 o4beZpsFMT40A==
Date: Wed, 2 Feb 2022 16:44:34 -0800 (PST)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>
cc: xen-devel@lists.xenproject.org, sstabellini@kernel.org, 
    stefanos@xilinx.com, julien@xen.org, Volodymyr_Babchuk@epam.com, 
    bertrand.marquis@arm.com, Ayan Kumar Halder <ayankuma@xilinx.com>
Subject: Re: [XEN v6 3/3] xen/arm64: io: Support instructions (for which ISS
 is not valid) on emulated MMIO region using ioreq handler
In-Reply-To: <20220202173017.48463-4-ayankuma@xilinx.com>
Message-ID: <alpine.DEB.2.22.394.2202021609320.4074808@ubuntu-linux-20-04-desktop>
References: <20220202173017.48463-1-ayankuma@xilinx.com> <20220202173017.48463-4-ayankuma@xilinx.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Wed, 2 Feb 2022, Ayan Kumar Halder wrote:
> When an instruction is trapped in Xen due to translation fault, Xen checks if
> the ISS is valid. If not, Xen tries to resolve the translation fault using
> p2m page tables. In case if it is a data abort, Xen will try to map the mmio
> region to the guest (ie tries to emulate the mmio region).
> 
> If it is not successfull, then it tries to decode the instruction.
> It saves the decoding state, rn and imm9 to ioreq. Whenever the vcpu handles
> the ioreq successfully, it will read the decoding state to determine if the
> instruction decoded was a ldr/str post indexing (ie INSTR_LDR_STR_POSTINDEXING).
> If so, it uses these details to post increment rn.
> 
> Signed-off-by: Ayan Kumar Halder <ayankuma@xilinx.com>

Typically, we try to avoid introducing code in one patch, then moving it
to a different place in the next patch. We try to add code where it
needs to be directly in the first place.

Most of my feedback below is really to do things directly in patch #2.
It could be that once you do that, there is nothing left here in patch
#3 and you could even drop it.


> ---
> 
> Changelog :-
> 
> v2..v5 - Provided in cover letter.
> 
> v6 - 1. Introduced a new field('enum instr_decode_state state') inside
> 'struct instr_details'. This holds the decoding state of the instruction.
> This is later read by the post_increment_register() to determine if rn needs to
> be incremented. Also, this is read by the callers of try_decode_instruction()
> to determine if the instruction was valid or ignored or to be retried or
> error or decoded successfully.
> 
> 2. Also stored 'instr_details' inside 'struct ioreq'. This enables
> arch_ioreq_complete_mmio() to invoke post_increment_register() without decoding
> the instruction again.
> 
> 3. Check hsr.dabt.valid in do_trap_stage2_abort_guest(). If it is not valid,
> then decode the instruction. This ensures that try_handle_mmio() is invoked only
> when the instruction is either valid or decoded successfully.
> 
> 4. Inside do_trap_stage2_abort_guest(), if hsr.dabt.valid is not set, then
> resolve the translation fault before trying to decode the instruction. If
> translation fault is resolved, then return to the guest to execute the instruction
> again.
> 
>  xen/arch/arm/arm64/traps.c      |  4 +++
>  xen/arch/arm/decode.c           |  1 +
>  xen/arch/arm/decode.h           |  9 ------
>  xen/arch/arm/include/asm/mmio.h | 13 ++++++++
>  xen/arch/arm/io.c               | 56 ++++++++++-----------------------
>  xen/arch/arm/ioreq.c            | 13 +++++---
>  xen/arch/arm/traps.c            | 56 +++++++++++++++++++++++++++++++--
>  xen/include/public/hvm/ioreq.h  | 19 +++++------
>  8 files changed, 108 insertions(+), 63 deletions(-)
> 
> diff --git a/xen/arch/arm/arm64/traps.c b/xen/arch/arm/arm64/traps.c
> index 4de2206801..505a843b07 100644
> --- a/xen/arch/arm/arm64/traps.c
> +++ b/xen/arch/arm/arm64/traps.c
> @@ -52,6 +52,10 @@ void post_increment_register(const struct instr_details *instr)
>      struct cpu_user_regs *regs = guest_cpu_user_regs();
>      register_t val;
>  
> +    /* Currently, we handle only ldr/str post indexing instructions */
> +    if ( instr->state != INSTR_LDR_STR_POSTINDEXING )
> +        return;

This change should be in patch #2


>      /*
>       * Handle when rn = SP
>       * Refer ArmV8 ARM DDI 0487G.b, Page - D1-2463 "Stack pointer register selection"
> diff --git a/xen/arch/arm/decode.c b/xen/arch/arm/decode.c
> index 3f2d2a3f62..0a4d9d2772 100644
> --- a/xen/arch/arm/decode.c
> +++ b/xen/arch/arm/decode.c
> @@ -147,6 +147,7 @@ static int decode_arm64(register_t pc, mmio_info_t *info)
>  
>      update_dabt(dabt, opcode.ldr_str.rt, opcode.ldr_str.size, false);
>  
> +    dabt_instr->state = INSTR_LDR_STR_POSTINDEXING;

This one should also be in patch #2


>      dabt_instr->rn = opcode.ldr_str.rn;
>      dabt_instr->imm9 = opcode.ldr_str.imm9;
>  
> diff --git a/xen/arch/arm/decode.h b/xen/arch/arm/decode.h
> index 5efd72405e..6a09b07b46 100644
> --- a/xen/arch/arm/decode.h
> +++ b/xen/arch/arm/decode.h
> @@ -52,15 +52,6 @@ union instr {
>  #define POST_INDEX_FIXED_MASK   0x3B200C00
>  #define POST_INDEX_FIXED_VALUE  0x38000400
>  
> -enum instr_decode_state
> -{
> -    INSTR_ERROR, /* Error encountered while decoding the instruction */
> -    INSTR_VALID, /* ISS is valid, so there is no need to decode */
> -    INSTR_SUCCESS, /* Instruction is decoded successfully */
> -    INSTR_IGNORE, /* Instruction is to be ignored (similar to NOP) */
> -    INSTR_RETRY /* Instruction is to be retried */
> -};
> -
>  /*
>   * Decode an instruction from pc
>   * /!\ This function is intended to decode an instruction. It considers that the
> diff --git a/xen/arch/arm/include/asm/mmio.h b/xen/arch/arm/include/asm/mmio.h
> index 3354d9c635..f7cdf66a5b 100644
> --- a/xen/arch/arm/include/asm/mmio.h
> +++ b/xen/arch/arm/include/asm/mmio.h
> @@ -26,12 +26,23 @@
>  
>  #define MAX_IO_HANDLER  16
>  
> +enum instr_decode_state
> +{
> +    INSTR_ERROR,                    /* Error encountered while decoding the instruction */
> +    INSTR_VALID,                    /* ISS is valid, so there is no need to decode */
> +    INSTR_LDR_STR_POSTINDEXING,     /* Instruction is decoded successfully.
> +                                       It is ldr/str post indexing */
> +    INSTR_IGNORE,                   /* Instruction is to be ignored (similar to NOP) */
> +    INSTR_RETRY                     /* Instruction is to be retried */
> +};
> +
>  typedef struct
>  {
>      struct hsr_dabt dabt;
>      struct instr_details {
>          unsigned long rn:5;
>          signed int imm9:9;
> +        enum instr_decode_state state;
>      } dabt_instr;
>      paddr_t gpa;
>  } mmio_info_t;
> @@ -77,6 +88,8 @@ void register_mmio_handler(struct domain *d,
>  int domain_io_init(struct domain *d, int max_count);
>  void domain_io_free(struct domain *d);
>  
> +void try_decode_instruction(const struct cpu_user_regs *regs,
> +                            mmio_info_t *info);
>  
>  #endif  /* __ASM_ARM_MMIO_H__ */
>  
> diff --git a/xen/arch/arm/io.c b/xen/arch/arm/io.c
> index 1011327058..46726637c6 100644
> --- a/xen/arch/arm/io.c
> +++ b/xen/arch/arm/io.c
> @@ -95,8 +95,8 @@ static const struct mmio_handler *find_mmio_handler(struct domain *d,
>      return handler;
>  }
>  
> -enum instr_decode_state try_decode_instruction(const struct cpu_user_regs *regs,
> -                                               mmio_info_t *info)
> +void try_decode_instruction(const struct cpu_user_regs *regs,
> +                            mmio_info_t *info)
>  {
>      int rc;
>  
> @@ -111,27 +111,37 @@ enum instr_decode_state try_decode_instruction(const struct cpu_user_regs *regs,
>          if ( rc )
>          {
>              gprintk(XENLOG_DEBUG, "Unable to decode instruction\n");
> -            return INSTR_ERROR;
> +            info->dabt_instr.state = INSTR_ERROR;
> +            return;
>          }
>      }
>  
>      /* If ISS is valid, then no need to decode the instruction any further */
>      if (info->dabt.valid)
> -        return INSTR_VALID;
> +    {
> +        info->dabt_instr.state = INSTR_VALID;
> +        return;
> +    }
>  
>      /*
>       * Xen should not decode the instruction when it was trapped due to
>       * translation fault.
>       */
>      if ( info->dabt.s1ptw )
> -        return INSTR_RETRY;
> +    {
> +        info->dabt_instr.state = INSTR_RETRY;
> +        return;
> +    }
>  
>      /*
>       * If the fault occurred due to cache maintenance or address translation
>       * instructions, then Xen needs to ignore these instructions.
>       */
>      if ( info->dabt.cache )
> -        return INSTR_IGNORE;
> +    {
> +        info->dabt_instr.state = INSTR_IGNORE;
> +        return;
> +    }
>  
>      /*
>       * Armv8 processor does not provide a valid syndrome for decoding some
> @@ -142,10 +152,8 @@ enum instr_decode_state try_decode_instruction(const struct cpu_user_regs *regs,
>      if ( rc )
>      {
>          gprintk(XENLOG_ERR, "Unable to decode instruction\n");
> -        return INSTR_ERROR;
> +        info->dabt_instr.state = INSTR_ERROR;
>      }
> -    else
> -        return INSTR_SUCCESS;
>  }
>  
>  enum io_state try_handle_mmio(struct cpu_user_regs *regs,
> @@ -160,7 +168,6 @@ enum io_state try_handle_mmio(struct cpu_user_regs *regs,
>          .dabt = dabt
>      };
>      int rc;
> -    enum instr_decode_state state;
>  
>      ASSERT(hsr.ec == HSR_EC_DATA_ABORT_LOWER_EL);
>  
> @@ -174,25 +181,6 @@ enum io_state try_handle_mmio(struct cpu_user_regs *regs,
>          return rc;
>      }
>  
> -    state = try_decode_instruction(regs, &info);
> -
> -    /*
> -     * If the instruction was to be ignored by Xen, then it should return to the
> -     * caller which will increment the PC, so that the guest can execute the
> -     * next instruction.
> -     */
> -    if ( state == INSTR_IGNORE )
> -        return IO_HANDLED;
> -    /*
> -     * If Xen could not decode the instruction for any reason, then it should
> -     * ask the caller to abort the guest.
> -     */
> -    else if ( state == INSTR_ERROR )
> -        return IO_ABORT;
> -    /* When the instruction needs to be retried by the guest */
> -    else if ( state == INSTR_RETRY )
> -        return IO_UNHANDLED;
>
>      /*
>       * At this point, we know that the instruction is either valid or has been
>       * decoded successfully. Thus, Xen should be allowed to execute the
> @@ -203,16 +191,6 @@ enum io_state try_handle_mmio(struct cpu_user_regs *regs,
>      else
>          rc = handle_read(handler, v, &info);
>  
> -    /*
> -     * If the instruction was decoded and has executed successfully on the MMIO
> -     * region, then Xen should execute the next part of the instruction. (for eg
> -     * increment the rn if it is a post-indexing instruction.
> -     */
> -    if ( (rc == IO_HANDLED) && (state == INSTR_SUCCESS) )
> -    {
> -        post_increment_register(&info.dabt_instr);
> -    }
> -
>      return rc;
>  }
>  
> diff --git a/xen/arch/arm/ioreq.c b/xen/arch/arm/ioreq.c
> index 308650b400..d8909aa903 100644
> --- a/xen/arch/arm/ioreq.c
> +++ b/xen/arch/arm/ioreq.c
> @@ -23,10 +23,13 @@
>  
>  #include <public/hvm/ioreq.h>
>  
> +#include "decode.h"
> +
>  enum io_state handle_ioserv(struct cpu_user_regs *regs, struct vcpu *v)
>  {
>      const union hsr hsr = { .bits = regs->hsr };
> -    const struct hsr_dabt dabt = hsr.dabt;
> +    struct hsr_dabt dabt = hsr.dabt;
> +
>      /* Code is similar to handle_read */
>      register_t r = v->io.req.data;
>  
> @@ -61,10 +64,13 @@ enum io_state try_fwd_ioserv(struct cpu_user_regs *regs,
>           */
>          .df = 0,
>          .data = get_user_reg(regs, info->dabt.reg),
> +        .dabt_instr = &info->dabt_instr,
>          .state = STATE_IOREQ_READY,
>      };
>      struct ioreq_server *s = NULL;
>      enum io_state rc;
> +    bool instr_decoded = false;
> +    const union hsr hsr = { .bits = regs->hsr };
>  
>      if ( vio->req.state != STATE_IOREQ_NONE )
>      {
> @@ -76,9 +82,6 @@ enum io_state try_fwd_ioserv(struct cpu_user_regs *regs,
>      if ( !s )
>          return IO_UNHANDLED;
>  
> -    if ( !info->dabt.valid )
> -        return IO_ABORT;
> -
>      vio->req = p;
>  
>      rc = ioreq_send(s, &p, 0);
> @@ -95,6 +98,7 @@ enum io_state try_fwd_ioserv(struct cpu_user_regs *regs,
>  bool arch_ioreq_complete_mmio(void)
>  {
>      struct vcpu *v = current;
> +    struct instr_details *dabt_instr = v->io.req.dabt_instr;

As Julien suggested, we can add the instruction details to vcpu_io (not
v->io.req).


>      struct cpu_user_regs *regs = guest_cpu_user_regs();
>      const union hsr hsr = { .bits = regs->hsr };
>  
> @@ -106,6 +110,7 @@ bool arch_ioreq_complete_mmio(void)
>  
>      if ( handle_ioserv(regs, v) == IO_HANDLED )
>      {
> +        post_increment_register(dabt_instr);
>          advance_pc(regs, hsr);
>          return true;
>      }

This change should also be in the previous patch.


> diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c
> index 9339d12f58..6cce2379fa 100644
> --- a/xen/arch/arm/traps.c
> +++ b/xen/arch/arm/traps.c
> @@ -1906,6 +1906,7 @@ static void do_trap_stage2_abort_guest(struct cpu_user_regs *regs,
>      paddr_t gpa;
>      uint8_t fsc = xabt.fsc & ~FSC_LL_MASK;
>      bool is_data = (hsr.ec == HSR_EC_DATA_ABORT_LOWER_EL);
> +    mmio_info_t info;
>  
>      /*
>       * If this bit has been set, it means that this stage-2 abort is caused
> @@ -1959,6 +1960,51 @@ static void do_trap_stage2_abort_guest(struct cpu_user_regs *regs,
>          return;
>      }
>      case FSC_FLT_TRANS:
> +
> +        info.gpa = gpa;
> +        info.dabt = hsr.dabt;
> +
> +        /* Check if the ISS is valid. */
> +        if ( !hsr.dabt.valid )
> +        {
> +
> +            /*
> +             * Assumption :- Most of the times when we get a translation fault
> +             * and the ISS is invalid, the underlying cause is that the page
> +             * tables have not been set up correctly.
> +             * First check if the translation fault can be resolved by the
> +             * P2M subsystem. If that's the case nothing else to do.
> +             */
> +            if ( p2m_resolve_translation_fault(current->domain,
> +                                           gaddr_to_gfn(gpa)) )
> +                return;
> +
> +            if ( is_data && try_map_mmio(gaddr_to_gfn(gpa)) )
> +                return;
> +
> +            try_decode_instruction(regs, &info);
> +
> +            /*
> +             * If the instruction was to be ignored by Xen, then it should return to the
> +             * caller which will increment the PC, so that the guest can execute the
> +             * next instruction.
> +             */
> +            if ( info.dabt_instr.state == INSTR_IGNORE )
> +            {
> +                advance_pc(regs, hsr);
> +                return;
> +            }
> +            /*
> +             * If Xen could not decode the instruction for any reason, then it should
> +             * ask the caller to abort the guest.
> +             */
> +            else if ( info.dabt_instr.state == INSTR_ERROR )
> +                goto inject_abt;
> +            /* When the instruction needs to be retried by the guest */
> +            else if ( info.dabt_instr.state == INSTR_RETRY )
> +                return;
> +        }

It is best to add the code directly here in the first place, rather than
adding it to try_handle_mmio first, then moving it here.

I think we should move the two calls to p2m_resolve_translation_fault
and try_map_mmio to a function to avoid repetation:

diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c
index 6cce2379fa..e3da9ed7c3 100644
--- a/xen/arch/arm/traps.c
+++ b/xen/arch/arm/traps.c
@@ -1893,6 +1893,23 @@ static bool try_map_mmio(gfn_t gfn)
     return !map_regions_p2mt(d, gfn, 1, mfn, p2m_mmio_direct_c);
 }
 
+static inline void check_p2m(bool is_data, paddr_t gpa)
+{
+    /*
+     * Assumption :- Most of the times when we get a translation fault
+     * and the ISS is invalid, the underlying cause is that the page
+     * tables have not been set up correctly.
+     * First check if the translation fault can be resolved by the
+     * P2M subsystem. If that's the case nothing else to do.
+     */
+    if ( p2m_resolve_translation_fault(current->domain,
+                gaddr_to_gfn(gpa)) )
+        return;
+
+    if ( is_data && try_map_mmio(gaddr_to_gfn(gpa)) )
+        return;
+}
+
 static void do_trap_stage2_abort_guest(struct cpu_user_regs *regs,
                                        const union hsr hsr)
 {
@@ -1968,19 +1985,7 @@ static void do_trap_stage2_abort_guest(struct cpu_user_regs *regs,
         if ( !hsr.dabt.valid )
         {
 
-            /*
-             * Assumption :- Most of the times when we get a translation fault
-             * and the ISS is invalid, the underlying cause is that the page
-             * tables have not been set up correctly.
-             * First check if the translation fault can be resolved by the
-             * P2M subsystem. If that's the case nothing else to do.
-             */
-            if ( p2m_resolve_translation_fault(current->domain,
-                                           gaddr_to_gfn(gpa)) )
-                return;
-
-            if ( is_data && try_map_mmio(gaddr_to_gfn(gpa)) )
-                return;
+            check_p2m(is_data, gpa);
 
             try_decode_instruction(regs, &info);
 
@@ -2038,15 +2043,7 @@ static void do_trap_stage2_abort_guest(struct cpu_user_regs *regs,
             }
         }
 
-        /* First check if the translation fault can be resolved by the
-         * P2M subsystem. If that's the case nothing else to do.
-         */
-        if ( p2m_resolve_translation_fault(current->domain,
-                                           gaddr_to_gfn(gpa)) )
-            return;
-
-        if ( is_data && try_map_mmio(gaddr_to_gfn(gpa)) )
-            return;
+        check_p2m(is_data, gpa);
 
         break;
     default:



>          /*
>           * Attempt first to emulate the MMIO as the data abort will
>           * likely happen in an emulated region.
> @@ -1975,6 +2021,13 @@ static void do_trap_stage2_abort_guest(struct cpu_user_regs *regs,
>                  goto inject_abt;
>              case IO_HANDLED:
>                  advance_pc(regs, hsr);
> +                /*
> +                 * If the instruction was decoded and has executed successfully
> +                 * on the MMIO region, then Xen should execute the next part of
> +                 * the instruction. (for eg increment the rn if it is a
> +                 * post-indexing instruction.
> +                 */
> +                post_increment_register(&info.dabt_instr);

I would introduce the post_increment_register() call here directly in
patch #2, rather than introducing it first in one place, then moving it
in the next patch


>                  return;
>              case IO_RETRY:
>                  /* finish later */
> @@ -1985,8 +2038,7 @@ static void do_trap_stage2_abort_guest(struct cpu_user_regs *regs,
>              }
>          }
>  
> -        /*
> -         * First check if the translation fault can be resolved by the
> +        /* First check if the translation fault can be resolved by the
>           * P2M subsystem. If that's the case nothing else to do.
>           */

Spurious change


>          if ( p2m_resolve_translation_fault(current->domain,
> diff --git a/xen/include/public/hvm/ioreq.h b/xen/include/public/hvm/ioreq.h
> index c511fae8e7..e4183960d8 100644
> --- a/xen/include/public/hvm/ioreq.h
> +++ b/xen/include/public/hvm/ioreq.h
> @@ -50,19 +50,20 @@
>   * SEGMENT |BUS   |DEV   |FN    |OFFSET
>   */
>  struct ioreq {
> -    uint64_t addr;          /* physical address */
> -    uint64_t data;          /* data (or paddr of data) */
> -    uint32_t count;         /* for rep prefixes */
> -    uint32_t size;          /* size in bytes */
> -    uint32_t vp_eport;      /* evtchn for notifications to/from device model */
> +    uint64_t addr;                   /* physical address */
> +    uint64_t data;                   /* data (or paddr of data) */
> +    uint32_t count;                  /* for rep prefixes */
> +    uint32_t size;                   /* size in bytes */
> +    uint32_t vp_eport;               /* evtchn for notifications to/from device model */
>      uint16_t _pad0;
>      uint8_t state:4;
> -    uint8_t data_is_ptr:1;  /* if 1, data above is the guest paddr
> -                             * of the real data to use. */
> -    uint8_t dir:1;          /* 1=read, 0=write */
> +    uint8_t data_is_ptr:1;           /* if 1, data above is the guest paddr
> +                                      * of the real data to use. */
> +    uint8_t dir:1;                   /* 1=read, 0=write */
>      uint8_t df:1;
>      uint8_t _pad1:1;
> -    uint8_t type;           /* I/O type */
> +    uint8_t type;                     /* I/O type */
> +    struct instr_details *dabt_instr; /* when the instruction is decoded */
>  };
>  typedef struct ioreq ioreq_t;

This structure is a public interface (public as in exposed and used by
other project.) We cannot change it easily as we need to maintain
backward compatibility. In any case, I don't think that changing struct
ioreq is required for what we are trying to achieve with this patch.


From xen-devel-bounces@lists.xenproject.org Thu Feb 03 00:45:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 03 Feb 2022 00:45:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264463.457567 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFQFM-0008LO-E9; Thu, 03 Feb 2022 00:45:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264463.457567; Thu, 03 Feb 2022 00:45:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFQFM-0008LH-B0; Thu, 03 Feb 2022 00:45:12 +0000
Received: by outflank-mailman (input) for mailman id 264463;
 Thu, 03 Feb 2022 00:45:11 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=VklA=SS=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nFQFL-0008IN-FU
 for xen-devel@lists.xenproject.org; Thu, 03 Feb 2022 00:45:11 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org
 [2604:1380:4641:c500::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 88e36a5f-848a-11ec-8eb8-a37418f5ba1a;
 Thu, 03 Feb 2022 01:45:10 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 71F8D60C0D;
 Thu,  3 Feb 2022 00:45:07 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 728E5C004E1;
 Thu,  3 Feb 2022 00:45:06 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 88e36a5f-848a-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1643849106;
	bh=Im11H1L8ze4uYI16QQMbKAIM4DiPehczorWfQ+SjV9k=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=oQMu22llX6KshLzFLQo29sBaaIixan6KOlZTdSQKoAiboSl1M8cWn2SxpjNPONUF4
	 wKoyijKTgy5ASRRf/PVsqo/LXgScSiwmvGANCNtnNrs1IQdmSXpXXZ2kPBbk3xtdsF
	 a2YRLAe0kl2Fx2gRDJAmonmGTVs1jzoXNxgDS5AvX0pPFbvOi7uyOUg4xob7TQ1NHC
	 Nv9BZW24WHRXDujt/1trxQyuNt0/lERrVoHkJAB6HEy0+JrKX7wvNseqS+jiEEhbq4
	 5XmGEfTQPtboY4DX4DzztKZvtk4xjEoY7Swse2WqiX1OfsyTtq02N+QRaozCvKvnI9
	 El6gJPMRWNm5Q==
Date: Wed, 2 Feb 2022 16:45:05 -0800 (PST)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Stefano Stabellini <sstabellini@kernel.org>
cc: Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>, 
    xen-devel@lists.xenproject.org, stefanos@xilinx.com, julien@xen.org, 
    Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, 
    Ayan Kumar Halder <ayankuma@xilinx.com>
Subject: Re: [XEN v6 2/3] xen/arm64: io: Support instructions (for which ISS
 is not valid) on emulated MMIO region using MMIO handler
In-Reply-To: <alpine.DEB.2.22.394.2202021553210.4074808@ubuntu-linux-20-04-desktop>
Message-ID: <alpine.DEB.2.22.394.2202021644410.4074808@ubuntu-linux-20-04-desktop>
References: <20220202173017.48463-1-ayankuma@xilinx.com> <20220202173017.48463-3-ayankuma@xilinx.com> <alpine.DEB.2.22.394.2202021553210.4074808@ubuntu-linux-20-04-desktop>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-788060652-1643849106=:4074808"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-788060652-1643849106=:4074808
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT

On Wed, 2 Feb 2022, Stefano Stabellini wrote:
> On Wed, 2 Feb 2022, Ayan Kumar Halder wrote:
> > For instructions on MMIO regions emulated by Xen, Xen reads the
> > remaining bits of the HSR. It determines if the instruction is to be
> > ignored, retried or decoded. If it gets an error while decoding the
> > instruction, then it sends an abort to the guest.
> > 
> > If the instruction is valid or successfully decoded, Xen tries to
> > execute the instruction for the emulated MMIO region. If the instruction
> > was successfully executed, then Xen determines if the instruction needs
> > further processing. For eg:- In case of ldr/str post indexing on arm64,
> > the rn register needs to be updated.
> > 
> > Signed-off-by: Ayan Kumar Halder <ayankuma@xilinx.com>
> > ---
> > 
> > Changelog :-
> > 
> > v2..v5 - Mentioned in the cover letter.
> > 
> > v6 - 1. Mantained the decoding state of the instruction. This is used by the
> > caller to either abort the guest or retry or ignore or perform read/write on
> > the mmio region.
> > 
> > 2. try_decode() invokes decoding for both aarch64 and thumb state. (Previously
> > it used to invoke decoding only for aarch64 state). Thus, it handles all the
> > checking of the registers before invoking any decoding of instruction.
> > try_decode_instruction_invalid_iss() has thus been removed.
> > 
> >  xen/arch/arm/arm32/traps.c       |   6 ++
> >  xen/arch/arm/arm64/traps.c       |  41 ++++++++++++
> >  xen/arch/arm/decode.h            |  12 +++-
> >  xen/arch/arm/include/asm/traps.h |   2 +
> >  xen/arch/arm/io.c                | 108 +++++++++++++++++++++++++------
> >  5 files changed, 148 insertions(+), 21 deletions(-)
> > 
> > diff --git a/xen/arch/arm/arm32/traps.c b/xen/arch/arm/arm32/traps.c
> > index 9c9790a6d1..6ad9a31499 100644
> > --- a/xen/arch/arm/arm32/traps.c
> > +++ b/xen/arch/arm/arm32/traps.c
> > @@ -21,6 +21,7 @@
> >  
> >  #include <public/xen.h>
> >  
> > +#include <asm/mmio.h>
> >  #include <asm/processor.h>
> >  #include <asm/traps.h>
> >  
> > @@ -82,6 +83,11 @@ void do_trap_data_abort(struct cpu_user_regs *regs)
> >          do_unexpected_trap("Data Abort", regs);
> >  }
> >  
> > +void post_increment_register(const struct instr_details *instr)
> > +{
> > +    ASSERT_UNREACHABLE();
> > +}
> > +
> >  /*
> >   * Local variables:
> >   * mode: C
> > diff --git a/xen/arch/arm/arm64/traps.c b/xen/arch/arm/arm64/traps.c
> > index 9113a15c7a..4de2206801 100644
> > --- a/xen/arch/arm/arm64/traps.c
> > +++ b/xen/arch/arm/arm64/traps.c
> > @@ -18,9 +18,12 @@
> >  
> >  #include <xen/lib.h>
> >  
> > +#include <asm/current.h>
> >  #include <asm/hsr.h>
> > +#include <asm/mmio.h>
> >  #include <asm/system.h>
> >  #include <asm/processor.h>
> > +#include <asm/regs.h>
> >  
> >  #include <public/xen.h>
> >  
> > @@ -44,6 +47,44 @@ void do_bad_mode(struct cpu_user_regs *regs, int reason)
> >      panic("bad mode\n");
> >  }
> >  
> > +void post_increment_register(const struct instr_details *instr)
> > +{
> > +    struct cpu_user_regs *regs = guest_cpu_user_regs();
> > +    register_t val;

val needs to be initialized:

traps.c: In function ‘post_increment_register’:
traps.c:79:9: error: ‘val’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
   79 |     val += instr->imm9;
      |     ~~~~^~~~~~~~~~~~~~



> > +    /*
> > +     * Handle when rn = SP
> > +     * Refer ArmV8 ARM DDI 0487G.b, Page - D1-2463 "Stack pointer register selection"
> > +     * t = SP_EL0
> > +     * h = SP_ELx
> > +     * and M[3:0] (Page - C5-474 "When exception taken from AArch64 state:")
> > +     */
> > +    if (instr->rn == 31 )
> > +    {
> > +        if ( (regs->cpsr & PSR_MODE_MASK) == PSR_MODE_EL1h )
> > +            val = regs->sp_el1;
> > +        else if ( ((regs->cpsr & PSR_MODE_MASK) == PSR_MODE_EL1t) ||
> > +                    ((regs->cpsr & PSR_MODE_MASK) == PSR_MODE_EL0t) )
> > +            val = regs->sp_el0;
> > +        else
> > +            ASSERT_UNREACHABLE();
> > +    }
> > +    else
> > +        val = get_user_reg(regs, instr->rn);
> > +
> > +    val += instr->imm9;
> > +
> > +    if ( instr->rn == 31 )
> > +    {
> > +        if ( (regs->cpsr & PSR_MODE_MASK) == PSR_MODE_EL1h )
> > +            regs->sp_el1 = val;
> > +        else
> > +            regs->sp_el0 = val;
> > +    }
> > +    else
> > +        set_user_reg(regs, instr->rn, val);
> > +}
> > +
> >  /*
> >   * Local variables:
> >   * mode: C
> > diff --git a/xen/arch/arm/decode.h b/xen/arch/arm/decode.h
> > index fe7512a053..5efd72405e 100644
> > --- a/xen/arch/arm/decode.h
> > +++ b/xen/arch/arm/decode.h
> > @@ -52,7 +52,17 @@ union instr {
> >  #define POST_INDEX_FIXED_MASK   0x3B200C00
> >  #define POST_INDEX_FIXED_VALUE  0x38000400
> >  
> > -/* Decode an instruction from pc
> > +enum instr_decode_state
> > +{
> > +    INSTR_ERROR, /* Error encountered while decoding the instruction */
> > +    INSTR_VALID, /* ISS is valid, so there is no need to decode */
> > +    INSTR_SUCCESS, /* Instruction is decoded successfully */
> > +    INSTR_IGNORE, /* Instruction is to be ignored (similar to NOP) */
> > +    INSTR_RETRY /* Instruction is to be retried */
> > +};
> > +
> > +/*
> > + * Decode an instruction from pc
> >   * /!\ This function is intended to decode an instruction. It considers that the
> >   * instruction is valid.
> >   *
> > diff --git a/xen/arch/arm/include/asm/traps.h b/xen/arch/arm/include/asm/traps.h
> > index 2ed2b85c6f..95c46ad391 100644
> > --- a/xen/arch/arm/include/asm/traps.h
> > +++ b/xen/arch/arm/include/asm/traps.h
> > @@ -109,6 +109,8 @@ static inline register_t sign_extend(const struct hsr_dabt dabt, register_t r)
> >      return r;
> >  }
> >  
> > +void post_increment_register(const struct instr_details *instr);
> > +
> >  #endif /* __ASM_ARM_TRAPS__ */
> >  /*
> >   * Local variables:
> > diff --git a/xen/arch/arm/io.c b/xen/arch/arm/io.c
> > index a289d393f9..1011327058 100644
> > --- a/xen/arch/arm/io.c
> > +++ b/xen/arch/arm/io.c
> > @@ -95,6 +95,59 @@ static const struct mmio_handler *find_mmio_handler(struct domain *d,
> >      return handler;
> >  }
> >  
> > +enum instr_decode_state try_decode_instruction(const struct cpu_user_regs *regs,
> > +                                               mmio_info_t *info)
> > +{
> > +    int rc;
> > +
> > +    /*
> > +     * Erratum 766422: Thumb store translation fault to Hypervisor may
> > +     * not have correct HSR Rt value.
> > +     */
> > +    if ( check_workaround_766422() && (regs->cpsr & PSR_THUMB) &&
> > +         info->dabt.write )
> > +    {
> > +        rc = decode_instruction(regs, info);
> > +        if ( rc )
> > +        {
> > +            gprintk(XENLOG_DEBUG, "Unable to decode instruction\n");
> > +            return INSTR_ERROR;
> > +        }
> 
> It looks like we want a "return" here? But it should work either way
> because it should return with the if ( info->dabt.valid ) check right
> after anyway.
> 
> 
> > +    }
> > +
> > +    /* If ISS is valid, then no need to decode the instruction any further */
> > +    if (info->dabt.valid)
> > +        return INSTR_VALID;
> 
> code style
> 
> 
> > +    /*
> > +     * Xen should not decode the instruction when it was trapped due to
> > +     * translation fault.
> > +     */
> > +    if ( info->dabt.s1ptw )
> > +        return INSTR_RETRY;
> > +
> > +    /*
> > +     * If the fault occurred due to cache maintenance or address translation
> > +     * instructions, then Xen needs to ignore these instructions.
> > +     */
> > +    if ( info->dabt.cache )
> > +        return INSTR_IGNORE;
> > +
> > +    /*
> > +     * Armv8 processor does not provide a valid syndrome for decoding some
> > +     * instructions. So in order to process these instructions, Xen must
> > +     * decode them.
> > +     */
> > +    rc = decode_instruction(regs, info);
> > +    if ( rc )
> > +    {
> > +        gprintk(XENLOG_ERR, "Unable to decode instruction\n");
> > +        return INSTR_ERROR;
> > +    }
> > +    else
> > +        return INSTR_SUCCESS;
> > +}
> > +
> >  enum io_state try_handle_mmio(struct cpu_user_regs *regs,
> >                                const union hsr hsr,
> >                                paddr_t gpa)
> > @@ -106,14 +159,14 @@ enum io_state try_handle_mmio(struct cpu_user_regs *regs,
> >          .gpa = gpa,
> >          .dabt = dabt
> >      };
> > +    int rc;
> > +    enum instr_decode_state state;
> >  
> >      ASSERT(hsr.ec == HSR_EC_DATA_ABORT_LOWER_EL);
> >  
> >      handler = find_mmio_handler(v->domain, info.gpa);
> >      if ( !handler )
> >      {
> > -        int rc;
> > -
> >          rc = try_fwd_ioserv(regs, v, &info);
> >          if ( rc == IO_HANDLED )
> >              return handle_ioserv(regs, v);
> > @@ -121,31 +174,46 @@ enum io_state try_handle_mmio(struct cpu_user_regs *regs,
> >          return rc;
> >      }
> >  
> > -    /* All the instructions used on emulated MMIO region should be valid */
> > -    if ( !dabt.valid )
> > +    state = try_decode_instruction(regs, &info);
> 
> We still have the issue that try_fwd_ioserv (called above) doesn't work
> properly if !dabt.valid. I think we need to call try_decode_instruction
> and do the "state" checks before find_mmio_handler/try_fwd_ioserv.
> 
> 
> > +    /*
> > +     * If the instruction was to be ignored by Xen, then it should return to the
> > +     * caller which will increment the PC, so that the guest can execute the
> > +     * next instruction.
> > +     */
> > +    if ( state == INSTR_IGNORE )
> > +        return IO_HANDLED;
> > +    /*
> > +     * If Xen could not decode the instruction for any reason, then it should
> > +     * ask the caller to abort the guest.
> > +     */
> > +    else if ( state == INSTR_ERROR )
> >          return IO_ABORT;
> > +    /* When the instruction needs to be retried by the guest */
> > +    else if ( state == INSTR_RETRY )
> > +        return IO_UNHANDLED;
> >  
> >      /*
> > -     * Erratum 766422: Thumb store translation fault to Hypervisor may
> > -     * not have correct HSR Rt value.
> > +     * At this point, we know that the instruction is either valid or has been
> > +     * decoded successfully. Thus, Xen should be allowed to execute the
> > +     * instruction on the emulated MMIO region.
> >       */
> > -    if ( check_workaround_766422() && (regs->cpsr & PSR_THUMB) &&
> > -         dabt.write )
> > -    {
> > -        int rc;
> > +    if ( info.dabt.write )
> > +        rc = handle_write(handler, v, &info);
> > +    else
> > +        rc = handle_read(handler, v, &info);
> >  
> > -        rc = decode_instruction(regs, &info);
> > -        if ( rc )
> > -        {
> > -            gprintk(XENLOG_DEBUG, "Unable to decode instruction\n");
> > -            return IO_ABORT;
> > -        }
> > +    /*
> > +     * If the instruction was decoded and has executed successfully on the MMIO
> > +     * region, then Xen should execute the next part of the instruction. (for eg
> > +     * increment the rn if it is a post-indexing instruction.
> > +     */
> > +    if ( (rc == IO_HANDLED) && (state == INSTR_SUCCESS) )
> > +    {
> > +        post_increment_register(&info.dabt_instr);
> >      }
> 
> We need to call post_increment_register also from arch_ioreq_complete_mmio for the IOREQ case.
> 
> 
> > -    if ( info.dabt.write )
> > -        return handle_write(handler, v, &info);
> > -    else
> > -        return handle_read(handler, v, &info);
> > +    return rc;
> >  }
> >  
> >  void register_mmio_handler(struct domain *d,
> > -- 
> > 2.17.1
> > 
> 
--8323329-788060652-1643849106=:4074808--


From xen-devel-bounces@lists.xenproject.org Thu Feb 03 04:31:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 03 Feb 2022 04:31:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264478.457578 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFTmG-0006YT-BW; Thu, 03 Feb 2022 04:31:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264478.457578; Thu, 03 Feb 2022 04:31:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFTmG-0006Y4-4F; Thu, 03 Feb 2022 04:31:24 +0000
Received: by outflank-mailman (input) for mailman id 264478;
 Thu, 03 Feb 2022 04:31:23 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nFTmF-0006Xu-Ia; Thu, 03 Feb 2022 04:31:23 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nFTmF-0004gB-G9; Thu, 03 Feb 2022 04:31:23 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nFTmE-0006kr-R2; Thu, 03 Feb 2022 04:31:22 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nFTmE-0001qk-QH; Thu, 03 Feb 2022 04:31:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=7ecG/oqJIh2naRyaLOqJg6kM4VdZFGZgPDkSEaVKULQ=; b=I2s0ZWIxV1fJzZroNi1HAoEf3N
	HBGFAoz0lrv5ZMOKWENsXwUEfOM6vHk/K3O2RK9ohliCVVulN8m3rIwjOgyRNflXvqEvlv4+hj9ht
	t3tNoyxH4VHUfW42QgPRwE4cBb0Rk2Xx+NCxxTZb8NGU2YStbilpqZZwo7SFzCuK1REA=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167988-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 167988: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=27bb0b18c208ecd4c0deda6aad28616d73e4133d
X-Osstest-Versions-That:
    linux=9f7fb8de5d9bac17b6392a14af40baf555d9129b
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 03 Feb 2022 04:31:22 +0000

flight 167988 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167988/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167979
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167979
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167979
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167979
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167979
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167979
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167979
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167979
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                27bb0b18c208ecd4c0deda6aad28616d73e4133d
baseline version:
 linux                9f7fb8de5d9bac17b6392a14af40baf555d9129b

Last test of basis   167979  2022-02-01 21:12:14 Z    1 days
Testing same since   167988  2022-02-02 18:11:17 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andre Przywara <andre.przywara@arm.com>
  Andy Shevchenko <andriy.shevchenko@linux.intel.com>
  Florian Fainelli <f.fainelli@gmail.com>
  Gerhard Engleder <gerhard@engleder-embedded.com>
  Grace Kao <grace.kao@intel.com>
  Hans de Goede <hdegoede@redhat.com>
  Horatiu Vultur <horatiu.vultur@microchip.com>
  Julian Braha <julianbraha@gmail.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Linus Walleij <linus.walleij@linaro.org>
  Michał Winiarski <michal.winiarski@intel.com>
  Mika Westerberg <mika.westerberg@linux.intel.com>
  Rafał Miłecki <rafal@milecki.pl>
  Shuah Khan <skhan@linuxfoundation.org>
  Steen Hegelund <Steen.Hegelund@microchip.com>
  Łukasz Bartosik <lb@semihalf.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   9f7fb8de5d9b..27bb0b18c208  27bb0b18c208ecd4c0deda6aad28616d73e4133d -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Thu Feb 03 06:50:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 03 Feb 2022 06:50:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264489.457589 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFVwt-0002vM-44; Thu, 03 Feb 2022 06:50:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264489.457589; Thu, 03 Feb 2022 06:50:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFVwt-0002vF-1B; Thu, 03 Feb 2022 06:50:31 +0000
Received: by outflank-mailman (input) for mailman id 264489;
 Thu, 03 Feb 2022 06:50:29 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=nHU3=SS=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nFVwr-0002v9-PN
 for xen-devel@lists.xenproject.org; Thu, 03 Feb 2022 06:50:29 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 92540d03-84bd-11ec-8eb8-a37418f5ba1a;
 Thu, 03 Feb 2022 07:50:28 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id D6E7C1F398;
 Thu,  3 Feb 2022 06:50:27 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 770D91330C;
 Thu,  3 Feb 2022 06:50:27 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id GCgWGzN7+2EGaAAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 03 Feb 2022 06:50:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 92540d03-84bd-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1643871027; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=1942n+vtW/VdqlOdcFNaQCCIWriMC0N8GhwC/HIvrAo=;
	b=Zn8MSUdUuXmerFBTYpg/TvWMR4Gt1nA6yI8isYfwGZb/ReZLZgUWcEW+ELbsVrvY61vH/6
	Md8mTjaZjATynsDOfv3nlRLvnEVe3XkJBK7Gan0XLtvrm2D9RJRbUmblf6TcSxWJ/wll2x
	DYezKPbqA4auxUo6uL5/IQHLC+c5cQA=
Message-ID: <91fc3a98-1bc4-74be-9567-0880af12765f@suse.com>
Date: Thu, 3 Feb 2022 07:50:26 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Subject: Re: [PATCH] xen/x2apic: enable x2apic mode when supported for HVM
Content-Language: en-US
To: Roger Pau Monne <roger.pau@citrix.com>, linux-kernel@vger.kernel.org
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,
 x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
 xen-devel@lists.xenproject.org
References: <a34aff19-4530-7f44-c849-4b3eb2aa3d00@oracle.com>
 <20220121090146.13697-1-roger.pau@citrix.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <20220121090146.13697-1-roger.pau@citrix.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------aLfNpwznLJzQ7dZU0wTISsif"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------aLfNpwznLJzQ7dZU0wTISsif
Content-Type: multipart/mixed; boundary="------------fdm2Uc58iwQWkMjO0RCl8H0d";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Roger Pau Monne <roger.pau@citrix.com>, linux-kernel@vger.kernel.org
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,
 x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
 xen-devel@lists.xenproject.org
Message-ID: <91fc3a98-1bc4-74be-9567-0880af12765f@suse.com>
Subject: Re: [PATCH] xen/x2apic: enable x2apic mode when supported for HVM
References: <a34aff19-4530-7f44-c849-4b3eb2aa3d00@oracle.com>
 <20220121090146.13697-1-roger.pau@citrix.com>
In-Reply-To: <20220121090146.13697-1-roger.pau@citrix.com>

--------------fdm2Uc58iwQWkMjO0RCl8H0d
Content-Type: multipart/mixed; boundary="------------PfFntwV0FJxIGINPPVj5Lmze"

--------------PfFntwV0FJxIGINPPVj5Lmze
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMjEuMDEuMjIgMTA6MDEsIFJvZ2VyIFBhdSBNb25uZSB3cm90ZToNCj4gVGhlcmUncyBu
byBwb2ludCBpbiBkaXNhYmxpbmcgeDJBUElDIG1vZGUgd2hlbiBydW5uaW5nIGFzIGEgWGVu
IEhWTQ0KPiBndWVzdCwganVzdCBlbmFibGUgaXQgd2hlbiBhdmFpbGFibGUuDQo+IA0KPiBS
ZW1vdmUgc29tZSB1bm5lZWRlZCB3cmFwcGluZyBhcm91bmQgdGhlIGRldGVjdGlvbiBmdW5j
dGlvbnMsIGFuZA0KPiBzaW1wbHkgcHJvdmlkZSBhIHhlbl94MmFwaWNfYXZhaWxhYmxlIGhl
bHBlciB0aGF0J3MgYSB3cmFwcGVyIGFyb3VuZA0KPiB4MmFwaWNfc3VwcG9ydGVkLg0KPiAN
Cj4gU2lnbmVkLW9mZi1ieTogUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5j
b20+DQoNClB1c2hlZCB0byB4ZW4vdGlwLmdpdCBmb3ItbGludXMtNS4xN2ENCg0KDQpKdWVy
Z2VuDQo=
--------------PfFntwV0FJxIGINPPVj5Lmze
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------PfFntwV0FJxIGINPPVj5Lmze--

--------------fdm2Uc58iwQWkMjO0RCl8H0d--

--------------aLfNpwznLJzQ7dZU0wTISsif
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmH7ezIFAwAAAAAACgkQsN6d1ii/Ey/W
cwf/XTOZpxy5askUaUkKFp10Y+CsYPag6GEYsp3sxO74cpXz154NJNJDJarSY3ECmy8HU5xxX7EQ
3nBaBniu4BoIHrbAyRpw18fgI5XYADMbJQFJI9C/7z+wCJXFqbRSUw/oUSU++6n7avCEQRERJKJN
gG50cgbQE4Zg+/RvFC0VhBX8uMdSebSim2vi9nq5UIGbOZgZO/a+G3ZdBh93R2kG7OfMQeknFP3E
IYgRgYb2o183+V7LXcT+yZ/aUU9dVVO0SiZAyMrahB21DhOxD3jQLTADJAVFpN6Ifq3ce3U52FNn
adBE0Q5kL5lwyBy8jDx/JHL3bib7QkpYJc7M+xxhLA==
=Uq/7
-----END PGP SIGNATURE-----

--------------aLfNpwznLJzQ7dZU0wTISsif--


From xen-devel-bounces@lists.xenproject.org Thu Feb 03 08:01:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 03 Feb 2022 08:01:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264506.457611 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFX3Y-0001zK-A4; Thu, 03 Feb 2022 08:01:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264506.457611; Thu, 03 Feb 2022 08:01:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFX3Y-0001zD-73; Thu, 03 Feb 2022 08:01:28 +0000
Received: by outflank-mailman (input) for mailman id 264506;
 Thu, 03 Feb 2022 08:01:27 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nFX3X-0001z3-JU; Thu, 03 Feb 2022 08:01:27 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nFX3X-0000i3-HA; Thu, 03 Feb 2022 08:01:27 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nFX3X-0000WQ-4J; Thu, 03 Feb 2022 08:01:27 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nFX3X-0000s8-3p; Thu, 03 Feb 2022 08:01:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=++3EuiXvwPZqY4fvFompvSU24Z/PVFH1GfAns/NJMpg=; b=nkB9qrB8YAHtU9f7DLvkiPceCD
	1+ViKi5vQLGUUYccv1J8vSsYAWeeW32xF5I9Xb3QVjrtnmh9kqLZU+9SaEeG2iHxO/DKF65zsaBqO
	3E9/fBpHXek8v5cGx6Pgj82VsqgoKZ6GAHQSx4q6lAxrf2sXt5PyuFX3FQrsnE/lzjI0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167990-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 167990: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=b17e0ec72eded037297f34a233655aad23f64711
X-Osstest-Versions-That:
    xen=9ce3ef20b4f085a7dc8ee41b0fec6fdeced3773e
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 03 Feb 2022 08:01:27 +0000

flight 167990 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167990/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167986
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167986
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167986
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167986
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 167986
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 167986
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167986
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167986
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167986
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167986
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167986
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167986
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 xen                  b17e0ec72eded037297f34a233655aad23f64711
baseline version:
 xen                  9ce3ef20b4f085a7dc8ee41b0fec6fdeced3773e

Last test of basis   167986  2022-02-02 10:07:45 Z    0 days
Testing same since   167990  2022-02-02 20:09:48 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
  Jan Beulich <jbeulich@suse.com>
  Luca Fancellu <luca.fancellu@arm.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Sergey Temerkhanov <s.temerkhanov@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   9ce3ef20b4..b17e0ec72e  b17e0ec72eded037297f34a233655aad23f64711 -> master


From xen-devel-bounces@lists.xenproject.org Thu Feb 03 08:31:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 03 Feb 2022 08:31:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264519.457622 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFXWL-0005GT-Ro; Thu, 03 Feb 2022 08:31:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264519.457622; Thu, 03 Feb 2022 08:31:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFXWL-0005GM-Or; Thu, 03 Feb 2022 08:31:13 +0000
Received: by outflank-mailman (input) for mailman id 264519;
 Thu, 03 Feb 2022 08:31:12 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=OTfZ=SS=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nFXWK-0005GG-GS
 for xen-devel@lists.xenproject.org; Thu, 03 Feb 2022 08:31:12 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a3bba573-84cb-11ec-8eb8-a37418f5ba1a;
 Thu, 03 Feb 2022 09:31:10 +0100 (CET)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2104.outbound.protection.outlook.com [104.47.18.104]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-28--7ZxQoXkNYeGBjpGMwFHQw-1; Thu, 03 Feb 2022 09:31:08 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DB8PR04MB6601.eurprd04.prod.outlook.com (2603:10a6:10:104::28)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Thu, 3 Feb
 2022 08:31:06 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.012; Thu, 3 Feb 2022
 08:31:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a3bba573-84cb-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1643877070;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=EmH6CmgN6balkt3iHXRNofwPwrLiRaQR1VbGFCd3aQk=;
	b=V37vsD4qPLqZAL8+WpC5TWYW/Gwjh+iGjeTnx8MyoWhswteqI6fCiw2nLCBFJkGtR1HYps
	3f9o+bLjTZvr48G/bYAHccOA/t92xrlpd9VHhSn3P7BhbkLAOeS7z2leq8eoAX11zil3wH
	I0em2Sg4wpnZ+K7T1Lnry2BUG8xkjno=
X-MC-Unique: -7ZxQoXkNYeGBjpGMwFHQw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=k+PoU9vJvaQ2qsgxe1s8qWQzzdfYpqDMqoGFuLSDaayivr7sHepjtPcG/aDl+qebPAlTbiqSj+ZjgHTRKN+NaK8lQyVxC6wfA5J+PWmwO8a5XgnGgKjRUyWWe0b/cNgzc0W10lR55sQrDbUxzuCCN5aYA77HAdG/7pg5k0e2slAMi1/FrKldxba5QQ3SBPkCnVEdyV250HC+ZbyjCNQYnw1JFuSemVGFKFCc0nusufzqGHfEXABS1klTUXQBK66DJJHurNOV7ZuJBsB+pILM25773rJAiLHT/H5hR3LUmRHvAbSprwv01qBy1fHNbLl3jPuTfRIYvtxVlQqT/Afn7w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=7FiDubBCIc3LEE4HoLRKikwBjbKopWHpDaeCgVS5xNQ=;
 b=He7QmAtxy9bvldZEWO/SqxTKUMy1N3pwafLgaFonHEYF1xngxfuwH2Vq6Oi6+2LCwdgH7pmcsjehPoPVnnERNDJ5AbcDcuNkf3a7EOHsPv/gzsplMrUWLTxOl2qb0TWEDGmmd2+ffupOTcI7jMP/kdTSisMT66jXm2hEq8M9YpZdelJpIWH4eF1bWi1+TrhxwL+IA29t0aFyhNSop8OucI8gR7dw2lCL4qU3axDi04KzdeRYhY+slHwsE1gOIfIqCAfUeqa6rxTZFlAe5IDPBvxuFrbvUhRcX3ODhmggdiIFcNWghYT2f2dhX6jNt0QtBtENCzM4se1IzjCwNhD5cQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <2cd051c8-dac0-998c-cced-401c504ad439@suse.com>
Date: Thu, 3 Feb 2022 09:31:03 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v3 1/2] IOMMU/x86: disallow device assignment to PoD
 guests
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 George Dunlap <george.dunlap@citrix.com>, Paul Durrant <paul@xen.org>,
 Tamas K Lengyel <tamas@tklengyel.com>,
 Petre Pircalabu <ppircalabu@bitdefender.com>,
 Alexandru Isaila <aisaila@bitdefender.com>
References: <6fe7b036-2bdb-b391-4e6c-1b5d7e05a119@suse.com>
 <b0a77526-17f2-a5ab-6f7f-1b3caeb4a59b@suse.com>
 <YfqtlZMAKd/HXsgf@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YfqtlZMAKd/HXsgf@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0087.eurprd06.prod.outlook.com
 (2603:10a6:20b:464::8) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ac61d65f-04f1-4e4c-8048-08d9e6ef8576
X-MS-TrafficTypeDiagnostic: DB8PR04MB6601:EE_
X-Microsoft-Antispam-PRVS:
	<DB8PR04MB66010A853734A4997D4F7321B3289@DB8PR04MB6601.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	mEvvqEFrMAStvu8tqm4SurLGeBJguUqf18DZQ//0WLX0oGpiSe9BVgB0d/oPwEfHBR2GRxbl53h8IIQ68wH5m/lc3od04Em9wIGxColbF1wZBcY0CcFwuEGDFANpVgUy74OOPj9MPjxIE4SpoV0IFn7Fdd1cj9nxoDbW7JI2IhsExGmkZ2Yg0prHjwwh+saHTILVn1Q7nC8y3Ihg43CTfOS0a1O9N5PICMoxNCkafPGwwwheRS2n3kHTitsosXyW0rXL24qMHJpczYbz0OpSdB5WMLFAm8Nz5ARe+8vGJjArA/aBAd8zdoj+GJatfbYGlfcqalcTRIyNnHDRi3Nu7kIIiv1Nsb5N4NKb/1zYF34mpEzh5ve0XqVWxXlCBXvhCZgBP0Pkf1g/ZucZBtSxXC44DEjmo4Jkbqx4r04aBaZl3PutaafcCY6yC1NlvQ32bJLjRBLQXLlTZeEvl7Dm2epi7VBC3DLyHbzRBelSIOE3hUDyPFHdHgli0v8Nv9OhC95D5RBN9KgdnAEYF14NH0kxDQ9Keg1G+5NFuHa1+0XXNY2P8ifZWjHhFHQSe00Ee+SXDP3hxg2QyOeL0UXm1CTtA5jUH0PYp+wt21M6JU0oie266p9+IU3DCX+i4WcCKnQFrSBl6dOSUc1hRbcPlE+P58zaulKsGX7S9hAcFCP7uxgTs4CWkrLbuJqjCn56Aq5CnJAeci4S57iQb7ZgDFX8yveR1lBj7L9HHAaa8yg=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(38100700002)(36756003)(5660300002)(66556008)(86362001)(66946007)(66476007)(8936002)(316002)(2616005)(8676002)(508600001)(31696002)(6512007)(4326008)(6916009)(54906003)(6486002)(6666004)(2906002)(83380400001)(26005)(6506007)(53546011)(186003)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?VdviZpORSaq7XIu+qk9mtBozxSQlkRS2Dc56M1VvEmc47gcLDv4J4dDO5MKB?=
 =?us-ascii?Q?JNwkVZ0EIfwzSU/xJpSgAkg9toioRKv3X3SLDuJvBlS2o70xWQhZtYi5/CAw?=
 =?us-ascii?Q?ckIXGwM1m6dY+5TKQAeOBrEvZKgSE9WUNP2PHQzpv4y/3KnoqP3kIwvg90sW?=
 =?us-ascii?Q?D7b2J6WsuzSHelC+S7t0mihALORPei1+QehP/c1fKWb0XV1jNxrLBKV0Bwel?=
 =?us-ascii?Q?PSTsVWsiYJ8yot6KIDq+K81LSNhsvUvvnHwIqLAmiLowDMhzzwrniqUtyLBr?=
 =?us-ascii?Q?fRfeisfabx7vsNovEVTslMBFSzguPmH5FYm2iNMcXr2E5St7zJLKpIqGc43p?=
 =?us-ascii?Q?vq3CU2rsU8WzmE5bdLPs4zhfSknIm41WhMnQ84cFxrSZk11zHH+Bqj+2nFT3?=
 =?us-ascii?Q?nZOJCJL7W2mg7AU3HtKE0vSsNvkmSL8wyhUSZ7HFz80nist00w5HHS6A9Rud?=
 =?us-ascii?Q?P8Q9xDXdi+ojGC/5arsUbO+w3+vurFn1Lne04mWb1kKxeD+j8l5tDyUyvT89?=
 =?us-ascii?Q?nE2gtXeUsKzIa2MkaplIRnn6472vL9XVF3RPzrbaikJV6+8Cy0htjZTmHDXW?=
 =?us-ascii?Q?vFmkZCQQPSGnvCJSQxM/hTmi+3nqAyjjP61FnufEAovsc+v1CUHzxAggrw/m?=
 =?us-ascii?Q?OHrAbhYBzwIWPNdZUWw726extSGUySJ46OZeenijHxY/iAzpTp3dSGteDpdR?=
 =?us-ascii?Q?nhouCi9V9gk+RZLcqY9fXPFvCBNo+mVhKDUYPcUudJeW9c+xO1BsOwism2W1?=
 =?us-ascii?Q?+8mVePeMpLDHVRbvRZomFr3NSZja/4H/5a5MWyJ1AKngEeR2cp5IETJ7wrXe?=
 =?us-ascii?Q?TtTlXvbFL0kkDiV1qnWj+9sET5KlGkl4tDSefPZNTRV9+ygSlgPfVJf6ixia?=
 =?us-ascii?Q?QJt6UYsZQHA0EZrH6ZmJzVpScTm0BT73aWGDMB0uyKJXRcZvFI+pVBGJE0AP?=
 =?us-ascii?Q?gVfV9TzRQdx7xSaA8TT2MG1maM/sJdhYSTazPnW/vcjsowk27Br9ruzLhJgV?=
 =?us-ascii?Q?qWUZ0lGeCUxZR8pR7uM4lqzFnDn32M4Sxp/tm3n0emTAI9XM9cxJcJVuAQIV?=
 =?us-ascii?Q?QkGAo9ntcY9vTk8jhMaoIZUjhhLdqfGd/+/nLe/oZx1r1V4+HMwP9ICq6L9s?=
 =?us-ascii?Q?WYAkyNKdMxoLkeDSsERGe0k0lYjKfjyn1UqHV/Nqchp0yLx7sPkejbyyKsZF?=
 =?us-ascii?Q?BwVrSEPGL3zspN2kZhc4Na2iMmyw4WohA2BTh8SvfloRj3lOehUaruo9C4Z2?=
 =?us-ascii?Q?rPIWUbbxDfnrmVLlU6qz1B3NM80MhIDYZZFUMpR2XQahb/pGTfqGglB/btx/?=
 =?us-ascii?Q?qE5dHLhyjSnx6aiu1zl9dZE0wrY4shxHCUpd8xumNNmUycFlD0DINn3WwLkO?=
 =?us-ascii?Q?pBqtdYvAm5yp3v/r8zQsZuhJyNso2jWBVnB+yfeUA62y4n3Sh6VSe/17PO6L?=
 =?us-ascii?Q?S7FB3w/51I7RV93QxsCuTFJaDe6T0n9LiSwevo9s5gZYpvNFdNnLy5uXUPH7?=
 =?us-ascii?Q?WyCgUZ+igVHC78grcM0qt5FeWeDdLJt0cvIB+juRxqU8jLbkQNhmDZ+CWrVb?=
 =?us-ascii?Q?1UvmAv7AjAXUZm9d6HASfT9cQ3X5rg8S7CeP+omT0D+fquTWWvnQiSt5Q8rZ?=
 =?us-ascii?Q?od4DA2l85CuqPeJBywXlrb8=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ac61d65f-04f1-4e4c-8048-08d9e6ef8576
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Feb 2022 08:31:06.2531
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JXc7qvXiATLjza68NaRYZxW0ZKJiPQ6Ovot3xqkeoNkWZLfUa+wKUt29Lw/dkSOH6EXTE/Ik9+3vqjXOoqIe1w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6601

On 02.02.2022 17:13, Roger Pau Monn=C3=A9 wrote:
> On Tue, Jan 04, 2022 at 10:41:32AM +0100, Jan Beulich wrote:
>> @@ -359,7 +360,10 @@ p2m_pod_set_mem_target(struct domain *d,
>> =20
>>      ASSERT( pod_target >=3D p2m->pod.count );
>> =20
>> -    ret =3D p2m_pod_set_cache_target(p2m, pod_target, 1/*preemptible*/)=
;
>> +    if ( has_arch_pdevs(d) || cache_flush_permitted(d) )
>=20
> Is it possible to have cache flush allowed without any PCI device
> assigned? AFAICT the iomem/ioport_caps would only get setup when there
> are device passed through?

One can assign MMIO or ports to a guest the raw way. That's not
secure, but functionally explicitly permitted.

> TBH I would be fine if we just say that PoD cannot be used in
> conjunction with an IOMMU, and just check for is_iommu_enable(d) here.
>=20
> I understand it's technically possible for PoD to be used together
> with a domain that will later get a device passed through once PoD is
> no longer in use, but I doubt there's much value in supporting that
> use case, and I fear we might be introducing corner cases that could
> create issues in the future. Overall I think it would be safer to just
> disable PoD in conjunction with an IOMMU.

I consider it wrong to put in place such a restriction, but I could
perhaps accept you and Andrew thinking this way if this was the only
aspect playing into here. However, this would then want an equivalent
tools side check, and while hunting down where to make the change as
done here, I wasn't able to figure out where that alternative
adjustment would need doing. Hence I would possibly(!) buy into this
only if someone else took care of doing so properly in the tool stack
(including the emission of a sensible error message).

Finally this still leaves out the "raw MMIO / ports" case mentioned
above.

>> --- a/xen/common/vm_event.c
>> +++ b/xen/common/vm_event.c
>> @@ -639,7 +639,7 @@ int vm_event_domctl(struct domain *d, st
>> =20
>>              rc =3D -EXDEV;
>>              /* Disallow paging in a PoD guest */
>> -            if ( p2m_pod_entry_count(p2m_get_hostp2m(d)) )
>> +            if ( p2m_pod_active(d) )
>=20
> Isn't it fine to just check for entry_count like you suggest in the
> change to libxl?

I didn't think it would be, but I'm not entirely sure: If paging was
enabled before a guest actually starts, it wouldn't have any entries
but still be a PoD guest if it has a non-empty cache. The VM event
folks may be able to clarify this either way. But ...

> This is what p2m_pod_entry_count actually does (rather than entry_count |=
=C2=A0count).

... you really mean "did" here, as I'm removing p2m_pod_entry_count()
in this patch. Of course locking could be added to it instead (or
p2m_pod_get_mem_target() be used in its place), but I'd prefer if we
could go with just the check which precisely matches what the comment
says (IOW otherwise I'd need to additionally know what exactly the
comment is to say).

Jan



From xen-devel-bounces@lists.xenproject.org Thu Feb 03 08:56:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 03 Feb 2022 08:56:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264526.457633 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFXuc-0007fI-UL; Thu, 03 Feb 2022 08:56:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264526.457633; Thu, 03 Feb 2022 08:56:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFXuc-0007fB-RP; Thu, 03 Feb 2022 08:56:18 +0000
Received: by outflank-mailman (input) for mailman id 264526;
 Thu, 03 Feb 2022 08:56:16 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=OTfZ=SS=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nFXua-0007f5-PC
 for xen-devel@lists.xenproject.org; Thu, 03 Feb 2022 08:56:16 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 24632816-84cf-11ec-8f75-fffcc8bd4f1a;
 Thu, 03 Feb 2022 09:56:15 +0100 (CET)
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur01lp2058.outbound.protection.outlook.com [104.47.0.58]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-7-n2Ltb0jtPiaJWMntj6JDPA-2; Thu, 03 Feb 2022 09:56:12 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM8PR04MB7811.eurprd04.prod.outlook.com (2603:10a6:20b:236::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Thu, 3 Feb
 2022 08:56:10 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.012; Thu, 3 Feb 2022
 08:56:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 24632816-84cf-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1643878574;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=24UZRQHWuLcZR7O/O/nTs8iv2Y3SejlgISfyy5eQiK0=;
	b=BF6sMqU7zpMPraJxr4zhs6rkbXHefawRBPnMJxnJWJRNYk9hTpnpJ4IPpKDsarWkcTKn6e
	rvH0qaAVbS8uT8WpE9eCAlHzWxJNiGCB6nJ32xmi2t1ZKKs1qPOgdWMim0eWM9VPs8uUst
	Bp6Cssat4lhbwMSH9k1TMQcie4FAglk=
X-MC-Unique: n2Ltb0jtPiaJWMntj6JDPA-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=kiwcUDkFJ6KSysAWQlPEQeDFfuRa2ZFDw+PEGc6grrMKSnVz3pWuxgXviUsa7Ym7GEvr1AtgrYEE4CMjps3gVeZwl4g4dIIRbufxszz+dsRmVs/6OEe11yKn6yMzTBtJjeXXailf6hNVxU8IsN9NEUViX0ngNtrallcjZy1Sqi30ln4Hg7rUwod6V1+0DbrpAKx1OSU6DfdNPJQtLogZqpfD96cLLBNE5aq4vdZlof1gJqZ6zoqWoXCm4av4AUvpJj3/hMOaAWaHMHKmLOrQd4DfUCsixyAHQZrh79rwZ3/ecA4EdtAN/nByFh3wsWgcKIKwtkqwGnWYg9mh6tUjwA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=24UZRQHWuLcZR7O/O/nTs8iv2Y3SejlgISfyy5eQiK0=;
 b=LAXoQyTCzITqxoA2B3menjh7cS2picI8rmwXbuzWMuR5KlPICDS71/IRcsV1bg1fPLD5Zywfu3845SQtW/Q7zxGV/FeA7IY5ak6woXzpsCyuAFXNncLjUkc/jJUjEii/2TVJb5Afel5/WZlwzxLgggqDBIphdxymWnaIsoh0a7OOnv+sbTLhXDG/y4CyieACFetcn184Ed5I/Mh4Rvo6D6XP+AGj50f1c9nrK3R73C/RGK0qhBmvDgjCY3U/BKflQ65uSkIHCNiIYjCD66ShtOslPzqX4FAKwJMyW31qZ98vrL/02MO6/kDq6vuTDefeUSlUo1xTHRW8DEJqjOmb2Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <3a8a7290-5cd1-da7a-46df-5cbe1755036e@suse.com>
Date: Thu, 3 Feb 2022 09:56:08 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Content-Language: en-US
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Anthony Perard <anthony.perard@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH 4.16 / 4.15] MAINTAINERS: Anthony is stable branch tools
 maintainer
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0180.eurprd04.prod.outlook.com
 (2603:10a6:20b:331::35) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9a5bf41a-e38b-4e4b-c9b1-08d9e6f3063b
X-MS-TrafficTypeDiagnostic: AM8PR04MB7811:EE_
X-Microsoft-Antispam-PRVS:
	<AM8PR04MB7811310F09BB0491ADC151CFB3289@AM8PR04MB7811.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2803;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	3X4Mb1ot8qbDaSJvSuZeIwvFxzHWxtEm10aWhOZgqwmAw/ikT/H4L5pEjFalF5oJvIjc6qGtrGquRnTUx5DX5SxTpSxV8dDXex3dxOH0FwoXqr3FoGJLhtNtx9cV7JJUbF2uH3Bq8MalT3HG1PR7VwQEd7SS6pQ/bnoSnwMD5KTOsDQ9I6aZ0PtQA7VDFvaESG8hJApeunBK06yNdljvYGAbVOPlhaFm88M4Km6/LDl50DYoGd/BLfrj43Y5PCxiqOLyhnSiyt23gUI+/YFAWvFGDpU/s81mqydrsjvTowtvA+3Qyu+sUzhNdI9ChcBcyIZsEDBdHmAaruXFcWriPflbqSgSNawImvzc7ghAMkbjm6IqCfGanxI6u6v4K1Uu5JHaLW2CvCbDK7vrx6x0R0OuILSFUTBga6yxdlpk2Tul+Na5wjFhvvKgiCfkRzOFd79gPNWZcnt2TOdsgfOyOrysr4Bov4XSyxlg+PH112JsMPHxUyEnGRzRYl0AzFdMrALl4eUtCRNDYxi2moaT8i4+NSVO6mhPvTsIKAyb0eVZ52hDK/bhYe0mDTEsTK1JmCgpoxvdHKLzGKJ8NPiR/loJ5kduqASkcOtqr2cmiEZLTrRZ2rIR76urzvzy6OooKkCoxYPcUL7BnpWrF3mB3WhlugIFFkxsvN9LS23BzXD0V6pOzDOBnuViZjSvOWj8A//gZ+YEtKzb30YII4vn1qwcFi3ILCT/2X+KD1DGtOT6pVlxpfxMombU+/GuVL6S
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(4744005)(6916009)(86362001)(316002)(31696002)(66476007)(8936002)(2906002)(4326008)(66946007)(36756003)(66556008)(5660300002)(8676002)(38100700002)(31686004)(2616005)(26005)(83380400001)(508600001)(6512007)(6506007)(6486002)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Rkt2L1Fnd3dLZnc2OU83Y0dkbjQzaFcxTmlMYTJIMjkxdGlnUHMwamRCUHRD?=
 =?utf-8?B?c09iZGwrV2lOcDhmUmdCL3RhSEhBeU13aEJlQ1VYaFJNQ2p2NlJVckRzM0Z4?=
 =?utf-8?B?dGM4Q1pIemFhSi90Lzc0YlJxRGljN20za25QdlVpZDZPQm5uOHlHNFhNQnV0?=
 =?utf-8?B?cW13UjBJaG9hQ1dHNlNpNHZlYWpLZWFMQ2ovcWpKaGplU0M0VmR3VHZVNU85?=
 =?utf-8?B?WTZteDBuSllDSlIwb21TRmVlVkR2UEhaNm1Cb2VJK1FlNHkwN3RRdGc4ZDNu?=
 =?utf-8?B?em5sejdBcHgvZGhtUWttelpoeUI0NDdLbDV4MkZoSy9adWoveEc2bXhRaTJZ?=
 =?utf-8?B?TFl0K1ZETGZoTlBZQkkvcEJEYUlQdlJEbnQ1RDlBWVRtMmg2OGNSamVKaS9C?=
 =?utf-8?B?NktpUjh3MU9NcFFveTdLblVESWtEVy9sNWQydXp5YXM1VDV0dTI4cEIxd0h4?=
 =?utf-8?B?MDlzNmVteUtRcGU5OCttT0Eyb3JzSXg5MzRjZk5xM2ZOMHEwbGM3TE4yRGVS?=
 =?utf-8?B?NjdXTldFNGhGQlVITWJxZU51UGwrTVBQcVpKb1k2dC9vaW9QT0tUM2pVdXpa?=
 =?utf-8?B?UlNCM2hKVENyNUJ3RGZwdHdXNkkrRHlLdG9EVlZOcnY2QzltTGh4WXJ2Qi90?=
 =?utf-8?B?b3hQWENWUFY3TURBb1d3dHo4RWxydjQ5eUFYQWhMSkRIMHE3bkhmT1JCaFJu?=
 =?utf-8?B?S1ZDQWpvb0hVMlFOOE42QjRHMlJwcHowNDJTbjBxdlJURzYvbVUzZUIvZFk0?=
 =?utf-8?B?MVUyT09QSlVNRzJwdXM3UXVmTDZGWWlKM0MwQ0crOUhoNHB1VysxcUdIRHlJ?=
 =?utf-8?B?VmpaUFlaMG9qTnBZR3ZCU2RnUUpSSG1LMkY1cDRpeVlPR2NPWGxnMzJSL1BO?=
 =?utf-8?B?bkhhVzM5YzZLc29FUXdLM0VqcWcwbEJoZEhSeWp5ejhsSWI0VEFCMmx5RmZt?=
 =?utf-8?B?UWN6ZFRtWVl5eHlCdzJvV3FRY0lZRm9IR0lYNDU3dGtWbjlHNDRDZDdDTmNS?=
 =?utf-8?B?dm1GdWNVVEJCaGlCeTJUNk9yTm1WQlkxN3V3MS9oOHlkaitQd0REd3pnTzha?=
 =?utf-8?B?RVJsTU1jcnVCc0FIVFVldnhydUhVWndOTTBCNE1xczg5MWd3cnRpS3FaWDBp?=
 =?utf-8?B?NGVXcUZHNVVML3pUSlVSWHJnMWVTdGFYZGJ4TlNKYU9qcDl6dFNCTnRHMWt3?=
 =?utf-8?B?NHk3Yk1EMUk5cE1QSlQyd0VKY3orbTlXa1QxdWI2Um14UStvbWd2ZlFEalJL?=
 =?utf-8?B?NStHY1N2Rm9Ha3N0dDYxRkE4UU55VnhyRU81c2RtTm5CekhYNnRxL2V1N3hw?=
 =?utf-8?B?U3g5Vm5JTDZ1ai9IYW9PbVRXZ2p6RjYxRmYrd3JNMU9hNTlTWUV5K0UyOXhP?=
 =?utf-8?B?ZFBDU1prdjQ2dllKWHNhZS9VT203ZmVzNW1Qb0FUVUQxWGVOYXRRS0Racysz?=
 =?utf-8?B?Yzl0YjhhaE0vK3VtQVVRcml4ME44VERlOHFxSU1QZ25iTVM4Y0xyOWhvVXJv?=
 =?utf-8?B?WDRlNjZDc281NGJ1RXNRd3ZhTlhUY056OHJwbFBSRUV0TkowWVFUQ1h3VkRY?=
 =?utf-8?B?c1BaVG9Sb2QwTmt2TmcxdkVTN2k5d20vQ0FTVjExUVhiZmp0R1JKa29kdEJG?=
 =?utf-8?B?M1lSTGpwM1hUTk12bGRJbUljS1h3MlhVQ2llZU5LUHdXQTYrR2J4TnpFUldY?=
 =?utf-8?B?Q3pQV3ZHWnlydGVMRUNHTHpBanZhRzNES1Q3SDFoaDRmME5sZERvTmlHQjZ2?=
 =?utf-8?B?b2J4WnV3NWNOVWZZRjh4eDB2MU5pNWZLemdzT0M4dVVXUWhhaU15bUZsN0lz?=
 =?utf-8?B?b2txMXU0Zi9mR2hQK1ZqSXFqNkU3MWx5MGthaVJjNUFOaUsxNFVYbWJBYlA2?=
 =?utf-8?B?ZXUxR2xEVzdTeVlpcHlPVnl0WFhyT08zOHg4Wmw3Qy9lZVdVcUdJNGFyQmZQ?=
 =?utf-8?B?Q2d0VTM1enpwV1pwNmQzUlc5UzcwZnE1N1hHcUpqeUs0cjUvUGt4d1h1SFN4?=
 =?utf-8?B?cS9mSUZxdlB1NEY4R1RVK1ZPNHM5M0xNb1RPR0xZNEk4MEJaamFSSW8wRmht?=
 =?utf-8?B?MHUxcDVQTUkxOTBtMWp6ZHllODVSdmdpZnNWTG1SYUdTL3ZJTUxPNW5zWFc2?=
 =?utf-8?B?NkV0TGtVQ3Y0Q3AwZEJNRFZHd3FldjVhSDMra1lRWFd4WXJpbTFHeDR5eVVP?=
 =?utf-8?Q?NzPgqWPPTMUW1Je+AGk9qeU=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9a5bf41a-e38b-4e4b-c9b1-08d9e6f3063b
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Feb 2022 08:56:10.7377
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ibk/S71TdyzEEQ3LiECd4Q9nRgViCk6BndiM5R07MLOvDDTU8vi1d7PvcPgJZHG3PkWGlBXepMikFoA5qA3Baw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7811

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -60,7 +60,7 @@ The maintainer for this branch is:
 
 Tools backport requests should also be copied to:
 
-	TODO - Loooking for new tools stable maintainer
+	Anthony Perard <anthony.perard@citrix.com>
 
 
 	Unstable Subsystem Maintainers



From xen-devel-bounces@lists.xenproject.org Thu Feb 03 09:04:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 03 Feb 2022 09:04:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264533.457644 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFY2X-0000kU-QL; Thu, 03 Feb 2022 09:04:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264533.457644; Thu, 03 Feb 2022 09:04:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFY2X-0000kN-Mh; Thu, 03 Feb 2022 09:04:29 +0000
Received: by outflank-mailman (input) for mailman id 264533;
 Thu, 03 Feb 2022 09:04:28 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mjBt=SS=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nFY2W-0000kH-Ak
 for xen-devel@lists.xenproject.org; Thu, 03 Feb 2022 09:04:28 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 47407957-84d0-11ec-8f75-fffcc8bd4f1a;
 Thu, 03 Feb 2022 10:04:25 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 47407957-84d0-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1643879065;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=22L88+kokrff2C8t6uJKWddo4PWEBQxHLZzX805np1c=;
  b=KZve4AKO4FwFPX1MTD/0ipJDIA6FkAoz9PSnTGJ6PoV5heVsH36scvBQ
   LMP37hNWLXRUEldc2JHEVmOGB50jAFbyqJFeSKXc/qiKKrKyDLsccCz4P
   agtrADRt/If5H2kKwPVeBJ1bbNxX1UaSdmDSGW3C4tbE40djjbOGHYSMh
   Y=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: G0tugr9LC+vytqwYYIeJd3BzB1tQ1CFPDfPyixwhttoEwCQIQKyiU37FxW/80jNfciWUK70D5C
 Q8GLzkr5TD0xNqtJRH5p3/IEbHvsfBwQ7s8eGeV3gtF4OI5hBkD6y3GtrzSbjP2CesN0T6Q8ll
 s8U7cfcEyoFg/KjkUbd+6qKAmgzYoNxzHds9N9reQBZtVJ98w+TPE025wu5eCBCpq9Ti20sLKj
 z7ZOAPzHTuI511oXc95kRJ1sHOM+BsmITinr+h5J60UXpeDczqlJHlVKkrHSs8lM7eH5uKPYtj
 Zf6jEbn4rvjkN6TrAV3e67ie
X-SBRS: 5.2
X-MesageID: 63394355
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:BhW6WaBEWLvIARVW/5fkw5YqxClBgxIJ4kV8jS/XYbTApD12hmcEy
 TNJW2/VPq3fY2ugfNl0aYq+9xsAscfczNc1QQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMo/u1Si6FatANl1ElvU2zbue6WL6s1hxZH1c+En970Uk7wobVv6Yz6TSHK1LV0
 T/Ni5W31G+Ng1aY5UpNtspvADs21BjDkGtwUm4WPJinj3eH/5UhN7oNJLnZEpfNatI88thW5
 Qr05OrREmvxp3/BAz4++1rxWhVirrX6ZWBihpfKMkQLb9crSiEai84G2PQghUh/2wjRx89I6
 8p3vIHvQlY5JIvutcIATEwNe81+FfUuFL7vJHG+tYqYzlHccmuqyPJrZK00FdRGoKAtWzgIr
 KFGbmBWBvyAr7veLLaTUO5ji95lNMD2FIgepmth3XfSCvNOrZXrHf6RtIMDgWpYasZmOvT9Q
 OhHRj9UXRnebDpUMFFUVKMMg7L97pX4W2IB8w/EzUYt2EDPxQl4y5DxM97YfNObSMETlUGdz
 kre52XjCRgePdaC4TCE7n6hiOLJkS7hHokVEdWQ//9xiVyXz0QZCQEaWFW2p/W0kAi1XNc3A
 1Qd5y4GvaU0skuxQbHVXRe1vXqFtR40QMdLHqsx7wTl4rrZ5UOVC3YJShZFacc6r4kmSDoyz
 FiLktj1Qzt1v9W9Vna15rqS6zSoNkAowXQqPHFeC1Ffup+6/d913kmnostf/LCd3uCtQS7J4
 C+wpTVhjOQDl+gp+oOm4gWS696znaThQgkw7wTRe2uq6AJleYKoD7CVBUjnAeVod9jAEATY1
 JQQs43Htb1VU8nR/MCYaLhVRNmUC+C53CowaLKFN70o7HyT9nGqZui8CxkudR4yYq7oldIEC
 XI/WD+9BrcOZBNGjoctOupd7vjGK4C6TrwJsdiPNrJzjmBZLlPvwc2XTRf4M5rRuEYti7ojH
 pyQbNyhC30XYYw+kmbtF7xAj+J6nX9lrY82eXwd5078uVZ5TCXNIYrpzXPUNrxphE96iFm9H
 ylj2zuilEwEDbyWjtj/+o8PN1EaRUXX9ritw/G7gtWre1I8cEl4Uqe56ep4J+RNwvoJ/s+Vo
 CDVchIImTLX2CycQS3XOy8LVV8adcslxZ7NFXZybQ/ANrlKSdvH0ZrzgLNsLOR+qbw+kaUpJ
 xTHEu3Zaslypv380211RbH2rZB4dQTtggSLPiG/ZyM4cYImTAvMkuIItCO2nMXXJibo58Y4v
 ZO60QbXHcgKSwh4VZ6EY/Oz1VKh+3ManbsqDUfPJ9BSfmTq8ZRrdHOt3qNmfZlUJEWR3Cae2
 iaXHQwc+bvHrbgq/YSbnquDtYqoTbdzRxIIA2nB4L+qHiDG5W7/k5RYWeOFcGmFBmP58amvf
 8tPyPT4PKFVlVpGqdMkQb1q0bg/953koLoDllZoG3DCblKKDLJ8IybZgZkT5/MVnrIA4Fm4Q
 EOC/NVeKI6lAsK9HQ5DPhchY8SCyeoQxmvY48MqLRio/yRw5reGDxlfZkHelCxHIbJpG4o52
 uN96tUO4gmyhxd2YNaLiidYqzaFInAaCvh1s5gbBMngixYxy0EEapvZU3ek7JaKYtRKE08rP
 j7L2/aS2+UCnhLPIygpCHzA/etBnpBf6hlFwWgLK0mNhteY1OQ82wdc8GhvQwlYpvmdPzmf5
 oS/25VJGJiz
IronPort-HdrOrdr: A9a23:H3orz6spGEnIXY2C++NSwdgi7skC7IMji2hC6mlwRA09TyXGra
 6TdaUguiMc1gx8ZJhBo7C90KnpewK7yXdQ2/htAV7EZnibhILIFvAZ0WKG+Vzd8kLFh4tgPM
 tbAsxD4ZjLfCdHZKXBkXmF+rQbsaG6GcmT7I+0pRodLnAJV0gj1XYDNu/yKDwGeOAsP+tBKH
 Pz3Lshm9L2Ek5nEPhTS0N1FdTrlpnurtbLcBQGDxko5E2nii6p0qfzF1y90g0FWz1C7L8++S
 yd+jaJqpmLgrWe8FvxxmXT55NZlJ/IzcZCPtWFjowwJi/3ggilSYx9U/mpvSwzosuo9FE2+e
 O87isIDoBW0Tf8b2u1qRzi103J1ysv0WbrzRuijX7qsaXCNXsHIvsEobgcXgrS6kImst05+r
 lMxXilu51eCg6FtDjh5vDTPisa13ackD4Hq6o+nnZfWYwRZPt6tooE5n5YF58GAWbT9J0nKu
 9zF8vRjcwmP29yV0qp/VWH/ebcHEjaRny9Mw0/U42uondrdUlCvgslLJd1pAZFyHo/I6M0kd
 gsfJ4Y042mdfVmH56VMt1xNvdfOla9Mi4kD1jiVGgPNJt3c04l+KSHq4nc2omRCeg1Jd0J6d
 L8bG8=
X-IronPort-AV: E=Sophos;i="5.88,339,1635220800"; 
   d="scan'208";a="63394355"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ByTOdmzmr3RJXoiYNGgYKnCy4TVXCmlIyd2IHmPHIhw8kZgh2myFA9PKixeKOzFiBq6efWwoaopDbEph1JsDfA4eEtpQhrFzYVaQp6pC9Cs06dHfUXhG50BfLfxe2UJfQrwquFqkXoqbBn2pVM3Ph9g+RqZ/2d3RLuJgk40qcmPWNOxuaadOu3ALyJWhaFubMgv8TbGzM7cUPRTovJQXI6V0klMqbh0inhyjKIDVfkTUoeaWawm2ReQfA9PWV7waoWwYnIr+4Iuk72qta92JeOpMG0nFWrLo+3+q3CYHF5JNr2C51jJb8ybGKkJZzkDtUTVNMbYJnVDLBXa0sTh0hg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=zODdNV7ArjOdL7lhGTdFRD4+JJR5lQe2VVceAhdOiIM=;
 b=OkjnSV8Fm9AAXiPjj0+TVUVYmq5yZ3OfpsorPtjZEWoaEAbUc64HaWTRPQeIrkW5thim+KuIkWQPpDdTvTPMD70LAX5X5yVNlvQwvsjTr/B+tcE1QkQ9CVjpz9CaBOUCaphvqMB8eO5I4+3oE+Nt92fJ1YsSpZq+i4TLyzcCQua5h0jUo36AqpPZcBexXkuuZBNV+RyNINzrga07mYXNjru82hHC2xlSzFwUtwLqt+qstwoMaI8kzV0PsOR3jG8qhoiS3qJUF/u2K2grYLhuS+iwrrXbULrscfD2tCxOddMq0YaHQpGptrKEOs++qbu0UYsOWDoNr+ezFspPoRGwyQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=zODdNV7ArjOdL7lhGTdFRD4+JJR5lQe2VVceAhdOiIM=;
 b=kG1MJd74h+HgbXqXrlAFomfo+OAfanYKfhu0DanjeDnxwsqvBbQss1CirH0JtHTtU0D5WdVsWziTO+75hTQoz6V4q/1EmmdIHLo0HpSJIJ1hQxtJWN8wM77C5+ikdFfXIBx6YHCoiAQUGNy9kb0slujqsmz2QX6ISOWQccgZtbA=
Date: Thu, 3 Feb 2022 10:04:07 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Andrew
 Cooper" <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>, George Dunlap
	<george.dunlap@citrix.com>, Paul Durrant <paul@xen.org>, Tamas K Lengyel
	<tamas@tklengyel.com>, Petre Pircalabu <ppircalabu@bitdefender.com>,
	Alexandru Isaila <aisaila@bitdefender.com>
Subject: Re: [PATCH v3 1/2] IOMMU/x86: disallow device assignment to PoD
 guests
Message-ID: <Yfuahx0ntHJ2BQ6x@Air-de-Roger>
References: <6fe7b036-2bdb-b391-4e6c-1b5d7e05a119@suse.com>
 <b0a77526-17f2-a5ab-6f7f-1b3caeb4a59b@suse.com>
 <YfqtlZMAKd/HXsgf@Air-de-Roger>
 <2cd051c8-dac0-998c-cced-401c504ad439@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <2cd051c8-dac0-998c-cced-401c504ad439@suse.com>
X-ClientProxiedBy: LO4P123CA0160.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:188::21) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 80b019cc-9d73-4a09-2122-08d9e6f425c6
X-MS-TrafficTypeDiagnostic: BN6PR03MB3041:EE_
X-Microsoft-Antispam-PRVS: <BN6PR03MB3041CCC6CFCE7EED3B724EB28F289@BN6PR03MB3041.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: DQOuMaam2qkNgFy63R5ESEkXQNC4UHLXF+dIzXEbD+kqtgnoo4Sgf5uVJAn7PKa5bEW0M7lb7vrXyheXBsh5uk5pATIGFhCk+tQfYR47EFtH/lqK2ebrKUc/DhbO+eTUO/bCWYIkirKvV8TsLFOB0OU59GDgHJUnp2G9J9IVj+MXmnJ4f/yJXf2GgG9NkvFur7HRuZ6V7zvxM9Gw6TecIfjZoTwQrD/76bGADz76Vo0gKZETAlZaPMYeXMqkSslfQLsoB4Zo33lG8Hick1ACcKD2XoHph+a48ZYq9R7ev7yOYXJrn/OdQNO8imWJK0jf6PrDStY0UoRURjfBGD4py+zMaiS74tWbb4yONn5O9ZCVWXzigr5uCM/FuzDK2Qd8keJulbg5FmX1YwGTYb3XcyRlJzAliNleqnFGNc7WqLRkCyc8voK8o7KfjiNLbHSeRQ/RA0aEuFZyLLbJiIPAa9cHwsaEQqAZxpgAKh0hqqlGl9s73iHYSR9lmSk7W6JmQF42jsHMXWPQL0FSUTEY3Gxwcm8Whunf3uLCymSx+hXGpc6aI7UzOuWWHUm8AGHk1C4iUOqh4IywUqVMSmGPW/uYiFTAIYeEkmaAGwQX25ysQsYZ9CPFyIl7eMAmxW8bY1rEjlazaLi51a0SYRVKeg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(316002)(54906003)(38100700002)(6916009)(85182001)(5660300002)(82960400001)(8936002)(8676002)(4326008)(2906002)(66556008)(86362001)(66946007)(26005)(66476007)(186003)(83380400001)(508600001)(6486002)(9686003)(6512007)(6506007)(6666004)(33716001)(53546011);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VGNsd3RmNnFMdncwNWVwKzNTMDR5L2NmMEJOcG9UVjI4a3JlbXhjakxyODBH?=
 =?utf-8?B?SkRxc1daOFFCcENrRlJwano1eVVKWmcrUENSZGw1SVBOZ1FGVmVaZlErdEFr?=
 =?utf-8?B?WTBCM05yeVAwaUtGV3ZSU0RPcVRoY0JFYW82Vm5VYUFhQzN4c2pJcTE5MGdQ?=
 =?utf-8?B?QWVxeUQ0UjlmZWpia085WktxVlhzRVFCVzdCbWxjcisvY2sydCt5SjZMMHZZ?=
 =?utf-8?B?V3p5Sm1yeGFZMkV5U0x3Y3IzWFhmNzBKS21IaUVyNzlTSEoxR2lvTmFHK3Ur?=
 =?utf-8?B?b3NabUl2MVpNQnc2Wm01YU8zeStNbmVqU3JPcEVDajNIemdUSE5pZDdraUx6?=
 =?utf-8?B?dzIyOG9FNVJWenoyQkRUUnNpcm41dEZudDVZNGdRY1R1cnV2M3BwVHVFWnUx?=
 =?utf-8?B?ckJ1RTlZYlpwMGNHUXRkMWp6UENiVWluUkRvL3d2WHZnQmJzOTdMb3RMS0dQ?=
 =?utf-8?B?WUsrY2FoZUZXN2FyeHJUMVk0NW8zem9yRnh2Tm54M05sZFJZRlF4Mk5wb0Ux?=
 =?utf-8?B?L1B1dXFKM2tma2RDaG5FdkhZY2Y1eUJBNEJGRTVHbE5pZ3BuMVYxY1NoYUhm?=
 =?utf-8?B?c05PcWxhOUdGWTdPeFhFQ0ZzL0RkYmlnSjNyc2NpZ24zMlNMYTV4TkxIVTd1?=
 =?utf-8?B?ZjZIYnJtQkNaajVXcGN4S29yVkpodHJtVXJPaHdtbXI1YkprVDFncktvNzEy?=
 =?utf-8?B?bVlRNlFNNVFjTjB5SGl5TVNpa1FQU3BlR29IeDY3V3NzdDhVckRuUzcrRXl5?=
 =?utf-8?B?RWFTVEIyOUxucERQcGxrNTA5cFkxQnpGR0k4bDNCcHZBdzJLaDd6SkI1eVFa?=
 =?utf-8?B?WW85ZURGczkrdWpqUnk3QmwvbGE3STR6UEI1dU1MTW51cC9GdkdDdUljK3Vm?=
 =?utf-8?B?MzJTQkExWHVhRlZDZGRxWnl1STlJZi80VEFaSmVpNkl4ZVEwTmNtVmQwSU5O?=
 =?utf-8?B?N1IxUEdSVWdFN0NBWG9OdDZPM0Y1YXNETkRWeVF2eitZT0ZTZmNFOWxhQ2pP?=
 =?utf-8?B?bUx0ZXdPUGlIck1TY1B3d0JJejdRdDVBUkpOWmI5cVd3VkVFN2ZqUmNiSjhO?=
 =?utf-8?B?djdBcExZdk5GcmxwYWl3S2FNL0ltdGJueG1USzd5NUtFSURhVStHaExlT0ZL?=
 =?utf-8?B?S0dUWml2Ukg3NlhUYXJnektHTW5CSGNqY3JHWUQ4ZDYzeTZGZTZLOGZzZ3NM?=
 =?utf-8?B?akx1T3pnd2xFcTZENmlQVlBVcHJzOWlyTlJTcHY5NnpFMDFEeEhwc0FBMHZJ?=
 =?utf-8?B?WHpYQmZZQlVnalA0OGFiV1g2VmxOMDVscUpvMDk2L2ptekxWODdIMWNrNTVP?=
 =?utf-8?B?WTBvTmdNTVBZYWNnK05Rb2ZCa0t1MjFlOVprMGpBS0pDTXZ0RFVGMkJhekx4?=
 =?utf-8?B?UmE2LzhVcnFqbmo4VnZRamtVcU1JWVZIbDF4UHJnRjM1YkhIV0FSa25PVGpq?=
 =?utf-8?B?VmE2S2RyY2cvNEtHdkhPTjFFb3lFdmZ3UGc0RndNSnBXTWlnRlJDTTVBd0Zr?=
 =?utf-8?B?YUdmejYwNHVuMjhiRUIzT1hMOEZtQnE4UlU5cUZMbUwxUEErSkV2RWRSRExT?=
 =?utf-8?B?R2FIbkNLNWl4UjJtYzB5NjQ5U1F4R2Fvemd4aUUxc0hsZS92bFpwaEFWZzFr?=
 =?utf-8?B?M3FVdDRYQ1M4Z3JiYXIzSXJoNHFyR0RrcGZXU01IWXhsejROUTJFYWl6VmVo?=
 =?utf-8?B?L2tGM0NkaUM2MVFvdzdGMzNFMlFaMmxoOUNlOWd1QWZIQkp6a3hLMCtaOXla?=
 =?utf-8?B?a1FBNWpETW9LMjhsenQ4L1lkT0docjVsMWZKbFQyeUV5WVQyR2cxR2haMGxL?=
 =?utf-8?B?dE1ObWN1eVFIY2xtNkRWK29Ed0htS2tFMkRES2EvdjRwa2x5ZUZodklDRmFp?=
 =?utf-8?B?ODJ5SFF3RVpnaCtvU0dRZWRMOWMxQVEvU25uTWF6TDQzYnJLTnBHVDlrcSs2?=
 =?utf-8?B?TGFoZCtZWUJmdGpmd1IwV3VyemNrRFFRSjR6cEJVWmlpZWNBYnVIVk05TkJ3?=
 =?utf-8?B?TlhlM1A0V2NOcHgzakgvVWhqbFdCZDNXcDRsdmxRRE1VMEdCemZpK0kwVW9p?=
 =?utf-8?B?VGZCMURnSHA2NWtkMm4xSE5iN0NmL2p2Ri9NbFBxWFRuTXJMeXJzVE5RRThG?=
 =?utf-8?B?UFQxc3A5YWZUVmM0YTltbUhKVm1LbkgzVVpvbEZtR1hOUWp4ZTIxK3FVb0hn?=
 =?utf-8?Q?HlaSg+Ha4iT4DNX3D3Rhg2I=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 80b019cc-9d73-4a09-2122-08d9e6f425c6
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Feb 2022 09:04:13.1348
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jboA+CmCwDt2MY6GCQCCgtidq5WDAhu2vN+iaEcbiiXpXgfhx7fC8Tz7NwSFe+++eO/JnyKdFA7sgx5fPxn7Xw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB3041
X-OriginatorOrg: citrix.com

On Thu, Feb 03, 2022 at 09:31:03AM +0100, Jan Beulich wrote:
> On 02.02.2022 17:13, Roger Pau Monné wrote:
> > On Tue, Jan 04, 2022 at 10:41:32AM +0100, Jan Beulich wrote:
> >> @@ -359,7 +360,10 @@ p2m_pod_set_mem_target(struct domain *d,
> >>  
> >>      ASSERT( pod_target >= p2m->pod.count );
> >>  
> >> -    ret = p2m_pod_set_cache_target(p2m, pod_target, 1/*preemptible*/);
> >> +    if ( has_arch_pdevs(d) || cache_flush_permitted(d) )
> > 
> > Is it possible to have cache flush allowed without any PCI device
> > assigned? AFAICT the iomem/ioport_caps would only get setup when there
> > are device passed through?
> 
> One can assign MMIO or ports to a guest the raw way. That's not
> secure, but functionally explicitly permitted.
> 
> > TBH I would be fine if we just say that PoD cannot be used in
> > conjunction with an IOMMU, and just check for is_iommu_enable(d) here.
> > 
> > I understand it's technically possible for PoD to be used together
> > with a domain that will later get a device passed through once PoD is
> > no longer in use, but I doubt there's much value in supporting that
> > use case, and I fear we might be introducing corner cases that could
> > create issues in the future. Overall I think it would be safer to just
> > disable PoD in conjunction with an IOMMU.
> 
> I consider it wrong to put in place such a restriction, but I could
> perhaps accept you and Andrew thinking this way if this was the only
> aspect playing into here. However, this would then want an equivalent
> tools side check, and while hunting down where to make the change as
> done here, I wasn't able to figure out where that alternative
> adjustment would need doing. Hence I would possibly(!) buy into this
> only if someone else took care of doing so properly in the tool stack
> (including the emission of a sensible error message).

What about the (completely untested) chunk below:

diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_create.c
index d7a40d7550..e585ef4c5c 100644
--- a/tools/libs/light/libxl_create.c
+++ b/tools/libs/light/libxl_create.c
@@ -1160,17 +1160,16 @@ int libxl__domain_config_setdefault(libxl__gc *gc,
     pod_enabled = (d_config->c_info.type != LIBXL_DOMAIN_TYPE_PV) &&
         (d_config->b_info.target_memkb < d_config->b_info.max_memkb);
 
-    /* We cannot have PoD and PCI device assignment at the same time
+    /* We cannot have PoD and an active IOMMU at the same time
      * for HVM guest. It was reported that IOMMU cannot work with PoD
      * enabled because it needs to populated entire page table for
-     * guest. To stay on the safe side, we disable PCI device
-     * assignment when PoD is enabled.
+     * guest.
      */
     if (d_config->c_info.type != LIBXL_DOMAIN_TYPE_PV &&
-        d_config->num_pcidevs && pod_enabled) {
+        d_config->c_info.passthrough != LIBXL_PASSTHROUGH_DISABLED &&
+        pod_enabled) {
         ret = ERROR_INVAL;
-        LOGD(ERROR, domid,
-             "PCI device assignment for HVM guest failed due to PoD enabled");
+        LOGD(ERROR, domid, "IOMMU cannot be enabled together with PoD");
         goto error_out;
     }
 


> Finally this still leaves out the "raw MMIO / ports" case mentioned
> above.

But the raw MMIO 'mode' doesn't care much about PoD, because if
there's no PCI device assigned there's no IOMMU setup, and thus such
raw MMIO regions (could?) belong to a device that's not constrained by
the guest p2m anyway?

> >> --- a/xen/common/vm_event.c
> >> +++ b/xen/common/vm_event.c
> >> @@ -639,7 +639,7 @@ int vm_event_domctl(struct domain *d, st
> >>  
> >>              rc = -EXDEV;
> >>              /* Disallow paging in a PoD guest */
> >> -            if ( p2m_pod_entry_count(p2m_get_hostp2m(d)) )
> >> +            if ( p2m_pod_active(d) )
> > 
> > Isn't it fine to just check for entry_count like you suggest in the
> > change to libxl?
> 
> I didn't think it would be, but I'm not entirely sure: If paging was
> enabled before a guest actually starts, it wouldn't have any entries
> but still be a PoD guest if it has a non-empty cache. The VM event
> folks may be able to clarify this either way. But ...
> 
> > This is what p2m_pod_entry_count actually does (rather than entry_count | count).
> 
> ... you really mean "did" here, as I'm removing p2m_pod_entry_count()
> in this patch. Of course locking could be added to it instead (or
> p2m_pod_get_mem_target() be used in its place), but I'd prefer if we
> could go with just the check which precisely matches what the comment
> says (IOW otherwise I'd need to additionally know what exactly the
> comment is to say).

Could you briefly mention this in the commit message? Ie: VM event
code is also adjusted to make sure PoD is not in use and cannot be
used during the guest lifetime?

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Thu Feb 03 09:10:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 03 Feb 2022 09:10:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264542.457656 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFY8A-0002DC-Hl; Thu, 03 Feb 2022 09:10:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264542.457656; Thu, 03 Feb 2022 09:10:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFY8A-0002D5-Cy; Thu, 03 Feb 2022 09:10:18 +0000
Received: by outflank-mailman (input) for mailman id 264542;
 Thu, 03 Feb 2022 09:10:17 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=OTfZ=SS=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nFY89-0002Cz-3k
 for xen-devel@lists.xenproject.org; Thu, 03 Feb 2022 09:10:17 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 19af28e6-84d1-11ec-8f75-fffcc8bd4f1a;
 Thu, 03 Feb 2022 10:10:15 +0100 (CET)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2105.outbound.protection.outlook.com [104.47.18.105]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-41-NCXI3nVzMH2Tj327H6NRTw-1; Thu, 03 Feb 2022 10:10:14 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0401MB2496.eurprd04.prod.outlook.com (2603:10a6:800:56::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Thu, 3 Feb
 2022 09:10:13 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.012; Thu, 3 Feb 2022
 09:10:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 19af28e6-84d1-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1643879415;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=/NmLh7X+2qGQ0pCnHnLln80ApoN23mns1vRmFb2h8Ww=;
	b=UqS56v6ftYjmHt1QDkvSICoBl6hY9NV6I0ghTfvW27mb64GqGOV1EIv/Zdk4Cj/njrtsBS
	2oDl9mrC0JXW8V6uyCENTUzIoH2QqJtquoOLEwQ9eHHUZDWYQmcw7y4It93eUqhvn/e0lC
	ey5v2kAMj4p3M0Ao7qH+7USR5PY01u4=
X-MC-Unique: NCXI3nVzMH2Tj327H6NRTw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=itxHsIE9hu8Egw/OVj2gqQAgl3Up5WK6edV3z8N6YoZXxXMliiRMlre/laKWqfea5Fc23an8dCwSv9ESBYkOaSzUlfSsKKaHBqFbBDQ0Y0ZU1JoAtLAaC9QuozSY1I8NG5dNZECNga/n/VA+rllHUDXwqWtClI/pEBtDFN7QQ89qZFeLEm/ImbtGPeKMFXJ8g4PGnet1SRaojvPJ2an8rPBaTElJTYiYqREoRW78y4060T/l6sl9W6+9RmjJ7bBvxU+v1pPUTf2KVDMAXQFwB5vGNEOv4nTliDCVg5IGaZcatY/wi0pag9QJTkWJqJJ1R7VGuVPZQAsBxV9oeqci8w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=/NmLh7X+2qGQ0pCnHnLln80ApoN23mns1vRmFb2h8Ww=;
 b=cTz0BkG9rdegUwcEvfMxn24HFJveRYT7NAjoApfXP6hc64w0+AGG7Z8pSdG2mGKnMk9pedTY+X3aIbTPqXoE3l3W4jbaK1A5l38GKUEIbfo5ou5eop2SNJyY0Phv/L30ubL8xE9O5tPLtjIA3gZ6eZ30gYgO/0hzz/JoiGicoqVu+irBUf7V8g5aWR2zNB4gQ/saA1DSA8sO4wgYQdJGwgzL497H2t87USRicG1UcCBR1BbHN2DNmLFqvcPWdUQNLt7qRlXrr04P/M7za7bC/0OyeqJvdsfOkJpUI27gCRSuuwmW0aEwBtc479sb8Mu4cui7eX0AhiXc8ET8KTWwXQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <2c3c7da6-0239-1999-3cb4-a5f49745c6b5@suse.com>
Date: Thu, 3 Feb 2022 10:10:10 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH] xen: add option to disable GNTTABOP_transfer
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220201090239.32067-1-jgross@suse.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220201090239.32067-1-jgross@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0308.eurprd06.prod.outlook.com
 (2603:10a6:20b:45b::28) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d6013bea-4496-423c-c804-08d9e6f4fc3d
X-MS-TrafficTypeDiagnostic: VI1PR0401MB2496:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<VI1PR0401MB2496A0568A6D4D93BA5159C4B3289@VI1PR0401MB2496.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5516;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	T29kQsARNbbGdtP41vO7YY9gULonlP8nc4Oj2PkbTsnoNp2z9lA+r4yPK88Nk9Dk235O1qsoBQPZquu9UgtcOrS4NiNN1n9TUsqD3fHPvykUMu3K4JOEFt86cRdDmuDa8r6Q1P2c/L4+qbErXz6XHcF7EXLpFygbFXkkY3mZTipUdBNGOwM069ZKQwg3mGyeoPcXaDhrZeKy1SicDJJwH+IXdKQ5zVAzU15+QukqmzL5V5rk19sSXsiTLuVvVZVr8ME/Pi0TZUHtVLHkLYszsQHthOY5Vxur+sjHYCGWK8ZUBuqVvuGzSVNAFU8bJk8Vxt//56X5STAMh0cm2/NK7Qg9OtvgYIDh5HrxFnfsVLGmn+49t41bjqgx10md6JAuTL1f6xAkMSSHarFfHw6DPTE58XLAUHSOZjs4vtD/QM0xhyAY816XY5CjvP4IwFD6EppkHC4GD1oE0AG6cFvLtC37PAYkVuelXRclOMScd5NHOMXSKa6BAG0j7rFzuGR3JIE/8N8jEpc4ky+NuyWp6GN/aq7qx2qjh7hyC5BaFujyAob3wu2zGIkNlMoUlw16MnZuI8FooeUceQoYI0JXf+SvRjBolgOrUW6pPOoljtUJM7O4tGFCjkFot8VCcsTrHwdGoPqWw/kqk0phY3WHcX3mv1QsSo+plOkNU3Sif63WcADei0jDPjrFzP2mv+Twomst3BcLjxWRNAvqTdTxnpsSAajt2KLpS3nMiKOCKRo6Az7PQRIxG+k72oVuDWRY
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(316002)(31686004)(54906003)(5660300002)(6636002)(37006003)(36756003)(83380400001)(508600001)(2616005)(38100700002)(66946007)(66556008)(186003)(8676002)(26005)(66476007)(86362001)(31696002)(6512007)(6506007)(53546011)(2906002)(6486002)(8936002)(4326008)(6862004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RFNOZWgxc3JZSjdaNitmNkR0VHdPMTlJUE4wRXFTL3FoRm13azF0OXBLT3Uy?=
 =?utf-8?B?ckhVVUd3RzdFaW9GdXl5MTdxTnBVQ1NhbVRuVWwwcE8rakZ0QzRyTWJmZDBl?=
 =?utf-8?B?NnNzL1JpTXJIOG1wMDlhKytBVlo3S21PTERyeHNiWXR6bGdoS1JpR0FFS0w1?=
 =?utf-8?B?LzhJampZektFWW01bm90dmt4UkNFY2VrU2piMG9lOGRaamdNL0V3emV0bWRE?=
 =?utf-8?B?bHFNSGp4QzcxODJjTk1VcmJTaE1EZFpUZTdmcVlZc2ZRWXl4SE4xTVdQampW?=
 =?utf-8?B?d2NnbFIyeDFTZzA4cVlUcnNOYmM2QTlQYnEvcFl6cEhpMXhNNVBzNThOSWJZ?=
 =?utf-8?B?VzhDNWh2N1l1WnhIWkhoMlRtckRhZk1wU1Flb0xsTXFabjliZmRtRDF5MzZ3?=
 =?utf-8?B?S2E4bHRsd2dHZVQ4ZlJadENqeXoyV2VPak5DSHhwekU3S2tYejl2bXcxdGVQ?=
 =?utf-8?B?UWk4NEVLVE4yeTBlNldlZzBDNnU2ZGFUU2tzakxaTTZ0bDhHbStzNkszVE93?=
 =?utf-8?B?MVNiVzdabzZtRHVNMTJaWTk0ZVAvUVZKdTFFYVV5bWVXcTJGNmppODRPQTda?=
 =?utf-8?B?cG1sNzlHZDg5MVVnd3RkaTNXOUFhamhFKzVoaGd2ZEJKUzFpeG0wZ0ZsRHd6?=
 =?utf-8?B?QU9LUU5DaU5pYm1mRFduZGtPSkRRR1dvTDBTVHV2L2Jpc1BqRVdpUHNpampW?=
 =?utf-8?B?Y0NhMXRZS0JkTXVQa1d2cWJtVmY2Z0ttcXJNaUpNQS90NFhFa1hCcWRQV1Jt?=
 =?utf-8?B?TzNLZmRoOUpzZnhWYlhTRlVhSDhZM3dNWVdodTgyaEJwRjdNNVBEV3Ftd09x?=
 =?utf-8?B?dzRMS3piRlI3d3VteUJ6NFUwMk5MVkhLRC90OW0rdnU3VVQxejZZd2UvNWxD?=
 =?utf-8?B?dlBhOUgvMDc3dS8yam83cHFXUHpmY1BPckRYcS9JMDhwT2tHeFZWTm04R2xL?=
 =?utf-8?B?b0I4WERhTTJaWkZtYWpkRDhFQjc4ZENWZE1WMHVFaUV5S2RFdGRDeXFqdnFY?=
 =?utf-8?B?ZkRSRStZOUtxSmdOZlU2K2ptSFN0Z3ZydjlabnpkSGh5YlI0WSsxOUoxZWUw?=
 =?utf-8?B?ZDM5ZW4xZTluOTdXUWpTYTFaNFhPTVpkSWxYMWpzWHhVS3NxQWsvR2svZWty?=
 =?utf-8?B?VTJmSGpYUTJhTlI5bFVIbWF5L0xOUGNNcWxJbllJcU1FZ2ZiaGNEZkZUR3E1?=
 =?utf-8?B?aEI4N2RVNUNuMTFSN3ZVbUhiRkxPU29nSmoxNGZ3VzVERHpma1Q2MWY0ajZN?=
 =?utf-8?B?UVE1RFFoVnRhYSsxWUNVUjJIdzBxN3hvMXplS2VuUk9HcXppYjZXTWVqVjR4?=
 =?utf-8?B?VmdxeDEzRlpkaml3WVFTZHptQ3BDN0Q5cDZUeHJCcXNHUC9BL2YvNDlLcjVL?=
 =?utf-8?B?SVp4S25uUUViVGF0VFZOZzZWWlhCWlQrcmJCREFLZDhlNkZuajdUdUpEM2lm?=
 =?utf-8?B?WGlET3dMOStlQUZZdUZjQ0UwbnpYbVpDYzdaVWI4WTlzejE1NlduRUQ2R0U1?=
 =?utf-8?B?ckxpdnR2UEpxSC9VQ2NLaVoxeEhsTjZuMXZSRnR3OEY0ek9WYjBwVXU2ajBr?=
 =?utf-8?B?ZFNwckNkUGt2KzJ6OC9UU1pRZU1vUGRidUZTakxOMis1c25VaVcxTzZRamV5?=
 =?utf-8?B?NzNYQ0E2Qm55SDlsQWRVSGJGdDBuT3Fhei9Mc256cTZLQ2pKdVRFRDgxNzRL?=
 =?utf-8?B?SUxvZUttcDEyTS9aODl1aEVKZ1U2VkhkdlNkKzdZcmd3eHFzamVwZ1V5REww?=
 =?utf-8?B?UnR1R3VIakpteE00QkExRUhoTFlPMGYwOUltNElGSTNjTnVMRmhSR2N3YjBy?=
 =?utf-8?B?ZXVqWFgzemxBOXVQV0dzSVQ1d2liUG1Hby9iUWZ5c3lETGZVMUpnaUdJR0gv?=
 =?utf-8?B?YWMvbmxjU1h1T21idjM1aGlMNlpGaWZHY1kwdnhybm9TSWxMRXcrUXB4bkl6?=
 =?utf-8?B?eW8zVEx2K2pOWGx2ZHlnVktjM1NYbXJzWW1HbDBvWkNTREoyaURubUhGRGdl?=
 =?utf-8?B?Wk5LcFRVL1dEQ09YTzh0azc5czFaOWxtTTZWVFQ2dXZMdjIyd25pWjFYc2Fx?=
 =?utf-8?B?dnR1Vk1JbWxRY21VQjBOZ2x0QkNKWU1zQms1MXhEQ0JzQWxBVmw5VXErUnkz?=
 =?utf-8?B?aTNINkI1Vm1SMEo0d294V3Q4QVZEaDRoWHZXRzVOT09LOGZXOUttVU1xZFpp?=
 =?utf-8?Q?t4JEcQUdwEy9VG8I6hD2S1U=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d6013bea-4496-423c-c804-08d9e6f4fc3d
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Feb 2022 09:10:12.9670
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: A6/P+xGivlO4/mvX/Z0VilZn5v7oEYFolyRm428dCW7kynBQannZUedr8wLab9yaPOY7AqP3TQ2dG3gv6Undiw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2496

On 01.02.2022 10:02, Juergen Gross wrote:
> The grant table operation GNTTABOP_transfer is meant to be used in
> PV device backends, and it hasn't been used in Linux since the old
> Xen-o-Linux days.

Kind of unusual spelling of XenoLinux ;-)

> --- a/xen/common/grant_table.c
> +++ b/xen/common/grant_table.c
> @@ -181,6 +181,7 @@ static int parse_gnttab_max_maptrack_frames(const char *arg)
>  
>  unsigned int __read_mostly opt_gnttab_max_version = GNTTAB_MAX_VERSION;
>  static bool __read_mostly opt_transitive_grants = true;
> +static bool __read_mostly opt_grant_transfer = true;

If this was conditional upon PV (with a #define to false in the
opposite case), it could be __ro_after_init right away, while at
the same time allowing the compiler to eliminate gnttab_transfer().

> @@ -204,6 +205,8 @@ static int __init parse_gnttab(const char *s)
>          }
>          else if ( (val = parse_boolean("transitive", s, ss)) >= 0 )
>              opt_transitive_grants = val;
> +        else if ( (val = parse_boolean("transfer", s, ss)) >= 0 )
> +            opt_grant_transfer = val;
>          else
>              rc = -EINVAL;

To possibly save a further roundtrip: If the PV dependency was added
above, I'd like to ask to follow the model of parse_iommu_param()
here and use "#ifndef opt_grant_transfer" around the added code in
favor of "#ifdef CONFIG_PV".

> @@ -2233,6 +2236,9 @@ gnttab_transfer(
>      unsigned int max_bitsize;
>      struct active_grant_entry *act;
>  
> +    if ( !opt_grant_transfer )
> +        return -ENOSYS;

-EOPNOTSUPP please.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Feb 03 09:22:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 03 Feb 2022 09:22:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264549.457667 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFYJY-0003iR-Kx; Thu, 03 Feb 2022 09:22:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264549.457667; Thu, 03 Feb 2022 09:22:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFYJY-0003iK-Gh; Thu, 03 Feb 2022 09:22:04 +0000
Received: by outflank-mailman (input) for mailman id 264549;
 Thu, 03 Feb 2022 09:22:02 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=OTfZ=SS=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nFYJW-0003iE-MU
 for xen-devel@lists.xenproject.org; Thu, 03 Feb 2022 09:22:02 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id bde9eb0a-84d2-11ec-8f75-fffcc8bd4f1a;
 Thu, 03 Feb 2022 10:22:00 +0100 (CET)
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur03lp2059.outbound.protection.outlook.com [104.47.9.59]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-10-fH1YoKenOyS5f6QS9X-8SQ-1; Thu, 03 Feb 2022 10:21:59 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by PAXPR04MB9105.eurprd04.prod.outlook.com (2603:10a6:102:225::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Thu, 3 Feb
 2022 09:21:57 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.012; Thu, 3 Feb 2022
 09:21:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bde9eb0a-84d2-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1643880120;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=RNEnHKdAcwJyjLFMBZa1qMp9ftVYkRele6HWYd3ZhEI=;
	b=m6hz9hCEI7x5P3bwpFJNrSsgksj+YXBPKnJhGNXkv5/FyCqD7nyX/P7PKt2ekUwtvfVc0U
	/LR7bCE/VcKWzPv296iiqVk+CnZ8Hg5SW+QIamsW23y19MW0g4Lm8YxQDkYE4cwu4uiBbC
	S6qqvNnkprjPtDCO4kADxeSQuLUVnPI=
X-MC-Unique: fH1YoKenOyS5f6QS9X-8SQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=YNdlCed5w5Vt6cvtP/3lWewuD6pwZCuKISJ2CFfq6+6KEUnqjS2M+vTo6JKvhjwA63OIGO22bpr0q45g0mJrmMGYWC1wF4rIBJ9fgJL9gcjnUl9blIaPTPzDXfivzeXcMzefj3nXICNWB1zGizk4SRhd01+7LlpuIHfmamnemrKAoM2w2uft+43SUx+DZeMmHS5DbjXCe8uLF0hx5E0IjMDhkqB4zOGSBr8Qh3MUEEcEx3k9IWpyqZuMvIN6G2LiSVcvVaIBCpf8HoSf/ny8QeYmb/iUpmXO2bjrIEyTRcG5sZZEKbP9xX1Uc694DWhF6WSx4+fc+ebl6ZmuDd1bew==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ybZ7fVeG4BCzRYN4EowpOl+XVaC7V3n0qFG0YeMTT00=;
 b=HrZW8/u5TgSgqMQjOBf9ElGQlSWrX/v1b7b+U1kirOToMM2R6foOkkYg8lv4LZqBrLgtxl4U8K6MyXUVYzeor7vGt4ASKdFWDnlwpFHUZMJZuDUK19UO5SsQRfZvXteA/DkS/HivjqsBWCar9cVyQdUreNVq973CPIlpU3Ke1qbxbyVea6CEvKBy6+31l/gkR81UF5PSvWqmUsuuxQGPSVb8sitdo9mX7gFzSnpqQlwBiOD1SCgiaeCfwcw1VdbRsh3Va7OdnNmuqNbq+ZL4JQxkE9ioaYh7dXACZ4eIm8KZAlPcmk71ycG6E1dp47m2gpfwjpa6rBKotJ+FG2BlSg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <7c315902-e618-bba6-054d-86b0aa685370@suse.com>
Date: Thu, 3 Feb 2022 10:21:54 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v3 1/2] IOMMU/x86: disallow device assignment to PoD
 guests
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 George Dunlap <george.dunlap@citrix.com>, Paul Durrant <paul@xen.org>,
 Tamas K Lengyel <tamas@tklengyel.com>,
 Petre Pircalabu <ppircalabu@bitdefender.com>,
 Alexandru Isaila <aisaila@bitdefender.com>
References: <6fe7b036-2bdb-b391-4e6c-1b5d7e05a119@suse.com>
 <b0a77526-17f2-a5ab-6f7f-1b3caeb4a59b@suse.com>
 <YfqtlZMAKd/HXsgf@Air-de-Roger>
 <2cd051c8-dac0-998c-cced-401c504ad439@suse.com>
 <Yfuahx0ntHJ2BQ6x@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Yfuahx0ntHJ2BQ6x@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: FR0P281CA0084.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:1e::23) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b1a13b6d-f03b-4533-35c2-08d9e6f6a02d
X-MS-TrafficTypeDiagnostic: PAXPR04MB9105:EE_
X-Microsoft-Antispam-PRVS:
	<PAXPR04MB910518DB1F8DB74AD768B90AB3289@PAXPR04MB9105.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	hf2HORtJzShYi7hJe3GPkNigJwF3EmRsbzFB867YmSAJhMplh8m7GQ8k+IKgJV4wcIhfq89NuokQp7zdhJUzetOP6qQQIKtJiVTMGhtpIvFhoBDLCUqvZVZB6DcJp0osVt9lrFxDtSPUJgWtcPgu71LSI9LOtUwVC9WWx0NpX/HA9/14Waxy5ArLiN4862n6ZUeCgvjecT/WJpvZtrTvA184zw/h9k/O6IgvveMQBcA1c2cdvDcFM4sW5Klt4ZsL3qd56Aer/5ytgRbU1ASv8zmTP4dYE0XEKDZA0FAVgs7USW52RR5OAdU3vxwRxyUu+jb0RflvWyhWu3KYEktOW2u+eFV2VIQveBhb8+eec+pt+Kp2Dp0nyrYbdZKJLztH0lQoravWdBeRlGXAMVt9VutO0/LT+0NMCWUTom1ipnS6tXW4JxOMfjpk0er5+Zrmw4iIRxztsFU1e5T3f8NWB0VHWz19l6Kz4lYle9aW9aa/bVcOg6JVZl59dN1zcVr0DEu0OCblM6Fjj4YXKkVGrGv7e9MhSTddODOMhl1rhZFcYGDQjrxS3riOGIMuDrmn0lmjnFG/n53ZBBv5UICHuIGcAhCf+WLjfLHx+fNYlvcSsSJbVRlfGHJBWeSZyLHUcei/hgkCQ9KRnp3q0+7sHYagFqtPOpRHEm4SCMyqUmBGMrnZuARN9ZYILmK1OnN1X7CF7QdYgZSVqj5SMPxSRqfBFpnRfdebs8DAr9X7iMg=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(38100700002)(316002)(6916009)(31696002)(86362001)(5660300002)(8676002)(8936002)(83380400001)(66476007)(66556008)(2906002)(4326008)(53546011)(31686004)(66946007)(6506007)(6512007)(6666004)(26005)(186003)(2616005)(36756003)(6486002)(508600001)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?4l7E5riPL04JJhu+YvVy7B3BEma4yZ5gRV9X2At9emhINzKk6DsUPYdJy2Y9?=
 =?us-ascii?Q?DUiPNuBaO+yB3lGpFZkPygNL+bGa7xhNGu8dzh+5xcaCdvOUdthYTVBiVomA?=
 =?us-ascii?Q?v6AMx2vtanHmwv6t9d6eiNes2x846skGMxnxcWIDcqda/I1FN26x3HzWXjej?=
 =?us-ascii?Q?ykSsMfPT4jDyyTr4BH8BVt/CEHkfVgaFV8OphCEL28fbZgPGYTe0vvAiyPRT?=
 =?us-ascii?Q?ZG+1zR4hlvt+WWrSXI/xi+Ld7++c97P69KthXiXRRcx4BebZapAtJ430yKbn?=
 =?us-ascii?Q?E07oMvKgazgS1VTdYhhgYqN+/vxAXMWklgetOZzr7Y1dBE+BgbaREp8IPIEL?=
 =?us-ascii?Q?R5tCbQqZoM9FDUtjcVpAI5VNj1Yo05WladZ1OK8HvzTj6l64IoWe78BsdXB3?=
 =?us-ascii?Q?vyXpUQp88JZqOotkbEX4In2EcWyxvcmrY7PqVNqjzlfMRMQfqXs8XIrxFJ4g?=
 =?us-ascii?Q?MKrEQNm2wxvXaORLVU0h6wduAOOAzeaFABrEueyiKqtVwRNvYHF3abtT6I51?=
 =?us-ascii?Q?yFFyC58P5RXctf5i/AHhcVGYDIee5jJsytE2Ae17+QH9Oq5CiMKK1aPWHGCw?=
 =?us-ascii?Q?Up9YiTVKlGO/O6jcGXG7rNgA9V7QbLeEUZpBR8eVSyIyZV6wCmk5QFHeehAH?=
 =?us-ascii?Q?YtgVZgC0qHHQA2ZmGPjhoQdkn1G1Disw84pDBY2Py5lfUj7hEBkI9GJ3ukRA?=
 =?us-ascii?Q?qYhSWKIdKcTsl5D9lrdE7iWLN5QsXFuJo6iB+4NMD/YIxi3xW4GlqSw5d1Ga?=
 =?us-ascii?Q?h256pqIgUDeYG6cYTfeJUXP6qalVBLnqCs2UUszK9ot/l8r0VE6sgY3u8+Du?=
 =?us-ascii?Q?DZ4ts+mrW4WdqsBeSIk6U3UizB2MOIhWesO6QQpo3LC2WYEjn+IO3JTUQLpo?=
 =?us-ascii?Q?lVv0YdOChXc/1hiQP/8vP8n8wnKpXqUI+pO9XScxZA3eDHKb5RAK2RP6HGq5?=
 =?us-ascii?Q?zsy0tfVVvdYadU7V+qfBPqO8uC7tJmGZ3N+p8qIghwqFgXKkjkR0uGkSYkOy?=
 =?us-ascii?Q?Eb7EIadNGTs+Ze1VhBvkPS+Y2Bx0dXstYiJmwEJlNr4OFtFs/HUTVE7N1DqO?=
 =?us-ascii?Q?wIguI0Ls73a+e2Epz9tbubCN43Y7+6f2jTpeH8duSRWL8/duwb9B70PFqsH2?=
 =?us-ascii?Q?7kaYZPmUubiazMtp6NqrrHWtwvtSVjORsAobKqmmbgzNFh2fsTHrevbTJPwY?=
 =?us-ascii?Q?KbpV5zkHngsQW0bbf4ymgaUZmQRM0oIZLdA3CU+aBBn5f9HXibdzJwG4VPVp?=
 =?us-ascii?Q?gog/PKkDtYNqD/2wqizvlTGBktGubKfWccpS0g5rZw5Chw6kPEIL41rJhiTL?=
 =?us-ascii?Q?2VYNS3JqU0N+pmnWEIhlQzX1ujuhnClh0zuAUmDizg49tdv62wv6vSiJmEAB?=
 =?us-ascii?Q?fGrRkPydBpbdb/YRAHz0TMfRL6Sn5M9tj9hXNlBzAenyRC/5xEsxHNhbEDEB?=
 =?us-ascii?Q?1g1lPU986a6TR066nXlT8KvGDOFieqi7249e9QxZkR9f6ZY4JHsfgPa7oe4Z?=
 =?us-ascii?Q?V4UTa+7VDA3ocxCb++jvu7t3ovcj78wQeNdUQD7dsOTtJEDG+khD4KXweUAK?=
 =?us-ascii?Q?PSjMKD5TGfoEB3Qr9XmzOpc1Wl4TiaEgH7DXLsw9sMIXy7ojZRIfhMH/A9xC?=
 =?us-ascii?Q?HPNlTpuVWAeFJ3zvNQLMt0g=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b1a13b6d-f03b-4533-35c2-08d9e6f6a02d
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Feb 2022 09:21:57.4390
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OaaGkSQAzZLI9/R8DmgmMZ9zrJ6xt7HJ6BZV3PVj9Jq5f/9LozNw8CAT74H0N7SuTGWFiXXbwGlDAc5zbqVI8Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9105

On 03.02.2022 10:04, Roger Pau Monn=C3=A9 wrote:
> On Thu, Feb 03, 2022 at 09:31:03AM +0100, Jan Beulich wrote:
>> On 02.02.2022 17:13, Roger Pau Monn=C3=A9 wrote:
>>> On Tue, Jan 04, 2022 at 10:41:32AM +0100, Jan Beulich wrote:
>>>> @@ -359,7 +360,10 @@ p2m_pod_set_mem_target(struct domain *d,
>>>> =20
>>>>      ASSERT( pod_target >=3D p2m->pod.count );
>>>> =20
>>>> -    ret =3D p2m_pod_set_cache_target(p2m, pod_target, 1/*preemptible*=
/);
>>>> +    if ( has_arch_pdevs(d) || cache_flush_permitted(d) )
>>>
>>> Is it possible to have cache flush allowed without any PCI device
>>> assigned? AFAICT the iomem/ioport_caps would only get setup when there
>>> are device passed through?
>>
>> One can assign MMIO or ports to a guest the raw way. That's not
>> secure, but functionally explicitly permitted.
>>
>>> TBH I would be fine if we just say that PoD cannot be used in
>>> conjunction with an IOMMU, and just check for is_iommu_enable(d) here.
>>>
>>> I understand it's technically possible for PoD to be used together
>>> with a domain that will later get a device passed through once PoD is
>>> no longer in use, but I doubt there's much value in supporting that
>>> use case, and I fear we might be introducing corner cases that could
>>> create issues in the future. Overall I think it would be safer to just
>>> disable PoD in conjunction with an IOMMU.
>>
>> I consider it wrong to put in place such a restriction, but I could
>> perhaps accept you and Andrew thinking this way if this was the only
>> aspect playing into here. However, this would then want an equivalent
>> tools side check, and while hunting down where to make the change as
>> done here, I wasn't able to figure out where that alternative
>> adjustment would need doing. Hence I would possibly(!) buy into this
>> only if someone else took care of doing so properly in the tool stack
>> (including the emission of a sensible error message).
>=20
> What about the (completely untested) chunk below:
>=20
> diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_cre=
ate.c
> index d7a40d7550..e585ef4c5c 100644
> --- a/tools/libs/light/libxl_create.c
> +++ b/tools/libs/light/libxl_create.c
> @@ -1160,17 +1160,16 @@ int libxl__domain_config_setdefault(libxl__gc *gc=
,
>      pod_enabled =3D (d_config->c_info.type !=3D LIBXL_DOMAIN_TYPE_PV) &&
>          (d_config->b_info.target_memkb < d_config->b_info.max_memkb);
> =20
> -    /* We cannot have PoD and PCI device assignment at the same time
> +    /* We cannot have PoD and an active IOMMU at the same time
>       * for HVM guest. It was reported that IOMMU cannot work with PoD
>       * enabled because it needs to populated entire page table for
> -     * guest. To stay on the safe side, we disable PCI device
> -     * assignment when PoD is enabled.
> +     * guest.
>       */
>      if (d_config->c_info.type !=3D LIBXL_DOMAIN_TYPE_PV &&
> -        d_config->num_pcidevs && pod_enabled) {
> +        d_config->c_info.passthrough !=3D LIBXL_PASSTHROUGH_DISABLED &&
> +        pod_enabled) {
>          ret =3D ERROR_INVAL;
> -        LOGD(ERROR, domid,
> -             "PCI device assignment for HVM guest failed due to PoD enab=
led");
> +        LOGD(ERROR, domid, "IOMMU cannot be enabled together with PoD");
>          goto error_out;
>      }

Perhaps. Seeing this I actually recall coming across this check during
my investigation. Not changing it along the lines of what you do was
then really more because of me not being convinced of the extra
restriction; I clearly misremembered when writing the earlier reply.
If we were to do what you suggest, I'd like to ask that the comment be
changed differently, though: "We cannot ..." then isn't really true
anymore. We choose not to permit this mode; "cannot" only applies to
actual device assignment (and of course only as long as there aren't
restartable IOMMU faults).

>> Finally this still leaves out the "raw MMIO / ports" case mentioned
>> above.
>=20
> But the raw MMIO 'mode' doesn't care much about PoD, because if
> there's no PCI device assigned there's no IOMMU setup, and thus such
> raw MMIO regions (could?) belong to a device that's not constrained by
> the guest p2m anyway?

Hmm, yes, true.

>>>> --- a/xen/common/vm_event.c
>>>> +++ b/xen/common/vm_event.c
>>>> @@ -639,7 +639,7 @@ int vm_event_domctl(struct domain *d, st
>>>> =20
>>>>              rc =3D -EXDEV;
>>>>              /* Disallow paging in a PoD guest */
>>>> -            if ( p2m_pod_entry_count(p2m_get_hostp2m(d)) )
>>>> +            if ( p2m_pod_active(d) )
>>>
>>> Isn't it fine to just check for entry_count like you suggest in the
>>> change to libxl?
>>
>> I didn't think it would be, but I'm not entirely sure: If paging was
>> enabled before a guest actually starts, it wouldn't have any entries
>> but still be a PoD guest if it has a non-empty cache. The VM event
>> folks may be able to clarify this either way. But ...
>>
>>> This is what p2m_pod_entry_count actually does (rather than entry_count=
 |=C2=A0count).
>>
>> ... you really mean "did" here, as I'm removing p2m_pod_entry_count()
>> in this patch. Of course locking could be added to it instead (or
>> p2m_pod_get_mem_target() be used in its place), but I'd prefer if we
>> could go with just the check which precisely matches what the comment
>> says (IOW otherwise I'd need to additionally know what exactly the
>> comment is to say).
>=20
> Could you briefly mention this in the commit message? Ie: VM event
> code is also adjusted to make sure PoD is not in use and cannot be
> used during the guest lifetime?

I've added

"Nor was the use of that function in line with the immediately preceding
 comment: A PoD guest isn't just one with a non-zero entry count, but
 also one with a non-empty cache (e.g. prior to actually launching the
 guest)."

to the already existing paragraph about the removal of that function.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Feb 03 09:35:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 03 Feb 2022 09:35:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264556.457677 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFYWg-0005Ch-S7; Thu, 03 Feb 2022 09:35:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264556.457677; Thu, 03 Feb 2022 09:35:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFYWg-0005Ca-PF; Thu, 03 Feb 2022 09:35:38 +0000
Received: by outflank-mailman (input) for mailman id 264556;
 Thu, 03 Feb 2022 09:35:37 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=iP5S=SS=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nFYWf-0005CU-Lc
 for xen-devel@lists.xenproject.org; Thu, 03 Feb 2022 09:35:37 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a2e4a2e6-84d4-11ec-8eb8-a37418f5ba1a;
 Thu, 03 Feb 2022 10:35:36 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a2e4a2e6-84d4-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1643880935;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=hVLBWmA4H4oxQBG73G7hRaLkBdQn+/WEaI9T42E8Jag=;
  b=TaHZn8re9drOXg/T6/lgCUvYZIZ/PmajgsiYfWQSyCf28aN+TVpbxyS4
   OGCZ/XE1rfzz4gjbQTURSNcWRIvC1ubGZaT/H4GRpA0hTI588IPDl4oR+
   ICe5Zagz9ZERfkQcTW0jWQ4bp0UJT0E7eaddXE4rOxD9lak3LvPhoEiQQ
   c=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: Duec6gSvMxJxPq06/J7VnkejSZmwPNKJJwFBC6qJ+ZSC/dXSHQXACusSy6/oOLFLmx5i7RaAgu
 1tIFyf3eOf5P03/Z92+hBCkz3A2SY+1OeL7ivniHiwtq/ulZ+1nP0D8EM0AbUpCwEAnoF/+5K+
 KFiB4Yq+WHw5yf/66gG8gKAm+FHkkBpmwQhtsQAVimFvEagEfLI7Isq028UL39pVtx+7yuBOkg
 EggFuKXjPtuyLz2D5Qkf6gd7Oevcq1q8YsZVJcZXB/ZVb7leuL8n3/O/eUzE79SwOGR2FZc9qD
 oobOUvo9JNTdDkElW18tMND+
X-SBRS: 5.2
X-MesageID: 63311742
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:T/70N63kSP1lEBaBP/bD5RN2kn2cJEfYwER7XKvMYLTBsI5bpzcHn
 2cfX2jQaPyPMWD9eY12bIviphsF75DRndZjHAFrpC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkS5PE3oHJ9RGQ74nRLlbHILOCanAZqTNMEn9700o5w7Vh2+aEvPDia++zk
 YKqyyHgEAfNNw5cagr4PIra9XuDFNyr0N8plgRWicJj5TcypFFMZH4rHomjLmOQf2VhNrXSq
 9Avbl2O1jixEx8FUrtJm1tgG6EAaua60QOm0hK6V0U+6/TrS+NbPqsTbZIhhUlrZzqhkfxp2
 N99n7uKdxo7LL3jpPUmVDMDKnQrVUFG0OevzXmXtMWSywvNcmf2wuUoB0YzVWEa0r8pWycUr
 6VecW1TKEDY7w616OvTpu1Ej8I/LM7tLcUHt2tp1z3xBvc6W5HTBa7N4Le02R9u3ZsXRKmCP
 aL1bxJVVQ7bZDhLK2wWAYAMmfqP2mXucxFH/Qf9Sa0fvDGIkV0ZPKLWGMrYfJmGSNtYmm6cp
 3na5CLpDxcCLtudxDGZtHW2iYfnnyn2RYYTH72Q7eNxjRuYwWl7NfENfQLl+7/j0Bf4Ao8Bb
 RxPksYzkUQs3EKHVsn3bzefmkCZrAwMdOZBKOoQszjYn8I4/D2lLmQDSzdAbvkvu8k3WSEm2
 ze1oj/5OdB8mObLECzAr994uRv3YHFIdjFaOUfoWCNYu4GLnW0lsv7Yoj+P+oaRh8a9Jzz/y
 iviQMMW1+RK1p5jO0lWEDn6b9OQSnrhE1ZdCub/BDvNAuZFiGiNPdfABb/ztq4oEWphZgPd1
 EXoYuDHhAz0MbmDlTaWXMIGF6yz6vCOPVX02AAzRMl6qmrwqiX8Jui8BQ2Swm8zaa7onheyO
 CfuVf55vscPbBNGk4crC25ONyja5fe5Tom0PhwlRtFPfoJwZGe6ENJGPiatM5TWuBF0y8kXY
 M7DGe71VCpyIfk5kFKeGrlMuZd2lnFW7T6CHvjTkkX4uYdykVbIE9/pxnPUMLBghE5FyS2Im
 +ti2zyikEQCCbCuP3WMrOb+7zkidBAGOHw/kOQPHsbrH+asMDtJ5yb5zexzdop7sb5Sk+uUr
 HixVlUBkAj0hGHdKBXMYXdmMeu9UZF6pHM9HCotIVf3hCRzPdfxtP8SJ8ktYL0q1O1/1vooH
 fMLTNqNX6ZUQTPd9jVDMZSk9N5+dA6mjB6lNja+ZGRtZIZpQgHEo4e2fgbm+CQUIDCwsM8y/
 ++p2g/BGMJRTAV+FsfGLvmoygrp73QanetzWWrOI8VSJxqwoNQ7dXSpg6Zucc8WKBjFyj+L7
 CqsAE8V9bvXvos40NjVnqTY/Y2nJPRzQxhBFG7B4LfoaSSDpji/wZVNWfqjdCzGUD+m472rY
 OhYwq2uMPADm1oW4YNwH6wykPA77trr4bRb0h5lDDPAaFHyUuFsJXyP3M9usKxRx+AG5VvqC
 xzXotQKa6+UPM7FEUIKIFt3Z+uO4vgYhz3O4KlnO079/iJ2oOKKXEg608NgU8CBwG+Z6L8Y/
 No=
IronPort-HdrOrdr: A9a23:9ODdx6uABUKJv6AKne4gGwVT7skDdtV00zEX/kB9WHVpmszxra
 6TddAgpHvJYVcqKRQdcL+7VZVoLUmxyXcx2/h3AV7AZniFhILLFuFfBOLZqlWKcREWtNQttp
 uIG5IObuEYZmIasS+V2maFL+o=
X-IronPort-AV: E=Sophos;i="5.88,339,1635220800"; 
   d="scan'208";a="63311742"
Date: Thu, 3 Feb 2022 09:35:30 +0000
From: Anthony PERARD <anthony.perard@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 4.16 / 4.15] MAINTAINERS: Anthony is stable branch tools
 maintainer
Message-ID: <Yfuh4v50Zu9g6UuN@perard>
References: <3a8a7290-5cd1-da7a-46df-5cbe1755036e@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <3a8a7290-5cd1-da7a-46df-5cbe1755036e@suse.com>

On Thu, Feb 03, 2022 at 09:56:08AM +0100, Jan Beulich wrote:
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -60,7 +60,7 @@ The maintainer for this branch is:
>  
>  Tools backport requests should also be copied to:
>  
> -	TODO - Loooking for new tools stable maintainer
> +	Anthony Perard <anthony.perard@citrix.com>

Acked-by: Anthony PERARD <anthony.perard@citrix.com>

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Thu Feb 03 09:36:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 03 Feb 2022 09:36:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264562.457689 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFYXp-0005pI-BH; Thu, 03 Feb 2022 09:36:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264562.457689; Thu, 03 Feb 2022 09:36:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFYXp-0005pB-6N; Thu, 03 Feb 2022 09:36:49 +0000
Received: by outflank-mailman (input) for mailman id 264562;
 Thu, 03 Feb 2022 09:36:47 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mjBt=SS=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nFYXn-0005om-H5
 for xen-devel@lists.xenproject.org; Thu, 03 Feb 2022 09:36:47 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id cac41739-84d4-11ec-8f75-fffcc8bd4f1a;
 Thu, 03 Feb 2022 10:36:43 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cac41739-84d4-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1643881005;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=23t8jwQQX1AC/xtblucynRKJC3J7+0r7n4XTehgwPWk=;
  b=XmBxMwQ92IW91UXteyttbLazbA72qe71SL7HD2mHqVC9vHjP4j9g3gvP
   y4/i62BQHCS2aLMqjpL/v0MmWo/fX3TiK7nih+yPLPl2UkTXnQeLf6/To
   Lx5gESGsQbZ2XKZWlocbLltk8OTn0kX37Ml7GIhhd3DpGbn5zUR2dCaSk
   Q=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: l5b5qyWC/UGO678GvSjBi5ReUhs9KgIE9zX53NTKmV3YG66HmYGuQfFmPPbuI9WTLuuJVvF1vj
 i/yQxb9ryMF9KKTtf8GHkVGokZUJnBq6OP6xyk2QpsJjqvqQIsTpJit9tkJKBUhhS1ZXIkwczV
 s7LV5wVXA7Z9g/3xsfN1dkjZJ7YbAK53t/t/lZs6DHU6tYD+jQZXtQRbblzG3o3GWwSFL+OFVY
 fa+wsEp8wTL3sPdskN4XaNlPBW76ilGJqq6SGICmg+kz3DBM3L14AbxSMj10CFcp9s6pxTx9ag
 lNSUkLv4K1AYlyF3c05ouk2L
X-SBRS: 5.2
X-MesageID: 63311779
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:WZH536MjaB1NK3rvrR09kMFynXyQoLVcMsEvi/4bfWQNrUpx3zJUz
 TYZD2mHPf+Ka2X2e9x2b4rk8UpTsZWBxtAxTgto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6UUsxNbVU8En1500o4w7dRbrNA2rBVPSvc4
 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq
 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYoz7Zsv1S9
 f5CjMPqFA00FIfDtfsnTTANRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs
 6VFdnZdNXhvhMrvqF6/YvNrick5atHiIasUu216zCGfBvEjKXzGa/uRvoYBg2hh7ixINejzV
 4kpaTl9UAXnXTF3F04HEK5u28790xETdBUH8QnI9MLb+VP7zhF10bXrGMrYfJqNX8o9tl2Du
 mvM8mD9AxcbHN+S0zyI9jSrnOCntTz/cJIfEvu/7PECqF+c3GsIEzUNSEC25/K+jyaWS99Zb
 kAZ5Ccqhawz71CwCMnwWQWip3yJtQJaXMBfe8U44gyQzqvf4y6CG3MJCDVGbbQbWNQeHGJwk
 AXTxpWwWGIp4Ob9pW+hGqm8pmOfFAsoBmA7OnVZRxYvydbOv7stp0eaJjp8K5KdgtrwEDD25
 jmFqikimrke5fI2O7WHEUPv2Gz1+MWQJuIhzkCOBz/+sFslDGKwT9HwsTDmAeB8wJF1p7Vrl
 FwNgICg4e8HFvlhfwTdEbxWTNlFCxtoWQAwYGKD/bF8r1xBGFb5JOi8BQ2Swm8zaa7onheyO
 CfuVft5vsM7AZdTRfYfj3iNI8or17P8Mt/uS+rZaNFDCrAoKlPcrHozOxPBhD+2+KTJrU3ZE
 c3AGSpLJS1CYZmLMRLsH7tNuVPV7nxWKZzvqWDTkE38jOv2iI+9QrYZKlqeBt3VH4vfyDg5B
 +13bpPQoz0GCbWWSnCOreY7cA5WRVBmW8Geg5EHJ4arf1s9cEl8WqC5/F/UU9E/90ijvr2Wr
 ijVt44x4AeXuEAr3i3ROy06NeOyAc0ixZ/5VAR1VWuVN7EYSd/HxI8UdoctfKlh8+pmzPVuS
 OICddnGCfNKIgkrMRxENPERdaRuK0amgxygJS2gbGRtdpJsXVWRqNTlYhHu5G8FCS/u7Zkyp
 Lip1wX6R5sfRls9UJaKOaz3l17h72IAnO9SXlfTJoUBckvb74U3eTf6ieU6Ip9QJEyblCeaz
 QufHTwRufLJ/90u6NDMiK3d99WpHuJyE1B0BW7e6brqZyDW8nD6md1LUfqSfCCbX2Txof3wa
 eJQxvD6EfsGgFcV7NYsT+c1lfozvoK9qaVbwwJoGGTwQ26qUr4wcGOb2cRvt7FWwuMLswWBR
 U/SqMJRPq+EOZ25HQdJdhYldOmKydodhiLWsaYuOEz/6SJ6oOiHXEFVM0XegSBRNuIoYoYsw
 ONns88K8Q2vzBEtN4/e3CxT8m2NKF0GUrkm6c5GUNO61FJzxwEQe4HYBw/3/IqLOodFPUQdK
 zOJgLbP2uZHzU3YfntvTXXA0IKxX3jVVMymGLPaG2m0pw==
IronPort-HdrOrdr: A9a23:mRlzRaxQHnWZXXUxSB6TKrPxyOskLtp133Aq2lEZdPULSKKlfp
 GV88jziyWZtN9wYhEdcdDpAtjnfZr5z+8J3WBxB8bZYOCCggqVxe5ZnO7fKlHbaknDH6tmpN
 tdmstFeazN5DpB/L7HCWCDer5KqrT3k9HLuQ6d9QYXcegDUdAf0+4TMHfjLqQZfnggOXJvf6
 Dsmfav6gDQMkg/X4CePD0oTuLDr9rEmNbPZgMHPQcu7E2rgSmz4LD3PhCE1lNGOgk/jIsKwC
 zgqUjU96+ju/a0xlv10HLS1Y1fnJ/ExsFYDMKBp8AJInHHixquZq5mR7qe1QpF6t2H2RIPqp
 3hsh0gN8N85zf4eXy0mwLk303a3DMn+xbZuCmlqEqmhfa8aCMxCsJHi44cWADe8VAcsNZ117
 8O936FtrJMZCmw0hjV1pztbVVHh0C0qX0tnao4lHpES7YTb7dXsMg24F5VKpEdByj3gbpXX9
 WGNPuspMq+TGnqLEww5gJUsZ6RtzUIb1u7q3E5y42oO2M8pgE986MarPZv6UvouqhND6Ws3N
 60QZiAoos+OvP+XZgNdNvpfvHHeFAlYSi8eV56cm6XXJ3uBRr22uvKCfMOlaaXRKA=
X-IronPort-AV: E=Sophos;i="5.88,339,1635220800"; 
   d="scan'208";a="63311779"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=MLeZYa6fQhtEZiiiS9PHjS+TNPSyrHDXJdCWtm/GvA5ZPbGDRzDAq5IuT1/6PhbH9syUeauXmyx9svb2ziZgirNeRJbp9EniYTK2dK2BO8hQNvsMhZa7dUN35OJ+5cWciR6wTPzpu+XwcrDNq1gpj2SjjMBoDAhgzio7RuTo6pgeEgd/2UoKhc478iGS7uCEezGvhkD/nhuRglxDYUh15y5rZqOhrwsfzQ37vtnHKE9FGmtshwOremj7BThXSg9OyIAxYCmbPD8bP0gc8Q8KkDF5Br71ctqTrDS41ceMhvV5nE1nqg5/nNTCnxGn1BMxfcLhcYmnG8disCH1YqP0DA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=pJJE/ITSJDKPmZHIXrBeGC0SyS/eYpEwZlP5PQ9vkRE=;
 b=V9laSaGxriuNp8HPi3YX1j8fkiUKdmFbSbHhL15fce2Gfz/kvKcsisjA2YaG/7rio8E+on6cNAarqCqfmkWkjWBP2DLKKWfQAV0whfesg5Uljww3SLRNU8WJh7scWYgJ6hHdwXQUdQe9qBzPiXGUfkMzSWnv6h/CqK8mWFAzdkybFJzXT34dLSW6IgqQ53uy6nW40f2iFo4elXBQ7jRg1P9RvVofsDsu2E80Cyqu0fqW8v/4KdKSJpWHzx8A+x1HOjmknLhrHhiv7Q4RTDI6Ev2P18n1EHBOyi0hyZ5RUt5YVDwY2bgUuPEf+wLmTC0cgQh2pbZNhXqH1LvncM/8jA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=pJJE/ITSJDKPmZHIXrBeGC0SyS/eYpEwZlP5PQ9vkRE=;
 b=OLJ5DKJo7qBXMWtXWfJz9XEPvWaORME/1Xl2Jys6rXpEHmGDMbv3Hi2cdCwY9jSx/b2y+S9TWiQthkIbPbLcfl4rhAlRxoLFwqyAY/kmElhrW9me0m/WHDnTd6LAIG7XdTrq77MQQ30z1Z7PLOKkCmRH+mgJ4xhSZ+dU0ytmMxk=
Date: Thu, 3 Feb 2022 10:36:20 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Juergen Gross <jgross@suse.com>
CC: <xen-devel@lists.xenproject.org>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, "Jan
 Beulich" <jbeulich@suse.com>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH] docs: document patch rules
Message-ID: <YfuiFCrF1VJsX5gU@Air-de-Roger>
References: <20220202114448.8608-1-jgross@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20220202114448.8608-1-jgross@suse.com>
X-ClientProxiedBy: LO2P265CA0176.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:a::20) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e9b33f32-9e67-490d-c149-08d9e6f8a56e
X-MS-TrafficTypeDiagnostic: BL1PR03MB6184:EE_
X-Microsoft-Antispam-PRVS: <BL1PR03MB61847EB8F79E6E601C5512008F289@BL1PR03MB6184.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: H37cchXQ6gM626JB8mSOITM8j8PPoXmF64ibZOkqsGUsicLpRjTr3MV8oFEJHwCLRI/0hmSLgo22wvovXct+lQH4bEsDyyzgFWUDYZ87WtP8Qz3Tlgogsdj3X5kVCu9TD7yE+bjpQGFY4ZBTtR6jJCPLyc/To/jep3qAmqz78ztP6MkYufeLj1S72c1XcicKHbIKSXxQTolK0HD7Wbi89Oz9K4QAZyw9MYwFdSId1d2Pdti57KBDDxPzLDKhY4cPlzMXtRUziU0YTU01HTw37mIctvD9U7q2iArI+tohByF8dAp8V25iZwt0ydz4or68L3Yca/j/6vMKceky23rnwN8ePmjnqYwLiQYMV/IE6ZO+gzAXQJCYfDFBRaH6/AAR2wZist4TsHfyAv0cNocrizms/SzdSml9J3Y6/SToBtROZC9SyAM4Z/cnVpFLc/kaeHbvvaUvEQ4Ia9J+f2LmgJO9D2lEsKlVHRQ4j8Kp/4Xbu6ZxhlNf0t3BuqcoWOJFiBDML57CNND2BCnGXGzhuI68jCsHtkBB1qM/6XLcZ//1O6x367rzPdVOjXkNYBpwZ/UA2KUvtgkG0W6uum4pVBQwmhemNb38Es9WYyQIboO25b4Ietis6Oyq6H47tSZsqodzVBlQIA1EDh88C/e3SMbqj+13jJ2hcpzbJUOCH5XFT4ZrsHwZKCTkhfZXdRoG2/8DEUXSZW4poeY4oE/QUqKNfCg/K8qrcRBzFv331+E=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(508600001)(85182001)(33716001)(38100700002)(83380400001)(6666004)(9686003)(26005)(186003)(6506007)(6486002)(6512007)(5660300002)(2906002)(82960400001)(66556008)(66476007)(4326008)(66946007)(8676002)(8936002)(30864003)(86362001)(316002)(6916009)(54906003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Tm9HUTNQVy8xWWxTSzRDRjN6TGY5c1BpWXJKTitZNVRlRk0rUzErbk1wQWlX?=
 =?utf-8?B?UDZmU1hGbU45QjlJc2JycW9GWng5WGdhWktza0RSM0JDY2YwRWVYUHhsL3ha?=
 =?utf-8?B?ZDNsOVVmdVhxaTJVL1lmMXhtcU1EMEZmZFdObjVHTGxzaTBVWVY5d1VwZmg3?=
 =?utf-8?B?ckNmZldYbVA0RVJqMTc0WWlRMTZYbzBmenRGQmNoRHplZEtkcldxaTFFSHlm?=
 =?utf-8?B?YURLRTlpOXM1WXRJRnNLUGpDbk4xUVZqZ1pTRzlPeWljQkloYVNxNTlmRmtI?=
 =?utf-8?B?cDFIb2RNNzQ2OXNPVE5IRzN6M3hHeDdBZVZxZzBtandRaTZVb0M1Wk5oeHlK?=
 =?utf-8?B?dkxrazk1NXdSdlhiVXJDcWpTWEkrYkFldFI3VDdsRUdmMUlCak5IRlUxVGtz?=
 =?utf-8?B?bU80OFhMTWozYklCNldkdTFQbitjUER3NUVwUkIvZmE3cExvcndON2hRREsr?=
 =?utf-8?B?eEFoSFhld3RwQlJzSk1iSDBUeUxJTFRVV2lnVXpIdUhlY2dLVGFzRk14ZDdy?=
 =?utf-8?B?Q0o2bFB4eFNlcGhKd1hwbTB6RkVhUUh4ZGRDV0hVaEFCZWRMVlNiWTVBM2ZE?=
 =?utf-8?B?YkpaZEk0clpaMm1TRUUzNSttTmM1ZDVxTFVXT1o4VUdOdDE1d3IzUjExQktC?=
 =?utf-8?B?WHNQaVNNeXlBcEVwckJOMlErbExCaFF3NDErbC9BUWxSTE5YV04zZ2xTWUg4?=
 =?utf-8?B?dUEvZzBJQzJRQkhyeXZocjdGTjhuQkh0d1owT3FmQXlQbVJaZWg1RGFkZFR3?=
 =?utf-8?B?UFBweFVKYzYvdHZIMXNWWm9hSWFLeDc1SGNpZW8wRllGSmhCMVRHeG5jU0Js?=
 =?utf-8?B?RkQrb25HUUxrMDM0VmVXUkdEaXZXSk1YbXV1SkJDd2RnYU9XZTlSQW9oOGls?=
 =?utf-8?B?cE01ZjNrUW8vZ0FvQjhkTWV2bll1MHhOSkt1RURwMG92Wm5ha3hVVVp5TVZj?=
 =?utf-8?B?V3Zod3V6NzFQQWt4bllWUjEzZ0R6YXR3VDRRa3lYZ3BEYTF0VDZ1dzA1VkN2?=
 =?utf-8?B?RWNVSWZaSytWbmV4dnU5Rlk0V2NjT1V6eWVoLzhsSXNzbmFNS25ITEdLUUR2?=
 =?utf-8?B?M3p5aFZTV1kwZkJ2WFdFd3V0ajR3VEdpMTlPdnlqSE41aUNEdzl6aGY3dGZx?=
 =?utf-8?B?eWIyNUtCSmpDZDYybERZWGYyQ3NBcExHZkN5bjVRSFVjSUZ0ZFN6SzNQOUxW?=
 =?utf-8?B?dU1McnFHcU82MjlGNmtJeGYwNGF6TFpxd2xFK3B2aW4zRUZ4cTVMeGdZMkVp?=
 =?utf-8?B?TGpWMy9GbFlBTXhEOVFYTG44azFGL0VWbFJUR3FBZ1gvdm5vNitrY1hiVS9l?=
 =?utf-8?B?d2V0eXlOZ0MyUVpVY2tWeTJ0QzR5VTgwcTJvTFN6WUUvSTJJbkwvMVpJdklB?=
 =?utf-8?B?VEVQNUY0Vkg2QlFiQVpDY0RPLzNmaFZaTFl1N0JFTXRpRUo5dkc1YWUvd2lz?=
 =?utf-8?B?a1FTbTZ6aVJJS2VlZUxwZzZYT2hFK0tKbEpHcnlicVI0MUo5R2xhWVZ4UXUz?=
 =?utf-8?B?UzRZczFHV3BUVUROWjJKOVhpalVWWFl0SE53UlNsakRQMXQxWXZyY0hZSTV4?=
 =?utf-8?B?NU5DNTBaWDhGSWkrN2NBYUFrb1JHUHZpUnJHdjdjN0V3ckxZN3NyaGZvSzFq?=
 =?utf-8?B?dlZLcGwvU0orZ0k1VlFlS2VZU1hFWEIvYjRBQ1pzSk1jMzRzdFpjdE4zU2Er?=
 =?utf-8?B?RTQ3UjRRWFpjRFFOM2Y4MTBTSXpZYmhDdDRWUHpSaWhtS0FLYk5xRFJpczdS?=
 =?utf-8?B?RitrOU9rYnpCQisxVE5mYjdOQ2NpUXh3Y1pFb2dQejZQMFRzSGhWTVR3Q3lO?=
 =?utf-8?B?L1BQRVg2UmtYRWw2L244bFB4Tmdybm5LcDl3VFNwYjljS2dscSsvSG81Smp6?=
 =?utf-8?B?NGoxU090bnRwc0NOYURpbHp2c2V2MEVUUXRRQ1NVQWpvSkxYYzRqbEZKL1d5?=
 =?utf-8?B?RTlXWXpweEExRnJqMjA0VHVMTXhiTm9nTVI4a2orQlU2aWdPdTJLRDRiK05l?=
 =?utf-8?B?Tm1nNERRSGovWHdueUhMbE1QYXJMU3JxZTBEMGlSUEZTS1R6QWw2azhuRHhx?=
 =?utf-8?B?ajVsL0xpQmMxRk1RQ1AvT1V5STZkYnplU1FIS2I1K2c3U2JabTEvNmlneXBJ?=
 =?utf-8?B?b3FzcXhnSUd1TUZpUi9rVWd2REpFNDVaNzUvby9sUUhPUGRYc1NGWWJqMzhi?=
 =?utf-8?Q?94RI06GW6Xua8hzcBCKtiys=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e9b33f32-9e67-490d-c149-08d9e6f8a56e
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Feb 2022 09:36:25.3599
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fpPZMt7KGGYnBfu5cCo17+qqURxkUgvwPBmShTKYacXrVFq3jTL6GKngI3wY1YqcSIOa1EqCliF06xJm2IQybA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR03MB6184
X-OriginatorOrg: citrix.com

On Wed, Feb 02, 2022 at 12:44:48PM +0100, Juergen Gross wrote:
> Add a document to describe the rules for sending a proper patch.
> 
> As it contains all the information already being present in
> docs/process/tags.pandoc remove that file.
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>
> ---
>  docs/process/sending-patches.pandoc | 284 ++++++++++++++++++++++++++++
>  docs/process/tags.pandoc            |  55 ------
>  2 files changed, 284 insertions(+), 55 deletions(-)
>  create mode 100644 docs/process/sending-patches.pandoc
>  delete mode 100644 docs/process/tags.pandoc
> 
> diff --git a/docs/process/sending-patches.pandoc b/docs/process/sending-patches.pandoc
> new file mode 100644
> index 0000000000..4cfc6e1a5b
> --- /dev/null
> +++ b/docs/process/sending-patches.pandoc
> @@ -0,0 +1,284 @@
> +# How a proper patch should look like
> +
> +This is a brief description how a proper patch for the Xen project should
> +look like. Examples and tooling tips are not part of this document, those
> +can be found in the
> +[Xen Wiki](https://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches).
> +
> +## The patch subject
> +
> +The first line at the top of the patch should contain a short description of
> +what the patch does, and hints as to what code it touches. This line is used
> +as the **Subject** line of the mail when sending the patch.
> +
> +The hint which code is touched us usually in form of a relative path inside
> +the Xen git repository, where obvious directories can be omitted or replaced
> +by abbreviations, or it can be a single word describing the topic:
> +
> +    <path>: <description>

I would use <component> maybe instead of path, to explicitly note this
is not usually a real path inside the repo.

> +
> +E.g.:
> +
> +    xen/arm: increase memory banks number define value
> +    tools/libs/evtchn: Deduplicate xenevtchn_fd()

Mostly a nit, but since this document is about style: I wouldn't
recommend using a capital letter after ':' by default. The above line
should instead be:

    tools/libs/evtchn: deduplicate xenevtchn_fd()

> +    MAINTAINERS: update my email address
> +    build: correct usage comments in Kbuild.include
> +
> +The description should give a rough hint *what* is done in the patch.
> +
> +The subject line should in general not exceed 80 characters. It must be
> +followed by a blank line.
> +
> +## The commit message
> +
> +The commit message is free text describing *why* the patch is done and
> +*how* the goal of the patch is achieved. A good commit message will describe
> +the current situation, the desired goal, and the way this goal is being
> +achieved. Parts of that can be omitted in obvious cases.
> +
> +In case additional changes are done in the patch (like e.g. cleanups), those
> +should be mentioned.
> +
> +When referencing other patches (e.g. `patch xy introduced a bug ...`) those
> +patches should be referenced via their commit id (at least 12 digits) and the
> +patch subject:
> +
> +    Commit 67d01cdb5518 ("x86: infrastructure to allow converting certain
> +    indirect calls to direct ones") introduced a bug ...
> +
> +The following ``git config`` settings can be used to add a pretty format for
> +outputting the above style in the ``git log`` or ``git show`` commands:
> +
> +        [core]
> +                abbrev = 12
> +        [pretty]
> +                fixes = Fixes: %h (\"%s\")
> +
> +Lines in the commit message should not exceed 75 characters, except when
> +copying error output directly into the commit message.
> +
> +## Tags
> +
> +Tags are entries in the form
> +
> +    Tag: something
> +
> +In general tags are added in chronological order. So a `Reviewed-by:` tag
> +should be added **after** the `Signed-off-by:` tag, as the review happened
> +after the patch was written.
> +
> +Do not split a tag across multiple lines, tags are exempt from the
> +"wrap at 75 columns" rule in order to simplify parsing scripts.
> +
> +### Taken-from:
> +
> +Xen has inherited some source files from other open source projects. In case
> +a patch modifying such an inherited file is taken from that project (maybe in
> +modified form), the `Taken-from:` tag specifies the source of the patch:
> +
> +    Taken-from: <repository-URL> <commit-id>
> +
> +E.g.:
> +
> +    Taken-from: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git f093b08c47b3
> +
> +All tags **above** the `Taken-from:` tag are from the original patch (which
> +should all be kept), while tags **after** `Taken-from:` are related to the
> +normal Xen patch process as described here.
> +
> +### Fixes:
> +
> +If your patch fixes a bug in a specific commit, e.g. you found an issue using
> +``git bisect``, please use the `Fixes:` tag with the first 12 characters of
> +the commit id, and the one line summary.
> +
> +    Fixes: <commit-id> ("<patch-subject>")
> +
> +E.g.:
> +
> +    Fixes: 67d01cdb5518 ("x86: infrastructure to allow converting certain indirect calls to direct ones")
> +
> +### Backport:
> +
> +A backport tag is an optional tag in the commit message to request a
> +given commit to be backported to the released trees:
> +
> +    Backport: <version> [# <comment>]

So we already had a documented usage of '#' in tags, which I think
should make it a better candidate for the R-b scope limiting.

> +
> +E.g.:
> +
> +    Backport: 4.9+
> +
> +It marks a commit for being a candidate for backports to all released
> +trees from 4.9 onward.
> +
> +The backport requester is expected to specify which currently supported
> +releases need the backport; but encouraged to specify a release as far
> +back as possible which applies. If the requester doesn't know the oldest
> +affected tree, they are encouraged to append a comment like the
> +following:
> +
> +    Backport: 4.9+ # maybe older
> +
> +Maintainers request the Backport tag to be added on commit. Contributors
> +are welcome to mark their patches with the Backport tag when they deem
> +appropriate. Maintainers will request for it to be removed when that is
> +not the case.
> +
> +Please note that the Backport tag is a **request** for backport, which
> +will still need to be evaluated by the maintainers. Maintainers might
> +ask the requester to help with the backporting work if it is not
> +trivial.
> +
> +### Reported-by:
> +
> +This optional tag can be used to give credit to someone reporting an issue.
> +It is in the format:
> +
> +    Reported-by: name <email@domain>
> +
> +E.g.:
> +
> +    Reported-by: Jane Doe <jane.doe@example.org>
> +
> +As the email address will be made public via git, the reporter of an issue
> +should be asked whether he/she is fine with being mentioned in the patch.
> +
> +### Suggested-by:
> +
> +This optional tag can be used to give credit to someone having suggested the
> +solution the patch is implementing. It is in the format:
> +
> +    Suggested-by: name <email@domain>
> +
> +E.g.:
> +
> +    Suggested-by: Jane Doe <jane.doe@example.org>
> +
> +As the email address will be made public via git, the reporter of an issue
> +should be asked whether he/she is fine with being mentioned in the patch.
> +
> +### Signed-off-by:
> +
> +This mandatory tag specifies the author(s) of a patch (for each author a
> +separate `Signed-off-by:` tag is needed). It is in the format:
> +
> +    Signed-off-by: name <email@domain>
> +
> +E.g.:
> +
> +    Signed-off-by: Jane Doe <jane.doe@example.org>
> +
> +The author must be a natural person (not a team or just a company) and the
> +`Signed-off-by:` tag must include the real name of the author (no pseudonym).
> +
> +By signing the patch with her/his name the author explicitly confirms to have
> +made the contribution conforming to the `Developer's Certificate of Origin`:
> +
> +    Developer's Certificate of Origin 1.1
> +    
> +    By making a contribution to this project, I certify that:
> +    
> +    (a) The contribution was created in whole or in part by me and I
> +        have the right to submit it under the open source license
> +        indicated in the file; or
> +    
> +    (b) The contribution is based upon previous work that, to the best
> +        of my knowledge, is covered under an appropriate open source
> +        license and I have the right under that license to submit that
> +        work with modifications, whether created in whole or in part
> +        by me, under the same open source license (unless I am
> +        permitted to submit under a different license), as indicated
> +        in the file; or
> +    
> +    (c) The contribution was provided directly to me by some other
> +        person who certified (a), (b) or (c) and I have not modified
> +        it.
> +    
> +    (d) I understand and agree that this project and the contribution
> +        are public and that a record of the contribution (including all
> +        personal information I submit with it, including my sign-off) is
> +        maintained indefinitely and may be redistributed consistent with
> +        this project or the open source license(s) involved.
> +
> +### Reviewed-by:
> +
> +A `Reviewed-by:` tag can only be given by a reviewer of the patch. With
> +responding to a sent patch adding the `Reviewed-by:` tag the reviewer
> +(which can be anybody) confirms to have looked thoroughly at the patch and
> +didn't find any issue (being it technical, legal or formal ones). If the
> +review is covering only some parts of the patch, those parts can optionally
> +be specified (multiple areas can be covered with multiple `Reviewed-by:`
> +tags). It is in the format:
> +
> +    Reviewed-by: name <email@domain> [# area]
> +
> +E.g.:
> +
> +    Reviewed-by: Jane Doe <jane.doe@example.org>
> +    Reviewed-by: Jane Doe <jane.doe@example.org> # xen/x86

I think you should mention in the commit message that we are also
adding the R-b scope limiting in this commit? The commit message makes
it look like this is mostly moving the existing Tags into a new
document.

> +
> +In case a patch is being resent an already given `Reviewed-by:` tag can and
> +should be included, if the patch didn't change the portions of the patch
> +covered by the tag, or if the reviewer already made clear it would be fine
> +to make specific changes and no *other* changes have been made.
> +
> +### Acked-by:
> +
> +Similar to `Reviewed-by:` the `Acked-by:` tag is given by someone having looked
> +at the patch. The `Acked-by:` tag can only be given by a **maintainer** of the
> +modified code, and it only covers the code the maintainer is responsible for.
> +For this reason there is no optional area possible. With the `Acked-by:` tag
> +the maintainer states, that he/she is fine with the changes in principle, but
> +didn't do a thorough review. The format is:
> +
> +    Acked-by: name <email@domain>
> +
> +E.g.:
> +
> +    Acked-by: Jane Doe <jane.doe@example.org>
> +
> +Including the `Acked-by:` tag in a patch is done under the same rules as for
> +the `Reviewed-by:` tag, with the implied code area the maintainer who gave the
> +`Acked-by:` tag is responsible for.
> +
> +### Tested-by:
> +
> +The `Tested-by:` tag is another tag given by someone else. The one giving it
> +confirms to have tested the patch without finding any functional issues. The
> +format is:
> +
> +    Tested-by: name <email@domain> 

Trailing white space.

> +
> +E.g.:
> +
> +    Tested-by: Jane Doe <jane.doe@example.org>
> +
> +Including the `Tested-by:` tag in a patch is done under the same rules as for
> +the `Reviewed-by:` tag, now limited to the patch not having been modified
> +regarding code logic (having changed only coding style, comments, or message
> +texts is fine).
> +
> +## Patch version history (change log), further comments
> +
> +When sending revised versions of a patch it is good practice to include a
> +change log after a line containing only `---` (this line will result in the
> +following text not being included in the commit message). This change log
> +will help reviewers to spot which parts of the patch have changed. Attributing
> +changes due to reviewer comments will help the reviewer even more, e.g.:
> +
> +    ---
> +    Changes in V2:

I would use v2 (lowercase 'v'), because that's how git format-patch
places the version in the subject line.

> +    - changed function foo() as requested by Jane Doe
> +    - code style fixed
> +
> +In some cases it might be desirable to add some more information for readers
> +of the patch, like potential enhancements, other possible solutions, etc.,
> +which should not be part of the commit message. This information can be
> +added after the `---` line, too.
> +
> +## Recipients of the patch
> +
> +A patch should always be sent **to** the xen-devel mailing list <xen-devel@lists.xenproject.org> and all maintainers of all touched code areas should get a

Missing newline.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Thu Feb 03 09:46:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 03 Feb 2022 09:46:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264571.457700 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFYgw-0007Jg-8T; Thu, 03 Feb 2022 09:46:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264571.457700; Thu, 03 Feb 2022 09:46:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFYgw-0007JZ-4d; Thu, 03 Feb 2022 09:46:14 +0000
Received: by outflank-mailman (input) for mailman id 264571;
 Thu, 03 Feb 2022 09:46:12 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=nHU3=SS=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nFYgu-0007JT-5H
 for xen-devel@lists.xenproject.org; Thu, 03 Feb 2022 09:46:12 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1e081ac3-84d6-11ec-8eb8-a37418f5ba1a;
 Thu, 03 Feb 2022 10:46:10 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 15177210F1;
 Thu,  3 Feb 2022 09:46:10 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C764213B7F;
 Thu,  3 Feb 2022 09:46:09 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id XYJVL2Gk+2EFQgAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 03 Feb 2022 09:46:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1e081ac3-84d6-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1643881570; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=s8LquMAwYvLOeme7rk2UJzMhf2fGuvUwSlZ4tek6gbU=;
	b=NkOygvpTFAntGpNUKoFUMFjlGgTd5hJ8YTxdDhTkEZRHQ8PTJagcefv0iUQM7RbO1XmXlH
	7W7g6U9P2fJ0NY1Fr9dKkxNMWEPYFO7JbvUU+lU8czCwjVA6rYZtUbUGV+gm9m+ONMx68S
	hoP8oML5x+X2E2aJp+HBChqRbUsKuwI=
Message-ID: <b545ca94-4e98-b77f-fc1c-8b4686893824@suse.com>
Date: Thu, 3 Feb 2022 10:46:09 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Cc: xen-devel@lists.xenproject.org, Andrew Cooper
 <andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>,
 Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
References: <20220202114448.8608-1-jgross@suse.com>
 <YfuiFCrF1VJsX5gU@Air-de-Roger>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH] docs: document patch rules
In-Reply-To: <YfuiFCrF1VJsX5gU@Air-de-Roger>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------27D0eX2GccdyyTSZhwr0TFWM"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------27D0eX2GccdyyTSZhwr0TFWM
Content-Type: multipart/mixed; boundary="------------Y0NNAV9In0e0sq0drP3Ptrqe";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Cc: xen-devel@lists.xenproject.org, Andrew Cooper
 <andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>,
 Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Message-ID: <b545ca94-4e98-b77f-fc1c-8b4686893824@suse.com>
Subject: Re: [PATCH] docs: document patch rules
References: <20220202114448.8608-1-jgross@suse.com>
 <YfuiFCrF1VJsX5gU@Air-de-Roger>
In-Reply-To: <YfuiFCrF1VJsX5gU@Air-de-Roger>

--------------Y0NNAV9In0e0sq0drP3Ptrqe
Content-Type: multipart/mixed; boundary="------------86hsX0iHbZ3pJWtk5QSGzbL2"

--------------86hsX0iHbZ3pJWtk5QSGzbL2
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMDMuMDIuMjIgMTA6MzYsIFJvZ2VyIFBhdSBNb25uw6kgd3JvdGU6DQo+IE9uIFdlZCwg
RmViIDAyLCAyMDIyIGF0IDEyOjQ0OjQ4UE0gKzAxMDAsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6
DQo+PiBBZGQgYSBkb2N1bWVudCB0byBkZXNjcmliZSB0aGUgcnVsZXMgZm9yIHNlbmRpbmcg
YSBwcm9wZXIgcGF0Y2guDQo+Pg0KPj4gQXMgaXQgY29udGFpbnMgYWxsIHRoZSBpbmZvcm1h
dGlvbiBhbHJlYWR5IGJlaW5nIHByZXNlbnQgaW4NCj4+IGRvY3MvcHJvY2Vzcy90YWdzLnBh
bmRvYyByZW1vdmUgdGhhdCBmaWxlLg0KPj4NCj4+IFNpZ25lZC1vZmYtYnk6IEp1ZXJnZW4g
R3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4NCj4+IC0tLQ0KPj4gICBkb2NzL3Byb2Nlc3Mvc2Vu
ZGluZy1wYXRjaGVzLnBhbmRvYyB8IDI4NCArKysrKysrKysrKysrKysrKysrKysrKysrKysr
DQo+PiAgIGRvY3MvcHJvY2Vzcy90YWdzLnBhbmRvYyAgICAgICAgICAgIHwgIDU1IC0tLS0t
LQ0KPj4gICAyIGZpbGVzIGNoYW5nZWQsIDI4NCBpbnNlcnRpb25zKCspLCA1NSBkZWxldGlv
bnMoLSkNCj4+ICAgY3JlYXRlIG1vZGUgMTAwNjQ0IGRvY3MvcHJvY2Vzcy9zZW5kaW5nLXBh
dGNoZXMucGFuZG9jDQo+PiAgIGRlbGV0ZSBtb2RlIDEwMDY0NCBkb2NzL3Byb2Nlc3MvdGFn
cy5wYW5kb2MNCj4+DQo+PiBkaWZmIC0tZ2l0IGEvZG9jcy9wcm9jZXNzL3NlbmRpbmctcGF0
Y2hlcy5wYW5kb2MgYi9kb2NzL3Byb2Nlc3Mvc2VuZGluZy1wYXRjaGVzLnBhbmRvYw0KPj4g
bmV3IGZpbGUgbW9kZSAxMDA2NDQNCj4+IGluZGV4IDAwMDAwMDAwMDAuLjRjZmM2ZTFhNWIN
Cj4+IC0tLSAvZGV2L251bGwNCj4+ICsrKyBiL2RvY3MvcHJvY2Vzcy9zZW5kaW5nLXBhdGNo
ZXMucGFuZG9jDQo+PiBAQCAtMCwwICsxLDI4NCBAQA0KPj4gKyMgSG93IGEgcHJvcGVyIHBh
dGNoIHNob3VsZCBsb29rIGxpa2UNCj4+ICsNCj4+ICtUaGlzIGlzIGEgYnJpZWYgZGVzY3Jp
cHRpb24gaG93IGEgcHJvcGVyIHBhdGNoIGZvciB0aGUgWGVuIHByb2plY3Qgc2hvdWxkDQo+
PiArbG9vayBsaWtlLiBFeGFtcGxlcyBhbmQgdG9vbGluZyB0aXBzIGFyZSBub3QgcGFydCBv
ZiB0aGlzIGRvY3VtZW50LCB0aG9zZQ0KPj4gK2NhbiBiZSBmb3VuZCBpbiB0aGUNCj4+ICtb
WGVuIFdpa2ldKGh0dHBzOi8vd2lraS54ZW5wcm9qZWN0Lm9yZy93aWtpL1N1Ym1pdHRpbmdf
WGVuX1Byb2plY3RfUGF0Y2hlcykuDQo+PiArDQo+PiArIyMgVGhlIHBhdGNoIHN1YmplY3QN
Cj4+ICsNCj4+ICtUaGUgZmlyc3QgbGluZSBhdCB0aGUgdG9wIG9mIHRoZSBwYXRjaCBzaG91
bGQgY29udGFpbiBhIHNob3J0IGRlc2NyaXB0aW9uIG9mDQo+PiArd2hhdCB0aGUgcGF0Y2gg
ZG9lcywgYW5kIGhpbnRzIGFzIHRvIHdoYXQgY29kZSBpdCB0b3VjaGVzLiBUaGlzIGxpbmUg
aXMgdXNlZA0KPj4gK2FzIHRoZSAqKlN1YmplY3QqKiBsaW5lIG9mIHRoZSBtYWlsIHdoZW4g
c2VuZGluZyB0aGUgcGF0Y2guDQo+PiArDQo+PiArVGhlIGhpbnQgd2hpY2ggY29kZSBpcyB0
b3VjaGVkIHVzIHVzdWFsbHkgaW4gZm9ybSBvZiBhIHJlbGF0aXZlIHBhdGggaW5zaWRlDQo+
PiArdGhlIFhlbiBnaXQgcmVwb3NpdG9yeSwgd2hlcmUgb2J2aW91cyBkaXJlY3RvcmllcyBj
YW4gYmUgb21pdHRlZCBvciByZXBsYWNlZA0KPj4gK2J5IGFiYnJldmlhdGlvbnMsIG9yIGl0
IGNhbiBiZSBhIHNpbmdsZSB3b3JkIGRlc2NyaWJpbmcgdGhlIHRvcGljOg0KPj4gKw0KPj4g
KyAgICA8cGF0aD46IDxkZXNjcmlwdGlvbj4NCj4gDQo+IEkgd291bGQgdXNlIDxjb21wb25l
bnQ+IG1heWJlIGluc3RlYWQgb2YgcGF0aCwgdG8gZXhwbGljaXRseSBub3RlIHRoaXMNCj4g
aXMgbm90IHVzdWFsbHkgYSByZWFsIHBhdGggaW5zaWRlIHRoZSByZXBvLg0KDQpHb29kIGlk
ZWEuDQoNCj4gDQo+PiArDQo+PiArRS5nLjoNCj4+ICsNCj4+ICsgICAgeGVuL2FybTogaW5j
cmVhc2UgbWVtb3J5IGJhbmtzIG51bWJlciBkZWZpbmUgdmFsdWUNCj4+ICsgICAgdG9vbHMv
bGlicy9ldnRjaG46IERlZHVwbGljYXRlIHhlbmV2dGNobl9mZCgpDQo+IA0KPiBNb3N0bHkg
YSBuaXQsIGJ1dCBzaW5jZSB0aGlzIGRvY3VtZW50IGlzIGFib3V0IHN0eWxlOiBJIHdvdWxk
bid0DQo+IHJlY29tbWVuZCB1c2luZyBhIGNhcGl0YWwgbGV0dGVyIGFmdGVyICc6JyBieSBk
ZWZhdWx0LiBUaGUgYWJvdmUgbGluZQ0KPiBzaG91bGQgaW5zdGVhZCBiZToNCj4gDQo+ICAg
ICAgdG9vbHMvbGlicy9ldnRjaG46IGRlZHVwbGljYXRlIHhlbmV2dGNobl9mZCgpDQo+IA0K
DQpZZXMuDQoNCj4+ICsgICAgTUFJTlRBSU5FUlM6IHVwZGF0ZSBteSBlbWFpbCBhZGRyZXNz
DQo+PiArICAgIGJ1aWxkOiBjb3JyZWN0IHVzYWdlIGNvbW1lbnRzIGluIEtidWlsZC5pbmNs
dWRlDQo+PiArDQo+PiArVGhlIGRlc2NyaXB0aW9uIHNob3VsZCBnaXZlIGEgcm91Z2ggaGlu
dCAqd2hhdCogaXMgZG9uZSBpbiB0aGUgcGF0Y2guDQo+PiArDQo+PiArVGhlIHN1YmplY3Qg
bGluZSBzaG91bGQgaW4gZ2VuZXJhbCBub3QgZXhjZWVkIDgwIGNoYXJhY3RlcnMuIEl0IG11
c3QgYmUNCj4+ICtmb2xsb3dlZCBieSBhIGJsYW5rIGxpbmUuDQo+PiArDQo+PiArIyMgVGhl
IGNvbW1pdCBtZXNzYWdlDQo+PiArDQo+PiArVGhlIGNvbW1pdCBtZXNzYWdlIGlzIGZyZWUg
dGV4dCBkZXNjcmliaW5nICp3aHkqIHRoZSBwYXRjaCBpcyBkb25lIGFuZA0KPj4gKypob3cq
IHRoZSBnb2FsIG9mIHRoZSBwYXRjaCBpcyBhY2hpZXZlZC4gQSBnb29kIGNvbW1pdCBtZXNz
YWdlIHdpbGwgZGVzY3JpYmUNCj4+ICt0aGUgY3VycmVudCBzaXR1YXRpb24sIHRoZSBkZXNp
cmVkIGdvYWwsIGFuZCB0aGUgd2F5IHRoaXMgZ29hbCBpcyBiZWluZw0KPj4gK2FjaGlldmVk
LiBQYXJ0cyBvZiB0aGF0IGNhbiBiZSBvbWl0dGVkIGluIG9idmlvdXMgY2FzZXMuDQo+PiAr
DQo+PiArSW4gY2FzZSBhZGRpdGlvbmFsIGNoYW5nZXMgYXJlIGRvbmUgaW4gdGhlIHBhdGNo
IChsaWtlIGUuZy4gY2xlYW51cHMpLCB0aG9zZQ0KPj4gK3Nob3VsZCBiZSBtZW50aW9uZWQu
DQo+PiArDQo+PiArV2hlbiByZWZlcmVuY2luZyBvdGhlciBwYXRjaGVzIChlLmcuIGBwYXRj
aCB4eSBpbnRyb2R1Y2VkIGEgYnVnIC4uLmApIHRob3NlDQo+PiArcGF0Y2hlcyBzaG91bGQg
YmUgcmVmZXJlbmNlZCB2aWEgdGhlaXIgY29tbWl0IGlkIChhdCBsZWFzdCAxMiBkaWdpdHMp
IGFuZCB0aGUNCj4+ICtwYXRjaCBzdWJqZWN0Og0KPj4gKw0KPj4gKyAgICBDb21taXQgNjdk
MDFjZGI1NTE4ICgieDg2OiBpbmZyYXN0cnVjdHVyZSB0byBhbGxvdyBjb252ZXJ0aW5nIGNl
cnRhaW4NCj4+ICsgICAgaW5kaXJlY3QgY2FsbHMgdG8gZGlyZWN0IG9uZXMiKSBpbnRyb2R1
Y2VkIGEgYnVnIC4uLg0KPj4gKw0KPj4gK1RoZSBmb2xsb3dpbmcgYGBnaXQgY29uZmlnYGAg
c2V0dGluZ3MgY2FuIGJlIHVzZWQgdG8gYWRkIGEgcHJldHR5IGZvcm1hdCBmb3INCj4+ICtv
dXRwdXR0aW5nIHRoZSBhYm92ZSBzdHlsZSBpbiB0aGUgYGBnaXQgbG9nYGAgb3IgYGBnaXQg
c2hvd2BgIGNvbW1hbmRzOg0KPj4gKw0KPj4gKyAgICAgICAgW2NvcmVdDQo+PiArICAgICAg
ICAgICAgICAgIGFiYnJldiA9IDEyDQo+PiArICAgICAgICBbcHJldHR5XQ0KPj4gKyAgICAg
ICAgICAgICAgICBmaXhlcyA9IEZpeGVzOiAlaCAoXCIlc1wiKQ0KPj4gKw0KPj4gK0xpbmVz
IGluIHRoZSBjb21taXQgbWVzc2FnZSBzaG91bGQgbm90IGV4Y2VlZCA3NSBjaGFyYWN0ZXJz
LCBleGNlcHQgd2hlbg0KPj4gK2NvcHlpbmcgZXJyb3Igb3V0cHV0IGRpcmVjdGx5IGludG8g
dGhlIGNvbW1pdCBtZXNzYWdlLg0KPj4gKw0KPj4gKyMjIFRhZ3MNCj4+ICsNCj4+ICtUYWdz
IGFyZSBlbnRyaWVzIGluIHRoZSBmb3JtDQo+PiArDQo+PiArICAgIFRhZzogc29tZXRoaW5n
DQo+PiArDQo+PiArSW4gZ2VuZXJhbCB0YWdzIGFyZSBhZGRlZCBpbiBjaHJvbm9sb2dpY2Fs
IG9yZGVyLiBTbyBhIGBSZXZpZXdlZC1ieTpgIHRhZw0KPj4gK3Nob3VsZCBiZSBhZGRlZCAq
KmFmdGVyKiogdGhlIGBTaWduZWQtb2ZmLWJ5OmAgdGFnLCBhcyB0aGUgcmV2aWV3IGhhcHBl
bmVkDQo+PiArYWZ0ZXIgdGhlIHBhdGNoIHdhcyB3cml0dGVuLg0KPj4gKw0KPj4gK0RvIG5v
dCBzcGxpdCBhIHRhZyBhY3Jvc3MgbXVsdGlwbGUgbGluZXMsIHRhZ3MgYXJlIGV4ZW1wdCBm
cm9tIHRoZQ0KPj4gKyJ3cmFwIGF0IDc1IGNvbHVtbnMiIHJ1bGUgaW4gb3JkZXIgdG8gc2lt
cGxpZnkgcGFyc2luZyBzY3JpcHRzLg0KPj4gKw0KPj4gKyMjIyBUYWtlbi1mcm9tOg0KPj4g
Kw0KPj4gK1hlbiBoYXMgaW5oZXJpdGVkIHNvbWUgc291cmNlIGZpbGVzIGZyb20gb3RoZXIg
b3BlbiBzb3VyY2UgcHJvamVjdHMuIEluIGNhc2UNCj4+ICthIHBhdGNoIG1vZGlmeWluZyBz
dWNoIGFuIGluaGVyaXRlZCBmaWxlIGlzIHRha2VuIGZyb20gdGhhdCBwcm9qZWN0IChtYXli
ZSBpbg0KPj4gK21vZGlmaWVkIGZvcm0pLCB0aGUgYFRha2VuLWZyb206YCB0YWcgc3BlY2lm
aWVzIHRoZSBzb3VyY2Ugb2YgdGhlIHBhdGNoOg0KPj4gKw0KPj4gKyAgICBUYWtlbi1mcm9t
OiA8cmVwb3NpdG9yeS1VUkw+IDxjb21taXQtaWQ+DQo+PiArDQo+PiArRS5nLjoNCj4+ICsN
Cj4+ICsgICAgVGFrZW4tZnJvbTogZ2l0Oi8vZ2l0Lmtlcm5lbC5vcmcvcHViL3NjbS9saW51
eC9rZXJuZWwvZ2l0L3RvcnZhbGRzL2xpbnV4LmdpdCBmMDkzYjA4YzQ3YjMNCj4+ICsNCj4+
ICtBbGwgdGFncyAqKmFib3ZlKiogdGhlIGBUYWtlbi1mcm9tOmAgdGFnIGFyZSBmcm9tIHRo
ZSBvcmlnaW5hbCBwYXRjaCAod2hpY2gNCj4+ICtzaG91bGQgYWxsIGJlIGtlcHQpLCB3aGls
ZSB0YWdzICoqYWZ0ZXIqKiBgVGFrZW4tZnJvbTpgIGFyZSByZWxhdGVkIHRvIHRoZQ0KPj4g
K25vcm1hbCBYZW4gcGF0Y2ggcHJvY2VzcyBhcyBkZXNjcmliZWQgaGVyZS4NCj4+ICsNCj4+
ICsjIyMgRml4ZXM6DQo+PiArDQo+PiArSWYgeW91ciBwYXRjaCBmaXhlcyBhIGJ1ZyBpbiBh
IHNwZWNpZmljIGNvbW1pdCwgZS5nLiB5b3UgZm91bmQgYW4gaXNzdWUgdXNpbmcNCj4+ICtg
YGdpdCBiaXNlY3RgYCwgcGxlYXNlIHVzZSB0aGUgYEZpeGVzOmAgdGFnIHdpdGggdGhlIGZp
cnN0IDEyIGNoYXJhY3RlcnMgb2YNCj4+ICt0aGUgY29tbWl0IGlkLCBhbmQgdGhlIG9uZSBs
aW5lIHN1bW1hcnkuDQo+PiArDQo+PiArICAgIEZpeGVzOiA8Y29tbWl0LWlkPiAoIjxwYXRj
aC1zdWJqZWN0PiIpDQo+PiArDQo+PiArRS5nLjoNCj4+ICsNCj4+ICsgICAgRml4ZXM6IDY3
ZDAxY2RiNTUxOCAoIng4NjogaW5mcmFzdHJ1Y3R1cmUgdG8gYWxsb3cgY29udmVydGluZyBj
ZXJ0YWluIGluZGlyZWN0IGNhbGxzIHRvIGRpcmVjdCBvbmVzIikNCj4+ICsNCj4+ICsjIyMg
QmFja3BvcnQ6DQo+PiArDQo+PiArQSBiYWNrcG9ydCB0YWcgaXMgYW4gb3B0aW9uYWwgdGFn
IGluIHRoZSBjb21taXQgbWVzc2FnZSB0byByZXF1ZXN0IGENCj4+ICtnaXZlbiBjb21taXQg
dG8gYmUgYmFja3BvcnRlZCB0byB0aGUgcmVsZWFzZWQgdHJlZXM6DQo+PiArDQo+PiArICAg
IEJhY2twb3J0OiA8dmVyc2lvbj4gWyMgPGNvbW1lbnQ+XQ0KPiANCj4gU28gd2UgYWxyZWFk
eSBoYWQgYSBkb2N1bWVudGVkIHVzYWdlIG9mICcjJyBpbiB0YWdzLCB3aGljaCBJIHRoaW5r
DQo+IHNob3VsZCBtYWtlIGl0IGEgYmV0dGVyIGNhbmRpZGF0ZSBmb3IgdGhlIFItYiBzY29w
ZSBsaW1pdGluZy4NCg0KWWVzLCBJIGZvdW5kIHRoYXQgYnkgc3VycHJpc2UuDQoNCj4gDQo+
PiArDQo+PiArRS5nLjoNCj4+ICsNCj4+ICsgICAgQmFja3BvcnQ6IDQuOSsNCj4+ICsNCj4+
ICtJdCBtYXJrcyBhIGNvbW1pdCBmb3IgYmVpbmcgYSBjYW5kaWRhdGUgZm9yIGJhY2twb3J0
cyB0byBhbGwgcmVsZWFzZWQNCj4+ICt0cmVlcyBmcm9tIDQuOSBvbndhcmQuDQo+PiArDQo+
PiArVGhlIGJhY2twb3J0IHJlcXVlc3RlciBpcyBleHBlY3RlZCB0byBzcGVjaWZ5IHdoaWNo
IGN1cnJlbnRseSBzdXBwb3J0ZWQNCj4+ICtyZWxlYXNlcyBuZWVkIHRoZSBiYWNrcG9ydDsg
YnV0IGVuY291cmFnZWQgdG8gc3BlY2lmeSBhIHJlbGVhc2UgYXMgZmFyDQo+PiArYmFjayBh
cyBwb3NzaWJsZSB3aGljaCBhcHBsaWVzLiBJZiB0aGUgcmVxdWVzdGVyIGRvZXNuJ3Qga25v
dyB0aGUgb2xkZXN0DQo+PiArYWZmZWN0ZWQgdHJlZSwgdGhleSBhcmUgZW5jb3VyYWdlZCB0
byBhcHBlbmQgYSBjb21tZW50IGxpa2UgdGhlDQo+PiArZm9sbG93aW5nOg0KPj4gKw0KPj4g
KyAgICBCYWNrcG9ydDogNC45KyAjIG1heWJlIG9sZGVyDQo+PiArDQo+PiArTWFpbnRhaW5l
cnMgcmVxdWVzdCB0aGUgQmFja3BvcnQgdGFnIHRvIGJlIGFkZGVkIG9uIGNvbW1pdC4gQ29u
dHJpYnV0b3JzDQo+PiArYXJlIHdlbGNvbWUgdG8gbWFyayB0aGVpciBwYXRjaGVzIHdpdGgg
dGhlIEJhY2twb3J0IHRhZyB3aGVuIHRoZXkgZGVlbQ0KPj4gK2FwcHJvcHJpYXRlLiBNYWlu
dGFpbmVycyB3aWxsIHJlcXVlc3QgZm9yIGl0IHRvIGJlIHJlbW92ZWQgd2hlbiB0aGF0IGlz
DQo+PiArbm90IHRoZSBjYXNlLg0KPj4gKw0KPj4gK1BsZWFzZSBub3RlIHRoYXQgdGhlIEJh
Y2twb3J0IHRhZyBpcyBhICoqcmVxdWVzdCoqIGZvciBiYWNrcG9ydCwgd2hpY2gNCj4+ICt3
aWxsIHN0aWxsIG5lZWQgdG8gYmUgZXZhbHVhdGVkIGJ5IHRoZSBtYWludGFpbmVycy4gTWFp
bnRhaW5lcnMgbWlnaHQNCj4+ICthc2sgdGhlIHJlcXVlc3RlciB0byBoZWxwIHdpdGggdGhl
IGJhY2twb3J0aW5nIHdvcmsgaWYgaXQgaXMgbm90DQo+PiArdHJpdmlhbC4NCj4+ICsNCj4+
ICsjIyMgUmVwb3J0ZWQtYnk6DQo+PiArDQo+PiArVGhpcyBvcHRpb25hbCB0YWcgY2FuIGJl
IHVzZWQgdG8gZ2l2ZSBjcmVkaXQgdG8gc29tZW9uZSByZXBvcnRpbmcgYW4gaXNzdWUuDQo+
PiArSXQgaXMgaW4gdGhlIGZvcm1hdDoNCj4+ICsNCj4+ICsgICAgUmVwb3J0ZWQtYnk6IG5h
bWUgPGVtYWlsQGRvbWFpbj4NCj4+ICsNCj4+ICtFLmcuOg0KPj4gKw0KPj4gKyAgICBSZXBv
cnRlZC1ieTogSmFuZSBEb2UgPGphbmUuZG9lQGV4YW1wbGUub3JnPg0KPj4gKw0KPj4gK0Fz
IHRoZSBlbWFpbCBhZGRyZXNzIHdpbGwgYmUgbWFkZSBwdWJsaWMgdmlhIGdpdCwgdGhlIHJl
cG9ydGVyIG9mIGFuIGlzc3VlDQo+PiArc2hvdWxkIGJlIGFza2VkIHdoZXRoZXIgaGUvc2hl
IGlzIGZpbmUgd2l0aCBiZWluZyBtZW50aW9uZWQgaW4gdGhlIHBhdGNoLg0KPj4gKw0KPj4g
KyMjIyBTdWdnZXN0ZWQtYnk6DQo+PiArDQo+PiArVGhpcyBvcHRpb25hbCB0YWcgY2FuIGJl
IHVzZWQgdG8gZ2l2ZSBjcmVkaXQgdG8gc29tZW9uZSBoYXZpbmcgc3VnZ2VzdGVkIHRoZQ0K
Pj4gK3NvbHV0aW9uIHRoZSBwYXRjaCBpcyBpbXBsZW1lbnRpbmcuIEl0IGlzIGluIHRoZSBm
b3JtYXQ6DQo+PiArDQo+PiArICAgIFN1Z2dlc3RlZC1ieTogbmFtZSA8ZW1haWxAZG9tYWlu
Pg0KPj4gKw0KPj4gK0UuZy46DQo+PiArDQo+PiArICAgIFN1Z2dlc3RlZC1ieTogSmFuZSBE
b2UgPGphbmUuZG9lQGV4YW1wbGUub3JnPg0KPj4gKw0KPj4gK0FzIHRoZSBlbWFpbCBhZGRy
ZXNzIHdpbGwgYmUgbWFkZSBwdWJsaWMgdmlhIGdpdCwgdGhlIHJlcG9ydGVyIG9mIGFuIGlz
c3VlDQo+PiArc2hvdWxkIGJlIGFza2VkIHdoZXRoZXIgaGUvc2hlIGlzIGZpbmUgd2l0aCBi
ZWluZyBtZW50aW9uZWQgaW4gdGhlIHBhdGNoLg0KPj4gKw0KPj4gKyMjIyBTaWduZWQtb2Zm
LWJ5Og0KPj4gKw0KPj4gK1RoaXMgbWFuZGF0b3J5IHRhZyBzcGVjaWZpZXMgdGhlIGF1dGhv
cihzKSBvZiBhIHBhdGNoIChmb3IgZWFjaCBhdXRob3IgYQ0KPj4gK3NlcGFyYXRlIGBTaWdu
ZWQtb2ZmLWJ5OmAgdGFnIGlzIG5lZWRlZCkuIEl0IGlzIGluIHRoZSBmb3JtYXQ6DQo+PiAr
DQo+PiArICAgIFNpZ25lZC1vZmYtYnk6IG5hbWUgPGVtYWlsQGRvbWFpbj4NCj4+ICsNCj4+
ICtFLmcuOg0KPj4gKw0KPj4gKyAgICBTaWduZWQtb2ZmLWJ5OiBKYW5lIERvZSA8amFuZS5k
b2VAZXhhbXBsZS5vcmc+DQo+PiArDQo+PiArVGhlIGF1dGhvciBtdXN0IGJlIGEgbmF0dXJh
bCBwZXJzb24gKG5vdCBhIHRlYW0gb3IganVzdCBhIGNvbXBhbnkpIGFuZCB0aGUNCj4+ICtg
U2lnbmVkLW9mZi1ieTpgIHRhZyBtdXN0IGluY2x1ZGUgdGhlIHJlYWwgbmFtZSBvZiB0aGUg
YXV0aG9yIChubyBwc2V1ZG9ueW0pLg0KPj4gKw0KPj4gK0J5IHNpZ25pbmcgdGhlIHBhdGNo
IHdpdGggaGVyL2hpcyBuYW1lIHRoZSBhdXRob3IgZXhwbGljaXRseSBjb25maXJtcyB0byBo
YXZlDQo+PiArbWFkZSB0aGUgY29udHJpYnV0aW9uIGNvbmZvcm1pbmcgdG8gdGhlIGBEZXZl
bG9wZXIncyBDZXJ0aWZpY2F0ZSBvZiBPcmlnaW5gOg0KPj4gKw0KPj4gKyAgICBEZXZlbG9w
ZXIncyBDZXJ0aWZpY2F0ZSBvZiBPcmlnaW4gMS4xDQo+PiArDQo+PiArICAgIEJ5IG1ha2lu
ZyBhIGNvbnRyaWJ1dGlvbiB0byB0aGlzIHByb2plY3QsIEkgY2VydGlmeSB0aGF0Og0KPj4g
Kw0KPj4gKyAgICAoYSkgVGhlIGNvbnRyaWJ1dGlvbiB3YXMgY3JlYXRlZCBpbiB3aG9sZSBv
ciBpbiBwYXJ0IGJ5IG1lIGFuZCBJDQo+PiArICAgICAgICBoYXZlIHRoZSByaWdodCB0byBz
dWJtaXQgaXQgdW5kZXIgdGhlIG9wZW4gc291cmNlIGxpY2Vuc2UNCj4+ICsgICAgICAgIGlu
ZGljYXRlZCBpbiB0aGUgZmlsZTsgb3INCj4+ICsNCj4+ICsgICAgKGIpIFRoZSBjb250cmli
dXRpb24gaXMgYmFzZWQgdXBvbiBwcmV2aW91cyB3b3JrIHRoYXQsIHRvIHRoZSBiZXN0DQo+
PiArICAgICAgICBvZiBteSBrbm93bGVkZ2UsIGlzIGNvdmVyZWQgdW5kZXIgYW4gYXBwcm9w
cmlhdGUgb3BlbiBzb3VyY2UNCj4+ICsgICAgICAgIGxpY2Vuc2UgYW5kIEkgaGF2ZSB0aGUg
cmlnaHQgdW5kZXIgdGhhdCBsaWNlbnNlIHRvIHN1Ym1pdCB0aGF0DQo+PiArICAgICAgICB3
b3JrIHdpdGggbW9kaWZpY2F0aW9ucywgd2hldGhlciBjcmVhdGVkIGluIHdob2xlIG9yIGlu
IHBhcnQNCj4+ICsgICAgICAgIGJ5IG1lLCB1bmRlciB0aGUgc2FtZSBvcGVuIHNvdXJjZSBs
aWNlbnNlICh1bmxlc3MgSSBhbQ0KPj4gKyAgICAgICAgcGVybWl0dGVkIHRvIHN1Ym1pdCB1
bmRlciBhIGRpZmZlcmVudCBsaWNlbnNlKSwgYXMgaW5kaWNhdGVkDQo+PiArICAgICAgICBp
biB0aGUgZmlsZTsgb3INCj4+ICsNCj4+ICsgICAgKGMpIFRoZSBjb250cmlidXRpb24gd2Fz
IHByb3ZpZGVkIGRpcmVjdGx5IHRvIG1lIGJ5IHNvbWUgb3RoZXINCj4+ICsgICAgICAgIHBl
cnNvbiB3aG8gY2VydGlmaWVkIChhKSwgKGIpIG9yIChjKSBhbmQgSSBoYXZlIG5vdCBtb2Rp
ZmllZA0KPj4gKyAgICAgICAgaXQuDQo+PiArDQo+PiArICAgIChkKSBJIHVuZGVyc3RhbmQg
YW5kIGFncmVlIHRoYXQgdGhpcyBwcm9qZWN0IGFuZCB0aGUgY29udHJpYnV0aW9uDQo+PiAr
ICAgICAgICBhcmUgcHVibGljIGFuZCB0aGF0IGEgcmVjb3JkIG9mIHRoZSBjb250cmlidXRp
b24gKGluY2x1ZGluZyBhbGwNCj4+ICsgICAgICAgIHBlcnNvbmFsIGluZm9ybWF0aW9uIEkg
c3VibWl0IHdpdGggaXQsIGluY2x1ZGluZyBteSBzaWduLW9mZikgaXMNCj4+ICsgICAgICAg
IG1haW50YWluZWQgaW5kZWZpbml0ZWx5IGFuZCBtYXkgYmUgcmVkaXN0cmlidXRlZCBjb25z
aXN0ZW50IHdpdGgNCj4+ICsgICAgICAgIHRoaXMgcHJvamVjdCBvciB0aGUgb3BlbiBzb3Vy
Y2UgbGljZW5zZShzKSBpbnZvbHZlZC4NCj4+ICsNCj4+ICsjIyMgUmV2aWV3ZWQtYnk6DQo+
PiArDQo+PiArQSBgUmV2aWV3ZWQtYnk6YCB0YWcgY2FuIG9ubHkgYmUgZ2l2ZW4gYnkgYSBy
ZXZpZXdlciBvZiB0aGUgcGF0Y2guIFdpdGgNCj4+ICtyZXNwb25kaW5nIHRvIGEgc2VudCBw
YXRjaCBhZGRpbmcgdGhlIGBSZXZpZXdlZC1ieTpgIHRhZyB0aGUgcmV2aWV3ZXINCj4+ICso
d2hpY2ggY2FuIGJlIGFueWJvZHkpIGNvbmZpcm1zIHRvIGhhdmUgbG9va2VkIHRob3JvdWdo
bHkgYXQgdGhlIHBhdGNoIGFuZA0KPj4gK2RpZG4ndCBmaW5kIGFueSBpc3N1ZSAoYmVpbmcg
aXQgdGVjaG5pY2FsLCBsZWdhbCBvciBmb3JtYWwgb25lcykuIElmIHRoZQ0KPj4gK3Jldmll
dyBpcyBjb3ZlcmluZyBvbmx5IHNvbWUgcGFydHMgb2YgdGhlIHBhdGNoLCB0aG9zZSBwYXJ0
cyBjYW4gb3B0aW9uYWxseQ0KPj4gK2JlIHNwZWNpZmllZCAobXVsdGlwbGUgYXJlYXMgY2Fu
IGJlIGNvdmVyZWQgd2l0aCBtdWx0aXBsZSBgUmV2aWV3ZWQtYnk6YA0KPj4gK3RhZ3MpLiBJ
dCBpcyBpbiB0aGUgZm9ybWF0Og0KPj4gKw0KPj4gKyAgICBSZXZpZXdlZC1ieTogbmFtZSA8
ZW1haWxAZG9tYWluPiBbIyBhcmVhXQ0KPj4gKw0KPj4gK0UuZy46DQo+PiArDQo+PiArICAg
IFJldmlld2VkLWJ5OiBKYW5lIERvZSA8amFuZS5kb2VAZXhhbXBsZS5vcmc+DQo+PiArICAg
IFJldmlld2VkLWJ5OiBKYW5lIERvZSA8amFuZS5kb2VAZXhhbXBsZS5vcmc+ICMgeGVuL3g4
Ng0KPiANCj4gSSB0aGluayB5b3Ugc2hvdWxkIG1lbnRpb24gaW4gdGhlIGNvbW1pdCBtZXNz
YWdlIHRoYXQgd2UgYXJlIGFsc28NCj4gYWRkaW5nIHRoZSBSLWIgc2NvcGUgbGltaXRpbmcg
aW4gdGhpcyBjb21taXQ/IFRoZSBjb21taXQgbWVzc2FnZSBtYWtlcw0KPiBpdCBsb29rIGxp
a2UgdGhpcyBpcyBtb3N0bHkgbW92aW5nIHRoZSBleGlzdGluZyBUYWdzIGludG8gYSBuZXcN
Cj4gZG9jdW1lbnQuDQoNClNhbWUgZm9yIHRoZSAiVGFrZW4tZnJvbToiIHRhZy4NCg0KTWF5
YmUgSSBzaG91bGQgZXZlbiBzcGxpdCB0aGUgcGF0Y2ggYW5kIGFkZCB0aGUgZXh0ZW5zaW9u
IG9mDQoiUmV2aWV3ZWQtYnk6IiBhbmQgdGhlIG5ldyAiVGFrZW4tZnJvbToiIGFzIHNlcGFy
YXRlIHBhdGNoZXMsIGluIG9yZGVyDQp0byBtYWtlIHRoZSBhZGRpdGlvbiBtb3JlIGNsZWFy
LiBBZGRpdGlvbmFsbHkgdGhlIGJhc2UgZG9jdW1lbnQgbWlnaHQNCmdvIGluIHdoaWxlIHdl
IGFyZSBzdGlsbCBkaXNjdXNzaW5nIHRoZSBhZGRpdGlvbnMuDQoNCj4gDQo+PiArDQo+PiAr
SW4gY2FzZSBhIHBhdGNoIGlzIGJlaW5nIHJlc2VudCBhbiBhbHJlYWR5IGdpdmVuIGBSZXZp
ZXdlZC1ieTpgIHRhZyBjYW4gYW5kDQo+PiArc2hvdWxkIGJlIGluY2x1ZGVkLCBpZiB0aGUg
cGF0Y2ggZGlkbid0IGNoYW5nZSB0aGUgcG9ydGlvbnMgb2YgdGhlIHBhdGNoDQo+PiArY292
ZXJlZCBieSB0aGUgdGFnLCBvciBpZiB0aGUgcmV2aWV3ZXIgYWxyZWFkeSBtYWRlIGNsZWFy
IGl0IHdvdWxkIGJlIGZpbmUNCj4+ICt0byBtYWtlIHNwZWNpZmljIGNoYW5nZXMgYW5kIG5v
ICpvdGhlciogY2hhbmdlcyBoYXZlIGJlZW4gbWFkZS4NCj4+ICsNCj4+ICsjIyMgQWNrZWQt
Ynk6DQo+PiArDQo+PiArU2ltaWxhciB0byBgUmV2aWV3ZWQtYnk6YCB0aGUgYEFja2VkLWJ5
OmAgdGFnIGlzIGdpdmVuIGJ5IHNvbWVvbmUgaGF2aW5nIGxvb2tlZA0KPj4gK2F0IHRoZSBw
YXRjaC4gVGhlIGBBY2tlZC1ieTpgIHRhZyBjYW4gb25seSBiZSBnaXZlbiBieSBhICoqbWFp
bnRhaW5lcioqIG9mIHRoZQ0KPj4gK21vZGlmaWVkIGNvZGUsIGFuZCBpdCBvbmx5IGNvdmVy
cyB0aGUgY29kZSB0aGUgbWFpbnRhaW5lciBpcyByZXNwb25zaWJsZSBmb3IuDQo+PiArRm9y
IHRoaXMgcmVhc29uIHRoZXJlIGlzIG5vIG9wdGlvbmFsIGFyZWEgcG9zc2libGUuIFdpdGgg
dGhlIGBBY2tlZC1ieTpgIHRhZw0KPj4gK3RoZSBtYWludGFpbmVyIHN0YXRlcywgdGhhdCBo
ZS9zaGUgaXMgZmluZSB3aXRoIHRoZSBjaGFuZ2VzIGluIHByaW5jaXBsZSwgYnV0DQo+PiAr
ZGlkbid0IGRvIGEgdGhvcm91Z2ggcmV2aWV3LiBUaGUgZm9ybWF0IGlzOg0KPj4gKw0KPj4g
KyAgICBBY2tlZC1ieTogbmFtZSA8ZW1haWxAZG9tYWluPg0KPj4gKw0KPj4gK0UuZy46DQo+
PiArDQo+PiArICAgIEFja2VkLWJ5OiBKYW5lIERvZSA8amFuZS5kb2VAZXhhbXBsZS5vcmc+
DQo+PiArDQo+PiArSW5jbHVkaW5nIHRoZSBgQWNrZWQtYnk6YCB0YWcgaW4gYSBwYXRjaCBp
cyBkb25lIHVuZGVyIHRoZSBzYW1lIHJ1bGVzIGFzIGZvcg0KPj4gK3RoZSBgUmV2aWV3ZWQt
Ynk6YCB0YWcsIHdpdGggdGhlIGltcGxpZWQgY29kZSBhcmVhIHRoZSBtYWludGFpbmVyIHdo
byBnYXZlIHRoZQ0KPj4gK2BBY2tlZC1ieTpgIHRhZyBpcyByZXNwb25zaWJsZSBmb3IuDQo+
PiArDQo+PiArIyMjIFRlc3RlZC1ieToNCj4+ICsNCj4+ICtUaGUgYFRlc3RlZC1ieTpgIHRh
ZyBpcyBhbm90aGVyIHRhZyBnaXZlbiBieSBzb21lb25lIGVsc2UuIFRoZSBvbmUgZ2l2aW5n
IGl0DQo+PiArY29uZmlybXMgdG8gaGF2ZSB0ZXN0ZWQgdGhlIHBhdGNoIHdpdGhvdXQgZmlu
ZGluZyBhbnkgZnVuY3Rpb25hbCBpc3N1ZXMuIFRoZQ0KPj4gK2Zvcm1hdCBpczoNCj4+ICsN
Cj4+ICsgICAgVGVzdGVkLWJ5OiBuYW1lIDxlbWFpbEBkb21haW4+DQo+IA0KPiBUcmFpbGlu
ZyB3aGl0ZSBzcGFjZS4NCg0KVGhhbmtzLg0KDQo+IA0KPj4gKw0KPj4gK0UuZy46DQo+PiAr
DQo+PiArICAgIFRlc3RlZC1ieTogSmFuZSBEb2UgPGphbmUuZG9lQGV4YW1wbGUub3JnPg0K
Pj4gKw0KPj4gK0luY2x1ZGluZyB0aGUgYFRlc3RlZC1ieTpgIHRhZyBpbiBhIHBhdGNoIGlz
IGRvbmUgdW5kZXIgdGhlIHNhbWUgcnVsZXMgYXMgZm9yDQo+PiArdGhlIGBSZXZpZXdlZC1i
eTpgIHRhZywgbm93IGxpbWl0ZWQgdG8gdGhlIHBhdGNoIG5vdCBoYXZpbmcgYmVlbiBtb2Rp
ZmllZA0KPj4gK3JlZ2FyZGluZyBjb2RlIGxvZ2ljIChoYXZpbmcgY2hhbmdlZCBvbmx5IGNv
ZGluZyBzdHlsZSwgY29tbWVudHMsIG9yIG1lc3NhZ2UNCj4+ICt0ZXh0cyBpcyBmaW5lKS4N
Cj4+ICsNCj4+ICsjIyBQYXRjaCB2ZXJzaW9uIGhpc3RvcnkgKGNoYW5nZSBsb2cpLCBmdXJ0
aGVyIGNvbW1lbnRzDQo+PiArDQo+PiArV2hlbiBzZW5kaW5nIHJldmlzZWQgdmVyc2lvbnMg
b2YgYSBwYXRjaCBpdCBpcyBnb29kIHByYWN0aWNlIHRvIGluY2x1ZGUgYQ0KPj4gK2NoYW5n
ZSBsb2cgYWZ0ZXIgYSBsaW5lIGNvbnRhaW5pbmcgb25seSBgLS0tYCAodGhpcyBsaW5lIHdp
bGwgcmVzdWx0IGluIHRoZQ0KPj4gK2ZvbGxvd2luZyB0ZXh0IG5vdCBiZWluZyBpbmNsdWRl
ZCBpbiB0aGUgY29tbWl0IG1lc3NhZ2UpLiBUaGlzIGNoYW5nZSBsb2cNCj4+ICt3aWxsIGhl
bHAgcmV2aWV3ZXJzIHRvIHNwb3Qgd2hpY2ggcGFydHMgb2YgdGhlIHBhdGNoIGhhdmUgY2hh
bmdlZC4gQXR0cmlidXRpbmcNCj4+ICtjaGFuZ2VzIGR1ZSB0byByZXZpZXdlciBjb21tZW50
cyB3aWxsIGhlbHAgdGhlIHJldmlld2VyIGV2ZW4gbW9yZSwgZS5nLjoNCj4+ICsNCj4+ICsg
ICAgLS0tDQo+PiArICAgIENoYW5nZXMgaW4gVjI6DQo+IA0KPiBJIHdvdWxkIHVzZSB2MiAo
bG93ZXJjYXNlICd2JyksIGJlY2F1c2UgdGhhdCdzIGhvdyBnaXQgZm9ybWF0LXBhdGNoDQo+
IHBsYWNlcyB0aGUgdmVyc2lvbiBpbiB0aGUgc3ViamVjdCBsaW5lLg0KDQpPa2F5Lg0KDQo+
IA0KPj4gKyAgICAtIGNoYW5nZWQgZnVuY3Rpb24gZm9vKCkgYXMgcmVxdWVzdGVkIGJ5IEph
bmUgRG9lDQo+PiArICAgIC0gY29kZSBzdHlsZSBmaXhlZA0KPj4gKw0KPj4gK0luIHNvbWUg
Y2FzZXMgaXQgbWlnaHQgYmUgZGVzaXJhYmxlIHRvIGFkZCBzb21lIG1vcmUgaW5mb3JtYXRp
b24gZm9yIHJlYWRlcnMNCj4+ICtvZiB0aGUgcGF0Y2gsIGxpa2UgcG90ZW50aWFsIGVuaGFu
Y2VtZW50cywgb3RoZXIgcG9zc2libGUgc29sdXRpb25zLCBldGMuLA0KPj4gK3doaWNoIHNo
b3VsZCBub3QgYmUgcGFydCBvZiB0aGUgY29tbWl0IG1lc3NhZ2UuIFRoaXMgaW5mb3JtYXRp
b24gY2FuIGJlDQo+PiArYWRkZWQgYWZ0ZXIgdGhlIGAtLS1gIGxpbmUsIHRvby4NCj4+ICsN
Cj4+ICsjIyBSZWNpcGllbnRzIG9mIHRoZSBwYXRjaA0KPj4gKw0KPj4gK0EgcGF0Y2ggc2hv
dWxkIGFsd2F5cyBiZSBzZW50ICoqdG8qKiB0aGUgeGVuLWRldmVsIG1haWxpbmcgbGlzdCA8
eGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnPiBhbmQgYWxsIG1haW50YWluZXJzIG9m
IGFsbCB0b3VjaGVkIGNvZGUgYXJlYXMgc2hvdWxkIGdldCBhDQo+IA0KPiBNaXNzaW5nIG5l
d2xpbmUuDQoNCldlaXJkIEkgbWlzc2VkIHRoYXQuDQoNCg0KSnVlcmdlbg0KDQo=
--------------86hsX0iHbZ3pJWtk5QSGzbL2
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------86hsX0iHbZ3pJWtk5QSGzbL2--

--------------Y0NNAV9In0e0sq0drP3Ptrqe--

--------------27D0eX2GccdyyTSZhwr0TFWM
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmH7pGEFAwAAAAAACgkQsN6d1ii/Ey/J
8gf/TbDunaVa8bLkIOw4wq39AjAn8/VHRxvvCW/YpNr7Uw6oJ6j4+R0eH/oUikPE7G/vx30AoO/V
AFQqFqRkE9EZ51YAQ6lfHB0zxGiTd3snAHqcMWy2lvGoAbrVBy4dBAueqzH+y+WkDbetZCRHX1mJ
XWOVIZ0pYeFzb0fI9hOJPnNa5xL6cLixKDaYSdi1FMCs7Z1K6cGSMQjTQ8XYd8WGdjWH0nRyMmoU
Rb33rV0caUCCV8sHKw6h+rArTXrZmMrYKh+ywtN7pKqMXMMxnWl/po1dGdh7sx4gNXMR6aR92KFU
PLKJ0UzADlYKh10pI1q1M/3Wau5QL8KMV3q3tChuAg==
=+h4o
-----END PGP SIGNATURE-----

--------------27D0eX2GccdyyTSZhwr0TFWM--


From xen-devel-bounces@lists.xenproject.org Thu Feb 03 09:52:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 03 Feb 2022 09:52:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264579.457710 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFYnI-0000OG-TW; Thu, 03 Feb 2022 09:52:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264579.457710; Thu, 03 Feb 2022 09:52:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFYnI-0000O9-QN; Thu, 03 Feb 2022 09:52:48 +0000
Received: by outflank-mailman (input) for mailman id 264579;
 Thu, 03 Feb 2022 09:52:46 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mjBt=SS=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nFYnG-0000O0-KZ
 for xen-devel@lists.xenproject.org; Thu, 03 Feb 2022 09:52:46 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0824784f-84d7-11ec-8eb8-a37418f5ba1a;
 Thu, 03 Feb 2022 10:52:44 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0824784f-84d7-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1643881964;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=B1RccMnwHrlHmCUeK/pPU+jtGv7v8/K2Rkap9RK4KA0=;
  b=eaE2iNUaM/n0xVszn8HtAC2yygS1Qkc8ZBE8ye8TyCfmiAdcBEuUsdQT
   ee1Nl3shLL69MqD5jh76POsM0twukaLSp9RRt0ZYPRREUtFcG0YEaWV3A
   BIKB4LpvpFGYNzcAExgt9ITHergIEEhsudM4Th+ulafDF+brVRZMPx55L
   c=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: 3+23iLLTUPIn+zkneI23LWqxALA5bUZPwZOu+xZ5HFrNr4+1NwulTLfb+4mMBmyLs7a0sb5Il9
 v2rdC9UE+zgpnyT/VWgGwlRS32S41auG5mMUe7Qfso7kQWBbOdmhNZg5uU646CcN8nmVfaZ5Sw
 hl9Cevu9asblWNBhqp4Z4WraWVpF5zYHa3utS//IqgNstRePCLYllT2VaWprfiXJoheRy/imbC
 MmwKNN4AouoOTN/l7zQ4NGovzzcGSI/53fXybE+bm6Guv2ahePHwk+1ZwbbtSb7ogHiLKFJOLZ
 JjdmgxJpzjNxW1eO9Dpagw/W
X-SBRS: 5.2
X-MesageID: 62858562
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:DlKHEKDJNNXaXRVW/5fkw5YqxClBgxIJ4kV8jS/XYbTApD1w3zIAx
 jRMC2zXPvqNYzTxet9+boTi8EwPsZbQn9JqQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMo/u1Si6FatANl1ElvU2zbue6WL6s1hxZH1c+En970Uk7wobVv6Yz6TSHK1LV0
 T/Ni5W31G+Ng1aY5UpNtspvADs21BjDkGtwUm4WPJinj3eH/5UhN7oNJLnZEpfNatI88thW5
 Qr05OrREmvxp3/BAz4++1rxWhVirrX6ZWBihpfKMkQLb9crSiEai84G2PQghUh/1g2Mltdhl
 9l3qrPhRCgbFaLRvsA3ekwNe81+FfUuFL7vJHG+tYqYzlHccmuqyPJrZK00FdRGoKAtWzgIr
 KFGbmBWBvyAr7veLLaTUO5ji95lNMD2FIgepmth3XfSCvNOrZXrHf+auI8Fgm1YasZmDf3CR
 /glcRdTd079bR9ICgw3MMk9g7L97pX4W2IB8w/EzUYt2EDPxQl4y5DxM97YfNObSMETlUGdz
 kre52XjCRgePdaC4TCE7n6hiOLJkS7hHokVEdWQ//9xiVyXz0QZCQEaWFW2p/W0kAi1XNc3A
 1Qd5y4GvaU0skuxQbHVXRe1vXqFtR40QMdLHqsx7wTl4rrZ5UOVC3YJShZFacc6r4kmSDoyz
 FiLktj1Qzt1v9W9Vna15rqS6zSoNkAowXQqPHFeC1Ffup+6/d913kmnostf/LCd0+XwEDbgn
 DywswdvipohpsEW8YGR1AWS696znaThQgkw7wTRe2uq6AJleYKoD7CVBUjnAeVod9jAEATY1
 JQQs43Htb1VU8nR/MCYaLhVRNmUC+C53CowaLKFN70o7HyT9nGqZui8CxkudR4yYq7oldIEC
 XI/WD+9BrcOZBNGjoctOupd7vjGK4C6TrwJsdiPNrJzjmBZLlPvwc2XTRf4M5rRuEYti7ojH
 pyQbNyhC30XYYw+kmbtF7xAj+J6nX9lrY82eXwd5078uVZ5TCXNIYrpzXPUNrxphE96iFm9H
 ylj2zuilEwEDbyWjtj/+o8PN1EaRUXX9ritw/G7gtWre1I8cEl4Uqe56ep4J+RNwvoJ/s+Vo
 CDVchIImTLX2CycQS3XOy8LVV8adcslxZ7NFXZybQ/ANrlKSdvH0ZrzgLNsLOR+qbw+kaUpJ
 xTHEu3Zaslypv380211RbH2rZB4dQTtggSLPiG/ZyM4cYImTAvMkuIItCO2nMXXJibo58Y4v
 ZO60QbXHcgKSwh4VZ6EY/Oz1VKh+3ManbsqDUfPJ9BSfmTq8ZRrdHOt3qNmfZlUJEWR3Cae2
 iaXHQwc+bvHrbgq/YSbnquDtYqoTbdzRxIIA2nB4L+qHiDG5W7/k5RYWeOFcGmFBmP58amvf
 8tPyPT4PKFVlVpGqdMkQb1q0bg/953koLoDllZoG3DCblKKDLJ8IybZgZkT5/MVnrIA4Fm4Q
 EOC/NVeKI6lAsK9HQ5DPhchY8SCyeoQxmvY48MqLRio/yRw5reGDxlfZkHelCxHIbJpG4o52
 uN96tUO4gmyhxd2YNaLiidYqzaFInAaCvh1s5gbBMngixYxy0EEapvZU3ek7JaKYtRKE08rP
 j7L2/aS2+UCnhLPIygpCHzA/etBnpBf6hlFwWgLK0mNhteY1OQ82wdc8GhvQwlYpvmdPzmf5
 oS/25VJGJiz
IronPort-HdrOrdr: A9a23:yhp4M6P4T63UicBcT1v155DYdb4zR+YMi2TDiHoedfUFSKOlfp
 6V8MjztSWVtN4QMEtQ/+xoHJPwPE80kqQFnbX5XI3SJjUO3VHIEGgM1/qG/9SNIVybygcZ79
 YeT0EcMqyBMbEZt7eD3ODQKb9Jq7PrgcPY59s2jU0dNj2CA5sQnjuRYTzra3GeKjM2YqbQQ/
 Gnl7R6TnebCD4qR/X+IkNAc/nIptXNmp6jSRkaByQ/4A3LqT+z8rb1HzWRwx9bClp0sPsf2F
 mAtza8yrSosvm9xBOZ/2jP765OkN+k7tdYHsSDhuUcNz2poAe1Y4ZKXaGEoVkO0aySwWdvtO
 OJjwYrPsx15X+UVmapoSH10w2l6zoq42+K8y7QvVLT5ejCAB4qActIgoxUNjHD7VA7gd162K
 VXm0qEqpt+F3r77WXAzumNcysvulu/oHIkn+JWpWdYS5EiZLhYqpFa1F9JEa0HADnx5OkcYa
 dT5fnnlbVrmG6hHjLkVjEF+q3oYp1zJGbIfqE6gL3U79AM90oJi3fxx6Qk7wE9HdwGOt55Dt
 //Q9ZVfYd1P7grhJJGdZQ8qPSMexnwqDL3QSqvyAfcZeo600ykke+C3Fxy3pDtRKA1
X-IronPort-AV: E=Sophos;i="5.88,339,1635220800"; 
   d="scan'208";a="62858562"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=bJMNm3FkGELxjxDA0n7CmsbOa/iG/OmDjvU5BMjizwuNmPT4EUHY8XGLvFNSlj7lWtlkAbNeERq5p5KzhuCdOI+aTQHyx0sJXtlTyWsefaPILfVGeKlTxougkWGUjMZmEyUTghYQ+grXHnqOwEtcWW58MftuZXboQsTSwvedN2tx6zLdobFQwkYilhkYhOf82RohDatC3JTbTvc6ghyCL0rGS4IjoZCAMNLRsfiDURDih+FG4kcTKWx/3HwQlkVAcXWczhFmwC3p05WsrecWnbsVdn6dPkYFNzxEIYKmztfWwyNAsUYwz5UiXjN2iowkHgmmZPyyjYKhivFTLaFFiQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=5KEUghfDt3DRQtQA4I7P0DPj+90F4WVJn336jZSh78M=;
 b=aa9GzABhMCFIMLD3O4O45m+49DNDkPHtM5DMSvwJ5R6tFl2AbhWKsA9/z8ZAjxbxd1EBbgZpOhGxJcn95bI+iFn6v9NbhwZdDbQeGVGsLrbAqz6URdYLBHpVFHkcNy8pOPkjLG/XP4eVeyBxIljeL2pOv/acEG1uo1unpGfxhbGKxg8fjmvLwN+kAwYfm764dQGR9mFpXU1YCEEDNqEJS+MhxcOEWj6EF+rT3tsL4ObpaNSFAZ90URmiQvsub33PEyCjsMOx6q9PhJEibiHgH7bzgRLo3y7DYQthcL5ceBqa0d/bmYMn8bX7tH1jWv+TOV9ZxGi/bbRwkS3kCXav5g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=5KEUghfDt3DRQtQA4I7P0DPj+90F4WVJn336jZSh78M=;
 b=w+zHX2SvnwiTa7NV2KQR/gNKz1J5j2zB2LIvQmY96yPWEEUwkFBddUlCuJzp1/TyoNUhTqDe2IyUcu4R5cWvPN8bBROKndyM+LnY1u3Q2FwfJYrcodgp8xVpyMW/XVMbudNpB3JNQyztPZN0ofx7ZprXeZQcs1VS2uKaV6aGTaw=
Date: Thu, 3 Feb 2022 10:52:34 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Andrew
 Cooper" <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>, George Dunlap
	<george.dunlap@citrix.com>, Paul Durrant <paul@xen.org>, Tamas K Lengyel
	<tamas@tklengyel.com>, Petre Pircalabu <ppircalabu@bitdefender.com>,
	Alexandru Isaila <aisaila@bitdefender.com>
Subject: Re: [PATCH v3 1/2] IOMMU/x86: disallow device assignment to PoD
 guests
Message-ID: <Yful4oPqwzw3lsjp@Air-de-Roger>
References: <6fe7b036-2bdb-b391-4e6c-1b5d7e05a119@suse.com>
 <b0a77526-17f2-a5ab-6f7f-1b3caeb4a59b@suse.com>
 <YfqtlZMAKd/HXsgf@Air-de-Roger>
 <2cd051c8-dac0-998c-cced-401c504ad439@suse.com>
 <Yfuahx0ntHJ2BQ6x@Air-de-Roger>
 <7c315902-e618-bba6-054d-86b0aa685370@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <7c315902-e618-bba6-054d-86b0aa685370@suse.com>
X-ClientProxiedBy: LO4P123CA0388.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:18f::15) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 14485d88-cca4-45ee-bba6-08d9e6fae9b7
X-MS-TrafficTypeDiagnostic: CY4PR03MB3238:EE_
X-Microsoft-Antispam-PRVS: <CY4PR03MB3238E73C4FFE31C9DA5CE8328F289@CY4PR03MB3238.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: HssSX6WagR3tJ0SRgN7F6smPYsU6lppzvIBsgd7vqP0x32+D1OUcK4sk8IwxXxUhqqyZa7wG9qZNKZM/eqPjPkHcvvbQbkzzmoWqA7GMUguU0uUXA+0ii/bdksuZU1hIAon13SvNaS6LUehEeoaT0l+/Sj1+BJk6yHi1LGnIyh3wIvvhMaqwlK438vZJbBD3eYYwBFd0KDr/w8Z+LqkwvCTYt2oyGYRhJCDTNwdTrjx6LUUUwznF3t+NjCNdOoYJMjipO2dwWZnwQ74T7nqA+0kpAZWJsqWnl7TpeMnpI94LFNFeaFt8BZAJMe/fKvUhJ4vFMa2/OqnqcNjUdT/x8de7Vv3Ja+0uPDYFDdFvrz8/RtEGDx1DWC7l86QXMuwe78NO+yCxsvnkq8NSSQrEKSbclSnAMZJjlCUV2Y5oeKjhlNYrDh6CQSaPDpCuW+NlEbgRltMh/o8FlPUcYB4UfmaZdTdELYCVI7QvTMnmXiUTdzM5v7nLFf9/SCQGQVEt1wSjTJP34T+88UXDh01O8GbOqEhOkqaJdX2Tw08DfJVlV4L6jwGAblKwWdFVycUXsNcdOKQymRm3lqAiTDdFzmop4+NekLoqgGZz2Eb8nVHMV5p1SiH+Qz7qfpgrG7n+qXzcImOtI0T1j3mnGqyoQA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(6512007)(186003)(26005)(5660300002)(2906002)(85182001)(53546011)(33716001)(6666004)(66476007)(9686003)(66556008)(6506007)(86362001)(4326008)(66946007)(8676002)(8936002)(54906003)(82960400001)(6916009)(316002)(6486002)(38100700002)(83380400001)(508600001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZnJhYjVJWkMvaTFoYUVocW9xbWUzeW0xZ1RvUGpqTUtKckI4eFZqdDM4alVa?=
 =?utf-8?B?TmpJQjJjSlJZNERoWVdWWkUxNUNHaGgxaXI0Sk5WY05lTU1naFNZclprT3Ny?=
 =?utf-8?B?YkFPYUxIdkZkNFlIR3NtYURwMGhVZUtrL0J3VU1FeTdqR2l3aGVzMVRjdjZt?=
 =?utf-8?B?TzdyYmJVaEp5QXhvY1VuZlRLZWYrYW8vb0FuOTlXdU9lUzkyQWozZ1h6K25j?=
 =?utf-8?B?aGUyUkhQWWpYZUtycFZYN2FVU3IrWVVQemlWZnNyUEtackt3Q3hyeUdvb3Zu?=
 =?utf-8?B?Y3JtVUJhUTd5dzZXenY0ZG1jbktqd1dhQTBxM3NqaldhV2xZOFF5TVhvZE5F?=
 =?utf-8?B?QlE2RUx4R2dpcitDM2Q2YkdydC9ESlR5aVNrQThlQm5wdWJMY0xZVlY0aEhl?=
 =?utf-8?B?dG0wbDhiM1R5NTdpV1AzRXlWQ0dlbHhxWm9jZk1pVzZkVW81bjRET2YwdWsr?=
 =?utf-8?B?ZlpDY2kza0RWWjY3bHMxRWZqbm85UGZtZjNFcDFMVVJQSFF5c2VMMUZUQSth?=
 =?utf-8?B?anJoaGRGaEtXNWdLVmJWWVRYdFVBZ1dCNTNybVhINlYyQUtleHEzZ2tNaE85?=
 =?utf-8?B?ZVRwNHhFYnZrSVBaeHdDUG1nSDF5RENLZ2ZXQW5SWGNFTjhXNE9UTEduZ2FE?=
 =?utf-8?B?NWdyK00vUVF0bXA5aVhPUzJKWGlwb0tXd2h4aWhqSjRqU2EwczhXMDl3OGs5?=
 =?utf-8?B?U3VnMzB3SmsrTlhUd0tra2l0TXkrcHU1di9PT1lyK1FGT1V2UGJubWVqSG9L?=
 =?utf-8?B?SzhQdE5CbDY2RkhUaEZiS1FzbEdrVFdsTUovWmZXM0trWllrdGYvZUNzTUdW?=
 =?utf-8?B?cXpzV1BKZ0orNTlEaHRnemZVVTYyZytZYnJKd2t0emgwWmJZM25BalFQZVR0?=
 =?utf-8?B?RFFCNlNJVUdjSTVjYUN2ZUtYbXhLNGoyczdKRHlIOG11SWR4U1h2MmJEM3p6?=
 =?utf-8?B?NXNBSGUwbG1RdlN2azY3SFlGQlVCRkVyYjkxWHg0SEdYUjY4dXg3Nm15cVhr?=
 =?utf-8?B?cDFJSnJ1Z1g2UXpWOVZtQmlLNXhRUWpRbEplZzk4ZFNzUmgva0plTSt0V3hL?=
 =?utf-8?B?SE53eUVKdWVyRkUyak56TWl3VElQWUs2SWt3MlpiMlRRcnZ1ZWQ3MjZNanBJ?=
 =?utf-8?B?N2VvNllEN1BXb2dLYzhJTzEyMUxmQ2RuNWdmYU42amtpT0gyUVdidWZWTC9n?=
 =?utf-8?B?OFRHcHpOK3FsZS9pdE5yeWd4c1JrMlJVTDZZV1g2cnl4T3psZjV3dVkxTGtv?=
 =?utf-8?B?SGdLOVZNYThPVEc0Q3VtcHBpNWEzZXZNVmJ2cWFYSng1OFhpNTg2TzU5b3ND?=
 =?utf-8?B?c0x6dG91VE0yT2g4U0QyWHBxOFRZL1UxTmJ5aGhkdHd0NlpudjZFUnJoVmw0?=
 =?utf-8?B?bFpac3BzNitnOUkwSEZnOE1lL0RFQzcrMVNEZ2JPbUR3NTZ5U0NQUHBZbDYw?=
 =?utf-8?B?bUZqUG1GemhYaXJSTk0xWm9GNzl4NUN6MkdubHVFMTNyTXhyQXhqb0l1OEky?=
 =?utf-8?B?Q2xUOGdBcmhKenFEMGxFQXFIcEpZMEZ4bU1ybnd2eitrQVN6U2o4YVFVRysv?=
 =?utf-8?B?TUZwU2s3NnVJMi9RSkdlNkhkdVlwL2JrYjRsQWw0aUNrNkxJTTBPL3V2eEJs?=
 =?utf-8?B?anVqQjJXOGpwYmlrOXBseEN3ekROa3gxWE9leDRhQTlycDBWRUlXc2tVcmJr?=
 =?utf-8?B?YXgvOFYvdVE0K0p1TFZOUVRrZjZnOFA5RWdWOTRvUTZYUTF3VGoyY2krbnBj?=
 =?utf-8?B?UzhJL0lKRUxML1p1RDBzOUZEaWI0NitzeVB2SkF5eVJtSGNjUDh0aG4zaXRE?=
 =?utf-8?B?UWhTcWtISUVTVG5NVUh3aXZTS092VWprUWpWeW5reFJNM2R0YnE3c3JCZ0NW?=
 =?utf-8?B?UTZHRXJEamJMZ0tVNlA4c2txeU1BSjBQR3VWaE1IdE5mYWhPdUtidXArR3Jm?=
 =?utf-8?B?QjMyMzZnQTNTQ3dia1FhKzVnNS9RbUNNMmlDK01Qb0JMRmEwVnhEdHFIZGZT?=
 =?utf-8?B?U0VTWFc3dHJXNUJlN0hZcUxzVHpwOVpFNUdEKzA2VEtYNVNzS2ZKRm56eWxG?=
 =?utf-8?B?NGE0ZWo5QzZSWVJkYWMzWWdHdjFyQkUremt5MnViZDRwazRIZk1BWTJZb0hi?=
 =?utf-8?B?SVNyV0R3RWNCZC9WQjRRd1NIZGZlbzdyRHYxeWtlV25OV3BDVVZmZk50aEhG?=
 =?utf-8?Q?7UjhCJTB7sWZncXm7D5yZ4M=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 14485d88-cca4-45ee-bba6-08d9e6fae9b7
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Feb 2022 09:52:38.8230
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: B7gcSIQOoY0Xbv3eTQM/vijeMMksB9gKYif/VW/cwJg+IAe9L2PAccd0vYiqcMOasATWeOegaxScXBO2MlwOLw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR03MB3238
X-OriginatorOrg: citrix.com

On Thu, Feb 03, 2022 at 10:21:54AM +0100, Jan Beulich wrote:
> On 03.02.2022 10:04, Roger Pau Monné wrote:
> > On Thu, Feb 03, 2022 at 09:31:03AM +0100, Jan Beulich wrote:
> >> On 02.02.2022 17:13, Roger Pau Monné wrote:
> >>> On Tue, Jan 04, 2022 at 10:41:32AM +0100, Jan Beulich wrote:
> >>>> @@ -359,7 +360,10 @@ p2m_pod_set_mem_target(struct domain *d,
> >>>>  
> >>>>      ASSERT( pod_target >= p2m->pod.count );
> >>>>  
> >>>> -    ret = p2m_pod_set_cache_target(p2m, pod_target, 1/*preemptible*/);
> >>>> +    if ( has_arch_pdevs(d) || cache_flush_permitted(d) )
> >>>
> >>> Is it possible to have cache flush allowed without any PCI device
> >>> assigned? AFAICT the iomem/ioport_caps would only get setup when there
> >>> are device passed through?
> >>
> >> One can assign MMIO or ports to a guest the raw way. That's not
> >> secure, but functionally explicitly permitted.
> >>
> >>> TBH I would be fine if we just say that PoD cannot be used in
> >>> conjunction with an IOMMU, and just check for is_iommu_enable(d) here.
> >>>
> >>> I understand it's technically possible for PoD to be used together
> >>> with a domain that will later get a device passed through once PoD is
> >>> no longer in use, but I doubt there's much value in supporting that
> >>> use case, and I fear we might be introducing corner cases that could
> >>> create issues in the future. Overall I think it would be safer to just
> >>> disable PoD in conjunction with an IOMMU.
> >>
> >> I consider it wrong to put in place such a restriction, but I could
> >> perhaps accept you and Andrew thinking this way if this was the only
> >> aspect playing into here. However, this would then want an equivalent
> >> tools side check, and while hunting down where to make the change as
> >> done here, I wasn't able to figure out where that alternative
> >> adjustment would need doing. Hence I would possibly(!) buy into this
> >> only if someone else took care of doing so properly in the tool stack
> >> (including the emission of a sensible error message).
> > 
> > What about the (completely untested) chunk below:
> > 
> > diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_create.c
> > index d7a40d7550..e585ef4c5c 100644
> > --- a/tools/libs/light/libxl_create.c
> > +++ b/tools/libs/light/libxl_create.c
> > @@ -1160,17 +1160,16 @@ int libxl__domain_config_setdefault(libxl__gc *gc,
> >      pod_enabled = (d_config->c_info.type != LIBXL_DOMAIN_TYPE_PV) &&
> >          (d_config->b_info.target_memkb < d_config->b_info.max_memkb);
> >  
> > -    /* We cannot have PoD and PCI device assignment at the same time
> > +    /* We cannot have PoD and an active IOMMU at the same time
> >       * for HVM guest. It was reported that IOMMU cannot work with PoD
> >       * enabled because it needs to populated entire page table for
> > -     * guest. To stay on the safe side, we disable PCI device
> > -     * assignment when PoD is enabled.
> > +     * guest.
> >       */
> >      if (d_config->c_info.type != LIBXL_DOMAIN_TYPE_PV &&
> > -        d_config->num_pcidevs && pod_enabled) {
> > +        d_config->c_info.passthrough != LIBXL_PASSTHROUGH_DISABLED &&
> > +        pod_enabled) {
> >          ret = ERROR_INVAL;
> > -        LOGD(ERROR, domid,
> > -             "PCI device assignment for HVM guest failed due to PoD enabled");
> > +        LOGD(ERROR, domid, "IOMMU cannot be enabled together with PoD");
> >          goto error_out;
> >      }
> 
> Perhaps. Seeing this I actually recall coming across this check during
> my investigation. Not changing it along the lines of what you do was
> then really more because of me not being convinced of the extra
> restriction; I clearly misremembered when writing the earlier reply.
> If we were to do what you suggest, I'd like to ask that the comment be
> changed differently, though: "We cannot ..." then isn't really true
> anymore. We choose not to permit this mode; "cannot" only applies to
> actual device assignment (and of course only as long as there aren't
> restartable IOMMU faults).

I'm fine with an adjusted wording here. This was mostly a placement
suggestion, but I didn't gave much thought to the error message.

> >> Finally this still leaves out the "raw MMIO / ports" case mentioned
> >> above.
> > 
> > But the raw MMIO 'mode' doesn't care much about PoD, because if
> > there's no PCI device assigned there's no IOMMU setup, and thus such
> > raw MMIO regions (could?) belong to a device that's not constrained by
> > the guest p2m anyway?
> 
> Hmm, yes, true.
> 
> >>>> --- a/xen/common/vm_event.c
> >>>> +++ b/xen/common/vm_event.c
> >>>> @@ -639,7 +639,7 @@ int vm_event_domctl(struct domain *d, st
> >>>>  
> >>>>              rc = -EXDEV;
> >>>>              /* Disallow paging in a PoD guest */
> >>>> -            if ( p2m_pod_entry_count(p2m_get_hostp2m(d)) )
> >>>> +            if ( p2m_pod_active(d) )
> >>>
> >>> Isn't it fine to just check for entry_count like you suggest in the
> >>> change to libxl?
> >>
> >> I didn't think it would be, but I'm not entirely sure: If paging was
> >> enabled before a guest actually starts, it wouldn't have any entries
> >> but still be a PoD guest if it has a non-empty cache. The VM event
> >> folks may be able to clarify this either way. But ...
> >>
> >>> This is what p2m_pod_entry_count actually does (rather than entry_count | count).
> >>
> >> ... you really mean "did" here, as I'm removing p2m_pod_entry_count()
> >> in this patch. Of course locking could be added to it instead (or
> >> p2m_pod_get_mem_target() be used in its place), but I'd prefer if we
> >> could go with just the check which precisely matches what the comment
> >> says (IOW otherwise I'd need to additionally know what exactly the
> >> comment is to say).
> > 
> > Could you briefly mention this in the commit message? Ie: VM event
> > code is also adjusted to make sure PoD is not in use and cannot be
> > used during the guest lifetime?
> 
> I've added
> 
> "Nor was the use of that function in line with the immediately preceding
>  comment: A PoD guest isn't just one with a non-zero entry count, but
>  also one with a non-empty cache (e.g. prior to actually launching the
>  guest)."
> 
> to the already existing paragraph about the removal of that function.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Thu Feb 03 10:08:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 03 Feb 2022 10:08:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264586.457722 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFZ27-000233-9Q; Thu, 03 Feb 2022 10:08:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264586.457722; Thu, 03 Feb 2022 10:08:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFZ27-00022w-5q; Thu, 03 Feb 2022 10:08:07 +0000
Received: by outflank-mailman (input) for mailman id 264586;
 Thu, 03 Feb 2022 10:08:06 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=OTfZ=SS=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nFZ26-00022q-Fi
 for xen-devel@lists.xenproject.org; Thu, 03 Feb 2022 10:08:06 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2d267748-84d9-11ec-8eb8-a37418f5ba1a;
 Thu, 03 Feb 2022 11:08:04 +0100 (CET)
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2050.outbound.protection.outlook.com [104.47.1.50]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-4-ueIPvqyhM9CwzGkbIdaU8Q-1; Thu, 03 Feb 2022 11:08:03 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DB6PR0402MB2933.eurprd04.prod.outlook.com (2603:10a6:4:9c::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Thu, 3 Feb
 2022 10:08:00 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.012; Thu, 3 Feb 2022
 10:08:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2d267748-84d9-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1643882884;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=JxVgD5J3f611iLcCd4U9QBkLVFGWKsoTzez8mxiPSHM=;
	b=ZN9lq86EacezUuInwmKi+cf6I7win/jgfkNx3fU3I5ov9VuKiAg2/NJz0teDOKW5cB5j6e
	0cGIAd3ICJ5e4BZkOjm6VZzAaUMfB37tMFIj5bVhV8YX+kyDUURIuNTgqqv+NTzuYvW48L
	WKVFOncYSi5uD5VF+bzREmZQFb5dUWk=
X-MC-Unique: ueIPvqyhM9CwzGkbIdaU8Q-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jCDpysO7XhlnHeqy8VvvVckiltJmWtTE1lZ4T0ETSAlYfGrZRtJCXpf6/k4iI4QddbmSK1ID2jyAMl8EevovoVzPDOnDxmcbOpkPnbQEq83IM1bWPQOQdTR6LIKi998juSXdgy2kVA/NQVk8GgQUvawbIqtCjxWGx1KdAbXxLcXFFuGgEke4XTEwY3Rxxpj3ey4/fxrffMp7nCjX3lpXQZoluCO0+hf9sBdGNqUvhtbip9zLjv+/39aYAT4VnXadreHa9khXc86jv/HDM3KDX4cpqiWcYBcKsqlzYvC1tE8JiO/ay4upq8UZp53HoRbzKaW+ea9+PTVRmebTE3/Xaw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=JxVgD5J3f611iLcCd4U9QBkLVFGWKsoTzez8mxiPSHM=;
 b=E81fpwMpGgEpFU0i28PoQvSb8RPvtS87v5yRHD+u4kC0wpOFMpzJCP7x0lswca2bjV2S0cRrwqRPT7DSpTEm+YasOlMIIfF2/vfoa9UPTvU7zTuSXvE5cg7eSnyV8cuHugJGvE02Xv+bO1q3ZG/CI23rx/Yta1mnRxgUy+YGKfftmI+R19LouYnxVGKO2j3/RsimeNxyrdB3IF6D+JQXpFBFpp8gZ6jluVMcMmfFsHCdxIZAxO1zndN99j7AOq4UgnZhfcsnc54QtZvW1SmgZAsp5yvAjkWgHCLqZ+n0Y2+ZHOHKWEpDhvXWTDZw171zQtwHlAIP7DzFwcTtuhS0KA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <efe591ea-36c9-0ead-727f-600ae3c5ed05@suse.com>
Date: Thu, 3 Feb 2022 11:07:58 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH] docs: document patch rules
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220202114448.8608-1-jgross@suse.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220202114448.8608-1-jgross@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0076.eurprd04.prod.outlook.com
 (2603:10a6:20b:313::21) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b584c427-51a7-4122-8f89-08d9e6fd0f19
X-MS-TrafficTypeDiagnostic: DB6PR0402MB2933:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<DB6PR0402MB29336675ACE25BD36EF37C83B3289@DB6PR0402MB2933.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	oS/ula1cyGDAqMR62cpTM6Q2Goc+WICKR9s8wd8n6AxqpgHLDEJnus5Nj2w8MESXKwgUnGQduJFwC1w8pHJDl1l7r6FykfFwST51tE4c2fS7AEL6o87sO+jeb6pemBLNb+tQm1e9GjRSgwblruegL1GGQtOvN6x2yHwdh5RPCHEKBh83GM2j50PfUVgb8a7YG6QM0P1OFEejKYnEuKubgoiIGGl3QeCnMJR9EYzZpbovK9TQWw12OfDcZPfILZGyHTKTz7h4gn2z/Nxz2ovQHSKIVgz9JaMzanvl4wxfGh6DhvSZUxgFt1xEop/vhKKIzCluLYdz1NPHMQiBLI9iGr3Hx0DwxWiFn7NnwJ/d3ZCjV893FH7b9wBEYeWw7THLXKZoIURwGY3Xp/fjfMYkpXLt1I5pinKAvccQwQZEh0K5yqg9zNxQoiMcPG62cnYyt5wHIknq5ZrNDwkdqmRcMIWQNWXf/Vz18CGk2mnMrqkw9TTEBLXSZO4N5vv8eqYq737WnbpgNJIWsiPjDJXAfZBRQ4hyHLNQxDfzQPT2H2LZOUh6sQF0FmpQv+bzbQZpFE1Nbgy/ss8wFvewf/nHRX2B4qbMrzqAaghxGf9o3WcAUAVrV+L2qkuG6qFtC6gXGccGyjHOj7hmKRWEPKBpByzjlran8+GtnDWab9ctShqy02KUJvZjEhzV3e8EafFqqIKLo3t8TgoVrz0CjM10wxbT+fR08sH9HBvOtxrjl5QjY4Oqp+e204EzKcFJUS4H7g/qTgydj/62mIVq24LqPqzhaKtZ/UHV5G0OqSOmQfA+uJvghwejvcHS3x1mcdps
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66476007)(83380400001)(66946007)(2616005)(66556008)(6512007)(6506007)(186003)(53546011)(38100700002)(86362001)(31696002)(26005)(6862004)(36756003)(8936002)(5660300002)(8676002)(4326008)(6486002)(37006003)(31686004)(508600001)(316002)(6636002)(54906003)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dU93STRWTFZGeTNZZEFHMGI2K3BHTG8vTm1scDI1T3R5SHp4bTJ5eS9QSHNZ?=
 =?utf-8?B?ajFFWFZqRFRCNFhzZWNwWXZpUlZrQTcyeC81STVZZm9GUDZvbU5HU043cm41?=
 =?utf-8?B?VzIrN2ZVdVp0dFg3R3VxQWQ1SmZEaWoyNFo1SVdLeDRORnhQY2l4NUxPQVlQ?=
 =?utf-8?B?Y2dqOHFKNDZYUUdyb1NQbVRuekVZVmtTNng1UFNGOXVFaHpPUDNUdkNpV0Jq?=
 =?utf-8?B?Wit6VzJLeUNvRlo4bHh6NndNY01tRWhORnRzNDBwYVRCVCtGdkpRU0xLaEhz?=
 =?utf-8?B?RUZvcGxJZTB1N2dXZXExR2ZkVDFobHNQbmVQeDJ1N2Fhd0t5cmp1YTdPcVht?=
 =?utf-8?B?ZHhjUmdSczJSZ2FqNHVweDhuakJTdEtPNHhlK0pnNmQ2eG1TdWJTMUY4bHlV?=
 =?utf-8?B?K1d6amppRmRJY0dqbXNuc3F2ZktNV0V2TysrWUNBeHhoZVhuUXJVSmtDdHc0?=
 =?utf-8?B?L3orL0dBMXFUVVNtaXgzbklzZ2NVZUZwMGtFd3pBUk1uS2hkRmQ4Vi9ZaWo5?=
 =?utf-8?B?aFp6M3QvZjBkNHpaR1MyQitnNkhqQ3FEK3VHMmpERjMxV0lDTndDdm9RYW5R?=
 =?utf-8?B?NGhLT1ZXU0VzcFI3Yit4UlZUQnpKTmpxeHkvZmpCUVMyTjN4blc5akQySHNU?=
 =?utf-8?B?Q0dma1d4SFY1QkpLczhkUUFiK28yRlByS0lPZitwbGUyR1NhZ09DaDdQd3FF?=
 =?utf-8?B?eDhpcUw3TUp6YnREVk1GVzJzaVdBTkQ2dFV6aWpkV3BzazBVekNNREdtRStZ?=
 =?utf-8?B?dE9GL0hlUU0yR1ozSkJjdzl4c1FOUmxNbFlqbFNScHoyYXpXN0ZXMWlzNzRl?=
 =?utf-8?B?R0pWWXZFeFUwaVBpdEhLc3NFZnhwVlZCdnBkemhZQVNEdjJseDBTcitXQ0tH?=
 =?utf-8?B?L3VwUmtITVF3UDh1b09MUmZwRm44bGswYitIcjJ1bG93VTllOVpjbXdINThK?=
 =?utf-8?B?U3FXZUw0MTBoZTd2VmhHOElTUGVDb1VRRmFEMWJUeTNVeFRCZ0trU1pTWjVU?=
 =?utf-8?B?czJLblk1L1JhMHNmLzVkTnNNYUZwN2Z2T0RGZkFOS3FzM0JmV3dSbDF6K1ZX?=
 =?utf-8?B?bzloQUFLNDdUZ1hKajBYc0hydUh2ZVFiZExjZHhvamNNc1lFRm1mVHdmKy9T?=
 =?utf-8?B?eVBTTFMyRXlVSGNjaHo2TzZ0SkJZcFovdE1hNDFkbWZkTmpxd0kzeXBlQmlv?=
 =?utf-8?B?aEpqTHNCVkxCcXQwT0dMSWpxazhTZ0xSTWRQQmloVXhDSzNESEFvRXd5R2hZ?=
 =?utf-8?B?blRvY2VMeWpta1FaaWpqeENicmNPTlVNSElCYXFnK0xZVHIwNWRoN0taNWdD?=
 =?utf-8?B?MGwrVytyaEt6VnZINUJwcHRWbWxRV2VJZExtMnE5bUZVa1lla0JLZjdyM3R3?=
 =?utf-8?B?akVQRFp1alpkL0VXVm9IQWdrQ2VsTHFHcUFXMjNKODdnM0xKYjI1WjNnWW54?=
 =?utf-8?B?WFR2L25DWUUzNFRiVE03eC9VZjdiNEF0djFGODYzSFJFYkZlYTY3Ly9ORDRM?=
 =?utf-8?B?V1VIYmVGK1NDVzAzUHpvb3hSVEcxL2tvWCtHUTB4dWx6d3BQVWdCb1BsWDFU?=
 =?utf-8?B?cHFPdHV3NTdtbTVzUi9sOGNjRWF5c2ZOYVRrclNZb3ZZemNlYXI2bEZETGM4?=
 =?utf-8?B?a0RPSUdMZGhWY2QvZ2JaaGNGUUdoVGNMcTVyd0g4L3hvc3h3R1I3TStPTUtX?=
 =?utf-8?B?bkNZQmVXbHlDdDNsOUlmZ2VQR3NzTmlXNTJYekdXZnY4cE5NbUFBWFJ5K2Np?=
 =?utf-8?B?UWJDempaZzlCd2N6bnpHdzhpWldHZEo0bFpBY0U3VG91UHpoYmhKTU5DdnJl?=
 =?utf-8?B?WGpPUFRkNVNWTmFtMWVYQWV1cjJuUndTbG1nT2U5dWNScjJSMXByK2dpMDli?=
 =?utf-8?B?OEdiZndza29jOHhELzlKL2dpQkZTUWdJMHVkNmZVeWlKZDdrY1JGbHA1eW1s?=
 =?utf-8?B?aGRqSS9SR1E1K1k1aWgweW1OU1hTRTYyQndoWTVuRGsweGFpZ2hRMkxQVGho?=
 =?utf-8?B?Z0RVcEt4ZENoYUVZOFpjWWtoU25QQytrQWVRL1FpcWpNamZoaXdIYkIxd1pm?=
 =?utf-8?B?eklReG83T0F0RG5vWXNPNFR6NnJjZTV2YUR1aS81cGlpZDlwQmsyY1AyMXh6?=
 =?utf-8?B?d3ppOVhkSlNTQndaZ0Q2cmtmdTAwd0x3ZzlKV0d6SlpDeXFSOXVibWNTd3Qy?=
 =?utf-8?Q?G1bHRGI1Ya3TAx/baqK7HRM=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b584c427-51a7-4122-8f89-08d9e6fd0f19
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Feb 2022 10:08:00.6427
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Fif41imNLREFcivWyJZl/0yIYgCsVMzdu8JW5goU3lLNDFrcMsIUplhntk5ayVn1BxaEcK+cJ9AXDc4I0ECP7Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0402MB2933

On 02.02.2022 12:44, Juergen Gross wrote:
> --- /dev/null
> +++ b/docs/process/sending-patches.pandoc
> @@ -0,0 +1,284 @@
> +# How a proper patch should look like
> +
> +This is a brief description how a proper patch for the Xen project should
> +look like. Examples and tooling tips are not part of this document, those
> +can be found in the
> +[Xen Wiki](https://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches).
> +
> +## The patch subject
> +
> +The first line at the top of the patch should contain a short description of
> +what the patch does, and hints as to what code it touches. This line is used
> +as the **Subject** line of the mail when sending the patch.
> +
> +The hint which code is touched us usually in form of a relative path inside

Nit: s/ us / is /

> +the Xen git repository, where obvious directories can be omitted or replaced
> +by abbreviations, or it can be a single word describing the topic:
> +
> +    <path>: <description>
> +
> +E.g.:
> +
> +    xen/arm: increase memory banks number define value
> +    tools/libs/evtchn: Deduplicate xenevtchn_fd()
> +    MAINTAINERS: update my email address
> +    build: correct usage comments in Kbuild.include

I realize there's "usually" in the wording, but I'm still uncertain in how
far we want to suggest paths here. I have to admit that I never really
liked overly long prefixes like the "tools/libs/evtchn:" you give as
example. The prefix should be sufficiently unambiguous, yes, but in this
particular case "libs/evtchn:" or "libxenevtchn:" would be enough to
achieve that.

I'd prefer if the tag was described as specifying a (sub-)component (or
other abstract entity, like is the case for your "build:" example).

> +The description should give a rough hint *what* is done in the patch.
> +
> +The subject line should in general not exceed 80 characters. It must be
> +followed by a blank line.
> +
> +## The commit message
> +
> +The commit message is free text describing *why* the patch is done and
> +*how* the goal of the patch is achieved. A good commit message will describe
> +the current situation, the desired goal, and the way this goal is being
> +achieved. Parts of that can be omitted in obvious cases.
> +
> +In case additional changes are done in the patch (like e.g. cleanups), those
> +should be mentioned.
> +
> +When referencing other patches (e.g. `patch xy introduced a bug ...`) those
> +patches should be referenced via their commit id (at least 12 digits) and the
> +patch subject:
> +
> +    Commit 67d01cdb5518 ("x86: infrastructure to allow converting certain
> +    indirect calls to direct ones") introduced a bug ...

I think this should have a reference to the Fixes: tag, as generally it
makes the text less convoluted if it references such a tag rather than
spelling out hash and title a 2nd time.

> +## Tags
> +
> +Tags are entries in the form
> +
> +    Tag: something
> +
> +In general tags are added in chronological order. So a `Reviewed-by:` tag
> +should be added **after** the `Signed-off-by:` tag, as the review happened
> +after the patch was written.
> +
> +Do not split a tag across multiple lines, tags are exempt from the
> +"wrap at 75 columns" rule in order to simplify parsing scripts.
> +
> +### Taken-from:
> +
> +Xen has inherited some source files from other open source projects. In case
> +a patch modifying such an inherited file is taken from that project (maybe in
> +modified form), the `Taken-from:` tag specifies the source of the patch:
> +
> +    Taken-from: <repository-URL> <commit-id>
> +
> +E.g.:
> +
> +    Taken-from: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git f093b08c47b3
> +
> +All tags **above** the `Taken-from:` tag are from the original patch (which
> +should all be kept), while tags **after** `Taken-from:` are related to the
> +normal Xen patch process as described here.

While I don't mind it becoming "Taken-from:", I'd like to put up for
consideration the (slightly shorter) alternative of "Origin:".

> +### Reported-by:
> +
> +This optional tag can be used to give credit to someone reporting an issue.
> +It is in the format:
> +
> +    Reported-by: name <email@domain>
> +
> +E.g.:
> +
> +    Reported-by: Jane Doe <jane.doe@example.org>
> +
> +As the email address will be made public via git, the reporter of an issue
> +should be asked whether he/she is fine with being mentioned in the patch.
> +
> +### Suggested-by:
> +
> +This optional tag can be used to give credit to someone having suggested the
> +solution the patch is implementing. It is in the format:
> +
> +    Suggested-by: name <email@domain>
> +
> +E.g.:
> +
> +    Suggested-by: Jane Doe <jane.doe@example.org>
> +
> +As the email address will be made public via git, the reporter of an issue
> +should be asked whether he/she is fine with being mentioned in the patch.

Besides these two we've also been using Requested-by:, which I think in
some cases conveys information more precisely than Suggested-by: (e.g.
when some result was to be achieved without a solution or path there
having been given).

> +### Reviewed-by:
> +
> +A `Reviewed-by:` tag can only be given by a reviewer of the patch. With
> +responding to a sent patch adding the `Reviewed-by:` tag the reviewer
> +(which can be anybody) confirms to have looked thoroughly at the patch and
> +didn't find any issue (being it technical, legal or formal ones). If the
> +review is covering only some parts of the patch, those parts can optionally
> +be specified (multiple areas can be covered with multiple `Reviewed-by:`
> +tags).

I'd prefer if the comma separated form was also explicitly mentioned
(and hence permitted) here. I'd even go as far as suggesting that this
should be the preferred form as long as line length constraints permit.

> It is in the format:
> +
> +    Reviewed-by: name <email@domain> [# area]
> +
> +E.g.:
> +
> +    Reviewed-by: Jane Doe <jane.doe@example.org>
> +    Reviewed-by: Jane Doe <jane.doe@example.org> # xen/x86
> +
> +In case a patch is being resent an already given `Reviewed-by:` tag can and
> +should be included, if the patch didn't change the portions of the patch
> +covered by the tag,

May I suggest to insert "meaningfully" or some such here?

> or if the reviewer already made clear it would be fine
> +to make specific changes and no *other* changes have been made.
> +
> +### Acked-by:
> +
> +Similar to `Reviewed-by:` the `Acked-by:` tag is given by someone having looked
> +at the patch. The `Acked-by:` tag can only be given by a **maintainer** of the
> +modified code, and it only covers the code the maintainer is responsible for.
> +For this reason there is no optional area possible.

I'd like this to say "normally" or alike. Maintainers may choose to
restrict their ack to less than what they're listed for, requiring
remaining areas to gain another maintainer's ack.

> +## Recipients of the patch
> +
> +A patch should always be sent **to** the xen-devel mailing list <xen-devel@lists.xenproject.org> and all maintainers of all touched code areas should get a

Nit: Split this line?

> +copy of the mail via **Cc**. In case some other recipients are known to be
> +interested in the patch, they can be added via **Cc**, too.

Prior to or alongside "interested" parties, I think we will want to mention
dedicated reviewers.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Feb 03 10:20:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 03 Feb 2022 10:20:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264594.457732 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFZE1-0004LK-Fh; Thu, 03 Feb 2022 10:20:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264594.457732; Thu, 03 Feb 2022 10:20:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFZE1-0004LD-Cj; Thu, 03 Feb 2022 10:20:25 +0000
Received: by outflank-mailman (input) for mailman id 264594;
 Thu, 03 Feb 2022 10:20:24 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=OTfZ=SS=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nFZE0-0004L7-Dh
 for xen-devel@lists.xenproject.org; Thu, 03 Feb 2022 10:20:24 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e5481721-84da-11ec-8f75-fffcc8bd4f1a;
 Thu, 03 Feb 2022 11:20:22 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2055.outbound.protection.outlook.com [104.47.14.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-36-JQsTC6oMPqeJrqtITfAGdA-1; Thu, 03 Feb 2022 11:20:21 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DBBPR04MB6314.eurprd04.prod.outlook.com (2603:10a6:10:c3::20) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Thu, 3 Feb
 2022 10:20:20 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.012; Thu, 3 Feb 2022
 10:20:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e5481721-84da-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1643883622;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=l9YYpd3DEdqXW/HSUagkh2HwS10lejt3JIfsjk9tLEQ=;
	b=ZNsrz4mD8ppsEYX4nNkoZ8ObOGZhiz//RziD7tFA+2iWmRk52GSWZbUCZKapGWWZGVGluS
	9kcBTXJ5U2T5f1+B7hqNAJkkizXOwXz7pg6nwZlMftByh/o2Ve71r5itZWIESw3Dvquk6o
	peJkPJxDrryIyOMJg52vqNXTI+Zzs0I=
X-MC-Unique: JQsTC6oMPqeJrqtITfAGdA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=RrnpmzOx5R27XyX1viaR4NyqVv4O7BbJV9ThH2gPRa0vpSJtIXYS7Gm+nv6Vg/M9Z4yx3J9OXlFMkHTOWvrmDK38ujkOhoQoOfPR6AZVin8fKlTXaORFUoReOnCx7yNInRbOnGCH6uEwl2gJuGoboHqkmHg5MpCmcuwALsNTOAUEaV+PSaWG/yjndbBHUZwsQyMZqB6WfeSk0R7/3ynIiwCsRb+BgN4OQ/XCZ+iIM00/Q/QJ9oGQYW82qWaFdBbhD/nU2vM4TtbSNlTAb+BwyyaKMFqDeASCZ77nlriq4i8Rdi/ZRdmT6WOhToSUhrnoqy+2XC1lAhmy6PLmbLupEw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=KryuYmF3kKXLUrAMriz9WqzzwxBTtYVk+FxcG7V2/Eg=;
 b=RAT2Jr6NLoctkO6KODAMlgNrShH6bs5zj1usKvBvxavVk9GZMU4h/1u1qxuQRCUgDXiv38FOcNF3NGETQOgcP/+lhaQs2uiVCAPGxZ3U/XvPq5e+cpdY2ry0kUvtr5L8JvucZdyDIEj8GgnNFSA3/VVhZEtTFBQ5nnG95+FSpmMy/Yy/yGxv4qfsjc9y8A7IoRT3oY7S3AerYJ6xRvZb7ZKkOTb14NlTnLxfp4Ip+nv+Glreyxoyb//Yt8KdDaKyFarcDSIvxeb/0ldfc7dE9SuQ5nGPH+qg8jLBgMrS1Fx/mdt+qb+DB6PJdAL080B1Z/XQ1JgGtRv1yglNj6o+Nw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <6e835c3a-c22a-dd6b-b6f8-e6c22404b814@suse.com>
Date: Thu, 3 Feb 2022 11:20:15 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v3 1/2] IOMMU/x86: disallow device assignment to PoD
 guests
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 George Dunlap <george.dunlap@citrix.com>, Paul Durrant <paul@xen.org>,
 Tamas K Lengyel <tamas@tklengyel.com>,
 Petre Pircalabu <ppircalabu@bitdefender.com>,
 Alexandru Isaila <aisaila@bitdefender.com>
References: <6fe7b036-2bdb-b391-4e6c-1b5d7e05a119@suse.com>
 <b0a77526-17f2-a5ab-6f7f-1b3caeb4a59b@suse.com>
 <YfqtlZMAKd/HXsgf@Air-de-Roger>
 <2cd051c8-dac0-998c-cced-401c504ad439@suse.com>
 <Yfuahx0ntHJ2BQ6x@Air-de-Roger>
 <7c315902-e618-bba6-054d-86b0aa685370@suse.com>
 <Yful4oPqwzw3lsjp@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Yful4oPqwzw3lsjp@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM7PR03CA0030.eurprd03.prod.outlook.com
 (2603:10a6:20b:130::40) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 37f7aa05-61b8-4b5e-c034-08d9e6fec79d
X-MS-TrafficTypeDiagnostic: DBBPR04MB6314:EE_
X-Microsoft-Antispam-PRVS:
	<DBBPR04MB6314CE39556EE29F4CBC6DC8B3289@DBBPR04MB6314.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	4mQj80ThclEku/OxRbg7f3wuRoOnztca7/zEU4Z351wBS4LBaWULJy9yz8Qa/0Ip3gi0fQjxKK4CCbPzMkAkrXOTi9wbGbWLbZkPSd2qTaEGLKfOIxRwfKV/Ov91JWnQw7ZasLberTtOxeWzB8qATOAaO50Xhti+fJPrIf7zQvfpbBOXQv/zw0XfoEdOnmOj3EtyTAHpcrSrumxUT3YXIzd8tOwuFraxIsMLg3YDgojcOrcIqTQ3BGIABiVRcxKTjkGydBzspFnL66PWJZr7XBCgS6CC8pqzm4QkAsJ6fplKkHrNLPYE+UC1GRfN6ChgH0MPXKpfHsrFCTJkYbvOUWD0VvksNLwSbz7QjOi9d2Z3z7eLfEpGS7LC2BJ4GIVvY0ocXTA6vLMhYNFJjTJwQCTnemz0JTeEX4M9dXgMKyhIOksj7tlOXZQwgX8snVbOyXm0Iwi0D1vJtPFD/k8/0y7NEt363RwjRpWLntm+BJVX1nL04InrmodKdbtpjukQaw6UGEu7vjS7NUC3+XPrzfJ5pCXXn26LADEJBNffwe+2KoEWDx/EkMroD58mvZd2hw6Mu7xcpL1XwosFliJTwsMSmEVoAz1QWUaix0YYLUQp8ClRQKQSwO+JfAkiRNZl8MvxGKbe/RGjjruslz83bp3v/XvAwCCLBTzzdcMPy25Cj/pz1adP/QxWdafcFP9s+reQscwAkVVALcccV8emsYT3uBEzrl41xx61ObFTeUYMNc9qxM1MMG/onwBNeR4OTSXZL9lzx6VqsGLFeRNiGE4gwFmdSn0EHFvqXjIltGU=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66946007)(316002)(2906002)(6666004)(8676002)(6916009)(8936002)(66556008)(86362001)(53546011)(4326008)(66476007)(2616005)(26005)(186003)(6506007)(6512007)(31696002)(36756003)(508600001)(6486002)(54906003)(38100700002)(83380400001)(31686004)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?3bkbmLZwxNhJXToBeJRUfcAn0DOoqItRjC+GtgGpMuD69Tf+ohavi8UtypDW?=
 =?us-ascii?Q?O5Qsu4dfHUnHIpBedxiA9Rp25OxBkAP8AW8G2hV7sSEsqQWEKmqd3RLdN2hR?=
 =?us-ascii?Q?rr2mtWyG3snA++oNOyn1ti+esvvBeXdNvNpurRx6NU9nUONfrKYVDheAxfT6?=
 =?us-ascii?Q?4W59eBJ7iJQ2hHl6HMDrK1XATYZ8dvvpUWJVmeylD23xQyIbA0SIzTpCU0Om?=
 =?us-ascii?Q?gINMMREmbfXugObGGeaImXyve43zEaFqkSBsY5jtYScvm7OXNNJTFqY1vUyy?=
 =?us-ascii?Q?p4SaHmJGBJek48jfYWgyg1neyaZ3voPz8CjLmceeHWRJ6bwob6DBff8hrdEW?=
 =?us-ascii?Q?jKTkqbUQRIlWSTsGVlTYEzdvj4bdYl9vkkhuPCRRNQkOOyFlr4t2mU0q0COQ?=
 =?us-ascii?Q?qWMNysrwWyK1++bmVyWpM74/RF57VmCwHBxlz+z1t5xIses6XzcraDC1itn5?=
 =?us-ascii?Q?rWo+si0Qw/aFCmZrIEYEYf+znQSasA0CVc4LzvJhxUGZ2yLiWsvZpTsJIWfi?=
 =?us-ascii?Q?7i/SaOd/l7kz7yqeR3lvptoylJnYGiP9W4ikVlDrn2DzU6MwPhaWDFAdOHAh?=
 =?us-ascii?Q?SL0r+JomsKdEFEFh7kOw7xIMXL2hUELMP08QpcR2jCW/3QirCmaOzImz21Ai?=
 =?us-ascii?Q?dZGoH+X3AnImpZn+fO7TrcCL1S/TQzB7r+mU+UnYWDIRERb/kDCZLiJohYEa?=
 =?us-ascii?Q?5DCmGkgsIH9R2woaPx9qNHkcw6TUAJeH27FaAhmwWOZJeEPOT6+9b1iWjX/3?=
 =?us-ascii?Q?KNx90nJHe4MGXWil4kLOGJvZHfvnfA+NemBu8KpSD9CQNOP1rCxoe/HxpUnV?=
 =?us-ascii?Q?/vJrLZb+jLUgptEUGPlp0pTx9tTOGFrxOGC6SGiJH0joRD0pb14YKdfqWP1i?=
 =?us-ascii?Q?2YTKyKdnm104Osk2Ohli5qeKC/DR1ZCM18fNap1zPpAKo7HCervntrM6NEQH?=
 =?us-ascii?Q?t5aRFKRFxJ4fuGBg/9ZIDTWcjrriGvtROHrV1E0qh9GyHj3waClAmfZ0hxLv?=
 =?us-ascii?Q?L5c0AXwsJw1MhShtBBa3zCa2TyxwR05iBtfTtb2Nbmg6Sy/SK4l1wzTfTbNu?=
 =?us-ascii?Q?KPptR/aDhD0Nh0gSeqmci5d6j6PunkkrQMAdZNDaSsXTfx0aeyokl9ue+5yK?=
 =?us-ascii?Q?RPM89im9rt1oz6pxNdo6sb9gUaLH5rlI5wIkbs+BGDRhDbQVrRGbt/KlRl/W?=
 =?us-ascii?Q?TGf8zakGwINurchCsb3iLo/NVtqX7hfiaBDOYYutJhxdCX0UlEtguBZQ7dRR?=
 =?us-ascii?Q?EWoiGRl3/UVOwk0sLn7gaXBAgq18dHQHv214Dxb5E5/mL07X68vetfh7LeTG?=
 =?us-ascii?Q?iOWUj6DgDsoGqzs6WLw5blDB27hpLIsIDmvwHcusnPUO6LF3/gd/UBns1xz3?=
 =?us-ascii?Q?8Lgn54nbVBAKYPwZ2pb0IDYXlJ02tAbTmfdSguco6fZQsqUxM7sJu7B6FwJT?=
 =?us-ascii?Q?89ZXKzEHZJhonn+CHKfsHelTOVRpVS2Iu1UM7MjhLNj+4H1nDbnfptA/uURN?=
 =?us-ascii?Q?/aFWt9J/yim3asm53aAhQkfls9aBz314VbKAJd+JJVb7DavrBOPX0LFnKhr4?=
 =?us-ascii?Q?3MdOMtUKAgBEAQ9z0n9lfUe22+Wn6/r/XOoomRculPKdzhjBYM+j1u3dlrQ5?=
 =?us-ascii?Q?76VplVwwe1YhNKYc6CaBaPM=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 37f7aa05-61b8-4b5e-c034-08d9e6fec79d
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Feb 2022 10:20:19.6128
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: c2sPpWFGHI+LV25v1z61udcDkL3nXHbUTHPg2YO3EFXCgCkYAd0IWeymHz8f3YaGD0zKVNeHjGuV7QpiH6x0LA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB6314

On 03.02.2022 10:52, Roger Pau Monn=C3=A9 wrote:
> On Thu, Feb 03, 2022 at 10:21:54AM +0100, Jan Beulich wrote:
>> On 03.02.2022 10:04, Roger Pau Monn=C3=A9 wrote:
>>> On Thu, Feb 03, 2022 at 09:31:03AM +0100, Jan Beulich wrote:
>>>> On 02.02.2022 17:13, Roger Pau Monn=C3=A9 wrote:
>>>>> On Tue, Jan 04, 2022 at 10:41:32AM +0100, Jan Beulich wrote:
>>>>>> @@ -359,7 +360,10 @@ p2m_pod_set_mem_target(struct domain *d,
>>>>>> =20
>>>>>>      ASSERT( pod_target >=3D p2m->pod.count );
>>>>>> =20
>>>>>> -    ret =3D p2m_pod_set_cache_target(p2m, pod_target, 1/*preemptibl=
e*/);
>>>>>> +    if ( has_arch_pdevs(d) || cache_flush_permitted(d) )
>>>>>
>>>>> Is it possible to have cache flush allowed without any PCI device
>>>>> assigned? AFAICT the iomem/ioport_caps would only get setup when ther=
e
>>>>> are device passed through?
>>>>
>>>> One can assign MMIO or ports to a guest the raw way. That's not
>>>> secure, but functionally explicitly permitted.
>>>>
>>>>> TBH I would be fine if we just say that PoD cannot be used in
>>>>> conjunction with an IOMMU, and just check for is_iommu_enable(d) here=
.
>>>>>
>>>>> I understand it's technically possible for PoD to be used together
>>>>> with a domain that will later get a device passed through once PoD is
>>>>> no longer in use, but I doubt there's much value in supporting that
>>>>> use case, and I fear we might be introducing corner cases that could
>>>>> create issues in the future. Overall I think it would be safer to jus=
t
>>>>> disable PoD in conjunction with an IOMMU.
>>>>
>>>> I consider it wrong to put in place such a restriction, but I could
>>>> perhaps accept you and Andrew thinking this way if this was the only
>>>> aspect playing into here. However, this would then want an equivalent
>>>> tools side check, and while hunting down where to make the change as
>>>> done here, I wasn't able to figure out where that alternative
>>>> adjustment would need doing. Hence I would possibly(!) buy into this
>>>> only if someone else took care of doing so properly in the tool stack
>>>> (including the emission of a sensible error message).
>>>
>>> What about the (completely untested) chunk below:
>>>
>>> diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_c=
reate.c
>>> index d7a40d7550..e585ef4c5c 100644
>>> --- a/tools/libs/light/libxl_create.c
>>> +++ b/tools/libs/light/libxl_create.c
>>> @@ -1160,17 +1160,16 @@ int libxl__domain_config_setdefault(libxl__gc *=
gc,
>>>      pod_enabled =3D (d_config->c_info.type !=3D LIBXL_DOMAIN_TYPE_PV) =
&&
>>>          (d_config->b_info.target_memkb < d_config->b_info.max_memkb);
>>> =20
>>> -    /* We cannot have PoD and PCI device assignment at the same time
>>> +    /* We cannot have PoD and an active IOMMU at the same time
>>>       * for HVM guest. It was reported that IOMMU cannot work with PoD
>>>       * enabled because it needs to populated entire page table for
>>> -     * guest. To stay on the safe side, we disable PCI device
>>> -     * assignment when PoD is enabled.
>>> +     * guest.
>>>       */
>>>      if (d_config->c_info.type !=3D LIBXL_DOMAIN_TYPE_PV &&
>>> -        d_config->num_pcidevs && pod_enabled) {
>>> +        d_config->c_info.passthrough !=3D LIBXL_PASSTHROUGH_DISABLED &=
&
>>> +        pod_enabled) {
>>>          ret =3D ERROR_INVAL;
>>> -        LOGD(ERROR, domid,
>>> -             "PCI device assignment for HVM guest failed due to PoD en=
abled");
>>> +        LOGD(ERROR, domid, "IOMMU cannot be enabled together with PoD"=
);
>>>          goto error_out;
>>>      }
>>
>> Perhaps. Seeing this I actually recall coming across this check during
>> my investigation. Not changing it along the lines of what you do was
>> then really more because of me not being convinced of the extra
>> restriction; I clearly misremembered when writing the earlier reply.
>> If we were to do what you suggest, I'd like to ask that the comment be
>> changed differently, though: "We cannot ..." then isn't really true
>> anymore. We choose not to permit this mode; "cannot" only applies to
>> actual device assignment (and of course only as long as there aren't
>> restartable IOMMU faults).
>=20
> I'm fine with an adjusted wording here. This was mostly a placement
> suggestion, but I didn't gave much thought to the error message.

FTAOD: Are you going to transform this into a proper patch then? While
I wouldn't object to such a behavioral change, I also wouldn't want to
put my name under it. But if it went in, I think I might be able to
then drop the libxl adjustment from my patch.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Feb 03 10:24:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 03 Feb 2022 10:24:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264601.457744 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFZHh-0004yJ-0L; Thu, 03 Feb 2022 10:24:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264601.457744; Thu, 03 Feb 2022 10:24:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFZHg-0004yC-TZ; Thu, 03 Feb 2022 10:24:12 +0000
Received: by outflank-mailman (input) for mailman id 264601;
 Thu, 03 Feb 2022 10:24:11 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mjBt=SS=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nFZHf-0004y6-GJ
 for xen-devel@lists.xenproject.org; Thu, 03 Feb 2022 10:24:11 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6bcff17d-84db-11ec-8eb8-a37418f5ba1a;
 Thu, 03 Feb 2022 11:24:09 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6bcff17d-84db-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1643883849;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=QmALk/GizQHxgvnu2jsjRSos8WZI1VkYqyAk9VbelnY=;
  b=eEy5yPvpl9J5qnz+XIVx22XEYnZm+qIdbi4kjtam7UQj8fXpMAuvPotX
   J3RXGMaJt9UI5qLQLLsTGx6grjsnGRf66Fcv29HLmsNc5RFmPL0uuBoje
   A3UwbXT8phZkTR2wGncNbrIb2AfJk+opdsUMxA6jdIvf1BpcH4zTEUKcj
   s=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: SySO0xn3Xnu8hcIaDr2Ic8XOnXMOVIbAWQ3qAzx1am13FuFKgPZfc+ixvrZ57C1oLQ8eCIp5+b
 Synfk3zGBagOVyZezOhfpvURHluLoVX9FkeQds23AlfT63H6nstmFioILQGg9sbmFl0MSoMHmz
 ef5/h+HXhTbdHehbfdFApXpnCJosbL8AxP82flvQOuo5F0mmT6f/wTEVJ9eRhL6olVs6El1JYa
 A4Fy53rmXUFzKxUBTWmVM81w7RMDfRuPjeLyPYxGC7GqjwJlckGGsDBV+5e6gNRYLjwY1yiB4H
 ty/jYFBvQ7eTeYWmvV6UuO5G
X-SBRS: 5.2
X-MesageID: 62860555
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:/t4S2q2Q/VlUaZMhFvbD5W12kn2cJEfYwER7XKvMYLTBsI5bp2dTn
 TAfXTrVPqmJNGHzLd1wbo21oBsDvZbdyNFmGlFppC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkS5PE3oHJ9RGQ74nRLlbHILOCanAZqTNMEn9700o5w7Vh2+aEvPDia++zk
 YKqyyHgEAfNNw5cagr4PIra9XuDFNyr0N8plgRWicJj5TcypFFMZH4rHomjLmOQf2VhNrXSq
 9Avbl2O1jixEx8FUrtJm1tgG6EAaua60QOm0hK6V0U+6/TrS+NbPqsTbZIhhUlrZzqhpIB97
 NFRrZ6JdF1zH63FwcoSYjZROnQrVUFG0OevzXmXtMWSywvNcmf2wuUoB0YzVWEa0r8pWycUr
 6VecW1TKEDY7w616OvTpu1EnMMsIdOtJIoCknph0SvYHbAtRpWrr6Diu4UIgm9t250m8fD2P
 5A7TANLdR35QTZQZlkFU5FixOyKiSyqG9FfgA3M/vdmi4TJ9yRt2b3kK/LJediHQ8pEk0Ler
 WXDl0zhGhAAP9WbwDCY2nitmuPCky79VI8IUra/85ZCiVyIz20XATUcVEe3rPe0jEKzQZRUL
 El80jInsKwa5EGtCN7nUHWQonSJoxodUNp4CPAh5UeGza+8yxaUAC0IQyBMbPQitdQqXno62
 1mRhdTrCDdz9rqPRhq16bO8vT60fy8PIgc/iTQsFFVfpYO5+cdq00yJHo0L/LOJYsPdImH85
 zSWtCoHuu9JrM4Cjou0zH/Oqmf5znTWdTId6gLSV2Ojywp2Yo+5eoClgWTmAeZ8wJWxFQfY4
 iVd8ySKxKVXVMzWynTRKAkYNOzxv5643CvgbUmD9nXL3xCk4DadcI9Z+1mSz285Y59fKVcFj
 KI+0D69BaO/3lP3NcebgKrrUqzGKJQM8/y/DZg4ifIVOvBMmPevpn0GWKJp9zmFfLIQua8+I
 4yHVs2nEGwXD69qpBLvGbtGgeR2mH1vnjyILXwe8/hB+eDFDJJyYexdWGZik8hjtP/UyOkr2
 4o32zS2J+V3D7SlP3i/HX87JlEWN3krba0aWOQMHtNv1jFOQTl7Y9eImOtJU9U8w8x9y7mUl
 lngBB4w4Aev1BXvdFTRAlg+OeyHYHqKhS9hVcDaFQz2iyFLjEfGxPp3SqbbipF8pbE6kK4pE
 6JYEyhCa9wWIgn6F/0mRcCVhKRpdQixhBLIOCygYTMleIVnSRCP8djhFjYDPgFXZsZuncdh8
 bCmyC3BRp8PG1ZrAMrMMar9xFKtp3kN3ul1WhKQcNVUfUzt9qlsKjDw0aBrc51dd02by2vIz
 RuSDDcZufLJ/90//u7WiP3WtIyuCeZ/QBZXRjGJ8basOCDG1WO/2oscAv2QdDXQWTqsqqWvb
 OlY1d/mN/gDkAoYuoZwCe8zn6k/+8Hut/lRyQE9RCfHaFGiC7VBJHia3JYQ6v0Rl+EB4QbvA
 xCB4NhXP7mNKfjJKl9JKVp3dPmH2NEVhiLWsaY/LnLl6XIl57GAS0hTYUWB0XQPMLtvPYo56
 u49o8pKuRengx8nP9va3CBZ82OAci4JX6k978xIBYbqjkwgy01YYIyaASjzucndZ9JJO0gsA
 zmVmKud2OgMmhucKyI+RSrXwO5QpZUSoxQbnlYNKmOAlsfBmvJqjgZa9i46T1gNwxhKuw6p1
 rOH66GhyX2ywgpV
IronPort-HdrOrdr: A9a23:UgCF5KEiF8xQVFqQpLqFcpHXdLJyesId70hD6qkvc3Jom52j+P
 xGws526faVslYssHFJo6HnBEClewKgyXcT2/hsAV7CZnidhILMFuBfBOTZsljd8kHFh4pgPO
 JbAtdD4b7LfChHZKTBkXGF+r8bqbHtms3Y5pa9854ud3AQV0gJ1XYJNu/xKDwOeOApP+tfKH
 LKjfA32QZINE5nJPiTNz0gZazuttfLnJXpbVovAAMm0hCHiXeN5KThGxaV8x8CW3cXqI1SvV
 Ttokjc3OGOovu7whjT2yv66IlXosLozp9mCNaXgsYYBz3wgkKDZZhnWZeFoDcpydvfpWoCoZ
 3pmVMNLs5z43TeciWcpgbs4RDp1HIU53rr2Taj8DLeiP28YAh/J9tKhIpffBecwVEnpstA3K
 VC2H/cn4ZLDDvb9R6NpuTgZlVPrA6ZsHAimekcgzh0So0FcoJcqoQZ4Qd8DIoAJiTn84oqed
 MeQv003MwmMm9yUkqp/FWGmLeXLzEO91a9Mwc/U/WuonhrdCsT9Tpd+CQd9k1wgq7VBaM0oN
 gsCZ4Y5o2mePVmGp6VNN1xMvdfNVa9NC4kEFjiaWgPR5t3cE4klfbMkcEIDaeRCdo18Kc=
X-IronPort-AV: E=Sophos;i="5.88,339,1635220800"; 
   d="scan'208";a="62860555"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=TYAQa/VHkR9SbhHtXOJqPP3Q+IbaVs/R+/Bp/N0XAa5RnNAIG69mBn3q7828zDlFbdyEOnMzlSWidL+jMTPV4y9i4mt5dHpPUc1ZPlQeYctp/9SFj1Oc0aMJ1Mg+b+JV7obPrYb7A02g1tWtoj1oryBz/j/o+XiegutZZf3GbY127ELPcQ2Gt6JMkSQrAFNufuuohMOhofYvn7FnjM1u4j08BmlQTgYmXXqOPMK5QBK8rVrk2e6X51BebKvD31QFMPFpfXWTk+/Jqd60v+cSs6OBkU0cUVkySYFCk/vehbfnyrD0LsHbuUbB9vjkEoTSTAnfdQ52WHHNmKjldlk13w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=MzP9lXHShiSL2H6N8/+SSVhd7ck4bHF0hXzEA+fyXck=;
 b=AlTlKWcf9k5LpX+Ge56N6FPWDgk71+cwysLhOVbG8Hanl3jwzRCBLu1ZmQhD7svq+DWMvfmZpeChBfs/88ekMX65bzD70VPx6os2TsphU7zO1OTOUGn5PilaZEN96oBnZLrk04LcuBffPqkOlOUGhh33zI4KpRewGoTmZWC4/mCrxJijfXVkugis1njZvZ3f1TLgw741LWjSdsoDAYcptES3lejLfkpjAWHoU95JXZtNFkRv7TzYbZra7m1lrUj61nGavzuKVKXX3QjEOGIjjjMB5Misgs/AoCmEAKjqlR9gFHWV9QVszDSrwKyWl6CfqaPF8vOFuQIAkzCHRlcYtQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=MzP9lXHShiSL2H6N8/+SSVhd7ck4bHF0hXzEA+fyXck=;
 b=VVDuhnTcrPCZASokCZseKVqfURT4Q5nxPp8fROx37BhLx3OwfcW/6ICJR37p3CgCNLzzmu4BCZPMge8iH23QsrUcb7m7Jr2/zyGttOeEdaV+2cg4Z7WVYg97m/HhQKs5e+A4/mL1kmuZoKRM1jl66iBcsfmGdHkJyb/2hSagjfQ=
Date: Thu, 3 Feb 2022 11:23:51 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Andrew
 Cooper" <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>, George Dunlap
	<george.dunlap@citrix.com>, Paul Durrant <paul@xen.org>, Tamas K Lengyel
	<tamas@tklengyel.com>, Petre Pircalabu <ppircalabu@bitdefender.com>,
	Alexandru Isaila <aisaila@bitdefender.com>
Subject: Re: [PATCH v3 1/2] IOMMU/x86: disallow device assignment to PoD
 guests
Message-ID: <YfutNyLR6CtMHkiv@Air-de-Roger>
References: <6fe7b036-2bdb-b391-4e6c-1b5d7e05a119@suse.com>
 <b0a77526-17f2-a5ab-6f7f-1b3caeb4a59b@suse.com>
 <YfqtlZMAKd/HXsgf@Air-de-Roger>
 <2cd051c8-dac0-998c-cced-401c504ad439@suse.com>
 <Yfuahx0ntHJ2BQ6x@Air-de-Roger>
 <7c315902-e618-bba6-054d-86b0aa685370@suse.com>
 <Yful4oPqwzw3lsjp@Air-de-Roger>
 <6e835c3a-c22a-dd6b-b6f8-e6c22404b814@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <6e835c3a-c22a-dd6b-b6f8-e6c22404b814@suse.com>
X-ClientProxiedBy: LO3P265CA0014.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:bb::19) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 18daacc3-8ca7-4bb8-a376-08d9e6ff498f
X-MS-TrafficTypeDiagnostic: SN6PR03MB4047:EE_
X-Microsoft-Antispam-PRVS: <SN6PR03MB404790FD9BE2674A34F77B068F289@SN6PR03MB4047.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: jX/z2soiybTrGCGKZ2KGc8MByYQmUZg93IeCGFb8UsUHJoay6w/DV245EB91Ic7mdtsAFxK4p+J3ESlehrKc8gUtL0+z8/bbynfTZJ4QUR5xINDPKPXUVJAxHWkUzPGOgH/CDF6Ay9bgvdKRHhSYxmnQ2zMqoWn7E1Su959ooRjUY6zbIsBchg+J1sh/d5c0ZZfqndZ22HAMGof9/mx1E9sjkQehLd2S9Xeh95fID6eD+ksd5cEVzX3PcKexzmFEqxH/JLKZNut0wAXoN5//Xgbq4XBqzORJ+Bp9oiVeBBWW9GfK2v46SKW5pXufQJtToRRAWbtuNSJFwp0I7NCtGI9tyxKXgm+vTFtpLjiMemfZAeyg3r/oOHKYLBJ4M2G1l4CLArfl6LznyBSV88coj9Y14M6BYoBHcMQGinNCDenU2na0HRhTAzHTX32oEu73MCHhFlfUebhvreRdy0DuchNfyD5Cmhq5Vh35Ogvdfcc+G2Pb+rYoHHd1WIur/lUSgNSDLCt1IHhDEhw0sNY4AYxq0RoWfrlO45ouht6kpZhUcnO0A/ppigEtaLeOQTgCKVcO2gEW0swxsNiSXuCwIssKghZ73n360tS/5Y+knmtVOil0gPHdJp+AgBP7H0pVJcYSFm2wd8Ng3q7XWByB3w==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(66946007)(38100700002)(53546011)(6506007)(86362001)(6916009)(5660300002)(316002)(508600001)(66556008)(6666004)(8936002)(54906003)(85182001)(6486002)(4326008)(66476007)(8676002)(9686003)(6512007)(2906002)(33716001)(186003)(26005)(83380400001)(82960400001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cnNrQVNQSFhPZDY5RDBtZlZ6OTRXL0RsTmdXSGZ3V3VWVHN2RVp5U0dncGpD?=
 =?utf-8?B?ZDZhYm5Eay9IMXhFSFFFSEVUZkdPSlRDeHlPOWNnOTFjU2ZLR3J2Zi9XR0ZQ?=
 =?utf-8?B?dWl1YmZmT1ZWRktIQndHMy9TTEV6MlAvSUV2V3VaaStPZUp1RE9JaG9VMWFZ?=
 =?utf-8?B?dWxrdUwyK2lwOVFISStBVEVydTdWWkZ1cHpCQ3JCU3NhUFl1aUFma3ZSbkpz?=
 =?utf-8?B?THZIbzk5b1JoRWtER2FpN0RCS2dWSWNFRGdhSlZ5NlBMcG8vMGtCc3RDd295?=
 =?utf-8?B?WFkxN3NqNHZiMzd2KzFhVzhUNCtjdm1kMHU0VHl4SDZqTW9FSWR2eGRxdkxh?=
 =?utf-8?B?bXBqMmxCSnJUcGhROElRUm1OYXVMall0eUJtSjljdTJ4bmgxZ3RBeHpaU3M1?=
 =?utf-8?B?NHBtM0s5elpGbUFCd1k2TTFlSytnck5rVjd1ZlJPZ053NUZMYlhIWmxnUXYy?=
 =?utf-8?B?bmNobzVYaTVia3V6RTczVm5uanA3WmpjcVJXRnlIV0c4ZnlhaVR2N3lVVjZm?=
 =?utf-8?B?dGVzSkI4cjRGb245WlUwTHBROWRXUkQrZUFJeFgvNGo1NS9KRi9va21HUkts?=
 =?utf-8?B?Mm92N21GWmlQTzloRktqZ0hYdFMyMk9oVWRxdjE0eGNiMllyR3RsSkhjNnUw?=
 =?utf-8?B?aThaM1FyWkZXNlVjeW8yN0h2WVJvdHhEa1pkT0Z4TnpzbmRncGlpNjFtaUJm?=
 =?utf-8?B?N09qdFFkWUhTZmt0M1UxbmNsaDVUZUlHQmk0NkN1N3VhQzZKWTYxQmpES2lT?=
 =?utf-8?B?Y2hKYmVYN2oyRit3NDdXTmJtYlVoRTZCYklmS25HZlVaRWRQYlVKUmRxc2FV?=
 =?utf-8?B?NTdlWDQzTTYranVyVjR3Yk5NMUQxNldoaEJyRi9neno4Z3R1QkJOdDg1Q1Za?=
 =?utf-8?B?YjczWTJEVUc5dVpXdlJ2Z2ZvZ0toSkEyZTI1U05xVGpWdi9LUGptYWF6aXFF?=
 =?utf-8?B?KzVXSm1NWGtaS2dnRWVGNFFZelZoMjlWTGk1aGFiR0NHRkFKei9zWFRlYVJN?=
 =?utf-8?B?UVhFUVJ3WUZIU252c1haTTFaQVQ2VEkwNjhLeWtrNmt1Y1pGRHU3V0RvQ0RZ?=
 =?utf-8?B?bURST1dBWmEwSHVVSit3QXVvdCtDb2FiTEFPa2gwb0Q4YkdORGZTQk9CUHRS?=
 =?utf-8?B?NnpCeTMrR2l1Q3grajh4aDVwakFLUGwrUWxJZEEwRWE5RjJxU0RYK1ZWbXRW?=
 =?utf-8?B?OU9oeWZkQnJPa2dYUEF2bVhTZHYrUU5CUnhXK0VlM3h4dUd5M0pHYU4zZ3Zh?=
 =?utf-8?B?bjBMTWFNN2djRW5sRkhVZUZLQzFKcXl4U25ybGVHKzh1YW8vTEZwTzMvU29O?=
 =?utf-8?B?eGlBR3VsRzhLT2VURWhUNEw1U0Y5WGtFNlp6S3F4SnIyak05VjBvVVVDNSsx?=
 =?utf-8?B?K09ka1U4WkFDTTkvY1FtMG1YSjVUZ3h0WU5vWHlDM0xpdFNUL28yS1RzVFYx?=
 =?utf-8?B?L2s5V1dpazk2SSsyMFZQQ0dMZmFpN2YwcGRjc0ZsWXkvdVpWenZHc3U2aVZo?=
 =?utf-8?B?Wjh3cnFJTmRlZ2s1VUxaeDR6VDJMZG1aclJ5T1ZnL3NVUW4zVFl0VTM4Q3FZ?=
 =?utf-8?B?bm9TRXlRN3JtcEpkb05XVnhCbkFPZDJ0RE0zT0xibnVrSHJSV3Y2NEpjTnFJ?=
 =?utf-8?B?OUY0enVoQlNnMlhJUDdWbUxjQnhoNUIwUjliNTc0dHc2WGp1UXVOaVhMVXFE?=
 =?utf-8?B?dEJRSkwxV0NzRW5mK2FrdU9CaGxaL0xXclZ4eUI2SlprMTNNV0h4WmN6bUV2?=
 =?utf-8?B?eFR6MmttNXU3K3h0RWdmV0g1RXk4NHB2UFozandYanNCQTd1TWhzbStqR29J?=
 =?utf-8?B?NXg3Y0FsOXJHakFZaDJEU2JML1Q2THNVMUJZYUJTS2xHNnlUNUt3S1AwZmRq?=
 =?utf-8?B?c1E4ZDgxQWNLTGIwL1FWT2Q2UkM1TkxTRnFxNWhxMDhIT3JjNkFXWmV1SGxq?=
 =?utf-8?B?c1lUTVE2ZXA1STdnd21NMWRuT3VMcWxUeDVjTjNtcmNzakp4cHBoMzY0bjlx?=
 =?utf-8?B?WFhvdjdTUW40M3RwU1piYjJUeVZaUHhERi8yaExuVnJUR0VpeXNYMUVDMnRS?=
 =?utf-8?B?VUJ2MWtoU3d2OHdpTmRCTXFDQ0RXN3ZTeXpTRDNmSEZ2U094S3JqR2lRK3Ir?=
 =?utf-8?B?enJDbE5uM05jeGNGci8wY0xydWdyL1ZTTmp3dURORjRhMWhVYkFQNXZhYmlG?=
 =?utf-8?Q?qtE9/iKjRzdvdugPk66sSMc=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 18daacc3-8ca7-4bb8-a376-08d9e6ff498f
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Feb 2022 10:23:57.7022
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: H9+FBTS6j+wjF1mNC43UBj9gfCB0RoF0u5gVzc0QRyE4n/fWv9bhN7T9ya1eH4oE95ALlnlA3Jfeo++k/McE6A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR03MB4047
X-OriginatorOrg: citrix.com

On Thu, Feb 03, 2022 at 11:20:15AM +0100, Jan Beulich wrote:
> On 03.02.2022 10:52, Roger Pau Monné wrote:
> > On Thu, Feb 03, 2022 at 10:21:54AM +0100, Jan Beulich wrote:
> >> On 03.02.2022 10:04, Roger Pau Monné wrote:
> >>> On Thu, Feb 03, 2022 at 09:31:03AM +0100, Jan Beulich wrote:
> >>>> On 02.02.2022 17:13, Roger Pau Monné wrote:
> >>>>> On Tue, Jan 04, 2022 at 10:41:32AM +0100, Jan Beulich wrote:
> >>>>>> @@ -359,7 +360,10 @@ p2m_pod_set_mem_target(struct domain *d,
> >>>>>>  
> >>>>>>      ASSERT( pod_target >= p2m->pod.count );
> >>>>>>  
> >>>>>> -    ret = p2m_pod_set_cache_target(p2m, pod_target, 1/*preemptible*/);
> >>>>>> +    if ( has_arch_pdevs(d) || cache_flush_permitted(d) )
> >>>>>
> >>>>> Is it possible to have cache flush allowed without any PCI device
> >>>>> assigned? AFAICT the iomem/ioport_caps would only get setup when there
> >>>>> are device passed through?
> >>>>
> >>>> One can assign MMIO or ports to a guest the raw way. That's not
> >>>> secure, but functionally explicitly permitted.
> >>>>
> >>>>> TBH I would be fine if we just say that PoD cannot be used in
> >>>>> conjunction with an IOMMU, and just check for is_iommu_enable(d) here.
> >>>>>
> >>>>> I understand it's technically possible for PoD to be used together
> >>>>> with a domain that will later get a device passed through once PoD is
> >>>>> no longer in use, but I doubt there's much value in supporting that
> >>>>> use case, and I fear we might be introducing corner cases that could
> >>>>> create issues in the future. Overall I think it would be safer to just
> >>>>> disable PoD in conjunction with an IOMMU.
> >>>>
> >>>> I consider it wrong to put in place such a restriction, but I could
> >>>> perhaps accept you and Andrew thinking this way if this was the only
> >>>> aspect playing into here. However, this would then want an equivalent
> >>>> tools side check, and while hunting down where to make the change as
> >>>> done here, I wasn't able to figure out where that alternative
> >>>> adjustment would need doing. Hence I would possibly(!) buy into this
> >>>> only if someone else took care of doing so properly in the tool stack
> >>>> (including the emission of a sensible error message).
> >>>
> >>> What about the (completely untested) chunk below:
> >>>
> >>> diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_create.c
> >>> index d7a40d7550..e585ef4c5c 100644
> >>> --- a/tools/libs/light/libxl_create.c
> >>> +++ b/tools/libs/light/libxl_create.c
> >>> @@ -1160,17 +1160,16 @@ int libxl__domain_config_setdefault(libxl__gc *gc,
> >>>      pod_enabled = (d_config->c_info.type != LIBXL_DOMAIN_TYPE_PV) &&
> >>>          (d_config->b_info.target_memkb < d_config->b_info.max_memkb);
> >>>  
> >>> -    /* We cannot have PoD and PCI device assignment at the same time
> >>> +    /* We cannot have PoD and an active IOMMU at the same time
> >>>       * for HVM guest. It was reported that IOMMU cannot work with PoD
> >>>       * enabled because it needs to populated entire page table for
> >>> -     * guest. To stay on the safe side, we disable PCI device
> >>> -     * assignment when PoD is enabled.
> >>> +     * guest.
> >>>       */
> >>>      if (d_config->c_info.type != LIBXL_DOMAIN_TYPE_PV &&
> >>> -        d_config->num_pcidevs && pod_enabled) {
> >>> +        d_config->c_info.passthrough != LIBXL_PASSTHROUGH_DISABLED &&
> >>> +        pod_enabled) {
> >>>          ret = ERROR_INVAL;
> >>> -        LOGD(ERROR, domid,
> >>> -             "PCI device assignment for HVM guest failed due to PoD enabled");
> >>> +        LOGD(ERROR, domid, "IOMMU cannot be enabled together with PoD");
> >>>          goto error_out;
> >>>      }
> >>
> >> Perhaps. Seeing this I actually recall coming across this check during
> >> my investigation. Not changing it along the lines of what you do was
> >> then really more because of me not being convinced of the extra
> >> restriction; I clearly misremembered when writing the earlier reply.
> >> If we were to do what you suggest, I'd like to ask that the comment be
> >> changed differently, though: "We cannot ..." then isn't really true
> >> anymore. We choose not to permit this mode; "cannot" only applies to
> >> actual device assignment (and of course only as long as there aren't
> >> restartable IOMMU faults).
> > 
> > I'm fine with an adjusted wording here. This was mostly a placement
> > suggestion, but I didn't gave much thought to the error message.
> 
> FTAOD: Are you going to transform this into a proper patch then? While
> I wouldn't object to such a behavioral change, I also wouldn't want to
> put my name under it. But if it went in, I think I might be able to
> then drop the libxl adjustment from my patch.

Oh, I somewhat assumed you would integrate this check into the patch.
I can send a standalone patch myself if that's your preference. Let me
do that now.

Roger.


From xen-devel-bounces@lists.xenproject.org Thu Feb 03 10:31:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 03 Feb 2022 10:31:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264609.457755 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFZP0-0006SL-Us; Thu, 03 Feb 2022 10:31:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264609.457755; Thu, 03 Feb 2022 10:31:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFZP0-0006SE-Qw; Thu, 03 Feb 2022 10:31:46 +0000
Received: by outflank-mailman (input) for mailman id 264609;
 Thu, 03 Feb 2022 10:31:45 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=nHU3=SS=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nFZOz-0006S8-EZ
 for xen-devel@lists.xenproject.org; Thu, 03 Feb 2022 10:31:45 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7b46eb91-84dc-11ec-8eb8-a37418f5ba1a;
 Thu, 03 Feb 2022 11:31:43 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 7BB98210F5;
 Thu,  3 Feb 2022 10:31:43 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3F41C1348D;
 Thu,  3 Feb 2022 10:31:43 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id i4kIDg+v+2EsWgAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 03 Feb 2022 10:31:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7b46eb91-84dc-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1643884303; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=vXmYw5/Ujk0DKb4HMBxVP4U/N484qdyV5J+Cqee4aMU=;
	b=Iil1LT4BQ2gzzaEaLLugkBPMIkSorCw1iC9QPC2ZolvQuNqdia7dGSOFp0aus2WJlwSP2Q
	4P+U/1q1caoCsThzkHHTRHgEBSYT9ANkbhELa7Uqok/IkAOm0T7y4saCSaRIGOYG5dKxLJ
	Eu+9a+J0OlrWxG9G/mCwnjUV2qpP7YU=
Message-ID: <42d7815f-aa16-d6e3-8e9f-379f678a1387@suse.com>
Date: Thu, 3 Feb 2022 11:31:42 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Content-Language: en-US
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220202114448.8608-1-jgross@suse.com>
 <efe591ea-36c9-0ead-727f-600ae3c5ed05@suse.com>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH] docs: document patch rules
In-Reply-To: <efe591ea-36c9-0ead-727f-600ae3c5ed05@suse.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------GV6wpJ5g7pRSDju9plv0tlxd"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------GV6wpJ5g7pRSDju9plv0tlxd
Content-Type: multipart/mixed; boundary="------------A3GNKS1ougqvuLGxmSLrzfKb";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
Message-ID: <42d7815f-aa16-d6e3-8e9f-379f678a1387@suse.com>
Subject: Re: [PATCH] docs: document patch rules
References: <20220202114448.8608-1-jgross@suse.com>
 <efe591ea-36c9-0ead-727f-600ae3c5ed05@suse.com>
In-Reply-To: <efe591ea-36c9-0ead-727f-600ae3c5ed05@suse.com>

--------------A3GNKS1ougqvuLGxmSLrzfKb
Content-Type: multipart/mixed; boundary="------------uFBDrjzQ8WxtevdUQ5DEVkdg"

--------------uFBDrjzQ8WxtevdUQ5DEVkdg
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMDMuMDIuMjIgMTE6MDcsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAwMi4wMi4yMDIy
IDEyOjQ0LCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gLS0tIC9kZXYvbnVsbA0KPj4gKysr
IGIvZG9jcy9wcm9jZXNzL3NlbmRpbmctcGF0Y2hlcy5wYW5kb2MNCj4+IEBAIC0wLDAgKzEs
Mjg0IEBADQo+PiArIyBIb3cgYSBwcm9wZXIgcGF0Y2ggc2hvdWxkIGxvb2sgbGlrZQ0KPj4g
Kw0KPj4gK1RoaXMgaXMgYSBicmllZiBkZXNjcmlwdGlvbiBob3cgYSBwcm9wZXIgcGF0Y2gg
Zm9yIHRoZSBYZW4gcHJvamVjdCBzaG91bGQNCj4+ICtsb29rIGxpa2UuIEV4YW1wbGVzIGFu
ZCB0b29saW5nIHRpcHMgYXJlIG5vdCBwYXJ0IG9mIHRoaXMgZG9jdW1lbnQsIHRob3NlDQo+
PiArY2FuIGJlIGZvdW5kIGluIHRoZQ0KPj4gK1tYZW4gV2lraV0oaHR0cHM6Ly93aWtpLnhl
bnByb2plY3Qub3JnL3dpa2kvU3VibWl0dGluZ19YZW5fUHJvamVjdF9QYXRjaGVzKS4NCj4+
ICsNCj4+ICsjIyBUaGUgcGF0Y2ggc3ViamVjdA0KPj4gKw0KPj4gK1RoZSBmaXJzdCBsaW5l
IGF0IHRoZSB0b3Agb2YgdGhlIHBhdGNoIHNob3VsZCBjb250YWluIGEgc2hvcnQgZGVzY3Jp
cHRpb24gb2YNCj4+ICt3aGF0IHRoZSBwYXRjaCBkb2VzLCBhbmQgaGludHMgYXMgdG8gd2hh
dCBjb2RlIGl0IHRvdWNoZXMuIFRoaXMgbGluZSBpcyB1c2VkDQo+PiArYXMgdGhlICoqU3Vi
amVjdCoqIGxpbmUgb2YgdGhlIG1haWwgd2hlbiBzZW5kaW5nIHRoZSBwYXRjaC4NCj4+ICsN
Cj4+ICtUaGUgaGludCB3aGljaCBjb2RlIGlzIHRvdWNoZWQgdXMgdXN1YWxseSBpbiBmb3Jt
IG9mIGEgcmVsYXRpdmUgcGF0aCBpbnNpZGUNCj4gDQo+IE5pdDogcy8gdXMgLyBpcyAvDQo+
IA0KPj4gK3RoZSBYZW4gZ2l0IHJlcG9zaXRvcnksIHdoZXJlIG9idmlvdXMgZGlyZWN0b3Jp
ZXMgY2FuIGJlIG9taXR0ZWQgb3IgcmVwbGFjZWQNCj4+ICtieSBhYmJyZXZpYXRpb25zLCBv
ciBpdCBjYW4gYmUgYSBzaW5nbGUgd29yZCBkZXNjcmliaW5nIHRoZSB0b3BpYzoNCj4+ICsN
Cj4+ICsgICAgPHBhdGg+OiA8ZGVzY3JpcHRpb24+DQo+PiArDQo+PiArRS5nLjoNCj4+ICsN
Cj4+ICsgICAgeGVuL2FybTogaW5jcmVhc2UgbWVtb3J5IGJhbmtzIG51bWJlciBkZWZpbmUg
dmFsdWUNCj4+ICsgICAgdG9vbHMvbGlicy9ldnRjaG46IERlZHVwbGljYXRlIHhlbmV2dGNo
bl9mZCgpDQo+PiArICAgIE1BSU5UQUlORVJTOiB1cGRhdGUgbXkgZW1haWwgYWRkcmVzcw0K
Pj4gKyAgICBidWlsZDogY29ycmVjdCB1c2FnZSBjb21tZW50cyBpbiBLYnVpbGQuaW5jbHVk
ZQ0KPiANCj4gSSByZWFsaXplIHRoZXJlJ3MgInVzdWFsbHkiIGluIHRoZSB3b3JkaW5nLCBi
dXQgSSdtIHN0aWxsIHVuY2VydGFpbiBpbiBob3cNCj4gZmFyIHdlIHdhbnQgdG8gc3VnZ2Vz
dCBwYXRocyBoZXJlLiBJIGhhdmUgdG8gYWRtaXQgdGhhdCBJIG5ldmVyIHJlYWxseQ0KPiBs
aWtlZCBvdmVybHkgbG9uZyBwcmVmaXhlcyBsaWtlIHRoZSAidG9vbHMvbGlicy9ldnRjaG46
IiB5b3UgZ2l2ZSBhcw0KPiBleGFtcGxlLiBUaGUgcHJlZml4IHNob3VsZCBiZSBzdWZmaWNp
ZW50bHkgdW5hbWJpZ3VvdXMsIHllcywgYnV0IGluIHRoaXMNCj4gcGFydGljdWxhciBjYXNl
ICJsaWJzL2V2dGNobjoiIG9yICJsaWJ4ZW5ldnRjaG46IiB3b3VsZCBiZSBlbm91Z2ggdG8N
Cj4gYWNoaWV2ZSB0aGF0Lg0KPiANCj4gSSdkIHByZWZlciBpZiB0aGUgdGFnIHdhcyBkZXNj
cmliZWQgYXMgc3BlY2lmeWluZyBhIChzdWItKWNvbXBvbmVudCAob3INCj4gb3RoZXIgYWJz
dHJhY3QgZW50aXR5LCBsaWtlIGlzIHRoZSBjYXNlIGZvciB5b3VyICJidWlsZDoiIGV4YW1w
bGUpLg0KDQpPa2F5Lg0KDQo+IA0KPj4gK1RoZSBkZXNjcmlwdGlvbiBzaG91bGQgZ2l2ZSBh
IHJvdWdoIGhpbnQgKndoYXQqIGlzIGRvbmUgaW4gdGhlIHBhdGNoLg0KPj4gKw0KPj4gK1Ro
ZSBzdWJqZWN0IGxpbmUgc2hvdWxkIGluIGdlbmVyYWwgbm90IGV4Y2VlZCA4MCBjaGFyYWN0
ZXJzLiBJdCBtdXN0IGJlDQo+PiArZm9sbG93ZWQgYnkgYSBibGFuayBsaW5lLg0KPj4gKw0K
Pj4gKyMjIFRoZSBjb21taXQgbWVzc2FnZQ0KPj4gKw0KPj4gK1RoZSBjb21taXQgbWVzc2Fn
ZSBpcyBmcmVlIHRleHQgZGVzY3JpYmluZyAqd2h5KiB0aGUgcGF0Y2ggaXMgZG9uZSBhbmQN
Cj4+ICsqaG93KiB0aGUgZ29hbCBvZiB0aGUgcGF0Y2ggaXMgYWNoaWV2ZWQuIEEgZ29vZCBj
b21taXQgbWVzc2FnZSB3aWxsIGRlc2NyaWJlDQo+PiArdGhlIGN1cnJlbnQgc2l0dWF0aW9u
LCB0aGUgZGVzaXJlZCBnb2FsLCBhbmQgdGhlIHdheSB0aGlzIGdvYWwgaXMgYmVpbmcNCj4+
ICthY2hpZXZlZC4gUGFydHMgb2YgdGhhdCBjYW4gYmUgb21pdHRlZCBpbiBvYnZpb3VzIGNh
c2VzLg0KPj4gKw0KPj4gK0luIGNhc2UgYWRkaXRpb25hbCBjaGFuZ2VzIGFyZSBkb25lIGlu
IHRoZSBwYXRjaCAobGlrZSBlLmcuIGNsZWFudXBzKSwgdGhvc2UNCj4+ICtzaG91bGQgYmUg
bWVudGlvbmVkLg0KPj4gKw0KPj4gK1doZW4gcmVmZXJlbmNpbmcgb3RoZXIgcGF0Y2hlcyAo
ZS5nLiBgcGF0Y2ggeHkgaW50cm9kdWNlZCBhIGJ1ZyAuLi5gKSB0aG9zZQ0KPj4gK3BhdGNo
ZXMgc2hvdWxkIGJlIHJlZmVyZW5jZWQgdmlhIHRoZWlyIGNvbW1pdCBpZCAoYXQgbGVhc3Qg
MTIgZGlnaXRzKSBhbmQgdGhlDQo+PiArcGF0Y2ggc3ViamVjdDoNCj4+ICsNCj4+ICsgICAg
Q29tbWl0IDY3ZDAxY2RiNTUxOCAoIng4NjogaW5mcmFzdHJ1Y3R1cmUgdG8gYWxsb3cgY29u
dmVydGluZyBjZXJ0YWluDQo+PiArICAgIGluZGlyZWN0IGNhbGxzIHRvIGRpcmVjdCBvbmVz
IikgaW50cm9kdWNlZCBhIGJ1ZyAuLi4NCj4gDQo+IEkgdGhpbmsgdGhpcyBzaG91bGQgaGF2
ZSBhIHJlZmVyZW5jZSB0byB0aGUgRml4ZXM6IHRhZywgYXMgZ2VuZXJhbGx5IGl0DQo+IG1h
a2VzIHRoZSB0ZXh0IGxlc3MgY29udm9sdXRlZCBpZiBpdCByZWZlcmVuY2VzIHN1Y2ggYSB0
YWcgcmF0aGVyIHRoYW4NCj4gc3BlbGxpbmcgb3V0IGhhc2ggYW5kIHRpdGxlIGEgMm5kIHRp
bWUuDQoNCkkgdGhpbmsgdGhpcyBkZXBlbmRzIG9uIHRoZSB1c2UgY2FzZS4gSWYgdGhlIGNp
dGVkIHBhdGNoIGlzIGluIHRoZQ0KRml4ZXM6IHRhZyBJIGFncmVlLiBTb21ldGltZXMgYSBw
YXRjaCBpcyBjaXRlZCBmb3Igb3RoZXIgcmVhc29ucywgZS5nLg0Kd2hlbiBhZGRpbmcgYSBm
aXggc2ltaWxhciB0byB0aGUgb25lIGluIHRoZSBjaXRlZCBwYXRjaC4gSSBhbHdheXMgbGlr
ZQ0KdG8gaGF2ZSB0aGUgY29tbWl0IGlkIGluIHN1Y2ggYSBjYXNlLg0KDQpBcmUgeW91IGZp
bmUgd2l0aCBtZSByZXBocmFzaW5nIHRoZSB0ZXh0IHRvOg0KDQpXaGVuIHJlZmVyZW5jaW5n
IG90aGVyIHBhdGNoZXMgKGUuZy4gYHNpbWlsYXIgdG8gcGF0Y2ggeHkgLi4uYCkgdGhvc2UN
CnBhdGNoZXMgc2hvdWxkIGJlIHJlZmVyZW5jZWQgdmlhIHRoZWlyIGNvbW1pdCBpZCAoYXQg
bGVhc3QgMTIgZGlnaXRzKQ0KYW5kIHRoZSBwYXRjaCBzdWJqZWN0LCBpZiB0aGUgdmVyeSBz
YW1lIHBhdGNoIGlzbid0IHJlZmVyZW5jZWQgYnkgdGhlDQpgRml4ZXM6YCB0YWcsIHRvbzoN
Cg0KPiANCj4+ICsjIyBUYWdzDQo+PiArDQo+PiArVGFncyBhcmUgZW50cmllcyBpbiB0aGUg
Zm9ybQ0KPj4gKw0KPj4gKyAgICBUYWc6IHNvbWV0aGluZw0KPj4gKw0KPj4gK0luIGdlbmVy
YWwgdGFncyBhcmUgYWRkZWQgaW4gY2hyb25vbG9naWNhbCBvcmRlci4gU28gYSBgUmV2aWV3
ZWQtYnk6YCB0YWcNCj4+ICtzaG91bGQgYmUgYWRkZWQgKiphZnRlcioqIHRoZSBgU2lnbmVk
LW9mZi1ieTpgIHRhZywgYXMgdGhlIHJldmlldyBoYXBwZW5lZA0KPj4gK2FmdGVyIHRoZSBw
YXRjaCB3YXMgd3JpdHRlbi4NCj4+ICsNCj4+ICtEbyBub3Qgc3BsaXQgYSB0YWcgYWNyb3Nz
IG11bHRpcGxlIGxpbmVzLCB0YWdzIGFyZSBleGVtcHQgZnJvbSB0aGUNCj4+ICsid3JhcCBh
dCA3NSBjb2x1bW5zIiBydWxlIGluIG9yZGVyIHRvIHNpbXBsaWZ5IHBhcnNpbmcgc2NyaXB0
cy4NCj4+ICsNCj4+ICsjIyMgVGFrZW4tZnJvbToNCj4+ICsNCj4+ICtYZW4gaGFzIGluaGVy
aXRlZCBzb21lIHNvdXJjZSBmaWxlcyBmcm9tIG90aGVyIG9wZW4gc291cmNlIHByb2plY3Rz
LiBJbiBjYXNlDQo+PiArYSBwYXRjaCBtb2RpZnlpbmcgc3VjaCBhbiBpbmhlcml0ZWQgZmls
ZSBpcyB0YWtlbiBmcm9tIHRoYXQgcHJvamVjdCAobWF5YmUgaW4NCj4+ICttb2RpZmllZCBm
b3JtKSwgdGhlIGBUYWtlbi1mcm9tOmAgdGFnIHNwZWNpZmllcyB0aGUgc291cmNlIG9mIHRo
ZSBwYXRjaDoNCj4+ICsNCj4+ICsgICAgVGFrZW4tZnJvbTogPHJlcG9zaXRvcnktVVJMPiA8
Y29tbWl0LWlkPg0KPj4gKw0KPj4gK0UuZy46DQo+PiArDQo+PiArICAgIFRha2VuLWZyb206
IGdpdDovL2dpdC5rZXJuZWwub3JnL3B1Yi9zY20vbGludXgva2VybmVsL2dpdC90b3J2YWxk
cy9saW51eC5naXQgZjA5M2IwOGM0N2IzDQo+PiArDQo+PiArQWxsIHRhZ3MgKiphYm92ZSoq
IHRoZSBgVGFrZW4tZnJvbTpgIHRhZyBhcmUgZnJvbSB0aGUgb3JpZ2luYWwgcGF0Y2ggKHdo
aWNoDQo+PiArc2hvdWxkIGFsbCBiZSBrZXB0KSwgd2hpbGUgdGFncyAqKmFmdGVyKiogYFRh
a2VuLWZyb206YCBhcmUgcmVsYXRlZCB0byB0aGUNCj4+ICtub3JtYWwgWGVuIHBhdGNoIHBy
b2Nlc3MgYXMgZGVzY3JpYmVkIGhlcmUuDQo+IA0KPiBXaGlsZSBJIGRvbid0IG1pbmQgaXQg
YmVjb21pbmcgIlRha2VuLWZyb206IiwgSSdkIGxpa2UgdG8gcHV0IHVwIGZvcg0KPiBjb25z
aWRlcmF0aW9uIHRoZSAoc2xpZ2h0bHkgc2hvcnRlcikgYWx0ZXJuYXRpdmUgb2YgIk9yaWdp
bjoiLg0KDQpGaW5lIHdpdGggbWUuDQoNCj4gDQo+PiArIyMjIFJlcG9ydGVkLWJ5Og0KPj4g
Kw0KPj4gK1RoaXMgb3B0aW9uYWwgdGFnIGNhbiBiZSB1c2VkIHRvIGdpdmUgY3JlZGl0IHRv
IHNvbWVvbmUgcmVwb3J0aW5nIGFuIGlzc3VlLg0KPj4gK0l0IGlzIGluIHRoZSBmb3JtYXQ6
DQo+PiArDQo+PiArICAgIFJlcG9ydGVkLWJ5OiBuYW1lIDxlbWFpbEBkb21haW4+DQo+PiAr
DQo+PiArRS5nLjoNCj4+ICsNCj4+ICsgICAgUmVwb3J0ZWQtYnk6IEphbmUgRG9lIDxqYW5l
LmRvZUBleGFtcGxlLm9yZz4NCj4+ICsNCj4+ICtBcyB0aGUgZW1haWwgYWRkcmVzcyB3aWxs
IGJlIG1hZGUgcHVibGljIHZpYSBnaXQsIHRoZSByZXBvcnRlciBvZiBhbiBpc3N1ZQ0KPj4g
K3Nob3VsZCBiZSBhc2tlZCB3aGV0aGVyIGhlL3NoZSBpcyBmaW5lIHdpdGggYmVpbmcgbWVu
dGlvbmVkIGluIHRoZSBwYXRjaC4NCj4+ICsNCj4+ICsjIyMgU3VnZ2VzdGVkLWJ5Og0KPj4g
Kw0KPj4gK1RoaXMgb3B0aW9uYWwgdGFnIGNhbiBiZSB1c2VkIHRvIGdpdmUgY3JlZGl0IHRv
IHNvbWVvbmUgaGF2aW5nIHN1Z2dlc3RlZCB0aGUNCj4+ICtzb2x1dGlvbiB0aGUgcGF0Y2gg
aXMgaW1wbGVtZW50aW5nLiBJdCBpcyBpbiB0aGUgZm9ybWF0Og0KPj4gKw0KPj4gKyAgICBT
dWdnZXN0ZWQtYnk6IG5hbWUgPGVtYWlsQGRvbWFpbj4NCj4+ICsNCj4+ICtFLmcuOg0KPj4g
Kw0KPj4gKyAgICBTdWdnZXN0ZWQtYnk6IEphbmUgRG9lIDxqYW5lLmRvZUBleGFtcGxlLm9y
Zz4NCj4+ICsNCj4+ICtBcyB0aGUgZW1haWwgYWRkcmVzcyB3aWxsIGJlIG1hZGUgcHVibGlj
IHZpYSBnaXQsIHRoZSByZXBvcnRlciBvZiBhbiBpc3N1ZQ0KPj4gK3Nob3VsZCBiZSBhc2tl
ZCB3aGV0aGVyIGhlL3NoZSBpcyBmaW5lIHdpdGggYmVpbmcgbWVudGlvbmVkIGluIHRoZSBw
YXRjaC4NCj4gDQo+IEJlc2lkZXMgdGhlc2UgdHdvIHdlJ3ZlIGFsc28gYmVlbiB1c2luZyBS
ZXF1ZXN0ZWQtYnk6LCB3aGljaCBJIHRoaW5rIGluDQo+IHNvbWUgY2FzZXMgY29udmV5cyBp
bmZvcm1hdGlvbiBtb3JlIHByZWNpc2VseSB0aGFuIFN1Z2dlc3RlZC1ieTogKGUuZy4NCj4g
d2hlbiBzb21lIHJlc3VsdCB3YXMgdG8gYmUgYWNoaWV2ZWQgd2l0aG91dCBhIHNvbHV0aW9u
IG9yIHBhdGggdGhlcmUNCj4gaGF2aW5nIGJlZW4gZ2l2ZW4pLg0KDQpXaWxsIGFkZCBpdC4N
Cg0KPiANCj4+ICsjIyMgUmV2aWV3ZWQtYnk6DQo+PiArDQo+PiArQSBgUmV2aWV3ZWQtYnk6
YCB0YWcgY2FuIG9ubHkgYmUgZ2l2ZW4gYnkgYSByZXZpZXdlciBvZiB0aGUgcGF0Y2guIFdp
dGgNCj4+ICtyZXNwb25kaW5nIHRvIGEgc2VudCBwYXRjaCBhZGRpbmcgdGhlIGBSZXZpZXdl
ZC1ieTpgIHRhZyB0aGUgcmV2aWV3ZXINCj4+ICsod2hpY2ggY2FuIGJlIGFueWJvZHkpIGNv
bmZpcm1zIHRvIGhhdmUgbG9va2VkIHRob3JvdWdobHkgYXQgdGhlIHBhdGNoIGFuZA0KPj4g
K2RpZG4ndCBmaW5kIGFueSBpc3N1ZSAoYmVpbmcgaXQgdGVjaG5pY2FsLCBsZWdhbCBvciBm
b3JtYWwgb25lcykuIElmIHRoZQ0KPj4gK3JldmlldyBpcyBjb3ZlcmluZyBvbmx5IHNvbWUg
cGFydHMgb2YgdGhlIHBhdGNoLCB0aG9zZSBwYXJ0cyBjYW4gb3B0aW9uYWxseQ0KPj4gK2Jl
IHNwZWNpZmllZCAobXVsdGlwbGUgYXJlYXMgY2FuIGJlIGNvdmVyZWQgd2l0aCBtdWx0aXBs
ZSBgUmV2aWV3ZWQtYnk6YA0KPj4gK3RhZ3MpLg0KPiANCj4gSSdkIHByZWZlciBpZiB0aGUg
Y29tbWEgc2VwYXJhdGVkIGZvcm0gd2FzIGFsc28gZXhwbGljaXRseSBtZW50aW9uZWQNCj4g
KGFuZCBoZW5jZSBwZXJtaXR0ZWQpIGhlcmUuIEknZCBldmVuIGdvIGFzIGZhciBhcyBzdWdn
ZXN0aW5nIHRoYXQgdGhpcw0KPiBzaG91bGQgYmUgdGhlIHByZWZlcnJlZCBmb3JtIGFzIGxv
bmcgYXMgbGluZSBsZW5ndGggY29uc3RyYWludHMgcGVybWl0Lg0KDQpPVE9IIHRoaXMgd2ls
bCBtYWtlIGF1dG9tYXRlZCBwYXJzaW5nIGhhcmRlci4NCg0KSSdtIG9wZW4gZm9yIGJvdGgg
dmFyaWFudHMsIGp1c3Qgd2FudGVkIHRvIG1lbnRpb24gd2h5IEkndmUgY2hvc2VuIHRoZQ0K
bXVsdGlsaW5lIGZvcm0gaW5pdGlhbGx5Lg0KDQo+IA0KPj4gSXQgaXMgaW4gdGhlIGZvcm1h
dDoNCj4+ICsNCj4+ICsgICAgUmV2aWV3ZWQtYnk6IG5hbWUgPGVtYWlsQGRvbWFpbj4gWyMg
YXJlYV0NCj4+ICsNCj4+ICtFLmcuOg0KPj4gKw0KPj4gKyAgICBSZXZpZXdlZC1ieTogSmFu
ZSBEb2UgPGphbmUuZG9lQGV4YW1wbGUub3JnPg0KPj4gKyAgICBSZXZpZXdlZC1ieTogSmFu
ZSBEb2UgPGphbmUuZG9lQGV4YW1wbGUub3JnPiAjIHhlbi94ODYNCj4+ICsNCj4+ICtJbiBj
YXNlIGEgcGF0Y2ggaXMgYmVpbmcgcmVzZW50IGFuIGFscmVhZHkgZ2l2ZW4gYFJldmlld2Vk
LWJ5OmAgdGFnIGNhbiBhbmQNCj4+ICtzaG91bGQgYmUgaW5jbHVkZWQsIGlmIHRoZSBwYXRj
aCBkaWRuJ3QgY2hhbmdlIHRoZSBwb3J0aW9ucyBvZiB0aGUgcGF0Y2gNCj4+ICtjb3ZlcmVk
IGJ5IHRoZSB0YWcsDQo+IA0KPiBNYXkgSSBzdWdnZXN0IHRvIGluc2VydCAibWVhbmluZ2Z1
bGx5IiBvciBzb21lIHN1Y2ggaGVyZT8NCg0KT2theS4NCg0KPiANCj4+IG9yIGlmIHRoZSBy
ZXZpZXdlciBhbHJlYWR5IG1hZGUgY2xlYXIgaXQgd291bGQgYmUgZmluZQ0KPj4gK3RvIG1h
a2Ugc3BlY2lmaWMgY2hhbmdlcyBhbmQgbm8gKm90aGVyKiBjaGFuZ2VzIGhhdmUgYmVlbiBt
YWRlLg0KPj4gKw0KPj4gKyMjIyBBY2tlZC1ieToNCj4+ICsNCj4+ICtTaW1pbGFyIHRvIGBS
ZXZpZXdlZC1ieTpgIHRoZSBgQWNrZWQtYnk6YCB0YWcgaXMgZ2l2ZW4gYnkgc29tZW9uZSBo
YXZpbmcgbG9va2VkDQo+PiArYXQgdGhlIHBhdGNoLiBUaGUgYEFja2VkLWJ5OmAgdGFnIGNh
biBvbmx5IGJlIGdpdmVuIGJ5IGEgKiptYWludGFpbmVyKiogb2YgdGhlDQo+PiArbW9kaWZp
ZWQgY29kZSwgYW5kIGl0IG9ubHkgY292ZXJzIHRoZSBjb2RlIHRoZSBtYWludGFpbmVyIGlz
IHJlc3BvbnNpYmxlIGZvci4NCj4+ICtGb3IgdGhpcyByZWFzb24gdGhlcmUgaXMgbm8gb3B0
aW9uYWwgYXJlYSBwb3NzaWJsZS4NCj4gDQo+IEknZCBsaWtlIHRoaXMgdG8gc2F5ICJub3Jt
YWxseSIgb3IgYWxpa2UuIE1haW50YWluZXJzIG1heSBjaG9vc2UgdG8NCj4gcmVzdHJpY3Qg
dGhlaXIgYWNrIHRvIGxlc3MgdGhhbiB3aGF0IHRoZXkncmUgbGlzdGVkIGZvciwgcmVxdWly
aW5nDQo+IHJlbWFpbmluZyBhcmVhcyB0byBnYWluIGFub3RoZXIgbWFpbnRhaW5lcidzIGFj
ay4NCg0KT2theSwgd2lsbCBhZGQgdGhhdC4NCg0KPiANCj4+ICsjIyBSZWNpcGllbnRzIG9m
IHRoZSBwYXRjaA0KPj4gKw0KPj4gK0EgcGF0Y2ggc2hvdWxkIGFsd2F5cyBiZSBzZW50ICoq
dG8qKiB0aGUgeGVuLWRldmVsIG1haWxpbmcgbGlzdCA8eGVuLWRldmVsQGxpc3RzLnhlbnBy
b2plY3Qub3JnPiBhbmQgYWxsIG1haW50YWluZXJzIG9mIGFsbCB0b3VjaGVkIGNvZGUgYXJl
YXMgc2hvdWxkIGdldCBhDQo+IA0KPiBOaXQ6IFNwbGl0IHRoaXMgbGluZT8NCj4gDQo+PiAr
Y29weSBvZiB0aGUgbWFpbCB2aWEgKipDYyoqLiBJbiBjYXNlIHNvbWUgb3RoZXIgcmVjaXBp
ZW50cyBhcmUga25vd24gdG8gYmUNCj4+ICtpbnRlcmVzdGVkIGluIHRoZSBwYXRjaCwgdGhl
eSBjYW4gYmUgYWRkZWQgdmlhICoqQ2MqKiwgdG9vLg0KPiANCj4gUHJpb3IgdG8gb3IgYWxv
bmdzaWRlICJpbnRlcmVzdGVkIiBwYXJ0aWVzLCBJIHRoaW5rIHdlIHdpbGwgd2FudCB0byBt
ZW50aW9uDQo+IGRlZGljYXRlZCByZXZpZXdlcnMuDQoNCk9oLCBpbmRlZWQuDQoNCg0KSnVl
cmdlbg0K
--------------uFBDrjzQ8WxtevdUQ5DEVkdg
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------uFBDrjzQ8WxtevdUQ5DEVkdg--

--------------A3GNKS1ougqvuLGxmSLrzfKb--

--------------GV6wpJ5g7pRSDju9plv0tlxd
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmH7rw4FAwAAAAAACgkQsN6d1ii/Ey/4
Sgf+KJSrIwg7Y7u4aOleFyDcoYPHNqFXIc8dgQkiM1htssJoYZmXwSm0URsagJAzdhzQNpW1jzxC
39+gfykaTMbXB/1ORMIjDJwYvA6+HM0EJZGPzQfya5+CsA4NoCB/NXjOwA3za1gIypwL1ruIzwJg
l+B1vhFtTf/ThUEodmzGzXxfaMZnNlTrIhl0t4a4xWJ79q8oHL54KfmYaL3Z8BthnBqHF6FoBXkh
ig+TXIPZSCsZHYkozfXQGfFJ9hTxIEEhZrVNesCVx3/JJoY+ORcZ9p0UutHK8z57gywwKLX2LBPx
TgFYIOrOvJ6xuQ5dFB9aJuqofokS+F+yGx4NgY8lIQ==
=QA5Y
-----END PGP SIGNATURE-----

--------------GV6wpJ5g7pRSDju9plv0tlxd--


From xen-devel-bounces@lists.xenproject.org Thu Feb 03 10:55:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 03 Feb 2022 10:55:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264616.457766 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFZm4-0000Ql-Sr; Thu, 03 Feb 2022 10:55:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264616.457766; Thu, 03 Feb 2022 10:55:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFZm4-0000Qe-Po; Thu, 03 Feb 2022 10:55:36 +0000
Received: by outflank-mailman (input) for mailman id 264616;
 Thu, 03 Feb 2022 10:55:35 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=nHU3=SS=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nFZm3-0000QY-8x
 for xen-devel@lists.xenproject.org; Thu, 03 Feb 2022 10:55:35 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id cf8a549f-84df-11ec-8f75-fffcc8bd4f1a;
 Thu, 03 Feb 2022 11:55:33 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 549C11F440;
 Thu,  3 Feb 2022 10:55:33 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1DF5A13BAC;
 Thu,  3 Feb 2022 10:55:33 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id dCfuBaW0+2FoZgAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 03 Feb 2022 10:55:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cf8a549f-84df-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1643885733; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=N/TMokAea3A/PETWtYhknx9ccrHFTYWQUwOmRVJPOxY=;
	b=mdNyYRSrms7wQueLuj+j1GxmgGBCXi0fVTbEOIgV2FOKm/f0s74zBmna439yx5Z89Quo4B
	yKfMVakM+pc6r0kt7nMRRsFEePcO4hH7jxrRx8WBypW/Ny1ufulafWrkplGUEQfw1JucbS
	fqNxCKa9fnZWKwxQtouyRevhL+KxOkg=
Message-ID: <93d0c738-df71-bfc2-445a-7b892884d8f3@suse.com>
Date: Thu, 3 Feb 2022 11:55:32 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Subject: Re: [PATCH] xen: add option to disable GNTTABOP_transfer
Content-Language: en-US
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220201090239.32067-1-jgross@suse.com>
 <2c3c7da6-0239-1999-3cb4-a5f49745c6b5@suse.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <2c3c7da6-0239-1999-3cb4-a5f49745c6b5@suse.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------92dA1oy60qxRr6BoyEpVCJt2"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------92dA1oy60qxRr6BoyEpVCJt2
Content-Type: multipart/mixed; boundary="------------Re08gcV5BadRwUXckh8Z7KzP";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
Message-ID: <93d0c738-df71-bfc2-445a-7b892884d8f3@suse.com>
Subject: Re: [PATCH] xen: add option to disable GNTTABOP_transfer
References: <20220201090239.32067-1-jgross@suse.com>
 <2c3c7da6-0239-1999-3cb4-a5f49745c6b5@suse.com>
In-Reply-To: <2c3c7da6-0239-1999-3cb4-a5f49745c6b5@suse.com>

--------------Re08gcV5BadRwUXckh8Z7KzP
Content-Type: multipart/mixed; boundary="------------9Fobx7Ee2ZHGKKzd0aYZXm76"

--------------9Fobx7Ee2ZHGKKzd0aYZXm76
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMDMuMDIuMjIgMTA6MTAsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAwMS4wMi4yMDIy
IDEwOjAyLCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gVGhlIGdyYW50IHRhYmxlIG9wZXJh
dGlvbiBHTlRUQUJPUF90cmFuc2ZlciBpcyBtZWFudCB0byBiZSB1c2VkIGluDQo+PiBQViBk
ZXZpY2UgYmFja2VuZHMsIGFuZCBpdCBoYXNuJ3QgYmVlbiB1c2VkIGluIExpbnV4IHNpbmNl
IHRoZSBvbGQNCj4+IFhlbi1vLUxpbnV4IGRheXMuDQo+IA0KPiBLaW5kIG9mIHVudXN1YWwg
c3BlbGxpbmcgb2YgWGVub0xpbnV4IDstKQ0KPiANCj4+IC0tLSBhL3hlbi9jb21tb24vZ3Jh
bnRfdGFibGUuYw0KPj4gKysrIGIveGVuL2NvbW1vbi9ncmFudF90YWJsZS5jDQo+PiBAQCAt
MTgxLDYgKzE4MSw3IEBAIHN0YXRpYyBpbnQgcGFyc2VfZ250dGFiX21heF9tYXB0cmFja19m
cmFtZXMoY29uc3QgY2hhciAqYXJnKQ0KPj4gICANCj4+ICAgdW5zaWduZWQgaW50IF9fcmVh
ZF9tb3N0bHkgb3B0X2dudHRhYl9tYXhfdmVyc2lvbiA9IEdOVFRBQl9NQVhfVkVSU0lPTjsN
Cj4+ICAgc3RhdGljIGJvb2wgX19yZWFkX21vc3RseSBvcHRfdHJhbnNpdGl2ZV9ncmFudHMg
PSB0cnVlOw0KPj4gK3N0YXRpYyBib29sIF9fcmVhZF9tb3N0bHkgb3B0X2dyYW50X3RyYW5z
ZmVyID0gdHJ1ZTsNCj4gDQo+IElmIHRoaXMgd2FzIGNvbmRpdGlvbmFsIHVwb24gUFYgKHdp
dGggYSAjZGVmaW5lIHRvIGZhbHNlIGluIHRoZQ0KPiBvcHBvc2l0ZSBjYXNlKSwgaXQgY291
bGQgYmUgX19yb19hZnRlcl9pbml0IHJpZ2h0IGF3YXksIHdoaWxlIGF0DQo+IHRoZSBzYW1l
IHRpbWUgYWxsb3dpbmcgdGhlIGNvbXBpbGVyIHRvIGVsaW1pbmF0ZSBnbnR0YWJfdHJhbnNm
ZXIoKS4NCg0KTmljZSBpZGVhLiBUaGUgb3RoZXIgb3B0aW9uIHdvdWxkIGJlIHRvIHB1dCBh
bGwgKG9yIG1vc3QpIG9mDQpnbnR0YWJfdHJhbnNmZXIoKSBpbiBhICIjaWZkZWYgQ09ORklH
X1BWIiBzZWN0aW9uLCBhbGxvd2luZyB0bw0KcmVtb3ZlIHRoZSAiI2lmZGVmIENPTkZJR19Y
ODYiIHBhcnRzIGluIGl0LCB0b28uDQoNCj4gDQo+PiBAQCAtMjA0LDYgKzIwNSw4IEBAIHN0
YXRpYyBpbnQgX19pbml0IHBhcnNlX2dudHRhYihjb25zdCBjaGFyICpzKQ0KPj4gICAgICAg
ICAgIH0NCj4+ICAgICAgICAgICBlbHNlIGlmICggKHZhbCA9IHBhcnNlX2Jvb2xlYW4oInRy
YW5zaXRpdmUiLCBzLCBzcykpID49IDAgKQ0KPj4gICAgICAgICAgICAgICBvcHRfdHJhbnNp
dGl2ZV9ncmFudHMgPSB2YWw7DQo+PiArICAgICAgICBlbHNlIGlmICggKHZhbCA9IHBhcnNl
X2Jvb2xlYW4oInRyYW5zZmVyIiwgcywgc3MpKSA+PSAwICkNCj4+ICsgICAgICAgICAgICBv
cHRfZ3JhbnRfdHJhbnNmZXIgPSB2YWw7DQo+PiAgICAgICAgICAgZWxzZQ0KPj4gICAgICAg
ICAgICAgICByYyA9IC1FSU5WQUw7DQo+IA0KPiBUbyBwb3NzaWJseSBzYXZlIGEgZnVydGhl
ciByb3VuZHRyaXA6IElmIHRoZSBQViBkZXBlbmRlbmN5IHdhcyBhZGRlZA0KPiBhYm92ZSwg
SSdkIGxpa2UgdG8gYXNrIHRvIGZvbGxvdyB0aGUgbW9kZWwgb2YgcGFyc2VfaW9tbXVfcGFy
YW0oKQ0KPiBoZXJlIGFuZCB1c2UgIiNpZm5kZWYgb3B0X2dyYW50X3RyYW5zZmVyIiBhcm91
bmQgdGhlIGFkZGVkIGNvZGUgaW4NCj4gZmF2b3Igb2YgIiNpZmRlZiBDT05GSUdfUFYiLg0K
DQpPa2F5Lg0KDQo+IA0KPj4gQEAgLTIyMzMsNiArMjIzNiw5IEBAIGdudHRhYl90cmFuc2Zl
cigNCj4+ICAgICAgIHVuc2lnbmVkIGludCBtYXhfYml0c2l6ZTsNCj4+ICAgICAgIHN0cnVj
dCBhY3RpdmVfZ3JhbnRfZW50cnkgKmFjdDsNCj4+ICAgDQo+PiArICAgIGlmICggIW9wdF9n
cmFudF90cmFuc2ZlciApDQo+PiArICAgICAgICByZXR1cm4gLUVOT1NZUzsNCj4gDQo+IC1F
T1BOT1RTVVBQIHBsZWFzZS4NCg0KWWVzLCB0aGF0J3MgYmV0dGVyLg0KDQoNCkp1ZXJnZW4N
Cg==
--------------9Fobx7Ee2ZHGKKzd0aYZXm76
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------9Fobx7Ee2ZHGKKzd0aYZXm76--

--------------Re08gcV5BadRwUXckh8Z7KzP--

--------------92dA1oy60qxRr6BoyEpVCJt2
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmH7tKQFAwAAAAAACgkQsN6d1ii/Ey+3
jAgAkw9tzwrfNqTQDO9Sb3DV/SMsEWDhD4gc5daC+2sgIbMd27MmBdF9LWajvK2PTFY2aLIsC8ZK
bp70d6Yv0LT11PAq/EsYHOJdv8aizUcEG+oFDMz01W17Y82gemVqP/WOUdJLPaogdUmXxWK/iKg9
DVy1DVOv8Fw1NdVWY9gUwsPJpvcPQIMe5zopv3WZ2qfI5lLf1v1wXfO7qNDGqPJAm+l115rgCIjr
mRhD3c28yM1bP7H8VDFKgeKspCkuY+DACA8Agbl2JiUJ0htQoHa4a0GNEPV7vxmxVjcfLl3T9/mY
cx0ZvOX1dvskIENR3KG3RCbAvVp2ZK5fMeiiDwmCIw==
=0zHN
-----END PGP SIGNATURE-----

--------------92dA1oy60qxRr6BoyEpVCJt2--


From xen-devel-bounces@lists.xenproject.org Thu Feb 03 11:07:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 03 Feb 2022 11:07:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264624.457777 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFZxJ-00022u-3J; Thu, 03 Feb 2022 11:07:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264624.457777; Thu, 03 Feb 2022 11:07:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFZxJ-00022n-0B; Thu, 03 Feb 2022 11:07:13 +0000
Received: by outflank-mailman (input) for mailman id 264624;
 Thu, 03 Feb 2022 11:07:11 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mjBt=SS=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nFZxH-00022h-B7
 for xen-devel@lists.xenproject.org; Thu, 03 Feb 2022 11:07:11 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6cf0c918-84e1-11ec-8eb8-a37418f5ba1a;
 Thu, 03 Feb 2022 12:07:09 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6cf0c918-84e1-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1643886429;
  h=from:to:cc:subject:date:message-id:
   content-transfer-encoding:mime-version;
  bh=6gqfhiUC3uEYxiFm1iVa9AhPNmJIT0SxLUG9WgrR6fg=;
  b=Ki45S7XzpELP2tn8xwuzWGieH9zUkLo0zPfNMhBcD/Q5XIVrMgnmwkTQ
   3RjJwAV5ydh3GQEBpnpKYagVtMImPl3ogs+Yu3aLsOJ9bWV2qU7LZDfp8
   98uwO+2avSqYxxxdZ8B3crQ9IVjf6VW5tl9ME2iOc/UKR0QzzxQyrlAIY
   Y=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: zc/e1xSXd7H23wfpbfm+gGkOMY4Raz+4duQZ3cT/ZufRMejuruiWXhg9kOo04C6BbUo27y8y+8
 +hXasrt2slp0yPiUiXFqWIPzD70V9Iz1yyqvLV5YzzL5pRHFSJCNhGdvh02XERP43ZDEhUuAie
 EdE0sI0tSe7UB/WPH8RNE75GY8cPCq0vaPWjnf5+SXbaokTcNWITzISvAV4etYQi00jvkiyDwY
 v3dDm4uK7Z+L51b9w0Df178EH3dkP5aiwQr4ShuZBUMWUY/5jMr6gh3QDpJw659gXHfiLrERzN
 uoAtWtUFkbBT/XSL9+I0/IDR
X-SBRS: 5.2
X-MesageID: 63316582
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:U1GYPqOtYhc852nvrR1UkMFynXyQoLVcMsEvi/4bfWQNrUomgz1Un
 GNKC2CFbquON2D8KI0kOtni9RgB6sWAzt4xSQto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6UUsxNbVU8En1500o4w7dRbrNA2rBVPSvc4
 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq
 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYo3KAw9Fby
 uxSjrHzTSA5L5zAqLgbczANRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs
 6VFdnZdNXhvhMrvqF6/YvNrick5atHiIasUu216zCGfBvEjKXzGa/uRvoYGgWdq7ixINfbwS
 8RAbydeVQWaUzBTNVEUGLV5hd790xETdBUH8QnI9MLb+VP7zgNr16P2GMHIYdHMTsJQ9m6ar
 G/b+2XyAjkBKceSjzGC9xqEluLJ2C/2Ro8WPLm57eJxxk2ewHQJDx8bXkf9puO24mahX/pPJ
 kpS/TAhxZXe72TyEIO7BUfh5ifZ4FhMALK8DtHW9inKw/bVyQSgGVMpDTpmeM0XuP9qQxwDg
 wrhc8zSORRjt7icSHS4/7iSrC+vNSV9EVLudRPoXiNevYC9/dhbYgbnC486TfXr1oGd9STYn
 mjSxBXSkYn/miLiO0+T2VncywyhqZHSJuLezlWGBzn1hu+ViWPMWmBJ1bQ5xasYRGp6ZgPY1
 JThpyR4xLpVZX1qvHfVKNjh5Jnzu5643MT02DaD5aUJ+TW34GKEdotN+jx4L0oBGp9aJWS5O
 xKN5FIKu8Q70J6WgUlfOdnZ5yMClvCIKDgYfqqMMoomjmZZKGdrAx2ClWbPhjuwwSDAYIk0O
 IuBcNbEMJrpIf8P8dZCfM9EieVD7nlnnQv7HMmnpzz6j+b2TCPLGN8tbQvfBshkvfjsiFiEr
 L5i2z6ilk83vBvWOHeHqOb+7DkicBAGOHwBg5cGK7feclc6QzxJ5j246epJRrGJVp99z4/g1
 nq8RlVZ2Bz4g3jGIh+NcXdtdPXkWpMXkJ7xFXdE0Y+A1ydxbICxwr0YcpdrL7Ar+PY6lax/T
 uUfetXGCfNKE2yV9zMYZJj7jYpjaBX02l7eY3v7OGAyL8x6WgjE2t74ZQ+zpiMAOTW66Jklq
 Lq62wKFHZdaH1Z+DNzbYe6Exk+quSRPg/p7WkbFe4EBeEjl/IVwBTb2i/s7f5MFJRnZn2PI3
 AeKGxYI4+LKptZtotXOgKmFqaavEvd/QRUGTzWKs+7uOHCDrGS5wIJGXOKZRhznVTv5qPe4e
 OFY7/DgK/lbzlxEhJVxTuRwxqUk6tqx+7IDllZ4HG/GZkiAA697JiXUxtFGs6BAy+MLuQayX
 U7TqNBWNa/QZZHgGV8VYgEkcv6CxbcfnTyLtaY5J0Dz5SlW+rubUBoNY0nQ2XIFdLYlYpk4x
 eoBudIN713tgxUnBd+KkyRI+jneNXcHSagm6skXDYKDZtDHEb2ejUgw0hPL3aw=
IronPort-HdrOrdr: A9a23:C6tGeK28TAc6hPDECQqj0QqjBVxyeYIsimQD101hICG9Lfb3qy
 n+ppsmPEHP5Ar5OEtBpTiBUJPwJk80kqQFnLX5XI3SJjUO3VHIEGgM1/qa/9SNIVyaygc/79
 YfT0EdMqyJMbESt6+Ti2PUYrVQouVvmJrY+ts2pE0dKz2CBZsQizuQXW2gYzFLrUR9dNIEPa
 vZwvACiyureHwRYMj+Ln4ZX9Lbr9mOsJ79exYJCzMu9QHL1FqTmfTHOind+i1bfyJEwL8k/2
 SAuwvl5p+7u/X+7hPHzWfc47lfhdOk4NpeA86njNQTN1zX+02VTbUkf4fHkCE+oemp5lpvuN
 7Qoy04N8A20H/VdnHdm2qb5yDQlBIVr1Pyw16RhnXu5ebjQighNsZHjYVFNjPE9ksJprhHoe
 129lPck6ASIQLLnSz76dSNfQptjFCIrX0rlvNWp2BDULEZdKRaoeUkjQ9o+a87bWPHAb0cYa
 lT5Jm23ocUTbraVQGVgoBX+q3jYpxpdS32AHTruaSuokxrdT5Cvg4lLfck7wc9HaQGOux5Dt
 T/Q9VVfY51P7wrhNpGdZw8qOuMexrwqEH3QSuvyWqOLtB0B5uKke+y3IkI
X-IronPort-AV: E=Sophos;i="5.88,339,1635220800"; 
   d="scan'208";a="63316582"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=aGfm22tRJLh7uxWz15Igp4jdVgPufhxyoHAjDl6NhV7G41fGMd/vsa9GCvRc51nKuDTHQDK6g0YyJ8vnfKNI6R/0TPzuTvwFX2TlG2uDh1sfP8XCKfcK33Yx0nEr1LQjCQZg7mq7vDm/WgTO+9sSAZ7R77gw+vBuGn9wUxVRer2Bn+Zm1H9MT1MA+27lm4MdVIZc2sRnJMBttff53qC6bajCpkQEHM80jywuMckwHVQmbPBYLkhruap3XUltodp1gsq6HLBQ6cDWj+kxtWYjdT8xBUwcLdq+3ddNV6CT+neLfbX3015Yi12YMZCTOF0Rh48tWgv+LSqlKk4KnREIPw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=RGGgEMiYSdtDhYu8CkqWA9Ie6XCQvmc1RhXhlaBA9v0=;
 b=b5o6MUAZTIGuLHzPndR/QZsLPUdgvXicDZ4IXXAWQOkS35mluMr86kivUDiF5t5la726xZ6M+zRip/h9zR+eT4P6ZgKHHKo5c3J5jOwaG5WQQgYKRvZJ7GKgc6lyVh43w3lQOpWnvb9rAzNHk1nn7/QGKKAdpgdJKbuZxDa9wG6zYLE6CldFy58ERlctSi4P0hUHDyVOLYyULdFUaeXsm20T/8ENn84xQzwYuLpisYr/8DamxwqlflcBdxdJBdyjMSJ2kxDjhghvzeWDHtVPXVScgolqXC6SsEZi7ezrWx1Z74qMppv1WM0u2JAtx/IyCkqTaxBtU360bQNNyVgsHw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=RGGgEMiYSdtDhYu8CkqWA9Ie6XCQvmc1RhXhlaBA9v0=;
 b=W0BprREW613xMEHQAbxYy4G6g4mYxxoRaX1AvkYp7B9/sP/zNvjZn75P3Yo47BOE6hV+Q2msdNyUfCiTPxH16IQVTj6c9N5/SnuE6K8LmpldoxwqpQtM5dKkBjEA+o+01B9v5+Xm0nHzcPkUUyQ1nauROGsuOI9T/8Bwhghyajw=
From: Roger Pau Monne <roger.pau@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>, "Anthony
 PERARD" <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, "Jan
 Beulich" <jbeulich@suse.com>
Subject: [PATCH] tools/libxl: don't allow IOMMU usage with PoD
Date: Thu,  3 Feb 2022 12:06:51 +0100
Message-ID: <20220203110651.17419-1-roger.pau@citrix.com>
X-Mailer: git-send-email 2.34.1
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO4P123CA0183.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1a4::8) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7b9aeaa9-a813-47ff-1dec-08d9e7054daa
X-MS-TrafficTypeDiagnostic: BN7PR03MB3666:EE_
X-Microsoft-Antispam-PRVS: <BN7PR03MB36662A8B00BAAFED5004B4E38F289@BN7PR03MB3666.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: fy0Qa+XGVYkRLb+WCMpzOKP2B42o9Zfhq9iXBHbcDACKF4JL7QSsEsPOIa3u+SPkFCsw/HGjX5/H86ynHxl+bflwgIVC5jf4LFBCdLTloo6gZwnmaSAw+gRRShRR7pQoBA1v6/BnwLgbi4FjgTCz+xMtdeE8OqZWOHnnXoS5f90oGQ53PpCk/Lsoa/ee4ub1aV2eOq2QDLOwUOClpwww3hWaaRgEb0ywCcBMWJ9G7izP12G4yFXRqLZRbT0N7Lfkjg2lSVuuWjzuR2dQVq/KY5wiJn7mhi5mfYLFmb+ztbl9Y0wogb8tzHRc2oRhY0tyAMhNXDJDyzQCxneMRHPuE1V5wjFWr0BZcOxNqc2ZanHrLGY2OdFeu22dFBp/bhK2PvkF0+iEJT23glOPoVzjNX7hFmgdMQgiq0gspQ/ESzUIvBXsy7L2O2GCMHpLSAhDpuHzvpCe/QoU7BgRWnP9qEyzJNH9JcF3zYa4jJOToxtvqoWwK7hw2faukXC9SIi/mkyhdNGzn+JZvChiqYJjfjubgwjr0cKMIcgx85wNtSXpzZSkYYrz6ahxpHYDBwhBj9oUlnPVpNSx+HJ3OX0qbggjoLr6scoVfsXFbQu42WhfOQ1Qcq4ABR0Hx4+ifQd46ZyRqN9V36ykLSrVv9VkUA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(2906002)(82960400001)(8936002)(8676002)(66476007)(66946007)(66556008)(316002)(38100700002)(54906003)(6506007)(508600001)(6512007)(6666004)(6486002)(6916009)(86362001)(1076003)(2616005)(186003)(26005)(4326008)(36756003)(5660300002)(83380400001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SVFIelR1aVJqQmFucXV6TVQ0OWR3QlhhRWVQeWdmTFlFQUhZTWJQQXkyLzFl?=
 =?utf-8?B?bFJiUGk5R3N4YW5lN3dBa1I3dWh5SDFycWJuWUJCZlJDSFpKQjNpbHVaTHJW?=
 =?utf-8?B?cllhQU02T2MvUjJlOFd4UnVoZVVub1IzR1J4NmN2ZmFCeTh3MEpyRmFqakpD?=
 =?utf-8?B?aHRzS2E3Y2pvdW1XY0UvZzRqL01zaUlySi85NE1jOGROQVp5dnI4L1QxWlBO?=
 =?utf-8?B?UjlyRUMzbTA4ZjdiT01LQ2ZhQktCYUdMZWZNTmZBczFPZDZSOTRvNFNKakFI?=
 =?utf-8?B?aktObzhRU29IZ054MWVLeTdVREVCYk5tZzc5VURUaEN0ekVyQk5xZGtXTjg2?=
 =?utf-8?B?anZmaDNPRWVyT2ZrNWtaaXgyRjJIWm1ydklNdzFNdWNNckIzVkZyaGptaDBT?=
 =?utf-8?B?RHdXaUZKMTF3TW9TOUJ2TC9qT0xydDVjRXlnbTdwUUhTTFFSaGxMYnJUVUkr?=
 =?utf-8?B?NkJwT282cEIxaEpyZ3FUQWx1RlZNMkE2UVBjWWp1RjhpbWliLzBrZzNHdkFh?=
 =?utf-8?B?all0THJMT2VzVEM4VGM4bmswQlhBU2hQb2Zzb3RKdVRnWXhmWU1CVkNaL0lo?=
 =?utf-8?B?MjRXNExsSEdpT3plbzU2NThMbzZ2bVlOZFZOYmYybzcrbDJtRlVsQVRodjAv?=
 =?utf-8?B?WitZUDlLQ1czemNBOGVxTldLNGJLUHdaa21jWTJ3OWNTV2hjcWxtdlNGSmRR?=
 =?utf-8?B?Y3RkaTBKVHV3U1hIekRFa0w5NE9tbXRjT25BQnN1U3VUaUlvMUtoNGRIaFlL?=
 =?utf-8?B?V21NYmw5ZDhwbFVMaFYrS2FBYmpXRVJ6VXVPMVE5UHdpOUpGdUVWVnVaTitx?=
 =?utf-8?B?QWdnc083UU5Fb1ZrTks5blNYNXRsT0JuTjNmNkYraDlkMWxGTk9NQThYWE9B?=
 =?utf-8?B?QSs3V3RzMDlrbTJ1eEU0YVU0Tk0yOWQ1a3VVcWRnNGhhRUJ1R2tsK0ZTaGEz?=
 =?utf-8?B?SWY2WGE0emdkUEJnMk80ZmdBQUU5VFNDTkpzNnppVUtkdDQwVmhVeUxUK1pK?=
 =?utf-8?B?amxuOUoxZlQrVXBPanVEL2tCTUtjVFBGZGp5Y2J3djIzb1k3V1k1VVA3L0E0?=
 =?utf-8?B?QXViMHo4bVlXam1MREo1YmhKcXlhMmdid3pFSHRCdHZrOEFzOW8xdE5uT3Jo?=
 =?utf-8?B?Y3QyVFJxTG9PMHBnR1M5TVVwWjZBWDFxclh1VlVXU1RNWlRzSGNnYndoSzND?=
 =?utf-8?B?MzVpaEw0Rkw0OWdlQy92d2FlVFM3WnB4ZXlucU8yajQ2OUlUTEFXckdMaWZV?=
 =?utf-8?B?V1R2cWJ2UjFzblBOeWREaStHTHRPSWtlWm8rOVJ6OEdpUXc5RFdZZzB3clFO?=
 =?utf-8?B?MXlvdmU4QzkwRXdvT1YxdkJNRWZpM1kwQ1lQUEFyVHRkUWZkWGRTa0kvL2Za?=
 =?utf-8?B?bkltcEQ0amJRSk9TSTRSMTgvcHZkV09ySXUvaWtub3JMdlNFRkVXN1FOZjlJ?=
 =?utf-8?B?V2oyck05RTlHU3p2RTg0Szl1cjZFYzdtdnR5dHBqdnhJakdOQjFKYWkxbnlZ?=
 =?utf-8?B?NGVkRy9JOUxKT0NuYlI1azJrQ1h2U1Bxb1VOUklsYVE1ZnJKazhYNkZRbDhE?=
 =?utf-8?B?dmFNaVBPZ0VzdDhpMUhQVkxNcTJ5OWlhcnZBWUJYbXpsYmNJRzJCY2laZGpE?=
 =?utf-8?B?R0c0SGE4YjUvUVZoT1k5Q3g2Y3J5TVk5TjN1V0NSQ2lEWUZzWFBqUGFMM2wv?=
 =?utf-8?B?SXN3UVJGOFowVzFHbE0xVytIY1dENnAzcW91KzhGSTNmcVBieUZDZ0pwaHhO?=
 =?utf-8?B?Y3BuTTVtWkx3T1VqVHhoRDZiMVBYaFJYY2pOTlZRU1dKUjBjQlVuSVplMTFW?=
 =?utf-8?B?MlRZRlVSWGdlTndzK3p3SEZlY3pNZnNTUCtOQVNpWVkrc2hianlkYWpDZk5B?=
 =?utf-8?B?QmMyc1o1U1hwaUlCR0ZyeGpzbXpPVmEybnRtM2N3YWhTUjM0RkZ5UE03TGF6?=
 =?utf-8?B?MGljVVRRRUxqU0RVOXhIVGJ1SDBPVU9NTUpEQ1k3L3JWSnEvbW5UUFhSdzhu?=
 =?utf-8?B?QTJUNXpvTGxVUm1yWm1mYWRVNDJhTlNmL3Y3eXd6M1hMMElmUkFRQ3pZZjN5?=
 =?utf-8?B?anEwV28vbENuaU9MZE9SKzB1QVVRcWNHUm5RcEdWWXRwNGJMWVFUcDh6aFd5?=
 =?utf-8?B?RGkvQllCek9xL2YzN0VpRG82dy93Qmd2VXJUakZacHNLTXhXZ3Q5WjBwOWp0?=
 =?utf-8?Q?6Yd9WQBFq0+SZWIYZ1iO0sY=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7b9aeaa9-a813-47ff-1dec-08d9e7054daa
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Feb 2022 11:07:01.6451
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LRUUGquzdRmoHrLxN3hcB660DquGG1J7Ju9kbFB0jLVc3q4r1LvuLJuQqnXQVIz2Opb+YOOmHZ8uqu2YWDXNgA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB3666
X-OriginatorOrg: citrix.com

Prevent libxl from creating guests that attempts to use PoD together
with an IOMMU, even if no devices are actually assigned.

While the hypervisor could support using PoD together with an IOMMU as
long as no devices are assigned, such usage seems doubtful. There's no
guarantee the guest has ballooned down enough memory for PoD to no
longer be active, and thus a later assignment of a PCI device to such
domain could fail.

Preventing the usage of PoD together with an IOMMU at guest creation
avoids having to add checks for active PoD entries in the device
assignment paths.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Cc: Jan Beulich <jbeulich@suse.com>
---
 tools/libs/light/libxl_create.c | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_create.c
index d7a40d7550..7499922088 100644
--- a/tools/libs/light/libxl_create.c
+++ b/tools/libs/light/libxl_create.c
@@ -1160,17 +1160,16 @@ int libxl__domain_config_setdefault(libxl__gc *gc,
     pod_enabled = (d_config->c_info.type != LIBXL_DOMAIN_TYPE_PV) &&
         (d_config->b_info.target_memkb < d_config->b_info.max_memkb);
 
-    /* We cannot have PoD and PCI device assignment at the same time
-     * for HVM guest. It was reported that IOMMU cannot work with PoD
-     * enabled because it needs to populated entire page table for
-     * guest. To stay on the safe side, we disable PCI device
-     * assignment when PoD is enabled.
+    /* We don't support having PoD and an IOMMU at the same time for HVM
+     * guests. An active IOMMU cannot work with PoD because it needs a fully
+     * populated page-table. Prevent PoD usage if the domain has an IOMMU
+     * assigned, even if not active.
      */
     if (d_config->c_info.type != LIBXL_DOMAIN_TYPE_PV &&
-        d_config->num_pcidevs && pod_enabled) {
+        d_config->c_info.passthrough != LIBXL_PASSTHROUGH_DISABLED &&
+        pod_enabled) {
         ret = ERROR_INVAL;
-        LOGD(ERROR, domid,
-             "PCI device assignment for HVM guest failed due to PoD enabled");
+        LOGD(ERROR, domid, "IOMMU not supported together with PoD");
         goto error_out;
     }
 
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Thu Feb 03 11:14:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 03 Feb 2022 11:14:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264631.457788 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFa3w-0003SF-PH; Thu, 03 Feb 2022 11:14:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264631.457788; Thu, 03 Feb 2022 11:14:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFa3w-0003S8-MB; Thu, 03 Feb 2022 11:14:04 +0000
Received: by outflank-mailman (input) for mailman id 264631;
 Thu, 03 Feb 2022 11:14:02 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nFa3u-0003Ry-QF; Thu, 03 Feb 2022 11:14:02 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nFa3u-000426-Nr; Thu, 03 Feb 2022 11:14:02 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nFa3u-0000WV-6y; Thu, 03 Feb 2022 11:14:02 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nFa3u-00046I-6Z; Thu, 03 Feb 2022 11:14:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=IgoyxUQhwVvrJXiqrp9x+vH4T1zu4sEVelvPLDigmEA=; b=COeDsGXkYZRjjhqb9mky9myF8T
	M8mAS7o6YRpaUIprgwRMhKK+r489yPX0Bj3P6xeo6xjvZ4hf7fjns9fN+KRRzTZXnLfXqFvqI2+yb
	uK8jTUarc9Xq0A6RWkwGhAE7ME4gkUIKsmi13jbb1dFYHsypPk0aiDAA9KAcWZ11I+Hs=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167991-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 167991: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=f7c0e223acd5021d03736644cc0abf3501003820
X-Osstest-Versions-That:
    qemuu=47cc1a3655135b89fa75c2824fbddd29df874612
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 03 Feb 2022 11:14:02 +0000

flight 167991 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167991/

Failures :-/ but no regressions.

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds    18 guest-start/debian.repeat fail REGR. vs. 167987

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167987
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167987
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167987
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167987
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167987
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167987
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167987
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167987
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                f7c0e223acd5021d03736644cc0abf3501003820
baseline version:
 qemuu                47cc1a3655135b89fa75c2824fbddd29df874612

Last test of basis   167987  2022-02-02 13:39:33 Z    0 days
Testing same since   167991  2022-02-02 23:39:43 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Peter Maydell <peter.maydell@linaro.org>
  Warner Losh <imp@bsdimp.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   47cc1a3655..f7c0e223ac  f7c0e223acd5021d03736644cc0abf3501003820 -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Thu Feb 03 11:49:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 03 Feb 2022 11:49:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264644.457799 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFacN-0006rB-Hg; Thu, 03 Feb 2022 11:49:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264644.457799; Thu, 03 Feb 2022 11:49:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFacN-0006r4-Ef; Thu, 03 Feb 2022 11:49:39 +0000
Received: by outflank-mailman (input) for mailman id 264644;
 Thu, 03 Feb 2022 11:49:39 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=OTfZ=SS=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nFacN-0006qy-55
 for xen-devel@lists.xenproject.org; Thu, 03 Feb 2022 11:49:39 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5d03c9ea-84e7-11ec-8f75-fffcc8bd4f1a;
 Thu, 03 Feb 2022 12:49:37 +0100 (CET)
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2056.outbound.protection.outlook.com [104.47.8.56]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-39-KPQz_b0_OaucMiZwYjhr_g-1; Thu, 03 Feb 2022 12:49:36 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by HE1PR0402MB3355.eurprd04.prod.outlook.com (2603:10a6:7:81::28)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Thu, 3 Feb
 2022 11:49:32 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.012; Thu, 3 Feb 2022
 11:49:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5d03c9ea-84e7-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1643888977;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=UYMDiNNJZEYIZtAM370eRo8i7YpH9n8Y7m1ru+rugHk=;
	b=h2TR21nlshy1Qjm6yiC9f9SNGymFkjMZmYTk9WWssEUtCR7cXNriWR1ncLNVBBfV2pTzmR
	jpXOxaye/yfZ5f3VgyHIbgl2CF49P/ucuM3Bg4ZM+M4nCovk9GfSkmXWtIc6D18jyIcsdi
	udYN0ZeSrCmGFqRC3fvYYXy6MsBvDSk=
X-MC-Unique: KPQz_b0_OaucMiZwYjhr_g-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=hc96rDDx0FvNgNP5iVeWxlAp/ZOVfKSZifXgcqNV/7PU3/H2ELAdJEMf7cOQU5zGrK0u737Y0FblEDofH70bGeuVjagK6gKCSWaaeybvM22eLOX2f8rTQsg22CDIdE5tjhUiW73HGeQ+XzZdczUSmI6St9g+YtX4cl58MhK2aU60awSgD1bprT8WhZkeRJEHUmABJq4rxNJ2RliTdqeXWWIXMlvxGh+Zmqa5BJf29WvWwga3ACLyA8dz8GqGOj0GgKktBty0tDsd9SSiTuSfwZOuqD/YI3Cs0JhJsRvmNET5u1svxTOWAVdSR97vVxVAywlSdqeaL5Ji6WkF8qqzUw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=UYMDiNNJZEYIZtAM370eRo8i7YpH9n8Y7m1ru+rugHk=;
 b=N7FgROfKy/cYca8sXsIe5S4p3/bcbGzZtgBCh+rrbr3CLpqCMOGdwrQHP/cyOHIus0EGNYpJaY7baOUaP8dlawUq0PiovId14uLxqasdz95XtGwBzxOayfIhB7aMK82NXD2D5NRsKbnUzrdUEl8DDxwGm3eV3ajLcQddavU3HvH8OYSd6R0yASrMMEVNXWmeLhtM2sKMCmUfOiomN9f885nUmltKwo0AgyFN7fwyebkQqzx/57WqM/tqXkYlm3XabVYT1gpDPWfV830at2nlXPdznrsZl/AWrJTBATnm4f21VECF3Q3/TreZiJxMsydAuXVb5Z/EWWB5TB/IDNsSVA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <f491b77f-a0c2-09fe-7c7e-939f9a3210a6@suse.com>
Date: Thu, 3 Feb 2022 12:49:29 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH] docs: document patch rules
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220202114448.8608-1-jgross@suse.com>
 <efe591ea-36c9-0ead-727f-600ae3c5ed05@suse.com>
 <42d7815f-aa16-d6e3-8e9f-379f678a1387@suse.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <42d7815f-aa16-d6e3-8e9f-379f678a1387@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR0502CA0054.eurprd05.prod.outlook.com
 (2603:10a6:20b:56::31) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d07225d7-df54-4ed6-a92f-08d9e70b3dec
X-MS-TrafficTypeDiagnostic: HE1PR0402MB3355:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<HE1PR0402MB335561D37EA506C41A6BD2E7B3289@HE1PR0402MB3355.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	itRFBP6iFkKhLbfdmD3YwzuwiePlbxyYfRo4LoT8XG1iqZJ27/ncFsMHlKU7Z5SyYNzftBFg15OShw+jzxHM13mvSyz6t7Nb3svdvWB8JhHWthnAAm1gWDo9seknOMs1hPklKL0n/6r1AUAQTthg0S3c/Achjg4xhTJuVijJ6ZSA8ShuFIKy3y7r1qRfQTF9xGI6Naocq0qQ1vlGeTVBYGWBHZ4G+e7cGqm8gjqA/EBhyVH8HQnJ+bRzFie5FvZ6frcqY8Bst1Tvsa0zjfAz8PkXkXyo+oNeNJP9WHe7uqbiz0BuOKzeyz8ezCtHDB540sWEMGnYcm14XhJpD3s/tSRiwjswJG7/bo8ymSgf/ovNmz1msiKGOyoprx54/K7olfbvy5q5xo5OHR+RiMMGR1xrkoNbBIEVWL1A/aD0HYVjaaiFqFM7Hgk0rdcUnwl7glGChUG57LgVms7qgQN8HHi7EOaIhEcnaIXIzc7U0E1vZQj3b5Lwl3qCWU6QfDWBhfEz4LOkpkTlYboTCclRiUeor831wO1shZtWlq8laBbGAhBOmXjQLsvAUJIojDlwoqfvmRHI+5qU4QvVOZ1Wmx+YH6Uiq8kLrAPnGCZ9eTthSx+taJICHxT5CWusSPCSveC4uloRgvqbpIgkT76XjOIoQE3AayiCBeaYWj8EZja1UVy1XE+SKCKQ7JVgoOBrGWcFoCfU1q2bLx/CNkafdPzBSf3mowd4k708C1ZT+c7ThNTdauEmHW2yQMLOSOew
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(83380400001)(2616005)(54906003)(38100700002)(2906002)(186003)(37006003)(6636002)(86362001)(31696002)(26005)(5660300002)(66556008)(66476007)(508600001)(66946007)(6512007)(6666004)(53546011)(6506007)(36756003)(8936002)(31686004)(316002)(8676002)(6862004)(4326008)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aEphcDVzbStITHNpMXEzMThCS2luMjdxVTZWTVV5N0dwRHA1OXdjNitzWHpN?=
 =?utf-8?B?VEZ4RVFjblRCanlnS3hZdFVMeFc4cUNRUkhWZjBDbzZLSmJJMDViN2d1Risx?=
 =?utf-8?B?NnB0b0FxbjdYMy9rbUVJQzU4UG9XbFhBcXhlTEhyS2JiMWR4UWV4dFRCN1cr?=
 =?utf-8?B?ZzgyUlJhYVVCRCtrTE91azlHc0ZCakt4bUY2d2ZDM3BpYmZjS3dmOTJ0aWZ3?=
 =?utf-8?B?TUltT1pqTVNWZEl3ZERZTENHLzRnWkt1V3VEUkhtL2ZFdzgvRGswOUpkTWg2?=
 =?utf-8?B?L292N1dsVEtSS2xTZCs2ZTFpMkVHOHlRaVFNUldDQ2VEUlh0YXV5QzRNcS9t?=
 =?utf-8?B?UitZRkR5Q1VtNnJZSVVjR0ltdW1hNmdyZTNhejNwVnFycG5vS1pGelNSaVBH?=
 =?utf-8?B?dlhjdlpKTnBEc3ZjeXhockl2cVVjNG5WdVJaRUpwRHpJUzkzdFFLMEwrY0du?=
 =?utf-8?B?SWl2RXJrNnkvbFk2RkJnSlVud0NNVVNCVnBQaHN6MEdGcE9zNUNuSSs4S3Bp?=
 =?utf-8?B?T2k3RjcyOVZqU2JsOVlRaEMwMk93T3BaZWFDbEIzUW42dEcxQlliUm51UGNm?=
 =?utf-8?B?ODJ4aGZjRGJJNmU0OFByK2lQWlpvTmQrREJlckJJeGxXcXJTWWRabk5BaERv?=
 =?utf-8?B?YkNhNVN2NEN0QVJNVmpwR0NQS0NLcUIwM0dnclFRWmxHRkdnMkNXRGxSeFdT?=
 =?utf-8?B?eTcrdVlaTEFEWkp2RFp4dDdPbU5Va2xkNVN0R250L2w1NThLNk0rZUdkMnRv?=
 =?utf-8?B?Y2k2L05HeDZ5ZU5ZblJjQzB4VjhXNzJrbTlMVkRGSUZHcGVhaElaWlNOeU1D?=
 =?utf-8?B?eXR3WVNYQXBCOHV6aEZPV3V1RkZ5VkluTzk5RGpBbDhSLzZOMzBjRjI1blky?=
 =?utf-8?B?WTlHRDlQSmFENEtxVG5sYnk4WmRZVzNZdG9OdER4U2pXbXhhUVlyTnYraW83?=
 =?utf-8?B?blYxNkdVZ1BoVlJqM1dwelhtSDlmMk1UVVdpUFl5S2RFODA4TUNsTFhja0RZ?=
 =?utf-8?B?N3F1ajMvNU0yVnI4VmJ2TGVVM1dBekE1YmhGbDZzeXRYcndMZzc3QnBuTzdr?=
 =?utf-8?B?aFYvTE5wUVptbUpncTVXNjRpd3p4bGZjRFI3cloxTmdLVmhqUWJLQThOZk5y?=
 =?utf-8?B?VkhtV3pTdzhFWUMwUGV2K2xlendsZ3FFTjFIRkswRHY5eDhML0Z5QndIN0pN?=
 =?utf-8?B?dTBQS3hIRHZ0NURhMkdyQS9LRlVCeVBuUlhtZFEwVTNwSDdmUnlIRmx6QU9i?=
 =?utf-8?B?SXNiVzI4bGcwMDM2ZUZOT0NVMEtodlBVTnE5anNUNVgxOXh5dkg1VHp2V0Nx?=
 =?utf-8?B?VEcwZmkwY2lOdmJNSkNabDRVQkZIT0Zqd2g4UVE5cmFFdElWT1FFSVIwVmJF?=
 =?utf-8?B?K08xaHViRkk5eU5pSEhkUUxDZVF0aVNRVXc5dnp6UjJoUVhEQkJxSmtuVi9X?=
 =?utf-8?B?SHRteGUwN3BNdGVwM2g5SWRKN080UEw4OGN0elAycWJQekI1K3ZUMWJ3cGlC?=
 =?utf-8?B?SFgyOXhQUjBSdENHU1E2VG12ZFlLY2E0K1Q0cy8wVVZ0NW84d2VjbkY1UzlR?=
 =?utf-8?B?MW1uQnR2d3VCcDgySnF0NXJ3SU9IMHhGZkFsT3pYa0RWS0VaSnc2NzNaOExR?=
 =?utf-8?B?QkF2YnU4YzlNRENHNG4yQUViajI4eVlkUHlIMmQyZi9OZGphNnJoVkxCZ3ZN?=
 =?utf-8?B?b3dYSWJZdklGSGdBTWVoMU9zUlRMYzVQYU02Nmc3NTF4clBuSjdlTGozUnZL?=
 =?utf-8?B?TWU3akFYL2Q2Ris2ZlNwVXRGQm1XaFR0ZWJDQ2RrNXpJL1FXSzBrbUluQllK?=
 =?utf-8?B?T2tYOU4wekNSdm50V3hDVUNMbE1VcUlRTXVFS1ZncEc4V0dOVldZL0docTZW?=
 =?utf-8?B?bzl4d0VES1JPZGo2RDJqVXkxTmpEaTJiK2Q0b0FNelYrSUYvRVB1UkZMYTNR?=
 =?utf-8?B?b0t6MXBkeDVkKzNHKzYzcU8rZFQxQ0xpYnhDcVhvaWV2WXgzTHloYnVEWWNR?=
 =?utf-8?B?bC9VNHNYMjJ4TWJLMHFSbDdvWlUrM3VSbVU5eUdGdittQmptdWNmY2R1Ui81?=
 =?utf-8?B?WFh5OERGcVdnL0FhMmdrbG9QNzYxUVNvdlBmZGlWdjFFSEtSSEhUQ0JVbEFa?=
 =?utf-8?B?VHVNSm56aEVHM3NhWTVuamw4eXpOL3VXbEZ4VENkQmRvZEYvejBpZmdMSGUw?=
 =?utf-8?Q?PKBAjOmUimkncbgA4BdQvsI=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d07225d7-df54-4ed6-a92f-08d9e70b3dec
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Feb 2022 11:49:32.0930
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9pGxF+XqrMh434s17/M7zY8a0mJLE+9C/yHE+WjpIDdU8cMf15eMgogYxvP19Nkpdvtdj25ulfR2jE3gWyMVKQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0402MB3355

On 03.02.2022 11:31, Juergen Gross wrote:
> On 03.02.22 11:07, Jan Beulich wrote:
>> On 02.02.2022 12:44, Juergen Gross wrote:
>>> +## The commit message
>>> +
>>> +The commit message is free text describing *why* the patch is done and
>>> +*how* the goal of the patch is achieved. A good commit message will describe
>>> +the current situation, the desired goal, and the way this goal is being
>>> +achieved. Parts of that can be omitted in obvious cases.
>>> +
>>> +In case additional changes are done in the patch (like e.g. cleanups), those
>>> +should be mentioned.
>>> +
>>> +When referencing other patches (e.g. `patch xy introduced a bug ...`) those
>>> +patches should be referenced via their commit id (at least 12 digits) and the
>>> +patch subject:
>>> +
>>> +    Commit 67d01cdb5518 ("x86: infrastructure to allow converting certain
>>> +    indirect calls to direct ones") introduced a bug ...
>>
>> I think this should have a reference to the Fixes: tag, as generally it
>> makes the text less convoluted if it references such a tag rather than
>> spelling out hash and title a 2nd time.
> 
> I think this depends on the use case. If the cited patch is in the
> Fixes: tag I agree. Sometimes a patch is cited for other reasons, e.g.
> when adding a fix similar to the one in the cited patch. I always like
> to have the commit id in such a case.
> 
> Are you fine with me rephrasing the text to:
> 
> When referencing other patches (e.g. `similar to patch xy ...`) those
> patches should be referenced via their commit id (at least 12 digits)
> and the patch subject, if the very same patch isn't referenced by the
> `Fixes:` tag, too:

Sounds good to me.

>>> +### Reviewed-by:
>>> +
>>> +A `Reviewed-by:` tag can only be given by a reviewer of the patch. With
>>> +responding to a sent patch adding the `Reviewed-by:` tag the reviewer
>>> +(which can be anybody) confirms to have looked thoroughly at the patch and
>>> +didn't find any issue (being it technical, legal or formal ones). If the
>>> +review is covering only some parts of the patch, those parts can optionally
>>> +be specified (multiple areas can be covered with multiple `Reviewed-by:`
>>> +tags).
>>
>> I'd prefer if the comma separated form was also explicitly mentioned
>> (and hence permitted) here. I'd even go as far as suggesting that this
>> should be the preferred form as long as line length constraints permit.
> 
> OTOH this will make automated parsing harder.
> 
> I'm open for both variants, just wanted to mention why I've chosen the
> multiline form initially.

Unless commas are expected to be part of such "identifiers", I don't think
I see how parsing would become meaningfully harder. When the email address
is wanted, parsing would strip # and everything following anyway.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Feb 03 11:56:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 03 Feb 2022 11:56:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264651.457809 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFaib-0008FO-7n; Thu, 03 Feb 2022 11:56:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264651.457809; Thu, 03 Feb 2022 11:56:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFaib-0008FH-4q; Thu, 03 Feb 2022 11:56:05 +0000
Received: by outflank-mailman (input) for mailman id 264651;
 Thu, 03 Feb 2022 11:56:04 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=OTfZ=SS=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nFaia-0008FB-9v
 for xen-devel@lists.xenproject.org; Thu, 03 Feb 2022 11:56:04 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 42dc8833-84e8-11ec-8f75-fffcc8bd4f1a;
 Thu, 03 Feb 2022 12:56:03 +0100 (CET)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2106.outbound.protection.outlook.com [104.47.18.106]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-7-Nj7y5JOcOBuynyUfF13R3g-1; Thu, 03 Feb 2022 12:56:02 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AS8PR04MB8326.eurprd04.prod.outlook.com (2603:10a6:20b:3ff::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Thu, 3 Feb
 2022 11:55:59 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.012; Thu, 3 Feb 2022
 11:55:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 42dc8833-84e8-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1643889363;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=hlIUFxMgWGxdAvsZ3Zpu7XbgD5YlGha65sq9XotFu8A=;
	b=mPhfpqKr4P+FaPr22Lv/zl4OpKlwg/6WgF7n5eA/XvC4EmMND1n/eoxMKKi6hmSzAamBdt
	TaFT30R46WbrQaGwxa/392By97c5xWysnIIi3xwVUAdorGa4j0c9OGNA/dxt4ftAZNEo2+
	0C9PY9BorL0G+uVWEG+i5mNcfj7T7nI=
X-MC-Unique: Nj7y5JOcOBuynyUfF13R3g-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=UQiBWnyhviWF2+thkcauOmmHorNiCfjw9LoUcfM3BYSjkB0Ja29vhXVygWKgw50PZovJR+63LWGK1DjDvoyoV4UdVTN4qxF+KTSH7qiGk7raIFNp9UgfzOxBEGuEStwfnrJCuerqoJJevuCwIv1hsxK/ukOr6Zc1ltSV3yjBOPwb+m6HlXyPzJ739hL1KY/kgPQKqqzxRghfrhfVgRk39pNRuhW6WXhe66dAj6U6WuTeoIMHmGz2IisrfVFn9EMn5K4QRRE3pu+cHbAkSBs/2nQGAOVyl3K8ZEzTvfgXzDxgzKJ+xPpzEKIXOmIlk9r/rVV7Rr6akxNfM7+SbvOdnw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=hlIUFxMgWGxdAvsZ3Zpu7XbgD5YlGha65sq9XotFu8A=;
 b=Pl91cN5r/EhNs94ZeylOwRwZQBAGyXFnTQQOGetiIcYPIDLiwbzBQGkrr0Yxe72wN0DMC+ba1ccd1s8bf02KydIa0LjDHvJ/O0l53qu+UlEM6z05pyYjMTF0pHffJgrbMc78CQrm9pbS+/Atbrj5StoiUtzJZokT979pbD8WFR8Ccvm0N5hXONdABzyS+e6Y/vMqRoR8jYrnuxqdmQvaQzrFtV/ecsKzlD1tgFp89N3RT2mNSym6tITM9afY4OZGw3y4SgzGj9tMep4RstHB/hFPZEZinVrxKYkQFmhL0J0syG6rC7CQJoDJf4NU6zrWYIZXYsR2qHzdWDObiTLcuw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <bae9ad85-a26a-67f7-93af-166cc743e046@suse.com>
Date: Thu, 3 Feb 2022 12:55:56 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH] tools/libxl: don't allow IOMMU usage with PoD
Content-Language: en-US
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: Wei Liu <wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>,
 Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org
References: <20220203110651.17419-1-roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220203110651.17419-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR04CA0099.eurprd04.prod.outlook.com
 (2603:10a6:20b:50e::22) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a782fb82-1042-4763-a76c-08d9e70c24f8
X-MS-TrafficTypeDiagnostic: AS8PR04MB8326:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<AS8PR04MB8326A9B752510919511D2B84B3289@AS8PR04MB8326.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	NcJGp7TD25n7TCCJtiHLqnhLE8usKTfZjz8ls/xlCqOByrSxEucGRAhdcBFoqD6Wl2Nvw8QgUKWKQ2vwOHe/1svES6bvwLnURtCIXSxnoKiLtamHIrgZ008UNW8JCW7dk8GAu1bi038NGHgESRR/HotgNmyDBCLOTRTrYrGRVQMDcFHBjtJfY1w5ACLAK/Jotk0AnYLdVYXR9lLjtIbToeOhqMv/6ce+lSi90zi4LhewWVCtcnTqiv8tXDQN2D4DInQAUcEBL7jHbIs7446kcZFJFdSQPMhijA3iYbu5lh0Idn9D9K90UGAX+BbHScqTY9PT9dUT2MV9UppBQJRvACrLV/PCBYhGFEez3QMnA9HhgwHihXx7zzjM1CbGCwhZo5O0kY/eagNWDVDeLTcGv16o718XLHq4KChAM4qXjaH3DBaP8ZBOM4CNO0Xs9Kbbd4fxLf7PuVuvoBDn+rBy43BgSzsuIXX6WT+8+kTA7DR2xC0BTdz5J3u3qcOfRKSG6KukqtVobv3RUGJXUW5KjDoX7kLYEVseol93vdS3MBVxrpLUqfSEdq//6hkXDV3htBN3GBwSNeYzpQVKInGsQDb91aR1JbP9N73aFN7zdQaVCE0ilP0DAa1OiAph5/QnDutT6AD6r37RoOQOo/tkHycjuZA+3Bp0UmLKn7G48FZSwQcmDHt1q7wuz2dlu0GaYm4mMdGANEVTXybUVv1NkyDdrpbrqG+0uPWoYburRtpOD8ul0n100hq1azbHKO4/
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66476007)(5660300002)(53546011)(6666004)(508600001)(6506007)(6512007)(4744005)(66556008)(6486002)(316002)(6916009)(66946007)(38100700002)(54906003)(26005)(31696002)(4326008)(8936002)(2906002)(86362001)(36756003)(8676002)(83380400001)(31686004)(2616005)(186003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?d252RWhLRlIyenVrYlRWRzFZRmpIUVMvQjF4NWhacjFmWDJIaHVEMytRV1JN?=
 =?utf-8?B?bjVoMDYyYXB6UVU5Z29YR2wzWWNGenhnQ255OXJaTEZydEJUTU9NS0dUYllD?=
 =?utf-8?B?TVdwdzE3YUZkZFFkMHRxaU51cG1YSm5iNURMTkFkNjJRc2FsU0IwRWJEWVFu?=
 =?utf-8?B?VzQ0S29FbzdkVzJDR3FZQXZPRWtLS1JncENET3hWbTFFTVZqdEJta3pxOG1S?=
 =?utf-8?B?RnB6cWZ4VG5SaVUrOHR5cHYzYnN2dTlHSmFhc2NHRGttRE9QeHh5RW5xdjdQ?=
 =?utf-8?B?ak5FZHdUUC8xY2dDN1RURFZ2YkptbUQ5R2hkb3JYVU9IbTNlMld0WlFTa2ti?=
 =?utf-8?B?RG9SaDQxS1V0QlF4ZytWMGJhbnVEOXl5WkpJMmRaQzBIU2t4WXJhdTdoY2py?=
 =?utf-8?B?cUVWMXIxUUJ5aE9JR1pqb0lzWkJNQWE3cVJSR1FteWU2bzlnOU1uVWtRODg0?=
 =?utf-8?B?SHAwVVpmaHUwb1NJWVBhSlQ0dGdtZHV4eUxrMEdPWU1iL0VUOU44dlpnRVc2?=
 =?utf-8?B?RmdFaFNZY3E3aThJTFAwSGtvSmRISXlXV0NhbGtGc0huRC8rZ3E2a0JjaFNi?=
 =?utf-8?B?Y0IyOElHanBoMW01NGNjeU9DY3pvY05Qc05QN2JXRDlZREZGRjNncHE1bEhs?=
 =?utf-8?B?eTNBdHd0M0pKR3Avd1ZBR1dGZEV6UFJ3SkU4bEQ4SnEwUTBqZEpmaXU2WTlY?=
 =?utf-8?B?ZXdacWJIOVkxR3p0KzNjUG4xbHpTNEJaZFBUMW1CL0RTZi80bGZoZ3ZMd3ZS?=
 =?utf-8?B?OGYwK01GcGhZK3NnU0pEcUI3VEc4S0paVnFoOWVGTjJpcnZ2RWpLR2tPRzlW?=
 =?utf-8?B?elBRWFk0dlZOdEpXOUU2cklYT0hrWUp2RVhYTkdncTRFSzJGVWtrRld3MXFX?=
 =?utf-8?B?alpZdWMrR0FPd3Zub2hBNjRrVnZBbW9JbkpYcEc3UEtUU1hqR3lhb3BVSGVZ?=
 =?utf-8?B?RDFMR21KclJ3b0lGMTRCM3JrT0FNb3VvU21xNGwxOVBLUkYyMDh6Z2ZVMlVz?=
 =?utf-8?B?MnVEc2hSNmFsVW81d21vSkRLRitCTkZua2l2eXMwRS9Vb2dTZk9vNmNRZVd6?=
 =?utf-8?B?T3V3cThtTmFuU1orR0VhL3lScEt1TmE5ZmNDUnVGRGFNNlVDU0RTRXNvUnFK?=
 =?utf-8?B?cmhZOXdpZVM4Ni9wTEtuU0pEVExQU1kybFoyREplM0hEV21yeHllcEx2MEpN?=
 =?utf-8?B?MFpWMk1FUk5xaVNzdElvdTBEUEhROWhIdjNDSUo0UmQ0bGtIUDdoVTJFcXl3?=
 =?utf-8?B?dVA1dzJlT0pndkxTTVdKZ05pVmxaLzJLa0E5U2FoMTV0MEk5ZnZ2cHcwbDBJ?=
 =?utf-8?B?aCs3ZVA3eFREb2N1eVVDWGRpYm9jeksrYnB1M0xveXNaRVBTSHpDWDV0WmUw?=
 =?utf-8?B?YVZ5Z1Zrd2dDVnNya1YwTE1IOW4wRitqWWlrV3BLUVJ2d1hMU0NjZHpWRTdv?=
 =?utf-8?B?M1REbjBlREtuQ2paWmJjcjFHNEFIZk04STRWOUMwbW1SZ3NjSHZzMk85RnBO?=
 =?utf-8?B?VXljSlZNdDBTZ21LMHRpUmpyY0kxU0JpcFY4UzdpNWhqbnhWQUpDdmZINjRV?=
 =?utf-8?B?S1JPV3lRL1JkeFlHUlpFdWRiN1VkOGdNaUl2MHRZLzIwdlBXamFBYThWcVhR?=
 =?utf-8?B?WlBBNnlGTHhnYlQ1bFUxcndITWRLMWVnM2EyOFdrcVFtRkRxOGdFamJWdFc5?=
 =?utf-8?B?TThmM0d6Y1BoUnRSWDM4dW53WDFJR21UeUZlMkN4RGpMOHdrdFR3c2JpeUpw?=
 =?utf-8?B?R1A4TTlvMURJeDR5U2RjNkRsdlNQNG9URDFhVDlFRXUybndWdEZBVDZoVTFX?=
 =?utf-8?B?dExsajdjbXIySDVQUFBVODd6ZVZCSkpFUU96U2FwaHFFTjZQdzNvdDNBN0hS?=
 =?utf-8?B?aVlFZlY1a2t2S1VRd0ppOGYzbFp4QldsbXVPMmtnSlg3eW1oQTZPbXllLzBB?=
 =?utf-8?B?K2VvQlZ1VWZ3QWZSK0c2V283cEJWNitrZVdTMmFja3FYWlU5WGg5czhpRlZD?=
 =?utf-8?B?eTJxQ0YwcnovUEdyMnArd1pFTEJ6UmVyaUFJTTFHSGx6Q0VmbEllQUpHaEU1?=
 =?utf-8?B?UEl0YXZQcS9oS09nNGdGUDFnMzMzSU0xK1B2ODBKKzlSM1ZVbEdGcjE2dmlB?=
 =?utf-8?B?Z0liZmhqWHhnNVdKY3FlT2RTRmVOYWdoTEszQ3UrYzY4STJvOUxkQ3ZycjJX?=
 =?utf-8?Q?XlDeUoZlXr3Vbo8ENKdxf3M=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a782fb82-1042-4763-a76c-08d9e70c24f8
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Feb 2022 11:55:59.6628
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XPMWRlsXQzliJC9rRTf8tYVSNklAjntfCz2zFMbt8QlJx6asew3HetE3jHtk1VOULaV078CGxs4pRzvj7viMnQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8326

On 03.02.2022 12:06, Roger Pau Monne wrote:
> Prevent libxl from creating guests that attempts to use PoD together
> with an IOMMU, even if no devices are actually assigned.
> 
> While the hypervisor could support using PoD together with an IOMMU as
> long as no devices are assigned, such usage seems doubtful. There's no
> guarantee the guest has ballooned down enough memory for PoD to no
> longer be active, and thus a later assignment of a PCI device to such
> domain could fail.

That's not a precise description of the constraint: The guest ballooning
down enough only means entries == cache, but for device assignment we
need entries == 0 (and a guarantee that no new entries can appear, but I
think this is already the case once a guest was launched).

(FWIW the wording in code comment and log message read fine to me.)

Jan



From xen-devel-bounces@lists.xenproject.org Thu Feb 03 12:04:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 03 Feb 2022 12:04:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264660.457821 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFaqt-0001O8-9c; Thu, 03 Feb 2022 12:04:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264660.457821; Thu, 03 Feb 2022 12:04:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFaqt-0001O1-5u; Thu, 03 Feb 2022 12:04:39 +0000
Received: by outflank-mailman (input) for mailman id 264660;
 Thu, 03 Feb 2022 12:04:37 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=OTfZ=SS=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nFaqr-0001Nv-BC
 for xen-devel@lists.xenproject.org; Thu, 03 Feb 2022 12:04:37 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7478859c-84e9-11ec-8f75-fffcc8bd4f1a;
 Thu, 03 Feb 2022 13:04:36 +0100 (CET)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2108.outbound.protection.outlook.com [104.47.17.108]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-18-S2fY4oEjOeWBBunNbNQSzg-1; Thu, 03 Feb 2022 13:04:34 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM9PR04MB8225.eurprd04.prod.outlook.com (2603:10a6:20b:3e7::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Thu, 3 Feb
 2022 12:04:33 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.012; Thu, 3 Feb 2022
 12:04:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7478859c-84e9-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1643889875;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=RbGtFGAPQdoQUjLHf23UTiEs2aFu9ONuIqPMYyI9F6Y=;
	b=NoofWdtp/fC1UMMUp54cfNu2LQ9VI0J4ISfyZcRE/FVMhdKft0hAjoA8hL2LyXX3KWNnKt
	mM52zJWuco13uQUZZWRawIcgOM7W3qvusPk34KS00lUIEbEYqWwm5ynxGTVNEsm57WRIBr
	zmX2VyLSgHhUqRgE9AhET8T14AM1KxA=
X-MC-Unique: S2fY4oEjOeWBBunNbNQSzg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=OthmLkaoqR8xxbs49opU5o5EyH9mwraeOMdKKH0F+pH9XppDp7J8fyWZElRu1tn8UbcGAytSa9jK7sfFcJVL7OFpwjxzIh4YLhcSOKjtVzPaEOtfX1/T2y+fM2yBp3Esacb7t3sf49JrQpf/v+xqFkcjCbQAp9dYlwVz9/qNIcAQOq97C/qYfHhv039vJgM0+EG6cjKK2EsWPWCCGG+PhO9fDIEg8I6Q52M9bEPNro+R5v4ClFQ9r5Zi94CK+yMTs2ScwQ2HARC85NaEs7cST5sPTIRnqSGf6NiuSJnved8Zka5KmMgn41Xx2W6rxBpzr+b4UlbsMkBAeB28q5+16w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=RbGtFGAPQdoQUjLHf23UTiEs2aFu9ONuIqPMYyI9F6Y=;
 b=b6Ia9ajXC0T08YqSXsK5ZVQnuHJSvAHW2znfhUcsWNNTaLXLR2/yYlAskp+XSpkPDoqjfpO4kZq56HjF3sMZ6V6kuicCZwJ/VNv5mOpJ6zzkh8998X0U0xPepPzwwR8gGgeb7Ofg60HT1ObbT2AFD1DRpQU+L4byu52NTMr0RSSdwTC+CPVwWn0u3Xif6aDFl1TJaQBXD98ylgxnUwXV/BZ4KNaZZgIVKtua/IV1x59U/lc33NFzWtVQLexzIIX6tUxp9bvl3FAEaYavJTuVriQmIrK/lEgLWNcP1zC9RI0/dBjShb6rIm0pTCdIqTo3H+lFzOKbbSic0L2OpDF+SQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <b14bf41a-663c-6522-8596-df9377d69fef@suse.com>
Date: Thu, 3 Feb 2022 13:04:29 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH] xen: add option to disable GNTTABOP_transfer
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220201090239.32067-1-jgross@suse.com>
 <2c3c7da6-0239-1999-3cb4-a5f49745c6b5@suse.com>
 <93d0c738-df71-bfc2-445a-7b892884d8f3@suse.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <93d0c738-df71-bfc2-445a-7b892884d8f3@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P191CA0091.EURP191.PROD.OUTLOOK.COM
 (2603:10a6:209:8a::32) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9b05b0a6-d584-4663-6008-08d9e70d56b9
X-MS-TrafficTypeDiagnostic: AM9PR04MB8225:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<AM9PR04MB8225512065A20A39BDE27812B3289@AM9PR04MB8225.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	1AhIJG2Re1sUzKW821K63wrPCWmndJ7Uz7iMlCbDtsBVhh8uL0whHU99dx0q6Bo3Ren4qyLIjF7fSCCqAgrPzZEwUgGFZbttp4leNc3BRfWanoSv2CP+Vy1FfIJtLh7FFZ4YzxOf775FaK5BzbiCTm86oRzutFiN1CYP6/x0gMfy2EmU90SSuEi0fmP1LRfeKszsKLaDn77tnovQoV6n2IOzefHqFeiXWg7QsklSO7FMs7UhLNjTmYUClAyL8PxgyJR+mAGusGM8Pbphmx5JJgubqyGsPimN4p5WprVqU6VBGxlUiw2rrY1pE/ANeufKMk8epSWvulm0MSBNeSjX5+hnQZpQfJQqm29Yvz2Vkpag7AZDqj9k06pDWwoa+2wZowIjKhdSAXWsf8NpEJH7fNVMWZykLfTh3Z3+PGHNBnTrnLqoMpGJngC14gY6CVF1ii0rdVsUc9kODIEzAq86ZCs6HK9dgFeJlijK+aWJvLT24TaAby0yLWkRedpitU/6nkj0/TliLKqzOgX8ZlJYcoWRQKBqfK5dywgDoeZQ+aYlXDh1MgqZLf84lQ+2FrygyY7wtOa4e0YQP3XfkuBopypI8RXulh649RfhOtYIHYVKp/xgsw8LVcfXyF3mxqns7yHPnjKArnUjTFrFq1yMlOPOyLBqaUlDWzbZ/cmW9CPAsZzPwat6DEwkAfLQtAQLBe9aJ1C4kQPZTsUTOAlhw8jL7JlKmmkzhIZwqerlUqmEh1fMtjlai5G4w3UFWkj8
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66476007)(6512007)(508600001)(5660300002)(6486002)(66556008)(31686004)(316002)(2906002)(83380400001)(2616005)(66946007)(37006003)(54906003)(6636002)(26005)(186003)(6862004)(86362001)(6506007)(53546011)(6666004)(8936002)(8676002)(4326008)(36756003)(38100700002)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Q3F6T3hJaDNkQk50aFJrL2h5QnJ2ZjVtOHJlaFNmSnZtTWZUWWN3VXNNekVF?=
 =?utf-8?B?MU9uOFhCN3dGNVhYbjhzbGtnQTlNVDVxY1R1Q1NjMFJZcjVrekxhU1dyQ2pZ?=
 =?utf-8?B?b1ZlVTFYelB3SzM1QWdVUWkyNmVzQWhrMFREU3U3bnNiQ3ZOaE5hZUJZNCtM?=
 =?utf-8?B?ZmcvRzl3SitYK2N2NDlRL21tYmttSFVHS08zenBjNzh2cmdJdmJEVUdpbmQ1?=
 =?utf-8?B?TVBYZ1orVTlsYXdzK3FYV1hOVHZLVC84WGp6YzZFQ0I0YU5ySktuSTFId3Fm?=
 =?utf-8?B?SFhXSTBIMzB5NnNGcHBFKzQ4Y3czSVlwdFIwR0VuTHkyNkZtN0RiQnRyMmty?=
 =?utf-8?B?OXUxeDRpYm5BUXBXL3FZVHF2cERPalhFYVdMd1NFbUd1eUREK05kbUVYZE56?=
 =?utf-8?B?NnZ6cDhhMGRmVW9HU1RRZnhRS0NRWTJWWHVaRTgxNjBaNFYySmJhV1FmcGtm?=
 =?utf-8?B?UHI4NWpDejBIdmg5dGZ1RzllUmgrQktTUmsxYUpsL3JIWmhnc0E1RDdyNFJt?=
 =?utf-8?B?OVI1QWViQW9TNUo4ZHRYUTJGeUcxbVJ2Tk9UcFRKM1hIWkM1T1BxSlJuL0lQ?=
 =?utf-8?B?UDQxZUdvRUErRVZ6aGY2WVFBQWtuV3o0TVViampWZFVhVmpML3NUTFQ2V1RU?=
 =?utf-8?B?eW9xaktzdkloWEZiTjBRTzE1V1o4b2J4RjF3VTUrS2dPRFk3eUV4aGVpWDEw?=
 =?utf-8?B?R1pzNVBXUnk1aDAwZHdGYVU3aE96MTdud3F2QkIyWkxWYTdpbFh2VmNDQ01Y?=
 =?utf-8?B?dG1TanJBbUFFQTBOTDJ1K2I1bTNLSmoyUGZ5NU14WWozL0dTendObUF1ZmND?=
 =?utf-8?B?ek8zRnNkbmt5RVZoaVdDTE9QaHpCM2hoQ3dpTmNiRHJ5TSsyZW14cGF2cjFI?=
 =?utf-8?B?RUFqQW5RSlprcHJJd2QvOHp5V3FwQ3lKQ0pXZVUvMk9uQUZDRnRoQ2JMTkUv?=
 =?utf-8?B?akYyWVgzdjExalViL3NpeC9mdytWeFl5WkpWdDVVc0laNGlzM1dySUtyeWlk?=
 =?utf-8?B?OVphQVpaVzNoR2pCZHdrbVdNdHJxcmg3NHZWMjRCVTNkNmtpbFg1aG9ZK01M?=
 =?utf-8?B?a2h0RnR4UUQ0UlQvckl0N2dVN3JTandvc0s0cENRNFdrOVI4eDFkMXFTSnVr?=
 =?utf-8?B?T2ZvWFgrSTJxYUFxSXBrSFpPa2VRdkVhZU9UT2UrSHI5UHhtV25sdXlZZ2Yv?=
 =?utf-8?B?Qkc3ZVRPdzRTYng5MEhlZWltRWxVcEpRTU9xWktremUzS3d4RURGRHl4dmV0?=
 =?utf-8?B?dnp0d0dTYkp0SDVGTU41ZjdiTWpKTEh0OWdueGViTTFxa1BIaW1vYm5IV25S?=
 =?utf-8?B?c2xkOTdBSTJKT0lqNEo5Nk5lLzlEbTlZWFR3NGFGZnFsOWdSUWJLUjdlemFS?=
 =?utf-8?B?dUZSdWFOUXdhTTFtWFQ4TFNoaVU3Nmo0cituMENuaXBHRE5JUTNwcnYrN2ZO?=
 =?utf-8?B?NG5OekJMOFpoSldWeVJsb1UwczVKQ0paV3JBUldWanVRbWZDNkoxcU95RFIx?=
 =?utf-8?B?VGp2WFc2eEI2dGp5T1FGVkNDbXNVditGeXRZWk9hYnlBdjZYSUI5THd3Wkc3?=
 =?utf-8?B?bExSMW0yM1AwejJjbjNuTHpjdkxuU2NLVFZ2M1BndzlYeTZxaGIzTFZLOWMx?=
 =?utf-8?B?WWVwMmtHYTNyOUxTdnpFZnJhNkJiQlE1cnZoZms4eXhuWEllbVZXV05MZklu?=
 =?utf-8?B?aEdWQWJxT2p6OWdCb3BRdlJXeUVsa0FBaG5ISHcvZk1tSHFIRHYvZFA2V0pB?=
 =?utf-8?B?OFJjbjFlb1JPaFVoWEZzRkNWaTRUTElMbmcvVEFXdGtPN1VKYnRVZnVuY010?=
 =?utf-8?B?bzhwSUpPSVBFdUk2UEc5YXFTajlIMUdVMCtpUGdFZmdpZWludnFwMFpLM1JK?=
 =?utf-8?B?SHNhWTF6NWdrWkFYWjhPU2ZlYjdWNFZHeHVrNDJlMGZjWW9uZ3lVeTRUMjg5?=
 =?utf-8?B?dytDN3JJNXIrVGcxbFAzMmFGcThCVXJYNWp4MUhPRi9HMmVCd0pROHJYZTM3?=
 =?utf-8?B?NjhnN0x2T2hzdTE3ODdjK3FKN003ZDNGSlNLeFg1NUlMaERWZm45NWM2Wkhw?=
 =?utf-8?B?NUlLdnp2V2RaYmxROGs2bGRiRjI4cW9FeTRMOFlSVCtuYS9KVVdiSit5L2hy?=
 =?utf-8?B?d1JMQ3JoRHdwWHlHTE1GZmhROWg1QzUzLzBRQTQzZVJRcmIzY0VtaG5CTThl?=
 =?utf-8?Q?jSbqSLzXhflrmx+C0rlBkMc=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9b05b0a6-d584-4663-6008-08d9e70d56b9
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Feb 2022 12:04:32.6934
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HLLlgY3nN1F+KQ0uI2Hz+Omu4ocx1BmoMDhbey/uE/mtvPuUzeA6VXWU1lupwrZWJnoczqoxJjxcsX2K48XUVg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8225

On 03.02.2022 11:55, Juergen Gross wrote:
> On 03.02.22 10:10, Jan Beulich wrote:
>> On 01.02.2022 10:02, Juergen Gross wrote:
>>> The grant table operation GNTTABOP_transfer is meant to be used in
>>> PV device backends, and it hasn't been used in Linux since the old
>>> Xen-o-Linux days.
>>
>> Kind of unusual spelling of XenoLinux ;-)
>>
>>> --- a/xen/common/grant_table.c
>>> +++ b/xen/common/grant_table.c
>>> @@ -181,6 +181,7 @@ static int parse_gnttab_max_maptrack_frames(const char *arg)
>>>   
>>>   unsigned int __read_mostly opt_gnttab_max_version = GNTTAB_MAX_VERSION;
>>>   static bool __read_mostly opt_transitive_grants = true;
>>> +static bool __read_mostly opt_grant_transfer = true;
>>
>> If this was conditional upon PV (with a #define to false in the
>> opposite case), it could be __ro_after_init right away, while at
>> the same time allowing the compiler to eliminate gnttab_transfer().
> 
> Nice idea. The other option would be to put all (or most) of
> gnttab_transfer() in a "#ifdef CONFIG_PV" section, allowing to
> remove the "#ifdef CONFIG_X86" parts in it, too.

Yes, sure. The downside being that then this code won't be compile-
tested anymore in !PV builds. Yet keeping code visible to compilers
is what we aim for elsewhere by preferring if(IS_ENABLED(...)) over
#ifdef where possible.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Feb 03 12:36:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 03 Feb 2022 12:36:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264671.457848 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFbLd-0004r5-Ui; Thu, 03 Feb 2022 12:36:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264671.457848; Thu, 03 Feb 2022 12:36:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFbLd-0004qy-Rg; Thu, 03 Feb 2022 12:36:25 +0000
Received: by outflank-mailman (input) for mailman id 264671;
 Thu, 03 Feb 2022 12:36:24 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ArrP=SS=epam.com=prvs=403311c35b=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nFbLb-0004qc-VJ
 for xen-devel@lists.xenproject.org; Thu, 03 Feb 2022 12:36:24 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e3ed053d-84ed-11ec-8eb8-a37418f5ba1a;
 Thu, 03 Feb 2022 13:36:21 +0100 (CET)
Received: from pps.filterd (m0174680.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 213C2wW3031038;
 Thu, 3 Feb 2022 12:36:10 GMT
Received: from eur03-ve1-obe.outbound.protection.outlook.com
 (mail-ve1eur03lp2059.outbound.protection.outlook.com [104.47.9.59])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3e0cw4gm49-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Thu, 03 Feb 2022 12:36:10 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM6PR03MB4453.eurprd03.prod.outlook.com (2603:10a6:20b:10::33)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Thu, 3 Feb
 2022 12:36:06 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6%3]) with mapi id 15.20.4951.012; Thu, 3 Feb 2022
 12:36:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e3ed053d-84ed-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=TMuSfnhVGyo/CNGY4O/e+LFkAilnTgZX4WOhohe82W1AovqeEWQkRkUP/AILjRojsZiU83YtTjSbmz5XW3fRHYxFmqnobFBeJz1IT7ckqZ7bsaT5Ojh3l5QPQVzuG5p5oEF3MN+KwYs51zoquCpo5FTUU/ybODGuH6Xd+e+xcXjEt8o9jLUqd2Mrqg7by5PfOEdurYIBUrKxklmpy25jUIbGx+/I30B/25mFfc+w+/LkX2xptl5x4Gv47AKceSvOP0nliqMkxc9nmpaRpVk988Etbk6eZ5H5TFcugmMxR0dxbJTJHtpKXovW5Kn6w1x6kXGRDs07kpRLfCUPJOoudA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=qvjXtdrceeDe0zyUuMbF/2QUXRGNXnQyZ4ZyVbFcofA=;
 b=oZ3+oZzviw+qkGdXnjFR9d0keolWzeDXu2dGcQq22FRq6fyBCqSR5PVkize1alEcL+J4Vof6MGh+CkvIl1pRoQgghT7FQYh7nV+7520/1fexu5zPNG0jmr4uXqT3gT+lH7BK6Qaoykzo3C26zx0s0uR5pX3mAKIMkc7eoxGSs7gXhNx0Ug+8cQTtISBbrCkww70UOsbeMley304pjJ3G4o0jaWyiNZYgl951axhoOvD+ROhh4Z76o1O2Wk/AUx2hP+akecO3c7turqLYXPgor6DNiATLNZNRifi1XxMn0zmln+WoSp2RoqCdhWYp2Ijrna/KR1hfVBmWggsbT+Ip+g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=qvjXtdrceeDe0zyUuMbF/2QUXRGNXnQyZ4ZyVbFcofA=;
 b=iugyGtNeVr5lFBr5jpfQFt6o5euQqh6WouRApU0KwaNfTpTWCgWuEQoTFxcfsMETAUy6cNMdXjJHIgC5zd0yQcJ1CS51aOgs635ApBX/oH0Mtm9UxU/zTUKgZdYRnwnxVDsbfzOICbvAaQDxGncqdNVavhdjCciVs6sjp8IY5GTnLE0zLcEi64Jt45XoaSy/EmEW4fof+bbL7uiQ4zJ8zAn21Pat+utmqHivvpCL947Uo6+Yi89DN85n3+hU089wBQYFmvhTqNgRZ8yYsFecTHhsFDJZVKF9StGu1cVszLx/dKnLw7Z3hQjixX9wnKURtgk9Pmr74JyrbjMnxzunUA==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Bertrand Marquis <bertrand.marquis@arm.com>,
        "roger.pau@citrix.com"
	<roger.pau@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Julien Grall <julien@xen.org>,
        "sstabellini@kernel.org" <sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "jbeulich@suse.com" <jbeulich@suse.com>,
        "andrew.cooper3@citrix.com"
	<andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com"
	<george.dunlap@citrix.com>,
        "paul@xen.org" <paul@xen.org>, Rahul Singh
	<rahul.singh@arm.com>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v5 06/14] vpci/header: implement guest BAR register
 handlers
Thread-Topic: [PATCH v5 06/14] vpci/header: implement guest BAR register
 handlers
Thread-Index: AQHX4ewHyWAyD811HEGp8pIjUuVWNawUby8AgAFMuICAbHV4AA==
Date: Thu, 3 Feb 2022 12:36:05 +0000
Message-ID: <571d7660-c091-ac41-5e3c-441b4c5a1679@epam.com>
References: <20211125110251.2877218-1-andr2000@gmail.com>
 <20211125110251.2877218-7-andr2000@gmail.com>
 <34FC3FE6-EBA8-4A5C-A1F3-1E9F98C0337F@arm.com>
 <a6ee236b-5a00-8116-c744-6c94fcf46ae1@epam.com>
In-Reply-To: <a6ee236b-5a00-8116-c744-6c94fcf46ae1@epam.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 633b124f-4fb3-45c4-3e5c-08d9e711bf3f
x-ms-traffictypediagnostic: AM6PR03MB4453:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM6PR03MB4453B6A392810E74B6BE8AD1E7289@AM6PR03MB4453.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 YTUoddm0Xl2uIcB3KlKIcoJuzAq1yzvOwGIs4QClW5V8/dLPoTMSqj0TxNzCe3RrWmKtI2X1K2lyYO8pf/AJ0C6HVqBqLVF5NHjJfwuxHxhbDahLuozb9/Up1smgg81Lmx2cSBu0pWP9GVU4Jx0Fmr5zOreQf4AdSmjPwv1DvQ+Vhz60WSYOfs2RfGzfo8e5YQid0V186/QjJ0oamVLXEIRIyZWSf3XYEYQwjXW4diqtz4jB6U/Tza3g7ZWw/IKEG4w1/Y8/JajwQkGyU+0lX9kEj6zppy/kz2ZG0K6bmjSefxfCpXZOGOlnJ/CTgmLe5NZ3r2XPS7Zhv+SsP+Ga30iHmDQjvFOkfcUFbGyYPNX5LfN3g6kJ00HdmlduYSznDAy1PFvtVd1bMQYfnz5eeXMbpoNYx9IGYAqgrQV0nJR/N8boWpYt9pUJ73/2aqAhCcgWqdMXg4VnOSg5/jkRfc7IrsjXRnp0pxiHZ2sR0nCjl40gMQijE4p8HwZ67edyD7aN0x+crqLbWh+s9gBubRy646botAbmfm6mTk4ueL7WUtR++a+oxm8c6thLqt5WsM0RpA6sqyTucbJaOEBXZzefXHN6mwsmOcH9Xtj/zUjsaPn+gbojFBuTIvVJh7EOV54lso5F5W2ttRKhyfHmNNP3A3LKeFA2ONWI7/QHpirmfgflrdvGMEsQ9D2MGYc0b1HjBJcmdsDIQxgAInhRQmDOMZZVbcf/aQbthkdQYi31S0RrC99a3vAJV6HERST9
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(26005)(31686004)(71200400001)(8676002)(5660300002)(36756003)(316002)(38100700002)(66446008)(2616005)(76116006)(64756008)(110136005)(8936002)(54906003)(4326008)(66476007)(66946007)(186003)(107886003)(91956017)(83380400001)(66556008)(6486002)(7416002)(6506007)(31696002)(53546011)(86362001)(122000001)(508600001)(38070700005)(2906002)(6512007)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?cVpPMzJHbEZYeUZXa1crYnhkVjh3MUZOZHJobHFxcXB5K05EbUlWZURpdVF3?=
 =?utf-8?B?NWVLWlE4K1RNVzVPY3M4TWN6S0lxaVB2ZWMvZTJQQ3dIam1zU0UxclEzeXRY?=
 =?utf-8?B?Vy9jd0hwandFQ2Y5Nk9XNlFoZFhFVTgvNmlXSFJjb2E4eHU3c0xpUS8wdmFD?=
 =?utf-8?B?MDgzTXRkWDhKMk1KRVZxODdsOFYyTjhqMGJ1TGd5NHVJVG1HdGJsYUtZaG9O?=
 =?utf-8?B?c1VTSnZkK3k0alJTcDVkZXhqTGgwempUVW1qbytJWU9rZEdPblJGY25aNUti?=
 =?utf-8?B?TmM2eWxuQ3BqTUNyMUlmMkM4dGJya3RueU4xek5PZnNHYkJ3MmhhVEJyZGNn?=
 =?utf-8?B?dnJKY2dFR2RGR0s2aW94T3FwTXM4Mlg0WjlWZ1pWYklLUUU1TlBVL214cjNN?=
 =?utf-8?B?MjRpT0FRZUs2emt0NDZVdEdRMVJhekp3Y3cvaG83dE1GT2pwb0JhNmNLaXVU?=
 =?utf-8?B?RWMyZ3YxdzYzSHJXOE45eHp3OFRObm1mSXhGc2FRRUx6bHR2THo3YXJyNWVk?=
 =?utf-8?B?M203M05RU2I3VmlHTGJRc3NiRGxYY3pTOTZRM2RVSjE0ZmtFTDF6QjRVb21s?=
 =?utf-8?B?RVVLS1Y4K3dSak9xb0p4UDRMemozZ2VLV1NiTExLQ0R2WW1hbkYvWHNHRUU0?=
 =?utf-8?B?cXNkYStORmRaUzlqNm1hRjNVZ1JTVXU5SHdpd3R0SkJWUm1RK3N0aC9hWGFW?=
 =?utf-8?B?MUNNVnZEN1FZZkhKam4wTWRUWTdiT3dhL0YxTHU0QWpMdFY2NVRGaktWOENM?=
 =?utf-8?B?TTRQRGJBNlVOcnpvelFHL2puQjEwQjFxS3hCM0RLemMzS01idWNhNUNoeWxS?=
 =?utf-8?B?SzJiQXgxbkdZYktwVXNnM3lNalRLbDZFV25DSnpvTGx4eXdqZ3pnclJ1Z01m?=
 =?utf-8?B?b01YRVh1MS9zbWVyVGRiUXRNNGdqRWttR0Zib1RJenNBRWtNT1AwMHVxRDNX?=
 =?utf-8?B?c0R1OTlnQWlsYzRuKy9lT2ZMTXlTM0hGc0dJTkE5NEM4eW1zc0U4SE5udHFM?=
 =?utf-8?B?SU8yTkFrang4RzA1ZFJmU3I0M2NseCtGbEpRUzh4MHFpcE8rRFF1OTZmU0FL?=
 =?utf-8?B?VUZYaVE1ZTJyRjcxWXJlMTJ4dTlpYWYyQXhFMUx3dDdKbTIzRGowRWNXTWVO?=
 =?utf-8?B?M1lqYkk3dTZOTHd4WTNjY2lVaWFpeVBRbENwN04rTFJBakNtNzBkckg5ckg5?=
 =?utf-8?B?cUdzZktzUDBQWW1WYjZxaWxUNDB6akVzMUZyUzVCSGVLNEw3NE9CWXNLVk14?=
 =?utf-8?B?MlR6OW5hL3BOL1pvU1NDOUQrM1c1RGxmY0FwTHhGSXBpMUhCSS9rcXoyYUtL?=
 =?utf-8?B?YXRxUU5Xcnh1WXF0YW5yemRpZklIVFQ0ZGZPRXNZTnVxeUtGWTBiNWJucTBw?=
 =?utf-8?B?aUVvUHRaL2NOK2NpbjJjc0RKdzB4eE9HTWRMcHZXNFVjSGFLTlc5SVY0NzAr?=
 =?utf-8?B?WDJQUkVyYk5ZMzlPVVZCazllMHF2VkR5TTQzSEMweVJrVlJUQXVNVDZKT3Bx?=
 =?utf-8?B?YXQ1VGhWbStwWm53ZnF3WlZCeTJZVXVmQU14YndmMU9TOVczR1JaTjAzeVhF?=
 =?utf-8?B?TDA5em5vZFhvUUF2Uk1JQ0ZCc1JtZTVld3ROcUE3dEFaS1ZGTFAycXJteDFV?=
 =?utf-8?B?elhzU2I1ekZvK2dMSFM2VUVBQXJnWjlVbWdnOU1FSUFITWVrTlBHajhSYnFD?=
 =?utf-8?B?RFhKM1VkenJOKzF1NEkvaDRmT0huVTdFa1dRcDloL2lOVTVKMUdXMVhhZ0RX?=
 =?utf-8?B?UW5ldmdKTzNyeUlqWTZhRms5azl2OVBoRnFFWXdLZlVlMnNqV09BVmlCRGRJ?=
 =?utf-8?B?RW9tdVI1bHByV3c2M2RwSGRJUWZkMnIxTThIR3U2L1Jra1NFY0xSUXNWeFVJ?=
 =?utf-8?B?cUdNOW5PZnNVdGZtMVJnTy9tNXZNNnRoVDVZN0VYVnpMamRMc2dpeWxJTmFV?=
 =?utf-8?B?SzFrek1Qa1dpS1FkTXBkczJCN3VwY011NitpQS9LQmhQQ2VzVXdUV1FYUkZU?=
 =?utf-8?B?WEJaSHU1djFvcEo3RHh5SG12MU4vNU03UGpHREtOSnB3RFB4RjhYNmtoTTBV?=
 =?utf-8?B?b2w3Q0kybytraG5vU0xzRWovMHkrb0FJMmxsTVR0eHAyWGlvOGZIOUtWTjVj?=
 =?utf-8?B?alZ5dXZNWUN3SXhlUnI3a1pNN0hkMjdlRUNWMzBJVWxDRVpCQkxzVlRzOXRC?=
 =?utf-8?B?NEo5a2FIbThFUDZ5TjhLenhGZW1DblVaQ1R0QzkycksvbmRURVpnM3NMckps?=
 =?utf-8?B?dmxYdVg3dUdMZzN6VENhVWpNakxCY05URndnRmNTK3lYQVVpT1R5RmNXUVNj?=
 =?utf-8?B?SkozSURCMHkxSm04bVVEaXNvdFBROTVUL1kzaWJvR3hTUXNYdi9FZz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <342FD43ED91F3847B5F751C6392DF18F@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 633b124f-4fb3-45c4-3e5c-08d9e711bf3f
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Feb 2022 12:36:05.6458
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: yhB+c1KIALG6TezDqtL5H5tsymSUxmi4PxrL5O+PXxkZWQ5tLbDCWLg4SUsR8deGt2dJpKdiDPFyKbGi/BMEk9AVn3jmDJu6UT69co/fUWojhblDbz8jh63kL/deGSNW
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR03MB4453
X-Proofpoint-GUID: zTM6uJ4pH-AfPbJzZYBN1D0NIERqKVDy
X-Proofpoint-ORIG-GUID: zTM6uJ4pH-AfPbJzZYBN1D0NIERqKVDy
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-03_03,2022-02-03_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0
 spamscore=0 mlxscore=0 malwarescore=0 suspectscore=0 adultscore=0
 clxscore=1015 bulkscore=0 mlxlogscore=334 priorityscore=1501
 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202030078

SGksIEJlcnRyYW5kIQ0KDQpPbiAyNi4xMS4yMSAxNDoxOSwgT2xla3NhbmRyIEFuZHJ1c2hjaGVu
a28gd3JvdGU6DQo+IEhpLCBCZXJ0cmFuZCENCj4NCj4gT24gMjUuMTEuMjEgMTg6MjgsIEJlcnRy
YW5kIE1hcnF1aXMgd3JvdGU6DQo+PiBIaSBPbGVrc2FuZHIsDQo+Pg0KPj4+IE9uIDI1IE5vdiAy
MDIxLCBhdCAxMTowMiwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gPGFuZHIyMDAwQGdtYWlsLmNv
bT4gd3JvdGU6DQo+Pj4NCj4+PiBGcm9tOiBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyA8b2xla3Nh
bmRyX2FuZHJ1c2hjaGVua29AZXBhbS5jb20+DQo+Pj4NCj4+PiBBZGQgcmVsZXZhbnQgdnBjaSBy
ZWdpc3RlciBoYW5kbGVycyB3aGVuIGFzc2lnbmluZyBQQ0kgZGV2aWNlIHRvIGEgZG9tYWluDQo+
Pj4gYW5kIHJlbW92ZSB0aG9zZSB3aGVuIGRlLWFzc2lnbmluZy4gVGhpcyBhbGxvd3MgaGF2aW5n
IGRpZmZlcmVudA0KPj4+IGhhbmRsZXJzIGZvciBkaWZmZXJlbnQgZG9tYWlucywgZS5nLiBod2Rv
bSBhbmQgb3RoZXIgZ3Vlc3RzLg0KPj4+DQo+Pj4gRW11bGF0ZSBndWVzdCBCQVIgcmVnaXN0ZXIg
dmFsdWVzOiB0aGlzIGFsbG93cyBjcmVhdGluZyBhIGd1ZXN0IHZpZXcNCj4+PiBvZiB0aGUgcmVn
aXN0ZXJzIGFuZCBlbXVsYXRlcyBzaXplIGFuZCBwcm9wZXJ0aWVzIHByb2JlIGFzIGl0IGlzIGRv
bmUNCj4+PiBkdXJpbmcgUENJIGRldmljZSBlbnVtZXJhdGlvbiBieSB0aGUgZ3Vlc3QuDQo+Pj4N
Cj4+PiBST00gQkFSIGlzIG9ubHkgaGFuZGxlZCBmb3IgdGhlIGhhcmR3YXJlIGRvbWFpbiBhbmQg
Zm9yIGd1ZXN0IGRvbWFpbnMNCj4+PiB0aGVyZSBpcyBhIHN0dWI6IGF0IHRoZSBtb21lbnQgUENJ
IGV4cGFuc2lvbiBST00gaGFuZGxpbmcgaXMgc3VwcG9ydGVkDQo+Pj4gZm9yIHg4NiBvbmx5IGFu
ZCBpdCBtaWdodCBub3QgYmUgdXNlZCBieSBvdGhlciBhcmNoaXRlY3R1cmVzIHdpdGhvdXQNCj4+
PiBlbXVsYXRpbmcgeDg2LiBPdGhlciB1c2UtY2FzZXMgbWF5IGluY2x1ZGUgdXNpbmcgdGhhdCBl
eHBhbnNpb24gUk9NIGJlZm9yZQ0KPj4+IFhlbiBib290cywgaGVuY2Ugbm8gZW11bGF0aW9uIGlz
IG5lZWRlZCBpbiBYZW4gaXRzZWxmLiBPciB3aGVuIGEgZ3Vlc3QNCj4+PiB3YW50cyB0byB1c2Ug
dGhlIFJPTSBjb2RlIHdoaWNoIHNlZW1zIHRvIGJlIHJhcmUuDQo+PiBJbiB0aGUgZ2VuZXJpYyBj
b2RlLCBiYXJzIGZvciBpb3BvcnRzIGFyZSBhY3R1YWxseSBza2lwcGVkIChjaGVjayBjb2RlIGJl
Zm9yZQ0KPj4gaW4gaGVhZGVyLmMsIGluIGNhc2Ugb2YgaW9wb3J0cyB0aGVyZSBpcyBhIGNvbnRp
bnVlKSBhbmQgbm8gaGFuZGxlciBpcyByZWdpc3RlcmVkIGZvciB0aGVtLg0KPj4gVGhlIGNvbnNl
cXVlbmNlIHdpbGwgYmUgdGhhdCBhIGd1ZXN0IHdpbGwgYWNjZXNzIGhhcmR3YXJlIHdoZW4gcmVh
ZGluZyB0aG9zZSBCQVJzLg0KPiBZZXMsIHRoaXMgc2VlbXMgdG8gYmUgYSB2YWxpZCBwb2ludA0K
U28sIHdpdGggdGhlIGFwcHJvYWNoIHdlIGhhdmUgZGV2ZWxvcGVkIHRoZXNlIGRheXMgd2Ugd2ls
bCBpZ25vcmUgYWxsIHdyaXRlcw0KYW5kIHJldHVybiB+MCBmb3IgcmVhZHMgZm9yIGFsbCB1bmhh
bmRsZWQgb3BzLCBlLmcuIHRob3NlIHdoaWNoIGRvIG5vdCBoYXZlIGV4cGxpY2l0DQpyZWdpc3Rl
ciBoYW5kbGVycyBlbXBsb3llZC4gVGh1cywgdGhpcyBjYXNlIHdpbGwgZmFsbCBpbnRvIHVuaGFu
ZGxlZCBjbGF1c2UuDQoNClRoYW5rIHlvdSwNCk9sZWtzYW5kcg==


From xen-devel-bounces@lists.xenproject.org Thu Feb 03 12:44:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 03 Feb 2022 12:44:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264678.457859 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFbTZ-0006JX-Qe; Thu, 03 Feb 2022 12:44:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264678.457859; Thu, 03 Feb 2022 12:44:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFbTZ-0006JQ-Ml; Thu, 03 Feb 2022 12:44:37 +0000
Received: by outflank-mailman (input) for mailman id 264678;
 Thu, 03 Feb 2022 12:44:36 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=OTfZ=SS=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nFbTY-0006JK-Sl
 for xen-devel@lists.xenproject.org; Thu, 03 Feb 2022 12:44:36 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0a8da2f8-84ef-11ec-8eb8-a37418f5ba1a;
 Thu, 03 Feb 2022 13:44:35 +0100 (CET)
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2053.outbound.protection.outlook.com [104.47.2.53]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-10-RpzGfCAKO1GQ8aLm8WBtmQ-1; Thu, 03 Feb 2022 13:44:33 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3536.eurprd04.prod.outlook.com (2603:10a6:803:2::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Thu, 3 Feb
 2022 12:44:31 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.012; Thu, 3 Feb 2022
 12:44:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0a8da2f8-84ef-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1643892275;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=FiLxVk8iiEYG+at9BCceDO5cYQTAVRGZhU4E+w1O6uc=;
	b=JNvmOLq4oDza4cPWuiAknmS9+vWzO5DqibD0g+uUZ8jjQB0gKU0S1KYCRZfu2E5dTGxS7H
	vrLjRWgaqf4Am0GRBj47RXgz+39KwpMJKJ+1igWeeL8UHli3aY/EjmL+YT23dUJ/nPKUVy
	RFIq20QBhdw7Z8SSmxT2ZAFDlUfnAK4=
X-MC-Unique: RpzGfCAKO1GQ8aLm8WBtmQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=FQ6qdt6BQk0HSk9YtuKI/Goxptif6nFq1HWgl8shCEQIZMlWki6m6v6j0hffu7DYJl1yxSCdWc4XIx/xVRgdxzg95DQLA/nwA9K8qjbuo18IEbU0JYR3l6HEFK7RBfrNyevw7n7TMhDwsL3ZPjCcYITr3DUJp+hA7SE2REpSoJVxk+t2f50ax7zpVoKhgJsGrVpOe1DMSowK+a7nWFG56+4t++ypwVVjhcC5fo3gok+hWbop3mEED4eLr5psipXQUS+k8T43++GHbPOPBhIVfBSeb93xB7ZFqPgV76Fw74UbbWffprzwzNUPhdsOs4l/1sCmP4jdt72W36NnjXHChQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=FiLxVk8iiEYG+at9BCceDO5cYQTAVRGZhU4E+w1O6uc=;
 b=kPh0Ja+UEsaDc+Fky++DYBxBzpTo4UVN/ASTB9X4L12wq9aAXA2wMa/0WRe9F4nTp0XaONzNwlG7hDy7tYitddsKZx/muMiyQ4M738hJdwCmpZQ8VgiJFjFHR8Ar8jfKNxWzW6snkijwLD/jNjhEgH2RlDOnqFMk5oVOGR8FovITvm98Xgy7uLqqAxQQqZQLehfFW2MCEBJtuTKwXxVF7IwIrcBsg7fpu4NSQU4C3zc6NqIiOgNtA9I0mAoWKrOxp1WuQykf9d+xcTTUB7czvP9O0QdPWe61kySUHqYuQHOTD/0S5LlLBGsjFCAk/KDFHtnH4qrC0FyAItD3D152jw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <8ac4e23d-afcd-d965-fab0-b437baef8172@suse.com>
Date: Thu, 3 Feb 2022 13:44:28 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v5 06/14] vpci/header: implement guest BAR register
 handlers
Content-Language: en-US
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>, Julien Grall
 <julien@xen.org>, "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Artem Mygaiev <Artem_Mygaiev@epam.com>,
 "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
 "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
 "paul@xen.org" <paul@xen.org>, Rahul Singh <rahul.singh@arm.com>,
 "roger.pau@citrix.com" <roger.pau@citrix.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <20211125110251.2877218-1-andr2000@gmail.com>
 <20211125110251.2877218-7-andr2000@gmail.com>
 <34FC3FE6-EBA8-4A5C-A1F3-1E9F98C0337F@arm.com>
 <a6ee236b-5a00-8116-c744-6c94fcf46ae1@epam.com>
 <571d7660-c091-ac41-5e3c-441b4c5a1679@epam.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <571d7660-c091-ac41-5e3c-441b4c5a1679@epam.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR07CA0002.eurprd07.prod.outlook.com
 (2603:10a6:20b:46c::20) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e02dd501-1649-4c3c-6b73-08d9e712ecae
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3536:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB3536C940987DB984A35C46E8B3289@VI1PR0402MB3536.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	dEUp85BTXrfhz8J1Rtgr2+avtV7F6dAiqHbbThwSKt2BuKNr/CS4ffsQn4y6PTph7rYrko80dk+rlw7BkFuujtjtkKbOfWQ5nbUlfMXeZVlaFZnQ0YbhOzj3jz6t7aj6qyZU7+xtQOQst5btKQaS8XxkPVwaML1F5TyKUVKuXwj6YZR+8YoaCWgLiOI3d4brB+ox/mNsvf8jUmY63tkySAEGbwtP5ugTi7mJMTN0eRXtgEhBt/5GNC3aMienmla1osuEP9IzD5gxWLlzcb4DQM2adUPu6LG5vJ254zxIRH5StTsXaHpw6T36+gnDLawGSjIr+/QLqBauH684GVr5uz1P8FUUakNIBsFjB6N9a558e29Y6lfjRakTQiKqmi/FtT1xwTnJeEAn4BRpbZ0weHcdTlhYug0p95hU3bYrYyIJktcVSUz2tVZ7vM7HGq2rQxcKvwNSbGKtkC0C1qg2qXJtMUAwdhgsWS0sVfsdMZ6twiB8vBmp8MiYRaxC+RNQX63JzFe10SnGNOF2Y9jRVpU2bAmfVQyD7GDnahztuDRfRMeR3wzzzj54zbWjQGPY6irKw737VDfWkeKM0U7b0AnWeueaQlXvV37OmrtBgbcTYuGDC2/ZEE773h1T+D/S7pCbo+gZN3LYE6cG83VHrCBsPxaAyIuDoKnCg1LMIBa17u1Pw1qow9uyMvzBuitZomFiVTSgIWGN8t+uASKi7BUQv1uWhDhFLKbs7X8g0d9cl9YxZeQRjevkFeMz3uqJ
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6916009)(6486002)(5660300002)(38100700002)(508600001)(6506007)(54906003)(53546011)(6666004)(7416002)(31696002)(6512007)(8936002)(8676002)(4326008)(66476007)(66556008)(186003)(86362001)(83380400001)(2906002)(66946007)(31686004)(2616005)(36756003)(26005)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?YS9ORWFJK0hXOTJpYjJ0TzJQdXpYcU9PRUl5V1VUWW1nVjZqSXJWbnJQenpx?=
 =?utf-8?B?NWNDVEVwd3dzUytQbmp5ZFQ0ZUMxNUR4UzlrYTBwc0VESElvZEZnbENxZWNZ?=
 =?utf-8?B?eTl6dWZMWG9wT2tvVDVCa2VJbTRWaUNiNGJHRGV1Q0NGS2cwOVRRZlVnYXBL?=
 =?utf-8?B?NzE2RnFObVRSaUhQbnhGNXQ5Q21LRTcrL2hwYTQvNzZQSzEzU1lKbnZMZTQ3?=
 =?utf-8?B?UG45YmpmOHlMZlpYbFJsRWNZd3c3Q3AvenkyQzRyR2JXS0RvaFdTRlVNQmtM?=
 =?utf-8?B?UmtBQUhUVER0V29NZ0xqQzhJMGtDWUZMWGkvZWNYV1JUei9hb3pWT001RU16?=
 =?utf-8?B?bjFDTlVUcVhGbzhub1JNdUduWjdRNjlzMDVad09STjJ0eCtsTTVYWElzbFVq?=
 =?utf-8?B?Z3JMbTMwZnl6Z01qMEtodXZha0wzN3JzdXVWK2h5dUY1bEFJVVd5SWYvd3Qx?=
 =?utf-8?B?ZkRqYzY1K2VMUkJTSHhkRmRmenpsbC9jaUVPUEI5MFFPbkpTTG1uWG5hZ0h2?=
 =?utf-8?B?VDFSMitGYnh6WmRwcGxGQkM5VkpsMjRBRHV2bkowV3g5RVpHSnlYUE5zbXZs?=
 =?utf-8?B?NWk1aEo0bjBud2NpaFJaMkRKU3pCbnZoYU5HVm5wc1JvOHF6SWpjT2tUWHVM?=
 =?utf-8?B?YW95MGQ3VHNZazA2Znp5K3BpUzNudWFtVHYzT24vUVNkTGFxMFNLNGVIMnpG?=
 =?utf-8?B?eURIb2dwZXVMcHJEc0RIcFFjY1Y0WnZCdEIwQ085ZTlWWVNwR2l5eWVsSE12?=
 =?utf-8?B?OGlWSHhPV3ZtWFJrbDhLZHRpb0xXbmVwWGFvTnc1MUlhNUcvN2VTOGN3cWEr?=
 =?utf-8?B?MlpPbUtzUXh0ZVRaalg1MkRpUDU1MVdDR0tycGthNDRHeHRzQUlySWFQUUd0?=
 =?utf-8?B?YytxQnZoMzZzNVZFQkM0YmZQV2xCVTJlRFpVaTRPamdGTjYwOU9ZcUtJRC8v?=
 =?utf-8?B?STdqSUJNc2Mvb2JZOVBwaTF5bVlHVWpUSnJzZlp0RVhLMkI1NmNXMUxtd2hJ?=
 =?utf-8?B?MEpIVVM4cVVRb1FFSTE1Yi9oQSsrbVhvRmk2eTVCbkNmNEN6Z3VpNTFlUGpL?=
 =?utf-8?B?TTJ0OWVXTnkyT3A5RitLdnV3TndYSG56bW5wRU9YaVpsVThCZmsxTGYxanNB?=
 =?utf-8?B?OG95cndSMUx6MjJqeUxoOE0rU0tlNTBqaXE2Ti9aMlV5ek9CM2FVdDRjOGZW?=
 =?utf-8?B?bW5PdFpIMGswblVJM2h2aXh5emFPK0lJUyttWWZuRWlMYlBnRjNpVWJWcWNL?=
 =?utf-8?B?UXdUSVJ6QmVNcTdBc3lMejlIQWwva3N3WEFuVXhuNlNWL1psV24rUWNpRHF1?=
 =?utf-8?B?bzQ1K2hCMDllWStUYjZEZ0U4THpERjBMaHRhWDVlMzJnZmtKaTZVRG1tNkN4?=
 =?utf-8?B?bGNnaFVodlFuRU93UmxXNjR3ZGIxL2tSSjZZMHVhUHUzWnZHc1R6R0VzOWlD?=
 =?utf-8?B?bUpxSC9TUGpxejJ6VEJ3RUtybkFYK1M1Y2pGQjUyQzV1dlFzTEIxa0RPd3F5?=
 =?utf-8?B?WGt5WFhSZWUxUmo1QTJaUThjM0toRFJHd3NVVitxVnVidW12QTU0THRDVmh2?=
 =?utf-8?B?Y3UySDkyQ3ZiNENUb1lPR0dQN1JuK1c1eWMrREU2blVjdThCQXJrcW9mTU9G?=
 =?utf-8?B?dUdUcjZLMWU2UjYvTXV6a0dXN2tWejJZVFdOV1lYVXdvaEh5NWV5Y2hHYVpJ?=
 =?utf-8?B?WUlpUnhCN29QQVk4THorcU5BMEthRkdocm1nTHpXOUdBVk5Da3lab0psSlFT?=
 =?utf-8?B?VXNMOXVjVm81UWhFQ2xNdEplNXQ5TWR0SUx5SjFpZkxOd0swYW5TWkpWa1dS?=
 =?utf-8?B?cVRZcVpCVUwxUWhlOExtei85UXN1QXBuYkRzU1lHNnJBQUhuTHlXOTk0QmVv?=
 =?utf-8?B?TDJ2b2dkdnpRblFhOTRJMzRIT1Q4SVl0M0haWFBFanVHaFJmQXJYQUZDNFI2?=
 =?utf-8?B?bk1DeDVadytkVlEvTlVFaG1GMGI0cWZkbjBFYW5QYVBGMnlubUM1TW9xeTV1?=
 =?utf-8?B?dUtESXB6MllHY1NhbUtrdWpKT1JqZGJRbzg4VmVKZ0dJNnJ4YTZYelhTTmg4?=
 =?utf-8?B?S2MwQmFoTGErcWZWR2EzWTdLcTZRMHZCc25Ba0ZpbjNta0lDK29YbnFNbDFN?=
 =?utf-8?B?TUl5WVBxOGJYVVZ3UmlUNk5Ydk9RS0UrZHpvQ1pmcndhOVUway9wV1k2eURV?=
 =?utf-8?Q?SUPM0CcBdA4tXgLJ/VdTmlk=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e02dd501-1649-4c3c-6b73-08d9e712ecae
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Feb 2022 12:44:31.7635
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: edfKmz4+TK/oEUeN/Zr6Di+JsNEYQ7v2P/JDhF/f/dzDDLamsaTcKMvz6PSHAjddSx/KYq8yYzNXc+gp7YWAtw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3536

On 03.02.2022 13:36, Oleksandr Andrushchenko wrote:
> Hi, Bertrand!
> 
> On 26.11.21 14:19, Oleksandr Andrushchenko wrote:
>> Hi, Bertrand!
>>
>> On 25.11.21 18:28, Bertrand Marquis wrote:
>>> Hi Oleksandr,
>>>
>>>> On 25 Nov 2021, at 11:02, Oleksandr Andrushchenko <andr2000@gmail.com> wrote:
>>>>
>>>> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>>>>
>>>> Add relevant vpci register handlers when assigning PCI device to a domain
>>>> and remove those when de-assigning. This allows having different
>>>> handlers for different domains, e.g. hwdom and other guests.
>>>>
>>>> Emulate guest BAR register values: this allows creating a guest view
>>>> of the registers and emulates size and properties probe as it is done
>>>> during PCI device enumeration by the guest.
>>>>
>>>> ROM BAR is only handled for the hardware domain and for guest domains
>>>> there is a stub: at the moment PCI expansion ROM handling is supported
>>>> for x86 only and it might not be used by other architectures without
>>>> emulating x86. Other use-cases may include using that expansion ROM before
>>>> Xen boots, hence no emulation is needed in Xen itself. Or when a guest
>>>> wants to use the ROM code which seems to be rare.
>>> In the generic code, bars for ioports are actually skipped (check code before
>>> in header.c, in case of ioports there is a continue) and no handler is registered for them.
>>> The consequence will be that a guest will access hardware when reading those BARs.
>> Yes, this seems to be a valid point
> So, with the approach we have developed these days we will ignore all writes
> and return ~0 for reads for all unhandled ops, e.g. those which do not have explicit
> register handlers employed. Thus, this case will fall into unhandled clause.

Except that I guess BARs are special in that reads may not return ~0,
or else the low bits carry a meaning we don't want to convey. Unused
BARs need to be hard-wired to 0, I think.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Feb 03 12:45:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 03 Feb 2022 12:45:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264683.457870 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFbUE-0006uW-6F; Thu, 03 Feb 2022 12:45:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264683.457870; Thu, 03 Feb 2022 12:45:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFbUE-0006uP-3I; Thu, 03 Feb 2022 12:45:18 +0000
Received: by outflank-mailman (input) for mailman id 264683;
 Thu, 03 Feb 2022 12:45:16 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ArrP=SS=epam.com=prvs=403311c35b=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nFbUC-0006l6-KY
 for xen-devel@lists.xenproject.org; Thu, 03 Feb 2022 12:45:16 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 21d91b94-84ef-11ec-8f75-fffcc8bd4f1a;
 Thu, 03 Feb 2022 13:45:15 +0100 (CET)
Received: from pps.filterd (m0174676.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 213CX0T4008878;
 Thu, 3 Feb 2022 12:45:05 GMT
Received: from eur03-db5-obe.outbound.protection.outlook.com
 (mail-db5eur03lp2058.outbound.protection.outlook.com [104.47.10.58])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e0dhuge6x-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Thu, 03 Feb 2022 12:45:04 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by DB7PR03MB4827.eurprd03.prod.outlook.com (2603:10a6:10:75::20) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Thu, 3 Feb
 2022 12:45:01 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6%3]) with mapi id 15.20.4951.012; Thu, 3 Feb 2022
 12:45:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 21d91b94-84ef-11ec-8f75-fffcc8bd4f1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cthrr9zQG1Qf/B4RBfWDTSR95e872kSxX1PIn5i6HI7i3kynXI8Mwhx28hBfTVuorZncbBd9SwMU1jLTMbR9xj4cMxrncdqtLwLZr7+64ogtSbndDwQRx0uRxpb3iJgzZklke2W0Y5s8Np/H1+3qY7TQmNB5PnZnPHpBrvAevnc/hh9Rx1bSFuHdO3GSAcYx07YuSCRQJSU2g6fPt3CqRgjljAIl22/jbcMuzpF+zb1WpASnPLoIISgK5CDzLtBbrhG2C7bfkjImysBYRnev0QVw9IifJOwi4tYljbGBaSoXCvF7xJxjPg4JtoZxH6ikbhguaWIynV1DKxd8znp3LQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=YzD327I/5O8F3nb1JPeYO8Iyf3svDbljUweJy4ygqMU=;
 b=dBpiu5vZLq16gEzp/urPcxgoctYfcw3Wv47VrZr1xUV8ZVJy0fMalzmYCFf3wAViDhCIkMHHhrMf6SRAqmYFCzEUvNlgyZ30rIIH9jCkZCcitoMyS2BpbAKGtc1KK5zIY90tQA+jE4QWvFIT35xnbVRpHzzn46gxJhMO3C3/ImIBfzeaPS4Jbs/C2nyaQ8xN01fB9Ug2kmpcI6bTVwRqnUWhvoyvwVeT+WwOdKjNAgtutfhE/9qPgWVlHe+31A6ttIWxpWUxBIBy6SCK4zm/5LyjgGVgcrT+dyIuFl/TEOAE1ERVEyuUzYwwMnD728Jqi6tJu65Lc7KUn5pnMpoCDA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=YzD327I/5O8F3nb1JPeYO8Iyf3svDbljUweJy4ygqMU=;
 b=aXdsZG5zVXPr1fLq5McClAvUE3YaVz7ZvWAMmoxU0YouEOUCPVmhBl5FwhwhGS+fQqgdH80x36vj5Un3bpQ3v8VzpjJcBOvZYAdAiRuCa43Z27y35myLv2Jf+VezQfnpFYpMDYE7L0/5qCUaC9I3BOLtLiICLZxdUjrUWN2VtW4l6Y7LKDEOjqL1NoCf50Dg9784XZ5SLU+rB1bROxDJtvKYGAeZ7qwXtGqBXqJIU0h3/BUUSc9AiWGJlJAM8bC+H6mvk4Dl8TT4xZmAnPLi75PqJlmqU7AoFqdP1jfyhQnAAnGKB29yRIqMBl/fjXKUQ3urkHhfvEj3vvPXVwAIDQ==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "jbeulich@suse.com" <jbeulich@suse.com>,
        "andrew.cooper3@citrix.com"
	<andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com"
	<george.dunlap@citrix.com>,
        "paul@xen.org" <paul@xen.org>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>,
        Rahul Singh <rahul.singh@arm.com>,
        Oleksandr
 Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v5 06/14] vpci/header: implement guest BAR register
 handlers
Thread-Topic: [PATCH v5 06/14] vpci/header: implement guest BAR register
 handlers
Thread-Index: AQHX4ewHyWAyD811HEGp8pIjUuVWNaxf8XWAgB1bfoCABObrAA==
Date: Thu, 3 Feb 2022 12:45:00 +0000
Message-ID: <df98cdbd-36fe-0386-c068-2a1540f10188@epam.com>
References: <20211125110251.2877218-1-andr2000@gmail.com>
 <20211125110251.2877218-7-andr2000@gmail.com> <Yd8RJfpEalnfl+CC@Air-de-Roger>
 <d493b022-3c78-1721-e668-48f4553056a9@epam.com>
In-Reply-To: <d493b022-3c78-1721-e668-48f4553056a9@epam.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: ee8c57cf-bde2-42d2-3e88-08d9e712fe37
x-ms-traffictypediagnostic: DB7PR03MB4827:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <DB7PR03MB4827DA59BC13FDBC1A2E968AE7289@DB7PR03MB4827.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 iSclE5MVbOwv32ungxQKPLI6H+0svCPHoYeyMeDCxhI5MRpVKD8J3x7exryOPZebTrX1igWdY702WrV5BGx42sUauJZpTaan2Q1kOqT4xwNIy0ieHyEPTYkgxpF0ei34rE12BgLfuuNJ4tbyFo3vthnkt8H55vmSpyWz1POtaZQ+S+d6uXz1qw07g9VITiPuaPE84cxkdqTIv/BiOH7R7tWzo6pXONh4NAr+07dyg11yRlBpxjnTsaGLNn6bgmOrigQX8ge5IW0lHJHe6hlfkZO40+65fIOntYzaH6Bx+3MwDByy8TQcynk39337fTcZqCvy3h9JjYkQDlkVWnLubKKbkEG7uZq2ZGWHDQE91w3o0bzBuwMzBqVIMYatK4H3m/dFrVnWCNH0qMYypZZZPSYfY2pePC0S25yViwKoLBrEG8OrQh4DQQlMp1V3tPH4i7JlYUvU4ow6kIvrGx2l4dBchuUOt2d+X4cpo1t+MlxVLIRLHa8ueiUSqrYl5VfUWfo9pYy/+kxTNypswba9ffLpBq1VJ6Cc6ShXG8Zx27swN4BRCtMWCRlhSZIuvk93NQEvAQ+e/J6A9S4VsR+h30btKF8xKfGwNaee2/RNQXOLot1MNBPUg3w4b7d7jH2/yvXHimShwz+JNs0VBQ/Cl6uzrZ3bwmF89uXivZGPGn7HtW5qPA9H8OaqFx77k/V6XZMY481Emmr2ZpbSbOd/8cr6U/KLXBQNQlO5TjaaOh3bm1LjXM1QrJHO5wg2z5xY
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(83380400001)(54906003)(6916009)(2906002)(36756003)(122000001)(8676002)(6512007)(8936002)(38100700002)(66946007)(71200400001)(64756008)(66446008)(86362001)(4326008)(66556008)(31696002)(76116006)(91956017)(508600001)(66476007)(4744005)(107886003)(6486002)(31686004)(7416002)(5660300002)(186003)(316002)(26005)(6506007)(2616005)(38070700005)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?NW5ITDM3YjVabVlwSmhVVXc3RjM1RnlSVFVyckI4TzBoZlNpOHEyd1ZxZkFy?=
 =?utf-8?B?NlhWK2h6aFZkcmc0andHZVNwbGxHRXFnR2ozVTJYbTFXaHdPZ3ZFTzhyTzRG?=
 =?utf-8?B?eFAyTlBoYkNrVTA0b29NZytQL2d0b0RpdXNpSlNueTQ3TGp0Wk5weEJ6WUJW?=
 =?utf-8?B?c1JLSXllWUNERW5IRTBTMUl6MDFHMHFpUGlkS2JRZUhta1QyYnlzUWZ0OXpQ?=
 =?utf-8?B?R2JOWG5sd0grQTlyLzZoc2tIOEFKS3JRcmFqOWZTQmVSQVB0bSs3RFFyMGhD?=
 =?utf-8?B?OW5xYW5TMDJCREd1N1R3NjhXU0tpZVhLQmJ4WHJMSkNkR2hqbk5NWFFtbXI0?=
 =?utf-8?B?VS9sbHgxazVUS1ZmZ1g2VStacFVESitBNjFsRDdHZjVhVHlOeGx6QkNaU0RB?=
 =?utf-8?B?NjlIeE1jQ3owLzhSL0RQSTE0bEd4d0dweU5rTWFOR1F3b0d6RUlhZHovYUpF?=
 =?utf-8?B?eUFKdVRrcVdCaktlUDZ4VkF3bnJSQzQrclZCdzYybU13TXhKNTYrU1F3Yll6?=
 =?utf-8?B?eFB3ZWxsUHA4azVSK3I1RkpLY3hpZnFwRDBsWDBFb296UjVYQ2V6a0kySXJz?=
 =?utf-8?B?V1c0OGhPRzQrSzFLeXp6TWxWelBJUjhTT0pqeUlPMXZMRlh0TjQ2eWh3TWk5?=
 =?utf-8?B?SUtpWE5BeFNGRDRZcjMxT0V0OWUwMk5jVUZEdVozVlY3VFV2cTBMdU9YWVF3?=
 =?utf-8?B?cWRMditldnQ3VmFEMXRkeENtNlJMZ2UweUNBaW10TkZ6UFdvTVcyWFVNNFUw?=
 =?utf-8?B?cVE1U0J2YUcrRERWRmNJM2dHWmhqaFZ3TUx6NWhlTHFZdlV4bFdjNjRxeHpC?=
 =?utf-8?B?Wit4Z2hKbWJMZWQxNXB6YlNCVVFQY2JhY2FCQWtnUmw4dk5FUHNwZVY5bkJY?=
 =?utf-8?B?bWRTbVFLUjVuc3p0QUtMOW1BY2lsSUZSS29UZE9xQk1PTDBQdVhTOVFSTVE4?=
 =?utf-8?B?bFJjdVF1U3oyNTZmYnYrTENMcFBPQW5aZHA4MzJ2ZkY0cStuQmgzbm1iQkN0?=
 =?utf-8?B?N1JJQTFxTitGNis1SVBCa29VaUJ3YkFCU0tHeC9TR3VOM3E2MU4xT1Q4Ulpu?=
 =?utf-8?B?QlRObVY5bDlHaFRldFgvMkZMT2F3dFJzNllLV0dKUmFZMEZxWnZBQjE0QTdX?=
 =?utf-8?B?Z0x3QldtTStqOGdTaHNRSmZkem04SDY0U3N3YUE5cVVUa1dWN21yTVlza2xT?=
 =?utf-8?B?RUdhczRLTE81cW5GbXFzaElsdkxqN3crVXdMTldBRytDZjFhREk1NStKZFpI?=
 =?utf-8?B?ODEwSDR3M2JHdFhvYWo2WmRuWnp0bU0xSU9OMjNaWFRjbzJSR3JqMjNjOXRV?=
 =?utf-8?B?M3NadDdQV2I2bStKSm10MnY1THJRVGN5ZUhMQXpRU3lFVTBWcko2enJkSUhB?=
 =?utf-8?B?bGFndk96RWV3UEk4VUxrRWtPSGFZVFlpdVQ5KzJoTDFnRTVxWlI2bmFaR2pU?=
 =?utf-8?B?SEdxbVY1NG9JaFg3YnNzSW9HemJOY29QZUZHVExYT0VmdFJRbFBWclFlZDc3?=
 =?utf-8?B?M3NrUnpSaVVDeGQ4WUdqN2pnL2FrZDE1RitEKzNPWHV2M25NOHpHWmd5dnNH?=
 =?utf-8?B?NURiOTJ2T1pVQlFwdS9TRVRJc3V1Q1dRUnNuYURSaVpIblFsZTFWanpPa1BR?=
 =?utf-8?B?Q2VMUTNzZ1I5RVhZSXRFOC9xQVg1UUFvWHplQ21KR1BvTUtnNVB4cTVKblQx?=
 =?utf-8?B?M29seDFOMnB2a3JKOWV1cGJvZmszZmxnK3NkRXRjdmV2UkR4R1EvRTBZdGw4?=
 =?utf-8?B?TGhTbEtnbTlLaHh1YnZ2dUVTbDZSbVJyUCt6MUQ2cWJHRVU4SWlPb2w1Z00r?=
 =?utf-8?B?anJRZkdIcXFhaWZmSlJLQjc0QngxZ3VjZXBXdGE4MnBkdmlKaWRTOFcraTBz?=
 =?utf-8?B?MDhmcTV0bUlOeDk2QVAyUDltbnZ2VkZKcWdLTXRPL0lWMHRVOGhGcDVrdEUr?=
 =?utf-8?B?N3dpbGZZekVZZS96T2E3dElaWjJscjhaOUlsdkhBc0FpK1kzWTd3T3BNdkZv?=
 =?utf-8?B?YVpMN2czZzBkeVUvbzZ1VWV6NkluSGJMUzYrKzVyb1NIczJ4WlFiZkVlZ0Iy?=
 =?utf-8?B?RVhyWjhZWVZ4RGZCUjJteW5hSVVjOEFicW1aSTYwTDBPM1FSbHQxOVF4ZFg3?=
 =?utf-8?B?Y3p3OFBUWkdCUU1GYnlwdDFYeFR6cHdjanJDU1VOMERKeVc3R2pqTG5lYVND?=
 =?utf-8?B?Qm1XWHh5c25SVFYxS2J1YS94Sm1ORGNNRHBMTUFycGxCT2gvcXpaelZuRmNT?=
 =?utf-8?B?RDJ5dm9ZTUlrVWc3YkxNYm1oRjJlQlVXcVdnYXBXVzBWTDIwVUJRY1VIV0Mv?=
 =?utf-8?B?amJjQUV5N1hQTGw3Y3g1L1NFTmtaQkNUOW8zMFpsWVpjczNlMFJUZz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <1A3F69A1F0D3C141A8E3905BD4F0FD4B@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ee8c57cf-bde2-42d2-3e88-08d9e712fe37
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Feb 2022 12:45:00.8846
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: LttdC/Ossk8vQ0VxEiPRc7jYLUR1iNFAiQOxEiKqhBzJ+VAgfOybuDba/jD7um3HFqQy6vjR3fwxYR0keclJeDudb2bC8hu/TES/JXZkp2uSUBzAaYyN7L17rKkWq8xF
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR03MB4827
X-Proofpoint-GUID: DwtCkC3jzbpd5i4f-la-Le-iTNVO4-K2
X-Proofpoint-ORIG-GUID: DwtCkC3jzbpd5i4f-la-Le-iTNVO4-K2
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-03_03,2022-02-03_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0
 lowpriorityscore=0 impostorscore=0 clxscore=1015 bulkscore=0
 priorityscore=1501 mlxlogscore=914 mlxscore=0 phishscore=0 spamscore=0
 malwarescore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2201110000 definitions=main-2202030079

SGksIFJvZ2VyIQ0KPj4gQWxzbyBtZW1vcnkgZGVjb2RpbmcgbmVlZHMgdG8gYmUgaW5pdGlhbGx5
IGRpc2FibGVkIHdoZW4gdXNlZCBieQ0KPj4gZ3Vlc3RzLCBpbiBvcmRlciB0byBwcmV2ZW50IHRo
ZSBCQVIgYmVpbmcgcGxhY2VkIG9uIHRvcCBvZiBhIFJBTQ0KPj4gcmVnaW9uLiBUaGUgZ3Vlc3Qg
cGh5c21hcCB3aWxsIGJlIGRpZmZlcmVudCBmcm9tIHRoZSBob3N0IG9uZSwgc28gaXQncw0KPj4g
cG9zc2libGUgZm9yIEJBUnMgdG8gZW5kIHVwIHBsYWNlZCBvbiB0b3Agb2YgUkFNIHJlZ2lvbnMg
aW5pdGlhbGx5DQo+PiB1bnRpbCB0aGUgZmlybXdhcmUgb3IgT1MgcGxhY2VzIHRoZW0gYXQgYSBz
dWl0YWJsZSBhZGRyZXNzLg0KPiBBZ3JlZSwgbWVtb3J5IGRlY29kaW5nIG11c3QgYmUgZGlzYWJs
ZWQNCklzbid0IGl0IGFscmVhZHkgYWNoaWV2ZWQgYnkgdGhlIHRvb2xzdGFjayByZXNldHRpbmcg
dGhlIFBDSSBkZXZpY2UNCndoaWxlIGFzc2lnbmluZ8KgIGl0IHRvIGEgZ3Vlc3Q/DQoNClRoYW5r
IHlvdSwNCk9sZWtzYW5kcg==


From xen-devel-bounces@lists.xenproject.org Thu Feb 03 12:49:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 03 Feb 2022 12:49:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264693.457880 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFbXu-0007d5-Ns; Thu, 03 Feb 2022 12:49:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264693.457880; Thu, 03 Feb 2022 12:49:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFbXu-0007cy-Kb; Thu, 03 Feb 2022 12:49:06 +0000
Received: by outflank-mailman (input) for mailman id 264693;
 Thu, 03 Feb 2022 12:49:05 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ArrP=SS=epam.com=prvs=403311c35b=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nFbXt-0007cs-Jp
 for xen-devel@lists.xenproject.org; Thu, 03 Feb 2022 12:49:05 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id aa87b4f4-84ef-11ec-8f75-fffcc8bd4f1a;
 Thu, 03 Feb 2022 13:49:04 +0100 (CET)
Received: from pps.filterd (m0174683.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 213CcdcP015031;
 Thu, 3 Feb 2022 12:49:00 GMT
Received: from eur05-vi1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2173.outbound.protection.outlook.com [104.47.17.173])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3e0f7v0127-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Thu, 03 Feb 2022 12:48:59 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM9PR03MB7591.eurprd03.prod.outlook.com (2603:10a6:20b:41a::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Thu, 3 Feb
 2022 12:48:56 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6%3]) with mapi id 15.20.4951.012; Thu, 3 Feb 2022
 12:48:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: aa87b4f4-84ef-11ec-8f75-fffcc8bd4f1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=lAjXGd+bXzn2Qs4RxPA39mM9AczXk4fBLBCCFzDGRLSQhAkWSdYJ00f0zdDR8YgGot+3S37jPbSJrvSAzOyTZOcLvsiLZ2sp/bMvZJt4puhBNn1g9IAq/EPKV9OH7bxd7/+kQpQMaifPV4tFeOt5EsxLiWnczEDA7tk5gS8ffRaMmPL2O6Ps/Tkpoa1vo3dMiIHNuyXkdGlrX03Y2x4F1WqwNTmodeNLgunOy8RtIWGJITkV+rhWQL6ss8mIb1dMhTVucGpt7j0NJtSlFn+rZmVAg3VP8QAFAIY6DIch69MBzSppW9SZUeOVzXfbo/Pc/M6BBrlIYyJnc0FMKIrKNQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=0mkvfkhkUEtBIkeEMGL9DIm0b6r7kWg1A5PuG0YtxrQ=;
 b=Ny44nBjcFC8V1bwtKTwFOcsyp83LJoEZ8ytO03ix2Gby26+Wlf4r98dw1WNKwsIpUwkQ9hhKfUx9hhcxeMhNwLOvwY3q8RTMsG2K/0okM/0BLyfLhqmEuRMdzujid+wsMgGDQfrY+S6UB/NMSuagX8GA+ornruGkiAtIEYxN6ON0D/xhleaACOmdPKBH4udk8zuq/FR54s4mG13JvgV/UGhq2v/9EfckYmAuj4tAjzwZ4/epjUwscYzs9rxaOk9xBibhDUv3cestta97GP2WM4nykCnkN0L5CMuCDUC+7qr5rUoxpZe+7bhQm9W/w8Y2fKJfZCp1/2g+YrU5OYNu0w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=0mkvfkhkUEtBIkeEMGL9DIm0b6r7kWg1A5PuG0YtxrQ=;
 b=ZmLqoujrpxnHPDuvi4kou1eOi+1/CAnboOHgCUAm3OxhmPVxsYdJIkcSboS4+3IIdCXsxngWaZpeYfxtlmbmaPY6ASfV88aqpCkRK0HSBOJ/ovI0gr0+fnenwYrSr8DU/JlMBpTFsyW4zftsqGH6TxpToeRp+DUmJGk6qdCBfhpaE0rEGmb8RQROQodFhjjsT5DlgncwqlRc1akjSffswg2fnCl7AnaM9JEl+e9efNNAsJeGACukViqe4pKCP4LiOnJLFT/6sbfEhx6I29bdaSVdLyACr6sh5/vzz26Al7OKdmMSTkjTW36uinz6QFH6HKd4SJjt5Qg8qdgpcOGoYg==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Julien Grall <julien@xen.org>,
        "sstabellini@kernel.org" <sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>, Rahul Singh <rahul.singh@arm.com>,
        "roger.pau@citrix.com"
	<roger.pau@citrix.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v5 06/14] vpci/header: implement guest BAR register
 handlers
Thread-Topic: [PATCH v5 06/14] vpci/header: implement guest BAR register
 handlers
Thread-Index: AQHX4ewHyWAyD811HEGp8pIjUuVWNawUby8AgAFMuICAbHV4AIAAAlkAgAABPoA=
Date: Thu, 3 Feb 2022 12:48:55 +0000
Message-ID: <c9e7b16f-db9e-e86b-a5b1-ca87d5fb6609@epam.com>
References: <20211125110251.2877218-1-andr2000@gmail.com>
 <20211125110251.2877218-7-andr2000@gmail.com>
 <34FC3FE6-EBA8-4A5C-A1F3-1E9F98C0337F@arm.com>
 <a6ee236b-5a00-8116-c744-6c94fcf46ae1@epam.com>
 <571d7660-c091-ac41-5e3c-441b4c5a1679@epam.com>
 <8ac4e23d-afcd-d965-fab0-b437baef8172@suse.com>
In-Reply-To: <8ac4e23d-afcd-d965-fab0-b437baef8172@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: deee9969-18f9-44dc-20d6-08d9e7138a47
x-ms-traffictypediagnostic: AM9PR03MB7591:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM9PR03MB7591DD5A3BC9CB1E88780BAEE7289@AM9PR03MB7591.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 MbpEV4J8pu5DWew/PpTyV3l1bPsyQ1GNdMA3uK5jLt7EDhALhWleR1/1bLp5cD9MR74EwLEankZjPMo1ZoJU+bmsF3Sptdh9lxCFz+sg2JZWzX8HeOmsOOWuhLchmsQpuaMwrr8mTZ/Nj+xWLI9zsEnvLIX91+bZzPPu39Jd7SVJ+nYvJ5wkHKlXU+aEul6r+EpZmyR7DvBj8qZiYcY/O+DYJGrTPM8OHXKtFFGkzgR4oKJOg6b0n+Qnv9TwhPINdviaq3oiUWk2xb0sHAGvFgrYgtLZOHLQkxT3IYd+wWY6G/2iUejfNG+xtZBQc1YNT6buCNexGLIwFBTsSN1wSX4wBrwUQaeYyfNgosHPpre1I9DsRosCk3LDLSPtbX7H5H6CCsh4DMgkmcJYDsaF78YYXMuaf/Emx8Rt0SUlHS+CnkvlqbID9AOPoqfbHMN9qFgGRr70fyRTzCx9suXGsOaYDgY70JN3nSD4gIf00bpHzBDCTyN1+j7iEov+siSTeo/58Uv3lov78BF26o3hJu0Bx/MW7KaFh7FqBH0c85NsBqc7Mzj+Uw8dXddW0fzaYm723fDyF/+0R8dWWPBBQ3IlboJBeAgaOf8GsRd8BlNB//To3nR1F4FrGlt9uHkKABf4vqMb6/em1oFzBFW9Gejt1fWuIUq0rSO5/XPQ6OVVu4xJ6vo9ZFHRJHP7E80xrGnQZOu05xK7JmKEApd2MubPdvAIamZCU+oihpeMW8I/YSzojdE/+7Xk+env2O3/
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66556008)(66476007)(91956017)(76116006)(5660300002)(64756008)(38070700005)(66946007)(122000001)(8936002)(66446008)(31696002)(2906002)(7416002)(86362001)(8676002)(4326008)(107886003)(31686004)(2616005)(26005)(71200400001)(53546011)(6916009)(83380400001)(186003)(508600001)(316002)(6512007)(6506007)(54906003)(38100700002)(36756003)(6486002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?UVRDRDBVLzc0U0pWVUtFL3VOYUFqT3diVFZjdlQ2a2tJb3lNTThacjBMMUUz?=
 =?utf-8?B?V0cxZkZjMnJHMlRxWnViYkFpcEwvZlpqcFMzaGVQOWFqWmxZdGR5SjBuRnVY?=
 =?utf-8?B?djNXWS9WeFJ5WUFIS0taa1pJWkdCZytlK0t1MERQNUxZc0dWZUtTd2RQK1Ny?=
 =?utf-8?B?VTIwWWVaN1dSSXVzN3NkQ2NJaU1RRDk5U21JdnRUTU1qWkF5bEFzdnZ6cjZH?=
 =?utf-8?B?NHFjdzNieHBZcjk2c21xT1VpOU4vays4VDB6cEZhcXR4WWY4dGRmTEZpWmJN?=
 =?utf-8?B?OGlmRDNaWmttc1FZRUkyMHhuemlkbDhocWRVY3huU29sdEVJeEM0UWRpK2U4?=
 =?utf-8?B?U2swdkU4RzhNS0p3YVlZMTdpVDZDMTUrWDJoZFZSWEhibjBIZ3VaVWxLZXJU?=
 =?utf-8?B?ekp2RjlpNnVqMlhHU0tqQ0w0RVErMUhWeXFVNXJoR2JFblBobmR3WWxUMU9v?=
 =?utf-8?B?bTRUUTVINWU3RFVoM0oyTXZXSUwwZHlTbkYrZkVUdUdWbmwzbC82TjhMWXdT?=
 =?utf-8?B?eWYwNmw5WHYvSFhMUk4xMnlhUUt5YVNaeHIwTGZkdVlVMFhVbUJmRzNxd0t2?=
 =?utf-8?B?WUkydHJnanpmODNTUEkrOHg2UWZNYVdXSTBVY1h5WldXczVzOGpJZDRXM0xo?=
 =?utf-8?B?STZWMUUrOHhhK05yK09XWUdBVXRoN0lQWWhCb2VqL2diZER5VHVwRk1aMWhm?=
 =?utf-8?B?L2RvT2NRVXp5YjZyMzl0aXNvL3Uyei9ZR1haSkZld09rVkFDVm9MU3ZPc2Qw?=
 =?utf-8?B?VCtCa2lNd3d6ZGJWRGNTR05ZekdhTVVlQ0Vkdkxka2xZSzdJU0VoV2JaZSs5?=
 =?utf-8?B?N3NwSUduR2E1bWJRL0Y4R1hiMk1iNnBjTjI0Z1drL1M2OFYybmROM1Y3TGc5?=
 =?utf-8?B?SEh0MHBnRzZ2eHhGSU9oa1hETTZ1aWh0OWkrdStvdWFiZFZiY2tjQ2JTcWFL?=
 =?utf-8?B?eFBncnZwOTRoMUhXMWlaYW1rdWtEclA5UzR3aFhTOGdiMzV2YVJSelFpeFBr?=
 =?utf-8?B?dVkzblBZM0RLRjJsczJLU1c1WHJGTFo5czQ3K1ByWUZKblZjbFRXRnhIVFkz?=
 =?utf-8?B?OWVTUmhJM09JM0VNTGM1ZkJYbzRLSlNSbnNUVUNCTUJ3b2QxcGlIbWoxbVk3?=
 =?utf-8?B?RXNDbUw1UUFLMHlNUzg0WjZZcXZJZXhvK2pZa05RU3dpQ041Z0hGd081d2Ru?=
 =?utf-8?B?dDBrTWlRcmdBakVIL1RlaUROOW5DVEZGYlYwVzVtK3dqMHRvU2kva24rZjFW?=
 =?utf-8?B?ZzIzYVdqZkpYZ2g2aFN5aXhscUlydnBpMXpsNC8rUXJxcmI3MVErRDAyVmth?=
 =?utf-8?B?UmxoblpIR21MMmVGMUlnaW9zOGo4R1l5TkdoRFltTHBnZHdoaksxblpReDcw?=
 =?utf-8?B?dkxDZ203L2FVaFc0bUxVQjNrTys3QS9hS04zdGFpeGV2ZHRkaDhGY0VEUFFu?=
 =?utf-8?B?Y0VHZG5RVjV3em5NZnIzRXpYOXh1aGp1eHFBNmRIcnB0c2RaSWJVN3dLM0RC?=
 =?utf-8?B?RjhPOHZybVBkR3dIaTllbkVXemVseGZrNEtwei9zalhDU3BnUzdta0tFTzc3?=
 =?utf-8?B?YUFIbHhmQUc2VUZZWGozMWZmWHB1K1Y1cGw4bnhHTm5VbjRjd3BEVUtoMlVt?=
 =?utf-8?B?OERHTVdLcS9ka1ZKa0N0N1R0WkVVRFB4YTdLOXN6M0JUb3NJUCtjdSt2QmR5?=
 =?utf-8?B?WnV2L3I5SFIyTzBDc0pkUmJOZXozb2NvWUc3MGk3YitKbVlHM0VBWjUzSmNu?=
 =?utf-8?B?emJyOE1WNitMekJsdnVWU05haHRxVE5IdmZxZnM5cjJ2NzVucmRXMjlYM1lo?=
 =?utf-8?B?NlplbE5tN2Y3Q3ExSmtzTTZFbXQzNHBjZk04ME5zVzFIa0V0VlBpV0tEcHZO?=
 =?utf-8?B?TndKcHZEQm9razFrbnRmZnZmeGZJUlAzNGI4QWxMM0ZMSTFPeVo3am5TRWov?=
 =?utf-8?B?cjFLWFd4cmhuZ3pqMm5sOGQ5dGRxRkZFMlU5SFJScUxoR0JIUjFiVmdFVmZI?=
 =?utf-8?B?OFhINGZxbWNneDMrc1FmcUVBa1NQV0ZYUzB1ck1OTjVjRDRxYVBIeVQ2bVdG?=
 =?utf-8?B?bHNuVnRWMXg0Y2IwNk5KT21FSWdaeWdRUXJaK2Fjd3lTU1BrSk9FdHU0enVr?=
 =?utf-8?B?aVV4TG5qVElGT1hnam5wMnY3QmlZUnpvbXgrTjZBUm8vRkdpWi81YnlydlNY?=
 =?utf-8?B?WWlsdVpNZVZlWERBN0N3cE94dGJKcUdzb3VqVlVSeVFuam1nZ0Y3M3lRZ0Vr?=
 =?utf-8?B?bUhuaGdSeUJpK2NsMjMxQ2tEc2FhcnZFUnpUcjVXblh4NnFQK010dDhSc3Vt?=
 =?utf-8?B?ZjFJQzZiMDRHTkVYSE9pTFk3dTZDMy94dTQ2emoraWR1K0NkS25jQT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <9BCA9F942797A14FBF2EB01F1F63F964@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: deee9969-18f9-44dc-20d6-08d9e7138a47
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Feb 2022 12:48:55.8854
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: xAaAlV1hNnwqFuUnAtnFvtVf37xQnv1GvutZpJYjwItAosqi7MgDfSv+IJNdXeQ4IAlnqaVeBcl7fkdgHUBuvXbGGxaotFMKN3VWs8zUSkSTUIRgmv8e3wx8TwmlYPuE
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR03MB7591
X-Proofpoint-GUID: S5BhkL1HiM9_VWRJze03sGhhZSMJ_WNY
X-Proofpoint-ORIG-GUID: S5BhkL1HiM9_VWRJze03sGhhZSMJ_WNY
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-03_03,2022-02-03_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=3 lowpriorityscore=0
 suspectscore=0 priorityscore=1501 clxscore=1015 impostorscore=0
 phishscore=0 adultscore=0 bulkscore=0 mlxlogscore=154 mlxscore=3
 malwarescore=0 spamscore=3 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202030080

SGksIEphbiENCg0KT24gMDMuMDIuMjIgMTQ6NDQsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAw
My4wMi4yMDIyIDEzOjM2LCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyB3cm90ZToNCj4+IEhpLCBC
ZXJ0cmFuZCENCj4+DQo+PiBPbiAyNi4xMS4yMSAxNDoxOSwgT2xla3NhbmRyIEFuZHJ1c2hjaGVu
a28gd3JvdGU6DQo+Pj4gSGksIEJlcnRyYW5kIQ0KPj4+DQo+Pj4gT24gMjUuMTEuMjEgMTg6Mjgs
IEJlcnRyYW5kIE1hcnF1aXMgd3JvdGU6DQo+Pj4+IEhpIE9sZWtzYW5kciwNCj4+Pj4NCj4+Pj4+
IE9uIDI1IE5vdiAyMDIxLCBhdCAxMTowMiwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gPGFuZHIy
MDAwQGdtYWlsLmNvbT4gd3JvdGU6DQo+Pj4+Pg0KPj4+Pj4gRnJvbTogT2xla3NhbmRyIEFuZHJ1
c2hjaGVua28gPG9sZWtzYW5kcl9hbmRydXNoY2hlbmtvQGVwYW0uY29tPg0KPj4+Pj4NCj4+Pj4+
IEFkZCByZWxldmFudCB2cGNpIHJlZ2lzdGVyIGhhbmRsZXJzIHdoZW4gYXNzaWduaW5nIFBDSSBk
ZXZpY2UgdG8gYSBkb21haW4NCj4+Pj4+IGFuZCByZW1vdmUgdGhvc2Ugd2hlbiBkZS1hc3NpZ25p
bmcuIFRoaXMgYWxsb3dzIGhhdmluZyBkaWZmZXJlbnQNCj4+Pj4+IGhhbmRsZXJzIGZvciBkaWZm
ZXJlbnQgZG9tYWlucywgZS5nLiBod2RvbSBhbmQgb3RoZXIgZ3Vlc3RzLg0KPj4+Pj4NCj4+Pj4+
IEVtdWxhdGUgZ3Vlc3QgQkFSIHJlZ2lzdGVyIHZhbHVlczogdGhpcyBhbGxvd3MgY3JlYXRpbmcg
YSBndWVzdCB2aWV3DQo+Pj4+PiBvZiB0aGUgcmVnaXN0ZXJzIGFuZCBlbXVsYXRlcyBzaXplIGFu
ZCBwcm9wZXJ0aWVzIHByb2JlIGFzIGl0IGlzIGRvbmUNCj4+Pj4+IGR1cmluZyBQQ0kgZGV2aWNl
IGVudW1lcmF0aW9uIGJ5IHRoZSBndWVzdC4NCj4+Pj4+DQo+Pj4+PiBST00gQkFSIGlzIG9ubHkg
aGFuZGxlZCBmb3IgdGhlIGhhcmR3YXJlIGRvbWFpbiBhbmQgZm9yIGd1ZXN0IGRvbWFpbnMNCj4+
Pj4+IHRoZXJlIGlzIGEgc3R1YjogYXQgdGhlIG1vbWVudCBQQ0kgZXhwYW5zaW9uIFJPTSBoYW5k
bGluZyBpcyBzdXBwb3J0ZWQNCj4+Pj4+IGZvciB4ODYgb25seSBhbmQgaXQgbWlnaHQgbm90IGJl
IHVzZWQgYnkgb3RoZXIgYXJjaGl0ZWN0dXJlcyB3aXRob3V0DQo+Pj4+PiBlbXVsYXRpbmcgeDg2
LiBPdGhlciB1c2UtY2FzZXMgbWF5IGluY2x1ZGUgdXNpbmcgdGhhdCBleHBhbnNpb24gUk9NIGJl
Zm9yZQ0KPj4+Pj4gWGVuIGJvb3RzLCBoZW5jZSBubyBlbXVsYXRpb24gaXMgbmVlZGVkIGluIFhl
biBpdHNlbGYuIE9yIHdoZW4gYSBndWVzdA0KPj4+Pj4gd2FudHMgdG8gdXNlIHRoZSBST00gY29k
ZSB3aGljaCBzZWVtcyB0byBiZSByYXJlLg0KPj4+PiBJbiB0aGUgZ2VuZXJpYyBjb2RlLCBiYXJz
IGZvciBpb3BvcnRzIGFyZSBhY3R1YWxseSBza2lwcGVkIChjaGVjayBjb2RlIGJlZm9yZQ0KPj4+
PiBpbiBoZWFkZXIuYywgaW4gY2FzZSBvZiBpb3BvcnRzIHRoZXJlIGlzIGEgY29udGludWUpIGFu
ZCBubyBoYW5kbGVyIGlzIHJlZ2lzdGVyZWQgZm9yIHRoZW0uDQo+Pj4+IFRoZSBjb25zZXF1ZW5j
ZSB3aWxsIGJlIHRoYXQgYSBndWVzdCB3aWxsIGFjY2VzcyBoYXJkd2FyZSB3aGVuIHJlYWRpbmcg
dGhvc2UgQkFScy4NCj4+PiBZZXMsIHRoaXMgc2VlbXMgdG8gYmUgYSB2YWxpZCBwb2ludA0KPj4g
U28sIHdpdGggdGhlIGFwcHJvYWNoIHdlIGhhdmUgZGV2ZWxvcGVkIHRoZXNlIGRheXMgd2Ugd2ls
bCBpZ25vcmUgYWxsIHdyaXRlcw0KPj4gYW5kIHJldHVybiB+MCBmb3IgcmVhZHMgZm9yIGFsbCB1
bmhhbmRsZWQgb3BzLCBlLmcuIHRob3NlIHdoaWNoIGRvIG5vdCBoYXZlIGV4cGxpY2l0DQo+PiBy
ZWdpc3RlciBoYW5kbGVycyBlbXBsb3llZC4gVGh1cywgdGhpcyBjYXNlIHdpbGwgZmFsbCBpbnRv
IHVuaGFuZGxlZCBjbGF1c2UuDQo+IEV4Y2VwdCB0aGF0IEkgZ3Vlc3MgQkFScyBhcmUgc3BlY2lh
bCBpbiB0aGF0IHJlYWRzIG1heSBub3QgcmV0dXJuIH4wLA0KPiBvciBlbHNlIHRoZSBsb3cgYml0
cyBjYXJyeSBhIG1lYW5pbmcgd2UgZG9uJ3Qgd2FudCB0byBjb252ZXkuIFVudXNlZA0KPiBCQVJz
IG5lZWQgdG8gYmUgaGFyZC13aXJlZCB0byAwLCBJIHRoaW5rLg0KU28sIHlvdSBtZWFuIHdlIHNo
b3VsZCBoYXZlIDIgc2V0cyBvZiBCQVIgaGFuZGxlcnMgZm9yIGd1ZXN0czoNCjEuIG5vcm1hbCBl
bXVsYXRpb24gKHRoZXNlIGFyZSBpbXBsZW1lbnRlZCBpbiB0aGlzIHBhdGNoKQ0KMi4gYWxsIG90
aGVyIEJBUnM6IHJlYWQgMC9pZ25vcmUgd3JpdGUgZm9yIGFsbCBvdGhlciBCQVJzLCBpbmNsdWRp
bmcgUk9NLCBJTyBldGMuDQoNCklzIHRoaXMgd2hhdCB5b3UgbWVhbj8NCj4gSmFuDQo+DQpUaGFu
ayB5b3UsDQpPbGVrc2FuZHI=


From xen-devel-bounces@lists.xenproject.org Thu Feb 03 12:51:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 03 Feb 2022 12:51:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264699.457892 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFbZh-0000WN-3i; Thu, 03 Feb 2022 12:50:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264699.457892; Thu, 03 Feb 2022 12:50:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFbZg-0000WG-Vz; Thu, 03 Feb 2022 12:50:56 +0000
Received: by outflank-mailman (input) for mailman id 264699;
 Thu, 03 Feb 2022 12:50:55 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=OTfZ=SS=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nFbZf-0000W8-Ll
 for xen-devel@lists.xenproject.org; Thu, 03 Feb 2022 12:50:55 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ec9276c5-84ef-11ec-8f75-fffcc8bd4f1a;
 Thu, 03 Feb 2022 13:50:54 +0100 (CET)
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2057.outbound.protection.outlook.com [104.47.8.57]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-6-eTOkWibcPsWMyzq2aHpBRA-2; Thu, 03 Feb 2022 13:50:53 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DB7PR04MB4860.eurprd04.prod.outlook.com (2603:10a6:10:14::17) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Thu, 3 Feb
 2022 12:50:51 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.012; Thu, 3 Feb 2022
 12:50:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ec9276c5-84ef-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1643892654;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=9fJYLOu+SSapEu4PHaPUc4xhfvLCAo0tqu4/AKsrBAE=;
	b=mzhN0/kdJj+7Rg6/QATsTaEkXn85DQMxdN5xcNZ2Qlljm/dl8znOekM9MsHL134DQDKQkA
	mNUUEU31vO7os4rBsKzkW0uqFeY/3kQSiBrz6VIqoTM2avWG0pXoHdX48HGk3CXKmHOBdT
	VdOi9phh4ZecURVooV1miKgdUW+b/WY=
X-MC-Unique: eTOkWibcPsWMyzq2aHpBRA-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cs4Clw9uLH9qLlHP0M9a5dQL62Gv7z+4SWuRaGz8hFKdHaj/rw4tlA38Zio3zjkB3J3RPHoYKhYAF79GBgoBfxJpXYYiFUj7+x91tpgBv3TK1oqCW1IC/V1GDngqxajRVWzix1bIcfkPd8QR54Fq1qqOc6MTETHmFysod2dANn4+vI3QT7cEJCA+prt17RzYnG9qWNKs3x0q3GEfybLmVxXpm6C07ISMPg4Ps4Znf+w8ihuKMt4SSmHLM5Kru8Q6W01mkfceqbIHjHgTkGfKUpZe3IZLwF/t6WWH2Kv/22d/vCYDxyrXxZBwtzHrLoX8Rh2bCm0HPP+mABeXSvT1Lg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=9fJYLOu+SSapEu4PHaPUc4xhfvLCAo0tqu4/AKsrBAE=;
 b=im4bV4/4lf/GQTvvfHGV2+8bco7TWpjWEMFG0k+t85NjEkTSSGLk0hf2QAE7qgZr4qHMvXLmIGgYhTUOdLtCH2wM6ijorSjLyJrtEaQXyjzfn023lW1Jh0wQzsM2D+zSiA5cIEthk6XPIYab2Zzrex8rZu5qdQcRn0FIIWjN/aSx8E/08G3UkceneRFGydRme0+wd8WltjYmMxXwWvs7mCe/CatUfVdq+jS+HcLcPrCu9egi3Hx2XO7AbwkwkcTB+AeKjhX1p1rkS0AoCSuUy7Z46/TqgwoQhVnh5Hvwa6G2qwp1HmDGOPyL3UZijM4rLTLXzSiIJkVy9yQUHbgi5A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <4dd945c0-c600-4515-6f99-a75d06cf84de@suse.com>
Date: Thu, 3 Feb 2022 13:50:48 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v5 06/14] vpci/header: implement guest BAR register
 handlers
Content-Language: en-US
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>, Julien Grall
 <julien@xen.org>, "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Artem Mygaiev <Artem_Mygaiev@epam.com>,
 "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
 "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
 "paul@xen.org" <paul@xen.org>, Rahul Singh <rahul.singh@arm.com>,
 "roger.pau@citrix.com" <roger.pau@citrix.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <20211125110251.2877218-1-andr2000@gmail.com>
 <20211125110251.2877218-7-andr2000@gmail.com>
 <34FC3FE6-EBA8-4A5C-A1F3-1E9F98C0337F@arm.com>
 <a6ee236b-5a00-8116-c744-6c94fcf46ae1@epam.com>
 <571d7660-c091-ac41-5e3c-441b4c5a1679@epam.com>
 <8ac4e23d-afcd-d965-fab0-b437baef8172@suse.com>
 <c9e7b16f-db9e-e86b-a5b1-ca87d5fb6609@epam.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <c9e7b16f-db9e-e86b-a5b1-ca87d5fb6609@epam.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0030.eurprd06.prod.outlook.com
 (2603:10a6:20b:462::35) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 28065e1e-03b6-49ab-f283-08d9e713cebe
X-MS-TrafficTypeDiagnostic: DB7PR04MB4860:EE_
X-Microsoft-Antispam-PRVS:
	<DB7PR04MB48603C5D116947AA2A6B3DC5B3289@DB7PR04MB4860.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	HDl6xkprwM3WPrZ29+00uAggc5sSUdiig5acn/yqXxTr5DEDJ8nd/jf5a6iVMO0Zp/JcD1bhNl12RzsTJp44brVz2UxmK33WMlsfmyWbzygsMQwScHWQLmosG1jfIyIaTh20dCy4fL2VJEf+o7fSdxhaYWIeeEJKTDcj5fuWOTVLLjltL2gWXlJ8DSyulR1yJhgMw9h86gFfPlLDOdtjbZxqCkXt1HYSj2uLU1WG/4OfM/laWkPqmMQhu9r0K+aGRCg+yi2UHTlZ05BElbn0pEhKPeBjkvuZV3OkEWm3WN9jqqXyKgHz00vzJjwiOC1Z2++MFL7yWYkDAeGX/VZew9EEXnTudLLLbSmfwfbW5C4jjbxez8SBgEFR0RUD5akYsR0exxBC+rUoj+fdBmw0qstgXJ3raYIj6SkBd5Z3Bgsv591LzpugD3q8zZklYO57Ys8rLyoMYxw6U9V87TbnOFboaEtw5/S60VYTLGX+0B5v8lZxOdDCiMPuZ/vvXJ0BVenXGzlGZbg6M1J9k6/Lw7QqIE6qgdTiKEmu7uCsH7PiVFluNXyjJCoGfcPIwX3tcw9wutqpD9cunYU3+TtrgFOhx1IYwVQCN06SGKY6IqKCXQ7P7XkQIBrWUvE9yohthTmaQXuRCpxI/ImsGWsRcR6J/lkEOgNA0qtGDdFDfh7sJ6v6+DUL2xRgqpSOnZbuMVW1clZ3oqcHW9jhtvOtbsu18CC9ls1/vy7yHgLJybBUDFr3gWheTMPR0xaJU95w
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(83380400001)(5660300002)(26005)(186003)(31686004)(7416002)(2906002)(36756003)(508600001)(86362001)(6486002)(8936002)(8676002)(6916009)(54906003)(66556008)(66476007)(66946007)(2616005)(38100700002)(316002)(31696002)(53546011)(6666004)(4326008)(6506007)(6512007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bzNCQStzNXkxNmxoNHF5SStkN2pxUU9wZmpKdUZMS2R3UHV3WEV4SDRKQUI3?=
 =?utf-8?B?RWVOTDQzQXBaN1grSHpxS0tmNzZwT05hb1A1UXlHZWo5Zk1vT0pwM2l2S0kr?=
 =?utf-8?B?bUJEa243ZS9wYXJvVGhWRlBiL2dkVStqUHRPczVLcWJrTEt1QVd0dkpwQ3I4?=
 =?utf-8?B?RHBEM0o3djR2RE9iTzFiR3BKb1hFWitPaTNKT0FFeXhGbnRSbmw2L1VONFps?=
 =?utf-8?B?bUZYcDNGZnhIZmJEV2VWYjJlMUFuM1Q0KzIwdkt5dkM5WGlFN3cxMldQV2x4?=
 =?utf-8?B?Z3pEcC9KdnBYa0NqaVR3eE9LK3U3Vzhob0pQQlBWVHZVS3VVRFhrSDZyLzJN?=
 =?utf-8?B?MFJRc1lkWnZTQ1g3UjNoQWY3aURuUlMxZVROR05ZY2ZUMHFhVlpTblJpbmNL?=
 =?utf-8?B?RE4xdlFmV25BQlpiOWYwNlkwOHMvbUdsS04vRGM3SDNGcTZvU3RSTDRoNlhQ?=
 =?utf-8?B?bThnU3ArdENOeVUvV3RUUEJud0RDdUsvWTFCMWZvRFVnVVJFQ080UXY0L1gv?=
 =?utf-8?B?Z0d1Ym9xRDdqa1Znek55VTE0dWhlZW5GazF5NXZCaG1KSUFsaUlMUkhJOE91?=
 =?utf-8?B?S0k4aHg1aWVBeUN3SlRFdExYRWU2cTBXQytxWGpFVGRLUDg0aEdOTnJ5Y21W?=
 =?utf-8?B?Ri8wMUlsWVcxaTI2bUxEdVN4TVkrRmpvWThPQkx3UXVmdjdQRXA1TktSc2xk?=
 =?utf-8?B?WmZuK1M5UjNmYi9lNVJ5SFFOYVVKQVhncVlFWXdhOUFYZWZoellpNUN3MTdh?=
 =?utf-8?B?NlNXZ3R6K1IwTm53czYxRFlFaHZaRE1TMm16Qmh0SXpNNHhUOTNuMDlhWkhn?=
 =?utf-8?B?LzdaY0xHNktxNXRSZ0s0N0txOXRhZU1xME1rSzNoQmtKTzZqL3JRcDRVSjlx?=
 =?utf-8?B?eFF0V1RDL3RzWTVKM3hJajJsaWYrN09Bcnh4ZmEwSklnUG82Nm91bDVHSHBy?=
 =?utf-8?B?TjYreFp5WElBZXhaZDhsK0hmR1ZXcytaNU9za3FxRDl2ZjZzZjN1MkZqZkVo?=
 =?utf-8?B?OUcyVWZ2VU1WZldpWGUyYXB4Y3UxQVRnMHRTeGpDVmNCbjJ3OVRJZGY3MXhz?=
 =?utf-8?B?bWpYWVhMdWtoalFMWnYyMDlLVzBVMFFtcVcvM09USkxKYmNxaGJsZERDUEZx?=
 =?utf-8?B?b3J2K2pkYTRFQlo1YUhhaUR5ZHI0Q0xqTEtkMDhhMDZ6eXh2aUFHU3lFUzB4?=
 =?utf-8?B?NnpybUV0ZEtkK21SVXgwVjI5cGhRc1FzZFpCdmdJVlBYQ2RCS0YvRTgyQ1ds?=
 =?utf-8?B?QXl5czlZUHVuT3pHVGl5eGFhY0FMY2pITjdRRGFqTithb0lNYlNGVFdPYjR2?=
 =?utf-8?B?ZHJudWN4ak1hMUxvcXYvUVU3VXhHUTZ4N1krVXMxaDB0Z3g5eWw2QUVaOGsx?=
 =?utf-8?B?ZUc1RUwzQ25tNVZ2Q0pjMlJvcXByNzlXTktieWI2Ulg0eXBlSnRTV2NXNktH?=
 =?utf-8?B?LzhNK1hMSFV4K2ViUTRKVWNVRXVPaFBYQnBFSHRqR2hqREJFeStFd2xDK0RD?=
 =?utf-8?B?MHZKejBOTy92bkk5ZnZYTlMxenJScDhoMCtQQ0xlZ0hZZTZBcjhqVnVZNlhw?=
 =?utf-8?B?L0p6YURmeldoNE1NQ2p1M3pyUnBUbmZWYTN5d2c2Wi9XOEVHWTViQWdyUE02?=
 =?utf-8?B?M1hCbXA3a0lsN0U4NHBlK3NCN0JsNUlDNGV6eUtNTGhUaEVRbjZ2NTVtZHIy?=
 =?utf-8?B?bjRnSUQ0V1RCa3VYM1hFWklsWUdmOWVEbVlEazRuVEJQbmpyNW9hY1c3V2RK?=
 =?utf-8?B?RW52MU40d0wxWnNVV09uSzRhL0VIRmt6YWJ6d3NSTXc2T3UzRFJWakp6NWM0?=
 =?utf-8?B?QWNxc2d2RnZxcmxSUDBQd0xnWmRyeUdvamRHdlloTE5WU1dVbVRJQjczOXU2?=
 =?utf-8?B?M1YrcHVJZlJoMnVrYnFGbVBYV3F3SDdCQURWdlZtUnlVaFhIaTNZRDYwOG1j?=
 =?utf-8?B?NGxMSVAzUXRzN25kQ21tNEVOK3Y0TEIxekd6MXRwK0NLTFg4YlpEcWN1T0tF?=
 =?utf-8?B?Rm9kdFFYYzVxRU0xYzBMNDZVclVENWs2VnlPN3hNOEhOT1RVdEJrRnVyOEY2?=
 =?utf-8?B?Y0pzTCs5Z0VPczVOS24wNkl3TnBrdlFsTXlOdmtYaHJrNlRjOTBZZHgyL0lF?=
 =?utf-8?B?MDdzWm9za0xkYmFremYrWU5PYVBNM0ZVS2dCMjdFNll2cVd1ditDZStEVjVD?=
 =?utf-8?Q?ZBqhHBR+Y3eE1mP/TqBvijY=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 28065e1e-03b6-49ab-f283-08d9e713cebe
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Feb 2022 12:50:50.9901
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: D9vYuVSuQjCk9f1E70zB/3Weui2Su5tG7PBGjawNYqPCzO+lNppm8YhnbMg37zTv9le7ve8MB5J4Q82JqTzkrA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4860

On 03.02.2022 13:48, Oleksandr Andrushchenko wrote:
> Hi, Jan!
> 
> On 03.02.22 14:44, Jan Beulich wrote:
>> On 03.02.2022 13:36, Oleksandr Andrushchenko wrote:
>>> Hi, Bertrand!
>>>
>>> On 26.11.21 14:19, Oleksandr Andrushchenko wrote:
>>>> Hi, Bertrand!
>>>>
>>>> On 25.11.21 18:28, Bertrand Marquis wrote:
>>>>> Hi Oleksandr,
>>>>>
>>>>>> On 25 Nov 2021, at 11:02, Oleksandr Andrushchenko <andr2000@gmail.com> wrote:
>>>>>>
>>>>>> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>>>>>>
>>>>>> Add relevant vpci register handlers when assigning PCI device to a domain
>>>>>> and remove those when de-assigning. This allows having different
>>>>>> handlers for different domains, e.g. hwdom and other guests.
>>>>>>
>>>>>> Emulate guest BAR register values: this allows creating a guest view
>>>>>> of the registers and emulates size and properties probe as it is done
>>>>>> during PCI device enumeration by the guest.
>>>>>>
>>>>>> ROM BAR is only handled for the hardware domain and for guest domains
>>>>>> there is a stub: at the moment PCI expansion ROM handling is supported
>>>>>> for x86 only and it might not be used by other architectures without
>>>>>> emulating x86. Other use-cases may include using that expansion ROM before
>>>>>> Xen boots, hence no emulation is needed in Xen itself. Or when a guest
>>>>>> wants to use the ROM code which seems to be rare.
>>>>> In the generic code, bars for ioports are actually skipped (check code before
>>>>> in header.c, in case of ioports there is a continue) and no handler is registered for them.
>>>>> The consequence will be that a guest will access hardware when reading those BARs.
>>>> Yes, this seems to be a valid point
>>> So, with the approach we have developed these days we will ignore all writes
>>> and return ~0 for reads for all unhandled ops, e.g. those which do not have explicit
>>> register handlers employed. Thus, this case will fall into unhandled clause.
>> Except that I guess BARs are special in that reads may not return ~0,
>> or else the low bits carry a meaning we don't want to convey. Unused
>> BARs need to be hard-wired to 0, I think.
> So, you mean we should have 2 sets of BAR handlers for guests:
> 1. normal emulation (these are implemented in this patch)
> 2. all other BARs: read 0/ignore write for all other BARs, including ROM, IO etc.
> 
> Is this what you mean?

I think that's what we're going to need, yes.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Feb 03 12:53:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 03 Feb 2022 12:53:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264706.457902 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFbbw-0001D1-Ka; Thu, 03 Feb 2022 12:53:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264706.457902; Thu, 03 Feb 2022 12:53:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFbbw-0001Cu-HZ; Thu, 03 Feb 2022 12:53:16 +0000
Received: by outflank-mailman (input) for mailman id 264706;
 Thu, 03 Feb 2022 12:53:16 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ArrP=SS=epam.com=prvs=403311c35b=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nFbbv-0001Co-Ul
 for xen-devel@lists.xenproject.org; Thu, 03 Feb 2022 12:53:16 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3fa2fa3a-84f0-11ec-8f75-fffcc8bd4f1a;
 Thu, 03 Feb 2022 13:53:14 +0100 (CET)
Received: from pps.filterd (m0174679.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 213C309a032236;
 Thu, 3 Feb 2022 12:53:05 GMT
Received: from eur05-am6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2108.outbound.protection.outlook.com [104.47.18.108])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e0en1r6n2-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Thu, 03 Feb 2022 12:53:05 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by DB7PR03MB4859.eurprd03.prod.outlook.com (2603:10a6:10:33::20) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Thu, 3 Feb
 2022 12:53:01 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6%3]) with mapi id 15.20.4951.012; Thu, 3 Feb 2022
 12:53:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3fa2fa3a-84f0-11ec-8f75-fffcc8bd4f1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=T9wo4jsIHgkUnvnafn7SXMZ6wNxLsWsr74BxMcuOmN6Nb+MIK8km+D86yG+SCSN1y2rrgAlFADcjVt8XAUzlJs4uFvqdjdaQAXX6HrEYW0Y7hBKGpDjpEaO1+6OMvrJFKpexHvFGnv49Drsu1YbwGTITuqHqlSdSp6tjMqKo8mrmMuuqG7Fa/Dytc+NnHRs0bvUZEGW+bNq7UbI6KDEtAFjYRO6FE0oCvy6+KWF1ExT+caOnZ4JnsQM2Rb71v05E3siJRReSlyJy1sqfAFeNLBaw9Bq1JbzrjV5fsKpQljII9XgElX9UEPP1diVkj5F5K/eWVUcUYNzf+2CWYyANLg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=j37AQMrZ1ji+fHX7ArPqQEKUN5XNyvAMDiKP235kHTg=;
 b=hdCZCIVtKfVWGJK2vy8hStAoOta2uXPwry3s3yw2GGYUpHE4z8QNWv+OS3iiutpj+dgPKRCpDuGZsLaOJaWHdWbHd3b4IJe/DcrdaVSEjos0bKb3kpqvLD4nC1QzBCPkmXDxNxQgjD18EkMtz8O9eViXsDEC50WYT9wgK9Gm3kNr97alGOwYCFTOBP9DTSb7WsPXKYX8pg6GSdOn0bY4fO25ECtwQHVuyhjbj+cuzO8v3O6eSaRbWgS0oLVVANgotV16xbrU1nOPG8WUhtkTBvacl3j98jmLY2O3e8hSz3JGX7myx1kh6OAgcu8J1QVNXcL/Dbt/wfv3LOEPjvG08A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=j37AQMrZ1ji+fHX7ArPqQEKUN5XNyvAMDiKP235kHTg=;
 b=FzgjXxnA9SiFF4pHYggrSck3I+pZcsq/w/A5noFUmG/a+gHOSVEmnLqptRG3/UmbBPfdeYS077GvL1H032q0zi5uOo/v3DZWrBIoGa9VWgWyHhrA+4fmQgbKJNsvBqp4CBUpiuGf0nERFRSRhUzi6jDRi/4ZJ7UqVWyxvJbrhXNky9HU8imtYG6fO13ApvdYGphLue7qzfaOUIsHtvaqaaTsQAsNVRErZFg5Qu5pmoBN3E4DTxaCejjLdxOSCQgK1XjpfQ73RAm0GmPWm95MELiJvzVx4T1WEJS7NIRbuM704makYIVyrkk2WopoRP3Pmk11vkra2SNCywMZ6qgUfA==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Julien Grall <julien@xen.org>,
        "sstabellini@kernel.org" <sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>, Rahul Singh <rahul.singh@arm.com>,
        "roger.pau@citrix.com"
	<roger.pau@citrix.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v5 06/14] vpci/header: implement guest BAR register
 handlers
Thread-Topic: [PATCH v5 06/14] vpci/header: implement guest BAR register
 handlers
Thread-Index: 
 AQHX4ewHyWAyD811HEGp8pIjUuVWNawUby8AgAFMuICAbHV4AIAAAlkAgAABPoCAAACHAIAAAJ0A
Date: Thu, 3 Feb 2022 12:53:01 +0000
Message-ID: <d155682d-7beb-86e7-4685-1b7207108c07@epam.com>
References: <20211125110251.2877218-1-andr2000@gmail.com>
 <20211125110251.2877218-7-andr2000@gmail.com>
 <34FC3FE6-EBA8-4A5C-A1F3-1E9F98C0337F@arm.com>
 <a6ee236b-5a00-8116-c744-6c94fcf46ae1@epam.com>
 <571d7660-c091-ac41-5e3c-441b4c5a1679@epam.com>
 <8ac4e23d-afcd-d965-fab0-b437baef8172@suse.com>
 <c9e7b16f-db9e-e86b-a5b1-ca87d5fb6609@epam.com>
 <4dd945c0-c600-4515-6f99-a75d06cf84de@suse.com>
In-Reply-To: <4dd945c0-c600-4515-6f99-a75d06cf84de@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 1548d582-fd85-4993-8dea-08d9e7141cbc
x-ms-traffictypediagnostic: DB7PR03MB4859:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <DB7PR03MB4859F8323ECAB8AF41863151E7289@DB7PR03MB4859.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 IQbFF+s3fybMj+F84/VyuE6hT6IKUzmzchf/e6iyNZCJEx/1yUup7UANoxaM5mABlyEHwBkvjJEds5BxJPvGZwsX3xEK71XCTFmn/e50zi+HgsUoDIzIwe9eCQ/Cu5jXJw4otlflS675bxbILHwJBfJwuURjs0GLO2q+IN//Vj6gfclcG/iY7cEXZ12Fx7KGNQy/9PRMgzMSey++3tvIRifj4IDH7ZSbgMKCgrbGVETzGkQO2OQQ0lsVKrrRZnFvXCBELKlL1LdD5pRCGwqQuIn2Rrt8VZDXsfijeLCwYhCEoerUX86JEfN8U3PFgCkE2r4L+WqQiKojXjzMbo8WhC3z//gpgCM78f5o8vjIwgiZtLYl4GKMYVtkOj8opRJGZ+WS3g5rxV1cDScy5TRgUtTEUBDmfpmPN0t2Z2UDsz8RU2bS7QVklGJ8BWeqck46FVVykdp1i8VoA8T4p/U0sWB2Mp01K3eNlFMal2iNGry35gdUyzXgw160I8N7bDMjoBg6a26ZWvTBBADzvDTGrpMZTeRMKnHVLvUr/sseCgzu5y8i+RznQ07ylpmIw+JQm4hbqsyG5ekB5+QNp2whh7RoRGgnJ3GxVHHtPzSWFAvyRM+OWsnDN8TRilygDYyQXM9MR7iUvY7Zc5+UbnxhckAviaQevzMfzfoC2rRBHbWuvrbLjgBnIPKnIkhy/m0QkkI+jf+/zj+8TEF3M42BjjwSX27YFAwBICYwmAwyfp3zUfhA9C9z/y1241vzAhky
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(5660300002)(7416002)(66476007)(31686004)(64756008)(2906002)(66946007)(66556008)(36756003)(4326008)(8676002)(8936002)(66446008)(122000001)(91956017)(38100700002)(6916009)(316002)(54906003)(76116006)(26005)(83380400001)(508600001)(6486002)(6506007)(31696002)(53546011)(2616005)(107886003)(38070700005)(6512007)(71200400001)(86362001)(186003)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?VHNHYVNkcGwzbC9ZS1hTemZiTkFFNHdwWm1RY2ZMcEQ0RDkybHB5OWdaQkto?=
 =?utf-8?B?ODVkV2pOaG42U3AyVGUyQ0FNS1lBTUlTRUZNdVAzYzVNbTkvV1FEd2hDYlgy?=
 =?utf-8?B?UkRxK1RuZmFPZ0s2dmpFbnpDakdSQkhGZmxjSFRJdk1uNHdFVW4yeSsrTVh2?=
 =?utf-8?B?VE1LS2c0a0piS2lMbmNzTUlIM2hpaXAvbFJscXVLbzJtTDd5M3RGQVhqaTdS?=
 =?utf-8?B?ZFdrMVpBb2dHaWhCU0xoTU4vQkdXRXJtL2tTbnM2SXNBdnd6QWZ0bU5QNXRy?=
 =?utf-8?B?S2ttT08rZWVwYU1EdVhTSWpuWVk3ODdueGlmRWRtZlRmNDFUVG5sTEJLMEd1?=
 =?utf-8?B?UGtIZWZFTFdZRmhiUndQeGFHbXVuMWQ1cmpIRVpPcjdjdlh5Q1llZXc1blpY?=
 =?utf-8?B?UWphWHRaWm1YS3lCWU5uVzFsZkcrdUNLUFJxOFR1b0V0NS92N2NudDltY08r?=
 =?utf-8?B?WGtMVTVsSldGYmRoampQNGx6UHcveldqeE15azVzWVBxNlJtNU1yWUxQWXRt?=
 =?utf-8?B?R0pHeWRVWGREek1CMi83MFl4RXBBcjQ5cjBIVDA4VDlOSzNGZ2NLOVRZVkxE?=
 =?utf-8?B?QWEwVGN1bUV4S0RCckV5UnhZVEdQNHNaSWliZ0FYWTNLaktnb0JubXZiY3FY?=
 =?utf-8?B?OGhsQ2tFOENzZ2dvejI5TzJjdUNkTDMra2hkUDJNWWRuU2l5Q1VwTys0Qm1Y?=
 =?utf-8?B?N3dieGZaU0h0N2RUeldoTzJQL3JWaG1UcEhaZU8wWng0YTR3Tld6cFE5MjBH?=
 =?utf-8?B?dWhXL041WlhEcDBlR3J6Uml6ME9jdUpYS29hbUQ4MDFLYVQrUFlhTU9GNGZv?=
 =?utf-8?B?aGgxaU9NcTZrNVk2K202cDRzVWoyQ1dJNHh1czZCRXFZUjVkOEZUa3hGRXdP?=
 =?utf-8?B?ZU9NZ3lvMjVtMHZkZzZuVDRhSHlJaFV4U042a3JQUDVleWpZWXRFbDEwOE8x?=
 =?utf-8?B?TDVibFZTbjhiYVBRTFI2cUoycWR1ZHRacUw1VXFORG1WTGRJQ3MzSERaNFMz?=
 =?utf-8?B?cFVNbGxuM042czl1OXFrbi9CWDh5Y0gzcDc2VmQ0amVMZ1FOdmxrNzlxVTZp?=
 =?utf-8?B?d3VjZFNGdTVndk5XbU1XaXI0NjR5U01OTUtVVkhseGpKN011T01hdHRMUTU0?=
 =?utf-8?B?YkRnQ0c5elJ1OUJkK2xDNkNnMmw2M1BQZmRYakV1VEJnTjZsVVppSVc5MnNZ?=
 =?utf-8?B?VTJtdW5TWjc5TjlHVEptRVI4ejVJeTVEeEUwaGdZUDNIakZVQktwM1FLYTla?=
 =?utf-8?B?SEl1MzNFdmZINVk3ZGIxckk0WXU0Y2xTdzVZaDdVWVJ4VHA2K0lnME40U0Z5?=
 =?utf-8?B?RlpOL3RyWHFnWFBUcDVEaDUxWGNPQWZhOG1YaFI3Z2tTY1VkaXB5VXptQmNi?=
 =?utf-8?B?bDhZR0diTXZIYnV5MXlXbWVCd3R0WlZIb1lmSHV4b3B4Z1hiOU9RcWFDdndZ?=
 =?utf-8?B?TjVCaG05K0tFYm1oa3A0RnlFZ1pyKzRJOUVWLzJBN1VlM0dYVFFCS0tuUnpu?=
 =?utf-8?B?UjhnZi9uZW92T1RrL1VGZXE2SzBiazY4MnBYT0hCOTlmaks3VHlsNFQvbjRX?=
 =?utf-8?B?cUpLOVVTVk1IWC82U0tzVERTbjMxcS8zNFltL3NNUVZJTkYwcVNZL0JmWkdJ?=
 =?utf-8?B?dFExKy9Pdkx4TERMa2h5dnpzY25tbmFYWDh3bHdITUF0c3JpckxiaW5XVkQz?=
 =?utf-8?B?UEdidzYwK0dCcWZCQ2NzYVpEbkQ5VW8vNm0xZTJuTWJKcTZYZ3pmODJsU2FI?=
 =?utf-8?B?cnQxMEdEajFTTllJWXpsME5sT2V1UWZRN0dGd29UY2pwQXRHMDc4MVZoVHhp?=
 =?utf-8?B?cE50WGsrR3QzLzR6OUdMZVhPUXAyY0FVdEh3c2VmOUU4RmFzS0NKUU42emth?=
 =?utf-8?B?QnZWNy9WR3diZzg5eGtWR2ZpYWtxMnFTQjlsMHpSaFI0VXVsNWJyRitVVXoz?=
 =?utf-8?B?SWJBVkx0MUdVZjRock5UeHdaN0tLT2RGTzZKeXpEM3UwZ2Vncks3SnFvTVZH?=
 =?utf-8?B?MFlXUml3Z0MrdEV5M21YUEoxeG1iT2pDdkZicUxyaEJKWVZXcTUzSm9uWjcw?=
 =?utf-8?B?Szh3b2tDelhMY1RyVHdEd0grWHdka1lneFdNcEI5ejFqVEUxWVgzdWZhUXpU?=
 =?utf-8?B?RW1hcEFvOVBLSEZwSmNYZlBXN1ZUMkJmSzhtTzlkaFFYTzBRTkdrZzg5M0gw?=
 =?utf-8?B?N1cvQ3p6emRoWHBSbGFkdGtMUzh1SVdteGRLVGxtTkJIMTZmMzhCSzZLOUdV?=
 =?utf-8?B?VmNVZUdreFI5Z2g4Z2Jyb2pwWXZQaWovTjJYdVBUaUFDOG5qc0VTM1VybTR4?=
 =?utf-8?B?cExyVHlMaGRWOWZBNXp0ZjdnSExZaHZra0xkWDlLRGlBVzRHeWZVQT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <B3AB97E4BB389A48BE1AD299B0DBAB4F@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1548d582-fd85-4993-8dea-08d9e7141cbc
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Feb 2022 12:53:01.6169
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Zcdbp1yZf35/ViMX+/IFE5t0PCt+gApoR6WGAQ/ESN28e2X4+FMhHYDHx2/krnr2a1SGSg+xcV9gundSSP8Skgmkcsy4mIofw9y+VTuejhtlz0PUsdPbUBmPd4wI9yD5
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR03MB4859
X-Proofpoint-ORIG-GUID: GQhsmyNTGiELhlSG2YzcGQ4edkAx7HbN
X-Proofpoint-GUID: GQhsmyNTGiELhlSG2YzcGQ4edkAx7HbN
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-03_03,2022-02-03_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=4 impostorscore=0
 mlxlogscore=143 malwarescore=0 clxscore=1015 priorityscore=1501
 lowpriorityscore=0 bulkscore=0 phishscore=0 suspectscore=0 spamscore=4
 adultscore=0 mlxscore=4 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202030080

DQoNCk9uIDAzLjAyLjIyIDE0OjUwLCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMDMuMDIuMjAy
MiAxMzo0OCwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+PiBIaSwgSmFuIQ0KPj4N
Cj4+IE9uIDAzLjAyLjIyIDE0OjQ0LCBKYW4gQmV1bGljaCB3cm90ZToNCj4+PiBPbiAwMy4wMi4y
MDIyIDEzOjM2LCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyB3cm90ZToNCj4+Pj4gSGksIEJlcnRy
YW5kIQ0KPj4+Pg0KPj4+PiBPbiAyNi4xMS4yMSAxNDoxOSwgT2xla3NhbmRyIEFuZHJ1c2hjaGVu
a28gd3JvdGU6DQo+Pj4+PiBIaSwgQmVydHJhbmQhDQo+Pj4+Pg0KPj4+Pj4gT24gMjUuMTEuMjEg
MTg6MjgsIEJlcnRyYW5kIE1hcnF1aXMgd3JvdGU6DQo+Pj4+Pj4gSGkgT2xla3NhbmRyLA0KPj4+
Pj4+DQo+Pj4+Pj4+IE9uIDI1IE5vdiAyMDIxLCBhdCAxMTowMiwgT2xla3NhbmRyIEFuZHJ1c2hj
aGVua28gPGFuZHIyMDAwQGdtYWlsLmNvbT4gd3JvdGU6DQo+Pj4+Pj4+DQo+Pj4+Pj4+IEZyb206
IE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIDxvbGVrc2FuZHJfYW5kcnVzaGNoZW5rb0BlcGFtLmNv
bT4NCj4+Pj4+Pj4NCj4+Pj4+Pj4gQWRkIHJlbGV2YW50IHZwY2kgcmVnaXN0ZXIgaGFuZGxlcnMg
d2hlbiBhc3NpZ25pbmcgUENJIGRldmljZSB0byBhIGRvbWFpbg0KPj4+Pj4+PiBhbmQgcmVtb3Zl
IHRob3NlIHdoZW4gZGUtYXNzaWduaW5nLiBUaGlzIGFsbG93cyBoYXZpbmcgZGlmZmVyZW50DQo+
Pj4+Pj4+IGhhbmRsZXJzIGZvciBkaWZmZXJlbnQgZG9tYWlucywgZS5nLiBod2RvbSBhbmQgb3Ro
ZXIgZ3Vlc3RzLg0KPj4+Pj4+Pg0KPj4+Pj4+PiBFbXVsYXRlIGd1ZXN0IEJBUiByZWdpc3RlciB2
YWx1ZXM6IHRoaXMgYWxsb3dzIGNyZWF0aW5nIGEgZ3Vlc3Qgdmlldw0KPj4+Pj4+PiBvZiB0aGUg
cmVnaXN0ZXJzIGFuZCBlbXVsYXRlcyBzaXplIGFuZCBwcm9wZXJ0aWVzIHByb2JlIGFzIGl0IGlz
IGRvbmUNCj4+Pj4+Pj4gZHVyaW5nIFBDSSBkZXZpY2UgZW51bWVyYXRpb24gYnkgdGhlIGd1ZXN0
Lg0KPj4+Pj4+Pg0KPj4+Pj4+PiBST00gQkFSIGlzIG9ubHkgaGFuZGxlZCBmb3IgdGhlIGhhcmR3
YXJlIGRvbWFpbiBhbmQgZm9yIGd1ZXN0IGRvbWFpbnMNCj4+Pj4+Pj4gdGhlcmUgaXMgYSBzdHVi
OiBhdCB0aGUgbW9tZW50IFBDSSBleHBhbnNpb24gUk9NIGhhbmRsaW5nIGlzIHN1cHBvcnRlZA0K
Pj4+Pj4+PiBmb3IgeDg2IG9ubHkgYW5kIGl0IG1pZ2h0IG5vdCBiZSB1c2VkIGJ5IG90aGVyIGFy
Y2hpdGVjdHVyZXMgd2l0aG91dA0KPj4+Pj4+PiBlbXVsYXRpbmcgeDg2LiBPdGhlciB1c2UtY2Fz
ZXMgbWF5IGluY2x1ZGUgdXNpbmcgdGhhdCBleHBhbnNpb24gUk9NIGJlZm9yZQ0KPj4+Pj4+PiBY
ZW4gYm9vdHMsIGhlbmNlIG5vIGVtdWxhdGlvbiBpcyBuZWVkZWQgaW4gWGVuIGl0c2VsZi4gT3Ig
d2hlbiBhIGd1ZXN0DQo+Pj4+Pj4+IHdhbnRzIHRvIHVzZSB0aGUgUk9NIGNvZGUgd2hpY2ggc2Vl
bXMgdG8gYmUgcmFyZS4NCj4+Pj4+PiBJbiB0aGUgZ2VuZXJpYyBjb2RlLCBiYXJzIGZvciBpb3Bv
cnRzIGFyZSBhY3R1YWxseSBza2lwcGVkIChjaGVjayBjb2RlIGJlZm9yZQ0KPj4+Pj4+IGluIGhl
YWRlci5jLCBpbiBjYXNlIG9mIGlvcG9ydHMgdGhlcmUgaXMgYSBjb250aW51ZSkgYW5kIG5vIGhh
bmRsZXIgaXMgcmVnaXN0ZXJlZCBmb3IgdGhlbS4NCj4+Pj4+PiBUaGUgY29uc2VxdWVuY2Ugd2ls
bCBiZSB0aGF0IGEgZ3Vlc3Qgd2lsbCBhY2Nlc3MgaGFyZHdhcmUgd2hlbiByZWFkaW5nIHRob3Nl
IEJBUnMuDQo+Pj4+PiBZZXMsIHRoaXMgc2VlbXMgdG8gYmUgYSB2YWxpZCBwb2ludA0KPj4+PiBT
bywgd2l0aCB0aGUgYXBwcm9hY2ggd2UgaGF2ZSBkZXZlbG9wZWQgdGhlc2UgZGF5cyB3ZSB3aWxs
IGlnbm9yZSBhbGwgd3JpdGVzDQo+Pj4+IGFuZCByZXR1cm4gfjAgZm9yIHJlYWRzIGZvciBhbGwg
dW5oYW5kbGVkIG9wcywgZS5nLiB0aG9zZSB3aGljaCBkbyBub3QgaGF2ZSBleHBsaWNpdA0KPj4+
PiByZWdpc3RlciBoYW5kbGVycyBlbXBsb3llZC4gVGh1cywgdGhpcyBjYXNlIHdpbGwgZmFsbCBp
bnRvIHVuaGFuZGxlZCBjbGF1c2UuDQo+Pj4gRXhjZXB0IHRoYXQgSSBndWVzcyBCQVJzIGFyZSBz
cGVjaWFsIGluIHRoYXQgcmVhZHMgbWF5IG5vdCByZXR1cm4gfjAsDQo+Pj4gb3IgZWxzZSB0aGUg
bG93IGJpdHMgY2FycnkgYSBtZWFuaW5nIHdlIGRvbid0IHdhbnQgdG8gY29udmV5LiBVbnVzZWQN
Cj4+PiBCQVJzIG5lZWQgdG8gYmUgaGFyZC13aXJlZCB0byAwLCBJIHRoaW5rLg0KPj4gU28sIHlv
dSBtZWFuIHdlIHNob3VsZCBoYXZlIDIgc2V0cyBvZiBCQVIgaGFuZGxlcnMgZm9yIGd1ZXN0czoN
Cj4+IDEuIG5vcm1hbCBlbXVsYXRpb24gKHRoZXNlIGFyZSBpbXBsZW1lbnRlZCBpbiB0aGlzIHBh
dGNoKQ0KPj4gMi4gYWxsIG90aGVyIEJBUnM6IHJlYWQgMC9pZ25vcmUgd3JpdGUgZm9yIGFsbCBv
dGhlciBCQVJzLCBpbmNsdWRpbmcgUk9NLCBJTyBldGMuDQo+Pg0KPj4gSXMgdGhpcyB3aGF0IHlv
dSBtZWFuPw0KPiBJIHRoaW5rIHRoYXQncyB3aGF0IHdlJ3JlIGdvaW5nIHRvIG5lZWQsIHllcy4N
Ck9rLCB0aGVuIEknbGwgc3R1ZmYgdGhhdCBpbnRvIHRoaXMgcGF0Y2ggdjYNCj4gSmFuDQo+DQpU
aGFuayB5b3UsDQpPbGVrc2FuZHI=


From xen-devel-bounces@lists.xenproject.org Thu Feb 03 12:54:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 03 Feb 2022 12:54:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264712.457913 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFbdK-0001mW-VS; Thu, 03 Feb 2022 12:54:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264712.457913; Thu, 03 Feb 2022 12:54:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFbdK-0001mP-Sa; Thu, 03 Feb 2022 12:54:42 +0000
Received: by outflank-mailman (input) for mailman id 264712;
 Thu, 03 Feb 2022 12:54:41 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=nHU3=SS=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nFbdJ-0001mF-N8
 for xen-devel@lists.xenproject.org; Thu, 03 Feb 2022 12:54:41 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 731a97a5-84f0-11ec-8eb8-a37418f5ba1a;
 Thu, 03 Feb 2022 13:54:40 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id C76A41F3AF;
 Thu,  3 Feb 2022 12:54:39 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 88BEE13BC0;
 Thu,  3 Feb 2022 12:54:39 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id mG0WII/Q+2HZJwAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 03 Feb 2022 12:54:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 731a97a5-84f0-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1643892879; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=7iSunMqBl0r2TYN6qk5DOh7j2XaRG5LJCFhaoFwS36Y=;
	b=fXLmwOSHW9TAlAuxjDA85N43mCXieeEFShWSoY0rYqHZgpx+98J6Igwc/lPkc6aiho0MZm
	TCb9vgxFmmphcGSassRXAhdq2juWzkiiUAzVkhMXF7O9n70Zx+NbCv7ZKVguDA2/WGzTzh
	V6Q8mW6i72wsktAVeLI35xbnG7a1Rj0=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>
Subject: [PATCH v2] docs: document patch rules
Date: Thu,  3 Feb 2022 13:54:38 +0100
Message-Id: <20220203125438.21807-1-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Add a document to describe the rules for sending a proper patch.

As it contains all the information already being present in
docs/process/tags.pandoc remove that file.

The "Reviewed-by:" and "Acked-by:" tags are expanded to allow an
optional restriction of the tag.

A new tag "Origin:" is added to tag patches taken from another project.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
v2:
- expanded commit message (Roger Pau Monné)
- some rewordings (Roger Pau Monné, Jan Beulich)
- add "Requested-by:" description (Jan Beulich)
- rename "Taken-from:" to "Origin:" (Jan Beulich)
- add reviewers as recipients of patch (Jan Beulich)
- style fixes (Roger Pau Monné, Jan Beulich)

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 docs/process/sending-patches.pandoc | 298 ++++++++++++++++++++++++++++
 docs/process/tags.pandoc            |  55 -----
 2 files changed, 298 insertions(+), 55 deletions(-)
 create mode 100644 docs/process/sending-patches.pandoc
 delete mode 100644 docs/process/tags.pandoc

diff --git a/docs/process/sending-patches.pandoc b/docs/process/sending-patches.pandoc
new file mode 100644
index 0000000000..2091037901
--- /dev/null
+++ b/docs/process/sending-patches.pandoc
@@ -0,0 +1,298 @@
+# How a proper patch should look like
+
+This is a brief description how a proper patch for the Xen project should
+look like. Examples and tooling tips are not part of this document, those
+can be found in the
+[Xen Wiki](https://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches).
+
+## The patch subject
+
+The first line at the top of the patch should contain a short description of
+what the patch does, and hints as to what code it touches. This line is used
+as the **Subject** line of the mail when sending the patch.
+
+The hint which code is touched is usually in form of an abstract entity
+(like e.g. `build` for the build system), or a component (like `tools` or
+`iommu`). Further specification is possible via adding a sub-component with
+a slash (e.g. `tools/xenstore`):
+
+    <component>: <description>
+
+E.g.:
+
+    xen/arm: increase memory banks number define value
+    tools/libxenevtchn: deduplicate xenevtchn_fd()
+    MAINTAINERS: update my email address
+    build: correct usage comments in Kbuild.include
+
+The description should give a rough hint *what* is done in the patch.
+
+The subject line should in general not exceed 80 characters. It must be
+followed by a blank line.
+
+## The commit message
+
+The commit message is free text describing *why* the patch is done and
+*how* the goal of the patch is achieved. A good commit message will describe
+the current situation, the desired goal, and the way this goal is being
+achieved. Parts of that can be omitted in obvious cases.
+
+In case additional changes are done in the patch (like e.g. cleanups), those
+should be mentioned.
+
+When referencing other patches (e.g. `similar to patch xy ...`) those
+patches should be referenced via their commit id (at least 12 digits)
+and the patch subject, if the very same patch isn't referenced by the
+`Fixes:` tag, too:
+
+    Similar to commit 67d01cdb5518 ("x86: infrastructure to allow converting
+    certain indirect calls to direct ones") add ...
+
+The following ``git config`` settings can be used to add a pretty format for
+outputting the above style in the ``git log`` or ``git show`` commands:
+
+        [core]
+                abbrev = 12
+        [pretty]
+                fixes = Fixes: %h (\"%s\")
+
+Lines in the commit message should not exceed 75 characters, except when
+copying error output directly into the commit message.
+
+## Tags
+
+Tags are entries in the form
+
+    Tag: something
+
+In general tags are added in chronological order. So a `Reviewed-by:` tag
+should be added **after** the `Signed-off-by:` tag, as the review happened
+after the patch was written.
+
+Do not split a tag across multiple lines, tags are exempt from the
+"wrap at 75 columns" rule in order to simplify parsing scripts.
+
+### Origin:
+
+Xen has inherited some source files from other open source projects. In case
+a patch modifying such an inherited file is taken from that project (maybe in
+modified form), the `Origin:` tag specifies the source of the patch:
+
+    Origin: <repository-URL> <commit-id>
+
+E.g.:
+
+    Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git f093b08c47b3
+
+All tags **above** the `Origin:` tag are from the original patch (which
+should all be kept), while tags **after** `Origin:` are related to the
+normal Xen patch process as described here.
+
+### Fixes:
+
+If your patch fixes a bug in a specific commit, e.g. you found an issue using
+``git bisect``, please use the `Fixes:` tag with the first 12 characters of
+the commit id, and the one line summary.
+
+    Fixes: <commit-id> ("<patch-subject>")
+
+E.g.:
+
+    Fixes: 67d01cdb5518 ("x86: infrastructure to allow converting certain indirect calls to direct ones")
+
+### Backport:
+
+A backport tag is an optional tag in the commit message to request a
+given commit to be backported to the released trees:
+
+    Backport: <version> [# <comment>]
+
+E.g.:
+
+    Backport: 4.9+
+
+It marks a commit for being a candidate for backports to all released
+trees from 4.9 onward.
+
+The backport requester is expected to specify which currently supported
+releases need the backport; but encouraged to specify a release as far
+back as possible which applies. If the requester doesn't know the oldest
+affected tree, they are encouraged to append a comment like the
+following:
+
+    Backport: 4.9+ # maybe older
+
+Maintainers request the Backport tag to be added on commit. Contributors
+are welcome to mark their patches with the Backport tag when they deem
+appropriate. Maintainers will request for it to be removed when that is
+not the case.
+
+Please note that the Backport tag is a **request** for backport, which
+will still need to be evaluated by the maintainers. Maintainers might
+ask the requester to help with the backporting work if it is not
+trivial.
+
+### Reported-by:
+
+This optional tag can be used to give credit to someone reporting an issue.
+It is in the format:
+
+    Reported-by: name <email@domain>
+
+E.g.:
+
+    Reported-by: Jane Doe <jane.doe@example.org>
+
+As the email address will be made public via git, the reporter of an issue
+should be asked whether he/she is fine with being mentioned in the patch.
+
+### Suggested-by:
+
+This optional tag can be used to give credit to someone having suggested the
+solution the patch is implementing. It is in the format:
+
+    Suggested-by: name <email@domain>
+
+E.g.:
+
+    Suggested-by: Jane Doe <jane.doe@example.org>
+
+As the email address will be made public via git, the reporter of an issue
+should be asked whether he/she is fine with being mentioned in the patch.
+
+### Requested-by:
+
+This tag is very similar to the `Suggested-by:` tag, but it refers to an
+explicit request to add the patch. It is in the format:
+
+    Requested-by: name <email@domain>
+
+E.g.:
+
+    Requested-by: Jane Doe <jane.doe@example.org>
+
+### Signed-off-by:
+
+This mandatory tag specifies the author(s) of a patch (for each author a
+separate `Signed-off-by:` tag is needed). It is in the format:
+
+    Signed-off-by: name <email@domain>
+
+E.g.:
+
+    Signed-off-by: Jane Doe <jane.doe@example.org>
+
+The author must be a natural person (not a team or just a company) and the
+`Signed-off-by:` tag must include the real name of the author (no pseudonym).
+
+By signing the patch with her/his name the author explicitly confirms to have
+made the contribution conforming to the `Developer's Certificate of Origin`:
+
+    Developer's Certificate of Origin 1.1
+    
+    By making a contribution to this project, I certify that:
+    
+    (a) The contribution was created in whole or in part by me and I
+        have the right to submit it under the open source license
+        indicated in the file; or
+    
+    (b) The contribution is based upon previous work that, to the best
+        of my knowledge, is covered under an appropriate open source
+        license and I have the right under that license to submit that
+        work with modifications, whether created in whole or in part
+        by me, under the same open source license (unless I am
+        permitted to submit under a different license), as indicated
+        in the file; or
+    
+    (c) The contribution was provided directly to me by some other
+        person who certified (a), (b) or (c) and I have not modified
+        it.
+    
+    (d) I understand and agree that this project and the contribution
+        are public and that a record of the contribution (including all
+        personal information I submit with it, including my sign-off) is
+        maintained indefinitely and may be redistributed consistent with
+        this project or the open source license(s) involved.
+
+### Reviewed-by:
+
+A `Reviewed-by:` tag can only be given by a reviewer of the patch. With
+responding to a sent patch adding the `Reviewed-by:` tag the reviewer
+(which can be anybody) confirms to have looked thoroughly at the patch and
+didn't find any issue (being it technical, legal or formal ones). If the
+review is covering only some parts of the patch, those parts can optionally
+be specified (multiple areas can be either separated by commas, or be covered
+with multiple `Reviewed-by:` tags). It is in the format:
+
+    Reviewed-by: name <email@domain> [# area[, area]]
+
+E.g.:
+
+    Reviewed-by: Jane Doe <jane.doe@example.org>
+    Reviewed-by: Jane Doe <jane.doe@example.org> # xen/x86
+
+In case a patch is being resent an already given `Reviewed-by:` tag can and
+should be included, if the patch didn't meaningfully change the portions of the
+patch covered by the tag, or if the reviewer already made clear it would be
+fine to make specific changes and no *other* changes have been made.
+
+### Acked-by:
+
+Similar to `Reviewed-by:` the `Acked-by:` tag is given by someone having looked
+at the patch. The `Acked-by:` tag can only be given by a **maintainer** of the
+modified code, and it only covers the code the maintainer is responsible for.
+With the `Acked-by:` tag the maintainer states, that he/she is fine with the
+changes in principle, but didn't do a thorough review. The format is:
+
+    Acked-by: name <email@domain> [# area[, area]]
+
+E.g.:
+
+    Acked-by: Jane Doe <jane.doe@example.org>
+
+Including the `Acked-by:` tag in a patch is done under the same rules as for
+the `Reviewed-by:` tag, with the implied code area the maintainer who gave the
+`Acked-by:` tag is responsible for (if no area was specified with the tag).
+
+### Tested-by:
+
+The `Tested-by:` tag is another tag given by someone else. The one giving it
+confirms to have tested the patch without finding any functional issues. The
+format is:
+
+    Tested-by: name <email@domain>
+
+E.g.:
+
+    Tested-by: Jane Doe <jane.doe@example.org>
+
+Including the `Tested-by:` tag in a patch is done under the same rules as for
+the `Reviewed-by:` tag, now limited to the patch not having been modified
+regarding code logic (having changed only coding style, comments, or message
+texts is fine).
+
+## Patch version history (change log), further comments
+
+When sending revised versions of a patch it is good practice to include a
+change log after a line containing only `---` (this line will result in the
+following text not being included in the commit message). This change log
+will help reviewers to spot which parts of the patch have changed. Attributing
+changes due to reviewer comments will help the reviewer even more, e.g.:
+
+    ---
+    Changes in v2:
+    - changed function foo() as requested by Jane Doe
+    - code style fixed
+
+In some cases it might be desirable to add some more information for readers
+of the patch, like potential enhancements, other possible solutions, etc.,
+which should not be part of the commit message. This information can be
+added after the `---` line, too.
+
+## Recipients of the patch
+
+A patch should always be sent **to** the xen-devel mailing list
+<xen-devel@lists.xenproject.org> and all maintainers and designated reviewers
+of all touched code areas should get a copy of the mail via **Cc**. In case
+some other recipients are known to be interested in the patch, they can be
+added via **Cc**, too.
diff --git a/docs/process/tags.pandoc b/docs/process/tags.pandoc
deleted file mode 100644
index 1841cb87a8..0000000000
--- a/docs/process/tags.pandoc
+++ /dev/null
@@ -1,55 +0,0 @@
-Tags: No line splitting
------------------------
-Do not split a tag across multiple lines, tags are exempt from the
-"wrap at 75 columns" rule in order to simplify parsing scripts.  For
-example:
-
-        Fixes: 67d01cdb5518 ("x86: infrastructure to allow converting certain indirect calls to direct ones")
-
-
-Fixes Tag
----------
-
-If your patch fixes a bug in a specific commit, e.g. you found an issue using
-``git bisect``, please use the 'Fixes:' tag with the first 12 characters of
-the SHA-1 ID, and the one line summary.
-
-The following ``git config`` settings can be used to add a pretty format for
-outputting the above style in the ``git log`` or ``git show`` commands:
-
-        [core]
-                abbrev = 12
-        [pretty]
-                fixes = Fixes: %h (\"%s\")
-
-
-Backport Tag
-------------
-
-A backport tag is an optional tag in the commit message to request a
-given commit to be backported to the released trees:
-
-    Backport: 4.9+
-
-It marks a commit for being a candidate for backports to all released
-trees from 4.9 onward.
-
-The backport requester is expected to specify which currently supported
-releases need the backport; but encouraged to specify a release as far
-back as possible which applies. If the requester doesn't know the oldest
-affected tree, they are encouraged to append a comment like the
-following:
-
-    Backport: 4.9+ # maybe older
-
-Maintainers request the Backport tag to be added on commit. Contributors
-are welcome to mark their patches with the Backport tag when they deem
-appropriate. Maintainers will request for it to be removed when that is
-not the case.
-
-Please note that the Backport tag is a **request** for backport, which
-will still need to be evaluated by the maintainers. Maintainers might
-ask the requester to help with the backporting work if it is not
-trivial.
-
-When possible, please use the Fixes tag instead (or in addition).
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Thu Feb 03 12:55:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 03 Feb 2022 12:55:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264716.457925 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFbdi-0002Nn-Cu; Thu, 03 Feb 2022 12:55:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264716.457925; Thu, 03 Feb 2022 12:55:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFbdi-0002Ng-9A; Thu, 03 Feb 2022 12:55:06 +0000
Received: by outflank-mailman (input) for mailman id 264716;
 Thu, 03 Feb 2022 12:55:04 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=OTfZ=SS=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nFbdg-0001mF-DK
 for xen-devel@lists.xenproject.org; Thu, 03 Feb 2022 12:55:04 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 80e6d4b4-84f0-11ec-8eb8-a37418f5ba1a;
 Thu, 03 Feb 2022 13:55:03 +0100 (CET)
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2054.outbound.protection.outlook.com [104.47.2.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-5-XApct5dwPimfIYBbFmthRQ-1; Thu, 03 Feb 2022 13:55:01 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM7PR04MB7047.eurprd04.prod.outlook.com (2603:10a6:20b:11b::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Thu, 3 Feb
 2022 12:54:59 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.012; Thu, 3 Feb 2022
 12:54:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 80e6d4b4-84f0-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1643892903;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=3GwTO6yhPVlHp/fqFnzYc7/0Mvu4gA14nx8f03cFGD4=;
	b=aLISX6mAHaBVReUhelUD0pJihgmXXT1PlFP9NK5k6+48bv9SNn7vukGnBDBUWjmZ+/xCS+
	tEOIGgwzjctDpSCMJ7h0E5nBgWhXXGwh4EyOcSSGp1EmAWWGoIw2mK5uyoZvSVgCYYoesU
	pUfIXHkkDyTK+fI2J0TvO+NaqcBZoX0=
X-MC-Unique: XApct5dwPimfIYBbFmthRQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=MnYjliUxFYN87tYwxj4d5Ep9q24yegAuvojKnwRgc6+k10wxXeXlgwz8u4Rth6s3tetj8+BSuNcRFcYP0avfxBEVcDR6chQfbHwk7fQfsUF2IEN96V3rr0Oe11UJMCKDGWm57Pl/qSa+zJtw+bIXWngH4MJxf/gjD2auZVFIh+W8ZuQY0rkeZavbRvGp7FAInkc2GIA5KvxsvPlckgf3mCEQXdhcBgzFIk5FPlVtjSibTLC4uh3IPO4HWPmgkAhUlxZAVNJ97QDZEje0WDfmpXHPT5dQ6I16rHUFTC75Ie1sccxmo8BbqBBp276nTOwm/CoAIZSiApPY2LzuvmF4rw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=YboevU3sS+1yg/iJml4Svbv970lgeDaTwRe6bx8AyEY=;
 b=PkDnBBkY0ZrUffciVTpAs/nzCwANqomBAJjo08wC49B/Hhmd7ep7XFQtM+Za6SDpM6YPqxWPaVeSeFM8Q7wTJvLzFCNuhVG2KlogIWMB3F2gniAamwZbH8QU6+0uNRWkQiDeJyZhXhxn8wYEyEM0UQ0Q/OUs2oE6Xb8dE8oJ/Z6fa4toJ4nFtEKCZJOLwQ8KP6bc6LbyHnUqOXfTf0OGyPlOogS12xuXxVvS2YMDigQByLyHpKFNcuDgadL6H2Yhqm67fVUY75us9WYkVARvdmHrcehHoXy2sXpeauoC/xVawWCWRNiXL5P25PDUuasfF+2PcEMZPGlj0/nIYEmPig==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <9c1f376a-0df3-67eb-7fd1-bb75ae130e77@suse.com>
Date: Thu, 3 Feb 2022 13:54:56 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v5 06/14] vpci/header: implement guest BAR register
 handlers
Content-Language: en-US
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "julien@xen.org" <julien@xen.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Artem Mygaiev <Artem_Mygaiev@epam.com>,
 "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
 "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
 "paul@xen.org" <paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>
References: <20211125110251.2877218-1-andr2000@gmail.com>
 <20211125110251.2877218-7-andr2000@gmail.com> <Yd8RJfpEalnfl+CC@Air-de-Roger>
 <d493b022-3c78-1721-e668-48f4553056a9@epam.com>
 <df98cdbd-36fe-0386-c068-2a1540f10188@epam.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <df98cdbd-36fe-0386-c068-2a1540f10188@epam.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0254.eurprd06.prod.outlook.com
 (2603:10a6:20b:45f::29) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 752f4cb9-f807-4baa-9635-08d9e7146305
X-MS-TrafficTypeDiagnostic: AM7PR04MB7047:EE_
X-Microsoft-Antispam-PRVS:
	<AM7PR04MB7047DC68409D814BC16941F1B3289@AM7PR04MB7047.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	BadbHsau4BfH6r38qEpagXylW+GcYZ/enNyy8KPw1M2ZK00mR+1bNPIOZZeAF/l6CLo6RpPChf/8oWHPYsA/Q8GYAoyMDYXqXFdzolH4Xm7QL1Y80o0hx5GXoVxSZXaGoA0xpl0cbKVjYB2gbAmTJzYnnm649VdpblvNtDsATpsk50rabGQxxRPwUAygaw2hFWJhSwP+QF8OmXGUjx3ETXzaZLS6QI2Lr+H+eJVaFcXymFf2ScnBfsfKuRBygeCLywTDwvbKnJZwk69OpANdii+Y3z259J2NCHZOwfGQYJNPSAuCAC/zWMPadEqiFxENxL9H++o8rQqWEr6SwajcxlhLZxpNOIzGWJgBL+xHSFbA6jmN0IwBneidUbfLNuNsmVhEmaCOUu0MDWwcHJ4NqyJGTU4putMIpUnXBG2AO2dUSzjrvNGQrI7Vv2f9+/66LQm8SvO96pItjrnlkz69+XmlZm7Mijmjrt+Xx/CpNqUiMsW3D404w5YcvXk58ZEdDhw301BaJFHSeT/PXF/Alm+fUiMAPUqtDOev8fiCPV1V0743Efdv0JPeOtb53qDdZGvSO+pIDUYkkeMmvLgOo5urbX/8aYJalukgt8z9+/Th7Lqls0IReOQ+Q3xKwh5nPhc7IfWn0h8OmHPzgFlab4AJYAvsqyyxws6wTeOPSwouvW7KLLDQYtlnJ91Mv90xdw9M2ky2xPtW3FOoaC4jJEDajrV9XCiJrohPXCbrQvU=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6666004)(66946007)(66556008)(83380400001)(2906002)(66476007)(8936002)(2616005)(8676002)(4326008)(6512007)(6506007)(26005)(508600001)(7416002)(186003)(86362001)(36756003)(316002)(6916009)(31696002)(38100700002)(54906003)(5660300002)(53546011)(31686004)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?1sBOgn0OjUSHx2xc/S/c3Jfeh7B4s74fsoGq2zWgEEDxowF/VAnrKpxt4S/a?=
 =?us-ascii?Q?L85DyczzEu7WUMd3z6ZmZFxCXPsKH6Qn+VDlJbwdQiuKp1InlJugzAOD6Elz?=
 =?us-ascii?Q?lAmmZ8w2yYBk9NNV9IRRkgF0rmHDyC63sbsR8Wop4LsV7XuPn8D2gRxKbFlH?=
 =?us-ascii?Q?yt5StjVQjtv4zyUwISaU5OfbVtxe589Oa+AHZ3TfzgZNYgioc1ORhZ1KT4C4?=
 =?us-ascii?Q?iQOZxZMKxD66MDiPm9R55XFWvA7j6X6k44Jl9c92WgHrmwtAlasMnhnAxfSY?=
 =?us-ascii?Q?WU7nXy5NHJqQgU7Xps3pVKulnhXCOK3OohjRaLLGrEHnVAC5sJguKhPhhWUk?=
 =?us-ascii?Q?hlEK1RNUd6axU4FJDxx23se/GLuUWkqr/v0Ghixlf+fF4OgJWA/U+qcRiSZa?=
 =?us-ascii?Q?BCUEM+gKnNTr/UPfJbrHwM4QFVY12o71dx8ZUrPdP9jib34qyHlomSbx4EoV?=
 =?us-ascii?Q?q6bII+8IZknqdQ4Vnt3fVf99XcowIS5YgAJQsL9hPPO6gP+n9a21NMI/rHx7?=
 =?us-ascii?Q?yLcynOUL+UJlmIki3mYGwMEdz0BX9ReWE5z19FTgywMjqjy6pZN04D5L2io+?=
 =?us-ascii?Q?bk3zoMZRf62zE0qbunFvlRmiMbOfzMUfyDpmL1VwEYaPy2ukNF61U60d8NKs?=
 =?us-ascii?Q?yGym1aDraexRYrr4oFyLEGda2IhTlW4ndHl95uuoJegGqjcrwsOLUw3xgKcH?=
 =?us-ascii?Q?ARwOpXnySem1SjbYQSpCCkU2QB31SvqDUTHuOenr14fMhe7Pip2qz7SSL7wV?=
 =?us-ascii?Q?hD8FPJHLorc0Kl/5UR0MjT8D6B++E/ZnSIJQtI7/Cu3VOk8AV6pWR7ueK05z?=
 =?us-ascii?Q?6BTDBe1jDhIq8yyqKlcpBLLg8+j45SY1nnGMmtRejGz+TaMxDJKN2B4JUi/9?=
 =?us-ascii?Q?a/IOkvXIJPOlaM2b6TyNv05AfhVdn2xER/XRJgIezvME12WZc16nL4Qg/FEY?=
 =?us-ascii?Q?JcgU4beROzTtBz0Wa3AuGKDHp1FN9mGZ5+TaU14AqQQZzQV1er6iYJDSul8A?=
 =?us-ascii?Q?+cPNDYF2/tVBgHzuoRzNIIuGJCrZ6SNU00/zu0gAJEJ4N/0pPwWOlv9BU5BV?=
 =?us-ascii?Q?6IZoT44tOPN22IhI/19NK6ibFfmWMDbchI/M3f26v0XiYtUdpwRjUeYXoBow?=
 =?us-ascii?Q?ep+KrdkH/ejyTndQj5Wq+9euq98KEpr1EipggwUzVTM4FjOHSlODokESsFWF?=
 =?us-ascii?Q?E4RyEZqrDH0BqfLdJhWNvaozzeZ+Vpyq6lUruowc6pK+JkMNktQLUszCUXJi?=
 =?us-ascii?Q?v2oxiE4VM1h01s24/4xyJHuDtkS809+cLhTn6Qj/AgpeClSbnwJeZNER7DUN?=
 =?us-ascii?Q?Y9z327WfiTIuaX5exJ9pJy+IesMmDh781VP3qpTxHYuJ35zTiEsW9fDBlxMX?=
 =?us-ascii?Q?/oIjWcm7jCnju6l0L3EMc37IiC0AwhddAcpTbSZwlr56M3JLyzdbqRKhhvf3?=
 =?us-ascii?Q?X84LSwxptuU1tPwm+UNB9Xh1BLsh7FLt3JRB10fp4JeHWld1iRc4nKurM+Kt?=
 =?us-ascii?Q?dbpDt4/6yjZGNrZzkmVRcukhF7KjFZhTbgnpwMQzqCNXah62V1g8+EQuB4YT?=
 =?us-ascii?Q?m1tXwUlbENGKw3iFLQsrFsoY9HJOKnaC5A0/UqbfnZdJhzeC2b0mF7iKerd4?=
 =?us-ascii?Q?3kG23pFoEAjftZ8tg4x+ueE=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 752f4cb9-f807-4baa-9635-08d9e7146305
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Feb 2022 12:54:59.7714
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wMxeGCYmdld29QDBzjH/8XiJ9GrDDz18+saBCYxystrNeIpzKhegRDG7+jL/1tYsX8bfHXfRohV8VrRLg8VF/w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB7047

On 03.02.2022 13:45, Oleksandr Andrushchenko wrote:
>>> Also memory decoding needs to be initially disabled when used by
>>> guests, in order to prevent the BAR being placed on top of a RAM
>>> region. The guest physmap will be different from the host one, so it's
>>> possible for BARs to end up placed on top of RAM regions initially
>>> until the firmware or OS places them at a suitable address.
>> Agree, memory decoding must be disabled
> Isn't it already achieved by the toolstack resetting the PCI device
> while assigning=C2=A0 it to a guest?

Iirc the tool stack would reset a device only after getting it back from
a DomU. When coming straight from Dom0 or DomIO, no reset would be
performed. Furthermore, (again iirc) there are cases where there's no
known (standard) way to reset a device. Assigning such to a guest when
it previously was owned by another one is risky (and hence needs an
admin knowing what they're doing), but may be acceptable in particular
when e.g. simply rebooting a guest.

IOW - I don't think you can rely on the bit being in a particular state.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Feb 03 13:14:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 03 Feb 2022 13:14:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264730.457936 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFbwR-0004rV-13; Thu, 03 Feb 2022 13:14:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264730.457936; Thu, 03 Feb 2022 13:14:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFbwQ-0004rO-Tg; Thu, 03 Feb 2022 13:14:26 +0000
Received: by outflank-mailman (input) for mailman id 264730;
 Thu, 03 Feb 2022 13:14:25 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=nHU3=SS=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nFbwP-0004qx-Mv
 for xen-devel@lists.xenproject.org; Thu, 03 Feb 2022 13:14:25 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 28ef5f52-84f3-11ec-8f75-fffcc8bd4f1a;
 Thu, 03 Feb 2022 14:14:04 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 174241F3AF;
 Thu,  3 Feb 2022 13:14:24 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D4A4E13BC0;
 Thu,  3 Feb 2022 13:14:23 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 09zAMi/V+2GZMQAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 03 Feb 2022 13:14:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 28ef5f52-84f3-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1643894064; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=QuC0bG21+xDeovd2V5wjc961oxT9zXJ/CXc6pmIKuBw=;
	b=qX6gAZbcVG/zg+sloMEH8QogQ1BrDZRQJuW0fgoYRgKGRvmpL6fITr2AyfGfCAfUXKGNOV
	y6wpmc3lKP+XGtKQEU64DdchB9Y2kzuvlwHT64NKNsWsjA0vwgbuY2ptQbIEROEOluriIx
	WYN6EE2PPh8vU4E+2Grw7PiyJAoLkCE=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>
Subject: [PATCH v2 1/2] xen: add option to disable GNTTABOP_transfer
Date: Thu,  3 Feb 2022 14:14:17 +0100
Message-Id: <20220203131418.1319-1-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

The grant table operation GNTTABOP_transfer is meant to be used in
PV device backends, and it hasn't been used in Linux since the old
Xen-o-Linux days.

Add a command line sub-option to the "gnttab" option for disabling the
GNTTABOP_transfer functionality.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
V2:
- make option available for CONFIG_PV only (Jan Beulich)
- return -EOPNOTSUPP instead of -ENOSYS (Jan Beulich)
---
 docs/misc/xen-command-line.pandoc |  8 ++++++--
 xen/common/grant_table.c          | 12 ++++++++++++
 2 files changed, 18 insertions(+), 2 deletions(-)

diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc
index 6b3da6ddc1..44232b94c5 100644
--- a/docs/misc/xen-command-line.pandoc
+++ b/docs/misc/xen-command-line.pandoc
@@ -1167,9 +1167,9 @@ does not provide `VM_ENTRY_LOAD_GUEST_PAT`.
 Specify which console gdbstub should use. See **console**.
 
 ### gnttab
-> `= List of [ max-ver:<integer>, transitive=<bool> ]`
+> `= List of [ max-ver:<integer>, transitive=<bool>, transfer=<bool> ]`
 
-> Default: `gnttab=max-ver:2,transitive`
+> Default: `gnttab=max-ver:2,transitive,transfer`
 
 Control various aspects of the grant table behaviour available to guests.
 
@@ -1178,6 +1178,10 @@ version are 1 and 2.
 * `transitive` Permit or disallow the use of transitive grants.  Note that the
 use of grant table v2 without transitive grants is an ABI breakage from the
 guests point of view.
+* `transfer` Permit or disallow the GNTTABOP_transfer operation of the
+grant table hypercall.  Note that disallowing GNTTABOP_transfer is an ABI
+breakage from the guests point of view.  This option is only available on
+hypervisors configured to support PV guests.
 
 The usage of gnttab v2 is not security supported on ARM platforms.
 
diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c
index ed1e2fabce..57dfc54994 100644
--- a/xen/common/grant_table.c
+++ b/xen/common/grant_table.c
@@ -181,6 +181,11 @@ static int parse_gnttab_max_maptrack_frames(const char *arg)
 
 unsigned int __read_mostly opt_gnttab_max_version = GNTTAB_MAX_VERSION;
 static bool __read_mostly opt_transitive_grants = true;
+#ifdef CONFIG_PV
+static bool __ro_after_init opt_grant_transfer = true;
+#else
+#define opt_grant_transfer false
+#endif
 
 static int __init parse_gnttab(const char *s)
 {
@@ -204,6 +209,10 @@ static int __init parse_gnttab(const char *s)
         }
         else if ( (val = parse_boolean("transitive", s, ss)) >= 0 )
             opt_transitive_grants = val;
+#ifndef opt_grant_transfer
+        else if ( (val = parse_boolean("transfer", s, ss)) >= 0 )
+            opt_grant_transfer = val;
+#endif
         else
             rc = -EINVAL;
 
@@ -2233,6 +2242,9 @@ gnttab_transfer(
     unsigned int max_bitsize;
     struct active_grant_entry *act;
 
+    if ( !opt_grant_transfer )
+        return -EOPNOTSUPP;
+
     for ( i = 0; i < count; i++ )
     {
         bool_t okay;
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Thu Feb 03 13:14:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 03 Feb 2022 13:14:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264731.457941 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFbwR-0004uj-B6; Thu, 03 Feb 2022 13:14:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264731.457941; Thu, 03 Feb 2022 13:14:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFbwR-0004tg-52; Thu, 03 Feb 2022 13:14:27 +0000
Received: by outflank-mailman (input) for mailman id 264731;
 Thu, 03 Feb 2022 13:14:26 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=nHU3=SS=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nFbwQ-0004qx-Fk
 for xen-devel@lists.xenproject.org; Thu, 03 Feb 2022 13:14:26 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 290c58fa-84f3-11ec-8f75-fffcc8bd4f1a;
 Thu, 03 Feb 2022 14:14:04 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 55D051F440;
 Thu,  3 Feb 2022 13:14:24 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1D5E913BC0;
 Thu,  3 Feb 2022 13:14:24 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id wDcMBjDV+2GZMQAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 03 Feb 2022 13:14:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 290c58fa-84f3-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1643894064; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=g+iDuOt8GAh3oeLO+lSu1uVXdxYbj9ZBe5nrAfLFutA=;
	b=H/w7s193JJpQkRZ5WNy37uQatu4tFWBkGTrdAEZmkWA1kenxfW1iy3qxlbSELOCnZ/xu+2
	qb0aYbUad/eRngcBEtS/CuGaERso/q3ZVbEwSTIxfX4t4wSTrNQJ0aI+58v6QGEY/Wg1bo
	4uomzOVlQl6c5LBjXRvCpPBBgu0zb5A=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>
Subject: [PATCH v2 2/2] xen/include/public: deprecate GNTTABOP_transfer
Date: Thu,  3 Feb 2022 14:14:18 +0100
Message-Id: <20220203131418.1319-2-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220203131418.1319-1-jgross@suse.com>
References: <20220203131418.1319-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Add a comment to include/public/grant_table.h that GNTTABOP_transfer
is deprecated, in order to discourage new use cases.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
v2:
- new patch
---
 xen/include/public/grant_table.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/xen/include/public/grant_table.h b/xen/include/public/grant_table.h
index 7934d7b718..7fbd1c6d10 100644
--- a/xen/include/public/grant_table.h
+++ b/xen/include/public/grant_table.h
@@ -417,6 +417,8 @@ DEFINE_XEN_GUEST_HANDLE(gnttab_dump_table_t);
  * GNTTABOP_transfer: Transfer <frame> to a foreign domain. The foreign domain
  * has previously registered its interest in the transfer via <domid, ref>.
  *
+ * This operation is deprecated! Please don't add new use cases!
+ *
  * Note that, even if the transfer fails, the specified page no longer belongs
  * to the calling domain *unless* the error is GNTST_bad_page.
  *
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Thu Feb 03 13:15:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 03 Feb 2022 13:15:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264737.457958 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFbx1-0005la-Is; Thu, 03 Feb 2022 13:15:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264737.457958; Thu, 03 Feb 2022 13:15:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFbx1-0005lR-Eo; Thu, 03 Feb 2022 13:15:03 +0000
Received: by outflank-mailman (input) for mailman id 264737;
 Thu, 03 Feb 2022 13:15:02 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nFbx0-0005kv-CE; Thu, 03 Feb 2022 13:15:02 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nFbx0-0006Bx-8k; Thu, 03 Feb 2022 13:15:02 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nFbwz-0007Lg-J3; Thu, 03 Feb 2022 13:15:01 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nFbwz-00024G-Ie; Thu, 03 Feb 2022 13:15:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=r+SVRi6gA4i1iC132NObqD2QL1yPuehyLMQ335DcfSc=; b=AqW7ncJfiB93rVD6PaEiFyorXz
	UjFeT2eBPMvVedTMCyRL25ZJVg28tTU6+SJumlKvxdOROlRP93Y6ABYlCzakfrxrXAmiieh6BIE3c
	NPV45UlMc28CCLr0bhfsdO6TtPa60Q+LDASh5PhQq4Q4k4HE9yAbZw6GNmB8sAQOasCE=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167992-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 167992: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=41e878859ac7eb4059f2e9b338e585e205fd575c
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 03 Feb 2022 13:15:01 +0000

flight 167992 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167992/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              41e878859ac7eb4059f2e9b338e585e205fd575c
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  573 days
Failing since        151818  2020-07-11 04:18:52 Z  572 days  554 attempts
Testing same since   167992  2022-02-03 04:20:17 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brad Laue <brad@brad-x.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Christophe Fergeau <cfergeau@redhat.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Divya Garg <divya.garg@nutanix.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Emilio Herrera <ehespinosa57@gmail.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Ivan Teterevkov <ivan.teterevkov@nutanix.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Lubomir Rintel <lkundrak@v3.sk>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nicolas Lécureuil <neoclust@mageia.org>
  Nicolas Lécureuil <nicolas.lecureuil@siveo.net>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Rohit Kumar <rohit.kumar3@nutanix.com>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  shenjiatong <yshxxsjt715@gmail.com>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tuguoyi <tu.guoyi@h3c.com>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Vineeth Pillai <viremana@linux.microsoft.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yasuhiko Kamata <belphegor@belbel.or.jp>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 95898 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Feb 03 13:17:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 03 Feb 2022 13:17:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264756.457969 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFbzl-0006lq-7z; Thu, 03 Feb 2022 13:17:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264756.457969; Thu, 03 Feb 2022 13:17:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFbzl-0006lj-4L; Thu, 03 Feb 2022 13:17:53 +0000
Received: by outflank-mailman (input) for mailman id 264756;
 Thu, 03 Feb 2022 13:17:52 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=OTfZ=SS=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nFbzk-0006ld-JE
 for xen-devel@lists.xenproject.org; Thu, 03 Feb 2022 13:17:52 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a461aba0-84f3-11ec-8f75-fffcc8bd4f1a;
 Thu, 03 Feb 2022 14:17:31 +0100 (CET)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2052.outbound.protection.outlook.com [104.47.12.52]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-31-uKo8084GPwG68tnx4lB5mA-1; Thu, 03 Feb 2022 14:17:50 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM7PR04MB6792.eurprd04.prod.outlook.com (2603:10a6:20b:dc::8) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Thu, 3 Feb
 2022 13:17:48 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.012; Thu, 3 Feb 2022
 13:17:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a461aba0-84f3-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1643894271;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=KraDiBsPtW/5qsRQGD4muTqPq5mDALoHr8tGsweK3Wg=;
	b=J55grUBwrsDwJcVEy+t01+kq5EvtIGPZjot7YIlM4WhDrX1uKfKHZocSOgNeXxWe8BBLQJ
	DTXSvPR8VLs+et2td89qnUCaxqFQnoY1HPxXSphDf9BgQ046YxDvkbtX7kRwwQY+5DScDp
	546WzjALy9MDzmjQ/X+eVN3Pta6XP2U=
X-MC-Unique: uKo8084GPwG68tnx4lB5mA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gzSIvw+Df251FetQSJi0S4x7f+H4lNKZbvzNaRmJfaPywlejdbsMDfRVFdd/pcC9gBOaIGbvv2gprn7mStR+z3kNjzB41x6g9YosMdQOvQcaTyRgTK/+wQyN0uUkqsr71AR4oE7E7BGyXSj3/4ziDJ/DHytj8/hPGOcJg9W6QjA3Eo/xMfadjIBCRfjXKwn2LR6DuaC1bFMe40lyxmCoLWuXNaqC0sVWJQuGnmRENtlKtpK2RXFrEIKXuZR5PlPGoBJZKuCGMNFiUSX50DRo1W3zkYKPXe5KyB3rFgmnIALweHAsHJBa8+qvbu8qG0f+5Y3gkIKVY01TMoOwQ023rw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=KraDiBsPtW/5qsRQGD4muTqPq5mDALoHr8tGsweK3Wg=;
 b=lbFLt+L4p31hqf9jnHsdaU/V1GMSdznMtdmu7WmKlOAi4eZUXsReADKmcxA55gnQwvXFl2OHl6ukxgwExxCT/Xz9zPL9veNvXaagOCil9EMmqPpAf78waO8yiV6seUmCc7hTFBXeJXF2qLGNyTP2qCYPieGf7HVo5Sm3oERQoqTgw8iPVzSflVB2cnWdoYgSfkXUv2jax+MBZ43G00Y61t5UJoyIfB8G8+AwmN/GCDpre9EzgJvkO67pTxIEYmrdZkwYzhkQ1AExBFjLG3yKKr1f9fnyFJah4isYGf/MpgscuG3hrJ+0jIkWiaMQginfv+5tlbSRxPF71jWtec+zzw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <41828b2e-a824-fd3e-93d3-2de28a392b6d@suse.com>
Date: Thu, 3 Feb 2022 14:17:44 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v2 1/2] xen: add option to disable GNTTABOP_transfer
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220203131418.1319-1-jgross@suse.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220203131418.1319-1-jgross@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0602CA0011.eurprd06.prod.outlook.com
 (2603:10a6:203:a3::21) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7b3c76f6-76e5-4ef8-6bbb-08d9e71792d6
X-MS-TrafficTypeDiagnostic: AM7PR04MB6792:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<AM7PR04MB6792DE8EF4743B0502A41C9FB3289@AM7PR04MB6792.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7219;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	/ov5OEgvDXAYqj/kO5H2VOMf/HrKnHGas53U/0vccnzkeE4IKNkR0BK424LU54oLaXyvlaylO8M0dtJrEQp0+/oIjenOu5p6/fWjtHjeHfbAbPiCeWHI1jw3yR5ONbW9WSUUwLkilp3OAvz+9Wi+m6PBh5KNcSs7RFhtBMGw2+ix44tG2GeZeWN6tZSh0wsPZKg4fn3Abu2MJRYbQOJdJBiiPQOzgiqdfpmZwjAVde+I4BjtcJgCj+xDW4i83yD8zzwpgxFm4bDK5TsRYz4Nz+rt1amX5+N4u9fgEgxzlHtncKe09qM0makb1EXZHF9INxmFNICfPXi1+wuqXyRU5iwKg13Xnc/vNsY+nddTNGNYbhS3U4cCN9ccCcy8bxYu1Mij6acoDXGl6rX/O1Wi3NRfwYgRmp++yzQ34shPVEoyVzvy2JdSZIyFWClkQ4buKyYypcH5Q1yGl0ujG2lK40rHiNfxvFZqC8pGIYfdpbhmymfp0XKrHg5OzmTOjiyhfwlsL+fdx/vptd1KtYBvD4n8Xro3TAxxQ5uKApcdWx8F7wJeo0Nrrjf4bCJNl38GmTH57kWE+KRdcGi002x6x4Y7wD5fK0lZq/nW37mahIZAbGzfFSMIUIWPMY2izwtyU/F0EE+89kS/YY0dfyVPuqtFqg87qhK6sFUBUrn7SpPjqa0VpA3t+4hOLKgow147a6VB1ZSCQO1ueVKvxvkYv8cZTpWEd8YT88M9ofHDvc8=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2906002)(6636002)(86362001)(8936002)(36756003)(6862004)(4326008)(8676002)(186003)(26005)(2616005)(31696002)(31686004)(508600001)(66556008)(6666004)(6506007)(6512007)(4744005)(5660300002)(53546011)(37006003)(54906003)(38100700002)(66476007)(6486002)(66946007)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?QTYzejBaa2NBMnY1VVNsWVM0c0paZHc3dmErZldKUnl3QzNpQTNjcVUvdUVD?=
 =?utf-8?B?VWdlSGhQWDJRRFcrMFdCZC83WTdLZFhJTExhK3dwUU9CZWtBbUlGS2Ntbk0x?=
 =?utf-8?B?S3ZrLzZFQ0NHNFp2Wm9nQkF5bmRuSnUvZWRWQ1ptU3VjaEFybWwyTzJoWEdS?=
 =?utf-8?B?T3BOYTVNcnkrNFgzNlpETzhJeW5zWWlSQWttajJrNTZ4ZUhtRU95enpXQUtI?=
 =?utf-8?B?eXJtbGIwTlVBY1FMNHdwb0FVNlFXMXlsbEFCSXBxcVEwL01ab1JvczdxV0Zo?=
 =?utf-8?B?ZWRsbjFScHJJdUlaSjh1ZVhrRHFmV1lKb0dJNERmUm1zbE83NGhaanNpN3JE?=
 =?utf-8?B?TWN0Ty9yeUN3YkQxLzZ0ck5mNi90U3RCLzJNd2xxR05DSHBJN2d0c0g1cVQy?=
 =?utf-8?B?SWZBUG5MMW1ZOEJ5TFpaUjZmSURzWGpqT3l2UXQvVzZkQmxoVmNsa3BoMnRR?=
 =?utf-8?B?L0tJT0RkSEp3S09aTk1WQm9ualR2emhqOWxuam5LYVltVzk2cDNvUlAyL0I3?=
 =?utf-8?B?SkRnUFpyM2NTM1lVd0tGKzA1RmhqNng3cmpieHF1MC9hK3AwY2ZIdEVOMlJs?=
 =?utf-8?B?OE9HTU5YTXR6bWs4Tmk4SDAwMDJLeG9naUgyNmRoenlENVVuYnNmQzh6WTgr?=
 =?utf-8?B?QnYxSEZJV3ozT0hKdG5RYzNXdHFoMUw0L2RyZEM5SmhHanZZbUtzdWVIWS9P?=
 =?utf-8?B?YU9jTHVWZlplYTAwMlhwSEpDN2RVc3BFMmNvQmxDNGprajkxSnBpN0FLUXE2?=
 =?utf-8?B?TVhUNWZYd3N4SmVUVm8vMFFrV0dZUXRvVjRabHZVTE9WWXhNTUl3MWx2WkYx?=
 =?utf-8?B?V25zK3NPd2lxaDlOWTFOclJNZFBxN2laNkkyRTlpYmd2V1cvRjFhV1AzaHB5?=
 =?utf-8?B?b2ZsM3RKaWhBWHVDS24xQVpmZldHU0lGZHUzMUFXVVU0WGRZOWNBKzk1MERO?=
 =?utf-8?B?Tnk0ZTlUZHRpajBaNGVFanc3WmFrdXhybWw0cUwxVlBzRHh5dXFtV0drQ1dj?=
 =?utf-8?B?aHNoUklDRjR6bTBLcnZHS1ptWUJZbUR0MDNRWkZsbTE5M1NxUFp0a0U0Y1l6?=
 =?utf-8?B?RER6bnY1R3lSWDd3S2tDbHRaK3ZhQmhSUmpzRWFCZHhlMnRxbHR5dENOS280?=
 =?utf-8?B?RUd2N21hZm5aWHUyMVc3VDhmcEJ3Skg3S3pocngwenFvVStiMDl2cUJFTkFV?=
 =?utf-8?B?enQvamVWVEd5NFM1a21BaW1zZWY5OHlGcE5JU00xVHh4N1B0UmtaNHF1NUI2?=
 =?utf-8?B?aFVzOHQvRUtpMnBxOGwyTnpIbnVNZ3oyaUZmQ3luZUpCUjN5MUVkT2JWN0cw?=
 =?utf-8?B?UGlUV1ZnNHlEbFhaYy9PdTlJd3NpaHE3bUJiMlV2WXN0STNabmpiRmhLNm9i?=
 =?utf-8?B?b2Y5aUZLSjhzVGpjTzhTYlc3THRkdlZsQ1g1RGtaaGhwZUgzbGtGb3M0WDVy?=
 =?utf-8?B?SjNqY2taMlVkU1llblM1YVNONWgxdzVZcXc1MXltQloreHRpdXowQmh1ZEt2?=
 =?utf-8?B?MGlBV29OVnNsb3FENnFoeGpYU1lRZkl3QWZPYklXbXdPMDF5WXhSTmdiZ3RQ?=
 =?utf-8?B?OGVjaGF0TDZ1a0piTlZTRlFjcmd1VGxqVXVCTGFaNS9jVHFDVUs0NmpvSXZP?=
 =?utf-8?B?aUxHUWllYkVqYUJIUU9uQkhzaTlEbHJKMnNSRGVEb2l0dTZKRWZrWDhPM1JT?=
 =?utf-8?B?NThYaUN1YVlhb3hSTE1LZEEzNkN6Ry9oT2xTaXUzUHdadlhzczlIWmxrVVJR?=
 =?utf-8?B?Y0RlMnVxeUtyYzh2RWcrZEFERWpGUDRLaENGUzFKN1pmWmdUdTU4dkl2dEow?=
 =?utf-8?B?T05oSW0xZEFuME5TenB3a0RjSnZXb05YTTExdDBlc1gySG4zVURFdlNOenM3?=
 =?utf-8?B?U3dvWDMwMFZDSXA2ckgySjhSSktBQ0JvYkE1RFZhSEl0T1VieW9RcUFQS3hU?=
 =?utf-8?B?MEQwMVZDdE4zU0d1b2xORnRtMFQvL1B1MVd5eXBOZWIxOU1tRGt5RHltM09C?=
 =?utf-8?B?cVdpZ1ZaVFJBVSt3WkdUQm9LZ3huZWNoOVRndnIvZURwZU56bk10L1JHR3dk?=
 =?utf-8?B?SWx6V1RqWVcveVhjcmZlT0VwOC92U2hmOHFvYkxGdnNYZDM5YjF5TWJFT0t4?=
 =?utf-8?B?WFBGR0FScHRzS1lrcDA2ellibWo5bGxwcTcwYnZYUXA1TWxmUi9nWElZTWE4?=
 =?utf-8?Q?27T8Oq51tn/BewM1wJ4xYsc=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7b3c76f6-76e5-4ef8-6bbb-08d9e71792d6
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Feb 2022 13:17:48.5300
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tuIv1P+bH6EnIHIBH58d3OdOs21NCUOz4UH38iaR0Y72hXWnDK7KtMXx9f1VgwXFQsQU0BG5HgTSmStrVbMcjw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6792

On 03.02.2022 14:14, Juergen Gross wrote:
> The grant table operation GNTTABOP_transfer is meant to be used in
> PV device backends, and it hasn't been used in Linux since the old
> Xen-o-Linux days.
> 
> Add a command line sub-option to the "gnttab" option for disabling the
> GNTTABOP_transfer functionality.
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Thu Feb 03 13:30:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 03 Feb 2022 13:30:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264763.457980 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFcCF-0000Zs-CU; Thu, 03 Feb 2022 13:30:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264763.457980; Thu, 03 Feb 2022 13:30:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFcCF-0000Zl-9T; Thu, 03 Feb 2022 13:30:47 +0000
Received: by outflank-mailman (input) for mailman id 264763;
 Thu, 03 Feb 2022 13:30:46 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ArrP=SS=epam.com=prvs=403311c35b=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nFcCE-0000Zf-5c
 for xen-devel@lists.xenproject.org; Thu, 03 Feb 2022 13:30:46 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 70bafa1c-84f5-11ec-8f75-fffcc8bd4f1a;
 Thu, 03 Feb 2022 14:30:24 +0100 (CET)
Received: from pps.filterd (m0174677.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 213DKLPf003532;
 Thu, 3 Feb 2022 13:30:36 GMT
Received: from eur03-am5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2055.outbound.protection.outlook.com [104.47.8.55])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e0e15gg0b-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Thu, 03 Feb 2022 13:30:35 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by VI1PR03MB3535.eurprd03.prod.outlook.com (2603:10a6:803:2c::27)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Thu, 3 Feb
 2022 13:30:27 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6%3]) with mapi id 15.20.4951.012; Thu, 3 Feb 2022
 13:30:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 70bafa1c-84f5-11ec-8f75-fffcc8bd4f1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Q6ohaYmc7Ps/AZnEm2qJuGPsCwdZOYFUamjb2TInUjbXVztVMrxzHJUIEUCG+GO0U/JDbOR25lVfgJf1TV0dV5wP9/bdVqwMUzipoc8gSXMHJfH5WfNl//qwL9zcXS1l4rybB4qQ93tU7Mziybs+kQ/SMCBQzVkI1y+FvjEcejYbwrQgKj8SEreg8Ve0XTSl1sZZpDLqg9Jb6+o/6ngYBsd9TYoS7AUrVpBK6RMKN2GyeEEN1llLOe1flz0W1kDx07Ud7KNz+HK9f/Se5xZ5PRgIaJdOVyzh5jvSZpiHwkiCauTxPLlhc4TROFs/dX//2sowJiewKli8ncc2mrNwGw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=LspjNt9xzAvYju5tsYSAbGYqPXK/3dvEtZAVgtq5KV0=;
 b=jYQBCNPHtT8/7uA8iG5Z0xhv8TzHq/HzlfJER4Yxw36YYJ2VayhrlKyjBATE2X0yU93xYezTYh6hfwjE6WVEDQKHpSzFtx3wrmPum6XVLPVrwXcJ9W6/kJ8iGxa0XZMaSVJnyJrrCswbS8+srsnKcnsfPWsD3REmKUz3JLj1gpF5laUtlvlSKA1/TWFLolHchInLStk0ARfAvKrY1q55UIqbKN7PFwuE88r5ZrxmwWYVoFKYMzX8fxuHMoxS4FmEPvUczD1LcloiJP6uyJ0Blk2rnj0XWSg18pufEFTMbjKFzcobWWuefeVj26hA5L9ShGaX6ncbHi2vE9RSHujnqg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=LspjNt9xzAvYju5tsYSAbGYqPXK/3dvEtZAVgtq5KV0=;
 b=l/qTlX9AsvFzuNnc6iHOwF3lf0crvg3QThy305OyCpDDf9UCK27RRjTZxRqMliKzFLniLUL6URku/rR5oUifSXQMXXigN/bYIU/0gb2SYLY4xT6jToCOjyAr7VhZfzTbC7Rdh3UDpny65iS9+tku+7NcOIQuqIH4GVUN7SJmjkDEYVBLIKClaz7nCaZFeTdhKQN5YNsOIV2om1DcUy4ZkhuRvbWTLk/zK1SxG00VIPROLDUj+JX20Od+BrPz3Dm85lP5WM/giavC1IuVW5TYWD6NCPNKX0fHqBvOO6ergmYDodBucpkbYtc/MS4t0a7pP4wFEoSAXxVrhbuj2sKN+g==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?=
	<roger.pau@citrix.com>
Subject: Re: [PATCH v5 06/14] vpci/header: implement guest BAR register
 handlers
Thread-Topic: [PATCH v5 06/14] vpci/header: implement guest BAR register
 handlers
Thread-Index: AQHX4ewHyWAyD811HEGp8pIjUuVWNaxf8XWAgB1bfoCABObrAIAAAsYAgAAJ6wA=
Date: Thu, 3 Feb 2022 13:30:26 +0000
Message-ID: <0171761f-d90f-3e3a-5c8f-e32d70096e27@epam.com>
References: <20211125110251.2877218-1-andr2000@gmail.com>
 <20211125110251.2877218-7-andr2000@gmail.com> <Yd8RJfpEalnfl+CC@Air-de-Roger>
 <d493b022-3c78-1721-e668-48f4553056a9@epam.com>
 <df98cdbd-36fe-0386-c068-2a1540f10188@epam.com>
 <9c1f376a-0df3-67eb-7fd1-bb75ae130e77@suse.com>
In-Reply-To: <9c1f376a-0df3-67eb-7fd1-bb75ae130e77@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: e10c7963-192a-41fc-e0bb-08d9e7195704
x-ms-traffictypediagnostic: VI1PR03MB3535:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <VI1PR03MB3535CE41F1754697943C5E8FE7289@VI1PR03MB3535.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 sq+u1jcvUZBsn/BqCAkcXMyqYxSm4o9QkKIRoFlGcR19bcORu8sKOkThdt/9NgtEkYdDJBsIk8jqrGM/spulk2Utv5BcDBxG7aVcdJyWBR6SjPAQ56gFPu+zBEyWl9jfRK8SPOnERNo3ZJzopp9yUJhURU/7KwiydaR5tP5W8ev13m6uOC6PQxma+gVIzGTNiK0jiR6eb9TH93nRi5hs0BqGNJSv+qwH2W4W3xrbeWuLZZJ/MxzNtv8OPryMGr2LemwMZcLJUbBqeA7x3R4fnIc0+oqSbjsGC8GdBDGEDoP82ZfwHLemGPkEqrHLR2Z9OJATYx6WfPBT5QjwLLLkw8cL6MKmY2e4/m2r3SprJTGal3majTC3Lw5XCZqs7MJ+qN3zG+t1uYs5/JYubOb+pUpZ0DDerT5jIfxkc2WoP+ao7pTLz0d+2zOG8Zl0t1vdvZRjJkmbtSn9Ofq5S3MX30twsLDf2Ge3zQ6qQDGte1VBX4BaiWA5wxyyVyiVAgegRVxHYN0Z9kim6Hg6C074dMPUSc/Br40+b2Of4GPWTJgRxLk4jdVWv1dqfbaa0hxK0SS/kcSUCpbq18/4nJ7uKR/hAKKUfPbmXYQxXgGvdk98PAMsVMcBBJaZgcpagZ2khJkvENDoslihh1fKjJvmC+i9cCrEURNSDxbmuu2mvIvur2XiLMznazqoHuf504s5USgbwcInFpZM0T0ExzUPdZcB7bZIvEOoiBkuCM5k+3OfGEXLZftvn6UAKzKuNY6N
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(53546011)(26005)(186003)(38100700002)(31696002)(83380400001)(71200400001)(6506007)(6512007)(2616005)(36756003)(31686004)(6486002)(508600001)(76116006)(8936002)(122000001)(7416002)(91956017)(5660300002)(64756008)(66446008)(66476007)(66946007)(8676002)(4326008)(86362001)(66556008)(38070700005)(2906002)(316002)(54906003)(6916009)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?WG9mK2RGeGo3cC8yeXU1YVRzcnFFV1Zpajg2eFExeW5PN2thU1FNQVZVSXFV?=
 =?utf-8?B?dmRsQTBHU2FxVTAwUjZVMklodEdQK2xSWitOTFBRbU81WXVlQkJCSk1oNkh2?=
 =?utf-8?B?RHY0akJoN3B5MGhvT2xIN2tHRFFqTlMxZUVya0dDZ25DYUlGeHFOd0xlYmsv?=
 =?utf-8?B?dFpnMVBCQjFhNktpMW9jWEIrZERLd1ZkeW9NVEJqRUFZMzlSTXN0NXdtc1h0?=
 =?utf-8?B?NTF6ZW1LNHBxS09SRWhsSDBvN3krWjY3dXV1NGVmWFgxay9FTzhZSTBPdlBM?=
 =?utf-8?B?SUdiOWhKSVVFN1p6U0N2bS9wZWN0ZUVwMlgzbmZjc1N2anJhTnVVaGF3R2E4?=
 =?utf-8?B?dUVtelVSbURNNS9YdWdrb0RQNnYxL3F0SFdYd3pPSk5CVGxBWnVuODZjQk9i?=
 =?utf-8?B?QW0vOG5HMVdlOUlUQ01WRFJYb2NabjRUZTJJZ3llMFJjNy9meU43RTBabGRH?=
 =?utf-8?B?a3lxNWlubU9ETmpiTU00TDc3cDRhL2I5alVWbEdlVENSamJ5SzV3bnRvT0ta?=
 =?utf-8?B?aHRRVEVtNXM2OTFWM3gvUXhsb2huZmdmOHpOVU1jQWVOallPdEErUkc2ZmNl?=
 =?utf-8?B?ekhFQUR1TnBOU29BVVlOMkJjcWRtWFBZSWxIaitpcDdyWVNZak10STA4VlhL?=
 =?utf-8?B?b1Bia2IrVFY2WVlGVkF5bHhWdUpELzcyLzIxamZsS1RQK2V0MjgvYlJNbW5a?=
 =?utf-8?B?clk3bmFGSHN2S0ZBNWpBSlFRczFIZDBNUW9tT1ZnR3RuTkthNFp5a3pTYXA4?=
 =?utf-8?B?cGpSaTQ1OWZFUmZqSTRHaTZvNUE0WHE4SE9EazROdUNuZVdLVHBhMTdLMjZJ?=
 =?utf-8?B?SGpUOWhyNDR6cmFsanJacFIzcFN5bDVVQkRxZHdZeFlJbGRvd3FTMDVJRHRk?=
 =?utf-8?B?TUhCc2JhLzRtYXhZRTB3VFYvWUorNTJ2dzlmMm42WW1tdUZ3S0JOQ2hyQWFm?=
 =?utf-8?B?SloxVkNjSW5lWEZkRVJ2R0NrcmZzSDB6VEl5SzdneUN5Sk50dy83ckNORlBw?=
 =?utf-8?B?ZUJuWFRxMU5PNWlsT2xjVDh3eklqK08yM0cvTHZOcVo5R1d1UkdQelZpNkZG?=
 =?utf-8?B?bU9FZC9oM1RvbmJmdjJUNEJNTmQrRFR5REQ2MnFSWFpxNUUrS01xeWdxQUY5?=
 =?utf-8?B?N1dOd0RVWmZPTDdNdjZKNHp6UVlmTjdpZ1RZbnhKRmhsNWgvMWUvdkxsdktQ?=
 =?utf-8?B?NjdRQ3VaQnhFelpnWGVGNGJodkFNdXJhL1Ntekp0Z1NHZ09YOTZVZEZpMXdT?=
 =?utf-8?B?SWtIc0YreWg1bkxaSjdLRERhcTFHWWFQaS9uOGdjclYyejVKZlBXVldBS1Vr?=
 =?utf-8?B?MnY2WnVrY1dpYXhWSUpBZUxwalducHJ6ZXNtQXJ3dHl1YUNoTkR0TzVnODV3?=
 =?utf-8?B?M2JJdCt3M3A5VW9IRDY2WTRKK0F0RWp0RkVpR0h1aGI1d1NZSmZmYlNsQSth?=
 =?utf-8?B?eWNUMWJ0NXk2NGdyMkF4SlU1enNyQWVBTEVCZEJqazBRbWhhZHFvUFFUeXpD?=
 =?utf-8?B?VkhDTFJkSTczZGlTYnFHeDdBL1h0eFYwelhZL0l3aVpPT3E0Rk05VGZBa1BG?=
 =?utf-8?B?dWVyVUlmUzZlQlBzaTBLWDNOSkRMWDF3UlFVUFNzdmFaZXBGTVFMd1F3UEI2?=
 =?utf-8?B?dk9FWG9lMHhURXdFc0p0YVRXY2RUc1ZydHFoSUhlRkJsR3BCVWpOdmtSbGtL?=
 =?utf-8?B?WEZ2L2xOQ0NYTm9NNndOYWh3N2tiSmFmdlIzWUVHWjFjb1RpOUZya1F5MzZv?=
 =?utf-8?B?U0pTWFExM0xnSUNkRmYxdXJZQmcyRFhEdUk2NjNackVjOCtZQTMrM0FpYmpM?=
 =?utf-8?B?ck5zUk5oUmRtZkJ2OGNKT1dYZlA3QjI2RXpyVWJwRW9IOG1uWVhUS2huK2VZ?=
 =?utf-8?B?R3J6dENseThOVEhuQll3bUZKOGVBNkUraHM4Z2kzNWMwcjJUdmowbkdzTjg0?=
 =?utf-8?B?MUUrMitubkJ5RVZ2TmtOcmQvMGVjVEszamxNc2lvYVVZcXJEcUd5WDU5OWJo?=
 =?utf-8?B?TjQ5Q25IdVdNeHJZYkNLWlZmbGxpTkYySlVicTBsRG5OTFVMcitXY0dmUE52?=
 =?utf-8?B?ZGV6a0dQZ0xyeWkwWVFDNjZDNVBxeHZZUVBGemxrTU04bG9pVnFyRUM4QXUx?=
 =?utf-8?B?N0xzY0ZpZWtvWWlYOEdOZTA2UU9PbzNmRmZBTWY5aWNqWkVPYjM3aTRRRFh3?=
 =?utf-8?B?citRSVo4NlI3SDFTNU9oQ2ZnV0V4VXg3K1BGN1ovbFBJUnZRWjR0cllGTHF4?=
 =?utf-8?B?YTYxSTJuWFUyTXNrL1hOV1BYTDhJTGlJREk3elF5NnlmL3l5QVo0blBKcnNC?=
 =?utf-8?B?czRXL1E1VWV2ejZsd2NvckI2VDV6bG9tdDJSR2NKZzNhT2RNekNPZz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <31832C7A64899A4880E4664258B371AC@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e10c7963-192a-41fc-e0bb-08d9e7195704
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Feb 2022 13:30:26.8522
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ET0Ud20ZZE6SCvaAjvCeOcBQDvmdDQ/pss5gp+qkSwtvVUIwABcolirUbAOvIJM0GcYtVSpQT3aIXun1N9cs5hJR34YFRltcN7/wiPEiDRangzfBhiVwNH3ZfnFX6k4w
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR03MB3535
X-Proofpoint-GUID: 79dOpfZwELa0g0h0lZpFhq1xCL5hBoIF
X-Proofpoint-ORIG-GUID: 79dOpfZwELa0g0h0lZpFhq1xCL5hBoIF
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-03_04,2022-02-03_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0
 priorityscore=1501 suspectscore=0 lowpriorityscore=0 mlxlogscore=999
 mlxscore=0 bulkscore=0 phishscore=0 impostorscore=0 clxscore=1015
 adultscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2201110000 definitions=main-2202030084

DQoNCk9uIDAzLjAyLjIyIDE0OjU0LCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMDMuMDIuMjAy
MiAxMzo0NSwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+Pj4+IEFsc28gbWVtb3J5
IGRlY29kaW5nIG5lZWRzIHRvIGJlIGluaXRpYWxseSBkaXNhYmxlZCB3aGVuIHVzZWQgYnkNCj4+
Pj4gZ3Vlc3RzLCBpbiBvcmRlciB0byBwcmV2ZW50IHRoZSBCQVIgYmVpbmcgcGxhY2VkIG9uIHRv
cCBvZiBhIFJBTQ0KPj4+PiByZWdpb24uIFRoZSBndWVzdCBwaHlzbWFwIHdpbGwgYmUgZGlmZmVy
ZW50IGZyb20gdGhlIGhvc3Qgb25lLCBzbyBpdCdzDQo+Pj4+IHBvc3NpYmxlIGZvciBCQVJzIHRv
IGVuZCB1cCBwbGFjZWQgb24gdG9wIG9mIFJBTSByZWdpb25zIGluaXRpYWxseQ0KPj4+PiB1bnRp
bCB0aGUgZmlybXdhcmUgb3IgT1MgcGxhY2VzIHRoZW0gYXQgYSBzdWl0YWJsZSBhZGRyZXNzLg0K
Pj4+IEFncmVlLCBtZW1vcnkgZGVjb2RpbmcgbXVzdCBiZSBkaXNhYmxlZA0KPj4gSXNuJ3QgaXQg
YWxyZWFkeSBhY2hpZXZlZCBieSB0aGUgdG9vbHN0YWNrIHJlc2V0dGluZyB0aGUgUENJIGRldmlj
ZQ0KPj4gd2hpbGUgYXNzaWduaW5nwqAgaXQgdG8gYSBndWVzdD8NCj4gSWlyYyB0aGUgdG9vbCBz
dGFjayB3b3VsZCByZXNldCBhIGRldmljZSBvbmx5IGFmdGVyIGdldHRpbmcgaXQgYmFjayBmcm9t
DQo+IGEgRG9tVS4gV2hlbiBjb21pbmcgc3RyYWlnaHQgZnJvbSBEb20wIG9yIERvbUlPLCBubyBy
ZXNldCB3b3VsZCBiZQ0KPiBwZXJmb3JtZWQuIEZ1cnRoZXJtb3JlLCAoYWdhaW4gaWlyYykgdGhl
cmUgYXJlIGNhc2VzIHdoZXJlIHRoZXJlJ3Mgbm8NCj4ga25vd24gKHN0YW5kYXJkKSB3YXkgdG8g
cmVzZXQgYSBkZXZpY2UuIEFzc2lnbmluZyBzdWNoIHRvIGEgZ3Vlc3Qgd2hlbg0KPiBpdCBwcmV2
aW91c2x5IHdhcyBvd25lZCBieSBhbm90aGVyIG9uZSBpcyByaXNreSAoYW5kIGhlbmNlIG5lZWRz
IGFuDQo+IGFkbWluIGtub3dpbmcgd2hhdCB0aGV5J3JlIGRvaW5nKSwgYnV0IG1heSBiZSBhY2Nl
cHRhYmxlIGluIHBhcnRpY3VsYXINCj4gd2hlbiBlLmcuIHNpbXBseSByZWJvb3RpbmcgYSBndWVz
dC4NCj4NCj4gSU9XIC0gSSBkb24ndCB0aGluayB5b3UgY2FuIHJlbHkgb24gdGhlIGJpdCBiZWlu
ZyBpbiBhIHBhcnRpY3VsYXIgc3RhdGUuDQpTbywgeW91IG1lYW4gc29tZXRoaW5nIGxpa2U6DQoN
CmRpZmYgLS1naXQgYS94ZW4vZHJpdmVycy92cGNpL2hlYWRlci5jIGIveGVuL2RyaXZlcnMvdnBj
aS9oZWFkZXIuYw0KaW5kZXggNzY5NTE1OGU2NDQ1Li45ZWJkNTc0NzJkYTggMTAwNjQ0DQotLS0g
YS94ZW4vZHJpdmVycy92cGNpL2hlYWRlci5jDQorKysgYi94ZW4vZHJpdmVycy92cGNpL2hlYWRl
ci5jDQpAQCAtODA4LDYgKzgwOCwxNCBAQCBzdGF0aWMgaW50IGluaXRfYmFycyhzdHJ1Y3QgcGNp
X2RldiAqcGRldikNCiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcmV0dXJuIHJjOw0KIMKgwqDC
oMKgIH0NCg0KK8KgwqDCoCAvKg0KK8KgwqDCoMKgICogTWVtb3J5IGRlY29kaW5nIG5lZWRzIHRv
IGJlIGluaXRpYWxseSBkaXNhYmxlZCB3aGVuIHVzZWQgYnkNCivCoMKgwqDCoCAqIGd1ZXN0cywg
aW4gb3JkZXIgdG8gcHJldmVudCB0aGUgQkFSIGJlaW5nIHBsYWNlZCBvbiB0b3Agb2YgYSBSQU0N
CivCoMKgwqDCoCAqIHJlZ2lvbi4NCivCoMKgwqDCoCAqLw0KK8KgwqDCoCBpZiAoICFpc19od2Rv
bSApDQorwqDCoMKgwqDCoMKgwqAgcGNpX2NvbmZfd3JpdGUxNihwZGV2LT5zYmRmLCBQQ0lfQ09N
TUFORCwgY21kICYgflBDSV9DT01NQU5EX01FTU9SWSk7DQorDQogwqDCoMKgwqAgcmV0dXJuIChj
bWQgJiBQQ0lfQ09NTUFORF9NRU1PUlkpID8gbW9kaWZ5X2JhcnMocGRldiwgY21kLCBmYWxzZSkg
OiAwOw0KIMKgfQ0KIMKgUkVHSVNURVJfVlBDSV9JTklUKGluaXRfYmFycywgVlBDSV9QUklPUklU
WV9NSURETEUpOw0KDQo+IEphbg0KPg0KVGhhbmsgeW91LA0KT2xla3NhbmRy


From xen-devel-bounces@lists.xenproject.org Thu Feb 03 13:38:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 03 Feb 2022 13:38:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264770.457991 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFcK1-0001Iz-5Z; Thu, 03 Feb 2022 13:38:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264770.457991; Thu, 03 Feb 2022 13:38:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFcK1-0001Is-0h; Thu, 03 Feb 2022 13:38:49 +0000
Received: by outflank-mailman (input) for mailman id 264770;
 Thu, 03 Feb 2022 13:38:47 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Ap74=SS=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nFcJz-0001Im-5n
 for xen-devel@lists.xenproject.org; Thu, 03 Feb 2022 13:38:47 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9a8eeff7-84f6-11ec-8eb8-a37418f5ba1a;
 Thu, 03 Feb 2022 14:38:45 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9a8eeff7-84f6-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1643895525;
  h=from:to:cc:subject:date:message-id:mime-version:
   content-transfer-encoding;
  bh=HHOX/WHyplwxog3uWsB8rHIhKz2K06Z2bGy3CpsQCGs=;
  b=GCUSweDiQ8jUtJpLzMES2MdDsHXAe1eXBb9lar4l3cG+rvGCPX+KwoUz
   Nz8JLJJV+Pv+oVSGQLi7tmM2J30t7GfW7c78Nye81jgIMMo8ytsD7a9fg
   RWs+41h4T0pxaaV1Ab66/HfJ6CnPS7s6PlRvrE/PyahiTWuKMPTbFZ3e8
   U=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: QNYqSAQOvwMYcAlKDavaPrinwxMRn/Ntfg7OeX/VIHZClDs1krAywSzmTtq73N7Fb4WObymhkz
 FiUUplptly5x5ugQN0uXUcB2iA8Sqeh7FUzhySlqBqn9dPjJsZUZUOmtx90Lk3uMyOH3IPPV3i
 5MGCapNmD3t9vGqBy2NfqmkuU5s/ctYbJ8v8KsXoYmSBoX3joIIuOwHd6HI05drLW8PnpxXc60
 k8f/Hwvnjd07dbvBjsa9THKrELvllFcQgF4r2RUjWrepVUU8vMtk1JIRtRKBt64prV9FIKez3g
 XPF4CZfeIg0t7/xij/5cJlXV
X-SBRS: 5.2
X-MesageID: 63817204
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:W2lH7aLKJ11WYOivFE+RZJIlxSXFcZb7ZxGr2PjKsXjdYENS0jICy
 mBOWG7Qa/3ZY2Xzft90OoS09EkF6MDcyoIyHQNlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokcxIn5BC5C5xZVG/fjgqoHUVaiUakideSc+EH170Ug7wLZj6mJVqYPR7z2l6
 IuaT/L3YDdJ6xYsWo7Dw/vewP/HlK2aVAIw5jTSV9gS1LPtvyB94KYkDbOwNxPFrrx8RYZWc
 QphIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbrGvaUXe345iXMfwZ3u7hB3Swopb6
 /hGhaCScgt4B/DXh+knbwJXRnQW0a1uoNcrIFC6uM2XiUbHb2Ht07NlC0Re0Y8wo7gtRzsUr
 LpBdW5LPkvra+GemdpXTsFFgMg5IdatF4QYonx6lhnSDOo8QICFSKLPjTNd9Glr1pkRR66CD
 yYfQQFJchnMTx9QBl00LpIjktmBqEHaYTIN/Tp5ooJoujOOnWSdyoPFMsfRe9GMbdVYmACfv
 G2u11r+BhYWJdmO0w2v+3inhvLMtS7jUYdUH7q9ntZgjUeP3GUVBFsTXEGivPiiokekXpRUL
 El80jUqhbg/8gqsVNaVdw21pjuIswARX/JUEvYm80edx6zM+QGbC2MYCDlbZ7QOluU7WDgr3
 V+hhM7yCHpkt7j9YWmG6r6eoDe2OC4UBWwPfykJSU0C+daLnW0opkuRFJA5Svfz14CrX2Grq
 9yXkMQgr+5O1+Qo+q6LwXL8j2OV+4PWQzQJ/QqCCwpJ8ThFTIKiYoWp733S4vBBMJuVQzG9g
 ZQUpySNxLtQVM/QzURhVM1IRej0vKjdbFUwlHYyR8FJyti7x5K0kWm8ChlaLVwhDMsLcCSBj
 KT76VIIv8870JdHgMZKj2ON5yYCkPCI+TfNDKm8gj9yjn5ZLlTvEMZGPhb44owVuBJw+ZzTw
 L/CGSpWMV4UCL580B29TPoH3Lkgy0gWnD2PHsCgkkr6gOHBPxZ5rIvp1nPUNYjVC4vf+G3oH
 yt3bZPWm32zrsWiCsUozWLjBQ9TdiVqbXwHg8dWavSCMmJb9JIJUJfsLUcaU9U9xcx9z76Ql
 lnkAxMw4Aeh2RXvdFvbAlg+OOKHdcsu9hoTYH1zVWtELlB+O+5DGo9FKctuFVTmncQ+pcNJo
 w4tIJTdW6kfF2icplzwr/DV9eRfSfhivirWVwLNXdT1V8Q5L+AQ0tO7LAbp6gcUCS+76Zk3r
 7G6j1uJSpsfXQVySs3Rbav3nV+2uHEcnsN0XlfJfYYPKBm9rtAyJnyjlOIzLuENNQ7HmmmQ2
 TGJDEpKvuLKuYI0roXE3PjWs4ezHuJiNUNGBG2Hv62uPCzX8zP7k49NWeqFZx7HU2bw9Pnwb
 OlZ1aikYvYGgExLo8x3FLMylfAy4N7mprl7yAV4HSqUMwT3W+04enTfhJtBrKxAwLNdqDCaY
 EPX94kII6iNNePkDEUVeFgvYNOc2KxGgTLV9/k0fhn3vXcl4LqdXExOFBCQkygBfqBtOYYoz
 Op96s4b7wuz1kgjPtqc130G8m2NKjoLUrk9t4FcC4ju01J5xlZHaJ3aKyn3/JDQNIkcbhh0e
 meZ1PjYmrBR5kveaH5iR3HC0N1UiYkKpB0XnkQJIE6Em4adi/I6tPGLHe/bkuiBIs177t9O
IronPort-HdrOrdr: A9a23:fYz76KBlZYCf/dLlHemi55DYdb4zR+YMi2TC1yhKKCC9Ffbo8f
 xG/c5rsiMc5wxhO03I9eruBEDiewK5yXcW2/hyAV7KZmCP0wHEQL2KhbGSugEIcBefygcy78
 ldmtBFebjNMWQ=
X-IronPort-AV: E=Sophos;i="5.88,340,1635220800"; 
   d="scan'208";a="63817204"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>
Subject: [PATCH] xen: Modify domain_crash() to take a print string
Date: Thu, 3 Feb 2022 13:38:29 +0000
Message-ID: <20220203133829.7913-1-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

There are two problems with domain_crash().

First, that it is frequently not preceded by a printk() at all, or that it is
only preceded by a dprintk().  Either way, critical diagnostic is omitted for
an event which is fatal to the guest.

Second, the embedded __LINE__ is an issue for livepatching, creating unwanted
churn in the binary diff.  This is the final __LINE__ remaining in
livepatching-relevant contexts.

The end goal is to have domain_crash() require a print string which gets fed
to printk(), making it far less easy to omit relevant diagnostic information.

However, modifying all callers at once is far too big and complicated, so use
some macro magic to tolerate the old API (no print string) in the short term.

Adjust two callers in load_segments() to demonstrate the new API.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>
CC: Stefano Stabellini <sstabellini@kernel.org>
CC: Julien Grall <julien@xen.org>
CC: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
CC: Bertrand Marquis <bertrand.marquis@arm.com>

Supersedes my previous attempt to update every caller in one go.  In due
course I'll split that mammoth patch up into a series.
---
 xen/arch/x86/domain.c   | 14 ++++----------
 xen/include/xen/sched.h | 13 +++++++++----
 2 files changed, 13 insertions(+), 14 deletions(-)

diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c
index ef1812dc1402..45be5e1cd7c9 100644
--- a/xen/arch/x86/domain.c
+++ b/xen/arch/x86/domain.c
@@ -1693,11 +1693,8 @@ static void load_segments(struct vcpu *n)
                  put_guest(uregs->fs,   esp - 5) |
                  put_guest(uregs->es,   esp - 6) |
                  put_guest(uregs->ds,   esp - 7) )
-            {
-                gprintk(XENLOG_ERR,
-                        "error while creating compat failsafe callback frame\n");
-                domain_crash(n->domain);
-            }
+                domain_crash(n->domain,
+                             "Error creating compat failsafe callback frame\n");
 
             if ( n->arch.pv.vgc_flags & VGCF_failsafe_disables_events )
                 vcpu_info(n, evtchn_upcall_mask) = 1;
@@ -1732,11 +1729,8 @@ static void load_segments(struct vcpu *n)
              put_guest(uregs->ds,   rsp -  9) |
              put_guest(regs->r11,   rsp - 10) |
              put_guest(regs->rcx,   rsp - 11) )
-        {
-            gprintk(XENLOG_ERR,
-                    "error while creating failsafe callback frame\n");
-            domain_crash(n->domain);
-        }
+            domain_crash(n->domain,
+                         "Error creating failsafe callback frame\n");
 
         if ( n->arch.pv.vgc_flags & VGCF_failsafe_disables_events )
             vcpu_info(n, evtchn_upcall_mask) = 1;
diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
index 37f78cc4c4c9..38b390d20371 100644
--- a/xen/include/xen/sched.h
+++ b/xen/include/xen/sched.h
@@ -736,10 +736,15 @@ void vcpu_end_shutdown_deferral(struct vcpu *v);
  * from any processor.
  */
 void __domain_crash(struct domain *d);
-#define domain_crash(d) do {                                              \
-    printk("domain_crash called from %s:%d\n", __FILE__, __LINE__);       \
-    __domain_crash(d);                                                    \
-} while (0)
+#define domain_crash(d, ...)                            \
+    do {                                                \
+        if ( count_args(__VA_ARGS__) == 0 )             \
+            printk("domain_crash called from %s:%d\n",  \
+                   __FILE__, __LINE__);                 \
+        else                                            \
+            printk(XENLOG_G_ERR __VA_ARGS__);           \
+        __domain_crash(d);                              \
+    } while ( 0 )
 
 /*
  * Called from assembly code, with an optional address to help indicate why
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Thu Feb 03 13:48:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 03 Feb 2022 13:48:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264778.458001 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFcTJ-0002rP-36; Thu, 03 Feb 2022 13:48:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264778.458001; Thu, 03 Feb 2022 13:48:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFcTJ-0002rI-0F; Thu, 03 Feb 2022 13:48:25 +0000
Received: by outflank-mailman (input) for mailman id 264778;
 Thu, 03 Feb 2022 13:48:23 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nFcTH-0002rC-KI
 for xen-devel@lists.xenproject.org; Thu, 03 Feb 2022 13:48:23 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nFcTH-0006lu-40; Thu, 03 Feb 2022 13:48:23 +0000
Received: from 54-240-197-231.amazon.com ([54.240.197.231] helo=[10.7.236.11])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nFcTG-0006qW-TH; Thu, 03 Feb 2022 13:48:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=IPEnVc8uiuVpQx36uc7O4QQ1mw9c3xlX/S0zt16aMBg=; b=zmIfi7Jn3m0+QONoW8KUG+8ltI
	RlilTlrT4LSKIhVxmNMRoPU91eQNFg7BzHACIND7uRuylHKieRl7vqzsnQcttNqvXKG4TBGcihIhx
	C2u9sbWSKpOY5pSTl1qL3ecw4RlH6QxRAeYR8iLtL7BCcIO3TL94n94E7gDJdlP09LoU=;
Message-ID: <c0d82900-64d1-fe16-9283-deb7c324ff8a@xen.org>
Date: Thu, 3 Feb 2022 13:48:20 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.1
Subject: Re: [PATCH] xen: Modify domain_crash() to take a print string
To: Andrew Cooper <andrew.cooper3@citrix.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
Cc: Jan Beulich <JBeulich@suse.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Wei Liu <wl@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <20220203133829.7913-1-andrew.cooper3@citrix.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220203133829.7913-1-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 03/02/2022 13:38, Andrew Cooper wrote:
> diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
> index 37f78cc4c4c9..38b390d20371 100644
> --- a/xen/include/xen/sched.h
> +++ b/xen/include/xen/sched.h
> @@ -736,10 +736,15 @@ void vcpu_end_shutdown_deferral(struct vcpu *v);
>    * from any processor.
>    */
>   void __domain_crash(struct domain *d);
> -#define domain_crash(d) do {                                              \
> -    printk("domain_crash called from %s:%d\n", __FILE__, __LINE__);       \
> -    __domain_crash(d);                                                    \
> -} while (0)
> +#define domain_crash(d, ...)                            \
> +    do {                                                \
> +        if ( count_args(__VA_ARGS__) == 0 )             \
> +            printk("domain_crash called from %s:%d\n",  \
> +                   __FILE__, __LINE__);                 \

I find a bit odd that here you are using a normal printk but...


> +        else                                            \
> +            printk(XENLOG_G_ERR __VA_ARGS__);           \

here it is XENLOG_G_ERR. In fact, isn't it ratelimited? If so, wouldn't 
it be better to only use XENLOG_ERR so they can always be seen? (A 
domain shouldn't be able to abuse it).

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Feb 03 13:50:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 03 Feb 2022 13:50:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264784.458012 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFcVl-0004BC-Hc; Thu, 03 Feb 2022 13:50:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264784.458012; Thu, 03 Feb 2022 13:50:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFcVl-0004B5-E7; Thu, 03 Feb 2022 13:50:57 +0000
Received: by outflank-mailman (input) for mailman id 264784;
 Thu, 03 Feb 2022 13:50:55 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mjBt=SS=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nFcVj-0004Az-LB
 for xen-devel@lists.xenproject.org; Thu, 03 Feb 2022 13:50:55 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4d56dad6-84f8-11ec-8eb8-a37418f5ba1a;
 Thu, 03 Feb 2022 14:50:54 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4d56dad6-84f8-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1643896254;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=TH0YcttGKgnOP31CS0AleWw3PvS2sNL7rFM1UKVRy1o=;
  b=cIJlIH2b2MAAuJH/IMmn7ghLOMTTk14fOaQmNb1ifzMMAqIlbncIPDX6
   Zhx8vRYzQC/+7boy0Zs/JKXehDTyZa0aY34PzuymhVytw2Us5L+xFSbs7
   1VxzyMqhsdbN3mufJ7sh6HIxXmTKFGLh1My2Zt/7idEdQePrZV5w2CjbB
   A=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: R169npPNz6+bqMpH37TtUfVe26HslTAQ4nRe3FmxXcUMW1daKJ5uaOC8gM1Lz+Xg8fSQxX5CQm
 XfqfZ5ysXpWyFeZ7GZks80KWXj96K4l5K16aBN29mkC99F3Y4/Rm0LUf+K10vULASAFbuOmf/G
 E9XiB8rJapjjNNUA6Bryob0smWma4l4yof40il7PyH/v4haoUuFhCq7SJ7K05G5gxm8CiGn4Ku
 M5DOL012vL32Mb1LbFyseqox/c4vcamLUpcLuptNBrRumvH7JMXuT3eBqrmkgvhpI0eSHtp+y7
 O9NstBOCiGgsZVEtjhTkiFXS
X-SBRS: 5.2
X-MesageID: 63818176
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:clEjcq0/Xmu88UmXPvbD5SJ2kn2cJEfYwER7XKvMYLTBsI5bpzFTn
 2dOCDqHaKrYZ2L1LtwjO43i8UNT78PTnIVnTgNppC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkS5PE3oHJ9RGQ74nRLlbHILOCanAZqTNMEn9700o5w7Vh2OaEvPDia++zk
 YKqyyHgEAfNNw5cagr4PIra9XuDFNyr0N8plgRWicJj5TcypFFMZH4rHomjLmOQf2VhNrXSq
 9Avbl2O1jixEx8FUrtJm1tgG6EAaua60QOm0hK6V0U+6/TrS+NbPqsTbZIhhUlrZzqhsoBOz
 OxRq6aMZ0QABfaRvuk2SCd4DHQrVUFG0OevzXmXtMWSywvNcmf2wuUoB0YzVWEa0r8pWycUr
 6VecW1TKEDY7w616OvTpu1EnMMsIdOtJIoCknph0SvYHbAtRpWrr6Diu4QIhWdp2Z4m8fD2O
 s8JLgZVfAn8XTJJYFYaDZEcksWziSyqG9FfgA3M/vdmi4TJ9yRz36LqK8H9YcGRSINemUPwj
 nLL+SH1Dw8XMPSbyCGZ6TS8i+nXhyT5VYkOUrqi+ZZCglee22gSAx0+TkagrL+yjUvWc81bA
 1wZ/Gwpt6dayaCwZoCjBVvi+ifC50NCHYoLewEn1O2T4oeE3AKgGnY+chACQed96ek7bicU9
 kDcyrsFGgdTmLGSTHuc8JKdojWzJTUZIAc+WMMUcecWy4K9+d9u13ojWv4mSffo1YOtRVkc1
 hjX9HBWulkFsSIcO0xXF3jjiinkmJXGRxVdCu7/DjP8tVMRiGJIiuWVBbnnARRocd7xorqp5
 iFsdy2iAAYmV8rleMulG71lIV1Rz6zZWAAweHY2d3Xbyxyj+mS4Yadb6yxkKUFiP64sIGG1O
 x+I5F0MtcQMZxNGiJObharrUKzGKoC7TbzYug38NIISMvCdiifblM2RWaJg9z+0yxV9+U3OE
 ZyabdytHR4n5VdPl1KLqxMm+eZznEgWnDqLLbiilkjP+efAOBa9FOlUWHPTPrFRxP7V+239r
 ocAX/ZmPj0CCoUSlAGNr95KRb3LRFBmba3LRzt/Lb/ee1c2RT16Vpc8A9oJIuRYokicrc+Rl
 lmVUU5E0lvvw3rBLASBcHd4b73zG514qBoG0eYEZz5EAlAvPtSi6rkxbZwyceV1/eBv16csH
 fIEZ9+BErJETTGeo2YRapz0rYpDchW3hF3RY3r5MWZnJ5MwFRbU/tLEfxf08HVcBCSAqsZj8
 aar0RnWQMRfSl06XtrWcv+m03i4oWMZxLBpR0LNL9QKIBfs/YFmJjbflPgyJ81QexzPyiHDj
 1SdAAsCpPmLqIgwqYGbiaeBpoavMu1/AksFQDWLsefobXHXpzPxz5VBXeCEeSHmeFn1oKjyN
 /9Iy/zcMeEcmAoYuYRLDLs2n7k14MHipuEGw108TmnLdVmiFphpPmKCgZtUrqRIy7JU5Vm2V
 0aI9oUIMLmFIpq4QlsYJQ5jZeWfz/AE3DLV6K1tckn94SZ2+puBUFlTYEbQ2HAMcuMtPdN32
 /olte4X9xe720gjPduxhyxJ83iBcy4bWKI9u5BGWILmh2LHEL2ZjUAw3sMu3KyyVg==
IronPort-HdrOrdr: A9a23:m0nguqj0OsSaZh7Y2Hhbd+ktm3BQXzh13DAbv31ZSRFFG/FwyP
 rAoB1L73PJYWgqNU3I+ergBEGBKUmskqKdxbNhR4tKPTOWw1dASbsN0WKM+UyDJ8STzJ856U
 4kSdkCNDSSNykFsS+Z2njALz9I+rDum8rJ9ITjJjVWPHlXgslbnnhE422gYytLrWd9dP4E/M
 323Ls6m9PsQwVeUu2LQl0+G8TTrdzCk5zrJTYAGh4c8QGLyRel8qTzHRS01goXF2on+8ZpzU
 H11yjCoomzufCyzRHRk0fV8pRtgdPkjv9OHtaFhMQ5IijlziyoeINicbufuy1dmpDl1H8a1P
 335zswNcV67H3cOkmzvBvWwgHllA0j7nfzoGXo9kfLkIjcfnYXGsBBjYVWfl/y8Ew7puxx16
 pNwiawq4dXJQmoplWz2/H4EzVR0makq3srluAey1ZFV5EFVbNXpYsDuGtIDZY7Gj7g4oxPKp
 gjMCjl3ocWTbqmVQGYgoE2q+bcHUjbXy32D3Tqg/blnQS/xxtCvgklLM92pAZ1yHtycegA2w
 3+CNUZqFh5dL5iUUtMPpZxfSKJMB2/ffvtChPlHb21LtBPB5ryw6SHkondotvaPKA18A==
X-IronPort-AV: E=Sophos;i="5.88,340,1635220800"; 
   d="scan'208";a="63818176"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=WYwEafNT7zZ5edQjBTHcc5JVQ0gdvPopmzeKSUX/sU7rMbCPkqNsaNwUzi494Z9toPXOmX1X90Wt2m1bclF4+drycUFC4TNLXqDBaJOSIk4dbX0NfM90KumjneED8y9+ZXMJErXtY1YcOH8lbfEtG9UIvySjB5qLIXJsmbFeJpG6gBxwbbvz4UugUNq/rFtIVr7ZZIo4ST3XHLqpfDZ6u8GpqGHj6WyIVSg9lHX16kd/Xf7/pCDQcNGbAjvX5bUGaTm86NPjVuDGIamVd6Mwyqn62FLpOKwGOLiSMJ48E8ztSd+bM78TfY/ZA2yxLGu1ujkHtFhyS9TZncN0RdHB1w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=24HJAMn6dwns7ZrlAtR65gk3ceNBsb4qPm0v4UZ40f0=;
 b=kusBJYKW/18U7bD90QjBwucF24lizSyFZ25BHE8tw+02bIkq2JdBL5sFo2rxxHPLk708OHA2otmtm/XE62/EceXqnvKnAYUdC/1UuMlhLH3veN2DkOi+CsVz/Dy5P9seEEkRJ+MjDRHkABxtvF+wWztZpx56Zoug3gpMZJzaxlDdUPYSiT74C5ZKc8SlorHJOtd5E57Hh22OLjbjAulPf9wHnKsCLVa/5uSOwMejwGx9bo41W8J4VLPj8/ysdih/C9p4O+I+B7jRbLzDfQaESAzd3HRfrwCWlmB2M1mZ4XluSanyhPiIRCOllrSLA54Quh3f4D78bLU5l3j6V6ct5g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=24HJAMn6dwns7ZrlAtR65gk3ceNBsb4qPm0v4UZ40f0=;
 b=YM5aa32vB57FV7WcZpCN7EiECCUxqA7CAtDutuHnVtkpuYbLiUYHR01gV0qRvF6B26MmvVnG3TiBMU8ybLtThy45GlAZKnDEoVH6+3yMOLRFCn5WKvkLeNbVWUUg9vT4Mg0tfsofJwL/itvsqNZNsbtEs7eGi2dxtWdZ+lhf2Do=
Date: Thu, 3 Feb 2022 14:50:40 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Wei Liu <wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>, Juergen
 Gross <jgross@suse.com>, <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] tools/libxl: don't allow IOMMU usage with PoD
Message-ID: <YfvdsDQA/QfZAewh@Air-de-Roger>
References: <20220203110651.17419-1-roger.pau@citrix.com>
 <bae9ad85-a26a-67f7-93af-166cc743e046@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <bae9ad85-a26a-67f7-93af-166cc743e046@suse.com>
X-ClientProxiedBy: LO4P265CA0098.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:2bc::15) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2dbeaef3-6e69-4945-6b3d-08d9e71c2ddf
X-MS-TrafficTypeDiagnostic: DM5PR03MB2988:EE_
X-Microsoft-Antispam-PRVS: <DM5PR03MB2988B0CBDAA2303A7308AB5E8F289@DM5PR03MB2988.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: rZeHEZEcDUGucwPdC8jTkLtdxxQfsqQEzcTHQmG9vWI/GHZRjlLcxOfXjr8NSevwWiTMGf416WuX8D88b2GbdBw9IHM2Mst6EzB/yjYWE7OH6qCX+D3xXQvgzm9OZ35OHE/KuKUGUPWhWc3oRYKspQO0wmfURoPeSC9/mUuxCetsRB4UcTKqlaFuiycFDd+mvyIRnbJarQJAT3x37R20EyYJ5s1nZZPStG4b3YN9yC7jyb/kC5BILjcPQfByIak+cRHf6DnSyzmva+DISyW6qTuqkzSutXr8IQN4RT/aQ2Ig8/JQ1oYiby6+1SOlFftUfUfBMjQOoTvdcXvdNN/mHiTC4T0vl0lanjxnYfjuamA33jeU4+9BPE2HsRmLg1/N65HS/wPsL2/MMK+OplzhyKFvFRDlvQFwZbAym+aIuCPynbxvFlnpTN5l2DMyWRirCO5zXtox2eVb6QW5H9dLQ0tcI/IYjOip9xX7pdqskc26tM+8XnrgxokTjCvmfgKdDGa4E7UdGUJYFQOF8yIDCjK70ZlXBnG3a6UaBWL1kOFf/NdCw/lylse4pwaRgasNGgjBt/AobyG4MiKBEN/0Tin2/eaxMvVqp1562J4YDu6h2ohKuk5aOqsLwrSq5+9ydUIhAqBQQD9QbJ265ocwBA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(53546011)(26005)(186003)(6666004)(9686003)(6506007)(508600001)(6512007)(33716001)(85182001)(2906002)(6486002)(66556008)(66476007)(316002)(6916009)(8936002)(8676002)(66946007)(86362001)(4326008)(82960400001)(5660300002)(54906003)(38100700002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MklpUEEvK0RTbEh2eVlacDAxbHRFV3JYei9GakVqMUQyQkg2YUVIcDZiM3Ni?=
 =?utf-8?B?ZUpMSG42MnYrNXJ1bzVEbCtMYTNGc3BEcUxIdGhPMm9rQ2ZwYzFHalMrdDFR?=
 =?utf-8?B?Z3ZVYytKTFBBMXgzK2g1WlBTNVRMU1FQclMvK1E0dW1zejljV29nVFJIQ0p4?=
 =?utf-8?B?bVYyY3huUnBGUU5XanBNcDZzQWJkTXlFNzlEdVZiMS9nVzhTcTNDVmt0K2kz?=
 =?utf-8?B?VE1GV3Y5V0N1OGJtUjNiTzVneHlRS2E0VUlQN2R2NGtRWFQ3ZCszUFE0ZWE1?=
 =?utf-8?B?d2E4ajlURVJpUlEvM09TNkthcnRXSTNiOE5vMUFiTUc3eStJdkFjWXBNQXFC?=
 =?utf-8?B?K1N2L3BwQXp5OVg1eXh4cWFzeXkyTjZHWVlWdzNxTXpIQjNIbjI1dmNaQ2NS?=
 =?utf-8?B?dTFGQ2lMSlJiVkxTaXkzWGV6bncvTkxDV1Z4L21uaG13MGpFUzBFeTdRV0Fy?=
 =?utf-8?B?TWJxakIyaERFWlpBS0VEVWsvNzlTdjdwT085c1lRQmFDVDExL3lxdG9lTTFX?=
 =?utf-8?B?RERXTi9GQmowSFhkb0R2MjBiVEk3cDdSWGVnM0ZXUTR2WFAyNU41ZlcvM1J0?=
 =?utf-8?B?OXZlTTlsRllJTEFZVHo5UFJKbHRMRm5lbEx3eGd0dWNNdDhOR2RNdTBVN1VJ?=
 =?utf-8?B?ZXdiQ1J6L1RWMXFranBIV0JxK1VIbFhTV3Zqc29wT1lrek5Nd0Y5QnA4eUNG?=
 =?utf-8?B?Sm81T0h3MUthVm9LaVg1bWZpUlNiMVl0VkU3cHF6b1RMQzhIMURtRHJqQUNU?=
 =?utf-8?B?RmdVZGJReDB0eGZEa2RZazd1K3FhRkNoYXl6U3V3aGxyUm5IckNFamkxMVhR?=
 =?utf-8?B?aHc3Nzl3WFlRcFF2dEZhMGNzeGl4c2F0Vk9UcnNRVHJ5RHFsdjRzamoyRXZz?=
 =?utf-8?B?bHR3MEJDaW5VKzZ3VnhlZE5QWmdzT1hFdmZxeEowd2ZtMmNBUTNCTURLRENO?=
 =?utf-8?B?MzJmZkRrL2gyL09SZmdXR013ZjA4NDJsSVh3eHUxSEw5dEY4UG1BUTRUMmV6?=
 =?utf-8?B?SE9BY0JNVVJLaHA2ZndHNWtKSnkwL0lxdmZQQzdCNEpFZ2JwcnZWOTIxaUds?=
 =?utf-8?B?clRucE1IZ0d3NlJIUTB3ajlPRTNQZ1VTamRFdWtNS2xUdWdOV29SRjNjUWNr?=
 =?utf-8?B?ait0UWRMWWhxUlpCbm9LK0cybk5FSmg2ME9Udm1iWmJlb0oxMVRjNEtKUDJT?=
 =?utf-8?B?VTlxemF2enVkQklWaEZobDdsc1Yxc0pnTE4zQUhxVml1WEcyQnR5NHVQc1F6?=
 =?utf-8?B?OThpWTk4VUVxcmtScWcyVlBWRXlmOVRTY2t3T2xKTmoyWjZFbDJXRlloK2N3?=
 =?utf-8?B?UitFdlMzcTJBVC9mQmVCbTNhQTJyVlc5U3dZYVIwK3BKK29MTThqa0FTOXI2?=
 =?utf-8?B?VXZzOUJxRlNFWUl2Y00wcjg1ZGwyL1AxaG5ERWMxbktJdkxJcVBZeUozUk5i?=
 =?utf-8?B?WXduRGdvR0VuOG5GcjFyOGoySHhVZ2ExNlEzaTFkckdCTjN2TDdVUUtsRklN?=
 =?utf-8?B?bm9qQ2lIdldzNTkzRnlGaFlIMU5HMXpYUEs1QTJITU1hSEx4RDQwaTZYWUlX?=
 =?utf-8?B?T1N2Z3RKUzdNUUtLQ3VjSTNNNWVRd3JKeUwwZXp1QkxHL1c5d0hPK0hQRXQr?=
 =?utf-8?B?QUdaWGNqU2dXNmNOTTMzcFZudnQzWDhRV3loeGRndEVyRzByb1N3cG1JWjA0?=
 =?utf-8?B?eks0UUl2TjFCREFnREk0aUxSREFDUzFNVkJveG41VWdpVTZKRHdpL3JBdm8w?=
 =?utf-8?B?SzRnL05seE84d0R2YzZ6bUhRaHk1L3QyZFpKemt4TzJQbVQxZ1Y4WnVNREUz?=
 =?utf-8?B?L1lKYXh5YVNsdUVRbnZIWENxYytOczNnVUY4RzZiNG1jZnBxdld2aVhGS2ZU?=
 =?utf-8?B?TUFDR1RoQWF0Mm1NZFNSS1RNc0ZFclhwNU8zbUdQU293THQ0Tm5mQXFEdGdl?=
 =?utf-8?B?eVZyaFdCOFB4Y2R6RW1mNEl5YnRyMmJEckMvTmQyQ2JjSW5EUnNhN0J2K1hw?=
 =?utf-8?B?Y1Zld1NnRjZDTzdROVgvZUJLdkRsMklMcmdkRkloWEwxeDV1azdHQ25VMGdy?=
 =?utf-8?B?NmpYZzc5Z0phc1Y2WTI1UU5hTEZwWHZJVml0N0lkeHBGcU42bFBnSWFBWStG?=
 =?utf-8?B?WHloUmxUb0JpaElXYjZtanVnZkJUZXVBcHV1YXl5VHdWb3VQM0J2amJzQ0Jt?=
 =?utf-8?Q?4FTBestMuTA5ZwEBp50nHSk=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 2dbeaef3-6e69-4945-6b3d-08d9e71c2ddf
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Feb 2022 13:50:46.7321
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bHh0kE9N8yVdRX0bsn7Qwf1+SKB4+UR5k9R/qYwQka+xlloIRUSJ2aqbczaXskB8RLUE4uF855JptOqtNbc0EA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2988
X-OriginatorOrg: citrix.com

On Thu, Feb 03, 2022 at 12:55:56PM +0100, Jan Beulich wrote:
> On 03.02.2022 12:06, Roger Pau Monne wrote:
> > Prevent libxl from creating guests that attempts to use PoD together
> > with an IOMMU, even if no devices are actually assigned.
> > 
> > While the hypervisor could support using PoD together with an IOMMU as
> > long as no devices are assigned, such usage seems doubtful. There's no
> > guarantee the guest has ballooned down enough memory for PoD to no
> > longer be active, and thus a later assignment of a PCI device to such
> > domain could fail.
> 
> That's not a precise description of the constraint: The guest ballooning
> down enough only means entries == cache, but for device assignment we
> need entries == 0 (and a guarantee that no new entries can appear, but I
> think this is already the case once a guest was launched).

Would you be OK with:

"While the hypervisor could support using PoD together with an IOMMU as
long as no devices are assigned, such usage seems doubtful. There's no
guarantee the guest has PoD no longer be active, and thus a later
assignment of a PCI device to such domain could fail."

By "PoD no longer be active" meaning cache == entries == 0.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Thu Feb 03 13:57:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 03 Feb 2022 13:57:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264792.458024 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFccB-0004wg-8v; Thu, 03 Feb 2022 13:57:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264792.458024; Thu, 03 Feb 2022 13:57:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFccB-0004wZ-5k; Thu, 03 Feb 2022 13:57:35 +0000
Received: by outflank-mailman (input) for mailman id 264792;
 Thu, 03 Feb 2022 13:57:34 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=OTfZ=SS=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nFccA-0004wT-Eq
 for xen-devel@lists.xenproject.org; Thu, 03 Feb 2022 13:57:34 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3c24f490-84f9-11ec-8f75-fffcc8bd4f1a;
 Thu, 03 Feb 2022 14:57:33 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2169.outbound.protection.outlook.com [104.47.17.169]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-37-nGaGM6nbO-Sj-DfWc9fsHg-1; Thu, 03 Feb 2022 14:57:31 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DB6PR0402MB2886.eurprd04.prod.outlook.com (2603:10a6:4:97::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Thu, 3 Feb
 2022 13:57:29 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.012; Thu, 3 Feb 2022
 13:57:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3c24f490-84f9-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1643896653;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=HJa4rCjZpzGIpqqFbd5+yMzWnrzq2hc8hkN/C3WC/JU=;
	b=M2fmy6iuDlJoZ919BaMMebGErQNx07KGZ6YBtZ5eWt4UV7Wi4fGrMK0BXXe8CbUNauKzlS
	FVm2y64+HBdlaeh8+V3j0QVSHMeAsdbxCn9/e7ONh62Hb/7Qki/tjQ3mhqbQCia5bLwC1o
	6fPha0NHgh0dHDeTlg4aC2R73G0O79o=
X-MC-Unique: nGaGM6nbO-Sj-DfWc9fsHg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gcveZPoDEpplu4hdfKFVh3QqKiVLRWqp9l9Eeg1UDMko7j7Nz0CllMlLrh0OdfkuKadLzIXcPzOfe3pS7JJDpcDedWvW5b1L8yRTRBQNIvq4hpnXztRH1r+afGJS6DWYrHNMOrwR9EhwMoDkNyqZORPk0K6Gn42COormqIBLNYIekeRoih693KHuo45usucUL59hVS/SbIFeeLxM9PK2uIGg3cs69+VLCeSqG+L2mUBHp0yNw4L+uVUp6ccez4856p0OhuD9dJlSGTHSfZ7FIrVkp/90m6td0FD8/Dti2JgQH5SoZESmf0PKHDNl/sNeIPNLpqqnx/aBZxvUq+MjXg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=HJa4rCjZpzGIpqqFbd5+yMzWnrzq2hc8hkN/C3WC/JU=;
 b=I3Ol7i/EcRYvJb1vxxFr/ktptdW//OKnuVuRn556cpI/ANgpiBOJtg0m7vp3iiES6sL1XPH3RjLdXgqJzPUTMJJpUF4bK35n/UTPKI0fTQOXWeUgH9Of1RVZvu9lMnRvRIALFh9mNm4REVC4wVcsas2vF6MVRvPfML78yjRt3ehf4ce+CZcRLbAiG++SlRw+VPZ1VMT4UaWGhh/lZngd8nHcTyxlOeVVuK2ekcOb4NRYBbthlzg7a8LTxmAfrMAWMM09/ToOKE+JVA/kcGZUJceuBcDBKzi7E2KTW5fN3rAFO/2othBevpBxb5KpyUAGhp2ByHy9o+TNgOSeV8NFOA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <b3564fe0-e375-b386-df0d-a5c2b54d1299@suse.com>
Date: Thu, 3 Feb 2022 14:57:27 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH v4] x86/altp2m: p2m_altp2m_propagate_change() should honor
 present page order
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Tamas K Lengyel <tamas@tklengyel.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 Petre Pircalabu <ppircalabu@bitdefender.com>,
 Alexandru Isaila <aisaila@bitdefender.com>,
 George Dunlap <george.dunlap@citrix.com>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0090.eurprd06.prod.outlook.com
 (2603:10a6:20b:464::7) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 24167c68-0ce9-4118-65fe-08d9e71d1dd5
X-MS-TrafficTypeDiagnostic: DB6PR0402MB2886:EE_
X-Microsoft-Antispam-PRVS:
	<DB6PR0402MB2886F434933016DA10EF7532B3289@DB6PR0402MB2886.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6430;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	W1V5lKgyCfUNLMlIM2U7jrI3mgxUQLxgjnApNTvmoi264tw/i1ZAlIyjAkYIF2ZKY+W7cjnRl4EWNUPmyaPFhlteImBXygDfsUnGVlv2CJ0eJF1ZmYA7HHQOVmgLV3gRuJAqXF+6SBZ8WwwLoZl8eTidR2jVhLhTUoYnSxT56dvcQOKh9UdA7V//8TYpEzeNDErb6yrNw7LTEDPhVK3KZZRc87lwGeBN5TsBFqrKDalwdSJeNZt/YrI3nd1Pdd+CaFq59bcUUB7yrxwtQEwHsUyFjAO79YhIpg0QlGOOvP6b+spAxC3INLT6ecPwKyivDMAfplv5asHYEk+j7YFS0kbJ4zbGtIXaP43urOzoBPREEgIr4wVOtKOI4y1t2O3WZaGxDqIepRAB0dqbBYNLgiCIGv2YXV+LTEDA/wdD8PYqtS4S2WIvmw+YTj58+5j++Swzmbs9T2XxkzgcJG9NGVgtEOPCiI+3FXEXpYpnaYKryIuIBQ0to1LpOXjJy9RkNJlU9T6yiUsU7xBGos28tr7/0dlrNk13CTfCyzkN0AbQ0Cy9ssHWDoNIqkuJ15LnQV0ueloqqcdUkiUvEudrR9U0SC9ycbeDdZh5ipz33DHYGWgY9dZif5TGKyO4JCYbG/CcV7w7r5BGb80u65HapHYjbw54rSqV65F5B4OAnwtoS7DPol38aIbxabeWhjegrdDLQfhkrEeyOd69l1IkrgNM0mdCWk0blSorxv1eQ0Y=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6512007)(316002)(83380400001)(508600001)(2616005)(86362001)(54906003)(6916009)(31696002)(6506007)(8936002)(26005)(186003)(6486002)(66476007)(66556008)(66946007)(36756003)(38100700002)(8676002)(31686004)(2906002)(4326008)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZW0vZDdOL0pjc1ltUkQvMXRYZXZNTnorZ1puZ0lIazBWYVpQUE5jTmV3Mitt?=
 =?utf-8?B?SmNkOW5XTlQzSS96TnBmbk0xeHJSUndKdyt4S1BpYlZqUEx4UVJIekh4YzR5?=
 =?utf-8?B?UEs0SkZYK2R2ZGROMWNGWS9WNkYwN0pnVzIvQTA1WHJqMXUvdnBqWTI1dE5E?=
 =?utf-8?B?VmN0WlhWWTkxT3g5SU5DWGhYVi96WG1PT2VlVmpTNVY1enJmc20wcjd2eHFF?=
 =?utf-8?B?R3U3eVFNMmVvS2IvSjQzSDhkQ2ZnT0FlTUppSitOOCtWM2FRWnI3dmFiRlpL?=
 =?utf-8?B?UFc0SHFwcStPUDA3U1JPTmVMSW83SHhBTkEvV3NmWVgySVpTNDByU3Y2Nmcz?=
 =?utf-8?B?V2pGRFdoMlZHRVFQMTNUdXN5eHNVcXhsTlNVSXFtVGloamhQbFE0QUpiVTFy?=
 =?utf-8?B?U1dVTUdmUTByK0JxTkQxNTRzcEt4Y2hvcWNaRUx3S0pKTy9CSzM0QldHMjdI?=
 =?utf-8?B?SnBGeWFwejlPbDRKRERSZHVkVk1HdkRsVEMyUTV3SmxUeVpKdEMrZjFYOGkr?=
 =?utf-8?B?bnlxZTZrLzJXLzZUcE5MNnQ3UmNuS3RSc2ZhMHpYTlJIaExTK3EwdGkwWGhm?=
 =?utf-8?B?dGhGRUltcmt2bXU0Z2xoQjFBV3FuL1NQM2lCaFdWL0g2eFVJbWhXUFZDa0tJ?=
 =?utf-8?B?Sm5wYmFHd3BEVEVIdDRoQW5lQUUvQTE5K1dhcGFCbXB1dll0N0s0WmhzNTBy?=
 =?utf-8?B?aXpTYkpwQmtjcE83eVZ6M1NnanFVODM5R2pxRGNaOVZyMTJ0L3BmcE02S1JV?=
 =?utf-8?B?V2RQcDJ2ZjA0ODIxSjgxNW1qQVJ5Q0xRVVVWZFdaR0djSFFHTllEcHdVN1Bs?=
 =?utf-8?B?RVJVSkdRaE90OHlmdnVoUllVYktrSkJKUUVKQjV4TGMyQ2VGRnBkeW1sdWdC?=
 =?utf-8?B?Z2VYd2xXeXZ6bWsrdVpQNVBRcFR1NitTZ2MySGtBNTdETmk1NzcwSWtzNHZO?=
 =?utf-8?B?QUJtVmIrbHEwNndsbHB1V1dxb2JEcDJjSUhiaXRZd05WT1ZucWM2TmhzZS9J?=
 =?utf-8?B?UVozM09QMmdDd2FqR0VVRFVEWFdvYzNrbGtROXB6Y2dhT0RaWjVROTVTQmhR?=
 =?utf-8?B?bW5pOWtWOHpJeWY3NVRMR1dnWC8yTDR0SUo5VGVMR21mSi9wV1NYZzY1dCsr?=
 =?utf-8?B?dHpQdWpyZHdZTktVTVZVMDQvajNZVjVpMDUwK3dCOEdXY3NJWUs3azFIWkZl?=
 =?utf-8?B?QkltK3JtOVRaYktYMGUyWS9BbFhSSUJNbTNvNi9POFFhVGtNTWM5NlJlWTZC?=
 =?utf-8?B?T25CS1hGY25rekphVHZWV0JOUTZlZ0lmaVFnTVdiTVVuaSt3S3BJZEluWUts?=
 =?utf-8?B?dmxTSUIvSkQ5NCtiai9LRmpsYjBQdWI1QXNQMXpTZnFidzNQR3pYWHg1M1Nj?=
 =?utf-8?B?bGRTK1NjTjd0NGJWd1VxdUx5T05yU0ZaZTBKOVRRV1VsZEwrM2lpMlJZbFNz?=
 =?utf-8?B?VEgzSklkSzYwUk81MElVQlRqM0JkNU5uOGpHTjdkQXVQYXRTQTJyWDVTcXVX?=
 =?utf-8?B?ZTd6S211WURDQmJiUmRxZUNPa3JoNUl6RGo2V0hONGRmTGJVMkE5d3hKeVA5?=
 =?utf-8?B?eXRFNnBYdkFFUENuVW4xL0E2eVJoQzJISHN4ZiszQndUSjNWTFppNVdpZkNr?=
 =?utf-8?B?UVhqc2swNVYzc1hpS3N4UDBjcXpqMUo4bENRb3I3U3Z1eEdkM3YrSEozd1pF?=
 =?utf-8?B?aFZtNHE2enQ5bjQxb3lpR2NKZ25PRDBMdk53blJqYXpwcm1oYlR2N1ZNM2U3?=
 =?utf-8?B?ODI0M3A1Ti9NRUkrU2VQWGhQa1RSb2kvd2lCMnVvZFRydDhMN3BudjgzL2pi?=
 =?utf-8?B?Sml3RVJCdHU2NzFxZzZ6bVZYcThNWEhUZGZjR05OZ1BJTE4zMmlqcUVocS9h?=
 =?utf-8?B?bEFscEx1MHNsbHRJMVlEMmpGWUJaVkp6NWZLZnMzR3ljeHNQVUwrMFhRWDdr?=
 =?utf-8?B?WVNsY2RRc1FuU0orMWc4dytOTG5pR2g4MzRxTkZqbG10UlB3dUIzTmdWWjJr?=
 =?utf-8?B?NitYUHFvTzZOZ25SdXhpK1FYZ0hNeDR5bXZtaGlaUFFaVVErc21ncE9aWE9X?=
 =?utf-8?B?QUtXSDFkMjJZZGRQbU0xSEJzTlBTQ0V1Y2ZHK3JBdjljMEFSQ2wvSGZId3VW?=
 =?utf-8?B?NWtHOWJwVmtOZC9jZVR6ZklKaG1SOE9OdWpjUXVZOWNIQmlRNHJWK3hMTm4v?=
 =?utf-8?Q?kQpJuv71JMsWRl9aXtpQQT4=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 24167c68-0ce9-4118-65fe-08d9e71d1dd5
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Feb 2022 13:57:29.2415
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ualy5lrZIBZBjrYlC8LSzLA1Qc1EFKGyYBUXBvuFLIyvQjt0QwkGKn4/ctzSOBbB2/2yG4Fs6R8mfHtYsUR0hw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0402MB2886

For higher order mappings the comparison against p2m->min_remapped_gfn
needs to take the upper bound of the covered GFN range into account, not
just the base GFN. Otherwise, i.e. when dropping a mapping overlapping
the remapped range but the base GFN outside of that range, an altp2m may
wrongly not get reset.

Note that there's no need to call get_gfn_type_access() ahead of the
check against the remapped range boundaries: None of its outputs are
needed earlier, and p2m_reset_altp2m() doesn't require the lock to be
held. In fact this avoids a latent lock order violation: With per-GFN
locking p2m_reset_altp2m() not only doesn't require the GFN lock to be
held, but holding such a lock would actually not be allowed, as the
function acquires a P2M lock.

Local variables are moved into the more narrow scope (one is deleted
altogether) to help see their actual life ranges.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
Note that this addresses only half of the problem: get_gfn_type_access()
would also need invoking for all of the involved GFNs, not just the 1st
one.
---
v4: Restore mistakenly dropped mfn_eq(mfn, INVALID_MFN).
v3: Don't pass the minimum of both orders to p2m_set_entry() (as was the
    case in the original code). Restore get_gfn_type_access() return
    value checking.

--- a/xen/arch/x86/mm/p2m.c
+++ b/xen/arch/x86/mm/p2m.c
@@ -2534,9 +2534,6 @@ int p2m_altp2m_propagate_change(struct d
                                 p2m_type_t p2mt, p2m_access_t p2ma)
 {
     struct p2m_domain *p2m;
-    p2m_access_t a;
-    p2m_type_t t;
-    mfn_t m;
     unsigned int i;
     unsigned int reset_count = 0;
     unsigned int last_reset_idx = ~0;
@@ -2549,15 +2546,17 @@ int p2m_altp2m_propagate_change(struct d
 
     for ( i = 0; i < MAX_ALTP2M; i++ )
     {
+        p2m_type_t t;
+        p2m_access_t a;
+
         if ( d->arch.altp2m_eptp[i] == mfn_x(INVALID_MFN) )
             continue;
 
         p2m = d->arch.altp2m_p2m[i];
-        m = get_gfn_type_access(p2m, gfn_x(gfn), &t, &a, 0, NULL);
 
         /* Check for a dropped page that may impact this altp2m */
         if ( mfn_eq(mfn, INVALID_MFN) &&
-             gfn_x(gfn) >= p2m->min_remapped_gfn &&
+             gfn_x(gfn) + (1UL << page_order) > p2m->min_remapped_gfn &&
              gfn_x(gfn) <= p2m->max_remapped_gfn )
         {
             if ( !reset_count++ )
@@ -2568,8 +2566,6 @@ int p2m_altp2m_propagate_change(struct d
             else
             {
                 /* At least 2 altp2m's impacted, so reset everything */
-                __put_gfn(p2m, gfn_x(gfn));
-
                 for ( i = 0; i < MAX_ALTP2M; i++ )
                 {
                     if ( i == last_reset_idx ||
@@ -2583,16 +2579,19 @@ int p2m_altp2m_propagate_change(struct d
                 break;
             }
         }
-        else if ( !mfn_eq(m, INVALID_MFN) )
+        else if ( !mfn_eq(get_gfn_type_access(p2m, gfn_x(gfn), &t, &a, 0,
+                                              NULL), INVALID_MFN) )
         {
             int rc = p2m_set_entry(p2m, gfn, mfn, page_order, p2mt, p2ma);
 
             /* Best effort: Don't bail on error. */
             if ( !ret )
                 ret = rc;
-        }
 
-        __put_gfn(p2m, gfn_x(gfn));
+            __put_gfn(p2m, gfn_x(gfn));
+        }
+        else
+            __put_gfn(p2m, gfn_x(gfn));
     }
 
     altp2m_list_unlock(d);



From xen-devel-bounces@lists.xenproject.org Thu Feb 03 14:05:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 03 Feb 2022 14:05:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264800.458035 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFcjP-0006Tk-5V; Thu, 03 Feb 2022 14:05:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264800.458035; Thu, 03 Feb 2022 14:05:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFcjP-0006Td-1b; Thu, 03 Feb 2022 14:05:03 +0000
Received: by outflank-mailman (input) for mailman id 264800;
 Thu, 03 Feb 2022 14:05:01 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=OTfZ=SS=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nFcjN-0006TV-UE
 for xen-devel@lists.xenproject.org; Thu, 03 Feb 2022 14:05:01 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 467c40b4-84fa-11ec-8eb8-a37418f5ba1a;
 Thu, 03 Feb 2022 15:05:00 +0100 (CET)
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur02lp2052.outbound.protection.outlook.com [104.47.4.52]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-3-c1IDmQh7Mjy6d3luFvArDw-1; Thu, 03 Feb 2022 15:04:58 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by HE1PR0401MB2267.eurprd04.prod.outlook.com (2603:10a6:3:2b::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Thu, 3 Feb
 2022 14:04:56 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.012; Thu, 3 Feb 2022
 14:04:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 467c40b4-84fa-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1643897100;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=ScDkqfasUl6RtJCwketVb4VOq3IzD9NIKTJM5lYSMmA=;
	b=LK6krTlO3Xli5exMR6zj8rVMPd74cRE2Ykb8RPUoVWqhztEMwgJOe35IjMYXCo428TO023
	IxfqEGmZz8y2bZ9sSWcMssKeGfIV9V44Doxg6PWCUdbCOvG+g9FKLOBihqYgMQLwohEiZh
	c4ty5Hi7kcvdVnelc1zVqXSwmIZdXIs=
X-MC-Unique: c1IDmQh7Mjy6d3luFvArDw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=TiaxVZ0O3QDKBSuuvZ5kOPpYWYeAnUS5cgP1PVxr7nJ6Cafy8G4fvRME6GZl23PxSyy4a2+NjMO7XzEyduKw74CxfM4+77m2Edyp4DLgQ02qI/IUNh1W3wskBghE+TfwLNXlC6zeYbmC2D9mwAf1S+aGw4D+Ct2VFIgsTQp0D1DbIQkH/LZg+k4cztFxnw6Dsb6e3I530ThLmvQwK5hpEQhEIsbEpNaeNexuMIydR5uvtEv+hJkmJFWUMe7Hkg6yf/qZyjmB5bn8AIQIEVG3nSxF1J5f69DVkfJDZtZaTwWIf6BhHekQMFqk32GVsigQiojm1ZDDxt0u1ZuHEcn9SQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=guEwFPsRbgbhwZ0w+ILIYeqg/kkfC0D/Hxs0UihSAYY=;
 b=ich3hpjQ6FUjJcv6TYR6R4URZnwvIXE5MqqPLDHqj7v/D3x7Q/zjXZPItqdrEZkQijNYG+r5yb043ErK+ZXT7Y1Pa/agtH1PTE/jGPHcz3e8+cH/hq+uvjbnS5J4SadP/xlyHnjBHAIyqXm0+EYEkP0ey9d4O04sgMSOwy9ZJq3PMFVKoVsMcuZUOYUGv54Uce/K89+pN8sLFrZ/YlUj09tPc4xpxy63aykdz9Y/hurE68ohQmO5JgJ91wj+qv5IDxjAlXDixAz9ZgXk9C0zztuSyJ5DBGZTJzxMUHW/ZrZYPCvpuU2bUQmBEy8fx36IrdfELMBpY7eJWGTunGcUvQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <be1546ec-0465-9398-9681-7e85e2ca9455@suse.com>
Date: Thu, 3 Feb 2022 15:04:52 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v5 06/14] vpci/header: implement guest BAR register
 handlers
Content-Language: en-US
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "julien@xen.org" <julien@xen.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Artem Mygaiev <Artem_Mygaiev@epam.com>,
 "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
 "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
 "paul@xen.org" <paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>
References: <20211125110251.2877218-1-andr2000@gmail.com>
 <20211125110251.2877218-7-andr2000@gmail.com> <Yd8RJfpEalnfl+CC@Air-de-Roger>
 <d493b022-3c78-1721-e668-48f4553056a9@epam.com>
 <df98cdbd-36fe-0386-c068-2a1540f10188@epam.com>
 <9c1f376a-0df3-67eb-7fd1-bb75ae130e77@suse.com>
 <0171761f-d90f-3e3a-5c8f-e32d70096e27@epam.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <0171761f-d90f-3e3a-5c8f-e32d70096e27@epam.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM5PR0101CA0009.eurprd01.prod.exchangelabs.com
 (2603:10a6:206:16::22) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7b05823f-2605-4be5-fe16-08d9e71e2890
X-MS-TrafficTypeDiagnostic: HE1PR0401MB2267:EE_
X-Microsoft-Antispam-PRVS:
	<HE1PR0401MB2267B7CECC8AB34BD8EC088AB3289@HE1PR0401MB2267.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	glRGVBd7BcWO4p/5y8VGW8bkoQQKMUZth1w2u3xosrrFXTyyNddpLuJFzztkF14vHkEzLuXnES6DQ+FU1BjJo0dqVH8TIJU3SxCLtkwhkPkyGihmVQTq7t54z6YCbgCYWiz5xIEqE7UNlAltfChQnMFxnopmkP+VJaNI2WWTAXbqo9+tib+7EsmqOGuZOoz4TFzzxYSQKm5cMxM7CeqzWGfsN4YKtU7EsEYD+o04hhPHG0/fR/mi7Ku2PIecNXczPWbY6IbLdaQlOUgsjnhtz/oeSIVrQO0IQ43QDYsJ2U4+bWd+aOp/p7Z1LO7bzdkl7E3oLLqQdT/dOJYxGRY+vbv+N97/jipyK6Ek7G15mwzwtZTWtX2tqGJOnmreWEIG5pn2Zc8Uj9qYPCFuoGOPoc52twcUA986fDL48C3ENkFYHDgD1kZKA34y2qygaUhjkPokTvQQE1t0k2ePiVpfK2z1Op2FmQwzo6pd/1KExwA6DhQdifrx/20bE+q+uVIO6wMVAUKJSrqPP7tjWYtONMNlH0FRdK45g+xAbXq8NLYd55fZ546iX1aB/TDKRdog9yi24QgYAmZ/CcvK9rHHpnay1JEXzetUltnD9XGNTTqf06UyMBOB5uE1Z9+OQnwk01YQ0ADYfKsyrHvwxXHJGIUML7rVu/lRPBIV5OA06Bc8pnZxp0XDUxcxB1XcNARGG6DzFvMZsNJ7kz0zOfvd9Ng96UugntYPg9FikRKBCUa2V8dSgLkS9zX+Cm6hZZgO
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6666004)(2616005)(8936002)(66556008)(83380400001)(8676002)(4326008)(66476007)(2906002)(66946007)(6512007)(6506007)(26005)(7416002)(186003)(5660300002)(86362001)(36756003)(38100700002)(31696002)(316002)(508600001)(6916009)(54906003)(31686004)(6486002)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?q7D/yP20dCgjGcPD4RNhoPF8F6LZF/RFFAyUku/flg2nCN990fYNWzwlQ8o7?=
 =?us-ascii?Q?UBvsdzI/ChdQc46g+c7hQEmdoCRKl+wLVUCMavNnEQynDbA5NNwb0Z5PDIDE?=
 =?us-ascii?Q?gc4a0SnPMAiQ7k+PTLGm3nnHayfWyKtCwPqVrCERm7F/UjsGtZKH4XP986mD?=
 =?us-ascii?Q?U6JPXunU4AAqdK0vgQItu7+aT1pCJL9prR9OibuazC6INH1AZTM56GB0DKFQ?=
 =?us-ascii?Q?72mxoe5seeF+MrS2cBiLJW6Mu0ogg6nF8RTH6cCyQWXD90XwlcvT681Ql2RZ?=
 =?us-ascii?Q?qqsC/OjU9eUhNHqQ95pEP48XuAaSo/BcIlY6DxKuUEFyUMfRsKGQ3JgxtNsL?=
 =?us-ascii?Q?BhmcWku2AajWLkXz/CZD+rE7wUg1qS2BNfQz7ELtipeGEQQIHJ12xEQJo8Mk?=
 =?us-ascii?Q?i6vVV4ICtqRXn0vOD8uc6ochpVfIHPQj7Qa4PrOW0cz66FWN64DGon+V/d+3?=
 =?us-ascii?Q?qhxik28xacpPiWeCO1GyhDzfMaOvWjMbQYezwvWURZOCW+Zfmt75/KCnK6Lu?=
 =?us-ascii?Q?9nBxN0aX3/MMAVhBQ25bj1Z1h2yescKcivFzhlejBnY5cwb6ngtlcfPgzg1C?=
 =?us-ascii?Q?uzKdigGcaI1McRGziFWT86GYKp401K/H+suK5Y/2iuWNSfX8ESUMAXbq7Vxj?=
 =?us-ascii?Q?daYRZfCyzEkyfwrhn6g55ZiW/JJPgfuSf7PQcLD88XVpqlvthOwZZ8O6OI7o?=
 =?us-ascii?Q?LOxIY3nPPtWGrbz3tKxfcmOtLSCbP94m6+viMrLAp3ZBoxwLqGb+JfnLvMX0?=
 =?us-ascii?Q?A1lxxNMKa8TqLMz5GIQc2QaQQoeB6/40Cl97dAJQ1oo/EHhJhzmF56/leTkj?=
 =?us-ascii?Q?/kA5dBoYJZ1DH9rdoOVQjZBdqVljU3vcUDqETqm4ga0emMzh7O+PUKqBaodQ?=
 =?us-ascii?Q?o1NPtjRKFbElVxq9MNZ9+qLWYWBG931WyYz7KahEW/l7mu7uQAccc3jsFCAa?=
 =?us-ascii?Q?6ELEhR8uaNQz47Y8fwAoxI3Ii1LViu111aUQnOghqHK7XdkMDwtgfNG7528o?=
 =?us-ascii?Q?DaSrrET4wZPBJQ6DySbLoh8G07uLnc96rltHH+jDz2J7lql4srH2Joqcidmk?=
 =?us-ascii?Q?U7//1oUq+uAHO70P7R+UEzrF666C22KGoTNX5qLi/Xm1JPfxSydPzD0x+k3+?=
 =?us-ascii?Q?9n/kzo5oBqYmKcTA4iu8mZcmrQZI9m8Qie3HK5t8uVfBuX9U3ke+HEHy6jGj?=
 =?us-ascii?Q?vVkme1eQosNXZ+31oYdYLynsKJXusfu7zLQwGPwF93VezbRKhzkIY09rd0MF?=
 =?us-ascii?Q?qSwLiVsnJJKWH5uhs6rOf1nvzRphSa/mhZSyJ9IQwtMFI2pqyZ9EVI4g8QOP?=
 =?us-ascii?Q?NsaRzJHguiDdGHan+EJPc6FzLG2Px0ZmUvB3K2To+b3npdDOrubBMa85cS6H?=
 =?us-ascii?Q?GNc+73yascqMIPqlXdRd+jq8ZFBfohYAl/bqQFas5mh68D6l9PSCogp2tQYI?=
 =?us-ascii?Q?5E7XGPUBVO9uv1NlXGXl2uOhq/bfxH5M0hdhlHDVkv8wxDhcmJqRehs3deXT?=
 =?us-ascii?Q?oHBiuw3ttIJrmCKrQgC43107/faR71n3QyZ6DhwVFdl1pxvKqdE6IaFpRTFT?=
 =?us-ascii?Q?OBlwzX6ZIjVWFRimm6x9dJ5IwzUWz4fcktMx0Gpe3KbncpzMqYkbQCHyHc+T?=
 =?us-ascii?Q?qe7NcQt2TIuce5N6IaiRjNc=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7b05823f-2605-4be5-fe16-08d9e71e2890
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Feb 2022 14:04:56.7136
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hGOs6mqImexZ9H1RpPF81dNcndFsytKXZmpMRKCND01TC2dLLjyhGfTr/se2dQAaHYvTVKVuYJeruqcANnspMQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0401MB2267

On 03.02.2022 14:30, Oleksandr Andrushchenko wrote:
>=20
>=20
> On 03.02.22 14:54, Jan Beulich wrote:
>> On 03.02.2022 13:45, Oleksandr Andrushchenko wrote:
>>>>> Also memory decoding needs to be initially disabled when used by
>>>>> guests, in order to prevent the BAR being placed on top of a RAM
>>>>> region. The guest physmap will be different from the host one, so it'=
s
>>>>> possible for BARs to end up placed on top of RAM regions initially
>>>>> until the firmware or OS places them at a suitable address.
>>>> Agree, memory decoding must be disabled
>>> Isn't it already achieved by the toolstack resetting the PCI device
>>> while assigning=C2=A0 it to a guest?
>> Iirc the tool stack would reset a device only after getting it back from
>> a DomU. When coming straight from Dom0 or DomIO, no reset would be
>> performed. Furthermore, (again iirc) there are cases where there's no
>> known (standard) way to reset a device. Assigning such to a guest when
>> it previously was owned by another one is risky (and hence needs an
>> admin knowing what they're doing), but may be acceptable in particular
>> when e.g. simply rebooting a guest.
>>
>> IOW - I don't think you can rely on the bit being in a particular state.
> So, you mean something like:

Perhaps, but then I think ...

> --- a/xen/drivers/vpci/header.c
> +++ b/xen/drivers/vpci/header.c
> @@ -808,6 +808,14 @@ static int init_bars(struct pci_dev *pdev)
>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
 return rc;
>  =C2=A0=C2=A0=C2=A0=C2=A0 }
>=20
> +=C2=A0=C2=A0=C2=A0 /*
> +=C2=A0=C2=A0=C2=A0=C2=A0 * Memory decoding needs to be initially disable=
d when used by
> +=C2=A0=C2=A0=C2=A0=C2=A0 * guests, in order to prevent the BAR being pla=
ced on top of a RAM
> +=C2=A0=C2=A0=C2=A0=C2=A0 * region.
> +=C2=A0=C2=A0=C2=A0=C2=A0 */
> +=C2=A0=C2=A0=C2=A0 if ( !is_hwdom )
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 pci_conf_write16(pdev->sbdf, =
PCI_COMMAND, cmd & ~PCI_COMMAND_MEMORY);
> +
>  =C2=A0=C2=A0=C2=A0=C2=A0 return (cmd & PCI_COMMAND_MEMORY) ? modify_bars=
(pdev, cmd, false) : 0;

... you also want to update cmd, thus avoiding the call to modify_bars().

And btw, from an abstract pov the same is true for I/O decoding: I
realize that you mean to leave I/O port BARs aside for the moment, but I
think the command register handling could very well take care of both.

Which quickly gets us to the bus master enable bit: I think that one
should initially be off too. Making me wonder: Doesn't the PCI spec
define what the reset state of this register is? If so, that's what I
think we want to put in place for DomU-s.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Feb 03 14:06:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 03 Feb 2022 14:06:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264804.458046 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFckQ-00071d-EM; Thu, 03 Feb 2022 14:06:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264804.458046; Thu, 03 Feb 2022 14:06:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFckQ-00071V-BG; Thu, 03 Feb 2022 14:06:06 +0000
Received: by outflank-mailman (input) for mailman id 264804;
 Thu, 03 Feb 2022 14:06:04 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mjBt=SS=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nFckO-00070F-Oy
 for xen-devel@lists.xenproject.org; Thu, 03 Feb 2022 14:06:04 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 69fe9edf-84fa-11ec-8f75-fffcc8bd4f1a;
 Thu, 03 Feb 2022 15:06:01 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 69fe9edf-84fa-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1643897161;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=AFKNSxzQq822lpZOMTbQdJjj9OdDp3Os1we92Rqt4Vo=;
  b=IieIDmn7vvllPOqmUNKlhJaYIIaWOgg4vws7xIw/grySs3hXNB9e/jQB
   EjdkHq08RRPsBuvNqC2AUE7r3kq+v5JeXDRHdC7VtV/lgg/3LqeVjjiFT
   4rQN7d9PtwPrzxQxhmmngXBP3IOM/3YOtmfUlaup1fNj+oQOOGE3bWBH6
   Q=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: rjcPPiKvhURkGwfAVZNZ2O4IOWplLIOeKyil5DOMI9wdCGiN7HAn6xLVnXUm6LSEE8sr/4LWV2
 tXV0vaF7ecfu1FefQAGu9DR84YUmh5Qj0uvSgtgt01WZrOnLF98H3AZtB5GQYxwmZ7jYkr7W0/
 1rO09V3WKjgG7n33HCXfCZZeFwLmjNJdrW0SZHJZ1yKoohAiWPG+wpxDTER4t6m6LYbrADKXzf
 skjV0+EFasFoq4TCsuTFBl4Y9ZMvHUO7f/5lX5tiaq0CnR6Xs5jSABgkqk0oK3KA6Tz1vKy+L0
 fxk=
X-SBRS: 5.2
X-MesageID: 63328879
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:+VEB06PizotvbZrvrR3NkMFynXyQoLVcMsEvi/4bfWQNrUog1DBTn
 GFKXm3Sa62MYWqme9ona4+w/UhXvpSDmoJmTwto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6UUsxNbVU8En1500o4w7RRbrNA2rBVPSvc4
 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq
 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYozbV3Ox90
 YRPj7OtGQM4EYHvyfU8fDANRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs
 6VFdnZdNXhvhMrvqF6/YvNrick5atHiIasUu216zCGfBvEjKXzGa/uRvoUIjGhh7ixINc2OX
 +k+TxVlV0XnbTJfOlsNIrc0uuj90xETdBUH8QnI9MLb+VP75RZt3b3aFcvac92HW+1Yhk+d4
 GnB+gzRPBYeM9COzCufxViljOTPgCDTVZobEfuz8fsCqEWa22g7GBAQE1yhrpGRkEe+RtYZM
 E0S9SoGpLI3skesS7HVVRCivGSNuBJaXtNKCvA78ymE0K+S6AGcbkAjSjNCc9UguNUBeS0x1
 lSJktXqAhRiqLSQD3ma89+8rzm/JCwUJm8qfjIfQE0O5NyLiKY3gxHUR9BvCpmciNHvBCrwy
 DCHqis5r7gLhMtN3KK+lXjXjjTpqpXXQwod4gTMQnnj/g5/fJSiZYGj9R7c9/koBJ2CUlCLs
 XwAms6fxOMDF5eAkGqKWuplNLO04/eINhXMjFgpGIMunwlB4Fb6I9oWumsnYh40bIBUIlcFf
 XM/pytSuNxvMGL7b5VYftK1GusG7vnxNPvMA6W8gsV1XrB9cwqO/SdLbEGW3nzwnEVErZzTK
 at3Yu73Uy9EVP0PIC6eAr5EjOR1nnxWKXb7GMijpylLx4Zyc5J8pV0tFFKVJt4046qfyOk+2
 4YObpDao/mzvQCXX8U2zWLxBQ1SRZTYLcqvwyCySgJlClA9cI3GI6SJqY7Ng6Q/w8xoeh7gp
 xlRoHNwxlvlnmHgIg6XcH1lY76Hdc8h8SlrZnFyYAfzhCNLjWOTAEE3LcBfkV4Pr7QL8BKJZ
 6NdJ5Xo7gpnFlwrBAjxnbGi9dc/JXxHdCqFPja/YShXQnKTb1ehxzMQRSO2rHNmJnPu7aMW+
 uT8viuGH8Zrb1k8Xa7+NaL+p3vs7CN1sL8jACP1zix7JR+EHH5CcXKh15fa4qgkdH3++9dt/
 13HXE5F9bSR+NJdHRugrfnskrpF2tBWRyJyN2La8ay3JW/d+G+iypVHS+GGYXbWU2acxUloT
 bw9I1zUYKVZ9LqWm+KQy4pW8J8=
IronPort-HdrOrdr: A9a23:cHi8jaH2J0abqvGDpLqFcJHXdLJyesId70hD6qkvc3Nom52j+/
 xGws536faVslcssHFJo6HmBEClewKnyXcT2/htAV7CZnichILMFu9fBOTZsl/d8kHFh4tgPO
 JbAtRD4b7LfClHZKTBkXCF+r8bqbHtmsDY5ts2jU0dNT2CA5sQkTuRYTzrdHGeKjM2YabQQ/
 Gnl7V6TnebCD8qR/X+IkNAc/nIptXNmp6jSRkaByQ/4A3LqT+z8rb1HzWRwx9bClp0sPof2F
 mAtza8yrSosvm9xBOZ/2jP765OkN+k7tdYHsSDhuUcNz2poAe1Y4ZKXaGEoVkO0auSwWdvtO
 OJjwYrPsx15X+UVmapoSH10w2l6zoq42+K8y7vvVLT5ejCAB4qActIgoxUNjHD7VA7gd162K
 VXm0qEqpt+F3r77WrAzumNcysvulu/oHIkn+JWpWdYS5EiZLhYqpFa1F9JEa0HADnx5OkcYa
 ZT5fnnlbZrmG6hHjPkVjEF+q3vYp1zJGbLfqE6gL3V79AM90oJinfxx6Qk7wA9HdwGOt15Dt
 //Q9dVfYd1P7srhJJGdZc8qPSMex7wqDL3QSuvyAfcZek600ykke+D3Fxy3pDsRKA1
X-IronPort-AV: E=Sophos;i="5.88,340,1635220800"; 
   d="scan'208";a="63328879"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=RHsezH2bVg1r4v/udyqxnT5fA09WOKApK89RNo/kzfD1ay2/Hz3DOzHCHkNCeZHhkxdDHfsyEyvWfjN/u54F1n67sAdsQ+inmywBAGy33fZ4D4xG5dUGWdUQFpIIiiMAbKqhjAX7omFxjZWdiRlH0fwTvOdnjj9K0EF9S/P79U4SD6MMCQA426nhzxCbgKpRfr0dpwkJdaVrUVlRuMy59hoDjXsZNTjEmVnDmV57CKsrDvtO+MnMn35mZLfDDllo7Xjqhbm4WWhRzJNPl+B04XnUK1V+1j0ACBmlw5/Uy+54PpKk5UvJUoxVSYA+xPTOYfwrf2pxGR7oSCq/xVJHiw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=CS7V07AIdkGI252hKVMxsoOyL2HAZKXrXAMBhnxgCB4=;
 b=nm89MeaHr9hjoAgasb157cUVbcoTZUj5J+nmQfwCLIvX9fDA/H1/oVVyNPr7EyPgb83dFplLKpjBvaTCoJcmfFkDYJwVLu7knVS0B11AIxl1luDU3zBEJT4e1IHQJmxCjVAB0sWf4EhWlhwicX1Jd5iv+gO3Y68MNkNrFTmw7Ov2w40lwYKXPt221FbQUuj3/Qsz5aQdVaAxAMAsFe17B/dSh4NAJrLC7hY7vBw35cbiSu11YergVLmuN5dbMixK0bNuW+XkZ40F7BcdDoHH/hn+TU/XEhu8GnftJbPvfIk9RcYOC6nvGHf3f5ZhTDRrLVz/IXTwfs3G1Tc5ebWTNQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=CS7V07AIdkGI252hKVMxsoOyL2HAZKXrXAMBhnxgCB4=;
 b=P0LK2xH6cu0/1z6CrRboV91c03+VhXtc09QNs4aEZafnCTzbbITGu5GBJqpmYrAHtUKpKJ5oafVetkFvpsiy95wxzWc/y//PygIC7VaEvEcacBef5qRajnlQEP6qf5pe6eltMDHVsoP9KL/xasCDi5zlhD89TcdJyEwKMY1mcOo=
Date: Thu, 3 Feb 2022 15:05:46 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "julien@xen.org" <julien@xen.org>,
	"sstabellini@kernel.org" <sstabellini@kernel.org>, Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Artem Mygaiev <Artem_Mygaiev@epam.com>,
	"andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
	"george.dunlap@citrix.com" <george.dunlap@citrix.com>, "paul@xen.org"
	<paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>, Rahul Singh
	<rahul.singh@arm.com>
Subject: Re: [PATCH v5 06/14] vpci/header: implement guest BAR register
 handlers
Message-ID: <YfvhOmbFxjKdjI2x@Air-de-Roger>
References: <20211125110251.2877218-1-andr2000@gmail.com>
 <20211125110251.2877218-7-andr2000@gmail.com> <Yd8RJfpEalnfl+CC@Air-de-Roger>
 <d493b022-3c78-1721-e668-48f4553056a9@epam.com>
 <df98cdbd-36fe-0386-c068-2a1540f10188@epam.com>
 <9c1f376a-0df3-67eb-7fd1-bb75ae130e77@suse.com>
 <0171761f-d90f-3e3a-5c8f-e32d70096e27@epam.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <0171761f-d90f-3e3a-5c8f-e32d70096e27@epam.com>
X-ClientProxiedBy: LO2P265CA0189.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:a::33) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 85d90df5-6dac-46df-445d-08d9e71e48f9
X-MS-TrafficTypeDiagnostic: BYAPR03MB4645:EE_
X-Microsoft-Antispam-PRVS: <BYAPR03MB464548E54ADDBE22856BC7478F289@BYAPR03MB4645.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: YckT3gyByQwKvKir3LoD03W3dOx3wuhFDDkgNJmiYf9fTWDBWT9YFV1Ge0DaLJlAv3pu+nGgH2mqNQJSr5BeTDMASGz368kwrU0nYjVyOSg+vTQLfb4YBud6RMIgKANSOsZL8e6Q2G7Z9dAzZaWwXg/9cGbbisDXIT/wOYxjRfnEnj6aj4IOC0ghADkZZ3v0GXK7w7V9Nri5kHShCakDZDY7bzwjIXiz8RwY33Wt65zM/BBNizm2dzZ6Tr2KBv+VonVSsf+ojVMuSWl0O2KpCYF+nrlenDtQD+8mIqeqFD03IunXOnYk8EfK0XGayzh5LF7liUQSzpbYrbaMcPVFjINcHgs2MtZyvBYI6ipV+E3Bt7/GE8DHO8FmmFZpAw+sUzV0qt4mrJsIq7cDGC+LOOGEWU8DeTQC9J+DF+Xyg04xidcVEDQX0KqIz4YyUGA7uiVDY+tFEA5hqtecL3DYgMrbHwzpnGLMRjlFPz1+GVVrVbywhWAFugbO/7C8g27N96Auvn6xTq/MK5fVni3A+Z+cl5mLUIlyPquL/DzYdI43o4RBOLfs6+F2X3QAUyLMw1AYSijfG9XW205mQc5GJFI1mMd1Cj8MdCbfOYCVIcTuxvt+kxRB7+4MHQqbKANyX2pU2vRwrXuUNTdo6EL25A==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(7416002)(9686003)(6506007)(5660300002)(2906002)(6666004)(186003)(26005)(6512007)(83380400001)(53546011)(85182001)(54906003)(508600001)(38100700002)(66476007)(6916009)(316002)(6486002)(82960400001)(8676002)(86362001)(4326008)(8936002)(66946007)(66556008)(33716001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VUNLaXRxc1g3dGJZMmRXbnZRYUtOUjVOUlBsVjdQb0RSWWNmb25wc1d4RHY5?=
 =?utf-8?B?RHlDMElraUlLd3Y0ZENrKzY1aHFaM2FUbVNsckpPWnZyMGxlendNNGJyVng0?=
 =?utf-8?B?ZWtxVUZ5QWhoVml1enpKd2Nub1ZxbVlTMzRpT3p3dnhjKzRYUmZlSEFsYUkr?=
 =?utf-8?B?Yk1xN20xSm00UHNHWTRudlJzSVdWekZJMWYyRUc1VU9lM1hNMy9kNFY2c0Q2?=
 =?utf-8?B?RktzWFJOZGFaRkhaK0RhZmlvZkcxdG1LdmVabC8wTzFIWFpnRCswVFltM21R?=
 =?utf-8?B?dURMcjNiUi8wcGdVWEFOcGhKYXZzZVdOVTBLZURtdUJRTkJHMjdXTjNPRkF0?=
 =?utf-8?B?YW9UZ2VmNUh5S2d0R0JhNzNyaVYya1hwbU5NOWtGZ3hqWnc5MHBQM08zaFFG?=
 =?utf-8?B?ZWpqbDZ3ZEhFSTdrLytIZWtNV0lsRFRQK3UrUXkrbituWmhMYnYrZzgremdP?=
 =?utf-8?B?QW9nTTdaSExiWWxDanR4K21sajBwem9PM3liMHJvdUVMNm9BWm00TDNLQysw?=
 =?utf-8?B?RjlkZC9OdWtSdUVqVld5UzVKUnRQZW1DdnVaa25SQXJnYzFKQXNNdUMvUy9i?=
 =?utf-8?B?TU5kclhINmpPa1BWY0hYbkw4Wk9jMWMvVUFGOTdvUm0vV0U4eUNMa1dCWW5t?=
 =?utf-8?B?eWpaWGxJTDRlNnRtNTNUcWhJTENSQmN4MncyRGdWZzZYYXFXMERKeGc5R2JZ?=
 =?utf-8?B?NjVra3BFWXMwcTdUMmZETnk2UUw3MjVuaTlMYXpLbVNXM0l3Ukhqei9nUndG?=
 =?utf-8?B?aW1wOUJsSjY2a2tGamJCSVhGYkVmSU9oeStLSUhCenBPb1dDVkFxNkNwcHRq?=
 =?utf-8?B?Q0FmeFVjMUR0SzdkZ2ZaV1ZIOWI5RGlyMjF4R0ZtdmNyWTZyWnJFM1AxZmxG?=
 =?utf-8?B?NjRKcDJpVUovQkJad2RoSTJBVFpaM29zRENOUzUxS1ZIR2VEM0w4OTFRWXQr?=
 =?utf-8?B?Tmd5WVVhUGtVdi9raHExQjlOZjFDVDFaUE9DdVFHVXZISUhXVzQ3b1RIb210?=
 =?utf-8?B?ZHNKaFltRE5SWVV0Ym9rSUFhRnhBR3lVUzdYR3FZSWQ5ZEZvWnBYaHNlTmVy?=
 =?utf-8?B?VXdGcDhmb2pXbHVFUFQ5VTRERGdic0grRDNoL3hsWmM0UHVTVTdpT2FHd1Fq?=
 =?utf-8?B?eGk0dEoyTVdaMnZxcnl0Wk83ZTZhTzF2alEweG5qbENMSzRaeFA4aFh2UXp6?=
 =?utf-8?B?VWFzMDU1VkVDV25hejJlbS9XZkwvN3Vtdy80SkdWNEZSZzE2MXJBNi9qc2F3?=
 =?utf-8?B?SmEwaGg3dDlrRkpobjhsbTJuVXVvSGM0SHN5ZkRwMXVxejNCWDAxTU0xQjZE?=
 =?utf-8?B?ZHdpdVVIK29mQUE3cWUxRE04Nzh6YjJGaFdSK1F2NWRsWCtPWHluRkgxS1hM?=
 =?utf-8?B?ZmFsdTlaSTFvbVdLdHVSWHdIWDdVS2tPcVRYWnNVZ1hrdTRrY29xeE9PS1do?=
 =?utf-8?B?a2dOeTA4N1E3QTY0QmladWJ6MmR6MkNHRk9NRlM1N2hZajV4eEVyNm9sSGVq?=
 =?utf-8?B?dnBRcktQb3p0YUE4NUdyUHpYQVVIeUMvT0RrV21BVDhmcDJvUlViQWIyazZp?=
 =?utf-8?B?dlZBMzhqNDBJeThsaUN1R0w5K2ZGU28vbWR4b01YK0k3SWxYM0JlNkNhZ1NO?=
 =?utf-8?B?QVBmQVpJZm5zSzN1WFJ5TVhPQWtiQ3U4dm1zTlVPZ3pHaXUxQjJhT1NUQXRI?=
 =?utf-8?B?VENSQlgzUVNCMitvMWRrNmw4dWJkRnFnd1JYV2tBd2s3d3c1Uko3VXQ4VGh4?=
 =?utf-8?B?dVRsODM3M1AvMjJSWlVXd2dvMUpzZkxtZVJGbDZwalNCNkd4bjJIdWpwZXVi?=
 =?utf-8?B?d21JUnU0bktPK05NT1lBVFp5OFI1NXJkVEVTcFIyODk4WFhXZXgrZ09hTmVY?=
 =?utf-8?B?L1UrV2d4RHFsL1VqV24wM1pCWTRGK2xQM1M1SklYamxXQXBhY01iY0IxSFRY?=
 =?utf-8?B?RkMwTVFWQU41RUYwZWtOKy9NbmlDZVNpNXlzak9DeTd0S3cvZXhDTW1pWkRh?=
 =?utf-8?B?ZWpnS25yY28zdTMwdXZ0Zzl6ZU5KRUppNG1vY2JPQkVSL1Mwck9kVFFKTHkz?=
 =?utf-8?B?Qjc5bjg0Zis1MzJwNTduanE0NytWMnV4TlBKMWtkODlPY1FXWE9NRzFBZlBt?=
 =?utf-8?B?cXhxT1FkOXcyNG1vRHhwcXVHQ2IwdjVlQ3AybEowWEYwb0JqYlR4ZGIyeW9Y?=
 =?utf-8?Q?ltOdCyK6ebZ+aopKr8X92xo=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 85d90df5-6dac-46df-445d-08d9e71e48f9
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Feb 2022 14:05:51.0528
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: z6eaF2OTaIRuPK371pOpJS0q7ereC6eZXa2bz45m06ji0gSISAQU0XLCpplTx3b/LHDGyPgLmgIw8xSD61SQdA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4645
X-OriginatorOrg: citrix.com

On Thu, Feb 03, 2022 at 01:30:26PM +0000, Oleksandr Andrushchenko wrote:
> 
> 
> On 03.02.22 14:54, Jan Beulich wrote:
> > On 03.02.2022 13:45, Oleksandr Andrushchenko wrote:
> >>>> Also memory decoding needs to be initially disabled when used by
> >>>> guests, in order to prevent the BAR being placed on top of a RAM
> >>>> region. The guest physmap will be different from the host one, so it's
> >>>> possible for BARs to end up placed on top of RAM regions initially
> >>>> until the firmware or OS places them at a suitable address.
> >>> Agree, memory decoding must be disabled
> >> Isn't it already achieved by the toolstack resetting the PCI device
> >> while assigning  it to a guest?
> > Iirc the tool stack would reset a device only after getting it back from
> > a DomU. When coming straight from Dom0 or DomIO, no reset would be
> > performed. Furthermore, (again iirc) there are cases where there's no
> > known (standard) way to reset a device. Assigning such to a guest when
> > it previously was owned by another one is risky (and hence needs an
> > admin knowing what they're doing), but may be acceptable in particular
> > when e.g. simply rebooting a guest.
> >
> > IOW - I don't think you can rely on the bit being in a particular state.
> So, you mean something like:
> 
> diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c
> index 7695158e6445..9ebd57472da8 100644
> --- a/xen/drivers/vpci/header.c
> +++ b/xen/drivers/vpci/header.c
> @@ -808,6 +808,14 @@ static int init_bars(struct pci_dev *pdev)
>               return rc;
>       }
> 
> +    /*
> +     * Memory decoding needs to be initially disabled when used by
> +     * guests, in order to prevent the BAR being placed on top of a RAM
> +     * region.
> +     */
> +    if ( !is_hwdom )
> +        pci_conf_write16(pdev->sbdf, PCI_COMMAND, cmd & ~PCI_COMMAND_MEMORY);

Memory decoding is already disabled here, so you just need to avoid
enabling it, for example:

    /*
     * Memory decoding needs to be initially disabled when used by
     * guests, in order to prevent the BARs being mapped at gfn 0 by
     * default.
     */
    if ( !is_hwdom )
        cmd &= ~PCI_COMMAND_MEMORY;

>       return (cmd & PCI_COMMAND_MEMORY) ? modify_bars(pdev, cmd, false) : 0;

This is important here because guest_reg won't be set (ie: will be set
to 0) so if for some reason memory decoding was enabled you would end
up with BARs mappings overlapping at gfn 0.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Thu Feb 03 14:06:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 03 Feb 2022 14:06:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264808.458057 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFckt-0007W3-OX; Thu, 03 Feb 2022 14:06:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264808.458057; Thu, 03 Feb 2022 14:06:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFckt-0007Vw-LK; Thu, 03 Feb 2022 14:06:35 +0000
Received: by outflank-mailman (input) for mailman id 264808;
 Thu, 03 Feb 2022 14:06:33 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=OTfZ=SS=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nFckr-0006zt-Df
 for xen-devel@lists.xenproject.org; Thu, 03 Feb 2022 14:06:33 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7d82090d-84fa-11ec-8eb8-a37418f5ba1a;
 Thu, 03 Feb 2022 15:06:32 +0100 (CET)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2053.outbound.protection.outlook.com [104.47.6.53]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-30-RtRnLS0VMYuJjgIg7PDz5g-2; Thu, 03 Feb 2022 15:06:31 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM6PR04MB4502.eurprd04.prod.outlook.com (2603:10a6:20b:1e::32)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Thu, 3 Feb
 2022 14:06:27 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.012; Thu, 3 Feb 2022
 14:06:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7d82090d-84fa-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1643897192;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=fTJlA7TTaL3xCbOgLXNAaiKwODuEMRIYffQ3vaXAS2I=;
	b=jrmOgpLwuOQ6cHlsjkYjJzFtOG4GbMWpd84GlAiuo4F4HFTLT+7AlON7zFxYIdQPS0YM1z
	AEeK5u346o6vIEFtujzJ91NLPCv+n0L0iF9E/vQLb7mjkQZcmJz6ixlx2uC2OBOcikiPNy
	k4UkoyK0Z5x8WPIo6TU/CUSyUg7a1Ec=
X-MC-Unique: RtRnLS0VMYuJjgIg7PDz5g-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=oJrEr0l8X9xx2dDAeOUhV1+Csz1kziuPiGWlz0umj8qtB7QfgcgrQiY8kbAGT2dWmhQdJXhWc2QZK0/fVNbEnk/KGGDZ3aSRSMHO+YFVQ1q6mPU4iU0SHzQOJrduWo3Pm87x0cptUAv8q3UpuYfaITar7/Fbqfo01uvWUTBiTb47JtYrfa/fkQpobaKZqMgLNhGaROHtQ1+cXSSkmCEyc7kM0LKFxbcFSMLWJy16TzM9BY279TzOqfaPTDjfMD1qZkd9TekFaVs0VAmRzei/nfMQOYqm69mo1Q+mQM/x1r7HtYFlj0FUedzOJJAMjl17ELvLFPqhUJJg5ieaNA5IAw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=opj1CAKwFYlKWMUE70JjRXBz6CijP/Uc3r88g87i9BU=;
 b=AU1uFh0SyR7VzkwH9VgBeK3b+tzVyDx5KEUijsSzwyI3yU00h4jXgBtMWJjG89du/KEANbXp8drzkpXLXwwkxF2eu4TUpHxmEnbr0ho/bcY8zZPeeN/r5/mGGW3hLemy/qekS472nNn7TlSIr1Oko4VyURNy0WDH5iEB7DbOoAohBphErnqHZxD/yP4Kyk2GIyNvKKRGXFpx0UGmNzuD5c7xpACOX0YCgj58klhxnG1wlI3hJNFTZ/mqmwS1r9IjLMjrDdHgRlLBA8Ia/pDAroGHiyFt+djPFOXy5ANzX3dXN+bSvJMph1UvKFqTb8utC6r+iF6YaZqhHynT9+XIYA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <09a5284a-4cf4-1b86-47ee-03b572639763@suse.com>
Date: Thu, 3 Feb 2022 15:06:25 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH] tools/libxl: don't allow IOMMU usage with PoD
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>,
 Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org
References: <20220203110651.17419-1-roger.pau@citrix.com>
 <bae9ad85-a26a-67f7-93af-166cc743e046@suse.com>
 <YfvdsDQA/QfZAewh@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YfvdsDQA/QfZAewh@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6PR04CA0057.eurprd04.prod.outlook.com
 (2603:10a6:20b:f0::34) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 51f69950-bfee-4599-f35c-08d9e71e5e7e
X-MS-TrafficTypeDiagnostic: AM6PR04MB4502:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB4502D874A3B4A91B9BD55802B3289@AM6PR04MB4502.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	uRMkUDgKLm028ExGCmIVAq7VuU6sqMb4APu1FC/uqCczDoAuxwLuzaiBdwmWjqv4vpfNc/E0tl3OCqFVY08KcRedIowondND2LNU18EMLmbOfS3HwJaDOBENTZsaJj2V+tSlrWPzcFXi7Rov8CbkaX9QrTjB8wWWQIb/cBmDqgUWIxLHYNJecKnucWQl7KpMQZIKzsw0U39+TQJRnIzn6JK5QE3fPCO/rO8V5a5+ljcNB17Z6UsBskc0GlGqiRpkeHCkvz4lR/dBFifKyUh3EOxmo+MmrOb5SP0zWUjP+/2ZUx0j1lKaIxyHmh89TP40guUbCP3WkArU7/fKqwfID6DkyoBuFUuZQGvXsdwETpAfD0Uaqqb1jHWuPO4e0f2roP17+31a06JqT9nWgsx9kdIs3JpY1z2Qml2Ihz6cI7U8NLdeTwO0p5b5lDEtddTYoQ5lmUBlPZiYiU30ACZQUwVEECU9ebFbaQKN6QXSxKvPMrZcyb84Gy/qQoof26fZbx6xd5NDW46zDse38H2GFHYxotpC0ckOYf+xwyVE4P/9ovvkmtrMLqWn4oytAz5SFgZOsm92l4R2ssj4/QtomZxaMHdJiLsBYctEt5PvH7a9Zborp0mdMg3FsoqSzuddiu5SZzq6WksuRsmqz8vPMBYcACFddOZCuMWK+Dkz6I9M2tY7PlYMEMlmwbsfd9DAOSwz6aNnc0BqKM/qHHW3yd9Vd895qZue7kLO1Od3SXNunLqJvJykXa3fWGR9sC70
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(508600001)(31696002)(8936002)(6486002)(66476007)(66946007)(66556008)(8676002)(38100700002)(4326008)(86362001)(2616005)(186003)(26005)(53546011)(6512007)(31686004)(2906002)(36756003)(6916009)(54906003)(316002)(6506007)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?DrtMlqJx2zDaVcn+jQMEzbzf2jAuD1ftt0YGFCOpYnMASPtD2qAALc0CWIv5?=
 =?us-ascii?Q?o8gB0Iv1WDQNcFfhrxgh1EZm/9jfIV+4DF2HFRYkJ06V0wQ2l6LUnLVbesOx?=
 =?us-ascii?Q?ZABaLjmaXUc12dzR2i9TJrFSfjR9guBZUk8Bc4iM+6NiGXYI45HYWyCpjeX5?=
 =?us-ascii?Q?bPsUY6XBjDzwqzB/sPmaMVSAqhmOtdamr7/h/2aRecCOG5y59CwvzzzE2JBx?=
 =?us-ascii?Q?Q1KdHjc/56+ghF9wrHsoeeJWdmnKrFb13UYpmcY+M7fvGN8UHlsKuHIO0n3t?=
 =?us-ascii?Q?j0RXhbX2LR53PzfJpv3TERW+01pD8+QyfbCQX7mTSnlC+LzS2aJpmWXLPfLe?=
 =?us-ascii?Q?jTqB5F8WupYvqobvlqXrOaO9fEw/rA3r9xC0n9sQdFKPfHtdUyFjZCW2roIs?=
 =?us-ascii?Q?Gu/EOWV9pP+Ee/uCVw9jqgOsarANW7JxAfSFD4sH2gaZl+I3R3/BPsUZtZ8A?=
 =?us-ascii?Q?78Hk1m0lWmihekeJ/smiaXclvvNLM0OL1gdvTrdWdIzpyf4Nrqi2pVzhlK8G?=
 =?us-ascii?Q?jCVs3o/umtWKWHWxR2s1YDnpfbXN+Etd69SzJmFyHpOXvfSoKDbAmbGTeRwX?=
 =?us-ascii?Q?RcEqGLXdMaQnmTAAayPaosBi9ygbJHIrExzlBW5oBeV86/sN5M37MTNJGE/D?=
 =?us-ascii?Q?v39QE6/jBTd4oGDTONFpslBtVRC8ScqvL9BQdTYraMla57r4KCaz0NkVjik8?=
 =?us-ascii?Q?PNKA2SELbGgA6T2+A35vUe2Lh2klg3IzaRiVhbVZGWQ66h9IBeFVxuTRX9bi?=
 =?us-ascii?Q?B1RPXQDHqfRU3DuQhinocK4FiXe17GwosSPeMX6H0/JPmCyP/isFc926jAU+?=
 =?us-ascii?Q?EdJKsd4z5X/keEJblxKWI69QOmBeJOGm/5IexoeYtq3usTJRTwLscmfuSpIO?=
 =?us-ascii?Q?i3L5eWP9nHmaQQOvL+6RBWd/uSvPFJhw7/W5PhNRWMYVYFBmXDU4uda+EBtF?=
 =?us-ascii?Q?3WiqSaDXLii5UtVmXRRtOmYIU0nOzy5jroyhxqtWTVuB3XZ42rSeqL6foDzx?=
 =?us-ascii?Q?xxh4HoucVbnc9l21BG4K9vQeXiWr+7LagiPqf/92cjKwfWlvn9iLrMNqspKU?=
 =?us-ascii?Q?peBlbRnKPt7LuZzX7C5g7xJxK+UWn0DznQpBiqAJ2sBzgxG9YpQrEjkufBRA?=
 =?us-ascii?Q?z+SUybnaRDIrH2u2+5QoEjJCE8S0ValviHCnyq4vxIiaWq0Zsp9ieh0zC3dc?=
 =?us-ascii?Q?NsI0lVQbETJk71yFFsJVu4L5aX4KSCIAtMN3ZZhIq2UO4GsWF81ABpTfYU9h?=
 =?us-ascii?Q?l36iCa2Mc8SY7Vn0tZOt1ifsw6hglnxRzMTv//T7hCUzH6sTBGmB7NjJPMVm?=
 =?us-ascii?Q?VYunZb1xfc7zk2u9JZ0dAS5CcG4sZ53D7tQ4HmYyIPZnDSSy+q3Eh1+vKFk0?=
 =?us-ascii?Q?jcuny3ygn7SSw0nc+jMHakdc31BV5PEuVaa/gPSwpH3tAn+ZxexODs1NRsm9?=
 =?us-ascii?Q?EdtgR7J1GazPnf/s/KNLGHn/4LQfBseB5kMczqz8lbjbBRbPOLVeYxrpJDkx?=
 =?us-ascii?Q?HcgihYJWELicsd+h4tnxZYULnvq6bJ/I+coTdCSAUYK8XREXwDsSoHTvvVC8?=
 =?us-ascii?Q?o/BxugowF7Rka8e32+G4j6OyS2c5M//7+vZibLUBT9Ib7csM5npbtIYZRxdp?=
 =?us-ascii?Q?aIo+zR8kpDaVZCIyy3MHN4Q=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 51f69950-bfee-4599-f35c-08d9e71e5e7e
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Feb 2022 14:06:27.1455
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qNf2NA/hbY39EBasMDsB6TN2XAxuiDwqx4c0UNcKRTJKJKNRaynWJwtCHOjYfp19oYbXe6woh4tnBJJXoh+tWQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4502

On 03.02.2022 14:50, Roger Pau Monn=C3=A9 wrote:
> On Thu, Feb 03, 2022 at 12:55:56PM +0100, Jan Beulich wrote:
>> On 03.02.2022 12:06, Roger Pau Monne wrote:
>>> Prevent libxl from creating guests that attempts to use PoD together
>>> with an IOMMU, even if no devices are actually assigned.
>>>
>>> While the hypervisor could support using PoD together with an IOMMU as
>>> long as no devices are assigned, such usage seems doubtful. There's no
>>> guarantee the guest has ballooned down enough memory for PoD to no
>>> longer be active, and thus a later assignment of a PCI device to such
>>> domain could fail.
>>
>> That's not a precise description of the constraint: The guest ballooning
>> down enough only means entries =3D=3D cache, but for device assignment w=
e
>> need entries =3D=3D 0 (and a guarantee that no new entries can appear, b=
ut I
>> think this is already the case once a guest was launched).
>=20
> Would you be OK with:
>=20
> "While the hypervisor could support using PoD together with an IOMMU as
> long as no devices are assigned, such usage seems doubtful. There's no
> guarantee the guest has PoD no longer be active, and thus a later
> assignment of a PCI device to such domain could fail."

Yes, thanks, this sounds better (to me at least).

Jan



From xen-devel-bounces@lists.xenproject.org Thu Feb 03 14:12:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 03 Feb 2022 14:12:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264822.458068 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFcq9-0000ka-In; Thu, 03 Feb 2022 14:12:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264822.458068; Thu, 03 Feb 2022 14:12:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFcq9-0000kT-DM; Thu, 03 Feb 2022 14:12:01 +0000
Received: by outflank-mailman (input) for mailman id 264822;
 Thu, 03 Feb 2022 14:12:00 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Ap74=SS=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nFcq8-0000kN-JC
 for xen-devel@lists.xenproject.org; Thu, 03 Feb 2022 14:12:00 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 3f1816c8-84fb-11ec-8eb8-a37418f5ba1a;
 Thu, 03 Feb 2022 15:11:59 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3f1816c8-84fb-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1643897519;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=jmG3vSUwUwV9cYyaBAFqu3A2a77D0HHSIhiZMswXxvE=;
  b=ZIcMrFIh9UAmeLBxSKpJS0j5DIJBtAOQ91PmUA8cq/QIoJEq89JPdmey
   EV60Cld5+XH4fA0F8lO1TtECbpZzUIAsYMGhF7DGQtP4hBH1XCoXlQZNy
   0mrmtsKYF3r9WZvCGHLRztDtCDHK5EZq1FCxG/yzya5+wAkQW06ej0SbU
   g=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: f10cTp67eEl40J5hV1Yu3rFsQwAckBVc8oRChnm3SeeZVyDet9XM4o8R+aNBf/6NIkV1w4HkCP
 xEZJUHMdNNfeMD8nZEcjEZfigZTkj4S7tJ1FAJ5lnYPjYzPzqoa15IE/jKGLwx2HXoy6D7cJJp
 pXYVhWekYdb041+jUcqmnGbPLXhrepKyNo9pNL/MMKdCRUEibWZUNAmhMlP+1cppiO0w3I+O9Y
 h+36vM03808WEA9TwRlA5WmNsSJaE/eZyWVbDECy/vcH/XALzqthuj/trBMixfo+5g20NPTaeC
 DZG4N1YmEhYqAUI3U15VllMQ
X-SBRS: 5.2
X-MesageID: 65617163
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:PojeeqkjJeC0zvECSPsbISro5gzDIERdPkR7XQ2eYbSJt1+Wr1Gzt
 xJKWjzSb/veMTOkc4oiOdvg9ksAucXUxoUyHQJoqSBkFCMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BClVlxJVF/fngqoDUUYYoAQgsA180IMsdoUg7wbRh2NYz2YLR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 NRD6ZybERk2B+rRpv4iDSkGISY9DLITrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBODtMJkSpTdLyjbBAOx9aZvCX7/L9ZlT2zJYasVmQ6uAP
 pVAN2EHgBLoZzZUAU4cBJEEsMj4uSHFcmJe8kiejP9ii4TU5FMoi+W8WDbPQfSRXtlclEuco
 mPA/kz6DwscOdjZziCKmlqSgevIkTL+SZglPrSy/f53g3We3mUWThYRUDOTq/SjllS3Xd4ZL
 kUO4zcvtoA77kntRd74NzWnpFaUsxhaXMBfe8U49QWMx6z88wufQG8eQVZpeNEg8cM7WzEu/
 luIhM/yQyxitqWPTnCQ/avSqim9UQA3B2IfYS4PTSMe/sLu5oo0i3ryos1LSfDvyIevQHepn
 m7M/HNWa6gvYdAj1qvn/XufnS2V4YX3VDFr1lvlWSGU8VYsDGK6XLCA5V/e5PdGCY+WSFido
 XQJ8/SjAPAy4YKlz3LUHrhUdF29z7PcaWCH3wYzd3U032n1oxaekZZsDCaSzauDGuINYnfXb
 UDaomu9D7cDbSLxPcebj29cYvnGLJQM9/y4Dpg4jfIUO/CdkTNrGgk0PiZ8OEi2yCARfVkXY
 8vzTCpVJS9y5V5b5DS3XfwB9rQg2zozw2jeLbiikUj8geHDOiPEEuheWLdrUgzfxPnfyOky2
 40HX/ZmNj0FCLGuCsUp2dJ7wa82wYgTWsmt9p0/mh+rKQt6AmAxY8I9Mpt6E7GJa599z7+Sl
 lnkAxcw4AOm2RXvdFvWAlg+NuKHdcsv/BoTYH13VX71iidLXGpaxPpFH3fBVeN5pLULID8dZ
 6RtRvhs9dwUG2mepmRAMcKgxGGgHTzy7T+z0+OeSGFXV7ZrRhDT+8+ieQ3q9SIUCTGwu9d4q
 Lqlvj43i7JYHmyO1e7aN6CiyU2fp38YlL4gVkfEOIALKk7t7JJrO2r6ifpue5MALhDKxz270
 QeKAEhH+bmR8tFtqNSZ17qZq4qJEvdlGhYIFWfs8rvrZzLR+XCuwNEcXb/QLyzdTm795I6re
 f5Rk6PnKPQCkVsT69h8Hr9nwLgQ/dzqo7MGnA1oEG+SNwagC696I2nA1s5K7/UfyrhcsAqwe
 0SO5tgFZunZZJK7SAYcfVN3YP6C2PcYnijpwc40eEiqtjVq+LenUFlJO0XegiJqM7YoYpgux
 v0suZBK5lXn2AYqKNuPkgtd63+Ici4bS6wiu5wXXN3rhw4sxg0QaJDQEHarspSGatEKOUg2O
 D6EwqHFgu0ElEbFdnMyE1nL3PZc2stS6EwbkgdaKgTbgMfBi982wAZVoGY+QQlixxla1/5+Z
 zpwPEpvKKTSpzpliaCvhYx3992t0PFBxnHM9g==
IronPort-HdrOrdr: A9a23:scwelK5/2yyFp4mrcQPXwW6BI+orL9Y04lQ7vn2ZFiY6TiXIra
 +TdaoguSMc0AxhJE3Jmbi7Sc29qeu1z+813WBjB8bcYOCAghrpEGgC1/qt/9SEIUzDH4FmpN
 9dmsRFeb/N5B1B/LvHCWqDYpUdKbu8gduVbI7lph8HJ2wLGsJdBkVCe3ym+yVNNVR77PECZf
 2hD7981kOdkAMsH6KG7xc+Lo3+juyOsKijTQ8NBhYh5gXLpyiv8qTGHx+R2Qpbey9TwJ85mF
 K10TDR1+GGibWW2xXc32jc49B9g9360OZOA8SKl4w8NijssAC1f45sMofy+Qzd4dvfrGrCou
 O85SvIDP4Dsk85uVvF+ScF7jOQlwrGLUWSkmNwz0GT+/ARDwhKdfapzbgpAycxrXBQ4O2UmZ
 g7rF5w/fBsfGP9tTW46N7SWx5wkE2o5XIkjO4IlnRaFZATcblLsOUkjQ5o+bo7bWnHAbocYa
 NT5QDnlYFrWELfa2qcsnhkwdSqUHh2FhCaQlIassjQ1zRNhnh2w0YR2cRaxx47hd0AYogB4/
 6BPrVjlblIQMNTZaVhBP0ZSc/yDmDWWxrDPG+bPFyiHqAaPHDGrYLx/dwOla2XUY1NyIF3lI
 XKUVteu2J3c0XyCdeW1JkO6RzJSHXVZ0Wk9iif3ekxhlTRfsufDcSzciFZryL7mYRsPiTyYY
 fGBK5r
X-IronPort-AV: E=Sophos;i="5.88,340,1635220800"; 
   d="scan'208";a="65617163"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ioR5UmMJoCUbOXLCGpWotVZN2oESWEZ7RvvVI2L/PQki/k/DLjmF1dflYHxnr3fUpweYcwh10XzLd6HPCeWDwpHWu+wPwgWEwpeD/hvsu8FDueAUeUvAT6PEQZayPZV/s9LEnlZl3LL99itKrz6bNMDqjXHPgJpCcccS/oTuX3tgMD9X+Z8nq0OYa6Iv3/KWEsFqMGCO12IIAPwrdiVlnOOy1ugtA0T3mvVLxNSK9ShXYWBZuUZNcNGNsgSQwFKEXeTJdf6c+Hwg6GeDmNZIsemUfyjm5S+yBUyX3bO7Dge9wl/cH68B2UKOzD/6qNyuSn6WQZtQv/X6ELxHIgtu7A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=jmG3vSUwUwV9cYyaBAFqu3A2a77D0HHSIhiZMswXxvE=;
 b=KPEM4j9AFANoI/jY5vKwrakibHh5PhPKnNT2+ATXzeH/lT2V/OIp21CtLnpovxTC/N4DitP+EdU+BzGksBy5W1H8couxLBTNA6tWgk2tG8DX62UeXx9EheQMriI/mIIUN5frXwEN0H4j0DKV9DTg2KyWwWXVy0ZtNualEEKEtPDKksjJ7DZJ6M8M2rPqH54D8jbf5wRaUCWFsnNo537s3U5DzcgWlOWas1EEGtpxQDF6Owuh3vT6WMXQmWO2NeQxQsXuCLJlHh4U1MIj4KP5f9xtS3/f0vh/mfQufj0jvmEUF32IC2fUSRuhwEG26KXpjaGyW9eztXPBSrGlZRA4vQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=jmG3vSUwUwV9cYyaBAFqu3A2a77D0HHSIhiZMswXxvE=;
 b=CO+ybC3wQPgC6aFgFEZCdOipxL9SSvUe1BbWBcZqgaL9+HXC3G6r2yimMeaxK3sXVehuBaXyvpIjQWiZrQsa7pHe6AsWNpZ7IcZK7g7ovlgeqYR8CjDA89jqaluKJjKVg+2SN8q9L7ZRVeimgQKgjEIHQvSSYF1dw0puRUpH8rY=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Julien Grall <julien@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
CC: Jan Beulich <JBeulich@suse.com>, Roger Pau Monne <roger.pau@citrix.com>,
	Wei Liu <wl@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, "Volodymyr
 Babchuk" <Volodymyr_Babchuk@epam.com>, Bertrand Marquis
	<bertrand.marquis@arm.com>
Subject: Re: [PATCH] xen: Modify domain_crash() to take a print string
Thread-Topic: [PATCH] xen: Modify domain_crash() to take a print string
Thread-Index: AQHYGQNtP3H+icKR40C9qFef/QWZtKyB12EAgAAGeoA=
Date: Thu, 3 Feb 2022 14:11:31 +0000
Message-ID: <ad7467d2-1cae-c8ea-1217-69f0924044d4@citrix.com>
References: <20220203133829.7913-1-andrew.cooper3@citrix.com>
 <c0d82900-64d1-fe16-9283-deb7c324ff8a@xen.org>
In-Reply-To: <c0d82900-64d1-fe16-9283-deb7c324ff8a@xen.org>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.1
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: e1f0a0b5-b59c-48a7-d25f-08d9e71f13fe
x-ms-traffictypediagnostic: SN6PR03MB4464:EE_
x-microsoft-antispam-prvs: <SN6PR03MB4464CC9EF82B6C0DEFB69647BA289@SN6PR03MB4464.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:1332;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: LS9CnTEIEkDgCSBfknk5WvqRdbFjo7sHhzywdh2PpM4uNWGgizDNURKg+Kwz/CcdaC53zQc3qdGDmjekYvBmudUh9MPKGL9OI5gx3Y2u1DO2Xq+qJQNJpod8waj2PYl+pxrlmVudyEMVACd6JG/vOAhsxUAET7X+AWdimgRG/xN6ZSadBJc/6ZY4jW2b0bA9v6chQp0KvO9R328CU4BN8duxrs7IHq/tQ1F0Sf1/sJlJPJVLG7KNOgfQOsofYLhuu7m7WlFICKYnS+oMhTmJb+Q+0A+IMDHOqnGblbW+Rc4W5qAIgHJoOQv8tD1cBgoZzd0BU93wbYVyd1mf1Sy7JOwqRVI8+YmB21d+UWzLhuuYJih8xlnAiuAqb080EfQaFR7kE+XwhrcbSBAw7ZrmLHZbv562v+CX5DJmLFm6ouj2rvIxwWe1xXyuUn1I6g1fFgkZO5PWp7POxEPVhnmvY1fwkiZ/5WvaU5WI+UgF5O67I4G2A/mL4i7oZcnUGInqq02XSuWSsIAEsw0nPv1ZcZyAWpzwq18+/ObNHX/K3BiG6S1e2YonzQuUrkSlVuyW5OxvmVaLF+kCSyJ1tbP7hTytuuGoj8L6o0duJbZQWZr+i+vIjWuGSUwJUk8OFmL18GBmuw3Ht1+tjwRjQS5a9SwS/NlsIMSDumnRYKGu1S1Ytw9rUmXuuxdXxQPlrfjRVkEbio9Gxzn8y2j9j9VaOz4rvgooJUsiwdUv6M5MbXaVukMNJ7MeDHDZgXn+6Gy2Ly042Tx6s/oeqxcLDIrOSw==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(5660300002)(8676002)(66476007)(38070700005)(2906002)(4326008)(8936002)(6486002)(66556008)(66946007)(91956017)(76116006)(86362001)(38100700002)(64756008)(66446008)(122000001)(31696002)(82960400001)(186003)(508600001)(36756003)(83380400001)(316002)(26005)(6506007)(6512007)(53546011)(71200400001)(2616005)(110136005)(31686004)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?TXJTRU5sckdYZm9pckx1aEI3U2R0L2ZJV0RlRWNzdDY1WElGSjQwUndmQjAy?=
 =?utf-8?B?MGEwY1pyYUd2aVQ0ZVhkaFF5ZHJBK3hIKzdST1dZQ3YvOWo2U1d5Rlp6VHdD?=
 =?utf-8?B?U1hKM0k1K1RQeFlnayszclBDYjR4YldpcTVQcm5keVBzMWZLaDgwK244cGlQ?=
 =?utf-8?B?ekF4UlF0Q29iQXRtU0hJSkNXVEdLZDh4ZStWbWVuNUN3dG16MjYwVWltZHll?=
 =?utf-8?B?eU4vdENKeEJNVU1hREVjd3ZuYTh2Y3VtVEl0bzlDZUlhMGtKbStER3Rsa3lH?=
 =?utf-8?B?bHA3SWlBcGoranhsL3FxcFJ2alk5cEErMkJ1dWtVRFYxOGZ6ZVYwY1JsTW5z?=
 =?utf-8?B?VzNzTTJWWjVIZUxoVmNPVlJZYWYzL0c2aHIva2VqbFlGblFtWG1iQXR5L29p?=
 =?utf-8?B?OGRzTDQybTFVNnRESUxCRURGdkZqRE0wdXM1NnEwdmhKbFZ2UDhSZEhxbGIz?=
 =?utf-8?B?TCtKdndnNkpIbjhJb0ltbjdYK2RYVDh3T1BsaTY3YWUzaXV4NlhlMVRMWCtP?=
 =?utf-8?B?YnFkWlpHQkFUY085VUtrSUlram5CVERGbWNDQlhFelFqdFVFN1NSWTdzQk91?=
 =?utf-8?B?T2hDSEw4aExLeXBVZ1QyVW1zdFhyS1FBWWU1UzM1aEl5MFk5c3k1NmpEU1Qx?=
 =?utf-8?B?d3FpR2prTk9zV1dKclBKM2lMTU9GeFR4L0hpLzRLWUNpdERnOGl0b1lWeW5O?=
 =?utf-8?B?Y2dMRDZqcjB5Qlk4QU1IWEtXRTIvNWtqVUJxTE40U3dYcGRxVnBlTENJTUZB?=
 =?utf-8?B?N0VGQ0JUMWNVTURiN2s0T2pkbzA4T2lyYjdkNXNXNVlBci9mU2JZUTVSMW15?=
 =?utf-8?B?MThBNzFxRjVrd0FrVW9HY3ZlRTBWbDhqTXR2ZHlGKzVMQnNHVmx5S3FMc3dC?=
 =?utf-8?B?bkNpM3puRXFhY2I4YUx4UFlhSWwzdTdydTd2ZVBaanBOVFJIWUJWR3NFRzlC?=
 =?utf-8?B?WndOc2hDaXo2SjlucTBxcTVrM3Nkc0s0bjNpd1JFd0dySDU0cTBSRUkyYUNZ?=
 =?utf-8?B?RUwyenEybzhNRVprVUY1TEpOMVcyWWhXOU5BNmhweVVZdHRVOHdpSTc0TlZ2?=
 =?utf-8?B?RnZlWnAzTGh2eks5M0JQODA0RXp4SURyRnB6YVcydC9WM3czSVFjenA3TG1v?=
 =?utf-8?B?UDBkd2JmTFp4Y0RCTC9jWS92UVBJaDRsdlRKY1N6UzFHc0krUzRCUjRTS1la?=
 =?utf-8?B?TTFwRTlQS0N4ZjJ5SUdpL2FFdGcyK29ob1dIUWR2MDJnWXRaVE1qMXV2OS8r?=
 =?utf-8?B?V0FRdkNpQi9kek1wZFpsUnB4ZmsxZCt2M1gya2UxZkVjcElBazNQRjlGMUw5?=
 =?utf-8?B?QUt4bnlRQ3ZNemdzcy85eS83cXFzVEhzY1BSRXN4eTBSVG5mdnZjYlJyTWtp?=
 =?utf-8?B?aDA0YlF4N3NlME50QUh2TTZFOUJsUzZkR3ZjOFV3MnNKSlZkRnlsZDE3b1Uy?=
 =?utf-8?B?aDdZbERtUEFIbU1pYzdkTS9KSzlldE94Ly9ueW9hV1lIMlM2cm5jUUlXd09O?=
 =?utf-8?B?L21EMkF3MTJSMXRIMHBDVXRXMkFDUXppYklZVWhyNmhuOGplR2NHWGlUY0pF?=
 =?utf-8?B?MEppNHlOR2JrdVZuWHBXYXJFL21id3d2b1NUS3RLNEF2WGVaQ01SQ3RkRzRz?=
 =?utf-8?B?RFBsRTV2L3k3NC85WkNBMkg0TW5tVWd4UWZ4REhBWUd2Y3JmNWZFL1p4QTFv?=
 =?utf-8?B?MGpuYkhxWEFTVHNmcGdjU1hjakF2MU1FbDN6MExJSWNZejdlM2pKVmFnM2Mw?=
 =?utf-8?B?b2Fab3BrOWZmMHlYb2dEZTFsRUdJcGxKeGh0VkNZT1NPeWx3V1lDSTh0UGEv?=
 =?utf-8?B?NkQ4V2xLcXpSTjA4ZlQ0SnNMSFVGaVdmeG9wbUV4MC9GTUh1bm5ZakloL3E2?=
 =?utf-8?B?Sit2TFRTR3JRZkQva05ZaHhzTkgvK29TZFExMXRzZEFoTEZZZThOMW1nalBk?=
 =?utf-8?B?ZTNSWjkxb3Y0ZVpsZDg2VzZxeUk1N29Sdnlva0h3RzhFSVQzZ1NNQkh0akhW?=
 =?utf-8?B?M3VaSFByVURmdTBOVGtUZnhsNVp2UU9ROERpcXJpSzI4RnRkU3FOemIzNlVU?=
 =?utf-8?B?clJwaGZtV3EwUGl5Y2Rqa3lTWVFLOWoyZzF0U0hTU0Q2THF4cEtBQnl6Q1VE?=
 =?utf-8?B?RWJBbFBueTRndDFzU2lpdnp0YkIzbE5neEtheURRa2l4QjBDaW15UnZMS3k1?=
 =?utf-8?B?NGVBd1FBQ2xNQmtZazVMcEVtZStWdzNFWFIyZ1c4QUJHazVsRFIrWiswVEFK?=
 =?utf-8?B?NzhmNVU3ZHhCM3Z2bUVORjdCbU5BPT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <568B592618437248964EC45ED9EA96DF@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e1f0a0b5-b59c-48a7-d25f-08d9e71f13fe
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Feb 2022 14:11:31.4011
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: KnC5AmUyUqBPMPQkJ3lQsaqrwd8XL+/082Dnz1Bt9ps1LQqxqwUpeEPNv2SgD/5MjcTTCaNflUkX83+7WEX8QcNr4Pk9HkxqUqB5dMGAQKw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR03MB4464
X-OriginatorOrg: citrix.com

T24gMDMvMDIvMjAyMiAxMzo0OCwgSnVsaWVuIEdyYWxsIHdyb3RlOg0KPiBIaSwNCj4NCj4gT24g
MDMvMDIvMjAyMiAxMzozOCwgQW5kcmV3IENvb3BlciB3cm90ZToNCj4+IGRpZmYgLS1naXQgYS94
ZW4vaW5jbHVkZS94ZW4vc2NoZWQuaCBiL3hlbi9pbmNsdWRlL3hlbi9zY2hlZC5oDQo+PiBpbmRl
eCAzN2Y3OGNjNGM0YzkuLjM4YjM5MGQyMDM3MSAxMDA2NDQNCj4+IC0tLSBhL3hlbi9pbmNsdWRl
L3hlbi9zY2hlZC5oDQo+PiArKysgYi94ZW4vaW5jbHVkZS94ZW4vc2NoZWQuaA0KPj4gQEAgLTcz
NiwxMCArNzM2LDE1IEBAIHZvaWQgdmNwdV9lbmRfc2h1dGRvd25fZGVmZXJyYWwoc3RydWN0IHZj
cHUgKnYpOw0KPj4gwqDCoCAqIGZyb20gYW55IHByb2Nlc3Nvci4NCj4+IMKgwqAgKi8NCj4+IMKg
IHZvaWQgX19kb21haW5fY3Jhc2goc3RydWN0IGRvbWFpbiAqZCk7DQo+PiAtI2RlZmluZSBkb21h
aW5fY3Jhc2goZCkgZG8NCj4+IHvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgXA0K
Pj4gLcKgwqDCoCBwcmludGsoImRvbWFpbl9jcmFzaCBjYWxsZWQgZnJvbSAlczolZFxuIiwgX19G
SUxFX18sDQo+PiBfX0xJTkVfXyk7wqDCoMKgwqDCoMKgIFwNCj4+IC3CoMKgwqANCj4+IF9fZG9t
YWluX2NyYXNoKGQpO8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oCBcDQo+PiAtfSB3aGlsZSAoMCkNCj4+ICsjZGVmaW5lIGRvbWFpbl9jcmFzaChkLCAuLi4pwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIFwNCj4+
ICvCoMKgwqAgZG8ge8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgXA0KPj4g
K8KgwqDCoMKgwqDCoMKgIGlmICggY291bnRfYXJncyhfX1ZBX0FSR1NfXykgPT0gMCApwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgIFwNCj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHByaW50aygi
ZG9tYWluX2NyYXNoIGNhbGxlZCBmcm9tICVzOiVkXG4iLMKgIFwNCj4+ICvCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgX19GSUxFX18sIF9fTElORV9fKTvCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoCBcDQo+DQo+IEkgZmluZCBhIGJpdCBvZGQgdGhhdCBoZXJlIHlv
dSBhcmUgdXNpbmcgYSBub3JtYWwgcHJpbnRrDQoNClRoYXQncyB1bm1vZGlmaWVkIGZyb20gYmVm
b3JlLsKgIE9ubHkgcmVmb3JtYXR0ZWQuDQoNCj4gYnV0Li4uDQo+DQo+DQo+PiArwqDCoMKgwqDC
oMKgwqAgZWxzZcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIFwNCj4+ICvCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgIHByaW50ayhYRU5MT0dfR19FUlIgX19WQV9BUkdTX18pO8KgwqDCoMKgwqDC
oMKgwqDCoMKgIFwNCj4NCj4gaGVyZSBpdCBpcyBYRU5MT0dfR19FUlIuIEluIGZhY3QsIGlzbid0
IGl0IHJhdGVsaW1pdGVkPyBJZiBzbywNCj4gd291bGRuJ3QgaXQgYmUgYmV0dGVyIHRvIG9ubHkg
dXNlIFhFTkxPR19FUlIgc28gdGhleSBjYW4gYWx3YXlzIGJlDQo+IHNlZW4/IChBIGRvbWFpbiBz
aG91bGRuJ3QgYmUgYWJsZSB0byBhYnVzZSBpdCkuDQoNClBlcmhhcHMuwqAgSSBzdXBwb3NlIGl0
IGlzIG1vcmUgaW1wb3J0YW50IGluZm9ybWF0aW9uIHRoYW4gcHJldHR5IG11Y2gNCmFueXRoaW5n
IGVsc2UgYWJvdXQgdGhlIGd1ZXN0Lg0KDQpJJ3ZlIGNoYW5nZWQgbG9jYWxseSwgYnV0IHdvbid0
IHJlcG9zdCBqdXN0IGZvciB0aGlzLg0KDQp+QW5kcmV3DQo=


From xen-devel-bounces@lists.xenproject.org Thu Feb 03 14:13:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 03 Feb 2022 14:13:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264828.458078 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFcs2-0001L5-T7; Thu, 03 Feb 2022 14:13:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264828.458078; Thu, 03 Feb 2022 14:13:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFcs2-0001Ky-Q7; Thu, 03 Feb 2022 14:13:58 +0000
Received: by outflank-mailman (input) for mailman id 264828;
 Thu, 03 Feb 2022 14:13:57 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=OTfZ=SS=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nFcs1-0001Kk-58
 for xen-devel@lists.xenproject.org; Thu, 03 Feb 2022 14:13:57 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 85e78eec-84fb-11ec-8eb8-a37418f5ba1a;
 Thu, 03 Feb 2022 15:13:56 +0100 (CET)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2057.outbound.protection.outlook.com [104.47.12.57]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-4-l_0gKs22OgaqIq-0_oWDSA-1; Thu, 03 Feb 2022 15:13:54 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM6PR04MB4502.eurprd04.prod.outlook.com (2603:10a6:20b:1e::32)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Thu, 3 Feb
 2022 14:13:53 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.012; Thu, 3 Feb 2022
 14:13:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 85e78eec-84fb-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1643897635;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=Zm0wIMA1IAoeOuJCXF+lU0XyxSNv9xb2pgurAmm6lU4=;
	b=PhGN2lkvLreHtS0ZwE9ZsO8wqf+68JodTUpwSVaEnKxSycB65cGS3CCcsYflbyo+t31u1A
	i2HKqLOiphUyqjXux7Dlb8o5oxOZe65WSapSCZIJIWTAaJ24lwAF28iUCOsOIvD3/2VeaL
	h07X3G1BGZuipv4yer0fz2YASd5hmp0=
X-MC-Unique: l_0gKs22OgaqIq-0_oWDSA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=mOFJmWaEd/eHcQ+OWeLg9y7vifmG17Jap4EMKFwvaldDu1+Fz1Lzwl43yuOUpW/hItVUABzKFR2h0r+k6JARruC55cPipUCY3+y6kZ5o9LJwtu4IivYgckCjsRSlbRZnieU4Z8CMZP1TJk0++VoGMvUB0ykkV5YzAYtQ4/3mS2b9ZjKhYYOsKSve6UhCthF3XEJA9UDFekhh2kXwwipSpjlLTH++Hi/DPEs1ALvbVY+Iq1BHzmXdQ6yC9KO0FL+u/2XaWe8/m3fl13Rav717oDcFNdHapCdZf/5Zw9tuE3LESNRvoWodOd4pinuKid0ojX+OdXJUS7UAqyN5j02PaA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Zm0wIMA1IAoeOuJCXF+lU0XyxSNv9xb2pgurAmm6lU4=;
 b=IXg3nJP3RzdPkcuXtzw7o+oz42A3Sg0byq3Mydb2l+CkNblTJ7ME6mr2K2NESx7HN6Uk5mu3KSHQmjCAkqqDKiepU0RxTvniw1N7We2Gb4LE7JBJwWdVq75NRnD62oAtxTZJIic1p1uMHBv4mTH3kNBOMJwXb0+HgEI9a/p7DyuFD9BjH8F8Iio5/JBZw1tFk9+/rRlWxsyAgAB/PYNhryITkMJABOOoIkJCpgm/FQRDufxGAjSfbyIA3YYxQfbIV+Ctvc07ABrorjWjE1LtI+GKP7E6q42CvaT5BuHcRl5hnuhTkPE21AX+RaLLrBr+twjV6FgOblFJ7oTyQlAxSg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <c1b1aea3-4258-d012-b7ae-634c3efce993@suse.com>
Date: Thu, 3 Feb 2022 15:13:51 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
From: Jan Beulich <jbeulich@suse.com>
Subject: Xen 4.15.2 released
To: xen-announce@lists.xenproject.org
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0016.eurprd06.prod.outlook.com
 (2603:10a6:20b:462::23) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a8042517-521c-423b-6f91-08d9e71f68b7
X-MS-TrafficTypeDiagnostic: AM6PR04MB4502:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB45027CB6D1AEFCE0288841CAB3289@AM6PR04MB4502.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7219;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	YNuOwmyh04H1YCh6n5jNqT5jEYkRZRrPDY7zSUKMLYOdQbJy4SYhNgaAlOHchNXAaMB+b3zwz/BpxTfRVdBB9Y/f2PsrqesXpbeaNiv7638fuAMLXYhNRq0TE8lgoHJSTjVRgX6v/2SWaDAfGXcVUh363VKVwvg3vo+BzFcFhJ8Fqs88TOGtb7Q7GykZdSUv8Ku//zLt+Ks3ZdiqYiFQxRXkZq0hvErX/sIs8yhdS8s5AJ5Rwet4gh4AvOl5777qAwALn5aLPV8dUgU5z2ki1Eexs50+Jat5jrFT9QPvd2CHPiV5vm2zrXLc06OOxMG0bF0nEXshdJgMvQNJ+BqRofGZwwYniBWQ2O/hqVWIKXsLoV1VGPomAtbmsDaf3w0/FsLSmNQMCDoQGik6xjtkhqmdrE0u7DCHr+6IvdIl1sl0sKmslUQS9a6MHH0z0wRS8ElYMkMNTd9EiNqJbYcI+4fz21k6fqZpChXgIhIspky4dChQlp4ruEITUmYJqgq/h3xtnXU5vxGs8kS60b1cMX9a/M+MWPntb3sKnYVnMaSiSkL4kz/SLuQJ8uoHAFBGZ/KnVTkDRm6DFdMhyGY1wbtuzjvtJEt63w/3rHKg+A1i55ezY1eqtx3YC3MpBNl+HFNDKd7G7yQpjsYw6QmbBpUL+kw6G6/6O4FvXZ2gyDj251GWQ5aR2ptoQ8TLavU4BCZXiS65rI0PkbwxfrsGF+xCfJ6UhtglVned+p03VZpE0NW5cfmNZCR7p3C/lLo0QAdiPfnY95+pgwoZ0mkHstk5AjZPIyEhVYtWnz0a6yoGk4bcuo309EhSXnwmJ7F/
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6512007)(31686004)(4744005)(2906002)(6506007)(450100002)(5660300002)(6916009)(36756003)(316002)(38100700002)(4326008)(508600001)(7116003)(31696002)(86362001)(8936002)(66476007)(66946007)(66556008)(8676002)(966005)(6486002)(186003)(26005)(2616005)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZjBRMitkSFViRjd3dnpQSEt6a0VQQVgvRTgyTEJHK1IrTkU1dXVYcThlL3g0?=
 =?utf-8?B?N3JUVWxSandpMmI2R3VGa1JyYlZRR25hczRuaUVteGtuT0NicFJPKzlvR1cr?=
 =?utf-8?B?aXczd3IyS3Q5ZWMwR250Ni9TZ1hjUTNKNnVuNEJoa1NqVE95dVhBQW56aGJ0?=
 =?utf-8?B?VTA1ODRoVXpOM2NvZXFGK0FBSDlUSkh5R2xRMU9HdXJROWQ1L2tZckg5ZW5i?=
 =?utf-8?B?OEUraUZXaWpWMzJqb3FJUHVrVTdZejI4dzRTSnhTdkdWMElSVEdUQ1RQT2Np?=
 =?utf-8?B?UUIyRnV6RHNsMXlsZExublpTQ3ZIckRGQVVCZ1NCOTVKVitramdSclZMQSti?=
 =?utf-8?B?RGhGRVVQODhjYm90aEQvZVp1TldpMkpmVk9xdkJGWEtFZVkzczFQY3RiQlph?=
 =?utf-8?B?WkVPL0RwcU1KWit6YUVUaXljZ2lvcjMrUy9EbHJ2RXhnZWtMV0NlOHVVTDMx?=
 =?utf-8?B?ZkE4UHlJU3ZpZHB1bkJPOTFYMTRRWTFtMTJaTnhUV0ZPRFppcDRRVzVpOU5E?=
 =?utf-8?B?enV0ZnpZeTNrc2JmV3ZSSkNSc2tmVFJod3Zhbm8wZlUwSW9tcGNmNkZGdVpy?=
 =?utf-8?B?NE9KdThjbWdCTzRqWnNCaFcxWS9FaisrMnZPcU9DL2lrUHp1cWVPcmZDK0dk?=
 =?utf-8?B?c0FKU1ZOMTEybHpteVNqYnRUb3FzL1FkcC9FNXJTNlJOSFl0azNDd1pWTmZP?=
 =?utf-8?B?TllBZEhoN1R4TVhzblduN1ppckNaZG9kc0pwV2U0VlZDN0IvRHkxSlhKU1Y5?=
 =?utf-8?B?ZG1YMnMvd2dpY2g5eHRGWEdaOFVlZFB2L0tCa2U1M1ZUeW1JQjhvZUxQM1Zu?=
 =?utf-8?B?bkx6dG1WSGVuc0dhS0ppeGJ2WTQ4UGwwaGQzb1V3OFdDSGdhYjhTYm13YlFE?=
 =?utf-8?B?cS8zb1R3cFpKdkNNNGFnZ3E3REJKNGp1N1o4cHN2Vy9HZzM4bTByTUtvNHUy?=
 =?utf-8?B?RWlMWXB3eHlMVHUvNVZFcjlCYllaTUpObEVyQ1p0dEF3UE1pV2kzWHFoY0pz?=
 =?utf-8?B?WkhrcTNCelJseEpxRU9xSHZrQXpiSW5LMUsxTjBibXlpVTJsR3VpTkNwcita?=
 =?utf-8?B?V0xYb2hFZE5MSXpub3RUQmlRQWRNeW44cEcwck1EQlJuSTNxZ1JGdzBlWHB2?=
 =?utf-8?B?Mk5aZk5KekR0UmhnOS9WU1dEcFhTQlR2VjE0ZlJSbFdHSE5FdVc4dnd0dFU3?=
 =?utf-8?B?ZFl6b1hYcXROU2tYZjAzOThpaTNXT3FwUG10MSs1YUhwZXZjWGM5Rkc0STZM?=
 =?utf-8?B?VXA4RmxPb2x1UWNRZUk4eXVYTk4vcnBJRzYxeGRERVh1RWN6V2E0UmhtcUoy?=
 =?utf-8?B?MnlpZmZSU3N1Z1RaT1VkSFVSTHpuMVNFK1JMN2Y5UWczYmVpNWV0TXRHcGxo?=
 =?utf-8?B?VERYanROL25jcVNiajB0NHlqbllSTEJHQ2ZWcldtckFCNkdFWVJnamk1YUdX?=
 =?utf-8?B?NGVQdmc0eGxDL0ljaERNKzE2RlBCYVJhS01JWVRDaGFmVzBuWnRUOTg1ckNK?=
 =?utf-8?B?T202MHVVcnVnY1cxVVhUQ2ZqRnZJUkJFWitpYURrMGp6b1pCVUQ5VVVLYWg1?=
 =?utf-8?B?bEw5SXJtckFTYlBNem9SdWc3NnBrQXQraUJDOHpiV0IwLzN0Y2E0M3g3MHYz?=
 =?utf-8?B?TE1LRE1EbXNnTnE0L0ZZcUtBUHlHZlVpWFNDY1RTNzc4RFQzT0NseVNnYThV?=
 =?utf-8?B?azNSdlJtM0hXTVZCZk8xZDhnZCtwZ3FPaldWWHRncktSNHBnZCtCbHVZczRM?=
 =?utf-8?B?c2paSXEvOWp1ZEo5M3oybS9mVFRMNlduVTZOQ0tyUm5zanBsK0c4akNhck52?=
 =?utf-8?B?d3c5amExdUNoRnFGTEttVVlybVpMWEs5ZEpkbzMyUHdkWlJ5UFRIVzVOM3pP?=
 =?utf-8?B?MTZMOWJ4WUZ4bXR6MGwvMjRiVWVYUmJuc1QvRFlkeWlnUmY4alNGek0vRHFZ?=
 =?utf-8?B?dlRMTGQ1ZTlZd05oWWNoREk3OVFDdFQ4Uy9CaXJmREtoYjJwWm5XOHFzb2tQ?=
 =?utf-8?B?ZXEwSEtwKys0UGxmc1loY2VYY2FrenprV2VtMlc4TURtclN2Qk80bll3U3I5?=
 =?utf-8?B?eTNPVzNzc2FaTC92SHVLTytLWGZjaWhWVGtkR0ljZEZGM2haL3V0aXpIM2xT?=
 =?utf-8?B?RHRUekRXSklPYUJwV0twMFJIVTQwVndxOUdMczByTFJzWlZtc3FxMnY1MllD?=
 =?utf-8?Q?55UmQFnQFhPyEgQSg4CKW2Y=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a8042517-521c-423b-6f91-08d9e71f68b7
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Feb 2022 14:13:53.8052
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZIluJoHTXi2atZY+XA+T8907HeQ/KYjNUd0dl4TUOxDtg4xFefpmSkOdTQpXzhII6j4egzbGnRVDJi6Hi2g+lQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4502

All,

we're pleased to announce the release of Xen 4.15.2. This is available
immediately from its git repository
http://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=refs/heads/stable-4.15
(tag RELEASE-4.15.2) or from the XenProject download page
https://xenproject.org/downloads/xen-project-archives/xen-project-4-15-series/xen-project-4-15-2/
(where a list of changes can also be found).

We recommend all users of the 4.15 stable series to update to this
latest point release.

Regards, Jan



From xen-devel-bounces@lists.xenproject.org Thu Feb 03 14:15:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 03 Feb 2022 14:15:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264837.458090 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFctZ-0001wY-Aq; Thu, 03 Feb 2022 14:15:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264837.458090; Thu, 03 Feb 2022 14:15:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFctZ-0001wR-7Y; Thu, 03 Feb 2022 14:15:33 +0000
Received: by outflank-mailman (input) for mailman id 264837;
 Thu, 03 Feb 2022 14:15:32 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=OTfZ=SS=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nFctY-0001wL-2M
 for xen-devel@lists.xenproject.org; Thu, 03 Feb 2022 14:15:32 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id be6fe6c8-84fb-11ec-8eb8-a37418f5ba1a;
 Thu, 03 Feb 2022 15:15:31 +0100 (CET)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2058.outbound.protection.outlook.com [104.47.12.58]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-38-AjG7-o0AP_eZ_7waPHBk2Q-1; Thu, 03 Feb 2022 15:15:29 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM6PR04MB4502.eurprd04.prod.outlook.com (2603:10a6:20b:1e::32)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Thu, 3 Feb
 2022 14:15:28 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.012; Thu, 3 Feb 2022
 14:15:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: be6fe6c8-84fb-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1643897730;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=0YgL5Ont2EUUMHy9vQByF/JMgI+F1ZyHNlFHmjEREHw=;
	b=L2eLRHuzjx3gYxVhGSCSjV9liUIJyW0Y3YTNT8ToTZsoFLP+lIfruAcaL3d9Io/VpB6N4m
	RZEMEf8ARg8xIzedNweV3e4sBw+zKROM8ylaiXWP8ffmcRvhEM8jwJ1DdZ8VW0VkMuZObC
	2UyLWxC2AbyHloZLTR7AvcpiAT2iTJw=
X-MC-Unique: AjG7-o0AP_eZ_7waPHBk2Q-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=h/nSyr7PYNeTJQaMFarj0A8RtNXbnr1L5gaABOSkg7HufeOh/uOAbFCmHnVbF1RXVYw8mvmXdu1hv8SSbzbkF20VbwIBmRPC5i60e0hTL73nxtywXS7UYfyUCQjJePRDeNBqS9NpmjCVhp/m19iOCS4kk32yG/KAIFWnH1H56qF5RkXbh80VpB0dpbHdkFu/thq5W//Gt4/Zkk514xLW3aOLUVAjEBF+jr/wVIXpTcT220nv6vlav550v/FcXeyGq8ZBAXu2tjh9u77eGMD/2hM7zRgrVOUn2hpyDdiwfnEggMVTHT7JG/79qlMVGzKa6hgZYHyVQK/qIu4b4iSlqg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=0YgL5Ont2EUUMHy9vQByF/JMgI+F1ZyHNlFHmjEREHw=;
 b=muLzeO0O30RpSIKOvqUFrAsD2/B5pGKKtfoTkZXM+oCI0IZr28dDwIgqoUiHqIzer73fbTQfTKDxA7v1kl7cIhB7D8BK45YpKTrEGjMhAix6JeI0eYkyGUZCh3uj4DTWxCpK0NJx+5ilY0R0RPo/32FdUxUMKjygIxcISo2s3GFABBAP8EEz2HTsNERB8/Zg6GwpHRlaRs8y7waLMo3ccISTSxZXAQeczmRSNTXSkBeXRn299xqxE+AayNUpXvYsfFA5q0BRYxe38B9K1wfGr1VRRUe7sFiUqJzII9avMy8bLV0cS9GsIRn1kfUydLBwbl85Xu+KE4bXw/k2LYpxKg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <9f54a718-86fc-5340-7485-8251fb04964f@suse.com>
Date: Thu, 3 Feb 2022 15:15:26 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
From: Jan Beulich <jbeulich@suse.com>
Subject: Xen 4.14.4 released
To: xen-announce@lists.xenproject.org
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR05CA0011.eurprd05.prod.outlook.com
 (2603:10a6:20b:311::16) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 0765c953-3bfa-4e0a-c81e-08d9e71fa11a
X-MS-TrafficTypeDiagnostic: AM6PR04MB4502:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB4502E8F60974C8A0C950D079B3289@AM6PR04MB4502.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7219;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	wyQbEqbSUbDcNwqSiiJagqL6ZGcoLyxdB3qz6jpWYHamA0ITfHWDE3fitYspQcaH6BaujAdnkRIQ8/0vSYOOKc6yj8gRYLAwGPmWTfBSPiySKeiZykpwmiDtERd/bqZgEO3ygTKbXUXE/01f3+auMYNiJ3CG+PQr//XWbrqFn9zkLJgPsAGb+NQUO+Ul5xrPpujU/aYV/KhK4ifZGBjqcSb4oOU12UzG98CoYn/7e/eW75zS+uto7ak/Xwyi0/OfrPev5JnmYepMGLDFdje0VKOs9bJAmZc6rZq/AJ+2wQK7mITRvmWmHqhebRyis+vcfQaj7Cw6XMEJR3oAhRKTY+FGr9GbZyCT67YjB+GYGnhFPw931Hpim4F//7l6PZ1y35YcH3zy8qTJslrDEmqvL35KexUqQaSVh3Hj57rBoGJbKmeti4lqZNKSuuOtNdkcwov2LORhJc6D+zoE01wkh+5uJ96J0oUwF1l0D43AzmmuxJQjBgUOCs2z9xpcs+yMV8CSF6xOkg/BMuJHxjqLFcD2VYoAWSVjPTk4zTuh6Nc7/RkxJrQ+Veb3gl8xj/PqNJgAeVACYDMLGKLLp+yWrzOXQHzs21El0d1qZObFKzrMHPMKgZ0GxOW/vclDTSaRw316nQOHMZyy9X5iB9eIaFrtUG+vok8GuwY3lXuTY9+WkLY0hK01R5ErUy1XVgcUMpHFbsJmrudBSbG9JZpUGj9nTgT2YNgiWito+pW7+nQlOL07h0V6W8q34aygenJOMfCXsYT2Q3XcOc/zkFHyJXEXbTxtn/PpKTn/WxKwt7Z87aLXsHyz/f8xPflWQR+A
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6512007)(31686004)(4744005)(2906002)(6506007)(450100002)(5660300002)(6916009)(36756003)(316002)(38100700002)(4326008)(508600001)(7116003)(31696002)(86362001)(8936002)(66476007)(66946007)(66556008)(8676002)(966005)(6486002)(186003)(26005)(2616005)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TXhtVzVnbUhPYll3S0tZUTIvcDM0THZocmVsYlJyeTZCOXUzVjQrdGMzUjRZ?=
 =?utf-8?B?cVZ4MC9DNFZ6ZkJzVVNrMVZKbk9yQXZteS9jSmdEVHFXWFdYMHdxcWl1T2xQ?=
 =?utf-8?B?OTQ3M2RjOGs3dkdUTGRoL3dhNklZc2tCSHBuc2NCWWI5MWJhYkE1RUQ1YWQ3?=
 =?utf-8?B?bTIxeWZoNkxqNTJFZUtUeTRhU0JyUElVNWNDUnQ1OUhoTDhsc1Fqc1YrTndV?=
 =?utf-8?B?T1hGYmVMUTZaRzBmYnZSdWVjeGJ4TlZLUGhvdCtOM0U1b25uQTZ1UFlBdWFi?=
 =?utf-8?B?SXZLNGR6aGpMOWx2cmRFZEtCTEhORFNxc2NoaXY5d0ttM3VOb00vVkVGRU1j?=
 =?utf-8?B?bWUrbS8rdXUxVkw2RitiNzJUYXNZejRPdDhRclczYUgwRVV1MXV1cDVEV1Vx?=
 =?utf-8?B?SnJaM2tXdmR1QWFueDZWdkg2WGFxV0kwUDhRVzVPR01ZY0Q5T2VRT2hZVVZP?=
 =?utf-8?B?LzEvRHN4UkRnd05pZHFMYVdtZm5UbXVwYmpXS0NJSWpWcUpGSWg1YlM2UVJV?=
 =?utf-8?B?cWxCVzB1ZDU0WVRMMGFadzFKQjlmOEdZZ3NJRENpeHR2cFlDTlF1REFVcjcr?=
 =?utf-8?B?azdmYmo2bHZqWmlwT3dQeUFQQWcxRmo4RTJXUUFlU2xEdzVGRytqdS9rSXJG?=
 =?utf-8?B?aGc4SUwxTlEwdUZJUk9XM1VZZ0R2eHBPUTIvVlVMQU1FVEJjbzZWdjBtWGFS?=
 =?utf-8?B?YktQajJJV1ZlRlZZTUROOVpaSnJqakVkNTNEeUtFMEcyVDFuM0Fwekl2Y1Jo?=
 =?utf-8?B?N2ZHcCsxbndxVEMwNWNZSU5sQkFwdUQ0MjlML1U0Z1FTdS9SRkxYUVpkUkQw?=
 =?utf-8?B?TmV0UE1uNTM5OHZkNjZ6aSt2M2oybGIzOHYwZGo0eG10YzhjRTM1emI4Tk5n?=
 =?utf-8?B?NE04TU1USWhqdWdDWUFvWUJCRGFEd2dIbnJYbHd6dEFrQ2g1SUpFSGIxY1Nw?=
 =?utf-8?B?VW8ycjdyUUJmYUhsa3hncmcwYzJOenFQNWs0SnRqblZpTmdaSnkvK0c3SWQ0?=
 =?utf-8?B?RnV6a0dnU1RPQUhaYldwc1dwaUZ1cUwvem0vbnF1UDJxYXpVL3JjaG8xaTBP?=
 =?utf-8?B?SzlmUzdESkxOSHZOa0tZeURRNU5Sd25GUVBFeWtkN3FTSnVMN0kxMFE5bVdF?=
 =?utf-8?B?OEhaQndhdFNydWJIb05mcDBsMXRGTjM5TGdTc3ZXSGIxa1c3NDRaKzVkSnZo?=
 =?utf-8?B?TmdRNEdld2NPS3NabXBhQUNkTVY3bU5GYkl1SjdJWXdONk04WVNLYjJBcUUx?=
 =?utf-8?B?bTNHVzk2RUJUZWdONUNXeTdkVnM2allPS0tHWnlCY0pWZ0trR1BWc05uNXhP?=
 =?utf-8?B?dGRPekNiN1Z4cG9aUjJSMXAyUUFDaGJvT2xXWnRyVHNFcjJ5a2pVQ0pDOUtI?=
 =?utf-8?B?dVlVTFlnWGNINDROb1ZwVXZCa2xKS3lETStYSk85TlZDbjRnbnVFQVdOM3Qz?=
 =?utf-8?B?My9CY2hManlkRmw2c3IxQ1BpUkwxU3ZpMk9aOWFObS9HTzUxeUlJSFl1K2t6?=
 =?utf-8?B?eWRkRVZZbkdPUDl0OGo0VXFYTVZGa0tOejZxbmltVm1pVmZTSU1LVTdrQ1lu?=
 =?utf-8?B?YWhwVmQybmtjS1BFSE1iT2doOUtDNEgrZVd6a2xZYlQxYnMvcUNOcytHVzV6?=
 =?utf-8?B?Y21XbXJORGdKSnNsU0FmNCt0MkVQTkEwNE96SlhEcTgwY1lQdWpqaEczZXR1?=
 =?utf-8?B?Um1WdWliUURnS1Z0TGJ1M0ZxWmozQ3hjZTRnbHI4UlMvR2dOd3BBU0NiNith?=
 =?utf-8?B?eWZvZnpvazc0QlRiVTFJekdOUmU4TUdMRWc2WnFFVFptelVmYWlDQ0VwRE1q?=
 =?utf-8?B?UlJqOG42bVU5Z1FSY3FSZHRjZ0NHeDlZVTJmRnVWckFxbTNESmZDNzFQdUo3?=
 =?utf-8?B?TU94MmZ4RWFPNysycHVRZWFLb0YvRFMzbzU3akIyN3hGS2ttK2ExLytvYUhP?=
 =?utf-8?B?R3FMMnZ0QXBtT0pKUUNIU1VxK2Ird201RmpLSFJvRHlsTUdCUEM4NWtqN2Rj?=
 =?utf-8?B?OGs4eC91WXZ4U0tNMGltSHc0SVp0N2xMSDRYOG1nWUp2TC9xRStxYi9XU3hl?=
 =?utf-8?B?VUlOSi9nZ0ZibC9zTFQxRXc0RndYT3BZRkV1ekl1QzFZZ3l1eHlIRmZCVmlo?=
 =?utf-8?B?cVlxWFljWmdoS1JCYkNFTEg3dERVWEdoQnFwSFBSaUROSG5JYnJ6U24rcDRO?=
 =?utf-8?Q?n3RATZwb5GSrvsrJbt2JMYE=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0765c953-3bfa-4e0a-c81e-08d9e71fa11a
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Feb 2022 14:15:28.4243
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XzoVMQpLvqKrgJNbuFJTkDzdb4INddCsQxZRF5Ki7WNVORragHa2QB1b5Y+Ebnnl+yFp+qXTctNHh7WH3CB6RQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4502

All,

we're pleased to announce the release of Xen 4.14.4. This is available
immediately from its git repository
http://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=refs/heads/stable-4.14
(tag RELEASE-4.14.4) or from the XenProject download page
https://xenproject.org/downloads/xen-project-archives/xen-project-4-14-series/xen-project-4-14-4/
(where a list of changes can also be found).

We recommend all users of the 4.14 stable series to update to this
last point release scheduled to be made by the Xen Project team from
this branch.

Regards, Jan



From xen-devel-bounces@lists.xenproject.org Thu Feb 03 14:17:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 03 Feb 2022 14:17:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264848.458101 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFcve-0002hf-0p; Thu, 03 Feb 2022 14:17:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264848.458101; Thu, 03 Feb 2022 14:17:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFcvd-0002hY-SP; Thu, 03 Feb 2022 14:17:41 +0000
Received: by outflank-mailman (input) for mailman id 264848;
 Thu, 03 Feb 2022 14:17:40 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nFcvc-0002hQ-KD
 for xen-devel@lists.xenproject.org; Thu, 03 Feb 2022 14:17:40 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nFcvc-0007O4-6G; Thu, 03 Feb 2022 14:17:40 +0000
Received: from 54-240-197-231.amazon.com ([54.240.197.231] helo=[10.7.236.11])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nFcvb-0000hK-UF; Thu, 03 Feb 2022 14:17:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=2yZRJYN+KPdbLlGPiBYn6xr01jOJPi6GUN30y1HB3DY=; b=5AZOda9x6ICFDcOwqWB7tAMTrw
	6SHLAkA1Y/JEn8qIXVmpK45Z402jEK5NXZnU8ptzqZQs5NeTKiFsJX3aBSHoksZvClAP/CDd5QZuT
	9I0bAT5S8GKrcyzXTjFCP/K8b1s5E+vvIEomncSxVvebf1iCri+6lkvG/tGcNLfwNH7Q=;
Message-ID: <0216845c-be47-41b7-661a-4780fa6b463e@xen.org>
Date: Thu, 3 Feb 2022 14:17:37 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.1
Subject: Re: [PATCH] xen: Modify domain_crash() to take a print string
To: Andrew Cooper <Andrew.Cooper3@citrix.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
Cc: Jan Beulich <JBeulich@suse.com>, Roger Pau Monne <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <20220203133829.7913-1-andrew.cooper3@citrix.com>
 <c0d82900-64d1-fe16-9283-deb7c324ff8a@xen.org>
 <ad7467d2-1cae-c8ea-1217-69f0924044d4@citrix.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <ad7467d2-1cae-c8ea-1217-69f0924044d4@citrix.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Andrew,

On 03/02/2022 14:11, Andrew Cooper wrote:
> On 03/02/2022 13:48, Julien Grall wrote:
>> Hi,
>>
>> On 03/02/2022 13:38, Andrew Cooper wrote:
>>> diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
>>> index 37f78cc4c4c9..38b390d20371 100644
>>> --- a/xen/include/xen/sched.h
>>> +++ b/xen/include/xen/sched.h
>>> @@ -736,10 +736,15 @@ void vcpu_end_shutdown_deferral(struct vcpu *v);
>>>     * from any processor.
>>>     */
>>>    void __domain_crash(struct domain *d);
>>> -#define domain_crash(d) do
>>> {                                              \
>>> -    printk("domain_crash called from %s:%d\n", __FILE__,
>>> __LINE__);       \
>>> -
>>> __domain_crash(d);                                                    \
>>> -} while (0)
>>> +#define domain_crash(d, ...)                            \
>>> +    do {                                                \
>>> +        if ( count_args(__VA_ARGS__) == 0 )             \
>>> +            printk("domain_crash called from %s:%d\n",  \
>>> +                   __FILE__, __LINE__);                 \
>>
>> I find a bit odd that here you are using a normal printk
> 
> That's unmodified from before.  Only reformatted.
> 
>> but...
>>
>>
>>> +        else                                            \
>>> +            printk(XENLOG_G_ERR __VA_ARGS__);           \
>>
>> here it is XENLOG_G_ERR. In fact, isn't it ratelimited? If so,
>> wouldn't it be better to only use XENLOG_ERR so they can always be
>> seen? (A domain shouldn't be able to abuse it).
> 
> Perhaps.  I suppose it is more important information than pretty much
> anything else about the guest.
> 
> I've changed locally, but won't repost just for this.

Ok. With that:

Reviewed-by: Julien Grall <jgrall@amazon.com>

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Feb 03 14:19:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 03 Feb 2022 14:19:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264855.458112 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFcxE-0003I4-BH; Thu, 03 Feb 2022 14:19:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264855.458112; Thu, 03 Feb 2022 14:19:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFcxE-0003Hx-8C; Thu, 03 Feb 2022 14:19:20 +0000
Received: by outflank-mailman (input) for mailman id 264855;
 Thu, 03 Feb 2022 14:19:18 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=OTfZ=SS=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nFcxC-0003Hn-Ol
 for xen-devel@lists.xenproject.org; Thu, 03 Feb 2022 14:19:18 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 45a3df94-84fc-11ec-8f75-fffcc8bd4f1a;
 Thu, 03 Feb 2022 15:19:17 +0100 (CET)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2052.outbound.protection.outlook.com [104.47.6.52]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-7-v4R4LFkBNO6u362F4YioAg-1; Thu, 03 Feb 2022 15:19:16 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DB7PR04MB4492.eurprd04.prod.outlook.com (2603:10a6:5:39::18) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Thu, 3 Feb
 2022 14:19:15 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.012; Thu, 3 Feb 2022
 14:19:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 45a3df94-84fc-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1643897957;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=poxCJPu+On0hgrw8M0GG0x0NcdxG3HQC068XgVI+pLg=;
	b=LeE/fnNohvs6VrTQ+mOk8SNRMvejg97zNDrVThAta1jqGMBsTHnFHuSFqtm7dkWMQnW43+
	KCKgx00JVd7SPYLtgq0xf9KIMWVXG8pycDvwk/FzmjiYa9YluptRpn9e0jdaniJ+PMFVsp
	6/yIFtUPvt7YOQ9IJnN9jd3wQ2dtl/4=
X-MC-Unique: v4R4LFkBNO6u362F4YioAg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=OaSRqxtaAAvbs0U+oABso9pWHlSr8F4l/YLWefIHMDmQ1vOZUn/OGBSNAd4Hm7ptZFKZMpFRQ/juerGqysULLK5NM0crqKHwiqA3iKCuvaYFBh5zKdqObydrEh3TXY62W0liE6aX2JJsrRgEUGHAPHdwKlfa1Yy6lHpmH06Qiu/Q1oFS5UcQk8N1d3UM2KJ5cQQB11ZCGJ5fFHPuE6atCgRnL7SF9aoyF00vS1tMbgKXMykJyIJO4vD/aVF4Ihwr+PWrpwE+WvoG8xUChzPMn0wlHbuqjBOdDV88W9Omk5iylFrnPrPn0Peo0ZYXih/aa7G3vvjmO8BRBwlmMKB5vg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=xMImXoeAqgdJ264Zg4yEYdEmkeDqy4vj7E3LyN4DGd0=;
 b=dpQIZe6ERi3Qk1SRJt50mA2OzzjqG+6gFd2iRhue1FgKWppeWLP5dD0k3OXz+z3Jn39t13J23ZGNWzKgMTFqczb/lSLOomFQ5sut/3D6wlrdeQMWOTUcJyUOIt1ykVZz8cwpD4H9hek6NY5LGFnT+3Dw/p0J96U5G+L3mIWmb1iH0tdW1VpySryp+c6FQJXXbLLir9c/i8Vim+aFk9ErmOkNflrGQy0uuDf0jPNA6SbxOy9+6DsPtyU1KPfpyjyhRasK7641VdI/v+45Te/dYvdKu8hbYysf871yt+JhGed302fsCEZ53DqM0Vx6BMSaJedQMpN3RVlLQOvZrYgbDQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <348f062c-9aed-0275-f0ad-87a0eff8e986@suse.com>
Date: Thu, 3 Feb 2022 15:19:11 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH] xen: Modify domain_crash() to take a print string
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>, Julien Grall <julien@xen.org>
CC: Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20220203133829.7913-1-andrew.cooper3@citrix.com>
 <c0d82900-64d1-fe16-9283-deb7c324ff8a@xen.org>
 <ad7467d2-1cae-c8ea-1217-69f0924044d4@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <ad7467d2-1cae-c8ea-1217-69f0924044d4@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6PR0202CA0064.eurprd02.prod.outlook.com
 (2603:10a6:20b:3a::41) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d4740c42-a538-49f2-9da3-08d9e7202850
X-MS-TrafficTypeDiagnostic: DB7PR04MB4492:EE_
X-Microsoft-Antispam-PRVS:
	<DB7PR04MB44928583C038C90CB96AE627B3289@DB7PR04MB4492.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3276;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	2TO/HBO9AeA74oOVdSHa8sDC+3dEgH774lKQOs6NgveBaUc69TWe7+TL7nc9idl5IG0hsmDqOQ2HFNxLRuGCS8sguPfxsV0Qq7agmO11f/glkUfFaXiCWojOnY7yd5WJH3n7b632jLDrImIA44wAOtM6seTCOEtSEO3J25fXyI3GUsjF4ZrvrlxCIYwV4amBhf6oNf4oEXpqB2fKONWJTA4l/m/7Iiv/EiZKhWccuARWHachw0HCqGYWib39k6VwNqtRDMMy8yn3CfVOFrAf3IKQbejhbClT3584y3RnjF6ZyKnXkX5+Oo+b2dq0bvfSqIJaAUjycqIBQaiGUresg8B3uA7QpMscsEBfIJp1cL9kFGQsEGFbJOzm2WQAWQu6Ak64P589uBQYsv5jfNjaPoU3m7nu/njvwi7Ol/vOQKpHO+mL0Wg1dfwPgEDfL009bfMTyW/IJcT5vSu1I8qKQXioJVDhwBnXoR96ZwNgLWXG7G0UWv8rWh12zWDjuByVocXgL4qmFvVrswFax/ZG20nDpml5gNR0pv2FZKQ7ntvKEpkPOGR7lALnfXjWo2h2hqG5/7X6CDtOZgcp7RAjDenVesVTsx081DKuCBBA3SoIMeooJYtFjwQSr1rRcYvfudZ1qbTpbU+0MueV66UeE5APTEGFkF1fL9VTH8c0mPWbze+WSCst+gOePmxfmxrjp2Eij6+2amjBJHJjo9jvH8G21+G306MwQrOUN6RNJkI=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(83380400001)(66476007)(110136005)(36756003)(6512007)(54906003)(2906002)(8936002)(8676002)(66946007)(86362001)(66556008)(38100700002)(4326008)(31696002)(508600001)(31686004)(186003)(5660300002)(316002)(26005)(6506007)(6486002)(53546011)(2616005)(6666004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?um9bUGYvwwTTiXCdd13JxpvpCpNqRgQdp3pvBMJ1fmhccNfmh31w5o5ugpzf?=
 =?us-ascii?Q?uaFIxELZFKPJEXN0/IB2yPCAhIP18MI3KoQKmizoXfdlI6geszV3AcuW5zPZ?=
 =?us-ascii?Q?WSA7YQVWgOnv0b1tRKK7Hci+BwH/u/WCNvdZL+x7XsBS7xQrW4fUtH8IchLe?=
 =?us-ascii?Q?O1Yd/y6mD3SyRGtsXAwQy7aBnvFwclxkn6ds/trz3rtqTJv4WjEKnONreHBG?=
 =?us-ascii?Q?Y7SYIcHMlSRS5C4nqspYuFXZiByQ5RA1lQqN2FEI8G7KxRoE92gLPyv3agJD?=
 =?us-ascii?Q?cA4Mkp3sBFtQXSLoOKqgKs1fm5CF65pEvIl9YHYmava3PLIhsH7XgTMkXNVh?=
 =?us-ascii?Q?LmCQH+D8tDu4XHBXqfdlEXP99MUGmA+saN9UipRrgK0TNtU+A1Ax0awG9mKM?=
 =?us-ascii?Q?Gm2NXU6VPbCtpmLCskUuvkjxU0f3TcH3RHsjjhc/OnB7Ajb4ANYGpfiCHNLM?=
 =?us-ascii?Q?2UXzoo3XXBsxZ1s/BtPE2vtNz5zKfJfT6icDMkqOosgvJae7k7w4LJj7W8Nq?=
 =?us-ascii?Q?5/7xiys9zyWO9yUWp/6Hkww2r+CfMYwP40anA6SyTcQ7+XizCtJDfRIA0U8q?=
 =?us-ascii?Q?vOO4t4T+89vx41O1gRH6QBZPy3hTtcmVWL7rlYqgtxWu60Zs30oBEz/NZlO0?=
 =?us-ascii?Q?JIZhcTV9DtdJ2f3kom+aaTtCf0+fd9SvxobwW/94sBlHisw9e4veOG+DVJax?=
 =?us-ascii?Q?laFKs/MtwO9kMK43YfU19VPGJTewJNUb6EIDiYLQzM+VUeu/qXs74Wn+QRFp?=
 =?us-ascii?Q?y3IUTJ73aH0u7Of/IJC8TghyqdwT951oRqunMhBTneVZkj/OFCfZdZvz1Mz4?=
 =?us-ascii?Q?9XB5hOBzd4RUJmbxX0BJ+5TWSm5uoUftqLjEf5oauACZwmQ47evwX98/duW4?=
 =?us-ascii?Q?QWzhw0TTxplmknVdjq0nTx+RwW4Z+d6fbduC9JehgEW3aJSOJA+b9TTCWcWE?=
 =?us-ascii?Q?DU4+EF6kjCDJfMzwtOK8tsYp84OYM7PWmQJ5vPqTTcDoaZP3zosaTSY+MhsD?=
 =?us-ascii?Q?YZOkgFAPZe7P46weQXoVfxhKouJZyDdgptaelNsUt5UPL7fvwE4jeblX6sQE?=
 =?us-ascii?Q?eaYXyTBQuQ8L/cHkNDvXedHmt9LG0Wlb6vWCSyo70ZEuyWoeWp+4w4DCwtV0?=
 =?us-ascii?Q?085nK7VYo3Zwfr6F90fi3OMzA9CykcNOjUCwKUGjMZnZdo9MqNjDKabovCfW?=
 =?us-ascii?Q?Bm+5ncObaK4lKMFajN6k1OPCLdGZvJFVjKvU9UhrJ/J3WFzGIRtla4hdcBwp?=
 =?us-ascii?Q?Pin61TqVTRPGbUlik/gbk268Ezrek0BjDL0Ov/dLXIYpaXq91D5tv+tz29kU?=
 =?us-ascii?Q?wNKw9iIAuhrdR2OnTpcuNrIyJUOFmWKdOTE9PAqDKDxW2m822z57z0UGD0//?=
 =?us-ascii?Q?WvycAY76H074ubqvMfRE0qXRGXZZxezvJrFG2wyM+GMiHiAAG9Kc+0tce0Na?=
 =?us-ascii?Q?s8FqWbyMQrLruZBVRhZh5eOQDzwQjjurW4yyga3lUV8CHd7N0BDSABF3Pj8u?=
 =?us-ascii?Q?c8GV49VNRb8XrcipaT8ga57T0hYT2TgvAKxpRKU9KH7IsdBa61YWKUkTmvuF?=
 =?us-ascii?Q?4JGimhW9bOCPqY0dH+e55USr4h3NoqzT/10M5S2OFP055eN920XydfxO7nZK?=
 =?us-ascii?Q?f35sTtRYy/g/GnQZKJzrjz8=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d4740c42-a538-49f2-9da3-08d9e7202850
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Feb 2022 14:19:15.2539
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: T4N4w9M3mUda3fRsGUZoAVxWjuCEArf62L07pSzsgm5SRSjjKTuTFHhvy3M4ifz5WDdGTxn72ZR5FCKROAom/g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4492

On 03.02.2022 15:11, Andrew Cooper wrote:
> On 03/02/2022 13:48, Julien Grall wrote:
>> On 03/02/2022 13:38, Andrew Cooper wrote:
>>> diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
>>> index 37f78cc4c4c9..38b390d20371 100644
>>> --- a/xen/include/xen/sched.h
>>> +++ b/xen/include/xen/sched.h
>>> @@ -736,10 +736,15 @@ void vcpu_end_shutdown_deferral(struct vcpu *v);
>>> =C2=A0=C2=A0 * from any processor.
>>> =C2=A0=C2=A0 */
>>> =C2=A0 void __domain_crash(struct domain *d);
>>> -#define domain_crash(d) do
>>> {=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \
>>> -=C2=A0=C2=A0=C2=A0 printk("domain_crash called from %s:%d\n", __FILE__=
,
>>> __LINE__);=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \
>>> -=C2=A0=C2=A0=C2=A0
>>> __domain_crash(d);=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \
>>> -} while (0)
>>> +#define domain_crash(d, ...)=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \
>>> +=C2=A0=C2=A0=C2=A0 do {=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0 \
>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if ( count_args(__VA_ARGS__=
) =3D=3D 0 )=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0 \
>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 pri=
ntk("domain_crash called from %s:%d\n",=C2=A0 \
>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 __FILE__, __LINE__);=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0 \
>>
>> I find a bit odd that here you are using a normal printk
>=20
> That's unmodified from before.=C2=A0 Only reformatted.
>=20
>> but...
>>
>>
>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 else=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0 \
>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 pri=
ntk(XENLOG_G_ERR __VA_ARGS__);=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0 \
>>
>> here it is XENLOG_G_ERR. In fact, isn't it ratelimited? If so,
>> wouldn't it be better to only use XENLOG_ERR so they can always be
>> seen? (A domain shouldn't be able to abuse it).
>=20
> Perhaps.=C2=A0 I suppose it is more important information than pretty muc=
h
> anything else about the guest.

Indeed, but then - is this really an error in all cases? The prior
printk() simply ended up defaulting to a warning, and I would think
that's what the new one should be doing too. Or even leave the
setting of the log level to the invocation sites of the macro.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Feb 03 14:19:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 03 Feb 2022 14:19:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264857.458123 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFcxY-0003hA-Jz; Thu, 03 Feb 2022 14:19:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264857.458123; Thu, 03 Feb 2022 14:19:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFcxY-0003h3-Gt; Thu, 03 Feb 2022 14:19:40 +0000
Received: by outflank-mailman (input) for mailman id 264857;
 Thu, 03 Feb 2022 14:19:39 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ArrP=SS=epam.com=prvs=403311c35b=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nFcxX-0003Hn-3f
 for xen-devel@lists.xenproject.org; Thu, 03 Feb 2022 14:19:39 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 51029db4-84fc-11ec-8f75-fffcc8bd4f1a;
 Thu, 03 Feb 2022 15:19:37 +0100 (CET)
Received: from pps.filterd (m0174682.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 213EAQ71014061;
 Thu, 3 Feb 2022 14:19:31 GMT
Received: from eur04-vi1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2058.outbound.protection.outlook.com [104.47.14.58])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3e0gdc03cj-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Thu, 03 Feb 2022 14:19:31 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by DB7PR03MB4668.eurprd03.prod.outlook.com (2603:10a6:10:16::11) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Thu, 3 Feb
 2022 14:19:28 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6%3]) with mapi id 15.20.4951.012; Thu, 3 Feb 2022
 14:19:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 51029db4-84fc-11ec-8f75-fffcc8bd4f1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=GoZ2dhsbozElKXDTvL6q2kJ8+Mqp8ugT59pOhFcz6HTNGfK3bXQBYtUB1Xa2s29+oHpNmlH09LYyl8qSUOPGGwzux+Fb7RiJz3f6e5zgYnFCOnvKh+di0JT+LJXz0j7Hc4EfesrDRHD7AfoOogJ+OMUpXRzw/d6L/uoCDyzzX5r0gQ9FChIM93yw56GR2MWbxQqBu+Q8g9heHSPaeLrSv7YwkGfNVUSAS2/1cW/vaGwJVwgjrQoH4dTWnZ/JbtOb+/y8gNG2VZm5ierhNfKwxdP+HN2gUkIJyfC0inUmSptIaeNH2Sj+hp0VHpXDGMP1bKmK6J6zl/+FJ2mVle2vjg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=XBz62T6pXh9O7HDCCwgmvA8biJZnCClmlZ8wQ8WkB/E=;
 b=mnl/GR/I0Y+zfUd1TO2r8THBhYnY7SjeFnDKtFntdBgKcKSOtct8FltoiEwMNXVHv40FwLtQZ3n4Scy9IqSlNRgnYtA0WyvbaK5CJ+YXHtXysb71kDnLjU22U6JuvDRo/IXCC1i2cc2kHQ/Gyr2oNKQa8MzfFQxshClKJ9AYVZYnIt9lu3Rhx3RcqoEZlYRjruTIZQme/LWdtZoNXEvxVBOeSdw+p+6ZiKo6GRR3UmnEFbQlMkqgxb+AIKvqyFAJJmsFcNnjtQDOqQFAm1pwh2WRUJvWRP0EPp6o8nEMFPL/D/ochjRVTRMYzEjGDRx07oNMH4Bae1jDXFsh50zZ/g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=XBz62T6pXh9O7HDCCwgmvA8biJZnCClmlZ8wQ8WkB/E=;
 b=GmRC8a759LJ5VHO+5sc4rpk/SIHcgZzX7InFu2LlfYM8aINxnAyJPfesmw6rVI2jCNWwIfHP6YP/rzM5lFUyE45dEpE0zRqnEAr5TZ8mMvEiyh9OJi2a0px6bfJoexOLgIIr953BTPIPsqWvt3TMQjF3rcLuNKV/M/qrEqscAxrPolStEcgmRD+uZ6sc+xyrF38ZAwkeLS44EvV1KBkD93NbWllxriYUNRenilo/NHVd7mBgr9oiHLDtoXv66jvRGIRMT62TcrTb1GmUM5DurKu9ybDJ6VB5ucTdDnHixiPGC2w3w407T8jyuNnVP8TEjerPrkM5fYXn8Ci+VfTcIQ==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?=
	<roger.pau@citrix.com>
Subject: Re: [PATCH v5 06/14] vpci/header: implement guest BAR register
 handlers
Thread-Topic: [PATCH v5 06/14] vpci/header: implement guest BAR register
 handlers
Thread-Index: 
 AQHX4ewHyWAyD811HEGp8pIjUuVWNaxf8XWAgB1bfoCABObrAIAAAsYAgAAJ6wCAAAmfAIAABBOA
Date: Thu, 3 Feb 2022 14:19:27 +0000
Message-ID: <c1087de5-4b53-5a97-6c26-e341b53a027f@epam.com>
References: <20211125110251.2877218-1-andr2000@gmail.com>
 <20211125110251.2877218-7-andr2000@gmail.com> <Yd8RJfpEalnfl+CC@Air-de-Roger>
 <d493b022-3c78-1721-e668-48f4553056a9@epam.com>
 <df98cdbd-36fe-0386-c068-2a1540f10188@epam.com>
 <9c1f376a-0df3-67eb-7fd1-bb75ae130e77@suse.com>
 <0171761f-d90f-3e3a-5c8f-e32d70096e27@epam.com>
 <be1546ec-0465-9398-9681-7e85e2ca9455@suse.com>
In-Reply-To: <be1546ec-0465-9398-9681-7e85e2ca9455@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 47f69ffa-63e3-4bdb-49af-08d9e720300c
x-ms-traffictypediagnostic: DB7PR03MB4668:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <DB7PR03MB46689B0008E7BFDCEDB8DC36E7289@DB7PR03MB4668.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 kR4JYkKM9WgwCagwx7dejqLQN3VTvZALTFggeXEVyqGsn92X9JP+IqHfjW15eFReb5DWgcq0z6Y617MG8v4N9OGq5VxlXmWw6oU+Qdl1Sp6e2AT2CU8g7CRc45fKYFfuuFXFEmrn9Ggj34liGLstRzTlKDDjHkAzgychn7ClqaLKzy7+Ru7dfghGbhx1OH083VXftREy4cEzrerEiPmpQoncYQiVGC6acWBEqZJdaYG4VHgLBmeuhq3b1WaUCvFL5s+BpDbIdDa2qnjGwmek0WPIA4Tt7OEqvDnFMYIyo/wzKBDakHrhN1sBJmeTNlunuPIdYLE8rZYqox/pV++mwWMEoU9j/luv9zoGQgbySFhq1y1HjeaOxJgqAK8k2Tm+t3ulUfEvoph4nhmOR2ckx7S3dwVNzmor1fJRm4JI7GB3O0PDH5e0icnDA7ZBJd9kyXZVmIPGzGQm+UoJnFD4m1oDjCrQXBKdLNbBdwTu66NS5FJyjIrY+lmZVTq11g2lZ+/UkHn4putbMuwUUR6HDOlke6sMR3Qa6yQg3Mq2a+9Dc7YjtZbmfH8bCxxQIy0W4DAq8V4MUFb8BJJIMIUb74G1FOLrdMlSBXKurMctJOG5OSEsXQO6MAwg33MfZOxQkv+RvUVgCCz+EArC4C4t4XX7JmbsDjLnLCCD/j2a56FbVaDr+uCUdN9HpunCAzooeZwPCJu3vvMt6WTVIz37lpN2a1XVjFrKzr4eWW88Pjf8di6P4khTZvFbBS1ajCek
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(7416002)(86362001)(36756003)(6486002)(54906003)(83380400001)(6916009)(5660300002)(2616005)(6512007)(316002)(31686004)(508600001)(2906002)(71200400001)(53546011)(66946007)(66556008)(66476007)(66446008)(76116006)(91956017)(64756008)(8936002)(26005)(6506007)(31696002)(4326008)(122000001)(8676002)(38100700002)(38070700005)(186003)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?azZzaC9lcG5oWjJuTWk0aE1XSUtYemdPbzAwNzd6cXJLek5ralQwQXNhakFQ?=
 =?utf-8?B?d0l0dGQ2U0pyUnpqMXJaUUdsZWMwZ0gzU2hPS01vMTl2SGZOdUwzU0dLcUtN?=
 =?utf-8?B?TTZXenRqVmhEalhIcjcyV0RDRXgvSlowaXhRYkJYSlV1NFRBMkZwQWlFbW1s?=
 =?utf-8?B?OXl0TWNvSHREVnJJMytRQkpaSGUxSmNEb2VDOE9IeEI4d2ZRYk4xV1FOaVBT?=
 =?utf-8?B?a3p2NURQeCtFM1NlU2tzWFRkeEFwZjF2bkRRMXdTUTJtY0lZZnFsNnZYdjNk?=
 =?utf-8?B?djRMTldFcVhVVWZFYzBSOEI4V0M1QlVsemswbm9rWTlLWUNsYnNhcE9ZSmMz?=
 =?utf-8?B?WUl2MW5hNGVWOVpzN0NHRUFTdzBEL00rZlJYUVFJQnYzbGk2TGtGeEp6RFgz?=
 =?utf-8?B?RUhaclpqb2k0RUVaaTVhZTR0Wm9NL1JlVGRFMU1pV2g0cUp2ZmtRdzdFb2Vm?=
 =?utf-8?B?ZER1Q2NrNEhwc1ozSGcrNlFDWFJpUmtadkEvZE0zTnMvQUh3bjV2WU03ZThm?=
 =?utf-8?B?eVR0ZnU2QWJmS2t4UXRiemNKUFN3WTZQVkFWTUVjZzBWZHc3SWRMUVFac2ZR?=
 =?utf-8?B?YUlCcUloR3lCNVVMcWlWNTNIc2o1WGc0NzhBWm0zZE80K0lNOUttWnpzSFZu?=
 =?utf-8?B?dzE3ZGlScCt3RThoS0NFeXZubUdCTWR3ZzhyRnk5UjZFMUR0MGRaWFFzKzZi?=
 =?utf-8?B?cWh2bnhQdDgyRGcrUEZDY3pab0dYYXFTMzlrRVZId2ZVNzlCVUNlL1dVYWVU?=
 =?utf-8?B?VkdlUFV6NSsyZGtrU1d3YkczL0dPRDc0Sndvby9ISm9FQlVxaDlObEJkUjNU?=
 =?utf-8?B?aDcrUzNkbDNDS29uREcyenNYUTVHWmNDdi9Nd081NFZVUzY5dk1wVVc2N0pk?=
 =?utf-8?B?QmNrU2NKT2c1WXpRQk5rQzZReFRLajkvMm1Nd3QxN3JyaVZUOWdJR0NHUkFJ?=
 =?utf-8?B?aDVTa29rZ243ZlRaYkZDMlVSZnVQcThWeEdDWjlKODI4RWtEUUs2TUVvRnZQ?=
 =?utf-8?B?RXdmbjIxWGU0UU5TYnRjZm9oWGxRcytmYjFvR0oxbVEvQjV4QzVxSGMrWDEz?=
 =?utf-8?B?YTlkNlQ4dmRRWjc5RkJRSXNxcnEyYy9mcndRS09NREJYM0VjRDNoUktCZzNT?=
 =?utf-8?B?UWZwK2tzUW5YcmxFcW5HRG1mZnJ6eVRaL3hNVkVVNy9FV2RrR2M4Z2dleGZr?=
 =?utf-8?B?U2ZacUpiaSt3bVNhSWtBcHFOSGMzT1FpQmkwcUt3eWJWd2dWczlBREg5YnlH?=
 =?utf-8?B?bHgvMUtQb2tTcGxyejV0Mk5UbTdWamI0SUp1clkxc0d6a1BmQVN2cTZEcVdq?=
 =?utf-8?B?bWdFOGErSWJFamNKUmFsOUpBZHJEUEpmc3lyeFprSVdVNjZJQTZSaGhUQ203?=
 =?utf-8?B?eTFDVWFlRGR1UnUxYWZaN215OVdwZ2VDSFFsR0VrUEZwY1gzaXFtKzZoSTkr?=
 =?utf-8?B?NjA2V0Z2SXhwQ1d1N25qN2VhR05ZMG1KdDJXODNjWjdDdU9XbUNxbG5Ldko2?=
 =?utf-8?B?dmpwVmcrWWxZQXUzdCtQR1Y0U2hEdjdTa1Z1ZUhiRnM2UDdBR0VLR3NZaTVl?=
 =?utf-8?B?dWhXVFBQZkhkZDNSOXpRdlBKWUxqUVo4aW9lRFVaSmQ3OWExWlQ2SmkyRWN1?=
 =?utf-8?B?a3pHNUZMQ3RPRGE0Vjg1SHNVQjI1NUN5c1FYaFAvYURsU2pwS3AvclFzVElm?=
 =?utf-8?B?dmhpdXo0ditDWWtxR2tkS1dVUCtuTzNvY0FDZ1hab2hyVnZCc1V5aEVHUldJ?=
 =?utf-8?B?Ti9DUk94WHA3aldHU3FKU29Va3plbnQyV0dqL0h0dFNMbWJVTEorYTExamsv?=
 =?utf-8?B?aTgybDBMN0xJcmFpVDd5ZUduc3k3MytETGsvdy82SFpvelRqTjUrQnVlaEhr?=
 =?utf-8?B?L3pFWVBTN1lrV1loN29zSU5EWjVRWStBdzJ5QkhROUJlck5Mbk5wN1JtNWV3?=
 =?utf-8?B?dmkxaVp3WGs1TTg2ZTN1M216VDJDUE9jYk1QeEVOM1R1THFxSHFPeThKOE1T?=
 =?utf-8?B?ZysvSVpuSm5qcDlBQ1FZM1BWQU1jdlRJZmJSelBUMFgyZXlsdWx2TEo1eFZp?=
 =?utf-8?B?S280MjdRSkxZdklkWUhleVRIYlkzMUhuRStKWWxaeDFnaWtTMXpWWTVXK1l0?=
 =?utf-8?B?TVkzMzNSdFhrRExmQUgweGpRQjFWMGpxNHUvSGFaRFhMNUdwNW1qa2ErNjZ2?=
 =?utf-8?B?WFpGMjNTaWMreExYb2o5NjhULytkZE9ydTdBSGlWVlBjZTVMVXRpRXI2cytq?=
 =?utf-8?B?SktRYm9YWGEvZW1MWFRObk5CYzRjcGE2YmJrNDUzY0NnbkF0dFZ0bVZONnho?=
 =?utf-8?B?MS9TZlMwV0l3cVNlbmJlRG9WOTZySEdjRjREM0JVOWl1S2JqWVJTQT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <CE7F0917E9158648A13DF6108A5E5BF3@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 47f69ffa-63e3-4bdb-49af-08d9e720300c
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Feb 2022 14:19:27.9155
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: j1FQbVrBpo05W2+E67uepjng5DmCg4qEyjIs8zrCuH619Qi1Ako5tt59p+yIAC9mrfzpueQysaGofK/8a2edl6vxq2yRDaazSiSRTHbD5ZYHkF4bDVQdc09psUmL7CSY
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR03MB4668
X-Proofpoint-GUID: 9o8Hidz9AuAfXLP93jEKuopQN9PQJFan
X-Proofpoint-ORIG-GUID: 9o8Hidz9AuAfXLP93jEKuopQN9PQJFan
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-03_04,2022-02-03_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 adultscore=0
 bulkscore=0 malwarescore=0 mlxlogscore=999 phishscore=0 lowpriorityscore=0
 spamscore=0 clxscore=1015 priorityscore=1501 mlxscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2202030089

DQoNCk9uIDAzLjAyLjIyIDE2OjA0LCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMDMuMDIuMjAy
MiAxNDozMCwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+Pg0KPj4gT24gMDMuMDIu
MjIgMTQ6NTQsIEphbiBCZXVsaWNoIHdyb3RlOg0KPj4+IE9uIDAzLjAyLjIwMjIgMTM6NDUsIE9s
ZWtzYW5kciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4+Pj4+IEFsc28gbWVtb3J5IGRlY29kaW5n
IG5lZWRzIHRvIGJlIGluaXRpYWxseSBkaXNhYmxlZCB3aGVuIHVzZWQgYnkNCj4+Pj4+PiBndWVz
dHMsIGluIG9yZGVyIHRvIHByZXZlbnQgdGhlIEJBUiBiZWluZyBwbGFjZWQgb24gdG9wIG9mIGEg
UkFNDQo+Pj4+Pj4gcmVnaW9uLiBUaGUgZ3Vlc3QgcGh5c21hcCB3aWxsIGJlIGRpZmZlcmVudCBm
cm9tIHRoZSBob3N0IG9uZSwgc28gaXQncw0KPj4+Pj4+IHBvc3NpYmxlIGZvciBCQVJzIHRvIGVu
ZCB1cCBwbGFjZWQgb24gdG9wIG9mIFJBTSByZWdpb25zIGluaXRpYWxseQ0KPj4+Pj4+IHVudGls
IHRoZSBmaXJtd2FyZSBvciBPUyBwbGFjZXMgdGhlbSBhdCBhIHN1aXRhYmxlIGFkZHJlc3MuDQo+
Pj4+PiBBZ3JlZSwgbWVtb3J5IGRlY29kaW5nIG11c3QgYmUgZGlzYWJsZWQNCj4+Pj4gSXNuJ3Qg
aXQgYWxyZWFkeSBhY2hpZXZlZCBieSB0aGUgdG9vbHN0YWNrIHJlc2V0dGluZyB0aGUgUENJIGRl
dmljZQ0KPj4+PiB3aGlsZSBhc3NpZ25pbmfCoCBpdCB0byBhIGd1ZXN0Pw0KPj4+IElpcmMgdGhl
IHRvb2wgc3RhY2sgd291bGQgcmVzZXQgYSBkZXZpY2Ugb25seSBhZnRlciBnZXR0aW5nIGl0IGJh
Y2sgZnJvbQ0KPj4+IGEgRG9tVS4gV2hlbiBjb21pbmcgc3RyYWlnaHQgZnJvbSBEb20wIG9yIERv
bUlPLCBubyByZXNldCB3b3VsZCBiZQ0KPj4+IHBlcmZvcm1lZC4gRnVydGhlcm1vcmUsIChhZ2Fp
biBpaXJjKSB0aGVyZSBhcmUgY2FzZXMgd2hlcmUgdGhlcmUncyBubw0KPj4+IGtub3duIChzdGFu
ZGFyZCkgd2F5IHRvIHJlc2V0IGEgZGV2aWNlLiBBc3NpZ25pbmcgc3VjaCB0byBhIGd1ZXN0IHdo
ZW4NCj4+PiBpdCBwcmV2aW91c2x5IHdhcyBvd25lZCBieSBhbm90aGVyIG9uZSBpcyByaXNreSAo
YW5kIGhlbmNlIG5lZWRzIGFuDQo+Pj4gYWRtaW4ga25vd2luZyB3aGF0IHRoZXkncmUgZG9pbmcp
LCBidXQgbWF5IGJlIGFjY2VwdGFibGUgaW4gcGFydGljdWxhcg0KPj4+IHdoZW4gZS5nLiBzaW1w
bHkgcmVib290aW5nIGEgZ3Vlc3QuDQo+Pj4NCj4+PiBJT1cgLSBJIGRvbid0IHRoaW5rIHlvdSBj
YW4gcmVseSBvbiB0aGUgYml0IGJlaW5nIGluIGEgcGFydGljdWxhciBzdGF0ZS4NCj4+IFNvLCB5
b3UgbWVhbiBzb21ldGhpbmcgbGlrZToNCj4gUGVyaGFwcywgYnV0IHRoZW4gSSB0aGluayAuLi4N
Cj4NCj4+IC0tLSBhL3hlbi9kcml2ZXJzL3ZwY2kvaGVhZGVyLmMNCj4+ICsrKyBiL3hlbi9kcml2
ZXJzL3ZwY2kvaGVhZGVyLmMNCj4+IEBAIC04MDgsNiArODA4LDE0IEBAIHN0YXRpYyBpbnQgaW5p
dF9iYXJzKHN0cnVjdCBwY2lfZGV2ICpwZGV2KQ0KPj4gICDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqAgcmV0dXJuIHJjOw0KPj4gICDCoMKgwqDCoCB9DQo+Pg0KPj4gK8KgwqDCoCAvKg0KPj4gK8Kg
wqDCoMKgICogTWVtb3J5IGRlY29kaW5nIG5lZWRzIHRvIGJlIGluaXRpYWxseSBkaXNhYmxlZCB3
aGVuIHVzZWQgYnkNCj4+ICvCoMKgwqDCoCAqIGd1ZXN0cywgaW4gb3JkZXIgdG8gcHJldmVudCB0
aGUgQkFSIGJlaW5nIHBsYWNlZCBvbiB0b3Agb2YgYSBSQU0NCj4+ICvCoMKgwqDCoCAqIHJlZ2lv
bi4NCj4+ICvCoMKgwqDCoCAqLw0KPj4gK8KgwqDCoCBpZiAoICFpc19od2RvbSApDQo+PiArwqDC
oMKgwqDCoMKgwqAgcGNpX2NvbmZfd3JpdGUxNihwZGV2LT5zYmRmLCBQQ0lfQ09NTUFORCwgY21k
ICYgflBDSV9DT01NQU5EX01FTU9SWSk7DQo+PiArDQo+PiAgIMKgwqDCoMKgIHJldHVybiAoY21k
ICYgUENJX0NPTU1BTkRfTUVNT1JZKSA/IG1vZGlmeV9iYXJzKHBkZXYsIGNtZCwgZmFsc2UpIDog
MDsNCj4gLi4uIHlvdSBhbHNvIHdhbnQgdG8gdXBkYXRlIGNtZCwgdGh1cyBhdm9pZGluZyB0aGUg
Y2FsbCB0byBtb2RpZnlfYmFycygpLg0KPg0KPiBBbmQgYnR3LCBmcm9tIGFuIGFic3RyYWN0IHBv
diB0aGUgc2FtZSBpcyB0cnVlIGZvciBJL08gZGVjb2Rpbmc6IEkNCj4gcmVhbGl6ZSB0aGF0IHlv
dSBtZWFuIHRvIGxlYXZlIEkvTyBwb3J0IEJBUnMgYXNpZGUgZm9yIHRoZSBtb21lbnQsIGJ1dCBJ
DQo+IHRoaW5rIHRoZSBjb21tYW5kIHJlZ2lzdGVyIGhhbmRsaW5nIGNvdWxkIHZlcnkgd2VsbCB0
YWtlIGNhcmUgb2YgYm90aC4NCj4NCj4gV2hpY2ggcXVpY2tseSBnZXRzIHVzIHRvIHRoZSBidXMg
bWFzdGVyIGVuYWJsZSBiaXQ6IEkgdGhpbmsgdGhhdCBvbmUNCj4gc2hvdWxkIGluaXRpYWxseSBi
ZSBvZmYgdG9vLiBNYWtpbmcgbWUgd29uZGVyOiBEb2Vzbid0IHRoZSBQQ0kgc3BlYw0KPiBkZWZp
bmUgd2hhdCB0aGUgcmVzZXQgc3RhdGUgb2YgdGhpcyByZWdpc3RlciBpcz8gSWYgc28sIHRoYXQn
cyB3aGF0IEkNCj4gdGhpbmsgd2Ugd2FudCB0byBwdXQgaW4gcGxhY2UgZm9yIERvbVUtcy4NClRo
ZSBzcGVjIEkgaGF2ZSBzYXlzIHRoYXQgYWxsIGJpdHMgYXJlIHR5cGljYWxseSAwIGFmdGVyIHJl
c2V0Lg0KU28sIGl0IHNlZW1zIHRvIGJlIHJlYXNvbmFibGUgdG8ganVzdCB3cml0ZSAwIHRvIFBD
SV9DT01NQU5EDQo+IEphbg0KPg0KVGhhbmsgeW91LA0KT2xla3NhbmRy


From xen-devel-bounces@lists.xenproject.org Thu Feb 03 14:26:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 03 Feb 2022 14:26:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264871.458133 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFd44-0005L8-Fg; Thu, 03 Feb 2022 14:26:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264871.458133; Thu, 03 Feb 2022 14:26:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFd44-0005L1-Ci; Thu, 03 Feb 2022 14:26:24 +0000
Received: by outflank-mailman (input) for mailman id 264871;
 Thu, 03 Feb 2022 14:26:23 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ArrP=SS=epam.com=prvs=403311c35b=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nFd42-0005Kv-Rc
 for xen-devel@lists.xenproject.org; Thu, 03 Feb 2022 14:26:22 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 40c7fb59-84fd-11ec-8eb8-a37418f5ba1a;
 Thu, 03 Feb 2022 15:26:21 +0100 (CET)
Received: from pps.filterd (m0174679.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 213EAguV001373;
 Thu, 3 Feb 2022 14:26:15 GMT
Received: from eur05-vi1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2175.outbound.protection.outlook.com [104.47.17.175])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e0fwd07td-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Thu, 03 Feb 2022 14:26:15 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM7PR03MB6369.eurprd03.prod.outlook.com (2603:10a6:20b:1b0::7)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Thu, 3 Feb
 2022 14:26:07 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6%3]) with mapi id 15.20.4951.012; Thu, 3 Feb 2022
 14:26:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 40c7fb59-84fd-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=GtfKRqW1C5MKo6a/sP/w6mAwZDTDpEtcIG+5RrZVDaXNuUA3sDEIYGJ2NPRjDjjxql8KKue02HslZSJgw62H6Lj67ESx1keVbmjywq2hcdSSOljeL7vcf98AyzDdqNWM4B+b6WGPX8U5DE0TGSjRKl/+piG6mg3R9vnAlfBuyVTF1H3JnG61I1O5tjNaMyb+VY1qjLVvBLXunGG2rNjzO7ap58gq3hVzWV2RfiQxRIz69Mh3DD6HT+T/k7ToLb7WmnbAjLMeCaOvKJge6Sv295WN2s1gs2PTJ+cATImvCWW4OssJF0sgaYAghmuYUT1tQ360kHy1CQvfihVM5TJPBw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ydsqxChzJ+C+qFYsxgonDMMngWA0WaharFTnKZyVBxY=;
 b=YyTquGeQUajWLY2nujlAQvrldqcOKJj6QBJzhZ081XfZ1/8ylOqJyeqq/G9249pUjjvYqHJ0Nwbj1IXtDhG5LvuUyHtZss3ETcG2bCiHgb10qwzLxekgJ0TaHKhI4fHAq4CovzRiMTsDuXi0sXhMA75YFw7UNQowvIBlzpD563EmGG1MJ6Lmevf14l9aSML8dJGdaTDo6LLH58slnYa351qVF9BT1qJbs1bqC7+id0L72tahEwY1wcPMr8D96CLlGZm+wVk3tQfj0i6hnl8Ds5cKX8xOIGZg4uPO4WOKjuz9jZA04cyAug18Xe3GGef/R53mNeMqjGUbw8QmB853sQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ydsqxChzJ+C+qFYsxgonDMMngWA0WaharFTnKZyVBxY=;
 b=GCxqzDhpcIeCGuTZ4TKjwNuyINHvs3FY5vB/O3UD7jCg33lAPB+o33ZSTA+mhynp6TitJfRZUcACY1gkfKLpBoMAy7L64K0hSdxFTSO43GNznvTbCQowo19MdzCjXfC2LV5OEAiMgAvRXCqj+bBPrYR6ZHJhtG4pq7Ag9E3e3x//M92jkb2Vn2XTECXMLXjghN0ms4FUJYuVgMK/gX7D1cW/rrWci7z8I2c+S3MAQDYQe7u3DmNtWzGWKTFg5wNGDD2YpYyC/K2iG99hU7F6tMKSVTFXuMp1nPjE2ZUaeQW3/4pillzcBM1d8aDm7RtOLBZM259eYg15ZJPJ9uebSw==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>,
        Jan Beulich
	<jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v5 06/14] vpci/header: implement guest BAR register
 handlers
Thread-Topic: [PATCH v5 06/14] vpci/header: implement guest BAR register
 handlers
Thread-Index: 
 AQHX4ewHyWAyD811HEGp8pIjUuVWNaxf8XWAgB1bfoCABObrAIAAAsYAgAAJ6wCAAAngAIAABa2A
Date: Thu, 3 Feb 2022 14:26:06 +0000
Message-ID: <0b339957-b313-3fe4-5211-c03612a000ce@epam.com>
References: <20211125110251.2877218-1-andr2000@gmail.com>
 <20211125110251.2877218-7-andr2000@gmail.com> <Yd8RJfpEalnfl+CC@Air-de-Roger>
 <d493b022-3c78-1721-e668-48f4553056a9@epam.com>
 <df98cdbd-36fe-0386-c068-2a1540f10188@epam.com>
 <9c1f376a-0df3-67eb-7fd1-bb75ae130e77@suse.com>
 <0171761f-d90f-3e3a-5c8f-e32d70096e27@epam.com>
 <YfvhOmbFxjKdjI2x@Air-de-Roger>
In-Reply-To: <YfvhOmbFxjKdjI2x@Air-de-Roger>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 36dba2b1-372b-4825-8bf0-08d9e7211ddf
x-ms-traffictypediagnostic: AM7PR03MB6369:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM7PR03MB6369E08C3B49EF964D451498E7289@AM7PR03MB6369.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 5d5BT11NKQs+npT6FhhwvKj+EJl4i2S1GxXqEioVLhYSjWIae7qlOzhu2Z1Amh3NWKieNzzflGl2kJZZERUB+WAdtW3Y7A/hWZsCSckJ8+prZdqqprdZLmxn8et7NqGKVD/0mLFzsDSLxXAWzRR5BB5x2CrjdSyLMzgYK6V3kt2nmvzjoPdQEq5Flm37Bn706tmV1kkJxnnawJ3RNFReHAtyhjqDl8X8fXWR6YbnI/MlS0XOx+LrLqfTPlsxX5p0NKK0M2yxBic9kHXQANvQnYUJ2ZUGVQv7MaYFGbf1yk0Hn4OvPLPg1k0GaIpiQto1l7A/7IoevWzscpRQ6KB7ROzAcksF2Vu501wO7YtHuokUvhWlNKvhCjVcRFOR3LqiB0eiY/TaNp1NLqBhSNt2U+juiDYteISDWWpsidz+lib3LgkS01RMtHI4hcGL4FQP/6hB1l8ypzQT78P2vxsPMZQXCizyAwBrEkVPuvXs/Jg9/knSWy3lPuzO/BkHL1UbWcbuITkUtMRYD40rK5DuNJSbuW5qrFrHzZJseYyU1eYjpo7mttk2Rp7aZjHoOtigxjKqRomha1R+1KuY+R8BQ4UpTT90uDWp71yMDkoBnJvW38YETQlAnhsNa/hyoVff8bRfh6GGn8jGdcFX/YhNSPOgTPGQ4FuvpTpv8uhfLnVVIq6GrmohdNc1O5ZJwgBy6ycmLzIP4C5M1EGluqB4fWRKMrJIm7nxPrvU6+fX/FQerJv9KHQqevHVEX2AzsiLivBKJZ8JTgx0kMCbkejSDzh/3cQjDhU6697qLWlVVEMFbc8Xn1ZL2QOCSgp1qHajPbOyiqRt3XsKHd7xnSXvxQ==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(31696002)(2616005)(186003)(508600001)(966005)(31686004)(2906002)(36756003)(6486002)(316002)(83380400001)(38070700005)(107886003)(26005)(110136005)(54906003)(122000001)(71200400001)(5660300002)(6506007)(38100700002)(7416002)(76116006)(86362001)(8676002)(8936002)(66946007)(4326008)(64756008)(66476007)(66556008)(66446008)(6512007)(91956017)(53546011)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?b1RTNnRYRUt1WnF0cUNaamNJcmFJbmk3a2RnQWFqZFRvRHEvWEtINDdWZDUy?=
 =?utf-8?B?Q1NjVGY3UTl1a04vZmYrWFFCalJrK245UkNwWjd4cXBTTDhKUFFSMmFEMU1V?=
 =?utf-8?B?SWtRWVlTOURvU2dTWU5zRnY1QlRpUm1YdUZyaGZzdS9DVHVqNzA0Q3VlbTdi?=
 =?utf-8?B?Y0hKT0oxdXEwbDN1TzlOY2JGT083SkU4eWx0Z2w0ZnI4TE9OYkxaa2w1cExq?=
 =?utf-8?B?M1JKWGtPcm5uMWwyQ2ViREQ2a3NHVDIrOSt2TDE3NDZhRW10UEkyZ3VrUFZl?=
 =?utf-8?B?eE1ROHJXS3RqUTVybi9LZzV6Q1hTbFdoWFlNdkxScmNpRklzRDAwSVpkc3A0?=
 =?utf-8?B?a0NzRjlMdzU5WUpPWmFCUG1VK0VxYzQ3c1lFSk1za1ptZ0pDNHd6Y05Hdjhq?=
 =?utf-8?B?U0h2SzA0UUROaFRSVEJQWElHMnloS3dhUlI4WStOd1VYUmFoUDFoTWU4S2dW?=
 =?utf-8?B?bXIraG45ZjFBYUZLQU0xUVVpN3NLd3IxaVUxaVdya0JuR090VHFWUGhidWV6?=
 =?utf-8?B?ZWV2anNvaFdMeHU1emRjZ1h5THJsTG5xRGtTMWcwRzJkM0dlVFJzRXZqc3FP?=
 =?utf-8?B?dkJMamRKSU9SZnh2TXpHWHhZSUE4RGtpTjZNdmNNdlNZWHdCUmRjWWlwQzE4?=
 =?utf-8?B?VjNSY3lGNElPcVpoaTRENnVGeUY3VzBrMnR5UEsxdVlDb3RRR0U4OVFsZmdI?=
 =?utf-8?B?bU9NRkJ1d2V6N24wSktkTjJNZm9PS21ReElsL2lmcWxEK09HclZrOWxyZ3Fj?=
 =?utf-8?B?bUlobm9NalI4Snk4emxwWU02YTZuWGpVejFFblVyZS9qRmpyM3BLc0lodzg3?=
 =?utf-8?B?bG1GWVZpQklQVVdaUGpDRTVIQ3FZeUpLa1luelRndmFZYXVMY3BnNVJaRFlD?=
 =?utf-8?B?RDYyNTZpUUxQL1ZobVRZdG5jOE02bUV2WEVjbEpndW9SNEplNUp0YkJ1SGdM?=
 =?utf-8?B?THN6a29Hc1d6Tk43VFVFemdMak9mV1NqMVFvakxGYWp3WXRtV09LWWNneWdq?=
 =?utf-8?B?NFJmcDlHa1pmQmpuRE1jNkFDQVNkQTdGMmNlRU5tSlRqRUJKOHVLcFdLVEh2?=
 =?utf-8?B?d0E3N3ZHQ3hTMU9CU1Zkci90M3p2OXNwd3c2dERCMWZ2ZllmSHNBbnY4eFFS?=
 =?utf-8?B?UnFGa3FvdDFiSm9TY3RQT3RhOG1EN1VEN1hCK05sdStBLyt2Y0NDVmRZTUZG?=
 =?utf-8?B?UFFqaDEzdVRlaW9yQXhQOVJsYU1LUEp1aW4ydS93Tks0MjFDeUNhejZpOVh3?=
 =?utf-8?B?czE4aVBjcFdreWI1SVJWWXhaR1lVbGQ5Z2J0d1RQQlR4cllra2E3LzNCWlNx?=
 =?utf-8?B?Q1VtL3AwT1k5SjlTaEFMTk1KaWIrdElITHkvQTZKUzdvMkJDTDlBMHlCb0NQ?=
 =?utf-8?B?a004Sm9CejdsTWw1ODVJMHo1UisrWmpjalJ6elZtNlhLV0E0TzhaWFRTVVBu?=
 =?utf-8?B?ajE5VnlIbXNyL1VwVWJZeGhYWXhxU2hKbUJtb21HOEQ3dHU4aURQMTlRR08v?=
 =?utf-8?B?WHNZdGRYWXZXU1hFa3F4UnRNRUhDN3EwUTJzNXhod0Z6NldlaERSSVpnTnZp?=
 =?utf-8?B?UFgrUFg3WjJQY1d6ejVFemtQUDNUQ1ZSSnZ5RFNmTi92RXROTTBZaEI2dWdJ?=
 =?utf-8?B?SXVxUm9NMzJBdFQzTG1FWkpNOE1RdjFkVDliVFc1ck55QU1oTGFCL0Z5VHI3?=
 =?utf-8?B?SExLeHBkRGJXbzBwRnBVdHREaWFIVkxxeGRGUWsxU3VrZ3FtYmYzcmZzMThB?=
 =?utf-8?B?eDQ4UEhQZERubDNmZWlBeDlRVmRMUmFHK3NlcmNLK2FpZitJL0RNa2FXRzZM?=
 =?utf-8?B?QW9TdTI1a2MzWVhqZlBockdrWWVjSWtUMSs2ZS93YUVXRTE3Q1pXaUc5Zjdi?=
 =?utf-8?B?WkFET2tvdDhvKzd6NDlYNnZjdGxvWExLZlVUd0dtT283UzBGUFNwbHFVOWxv?=
 =?utf-8?B?WllEV3NyTHFQQ3M4YWpuMC96ekptSjJvalMyd21nTHhxclV0Z1VGZVMzZlk3?=
 =?utf-8?B?dnBMWEsvY3lIdEg1K29CUnppU1pMa1NHVHVTL0o4dzdSZFlGUGloZGZEeVV5?=
 =?utf-8?B?QmxYazY0QlVST3BJS3VIRUVHYWFmN2VnOWJ1aEZ6Wk40MVIwRlVhL3VBdVk1?=
 =?utf-8?B?cDdRZWErVDFXZmVlZ01yclJsa0daTE1YZUpnc1VzUWxGYmFYalZuL05xTmcy?=
 =?utf-8?B?WWdRRUhhMGdTYnRZMXAvWHFuZW1LQ0l0bGpwa0hubUFaNXJLU2dQYkVGNHNS?=
 =?utf-8?B?Y3dqbWY5amErSnhUWXZQNGhncHozbHNUWXVWU29DWFZYbG45RXdROEcvWmJx?=
 =?utf-8?B?bzAwenZ6bVk5TmxBTUNBSmQ5S3dvMUU3Q3VHWENYWlVjc2IyYTE0UT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <647FBC7B75172C49B699826FF4F4370F@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 36dba2b1-372b-4825-8bf0-08d9e7211ddf
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Feb 2022 14:26:06.9356
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ljXTJVVPU3nuxLj6YGv2yAOMgWEGJViJKZpiHLc8rHL/26gyd/2HC+lE5gYc9MK0kJJvtYsofHUv7H2ISbcdk0TzsA/AdlqMZmH6GJBe7ClKDHfi1OMtLJuSq8QBvSr4
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR03MB6369
X-Proofpoint-GUID: S4tDpQkVhOKM21oRYPF5ZqjcYDesbk_-
X-Proofpoint-ORIG-GUID: S4tDpQkVhOKM21oRYPF5ZqjcYDesbk_-
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-03_04,2022-02-03_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 mlxscore=0
 spamscore=0 suspectscore=0 mlxlogscore=999 adultscore=0 priorityscore=1501
 bulkscore=0 lowpriorityscore=0 phishscore=0 clxscore=1015 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2202030089

DQoNCk9uIDAzLjAyLjIyIDE2OjA1LCBSb2dlciBQYXUgTW9ubsOpIHdyb3RlOg0KPiBPbiBUaHUs
IEZlYiAwMywgMjAyMiBhdCAwMTozMDoyNlBNICswMDAwLCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5r
byB3cm90ZToNCj4+DQo+PiBPbiAwMy4wMi4yMiAxNDo1NCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+
Pj4gT24gMDMuMDIuMjAyMiAxMzo0NSwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+
Pj4+Pj4gQWxzbyBtZW1vcnkgZGVjb2RpbmcgbmVlZHMgdG8gYmUgaW5pdGlhbGx5IGRpc2FibGVk
IHdoZW4gdXNlZCBieQ0KPj4+Pj4+IGd1ZXN0cywgaW4gb3JkZXIgdG8gcHJldmVudCB0aGUgQkFS
IGJlaW5nIHBsYWNlZCBvbiB0b3Agb2YgYSBSQU0NCj4+Pj4+PiByZWdpb24uIFRoZSBndWVzdCBw
aHlzbWFwIHdpbGwgYmUgZGlmZmVyZW50IGZyb20gdGhlIGhvc3Qgb25lLCBzbyBpdCdzDQo+Pj4+
Pj4gcG9zc2libGUgZm9yIEJBUnMgdG8gZW5kIHVwIHBsYWNlZCBvbiB0b3Agb2YgUkFNIHJlZ2lv
bnMgaW5pdGlhbGx5DQo+Pj4+Pj4gdW50aWwgdGhlIGZpcm13YXJlIG9yIE9TIHBsYWNlcyB0aGVt
IGF0IGEgc3VpdGFibGUgYWRkcmVzcy4NCj4+Pj4+IEFncmVlLCBtZW1vcnkgZGVjb2RpbmcgbXVz
dCBiZSBkaXNhYmxlZA0KPj4+PiBJc24ndCBpdCBhbHJlYWR5IGFjaGlldmVkIGJ5IHRoZSB0b29s
c3RhY2sgcmVzZXR0aW5nIHRoZSBQQ0kgZGV2aWNlDQo+Pj4+IHdoaWxlIGFzc2lnbmluZ8KgIGl0
IHRvIGEgZ3Vlc3Q/DQo+Pj4gSWlyYyB0aGUgdG9vbCBzdGFjayB3b3VsZCByZXNldCBhIGRldmlj
ZSBvbmx5IGFmdGVyIGdldHRpbmcgaXQgYmFjayBmcm9tDQo+Pj4gYSBEb21VLiBXaGVuIGNvbWlu
ZyBzdHJhaWdodCBmcm9tIERvbTAgb3IgRG9tSU8sIG5vIHJlc2V0IHdvdWxkIGJlDQo+Pj4gcGVy
Zm9ybWVkLiBGdXJ0aGVybW9yZSwgKGFnYWluIGlpcmMpIHRoZXJlIGFyZSBjYXNlcyB3aGVyZSB0
aGVyZSdzIG5vDQo+Pj4ga25vd24gKHN0YW5kYXJkKSB3YXkgdG8gcmVzZXQgYSBkZXZpY2UuIEFz
c2lnbmluZyBzdWNoIHRvIGEgZ3Vlc3Qgd2hlbg0KPj4+IGl0IHByZXZpb3VzbHkgd2FzIG93bmVk
IGJ5IGFub3RoZXIgb25lIGlzIHJpc2t5IChhbmQgaGVuY2UgbmVlZHMgYW4NCj4+PiBhZG1pbiBr
bm93aW5nIHdoYXQgdGhleSdyZSBkb2luZyksIGJ1dCBtYXkgYmUgYWNjZXB0YWJsZSBpbiBwYXJ0
aWN1bGFyDQo+Pj4gd2hlbiBlLmcuIHNpbXBseSByZWJvb3RpbmcgYSBndWVzdC4NCj4+Pg0KPj4+
IElPVyAtIEkgZG9uJ3QgdGhpbmsgeW91IGNhbiByZWx5IG9uIHRoZSBiaXQgYmVpbmcgaW4gYSBw
YXJ0aWN1bGFyIHN0YXRlLg0KPj4gU28sIHlvdSBtZWFuIHNvbWV0aGluZyBsaWtlOg0KPj4NCj4+
IGRpZmYgLS1naXQgYS94ZW4vZHJpdmVycy92cGNpL2hlYWRlci5jIGIveGVuL2RyaXZlcnMvdnBj
aS9oZWFkZXIuYw0KPj4gaW5kZXggNzY5NTE1OGU2NDQ1Li45ZWJkNTc0NzJkYTggMTAwNjQ0DQo+
PiAtLS0gYS94ZW4vZHJpdmVycy92cGNpL2hlYWRlci5jDQo+PiArKysgYi94ZW4vZHJpdmVycy92
cGNpL2hlYWRlci5jDQo+PiBAQCAtODA4LDYgKzgwOCwxNCBAQCBzdGF0aWMgaW50IGluaXRfYmFy
cyhzdHJ1Y3QgcGNpX2RldiAqcGRldikNCj4+ICAgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHJl
dHVybiByYzsNCj4+ICAgwqDCoMKgwqAgfQ0KPj4NCj4+ICvCoMKgwqAgLyoNCj4+ICvCoMKgwqDC
oCAqIE1lbW9yeSBkZWNvZGluZyBuZWVkcyB0byBiZSBpbml0aWFsbHkgZGlzYWJsZWQgd2hlbiB1
c2VkIGJ5DQo+PiArwqDCoMKgwqAgKiBndWVzdHMsIGluIG9yZGVyIHRvIHByZXZlbnQgdGhlIEJB
UiBiZWluZyBwbGFjZWQgb24gdG9wIG9mIGEgUkFNDQo+PiArwqDCoMKgwqAgKiByZWdpb24uDQo+
PiArwqDCoMKgwqAgKi8NCj4+ICvCoMKgwqAgaWYgKCAhaXNfaHdkb20gKQ0KPj4gK8KgwqDCoMKg
wqDCoMKgIHBjaV9jb25mX3dyaXRlMTYocGRldi0+c2JkZiwgUENJX0NPTU1BTkQsIGNtZCAmIH5Q
Q0lfQ09NTUFORF9NRU1PUlkpOw0KPiBNZW1vcnkgZGVjb2RpbmcgaXMgYWxyZWFkeSBkaXNhYmxl
ZCBoZXJlLCBzbyB5b3UganVzdCBuZWVkIHRvIGF2b2lkDQo+IGVuYWJsaW5nIGl0LCBmb3IgZXhh
bXBsZToNCj4NCj4gIMKgwqDCoCAvKg0KPiAgwqDCoMKgwqAgKiBNZW1vcnkgZGVjb2RpbmcgbmVl
ZHMgdG8gYmUgaW5pdGlhbGx5IGRpc2FibGVkIHdoZW4gdXNlZCBieQ0KPiAgwqDCoMKgwqAgKiBn
dWVzdHMsIGluIG9yZGVyIHRvIHByZXZlbnQgdGhlIEJBUnMgYmVpbmcgbWFwcGVkIGF0IGdmbiAw
IGJ5DQo+ICAgICAgICogZGVmYXVsdC4NCj4gIMKgwqDCoMKgICovDQo+ICDCoMKgwqAgaWYgKCAh
aXNfaHdkb20gKQ0KPiAgICAgICAgICBjbWQgJj0gflBDSV9DT01NQU5EX01FTU9SWTsNCj4NCj4+
ICAgwqDCoMKgwqAgcmV0dXJuIChjbWQgJiBQQ0lfQ09NTUFORF9NRU1PUlkpID8gbW9kaWZ5X2Jh
cnMocGRldiwgY21kLCBmYWxzZSkgOiAwOw0KPiBUaGlzIGlzIGltcG9ydGFudCBoZXJlIGJlY2F1
c2UgZ3Vlc3RfcmVnIHdvbid0IGJlIHNldCAoaWU6IHdpbGwgYmUgc2V0DQo+IHRvIDApIHNvIGlm
IGZvciBzb21lIHJlYXNvbiBtZW1vcnkgZGVjb2Rpbmcgd2FzIGVuYWJsZWQgeW91IHdvdWxkIGVu
ZA0KPiB1cCB3aXRoIEJBUnMgbWFwcGluZ3Mgb3ZlcmxhcHBpbmcgYXQgZ2ZuIDAuDQpUaGVuIHRo
ZSBwYXRjaCBbMV0gd2lsbCBkbyB3aGF0IHdlIG5lZWQgdG8gYmUgZG9uZSBmb3IgdGhlIGd1ZXN0
IEkgZ3Vlc3MNCkkgYW0gdGhpbmtpbmcgdG8gc3RpbGwgaGF2ZSBpdCBpbiB0aGUgc2VyaWVzIHdo
aWNoIHdpbGwgc29sdmUgZXhhY3RseSB0aGUgcHJvYmxlbQ0Kd2UgYXJlIHRyeWluZyB0byBzb2x2
ZQ0KPg0KPiBUaGFua3MsIFJvZ2VyLg0KWzFdIGh0dHBzOi8vcGF0Y2h3b3JrLmtlcm5lbC5vcmcv
cHJvamVjdC94ZW4tZGV2ZWwvcGF0Y2gvMjAyMTExMjUxMTAyNTEuMjg3NzIxOC0xMS1hbmRyMjAw
MEBnbWFpbC5jb20v


From xen-devel-bounces@lists.xenproject.org Thu Feb 03 14:32:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 03 Feb 2022 14:32:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264878.458145 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFd9s-0006o1-5v; Thu, 03 Feb 2022 14:32:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264878.458145; Thu, 03 Feb 2022 14:32:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFd9s-0006nu-25; Thu, 03 Feb 2022 14:32:24 +0000
Received: by outflank-mailman (input) for mailman id 264878;
 Thu, 03 Feb 2022 14:32:23 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mjBt=SS=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nFd9r-0006no-HF
 for xen-devel@lists.xenproject.org; Thu, 03 Feb 2022 14:32:23 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 18178f12-84fe-11ec-8f75-fffcc8bd4f1a;
 Thu, 03 Feb 2022 15:32:22 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 18178f12-84fe-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1643898741;
  h=from:to:cc:subject:date:message-id:
   content-transfer-encoding:mime-version;
  bh=oBUglG6X8uiWkqddQZ6935oCf0m9hHKC4JL6UB+D6dQ=;
  b=PgrO+KHfxcEy+JtMzvi1LnkWNBf7o19ngq/z2nbpEcJjZGtuV3IloZzt
   7uYAjH2x2FUd4j4CXoC3h3DJXhLtS3Q50YJi419xDp2D1RkKJMFciZVmy
   mcZ9+dxFhpufOW/d1BcgtOR3K7au3f7OTQiXqWjOV3PhkT+6X/070oZHq
   k=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: MCNAOIjh+atY4GbeYkBGJiiWl48Se2YP6bivFr9byG9pU1fhnyB8Gq59t8ksoVQXdxGrxcoxcz
 e8w3JbkNsIo/gK6wvJ5ACJS8Kzxsn90/q2/v3X3yFimzSHOqQrawz7txKA+Mp016TDQfdvMCmT
 WsAtXhK7KloPi4GcN02t4ApiMupvDYGGzI6zfSwGwijEcczqds3KCPCGXA0cHbITOvDCY/Jhfn
 6ffFJNnNNUP4mGMgD4zpIi8AV1pgg58lubH3wGdh+tfZcK9y4NrLgU6xwxp8j9+uqiVpj42sWF
 Q6YiFzlQqeyqdB1JI1YRzspN
X-SBRS: 5.2
X-MesageID: 63417709
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:zgNHJ6vnjQMD/4t029Oji8QUeefnVKdZMUV32f8akzHdYApBsoF/q
 tZmKTiHPfmNM2Hycttzbt/k8R5XupLUndZqHgU9/HpkFisX+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZQP0VOZigHtIQMsadUsxKbVIiGHdJZS5LwbZj2NYy2YPhWWthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 Nplsr3vcgoqO6z3xOlaDzJdPS4iLZdFweqSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DJoQQt2sm1TjEJf0nXYrCU+PB4towMDIY2JsSRKmBP
 5txhTxHYQbvYk1/Og4tNtFhxNeY22jkVxRhkQfAzUYwyzeKl1EguFT3C/LXdcaNXt59hVuDq
 yTN+GGRKhMQOcGbyDGF2mmxneKJliT+MKoCGbv9+vN0jVm7wm0IFAZQRVa9ueO+iEO1R5RYM
 UN80jUqhbg/8gqsVNaVYvGjiCfa5FhGAYMWSrBkrlHWokbJ3+qHLm8lEQVMa9knj5M7AmAB0
 3GGw8PTBgU65dV5Vkmh3ruTqDqzPw0cImkDeTIIQGM53jXznG0gpkmRF4g+ScZZmvWwQGitm
 G7S8EDSkp1O1ZZj6kmtwbzQb9tATLDtRxV92AjYV3nNAuhRNN/8PNzABbQ2AJ99wGelorup4
 SBsdyu2trlm4XSxeMqlGr5l8FaBvK7tDdEkqQQzd6TNDhz0k5JZQahe4StlOGBiOdsedDnib
 Sf74F0Nv88IYSX3PPQoOOpd7vjGK4C6TrwJsdiPNrJzjmVZLlfbrEmCm2bMt4wSrKTcuf5mY
 srKGSpdJX0bFb5m3FKLqxQ1itcWKtQF7TqLH/jTlk3/uZLHPSL9YepbbDOmM75ohIvZ8FS92
 4sObKOilkQAONASlwGKq+b/23hQcyhibX03wuQKHtO+zv1OQzB8UqKBnO96JuSIXc19z4/1w
 510YWcBoHLXjnzbMwSaLHdlbbLkR5FkqnwneycrOD6VN7ILO+5DNY8TKMk6e6cJ7utmwaImR
 vUJYZzYUP9OVi7G63IWapyk9N5ucxGihASvOSu5YWdgI848FlKRotK0LBHy8CQuDzassZdsq
 bOXyQ6GE4EIQB5vDZiKZav3nU+xp3UUhMl7Q1DMfotIYEzp/YUzc37xg/Y7LtsiMxLGwjfGh
 Q+aDQ1B/bvGopMv8cmPjqeB9t/7H+x7F0tcPm/a8bfpanWKojv9mddNCb/acyrcWWX4/LSZS
 d9Ul/ysYucamFtqspZnF+o5x6wJ+Nay9aRRyR5pHSuXYg3zWK9gOHSPweJGqrZJmu1CoQKzV
 0+CpotaNLGONJ+3GVIdPlN4POGK1PVSkTjO9/UlZk794XYvrraAVExTOTiKiTBcc+QpYN90n
 795tZ5E8RG7hzorLs2C33Jd+Gm7J3AdV7kq68MBC4jxhwt3klxPbPQw0MMtDE1jvzmUDnQXH
 w==
IronPort-HdrOrdr: A9a23:ETTkA68MonO2Z2R7Yypuk+E0db1zdoMgy1knxilNoENuHfBwxv
 rDoB1E73LJYVYqOU3Jmbi7Sc29qBTnhORICOgqTMyftWzd1ldAQ7sSi7cKrweQeREWldQtqp
 uIEZIOceEYZGIS5a2RgHjaLz9J+qj6zEnCv5a4854Cd3AOV0k2hD0JdzpzX3cGDTVuNN4cLt
 6x98BHrz2vdTA+adm6PGAMW6zmq8fQnJzrTBYaD1p/gTP+xg+A2frfKVy1zx0eWzRAzfML9n
 XEqRXw4uGGv+ugwhHR+mfP59B9mcfnyPFEGMuQ4/JlYgnEu0KNXsBMSreCtDc6rKWG70srqs
 DFp1MaM8F6+xrqDxWIiCqo/zOl/Ccl6nfkx1Pdq2Dku9bFSDUzDNcErZ5FczPCgnBQ8O1U4e
 Zu5Sa0ppBXBRTPkGDW/N7TTSxnkUKyvD4LjfMTtXpCSoETAYUh4LD3xHklXqvoIRiKqbzOSI
 JVfYHhDbdtABmnhknizyZSKIfGZAVxIv+EKnJyz/B9nQIm3kyR9HFotfD3qE1whq7Ve6M0md
 gsDZ4Y5I2mNvVmFZ6VJN1xNvdfWVa9Ny4lDgqpUCfa/ec8Sjfwl6I=
X-IronPort-AV: E=Sophos;i="5.88,340,1635220800"; 
   d="scan'208";a="63417709"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=bcPEZFcjmRHpE2l+MQRNP+mIWWP2EvvsQHApnda30qSZsPL6dUiwkU8izpy3gIrky6p00gQVB2tqa/hk6Xrg1A/Rm0Vu7BQNAqQv7A7u9utw/U5193DObg+AHKdpIo4WMIC8z6HS2JMnvs8OQHhbfjzq7imAue47hBSZsOAZDtbS9F1xvO4x5YFEJUU3Puhau4N2NLSwOyEV1XN8lOVjCLrzZUiK9ua2aqN4f7aTOo1KnmuSrtzxnHQIMfFTQkQslnxzXacZ5uJ5TbQX2NAnzbpckeM1/ZrkykU14biZOlcDLFuYY6zLJGttSmZSIOwCjKdK1P6Ea0WsslAioooxcg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=tdZCE3jW8S28XPDZ2yi5CBt3HMczKkZ71EmvZ40xOhI=;
 b=IcV5Of9PPlCDp59QzR+5xV0BI4lpELCsSu/8+jE8ExKQMGdfnCJdZtZsyI0AZ9VpkQu6OW0eChXCltNtRbS5UlOpaZ7L+K79wGd2qPK34cCnoZQxemZP+1AeW6pdlwP/rBl842RewdTKL+IG3OhoKow6yr8QKQWhLljT5rEv7B2qdgd24BowImgfxNDihAabmUnCnaDm7HjTn8wzL+KbWDlDR8fv14avjItGDPWiK7cj/M2OAfwhGDgk4BnDvOiB5NmFqGxB1LLkot0QIh6a3yZLxc+b0PhWjX0/ivqoCQYN5jy8AN6fpX688LiSv8a9pSfKFW2qVS1D0q2ZKA5Ubw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=tdZCE3jW8S28XPDZ2yi5CBt3HMczKkZ71EmvZ40xOhI=;
 b=JaQnCxFLeoT3OUrQNEz0Rz7cousvE7v9gSaj/REn7SRnLp+7yYY2i2Ijlki2UcDNBXWWbB14n93klJx9hXT2Pd3YP6bIuun1mUO+CDM+kToGolcIgM2yTfFGWbOhGT8qzQqTrnQoE9yyOl8qag4cqIXhYyPdhVLltg6V77QrfR8=
From: Roger Pau Monne <roger.pau@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>, Anthony
 PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, Jan
 Beulich <jbeulich@suse.com>
Subject: [PATCH v2] tools/libxl: don't allow IOMMU usage with PoD
Date: Thu,  3 Feb 2022 15:32:11 +0100
Message-ID: <20220203143211.18967-1-roger.pau@citrix.com>
X-Mailer: git-send-email 2.34.1
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO2P265CA0457.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:a2::13) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d57dc1a3-29fb-4de0-c564-08d9e721f952
X-MS-TrafficTypeDiagnostic: MN2PR03MB4942:EE_
X-Microsoft-Antispam-PRVS: <MN2PR03MB4942A8A09A8BC3963CDB269C8F289@MN2PR03MB4942.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3513;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: uRTZzmOuuR9181fwqoT61dIhqLzP4DDisH5LBzaPGdHSY5zI8rP2zMX+MfO1KV5DCxBCU8XtrZO6kxM1e05aLgTn8DMI7yi1pK4LcrsgPd0R1GvhhVOam+RozE72n9E/JRstxyNh0HTlnMF0hSPvLhc4xzlbuXKzgt1UvkXsDd0dZTniyqxUhP2XKSh42ERjeDRioSpNFVuaEYLEHFZKAWUc4LLGhW7F/EcLOoTikKfEUN5XBW2YdScVUDtl4byWl6aNbkGe+705f7FiPfZKFOYYgRb6D6ZylMpV31xHwf2LUNa2NtCg460/Keeq1SBNDpFNYXTWoMChoRVKe4MyJ79mITRyJh1UIUNqSJHOuqgFA/3NxdFjctrsgO3E9JzTqXnHjkzzMgiasclB7DrwkUWzcA15PrsTt8GqtsH25W5ZffSh7g2i1mIHjkEKrKkd2nlDOnzBfBXgs1ZjQPxv8jannHUtB5Mo+fRojuq+Mxq67z+jCRy3E3+XK9Bie8QFh8an3/gfoZhHIQ5JTS8XArvDwelddlN3YE60s3DPhZZQRfLNzWI2u1D+oBPFfP/VWNN2yfdrVRDc7ou/CiesMPLXBpsWm3NGR+PuV+5gJhMsa8liAQvdH4a5kYmgHKwklPvLVpXCoe0Tkm8wr4GEBQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(54906003)(6916009)(38100700002)(508600001)(6512007)(86362001)(316002)(36756003)(6486002)(8936002)(8676002)(5660300002)(6666004)(66476007)(66556008)(66946007)(83380400001)(6506007)(26005)(186003)(1076003)(2906002)(2616005)(82960400001)(4326008);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VE8rVi8zQ25yTlNja1FYTGZWb3dic1BVZTNGV0tiSkVxNXU1cEcraTZZUWg4?=
 =?utf-8?B?dHRyKzVnSWw4TXl5VmJ3ejFiOWxXMXdJQTRaQlhpdXc5RFFvVFFwMG9tb2J6?=
 =?utf-8?B?eGZURUJsbDlEZU8wdGhCTUpzOWZnQTlnblk5M1pGZWdDVkl2OE9aUS9FVVJz?=
 =?utf-8?B?U1BlUkJOc1BwbXpnK1pOMWM3UUp3YmtIUE1NRlVtQlFza3k0TjAvZExzOUZn?=
 =?utf-8?B?NWlTeFNKMkNwQTZROS83ZnFVdGUzWFh4QzZQQlVQNWIwY2R0ekFQLzZMdVcw?=
 =?utf-8?B?bGdRSlhaVWo5MGdHT3pNZFJBcE1YdEh5N3ByNG5CZXFyVUFoQ1IxNXQ4bWhr?=
 =?utf-8?B?dllwbTRNZ2pYWVNlTG8zcWlpVUN6SURsNGlXYjJtdUNxTFlvTThlWWhJMkVn?=
 =?utf-8?B?aXdhaTRHeW9YeDhWY0p4enpsUEplOXg5WUhWUExsL1lnT24yQ3VLdWRKTmRr?=
 =?utf-8?B?emJQdXk3bTMzSWptcHVURVZnaENQcGt0RWNwOWxXMmdLMDMzM0hqL2hheDlo?=
 =?utf-8?B?RUpEZEdla0t4OEU4SW1XczR3bmpIdDlSYmFnbkZwZXpGWkZlaW8vb1o5aTY4?=
 =?utf-8?B?TzRkdDc0ZFpaS2p4S2JSQksxZFlJbGhWeWluaUs2bUcxTm8vd1F3ckx4MmpB?=
 =?utf-8?B?WEhFUDVnZEs2bFJxK2RhWFFNR1F3ay8wVXRoeSsyT3pkREE3T2YvLzJlVUhk?=
 =?utf-8?B?NUxGNkpHUmhCNVNDYzdZcHFsdTNVaWFlTWRKM0xhdFdCT3FYMkhXRE5ZeXR2?=
 =?utf-8?B?WEZ0QmZYT1FXZitmbUdSMEpBSmZWc0RQeWJoSmp3VzJoU1dUZ1U2RDJJdGZ0?=
 =?utf-8?B?c3NWODR3VUNlN1lqaGpRVFZjV2QrRFRmbGpDODBwS00zSzYwK2w5dGZQczNx?=
 =?utf-8?B?eEpoelg4MXlYK25ZeU41SklxRWE5cjR6bUhBemM4cUd5T0NrNXM4cXZDU2Fi?=
 =?utf-8?B?RHpZclNMdG83MC9kakJwWlRlbGtjNkhNeTNtQTJtTjd3NkhrMnA5WW5ianNT?=
 =?utf-8?B?ekpVK0FDL21IeHE4ZzBRNjhEUkZvM2VmNmxmTm5mZ3Jwek1FUEwxV3l4ajAv?=
 =?utf-8?B?bWdYaWFhK1dRZk4wZXBuV3BYbUJWdnNtZW5MdVA0OUwvWlhsQjFtc0RyY29Y?=
 =?utf-8?B?V0JIUHU2YkU1a1BwRzJaTXlQUWQybmlsUFpoWTg5OUpkVjQ0TkVuVHB0bzBo?=
 =?utf-8?B?WUhuNDM4eWVkZ2poY1pCRS9YcEVPZUkwclNseWhGVjVLTlNMRnE3Ti9SZ3VH?=
 =?utf-8?B?ekhZc3M2a2h3bno2OFVHMzFxV3IreXZGNjkyUlBoK2Iva2REZXlDa1J4MGZO?=
 =?utf-8?B?V1FZVnpTbTZHSVFHdFZZU2F6aUpleTl6R0RzSGx0VkplVmtBMXVGMThSVXd5?=
 =?utf-8?B?OFo1RlI0aGhMZ016N0tycnVyQXkwREM4SEhxaFI5S3ZLQk9hK0I0VDBSejJL?=
 =?utf-8?B?RjV3UnBpcnllZFBnUXo1Zkp2Y25qeDdndGtrdEUyQnhyRzV2T2lWZWNyMWNk?=
 =?utf-8?B?Q01LUWFqc1JsUStFamI3c29WLzhZdEpLc1dCaEQ2YjQrUGxNYVI2MlY5MzA1?=
 =?utf-8?B?dVc0Skt0WkdwYWJNU3NXQzFYN1RnQlZ4MnRxM081c20xaDRLbzRIaDVpd05N?=
 =?utf-8?B?SFF6THV0aFpEZ05ITCtQd2pOeVlGTXZZVTM5b1NCVzVMOVpSTHB6MUY1V3hY?=
 =?utf-8?B?YzE2ZU1CbU90SEYvbDA1WVViU0duaFlsOWh2d0F4UGFGbyticmZJbGZmSnJK?=
 =?utf-8?B?dUl3eU9JL2JBLyt4WDM1aDNBNDV3WVdDa2VtMHo4RXlJMHY3Yk9UWTZDektp?=
 =?utf-8?B?U2pYNmRBdVJpMit4aTBLaGdJbmdEMnVYeFJGM2dDRU9XVDMyckJ2S1ROc21X?=
 =?utf-8?B?cThmTG1kVkVhZzNEOHAwSVgxUmZiZkNJQTRNaGFwWUdrWFI4N2o3aUd6MjdT?=
 =?utf-8?B?Q0d6K2tmRXVUK0R2KytqdXJjNjM1RnFjNENGNnBXSmpHMHZaN1AxdnFzbENa?=
 =?utf-8?B?Rk1UZkJNd29WV1Y5aXAreFhVR0N6c2VXcVEvTlo2SUZkQkxabnRtRzZxSTNQ?=
 =?utf-8?B?aGNleWxXUE1xWnRqTUs5K21hUnVsbmVWWWhNcllYZFlaMUNWZ0dCbmg3RGhm?=
 =?utf-8?B?aGNjOVRMSVV3TjhUZWtnK3loeHRxZC9kUUlVL0MwRklsMjZBY1BXWUdGaXcw?=
 =?utf-8?Q?nx8TTjuybVaSFqEFCEGfxl0=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d57dc1a3-29fb-4de0-c564-08d9e721f952
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Feb 2022 14:32:15.4554
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vjaH/8ZWXeZUMX08K5U2ambf3w2EqGgXIFauCvQNZd0sk5Q6g1ui6oOWF9R4kLAJMWlNxo7+hYJAVnzFpoiT5Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB4942
X-OriginatorOrg: citrix.com

Prevent libxl from creating guests that attempts to use PoD together
with an IOMMU, even if no devices are actually assigned.

While the hypervisor could support using PoD together with an IOMMU as
long as no devices are assigned, such usage seems doubtful. There's no
guarantee the guest has PoD no longer be active, and thus a later
assignment of a PCI device to such domain could fail.

Preventing the usage of PoD together with an IOMMU at guest creation
avoids having to add checks for active PoD entries in the device
assignment paths.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Cc: Jan Beulich <jbeulich@suse.com>
---
Changes since v1:
 - Reword commit message.
---
 tools/libs/light/libxl_create.c | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_create.c
index d7a40d7550..7499922088 100644
--- a/tools/libs/light/libxl_create.c
+++ b/tools/libs/light/libxl_create.c
@@ -1160,17 +1160,16 @@ int libxl__domain_config_setdefault(libxl__gc *gc,
     pod_enabled = (d_config->c_info.type != LIBXL_DOMAIN_TYPE_PV) &&
         (d_config->b_info.target_memkb < d_config->b_info.max_memkb);
 
-    /* We cannot have PoD and PCI device assignment at the same time
-     * for HVM guest. It was reported that IOMMU cannot work with PoD
-     * enabled because it needs to populated entire page table for
-     * guest. To stay on the safe side, we disable PCI device
-     * assignment when PoD is enabled.
+    /* We don't support having PoD and an IOMMU at the same time for HVM
+     * guests. An active IOMMU cannot work with PoD because it needs a fully
+     * populated page-table. Prevent PoD usage if the domain has an IOMMU
+     * assigned, even if not active.
      */
     if (d_config->c_info.type != LIBXL_DOMAIN_TYPE_PV &&
-        d_config->num_pcidevs && pod_enabled) {
+        d_config->c_info.passthrough != LIBXL_PASSTHROUGH_DISABLED &&
+        pod_enabled) {
         ret = ERROR_INVAL;
-        LOGD(ERROR, domid,
-             "PCI device assignment for HVM guest failed due to PoD enabled");
+        LOGD(ERROR, domid, "IOMMU not supported together with PoD");
         goto error_out;
     }
 
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Thu Feb 03 14:41:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 03 Feb 2022 14:41:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264885.458156 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFdIh-0008Gj-2b; Thu, 03 Feb 2022 14:41:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264885.458156; Thu, 03 Feb 2022 14:41:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFdIg-0008Gc-VE; Thu, 03 Feb 2022 14:41:30 +0000
Received: by outflank-mailman (input) for mailman id 264885;
 Thu, 03 Feb 2022 14:41:30 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Ap74=SS=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nFdIf-0008GW-TA
 for xen-devel@lists.xenproject.org; Thu, 03 Feb 2022 14:41:30 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5dd0d910-84ff-11ec-8f75-fffcc8bd4f1a;
 Thu, 03 Feb 2022 15:41:28 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5dd0d910-84ff-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1643899288;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=r5t3oiVXjagXb7bjTG448gBBaQt4H1arjpez6xgFQrQ=;
  b=a20xeHvDgLPdL6zJcwhFYa4+ieZyvQQq1m6jnuHXNMRExLXri8ENwez9
   G1NyeSzxCAJOlJV3pGzJBRUZ1oHzs7WE3yCMjyEP9rLtyRw0uvTyXPH0Z
   qVoGzu2q2cdyPYhH8nJ1yPmAzPREB+/x28Z27n3iN7gyZBKwJ404b3yMd
   Q=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: q37zmNw1Q1eAI6n41QOUPpgtHLcg8l6pC73MbBnh/5JxV7bTEvnWATP/fGrCs/aMPU2ErfpD04
 7/ny+gEkpFAZsd88llwgSznNOyOhzsh4KhCrlDzaolk+33yNDzoymFuUen/nrn9+aEyD4VVJJc
 z5UFuSR7VmFjR67P0NOg6RfpcdQesdlCRjzRBiMfcD33NLoQUygkDG7vd7aZZ60kt1M77QZWks
 DsLRQDZRZRGAN/Jab/QX9XF3rY0tA810mIfE4IjNeWP0dzrfvKXuo6VRWHTY6L7W+E7VpG0xVS
 GrVs0dUqJxF4GuqDzVBT1Qww
X-SBRS: 5.2
X-MesageID: 62879565
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:SzJWVK47k9YsJa+PSkOE6wxRtHrBchMFZxGqfqrLsTDasY5as4F+v
 mcbXGGCOa2MZ2egfIskbt7k8B4Fv5OAnd9qGQRoqnxhHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FV8MpBsJ00o5wbZj2tUw27BVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zw
 9pwi5KoeVkVOajBxtQ8CQh5THxMIvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALBc/nJo4A/FpnyinUF60OSpHfWaTao9Rf2V/cg+gQR6aBN
 pdHNFKDajzJRAJpYlU4MKgHneWqqkL0KmBZt3Wa8P9fD2/7k1UqjemF3MDuUuKNQcJZj0OJv
 FXs9m7yAgwZHNGHwD/D+XWp7sfFkDnnQosUGPu9/+RznVyI7mUJDVsdUl7Tiem0jAuyVsxSL
 2QQ+zEytu4i+UqzVN7/Uhak5nmesXY0QMFMGuc37AWMzKv84AuDAGUACDlbZ7QOtsU7WDgr3
 V+hhM7yCHpkt7j9YXCA8raZqxuiNC5TKnUNDQcbSSMV7t+lp5s85i8jVf46TvTz1IesX2itn
 Xba90DSmon/k+YA2JiF80j33Q6ro5WXfi9v9ySIA1C6u1YRiJGeW6Sk7l3S7PBlJYmfT0Wcs
 HVsp/Vy/NziHrnWynXTHbxl8KWBoq/cbWaC2QIH84wJqmz1k0NPa7y8992XyK1BFs8fMQHkb
 0bI0e+6zM8CZSD6BUObjm/YNijL8UQCPYm9Phw3RoAXCnSUSONh1Hs1DaJ39zu1+HXAaYllZ
 f+mnT+EVB7285hPwjusXPs62rQ23C04zm67bcmlk0/3iufAOS/OFuxt3L6yggYRtvjsTOL9q
 I43Cid3408HDL2Wjtf/reb/0mzm3VBkXMur+qS7h8aIIxZ8GXFJNhMi6ehJRmCRpIwMzr2g1
 ijkAidwkQOj7VWad1niQi09OdvHAMYuxVpmbHdEFQv5hBAejXOHsf13m20fJ+d3rYSODJdcE
 pE4Ril3Kq8eF22aq2lBNsSVQU4LXE3DuD9i9hGNOVAXV5VhWxbI6pnjeA7u/zMJFS25qY01p
 LjI6+8RacNfL+i7JMqJOv+p0X2run0RxLB7U0fSe4EBc0Tw6ol6bSf2i6Zvcc0LLBzCwBqc1
 hqXXkhE9bWc/ddt/Ymbn72AoqeoD/B6QhhQEV7E4OvkLiLd5Gein9NNCb7aYTDHWWro06y+f
 uEJnerkOfgKkQ8S4YpxGrpm14wk4N7rq+MIxwhoBiyTPV+qFqlhMj+N2swW7v9BwbpQuA2XX
 EOT+4YFZeXVaZ29SFNIfVgrdOWO0/0QiwL+1/VtLRWo/jJz8ZqGTV5WY0uGhhtCIeYnK4gi2
 +og5pIbslTtlhowP9+apSlI7GDQfGcYWqAqu5xGUo/mjg0nlgNLbZDGU3Kk5ZiOb5NHM1UwI
 y/Sj63H3uwOyk3Hens1NH7MwesC2she5EEUlAcPdwaTh97Ipv4rxxkAoz04QzNcwghDz+8ua
 HNgMFd4JPnW8jpl7CSZs7tAx+2V6MWlx3HM
IronPort-HdrOrdr: A9a23:cKbWV63qix3L+e8QJ5CwYgqjBRZyeYIsimQD101hICG9Lfb2qy
 n+ppgmPEHP5Qr5AEtQ5OxpOMG7MBbhHQYc2/heAV7QZnibhILOFvAi0WKC+UyuJ8SazIBgPM
 hbAtFD4bHLfDtHZIPBkXOF+rUbsZm6GcKT9J/jJh5WJGkAAcAB0+46MHfhLqQffngdOXNTLu
 v52iMznUvHRZ1hVLXdOpBqZZmgm/T70LbdJTIWDR8u7weDyRmy7qThLhSe1hACFxtS3LYL6w
 H+4k/Ez5Tml8v+5g7X1mfV4ZgTssDm0MF/CMuFjdVQAinwizyveJ9qV9S5zXIISaCUmRMXee
 v30lAd1vdImjXsl6aO0ELQMjzboXITArnZuAelaDXY0JfErXkBerV8bMpiA2XkAgwbzYxBOe
 twrhKkX9A8N2KwoA3to9fPTB1kjUyyvD4rlvMSlWVWVc8EZKZWtpF3xjIeLH4sJlOz1GkcKp
 gkMCgc3ocjTXqKK3TC+mV/yt2lWXo+Wh+AX0gZo8SQlzxbhmpwwUcUzNEW2i5ozuNwd7BUo+
 Dfdqh4nrBHScEbKap7GecaWMOyTmjAWwjFPm6eKUnuUKsHJ3XOoZjq56hd3pDmRLUYiJ8p3J
 jRWlJRsmA/P0roFM2VxZVOtgvARW2sNA6dg/22J6IJzIEUaICbQxFreWpe5PdI+c9vcfEzc8
 zDTa5rPw==
X-IronPort-AV: E=Sophos;i="5.88,340,1635220800"; 
   d="scan'208";a="62879565"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=kKFeJGPYDo3IfQT+VmHx2Y0EMEEK8sqinI3BAqjxJxdSFWI4CTTBDZoxVv/um4AfA5TAxVzFz/Oi+fudbc/5f/amYB0nmdsgY2LSrttqZEVoDXwwBbBHynzGwcz/dn10uIvhfzKR4PSS0MN21xXtjkK9DwIR7AvJ6Ej+WAbZUH1rUYgbaOWglplM2Tch81j4yJU4w9FKG/JU08h1fb77VUEI183E8MIV6pzRw7+/xKR4iBbE8XELRFrdjf5a2SsrY0qo3CXKppwtTvSGmedtacOcmYnfIxtFxc2guDCdJLJWay0TEdrkoPKml68zFQr1BSePIddORJnH01XU7QoJyg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=r5t3oiVXjagXb7bjTG448gBBaQt4H1arjpez6xgFQrQ=;
 b=comSFbZvwcgB30JtEpb1+8VfQIUBv6lsiN47jGJUkOkiJ0Azlxyj8MUcfLY3k/0vfnRPuGxLYJ5re7NbkY84haQPi+OXyu3GEZsmz32/6XlvcvUPKof0nJUOqwBvSotKz9Whxjfk4wC3YIqHPa5EOFIlXLzA/31LyDGoUbEfzxtdXR72JHl10D9fq77/wZDLcJpCYIqUG2NEl4ahJhjns7GF9/Zh60juLZx3FaH9ndFiOTshrxMyiXQIKWNRXGplTRLpVols3dUFXM5rCNAn9wKMDlambTXSGYKWhFS2KVQpbcLPh/A07BMGyYlqe9c1SJXElP913/1gsGbXfGV9vw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=r5t3oiVXjagXb7bjTG448gBBaQt4H1arjpez6xgFQrQ=;
 b=sb4qEyLtP3wATAhDxFOm1/lGb/3JrqdeWQ20ZvaWiRhEQdzk8Uv66bGBb+yrkx63TUUadrYU2dI5y4/KW3fZPemfaviA2qYw5y0OmDU29QIs3vwl/qiTsCvSJ0nE3Rnqzs2mI+YHFn/MG5L4W6VZR9DFQiZGvkESoCWs7v4uRjk=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>, Andrew Cooper
	<Andrew.Cooper3@citrix.com>, Julien Grall <julien@xen.org>
CC: Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>,
	Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] xen: Modify domain_crash() to take a print string
Thread-Topic: [PATCH] xen: Modify domain_crash() to take a print string
Thread-Index: AQHYGQNtP3H+icKR40C9qFef/QWZtKyB12EAgAAGeoCAAAIkgIAABjKA
Date: Thu, 3 Feb 2022 14:41:21 +0000
Message-ID: <8a28b63b-a5f6-db0f-3108-646475912abd@citrix.com>
References: <20220203133829.7913-1-andrew.cooper3@citrix.com>
 <c0d82900-64d1-fe16-9283-deb7c324ff8a@xen.org>
 <ad7467d2-1cae-c8ea-1217-69f0924044d4@citrix.com>
 <348f062c-9aed-0275-f0ad-87a0eff8e986@suse.com>
In-Reply-To: <348f062c-9aed-0275-f0ad-87a0eff8e986@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.1
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 5aa15e95-3313-4f0a-2b83-08d9e7233f40
x-ms-traffictypediagnostic: CY4PR03MB3031:EE_
x-microsoft-antispam-prvs: <CY4PR03MB30314EC6C054B43D87DDAE0DBA289@CY4PR03MB3031.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:4502;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: HNeLtnYzAP6pEJprtmd0FZFaeLrk6OHJNzhKujCPyzFa5xXe2PBfPEgf4zumdZGTW6dtROu4Ve3FRggIm4uj6wmq+imBuEVTjvrY+KnKfysREJBHy4fwmJAbuwh2km7y3nOMPIIyAfRwIif46dGPolrm++evNEG7QOj6O3UlR517RRzRSmc13Nivub9ctio1i/6FJZBW0mw5Dwetf5K7c3zKLm3UUZRVq8FxuGPpUNrrQ5JV5K9DB2FwwPQ2yTl9qkq/E8NfP51OoG3vJF6/Faq7iXi46LA/TGpwOwVp7u9v2hSAs6jMvZ5/oa9dEr6/qqbPVFWkOqUAk5VgPYQrkdIJpine1TfQhsSdoZ1/gEWCbCDIGdU+Zt/hPIccAZnU3NrrDEnibnXCY+5MfF0XxGdZTrj0QkZ4KrvqCVJ8X8dG+odAhOlDn4fYUYrrr5HagTPIdQNv45B/dqQpQfjBPdsFiXx2ettlwCgePHGIxjqKZLX2lsrJP5z12IFv45acZLCYjtOf36+DnxcU5JlJbZUkNpZ+96gQd2/a5lC1uQdtWkAYE0CQ0DsReFsDXRge3qoGiBI24mNEqtELjwmJR/CxoId2gQP2NblcC92NHTyg+RH8DQZ9YMIB+Enks2MMoVT0zZaOEvIgvAbIVlmKMkvEzOgYoivsxDhyb9jvB5gZd5rw0PbFUfYchqmHX6+Y8VahRuClcGKT2Xj+hhkY5dwfjaGhjmvyq0djNWPnitZ1dYl34Pd9waZY6NTHbDndNkw31ciYJyRpTQrrUzdByA==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(2906002)(6506007)(83380400001)(186003)(53546011)(38070700005)(5660300002)(71200400001)(31686004)(36756003)(122000001)(110136005)(54906003)(82960400001)(316002)(66946007)(66556008)(66476007)(76116006)(6486002)(6512007)(8676002)(8936002)(38100700002)(4326008)(2616005)(26005)(31696002)(86362001)(66446008)(508600001)(91956017)(64756008)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?ZU0yeVZ2ckpydlA0aGtEb0JYTlgzZmN4VnpONlVZT2VvU3hCM0lWeXBTRzdj?=
 =?utf-8?B?UFRYcDlURXdTSTk1bHhCS2hidmdnYnJyZHpIOGZ6WlpIUUVFWHNMQTl5bzBI?=
 =?utf-8?B?VjFseFhnYklPbGpwNHFUYlllYklkNEI2SVVabXp0UnF6cm1OYnJBdEg4Zndo?=
 =?utf-8?B?MnNUZVN5dzA1NG1EcWlMUkdsZ3R0T1FmemltRVlQYSs5bTBOOGFDMTRUZklF?=
 =?utf-8?B?cHpHQmovcFdiZ05HNlNKaEdYZHQzRWwwenR2dEpJVUl0eGJjbnNFaUlRcysr?=
 =?utf-8?B?d082Qm53Qm8vaXZmdmM2Q250YmNzNVdKa1JuZUVid3p3d2xaYTU3VUwvSk1V?=
 =?utf-8?B?aEl0Nnh5dFJ1UDQ2OXdBQnNVTUlua2UzbjBpbzBIenkrNXVUNkI2TThXR2VI?=
 =?utf-8?B?b3V6ZW5hc0ovQ1lJOEsxYysxRGp1M3N4OFBzWG5sMENGTEo0WHhGdDJ3VHlU?=
 =?utf-8?B?QXFrbXlwU25Mc2Z6NDNEMVBCSEkvZ2pJVjN4WjYxYi9WMnNpL3l0Y2l5V2lB?=
 =?utf-8?B?MVp1Wno5Nis0U2F4STErRGRIdmwzSlc2R0FiME9SUDhaSFJHTkJORk50T1hN?=
 =?utf-8?B?SVRtQk9wakZPT2VFSzBqUjh3V1VTeENVaHZveDluZm8yS1g0YWZZVnNXVWN0?=
 =?utf-8?B?eXJKNmFvNFV2anRMNVJpSS9odlNVWjVaMjJ0WjVUOEVOSGZCTW9aUm5SOWI0?=
 =?utf-8?B?bGxXZWxFZHgxZ2hpeEw1Ym9aK240S0w4Ym1zdUdSUUpCQnRKOVB2RlR1dmdC?=
 =?utf-8?B?NStMalhSQ3pyUlFJdEp5dFRLY3NoSTZWb3J3aDlCNjV4Ynpheis4cUp2S3Zk?=
 =?utf-8?B?M25DNGxqaVUyRkM1OVhLQXF1YzhDM2RPN1lpLzFMVUZucnJCR1p6dkpQdzJh?=
 =?utf-8?B?NllsbE8rdTgweUZiZTJSQ3MwdTRDVzhrUXVHOGNyKzFqbkxYalJJYlZaN0J5?=
 =?utf-8?B?STBGamhZZ1JGT2xLZWUvUGE1T1VRYzhGMk9sWG1abzBJYlJKT0swZGNLYmxZ?=
 =?utf-8?B?SEVRN1RxQWtHSFpkUThkdmVSWTZMVUJwTmM1Y2RxZUJVTEM2TlVab3Y3UjJY?=
 =?utf-8?B?aXBZK2NtZjNJa0U1RnF3eHRmTmtKd0llQzM5Q3VLMWpLcFY3eXJoK1cweTRV?=
 =?utf-8?B?Y042MTk1U1F5Zm1RNGtpQ1ZoMnA5NzR5ZTN4aTJCTWNvM2ZOWTRGakNGOVdG?=
 =?utf-8?B?OHp6akFvNXovck1GZ0xueHRROFg5Nm5SS2puUk5PcVRqKyt3ZHIyWTJ2MEZM?=
 =?utf-8?B?WVhuNG5FdGlXL25SUlZIZytiMWVFNDN4MGZSUkdHZ3lQMmRnY2M2dFpKM2Iy?=
 =?utf-8?B?VnRkZHN0MWZFT2Y1NG92L05EQzlla3gzTExXSGg4UTdvWXlKNXlqaFpDemhw?=
 =?utf-8?B?dTkvSFd5Wi9ya0JTc0JDQkprd3NQZmd2UEt4MU9mZUVxNkZzVWhEWmJiTms0?=
 =?utf-8?B?UkJkZTFpWjJwZFVaWno2MXY4TitYTC9lb3Y2Yjl4c1pxcDJjZHg4azZ2cjFD?=
 =?utf-8?B?VXVpdnhNWmNkSlZpaTY0QVRMRGd6SGVCWVdaNkJEQWZSeDhKWHdjeW9ZakxY?=
 =?utf-8?B?a0VTbWJDdHR6em1nL1o3aUYraGN3VUdmWm9HRlRTUVoyd3ZQQThTVW1zNWYv?=
 =?utf-8?B?MzlSS3NwUUZiZEUwd3M5QWZFeDJlT1pmTm5JMi9WK3g4cU82VDNhZjZkZGNW?=
 =?utf-8?B?MHZXSEVnUEg2SnVSa0JReTZISSt2UUtFclRiOGFsQmxNdXMvZTdSSzdqc2Zi?=
 =?utf-8?B?dDhtTEVUcTJlbE9WRWFWVll4ditLd3diaGhaU3cwSkI5UkVOZlU4VHYvQTdQ?=
 =?utf-8?B?MW9oaCtnMzVxY0phVW1LdmM0aFdIYldneE9YTytSYzBSL1pNMFpVSklFNGZP?=
 =?utf-8?B?b09LMjV6dCs2WjFEOFdpOEJFakwyTThNeVRLRTRvOGpWWDJ1KzZUbkpsb0JX?=
 =?utf-8?B?b0VGRDAwSTE2WENxS1JYaXlZVUFtMWpRdmNqNWZDQVhLL1JpTGFmeENOVmlG?=
 =?utf-8?B?aGhlZFRBOXRHd2tMYkgxQzQ1SjR5MmZxUFRVUEc3b1VRNWpWVnltVWFvQVcx?=
 =?utf-8?B?WWw0ZW1nZHN0ZGVuY0tocnJEYUhuRi8zaFpRWjVrSDNZWHpQNjYxWThIMFBj?=
 =?utf-8?B?UnVpR2UzUGRMYXhJcitlaGZ0WWl4Z2xNODNjVGJrVG1hL00rMitON0s5MnZ3?=
 =?utf-8?B?QldpRkRoV2hRMmZzQ0lOaFZvUWRYVHZyZmRBYmFYcDNPMmxSQk1rTUdHTGFD?=
 =?utf-8?B?WnFVSVZtdnd4WWk3Tm5mMlJ2ek53PT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <FD0F3C40F175124595C5E07831D16E62@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5aa15e95-3313-4f0a-2b83-08d9e7233f40
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Feb 2022 14:41:21.9583
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: /fxyTurIeKxk6gLF+J5PA1vsfqITBpF3za8IbFhYyAdddPQ/564tZfhs8uGK8oaHqXmVHkY77hhMP+T67KSXhlwAOnDetalN4jQzXE0RUUw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR03MB3031
X-OriginatorOrg: citrix.com

T24gMDMvMDIvMjAyMiAxNDoxOSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDAzLjAyLjIwMjIg
MTU6MTEsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBPbiAwMy8wMi8yMDIyIDEzOjQ4LCBKdWxp
ZW4gR3JhbGwgd3JvdGU6DQo+Pj4gT24gMDMvMDIvMjAyMiAxMzozOCwgQW5kcmV3IENvb3BlciB3
cm90ZToNCj4+Pj4gZGlmZiAtLWdpdCBhL3hlbi9pbmNsdWRlL3hlbi9zY2hlZC5oIGIveGVuL2lu
Y2x1ZGUveGVuL3NjaGVkLmgNCj4+Pj4gaW5kZXggMzdmNzhjYzRjNGM5Li4zOGIzOTBkMjAzNzEg
MTAwNjQ0DQo+Pj4+IC0tLSBhL3hlbi9pbmNsdWRlL3hlbi9zY2hlZC5oDQo+Pj4+ICsrKyBiL3hl
bi9pbmNsdWRlL3hlbi9zY2hlZC5oDQo+Pj4+IEBAIC03MzYsMTAgKzczNiwxNSBAQCB2b2lkIHZj
cHVfZW5kX3NodXRkb3duX2RlZmVycmFsKHN0cnVjdCB2Y3B1ICp2KTsNCj4+Pj4gwqDCoCAqIGZy
b20gYW55IHByb2Nlc3Nvci4NCj4+Pj4gwqDCoCAqLw0KPj4+PiDCoCB2b2lkIF9fZG9tYWluX2Ny
YXNoKHN0cnVjdCBkb21haW4gKmQpOw0KPj4+PiAtI2RlZmluZSBkb21haW5fY3Jhc2goZCkgZG8N
Cj4+Pj4ge8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBcDQo+Pj4+IC3CoMKgwqAg
cHJpbnRrKCJkb21haW5fY3Jhc2ggY2FsbGVkIGZyb20gJXM6JWRcbiIsIF9fRklMRV9fLA0KPj4+
PiBfX0xJTkVfXyk7wqDCoMKgwqDCoMKgIFwNCj4+Pj4gLcKgwqDCoA0KPj4+PiBfX2RvbWFpbl9j
cmFzaChkKTvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgXA0K
Pj4+PiAtfSB3aGlsZSAoMCkNCj4+Pj4gKyNkZWZpbmUgZG9tYWluX2NyYXNoKGQsIC4uLinCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgXA0KPj4+
PiArwqDCoMKgIGRvIHvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIFwNCj4+
Pj4gK8KgwqDCoMKgwqDCoMKgIGlmICggY291bnRfYXJncyhfX1ZBX0FSR1NfXykgPT0gMCApwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgIFwNCj4+Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcHJp
bnRrKCJkb21haW5fY3Jhc2ggY2FsbGVkIGZyb20gJXM6JWRcbiIswqAgXA0KPj4+PiArwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIF9fRklMRV9fLCBfX0xJTkVfXyk7wqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgXA0KPj4+IEkgZmluZCBhIGJpdCBvZGQgdGhhdCBo
ZXJlIHlvdSBhcmUgdXNpbmcgYSBub3JtYWwgcHJpbnRrDQo+PiBUaGF0J3MgdW5tb2RpZmllZCBm
cm9tIGJlZm9yZS7CoCBPbmx5IHJlZm9ybWF0dGVkLg0KPj4NCj4+PiBidXQuLi4NCj4+Pg0KPj4+
DQo+Pj4+ICvCoMKgwqDCoMKgwqDCoCBlbHNlwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAg
XA0KPj4+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBwcmludGsoWEVOTE9HX0dfRVJSIF9fVkFf
QVJHU19fKTvCoMKgwqDCoMKgwqDCoMKgwqDCoCBcDQo+Pj4gaGVyZSBpdCBpcyBYRU5MT0dfR19F
UlIuIEluIGZhY3QsIGlzbid0IGl0IHJhdGVsaW1pdGVkPyBJZiBzbywNCj4+PiB3b3VsZG4ndCBp
dCBiZSBiZXR0ZXIgdG8gb25seSB1c2UgWEVOTE9HX0VSUiBzbyB0aGV5IGNhbiBhbHdheXMgYmUN
Cj4+PiBzZWVuPyAoQSBkb21haW4gc2hvdWxkbid0IGJlIGFibGUgdG8gYWJ1c2UgaXQpLg0KPj4g
UGVyaGFwcy7CoCBJIHN1cHBvc2UgaXQgaXMgbW9yZSBpbXBvcnRhbnQgaW5mb3JtYXRpb24gdGhh
biBwcmV0dHkgbXVjaA0KPj4gYW55dGhpbmcgZWxzZSBhYm91dCB0aGUgZ3Vlc3QuDQo+IEluZGVl
ZCwgYnV0IHRoZW4gLSBpcyB0aGlzIHJlYWxseSBhbiBlcnJvciBpbiBhbGwgY2FzZXM/DQoNClll
cy7CoCBJdCBpcyBhbHdheXMgYSBmYXRhbCBldmVudCBmb3IgdGhlIFZNLg0KDQo+IFRoZSBwcmlv
cg0KPiBwcmludGsoKSBzaW1wbHkgZW5kZWQgdXAgZGVmYXVsdGluZyB0byBhIHdhcm5pbmcsIGFu
ZCBJIHdvdWxkIHRoaW5rDQo+IHRoYXQncyB3aGF0IHRoZSBuZXcgb25lIHNob3VsZCBiZSBkb2lu
ZyB0b28uDQoNCldBUk5JTkcgaXNuJ3QgZXhhY3RseSBjb3JyZWN0IGZvciBhIGZhdGFsIGV2ZW50
Lg0KDQpJZGVhbGx5LCB3ZSB3YW50IGEgbm9uLXJhdGVsaW1pdGVkIEdfRVJSLCBidXQgdGhhdCBk
b2Vzbid0IGV4aXN0LsKgIElmIGl0DQphcHBlYXJzIGluIHRoZSBmdXR1cmUsIHdlIGNhbiB1c2Ug
aXQuDQoNClRoZSBzZXQgb2YgcGVvcGxlIHJ1bm5pbmcgd2l0aCBsb2dsdmw9ZXJyb3IgaXMgYWxt
b3N0IGNlcnRhaW5seSBlbXB0eSwNCnNvIGl0IGRvZXNuJ3QgbWF0dGVyLg0KDQp+QW5kcmV3DQo=


From xen-devel-bounces@lists.xenproject.org Thu Feb 03 15:07:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 03 Feb 2022 15:07:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264894.458167 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFdhY-0002W3-Ar; Thu, 03 Feb 2022 15:07:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264894.458167; Thu, 03 Feb 2022 15:07:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFdhY-0002Vw-68; Thu, 03 Feb 2022 15:07:12 +0000
Received: by outflank-mailman (input) for mailman id 264894;
 Thu, 03 Feb 2022 15:07:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=OTfZ=SS=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nFdhW-0002Vq-GP
 for xen-devel@lists.xenproject.org; Thu, 03 Feb 2022 15:07:10 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f445bd1a-8502-11ec-8f75-fffcc8bd4f1a;
 Thu, 03 Feb 2022 16:07:08 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2170.outbound.protection.outlook.com [104.47.17.170]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-41-041bxVe1NdC9uQXjuxxBsw-1; Thu, 03 Feb 2022 16:07:05 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM0PR04MB5073.eurprd04.prod.outlook.com (2603:10a6:208:c9::26)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Thu, 3 Feb
 2022 15:07:04 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.012; Thu, 3 Feb 2022
 15:07:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f445bd1a-8502-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1643900827;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=s3C/ypgbkuE8mfh9iBTm6hEUNLA4imWQI74JH9UEfYY=;
	b=ddDAhu4DcSb3BdnSoO4SC5u9IOr5d8IIzNatS+YkA+vpE05z1g3iXRhOQheMz1F1872JL6
	2JXHwJ7HFDDhT742yxUa4Bsd4howNU6P3gpopbqo4ElPd+Mr2r/wY2qA1jsmfP65YzWCEP
	r2LlTzG+CWXV+xfZZQEX3DzvGZp8e+c=
X-MC-Unique: 041bxVe1NdC9uQXjuxxBsw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=oP0jizxOElE1U9WSjjpR3t98t+XQrd5ulTs4mudeGb28xXyA5H5rigw+FMvSBwEqGiUbktqMENQpuDv0gob/ojfQGIIwZ1+P5hsazrTzGChF3UpcZBKB6s5+JYfbYkpEXA/eCDokOhhGk+xOhKVVajOL1MmPcSCBrfjk0bzt0IAwtXUKKQG4sm/uUUY/XuBjvnYuV0FdawwGwfckNpAXkHgkAhyI9zN+Zt3x6pdGkwftyiXl9HbLfiBPBcgynLYlqyRUyyXSw3BwCx+zlY3W+poOMXUwxo6S+nPg9hFZ9Yxfy/qFPwChILlR8KwSkzoC+swEUbkTRX7DBS6DsEL/9Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Js3txiK8y2wuTcENUZZgLbSeBUUXCipYNEd2R8WFlyQ=;
 b=Mf6qS7vlTX0AFye+EID00BBNstmwXQfSeNKFvCCLFoPBvWfuzsRj8gO2EI83ab9AB819ia3igotb3wRjnfeIgHExB+x9KpIBhfIrtCjSwHLXbjGC6/Ma73Aqyv//mC7zMlQm4ckq8q5o+qStcPB36M2pQDhUadJxBsggFU/wU5t4lEgrv/XrZUCumAjIG+cY2hO311a4ecoQrJsu1eKPkPBZIXE48GU8tSfYLcpoQ098raodq/CpHZIIX0FSNpJ5HEduJlZVCOQaCVZWe4LBi27J9z3P9ojv4D+UxJEQfQS66s+WJM01PFngEUfrHc1B/MIzfhoS+FWoOo7v7DLPIQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <c20b2017-7313-41bd-c854-48029a5df206@suse.com>
Date: Thu, 3 Feb 2022 16:06:59 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH] xen: Modify domain_crash() to take a print string
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
CC: Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Xen-devel <xen-devel@lists.xenproject.org>, Julien Grall <julien@xen.org>
References: <20220203133829.7913-1-andrew.cooper3@citrix.com>
 <c0d82900-64d1-fe16-9283-deb7c324ff8a@xen.org>
 <ad7467d2-1cae-c8ea-1217-69f0924044d4@citrix.com>
 <348f062c-9aed-0275-f0ad-87a0eff8e986@suse.com>
 <8a28b63b-a5f6-db0f-3108-646475912abd@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <8a28b63b-a5f6-db0f-3108-646475912abd@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6P193CA0143.EURP193.PROD.OUTLOOK.COM
 (2603:10a6:209:85::48) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: de1a4178-a968-4de2-ad4c-08d9e726d60f
X-MS-TrafficTypeDiagnostic: AM0PR04MB5073:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB507397FADBBB6DEA146FFF63B3289@AM0PR04MB5073.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4502;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	UbhleyEENs/1syOyXtM57E/o+Ma11gnhpD0qSiyF6LKXeiAnQ1TKQHx4Jw4ju4yCIll+Rrg2uEQkoR9KHdD94M7xHjR5H6GnA6sOo5n5wo9hmISY1Z47IQ2v5nIrcY8QW5uhXA4Rh+/I7g8s293/geh8ISN9JhsEbobqW3HysJGMhlH7caBpJE+1Adau9GXC226z/Wh1XhOQjpOfq3LnNg3YVo3PC3hp6/SCkgEEje9H7ALwTKxoq6DGatJSjEd+GFxLMjDlOKBAm1PsZDv2NIJIk65s5BR20WXSu5BFG7z43dLxU09UDyvkS66EjkZgesPw7eUmmgDHpri3I7IZ6+sfyi7y8yaldCDIR5wEscxmU+qPFp8pAm6fuW+tnk7osGdyb9R0MWrZcaf5dpRXTSymU6HeGmETTyNAsXnzVQ81JtT1MZxT9LXXrTxr9r+zK1ma+LhQBfFOsU1+UfBsAxsvEaIuTD5ToWmnyJv/KZZHLe+U94CYGZ8ma+lZrC5B45H0nDYj/yMY7rCtu9e2HSHUOHiPIcucjDnUybl+TcWYc7VC1eWDMkzecn8F46NuPWZBStbS0j9UQ/oIdtrICvoDg2MHoqLZzKfHuuuuFoUuGZENS2lI4RCSTrBF+ABDKm1I8Kv+ZXOmdbctMdsMyYd+1O6n2/a4J1VYSMe7vesGledteNFhWVr/yfqdc1T/tASy2I9wGngUgGCn9ctulr4er+R1nIWJ22bo/DoiArM=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6916009)(31696002)(36756003)(86362001)(6506007)(6512007)(6666004)(53546011)(31686004)(66946007)(66556008)(2616005)(186003)(26005)(38100700002)(83380400001)(4326008)(8676002)(54906003)(6486002)(5660300002)(66476007)(508600001)(8936002)(2906002)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?UqPK6+Q5iyfoOHWizeaJlM1JoRpBBnXTy/3ehuSmnpLH24tNImgud/4LpVX7?=
 =?us-ascii?Q?UmdcmwtxYAWTqu6C12AEnu25SPJDMXH5fOcefQZBEIeT4SGmRJOasH4BqgAN?=
 =?us-ascii?Q?C1KUru5DuqFpThC3OGj/cagITFzQaw1qabc6etC/ctgn944oel3z71uclhkN?=
 =?us-ascii?Q?1YFwQukKHp1BB9BUP4TiD5vRQgCqN5hFBav12zfQvRKL5uO88TD/ByIvw5Z/?=
 =?us-ascii?Q?Y8KYtG20SmyFnGZCA4mfizs26uVsrwstWi71d9Oo+RL8/XuQ8mh7GXAGgoqh?=
 =?us-ascii?Q?blWDMQZ6lLW3AXMNnSqHp8i0p8aerlGD7hMaY+y7x8sScNpDFnIuTdl+6B2i?=
 =?us-ascii?Q?dyFhJtMTT9WnrhWqbm6fCLBOdbiJmZphZFXa8LRjaIklKzWIhZS+UNmgHWU4?=
 =?us-ascii?Q?JXUETqupeFcIyvaQ9+3uCFeP8Dp5Z9uhVvft0kLUWaMNRLKprYD5pJlrL2Gf?=
 =?us-ascii?Q?X+ypbTNJjO/gb39P5LAnflNOxQqOEykK4pX+wvpIPoPL4C8IL1ddB5zI/1Bk?=
 =?us-ascii?Q?APjn3iH3UK6tU81QIsJwc2Lp3uSk3WrJs807tH7DWnX5MobW8mM40mOMi501?=
 =?us-ascii?Q?xEK8LlK9W8s0pQlPpA3lazQRPJ19rhuabTvh3aSUhBUN3QtaQ0s1bCio+Ze5?=
 =?us-ascii?Q?BHifgfpD5ca8zkPqNgCVrszaC+LtIDswlSxIt7smQGTTkQRq7g4TOeDzo7h9?=
 =?us-ascii?Q?fxCVOH7csBTF/U6UzfXPMCt5pxBeLHKtCbbhBcqV/R+IhJKAbPMACD28E+ej?=
 =?us-ascii?Q?OmHBqfaB5B3ACq124EeYXPzQCm3y0MF5sdj34VPN0XYMsM3YIRVmf0/i10X2?=
 =?us-ascii?Q?IqQGBOLFMD/YCWyashpVoboRbOee8VgTzPWnnQOQiw2PK/0JMca5LDMf9jnH?=
 =?us-ascii?Q?08hVFVW0Bd8++FiNjxd+pkUYxpAOK6AxlX2hDoSOENaFwVDImOoQyI735Ddi?=
 =?us-ascii?Q?uwOdQQJ6GN+oIvGuZaM/VgCLGw0RTlLvYPRCoLZm9cmOiEyMoFvsKdEhaMAZ?=
 =?us-ascii?Q?TZXYTRfXvHJw9bU6D5IL8Ga3vOC4JfnrfdLPiX0xS1kJohUOmDEknSXLHQU6?=
 =?us-ascii?Q?667QFR3/A19A9Jtah6oDVkEbhg1hX9O7sr/Emzt5xKSGPCGoH8aq4vQXIXK6?=
 =?us-ascii?Q?QtUXTU2V9XL/w/ADZArsbNhD2UoVZ0ps6dh8CrtPN1jj0W1IbP9z7A+qZyYf?=
 =?us-ascii?Q?B92pdB6WON3bWlJ56+BddaR4GXfLl8zDo2LDiY+qZhn+w6WlxpOdFPlIviPk?=
 =?us-ascii?Q?mT83biHV3I4zbJXZl1lYvUjdriU9HpCVETkhb2EDg2zlu/E23PTebkCKYVkG?=
 =?us-ascii?Q?RYq9YDQhTTYFACRV8r1gMs+Zb2wF1dDhkb48JJZHCW99TNzRxv7R3J2PyaoE?=
 =?us-ascii?Q?Nfq8j63Sc2afeoZj3e0vcn3Y1Y6MK/3GpHKEBZMsH/BUK9ZvjLWhbmlLQ52l?=
 =?us-ascii?Q?Bnve3swVxmmyO4hJMAbBDfkdyxM1Pdnf1iC306WJqsILMtJBiG7qemg/skv3?=
 =?us-ascii?Q?T8Nk1oZU/jG0e3TZ9qrADIxel+BB09lgxZY0hQbFd95lkUYbvYqSzGiHhGhl?=
 =?us-ascii?Q?+G/fF0WtDVJn98dllWtx6wQ4tm8OwNmzt1wAkRIEi/CvqPr5DqsBfqIFkWc3?=
 =?us-ascii?Q?vLsVekY/R1ATlzB87J01haQ=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: de1a4178-a968-4de2-ad4c-08d9e726d60f
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Feb 2022 15:07:03.8417
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: u1cwqwyy8Q7lwOJpMcXFACfq3aCkN23ClbC6iWLbOnJB7jvQmP4j8EvWUHU1gWCXzhEqfXODxmjUO761T5pb8w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5073

On 03.02.2022 15:41, Andrew Cooper wrote:
> On 03/02/2022 14:19, Jan Beulich wrote:
>> On 03.02.2022 15:11, Andrew Cooper wrote:
>>> On 03/02/2022 13:48, Julien Grall wrote:
>>>> On 03/02/2022 13:38, Andrew Cooper wrote:
>>>>> diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
>>>>> index 37f78cc4c4c9..38b390d20371 100644
>>>>> --- a/xen/include/xen/sched.h
>>>>> +++ b/xen/include/xen/sched.h
>>>>> @@ -736,10 +736,15 @@ void vcpu_end_shutdown_deferral(struct vcpu *v)=
;
>>>>> =C2=A0=C2=A0 * from any processor.
>>>>> =C2=A0=C2=A0 */
>>>>> =C2=A0 void __domain_crash(struct domain *d);
>>>>> -#define domain_crash(d) do
>>>>> {=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \
>>>>> -=C2=A0=C2=A0=C2=A0 printk("domain_crash called from %s:%d\n", __FILE=
__,
>>>>> __LINE__);=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \
>>>>> -=C2=A0=C2=A0=C2=A0
>>>>> __domain_crash(d);=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \
>>>>> -} while (0)
>>>>> +#define domain_crash(d, ...)=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \
>>>>> +=C2=A0=C2=A0=C2=A0 do {=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0 \
>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if ( count_args(__VA_ARGS=
__) =3D=3D 0 )=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0 \
>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 p=
rintk("domain_crash called from %s:%d\n",=C2=A0 \
>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 __FILE__, __LINE__);=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0 \
>>>> I find a bit odd that here you are using a normal printk
>>> That's unmodified from before.=C2=A0 Only reformatted.
>>>
>>>> but...
>>>>
>>>>
>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 else=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0 \
>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 p=
rintk(XENLOG_G_ERR __VA_ARGS__);=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0 \
>>>> here it is XENLOG_G_ERR. In fact, isn't it ratelimited? If so,
>>>> wouldn't it be better to only use XENLOG_ERR so they can always be
>>>> seen? (A domain shouldn't be able to abuse it).
>>> Perhaps.=C2=A0 I suppose it is more important information than pretty m=
uch
>>> anything else about the guest.
>> Indeed, but then - is this really an error in all cases?
>=20
> Yes.=C2=A0 It is always a fatal event for the VM.

Which may or may not be Xen's fault. If the guest put itself in a bad
state, I don't see why we shouldn't consider such just a warning. IOW
I continue to think a log level, if so wanted, should be supplied by
the user of the macro.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Feb 03 16:34:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 03 Feb 2022 16:34:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264902.458180 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFf3l-00032N-HX; Thu, 03 Feb 2022 16:34:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264902.458180; Thu, 03 Feb 2022 16:34:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFf3l-00032G-EI; Thu, 03 Feb 2022 16:34:13 +0000
Received: by outflank-mailman (input) for mailman id 264902;
 Thu, 03 Feb 2022 16:34:12 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nFf3k-000326-0q; Thu, 03 Feb 2022 16:34:12 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nFf3j-0001ly-VH; Thu, 03 Feb 2022 16:34:11 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nFf3j-0000tT-H4; Thu, 03 Feb 2022 16:34:11 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nFf3j-0005mV-Ga; Thu, 03 Feb 2022 16:34:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=qNFIgFVJSiCfvLem0f5WkFfrKJdovFID9Z9WUjWIRp4=; b=x1SPDXRyjmGdGMQXZVAgZbt1iy
	kETomhvNpLsSMMFb4w4dobuogU06CzmurpMkJsJ3n93EGqrKjJvp48Fze4HYEFDFr4R8GiDqQbyIt
	EMVK3rud2JkAVwgn6Jii3Xw6cPCNAUe1Iwkm2NXfSQdeKbNdXxS2B+Rz4dUhpe+TDsvk=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167999-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 167999: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=75cc460a1b8cfd8e5d2c4302234ee194defe4872
X-Osstest-Versions-That:
    xen=b17e0ec72eded037297f34a233655aad23f64711
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 03 Feb 2022 16:34:11 +0000

flight 167999 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167999/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  75cc460a1b8cfd8e5d2c4302234ee194defe4872
baseline version:
 xen                  b17e0ec72eded037297f34a233655aad23f64711

Last test of basis   167985  2022-02-02 10:00:30 Z    1 days
Testing same since   167999  2022-02-03 13:01:51 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   b17e0ec72e..75cc460a1b  75cc460a1b8cfd8e5d2c4302234ee194defe4872 -> smoke


From xen-devel-bounces@lists.xenproject.org Thu Feb 03 18:11:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 03 Feb 2022 18:11:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264915.458192 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFgZF-0003wr-Us; Thu, 03 Feb 2022 18:10:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264915.458192; Thu, 03 Feb 2022 18:10:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFgZF-0003wk-RB; Thu, 03 Feb 2022 18:10:49 +0000
Received: by outflank-mailman (input) for mailman id 264915;
 Thu, 03 Feb 2022 18:10:48 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Ap74=SS=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nFgZE-0003we-Hk
 for xen-devel@lists.xenproject.org; Thu, 03 Feb 2022 18:10:48 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9ae54ff9-851c-11ec-8f75-fffcc8bd4f1a;
 Thu, 03 Feb 2022 19:10:46 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9ae54ff9-851c-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1643911846;
  h=from:to:cc:subject:date:message-id:mime-version:
   content-transfer-encoding;
  bh=so4Am0ORuGtCYnjcacxrQ0MqF+d7F1NVZVzTcDC95c8=;
  b=LTbFtNUjitkSalaVKmicwcf0VSSng/UD76LRu6pHcFGybgK82BF44Bqp
   lb2DNLDSCnzbdPy3pJhBRlpbVBQ3djMaBVmKVRkurY7rSm0XgFB1IFbHm
   sK9PnspVQKVzdXqNm8Gjc92zO9JSRlezkRIYugR2gemnLRnVkcsR16zSX
   M=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: 0cJLhdgVgeTWPX0OBNrZBO+1608NV+oplHmRa+wi/qP9ud14YIyywaTWPwAOcvWAelIwLZnXE2
 Xd2v0T8G8Zh55Pdso2Q8IjQPX068wbnh+/kgp0But1JeADBGoxB9RgE13EB1Uxfszfj6w5l5mI
 OfG6iaw3AVaLEu1q+ig3OidsWSrKEfa3auhEx/yYCUECE/OjvLnOaeSwLQXfGafrGqHjZIQTyp
 4/jUVT5UDx+COO7Z0CvQz7CeTd47avSMD2wVD6EKAvrSGH3AvvjY/vNKE0hoCCnpcuI3jyi6qJ
 wFesTIlidN6EVBGtBXiHl06g
X-SBRS: 5.2
X-MesageID: 63439656
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:tWQh4a24BXGfZoB7JvbD5TR2kn2cJEfYwER7XKvMYLTBsI5bp2ECz
 WAdXT2PP/6MYGH1c9pxPIjj8xkH78Lcy9NqHQo9pC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkS5PE3oHJ9RGQ74nRLlbHILOCanAZqTNMEn9700o5w7Vh2OaEvPDia++zk
 YKqyyHgEAfNNw5cagr4PIra9XuDFNyr0N8plgRWicJj5TcypFFMZH4rHomjLmOQf2VhNrXSq
 9Avbl2O1jixEx8FUrtJm1tgG6EAaua60QOm0hK6V0U+6/TrS+NbPqsTbZIhhUlrZzqhx9Z/w
 9FNsLmKRwJyPoD1nbURFD1/HHQrVUFG0OevzXmXtMWSywvNcmf2wuUoB0YzVWEa0r8pWycUr
 6VecW1TKEDY7w616OvTpu1Er8IvNsT0eqgYvWlt12rxBvc6W5HTBa7N4Le02R9u3ZwVTKiDO
 aL1bxJEPB3bch1iHW4VJ5l5lv2likDnfABx/Qf9Sa0fvDGIkV0ZPKLWGPj/d8GORM5Vtl2Fv
 W+A9GP8ajkYO8aY0iGt6W+3i6nEmiaTcJIfEvi0++BnhHWXx3cPE1sGWF2ju/67h0WiHdVFJ
 CQ85S4GvaU0skuxQbHAswaQ+SDe+ERGApwJTrN8uFrlJrfoDxixXm4KRTpBbfkcusptRRET0
 w6F2PfOCmk62FGKck61+rCRpDK0HCEaK24eeCMJJTc4D8nfTJIb1UyWEIs6eEKhppisQGyrn
 WjWxMQrr+hL1aY2O7OHEUcrat5GjrzAVUYL6wreRQpJBSspNdf+N+REBbU2hMuszbp1rHHc5
 BDoeODEtYji6K1hcgTXG43h+5nyv5643MX02wIHInXY323FF4SfVY5R+ipiA0xiL9wJfzTkC
 GeK518KtMQOYib7NvAsC25UNyjM5fK7fTgCfquMBuein7ArLFPXlM2QTRL4M5/RfLgEzvhkZ
 MbznTeEBncGE6V3pAdatM9GuYLHMhsWnDuJLbiilkzP+ePHOBa9FOlZWHPTMLFRxP7U8W39r
 ocEX+PXmko3bQELSnSNmWLlBQpUfSFT6FGfg5E/S9Nv1SI9STx4Vq+Mneh8E2Gn9owM/tr1E
 riGchcw4DLCabfvcG1ms1hvN+HiW4hRt3U+MXB+NFqkwSF7M42u8L0eZ908erx+rL5vyvt9T
 v8kfcScA6sQFmSbqmpFNZSt/pZ/cBmLhB6VO3b3ajYIYJM9FRfC/cXpf1Wz+XBWXDa3r8Y3v
 5apyhjfHcgYXw1nAcuPMKCvwlq9sGIzguV3W0eUcNBfdF+1qNphKjDrj+9xKMYJcE2Ryjyf3
 geQIBEZueiS/NNlrIiX3fiJ9t77HfF/E0xWG3jgwYy3bSSKrHC+xYJgUfqTeWyPXm3D56j/N
 /5eyOvxMaNbkQ8S4ZZ8Cbti0Yk3+8Dr++1B1g1hEXjGMwarB7dnLiXU1MVDrPQQlLpQuA/wU
 UOT4NhKf76OPZq9QlIWIQMkaMWF1O0VxWaOvahkfh2i6X8l5qeDXGVTIwKI2X5UI7ZCOY84x
 fss5ZwN4Aulhxt2atuLg0i4LYhXwqDsh0n/iqwnPQ==
IronPort-HdrOrdr: A9a23:3H3d8qrLIKwxO6Z4e393bNwaV5oleYIsimQD101hICG8cqSj9v
 xG+85rsyMc6QxhP03I9urwW5VoLUmyyXcX2/h0AV7BZniFhILAFugLhuGOrwEIcxeOj9K1vp
 0BT0ERMrPN5CBB/KPH3DU=
X-IronPort-AV: E=Sophos;i="5.88,340,1635220800"; 
   d="scan'208";a="63439656"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>, Anthony PERARD
	<anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>
Subject: [PATCH] tools/guest: Fix comment regarding CPUID compatibility
Date: Thu, 3 Feb 2022 18:10:23 +0000
Message-ID: <20220203181023.1554-1-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

It was Xen 4.14 where CPUID data was added to the migration stream, and 4.13
that we need to worry about with regards to compatibility.  Xen 4.12 isn't
relevant.

Expand and correct the commentary.

Fixes: 111c8c33a8a1 ("x86/cpuid: do not expand max leaves on restore")
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>
CC: Anthony PERARD <anthony.perard@citrix.com>
CC: Juergen Gross <jgross@suse.com>

Roger, this also has a knock-on effect on your CPUID series.  The 4.12 had
been nagging me for a while before I figured out why.
---
 tools/libs/guest/xg_cpuid_x86.c | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/tools/libs/guest/xg_cpuid_x86.c b/tools/libs/guest/xg_cpuid_x86.c
index b9e827ce7eb0..57f81eb0a082 100644
--- a/tools/libs/guest/xg_cpuid_x86.c
+++ b/tools/libs/guest/xg_cpuid_x86.c
@@ -497,9 +497,19 @@ int xc_cpuid_apply_policy(xc_interface *xch, uint32_t domid, bool restore,
     if ( restore )
     {
         /*
-         * Account for feature which have been disabled by default since Xen 4.13,
-         * so migrated-in VM's don't risk seeing features disappearing.
+         * Xen 4.14 introduced support to move the guest's CPUID data in the
+         * migration stream.  Previously, the destination side would invent a
+         * policy out of thin air in the hopes that it was ok.
+         *
+         * This restore path is used for incoming VMs with no CPUID data
+         * i.e. originated on Xen 4.13 or earlier.  We must invent a policy
+         * compatible with what Xen 4.13 would have done on the same hardware.
+         *
+         * Specifically:
+         * - Clamp max leaves.
+         * - Re-enable features which have become (possibly) off by default.
          */
+
         p->basic.rdrand = test_bit(X86_FEATURE_RDRAND, host_featureset);
         p->feat.hle = test_bit(X86_FEATURE_HLE, host_featureset);
         p->feat.rtm = test_bit(X86_FEATURE_RTM, host_featureset);
@@ -509,7 +519,6 @@ int xc_cpuid_apply_policy(xc_interface *xch, uint32_t domid, bool restore,
             p->feat.mpx = test_bit(X86_FEATURE_MPX, host_featureset);
         }
 
-        /* Clamp maximum leaves to the ones supported on 4.12. */
         p->basic.max_leaf = min(p->basic.max_leaf, 0xdu);
         p->feat.max_subleaf = 0;
         p->extd.max_leaf = min(p->extd.max_leaf, 0x8000001c);
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Thu Feb 03 19:33:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 03 Feb 2022 19:33:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264922.458203 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFhrP-00039l-1c; Thu, 03 Feb 2022 19:33:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264922.458203; Thu, 03 Feb 2022 19:33:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFhrO-00039e-UV; Thu, 03 Feb 2022 19:33:38 +0000
Received: by outflank-mailman (input) for mailman id 264922;
 Thu, 03 Feb 2022 19:33:37 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nFhrN-00039U-Fq; Thu, 03 Feb 2022 19:33:37 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nFhrN-0004qH-8j; Thu, 03 Feb 2022 19:33:37 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nFhrM-00030I-T0; Thu, 03 Feb 2022 19:33:36 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nFhrM-00078L-Ph; Thu, 03 Feb 2022 19:33:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=fNFJBl5aOjM54CDuEXD8d+lxoR0qSIwiKPgHXC7Y9dc=; b=I+Jy44ocySihrIcNLnv5tUSHO6
	nUolBhuCF420i/DNixcmmSHPH4izll3MVAyOBdlWicmQ55n3114hju/kliR6eF/OH4vJw1nKt/UYF
	GzImIjeNc6db1kvoSdx02v47HNS1ZcRmLCj8HKu7yXVxuD7xxlca94z+NAk5diH0bE8E=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167994-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 167994: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=b17e0ec72eded037297f34a233655aad23f64711
X-Osstest-Versions-That:
    xen=b17e0ec72eded037297f34a233655aad23f64711
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 03 Feb 2022 19:33:36 +0000

flight 167994 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167994/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-armhf-armhf-xl-rtds     18 guest-start/debian.repeat  fail pass in 167990

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167990
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167990
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167990
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167990
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 167990
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 167990
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167990
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167990
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167990
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167990
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167990
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167990
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 xen                  b17e0ec72eded037297f34a233655aad23f64711
baseline version:
 xen                  b17e0ec72eded037297f34a233655aad23f64711

Last test of basis   167994  2022-02-03 08:04:48 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Fri Feb 04 00:09:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 00:09:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264962.458220 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFmAT-00031z-LH; Fri, 04 Feb 2022 00:09:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264962.458220; Fri, 04 Feb 2022 00:09:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFmAT-00031s-IB; Fri, 04 Feb 2022 00:09:37 +0000
Received: by outflank-mailman (input) for mailman id 264962;
 Fri, 04 Feb 2022 00:09:36 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nFmAR-00031i-UI; Fri, 04 Feb 2022 00:09:35 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nFmAR-0001gs-QN; Fri, 04 Feb 2022 00:09:35 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nFmAQ-0000sc-GF; Fri, 04 Feb 2022 00:09:34 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nFmAQ-0006B9-CM; Fri, 04 Feb 2022 00:09:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=JIhHLJ6x8KEZcd2OoKgj4ichOg8zk0b61kvwNzlmku8=; b=ik/E9yyjpODtjoqy27incTOhTG
	0AZfLfHzAh9odY1SzvTCrWA78CHNb3+6yYyKesNr+j5kZDeHr/Ztm6k940QCa4dqZ+1CRl5YlC+3v
	P3KG54JShSo9WxnpTc7z6HrwmGum9SCE8ZtT5lTTohy+BHikTwWPkAStA/tSRJShJECQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167993-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 167993: regressions - FAIL
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=88808fbbead481aedb46640a5ace69c58287f56a
X-Osstest-Versions-That:
    linux=27bb0b18c208ecd4c0deda6aad28616d73e4133d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 04 Feb 2022 00:09:34 +0000

flight 167993 linux-linus real [real]
flight 168002 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/167993/
http://logs.test-lab.xenproject.org/osstest/logs/168002/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 167988

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167988
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167988
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167988
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167988
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167988
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167988
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167988
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167988
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                88808fbbead481aedb46640a5ace69c58287f56a
baseline version:
 linux                27bb0b18c208ecd4c0deda6aad28616d73e4133d

Last test of basis   167988  2022-02-02 18:11:17 Z    1 days
Testing same since   167993  2022-02-03 04:34:02 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Chuck Lever <chuck.lever@oracle.com>
  Dai Ngo <dai.ngo@oracle.com>
  Dan Carpenter <dan.carpenter@oracle.com>
  J. Bruce Fields <bfields@redhat.com>
  Jan Kara <jack@suse.cz>
  Linus Torvalds <torvalds@linux-foundation.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

------------------------------------------------------------
commit 88808fbbead481aedb46640a5ace69c58287f56a
Merge: d5084ffbc50c ab451ea952fe
Author: Linus Torvalds <torvalds@linux-foundation.org>
Date:   Wed Feb 2 10:14:31 2022 -0800

    Merge tag 'nfsd-5.17-1' of git://git.kernel.org/pub/scm/linux/kernel/git/cel/linux
    
    Pull nfsd fixes from Chuck Lever:
     "Notable bug fixes:
    
       - Ensure SM_NOTIFY doesn't crash the NFS server host
    
       - Ensure NLM locks are cleaned up after client reboot
    
       - Fix a leak of internal NFSv4 lease information"
    
    * tag 'nfsd-5.17-1' of git://git.kernel.org/pub/scm/linux/kernel/git/cel/linux:
      nfsd: nfsd4_setclientid_confirm mistakenly expires confirmed client.
      lockd: fix failure to cleanup client locks
      lockd: fix server crash on reboot of client holding lock

commit d5084ffbc50c76e4a237d87e022e88f6b15b3cb9
Merge: 27bb0b18c208 ee12595147ac
Author: Linus Torvalds <torvalds@linux-foundation.org>
Date:   Wed Feb 2 10:08:52 2022 -0800

    Merge tag 'fsnotify_for_v5.17-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs
    
    Pull fanotify fix from Jan Kara:
     "Fix stale file descriptor in copy_event_to_user"
    
    * tag 'fsnotify_for_v5.17-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs:
      fanotify: Fix stale file descriptor in copy_event_to_user()

commit ee12595147ac1fbfb5bcb23837e26dd58d94b15d
Author: Dan Carpenter <dan.carpenter@oracle.com>
Date:   Fri Jan 28 22:57:01 2022 +0300

    fanotify: Fix stale file descriptor in copy_event_to_user()
    
    This code calls fd_install() which gives the userspace access to the fd.
    Then if copy_info_records_to_user() fails it calls put_unused_fd(fd) but
    that will not release it and leads to a stale entry in the file
    descriptor table.
    
    Generally you can't trust the fd after a call to fd_install().  The fix
    is to delay the fd_install() until everything else has succeeded.
    
    Fortunately it requires CAP_SYS_ADMIN to reach this code so the security
    impact is less.
    
    Fixes: f644bc449b37 ("fanotify: fix copy_event_to_user() fid error clean up")
    Link: https://lore.kernel.org/r/20220128195656.GA26981@kili
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Reviewed-by: Mathias Krause <minipli@grsecurity.net>
    Signed-off-by: Jan Kara <jack@suse.cz>

commit ab451ea952fe9d7afefae55ddb28943a148247fe
Author: Dai Ngo <dai.ngo@oracle.com>
Date:   Wed Jan 26 13:13:38 2022 -0800

    nfsd: nfsd4_setclientid_confirm mistakenly expires confirmed client.
    
    From RFC 7530 Section 16.34.5:
    
    o  The server has not recorded an unconfirmed { v, x, c, *, * } and
       has recorded a confirmed { v, x, c, *, s }.  If the principals of
       the record and of SETCLIENTID_CONFIRM do not match, the server
       returns NFS4ERR_CLID_INUSE without removing any relevant leased
       client state, and without changing recorded callback and
       callback_ident values for client { x }.
    
    The current code intends to do what the spec describes above but
    it forgot to set 'old' to NULL resulting to the confirmed client
    to be expired.
    
    Fixes: 2b63482185e6 ("nfsd: fix clid_inuse on mount with security change")
    Signed-off-by: Dai Ngo <dai.ngo@oracle.com>
    Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
    Reviewed-by: Bruce Fields <bfields@fieldses.org>

commit d19a7af73b5ecaac8168712d18be72b9db166768
Author: J. Bruce Fields <bfields@redhat.com>
Date:   Tue Jan 18 17:00:51 2022 -0500

    lockd: fix failure to cleanup client locks
    
    In my testing, we're sometimes hitting the request->fl_flags & FL_EXISTS
    case in posix_lock_inode, presumably just by random luck since we're not
    actually initializing fl_flags here.
    
    This probably didn't matter before commit 7f024fcd5c97 ("Keep read and
    write fds with each nlm_file") since we wouldn't previously unlock
    unless we knew there were locks.
    
    But now it causes lockd to give up on removing more locks.
    
    We could just initialize fl_flags, but really it seems dubious to be
    calling vfs_lock_file with random values in some of the fields.
    
    Fixes: 7f024fcd5c97 ("Keep read and write fds with each nlm_file")
    Signed-off-by: J. Bruce Fields <bfields@redhat.com>
    [ cel: fixed checkpatch.pl nit ]
    Signed-off-by: Chuck Lever <chuck.lever@oracle.com>

commit 6e7f90d163afa8fc2efd6ae318e7c20156a5621f
Author: J. Bruce Fields <bfields@redhat.com>
Date:   Tue Jan 18 17:00:16 2022 -0500

    lockd: fix server crash on reboot of client holding lock
    
    I thought I was iterating over the array when actually the iteration is
    over the values contained in the array?
    
    Ugh, keep it simple.
    
    Symptoms were a null deference in vfs_lock_file() when an NFSv3 client
    that previously held a lock came back up and sent a notify.
    
    Reported-by: Jonathan Woithe <jwoithe@just42.net>
    Fixes: 7f024fcd5c97 ("Keep read and write fds with each nlm_file")
    Signed-off-by: J. Bruce Fields <bfields@redhat.com>
    Signed-off-by: Chuck Lever <chuck.lever@oracle.com>


From xen-devel-bounces@lists.xenproject.org Fri Feb 04 03:09:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 03:09:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264976.458231 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFoyc-0004qu-Nm; Fri, 04 Feb 2022 03:09:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264976.458231; Fri, 04 Feb 2022 03:09:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFoyc-0004qn-Hg; Fri, 04 Feb 2022 03:09:34 +0000
Received: by outflank-mailman (input) for mailman id 264976;
 Fri, 04 Feb 2022 03:09:33 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nFoyb-0004qd-L2; Fri, 04 Feb 2022 03:09:33 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nFoyb-0006eO-Fz; Fri, 04 Feb 2022 03:09:33 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nFoyb-0001Ob-0h; Fri, 04 Feb 2022 03:09:33 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nFoya-0002n8-UO; Fri, 04 Feb 2022 03:09:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=51SJydXFnb8WfSZMIDhMHR9o2kx9CrAmDh4U70yUB8s=; b=2W5EvJ7Ijrxfq8zPumskhh/9Qa
	dV7k15oRXpOKX98SIUkB/sczkqfaHBRf2NL6oU0WQ2TF/gFraAZqcM+oUj6yctXFbYESfTMXFvc8C
	qRlBdATXYUI/i5jwRDddHov/P92bfusVBtuC86XtbVmX8Kx2DtW3JSrZZRN/k67qwjt4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167996-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.15-testing test] 167996: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=3a9450fe5eb0fda8b7069f37d21ce2655bb59da6
X-Osstest-Versions-That:
    xen=32dcef072fb37d432fd45c7916383472f3fcbc5e
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 04 Feb 2022 03:09:32 +0000

flight 167996 xen-4.15-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167996/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail blocked in 167965
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167965
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167965
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167965
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167965
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167965
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167965
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167965
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167965
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 167965
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167965
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 167965
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  3a9450fe5eb0fda8b7069f37d21ce2655bb59da6
baseline version:
 xen                  32dcef072fb37d432fd45c7916383472f3fcbc5e

Last test of basis   167965  2022-01-31 10:06:48 Z    3 days
Testing same since   167996  2022-02-03 12:39:16 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Anthony PERARD <anthony.perard@citrix.com>
  Jan Beulich <jbeulich@suse.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   32dcef072f..3a9450fe5e  3a9450fe5eb0fda8b7069f37d21ce2655bb59da6 -> stable-4.15


From xen-devel-bounces@lists.xenproject.org Fri Feb 04 05:06:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 05:06:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.264990.458246 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFqnK-00083h-Ht; Fri, 04 Feb 2022 05:06:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 264990.458246; Fri, 04 Feb 2022 05:06:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFqnK-00083a-ED; Fri, 04 Feb 2022 05:06:02 +0000
Received: by outflank-mailman (input) for mailman id 264990;
 Fri, 04 Feb 2022 05:06:01 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nFqnJ-00083Q-D7; Fri, 04 Feb 2022 05:06:01 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nFqnJ-0000by-9v; Fri, 04 Feb 2022 05:06:01 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nFqnI-0007IW-UF; Fri, 04 Feb 2022 05:06:01 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nFqnI-0003NE-TC; Fri, 04 Feb 2022 05:06:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=DyUklEkSublphG7bF69FwMYh99qAWpdM3Q+rgixp5jc=; b=pjtiQbaHkx//9fxEPPre5QkLlE
	b1BtEAwEd09FJ+oI43S/e7kkWv8N/tvhV7iWIgvqYGcS8KsZJft+9NESf1LWRBw1gmuGR6JvApyG1
	lKo6pY1jefsH3sQMJoGU1MJqXkcDOkjm/+SZsIh1tMCEFyha0KmmkvOSkBrF4Z3KlM+Y=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167997-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.16-testing test] 167997: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-4.16-testing:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-4.16-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=0b7aba57b310cfc41287a88c4f9198739706dd71
X-Osstest-Versions-That:
    xen=8abb345e6b5c11b79d1a032533130ea6c5519435
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 04 Feb 2022 05:06:00 +0000

flight 167997 xen-4.16-testing real [real]
flight 168005 xen-4.16-testing real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/167997/
http://logs.test-lab.xenproject.org/osstest/logs/168005/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 168005-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167894
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167894
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167894
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167894
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167894
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167894
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167894
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167894
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167894
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 167894
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167894
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 167894
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  0b7aba57b310cfc41287a88c4f9198739706dd71
baseline version:
 xen                  8abb345e6b5c11b79d1a032533130ea6c5519435

Last test of basis   167894  2022-01-26 17:11:33 Z    8 days
Testing same since   167997  2022-02-03 12:39:17 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Anthony PERARD <anthony.perard@citrix.com>
  Jan Beulich <jbeulich@suse.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   8abb345e6b..0b7aba57b3  0b7aba57b310cfc41287a88c4f9198739706dd71 -> stable-4.16


From xen-devel-bounces@lists.xenproject.org Fri Feb 04 06:35:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 06:35:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265008.458315 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFsBa-00012P-8C; Fri, 04 Feb 2022 06:35:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265008.458315; Fri, 04 Feb 2022 06:35:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFsBa-00011Y-2T; Fri, 04 Feb 2022 06:35:10 +0000
Received: by outflank-mailman (input) for mailman id 265008;
 Fri, 04 Feb 2022 06:35:08 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Tguk=ST=gmail.com=andr2000@srs-se1.protection.inumbo.net>)
 id 1nFsBY-0008DX-5I
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 06:35:08 +0000
Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com
 [2a00:1450:4864:20::229])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 97f177f4-8584-11ec-8eb8-a37418f5ba1a;
 Fri, 04 Feb 2022 07:35:07 +0100 (CET)
Received: by mail-lj1-x229.google.com with SMTP id e17so7167528ljk.5
 for <xen-devel@lists.xenproject.org>; Thu, 03 Feb 2022 22:35:07 -0800 (PST)
Received: from a2klaptop.localdomain ([185.199.97.5])
 by smtp.gmail.com with ESMTPSA id f34sm163027lfv.165.2022.02.03.22.35.05
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 03 Feb 2022 22:35:06 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 97f177f4-8584-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=7XW5WI2LKa0+lHLha6LOvz3mRlOFJHaJBN6i9Y4p6WM=;
        b=dhahBLefv3vqpJIzC/B6ePyfjpDpPIn86QOziEMIKUWSkc+w0iRCBKAJ6dWQdHnocH
         QKOJqMlHxXYEJ/mxNf/0sVdGb0tW7CAtp4i/oNw6u8Rr28oCjpPNVgP2WCz+nWhJ7Te2
         NmdZfvJ/QtVeUxx23tOWOcEfvFweXLQw30iJt2sTikUH2ss2SUxGXONdjtD4BZXJ3M4t
         8j9yN+t5sFF12wbD0Py19VVpXMQwX0RRhg1kPw1G920+tqgtQbA6ZwwwLvDzdKYNVuUX
         T9nVM7QqK4HsM2wb+uvctYF4gge17KSZ1x0oWs9vA1VcrKsTHR3njYi1Z6r9ZhL+bAxe
         MXSQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=7XW5WI2LKa0+lHLha6LOvz3mRlOFJHaJBN6i9Y4p6WM=;
        b=x2Lrz3Tw9xnAOdSbSY+DdcvxEiF6oicZXECNegNKX67ZDMUeVME41VlwXtPdc/fK7M
         nhKfYsJ8hl8g1mduv3TvI5VFF1Gtp0i2rieAhhpglyxG+Yz7wGldB2RWRv/Rr5NqtS4f
         oGd4QQyLqY5iSBM4BF0ZGWTcoeWWDaK8NRTLBLUxeW3MSMM/nK/00yF8BtpaekJ2xxWf
         bQcxgsym+LU3bsUEp6HUrrD0RENM1hFWQ8AWwefWF5bmQkpRdo73BpBzlBFZXKPDvk3O
         0PEGMXRIiGCbDcmjH5VtxCxz5w+IH1xrsc6f9gfM5rwsqapZDVAs6QQxiWeLD/yiXf3W
         yxYA==
X-Gm-Message-State: AOAM533X/WKQqvXQOiVY89c/ogMHJajirMrQ8m/rCXb6JuV/39l/Ze96
	rS51qJ354SHfpT90LLT2Ps+m9LuwN2I=
X-Google-Smtp-Source: ABdhPJx32wzZ5nqhjR3pnLXjGJB/ispCD26olf2AkIY8XmREw8kF2eQaqvbwXb6rvKqnjeQ7HQ+hKQ==
X-Received: by 2002:a2e:a289:: with SMTP id k9mr907186lja.464.1643956506750;
        Thu, 03 Feb 2022 22:35:06 -0800 (PST)
From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	sstabellini@kernel.org,
	oleksandr_tyshchenko@epam.com,
	volodymyr_babchuk@epam.com,
	artem_mygaiev@epam.com,
	roger.pau@citrix.com,
	jbeulich@suse.com,
	andrew.cooper3@citrix.com,
	george.dunlap@citrix.com,
	paul@xen.org,
	bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: [PATCH v6 05/13] vpci: add hooks for PCI device assign/de-assign
Date: Fri,  4 Feb 2022 08:34:51 +0200
Message-Id: <20220204063459.680961-6-andr2000@gmail.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220204063459.680961-1-andr2000@gmail.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

When a PCI device gets assigned/de-assigned some work on vPCI side needs
to be done for that device. Introduce a pair of hooks so vPCI can handle
that.

Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
---
Since v5:
- do not split code into run_vpci_init
- do not check for is_system_domain in vpci_{de}assign_device
- do not use vpci_remove_device_handlers_locked and re-allocate
  pdev->vpci completely
- make vpci_deassign_device void
Since v4:
 - de-assign vPCI from the previous domain on device assignment
 - do not remove handlers in vpci_assign_device as those must not
   exist at that point
Since v3:
 - remove toolstack roll-back description from the commit message
   as error are to be handled with proper cleanup in Xen itself
 - remove __must_check
 - remove redundant rc check while assigning devices
 - fix redundant CONFIG_HAS_VPCI check for CONFIG_HAS_VPCI_GUEST_SUPPORT
 - use REGISTER_VPCI_INIT machinery to run required steps on device
   init/assign: add run_vpci_init helper
Since v2:
- define CONFIG_HAS_VPCI_GUEST_SUPPORT so dead code is not compiled
  for x86
Since v1:
 - constify struct pci_dev where possible
 - do not open code is_system_domain()
 - extended the commit message
---
 xen/drivers/Kconfig           |  4 ++++
 xen/drivers/passthrough/pci.c |  6 ++++++
 xen/drivers/vpci/vpci.c       | 27 +++++++++++++++++++++++++++
 xen/include/xen/vpci.h        | 15 +++++++++++++++
 4 files changed, 52 insertions(+)

diff --git a/xen/drivers/Kconfig b/xen/drivers/Kconfig
index db94393f47a6..780490cf8e39 100644
--- a/xen/drivers/Kconfig
+++ b/xen/drivers/Kconfig
@@ -15,4 +15,8 @@ source "drivers/video/Kconfig"
 config HAS_VPCI
 	bool
 
+config HAS_VPCI_GUEST_SUPPORT
+	bool
+	depends on HAS_VPCI
+
 endmenu
diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
index 50dec3bb73d0..88836aab6baf 100644
--- a/xen/drivers/passthrough/pci.c
+++ b/xen/drivers/passthrough/pci.c
@@ -943,6 +943,8 @@ static int deassign_device(struct domain *d, uint16_t seg, uint8_t bus,
     if ( ret )
         goto out;
 
+    vpci_deassign_device(d, pdev);
+
     if ( pdev->domain == hardware_domain  )
         pdev->quarantine = false;
 
@@ -1488,6 +1490,8 @@ static int assign_device(struct domain *d, u16 seg, u8 bus, u8 devfn, u32 flag)
     ASSERT(pdev && (pdev->domain == hardware_domain ||
                     pdev->domain == dom_io));
 
+    vpci_deassign_device(pdev->domain, pdev);
+
     rc = pdev_msix_assign(d, pdev);
     if ( rc )
         goto done;
@@ -1507,6 +1511,8 @@ static int assign_device(struct domain *d, u16 seg, u8 bus, u8 devfn, u32 flag)
                         pci_to_dev(pdev), flag);
     }
 
+    rc = vpci_assign_device(d, pdev);
+
  done:
     if ( rc )
         printk(XENLOG_G_WARNING "%pd: assign (%pp) failed (%d)\n",
diff --git a/xen/drivers/vpci/vpci.c b/xen/drivers/vpci/vpci.c
index f8a93e61c08f..4e774875fa04 100644
--- a/xen/drivers/vpci/vpci.c
+++ b/xen/drivers/vpci/vpci.c
@@ -99,6 +99,33 @@ int vpci_add_handlers(struct pci_dev *pdev)
 
     return rc;
 }
+
+#ifdef CONFIG_HAS_VPCI_GUEST_SUPPORT
+/* Notify vPCI that device is assigned to guest. */
+int vpci_assign_device(struct domain *d, struct pci_dev *pdev)
+{
+    int rc;
+
+    if ( !has_vpci(d) )
+        return 0;
+
+    rc = vpci_add_handlers(pdev);
+    if ( rc )
+        vpci_deassign_device(d, pdev);
+
+    return rc;
+}
+
+/* Notify vPCI that device is de-assigned from guest. */
+void vpci_deassign_device(struct domain *d, struct pci_dev *pdev)
+{
+    if ( !has_vpci(d) )
+        return;
+
+    vpci_remove_device(pdev);
+}
+#endif /* CONFIG_HAS_VPCI_GUEST_SUPPORT */
+
 #endif /* __XEN__ */
 
 static int vpci_register_cmp(const struct vpci_register *r1,
diff --git a/xen/include/xen/vpci.h b/xen/include/xen/vpci.h
index f2a7d82ce77b..246307e6f5d5 100644
--- a/xen/include/xen/vpci.h
+++ b/xen/include/xen/vpci.h
@@ -251,6 +251,21 @@ static inline bool __must_check vpci_process_pending(struct vcpu *v)
 }
 #endif
 
+#ifdef CONFIG_HAS_VPCI_GUEST_SUPPORT
+/* Notify vPCI that device is assigned/de-assigned to/from guest. */
+int vpci_assign_device(struct domain *d, struct pci_dev *pdev);
+void vpci_deassign_device(struct domain *d, struct pci_dev *pdev);
+#else
+static inline int vpci_assign_device(struct domain *d, struct pci_dev *pdev)
+{
+    return 0;
+};
+
+static inline void vpci_deassign_device(struct domain *d, struct pci_dev *pdev)
+{
+};
+#endif
+
 #endif
 
 /*
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Feb 04 06:35:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 06:35:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265005.458274 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFsBX-0008Ql-2D; Fri, 04 Feb 2022 06:35:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265005.458274; Fri, 04 Feb 2022 06:35:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFsBW-0008PB-Si; Fri, 04 Feb 2022 06:35:06 +0000
Received: by outflank-mailman (input) for mailman id 265005;
 Fri, 04 Feb 2022 06:35:05 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Tguk=ST=gmail.com=andr2000@srs-se1.protection.inumbo.net>)
 id 1nFsBV-0008DX-E1
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 06:35:05 +0000
Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com
 [2a00:1450:4864:20::12b])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 95396f71-8584-11ec-8eb8-a37418f5ba1a;
 Fri, 04 Feb 2022 07:35:03 +0100 (CET)
Received: by mail-lf1-x12b.google.com with SMTP id z4so10781282lft.3
 for <xen-devel@lists.xenproject.org>; Thu, 03 Feb 2022 22:35:03 -0800 (PST)
Received: from a2klaptop.localdomain ([185.199.97.5])
 by smtp.gmail.com with ESMTPSA id f34sm163027lfv.165.2022.02.03.22.35.01
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 03 Feb 2022 22:35:01 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 95396f71-8584-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=nEZ0S5ylp2hVxPb59duUWX5SgzLrq0RrV7CsGFnmgls=;
        b=ljHuqvmKZbx3pFGEj/9BQ+VGUO0+7SGsf8IYTF0oPk5K7zJA+Zr6P+5sPWUUM3wNcm
         uFX87jQNZi3n/maFzKdEA/l/k2sUOk4VpkAjR909ZkhY72pxTXP2Fyn9dWwaRJkMBUPl
         eOMzJLCi+HMPk+E6eEuqNzWx1aQ4UEu12T0cOs1IUIiywh3ZkboZbkDy5X62/60XjssH
         yFzcne58IqIbGWH6pXBQlFnMX7cbxGetb8lKBVjz4H39Rg0MYKcbag/jFj4OnVqEtZdV
         jf/JsKtTUOIEixmw3rh/gOqAoJREqDDSbHMwWxPDzYh173+NMq0yFXxf3fbLCROk3AnB
         QbCg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=nEZ0S5ylp2hVxPb59duUWX5SgzLrq0RrV7CsGFnmgls=;
        b=zOtFIaLgqCPJHjfoO6CUfXTuQm1xvwAdEPk9uf0qEU1QUnChXnWNYEmm0p+Cgnv6PA
         AXVwXYlJZEIJbm64tjNafNykRWDmniXtpst7ACOPpPhxZxTjZneCWITRMr7hh0OZuv9t
         sMDADbzkz5/TSWsYAhBYh8FhKssNP+fUDAXteHWFDYUn5PQWx4w7WhaMiwx8LNvExVyZ
         HJ7lrbWOO3/6m65PmYzIPHd4B+de8XGuQZ+UFTE8e+qkZx4hZiGxnJZLJwP4E9fBs6F1
         eC9d6Khd+peZgkGpDY64JnpKA047tNliFly4agCSchw3/vx84Y2hA1zuhVM0LVQYcsRh
         pRrg==
X-Gm-Message-State: AOAM533EpdA17k7ga4xjQ1m2zWQ/bqdSIClwC1kj47yo5HqN/w7bL2Qd
	QYb4C5tOFcdbyhjoQEAZ8MNxuWowOxo=
X-Google-Smtp-Source: ABdhPJyb52ecDgdNTkD06qSr2ws0sAPXn71t/8qeE3T7ubzYIIgJyTlltqbfnCKWdc26bSW7BjWMnQ==
X-Received: by 2002:a05:6512:2354:: with SMTP id p20mr1320036lfu.215.1643956502200;
        Thu, 03 Feb 2022 22:35:02 -0800 (PST)
From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	sstabellini@kernel.org,
	oleksandr_tyshchenko@epam.com,
	volodymyr_babchuk@epam.com,
	artem_mygaiev@epam.com,
	roger.pau@citrix.com,
	jbeulich@suse.com,
	andrew.cooper3@citrix.com,
	george.dunlap@citrix.com,
	paul@xen.org,
	bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: [PATCH v6 01/13] xen/pci: arm: add stub for is_memory_hole
Date: Fri,  4 Feb 2022 08:34:47 +0200
Message-Id: <20220204063459.680961-2-andr2000@gmail.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220204063459.680961-1-andr2000@gmail.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

Add a stub for is_memory_hole which is required for PCI passthrough
on Arm.

Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

---
Cc: Julien Grall <julien@xen.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>
---
New in v6
---
 xen/arch/arm/mm.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
index b1eae767c27c..c32e34a182a2 100644
--- a/xen/arch/arm/mm.c
+++ b/xen/arch/arm/mm.c
@@ -1640,6 +1640,12 @@ unsigned long get_upper_mfn_bound(void)
     return max_page - 1;
 }
 
+bool is_memory_hole(mfn_t start, mfn_t end)
+{
+    /* TODO: this needs to be properly implemented. */
+    return true;
+}
+
 /*
  * Local variables:
  * mode: C
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Feb 04 06:35:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 06:35:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265010.458331 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFsBc-0001QK-42; Fri, 04 Feb 2022 06:35:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265010.458331; Fri, 04 Feb 2022 06:35:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFsBb-0001Ou-RL; Fri, 04 Feb 2022 06:35:11 +0000
Received: by outflank-mailman (input) for mailman id 265010;
 Fri, 04 Feb 2022 06:35:11 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Tguk=ST=gmail.com=andr2000@srs-se1.protection.inumbo.net>)
 id 1nFsBb-0008DX-2o
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 06:35:11 +0000
Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com
 [2a00:1450:4864:20::232])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9970619f-8584-11ec-8eb8-a37418f5ba1a;
 Fri, 04 Feb 2022 07:35:09 +0100 (CET)
Received: by mail-lj1-x232.google.com with SMTP id z7so7175594ljj.4
 for <xen-devel@lists.xenproject.org>; Thu, 03 Feb 2022 22:35:09 -0800 (PST)
Received: from a2klaptop.localdomain ([185.199.97.5])
 by smtp.gmail.com with ESMTPSA id f34sm163027lfv.165.2022.02.03.22.35.08
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 03 Feb 2022 22:35:08 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9970619f-8584-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=7HlIeOQ4u8ilsk2z8tUSqNoEHT6feHwuo6GUwAouwe0=;
        b=oo/4mkgXCUQW6zXw9NSPzAjcrsksdcI9Ua1MMWdkCTeOF0VmcvI6jgT+91VSZcB/5s
         ngyIhz7SfBUdVU8AKh4UpTzi2FPCNgvwUO5EoACJphhff7pxujAQfjOoNmMwoJpj0S3N
         6ArXKPq94WC6EraXQm5nyJ0de5FUUC7WcUfTZWS6bAE5woxuDwk+9YXtLs2j7osr9wld
         /7iq7xMwnNWMVgHbDDYY/wogOqysmDurEkT8A4tbDulCqBPoz2AsPwNZ/YVc07R+iRcp
         N6/cJu/XwfNa/oEIn1TMZrq5AKsVTfChkPngLW257zbFqH7J8RQx9gOkSvSk1d/YtWp7
         oADg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=7HlIeOQ4u8ilsk2z8tUSqNoEHT6feHwuo6GUwAouwe0=;
        b=C9nMWgjV0s74BtURBAzvKj62G/pI6rbO9sVyKaFygLI6OY81CYsrNeyJ0tiobfEHX3
         SXELeHqrdJSw2sBSgjpL9I5hqWhRyH1XRlaSCmjYVOuLGQPIvCUN7H91bZJYjMVShMTM
         LZMt6mfrwgqawaJy7G1p9k6pU+3xSxJN5gDD7hGEVvtrdl1OBJfGTUdTyCTvYgKbtxcm
         aEjE8/dmjpCOZweZFU05d6HIhLXm0nue/ccTjMC4mO911/R3gyKge25eujTTzKN+oVdC
         vTfv6qM4wcskovpEY1UA3cVD/UMaHSbbB7ScGePoLwzLaAHeFmtTZbypF210G+bTNqgf
         bfXg==
X-Gm-Message-State: AOAM533dUgW17lXih5NkeQS9PIQyt6KQIt//R+kXIFtTkslff8uLwQXu
	73XDY/FjZE54UMxZ+P5y9XepolLXZFI=
X-Google-Smtp-Source: ABdhPJwLQpGq15e84eC4Z8AwZC/jlpbvigrsAv/ePIiKVlZiNNo/Jgd85WKzCvwf1eJvYavTpfEPIw==
X-Received: by 2002:a2e:9918:: with SMTP id v24mr919230lji.230.1643956509105;
        Thu, 03 Feb 2022 22:35:09 -0800 (PST)
From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	sstabellini@kernel.org,
	oleksandr_tyshchenko@epam.com,
	volodymyr_babchuk@epam.com,
	artem_mygaiev@epam.com,
	roger.pau@citrix.com,
	jbeulich@suse.com,
	andrew.cooper3@citrix.com,
	george.dunlap@citrix.com,
	paul@xen.org,
	bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: [PATCH v6 07/13] vpci/header: handle p2m range sets per BAR
Date: Fri,  4 Feb 2022 08:34:53 +0200
Message-Id: <20220204063459.680961-8-andr2000@gmail.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220204063459.680961-1-andr2000@gmail.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

Instead of handling a single range set, that contains all the memory
regions of all the BARs and ROM, have them per BAR.
As the range sets are now created when a PCI device is added and destroyed
when it is removed so make them named and accounted.

Note that rangesets were chosen here despite there being only up to
3 separate ranges in each set (typically just 1). But rangeset per BAR
was chosen for the ease of implementation and existing code re-usability.

This is in preparation of making non-identity mappings in p2m for the MMIOs.

Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

---
Since v5:
- fix comments
- move rangeset allocation to init_bars and only allocate
  for MAPPABLE BARs
- check for overlap with the already setup BAR ranges
Since v4:
- use named range sets for BARs (Jan)
- changes required by the new locking scheme
- updated commit message (Jan)
Since v3:
- re-work vpci_cancel_pending accordingly to the per-BAR handling
- s/num_mem_ranges/map_pending and s/uint8_t/bool
- ASSERT(bar->mem) in modify_bars
- create and destroy the rangesets on add/remove
---
 xen/drivers/vpci/header.c | 213 ++++++++++++++++++++++++++++----------
 xen/drivers/vpci/vpci.c   |  17 ++-
 xen/include/xen/vpci.h    |   4 +-
 3 files changed, 177 insertions(+), 57 deletions(-)

diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c
index 2620a95ff35b..0c94504b87d8 100644
--- a/xen/drivers/vpci/header.c
+++ b/xen/drivers/vpci/header.c
@@ -131,50 +131,85 @@ static void modify_decoding(const struct pci_dev *pdev, uint16_t cmd,
 
 bool vpci_process_pending(struct vcpu *v)
 {
-    if ( v->vpci.mem )
+    struct pci_dev *pdev = v->vpci.pdev;
+
+    if ( !pdev )
+        return false;
+
+    spin_lock(&pdev->vpci_lock);
+    if ( v->vpci.map_pending )
     {
         struct map_data data = {
             .d = v->domain,
             .map = v->vpci.cmd & PCI_COMMAND_MEMORY,
         };
-        int rc = rangeset_consume_ranges(v->vpci.mem, map_range, &data);
+        struct vpci_header *header = &pdev->vpci->header;
+        unsigned int i;
+
+        for ( i = 0; i < ARRAY_SIZE(header->bars); i++ )
+        {
+            struct vpci_bar *bar = &header->bars[i];
+            int rc;
+
+            if ( rangeset_is_empty(bar->mem) )
+                continue;
 
-        if ( rc == -ERESTART )
-            return true;
+            rc = rangeset_consume_ranges(bar->mem, map_range, &data);
+
+            if ( rc == -ERESTART )
+            {
+                spin_unlock(&pdev->vpci_lock);
+                return true;
+            }
 
-        spin_lock(&v->vpci.pdev->vpci_lock);
-        if ( v->vpci.pdev->vpci )
             /* Disable memory decoding unconditionally on failure. */
-            modify_decoding(v->vpci.pdev,
-                            rc ? v->vpci.cmd & ~PCI_COMMAND_MEMORY : v->vpci.cmd,
-                            !rc && v->vpci.rom_only);
-        spin_unlock(&v->vpci.pdev->vpci_lock);
+            modify_decoding(pdev, rc ? v->vpci.cmd & ~PCI_COMMAND_MEMORY :
+                                       v->vpci.cmd, !rc && v->vpci.rom_only);
+
+            if ( rc )
+            {
+                /*
+                 * FIXME: in case of failure remove the device from the domain.
+                 * Note that there might still be leftover mappings. While this
+                 * is safe for Dom0, for DomUs the domain needs to be killed in
+                 * order to avoid leaking stale p2m mappings on failure.
+                 */
+                if ( is_hardware_domain(v->domain) )
+                    vpci_remove_device_locked(pdev);
+                else
+                    domain_crash(v->domain);
+
+                break;
+            }
+        }
+
+        v->vpci.map_pending = false;
 
-        rangeset_destroy(v->vpci.mem);
-        v->vpci.mem = NULL;
-        if ( rc )
-            /*
-             * FIXME: in case of failure remove the device from the domain.
-             * Note that there might still be leftover mappings. While this is
-             * safe for Dom0, for DomUs the domain will likely need to be
-             * killed in order to avoid leaking stale p2m mappings on
-             * failure.
-             */
-            vpci_remove_device(v->vpci.pdev);
     }
+    spin_unlock(&pdev->vpci_lock);
 
     return false;
 }
 
 static int __init apply_map(struct domain *d, const struct pci_dev *pdev,
-                            struct rangeset *mem, uint16_t cmd)
+                            uint16_t cmd)
 {
     struct map_data data = { .d = d, .map = true };
-    int rc;
+    struct vpci_header *header = &pdev->vpci->header;
+    int rc = 0;
+    unsigned int i;
+
+    for ( i = 0; i < ARRAY_SIZE(header->bars); i++ )
+    {
+        struct vpci_bar *bar = &header->bars[i];
 
-    while ( (rc = rangeset_consume_ranges(mem, map_range, &data)) == -ERESTART )
-        process_pending_softirqs();
-    rangeset_destroy(mem);
+        if ( rangeset_is_empty(bar->mem) )
+            continue;
+
+        while ( (rc = rangeset_consume_ranges(bar->mem, map_range,
+                                              &data)) == -ERESTART )
+            process_pending_softirqs();
+    }
     if ( !rc )
         modify_decoding(pdev, cmd, false);
 
@@ -182,7 +217,7 @@ static int __init apply_map(struct domain *d, const struct pci_dev *pdev,
 }
 
 static void defer_map(struct domain *d, struct pci_dev *pdev,
-                      struct rangeset *mem, uint16_t cmd, bool rom_only)
+                      uint16_t cmd, bool rom_only)
 {
     struct vcpu *curr = current;
 
@@ -193,7 +228,7 @@ static void defer_map(struct domain *d, struct pci_dev *pdev,
      * started for the same device if the domain is not well-behaved.
      */
     curr->vpci.pdev = pdev;
-    curr->vpci.mem = mem;
+    curr->vpci.map_pending = true;
     curr->vpci.cmd = cmd;
     curr->vpci.rom_only = rom_only;
     /*
@@ -207,42 +242,60 @@ static void defer_map(struct domain *d, struct pci_dev *pdev,
 static int modify_bars(const struct pci_dev *pdev, uint16_t cmd, bool rom_only)
 {
     struct vpci_header *header = &pdev->vpci->header;
-    struct rangeset *mem = rangeset_new(NULL, NULL, 0);
     struct pci_dev *tmp, *dev = NULL;
     const struct vpci_msix *msix = pdev->vpci->msix;
-    unsigned int i;
+    unsigned int i, j;
     int rc;
-
-    if ( !mem )
-        return -ENOMEM;
+    bool map_pending;
 
     /*
-     * Create a rangeset that represents the current device BARs memory region
-     * and compare it against all the currently active BAR memory regions. If
-     * an overlap is found, subtract it from the region to be mapped/unmapped.
+     * Create a rangeset per BAR that represents the current device memory
+     * region and compare it against all the currently active BAR memory
+     * regions. If an overlap is found, subtract it from the region to be
+     * mapped/unmapped.
      *
-     * First fill the rangeset with all the BARs of this device or with the ROM
+     * First fill the rangesets with the BARs of this device or with the ROM
      * BAR only, depending on whether the guest is toggling the memory decode
      * bit of the command register, or the enable bit of the ROM BAR register.
      */
     for ( i = 0; i < ARRAY_SIZE(header->bars); i++ )
     {
-        const struct vpci_bar *bar = &header->bars[i];
+        struct vpci_bar *bar = &header->bars[i];
         unsigned long start = PFN_DOWN(bar->addr);
         unsigned long end = PFN_DOWN(bar->addr + bar->size - 1);
 
+        if ( !bar->mem )
+            continue;
+
         if ( !MAPPABLE_BAR(bar) ||
              (rom_only ? bar->type != VPCI_BAR_ROM
                        : (bar->type == VPCI_BAR_ROM && !header->rom_enabled)) )
             continue;
 
-        rc = rangeset_add_range(mem, start, end);
+        rc = rangeset_add_range(bar->mem, start, end);
         if ( rc )
         {
             printk(XENLOG_G_WARNING "Failed to add [%lx, %lx]: %d\n",
                    start, end, rc);
-            rangeset_destroy(mem);
-            return rc;
+            goto fail;
+        }
+
+        /* Check for overlap with the already setup BAR ranges. */
+        for ( j = 0; j < i; j++ )
+        {
+            struct vpci_bar *bar = &header->bars[j];
+
+            if ( rangeset_is_empty(bar->mem) )
+                continue;
+
+            rc = rangeset_remove_range(bar->mem, start, end);
+            if ( rc )
+            {
+                printk(XENLOG_G_WARNING
+                       "Failed to remove overlapping range [%lx, %lx]: %d\n",
+                       start, end, rc);
+                goto fail;
+            }
         }
     }
 
@@ -253,14 +306,21 @@ static int modify_bars(const struct pci_dev *pdev, uint16_t cmd, bool rom_only)
         unsigned long end = PFN_DOWN(vmsix_table_addr(pdev->vpci, i) +
                                      vmsix_table_size(pdev->vpci, i) - 1);
 
-        rc = rangeset_remove_range(mem, start, end);
-        if ( rc )
+        for ( j = 0; j < ARRAY_SIZE(header->bars); j++ )
         {
-            printk(XENLOG_G_WARNING
-                   "Failed to remove MSIX table [%lx, %lx]: %d\n",
-                   start, end, rc);
-            rangeset_destroy(mem);
-            return rc;
+            const struct vpci_bar *bar = &header->bars[j];
+
+            if ( rangeset_is_empty(bar->mem) )
+                continue;
+
+            rc = rangeset_remove_range(bar->mem, start, end);
+            if ( rc )
+            {
+                printk(XENLOG_G_WARNING
+                       "Failed to remove MSIX table [%lx, %lx]: %d\n",
+                       start, end, rc);
+                goto fail;
+            }
         }
     }
 
@@ -298,7 +358,8 @@ static int modify_bars(const struct pci_dev *pdev, uint16_t cmd, bool rom_only)
             unsigned long start = PFN_DOWN(bar->addr);
             unsigned long end = PFN_DOWN(bar->addr + bar->size - 1);
 
-            if ( !bar->enabled || !rangeset_overlaps_range(mem, start, end) ||
+            if ( !bar->enabled ||
+                 !rangeset_overlaps_range(bar->mem, start, end) ||
                  /*
                   * If only the ROM enable bit is toggled check against other
                   * BARs in the same device for overlaps, but not against the
@@ -307,14 +368,13 @@ static int modify_bars(const struct pci_dev *pdev, uint16_t cmd, bool rom_only)
                  (rom_only && tmp == pdev && bar->type == VPCI_BAR_ROM) )
                 continue;
 
-            rc = rangeset_remove_range(mem, start, end);
+            rc = rangeset_remove_range(bar->mem, start, end);
             if ( rc )
             {
                 spin_unlock(&tmp->vpci_lock);
                 printk(XENLOG_G_WARNING "Failed to remove [%lx, %lx]: %d\n",
                        start, end, rc);
-                rangeset_destroy(mem);
-                return rc;
+                goto fail;
             }
         }
         spin_unlock(&tmp->vpci_lock);
@@ -333,12 +393,28 @@ static int modify_bars(const struct pci_dev *pdev, uint16_t cmd, bool rom_only)
          * will always be to establish mappings and process all the BARs.
          */
         ASSERT((cmd & PCI_COMMAND_MEMORY) && !rom_only);
-        return apply_map(pdev->domain, pdev, mem, cmd);
+        return apply_map(pdev->domain, pdev, cmd);
     }
 
-    defer_map(dev->domain, dev, mem, cmd, rom_only);
+    /* Find out how many memory ranges has left after MSI and overlaps. */
+    map_pending = false;
+    for ( i = 0; i < ARRAY_SIZE(header->bars); i++ )
+        if ( !rangeset_is_empty(header->bars[i].mem) )
+        {
+            map_pending = true;
+            break;
+        }
+
+    /* If there's no mapping work write the command register now. */
+    if ( !map_pending )
+        pci_conf_write16(pdev->sbdf, PCI_COMMAND, cmd);
+    else
+        defer_map(dev->domain, dev, cmd, rom_only);
 
     return 0;
+
+fail:
+    return rc;
 }
 
 static void cmd_write(const struct pci_dev *pdev, unsigned int reg,
@@ -529,6 +605,19 @@ static void rom_write(const struct pci_dev *pdev, unsigned int reg,
         rom->addr = val & PCI_ROM_ADDRESS_MASK;
 }
 
+static int bar_add_rangeset(struct pci_dev *pdev, struct vpci_bar *bar, int i)
+{
+    char str[32];
+
+    snprintf(str, sizeof(str), "%pp:BAR%d", &pdev->sbdf, i);
+
+    bar->mem = rangeset_new(pdev->domain, str, RANGESETF_no_print);
+    if ( !bar->mem )
+        return -ENOMEM;
+
+    return 0;
+}
+
 static int init_bars(struct pci_dev *pdev)
 {
     uint16_t cmd;
@@ -607,6 +696,13 @@ static int init_bars(struct pci_dev *pdev)
         else
             bars[i].type = VPCI_BAR_MEM32;
 
+        rc = bar_add_rangeset(pdev, &bars[i], i);
+        if ( rc )
+        {
+            bars[i].type = VPCI_BAR_EMPTY;
+            return rc;
+        }
+
         rc = pci_size_mem_bar(pdev->sbdf, reg, &addr, &size,
                               (i == num_bars - 1) ? PCI_BAR_LAST : 0);
         if ( rc < 0 )
@@ -659,6 +755,15 @@ static int init_bars(struct pci_dev *pdev)
                                    rom_reg, 4, rom);
             if ( rc )
                 rom->type = VPCI_BAR_EMPTY;
+            else
+            {
+                rc = bar_add_rangeset(pdev, rom, i);
+                if ( rc )
+                {
+                    rom->type = VPCI_BAR_EMPTY;
+                    return rc;
+                }
+            }
         }
     }
     else
diff --git a/xen/drivers/vpci/vpci.c b/xen/drivers/vpci/vpci.c
index 4e774875fa04..3177f13c1c22 100644
--- a/xen/drivers/vpci/vpci.c
+++ b/xen/drivers/vpci/vpci.c
@@ -35,8 +35,11 @@ extern vpci_register_init_t *const __start_vpci_array[];
 extern vpci_register_init_t *const __end_vpci_array[];
 #define NUM_VPCI_INIT (__end_vpci_array - __start_vpci_array)
 
-static void vpci_remove_device_locked(struct pci_dev *pdev)
+void vpci_remove_device_locked(struct pci_dev *pdev)
 {
+    struct vpci_header *header = &pdev->vpci->header;
+    unsigned int i;
+
     ASSERT(spin_is_locked(&pdev->vpci_lock));
 
     while ( !list_empty(&pdev->vpci->handlers) )
@@ -48,6 +51,10 @@ static void vpci_remove_device_locked(struct pci_dev *pdev)
         list_del(&r->node);
         xfree(r);
     }
+
+    for ( i = 0; i < ARRAY_SIZE(header->bars); i++ )
+        rangeset_destroy(header->bars[i].mem);
+
     xfree(pdev->vpci->msix);
     xfree(pdev->vpci->msi);
     xfree(pdev->vpci);
@@ -94,9 +101,15 @@ int vpci_add_handlers(struct pci_dev *pdev)
     }
 
     if ( rc )
-        vpci_remove_device_locked(pdev);
+        goto fail;
+
     spin_unlock(&pdev->vpci_lock);
 
+    return 0;
+
+ fail:
+    vpci_remove_device_locked(pdev);
+    spin_unlock(&pdev->vpci_lock);
     return rc;
 }
 
diff --git a/xen/include/xen/vpci.h b/xen/include/xen/vpci.h
index 270d22b85653..f1f49db959c7 100644
--- a/xen/include/xen/vpci.h
+++ b/xen/include/xen/vpci.h
@@ -30,6 +30,7 @@ int __must_check vpci_add_handlers(struct pci_dev *dev);
 
 /* Remove all handlers and free vpci related structures. */
 void vpci_remove_device(struct pci_dev *pdev);
+void vpci_remove_device_locked(struct pci_dev *pdev);
 
 /* Add/remove a register handler. Must be called holding the vpci_lock. */
 int __must_check vpci_add_register(struct vpci *vpci,
@@ -71,6 +72,7 @@ struct vpci {
             /* Guest view of the BAR: address and lower bits. */
             uint64_t guest_reg;
             uint64_t size;
+            struct rangeset *mem;
             enum {
                 VPCI_BAR_EMPTY,
                 VPCI_BAR_IO,
@@ -143,9 +145,9 @@ struct vpci {
 
 struct vpci_vcpu {
     /* Per-vcpu structure to store state while {un}mapping of PCI BARs. */
-    struct rangeset *mem;
     struct pci_dev *pdev;
     uint16_t cmd;
+    bool map_pending : 1;
     bool rom_only : 1;
 };
 
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Feb 04 06:35:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 06:35:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265012.458353 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFsBe-000255-SQ; Fri, 04 Feb 2022 06:35:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265012.458353; Fri, 04 Feb 2022 06:35:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFsBe-00022M-Hy; Fri, 04 Feb 2022 06:35:14 +0000
Received: by outflank-mailman (input) for mailman id 265012;
 Fri, 04 Feb 2022 06:35:12 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Tguk=ST=gmail.com=andr2000@srs-se1.protection.inumbo.net>)
 id 1nFsBc-0008DX-K9
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 06:35:12 +0000
Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com
 [2a00:1450:4864:20::229])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9aa7edd9-8584-11ec-8eb8-a37418f5ba1a;
 Fri, 04 Feb 2022 07:35:11 +0100 (CET)
Received: by mail-lj1-x229.google.com with SMTP id o17so7205812ljp.1
 for <xen-devel@lists.xenproject.org>; Thu, 03 Feb 2022 22:35:11 -0800 (PST)
Received: from a2klaptop.localdomain ([185.199.97.5])
 by smtp.gmail.com with ESMTPSA id f34sm163027lfv.165.2022.02.03.22.35.10
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 03 Feb 2022 22:35:11 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9aa7edd9-8584-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=kqe4MtyzAvOGHGKuf3R4wkGH8c0Z7HCCzvLS5umkU1o=;
        b=aZkmCJKMeQMCzE2uO2NL3NExo6pehR9hggGJIxvr10ezeFkscLBRLAEIPtGHDIlsqF
         FveGForAVCWOyJlL3/TNTCBHOHo+Q0iyqVUt9stcPGLF6Mxk2yWgzk7Udh7NSFfXHgSv
         mGKlJEtlUNpEpXKgcI78rxcdD7OZBG30y0EUavYCZkEZvoe9YJ+rCGi+CILkvgXO8xu/
         wz9SJIAVk5jW9Ecnomi3T/yn2Mz+ym/5oytSRRlHKvzfNvb7mJPp89O6h5Roik30WQOq
         uKJVOEQyY9bj7IyjoH31Nbhg+RkJveky4PRhP+/wsOWjwiHZxyRidGJ8s5r75BtavSse
         pkuQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=kqe4MtyzAvOGHGKuf3R4wkGH8c0Z7HCCzvLS5umkU1o=;
        b=AsEv10kFpOKydudwGvE8kQcOvV5LDlnubhJSs6Euvxc1+n1B+i5T2JVeFyu9cC2tYq
         1QvjKcQOrAsNCVDl88fo55sOK/EzhN7oC7BdB6iZklEE1ZlvaJaJBPDENKr+4tqIgNEa
         KI/kTxt/Yv/lsIRphH2zhYfDtY5BvWxaM250zotaOC6sFA3gncKiyor/YLWeTmgNWcKB
         CJVUrBeEJpQ9imhPSK011AV6eMZ2RV0+5dPRfUKXRRmEYatG1qhOXn0aB7zk1qLfVA8u
         8R103oAEH6o6c4/i/ENsxxulxWX4Oh/14J2lGNfN6JJxRSEHZO2YpXiKtsCgTsZstF3f
         A1Ng==
X-Gm-Message-State: AOAM532O27H6J7PQHT8ljmdzqNDO1XcM1mJgOiFCJyWgx9RZbxb1PMxo
	2SF8N9vkjE+G4tddnmN//7rxBa8WbtU=
X-Google-Smtp-Source: ABdhPJyB7jlJZ7qysvRjbOwP2BLmD+X+2ZSuXBZ47oczLChBA1MjcsRUZxy9FgQ7GWx1wfWjjkim7w==
X-Received: by 2002:a2e:bc1c:: with SMTP id b28mr936913ljf.40.1643956511398;
        Thu, 03 Feb 2022 22:35:11 -0800 (PST)
From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	sstabellini@kernel.org,
	oleksandr_tyshchenko@epam.com,
	volodymyr_babchuk@epam.com,
	artem_mygaiev@epam.com,
	roger.pau@citrix.com,
	jbeulich@suse.com,
	andrew.cooper3@citrix.com,
	george.dunlap@citrix.com,
	paul@xen.org,
	bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: [PATCH v6 09/13] vpci/header: emulate PCI_COMMAND register for guests
Date: Fri,  4 Feb 2022 08:34:55 +0200
Message-Id: <20220204063459.680961-10-andr2000@gmail.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220204063459.680961-1-andr2000@gmail.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

Add basic emulation support for guests. At the moment only emulate
PCI_COMMAND_INTX_DISABLE bit, the rest is not emulated yet and left
as TODO.

Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
---
Since v5:
- add additional check for MSI-X enabled while altering INTX bit
- make sure INTx disabled while guests enable MSI/MSI-X
Since v3:
- gate more code on CONFIG_HAS_MSI
- removed logic for the case when MSI/MSI-X not enabled
---
 xen/drivers/vpci/header.c | 21 +++++++++++++++++++--
 xen/drivers/vpci/msi.c    |  4 ++++
 xen/drivers/vpci/msix.c   |  4 ++++
 3 files changed, 27 insertions(+), 2 deletions(-)

diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c
index 88ca1ad8211d..33d8c15ae6e8 100644
--- a/xen/drivers/vpci/header.c
+++ b/xen/drivers/vpci/header.c
@@ -454,6 +454,22 @@ static void cmd_write(const struct pci_dev *pdev, unsigned int reg,
         pci_conf_write16(pdev->sbdf, reg, cmd);
 }
 
+static void guest_cmd_write(const struct pci_dev *pdev, unsigned int reg,
+                            uint32_t cmd, void *data)
+{
+    /* TODO: Add proper emulation for all bits of the command register. */
+
+#ifdef CONFIG_HAS_PCI_MSI
+    if ( pdev->vpci->msi->enabled || pdev->vpci->msix->enabled )
+    {
+        /* Guest wants to enable INTx. It can't be enabled if MSI/MSI-X enabled. */
+        cmd |= PCI_COMMAND_INTX_DISABLE;
+    }
+#endif
+
+    cmd_write(pdev, reg, cmd, data);
+}
+
 static void bar_write(const struct pci_dev *pdev, unsigned int reg,
                       uint32_t val, void *data)
 {
@@ -661,8 +677,9 @@ static int init_bars(struct pci_dev *pdev)
     }
 
     /* Setup a handler for the command register. */
-    rc = vpci_add_register(pdev->vpci, vpci_hw_read16, cmd_write, PCI_COMMAND,
-                           2, header);
+    rc = vpci_add_register(pdev->vpci, vpci_hw_read16,
+                           is_hwdom ? cmd_write : guest_cmd_write,
+                           PCI_COMMAND, 2, header);
     if ( rc )
         return rc;
 
diff --git a/xen/drivers/vpci/msi.c b/xen/drivers/vpci/msi.c
index e3ce46869dad..90465dcb4831 100644
--- a/xen/drivers/vpci/msi.c
+++ b/xen/drivers/vpci/msi.c
@@ -70,6 +70,10 @@ static void control_write(const struct pci_dev *pdev, unsigned int reg,
 
         if ( vpci_msi_arch_enable(msi, pdev, vectors) )
             return;
+
+        /* Make sure guest doesn't enable INTx while enabling MSI. */
+        if ( !is_hardware_domain(pdev->domain) )
+            pci_intx(pdev, false);
     }
     else
         vpci_msi_arch_disable(msi, pdev);
diff --git a/xen/drivers/vpci/msix.c b/xen/drivers/vpci/msix.c
index d1dbfc6e0ffd..4c0e1836b589 100644
--- a/xen/drivers/vpci/msix.c
+++ b/xen/drivers/vpci/msix.c
@@ -92,6 +92,10 @@ static void control_write(const struct pci_dev *pdev, unsigned int reg,
         for ( i = 0; i < msix->max_entries; i++ )
             if ( !msix->entries[i].masked && msix->entries[i].updated )
                 update_entry(&msix->entries[i], pdev, i);
+
+        /* Make sure guest doesn't enable INTx while enabling MSI-X. */
+        if ( !is_hardware_domain(pdev->domain) )
+            pci_intx(pdev, false);
     }
     else if ( !new_enabled && msix->enabled )
     {
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Feb 04 06:35:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 06:35:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265003.458260 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFsBW-0008Du-8W; Fri, 04 Feb 2022 06:35:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265003.458260; Fri, 04 Feb 2022 06:35:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFsBW-0008Dn-5U; Fri, 04 Feb 2022 06:35:06 +0000
Received: by outflank-mailman (input) for mailman id 265003;
 Fri, 04 Feb 2022 06:35:04 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Tguk=ST=gmail.com=andr2000@srs-se1.protection.inumbo.net>)
 id 1nFsBU-0008DW-BO
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 06:35:04 +0000
Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com
 [2a00:1450:4864:20::132])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 94951977-8584-11ec-8f75-fffcc8bd4f1a;
 Fri, 04 Feb 2022 07:35:01 +0100 (CET)
Received: by mail-lf1-x132.google.com with SMTP id bu18so10750523lfb.5
 for <xen-devel@lists.xenproject.org>; Thu, 03 Feb 2022 22:35:01 -0800 (PST)
Received: from a2klaptop.localdomain ([185.199.97.5])
 by smtp.gmail.com with ESMTPSA id f34sm163027lfv.165.2022.02.03.22.34.59
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 03 Feb 2022 22:35:00 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 94951977-8584-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=ZtTP0vCKvp+IYYxFasqhvmaqt9iKhL0NT56BNAzsirA=;
        b=QRuFvihoVYidWIZ4bw9oCMJgOve+jackLzUmJ5jUw0pQNniIwsKgOA+oUOPRhgKHPw
         C6vA0NdUuOkfRBKTtWsq7ZV2ASMy+wfTdJBJKtukSkXjpfhHGXLGHCgggN/G/14PhmGx
         9hUg1Rx0O5LVqYWcaxxBb0KMi4mf2Hg+3ogGIKsrrw5fWFp/yThpxG1Q4oBvb2vOc2gb
         ylfMs/QhLr28xz91RHiwsEtfiwJ5BYZAj4aaqiMCOZyE/luUh2NjkkYP7+X+Kb+aPYZk
         FbA/4tTXRzt5p4QhIG/XnhQiAIgVvCL0DlPVy3oWD8CC85c3t4rlJ7eaeokLcmppVehh
         ATRw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=ZtTP0vCKvp+IYYxFasqhvmaqt9iKhL0NT56BNAzsirA=;
        b=GzICe0hJGbQQ6RYn5LerMaY0acu4qTF5/yr4f3/V+HGckwJ/mABGELGAZ83ThbkuCW
         pyIbbR95WjfcL10TX9oJj/U3i+XEBYswZhF6WAlibm4Sl5LsfD/gaLOWjOOEiNWGndPt
         tLxBAu3k6pX3ln9UbkZCQ8VIy1Rthl2R9ohgkqFdf9b1jg4/kcNhnR5sWH0Ca4WyvT32
         6IO3XO83BiIhUxPNLE4NlXPTapDNW6h/BpeblXngDUo3ei/pdzswXSB7K3TrvI9cv1jB
         GDTFBQcUM7k6HMDCg8+QZ9pcAb9qmgzlCS4WpNSmNc7UCQKERMr2leXRB5f+I6p4VDnA
         sCxA==
X-Gm-Message-State: AOAM531Ewkx8ZTLezUJ/ln0y2kTlb/CIN/ULOeV5840fbnQJ5JWQPcZD
	kg6mRx3bAiEWuCL+IvUlLVtWN2O9SGk=
X-Google-Smtp-Source: ABdhPJzTYRa1imZc1Halu4szk4xYwY4WPYb6taPvwofWEBnmAOcXNAjTHC1EpxQheJivPrNGgeMznw==
X-Received: by 2002:a05:6512:3a91:: with SMTP id q17mr1308919lfu.628.1643956501075;
        Thu, 03 Feb 2022 22:35:01 -0800 (PST)
From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	sstabellini@kernel.org,
	oleksandr_tyshchenko@epam.com,
	volodymyr_babchuk@epam.com,
	artem_mygaiev@epam.com,
	roger.pau@citrix.com,
	jbeulich@suse.com,
	andrew.cooper3@citrix.com,
	george.dunlap@citrix.com,
	paul@xen.org,
	bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: [PATCH v6 00/13] PCI devices passthrough on Arm, part 3
Date: Fri,  4 Feb 2022 08:34:46 +0200
Message-Id: <20220204063459.680961-1-andr2000@gmail.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

Hi, all!

1. This patch series is focusing on vPCI and adds support for non-identity
PCI BAR mappings which is required while passing through a PCI device to
a guest. The highlights are:

- Add relevant vpci register handlers when assigning PCI device to a domain
  and remove those when de-assigning. This allows having different
  handlers for different domains, e.g. hwdom and other guests.

- Emulate guest BAR register values based on physical BAR values.
  This allows creating a guest view of the registers and emulates
  size and properties probe as it is done during PCI device enumeration by
  the guest.

- Instead of handling a single range set, that contains all the memory
  regions of all the BARs and ROM, have them per BAR.

- Take into account guest's BAR view and program its p2m accordingly:
  gfn is guest's view of the BAR and mfn is the physical BAR value as set
  up by the host bridge in the hardware domain.
  This way hardware doamin sees physical BAR values and guest sees
  emulated ones.

2. The series also adds support for virtual PCI bus topology for guests:
 - We emulate a single host bridge for the guest, so segment is always 0.
 - The implementation is limited to 32 devices which are allowed on
   a single PCI bus.
 - The virtual bus number is set to 0, so virtual devices are seen
   as embedded endpoints behind the root complex.

3. The series has complete re-work of the locking scheme used/absent before with
the help of the work started by Roger [1]:
[PATCH v6 03/13] vpci: move lock outside of struct vpci

This way the lock can be used to check whether vpci is present, and
removal can be performed while holding the lock, in order to make
sure there are no accesses to the contents of the vpci struct.
Previously removal could race with vpci_read for example, since the
lock was dropped prior to freeing pdev->vpci.
This also solves synchronization issues between all vPCI code entities
which could run in parallel.

4. For unprivileged guests vpci_{read|write} has been re-worked
to not passthrough accesses to the registers not explicitly handled
by the corresponding vPCI handlers: without that passthrough
to guests is completely unsafe as Xen allows them full access to
the registers.
During development this can be reverted for debugging purposes.

5. The series was also tested on:
 - x86 PVH Dom0 and doesn't break it.
 - x86 HVM with PCI passthrough to DomU and doesn't break it.
 - Arm

Thank you,
Oleksandr

[1] https://lore.kernel.org/xen-devel/20180717094830.54806-2-roger.pau@citrix.com/

Oleksandr Andrushchenko (12):
  xen/pci: arm: add stub for is_memory_hole
  rangeset: add RANGESETF_no_print flag
  vpci: restrict unhandled read/write operations for guests
  vpci: add hooks for PCI device assign/de-assign
  vpci/header: implement guest BAR register handlers
  vpci/header: handle p2m range sets per BAR
  vpci/header: program p2m with guest BAR view
  vpci/header: emulate PCI_COMMAND register for guests
  vpci/header: reset the command register when adding devices
  vpci: add initial support for virtual PCI bus topology
  xen/arm: translate virtual PCI bus topology for guests
  xen/arm: account IO handlers for emulated PCI MSI-X

Roger Pau Monné (1):
  vpci: move lock outside of struct vpci

 tools/tests/vpci/emul.h       |   5 +-
 tools/tests/vpci/main.c       |   3 +-
 xen/arch/arm/mm.c             |   6 +
 xen/arch/arm/vpci.c           |  31 ++-
 xen/arch/x86/hvm/vmsi.c       |   8 +-
 xen/common/rangeset.c         |   5 +-
 xen/drivers/Kconfig           |   4 +
 xen/drivers/passthrough/pci.c |   7 +
 xen/drivers/vpci/header.c     | 407 +++++++++++++++++++++++++++-------
 xen/drivers/vpci/msi.c        |  15 +-
 xen/drivers/vpci/msix.c       |  43 +++-
 xen/drivers/vpci/vpci.c       | 232 ++++++++++++++++---
 xen/include/xen/pci.h         |   1 +
 xen/include/xen/rangeset.h    |   5 +-
 xen/include/xen/sched.h       |   8 +
 xen/include/xen/vpci.h        |  43 +++-
 16 files changed, 688 insertions(+), 135 deletions(-)

-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Feb 04 06:35:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 06:35:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265011.458347 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFsBe-0001xn-7F; Fri, 04 Feb 2022 06:35:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265011.458347; Fri, 04 Feb 2022 06:35:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFsBd-0001vu-Ru; Fri, 04 Feb 2022 06:35:13 +0000
Received: by outflank-mailman (input) for mailman id 265011;
 Fri, 04 Feb 2022 06:35:11 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Tguk=ST=gmail.com=andr2000@srs-se1.protection.inumbo.net>)
 id 1nFsBb-0008DX-OD
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 06:35:11 +0000
Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com
 [2a00:1450:4864:20::236])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 99ffe2d3-8584-11ec-8eb8-a37418f5ba1a;
 Fri, 04 Feb 2022 07:35:10 +0100 (CET)
Received: by mail-lj1-x236.google.com with SMTP id q22so7161844ljh.7
 for <xen-devel@lists.xenproject.org>; Thu, 03 Feb 2022 22:35:10 -0800 (PST)
Received: from a2klaptop.localdomain ([185.199.97.5])
 by smtp.gmail.com with ESMTPSA id f34sm163027lfv.165.2022.02.03.22.35.09
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 03 Feb 2022 22:35:09 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 99ffe2d3-8584-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=qtkK/j8pu6kupq3RbAcpqc3jfOmxqW4/nLCIHyxmPhw=;
        b=LcavmegIjsn1jtf8L7reZvcGqNqvIimlLW1FC6Ke96AWMS6A1lu/GmYLd/9I1A7eOw
         jPIME4KoFaZrtnuk6in1pPcQT5stbkymritBMZsl10FZgWzoZTCXcMxagp84DfsZihPO
         RGHQ6aJu9q5yYUUc8Qwq1qITZw9XC9KqwLeO0nqJU9/MdYb4p4qLnWVVbCeoOb9I/hII
         Vg3reIRVkq4BiSLDhBh/LZekJM9WKWvbbrreZwgvowYHpG5iDUpcB4hlJHFtciVWbF+k
         cSiUsa8gnlvcsBaOxRu//oTbG897/xj+hDT9fih5k9WgdSxNR6SZxcByWKamdK0yQ+MJ
         ZKyw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=qtkK/j8pu6kupq3RbAcpqc3jfOmxqW4/nLCIHyxmPhw=;
        b=krTo55hg/qcIHx41WTWoZt7hP9NsAKZMFtlrsVKMnuntoAJt/SBKh89r7BXIwGnspl
         ej1QcDRJWTZ4Ka7ySxPSMMJ7b7KcsTnOWu19Lz3mTgEDrRYV7alJyDFd7f0YDTEg/SdK
         IyyMdhX0McVPh2rCDvwwMcd6zGwRjjn52jo/DT4vDxz2m23xHwVm1dbw2iGoX4JqUijR
         oP3qF/FTnHncgFxpkSFm6CLPJhdP+dZCEYB02tvvckYTitkplsL1XLCBfdj6KjozDuVH
         aATIxqQK71FLpYs0v50KNtj0HRslrF7OtL7pZxeKyIHRABMz18f/yZdHzrokNzESG+Pj
         F/Rg==
X-Gm-Message-State: AOAM5315kovfUAmtwPGswe5OzrrnAydL11URkgEWGXeEBOCS0yH4Q3ED
	eafc/+FSPEZ4bfCHvN84WyzRN+XyiZ0=
X-Google-Smtp-Source: ABdhPJxTXPZEdj2jvQlmavhyN/FVUW2Ujue3KbH3gBqvpnm6iioAFpcnFab7qHHhSkjZUArvQ7YeEw==
X-Received: by 2002:a2e:a607:: with SMTP id v7mr936685ljp.248.1643956510257;
        Thu, 03 Feb 2022 22:35:10 -0800 (PST)
From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	sstabellini@kernel.org,
	oleksandr_tyshchenko@epam.com,
	volodymyr_babchuk@epam.com,
	artem_mygaiev@epam.com,
	roger.pau@citrix.com,
	jbeulich@suse.com,
	andrew.cooper3@citrix.com,
	george.dunlap@citrix.com,
	paul@xen.org,
	bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: [PATCH v6 08/13] vpci/header: program p2m with guest BAR view
Date: Fri,  4 Feb 2022 08:34:54 +0200
Message-Id: <20220204063459.680961-9-andr2000@gmail.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220204063459.680961-1-andr2000@gmail.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

Take into account guest's BAR view and program its p2m accordingly:
gfn is guest's view of the BAR and mfn is the physical BAR value as set
up by the PCI bus driver in the hardware domain.
This way hardware domain sees physical BAR values and guest sees
emulated ones.

Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
---
Since v5:
- remove debug print in map_range callback
- remove "identity" from the debug print
Since v4:
- moved start_{gfn|mfn} calculation into map_range
- pass vpci_bar in the map_data instead of start_{gfn|mfn}
- s/guest_addr/guest_reg
Since v3:
- updated comment (Roger)
- removed gfn_add(map->start_gfn, rc); which is wrong
- use v->domain instead of v->vpci.pdev->domain
- removed odd e.g. in comment
- s/d%d/%pd in altered code
- use gdprintk for map/unmap logs
Since v2:
- improve readability for data.start_gfn and restructure ?: construct
Since v1:
 - s/MSI/MSI-X in comments
---
 xen/drivers/vpci/header.c | 24 ++++++++++++++++++++----
 1 file changed, 20 insertions(+), 4 deletions(-)

diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c
index 0c94504b87d8..88ca1ad8211d 100644
--- a/xen/drivers/vpci/header.c
+++ b/xen/drivers/vpci/header.c
@@ -30,6 +30,7 @@
 
 struct map_data {
     struct domain *d;
+    const struct vpci_bar *bar;
     bool map;
 };
 
@@ -41,8 +42,21 @@ static int map_range(unsigned long s, unsigned long e, void *data,
 
     for ( ; ; )
     {
+        /* Start address of the BAR as seen by the guest. */
+        gfn_t start_gfn = _gfn(PFN_DOWN(is_hardware_domain(map->d)
+                                        ? map->bar->addr
+                                        : map->bar->guest_reg));
+        /* Physical start address of the BAR. */
+        mfn_t start_mfn = _mfn(PFN_DOWN(map->bar->addr));
         unsigned long size = e - s + 1;
 
+        /*
+         * Ranges to be mapped don't always start at the BAR start address, as
+         * there can be holes or partially consumed ranges. Account for the
+         * offset of the current address from the BAR start.
+         */
+        start_gfn = gfn_add(start_gfn, s - mfn_x(start_mfn));
+
         /*
          * ARM TODOs:
          * - On ARM whether the memory is prefetchable or not should be passed
@@ -52,8 +66,8 @@ static int map_range(unsigned long s, unsigned long e, void *data,
          * - {un}map_mmio_regions doesn't support preemption.
          */
 
-        rc = map->map ? map_mmio_regions(map->d, _gfn(s), size, _mfn(s))
-                      : unmap_mmio_regions(map->d, _gfn(s), size, _mfn(s));
+        rc = map->map ? map_mmio_regions(map->d, start_gfn, size, _mfn(s))
+                      : unmap_mmio_regions(map->d, start_gfn, size, _mfn(s));
         if ( rc == 0 )
         {
             *c += size;
@@ -62,8 +76,8 @@ static int map_range(unsigned long s, unsigned long e, void *data,
         if ( rc < 0 )
         {
             printk(XENLOG_G_WARNING
-                   "Failed to identity %smap [%lx, %lx] for d%d: %d\n",
-                   map->map ? "" : "un", s, e, map->d->domain_id, rc);
+                   "Failed to %smap [%lx, %lx] for %pd: %d\n",
+                   map->map ? "" : "un", s, e, map->d, rc);
             break;
         }
         ASSERT(rc < size);
@@ -154,6 +168,7 @@ bool vpci_process_pending(struct vcpu *v)
             if ( rangeset_is_empty(bar->mem) )
                 continue;
 
+            data.bar = bar;
             rc = rangeset_consume_ranges(bar->mem, map_range, &data);
 
             if ( rc == -ERESTART )
@@ -206,6 +221,7 @@ static int __init apply_map(struct domain *d, const struct pci_dev *pdev,
         if ( rangeset_is_empty(bar->mem) )
             continue;
 
+        data.bar = bar;
         while ( (rc = rangeset_consume_ranges(bar->mem, map_range,
                                               &data)) == -ERESTART )
             process_pending_softirqs();
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Feb 04 06:35:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 06:35:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265004.458267 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFsBW-0008HS-JN; Fri, 04 Feb 2022 06:35:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265004.458267; Fri, 04 Feb 2022 06:35:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFsBW-0008Ga-DK; Fri, 04 Feb 2022 06:35:06 +0000
Received: by outflank-mailman (input) for mailman id 265004;
 Fri, 04 Feb 2022 06:35:04 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Tguk=ST=gmail.com=andr2000@srs-se1.protection.inumbo.net>)
 id 1nFsBU-0008DW-TO
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 06:35:04 +0000
Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com
 [2a00:1450:4864:20::22f])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 95dfe064-8584-11ec-8f75-fffcc8bd4f1a;
 Fri, 04 Feb 2022 07:35:04 +0100 (CET)
Received: by mail-lj1-x22f.google.com with SMTP id c15so7131145ljf.11
 for <xen-devel@lists.xenproject.org>; Thu, 03 Feb 2022 22:35:03 -0800 (PST)
Received: from a2klaptop.localdomain ([185.199.97.5])
 by smtp.gmail.com with ESMTPSA id f34sm163027lfv.165.2022.02.03.22.35.02
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 03 Feb 2022 22:35:02 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 95dfe064-8584-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=fkt1iiffJfOyIvWsY76Bn/20kVLeJA6ML116mlUONbo=;
        b=pf1kd98rLRo4oMne6N5TZmeGAzADdmqWwChEtEtmGzVv81uVsjUztGLFhrbZFULVdE
         59MTje+KtbOtCXsBULQRsNzE7Z0GKfm8Nw3uoeKeNDxFEQ27YfVvizhGZLVmC+00sDzT
         GFycA4Y+NWJf8d8B6RgZYRLHCvA5/lghyY0lo9DewojjjiXB12uVVKO8HA+M0HBKO5gO
         rG+ZOZsp5yjmjQkM3AzPstjUMy4neYoQWjcH+1wdkB/Haj1o90UBHpNfSMawLb1c8u7I
         v/aUtOlxo0Vho4MIeLtOR1Uz9PjDjFjjDrZjHDMGYclAMJJz1cZI9fBx++zFhtF2eGVt
         O/mQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=fkt1iiffJfOyIvWsY76Bn/20kVLeJA6ML116mlUONbo=;
        b=DRIdD5Oapo/yGKjgmf9wgZWDUYkvxnLCZiIttILa8fmgx3g2hjrpBIBdXZBhW/ITFB
         rhvwANbGnd7dhx9qEfJBzuKQDsrOIc6M2VqWQZUEeJOh7dxN+WgmwjIaCbuwWQAFDvjb
         8irAQRi6uVT5yxcdjtrFH7mVvBJtD9YvUm1T49re6JIqmAEjbAkqZyhlmu/4Uu3mIwSn
         zRG9CHQ0QPfDrJkf3AZ6WTg0xdfzeDMPJluzaF3tvRIhL+uIfcvtmNqrp3l26P12HV5C
         T75b3N1hPFQO9dQPL2NMmtwAig033Ulr6udEOjCD4K1rvbxBbEmWJr1Gcx8HdlkxxGNk
         gG3Q==
X-Gm-Message-State: AOAM5303zwEb02k+8Pz8CptI47KHAVGIz4qK+XlNQeU7ccBxWVva6JXl
	ICfgQpeUtqKyhsUDFW+a6qNu8GgivN4=
X-Google-Smtp-Source: ABdhPJxPoAt1JRMWcJlYt+YBJllDqtzQb/8LTegxXLQOdjyAb34lQHAZ/fQnkHFk0AYemOu19Q85wQ==
X-Received: by 2002:a2e:a583:: with SMTP id m3mr934695ljp.530.1643956503315;
        Thu, 03 Feb 2022 22:35:03 -0800 (PST)
From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	sstabellini@kernel.org,
	oleksandr_tyshchenko@epam.com,
	volodymyr_babchuk@epam.com,
	artem_mygaiev@epam.com,
	roger.pau@citrix.com,
	jbeulich@suse.com,
	andrew.cooper3@citrix.com,
	george.dunlap@citrix.com,
	paul@xen.org,
	bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: [PATCH v6 02/13] rangeset: add RANGESETF_no_print flag
Date: Fri,  4 Feb 2022 08:34:48 +0200
Message-Id: <20220204063459.680961-3-andr2000@gmail.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220204063459.680961-1-andr2000@gmail.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

There are range sets which should not be printed, so introduce a flag
which allows marking those as such. Implement relevant logic to skip
such entries while printing.

While at it also simplify the definition of the flags by directly
defining those without helpers.

Suggested-by: Jan Beulich <jbeulich@suse.com>
Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
---
Since v5:
- comment indentation (Jan)
Since v1:
- update BUG_ON with new flag
- simplify the definition of the flags
---
 xen/common/rangeset.c      | 5 ++++-
 xen/include/xen/rangeset.h | 5 +++--
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/xen/common/rangeset.c b/xen/common/rangeset.c
index 885b6b15c229..ea27d651723b 100644
--- a/xen/common/rangeset.c
+++ b/xen/common/rangeset.c
@@ -433,7 +433,7 @@ struct rangeset *rangeset_new(
     INIT_LIST_HEAD(&r->range_list);
     r->nr_ranges = -1;
 
-    BUG_ON(flags & ~RANGESETF_prettyprint_hex);
+    BUG_ON(flags & ~(RANGESETF_prettyprint_hex | RANGESETF_no_print));
     r->flags = flags;
 
     safe_strcpy(r->name, name ?: "(no name)");
@@ -575,6 +575,9 @@ void rangeset_domain_printk(
 
     list_for_each_entry ( r, &d->rangesets, rangeset_list )
     {
+        if ( r->flags & RANGESETF_no_print )
+            continue;
+
         printk("    ");
         rangeset_printk(r);
         printk("\n");
diff --git a/xen/include/xen/rangeset.h b/xen/include/xen/rangeset.h
index 135f33f6066f..f7c69394d66a 100644
--- a/xen/include/xen/rangeset.h
+++ b/xen/include/xen/rangeset.h
@@ -49,8 +49,9 @@ void rangeset_limit(
 
 /* Flags for passing to rangeset_new(). */
  /* Pretty-print range limits in hexadecimal. */
-#define _RANGESETF_prettyprint_hex 0
-#define RANGESETF_prettyprint_hex  (1U << _RANGESETF_prettyprint_hex)
+#define RANGESETF_prettyprint_hex   (1U << 0)
+ /* Do not print entries marked with this flag. */
+#define RANGESETF_no_print          (1U << 1)
 
 bool_t __must_check rangeset_is_empty(
     const struct rangeset *r);
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Feb 04 06:35:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 06:35:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265006.458294 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFsBY-0000VJ-Ea; Fri, 04 Feb 2022 06:35:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265006.458294; Fri, 04 Feb 2022 06:35:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFsBY-0000Ug-5u; Fri, 04 Feb 2022 06:35:08 +0000
Received: by outflank-mailman (input) for mailman id 265006;
 Fri, 04 Feb 2022 06:35:06 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Tguk=ST=gmail.com=andr2000@srs-se1.protection.inumbo.net>)
 id 1nFsBW-0008DW-GL
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 06:35:06 +0000
Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com
 [2a00:1450:4864:20::12c])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 96944681-8584-11ec-8f75-fffcc8bd4f1a;
 Fri, 04 Feb 2022 07:35:05 +0100 (CET)
Received: by mail-lf1-x12c.google.com with SMTP id bu18so10750710lfb.5
 for <xen-devel@lists.xenproject.org>; Thu, 03 Feb 2022 22:35:05 -0800 (PST)
Received: from a2klaptop.localdomain ([185.199.97.5])
 by smtp.gmail.com with ESMTPSA id f34sm163027lfv.165.2022.02.03.22.35.03
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 03 Feb 2022 22:35:04 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 96944681-8584-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=yxvQBdV5Q4sDH3B8Pg7aZNA92D9cHrIG2H+0rNtBrr0=;
        b=VOub8JoCp14IgAzRiaxfC0PpVpvjywdzU8mGd7JwFmaFwxGjA+BjTaDh8w1KVx/A3g
         90Eb5m7hpLa2lEdBvxJ14XNBekRwYoxtC5ofat8XoikToYiCq8V1sVYBoi5z/Okh6mEn
         Nk06PTuxB9YQKcTmHD27MeoSt/qzsD+LPmYpn/3uMCaRPv3UJTqYYHRR9Sbd1q5g/EF9
         pCRb8UJFdRl3S/E0lKNT0FqoCYzbAhS13E7tf9fgx7eV3VZEeo/nM2ZM4F95KKzhjxV6
         CdElOXTXSDVZc/tztA8uS0V40TcRi2i40CFeqO4mTEmTk1FdOl58riBFXboQYB8l430N
         VgMA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=yxvQBdV5Q4sDH3B8Pg7aZNA92D9cHrIG2H+0rNtBrr0=;
        b=JFB+SR2byGIYjnQ+CGtjt3mCF0UouY4LLiQcKtwA9FfcvFnMDBlubTdH89HSv+i+Bn
         6BlFu87ROknkY1hlhIfNyXVD25MJ9MkvY0r61BqPVbiXsraA+iChfLp3UEuUrHGDWLrL
         l0r1i/rSark1q6oAsmqstuo6x5WzK79bRhVxXjjsJ5JOA+7HrLAfkdd+hS8a6YzWeocB
         /j+48VUU5+yTZvyH6V0NTWeHOkolaMPYaNeOhsq1+wnzGwLJ0/7nyXNQb61dBjJDg3ab
         QK9OZydq7Ez+xa9SzBj0CBpZL8uxj3CUQxq53JpqjLj7CmwniEInh6dp5vMlD32kAlc9
         E20A==
X-Gm-Message-State: AOAM532WJiHnNyCYwTdWx/7KnN+TprbaCgwdsZchW2LolBwZjkz6R3xz
	P+xB3MgBhrxLeArFjDKGgkbv931VOCs=
X-Google-Smtp-Source: ABdhPJzh7UX3hWPz+NmdK0JSfU2SwFsZ5hSTEX8nR+b06eIGCf0NrZK59mb8mm2x/wgotivf/NXbIA==
X-Received: by 2002:a05:6512:68a:: with SMTP id t10mr1337219lfe.520.1643956504487;
        Thu, 03 Feb 2022 22:35:04 -0800 (PST)
From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	sstabellini@kernel.org,
	oleksandr_tyshchenko@epam.com,
	volodymyr_babchuk@epam.com,
	artem_mygaiev@epam.com,
	roger.pau@citrix.com,
	jbeulich@suse.com,
	andrew.cooper3@citrix.com,
	george.dunlap@citrix.com,
	paul@xen.org,
	bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Date: Fri,  4 Feb 2022 08:34:49 +0200
Message-Id: <20220204063459.680961-4-andr2000@gmail.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220204063459.680961-1-andr2000@gmail.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

From: Roger Pau Monné <roger.pau@citrix.com>

This way the lock can be used (and in a few cases is used right away)
to check whether vpci is present, and removal can be performed while
holding the lock, in order to make sure there are no accesses to the
contents of the vpci struct.
Previously removal could race with vpci_read for example, since the
lock was dropped prior to freeing pdev->vpci.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
---
Cc: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Jan Beulich <jbeulich@suse.com>
Cc: Julien Grall <julien@xen.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>
---
New in v5 of this series: this is an updated version of the patch published at
https://lore.kernel.org/xen-devel/20180717094830.54806-2-roger.pau@citrix.com/

Changes since v5:
 - vpci_lock in test_pdev is already initialized to false by default
 - introduce msix_{get|put} to protect former msix_find's result
 - add comments to vpci_{add|remove}_registers about pdev->vpci_lock must
   be held.
 - do not split code into vpci_remove_device_handlers_locked yet
 - move INIT_LIST_HEAD outside the locked region (Jan)
 - stripped out locking optimizations for vpci_{read|write} into a
   dedicated patch
Changes since v2:
 - fixed pdev->vpci = xzalloc(struct vpci); under spin_lock (Jan)
Changes since v1:
 - Assert that vpci_lock is locked in vpci_remove_device_locked.
 - Remove double newline.
 - Shrink critical section in vpci_{read/write}.
---
 tools/tests/vpci/emul.h       |  5 ++-
 tools/tests/vpci/main.c       |  3 +-
 xen/arch/x86/hvm/vmsi.c       |  8 ++---
 xen/drivers/passthrough/pci.c |  1 +
 xen/drivers/vpci/header.c     | 21 +++++++----
 xen/drivers/vpci/msi.c        | 11 ++++--
 xen/drivers/vpci/msix.c       | 39 ++++++++++++++++-----
 xen/drivers/vpci/vpci.c       | 65 ++++++++++++++++++++++-------------
 xen/include/xen/pci.h         |  1 +
 xen/include/xen/vpci.h        |  3 +-
 10 files changed, 106 insertions(+), 51 deletions(-)

diff --git a/tools/tests/vpci/emul.h b/tools/tests/vpci/emul.h
index 2e1d3057c9d8..d018fb5eef21 100644
--- a/tools/tests/vpci/emul.h
+++ b/tools/tests/vpci/emul.h
@@ -44,6 +44,7 @@ struct domain {
 };
 
 struct pci_dev {
+    bool vpci_lock;
     struct vpci *vpci;
 };
 
@@ -53,10 +54,8 @@ struct vcpu
 };
 
 extern const struct vcpu *current;
-extern const struct pci_dev test_pdev;
+extern struct pci_dev test_pdev;
 
-typedef bool spinlock_t;
-#define spin_lock_init(l) (*(l) = false)
 #define spin_lock(l) (*(l) = true)
 #define spin_unlock(l) (*(l) = false)
 
diff --git a/tools/tests/vpci/main.c b/tools/tests/vpci/main.c
index b9a0a6006bb9..3b86ed232eb1 100644
--- a/tools/tests/vpci/main.c
+++ b/tools/tests/vpci/main.c
@@ -23,7 +23,7 @@ static struct vpci vpci;
 
 const static struct domain d;
 
-const struct pci_dev test_pdev = {
+struct pci_dev test_pdev = {
     .vpci = &vpci,
 };
 
@@ -158,7 +158,6 @@ main(int argc, char **argv)
     int rc;
 
     INIT_LIST_HEAD(&vpci.handlers);
-    spin_lock_init(&vpci.lock);
 
     VPCI_ADD_REG(vpci_read32, vpci_write32, 0, 4, r0);
     VPCI_READ_CHECK(0, 4, r0);
diff --git a/xen/arch/x86/hvm/vmsi.c b/xen/arch/x86/hvm/vmsi.c
index 13e2a190b439..1f7a37f78264 100644
--- a/xen/arch/x86/hvm/vmsi.c
+++ b/xen/arch/x86/hvm/vmsi.c
@@ -910,14 +910,14 @@ int vpci_msix_arch_print(const struct vpci_msix *msix)
         {
             struct pci_dev *pdev = msix->pdev;
 
-            spin_unlock(&msix->pdev->vpci->lock);
+            spin_unlock(&msix->pdev->vpci_lock);
             process_pending_softirqs();
             /* NB: we assume that pdev cannot go away for an alive domain. */
-            if ( !pdev->vpci || !spin_trylock(&pdev->vpci->lock) )
+            if ( !spin_trylock(&pdev->vpci_lock) )
                 return -EBUSY;
-            if ( pdev->vpci->msix != msix )
+            if ( !pdev->vpci || pdev->vpci->msix != msix )
             {
-                spin_unlock(&pdev->vpci->lock);
+                spin_unlock(&pdev->vpci_lock);
                 return -EAGAIN;
             }
         }
diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
index e8b09d77d880..50dec3bb73d0 100644
--- a/xen/drivers/passthrough/pci.c
+++ b/xen/drivers/passthrough/pci.c
@@ -397,6 +397,7 @@ static struct pci_dev *alloc_pdev(struct pci_seg *pseg, u8 bus, u8 devfn)
     *((u8*) &pdev->bus) = bus;
     *((u8*) &pdev->devfn) = devfn;
     pdev->domain = NULL;
+    spin_lock_init(&pdev->vpci_lock);
 
     arch_pci_init_pdev(pdev);
 
diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c
index 40ff79c33f8f..bd23c0274d48 100644
--- a/xen/drivers/vpci/header.c
+++ b/xen/drivers/vpci/header.c
@@ -142,12 +142,13 @@ bool vpci_process_pending(struct vcpu *v)
         if ( rc == -ERESTART )
             return true;
 
-        spin_lock(&v->vpci.pdev->vpci->lock);
-        /* Disable memory decoding unconditionally on failure. */
-        modify_decoding(v->vpci.pdev,
-                        rc ? v->vpci.cmd & ~PCI_COMMAND_MEMORY : v->vpci.cmd,
-                        !rc && v->vpci.rom_only);
-        spin_unlock(&v->vpci.pdev->vpci->lock);
+        spin_lock(&v->vpci.pdev->vpci_lock);
+        if ( v->vpci.pdev->vpci )
+            /* Disable memory decoding unconditionally on failure. */
+            modify_decoding(v->vpci.pdev,
+                            rc ? v->vpci.cmd & ~PCI_COMMAND_MEMORY : v->vpci.cmd,
+                            !rc && v->vpci.rom_only);
+        spin_unlock(&v->vpci.pdev->vpci_lock);
 
         rangeset_destroy(v->vpci.mem);
         v->vpci.mem = NULL;
@@ -285,6 +286,12 @@ static int modify_bars(const struct pci_dev *pdev, uint16_t cmd, bool rom_only)
                 continue;
         }
 
+        spin_lock(&tmp->vpci_lock);
+        if ( !tmp->vpci )
+        {
+            spin_unlock(&tmp->vpci_lock);
+            continue;
+        }
         for ( i = 0; i < ARRAY_SIZE(tmp->vpci->header.bars); i++ )
         {
             const struct vpci_bar *bar = &tmp->vpci->header.bars[i];
@@ -303,12 +310,14 @@ static int modify_bars(const struct pci_dev *pdev, uint16_t cmd, bool rom_only)
             rc = rangeset_remove_range(mem, start, end);
             if ( rc )
             {
+                spin_unlock(&tmp->vpci_lock);
                 printk(XENLOG_G_WARNING "Failed to remove [%lx, %lx]: %d\n",
                        start, end, rc);
                 rangeset_destroy(mem);
                 return rc;
             }
         }
+        spin_unlock(&tmp->vpci_lock);
     }
 
     ASSERT(dev);
diff --git a/xen/drivers/vpci/msi.c b/xen/drivers/vpci/msi.c
index 5757a7aed20f..e3ce46869dad 100644
--- a/xen/drivers/vpci/msi.c
+++ b/xen/drivers/vpci/msi.c
@@ -270,7 +270,7 @@ void vpci_dump_msi(void)
     rcu_read_lock(&domlist_read_lock);
     for_each_domain ( d )
     {
-        const struct pci_dev *pdev;
+        struct pci_dev *pdev;
 
         if ( !has_vpci(d) )
             continue;
@@ -282,8 +282,13 @@ void vpci_dump_msi(void)
             const struct vpci_msi *msi;
             const struct vpci_msix *msix;
 
-            if ( !pdev->vpci || !spin_trylock(&pdev->vpci->lock) )
+            if ( !spin_trylock(&pdev->vpci_lock) )
                 continue;
+            if ( !pdev->vpci )
+            {
+                spin_unlock(&pdev->vpci_lock);
+                continue;
+            }
 
             msi = pdev->vpci->msi;
             if ( msi && msi->enabled )
@@ -323,7 +328,7 @@ void vpci_dump_msi(void)
                 }
             }
 
-            spin_unlock(&pdev->vpci->lock);
+            spin_unlock(&pdev->vpci_lock);
             process_pending_softirqs();
         }
     }
diff --git a/xen/drivers/vpci/msix.c b/xen/drivers/vpci/msix.c
index 846f1b8d7038..d1dbfc6e0ffd 100644
--- a/xen/drivers/vpci/msix.c
+++ b/xen/drivers/vpci/msix.c
@@ -138,7 +138,7 @@ static void control_write(const struct pci_dev *pdev, unsigned int reg,
         pci_conf_write16(pdev->sbdf, reg, val);
 }
 
-static struct vpci_msix *msix_find(const struct domain *d, unsigned long addr)
+static struct vpci_msix *msix_get(const struct domain *d, unsigned long addr)
 {
     struct vpci_msix *msix;
 
@@ -150,15 +150,29 @@ static struct vpci_msix *msix_find(const struct domain *d, unsigned long addr)
         for ( i = 0; i < ARRAY_SIZE(msix->tables); i++ )
             if ( bars[msix->tables[i] & PCI_MSIX_BIRMASK].enabled &&
                  VMSIX_ADDR_IN_RANGE(addr, msix->pdev->vpci, i) )
+            {
+                spin_lock(&msix->pdev->vpci_lock);
                 return msix;
+            }
     }
 
     return NULL;
 }
 
+static void msix_put(struct vpci_msix *msix)
+{
+    if ( !msix )
+        return;
+
+    spin_unlock(&msix->pdev->vpci_lock);
+}
+
 static int msix_accept(struct vcpu *v, unsigned long addr)
 {
-    return !!msix_find(v->domain, addr);
+    struct vpci_msix *msix = msix_get(v->domain, addr);
+
+    msix_put(msix);
+    return !!msix;
 }
 
 static bool access_allowed(const struct pci_dev *pdev, unsigned long addr,
@@ -186,7 +200,7 @@ static int msix_read(struct vcpu *v, unsigned long addr, unsigned int len,
                      unsigned long *data)
 {
     const struct domain *d = v->domain;
-    struct vpci_msix *msix = msix_find(d, addr);
+    struct vpci_msix *msix = msix_get(d, addr);
     const struct vpci_msix_entry *entry;
     unsigned int offset;
 
@@ -196,7 +210,10 @@ static int msix_read(struct vcpu *v, unsigned long addr, unsigned int len,
         return X86EMUL_RETRY;
 
     if ( !access_allowed(msix->pdev, addr, len) )
+    {
+        msix_put(msix);
         return X86EMUL_OKAY;
+    }
 
     if ( VMSIX_ADDR_IN_RANGE(addr, msix->pdev->vpci, VPCI_MSIX_PBA) )
     {
@@ -222,10 +239,10 @@ static int msix_read(struct vcpu *v, unsigned long addr, unsigned int len,
             break;
         }
 
+        msix_put(msix);
         return X86EMUL_OKAY;
     }
 
-    spin_lock(&msix->pdev->vpci->lock);
     entry = get_entry(msix, addr);
     offset = addr & (PCI_MSIX_ENTRY_SIZE - 1);
 
@@ -254,7 +271,8 @@ static int msix_read(struct vcpu *v, unsigned long addr, unsigned int len,
         ASSERT_UNREACHABLE();
         break;
     }
-    spin_unlock(&msix->pdev->vpci->lock);
+
+    msix_put(msix);
 
     return X86EMUL_OKAY;
 }
@@ -263,7 +281,7 @@ static int msix_write(struct vcpu *v, unsigned long addr, unsigned int len,
                       unsigned long data)
 {
     const struct domain *d = v->domain;
-    struct vpci_msix *msix = msix_find(d, addr);
+    struct vpci_msix *msix = msix_get(d, addr);
     struct vpci_msix_entry *entry;
     unsigned int offset;
 
@@ -271,7 +289,10 @@ static int msix_write(struct vcpu *v, unsigned long addr, unsigned int len,
         return X86EMUL_RETRY;
 
     if ( !access_allowed(msix->pdev, addr, len) )
+    {
+        msix_put(msix);
         return X86EMUL_OKAY;
+    }
 
     if ( VMSIX_ADDR_IN_RANGE(addr, msix->pdev->vpci, VPCI_MSIX_PBA) )
     {
@@ -294,10 +315,11 @@ static int msix_write(struct vcpu *v, unsigned long addr, unsigned int len,
             }
         }
 
+        msix_put(msix);
+
         return X86EMUL_OKAY;
     }
 
-    spin_lock(&msix->pdev->vpci->lock);
     entry = get_entry(msix, addr);
     offset = addr & (PCI_MSIX_ENTRY_SIZE - 1);
 
@@ -370,7 +392,8 @@ static int msix_write(struct vcpu *v, unsigned long addr, unsigned int len,
         ASSERT_UNREACHABLE();
         break;
     }
-    spin_unlock(&msix->pdev->vpci->lock);
+
+    msix_put(msix);
 
     return X86EMUL_OKAY;
 }
diff --git a/xen/drivers/vpci/vpci.c b/xen/drivers/vpci/vpci.c
index fb0947179b79..cb2ababa28e3 100644
--- a/xen/drivers/vpci/vpci.c
+++ b/xen/drivers/vpci/vpci.c
@@ -35,12 +35,10 @@ extern vpci_register_init_t *const __start_vpci_array[];
 extern vpci_register_init_t *const __end_vpci_array[];
 #define NUM_VPCI_INIT (__end_vpci_array - __start_vpci_array)
 
-void vpci_remove_device(struct pci_dev *pdev)
+static void vpci_remove_device_locked(struct pci_dev *pdev)
 {
-    if ( !has_vpci(pdev->domain) )
-        return;
+    ASSERT(spin_is_locked(&pdev->vpci_lock));
 
-    spin_lock(&pdev->vpci->lock);
     while ( !list_empty(&pdev->vpci->handlers) )
     {
         struct vpci_register *r = list_first_entry(&pdev->vpci->handlers,
@@ -50,15 +48,26 @@ void vpci_remove_device(struct pci_dev *pdev)
         list_del(&r->node);
         xfree(r);
     }
-    spin_unlock(&pdev->vpci->lock);
     xfree(pdev->vpci->msix);
     xfree(pdev->vpci->msi);
     xfree(pdev->vpci);
     pdev->vpci = NULL;
 }
 
+void vpci_remove_device(struct pci_dev *pdev)
+{
+    if ( !has_vpci(pdev->domain) )
+        return;
+
+    spin_lock(&pdev->vpci_lock);
+    if ( pdev->vpci )
+        vpci_remove_device_locked(pdev);
+    spin_unlock(&pdev->vpci_lock);
+}
+
 int vpci_add_handlers(struct pci_dev *pdev)
 {
+    struct vpci *vpci;
     unsigned int i;
     int rc = 0;
 
@@ -68,12 +77,14 @@ int vpci_add_handlers(struct pci_dev *pdev)
     /* We should not get here twice for the same device. */
     ASSERT(!pdev->vpci);
 
-    pdev->vpci = xzalloc(struct vpci);
-    if ( !pdev->vpci )
+    vpci = xzalloc(struct vpci);
+    if ( !vpci )
         return -ENOMEM;
 
-    INIT_LIST_HEAD(&pdev->vpci->handlers);
-    spin_lock_init(&pdev->vpci->lock);
+    INIT_LIST_HEAD(&vpci->handlers);
+
+    spin_lock(&pdev->vpci_lock);
+    pdev->vpci = vpci;
 
     for ( i = 0; i < NUM_VPCI_INIT; i++ )
     {
@@ -83,7 +94,8 @@ int vpci_add_handlers(struct pci_dev *pdev)
     }
 
     if ( rc )
-        vpci_remove_device(pdev);
+        vpci_remove_device_locked(pdev);
+    spin_unlock(&pdev->vpci_lock);
 
     return rc;
 }
@@ -129,6 +141,7 @@ uint32_t vpci_hw_read32(const struct pci_dev *pdev, unsigned int reg,
     return pci_conf_read32(pdev->sbdf, reg);
 }
 
+/* Must be called with pdev->vpci_lock held. */
 int vpci_add_register(struct vpci *vpci, vpci_read_t *read_handler,
                       vpci_write_t *write_handler, unsigned int offset,
                       unsigned int size, void *data)
@@ -152,8 +165,6 @@ int vpci_add_register(struct vpci *vpci, vpci_read_t *read_handler,
     r->offset = offset;
     r->private = data;
 
-    spin_lock(&vpci->lock);
-
     /* The list of handlers must be kept sorted at all times. */
     list_for_each ( prev, &vpci->handlers )
     {
@@ -165,25 +176,23 @@ int vpci_add_register(struct vpci *vpci, vpci_read_t *read_handler,
             break;
         if ( cmp == 0 )
         {
-            spin_unlock(&vpci->lock);
             xfree(r);
             return -EEXIST;
         }
     }
 
     list_add_tail(&r->node, prev);
-    spin_unlock(&vpci->lock);
 
     return 0;
 }
 
+/* Must be called with pdev->vpci_lock held. */
 int vpci_remove_register(struct vpci *vpci, unsigned int offset,
                          unsigned int size)
 {
     const struct vpci_register r = { .offset = offset, .size = size };
     struct vpci_register *rm;
 
-    spin_lock(&vpci->lock);
     list_for_each_entry ( rm, &vpci->handlers, node )
     {
         int cmp = vpci_register_cmp(&r, rm);
@@ -195,14 +204,12 @@ int vpci_remove_register(struct vpci *vpci, unsigned int offset,
         if ( !cmp && rm->offset == offset && rm->size == size )
         {
             list_del(&rm->node);
-            spin_unlock(&vpci->lock);
             xfree(rm);
             return 0;
         }
         if ( cmp <= 0 )
             break;
     }
-    spin_unlock(&vpci->lock);
 
     return -ENOENT;
 }
@@ -311,7 +318,7 @@ static uint32_t merge_result(uint32_t data, uint32_t new, unsigned int size,
 uint32_t vpci_read(pci_sbdf_t sbdf, unsigned int reg, unsigned int size)
 {
     const struct domain *d = current->domain;
-    const struct pci_dev *pdev;
+    struct pci_dev *pdev;
     const struct vpci_register *r;
     unsigned int data_offset = 0;
     uint32_t data = ~(uint32_t)0;
@@ -327,7 +334,12 @@ uint32_t vpci_read(pci_sbdf_t sbdf, unsigned int reg, unsigned int size)
     if ( !pdev )
         return vpci_read_hw(sbdf, reg, size);
 
-    spin_lock(&pdev->vpci->lock);
+    spin_lock(&pdev->vpci_lock);
+    if ( !pdev->vpci )
+    {
+        spin_unlock(&pdev->vpci_lock);
+        return vpci_read_hw(sbdf, reg, size);
+    }
 
     /* Read from the hardware or the emulated register handlers. */
     list_for_each_entry ( r, &pdev->vpci->handlers, node )
@@ -370,7 +382,7 @@ uint32_t vpci_read(pci_sbdf_t sbdf, unsigned int reg, unsigned int size)
             break;
         ASSERT(data_offset < size);
     }
-    spin_unlock(&pdev->vpci->lock);
+    spin_unlock(&pdev->vpci_lock);
 
     if ( data_offset < size )
     {
@@ -414,7 +426,7 @@ void vpci_write(pci_sbdf_t sbdf, unsigned int reg, unsigned int size,
                 uint32_t data)
 {
     const struct domain *d = current->domain;
-    const struct pci_dev *pdev;
+    struct pci_dev *pdev;
     const struct vpci_register *r;
     unsigned int data_offset = 0;
     const unsigned long *ro_map = pci_get_ro_map(sbdf.seg);
@@ -440,7 +452,14 @@ void vpci_write(pci_sbdf_t sbdf, unsigned int reg, unsigned int size,
         return;
     }
 
-    spin_lock(&pdev->vpci->lock);
+    spin_lock(&pdev->vpci_lock);
+    if ( !pdev->vpci )
+    {
+        spin_unlock(&pdev->vpci_lock);
+        vpci_write_hw(sbdf, reg, size, data);
+        return;
+    }
+
 
     /* Write the value to the hardware or emulated registers. */
     list_for_each_entry ( r, &pdev->vpci->handlers, node )
@@ -475,7 +494,7 @@ void vpci_write(pci_sbdf_t sbdf, unsigned int reg, unsigned int size,
             break;
         ASSERT(data_offset < size);
     }
-    spin_unlock(&pdev->vpci->lock);
+    spin_unlock(&pdev->vpci_lock);
 
     if ( data_offset < size )
         /* Tailing gap, write the remaining. */
diff --git a/xen/include/xen/pci.h b/xen/include/xen/pci.h
index b6d7e454f814..3f60d6c6c6dd 100644
--- a/xen/include/xen/pci.h
+++ b/xen/include/xen/pci.h
@@ -134,6 +134,7 @@ struct pci_dev {
     u64 vf_rlen[6];
 
     /* Data for vPCI. */
+    spinlock_t vpci_lock;
     struct vpci *vpci;
 };
 
diff --git a/xen/include/xen/vpci.h b/xen/include/xen/vpci.h
index e8ac1eb39513..f2a7d82ce77b 100644
--- a/xen/include/xen/vpci.h
+++ b/xen/include/xen/vpci.h
@@ -31,7 +31,7 @@ int __must_check vpci_add_handlers(struct pci_dev *dev);
 /* Remove all handlers and free vpci related structures. */
 void vpci_remove_device(struct pci_dev *pdev);
 
-/* Add/remove a register handler. */
+/* Add/remove a register handler. Must be called holding the vpci_lock. */
 int __must_check vpci_add_register(struct vpci *vpci,
                                    vpci_read_t *read_handler,
                                    vpci_write_t *write_handler,
@@ -60,7 +60,6 @@ bool __must_check vpci_process_pending(struct vcpu *v);
 struct vpci {
     /* List of vPCI handlers for a device. */
     struct list_head handlers;
-    spinlock_t lock;
 
 #ifdef __XEN__
     /* Hide the rest of the vpci struct from the user-space test harness. */
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Feb 04 06:35:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 06:35:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265009.458325 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFsBb-0001Mw-KH; Fri, 04 Feb 2022 06:35:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265009.458325; Fri, 04 Feb 2022 06:35:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFsBb-0001Lt-F5; Fri, 04 Feb 2022 06:35:11 +0000
Received: by outflank-mailman (input) for mailman id 265009;
 Fri, 04 Feb 2022 06:35:09 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Tguk=ST=gmail.com=andr2000@srs-se1.protection.inumbo.net>)
 id 1nFsBZ-0008DX-Hg
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 06:35:09 +0000
Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com
 [2a00:1450:4864:20::22c])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 98aeb6f8-8584-11ec-8eb8-a37418f5ba1a;
 Fri, 04 Feb 2022 07:35:08 +0100 (CET)
Received: by mail-lj1-x22c.google.com with SMTP id e17so7167593ljk.5
 for <xen-devel@lists.xenproject.org>; Thu, 03 Feb 2022 22:35:08 -0800 (PST)
Received: from a2klaptop.localdomain ([185.199.97.5])
 by smtp.gmail.com with ESMTPSA id f34sm163027lfv.165.2022.02.03.22.35.06
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 03 Feb 2022 22:35:07 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 98aeb6f8-8584-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=4b53rA6xzj/VK8mPmETSCKHkM43BtRFV7FZoD/x6CYM=;
        b=LGFssdbglsHSBRlLC10zAwfwl+lxGwyGLcSEdRXHsHfCtbH4EZFUs1eo+aoLDmBg4S
         eB6pFpKJGKQyDTv/SUipdDjBH8iXt/3A/eV7ucleaPmF2llLUvbbMFoCgFShlOdgrmE5
         IivVoOTRjsuUm/VdB7KPtmsXA9ZYwcx9V1RbdqPeDn0jUaaRojQoDRGJ6z4ZWA9TaktG
         faQlTO2kJ0JfREXc0+N3NSw8kLhL6bnWJC8ppgKvyBEIHgfvSZmsnkZOh72SlUdfD6qm
         Z26XqIeZu6GCEF9d4lT6hQIpHAwq0pcEgoN+k/wlaH2N9n2lviiCuaq+NvWUEJnQ4+KW
         CkIA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=4b53rA6xzj/VK8mPmETSCKHkM43BtRFV7FZoD/x6CYM=;
        b=ludS6Bq5lxUDJyLJKJ8L+CWi66r/6ORTsCqx+1w/amxtZDbLTFpSZAfeff8/ruX/rn
         /9m89XT7xmb59nzqBJwUuB7ELOQyhB2L0Jp4DRcPUdTzt2cgFoa8wR/MJmmlcZUAcQfR
         22C+aahPb+c8Q5/9AXtNYbKBIyaoX1foBB18uMQPlHJQuNU5LbQCCOAhDCe4ij9bhTSN
         Iyf+BSWuGAmfN3CTLL00I24nJinXMdU4dreUZj+JI1Rtri0gn7wGmboUOurUS67SIH6h
         mjGAgzjE+J00TyicWXEZaLhrqIXxEDkzWAzc0VvED7yfd+C+8u+cwa0fAuWYG04AgJVO
         s1zg==
X-Gm-Message-State: AOAM530Dyhj/fsnMHHgF4Dto7rPTkZlt94RhiU26H68c0e6j4Zxb7L0o
	LVWXDDBj29dbr05SjhoEUZaJRAfhzfE=
X-Google-Smtp-Source: ABdhPJyT9UqVfIhAtTM96uy+/s3bkntSE0jQKHwafHnI3xVxjYIKf9NL0rxmdS5y0dE9VlwJS+zJEg==
X-Received: by 2002:a2e:95cb:: with SMTP id y11mr937679ljh.129.1643956507945;
        Thu, 03 Feb 2022 22:35:07 -0800 (PST)
From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	sstabellini@kernel.org,
	oleksandr_tyshchenko@epam.com,
	volodymyr_babchuk@epam.com,
	artem_mygaiev@epam.com,
	roger.pau@citrix.com,
	jbeulich@suse.com,
	andrew.cooper3@citrix.com,
	george.dunlap@citrix.com,
	paul@xen.org,
	bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: [PATCH v6 06/13] vpci/header: implement guest BAR register handlers
Date: Fri,  4 Feb 2022 08:34:52 +0200
Message-Id: <20220204063459.680961-7-andr2000@gmail.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220204063459.680961-1-andr2000@gmail.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

Add relevant vpci register handlers when assigning PCI device to a domain
and remove those when de-assigning. This allows having different
handlers for different domains, e.g. hwdom and other guests.

Emulate guest BAR register values: this allows creating a guest view
of the registers and emulates size and properties probe as it is done
during PCI device enumeration by the guest.

All empty, IO and ROM BARs for guests are emulated by returning 0 on
reads and ignoring writes: this BARs are special with this respect as
their lower bits have special meaning, so returning default ~0 on read
may confuse guest OS.

Memory decoding is initially disabled when used by guests in order to
prevent the BAR being placed on top of a RAM region.

Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
---
Since v5:
- make sure that the guest set address has the same page offset
  as the physical address on the host
- remove guest_rom_{read|write} as those just implement the default
  behaviour of the registers not being handled
- adjusted comment for struct vpci.addr field
- add guest handlers for BARs which are not handled and will otherwise
  return ~0 on read and ignore writes. The BARs are special with this
  respect as their lower bits have special meaning, so returning ~0
  doesn't seem to be right
Since v4:
- updated commit message
- s/guest_addr/guest_reg
Since v3:
- squashed two patches: dynamic add/remove handlers and guest BAR
  handler implementation
- fix guest BAR read of the high part of a 64bit BAR (Roger)
- add error handling to vpci_assign_device
- s/dom%pd/%pd
- blank line before return
Since v2:
- remove unneeded ifdefs for CONFIG_HAS_VPCI_GUEST_SUPPORT as more code
  has been eliminated from being built on x86
Since v1:
 - constify struct pci_dev where possible
 - do not open code is_system_domain()
 - simplify some code3. simplify
 - use gdprintk + error code instead of gprintk
 - gate vpci_bar_{add|remove}_handlers with CONFIG_HAS_VPCI_GUEST_SUPPORT,
   so these do not get compiled for x86
 - removed unneeded is_system_domain check
 - re-work guest read/write to be much simpler and do more work on write
   than read which is expected to be called more frequently
 - removed one too obvious comment
---
 xen/drivers/vpci/header.c | 131 +++++++++++++++++++++++++++++++++-----
 xen/include/xen/vpci.h    |   3 +
 2 files changed, 118 insertions(+), 16 deletions(-)

diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c
index bd23c0274d48..2620a95ff35b 100644
--- a/xen/drivers/vpci/header.c
+++ b/xen/drivers/vpci/header.c
@@ -406,6 +406,81 @@ static void bar_write(const struct pci_dev *pdev, unsigned int reg,
     pci_conf_write32(pdev->sbdf, reg, val);
 }
 
+static void guest_bar_write(const struct pci_dev *pdev, unsigned int reg,
+                            uint32_t val, void *data)
+{
+    struct vpci_bar *bar = data;
+    bool hi = false;
+    uint64_t guest_reg = bar->guest_reg;
+
+    if ( bar->type == VPCI_BAR_MEM64_HI )
+    {
+        ASSERT(reg > PCI_BASE_ADDRESS_0);
+        bar--;
+        hi = true;
+    }
+    else
+    {
+        val &= PCI_BASE_ADDRESS_MEM_MASK;
+        val |= bar->type == VPCI_BAR_MEM32 ? PCI_BASE_ADDRESS_MEM_TYPE_32
+                                           : PCI_BASE_ADDRESS_MEM_TYPE_64;
+        val |= bar->prefetchable ? PCI_BASE_ADDRESS_MEM_PREFETCH : 0;
+    }
+
+    guest_reg &= ~(0xffffffffull << (hi ? 32 : 0));
+    guest_reg |= (uint64_t)val << (hi ? 32 : 0);
+
+    guest_reg &= ~(bar->size - 1) | ~PCI_BASE_ADDRESS_MEM_MASK;
+
+    /*
+     * Make sure that the guest set address has the same page offset
+     * as the physical address on the host or otherwise things won't work as
+     * expected.
+     */
+    if ( (guest_reg & (~PAGE_MASK & PCI_BASE_ADDRESS_MEM_MASK)) !=
+         (bar->addr & ~PAGE_MASK) )
+    {
+        gprintk(XENLOG_WARNING,
+                "%pp: ignored BAR %zu write with wrong page offset\n",
+                &pdev->sbdf, bar - pdev->vpci->header.bars + hi);
+        return;
+    }
+
+    bar->guest_reg = guest_reg;
+}
+
+static uint32_t guest_bar_read(const struct pci_dev *pdev, unsigned int reg,
+                               void *data)
+{
+    const struct vpci_bar *bar = data;
+    bool hi = false;
+
+    if ( bar->type == VPCI_BAR_MEM64_HI )
+    {
+        ASSERT(reg > PCI_BASE_ADDRESS_0);
+        bar--;
+        hi = true;
+    }
+
+    return bar->guest_reg >> (hi ? 32 : 0);
+}
+
+static uint32_t guest_bar_ignore_read(const struct pci_dev *pdev,
+                                      unsigned int reg, void *data)
+{
+    return 0;
+}
+
+static int bar_ignore_access(const struct pci_dev *pdev, unsigned int reg,
+                             struct vpci_bar *bar)
+{
+    if ( is_hardware_domain(pdev->domain) )
+        return 0;
+
+    return vpci_add_register(pdev->vpci, guest_bar_ignore_read, NULL,
+                             reg, 4, bar);
+}
+
 static void rom_write(const struct pci_dev *pdev, unsigned int reg,
                       uint32_t val, void *data)
 {
@@ -462,6 +537,7 @@ static int init_bars(struct pci_dev *pdev)
     struct vpci_header *header = &pdev->vpci->header;
     struct vpci_bar *bars = header->bars;
     int rc;
+    bool is_hwdom = is_hardware_domain(pdev->domain);
 
     switch ( pci_conf_read8(pdev->sbdf, PCI_HEADER_TYPE) & 0x7f )
     {
@@ -501,8 +577,10 @@ static int init_bars(struct pci_dev *pdev)
         if ( i && bars[i - 1].type == VPCI_BAR_MEM64_LO )
         {
             bars[i].type = VPCI_BAR_MEM64_HI;
-            rc = vpci_add_register(pdev->vpci, vpci_hw_read32, bar_write, reg,
-                                   4, &bars[i]);
+            rc = vpci_add_register(pdev->vpci,
+                                   is_hwdom ? vpci_hw_read32 : guest_bar_read,
+                                   is_hwdom ? bar_write : guest_bar_write,
+                                   reg, 4, &bars[i]);
             if ( rc )
             {
                 pci_conf_write16(pdev->sbdf, PCI_COMMAND, cmd);
@@ -516,6 +594,11 @@ static int init_bars(struct pci_dev *pdev)
         if ( (val & PCI_BASE_ADDRESS_SPACE) == PCI_BASE_ADDRESS_SPACE_IO )
         {
             bars[i].type = VPCI_BAR_IO;
+
+            rc = bar_ignore_access(pdev, reg, &bars[i]);
+            if ( rc )
+                return rc;
+
             continue;
         }
         if ( (val & PCI_BASE_ADDRESS_MEM_TYPE_MASK) ==
@@ -535,6 +618,11 @@ static int init_bars(struct pci_dev *pdev)
         if ( size == 0 )
         {
             bars[i].type = VPCI_BAR_EMPTY;
+
+            rc = bar_ignore_access(pdev, reg, &bars[i]);
+            if ( rc )
+                return rc;
+
             continue;
         }
 
@@ -542,8 +630,10 @@ static int init_bars(struct pci_dev *pdev)
         bars[i].size = size;
         bars[i].prefetchable = val & PCI_BASE_ADDRESS_MEM_PREFETCH;
 
-        rc = vpci_add_register(pdev->vpci, vpci_hw_read32, bar_write, reg, 4,
-                               &bars[i]);
+        rc = vpci_add_register(pdev->vpci,
+                               is_hwdom ? vpci_hw_read32 : guest_bar_read,
+                               is_hwdom ? bar_write : guest_bar_write,
+                               reg, 4, &bars[i]);
         if ( rc )
         {
             pci_conf_write16(pdev->sbdf, PCI_COMMAND, cmd);
@@ -551,22 +641,31 @@ static int init_bars(struct pci_dev *pdev)
         }
     }
 
-    /* Check expansion ROM. */
-    rc = pci_size_mem_bar(pdev->sbdf, rom_reg, &addr, &size, PCI_BAR_ROM);
-    if ( rc > 0 && size )
+    /* Check expansion ROM: we do not handle ROM for guests. */
+    if ( is_hwdom )
     {
-        struct vpci_bar *rom = &header->bars[num_bars];
+        rc = pci_size_mem_bar(pdev->sbdf, rom_reg, &addr, &size, PCI_BAR_ROM);
+        if ( rc > 0 && size )
+        {
+            struct vpci_bar *rom = &header->bars[num_bars];
 
-        rom->type = VPCI_BAR_ROM;
-        rom->size = size;
-        rom->addr = addr;
-        header->rom_enabled = pci_conf_read32(pdev->sbdf, rom_reg) &
-                              PCI_ROM_ADDRESS_ENABLE;
+            rom->type = VPCI_BAR_ROM;
+            rom->size = size;
+            rom->addr = addr;
+            header->rom_enabled = pci_conf_read32(pdev->sbdf, rom_reg) &
+                                  PCI_ROM_ADDRESS_ENABLE;
 
-        rc = vpci_add_register(pdev->vpci, vpci_hw_read32, rom_write, rom_reg,
-                               4, rom);
+            rc = vpci_add_register(pdev->vpci, vpci_hw_read32, rom_write,
+                                   rom_reg, 4, rom);
+            if ( rc )
+                rom->type = VPCI_BAR_EMPTY;
+        }
+    }
+    else
+    {
+        rc = bar_ignore_access(pdev, rom_reg, &header->bars[num_bars]);
         if ( rc )
-            rom->type = VPCI_BAR_EMPTY;
+            return rc;
     }
 
     return (cmd & PCI_COMMAND_MEMORY) ? modify_bars(pdev, cmd, false) : 0;
diff --git a/xen/include/xen/vpci.h b/xen/include/xen/vpci.h
index 246307e6f5d5..270d22b85653 100644
--- a/xen/include/xen/vpci.h
+++ b/xen/include/xen/vpci.h
@@ -66,7 +66,10 @@ struct vpci {
     struct vpci_header {
         /* Information about the PCI BARs of this device. */
         struct vpci_bar {
+            /* Physical (host) address. */
             uint64_t addr;
+            /* Guest view of the BAR: address and lower bits. */
+            uint64_t guest_reg;
             uint64_t size;
             enum {
                 VPCI_BAR_EMPTY,
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Feb 04 06:35:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 06:35:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265007.458299 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFsBY-0000Zp-Qn; Fri, 04 Feb 2022 06:35:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265007.458299; Fri, 04 Feb 2022 06:35:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFsBY-0000Xs-GL; Fri, 04 Feb 2022 06:35:08 +0000
Received: by outflank-mailman (input) for mailman id 265007;
 Fri, 04 Feb 2022 06:35:07 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Tguk=ST=gmail.com=andr2000@srs-se1.protection.inumbo.net>)
 id 1nFsBX-0008DX-0q
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 06:35:07 +0000
Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com
 [2a00:1450:4864:20::135])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 973fa44c-8584-11ec-8eb8-a37418f5ba1a;
 Fri, 04 Feb 2022 07:35:06 +0100 (CET)
Received: by mail-lf1-x135.google.com with SMTP id z4so10781574lft.3
 for <xen-devel@lists.xenproject.org>; Thu, 03 Feb 2022 22:35:06 -0800 (PST)
Received: from a2klaptop.localdomain ([185.199.97.5])
 by smtp.gmail.com with ESMTPSA id f34sm163027lfv.165.2022.02.03.22.35.04
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 03 Feb 2022 22:35:05 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 973fa44c-8584-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=7lOljSwfVLv7O1Qu1kbWEhEP6CpP7dXjj0XKQulfe6E=;
        b=Ck6BoSlnQgRISD6huKxphsjKoG7Euj2TC16HbLrf+oVTvsu+WKBI1c3kt8icPCERIB
         tkkWe/KesrqTP/q7HDoal4nGgy9m/6Ew9lCh7TrJWuYslrgjYmgtc6Ea5jRCMjJNj4LC
         kg7zdt2/kaKGbAzTDzeW0NoyYPbUHwutKjT6erIRJQAcUqAXsOSafT3+eODU1ugAQHtz
         Zgn5ZYMrhi45XL/tNMKmf75EiXt2FD+8gRN2p/FUE/n+37KE3I7BSLgLtjIB4Cz6vru+
         uXnAwU2XEzrjw0ZZYFZ7eJC2wBKSU2sap05DLurc4bQbHXDNegwVdVDrrSHmvXwPuWv7
         4RDQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=7lOljSwfVLv7O1Qu1kbWEhEP6CpP7dXjj0XKQulfe6E=;
        b=HBEiXgxoYa/kRj88N8yBGQgrz1YZXomxYTsTsW6YrvaVSI+DeYCHx6Um8vQuQp8BaB
         AN5IixKLuTiuC++5veHVRQQCPOxiW+cnl+26EXl+RHBSznp9gZuLs+HNLtG7PWoPlMSh
         QL72+Aq90rnz68+Sj2FR8oB/gRIbnV3g5qNCkTIZ/JfqPc5yidUqeZ/Z6JYQkTu37SiG
         93rKPSDtgcpUdZbvS8fHRjVuYYEwXpW9h8ZlI76fTJNs0zTJWCtgQQPcC2AgVHvzhReU
         9HuoIYdOmXdP5izkbAEkL3mDKPeZadBoh4RyP5Kwp1yex3zGpOl8mm89n7J6Ui+y1c3i
         WQeg==
X-Gm-Message-State: AOAM532NeogFBNrBMnfGXjBRheB1JCTN9TYaYGl1vEmpIKCUFE3GXMbH
	YQfzxkilMjbejVimjC/GsMVWnoVXSM8=
X-Google-Smtp-Source: ABdhPJyB6MQ7eonV8Yqfxf8f3gGfIt7kmJS1oIR+juotmd4GDOq+j/gxIoib7IA3nxTTvs39ppLLBg==
X-Received: by 2002:ac2:5186:: with SMTP id u6mr1392098lfi.519.1643956505619;
        Thu, 03 Feb 2022 22:35:05 -0800 (PST)
From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	sstabellini@kernel.org,
	oleksandr_tyshchenko@epam.com,
	volodymyr_babchuk@epam.com,
	artem_mygaiev@epam.com,
	roger.pau@citrix.com,
	jbeulich@suse.com,
	andrew.cooper3@citrix.com,
	george.dunlap@citrix.com,
	paul@xen.org,
	bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: [PATCH v6 04/13] vpci: restrict unhandled read/write operations for guests
Date: Fri,  4 Feb 2022 08:34:50 +0200
Message-Id: <20220204063459.680961-5-andr2000@gmail.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220204063459.680961-1-andr2000@gmail.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

A guest can read and write those registers which are not emulated and
have no respective vPCI handlers, so it can access the HW directly.
In order to prevent a guest from reads and writes from/to the unhandled
registers make sure only hardware domain can access HW directly and restrict
guests from doing so.

Suggested-by: Roger Pau Monné <roger.pau@citrix.com>
Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

---
New in v6
---
 xen/drivers/vpci/vpci.c | 32 +++++++++++++++++++++-----------
 1 file changed, 21 insertions(+), 11 deletions(-)

diff --git a/xen/drivers/vpci/vpci.c b/xen/drivers/vpci/vpci.c
index cb2ababa28e3..f8a93e61c08f 100644
--- a/xen/drivers/vpci/vpci.c
+++ b/xen/drivers/vpci/vpci.c
@@ -215,11 +215,15 @@ int vpci_remove_register(struct vpci *vpci, unsigned int offset,
 }
 
 /* Wrappers for performing reads/writes to the underlying hardware. */
-static uint32_t vpci_read_hw(pci_sbdf_t sbdf, unsigned int reg,
+static uint32_t vpci_read_hw(bool is_hwdom, pci_sbdf_t sbdf, unsigned int reg,
                              unsigned int size)
 {
     uint32_t data;
 
+    /* Guest domains are not allowed to read real hardware. */
+    if ( !is_hwdom )
+        return ~(uint32_t)0;
+
     switch ( size )
     {
     case 4:
@@ -260,9 +264,13 @@ static uint32_t vpci_read_hw(pci_sbdf_t sbdf, unsigned int reg,
     return data;
 }
 
-static void vpci_write_hw(pci_sbdf_t sbdf, unsigned int reg, unsigned int size,
-                          uint32_t data)
+static void vpci_write_hw(bool is_hwdom, pci_sbdf_t sbdf, unsigned int reg,
+                          unsigned int size, uint32_t data)
 {
+    /* Guest domains are not allowed to write real hardware. */
+    if ( !is_hwdom )
+        return;
+
     switch ( size )
     {
     case 4:
@@ -322,6 +330,7 @@ uint32_t vpci_read(pci_sbdf_t sbdf, unsigned int reg, unsigned int size)
     const struct vpci_register *r;
     unsigned int data_offset = 0;
     uint32_t data = ~(uint32_t)0;
+    bool is_hwdom = is_hardware_domain(d);
 
     if ( !size )
     {
@@ -332,13 +341,13 @@ uint32_t vpci_read(pci_sbdf_t sbdf, unsigned int reg, unsigned int size)
     /* Find the PCI dev matching the address. */
     pdev = pci_get_pdev_by_domain(d, sbdf.seg, sbdf.bus, sbdf.devfn);
     if ( !pdev )
-        return vpci_read_hw(sbdf, reg, size);
+        return vpci_read_hw(is_hwdom, sbdf, reg, size);
 
     spin_lock(&pdev->vpci_lock);
     if ( !pdev->vpci )
     {
         spin_unlock(&pdev->vpci_lock);
-        return vpci_read_hw(sbdf, reg, size);
+        return vpci_read_hw(is_hwdom, sbdf, reg, size);
     }
 
     /* Read from the hardware or the emulated register handlers. */
@@ -361,7 +370,7 @@ uint32_t vpci_read(pci_sbdf_t sbdf, unsigned int reg, unsigned int size)
         {
             /* Heading gap, read partial content from hardware. */
             read_size = r->offset - emu.offset;
-            val = vpci_read_hw(sbdf, emu.offset, read_size);
+            val = vpci_read_hw(is_hwdom, sbdf, emu.offset, read_size);
             data = merge_result(data, val, read_size, data_offset);
             data_offset += read_size;
         }
@@ -387,7 +396,7 @@ uint32_t vpci_read(pci_sbdf_t sbdf, unsigned int reg, unsigned int size)
     if ( data_offset < size )
     {
         /* Tailing gap, read the remaining. */
-        uint32_t tmp_data = vpci_read_hw(sbdf, reg + data_offset,
+        uint32_t tmp_data = vpci_read_hw(is_hwdom, sbdf, reg + data_offset,
                                          size - data_offset);
 
         data = merge_result(data, tmp_data, size - data_offset, data_offset);
@@ -430,6 +439,7 @@ void vpci_write(pci_sbdf_t sbdf, unsigned int reg, unsigned int size,
     const struct vpci_register *r;
     unsigned int data_offset = 0;
     const unsigned long *ro_map = pci_get_ro_map(sbdf.seg);
+    bool is_hwdom = is_hardware_domain(d);
 
     if ( !size )
     {
@@ -448,7 +458,7 @@ void vpci_write(pci_sbdf_t sbdf, unsigned int reg, unsigned int size,
     pdev = pci_get_pdev_by_domain(d, sbdf.seg, sbdf.bus, sbdf.devfn);
     if ( !pdev )
     {
-        vpci_write_hw(sbdf, reg, size, data);
+        vpci_write_hw(is_hwdom, sbdf, reg, size, data);
         return;
     }
 
@@ -456,7 +466,7 @@ void vpci_write(pci_sbdf_t sbdf, unsigned int reg, unsigned int size,
     if ( !pdev->vpci )
     {
         spin_unlock(&pdev->vpci_lock);
-        vpci_write_hw(sbdf, reg, size, data);
+        vpci_write_hw(is_hwdom, sbdf, reg, size, data);
         return;
     }
 
@@ -479,7 +489,7 @@ void vpci_write(pci_sbdf_t sbdf, unsigned int reg, unsigned int size,
         if ( emu.offset < r->offset )
         {
             /* Heading gap, write partial content to hardware. */
-            vpci_write_hw(sbdf, emu.offset, r->offset - emu.offset,
+            vpci_write_hw(is_hwdom, sbdf, emu.offset, r->offset - emu.offset,
                           data >> (data_offset * 8));
             data_offset += r->offset - emu.offset;
         }
@@ -498,7 +508,7 @@ void vpci_write(pci_sbdf_t sbdf, unsigned int reg, unsigned int size,
 
     if ( data_offset < size )
         /* Tailing gap, write the remaining. */
-        vpci_write_hw(sbdf, reg + data_offset, size - data_offset,
+        vpci_write_hw(is_hwdom, sbdf, reg + data_offset, size - data_offset,
                       data >> (data_offset * 8));
 }
 
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Feb 04 06:35:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 06:35:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265013.458362 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFsBg-0002K8-Bx; Fri, 04 Feb 2022 06:35:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265013.458362; Fri, 04 Feb 2022 06:35:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFsBf-0002Gc-DU; Fri, 04 Feb 2022 06:35:15 +0000
Received: by outflank-mailman (input) for mailman id 265013;
 Fri, 04 Feb 2022 06:35:14 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Tguk=ST=gmail.com=andr2000@srs-se1.protection.inumbo.net>)
 id 1nFsBd-0008DW-QM
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 06:35:13 +0000
Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com
 [2a00:1450:4864:20::130])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9b59e52f-8584-11ec-8f75-fffcc8bd4f1a;
 Fri, 04 Feb 2022 07:35:13 +0100 (CET)
Received: by mail-lf1-x130.google.com with SMTP id z19so10659451lfq.13
 for <xen-devel@lists.xenproject.org>; Thu, 03 Feb 2022 22:35:13 -0800 (PST)
Received: from a2klaptop.localdomain ([185.199.97.5])
 by smtp.gmail.com with ESMTPSA id f34sm163027lfv.165.2022.02.03.22.35.11
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 03 Feb 2022 22:35:12 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9b59e52f-8584-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=FX99xFROYnnqXaxsrJbKwTBFYrf06bSi150/1Wew964=;
        b=cfEcGqDRT0H+u76W/kO7xJphKRiV6ogCbh4ol7qeJnPisV7JGCgkiVR1sSNGS4CRyM
         mh8fidCB4ulKXq5h9Smv+lSr4tSwufdbBKxBOxJcPOTv2tF3ohaLs5FRYsAZdqp/QwGU
         REu1w4eB5e1E3XbosGxE+NjRBsKrwEngfwtIf+UM+sTF2kwFk1mri4BqUPaT8yW/CgwY
         wLUctjH9xQn93iUyRBgB6cYJTIQC+GW/4RUPonIRmQDjYfRYEFd04iwKj2rr3TRN0hxF
         P6XUv5qj5Tv+x6thu/brLBbh6YBahufDoBOWqApfgdyuLFuffR4Tc94uaQ8eiDyUEQfX
         9OJA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=FX99xFROYnnqXaxsrJbKwTBFYrf06bSi150/1Wew964=;
        b=Cjez70YkqzDjVsQK8Msb0C4Am3DQ2qpnAuwFVOTpzBIQSa6FTWpCU9DUsi0ZHcu/XK
         tbzMPBMFeVhQ9ZyGKjhu4/K6cFyJh9DFojCqYHMQnC00uGXnL5dBumqXXX1vS0XNFgS9
         OwsuvmRhTbebroJN5z2CCeJPabLD/TNlMgT4ioqS1S8De9AhDF6uPHhXGTiuFU0FRjQQ
         XJM9ZCSs0GTOJANL/nCnFo5ONcEOvCcAC6XtHl1SpGuY+jpXoIlbdI791HrQMmOo1uI+
         2W1hHPkhwJxTe8aqHJAIa7tnLSFJWvOiCqxHCFWO2VZhphMXMgSS9LLUFn7fLGOxyacp
         FDig==
X-Gm-Message-State: AOAM531tcuQp3moQqirUboK3mf56If3i32UNdnvRxeFhmMdvKFW0tVyr
	0Af1W6h/iD9hcXBhCXJLozp1Q3syffY=
X-Google-Smtp-Source: ABdhPJwon9dynpKYpjG0DMccYwOaOzKCe/ToTI783e4Ajn2KtH8i/5XPF0PCpVRt0DG4lKESp5cs0g==
X-Received: by 2002:a05:6512:1082:: with SMTP id j2mr1237420lfg.371.1643956512552;
        Thu, 03 Feb 2022 22:35:12 -0800 (PST)
From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	sstabellini@kernel.org,
	oleksandr_tyshchenko@epam.com,
	volodymyr_babchuk@epam.com,
	artem_mygaiev@epam.com,
	roger.pau@citrix.com,
	jbeulich@suse.com,
	andrew.cooper3@citrix.com,
	george.dunlap@citrix.com,
	paul@xen.org,
	bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: [PATCH v6 10/13] vpci/header: reset the command register when adding devices
Date: Fri,  4 Feb 2022 08:34:56 +0200
Message-Id: <20220204063459.680961-11-andr2000@gmail.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220204063459.680961-1-andr2000@gmail.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

Reset the command register when assigning a PCI device to a guest:
according to the PCI spec the PCI_COMMAND register is typically all 0's
after reset.

Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
---
Since v5:
- updated commit message
Since v1:
 - do not write 0 to the command register, but respect host settings.
---
 xen/drivers/vpci/header.c | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c
index 33d8c15ae6e8..407fa2fc4749 100644
--- a/xen/drivers/vpci/header.c
+++ b/xen/drivers/vpci/header.c
@@ -454,8 +454,7 @@ static void cmd_write(const struct pci_dev *pdev, unsigned int reg,
         pci_conf_write16(pdev->sbdf, reg, cmd);
 }
 
-static void guest_cmd_write(const struct pci_dev *pdev, unsigned int reg,
-                            uint32_t cmd, void *data)
+static uint32_t emulate_cmd_reg(const struct pci_dev *pdev, uint32_t cmd)
 {
     /* TODO: Add proper emulation for all bits of the command register. */
 
@@ -467,7 +466,13 @@ static void guest_cmd_write(const struct pci_dev *pdev, unsigned int reg,
     }
 #endif
 
-    cmd_write(pdev, reg, cmd, data);
+    return cmd;
+}
+
+static void guest_cmd_write(const struct pci_dev *pdev, unsigned int reg,
+                            uint32_t cmd, void *data)
+{
+    cmd_write(pdev, reg, emulate_cmd_reg(pdev, cmd), data);
 }
 
 static void bar_write(const struct pci_dev *pdev, unsigned int reg,
@@ -676,6 +681,10 @@ static int init_bars(struct pci_dev *pdev)
         return -EOPNOTSUPP;
     }
 
+    /* Reset the command register for the guest. */
+    if ( !is_hwdom )
+        pci_conf_write16(pdev->sbdf, PCI_COMMAND, emulate_cmd_reg(pdev, 0));
+
     /* Setup a handler for the command register. */
     rc = vpci_add_register(pdev->vpci, vpci_hw_read16,
                            is_hwdom ? cmd_write : guest_cmd_write,
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Feb 04 06:35:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 06:35:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265014.458370 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFsBh-0002hl-QP; Fri, 04 Feb 2022 06:35:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265014.458370; Fri, 04 Feb 2022 06:35:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFsBh-0002dg-El; Fri, 04 Feb 2022 06:35:17 +0000
Received: by outflank-mailman (input) for mailman id 265014;
 Fri, 04 Feb 2022 06:35:15 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Tguk=ST=gmail.com=andr2000@srs-se1.protection.inumbo.net>)
 id 1nFsBf-0008DX-6C
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 06:35:15 +0000
Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com
 [2a00:1450:4864:20::130])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9c0d2cc9-8584-11ec-8eb8-a37418f5ba1a;
 Fri, 04 Feb 2022 07:35:14 +0100 (CET)
Received: by mail-lf1-x130.google.com with SMTP id o12so10664148lfg.12
 for <xen-devel@lists.xenproject.org>; Thu, 03 Feb 2022 22:35:14 -0800 (PST)
Received: from a2klaptop.localdomain ([185.199.97.5])
 by smtp.gmail.com with ESMTPSA id f34sm163027lfv.165.2022.02.03.22.35.12
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 03 Feb 2022 22:35:13 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9c0d2cc9-8584-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=tGFLOQCwkEQFlI9mFVvLvlv0pMnFdRny8N7SLfH9TJA=;
        b=YlgiD5lGb3evZ6RR1LePZhPhqzkgUVHIPb2Gy3O72gERgeDAmwDTYaB0XUarTQgsD8
         pmdw7nrr7tOpf/VkdnbF851kb5Y8xpkUCSOphdAW69ua0+sdexi8ht29J6xt3629QdYw
         8q421az1QnqIpTccWIu2jw9mRqZwIRJJQr9fjZjEvRHqTXgN99wxLu6k7zzlJ+iZexcK
         j131pVe1Bn0fM1phTaY1dA0B3H4DUjCi07cAHQi7H+H/6xGbYmNtrY/+dguki/2iv26P
         ps40BdLcc/ktXwgv/LnZ8VTYgZaZEO5Ys52gDX5rQ7GrNIjDR46fhSUVc4ThlvEPF0Vf
         kRFw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=tGFLOQCwkEQFlI9mFVvLvlv0pMnFdRny8N7SLfH9TJA=;
        b=3OSLR+PccHK9fCyIlslFJKh+x68f924fQVGXqIcwpFy68BovlCqqaRP9jKCunkKBna
         zw7Qok2HaYc3glIJ3iwYzRt+LV8XZwz1waeFrsFvxuD1f+eO0/Kd0EtgDbZmkdT5jkOf
         RwwWeEnBHB2jRm9qqlsNqB+rBDmYvE1IsODGRTbz+DDFD2/V4iRC+HXnJ6mz+wBXfnWS
         WzYO822evOxIbpjB2ZlacN44+dYukA0I0b8sWkxxoDhkf8l70WlRyn6j+yApRuMupTIc
         knl1hqKHhV55AQdpsCP5fHHxNAkLfmA6X/u6pLK1WKvjI5gHoA2PuQ/YN/JEKFndbbRS
         Ztjw==
X-Gm-Message-State: AOAM530G2eU6sZ2vjGp6aIC62W9pCotfYBWy9qe2s03BqwTjMU+MqpBB
	wT3KG0hBdaK9Btd7cNgv+sHlSD17jgo=
X-Google-Smtp-Source: ABdhPJwPzBAmRPwkr5ocrvbHVI7IaKNMChAL/CL0c1126BAXRRe8+v+tzkGTEQ3jLHc1eLnLZCqIZg==
X-Received: by 2002:a05:6512:683:: with SMTP id t3mr1289026lfe.61.1643956513698;
        Thu, 03 Feb 2022 22:35:13 -0800 (PST)
From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	sstabellini@kernel.org,
	oleksandr_tyshchenko@epam.com,
	volodymyr_babchuk@epam.com,
	artem_mygaiev@epam.com,
	roger.pau@citrix.com,
	jbeulich@suse.com,
	andrew.cooper3@citrix.com,
	george.dunlap@citrix.com,
	paul@xen.org,
	bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: [PATCH v6 11/13] vpci: add initial support for virtual PCI bus topology
Date: Fri,  4 Feb 2022 08:34:57 +0200
Message-Id: <20220204063459.680961-12-andr2000@gmail.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220204063459.680961-1-andr2000@gmail.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

Assign SBDF to the PCI devices being passed through with bus 0.
The resulting topology is where PCIe devices reside on the bus 0 of the
root complex itself (embedded endpoints).
This implementation is limited to 32 devices which are allowed on
a single PCI bus.

Please note, that at the moment only function 0 of a multifunction
device can be passed through.

Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
---
Since v5:
- s/vpci_add_virtual_device/add_virtual_device and make it static
- call add_virtual_device from vpci_assign_device and do not use
  REGISTER_VPCI_INIT machinery
- add pcidevs_locked ASSERT
- use DECLARE_BITMAP for vpci_dev_assigned_map
Since v4:
- moved and re-worked guest sbdf initializers
- s/set_bit/__set_bit
- s/clear_bit/__clear_bit
- minor comment fix s/Virtual/Guest/
- added VPCI_MAX_VIRT_DEV constant (PCI_SLOT(~0) + 1) which will be used
  later for counting the number of MMIO handlers required for a guest
  (Julien)
Since v3:
 - make use of VPCI_INIT
 - moved all new code to vpci.c which belongs to it
 - changed open-coded 31 to PCI_SLOT(~0)
 - added comments and code to reject multifunction devices with
   functions other than 0
 - updated comment about vpci_dev_next and made it unsigned int
 - implement roll back in case of error while assigning/deassigning devices
 - s/dom%pd/%pd
Since v2:
 - remove casts that are (a) malformed and (b) unnecessary
 - add new line for better readability
 - remove CONFIG_HAS_VPCI_GUEST_SUPPORT ifdef's as the relevant vPCI
    functions are now completely gated with this config
 - gate common code with CONFIG_HAS_VPCI_GUEST_SUPPORT
New in v2
---
 xen/drivers/vpci/vpci.c | 74 +++++++++++++++++++++++++++++++++++++++--
 xen/include/xen/sched.h |  8 +++++
 xen/include/xen/vpci.h  | 11 ++++++
 3 files changed, 91 insertions(+), 2 deletions(-)

diff --git a/xen/drivers/vpci/vpci.c b/xen/drivers/vpci/vpci.c
index 3177f13c1c22..7d422d11f83d 100644
--- a/xen/drivers/vpci/vpci.c
+++ b/xen/drivers/vpci/vpci.c
@@ -89,6 +89,9 @@ int vpci_add_handlers(struct pci_dev *pdev)
         return -ENOMEM;
 
     INIT_LIST_HEAD(&vpci->handlers);
+#ifdef CONFIG_HAS_VPCI_GUEST_SUPPORT
+    vpci->guest_sbdf.sbdf = ~0;
+#endif
 
     spin_lock(&pdev->vpci_lock);
     pdev->vpci = vpci;
@@ -114,6 +117,57 @@ int vpci_add_handlers(struct pci_dev *pdev)
 }
 
 #ifdef CONFIG_HAS_VPCI_GUEST_SUPPORT
+static int add_virtual_device(struct pci_dev *pdev)
+{
+    struct domain *d = pdev->domain;
+    pci_sbdf_t sbdf = { 0 };
+    unsigned long new_dev_number;
+
+    if ( is_hardware_domain(d) )
+        return 0;
+
+    ASSERT(pcidevs_locked());
+
+    /*
+     * Each PCI bus supports 32 devices/slots at max or up to 256 when
+     * there are multi-function ones which are not yet supported.
+     */
+    if ( pdev->info.is_extfn )
+    {
+        gdprintk(XENLOG_ERR, "%pp: only function 0 passthrough supported\n",
+                 &pdev->sbdf);
+        return -EOPNOTSUPP;
+    }
+
+    new_dev_number = find_first_zero_bit(d->vpci_dev_assigned_map,
+                                         VPCI_MAX_VIRT_DEV);
+    if ( new_dev_number >= VPCI_MAX_VIRT_DEV )
+        return -ENOSPC;
+
+    __set_bit(new_dev_number, &d->vpci_dev_assigned_map);
+
+    /*
+     * Both segment and bus number are 0:
+     *  - we emulate a single host bridge for the guest, e.g. segment 0
+     *  - with bus 0 the virtual devices are seen as embedded
+     *    endpoints behind the root complex
+     *
+     * TODO: add support for multi-function devices.
+     */
+    sbdf.devfn = PCI_DEVFN(new_dev_number, 0);
+    pdev->vpci->guest_sbdf = sbdf;
+
+    return 0;
+
+}
+
+static void vpci_remove_virtual_device(struct domain *d,
+                                       const struct pci_dev *pdev)
+{
+    __clear_bit(pdev->vpci->guest_sbdf.dev, &d->vpci_dev_assigned_map);
+    pdev->vpci->guest_sbdf.sbdf = ~0;
+}
+
 /* Notify vPCI that device is assigned to guest. */
 int vpci_assign_device(struct domain *d, struct pci_dev *pdev)
 {
@@ -124,8 +178,16 @@ int vpci_assign_device(struct domain *d, struct pci_dev *pdev)
 
     rc = vpci_add_handlers(pdev);
     if ( rc )
-        vpci_deassign_device(d, pdev);
+        goto fail;
+
+    rc = add_virtual_device(pdev);
+    if ( rc )
+        goto fail;
 
+    return 0;
+
+ fail:
+    vpci_deassign_device(d, pdev);
     return rc;
 }
 
@@ -135,7 +197,15 @@ void vpci_deassign_device(struct domain *d, struct pci_dev *pdev)
     if ( !has_vpci(d) )
         return;
 
-    vpci_remove_device(pdev);
+    spin_lock(&pdev->vpci_lock);
+    if ( !pdev->vpci )
+        goto done;
+
+    vpci_remove_virtual_device(d, pdev);
+    vpci_remove_device_locked(pdev);
+
+ done:
+    spin_unlock(&pdev->vpci_lock);
 }
 #endif /* CONFIG_HAS_VPCI_GUEST_SUPPORT */
 
diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
index 37f78cc4c4c9..3c25e265eaa8 100644
--- a/xen/include/xen/sched.h
+++ b/xen/include/xen/sched.h
@@ -444,6 +444,14 @@ struct domain
 
 #ifdef CONFIG_HAS_PCI
     struct list_head pdev_list;
+#ifdef CONFIG_HAS_VPCI_GUEST_SUPPORT
+    /*
+     * The bitmap which shows which device numbers are already used by the
+     * virtual PCI bus topology and is used to assign a unique SBDF to the
+     * next passed through virtual PCI device.
+     */
+    DECLARE_BITMAP(vpci_dev_assigned_map, VPCI_MAX_VIRT_DEV);
+#endif
 #endif
 
 #ifdef CONFIG_HAS_PASSTHROUGH
diff --git a/xen/include/xen/vpci.h b/xen/include/xen/vpci.h
index f1f49db959c7..1f04d34a2369 100644
--- a/xen/include/xen/vpci.h
+++ b/xen/include/xen/vpci.h
@@ -21,6 +21,13 @@ typedef int vpci_register_init_t(struct pci_dev *dev);
 
 #define VPCI_ECAM_BDF(addr)     (((addr) & 0x0ffff000) >> 12)
 
+/*
+ * Maximum number of devices supported by the virtual bus topology:
+ * each PCI bus supports 32 devices/slots at max or up to 256 when
+ * there are multi-function ones which are not yet supported.
+ */
+#define VPCI_MAX_VIRT_DEV       (PCI_SLOT(~0) + 1)
+
 #define REGISTER_VPCI_INIT(x, p)                \
   static vpci_register_init_t *const x##_entry  \
                __used_section(".data.vpci." p) = x
@@ -140,6 +147,10 @@ struct vpci {
             struct vpci_arch_msix_entry arch;
         } entries[];
     } *msix;
+#ifdef CONFIG_HAS_VPCI_GUEST_SUPPORT
+    /* Guest SBDF of the device. */
+    pci_sbdf_t guest_sbdf;
+#endif
 #endif
 };
 
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Feb 04 06:35:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 06:35:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265015.458380 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFsBj-0002vd-Gw; Fri, 04 Feb 2022 06:35:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265015.458380; Fri, 04 Feb 2022 06:35:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFsBi-0002sJ-Mz; Fri, 04 Feb 2022 06:35:18 +0000
Received: by outflank-mailman (input) for mailman id 265015;
 Fri, 04 Feb 2022 06:35:16 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Tguk=ST=gmail.com=andr2000@srs-se1.protection.inumbo.net>)
 id 1nFsBg-0008DX-6Q
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 06:35:16 +0000
Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com
 [2a00:1450:4864:20::131])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9cb91094-8584-11ec-8eb8-a37418f5ba1a;
 Fri, 04 Feb 2022 07:35:15 +0100 (CET)
Received: by mail-lf1-x131.google.com with SMTP id i34so10811258lfv.2
 for <xen-devel@lists.xenproject.org>; Thu, 03 Feb 2022 22:35:15 -0800 (PST)
Received: from a2klaptop.localdomain ([185.199.97.5])
 by smtp.gmail.com with ESMTPSA id f34sm163027lfv.165.2022.02.03.22.35.13
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 03 Feb 2022 22:35:14 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9cb91094-8584-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=hIaF8lkau0N10gIhOfyFkvM+7dDNU2pFNiSNz4Bb4DM=;
        b=BQx5h1U1XzMedlxkvKRWbAoeeDDDuxCa+NYZCC5EXXKvNVb57WykA7geNU2PwwfOZq
         9boVsP/FKrdj5QijI5UOmqpiJ/108TlbnER9IZhZmy0RGl5IOE57CosP9uDTvIDuYDbo
         zHhfShTjr4qt57OIjhKs9SBko9C9BKzPn/3mYPs2jIZxyyICCymb8RGNt8go4CY8Z1Ok
         zqFmtbBlD3fbVKWSpC72QVUh+9sVJeSCaazwwX1bSLiwuIQHtE6UPH88FeAYFv/JNfLI
         d2nZcYcEhbTMz7QDE7HkDz/rjBl9F5R4X+98fpvxVKMfjXD2MOxz+NjAY1Zg3+QrrepP
         mIow==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=hIaF8lkau0N10gIhOfyFkvM+7dDNU2pFNiSNz4Bb4DM=;
        b=pzyEKVUMrHCayfrEwdRh9Jj5XXF2LSwKvnNWzy8vUVrrEokCJnW1xFL0sBcEkGuFQY
         WgONp4bO5QS10r49Vu+YLyfaIlsrh3iLpWJjPXnb90qJNOgIeRDwJkhfRGR++Ca2FTHT
         CqivcHGv3YCoWelvdVK2PhXaqThz5Di1GGCv+IMFWLIPpxkZFFxnVijyovIDG29o93y6
         yhVI2aHj3LKgPj+urdFcui40mUppNBru9Bfbf6Lu7MimivbzKJkwegXARuI4vqaIXazK
         27OEJxFme4eZD3UsvAXaJ/8XEuu35Ofk0gV1nI3pWWp/3zVwGRkkfw1sQ6AYZri70h4m
         h9cg==
X-Gm-Message-State: AOAM533fIkCFEKVIDhuO6yVSKqE+lPh27A0VD26PBWehTmA7ofEI1ETf
	YDJRbJ8oO0EMhzV23I81smev6LTNSfw=
X-Google-Smtp-Source: ABdhPJzInhEwoaUav36B1b6oDvhcMTtbaYic6ktmXAldzUwMXmLO5P4HKZ2/mUC2v+QPU1VKXYIkVw==
X-Received: by 2002:a05:6512:1697:: with SMTP id bu23mr1338331lfb.392.1643956514817;
        Thu, 03 Feb 2022 22:35:14 -0800 (PST)
From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	sstabellini@kernel.org,
	oleksandr_tyshchenko@epam.com,
	volodymyr_babchuk@epam.com,
	artem_mygaiev@epam.com,
	roger.pau@citrix.com,
	jbeulich@suse.com,
	andrew.cooper3@citrix.com,
	george.dunlap@citrix.com,
	paul@xen.org,
	bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: [PATCH v6 12/13] xen/arm: translate virtual PCI bus topology for guests
Date: Fri,  4 Feb 2022 08:34:58 +0200
Message-Id: <20220204063459.680961-13-andr2000@gmail.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220204063459.680961-1-andr2000@gmail.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

There are three  originators for the PCI configuration space access:
1. The domain that owns physical host bridge: MMIO handlers are
there so we can update vPCI register handlers with the values
written by the hardware domain, e.g. physical view of the registers
vs guest's view on the configuration space.
2. Guest access to the passed through PCI devices: we need to properly
map virtual bus topology to the physical one, e.g. pass the configuration
space access to the corresponding physical devices.
3. Emulated host PCI bridge access. It doesn't exist in the physical
topology, e.g. it can't be mapped to some physical host bridge.
So, all access to the host bridge itself needs to be trapped and
emulated.

Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
---
Since v5:
- add vpci_translate_virtual_device for #ifndef CONFIG_HAS_VPCI_GUEST_SUPPORT
  case to simplify ifdefery
- add ASSERT(!is_hardware_domain(d)); to vpci_translate_virtual_device
- reset output register on failed virtual SBDF translation
Since v4:
- indentation fixes
- constify struct domain
- updated commit message
- updates to the new locking scheme (pdev->vpci_lock)
Since v3:
- revisit locking
- move code to vpci.c
Since v2:
 - pass struct domain instead of struct vcpu
 - constify arguments where possible
 - gate relevant code with CONFIG_HAS_VPCI_GUEST_SUPPORT
New in v2
---
 xen/arch/arm/vpci.c     | 17 +++++++++++++++++
 xen/drivers/vpci/vpci.c | 29 +++++++++++++++++++++++++++++
 xen/include/xen/vpci.h  |  7 +++++++
 3 files changed, 53 insertions(+)

diff --git a/xen/arch/arm/vpci.c b/xen/arch/arm/vpci.c
index a9fc5817f94e..84b2b068a0fe 100644
--- a/xen/arch/arm/vpci.c
+++ b/xen/arch/arm/vpci.c
@@ -41,6 +41,16 @@ static int vpci_mmio_read(struct vcpu *v, mmio_info_t *info,
     /* data is needed to prevent a pointer cast on 32bit */
     unsigned long data;
 
+    /*
+     * For the passed through devices we need to map their virtual SBDF
+     * to the physical PCI device being passed through.
+     */
+    if ( !bridge && !vpci_translate_virtual_device(v->domain, &sbdf) )
+    {
+        *r = ~0ul;
+        return 1;
+    }
+
     if ( vpci_ecam_read(sbdf, ECAM_REG_OFFSET(info->gpa),
                         1U << info->dabt.size, &data) )
     {
@@ -59,6 +69,13 @@ static int vpci_mmio_write(struct vcpu *v, mmio_info_t *info,
     struct pci_host_bridge *bridge = p;
     pci_sbdf_t sbdf = vpci_sbdf_from_gpa(bridge, info->gpa);
 
+    /*
+     * For the passed through devices we need to map their virtual SBDF
+     * to the physical PCI device being passed through.
+     */
+    if ( !bridge && !vpci_translate_virtual_device(v->domain, &sbdf) )
+        return 1;
+
     return vpci_ecam_write(sbdf, ECAM_REG_OFFSET(info->gpa),
                            1U << info->dabt.size, r);
 }
diff --git a/xen/drivers/vpci/vpci.c b/xen/drivers/vpci/vpci.c
index 7d422d11f83d..070db7391391 100644
--- a/xen/drivers/vpci/vpci.c
+++ b/xen/drivers/vpci/vpci.c
@@ -168,6 +168,35 @@ static void vpci_remove_virtual_device(struct domain *d,
     pdev->vpci->guest_sbdf.sbdf = ~0;
 }
 
+/*
+ * Find the physical device which is mapped to the virtual device
+ * and translate virtual SBDF to the physical one.
+ */
+bool vpci_translate_virtual_device(const struct domain *d, pci_sbdf_t *sbdf)
+{
+    struct pci_dev *pdev;
+
+    ASSERT(!is_hardware_domain(d));
+
+    for_each_pdev( d, pdev )
+    {
+        bool found;
+
+        spin_lock(&pdev->vpci_lock);
+        found = pdev->vpci && (pdev->vpci->guest_sbdf.sbdf == sbdf->sbdf);
+        spin_unlock(&pdev->vpci_lock);
+
+        if ( found )
+        {
+            /* Replace guest SBDF with the physical one. */
+            *sbdf = pdev->sbdf;
+            return true;
+        }
+    }
+
+    return false;
+}
+
 /* Notify vPCI that device is assigned to guest. */
 int vpci_assign_device(struct domain *d, struct pci_dev *pdev)
 {
diff --git a/xen/include/xen/vpci.h b/xen/include/xen/vpci.h
index 1f04d34a2369..f6eb9f2051af 100644
--- a/xen/include/xen/vpci.h
+++ b/xen/include/xen/vpci.h
@@ -271,6 +271,7 @@ static inline bool __must_check vpci_process_pending(struct vcpu *v)
 /* Notify vPCI that device is assigned/de-assigned to/from guest. */
 int vpci_assign_device(struct domain *d, struct pci_dev *pdev);
 void vpci_deassign_device(struct domain *d, struct pci_dev *pdev);
+bool vpci_translate_virtual_device(const struct domain *d, pci_sbdf_t *sbdf);
 #else
 static inline int vpci_assign_device(struct domain *d, struct pci_dev *pdev)
 {
@@ -280,6 +281,12 @@ static inline int vpci_assign_device(struct domain *d, struct pci_dev *pdev)
 static inline void vpci_deassign_device(struct domain *d, struct pci_dev *pdev)
 {
 };
+
+static inline bool vpci_translate_virtual_device(const struct domain *d,
+                                                 pci_sbdf_t *sbdf)
+{
+    return false;
+}
 #endif
 
 #endif
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Feb 04 06:35:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 06:35:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265016.458386 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFsBl-0003Ff-62; Fri, 04 Feb 2022 06:35:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265016.458386; Fri, 04 Feb 2022 06:35:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFsBk-0003BJ-E5; Fri, 04 Feb 2022 06:35:20 +0000
Received: by outflank-mailman (input) for mailman id 265016;
 Fri, 04 Feb 2022 06:35:17 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Tguk=ST=gmail.com=andr2000@srs-se1.protection.inumbo.net>)
 id 1nFsBh-0008DX-6q
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 06:35:17 +0000
Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com
 [2a00:1450:4864:20::229])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9d5fbd2f-8584-11ec-8eb8-a37418f5ba1a;
 Fri, 04 Feb 2022 07:35:16 +0100 (CET)
Received: by mail-lj1-x229.google.com with SMTP id o17so7206043ljp.1
 for <xen-devel@lists.xenproject.org>; Thu, 03 Feb 2022 22:35:16 -0800 (PST)
Received: from a2klaptop.localdomain ([185.199.97.5])
 by smtp.gmail.com with ESMTPSA id f34sm163027lfv.165.2022.02.03.22.35.14
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 03 Feb 2022 22:35:15 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9d5fbd2f-8584-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=qo4xVV2IOrLU3ayXp+CLSEr+b1lCwCF0zrFQg2DftNA=;
        b=DW8T5+dKfc/hN9mnCARyk2APUMIqiKK4CcqjIN0Whced814pQ8sYHC/r342zGCp7Gw
         IBwogyUJD9Ll9XN/ABcSgRxIMazNdqgGYw6lOmF65gWB6mOnkOmc0Xgmhk34CQccPhNo
         GtIPYj5MTo4WiqPdTXiYUr2UdjamJFF8aitaHwtOtk2vcf/i52oQls8Sya0/R0AaXkAD
         CG0OaC/BimKmkIEF0RssbmfnB6KDFgkf0q/P4ZQO+yo0tTnJ4zF8wscY/MxfJWeKFx02
         rbq+wZ/wpS2fq4B4fhEQYjVdTqlPpD0+jelO1aoh1jAhQbiFmzuHbzY9AGUMIDU4O5D+
         ux1g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=qo4xVV2IOrLU3ayXp+CLSEr+b1lCwCF0zrFQg2DftNA=;
        b=maYQAknmYI3sU1lx/8bDsOmWYL6R0ezSWud7+oY2B3r4w3KJvkACpfyzb9dh8EGptg
         M3rd+t1mIV1vMUb0Ud1f332jOk4eugoERLoILfQWj8jKQVZptrVIdvGeXbpuegD2Sswn
         uIRLYRc6QXerWKAE8LEDxMwUIP83o1w9rLvyoC67uO9O8TF9XQ2Lrs3QljIuYzRXVqW0
         MfTJoyy4kLtK2AKHGPTuuuuO/PBTkfzijiRuZdaJQ5JpGKSJTWTbuwDUSkwpVb7dRFf7
         Jq3MztAZbU9NSzR7OBS5Erg3oOgg96w97bT+IV4IDaR5G4ZWKuazTGV/6yGkPwbnvZCL
         XRxw==
X-Gm-Message-State: AOAM531hlDQUhcnH/lpWWjcPQxvq3UPhZy7CYUKvs3Fj6lg+jiYQ//bi
	l1wwBXmDBLkjs3tfyH8qoJ19xW0lioI=
X-Google-Smtp-Source: ABdhPJwWj2gtNHZB0Bqn6McKeBHaWxFGAxFvXVwELlj4nHdWpNKInEIKgGnAdCyCL0new9sD8fO1VA==
X-Received: by 2002:a2e:82c4:: with SMTP id n4mr893394ljh.163.1643956515947;
        Thu, 03 Feb 2022 22:35:15 -0800 (PST)
From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	sstabellini@kernel.org,
	oleksandr_tyshchenko@epam.com,
	volodymyr_babchuk@epam.com,
	artem_mygaiev@epam.com,
	roger.pau@citrix.com,
	jbeulich@suse.com,
	andrew.cooper3@citrix.com,
	george.dunlap@citrix.com,
	paul@xen.org,
	bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: [PATCH v6 13/13] xen/arm: account IO handlers for emulated PCI MSI-X
Date: Fri,  4 Feb 2022 08:34:59 +0200
Message-Id: <20220204063459.680961-14-andr2000@gmail.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220204063459.680961-1-andr2000@gmail.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

At the moment, we always allocate an extra 16 slots for IO handlers
(see MAX_IO_HANDLER). So while adding IO trap handlers for the emulated
MSI-X registers we need to explicitly tell that we have additional IO
handlers, so those are accounted.

Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

---
Cc: Julien Grall <julien@xen.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>
---
This actually moved here from the part 2 of the prep work for PCI
passthrough on Arm as it seems to be the proper place for it.

Since v5:
- optimize with IS_ENABLED(CONFIG_HAS_PCI_MSI) since VPCI_MAX_VIRT_DEV is
  defined unconditionally
New in v5
---
 xen/arch/arm/vpci.c | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

diff --git a/xen/arch/arm/vpci.c b/xen/arch/arm/vpci.c
index 84b2b068a0fe..c5902cb9d34d 100644
--- a/xen/arch/arm/vpci.c
+++ b/xen/arch/arm/vpci.c
@@ -131,6 +131,8 @@ static int vpci_get_num_handlers_cb(struct domain *d,
 
 unsigned int domain_vpci_get_num_mmio_handlers(struct domain *d)
 {
+    unsigned int count;
+
     if ( !has_vpci(d) )
         return 0;
 
@@ -151,7 +153,17 @@ unsigned int domain_vpci_get_num_mmio_handlers(struct domain *d)
      * For guests each host bridge requires one region to cover the
      * configuration space. At the moment, we only expose a single host bridge.
      */
-    return 1;
+    count = 1;
+
+    /*
+     * There's a single MSI-X MMIO handler that deals with both PBA
+     * and MSI-X tables per each PCI device being passed through.
+     * Maximum number of emulated virtual devices is VPCI_MAX_VIRT_DEV.
+     */
+    if ( IS_ENABLED(CONFIG_HAS_PCI_MSI) )
+        count += VPCI_MAX_VIRT_DEV;
+
+    return count;
 }
 
 /*
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Feb 04 07:53:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 07:53:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265119.458415 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFtOx-00070n-5W; Fri, 04 Feb 2022 07:53:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265119.458415; Fri, 04 Feb 2022 07:53:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFtOx-00070g-2D; Fri, 04 Feb 2022 07:53:03 +0000
Received: by outflank-mailman (input) for mailman id 265119;
 Fri, 04 Feb 2022 07:53:01 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1gJ0=ST=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nFtOv-00070a-LQ
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 07:53:01 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 789cce1d-858f-11ec-8eb8-a37418f5ba1a;
 Fri, 04 Feb 2022 08:52:59 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2055.outbound.protection.outlook.com [104.47.14.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-39-iG4dhRilPvW1SLfQ1GZq9g-1; Fri, 04 Feb 2022 08:52:57 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM0PR0402MB3762.eurprd04.prod.outlook.com (2603:10a6:208:3::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.14; Fri, 4 Feb
 2022 07:52:56 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.014; Fri, 4 Feb 2022
 07:52:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 789cce1d-858f-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1643961179;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=U3e1pm3Fm1Vdpk8T3tYL0kSS63VDrtItiFu6xb5gSeQ=;
	b=LCEgGAD+w7B0thEvXcq/M31bjg+bIQO7G8/YKjWOqyqW8e3gP4GYDs5IiiU/aWlNxEWovp
	dFDEQ8FSmCmubjRm6/0Ms/O8b8b3BVd4P3eDi+rnajyDHHsSA2T2xG/eNPfiQN9ajofhPn
	PKhd3ZOoNOgSG9/9zNQIaywmR1QFQe8=
X-MC-Unique: iG4dhRilPvW1SLfQ1GZq9g-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cgRpOfS9HxFZIBnGvtrWdgdG+tP7VkJh4MnipgIEEbedUIwYw+lR2Qc7gI89su5YjYeeBzrHCzpEHNHSSGcZG1bBjia4GC01BE6jTBen5bWmkQS/K7dxHiZqQ+abVGcQxu+mJ2qkH2jPqQmYlOTKExf5umud6PzFdSnddBowRSM6mKSPvJ+2enWii6VeIDOV8qDVJV0yGfk6OlCGT4dl6WNcgkh5vH9pi+S9+NYau2T1iU7pmMSHYPiZ7aRCOMVOxuwj17NvjZSDdAmEP9JDg12QLyGk9VYdlNjiokVz9vO/PXyhL9F5BXRAT25eA1KUAEqGUMKCbhFnGpR6yRgUtQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=U3e1pm3Fm1Vdpk8T3tYL0kSS63VDrtItiFu6xb5gSeQ=;
 b=CCt5nVWT158XTXRYfGZMPnoLWSIR7tsENi1k9yKp05BdIHOhERlJwdYj9TakRLLTLxJgEqxOmjtdiOiHn4OL3PskWO66GL+1mb+o5Wov/VxOEEgO7aca8jCF/PPSTQ8qkU4hlYm8+qRa962NdyE60wIXMtfMUQ/VO2yDV6Q5d3oU1pvze2gw3xUqh2cOLzIOlNNQZKEoD2xPZ1eByM2Y/kSqoIECPeR7bNahCEWKcP1M+nFzva/uT6HD3zMRAveg2ac8nWTmiNL+PZ9GGVp6BLXSYYkr4VTduamIb1F49W1rj6w+uHpzgbGAtmn9g10SNMM/tBDeWqx2Mv9tSWWY5w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <7209889d-8f17-61cc-72a4-97f6dbc1d54d@suse.com>
Date: Fri, 4 Feb 2022 08:52:52 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Content-Language: en-US
To: Oleksandr Andrushchenko <andr2000@gmail.com>, roger.pau@citrix.com
Cc: julien@xen.org, sstabellini@kernel.org, oleksandr_tyshchenko@epam.com,
 volodymyr_babchuk@epam.com, artem_mygaiev@epam.com,
 andrew.cooper3@citrix.com, george.dunlap@citrix.com, paul@xen.org,
 bertrand.marquis@arm.com, rahul.singh@arm.com,
 Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>,
 xen-devel@lists.xenproject.org
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-4-andr2000@gmail.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220204063459.680961-4-andr2000@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR08CA0018.eurprd08.prod.outlook.com
 (2603:10a6:20b:b2::30) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 61bde2eb-c408-4192-23da-08d9e7b35a4e
X-MS-TrafficTypeDiagnostic: AM0PR0402MB3762:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR0402MB376239D3BB2418521578B8EFB3299@AM0PR0402MB3762.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4502;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	qPcZXF3CYk8tjRGNkd5AhqYZ4p7mRvvf1zzeHJcsCvXXvyUJoFV8cck0cE1YWzaR36N4n3rOYbMMm+KSZRlfZ7oqxv+R0VoqpyuZdniZTCTu9J7Zg1PdoCfDqoXoPbXIparYoHthI1iHAko1+HZtPWTyysnFQOQZ/ndsTogB30f/ov8vY8uLTJ++A8cz29AvqCChFO6/ASMftOdPon7MvFRVD1QQrvnEncxPn9Ti3jibpgXhi4QgGnXdVhHh85PUvRbyAQDzNGS4c2UM4pi9L9iTHbHTUOFiIe4uNjQq88jYIRc9crLJOCPMuor3UNepIOUQ69F23WKHuotYmRmDTnxy12DWX8TWLF23LiRRoFhvTrpUhjdUSHVe0z/MQ3E6TJ58BS0uecHB+tJ4PHOCgd6I9YDEv8Ij2xJXcNxN0CLIVsmfkk6zPvOh+AolgxbbOzq9taoUtLz9qR53IDminVyXUfS6AMKFwgmpRjwmKVMCfR9uqONoDJdEY1JijlAhpx9oyCxFw66BL3S5bjd6SLWIUQ0ilQsPVV5gWxV5D5pi7BZob97IErVCgOiC0dOZ603Tt9tJUf+c30lWSSwH6SvKxs82D7QWwDiWBu9N07IPvb8TySZShV6F1yZl/cBTnQoHSzSMsfy7wwMLexNNf5QC700PUar5Ahf9Y2sWlUVvc6wdAGBmVCdJYgIEbU29ueKLIvKDmoGaRV+OD5jVj+/nSAo4ZNRHC9L+yj629Sj/n7C7ZmfnMGKs1DzY2zU8fw0+jpeT18BnWc97iObAPA==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(86362001)(31696002)(508600001)(38100700002)(316002)(6486002)(7416002)(5660300002)(66946007)(66556008)(4326008)(66476007)(83380400001)(2906002)(8676002)(8936002)(6512007)(6506007)(53546011)(6666004)(2616005)(26005)(186003)(36756003)(31686004)(45980500001)(43740500002)(309714004);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?YVltQytxZ3IvakYveGF2aFB0eTYyTGJCeW5TUXlJQ3lWVHFRU2c2MkxUOHV0?=
 =?utf-8?B?UzhVZHJlZndabkkxNlh1YTFHWEdxeTFMcEdlSFlZdm03dnBFL1psaDgwbHN2?=
 =?utf-8?B?dEozbmYzR0ZVVkNIK284Q2FSQkVHNEswYmsyRWNEc2VqeUpHUHkyUnlsUDAz?=
 =?utf-8?B?U011bWhzaFl1cWd4S25VUVdWUEluL1EwVmcwb0tNNGl6eCt4NUFuUjJ1Uktz?=
 =?utf-8?B?MVROSUdzb0JObVhrdEp5V3BMZFFXS3RMSE9HZEw5MnQwYnFFcHZXeHY5Z29J?=
 =?utf-8?B?MWp5VG1rbmM3SHJybDlyV0lQNlhaK0hrRm5ub3RnMVRlOEhwY1V6N3h6b29D?=
 =?utf-8?B?QXNOekV3dWRmcDI4eGVKMWlSRldaa010THBaTU9oRURUbzBmd1ZGNW9jN1FK?=
 =?utf-8?B?Mml2bU4vRTNIbFRPZ1FzWVhpV21rWUR4QklPMktheWhwRHNHM2FZWjJVMnJV?=
 =?utf-8?B?QUs2dURkL092ZjJydlhTVFFwaEpuc0lvZ0FTWG40WFVGNk5LQmJncTBnd0Ji?=
 =?utf-8?B?UVg3ZVJpb3FoU1RsTjBSMUZNNnlOMGlDTk5kWkthai8xQjdlbktmc3ZSUU5q?=
 =?utf-8?B?T2hxTExUNU5qclAwcDJROHhnL1ErYmtaclBBSHRQZ2dobkpSOHkrSUxlVUox?=
 =?utf-8?B?c3M2T0JKK0VRSlRaSDhvNlhyVi9XQ2dYSnMwaWtEMXBaOEZuemIzaDRLRFls?=
 =?utf-8?B?d21FTGtJQ1VPNElOMC84Sm1scFMzdEMvTXBiM2kweXVLbTBLUU1DZzFmZ2VT?=
 =?utf-8?B?RERFNnlKVWdpanQ2ODZ5WXA2dDZxb0dWTll4dkR2czR6UGtTQ1R3dGNvc01D?=
 =?utf-8?B?djRES3RUTjhKTFV0S0wvNE9mWWVDb1hWNXVwRTdpNmJVVVE0RXVEd1JJQUc2?=
 =?utf-8?B?UlhPRng4VUVJUGthZ05jTTZFZ2MzNVozMDhMTTN6WnBRQWc2THR1LzhpMUVw?=
 =?utf-8?B?S2VDZGJqQlM0SVdEMzFGSWVDNzNhS1NmK2txNWI3UTB0M3ZZaFlMakkrSHFp?=
 =?utf-8?B?OVQ1eEY3T24yYzBBT2Vjd2tmSGgwOW0xRW54NVJxQ3hqbWtoNmg4NmJxbUxr?=
 =?utf-8?B?K3JMYzhRSGg1d0RiYi9VWFZldzNWVk94ajJZNDJLQWdMajBydEpJUkVPNzhO?=
 =?utf-8?B?ZkxIQmJvam5ZbU04cGMzSG0yaW5VU2VEek01bVRNKzlMc0xvT3Q2UXA3WE1l?=
 =?utf-8?B?OU1VelJYZktZTEJmQ2dnUXdrNUZya3dhYXIyVWN1NHFuNUZSSWZ4dFd1dWEz?=
 =?utf-8?B?M05ucDArNnk0Q3JjUU5vb09Vb25NbG5NdWNWZk9yL3RFQ2dIemdhVERJNzJZ?=
 =?utf-8?B?Skh4Vzcxc3J3eTRxdG5VTjByLzZjcldETFJuYW5WY3lUTWFVNFBGeFg5M2xl?=
 =?utf-8?B?MlhEUEZTUll5S2hJZEZDOHM1aGs2eXJiU3lGWStPUHY0Qk9GdDhkbWw4Snk3?=
 =?utf-8?B?djduL1VIMGFwVzlBMEgwRzRuaDM4Mm5oTUtHcnUzLzMyc01nZzFKOHhybmg5?=
 =?utf-8?B?eGJHc1JLMHVBdTFwTG9IcG93MkltaWlQME5pN09jVzNnVy9laUdOcmd1cDYy?=
 =?utf-8?B?a1VnYk9GUGVnRXZ4aHNqTjBRU1JtN05XaGZOV0wyNWNKKzVnN0RvUHFqbU9h?=
 =?utf-8?B?azJjOS9pNXdkQjlZaXZlTWxQUTYrTEp1dEpWMGIyaEVoTGNtMFBiR2JMRjRk?=
 =?utf-8?B?a0RVVHAzZ0s4UDFoV1MySE83WkZmY0FKamwxajViNFlxRC8ybXduYjhpUWMy?=
 =?utf-8?B?N3NYUzZEOVZld3YwdS9DdWpJSnpMVUgxeEpDZVNmY3VrSlVxOW84U1NtRENr?=
 =?utf-8?B?WEhVK3lyc1pSb1lJQTFPNFpVTHRSN0hhN25LZWFBa09CbVhYT0JSdGVwNHRy?=
 =?utf-8?B?M3RhRy9HTHRwVkdCK2pDdWZmbm9GZXFNWjVHbmVvSTFnNU1RRTBac3Uvb09y?=
 =?utf-8?B?M3VidHJqNm9HSXFXS3pWZU9DcUxKOEg0Y2pwMUplOW44dlRERnZaUjRXVTlU?=
 =?utf-8?B?Rm5YbEtCZ0NLczFKWWNrTDdkSlRhM3B5WFQ5WUdjWnFod3JYN21xT0prWGFz?=
 =?utf-8?B?R1NoSnErVDgxU281WkdkV05ZWTFmclo5R0tuMldYbzl5WlNldlM4VkhRZVRa?=
 =?utf-8?B?R0hPYTB2OHQ0RTdHZzhIN2pnY0hHODcvS1QyVGtudktPL0c4K1ZEc2laK2Vt?=
 =?utf-8?Q?/whsXk8Y0cISPoxWPMBEkzQ=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 61bde2eb-c408-4192-23da-08d9e7b35a4e
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Feb 2022 07:52:55.1899
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FeQk2yUG2aPsN4CASrEZrD5PC7HiWH94eN1Fc4bIGp9B4ydGFU5ANl7FFYvcMpQ1K8tAt1nFOQSZdINoR1zbiA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0402MB3762

On 04.02.2022 07:34, Oleksandr Andrushchenko wrote:
> @@ -285,6 +286,12 @@ static int modify_bars(const struct pci_dev *pdev, uint16_t cmd, bool rom_only)
>                  continue;
>          }
>  
> +        spin_lock(&tmp->vpci_lock);
> +        if ( !tmp->vpci )
> +        {
> +            spin_unlock(&tmp->vpci_lock);
> +            continue;
> +        }
>          for ( i = 0; i < ARRAY_SIZE(tmp->vpci->header.bars); i++ )
>          {
>              const struct vpci_bar *bar = &tmp->vpci->header.bars[i];
> @@ -303,12 +310,14 @@ static int modify_bars(const struct pci_dev *pdev, uint16_t cmd, bool rom_only)
>              rc = rangeset_remove_range(mem, start, end);
>              if ( rc )
>              {
> +                spin_unlock(&tmp->vpci_lock);
>                  printk(XENLOG_G_WARNING "Failed to remove [%lx, %lx]: %d\n",
>                         start, end, rc);
>                  rangeset_destroy(mem);
>                  return rc;
>              }
>          }
> +        spin_unlock(&tmp->vpci_lock);
>      }

At the first glance this simply looks like another unjustified (in the
description) change, as you're not converting anything here but you
actually add locking (and I realize this was there before, so I'm sorry
for not pointing this out earlier). But then I wonder whether you
actually tested this, since I can't help getting the impression that
you're introducing a live-lock: The function is called from cmd_write()
and rom_write(), which in turn are called out of vpci_write(). Yet that
function already holds the lock, and the lock is not (currently)
recursive. (For the 3rd caller of the function - init_bars() - otoh
the locking looks to be entirely unnecessary.)

Then again this was present already even in Roger's original patch, so
I guess I must be missing something ...

> --- a/xen/drivers/vpci/msix.c
> +++ b/xen/drivers/vpci/msix.c
> @@ -138,7 +138,7 @@ static void control_write(const struct pci_dev *pdev, unsigned int reg,
>          pci_conf_write16(pdev->sbdf, reg, val);
>  }
>  
> -static struct vpci_msix *msix_find(const struct domain *d, unsigned long addr)
> +static struct vpci_msix *msix_get(const struct domain *d, unsigned long addr)
>  {
>      struct vpci_msix *msix;
>  
> @@ -150,15 +150,29 @@ static struct vpci_msix *msix_find(const struct domain *d, unsigned long addr)
>          for ( i = 0; i < ARRAY_SIZE(msix->tables); i++ )
>              if ( bars[msix->tables[i] & PCI_MSIX_BIRMASK].enabled &&
>                   VMSIX_ADDR_IN_RANGE(addr, msix->pdev->vpci, i) )
> +            {
> +                spin_lock(&msix->pdev->vpci_lock);
>                  return msix;
> +            }

I think deliberately returning with a lock held requires a respective
comment ahead of the function.

>      }
>  
>      return NULL;
>  }
>  
> +static void msix_put(struct vpci_msix *msix)
> +{
> +    if ( !msix )
> +        return;
> +
> +    spin_unlock(&msix->pdev->vpci_lock);
> +}

Maybe shorter

    if ( msix )
        spin_unlock(&msix->pdev->vpci_lock);

? Yet there's only one case where you may pass NULL in here, so
maybe it's better anyway to move the conditional ...

>  static int msix_accept(struct vcpu *v, unsigned long addr)
>  {
> -    return !!msix_find(v->domain, addr);
> +    struct vpci_msix *msix = msix_get(v->domain, addr);
> +
> +    msix_put(msix);
> +    return !!msix;
>  }

... here?

> @@ -186,7 +200,7 @@ static int msix_read(struct vcpu *v, unsigned long addr, unsigned int len,
>                       unsigned long *data)
>  {
>      const struct domain *d = v->domain;
> -    struct vpci_msix *msix = msix_find(d, addr);
> +    struct vpci_msix *msix = msix_get(d, addr);
>      const struct vpci_msix_entry *entry;
>      unsigned int offset;
>  
> @@ -196,7 +210,10 @@ static int msix_read(struct vcpu *v, unsigned long addr, unsigned int len,
>          return X86EMUL_RETRY;
>  
>      if ( !access_allowed(msix->pdev, addr, len) )
> +    {
> +        msix_put(msix);
>          return X86EMUL_OKAY;
> +    }
>  
>      if ( VMSIX_ADDR_IN_RANGE(addr, msix->pdev->vpci, VPCI_MSIX_PBA) )
>      {
> @@ -222,10 +239,10 @@ static int msix_read(struct vcpu *v, unsigned long addr, unsigned int len,
>              break;
>          }
>  
> +        msix_put(msix);
>          return X86EMUL_OKAY;
>      }
>  
> -    spin_lock(&msix->pdev->vpci->lock);
>      entry = get_entry(msix, addr);
>      offset = addr & (PCI_MSIX_ENTRY_SIZE - 1);

You're increasing the locked region quite a bit here. If this is really
needed, it wants explaining. And if this is deemed acceptable as a
"side effect", it wants justifying or at least stating imo. Same for
msix_write() then, obviously. (I'm not sure Roger actually implied this
when suggesting to switch to the get/put pair.)

> @@ -327,7 +334,12 @@ uint32_t vpci_read(pci_sbdf_t sbdf, unsigned int reg, unsigned int size)
>      if ( !pdev )
>          return vpci_read_hw(sbdf, reg, size);
>  
> -    spin_lock(&pdev->vpci->lock);
> +    spin_lock(&pdev->vpci_lock);
> +    if ( !pdev->vpci )
> +    {
> +        spin_unlock(&pdev->vpci_lock);
> +        return vpci_read_hw(sbdf, reg, size);
> +    }

Didn't you say you would add justification of this part of the change
(and its vpci_write() counterpart) to the description?

Jan



From xen-devel-bounces@lists.xenproject.org Fri Feb 04 07:56:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 07:56:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265126.458425 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFtRw-0007c0-M6; Fri, 04 Feb 2022 07:56:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265126.458425; Fri, 04 Feb 2022 07:56:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFtRw-0007bt-IT; Fri, 04 Feb 2022 07:56:08 +0000
Received: by outflank-mailman (input) for mailman id 265126;
 Fri, 04 Feb 2022 07:56:07 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1gJ0=ST=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nFtRv-0007bl-KP
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 07:56:07 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e83ecbeb-858f-11ec-8eb8-a37418f5ba1a;
 Fri, 04 Feb 2022 08:56:06 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2055.outbound.protection.outlook.com [104.47.14.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-7-KXk5w3xJOO6xLu8wBRx2kw-1; Fri, 04 Feb 2022 08:56:05 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM0PR0402MB3762.eurprd04.prod.outlook.com (2603:10a6:208:3::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.14; Fri, 4 Feb
 2022 07:56:04 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.014; Fri, 4 Feb 2022
 07:56:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e83ecbeb-858f-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1643961366;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=k7GYhuJCbNjhx0WIlcWn5Rn1mDYkjm0tooRLJ8Lgu4U=;
	b=mgg0t7SaZFTzft2sBD/xoWePeD2BDjX6VltL5mb19JBTnOv/rT2Lra/b2YelL3LhiGtCOW
	TxrxxtJW1fX1OBeZL1agB2g7CjZ+jViA0UtqkQNfH9NAA+E1f9c9k0TA0nAIZDHS3qm8JF
	Nz+YHUB85cVb9kbqn9f0WEUQfe2dx2g=
X-MC-Unique: KXk5w3xJOO6xLu8wBRx2kw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Hmg68HKQ/927D6fcprksQCtrSIb3HekjOyb6Lz6hQXEx7ir5fe1LVmz7jY80JpAIX6WuutLZdNRtJzBmIECQMm3suxVSwECOUtQbdOaBxOIqQTraKg9vbTY+xvH3Cn24Q5hqR7zAKDNo4UqqhBg8lT+C3X6lAnB2L1qaFAZJ4pmPUXJYe7GhNdIB/DahHE3G52uCVGTEG7ry/AzYo5akA3IV5w2Ok7oOz6W6StosQ6otLFwU+jufDthCGVasXqvzTZuyZwPl6IYij2LE+VaQQ0i/GjdKeyh+0/N4jNPEPv+tGFSboB2P0bS6MwDry/3j0cwD673wnA2wcO0rKTFZfQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=k7GYhuJCbNjhx0WIlcWn5Rn1mDYkjm0tooRLJ8Lgu4U=;
 b=K5Mxae1F1R6liyBvmEXypYgRXBWkaXJ4tuvxqjHCjRc/I063RNuSghP9i1cITuO/BfWsbLyQpcq4AdKYQJRwdG8DXcBJQsZ/bN//UxQW6JHgI5v5mCqoNrHOM0jFQxY+ZOKrKNjZuzQ+9eTewRP4KNs10raOYqlaFmGaSOv9GUPtxuJav41HvatWMlfwlH8L9QnaAxwDc1eTuq6nbsERbZO5rtXJWGb1B75UNK32fLY/yYQM5zf+BsEKWiyyK1SDj7hu4JxIU/At8q0vaOCz4+H0Ebufw/UmiWtLmRe+3uZCutJMxMjCsoIV2NHECFrLziQ/WY6daaJYCrIA1cbPmQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <c8de0575-b2c5-48cb-c579-e1d2b7be5bd0@suse.com>
Date: Fri, 4 Feb 2022 08:56:01 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v6 12/13] xen/arm: translate virtual PCI bus topology for
 guests
Content-Language: en-US
To: Oleksandr Andrushchenko <andr2000@gmail.com>
Cc: julien@xen.org, sstabellini@kernel.org, oleksandr_tyshchenko@epam.com,
 volodymyr_babchuk@epam.com, artem_mygaiev@epam.com, roger.pau@citrix.com,
 andrew.cooper3@citrix.com, george.dunlap@citrix.com, paul@xen.org,
 bertrand.marquis@arm.com, rahul.singh@arm.com,
 Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>,
 xen-devel@lists.xenproject.org
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-13-andr2000@gmail.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220204063459.680961-13-andr2000@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5P194CA0017.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:203:8f::27) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 69006095-aaa5-4cec-7796-08d9e7b3cad4
X-MS-TrafficTypeDiagnostic: AM0PR0402MB3762:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR0402MB3762A341ED5CD1E4903EB99BB3299@AM0PR0402MB3762.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7219;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	TmXJCQed/U8bjvnDVfX9Qsl8gQLxsWmAALwKt8c3n00+m8pwYJiWVCnFOoIInzj0tl8r1QI1tzY4P+3SJyBCiFQFpZEahojQDPOAyi4Av72sQa2gvyv5Svx5hcCwPrMbEg0sTCJZ64E0VqRDlUsfLrRp7p3hU+XFUcsqTX27pAgskiPQUd/daQtZSRS8BSjpht2TlfS2lQcLgq/Uxbo/O2SmHSP1OgCPGYX8/girnfy2iTrZgVk2X8Q0MdhHp7xxD5QtPdgaT2BJTVW1M9YRXava8k6X2jnPB42cMRs3eAiRsio1HasaSlcwdZV4G0wsl9JXFwahdG7wKhBKn1vxzhUPx8YYu63O8Nu8363BnpZiE3P4ozuWRrLEAt+05l6xVdFiMi6J1BVHN+bPbK9DqkfjP1/vYWzjhAM0gAaOfsygJ2eXQFw3DsoBf8pRRoDPY9FAmLw25v2VdhLuQb4L2i8WJSi2pd4TcOJPAtd1BvKfdGL13uryJvSs6Mo5eTnqKhhlpd2UWyp8FWTPfad0/gBdvpKYf9ZIkq11sfLWMN7vMJ2eHMhyY65aFk0dI0Yl5TxyJQQ5FljLFlepM9KtxkV0S6+7+sIuiFCJ0wFg3fdyyd+I5ofH2F8VHPm8pC90hLKZCKF/0mwjTReNjPq941T43RFcE2MaAXnOy60Y3PE4/S8falMCOx1/ziNrJQHYDk48v5RDwCD7pvRgSnMSIeiJKGEYsTktOfckCqI4rZk=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(86362001)(31696002)(508600001)(38100700002)(6916009)(316002)(6486002)(7416002)(5660300002)(4744005)(66946007)(66556008)(4326008)(66476007)(83380400001)(2906002)(8676002)(8936002)(6512007)(6506007)(53546011)(2616005)(26005)(186003)(36756003)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dkJuOGtzVGdsQk9SSUY4K2ZBVitySGNsWnhVTDJQTTcwcUpLV2I1SzlRSUlJ?=
 =?utf-8?B?VWVIU3VTM0dYcWVXdmVEMVhzUS9QcDJ6RkFnL3BBeWtTU3RMQkpNVzY4a2Zi?=
 =?utf-8?B?Zk9idk4zczZyQ1VlVEgzRUlwaHBEQlN0dHd6OFRxK0R4UklJY3hvLzVLOFZj?=
 =?utf-8?B?QkpJKzJqZ1c4OEdoZG42dEpjMHNqYlRkQ3Y0U1RxalNMU3FIWmNvNXh0L2xZ?=
 =?utf-8?B?aGczVzdXbTJ1K3BYMEZwV1BQQzJrckg5K055NkF0SW9DQXFlQk1XS3FZNnZh?=
 =?utf-8?B?ZWE1N2dJU0YxVWcxdlBOL3lKSFd0MHJjTWVlZ01hWVVVV29DcUFVSEQxOEM4?=
 =?utf-8?B?bjNGNWFNdEg5QkRWdnZDazVUZnVVdVRnS0xOR3N2NHhnNitkQ3RzM3pBZ3Bh?=
 =?utf-8?B?Wlh5Z2Z1M2Zmd1RWK2pWdk9VZlpXd2MxTlpwbUF1WTRiSjh1VkhScURSTFY3?=
 =?utf-8?B?K0hPRVFNdDkvUVRIcjJMbGNVbDdKV2l0RzN1alVGRGZvVGFIbmRlMStUdHBR?=
 =?utf-8?B?WEx6aFpjOXVWd3NZaW04cGdGSkZsdVpmaVhOWkxOT1NKYW42MWNkbXBWT0tI?=
 =?utf-8?B?Qmlpak8vVWR6aTRxdnFCUUNHeklZQ2hzZDlOdGhvMGFwSFY2MTN6MjdWMlgr?=
 =?utf-8?B?OExYMWpIZlAxMFlJL0NySklOWkV2dzdqQlRIR2x1Q1BDMkdtbVZ4b2ZRaDl3?=
 =?utf-8?B?azZkZ3RxYkM4MXQ3dVY1TWU1dHIwK0xsWkE3RlZkR3hTMDE0VGh6Q1J6WkEx?=
 =?utf-8?B?ckRyT0tCM0Eyb09pZW9HRmxGWFpCYUd1b09BNWQ1U3hEUnU5RlZQbEx0Q2l3?=
 =?utf-8?B?Mm83WEN0UHgyQjM3TCt3VGczRWlSRkZVU2RMclJFTEdXTjYwd1Y3OWRKcG01?=
 =?utf-8?B?enZsbWI2QlhzRzJPTTc4UWoxdUx5enJZVGJsVkUydHRITUUyekhuTFFtWkFD?=
 =?utf-8?B?TEhuTk5WSGc3dHZRWi9HRVFNOHhFRGJzSkFJYk1EWjRwbWhKbWtIclN0WUpY?=
 =?utf-8?B?cDlIRFZIZHFvb3dOeUJ0MDlFYXRnRjhOS3oxQXRnNThKL1FHUGxYWElRRzNh?=
 =?utf-8?B?VHJjMXMzdEFkdFRyWWo3blBQaXpnZVg1c3EzRUhTVUppU2pXK0s3YmxaMVhC?=
 =?utf-8?B?QkV6cGNDVE56VzUwbjA4c1I2dzNqWDVkZkp6eTdLTFg3QWtnU0REZVllQXpy?=
 =?utf-8?B?NUhGNnNtV0p6NWUvN2hNSDY5ZmFXbGd4WXpzVjRnOTFidW01SjlBWU1CR3kz?=
 =?utf-8?B?MGM4YjFvVHZkR0ZWQ2tpZC9LQyt2Z0drcEZZb1VrV1Z6QldZVWlwOUN2a2M1?=
 =?utf-8?B?YUw3dGR2T3JHMzRlS3h6R0ZJU2tCRGxNQ3lmYnlJWU5jMWhzQ1BuMnV3K0xr?=
 =?utf-8?B?RHUvMUdFNFZPTzJQc2JiNWF3bGR0dmxDV1NyNEROZnJyQjhYeDVHblhRZjhW?=
 =?utf-8?B?RzBjZTFTalYrbFZ2RXJoTHZEMENGYUQ4Qlp1U1FtQ0R5bStTVXVZZEpQVnRs?=
 =?utf-8?B?NnJmWVpKWkhzSXgvUjlqR2hTWDJCQkMycXlJUXNyclRIRW8rcjV2N3E5RjFO?=
 =?utf-8?B?cnNaMFdSZVJWVU1ydzA4TEErOVptSUh3eXlFMTFaeHJkQnZma1dodndnVFFW?=
 =?utf-8?B?WWRmWDh0MFFSUS8wTlRmSzY2R1BJVjJOZkk1bVQvbytMTnlLMUJRdVBBVm5Y?=
 =?utf-8?B?ZkFpYW1jejlOSmZDcXpyVHNhZUdhZFpZa2s0NE43TCsycmcwMTlUTVBTd295?=
 =?utf-8?B?U0U0NGZwVjhpZUpEQ1ZmbTk0Y25pVm4yak1ZZlNpcEMrTXFLSUVEcHFET29K?=
 =?utf-8?B?aklPbjZMRTd0OE1OUDBNMlRMMm9VbThTbVBCNk81aWp2VVRZaDNRc3dZMjZn?=
 =?utf-8?B?dzVBNS9MVEZ0K2NrR0dYOWw4TXhHOXJwemdFVENrNUUyL1l5YkVnbEJMbmZH?=
 =?utf-8?B?SjlUY3FqN3VCZTBQTndnalNqSm5BSFZZTE5CU1NqSVg1M2tGcnAyWkFoSVJq?=
 =?utf-8?B?V1k1dzcxT2F0RGptS0FmZ3dJV2thUDErOFAwV2NXd0twQWJBektTNWhYelUr?=
 =?utf-8?B?ckhjWFg4Y3NvVjhOVzgzb2FjS3JXNWNhaWcxK0d1SXFmSzFna1dRWVJTYmRv?=
 =?utf-8?B?aUJkZ0ZGVmhFMFpaY2tyUWNVV0pKa0Z3dktKRGJ6NVBXN0VESk9HVmowcjJl?=
 =?utf-8?Q?2TRwZIRSwAh7Fx0TKIo6G/4=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 69006095-aaa5-4cec-7796-08d9e7b3cad4
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Feb 2022 07:56:03.8813
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IWgFR1JRaDXwi2EcYh1pvENMo7ZJAXtqLGuPMsIbgBCvSl8qo9qqqzxMA8oy3zZcJ7KcWcMJ6tY0Rtk9vkG1aA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0402MB3762

On 04.02.2022 07:34, Oleksandr Andrushchenko wrote:
> --- a/xen/drivers/vpci/vpci.c
> +++ b/xen/drivers/vpci/vpci.c
> @@ -168,6 +168,35 @@ static void vpci_remove_virtual_device(struct domain *d,
>      pdev->vpci->guest_sbdf.sbdf = ~0;
>  }
>  
> +/*
> + * Find the physical device which is mapped to the virtual device
> + * and translate virtual SBDF to the physical one.
> + */
> +bool vpci_translate_virtual_device(const struct domain *d, pci_sbdf_t *sbdf)
> +{
> +    struct pci_dev *pdev;
> +
> +    ASSERT(!is_hardware_domain(d));

In addition to this, don't you also need to assert that pcidevs_lock is
held (or if it isn't, you'd need to acquire it) for ...

> +    for_each_pdev( d, pdev )

... this to be race-free?

Jan



From xen-devel-bounces@lists.xenproject.org Fri Feb 04 08:14:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 08:14:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265144.458437 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFtjA-00029p-JE; Fri, 04 Feb 2022 08:13:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265144.458437; Fri, 04 Feb 2022 08:13:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFtjA-00029i-Ep; Fri, 04 Feb 2022 08:13:56 +0000
Received: by outflank-mailman (input) for mailman id 265144;
 Fri, 04 Feb 2022 08:13:55 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=u+82=ST=epam.com=prvs=4034f0a382=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nFtj9-00029b-7H
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 08:13:55 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 63983dc3-8592-11ec-8eb8-a37418f5ba1a;
 Fri, 04 Feb 2022 09:13:53 +0100 (CET)
Received: from pps.filterd (m0174681.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 21436JU8021943;
 Fri, 4 Feb 2022 08:13:49 GMT
Received: from eur01-he1-obe.outbound.protection.outlook.com
 (mail-he1eur01lp2054.outbound.protection.outlook.com [104.47.0.54])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3e0p4fh9wn-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 04 Feb 2022 08:13:48 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by VI1PR03MB4862.eurprd03.prod.outlook.com (2603:10a6:803:bd::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.22; Fri, 4 Feb
 2022 08:13:34 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6%3]) with mapi id 15.20.4951.014; Fri, 4 Feb 2022
 08:13:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 63983dc3-8592-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=lIK8eS5VsmHVQ2whW0y/U8htxqiyAH5l/TcGPjK8QHWktTLmTPUsTlu1XdOPlVPatT4UiSm+5h1TQJqV/77i0WDxhyvMANjxVgkOfUfRCpd5PWxWFdcO/8uxGJFwdVEyny5+o8CLY/WJi64DNNKNd57XbPBC3uf/JQ/3TNDNiOInVMqWEgvOyk6g3K9EnDV2Iss3DhZ2/5DSYqP5XIKIDeIIiyeKcKIZOPMaYeDcIEbMHfZePZ18NhbycARR4aoaOhQsm0z/0Rwhdn4Vr63y8xjZksC1j4x7k+b1Pa3HBjd0i9PV8/U0EvHIJ78BlGjFE/lqR8XgPYX89Z8jbncZFw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=9jnDkrI0D3kmmFAeSdC/dWBGDjEkOMEKL6SWkS2Vmvw=;
 b=Zs2bzZu7YTpVcOqZznxZ2XPx7vswgOHO9i26oCkpJR3kNGTNa/LRqTkQ3+MovNyHVZj9GtmJ8d34EakAXLiq9nKXSb/oKbgLxU0aH/vSt/w3ThowOK1joWuXf8RMSP46a3CBrzObwmcYO+2qzADX7d0k4O0S7hHUl4XVfAPSoZLvO7+8zdZEB3ccTrK33MoEH2NFS/+xIv1zGaE8EQGLY+kyVaGbJbPrugvrGBsl6H/RsMnAzGPF1YA0gG/jmKvQ2SlorvTSzAUHPSrBhc62L7MO/ofdKNM22YR5cLEjrhQuIorlcS2t8Fn4ZlJaE9DRGzHSZ0XeBKhfKuhbrMdjgg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=9jnDkrI0D3kmmFAeSdC/dWBGDjEkOMEKL6SWkS2Vmvw=;
 b=m/YpwoOgPb104LwIwP86qsuBjeipYUPYi7VrI6zpGnDqQmlrAbO8X7O3yfaQMCydG2oNSe7cZh8GAbeH5z4F7kGU/vuNU/nt5x2SnKpEfWFKSOLjPTAmhapwCUG3gPX0hF70tLIGW7Wcx+oChL1pN7LM1GkfBNUDkGTI+k4jJQ45PXvZChIkyBfNv2rldoMPRjwFpoLkc7+hitfFvmbM+vRFH1v5DCU4+labU8aQ+1mXM6NG+PNkIDQkNVUDONzCoZOwujRApuxEpw5UgpHV5Cu7n49ubp4RHejCgg/NZNzWZN17ZnGJ70bTBGDCPYnDu74P3uibN6zKZwKhcKx0ew==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>,
        "roger.pau@citrix.com"
	<roger.pau@citrix.com>
CC: "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Thread-Topic: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Thread-Index: AQHYGZFc/MnzQOjwVEeBBUHLSW0md6yDBUkAgAAFx4A=
Date: Fri, 4 Feb 2022 08:13:34 +0000
Message-ID: <fec9b8f5-05d7-8d0c-2ae0-0224318dfd13@epam.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-4-andr2000@gmail.com>
 <7209889d-8f17-61cc-72a4-97f6dbc1d54d@suse.com>
In-Reply-To: <7209889d-8f17-61cc-72a4-97f6dbc1d54d@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: e5c59d8e-3e6a-43fa-3de1-08d9e7b63d13
x-ms-traffictypediagnostic: VI1PR03MB4862:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <VI1PR03MB4862C7525474F0FE34EFAB8DE7299@VI1PR03MB4862.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 MyoUxVNRePmUyIF30//bcjeWL+RwFJizIjAI+GOCtdV+p1D1tqEHtYnEy79+pxGXY/kIKJB2J2brjtcajIV40NNYXxaR1rvahS/vYcO8U7/Xl3B29v+BzK9BxC/VqL1osxHY/b7GXydV2d5eNVb95D7j2Dk98MfplUtDNajJ1hEtug5XGXAyaS5SUaO21PUNVkZ99J3ro7ICCK+TR8Id5j0YeAHZl0C8fSlzafADNY9GwSkSi8o/hWmVel6A+KFBONcZCW/vfcPb48hgeJoBU6o6xRHCWp7MW/sW1HBqXc+Ymo6N179dcJ+8ogA0euQz3002WOaDWUU4n3E1okGcYTwLgloehtD3lvabZ5rX0wTV71Cllc9QsDihylUB40fqSBBsHpKlalmn8qQFzpkmbjcnUcW8d2yYjzqxE0BJBYu/VBeixTprqJ6zHOA4M1zzupY1XeZ7TCb85YWL8gV+EmrlfAwoX7wKMsDKG3bc6Q16UVThDYmQ9jcc59Z3MMb715Xi1W4JD+4VabV7uThRKCgxi1xheT5kPh4w4vcpxeLmCRE+LzkR1a0Xo5rNkeE9+am347/VQ4tW946pNZ8SmCqe0Wh9RPAa77jFgm6naq4fz4e8/asympKzZg2n8TSHVvpP7ZgPCOGfgvsAi9H408TNKnnspJfPd889SMn40wUF2VW1/P1EIMRNjGXh2zC7qzcyLm/aQ+0trcrSqtXz/W7Gagemf5aOf4AO6eonmEM=
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(53546011)(107886003)(122000001)(6506007)(110136005)(86362001)(186003)(2616005)(316002)(31696002)(54906003)(31686004)(26005)(38100700002)(36756003)(76116006)(4744005)(66446008)(66556008)(6486002)(83380400001)(91956017)(8676002)(8936002)(38070700005)(7416002)(508600001)(71200400001)(2906002)(66476007)(64756008)(5660300002)(6512007)(66946007)(4326008)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?SDh0Z3lOYzhkandoOXdNbXRsNnN4Z1Q2YlpCejQ2NmxJN1NYYkV3b21nek16?=
 =?utf-8?B?VGE0ZlQxaEV4Z0NkUTVMMzBiS0pKbFo3MEVpT1ZEOFMzRXF6amU3ZnJQVzc3?=
 =?utf-8?B?RnFLZ2V6c0dDOUluWkVxMWFNa3JXQmJoQ3ZxZWI5UUtJaE1WYXF6aFNINDFO?=
 =?utf-8?B?bi94UzRMc0h0dmpTR1luRW9rVGRNYXBHUjJHbTlhM29sZjFMbXNXN1NHTTZw?=
 =?utf-8?B?azFaaVFvN1V1dGJtL0h2cXdPazU2M0lsa01DMjhNeldvYy9ma2dHQ1V3azRy?=
 =?utf-8?B?WDBzWGtnbnNLT3QvdnJ2N2R5YmpXbnVFckNUcitjQ0VLenBQc0JVbTIwd09k?=
 =?utf-8?B?dEoxUTY2ME1qbndUWlhaOWpSRlhxMVNoNUJvRkUrRExReXAybzRkRDNMZFlM?=
 =?utf-8?B?bkE1WHFPdDZlZXVCYVYwTnRVZnZIbHdNOEhtd0w5Q1JOOUdhdVBUbWVXaG84?=
 =?utf-8?B?dXZtTFVjSjRZQU1qMlpmNi95cU00QnpFdks4akhIMTk2ZjY4L3NMNmxMc1Iw?=
 =?utf-8?B?aEVmQk1ZbjNIRDJLaUZpZ1hNODVQTmR3eW9sLzY3akt6OEVuS0ZXdkljQ3NG?=
 =?utf-8?B?UENMZzd6SjJOMmFTKzY4dFdLb05mNUlCbitXL0xLdmF2NzRlSHd0SzE5VHB3?=
 =?utf-8?B?Yms2OGlCZVg5S2dUSDhrcC9JM0lZMm5PekxyTEthcmNIN2xic1AvVHVxNEZP?=
 =?utf-8?B?QTdiQVl6aGx1bVFoMGk5ak95eG96N00wbys3UHdRTU9iQkpjR1dFeSszd3Rz?=
 =?utf-8?B?T2xiK00wSVAzS2k0TWVGMWdiZTMvVDFmNDB4K0JjNDh1RlEyZ1grQXhWMjlP?=
 =?utf-8?B?ZWNSZ0tTa2NMZUhObzQrWWxJSmRwVUg1N3QyUko2L3VVcE53VzgyUUFQcUZn?=
 =?utf-8?B?TGd2RFErQnlFbGZ6dklFeWtJLzN3cmR4N2VFRGdpRHlLUnd4NVZ0TlNWTms3?=
 =?utf-8?B?OFphdEszNzNva0lQbCt2R3o4R0dPcUgvZkJIZVJla0ZZOWNnOVA4SnB4eWZi?=
 =?utf-8?B?dGIzeGxHZjg5NjNERmZsWUZ6c0lUYVNUM2lpWTZ6a0FCSllYek0wbkU1d0xq?=
 =?utf-8?B?YkJiOHZtR0lqQVhUTnZDd2lLMjJFTUFhbjM2VGhKRmZxYmxMdTFxVitnMnE2?=
 =?utf-8?B?RUJjY2xmK1BqcTVDWW8yMEtKN1REeHBKSGhBbmMyZTUvRHIvcGgycnh3WEpw?=
 =?utf-8?B?WDJCc24vcE8wTnc3UkY0RUw0YURBcDVwK3l0TnFhV00vVUJqdS9hYVZUVElv?=
 =?utf-8?B?MDlqM3N0MVdLTkUrNGtXdzdTWlFOWW5Kc2djVWY4MWxzTzBUb0lROU5BclJp?=
 =?utf-8?B?L1ZlWXcxL2k4TGdPcUJQL2dWK1RieXJXV0FhSGNVcUlKQnIzWHJGeVFCL1pt?=
 =?utf-8?B?ekpSWEoxQmZVbWZRNjJRZW5UcXlsbEhBaWtqQkZiQWNaMzI2Zzk0WlBsTExh?=
 =?utf-8?B?eCttUThDOVdpdWFrSGpDaUd1clo5ZUMzeGtOMm56NzM0QXdjeU9DVCs5MUhz?=
 =?utf-8?B?Qnc3MzdiMXFRT0pNV3VIVW4yR0pVN052UHNaK1lxd2Y2U0hHeWJwMmMzNkpn?=
 =?utf-8?B?TDdzOE5HVlNOUEY2Q3dOMHpxNStMRG0zNFRSK0gvY2l6cjdSWWpaSm1ucEkx?=
 =?utf-8?B?NThCWCttN1RsMHpZQjBoUDhNQndieEZsdm9WZ3VWdzJBZmc2TllNakFHbW1l?=
 =?utf-8?B?NzdGeitnT1BST24rVmx2T00yZFU2bys5S01ob2o5bXUzNUxOVStRWjJTZzYv?=
 =?utf-8?B?ZnBvUTNOOE5GczhFckY4eWpwdlVzaXpGbXE4cVFnTkd2Yk9oNkVkWWRzb0tz?=
 =?utf-8?B?ZTR3VFIzUEhnekZtck00MDU2TUN0WkFwdWpBMkNBQmh5a1ZCUjNxS1dIeEhU?=
 =?utf-8?B?N3RzL0pBTUs3WHVodWpLVWh2WHEyS0R4TzZtRGI2dnlFNnZGWmNkRnBPQXhI?=
 =?utf-8?B?MmlqQlpqcjJ4L0FscThTaElsaU9OSGhzNGtZcmNCejhBQzUwSWJNR2ZaSXEv?=
 =?utf-8?B?VDAyV2JKV3dJazJxQS9FR0RoTUZ6bzF1TkVQMGlDdGNmRU96aDd1OUY1OWNx?=
 =?utf-8?B?eG9Uc2gxaVFtVEVnNVd5SzdpS3UxaWJkUTB3ZjBmMDJ4a0Z2VDQ3ZW1TZllQ?=
 =?utf-8?B?VHQrWGx6d082ZDZyTWQvdjNnOEhiMmJEenZQRi9aWjhpcWlHcHEyTTBaT2FZ?=
 =?utf-8?B?aDVRblJSUjZkOVJCV0ZWUjZsYXBTdUFGMit2aEpFeUJOdjE0cG1JYWVoWmtF?=
 =?utf-8?B?a1ExWHVMNUR3a0o5V0JQS25kOWRWOFhleVlvMEVYK2Z6eGRmTjY3STlZaDdl?=
 =?utf-8?B?SDJiTFlLSWVyalBoZnpRS1FUSGp1Skk4Y0RERjRVUlRxUExOdVF3UT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <5AE8686DD902FA4A906BBE4E6612A8AD@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e5c59d8e-3e6a-43fa-3de1-08d9e7b63d13
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Feb 2022 08:13:34.2953
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: mIHQDV/uKI3t4E45t6lqVO9ZeDwfzuOGcQ0817zFbJGWPWVdNkWL5/hUTvrH7UeSH4GbmdL4cyT4O9tJK0rfXMKsFgn6eT60LP+2y+LPqImhpecuA2T9ek70ZFcE2cUI
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR03MB4862
X-Proofpoint-ORIG-GUID: RyaM6txvstSeaV86uLCI8Ecg3cB72muG
X-Proofpoint-GUID: RyaM6txvstSeaV86uLCI8Ecg3cB72muG
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-04_03,2022-02-03_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 suspectscore=0
 bulkscore=0 lowpriorityscore=0 impostorscore=0 malwarescore=0 spamscore=0
 mlxlogscore=750 phishscore=0 priorityscore=1501 clxscore=1015 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2202040043

SGksIEphbiENCg0KT24gMDQuMDIuMjIgMDk6NTIsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAw
NC4wMi4yMDIyIDA3OjM0LCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyB3cm90ZToNCj4NCj4gQXQg
dGhlIGZpcnN0IGdsYW5jZSB0aGlzIHNpbXBseSBsb29rcyBsaWtlIGFub3RoZXIgdW5qdXN0aWZp
ZWQgKGluIHRoZQ0KPiBkZXNjcmlwdGlvbikgY2hhbmdlLCBhcyB5b3UncmUgbm90IGNvbnZlcnRp
bmcgYW55dGhpbmcgaGVyZSBidXQgeW91DQo+IGFjdHVhbGx5IGFkZCBsb2NraW5nIChhbmQgSSBy
ZWFsaXplIHRoaXMgd2FzIHRoZXJlIGJlZm9yZSwgc28gSSdtIHNvcnJ5DQo+IGZvciBub3QgcG9p
bnRpbmcgdGhpcyBvdXQgZWFybGllcikuIEJ1dCB0aGVuIEkgd29uZGVyIHdoZXRoZXIgeW91DQo+
IGFjdHVhbGx5IHRlc3RlZCB0aGlzDQpUaGlzIGlzIGFscmVhZHkgc3RhdGVkIGluIHRoZSBjb3Zl
ciBsZXR0ZXIgdGhhdCBJIGhhdmUgdGVzdGVkIHR3byB4ODYNCmNvbmZpZ3VyYXRpb25zIGFuZCB0
ZXN0ZWQgdGhhdCBvbiBBcm0uLi4uLi4uDQpXb3VsZCB5b3UgbGlrZSB0byBzZWUgdGhlIHJlbGV2
YW50IGxvZ3M/DQoNClRoYW5rIHlvdSwNCk9sZWtzYW5kcg==


From xen-devel-bounces@lists.xenproject.org Fri Feb 04 08:18:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 08:18:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265152.458448 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFtnz-0002oO-4p; Fri, 04 Feb 2022 08:18:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265152.458448; Fri, 04 Feb 2022 08:18:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFtnz-0002oH-1e; Fri, 04 Feb 2022 08:18:55 +0000
Received: by outflank-mailman (input) for mailman id 265152;
 Fri, 04 Feb 2022 08:18:53 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=u+82=ST=epam.com=prvs=4034f0a382=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nFtnx-0002oB-JW
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 08:18:53 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 15fc038e-8593-11ec-8eb8-a37418f5ba1a;
 Fri, 04 Feb 2022 09:18:52 +0100 (CET)
Received: from pps.filterd (m0174682.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 2148AVJb011800;
 Fri, 4 Feb 2022 08:18:48 GMT
Received: from eur05-am6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2109.outbound.protection.outlook.com [104.47.18.109])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3e0qyqs0w6-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 04 Feb 2022 08:18:47 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by DB7PR03MB4011.eurprd03.prod.outlook.com (2603:10a6:5:32::25) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.14; Fri, 4 Feb
 2022 08:18:06 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6%3]) with mapi id 15.20.4951.014; Fri, 4 Feb 2022
 08:18:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 15fc038e-8593-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ccFGU7Nl5Eg4UysEmN3B9GBU7Uq15aYfUGViVtENI+b+xrZu396VABYT1L+qLhAml8LuJgMP5v+CJx6ZRthnN61q6WVRPDAcFwxsQ7TYFVeKGnOrub457nZrwI/xV1lRhM3PY09HojVvzqZMJ/OkaQKAryXs2CzxIREjkAewgqqUpmDKjkWGIA0AUmq4q/ttLXNEb+gfd7gclvlKSlPNheZNoJaTM+cGKmDf/UWEB3cUFrQB+tnX0VE+k+FAMfPd0awpBPyL/uC5scRbeJ4b0N6iS6s3RcwlGVkoaD1/cJrDNsHnvz0lNFo/3JnY+DRZB+7UubsiPJz2Zzp05IV5Iw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=zoMjnUyR5QgnqfycTSZCVV6hh/8SJZXFw7/jJGS6fng=;
 b=d4h/OFaqhwcgBVUby6qoRQTfKw6UJ3VTcU9V3E0shJJwcfsG1Yiny66SpDeC2myQxbwE4NDWjZcSLhtJRircnVm0FrdqzsYVjj4sY7TL7A0JA+HDNPEgQAO8RRM1GfQKiO6Jm95YtnbPJEbQQya26Ho+Y5coN73rVAS+l6qoqMsXx9nC4OAKaEYhtcsc/ATzJHa0c6paZIzgfXg9m+mO/bYB+JgQUuqu+QY73EXlWXhd/WpxZtpnTUqTQqn1Ooi6AD861z0NFdOTTLMni8x6t/DY54iIKju4i38DRGkvnINodAIwUbcPDqHkC9EMtn664SjrI7qdLcZsm84F927n+g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=zoMjnUyR5QgnqfycTSZCVV6hh/8SJZXFw7/jJGS6fng=;
 b=BlgNTWxJEujDh6UEYKsZp9cuiLYtj0HQRk5RwjvcH/FUAAYE5YtkFNQOrvbLKX+30wi4YH1eghEXku/MjJAWRpkdpbw76nswhzatThknk+Q3WY4JrZ9PM4TGTvcQ4ldc5cxS60wE1yqOL5EjbkK54oovQmOaCUiLkRjLZGj2IQ1/tc/J13RUam/3t60O+9jHENt4yQCBtUG7hsjTrrLFJtnoYwelquNljP33fYylofJMe//jIhzplgzCGMyTBuVzOxD/1G1zLKSMUYbCcgasKbzMz9CMgSm1jp8Jgm7ELFKEcAJesEPEqgF8oMnXyqzoUF5DJSgGeeb4+/YKRDfkhg==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "roger.pau@citrix.com" <roger.pau@citrix.com>,
        "andrew.cooper3@citrix.com"
	<andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com"
	<george.dunlap@citrix.com>,
        "paul@xen.org" <paul@xen.org>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>,
        Rahul Singh <rahul.singh@arm.com>,
        "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        Oleksandr
 Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v6 12/13] xen/arm: translate virtual PCI bus topology for
 guests
Thread-Topic: [PATCH v6 12/13] xen/arm: translate virtual PCI bus topology for
 guests
Thread-Index: AQHYGZFgYcuoJMilu0Or+397ala4YKyDBiqAgAAGLAA=
Date: Fri, 4 Feb 2022 08:18:06 +0000
Message-ID: <87fd7f35-b6c3-8ce0-098e-d8f1615b3b05@epam.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-13-andr2000@gmail.com>
 <c8de0575-b2c5-48cb-c579-e1d2b7be5bd0@suse.com>
In-Reply-To: <c8de0575-b2c5-48cb-c579-e1d2b7be5bd0@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: e5791fdc-5dc9-4f1c-d429-08d9e7b6df6d
x-ms-traffictypediagnostic: DB7PR03MB4011:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <DB7PR03MB4011FCB157D25E2C607C0D40E7299@DB7PR03MB4011.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8273;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 XKmLz/azJuMC8zbiASxMyTVZPir9En+Wwf8vdzfNcF7h8rzAKH9/1dV9BhQO9TwRfWfG9QWiYZqKmL1AbmYM+Sq9FXA4wke19UmUZtIKoC6MjpCjBhmoVlO/6qikYIZgdketntki/VPoVMgu3cFOkC9Z0M36GGk5KaQ/Dv5fwqtx3riTnS05dT1YrHkCS+knQVTi9L7dPEMuoWgtgGTuG30T085NTpkH7mZGXTDhzhiYiV1jOKk1RcFMd4GaX9fUYUgWt7/Fcs8k5dro1HrJ+SMAv0Cp5tq3RA2VVbSYMMcxGx+ktQP5WvxFhmSDVTf/T9n4Aed7xXJJ2NmcIzx+BMKHm1rWnROius91e7vMtuABYB6NChK5MDHGIsOF1/lxPziEBzawookyYBc8e4RYE+5oIwmV91UlYXoLKkxQe8IG2w7gVCRT6lf1w3noZL5zqT0UMKRS5nhWqYisIRtDxJ4US7inIWa+elHkGLuCig4PtPhP8un6A2qCXNrlZt+mBEOuXLcQll2hr8Paaq/k/zSqdUTmHih/ky1MjnooDcr9avR3JMd/T8Vgi2y2/kC/N/njDvfpDDUwrIdVFgEoDYqEre1fhAlZKvVFeP6fZzjBIBDbzzXjdICoiJ0qRjCGskCqFl2cmqH2BTGn3YIM8skKquv3oFr/oW+BOd5oDphp39SPGnwoN1I4jW+FU/9bITU6B3bQzx1FsxERMsI/3TwP3Lxu8aNWxR6rlZIM3J8=
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(83380400001)(7416002)(5660300002)(31696002)(2906002)(107886003)(4744005)(71200400001)(36756003)(6486002)(31686004)(508600001)(122000001)(38100700002)(38070700005)(186003)(26005)(53546011)(86362001)(6506007)(316002)(2616005)(6512007)(54906003)(6916009)(4326008)(66476007)(8936002)(8676002)(66446008)(64756008)(66556008)(66946007)(76116006)(91956017)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?ZENxRjgxN1E1S3BDZkF6ajBaUHJudTdiTzViUVBtY2hLUDJ0eVdZTkNyRmEy?=
 =?utf-8?B?aXFFU2luc1ZqQkRCVURUNXhUMFBsZDlmenh6endaTE1GYWJQaTNpNkR0K2NE?=
 =?utf-8?B?cjA2N3BCWVRtU3R4WUNmSjM0elRNM1QxdUJ1SEdGMyswY2xjQ1gyTmtvcmlr?=
 =?utf-8?B?MjNIbXNXUVJycUpVNnErREl6TlZzbUhIc2R0Ykc3ZHNYN0ZCbzZ5RmJSazRP?=
 =?utf-8?B?NWFmUEorTGM2SFpCMTJMeHdaUzVuQ2IyMVpBdEtlbnFzMDV3OThqUXBaZWJo?=
 =?utf-8?B?Sm5mamt6ZXNCc3ZVZ0lzVjhsWkJJVlh5M3k3RHdUdUp3SG02SUo0VHdja0E0?=
 =?utf-8?B?dU5FZTlkUkxUSzhhN0tHWDNEbnJORmcreGI1aHpNWmRTeDlWYmhrUnVTaU1G?=
 =?utf-8?B?VUs3RUNWSjNWL1BIKzBRcEJod1hXTlRQMFdXVVlEQTVIb3JaeVpzM2JxaU5U?=
 =?utf-8?B?MjFUNVMyYnNNNTFZY3MxV21PNXRBQ0ROQUd5VXdHaXp4ekdyZzhLZ25pZ3FH?=
 =?utf-8?B?VFpCSkF1b2JvVFRpN1BIVU1hcHB4K0gwNXlNNUM5Si9xVkFBMGpTSTI1SDl2?=
 =?utf-8?B?blBiU1dTMDgvcWxySnh2UGFjWU5nZWJIVGpSc1d3Y2hnWEdoWVlIc01pNWxI?=
 =?utf-8?B?dGhjUXN6ZjZKc1J0WG9BL25Kd3EyVkhScStMZU1PcE9mQWhrZXYyajdjRzdI?=
 =?utf-8?B?VmFxc1VBN3FVNVFSdzVCbDlnUEVrRkxaVU5xUVdMY0NrSzVwb0RJS2M0Z0cz?=
 =?utf-8?B?aFR3MUY3SWtkVDhhWHRweE9oU3ZNOTE3TWs4MlBIU3dBbFF2ZVUwcVNSNzd3?=
 =?utf-8?B?UVJDRG9CZlBPSHNNczZPeVRoTlF3NDZ1K2h0YU16aUxQbFREUmpEYURrNkxj?=
 =?utf-8?B?NWY1OU9rRTZsWmc5bEdWSTdlQU9ZUGQ0TjhueDhGOGhkRjRwdjlYZXpEeldO?=
 =?utf-8?B?UnJ6L0FNTTVCbWk5MW9JUnMvbkVWNWVxMVpVcmRTeUVPNENPZGQ2b2pjTFpt?=
 =?utf-8?B?T1NUQWxsRFdHNldSWGhmQ1BnbHRTS0NSUllMcitqMXFFREFHdGw0RFgrQkhj?=
 =?utf-8?B?UEZqMUQ4UTc4ZnhVYStqTkNGTnBxRUV0NUJEVkt1RXpkWGdyeEhuRmRPRFdP?=
 =?utf-8?B?QVJCTlJvTzJZaXgyRzhteHJabW5FZzFxMWVGZWFGTC9KQysxNEhFS1VTT1o4?=
 =?utf-8?B?ZHM5dHlSRG1pWVl2K3BzMGdVVnhCWktob0xwZkJwY01CWGtnYWROWXp2VWw0?=
 =?utf-8?B?TDBsemRjUmd0QmZMdHdSUFYzK3RtU0ExNnBvSEdBRytydkUrcGdadTllRnpp?=
 =?utf-8?B?VU43RTJONWJXMXcwckxmSlk0VVozZTI0UXI2VmVTMTl0bGorb0wrZ3c0RFcx?=
 =?utf-8?B?NEYzRGhDbm5DdTFtdkJVdUREdDRiVlE0ZElydHJUdzJvc1hLVzhxNVlyMHE2?=
 =?utf-8?B?dWx1V0k0M0dTK3lJSVlDVE5BOFg1d3llaVFkamtHTUxZWisyYlBVTFdIbklv?=
 =?utf-8?B?R1c2UDZ5RUcvUExpVVordklRb08rOUZ0eG5FSGN3NGtJRk1QQjRyaHh2cm51?=
 =?utf-8?B?RzMvMHhTRVVGNUwzZDdIcUlWdDhBWHRHekRnWW5KSEV6d1U1c2dBajJIUXRJ?=
 =?utf-8?B?Si9oNGJ0R0YrMklMUGFkdHVPQ1ZVcHBhbHdwd3k3M2dKYndIbVZVMy81ZkJD?=
 =?utf-8?B?YmJGSkI3ZVJnUzdHZWRVZnlZbmx4NE42elUvdWU5TVdDRlpwQ2FXYUlHdmly?=
 =?utf-8?B?QnZ3cFl4L3JYNUJDRXdQa3FaQ2daZUlIU3UvR1RTWTJjRS9CUkNWQkJ4L0Jl?=
 =?utf-8?B?QXFiMXdkcGtBNUsza2R2REdLOWVwWklFbkxUUHU3bWdQQ1lodmxyRksrbWJ2?=
 =?utf-8?B?Zk9ncFJVSWFHcldHVmpsUkY4TGJnZDY3akxXQm93bngrcU82NVNZNnFuVTlw?=
 =?utf-8?B?dTg4eXFZVTlDYmFQN2RDTmI5ZVV2WU5hakExYVNzTXorOWZNVVZoazVMSk0x?=
 =?utf-8?B?dmdnNUs4bncrZEZQbkNFQ0IxaU5QbmM3bG5qRDIrSm5BMU90M1B3bmYwN0lX?=
 =?utf-8?B?T2x2emUvZmw0S0lHZGlEa0Z1NUk4OEtNL0FGYk9lcjlxKzZVcEdReHc4cHIw?=
 =?utf-8?B?Vk1LNkEvRDZaTGtLK29tZ0Z5Q3V4bXVDSHo4S08zRThBenY3UVhCbHFsYWVY?=
 =?utf-8?B?STdVTENXVWN2MWZqVEc0OXQ2c29zb3pRUTV5L0pyRWhWM1U2YnRObDlRS0Fv?=
 =?utf-8?B?ZzdFWTJlSHArRERtcGVIYWp6d095TUt5aGx4aUNDS0NLNkR3dGVZMU5NYlNq?=
 =?utf-8?B?TjhWQ3puSHgwWUtUblBkQkRPOVNSankyWXNrVFNYZGdlNStjNGxvQT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <2C839CCA6D3883408B47A8C3892D3B3A@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e5791fdc-5dc9-4f1c-d429-08d9e7b6df6d
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Feb 2022 08:18:06.7436
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 22q2wgHN02dzFomOpqO9Vr1jF2H66efzc5/RBds5FgQUdw99HQWcJidd/LejQF7jOTn+bcR12g/hBYPzlXYvyXdkGvqkvfY59eaxAJDFPFZlFWwdALJbmFal9zXO497b
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR03MB4011
X-Proofpoint-ORIG-GUID: hzQI0c2QrEUBpu-ZUH9ocRaYCV2OHQUL
X-Proofpoint-GUID: hzQI0c2QrEUBpu-ZUH9ocRaYCV2OHQUL
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-04_03,2022-02-03_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 bulkscore=0
 mlxscore=0 clxscore=1015 impostorscore=0 lowpriorityscore=0
 mlxlogscore=791 spamscore=0 adultscore=0 suspectscore=0 priorityscore=1501
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202040043

SGksIEphbiENCg0KT24gMDQuMDIuMjIgMDk6NTYsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAw
NC4wMi4yMDIyIDA3OjM0LCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyB3cm90ZToNCj4+IC0tLSBh
L3hlbi9kcml2ZXJzL3ZwY2kvdnBjaS5jDQo+PiArKysgYi94ZW4vZHJpdmVycy92cGNpL3ZwY2ku
Yw0KPj4gQEAgLTE2OCw2ICsxNjgsMzUgQEAgc3RhdGljIHZvaWQgdnBjaV9yZW1vdmVfdmlydHVh
bF9kZXZpY2Uoc3RydWN0IGRvbWFpbiAqZCwNCj4+ICAgICAgIHBkZXYtPnZwY2ktPmd1ZXN0X3Ni
ZGYuc2JkZiA9IH4wOw0KPj4gICB9DQo+PiAgIA0KPj4gKy8qDQo+PiArICogRmluZCB0aGUgcGh5
c2ljYWwgZGV2aWNlIHdoaWNoIGlzIG1hcHBlZCB0byB0aGUgdmlydHVhbCBkZXZpY2UNCj4+ICsg
KiBhbmQgdHJhbnNsYXRlIHZpcnR1YWwgU0JERiB0byB0aGUgcGh5c2ljYWwgb25lLg0KPj4gKyAq
Lw0KPj4gK2Jvb2wgdnBjaV90cmFuc2xhdGVfdmlydHVhbF9kZXZpY2UoY29uc3Qgc3RydWN0IGRv
bWFpbiAqZCwgcGNpX3NiZGZfdCAqc2JkZikNCj4+ICt7DQo+PiArICAgIHN0cnVjdCBwY2lfZGV2
ICpwZGV2Ow0KPj4gKw0KPj4gKyAgICBBU1NFUlQoIWlzX2hhcmR3YXJlX2RvbWFpbihkKSk7DQo+
IEluIGFkZGl0aW9uIHRvIHRoaXMsIGRvbid0IHlvdSBhbHNvIG5lZWQgdG8gYXNzZXJ0IHRoYXQg
cGNpZGV2c19sb2NrIGlzDQo+IGhlbGQgKG9yIGlmIGl0IGlzbid0LCB5b3UnZCBuZWVkIHRvIGFj
cXVpcmUgaXQpIGZvciAuLi4NCj4NCj4+ICsgICAgZm9yX2VhY2hfcGRldiggZCwgcGRldiApDQo+
IC4uLiB0aGlzIHRvIGJlIHJhY2UtZnJlZT8NClllcywgeW91IGFyZSByaWdodCBhbmQgdGhpcyBu
ZWVkcyBwY2lkZXZzX2xvY2soKTsNCldpbGwgYWRkDQo+DQo+IEphbg0KPg0KVGhhbmsgeW91LA0K
T2xla3NhbmRy


From xen-devel-bounces@lists.xenproject.org Fri Feb 04 08:31:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 08:31:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265160.458459 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFu0R-00051C-9f; Fri, 04 Feb 2022 08:31:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265160.458459; Fri, 04 Feb 2022 08:31:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFu0R-000515-6W; Fri, 04 Feb 2022 08:31:47 +0000
Received: by outflank-mailman (input) for mailman id 265160;
 Fri, 04 Feb 2022 08:31:45 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1gJ0=ST=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nFu0P-00050z-FB
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 08:31:45 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e26b82c0-8594-11ec-8eb8-a37418f5ba1a;
 Fri, 04 Feb 2022 09:31:44 +0100 (CET)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2059.outbound.protection.outlook.com [104.47.13.59]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-23-6zsKg6GMNWmLZglFpecr2w-1; Fri, 04 Feb 2022 09:31:42 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by HE1PR0402MB2729.eurprd04.prod.outlook.com (2603:10a6:3:e0::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.16; Fri, 4 Feb
 2022 08:31:38 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.014; Fri, 4 Feb 2022
 08:31:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e26b82c0-8594-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1643963504;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=LK/CR0+BBooKbsYdZzl2Ztn7yljlzCE0MS/S81bF6TE=;
	b=MGol7dZEZJmYzC5lcGyQ18pUv6VxR/gzaAdlMma617X6XwhecVZDKDw3jB8S7+Z9A/kQUT
	aC0C3hBpBc7pi+krRGAH0lks72xwaAuIiDrff/xDOlKH8nyTRFV4lMroLvqaa7YH+s3BPg
	KjqA76FxFOBH2TuFak3qpHpigwRZl2E=
X-MC-Unique: 6zsKg6GMNWmLZglFpecr2w-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gBQ45ptAFfrSPHnxr5JxiUAONZyYtwquJCvA2H32WMWOkeUxZZavzhhdBvYLEz4F2lBJ5EL1iXQNrH7LkuI2EEX7HGvRnM6b2yOPvvCxa4SaI9GUyRYZlWPzgIBj2GazAmLm2dumnM5lfkKxy3yxGJHsStnMvnQMe3BggR+JdhocFqWlHt8xuxoeN0gcr34ORcqBQKAwOd9dQ/kj1OiFx/cH56zaWoGgDMo/UuF5tfIG3lpr4rwf6R4abJ2cXFGu7j6rkKFMu8j30iKYWn/Ip7YOLrGzDdEFXC2YesDmoUxbSFB1nOgUI8poFd1BNOLcQi12xDG5j54SUXU3nR9YcQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=LK/CR0+BBooKbsYdZzl2Ztn7yljlzCE0MS/S81bF6TE=;
 b=SS4lroUtoN7IXsm8d2/2wA9k1QfqlBX6TsJNjTVpeQKfHBDrlDgLNegSwa9Jr9tFq1VVyERreslwYe9soh35r5Io47H03YGj6G91ltNEUYlU/FFhB90hSG68U8Pas9nRtu5zYNRghfO8GAUU6XX3BG0XjCeQnJZQfme9Bj/UTD/pbzy2KIjzAUwG0LHdOfp+GBtyF2C7iDEfK0+rnBzqzRVc+1RU2YqXDOWjty6gbY41jyqcRrjBThaCZFgwvcLMzTHPpmgsxUqC+7G+HeldSVog5uZOmg/gdP13EZLaYBCol01rms06Uesn/zKE8k+kt6vL85M5N9yBZ3RHfw+wlA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <53b98995-8cef-48b4-7728-3bfbc236af5f@suse.com>
Date: Fri, 4 Feb 2022 09:31:35 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH] tools/guest: Fix comment regarding CPUID compatibility
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Cc: Wei Liu <wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>,
 Juergen Gross <jgross@suse.com>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20220203181023.1554-1-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220203181023.1554-1-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P194CA0002.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:209:90::15) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c3c4cc48-c2be-4814-ec1c-08d9e7b8c2bd
X-MS-TrafficTypeDiagnostic: HE1PR0402MB2729:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<HE1PR0402MB2729B0E5083CF85197255625B3299@HE1PR0402MB2729.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3513;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	WRWG4Utf97o4NtDMIlPTUbvL2dgSb7Vw5VAT6U1/271Q2uO/eUMQ/Y9OOHNfUCingx14FiMwnW6Tkb+bryyU769ekQOzqXnxHTW9+51zrxDRYoaCp9cSDhm+Y6vAuIvAmxF3kabCWTP5AaEi/Lri6s3V3GvbGVBFYyhzuzjjiXpK2HGaiwMJuf8UPV1z2CcbF07WfLOeAP+gcLc1RfaXva7CeHNDVOJUw2d2m5SH1Y78bFKbQs3Y7RgYjUw8xHcq+6sb2FgBFbKy98kG670ETkvWnHXGkjjMaUL7YLoSWkhpOo8a0pZbZZY3XBOuzrqYIWXeQ3iEWrmnDcIUsALgzWyFlrJIzTTnW/igJ0qv5REIbgYLOmvwwEiJktpE4ZKSJHbbuuWzMxrJXVsVBNCudEHZZJnFeumxDRSZ/yReBdPB20/WPV9IrlvOhge1FVCbNRxkfM8ffIj3ub+wZv/kfg7D0Vk9wCk5uiQLbXsp01B5zprq6JKim/c5HWDnFPt9SJbwCUKQ5H837q5iqdo8LFsEdtKjsx+hYxsWgNdAzhcSAij8oVz5d4NUncr34GdF5AB19rf/1ZgjrlX9pgH/o9vIzSdzmqm4JPWpmDqYqpAHvkoiwKM3Kv4XBaCnxGolqdA8dc/dLxT50yxernzVX53tjhw/yxG8q2APvvVmb+r0PrjUAMvf/ihB5u85uyrZ4Crl5epwkHXleN8blpvDgyhVrpwdnbUiZWcBnV1JJJk=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(508600001)(5660300002)(53546011)(83380400001)(31686004)(4326008)(2616005)(2906002)(66556008)(66476007)(8676002)(316002)(38100700002)(186003)(26005)(110136005)(54906003)(66946007)(8936002)(31696002)(86362001)(36756003)(6506007)(6512007)(4744005)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NVFFYWhPenc5K2lKSXZyb0pUNkYxd2VNS3EyRG8yMzRzbWk5ZnduOG5GVktj?=
 =?utf-8?B?MVduZDQzWXgvUjQ0OEZraWpQMmJabWpINWtQWjZnUytudm1MOTV6cTRmR2RQ?=
 =?utf-8?B?LzdZL2x5WGpjUWNGdVJ6Yjl6ck5wUEtzRjZMLzh4dUVSM1BRV21ZZHZ5WVp5?=
 =?utf-8?B?ek50Q0dJUEV5cDBPM0FCaXhSQ1ZtNDhiazNaRVRkcDNuRXgwVmQ1Y0tZaFNQ?=
 =?utf-8?B?M2g0d0dDcTFpOUFrejMzZ3NRWkFKSGF0eThyVjdjTUdDVEJtSWFENG9pcmM1?=
 =?utf-8?B?bjNvZmVBcXFqdS9EcjVvcjU4ODZRNGs5MHA5Mm5KNkhyckpoSU8rcDNsVFVl?=
 =?utf-8?B?UlFhMmI3TEhsdStBQytIKzkzMXd2MGRSdW4zNngvM2g5bHRZRUd3eXFmZHFk?=
 =?utf-8?B?V2dGRWlxVmE5R3l1Q3U2UFVRTXpqVHlGQXhLMG9tdXRlRjE4bzdDd2lSVnBB?=
 =?utf-8?B?TWxZaUQySXdnek9FUTF3b0VnSnIyYnlTOFVPMktqb2dpSHZuak05bXhVSHJ2?=
 =?utf-8?B?YmdHV2Y3ZEJzK3RZOWtVREd5cTQ4TWEzTHNyZTNqRlgzWjY5ZUVaVHl6Y1BK?=
 =?utf-8?B?RXpkdTI1anFHa2pvcllTWTdYUE1lWjhTMHlBNjhTUlphRWJKN2xHaEhmTzBa?=
 =?utf-8?B?amJQZExVa3BNS0ZvTkxwME9zUTBlaEk3MDBMNkJPblJ2bXZtc1o1MkJpTHQ0?=
 =?utf-8?B?cWt2OUI2eXZUSVhjTFkvRG5TT0syQzlZcWcvcmhUVm1wNE1adE5FVkRjTWFt?=
 =?utf-8?B?TDI3MzkrUGY0anZGNmJlWGVhQXJCS0h6elorbjlMeSs3K1lSNXMwb3Q5YVhY?=
 =?utf-8?B?RFRSRWh6REY4cmJDZGhnM2JXRCtKTkE4VEtlcnZyNFdKeTAxQXdZRm80RFJE?=
 =?utf-8?B?d1VxZ2Z4SklqR2hVclR3dEhLZk1iR0kyQmRzZEczaUVOS0ZIYVQ1NEd0SUU0?=
 =?utf-8?B?dFE5VW9tMEhFSTZzNWhGNDRhSWhxSEhIcDFZaVdSMGZDdTRRSlcrMFVTcjRC?=
 =?utf-8?B?OEx1S1lOUm1DTVZYMjdmQzBMb0tyMnpzTnVQbWRKMktBZDFxcFNYKytGQ0do?=
 =?utf-8?B?WTIxbWpSK09HdFd1MlNEb1RGODhqdDZ2NFVBQjkvdS9yRmdBb2pNOVFZMG10?=
 =?utf-8?B?Q1ZKNWJZNlVMTk9zZU9Hd0swcFNhWFRzNUUzL3FPZ3JQR2lmM2tHRllyQmFa?=
 =?utf-8?B?MEVvSkR6cUdnL2s1YjVTcC9lcm1sWjlOck9YREFUNFRzWDgrQi9Yc1g2N3VD?=
 =?utf-8?B?NTg3MytzSEc0RjNDRlRyMkVTOWxrTitHbFprdDlVT1hVQjc1K2l3SUoweWZL?=
 =?utf-8?B?czhlVE0rUGVFWGxya3ZxQ2pZTXlFeWwwdEJIMEtWTlFFcnZITHpCRGVvSldX?=
 =?utf-8?B?M2Z1TERnQVA4aFFJVTZoL082RWJZZkpzQ09Oamc3eWN1MDJNUmJ0TWQwK1lQ?=
 =?utf-8?B?Z3NyamJsYk1GMm5uZFcxQU5nZ3E0WWo0aUo5elplZzN5NVVhZlZLR2pYVzdt?=
 =?utf-8?B?Ukp4dVJEUEhZY1F6WEl5VFcybk54ZU12cVYvbndFNGFhVlZTYkpEbkJUcXN2?=
 =?utf-8?B?VG5OU3ltQXk1OGNEaDcvOGkxVDV5aHFGMDZWdXlKZ25nN3MrMW16RzkrREpF?=
 =?utf-8?B?ZE80WnAwaEo1dGlxVnI2eTJhQTl4S21kOE0yK21WeFQ2Vkk0bXpTbHdQMmVv?=
 =?utf-8?B?ZTZGUWJKY1hkQkM4Y29USkQ3NTRrRlBqTDFkWVZCMHN0ckNkSGRPUDk0UHBq?=
 =?utf-8?B?b2lmZ3FITDV1MlZNR2hydHB2b1F4M0hQVjJNdUpnZk8wREdObVlmb2ZmR1dl?=
 =?utf-8?B?OU5BQ1c1cHQ4Ni9QU0I4VjZ1QXBNa0NoQlI1ajlYOEJEb21JVGpTNStCdXJn?=
 =?utf-8?B?WWErSmZiRlhhNVFZODBYVy9xcFZqdndaR2pCa2VMc0x2V3F2TVQ4ZmNHaXN3?=
 =?utf-8?B?VWIvRStocS84TFpLUUxlUEVWakFMRGlQNSs5ZW1wV0tyRjEzcDhWSTA4K0hi?=
 =?utf-8?B?SDNKOEhzVEJmUis4eVVGV3pySi9ZQWUxb2tWQTQrZERhN0d5Z1IyU3FCM2ly?=
 =?utf-8?B?RlVnMUJSa0RSSjl0UFFRaHcrUnQyOHVNc01JdWlVbkx5NllZSmpzNWlRTG0r?=
 =?utf-8?B?TEVIbHdEWGkvbHg5eHZTajFJMnZyRVpzdnM5SHA3aENvSnM4TXczYi9RN1NW?=
 =?utf-8?Q?nF0HULUOMdqIt2dXZCLKzbs=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c3c4cc48-c2be-4814-ec1c-08d9e7b8c2bd
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Feb 2022 08:31:37.8111
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3e07w+2F5SjmSfaloMw2SuJMmv3oFI3FPvZw7XQrMEJFQ9wH94mXbQxqsiQDJUn5Jzk/bmSqhKIs6YvCQ5BiQA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0402MB2729

On 03.02.2022 19:10, Andrew Cooper wrote:
> It was Xen 4.14 where CPUID data was added to the migration stream, and 4.13
> that we need to worry about with regards to compatibility.  Xen 4.12 isn't
> relevant.
> 
> Expand and correct the commentary.
> 
> Fixes: 111c8c33a8a1 ("x86/cpuid: do not expand max leaves on restore")

But doesn't this commit amend 685e922d6f30 ("tools/libxc: Rework
xc_cpuid_apply_policy() to use {get,set}_cpu_policy()"), which is
where DEF_MAX_* disappeared? That was a 4.13 change, and iirc that
was also why the commit above moved the 4.13/4.14 boundary related
comment from outside of the if() to inside it.

While looking at this, wasn't Roger's change incomplete, in that
for Intel the extended leaf upper bound was 0x80000008 in 4.12?

Jan



From xen-devel-bounces@lists.xenproject.org Fri Feb 04 08:36:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 08:36:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265169.458470 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFu5G-0005iv-0m; Fri, 04 Feb 2022 08:36:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265169.458470; Fri, 04 Feb 2022 08:36:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFu5F-0005io-S9; Fri, 04 Feb 2022 08:36:45 +0000
Received: by outflank-mailman (input) for mailman id 265169;
 Fri, 04 Feb 2022 08:36:44 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1gJ0=ST=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nFu5E-0005ii-LI
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 08:36:44 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 94c420af-8595-11ec-8f75-fffcc8bd4f1a;
 Fri, 04 Feb 2022 09:36:43 +0100 (CET)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2112.outbound.protection.outlook.com [104.47.18.112]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-16-P5p9eoAONY-4UC6D0kgTsw-1; Fri, 04 Feb 2022 09:36:42 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM0PR04MB6291.eurprd04.prod.outlook.com (2603:10a6:208:13c::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.14; Fri, 4 Feb
 2022 08:36:41 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.014; Fri, 4 Feb 2022
 08:36:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 94c420af-8595-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1643963803;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=1TotICqAwwNoNsvdJSgFi+8lkACU119xtP8l1WMdwUo=;
	b=LAk2X2uvhyADjEQzVanBgBiQMkQ3FUn+tVMkFHfz/OjITh81W45DByOMQvrMMGyO1PF4nI
	zlYseTtjoC0pIyro7d7tig84I13v62ZZ/Epv5hOlW8UNIGx3i/GCOd7T2VTV4bvUn8tG4u
	mk6WrKYT7bir/4cqabMpZKW0wn3KBKs=
X-MC-Unique: P5p9eoAONY-4UC6D0kgTsw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=BYM9sj1MfqqPX2t5+G230vI8Ljnuy2cdkthCHc5ukLbaDun/cbaq5ZIMFhgLgCH6NNVAfDQHbCU6ClMTYqJ/1ceYoeSySnBDnDOUKgVqY3qLRlAij+q4EB3h1k6vXZWAsfAtwi8iDZNTyuNk0qXso1o6TFO91HvT2I1ABwFTVny6lJwTsh6lNma/kxlLhPC0OwnMMtiGps84GZda4W5jgVPAjT219h6IT96Ci/Q5SRISHkSyLGlHVQXiPg7ei1VSlXdK9HkUoCTGZrPfVTtcEcp7lC/gEpvDyRaVbMTdwNYylHU0BTowqdqo/d51IDRw5R8wkTyAvuhJCHbhKHpnxQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=1TotICqAwwNoNsvdJSgFi+8lkACU119xtP8l1WMdwUo=;
 b=g8x7Fyg9/AYGvFda/UYy2UDl56ssC0NoVcBE4+mlNqz+for2SgOPLNTga6ZQ5qNnRuWkzQSgGGbTO84Ox/nXKymVwwoQfLyy9juKRhdOdfn5D0hRYPKt6azPQlejfPT1Tqgyo7igErxKd+IIXpb3nNABYJbgQoLTLujCjqCnWCaxsa7XuXq0XCF/mPsL6XXnPbX4sSM6pZDsbFZKDLsVTkFxos7kzHCeMjZeztUFVbCzzNZxDJ2TQDVAOs59hYzSNL+MuARH1hEShL4eVDuYIbFS54u/XNHYWqh8bzCZ5JHc/Hgoo4KZMpLKlEEoqG4/h7NJ3ZP4Vh9HeLi1/2Kcqw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <b413b9a8-b595-d37e-c1c2-5ffab743cbee@suse.com>
Date: Fri, 4 Feb 2022 09:36:38 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Content-Language: en-US
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Cc: "julien@xen.org" <julien@xen.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Artem Mygaiev <Artem_Mygaiev@epam.com>,
 "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
 "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
 "paul@xen.org" <paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "roger.pau@citrix.com" <roger.pau@citrix.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-4-andr2000@gmail.com>
 <7209889d-8f17-61cc-72a4-97f6dbc1d54d@suse.com>
 <fec9b8f5-05d7-8d0c-2ae0-0224318dfd13@epam.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <fec9b8f5-05d7-8d0c-2ae0-0224318dfd13@epam.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0355.eurprd06.prod.outlook.com
 (2603:10a6:20b:466::22) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d3b341d1-2d21-4897-7952-08d9e7b97782
X-MS-TrafficTypeDiagnostic: AM0PR04MB6291:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB6291D96F730FF983EC9B1369B3299@AM0PR04MB6291.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	/l+IXUicZ9V0dvKkPGTZykbTCqNyQr9U6yfdyZWkA/7nx6vvNPfmLjzHStcAGCbMyvTCkLET23QPIrn1MUIg9wazZrAWiLSIsk5nfwMUMLwhOPPguWDlGsk1FBDvn0SV3jMH4ccHRC3WmQ+epfE3KQMf3q6YJ8s5lnzgxai/F1J23OKSK1hvsJ6i6aFonHpzTj366iK1oAp0XibnyJLTUOGff8qpykP5sF77OGb3dGhvQM04QWV5Z1mEyN86i6gdhwZKoQNjp4Fdoh+tBUvdibJ6rW8rF6GgT99mtc9n/LLsL1AbxuTdXSPTxJZPjvbTS6+aaSsjME+sHH3cz+6JYWLE3ytDLvgLz5YDDXAa1oTLsCyJfJ0Fw+CjUGvHxvoBFD13ZclVjlDgLfFxZip6umUUGgQS5iHGcvXVETthB15hMskkdH26I2EMPE2Msh5lizeQZr+PAo2liSiXHXjKCwmdZOrfcSVgn7LxngEe8KJ45+d8u39eZKU1YseoDsVPSFUP3/ZKd0jFKrcBvgX1tvWva/eYPsvEiK7ht1hDYBcfUHoZUH5MBh6Vmat7TPYRhpvExwBg9mKwuO8+ywaYaLG2IYMHimJdpht9EkjB2vQXuZvzP63VBiU5BLxbLRzAZ4ZrpSgtC173WpKk/RNcL2qMGh9oRbGlGv+MWSbU1DbzmOS8sypRv7B6zuryyaw4dFMEsupEuBhvdgKWrKH4ABsiIrOdbS3dv752v4CXmDo=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(31696002)(83380400001)(86362001)(66476007)(6486002)(186003)(66946007)(4326008)(38100700002)(5660300002)(66556008)(54906003)(8936002)(8676002)(2906002)(6916009)(53546011)(4744005)(316002)(6506007)(7416002)(6512007)(6666004)(2616005)(26005)(31686004)(508600001)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?YU95bENWZDUvSVY4YjJvRlZQUTdyZ1IvRzNPa2ZoRXA1RE1Tbnh6Q3hBZVRO?=
 =?utf-8?B?UjBqRlowMVh1UGNyakRHOW03eVhpVFhCdzRIVW5wY0JQUTdveHdzM28zNXBs?=
 =?utf-8?B?Y1ExbFJJQTVjMmVMUkJHenAxUmN3b1pWZG8rMlZIYUdUell1L0FraFJ4dHVT?=
 =?utf-8?B?c05mSXg1cU9wUVBMWEVzQTRKam1FOEpadk9LTzZ2NW9kamUzV3JNZTBBcnJC?=
 =?utf-8?B?QVhhK212V29KYWtKcklQR3Y2L0pPY3lhNFVBR3VSTUZXak11UnVYcFROa3Ew?=
 =?utf-8?B?YTZmbzlLa0VhRWxEK1lvWlpKWWhKakJrejhTdUxFaWlBYjZyZitDWXBmL2t3?=
 =?utf-8?B?VFJBMklEMzAvOEtrV3diUEhCeHlsd2dxK1U4UElWNlF5aVhUQ3Y0dm5NSGth?=
 =?utf-8?B?RGZ1OG9DOEYyV3NHTG1ER1E2TXZqcnFhZ1cvRmx4SWcyRlRZN1drelZGOTZY?=
 =?utf-8?B?UWNBOEExK01xK2U1MjFoejlhRkRPQU1CZUJwVG0xVHkxblJaRGk4ajlES0Jr?=
 =?utf-8?B?T1VBejFZOTExRE1FY2N4UTQrTmNwaVBuV3pxY2RxaUVJTTE1R1l2VnpKYkNB?=
 =?utf-8?B?TnpkdStyMEF4MExaWk5RY2U1NnBScGtTQUk2Y3BMZzdVZ0VYSWZ2RFdVTFZn?=
 =?utf-8?B?eVliNWpPUWJKa2ViVzJiMnBzdUtDRW1BRi9sOG83ckZ0bmFKNXlCOVdaeUhj?=
 =?utf-8?B?UkRUcVVRT1ZpSHFFU05GY2VvSVBVT1dCNWw2NGdib3QvL0pPT1k3Vk0zdjND?=
 =?utf-8?B?R3kwYmZSU0V4WFRtYTNqZGVMOVlsQm9pbnVSN3k0LzM1VmZ5K0pSWjlESml0?=
 =?utf-8?B?cnlWdUZqYy90MFY1bG1ESE1aOTRxeSs4aHR5NmxnbTJ0OTQrOFlPTlBGTmNw?=
 =?utf-8?B?ekp6YzlMZHJzdk93UCtzU1k2WkF2S2RlMGRFT00xbjNZRytGc3hVOFFUZ3JJ?=
 =?utf-8?B?V2had3AzZ3VNeDczZUVzcGpNNGRSUEJVb2E5ajhUTVRHOFZJbThSSUszNWp3?=
 =?utf-8?B?YUhQa3FuRG5WZUN2dk9YTmNLT25YNFBaaTBGeDFwZEhMZlJoQjIvWG5hQ2ZW?=
 =?utf-8?B?M3VHSzJLaTRWV0MzZDQ2YVJrSlNiTDVXYmJVaSs3V2xRaE9hZVNESzJzaGFx?=
 =?utf-8?B?dThwWTNBamJ4V2ZrTkVVV0hESml1YWwvQTVLMnpwclFzM0hXMG53UVNjMGlJ?=
 =?utf-8?B?aDY0TExURFZWcmhWUEJhdEc3V1ZCYUxvT3g4NEczL2NRblhCVncvN1A2TTF4?=
 =?utf-8?B?N1ZtSnBTenRQVlFjQzNhZlFWeGZZRWZtYkNTNVBheVJwcVNaZzk5ZEVDcFlo?=
 =?utf-8?B?K3V4VVdBZXFuYzhTanF3Q2VJeE1nK09TQ1poZ3IydS9kVW00b2FzRUUxdHYy?=
 =?utf-8?B?aUlyRERBQmVBUFhrOUk2d25RMll4V2tKOHBSTGhhN045L1k5R3BwanJEOFRi?=
 =?utf-8?B?a09jb1A2OGFQSWJ2T2d4cVF0dkJzZzJacXVTd2toclQxK0FqTC9OVmFJV2Jq?=
 =?utf-8?B?VEhMaE9SMmNGaGNpakovbFBFVTNMZVlGUllQQ1pFVXZuM1JVNGJkVEt4SGZp?=
 =?utf-8?B?Wk5ZTU8wWDVGSGhNM0VVd2lyYTBRay9QSXN5eE0yMkFOdW5qYzZycWhuM2Zp?=
 =?utf-8?B?RHFUWUZRTXY3N1dTVUZqb0xPQWdva3cwS2FCOVMwVGFqeXJBbW9jT05WSVZN?=
 =?utf-8?B?d1lBaWY4NFhKYVVwZ3JaTnRHYVg5aEo5Vk1IdlZ2bGJLYUNMSE1mRFhXTG52?=
 =?utf-8?B?UnNTYTI5ejdJYk9oVmxUcnlDeVJrbmJMNG9Wa3Q1N3NFN3RseFBkNjByZkkz?=
 =?utf-8?B?Um0zbzcvbnZBU05YLy9DdXoxUzBvUlRneHFpV3JhdVY5ZC9VUjA3bHFFME5m?=
 =?utf-8?B?eFVxK09EOEh6WkVKNUo1M0JGTU9SeTdpbktaWmxTM2Y5UUUya01NNkttN0xw?=
 =?utf-8?B?U21jSVkxL1RzbUtzeitPcndOTTJyMkZITFZ4QVVDYUVUU0ljb0dqQnQ3b1JR?=
 =?utf-8?B?NFJDZjd2cnE5SkRObFR5WkVhK1hwcU42djY5ZXhGRlp1M3FsM2s1VWRXWXJO?=
 =?utf-8?B?R25hNTk0TVlRN0NRRnNsOTRBVGdWYURnZkx2bUR1Q3Jrb2F1ZzQzZythU2x4?=
 =?utf-8?B?M0NjQldjR2FpVTJNM2QwWEpvaDYxbXpTZE5Pdzc4RURQdkVqS1ExcjB2Rktj?=
 =?utf-8?Q?ncM3sNBfU2Hoy1RcRg5HlAc=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d3b341d1-2d21-4897-7952-08d9e7b97782
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Feb 2022 08:36:41.1203
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xfG7eN3YP5Ojf7E0pTHHIplaiXvK8eMcHKRJ7qe2QCFBClFP0t9mWtmxbDsHjPTM62J3mD1IbFvobfcsOETGUQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6291

On 04.02.2022 09:13, Oleksandr Andrushchenko wrote:
> On 04.02.22 09:52, Jan Beulich wrote:
>> On 04.02.2022 07:34, Oleksandr Andrushchenko wrote:
>>
>> At the first glance this simply looks like another unjustified (in the
>> description) change, as you're not converting anything here but you
>> actually add locking (and I realize this was there before, so I'm sorry
>> for not pointing this out earlier). But then I wonder whether you
>> actually tested this
> This is already stated in the cover letter that I have tested two x86
> configurations and tested that on Arm.......

Okay, I'm sorry then. But could you then please point out where I'm
wrong with my analysis?

Jan



From xen-devel-bounces@lists.xenproject.org Fri Feb 04 08:51:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 08:51:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265178.458481 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFuJ9-00080r-7s; Fri, 04 Feb 2022 08:51:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265178.458481; Fri, 04 Feb 2022 08:51:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFuJ9-00080k-4U; Fri, 04 Feb 2022 08:51:07 +0000
Received: by outflank-mailman (input) for mailman id 265178;
 Fri, 04 Feb 2022 08:51:06 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nFuJ8-00080e-Ib
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 08:51:06 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nFuJ7-0004zO-30; Fri, 04 Feb 2022 08:51:05 +0000
Received: from 54-240-197-231.amazon.com ([54.240.197.231]
 helo=[192.168.31.165]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nFuJ6-0004pp-SZ; Fri, 04 Feb 2022 08:51:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=QbPLx9302bQDr56ww36ibnkP7vYC1Av2h3v8BLGChx0=; b=y4OEfhmBJ1Amnw9koQuNeg7bCS
	5sVKWUNZT7yUz3H7hig+ZKbJKhsQ7NMS3H6OrHs5zoaErGH1YacZEdklrNyhK1z46KNObmNKfyatK
	uqOkoPXy1KzaOsM/p4tE1tBMibJ8iC44VVf8ljsliY/LZhIKFfDUf439v+OuCNXv5PdE=;
Message-ID: <000ac24e-fdac-855d-7fb4-2165a1192ea4@xen.org>
Date: Fri, 4 Feb 2022 08:51:01 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.1
Subject: Re: [PATCH v6 01/13] xen/pci: arm: add stub for is_memory_hole
To: Oleksandr Andrushchenko <andr2000@gmail.com>,
 xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, oleksandr_tyshchenko@epam.com,
 volodymyr_babchuk@epam.com, artem_mygaiev@epam.com, roger.pau@citrix.com,
 jbeulich@suse.com, andrew.cooper3@citrix.com, george.dunlap@citrix.com,
 paul@xen.org, bertrand.marquis@arm.com, rahul.singh@arm.com,
 Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-2-andr2000@gmail.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220204063459.680961-2-andr2000@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 04/02/2022 06:34, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> Add a stub for is_memory_hole which is required for PCI passthrough
> on Arm.
> 
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> ---
> Cc: Julien Grall <julien@xen.org>
> Cc: Stefano Stabellini <sstabellini@kernel.org>
> ---
> New in v6
> ---
>   xen/arch/arm/mm.c | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
> index b1eae767c27c..c32e34a182a2 100644
> --- a/xen/arch/arm/mm.c
> +++ b/xen/arch/arm/mm.c
> @@ -1640,6 +1640,12 @@ unsigned long get_upper_mfn_bound(void)
>       return max_page - 1;
>   }
>   
> +bool is_memory_hole(mfn_t start, mfn_t end)
> +{
> +    /* TODO: this needs to be properly implemented. */

I was hoping to see a summary of the discussion from IRC somewhere in 
the patch (maybe after ---). This would help to bring up to speed the 
others that were not on IRC.

> +    return true;
> +}
> +
>   /*
>    * Local variables:
>    * mode: C

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Feb 04 08:58:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 08:58:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265187.458492 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFuQN-0000Gy-1G; Fri, 04 Feb 2022 08:58:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265187.458492; Fri, 04 Feb 2022 08:58:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFuQM-0000Gr-U1; Fri, 04 Feb 2022 08:58:34 +0000
Received: by outflank-mailman (input) for mailman id 265187;
 Fri, 04 Feb 2022 08:58:33 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=u+82=ST=epam.com=prvs=4034f0a382=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nFuQL-0000Gl-C5
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 08:58:33 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a010830f-8598-11ec-8eb8-a37418f5ba1a;
 Fri, 04 Feb 2022 09:58:31 +0100 (CET)
Received: from pps.filterd (m0174680.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 2148wQdT018409;
 Fri, 4 Feb 2022 08:58:27 GMT
Received: from eur01-he1-obe.outbound.protection.outlook.com
 (mail-he1eur01lp2057.outbound.protection.outlook.com [104.47.0.57])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3e113t800b-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 04 Feb 2022 08:58:27 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM6PR03MB5879.eurprd03.prod.outlook.com (2603:10a6:20b:e9::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.14; Fri, 4 Feb
 2022 08:58:19 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6%3]) with mapi id 15.20.4951.014; Fri, 4 Feb 2022
 08:58:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a010830f-8598-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=J1qoKf+dd3SD2OEzvPVJfMCg9g7jk3N8p0AN6ojWWngO0mGPev95noW/pnD0KYC0ZQqV2BIxteRfAoa8hhLqVk0z4SUU3ISJX64gGV0/u+Ai8Du7kAxqwUEQ3MRvZBqhhqkR9NcxKEVfi3EpMNawvlAOYa3TsPolW0auB9V6DNYQUoEjNAfeq40bpvKaveJA7RM1CTzgQ3tneVvJp2uqv2JbD8ml7FucMGLECky3VUxGWXqgUt+oXxXnW8w0NcJi8XaG0rSVQOqeaG4qhFkXnNEae9t8+9j5QY3Oyf5Kdf1Q+djEmeW/D75G3zTTIznEvzQVcLSicAv0HEynbAforw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=sR02q3Oc3IfIcioWn60pYhXcrx/3K1XrtBzaE15zDFw=;
 b=GB16q80nQnz0cvxI85klfdLh1nWcIqg9ssfL7+wMkrUTiqhZTuJwX9QGKmg5ALvyztT7/KjdZIyB9kBe3BCinzO8G3LLGDD7T+/xy4blivAoTFZKi5+LzWKICPiBvxjxAZr9TyukIcxnWwVCMVoxQfG7JIIaY7OwnYYWBU0peCFqRIE892dZ/QlgouAerSIWEUWlh1JasbCxSLHj4qe4ugWwNa+asnVYOsXadBCMleeJx8E+4N6L8A4ew6dG8Cf4VUKbq6CnfLOKQTDJIrncLiBOcf+iI0rF9T/w1+REwOjYJrEy3sqAkKAKM9oyx5N+Yx4pZmg+VeggmKnfAeag9Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=sR02q3Oc3IfIcioWn60pYhXcrx/3K1XrtBzaE15zDFw=;
 b=VgmbQ6+znF7mjzocvoFLj+zirm1fKvVugw8L0AUApDn1kEupmOQuokv+oOxG5wHUFHP8bOgp5TOGKWo5dp8yxZR6A7htQeQav9QzFGsrIoPWMXtt3IBKLYgVgDSqmxjDtgLKVjvM9599p7BYJZ/OekSY7pN7eMDQDC1biC6jKPkl9ETpFnlWd8YuIEq51yCdtzrxSaKK6rTi765NBNB2kdEAqd0RS7RTqE9UL91R4omnBRXZbJKOk7oHUcm9bxR1h1ifNB3ufg4mixqkmQtBVlKM/hh3Ot40hwTDSGhxG/6ehdng6cxWcZF5bdADBGwDBy1R4UMi/VLNdLIeg6FKvQ==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>,
        "roger.pau@citrix.com"
	<roger.pau@citrix.com>
CC: "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Thread-Topic: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Thread-Index: AQHYGZFc/MnzQOjwVEeBBUHLSW0md6yDBUkAgAASSAA=
Date: Fri, 4 Feb 2022 08:58:19 +0000
Message-ID: <2cf022f8-b000-11b7-c6b9-90a56bc6e2ea@epam.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-4-andr2000@gmail.com>
 <7209889d-8f17-61cc-72a4-97f6dbc1d54d@suse.com>
In-Reply-To: <7209889d-8f17-61cc-72a4-97f6dbc1d54d@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: f601c9c8-6668-42c2-c85c-08d9e7bc7d5c
x-ms-traffictypediagnostic: AM6PR03MB5879:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM6PR03MB58796438DA3D98BA8ECF78ECE7299@AM6PR03MB5879.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:7219;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 3dMki5hXvl97dPxS/md2NH32gV57TLlpWZYlwqSjayXQenHp7LlDrfEWU46tQ+b4fVcA+03b9W7Ghkn2CY+nhgjCI6PTmzTjxWCHhclNslkCmv4FKz0t4KgQqer9isclTMaFXyXqyS+gSAKX46ywFqan4ZOtmmizqE8OnvxAX6k+uI7Ij9wMmQHX7PK9bKd8PUfXbeObk/v55+EeDno0Ww3XPOuNBoMq5DSVKWptobkiHnEWMv5TGVHHAUpi1KAreoMYeyNz6o4u6ruaGr4RZA+DvIZhy3LOWmNjGL92CLEU0mbdva/5LkxRUtO1hADH9c7zUuiqYhyNG9bdZupXO1EQ3u02y8sSedHWbVgNFqvIfk0ZTvBMEavEQ3ghhRXFIkleovXWPIkTGDxiBLzeJVKkoynF2JabxQaMQ4GurY24Y4zqad23pi4UOcnnOPzlYVlTs/Rd4igWl6UUbpDd9LZgvSSPRNBfetNTjmlK8Fedor/GI0wx8K5mCYuiCk5SrtEdGUQIVHJxxu0A8FpbKLSbEYURq6Fws5woodAjbMFo3RAJ03lY3p/cGdJOfp07hcSHnmIf3CDafnLH3ZCdsI/9m8288EYhqb4ykZ6H5KLQapen1mmK3HgexrFBZ/aTgwXYtlj5qUuKu5M0Qx9pnpRj2RifFCLMMUl5to2d6f7mzDcCL8uucIz6mZHsX6qUT5BPbZ7+OXcrDqZLmGeiWZMn7+Sn45/+j/MpMqTY7yG5dNQf9w0TkBwDTMPK3vaTsAlgosrx22xuc8sAA8Zxkg==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(83380400001)(107886003)(6486002)(5660300002)(6512007)(71200400001)(7416002)(53546011)(186003)(26005)(31686004)(2906002)(36756003)(508600001)(2616005)(6506007)(38070700005)(86362001)(31696002)(38100700002)(122000001)(316002)(64756008)(66446008)(66476007)(110136005)(66556008)(54906003)(66946007)(76116006)(8936002)(8676002)(4326008)(91956017)(45980500001)(309714004);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?R2F2ZFRWVzdTcjRIWXFDTG0wOUE3ZEs2S2l2RzE3V2c0RDlHeFFBOWQzVk9n?=
 =?utf-8?B?b0JsMCtvMEhDaFFUcmduNFZVUi9tWjIwajJnWHlNcktZdCswbXFiUWZHeDJx?=
 =?utf-8?B?TFlmOXlPclR4R3Q5R3g0M1R4SzJSaU5jdmFxVnVZTFRrM2VrWWhoc29lTFI0?=
 =?utf-8?B?Y2t1a2VMaEpTNVQzUDkzdC9ZOHYvVUVQRGNuVDBhM004TW43a1RkV1dpd3NY?=
 =?utf-8?B?SXZBVHNxNXlHTHpRNkFraUViMm9LQkFxMnliMWx6elN3OGZZZUtxeDRNaHN3?=
 =?utf-8?B?WjMyZUlqaXJmekFGTm16aUdUa21rR3IzNEdwU0grV3VaZktqYlNMdU5yMGpD?=
 =?utf-8?B?a2s1Wjd4WVJhY1lHT0Y1MCtsWWE0bFVya3k3L0kyam9NMVJWSmFPbkNTRUI4?=
 =?utf-8?B?ZGMyWkovcStEbEFVNHMrYktwMHF1SEhGR3Y1LysxSWtRc2F4Ync0eDZhR2lM?=
 =?utf-8?B?U1dKYjZuN2hEQk1HRzQrS1d4TUtzSGRGZUk0eXJTYXB2QUhxc1JzdWt1bFg2?=
 =?utf-8?B?SzA2SzZoK05DbTJCdEw0T0FVdWJLY0s3eXNMMmhKOGllSjl4K3BIZm9MQ0Jz?=
 =?utf-8?B?T2ZoRnJQL2dDZGh4OUovZ09NTUZRNHRiQi95QkpXZ1ExQ2JXMVg5RUYyRDRT?=
 =?utf-8?B?dFlnd0RtN29PWkZDZ2VSS0JqZGZpNmNjV1VMZXJ3YWw5MTlEUDJrYVJ0cEFG?=
 =?utf-8?B?VWIxVjhTSWdKelRuUjJNUWZMcjROdGQ4OE10N0FINCt0MmZMamQvcHNwc0VD?=
 =?utf-8?B?cFBUTldMMWJBVWlTVjBGK1NoUzU1eTVzZGtpcEJjeFNzdjRjenZQcXoyaUc4?=
 =?utf-8?B?M01TOVp5NnJSaUVnS2k4MzlHKzdoamZCd0xWanpLTU1JdGVQTFM4Q1hlOStv?=
 =?utf-8?B?V2J0dmZaeHRkQXNtRFNyK3lzNFFwYUlNajlWSUcwa2Uza2pTcVFOd0RjaUxF?=
 =?utf-8?B?N2tHTVVhWWlncnlkQmt1T1RJZnllc1dpR1pxR2FxbURFcEM3T3Q1Z2NyNnRj?=
 =?utf-8?B?S1NnNjdrZ3VEZGZwUTJLQkJSYWhTT3pNYjIyKzl6MzRkOXAxdjREQkI2bkYr?=
 =?utf-8?B?R3YyUlppNWpCNFJTMTFBYWxHVVdJM3R2Ri9iZE4zTnk3NElMNHJRYzBod2VT?=
 =?utf-8?B?aEFtSDNSbWtrcU1rOHBDcUpxNXFmMWw2TnA3Y1lpYVowMFBLNnFvRjZlbThn?=
 =?utf-8?B?Q1lFOWxWdDQ3dzBzRWdpaytRZkFpSlFpbndIdVJrSnVITE1PTnhsVFdhSUFE?=
 =?utf-8?B?YTZ3Qm8yVGJQeEFKZ2NIUE5mdVpERVdJQTg3MGtBaE8vQm90VzhtNFVvSWZJ?=
 =?utf-8?B?NDNUaUQzSnlBekR5L05iSC9GRTg0MjhMZDVOZ0FGODBwSDM2bjZHMExsUlpq?=
 =?utf-8?B?eHhIcDdkcm51OUhUaEU0RFV1dXMxckJVakRaN1lDdkozRHJyWWd0KytBdlRM?=
 =?utf-8?B?b2s5UFdlQ3ZSdm91M2FXVXBRNGhPSTVubHg2UTJWaXhuNjNOMzRVYi9semVW?=
 =?utf-8?B?MEoxa0xSM2ozTUNtVFkxWU5McWtqcUozemtDK0VKWW1QZGU2MU1KSEdYZkQ0?=
 =?utf-8?B?OU5WU1ZiVkFsamJVQU1qSGk3d3FiNXdoRmZLTlluOThRVC9CWVljNS8yb0Vm?=
 =?utf-8?B?RU93d3dTQ0taY08ydUZ5cTZnT0lPTnBHZHM1WjFhZENDSlIvMmJBOUlxcU9R?=
 =?utf-8?B?R2kzakMyUjdHdUV3U3lTSDcvOWZhdkgzZmo5dXRiTWNMUDhJeHlubnBlOXdV?=
 =?utf-8?B?VjhqeDNVVFVYLzVhRTNGWWZ4QUI5TVo0NHdKaUhvK29ua3ZQcGJDSGdvSmhL?=
 =?utf-8?B?QWtSVHg1c3dVMkhhMU45YkZhajU2R1pOQmc2SWdLYVdWTDNkT0ViWHEwc0lz?=
 =?utf-8?B?Q3B2bW1vb0lGaU5qdWtUSi9mbHNXVkJpUjg3ZkJnaHYva1RodVZGUGJtNk1C?=
 =?utf-8?B?bWFHaWIrVGgrblFPT21zY3o1eWJObCtPc1RDQ2szMXpYekRMRkx4NTVnYzk5?=
 =?utf-8?B?ZjdsTUp6aVRqNmFhN3BXVC9OR2NLV0JhWi9rRlN3c2V3U3hsL3BpRUxPRHFm?=
 =?utf-8?B?cGtXSEFZVWg4TGw0bm5LbDhHWTZhN2lNZ1VPbm43YWwzVjE0RDl2dTV5ZSth?=
 =?utf-8?B?OUFLT08wbmtGMTFIZ3dSNkI3Njlrc2xKK1hSNy9raGozWFJMREZYUHZuN2lC?=
 =?utf-8?B?WDFDUCsweWRUdVRnMVdvS1VRenQ0dVdyVWwrUTB0NFBjNUcwT3NKWUZYMm9o?=
 =?utf-8?B?RHI5YjRERnU3Tzl0RDRGRzVkM3p1YWlBNTNKY1VkNEp4V1EwcVdpVW9NK0VS?=
 =?utf-8?B?ZUJ2ZnFMajkwKzZiRmk4L1BhdzlOcWRZelNPT3NvWHExTnQxU0MvQT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <5995A2B662924C4E941714726182A791@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f601c9c8-6668-42c2-c85c-08d9e7bc7d5c
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Feb 2022 08:58:19.2111
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: WxmNq4izbCHSA8biEXPn089z+qzyXHeHlcRsOdKxLhefjtrwEzgRq9r19NGF5ELu+ewOXzPBpEIMYSSbIJqxW9+PtNlpqtMToM4Dyq3kaxYaEV+UmOiPM9efN/YfSe3C
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR03MB5879
X-Proofpoint-ORIG-GUID: tdCBd3h8HUkjpJmjYfyJV73aBXOe8Zzy
X-Proofpoint-GUID: tdCBd3h8HUkjpJmjYfyJV73aBXOe8Zzy
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-04_03,2022-02-03_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 adultscore=0
 clxscore=1015 impostorscore=0 mlxlogscore=999 priorityscore=1501
 lowpriorityscore=0 bulkscore=0 suspectscore=0 mlxscore=0 spamscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202040047

SGksIEphbiENCg0KT24gMDQuMDIuMjIgMDk6NTIsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAw
NC4wMi4yMDIyIDA3OjM0LCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyB3cm90ZToNCj4+IEBAIC0y
ODUsNiArMjg2LDEyIEBAIHN0YXRpYyBpbnQgbW9kaWZ5X2JhcnMoY29uc3Qgc3RydWN0IHBjaV9k
ZXYgKnBkZXYsIHVpbnQxNl90IGNtZCwgYm9vbCByb21fb25seSkNCj4+ICAgICAgICAgICAgICAg
ICAgIGNvbnRpbnVlOw0KPj4gICAgICAgICAgIH0NCj4+ICAgDQo+PiArICAgICAgICBzcGluX2xv
Y2soJnRtcC0+dnBjaV9sb2NrKTsNCj4+ICsgICAgICAgIGlmICggIXRtcC0+dnBjaSApDQo+PiAr
ICAgICAgICB7DQo+PiArICAgICAgICAgICAgc3Bpbl91bmxvY2soJnRtcC0+dnBjaV9sb2NrKTsN
Cj4+ICsgICAgICAgICAgICBjb250aW51ZTsNCj4+ICsgICAgICAgIH0NCj4+ICAgICAgICAgICBm
b3IgKCBpID0gMDsgaSA8IEFSUkFZX1NJWkUodG1wLT52cGNpLT5oZWFkZXIuYmFycyk7IGkrKyAp
DQo+PiAgICAgICAgICAgew0KPj4gICAgICAgICAgICAgICBjb25zdCBzdHJ1Y3QgdnBjaV9iYXIg
KmJhciA9ICZ0bXAtPnZwY2ktPmhlYWRlci5iYXJzW2ldOw0KPj4gQEAgLTMwMywxMiArMzEwLDE0
IEBAIHN0YXRpYyBpbnQgbW9kaWZ5X2JhcnMoY29uc3Qgc3RydWN0IHBjaV9kZXYgKnBkZXYsIHVp
bnQxNl90IGNtZCwgYm9vbCByb21fb25seSkNCj4+ICAgICAgICAgICAgICAgcmMgPSByYW5nZXNl
dF9yZW1vdmVfcmFuZ2UobWVtLCBzdGFydCwgZW5kKTsNCj4+ICAgICAgICAgICAgICAgaWYgKCBy
YyApDQo+PiAgICAgICAgICAgICAgIHsNCj4+ICsgICAgICAgICAgICAgICAgc3Bpbl91bmxvY2so
JnRtcC0+dnBjaV9sb2NrKTsNCj4+ICAgICAgICAgICAgICAgICAgIHByaW50ayhYRU5MT0dfR19X
QVJOSU5HICJGYWlsZWQgdG8gcmVtb3ZlIFslbHgsICVseF06ICVkXG4iLA0KPj4gICAgICAgICAg
ICAgICAgICAgICAgICAgIHN0YXJ0LCBlbmQsIHJjKTsNCj4+ICAgICAgICAgICAgICAgICAgIHJh
bmdlc2V0X2Rlc3Ryb3kobWVtKTsNCj4+ICAgICAgICAgICAgICAgICAgIHJldHVybiByYzsNCj4+
ICAgICAgICAgICAgICAgfQ0KPj4gICAgICAgICAgIH0NCj4+ICsgICAgICAgIHNwaW5fdW5sb2Nr
KCZ0bXAtPnZwY2lfbG9jayk7DQo+PiAgICAgICB9DQo+IEF0IHRoZSBmaXJzdCBnbGFuY2UgdGhp
cyBzaW1wbHkgbG9va3MgbGlrZSBhbm90aGVyIHVuanVzdGlmaWVkIChpbiB0aGUNCj4gZGVzY3Jp
cHRpb24pIGNoYW5nZSwgYXMgeW91J3JlIG5vdCBjb252ZXJ0aW5nIGFueXRoaW5nIGhlcmUgYnV0
IHlvdQ0KPiBhY3R1YWxseSBhZGQgbG9ja2luZyAoYW5kIEkgcmVhbGl6ZSB0aGlzIHdhcyB0aGVy
ZSBiZWZvcmUsIHNvIEknbSBzb3JyeQ0KPiBmb3Igbm90IHBvaW50aW5nIHRoaXMgb3V0IGVhcmxp
ZXIpLg0KV2VsbCwgSSB0aG91Z2h0IHRoYXQgdGhlIGRlc2NyaXB0aW9uIGFscmVhZHkgaGFzICIu
Li50aGUgbG9jayBjYW4gYmUNCnVzZWQgKGFuZCBpbiBhIGZldyBjYXNlcyBpcyB1c2VkIHJpZ2h0
IGF3YXkpIHRvIGNoZWNrIHdoZXRoZXIgdnBjaQ0KaXMgcHJlc2VudCIgYW5kIHRoaXMgaXMgZW5v
dWdoIGZvciBzdWNoIHVzZXMgYXMgaGVyZS4NCj4gICBCdXQgdGhlbiBJIHdvbmRlciB3aGV0aGVy
IHlvdQ0KPiBhY3R1YWxseSB0ZXN0ZWQgdGhpcywgc2luY2UgSSBjYW4ndCBoZWxwIGdldHRpbmcg
dGhlIGltcHJlc3Npb24gdGhhdA0KPiB5b3UncmUgaW50cm9kdWNpbmcgYSBsaXZlLWxvY2s6IFRo
ZSBmdW5jdGlvbiBpcyBjYWxsZWQgZnJvbSBjbWRfd3JpdGUoKQ0KPiBhbmQgcm9tX3dyaXRlKCks
IHdoaWNoIGluIHR1cm4gYXJlIGNhbGxlZCBvdXQgb2YgdnBjaV93cml0ZSgpLiBZZXQgdGhhdA0K
PiBmdW5jdGlvbiBhbHJlYWR5IGhvbGRzIHRoZSBsb2NrLCBhbmQgdGhlIGxvY2sgaXMgbm90IChj
dXJyZW50bHkpDQo+IHJlY3Vyc2l2ZS4gKEZvciB0aGUgM3JkIGNhbGxlciBvZiB0aGUgZnVuY3Rp
b24gLSBpbml0X2JhcnMoKSAtIG90b2gNCj4gdGhlIGxvY2tpbmcgbG9va3MgdG8gYmUgZW50aXJl
bHkgdW5uZWNlc3NhcnkuKQ0KV2VsbCwgeW91IGFyZSBjb3JyZWN0OiBpZiB0bXAgIT0gcGRldiB0
aGVuIGl0IGlzIGNvcnJlY3QgdG8gYWNxdWlyZQ0KdGhlIGxvY2suIEJ1dCBpZiB0bXAgPT0gcGRl
diBhbmQgcm9tX29ubHkgPT0gdHJ1ZQ0KdGhlbiB3ZSdsbCBkZWFkbG9jay4NCg0KSXQgc2VlbXMg
d2UgbmVlZCB0byBoYXZlIHRoZSBsb2NraW5nIGNvbmRpdGlvbmFsLCBlLmcuIG9ubHkgbG9jaw0K
aWYgdG1wICE9IHBkZXYNCj4NCj4gVGhlbiBhZ2FpbiB0aGlzIHdhcyBwcmVzZW50IGFscmVhZHkg
ZXZlbiBpbiBSb2dlcidzIG9yaWdpbmFsIHBhdGNoLCBzbw0KPiBJIGd1ZXNzIEkgbXVzdCBiZSBt
aXNzaW5nIHNvbWV0aGluZyAuLi4NCj4NCj4+IC0tLSBhL3hlbi9kcml2ZXJzL3ZwY2kvbXNpeC5j
DQo+PiArKysgYi94ZW4vZHJpdmVycy92cGNpL21zaXguYw0KPj4gQEAgLTEzOCw3ICsxMzgsNyBA
QCBzdGF0aWMgdm9pZCBjb250cm9sX3dyaXRlKGNvbnN0IHN0cnVjdCBwY2lfZGV2ICpwZGV2LCB1
bnNpZ25lZCBpbnQgcmVnLA0KPj4gICAgICAgICAgIHBjaV9jb25mX3dyaXRlMTYocGRldi0+c2Jk
ZiwgcmVnLCB2YWwpOw0KPj4gICB9DQo+PiAgIA0KPj4gLXN0YXRpYyBzdHJ1Y3QgdnBjaV9tc2l4
ICptc2l4X2ZpbmQoY29uc3Qgc3RydWN0IGRvbWFpbiAqZCwgdW5zaWduZWQgbG9uZyBhZGRyKQ0K
Pj4gK3N0YXRpYyBzdHJ1Y3QgdnBjaV9tc2l4ICptc2l4X2dldChjb25zdCBzdHJ1Y3QgZG9tYWlu
ICpkLCB1bnNpZ25lZCBsb25nIGFkZHIpDQo+PiAgIHsNCj4+ICAgICAgIHN0cnVjdCB2cGNpX21z
aXggKm1zaXg7DQo+PiAgIA0KPj4gQEAgLTE1MCwxNSArMTUwLDI5IEBAIHN0YXRpYyBzdHJ1Y3Qg
dnBjaV9tc2l4ICptc2l4X2ZpbmQoY29uc3Qgc3RydWN0IGRvbWFpbiAqZCwgdW5zaWduZWQgbG9u
ZyBhZGRyKQ0KPj4gICAgICAgICAgIGZvciAoIGkgPSAwOyBpIDwgQVJSQVlfU0laRShtc2l4LT50
YWJsZXMpOyBpKysgKQ0KPj4gICAgICAgICAgICAgICBpZiAoIGJhcnNbbXNpeC0+dGFibGVzW2ld
ICYgUENJX01TSVhfQklSTUFTS10uZW5hYmxlZCAmJg0KPj4gICAgICAgICAgICAgICAgICAgIFZN
U0lYX0FERFJfSU5fUkFOR0UoYWRkciwgbXNpeC0+cGRldi0+dnBjaSwgaSkgKQ0KPj4gKyAgICAg
ICAgICAgIHsNCj4+ICsgICAgICAgICAgICAgICAgc3Bpbl9sb2NrKCZtc2l4LT5wZGV2LT52cGNp
X2xvY2spOw0KPj4gICAgICAgICAgICAgICAgICAgcmV0dXJuIG1zaXg7DQo+PiArICAgICAgICAg
ICAgfQ0KPiBJIHRoaW5rIGRlbGliZXJhdGVseSByZXR1cm5pbmcgd2l0aCBhIGxvY2sgaGVsZCBy
ZXF1aXJlcyBhIHJlc3BlY3RpdmUNCj4gY29tbWVudCBhaGVhZCBvZiB0aGUgZnVuY3Rpb24uDQpP
aywgd2lsbCBhZGQgYSBjb21tZW50DQo+DQo+PiAgICAgICB9DQo+PiAgIA0KPj4gICAgICAgcmV0
dXJuIE5VTEw7DQo+PiAgIH0NCj4+ICAgDQo+PiArc3RhdGljIHZvaWQgbXNpeF9wdXQoc3RydWN0
IHZwY2lfbXNpeCAqbXNpeCkNCj4+ICt7DQo+PiArICAgIGlmICggIW1zaXggKQ0KPj4gKyAgICAg
ICAgcmV0dXJuOw0KPj4gKw0KPj4gKyAgICBzcGluX3VubG9jaygmbXNpeC0+cGRldi0+dnBjaV9s
b2NrKTsNCj4+ICt9DQo+IE1heWJlIHNob3J0ZXINCj4NCj4gICAgICBpZiAoIG1zaXggKQ0KPiAg
ICAgICAgICBzcGluX3VubG9jaygmbXNpeC0+cGRldi0+dnBjaV9sb2NrKTsNCkxvb2tzIGdvb2QN
Cj4NCj4gPyBZZXQgdGhlcmUncyBvbmx5IG9uZSBjYXNlIHdoZXJlIHlvdSBtYXkgcGFzcyBOVUxM
IGluIGhlcmUsIHNvDQo+IG1heWJlIGl0J3MgYmV0dGVyIGFueXdheSB0byBtb3ZlIHRoZSBjb25k
aXRpb25hbCAuLi4NCj4NCj4+ICAgc3RhdGljIGludCBtc2l4X2FjY2VwdChzdHJ1Y3QgdmNwdSAq
diwgdW5zaWduZWQgbG9uZyBhZGRyKQ0KPj4gICB7DQo+PiAtICAgIHJldHVybiAhIW1zaXhfZmlu
ZCh2LT5kb21haW4sIGFkZHIpOw0KPj4gKyAgICBzdHJ1Y3QgdnBjaV9tc2l4ICptc2l4ID0gbXNp
eF9nZXQodi0+ZG9tYWluLCBhZGRyKTsNCj4+ICsNCj4+ICsgICAgbXNpeF9wdXQobXNpeCk7DQo+
PiArICAgIHJldHVybiAhIW1zaXg7DQo+PiAgIH0NCj4gLi4uIGhlcmU/DQpZZXMsIEkgY2FuIGhh
dmUgdGhhdCBjaGVjayBoZXJlLCBidXQgd2hhdCBpZiB0aGVyZSBpcyB5ZXQNCmFub3RoZXIgY2Fs
bGVyIG9mIHRoZSBzYW1lPyBJIGFtIG5vdCBzdXJlIHdoZXRoZXIgaXQgaXMgYmV0dGVyDQp0byBo
YXZlIHRoZSBjaGVjayBpbiBtc2l4X2dldCBvciBhdCB0aGUgY2FsbGVyIHNpdGUuDQpBdCB0aGUg
bW9tZW50ICh3aXRoIGEgc2luZ2xlIHBsYWNlIHdpdGggTlVMTCBwb3NzaWJsZSkgSSBjYW4NCm1v
dmUgdGhlIGNoZWNrLiBAUm9nZXI/DQo+DQo+PiBAQCAtMTg2LDcgKzIwMCw3IEBAIHN0YXRpYyBp
bnQgbXNpeF9yZWFkKHN0cnVjdCB2Y3B1ICp2LCB1bnNpZ25lZCBsb25nIGFkZHIsIHVuc2lnbmVk
IGludCBsZW4sDQo+PiAgICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGxvbmcgKmRhdGEp
DQo+PiAgIHsNCj4+ICAgICAgIGNvbnN0IHN0cnVjdCBkb21haW4gKmQgPSB2LT5kb21haW47DQo+
PiAtICAgIHN0cnVjdCB2cGNpX21zaXggKm1zaXggPSBtc2l4X2ZpbmQoZCwgYWRkcik7DQo+PiAr
ICAgIHN0cnVjdCB2cGNpX21zaXggKm1zaXggPSBtc2l4X2dldChkLCBhZGRyKTsNCj4+ICAgICAg
IGNvbnN0IHN0cnVjdCB2cGNpX21zaXhfZW50cnkgKmVudHJ5Ow0KPj4gICAgICAgdW5zaWduZWQg
aW50IG9mZnNldDsNCj4+ICAgDQo+PiBAQCAtMTk2LDcgKzIxMCwxMCBAQCBzdGF0aWMgaW50IG1z
aXhfcmVhZChzdHJ1Y3QgdmNwdSAqdiwgdW5zaWduZWQgbG9uZyBhZGRyLCB1bnNpZ25lZCBpbnQg
bGVuLA0KPj4gICAgICAgICAgIHJldHVybiBYODZFTVVMX1JFVFJZOw0KPj4gICANCj4+ICAgICAg
IGlmICggIWFjY2Vzc19hbGxvd2VkKG1zaXgtPnBkZXYsIGFkZHIsIGxlbikgKQ0KPj4gKyAgICB7
DQo+PiArICAgICAgICBtc2l4X3B1dChtc2l4KTsNCj4+ICAgICAgICAgICByZXR1cm4gWDg2RU1V
TF9PS0FZOw0KPj4gKyAgICB9DQo+PiAgIA0KPj4gICAgICAgaWYgKCBWTVNJWF9BRERSX0lOX1JB
TkdFKGFkZHIsIG1zaXgtPnBkZXYtPnZwY2ksIFZQQ0lfTVNJWF9QQkEpICkNCj4+ICAgICAgIHsN
Cj4+IEBAIC0yMjIsMTAgKzIzOSwxMCBAQCBzdGF0aWMgaW50IG1zaXhfcmVhZChzdHJ1Y3QgdmNw
dSAqdiwgdW5zaWduZWQgbG9uZyBhZGRyLCB1bnNpZ25lZCBpbnQgbGVuLA0KPj4gICAgICAgICAg
ICAgICBicmVhazsNCj4+ICAgICAgICAgICB9DQo+PiAgIA0KPj4gKyAgICAgICAgbXNpeF9wdXQo
bXNpeCk7DQo+PiAgICAgICAgICAgcmV0dXJuIFg4NkVNVUxfT0tBWTsNCj4+ICAgICAgIH0NCj4+
ICAgDQo+PiAtICAgIHNwaW5fbG9jaygmbXNpeC0+cGRldi0+dnBjaS0+bG9jayk7DQo+PiAgICAg
ICBlbnRyeSA9IGdldF9lbnRyeShtc2l4LCBhZGRyKTsNCj4+ICAgICAgIG9mZnNldCA9IGFkZHIg
JiAoUENJX01TSVhfRU5UUllfU0laRSAtIDEpOw0KPiBZb3UncmUgaW5jcmVhc2luZyB0aGUgbG9j
a2VkIHJlZ2lvbiBxdWl0ZSBhIGJpdCBoZXJlLiBJZiB0aGlzIGlzIHJlYWxseQ0KPiBuZWVkZWQs
IGl0IHdhbnRzIGV4cGxhaW5pbmcuIEFuZCBpZiB0aGlzIGlzIGRlZW1lZCBhY2NlcHRhYmxlIGFz
IGENCj4gInNpZGUgZWZmZWN0IiwgaXQgd2FudHMganVzdGlmeWluZyBvciBhdCBsZWFzdCBzdGF0
aW5nIGltby4gU2FtZSBmb3INCj4gbXNpeF93cml0ZSgpIHRoZW4sIG9idmlvdXNseS4NClllcywg
SSBkbyBpbmNyZWFzZSB0aGUgbG9ja2luZyByZWdpb24gaGVyZSwgYnV0IHRoZSBtc2l4IHZhcmlh
YmxlIG5lZWRzDQp0byBiZSBwcm90ZWN0ZWQgYWxsIHRoZSB0aW1lLCBzbyBpdCBzZWVtcyB0byBi
ZSBvYnZpb3VzIHRoYXQgaXQgcmVtYWlucw0KdW5kZXIgdGhlIGxvY2sNCj4gICAoSSdtIG5vdCBz
dXJlIFJvZ2VyIGFjdHVhbGx5IGltcGxpZWQgdGhpcw0KPiB3aGVuIHN1Z2dlc3RpbmcgdG8gc3dp
dGNoIHRvIHRoZSBnZXQvcHV0IHBhaXIuKQ0KPg0KPj4gQEAgLTMyNyw3ICszMzQsMTIgQEAgdWlu
dDMyX3QgdnBjaV9yZWFkKHBjaV9zYmRmX3Qgc2JkZiwgdW5zaWduZWQgaW50IHJlZywgdW5zaWdu
ZWQgaW50IHNpemUpDQo+PiAgICAgICBpZiAoICFwZGV2ICkNCj4+ICAgICAgICAgICByZXR1cm4g
dnBjaV9yZWFkX2h3KHNiZGYsIHJlZywgc2l6ZSk7DQo+PiAgIA0KPj4gLSAgICBzcGluX2xvY2so
JnBkZXYtPnZwY2ktPmxvY2spOw0KPj4gKyAgICBzcGluX2xvY2soJnBkZXYtPnZwY2lfbG9jayk7
DQo+PiArICAgIGlmICggIXBkZXYtPnZwY2kgKQ0KPj4gKyAgICB7DQo+PiArICAgICAgICBzcGlu
X3VubG9jaygmcGRldi0+dnBjaV9sb2NrKTsNCj4+ICsgICAgICAgIHJldHVybiB2cGNpX3JlYWRf
aHcoc2JkZiwgcmVnLCBzaXplKTsNCj4+ICsgICAgfQ0KPiBEaWRuJ3QgeW91IHNheSB5b3Ugd291
bGQgYWRkIGp1c3RpZmljYXRpb24gb2YgdGhpcyBwYXJ0IG9mIHRoZSBjaGFuZ2UNCj4gKGFuZCBp
dHMgdnBjaV93cml0ZSgpIGNvdW50ZXJwYXJ0KSB0byB0aGUgZGVzY3JpcHRpb24/DQpBZ2Fpbiwg
SSBhbSByZWZlcnJpbmcgdG8gdGhlIGNvbW1pdCBtZXNzYWdlIGFzIGRlc2NyaWJlZCBhYm92ZQ0K
Pg0KPiBKYW4NCj4NClRoYW5rIHlvdSwNCk9sZWtzYW5kcg==


From xen-devel-bounces@lists.xenproject.org Fri Feb 04 09:01:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 09:01:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265195.458503 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFuTM-0001j7-Kp; Fri, 04 Feb 2022 09:01:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265195.458503; Fri, 04 Feb 2022 09:01:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFuTM-0001j0-HK; Fri, 04 Feb 2022 09:01:40 +0000
Received: by outflank-mailman (input) for mailman id 265195;
 Fri, 04 Feb 2022 09:01:39 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=u+82=ST=epam.com=prvs=4034f0a382=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nFuTL-0001iS-93
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 09:01:39 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0e151329-8599-11ec-8f75-fffcc8bd4f1a;
 Fri, 04 Feb 2022 10:01:38 +0100 (CET)
Received: from pps.filterd (m0174676.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 2146HfsH021954;
 Fri, 4 Feb 2022 09:01:25 GMT
Received: from eur04-db3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2052.outbound.protection.outlook.com [104.47.12.52])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e0uysgsuu-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 04 Feb 2022 09:01:24 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM4PR0302MB2786.eurprd03.prod.outlook.com (2603:10a6:200:92::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.14; Fri, 4 Feb
 2022 09:01:21 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6%3]) with mapi id 15.20.4951.014; Fri, 4 Feb 2022
 09:01:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0e151329-8599-11ec-8f75-fffcc8bd4f1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Kb7OEP4zqa6Al//HcpZktsbEtuyumfiDSY5hFU4iKS1F/QaNdTZcanKgpis6OLDVV8iIQOUqiREXd5J/BNBD/xhKkY83FiCabJImGgueE2iQjXg+FHgg44tZG91r71GymBZ0UMTTpxPqF+dlzHcyAyyTCN/UZrsSdoxgdE0bYg6X4O84JeczWIkGVRU0XqUAKddZlOLvI9FoYFd4v9dheS3W+kZdOhsTjt5oy+l8Dbq/OcLazxH3+/8GA4IaGn4olMF/nT4eFrDM3pSmjsCwnB2i3JuYTi4qIfw6ThXgIf9mh69Oi9GAF/Hpopdo2bOWNXvflvJDRY7xtXkIlyd4Qw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=kmkvB2Aufh6gUnuAZXvZdNGoZPqlCuNTXTrXiAAu9HY=;
 b=cXCBUvKCTTGpaLT+KTW/WCIIYTIsGJ9d1lkQkEAJvNRCdCAiR7X54+9iyB1biyq5NOQ2eGXGKfxVBL0Yp4Pm9ZGNIDqtfGGxOI/5m3YSzZ+5/Ld0hFdKkd8PJYKX6oA7NAcNvh1z71l55vi39wkmKW7XFvwkxFjdqGE07QnWdD0vzg7eXOuXQOwlWm2aa0pzzx4JLdp1WRPCxfLQulNQp4Lgbbs6lNK0otQdONXkLn1UGlVSU6Un+mhp9g+qWbhekr9dgBTEGRfUbBILyYUPugod/XClk+sBl1N0HEJ0EiTdfK9Ba8AvjhDoA8HAXAxAdYFc7GS4CzLUDf1Y2Dp3FA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=kmkvB2Aufh6gUnuAZXvZdNGoZPqlCuNTXTrXiAAu9HY=;
 b=PlSwGfKJOb4uEo4yAZ9ugAQxlD5qIR3FEPGVlN5rP8T1mp3kBOQlSf4X7S2GenXfL/NgHezo5SrufShOV4JXI7gobsLJEJVyq+rWi1s5JD10ZLHEsyZnsxybVcgyUznNB9M7jr2SKqZuvc5Pr+zL/fafeg2gKUhCEB4YnAQmvbMmK5/Xfl3KfPCkwFNqKcgfrLkoUElopRVs7a5H2wN6ertYzcqzzVicPhS7KHT+srpjSR1ytqOpEyfdr1VhtdvI3LzIBLhIe6Qfz6CT1YhtckZRSNQ9u1OUZcgXOGKRhuQu+FHyN0eUngHOzHtlFKq0dci1owXgGhE/8+g099aPRQ==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Julien Grall <julien@xen.org>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: "sstabellini@kernel.org" <sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "roger.pau@citrix.com" <roger.pau@citrix.com>,
        "jbeulich@suse.com"
	<jbeulich@suse.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v6 01/13] xen/pci: arm: add stub for is_memory_hole
Thread-Topic: [PATCH v6 01/13] xen/pci: arm: add stub for is_memory_hole
Thread-Index: AQHYGZFbEg6Erttt1UCNei+XrySHEqyDFYiAgAAC4gA=
Date: Fri, 4 Feb 2022 09:01:21 +0000
Message-ID: <19e50632-5865-9a75-756b-88db85007e96@epam.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-2-andr2000@gmail.com>
 <000ac24e-fdac-855d-7fb4-2165a1192ea4@xen.org>
In-Reply-To: <000ac24e-fdac-855d-7fb4-2165a1192ea4@xen.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 23b864cf-3ece-4b39-9cc3-08d9e7bce9d3
x-ms-traffictypediagnostic: AM4PR0302MB2786:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM4PR0302MB27869B1C63CE39BAEC4F36B2E7299@AM4PR0302MB2786.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 uCHJTAKYL6i6s8/6HQfYt134s9ykM8S7CvBihOkQHUCTSrGzemIyNj2pYGfRGFSxGn8jyGOq4D+MJd+fOO91+N4kLNEIFG7VR4q+x9QhTY2jluRKONtMzREfG6R30ujQ7YfFSq7cZbLzTsbtjFZGa16O3bih9T1363urkvqsaJ+vCMpNz+A3EdeFIfIWNGhispSXyaYN3ydcjvp8tEAMz5/dJQXMXJfvKW1Ps0hoQxR3DUtImJlVKQre/5AxyfYAUrHq2mgFb6LMf9qAbVYszMilP1f+gFGBWfqIS8NqVLN2lzwIQVgrWpp15nfuXK+S/Gv0W32Olnv+Jm8jIZhoh2KgTIg+u+vBoOfTR3X4AhY5Vj6rurGmtJwYYGluVdaRSr91hqQb5aI0WAv1NU1dExkC8RH+h4II7Ztwuw9MlbJaQeYYdSdXnwE5B9/F9GEhHWbmkaiyq1GE0XAH6Ljw0PxV0dDTI/UPCkBmkQsv+XrAcAU2e8GGgk+1uAKrvS7wlR4HhwSkuuK3SSLDOB3bljyUENplri0zdYabhobfdreAUgeuNTANKanKPO8AYqiHdOTiASEPdoGeSKRuyZnJZkWTTRBHX8i5nw5I4uigZ9JcrBCgASGMdlceMEm7bq2AkdCb7jdsIrEHrDq2KPLamDShHG0TvWYtvqGL3HDxpbYWdvYp6bxrwDKgvBQcKK4Tr6zIFz8osKpeW1YG2+l7icH58tGbPfvUqHfUSk4NWszjb+SE9I3e4Qbql46PWRob
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(316002)(53546011)(6512007)(71200400001)(6506007)(7416002)(64756008)(38070700005)(2906002)(26005)(31686004)(36756003)(6486002)(508600001)(107886003)(2616005)(8676002)(110136005)(186003)(83380400001)(86362001)(66476007)(54906003)(122000001)(8936002)(76116006)(66446008)(66946007)(38100700002)(5660300002)(4326008)(66556008)(91956017)(31696002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?WE9tNGxySDFTa3d3TzRSTGtDdS9mTWlJSzBqK0tSenc1ZTRiSkEwVTJXOHpV?=
 =?utf-8?B?N1FQSVpwTTBwdGJ0WDJQbURPYURvdnRFR25TV1dFOXp3MFdDUVJXNkJyb1hM?=
 =?utf-8?B?VnhnY2ZMaHcxMUJ4QkdQdnkwbVZJMkxEWSs3bDBvckg0Rmx6VnMvTW9yNFBW?=
 =?utf-8?B?Y1ZzMFV2aXZHbXduSjZnTVlFZGpYOHo2VTc3bWp3czk3eGV1dzFFK2s2bGVp?=
 =?utf-8?B?cFlCa2xlSHZnZFBzUjFCTEExM3dvcmhGaDRvWkJSbENXVnVHSytaU0tySWNi?=
 =?utf-8?B?QzhQSGVXZFdmakhXOFJiV0tBUkJmcm9LUG04bG1Da0U1TnRvSGlNZmdNeDVL?=
 =?utf-8?B?Z1FEM2VJNW1aVDlvSDUwdGtmQllYb1JPN2tVK3RWN3ltMTJvckxCNmprOTBx?=
 =?utf-8?B?WGs2WHJEdkJSU0xIbnY5QVJnTEl3bTFxb0JZeUFoYVVlbWpRbUROZ2lSMHJ1?=
 =?utf-8?B?bHljbnVnNmtTcDJUczBFazZTcGRCS3VycElpaERRenhOTllHS2RzbFZBRDY2?=
 =?utf-8?B?TWgvaGpEdFhRZ1pDd1hqeXVyOFA0MkNERXRnWjBWQmx2MkhuNHZZdHR2RkZz?=
 =?utf-8?B?QUtTTVA0MlZLL1R0SnpmRFZ3dHVFbVhQQ2d0OUtxeGk1QS9JV1FhNmoyOFU5?=
 =?utf-8?B?Z1FvZDU3VENBOVl5U1AxMGFlYjdXaG4wK1gxaUVhQ2FycGZ3b1dJOGNVbEJx?=
 =?utf-8?B?T0VGUHFuOS9wZU5DWjRWRUFDWjVZVWpOSWxjRmtuUHVQRXo5Z2hrVlRBbXhH?=
 =?utf-8?B?NTdQU1BKdWpaMnB4WCtzS3A2TG9kdU1NM1Z2U2JaOWVGTFMydllGRGEvSVlm?=
 =?utf-8?B?MXFvMFpmSXkzd3ZlRkUyOUZpeXRrQk9XWFpQbVZnL1o5eDJ3UEdoQ0FmN3h3?=
 =?utf-8?B?a0hTOTMxV2Job0RGMGxIVi9DSWZ4elhQL29GWU05cjVJK0Q4VUx3T253WTZS?=
 =?utf-8?B?bzYzQTVibUM2NUpwVklET3FrRDlISU9oVW0wNEN3S3ZSY05mcDhqUHoxbFd0?=
 =?utf-8?B?aU80ejJDMkxPUnM5WklaVmgydk5kdFlCUHRDUHZ0ZE9haElGMEJHRDA4SmdF?=
 =?utf-8?B?MzcxaDhkRGNjSUlxUHJQVy8zWWtDem1Wa0I2SzAvODNlQmYzSWNScFpVZ25Z?=
 =?utf-8?B?M3JuL1hQcE91SkhOeTBHdWtlSHdpT3g2UVhFVTAzeXJZNjcxZkNRa0dqbFhv?=
 =?utf-8?B?MmtsQlYwKytUU1RCZ24ySUxuM2JhUW1hLytOY3FQSkVGQ2ZlYmM1MWtEMVJz?=
 =?utf-8?B?K01qS2JVd0J2UHhpakcxYlhCWVJRdU10YVNYVk5NaW1VMEVJTUpKNVFWT2hu?=
 =?utf-8?B?a2RlRGlwVVF2VkZjN00zazZYYlJ6c3dLY3RzRmtySldpaFBDSkI2MHBUcVZ5?=
 =?utf-8?B?REV6dUQwWDhrYm1OdDRqRkErTzRQUlZGZzcvZUZULzEyUHpoZXFkV2tXdDFa?=
 =?utf-8?B?Q1lsVUt6clJ2d0wrOU9nMGlKNWdpSUdpTjJuMTFvWGNFRVlmak9xbUdvSXAz?=
 =?utf-8?B?MkpWcVZuWjdmYU9McGl2Tzc3VUtLZ25RclQxeEhMTzkvVkE0Sm5Sd3hPVW9Z?=
 =?utf-8?B?bEsvVXhpY0FBMlRQWWR3bkFxbklQOURZYUJhY0ZGUy9XYnJQL1BPbWQzcGc1?=
 =?utf-8?B?Ylhuekg0d1p2RVlWNkpsNkVoZGUxN09SRWFDMnRBL3Y3N2x0QngyaHcxMCs1?=
 =?utf-8?B?dGxNck1mZDVjcWdLK09sbTllZEZYYlFPcXVvU0hDM2xVWTRGdTVQeWFwL1FH?=
 =?utf-8?B?U0NlcWJkcWVFUnNxdEdON01zVE9ySFJ6bEhsbHpDa0IzMHBwcFRvRmw1TER3?=
 =?utf-8?B?LzZxN3plb00vL1FXdmdRVit4RkxJc1k2cHUweHd2ekVPdk9XejAySHFPdEhl?=
 =?utf-8?B?enlURzArTVkrWmpEL0pJcWZHZ1Fqanoyc3YxeHZRVVFBVjlXemQwZXR3VXdX?=
 =?utf-8?B?SUp5bURXa3REOVpjcmdkNyt6RzMvQmJrM1prY2NhWEFHNjVkWm9jckcxY2h5?=
 =?utf-8?B?aDZCQm5vdUwzWW95SkpXS25Md0lzQVJ3d0VSR3VxMVBuclNaMGw5ZmNPT21V?=
 =?utf-8?B?SStJR1BGZ2Q1UVJZaEpBNFpVQWcvZkpBWVVIdFVRbFlDQUNETktNNmNDNWNm?=
 =?utf-8?B?cmNIWmtJQmxScCs1STN1TkR5SWlTd08vdmJ3c2FzdlcyQjY0ZHpGeU04UWFR?=
 =?utf-8?B?Zk1sUWFzN0dmMldaOXVmaXNIUW9iSTN4YzVkeVJ3TE0xWWdKUUh4bkVKRXVZ?=
 =?utf-8?B?UDN6WG5QeU1GZUxHYm5acmJuOUpVSnVlU05idnFMTS8vQnVLeDB2Mk81KzF2?=
 =?utf-8?B?ZFhzTmxJNU0zbCtkMHFFcjFMbWl5bUNldGRaR2xOdHl6UWFDbXFmZz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <3AD5D54CEC78BB4C95612CFE27490594@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 23b864cf-3ece-4b39-9cc3-08d9e7bce9d3
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Feb 2022 09:01:21.1369
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: THEtpFfRnnp2NV5nixoH5B/jD2KnKqBe5+w5o519nCTpYcv437kuuLQaOdQS7XTxNzLmU/VzBx5k8JjNRSfeOZ/aHZk9Js1DZraeeJJvw08J4jktUy2r84WxjLlLa3Hl
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0302MB2786
X-Proofpoint-GUID: NYVlNNvTQXIcCk-4DRr7Klud4GI6tfql
X-Proofpoint-ORIG-GUID: NYVlNNvTQXIcCk-4DRr7Klud4GI6tfql
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-04_03,2022-02-03_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 adultscore=0
 lowpriorityscore=0 spamscore=0 suspectscore=0 bulkscore=0 mlxscore=0
 malwarescore=0 impostorscore=0 clxscore=1015 priorityscore=1501
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202040047

SGksIEp1bGllbiENCg0KT24gMDQuMDIuMjIgMTA6NTEsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4g
SGksDQo+DQo+IE9uIDA0LzAyLzIwMjIgMDY6MzQsIE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIHdy
b3RlOg0KPj4gRnJvbTogT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gPG9sZWtzYW5kcl9hbmRydXNo
Y2hlbmtvQGVwYW0uY29tPg0KPj4NCj4+IEFkZCBhIHN0dWIgZm9yIGlzX21lbW9yeV9ob2xlIHdo
aWNoIGlzIHJlcXVpcmVkIGZvciBQQ0kgcGFzc3Rocm91Z2gNCj4+IG9uIEFybS4NCj4+DQo+PiBT
aWduZWQtb2ZmLWJ5OiBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyA8b2xla3NhbmRyX2FuZHJ1c2hj
aGVua29AZXBhbS5jb20+DQo+Pg0KPj4gLS0tDQo+PiBDYzogSnVsaWVuIEdyYWxsIDxqdWxpZW5A
eGVuLm9yZz4NCj4+IENjOiBTdGVmYW5vIFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5v
cmc+DQo+PiAtLS0NCj4+IE5ldyBpbiB2Ng0KPj4gLS0tDQo+PiDCoCB4ZW4vYXJjaC9hcm0vbW0u
YyB8IDYgKysrKysrDQo+PiDCoCAxIGZpbGUgY2hhbmdlZCwgNiBpbnNlcnRpb25zKCspDQo+Pg0K
Pj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9tbS5jIGIveGVuL2FyY2gvYXJtL21tLmMNCj4+
IGluZGV4IGIxZWFlNzY3YzI3Yy4uYzMyZTM0YTE4MmEyIDEwMDY0NA0KPj4gLS0tIGEveGVuL2Fy
Y2gvYXJtL21tLmMNCj4+ICsrKyBiL3hlbi9hcmNoL2FybS9tbS5jDQo+PiBAQCAtMTY0MCw2ICsx
NjQwLDEyIEBAIHVuc2lnbmVkIGxvbmcgZ2V0X3VwcGVyX21mbl9ib3VuZCh2b2lkKQ0KPj4gwqDC
oMKgwqDCoCByZXR1cm4gbWF4X3BhZ2UgLSAxOw0KPj4gwqAgfQ0KPj4gwqAgK2Jvb2wgaXNfbWVt
b3J5X2hvbGUobWZuX3Qgc3RhcnQsIG1mbl90IGVuZCkNCj4+ICt7DQo+PiArwqDCoMKgIC8qIFRP
RE86IHRoaXMgbmVlZHMgdG8gYmUgcHJvcGVybHkgaW1wbGVtZW50ZWQuICovDQo+DQo+IEkgd2Fz
IGhvcGluZyB0byBzZWUgYSBzdW1tYXJ5IG9mIHRoZSBkaXNjdXNzaW9uIGZyb20gSVJDIHNvbWV3
aGVyZSBpbiB0aGUgcGF0Y2ggKG1heWJlIGFmdGVyIC0tLSkuIFRoaXMgd291bGQgaGVscCB0byBi
cmluZyB1cCB0byBzcGVlZCB0aGUgb3RoZXJzIHRoYXQgd2VyZSBub3Qgb24gSVJDLg0KSSBhbSBu
b3QgcXVpdGUgc3VyZSB3aGF0IG5lZWRzIHRvIGJlIHB1dCBoZXJlIGFzIHRoZSBzdW1tYXJ5DQpD
b3VsZCB5b3UgcGxlYXNlIGhlbHAgbWUgd2l0aCB0aGUgZXhhY3QgbWVzc2FnZSB5b3Ugd291bGQg
bGlrZSB0byBzZWU/DQo+DQo+PiArwqDCoMKgIHJldHVybiB0cnVlOw0KPj4gK30NCj4+ICsNCj4+
IMKgIC8qDQo+PiDCoMKgICogTG9jYWwgdmFyaWFibGVzOg0KPj4gwqDCoCAqIG1vZGU6IEMNCj4N
ClRoYW5rIHlvdSwNCk9sZWtzYW5kcg==


From xen-devel-bounces@lists.xenproject.org Fri Feb 04 09:04:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 09:04:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265203.458514 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFuVk-0002OC-2s; Fri, 04 Feb 2022 09:04:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265203.458514; Fri, 04 Feb 2022 09:04:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFuVj-0002O5-W3; Fri, 04 Feb 2022 09:04:07 +0000
Received: by outflank-mailman (input) for mailman id 265203;
 Fri, 04 Feb 2022 09:04:06 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nFuVh-0002Nv-VG; Fri, 04 Feb 2022 09:04:05 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nFuVh-0005Fl-QK; Fri, 04 Feb 2022 09:04:05 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nFuVh-0002qg-7C; Fri, 04 Feb 2022 09:04:05 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nFuVh-0003Ir-6m; Fri, 04 Feb 2022 09:04:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=sC0lPWHmQjZNAdZzwvXhpiKhnRY/xaWV0FF9ASqdXF8=; b=wUEzMPREsLqWajJ+D5I/CW/b4q
	j3Y3wsc/Nn9UK6PExg7KZi+oKzjuNoF+3rvkxkJnVPxDyvtFzLsb4sOwuQdQrtza2Uy6fSTrM//eK
	ATneE594EI4OtB6+KbptA9TtJ/uIpQc8X5Yu5Din3HOQhzVJnXfZ6Gayd7xHcC36CPJA=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168000-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 168000: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=8f3e5ce773c62bb5c4a847f3a9a5c98bbb3b359f
X-Osstest-Versions-That:
    qemuu=f7c0e223acd5021d03736644cc0abf3501003820
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 04 Feb 2022 09:04:05 +0000

flight 168000 qemu-mainline real [real]
flight 168007 qemu-mainline real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/168000/
http://logs.test-lab.xenproject.org/osstest/logs/168007/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 168007-retest

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167991
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167991
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167991
 test-armhf-armhf-xl-rtds     18 guest-start/debian.repeat    fail  like 167991
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167991
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167991
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167991
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167991
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167991
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                8f3e5ce773c62bb5c4a847f3a9a5c98bbb3b359f
baseline version:
 qemuu                f7c0e223acd5021d03736644cc0abf3501003820

Last test of basis   167991  2022-02-02 23:39:43 Z    1 days
Testing same since   168000  2022-02-03 16:08:17 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Helge Deller <deller@gmx.de>
  Peter Maydell <peter.maydell@linaro.org>
  Sven Schnelle <svens@stackframe.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   f7c0e223ac..8f3e5ce773  8f3e5ce773c62bb5c4a847f3a9a5c98bbb3b359f -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Fri Feb 04 09:15:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 09:15:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265217.458525 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFuh2-0003wG-At; Fri, 04 Feb 2022 09:15:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265217.458525; Fri, 04 Feb 2022 09:15:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFuh2-0003w9-72; Fri, 04 Feb 2022 09:15:48 +0000
Received: by outflank-mailman (input) for mailman id 265217;
 Fri, 04 Feb 2022 09:15:46 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1gJ0=ST=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nFuh0-0003w3-OJ
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 09:15:46 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 08a38f41-859b-11ec-8eb8-a37418f5ba1a;
 Fri, 04 Feb 2022 10:15:45 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2170.outbound.protection.outlook.com [104.47.17.170]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-38-u441yXTFM6KenmgCxzw2tw-1; Fri, 04 Feb 2022 10:15:44 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM6PR04MB6247.eurprd04.prod.outlook.com (2603:10a6:20b:be::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.14; Fri, 4 Feb
 2022 09:15:41 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.014; Fri, 4 Feb 2022
 09:15:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 08a38f41-859b-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1643966145;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=7u6ixG3pydigi95yu3HXcWX5ujp0fAcJhFelHm9tapQ=;
	b=bqQAFG4YJ9ebUg++IDL97bTm1wHnsgNoO3QlbSQPamr0sBL+xvPVrU0wMft11aSXYBSPkh
	SIo8f4ZW4msgMXJrFiSXEMQShVD8TyXdIdPvdexodA9TlFvizDEroCQaCxCtG3Wn1516Y+
	oeCqW2+a3ju4m+aEsT+y7OHa1K/7FfQ=
X-MC-Unique: u441yXTFM6KenmgCxzw2tw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Cf639v5I4JWlT+rZEmK11ycFKaQVsJf4m4s04UIgPyUHEQ9rOpArsfxhI0PKG2nvxNL5fNuDjA9KkUkqUKmfDIyi9mGp1UR+Iq3dVCLI4fmUQ5JjRZR6kEh8ZVysjVoh/Ka9LgwbYPdt+ou3gtUgXw1KbgjwODRh0p5qV58Jh4KpEoA/f1DUjuvKaYlmuTDs5fnq1YG/GOE2mbxhnGIya75bNeR8F5pMkYjGj0jQboGy65eUJS2UFwEg90yDnr1F4uIAlODuoYB8H+XdDjOta+4NekeAc35PI8FTCK6n41HZWfFrVGBqXJN1G5rKE+IDsZj9ivmrTO/Kgrwwn97KcA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=7u6ixG3pydigi95yu3HXcWX5ujp0fAcJhFelHm9tapQ=;
 b=fmkxEYMAywPP+s7uVRt9ykHcONPqTTTMASRVFO++2I5XoItRsaUgDJ4GQF0Hovo3fTvL5iPdDLhJ40NcMityZ2vkMl4exhelt7GddyvGPMvC9wJRoWBcjB2K5fuvfKEg0IkklFOOThZu1BxvYBINLVR2UAeUonUSpOWaC/kYF4QR2KafmIQKC+QZWerUw2wSy8WSad3eJ48lRvGK8q3QU7CyxCuHjBVpJZfu9BjPxop+15dh/MGLycdaBrEWONELkYaZo8pY7V9GmeFJuTZWhqZzHErnhGQN+CPm3NXibzBToTEbjl7p9j43EXxGg5YuW7KeiR1+MCDwzmZ8T6P5Vw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <04726915-f39f-9019-436e-4399533c9fc3@suse.com>
Date: Fri, 4 Feb 2022 10:15:38 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Content-Language: en-US
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Cc: "julien@xen.org" <julien@xen.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Artem Mygaiev <Artem_Mygaiev@epam.com>,
 "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
 "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
 "paul@xen.org" <paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "roger.pau@citrix.com" <roger.pau@citrix.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-4-andr2000@gmail.com>
 <7209889d-8f17-61cc-72a4-97f6dbc1d54d@suse.com>
 <2cf022f8-b000-11b7-c6b9-90a56bc6e2ea@epam.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <2cf022f8-b000-11b7-c6b9-90a56bc6e2ea@epam.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8P251CA0021.EURP251.PROD.OUTLOOK.COM
 (2603:10a6:20b:2f2::18) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: aa4a7f26-ddca-45d0-d9a8-08d9e7beea56
X-MS-TrafficTypeDiagnostic: AM6PR04MB6247:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB6247B560E798517F217EADE4B3299@AM6PR04MB6247.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	yjWVq2JHoRRAl70YQGcaR1FHZutedYXlro0h8Vo1DoQ+RICVz9UAlTyZN1IPUfCG2JVEoU8O0k4qvIF4lN4HIDus7So1zQEjZ60PukDCRgv+xGvO7XkUN19xcXmggXn8s7XDbeCzL4jcB+BOdM+06+KgAMsGcpWwwOl/gStuGZVgNAiKfDRB0M19i+bCQagY5HRP3+k3W0DUSNjU6oDMqNOOxHRBkis0HnmkBiSxXQNe0/5I1unOkfhDPHpaN98XkjuMRUMJZErsAScXajZbgTvmWPDLtibHDdv0athkwRlMCw3BmVJyCfig46V0lFn2sYRAuZsHgJodhsaUO+opTiPm4DxiNt07dheU4f5KUnUNX1QcUOqdS+fonkLLXjCOYdgeUPu4wvZ0nUx85xaPWSQBzrXA08grVZyGs86gQrl5hvxOPHUdtCA5zHxhk4Yp2rbpvHBkLKu5cUGfLyNmjB6ZKkoysKycGbMoFQaiFVl1O0ZesIDI6aJYga5BQZgV8V12KwKtxTgAXhOaoq6SHfeYXUtNx7FojU9KliNzJ05isM/BChF9NKZFwS9rRvaHxKI8OW4XqO6YwFy8y/w995PjcXjcQvjhQgvwxTdIVBy4YoaFPwrTiQBWXboJhqcGlwbkQdEiscXAvkTpi8I6KAYnVy37F1M94SnXm//J1xWrh4jQ+aiF1vH7q9VEAPWWFE0FZS/07A4lBK8+V9i2GLnU2Jc0RDzQZstIi0hYBts=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6666004)(8936002)(8676002)(31696002)(66476007)(66556008)(66946007)(6506007)(6512007)(4326008)(31686004)(83380400001)(6486002)(5660300002)(53546011)(36756003)(2616005)(316002)(86362001)(508600001)(2906002)(38100700002)(186003)(54906003)(26005)(7416002)(6916009)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RHkzcXFEMjM4cGdpVjJvVU9HZUhjbjFJN3llREwwMkpqVFFRUGlqcjFSK3Nk?=
 =?utf-8?B?SXYvZlRBNmhTVE8yYXRkSHRLZTA2TWN1azNlR0VDUnhsRmc1SUp6SFIxSGF2?=
 =?utf-8?B?U0pzcUIvRTlZR1J5OGl6M0FLMGNDalpJckdxRjlDbEhzWVR5clh2MHlXK3d0?=
 =?utf-8?B?Z3Y3THMvTEVuUHVwdURyTDRSc3lMWm9nWmRZdG9SU2p4TE40c091bmFUbU9o?=
 =?utf-8?B?d1dzbkZ5YXRmbm12VC9sK256a25EVldHek1VTGx0Sks5eVBRYkZvblYzVFdm?=
 =?utf-8?B?K0NaUnI0SERBMUlyc2tBR1pNZUZOUGFNT1JsN1ZEWWE0dXVDN1NCZWpaaUhI?=
 =?utf-8?B?SmxSMUc4azRBVEhkYTJrY1Q2dmVXK3p5emFEVDZVQjFPKzc3TE1EQzh2RWx4?=
 =?utf-8?B?Si92dEpjTzh6TklZMUFVNmpTL1pRZDU4QUlkdnNPSmZacUVsNUFZRXc5RXR2?=
 =?utf-8?B?ZEdsNktNS05hOVRBSXJvV0F0R0FsV3hOMEpDZWxsLzNwVHlpSG12cENGcTdL?=
 =?utf-8?B?MDh5SzB4bVJqQWVwUGlocGplM3U0Y3BTNFpuRXJveitUVTJxL2pDczY1NWFy?=
 =?utf-8?B?Z1k1WUEwai9pN1czbzZlWEFQRzEwQTNPQWxYZ3RNcEQ0SHprV09jbCs0UXJw?=
 =?utf-8?B?S3Z2OWtYT1lyR0JnVFdvRUFJeEFGTDVOVmxsTTEyZU5BQjA1VnlHMjBLemxQ?=
 =?utf-8?B?Uk1JSWVaK3RScGxJR3hZNWVNeFhYZmFkN2lOWWliVXRLRmpOQnQrbzJTQ21Q?=
 =?utf-8?B?VllWbmVnaTdCTTc3ZHlWSitPM3NxOW1sbHFuQmJzaDhGVjNzb2VWeTMrVTVi?=
 =?utf-8?B?cWl4UGd5UWM1dWt1VlQxNDFIb291R3h3NUVnVGVlYVJrSkQ0dmtsbFpwMGZX?=
 =?utf-8?B?aUJIWFByTXlpSndnOVd4aHVwMlQrVGlJQ0NycnBuZTJkVGYvWjY4ZmJZUHVp?=
 =?utf-8?B?dzdVb295dGZlN21vcjQ0UXM5TFpRTU81cHo5aTNlR0k5b3NmbXZxejlWSE01?=
 =?utf-8?B?eVVOM2JOdzJrdHE0OUZvYzR4YkJOeXlJVWVYUGVvejBvNkFwSDJ2cTVXVk8x?=
 =?utf-8?B?cE9pUVA4NlBNdjhOSXhrYW0wbm4vT3BYNWZSUlRuY2M5Z0RXcUJZOG0wSHZn?=
 =?utf-8?B?dmZlNWhpbG9YTmhDMDVHY0JOMjFDOTZFQ2VVdm5JbmNwRkZ6ZUZyYW9WSnQ2?=
 =?utf-8?B?NlVFdURSRS81SXpyS0FxblcvUlYyM2x4YXA3OWJwb25MWjhiZ0wrVVlUTkhK?=
 =?utf-8?B?Unk5MnYzTmpMTnEyWWlJc2FRSThvYzNKaXNCNG1YY2NGTDgxK0w1b1REeW9U?=
 =?utf-8?B?UHNxeWV3VnVieHVKZ2pDQjdZSTFLdE93NzRrQm15Rmk0V2lkUDZpQWhFdm5r?=
 =?utf-8?B?amhscFg5cTFQRlAxRVk1aTZyZ1ZMaU9LWE0zUUJ6RkM4T2U5L2FTQ2NQeTh2?=
 =?utf-8?B?cXVlNnhBUXg1RWl1VG41UmhkZVhBZE5tQ2lpMTZtTjZ5MTIvR3lQRFJGZ0kz?=
 =?utf-8?B?ZGQrbXN4b2ZOaHpXVjR3UXhibEw1RkMwMnNGaDRPTi9pb1k3QmlheWFoYmtP?=
 =?utf-8?B?WjlORkQvdGNXME5GSEFVN3pGOStmck8rNklwcFFPMWYrT01Zc3lyK0IzRXhM?=
 =?utf-8?B?dCtTODl2RHViWWh5ZTdGWlRtUkdWYnNvaUVNck1SUzhrSE8vNkFBRTcybDQ1?=
 =?utf-8?B?MUVEOTU4c2FlOTUrZUVPZ3RSeEo4UWMxVW1Hb2lsQUxrMWNzYWhvVnplRGN1?=
 =?utf-8?B?dG1CK0gyandWbXFRb29CZi9EMXRveDVYaVlPVzNydXhPVDN6dUJhd2VENmJi?=
 =?utf-8?B?Rzk4dnBmL0RUQ1E0N1RHNkVkNWsxVitBUVF4OW9iVEp1TlJScTRQNXBaSjhu?=
 =?utf-8?B?S0dqTHJIVkNyWFlMaVk0YU04eW5qQTBvamt4UERoUERzdmVwbkFUM05OOVB1?=
 =?utf-8?B?d0gralREazUyRldFOUFIVk9RRzhSczU0bG5JTmJKZThSMXlyOVc2OURFWDBR?=
 =?utf-8?B?M0c4L1Ira01Nend6Ui9MVDBvUkJpaCtuTHludm91dnJYMlA3YXg3OHJRNDdU?=
 =?utf-8?B?citYYmpidDhhVFo2cUJkMmJDc05JdGs5L1djODZSa0tCMGYybTY5cEZWTzRH?=
 =?utf-8?B?MkYzNlQ1bXBYS2lETENJQ3E2UXFlc3pxd3BJcnpjN2MzdGhJUVNyaXVDOXo0?=
 =?utf-8?Q?+PgvHM8jov1wwYoZWIvexrY=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: aa4a7f26-ddca-45d0-d9a8-08d9e7beea56
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Feb 2022 09:15:41.2404
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Tx8qT2xnmFa9MXCrFZWVhVw/5q1tQVNVdVS8BVuHdIZDpA1sPszVwrwJgUjn+LF+NZqzFJFcAShThfbeMFpXrA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB6247

On 04.02.2022 09:58, Oleksandr Andrushchenko wrote:
> On 04.02.22 09:52, Jan Beulich wrote:
>> On 04.02.2022 07:34, Oleksandr Andrushchenko wrote:
>>> @@ -285,6 +286,12 @@ static int modify_bars(const struct pci_dev *pdev, uint16_t cmd, bool rom_only)
>>>                   continue;
>>>           }
>>>   
>>> +        spin_lock(&tmp->vpci_lock);
>>> +        if ( !tmp->vpci )
>>> +        {
>>> +            spin_unlock(&tmp->vpci_lock);
>>> +            continue;
>>> +        }
>>>           for ( i = 0; i < ARRAY_SIZE(tmp->vpci->header.bars); i++ )
>>>           {
>>>               const struct vpci_bar *bar = &tmp->vpci->header.bars[i];
>>> @@ -303,12 +310,14 @@ static int modify_bars(const struct pci_dev *pdev, uint16_t cmd, bool rom_only)
>>>               rc = rangeset_remove_range(mem, start, end);
>>>               if ( rc )
>>>               {
>>> +                spin_unlock(&tmp->vpci_lock);
>>>                   printk(XENLOG_G_WARNING "Failed to remove [%lx, %lx]: %d\n",
>>>                          start, end, rc);
>>>                   rangeset_destroy(mem);
>>>                   return rc;
>>>               }
>>>           }
>>> +        spin_unlock(&tmp->vpci_lock);
>>>       }
>> At the first glance this simply looks like another unjustified (in the
>> description) change, as you're not converting anything here but you
>> actually add locking (and I realize this was there before, so I'm sorry
>> for not pointing this out earlier).
> Well, I thought that the description already has "...the lock can be
> used (and in a few cases is used right away) to check whether vpci
> is present" and this is enough for such uses as here.
>>   But then I wonder whether you
>> actually tested this, since I can't help getting the impression that
>> you're introducing a live-lock: The function is called from cmd_write()
>> and rom_write(), which in turn are called out of vpci_write(). Yet that
>> function already holds the lock, and the lock is not (currently)
>> recursive. (For the 3rd caller of the function - init_bars() - otoh
>> the locking looks to be entirely unnecessary.)
> Well, you are correct: if tmp != pdev then it is correct to acquire
> the lock. But if tmp == pdev and rom_only == true
> then we'll deadlock.
> 
> It seems we need to have the locking conditional, e.g. only lock
> if tmp != pdev

Which will address the live-lock, but introduce ABBA deadlock potential
between the two locks.

>>> @@ -222,10 +239,10 @@ static int msix_read(struct vcpu *v, unsigned long addr, unsigned int len,
>>>               break;
>>>           }
>>>   
>>> +        msix_put(msix);
>>>           return X86EMUL_OKAY;
>>>       }
>>>   
>>> -    spin_lock(&msix->pdev->vpci->lock);
>>>       entry = get_entry(msix, addr);
>>>       offset = addr & (PCI_MSIX_ENTRY_SIZE - 1);
>> You're increasing the locked region quite a bit here. If this is really
>> needed, it wants explaining. And if this is deemed acceptable as a
>> "side effect", it wants justifying or at least stating imo. Same for
>> msix_write() then, obviously.
> Yes, I do increase the locking region here, but the msix variable needs
> to be protected all the time, so it seems to be obvious that it remains
> under the lock

What does the msix variable have to do with the vPCI lock? If you see
a need to grow the locked region here, then surely this is independent
of your conversion of the lock, and hence wants to be a prereq fix
(which may in fact want/need backporting).

>>> @@ -327,7 +334,12 @@ uint32_t vpci_read(pci_sbdf_t sbdf, unsigned int reg, unsigned int size)
>>>       if ( !pdev )
>>>           return vpci_read_hw(sbdf, reg, size);
>>>   
>>> -    spin_lock(&pdev->vpci->lock);
>>> +    spin_lock(&pdev->vpci_lock);
>>> +    if ( !pdev->vpci )
>>> +    {
>>> +        spin_unlock(&pdev->vpci_lock);
>>> +        return vpci_read_hw(sbdf, reg, size);
>>> +    }
>> Didn't you say you would add justification of this part of the change
>> (and its vpci_write() counterpart) to the description?
> Again, I am referring to the commit message as described above

No, sorry - that part applies only to what inside the parentheses of
if(). But on the intermediate version (post-v5 in a 4-patch series) I
did say:

"In this case as well as in its write counterpart it becomes even more
 important to justify (in the description) the new behavior. It is not
 obvious at all that the absence of a struct vpci should be taken as
 an indication that the underlying device needs accessing instead.
 This also cannot be inferred from the "!pdev" case visible in context.
 In that case we have no record of a device at this SBDF, and hence the
 fallback pretty clearly is a "just in case" one. Yet if we know of a
 device, the absence of a struct vpci may mean various possible things."

If it wasn't obvious: The comment was on the use of vpci_read_hw() on
this path, not redundant with the earlier one regarding the added
"is vpci non-NULL" in a few places.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Feb 04 09:23:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 09:23:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265226.458547 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFuoP-0005fF-FZ; Fri, 04 Feb 2022 09:23:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265226.458547; Fri, 04 Feb 2022 09:23:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFuoP-0005f8-CW; Fri, 04 Feb 2022 09:23:25 +0000
Received: by outflank-mailman (input) for mailman id 265226;
 Fri, 04 Feb 2022 09:23:24 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=wIUc=ST=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nFuoO-0005e7-7T
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 09:23:24 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0806663f-859c-11ec-8f75-fffcc8bd4f1a;
 Fri, 04 Feb 2022 10:22:54 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 8350E1F44E;
 Fri,  4 Feb 2022 09:23:22 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 51E9E13322;
 Fri,  4 Feb 2022 09:23:22 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id vayYEorw/GG1eAAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 04 Feb 2022 09:23:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0806663f-859c-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1643966602; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=tMfz+vr/zoDM737ejREHv1kOAHk5koJJ0ECWuIe9qdE=;
	b=WjxH2q0Nm5qAJBmOosqnoXRQ7VfPByeBGK6byVqKlpWZV6EltUpQYdBFYvI9KkuRRtNhR5
	QwiDm58YSnmAR68CGrkIQpWIjghzlzRFM1EI3vt2fg522ekrCtgeJUW0rcaFS2oQLny28D
	JR0D4vUztA4c+s6pWfK7wlhriQzjeUE=
Message-ID: <3c068b89-862d-f65b-6621-47323a0a832c@suse.com>
Date: Fri, 4 Feb 2022 10:23:21 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Subject: Re: [PATCH] xen: xenbus_dev.h: delete incorrect file name
Content-Language: en-US
To: Randy Dunlap <rdunlap@infradead.org>, patches@lists.linux.dev
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Stefano Stabellini <sstabellini@kernel.org>, xen-devel@lists.xenproject.org
References: <20220130191705.24971-1-rdunlap@infradead.org>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <20220130191705.24971-1-rdunlap@infradead.org>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------crB4HNfKkBBu73aaZi3Iq1Kh"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------crB4HNfKkBBu73aaZi3Iq1Kh
Content-Type: multipart/mixed; boundary="------------UQeZwwBY2y2yVmKzI2OEzpkB";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Randy Dunlap <rdunlap@infradead.org>, patches@lists.linux.dev
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Stefano Stabellini <sstabellini@kernel.org>, xen-devel@lists.xenproject.org
Message-ID: <3c068b89-862d-f65b-6621-47323a0a832c@suse.com>
Subject: Re: [PATCH] xen: xenbus_dev.h: delete incorrect file name
References: <20220130191705.24971-1-rdunlap@infradead.org>
In-Reply-To: <20220130191705.24971-1-rdunlap@infradead.org>

--------------UQeZwwBY2y2yVmKzI2OEzpkB
Content-Type: multipart/mixed; boundary="------------7TyyAKiPrloII9pdF0Zvy80u"

--------------7TyyAKiPrloII9pdF0Zvy80u
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMzAuMDEuMjIgMjA6MTcsIFJhbmR5IER1bmxhcCB3cm90ZToNCj4gSXQgaXMgYmV0dGVy
L3ByZWZlcnJlZCBub3QgdG8gaW5jbHVkZSBmaWxlIG5hbWVzIGluIHNvdXJjZSBmaWxlcw0K
PiBiZWNhdXNlIChhKSB0aGV5IGFyZSBub3QgbmVlZGVkIGFuZCAoYikgdGhleSBjYW4gYmUg
aW5jb3JyZWN0LA0KPiBzbyBqdXN0IGRlbGV0ZSB0aGlzIGluY29ycmVjdCBmaWxlIG5hbWUu
DQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBSYW5keSBEdW5sYXAgPHJkdW5sYXBAaW5mcmFkZWFk
Lm9yZz4NCg0KUHVzaGVkIHRvIHhlbi90aXAuZ2l0IGZvci1saW51cy01LjE3YQ0KDQoNCkp1
ZXJnZW4NCg0K
--------------7TyyAKiPrloII9pdF0Zvy80u
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------7TyyAKiPrloII9pdF0Zvy80u--

--------------UQeZwwBY2y2yVmKzI2OEzpkB--

--------------crB4HNfKkBBu73aaZi3Iq1Kh
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmH88IkFAwAAAAAACgkQsN6d1ii/Ey/3
Fgf/Zg//UOe0gFtCNCY8fhfB0xFel62hofznU7Hbuwfw4rrnuvKrPBhyx3ClUTtXbcTg988vphcY
apkv7TYsOzDCUOMFpxd2ed5fWe7wSsSLWkL/RX2wiH4IGBIKBP1ixHxEwvD3oihVCAYa6sJ99vL9
4vU+tyKlMD6lYGlpMbsWtYMgTxan/o5cG427eiIkVn0yxoxWzoujctU1dZHPD36Bk0osMmZYw2pq
Fe3eMDOJmDnkJOD96ucR49ulJrTefhv1tvKpCOsf039hIELixsLuFICSwJ3yoG/s1dOXxprwqK4J
zQOeuN/MOfTc/EWzB75DLrKsW5XT+QrwzPx25cWGog==
=IMLv
-----END PGP SIGNATURE-----

--------------crB4HNfKkBBu73aaZi3Iq1Kh--


From xen-devel-bounces@lists.xenproject.org Fri Feb 04 09:23:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 09:23:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265225.458536 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFuoL-0005Na-4v; Fri, 04 Feb 2022 09:23:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265225.458536; Fri, 04 Feb 2022 09:23:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFuoL-0005NT-0o; Fri, 04 Feb 2022 09:23:21 +0000
Received: by outflank-mailman (input) for mailman id 265225;
 Fri, 04 Feb 2022 09:23:19 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=46ws=ST=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nFuoJ-0005NN-9n
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 09:23:19 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 14de3f66-859c-11ec-8eb8-a37418f5ba1a;
 Fri, 04 Feb 2022 10:23:17 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 14de3f66-859c-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1643966597;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=Py0vIv6hjWVHAbB0atG47ZgO0hHXoS6wcB3gVNUUH/0=;
  b=X0gFJzjUeYE4MIJHZcDxSf76gFVf+X5N31Tqkad5ECsbQUWpMhDubMNx
   m7mVTaoGDznQeuLM4TbxdsKHTU6p12XK2FUXa/ZO90nI/iWJNMRJVKW+4
   4+eKdZrUFmJW30+TsX4gT5BZzcyTDLr451AgS8rWKXREe57S6BYmAJZjh
   Y=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: I4YvK+rjXCOFrdxZ8+okPZpz9ihn/qJVkil6s1i2IO5hYWLcacMFNS9+OJT8P8bY3zu12/cwAG
 93yBoP+YcCM4YpqIEmOf1/iCKNwbTd1rKXR390VjNglvGPTZhmBKf/gPDS2yxF5KaT0D/BJSy0
 1PVAsMvsYwHckKcuUOrDAASinhYGXikO8NX9Mx11ZmcOJfVvXa2n7YM7Jfz2gtyyV/ocLZEYem
 C/Q/aiiOXt5lJZ9NkgVhUQ7GeDmr6LFpTIPcAOuyWh+1YV5IY5qedPQPh77A4snZlrC24Sw6v/
 B1zVEHnpAb2ADY0gY8X/siF2
X-SBRS: 5.2
X-MesageID: 63487251
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:WDWESai0PJQkmlQ3ptGHqQ7lX161/BcKZh0ujC45NGQN5FlHY01je
 htvWDvQPveIY2b0fo91aIq/9xlQ7ZTUndRkSABqpSlmEC0b9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oAMKRCQ7InQLlbGILes1htZGEk0GE/NtTo5w7Rj2tQw3YDja++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /1EpaKRUSArPZH1v80PaxhzPjM9NJxvreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHxO4wSoDd4xCzxBvc6W5HTBa7N4Le02R9u3ZweQqyDP
 qL1bxJ3NxLdcxp+MG4qVrt5mseEgWbTQhZX/Qf9Sa0fvDGIkV0ZPKLWGMHOZtWASMFRn0CZj
 mHL5WL0BlcdLtP34SKM73aEluLJ2yThV+o6BLC+s/JnnlCX7mgSEwENE0u2p+GjjUyzUM4ZL
 FYbkgIsp6Uv8E2gTvHmQga15nWDu3Y0RN54A+A8rgaXxcL84RudB2UCZi5MbpohrsBeeNAx/
 gbXxZWzX2Up6eDLDyLGnluJkd+sESEFE04aQi0HcTIiysvboaoenFHGf/82RcZZkebJMT33x
 jmLqg03iLMSkdMH2s2HwLzXv96/jsOXF1Bov207Skrgt1okP9D9O+RE/HCGta4oEWqPcrWWU
 JHoceC65ftGM5yCnTflrA4lTODwvKbt3NExbDdS83gdG9aFpibLkWN4umgWyKJV3iAsI2SBj
 Kj74ls52XOrFCH2BZKbmqroYyjQ8YDuFM7+StffZcdUb556eWevpX8yPh7Lgj6wwRNzysnT3
 Kt3l+72Vh727ow8lFKLqxo1i+d3lkjSO0uPLXwE8/hX+eXHPyPEIVv0GFCPcvo4/Mu5TPb9q
 L5i2z+x40wHCoXWO3CPmaZKdAxiBSVlWfje9pIGHsbeclsOMDxwUJf5nOJ+E7GJaowIzI8kC
 FnnBB8BoLc+7FWaQTi3hodLM+KyBMsv8C5gYETB/z+AghAeXGpm149GH7Mfdrg77u1zi/lyS
 vgOYcKbBfpTDD/A/lwggVPV9eSOrTyn2lCDOTSLej86c8IyTgDF4Ia8LADu6DMPHmy8ss5n+
 ++s0QbSQJwiQQV+DZmJNKLzng3p5XVNyvhvW0boI8VIfBm++oZdNCGs3OQ8JNsBKEufy2LCh
 RqWGxoRucLEv5QxrIvSnamBoorwS7l+E0NWEnP197GzMSWGrGOvzZUZCLSDfCzHVXOy86KnP
 L0Hw/b5OfwBvVBLr4sjTOo7kfNgv4Pi/uYIwB5lEXPHa0WQJolhenTWj9NSsqBtx6NCvVfkU
 Ey45dQHa66CP9noEQBNKVN9PPiDz/wdhhLb8e8xfBfh/CZy8beKDRdSMh2LhHAPJbd5Ktp4k
 +IoucpQ4A2jkBs6dN2Bi3kMpWiLK3UBVYQht40bX9C32lZ6lAkabMyOEDLy7bGOd85IYxsjL
 TKjjabfg6hRmxjZeH0pGHmRhedQiPziYvyRIIPu87hRpuf4uw==
IronPort-HdrOrdr: A9a23:OZ9WUK3gy7rBd63ghCIXWwqjBVByeYIsimQD101hICG9Lfb2qy
 n+ppgmPEHP5Qr5OEtApTiBUJPwJk800aQFm7X5XI3SJzUO3VHHEGgM1/qB/9SNIVyaygcZ79
 YcT0EcMqyPMbEZt7eC3ODQKb9Jq7PmgcOVbKXlvg9QpGlRGt5dBmxCe2Cm+yNNNW177c1TLu
 vh2iMLnUvpRV0nKuCAQlUVVenKoNPG0LrgfB49HhYirC2Dlymh5rLWGwWRmk52aUIE/Z4StU
 z+1yDp7KSqtP+2jjfaym/o9pxT3P/s0MFKCsCggtUcbh/slgGrToJ8XKDqhkF/nMifrHIR1P
 XcqRYpOMp+r1vXY2GOuBPonzLt1T4/gkWSvmOwsD/Gm4jUVTg6A81OicZyaR3C8Xctu9l6ze
 Ziw3+Zn4A/N2KOoA3No/zzEz16nEu9pnQv1cQJiWZEbIcYYLhN6aQC4UJuFosaFi6S0vFqLA
 BXNrCc2B9qSyLbU5iA1VMfg+BEH05DUytue3Jy9PB8iFNt7TJEJ0hx/r1qop5PzuN5d3B+3Z
 W1Dk1frsA6ciYnV9MNOA4/e7rFNoXse2O7DIvAGyWvKEk4U0i92aIfpo9FoN2XRA==
X-IronPort-AV: E=Sophos;i="5.88,342,1635220800"; 
   d="scan'208";a="63487251"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=l13yM9SMAsWdAEcPtu8PnnssPjDZgxRLjWhHIDkaDHNBN5t9dYyKfte3cVdyqaY9KNOmYh5uMVLgiSe514fhv31/JH44SGUMsmETKnuFsHbjZ3c8Q8hqFiFhZ38cc4blM2+Z6TB54tJM4ySuW083vHQu3SvmwI/ecIx4p0Y2nH1BopQQcbqH+13bNpBQ8GDz628a/NAcsvcMxPXfJV5JtQnGLTrpW8ibzXZnz09HQGsNamwVkPK2/8v1Sl6Lw/22aScKmesj/oB5QM/RNY37Gk8qVHmbx7d2BfAxNTN7yIR6Q7zm8VwJ6/92QATP74bcYXXOzgqpnKCnSkm+QDx3TQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=9Ro+G7XcDQDdwFpozBkSjFjPo4+IMmlcDyncGzsGGMo=;
 b=NKYVUv+BMzTnEjzLzozlXQsmhESTVLSybF0JYVA9RUuw/aNNrZ/GwG/eXGv+SRujkepkW4yKGQ8gyOWqwZhpiZCXWxlblQ6an1TOV+r1+0zHVZoXbY+Neyw1rtZNm1/MespVV7D+/l+Ji7d7sECQesVmoN1s9GyMdgG9cQxMcB/hV2zgUcS/NPfLv+/lxDpHGByqE9Q7sQH/R50YRevH6XlxNrwP4bHJE+HvRWXmmkPRwGvfhW54TQ0k+gWne+0fEAqnRK5JxVILNCTyuzSYohzn7U9kkuQvBpKYsa/F4QjzV7fq7LeHknQr/tvkj1laJsNUazM7JoqxqgISQf6GGg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=9Ro+G7XcDQDdwFpozBkSjFjPo4+IMmlcDyncGzsGGMo=;
 b=wOvEXYUGy3vmqvvmfBRN/24MJeXKQO+OxUK0nwKI2PQVeZNZLXxEcrtZhjXw/DjTDloQTGyHPattkYN0YkmJRcJVr4FxhFeBe4S9RI0wu5vFFBG89bX+tYybZO6xhap3HBWn/+4j4pHAE1gT6d6K2Z+oA/tfP8UeieTxdeVT4ys=
Date: Fri, 4 Feb 2022 10:23:06 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>, George
 Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>, Stefano
 Stabellini <sstabellini@kernel.org>, Paul Durrant <paul@xen.org>,
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 2/3] x86/vmsi: add support for extended destination ID in
 address field
Message-ID: <YfzwepCoIvJ3cI0v@Air-de-Roger>
References: <20220120152319.7448-1-roger.pau@citrix.com>
 <20220120152319.7448-3-roger.pau@citrix.com>
 <2e96bf2e-a31e-da9b-2f08-adfa0928e5b9@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <2e96bf2e-a31e-da9b-2f08-adfa0928e5b9@suse.com>
X-ClientProxiedBy: LO4P123CA0511.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:272::12) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 96f11fb6-526b-4baa-77d5-08d9e7bff6b5
X-MS-TrafficTypeDiagnostic: MWHPR03MB2959:EE_
X-Microsoft-Antispam-PRVS: <MWHPR03MB29599575EFECF0F23F53B1DC8F299@MWHPR03MB2959.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: ZaxgNDEUAmXR97lb3M/U6XMpN5bltnPhl2l1limbjRgQ+eepgXUrHBcNNHL7TNpVCKfcEBbnnW2hKnFONS4XurlbPGcUTOVg1FAzXxU9ZgzLWfYF+UC971pxWY5a8cN4PJpb4IFzBVcJmagMOTtdvev/uPIV9QC1gisrtHZZdftHCUfp468smrvuRrVek3llIXbZEzDJuGpWTE6X2oaU9GIeCEQEJlZn6WTM75MUpisMq8bvo5FoJfD7ulW6lPN2j1YXcqReXtZRkCP7kCDawwASOpG4q8F5SHq82CsT34YRf/RL2zRo5jVaPvBtu0jjPkMOeqSeeASHEjFBSj5MWo/gngw9h5bfiMNjtKn0ClVZdTmR6sKCco3c2ZUKWKazbXWAHIMeTNrgworzvkaV0rydRXTsltu2wctELQTtkHzNv7PjdlXgIpMBtG8utOB+K9QkHAcxZ1slBNaw4oZb+A93JeHnlqv2wBxe1EwzHRm3w/DcWynU2BRaje5ZaBqGahaV4/hCLiBSgY2aRcvSWAj2eMSyJG4idsPcvL/YKu0E0241a6embWP3DCX+hEEN05h8SvnOI1n2TnOfvC0JVOFFdH7ISxy3SrpfBAS1vmFv1dqtPsCl6eOwmFH9dZBFdxIAQCSqcnWf99rcXQq0dA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(2906002)(8676002)(8936002)(66476007)(66556008)(4326008)(83380400001)(6512007)(5660300002)(66946007)(26005)(186003)(9686003)(85182001)(6506007)(53546011)(6666004)(33716001)(86362001)(316002)(6916009)(6486002)(508600001)(38100700002)(82960400001)(54906003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UElwRGJkOERlTkdzbWJZeVU3M3JJMENrcUR5emJJRDJLUjNjcUxhdnFNUlpj?=
 =?utf-8?B?YnUvZ3R6NnJuNkV6MHVCTEVndUNtUHQyNGYyOFh4dzhxZ1pXb1BOcitDdkU1?=
 =?utf-8?B?TlozYjFnMkp2dTdNWi9RMlVucHMvbVNYaWlTelZsRmJuUGFHWGNGVUxVdHQ3?=
 =?utf-8?B?aEsxYllWeXkrT2RDOWs4dUtpZ1Z5bTAwQUxUQUxCOGx1bWl6WXNSSDNjMzl3?=
 =?utf-8?B?ZUFPOWMvajJTL1RnSEcrdVNFVFJFQlNxdmdJbTRPY0UzMG5la2lUaWZuTmNM?=
 =?utf-8?B?OFJYbzMyN2dYa2V6NVp2Vi9yb1QwZTB3eGc5dDR3T2hoQ2RBQm0wWnVWaHY5?=
 =?utf-8?B?MVVDVjFUWEZZRkdLYXNjbUY1TktDbjN5VVZUbzRQQjkzZmtSWTVoZWhpQ0pN?=
 =?utf-8?B?VFhvNmd6L0pxZkZRTWNOdWY3RE9YK1BITUNsOGlmaTFlZkxVYXRLdnZyb0dJ?=
 =?utf-8?B?cVdSbXpHMWdzWVZqYlpNd0QveEZ2UjBseExVaWxhYWM4NlI0Z1ozcWZONFF1?=
 =?utf-8?B?T21nWTVLaytBbkxNVTNzR3RyN0NlZjJ4U3NRQ1dVbThmVUZQZDVCa3huYk9x?=
 =?utf-8?B?OGJxR0l4c056cHBraDlONmFwU3hYNG52N3hqRjBFckdneVZjQVd3dnhyRjlS?=
 =?utf-8?B?YmkvWHF0OXp4RzRURkdPMmtlS0NFZDBxc1l1QlN4Q01oVWRqN244Q0pKMHVZ?=
 =?utf-8?B?Q0FXUU52b0RHY2ZsKzlmQWUvQWs5aWJXNUVtMERqM0V3WnVYUUtxQnBmRFJF?=
 =?utf-8?B?WHRTMU1RVk80QndKVnV4QWU3Z0MyNGlXdnBBWG9DcWU3dlJTRUgyS055NUZx?=
 =?utf-8?B?Y1cxU0wvV1l1MHZSZ29KeEZET1c3WUFtSVZ2enFWVm16SW1lZGFiQzYrZ0tp?=
 =?utf-8?B?NE9JUDB3bmhXb25TcG1PT2FyOFB4QWphU2srcm9ObTlreTBTV3RiKzJLaEF4?=
 =?utf-8?B?NmNwakhNYitKZzBCRjFmbEZHYXQwMFNKK2RpTzA2bzlpOGo5NlR5QUZrZFFn?=
 =?utf-8?B?N3BuU2hMbnAzaENSdGFtYjVWUnNRektZRlpBbFNNYktMcDRoSGwvVUFob2VB?=
 =?utf-8?B?YTdqNDVUZlJVaGFLeFdXUHUwZzQ2SlpxNWhhMEVyWmgrcEUvWTFYeXB4VllU?=
 =?utf-8?B?aW4xbFczZCtUSzVWREpKWldsNlphMGRWbFY4azVrU214bng3bWhZVllHZnFx?=
 =?utf-8?B?YTFLWFRwT3Ewa1IzQkp0S0N5OWF4S3ZXT0NkNzgvYk5nYndjeHZtK1k5OHJQ?=
 =?utf-8?B?US9nRGxnSVg4Vmk4TGlPdEhWRjNEdmRRYmdRb09VWTNhT0tVb0JIVFRTL1FE?=
 =?utf-8?B?aG5aemx3MHoyWVJBVDFIbjNnT2tXZC9HMzhib2Y4dmU1RWNiUTE3cWdnRjdS?=
 =?utf-8?B?anRzdGx2elZudi9GaUd3MUhDL0RMZWQ3U2NxNW9rK2JsZnFVM1FXR2p4MGJt?=
 =?utf-8?B?SklTZmhTSXVINFc0UHZ1Y1k1N2RPMHIxeXd0Y09uaWF1dzg4NGVTZkVuejMy?=
 =?utf-8?B?SzdpVUs4NXBUM1kxV3F4eDNweXpkUis3bURHUXp5dG9RVWRhYS9sanhkTzRt?=
 =?utf-8?B?YXlSamUzSlZpRkRYa2pYTktjYjlkdHA3M2Q4Vks5aml5ank3Y2xDWlpjc3pW?=
 =?utf-8?B?cC9jSFc0aW14YkdlNE94RWZVY241Z2d0T1YxblNpblptSTZWMVVIajBjbUdz?=
 =?utf-8?B?Z1J4aGh6VFZObTZNRE1QSEc2QlVRR1Yyb0Z4OWdrRGVqL2lvbXNrR2IwbUF3?=
 =?utf-8?B?M2dWdCswY0h2VlF1MXFVeWU0Qnk2VCt4ZzRPM3k3azRwQlYrRjI0ZmljNW9p?=
 =?utf-8?B?S1c1YTh6b2JEZWlaQnF5WWM5eEdTV3ZsdjY5Tm1zSDBLdHcwOEg3UUdoN2dM?=
 =?utf-8?B?NlFnL3pMZ3F1M0FDZyt3Y2U1MHkvTjdaR2VLUE5xMEpGdFNIcXNLVStOMlJn?=
 =?utf-8?B?clZMc3RsNmdNR1lqa2h5NHAwUnErVVhMdDdMSkM0RHVLcC9KWm5FR1J0YXNh?=
 =?utf-8?B?dno1YVhIdEIwek9hd09EM2VFVVVGRUdhalZLblJrKzNmZkUya2FqV2I2VjZU?=
 =?utf-8?B?TVM3UlNMZHhydXhiam1hblZEOHBsQzI2alZ3c3NYUEVtdGN3U3JRZTFIaDJs?=
 =?utf-8?B?THdEYVQ0dE8rcFF2bEtxdXUxaEpJMDBKT3VHMDluVmpnSHByTWVQVzB0Wm04?=
 =?utf-8?Q?062X9kTqma8grLF9vd5Yriw=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 96f11fb6-526b-4baa-77d5-08d9e7bff6b5
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Feb 2022 09:23:11.5680
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CGTR4PXdJoQiOnLvVtrGsBzOP31Rxdqo+HN+chpJr8IRroYXx4VhBXE6jfJY2D+a6UewbeTOKwLZsRdw24aDhQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2959
X-OriginatorOrg: citrix.com

On Mon, Jan 24, 2022 at 02:47:58PM +0100, Jan Beulich wrote:
> On 20.01.2022 16:23, Roger Pau Monne wrote:
> > --- a/xen/arch/x86/include/asm/msi.h
> > +++ b/xen/arch/x86/include/asm/msi.h
> > @@ -54,6 +54,7 @@
> >  #define MSI_ADDR_DEST_ID_SHIFT		12
> >  #define	 MSI_ADDR_DEST_ID_MASK		0x00ff000
> >  #define  MSI_ADDR_DEST_ID(dest)		(((dest) << MSI_ADDR_DEST_ID_SHIFT) & MSI_ADDR_DEST_ID_MASK)
> > +#define	 MSI_ADDR_EXT_DEST_ID_MASK	0x0000fe0
> 
> Especially the immediately preceding macro now becomes kind of stale.

Hm, I'm not so sure about that. We could expand the macro to place the
high bits in dest at bits 11:4 of the resulting address. However that
macro (MSI_ADDR_DEST_ID) is only used by Xen to compose its own
messages, so until we add support for the hypervisor itself to use the
extended destination ID mode there's not much point in modifying the
macro IMO.

> 
> > --- a/xen/drivers/passthrough/x86/hvm.c
> > +++ b/xen/drivers/passthrough/x86/hvm.c
> > @@ -269,7 +269,7 @@ int pt_irq_create_bind(
> >      {
> >      case PT_IRQ_TYPE_MSI:
> >      {
> > -        uint8_t dest, delivery_mode;
> > +        unsigned int dest, delivery_mode;
> >          bool dest_mode;
> 
> If you touch delivery_mode's type, wouldn't that better become bool?
> 
> > --- a/xen/include/public/domctl.h
> > +++ b/xen/include/public/domctl.h
> > @@ -588,6 +588,7 @@ struct xen_domctl_bind_pt_irq {
> >  #define XEN_DOMCTL_VMSI_X86_DELIV_MASK   0x007000
> >  #define XEN_DOMCTL_VMSI_X86_TRIG_MASK    0x008000
> >  #define XEN_DOMCTL_VMSI_X86_UNMASKED     0x010000
> > +#define XEN_DOMCTL_VMSI_X86_EXT_DEST_ID_MASK 0xfe0000
> 
> I'm not convinced it is a good idea to limit the overall destination
> ID width to 15 bits here - at the interface level we could as well
> permit more bits right away; the implementation would reject too high
> a value, of course. Not only with this I further wonder whether the
> field shouldn't be unsplit while extending it. You won't get away
> without bumping XEN_DOMCTL_INTERFACE_VERSION anyway (unless it was
> bumped already for 4.17) since afaics the unused bits of this field
> previously weren't checked for being zero. We could easily have 8
> bits vector, 16 bits flags, and 32 bits destination ID in the struct.
> And there would then still be 8 unused bits (which from now on we
> ought to check for being zero).

So I've made gflags a 64bit field, used the high 32bits for the
destination ID, and the low ones for flags. I've left gvec as a
separate field in the struct, as I don't want to require a
modification to QEMU, just a rebuild against the updated headers will
be enough.

I've been wondering about this interface though
(xen_domctl_bind_pt_irq), and it would seem better to just pass the
raw MSI address and data fields from the guest and let Xen do the
decoding. This however is not trivial to do as we would need to keep
the previous interface anyway as it's used by QEMU. Maybe we could
have some kind of union between a pair of address and data fields and
a gflags one that would match the native layout, but as said not
trivial (and would require using anonymous unions which I'm not sure
are accepted even for domctls in the public headers).

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Feb 04 09:23:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 09:23:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265235.458558 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFuoq-0006Un-Oo; Fri, 04 Feb 2022 09:23:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265235.458558; Fri, 04 Feb 2022 09:23:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFuoq-0006Ug-LZ; Fri, 04 Feb 2022 09:23:52 +0000
Received: by outflank-mailman (input) for mailman id 265235;
 Fri, 04 Feb 2022 09:23:51 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=wIUc=ST=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nFuop-0006TE-E4
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 09:23:51 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 29b90d86-859c-11ec-8eb8-a37418f5ba1a;
 Fri, 04 Feb 2022 10:23:50 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 3B62D1F44E;
 Fri,  4 Feb 2022 09:23:50 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1026413322;
 Fri,  4 Feb 2022 09:23:50 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id C4pcAqbw/GHieAAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 04 Feb 2022 09:23:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 29b90d86-859c-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1643966630; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=RRLlynzwQUyu0Ry2iHE9HxszpY1MyDqTOYy3+lP/PUg=;
	b=euJfpBMKuybHTjC/B50d1QfhxHnksuynJIaBJ8mkUWJwszI2fNw2KAkhRkFYnvLsOfKvn5
	/ZJ51BmV+A0vcFu/XF6i7VL0Iraqk6UnJEC5GQuZtBN2m4nkgqB77Wikvb1Qv0PWyj48wt
	/fgg8Ms5qGH2XMiB6SIhZqbp6Qjq/PA=
Message-ID: <0850fe20-8068-7780-9e19-f3f3c2ef8655@suse.com>
Date: Fri, 4 Feb 2022 10:23:49 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Subject: Re: [PATCH v2] xen: update missing ioctl magic numers documentation
Content-Language: en-US
To: Randy Dunlap <rdunlap@infradead.org>, patches@lists.linux.dev
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Stefano Stabellini <sstabellini@kernel.org>, xen-devel@lists.xenproject.org
References: <20220131161959.16509-1-rdunlap@infradead.org>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <20220131161959.16509-1-rdunlap@infradead.org>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------NNRk0QNS2HKGb7xIyuBOdBx0"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------NNRk0QNS2HKGb7xIyuBOdBx0
Content-Type: multipart/mixed; boundary="------------W20FlqUGWyleq74HGU8HW0TC";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Randy Dunlap <rdunlap@infradead.org>, patches@lists.linux.dev
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Stefano Stabellini <sstabellini@kernel.org>, xen-devel@lists.xenproject.org
Message-ID: <0850fe20-8068-7780-9e19-f3f3c2ef8655@suse.com>
Subject: Re: [PATCH v2] xen: update missing ioctl magic numers documentation
References: <20220131161959.16509-1-rdunlap@infradead.org>
In-Reply-To: <20220131161959.16509-1-rdunlap@infradead.org>

--------------W20FlqUGWyleq74HGU8HW0TC
Content-Type: multipart/mixed; boundary="------------mUnUayQgEfVjvjLXnoqTkgxO"

--------------mUnUayQgEfVjvjLXnoqTkgxO
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMzEuMDEuMjIgMTc6MTksIFJhbmR5IER1bmxhcCB3cm90ZToNCj4gQWRkIG1pc3Npbmcg
aW9jdGwgIm1hZ2ljIG51bWJlcnMiIGZvciB2YXJpb3VzIFhlbiBpbnRlcmZhY2VzDQo+ICh4
ZW5idXNfZGV2LmgsIGdudGFsbG9jLmgsIGdudGRldi5oLCBhbmQgcHJpdmNtZC5oKS4NCj4g
DQo+IFNpZ25lZC1vZmYtYnk6IFJhbmR5IER1bmxhcCA8cmR1bmxhcEBpbmZyYWRlYWQub3Jn
Pg0KDQpQdXNoZWQgdG8geGVuL3RpcC5naXQgZm9yLWxpbnVzLTUuMTdhDQoNCg0KSnVlcmdl
bg0K
--------------mUnUayQgEfVjvjLXnoqTkgxO
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------mUnUayQgEfVjvjLXnoqTkgxO--

--------------W20FlqUGWyleq74HGU8HW0TC--

--------------NNRk0QNS2HKGb7xIyuBOdBx0
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmH88KUFAwAAAAAACgkQsN6d1ii/Ey/R
Awf/ax2bWwMPZ29aKpnCJI7JQyJMDXGxbPSa9mEQaNhIA/fkEcZFeHmwvm22+09GGSjS+O7VP9/R
nW9FDL9YEOMazneMkO8w4sRTIuKWHQn+RGwfMUDueQq06KJMHR2C9hBjMmdJVcFwnY3DNolASyo/
xE52i+VmIlsi3fEO/IxIVilCL8eZXQ2LQxitMWFp7y6g0oqCBk0hy8zfeC+OerPe/eQfppuBVxn7
9s5Q3hCnVmbDLATOx3p1bLHG3ORyh0zjBFqWopZiWwdbKZ1HtNhvlEopb8721DLkSi7eHrhPCGH3
G54lo0nQfgT2CPUuYDJsKF4I2CHwjoC/Mh8+IvOOgQ==
=ag+7
-----END PGP SIGNATURE-----

--------------NNRk0QNS2HKGb7xIyuBOdBx0--


From xen-devel-bounces@lists.xenproject.org Fri Feb 04 09:24:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 09:24:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265236.458569 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFuoz-0006pT-1d; Fri, 04 Feb 2022 09:24:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265236.458569; Fri, 04 Feb 2022 09:24:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFuoy-0006pM-To; Fri, 04 Feb 2022 09:24:00 +0000
Received: by outflank-mailman (input) for mailman id 265236;
 Fri, 04 Feb 2022 09:23:59 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1gJ0=ST=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nFuox-0006TE-L0
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 09:23:59 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2eb7a34f-859c-11ec-8eb8-a37418f5ba1a;
 Fri, 04 Feb 2022 10:23:58 +0100 (CET)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2051.outbound.protection.outlook.com [104.47.6.51]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-35-gBgKrGrJNPmrTBlBSZrVZA-1; Fri, 04 Feb 2022 10:23:57 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3406.eurprd04.prod.outlook.com (2603:10a6:803:c::27)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.14; Fri, 4 Feb
 2022 09:23:56 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.014; Fri, 4 Feb 2022
 09:23:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2eb7a34f-859c-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1643966638;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=XNPUMy76s9V5P1WX5LpPDEh9bgK8dMDSXDK15/We5mA=;
	b=FpgkqgaHHCOWHEhh3Natkw6wNYt3IF9Thu/JnDlnyaweIAT3uP+H+dOzQeB1jqTl6RyoNy
	C+Y4NDcsHeEuibL/STCysbWvJSoj2Xn2wS2acqig0kIlLIBtxz5k9kd3l9pI3C/DSKuSZ0
	P6jesa6LIuL+741oVSAgXmvU5WTMfUU=
X-MC-Unique: gBgKrGrJNPmrTBlBSZrVZA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=FPZjm/y3QXrpihTaa7fApheUpBiyID4p0ZkBn0c0lhhDCG1hbbHTTEnFR7srH2VbPk/+AEX1TYSsL11cGux38r3F6Xr4bX9y3Op5ZZi8EFJ8qQFkyS+S39hkTVx1ASbT6ncTCkLx60KJoNqGOU9pq+6VCxjnEDWil5M2yGqkFhv1lCn6JOoDF81nugJ6+Kj+sgV2frKyl5UWrtNrgekNg4QU6b4+frYpBi5lOKMwQypAksR3k8wc+gLU2MqSNnXe+p4/Oi+xGWA6/UPgvkiA5EeaQ4I/ZXI0WYfEpjpAfTGINPmsfAw5VFMwhM9N6XUifigA898WWDMMWsztboW74Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=XNPUMy76s9V5P1WX5LpPDEh9bgK8dMDSXDK15/We5mA=;
 b=lWsMR09NAk8TxkmRpuwFOn30WaGPJtFAf1Mw3fmymDQ9EnAAt0hpO9EwJ6YY1He+YgBwLMrfpFxttjn+4kEeGM8PfUkHLwSMkNNHfu2WOzDpcaEuJlRrl9ZQDEgOI6dnY1TPkGcqNbX7OP/p5opzirmjdHK4Jxndh7S+ROiU3vvUCmrkPcga4yNDIPVpbOy1kiuV7adYIv/DSt9dyXno6URM8f1PoeXpx1h/BfzsK9t2sZo70pcVItgMwePGv1YNN5FZZahfUeoPkoLTN7blw0/6U3hkMybhcghU6yKzrh0YZXBXttKawjUpXHphGa55WMACLlRTrlaKkQkKglKqqA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <68c4f398-0494-e272-47e0-6803b6865f15@suse.com>
Date: Fri, 4 Feb 2022 10:23:54 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: x86: insn-eval.c's use of native_store_gdt()
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>,
 Peter Zijlstra <peterz@infradead.org>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 the arch/x86 maintainers <x86@kernel.org>
References: <0d687d64-1cf0-8965-0569-bce27cf0a8b7@suse.com>
In-Reply-To: <0d687d64-1cf0-8965-0569-bce27cf0a8b7@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P192CA0064.EURP192.PROD.OUTLOOK.COM
 (2603:10a6:209:82::41) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 575a34ba-9f8c-4f01-11bf-08d9e7c01188
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3406:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB3406B928D4272FACBD410C08B3299@VI1PR0402MB3406.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	eFtwcxduQTYLJ4iHxNRk13a/G63z8RmJ0KUHm5wDECmW3XXWugPABxEhcQEvujGkuJ3Ijovy48wnDFwk5G0YX273YJy5k589QckZ4p/pARDYfKripjDcmqMBf1wM0zct5B0AG55dLpS6xBDPB2ASIHAwDBvSL7MmUH7sUyU84c+5mGIXcmWgsXVop8R4NYmIEe+C/6yHvbXfbmP2+lzABv/MXyzYMA47t1+GsbS3foVUBIL9KKthbma2JsVNmqo7S6IWIuTSZm3Rc95AdPgmAWs77yR5yTFl8mrhxCnH4DcTkjQ2S9UNxOHKT1tuCFCCpgcHLeB9rni2tO9cIaqiP3JvBcIY3Xn9SF3zprlB7M6bA48/oLR5fo0+ZA97WS10W9fDnJIFyZcW1VyDJieKUYFueTu+E1KdedCeaDxg9Nr59W6aPWuYZD3+gUpF/ynG98hEIZsZqAAG3W9GcZPJwM1CZxZnEc4B0Dt3ktpCTB0ZXqqs6MvTRPJ48gmBQQh8dxsZzMfasUvYy9cZ71+15U7t//JnV8Yh3+PG395cLYHNe5l9fbdeMpgpdEdDtJMKiFlfpNKIFq401TOFivwvCs4y/SKBXZbx+OTlB5ePS78CS5YeVCz5tv29ythT7KDjQuxnCM9RaQULtbXn2k5O1Q3PeFK1RdAE1YtVaYefs3EBbrOmQaH0O5CFNCo4eThDJsKRXj5Qkh/XztqCpjitEp59r2iow650eTHoN7gJJo8=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(86362001)(31696002)(508600001)(110136005)(38100700002)(54906003)(316002)(6486002)(5660300002)(4744005)(66946007)(4326008)(66476007)(66556008)(83380400001)(2906002)(8676002)(8936002)(6512007)(53546011)(6506007)(26005)(186003)(2616005)(36756003)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Yys4M2s0czBzMDhSanBhVmlqY2gvWmM5NUk0NjZmaXBScmhFMmpyQkFzcGVJ?=
 =?utf-8?B?YVBuWngxbzF4anJhdmhRYUJUaTJubmtPQ3h3K2JqVjh3MVQvOVhoZ2pMNmwy?=
 =?utf-8?B?c3ZmSmM5RURDVERhcFk2VDJBTGNab3hVYTlDZjMvU05qdGN3NFc4T3VJUnB6?=
 =?utf-8?B?TXdyUjd1UnU2VGxpMm9rWUJaQTR3Tm16bU1uR2lGblcxcVVXQ3RqalBROVc3?=
 =?utf-8?B?Rk5FeTRFR1hjRk1NWFROd05KUjBTM09kSTVVSFEwZ3QrWE9uS0IxbkJnS0Q3?=
 =?utf-8?B?WlcrVDZCWjJXYUNhSDgvTjZiMFJlSUE3TnlQTnZGOVpzVlhLUWcrN1ZUSkZa?=
 =?utf-8?B?WlZNOG5oSmsvRFZ3dU1tbDFHK3hNRHRHc3Q0cFhGM1hxNFE0aUJObEtYazJB?=
 =?utf-8?B?Y081NnExVkpQVU9Fb1RSaWR6Z3N4bFQ0SW1KbFIzYzN0UDM4UHBIUTcxV0pM?=
 =?utf-8?B?TnVrK1NMOGU4UGR1T3lqc1VDYnF6VnNqS05kMExvcWplUEY2UTZPMjFsMUdU?=
 =?utf-8?B?N2xaWWprdXNmdDlncGFyR0EzNFo0Y2FQNi9BcC9UOFVvbWI4T3k5dnJtOC9R?=
 =?utf-8?B?K2w4OVZ3WU1JVXhxVVhZUkxVWGtjOGxKU2szNUhYaE9weStwMXNldm1IQ1U3?=
 =?utf-8?B?OFNMczZySmpqbEJZT2RydVcxR1FxUjFDY1luWFFJUXZVdFVwUE9lNWhDSGlt?=
 =?utf-8?B?OTBBN0NGQ0ZTU0J4YmZHWE1iTDg4S3hWYVdYSVFRTWJXVmRQdERrRzc0aTF3?=
 =?utf-8?B?a3YwN2wrMW9uM2JMQzZ0SHpocFJldVBEVkxoQ21OV0VVMDFPa3F2WlBMbUI5?=
 =?utf-8?B?cnBZRGozNzZKdWcxcTFQZTZPS25zcXE3T1BBbncrSmlucDR6MXB1N2FZRFM0?=
 =?utf-8?B?aG1ObWQxN1pOQWhkSk1QanIrSjYrVU9RNTluM05yWHUvMXVpOCtTdXZwWjBu?=
 =?utf-8?B?TzA5T1NnaFBYZlBUMDNtL3o1ck1DZ2k0QVkwZlpZUHlzMGg4NUhXN013cmdj?=
 =?utf-8?B?WmZYMVVNclcydDRpYnlaM1JrbFcvZmZKL3JVSDJyemV0N2RRWWp1ZVhWMHNQ?=
 =?utf-8?B?OFhIemFEZnhvQlF0Yk1rLzFOVm1UNUNwbUtNc2x3TVFJQ1RoQ1EyOGZ4ZThl?=
 =?utf-8?B?Tk1nYmFqSDVVSGdNMExobFo1aEcyczFoU3RYVlNnRUlhWHUreFNTSUV1d3RU?=
 =?utf-8?B?KzFNdHRHQ3dodlhaNlZHTkEzZUtUeDlQOGJjZHpWeFhxa1owM3JkTDJjQ1lx?=
 =?utf-8?B?V1p4MTlidmhoR0pWOEN0cHYzczFJajYzSVU5MzhPaThGR2p6M1hzVWlId1Nw?=
 =?utf-8?B?ajJ3SUlXaDE0WnhYcGZhdHFLUEJvdUVYdGh0a1M1SmVPVlZJQm5vdVZKay9L?=
 =?utf-8?B?WVhXOCtxOTVCWHZId2FEM2tkclFOVEtJamhZM3lOYjE5YWV6U1dnS1ZWenhl?=
 =?utf-8?B?a0NidUFFaGlDQ3dyU2JpUmovanpkc2I0YW8wUmR2V1VRRXBLUWw1VzlzN3Ra?=
 =?utf-8?B?NTh4cGVwTURQdHI1Q2I0UGdXRm5KRnpDcjB2RzR1UGl0aVNLYWprYTFIR2c4?=
 =?utf-8?B?eTdBY1lHcnZRYUhLdVU0YnJRZ2pPdUErVjBBZWZqc0E5WURPYXhMNzM4WFpF?=
 =?utf-8?B?aVVEQThud1J4SGVTaytpMGJlb09yZE5uNU9FSEh4ek93V05uT0hiZmRvNTUr?=
 =?utf-8?B?dTRCRzE2SGZWcHFwSStUYnNNb0IwVDJJRTZZOHIyN1FzSjlRK0hjMDV4K0w0?=
 =?utf-8?B?VVVCb0RuTHhja0JlK2tCbjJRSnpzVFRHaWhyNlNrMk5mbUMwSUY0bnJvcTlr?=
 =?utf-8?B?M2hBNzlqR3d3M3N3YzFIZUFzeXR3NUJPSTFtUFQ3ZjAwMXFBUks1NjZScU92?=
 =?utf-8?B?WWhZVUZ0cFJ0WUVJb2J4d05jbnQ1YUIzTXE0dHRFWHJMbE9KVG5xK2xNYXpQ?=
 =?utf-8?B?aFUxTVlRbE9tUGhGNXV2SnBhUDVvYzM0VnQxZExtbWxaNnIxWitwVjFtK09n?=
 =?utf-8?B?ck1xUEZWZ2FKcGZHaUZTRGJBV2xVZVNsYzZ5VGtkL3U3aVpidFN1KzNxc0k5?=
 =?utf-8?B?ZWx5YXRGa1BPRnhvVnhaTWZkOGtCYU5yR1d3WExtNmNJa2Q2MzhBMExLR2JO?=
 =?utf-8?B?SnZ3VHd4NXJCamE4L2xGRDJkV3NoZElYT0pCL3JCbnJBQ1ZFMVpnNmlzNys5?=
 =?utf-8?Q?5JYHKnDaBpScEITJEroH0FY=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 575a34ba-9f8c-4f01-11bf-08d9e7c01188
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Feb 2022 09:23:56.4752
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: e4YUwAmqX1JurWdnO/F6kfBzcy91QD/oX3+2Lih68/gWhkO9i9gvIVxEoR+jQYQ8XUl1gkC0ampfLfcEvelbTg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3406

On 30.11.2021 12:09, Jan Beulich wrote:
> I think it is b968e84b509d ("x86/iopl: Fake iopl(3) CLI/STI usage")
> which uncovered an issue with get_desc() trying to access the GDT, as
> introduced by 670f928ba09b ("x86/insn-eval: Add utility function to
> get segment descriptor"). When running in a PV domain under Xen, the
> (hypervisor's) GDT isn't accessible; with UMIP enabled by Xen even
> SGDT wouldn't work, as the kernel runs in ring 3.
> 
> There's currently no hypercall to retrieve a descriptor from the GDT.
> It is instead assumed that kernels know where their present GDT
> lives. Can the native_store_gdt() be replaced there, please?
> 
> For context (I don't think it should matter much here) I'm observing
> this with the kernel put underneath a rather old distro, where
> hwclock triggers this path.

I'd like to note that the issue still exists in 5.16.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Feb 04 09:24:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 09:24:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265244.458580 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFupE-0007RI-AA; Fri, 04 Feb 2022 09:24:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265244.458580; Fri, 04 Feb 2022 09:24:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFupE-0007RB-76; Fri, 04 Feb 2022 09:24:16 +0000
Received: by outflank-mailman (input) for mailman id 265244;
 Fri, 04 Feb 2022 09:24:15 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=wIUc=ST=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nFupD-0006TE-1B
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 09:24:15 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 37f79e56-859c-11ec-8eb8-a37418f5ba1a;
 Fri, 04 Feb 2022 10:24:14 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 211F0218F0;
 Fri,  4 Feb 2022 09:24:14 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id EAB4013322;
 Fri,  4 Feb 2022 09:24:13 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id oy3ON73w/GEMeQAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 04 Feb 2022 09:24:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 37f79e56-859c-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1643966654; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=8cDBknFJRIpxf5l9AdOZUIo0+FnYIcgRzSzamZqBACo=;
	b=gyCozaF0GvUFq5S0NlfbfbHKvuxPf62o/USaPhpLav/RBPVy4Nr0Bk1+fgGQgJBBV05yi9
	QZyhBkHtXcNpy0ehgel1ozmfdJra4Ag9a2khtpiKNnmGi1ma2A7SGfCSvLmalFvOQa+pct
	absX5Rsz6cck3tpMHMwWSp2M1NF/XxA=
Message-ID: <1af6c334-4c5c-66da-7fea-0dfd0339e665@suse.com>
Date: Fri, 4 Feb 2022 10:24:13 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Subject: Re: [PATCH v2] Improve docs for IOCTL_GNTDEV_MAP_GRANT_REF
Content-Language: en-US
To: Demi Marie Obenour <demiobenour@gmail.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
References: <f66c5a4e-2034-00b5-a635-6983bd999c07@gmail.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <f66c5a4e-2034-00b5-a635-6983bd999c07@gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------Eg4rG6ujboyviXGmG1PlN7iq"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------Eg4rG6ujboyviXGmG1PlN7iq
Content-Type: multipart/mixed; boundary="------------sgWeOpdNgNKChkm3psCKSe9q";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Demi Marie Obenour <demiobenour@gmail.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Message-ID: <1af6c334-4c5c-66da-7fea-0dfd0339e665@suse.com>
Subject: Re: [PATCH v2] Improve docs for IOCTL_GNTDEV_MAP_GRANT_REF
References: <f66c5a4e-2034-00b5-a635-6983bd999c07@gmail.com>
In-Reply-To: <f66c5a4e-2034-00b5-a635-6983bd999c07@gmail.com>

--------------sgWeOpdNgNKChkm3psCKSe9q
Content-Type: multipart/mixed; boundary="------------We0Qqb4jVkRXwDCuJewzkpGp"

--------------We0Qqb4jVkRXwDCuJewzkpGp
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMzEuMDEuMjIgMTg6MjMsIERlbWkgTWFyaWUgT2Jlbm91ciB3cm90ZToNCj4gVGhlIGN1
cnJlbnQgaW1wbGVtZW50YXRpb24gb2YgZ250ZGV2IGd1YXJhbnRlZXMgdGhhdCB0aGUgZmly
c3QgY2FsbCB0bw0KPiBJT0NUTF9HTlRERVZfTUFQX0dSQU5UX1JFRiB3aWxsIHNldCBAaW5k
ZXggdG8gMC4gIFRoaXMgaXMgcmVxdWlyZWQgdG8NCj4gdXNlIGdudGRldiBmb3IgV2F5bGFu
ZCwgd2hpY2ggaXMgYSBmdXR1cmUgZGVzaXJlIG9mIFF1YmVzIE9TLg0KPiBBZGRpdGlvbmFs
bHksIHJlcXVlc3RpbmcgemVybyBncmFudHMgcmVzdWx0cyBpbiBhbiBlcnJvciwgYnV0IHRo
aXMgd2FzDQo+IG5vdCBkb2N1bWVudGVkIGVpdGhlci4gIERvY3VtZW50IGJvdGggb2YgdGhl
c2UuDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBEZW1pIE1hcmllIE9iZW5vdXIgPGRlbWlvYmVu
b3VyQGdtYWlsLmNvbT4NCg0KUHVzaGVkIHRvIHhlbi90aXAuZ2l0IGZvci1saW51cy01LjE3
YQ0KDQoNCkp1ZXJnZW4NCg==
--------------We0Qqb4jVkRXwDCuJewzkpGp
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------We0Qqb4jVkRXwDCuJewzkpGp--

--------------sgWeOpdNgNKChkm3psCKSe9q--

--------------Eg4rG6ujboyviXGmG1PlN7iq
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmH88L0FAwAAAAAACgkQsN6d1ii/Ey/j
WQf/YxiHmXcPdXmmKLO9PoqWdFJfJJn4O4YaSkpUpk7v31m2RRyFhLTRjvlcqHoAj7z2OM1oYV6h
6khY2LgSF5OyioiowZU+47QNu354PbVPg2uJ2sRS2Av5836QiyNirH3Al7thSfLxtvtdReGE2xnJ
P9AaeiVxC4s8N/lKjFqIlnqh/vPXBiVanmWzuByQ4Z0F8F+u/KVUoy26C8I3twUWyze7IabD5MIO
NYMLENNFb3ByCgokQgoksiBuHDE3WBWxY4pLKO0J/V4t/MC6WElMzk4k2GSO6qfsoPrzormxytlW
hwvyvt5qWnWSFC0Iigka9n7N875aR+0PjtobEGve3A==
=yOqa
-----END PGP SIGNATURE-----

--------------Eg4rG6ujboyviXGmG1PlN7iq--


From xen-devel-bounces@lists.xenproject.org Fri Feb 04 09:24:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 09:24:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265256.458591 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFuph-0008Hr-Od; Fri, 04 Feb 2022 09:24:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265256.458591; Fri, 04 Feb 2022 09:24:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFuph-0008Hk-KB; Fri, 04 Feb 2022 09:24:45 +0000
Received: by outflank-mailman (input) for mailman id 265256;
 Fri, 04 Feb 2022 09:24:44 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=wIUc=ST=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nFupg-0006TE-4j
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 09:24:44 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 494da17e-859c-11ec-8eb8-a37418f5ba1a;
 Fri, 04 Feb 2022 10:24:43 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 3A8391F44E;
 Fri,  4 Feb 2022 09:24:43 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1A0BB13322;
 Fri,  4 Feb 2022 09:24:43 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id obCkBNvw/GE8eQAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 04 Feb 2022 09:24:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 494da17e-859c-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1643966683; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=DqdA+DBRa90BxqXlpLNlJ+Ze+BNHIBaKbH8YkKc6bwY=;
	b=mIoHGcrlxPMh8V8FNHV09dweAwlxMFd3Ztd9zaPXm0JLU3W+nO3jL15LM0dsHLp6uVAoZm
	bXzINg1hr53CmYZHX0tOHod1IlYg/2aNDXMrxXfbbtUEpYvnoiq7fze5it3vMuKWlREV2V
	8m9Y8L8r6MW+ca2QkuANLUDqpNFXaas=
Message-ID: <c522051d-41c9-cbe8-68bd-0d10b5bef2ab@suse.com>
Date: Fri, 4 Feb 2022 10:24:42 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Subject: Re: [PATCH] x86/Xen: streamline (and fix) PV CPU enumeration
Content-Language: en-US
To: Jan Beulich <jbeulich@suse.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <2dbd5f0a-9859-ca2d-085e-a02f7166c610@suse.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <2dbd5f0a-9859-ca2d-085e-a02f7166c610@suse.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------jy0qU0Z4HDMvLq5kabIuetKE"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------jy0qU0Z4HDMvLq5kabIuetKE
Content-Type: multipart/mixed; boundary="------------HKl3OGvg2lKkHce4tyNUhLKo";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <jbeulich@suse.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Message-ID: <c522051d-41c9-cbe8-68bd-0d10b5bef2ab@suse.com>
Subject: Re: [PATCH] x86/Xen: streamline (and fix) PV CPU enumeration
References: <2dbd5f0a-9859-ca2d-085e-a02f7166c610@suse.com>
In-Reply-To: <2dbd5f0a-9859-ca2d-085e-a02f7166c610@suse.com>

--------------HKl3OGvg2lKkHce4tyNUhLKo
Content-Type: multipart/mixed; boundary="------------xDKk03bowPY1c0pJSn9zYuQ6"

--------------xDKk03bowPY1c0pJSn9zYuQ6
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMDEuMDIuMjIgMTE6NTcsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBUaGlzIHN0YXJ0ZWQg
b3V0IHdpdGggbWUgbm90aWNpbmcgdGhhdCAiZG9tMF9tYXhfdmNwdXM9PE4+IiB3aXRoIDxO
Pg0KPiBsYXJnZXIgdGhhbiB0aGUgbnVtYmVyIG9mIHBoeXNpY2FsIENQVXMgcmVwb3J0ZWQg
dGhyb3VnaCBBQ1BJIHRhYmxlcw0KPiB3b3VsZCBub3QgYnJpbmcgdXAgdGhlICJleGNlc3Mi
IHZDUFUtcy4gQWRkcmVzc2luZyB0aGlzIGlzIHRoZSBwcmltYXJ5DQo+IHB1cnBvc2Ugb2Yg
dGhlIGNoYW5nZTsgQ1BVIG1hcHMgaGFuZGxpbmcgaXMgYmVpbmcgdGlkaWVkIG9ubHkgYXMg
ZmFyIGFzDQo+IGlzIG5lY2Vzc2FyeSBmb3IgdGhlIGNoYW5nZSBoZXJlICh3aXRoIHRoZSBl
ZmZlY3Qgb2YgYWxzbyBhdm9pZGluZyB0aGUNCj4gc2V0dGluZyB1cCBvZiB0b28gbXVjaCBw
ZXItQ1BVIGluZnJhc3RydWN0dXJlLCBpLmUuIGZvciBDUFVzIHdoaWNoIGNhbg0KPiBuZXZl
ciBjb21lIG9ubGluZSkuDQo+IA0KPiBOb3RpY2luZyB0aGF0IHhlbl9maWxsX3Bvc3NpYmxl
X21hcCgpIGlzIGNhbGxlZCB3YXkgdG9vIGVhcmx5LCB3aGVyZWFzDQo+IHhlbl9maWx0ZXJf
Y3B1X21hcHMoKSBpcyBjYWxsZWQgdG9vIGxhdGUgKGFmdGVyIHBlci1DUFUgYXJlYXMgd2Vy
ZQ0KPiBhbHJlYWR5IHNldCB1cCksIGFuZCBmdXJ0aGVyIG9ic2VydmluZyB0aGF0IGVhY2gg
b2YgdGhlIGZ1bmN0aW9ucyBzZXJ2ZXMNCj4gb25seSBvbmUgb2YgRG9tMCBvciBEb21VLCBp
dCBsb29rZWQgbGlrZSBpdCB3YXMgYmV0dGVyIHRvIHNpbXBsaWZ5IHRoaXMuDQo+IFVzZSB0
aGUgLmdldF9zbXBfY29uZmlnIGhvb2sgaW5zdGVhZCwgdW5pZm9ybWx5IGZvciBEb20wIGFu
ZCBEb21VLg0KPiB4ZW5fZmlsbF9wb3NzaWJsZV9tYXAoKSBjYW4gYmUgZHJvcHBlZCBhbHRv
Z2V0aGVyLCB3aGlsZQ0KPiB4ZW5fZmlsdGVyX2NwdV9tYXBzKCkgaXMgcmUtcHVycG9zZWQg
YnV0IG5vdCBvdGhlcndpc2UgY2hhbmdlZC4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IEphbiBC
ZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCg0KUHVzaGVkIHRvIHhlbi90aXAuZ2l0IGZv
ci1saW51cy01LjE3YQ0KDQoNCkp1ZXJnZW4NCg==
--------------xDKk03bowPY1c0pJSn9zYuQ6
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------xDKk03bowPY1c0pJSn9zYuQ6--

--------------HKl3OGvg2lKkHce4tyNUhLKo--

--------------jy0qU0Z4HDMvLq5kabIuetKE
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmH88NoFAwAAAAAACgkQsN6d1ii/Ey9F
4Af/UGUOzoHkvC9hE+u/irb3LpecWG83u9+plkvKcC2JQb7y2dvUG84ZMblndiLi4WbnmTXe3ydh
ZfEU+ONtakSq5fqgl7x4fVtNzHYGG7gDkfKhH4FVXi1iqHiQIkq4aWqHgTWC2x+hOzHy8bhPG76j
5uPUV5r+8PT+X43/FkBH+OR6/Z/65T0MvJF97VxUfO5MfV6pEWWYeEkgQe98erxIlvxiahqhMV1h
so756Fupl6npLANUROUzelTR6t/j05eROYVhLRLotbjghZuxAlyEpKle0QAQ2gn6i+0yaRDdWp0Q
goCf+Ijs7O7NkWM0ueUdKcbKuAB6QlRbd2ndNm4QaA==
=Chy+
-----END PGP SIGNATURE-----

--------------jy0qU0Z4HDMvLq5kabIuetKE--


From xen-devel-bounces@lists.xenproject.org Fri Feb 04 09:28:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 09:28:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265275.458602 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFutO-0000fm-7Z; Fri, 04 Feb 2022 09:28:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265275.458602; Fri, 04 Feb 2022 09:28:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFutO-0000ff-4S; Fri, 04 Feb 2022 09:28:34 +0000
Received: by outflank-mailman (input) for mailman id 265275;
 Fri, 04 Feb 2022 09:28:32 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=46ws=ST=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nFutM-0000fZ-Nh
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 09:28:32 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d013d4c3-859c-11ec-8eb8-a37418f5ba1a;
 Fri, 04 Feb 2022 10:28:31 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d013d4c3-859c-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1643966911;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=vDdyOYa9Qj225AnF27MFlYtyRvz7zGXvCLnLngp6hsE=;
  b=F3eKJ9vesURB6DYMlhcdJ4Tn7+9woaS0cuJZtqtz69QzMmI/zwYvSZBh
   Q9qpzjtPBroOtv3rNa9Y41O/IT5cc63VL5843MZoyR5zvv2agFU1D3iRE
   i7tQ2cpUVKd6PviJgC5H7Z3FusWbflxSBZFsIOqDrxSBS3qo41H5Qj/i+
   A=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: PAhuP5CsnwTIDnGTQTeSxpuNSgEfDDF8w5nQac6yFIQOFAePuVR9MsorENGjePTzDnipnhUQKs
 m063YrXle5Se+ENFjhsSrtKH0NdLIb0bFq4wesVzaNEmuFIzt1m8PpLeYDuqtiVKYkQlR20/8i
 O0hwjU/rM2MutPx0OwCEJQBNNU0tRm960xvfaSv5ZveKOYqOT/BPfW8uBwYvfseRHcpEXrFBEz
 BrXxERUkKP7UNuNw4jm30hpdIa7WNU6cGoe5QBU9h+bnzY7LxH5Ae4mlsFeYTKtelQRwDVnoor
 xFx2tdGkT8WcV4jCfibXXWJs
X-SBRS: 5.2
X-MesageID: 63487644
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Minqja8/jgEqHFrAGSqQDrUDZnmTJUtcMsCJ2f8bNWPcYEJGY0x3y
 jAcXmGOPKyCN2X1ftByPY6wpBgHuZOGzt5lTFFk/ik8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhFWeIdA970Ug5w7Rh3tYy6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPha2
 IUT66GJdj4mfYbtqfoBDyFBCDFXaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguw5K8bmJsUHs2xIxjDFF/c2B5vERs0m4PcGh2tg2Z4SQZ4yY
 eI9cQFlSDjOWycUP2pOArkHnuCFt0vGJmgwRFW9+vNsvjm7IBZK+KfpGMrYfJqNX8o9tlaVo
 CfK8nr0BjkeNceD0nyV/3S0nOjNkCjnHoUIG9WQ9PRnnVmSzWw7EwANWB2wpvzRt6Klc4sBc
 QpOoHNo9PVsshzwJjXgY/GmiFWU7kBCZuNvKuJ5wyC81LaI2x+CFkFRG1atd+canMMxQDUr0
 HqAkNXoGSFjvdWpdJ6NyluHhWjsYHZIdAfucQdBFFJYuIe7/OnfmzqSFo4LLUKjsjHi9dgcK
 RiupTN2ubgchNVjO06TrQGe2GLESnQko2cICuTrsoCNs1sRiG2NPdXABb3nARBodt3xor6p5
 yBspiRmxLpSZaxhbQTUKAn3IJmn5uyeLBrXikN1Ep8q+lyFoiD/JtALvW8jdRw2aa7onAMFh
 meJ4mu9A7cIZBOXgVJfOdrtW6zGM4C8fTgaahwkRoUXOcUgHON21CpveVSRzwjQfLsEyskC1
 WOgWZ/0Vx4yUP0/pBLvHrt1+eJ1mkgWmD2CLbimn0XP+efPPxa9FOZaWGZim8hktstoVi2Pr
 YYGXyZLoj0CONDDjt7/qt9OdA1acCRgWPgbaaV/L4a+H+avI0l4Y9f5yrI9YY112aNTk+bD5
 HamXUFEjlH4gBX6xc+iMxiPsZvjAsRyq2wVJyspMQr60nQve9/3vqwea4E2bf8s8+k6lax4S
 PwMesOhBPVTS2uYp2RBPMel9IEyJg62gQ+uPja+ZGRtdZBXWAGUqMTveRHi9XdSA3Pv59c+u
 bCpyijSXYEHG1Z5FM/TZf/2lwGxsHERlfhcRUzNJtUPKkzg/JIzc376j+MtItFKIhLGn2PI2
 wGTCBYehO/Mv45qr4WZ2fHa99+kSrIsEFBbEm/X6aeNGRPbpmfzk5VdVOuofCzGUD+m8quVe
 ugIner3N+cKnQgWvtMkQapr1683+/Dmu6ReklZ/BHzOYlmmVuFgL32B0ZUdv6FB3OYE6w6/W
 0bJ8dhGI7SZfsjiFQdJdgYia+2C09ASmyXTsqtpcBmruncv8erVS1hWMjmNlDdZfel8P44Sy
 Os8vNIbtl6kgR0wP9fa1i1Z+gxg9JDbv3nLYn3CPLLWtw==
IronPort-HdrOrdr: A9a23:2YGIB6pX5/tatIy7f9LQZWAaV5oXeYIsimQD101hICG9Ffbo8/
 xG/c5rsCMc5wxhO03I9ergBEDiex3hHPxOkO4s1N6ZNWGN1VdARLsSi7cKqAeQeREWmNQ86U
 5ISdkGNDWuZmIQsS+B2maF+nwbsaG6GduT6dvj8w==
X-IronPort-AV: E=Sophos;i="5.88,342,1635220800"; 
   d="scan'208";a="63487644"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=g0B3UTgynD6bfrH+9ilAUJyEUm5AvAE6qVAsCS7/brcPraIjzIyPb3fnpncI/xjcE5z0M4cabh5DNv76jb7VNCfwW1otntm3kQ6nzwk9Wm1yAKifX+KAFZjbZRuDEP03Eq1m0GtlSBOrDWtuYB3qM1RZk3qCsw3ZN5gY0J1bRXOvkEhKF+65ZCU1iyxeC2lKPwKqv3MEdDqxlekuJZZQFLrI3oEvBhRXye8mmXhdcOcyAS5st/n7DD4aLfwtMfImXtczOzOKgsCeAkIAUvFl7oEiTPNcU5dI5fusj0LSdlyYMjimf9FYz7qsYdZFzrY+CYHjN7zvZ9qr7XvPjun7Bg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=gt4df4tSvvF/CDg5OmvKefIUNSyCVVQSGpX8Y+Tig94=;
 b=n1mB9eS9Y9LueLGixEk0auu22OnRykVbdNx7c5Hy0zFizCz538H/T7K0FDhozdJdK49LahnkD+2C5s9BprSyRNdA10CJK7HmmbkeNh6ovsTtzXO+vWOrZ5R2m6D0mMHZbEjj9sxeDfwzUDFshz/tBZkqbr7iu3ed9sSsH3+/m1qtLnnerOgNvSaXKjmSSSZ329JqSanSLJepfyNGD80JXFVns+COeWUp8GrjjS7cxoJSTtC2+nQDU+shgL6s5D9ealHTAMHAlckHnBhhYS86tmdeRnwX/O+OZpSmhVxPQPaOJzb4X3mB9Jzh2cuRI9xcWEbWzrydZ4eGMHWZp7GISQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=gt4df4tSvvF/CDg5OmvKefIUNSyCVVQSGpX8Y+Tig94=;
 b=BHqREh1ggXnAkc3hMqJz1xl6Bl9u8YswroW6FjtMnttQ0v00tOnB48RHnAOCfdqfdz4XOo7zPFx44o1yGn2Ei+JSMwgAjHtQKWIOJrFdPUd6Y84mMT8cdeHraVOjf73F5Ni1CoiTdS49r5Yuz0eH2b/6RfKN9hFox+vDW7++f9A=
Date: Fri, 4 Feb 2022 10:28:16 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>, George Dunlap
	<george.dunlap@citrix.com>
Subject: Re: [PATCH v3 2/2] x86/mm: tidy XENMEM_{get,set}_pod_target handling
Message-ID: <YfzxsLefGoTD5bvN@Air-de-Roger>
References: <6fe7b036-2bdb-b391-4e6c-1b5d7e05a119@suse.com>
 <8cba4cd0-d218-da1b-dcea-4cc3047c0946@suse.com>
 <Yfqf5jiO0cHjR6gR@Air-de-Roger>
 <4a325d1e-85e0-09ea-e2ab-f0aae123d4c9@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <4a325d1e-85e0-09ea-e2ab-f0aae123d4c9@suse.com>
X-ClientProxiedBy: LO4P123CA0520.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:272::16) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 8359d7db-7b11-4b7e-24e0-08d9e7c0af26
X-MS-TrafficTypeDiagnostic: MWHPR03MB2959:EE_
X-Microsoft-Antispam-PRVS: <MWHPR03MB2959C4886F1DDE9E3F3F46488F299@MWHPR03MB2959.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:174;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: lw65PfiofQX/DgxKpPFar5Uzfb2SC2ApXrhYQlmJ7Qugf7kDwDMK7fEZQ/hQoNviC4GHHEPGGsHVqPj/BXZ3HcKhe4O5ShN1n2w2MjJ0DqyMUjQeJpHk1tE9vOPACc1T/ALIBk7rkpAdPruflkHuiBWF2ulLM4+o4TKDanEw4duGpk1w2t80LjBAF17U5uRDjdffTi7ymE5GUEn/2JxMrdKhma8+zRDBLdjptJuViijvTBbm7DT3OreAFYe+dK+l3ruYNS6jh1yDNPKXlNHqYAnqtzfB0Gs1yoIYqMgegKQJ5+6o9yrN0Z0PRD/06lAFeNV7nWQVuMBtsJ6y1pmFGk3S+9b15RIj1U/ds/LJtm94qRRy007XPACMkibu4q4Y8srYq5WXTkKH+gtGVkLEOoEw8zwsSggom0X7e25VxLhHGtBNi8Ip24/pVdaiTkack9y7Sju5d7NoCOsmDh9RAQk9Qr3cInS54oD+ASq27nAcBvitxunojICAGM9a9sPvOWYiMW6J+/r+TpA9BjvYeKVCCUvz1G8DspyHP4hVNU8Ruu0tx75IISpfYngrpEW0Iy2HPS/rRhXd34RHXjTznVhIY8OTEAun/X2dhgCVXPC9EPI8tK3TUpw2o1xs4nX/ALgffYRPHosmBdVSp52Fbw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(2906002)(8676002)(8936002)(66476007)(66556008)(4326008)(83380400001)(6512007)(5660300002)(107886003)(4744005)(66946007)(26005)(186003)(9686003)(85182001)(6506007)(53546011)(6666004)(33716001)(86362001)(316002)(6916009)(6486002)(508600001)(38100700002)(82960400001)(54906003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TzEyQmFXaG4xWUpxcGJZTDhUWlVPQkFPRkpDSThobjM4Y0R2eFRWd1ZpZ0VZ?=
 =?utf-8?B?MjNQa3dBV2N4NTQwdkd0bUxjODh2VU5XMVBJOHRUVjFKWmJpVlZZbjlTanRD?=
 =?utf-8?B?bWt5L2N4YmNHUFhrOGZjcXFUR1RCNWw1MXlEbFJudHBoaEpIWTUxaXZKK3Jt?=
 =?utf-8?B?eVVndENlUDVmaXBpcWhGek5zTWpNWlgrMUhnczY1VjNSZWVzaEdLMXJ3M3Ro?=
 =?utf-8?B?T2ovVVdyQ1JPRFRyNDJqcE91Q1d2R3JvYndJRUswUnBBS0REcmg0akJEMlF4?=
 =?utf-8?B?ZzI3QlFxVVBFby83alJjcytkc2ZkVFpMbjVSc2U2elk3Zk5kT1hKejJ6Q2NL?=
 =?utf-8?B?N21TS3lpOXFObEtGNHZBQUxkeGFaTFMzT3FyS0RreHdZSUs0K1VJY0t5azcw?=
 =?utf-8?B?cm93YVVzMGpNa09wUlRrUnovalJQbHNKQ3VhQ2hUU2FaN2Q5ZSt6QUFIUXB4?=
 =?utf-8?B?bjBmTWl3bkxFa1NLSzBFU0wxZnFrak9kek5NM2lVTDBqVFA1YzRmcC91RTZJ?=
 =?utf-8?B?TXpoWmYvUWt6b3hBTTF1NUg2VC9FTlFGNUljUjRHc3I1V1F2dllzVHczb3B6?=
 =?utf-8?B?eEZXdjBjVGxxL2JrYkZKMnlvdlFyeFNGYTBYOWFJS3p1emw4R1kySFBla2lU?=
 =?utf-8?B?S3VJSzJ0SVFncVEySWxhdG5ySzNwTlNPZzV0bHg2WE1Qb292V2tsU1ZsNWw3?=
 =?utf-8?B?bEtDeXZCaWdkUXVPUlpzMkthTzVtMU94SW5JUjhzWWZ4aFpsSlEyekxKenVB?=
 =?utf-8?B?R2YvbjBTU201SkdhdXdRQ3BBV3d3V3FvYXpadGpZWE5WZ1A2ZmhNdWVBcmdJ?=
 =?utf-8?B?akdMYlJtUnU0b0luZUlGUXdiMTVSTHFyWkViaHBRUytSbEtDd0hxdko5R2Mx?=
 =?utf-8?B?V1ZGcnUxeTduQjhkNXQzMFRMbE5wQWQyTnR5MDk5YmNQR2RFcHNTZWJTNnpP?=
 =?utf-8?B?T0haKy9KT1pPMGNraUVFZ2xrRUZEQU1OVHZMdm4xdExGOXh5dW9IMFRhUVda?=
 =?utf-8?B?M3Fpak9MT3NDaTlwTmRXMCtyNWF1WHBiSUhMN2hrR2k3ZjRPTjFocmdRL1JG?=
 =?utf-8?B?TFphY0l4WkluK1l4S1FuVXVDVk5sRmxRb1NwQVJIZ1JkRXRqWWY4QnhHN2lp?=
 =?utf-8?B?TGlRWHFPbnRIV0IxT2ZvdjRNdi9mVGIzU2pmRXVFamwxS3BTaGcvZnI1SVFj?=
 =?utf-8?B?ZnFHTzk2N2ZvaTI2WEl3dk1KakREL1lOQ0NLU3c0VTNUNitWaDZDNzhMTTJ6?=
 =?utf-8?B?SXFxVFM3RndTaE05dzJMTmZ0QjNVc1VZWHo1bGQxRnU3UTdWNGhPYVBFdkc4?=
 =?utf-8?B?bVJYR3BKeUUrcHIyWDArTENyS0VMYmV0UnZPRWVaTmszZEZFTkJ6Y1RBcllI?=
 =?utf-8?B?enJsSzBKdTNqTzQ5aDFpU3RLQ1JsQ3lsbjBxd1JtQkJvMEpEMG9yaDVacG9W?=
 =?utf-8?B?cmU2ZjBUNjZrZEFpVmE3ZWZLZGNrdE44Y0pDb212SXI5VUlCV24zeUcxZmNr?=
 =?utf-8?B?UWVCMmdBbTBUSTNRMERKZjhwNFJsa3ZEYXdxazhHS0hxVEtCQjhZRDRydkMy?=
 =?utf-8?B?dnZDQXR6bEc1bXpYY25QUUxJN0hBc1FUQ3ppMXVFWWtLbzVKeHdRQUs0Nzlm?=
 =?utf-8?B?VDBwb2t4NlpJL2RGNStGR2pSaGxseGlBMW9VbUE3a2o5R05wMCsrZkFxZjN1?=
 =?utf-8?B?aUY5Zkg1Z2doV2JUbkhsNTYxSGtzQkNFTEh4a01DcVJydE1TZ0ltNVEvaFFp?=
 =?utf-8?B?U25YYUk3dVkzaUtMKzN4NFFKTnZJc0NvWElkSUpZOXV1M21BZEllaTJQbmFk?=
 =?utf-8?B?bzZTMjQweG1HcGZXQXB0VGZ6TlhyYk1KMEtCUThzS3RLaDJvUUx6dStQTGVx?=
 =?utf-8?B?SnBtT3IrbXBCdU1rcXBTdFRiZVhBNDJEdXp0aTB4RUhMTUp0V2YzRTBmSmwy?=
 =?utf-8?B?R1I4c2lubk4xeXRNbHJMU3YxWWM3czRldVlVRG5OOUwwWXNJNWJxd3Y3dGJQ?=
 =?utf-8?B?U1lHdzBUS0VEREJYR09lbWVKUVRCY1BFV1dpV2JFd1k5TW5RTjQvT2V1OXEv?=
 =?utf-8?B?MjVUTWFGeVV1MDZsZndYZnpxeFB4QTE4ZWJldFlEbWJGallYaUQ2SEZGTWRF?=
 =?utf-8?B?dklLT3FjRUVpb1ZWbWxvSkNnRFJqeld5YU1JQWxvenhycXlnTHNUR2xOa2tn?=
 =?utf-8?Q?lI1NdyREhRT8I9EwYj9//Cg=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8359d7db-7b11-4b7e-24e0-08d9e7c0af26
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Feb 2022 09:28:20.9305
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: O8abru+B1Roskd7ugPrfM3UfE1t86Xy9RCiBHcVhVcKb1qgy1csR2txImy7a49qLnj2+TzinEONnp+OYGrm2PA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2959
X-OriginatorOrg: citrix.com

On Wed, Feb 02, 2022 at 04:29:37PM +0100, Jan Beulich wrote:
> On 02.02.2022 16:14, Roger Pau Monné wrote:
> > On Tue, Jan 04, 2022 at 10:41:53AM +0100, Jan Beulich wrote:
> >> Do away with the "pod_target_out_unlock" label. In particular by folding
> >> if()-s, the logic can be expressed with less code (and no goto-s) this
> >> way.
> >>
> >> Limit scope of "p2m", constifying it at the same time.
> > 
> > Is this stale? I cannot find any reference to a p2m variable in the
> > chunks below.
> 
> Indeed it is, leftover from rebasing over the introduction of
> p2m_pod_get_mem_target() in what is now patch 1. Dropped.

I'm happy with this change with the commit adjusted:

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

Not sure if you can commit this now regardless of patch 1?

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Feb 04 09:31:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 09:31:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265282.458613 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFuvl-00021k-MW; Fri, 04 Feb 2022 09:31:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265282.458613; Fri, 04 Feb 2022 09:31:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFuvl-00021d-Hu; Fri, 04 Feb 2022 09:31:01 +0000
Received: by outflank-mailman (input) for mailman id 265282;
 Fri, 04 Feb 2022 09:31:01 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1gJ0=ST=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nFuvk-00021W-Ut
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 09:31:00 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 29822008-859d-11ec-8eb8-a37418f5ba1a;
 Fri, 04 Feb 2022 10:30:59 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2054.outbound.protection.outlook.com [104.47.14.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-3-HPTJxufcMieHaILKS5MCdg-1; Fri, 04 Feb 2022 10:30:58 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM6PR04MB6599.eurprd04.prod.outlook.com (2603:10a6:20b:fd::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Fri, 4 Feb
 2022 09:30:57 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.014; Fri, 4 Feb 2022
 09:30:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 29822008-859d-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1643967059;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=0Khn6hnq2Hol+n38MHbxQhdXOt2gteuWM+u+3PdxRfg=;
	b=FmytVPgRpEZ7LxswW2HmozsI0rFKhQxJdRJ5lWxxvrqf1d/b+K3XwwxbtyLVdJGrC90x96
	wVj1AOo5G+sDrnLcxw20eHqQZVuXVIHsaE5S2TYblqUICeaaQ+HWQFYRFW/5IV5/j2Ngpk
	zZYMG/gtG/jGIIsbEUyYmyOqzMpiEao=
X-MC-Unique: HPTJxufcMieHaILKS5MCdg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=aY4moSW6kHoJqNFfYtAZUTZLCyqtxqVLUPVde6w/kpOct7S2M4wl8YlhT9Q3kbjlUcwQKbQZ57Rdz8DU6sbQMz5KMEmwB1V7JH5ppjw3sQTZqajKMy0PgQtYuE7iZSDWb87UI1C5oUp1YM/5zYZzacwoD3anRPw7EY8Eu7F8FhpABt9wB3K4UougJZ0OpxrCIf5lolG3U3f38yiDXcbclXyuYjTLfDVNC0sKe4AVcWXr6YPIt7LmaZJJsdjw8ZNe9mBaDYhK1u7dVcachLz4txW/rdAy/trVyMgB23VTK202bsldiN3WTThvO8RzOYtUBE8+E9uHzhaEiaO3I0w0qQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=lC1+Etl5uloA3kYhRGGmhTdw4b62+/IvKRf+q3AOnyc=;
 b=ehvqS0yeuPNuT34yyB3Wo76xCcHZ3Is9DUonJKCFFfxC2h0YhyOYEki4jbD0UgH6jh0QFkRGIscP1LIdmaWVk2KTYOx9MnljEogOpoyn1eUoQC7YA4cuyLt/I9rTo6KnjCCCcMVGP1NAFgVX7Ol1zsrhhAV5rKTHi+Dq4ISKghfmj/1fHjFS1u7aMjyp78/6E1ZXx5VaKnuT2eDCt1+YC84ipnDZEErK7xdfasGHKuVf+bNLkSzQRKyFT8yoowf7oXQHj9HHQtbMZkP5A0/8p/dZKOY64HkR/Arp0dWn3XUg6M7pugJ47W8EhvpTsrQwV+zpVlofESgUUwE55XcpzQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <d4ff7ca4-e728-5f5a-e569-ae42fdf17157@suse.com>
Date: Fri, 4 Feb 2022 10:30:54 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH 2/3] x86/vmsi: add support for extended destination ID in
 address field
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Paul Durrant <paul@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220120152319.7448-1-roger.pau@citrix.com>
 <20220120152319.7448-3-roger.pau@citrix.com>
 <2e96bf2e-a31e-da9b-2f08-adfa0928e5b9@suse.com>
 <YfzwepCoIvJ3cI0v@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YfzwepCoIvJ3cI0v@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM5PR0701CA0003.eurprd07.prod.outlook.com
 (2603:10a6:203:51::13) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d711acef-9d9b-4e00-e496-08d9e7c10c43
X-MS-TrafficTypeDiagnostic: AM6PR04MB6599:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB6599AAFFBA49969DB59BAE99B3299@AM6PR04MB6599.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	KzbdMprPKr9JCmwXHCOECi10SPF6Yo0Ac22plEh7qSw3aeJkRQNB6rYgDsFxE3i4OTShwU2didSyxYaVcFQklgbWIoevzrVUBBsgBhTCcMqMM1TsrZ3RQ2un60Kxk+Of0FKLWa5HJFTe6VgDKgjujioAc8ljFxWHvYcNIEogrRzqzZqcS692aPQpyLSOWa6O9MmCoGPuxjSBwV7zk8pT7FGIOdkRS722xePaRTSb5hS7cc7KmqYxqUl3TQdiyhTzl7dYCE3wUjfRZSH5HnglDY3shjyt3I0LJPoxe5X5VYgzE2nXpQd24eAy2fWQ+23FNsZL7CPYtZXmsmgk9zc+0CDpRBv/fhtlSugaIS75yPQD61xigjZMxcd03uX+IC5i8UEs5T5B2diPOOg63LBDI6SoPq0D0gXOgT+jh8Oq+LuVUhyChkHJEIPRKlW0NudTiEkWqzZXyox8WknrlQtqiZ4QOaXZIcluKhsMA/Qoiqioa/MibWrTPG7CR92bfggr+1VWuGS7aUQ6/B6oLNpUrXJEAr6yD2O+anvjLAG9CqGLZiGuxTlfcY8bYBPELOh8vqFHBoX/XD2I2DxKFFMUIKF7AMvvEKpy5UUpnRkJc+dCJD8qGJg73DWna0C4FocDScSrbwCa6t74xWKbM4T0COVX4AEymU9TEMk/e7NLkN1jrQR3mjKOfPzQOrJAalIxxR838jrGhrP53vgZeccPDkv86v4OBQ5632sgW6cMQl0=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6916009)(6506007)(31696002)(36756003)(86362001)(31686004)(53546011)(6512007)(6666004)(8936002)(66556008)(316002)(2616005)(2906002)(186003)(26005)(38100700002)(83380400001)(4326008)(8676002)(5660300002)(54906003)(6486002)(66946007)(66476007)(508600001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?UGWAK/wwM//V6uem7l6mnkebBP6QKOMEw4xwVxnSDUH6PKINcxqav0/8yYol?=
 =?us-ascii?Q?ZMpNQIHhV0oIsDLriy+YPxCHYwXRFCbaMiSZni1w1r8Lk+5zgQoK8HOYIH1N?=
 =?us-ascii?Q?xMqMCyU/nIZWPPhWi4SKBazV+mJo+C/AGa+Vy4hGKY7a7JliMNrlwwVT5UZd?=
 =?us-ascii?Q?jlJnIja1dn4vJ6+hX2hAqyuTv5u3/z2f3G/p5MNB+NUFbx5nVBztV0PSMHaG?=
 =?us-ascii?Q?gWjYjK4UkUUfMklkSMU2G6oo7ifD+hy4fXlZ24FkSkLTtEimwFl6la1qL7sB?=
 =?us-ascii?Q?xvi58/yi+fCxzAR46ha3bk17G5I4p+kXbEQIOQlEfjC3pCyfpXO/EqJCTl2A?=
 =?us-ascii?Q?bOuWzuqC2eCqtovcCqzD8VMRQvRuqWc1AU1FtZJO5HvIDWNUHu9k05eqVASW?=
 =?us-ascii?Q?oZpxQexr0fpcMQPesr+C+tyqgmUAJvTpPnQ6QV/4kCwjxoW0AfFfMMMCTXZz?=
 =?us-ascii?Q?bH3nS4VUZSglsHbUuTacfQMxc7sJasge+uF4DPKaU38euXAIkJ05joaKCRdi?=
 =?us-ascii?Q?XsWthmxx4DzICu+zbd8LWYzb1C1JwMGXZq55jKMsIzUDUI0wbWL4yvyncbge?=
 =?us-ascii?Q?dclniwp59NPKBF4uocDSQv1QTMD27dFoooPqlFlEz5PXyBNaylbHttw0R1tV?=
 =?us-ascii?Q?3LSeoDU+qgOsAb2AJaxvbvtwlcSnYu62vSRZjJMWvjuO81eT688iPHUBFMsv?=
 =?us-ascii?Q?G2OVlBZ/haE8E0edJHSuP+G0L0AUjMOWTeiZ0v98d60tEQmpRxusFlOTPsL1?=
 =?us-ascii?Q?L4MnJRtx1369uzl6wylrAA184BHRZ6cMvcv3N9XBpbsyvNzXRk/ftw0XRu1t?=
 =?us-ascii?Q?LLafauzOZ4H0+IN7XEaK0KYRD4poIv7wd8XHVhD4CwSl2dWPNY2SSBcULQ1/?=
 =?us-ascii?Q?g3UR9wZz2jwkZYPgNTpEGEJz4bdarQrMsN38KU5WJREninpYQ9Zf8SkRWMYC?=
 =?us-ascii?Q?zy8/6G+Kb0brc8ngW7u1U8XHReSJiO8ZWkfEkk5TRE9RhqHt3Kc68KhSaV4r?=
 =?us-ascii?Q?imAwAqKUmrJYTWG9A//3L+TdHWhJR/ro0hAixfMZX0i6QnDWJ420UFuBMj4F?=
 =?us-ascii?Q?RshI+N1z4Yi9NEVOdsXfqgT5QplVcCCIVZ0kUUKgo/UeWBAd8rlTKsI/lHmD?=
 =?us-ascii?Q?1PqcSwr8h/+CThMomKlYJlsCSWydALqL1WI23LgKaSaCyZ0II+0pRObwVcY4?=
 =?us-ascii?Q?KQRKjpFGyo6pUtCRKeNgQ3c4OU5f/J+KXiQYlxmB3uMPwOO9m+S+OrJ4Nu/X?=
 =?us-ascii?Q?hzjLFxzy8ndVo8+MQF7FDkPVdZh/mEFT++hOfBMCzKPwc86036wxsTJLzQr4?=
 =?us-ascii?Q?5qXs/w9x3OPNQmKjXb3D7+49wzG9uQ3kii2UqxZSZTy975XMSP0q0pKN92nr?=
 =?us-ascii?Q?kNU44BiuTUEVXPGfXkn3e+o/UDDmknj5WNNO88hW9aYUcELt2N3P3enxdoEJ?=
 =?us-ascii?Q?BvLDfnWSZbYTLowmoofusBrZAwa36y4QNWhnkburEY/jRL0qz4+b4EVet1Nw?=
 =?us-ascii?Q?3yG3Ua46qTf4MPnfwWsCO3WwOV4jvxRJvq2OlM41S8dEIBorxoK5VZKPkAJ6?=
 =?us-ascii?Q?59LvGub4190XbcotdfKlNimnfdKYcww9U7LRbGdhnhPj+6pVJn4H9dpdxGGR?=
 =?us-ascii?Q?fJj47AmwuTSfKhahCqHv7RA=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d711acef-9d9b-4e00-e496-08d9e7c10c43
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Feb 2022 09:30:57.1209
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: J9cBB8FVHH2mD4wWG2q08Li/iwA4SmKCCWB1kE2xyXIfhRmxI3Aqvf0aWSOXi/TkYXG64Ad7EKmXwqyTyiTcAA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB6599

On 04.02.2022 10:23, Roger Pau Monn=C3=A9 wrote:
> On Mon, Jan 24, 2022 at 02:47:58PM +0100, Jan Beulich wrote:
>> On 20.01.2022 16:23, Roger Pau Monne wrote:
>>> --- a/xen/arch/x86/include/asm/msi.h
>>> +++ b/xen/arch/x86/include/asm/msi.h
>>> @@ -54,6 +54,7 @@
>>>  #define MSI_ADDR_DEST_ID_SHIFT		12
>>>  #define	 MSI_ADDR_DEST_ID_MASK		0x00ff000
>>>  #define  MSI_ADDR_DEST_ID(dest)		(((dest) << MSI_ADDR_DEST_ID_SHIFT) &=
 MSI_ADDR_DEST_ID_MASK)
>>> +#define	 MSI_ADDR_EXT_DEST_ID_MASK	0x0000fe0
>>
>> Especially the immediately preceding macro now becomes kind of stale.
>=20
> Hm, I'm not so sure about that. We could expand the macro to place the
> high bits in dest at bits 11:4 of the resulting address. However that
> macro (MSI_ADDR_DEST_ID) is only used by Xen to compose its own
> messages, so until we add support for the hypervisor itself to use the
> extended destination ID mode there's not much point in modifying the
> macro IMO.

Well, this is all unhelpful considering the different form of extended
ID in Intel's doc. At least by way of a comment things need clarifying
and potential pitfalls need pointing out imo.

>>> --- a/xen/include/public/domctl.h
>>> +++ b/xen/include/public/domctl.h
>>> @@ -588,6 +588,7 @@ struct xen_domctl_bind_pt_irq {
>>>  #define XEN_DOMCTL_VMSI_X86_DELIV_MASK   0x007000
>>>  #define XEN_DOMCTL_VMSI_X86_TRIG_MASK    0x008000
>>>  #define XEN_DOMCTL_VMSI_X86_UNMASKED     0x010000
>>> +#define XEN_DOMCTL_VMSI_X86_EXT_DEST_ID_MASK 0xfe0000
>>
>> I'm not convinced it is a good idea to limit the overall destination
>> ID width to 15 bits here - at the interface level we could as well
>> permit more bits right away; the implementation would reject too high
>> a value, of course. Not only with this I further wonder whether the
>> field shouldn't be unsplit while extending it. You won't get away
>> without bumping XEN_DOMCTL_INTERFACE_VERSION anyway (unless it was
>> bumped already for 4.17) since afaics the unused bits of this field
>> previously weren't checked for being zero. We could easily have 8
>> bits vector, 16 bits flags, and 32 bits destination ID in the struct.
>> And there would then still be 8 unused bits (which from now on we
>> ought to check for being zero).
>=20
> So I've made gflags a 64bit field, used the high 32bits for the
> destination ID, and the low ones for flags. I've left gvec as a
> separate field in the struct, as I don't want to require a
> modification to QEMU, just a rebuild against the updated headers will
> be enough.

Hmm, wait - if qemu uses this without going through a suitable
abstraction in at least libxc, then we cannot _ever_ change this
interface: If a rebuild was required, old qemu binaries would
stop working with newer Xen. If such a dependency indeed exists,
we'll need a prominent warning comment in the public header.

Jan

> I've been wondering about this interface though
> (xen_domctl_bind_pt_irq), and it would seem better to just pass the
> raw MSI address and data fields from the guest and let Xen do the
> decoding. This however is not trivial to do as we would need to keep
> the previous interface anyway as it's used by QEMU. Maybe we could
> have some kind of union between a pair of address and data fields and
> a gflags one that would match the native layout, but as said not
> trivial (and would require using anonymous unions which I'm not sure
> are accepted even for domctls in the public headers).
>=20
> Thanks, Roger.
>=20



From xen-devel-bounces@lists.xenproject.org Fri Feb 04 09:36:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 09:36:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265292.458624 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFv1E-0002kX-EA; Fri, 04 Feb 2022 09:36:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265292.458624; Fri, 04 Feb 2022 09:36:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFv1E-0002kQ-Ay; Fri, 04 Feb 2022 09:36:40 +0000
Received: by outflank-mailman (input) for mailman id 265292;
 Fri, 04 Feb 2022 09:36:38 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1gJ0=ST=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nFv1C-0002k4-Pa
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 09:36:38 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f2e29f68-859d-11ec-8eb8-a37418f5ba1a;
 Fri, 04 Feb 2022 10:36:37 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2173.outbound.protection.outlook.com [104.47.17.173]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-29-TVWdnPrYO0SprBAY23uYVA-1; Fri, 04 Feb 2022 10:36:36 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM6PR04MB6086.eurprd04.prod.outlook.com (2603:10a6:20b:b8::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.16; Fri, 4 Feb
 2022 09:36:35 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.014; Fri, 4 Feb 2022
 09:36:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f2e29f68-859d-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1643967397;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=ZmuTAhhq6iJjyFHiqbf6kWQ/PYd0FMLJgXKe7242Q0g=;
	b=KXE2LVp/h2tZPzcMVwOWI29SlCevrnxYpq9/gAyfmWJX4GzLtipOh+qkbvbJNthOSvHcyx
	sUekPnwq9fPml50R8vSMGyWa8W8O4/VXf7uywD9jc3GzFzpziIpVNPfnTt0Pj9eRI4/d31
	QBqATaZ0pisVCIgdjimAymP/qOP7nqc=
X-MC-Unique: TVWdnPrYO0SprBAY23uYVA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=MaCqQ9Bab8tiBbx1pjq9kQkBOnUs+y1P72hXL9Ngj/2Y1bFSEu/CHwHSE6azItUcpm3/g9hf9B1BJc2+crEaMnOXQN0jdVF1a4WiNZi42rZ6mVpS7Si5gASbZxNDdt8TdrBk5GK+8kr3Ax6hckGgxfcOaEZuTVGsGucZYIZzvta5eZU3CyOYSe+gbUVwITwFIV8UsMWfYyC4YwWbxMQ6TCPkrwFaqQlaf0dC0aCQmgq//ABIAN4LwZVWX/Jp+uypluimQAXyoTXFueLb7grN0YU5+Pr/yT46QomyXkneIP/zHkXvhmRGl/LHpsyXaaQ7dO0bWrLxpwVRHsATroiujw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=FSRIHbcLpCujUBzdmAjhOBMcVTvBUzvxjySGwyZ0sRU=;
 b=ZFgP4RhCV0EUR4bls1+izCg6OUKH868Bgf1oVegwkJ8zBK+UsyKfiC27jkWUK5rzP14cW4OCgrV+pxMhCHJmjmt0s19ooQcOdR5umwV9UwmEumc6zKfvMJuuQvdKy+1t4Qc+M7niMNOMskOaYnXaPP6sE0FOBEKEeolwYYHvzCDJYpAb6NxmeoC9a4fgcPGmnM6z0SLa91fLWlzr/skevOXiqK4PFQY2jTf7aP+U75HccqfvNQN/ubbbjAflKKJu5OXBA3+8M9nqnfVgU9lqyeG4affL5CMI2GsyxnNgR6lFUENH0f2jS2Le+lt6htPnlGwgOu8kNaljOtp+gtVwGw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <4a6560ef-00b6-15ad-ef9f-3fdd2edd9edb@suse.com>
Date: Fri, 4 Feb 2022 10:36:33 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v3 2/2] x86/mm: tidy XENMEM_{get,set}_pod_target handling
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 George Dunlap <george.dunlap@citrix.com>
References: <6fe7b036-2bdb-b391-4e6c-1b5d7e05a119@suse.com>
 <8cba4cd0-d218-da1b-dcea-4cc3047c0946@suse.com>
 <Yfqf5jiO0cHjR6gR@Air-de-Roger>
 <4a325d1e-85e0-09ea-e2ab-f0aae123d4c9@suse.com>
 <YfzxsLefGoTD5bvN@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YfzxsLefGoTD5bvN@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6PR02CA0034.eurprd02.prod.outlook.com
 (2603:10a6:20b:6e::47) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2cd2ce82-1381-4d04-165f-08d9e7c1d5a9
X-MS-TrafficTypeDiagnostic: AM6PR04MB6086:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB6086CE20A1957BFA8F157341B3299@AM6PR04MB6086.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:227;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	4iNXvgKZJAkjACoY1lqDnQdcLsSmlz6aEqRdamCBGRv0sh7RtsgAz02UofwjV64L1rVf5PEEMvh3M8HGLf5NfYyT0sQcFMCjE0Gh4EejAT6OZFq0n0W21zOQYcTSj8bddP402sxSmQN6R4IM6J46h+eVN01ENzYs4KlZAkEYwOQVvYuc8F9c0AuS4El8QRY2WvSaGzsvkVk68s302xAKlhVf3TeOHx3Xd3k2/G4P7Mkqp7ve1bzxEbxA5aZgml80wcfTLlvZzEAP4jPPCEEE6UFTwTPjsVp3tyBvlhgKjz1qFGnRh555DOQvXP2oGZkjcIKF3bRmBbIXq76sIuwpshOGHuQoGdhb0T8TernuxCoKq+JukqJdS0GsD+RmbwoxzLhgkWULVLxnOZ7wpifchQVFKH+AIQTlgtDsDA4z6hT9G9NvFF+C0YteUDvW43OPPFKhFAzB3xmBz0ArhFG/ZW0NlhUl+rhQ532aeFCFmuIxVCyx2uWzOj2ai7poFyFl9BK1RCNTqttpxf3+EV5AhtTaldRSkJD3Ueb4/39EmT4U4nBo0C5r0+UsYwVVbOxH+JbVMhsHbjyNZpxScQ0HDP20CAGV6MuuJ8T5s1rtHXiAGILqYuz+KdPn8T7CVYj3ZkzIoeW+hFn87IpsyqL9nSxP8fGZyx4EvboJiomRzwYyc514NnkcPtwbC8IWKAsL8D1aq7lCg3cMHSnvde1cgkIrQWFKgGaaVlU/IFyRNqE=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(83380400001)(5660300002)(31696002)(2906002)(4744005)(36756003)(6486002)(31686004)(508600001)(38100700002)(26005)(186003)(53546011)(86362001)(6506007)(316002)(2616005)(6512007)(54906003)(6916009)(8936002)(4326008)(8676002)(66476007)(66556008)(66946007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?BeYXSnJEnV9qzv4wBMJpJrWxLKhM7jf1BoeJe51WucHB2j4qCf2Kio5N0h4O?=
 =?us-ascii?Q?gsrwGoVIYa7z5ens0DBtCo0PBCBSJy0oGqkEynqZxiwMK29JTdWl34IrXH/s?=
 =?us-ascii?Q?FdC8ekS1zn0j3BEZLDaKYPrRZHoqwMsA8IEdM60Es2R09S0mBW3QPou6Ycai?=
 =?us-ascii?Q?Tyw3fvPJtVozvN5FQSDZk4bZNYoWiGTrztCQ55WI/Iie/S+edxhJLXNeJ2NT?=
 =?us-ascii?Q?b4eiDSbsFzyByRRULUuEjDi0+xcT4ZKQWUfcOpNeZUCiDEYml9v9MtygjHbE?=
 =?us-ascii?Q?sk72jvv4bOt1Mag4/m3JgvXgCT6Cp4T+bDv4Qi6bH0aTeqKIUwGyUmENqeS/?=
 =?us-ascii?Q?k0Crx+JuCGMywZm3WTejmCwG0z6wwUpAs2oCOU82ML2DQVFVVrVAHzH5GR7c?=
 =?us-ascii?Q?DMjwxGou+1/QYsnbNMmBK2BHm3XxFsQRaeDG55e8s/aI0Qi6ICgRP7kLpkeC?=
 =?us-ascii?Q?oA7c54zEedA50ePOWzqt98ka1vLUkoffqFXhhqmp2T9ChOL6avu0v2hwEvwC?=
 =?us-ascii?Q?R6Y0YcWxv/9Ik/uj2j/LTHYPpCCKiU5WXnvZlKyBL5FJukPUX/YpM/DGzBzy?=
 =?us-ascii?Q?jfy/qweKeCznNRAT/lKqLfP2lpXn4dOiQFqM+uS+I78c5jLVUPJc5Ay/nZGL?=
 =?us-ascii?Q?SQmKGPW7ELotmWuD5aO8x2pNdYcQOz4tbvo3Yc6ToGmUK2EYhdTBDhEo5wWW?=
 =?us-ascii?Q?x2/YR7L06C5+BxtUYhSTvpLesV1rslePe4dU1y6/whK9PZbvG6ifp/c4GYTS?=
 =?us-ascii?Q?qvJqws6ZZNHWWXoGNBsxOB08lJVXMy0w0a0bJ7S9UsCJeZhzZLcKaLzTzG9t?=
 =?us-ascii?Q?Sq4gI9kYZieZAD3se4X+OmbDnXJcB6e9c2fSHE/7fGNiTlXimkS+WMAeb2wW?=
 =?us-ascii?Q?8CFBEjh4TImIIlOkoA7GuKDgnfO9PFe8ywNtD3CHNeEXFmagpNg/zjcF+I/2?=
 =?us-ascii?Q?+WxjAKAdK/XYKWsO6cc86rZPUtR11BS4bliKRRZTTYoo3opGZy0XN88WFPpt?=
 =?us-ascii?Q?xYyhOEPHqTHLZrieD/jsNQyJV+k1JLSdvfxwdiielVLP2BVVLNP6fpHjPHsy?=
 =?us-ascii?Q?Pry6MS3/WKqckTsYH7iL7eBuDYkcUtdQ1w3m+9YgoGEqeYzsHTj8q78WrPDs?=
 =?us-ascii?Q?DAL3QZzP5gIXscuRbKpgo6rxuPXI45OwQtT8RAgDlJuw+7IgZpqj5r6kb2MV?=
 =?us-ascii?Q?tvFcFJJfjHn6WivWDIPJK6ATSgHT24vUkC9JpTIGil858jG2rqKyuP8r2gis?=
 =?us-ascii?Q?Zy/Rj0u4+vpQvQz4280psVtnk86SBlcemu70dF7UQp+jBiwNpj9lC0HUcoPZ?=
 =?us-ascii?Q?1wfEIzy6o8mcAQCZAsGOjDqUyXVAzMWC/2AwuRr1j9ip7DAXImTSNCgUFAXd?=
 =?us-ascii?Q?RrgEHI3h+sQQS/3/OuCh4RHa22EtERwn4GdR9xDWefcdoEnbkiA3bSssArme?=
 =?us-ascii?Q?VRgkzGFLKZjcietuxd6fEBCt82JVHUMt9sb/szmofELCPTZG0T+ilVJFx20h?=
 =?us-ascii?Q?8RVJPyK9U25sQZqn8BD2DsOL5NJF25Mwl4ZjRj0y9Hju9qV7SKYltGB7c59F?=
 =?us-ascii?Q?2C50FMEiqOYbFdEt9TrLER06YC3s5xXWOhA1sfHMTRJjJkYWYrwiVHqULEWl?=
 =?us-ascii?Q?KUs3QU7jl/otaytZ/74tnXE=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2cd2ce82-1381-4d04-165f-08d9e7c1d5a9
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Feb 2022 09:36:35.0062
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ja57xB20CueYwMoSlY6eIg40DMPogH/n7uQ41txmp87z9qFYQnAMEvZmZS++ah9aYfKsTkSlFTn2XsuX/aLPtg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB6086

On 04.02.2022 10:28, Roger Pau Monn=C3=A9 wrote:
> On Wed, Feb 02, 2022 at 04:29:37PM +0100, Jan Beulich wrote:
>> On 02.02.2022 16:14, Roger Pau Monn=C3=A9 wrote:
>>> On Tue, Jan 04, 2022 at 10:41:53AM +0100, Jan Beulich wrote:
>>>> Do away with the "pod_target_out_unlock" label. In particular by foldi=
ng
>>>> if()-s, the logic can be expressed with less code (and no goto-s) this
>>>> way.
>>>>
>>>> Limit scope of "p2m", constifying it at the same time.
>>>
>>> Is this stale? I cannot find any reference to a p2m variable in the
>>> chunks below.
>>
>> Indeed it is, leftover from rebasing over the introduction of
>> p2m_pod_get_mem_target() in what is now patch 1. Dropped.
>=20
> I'm happy with this change with the commit adjusted:
>=20
> Acked-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>

Thanks.

> Not sure if you can commit this now regardless of patch 1?

I think it can be moved ahead; there looks to be only a minor contextual
dependency.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Feb 04 09:41:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 09:41:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265301.458635 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFv5h-00049V-0Y; Fri, 04 Feb 2022 09:41:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265301.458635; Fri, 04 Feb 2022 09:41:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFv5g-00049O-Te; Fri, 04 Feb 2022 09:41:16 +0000
Received: by outflank-mailman (input) for mailman id 265301;
 Fri, 04 Feb 2022 09:41:15 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nFv5f-00049I-Fu
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 09:41:15 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nFv5e-0005td-Ox; Fri, 04 Feb 2022 09:41:14 +0000
Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.2.73])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nFv5e-00081t-IR; Fri, 04 Feb 2022 09:41:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=mBtYiWysKWiP29tVIhYQCH7+vJLjrvISMol4iats01w=; b=5e1m2gQ7wwO1irsV0HA7dQZ4K4
	fZ6oelho4ePMDeJRiZ8Hdwia37dvtgcg2nt0apo264mEroiOvFIDnA+gIvLUKgAGj8mHOm28dvKKu
	k9SnSxb7iNmB3Nova35BtRCbuGnhEsVPO/m2emQYWDk06w1mNF+dwhisybfYkjt29jic=;
Message-ID: <d9741ff0-2152-6792-5249-09e3b0960972@xen.org>
Date: Fri, 4 Feb 2022 09:41:11 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.1
Subject: Re: [PATCH v6 01/13] xen/pci: arm: add stub for is_memory_hole
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Artem Mygaiev <Artem_Mygaiev@epam.com>,
 "roger.pau@citrix.com" <roger.pau@citrix.com>,
 "jbeulich@suse.com" <jbeulich@suse.com>,
 "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
 "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
 "paul@xen.org" <paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-2-andr2000@gmail.com>
 <000ac24e-fdac-855d-7fb4-2165a1192ea4@xen.org>
 <19e50632-5865-9a75-756b-88db85007e96@epam.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <19e50632-5865-9a75-756b-88db85007e96@epam.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 04/02/2022 09:01, Oleksandr Andrushchenko wrote:
> On 04.02.22 10:51, Julien Grall wrote:
>> Hi,
>>
>> On 04/02/2022 06:34, Oleksandr Andrushchenko wrote:
>>> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>>>
>>> Add a stub for is_memory_hole which is required for PCI passthrough
>>> on Arm.
>>>
>>> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>>>
>>> ---
>>> Cc: Julien Grall <julien@xen.org>
>>> Cc: Stefano Stabellini <sstabellini@kernel.org>
>>> ---
>>> New in v6
>>> ---
>>>    xen/arch/arm/mm.c | 6 ++++++
>>>    1 file changed, 6 insertions(+)
>>>
>>> diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
>>> index b1eae767c27c..c32e34a182a2 100644
>>> --- a/xen/arch/arm/mm.c
>>> +++ b/xen/arch/arm/mm.c
>>> @@ -1640,6 +1640,12 @@ unsigned long get_upper_mfn_bound(void)
>>>        return max_page - 1;
>>>    }
>>>    +bool is_memory_hole(mfn_t start, mfn_t end)
>>> +{
>>> +    /* TODO: this needs to be properly implemented. */
>>
>> I was hoping to see a summary of the discussion from IRC somewhere in the patch (maybe after ---). This would help to bring up to speed the others that were not on IRC.
> I am not quite sure what needs to be put here as the summary

At least some details on why this is a TODO. Is it because you are 
unsure of the implementation? Is it because you wanted to send early?...

IOW, what are you expecting from the reviewers?

> Could you please help me with the exact message you would like to see?

Here a summary of the discussion (+ some my follow-up thoughts):

is_memory_hole() was recently introduced on x86 (see commit 75cc460a1b8c 
"xen/pci: detect when BARs are not suitably positioned") to check 
whether the BAR are positioned outside of a valid memory range. This was 
introduced to work-around quirky firmware.

In theory, this could also happen on Arm. In practice, this may not 
happen but it sounds better to sanity check that the BAR contains 
"valid" I/O range.

On x86, this is implemented by checking the region is not described is 
in the e820. IIUC, on Arm, the BARs have to be positioned in pre-defined 
ranges. So I think it would be possible to implement is_memory_hole() by 
going through the list of hostbridges and check the ranges.

But first, I'd like to confirm my understanding with Rahul, and others.

If we were going to go this route, I would also rename the function to 
be better match what it is doing (i.e. it checks the BAR is correctly 
placed). As a potentially optimization/hardening for Arm, we could pass 
the hostbridge so we don't have to walk all of them.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Feb 04 09:47:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 09:47:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265309.458646 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFvBp-0004rG-NN; Fri, 04 Feb 2022 09:47:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265309.458646; Fri, 04 Feb 2022 09:47:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFvBp-0004r9-K3; Fri, 04 Feb 2022 09:47:37 +0000
Received: by outflank-mailman (input) for mailman id 265309;
 Fri, 04 Feb 2022 09:47:35 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=u+82=ST=epam.com=prvs=4034f0a382=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nFvBn-0004r3-6S
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 09:47:35 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 79013f62-859f-11ec-8eb8-a37418f5ba1a;
 Fri, 04 Feb 2022 10:47:33 +0100 (CET)
Received: from pps.filterd (m0174678.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 2147VchK001227;
 Fri, 4 Feb 2022 09:47:29 GMT
Received: from eur05-vi1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2169.outbound.protection.outlook.com [104.47.17.169])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e0yu5rg17-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 04 Feb 2022 09:47:29 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by DB8PR03MB6300.eurprd03.prod.outlook.com (2603:10a6:10:13f::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Fri, 4 Feb
 2022 09:47:24 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6%3]) with mapi id 15.20.4951.014; Fri, 4 Feb 2022
 09:47:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 79013f62-859f-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=FNZYTYXMR4X72RWrsGdDkYww/7oPoygBIx50HUDQ4j75m/N1ZQmWLqhtCsKl3rc7JlyjXCzh57DcLb9i0bl7V+G3XQlP5r0GTKYO8b7at0txtSDgp6/u9beRj1G67FZVL1z1e5VacDiJ4JfDnx/zhY+4Icok0fzH4DcquJrbKMDKag6sdixdsxVgbLpV9UIjx7+sK51Wq29X2eHHfy4icAlIxvGDKPNmrj+en8tolj/XFAME+TnMOF2fU634lFZXeoeo2SI/BG4AKDM7PLE6rVqlAIh4+pX1jkQdv0/MIpks6UD4kue6CYmC2Zda1HheInJ4jeg6r4MBzvZeUPi6QA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=OwICvpDE2fe4T4tWgkfH1bEvLBMLGpgSNmD+RdtsPHY=;
 b=OrXPK/DgJqafEhIatZS9eN0TcsSEpb2dbhKNiamMOpPGCfSsFlh+4TP+mlZdXBwuI9RbOqasFwUsUuRJeIgDZSokicF+NxPpHF7Pu+aEhqeCiHbThOcWDtH7wAiOehxFyzrYBL1JwZey1IXQFcOGIExKlPjsSojAz3y/4NPwoPNkVzsMjzEhnfCot+5UADU1K7hIN7MZuXNepDypuTtTh7qrgUaQDZCt4PRyMTYp7+OV3WNHxVQUkli9K0sCfgGIsZAHKzf5iir9YN4SAJZAe9G6CXZSyvSQk0d3AECn0dPjO5s31h/F3JWeUV1Q4Toy/6AiK5PMws6GW2aPEOpXOA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=OwICvpDE2fe4T4tWgkfH1bEvLBMLGpgSNmD+RdtsPHY=;
 b=PgDi7SpfYFGlKVNdMyli+HcejJnIs8b0F3S4mcp6grEKgUso9xGv4wGBdFe4jlf7euY+PGbHKxu1hoWMgTNDtYXlL0ncG1KXNDpQRiKkQS1K9Z2zxlf8pS9ck2irxBmW/i4MJSH7pLMLtk453C3AthcJyiLdSKN+++S0FG+O9WVKqHqxxXnzfb6Hx2N9/kW7NUASliFhbGa6UvzTGgES7H/hOYlE8VYw8zGvEGDr1rYfgCE7hdkP+sCPCpsvJk9puLXtnhBETpFSJ3ydpQFCtb1mSH9d5Gq5yLwV5ixKmyZRHmqlg+G8/Js/nVhsHtRGTbl1AR1tlyrdUbb8ZP6HEw==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Julien Grall <julien@xen.org>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: "sstabellini@kernel.org" <sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "roger.pau@citrix.com" <roger.pau@citrix.com>,
        "jbeulich@suse.com"
	<jbeulich@suse.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v6 01/13] xen/pci: arm: add stub for is_memory_hole
Thread-Topic: [PATCH v6 01/13] xen/pci: arm: add stub for is_memory_hole
Thread-Index: AQHYGZFbEg6Erttt1UCNei+XrySHEqyDFYiAgAAC4gCAAAsigIAAAbyA
Date: Fri, 4 Feb 2022 09:47:24 +0000
Message-ID: <43cab3d0-1a62-dca0-0d2d-5ea8fe237b21@epam.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-2-andr2000@gmail.com>
 <000ac24e-fdac-855d-7fb4-2165a1192ea4@xen.org>
 <19e50632-5865-9a75-756b-88db85007e96@epam.com>
 <d9741ff0-2152-6792-5249-09e3b0960972@xen.org>
In-Reply-To: <d9741ff0-2152-6792-5249-09e3b0960972@xen.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 184d875b-4255-41a3-fede-08d9e7c358cb
x-ms-traffictypediagnostic: DB8PR03MB6300:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <DB8PR03MB6300F85BE2E291799ACF998DE7299@DB8PR03MB6300.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 mWc701zS6kKWj9w6qguqnW+Dk+vOn5xw498BHX+igtcf8N9NH76nZwvQ/gzhMhlhIUTyMtR41h/fbQXHtegviVzSuXqwB0ZpQC+TRmMzUNoKQIFg4hn5iXwSjp8sm5t70MKn7W9xQaQY5kPnp+t2Zwcnvj/KrrjBmx9j4S0eL15qOzBVY5oVLQcTnI+bj1lI2C4QDaLMawZo5+gWaokQQiK1P26inENeoNDbWuOFXo/HN0ruFYAYa6UnUobtFWq98jYVLtbMLsvemIc4pXu5zArkoEVypWuuMqZ9JaV0n3asUdMc5qunoZRk5OwuIVfYxERPCZTAxZXgij15kUyHPhNQmc4d3MnIGLRs95ilmsjjk6F8+xubiQDixrVGOBkVtg2cRvq7YHNGCKdW8fw+j2HAp+czUj+69j5sLYDw6t2A5LO/W5Wg6tXQM/RGI34PrAjJZVy9k7Dqe8OUQI/IDcB4P6NKxZWaZ1azn9VhwFDksqHMv31X3nJhV1YPz4dPNrkwMIe3bZzhQKT/pyMrhG4NKxiQbFw78P+ZTUvRbHgIdkWa/XkTk/hkiuHWDRo/1lga9qz/yeEUylWtiJlM7jgJH2da6A6LsZw9ZIHzbz7PRsN1OZNdYzRhibKsOj9h4ZrN5GFX6rky8PJ0xNCoIdhRqQrJ4/NDxa03iXs32uhaN753xQGSSFftUxPuzGK39A5+ZJWzOWMdhBmIGwVvyp4U7UsrMrdZ08TubFw49UB/mcWbsXxG04OR+Ubj+/hr
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66556008)(31696002)(64756008)(122000001)(54906003)(71200400001)(2906002)(31686004)(83380400001)(6486002)(38070700005)(66476007)(107886003)(5660300002)(66446008)(508600001)(8936002)(110136005)(53546011)(8676002)(316002)(38100700002)(66946007)(76116006)(186003)(6506007)(91956017)(36756003)(7416002)(86362001)(6512007)(4326008)(2616005)(26005)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?bmFTZTFnVGd2WWp4T2RDZ0pOSC9Gd3MycUhQNmVUZy9kV0RvS3h6L3hPb3Rx?=
 =?utf-8?B?MFpUNzhXUE5hSHdVWURMVlRCTEpSUTBCK2RDQTlqaW1KQzY1YlBmYXd1R2xm?=
 =?utf-8?B?UFFLYUZhVFdqU3RVT0ljd3V3VmEvMGxhdUZyUmJud3kxajl3S3lrUXVGWEtT?=
 =?utf-8?B?SVRhbUtLZTlrTmdJb0tqUVE3VDBEMkhRQkRjNWltZ1ZqR1MxL1JCZnZOMGZC?=
 =?utf-8?B?ajZua1lyeHRtNW9ZcndYQit3b2R6N1FYeWRqM0M1ekw0aHFDeUlQcDlScnlJ?=
 =?utf-8?B?V0UyRll2RmZwbkZ1QVQzdktNc0oxSTB3VHVXWUdHOXErbUdpWDBtalJIeWNK?=
 =?utf-8?B?WDFjdkZCU2RRYzlUcDZJdkE5eU1ESGNrTXIvOHo0VW8yMTZndGJZTkZQVy92?=
 =?utf-8?B?UlRPQThPZmx4bUlyMFE1cERxQ1NtekVuZjNBcnJGK0Z0KzZmaUZRUWg1U3Fj?=
 =?utf-8?B?U1JmcjFRaklxeDJYTzZIZkVvb2E5Qncwa1VVb3UvRVo5ZVdKamFEQ25DOFM1?=
 =?utf-8?B?QWliUTZjOGVkaFBWYkxkaWtQWjRkT0pFMnUxWDR0T003UWF1V0RmaHBGS2pL?=
 =?utf-8?B?K3BITnZBY0tnbHdES205bm15VEZoOFJDQ2ErYllhR1ViWlQ5SjR6YUYra0Vu?=
 =?utf-8?B?QmV4K1RrSzh4OEplM2RrWml2bzdaMGdRT2RBVm14QkJpaUNlRjRjUkNhR1Rr?=
 =?utf-8?B?MzdQRmFrclpGQkorZURKOG5UeHdSakVvR2NrY2pUOHpLNEJ0blZWY3RYNFQw?=
 =?utf-8?B?T2ZHcjNRc3ZSOEhRMGJtQWFXK0FtY0hlWm9pV2NqQUxlWTZRVCsvRHRIY3RF?=
 =?utf-8?B?Q2MvSkorVWd5cU9KVjgySGxZSjJpUUdmdWxUUnlIMHlJVGVoQlFnYmZya2c0?=
 =?utf-8?B?QVJBU21xRGo1YkFYanpKVU0zNFZic0loM1o3UCttcjE0QTc4d2VvZWEyZ0kz?=
 =?utf-8?B?WUM4ei9meHo2M1l4b0w2dlY5aUxJL0xTRTRPMS9FUUFpWitSMC96OVF3NlB6?=
 =?utf-8?B?aEovZm5yVkdJeDBPOVFoZ2RsZjl2NnhmeEtkcjAxaUQ5VUV4Z2FQWXJJbUVZ?=
 =?utf-8?B?eEEzOWNPMHZXRG55ZzdseGVQZGR2d0VVUldjejIxSGNXc1dHaHhoZmVQWVJJ?=
 =?utf-8?B?ODNHbXhLVEVMVVFDSlorQkkxVUVveFFNVDRrNXJUZ0QxUXViaUpJOGt6aUNz?=
 =?utf-8?B?MEsyaTVXRkJqMFJWZ2pYRllkb1YvSEhhRjdIOWhjeGh4SFJiTEdkK0RwUDFO?=
 =?utf-8?B?VUk5TUVJaC9CaXFmTi9INlFFc2tWQWo1U09wQ2lsY1hYRDNJVFBaOGhXRjRw?=
 =?utf-8?B?Z09CbWtvdFVMYWxLZkd4anh6ZHRsYm50YmlJc3lQdkZCSXc5WnhiUGNnS2Rt?=
 =?utf-8?B?SWIrRDRvZ3FNUVdVVytPQ2RucWh1Qm9xc3BBRy9KR2hGN202M1ZibUVlUzhR?=
 =?utf-8?B?RXpxM1dUOXBmSFZvZGtyRS9BZU1xRFI0WklCSFMyOHBTU0RWaldYVkpKWWtB?=
 =?utf-8?B?Zkp5RWFoYkNRMy9TTFJQTFpxUndxQnYvbFlPdXdhT09VK2hLOU1RTXFRR3dp?=
 =?utf-8?B?cVZndzJHNXczYUc4NURhclh4ZWxaWUtpWUVQUHMrM3BvaFZ5bVZmalBhSVBM?=
 =?utf-8?B?MmRTampLWmZxbEFvdUo0dG5qY0E2T2JhQURxQmk2UnBLRXNCdHBpN3dSYTJr?=
 =?utf-8?B?RkpTUE1jUllHd1dKZXJQNjIwL0NnL2VTMHVIV25GNUpEa0d3OVZxampXQzNq?=
 =?utf-8?B?QVptMm93akRvait5MmpEVE1WeW9jenNwUDZVV0xmQituN1l2RzlRdjgzYy9w?=
 =?utf-8?B?ODZrYm55Qkt6dGswaXprUFh4YklRM2l3NGNQNWx0L2J0Z2xmVmkzWjRSL1ZW?=
 =?utf-8?B?dTNuWXR3aEhDS2lHazZ1dEp6VUFmQlpRVjlqTW1qbW1RRXRYcGM3MEpnZGFk?=
 =?utf-8?B?b2lOZTRxRkJYWVJoWXlQNVI0MjFMS2d6MytNeFQwczFKKzhIQXZhYnRiNzdn?=
 =?utf-8?B?alhoYTdYa3ZBU1grS0pocFhtRVAvUmQ4bU4zb3A1WW02T3l0Z25IdHhRaXd2?=
 =?utf-8?B?QVF2SkpnUVg4V0pPZEc1aER1STFuMXlWZHBLNGMyYlBOYmdtbjVFRlNVSlFw?=
 =?utf-8?B?bzRjR1ozRVZrN3BGNWJlM1RWL3hxTGNZdC9NVTU0dUZYNG11V0M2STRta1N0?=
 =?utf-8?B?QzVRTGxIOEhDOUI4aG9ENnlud3h2N2VPR3dIZEExOUwxNzEwV1VuazAxL3Bl?=
 =?utf-8?B?Q2wzcXFWWG05V3NjWllnRWlPMDZSQ2h1bFZUNmhlYS94MVNnNUdvdGdNekwz?=
 =?utf-8?B?cW4zRDNXMTZPQ1pMMnpvK1ViRGNYT3UzS2I4RVQ3VitVUUVjeEh2QT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <A39E8E04F1CFBD4BB8931B9D9196B719@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 184d875b-4255-41a3-fede-08d9e7c358cb
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Feb 2022 09:47:24.3257
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: vVLzpEx5wQW16A1PzdYRqE6IKFPXue6SohPz1U5Vyue2IEdtUjDfMvHx1MXCHz2kSpC5id/FNbD1FoFmJ/IN56f5Lc3g2P+C0CfNyTFvBMAR6ddK/otdcYUX9lD4Tznx
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR03MB6300
X-Proofpoint-GUID: 2uoDSoXiWrkRngE4H64voBLnP8SCwO2w
X-Proofpoint-ORIG-GUID: 2uoDSoXiWrkRngE4H64voBLnP8SCwO2w
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-04_03,2022-02-03_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 lowpriorityscore=0
 phishscore=0 suspectscore=0 bulkscore=0 mlxlogscore=999 malwarescore=0
 impostorscore=0 spamscore=0 adultscore=0 priorityscore=1501 clxscore=1015
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2202040051

DQoNCk9uIDA0LjAyLjIyIDExOjQxLCBKdWxpZW4gR3JhbGwgd3JvdGU6DQo+IE9uIDA0LzAyLzIw
MjIgMDk6MDEsIE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4gT24gMDQuMDIuMjIg
MTA6NTEsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4+PiBIaSwNCj4+Pg0KPj4+IE9uIDA0LzAyLzIw
MjIgMDY6MzQsIE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4+PiBGcm9tOiBPbGVr
c2FuZHIgQW5kcnVzaGNoZW5rbyA8b2xla3NhbmRyX2FuZHJ1c2hjaGVua29AZXBhbS5jb20+DQo+
Pj4+DQo+Pj4+IEFkZCBhIHN0dWIgZm9yIGlzX21lbW9yeV9ob2xlIHdoaWNoIGlzIHJlcXVpcmVk
IGZvciBQQ0kgcGFzc3Rocm91Z2gNCj4+Pj4gb24gQXJtLg0KPj4+Pg0KPj4+PiBTaWduZWQtb2Zm
LWJ5OiBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyA8b2xla3NhbmRyX2FuZHJ1c2hjaGVua29AZXBh
bS5jb20+DQo+Pj4+DQo+Pj4+IC0tLQ0KPj4+PiBDYzogSnVsaWVuIEdyYWxsIDxqdWxpZW5AeGVu
Lm9yZz4NCj4+Pj4gQ2M6IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3N0YWJlbGxpbmlAa2VybmVsLm9y
Zz4NCj4+Pj4gLS0tDQo+Pj4+IE5ldyBpbiB2Ng0KPj4+PiAtLS0NCj4+Pj4gwqDCoCB4ZW4vYXJj
aC9hcm0vbW0uYyB8IDYgKysrKysrDQo+Pj4+IMKgwqAgMSBmaWxlIGNoYW5nZWQsIDYgaW5zZXJ0
aW9ucygrKQ0KPj4+Pg0KPj4+PiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL21tLmMgYi94ZW4v
YXJjaC9hcm0vbW0uYw0KPj4+PiBpbmRleCBiMWVhZTc2N2MyN2MuLmMzMmUzNGExODJhMiAxMDA2
NDQNCj4+Pj4gLS0tIGEveGVuL2FyY2gvYXJtL21tLmMNCj4+Pj4gKysrIGIveGVuL2FyY2gvYXJt
L21tLmMNCj4+Pj4gQEAgLTE2NDAsNiArMTY0MCwxMiBAQCB1bnNpZ25lZCBsb25nIGdldF91cHBl
cl9tZm5fYm91bmQodm9pZCkNCj4+Pj4gwqDCoMKgwqDCoMKgIHJldHVybiBtYXhfcGFnZSAtIDE7
DQo+Pj4+IMKgwqAgfQ0KPj4+PiDCoMKgICtib29sIGlzX21lbW9yeV9ob2xlKG1mbl90IHN0YXJ0
LCBtZm5fdCBlbmQpDQo+Pj4+ICt7DQo+Pj4+ICvCoMKgwqAgLyogVE9ETzogdGhpcyBuZWVkcyB0
byBiZSBwcm9wZXJseSBpbXBsZW1lbnRlZC4gKi8NCj4+Pg0KPj4+IEkgd2FzIGhvcGluZyB0byBz
ZWUgYSBzdW1tYXJ5IG9mIHRoZSBkaXNjdXNzaW9uIGZyb20gSVJDIHNvbWV3aGVyZSBpbiB0aGUg
cGF0Y2ggKG1heWJlIGFmdGVyIC0tLSkuIFRoaXMgd291bGQgaGVscCB0byBicmluZyB1cCB0byBz
cGVlZCB0aGUgb3RoZXJzIHRoYXQgd2VyZSBub3Qgb24gSVJDLg0KPj4gSSBhbSBub3QgcXVpdGUg
c3VyZSB3aGF0IG5lZWRzIHRvIGJlIHB1dCBoZXJlIGFzIHRoZSBzdW1tYXJ5DQo+DQo+IEF0IGxl
YXN0IHNvbWUgZGV0YWlscyBvbiB3aHkgdGhpcyBpcyBhIFRPRE8uIElzIGl0IGJlY2F1c2UgeW91
IGFyZSB1bnN1cmUgb2YgdGhlIGltcGxlbWVudGF0aW9uPyBJcyBpdCBiZWNhdXNlIHlvdSB3YW50
ZWQgdG8gc2VuZCBlYXJseT8uLi4NCj4NCj4gSU9XLCB3aGF0IGFyZSB5b3UgZXhwZWN0aW5nIGZy
b20gdGhlIHJldmlld2Vycz8NCldlbGwsIEkganVzdCBuZWVkIHRvIGFsbG93IFBDSSBwYXNzdGhy
b3VnaCB0byBiZSBidWlsdCBvbiBBcm0gYXQgdGhlIG1vbWVudC4NCkNsZWFybHksIHdpdGhvdXQg
dGhpcyBzdHViIEkgY2FuJ3QgZG8gc28uIFRoaXMgaXMgdGhlIG9ubHkgaW50ZW50aW9uIG5vdy4N
Ck9mIGNvdXJzZSwgd2hpbGUgUENJIHBhc3N0aHJvdWdoIG9uIEFybSBpcyBzdGlsbCBub3QgcmVh
bGx5IGVuYWJsZWQgdGhvc2UNCndobyB3YW50IHRyeWluZyBpdCB3aWxsIG5lZWQgcmV2ZXJ0aW5n
IHRoZSBvZmZlbmRpbmcgcGF0Y2ggb3RoZXJ3aXNlLg0KSSBhbSBmaW5lIGJvdGggd2F5cw0KPg0K
Pj4gQ291bGQgeW91IHBsZWFzZSBoZWxwIG1lIHdpdGggdGhlIGV4YWN0IG1lc3NhZ2UgeW91IHdv
dWxkIGxpa2UgdG8gc2VlPw0KPg0KPiBIZXJlIGEgc3VtbWFyeSBvZiB0aGUgZGlzY3Vzc2lvbiAo
KyBzb21lIG15IGZvbGxvdy11cCB0aG91Z2h0cyk6DQo+DQo+IGlzX21lbW9yeV9ob2xlKCkgd2Fz
IHJlY2VudGx5IGludHJvZHVjZWQgb24geDg2IChzZWUgY29tbWl0IDc1Y2M0NjBhMWI4YyAieGVu
L3BjaTogZGV0ZWN0IHdoZW4gQkFScyBhcmUgbm90IHN1aXRhYmx5IHBvc2l0aW9uZWQiKSB0byBj
aGVjayB3aGV0aGVyIHRoZSBCQVIgYXJlIHBvc2l0aW9uZWQgb3V0c2lkZSBvZiBhIHZhbGlkIG1l
bW9yeSByYW5nZS4gVGhpcyB3YXMgaW50cm9kdWNlZCB0byB3b3JrLWFyb3VuZCBxdWlya3kgZmly
bXdhcmUuDQo+DQo+IEluIHRoZW9yeSwgdGhpcyBjb3VsZCBhbHNvIGhhcHBlbiBvbiBBcm0uIElu
IHByYWN0aWNlLCB0aGlzIG1heSBub3QgaGFwcGVuIGJ1dCBpdCBzb3VuZHMgYmV0dGVyIHRvIHNh
bml0eSBjaGVjayB0aGF0IHRoZSBCQVIgY29udGFpbnMgInZhbGlkIiBJL08gcmFuZ2UuDQo+DQo+
IE9uIHg4NiwgdGhpcyBpcyBpbXBsZW1lbnRlZCBieSBjaGVja2luZyB0aGUgcmVnaW9uIGlzIG5v
dCBkZXNjcmliZWQgaXMgaW4gdGhlIGU4MjAuIElJVUMsIG9uIEFybSwgdGhlIEJBUnMgaGF2ZSB0
byBiZSBwb3NpdGlvbmVkIGluIHByZS1kZWZpbmVkIHJhbmdlcy4gU28gSSB0aGluayBpdCB3b3Vs
ZCBiZSBwb3NzaWJsZSB0byBpbXBsZW1lbnQgaXNfbWVtb3J5X2hvbGUoKSBieSBnb2luZyB0aHJv
dWdoIHRoZSBsaXN0IG9mIGhvc3RicmlkZ2VzIGFuZCBjaGVjayB0aGUgcmFuZ2VzLg0KPg0KPiBC
dXQgZmlyc3QsIEknZCBsaWtlIHRvIGNvbmZpcm0gbXkgdW5kZXJzdGFuZGluZyB3aXRoIFJhaHVs
LCBhbmQgb3RoZXJzLg0KPg0KPiBJZiB3ZSB3ZXJlIGdvaW5nIHRvIGdvIHRoaXMgcm91dGUsIEkg
d291bGQgYWxzbyByZW5hbWUgdGhlIGZ1bmN0aW9uIHRvIGJlIGJldHRlciBtYXRjaCB3aGF0IGl0
IGlzIGRvaW5nIChpLmUuIGl0IGNoZWNrcyB0aGUgQkFSIGlzIGNvcnJlY3RseSBwbGFjZWQpLiBB
cyBhIHBvdGVudGlhbGx5IG9wdGltaXphdGlvbi9oYXJkZW5pbmcgZm9yIEFybSwgd2UgY291bGQg
cGFzcyB0aGUgaG9zdGJyaWRnZSBzbyB3ZSBkb24ndCBoYXZlIHRvIHdhbGsgYWxsIG9mIHRoZW0u
DQpJdCBzZWVtcyB0aGlzIG5lZWRzIHRvIGxpdmUgaW4gdGhlIGNvbW1pdCBtZXNzYWdlIHRoZW4/
IFNvLCBpdCBpcyBlYXN5IHRvIGZpbmQNCmFzIGV2ZXJ5dGhpbmcgYWZ0ZXIgIi0tLSIgaXMgZ29p
bmcgdG8gYmUgZHJvcHBlZCBvbiBjb21taXQNCj4NCj4gQ2hlZXJzLA0KPg0KVGhhbmsgeW91LA0K
T2xla3NhbmRy


From xen-devel-bounces@lists.xenproject.org Fri Feb 04 09:54:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 09:54:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265318.458657 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFvIb-0006Mh-Ia; Fri, 04 Feb 2022 09:54:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265318.458657; Fri, 04 Feb 2022 09:54:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFvIb-0006Ma-Ep; Fri, 04 Feb 2022 09:54:37 +0000
Received: by outflank-mailman (input) for mailman id 265318;
 Fri, 04 Feb 2022 09:54:36 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=46ws=ST=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nFvIa-0006MU-MN
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 09:54:36 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 741bf21d-85a0-11ec-8eb8-a37418f5ba1a;
 Fri, 04 Feb 2022 10:54:34 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 741bf21d-85a0-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1643968474;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=nrhw4Gl5cjKq3B82uTDbfZ0cuYcJTthEIF+ScbFjrv4=;
  b=WQDVi2aA/UfTFMzJu9aFjshWCnjNO7j/eGzAG0FnNMOW66JAXPA6zUsm
   d4aMwdq0BfN/8jAO9kF2BXnsK025cBtVSoC4SQv2kdCMMC4lB5+jKavlZ
   sxJlZgUwjcolClRGfOC2FRst/v+18zdh/NuIWuldJfIuFFSLHEH0evrcJ
   k=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: tzWl6HIjNOc/2DL6uHQ7oClEes8YA7mtrK+3mYdM0GfiE/foUd2K6V/XNCXLXzIPx0qrBO+SQj
 y7no/JejNzKkGWAO94+Ptc8riBnfRk7nAeBYJNYb8s9PN63n/MsCX1YcAzVXRM3PUwbPwlDvOk
 xuuI5JlFxGI3Ooqe5mW7OcHaC99seX3m5LVSvZFf+zp1R4evbWjxhvgBp+TtNr6Wdo/VXWWdeh
 G/9XRfnjdZUgTHezPxAh7Y6R+ekUns2BBN0FQbNkfx17IsXRusNeUD/h++AjP+VQMdi4HAI09O
 UpQHxLNaept0D+W7q4d7SccU
X-SBRS: 5.1
X-MesageID: 63401626
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:F9AON6swuCulVRlFNri0xvoxUOfnVNxZMUV32f8akzHdYApBsoF/q
 tZmKT2EPPiCa2X3Ltt2Pd6/9x4H65fTmtBrTFQ4ryo1FX4R+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZQP0VOZigHtIQMsadUsxKbVIiGHdJZS5LwbZj2NYy2YThWWthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 Npl6LuAUwIYNYDwiOU5c0V2FSxQI/0dweqSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DJoQQt2sm1TjEJf0nXYrCU+PB4towMDIY2JsSRa+AP
 ZRxhTxHbxPlelpIK3MuJZckxPuHtCPZMDMJpwfAzUYwyzeKl1EguFT3C/LOYcCDT8hRmkeep
 0rF8n7/DxVcM8aQoRKd+2+orv/Cm2X8Qo16PK218LtmjUOewkQXCQYKTh2rrP+hkEm8VtlDb
 UsO9UIGr6I/6UiqRdnVRACjrTiPuRt0c8VUO/037keK0KW8ywSEAmkJSBZRZdpgs9U5LQHGz
 XfQwYmvX2Y29uTIFzTNrd94sA9eJwBICl8YYB4PYDcV4v3D/K81gzzRHo1aRfvdYsLOJRn8x
 DWDrS4bjroVjNIW26jTwW0rkw5AtbCSEFdru1y/snaNq1ogOdX7P9DABU3zsK4YRLt1WGVtq
 5TtdyK2yOkVRa+AmyWWKAnmNOH4vq3VWNEwbLMGInXAy9hP0yP7FWyzyGsnTKuMDiriUWWyC
 KM0kVgJjKK/xFPwMcdKj3uZUqzGN5TIG9X/TezzZdFTeJV3fwLv1HgwORXAhD2zzRl3zvpX1
 XKnnSCEVy1y5UNPl2Leegvg+eVzmnBWKZ37GfgXMChLIZLBPSXIGN/pwXOFb/wj7bPsnekm2
 403Cid+8D0GCLeWSnCOqeY7dAlWRVBmVcGeg5EGLYarf1s5cFzN/teMmNvNjaQ+xP8L/goJl
 1ngMnJlJK3X3iyacFjaNyw4NdsCn/9X9BoGAMDlBn7xs1ALaoez9qYPMZwxeLgs7ut4yvBoC
 fICfq297j5nE1wrIhwRMsvwqpJMbhOuiV7cNiapemFnLZVhWxbI6pnveQ62rHsCCS++tM0fp
 by811yEHcpfFlo6VMuGOuiyy16RvGQGnL4gVUX/PdQOKl7n95JnKnKtg6Zvcd0MMxjK2hCTy
 x2SXUUDveDIroJsqIvJiKmIop2HCex7GkYGTWDX4azvbXvR/3a5wJ8GW+GNJGiPWGTx8aSkR
 ONU0/Cjb6FXwAcU69JxSu85w7g/6t3jo65h4j5lRHibPU62Dr5AI2Wd2ZUdvKN62bIE6xC9X
 ViC+4cGNOzRat/lClMYOCEscv+HiaMPgjDX4Pk4fBf66Stw8ObVWEleJUDR2ilULb8zO4I52
 +Yx/sUR7lXn2BYtN9+HiAFS9niNcSNcA/l26MlCDd+5kBcvx3FDfYfYW33/75y4YtlRNlUnf
 22Pj63YirUAnkfPfhLfz5QWMTaxUXjWhC138Q==
IronPort-HdrOrdr: A9a23:w5/+da1vxqyqEN54d7dElwqjBSpyeYIsimQD101hICG9Lfb2qy
 n+ppgmPEHP5Qr5OEtApTiBUJPwJk800aQFm7X5Wo3SITUO2VHYV72KiLGN/9SOIVydygcw79
 YET0E6MqyNMbEYt7eK3ODbKadY/DDvysnB7o2/vhRQpENRGtldBm9Ce3im+yZNNW977PQCZf
 6hDp0tnUveRZ1bVLXxOlA1G8z44/HbnpPvZhALQzYh9Qm1lDutrJr3CQKR0BsyWy5Ghe5Kyx
 mJryXJooGY992rwB7V0GHeq7xQhdva09NGQOiBkNIcJDnAghuhIK5hR7qBljYop/zH0idhrP
 D85zMbe+hj4XLYeW+45TPrxgnbyT4rr0TvzFeJ6EGT1/DRdXYfMY5slIhZehzW5w4Lp9dnyp
 9G2Gqfqt5+EQ7AtD6V3amHazha0m6P5VYym+8aiHJSFaEEbqVKkIAZ9ERJVL8dASPB7pw9Gu
 UGNrCS2B9vSyLbU5nlhBgt/DT1NU5DXCtuA3Jy9vB96gIm3UyQlCAjtYkidnRpzuNLd3AL3Z
 WBDk1SrsA8ciYhV9MIOA4we7rGNoXze2O/DIuzGyWvKEhVAQOEl3bIiI9Fkd1CPqZ4i6cPpA
 ==
X-IronPort-AV: E=Sophos;i="5.88,342,1635220800"; 
   d="scan'208";a="63401626"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ZnG/azxWoZc+7I37nEwGxY8SkeBmdUFBkM4PM3w3OFwKSrMHC49mvVVMtJmhG0aAKawgxPD5y4AzFHuYcIQEBXHhnWyzlrnFVlbQYmI0H/m1sPhtcKEg/9IPR2REmPLJfRHH+dHx7wsq/NPJC/liAGbdsftt++cQQVdOpel33FW9/Bd/ifMGIvzcoXCJC0yK4BqL2ZyBanHRCAmTlkGis/q4rplHXdKHb5qrT+fCh4HI+Io8RbbOkMDbR72RBnS5Z20qocqpgqqPPyIj+IMP2gsLI8zp9uRZXP9Eyg3GBuc3265i3L1oyDfpyeno3hGSYXTUyxs/OGf3/RtZsQWtqA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=nLrXdBKq1Kb7cup8F/PSzD52IEIcQ//gq1iU9TcYCVY=;
 b=PWyFE/suoqRGrfJSQZpy1nY9CCOU3nyG5UEAg9E3Ore4JDgqFmTbzqri9+nr/a/GR/Tpu/MRHOI1jF4D1WgFboAqx0no+jmCWLkQ2mV5YthSw0UXRalg+NrEopweQ843ZIpblGRGMLP2anR+RklVMRLA0oV41jSOn2Q9hDpW1TirGd7X4DCqvte6Dmtp/CFwLAhjpRMthdiQ309xP0eK3VQ/RZjy8O2NMsRFD24RHXSW/ztEc3C2x20ysIXsvV7x96WqKezRL1uqeDdKvdBeYRpqGELXXL2a1rezd/C+l8znCoJED4EY5k3LoXE+mfekrJBGqfjec9GGBUXT5bVEIw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=nLrXdBKq1Kb7cup8F/PSzD52IEIcQ//gq1iU9TcYCVY=;
 b=nZXlLrdV+eOs6SO7ixSSbRJyeshH39OAVTT7YO63y8DjeZt5hCZxZxeDxTCtO7aaKf4vf8sb1yy5NM2kVcn6GtSvfB2rauvLliIf5M3/rPi9gNxeV08kym3AnnbzeBUd1hle1GdiFfo1AMt/qLEEOOKsF3tJrmI1KMghUdgoChs=
Date: Fri, 4 Feb 2022 10:54:20 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>, George
 Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>, Stefano
 Stabellini <sstabellini@kernel.org>, Paul Durrant <paul@xen.org>,
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 2/3] x86/vmsi: add support for extended destination ID in
 address field
Message-ID: <Yfz3zLFpA3DWt27m@Air-de-Roger>
References: <20220120152319.7448-1-roger.pau@citrix.com>
 <20220120152319.7448-3-roger.pau@citrix.com>
 <2e96bf2e-a31e-da9b-2f08-adfa0928e5b9@suse.com>
 <YfzwepCoIvJ3cI0v@Air-de-Roger>
 <d4ff7ca4-e728-5f5a-e569-ae42fdf17157@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <d4ff7ca4-e728-5f5a-e569-ae42fdf17157@suse.com>
X-ClientProxiedBy: LO4P123CA0446.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1a9::19) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9a41d2be-af8b-40d9-2ec4-08d9e7c4534c
X-MS-TrafficTypeDiagnostic: DM4PR03MB6061:EE_
X-Microsoft-Antispam-PRVS: <DM4PR03MB6061488FCE3E1801ECFC9C808F299@DM4PR03MB6061.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: VmwpnSBWhOJ3Iwl61DyCx3V1FIbItVo8z7mkPaQYHpYIvSg6MhulleYLP0raO2KbgQxQPiQkNa6Nh6lQZkWKJix3bDZbmJzKVo+rIl5gOOK1iml44OOFLybNzVZ7ArV2ftUDRxEv0mB22j5Svr9K3lb/MxbkfAQy/uGwlo0RlDHeixWAzc/s4Ukjk2JqNfDC54PXRwZ7CAgJ8dLe4kqKliM23Ir2XO++j5iiaE6kM6R4wp1X8f25/o3jjYj7op848EDwOUXzKjNlzq4RDVC3TDxA27AuDD+djsiYt3lfl4RvjxBps8W7Jv7ExwPu5y6FVPhLSiyhatsolyAjOuWZuQyug8wTbOGnUc2bQTy+TngAnbMlnmmTveQP/PS0HD+sOENGr/ymB7r05HogRkiv/5TB1W0SRh6PifeIAhovrtjwYXAAVd43ljqbTeXiVRCz7Ttfyr7i3XA3TYjCtXcNN07fvYH6GkBRzDs/w9GpScBQ+hO7QHn73SJVMVSs0EIxKiIpKSexghIX2SJW542msopupS9MS1JH9HskwedBIIjD/pyHfNw/u5sp3KgysiRPFDs2NRWnEEUAIlxHegq1X891frKIsIm1X2UxMgp/IhPYYpZWifiVkBCGX1XWOyHYyktnXcOJA9OBDUE+ZKL3xg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(4326008)(66946007)(8676002)(8936002)(66476007)(66556008)(2906002)(83380400001)(5660300002)(6486002)(38100700002)(82960400001)(316002)(9686003)(6512007)(33716001)(85182001)(186003)(26005)(6916009)(6506007)(508600001)(53546011)(6666004)(54906003)(86362001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NHF0NHYxcVNrMXl5b3Z3SE9OL2pNU3MvaGJnZkQrYkZ6Y3ZITThtY1owemk4?=
 =?utf-8?B?MzNiN3B3dmpKVFZ4TUdpTGhBQlp4OWNUNk53a0UyRkltcVZjUFBkWkVsZ2Fk?=
 =?utf-8?B?ODZ2dXVUd0U1SVZOUm1Tb2ppVXJRQ3YrZ202M1lqa0ZJSGZLMGhnSlBhS2Rz?=
 =?utf-8?B?MWtnNTJxa2loTDVBUlRuRk44TStNd1hNSnlMcEgzUS9icjZyOEFWMW5uRy83?=
 =?utf-8?B?OW1WZGRjOW9jTnNBQjdqVmpYWktBU0RieU9Ga2kyNW0rQlRBTnN1VkJnZGRa?=
 =?utf-8?B?bUVpNXNmemdPbTNNbUtwaEZHUzgyd1BqVmlYTkNrbldFakNIRWtVeEppYlVN?=
 =?utf-8?B?ei9GSi9naW9KRGpieTBlZ3Rtc3M3bXhHOWMvOXZrZngrYWVUaTNsTGVLNzZG?=
 =?utf-8?B?clcyQ1kvMEdFdDZpbWIrekpnTUJMK0grWEE4OVY2L0xnNmFsNmF6UVJIa3cx?=
 =?utf-8?B?SFJielYvTXpBZHpGbzNLYVdzYnVBSUpGczZzdlZjTElQNjN2TkU3RUZRNG1Q?=
 =?utf-8?B?V0VNaXRvU3BzRUtETjJNaEh1ODVvUVFQbHUxMjRENGhxUFB2SWhZVndXbHRp?=
 =?utf-8?B?RlgvYjhWTWN1SnBQdGtpTEppZXAxU21zSDc2UG9HYVN3TXdua1BlOUxsN0pk?=
 =?utf-8?B?dzJzdGN6UzZVQWl4QVNQdUhmUjMvNnBCRWRHcGZNV1NKaHhmKzVLZzVTTWJF?=
 =?utf-8?B?TjVaaDVVRlpOZytxTlJ2Y1pwV3IxZXM2RkFHQlNFV0FOazgvN0lETFYwSEE3?=
 =?utf-8?B?YWR0NVF5YzJHRmlENEkzd0xPSng3cWVieDAvdjRLalZmTFg2dzMvVitRK28v?=
 =?utf-8?B?Q0xxaFN2Q0drM3hKb21NNGZ1TTg3WldjK0NVZ2VPSS9GdGZFRFF0bHZkYTFZ?=
 =?utf-8?B?ZnpDVU5QNkV2Nms3V1Fydm9WVUxzLytkYUNkc2VoRnBEVUt1QjhmeUIvVEZX?=
 =?utf-8?B?MTRyZ0NCT1VaN3JodFhiYkNWME0yazJIWitzZ05TWC9XWFU0OWVQVzA2ODF6?=
 =?utf-8?B?STZ2MGFWWG02blVQWks1bDRGZWNXY0IvVnd0YUdyNkpzeVhOVFBQKzNsZExq?=
 =?utf-8?B?dUkyNmhCRHlCRGwxK2JNa1c4RnRoaDRUQ3UvaUZFMnVpSWJVOXpacnVLYzdq?=
 =?utf-8?B?T1BSeGEyZ3lTSGhtRkdrTnJHUkx6ak5YYXRsWmdQNTF6MUZKQ1FKYzRYemRi?=
 =?utf-8?B?MmE2YmVuVlUrclBZTDE0YWtJbDY0NGw0UUlUL1ZSY1NZZS8welhSMlZ6cEkw?=
 =?utf-8?B?Smd5bHFWVFNwYW9rQjk2V09pMzZmODlXL1hmRUtQQmhLbmRwbjhKWU1jRGpp?=
 =?utf-8?B?QzNCOXYrblNEemppY2FZUW9JSWJhRENqMzNGQkVuZjNPUGltN0EzNnpjcnZi?=
 =?utf-8?B?LzN2ek9TTkZsV1ZYRi9CSTRWc0xxTEpXb2QrdEM3dTViRUY4a3pjYlhwZklr?=
 =?utf-8?B?aDJUUHJrTWFsZ25BZjlZc2p0NDVHTTc1bHdheHZwN21Bc3NwSkRQZDdvUDlw?=
 =?utf-8?B?SVFucGQyeklkTlh6M0hOLzkvbVR1RytHM2xqdDhoZEJaL3R1U3FUMk0zeW9Z?=
 =?utf-8?B?Z0pXZkxacXI5clZ1d2M0Q1pOSmN0eHlDNEw3cjk1UUk2QjhyRytpRDhlSTBY?=
 =?utf-8?B?U3JISDB3c1VVT0kwQ05ENkd3Z2hXZzkxY0J3MG1sTm43Z1M5Zm91Ynk2b3VM?=
 =?utf-8?B?VHRrdHB0ekh5ckRnWTZuaFlpMDBjbFFxZzlXeWV0ZFVaWWtuYzhuYVFwM0tR?=
 =?utf-8?B?YzJmSXFBUklJSENobGtnSUJybTdkQ1ZjVm9leWNHRHFORHcybWJrWUVLWGJq?=
 =?utf-8?B?UTBnY2JPWlhxRzlNZFB3c3pCZjRWOERuTk1hR0EyZVlKbkdJNDN2ZVN5V2FO?=
 =?utf-8?B?aTQyeU05cEhYUHZmQkhPRFo1Ui8xZjUwZFZLQURtN3l3YTdVbVVSODNkUkhJ?=
 =?utf-8?B?a2FIS0wyM0xFeWVQMUNrMmFkWmRzMUt1K20wSkhQZUVWUzhnV0l0ZHZldVds?=
 =?utf-8?B?Y2xGTEVmUFkvVVpIQi81R1BLbHBuaVFkTW9pN0dZbGNWUDNBcHBYMUlzdXJz?=
 =?utf-8?B?VGFraE1GZDlIVCtNOGp3ai9iY2h1UitHMkdrM25WcjlpT2EyL3NHSVZKMFc5?=
 =?utf-8?B?ODNPSDBBcGdUTm9MVHFsNk1FWVJsejN0NUxIUVRWV2VFVTdWeHRFZC9rL2kx?=
 =?utf-8?Q?mvemuzeFRxri/721VvD33mk=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9a41d2be-af8b-40d9-2ec4-08d9e7c4534c
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Feb 2022 09:54:24.7837
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: f/Lj00Ko09SMBSH65ingiNZvifRsUliarq8ZvaV8DtoiJjIE7uWceajaG4fDYz3g0LLDpYI/FMl9JMqQCIdTjA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB6061
X-OriginatorOrg: citrix.com

On Fri, Feb 04, 2022 at 10:30:54AM +0100, Jan Beulich wrote:
> On 04.02.2022 10:23, Roger Pau Monné wrote:
> > On Mon, Jan 24, 2022 at 02:47:58PM +0100, Jan Beulich wrote:
> >> On 20.01.2022 16:23, Roger Pau Monne wrote:
> >>> --- a/xen/arch/x86/include/asm/msi.h
> >>> +++ b/xen/arch/x86/include/asm/msi.h
> >>> @@ -54,6 +54,7 @@
> >>>  #define MSI_ADDR_DEST_ID_SHIFT		12
> >>>  #define	 MSI_ADDR_DEST_ID_MASK		0x00ff000
> >>>  #define  MSI_ADDR_DEST_ID(dest)		(((dest) << MSI_ADDR_DEST_ID_SHIFT) & MSI_ADDR_DEST_ID_MASK)
> >>> +#define	 MSI_ADDR_EXT_DEST_ID_MASK	0x0000fe0
> >>
> >> Especially the immediately preceding macro now becomes kind of stale.
> > 
> > Hm, I'm not so sure about that. We could expand the macro to place the
> > high bits in dest at bits 11:4 of the resulting address. However that
> > macro (MSI_ADDR_DEST_ID) is only used by Xen to compose its own
> > messages, so until we add support for the hypervisor itself to use the
> > extended destination ID mode there's not much point in modifying the
> > macro IMO.
> 
> Well, this is all unhelpful considering the different form of extended
> ID in Intel's doc. At least by way of a comment things need clarifying
> and potential pitfalls need pointing out imo.

Sure, will add some comments there.

> >>> --- a/xen/include/public/domctl.h
> >>> +++ b/xen/include/public/domctl.h
> >>> @@ -588,6 +588,7 @@ struct xen_domctl_bind_pt_irq {
> >>>  #define XEN_DOMCTL_VMSI_X86_DELIV_MASK   0x007000
> >>>  #define XEN_DOMCTL_VMSI_X86_TRIG_MASK    0x008000
> >>>  #define XEN_DOMCTL_VMSI_X86_UNMASKED     0x010000
> >>> +#define XEN_DOMCTL_VMSI_X86_EXT_DEST_ID_MASK 0xfe0000
> >>
> >> I'm not convinced it is a good idea to limit the overall destination
> >> ID width to 15 bits here - at the interface level we could as well
> >> permit more bits right away; the implementation would reject too high
> >> a value, of course. Not only with this I further wonder whether the
> >> field shouldn't be unsplit while extending it. You won't get away
> >> without bumping XEN_DOMCTL_INTERFACE_VERSION anyway (unless it was
> >> bumped already for 4.17) since afaics the unused bits of this field
> >> previously weren't checked for being zero. We could easily have 8
> >> bits vector, 16 bits flags, and 32 bits destination ID in the struct.
> >> And there would then still be 8 unused bits (which from now on we
> >> ought to check for being zero).
> > 
> > So I've made gflags a 64bit field, used the high 32bits for the
> > destination ID, and the low ones for flags. I've left gvec as a
> > separate field in the struct, as I don't want to require a
> > modification to QEMU, just a rebuild against the updated headers will
> > be enough.
> 
> Hmm, wait - if qemu uses this without going through a suitable
> abstraction in at least libxc, then we cannot _ever_ change this
> interface: If a rebuild was required, old qemu binaries would
> stop working with newer Xen. If such a dependency indeed exists,
> we'll need a prominent warning comment in the public header.

Hm, it's bad. The xc_domain_update_msi_irq interface uses a gflags
parameter that's the gflags parameter of xen_domctl_bind_pt_irq. Which
is even worse because it's not using the mask definitions from
domctl.h, but rather a copy of them named XEN_PT_GFLAGS_* that are
hardcoded in xen_pt_msi.c in QEMU code.

So we can likely expand the layout of gflags, but moving fields is not
an option. I think my original proposal of adding a
XEN_DOMCTL_VMSI_X86_EXT_DEST_ID_MASK mask is the less bad option until
we add a new stable interface for device passthrough for QEMU.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Feb 04 09:57:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 09:57:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265325.458668 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFvLS-00074I-05; Fri, 04 Feb 2022 09:57:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265325.458668; Fri, 04 Feb 2022 09:57:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFvLR-00074B-TG; Fri, 04 Feb 2022 09:57:33 +0000
Received: by outflank-mailman (input) for mailman id 265325;
 Fri, 04 Feb 2022 09:57:32 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nFvLQ-000744-QN
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 09:57:32 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nFvLQ-0006B3-4j; Fri, 04 Feb 2022 09:57:32 +0000
Received: from 54-240-197-225.amazon.com ([54.240.197.225] helo=[192.168.2.73])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nFvLP-0000br-Up; Fri, 04 Feb 2022 09:57:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=1kudkR96MbM2oMcKiRN9cRxXSLnW1OKFSnC0kW4HfqI=; b=Fuef2VxD3AbYbQ5bhmubHL9BTi
	565oxp+QNtl1EoJKT9xaG1KOyOK+3e+uiMaaYH/+f4ygtiOjAeGnfs8O9Ohvl6akG3ekbpBrcTc61
	A6O7VqpLM9lnnac6KuU00NcOg7y0VQB482MvGrFshzpjO4y1Edrgynju+FkM5/dduqAk=;
Message-ID: <ad90a3df-7049-8ff2-979a-dec3b8c542a1@xen.org>
Date: Fri, 4 Feb 2022 09:57:29 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.1
Subject: Re: [PATCH v6 01/13] xen/pci: arm: add stub for is_memory_hole
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Artem Mygaiev <Artem_Mygaiev@epam.com>,
 "roger.pau@citrix.com" <roger.pau@citrix.com>,
 "jbeulich@suse.com" <jbeulich@suse.com>,
 "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
 "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
 "paul@xen.org" <paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-2-andr2000@gmail.com>
 <000ac24e-fdac-855d-7fb4-2165a1192ea4@xen.org>
 <19e50632-5865-9a75-756b-88db85007e96@epam.com>
 <d9741ff0-2152-6792-5249-09e3b0960972@xen.org>
 <43cab3d0-1a62-dca0-0d2d-5ea8fe237b21@epam.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <43cab3d0-1a62-dca0-0d2d-5ea8fe237b21@epam.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 04/02/2022 09:47, Oleksandr Andrushchenko wrote:
>>> Could you please help me with the exact message you would like to see?
>>
>> Here a summary of the discussion (+ some my follow-up thoughts):
>>
>> is_memory_hole() was recently introduced on x86 (see commit 75cc460a1b8c "xen/pci: detect when BARs are not suitably positioned") to check whether the BAR are positioned outside of a valid memory range. This was introduced to work-around quirky firmware.
>>
>> In theory, this could also happen on Arm. In practice, this may not happen but it sounds better to sanity check that the BAR contains "valid" I/O range.
>>
>> On x86, this is implemented by checking the region is not described is in the e820. IIUC, on Arm, the BARs have to be positioned in pre-defined ranges. So I think it would be possible to implement is_memory_hole() by going through the list of hostbridges and check the ranges.
>>
>> But first, I'd like to confirm my understanding with Rahul, and others.
>>
>> If we were going to go this route, I would also rename the function to be better match what it is doing (i.e. it checks the BAR is correctly placed). As a potentially optimization/hardening for Arm, we could pass the hostbridge so we don't have to walk all of them.
> It seems this needs to live in the commit message then? So, it is easy to find
> as everything after "---" is going to be dropped on commit
I expect the function to be fully implemented before this is will be merged.

So if it is fully implemented, then a fair chunk of what I wrote would 
not be necessary to carry in the commit message.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Feb 04 10:13:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 10:13:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265336.458679 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFvaO-00010r-DO; Fri, 04 Feb 2022 10:13:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265336.458679; Fri, 04 Feb 2022 10:13:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFvaO-00010k-A1; Fri, 04 Feb 2022 10:13:00 +0000
Received: by outflank-mailman (input) for mailman id 265336;
 Fri, 04 Feb 2022 10:12:58 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=u+82=ST=epam.com=prvs=4034f0a382=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nFvaM-00010e-FD
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 10:12:58 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 04f8f4f2-85a3-11ec-8eb8-a37418f5ba1a;
 Fri, 04 Feb 2022 11:12:56 +0100 (CET)
Received: from pps.filterd (m0174677.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 2149uVa1021342;
 Fri, 4 Feb 2022 10:12:52 GMT
Received: from eur04-vi1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2054.outbound.protection.outlook.com [104.47.14.54])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e0w09rxes-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 04 Feb 2022 10:12:52 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by PR2PR03MB5401.eurprd03.prod.outlook.com (2603:10a6:101:1c::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.14; Fri, 4 Feb
 2022 10:12:46 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6%3]) with mapi id 15.20.4951.014; Fri, 4 Feb 2022
 10:12:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 04f8f4f2-85a3-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Yx1FamAwJF04XI8M8vqUj/uuWnPJuG/VLQ+wSVl5ae1h+j4BEEdffP2bxVHKqbBF1C23gprWb0dFBGeterPmgPVma58pzMry7wSdQeeMpJ8CHTwB2I4ZqOC0b0ZUfd4Tz8N8iplwfguEPV/8Ca1q4mRsVfYnTwp5G2j7vZutrwHc4Cf3PZ7suVZR2UjLk91LEBNKn0OZ5ezR/QeO5IIlrI7gC/BHOZ7qb7v30WzZRfHSoSFsAASttVVu/S9AjC0HHL6kLqZFvqzqA4a2n5t5JE4HwD25LuIrZaWhlZrp7sdQSJXkl5I80cp3gdTz9TQXMjVbVWBUq16/y1OWkZq36A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=lan3w+B6wLdQLQIObMyeJ+WNYXc6b0/eavTQ2i6H3HQ=;
 b=GflQYPOWoWmFwpjgUb9rAEEGfwuTwtxEfXCMF865bSPkbWHx5GmdEOeWKlIaGW0eBvlKmXmf2T0f6Q4m0F1wXJdAoVygDGw0pUE1QQLVWPb2Vmh5QCS2pNmA9EdEQk9Fs0Gv3BkuTCFYykGR9mQeYh5PO0zBAg5DtLFeDHzLjzTDeCbXDv1p+IMRxuLqWL54DMSefnJC4Owxg+70wrj7bTYXTQ9mEShpXh41QHSDCk2mpfjofQ5yLuqMN+p4Sh/oLvWHQkWDREDvF+0+RNlLbtvveRvTk2HVfbv+Xh99FIi8v6VKXf7VFPC6uuRCIiA3JjPi8t89u+4m592YSytyjA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=lan3w+B6wLdQLQIObMyeJ+WNYXc6b0/eavTQ2i6H3HQ=;
 b=JXWqVO+JDsJE7Fd51fd9MDjYL/c0gjixdWhBQF3J7248meFshwC7q5694mlEHvjaxM7moYKoY0xZlRKlI/TnI1njHVd6JJ0TW6efMrJL+ciWNHH1EaWbVwTGFc7zTW1intMdLvn6xhfE/h62jUxHBZwbJwLAB7hhrv28JD12WAVyK+i8by+7aslJg6uUQjBDZa+LoUN6nUICntW9yPvfKQIFAkOhJRN2inE1heMpwLRs/FjvPX1CHlFvXidk9yjlgl6eg0Oeaj2Cs8p7cOS3vWIm8SC87iFXG4mr6z6+H3Q6ooNNu3voLj6uHE95N47HW3fcWsreT0Q5fZS/9V3Qug==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        "roger.pau@citrix.com"
	<roger.pau@citrix.com>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Thread-Topic: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Thread-Index: AQHYGZFc/MnzQOjwVEeBBUHLSW0md6yDBUkAgAASSACAAATYAIAAD/WA
Date: Fri, 4 Feb 2022 10:12:46 +0000
Message-ID: <9ed3f4ac-0a2d-ed45-9872-7c3f356a469e@epam.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-4-andr2000@gmail.com>
 <7209889d-8f17-61cc-72a4-97f6dbc1d54d@suse.com>
 <2cf022f8-b000-11b7-c6b9-90a56bc6e2ea@epam.com>
 <04726915-f39f-9019-436e-4399533c9fc3@suse.com>
In-Reply-To: <04726915-f39f-9019-436e-4399533c9fc3@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 880cf1bd-577c-4c0f-cf6d-08d9e7c6e42e
x-ms-traffictypediagnostic: PR2PR03MB5401:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <PR2PR03MB540110DC472D52760708988FE7299@PR2PR03MB5401.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 DvZEeyXZpeHwnw6c1newIKQwZaEf4E8wKAMrN2UoQxjOoER26TziO5hBA5wrrQEkVmOV1Lr0L/ks5Z7WoVrNcmSMTFH14pF4fZeG6jQnSiCEo+cXLeDa8EbmcQ29EEzCEpiPPwzQn8Wrpu+oGdFQvYxF+Mlwa0uDdRSBy9paeh0x6mMP3EkLfXJ2rR8EJON+AHRmScX9qlTaQdEJoOyUYISZSOImL559+jvMWvaz+uV3pDKvssljjOvnCDAuMyOPYemP1xzasktNFQC00AEpnnuxt9x/qcT2CkXjwJVhqq1M+zBvmrfZMyFwAtZRWVx1MxkbhqkAa++iqXt2vpHezmqIwRnRl/JVhHJAoed4vVydDqSlnFHxheAJYwWIySfEZsQSi72DQH8b42+tF8jmp8n9JWr51oDcUVWnS0hD3PmQlUDe2GRP50FdCaw6HUa2xMqmVb29HbgUZcitYAuqYlgBwSAq5hk/WIPCGM1Is+WaiymscSAz4j8PIb3QCLQdjD8eEpjmVQEd+UtMMUcK5mghCfaIBrzHSb3u76/mdNyS5Y6gDdtQlPJ/q72mjWwlBS/BhavxKwLdhhOYKx4EKuWIl2XZ3fxhHQBzOc+WidhKfpWMS+3z75r1/D1/JInjKDNvfltERo4M0mL8H37hMHUtm/qd9Uf+2pj3i58wLXuLMvQoOKKTlaiVdn9Vnkx2NzvI7/WjaDIoH3L+ckjDsd2zvVkj83sMJ/ccjmrZLel+ied7bWgEPdCreIoj2cxY
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6512007)(53546011)(6506007)(38070700005)(2906002)(122000001)(107886003)(83380400001)(91956017)(316002)(86362001)(2616005)(31696002)(71200400001)(36756003)(66556008)(66946007)(7416002)(8936002)(66476007)(66446008)(64756008)(31686004)(76116006)(508600001)(4326008)(54906003)(8676002)(38100700002)(5660300002)(6916009)(186003)(26005)(6486002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?b2k2YWdnU1hnU1k0SVIrbzlVZlpWN3pycFdXMU9RcllZazRGL2lJQ1JtOEcz?=
 =?utf-8?B?eHh2VnA3UWt5N21JWDdXUG1LWGJuVDlWQ0hGNjE0T0oxbmJsQmlLSUJuY3NM?=
 =?utf-8?B?VUdOZExoZVFxZkRCWk5FU0hWWVpXQlJhNE96MFYyRFFCL0FsYmIrV0QrM08w?=
 =?utf-8?B?UElhemV5dkM3c0F1UWZqT000K0RyYnh6Z3BNZEY1NDAwRkNDejh4UVdaVnFX?=
 =?utf-8?B?Y2pWRGtHR2NyOFk1OUpqYnJXbXUwSVFmNm83a3lLYXFUSG9ZZHIrc29TaFhp?=
 =?utf-8?B?N3owWExmOTE3MWhtV3oyWDQ5czFyaG9Qbno3eVRSWmVtU0ZqVi9TeHdGT2xG?=
 =?utf-8?B?NEJsV0lDemtFdjgzKzI4T2xXbmlTdjFkRU4xTmVwUWFEbE0wUVB4MktuTUNY?=
 =?utf-8?B?VnVLTDdkdnRmcmNyZ3N5cXd3TmZ4K0V4ZkN0TElLbWtqb3pVWEw5cEdWQkVh?=
 =?utf-8?B?T3VOamRNakhvV3J1OE04ZmNFNlJhcXM4OHlKM1k2SGxoY1NQMy9QSURLdkdK?=
 =?utf-8?B?UmdxVzIxWmFBVDRhYTlHTE9IcXFXNnFaa3VCSEd5ME1QYXQyOVJWc0RqeDBX?=
 =?utf-8?B?UzBPbTIyb01lL1krWW9TOU8yQ0lYQmhCTEpCdGIwdGNnbk9vejNpa1kzUmI4?=
 =?utf-8?B?MlVxVjBQVnNkVzU2NzJyL20wdjRHMjFsOVc2aVpFMy8xK25lYkhoYmVYUS9t?=
 =?utf-8?B?ZGNsazdad1V5cTEyUTZFTlFXSE9aZmZENkVFMTdGS3YzVjBFOUQvVlNHNVhn?=
 =?utf-8?B?azlnejNXZG4rckZ3bWFOR0d6VE43Qk5PdDJVMU40Wm9qQ2tBaTJuRENaSkRH?=
 =?utf-8?B?SStxYlJqY0VBUmw5eTY5NStuT016b1BuV3B5bUszaUl6TWxVVlhKVGdRRzhK?=
 =?utf-8?B?eHpUcHRZczBtMjFtbFFRM1VPaWVSclpLMTFLQ25IUjlDTjB3NWdjenNIMU5n?=
 =?utf-8?B?TzU1U2JuQUtPeTJWRE9uNUJZaHVZcTJJd1ZMSGJyQWNtaWQ3WnU0eFpzN1lx?=
 =?utf-8?B?S3RsbnBhYU1KVW5pYUc2QkpqMUM0dGQrQ2RSZHVKVUNMN2ZIMjRrYTFOUy9a?=
 =?utf-8?B?TUVwT1FSZW9qK3hRZmMvdFhHYXJaaEZBVmdhM0ZRTXVyQU0wWTFINjk5dHJS?=
 =?utf-8?B?ZHJFMzhaaFFsclg1RkhBZlU1WUtwLy9jMjZON1hwUFErUHc3QmZNWSs2bEFO?=
 =?utf-8?B?Wll1OEhHeE83U3dQVUpNVG1jSWhERjlMYnNBeVAzMXptZGQySWNsUGRRYWJp?=
 =?utf-8?B?anF5TmxoZHlMOWRPYVBqTmE3N1VPM2NMT0tGMStxdGdWTUIvMTc1S2VNN2l5?=
 =?utf-8?B?WWQ1V2g4K3l4WFZNNkNWbjY0OWw4Zk13ajN5c0NneWJlcXNweldrd000V1d3?=
 =?utf-8?B?cWNleldSVnZneEdmN3hTT1QwbW45NWZCdUVaRGROcllYRlh5MTNCSGszaEQv?=
 =?utf-8?B?WVNZdWZKeWFZM2FrZXlNMEVHMjdXU2VTUnpaR1c4cmMzRWRPQ3U1T0E4RWxT?=
 =?utf-8?B?SWk5NGJOc0ViYnE5c0szamNlaC9UQU5relE4NDlxYzhLVUtKL1VSaEtybGNS?=
 =?utf-8?B?YUtBTWk3dDFENFROaTJMcXFiVGJKQkVNUGpGeGJGbER2YzBMcUEyMmRwQmhN?=
 =?utf-8?B?RWcrTSszTDdXR0YwZnFHMm9hcllOck4wbCttT0hnRG1lZDI3M3FEMGhycXhK?=
 =?utf-8?B?cmptNU9wQzN2TTFhNFRuQzFud2dMK2xPWDhFbkFHblNINXNZWDJjcTlNaVBp?=
 =?utf-8?B?bDN2QkhZTTErdlNyUVRteW82VVlhRkZNM0VvWUpMZ0NabUdKam1iUVk2ZEoy?=
 =?utf-8?B?WE9LYlREZGdxWjdPZGFKVGlrZytKVnFaeW5uVGtJLzZtUGJXcituSmkxN1VB?=
 =?utf-8?B?eU5adFhEZDcrWWRTeHM4MkwwQjRVNkVma2pMSHRGeENJQkxiWlhJV0tIWEpQ?=
 =?utf-8?B?WWNTdDJZWFo3NDlidlZnVSttTkxPZGJta09tREIvb3pVL3NJL3FKRWl5eUVE?=
 =?utf-8?B?KzVQRG9SR0lrZklmeUoxQkp6OWV1ME5ORm96aFJmaVpJYVhnNDhiRUhONEo2?=
 =?utf-8?B?UERnTVlncUZXWExXaUlBbXk2bUlVb2Qrc0xQMUM4ZFBoeVVHMEtTRU1zeitp?=
 =?utf-8?B?cTgxM0NpeEQzSGxHZFgwK1VPL21WOXlLOCsrcTFaamc3NlBDTXo0bVY1S1pr?=
 =?utf-8?B?M2o0blNMbDlSdWtyVUYwaFZrNVB4WEVZTkQzYzBVK045OWdjVklwQ3FXNXBD?=
 =?utf-8?B?VEdsZ3haMzhCbjUzdC9oK1d6ZytIRy8xRTZ4V29QME9HVWNBT1FITjg4RVNz?=
 =?utf-8?B?QUdSYm9tdzNReE1BVUZka2M5ZXVzalhMZXZqZU1ZN2llVWF0TU1nZz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <4D88AA8C4F1B684FBB15D3FD8A360A48@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 880cf1bd-577c-4c0f-cf6d-08d9e7c6e42e
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Feb 2022 10:12:46.6512
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: dO9ni+yK6JXGRMvuT/CWeBfVlJ3Y8bC9G3DX9XV+nRkOhAT6SEg8NTJ1S5wqJnt+h24Csjj7YkRBYiF0+nVuK0EaYvoQk5BvC8CtL1sq+M8lVyuttpUVc1GOY0LBzrof
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR2PR03MB5401
X-Proofpoint-GUID: WIOLyfmisHilC6SkauVkicusiHbgZ7Dz
X-Proofpoint-ORIG-GUID: WIOLyfmisHilC6SkauVkicusiHbgZ7Dz
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-04_03,2022-02-03_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0
 lowpriorityscore=0 phishscore=0 clxscore=1015 adultscore=0 suspectscore=0
 priorityscore=1501 malwarescore=0 mlxscore=0 spamscore=0 mlxlogscore=999
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202040055

SGksIEphbiENCg0KT24gMDQuMDIuMjIgMTE6MTUsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAw
NC4wMi4yMDIyIDA5OjU4LCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyB3cm90ZToNCj4+IE9uIDA0
LjAyLjIyIDA5OjUyLCBKYW4gQmV1bGljaCB3cm90ZToNCj4+PiBPbiAwNC4wMi4yMDIyIDA3OjM0
LCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyB3cm90ZToNCj4+Pj4gQEAgLTI4NSw2ICsyODYsMTIg
QEAgc3RhdGljIGludCBtb2RpZnlfYmFycyhjb25zdCBzdHJ1Y3QgcGNpX2RldiAqcGRldiwgdWlu
dDE2X3QgY21kLCBib29sIHJvbV9vbmx5KQ0KPj4+PiAgICAgICAgICAgICAgICAgICAgY29udGlu
dWU7DQo+Pj4+ICAgICAgICAgICAgfQ0KPj4+PiAgICANCj4+Pj4gKyAgICAgICAgc3Bpbl9sb2Nr
KCZ0bXAtPnZwY2lfbG9jayk7DQo+Pj4+ICsgICAgICAgIGlmICggIXRtcC0+dnBjaSApDQo+Pj4+
ICsgICAgICAgIHsNCj4+Pj4gKyAgICAgICAgICAgIHNwaW5fdW5sb2NrKCZ0bXAtPnZwY2lfbG9j
ayk7DQo+Pj4+ICsgICAgICAgICAgICBjb250aW51ZTsNCj4+Pj4gKyAgICAgICAgfQ0KPj4+PiAg
ICAgICAgICAgIGZvciAoIGkgPSAwOyBpIDwgQVJSQVlfU0laRSh0bXAtPnZwY2ktPmhlYWRlci5i
YXJzKTsgaSsrICkNCj4+Pj4gICAgICAgICAgICB7DQo+Pj4+ICAgICAgICAgICAgICAgIGNvbnN0
IHN0cnVjdCB2cGNpX2JhciAqYmFyID0gJnRtcC0+dnBjaS0+aGVhZGVyLmJhcnNbaV07DQo+Pj4+
IEBAIC0zMDMsMTIgKzMxMCwxNCBAQCBzdGF0aWMgaW50IG1vZGlmeV9iYXJzKGNvbnN0IHN0cnVj
dCBwY2lfZGV2ICpwZGV2LCB1aW50MTZfdCBjbWQsIGJvb2wgcm9tX29ubHkpDQo+Pj4+ICAgICAg
ICAgICAgICAgIHJjID0gcmFuZ2VzZXRfcmVtb3ZlX3JhbmdlKG1lbSwgc3RhcnQsIGVuZCk7DQo+
Pj4+ICAgICAgICAgICAgICAgIGlmICggcmMgKQ0KPj4+PiAgICAgICAgICAgICAgICB7DQo+Pj4+
ICsgICAgICAgICAgICAgICAgc3Bpbl91bmxvY2soJnRtcC0+dnBjaV9sb2NrKTsNCj4+Pj4gICAg
ICAgICAgICAgICAgICAgIHByaW50ayhYRU5MT0dfR19XQVJOSU5HICJGYWlsZWQgdG8gcmVtb3Zl
IFslbHgsICVseF06ICVkXG4iLA0KPj4+PiAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0YXJ0
LCBlbmQsIHJjKTsNCj4+Pj4gICAgICAgICAgICAgICAgICAgIHJhbmdlc2V0X2Rlc3Ryb3kobWVt
KTsNCj4+Pj4gICAgICAgICAgICAgICAgICAgIHJldHVybiByYzsNCj4+Pj4gICAgICAgICAgICAg
ICAgfQ0KPj4+PiAgICAgICAgICAgIH0NCj4+Pj4gKyAgICAgICAgc3Bpbl91bmxvY2soJnRtcC0+
dnBjaV9sb2NrKTsNCj4+Pj4gICAgICAgIH0NCj4+PiBBdCB0aGUgZmlyc3QgZ2xhbmNlIHRoaXMg
c2ltcGx5IGxvb2tzIGxpa2UgYW5vdGhlciB1bmp1c3RpZmllZCAoaW4gdGhlDQo+Pj4gZGVzY3Jp
cHRpb24pIGNoYW5nZSwgYXMgeW91J3JlIG5vdCBjb252ZXJ0aW5nIGFueXRoaW5nIGhlcmUgYnV0
IHlvdQ0KPj4+IGFjdHVhbGx5IGFkZCBsb2NraW5nIChhbmQgSSByZWFsaXplIHRoaXMgd2FzIHRo
ZXJlIGJlZm9yZSwgc28gSSdtIHNvcnJ5DQo+Pj4gZm9yIG5vdCBwb2ludGluZyB0aGlzIG91dCBl
YXJsaWVyKS4NCj4+IFdlbGwsIEkgdGhvdWdodCB0aGF0IHRoZSBkZXNjcmlwdGlvbiBhbHJlYWR5
IGhhcyAiLi4udGhlIGxvY2sgY2FuIGJlDQo+PiB1c2VkIChhbmQgaW4gYSBmZXcgY2FzZXMgaXMg
dXNlZCByaWdodCBhd2F5KSB0byBjaGVjayB3aGV0aGVyIHZwY2kNCj4+IGlzIHByZXNlbnQiIGFu
ZCB0aGlzIGlzIGVub3VnaCBmb3Igc3VjaCB1c2VzIGFzIGhlcmUuDQo+Pj4gICAgQnV0IHRoZW4g
SSB3b25kZXIgd2hldGhlciB5b3UNCj4+PiBhY3R1YWxseSB0ZXN0ZWQgdGhpcywgc2luY2UgSSBj
YW4ndCBoZWxwIGdldHRpbmcgdGhlIGltcHJlc3Npb24gdGhhdA0KPj4+IHlvdSdyZSBpbnRyb2R1
Y2luZyBhIGxpdmUtbG9jazogVGhlIGZ1bmN0aW9uIGlzIGNhbGxlZCBmcm9tIGNtZF93cml0ZSgp
DQo+Pj4gYW5kIHJvbV93cml0ZSgpLCB3aGljaCBpbiB0dXJuIGFyZSBjYWxsZWQgb3V0IG9mIHZw
Y2lfd3JpdGUoKS4gWWV0IHRoYXQNCj4+PiBmdW5jdGlvbiBhbHJlYWR5IGhvbGRzIHRoZSBsb2Nr
LCBhbmQgdGhlIGxvY2sgaXMgbm90IChjdXJyZW50bHkpDQo+Pj4gcmVjdXJzaXZlLiAoRm9yIHRo
ZSAzcmQgY2FsbGVyIG9mIHRoZSBmdW5jdGlvbiAtIGluaXRfYmFycygpIC0gb3RvaA0KPj4+IHRo
ZSBsb2NraW5nIGxvb2tzIHRvIGJlIGVudGlyZWx5IHVubmVjZXNzYXJ5LikNCj4+IFdlbGwsIHlv
dSBhcmUgY29ycmVjdDogaWYgdG1wICE9IHBkZXYgdGhlbiBpdCBpcyBjb3JyZWN0IHRvIGFjcXVp
cmUNCj4+IHRoZSBsb2NrLiBCdXQgaWYgdG1wID09IHBkZXYgYW5kIHJvbV9vbmx5ID09IHRydWUN
Cj4+IHRoZW4gd2UnbGwgZGVhZGxvY2suDQo+Pg0KPj4gSXQgc2VlbXMgd2UgbmVlZCB0byBoYXZl
IHRoZSBsb2NraW5nIGNvbmRpdGlvbmFsLCBlLmcuIG9ubHkgbG9jaw0KPj4gaWYgdG1wICE9IHBk
ZXYNCj4gV2hpY2ggd2lsbCBhZGRyZXNzIHRoZSBsaXZlLWxvY2ssIGJ1dCBpbnRyb2R1Y2UgQUJC
QSBkZWFkbG9jayBwb3RlbnRpYWwNCj4gYmV0d2VlbiB0aGUgdHdvIGxvY2tzLg0KSSBhbSBub3Qg
c3VyZSBJIGNhbiBzdWdnZXN0IGEgYmV0dGVyIHNvbHV0aW9uIGhlcmUNCkBSb2dlciwgQEphbiwg
Y291bGQgeW91IHBsZWFzZSBoZWxwIGhlcmU/DQo+DQo+Pj4+IEBAIC0yMjIsMTAgKzIzOSwxMCBA
QCBzdGF0aWMgaW50IG1zaXhfcmVhZChzdHJ1Y3QgdmNwdSAqdiwgdW5zaWduZWQgbG9uZyBhZGRy
LCB1bnNpZ25lZCBpbnQgbGVuLA0KPj4+PiAgICAgICAgICAgICAgICBicmVhazsNCj4+Pj4gICAg
ICAgICAgICB9DQo+Pj4+ICAgIA0KPj4+PiArICAgICAgICBtc2l4X3B1dChtc2l4KTsNCj4+Pj4g
ICAgICAgICAgICByZXR1cm4gWDg2RU1VTF9PS0FZOw0KPj4+PiAgICAgICAgfQ0KPj4+PiAgICAN
Cj4+Pj4gLSAgICBzcGluX2xvY2soJm1zaXgtPnBkZXYtPnZwY2ktPmxvY2spOw0KPj4+PiAgICAg
ICAgZW50cnkgPSBnZXRfZW50cnkobXNpeCwgYWRkcik7DQo+Pj4+ICAgICAgICBvZmZzZXQgPSBh
ZGRyICYgKFBDSV9NU0lYX0VOVFJZX1NJWkUgLSAxKTsNCj4+PiBZb3UncmUgaW5jcmVhc2luZyB0
aGUgbG9ja2VkIHJlZ2lvbiBxdWl0ZSBhIGJpdCBoZXJlLiBJZiB0aGlzIGlzIHJlYWxseQ0KPj4+
IG5lZWRlZCwgaXQgd2FudHMgZXhwbGFpbmluZy4gQW5kIGlmIHRoaXMgaXMgZGVlbWVkIGFjY2Vw
dGFibGUgYXMgYQ0KPj4+ICJzaWRlIGVmZmVjdCIsIGl0IHdhbnRzIGp1c3RpZnlpbmcgb3IgYXQg
bGVhc3Qgc3RhdGluZyBpbW8uIFNhbWUgZm9yDQo+Pj4gbXNpeF93cml0ZSgpIHRoZW4sIG9idmlv
dXNseS4NCj4+IFllcywgSSBkbyBpbmNyZWFzZSB0aGUgbG9ja2luZyByZWdpb24gaGVyZSwgYnV0
IHRoZSBtc2l4IHZhcmlhYmxlIG5lZWRzDQo+PiB0byBiZSBwcm90ZWN0ZWQgYWxsIHRoZSB0aW1l
LCBzbyBpdCBzZWVtcyB0byBiZSBvYnZpb3VzIHRoYXQgaXQgcmVtYWlucw0KPj4gdW5kZXIgdGhl
IGxvY2sNCj4gV2hhdCBkb2VzIHRoZSBtc2l4IHZhcmlhYmxlIGhhdmUgdG8gZG8gd2l0aCB0aGUg
dlBDSSBsb2NrPyBJZiB5b3Ugc2VlDQo+IGEgbmVlZCB0byBncm93IHRoZSBsb2NrZWQgcmVnaW9u
IGhlcmUsIHRoZW4gc3VyZWx5IHRoaXMgaXMgaW5kZXBlbmRlbnQNCj4gb2YgeW91ciBjb252ZXJz
aW9uIG9mIHRoZSBsb2NrLCBhbmQgaGVuY2Ugd2FudHMgdG8gYmUgYSBwcmVyZXEgZml4DQo+ICh3
aGljaCBtYXkgaW4gZmFjdCB3YW50L25lZWQgYmFja3BvcnRpbmcpLg0KRmlyc3Qgb2YgYWxsLCB0
aGUgaW1wbGVtZW50YXRpb24gb2YgbXNpeF9nZXQgaXMgd3JvbmcgYW5kIG5lZWRzIHRvIGJlOg0K
DQovKg0KIMKgKiBOb3RlOiBpZiB2cGNpX21zaXggZm91bmQsIHRoZW4gdGhpcyBmdW5jdGlvbiBy
ZXR1cm5zIHdpdGgNCiDCoCogcGRldi0+dnBjaV9sb2NrIGhlbGQuIFVzZSBtc2l4X3B1dCB0byB1
bmxvY2suDQogwqAqLw0Kc3RhdGljIHN0cnVjdCB2cGNpX21zaXggKm1zaXhfZ2V0KGNvbnN0IHN0
cnVjdCBkb21haW4gKmQsIHVuc2lnbmVkIGxvbmcgYWRkcikNCnsNCiDCoMKgwqAgc3RydWN0IHZw
Y2lfbXNpeCAqbXNpeDsNCg0KIMKgwqDCoCBsaXN0X2Zvcl9lYWNoX2VudHJ5ICggbXNpeCwgJmQt
PmFyY2guaHZtLm1zaXhfdGFibGVzLCBuZXh0ICkNCiDCoMKgwqAgew0KIMKgwqDCoMKgwqDCoMKg
IGNvbnN0IHN0cnVjdCB2cGNpX2JhciAqYmFyczsNCiDCoMKgwqDCoMKgwqDCoCB1bnNpZ25lZCBp
bnQgaTsNCg0KIMKgwqDCoMKgwqDCoMKgIHNwaW5fbG9jaygmbXNpeC0+cGRldi0+dnBjaV9sb2Nr
KTsNCiDCoMKgwqDCoMKgwqDCoCBpZiAoICFtc2l4LT5wZGV2LT52cGNpICkNCiDCoMKgwqDCoMKg
wqDCoCB7DQogwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBzcGluX3VubG9jaygmbXNpeC0+cGRldi0+
dnBjaV9sb2NrKTsNCiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGNvbnRpbnVlOw0KIMKgwqDCoMKg
wqDCoMKgIH0NCg0KIMKgwqDCoMKgwqDCoMKgIGJhcnMgPSBtc2l4LT5wZGV2LT52cGNpLT5oZWFk
ZXIuYmFyczsNCiDCoMKgwqDCoMKgwqDCoCBmb3IgKCBpID0gMDsgaSA8IEFSUkFZX1NJWkUobXNp
eC0+dGFibGVzKTsgaSsrICkNCiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGlmICggYmFyc1ttc2l4
LT50YWJsZXNbaV0gJiBQQ0lfTVNJWF9CSVJNQVNLXS5lbmFibGVkICYmDQogwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqAgVk1TSVhfQUREUl9JTl9SQU5HRShhZGRyLCBtc2l4LT5wZGV2
LT52cGNpLCBpKSApDQogwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHJldHVybiBtc2l4
Ow0KDQogwqDCoMKgwqDCoMKgwqAgc3Bpbl91bmxvY2soJm1zaXgtPnBkZXYtPnZwY2lfbG9jayk7
DQogwqDCoMKgIH0NCg0KIMKgwqDCoCByZXR1cm4gTlVMTDsNCn0NCg0KVGhlbiwgYm90aCBtc2l4
X3tyZWFkfHdyaXRlfSBjYW4gZGVyZWZlcmVuY2UgbXNpeC0+cGRldi0+dnBjaSBlYXJseSwNCnRo
aXMgaXMgd2h5IFJvZ2VyIHN1Z2dlc3RlZCB3ZSBtb3ZlIHRvIG1zaXhfe2dldHxwdXR9IGhlcmUu
DQpBbmQgeWVzLCB3ZSBncm93IHRoZSBsb2NrZWQgcmVnaW9uIGhlcmUgYW5kIHllcyB0aGlzIG1p
Z2h0IHdhbnQgYQ0KcHJlcmVxIGZpeC4gT3IganVzdCBiZSBmaXhlZCB3aGlsZSBhdCBpdC4NCg0K
Pg0KPj4+PiBAQCAtMzI3LDcgKzMzNCwxMiBAQCB1aW50MzJfdCB2cGNpX3JlYWQocGNpX3NiZGZf
dCBzYmRmLCB1bnNpZ25lZCBpbnQgcmVnLCB1bnNpZ25lZCBpbnQgc2l6ZSkNCj4+Pj4gICAgICAg
IGlmICggIXBkZXYgKQ0KPj4+PiAgICAgICAgICAgIHJldHVybiB2cGNpX3JlYWRfaHcoc2JkZiwg
cmVnLCBzaXplKTsNCj4+Pj4gICAgDQo+Pj4+IC0gICAgc3Bpbl9sb2NrKCZwZGV2LT52cGNpLT5s
b2NrKTsNCj4+Pj4gKyAgICBzcGluX2xvY2soJnBkZXYtPnZwY2lfbG9jayk7DQo+Pj4+ICsgICAg
aWYgKCAhcGRldi0+dnBjaSApDQo+Pj4+ICsgICAgew0KPj4+PiArICAgICAgICBzcGluX3VubG9j
aygmcGRldi0+dnBjaV9sb2NrKTsNCj4+Pj4gKyAgICAgICAgcmV0dXJuIHZwY2lfcmVhZF9odyhz
YmRmLCByZWcsIHNpemUpOw0KPj4+PiArICAgIH0NCj4+PiBEaWRuJ3QgeW91IHNheSB5b3Ugd291
bGQgYWRkIGp1c3RpZmljYXRpb24gb2YgdGhpcyBwYXJ0IG9mIHRoZSBjaGFuZ2UNCj4+PiAoYW5k
IGl0cyB2cGNpX3dyaXRlKCkgY291bnRlcnBhcnQpIHRvIHRoZSBkZXNjcmlwdGlvbj8NCj4+IEFn
YWluLCBJIGFtIHJlZmVycmluZyB0byB0aGUgY29tbWl0IG1lc3NhZ2UgYXMgZGVzY3JpYmVkIGFi
b3ZlDQo+IE5vLCBzb3JyeSAtIHRoYXQgcGFydCBhcHBsaWVzIG9ubHkgdG8gd2hhdCBpbnNpZGUg
dGhlIHBhcmVudGhlc2VzIG9mDQo+IGlmKCkuIEJ1dCBvbiB0aGUgaW50ZXJtZWRpYXRlIHZlcnNp
b24gKHBvc3QtdjUgaW4gYSA0LXBhdGNoIHNlcmllcykgSQ0KPiBkaWQgc2F5Og0KPg0KPiAiSW4g
dGhpcyBjYXNlIGFzIHdlbGwgYXMgaW4gaXRzIHdyaXRlIGNvdW50ZXJwYXJ0IGl0IGJlY29tZXMg
ZXZlbiBtb3JlDQo+ICAgaW1wb3J0YW50IHRvIGp1c3RpZnkgKGluIHRoZSBkZXNjcmlwdGlvbikg
dGhlIG5ldyBiZWhhdmlvci4gSXQgaXMgbm90DQo+ICAgb2J2aW91cyBhdCBhbGwgdGhhdCB0aGUg
YWJzZW5jZSBvZiBhIHN0cnVjdCB2cGNpIHNob3VsZCBiZSB0YWtlbiBhcw0KPiAgIGFuIGluZGlj
YXRpb24gdGhhdCB0aGUgdW5kZXJseWluZyBkZXZpY2UgbmVlZHMgYWNjZXNzaW5nIGluc3RlYWQu
DQo+ICAgVGhpcyBhbHNvIGNhbm5vdCBiZSBpbmZlcnJlZCBmcm9tIHRoZSAiIXBkZXYiIGNhc2Ug
dmlzaWJsZSBpbiBjb250ZXh0Lg0KPiAgIEluIHRoYXQgY2FzZSB3ZSBoYXZlIG5vIHJlY29yZCBv
ZiBhIGRldmljZSBhdCB0aGlzIFNCREYsIGFuZCBoZW5jZSB0aGUNCj4gICBmYWxsYmFjayBwcmV0
dHkgY2xlYXJseSBpcyBhICJqdXN0IGluIGNhc2UiIG9uZS4gWWV0IGlmIHdlIGtub3cgb2YgYQ0K
PiAgIGRldmljZSwgdGhlIGFic2VuY2Ugb2YgYSBzdHJ1Y3QgdnBjaSBtYXkgbWVhbiB2YXJpb3Vz
IHBvc3NpYmxlIHRoaW5ncy4iDQo+DQo+IElmIGl0IHdhc24ndCBvYnZpb3VzOiBUaGUgY29tbWVu
dCB3YXMgb24gdGhlIHVzZSBvZiB2cGNpX3JlYWRfaHcoKSBvbg0KPiB0aGlzIHBhdGgsIG5vdCBy
ZWR1bmRhbnQgd2l0aCB0aGUgZWFybGllciBvbmUgcmVnYXJkaW5nIHRoZSBhZGRlZA0KPiAiaXMg
dnBjaSBub24tTlVMTCIgaW4gYSBmZXcgcGxhY2VzLg0KT2sNCj4NCj4gSmFuDQo+DQpUaGFuayB5
b3UsDQpPbGVrc2FuZHI=


From xen-devel-bounces@lists.xenproject.org Fri Feb 04 10:20:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 10:20:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265345.458689 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFvhL-0002Ve-C4; Fri, 04 Feb 2022 10:20:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265345.458689; Fri, 04 Feb 2022 10:20:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFvhL-0002VX-8Q; Fri, 04 Feb 2022 10:20:11 +0000
Received: by outflank-mailman (input) for mailman id 265345;
 Fri, 04 Feb 2022 10:20:10 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1gJ0=ST=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nFvhK-0002VR-GM
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 10:20:10 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 077ad7fd-85a4-11ec-8eb8-a37418f5ba1a;
 Fri, 04 Feb 2022 11:20:09 +0100 (CET)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2057.outbound.protection.outlook.com [104.47.12.57]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-8-QS-joJExM3K01g8TZxL9yw-1; Fri, 04 Feb 2022 11:20:07 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM6PR04MB4726.eurprd04.prod.outlook.com (2603:10a6:20b:2::31) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Fri, 4 Feb
 2022 10:20:05 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.014; Fri, 4 Feb 2022
 10:20:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 077ad7fd-85a4-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1643970008;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=LyeK/RrCqmZMok1OHGy7O2IcgQoItYdzXUZHa2Q8kgI=;
	b=nzvvdgWNfhrq313AmOxV4YI4LBXh4+Uc60OwiHKz3ft8ECSfcTRdC3aqXm5mkqODBQN6Ik
	YNW7e91ue7ax84VeORJ31AwgNDGfW5ePd5UMXU3VVFZ55HppZXVcjeqkMtlcfHm9pmMVP0
	l9WkxUd+iV2nh049BS3YDm5VcinON60=
X-MC-Unique: QS-joJExM3K01g8TZxL9yw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=iTvb10pyIksaDz4KFoiDIyxgXBrRpSaRE7tTR5trLrCETWIghxcMWan3mNiZWrv1wFQfYiADNtELHGmkq7KsCrr1+wxt2/hkknCfnRz8BBK3VfY2iA6GxzmrP2WisvSQMv2JedmK9dwUlJXYRgrmxsqSkJLYAEwa1dJXnUWkFLKP8lKWJC8u0s4jFsHJgwk7Z6CMQrMNT2i2pUDGWeFZOL8pmq/dm+2NltCOkcOIlPa+5ocvXgKabo3LukcHgPJStjKy4K3gvf6LQ6n5hjBs3Y/J7suy0eq94qlmp9qfDL/xyqYtJATS/BPAsYOK0eS0CMF8BiwgQpPqTaTrSBmCeQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=7E++ERymDvabIr1oUezzU5LtSIFs2mCG00JeBUwT2v0=;
 b=Os+I7O7gVpnqfUBfFfrm0CvpbneSNZ2pSeMOoiIzY+UhFLJ8oFtg8bVcYu/Fc52VYoi9sXWYIgChLC/GSb0alw9ePlh7RB7Xp6nz9VNvbJzLNKhb6YiK+Dg72rA3PDhFQfrssHp9Uq3nQW5S9xbLg//AhZZUJ9TYnJksnOvy5+b6eDpDDZWPZR61FruZ9diiZBeTFQkTQYUgthx3Vz3VywQ21rs3rQIYUCgHHHEWzgzkjfj9N0ms8lXZ1rq0gPkprulhnO2dXzkd8bCxfVBC4EyRzPhJVWzMthjnd/Oc4ScXfses/hCvoNtUBME+MMrSaFNgBIyHvXFj/6RvN2xFGg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <7055da7d-42ed-5343-5065-38f338143e16@suse.com>
Date: Fri, 4 Feb 2022 11:20:03 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH 2/3] x86/vmsi: add support for extended destination ID in
 address field
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Paul Durrant <paul@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220120152319.7448-1-roger.pau@citrix.com>
 <20220120152319.7448-3-roger.pau@citrix.com>
 <2e96bf2e-a31e-da9b-2f08-adfa0928e5b9@suse.com>
 <YfzwepCoIvJ3cI0v@Air-de-Roger>
 <d4ff7ca4-e728-5f5a-e569-ae42fdf17157@suse.com>
 <Yfz3zLFpA3DWt27m@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Yfz3zLFpA3DWt27m@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM5PR0101CA0027.eurprd01.prod.exchangelabs.com
 (2603:10a6:206:16::40) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 0d573ae0-4b15-4cb0-c1c6-08d9e7c7e9ae
X-MS-TrafficTypeDiagnostic: AM6PR04MB4726:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB4726CE0713AC70215238881CB3299@AM6PR04MB4726.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	vrNTIUQ0FOVNN7nJANeTJ6hNI84kZZ+0NkrzGht5utdmsBvoQBKhUajD/klq8v+0n9BcJVCBSdku4Wl7UjYAa6qhUgRMyWHqSKILOywjT//3/NHaTp+2c5ZhxJ1zU0H0Cw1V4/f+gSY2DXY5LE8uy2hCwaPzXn/l9D1OB/QWfY8UAEMglvpf2eqRrg0Dk9Cr5A1+I2tL18t5zpGz9kKJ87uK0EHDzsbRvTAuYhLASudClK+OHiiesZOk/IpxW3WhKNY2PM7XgD9UpzsTF6BbByWhyM/jwyXLxthywTzdYXK4wFUvbBk3foXjthoE8nLM7GIXcJokXMz8ekhuwwXk2g2jTumxP3PxwcrA4nKARP6j/MmG3cUNQMQ+mnNNSm1pbP6nt5VNb636c+OHOsKToZgECcsViM35545aI5f7DtfXRt3FIdRe1zuWDTX2FbI6tjKBs5Do0d1ocKGO//clqnu8G+8h1OD7Dxz4bJPLGg8fiLScx/LnHcyhFkWj+LyB0Iv9zYDuBEK8lo6gJMg9FwWYS39uDWHeVAGJv9/dAu0vmdy18/xlaq0Z8mUcgC12uT1IE445VIu5U3E+CHvuLeYA78OaYLKlIRiy5ayvehRG4uCU2RPc0n1cdB/xfjGHLhtkVCi3Q9c1N/CAq4h5vymRNqBX2P4WwCKPO0YXXDvBuyUK+YMmByRSukQLHNdW24gJQ1dVLEVM0H1948WeutFObe5orcWbhPvX1KDy8Y4=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(31686004)(2906002)(316002)(36756003)(83380400001)(38100700002)(66556008)(6916009)(6486002)(26005)(5660300002)(8936002)(4326008)(6512007)(6506007)(66946007)(186003)(53546011)(66476007)(508600001)(31696002)(2616005)(54906003)(8676002)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?ulebB1+LTX/320jh2XulKqMk+Q/PxTTJuangXs22rUZgC+rM4MRxaCfMmDQA?=
 =?us-ascii?Q?mGTP+2HJmjQKaKrNkCkKxRxdzxrhMeXQdaQewaZ5RZKT7SId+EJ9dP0WeLLe?=
 =?us-ascii?Q?821KxSnlI6e7e2oXf+LSvvfM2WSMdnlyj74BWVrLyHt+75uK4+K5jeMx1zAO?=
 =?us-ascii?Q?Dfi3oqryGRXFQ4f6mnR2Bo+7OtqPqZfdsVUcLaJSu/XpImULSghP+1IScbik?=
 =?us-ascii?Q?VrExwZV5OThbi3I+KzYjQAgPLqxOQzVHXCAMSoK5ilbKslQQVz7wjTSpZ8cz?=
 =?us-ascii?Q?UFklDtFob2eMxjdlg/Bo/Je4NvANKEZBcLVy1KgsBTiqRJt1F4Xcev2z79Dq?=
 =?us-ascii?Q?ro2zB6A3kKDdhsIniUgCSuK/bI7A/ru1SMOh883ux3pSC13JrdVIxvsIvyFb?=
 =?us-ascii?Q?i3nVrHTqCWgkuAKXBN0KeuIzQW/7yO/75QGodHSd3bheXlprfl6HCCi0sRLx?=
 =?us-ascii?Q?0lvbXNS+5ismbQmiPWcz8FrVYTYsojFUQLEiTfn7HhUXunLSjsrv2ZKNHFsh?=
 =?us-ascii?Q?RIr1zaJBAOvufkaMHo3l+gWA6eUMgqlfuxuK0j5uFd2XxeMY3kjwKkEb8F56?=
 =?us-ascii?Q?CdFUuJk+Z9roH4qh4kOD2zuxJ1quk3hCPMmy8KwRXiqWSpfd+d2F/hpZeqJE?=
 =?us-ascii?Q?i7tv0m4bxeR0Tr1bHJrhSJT77ZhMEmKHnY+LqS5Le0iwXBjks9H3yi2tdZ0s?=
 =?us-ascii?Q?yV12tkzvk8CKAHc8QstxcjaLqb3LA4l2Mubmci9mxhiIimey6YqLDqLvkfez?=
 =?us-ascii?Q?xj9X6jujjXa60HRe9HmM6ktEsTD2V86uImLXSFs5k7vSqlVtRGaTsBYEeM++?=
 =?us-ascii?Q?AcdHGoqlpldNdEUkTxM4CtKYTF/VDfrUJOu2qu45JtfEFlzXxPWJ59DLjaZp?=
 =?us-ascii?Q?TJHyOcfH6y+aO4WL8QVzrz+v0eEMt0wVcE5A9tnZHC6Ig9QJC6I1ZP5YTFfG?=
 =?us-ascii?Q?JEMgiGzRdddKQDrNJbTl7OeCJd5TKW7YJsD4iNHQ90lnmcz0PAo9X1X9SsS7?=
 =?us-ascii?Q?vVqSXEz9OwRNPGu9dc7r4rwb46osjb4zlQcSU7biPC171PyQ2tQ8QYf6D9SO?=
 =?us-ascii?Q?cuO/gX8jMwBm1y296Vhtnk7JOjfBpNgxe89smUhDsXqA8dG2nrjispARJuJ6?=
 =?us-ascii?Q?DOTD5T3YzkI28pbumFKlZOCsPm7VUUW6dvdLc6CijJZC35Ep71XWNNZWVnBu?=
 =?us-ascii?Q?hCs0k6YMABOzCZOXimOXxL3JfIxXnR1NzrzenYO0ojxPSsRV2nLYY6+UtlQ0?=
 =?us-ascii?Q?AahV/S7fPKiOVeVvQ581dXdusnpQ85CYsu4PmqVXDOHNBEwHfKN39Wj/Fgmr?=
 =?us-ascii?Q?M5xR16WbzMtLpFuXJ3ZDpuw+P6RY/dPtYI+Rgxd/4hlD7fJAUaYvlUTgsD4L?=
 =?us-ascii?Q?v6P0VrFkxjCo9/6cjAqugzJLpUMy3GR/uKVN5myOUShjWB9I/47JIMHTG1fW?=
 =?us-ascii?Q?U+elnqqoBBE1OolUehnSBBxBkH66TVQukr8xwSapqKsist0rYPG1EayIFrNK?=
 =?us-ascii?Q?d4QURfFUw8FHQs6Vc0VIN34CvYHXTTGiNd0ipMVdaxY2e7QWbkRRAq3FI0rm?=
 =?us-ascii?Q?AX7ub1w/wDA42LD5hD5F3d7rFW3p2lESusfYPwz0sz5nplwnGb14zNe0sokJ?=
 =?us-ascii?Q?6mQNDY+xQVyZCfEbVKdyPnI=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0d573ae0-4b15-4cb0-c1c6-08d9e7c7e9ae
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Feb 2022 10:20:05.5938
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lF0FjB3y2ngT0s+8cHhQiZLSP6gKNG+/2mL9RTkPVz9qNtlpFYene7qKfPG5IHulidVDWG7ttg3R9yRCL9RWDA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4726

On 04.02.2022 10:54, Roger Pau Monn=C3=A9 wrote:
> On Fri, Feb 04, 2022 at 10:30:54AM +0100, Jan Beulich wrote:
>> On 04.02.2022 10:23, Roger Pau Monn=C3=A9 wrote:
>>> On Mon, Jan 24, 2022 at 02:47:58PM +0100, Jan Beulich wrote:
>>>> On 20.01.2022 16:23, Roger Pau Monne wrote:
>>>>> --- a/xen/arch/x86/include/asm/msi.h
>>>>> +++ b/xen/arch/x86/include/asm/msi.h
>>>>> @@ -54,6 +54,7 @@
>>>>>  #define MSI_ADDR_DEST_ID_SHIFT		12
>>>>>  #define	 MSI_ADDR_DEST_ID_MASK		0x00ff000
>>>>>  #define  MSI_ADDR_DEST_ID(dest)		(((dest) << MSI_ADDR_DEST_ID_SHIFT)=
 & MSI_ADDR_DEST_ID_MASK)
>>>>> +#define	 MSI_ADDR_EXT_DEST_ID_MASK	0x0000fe0
>>>>
>>>> Especially the immediately preceding macro now becomes kind of stale.
>>>
>>> Hm, I'm not so sure about that. We could expand the macro to place the
>>> high bits in dest at bits 11:4 of the resulting address. However that
>>> macro (MSI_ADDR_DEST_ID) is only used by Xen to compose its own
>>> messages, so until we add support for the hypervisor itself to use the
>>> extended destination ID mode there's not much point in modifying the
>>> macro IMO.
>>
>> Well, this is all unhelpful considering the different form of extended
>> ID in Intel's doc. At least by way of a comment things need clarifying
>> and potential pitfalls need pointing out imo.
>=20
> Sure, will add some comments there.
>=20
>>>>> --- a/xen/include/public/domctl.h
>>>>> +++ b/xen/include/public/domctl.h
>>>>> @@ -588,6 +588,7 @@ struct xen_domctl_bind_pt_irq {
>>>>>  #define XEN_DOMCTL_VMSI_X86_DELIV_MASK   0x007000
>>>>>  #define XEN_DOMCTL_VMSI_X86_TRIG_MASK    0x008000
>>>>>  #define XEN_DOMCTL_VMSI_X86_UNMASKED     0x010000
>>>>> +#define XEN_DOMCTL_VMSI_X86_EXT_DEST_ID_MASK 0xfe0000
>>>>
>>>> I'm not convinced it is a good idea to limit the overall destination
>>>> ID width to 15 bits here - at the interface level we could as well
>>>> permit more bits right away; the implementation would reject too high
>>>> a value, of course. Not only with this I further wonder whether the
>>>> field shouldn't be unsplit while extending it. You won't get away
>>>> without bumping XEN_DOMCTL_INTERFACE_VERSION anyway (unless it was
>>>> bumped already for 4.17) since afaics the unused bits of this field
>>>> previously weren't checked for being zero. We could easily have 8
>>>> bits vector, 16 bits flags, and 32 bits destination ID in the struct.
>>>> And there would then still be 8 unused bits (which from now on we
>>>> ought to check for being zero).
>>>
>>> So I've made gflags a 64bit field, used the high 32bits for the
>>> destination ID, and the low ones for flags. I've left gvec as a
>>> separate field in the struct, as I don't want to require a
>>> modification to QEMU, just a rebuild against the updated headers will
>>> be enough.
>>
>> Hmm, wait - if qemu uses this without going through a suitable
>> abstraction in at least libxc, then we cannot _ever_ change this
>> interface: If a rebuild was required, old qemu binaries would
>> stop working with newer Xen. If such a dependency indeed exists,
>> we'll need a prominent warning comment in the public header.
>=20
> Hm, it's bad. The xc_domain_update_msi_irq interface uses a gflags
> parameter that's the gflags parameter of xen_domctl_bind_pt_irq. Which
> is even worse because it's not using the mask definitions from
> domctl.h, but rather a copy of them named XEN_PT_GFLAGS_* that are
> hardcoded in xen_pt_msi.c in QEMU code.
>=20
> So we can likely expand the layout of gflags, but moving fields is not
> an option. I think my original proposal of adding a
> XEN_DOMCTL_VMSI_X86_EXT_DEST_ID_MASK mask is the less bad option until
> we add a new stable interface for device passthrough for QEMU.

Given the observations - yeah, not much of a choice left.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Feb 04 10:36:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 10:36:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265353.458701 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFvwl-00042i-Pp; Fri, 04 Feb 2022 10:36:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265353.458701; Fri, 04 Feb 2022 10:36:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFvwl-00042b-Lw; Fri, 04 Feb 2022 10:36:07 +0000
Received: by outflank-mailman (input) for mailman id 265353;
 Fri, 04 Feb 2022 10:36:06 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=u+82=ST=epam.com=prvs=4034f0a382=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nFvwk-00042V-Gj
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 10:36:06 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3e5bf5d2-85a6-11ec-8f75-fffcc8bd4f1a;
 Fri, 04 Feb 2022 11:36:01 +0100 (CET)
Received: from pps.filterd (m0174677.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 2149uVbk021292;
 Fri, 4 Feb 2022 10:35:57 GMT
Received: from eur01-ve1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2050.outbound.protection.outlook.com [104.47.1.50])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e0w09s182-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 04 Feb 2022 10:35:56 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM6PR03MB4279.eurprd03.prod.outlook.com (2603:10a6:20b:a::18) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Fri, 4 Feb
 2022 10:35:52 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6%3]) with mapi id 15.20.4951.014; Fri, 4 Feb 2022
 10:35:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3e5bf5d2-85a6-11ec-8f75-fffcc8bd4f1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=n2NvkHqx1wVvUvtsPev5bafIqT2ErVhc/tvXpfrzJfUx8xXwVupAZmSt5ErI9rJWhVlSayra91zFm3mFO5x4eXEanBdTq0kXpvafKb1H2TzSR9EzQGQ2YYHmzTHPOR1HXpsD8ILyMFdrJCkHA0ZK2Zo++Qsj5vJ6Pe+ID8sfUkXr0JrA7Lzn+3ApHSvHXH9OvdKALnuhNarTyqmbP1iIzjW/6fbIGApnD3uEJLs2DLNS+6NIBwrvt5rm8hd55dxe8h0eekjq3CSKJMSrlpN6LaknI6Yhxsmi9YNe0ep9Ne5o+midVRAX9mkQe8zT9QTYGb6oUba7IAyvGGNjS+uNMQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=SF09O8UfeTOzQNVYbgCroZZsXaWMbZHA4mqoWfu9hsY=;
 b=nhcmZMFXZmmMKmLGK2+WdWofcb3CoamrmaHlqnpBaE/yuH8KjLcfCCC9x0YCw0gBhgKyMGd+vSN1uk8guXhnzjRwZble7XIBxyIarEQ7L3dXZa04gDbB57DZHpLPrE7bfk5mKuipAxIub4KxGX80+S59VgP4jgVUAcsGvEtxTFMJkpZ25iBLhk++uKkMgpVz/IPhwX6I4Pg7LjR3v7dqPUsJGaO/Lr6N1G0NIQLb9SIANzlYk1IyisY9XuLqohIQsO4ZU+3Vxwp9vYVzou2c37h0WIMx5vVRSM1WKm6DkYR7R2eqXkp9H9pf+0u2Nlm31EUCCAD/gYqjHQKBJE1V3w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=SF09O8UfeTOzQNVYbgCroZZsXaWMbZHA4mqoWfu9hsY=;
 b=EECdhlKz+PiLxaFC15MI+IiyT4JwVZqQYuv93cYggjSqGw1y4yE1Ylbagi7iW3qStIrA22c3TMGoOB9mkTmMGdYVTc+E7tXzdRuAG/x8nvUidGA2UpNPkng116Lu3rez0ziISL0koR4IBmuczs5LC5a8Gs0fhKS2nvSbVHCyEHl5X8v8fJiOD3fCx39amROTbXCml4TcrPXQ/Ik+XLKJgWI1r4J1w2PvZNKI9AKVVDcc+h83d9SOfu5AJYulZ29nINWFCIXjdQMsU8gkfva2c4PZEx5ZV4AjR4ppZ6aXqn9xtB5lbxQ2VgYnF1ozqZ47W9O1q3YpMjFRybz1p0mh1w==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Julien Grall <julien@xen.org>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: "sstabellini@kernel.org" <sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "roger.pau@citrix.com" <roger.pau@citrix.com>,
        "jbeulich@suse.com"
	<jbeulich@suse.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v6 01/13] xen/pci: arm: add stub for is_memory_hole
Thread-Topic: [PATCH v6 01/13] xen/pci: arm: add stub for is_memory_hole
Thread-Index: 
 AQHYGZFbEg6Erttt1UCNei+XrySHEqyDFYiAgAAC4gCAAAsigIAAAbyAgAAC0oCAAAq4gA==
Date: Fri, 4 Feb 2022 10:35:52 +0000
Message-ID: <86e51f3c-6ef8-a86d-acf3-38334db430a7@epam.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-2-andr2000@gmail.com>
 <000ac24e-fdac-855d-7fb4-2165a1192ea4@xen.org>
 <19e50632-5865-9a75-756b-88db85007e96@epam.com>
 <d9741ff0-2152-6792-5249-09e3b0960972@xen.org>
 <43cab3d0-1a62-dca0-0d2d-5ea8fe237b21@epam.com>
 <ad90a3df-7049-8ff2-979a-dec3b8c542a1@xen.org>
In-Reply-To: <ad90a3df-7049-8ff2-979a-dec3b8c542a1@xen.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 77ec2dd9-1e55-4b3c-3559-08d9e7ca1e29
x-ms-traffictypediagnostic: AM6PR03MB4279:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM6PR03MB427970C6B19388D3646AB601E7299@AM6PR03MB4279.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 KPex9bBPuektC16nfTgI5mgwd0ls9/NL/SbyxZNz2TD4TB9GfKNQ39niX3AxQlgv88VMw9vEwC4079hnD5Ua9sszN7ba/OV+acOt2UTKX1m6x1y4ZqyU/7QSgldVQf2E8CvMp2wCfqysB1UsCCtiTjCxfcdlHQD6Yn5+AHMiz5ZpBb/zqSEdiDDa3bj0y6GpkB/oOuLt/dpTtFYS/W4h9a0uwDYuuvz4heg5rkFLtYY4RBITUQlfMT7UmJIWshnBl2tliarXx66y3nwjfSnhdq99Yj0bvu2RfspeSW4tVepUJ+zEWOP2WlZ2OHBEyo1lTybQFy6N/aSk1olMaLIDBO8IGA8GXLmutGkEkUrEDXVrgkbAY1DB1Zsb5CyBhe2Q3TL+fVS9YjwXOI7nVW1B/uAIS6QAl4PK+3jx4QcJrhSmdzTh7EuG9+RooI2v7ap75Y6ppanoUzJjNTc9cH3JDT4262GUAvaM4FfnxaK2gFQyjfKt29T0k5/5m9WqvcThARYdMR0GqA8a8VZ+FKp6wd+wuU/dG1T6KIWzfbXFQZZLmwH5v0WHS13A5arTJmUYvKfIODMcrQiTu3tAFB19cD41DuuIF7Q/mGm8jnYCRrlVbzH/cPTeVVN32m4p74oh6fqHbFiODAaTavzv70bUSxtw/lA7mu3kuG3+cSP0Js0IBAT9GHetmoomSUcdAlkyYSkzhGS/T/zxbGZ+gokiX8X/rmfltPLpNqTJwJ7Xcc1AhT3jMiplpE8Gv6slOiDN
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66446008)(66476007)(186003)(107886003)(91956017)(71200400001)(64756008)(66946007)(6512007)(7416002)(53546011)(122000001)(2616005)(38100700002)(6506007)(66556008)(76116006)(31696002)(86362001)(26005)(38070700005)(83380400001)(4326008)(8936002)(508600001)(36756003)(5660300002)(6486002)(31686004)(54906003)(8676002)(2906002)(316002)(110136005)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?eDBObnNxQ2xZUk05bUFZYy8wbWRDdTJTSzY2M0xVb2JqZ2J3OXpNcFpFTW5j?=
 =?utf-8?B?Mlh0TkdXOGl4Z1BDNWdvWkFQNjF1SnlCUFk1bEZqR0I1TFJwYmpRR05yU2tZ?=
 =?utf-8?B?S2JvNkNSQks2RmRmeHJBeDN1eHUwVW5KcnpWdGhjZzFTM2N0VWNEcHZTV2Fh?=
 =?utf-8?B?VGFnNzNVTW1sZmozS283bzVNeGJKNTcwTGdBeUYxMVozd1dyWkNFRkc1djRC?=
 =?utf-8?B?REY0ZjR0amFkSFVkZjdtRjY4aGZVWFI5c0tGUXQ3cEpCQ2Y3TUx0UWdXbkdQ?=
 =?utf-8?B?RHNCak0zQXR3ZUhGcjNUVEd4ZHhTUkNzak0remphdE9jb3pUODZaRWtlbUo3?=
 =?utf-8?B?KzA5ZjdZRFVGVk5odDBCTG5GbWQvZG8vaEo3cUNHRjYrZW4wQnRvYzE4V3hF?=
 =?utf-8?B?cXZOS0FoRkRQTUh5TmJoVkh6T290VDJnOURPVjd0OUxtRVExdTFlRlNkQXdY?=
 =?utf-8?B?cW83MldCUlBZaGowRkN2ZDVoWUErWEdib2VaYldiZ1ZoeDk4eVVBSFJ4bEpS?=
 =?utf-8?B?bjI4eFIrSGVuOWowSWdCS1N5STkva0xoZHB0c0x3LzREeXRMeitRVXdnOFRX?=
 =?utf-8?B?amtsWTJySHR1cGtjSm1tWHlDR3VpNE1KOVB1R3JaWGdnbWhaeTV5TTBFcGts?=
 =?utf-8?B?NzEzazlOTVJDcXJyNlJwc1FxK1BPd3Z2MGpack13RjRQL1BlcklDeWVsVS9B?=
 =?utf-8?B?Y0hjdUJzbUZrT1RMNDJyT0NCc3piS0FJNUh6UzJPU09tR2pCYWdiQlg0dyt2?=
 =?utf-8?B?U0xoN3NuNS90dmFBR1RoRnVndnNRcVRMeXVKbitISGtuTmF1YlI1YXRiMXpM?=
 =?utf-8?B?QUd6U3B2bTR1Q1NpOWVWNU5LSjZLcHVuL0doRjM5UTNQbTdsZXVsNTZPMXlV?=
 =?utf-8?B?QWQranZEczBiRExVTFA5MFJYUmVGY3A4RDNrUDc3M3htZXVUVVpFS0VYams5?=
 =?utf-8?B?RUc1WkFicXdqM1NjZUNDcEMzY1JJUzhXQ0YyaEFjK0Z1M01UOGpyN2ozMmVk?=
 =?utf-8?B?S0pVRTRJd3ppalllcnFEekNYNW1waDNqS2VDNDZQWDVCS2VYQUt1V3BBenlX?=
 =?utf-8?B?R09FRlNDZy9sYXBPNS9lczc0YzRGNEJoNnFYQmdjV1QwZUwwMCswMWFQR3M0?=
 =?utf-8?B?cU1BcjJ6bUkwWFFRZHJzSzI5NlJoVWxrYkh4MEFqa3BhdFJFOS8rbG9XeTRQ?=
 =?utf-8?B?dFR6VW81Q3AxRDNhKzRBUXJmTXA0MmN6ck9Iekw3ekd4UlRFaU1sT0NqOXlV?=
 =?utf-8?B?aENxSXR6c1ByRmtvN2dNcXJHZ25od1hkWEt1VURnYmszbFJzQi94QW1FWkRa?=
 =?utf-8?B?RlpwaEhmS2VVWlN0Sy95aTVWZGs1V2RkRXIvRHVQYVdrellJV20rckxyNUk3?=
 =?utf-8?B?WE4yWVU5aUd0SThyb3pSWTlWK2sxbUJUd0dmcHhIa2RvVUYvZUNaNURQd0c1?=
 =?utf-8?B?Y0EvaFRZRjBRN3UzRWdzMzdVQU4yNzBWcUhRdDYyNS9tUnBrNDBLQjZqM3Ru?=
 =?utf-8?B?bnpVY0RDbm40Rzl6TmZCeWlLV2NsSG5LK3VlSVVIQUduTkNuL0Y0ZEhFVGkr?=
 =?utf-8?B?K0RZNVNiWVZLaWQvc0hOR0ltbVl6cGJFRzVwU1VLcFlseWwzWUxtRmY4ekNB?=
 =?utf-8?B?U0tLRlRtREFEQjZDV0h5NWllM0FNdGlVakxnSXMrNXMrTzV6V0g5QUIrRlZo?=
 =?utf-8?B?RVhkT0hiWjl0bXFINkpRV1JxZURCcTJocDI5ZnU2SDlsYlNTbUZLeWRGbTRM?=
 =?utf-8?B?TWFNRlp1L056V3FaRXo3d2VmajJQdDEvZjBBVmZ5a1ZwWjh6MTltY0htWlBh?=
 =?utf-8?B?NEN6ZGo5dFFnWEcxR3N1UVFheHBmT2xmdWRqc1NhNUFLL2dVMUt2QlRWaDhy?=
 =?utf-8?B?K0FPcm8wZ2VZRk5OSVZPbnZweXJyM0xidzl6dDFEK1EvRDVscmh4azVlTUc3?=
 =?utf-8?B?ZHNBejdVRndDbUxURDgyQ3JFQm1pVDVmdUIvYVk3bTA2RlpqeE1VWXV0eW50?=
 =?utf-8?B?ZStkQXZtT2VadGRHR2VuWGgxZEJ0MDdCMTdyOVh1TU16THdmSTUzR0xOVnlL?=
 =?utf-8?B?eVZXTjljakNKV3h3RUhBem5IaVdmbkpKZVBUampyWnpta1UwZzNGSmw5Zk40?=
 =?utf-8?B?ZjU3U0xHMFJwWHQzdXFpNDE0VjdBdWtqZkszaFBYeGxWZDMrQ2QxNW9uZ0x4?=
 =?utf-8?B?YlpCS05hakRGcldaMUNSK0pJODFhU3hKcVdqckhQOWFyazdvdmptMTJhUlJ6?=
 =?utf-8?B?b3d3bjlLcGR2angySXpkZkU5ak4va0VZWHBEZUdtbm9hcmJMbFpZbGswZ2R3?=
 =?utf-8?B?OFR4dko4YUhhdTJzZlpDRXVrbnNSSVdKcUZvWHZRd3pUc1NxT0lWUT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <21B1FA967559AA40BED244988E6900BF@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 77ec2dd9-1e55-4b3c-3559-08d9e7ca1e29
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Feb 2022 10:35:52.4594
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 5QVKAQZOtHCsnPcHHfoffVFSLxC9RBzACtLrWc+fjcJvRR1SkZy58EHRsbKc7UNVObRNGWUmmhEVqmOj1WwyL428sMQkNaUo+M/op8JDE0HqlUHB2t2LLdl0ngFIaRQ1
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR03MB4279
X-Proofpoint-GUID: 0WZhHNr3WX-FLeh-kEe_G3qGZoxUarb0
X-Proofpoint-ORIG-GUID: 0WZhHNr3WX-FLeh-kEe_G3qGZoxUarb0
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-04_04,2022-02-03_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0
 lowpriorityscore=0 phishscore=0 clxscore=1015 adultscore=0 suspectscore=0
 priorityscore=1501 malwarescore=0 mlxscore=0 spamscore=0 mlxlogscore=999
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202040057

DQoNCk9uIDA0LjAyLjIyIDExOjU3LCBKdWxpZW4gR3JhbGwgd3JvdGU6DQo+IEhpLA0KPg0KPiBP
biAwNC8wMi8yMDIyIDA5OjQ3LCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyB3cm90ZToNCj4+Pj4g
Q291bGQgeW91IHBsZWFzZSBoZWxwIG1lIHdpdGggdGhlIGV4YWN0IG1lc3NhZ2UgeW91IHdvdWxk
IGxpa2UgdG8gc2VlPw0KPj4+DQo+Pj4gSGVyZSBhIHN1bW1hcnkgb2YgdGhlIGRpc2N1c3Npb24g
KCsgc29tZSBteSBmb2xsb3ctdXAgdGhvdWdodHMpOg0KPj4+DQo+Pj4gaXNfbWVtb3J5X2hvbGUo
KSB3YXMgcmVjZW50bHkgaW50cm9kdWNlZCBvbiB4ODYgKHNlZSBjb21taXQgNzVjYzQ2MGExYjhj
ICJ4ZW4vcGNpOiBkZXRlY3Qgd2hlbiBCQVJzIGFyZSBub3Qgc3VpdGFibHkgcG9zaXRpb25lZCIp
IHRvIGNoZWNrIHdoZXRoZXIgdGhlIEJBUiBhcmUgcG9zaXRpb25lZCBvdXRzaWRlIG9mIGEgdmFs
aWQgbWVtb3J5IHJhbmdlLiBUaGlzIHdhcyBpbnRyb2R1Y2VkIHRvIHdvcmstYXJvdW5kIHF1aXJr
eSBmaXJtd2FyZS4NCj4+Pg0KPj4+IEluIHRoZW9yeSwgdGhpcyBjb3VsZCBhbHNvIGhhcHBlbiBv
biBBcm0uIEluIHByYWN0aWNlLCB0aGlzIG1heSBub3QgaGFwcGVuIGJ1dCBpdCBzb3VuZHMgYmV0
dGVyIHRvIHNhbml0eSBjaGVjayB0aGF0IHRoZSBCQVIgY29udGFpbnMgInZhbGlkIiBJL08gcmFu
Z2UuDQo+Pj4NCj4+PiBPbiB4ODYsIHRoaXMgaXMgaW1wbGVtZW50ZWQgYnkgY2hlY2tpbmcgdGhl
IHJlZ2lvbiBpcyBub3QgZGVzY3JpYmVkIGlzIGluIHRoZSBlODIwLiBJSVVDLCBvbiBBcm0sIHRo
ZSBCQVJzIGhhdmUgdG8gYmUgcG9zaXRpb25lZCBpbiBwcmUtZGVmaW5lZCByYW5nZXMuIFNvIEkg
dGhpbmsgaXQgd291bGQgYmUgcG9zc2libGUgdG8gaW1wbGVtZW50IGlzX21lbW9yeV9ob2xlKCkg
YnkgZ29pbmcgdGhyb3VnaCB0aGUgbGlzdCBvZiBob3N0YnJpZGdlcyBhbmQgY2hlY2sgdGhlIHJh
bmdlcy4NCj4+Pg0KPj4+IEJ1dCBmaXJzdCwgSSdkIGxpa2UgdG8gY29uZmlybSBteSB1bmRlcnN0
YW5kaW5nIHdpdGggUmFodWwsIGFuZCBvdGhlcnMuDQo+Pj4NCj4+PiBJZiB3ZSB3ZXJlIGdvaW5n
IHRvIGdvIHRoaXMgcm91dGUsIEkgd291bGQgYWxzbyByZW5hbWUgdGhlIGZ1bmN0aW9uIHRvIGJl
IGJldHRlciBtYXRjaCB3aGF0IGl0IGlzIGRvaW5nIChpLmUuIGl0IGNoZWNrcyB0aGUgQkFSIGlz
IGNvcnJlY3RseSBwbGFjZWQpLiBBcyBhIHBvdGVudGlhbGx5IG9wdGltaXphdGlvbi9oYXJkZW5p
bmcgZm9yIEFybSwgd2UgY291bGQgcGFzcyB0aGUgaG9zdGJyaWRnZSBzbyB3ZSBkb24ndCBoYXZl
IHRvIHdhbGsgYWxsIG9mIHRoZW0uDQo+PiBJdCBzZWVtcyB0aGlzIG5lZWRzIHRvIGxpdmUgaW4g
dGhlIGNvbW1pdCBtZXNzYWdlIHRoZW4/IFNvLCBpdCBpcyBlYXN5IHRvIGZpbmQNCj4+IGFzIGV2
ZXJ5dGhpbmcgYWZ0ZXIgIi0tLSIgaXMgZ29pbmcgdG8gYmUgZHJvcHBlZCBvbiBjb21taXQNCj4g
SSBleHBlY3QgdGhlIGZ1bmN0aW9uIHRvIGJlIGZ1bGx5IGltcGxlbWVudGVkIGJlZm9yZSB0aGlz
IGlzIHdpbGwgYmUgbWVyZ2VkLg0KPg0KPiBTbyBpZiBpdCBpcyBmdWxseSBpbXBsZW1lbnRlZCwg
dGhlbiBhIGZhaXIgY2h1bmsgb2Ygd2hhdCBJIHdyb3RlIHdvdWxkIG5vdCBiZSBuZWNlc3Nhcnkg
dG8gY2FycnkgaW4gdGhlIGNvbW1pdCBtZXNzYWdlLg0KV2VsbCwgd2Ugc3RhcnRlZCBmcm9tIHRo
YXQgd2Ugd2FudCAqc29tZXRoaW5nKiB3aXRoIFRPRE8gYW5kIG5vdw0KeW91IHJlcXVlc3QgaXQg
dG8gYmUgZnVsbHkgaW1wbGVtZW50ZWQgYmVmb3JlIGl0IGlzIG1lcmdlZC4NCldoYXQgZG8gSSBt
aXNzIGhlcmU/DQo+DQo+IENoZWVycywNCj4NClRoYW5rIHlvdSwNCk9sZWtzYW5kcg==


From xen-devel-bounces@lists.xenproject.org Fri Feb 04 10:49:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 10:49:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265361.458712 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFw9f-0005ar-0l; Fri, 04 Feb 2022 10:49:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265361.458712; Fri, 04 Feb 2022 10:49:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFw9e-0005ak-Ty; Fri, 04 Feb 2022 10:49:26 +0000
Received: by outflank-mailman (input) for mailman id 265361;
 Fri, 04 Feb 2022 10:49:26 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1gJ0=ST=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nFw9e-0005ae-20
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 10:49:26 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1de07ad9-85a8-11ec-8f75-fffcc8bd4f1a;
 Fri, 04 Feb 2022 11:49:24 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2053.outbound.protection.outlook.com [104.47.14.53]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-38-Q72iVPDvPjmYGSoXh66qQQ-1; Fri, 04 Feb 2022 11:49:23 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by PAXPR04MB9188.eurprd04.prod.outlook.com (2603:10a6:102:222::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.22; Fri, 4 Feb
 2022 10:49:21 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.014; Fri, 4 Feb 2022
 10:49:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1de07ad9-85a8-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1643971764;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=R4JsFwGJrWfrpVEX8jSVVG428BXVo5vvWtIQ1qFK6Z4=;
	b=aHuR9xqGjpGFSFh1kkpj91y80QAKBXqraLXlsVSksKZjgdrds/UkvWWkSTH/hEElph9/JB
	VFy3LICeO69U5KBiz7wCBwNT3xHV/Y+8g6MFLP3M2UhAoowQAuRHWsBtYE/rOwwBzvdXMC
	7z7qdW8p8zxvxMlk8IkyUXfAdF3tPaE=
X-MC-Unique: Q72iVPDvPjmYGSoXh66qQQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=hLQskWNagmRbbQMFKsV2whVS/MptsdcBWzSrbbPgjl++Sf+lMoALmEKWsuFcPyuxPjWH4tCwcgyrZ06eMqtM3xlhjB60tCK6wi3Z/vVkTthyD94NtsuRw+mWiCDCQEld6mKsQBRej4/jdqxqiBetS+ARuo9m/dYid4WLqXSjVN0pg9XhsV332+7vKbnI/mG9wRW3Nls0S6mllQ33TZGtjy9VavRU9cwwgp/M5Y0naPbxbezbr34Gug6bY98LvbDJ7oRAdIDlyVtLf+vVaFPfzRcByVMzFCrxbeCt7XZozh79rMjQGkkdCBb/dK5tTpuSY6qGzE5L3gvRHsqKTXMaJg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=R4JsFwGJrWfrpVEX8jSVVG428BXVo5vvWtIQ1qFK6Z4=;
 b=Y45CsXG/wl9derdYT53URXOXkiGtsiMiyCJygFqHYam9HDMjuFEo/sBQLnwOQGhtWYkkSZd99O+g9GqstNf2CB1bDaeMbWm/s60331ZwqUiNI3dJhI+6SnnFPGltbUxk8JnL5ZfzDBMzkJ7Q614d7XdlRrYOJeh9SNxKxFs/z6Gl4yTNmrI9pwuMD5Dl8n5oYhuaN1N7ENjITqsrp0lQ7m0kz3rnKMgpwMfs2bnSItxAXKpxWrfGyEocPxA3TDrPK0WZYkokh7IPsdmH/erARhiVE69Q8fUP4c4nFVvbcmzUm81nU8ILxQDsIOKRW5Zpv1zx5nbUC4uUe+NAXeg8tg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <c3a99712-cf7c-37da-aac1-f2ee00e6d53b@suse.com>
Date: Fri, 4 Feb 2022 11:49:18 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Content-Language: en-US
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Cc: "julien@xen.org" <julien@xen.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Artem Mygaiev <Artem_Mygaiev@epam.com>,
 "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
 "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
 "paul@xen.org" <paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "roger.pau@citrix.com" <roger.pau@citrix.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-4-andr2000@gmail.com>
 <7209889d-8f17-61cc-72a4-97f6dbc1d54d@suse.com>
 <2cf022f8-b000-11b7-c6b9-90a56bc6e2ea@epam.com>
 <04726915-f39f-9019-436e-4399533c9fc3@suse.com>
 <9ed3f4ac-0a2d-ed45-9872-7c3f356a469e@epam.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <9ed3f4ac-0a2d-ed45-9872-7c3f356a469e@epam.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR07CA0032.eurprd07.prod.outlook.com
 (2603:10a6:20b:459::6) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e5c9a316-ee08-44b7-db50-08d9e7cc003c
X-MS-TrafficTypeDiagnostic: PAXPR04MB9188:EE_
X-Microsoft-Antispam-PRVS:
	<PAXPR04MB91885C58792E4FBAA7327048B3299@PAXPR04MB9188.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	yBD6mO6TlTtI3/zz3xttriTNGqi/pbIqpJXE4JXFmv3pd34JZo7O3lhPPpGp7IvAvwYkRE4ks+jbxXUqkVO3VsmDQJe0ADnMbQpX1ke9UY045lhI2DSnHf9ACoT6Ww9LAcI/mEeaAkDPrsZKRhcJSJnXXPHp/M4/6s1mp43VQHGN6Rhs6z2wELvzVTn0Vopk48awAOSWtl2OkQ5W8QtmZVH43vS6FDmKVm4P4BdkkeFxYO/BLhuAi18prdPKUYlpAEKSluKbQrhx290AMBRAEF3oTbZb5OCmzoLI9K3fGJKNr8JdC622JYxrmXDxT3GCreOSAikBYyZbLKQD2XhICMqlTEe04x1YklBYss4laR5F6swArF+k3EdV8Z6IAimD1KF6R6dHm/r97ArYwcknJQ3KXLGPZUhCPwZDIqeGgZBdEi9Ax2m6YGpRY2sz8KC1o6rTKCOO3wYRBt3yxDbcUZSaQ2S2ZcK1ODGrOmqsi0674oI5R6WhObBaRaGjMDHvVZmYT/nm/qXOGUvcG4NNvUoQlUb4kZQJ0J7CT4+FMrUX3kE7fFj7tq1EFE5cET41DJxAOSoQjuW5nn70YL0AFpCecbb5B1oIpXXroWZQj7h87pUNctYR2D0FQo0RW2TqQakP3klJ+6ov0ISQB2rtRb8jDjnPYhEmsbv2pAZsJdiJpoiOEQHwo4DIyohS6TkqJH5KwLEQ1jOMGQj6Yu6R8HxRalRoM+lWXMwauQCk2r4=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6506007)(6666004)(2616005)(53546011)(5660300002)(26005)(6512007)(186003)(7416002)(2906002)(36756003)(54906003)(8936002)(38100700002)(83380400001)(508600001)(66946007)(8676002)(31696002)(4326008)(66476007)(66556008)(86362001)(316002)(6486002)(6916009)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TFNrN2U1b3oybkMxcU1PUitNL0RibDhzUzR2NUlaNUh4Z1pEUytSM3VHQTBT?=
 =?utf-8?B?QkxiTVd3dDZKUnV0TEdjU2I1VVZnWWdnZy8wL2ZPb2FuODhHRTBNZWZCRVNI?=
 =?utf-8?B?QVNpR0RRckQ1djZ4UTdYREw5Kzl3YVpkSFF3TDhJUVYvenhsWlozcGRybTh5?=
 =?utf-8?B?aFlFSENGeHU5cm9EWmRLTnFBNklmTFAxRzBQZldvT0hYZlJtUHRYeTBBQUxo?=
 =?utf-8?B?djdKeFdDVlpGbzAwSmJ1VEtCYjI1dVpkb3pmTlhiMk90WW14bWZEUlhoZ1dY?=
 =?utf-8?B?a2NCVGNSdXpCTm1TY0lUNHowb09lL1JURW9KdzlMY0g3SjliSGFBOXlTUzVz?=
 =?utf-8?B?ak0vNE40YTVsbTl3cHl0Y2tHR09DR0lXbXlUeks2dFBobmxHelBVRlZweFE4?=
 =?utf-8?B?bitZRkc2U0xUWHkrcHIvR1RrWnU2dHZ5eE8vWkhmYVZLcHFkL2tXSU9LN3Mx?=
 =?utf-8?B?UDh2T29RcHZFTXNKd0owN0wyS1ZDZUtCVXIxUUo5L28xenpIRmRISGlEVnNJ?=
 =?utf-8?B?VjdVZTl2VzdWY1RidGFjcVN6Q0d3WDRtc01xdkVFU0RTNi81Vno2amwyRTQx?=
 =?utf-8?B?N04vbEk0cEUzN01mWnVxVC9ZY0NwK1Q2alZJMkc2bFdLcDNWVkh0SWFJaUpj?=
 =?utf-8?B?NjFBWndnVU44ZEkxblJoVDdoVXZsRU9tdUxLbVVvdkJBUElheTFIcmE1aWVQ?=
 =?utf-8?B?TjhSRldSVnIvTDlPS1ZCYkFBUWtiSC9WTW54TGZzL0RpcjE2TzE3Qm82Ylk0?=
 =?utf-8?B?VXVRbTBtMFZmbzNiUWgxOWJpRm1CeCtQQkI4TDQzM1pmNjAxbVFzTFNnZGJ6?=
 =?utf-8?B?RHJ0eFh1eGtHZGhCTUZ4TXFWdnV5ZGtaRVU2ckhpU3E1bDRIMHpZTHVhUkxh?=
 =?utf-8?B?M2FYRWNwNjdWbjJKbURsYUNRdWNVR1AydzlUbHVtNmJ3SHhEK3dHNCtlajhW?=
 =?utf-8?B?LzFBZndUTG5Rem1DczJ2a1k2MmJPSkl3TDlQT1hKUGdCK0xiYkNJbThqVjRY?=
 =?utf-8?B?TWhxQk1peEgzQjh5OFVmU0N6eEpFWWhGTURtZzBTMkNURkNkaHg5UytrUjJs?=
 =?utf-8?B?OWVPUFg2TXBUY2FudkhXeVFtYjM5WkxpdHlxSTRLRE8xWkFZb3A1UlFZenJN?=
 =?utf-8?B?WUlVL0ZMZUg5aG5hbzdqM3lkRUZ3L2JtMTNNMExQZzdBMmp4dG5XSmdCN0M4?=
 =?utf-8?B?cVhUZlFnMDhEV1BPcVA0WThIY3RaZzU0ZzlraHMyakljd2R0UlNBZmdtaEZ1?=
 =?utf-8?B?dG1qWjdiODlVT1pxd3lMTEExV1pYZnFYd2E2YU1Wa2hKZGVXNC85MXQwaFVl?=
 =?utf-8?B?WlBVNjhKSFlET2E4VkdROGVZemEvSHExa0E1VCttN3VqVXIrN2ZwS3p2RGxJ?=
 =?utf-8?B?YVNvQlJ0eEhqVFA0ZGQ5NkxBdk9ZTDhBODB2eXRuK2QxZEM5aCtsUCtKQ0Ni?=
 =?utf-8?B?OFZFV3BHa093aFU1d2ZNQW5vSGJ3S200SEZiZTV6NXB6V2laT2d3eEc5LzlI?=
 =?utf-8?B?ZDcxT2g0bC94KzhwdmpGSVZ3b1QrTTc0ZXNyQWNrSVdzbEh2cWR5aVM4NlJo?=
 =?utf-8?B?N3NqSUJtZGFRTGROV2V0cU9qSDZSNGlTUjVhSGh0VDgwdWVjQm9FR21PQmtz?=
 =?utf-8?B?MWduVW16bFo3Q1FEUXNXS3lSYy94aU5LNnZlcWhtTWJRZlVrM1NDMXhvOGFL?=
 =?utf-8?B?TG8wbkZOcHhoSjU3VGdIWmY4bGJzYWRYOVlPSjdvTG9ZdHNwWWlqZVVvb0tr?=
 =?utf-8?B?ZUZSVmZYOWZoN3VJMDAzM1lqMjIvUWFldWhHZW5PVisvU0E5eVFhK25tL0wr?=
 =?utf-8?B?aSs2Wm9EaFBaNUQxRG0rWXBHTGYwZVNYSG1YYnNheWJ5ODBLeGU0U2h3cGo0?=
 =?utf-8?B?VjFaODBOQUM3WldDVElxdzNGc25PbzI4ZENUNHFRbTBsNGQreFRyTk9Pb3Z5?=
 =?utf-8?B?V3ZmejI3U0ZsWDZFRlRwRGdOZCtkVGhSMDhiY3FNRjhLeUdWSjFhd0duUVdq?=
 =?utf-8?B?cW1jR3hHbGtJQ3gzcXZ1cCsvbVRQRC8vNGZpL3Z5djc1OUVJeE55Z3Q0OUpC?=
 =?utf-8?B?dG5YUm5Ua0NnRUFpWG1MUHJoeFUzd1c1bUFVd2REZVB4VC9paFJ1ZUlvUFVC?=
 =?utf-8?B?aWFMSzVDUEo5ZU4yMnRHekZYUUdrc0VzOExOTmk3UWFYV2RrWkN1c2VEdmll?=
 =?utf-8?Q?qqgRkAcfKRuIrR43baYhkQI=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e5c9a316-ee08-44b7-db50-08d9e7cc003c
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Feb 2022 10:49:21.4218
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: b2WRD60dHOvfSuVMqMbGaXW355Skv0x58VMFyqA0C/NVL9/5+Zz+zt+3snYwTLo8BXHLHF8YNqXDCel8uQmg7w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9188

On 04.02.2022 11:12, Oleksandr Andrushchenko wrote:
> On 04.02.22 11:15, Jan Beulich wrote:
>> On 04.02.2022 09:58, Oleksandr Andrushchenko wrote:
>>> On 04.02.22 09:52, Jan Beulich wrote:
>>>> On 04.02.2022 07:34, Oleksandr Andrushchenko wrote:
>>>>> @@ -285,6 +286,12 @@ static int modify_bars(const struct pci_dev *pdev, uint16_t cmd, bool rom_only)
>>>>>                    continue;
>>>>>            }
>>>>>    
>>>>> +        spin_lock(&tmp->vpci_lock);
>>>>> +        if ( !tmp->vpci )
>>>>> +        {
>>>>> +            spin_unlock(&tmp->vpci_lock);
>>>>> +            continue;
>>>>> +        }
>>>>>            for ( i = 0; i < ARRAY_SIZE(tmp->vpci->header.bars); i++ )
>>>>>            {
>>>>>                const struct vpci_bar *bar = &tmp->vpci->header.bars[i];
>>>>> @@ -303,12 +310,14 @@ static int modify_bars(const struct pci_dev *pdev, uint16_t cmd, bool rom_only)
>>>>>                rc = rangeset_remove_range(mem, start, end);
>>>>>                if ( rc )
>>>>>                {
>>>>> +                spin_unlock(&tmp->vpci_lock);
>>>>>                    printk(XENLOG_G_WARNING "Failed to remove [%lx, %lx]: %d\n",
>>>>>                           start, end, rc);
>>>>>                    rangeset_destroy(mem);
>>>>>                    return rc;
>>>>>                }
>>>>>            }
>>>>> +        spin_unlock(&tmp->vpci_lock);
>>>>>        }
>>>> At the first glance this simply looks like another unjustified (in the
>>>> description) change, as you're not converting anything here but you
>>>> actually add locking (and I realize this was there before, so I'm sorry
>>>> for not pointing this out earlier).
>>> Well, I thought that the description already has "...the lock can be
>>> used (and in a few cases is used right away) to check whether vpci
>>> is present" and this is enough for such uses as here.
>>>>    But then I wonder whether you
>>>> actually tested this, since I can't help getting the impression that
>>>> you're introducing a live-lock: The function is called from cmd_write()
>>>> and rom_write(), which in turn are called out of vpci_write(). Yet that
>>>> function already holds the lock, and the lock is not (currently)
>>>> recursive. (For the 3rd caller of the function - init_bars() - otoh
>>>> the locking looks to be entirely unnecessary.)
>>> Well, you are correct: if tmp != pdev then it is correct to acquire
>>> the lock. But if tmp == pdev and rom_only == true
>>> then we'll deadlock.
>>>
>>> It seems we need to have the locking conditional, e.g. only lock
>>> if tmp != pdev
>> Which will address the live-lock, but introduce ABBA deadlock potential
>> between the two locks.
> I am not sure I can suggest a better solution here
> @Roger, @Jan, could you please help here?

Well, first of all I'd like to mention that while it may have been okay to
not hold pcidevs_lock here for Dom0, it surely needs acquiring when dealing
with DomU-s' lists of PCI devices. The requirement really applies to the
other use of for_each_pdev() as well (in vpci_dump_msi()), except that
there it probably wants to be a try-lock.

Next I'd like to point out that here we have the still pending issue of
how to deal with hidden devices, which Dom0 can access. See my RFC patch
"vPCI: account for hidden devices in modify_bars()". Whatever the solution
here, I think it wants to at least account for the extra need there.

Now it is quite clear that pcidevs_lock isn't going to help with avoiding
the deadlock, as it's imo not an option at all to acquire that lock
everywhere else you access ->vpci (or else the vpci lock itself would be
pointless). But a per-domain auxiliary r/w lock may help: Other paths
would acquire it in read mode, and here you'd acquire it in write mode (in
the former case around the vpci lock, while in the latter case there may
then not be any need to acquire the individual vpci locks at all). FTAOD:
I haven't fully thought through all implications (and hence whether this is
viable in the first place); I expect you will, documenting what you've
found in the resulting patch description. Of course the double lock
acquire/release would then likely want hiding in helper functions.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Feb 04 10:58:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 10:58:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265370.458722 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFwHy-00077v-0U; Fri, 04 Feb 2022 10:58:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265370.458722; Fri, 04 Feb 2022 10:58:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFwHx-00077o-Tl; Fri, 04 Feb 2022 10:58:01 +0000
Received: by outflank-mailman (input) for mailman id 265370;
 Fri, 04 Feb 2022 10:58:00 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=46ws=ST=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nFwHw-00077i-8E
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 10:58:00 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4ee20772-85a9-11ec-8eb8-a37418f5ba1a;
 Fri, 04 Feb 2022 11:57:58 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4ee20772-85a9-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1643972277;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=OgOvysuyaITv+BlJ0XQ27OL1fJgus/Tep3gZgmDIyeo=;
  b=b9fLYJeYpSjXr1A6cdQSITtCJx2USssDn6cmZYI/Gf4DUgnj2glKkpI7
   aXIK5vptJXuTd8gTuik5vC/gQQqusgz8rqTaqFxf6h8xlhywM7e9hmx6/
   h5/pdZ6BkxRd5Fpef1Q9+CGTxdb8wsGzrVCCO+15e4An67zfOI2BfjtLw
   k=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: T1E2g3GEJtu+whThmC8irrkPrAySNmfUzpryHD0wToOyBxG4WDP3WWxTttRg6EhHPBebucCYdr
 z/Qnl7RZ8accrwtIDrRAh5/TIOXY8cz1hSFH/ntmbKfMkP9q8p53r09nav6kSzQyaz+W/FWYhR
 pS5RnvcLH97MhPRy9/TftIT/7KYP/4cOGEPYxJ4glJ9NRT3LJVxs/MRgHmHDDn6KjF90hxTvkB
 HrvrXQqE4/YrQ8+mDgr7R3KcCwvEYMa1CXYjy+QI/fcFBlsyAhvqsa12F/bv/XaAyspO9zmeaQ
 r8Ugf4L1VX1+l3LCgpF3EEIX
X-SBRS: 5.1
X-MesageID: 62950546
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:v155+q5L2q0kRlWVDvRTwAxRtBrBchMFZxGqfqrLsTDasY5as4F+v
 mIbCj+EaamLYjOke98iPd/jp0hU7cXcmNFlTQQ5qyg9Hi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FV8MpBsJ00o5wbZj2tIw27BVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z0
 f5P7LCBET4TPqzxmPgZegYbDhFXIvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALNs7kMZlZonh95TrYEewnUdbIRKCiCdpwgm1h25gTQai2i
 8wxYj1JRj3maE1zZngYNY4YsPiZhUHkfGgNwL6SjfVuuDWCpOBr65D1OcfRUsyHQ4NShEnwj
 kvc42n8NTQLO9WexCSt/2qlg6nEmiaTcIgfDqGi//hmxlia3HUOCQY+XEG+5/K+jyaWS99Zb
 kAZ5Ccqhawz71CwCMnwWQWip3yJtQJaXMBfe8Ug4QGQzuzP4gCWBkANVDsHY9sj3OcIQjgt2
 k6MjsneLzVlu72ISlqQ7r6R6zi1PEA9L2UPeCsFRgst+MT4rcc4iRenZvFnHa2uh9v5AwbZx
 TyQsTM+jLUei80M/6ij9FWBiDWpzrDLUwo06wP/Tm+jqARja+aNQIil6kPS6/paG7qIVVmKv
 HUCmM+24fgHCNeGkynlaP4WALij6vKBMTvdqV1iBZ8s83Kq4XHLQGxLyGggfgEzaJ9CIGK3J
 h+I0e9M2HNNFGKBb/ZbUtqIMcQr8Kj8Ef36Fe3kR8UbN/CdazS71C1pYEeR2UXkn04tjbwzN
 P+nTCq8MZoJIf85lWTrHo/xxZdun3ljnj2LGfgX2jz6ieL2WZKDdVsS3LJihMgd5bjMngja+
 s032yCim0QGC72WjsU6HOcuwbE2wZoTWMieRy9/LLfrzu9a9IcJUaS5LVQJINQNokitvr2Ul
 kxRo2cBoLYFuVXJKB+RdldoY671UJB0oBoTZHJwZgbzhiZ+MN3wt8/zkqfbm5F9r4SPKtYvF
 5E4lzioWKwTGlwrBRxBBXUCkGCSXEvy3l/fV8ZUSDM+Y4RhV2T0FizMJWPSGN01JnPv76MW+
 uT4viuCGMZrb1kyXa7+NaP0p3vs7Cd1pQ6HdxaRSjWlUB63q9YCxu2YpqJfHvzg3j2Yl2bDi
 lbLXUxFzQQPyqdsmOT0aWm/h97BO8N1H1ZAHnmd6rCzNCLA+XGkz5MGW+GNFQ0xnkupkEl7T
 ekKnfz6LtMdm1NG79h1H7pxlPps7Nrzvb5KiA9jGSyTPVisD7phJFiA3NVO6fIRluMI51PuV
 xLd4MReNJWIJNjhTAwbKj06Y7nRzvoTgDTTs6g4eR2o+C9t8bObekxOJB3Q2jdFJb54Pdp9k
 +csscIb8SKljR8uPorUhyxY7T3UfHcBT78mptcRB4qy0lgnzVRLYJr9DC7q4c7QN4UQYxdye
 jLN3fjMnbVRwEbGYkEfL3mV0LoPn4kKtTBL0EQGewaDlO3ai6JlxxZW6zk2EFhYl00Vz+JpN
 2F3HERpPqHSrSxwjc1OUm3wSQFMABqVph74x1cTzTCLSkCpUirGLXEnOPbL90ccqjoOcj9e9
 bCe6WDkTTe1I52hgnpsARZo+675UNh81gzeg8T2Tc2KEq4zbSfhnqLzN3EDrAHqAJ9piUDKz
 QWwED2ctUEv2fYsnpAG
IronPort-HdrOrdr: A9a23:sLwFjaw5gFpO+aIxxr9jKrPxtuskLtp133Aq2lEZdPULSKKlfp
 GV88jziyWZtN9wYhEdcdDpAtjnfZr5z+8J3WB3B8bfYOCGghrTEGgG1+rfKlLbakjDH4JmpM
 Ndmu1FeaLN5DtB/LbHCWuDYq4dKbC8mcjC74qurAYOcegpUdAa0+4QMHfrLqQcfng+OXNWLu
 v62iIRzADQB0j/I/7LTEUtbqzmnZnmhZjmaRkJC1oO7xSPtyqh7PrfHwKD1hkTfjtTyfN6mF
 K13zDR1+GGibWW2xXc32jc49B/n8bg8MJKAIiphtIOIjvhpw60bMBKWqGEvhoyvOazgWxa3e
 XkklMFBYBe+nnRdma6rV/E3BTh6i8n7zvYxVqRkRLY0IXEbQN/L/AEqZNScxPf5UZllsp7yr
 h302WQsIcSJQ/cnQzmjuK4Fi1Cpw6Rmz4PgOQTh3tQXc81c7lKt7ES+0tTDdMpAD/60oY6C+
 NjZfusqsq+SWnqLEwxg1MfguBFBh8Ib1K7qwk5y4OoOgFt7TBEJxBy/r1aop8CnKhNPaWsqd
 60dZiAr4s+PPP+W5gNc9vpcfHHeVAlfii8RV56AW6XXJ3vaEi94KIe3t0OlZWXkdozvd0PpK
 g=
X-IronPort-AV: E=Sophos;i="5.88,342,1635220800"; 
   d="scan'208";a="62950546"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XDHC1C3VT3VITYOGbrTW7ibGcVdU/QiK5JLdgauyKeJbfpCUOBoYH31Z8BqqZagVn2ZTNj5/9lzjtj5OIJikymK9rvi1XHsYjdSb+aStTBNSgvdT2RFOZbDPZLMCalQexS1en6+ngT6UmsD3R8Ym2D3XBEpdW6XXhp0fljyGBy/wUfEcv9uXD+b2uCrzQaPawVsVdaveCu8B1Xa+Ko7g/helQ+bAHzWNmM4R4jpXYubUznD9eZZ1y/Lwd4K7FzLH0PvgXfOeMdeRS/PF1jj0cbs4v4//Ikpb6/ttsPLTsjImjCm/njpY3e141Luj5rvk2iWgIPkOnrzHA9/Pmhg9dQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=5Ei6D6DYVxWsWl6EIOxM2w/fJrygwoeM3gINgQBcIx0=;
 b=EhwILJKM0SyCYJawGt+V/iMlyzslTaouP6YaBKlW1bKV/MS8pPwCWfs0Qx8laW5JaygI4+9NToL7SD+crfaEQZFK40JxfE88IaUD6BTDhyO5GmGytN5ERRVmwpb7aWobG3HsKt2E3R5lda5SnQNdAooh2VUkpojKDCFtWp7LyY2yOfKuidmA+rtPHvjF8BJoG0HhWTigShjUQhQhDi7ukl+moXt2Pe9OUoX38t4/Lom7TUaBv6wmFa0Gq6U80VUil+9Avrfj6iv7LnmS7opdyIsErmeOQnfLIGNNOwuWbUvdyHifrz8jdNT7KuQ1TRVJ/SGZk3rp23PREx46nehSow==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=5Ei6D6DYVxWsWl6EIOxM2w/fJrygwoeM3gINgQBcIx0=;
 b=X9N3sGzi93L+Uw+VFtRYJCQsoCybMYhGqtwOpCsO71q8ybpRFgFwbVKyaOsMZPyXR0XBd/Bp5YyJVUQrGcqj/AK8wV4LhbauTwc47foYZ9QGGh3SabkDNvm4Zn8GI3L9EwKg5YRR9NlCY0jd+tTjGTE5KTkxlRkqvqRGVVxKeAY=
Date: Fri, 4 Feb 2022 11:57:30 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: Jan Beulich <jbeulich@suse.com>, "julien@xen.org" <julien@xen.org>,
	"sstabellini@kernel.org" <sstabellini@kernel.org>, Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Artem Mygaiev <Artem_Mygaiev@epam.com>,
	"andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
	"george.dunlap@citrix.com" <george.dunlap@citrix.com>, "paul@xen.org"
	<paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>, Rahul Singh
	<rahul.singh@arm.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Message-ID: <Yf0Gml+2ERdcOJ5K@Air-de-Roger>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-4-andr2000@gmail.com>
 <7209889d-8f17-61cc-72a4-97f6dbc1d54d@suse.com>
 <2cf022f8-b000-11b7-c6b9-90a56bc6e2ea@epam.com>
 <04726915-f39f-9019-436e-4399533c9fc3@suse.com>
 <9ed3f4ac-0a2d-ed45-9872-7c3f356a469e@epam.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <9ed3f4ac-0a2d-ed45-9872-7c3f356a469e@epam.com>
X-ClientProxiedBy: LO4P123CA0346.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:18d::9) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 8ba98957-7902-4c21-4f9f-08d9e7cd26f2
X-MS-TrafficTypeDiagnostic: BYAPR03MB4118:EE_
X-Microsoft-Antispam-PRVS: <BYAPR03MB41183792E8E1C748B9D9A05D8F299@BYAPR03MB4118.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: C5WqvRA87nq2xG7Ok2wz9Ff3Sqeo0XUNSVl/nyX7XyJau4GZEFgMJPBWp+mIZ38BGmjaYKcbOOCwxCYSOiCmO3yvj4JAgHJ0ULHXf69jDltl2TkO4vpyTbVoR8hH3YrbYTKQMcFY11zolZ1xltd75MMcWCeZgwMbuV+FTbfuhVTXVyXxJYivsJo1vJ81mqi5zB+7RlTlPP1/OqF1YY9R3DhM1gDNKPPHcLys+jUjk3uLoE9MJJRnwrZaPUEF9Xzc6RHFA4Z8lV6in+YTbouqX6YZg/x5bGB7x2re4jQPcY/5JFUuUS8MFXmVPevXMoDXxZaY0qnZF1QptUm/1flwEOJLmSYckei5hgP5KsaejWRAorubhne+Uf1/S5482fvMRVR64YQ2Ebp8tpc4Vt7V6vFxeoaHGc2Lyv+sMRb8NvYZmitQvJ4Ggx/AJ4Kqs7u4zyOu2CTTeZ/SBUEjjDQsjZAQtXmeYWbk0YSx8xuXSBwMufBfJJt8niq/dL3zD0AgqLXYVFVgAHRApgaZW5WR2ViTKlzIgebdCCNyhSHJ3c9/eJpFo2UX/8JtrFjswAXNOnz0+ts38mAcFh/wJKe3d50EQ7Oz1ZCRpP9L/T08UbMfJsiHICoKhc1rGLgZpYVXbUwrWS4ndPhc543ewY/p4Mqa5MezHk/a5h8NPjkFEZSixj2ziOBCTdUux3B1UePFmB5ZV9gT7P3Q6Ujv4AOK2Q==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(6916009)(8676002)(8936002)(54906003)(4326008)(66476007)(6486002)(66556008)(66946007)(316002)(2906002)(6512007)(508600001)(86362001)(9686003)(6666004)(53546011)(7416002)(83380400001)(6506007)(5660300002)(33716001)(186003)(82960400001)(26005)(38100700002)(85182001)(67856001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MXVCUXVxbVF1elFkcnJzVzhBdXlqVkY4cWhQQ2tsSWpobWVMOVgybDNOeVhF?=
 =?utf-8?B?Ujh0TkIzWmZiODlJZEUxZkMrSmM3QUp4R3h1TXhrN2ZrR0ZZQTUwa3F3ajk5?=
 =?utf-8?B?ODVhcFMwT2FLQzJZRDJoU1lTVG1VWkZHWXFHUUNmR0QzVUtKK2NRVmVMZWRn?=
 =?utf-8?B?bEQra1FwN0dmZzlEVXJlMzdCSjBGODI4eXRKdnM0TmZzcjhzck50SXYrZnlw?=
 =?utf-8?B?bldraUhrV0N2czVzVld0RkRhR1N3ZnRsTzYyRmhvZGh2VWtrSXdmalhoRnYx?=
 =?utf-8?B?bm16MXdiUGFKTENrR1pwMk1tNmFySldxZFBmTjN3UlRCd3ZhZ2hteWQ2Qlp1?=
 =?utf-8?B?Tnh3UTczb3VlcVI0UVZlbStjQjEwWlpwWjgrS1ZyMng5QlNTV1NzUTNTSFNG?=
 =?utf-8?B?OXZRQ3MrK3R2SnFtVW5EVXJMRWoxOHdxRTF2L2p5SVNGWmtJaEw5WHB6VmUv?=
 =?utf-8?B?VHdpTUw4Z3lGQzQ2Z2Z5RnBJa1JyeERCS3l6TWdxRW9LVmVZcmRuYkZGd3Nw?=
 =?utf-8?B?NW9TM2VGMThib0xxSjcyZHc3Sm9CZU81d2hZNEdtc015WjVvc1k0YVdyNnMr?=
 =?utf-8?B?VnNJMjc3WXdCdExINmxwK0I5OE5Cc0wvTW9WSC9ZbkNqYnhpRWJtQTZ0Ykl1?=
 =?utf-8?B?N1luR2czQ2hLSVhLcXdRRzNFdlpWR20zU3o1ZEdVVzQ4ZDlwd2ZpZHJMVk9m?=
 =?utf-8?B?ZWFTN2FRWEN5Rm1LMUVxVXd6QWVuVFluM0dFMDFEd2g5KzV6WERjNWtQRWFF?=
 =?utf-8?B?Q2QxM2Mxdld4WWZaUGlGd296Rno1YXVZV3MzUk5qWTloclJIc1E4WWVTY2VH?=
 =?utf-8?B?NlNaR2hSMmJEQktlWHF2ZHV0SkptVlN2YWY5UFJGTFo2OFVja0tGV2V0aWhz?=
 =?utf-8?B?RytnSEpzUXl2YUcrL1hsOXZsTHMrZ0lEa2ZWV01TMUxRSmdvZnRWb0tHTW55?=
 =?utf-8?B?ZGUyWHJKZjVZVm9QY0lDODBObVByWW1hLzUrb0d5Yk8vT3E5OStQcWxaUVB5?=
 =?utf-8?B?R3BadUp6cU5FNGk0OVdIdjRPdWVUOW8rRVBSdm12V3RFSU1wNnhQaVR5WlR1?=
 =?utf-8?B?YmE4UjFiREVGbzBiemV3TUx6U1l1QlFzWDdlamZYMEwvYUphQ3hIbTRmV2l3?=
 =?utf-8?B?TU1zeUp4UXROcTBTRnZQdURxNXpPYzVXd3hBVytaOWxCcDM2S0hHSjhwam8x?=
 =?utf-8?B?QVlXYXJFaTBjMHcrdGw0NklqcTFkWXQ5NUJZR2gyeWVRWFc1aTA0NjlvMnhh?=
 =?utf-8?B?d28wUGFucWNRNFlFb1N6T3duM2VxS1lFWG93Z1lpRkNaSXJkY3JDYTFWMVZD?=
 =?utf-8?B?Rnl3VEtwYjArTDUrOVl3WmxUMVNyTC9vaTZHcW13SVcxWlBhMGZFa3VYVlVU?=
 =?utf-8?B?SzZPOGt0YjhwVm1QamhWTjZxcUpOaDd3NWgxYkZEdm51U3hPUGNYbXFoMVVB?=
 =?utf-8?B?OVU5T04zd1BIeVlTM2NURDhOMkx1cGlaY2RPWEEzMTdxdXpWaVY0OXlXcXVX?=
 =?utf-8?B?R1RsVWZVZXFXN0UzZStlbnJQTkg0alJBSGtLK0FhUkxLTWRmMTdCT2xQQUh0?=
 =?utf-8?B?N3oyQWJuNlBDbExkQ2xGN01KUDRYbDR6VktaKzgrTmtCUEhUa1pEOHRWRWk0?=
 =?utf-8?B?cEpTdjdYdHJ5Q1E5UVpiMmpjUFhhWHR3ajRQSjU3dnlGQWFnN3dxbXJ3YTVx?=
 =?utf-8?B?ODl0M2t4NXlrN3JpSkJqeVZSaWRvZWRSbCtJQVhjdnlBTE5zV2dRbksycGQ4?=
 =?utf-8?B?ejJtMk1MZGJXZEtkdzBUZmhnd1FDTC90YUQ4a211Sk01TXJJMzBnZDl1NzlH?=
 =?utf-8?B?SmFySk01aXkwZW95NWtFbTJ0cDExTERpTjZSVjRnM3YrZmN5RWZRU0pMVTg1?=
 =?utf-8?B?dW13dE5Pckd4YVFGQUVMTlNTbWdQbDJESmxCbmJIcS9RS0NYZXJtMnpiYXkw?=
 =?utf-8?B?cjFES3pZeVB6Y0FjRjhITjVJUWZOM01yRnNOdWlETnZVRE14VzFwU1F3ek01?=
 =?utf-8?B?Z1VkTGlLT3Y2ZjFrWmJ6SnMxMWdyVGJtUjRIMnZtTU9ueEQzZ01EcWZ2LzBq?=
 =?utf-8?B?TWRNUUFCRi80S0dMK0dhM0FzWUppUFJtaFJLWmZhdnJiU0x2czNIQjhUZjAz?=
 =?utf-8?B?R0w1cFpFVE1XR25YSlVsSFFYamdHdW1PS2FxV0ljZUpFK1EyNWxCR0loV2Uv?=
 =?utf-8?Q?ZmjIMm4EzQi5P0ZLc2gvARQ=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8ba98957-7902-4c21-4f9f-08d9e7cd26f2
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Feb 2022 10:57:35.9079
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KwVnEGpALDfUnSCGn1PmQj+izXrV5bPqkKUxlWRA5x0uNCEBMxLnN4RAaY1Cu435ZMXf8PvQIDmK3a92TH8iZQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4118
X-OriginatorOrg: citrix.com

On Fri, Feb 04, 2022 at 10:12:46AM +0000, Oleksandr Andrushchenko wrote:
> Hi, Jan!
> 
> On 04.02.22 11:15, Jan Beulich wrote:
> > On 04.02.2022 09:58, Oleksandr Andrushchenko wrote:
> >> On 04.02.22 09:52, Jan Beulich wrote:
> >>> On 04.02.2022 07:34, Oleksandr Andrushchenko wrote:
> >>>> @@ -285,6 +286,12 @@ static int modify_bars(const struct pci_dev *pdev, uint16_t cmd, bool rom_only)
> >>>>                    continue;
> >>>>            }
> >>>>    
> >>>> +        spin_lock(&tmp->vpci_lock);
> >>>> +        if ( !tmp->vpci )
> >>>> +        {
> >>>> +            spin_unlock(&tmp->vpci_lock);
> >>>> +            continue;
> >>>> +        }
> >>>>            for ( i = 0; i < ARRAY_SIZE(tmp->vpci->header.bars); i++ )
> >>>>            {
> >>>>                const struct vpci_bar *bar = &tmp->vpci->header.bars[i];
> >>>> @@ -303,12 +310,14 @@ static int modify_bars(const struct pci_dev *pdev, uint16_t cmd, bool rom_only)
> >>>>                rc = rangeset_remove_range(mem, start, end);
> >>>>                if ( rc )
> >>>>                {
> >>>> +                spin_unlock(&tmp->vpci_lock);
> >>>>                    printk(XENLOG_G_WARNING "Failed to remove [%lx, %lx]: %d\n",
> >>>>                           start, end, rc);
> >>>>                    rangeset_destroy(mem);
> >>>>                    return rc;
> >>>>                }
> >>>>            }
> >>>> +        spin_unlock(&tmp->vpci_lock);
> >>>>        }
> >>> At the first glance this simply looks like another unjustified (in the
> >>> description) change, as you're not converting anything here but you
> >>> actually add locking (and I realize this was there before, so I'm sorry
> >>> for not pointing this out earlier).
> >> Well, I thought that the description already has "...the lock can be
> >> used (and in a few cases is used right away) to check whether vpci
> >> is present" and this is enough for such uses as here.
> >>>    But then I wonder whether you
> >>> actually tested this, since I can't help getting the impression that
> >>> you're introducing a live-lock: The function is called from cmd_write()
> >>> and rom_write(), which in turn are called out of vpci_write(). Yet that
> >>> function already holds the lock, and the lock is not (currently)
> >>> recursive. (For the 3rd caller of the function - init_bars() - otoh
> >>> the locking looks to be entirely unnecessary.)
> >> Well, you are correct: if tmp != pdev then it is correct to acquire
> >> the lock. But if tmp == pdev and rom_only == true
> >> then we'll deadlock.
> >>
> >> It seems we need to have the locking conditional, e.g. only lock
> >> if tmp != pdev
> > Which will address the live-lock, but introduce ABBA deadlock potential
> > between the two locks.
> I am not sure I can suggest a better solution here
> @Roger, @Jan, could you please help here?

I think we could set the locking order based on the memory address of
the locks, ie:

if ( &tmp->vpci_lock < &pdev->vpci_lock )
{
    spin_unlock(&pdev->vpci_lock);
    spin_lock(&tmp->vpci_lock);
    spin_lock(&pdev->vpci_lock);
    if ( !pdev->vpci || &pdev->vpci->header != header )
        /* ERROR: vpci removed or recreated. */
}
else
    spin_lock(&tmp->vpci_lock);

That however creates a window where the address of the BARs on the
current device (pdev) could be changed, so the result of the mapping
might be skewed. I think the guest would only have itself to blame for
that, as changing the position of the BARs while toggling memory
decoding is not something sensible to do.

> >
> >>>> @@ -222,10 +239,10 @@ static int msix_read(struct vcpu *v, unsigned long addr, unsigned int len,
> >>>>                break;
> >>>>            }
> >>>>    
> >>>> +        msix_put(msix);
> >>>>            return X86EMUL_OKAY;
> >>>>        }
> >>>>    
> >>>> -    spin_lock(&msix->pdev->vpci->lock);
> >>>>        entry = get_entry(msix, addr);
> >>>>        offset = addr & (PCI_MSIX_ENTRY_SIZE - 1);
> >>> You're increasing the locked region quite a bit here. If this is really
> >>> needed, it wants explaining. And if this is deemed acceptable as a
> >>> "side effect", it wants justifying or at least stating imo. Same for
> >>> msix_write() then, obviously.
> >> Yes, I do increase the locking region here, but the msix variable needs
> >> to be protected all the time, so it seems to be obvious that it remains
> >> under the lock
> > What does the msix variable have to do with the vPCI lock? If you see
> > a need to grow the locked region here, then surely this is independent
> > of your conversion of the lock, and hence wants to be a prereq fix
> > (which may in fact want/need backporting).
> First of all, the implementation of msix_get is wrong and needs to be:
> 
> /*
>   * Note: if vpci_msix found, then this function returns with
>   * pdev->vpci_lock held. Use msix_put to unlock.
>   */
> static struct vpci_msix *msix_get(const struct domain *d, unsigned long addr)
> {
>      struct vpci_msix *msix;
> 
>      list_for_each_entry ( msix, &d->arch.hvm.msix_tables, next )

Strictly speaking you would also need to introduce a lock here to
protect msix_tables.

This was all designed when hot-adding (or removing) PCI devices to the
domain wasn't supported.

>      {
>          const struct vpci_bar *bars;
>          unsigned int i;
> 
>          spin_lock(&msix->pdev->vpci_lock);
>          if ( !msix->pdev->vpci )
>          {
>              spin_unlock(&msix->pdev->vpci_lock);
>              continue;
>          }
> 
>          bars = msix->pdev->vpci->header.bars;
>          for ( i = 0; i < ARRAY_SIZE(msix->tables); i++ )
>              if ( bars[msix->tables[i] & PCI_MSIX_BIRMASK].enabled &&
>                   VMSIX_ADDR_IN_RANGE(addr, msix->pdev->vpci, i) )
>                  return msix;
> 
>          spin_unlock(&msix->pdev->vpci_lock);
>      }
> 
>      return NULL;
> }
> 
> Then, both msix_{read|write} can dereference msix->pdev->vpci early,
> this is why Roger suggested we move to msix_{get|put} here.
> And yes, we grow the locked region here and yes this might want a
> prereq fix. Or just be fixed while at it.

Ideally yes, we would need a separate fix that introduced
msix_{get,put}, because the currently unlocked regions of
msix_{read,write} do access the BAR address fields, and doing so
without holding the vpci lock would be racy. I would expect that the
writing/reading of the addr field is done in a single instruction, so
it's unlikely to be a problem in practice. That's kind of similar to
the fact that modify_bars also accesses the addr and size fields of
remote BARs without taking the respective lock.

Once the lock is moved outside of the vpci struct and it's used to
assert that pdev->vpci is present then we do need to hold it while
accessing vpci, or else the struct could be removed under our feet.

Roger.


From xen-devel-bounces@lists.xenproject.org Fri Feb 04 11:00:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 11:00:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265379.458741 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFwKe-00009P-JW; Fri, 04 Feb 2022 11:00:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265379.458741; Fri, 04 Feb 2022 11:00:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFwKe-00009I-Fw; Fri, 04 Feb 2022 11:00:48 +0000
Received: by outflank-mailman (input) for mailman id 265379;
 Fri, 04 Feb 2022 11:00:47 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nFwKd-00009C-5F
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 11:00:47 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nFwKb-0007Kr-Rr; Fri, 04 Feb 2022 11:00:45 +0000
Received: from 54-240-197-225.amazon.com ([54.240.197.225] helo=[192.168.2.73])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nFwKb-0005AC-Lw; Fri, 04 Feb 2022 11:00:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=gqgnLLmbPo+T3r4xhRHV2tZ9fcEAOm2xqli39SrES64=; b=gcNtWYaUU8OV+xyBUv7olGLw6G
	HMq7cB1y/i9LkZ54Uz4txjGrCc6OGqLycpQc+fgxBEmYj6gbn1T8glCx/Bi4z3mnFGDf6r4zQcTcq
	K75xZ5KvqeaZd99dMN4WoOVePKSwMMA/qZiHraQHLFJ3cghdmW1zjeGi1yw23UQgQ+m4=;
Message-ID: <e5f0fd5d-b685-c559-6850-c2e06824b7d7@xen.org>
Date: Fri, 4 Feb 2022 11:00:42 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.1
Subject: Re: [PATCH v6 01/13] xen/pci: arm: add stub for is_memory_hole
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Artem Mygaiev <Artem_Mygaiev@epam.com>,
 "roger.pau@citrix.com" <roger.pau@citrix.com>,
 "jbeulich@suse.com" <jbeulich@suse.com>,
 "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
 "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
 "paul@xen.org" <paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-2-andr2000@gmail.com>
 <000ac24e-fdac-855d-7fb4-2165a1192ea4@xen.org>
 <19e50632-5865-9a75-756b-88db85007e96@epam.com>
 <d9741ff0-2152-6792-5249-09e3b0960972@xen.org>
 <43cab3d0-1a62-dca0-0d2d-5ea8fe237b21@epam.com>
 <ad90a3df-7049-8ff2-979a-dec3b8c542a1@xen.org>
 <86e51f3c-6ef8-a86d-acf3-38334db430a7@epam.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <86e51f3c-6ef8-a86d-acf3-38334db430a7@epam.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit



On 04/02/2022 10:35, Oleksandr Andrushchenko wrote:
> 
> 
> On 04.02.22 11:57, Julien Grall wrote:
>> Hi,
>>
>> On 04/02/2022 09:47, Oleksandr Andrushchenko wrote:
>>>>> Could you please help me with the exact message you would like to see?
>>>>
>>>> Here a summary of the discussion (+ some my follow-up thoughts):
>>>>
>>>> is_memory_hole() was recently introduced on x86 (see commit 75cc460a1b8c "xen/pci: detect when BARs are not suitably positioned") to check whether the BAR are positioned outside of a valid memory range. This was introduced to work-around quirky firmware.
>>>>
>>>> In theory, this could also happen on Arm. In practice, this may not happen but it sounds better to sanity check that the BAR contains "valid" I/O range.
>>>>
>>>> On x86, this is implemented by checking the region is not described is in the e820. IIUC, on Arm, the BARs have to be positioned in pre-defined ranges. So I think it would be possible to implement is_memory_hole() by going through the list of hostbridges and check the ranges.
>>>>
>>>> But first, I'd like to confirm my understanding with Rahul, and others.
>>>>
>>>> If we were going to go this route, I would also rename the function to be better match what it is doing (i.e. it checks the BAR is correctly placed). As a potentially optimization/hardening for Arm, we could pass the hostbridge so we don't have to walk all of them.
>>> It seems this needs to live in the commit message then? So, it is easy to find
>>> as everything after "---" is going to be dropped on commit
>> I expect the function to be fully implemented before this is will be merged.
>>
>> So if it is fully implemented, then a fair chunk of what I wrote would not be necessary to carry in the commit message.
> Well, we started from that we want *something* with TODO and now
> you request it to be fully implemented before it is merged.

I don't think I ever suggested this patch would be merged as-is. Sorry 
if this may have crossed like this.

Instead, my intent by asking you to send a TODO patch is to start a 
discussion how this function could be implemented for Arm.

You sent a TODO but you didn't provide any summary on what is the issue, 
what we want to achieve... Hence my request to add a bit more details so 
the other reviewers can provide their opinion more easily.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Feb 04 11:05:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 11:05:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265388.458753 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFwPD-0000o9-64; Fri, 04 Feb 2022 11:05:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265388.458753; Fri, 04 Feb 2022 11:05:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFwPD-0000o2-25; Fri, 04 Feb 2022 11:05:31 +0000
Received: by outflank-mailman (input) for mailman id 265388;
 Fri, 04 Feb 2022 11:05:29 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nFwPB-0000ns-DV; Fri, 04 Feb 2022 11:05:29 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nFwPB-0007Pp-6W; Fri, 04 Feb 2022 11:05:29 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nFwPA-0001EG-Iz; Fri, 04 Feb 2022 11:05:28 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nFwPA-0005yp-IX; Fri, 04 Feb 2022 11:05:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=qmGuGETtf9gBHfFGHP6margtOmdnHUQnVtUUqyY5NlY=; b=b8SPzEz8JqPT+B+M/DkK9hwGvk
	IkAEYmWKd/wwWxRScf9fbsnTUkhzInNeInQaTeLX0/sRLOoNRFUXZMpnNOAc1xVO9z1hKA6G2Pju6
	YYZIZusESvaFRUybsvhZhVeFvQI+KOsgOe3XYAr1VhPEHyuq3CdfBTRDCiupvXg/wEr0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168001-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 168001: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=75cc460a1b8cfd8e5d2c4302234ee194defe4872
X-Osstest-Versions-That:
    xen=b17e0ec72eded037297f34a233655aad23f64711
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 04 Feb 2022 11:05:28 +0000

flight 168001 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168001/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167994
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167994
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167994
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167994
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 167994
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 167994
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167994
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167994
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167994
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167994
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167994
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167994
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 xen                  75cc460a1b8cfd8e5d2c4302234ee194defe4872
baseline version:
 xen                  b17e0ec72eded037297f34a233655aad23f64711

Last test of basis   167994  2022-02-03 08:04:48 Z    1 days
Testing same since   168001  2022-02-03 19:39:46 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   b17e0ec72e..75cc460a1b  75cc460a1b8cfd8e5d2c4302234ee194defe4872 -> master


From xen-devel-bounces@lists.xenproject.org Fri Feb 04 11:14:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 11:14:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265401.458764 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFwXh-0002Ng-7e; Fri, 04 Feb 2022 11:14:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265401.458764; Fri, 04 Feb 2022 11:14:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFwXh-0002NZ-4Y; Fri, 04 Feb 2022 11:14:17 +0000
Received: by outflank-mailman (input) for mailman id 265401;
 Fri, 04 Feb 2022 11:14:15 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=46ws=ST=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nFwXf-0002NT-5R
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 11:14:15 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 93080d86-85ab-11ec-8f75-fffcc8bd4f1a;
 Fri, 04 Feb 2022 12:14:11 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 93080d86-85ab-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1643973251;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=ZGCfVPt2AFz0LLCJClX+I7V5KzaAatWi/C7jDa91Gok=;
  b=MTdF1Si90Ql3dL+hH00LRnpDMg+Ge0a7NdaMbGgbBIKTxZftimcUs0MW
   B5GdPKFCPObTuxO80QfD0S+OkpXnmAfA5tS9DFVUFlOMLpYUGnBbM1sw9
   8j4e+eDfyjM4tVP4SnVPqHGZMbPoLLy+V3MzRGvSC9ay8Bujs+Lo4OKUl
   U=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: UyWjaO6sFXOeqdAduZltg+W+Brk5AEfeRDBSgD7mW6PCF/Po197fc/HIgFSUFWr5TDAbmbmPtU
 4A4LVOvhdyD8FwErgRhROFG5AkZmH2KYHU6u7aFAKYLJOJpqAlWkl0rzk9oDIAmT1OyXn7+c7G
 qT/Vpcav6RQA6HSVSSa7prU6xu0yV21Ja5pVYEQfJcdWpWiKxVFocDWkOTkrvHCQU8oNvH7CFU
 B6npd/Jo8pV2Lc2A4+Qc7voR+0hGclw1n8FYkQjUBzDpjxzkEb0lEn9Pkh9XpreG9r2ApwJYES
 7najkuVDGSoguvxyZ6X6+cKG
X-SBRS: 5.1
X-MesageID: 63493074
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:AMsLhqBN+g0MIRVW/wvlw5YqxClBgxIJ4kV8jS/XYbTApD0qhjdTn
 TBOWD+POfmDYGbxe41ybI2w8UgE75SEn99rQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMo/u1Si6FatANl1ElvU2zbue6WL6s1hxZH1c+En970U47wYbVv6Yz6TSHK1LV0
 T/Ni5W31G+Ng1aY5UpNtspvADs21BjDkGtwUm4WPJinj3eH/5UhN7oNJLnZEpfNatI88thW5
 Qr05OrREmvxp3/BAz4++1rxWhVirrX6ZWBihpfKMkQLb9crSiEai84G2PQghUh/iCTUx897+
 Pp0kLu9RikvMKDKu+EBTEwNe81+FfUuFL7vJHG+tYqYzlHccmuqyPJrZK00FdRGoKAtWzgIr
 KFGbmBWBvyAr7veLLaTUO5ji95lNMD2FIgepmth3XfSCvNOrZXrHf6WtIQAg2tYasZmGfzbY
 /QfdDRWTDvOXRhINQcpFpgcg7L97pX4W2IB8w/EzUYt2EDLxRF1+KjgNpzSYNPibexPgkudk
 UfX8G34Dw8yOcSWzHyO9XfEruXChz/hUYQeUrix7Od3gUa7z3YWThYRUDOTsfS/z0KzRd9bA
 0gV4TY167g/8lSxSdvwVAH+p2SL1jYGUtpNF6sh6QeCyoLd+QPfDW8BJhZ/b9ghuN4zVCYd/
 FaDlNP0BhRiqLSQD3ma89+8ije/OjMcK2MYUgYCQREY+NnooIw1jRXnQ85qFei+ididMTP6z
 i2OrSM+r64OlsNN3KK+lXjFnjatq57hXgMzoALNUQqNyQd0Z5WsYYCy3mTK9vZLLIufTV6ps
 WANno6V6+VmJYqWiCWHTeEJHbeoz/WIKjvRhRhoBZZJyti20yf9J8YKumg4fRo3dJZfEdP0X
 KPNkQBAucdMNkuFVIpQbo2fDcony4vlCcuwA5g4ceFySpR2cQaG+gRnakiRw33hnSAQrE0vB
 XuIWZ3yVChHUMyL2BLzHr5AiuFzmkjS0EuOHciT8vix7VaJiJd5o58hOUDGUO025bjsTO79o
 4cGbJviJ/myvYTDjsjrHWw7cAhiwZsTX8meRylrmgireFEO9IYJUKe5/F/ZU9Y595m5b8+Rl
 p1HZmdWyUDkmVrMIhiQZ3ZoZdvHBMgj9iJgYHJxbA33gBDPhLpDCo9FLPPbmpF8rIReIQNcF
 aFZK61s/NwTItg4x9jtRcak99EzHPharQmPIzCkcFACk21IHGT0FivfVlK3rkEmV3Pv3eNn+
 uHI/l6LEPIrGlU5ZO6LOa3H8r9ElSVE8A6EdxCTeYc7lYSF2NUCFhEdeddscpxVdEWemmDHv
 +tUaD9BzdTwT0YO2IChrYiPrpuzEvs4GUxfHmLB6q2xOzWc9W2mqbKsms7RFdwEfG+rqqike
 8tPyPTwbK8OkFpQ6tIuGLd316MuodDoouYCnAhjGXzKaXWtC69hfSbajZUe6PUVy+8LoxayV
 2KO5sJeZeeDNvT6HQNDPwEidOmCi60Zw2GA8fQvLUzmzyZr577bA15KNhyBhXUFfrt4OY8o2
 8k7v8sS51DtgxYmKI/e3CtV636NPjoLVKB+7sMWB4riiwwKzFBeYMODVn+qsc/XM9gVaxskO
 D6ZgqbGlo9w/EuafiphD2XJ0MpcmY8K5EJAwmgdKgnbgdHCnPI2gkFcqGxlUgRPwxxb+OtvI
 Ww3ZVZtLKCD8jo01shOW2egR1NICBGDoxGjzlIIkCvSTlWyV3yLJ2o4YL7f8Ecc+mNaXz5a4
 LDHlzq1DWe0JJn8jnkoREpoi/3/VtggpATNlfeuE9mBA5RnMyHuhbWjZDZQphbqaS/raJYre
 QW+ED5MVJDG
IronPort-HdrOrdr: A9a23:q0JI5KhF9u5klKg9OfaxHCqQE3BQXi8ji2hC6mlwRA09TyXBrb
 HIoB1p726TtN9xYgBbpTnuAtjifZqxz/FICMwqTNOftWrdyRaVxeNZnOnfKlTbckWUnIMw6U
 4jSdkaNDSaNykFsS+O2mmF+qEboeVvnprHuQ6U9QYVcegjUdAZ0y5JTj+BFEt4XQ9HAod8Oq
 a9y6N81kWdUEVSV9+8AHYdWejFupnsr7LJJTA7JzNP0njzsduPgISKYiRw8C1uKA9y/Q==
X-IronPort-AV: E=Sophos;i="5.88,342,1635220800"; 
   d="scan'208";a="63493074"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=kBxjofkC8OmiDahhuVp/OFYJDZVa0k6iGDmkgqJeMT1cKVhDCue1q8cDOo5d3BTVbyEzJZngXLuwAfrFJwj3PzFBwPwbIHHIHjhRCv55eATmRj2xWEVFc1LxT54iajHpMUNYvw9exCX4IyFoC/ZZ9OLDiNPdbnpI6JYU08EBcXflVN6e6wgnjiwtbQVKOWkByeX870WF+0Apu5qUMGjWnhIQgNL4ffeoiQGKsFguUenPxnKddQcSihjFQ31KAMyojReZKjZdIQN3HXauBURdmToVRWKTt9PJIMMqlMBHnL6QVCSABbii77AbX4tIHhCfSc6134yBxF5IDhpiS2jsqA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=4xdNYezEZ3ZYqc8knLkXt2lQHsUTsGpM53PxmvAtwck=;
 b=DsJGATfSJDUpUsishGfcGljMsoXkFVPLrwLVjvoD4EAF4OR30xPgIP7AB1AOcAq6uZT9Ad9DRWHklFy9SMTfsPd/xOQqz+pl/y61i9oa5KSOlvWy+640OGmkOKqXgoQuqhMMOVPacEp/pDpS2+/TDVQ2+r6KGT0LgbX1dozIw8uXnnTsaah5XHkxkGLBrWDvx3FKItEAwcSeRNWD/SrSVpBwMVgxS4Ik57QR/sVp8eqQG/4Pa3l1HaAlkIHKOb7A2FpY/ZifMqezOcysEDwgW8MHwTdKksx66/UN5dkTEPOYW0DgMtWwy8qn98bAQMEygNYs5s5pYgp5BoWrBN9gjA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=4xdNYezEZ3ZYqc8knLkXt2lQHsUTsGpM53PxmvAtwck=;
 b=tq8nkRtP+pTv2j6TGPK5fmEP8TLqPjH7UY7qCSzuVfFz7ZQE3pjtXFQc6oz56SGva7+1FVA6SPxfSUtLt82xw2L3MNsnXxe1UTmhjXDUVmVO3xv0Ub3rwSy6GhwEIjDAbXixqPHVxudAF0S9N7h+K8eeExzCRHsZNvHVnF7bQGs=
Date: Fri, 4 Feb 2022 12:13:53 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>,
	"julien@xen.org" <julien@xen.org>, "sstabellini@kernel.org"
	<sstabellini@kernel.org>, Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Artem Mygaiev <Artem_Mygaiev@epam.com>,
	"andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
	"george.dunlap@citrix.com" <george.dunlap@citrix.com>, "paul@xen.org"
	<paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>, Rahul Singh
	<rahul.singh@arm.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Message-ID: <Yf0KcVD8W05A4fbB@Air-de-Roger>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-4-andr2000@gmail.com>
 <7209889d-8f17-61cc-72a4-97f6dbc1d54d@suse.com>
 <2cf022f8-b000-11b7-c6b9-90a56bc6e2ea@epam.com>
 <04726915-f39f-9019-436e-4399533c9fc3@suse.com>
 <9ed3f4ac-0a2d-ed45-9872-7c3f356a469e@epam.com>
 <c3a99712-cf7c-37da-aac1-f2ee00e6d53b@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <c3a99712-cf7c-37da-aac1-f2ee00e6d53b@suse.com>
X-ClientProxiedBy: LO2P123CA0097.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:139::12) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 83861945-a761-4c30-ddd5-08d9e7cf7061
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6272:EE_
X-Microsoft-Antispam-PRVS: <SJ0PR03MB62724AF13ABC820F5A3E71368F299@SJ0PR03MB6272.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: O97gpHZjvCkmdbAhUwXZBRB64uDhkCsiQfl+viAfIhDveSws/XRdHIG5V/jT3xiRGzl+3N+wJEJHgRkmgm2OHhewMi97mBBWq0iQl/NS624W6uqwabCxb0eK0AE4EA0nmfkcRYGAqUfu1INAlNqV86ER8pVOE3NzlPk/lYL87FK1+t7jdPUnI6UrukY/FZL3DnTxBJ/GOAlesqys1MgXAomCilVm49TbYyjEoVv+OJ2XB+nZJ4CG/6xq6FbwST6XtdQqNdlJoSnmBhV05vKLsSH2u+td52446PZCqh5NMDB2yom53IDWnd3jgnoS/QrEKJ+QG0B7l0GO/WLl4aCD7YJSrLC3AVHdsXG57IjNtF77xku5GmZ4Rdff3EfpWOhdIzm33yigTKCodvG9W4nf43tuwScQOW3vQ2D1eTRGUxrj4tQHw/5Pnr8V2fdXwWd4sS38BP7fDo2nH71BlxvAHScj+ZrFEmenUXhnxsXjX5Vmts8k9kwFvkG/7dOR06464WRelp1ZmsD/7Cn6/u1ri38PeH/OFBGsY1dsl1YdhDN/n9ZzxNt8z7SBNJetwSLf7Dz7oI1cHt3MjaxPbm9Ztf15Lyk0GFR4tLHIdQs2nX111YdTrMJS+LxTxL2jV6RRHUNhxQV/I3WMnq8veqD28A==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(86362001)(6486002)(83380400001)(26005)(54906003)(186003)(6916009)(6506007)(8676002)(8936002)(66476007)(4326008)(66556008)(66946007)(508600001)(6666004)(82960400001)(316002)(2906002)(6512007)(85182001)(9686003)(38100700002)(5660300002)(53546011)(7416002)(33716001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N2hDSkhSbEN6ZERiS2R0KzZBSnRQcnE4bTRtVzF6UWVzUFdnVnM4ZzdlbW1C?=
 =?utf-8?B?eW9DbFlwZTdRRE13RHBXeWpwbFduNDZEOWRLN0pnZEtoZXpTUnVEdThxZ1cy?=
 =?utf-8?B?Zk5NTWFxZUxBVmtqdTFyREtuanEzdmdXNU1DaEd3aVFWZTlGMWJjNGZIUTJz?=
 =?utf-8?B?NFA0ZXB0YWE0WGxDdERRTTFmRmM2UCt0YkRPNmpJcVJkTUYzMlR3c0tpWUxP?=
 =?utf-8?B?VXAwUG9BSEYzOFI5SThwVlRqSGhwdkZMdU9HM2lDV2tQQ1RHcU9seFlsSDBh?=
 =?utf-8?B?K0E2ekJId2NQZG52VWpuQmFuekFlZkhENmZaeXZVZHJsWUdWb1lUN3RwbXA3?=
 =?utf-8?B?NjVFeG1Ua3BSVUl6WVN0a2twQTg0UFdDVGh2Tm5SZHlwRkVMUm1BbklNTU5s?=
 =?utf-8?B?N0NFbkRYNGtJS2lwUzQwcXdGYzdxOGliRDBxZmlheU13SEN6L01nYVpiVFRm?=
 =?utf-8?B?NndoRnU4Vk44SkphQTdzanhIQjQ3SHhoWVRVTFJwcUlrbUVCY2JjRi9EL2tp?=
 =?utf-8?B?cWZwNXJpNmo1dXo1em9ZaXZoYXV4cm45bHd5R01SNEptVE9PRWNMaDArbjJY?=
 =?utf-8?B?cUtjbGRKd1BZcGlkTEwwRXFYYUxLaFVKbXNtckcvbXpiWlJSWWIvdERrTlZO?=
 =?utf-8?B?dE0rbnNrS1p0QjBFakpHeU00ZjhDQUpoeHhOWHFVUlplV21SM3FjVDVvcDRQ?=
 =?utf-8?B?bitCZWpuVEhhWXo3bXBkQStpbmRkaDFFVGIwYjhXU0FhM2FDQTMwQ2RmRXo0?=
 =?utf-8?B?UFN1ZVYzOE5NcHhpWllTNkwvTmptUXZwakczNFNSa0VMTDJhZmpoejc0anhs?=
 =?utf-8?B?MVZqdWFvU21UdUxwMWRxazBsT1FPaEZ2VmFycVRhK2tRVWZKZkxzMk5mVzFH?=
 =?utf-8?B?Z2hOMXh0eEU5T3NLeks3WXRFK01PSk9oU010SFBQeUdtemNiOGJCU2MvYkpP?=
 =?utf-8?B?QXBiN0RQMitueHg3bUtZR1VDWGtyTFhpZEZBVWN3azN2eGowMkZEN0prTy9T?=
 =?utf-8?B?RGE2S0Q2QWVuV1djb0pEZW00WkFMQmhTV2Q2Z0FwOTlQcUdGKzhMOS90NEp0?=
 =?utf-8?B?QU5lRktYT3UyK3NwRFpaVDhmaC9hMjlrTjBGU0E0ZFFBb0hxVjdiWTVqeFpz?=
 =?utf-8?B?Ym9JU2FFNnJNZ0VsMVpiamU5Y0t5LzFjbTZzZVZpNnZoTFQvQm1ITFJEaXRo?=
 =?utf-8?B?SHpVK0FDaExEWDF3QWpJZXMxemdrcllieEZrTUIzNWhESldlWnJ3SmZXY1Zz?=
 =?utf-8?B?dHZyRURDVkxqZWNyUlBIZGcrUlFhR21qSVVIY2QvcTJQQlc4V0d6bi9rZXhn?=
 =?utf-8?B?bUFMVXFFSVNFSDJGZTQwSkREUndUKzVzWlhkSFNyay9IdkI1U0RhTWVNZzFR?=
 =?utf-8?B?TFdVWkFnNmh0WWpUUCt1QlByd0tha1lPSHcvMEJoeWR3ZGFyL3lDN1VIT1Zr?=
 =?utf-8?B?WWp6SUtKSDJaT3ZLd0lWUlFpMmhUU0ZrM0RScTFFRHN3RWhpZmJLQnRlS2Yy?=
 =?utf-8?B?Yk5HRTJSTnduZVVjKzkyaUptYXhpS0xUTGFtajB4L0FBZjdVRWlVd3JveUYy?=
 =?utf-8?B?Y2xHRkQybDFYMTh4ZTFLUFVWdjVUREhLeW9GOEpBTlBXN0w1bkttMTdMWUtW?=
 =?utf-8?B?WWEycllWMk8yZ1grYTJaOStYOVhHbUgycjJhamJpcWVZaER4cUNyUHl0Wlh0?=
 =?utf-8?B?eURUMWF2T3ZwU1NHR1pDcHluUUk2cVA1emdUQXpyVnpwZWFSTVNKTWkvTUJy?=
 =?utf-8?B?Mjc0Znowd2lGTWROb2ROUmZtYlgrc3NKYjcxaHNseFNhRVFLMENYbUJpTnBm?=
 =?utf-8?B?dTloNEN4TWNGVitNL1RXQ2tsNkVCRGxibi9yd0g2S3RwcGJwdndrZ3JjMjU4?=
 =?utf-8?B?RHRCWUFOMVBOaGhpT2tSZTlzU0VFRU4zdDFSeTZSR0NiOGNVdS9xU2lha1Zs?=
 =?utf-8?B?cTRoRHduTlF5ZVp4TFpmM2VUK2YzdytFRnMxQVI4Z2Z3UTh1bUdObHQvenBS?=
 =?utf-8?B?R25CaHRtUHVkNGxrZXA1Yk41a01tYXJXbmxCZlBLL0xUZmNCL01XVjZ2R0hv?=
 =?utf-8?B?bVJWVVZCcE9GK0s1UU1mOFhGY1lqbTVVZTJTMWtNWGlvaWpkNVJWeWg1Vzky?=
 =?utf-8?B?YWtyQlFGekNRR2J2UGJyVkFLM0wycVhUSHFiTGk0TmJ2MTBkemtkQUluQWtp?=
 =?utf-8?Q?TNdffhrvQ94oSYwtfQcuFoE=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 83861945-a761-4c30-ddd5-08d9e7cf7061
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Feb 2022 11:13:58.0750
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: saTziUUQwgvqxZ22H4dLHB8RKopiNBFfWeXB6LV+r5hYAHQPSHwbiWtu0xxMi8OkZHKHUUPrOXWejVzzJ45nTg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6272
X-OriginatorOrg: citrix.com

On Fri, Feb 04, 2022 at 11:49:18AM +0100, Jan Beulich wrote:
> On 04.02.2022 11:12, Oleksandr Andrushchenko wrote:
> > On 04.02.22 11:15, Jan Beulich wrote:
> >> On 04.02.2022 09:58, Oleksandr Andrushchenko wrote:
> >>> On 04.02.22 09:52, Jan Beulich wrote:
> >>>> On 04.02.2022 07:34, Oleksandr Andrushchenko wrote:
> >>>>> @@ -285,6 +286,12 @@ static int modify_bars(const struct pci_dev *pdev, uint16_t cmd, bool rom_only)
> >>>>>                    continue;
> >>>>>            }
> >>>>>    
> >>>>> +        spin_lock(&tmp->vpci_lock);
> >>>>> +        if ( !tmp->vpci )
> >>>>> +        {
> >>>>> +            spin_unlock(&tmp->vpci_lock);
> >>>>> +            continue;
> >>>>> +        }
> >>>>>            for ( i = 0; i < ARRAY_SIZE(tmp->vpci->header.bars); i++ )
> >>>>>            {
> >>>>>                const struct vpci_bar *bar = &tmp->vpci->header.bars[i];
> >>>>> @@ -303,12 +310,14 @@ static int modify_bars(const struct pci_dev *pdev, uint16_t cmd, bool rom_only)
> >>>>>                rc = rangeset_remove_range(mem, start, end);
> >>>>>                if ( rc )
> >>>>>                {
> >>>>> +                spin_unlock(&tmp->vpci_lock);
> >>>>>                    printk(XENLOG_G_WARNING "Failed to remove [%lx, %lx]: %d\n",
> >>>>>                           start, end, rc);
> >>>>>                    rangeset_destroy(mem);
> >>>>>                    return rc;
> >>>>>                }
> >>>>>            }
> >>>>> +        spin_unlock(&tmp->vpci_lock);
> >>>>>        }
> >>>> At the first glance this simply looks like another unjustified (in the
> >>>> description) change, as you're not converting anything here but you
> >>>> actually add locking (and I realize this was there before, so I'm sorry
> >>>> for not pointing this out earlier).
> >>> Well, I thought that the description already has "...the lock can be
> >>> used (and in a few cases is used right away) to check whether vpci
> >>> is present" and this is enough for such uses as here.
> >>>>    But then I wonder whether you
> >>>> actually tested this, since I can't help getting the impression that
> >>>> you're introducing a live-lock: The function is called from cmd_write()
> >>>> and rom_write(), which in turn are called out of vpci_write(). Yet that
> >>>> function already holds the lock, and the lock is not (currently)
> >>>> recursive. (For the 3rd caller of the function - init_bars() - otoh
> >>>> the locking looks to be entirely unnecessary.)
> >>> Well, you are correct: if tmp != pdev then it is correct to acquire
> >>> the lock. But if tmp == pdev and rom_only == true
> >>> then we'll deadlock.
> >>>
> >>> It seems we need to have the locking conditional, e.g. only lock
> >>> if tmp != pdev
> >> Which will address the live-lock, but introduce ABBA deadlock potential
> >> between the two locks.
> > I am not sure I can suggest a better solution here
> > @Roger, @Jan, could you please help here?
> 
> Well, first of all I'd like to mention that while it may have been okay to
> not hold pcidevs_lock here for Dom0, it surely needs acquiring when dealing
> with DomU-s' lists of PCI devices. The requirement really applies to the
> other use of for_each_pdev() as well (in vpci_dump_msi()), except that
> there it probably wants to be a try-lock.
> 
> Next I'd like to point out that here we have the still pending issue of
> how to deal with hidden devices, which Dom0 can access. See my RFC patch
> "vPCI: account for hidden devices in modify_bars()". Whatever the solution
> here, I think it wants to at least account for the extra need there.

Yes, sorry, I should take care of that.

> Now it is quite clear that pcidevs_lock isn't going to help with avoiding
> the deadlock, as it's imo not an option at all to acquire that lock
> everywhere else you access ->vpci (or else the vpci lock itself would be
> pointless). But a per-domain auxiliary r/w lock may help: Other paths
> would acquire it in read mode, and here you'd acquire it in write mode (in
> the former case around the vpci lock, while in the latter case there may
> then not be any need to acquire the individual vpci locks at all). FTAOD:
> I haven't fully thought through all implications (and hence whether this is
> viable in the first place); I expect you will, documenting what you've
> found in the resulting patch description. Of course the double lock
> acquire/release would then likely want hiding in helper functions.

I've been also thinking about this, and whether it's really worth to
have a per-device lock rather than a per-domain one that protects all
vpci regions of the devices assigned to the domain.

The OS is likely to serialize accesses to the PCI config space anyway,
and the only place I could see a benefit of having per-device locks is
in the handling of MSI-X tables, as the handling of the mask bit is
likely very performance sensitive, so adding a per-domain lock there
could be a bottleneck.

We could alternatively do a per-domain rwlock for vpci and special case
the MSI-X area to also have a per-device specific lock. At which point
it becomes fairly similar to what you propose.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Feb 04 11:25:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 11:25:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265409.458775 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFwiO-0003rm-Al; Fri, 04 Feb 2022 11:25:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265409.458775; Fri, 04 Feb 2022 11:25:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFwiO-0003rf-64; Fri, 04 Feb 2022 11:25:20 +0000
Received: by outflank-mailman (input) for mailman id 265409;
 Fri, 04 Feb 2022 11:25:18 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=u+82=ST=epam.com=prvs=4034f0a382=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nFwiM-0003rZ-6N
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 11:25:18 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1fb93447-85ad-11ec-8f75-fffcc8bd4f1a;
 Fri, 04 Feb 2022 12:25:16 +0100 (CET)
Received: from pps.filterd (m0174679.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 214BCnkn000943;
 Fri, 4 Feb 2022 11:25:11 GMT
Received: from eur02-am5-obe.outbound.protection.outlook.com
 (mail-am5eur02lp2052.outbound.protection.outlook.com [104.47.4.52])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e11uerb1n-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 04 Feb 2022 11:25:11 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM9PR03MB7265.eurprd03.prod.outlook.com (2603:10a6:20b:266::6)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.16; Fri, 4 Feb
 2022 11:25:06 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6%3]) with mapi id 15.20.4951.014; Fri, 4 Feb 2022
 11:25:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1fb93447-85ad-11ec-8f75-fffcc8bd4f1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=GE72b01n+6nYD2ecYad4INC0lHSp7gES93QxxV3jjS8VxUtFxyHFPP2RcH9Fp65Lar1q9FW+Zzjax+SKEsRilrkn+ToajGVg3mAzGg1+iWr8NxwKGfIG6iF5R/OzAjTexR2CvugiFqXb1iy0BIyryDJv0eVe6KWvBzm2IXvi6A/VoWBw5QOZpq2R+XayBVD0XKCQeKrnG3eGajh22uEoMpXNT/dVnumYkApvHVhacaws+GO6Uye5w8+fbDbc+4xvj1HAWLMyUrRP3r9n0saLZdflJcdp+0R2mar6pMFzSLssnsg6a5pM223U0/CXi6E5kR0flc0aRinxiIgm9tAfNw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=qj3zpZmujP9hb71x77ZPgyJjmC8HFxdi35CoBI/TN6Y=;
 b=Z1BK0Mfv7DTHVrI8ZSGYlmezo7co0uo04F9vYrxcJoFtzxTy2Lm/6v4wexUbfx/dnQjUoUc0qhldiXx7VfGeuiqnngMsSqlMLq2FkS3rVTtjxEg6vUR4jchGt7+AFbnoFgdgezL35SShC/Jkebg5YdE77yGpEvcNIYY2YKN8Z/KP3YAxLaDoTvUYUPrCekKP7Y6UdEpNwHv2GiqVWBypeQmu3lKPMeL2ggeNDDEOjhnwaHx0pbqGYVgyd8rTgcbp47YESzuuUAvyYbaxNZvvFpBn+1lHqlmW8pcGcm/KPxR2Po2RPCODhKyTFtMOPcEkOIVSifBrhdHApOSZ8YjWFw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=qj3zpZmujP9hb71x77ZPgyJjmC8HFxdi35CoBI/TN6Y=;
 b=aaZ4t3dyaTeLZVjweeB3rfF34LzQAJbDJeAN8JEuNi0IOz+J0jCOlE33KvrJl8WLZexLtwtWGttACZGV7hDBGS9VDHx6RNkoZrOFHCFCU8H5BCaAQmpfhqHeb9PWkfRqmsPBBd3wmSSKXi4HeOdY3XpVpBhRz2zbPQHR4eRiohMhi4iuptmaVUEjahfhnbS+1p6QIpiQNdbbLQ7+eWrmT7hpqs9rRRdTWpd/s0LFmIkCukjhSh7iBCW31p5w4l3ICV98WI7WXVlwh7jmA3rGFKVX5FNMGN2dk704Xq8M2MZw7vL2YLaJRxJOe1wEIG68XhbxXbUjwd3zVm/SxyEzbQ==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Julien Grall <julien@xen.org>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: "sstabellini@kernel.org" <sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "roger.pau@citrix.com" <roger.pau@citrix.com>,
        "jbeulich@suse.com"
	<jbeulich@suse.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v6 01/13] xen/pci: arm: add stub for is_memory_hole
Thread-Topic: [PATCH v6 01/13] xen/pci: arm: add stub for is_memory_hole
Thread-Index: 
 AQHYGZFbEg6Erttt1UCNei+XrySHEqyDFYiAgAAC4gCAAAsigIAAAbyAgAAC0oCAAAq4gIAABvIAgAAG0IA=
Date: Fri, 4 Feb 2022 11:25:06 +0000
Message-ID: <111cab0d-b61b-6a93-ba49-f29e4fd16b60@epam.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-2-andr2000@gmail.com>
 <000ac24e-fdac-855d-7fb4-2165a1192ea4@xen.org>
 <19e50632-5865-9a75-756b-88db85007e96@epam.com>
 <d9741ff0-2152-6792-5249-09e3b0960972@xen.org>
 <43cab3d0-1a62-dca0-0d2d-5ea8fe237b21@epam.com>
 <ad90a3df-7049-8ff2-979a-dec3b8c542a1@xen.org>
 <86e51f3c-6ef8-a86d-acf3-38334db430a7@epam.com>
 <e5f0fd5d-b685-c559-6850-c2e06824b7d7@xen.org>
In-Reply-To: <e5f0fd5d-b685-c559-6850-c2e06824b7d7@xen.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 40a39077-18c9-4c84-b3e8-08d9e7d0fee2
x-ms-traffictypediagnostic: AM9PR03MB7265:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM9PR03MB72658E64CBEA1EFA508B3B47E7299@AM9PR03MB7265.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 LjQRL+qkQcwZoYoK8efZcBP9HggWmwxeouC+P26TEgVDzrSglLBIr29lZ4SAK2Tme8Se9Phd0pKKoYIsCcI+YckEiUm2WT4v4axln57gN8g2RfC1A44HbL24OezN4/zMKBzbaR8BG2qq9eHq+vN43xAbif1y+BiQYGvFZ3WCsqmFfwznmGm8aUcebLMuAKYW7q2XuTLjQ4ZdUMwQLW7lh5PN3kVklaq3aEBb1nZhu6n+DNzfpoGrAwVx12OAImGpsdyd9q4kCM0kB4OFptanE8a3H/kPyJkGi79a+JQEPijzQGptFDn6P/EeedmDwfYc5uUl2P43jF63VCZB8L8BWHJ+Q3QkKKr6JeqhVC+ajemnY9rnFblFqDZo0wMTg66bA8/gNZ/+OcIk+En43L7CvaaxPtNqErirt9bA/Ovlsz4dlUJMWmiNqJ68kC8N6BZvZ9HxqCo4IXDcPO96WFr0yqQ/+dkBBBYwd5+PfMc6XYOudSLn2A6NK+G42V16ugwFMMzufkwhCNU5jNsIcKcZAtbsJ8M/25A+Sk5+Z+dTVUIMN7LcbugRLL8JHPHBpWQ19BzlGgeUnH/YDXdo97/2a805GA/oHQ1NMz5x3JTbQKZLYwK/UMyMhYKOQVmhRJ55KmRvYQ1bGC1o8y8BDC8U25dwlRDhtTiOfl4esLTVc6w+UhcSaTtbP41DNeRSXAN5QW3s7M15+g6qJJspdAzhA0qjwEHHSr2ZdVYIy6SVSVS+PbIpABEu6M6uiV9uIpwT
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(83380400001)(5660300002)(7416002)(31696002)(2906002)(107886003)(71200400001)(36756003)(6486002)(508600001)(31686004)(316002)(38100700002)(122000001)(38070700005)(26005)(186003)(110136005)(86362001)(53546011)(6506007)(2616005)(54906003)(6512007)(76116006)(8936002)(4326008)(8676002)(64756008)(66446008)(66476007)(66556008)(91956017)(66946007)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?dmZPYWQvNkppV0JGa2JHSWg0VDQ0ZS9aVXZHSW4rNHlvd3UzZVhTS1F0elgy?=
 =?utf-8?B?RmVaQ1V0NzNKZkx0dVgxcVpqVmNnTWFObHhKZ3NaRFpoTVFSNDhvWk5yQ09S?=
 =?utf-8?B?QUFpQlBEczQvRHRrdUIyWTRaWEd0OWRWRW5SNTRMK1l6c0pSazlVWjFRM2RB?=
 =?utf-8?B?anpxUXNMRERTUjJGeDJOV0ZOaFFUakM4UXVrVTJTQ041S3JQUmlrU2NCSUFh?=
 =?utf-8?B?cHY5TER2VUpYRVVnNUtiTm9DTkNUZU5Qc1ZtMGtYSW9lVkFUT0VLbU1PTHRm?=
 =?utf-8?B?dlROMXk5MU5zdG43TkFNTXJqUVJpV2hRQW9hc2tORnBnbjNuQjFyZ0VuWC90?=
 =?utf-8?B?YU95M2RBbGVYM3l4Sm4zWHByczRNelp2OEtHNUhYQ2kyVXAzODhjSmxmVGdB?=
 =?utf-8?B?dVkzdGhOZHAwVlNtZEpKczZjRmlpVzJuVnpGWmNjb3IyMWNFWTN3aFEzdSs5?=
 =?utf-8?B?RlhmZTlOSVBCb09wVllnblJLT3l1cDRoTWJ6alRMUERKQ0lMTUZVWnluSGlY?=
 =?utf-8?B?cVYrYUpheHpoUUtpOUhIaFlISjR3ZGVlWHJXRm5BRHZjSkVWZFRQdlBKaWt1?=
 =?utf-8?B?U3NaM1FFRkFFTHZaVUsvU2RubGdFNXRXZlJPY0owZXpDVlZrNXFoNnp1cVlN?=
 =?utf-8?B?bTkzZ0JxalN1M25FTkpYalAxUFZkTGVYbGZDTm11Qm8wN0JjeWJ1WUZNRXc3?=
 =?utf-8?B?TVN6aVdpNWpGcG5sZExqRlNwZ3lENnVSaG50ak9TNTlrUzFSNXB6Y1dpRVVt?=
 =?utf-8?B?K2dhY1EyUDJwUUFjTTZNRW5mYjZ4cjdEZXlzU0d0SHQvWGFFcVhRWGN6K1dy?=
 =?utf-8?B?cFg3THcraGxDaEZ4ZFJmNFJwUStrZXdtVzBDcmZ2N0YzYnF2eGJnWU9JaWRJ?=
 =?utf-8?B?Z2ZkUWE3UnhXQVFRRHZNd2VSVEFibHlQYmdMZERuSGV3RVNOU2srRXVTOU93?=
 =?utf-8?B?QVBjemQraXhSZjlTNVRLdmNkdDVZUU5JbUk3aVVOT1UyUVBuNnd0SzdKd3p6?=
 =?utf-8?B?dlk5WGFRN0d4c3pib0ZjZmEyTStNT2tGd0lMY2FxZFdSUWZkQnNTZHZXQ0hL?=
 =?utf-8?B?b1FXQld3c09NdVVFdUVYaDJFRUVxeEhrM0w1aVY3cjJuMnN0bUdBSkhNSW14?=
 =?utf-8?B?UHcxT0xSbFQ3TmxhaVZnR1VPRWJTSFdLSi92L2g2Y0pUeU1hckk3MEVQVXlS?=
 =?utf-8?B?bHdVYzc2VlA0d1Q3cmtheEhqNnVLWWVGeEJZMUkvak93b2NTa2FqRW0vWkRq?=
 =?utf-8?B?ZXFscU85cTQzRC9wMCtURkxlb3lsb3lMZzFVYUxCSjluYWJLSkI0NjhhNklh?=
 =?utf-8?B?NjQwYXRJVTBQVzM1NnlpRS9SSjJkQy9LaGpuTWpQOVkzanZkaFVPaDZjN0Fv?=
 =?utf-8?B?SVZYemhaU1RlUTFlbVVmME51R1o0eDI3bE91OUdFM2RoK0FNbm1valN6dDJB?=
 =?utf-8?B?MXR5VDR3YW9PSnhuWHZ3U283V2N2Y1JTSmdsQ0R3RFJRdmpVc05PeHNSWmFK?=
 =?utf-8?B?Q1RiNDRCQnBhbmVFNTYwbUR5cFJhZ205Z2h5UjVBYmZoN3owbm10b1ZuSWhY?=
 =?utf-8?B?eVIzb2JNWTNkK2pKdUl0RS9sZThQTFRvSzdIZlFBYkg1bDhBQjE1TmhpQlhm?=
 =?utf-8?B?VVovMmVzSmpyemcvRjVNbzJvRTF3STFUR0J5bTFEYjcvWHlXWWc0dmdWKzlx?=
 =?utf-8?B?Wk1FTG9taG5kVTdXYWxEcVd2YXhrQTZVK0lqa3Q1UDdPL1YzSEwvVlBZZjhr?=
 =?utf-8?B?a2FDcVNGUHhJakFMMXowaTRPZXRMK1RjOWJiVDQxYVM3SFgvZTIxeTZYc0h0?=
 =?utf-8?B?TzE0MStFbnhiMXpGaWhGUngwdEhmQUVrTDQ1YzZ6OHhJUXBWcG1XcEo0bUpR?=
 =?utf-8?B?ek9iS1IrOXE4SU56M1hmd0NKUHlUU0VwNkV5dzExd3NsYWNRc3F1R3BNRURy?=
 =?utf-8?B?UUYrZzQ4LzR3OTZKaVhyY0Y3L1lNZXpIT284bldDem16NHdkVFpjZTY0WHpu?=
 =?utf-8?B?RnREU1NxYzJGVkFYcjlwK2FIOHl2MWNKMVFydUQ0VGlBMTNGRWlNc1BsUGNB?=
 =?utf-8?B?YXFhYlJsSGZoeFVSRlFHNlp3Y0Q5ejJoUjRsVU92Q3ZRamllREhxRmNEQUov?=
 =?utf-8?B?eWdyMzViZkc4emlCNTVxSXI3RFVSQ2hxN1lsR20rM2tCbGtrczhoclBVcHdz?=
 =?utf-8?B?TDlMb05ycm9xYWR2QXRHek9Zc3lpcHJXU2xjdkRYWnVhUUNMMTR4N05obThZ?=
 =?utf-8?B?cGlOb2xKb21iZzUxSjZDQUo4L2phMW5Hd3hHOGI4MUJGck1pTnNLd3FaSExI?=
 =?utf-8?B?NmczakN2bjhQUGxYbVhsYkVOeGJONU9YSVdIZTZwNkFvd29PbFY3Zz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <1C0DCDDD079B004C818428AFBF398156@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 40a39077-18c9-4c84-b3e8-08d9e7d0fee2
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Feb 2022 11:25:06.4182
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: iFUw7dWdat3c74ZdZAmAixk9ojks/jJNZGAG2UVviAEql2XIQG14tkJfIeHoiQ0JfMn4CipCSo51tWPhaJrUuVQHUaCgIxnf/5zHDU3TzYYKQb0R22mJZj9cPWsP7qI+
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR03MB7265
X-Proofpoint-ORIG-GUID: tEeiqVk91TArcxsPTkhJ4pPDZfEX7z5r
X-Proofpoint-GUID: tEeiqVk91TArcxsPTkhJ4pPDZfEX7z5r
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-04_04,2022-02-03_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0
 priorityscore=1501 mlxscore=0 adultscore=0 impostorscore=0 spamscore=0
 lowpriorityscore=0 bulkscore=0 suspectscore=0 mlxlogscore=999 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2202040062

DQoNCk9uIDA0LjAyLjIyIDEzOjAwLCBKdWxpZW4gR3JhbGwgd3JvdGU6DQo+DQo+DQo+IE9uIDA0
LzAyLzIwMjIgMTA6MzUsIE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4NCj4+DQo+
PiBPbiAwNC4wMi4yMiAxMTo1NywgSnVsaWVuIEdyYWxsIHdyb3RlOg0KPj4+IEhpLA0KPj4+DQo+
Pj4gT24gMDQvMDIvMjAyMiAwOTo0NywgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+
Pj4+Pj4gQ291bGQgeW91IHBsZWFzZSBoZWxwIG1lIHdpdGggdGhlIGV4YWN0IG1lc3NhZ2UgeW91
IHdvdWxkIGxpa2UgdG8gc2VlPw0KPj4+Pj4NCj4+Pj4+IEhlcmUgYSBzdW1tYXJ5IG9mIHRoZSBk
aXNjdXNzaW9uICgrIHNvbWUgbXkgZm9sbG93LXVwIHRob3VnaHRzKToNCj4+Pj4+DQo+Pj4+PiBp
c19tZW1vcnlfaG9sZSgpIHdhcyByZWNlbnRseSBpbnRyb2R1Y2VkIG9uIHg4NiAoc2VlIGNvbW1p
dCA3NWNjNDYwYTFiOGMgInhlbi9wY2k6IGRldGVjdCB3aGVuIEJBUnMgYXJlIG5vdCBzdWl0YWJs
eSBwb3NpdGlvbmVkIikgdG8gY2hlY2sgd2hldGhlciB0aGUgQkFSIGFyZSBwb3NpdGlvbmVkIG91
dHNpZGUgb2YgYSB2YWxpZCBtZW1vcnkgcmFuZ2UuIFRoaXMgd2FzIGludHJvZHVjZWQgdG8gd29y
ay1hcm91bmQgcXVpcmt5IGZpcm13YXJlLg0KPj4+Pj4NCj4+Pj4+IEluIHRoZW9yeSwgdGhpcyBj
b3VsZCBhbHNvIGhhcHBlbiBvbiBBcm0uIEluIHByYWN0aWNlLCB0aGlzIG1heSBub3QgaGFwcGVu
IGJ1dCBpdCBzb3VuZHMgYmV0dGVyIHRvIHNhbml0eSBjaGVjayB0aGF0IHRoZSBCQVIgY29udGFp
bnMgInZhbGlkIiBJL08gcmFuZ2UuDQo+Pj4+Pg0KPj4+Pj4gT24geDg2LCB0aGlzIGlzIGltcGxl
bWVudGVkIGJ5IGNoZWNraW5nIHRoZSByZWdpb24gaXMgbm90IGRlc2NyaWJlZCBpcyBpbiB0aGUg
ZTgyMC4gSUlVQywgb24gQXJtLCB0aGUgQkFScyBoYXZlIHRvIGJlIHBvc2l0aW9uZWQgaW4gcHJl
LWRlZmluZWQgcmFuZ2VzLiBTbyBJIHRoaW5rIGl0IHdvdWxkIGJlIHBvc3NpYmxlIHRvIGltcGxl
bWVudCBpc19tZW1vcnlfaG9sZSgpIGJ5IGdvaW5nIHRocm91Z2ggdGhlIGxpc3Qgb2YgaG9zdGJy
aWRnZXMgYW5kIGNoZWNrIHRoZSByYW5nZXMuDQo+Pj4+Pg0KPj4+Pj4gQnV0IGZpcnN0LCBJJ2Qg
bGlrZSB0byBjb25maXJtIG15IHVuZGVyc3RhbmRpbmcgd2l0aCBSYWh1bCwgYW5kIG90aGVycy4N
Cj4+Pj4+DQo+Pj4+PiBJZiB3ZSB3ZXJlIGdvaW5nIHRvIGdvIHRoaXMgcm91dGUsIEkgd291bGQg
YWxzbyByZW5hbWUgdGhlIGZ1bmN0aW9uIHRvIGJlIGJldHRlciBtYXRjaCB3aGF0IGl0IGlzIGRv
aW5nIChpLmUuIGl0IGNoZWNrcyB0aGUgQkFSIGlzIGNvcnJlY3RseSBwbGFjZWQpLiBBcyBhIHBv
dGVudGlhbGx5IG9wdGltaXphdGlvbi9oYXJkZW5pbmcgZm9yIEFybSwgd2UgY291bGQgcGFzcyB0
aGUgaG9zdGJyaWRnZSBzbyB3ZSBkb24ndCBoYXZlIHRvIHdhbGsgYWxsIG9mIHRoZW0uDQo+Pj4+
IEl0IHNlZW1zIHRoaXMgbmVlZHMgdG8gbGl2ZSBpbiB0aGUgY29tbWl0IG1lc3NhZ2UgdGhlbj8g
U28sIGl0IGlzIGVhc3kgdG8gZmluZA0KPj4+PiBhcyBldmVyeXRoaW5nIGFmdGVyICItLS0iIGlz
IGdvaW5nIHRvIGJlIGRyb3BwZWQgb24gY29tbWl0DQo+Pj4gSSBleHBlY3QgdGhlIGZ1bmN0aW9u
IHRvIGJlIGZ1bGx5IGltcGxlbWVudGVkIGJlZm9yZSB0aGlzIGlzIHdpbGwgYmUgbWVyZ2VkLg0K
Pj4+DQo+Pj4gU28gaWYgaXQgaXMgZnVsbHkgaW1wbGVtZW50ZWQsIHRoZW4gYSBmYWlyIGNodW5r
IG9mIHdoYXQgSSB3cm90ZSB3b3VsZCBub3QgYmUgbmVjZXNzYXJ5IHRvIGNhcnJ5IGluIHRoZSBj
b21taXQgbWVzc2FnZS4NCj4+IFdlbGwsIHdlIHN0YXJ0ZWQgZnJvbSB0aGF0IHdlIHdhbnQgKnNv
bWV0aGluZyogd2l0aCBUT0RPIGFuZCBub3cNCj4+IHlvdSByZXF1ZXN0IGl0IHRvIGJlIGZ1bGx5
IGltcGxlbWVudGVkIGJlZm9yZSBpdCBpcyBtZXJnZWQuDQo+DQo+IEkgZG9uJ3QgdGhpbmsgSSBl
dmVyIHN1Z2dlc3RlZCB0aGlzIHBhdGNoIHdvdWxkIGJlIG1lcmdlZCBhcy1pcy4gU29ycnkgaWYg
dGhpcyBtYXkgaGF2ZSBjcm9zc2VkIGxpa2UgdGhpcy4NCk5wDQo+DQo+IEluc3RlYWQsIG15IGlu
dGVudCBieSBhc2tpbmcgeW91IHRvIHNlbmQgYSBUT0RPIHBhdGNoIGlzIHRvIHN0YXJ0IGEgZGlz
Y3Vzc2lvbiBob3cgdGhpcyBmdW5jdGlvbiBjb3VsZCBiZSBpbXBsZW1lbnRlZCBmb3IgQXJtLg0K
Pg0KPiBZb3Ugc2VudCBhIFRPRE8gYnV0IHlvdSBkaWRuJ3QgcHJvdmlkZSBhbnkgc3VtbWFyeSBv
biB3aGF0IGlzIHRoZSBpc3N1ZSwgd2hhdCB3ZSB3YW50IHRvIGFjaGlldmUuLi4gSGVuY2UgbXkg
cmVxdWVzdCB0byBhZGQgYSBiaXQgbW9yZSBkZXRhaWxzIHNvIHRoZSBvdGhlciByZXZpZXdlcnMg
Y2FuIHByb3ZpZGUgdGhlaXIgb3BpbmlvbiBtb3JlIGVhc2lseS4NCk9rLCBzbyB3ZSBjYW4gZGlz
Y3VzcyBpdCBoZXJlLCBidXQgSSB3b24ndCBoYXZlIHRoaXMgcGF0Y2ggaW4gdjcNCj4NCj4gQ2hl
ZXJzLA0KPg0KVGhhbmsgeW91LA0KT2xla3NhbmRy


From xen-devel-bounces@lists.xenproject.org Fri Feb 04 11:37:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 11:37:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265418.458786 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFwtu-0005TA-Hz; Fri, 04 Feb 2022 11:37:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265418.458786; Fri, 04 Feb 2022 11:37:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFwtu-0005T3-EM; Fri, 04 Feb 2022 11:37:14 +0000
Received: by outflank-mailman (input) for mailman id 265418;
 Fri, 04 Feb 2022 11:37:13 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1gJ0=ST=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nFwts-0005Sx-Rq
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 11:37:12 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ca5e1d0d-85ae-11ec-8f75-fffcc8bd4f1a;
 Fri, 04 Feb 2022 12:37:11 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2053.outbound.protection.outlook.com [104.47.14.53]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-25-YSoHxWp9P7KZC_fa278jDQ-1; Fri, 04 Feb 2022 12:37:10 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM0PR04MB4515.eurprd04.prod.outlook.com (2603:10a6:208:73::25)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.14; Fri, 4 Feb
 2022 11:37:07 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.014; Fri, 4 Feb 2022
 11:37:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ca5e1d0d-85ae-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1643974631;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=XQwlyvf6XjFD3j6fojG1vICJyJSoRJD+Dfh7xgy54P4=;
	b=SoGeibtWj37i1K8nlGXgzdt9PJUuYzgyFdCaeTBwRopenuSQysGHbvz9taoNBxVZGDAoEc
	PTdV2y3t9GSvAR8g7lYPOGcnJlOQHD8VRz64YMesHrosN2n2/tlWYGyq58JRqnx3xZqGnj
	8Zn0xloff90e7OcFJExmqsFAvNvDPv4=
X-MC-Unique: YSoHxWp9P7KZC_fa278jDQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=oeXNQRFEy9lvWr46W/o7DVGwc8NisRpw666PyvfK+W+M5YYwCSUAVWYA0d6mTOtLkpK6BBYLy9nSBDVso0vKZM/2+HkVbObfPvprZm540Xkv7bHxr030P3uzaW6SStzZ2ky9z1RuK2IVX6bGNNQfCm55E1L0lhOapkjLo0LpnSGOk4RazXZDXeMwrOLJeqhrg7Rc0Q1Rj/jaN1pDqQl/y9+CGZ51BnVdU1/hMdFG4+n71FLCYWYORO838iNpIb+UmFTVNDGh43hsbmYlToMTrBf0FMj+L33fYx8vmXCKWnOlDDC2qdaebpbkqJ8SNvsuCvQv+CdxeBSljTk5Bk0MqQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=GF+ThDdIkkupSWOHcKjIDlSVm45Gaif1tf+fVYM+suU=;
 b=MVa6Cp7WB3vpBruLfPXHKQ5uIVgMXsP+TL2NyCAzAc3uVulrDMolPlcl/etr2yIKeKlBFiEux1TEJJMxbKpGLpDdFhHCiLl88rdDSdU/f7BVOc2N9LMH1vUSw6ibqfoJV/eL0XqXkX5PEYvB6vvjgiP8+20EHhHf4OizXOmpNxjWSjKWrnQl2lZQ2LQ1zrorfIfHoxVnnVYPNOstyLH71oC2LIPBDj7EPdbhfpBIovyuALQY2qux1HOhNj5W/o5XisM3ezCJySVOfkfV1VVq5VTaIw0ZHl0uBSXnK+oFj0rzLfWaR10oqnCXqCSLHlV0cNdadkN3QBcWPT1AZB4x0w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <1ed0e342-16cd-2f16-c05c-186667a22762@suse.com>
Date: Fri, 4 Feb 2022 12:37:05 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>,
 "julien@xen.org" <julien@xen.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Artem Mygaiev <Artem_Mygaiev@epam.com>,
 "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
 "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
 "paul@xen.org" <paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-4-andr2000@gmail.com>
 <7209889d-8f17-61cc-72a4-97f6dbc1d54d@suse.com>
 <2cf022f8-b000-11b7-c6b9-90a56bc6e2ea@epam.com>
 <04726915-f39f-9019-436e-4399533c9fc3@suse.com>
 <9ed3f4ac-0a2d-ed45-9872-7c3f356a469e@epam.com>
 <c3a99712-cf7c-37da-aac1-f2ee00e6d53b@suse.com>
 <Yf0KcVD8W05A4fbB@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Yf0KcVD8W05A4fbB@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR0301CA0040.eurprd03.prod.outlook.com
 (2603:10a6:20b:469::26) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 99547a1d-9f66-453b-97c8-08d9e7d2aca4
X-MS-TrafficTypeDiagnostic: AM0PR04MB4515:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB4515911191A1CB3D2C2C78B7B3299@AM0PR04MB4515.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6430;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	+hEOK6wpe4cv7IxoDTB2C314xTpbgAToNEJJRpGE0GQEKxRX3wcmRdZMICHhLiq0/5U/hEvBNVEz73UcheV2GaFLS/GIx9KGZciy2CmA1DRI7Fo8M7kPwuPeO8pQ6mDEH9ungYu6WGGNYaZQxTrIkln+BWXqdxxc4wGwoG4M6cjH6E4SnYczou/WChB9faHgqu8/FE78pTZKMNK/Hq9zvhUHuWtn2efqQ/05e5MAUNr/RrIrEyZAW00G5RkxamFjrb+xCdtpr5da9gEZRP0bAkTtDKP+pUFVRQ+JDn0gYvWDuHa3AmLyyzjkdz6k7PNnwrw3/ILYpRzJrcUF5uDMdc4GzIPm3O68w9jKrUffeyCZ/y2Z7if3pgBA68WEa9TwORsCfOmQGPa9SK4Ip6p0FSe0PgPNY8HAG8QIw4Gp7A0y2PgNA953xcBeejoVYY6E5M+ZFQeClosoa7s7hWIjdNkrnHpTlM0I++Hc3k/2LUqNQ3xxp9QsaAMY2Ixuv65ZoNUeyCYtHk85aUsQPU3Fwv+iANMBFNQO/9Pz5n3r4HvFctKC7ewA5Hzs4jkXC8eGrUnSbunQwkkf+sHXyUJsdWtQ0G8+BbZGSRzmeNA5b56MtsXMPqVztHxLmkMDpjJQBrqdNeRjCrcQMpZRwL6u89AE2LVWSli4NdbFTPG6PjjSFzEB3obOWxRlbw5H7ak6eNPghnZP8erwP9Ab5QCEeU9dM8X1A3jGkyee43FO0T0=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(86362001)(31686004)(31696002)(38100700002)(54906003)(6916009)(508600001)(316002)(6486002)(6512007)(8676002)(5660300002)(7416002)(66946007)(4326008)(66556008)(2906002)(83380400001)(8936002)(66476007)(53546011)(6506007)(2616005)(186003)(36756003)(26005)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?SqarcV65cGFUeNUqbwmwuXGxwZU8Cj6xxLd051zsE47ZMsUD34IWb3qHgjBn?=
 =?us-ascii?Q?cq/9AeogOHN2OnrYEECrT5CYKyJKDHts6a9l3ZEbB7O0/JKovN7vNSCrOSby?=
 =?us-ascii?Q?OFJmR/FdZId7vzGFoJJplToO9PFGS5xTUEFmDqBux52ILtMWwe1mjkYvd3sP?=
 =?us-ascii?Q?HQEmIEXM9A2ydPt5LJmn1kwsmoabEE3n5VZzPU5D1vkxk8cdyQsRlnRa9ZbT?=
 =?us-ascii?Q?Ilj7ZFk/4yiwhRROt7rKxap3Z9EaV1qMXjbwqiv9DXOPq07uHaPzHZdKlTj2?=
 =?us-ascii?Q?AO1/wR4aeEQNbc9DU+zhtuCZR8hhVeW6Gh+eq6EEebUGuT0mv1d+1OOgOODM?=
 =?us-ascii?Q?DCgqSN0DnJtWX5wnGVn3tqkfTOWz6RmvqJrZAjDfChX4Booiuv6aUPg7JLbm?=
 =?us-ascii?Q?XiW6S8u27OaoBlsMxhgoLYT7+oQZAVy+Vcb4vy0V7zvyST6a1WZWqRDFCsJq?=
 =?us-ascii?Q?NXajVHyhcT9OTolxPEisyB3ca70+85riOodgpsOGPmWTQY4/CR8/dqG/0Ubi?=
 =?us-ascii?Q?+gDcYhP/pWACKfEohghlwFv/XfeXg01GWcxtnXIb0582e+SlNGvFtDhZ28rQ?=
 =?us-ascii?Q?XVlAvB2QZ8ucbiXXp1PS0CXEkDwDefwewLPjHAtIUgtdFdFxnlXKdVTbuiFF?=
 =?us-ascii?Q?QCH/3VA9UEAl4Kjwb46+5c2puLFMDBAasS5VBAq4zYSMx0JUj/ajENyi3oNq?=
 =?us-ascii?Q?YmjMVs3cBN8D2QxB3jGiBGgymOQwsL2DUR9Y7h9ARZH4qgb8JTUxRCYuvA2b?=
 =?us-ascii?Q?aiPLq7t9h4b565k0z+5OsMV2PUrpz3dNK6bGBXOBYq5cmfuRP0teAPZgGtIS?=
 =?us-ascii?Q?ZEg1qJ8cXK8+kzVpWPo9wD0F4JzvS6M7H/XwhZbd3oB8W/N/MFQNgELf97Tl?=
 =?us-ascii?Q?3vPyHUtoRCyg3HQu7MNVECAnO735hjDRv8MtlZxWJEg+Nb+iKD1v6WAaktD4?=
 =?us-ascii?Q?kzFFEzhrJacVSPxr/9eW7Yxf3IoN0Sg1rTIVX2SFvIkl021JolRUHSAsGGuG?=
 =?us-ascii?Q?Vm2NTT0MxrP3bEErcstEcAeHlbpy7+nPWx7zk6XQcbdq9FEYde0QcnwjBF7s?=
 =?us-ascii?Q?LxOh7wajUfbJL33ErXMjovpXBQU4qyQ5uZXKLWxiH9b/mY/xyW5n6aQVpWPI?=
 =?us-ascii?Q?eT+ayLP3zIfvQrz9jVaZTt2e6EN/wxCta46qugY/9z7UjL0C7KoaNaaFmYUl?=
 =?us-ascii?Q?cILz+O2RK2BNDe35+k2J8yYcq7qKs2gih0VuWzs+s/DDpQxH1DmnroocNds0?=
 =?us-ascii?Q?gHYtiQCgj2Ad/lMDGwLWbKE7HMiWNLi5ncmoy3fBjDO8Apadpo0uE7zmmZII?=
 =?us-ascii?Q?+LNjAV5yWTQUDEuOyd+1wK3y0kjN7jGjioo/zqcZwhoTjgmxwm6GeEHShRcb?=
 =?us-ascii?Q?FJAFnFBML4pyTfTpuXSPEIKlt6DAFHiCEPY2L74ftjcPIXPlhgLgquXYaXp1?=
 =?us-ascii?Q?BnuwcChmmfnVD7vCqjed82PRikLaj4LeKQANe7LMCtiMBEDAfVUWBrAXu1zp?=
 =?us-ascii?Q?dh1gFG8cJ5FFq+P0inMdCvCO66ebaH296wxZEnAzgx85Mu54n6G5RU1HDKD7?=
 =?us-ascii?Q?yQY9RaUgNhRixF/LjG1u2xPD73SZn7nwgSgV2HH77ISYu9ge5zQkbJ3GwReC?=
 =?us-ascii?Q?bVSgAWaksj3cbv8XQl1pkQ0=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 99547a1d-9f66-453b-97c8-08d9e7d2aca4
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Feb 2022 11:37:07.6658
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: O4RWAXorDN2IHb00Kce+udeClTFBTU1lgT3E9sSqIwfd9NKE02UwZwv4LqF/bQ3OGt22JJqUyRMynMTni//xgA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4515

On 04.02.2022 12:13, Roger Pau Monn=C3=A9 wrote:
> On Fri, Feb 04, 2022 at 11:49:18AM +0100, Jan Beulich wrote:
>> On 04.02.2022 11:12, Oleksandr Andrushchenko wrote:
>>> On 04.02.22 11:15, Jan Beulich wrote:
>>>> On 04.02.2022 09:58, Oleksandr Andrushchenko wrote:
>>>>> On 04.02.22 09:52, Jan Beulich wrote:
>>>>>> On 04.02.2022 07:34, Oleksandr Andrushchenko wrote:
>>>>>>> @@ -285,6 +286,12 @@ static int modify_bars(const struct pci_dev *p=
dev, uint16_t cmd, bool rom_only)
>>>>>>>                    continue;
>>>>>>>            }
>>>>>>>   =20
>>>>>>> +        spin_lock(&tmp->vpci_lock);
>>>>>>> +        if ( !tmp->vpci )
>>>>>>> +        {
>>>>>>> +            spin_unlock(&tmp->vpci_lock);
>>>>>>> +            continue;
>>>>>>> +        }
>>>>>>>            for ( i =3D 0; i < ARRAY_SIZE(tmp->vpci->header.bars); i=
++ )
>>>>>>>            {
>>>>>>>                const struct vpci_bar *bar =3D &tmp->vpci->header.ba=
rs[i];
>>>>>>> @@ -303,12 +310,14 @@ static int modify_bars(const struct pci_dev *=
pdev, uint16_t cmd, bool rom_only)
>>>>>>>                rc =3D rangeset_remove_range(mem, start, end);
>>>>>>>                if ( rc )
>>>>>>>                {
>>>>>>> +                spin_unlock(&tmp->vpci_lock);
>>>>>>>                    printk(XENLOG_G_WARNING "Failed to remove [%lx, =
%lx]: %d\n",
>>>>>>>                           start, end, rc);
>>>>>>>                    rangeset_destroy(mem);
>>>>>>>                    return rc;
>>>>>>>                }
>>>>>>>            }
>>>>>>> +        spin_unlock(&tmp->vpci_lock);
>>>>>>>        }
>>>>>> At the first glance this simply looks like another unjustified (in t=
he
>>>>>> description) change, as you're not converting anything here but you
>>>>>> actually add locking (and I realize this was there before, so I'm so=
rry
>>>>>> for not pointing this out earlier).
>>>>> Well, I thought that the description already has "...the lock can be
>>>>> used (and in a few cases is used right away) to check whether vpci
>>>>> is present" and this is enough for such uses as here.
>>>>>>    But then I wonder whether you
>>>>>> actually tested this, since I can't help getting the impression that
>>>>>> you're introducing a live-lock: The function is called from cmd_writ=
e()
>>>>>> and rom_write(), which in turn are called out of vpci_write(). Yet t=
hat
>>>>>> function already holds the lock, and the lock is not (currently)
>>>>>> recursive. (For the 3rd caller of the function - init_bars() - otoh
>>>>>> the locking looks to be entirely unnecessary.)
>>>>> Well, you are correct: if tmp !=3D pdev then it is correct to acquire
>>>>> the lock. But if tmp =3D=3D pdev and rom_only =3D=3D true
>>>>> then we'll deadlock.
>>>>>
>>>>> It seems we need to have the locking conditional, e.g. only lock
>>>>> if tmp !=3D pdev
>>>> Which will address the live-lock, but introduce ABBA deadlock potentia=
l
>>>> between the two locks.
>>> I am not sure I can suggest a better solution here
>>> @Roger, @Jan, could you please help here?
>>
>> Well, first of all I'd like to mention that while it may have been okay =
to
>> not hold pcidevs_lock here for Dom0, it surely needs acquiring when deal=
ing
>> with DomU-s' lists of PCI devices. The requirement really applies to the
>> other use of for_each_pdev() as well (in vpci_dump_msi()), except that
>> there it probably wants to be a try-lock.
>>
>> Next I'd like to point out that here we have the still pending issue of
>> how to deal with hidden devices, which Dom0 can access. See my RFC patch
>> "vPCI: account for hidden devices in modify_bars()". Whatever the soluti=
on
>> here, I think it wants to at least account for the extra need there.
>=20
> Yes, sorry, I should take care of that.
>=20
>> Now it is quite clear that pcidevs_lock isn't going to help with avoidin=
g
>> the deadlock, as it's imo not an option at all to acquire that lock
>> everywhere else you access ->vpci (or else the vpci lock itself would be
>> pointless). But a per-domain auxiliary r/w lock may help: Other paths
>> would acquire it in read mode, and here you'd acquire it in write mode (=
in
>> the former case around the vpci lock, while in the latter case there may
>> then not be any need to acquire the individual vpci locks at all). FTAOD=
:
>> I haven't fully thought through all implications (and hence whether this=
 is
>> viable in the first place); I expect you will, documenting what you've
>> found in the resulting patch description. Of course the double lock
>> acquire/release would then likely want hiding in helper functions.
>=20
> I've been also thinking about this, and whether it's really worth to
> have a per-device lock rather than a per-domain one that protects all
> vpci regions of the devices assigned to the domain.
>=20
> The OS is likely to serialize accesses to the PCI config space anyway,
> and the only place I could see a benefit of having per-device locks is
> in the handling of MSI-X tables, as the handling of the mask bit is
> likely very performance sensitive, so adding a per-domain lock there
> could be a bottleneck.

Hmm, with method 1 accesses serializing globally is basically
unavoidable, but with MMCFG I see no reason why OSes may not (move
to) permit(ting) parallel accesses, with serialization perhaps done
only at device level. See our own pci_config_lock, which applies to
only method 1 accesses; we don't look to be serializing MMCFG
accesses at all.

> We could alternatively do a per-domain rwlock for vpci and special case
> the MSI-X area to also have a per-device specific lock. At which point
> it becomes fairly similar to what you propose.

Indeed.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Feb 04 11:38:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 11:38:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265422.458796 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFwuh-00062J-R7; Fri, 04 Feb 2022 11:38:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265422.458796; Fri, 04 Feb 2022 11:38:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFwuh-00062C-Nz; Fri, 04 Feb 2022 11:38:03 +0000
Received: by outflank-mailman (input) for mailman id 265422;
 Fri, 04 Feb 2022 11:38:02 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=u+82=ST=epam.com=prvs=4034f0a382=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nFwuf-0005zn-Oc
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 11:38:01 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e725ed57-85ae-11ec-8f75-fffcc8bd4f1a;
 Fri, 04 Feb 2022 12:38:00 +0100 (CET)
Received: from pps.filterd (m0174681.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 214BCcw4021912;
 Fri, 4 Feb 2022 11:37:55 GMT
Received: from eur01-ve1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2051.outbound.protection.outlook.com [104.47.1.51])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3e10hbrqny-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 04 Feb 2022 11:37:54 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM0PR03MB5921.eurprd03.prod.outlook.com (2603:10a6:208:159::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.14; Fri, 4 Feb
 2022 11:37:50 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6%3]) with mapi id 15.20.4951.014; Fri, 4 Feb 2022
 11:37:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e725ed57-85ae-11ec-8f75-fffcc8bd4f1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=aIqKw3ClazqebxYZLJ953QHL3pw/5BH7Nfhj623MyjS6IrebcGRkuJez6nLpfFidLoyQbBN94ygIiKud/NadxJ/5TSgsKIqRJo1ne1qIjS4I7yaXbRAtuYvbu2MXvIQq+dgWQ7Ml7wrGE6bgU0N8ad8AkI4MWgrfvcBeLAymrKABvCSV6tkahDvWyVXN6atG5ZGD7eTUcSQDfyYYFQE2hT38iaRqmsRMt0F5O9uYE7QC280+Nl/ctEq40E9TiFej8g7tgHGVkPpkbvA2DoniWcTeLqQBp1CjNTdF1rJeq0IT1dL2z3yHk0BXuRcV4aFnL4J7pVCoA6ngZF783TrhaA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Gx+6hvdvJTx7ZPDPFskEJfKj8Ep1A1VgE/SYYW6MNpk=;
 b=G3ffurE/yb+9sIzYDMakox0vTJVMKDBG4XR+3Nu5AK+3/8Ixoi5zcjUhFcVc36cFnln2ZiFftLYxqogY0FRzDg5owxsOlcFykqmGAZO9J4CJq7n1LC0ZL5XA8vN0xRx0Yc/HuqvZGBRXhZjvqh854I80WhDVPFmO5uNiAdJypaLTTfr6K3l4tk+I9q9A8F3U4LAdbhbBuWLpBgEcZrYDeekeAgiis3uMHziDF7rUutA1fbwescgakC7kYAngjEnzP94KYde48rV+bko3nm5DP2DmFjtEsFfcmRZyFjodjQUjzyiZiWyRnf2ZVphfHr+0rB4Bc3BJBpK5ZxncSPHkCQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Gx+6hvdvJTx7ZPDPFskEJfKj8Ep1A1VgE/SYYW6MNpk=;
 b=rNkdO431xXTpbhGECOHsYoYNqwdHSESKkvYQqyjS7UfLdD017BcsBtOcPt4U8zwNZJRfYpvbTaYAihUXT0HUUfuDp/xIsqr/5BBgazeovXjei4JPiQXineFlcAHBNYKaRmqq2EcYPD9m8kof90Cwl9R2Gu7JHfcFXOR00FGpuh0uq5ogDJAJQrCdD85Ol/rHU+klD7i1lv9NzYPcZk0+dKEuR1swPYdHaQfcaAzV+Qzl6xk1Ndmjl0ZJ0afCzUkyAxHL56qAVWSSKt+GeKzvhiyvU1yaBfQwyJ7eI8KSalqNPvomFMe9CKaaPfYkQVBIuYpmvLQkZNGaMaxauER58g==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>,
        Jan Beulich
	<jbeulich@suse.com>
CC: "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Thread-Topic: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Thread-Index: 
 AQHYGZFc/MnzQOjwVEeBBUHLSW0md6yDBUkAgAASSACAAATYAIAAD/WAgAAKNgCAAAbfgIAABrEA
Date: Fri, 4 Feb 2022 11:37:50 +0000
Message-ID: <55fc77e8-44c1-8769-f818-d68c05dec987@epam.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-4-andr2000@gmail.com>
 <7209889d-8f17-61cc-72a4-97f6dbc1d54d@suse.com>
 <2cf022f8-b000-11b7-c6b9-90a56bc6e2ea@epam.com>
 <04726915-f39f-9019-436e-4399533c9fc3@suse.com>
 <9ed3f4ac-0a2d-ed45-9872-7c3f356a469e@epam.com>
 <c3a99712-cf7c-37da-aac1-f2ee00e6d53b@suse.com>
 <Yf0KcVD8W05A4fbB@Air-de-Roger>
In-Reply-To: <Yf0KcVD8W05A4fbB@Air-de-Roger>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 061f6671-b972-4d60-77bd-08d9e7d2c671
x-ms-traffictypediagnostic: AM0PR03MB5921:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM0PR03MB5921942B3CF0044FE47DD454E7299@AM0PR03MB5921.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8882;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 l47urjQ2EmOG2jvqeLDn/lHP1K7rqLCUmreE6zcwOlYZ6MsHDVVCzCQFcu7pCYrKWvnFIIt9btrNUcJiiHZshAmGH+Dg8pg5kFJnl0omB7XYctFKL4vI5+OwAMog2OZuGpfZPJGP2VS9FUi5/rnqg+k0miti9IyAVmMepDQbo1b/+qKRitg4wtRjr5YBWpLZdNswWN4m6FjLqN29gNFM9+OjH6BH/ZPNP/tmeivg3ab7SoF42zOqy73+hrcqS1DyTMXYGhtWByGiAylHWy6yLbWQJtOD1/E7VtKZT8FNXdy4ObeE3lNL/JPeaWO7bNwj18JYeAbmjHcmFFFFB25gaWl5ZhrjdMQGUteFAvqN2CayHpBqKpG+VsyxqEvR/exno01V6dR4jA6xThcwKir/6A8p0OclnIY2VmIkP+mfAstxWkCmK8q9G77Vel9E5tUPqNw7JEyIrC2PwtDDOKDmZYY9JCXsq7jo17fvs8g3pEc/mvefl1FerAZt1QhCmkEHLOLq++BC28+hzOcFbHDZcNLc6F1yD+7uOl+6+cbp53cV030obOiNy87Za65JukNnCUjOXXz2Tedr2z6dSptWYXj6/F/+eOYT125y+ZMaZ3J0BULHRKE2O7LDUivhaustAyl0HKPHG1QiJ/3GkXEHp4dL4fMIjpopYknZHHa5pUl0f7xlzM4ks4AhzHUZPmrj9Hg0P0yGH0AXhQyI0CCXi6GbL2kLvbaX/oj71eiFHwbsrsEXoK7fPZ418Ni4QMIb
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(86362001)(38070700005)(36756003)(31696002)(110136005)(122000001)(38100700002)(54906003)(316002)(508600001)(6486002)(7416002)(5660300002)(66946007)(91956017)(6512007)(4326008)(2906002)(83380400001)(64756008)(66446008)(66476007)(66556008)(8936002)(76116006)(8676002)(53546011)(71200400001)(6506007)(2616005)(26005)(186003)(31686004)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?Qi9XWE55NUJCWURJZUZaNDJYbldVY0lsOGR3WXJUcld2WWhqbW1sNWNGNzhM?=
 =?utf-8?B?WFJ2bHhOQ2JaK280UHRoWXRGYjBCRTVLOEpnVXNoMnl5RjRBcmEvbzFnK3Vv?=
 =?utf-8?B?Ny91U1dCK09jMU1YNFhzTFVqZUd5WVY1NkRGZ1BXRDEvaWFaNmJETXBWdFJw?=
 =?utf-8?B?a0UxajRjYkVWMDFjL2M4dzY5RERLOElOYlRQdTdqSlcwWjUraWtnczhzTzFG?=
 =?utf-8?B?VXljcmJFM0pIdENYYjNvb0ltS2FGcVZ4US9qOWFpdWxFSjRielhVRDhNYkZw?=
 =?utf-8?B?dXFYS0ViVGJMWWE2c3lBM1o1QUJ5WW1Mcnc4ZExMWFBFQ0pQMU5sRUg5Ry9F?=
 =?utf-8?B?eEx5dW1PYUgrY3ZRN3dKUXlkZ2tIdHFoNis5MzMrbDZsNitRcjZTTW81cnNJ?=
 =?utf-8?B?eDZVemRtZW1TVXZUOXFqUnFYTCtJTHloa0dPOTE4b1B1Zk9neXhuMnI2T3RL?=
 =?utf-8?B?c0I1aHRLKzlHOHJiWUhUS0x0elRKekZZUVE5SkxHS015QlJKV3FRTENWeWlu?=
 =?utf-8?B?NUlDYlRoRXZxVmJvYlFNcGxnaERVSjZkYXJWQVV0eVcvTjVDNFZ0ZEtXeWR1?=
 =?utf-8?B?dEdhOTN2dUt6RUkrTG1QdjEzUWFkQThBNndQb0UvdlZVT1AyUzRmNVlFc0xz?=
 =?utf-8?B?STR3bWdIcVFpaGNZVHZBM1lDcm8zZk5Ic2VNWklkMEZuSWRid0V1MTFTRGpT?=
 =?utf-8?B?ZTIrb0M1d3Z4d3RzQ00rRWFUN0MzN1ZNUms5d1ZOQ2djb0lLN0dNYVZyNG54?=
 =?utf-8?B?WFdONnlLT2JZUDIwbkJGdDcvYXZ4Y3lrMDFvckdwcmZScHl0VFNMemdhVkV5?=
 =?utf-8?B?ZTZicnBtcGdmdG1iZGp5blBFRENCa1FmbEhjMFByRFl1ekVkSFRlRmpWYTFJ?=
 =?utf-8?B?V21tT2RKUjJ2VHUvaEE3WEtlRC9EYTNXQ2Z4OGZpV2dEZUR2M2JsakszWWZq?=
 =?utf-8?B?MCtWQUZuUEZCQXgvNndyN2psK3ROMFBPL2FHaU82M1Ira3ltWkhqZEN6VUc5?=
 =?utf-8?B?MXRhdWVaRHFITm5vWGdNeUF1TFJyM0NyUmVnT0MwcVZoMkRoVjg2Skl0WmIz?=
 =?utf-8?B?dlZ5T3dDSVRQT3ZHNHMzd2w2RzBVWlpUbnIzekdhTkVZNkI5MVNMZ3Z3cE52?=
 =?utf-8?B?ZXg1SFZvakVjSWdXVm5HTWZIbWNDTkw2WUF4bkMyb1puWkR3dVpoTHdPMjFL?=
 =?utf-8?B?aGJWV3BqSHZuS3VvZjBLVklEU0VrWUtiWVZncGRZbEFIVW1SQnZoQWgzTjRn?=
 =?utf-8?B?NkM2RmFlMFNCSnI4Vm5Hbk1FaXZSTzR0aXBGZHVEbW1kTHNIajE1TWRhaDNF?=
 =?utf-8?B?TFNtblpNdlBab2dKdXFVa2xNQTVrUHlwS1RyWDFBMXp0N0ZIbHEyeGVrKzlY?=
 =?utf-8?B?UHJSYU1LUWZ0TVo3Mi9NQVZjZlluOE90ZUoySmkwMUVjVjRXaFAxNnBLS2U5?=
 =?utf-8?B?OFlOblNRN0p6MncwTG5ocnBRTGZMTEFkR0pvMTJ5ekpaWW1UamU2MzRwOTVk?=
 =?utf-8?B?OXNES2pWZE5EY3VXYk9aQjcwaXZjTXNPSkMvNnVGcmJ3ZjhVRTdvWFhHVjcr?=
 =?utf-8?B?RSs1RlpETkdScXArYTYxTWNzQ3VuTmFuRzUxTFN5alNLa2JhaUMwMCt0bTRu?=
 =?utf-8?B?cXJJSHRpQW1QN1NDTG9aVElhVEwrcVJCbEdSUjlDcldUc0grTzIwZkd1a3E2?=
 =?utf-8?B?L0V1cTVhQW9UQTJiWTl4bWhINjhLdy9xOGo5TmxYdzM5VXVlMUlrTU5CckFP?=
 =?utf-8?B?SFFxb1dKdmZNclM2WE5kU3B3VzJqZ3RPUXBBcE8reTY3TXZMRkRndzJCcm00?=
 =?utf-8?B?S3l3bjFvak9GRFlEQWNMeHhmamRWTjlxYmVhOFptcjNHOGpuWlZLekJ0QWZ4?=
 =?utf-8?B?dHFDRDh3aGllQlR0cFNqbldvUytkS0dLSW1XYWZNTXNmNXFwNGxyOWJsV3ds?=
 =?utf-8?B?Y3BXbjd2aE1IcmtsSzRyTzRxVkZ4d21UTUVtV3RZZ25xUkZKdEE0Q2R6NGt4?=
 =?utf-8?B?SFBnYzNpaHF4VG9Pa2Z1ekk2TjFHa1FEVEI2NCtxLzZkNmlhU0lFKzZQaWRQ?=
 =?utf-8?B?WWliOGdNM3dKSW9HSU1jQjU3K1pwRXJEcDNGa1BqQ1NmNlN1eTRsd1RGTUI1?=
 =?utf-8?B?YzlMOWd6Mkt2MVUrT2NnMmlFVnZBM2JMV1FrM2NXOVlYOGgwWGc2SDRCTThw?=
 =?utf-8?B?bnhIendLUy9kdkE5ZVNxcVVadXBSZ0RaOVlHMHNXSFhrQkR1K1dzSEFJVjA0?=
 =?utf-8?B?ZndwWXNxaW0wQytIZEVzVm9UQ0Jsb1Q2NWZjNmF5YXFGcVpxemxsa0lRRDNT?=
 =?utf-8?B?cTNramxmYUhuV0pnZ2hCSWc4UXZveEdMNk5qZE14dGtNYVk4ZFRTUT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <C6ED8DD0E8878146BC9019BA4AC0E890@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 061f6671-b972-4d60-77bd-08d9e7d2c671
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Feb 2022 11:37:50.7171
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: IJpS42gahmqwoaTD0TbpwEbM0Ff8Sb6fcTKAoL5QjhCuESWy/tuTldBm2wjNs/wlaH97h08CzQMxn2BWC/uFB9sJT72sBB3Eavd2wkZInHDmWnkPI8arXkpJixyhEFv2
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB5921
X-Proofpoint-GUID: 4dtHJKJbAExkwvT47m5MBWQuqzwPmTyE
X-Proofpoint-ORIG-GUID: 4dtHJKJbAExkwvT47m5MBWQuqzwPmTyE
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-04_04,2022-02-03_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501
 lowpriorityscore=0 impostorscore=0 mlxscore=0 spamscore=0 adultscore=0
 bulkscore=0 phishscore=0 clxscore=1015 mlxlogscore=999 suspectscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202040064

DQoNCk9uIDA0LjAyLjIyIDEzOjEzLCBSb2dlciBQYXUgTW9ubsOpIHdyb3RlOg0KPiBPbiBGcmks
IEZlYiAwNCwgMjAyMiBhdCAxMTo0OToxOEFNICswMTAwLCBKYW4gQmV1bGljaCB3cm90ZToNCj4+
IE9uIDA0LjAyLjIwMjIgMTE6MTIsIE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4+
IE9uIDA0LjAyLjIyIDExOjE1LCBKYW4gQmV1bGljaCB3cm90ZToNCj4+Pj4gT24gMDQuMDIuMjAy
MiAwOTo1OCwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+Pj4+PiBPbiAwNC4wMi4y
MiAwOTo1MiwgSmFuIEJldWxpY2ggd3JvdGU6DQo+Pj4+Pj4gT24gMDQuMDIuMjAyMiAwNzozNCwg
T2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+Pj4+Pj4+IEBAIC0yODUsNiArMjg2LDEy
IEBAIHN0YXRpYyBpbnQgbW9kaWZ5X2JhcnMoY29uc3Qgc3RydWN0IHBjaV9kZXYgKnBkZXYsIHVp
bnQxNl90IGNtZCwgYm9vbCByb21fb25seSkNCj4+Pj4+Pj4gICAgICAgICAgICAgICAgICAgICBj
b250aW51ZTsNCj4+Pj4+Pj4gICAgICAgICAgICAgfQ0KPj4+Pj4+PiAgICAgDQo+Pj4+Pj4+ICsg
ICAgICAgIHNwaW5fbG9jaygmdG1wLT52cGNpX2xvY2spOw0KPj4+Pj4+PiArICAgICAgICBpZiAo
ICF0bXAtPnZwY2kgKQ0KPj4+Pj4+PiArICAgICAgICB7DQo+Pj4+Pj4+ICsgICAgICAgICAgICBz
cGluX3VubG9jaygmdG1wLT52cGNpX2xvY2spOw0KPj4+Pj4+PiArICAgICAgICAgICAgY29udGlu
dWU7DQo+Pj4+Pj4+ICsgICAgICAgIH0NCj4+Pj4+Pj4gICAgICAgICAgICAgZm9yICggaSA9IDA7
IGkgPCBBUlJBWV9TSVpFKHRtcC0+dnBjaS0+aGVhZGVyLmJhcnMpOyBpKysgKQ0KPj4+Pj4+PiAg
ICAgICAgICAgICB7DQo+Pj4+Pj4+ICAgICAgICAgICAgICAgICBjb25zdCBzdHJ1Y3QgdnBjaV9i
YXIgKmJhciA9ICZ0bXAtPnZwY2ktPmhlYWRlci5iYXJzW2ldOw0KPj4+Pj4+PiBAQCAtMzAzLDEy
ICszMTAsMTQgQEAgc3RhdGljIGludCBtb2RpZnlfYmFycyhjb25zdCBzdHJ1Y3QgcGNpX2RldiAq
cGRldiwgdWludDE2X3QgY21kLCBib29sIHJvbV9vbmx5KQ0KPj4+Pj4+PiAgICAgICAgICAgICAg
ICAgcmMgPSByYW5nZXNldF9yZW1vdmVfcmFuZ2UobWVtLCBzdGFydCwgZW5kKTsNCj4+Pj4+Pj4g
ICAgICAgICAgICAgICAgIGlmICggcmMgKQ0KPj4+Pj4+PiAgICAgICAgICAgICAgICAgew0KPj4+
Pj4+PiArICAgICAgICAgICAgICAgIHNwaW5fdW5sb2NrKCZ0bXAtPnZwY2lfbG9jayk7DQo+Pj4+
Pj4+ICAgICAgICAgICAgICAgICAgICAgcHJpbnRrKFhFTkxPR19HX1dBUk5JTkcgIkZhaWxlZCB0
byByZW1vdmUgWyVseCwgJWx4XTogJWRcbiIsDQo+Pj4+Pj4+ICAgICAgICAgICAgICAgICAgICAg
ICAgICAgIHN0YXJ0LCBlbmQsIHJjKTsNCj4+Pj4+Pj4gICAgICAgICAgICAgICAgICAgICByYW5n
ZXNldF9kZXN0cm95KG1lbSk7DQo+Pj4+Pj4+ICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIHJj
Ow0KPj4+Pj4+PiAgICAgICAgICAgICAgICAgfQ0KPj4+Pj4+PiAgICAgICAgICAgICB9DQo+Pj4+
Pj4+ICsgICAgICAgIHNwaW5fdW5sb2NrKCZ0bXAtPnZwY2lfbG9jayk7DQo+Pj4+Pj4+ICAgICAg
ICAgfQ0KPj4+Pj4+IEF0IHRoZSBmaXJzdCBnbGFuY2UgdGhpcyBzaW1wbHkgbG9va3MgbGlrZSBh
bm90aGVyIHVuanVzdGlmaWVkIChpbiB0aGUNCj4+Pj4+PiBkZXNjcmlwdGlvbikgY2hhbmdlLCBh
cyB5b3UncmUgbm90IGNvbnZlcnRpbmcgYW55dGhpbmcgaGVyZSBidXQgeW91DQo+Pj4+Pj4gYWN0
dWFsbHkgYWRkIGxvY2tpbmcgKGFuZCBJIHJlYWxpemUgdGhpcyB3YXMgdGhlcmUgYmVmb3JlLCBz
byBJJ20gc29ycnkNCj4+Pj4+PiBmb3Igbm90IHBvaW50aW5nIHRoaXMgb3V0IGVhcmxpZXIpLg0K
Pj4+Pj4gV2VsbCwgSSB0aG91Z2h0IHRoYXQgdGhlIGRlc2NyaXB0aW9uIGFscmVhZHkgaGFzICIu
Li50aGUgbG9jayBjYW4gYmUNCj4+Pj4+IHVzZWQgKGFuZCBpbiBhIGZldyBjYXNlcyBpcyB1c2Vk
IHJpZ2h0IGF3YXkpIHRvIGNoZWNrIHdoZXRoZXIgdnBjaQ0KPj4+Pj4gaXMgcHJlc2VudCIgYW5k
IHRoaXMgaXMgZW5vdWdoIGZvciBzdWNoIHVzZXMgYXMgaGVyZS4NCj4+Pj4+PiAgICAgQnV0IHRo
ZW4gSSB3b25kZXIgd2hldGhlciB5b3UNCj4+Pj4+PiBhY3R1YWxseSB0ZXN0ZWQgdGhpcywgc2lu
Y2UgSSBjYW4ndCBoZWxwIGdldHRpbmcgdGhlIGltcHJlc3Npb24gdGhhdA0KPj4+Pj4+IHlvdSdy
ZSBpbnRyb2R1Y2luZyBhIGxpdmUtbG9jazogVGhlIGZ1bmN0aW9uIGlzIGNhbGxlZCBmcm9tIGNt
ZF93cml0ZSgpDQo+Pj4+Pj4gYW5kIHJvbV93cml0ZSgpLCB3aGljaCBpbiB0dXJuIGFyZSBjYWxs
ZWQgb3V0IG9mIHZwY2lfd3JpdGUoKS4gWWV0IHRoYXQNCj4+Pj4+PiBmdW5jdGlvbiBhbHJlYWR5
IGhvbGRzIHRoZSBsb2NrLCBhbmQgdGhlIGxvY2sgaXMgbm90IChjdXJyZW50bHkpDQo+Pj4+Pj4g
cmVjdXJzaXZlLiAoRm9yIHRoZSAzcmQgY2FsbGVyIG9mIHRoZSBmdW5jdGlvbiAtIGluaXRfYmFy
cygpIC0gb3RvaA0KPj4+Pj4+IHRoZSBsb2NraW5nIGxvb2tzIHRvIGJlIGVudGlyZWx5IHVubmVj
ZXNzYXJ5LikNCj4+Pj4+IFdlbGwsIHlvdSBhcmUgY29ycmVjdDogaWYgdG1wICE9IHBkZXYgdGhl
biBpdCBpcyBjb3JyZWN0IHRvIGFjcXVpcmUNCj4+Pj4+IHRoZSBsb2NrLiBCdXQgaWYgdG1wID09
IHBkZXYgYW5kIHJvbV9vbmx5ID09IHRydWUNCj4+Pj4+IHRoZW4gd2UnbGwgZGVhZGxvY2suDQo+
Pj4+Pg0KPj4+Pj4gSXQgc2VlbXMgd2UgbmVlZCB0byBoYXZlIHRoZSBsb2NraW5nIGNvbmRpdGlv
bmFsLCBlLmcuIG9ubHkgbG9jaw0KPj4+Pj4gaWYgdG1wICE9IHBkZXYNCj4+Pj4gV2hpY2ggd2ls
bCBhZGRyZXNzIHRoZSBsaXZlLWxvY2ssIGJ1dCBpbnRyb2R1Y2UgQUJCQSBkZWFkbG9jayBwb3Rl
bnRpYWwNCj4+Pj4gYmV0d2VlbiB0aGUgdHdvIGxvY2tzLg0KPj4+IEkgYW0gbm90IHN1cmUgSSBj
YW4gc3VnZ2VzdCBhIGJldHRlciBzb2x1dGlvbiBoZXJlDQo+Pj4gQFJvZ2VyLCBASmFuLCBjb3Vs
ZCB5b3UgcGxlYXNlIGhlbHAgaGVyZT8NCj4+IFdlbGwsIGZpcnN0IG9mIGFsbCBJJ2QgbGlrZSB0
byBtZW50aW9uIHRoYXQgd2hpbGUgaXQgbWF5IGhhdmUgYmVlbiBva2F5IHRvDQo+PiBub3QgaG9s
ZCBwY2lkZXZzX2xvY2sgaGVyZSBmb3IgRG9tMCwgaXQgc3VyZWx5IG5lZWRzIGFjcXVpcmluZyB3
aGVuIGRlYWxpbmcNCj4+IHdpdGggRG9tVS1zJyBsaXN0cyBvZiBQQ0kgZGV2aWNlcy4gVGhlIHJl
cXVpcmVtZW50IHJlYWxseSBhcHBsaWVzIHRvIHRoZQ0KPj4gb3RoZXIgdXNlIG9mIGZvcl9lYWNo
X3BkZXYoKSBhcyB3ZWxsIChpbiB2cGNpX2R1bXBfbXNpKCkpLCBleGNlcHQgdGhhdA0KPj4gdGhl
cmUgaXQgcHJvYmFibHkgd2FudHMgdG8gYmUgYSB0cnktbG9jay4NCj4+DQo+PiBOZXh0IEknZCBs
aWtlIHRvIHBvaW50IG91dCB0aGF0IGhlcmUgd2UgaGF2ZSB0aGUgc3RpbGwgcGVuZGluZyBpc3N1
ZSBvZg0KPj4gaG93IHRvIGRlYWwgd2l0aCBoaWRkZW4gZGV2aWNlcywgd2hpY2ggRG9tMCBjYW4g
YWNjZXNzLiBTZWUgbXkgUkZDIHBhdGNoDQo+PiAidlBDSTogYWNjb3VudCBmb3IgaGlkZGVuIGRl
dmljZXMgaW4gbW9kaWZ5X2JhcnMoKSIuIFdoYXRldmVyIHRoZSBzb2x1dGlvbg0KPj4gaGVyZSwg
SSB0aGluayBpdCB3YW50cyB0byBhdCBsZWFzdCBhY2NvdW50IGZvciB0aGUgZXh0cmEgbmVlZCB0
aGVyZS4NCj4gWWVzLCBzb3JyeSwgSSBzaG91bGQgdGFrZSBjYXJlIG9mIHRoYXQuDQo+DQo+PiBO
b3cgaXQgaXMgcXVpdGUgY2xlYXIgdGhhdCBwY2lkZXZzX2xvY2sgaXNuJ3QgZ29pbmcgdG8gaGVs
cCB3aXRoIGF2b2lkaW5nDQo+PiB0aGUgZGVhZGxvY2ssIGFzIGl0J3MgaW1vIG5vdCBhbiBvcHRp
b24gYXQgYWxsIHRvIGFjcXVpcmUgdGhhdCBsb2NrDQo+PiBldmVyeXdoZXJlIGVsc2UgeW91IGFj
Y2VzcyAtPnZwY2kgKG9yIGVsc2UgdGhlIHZwY2kgbG9jayBpdHNlbGYgd291bGQgYmUNCj4+IHBv
aW50bGVzcykuIEJ1dCBhIHBlci1kb21haW4gYXV4aWxpYXJ5IHIvdyBsb2NrIG1heSBoZWxwOiBP
dGhlciBwYXRocw0KPj4gd291bGQgYWNxdWlyZSBpdCBpbiByZWFkIG1vZGUsIGFuZCBoZXJlIHlv
dSdkIGFjcXVpcmUgaXQgaW4gd3JpdGUgbW9kZSAoaW4NCj4+IHRoZSBmb3JtZXIgY2FzZSBhcm91
bmQgdGhlIHZwY2kgbG9jaywgd2hpbGUgaW4gdGhlIGxhdHRlciBjYXNlIHRoZXJlIG1heQ0KPj4g
dGhlbiBub3QgYmUgYW55IG5lZWQgdG8gYWNxdWlyZSB0aGUgaW5kaXZpZHVhbCB2cGNpIGxvY2tz
IGF0IGFsbCkuIEZUQU9EOg0KPj4gSSBoYXZlbid0IGZ1bGx5IHRob3VnaHQgdGhyb3VnaCBhbGwg
aW1wbGljYXRpb25zIChhbmQgaGVuY2Ugd2hldGhlciB0aGlzIGlzDQo+PiB2aWFibGUgaW4gdGhl
IGZpcnN0IHBsYWNlKTsgSSBleHBlY3QgeW91IHdpbGwsIGRvY3VtZW50aW5nIHdoYXQgeW91J3Zl
DQo+PiBmb3VuZCBpbiB0aGUgcmVzdWx0aW5nIHBhdGNoIGRlc2NyaXB0aW9uLiBPZiBjb3Vyc2Ug
dGhlIGRvdWJsZSBsb2NrDQo+PiBhY3F1aXJlL3JlbGVhc2Ugd291bGQgdGhlbiBsaWtlbHkgd2Fu
dCBoaWRpbmcgaW4gaGVscGVyIGZ1bmN0aW9ucy4NCj4gSSd2ZSBiZWVuIGFsc28gdGhpbmtpbmcg
YWJvdXQgdGhpcywgYW5kIHdoZXRoZXIgaXQncyByZWFsbHkgd29ydGggdG8NCj4gaGF2ZSBhIHBl
ci1kZXZpY2UgbG9jayByYXRoZXIgdGhhbiBhIHBlci1kb21haW4gb25lIHRoYXQgcHJvdGVjdHMg
YWxsDQo+IHZwY2kgcmVnaW9ucyBvZiB0aGUgZGV2aWNlcyBhc3NpZ25lZCB0byB0aGUgZG9tYWlu
Lg0KPg0KPiBUaGUgT1MgaXMgbGlrZWx5IHRvIHNlcmlhbGl6ZSBhY2Nlc3NlcyB0byB0aGUgUENJ
IGNvbmZpZyBzcGFjZSBhbnl3YXksDQo+IGFuZCB0aGUgb25seSBwbGFjZSBJIGNvdWxkIHNlZSBh
IGJlbmVmaXQgb2YgaGF2aW5nIHBlci1kZXZpY2UgbG9ja3MgaXMNCj4gaW4gdGhlIGhhbmRsaW5n
IG9mIE1TSS1YIHRhYmxlcywgYXMgdGhlIGhhbmRsaW5nIG9mIHRoZSBtYXNrIGJpdCBpcw0KPiBs
aWtlbHkgdmVyeSBwZXJmb3JtYW5jZSBzZW5zaXRpdmUsIHNvIGFkZGluZyBhIHBlci1kb21haW4g
bG9jayB0aGVyZQ0KPiBjb3VsZCBiZSBhIGJvdHRsZW5lY2suDQo+DQo+IFdlIGNvdWxkIGFsdGVy
bmF0aXZlbHkgZG8gYSBwZXItZG9tYWluIHJ3bG9jayBmb3IgdnBjaSBhbmQgc3BlY2lhbCBjYXNl
DQo+IHRoZSBNU0ktWCBhcmVhIHRvIGFsc28gaGF2ZSBhIHBlci1kZXZpY2Ugc3BlY2lmaWMgbG9j
ay4gQXQgd2hpY2ggcG9pbnQNCj4gaXQgYmVjb21lcyBmYWlybHkgc2ltaWxhciB0byB3aGF0IHlv
dSBwcm9wb3NlLg0KSSBuZWVkIGEgZGVjaXNpb24uDQpQbGVhc2UuDQo+DQo+IFRoYW5rcywgUm9n
ZXIuDQpUaGFuayB5b3UsDQpPbGVrc2FuZHI=


From xen-devel-bounces@lists.xenproject.org Fri Feb 04 11:56:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 11:56:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265436.458808 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFxCJ-0008Uk-I0; Fri, 04 Feb 2022 11:56:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265436.458808; Fri, 04 Feb 2022 11:56:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFxCJ-0008Ud-Ez; Fri, 04 Feb 2022 11:56:15 +0000
Received: by outflank-mailman (input) for mailman id 265436;
 Fri, 04 Feb 2022 11:56:13 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=98b4=ST=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1nFxCH-0008UX-IO
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 11:56:13 +0000
Received: from ppsw-32.csi.cam.ac.uk (ppsw-32.csi.cam.ac.uk [131.111.8.132])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7157f406-85b1-11ec-8eb8-a37418f5ba1a;
 Fri, 04 Feb 2022 12:56:10 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:53438)
 by ppsw-32.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.136]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1nFxC7-0002Pt-0o (Exim 4.95) (return-path <amc96@srcf.net>);
 Fri, 04 Feb 2022 11:56:03 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id E88471FB21;
 Fri,  4 Feb 2022 11:56:02 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7157f406-85b1-11ec-8eb8-a37418f5ba1a
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <5d721986-3298-51b1-22f9-58ecf8cb32c2@srcf.net>
Date: Fri, 4 Feb 2022 11:56:02 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.1
Content-Language: en-GB
To: Jan Beulich <jbeulich@suse.com>, Andrew Cooper <Andrew.Cooper3@citrix.com>
Cc: Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Xen-devel <xen-devel@lists.xenproject.org>, Julien Grall <julien@xen.org>
References: <20220203133829.7913-1-andrew.cooper3@citrix.com>
 <c0d82900-64d1-fe16-9283-deb7c324ff8a@xen.org>
 <ad7467d2-1cae-c8ea-1217-69f0924044d4@citrix.com>
 <348f062c-9aed-0275-f0ad-87a0eff8e986@suse.com>
 <8a28b63b-a5f6-db0f-3108-646475912abd@citrix.com>
 <c20b2017-7313-41bd-c854-48029a5df206@suse.com>
From: Andrew Cooper <amc96@srcf.net>
Subject: Re: [PATCH] xen: Modify domain_crash() to take a print string
In-Reply-To: <c20b2017-7313-41bd-c854-48029a5df206@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 03/02/2022 15:06, Jan Beulich wrote:
> On 03.02.2022 15:41, Andrew Cooper wrote:
>> On 03/02/2022 14:19, Jan Beulich wrote:
>>> On 03.02.2022 15:11, Andrew Cooper wrote:
>>>> On 03/02/2022 13:48, Julien Grall wrote:
>>>>> On 03/02/2022 13:38, Andrew Cooper wrote:
>>>>>> diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
>>>>>> index 37f78cc4c4c9..38b390d20371 100644
>>>>>> --- a/xen/include/xen/sched.h
>>>>>> +++ b/xen/include/xen/sched.h
>>>>>> @@ -736,10 +736,15 @@ void vcpu_end_shutdown_deferral(struct vcpu *v);
>>>>>>    * from any processor.
>>>>>>    */
>>>>>>   void __domain_crash(struct domain *d);
>>>>>> -#define domain_crash(d) do
>>>>>> {                                              \
>>>>>> -    printk("domain_crash called from %s:%d\n", __FILE__,
>>>>>> __LINE__);       \
>>>>>> -   
>>>>>> __domain_crash(d);                                                    \
>>>>>> -} while (0)
>>>>>> +#define domain_crash(d, ...)                            \
>>>>>> +    do {                                                \
>>>>>> +        if ( count_args(__VA_ARGS__) == 0 )             \
>>>>>> +            printk("domain_crash called from %s:%d\n",  \
>>>>>> +                   __FILE__, __LINE__);                 \
>>>>> I find a bit odd that here you are using a normal printk
>>>> That's unmodified from before.  Only reformatted.
>>>>
>>>>> but...
>>>>>
>>>>>
>>>>>> +        else                                            \
>>>>>> +            printk(XENLOG_G_ERR __VA_ARGS__);           \
>>>>> here it is XENLOG_G_ERR. In fact, isn't it ratelimited? If so,
>>>>> wouldn't it be better to only use XENLOG_ERR so they can always be
>>>>> seen? (A domain shouldn't be able to abuse it).
>>>> Perhaps.  I suppose it is more important information than pretty much
>>>> anything else about the guest.
>>> Indeed, but then - is this really an error in all cases?
>> Yes.  It is always a fatal event for the VM.
> Which may or may not be Xen's fault. If the guest put itself in a bad
> state, I don't see why we shouldn't consider such just a warning.

Log level is the severity of the action, not who's potentially to blame
for causing the situation.

Furthermore, almost all callers who do emit appropriate diagnostics
before domain_crash() already use ERR.

And, as already pointed out, it doesn't matter.  The line is going out
on the console however you want to try and bikeshed the internals.

>  IOW
> I continue to think a log level, if so wanted, should be supplied by
> the user of the macro.

That undermines the whole purpose of preventing callers from being able
to omit diagnostics.

~Andrew


From xen-devel-bounces@lists.xenproject.org Fri Feb 04 12:12:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 12:12:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265452.458818 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFxRz-0002ge-8m; Fri, 04 Feb 2022 12:12:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265452.458818; Fri, 04 Feb 2022 12:12:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFxRz-0002gX-5m; Fri, 04 Feb 2022 12:12:27 +0000
Received: by outflank-mailman (input) for mailman id 265452;
 Fri, 04 Feb 2022 12:12:25 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TTBG=ST=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nFxRx-0002gR-72
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 12:12:25 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b4d087fd-85b3-11ec-8f75-fffcc8bd4f1a;
 Fri, 04 Feb 2022 13:12:23 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b4d087fd-85b3-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1643976743;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=VV1SgA/+vHhVXkU0glUqb589oAQ2iOPI7l8P+Ayc/vc=;
  b=V14IH5uy6WcgngLD1PZlCKd3DJmEAzwEP3lnPcxHdnXuUqXGj+6kiH9p
   oBQtXCteYYRNHQit/YmAxn4RlS1DB3BfHc6E242J844PnrC0lAe7MHsPQ
   aswcgbqq4u4Yje6Oigzj9Zs3uXcUwHmVMR0WX6v76eVEYR2+5dMU88afC
   Q=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: NDFaphHeJ8slrujuoiwlRnUqPxcZW2FkYlgBXR6m9wH4PZyQEh6DW7k9NAYkaw6H123mA2PPpx
 o1xe9THslPN2J0qpQ3XOE4X4AKwBymD7px4qxfuoHGjyyvaUav+8zcDHvPrHqNq5YR3TAg00Ut
 wn+4eRf3ap62vXFZJDz9FR9lRx09Znpx2iQH7yTvJT0FnmLhF87s4dG4pxVPaIVqYylMlD1oBQ
 uoikQFq+piuzpuXsNcyjXwJAYSpg9K+ksOk8+G5+aOGikYL6Gp25qy5rY1rkfT9YZ6G7hVZJwd
 VvoXuMnS+JjTsddZ4nSnhha/
X-SBRS: 5.1
X-MesageID: 63900360
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:o4Hwnq9OdOQrsunmX2ocDrUDanmTJUtcMsCJ2f8bNWPcYEJGY0x3m
 GAdUWGFPqmJN2Cjf991atzi8RhVv5aHnYRkSQM+/H88E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhFWeIdA970Ug5w7Rh3tYy6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhM5
 OVVu4PzYDskZLSXgP9BTxZiVB1haPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguwKKsXxMZxZkXZn1TzDVt4tQIzZQrWM7thdtNs1rp4VTK6GP
 JRBAdZpRD/KRS1xZGhINKgzs/ul30bmLxR0uGvA8MLb5ECMlVcsgdABKuH9eNOQQt5Otl2Fv
 W+A9GP8ajkKOdraxTeb/3aEgu7UgTi9SI8UDKe/9PNhnBuU3GN7IB8cWEa/oPK5olWjQN8ZI
 EsRkgIxqYAi+UrtScPyNyBUu1bd4ERaAYAJVbRntkfdkcI4/jp1GEA5Yg5ZZsNlnfM7HyVxz
 kTVg9zTQgBw5ej9pW2myp+Yqja7OC4wJGAEZDMZQQZt3+QPsL3fnTqUEI89TffdYsndXGipn
 mvU9HRWa6A70JZTv5hX62wrlN5FSnLhagcurjvaUWu+hu+STN70Ptf4gbQ3ABspEWp4crVjl
 CVc8yR9xLpXZX1oqMBraL9WdF1Oz63dWAAweXY1Q/EcG82FohZPh7x47jBkP1tOOc0ZYzLva
 0K7kVoPuMQDZyb0MP4sPNnZ5yEWIU7IT4+Nuhf8NYImX3SMXFXfoHEGibC4gwgBb3TAYYlgY
 MzGIK5A/F4RCLh9zSreegvu+eRD+8zK/kuKHcqT503+idK2PSfJIZ9YYArmRr1ot8us/VSKm
 +uzwuPXkn2zpsWlOXKJmWPSRHhXRUUG6Wfe8J0KL7PTf1Y9RQnMyZb5mNscRmCspIwM/s/g9
 XChQE5Ijl35gHzMMwKRbX5/LrjoWP5CQbgTZ0TA5H6khCouZ5iB9qAae8dldLUr7rU7n/V1U
 +MEa4OLBfEWEmbL/DEUbJ/cqo1+dUv02VLSbnT9ODVvLYR9QwHp+8P/ele9/ic5ESfq59A1p
 Ket112HTMNbFRhiFsvfdNmm00i14SoGgOt3UkaReotTdUzg/ZJEMSv0ivNrccgAJQ+anmmR1
 hqMAAderu7I+tdn/N7MjKGCjoGoD+ohQRYKQziFte67bHCI8HCizIlMVPezUQrcDG6kqr+/Y
 eh1zu3nNKFVllh9rIchQa1gyrgz5oWzquYCnBhkBnjCc3+iFqhkfiudxcBKu6BAmu1ZtA+xV
 h7d89VWI+zUasbsEVpXLws5dOWTk/oTn2CKv/gyJUz74g5x/aaGDhoOb0Xd1nQFIesnKp4hz
 McgpNUSul62hRcdO9qbijxZqjaXJXsaXqR77pwXDecHUObwJo2utXAENhLL3Q==
IronPort-HdrOrdr: A9a23:BK0dm6z6nDkOTTmvGjrUKrPxiuskLtp133Aq2lEZdPULSKKlfp
 GV88jziyWZtN9IYgBdpTiBUJPwJU81bfZOkMgs1MSZLXbbUQyTXcFfBOrZsnPd8kjFl9K1up
 0QC5SWZOeAb2SSyPyKnTVQcOxQg+VvkprY/ts2pk0FJWoBBsEQjDuRSDzraHGeLDM2WKbRf6
 Dsgfav0gDQAEj/Gf7LYEXtMdKzwuHjpdbDW1orFhQn4A6BgXeD87jhCSWV2R8YTndm3aoi2X
 KtqX262oyT99WAjjPM3W7a6Jpb3PH7zMFYOcCKgs8Jbh3xlweTYph7UbHqhkFxnAjv0idvrD
 D/mWZnAy1B0QKJQohzm2q05+DU6kdo15Yl8y7CvZKsm72ieNtwMbs+uWsQSGqp16NnhqAh7E
 sD5RPri3IcZymw7BjV9pzGUQpnmVGzpmdnmekPj2ZHWY9bc7NJq5cDlXklXavoMRiKo7zPKt
 MeRv00JcwmBm+yfjTcpC1i0dasVnM8ElOPRVUDoNWc13xTkGpix0UVycQDljNYnahNBKVs9q
 DBKOBlhbtORsgZYeZ0A/oAW9K+DijITQjXOGyfLFz7HOUMOm7LqZTw/LIpjdvaNKAg3d83gt
 DMQVlYvWk9dwbnDtCPxoRC9lTXTGC0TV3Wu4ljDlhCy/TBrZbQQFi+oWEV4r2dSq8kc7/mst
 6ISeZrP8M=
X-IronPort-AV: E=Sophos;i="5.88,342,1635220800"; 
   d="scan'208";a="63900360"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=AaIrsuInwIEAnOVzMQBGCNUyB4YHp0UB009rVO04YcpW0XDP7Lc3Ao6/sTI3keyKWzb/M5Kf+Q9mC5GDq/y3OfraT0qQyYvElKjrZW0wSNaVn4j0NDAn6dwuJTSLjvPdElLZQQXHmLqRePMbI2u6ucDw9/cy3qlfE6/MwRDEX51kbUgjnzSYIgdP1dbeIYBm+nG/Vqqel3xnt73xlpdyhaAzGci1eH9az44k1fwwdcznjFkKFeADO+m4iDw1k/Zz7tD9LnqGD9wmMVYZ5fOrhtChYEBtQtoFWzK6fhK5m2wWN94YMWsDHRtVNAxeWz+fpyeKJvWDjoRT6OR3pPQWRA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=VV1SgA/+vHhVXkU0glUqb589oAQ2iOPI7l8P+Ayc/vc=;
 b=Rm0Fz+b2p8GC/gk9qFPvJZoSTTGEEuvVMJb3yJy5hn4pnHnhSC69ueFAmQD4oHmbG/GMVSHW7LQ6H7sIOWhTnW2QJz7lr4QA0SFq/tTmscMEjPLbRGpvudOVbN/R6xZEl2dk+QY2KPiolp8VpxJvwtsHTi18zrx4TNck77Q3e9WBFR9HtlKOw+WBHLo1qMURuNHZaPd2RttDeZ+KJkxSivlQpFaJy39ka/wNXtoZP7HsVVkmWpThxhoqfsPZ/O0eqBXNlhc5bUj/1A+PMrwYxkv7BigbPOZWTlqiCOW/OCu3yJaBYfxziHa4/cAXS3Q039hLbVloNMQReNHcyC0URA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=VV1SgA/+vHhVXkU0glUqb589oAQ2iOPI7l8P+Ayc/vc=;
 b=rOQAKSdWz1c8828azoG8xGkUTl2g4SRSn5xWIoEjKYDGUx52ac9hSQaiGsgYnN1mKwGR+x94ZlVHcm521p9hPOywd+Yxrh5Dtmv3+80+C8UgvnGYktq/19Q4x9dxl/MFicd5C1n+nhtFlycVBhxjdnGGxXoxLXvdDgi/jUuuv7s=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>, Roger Pau Monne <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>, Anthony Perard <anthony.perard@citrix.com>, "Juergen
 Gross" <jgross@suse.com>, Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] tools/guest: Fix comment regarding CPUID compatibility
Thread-Topic: [PATCH] tools/guest: Fix comment regarding CPUID compatibility
Thread-Index: AQHYGSl3cICfrTH0c0a6DCprlMhYPKyDEOqAgAA9p4A=
Date: Fri, 4 Feb 2022 12:12:16 +0000
Message-ID: <f2ce80ee-f30c-dc6f-e4b7-5d8eddb5b3d5@citrix.com>
References: <20220203181023.1554-1-andrew.cooper3@citrix.com>
 <53b98995-8cef-48b4-7728-3bfbc236af5f@suse.com>
In-Reply-To: <53b98995-8cef-48b4-7728-3bfbc236af5f@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.1
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 931af6b9-4de3-4bf6-3460-08d9e7d795b6
x-ms-traffictypediagnostic: PH0PR03MB5718:EE_
x-microsoft-antispam-prvs: <PH0PR03MB57189D694350F280854EDCB9BA299@PH0PR03MB5718.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:2803;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 7CN1XU200XQ5p5aNPlytAA4GSR04c2ew18E+EFfBrFuPv72Fh6YDRekIp4OC+F8/fwWWjbpeO/fZSCgqcbuDZ71c9RIBSzT/eH/I6kUgRLhRlwqk5BqIoHUAY3JBNGVIacR8mWorBvqx0tpcGqKTXZuoqT8oP7x0R9JjilZqhCjdUL+L6RBh4y0uYBfe452mHbPEFIWbocN+O4yEJ7es6lJOvjbtujhXdCEEYaaqDEjEOQFbjFVUPtL5gsjNChUZRmzhZYropOTkaZ5xaouEezJFT7+r3YqIqedermwEldtonJXwgLD9V9Y4juipy4halRsQ/Nxd62wQJmLORjprVHt53zZgemW3FJtdsbMkvJtD3JEGwD6e+7o6/QuUXiryJV2TqxI6K3KbhMYbM4g1WONDG3PKITgzlCf4O0gBCtv8XhMZgloroMtFRgJfW7gMVNY9GrPVDK0fx5vy5C4OIZj4nCuK4VKjurjUfMTwjDL8sMhrCJmNz4JhsU1yoSgiq0eLPFnVTsPSJ8sybe/HDm7O4rnHxQNP4eUg//VU3I5dQhVNoNl04eMQDsF8JgXkrVf2PekNw8Jvj/e9QcWGqVRLuV4D0W9tJe669MWDFvrxgSCy48g8ufmsIHWC31BXEmGuocPuGXsxqxRsvma/TDpYGqL/UlM78SaqX3xLRVDT2coT0gFZHnSA8yQHIDi9gUoepn3gpbUrsugc3LC4UiICpZD3cwLOJJeUWxce1vrtfgN9wBYnKH6hAN4Cf6+uYvngHszHZO2M8P/Tm9bjKQ==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(91956017)(66476007)(66446008)(186003)(6486002)(66946007)(4326008)(26005)(76116006)(31696002)(8676002)(2616005)(82960400001)(6506007)(8936002)(6512007)(2906002)(64756008)(53546011)(71200400001)(38070700005)(31686004)(316002)(6636002)(110136005)(54906003)(38100700002)(508600001)(36756003)(5660300002)(122000001)(83380400001)(86362001)(66556008)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?UDV1T1dGNFQxaWFnbUhlQXY5ZHV5SFMxc1VhOTFObHlaOWFWMWU1VTdDUmp6?=
 =?utf-8?B?dlNuZjZaM2pmVlA0dWMwNHcrRTdXUFh6ajBDQVNsUm5yalB5SzBoVXhrWE5p?=
 =?utf-8?B?L3NuN2tUazZlMmhWVTdsdG1xcThuMDRhS3ZnSjAweWxxdTRNYWFIWHI2UEwz?=
 =?utf-8?B?M2hFRFIybks3MTJ4bG9YRFl6eHBIbTFOYXlneHZibDV6MEszQlNteTVSeS91?=
 =?utf-8?B?VE1PZ0tkTkxLNnc2K20yaUswY0xMZ3R2Q0FTRitxUnJIbWtPd3JYUzFPOHRl?=
 =?utf-8?B?bnZKOUhNOUw3dWhoai9OM0dMN3gxYVNXUkM5YXQ4WE0yeTBZTlQrWkhjY0xz?=
 =?utf-8?B?OERqSHhKOG9zNWpuRUJQc0pBUzFQbjhkbEtkcUNBMTJ0NlpCaWFBWUJSSFFx?=
 =?utf-8?B?WW5kS0NFMGpFTnBSdmh1TU5iNExxTnA0NDM0VkUrVmloVlFQcXpORmRzK01O?=
 =?utf-8?B?VUZFS1FZSmtReXBRNFZUU1BmU3NqckJsODlKWGJHbU11U255QVJURjNCbFBC?=
 =?utf-8?B?dUpNL0UrcVRkbkplQkpvS1I1Z3c0VyszQ3F6bjk5QjducVAwZnlqZW1xTjND?=
 =?utf-8?B?K0F2WkZtNmt6QWgzdVRSYmFwN29BV21zL3pKYmZDVTlnT0F2RlRCUUFKV3BV?=
 =?utf-8?B?OG9OT2lCTk5MMGt6S2ZSVG53MVVUQUtjSWRhbi9uOWxBc3JYR2FYNGQ0YkE4?=
 =?utf-8?B?SG8ybzc4M3k2ZG9pNnpVVit5Vk5HK0lydTdiTDU1UjhDeERoQ0w0b2tBeFB4?=
 =?utf-8?B?OFZoT21OeElnbW5NR2NvekNkRXhSSGw3Q1crK1pPYWJ5eEx0TW83dVJjRUpI?=
 =?utf-8?B?QjErVzVISmNEKy9wWWdlakNnNkpTd1orOGdBZWpvbHA3ZmFyQ0haOWRjRGVL?=
 =?utf-8?B?bFpQSHlDZk9hUU5UNHZkZS9TOTFRbXdycUx3V1hMRGx1TTVmUDBrZHo0M1NM?=
 =?utf-8?B?NlAvSHVZbFUvb1cxSmxUV2JscW1qYysyTVk2UnJjZksxOE13clF6Yk11RUk3?=
 =?utf-8?B?eFVMRHp5NUs5Qmc5TjJid2UrTmlDVi9qMG5BNTMwQlRzVEgxWmRxR1ZldzFU?=
 =?utf-8?B?ZStoSElaUTkxc20rMTBNVTVELzczWEVWL2puK1dJVFhPeS9LcmlyMSt1Wkwz?=
 =?utf-8?B?MkVQZDcxYXAyQlE4c0dxWUNJZ2VCZnJNWGxMdzZneGVCTHRyVlZPQzdZR0do?=
 =?utf-8?B?dmxxblBpaFlVZktTWjFRcjI5V3ZCaUZ2ZkpYZWlocGQ4aFdmeVQ4QWNHQ2ZH?=
 =?utf-8?B?WlJRWGtJZ09XYXRlTlQyWW95VFkwVHNEWDduU2N4eHlHQjltdmFKYndUckFz?=
 =?utf-8?B?a0JHTncxNUhvUHNvQ2hkSWc2REFtdnJKTjhwVHcwUGx1QW9oOUZHdEU3UURy?=
 =?utf-8?B?KzFZdm5RN21UVFRqMGZESEptcTYwN2I2cEpiUDJRMmhqNU1ONE5ZTXVxellD?=
 =?utf-8?B?OG1hZWR2OFcvZi9oUDdQZzNvUXpuZHFEcXVmNlFWSGdyVTlNN0hLNW14M3Ix?=
 =?utf-8?B?NTRRa3drTnJrZkVKTXZtY0ZGeS9rREtBc0FrcTVlU28yYWdZbTJOVk5aWUNC?=
 =?utf-8?B?Vy9KTWg5UUFaeUpLcGZMWEJsU0FFY1RrY3V1L0VkQUZDODhtaUpJbDYvTGRn?=
 =?utf-8?B?MldVSWI1bDJVU3l4WXNXQW9VdjVYcE5OYk5uRWRBV01yN25SSWQrbnJSdUZT?=
 =?utf-8?B?aWdRYS9sY1F3MkovdGNMM1JjSHA1dXhFVnQ2L3d2MVduODVJMDlJVHFmbmJO?=
 =?utf-8?B?UW1Ja09QelQ2ZlArVncyd1o5Y1I1bDAzK2E1dEV4M2JJWGRJNkJZL21TbHVE?=
 =?utf-8?B?bGlNRTlXTUxLK3BEK3d0emEveWhTM2pkU1RmdUI2amtKQ1ZMT1pvM1ZRS0Zt?=
 =?utf-8?B?YXZQWVZQbUpFdDVXVjljbnIzRlZaeUhyTW9RZmRKb3hDM09XMHNBVkxVaWlZ?=
 =?utf-8?B?bTYzZm9VYUJvaTM2STJKRXd2OUFuN3E1SDkxVytjSUF3dDUyekF5a3N3eFN3?=
 =?utf-8?B?bG1sYW9xYWJKL0luUlFlR1NGcjZULzRZZUpmekxiR3dsY3JUa09rNzNaMjhu?=
 =?utf-8?B?TEZCR0RvazFYdytucWFzelJ3RDZSMnlQQ3FxUGxkOWxueFZvWUtnVTZLcWFx?=
 =?utf-8?B?cDJrN3F2dnBOTmtmb2hoQUgyOVhJL3YrMmtPdytTQ09wSVF3SGxjMzhteXhs?=
 =?utf-8?B?Z3VQWTN0TkxucVdNUVJWWHI0K0F0ZzhUaXdlU29aRTYxMmFwU1BXOEFPTGVB?=
 =?utf-8?B?dTB1aE1vYnhVUGhIRVpXN2xJSmdBPT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <ECAC67A0F71B7245BB3185CEE23DDC97@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 931af6b9-4de3-4bf6-3460-08d9e7d795b6
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Feb 2022 12:12:16.0523
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: //g4w9XD/MAdDem1XcbnSRbWQzCThNoA0gTjpez9TZrfnxPTNgGBEy2w6DCK2VzhaODF55i8he/IckjgNEwiq6JXIjAtA9FsOk3QJb5HGvc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB5718
X-OriginatorOrg: citrix.com

T24gMDQvMDIvMjAyMiAwODozMSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDAzLjAyLjIwMjIg
MTk6MTAsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBJdCB3YXMgWGVuIDQuMTQgd2hlcmUgQ1BV
SUQgZGF0YSB3YXMgYWRkZWQgdG8gdGhlIG1pZ3JhdGlvbiBzdHJlYW0sIGFuZCA0LjEzDQo+PiB0
aGF0IHdlIG5lZWQgdG8gd29ycnkgYWJvdXQgd2l0aCByZWdhcmRzIHRvIGNvbXBhdGliaWxpdHku
ICBYZW4gNC4xMiBpc24ndA0KPj4gcmVsZXZhbnQuDQo+Pg0KPj4gRXhwYW5kIGFuZCBjb3JyZWN0
IHRoZSBjb21tZW50YXJ5Lg0KPj4NCj4+IEZpeGVzOiAxMTFjOGMzM2E4YTEgKCJ4ODYvY3B1aWQ6
IGRvIG5vdCBleHBhbmQgbWF4IGxlYXZlcyBvbiByZXN0b3JlIikNCj4gQnV0IGRvZXNuJ3QgdGhp
cyBjb21taXQgYW1lbmQgNjg1ZTkyMmQ2ZjMwICgidG9vbHMvbGlieGM6IFJld29yaw0KPiB4Y19j
cHVpZF9hcHBseV9wb2xpY3koKSB0byB1c2Uge2dldCxzZXR9X2NwdV9wb2xpY3koKSIpLCB3aGlj
aCBpcw0KPiB3aGVyZSBERUZfTUFYXyogZGlzYXBwZWFyZWQ/DQoNCk5vLiBBbGwgdGhhdCBoYXBw
ZW5lZCBpbiB0aGF0IGNoYW5nZSB3YXMgdGhhdCB3ZSBzd2l0Y2hlZCB0byB1c2luZw0KDQpjcHVp
ZC5oOjg5OiNkZWZpbmUgQ1BVSURfR1VFU1RfTlJfRVhURF9BTUQNCg0KaW5zdGVhZCwgd2hpY2gg
cmVtYWluZWQgdGhlIHNhbWUgc2l6ZSB1bnRpbCBYZW4gNC4xNSB3aGVuIGU5YjRmZTI2MzY0DQpi
dW1wZWQgaXQuDQoNCj4gV2hpbGUgbG9va2luZyBhdCB0aGlzLCB3YXNuJ3QgUm9nZXIncyBjaGFu
Z2UgaW5jb21wbGV0ZSwgaW4gdGhhdA0KPiBmb3IgSW50ZWwgdGhlIGV4dGVuZGVkIGxlYWYgdXBw
ZXIgYm91bmQgd2FzIDB4ODAwMDAwMDggaW4gNC4xMj8NCg0KQ1BVSURfR1VFU1RfTlJfRVhURF9J
TlRFTCBpcyBzdGlsbCA4LCBzbyB0aGlzIGlzIGFsbCBmaW5lLg0KDQpFdmVuIGlmIGhhcmR3YXJl
IGhhcyBtb3JlLCB3ZSdsbCBzdGlsbCBsaW1pdCB0byA4IG9uIEludGVsLsKgIFRoYXQgc2FpZCwN
CnRvIHRoaXMgZGF0ZSBJbnRlbCBoYXZlbid0IGJ1bXBlZCB0aGUgbGltaXQsIHNvIHdlJ3JlIGFw
cHJvYWNoaW5nIDINCmRlY2FkZXMgd2l0aG91dCBjaGFuZ2UuDQoNClNob3VsZCB0aGlzIGNoYW5n
ZSwgdGhlbiB5ZXMsIHdlJ2QgaGF2ZSBoYXZlIHRvIGFkanVzdCB0aGUgY29tcGF0IHBhdGguDQoN
Cn5BbmRyZXcNCg==


From xen-devel-bounces@lists.xenproject.org Fri Feb 04 12:15:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 12:15:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265460.458830 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFxV7-0003Ic-OK; Fri, 04 Feb 2022 12:15:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265460.458830; Fri, 04 Feb 2022 12:15:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFxV7-0003IV-LG; Fri, 04 Feb 2022 12:15:41 +0000
Received: by outflank-mailman (input) for mailman id 265460;
 Fri, 04 Feb 2022 12:15:40 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=46ws=ST=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nFxV6-0003I6-0l
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 12:15:40 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 288e60e1-85b4-11ec-8eb8-a37418f5ba1a;
 Fri, 04 Feb 2022 13:15:37 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 288e60e1-85b4-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1643976937;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=7ZVk3LWMhdvQy6YVzmmNOu3jMzmBx8+ZuP9739N7bEg=;
  b=axryVhGM6Yj1CCByCm7iY61wHaCim6k3jifJ8M6mnynGkWVImvT7swsX
   xn2WMuZ90ukwDn8xUgjpGQGmAbtaHcun23D47Ckv5YVvjzjc0rHxdLkkR
   q41xSUN/TT3uKJCpMEU2L87+jWa5O0isy+0ZyEtRuENwNrpm/SZrXBSD8
   o=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: hOsT1x04df9AA4wuVvfZ27wNo1vK42GvY54kEFTOU/37Y7MlUQPspD949T4ZPZ0qSO+O0/Jk8o
 UL8gC4nWb9MeV7ug++IZWn7m+AJBeJdT4lIuIHRVC+JuQ83CCGyrdrRkamSNFk7pYGMMSFq/df
 xfAQRVgDEMqSjgRmh3MU1df7an5S9cjovj8aL7ak1zDoFvHnAdvU9Ru6uKhqm0s2zxGH9rZZrM
 icFc8CyvPE86I8F8TIWy0P+kSxuOj+LVP45ySORMT8f/s7iTw7k5hMNf7PkcwVuv70b2tOsjl6
 d2MWZxZm2pRRbohJaC9TUicM
X-SBRS: 5.1
X-MesageID: 63900502
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:tzXtqaKYyqiWnUgSFE+R85MlxSXFcZb7ZxGr2PjKsXjdYENS3zEDn
 WRJDDiGOKveZWX9KIhwOoi+p0kB65aDmN8wS1BlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokcxIn5BC5C5xZVG/fjgqoHUVaiUakideSc+EH170Ug7x7Zj6mJVqYPR7z2l6
 IuaT/L3YDdJ6xYsWo7Dw/vewP/HlK2aVAIw5jTSV9gS1LPtvyB94KYkDbOwNxPFrrx8RYZWc
 QphIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbrGvaUXe345iXMfwZ3u7hB3Rw9Nz+
 ekUuafoF10vG6r+qcFCWSZHRnQW0a1uoNcrIFC6uM2XiUbHb2Ht07NlC0Re0Y8wo7gtRzsUr
 LpBdW5LPkvra+GemdpXTsF2gcsuNo/zNZ43sXB81zDJS/0hRPgvRo2Uvo4AhGpo3KiiG96PS
 eYUeyE2YS2cTABIGVEJNq8CmcW30yyXnzpw9wvO+PtfD3Lo5BR4zbzFINfTPNuQSq19t1yEq
 2fx2nX2CxAXKvSS0TOAtHmrg4fnly7hRJgbErH+8/dwmUCS3UQaEhhQXly+ydGph0j7V99BJ
 kg8/is1sbN05EGtVsP6XRCzvDiDpBF0c8BZE/A+rhqMzKXUyw+DAy4PSTspQOIhsMg6VDk7z
 GijltniBSFsmLCNQHfb/bCRxRuwMyUIKW4JZQcfUBAIpdLkpekbqRbCTc1qFqKvufTzFSvt2
 DCBrCU4hLI7gNYC0uOw+lWvqzCxopnESCYl6wORWXiqhiteYIOmfIWu5ULs0edbLI2ZQ1+Cu
 1AJg8GbqusJCPmljzeRSe8AGLWo4fetMzDGh1NrWZ47+FyQF2WLJN4KpmskfQEwb5hCKWSBj
 FLvVR15vMNQPkqWNKNMO9zrDeEt/5nFSt7aSaWBBjZRWaRZeAiC9SBoQEef2WHxjUQh+Z0C1
 YenndWEVihDV/k+pNaib6JEiOJwmHhirY/Gbc2jl3yaPayiiGl5oFvvGH+HdagH4ayNu205G
 P4PZpLRm32zvAATCxQ7ELL/z3hXdRDX5ris8qS7k9JvxCI8QwnN7NeKmdscl3RNxfg9qwsx1
 ijVtrVk4FT+n2bbDg6Bd2pubrjiNb4m8y5gbXdxYwv5gCd4CWpK0Ev5X8FsFVXA3Lc7pcOYs
 tFfI5nQahixYmivF8shgWnV89U5KUXDafOmNCu5ejkvF6OMtCSSkuIIijDHrXFUZgLu7JNWi
 +T5imvzHMpSLyw/XZ2+QK/+kDuMUY01xbsas73geYIIJi0BMeFCdkTMsxPAC5pddEyelmbGj
 Fv+7NVxjbClnrLZOeLh3Mish4yoD/F/DgxdGWza5qyxLi7U4iyoxooobQpCVWm1uLrc9Prwa
 ONL4ev7NfFbzl9Gv5AlS+RgzL4k5suprLhfl1w2EHLOZlWtK7VhPnjZgpUf6vwTnudU6VmsR
 0aC2thGIrHVasnrJ0EceVg+ZeOZ2PBKxjSLtaYpIF/37TNc9aacVRkAJAGFjSFQdeMnMI4sz
 eo7ltQR7giz1kgjPtqc13gG/GWQNH0QFa4gs8hCUoPsjwMqzHBEYIDdVXCqsM3eNY0UPxBzc
 DGOhafEi7BN/Wb4ciI+RSrXwO5QpZUSoxQWnlUMEEuEx4jejfgt0RwPrTluFlZJzg9K2v5YM
 3RwMxEnPr2H+jpliZQRX22oHA0dVhSV9laolgkMnWzdCUKpSnbMPCs2PuPUpBIV9GdVfz56+
 rCEyTm6DWa2LZ+phiZiC1R4r/HDTMBq8lyQkc+qKM2JAp0mbGe3maSpf2cJ90PqDM5ZaJcrf
 gW2EDKcsZHGCBM=
IronPort-HdrOrdr: A9a23:QS8xqqDuS3j+0hzlHeg0sceALOsnbusQ8zAXPh9KJiC9I/b1qy
 nxppkmPH/P6Qr4WBkb6Le90Y27MAnhHPlOkPQs1NaZLXLbUQ6TQr2KgrGSoQEIdxeOk9K1kJ
 0QD5SWa+eAfGSS7/yKmTVQeuxIqLLskNHKuQ6d9QYUcegDUdAf0+4TMHf8LqQZfngjOXJvf6
 Dsmfav6gDQMkg/X4CePD0oTuLDr9rEmNbPZgMHPQcu7E2rgSmz4LD3PhCE1lNGOgk/jIsKwC
 zgqUjU96+ju/a0xlv10HLS1Y1fnJ/ExsFYDMKBp8AJInHHixquZq5mR7qe1QpF6t2H2RIPqp
 3hsh0gN8N85zf4eXy0mwLk303a3DMn+xbZuCmlqEqmhfa8aCMxCsJHi44cWADe8VAcsNZ117
 8O936FtrJMZCmw0hjV1pztbVVHh0C0qX0tnao4lHpES7YTb7dXsMg24F5VKpEdByj3gbpXX9
 WGNPuspMq+TGnqLEww5gJUsZ6RtzUIb1u7q3E5y42oO2M8pgE986MarPZv6UvouqhND6Ws3N
 60QZiAoos+OvP+XZgNdNvpfvHHeFAlYSi8eV56cm6XXJ3uBRr22uvKCfMOlaaXRKA=
X-IronPort-AV: E=Sophos;i="5.88,342,1635220800"; 
   d="scan'208";a="63900502"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=m40Yxvr2zyEl4vzNPAQDuqf6mMiVgqNHoOxLoySjw2Inl8zfNEEHeVI5h5xNG3snMN/a4V74WSkNGLfs1I+XsCu5hlR3Qm0cRWsvJ/1M+B6sjH2WvyyqRVT6gjGcFbB+lF8RAEsfprYPe3+FaBc7ytrHU56yMMwO1r3Yotj8whdAW9vrGxJpv0FSN9C4kidbBG/ifAjJ4jnD9Ow6qzvDXLdk9u5Oev6yNTtjRYwf3DYysdC2Fn4US/UMltNjcbQYJqFexNUN5QSRvWuZ2DxzXS5gGgB1wGTomHS28O/eJtbpIbICtfVrzAvdny48CemZNFLIz/es1si0emoGj7dX6A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=SxcVPsnDzRDyHUMKl2zPufZvTJ9bZ9pZr7eWfrRfxBU=;
 b=mAXae7CO+zQyJ/coUsikEFN3yq3QoKzV6FYvMMx90JUaeep/UkRYIZS/eSYClajtBQwlJxa9JWzBcuLr/SCOf63/+RUbxxLuQRRj85vxqaVVvPomNBAwjYnR9SvfaEZDvPdx3JB0yHWl3tHx9N/BdQ2MOkdO4fA0dEzoDGHc2ze1a+QaT8fw7t3DbZCfMTwtuIuqnH6bHriPOIENDkBY5SU5RBsH8e0JJxlrDhsP7YsUwAxwQq5MDLhZbKodd32N3Wsg7YK0MBvfGun3w3lHvdLE7Tl34juBM9DuwjTNsFwM/I4A11YLvZkR6WeqBIkP31xocvzP2dU0rNTJMwqGvA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=SxcVPsnDzRDyHUMKl2zPufZvTJ9bZ9pZr7eWfrRfxBU=;
 b=W9QYTNwPaeDPIu7LRz7naWUCjtSMoALfDdHZhhlJpB+BJEHiCXHc+sQB+SVhvV6Dtp/fZcaRYpZkx0HR2j00nIjMpsHZduORc/BP6h6p2AEcfbRX7yfoMgakKh8J7q3BiUH/dBacX5wIzJtlB7Jru/OQYGA2IxVwhM7/H9TKiZo=
Date: Fri, 4 Feb 2022 13:15:28 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: Jan Beulich <jbeulich@suse.com>, "julien@xen.org" <julien@xen.org>,
	"sstabellini@kernel.org" <sstabellini@kernel.org>, Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Artem Mygaiev <Artem_Mygaiev@epam.com>,
	"andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
	"george.dunlap@citrix.com" <george.dunlap@citrix.com>, "paul@xen.org"
	<paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>, Rahul Singh
	<rahul.singh@arm.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Message-ID: <Yf0Y4DEG4b5d3pRi@Air-de-Roger>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-4-andr2000@gmail.com>
 <7209889d-8f17-61cc-72a4-97f6dbc1d54d@suse.com>
 <2cf022f8-b000-11b7-c6b9-90a56bc6e2ea@epam.com>
 <04726915-f39f-9019-436e-4399533c9fc3@suse.com>
 <9ed3f4ac-0a2d-ed45-9872-7c3f356a469e@epam.com>
 <c3a99712-cf7c-37da-aac1-f2ee00e6d53b@suse.com>
 <Yf0KcVD8W05A4fbB@Air-de-Roger>
 <55fc77e8-44c1-8769-f818-d68c05dec987@epam.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <55fc77e8-44c1-8769-f818-d68c05dec987@epam.com>
X-ClientProxiedBy: LO3P265CA0006.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:bb::11) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 6fa1dec0-9286-45f8-3464-08d9e7d80a2e
X-MS-TrafficTypeDiagnostic: BYAPR03MB3925:EE_
X-Microsoft-Antispam-PRVS: <BYAPR03MB3925A28609E3B740C0AE2E4F8F299@BYAPR03MB3925.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: MS+RZz/EaS+gzmQxdETgT9qd2Gco720ISka83w9C/Dm5qcX2n9IhJCZu4U/O6jImr8jwikDsXGQgbX4joQNRcCAOFrwHS7kCUHl8jHo7DXNvb2w7r4xLKR5xsh2RoaVn9nMO1TvTaoiGWbuh5EAI2jEO+jkf432JYbdjkOuG6zdAQNH+n9uBIzfURFb3En94nrwWpi9MBABp9yBuoECq2kQ8GK576NwnMDG1mqFNv53ZWEzG0hF8Qiv9a6KwK0zSgbpCB9Cz4RKUJGJ3TnGaN3IEh1+Jfgz91fhAxVsfBfDMZ/pOqLopDHhH+Yk7Pzh4pxeeUEGSKQnWmr60zf4pzoTU7zZptl19r47KJDenGUL1RqQ6/+GF9VotimL9FG1fCnVh3LCKP7WTq1cwyTB2+YBRpbuhi57Y8h/HJYvLkd6fZ42PHinUFCLV8hViR2nCxFlw8M4CxpA4fON2bK73XeGaL5Z2BZ0IZ356pU7BF03Cf6hf0Ef/Z6r+3qQvnml3fHeeaE4WAeNxrGFnkFuThIJho37YqaopLTmoc/8rr85qOr+4JtMgv+lBSjGtFS/A2yh26N4+C6yXh7VPt8qzqPwZX6y8JCpaymFYrhRfE74xcPp/5z9KiKqakW2Gd/r5OM9L1G+MU/OC+UUpFs8J6g==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(4326008)(66476007)(66946007)(8676002)(8936002)(66556008)(2906002)(83380400001)(5660300002)(6486002)(7416002)(38100700002)(82960400001)(316002)(9686003)(6512007)(33716001)(85182001)(186003)(26005)(6916009)(6506007)(508600001)(53546011)(6666004)(54906003)(86362001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZTZmZG02R2ZCamptZnBvd3QwcTBjWWJTak9oQWZGN3Q0aHFZdUFCZ3dLT1Fq?=
 =?utf-8?B?VTFwNDNybGRIWjgrWjJ5cisvNDRSMkdLelZoc2VJdC9lRE9sdHdBNzE3bVJk?=
 =?utf-8?B?b0g3NzNGZ2k1S2VRRFNWL1NHS1JaWDhjc3BXendNQTgycHVkUldwaEFNOXpL?=
 =?utf-8?B?LzBzSjZwZkEvVDVSNGFrSXJtMlFMRFF5ZmlMSkhteXZSdWJMeVBNQ2N2a0Fl?=
 =?utf-8?B?K2YxREZmOVNhVmdjSUJsUksxN1BQOHlBTjlVUnlvVjc2ODJFcnlCVFlCZVFv?=
 =?utf-8?B?eFVwMDJpZzZ5aWtxendselRiazRvM1JKc0dmWC9ldnFXc3pwWFk2NFlWdnlw?=
 =?utf-8?B?WFJPRnc0MXhMbU5GUDRyc0l1WU5XSlpORVhUR0ZYVzFxVFM4RnBCQ0p2NVNP?=
 =?utf-8?B?SEVJVHZRQ0orZzFybHNZQmNPUkRKSlR4ZVlLQXJmb0pwNWR0QUhtTVcreWZt?=
 =?utf-8?B?ZUROb2NONENJQlNJZXRheUhFRm00NklnR2w5NGdCR3dYL05OclZIdVJJOHJY?=
 =?utf-8?B?dXQ5cVVSbm5mOWVvMVBMOTlscUt1L0hjWWE3R1BYUWVaWEsrVHhJKy9Xc2Z3?=
 =?utf-8?B?SGpkQlJPazF5MS9KWDFKcm81RzhlZFV2YnpOYVlReStyLzFhSUIwaWFnTTNI?=
 =?utf-8?B?aUx6QTZUNkhVT2VDV3BBRExoOW9yZEQrREFJS1piVHQvaVNTeVRBM0dZQXdZ?=
 =?utf-8?B?RHhlUjBGS0hmbXE2ZWlEc016eCtCWHBQZEUzK204bThZa0hJVEowcTJ2S3Bk?=
 =?utf-8?B?OWEwWEtFbU85bVFXbVRyVVVRWFFQUEZHcUJoS3h1ZGlJWlFyNDhYamRYaVRL?=
 =?utf-8?B?YzlzUFZQenVuWTM5Q0VwYjYvT0k3V3hsNG15VHplSDFYa09IUXFJeDBqSVQr?=
 =?utf-8?B?a2dqV3JCb25PMnVXelBIemQxRFA5MzduUU1CT3BUdnZJREJrSlFHTGVZSFp2?=
 =?utf-8?B?dnVIdTRXTWtKd2o2UnkvWW5rYjlTZlJEMFNYbXpYY3NWdXY2Mk5IUUVxWHFU?=
 =?utf-8?B?N1M0Y1cyUGRQUkw4VHNneHQrZXhuSXkzQ3M0cjUxL2kySitVSUFPalBmc2lh?=
 =?utf-8?B?MjBzaDdGdWFCL1ZVMGlpMVd1ckdiUjJoT29oeW5TRFEvdEovNGMrNGlOTUVZ?=
 =?utf-8?B?bDdiZG11RmdwczJoUXYzZ3VFTExDRnZVdmNYNFp1elZtRXF4azRKeFRjNVI1?=
 =?utf-8?B?OTNycVFtZ0NDbUpjK0U5eEZIQXVKMGtRZHhtcXBLbUNZd3ZscmxTMWR2aVRN?=
 =?utf-8?B?WnlTcTFER2UrVjhGcjZRcEptQTF6NXpQY1dmRU1iMkVzbk9QSUwrSnRaa1Mw?=
 =?utf-8?B?cVQ1T2orUEl4N2VsOE53aTdObVU3YksyN0wzUEpJS2tvMVdIalVQMlhISWtI?=
 =?utf-8?B?VnNMeS9xdlJyQmpaaFJUYzBvTmsyb1Z2Q3NSNEFNS215aWtlOFc2NDEvM0VG?=
 =?utf-8?B?NGpzMmtvYWE4UFdybHpJSGJHVEZZMlQrL1ZWOE5aM0tlSkphZWRLeXRjcFVt?=
 =?utf-8?B?MFN5SkVqNXBnUTJ6bXJ0dTZEcG5jdDlReklLV1lTeG9HaCt1ejFIRzB5OUxP?=
 =?utf-8?B?Z05ZdWtGbmpSdkdqREJick8zb1AzVnIrUTBSNnpPSGRmdHN4NzBzcXU4WEt3?=
 =?utf-8?B?bVJpeE1BaWlKOXBSR2h1cHQ0V3hRaFhOZkhiSHRSOXlOSDd4VzRJbWdydWpp?=
 =?utf-8?B?WnNuaHFadE9vNGVsNWpVVVlCUk11dVg1QzZuNlhPUkoxa0NadHBob0I2T1lR?=
 =?utf-8?B?eko1eVVOMHlmUXQ0cGhldnN0L04zZm1GWHpzSUVjNElYL0kwT2wxSDlWQ2p0?=
 =?utf-8?B?MTNZZmlxM09GcXZVdzk3aGNIcmtTcEUvZGJMRHFqRnZUaGprMjVmZFBSWVRW?=
 =?utf-8?B?cDUvRjFXQk1hSy80MFFBU0JjYzBvQmpQVjc0aWpjcEtINVgxaEpqNENZQXhV?=
 =?utf-8?B?M2cyMk9yU3NwaFJIelRFOEVaOVZHZ00vbnFSNEltd2YyVjcydGRIblpjbHJK?=
 =?utf-8?B?OEJyMmJQUG55Vk41cDJ0UVZuTUprVm5mU1NxMk9FQmRvbmdwMGR0Q2JyRmtT?=
 =?utf-8?B?dXcxNTVHdjUyNURuYmMwM05tSnhvcVZZUWpuM2Vvd1FTcUlJdHJreFJsSzN1?=
 =?utf-8?B?UjFFRC9WS1NWck8wYzA2dGV5Q3lndWgyVzhLdUNQUEI5VlJNc3AzK1dYSlVy?=
 =?utf-8?Q?ZaFR/+K/GP3FcifeqFyOGnw=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6fa1dec0-9286-45f8-3464-08d9e7d80a2e
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Feb 2022 12:15:32.1262
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cQRhv+7Wt3uCPRVWaDHIhzilw98D0itJGpfYZFPEfCjYIEXMndFmdVwq/gvLAXRAahew2+lcz3REu0gHq4wesw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB3925
X-OriginatorOrg: citrix.com

On Fri, Feb 04, 2022 at 11:37:50AM +0000, Oleksandr Andrushchenko wrote:
> 
> 
> On 04.02.22 13:13, Roger Pau Monné wrote:
> > On Fri, Feb 04, 2022 at 11:49:18AM +0100, Jan Beulich wrote:
> >> On 04.02.2022 11:12, Oleksandr Andrushchenko wrote:
> >>> On 04.02.22 11:15, Jan Beulich wrote:
> >>>> On 04.02.2022 09:58, Oleksandr Andrushchenko wrote:
> >>>>> On 04.02.22 09:52, Jan Beulich wrote:
> >>>>>> On 04.02.2022 07:34, Oleksandr Andrushchenko wrote:
> >>>>>>> @@ -285,6 +286,12 @@ static int modify_bars(const struct pci_dev *pdev, uint16_t cmd, bool rom_only)
> >>>>>>>                     continue;
> >>>>>>>             }
> >>>>>>>     
> >>>>>>> +        spin_lock(&tmp->vpci_lock);
> >>>>>>> +        if ( !tmp->vpci )
> >>>>>>> +        {
> >>>>>>> +            spin_unlock(&tmp->vpci_lock);
> >>>>>>> +            continue;
> >>>>>>> +        }
> >>>>>>>             for ( i = 0; i < ARRAY_SIZE(tmp->vpci->header.bars); i++ )
> >>>>>>>             {
> >>>>>>>                 const struct vpci_bar *bar = &tmp->vpci->header.bars[i];
> >>>>>>> @@ -303,12 +310,14 @@ static int modify_bars(const struct pci_dev *pdev, uint16_t cmd, bool rom_only)
> >>>>>>>                 rc = rangeset_remove_range(mem, start, end);
> >>>>>>>                 if ( rc )
> >>>>>>>                 {
> >>>>>>> +                spin_unlock(&tmp->vpci_lock);
> >>>>>>>                     printk(XENLOG_G_WARNING "Failed to remove [%lx, %lx]: %d\n",
> >>>>>>>                            start, end, rc);
> >>>>>>>                     rangeset_destroy(mem);
> >>>>>>>                     return rc;
> >>>>>>>                 }
> >>>>>>>             }
> >>>>>>> +        spin_unlock(&tmp->vpci_lock);
> >>>>>>>         }
> >>>>>> At the first glance this simply looks like another unjustified (in the
> >>>>>> description) change, as you're not converting anything here but you
> >>>>>> actually add locking (and I realize this was there before, so I'm sorry
> >>>>>> for not pointing this out earlier).
> >>>>> Well, I thought that the description already has "...the lock can be
> >>>>> used (and in a few cases is used right away) to check whether vpci
> >>>>> is present" and this is enough for such uses as here.
> >>>>>>     But then I wonder whether you
> >>>>>> actually tested this, since I can't help getting the impression that
> >>>>>> you're introducing a live-lock: The function is called from cmd_write()
> >>>>>> and rom_write(), which in turn are called out of vpci_write(). Yet that
> >>>>>> function already holds the lock, and the lock is not (currently)
> >>>>>> recursive. (For the 3rd caller of the function - init_bars() - otoh
> >>>>>> the locking looks to be entirely unnecessary.)
> >>>>> Well, you are correct: if tmp != pdev then it is correct to acquire
> >>>>> the lock. But if tmp == pdev and rom_only == true
> >>>>> then we'll deadlock.
> >>>>>
> >>>>> It seems we need to have the locking conditional, e.g. only lock
> >>>>> if tmp != pdev
> >>>> Which will address the live-lock, but introduce ABBA deadlock potential
> >>>> between the two locks.
> >>> I am not sure I can suggest a better solution here
> >>> @Roger, @Jan, could you please help here?
> >> Well, first of all I'd like to mention that while it may have been okay to
> >> not hold pcidevs_lock here for Dom0, it surely needs acquiring when dealing
> >> with DomU-s' lists of PCI devices. The requirement really applies to the
> >> other use of for_each_pdev() as well (in vpci_dump_msi()), except that
> >> there it probably wants to be a try-lock.
> >>
> >> Next I'd like to point out that here we have the still pending issue of
> >> how to deal with hidden devices, which Dom0 can access. See my RFC patch
> >> "vPCI: account for hidden devices in modify_bars()". Whatever the solution
> >> here, I think it wants to at least account for the extra need there.
> > Yes, sorry, I should take care of that.
> >
> >> Now it is quite clear that pcidevs_lock isn't going to help with avoiding
> >> the deadlock, as it's imo not an option at all to acquire that lock
> >> everywhere else you access ->vpci (or else the vpci lock itself would be
> >> pointless). But a per-domain auxiliary r/w lock may help: Other paths
> >> would acquire it in read mode, and here you'd acquire it in write mode (in
> >> the former case around the vpci lock, while in the latter case there may
> >> then not be any need to acquire the individual vpci locks at all). FTAOD:
> >> I haven't fully thought through all implications (and hence whether this is
> >> viable in the first place); I expect you will, documenting what you've
> >> found in the resulting patch description. Of course the double lock
> >> acquire/release would then likely want hiding in helper functions.
> > I've been also thinking about this, and whether it's really worth to
> > have a per-device lock rather than a per-domain one that protects all
> > vpci regions of the devices assigned to the domain.
> >
> > The OS is likely to serialize accesses to the PCI config space anyway,
> > and the only place I could see a benefit of having per-device locks is
> > in the handling of MSI-X tables, as the handling of the mask bit is
> > likely very performance sensitive, so adding a per-domain lock there
> > could be a bottleneck.
> >
> > We could alternatively do a per-domain rwlock for vpci and special case
> > the MSI-X area to also have a per-device specific lock. At which point
> > it becomes fairly similar to what you propose.
> I need a decision.
> Please.

I'm afraid that's up to you. I cannot assure that any of the proposed
options will actually be viable until someone attempts to implement
them. I wouldn't want to impose a solution to you because I cannot
guarantee it will work or result in better code than other options.

I think there are two options:

1. Set a lock ordering for double locking (based on the memory address
   of the lock for example).

2. Introduce a per-domain rwlock that protects all of the devices
   assigned to a domain.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Feb 04 12:37:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 12:37:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265469.458841 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFxpy-0005ot-No; Fri, 04 Feb 2022 12:37:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265469.458841; Fri, 04 Feb 2022 12:37:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFxpy-0005om-KO; Fri, 04 Feb 2022 12:37:14 +0000
Received: by outflank-mailman (input) for mailman id 265469;
 Fri, 04 Feb 2022 12:37:14 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=u+82=ST=epam.com=prvs=4034f0a382=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nFxpx-0005og-LQ
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 12:37:14 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2b543b40-85b7-11ec-8f75-fffcc8bd4f1a;
 Fri, 04 Feb 2022 13:37:10 +0100 (CET)
Received: from pps.filterd (m0174679.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 214C381w006851;
 Fri, 4 Feb 2022 12:37:07 GMT
Received: from eur03-ve1-obe.outbound.protection.outlook.com
 (mail-ve1eur03lp2056.outbound.protection.outlook.com [104.47.9.56])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e11uerjkb-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 04 Feb 2022 12:37:06 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AS8PR03MB7842.eurprd03.prod.outlook.com (2603:10a6:20b:341::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.20; Fri, 4 Feb
 2022 12:37:02 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6%3]) with mapi id 15.20.4951.014; Fri, 4 Feb 2022
 12:37:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2b543b40-85b7-11ec-8f75-fffcc8bd4f1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=GmE7Skz90lB5JXm5ZGpJEBsr+rEWqJwcB7fqsnwHvHDwxGMuSfxKGc+YXAe8CNLHBiMQej54eg4rucO1EcDIkDmzvYIbsF6vf0a6+deD5+zOT0VnoA/oaF4UaUimkTIsy/giQKxeQYFOPF8Qhl1GcJ1sTUeNzBH2igIDF1BoHTB5yGwWRBSl5rOMclCQkreJnrB9bV+7kJTCQaYPkqoB0EQnwxVwL5+PEnF67I60QivTDCfyqTTUtHE8p1VIPVV133ewNUcPlkuS7gKfdLYlz44sDzSf3vmfysexnBrbc9QfplGCGwnblyu5De32P7NrPDya5jNDfyW39WBvA+b/JQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=kXFWFp0WVV4MaLKwCh2i5LbxTT+ekPvTVyjxL00enwk=;
 b=Daj2WlPgHUnEXqe3hHLRNuuMDPs8B061XA/2doY5CbafE45E1m4XKRcgX7wJ47XQM8dg9H5BTvGch+HJT3kjJ4F4dRO5zeuhlF5vApdRKIF8AiRVlqghvQdGOp4GhQXxXm9aMIUSPbFyBGyZSOCU87NNTq/VSI/WNbIFNTxDSd83HFp27qZBUcuYCFFu0HgF8zOzqIKWz/8I3mCNeiUwRSYZ1VfyAm6pBmq7o3bXINYejrYmgiOVSJHnJGDFpoyvzk0R/l7aR+KhIFkQJesg0+YNxM1RAQmqO7o3t65Vq+aDOjA67z7icrT0GmRJaElGguktX2w5Erdon0xkarVHsA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=kXFWFp0WVV4MaLKwCh2i5LbxTT+ekPvTVyjxL00enwk=;
 b=bTkQ6OiaeAQHxnlZE4cJdmsovUz3AISi6HpHreOdh3lZSL4WpqdC5ov0+54vAgCqVt++eVGkfx0GC4MP25kSr8DXJCTB1yIlhQfQfrsRhX4aUNwNq13QtglEUjKNyaJDFabu4iM2ZuiVSvm/hB8wifCdQd6O5a2k1JohaSwUPyRp17HqmPmfO3s1AokNAViE5jHvYiqHRyvbuIiw8yJG1Y0uR0ambh7ZR3NL19KArxDRl3hhpx5OXjTHYc1R7qo/TT+bbtfjzk4ZEKHXXaCJ5N3szdiX1Qd62eBf/hLmvC3BBIC/J29v2oAO1JIIVuThDp35nJ9B6VY5SROqKOomRg==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>,
        =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?=
	<roger.pau@citrix.com>
CC: "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Thread-Topic: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Thread-Index: 
 AQHYGZFc/MnzQOjwVEeBBUHLSW0md6yDBUkAgAASSACAAATYAIAAD/WAgAAKNgCAAAbfgIAABnuAgAAQvgA=
Date: Fri, 4 Feb 2022 12:37:01 +0000
Message-ID: <7e3562b5-fc67-f213-e872-f211450d9e2e@epam.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-4-andr2000@gmail.com>
 <7209889d-8f17-61cc-72a4-97f6dbc1d54d@suse.com>
 <2cf022f8-b000-11b7-c6b9-90a56bc6e2ea@epam.com>
 <04726915-f39f-9019-436e-4399533c9fc3@suse.com>
 <9ed3f4ac-0a2d-ed45-9872-7c3f356a469e@epam.com>
 <c3a99712-cf7c-37da-aac1-f2ee00e6d53b@suse.com>
 <Yf0KcVD8W05A4fbB@Air-de-Roger>
 <1ed0e342-16cd-2f16-c05c-186667a22762@suse.com>
In-Reply-To: <1ed0e342-16cd-2f16-c05c-186667a22762@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 454bb995-e176-4d38-745f-08d9e7db0b2c
x-ms-traffictypediagnostic: AS8PR03MB7842:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AS8PR03MB7842846D5AB8339742832E6CE7299@AS8PR03MB7842.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8273;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 BbB5J9WBM2LLbv25T3w5WECHk3bXXVggxPYArsGYlb2LsPB4T5YSDK+fhQpwMPC0DjSpydD48RfP4tjJNPbUCUD8Pza81uu1eH+QmXsV3HVg1pVEu5d4Z4U8drUaGGB1+ySAlYfuaM2ms7gu/KAC0OZVCcH1Gajm8d5wZe6pBlUwhSu3zM9AzMXa2iMwVZbw171mBb3Y/1rzAHF7l+WJniVWPpk8tEN9E64HJpyQn2lwFHvLwdIOCPFpElYvYOqdKyeZ/oPYMMdlUPpwjm+0AeQ6QCbFEmR3dnnxSEKnAGmEw+PS4zlgfqCyaMcKABvtlXUAyF4h3cSRAO7ejyVxyMz/Iy76WYIJCE73WpEjElmQP3YD+jrpVDgHY7lzE0JdUuRfEQH1yGJeqb8FJaQBLj+OQNIvtA/6im2xJxHTi8TLo2WrIoEG/w8zsBhqmio7FcxALpbV/N3hZYBdhFDSRCFW8o7F3Cm5/HV4uGescmHc4a93DlSm6qs1NdhuSsjgTcU1bsX65tw+21XcP/5ZIEFxyO526du/le+K93rJJ04UsPjcOZCAVnhrxzbBQbtX81FBHwvBfulLrwAxN7JqMuo2fDOFgrIh6DumJvzmZR2/BrTt49IBd3OqTGQZiWFJ6iGsGsVQKe58zDgHKhwgF0i029YwG123FW0HYKcNPdvjB8U/GDpygVfJAv016NkJl2AifWZ0wTQDnb6VDTgWG8FiJzOHrijvvzAsVFXNiBseHFclvzy6qQjO36rhdM5e
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66946007)(64756008)(2616005)(6486002)(38070700005)(38100700002)(76116006)(66446008)(66556008)(8936002)(91956017)(8676002)(122000001)(7416002)(66476007)(2906002)(4326008)(31696002)(508600001)(71200400001)(83380400001)(53546011)(36756003)(86362001)(5660300002)(110136005)(186003)(316002)(26005)(54906003)(31686004)(6512007)(6506007)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?NnBQeSsvTkM1U08zbGNwRVJvbTVqNklGNTNTNTdML0Q3L0YyT1JzZXFpcGxS?=
 =?utf-8?B?SVhGZEliSGsxWUdmYmo4ektLd1RiQllpTExsVTVGSTh5Uyt3NGhvL2h1eG1H?=
 =?utf-8?B?OUx0YndCM25tMEZqc0VIYWhrRDRrdGxRdmhEK3pCdFA1QmpjR044bFg0cUN0?=
 =?utf-8?B?dENpRHllWHhYenhDUFRvNm5aWmV6ZnFGYkhTM2JVdlRFazc1NExZZnYvalFy?=
 =?utf-8?B?Vjh6V0FVSEM4MDREUlVrcEF5MFJmTjZIcW1FR2RKY3VBSEEvUzk5b2JQaUtu?=
 =?utf-8?B?T0tNdlVoY1hJdjEyT1RGdTdTR28wV05GMm5NVW1xWnMxUjZkR0pud1dSNzRF?=
 =?utf-8?B?S2U3cVVCNFoxc3Rld3doekh3WjdRQnNEZnhKK0ZHU3pMc1RZbzlSbDZuK2RK?=
 =?utf-8?B?eGQrTEZBTlBWRFZNM1BNQXJVZ2cxTVE1aTNrVWxBZVRadGoycXVMVk8rdTd1?=
 =?utf-8?B?Qk1Lc013aWd4eFVEN0V1SEtNNVlUWnVZNDdiQlRUY2RiRC8ydVBLNVNwd01F?=
 =?utf-8?B?V1U2UU9BTy9DaVdva0Q0V2JBakhjM3o4K0dVQmh5ZXJLNGxUeXJZRENWZms3?=
 =?utf-8?B?TFlRRE9yWFhBbm40WnRkcDFwNVg3UnlDVlczZE9VcnNqZS9JYng4UG1tTTFH?=
 =?utf-8?B?bjVYKzhqWHBSUU4yWnQvVDNrbWJra3VscTJVRktOM2JZb0RHZm9pWVdGdEhK?=
 =?utf-8?B?LzgrMTVxckpBYU02emNVVzI3dWRtb3dROVpESjBObklYQ0Q5UEdmaUtmVmlu?=
 =?utf-8?B?Z2trdGM4Sjk4MkNwNDliaCtheEVoWng5T2h5dnh3TE9Jc1N4L2dZRXJSUHJk?=
 =?utf-8?B?UkorMUU3NFl0QUN3MnVmQUN4Ukg3OEpIVU1lWUZrdlNyN2JKVlJPWlNuOFE5?=
 =?utf-8?B?Qy9ZbmozcDV5RlJia01RMmFWWUVLUWpNK3pCb0tRaVVXcTE5RGx6MUdRZjlp?=
 =?utf-8?B?ZzJ6T3pNeFN3WjNHWkc4ZHhNSHMrcnV3ZGdMNlVGUDBuNVhOZlgyczQ5QUM0?=
 =?utf-8?B?MjZVeEdYNUdCTk9BWVp6U2c0YWRGOUkwMm92NGh2RHlBaWF2VEMvbUg4TFA0?=
 =?utf-8?B?NzZFUnFCU0xNYXd1SU9pYjNJQ1Zwb1FLNjExMktRaExtVFZOaE5RM01qd2Jx?=
 =?utf-8?B?ZG1HU0Fqdk1Sa1dNeUJ6TWhhZUVWaG1lWWp3TWIySnEwQXZmd2twcHB6RUR4?=
 =?utf-8?B?NE0yc05DMStmSG5EV0lhV0dPK1A5NVBnbXJFWm5samV1Uk11QzdRUTNmeHdG?=
 =?utf-8?B?NzJVNDByOFZ4eVVVUmhZamhaL0NHeFhVUDlGUW52ekRuVEM3VWk3WUdLY0xT?=
 =?utf-8?B?d25yY1JtSFFieHZVNW8wV1VXeVM5dTRudmEwbWNJUURwWjRKdDNJd2dHejJZ?=
 =?utf-8?B?cmE0dWdPVW5SVkQyRC9UWHd0VlBqWkFXZHNCeGFvVnF6Wi8rWFd2NFp1RUEz?=
 =?utf-8?B?d1RSRU41NVV1dVkrMmphNzgzSjcwMkx1KzdCS0c0MUdLZ0lqc1BFVXNBUi9y?=
 =?utf-8?B?S2w2U2dzRlhGNjJ3SkpDbWFmTnJtMmcvOVRYVVRkcVcvNFg3VXF0SXV3SjRa?=
 =?utf-8?B?VDlSR2VPVlIwTU15anpYNEppQjIrSmNRTDY2cEhEWG5DV0gxdUVuVFFpaEcy?=
 =?utf-8?B?a3gxRnhKZEVOSUllNFBFeU5xaEdGTEs2WjlRZWV2TkRMR0xISnhaU1k2TUVa?=
 =?utf-8?B?QjdPNXl3dDdVZ2ovY3pJcU4reHZrT3gvSjFRVGRlOGpUUU1mTHU0UnVJVTdQ?=
 =?utf-8?B?QTBZcVVzTjA1emdKbXRQRjg2RC9jUGx6RUdWSERkdXhpMmtDSVBQMFFYVExC?=
 =?utf-8?B?RGhRNmlJS2RTMmZHN1hVUG52ZXZmMWIwNTc4Q2pUeXJmeGtMNXYwMjJrTGF0?=
 =?utf-8?B?V2o0L09iRjNlazJuRGZKZXBoaVVSUUk5SWhFZXZtajRvK3V4aE9qNnVQanBJ?=
 =?utf-8?B?UFp3UllkVVJIazlzS1RBL2VVeFRZem9YWFRVUWQ5M2ttK3MzWUsyUDRnaHNB?=
 =?utf-8?B?MEZ5M00weTRqdWQxbXEvQzBOT0V1TTF6MGJ1enlUSlZUZFQ4ekRUOER4dnJV?=
 =?utf-8?B?SGFzdE44SGUxbTlJL1d4Zkt4d0owNXpzeFJ1b0tSSE1lM2Zia2NqTzdRKzZs?=
 =?utf-8?B?WVZDYllKUmw2alFEbUdsenA4YW1mbmJERVo0MktNTVl2YTBVNTlnZHhDbDk4?=
 =?utf-8?B?Rzd2bWYxS0VoWjA4Y2hZSlZrODduSi9SbXprd0x4TlRrZmlobzJEczZmc2N6?=
 =?utf-8?B?VlVFWkJEYzdyNjNBNjExVTd5Wi9wQkRBYlBvTFBxS3JubHVpcnNseEwrTWZa?=
 =?utf-8?B?UjN1SzVSSHdPc2syeEhERDQvL0RIN00zMjlsemxsWkVwdmNLaTYrQT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <83DE2BD35936AD46BBE564A49AC70F99@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 454bb995-e176-4d38-745f-08d9e7db0b2c
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Feb 2022 12:37:02.0327
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: VxDVUVwbs5Wbr9n94vSw5+EzX5zx7Im8v9MhTaPm56At0jvizIcbLB204Jh7AauAEDX6O6F5ELKb49ztIOsotT8NuZjxubPA1vnXlPDbtXUHQCo2fffgT8AP2qd36rIV
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR03MB7842
X-Proofpoint-ORIG-GUID: iYmfnXQx0dh2Z5NomRcYVb1BydAaBoza
X-Proofpoint-GUID: iYmfnXQx0dh2Z5NomRcYVb1BydAaBoza
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-04_04,2022-02-03_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0
 priorityscore=1501 mlxscore=0 adultscore=0 impostorscore=0 spamscore=0
 lowpriorityscore=0 bulkscore=0 suspectscore=0 mlxlogscore=999 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2202040069

DQoNCk9uIDA0LjAyLjIyIDEzOjM3LCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMDQuMDIuMjAy
MiAxMjoxMywgUm9nZXIgUGF1IE1vbm7DqSB3cm90ZToNCj4+IE9uIEZyaSwgRmViIDA0LCAyMDIy
IGF0IDExOjQ5OjE4QU0gKzAxMDAsIEphbiBCZXVsaWNoIHdyb3RlOg0KPj4+IE9uIDA0LjAyLjIw
MjIgMTE6MTIsIE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4+PiBPbiAwNC4wMi4y
MiAxMToxNSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+Pj4+PiBPbiAwNC4wMi4yMDIyIDA5OjU4LCBP
bGVrc2FuZHIgQW5kcnVzaGNoZW5rbyB3cm90ZToNCj4+Pj4+PiBPbiAwNC4wMi4yMiAwOTo1Miwg
SmFuIEJldWxpY2ggd3JvdGU6DQo+Pj4+Pj4+IE9uIDA0LjAyLjIwMjIgMDc6MzQsIE9sZWtzYW5k
ciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4+Pj4+Pj4gQEAgLTI4NSw2ICsyODYsMTIgQEAgc3Rh
dGljIGludCBtb2RpZnlfYmFycyhjb25zdCBzdHJ1Y3QgcGNpX2RldiAqcGRldiwgdWludDE2X3Qg
Y21kLCBib29sIHJvbV9vbmx5KQ0KPj4+Pj4+Pj4gICAgICAgICAgICAgICAgICAgICBjb250aW51
ZTsNCj4+Pj4+Pj4+ICAgICAgICAgICAgIH0NCj4+Pj4+Pj4+ICAgICANCj4+Pj4+Pj4+ICsgICAg
ICAgIHNwaW5fbG9jaygmdG1wLT52cGNpX2xvY2spOw0KPj4+Pj4+Pj4gKyAgICAgICAgaWYgKCAh
dG1wLT52cGNpICkNCj4+Pj4+Pj4+ICsgICAgICAgIHsNCj4+Pj4+Pj4+ICsgICAgICAgICAgICBz
cGluX3VubG9jaygmdG1wLT52cGNpX2xvY2spOw0KPj4+Pj4+Pj4gKyAgICAgICAgICAgIGNvbnRp
bnVlOw0KPj4+Pj4+Pj4gKyAgICAgICAgfQ0KPj4+Pj4+Pj4gICAgICAgICAgICAgZm9yICggaSA9
IDA7IGkgPCBBUlJBWV9TSVpFKHRtcC0+dnBjaS0+aGVhZGVyLmJhcnMpOyBpKysgKQ0KPj4+Pj4+
Pj4gICAgICAgICAgICAgew0KPj4+Pj4+Pj4gICAgICAgICAgICAgICAgIGNvbnN0IHN0cnVjdCB2
cGNpX2JhciAqYmFyID0gJnRtcC0+dnBjaS0+aGVhZGVyLmJhcnNbaV07DQo+Pj4+Pj4+PiBAQCAt
MzAzLDEyICszMTAsMTQgQEAgc3RhdGljIGludCBtb2RpZnlfYmFycyhjb25zdCBzdHJ1Y3QgcGNp
X2RldiAqcGRldiwgdWludDE2X3QgY21kLCBib29sIHJvbV9vbmx5KQ0KPj4+Pj4+Pj4gICAgICAg
ICAgICAgICAgIHJjID0gcmFuZ2VzZXRfcmVtb3ZlX3JhbmdlKG1lbSwgc3RhcnQsIGVuZCk7DQo+
Pj4+Pj4+PiAgICAgICAgICAgICAgICAgaWYgKCByYyApDQo+Pj4+Pj4+PiAgICAgICAgICAgICAg
ICAgew0KPj4+Pj4+Pj4gKyAgICAgICAgICAgICAgICBzcGluX3VubG9jaygmdG1wLT52cGNpX2xv
Y2spOw0KPj4+Pj4+Pj4gICAgICAgICAgICAgICAgICAgICBwcmludGsoWEVOTE9HX0dfV0FSTklO
RyAiRmFpbGVkIHRvIHJlbW92ZSBbJWx4LCAlbHhdOiAlZFxuIiwNCj4+Pj4+Pj4+ICAgICAgICAg
ICAgICAgICAgICAgICAgICAgIHN0YXJ0LCBlbmQsIHJjKTsNCj4+Pj4+Pj4+ICAgICAgICAgICAg
ICAgICAgICAgcmFuZ2VzZXRfZGVzdHJveShtZW0pOw0KPj4+Pj4+Pj4gICAgICAgICAgICAgICAg
ICAgICByZXR1cm4gcmM7DQo+Pj4+Pj4+PiAgICAgICAgICAgICAgICAgfQ0KPj4+Pj4+Pj4gICAg
ICAgICAgICAgfQ0KPj4+Pj4+Pj4gKyAgICAgICAgc3Bpbl91bmxvY2soJnRtcC0+dnBjaV9sb2Nr
KTsNCj4+Pj4+Pj4+ICAgICAgICAgfQ0KPj4+Pj4+PiBBdCB0aGUgZmlyc3QgZ2xhbmNlIHRoaXMg
c2ltcGx5IGxvb2tzIGxpa2UgYW5vdGhlciB1bmp1c3RpZmllZCAoaW4gdGhlDQo+Pj4+Pj4+IGRl
c2NyaXB0aW9uKSBjaGFuZ2UsIGFzIHlvdSdyZSBub3QgY29udmVydGluZyBhbnl0aGluZyBoZXJl
IGJ1dCB5b3UNCj4+Pj4+Pj4gYWN0dWFsbHkgYWRkIGxvY2tpbmcgKGFuZCBJIHJlYWxpemUgdGhp
cyB3YXMgdGhlcmUgYmVmb3JlLCBzbyBJJ20gc29ycnkNCj4+Pj4+Pj4gZm9yIG5vdCBwb2ludGlu
ZyB0aGlzIG91dCBlYXJsaWVyKS4NCj4+Pj4+PiBXZWxsLCBJIHRob3VnaHQgdGhhdCB0aGUgZGVz
Y3JpcHRpb24gYWxyZWFkeSBoYXMgIi4uLnRoZSBsb2NrIGNhbiBiZQ0KPj4+Pj4+IHVzZWQgKGFu
ZCBpbiBhIGZldyBjYXNlcyBpcyB1c2VkIHJpZ2h0IGF3YXkpIHRvIGNoZWNrIHdoZXRoZXIgdnBj
aQ0KPj4+Pj4+IGlzIHByZXNlbnQiIGFuZCB0aGlzIGlzIGVub3VnaCBmb3Igc3VjaCB1c2VzIGFz
IGhlcmUuDQo+Pj4+Pj4+ICAgICBCdXQgdGhlbiBJIHdvbmRlciB3aGV0aGVyIHlvdQ0KPj4+Pj4+
PiBhY3R1YWxseSB0ZXN0ZWQgdGhpcywgc2luY2UgSSBjYW4ndCBoZWxwIGdldHRpbmcgdGhlIGlt
cHJlc3Npb24gdGhhdA0KPj4+Pj4+PiB5b3UncmUgaW50cm9kdWNpbmcgYSBsaXZlLWxvY2s6IFRo
ZSBmdW5jdGlvbiBpcyBjYWxsZWQgZnJvbSBjbWRfd3JpdGUoKQ0KPj4+Pj4+PiBhbmQgcm9tX3dy
aXRlKCksIHdoaWNoIGluIHR1cm4gYXJlIGNhbGxlZCBvdXQgb2YgdnBjaV93cml0ZSgpLiBZZXQg
dGhhdA0KPj4+Pj4+PiBmdW5jdGlvbiBhbHJlYWR5IGhvbGRzIHRoZSBsb2NrLCBhbmQgdGhlIGxv
Y2sgaXMgbm90IChjdXJyZW50bHkpDQo+Pj4+Pj4+IHJlY3Vyc2l2ZS4gKEZvciB0aGUgM3JkIGNh
bGxlciBvZiB0aGUgZnVuY3Rpb24gLSBpbml0X2JhcnMoKSAtIG90b2gNCj4+Pj4+Pj4gdGhlIGxv
Y2tpbmcgbG9va3MgdG8gYmUgZW50aXJlbHkgdW5uZWNlc3NhcnkuKQ0KPj4+Pj4+IFdlbGwsIHlv
dSBhcmUgY29ycmVjdDogaWYgdG1wICE9IHBkZXYgdGhlbiBpdCBpcyBjb3JyZWN0IHRvIGFjcXVp
cmUNCj4+Pj4+PiB0aGUgbG9jay4gQnV0IGlmIHRtcCA9PSBwZGV2IGFuZCByb21fb25seSA9PSB0
cnVlDQo+Pj4+Pj4gdGhlbiB3ZSdsbCBkZWFkbG9jay4NCj4+Pj4+Pg0KPj4+Pj4+IEl0IHNlZW1z
IHdlIG5lZWQgdG8gaGF2ZSB0aGUgbG9ja2luZyBjb25kaXRpb25hbCwgZS5nLiBvbmx5IGxvY2sN
Cj4+Pj4+PiBpZiB0bXAgIT0gcGRldg0KPj4+Pj4gV2hpY2ggd2lsbCBhZGRyZXNzIHRoZSBsaXZl
LWxvY2ssIGJ1dCBpbnRyb2R1Y2UgQUJCQSBkZWFkbG9jayBwb3RlbnRpYWwNCj4+Pj4+IGJldHdl
ZW4gdGhlIHR3byBsb2Nrcy4NCj4+Pj4gSSBhbSBub3Qgc3VyZSBJIGNhbiBzdWdnZXN0IGEgYmV0
dGVyIHNvbHV0aW9uIGhlcmUNCj4+Pj4gQFJvZ2VyLCBASmFuLCBjb3VsZCB5b3UgcGxlYXNlIGhl
bHAgaGVyZT8NCj4+PiBXZWxsLCBmaXJzdCBvZiBhbGwgSSdkIGxpa2UgdG8gbWVudGlvbiB0aGF0
IHdoaWxlIGl0IG1heSBoYXZlIGJlZW4gb2theSB0bw0KPj4+IG5vdCBob2xkIHBjaWRldnNfbG9j
ayBoZXJlIGZvciBEb20wLCBpdCBzdXJlbHkgbmVlZHMgYWNxdWlyaW5nIHdoZW4gZGVhbGluZw0K
Pj4+IHdpdGggRG9tVS1zJyBsaXN0cyBvZiBQQ0kgZGV2aWNlcy4gVGhlIHJlcXVpcmVtZW50IHJl
YWxseSBhcHBsaWVzIHRvIHRoZQ0KPj4+IG90aGVyIHVzZSBvZiBmb3JfZWFjaF9wZGV2KCkgYXMg
d2VsbCAoaW4gdnBjaV9kdW1wX21zaSgpKSwgZXhjZXB0IHRoYXQNCj4+PiB0aGVyZSBpdCBwcm9i
YWJseSB3YW50cyB0byBiZSBhIHRyeS1sb2NrLg0KPj4+DQo+Pj4gTmV4dCBJJ2QgbGlrZSB0byBw
b2ludCBvdXQgdGhhdCBoZXJlIHdlIGhhdmUgdGhlIHN0aWxsIHBlbmRpbmcgaXNzdWUgb2YNCj4+
PiBob3cgdG8gZGVhbCB3aXRoIGhpZGRlbiBkZXZpY2VzLCB3aGljaCBEb20wIGNhbiBhY2Nlc3Mu
IFNlZSBteSBSRkMgcGF0Y2gNCj4+PiAidlBDSTogYWNjb3VudCBmb3IgaGlkZGVuIGRldmljZXMg
aW4gbW9kaWZ5X2JhcnMoKSIuIFdoYXRldmVyIHRoZSBzb2x1dGlvbg0KPj4+IGhlcmUsIEkgdGhp
bmsgaXQgd2FudHMgdG8gYXQgbGVhc3QgYWNjb3VudCBmb3IgdGhlIGV4dHJhIG5lZWQgdGhlcmUu
DQo+PiBZZXMsIHNvcnJ5LCBJIHNob3VsZCB0YWtlIGNhcmUgb2YgdGhhdC4NCj4+DQo+Pj4gTm93
IGl0IGlzIHF1aXRlIGNsZWFyIHRoYXQgcGNpZGV2c19sb2NrIGlzbid0IGdvaW5nIHRvIGhlbHAg
d2l0aCBhdm9pZGluZw0KPj4+IHRoZSBkZWFkbG9jaywgYXMgaXQncyBpbW8gbm90IGFuIG9wdGlv
biBhdCBhbGwgdG8gYWNxdWlyZSB0aGF0IGxvY2sNCj4+PiBldmVyeXdoZXJlIGVsc2UgeW91IGFj
Y2VzcyAtPnZwY2kgKG9yIGVsc2UgdGhlIHZwY2kgbG9jayBpdHNlbGYgd291bGQgYmUNCj4+PiBw
b2ludGxlc3MpLiBCdXQgYSBwZXItZG9tYWluIGF1eGlsaWFyeSByL3cgbG9jayBtYXkgaGVscDog
T3RoZXIgcGF0aHMNCj4+PiB3b3VsZCBhY3F1aXJlIGl0IGluIHJlYWQgbW9kZSwgYW5kIGhlcmUg
eW91J2QgYWNxdWlyZSBpdCBpbiB3cml0ZSBtb2RlIChpbg0KPj4+IHRoZSBmb3JtZXIgY2FzZSBh
cm91bmQgdGhlIHZwY2kgbG9jaywgd2hpbGUgaW4gdGhlIGxhdHRlciBjYXNlIHRoZXJlIG1heQ0K
Pj4+IHRoZW4gbm90IGJlIGFueSBuZWVkIHRvIGFjcXVpcmUgdGhlIGluZGl2aWR1YWwgdnBjaSBs
b2NrcyBhdCBhbGwpLiBGVEFPRDoNCj4+PiBJIGhhdmVuJ3QgZnVsbHkgdGhvdWdodCB0aHJvdWdo
IGFsbCBpbXBsaWNhdGlvbnMgKGFuZCBoZW5jZSB3aGV0aGVyIHRoaXMgaXMNCj4+PiB2aWFibGUg
aW4gdGhlIGZpcnN0IHBsYWNlKTsgSSBleHBlY3QgeW91IHdpbGwsIGRvY3VtZW50aW5nIHdoYXQg
eW91J3ZlDQo+Pj4gZm91bmQgaW4gdGhlIHJlc3VsdGluZyBwYXRjaCBkZXNjcmlwdGlvbi4gT2Yg
Y291cnNlIHRoZSBkb3VibGUgbG9jaw0KPj4+IGFjcXVpcmUvcmVsZWFzZSB3b3VsZCB0aGVuIGxp
a2VseSB3YW50IGhpZGluZyBpbiBoZWxwZXIgZnVuY3Rpb25zLg0KPj4gSSd2ZSBiZWVuIGFsc28g
dGhpbmtpbmcgYWJvdXQgdGhpcywgYW5kIHdoZXRoZXIgaXQncyByZWFsbHkgd29ydGggdG8NCj4+
IGhhdmUgYSBwZXItZGV2aWNlIGxvY2sgcmF0aGVyIHRoYW4gYSBwZXItZG9tYWluIG9uZSB0aGF0
IHByb3RlY3RzIGFsbA0KPj4gdnBjaSByZWdpb25zIG9mIHRoZSBkZXZpY2VzIGFzc2lnbmVkIHRv
IHRoZSBkb21haW4uDQo+Pg0KPj4gVGhlIE9TIGlzIGxpa2VseSB0byBzZXJpYWxpemUgYWNjZXNz
ZXMgdG8gdGhlIFBDSSBjb25maWcgc3BhY2UgYW55d2F5LA0KPj4gYW5kIHRoZSBvbmx5IHBsYWNl
IEkgY291bGQgc2VlIGEgYmVuZWZpdCBvZiBoYXZpbmcgcGVyLWRldmljZSBsb2NrcyBpcw0KPj4g
aW4gdGhlIGhhbmRsaW5nIG9mIE1TSS1YIHRhYmxlcywgYXMgdGhlIGhhbmRsaW5nIG9mIHRoZSBt
YXNrIGJpdCBpcw0KPj4gbGlrZWx5IHZlcnkgcGVyZm9ybWFuY2Ugc2Vuc2l0aXZlLCBzbyBhZGRp
bmcgYSBwZXItZG9tYWluIGxvY2sgdGhlcmUNCj4+IGNvdWxkIGJlIGEgYm90dGxlbmVjay4NCj4g
SG1tLCB3aXRoIG1ldGhvZCAxIGFjY2Vzc2VzIHNlcmlhbGl6aW5nIGdsb2JhbGx5IGlzIGJhc2lj
YWxseQ0KPiB1bmF2b2lkYWJsZSwgYnV0IHdpdGggTU1DRkcgSSBzZWUgbm8gcmVhc29uIHdoeSBP
U2VzIG1heSBub3QgKG1vdmUNCj4gdG8pIHBlcm1pdCh0aW5nKSBwYXJhbGxlbCBhY2Nlc3Nlcywg
d2l0aCBzZXJpYWxpemF0aW9uIHBlcmhhcHMgZG9uZQ0KPiBvbmx5IGF0IGRldmljZSBsZXZlbC4g
U2VlIG91ciBvd24gcGNpX2NvbmZpZ19sb2NrLCB3aGljaCBhcHBsaWVzIHRvDQo+IG9ubHkgbWV0
aG9kIDEgYWNjZXNzZXM7IHdlIGRvbid0IGxvb2sgdG8gYmUgc2VyaWFsaXppbmcgTU1DRkcNCj4g
YWNjZXNzZXMgYXQgYWxsLg0KPg0KPj4gV2UgY291bGQgYWx0ZXJuYXRpdmVseSBkbyBhIHBlci1k
b21haW4gcndsb2NrIGZvciB2cGNpIGFuZCBzcGVjaWFsIGNhc2UNCj4+IHRoZSBNU0ktWCBhcmVh
IHRvIGFsc28gaGF2ZSBhIHBlci1kZXZpY2Ugc3BlY2lmaWMgbG9jay4gQXQgd2hpY2ggcG9pbnQN
Cj4+IGl0IGJlY29tZXMgZmFpcmx5IHNpbWlsYXIgdG8gd2hhdCB5b3UgcHJvcG9zZS4NCkBKYW4s
IEBSb2dlcg0KDQoxLiBkLT52cGNpX2xvY2sgLSByd2xvY2sgPC0gdGhpcyBwcm90ZWN0cyB2cGNp
DQoyLiBwZGV2LT52cGNpLT5tc2l4X3RibF9sb2NrIC0gcndsb2NrIDwtIHRoaXMgcHJvdGVjdHMg
TVNJLVggdGFibGVzDQpvciBzaG91bGQgaXQgYmV0dGVyIGJlIHBkZXYtPm1zaXhfdGJsX2xvY2sg
YXMgTVNJLVggdGFibGVzIGRvbid0DQpyZWFsbHkgZGVwZW5kIG9uIHZQQ0k/DQoNCkRvZXMgdGhp
cyBzb3VuZCBsaWtlIHNvbWV0aGluZyB0aGF0IGNvdWxkIGZseT8NCkl0IHRha2VzIHF1aXRlIGEg
d2hpbGUgdG8gaW1wbGVtZW50IGFuZCB0ZXN0LCBzbyBJIHdvdWxkIGxpa2UgdG8gdW5kZXJzdGFu
ZA0KdGhhdCBvbiB0aGUgZ3JvdW5kIHlldCBiZWZvcmUgcHV0dGluZyBlZmZvcnRzIGluIGl0Lg0K
PiBJbmRlZWQuDQo+DQo+IEphbg0KPg0KVGhhbmsgeW91IGluIGFkdmFuY2UsDQpPbGVrc2FuZHI=


From xen-devel-bounces@lists.xenproject.org Fri Feb 04 12:48:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 12:48:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265477.458852 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFy0J-0007ZQ-OC; Fri, 04 Feb 2022 12:47:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265477.458852; Fri, 04 Feb 2022 12:47:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFy0J-0007ZJ-K7; Fri, 04 Feb 2022 12:47:55 +0000
Received: by outflank-mailman (input) for mailman id 265477;
 Fri, 04 Feb 2022 12:47:54 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1gJ0=ST=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nFy0I-0007ZD-Bd
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 12:47:54 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id aaa73076-85b8-11ec-8f75-fffcc8bd4f1a;
 Fri, 04 Feb 2022 13:47:52 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2054.outbound.protection.outlook.com [104.47.14.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-22-LC6myEc5N1q0zJlgVMKmWQ-1; Fri, 04 Feb 2022 13:47:51 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM0PR04MB6513.eurprd04.prod.outlook.com (2603:10a6:208:178::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.14; Fri, 4 Feb
 2022 12:47:49 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.014; Fri, 4 Feb 2022
 12:47:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: aaa73076-85b8-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1643978872;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=YV+dG3qhJMPbTBxOksQyLr5gmXVQM7TVWOV+WFW2YKY=;
	b=NfE+HgfzF2WDVxYaTtbf8pudR9pep/6v9FsVpWEXf1ijlJmuymIVD7LTlMiPgI10Rv04KP
	bHmKbrpB74zGdES35HQQ+LDqtK11sUaSa5THj7tyBln0eGaKmLsWY4WSsM+inByBlL4n+T
	7vlSrYPIe630PGcfmxAE3MUYI6uH79w=
X-MC-Unique: LC6myEc5N1q0zJlgVMKmWQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=R5suSWb73ptc91CG4Ut6a16B/YIA4FCNpij56StdKuz4SlHfL2E14cydZXcIETkUjoJE3ZYpOE0TQZoJRxStx/BgTSMWhRr4drWdUUm1ifjLPPEHKltU7Cs7ZTe1ORh9eNEZda2BmgLqZoIlzEy1L/68/ft7Zu8S+FHsWRC5vqMm0Oq2hUxGd3VwQ0tIQaCIPMeOKpk5wfGeYhQ5mbgW8dcWacKKAi4l19s7UDMttKveyyWEAaWsxeF4Me2ShjGpgkHyOXfPXhOl3xvn0sEYfgu3oMkgB9Uxb5iZYAX8tQq6NAcPi5PNvTE2cBLp4+1q+Jvki1oWiY0rRHlGR2ckYQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=hO1IzpY8C4sOIILpU08w1gKMfn4ieRR8a3HMoQZgoxg=;
 b=RWfD9WJ45nKxhHC2GFlZO9C+0WzIK+twwRFTL/DBlqGYppi5xUIk0z8fRMjlwjhe1lCUnl+3+EEExsEUFb/UljAkSnU9YFjTs40nwZmFXQxByvx/Sga0qMG6EfuqodTB9RHxP4B6OUagWo4by650iH+Zh26MVEdMv6F90pLFih0FSDAufKygQkQ1mhvBfF8o2XTEVo4LZtxEKG4vF81zMlW4p++NgjkXd38gziYE7hpjXC6pBdq5XvSojh6LpIUeM3MLQ4D43lxgeRco7yhDvOl3/tAVFZHWP0T1v8pFlB+xR8eMMXPs3YLRJnYi+fYDSwnT4yYeiTofSRw7HZ7cSw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <a8fc599c-f620-c4d1-2077-c57068f46a7f@suse.com>
Date: Fri, 4 Feb 2022 13:47:46 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Content-Language: en-US
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: "julien@xen.org" <julien@xen.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Artem Mygaiev <Artem_Mygaiev@epam.com>,
 "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
 "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
 "paul@xen.org" <paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-4-andr2000@gmail.com>
 <7209889d-8f17-61cc-72a4-97f6dbc1d54d@suse.com>
 <2cf022f8-b000-11b7-c6b9-90a56bc6e2ea@epam.com>
 <04726915-f39f-9019-436e-4399533c9fc3@suse.com>
 <9ed3f4ac-0a2d-ed45-9872-7c3f356a469e@epam.com>
 <c3a99712-cf7c-37da-aac1-f2ee00e6d53b@suse.com>
 <Yf0KcVD8W05A4fbB@Air-de-Roger>
 <1ed0e342-16cd-2f16-c05c-186667a22762@suse.com>
 <7e3562b5-fc67-f213-e872-f211450d9e2e@epam.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <7e3562b5-fc67-f213-e872-f211450d9e2e@epam.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6P194CA0046.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:209:84::23) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d4376466-fd3b-4a58-0b02-08d9e7dc8d0e
X-MS-TrafficTypeDiagnostic: AM0PR04MB6513:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB6513711A90532E1C09A95E84B3299@AM0PR04MB6513.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6790;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	YbVNqMlHRsDK2vTfDCnEdF6a2/jjSSwFKPRhy8OTMjksxnR/zRh+awMhl9yP0iE46aDz2Rqm8cI9ciKWNqQuhnkncrFzK16IZtNgPheGxIS1DsWit0LFHcty4at9NMr5xgWMjb0ALYU1XluNhFLZBsa8qTgtQ/P1rQCy6mWHUEO8GO1ehTW9vm4E4w5lGpuIfoWZbWhpY8ChwCVCYRTR/Q1Ra/iIca6YHs6JP1C9kVCRuRaDT3+KvWGvIikn3m38IZ5WhRh1ZoNXh1OeJFsdavVJ3GVgfLl0gcv9ekzaxXTvXe5HLKkH0wlBuwNILGrwTmbT/b5ZF5034ZTK7y5j2Cg9MtGMvFjKBtqhP/5ll2zk6Hjrb+aaJ0xboTSinadN4g9cws0ure4GYjr2V5Qch5OVGQTXiFi8t0zh3maz6clmwizuyphs0bDPw4i1g3BM6DmRefCZNfZzQGi4qB0/uBekBhsarmNBKQNNa0AFMnw8tn4XFtuCa454jla+uvE11olfDCobXWToYPU+JLseoTUh9Os2hTfqxGW7UOCOSQPB1t9ehoQbOIsaqtOtMAdgjjUdNO2VhfDerwkWQsF3nQ8aJ96GcDDSGG1bYTkjDqAZ0zJkoEs2q+ZHe9PLuXiVibu+JSuO/SOLvK94jurycjdwPJUfQPY1TPmGOr3XgJ2ypb4EaZcQqMWpfIUaacIQP7RmuRhOLfscA2OpOVdVWNGwfGDZhLZyo+VUvdpWHeU=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(508600001)(2616005)(66556008)(6512007)(6486002)(31696002)(8936002)(86362001)(26005)(186003)(6666004)(6506007)(53546011)(2906002)(66476007)(36756003)(6916009)(8676002)(4326008)(5660300002)(7416002)(38100700002)(31686004)(54906003)(83380400001)(316002)(66946007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?LwcBfEHdZwDkgiSxNcxpfn5Npd/bRKg2L7gLLC0iCTsFzj37ewVe5CXRXmRZ?=
 =?us-ascii?Q?C3iN0zq2CY3hbk1z4EjrS79qmScwLJQhrOekQB3ACQM0/eq2+7wNGcQvhZmf?=
 =?us-ascii?Q?ruzc65KM0aW5oyzZIHTepTtb6CZZa/Ve/kqkqPErrHQHBeJVWe1z4Oue+XNb?=
 =?us-ascii?Q?JAkJ7zdGnx61QpTRNkg4yuw26lD0vGv6+9DlhMJ64xD3q3WxeXUym9c3bEDW?=
 =?us-ascii?Q?IBQYEAhgB/EJGx5Hcwdn76Pxd9vY5HbL50C6TiBilbA35CMPzjkbdAqrCe4q?=
 =?us-ascii?Q?qRDSXCBFmtPqNisjWPqkAAIc0rUZzZZiiGndj71YjSJ8diG9t8DH+hVLhRJZ?=
 =?us-ascii?Q?sE3+k3DUKjGHC5Nxg8QuJ1vQnDx9l0STlw4+XkfyUqdA6s43j4cI8UR1s8TP?=
 =?us-ascii?Q?yGccOayPzH1Cd6CzH/NODbm1aYlJwaiEX7UWGTNWKKOqWelM65/cp+kMtCCX?=
 =?us-ascii?Q?jyD9XkXZ2nUV+k/E61r59wFAbWmr4Z3ieMYUdHoUeW+Y5sgcoBEUbZpi6Gw1?=
 =?us-ascii?Q?ga0iyFEXKn8ABQVvJaOgTl32/5ySI8gX2md87S3ST1JBJ0t5Kxd60lkiTaRH?=
 =?us-ascii?Q?auOBMZ/xYQe3bVFm7Jrh07sXB7sn7sVwoXX9VFrtHJgHK3omCH3Q2+HeiRfC?=
 =?us-ascii?Q?yQnwEUwIyNnN8TW/k7vt7kIbwMPtPw1iZwacTeZ5pfrfCfGcvaHJUJM0NQb6?=
 =?us-ascii?Q?RF0W3NdP7jcD8PYYXFDD4+8va/SJhobidxF1aaq6L9QkUkBAAJhSomQOSTUw?=
 =?us-ascii?Q?5ImJsu3j0w1ScKd2YdUH4vPuZX6L1x88KZzJe4vQjWodjBzRNK7Q1S3uVuXF?=
 =?us-ascii?Q?gRO5IU2PARpViyaCqHVrMMnGbA0/+cDUqkDBgULhNi6tpoBGzJvzDgPBhCFz?=
 =?us-ascii?Q?GHgS5LS7u114wrUU9UuBeGTrPNvzVKtJgm6p6+oGEEnlt0Mn+v/ojCsSbZvj?=
 =?us-ascii?Q?9f0UaqecsH5Q4DY3EXA8uQFJB4+NlGR4waxACdzSKsV4GSYxQh8r/qzDYtbb?=
 =?us-ascii?Q?LQREP7UZ0ZseWncZSA4CVFI31vJjnc24Z/y5ZW2nGsy4SBrARgwFtdTvbBLN?=
 =?us-ascii?Q?ph5GKA3trPGLBocwCqr/7jo0yI0IzwExsIfukUL9/RjLaznUCLQN7pEqc6PX?=
 =?us-ascii?Q?QV5mzo/BYLIC1EvokwHElitIQeFYgSTz/uMsXvhec5rD6MKrU+Vyhw9sl5NU?=
 =?us-ascii?Q?1Jc9n3tD68EbAStt6ojzCbv0Ts7ZKPYtyiVDq5mmc7jI9lil7vaIHqe/Sejr?=
 =?us-ascii?Q?x7a9F7fbEFWVbpJ6NmctaehK2/hG9Nx262Njt6w9nGBSyv9IouPNfavZxStp?=
 =?us-ascii?Q?Z9L166QVUIfTL7r2/+1AX7BbPEfFcrwanUe6/VWOFSuoUyc+6FyPqvu/5cxL?=
 =?us-ascii?Q?XMj0+AjP1UD0eLsWlBiP583a5n+cbbqLF9elyhHwaoFu+dG6V6OCHl9jXofN?=
 =?us-ascii?Q?ByJuEeUufhpU/X0Lz3pCKyAfkZ+TUbleGwhnlRjfto2h6sSrVqixaYBZEGmr?=
 =?us-ascii?Q?jRUPjrP0xQreCQEgRGsh2orPTWOZaKdsk4wCzaj/Vmy2uo93BXaJfKAPCclO?=
 =?us-ascii?Q?5nRQyIaQJ23qBdiCf/zSiqR5BZ52UkVLZk3NjO+GPP6ZuLzB+h2z24zrdRMt?=
 =?us-ascii?Q?xHfFLh5Zm2D4C+0KmW3aUFE=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d4376466-fd3b-4a58-0b02-08d9e7dc8d0e
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Feb 2022 12:47:49.6214
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aYAe4JGdHZqsqOAJa3PSY9IbruwS/I6KjlRNZxpNVsW2vD/8zJH0HysVvyFFE+YF2dCVJ06Y273YZOFRykC/ew==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6513

On 04.02.2022 13:37, Oleksandr Andrushchenko wrote:
>=20
>=20
> On 04.02.22 13:37, Jan Beulich wrote:
>> On 04.02.2022 12:13, Roger Pau Monn=C3=A9 wrote:
>>> On Fri, Feb 04, 2022 at 11:49:18AM +0100, Jan Beulich wrote:
>>>> On 04.02.2022 11:12, Oleksandr Andrushchenko wrote:
>>>>> On 04.02.22 11:15, Jan Beulich wrote:
>>>>>> On 04.02.2022 09:58, Oleksandr Andrushchenko wrote:
>>>>>>> On 04.02.22 09:52, Jan Beulich wrote:
>>>>>>>> On 04.02.2022 07:34, Oleksandr Andrushchenko wrote:
>>>>>>>>> @@ -285,6 +286,12 @@ static int modify_bars(const struct pci_dev =
*pdev, uint16_t cmd, bool rom_only)
>>>>>>>>>                     continue;
>>>>>>>>>             }
>>>>>>>>>    =20
>>>>>>>>> +        spin_lock(&tmp->vpci_lock);
>>>>>>>>> +        if ( !tmp->vpci )
>>>>>>>>> +        {
>>>>>>>>> +            spin_unlock(&tmp->vpci_lock);
>>>>>>>>> +            continue;
>>>>>>>>> +        }
>>>>>>>>>             for ( i =3D 0; i < ARRAY_SIZE(tmp->vpci->header.bars)=
; i++ )
>>>>>>>>>             {
>>>>>>>>>                 const struct vpci_bar *bar =3D &tmp->vpci->header=
.bars[i];
>>>>>>>>> @@ -303,12 +310,14 @@ static int modify_bars(const struct pci_dev=
 *pdev, uint16_t cmd, bool rom_only)
>>>>>>>>>                 rc =3D rangeset_remove_range(mem, start, end);
>>>>>>>>>                 if ( rc )
>>>>>>>>>                 {
>>>>>>>>> +                spin_unlock(&tmp->vpci_lock);
>>>>>>>>>                     printk(XENLOG_G_WARNING "Failed to remove [%l=
x, %lx]: %d\n",
>>>>>>>>>                            start, end, rc);
>>>>>>>>>                     rangeset_destroy(mem);
>>>>>>>>>                     return rc;
>>>>>>>>>                 }
>>>>>>>>>             }
>>>>>>>>> +        spin_unlock(&tmp->vpci_lock);
>>>>>>>>>         }
>>>>>>>> At the first glance this simply looks like another unjustified (in=
 the
>>>>>>>> description) change, as you're not converting anything here but yo=
u
>>>>>>>> actually add locking (and I realize this was there before, so I'm =
sorry
>>>>>>>> for not pointing this out earlier).
>>>>>>> Well, I thought that the description already has "...the lock can b=
e
>>>>>>> used (and in a few cases is used right away) to check whether vpci
>>>>>>> is present" and this is enough for such uses as here.
>>>>>>>>     But then I wonder whether you
>>>>>>>> actually tested this, since I can't help getting the impression th=
at
>>>>>>>> you're introducing a live-lock: The function is called from cmd_wr=
ite()
>>>>>>>> and rom_write(), which in turn are called out of vpci_write(). Yet=
 that
>>>>>>>> function already holds the lock, and the lock is not (currently)
>>>>>>>> recursive. (For the 3rd caller of the function - init_bars() - oto=
h
>>>>>>>> the locking looks to be entirely unnecessary.)
>>>>>>> Well, you are correct: if tmp !=3D pdev then it is correct to acqui=
re
>>>>>>> the lock. But if tmp =3D=3D pdev and rom_only =3D=3D true
>>>>>>> then we'll deadlock.
>>>>>>>
>>>>>>> It seems we need to have the locking conditional, e.g. only lock
>>>>>>> if tmp !=3D pdev
>>>>>> Which will address the live-lock, but introduce ABBA deadlock potent=
ial
>>>>>> between the two locks.
>>>>> I am not sure I can suggest a better solution here
>>>>> @Roger, @Jan, could you please help here?
>>>> Well, first of all I'd like to mention that while it may have been oka=
y to
>>>> not hold pcidevs_lock here for Dom0, it surely needs acquiring when de=
aling
>>>> with DomU-s' lists of PCI devices. The requirement really applies to t=
he
>>>> other use of for_each_pdev() as well (in vpci_dump_msi()), except that
>>>> there it probably wants to be a try-lock.
>>>>
>>>> Next I'd like to point out that here we have the still pending issue o=
f
>>>> how to deal with hidden devices, which Dom0 can access. See my RFC pat=
ch
>>>> "vPCI: account for hidden devices in modify_bars()". Whatever the solu=
tion
>>>> here, I think it wants to at least account for the extra need there.
>>> Yes, sorry, I should take care of that.
>>>
>>>> Now it is quite clear that pcidevs_lock isn't going to help with avoid=
ing
>>>> the deadlock, as it's imo not an option at all to acquire that lock
>>>> everywhere else you access ->vpci (or else the vpci lock itself would =
be
>>>> pointless). But a per-domain auxiliary r/w lock may help: Other paths
>>>> would acquire it in read mode, and here you'd acquire it in write mode=
 (in
>>>> the former case around the vpci lock, while in the latter case there m=
ay
>>>> then not be any need to acquire the individual vpci locks at all). FTA=
OD:
>>>> I haven't fully thought through all implications (and hence whether th=
is is
>>>> viable in the first place); I expect you will, documenting what you've
>>>> found in the resulting patch description. Of course the double lock
>>>> acquire/release would then likely want hiding in helper functions.
>>> I've been also thinking about this, and whether it's really worth to
>>> have a per-device lock rather than a per-domain one that protects all
>>> vpci regions of the devices assigned to the domain.
>>>
>>> The OS is likely to serialize accesses to the PCI config space anyway,
>>> and the only place I could see a benefit of having per-device locks is
>>> in the handling of MSI-X tables, as the handling of the mask bit is
>>> likely very performance sensitive, so adding a per-domain lock there
>>> could be a bottleneck.
>> Hmm, with method 1 accesses serializing globally is basically
>> unavoidable, but with MMCFG I see no reason why OSes may not (move
>> to) permit(ting) parallel accesses, with serialization perhaps done
>> only at device level. See our own pci_config_lock, which applies to
>> only method 1 accesses; we don't look to be serializing MMCFG
>> accesses at all.
>>
>>> We could alternatively do a per-domain rwlock for vpci and special case
>>> the MSI-X area to also have a per-device specific lock. At which point
>>> it becomes fairly similar to what you propose.
> @Jan, @Roger
>=20
> 1. d->vpci_lock - rwlock <- this protects vpci
> 2. pdev->vpci->msix_tbl_lock - rwlock <- this protects MSI-X tables
> or should it better be pdev->msix_tbl_lock as MSI-X tables don't
> really depend on vPCI?

If so, perhaps indeed better the latter. But as said in reply to Roger,
I'm not convinced (yet) that doing away with the per-device lock is a
good move. As said there - we're ourselves doing fully parallel MMCFG
accesses, so OSes ought to be fine to do so, too.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Feb 04 12:53:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 12:53:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265486.458863 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFy5r-0000aN-9K; Fri, 04 Feb 2022 12:53:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265486.458863; Fri, 04 Feb 2022 12:53:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFy5r-0000aG-5s; Fri, 04 Feb 2022 12:53:39 +0000
Received: by outflank-mailman (input) for mailman id 265486;
 Fri, 04 Feb 2022 12:53:37 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=u+82=ST=epam.com=prvs=4034f0a382=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nFy5p-0000aA-ME
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 12:53:37 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 76c26f98-85b9-11ec-8f75-fffcc8bd4f1a;
 Fri, 04 Feb 2022 13:53:36 +0100 (CET)
Received: from pps.filterd (m0174679.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 214C38KL006867;
 Fri, 4 Feb 2022 12:53:25 GMT
Received: from eur05-db8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2105.outbound.protection.outlook.com [104.47.17.105])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e11uerm5b-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 04 Feb 2022 12:53:25 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by DB6PR0301MB2424.eurprd03.prod.outlook.com (2603:10a6:4:5c::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Fri, 4 Feb
 2022 12:53:20 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6%3]) with mapi id 15.20.4951.014; Fri, 4 Feb 2022
 12:53:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 76c26f98-85b9-11ec-8f75-fffcc8bd4f1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=DuNrJNHgPFLXCUcSd9mLdWVmF6w+49ETHKJEeVyR/bMKaYqnmkLjQdDioyZ9jKDj7/Rvqm9VABFBHXIQjKw1W7heuj98jxlGU+KVKJJTbLzOwasLJKNqe99M9I86wbIBgUAyzkzrvT5cFx+zg1HBr94CnG0RIGFNgSswJF/R911GI/YofnV8Swrt+Z+IlVNMQZ6CvyD74e+oNRNTPOevZuMn0uLcbuvHWgSNlK6bJriJY3l6yZTX8cBc5+y94u+BlZxEGejgFNcQt9QSzG3/1guoEgLYRshQAf4lhETQI+kPdPmpTa5B39aSLSb/coChMCK9x4YOSsewJeW5ii2d/Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=0CCuKhAuAIHCEyGTt3dgFlQdZ0wyy/ycwvxOjGJv6J8=;
 b=Z+0jKcAxSF88SSFgg94Hb0h3LsOkoBVtCqY+UelPzHY5GLBFWWoA7pI7G34d4Kmpsn3vU68cwsZ1Cf9mqXdeGW7DnlWwpZH+fu42wGMQdR3N1aO1PO0vkidTi/KPFe/7OCjrE9UjgPIifeStoH8Nf5RYghZzKkKUFpnCLAQWn6Nu8wq8Js6IwGrl47GFzU4yc+nhAi5m76uHMKU/IDfu1qI/SNpKz8S7fYx0fChmIS23iiYnAa2u1niqDF0MF67Io3YKgUlZ1SU/lJKB8/ygQ4LJtIMZzEUHPud/S2yketVnFHwhKteIcBSxTvVxPI2pAWZnkSHmeNDNOjI1/uWNTg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=0CCuKhAuAIHCEyGTt3dgFlQdZ0wyy/ycwvxOjGJv6J8=;
 b=i+iwrX4ZG03GCAvD0vjA2elka6xcxcl3a/bE9qfgCrG15Wih5lkraQ2pMOt9LPp9+3dZu5hXPF3Y28eNHlfpErov4JPxe+5AObK7ijgFaTHRowsm5E5ZU4f01tpUwcvjfpwScJ41HxP75nfhLpiuhFg5fcCkl1mvCqGi6YyPly+xZC4Y8R/Y0PxK0PPw5Cp6E6laGU+J/ditghIN4wPPBBUUnNXwGtsCx5udlkIyJERv5kyIIxgJUS6a4gHUh4020WCB3WqofILpPFo3SwQYrRFHgdwV4CJMrmFK7eVjTGkVBzEcHzpwXsnSdNOpzGIq2XRHJ3ZVVOFNmntO41FFNw==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?=
	<roger.pau@citrix.com>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Thread-Topic: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Thread-Index: 
 AQHYGZFc/MnzQOjwVEeBBUHLSW0md6yDBUkAgAASSACAAATYAIAAD/WAgAAKNgCAAAbfgIAABnuAgAAQvgCAAAMCAIAAAY4A
Date: Fri, 4 Feb 2022 12:53:20 +0000
Message-ID: <deef8468-d607-e49e-f456-6a8013329ca1@epam.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-4-andr2000@gmail.com>
 <7209889d-8f17-61cc-72a4-97f6dbc1d54d@suse.com>
 <2cf022f8-b000-11b7-c6b9-90a56bc6e2ea@epam.com>
 <04726915-f39f-9019-436e-4399533c9fc3@suse.com>
 <9ed3f4ac-0a2d-ed45-9872-7c3f356a469e@epam.com>
 <c3a99712-cf7c-37da-aac1-f2ee00e6d53b@suse.com>
 <Yf0KcVD8W05A4fbB@Air-de-Roger>
 <1ed0e342-16cd-2f16-c05c-186667a22762@suse.com>
 <7e3562b5-fc67-f213-e872-f211450d9e2e@epam.com>
 <a8fc599c-f620-c4d1-2077-c57068f46a7f@suse.com>
In-Reply-To: <a8fc599c-f620-c4d1-2077-c57068f46a7f@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: dff7d1e4-e51c-495b-b04b-08d9e7dd528f
x-ms-traffictypediagnostic: DB6PR0301MB2424:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <DB6PR0301MB24245CB9CFADD09F05B8F7E1E7299@DB6PR0301MB2424.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:6790;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 nXYZ6na4aL8rL5TM349n1Mr0GSgfoQ45ltO6mRYS1PF6AmaGs9i7ahj4PzZQ840cYjP/9ck9xixS+jzsmw+py2DYkvudghQmTemDzj1iPaBAjjClJBVKSkHotJh49brzM7lI7LzdW4mAbIiiHOjdoQB1+lCndhKUXeCCJQa6ewBa4fWm5vozr1SCZFqrAX+7RqUY9avi4YvmsG1awQJEW4Gri/1I9LC6KQMLWOj5X6iOac+SxFCB0aTBDQR/cbNXOa0787y1qdK94hF6j5o2H2gldmOZF/pHMOXAolzLtCgfS6LLmTU2mPRaekmgrCoHt382nXCQKIlWVtNSRbiLEVoahAl0ubNIvHQafr9NOgpr6cv5/jy2Z27xVVPjtpmlDI70xjWiL64XqN2cJLnI422IMQ40za9ECsBMEchLe/tfkuHe9znb0cf7xnLj5Hx5DeJ1jdTxTBCdPI3TApO8prhlq1UWBLctzkBO4qB/3kBWCtwOeJW2BFLE+ZBZS0MdABvjfGfhbpTKIfMrrr3xp/nvIUnfRa3HeHsRWRffKjwQkTzcivq3HziM+U27sK97iDTrU7j9ItW+b96t6OSpLZYCZxc/j/RhDIoMOMnn2bbfChKdrHmIof9AbBiZRXf0HXkxzQi1OPzMqWF+pVPTmyLsfq+ZoUD3t7M7LqGwqevOCNYPrENZvDc+gZe2wYFMj1KFEAK+/aMK9lMIHyK5hH7iEQvoebyZ1c+ieARGG+uIak2Iv75WQFNYD3E4SKpo
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(122000001)(6506007)(53546011)(31696002)(6916009)(316002)(38100700002)(6486002)(86362001)(54906003)(6512007)(8676002)(66446008)(83380400001)(91956017)(4326008)(31686004)(66476007)(7416002)(5660300002)(508600001)(186003)(2616005)(2906002)(36756003)(66946007)(38070700005)(71200400001)(8936002)(76116006)(66556008)(64756008)(26005)(107886003)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?eFdpUVZFREZZQnRqSS8xeElURFo2REkrYnJTNWJmUmdUVDJlcG1xQVN1VG9T?=
 =?utf-8?B?UVRoYUpIdkFCNm9JdXoxSWFPY2U1YlpmTmh5UE5ORzVPZG9lN2c0c1V5M1M0?=
 =?utf-8?B?MjBBb2h5MmNicjlWN0k2NGpPMzVUK04zeDU3RkdrOFFpYldtRmtZaDlmMTdw?=
 =?utf-8?B?dlRRM1FMSVVLRUYxRHBUU280YWFKREkyLzZvdER5Z0E5eUV3Z2p1RFhlOFZH?=
 =?utf-8?B?SWpORVNHYVRRWWF2VVZaR01KdjRKWUZHckhrWEFnVC9PTnZKQlRURGJqS3ZC?=
 =?utf-8?B?dUhrTm9sRjN6YmZwdmdoL0d0MnVuYVlYc05zbHdDM3ZQUmoxVDNYWk5peDZy?=
 =?utf-8?B?NDhvQnhJTmNXZ1VZRUNJRk5JNjZGT2xsb0VaeTNlQTM2MEYyL0p1Tm0zNDR3?=
 =?utf-8?B?ekRyZGFOajhOT0h6THpVTVBqcHBkNEVERlluTkdVNytEbjdxTDhxWjNaTnps?=
 =?utf-8?B?WC9ueGNFZFpFTjBpR3BrejBVcGZjZzNhTkFRQjI5R21kT08zdEFQcTJJOGRK?=
 =?utf-8?B?NnNZV3pSYXZpTXNBcEFyemZuenlvOXFmTEg1c3EwNGI3RlRIdTZNYVBSejk3?=
 =?utf-8?B?cW1CRlB3bTAyMmp6dHBGR29RYjh2cTZhajNyU2Y4Yy9KdUk2a05XamRDeFZV?=
 =?utf-8?B?OEtoTjVKMmExK0ZHVmJ1dGZNb2MvRVhyOWZES04xbVhtSDg1dXZ3L0JiSE5Y?=
 =?utf-8?B?cFFXT081NHp3UTNYZXFtNHlsdnV3dE9wTjJGWGZJM0FKa01XbnF0eVFTMmVS?=
 =?utf-8?B?MGo2UlF3a2k5KzhBVDV2c1VkZWFyWElId2MrbDlZWWdPUkJmUVdqT2dXOEpJ?=
 =?utf-8?B?dkg4TG5wQXhTQWhramNJcTk4Q2xENzhNYVY1VHdJbjRCSlkxTFFndmREUk1P?=
 =?utf-8?B?OSs4OWFNSmlhMXZ4RXZISmR2TUVUS3cwQ0p1Yml3ck9wblNhaDRPL1NRL0xk?=
 =?utf-8?B?SWhxNEJ3YWpNMEdEU1BnZGxIMk1Tbm5EdzRBTmRrN2VKTzFBd2hOd1ptMUo5?=
 =?utf-8?B?RGlJQklFVCtBL1cxMzR5WTRlRUpGdXRDOE1IR202WXNTZ3JoYlUzNlZSbWNh?=
 =?utf-8?B?bmtmWmxvTGVHRnZjK3FFRE9UNkQ5N0E5ZEk0NENhQmF3V3F2MDFVeEErMkpE?=
 =?utf-8?B?Y3VZSVRoUW9wT2hBNUYrS2JEV0lEL3FiTzdWYVBhdkVTT3ExU0huV21HTzFW?=
 =?utf-8?B?V2h3bHNmc0dFamQ0aE1nY3dwbkl4cmF4TmoyZ1VvMFhsMEhqbjBGUTFmOCt4?=
 =?utf-8?B?ckNHc2J0L3FvTWZmWmRCR25wSTBXaVBmK2ZOOG5LWFAwWjF5VmJqNmpiNERT?=
 =?utf-8?B?MVhlR21qdTkvdmlQWGFaYWxQV0hQcGVndnhSb1JBbEpvQUsrZE5XbXVMVllt?=
 =?utf-8?B?NHFjRHB6YnhQUEM5bEFYbTNiZFBldGk5R2Jia0FKZ2lJSzNRMlM5SUZMV0Np?=
 =?utf-8?B?OUtBWkgyUmxocWkwOWcycEF5aEhiWGlkUEJXdGZuTnZlU2h5b1UvenppWTdQ?=
 =?utf-8?B?aXBwR2VMM2hyU29UT0VScW5FVU9lSS9XNUxsS3d3Si9WL3l4K1YrbGRRdXhy?=
 =?utf-8?B?dUdFMVRrQ0Q2Ym1JSDUyVTlkUjVha0xteE4wVzYrbzZ0L1lNc2hyUDAxM1hN?=
 =?utf-8?B?MDArUWUyNzh3RUVlR2tWNGRFQ0xacFJlakVZUFVid1pLRFlrNXpNenVBK2RV?=
 =?utf-8?B?WXdIaWJNK0F4MEdRN2JJSEJrK0U4T0c0amFKYW1BOXZJRWVEMUdDNnIvUS9y?=
 =?utf-8?B?aWhZM3JiWHB4bjNESUVUTmFOOURjTlNVbTdBSWFEMStweVovOWlJMWtRUUEx?=
 =?utf-8?B?aEF4cURHUHVpZWFiNXlGVnFZamlpS0ZOSE1qeDBETE82WHZnSzhyVjdOVXFv?=
 =?utf-8?B?VVVQbGxpUWVvZ0dwQzVYbjJudTRwNm1oa1BjbzZldm1KWkYycVNjbk9pWDNP?=
 =?utf-8?B?RWRDQ09namZ0QlFYR1FUREZQUkJSdERwOWFvQU5Wc3RpaHFDdDZrVVZ2TE5U?=
 =?utf-8?B?ajNUV3ptTWJoNVZXOUFic3NPb2xncWU1d2tpc1pma211UDhUNEJpenZPelhy?=
 =?utf-8?B?eEpNSzlQRlNqWHlxL0dDd25OcUtSaU5iem5xd3A0SExOc1pITC9VUUozY0ww?=
 =?utf-8?B?bFpIclNxdXBlaFdqakdkQ3Vrdlg0Q2xpbnNHTVNZUGhHTnl1TDgwZlpCa0V5?=
 =?utf-8?B?VFhDVWJEYncxaitqMFRFbnZtUkdqWFpSTDBySnB4ZHpkdFY2OUN2andoVWRB?=
 =?utf-8?B?TnN4V256YTRDTFlicE9CUXBFK2tQNlVMWjJyVFhzUWRnTVBwY04wbmt2T1lK?=
 =?utf-8?B?bHhWcDloNjE2RDVYMnlaWEJUNDFqTm5KL1h6WkhXeVpPU1RnL2xGZz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <B4DABAA8BFB6D041AC394D88B6D00C9A@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dff7d1e4-e51c-495b-b04b-08d9e7dd528f
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Feb 2022 12:53:20.7636
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: H3f1hF2mPS2wg0EoIwb7uKZtl49pDiRYuuQZjiFTaIIUjabe9Z24z8z8oIFPUyn6oobNJ5CJjPlyvAmYVjfV6aQ4NK8Zh6OSLVdoDuSziJKUqF0um/XhIJBTM2qHPKVK
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0301MB2424
X-Proofpoint-ORIG-GUID: a5AFKxmkkcTIueAI6QRXv7nctyED5BvO
X-Proofpoint-GUID: a5AFKxmkkcTIueAI6QRXv7nctyED5BvO
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-04_04,2022-02-03_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0
 priorityscore=1501 mlxscore=0 adultscore=0 impostorscore=0 spamscore=0
 lowpriorityscore=0 bulkscore=0 suspectscore=0 mlxlogscore=999 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2202040072

DQoNCk9uIDA0LjAyLjIyIDE0OjQ3LCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMDQuMDIuMjAy
MiAxMzozNywgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+Pg0KPj4gT24gMDQuMDIu
MjIgMTM6MzcsIEphbiBCZXVsaWNoIHdyb3RlOg0KPj4+IE9uIDA0LjAyLjIwMjIgMTI6MTMsIFJv
Z2VyIFBhdSBNb25uw6kgd3JvdGU6DQo+Pj4+IE9uIEZyaSwgRmViIDA0LCAyMDIyIGF0IDExOjQ5
OjE4QU0gKzAxMDAsIEphbiBCZXVsaWNoIHdyb3RlOg0KPj4+Pj4gT24gMDQuMDIuMjAyMiAxMTox
MiwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+Pj4+Pj4gT24gMDQuMDIuMjIgMTE6
MTUsIEphbiBCZXVsaWNoIHdyb3RlOg0KPj4+Pj4+PiBPbiAwNC4wMi4yMDIyIDA5OjU4LCBPbGVr
c2FuZHIgQW5kcnVzaGNoZW5rbyB3cm90ZToNCj4+Pj4+Pj4+IE9uIDA0LjAyLjIyIDA5OjUyLCBK
YW4gQmV1bGljaCB3cm90ZToNCj4+Pj4+Pj4+PiBPbiAwNC4wMi4yMDIyIDA3OjM0LCBPbGVrc2Fu
ZHIgQW5kcnVzaGNoZW5rbyB3cm90ZToNCj4+Pj4+Pj4+Pj4gQEAgLTI4NSw2ICsyODYsMTIgQEAg
c3RhdGljIGludCBtb2RpZnlfYmFycyhjb25zdCBzdHJ1Y3QgcGNpX2RldiAqcGRldiwgdWludDE2
X3QgY21kLCBib29sIHJvbV9vbmx5KQ0KPj4+Pj4+Pj4+PiAgICAgICAgICAgICAgICAgICAgICBj
b250aW51ZTsNCj4+Pj4+Pj4+Pj4gICAgICAgICAgICAgIH0NCj4+Pj4+Pj4+Pj4gICAgICANCj4+
Pj4+Pj4+Pj4gKyAgICAgICAgc3Bpbl9sb2NrKCZ0bXAtPnZwY2lfbG9jayk7DQo+Pj4+Pj4+Pj4+
ICsgICAgICAgIGlmICggIXRtcC0+dnBjaSApDQo+Pj4+Pj4+Pj4+ICsgICAgICAgIHsNCj4+Pj4+
Pj4+Pj4gKyAgICAgICAgICAgIHNwaW5fdW5sb2NrKCZ0bXAtPnZwY2lfbG9jayk7DQo+Pj4+Pj4+
Pj4+ICsgICAgICAgICAgICBjb250aW51ZTsNCj4+Pj4+Pj4+Pj4gKyAgICAgICAgfQ0KPj4+Pj4+
Pj4+PiAgICAgICAgICAgICAgZm9yICggaSA9IDA7IGkgPCBBUlJBWV9TSVpFKHRtcC0+dnBjaS0+
aGVhZGVyLmJhcnMpOyBpKysgKQ0KPj4+Pj4+Pj4+PiAgICAgICAgICAgICAgew0KPj4+Pj4+Pj4+
PiAgICAgICAgICAgICAgICAgIGNvbnN0IHN0cnVjdCB2cGNpX2JhciAqYmFyID0gJnRtcC0+dnBj
aS0+aGVhZGVyLmJhcnNbaV07DQo+Pj4+Pj4+Pj4+IEBAIC0zMDMsMTIgKzMxMCwxNCBAQCBzdGF0
aWMgaW50IG1vZGlmeV9iYXJzKGNvbnN0IHN0cnVjdCBwY2lfZGV2ICpwZGV2LCB1aW50MTZfdCBj
bWQsIGJvb2wgcm9tX29ubHkpDQo+Pj4+Pj4+Pj4+ICAgICAgICAgICAgICAgICAgcmMgPSByYW5n
ZXNldF9yZW1vdmVfcmFuZ2UobWVtLCBzdGFydCwgZW5kKTsNCj4+Pj4+Pj4+Pj4gICAgICAgICAg
ICAgICAgICBpZiAoIHJjICkNCj4+Pj4+Pj4+Pj4gICAgICAgICAgICAgICAgICB7DQo+Pj4+Pj4+
Pj4+ICsgICAgICAgICAgICAgICAgc3Bpbl91bmxvY2soJnRtcC0+dnBjaV9sb2NrKTsNCj4+Pj4+
Pj4+Pj4gICAgICAgICAgICAgICAgICAgICAgcHJpbnRrKFhFTkxPR19HX1dBUk5JTkcgIkZhaWxl
ZCB0byByZW1vdmUgWyVseCwgJWx4XTogJWRcbiIsDQo+Pj4+Pj4+Pj4+ICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICBzdGFydCwgZW5kLCByYyk7DQo+Pj4+Pj4+Pj4+ICAgICAgICAgICAgICAg
ICAgICAgIHJhbmdlc2V0X2Rlc3Ryb3kobWVtKTsNCj4+Pj4+Pj4+Pj4gICAgICAgICAgICAgICAg
ICAgICAgcmV0dXJuIHJjOw0KPj4+Pj4+Pj4+PiAgICAgICAgICAgICAgICAgIH0NCj4+Pj4+Pj4+
Pj4gICAgICAgICAgICAgIH0NCj4+Pj4+Pj4+Pj4gKyAgICAgICAgc3Bpbl91bmxvY2soJnRtcC0+
dnBjaV9sb2NrKTsNCj4+Pj4+Pj4+Pj4gICAgICAgICAgfQ0KPj4+Pj4+Pj4+IEF0IHRoZSBmaXJz
dCBnbGFuY2UgdGhpcyBzaW1wbHkgbG9va3MgbGlrZSBhbm90aGVyIHVuanVzdGlmaWVkIChpbiB0
aGUNCj4+Pj4+Pj4+PiBkZXNjcmlwdGlvbikgY2hhbmdlLCBhcyB5b3UncmUgbm90IGNvbnZlcnRp
bmcgYW55dGhpbmcgaGVyZSBidXQgeW91DQo+Pj4+Pj4+Pj4gYWN0dWFsbHkgYWRkIGxvY2tpbmcg
KGFuZCBJIHJlYWxpemUgdGhpcyB3YXMgdGhlcmUgYmVmb3JlLCBzbyBJJ20gc29ycnkNCj4+Pj4+
Pj4+PiBmb3Igbm90IHBvaW50aW5nIHRoaXMgb3V0IGVhcmxpZXIpLg0KPj4+Pj4+Pj4gV2VsbCwg
SSB0aG91Z2h0IHRoYXQgdGhlIGRlc2NyaXB0aW9uIGFscmVhZHkgaGFzICIuLi50aGUgbG9jayBj
YW4gYmUNCj4+Pj4+Pj4+IHVzZWQgKGFuZCBpbiBhIGZldyBjYXNlcyBpcyB1c2VkIHJpZ2h0IGF3
YXkpIHRvIGNoZWNrIHdoZXRoZXIgdnBjaQ0KPj4+Pj4+Pj4gaXMgcHJlc2VudCIgYW5kIHRoaXMg
aXMgZW5vdWdoIGZvciBzdWNoIHVzZXMgYXMgaGVyZS4NCj4+Pj4+Pj4+PiAgICAgIEJ1dCB0aGVu
IEkgd29uZGVyIHdoZXRoZXIgeW91DQo+Pj4+Pj4+Pj4gYWN0dWFsbHkgdGVzdGVkIHRoaXMsIHNp
bmNlIEkgY2FuJ3QgaGVscCBnZXR0aW5nIHRoZSBpbXByZXNzaW9uIHRoYXQNCj4+Pj4+Pj4+PiB5
b3UncmUgaW50cm9kdWNpbmcgYSBsaXZlLWxvY2s6IFRoZSBmdW5jdGlvbiBpcyBjYWxsZWQgZnJv
bSBjbWRfd3JpdGUoKQ0KPj4+Pj4+Pj4+IGFuZCByb21fd3JpdGUoKSwgd2hpY2ggaW4gdHVybiBh
cmUgY2FsbGVkIG91dCBvZiB2cGNpX3dyaXRlKCkuIFlldCB0aGF0DQo+Pj4+Pj4+Pj4gZnVuY3Rp
b24gYWxyZWFkeSBob2xkcyB0aGUgbG9jaywgYW5kIHRoZSBsb2NrIGlzIG5vdCAoY3VycmVudGx5
KQ0KPj4+Pj4+Pj4+IHJlY3Vyc2l2ZS4gKEZvciB0aGUgM3JkIGNhbGxlciBvZiB0aGUgZnVuY3Rp
b24gLSBpbml0X2JhcnMoKSAtIG90b2gNCj4+Pj4+Pj4+PiB0aGUgbG9ja2luZyBsb29rcyB0byBi
ZSBlbnRpcmVseSB1bm5lY2Vzc2FyeS4pDQo+Pj4+Pj4+PiBXZWxsLCB5b3UgYXJlIGNvcnJlY3Q6
IGlmIHRtcCAhPSBwZGV2IHRoZW4gaXQgaXMgY29ycmVjdCB0byBhY3F1aXJlDQo+Pj4+Pj4+PiB0
aGUgbG9jay4gQnV0IGlmIHRtcCA9PSBwZGV2IGFuZCByb21fb25seSA9PSB0cnVlDQo+Pj4+Pj4+
PiB0aGVuIHdlJ2xsIGRlYWRsb2NrLg0KPj4+Pj4+Pj4NCj4+Pj4+Pj4+IEl0IHNlZW1zIHdlIG5l
ZWQgdG8gaGF2ZSB0aGUgbG9ja2luZyBjb25kaXRpb25hbCwgZS5nLiBvbmx5IGxvY2sNCj4+Pj4+
Pj4+IGlmIHRtcCAhPSBwZGV2DQo+Pj4+Pj4+IFdoaWNoIHdpbGwgYWRkcmVzcyB0aGUgbGl2ZS1s
b2NrLCBidXQgaW50cm9kdWNlIEFCQkEgZGVhZGxvY2sgcG90ZW50aWFsDQo+Pj4+Pj4+IGJldHdl
ZW4gdGhlIHR3byBsb2Nrcy4NCj4+Pj4+PiBJIGFtIG5vdCBzdXJlIEkgY2FuIHN1Z2dlc3QgYSBi
ZXR0ZXIgc29sdXRpb24gaGVyZQ0KPj4+Pj4+IEBSb2dlciwgQEphbiwgY291bGQgeW91IHBsZWFz
ZSBoZWxwIGhlcmU/DQo+Pj4+PiBXZWxsLCBmaXJzdCBvZiBhbGwgSSdkIGxpa2UgdG8gbWVudGlv
biB0aGF0IHdoaWxlIGl0IG1heSBoYXZlIGJlZW4gb2theSB0bw0KPj4+Pj4gbm90IGhvbGQgcGNp
ZGV2c19sb2NrIGhlcmUgZm9yIERvbTAsIGl0IHN1cmVseSBuZWVkcyBhY3F1aXJpbmcgd2hlbiBk
ZWFsaW5nDQo+Pj4+PiB3aXRoIERvbVUtcycgbGlzdHMgb2YgUENJIGRldmljZXMuIFRoZSByZXF1
aXJlbWVudCByZWFsbHkgYXBwbGllcyB0byB0aGUNCj4+Pj4+IG90aGVyIHVzZSBvZiBmb3JfZWFj
aF9wZGV2KCkgYXMgd2VsbCAoaW4gdnBjaV9kdW1wX21zaSgpKSwgZXhjZXB0IHRoYXQNCj4+Pj4+
IHRoZXJlIGl0IHByb2JhYmx5IHdhbnRzIHRvIGJlIGEgdHJ5LWxvY2suDQo+Pj4+Pg0KPj4+Pj4g
TmV4dCBJJ2QgbGlrZSB0byBwb2ludCBvdXQgdGhhdCBoZXJlIHdlIGhhdmUgdGhlIHN0aWxsIHBl
bmRpbmcgaXNzdWUgb2YNCj4+Pj4+IGhvdyB0byBkZWFsIHdpdGggaGlkZGVuIGRldmljZXMsIHdo
aWNoIERvbTAgY2FuIGFjY2Vzcy4gU2VlIG15IFJGQyBwYXRjaA0KPj4+Pj4gInZQQ0k6IGFjY291
bnQgZm9yIGhpZGRlbiBkZXZpY2VzIGluIG1vZGlmeV9iYXJzKCkiLiBXaGF0ZXZlciB0aGUgc29s
dXRpb24NCj4+Pj4+IGhlcmUsIEkgdGhpbmsgaXQgd2FudHMgdG8gYXQgbGVhc3QgYWNjb3VudCBm
b3IgdGhlIGV4dHJhIG5lZWQgdGhlcmUuDQo+Pj4+IFllcywgc29ycnksIEkgc2hvdWxkIHRha2Ug
Y2FyZSBvZiB0aGF0Lg0KPj4+Pg0KPj4+Pj4gTm93IGl0IGlzIHF1aXRlIGNsZWFyIHRoYXQgcGNp
ZGV2c19sb2NrIGlzbid0IGdvaW5nIHRvIGhlbHAgd2l0aCBhdm9pZGluZw0KPj4+Pj4gdGhlIGRl
YWRsb2NrLCBhcyBpdCdzIGltbyBub3QgYW4gb3B0aW9uIGF0IGFsbCB0byBhY3F1aXJlIHRoYXQg
bG9jaw0KPj4+Pj4gZXZlcnl3aGVyZSBlbHNlIHlvdSBhY2Nlc3MgLT52cGNpIChvciBlbHNlIHRo
ZSB2cGNpIGxvY2sgaXRzZWxmIHdvdWxkIGJlDQo+Pj4+PiBwb2ludGxlc3MpLiBCdXQgYSBwZXIt
ZG9tYWluIGF1eGlsaWFyeSByL3cgbG9jayBtYXkgaGVscDogT3RoZXIgcGF0aHMNCj4+Pj4+IHdv
dWxkIGFjcXVpcmUgaXQgaW4gcmVhZCBtb2RlLCBhbmQgaGVyZSB5b3UnZCBhY3F1aXJlIGl0IGlu
IHdyaXRlIG1vZGUgKGluDQo+Pj4+PiB0aGUgZm9ybWVyIGNhc2UgYXJvdW5kIHRoZSB2cGNpIGxv
Y2ssIHdoaWxlIGluIHRoZSBsYXR0ZXIgY2FzZSB0aGVyZSBtYXkNCj4+Pj4+IHRoZW4gbm90IGJl
IGFueSBuZWVkIHRvIGFjcXVpcmUgdGhlIGluZGl2aWR1YWwgdnBjaSBsb2NrcyBhdCBhbGwpLiBG
VEFPRDoNCj4+Pj4+IEkgaGF2ZW4ndCBmdWxseSB0aG91Z2h0IHRocm91Z2ggYWxsIGltcGxpY2F0
aW9ucyAoYW5kIGhlbmNlIHdoZXRoZXIgdGhpcyBpcw0KPj4+Pj4gdmlhYmxlIGluIHRoZSBmaXJz
dCBwbGFjZSk7IEkgZXhwZWN0IHlvdSB3aWxsLCBkb2N1bWVudGluZyB3aGF0IHlvdSd2ZQ0KPj4+
Pj4gZm91bmQgaW4gdGhlIHJlc3VsdGluZyBwYXRjaCBkZXNjcmlwdGlvbi4gT2YgY291cnNlIHRo
ZSBkb3VibGUgbG9jaw0KPj4+Pj4gYWNxdWlyZS9yZWxlYXNlIHdvdWxkIHRoZW4gbGlrZWx5IHdh
bnQgaGlkaW5nIGluIGhlbHBlciBmdW5jdGlvbnMuDQo+Pj4+IEkndmUgYmVlbiBhbHNvIHRoaW5r
aW5nIGFib3V0IHRoaXMsIGFuZCB3aGV0aGVyIGl0J3MgcmVhbGx5IHdvcnRoIHRvDQo+Pj4+IGhh
dmUgYSBwZXItZGV2aWNlIGxvY2sgcmF0aGVyIHRoYW4gYSBwZXItZG9tYWluIG9uZSB0aGF0IHBy
b3RlY3RzIGFsbA0KPj4+PiB2cGNpIHJlZ2lvbnMgb2YgdGhlIGRldmljZXMgYXNzaWduZWQgdG8g
dGhlIGRvbWFpbi4NCj4+Pj4NCj4+Pj4gVGhlIE9TIGlzIGxpa2VseSB0byBzZXJpYWxpemUgYWNj
ZXNzZXMgdG8gdGhlIFBDSSBjb25maWcgc3BhY2UgYW55d2F5LA0KPj4+PiBhbmQgdGhlIG9ubHkg
cGxhY2UgSSBjb3VsZCBzZWUgYSBiZW5lZml0IG9mIGhhdmluZyBwZXItZGV2aWNlIGxvY2tzIGlz
DQo+Pj4+IGluIHRoZSBoYW5kbGluZyBvZiBNU0ktWCB0YWJsZXMsIGFzIHRoZSBoYW5kbGluZyBv
ZiB0aGUgbWFzayBiaXQgaXMNCj4+Pj4gbGlrZWx5IHZlcnkgcGVyZm9ybWFuY2Ugc2Vuc2l0aXZl
LCBzbyBhZGRpbmcgYSBwZXItZG9tYWluIGxvY2sgdGhlcmUNCj4+Pj4gY291bGQgYmUgYSBib3R0
bGVuZWNrLg0KPj4+IEhtbSwgd2l0aCBtZXRob2QgMSBhY2Nlc3NlcyBzZXJpYWxpemluZyBnbG9i
YWxseSBpcyBiYXNpY2FsbHkNCj4+PiB1bmF2b2lkYWJsZSwgYnV0IHdpdGggTU1DRkcgSSBzZWUg
bm8gcmVhc29uIHdoeSBPU2VzIG1heSBub3QgKG1vdmUNCj4+PiB0bykgcGVybWl0KHRpbmcpIHBh
cmFsbGVsIGFjY2Vzc2VzLCB3aXRoIHNlcmlhbGl6YXRpb24gcGVyaGFwcyBkb25lDQo+Pj4gb25s
eSBhdCBkZXZpY2UgbGV2ZWwuIFNlZSBvdXIgb3duIHBjaV9jb25maWdfbG9jaywgd2hpY2ggYXBw
bGllcyB0bw0KPj4+IG9ubHkgbWV0aG9kIDEgYWNjZXNzZXM7IHdlIGRvbid0IGxvb2sgdG8gYmUg
c2VyaWFsaXppbmcgTU1DRkcNCj4+PiBhY2Nlc3NlcyBhdCBhbGwuDQo+Pj4NCj4+Pj4gV2UgY291
bGQgYWx0ZXJuYXRpdmVseSBkbyBhIHBlci1kb21haW4gcndsb2NrIGZvciB2cGNpIGFuZCBzcGVj
aWFsIGNhc2UNCj4+Pj4gdGhlIE1TSS1YIGFyZWEgdG8gYWxzbyBoYXZlIGEgcGVyLWRldmljZSBz
cGVjaWZpYyBsb2NrLiBBdCB3aGljaCBwb2ludA0KPj4+PiBpdCBiZWNvbWVzIGZhaXJseSBzaW1p
bGFyIHRvIHdoYXQgeW91IHByb3Bvc2UuDQo+PiBASmFuLCBAUm9nZXINCj4+DQo+PiAxLiBkLT52
cGNpX2xvY2sgLSByd2xvY2sgPC0gdGhpcyBwcm90ZWN0cyB2cGNpDQo+PiAyLiBwZGV2LT52cGNp
LT5tc2l4X3RibF9sb2NrIC0gcndsb2NrIDwtIHRoaXMgcHJvdGVjdHMgTVNJLVggdGFibGVzDQo+
PiBvciBzaG91bGQgaXQgYmV0dGVyIGJlIHBkZXYtPm1zaXhfdGJsX2xvY2sgYXMgTVNJLVggdGFi
bGVzIGRvbid0DQo+PiByZWFsbHkgZGVwZW5kIG9uIHZQQ0k/DQo+IElmIHNvLCBwZXJoYXBzIGlu
ZGVlZCBiZXR0ZXIgdGhlIGxhdHRlci4gQnV0IGFzIHNhaWQgaW4gcmVwbHkgdG8gUm9nZXIsDQo+
IEknbSBub3QgY29udmluY2VkICh5ZXQpIHRoYXQgZG9pbmcgYXdheSB3aXRoIHRoZSBwZXItZGV2
aWNlIGxvY2sgaXMgYQ0KPiBnb29kIG1vdmUuIEFzIHNhaWQgdGhlcmUgLSB3ZSdyZSBvdXJzZWx2
ZXMgZG9pbmcgZnVsbHkgcGFyYWxsZWwgTU1DRkcNCj4gYWNjZXNzZXMsIHNvIE9TZXMgb3VnaHQg
dG8gYmUgZmluZSB0byBkbyBzbywgdG9vLg0KQnV0IHdpdGggcGRldi0+dnBjaV9sb2NrIHdlIGZh
Y2UgQUJCQS4uLg0KPg0KPiBKYW4NCj4NCj4NCg==


From xen-devel-bounces@lists.xenproject.org Fri Feb 04 12:55:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 12:55:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265492.458873 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFy7B-00019m-Je; Fri, 04 Feb 2022 12:55:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265492.458873; Fri, 04 Feb 2022 12:55:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFy7B-00019f-Gj; Fri, 04 Feb 2022 12:55:01 +0000
Received: by outflank-mailman (input) for mailman id 265492;
 Fri, 04 Feb 2022 12:55:00 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1gJ0=ST=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nFy7A-00019V-3g
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 12:55:00 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a8cc7e05-85b9-11ec-8f75-fffcc8bd4f1a;
 Fri, 04 Feb 2022 13:54:59 +0100 (CET)
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur02lp2056.outbound.protection.outlook.com [104.47.5.56]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-37-sMrmpkXENg6vjoidA2Kl1w-1; Fri, 04 Feb 2022 13:54:57 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AS8PR04MB7798.eurprd04.prod.outlook.com (2603:10a6:20b:2a3::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.14; Fri, 4 Feb
 2022 12:54:56 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.014; Fri, 4 Feb 2022
 12:54:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a8cc7e05-85b9-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1643979298;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=a6qy4LhzAK0whgBQ1zjKt/DIf7HAvxgfiwFoU6aPCZY=;
	b=BmO3cCV2zQbtcGPNHISgJ9XwUdKBaUmKqtuUllYsHK18bwOY/I8FWWEowDN+e3HsSPWAmf
	Dfz68bFPqFQVsLEx2izAWCn51eH4cs9ZhWbl44hqwx8TiPoIKijvovm9UYsqIwNQWPL3wZ
	MSYxyeOQ2RoJImifNbX58DUvH+yIhqw=
X-MC-Unique: sMrmpkXENg6vjoidA2Kl1w-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=J6wYipk8GAXwjEQnPLWa3ZjGUHLBXu8gAgVvzhLF1J+JuJ3/NtQBVQbbpMw4Eq6HZ1J9JJ2baxABW8x5cwdloJS8QNnVBT9bCt2pYsA1bWgBszQbKl0c2SQYVJOxki/aZ0UjhLzE/9cIh/XRIokTExhYH8w6HDV3f8QISwDMwKxPBzx94VXRbvjY5b1DVEBEr1cay452AnpXLiuNbmGLoH0/S7B6gyW10Gl3aYe3QXruhWnp2IKzeq+VMAoATvHMjpgh47DbNXcGQad2ZhGMzYb3Hdd1kJ6YUppX5VB0wLREHPTz7n0r6tCwg62Lt5yzUsw6NX8EWylVaOA9AcTkqA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=a6qy4LhzAK0whgBQ1zjKt/DIf7HAvxgfiwFoU6aPCZY=;
 b=DdcTA0SBpYFNnBL5aG5wWrYLcT3Vt/u5XHm50gz9JNjK7w/sHapvXUcUfKeGEUu4039S+jlCjdnKdDqfR4KIQ3ZYXRQeSlPOvsZRJriT+FcvyDJvmoMp3AszhBUAqXaHRFFNOWBRVh8gC/LAUjO6UlIFeuZ3Qo6PcWPbSVkvEEY4bXzksjBcC4tyF1hjLowb1AzIXG6MNMXlA5cgHh8iz0mvMPPRI7jNZ1Mwwm/OgJhakPJiPQa1DFkdU6CvrMlEjBd+CWeQPDFxjX2CLZEdvRe/1nkunL0bCg/pluqf87kzS3i0A4VM8zkPB5pIhw9VTaoeLa2UnmyOYrvWNuEROg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <11398184-dff2-cbe1-bca3-e2862cfbb104@suse.com>
Date: Fri, 4 Feb 2022 13:54:53 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH] xen: Modify domain_crash() to take a print string
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Julien Grall <julien@xen.org>, Volodymyr Babchuk
 <Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20220203133829.7913-1-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220203133829.7913-1-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR04CA0011.eurprd04.prod.outlook.com
 (2603:10a6:20b:92::24) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 69cf52af-ffad-477b-82d1-08d9e7dd8b26
X-MS-TrafficTypeDiagnostic: AS8PR04MB7798:EE_
X-Microsoft-Antispam-PRVS:
	<AS8PR04MB7798EF01E97B0983351BD40BB3299@AS8PR04MB7798.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7219;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	SRaghqyAP75iYJgONX1xICtK64UBNMhHsdOekBdRuHXRb4Kk6K8m7DpbJfrFlaTKn6y+azqEEtFkOzPfLDwflwNRSGvmXu6QJB4EqSijuYFvbHA9+fDGp2uWsrPP7DKfZAz++ESvpPu3HqkxBLqWrJfV391keqqqy8IzfpwiOudYU+TP73fyawpV1HT6YCBqjJ88GxctCgc124Ek5cPeZPCCyLXUvyES0mJ/xQPBFRaOpEHWk9/UlA5SzGXJ8MPasLKDy/iXYrE2yQBznmguqeq90YHcBQ1fnfiKut0sVehSULvS4JU7B7o2AXzj//TlcV4IrugNqDN4zkmIJbdpRi8Sx4IzjhWbYjXx4VTKZhkkbSbGBYVYAuL3q2ZyyMJq6p3PxC0zr1Y57WjGh/zf06YOnvrtmLx58xf4ZUR/it30qZrU9calPOWhxmYo2zMDtrAKQeWui+RiNd5RuGVCOMZjzj0KnvQQaUlwGR2aJZNZXyBt2M1FJS/ZZL34GN+n3mmjIN5dmpCo+jAsjVwmn+js1oYXgWVtXTHeDSF1nIWxMCX34tIePTLqkoINYqAaMsyaVGjqogNZi+DRbcu3wgLqtx+UqhXP1xTugjKpIFsf8VEQCDGd6eGbOCPKsdFvOu+xREEQjvlAeI52PGcuYLoN7zIrmnPumAJyf8iCflI/j1cFVcLJn6Da2kaDtdI6dBDMXY3U/6w05XItiFH5l5GjIRNHw4dcG1wIjHGTyslKx526xwMpIydEm8NB8+M9
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(316002)(53546011)(6506007)(6512007)(2906002)(6916009)(36756003)(26005)(31686004)(6486002)(508600001)(2616005)(186003)(31696002)(86362001)(54906003)(8936002)(66946007)(5660300002)(66476007)(4326008)(38100700002)(8676002)(66556008)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Qk9XL2o5N3dqNkJmamtzYm1pTGVXelRmVVBvMVB1eHl5NkV3TGZ6eXBFTlQ4?=
 =?utf-8?B?YnFoZ0VVVWhmTkI3bjRQdGljWEE2Rm13WVN1aU5NbHpFZG5wVXUwMW5CQTdB?=
 =?utf-8?B?dkpFWEJ1bDIrWG9Kc1FYSWdZL1NGRWpUdFNDRHliOXFqNUJTRjAzWG9uaFJH?=
 =?utf-8?B?MGF2VGFPdFhkUE9CcW15cmxwTW4wdkh0N094OHlFMzlkeDZqejBpU0VvRGVs?=
 =?utf-8?B?dTJIL3dCRjZwYzlDN0t0cXNJVWRmZk5VUmVmazdGNzFTMnNWZU00Q2o0UTZH?=
 =?utf-8?B?ZGduSEEvNDVVN2lsV2hHTFpJUExWNjNNVXRlWnVvNXVqUzN4SUZjdS9ueGFh?=
 =?utf-8?B?ZnUxd2dwNElTaktVVzk0ck90eVl5Njl3YzBVTWNtdUhqOHc5cHgvaTBSVHdV?=
 =?utf-8?B?ckYweUUyNXdiZ01uTHY5OFVoK0srZXkxMzA5amFVQjRQbk1DT0N5V3pNVEtr?=
 =?utf-8?B?c1UzTG5Yblk1QzI0TndSZWRQcFM2ZCtTclpEWFlqaTF3THlYSW1MVVBGNUI3?=
 =?utf-8?B?dHV6eFRPQkJocGFvSnFUMk41MnhJKzltQVV1TEdpblkxRXhiWi9JS01XbHZq?=
 =?utf-8?B?OHZycHUyRjBmN3RQVFRGb3VxMkphcHhzR01Yc0ZQVWx0NXhDckR2VUtvc0pV?=
 =?utf-8?B?bVFuOHp4bXNwMjJpVEhtQ0JMcHJUR2taZzFYYnp0bzlmRWVnbXkxZnJuUTRt?=
 =?utf-8?B?aFJZbVdQeDVnK1NiQWl3SnJDTXVYQzZxV0s2b1pySEZjS21xVCsxUDd5SEMz?=
 =?utf-8?B?ajZXOTU0dTRMcFBzS2k2eXZyZFEvZldoRFFqTzNYazVNVlM1ZW54TjU2czdv?=
 =?utf-8?B?aXpjVEZYcjEzKys0dDIyRjdIcWpnZnltNnNpa2RuVytSVGZGU3I5b0RpT09O?=
 =?utf-8?B?Nmd2d1pTTldTVnR4R2RQMGRKNDd0VVJPeXR5SGpIdjlLT29jU1F0VjJ2U2JZ?=
 =?utf-8?B?NXR6NC9iR21tM21DREtTOFBUL1k1Z3NqMWhYek5Hakc4U1d2REdSTHIrblNY?=
 =?utf-8?B?eVlDTVJhZEgrVXYzUjBBWDl6bFdNZ25pM29Fbll6b21sTVowMHhRa3VhUnlp?=
 =?utf-8?B?ZnhOWHJoM0dJRVZ6NGlLalJmUVBxMTRvUmNmMStIbEhON3Z1MFRhR2hJd3U0?=
 =?utf-8?B?Y3ZOR25Sd0hhdndhelNXeUJ1RHNCdEk3cm9TQ3RIS0NibVcyc0k5RGRLTms0?=
 =?utf-8?B?VHcwSENwOTcrRUpPak8xbFRnU1p2YnEwNEZoNkMrdXZyVUNLYysrTlBramJR?=
 =?utf-8?B?VWU3UWxkbWZkTUJleDJ4S0NlUmxWYlkwOXZJVmZna2ovSUp6VHpsQjVCMXpw?=
 =?utf-8?B?K2JCa2ZiT3pkTTR0QXFsaHRXSk80Ump0QWRRUzRIQlovQThxYkNHMzRzb0s2?=
 =?utf-8?B?ZGYxWjBKMDV1TUttbGRZdEx3OWkxMTdqaHNhTENTNSt5SThOUWVoSXJsRmNV?=
 =?utf-8?B?MkFjOXduNFY3aEJYRVRXQytyOEpSL0ZnRTBManFON3BpVTVWS3VWWnR0US8v?=
 =?utf-8?B?eWo1dXVYb3JzSElDYVFpbnJxQVRHeERhS0gxRUR5SXJ2aExvZnRwRnp4dVp2?=
 =?utf-8?B?endtQVkxenROTU9vSjMvdGFQZmE0QTQwYmx3MjU5ZGwwTGo1UVZTMUxRZmRM?=
 =?utf-8?B?dG81blJYSmQweklKRWh1MjRpTFJYYUVDeWM1K0RveURSWHdheklFcGdqUEcx?=
 =?utf-8?B?ZHF0R3hkcXBiKy93c3hQWnZ3aG5LRFpEV0NlOHNBdmlmMk9HVllKTFJseDVD?=
 =?utf-8?B?RFR1dG05UnE3Vmk2QVBBd29UTTBSSmRMNnUvUjdQRUV1T2R1SFdMQ1hOL1Jp?=
 =?utf-8?B?Y0tyZnlXSm5jamdOQU9vbGZ4bjJCcWo0TUt2M2R0NVcvWjlLUTBiNEVxT3pU?=
 =?utf-8?B?ejgyeloreThnYnV5WEcyQjZIZkRHVXlnb0h2YkVoLys3N0lJWWVxc2Q1Vy80?=
 =?utf-8?B?QStYZXN4VCtkc3dTUlZTNlhPNXl2cEtzYVcrRlk3ckZRczZCVHVSakNlTkEy?=
 =?utf-8?B?MFJsNE0vZXZsY3dHRExHbnVVREk1V3NHMjVYRkdJRlhxUGg1aW1ReGY0bm1s?=
 =?utf-8?B?alB4alJPY0czTTBrSk16NTZINThLc2FQNi9QbEdEcTR6Qk5BWndHWnRJdCtL?=
 =?utf-8?B?UE5LdDc5U2xCVGl1blY4OEZSK283QWtxM1ZEZm5zMVFaUXg4UEZKOUZNMkp2?=
 =?utf-8?Q?0kYIHs21n3sCp4oWZFttbsU=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 69cf52af-ffad-477b-82d1-08d9e7dd8b26
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Feb 2022 12:54:55.9075
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WgYeCfYC4Pav2y3JEduAVwQ2kiUSt6pqhdThFf2hbxT5BWVRrd1xhFQ3tw+sjRZDIhCaQ0DiNYhbzmi2M2Sqng==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7798

On 03.02.2022 14:38, Andrew Cooper wrote:
> --- a/xen/arch/x86/domain.c
> +++ b/xen/arch/x86/domain.c
> @@ -1693,11 +1693,8 @@ static void load_segments(struct vcpu *n)
>                   put_guest(uregs->fs,   esp - 5) |
>                   put_guest(uregs->es,   esp - 6) |
>                   put_guest(uregs->ds,   esp - 7) )
> -            {
> -                gprintk(XENLOG_ERR,
> -                        "error while creating compat failsafe callback frame\n");
> -                domain_crash(n->domain);
> -            }
> +                domain_crash(n->domain,
> +                             "Error creating compat failsafe callback frame\n");
>  
>              if ( n->arch.pv.vgc_flags & VGCF_failsafe_disables_events )
>                  vcpu_info(n, evtchn_upcall_mask) = 1;
> @@ -1732,11 +1729,8 @@ static void load_segments(struct vcpu *n)
>               put_guest(uregs->ds,   rsp -  9) |
>               put_guest(regs->r11,   rsp - 10) |
>               put_guest(regs->rcx,   rsp - 11) )
> -        {
> -            gprintk(XENLOG_ERR,
> -                    "error while creating failsafe callback frame\n");
> -            domain_crash(n->domain);
> -        }
> +            domain_crash(n->domain,
> +                         "Error creating failsafe callback frame\n");

I assume it wasn't really intended to hide potentially relevant information
(the subject vCPU) by this change, which - by way of gprintk() - did get
logged before (since we already have n == current at this point)?

Jan



From xen-devel-bounces@lists.xenproject.org Fri Feb 04 13:01:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 13:01:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265503.458885 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFyDl-0002if-Ew; Fri, 04 Feb 2022 13:01:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265503.458885; Fri, 04 Feb 2022 13:01:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFyDl-0002iY-BG; Fri, 04 Feb 2022 13:01:49 +0000
Received: by outflank-mailman (input) for mailman id 265503;
 Fri, 04 Feb 2022 13:01:48 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1gJ0=ST=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nFyDk-0002iS-GB
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 13:01:48 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9c253017-85ba-11ec-8f75-fffcc8bd4f1a;
 Fri, 04 Feb 2022 14:01:47 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2175.outbound.protection.outlook.com [104.47.17.175]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-15-XTPyIXk1OtadObmG-2dB5g-1; Fri, 04 Feb 2022 14:01:46 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM6PR04MB6440.eurprd04.prod.outlook.com (2603:10a6:20b:f4::25)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.14; Fri, 4 Feb
 2022 13:01:44 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.014; Fri, 4 Feb 2022
 13:01:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9c253017-85ba-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1643979707;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=CRGoAlHuaCWvQyb6t/g00gRtygicmk7STo9sNL4yrJg=;
	b=N7kDlTHv6fj8uqmouWNBJRs5zWANex5YgpbUlFFB1yD245cHijoB19h4erovQVkXiexIre
	W0VGC2AyNZ1g36eRT/7/eCvfWUDAf1LHvvAdPxmLPYQiljhg35tHQiJR4sPQLIS/IzdRBT
	5Em2GYM2mosbNhppARrLpkrAGfudn/A=
X-MC-Unique: XTPyIXk1OtadObmG-2dB5g-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=oDYJza4JlJDiu0JCpSM6/a3G5NKhOeV3E21D/W9OhRRBkQPgKrnaFI70P/xYqrFpjySeXz2lUNf6DwzyIk7+a2vG5I03QxOLs3EirkDCMGJrG+AkIdX7mC486bMIqjvAHkxNirX+Y8XmOHgk15xFvd9CBv+QbwUufebhWoMIFRBF8qSJ7wmfz7kWB1qqjWKv9aewch/9jznH3H9IOpMqGzCefkBA6xUPJE/onZtCEl1OQquLyNFGeyoK86F8Va0XmK96cQDAC+1UC5SiaDVNZghZQsVyurhUebcuvJ1Do0rYWR5kSGdkGGiqlwL4D+8ri3hzMT7S0RHOQdhsWuw04A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=gZNMo/XRVYgUyoOFEdCXcYZ7ZInSsT2jNi4wIVZ2avw=;
 b=F2Kr78bPjZ9B1Qxty+PIiuDIszMQ/cnKit84lfhWJDSbjw56Y1yiCyYQ7zoa4N7Buaoq0xPlTgxlOSPfXirbfFEfEG5jaPTvHasNuZ60g+y8NEro46VMW5dSEU+Liul/q2WA8oL1iQ2GuqtCL22Lox1T1D8z0iSnwH0+nlY0cMBtw2XBGFepQdxRDzSboSqMLpA9Y7LAu+vswOZHOZRjo9Hj7R7rd4JxG+zaTc9afjipfeDWo+3sN5KoNKLZYImVJYIU20ecSgSWD2bOiYJJE+so2jg6/TURZ9ZQS4JXtRx8MiS8kaNUFA6087Yu4htrYYCs0R9wpdHX/w4niKiqGw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <fed06b8e-cba6-447f-0f17-e7a4ff557205@suse.com>
Date: Fri, 4 Feb 2022 14:01:41 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH] xen: Modify domain_crash() to take a print string
Content-Language: en-US
To: Andrew Cooper <amc96@srcf.net>, Andrew Cooper <Andrew.Cooper3@citrix.com>
CC: Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Xen-devel <xen-devel@lists.xenproject.org>, Julien Grall <julien@xen.org>
References: <20220203133829.7913-1-andrew.cooper3@citrix.com>
 <c0d82900-64d1-fe16-9283-deb7c324ff8a@xen.org>
 <ad7467d2-1cae-c8ea-1217-69f0924044d4@citrix.com>
 <348f062c-9aed-0275-f0ad-87a0eff8e986@suse.com>
 <8a28b63b-a5f6-db0f-3108-646475912abd@citrix.com>
 <c20b2017-7313-41bd-c854-48029a5df206@suse.com>
 <5d721986-3298-51b1-22f9-58ecf8cb32c2@srcf.net>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <5d721986-3298-51b1-22f9-58ecf8cb32c2@srcf.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6PR10CA0062.EURPRD10.PROD.OUTLOOK.COM
 (2603:10a6:209:80::39) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: fec8a980-bafc-4f8f-cc99-08d9e7de7e7f
X-MS-TrafficTypeDiagnostic: AM6PR04MB6440:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB6440DD595BCED0567885F428B3299@AM6PR04MB6440.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4502;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	9m/kPWtKPLhTRvFl5uKAMIrROOp/efJzeLrQAq64ze1rSTys5ajHm0nlxCPP+6zYPonEGiNeBoDBC0X7pjzZZvUOzxYexqcX9KTe93mTbSrxECT3w/uQF3OQlcKaVKUKx5Nkp3Rk5bFZVHtV5LRPYMoYYlT7pxKJmB9FRfNSPsVB8zufaOCDwGkBsGhBq3KjujMgit69z7sW9C294KfKZz8OJ/wVMRAphzxpiVBDssO6NJV7d1jJyvv1aA1JMELkFNZYGZWVFlhoLqzM6t1v+i+NjrcmP0YxMb/t2oA3/TjaICy5CZrTbs7lASrfyONzTLKEozp1zHydEJBeEyZpu2sGN1It413GPtp8GLt5ma0G9thcSMppMfFrd+TH18Yf2uB+oaDCL4ZnH3gujVtoqCLtjHZsmAgRczSXOWUeEd7n24XjXhlVESqKEHJUWM2KlfhcKqnsXne3J0xGzo1auXeq4LVyGs0VfgGM+LgM0O1JG6E+G38WSGb8xtWkYz2km+FjF99K/endiailg7QJiL5twTbrcF1vrhJtTlWCpESS0MV6/LwZVpXX5U6svt8P3jklMkFUdV7ptiY/Spwe0dQjfnLG1NZUkQE/4OoL8KSqAl0sV44OIAwb9A57FNtZCP99OOmS0YxADlWo7dGie8pWH13Cke6i3+vfVM2gytyU2Q1YL5SZqdFcQKfWgaZVUZfleqiXUadUm7Nq91f/WM9K1f79VVq07sqcMda8tur8yQlSCw99nEplZDXlUcv6
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(83380400001)(186003)(2616005)(38100700002)(31696002)(26005)(86362001)(31686004)(6506007)(508600001)(6486002)(66556008)(66476007)(4326008)(54906003)(36756003)(8936002)(8676002)(66946007)(110136005)(53546011)(2906002)(6666004)(5660300002)(6512007)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?UsJ2TDqH1gdasImYF885GmxJFRQ6k0AlzLV9lTVI/hUcwIA+00cEtAsIh2sq?=
 =?us-ascii?Q?KnwP5oGqiL5buhQ/BQuxJ3vGGPQNeIEFQ2mPuUTO1bagalIWH+Tzi2Mgcnl9?=
 =?us-ascii?Q?4v/PdTdxtMPZ+HaGzThXZ4abhlRFXWsba/+1nmtgLP4CpxNbatyTozcfWBOz?=
 =?us-ascii?Q?cxX0qH6GnwxTjFjomz3RAvU14TjbAAWZ0T18c620JbjYKpKJ+POORAjf4t0T?=
 =?us-ascii?Q?cltZjvYWdtcIvImrdklKP5GH78WNvmjVkF4yW8onlY7wMPPKKVjx6qRTvCFi?=
 =?us-ascii?Q?jnbSZEkNnyYdMXYR75BeqifC8tkONOhTHrZfTQPjyzz4/RaQ7CNgy3DDDYjo?=
 =?us-ascii?Q?wvkb33aNcNXGBXt6R2miggu4vpyRAG/3mNPulBccIIBxgeTuX7bW1mS+f4du?=
 =?us-ascii?Q?uZhWmJYEgM8PH+MITd/xfbNBgXRfodZxZqUF9ow03lCeUaKqWDSdh75nAZht?=
 =?us-ascii?Q?DYg3Yp7FCYHU3Uh4Y6poO5Kfi+pfsW1u6WJ/+b+yfB9f1TYUD/vGWriTUiqd?=
 =?us-ascii?Q?z68fueRKhHw36FEdA4rcqAaLOxcQzMQklb7WtlaDRcEXA7yQBvv4LGxYfb5z?=
 =?us-ascii?Q?JhpCnQk0RsjLrFaenix6hhK2e+C52rgXJfVsSWRhLlaGsGyvWPHcvCRDxQ+2?=
 =?us-ascii?Q?2jZFk1egcZ5ncO4Ua5SASF1Op+65pzgUmj7VLgFm1XqCVy7z7rY02amSTQXN?=
 =?us-ascii?Q?BGsZZXM6ZgxBYXNv32IJjeYM+4yiGbP/sSvdgFArhjttHTB9X9+h0Fer+bHB?=
 =?us-ascii?Q?3/8bh31Mpiqzftx6MeZakH3dngym/u56jWIXISsSKlp23SAnciuUO8aGYAG9?=
 =?us-ascii?Q?y/OkdcXnRvVg2F0zG/vwJQrEma/vwe59XwEUlFkuDGFOu0TL24ToFYqXnrvN?=
 =?us-ascii?Q?hLoU0LQye7O3QszBBvWAIHssPzdmjFfe4rgSJ4sHN/PM2QRqxUesHUTJpaFt?=
 =?us-ascii?Q?RThpknawGWz9e2TXdAoHyg27aKbyKmn4p/bGNF2EQ5Xmsx4legmAEQ95pJ9o?=
 =?us-ascii?Q?w9U0pZgwEu8rJZFsOCnCjPHwdMzWUFaPNtgyGf7dZCOQiwnR1uw4Y1Zny3BG?=
 =?us-ascii?Q?RB3pP6tnG/Pv7a7lcuJVacYTQkPwx6vGNyu/0DXaOfYvMhag7dBJUrjFiTKg?=
 =?us-ascii?Q?Mt7OokxJfRKEWopJh+pddjFNVo7QVF0XgcBF4mVKSnFHaVArxSCpxm2aXxxF?=
 =?us-ascii?Q?giXlHo5mPetWgM0krX0Cr5LxpMOlrxC7mTkLL7CPIskeUV0dtJ8RXiozCs04?=
 =?us-ascii?Q?w5+OJXHOrCzqr71Mbl4HfNh7S5lkyaeSIl5zg8fkgaVFNsljQCDu7C+7ArpJ?=
 =?us-ascii?Q?IkE1rzimDuyDO02PpyIXBMK3+HPY4ahyPY8Cjn3GS++NimvD6xGvD69bYckK?=
 =?us-ascii?Q?7pFAxaB0YKGWvTvKB4F0BX2ggm5Ldm+R9HncVlGkTUIrK3KAetCRiOfLEyzA?=
 =?us-ascii?Q?FWwNcg7ni2RuIygsLKeTC+6/kIzqab3KqBoHTbiwvpHCprmMv9vAPqWcj6Rb?=
 =?us-ascii?Q?foI84AUNUU5ak8mr4g0BW6hzDCL2sir29qJbKOIvpEpVmWITeuiOTpINSjXc?=
 =?us-ascii?Q?3g0bKY2syWV7zKIcolAvmIaz743UnspsmLYJydygnF0ckxtlJ8OdBCffW24v?=
 =?us-ascii?Q?OCxU3mpOcB/3XFQFHrZEXxI=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fec8a980-bafc-4f8f-cc99-08d9e7de7e7f
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Feb 2022 13:01:44.1633
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aeCCkX4udrIueCRkxC8C94jZRApI4lb/M+74+n9ppSNARd9cWoCc+HRNR6eMNZEMvu5VjNZMG3yR4qD1OoI42A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB6440

On 04.02.2022 12:56, Andrew Cooper wrote:
> On 03/02/2022 15:06, Jan Beulich wrote:
>> On 03.02.2022 15:41, Andrew Cooper wrote:
>>> On 03/02/2022 14:19, Jan Beulich wrote:
>>>> On 03.02.2022 15:11, Andrew Cooper wrote:
>>>>> On 03/02/2022 13:48, Julien Grall wrote:
>>>>>> On 03/02/2022 13:38, Andrew Cooper wrote:
>>>>>>> diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
>>>>>>> index 37f78cc4c4c9..38b390d20371 100644
>>>>>>> --- a/xen/include/xen/sched.h
>>>>>>> +++ b/xen/include/xen/sched.h
>>>>>>> @@ -736,10 +736,15 @@ void vcpu_end_shutdown_deferral(struct vcpu *=
v);
>>>>>>> =C2=A0=C2=A0 * from any processor.
>>>>>>> =C2=A0=C2=A0 */
>>>>>>> =C2=A0 void __domain_crash(struct domain *d);
>>>>>>> -#define domain_crash(d) do
>>>>>>> {=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \
>>>>>>> -=C2=A0=C2=A0=C2=A0 printk("domain_crash called from %s:%d\n", __FI=
LE__,
>>>>>>> __LINE__);=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \
>>>>>>> -=C2=A0=C2=A0=C2=A0
>>>>>>> __domain_crash(d);=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \
>>>>>>> -} while (0)
>>>>>>> +#define domain_crash(d, ...)=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \
>>>>>>> +=C2=A0=C2=A0=C2=A0 do {=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0 \
>>>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if ( count_args(__VA_AR=
GS__) =3D=3D 0 )=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0 \
>>>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
 printk("domain_crash called from %s:%d\n",=C2=A0 \
>>>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 __FILE__, __LINE__);=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0 \
>>>>>> I find a bit odd that here you are using a normal printk
>>>>> That's unmodified from before.=C2=A0 Only reformatted.
>>>>>
>>>>>> but...
>>>>>>
>>>>>>
>>>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 else=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0 \
>>>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
 printk(XENLOG_G_ERR __VA_ARGS__);=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0 \
>>>>>> here it is XENLOG_G_ERR. In fact, isn't it ratelimited? If so,
>>>>>> wouldn't it be better to only use XENLOG_ERR so they can always be
>>>>>> seen? (A domain shouldn't be able to abuse it).
>>>>> Perhaps.=C2=A0 I suppose it is more important information than pretty=
 much
>>>>> anything else about the guest.
>>>> Indeed, but then - is this really an error in all cases?
>>> Yes.=C2=A0 It is always a fatal event for the VM.
>> Which may or may not be Xen's fault. If the guest put itself in a bad
>> state, I don't see why we shouldn't consider such just a warning.
>=20
> Log level is the severity of the action, not who's potentially to blame
> for causing the situation.
>=20
> Furthermore, almost all callers who do emit appropriate diagnostics
> before domain_crash() already use ERR.

Well, yes, this looks to indeed be the case (albeit frequently with
gdprintk(), in which case I'm inclined to say the log level isn't
very relevant in the first place). On this basis I'm willing to give
in, despite continuing to not being fully convinced.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Feb 04 13:04:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 13:04:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265510.458896 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFyFw-0003Ku-SG; Fri, 04 Feb 2022 13:04:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265510.458896; Fri, 04 Feb 2022 13:04:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFyFw-0003Kn-P0; Fri, 04 Feb 2022 13:04:04 +0000
Received: by outflank-mailman (input) for mailman id 265510;
 Fri, 04 Feb 2022 13:04:04 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1gJ0=ST=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nFyFv-0003Kh-WA
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 13:04:04 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ec96f9de-85ba-11ec-8eb8-a37418f5ba1a;
 Fri, 04 Feb 2022 14:04:02 +0100 (CET)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2104.outbound.protection.outlook.com [104.47.17.104]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-19-iUA14Y4JNkiYSZiCvQw0SA-2; Fri, 04 Feb 2022 14:04:01 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DBAPR04MB7301.eurprd04.prod.outlook.com (2603:10a6:10:1a7::9) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.14; Fri, 4 Feb
 2022 13:03:58 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.014; Fri, 4 Feb 2022
 13:03:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ec96f9de-85ba-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1643979842;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=F5ZDGJxcxjXISvHmy4Not16q3L5iE6sMWbYjv/EzeYU=;
	b=WiHwRLKm4bhMumcISuOeuznoMIGvt5hQbvLNi15cuLw+SptrXrokdkmfWW44+P5tJ5E1Fp
	3bcI4C+StALtvh+ml+VF0yZbBPbSwyidcy1L6BKoLi3GWaNX9WTu2yI1Xg5mq1IxLoJqXG
	RSkKlAyLlrzc7U5R93FSL+/uoZsF01E=
X-MC-Unique: iUA14Y4JNkiYSZiCvQw0SA-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ldkDsMFVwkuwvGeDqXn19LvBzo2wvoW7T8dTPIBG9jd0PVq/41/LXEpSwexg7t0+433iZobxRdPVwDSUv3VnStfmx4U6zex8hpP4woTAOGH4XQNug2O16PalrYTe3CqZWWRSNjfto5nWAreIUvMg05YBYqGD6g9BMWmbu4261e88uy0HDFZz26ptj/3BR5on6AZO0csM92dW5j8yPyc+kUTDa99DU7U4yXnKgTnkk8eBUP7eKoNIZw8uWGMNMSp5v43xIi7F/W8u/D4zat8kSMNxUy/Uw/fcHcWz8cg42RIYAO5Qv+3R6RuOsvXM12UVTh1uBGYrs0IsAQ37CKr0DA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=JseKSd140tNutMDTdDkXq+JSWQ6igfvum558lHwn68E=;
 b=bbFa/6DeAf/D8VXa31IoqBrxCno7g92TiFPEJM0hgoyIMSGN7D5rhA6LD2A1y0Vxur4NUdkx8liFFCsQ4FdA+hDvMz97xeoDbLvvcif4suMyUdfb8eQ03/gkOi+M9wqxIja3ZKilQH9YRa3zHKzXYcQB2LHX+Sv0su9OGZYLDZeB1lJxbI88xg9kHmW1F7Sc2XZeHLBTmBjNoWhzVrVIBgRnX46JuOD8ycPmCE8EvyFjxYc3OTOvxfcVaV7gv9J98HyH/pt/XBNgSmOP8CdPtPcKLFE0ICQNM+ykM6lChGV24mzxIBpCrXPz/CPMvIIMkPLCivC5e3aXC4X/I6Z6GQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <655e491d-2af9-aac1-3ea6-fd0b6f1806a5@suse.com>
Date: Fri, 4 Feb 2022 14:03:55 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Content-Language: en-US
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: "julien@xen.org" <julien@xen.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Artem Mygaiev <Artem_Mygaiev@epam.com>,
 "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
 "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
 "paul@xen.org" <paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-4-andr2000@gmail.com>
 <7209889d-8f17-61cc-72a4-97f6dbc1d54d@suse.com>
 <2cf022f8-b000-11b7-c6b9-90a56bc6e2ea@epam.com>
 <04726915-f39f-9019-436e-4399533c9fc3@suse.com>
 <9ed3f4ac-0a2d-ed45-9872-7c3f356a469e@epam.com>
 <c3a99712-cf7c-37da-aac1-f2ee00e6d53b@suse.com>
 <Yf0KcVD8W05A4fbB@Air-de-Roger>
 <1ed0e342-16cd-2f16-c05c-186667a22762@suse.com>
 <7e3562b5-fc67-f213-e872-f211450d9e2e@epam.com>
 <a8fc599c-f620-c4d1-2077-c57068f46a7f@suse.com>
 <deef8468-d607-e49e-f456-6a8013329ca1@epam.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <deef8468-d607-e49e-f456-6a8013329ca1@epam.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0117.eurprd06.prod.outlook.com
 (2603:10a6:20b:465::32) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c23e7437-09af-4bd2-5efd-08d9e7dece8f
X-MS-TrafficTypeDiagnostic: DBAPR04MB7301:EE_
X-Microsoft-Antispam-PRVS:
	<DBAPR04MB7301C7346CB6EDEA118CD035B3299@DBAPR04MB7301.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6790;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	9p436t/7XK3cJ7dq0dle75oO9OImJOi3qejc2NLFVEzHsQWW9dsdyTiBfcDJKy2p2G+W0tKrYy+Uh7UmSsdC22c8vTZ/G6wZ+d0PqKTk7cBfaKlPTRSbtiGo2ByY/tChmM0+QhpR67Q55fDpn5xj+6V0I96wyaGeyZP8VhlJs57IA/7NjSYQKRpK6CFqaxIVWe7QYjC0BzdGDUqKBK6X8wNbllmmaUgtXHYoux44mVoc4BwUpjdZXz9e/oRRpkh6AfjaUnoFIotGocso2/tccBilzK9P1U0DiqzhGe/FI42cfv7K1m237XYPcyUGj5cJ2b1Z6EcCJbQF6+1vWdXhwLNz+PLFBeBqKr8AkMypDz3zVT5lVLPzuYEGIfMf/9SxDtl7+26GQoQQBl2OvJR9ZroopjR3CyWF9Mcy5PwbEr+qbfv2WZ3wNnF49K59fNNIyYRoVEQIv7JVmBYVnZ+cJkGWoG0zNe+X9YfM6yNJbxVg+vhv1+V9It/7Sz72BSQLKME/66XBGJJNE/JcJY9L7BqidUGgMBLDVFIXgqfzfpc6E+iFo1G2BAXqHKVA3B/QTmOxF5QdMN7UjjfEbQ3Eey11pVJrQwAIGzokQlfeZe5zQ/XH+J73UKSP3csz2LZLHuDAf7RPCPLRTGxmUG8r2rEivyLeeV1ruoJ0OEpMMB8lGrzwm+Mgx5DCM9njBODmqFkRaDgWfv9bFgh3zGkNd+hCPPvbUkpViuXoEx26aWMK475dj0AWyw7GZHYtRPfB
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(316002)(6916009)(38100700002)(8676002)(5660300002)(7416002)(66946007)(4326008)(83380400001)(31686004)(54906003)(186003)(8936002)(26005)(86362001)(508600001)(2616005)(6486002)(6512007)(31696002)(66476007)(36756003)(66556008)(6506007)(53546011)(6666004)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?OdDG3SYl/3YfuuH184GUN910xHuDwoxMp+Pw7fqZNT4uP2A04tfHjq1UqdHJ?=
 =?us-ascii?Q?wOFaJPu0RIdwgmJXnHATHL0Nm4PvTnZhmucpCZ49pzhwZ9770baZpn2GqalL?=
 =?us-ascii?Q?xf0afCX/Krc/1vTC6ExqrIJzDmChn9JZMbyLVZunRxzAbzRTy6mCqtQxgyvv?=
 =?us-ascii?Q?fxseRUiMy77r/hzoWAKu5j4pafFf65ri7u8qG9jnpjDWi3uwy2HshJwsK+9N?=
 =?us-ascii?Q?EDsXc84e67XuBuznxu49rk/T1XZnVeUI4eywqFu+rNAC7kZkTirs1JY08J9y?=
 =?us-ascii?Q?JNcu72XPlQS+cic7i9K6X6zje1pvJBmgLJCOUGjnLLaTvuzLMIceA6D4WN80?=
 =?us-ascii?Q?7ehw16U9D1d2vb5nWi7sfZOR2KfEwPj2Nm4HkI4OtWlKWw0eg/6a+LwYF1PY?=
 =?us-ascii?Q?9u4lXz8R5g4izifgYKNPCrhOZ17UL/jSKt+cgUO8CHKXWOCiyJquPa9yEjh5?=
 =?us-ascii?Q?tAlFNAcdUgkDV1bxdTSFEIZBJtxbPQ9CVlQK+Pdnq3QdxQxBmsnyFRM98F+1?=
 =?us-ascii?Q?smobehY8rOo53tpjF6+GLdMn25rPPNK5TNE2BXE4+1wyTe8ZKbdJ72oghXh/?=
 =?us-ascii?Q?qMaCpXV4KalMdwcRCZaa2Gzy2xTJvAh7qZg56eBfeFVe4HULC8TtPIGIw/6c?=
 =?us-ascii?Q?UERajCajpbqg+DS4b/Ds+I6KPDrniIy6X1Y8VCNUNWe3c2B+Di3Jg2HJOHsa?=
 =?us-ascii?Q?rskmEUwLKLc3RfTnYP02yWE2hQuOzXJdi9KunUquRASYuPYxoyedZ05mDiEs?=
 =?us-ascii?Q?cFYyBZ7ypBQSEKrPVsRljV6H7EYCs6ki/+Uah9kMoNnQL/tW7gRQ2WV/EFZU?=
 =?us-ascii?Q?VY/UUEOmQg2gHxnjMLKtHi0ad/UtuXd+kaxw9oAsHzpMJPVFbFNdZyJL8Ztb?=
 =?us-ascii?Q?2k5/qyROJ4ZBfXfC1bgS9/20qsWtZAisqU4C6M5oRgMI3CQUJkA/HAtytGq1?=
 =?us-ascii?Q?w2osqZ8KdenU6j2MaHDJDVdU6FfwkBLqEkrw3wbZ+ic5/3x6xNQKUCyfPpEb?=
 =?us-ascii?Q?t0pHHxm2yuSu1HdmYMX5YImrjft+T2BbEdN90VKKGLLgCQeoexwP27wjc/ti?=
 =?us-ascii?Q?3ojOSS9khbHDljQ6Npi2E5aRvs0uvn2BkOD2hjm3o2RiLTb73TuB9jm19nku?=
 =?us-ascii?Q?KXfbfw3uIBidzszkqap6BDjWg/KxWbSkF5QNa1IQ9MPg0i70sqNJWZZUsOtq?=
 =?us-ascii?Q?c5L5/mts1UWC1EHJrugvgmJ3Hilwpid6zx/jyJwK7GIoHKRWqxgcmizfbyjm?=
 =?us-ascii?Q?TrhJK6RS0zhyb6A8TKilB/dkr4HMWJvPFy9+PDpZU5nwiY8pXCfnTiF8m0Rq?=
 =?us-ascii?Q?Zr+iLGfwLiWO05i/oGOM/0MOQGm2agKDVgFTvS/K/22zWvweSJ/nXo0BMrgx?=
 =?us-ascii?Q?IP4V8uIY8itRwt8u9XiSLD/KucfSs1gl0vTMhIx32xlumb9iec7iQ0T5ebxg?=
 =?us-ascii?Q?VnLV+o0KO8Arm2H1Z5g20OiiigfZxuibMlg3X22oB0LPirGjENnSt8Nq1Iio?=
 =?us-ascii?Q?dY1op03yiqchNHyZBxyYUBaHeHHTl4xB3c3ukURxYsmu28fzsRr1TjAT5qEU?=
 =?us-ascii?Q?iQHMac+1ary+M46tyLVEZvuu2tBxNiPWyiwVd0RqN2pijBn/mW0vwm6t+Mo5?=
 =?us-ascii?Q?TSabh8T66s9td8DZISYj108=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c23e7437-09af-4bd2-5efd-08d9e7dece8f
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Feb 2022 13:03:58.5144
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1CqWHDS8AKFIAjaYzgvZJPyE+KbLv4DsNYencwzC39skX0r6Cgbkz+N+GIO7bQ0wv/7w6hbVMqxtY1+a1n6cTQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7301

On 04.02.2022 13:53, Oleksandr Andrushchenko wrote:
>=20
>=20
> On 04.02.22 14:47, Jan Beulich wrote:
>> On 04.02.2022 13:37, Oleksandr Andrushchenko wrote:
>>>
>>> On 04.02.22 13:37, Jan Beulich wrote:
>>>> On 04.02.2022 12:13, Roger Pau Monn=C3=A9 wrote:
>>>>> On Fri, Feb 04, 2022 at 11:49:18AM +0100, Jan Beulich wrote:
>>>>>> On 04.02.2022 11:12, Oleksandr Andrushchenko wrote:
>>>>>>> On 04.02.22 11:15, Jan Beulich wrote:
>>>>>>>> On 04.02.2022 09:58, Oleksandr Andrushchenko wrote:
>>>>>>>>> On 04.02.22 09:52, Jan Beulich wrote:
>>>>>>>>>> On 04.02.2022 07:34, Oleksandr Andrushchenko wrote:
>>>>>>>>>>> @@ -285,6 +286,12 @@ static int modify_bars(const struct pci_de=
v *pdev, uint16_t cmd, bool rom_only)
>>>>>>>>>>>                      continue;
>>>>>>>>>>>              }
>>>>>>>>>>>     =20
>>>>>>>>>>> +        spin_lock(&tmp->vpci_lock);
>>>>>>>>>>> +        if ( !tmp->vpci )
>>>>>>>>>>> +        {
>>>>>>>>>>> +            spin_unlock(&tmp->vpci_lock);
>>>>>>>>>>> +            continue;
>>>>>>>>>>> +        }
>>>>>>>>>>>              for ( i =3D 0; i < ARRAY_SIZE(tmp->vpci->header.ba=
rs); i++ )
>>>>>>>>>>>              {
>>>>>>>>>>>                  const struct vpci_bar *bar =3D &tmp->vpci->hea=
der.bars[i];
>>>>>>>>>>> @@ -303,12 +310,14 @@ static int modify_bars(const struct pci_d=
ev *pdev, uint16_t cmd, bool rom_only)
>>>>>>>>>>>                  rc =3D rangeset_remove_range(mem, start, end);
>>>>>>>>>>>                  if ( rc )
>>>>>>>>>>>                  {
>>>>>>>>>>> +                spin_unlock(&tmp->vpci_lock);
>>>>>>>>>>>                      printk(XENLOG_G_WARNING "Failed to remove =
[%lx, %lx]: %d\n",
>>>>>>>>>>>                             start, end, rc);
>>>>>>>>>>>                      rangeset_destroy(mem);
>>>>>>>>>>>                      return rc;
>>>>>>>>>>>                  }
>>>>>>>>>>>              }
>>>>>>>>>>> +        spin_unlock(&tmp->vpci_lock);
>>>>>>>>>>>          }
>>>>>>>>>> At the first glance this simply looks like another unjustified (=
in the
>>>>>>>>>> description) change, as you're not converting anything here but =
you
>>>>>>>>>> actually add locking (and I realize this was there before, so I'=
m sorry
>>>>>>>>>> for not pointing this out earlier).
>>>>>>>>> Well, I thought that the description already has "...the lock can=
 be
>>>>>>>>> used (and in a few cases is used right away) to check whether vpc=
i
>>>>>>>>> is present" and this is enough for such uses as here.
>>>>>>>>>>      But then I wonder whether you
>>>>>>>>>> actually tested this, since I can't help getting the impression =
that
>>>>>>>>>> you're introducing a live-lock: The function is called from cmd_=
write()
>>>>>>>>>> and rom_write(), which in turn are called out of vpci_write(). Y=
et that
>>>>>>>>>> function already holds the lock, and the lock is not (currently)
>>>>>>>>>> recursive. (For the 3rd caller of the function - init_bars() - o=
toh
>>>>>>>>>> the locking looks to be entirely unnecessary.)
>>>>>>>>> Well, you are correct: if tmp !=3D pdev then it is correct to acq=
uire
>>>>>>>>> the lock. But if tmp =3D=3D pdev and rom_only =3D=3D true
>>>>>>>>> then we'll deadlock.
>>>>>>>>>
>>>>>>>>> It seems we need to have the locking conditional, e.g. only lock
>>>>>>>>> if tmp !=3D pdev
>>>>>>>> Which will address the live-lock, but introduce ABBA deadlock pote=
ntial
>>>>>>>> between the two locks.
>>>>>>> I am not sure I can suggest a better solution here
>>>>>>> @Roger, @Jan, could you please help here?
>>>>>> Well, first of all I'd like to mention that while it may have been o=
kay to
>>>>>> not hold pcidevs_lock here for Dom0, it surely needs acquiring when =
dealing
>>>>>> with DomU-s' lists of PCI devices. The requirement really applies to=
 the
>>>>>> other use of for_each_pdev() as well (in vpci_dump_msi()), except th=
at
>>>>>> there it probably wants to be a try-lock.
>>>>>>
>>>>>> Next I'd like to point out that here we have the still pending issue=
 of
>>>>>> how to deal with hidden devices, which Dom0 can access. See my RFC p=
atch
>>>>>> "vPCI: account for hidden devices in modify_bars()". Whatever the so=
lution
>>>>>> here, I think it wants to at least account for the extra need there.
>>>>> Yes, sorry, I should take care of that.
>>>>>
>>>>>> Now it is quite clear that pcidevs_lock isn't going to help with avo=
iding
>>>>>> the deadlock, as it's imo not an option at all to acquire that lock
>>>>>> everywhere else you access ->vpci (or else the vpci lock itself woul=
d be
>>>>>> pointless). But a per-domain auxiliary r/w lock may help: Other path=
s
>>>>>> would acquire it in read mode, and here you'd acquire it in write mo=
de (in
>>>>>> the former case around the vpci lock, while in the latter case there=
 may
>>>>>> then not be any need to acquire the individual vpci locks at all). F=
TAOD:
>>>>>> I haven't fully thought through all implications (and hence whether =
this is
>>>>>> viable in the first place); I expect you will, documenting what you'=
ve
>>>>>> found in the resulting patch description. Of course the double lock
>>>>>> acquire/release would then likely want hiding in helper functions.
>>>>> I've been also thinking about this, and whether it's really worth to
>>>>> have a per-device lock rather than a per-domain one that protects all
>>>>> vpci regions of the devices assigned to the domain.
>>>>>
>>>>> The OS is likely to serialize accesses to the PCI config space anyway=
,
>>>>> and the only place I could see a benefit of having per-device locks i=
s
>>>>> in the handling of MSI-X tables, as the handling of the mask bit is
>>>>> likely very performance sensitive, so adding a per-domain lock there
>>>>> could be a bottleneck.
>>>> Hmm, with method 1 accesses serializing globally is basically
>>>> unavoidable, but with MMCFG I see no reason why OSes may not (move
>>>> to) permit(ting) parallel accesses, with serialization perhaps done
>>>> only at device level. See our own pci_config_lock, which applies to
>>>> only method 1 accesses; we don't look to be serializing MMCFG
>>>> accesses at all.
>>>>
>>>>> We could alternatively do a per-domain rwlock for vpci and special ca=
se
>>>>> the MSI-X area to also have a per-device specific lock. At which poin=
t
>>>>> it becomes fairly similar to what you propose.
>>> @Jan, @Roger
>>>
>>> 1. d->vpci_lock - rwlock <- this protects vpci
>>> 2. pdev->vpci->msix_tbl_lock - rwlock <- this protects MSI-X tables
>>> or should it better be pdev->msix_tbl_lock as MSI-X tables don't
>>> really depend on vPCI?
>> If so, perhaps indeed better the latter. But as said in reply to Roger,
>> I'm not convinced (yet) that doing away with the per-device lock is a
>> good move. As said there - we're ourselves doing fully parallel MMCFG
>> accesses, so OSes ought to be fine to do so, too.
> But with pdev->vpci_lock we face ABBA...

I didn't say without per-domain r/w lock, did I? I stand by my earlier
outline.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Feb 04 13:07:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 13:07:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265521.458907 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFyIp-00044i-EE; Fri, 04 Feb 2022 13:07:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265521.458907; Fri, 04 Feb 2022 13:07:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFyIp-00044b-B7; Fri, 04 Feb 2022 13:07:03 +0000
Received: by outflank-mailman (input) for mailman id 265521;
 Fri, 04 Feb 2022 13:07:02 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=46ws=ST=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nFyIo-00044B-27
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 13:07:02 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 55d3e20a-85bb-11ec-8f75-fffcc8bd4f1a;
 Fri, 04 Feb 2022 14:07:00 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 55d3e20a-85bb-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1643980020;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=+C5cSq8N7oe15qd5RRjtgqgE04Te6M/xJdkEuolfKx8=;
  b=Cyf98hEkk9GTVpKtwOQ5H+ILw8lHG2rJJ2bLhKnjd68+1HOilb07GbyC
   af8A1Pj4J+IdZDlrkGJnVNprWHD2FVY2mlsI8icoBLRn0jzTUa6N0z6I9
   BhZrFqdW7Lui1eyGtD6mGDKFXpAR2rWIeyzLt8YQ0NRqBlz6ZuYfu3T5n
   o=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: BoWmmKysbnN0hcYtlNd95B2+l2rBu7gPQyVp6tPjS0YFYXr5NKmVDfmgBrufyZYPChpBT76I8r
 G8UIA6cBjtxYZUjrqm30ZBaCUpZ1ol11aodpzIFm4mIMiuClq2dSBtC4Dlla8o0S0AsTuKEoWQ
 +bJmYjJLrlAJiULrt4HtZy6Eu/nlGiaM8LSaQKQZufvM9Te7j7GiT5eOhVfQo8dzDt+YzDD/Hy
 0XMz2XY6nOvG0HMivEr1vOs+4RnUqlwceFR5NzXS5wTNC31ejpoOwh62FaWt8LxaN9lBO5iBey
 LxrI9bIlF/XXSxCkpvCT6MWg
X-SBRS: 5.1
X-MesageID: 63903829
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:xdCkwKpngB8rce3uOrVNcnpRgtteBmI6YxIvgKrLsJaIsI4StFCzt
 garIBmEPv2DYDCmed8jbIq39R4G7MfWx95jQFBlpSs9FX5EpZuZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlZT4vE2xbuKU5NTsY0idfic5Dndx4f5fs7Rh2NQw24DlW1nlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCnaWLTAAkLqf1o7RecSNRGSVXbKxA0ZaSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFJkYtXx6iynQEN4tQIzZQrWM7thdtNs1rp4VTK6FN
 5BIAdZpRBntTDBPZFEwM4M3zeqslmDkKRJxtk3A8MLb5ECMlVcsgdABKuH9YtWXQe1Fk0Deo
 XjJl0zQGA0XMeu62DWM83+yruLXlCa9U4UXfJWy++R2mlSVyioWAQcPSFqgifCjjwi1XNc3A
 1wZ/G8ioLY/8GSvT8LhRFuorXicpBkeVtFMVeog52ml0KPU/gLfHWkCQT5pYcYj8sQxQFQC6
 FiNmN/4AC11h5ecQ3md67S8oCu7PG4eKmpqTS0OQBYB4tLjiJoulR+JRdFmeIaSitD2Ajj2z
 yq9hS4ynagIjcUL2qO4+njKmzup4JPOS2Yd5BjTX2+jxhN0YsiifYPAwX/f4PVbJYCVVG69r
 WMEkMiT6uMJJZyVnSnLS+IIdJmy/OqMOjDYhV9pHrEi+i6r9nrleppfiAySP28wbJxCI2WwJ
 haO50UBv/e/IUdGc4dOWIe2BtQg9JOwVvbfX/rQR4tPZLFYIVrvED5VWWac2GXkkU4JmK45O
 IuGfcvEMUv2GZiL3xLtGb5DjOZDKjQWgDqKGMull0jPPa+2OSbNIYrpJmdieQzQAEmshAzOu
 +hSOMKRo/m0eL2vO3KHmWL/wL1jEJTaOXwUg5EPHgJgClA/cI3ENxM36el6E2CCt/8N/tokB
 lnnBidlJKPX3BUr0zmiZHF5c6/IVp1it389NiFEFQ/2hyNzOtvxsfZEKMBfkVwbGApLl6Uco
 x4tIJ3oPxiyYm6fp2R1gWfV8OSOiyhHdSrRZnH4MVDTjrZrRhDT+8+MQ+cc3HJmM8ZDjuNn+
 +fI/lqCGfIrHl0+ZO6LOKPH5w7g5hA1xbMtN3Yk1/EOIS0ABqAxcHev5hL2SulRQSj+Ksyyj
 FfLWEpI+LWW/ufYMrDh3Mi5kmtgKMMndmJyFGjH97emcy7c+2uo24hbV+iUOzvaUQvJFG+KP
 425Ftnwb68KmkhkqY15H+o5xK4y/YK39bRb0h5lDDPAaFHyUuFsJXyP3M9usKxRx+AG5VvqC
 xzXotQKa6+UPM7FEUIKIFZ3ZOq0yvxJyCLZ6u44IRum6XYvrqaHS0hbIzKFlDdZcOluKIogz
 Op44JwW5gWzhwAEKNGDiiwIpW2AImZZC/cst40AAZ+tgQ0ukwkQbZvZAy7wwZeOd9QTbRV6f
 m7K3PLP3u0OyFDDfnw/EWn28dBc3Zle6gpXyFIiJkiSnoaXjPEAwxAMoy88SR5Yz0sb3rsra
 HRrLUB8OY6H4yxs2JpYR2mpFgxMWE+Z90j2xwdbnWHVVRD1BGnELWl7MueR5kEJtWlbe2EDr
 r2fzW/kVxfsfd3wgXRuCRI09aS7QIwj7BDGleCmA9+BTsszbjfSi6OzYXYF9kn8CsQriUyb/
 eRn8Y6cs0Eg2fL8d0HjN7Sn6A==
IronPort-HdrOrdr: A9a23:Swpzeaq2cDY0JeXgDdVYqOUaV5uzL9V00zEX/kB9WHVpm5Oj+P
 xGzc526farslsssREb+OxpOMG7MBThHLpOkPMs1NCZLXTbUQqTXfpfBO7ZrQEIdBeOlNK1uZ
 0QFpSWTeeAcWSS7vyKkTVQcexQueVvmZrA7Yy1rwYPcegpUdAZ0+4QMHfkLqQcfnghOXNWLu
 v52iIRzADQBkj/I/7LTUUtbqzmnZnmhZjmaRkJC1oO7xSPtyqh7PrfHwKD1hkTfjtTyfN6mF
 K13jDR1+GGibWW2xXc32jc49B/n8bg8MJKAIiphtIOIjvhpw60bMBKWqGEvhoyvOazgWxa2u
 XkklMFBYBe+nnRdma6rV/E3BTh6i8n7zvYxVqRkRLY0LrEbQN/L/AEqZNScxPf5UZllsp7yr
 h302WQsIcSJQ/cnQzmjuK4GS1Cpw6Rmz4PgOQTh3tQXc81c7lKt7ES+0tTDdMpAD/60oY6C+
 NjZfusq8q+SWnqL0wxg1Mfg+BFBh8Ib1W7qwk5y4CoOgFt7TFEJxBy/r1bop8CnKhNPKWsqd
 60dpiAr4s+PfP+W5gNcNvpcfHHelAlfii8Ql56AW6XXZ3vaEi946Ie3t0OlZSXkdozvdwPpK
 g=
X-IronPort-AV: E=Sophos;i="5.88,342,1635220800"; 
   d="scan'208";a="63903829"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=l8BzuojzgjPvIp/D4aBHR42tQ4W1Y/UW4dR56vluyE13fawkhUsMSDwZxaQV0lG22agyrObV4Rxsy5Qy5RcRNp2IX2ST7HjFwvKkxerg/cko2nKUemkBXbQyXlpm81vosP0OgjpRhQV+IH/F1fYzod+sfLmIaDphb0pfttqwZkKkT3I/D1TWOVusFlAPJ+XiTZwzyWlytXuPj6YBm//sXbEbCPBOJMuUXgUmyVOOjcB4SmDDCq+dUahsygw7PKzaNP6uXKJskbWUVODeS3yO17ALyO4By6+MTW6q33QS5wwLvjOPqXiIzg2GXG1mvdPHewFMW54PJbRMBkj/Z2iM4w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=cOsj3/lO0yyIvHSXvMIiEAHT+mxFIqipm9UcgUnPejE=;
 b=SXG1Fk2HWumXBK7oCzWvrDInjERi8GONMvINIXZPfUg6F74g7qyiihjn+G79OMbOCgGee+hNfiEVwZ3HZc9bPUBEwQMDwntiUbeM96NZLYqpCIUy+mRckRgQ5pVr/o0RoE8ZipGVlcp3hFpp/uKuoxzkClUUB/7yzWU98ybaANFdH3BiESwk/fFnC7WK2Z5QyK5Wb1xMwRS6XTyLzJZ5a2+oouvykunpL9Mw0u1YgVHNaErqISqjETRc+Yfsj9PlERpd69nksce/ypd3Gdu8YPtNRfPBCsQ5BPyrZP8TJitQA5CzOCt6ZCBB30V6LYiQF9s4HYiXUH6IhWAzqIkWyA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=cOsj3/lO0yyIvHSXvMIiEAHT+mxFIqipm9UcgUnPejE=;
 b=VdvICTBJ7S07Go9In1q/ulxGypynYh/1rzxYkeya8JsH3AWISh8NNRrfWxqhk5mQ08MzY2uBTsLdgk/4LMJ2dUSjVuPn6igD1jWgur5aQ28BPhR5z1sMjb3ZLtULwULrFdNYweInbpFHKkXb35KxdoTuXZeeEVOFJ9lKStfayEg=
Date: Fri, 4 Feb 2022 14:06:49 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: Jan Beulich <jbeulich@suse.com>, "julien@xen.org" <julien@xen.org>,
	"sstabellini@kernel.org" <sstabellini@kernel.org>, Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Artem Mygaiev <Artem_Mygaiev@epam.com>,
	"andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
	"george.dunlap@citrix.com" <george.dunlap@citrix.com>, "paul@xen.org"
	<paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>, Rahul Singh
	<rahul.singh@arm.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Message-ID: <Yf0k6aoKK5G3iad1@Air-de-Roger>
References: <7209889d-8f17-61cc-72a4-97f6dbc1d54d@suse.com>
 <2cf022f8-b000-11b7-c6b9-90a56bc6e2ea@epam.com>
 <04726915-f39f-9019-436e-4399533c9fc3@suse.com>
 <9ed3f4ac-0a2d-ed45-9872-7c3f356a469e@epam.com>
 <c3a99712-cf7c-37da-aac1-f2ee00e6d53b@suse.com>
 <Yf0KcVD8W05A4fbB@Air-de-Roger>
 <1ed0e342-16cd-2f16-c05c-186667a22762@suse.com>
 <7e3562b5-fc67-f213-e872-f211450d9e2e@epam.com>
 <a8fc599c-f620-c4d1-2077-c57068f46a7f@suse.com>
 <deef8468-d607-e49e-f456-6a8013329ca1@epam.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <deef8468-d607-e49e-f456-6a8013329ca1@epam.com>
X-ClientProxiedBy: LO2P265CA0115.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:c::31) To SA0PR03MB5610.namprd03.prod.outlook.com
 (2603:10b6:806:b2::9)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 34ac3d3e-c06b-4107-a340-08d9e7df378a
X-MS-TrafficTypeDiagnostic: BYAPR03MB4376:EE_
X-Microsoft-Antispam-PRVS: <BYAPR03MB43769062334CA87F8DF581C68F299@BYAPR03MB4376.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: HPTHrgyRoJif3/t5zCPPuqIRq7Zx93SSH6D7ge473mXoD45YatJiI025B10vkUdxiEX5uw9MWmuT1gbLEvcLxs3QiAVkr7SLPBw6X6C1YQJbMv2BoMBoyge05pdsZ+qaZSk6OC76ltdtfXpDiI+VJevVrp1rLwoHWX0z/l3WBRSRFi5I48cGUfHJW4jIc3Ys5RX+ui8G7+FMvSj+8eSPhVyQo35iRUgyNGJhKbJ1R07bEeT2Vw222BYa4FfZrCHbZYTEyEvCt8QhZCrDKAPubDK37QI/wV9QKEhetGb3/SpcQlcUm8I2Q7GvW/tasazrzmYT3ItxQa8xjGLgYRml7L/mrv08uWi81SQFBBstnN32wxjX8BJcoZYAP62gfpILHHUIQQmogv350o1yKLbB6otTpCBbdk4snjg28ATthSsgIYisSpukshXs5pTThFI35aifomBdy8cX4pNpMALI7i7ljQ+wBoeWlEsu3tf21LvLcwr6q0uqk0edMH0RC5e55oZfWhDxU6V6YQh9naJwzRVKtKlfA0zacBQ3vdX8+f1L8PhkLVtqh0rWtonqUgS9y3nZrZXnQWQaakTLiVPxJCAsVQxoxaAlZa25D4Enyob+tM1Rke2Z+9cwP0eZNtTIuEt2tmMmGj7mMgFntzYlBA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA0PR03MB5610.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(53546011)(66946007)(508600001)(8936002)(33716001)(38100700002)(82960400001)(85182001)(5660300002)(6486002)(6916009)(66476007)(316002)(54906003)(86362001)(83380400001)(26005)(2906002)(186003)(7416002)(9686003)(6666004)(66556008)(6506007)(6512007)(8676002)(4326008);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MytjbkljTjZkbmIxd3B3RGF6amFNLyt6R1ZyNDBEMW9KVDZPMzhHZERJMENL?=
 =?utf-8?B?UitQdkhKRW9WMWhySXJxQjhweVRvM2JxVnViVDhSSFJRYllNMHhrUGVBb25H?=
 =?utf-8?B?Q0h4QXhkbmdWWWt1YmNIdXBTd3MvSDZVTHdyUG04Tkw0dHZmWnNnTEtUeUZK?=
 =?utf-8?B?QmUzZzN1Sndjc0dlUXJoeXFFYzBtOUd1dmlMY2d6d3BsejdnTzJRdTQ5bHl2?=
 =?utf-8?B?MzFqQ0pkN3pudkZSODQ3eFdwT3RCOWZQR2V1VE5Qb2lLN2hNZUEyaDdnKzhJ?=
 =?utf-8?B?b2h1M2lqTFliRmgzSERCc1BBNDV4Mm1SYU1WK0dkUUVRWHNZbEZVZjQ0QnNJ?=
 =?utf-8?B?bDQreGFmNjhsL3orVklRV3FnTThLSVpRekNWS3RnbnpYeDcxZGEzYXozaW9w?=
 =?utf-8?B?VzU2R2Q5RkxzSHZjS3E1Wi9oWGVXWXpBMTMzS1FYeEtFZTFjSTdRMmQxU05y?=
 =?utf-8?B?WkE3bGlDMDFFSnJiTW5BdUpZSVZJd1ptZVRGN25iQUxHUDk0djQ3RWJqOTdG?=
 =?utf-8?B?L2dBSUhiUnZpUk1lc2RSVjdvZ1l4dzk3VEpXeGpUMXhGc0hSdW85ZFRkYlZ0?=
 =?utf-8?B?dXZBSjFtdXQ0WUU3SUdPTU9CWmJJcXNKeHFGZXpQZWZhdGNKNjBUbU04K0JQ?=
 =?utf-8?B?cFZlcW9Mc0E3Z2RMdHNYMmUzSzVSdlhOU0FTd3BaWXVyR1dVdGpXajhReFZv?=
 =?utf-8?B?Q08xcEhrSVRtZ25jc2J0VmNkbElZOHVSMzRhT2ZIV2cyU2R6RWcrcTFWZ2hi?=
 =?utf-8?B?ZEkyeHdJOUFKYWQzUDl6OEIveW9VZmMvVVMzejd6QmViK2pFV3hPcEx6TTlG?=
 =?utf-8?B?M25jSktOTkZWVm5TSWRLOXVacytrS095cS9rcEphQXU5YkRQN0JVSklQeTBQ?=
 =?utf-8?B?TkJWZnp0N3R5ZmZBZGxUVEhsQllFNHBNcThLOEhMRnNLd04ya20wL3dldHhu?=
 =?utf-8?B?WDFYYVNpdnozTkZ0Y2ZhRVlqV2w2Z0JGbnBQM3p3b1lrcG1tRElxcDBqS1Q0?=
 =?utf-8?B?L1RGb2RnVFdtMGlUbVN2WWRPUlgyQWxndTRoT3hYNDZVNVd1V0hFVW83OFBt?=
 =?utf-8?B?c3FOK1NXK2ZVa0RJNzRDald3UXBPNXh3RXJOT2U1Z0xYTVdDK05nbDJYUFBW?=
 =?utf-8?B?NlpVaVVjYUIvTW5MRUtWclZNTFlQSEM1TS9OYmdmdXRXWlkrY3F2MUI5aXZY?=
 =?utf-8?B?SldURjJFUXpSWWloTDliMzV6cFFhME5KV1dXcURVY0VCNHNOcVdEUFJOb1Nl?=
 =?utf-8?B?Um1ZY003K0l4bHdOV3FOdmxYQzl4ZUk2MjJ4aUM5ZmtMc1NvSnA2enRUU0Ft?=
 =?utf-8?B?RVhFQ1lVckRoc1diYy9qeWNUWGl0dGRiYlIrY1M3VjM2Mkx5YWVRRnluenVB?=
 =?utf-8?B?Szk3U2sxaG5vajBKRU9LK3RTUW1jL05LMExoSHVhRUFWRVhDNTUxTnR1Z0Jw?=
 =?utf-8?B?WGFRZlhreFp5QnVzeW4yZlNVZ2dmcERUMUx6Qm4rZm5XVW5oT3p2NFZGM2lF?=
 =?utf-8?B?bE4vTkJUdzVSYWwwSDgvUjRYMVQvL25sZndjQlRoSUVxeUErVjl5dERqblNW?=
 =?utf-8?B?UGRUaEhmdGM5Nkw4VnBrUS8wdi9BeWlnY1kzZjlmWmwzSC9QL2RsSm85M2xp?=
 =?utf-8?B?K1Jib0dxcUFFaFZ1RUFDVmo5dWxEZHdZREVsTUdLQnJQdXcwVHFvRVZyQVVw?=
 =?utf-8?B?dnF6LzFGT3NZb1ZzRklFaTRVSVhWOGxqTnlKNVdGNG5aKzEwTXE0VVpoZHUr?=
 =?utf-8?B?S1pTMTE5R2d2VEdrZTVyQXFzMFRwQUpsMFU0OFlvTVFsMndwaDdnVXloWVlY?=
 =?utf-8?B?c3U2MzMzdUU4SkRJdFVMTUcrcVJjTHBhUGdlWTBVNmZGUTZuOTBTRkUxd3Aw?=
 =?utf-8?B?WElnc1ZjNUdhUTZxMFRjWjFVbmsxcFIzdGtxazd4VVVLZ0ZkNnVzc25uNGNj?=
 =?utf-8?B?cDlHbU1uemdiR2FPeGNSMVlRR2UyaXBYMndBaXg4ejU5UXVUVGpBSE1sd29r?=
 =?utf-8?B?aHVpTW5ud0k3Y1cvNUNXUUt1WXNPZG8ram4yckdQVFVyRXRQbFc4K3JWZUxv?=
 =?utf-8?B?dVRVK2t1aUtSRElTMjlteFBtZ1ZaamhMeGU1U0cvbEZiMnFnSUN1dTZuQ1Fm?=
 =?utf-8?B?ME1ZMDBzdXNMUUEya2FnRnVQRkpEbGxvMi9ZODY0ZUdZNGZUOXBtSWVXRU13?=
 =?utf-8?Q?z53AuoMbKVj4DP9hulWdpZo=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 34ac3d3e-c06b-4107-a340-08d9e7df378a
X-MS-Exchange-CrossTenant-AuthSource: SA0PR03MB5610.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Feb 2022 13:06:54.7066
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uvoL9PaCW3P43GM/bKIVdu6rvGaYJcBLJAg3JiPoH4U3CpG9zCC9wN45hsZ9d/b6wqcWsunsolbpOtJdC1UBkA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4376
X-OriginatorOrg: citrix.com

On Fri, Feb 04, 2022 at 12:53:20PM +0000, Oleksandr Andrushchenko wrote:
> 
> 
> On 04.02.22 14:47, Jan Beulich wrote:
> > On 04.02.2022 13:37, Oleksandr Andrushchenko wrote:
> >>
> >> On 04.02.22 13:37, Jan Beulich wrote:
> >>> On 04.02.2022 12:13, Roger Pau Monné wrote:
> >>>> On Fri, Feb 04, 2022 at 11:49:18AM +0100, Jan Beulich wrote:
> >>>>> On 04.02.2022 11:12, Oleksandr Andrushchenko wrote:
> >>>>>> On 04.02.22 11:15, Jan Beulich wrote:
> >>>>>>> On 04.02.2022 09:58, Oleksandr Andrushchenko wrote:
> >>>>>>>> On 04.02.22 09:52, Jan Beulich wrote:
> >>>>>>>>> On 04.02.2022 07:34, Oleksandr Andrushchenko wrote:
> >>>>>>>>>> @@ -285,6 +286,12 @@ static int modify_bars(const struct pci_dev *pdev, uint16_t cmd, bool rom_only)
> >>>>>>>>>>                      continue;
> >>>>>>>>>>              }
> >>>>>>>>>>      
> >>>>>>>>>> +        spin_lock(&tmp->vpci_lock);
> >>>>>>>>>> +        if ( !tmp->vpci )
> >>>>>>>>>> +        {
> >>>>>>>>>> +            spin_unlock(&tmp->vpci_lock);
> >>>>>>>>>> +            continue;
> >>>>>>>>>> +        }
> >>>>>>>>>>              for ( i = 0; i < ARRAY_SIZE(tmp->vpci->header.bars); i++ )
> >>>>>>>>>>              {
> >>>>>>>>>>                  const struct vpci_bar *bar = &tmp->vpci->header.bars[i];
> >>>>>>>>>> @@ -303,12 +310,14 @@ static int modify_bars(const struct pci_dev *pdev, uint16_t cmd, bool rom_only)
> >>>>>>>>>>                  rc = rangeset_remove_range(mem, start, end);
> >>>>>>>>>>                  if ( rc )
> >>>>>>>>>>                  {
> >>>>>>>>>> +                spin_unlock(&tmp->vpci_lock);
> >>>>>>>>>>                      printk(XENLOG_G_WARNING "Failed to remove [%lx, %lx]: %d\n",
> >>>>>>>>>>                             start, end, rc);
> >>>>>>>>>>                      rangeset_destroy(mem);
> >>>>>>>>>>                      return rc;
> >>>>>>>>>>                  }
> >>>>>>>>>>              }
> >>>>>>>>>> +        spin_unlock(&tmp->vpci_lock);
> >>>>>>>>>>          }
> >>>>>>>>> At the first glance this simply looks like another unjustified (in the
> >>>>>>>>> description) change, as you're not converting anything here but you
> >>>>>>>>> actually add locking (and I realize this was there before, so I'm sorry
> >>>>>>>>> for not pointing this out earlier).
> >>>>>>>> Well, I thought that the description already has "...the lock can be
> >>>>>>>> used (and in a few cases is used right away) to check whether vpci
> >>>>>>>> is present" and this is enough for such uses as here.
> >>>>>>>>>      But then I wonder whether you
> >>>>>>>>> actually tested this, since I can't help getting the impression that
> >>>>>>>>> you're introducing a live-lock: The function is called from cmd_write()
> >>>>>>>>> and rom_write(), which in turn are called out of vpci_write(). Yet that
> >>>>>>>>> function already holds the lock, and the lock is not (currently)
> >>>>>>>>> recursive. (For the 3rd caller of the function - init_bars() - otoh
> >>>>>>>>> the locking looks to be entirely unnecessary.)
> >>>>>>>> Well, you are correct: if tmp != pdev then it is correct to acquire
> >>>>>>>> the lock. But if tmp == pdev and rom_only == true
> >>>>>>>> then we'll deadlock.
> >>>>>>>>
> >>>>>>>> It seems we need to have the locking conditional, e.g. only lock
> >>>>>>>> if tmp != pdev
> >>>>>>> Which will address the live-lock, but introduce ABBA deadlock potential
> >>>>>>> between the two locks.
> >>>>>> I am not sure I can suggest a better solution here
> >>>>>> @Roger, @Jan, could you please help here?
> >>>>> Well, first of all I'd like to mention that while it may have been okay to
> >>>>> not hold pcidevs_lock here for Dom0, it surely needs acquiring when dealing
> >>>>> with DomU-s' lists of PCI devices. The requirement really applies to the
> >>>>> other use of for_each_pdev() as well (in vpci_dump_msi()), except that
> >>>>> there it probably wants to be a try-lock.
> >>>>>
> >>>>> Next I'd like to point out that here we have the still pending issue of
> >>>>> how to deal with hidden devices, which Dom0 can access. See my RFC patch
> >>>>> "vPCI: account for hidden devices in modify_bars()". Whatever the solution
> >>>>> here, I think it wants to at least account for the extra need there.
> >>>> Yes, sorry, I should take care of that.
> >>>>
> >>>>> Now it is quite clear that pcidevs_lock isn't going to help with avoiding
> >>>>> the deadlock, as it's imo not an option at all to acquire that lock
> >>>>> everywhere else you access ->vpci (or else the vpci lock itself would be
> >>>>> pointless). But a per-domain auxiliary r/w lock may help: Other paths
> >>>>> would acquire it in read mode, and here you'd acquire it in write mode (in
> >>>>> the former case around the vpci lock, while in the latter case there may
> >>>>> then not be any need to acquire the individual vpci locks at all). FTAOD:
> >>>>> I haven't fully thought through all implications (and hence whether this is
> >>>>> viable in the first place); I expect you will, documenting what you've
> >>>>> found in the resulting patch description. Of course the double lock
> >>>>> acquire/release would then likely want hiding in helper functions.
> >>>> I've been also thinking about this, and whether it's really worth to
> >>>> have a per-device lock rather than a per-domain one that protects all
> >>>> vpci regions of the devices assigned to the domain.
> >>>>
> >>>> The OS is likely to serialize accesses to the PCI config space anyway,
> >>>> and the only place I could see a benefit of having per-device locks is
> >>>> in the handling of MSI-X tables, as the handling of the mask bit is
> >>>> likely very performance sensitive, so adding a per-domain lock there
> >>>> could be a bottleneck.
> >>> Hmm, with method 1 accesses serializing globally is basically
> >>> unavoidable, but with MMCFG I see no reason why OSes may not (move
> >>> to) permit(ting) parallel accesses, with serialization perhaps done
> >>> only at device level. See our own pci_config_lock, which applies to
> >>> only method 1 accesses; we don't look to be serializing MMCFG
> >>> accesses at all.
> >>>
> >>>> We could alternatively do a per-domain rwlock for vpci and special case
> >>>> the MSI-X area to also have a per-device specific lock. At which point
> >>>> it becomes fairly similar to what you propose.
> >> @Jan, @Roger
> >>
> >> 1. d->vpci_lock - rwlock <- this protects vpci
> >> 2. pdev->vpci->msix_tbl_lock - rwlock <- this protects MSI-X tables
> >> or should it better be pdev->msix_tbl_lock as MSI-X tables don't
> >> really depend on vPCI?
> > If so, perhaps indeed better the latter. But as said in reply to Roger,
> > I'm not convinced (yet) that doing away with the per-device lock is a
> > good move. As said there - we're ourselves doing fully parallel MMCFG
> > accesses, so OSes ought to be fine to do so, too.
> But with pdev->vpci_lock we face ABBA...

I think it would be easier to start with a per-domain rwlock that
guarantees pdev->vpci cannot be removed under our feet. This would be
taken in read mode in vpci_{read,write} and in write mode when
removing a device from a domain.

Then there are also other issues regarding vPCI locking that need to
be fixed, but that lock would likely be a start.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Feb 04 13:09:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 13:09:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265528.458918 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFyLd-0004gD-Tx; Fri, 04 Feb 2022 13:09:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265528.458918; Fri, 04 Feb 2022 13:09:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFyLd-0004g5-Pt; Fri, 04 Feb 2022 13:09:57 +0000
Received: by outflank-mailman (input) for mailman id 265528;
 Fri, 04 Feb 2022 13:09:56 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1gJ0=ST=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nFyLc-0004fz-GZ
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 13:09:56 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id bf01a4db-85bb-11ec-8eb8-a37418f5ba1a;
 Fri, 04 Feb 2022 14:09:55 +0100 (CET)
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur03lp2054.outbound.protection.outlook.com [104.47.9.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-11-t_tc7tIqPcOvapuNuRFIAg-1; Fri, 04 Feb 2022 14:09:54 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM6PR04MB5862.eurprd04.prod.outlook.com (2603:10a6:20b:a0::25)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.14; Fri, 4 Feb
 2022 13:09:47 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.014; Fri, 4 Feb 2022
 13:09:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bf01a4db-85bb-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1643980195;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=BNAzDebrtrUti65iUmF01QOluoTqxRHy34ABZA/n8L8=;
	b=Ne/KJxHj36++63jI7C27eY3m0wLXDoRT6mYqPGnGprSQkeKtqCxOB/9dDqSOogVIzkTIU5
	XbV1quBw7XUo402hdMI+EczJpWO6PG/vAyeCkTqYIuEUfF7mEKtHZPKKZigwx8wIQ75hxC
	nSu0qLQCahoKDwS8uPvkO4fnazOjp2s=
X-MC-Unique: t_tc7tIqPcOvapuNuRFIAg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=O117QMWMloPIRVcFD8x+r8OCu75G8Xp3eSuVP6P2K72NLShhbMldIkTJ5H4sp7kxbB5AS+u+F5JQKZsxPCfSN82dPclHyVXVipRsjYZ/gtY41M2MxKtR7g82sa5nBYGiGZlL17Utn+R/h5KBlzXrW/mNUXgTwrxtnqAMc8t5F9NUPNlPlnWT+ehVOBJFJlHz0Wu5+UGjlltAAExeGp4fSlfB/uB7ps4FrJIKpYz0g9PzvvqrxVQAz1S5C+liSQCsgtcHMThpGDyDUDV/X4c+/8aTdgEqmgrUOLlCG7W/2Z0jXuvd0TEXNqkCKKWXuhHexg84APLA9CZbz54q8gAMZg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=BNAzDebrtrUti65iUmF01QOluoTqxRHy34ABZA/n8L8=;
 b=F3cWA/10Nduk6fVsYv6jWZ8uOr/7raveWSSFz3P3PlW9BUbTAc+ZhjuHGuaL2bQKZpjBnOLDtEl3mNGjA1BhjbPkugw5vLVoezVXhxik5LMmZC6n/NjJxrwoBTKcx+u8ZZagP+6FUT/XfFTAzYfbJE3XxIrkTn8jEYFtPYk2f8jRLFOlcNaRW82Tez0cs8z2XjHOqWCnHVjbEPQrQLJha7uz1gA0Hxn7A78g115tCFPktZmncOq5AILVDlKOVKkExU1xiuY6PmdZkOS12aD0zZ7C6pN+Uz5A4stGtTKfrfORj97pIilKlJkaYSvxfnD7mtkzkXtifIWA0O6J7vyj6w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <1333696d-d3c2-15a8-1dd5-7cb0a17ef023@suse.com>
Date: Fri, 4 Feb 2022 14:09:44 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH] tools/guest: Fix comment regarding CPUID compatibility
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
Cc: Wei Liu <wl@xen.org>, Anthony Perard <anthony.perard@citrix.com>,
 Juergen Gross <jgross@suse.com>, Xen-devel <xen-devel@lists.xenproject.org>,
 Roger Pau Monne <roger.pau@citrix.com>
References: <20220203181023.1554-1-andrew.cooper3@citrix.com>
 <53b98995-8cef-48b4-7728-3bfbc236af5f@suse.com>
 <f2ce80ee-f30c-dc6f-e4b7-5d8eddb5b3d5@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <f2ce80ee-f30c-dc6f-e4b7-5d8eddb5b3d5@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0379.eurprd06.prod.outlook.com
 (2603:10a6:20b:460::12) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ddf1ef78-9600-43ca-cbb0-08d9e7df9e3d
X-MS-TrafficTypeDiagnostic: AM6PR04MB5862:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB5862452114D11C80FD96BE63B3299@AM6PR04MB5862.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	xn4874H4T9NEPLteO3MMnU8jclAJ4SIV8kfYymeqiy29dARaTyVnFGv69B8q2v6l8doepzGHXXBvNBJnF6ZLzjEQ4VWkyDbdxap5q5HgF90WqsCXvv4j1QbiEhLwslTyckmbRsUgBLiZInDG3TXWj/q4Ctq4RpHSFVToiqeOofj1m6hgpqCFh32URrp51tnjgqvZjoltMKRG69jAIN88h/1X6ouMtFhFSxgr+vXMPbglwrFe8wVWbMbpWs98vSBDyEmif/b4XhUDKBTWpFIhWY/TEGS7TKuS9oCqpPLgckgT2XMD2ltaHgsvg5yfvPVNFkeQtnKgms621fDvWJdU1K4NmQOM+/zjwWcC6qnVCBOhPLkt6eMZXHpumT3ioVqM/whtDIVEFPthO75bDNVQ39WvlJXICNvfaLKZcRYZRFqeGOAILbFo8pr29T+xJfRm+VlbC3YTxX5sfy/qyLsLZRPxas3fG3xo/EYA7aydlyx84B+SzNLLzpNvJBrYTAUNCuydwlgx8dJlOjuiWjEXa2xLAs1QN3kS+cczLagyA1vICeBIzzxvgBGAFUJGFlC2NuvgW0tkm1IXIt6XxMJgp+8MTeL9naF/GKpNKdBcio0RLxPuBCJm2nYVo+EPoTd9lRiAwjC8vmNuh5Emh+c/v/AwC7ll/PRdcj3pd8yDilbIqNI82pE2rfUk7LeDt9wS6oKoY/iwnHgIaPAWbnvlosMuSoVwP7WHmhKX/PotSws=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(4326008)(66556008)(8936002)(8676002)(83380400001)(2906002)(66476007)(5660300002)(66946007)(186003)(26005)(2616005)(31686004)(36756003)(53546011)(6506007)(6512007)(508600001)(86362001)(31696002)(316002)(6916009)(6486002)(38100700002)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TVdwZFUzMjBnclZvQkdaOWR4RmM0aWxPZ3IxRjdhNHQ1L1hOWTZpZXAwU0hX?=
 =?utf-8?B?cXp2dHQxK1ltMW1DQ0NhdGcwcFpnZE5Jc041QWxpNjRKZFQ5RlcxTEo3bWNY?=
 =?utf-8?B?dEdhQzcwbUg1ZWlIbVUwYTBicElNVllxOWN6THBPWWtPM2VtMTVuelhMQi9B?=
 =?utf-8?B?YnRaWkM4Rk04eU9wUnloWVk5cDJqRGl0M0ljVFVzVUF1ckZlTEdsQmlOak5w?=
 =?utf-8?B?RExDK1NndkNHZThvN2xuemVNSkIrbXZxTkRpSnJ6aXppeXJLOU1DTlkrdnd0?=
 =?utf-8?B?OVhRbnJHMFY1TDBJRzFDcFJkTU5PWTZkOTR1c25Rcm1YS0lZZzlHdGtXcGhw?=
 =?utf-8?B?LzdlOEtGOWVEZGlBUGRlSWhMYTNORU1TbWozOEc4bkZHeE42T2gxbVBGNVJO?=
 =?utf-8?B?OVd0Nzg2WnRxZnZ4Mmp3L1hPZGUxc3ZkanluZGNIMUpxUW1LakZzREt6ajRz?=
 =?utf-8?B?allYSzdFWHZFU3BZMjgrUjFsZEM1N3lZdTlnZWN3bkhhbE5HNkc5UHEyN2JY?=
 =?utf-8?B?Z1hVcUN2Sy9ocDNXVnh4VG91ZG5VREs4QVZTenVNYjExZXNqbmY2Q1dkbng0?=
 =?utf-8?B?T3FTaEZUVnRzVGN1cjlnT3AwaEk0V21ZUmhvYWx6cldReENraTZaNmdGcnhH?=
 =?utf-8?B?SkZTNldrUW5veTluaWxPU2pWRGhqT09xbkR0NTdsOWE4TjA5eEZjLzg2SVk3?=
 =?utf-8?B?b283dlNFSHhkZUVGd0UyR0hmU3Qwa3dXRm5JZm5ielNaMEhDakVHRkdEZzJG?=
 =?utf-8?B?YjBzd1J6NHJHZ29RWDNwVUFkTHJVZk10VXN0SUlFM2d1aDJQVmxITUYweS93?=
 =?utf-8?B?MUU0NnpMREhRTUtxYklHaXhCTk51cGJXUCtRUHljamFoTG9BS0lZMHN6LzJV?=
 =?utf-8?B?WXN2RWdWUWtoa0srdy9WR1FhZXZVWXB6Y3FWQzZuemlUNytMTlJrLzNSRFhl?=
 =?utf-8?B?RFZVdS9CK05hYU5GVTNscW1IMlhHWUU3TStpSyt2S3NYWHF6b2FJT294Q2Vh?=
 =?utf-8?B?akpRK0xLZ0RraDBKcjROTUtSN0IxQlI1YXVySUk0SlVpYWZDQXJaM0p1dmM1?=
 =?utf-8?B?UHpneUV4ODh3VnY0WlJrbUxQTHZzU0M0bFZHdVpDZzNyVmg3S3ZOd3VJalpl?=
 =?utf-8?B?ZVB0bUJKUDUvbEFTbDVUMXpZbjV5UDFkejhKdkl5SUJvSDZkbFRUb1EwWHo4?=
 =?utf-8?B?VWtLcFd3Qy9ic0Z4N2c0M1FXMlcrWDc3OUpwbGw1RUxtMzl4SjltaEJUeklm?=
 =?utf-8?B?Uk02ZmU4dUNqbVZ6ZU0rbEVkMnB0aS9jSldZR2lQSXh2NzFtNXlFbWsyY0hu?=
 =?utf-8?B?aXpNQVlHODRSOVMwSy9HOHU5NUd6ZHJod1kwTm1mMGJpQU43Rk1RMlRJZGVW?=
 =?utf-8?B?UGFrZm1FUXAyajRzS3BxcWhKVUVIVDlJSDdnb0xTbUs1TlRLeEJqV3NubWlp?=
 =?utf-8?B?dE83OC9BUmxFM0hTeFFIKzZQenFrZHMrcTFsOURPTnl5cUdKbjJzS2NCV0hT?=
 =?utf-8?B?Q3cwcVVmMnRHdHF2R3laOCt3NjZtdm9vclVEZHZzRjRlL1YwcXNtQ1poY0Ix?=
 =?utf-8?B?cHN2L1cxQkZ6amwxSE80OGxOc2JTYmJqN0FwVm9pWXU0UlNMNFBkZDVScUIr?=
 =?utf-8?B?SU41N2F0d0VDNGFzb3pvb2FCb2gwcXlUUkVaVGNFWUNVWC9tbVVXdkNyRVN4?=
 =?utf-8?B?M2s2QllhVGRoamZsNy9SWjQxdUlxeXR0d29zWGdMUGgrbzRlMXBXdTc3RUJt?=
 =?utf-8?B?SjF0TVl4SERScitjOGxyOW53MHQxc1V3QVBmem1SOFRlMmN1NnNSeGFEQzVk?=
 =?utf-8?B?MjZ0a1Q0cWxRUnI5RCt3cW9LVWMwYzFmN2RnY0FIbE5lZmVSMHlHMGVpZDVI?=
 =?utf-8?B?cWlyR3lrY1dTUm9ZeWZCbGF4ZHI1YjdEdWJHNnFEcFRuSERMZURMYzVvcGF4?=
 =?utf-8?B?Z2hlL29MY2FaeTFCM0Z2dU4rYitBUjZaSVA5dHlkaUkwMXZyT2FaNnNvUlll?=
 =?utf-8?B?MWY4MVFtNG5hdVJlR3NENXhBMVE0Uml2TEtTVHg5VytoUk5YcnQ1WXlHLzRQ?=
 =?utf-8?B?WGJoSjQ0RHdOeFBYQjdLS3RzUUR2SWZML2dGZ0h6VVBGaFVqYVZFU2ZJM3RH?=
 =?utf-8?B?b1U4YXR0bllraDhucXB1Qkw1eWZnamtpTCtnME42NzdVOHdJS0Foam5Dd00r?=
 =?utf-8?Q?pdLf6QJ6VsUCvVDXp85DK+U=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ddf1ef78-9600-43ca-cbb0-08d9e7df9e3d
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Feb 2022 13:09:46.9302
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BzNTlFtTY19FuscGhlIOvehREzEDV/rnP7UZ1W6h9eKAUkWh7YEdOOIsWNGuV3oOvX3RS2FCI7U/+eQ/wbdC0g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5862

On 04.02.2022 13:12, Andrew Cooper wrote:
> On 04/02/2022 08:31, Jan Beulich wrote:
>> On 03.02.2022 19:10, Andrew Cooper wrote:
>>> It was Xen 4.14 where CPUID data was added to the migration stream, and 4.13
>>> that we need to worry about with regards to compatibility.  Xen 4.12 isn't
>>> relevant.
>>>
>>> Expand and correct the commentary.
>>>
>>> Fixes: 111c8c33a8a1 ("x86/cpuid: do not expand max leaves on restore")
>> But doesn't this commit amend 685e922d6f30 ("tools/libxc: Rework
>> xc_cpuid_apply_policy() to use {get,set}_cpu_policy()"), which is
>> where DEF_MAX_* disappeared?
> 
> No. All that happened in that change was that we switched to using
> 
> cpuid.h:89:#define CPUID_GUEST_NR_EXTD_AMD
> 
> instead, which remained the same size until Xen 4.15 when e9b4fe26364
> bumped it.

Oh, right. I did try to look for a replacement, but managed to miss
this. But then, as much as 4.12 isn't relevant, isn't it the case
that the fact that CPUID data was added to the stream in 4.14 isn't
relevant here either, and it's instead the bumping in 4.15 which is?
IOW while I've been fine with the comment adjustment anyway, there
would still want to be an adjustment to the description.

>> While looking at this, wasn't Roger's change incomplete, in that
>> for Intel the extended leaf upper bound was 0x80000008 in 4.12?
> 
> CPUID_GUEST_NR_EXTD_INTEL is still 8, so this is all fine.

Again, somehow I did manage to miss the replacement defines.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Feb 04 13:35:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 13:35:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265539.458929 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFyju-0007xA-56; Fri, 04 Feb 2022 13:35:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265539.458929; Fri, 04 Feb 2022 13:35:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFyju-0007x3-1J; Fri, 04 Feb 2022 13:35:02 +0000
Received: by outflank-mailman (input) for mailman id 265539;
 Fri, 04 Feb 2022 13:35:01 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TTBG=ST=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nFyjt-0007wx-6o
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 13:35:01 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3e40c8de-85bf-11ec-8f75-fffcc8bd4f1a;
 Fri, 04 Feb 2022 14:34:58 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3e40c8de-85bf-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1643981698;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=N+xP3oaBWnSLB+9ZIZjG6LWMDdhaKkmifppjDyNId54=;
  b=WhKakJtwtFGA85pTgG1HCRrcERxtDeec+5MZRg6FfSm7SGwzRpAR5K7n
   xzkHrs5biMvCyXqEFCmDv96EMbCKJIUm1/KaTxJ89g8pl40tsVpeXKMwd
   yG81Y4svtMzYhn2HwoZSvyY+AE3X8d94xd+/Gw+ESaPtitSHz+rP2VcJT
   E=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: kDA+gylL1+8UyRG/76Glu7ct8DT0dp6MguNI/G5Khdnk6wVqk5XFX9L0UNk230xevU55ILSG9F
 P5lRV73EcQCgTgRmLtGxtDlWxGgUojGivpnUgCMmdjd0Ica48zPxSEeFvRDPmxyeoh9kljvmeP
 /ZGN6GItVMB1BNqC4e7FB8xKrjciMfoVn3jfZsyVk3EPnb5xkA+iWpcGvk55svrMgJvm7mm6wZ
 GIpnxKpJjuF8MV9AwxQ7J+kLQLkuMqBI0hf2SuWYEcLOWkUZCYyt8PNxFjYEgbgIMLlay6S48E
 LXjfI+jO6t/Wxk+n70vqTGhE
X-SBRS: 5.1
X-MesageID: 65708420
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:JPbMNaK2YvdtuT5yFE+RO5IlxSXFcZb7ZxGr2PjKsXjdYENS1D1Ty
 mpMXjiHO/aINjbxKN8jaNnk/RhU6MPdmIM1HgBlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokcxIn5BC5C5xZVG/fjgqoHUVaiUakideSc+EH170Ug7x7Zj6mJVqYPR7z2l6
 IuaT/L3YDdJ6xYsWo7Dw/vewP/HlK2aVAIw5jTSV9gS1LPtvyB94KYkDbOwNxPFrrx8RYZWc
 QphIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbrGvaUXe345iXMfwZ3u7hB3Xs4t60
 9h2m6C7SFZzF47JhOYlSgZhRnQW0a1uoNcrIFC6uM2XiUbHb2Ht07NlC0Re0Y8wo7gtRzsUr
 LpBdW5LPkvra+GemdpXTsFFgMg5IdatF4QYonx6lhnSDOo8QICFSKLPjTNd9Glt2ZgeQayGD
 yYfQQtLPDXuJBRlA3MeVa0Ah+ejgVSuSjIN/Tp5ooJoujOOnWSdyoPFMtXPfceRbd5IhUver
 WXDl0zpDxdfONGBxD6t9nO3mvSJjS79QJgVFrCz6rhtmlL77m4ZBQASVFC7ieKkkUP4UNVaQ
 2QL/gI+oK5081akJuQRRDXh/iTC5ERFHYMNTatqs2lh15Y4/S7HKjMPVTN6RuAttZ5sbB8vy
 l2xhszQUGkHXKKudVqR8bKdrDWXMCcTLHMfaSJscTbp8+UPs6lo0EuRE48L/Lqdy4SsRGqum
 2ziQD0W2u1L5fPnwZlX6rwub9iEgpHSBjA46QzMNo5OxlMoPdX1D2BEBLWy0BqhEGp7ZgTZ1
 JTns5LHhAzrMX1rvHbWKAnqNOrxj8tpyBWG3TZS82AJrlxBAUKLc4FK+y1ZL0x0KMsCcjKBS
 BaN5VgBv8INYSrxMvQfj2eN5yICl/OI+TPNDai8UzazSsIpKF/vEN9GOSZ8IFwBYGBzyPpia
 P93gO6nDGoACLQP8dZFb7x17FPf/QhnnTm7bcmil3yPiOPCDFbIGeZtGAbfNYgRsfLbyDg5B
 v4CbqNmPT0EC7agCsQWmKZORW03wY8TXsGr8pEHK7LYf2KL2ggJUpfs/F/oQKQ894x9nebU5
 HCtHEhezVv0n3rcLguWLHtkbdvSsVxX9BrX5AQgYgSl3WYNe4Gq4PtNfpc7Z+B/pudi0eR1X
 78OfMDZWqZDTTHO+jI8a5jhrdM9KET31FzWZyf1MiIie5NARhDS/oO2dAXY6yRTXDG8stEzo
 uP821qDE4YDXQlrEO3fdOmrkwGqpXEYle8rBxnIL9BfdV/C6o9vLyCt3PY7L9tVcUfIxyeA1
 hbQChAd/LGfr4gw+djPpKaFs4b2TLcuQhsERzHWtO/kOzPb82yvxZ57fNyJJT2NBnnp/KiCZ
 PlOy62uOvMwg1sX4ZF3FKxmzPxi6oK39aNa1AltAF7Cc0+vVuF7OnCD0MRC6v9Ny7tetVfkU
 06D4IAHa7CAOcejG18NPgs1KO+E0KhMyDXV6P00JmT85TN2o+XbARkDYUHUhXwPNqZxPaMk3
 fwl6Zwf5AGIgxY3NsqL03JP/GOWI31cC6gqu/n22mMwZtbHHr2aXaHhNw==
IronPort-HdrOrdr: A9a23:4uNjeasCWXhVxwp6+sVqoKpy7skC0oMji2hC6mlwRA09TyXGra
 +TdaUguSMc1gx9ZJh5o6H8BEGBKUmskKKceeEqTPmftXrdyReVxeZZnMrfKlzbamLDH4tmu5
 uIHJIOceEYYWIK7voSpTPIaerIo+P3sJxA592ut0uFJDsCA8oLjmdE40SgYzZLrWF9dMAE/f
 Gnl656Tk+bCBIqh7OAdx44tob41r/2vaOjRSRDKw8s6QGIgz/twqX9CQKk0hAXVC4K6as+8E
 De+jaJpZmLgrWe8FvxxmXT55NZlJ/K0d1YHvGBjcATN3HFlhuoXoJ8QLeP1QpF4t1HqWxa1e
 UkkS1QePib2EmhOF1dZiGdgjUI5Qxer0MKD2Xo2UcL7/aJHw7SQPAx+r6xOiGplXbI+usMjZ
 6jlljpx6a+R3n77VXAzsmNWBdwmkWup30+1eYVknxESIMbLKRctIoF4SpuYd099Q/Bmcga+d
 NVfYrhDTdtACenRmGcunMqzM2nX3w1EBvDSk8eutaN2zwTmHxi1UMXyMEWg39FrfsGOtV5zv
 WBNr4tmKBFT8cQY644DOAdQdGvAmiIRR7XKmqdLVnuCalCMXPQrJz85qkz+YiRCdE15Yp3nI
 6EXEJTtGY0dU6rAcqS3IdT+hSIW2m5VSSF8LAW23G4gMyLeFPGC1zwdLkeqbrWnxxEOLypZx
 +aAuMiP8Pe
X-IronPort-AV: E=Sophos;i="5.88,342,1635220800"; 
   d="scan'208";a="65708420"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=lHhiYTyvGUWL2dPmYXqCzUSw/+CzBoJfKEpwgrp7hUn8QntekfBLW7igkAbc69KMugbfhjS2osuFyXh7QQfDT4ipi8HulN6pOYv9dI6DVFs04SD7U0C+9ttSNjOwA6Ud9uFgsyS7xPTGInMPuXPwDwN/0z2eSJzEeUr3LphJwMfUh9mcdafqJopjP3vy/iuDPWCDATWVjppbO6ic/6HZDitbbptUZwoLSf1wOkeabzrshIcuor0CYGbQ3sLeUK6f6TP5thmsq/tXwuocPkIoHQ48z4QPl95BIFPKSzx+jADwewuYBPw0dGlMMnZfdd0BAlOp/B8mBuJ9xIRmNOIUxw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=N+xP3oaBWnSLB+9ZIZjG6LWMDdhaKkmifppjDyNId54=;
 b=F7BM4Bk05jcWlcFMnnAySUVugMmRMiXbdjm78uG8Hlf5W9Gc/JMUjR7Jz6NFJiPcXQCnoSTUtlP6TuiCIqgMlvhG1Ysfw8kADo6cIY71UqsG1lni/1R9ZS3VR/6/jb2DIh5TBS5Yz9gwr2SUfFaeSMHG1dkbSgLaA8fdqJGy3xQ9jCYWHke1Q27NhAHX/Z0iwqbuVtRYoaLzrQz5foC+ndSduU8guCwMQKqVdwLqkrW8GwR/TZ1aXbNIWURCFFGLnehOGhPryyb3KldgiI84RuiFmheiNbgDV6SHTwZTxCdKaAIqOKormmKCI0ZOC0YUjReI2hI7skD2mHaRZqV18Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=N+xP3oaBWnSLB+9ZIZjG6LWMDdhaKkmifppjDyNId54=;
 b=WFfRgjTgZ4hlqfoXU4nNRnuv2NQ34ZGsq6WZ9R3cDX3gK9fpCMNQWbtYu5uR1mtaAOTNDEz26k5dl2GURrIpM/QydZKron/qaDRPrcQQ/5/kKgWeyuXl/yfxMc+zQ2pI0WvZwISCvq7QxMurSTkYrNVflBsyyXfZhi9HQRPtz0c=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Wei Liu <wl@xen.org>, Anthony Perard <anthony.perard@citrix.com>, "Juergen
 Gross" <jgross@suse.com>, Xen-devel <xen-devel@lists.xenproject.org>, "Roger
 Pau Monne" <roger.pau@citrix.com>
Subject: Re: [PATCH] tools/guest: Fix comment regarding CPUID compatibility
Thread-Topic: [PATCH] tools/guest: Fix comment regarding CPUID compatibility
Thread-Index: AQHYGSl3cICfrTH0c0a6DCprlMhYPKyDEOqAgAA9p4CAABAQAIAABwUA
Date: Fri, 4 Feb 2022 13:34:53 +0000
Message-ID: <a28ff9e8-c022-6384-ee04-c21b69a4fdd2@citrix.com>
References: <20220203181023.1554-1-andrew.cooper3@citrix.com>
 <53b98995-8cef-48b4-7728-3bfbc236af5f@suse.com>
 <f2ce80ee-f30c-dc6f-e4b7-5d8eddb5b3d5@citrix.com>
 <1333696d-d3c2-15a8-1dd5-7cb0a17ef023@suse.com>
In-Reply-To: <1333696d-d3c2-15a8-1dd5-7cb0a17ef023@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.1
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 9551e2b5-a4bb-4120-4598-08d9e7e3209c
x-ms-traffictypediagnostic: MN2PR03MB4685:EE_
x-microsoft-antispam-prvs: <MN2PR03MB4685BD42E4044FBA42F22588BA299@MN2PR03MB4685.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:2512;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 9Zoj93rV9kqmVW+9/t/x6KkfmnqJdUZ/h3M0thGU/clKHoLoGmwAOfWY2w1jyfdB4WhaIz/bNRLmlyGKymGoLLjKBfGgV6xSe7zLYINmoz/zmYowLzhNQSfwmSLks/ODdP0HSBGLvTLcJmkD//LfchV6PzQ1zD0peWiZE6FGA3G6bsEzgdl392S/d5jCZ09tRF8kA0btO2GDlVILAWXVbwdHGbJ47NQnqsdD7QS8QpUV50SCkBuI/+RFluokbwi1IR4Qi8M1bzcJrQ4LCshS3qOI2AjHgtTtZujsZp7rKRQ9rcvQdvncb31kWYax3wea+du2r+hdYwgdbuXOnBoydpeFr+4fQHz0Kp+lWXWBGXNCCBwxFAx/u1KJ8Lvekw2Zv4bi5SEyH183IDOk1h1Wo/VIursYg+wuN8/a6gb/en7T1B3pi9ViaNDhS2Mb5G5Q/GDF7GsC9D1MjAAfHQx7GQ+qtA5hBN5wQC3ZM93/LYdyA0ZzNTpr47FijQ5sg8yGgxTvPkPRsbH9UIqjpRJtRhPGVRRghLvmwc3ovzq1flw8sLYNwVTMydY+ry+QEUshHsPH63tYV2q8KwREx5+4DCfHgwRMrK9yhaCiq7n9pByIVnX+i/+3Cu7BhUIrktHY0BdAuDmS3rUVrwPMk/nzPemC9/IelAZ2kgJU/S4voQNTDy1ppxy9h0Cjn33jbW3Tf4uJ4eRbQObdzre4y7sB42wpYHjMh71RF9lwmxyqg45mOjoYyYFM3NfJN/eBmiLhkCl4SxjFfPbZfxp/yl0jsw==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(91956017)(38100700002)(64756008)(66946007)(66556008)(4326008)(66446008)(8936002)(66476007)(83380400001)(76116006)(508600001)(31696002)(6486002)(38070700005)(8676002)(6506007)(53546011)(316002)(107886003)(2616005)(54906003)(6916009)(6512007)(82960400001)(86362001)(71200400001)(26005)(36756003)(2906002)(31686004)(122000001)(5660300002)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?cmRCVDQ3ZldVU1FvYmdaQXNxZDF0d2pPTXBUQ0F0V3FDdmJ3NVdXSjAzQklE?=
 =?utf-8?B?QTM5eTVGdXBSbTRFR1pFZVkrQTZiMmUreXN4eDhvamdodTh0a0Vlbm54TnNW?=
 =?utf-8?B?S0hnaEFnMlQ3VzJ4aGpxNDlPMDUraGhqaVgrSExONU1pbEtkaFdzek12YWhK?=
 =?utf-8?B?c1RMaWZFZUZZYXAreFRNZGlXTS9Kc3J2cDRDQ1NRd3J3TDRRVGtHZloyNFN5?=
 =?utf-8?B?SmJkcGN3QnlOVDJRdndjR3p4TFBJRTZ1ZjJXc0ZEUWp6OVl0RkN1ZFRJejYv?=
 =?utf-8?B?TEY0UGl3MHlmZ3FQM2hEUkh5bVo1cE1OWkV5YWo3N2YwQXVVaHRGMG1kYkxk?=
 =?utf-8?B?Lytndk9IWk41REtUNjJlU2lya2Mrd043R3Z0Y2lXQ2tRVEhtK3pWcVJtUFFT?=
 =?utf-8?B?WHF1Tkl1REN1czBoTVFNb0xzZ2RCTXVnSytzTDQ5U0owTk9VTzVIYVhsdUZX?=
 =?utf-8?B?aElDVEV1Mm0xSytJM2N1eXdzd3R2WDU5OWJwb3BDZVo3K0w0L0NlT0crK2kx?=
 =?utf-8?B?eU1SNldDZkxLTStNdmJsVjR6enZEVXhIc0F0Q2lXN2N0a1pDNTlpRkE2empN?=
 =?utf-8?B?eHYxeFN6akRpS0VleEFReXVmSFpFNWNxajVjdlpIeWNJaUdzZzBpUEkyS3RF?=
 =?utf-8?B?RW5zTHhxZ0tzNHpUbWQzL2JZU3hyemhFT0JlbzZoSWtLVEkyNDhSUFVhbWl1?=
 =?utf-8?B?WlRQeE4vV0poQS9Xc3kyZzdIUk1MRk5pNzU1S0ZwRnoydDVveThRVC9pSWJ5?=
 =?utf-8?B?NTg4RHZuaHBCcytNeDR1TW1vVit6Q3FCVkg0UW5reDg5aW5LRFd3a1dxTElB?=
 =?utf-8?B?VHVZc1N4NUVNYUhnRTdDVkdncTl5aWc1eldVNzEzZEU3Uk9zZ3RuZUxiMEcv?=
 =?utf-8?B?LzNOQm5aTy9mK3FBVDI0WGtuWkZCU2gwOVFSaEhSbXVXNUpIMjdzR1Z1c0V5?=
 =?utf-8?B?aTBoRUFOYlpHakxvWUNTU3lBWFVIRE1qWjNWSEprb2psT2NLQ1BFVGJ1UDVJ?=
 =?utf-8?B?d3FyQXUzRGRmWktXN2tiV2Z5WGJKOUpZNmdWV2d4Ykp3SEZNQU95L3RaVjJZ?=
 =?utf-8?B?UzRYRGZvcCtBSk5CMis5eE13Nzd5OEZRMFBBQ2RsQVlQazhHRklWTU5WeDFo?=
 =?utf-8?B?SlovMy95eHl0dUZkTEtJWkRKbzJTUXQ4bWV0VzRMUWROL0t1eVdjVHZBeXZQ?=
 =?utf-8?B?cFJHUVFNZi9XbDBnSFdseFNlR3hIY1JncmU1aTRBdDlnRHpaa0w5NXpMY0JJ?=
 =?utf-8?B?ZkR1SXQzRTMzeE91bEVCRGNDZWl3cVQwV0dsMjhwU2xVaUtZVWFpL0dETnQ2?=
 =?utf-8?B?dkg3L2UyTm1mSEQzYjdBRjZjak1yRVBPQkRCZ3N1OFl5TXJLclRQWVJ0dEVq?=
 =?utf-8?B?RlFna0hBbStoL3NwUGVNZnFiK001alRyTG5DV3ZnMkN6cTFzR3VoMVZSRzV5?=
 =?utf-8?B?RUFhVFJpd29kM0tEK24raDN4Y1Y2QXBJL1dzbVJXS21qcGVSVWdPdGJkVUF5?=
 =?utf-8?B?RVc2TEFHcUl0RDE5cTBpenZqcDdsN1ZvbmRja0VpdGtyQzNkcnBCVXF3bEs1?=
 =?utf-8?B?eEthaVJMSitzU2ZENWhocXhFYVFpVGxVWXMwNHhqTHBhN0hIT0F1ZGhyNE9y?=
 =?utf-8?B?TmkzZFZzOU5XQnlwOHpMeUN0eUJIODdwT1Y1UmcyUzhlTmY1UXBFT1Fzazcx?=
 =?utf-8?B?SWZ1Sk1odDVhenFhQm52cmpodDkvakhVdEZ3QkhLS2ZOQTV5YXVnNVBHQ0dT?=
 =?utf-8?B?dVlISUlXM3BIQXhrVkxmQjA5R3BLYlpZNVp1dWoreURxTnNDTUZ1VEkzREw1?=
 =?utf-8?B?TEZJc3QxeHBpTSt6Z0t2YkFLUDNORGtKc2lYa0pDNHl4TExYcDVoVHZOc3Nq?=
 =?utf-8?B?RUFVN3AyZXBvdWFpSCtVLzRFQk44WE9WV203L2NnQzMxRzFDL2gyWnErV2t4?=
 =?utf-8?B?WEFvMlVYVHMydklrQ3BEeVErbEtuODNzWlhveHNSWVZPRElBUWNjS0prc2Q4?=
 =?utf-8?B?Zk1YdlRtcUpGNGZhOGNZV1R0M1M2ZklodkxoaGYwbHRZMCtyY2tjend2cEM1?=
 =?utf-8?B?OHNOOVo3RnRmUExBeFd1czVZeXRYOHZEakNjVlVuaGtHZDNWaVRPVnJHMDlO?=
 =?utf-8?B?N2xvczVzZlAwMi9pb2gyeWR2T3VYYmJ6SnkrRkliR0xBaFdST0NxdDloS3Z0?=
 =?utf-8?B?MjZ0V1BhOWlndzJhTmNWU2FtV1hSek5uRlEwcE9zREwzTStzM1lwVS9qVHBh?=
 =?utf-8?B?a0RObG1ldnMxNjlFZGdjNCtnKzN3PT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <04C3A3361E4D1C4290EA2A2F4DC6115B@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9551e2b5-a4bb-4120-4598-08d9e7e3209c
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Feb 2022 13:34:53.5965
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: jWICgYgPFv1tINfB522/yU4/6L1Dd3X9WAuaRl+d8FF89AqFEM7E2TLqw5PFFcZdw+IevnLY5sOqK0cL/yrdRZjQnR+Gd7lcqYq6v1/3iJE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB4685
X-OriginatorOrg: citrix.com

T24gMDQvMDIvMjAyMiAxMzowOSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDA0LjAyLjIwMjIg
MTM6MTIsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBPbiAwNC8wMi8yMDIyIDA4OjMxLCBKYW4g
QmV1bGljaCB3cm90ZToNCj4+PiBPbiAwMy4wMi4yMDIyIDE5OjEwLCBBbmRyZXcgQ29vcGVyIHdy
b3RlOg0KPj4+PiBJdCB3YXMgWGVuIDQuMTQgd2hlcmUgQ1BVSUQgZGF0YSB3YXMgYWRkZWQgdG8g
dGhlIG1pZ3JhdGlvbiBzdHJlYW0sIGFuZCA0LjEzDQo+Pj4+IHRoYXQgd2UgbmVlZCB0byB3b3Jy
eSBhYm91dCB3aXRoIHJlZ2FyZHMgdG8gY29tcGF0aWJpbGl0eS4gIFhlbiA0LjEyIGlzbid0DQo+
Pj4+IHJlbGV2YW50Lg0KPj4+Pg0KPj4+PiBFeHBhbmQgYW5kIGNvcnJlY3QgdGhlIGNvbW1lbnRh
cnkuDQo+Pj4+DQo+Pj4+IEZpeGVzOiAxMTFjOGMzM2E4YTEgKCJ4ODYvY3B1aWQ6IGRvIG5vdCBl
eHBhbmQgbWF4IGxlYXZlcyBvbiByZXN0b3JlIikNCj4+PiBCdXQgZG9lc24ndCB0aGlzIGNvbW1p
dCBhbWVuZCA2ODVlOTIyZDZmMzAgKCJ0b29scy9saWJ4YzogUmV3b3JrDQo+Pj4geGNfY3B1aWRf
YXBwbHlfcG9saWN5KCkgdG8gdXNlIHtnZXQsc2V0fV9jcHVfcG9saWN5KCkiKSwgd2hpY2ggaXMN
Cj4+PiB3aGVyZSBERUZfTUFYXyogZGlzYXBwZWFyZWQ/DQo+PiBOby4gQWxsIHRoYXQgaGFwcGVu
ZWQgaW4gdGhhdCBjaGFuZ2Ugd2FzIHRoYXQgd2Ugc3dpdGNoZWQgdG8gdXNpbmcNCj4+DQo+PiBj
cHVpZC5oOjg5OiNkZWZpbmUgQ1BVSURfR1VFU1RfTlJfRVhURF9BTUQNCj4+DQo+PiBpbnN0ZWFk
LCB3aGljaCByZW1haW5lZCB0aGUgc2FtZSBzaXplIHVudGlsIFhlbiA0LjE1IHdoZW4gZTliNGZl
MjYzNjQNCj4+IGJ1bXBlZCBpdC4NCj4gT2gsIHJpZ2h0LiBJIGRpZCB0cnkgdG8gbG9vayBmb3Ig
YSByZXBsYWNlbWVudCwgYnV0IG1hbmFnZWQgdG8gbWlzcw0KPiB0aGlzLiBCdXQgdGhlbiwgYXMg
bXVjaCBhcyA0LjEyIGlzbid0IHJlbGV2YW50LCBpc24ndCBpdCB0aGUgY2FzZQ0KPiB0aGF0IHRo
ZSBmYWN0IHRoYXQgQ1BVSUQgZGF0YSB3YXMgYWRkZWQgdG8gdGhlIHN0cmVhbSBpbiA0LjE0IGlz
bid0DQo+IHJlbGV2YW50IGhlcmUgZWl0aGVyLCBhbmQgaXQncyBpbnN0ZWFkIHRoZSBidW1waW5n
IGluIDQuMTUgd2hpY2ggaXM/DQoNClRoZSBmYWN0IHRoYXQgdGhlIGJ1bXAgaGFwcGVuZWQgaXMg
cmVsZXZhbnQsIGJ5IHZpcnR1ZSBvZiB0aGUgZmFjdCB0aGVyZQ0KbG9naWMgYWRkZWQgdG8gY29w
ZS7CoCBUaGUgZmFjdCBpdCB3YXMgaW4gNC4xNSBpcyBub3QgcmVsZXZhbnQgLSB0aGlzDQppc24n
dCBhIGxpc3Qgb2YgZXZlcnkgQUJJLXJlbGV2YW50IGNoYW5nZS4NCg0KQ1BVSUQgZGF0YSBiZWlu
ZyBhZGRlZCB0byB0aGUgc3RyZWFtIGlzIGNyaXRpY2FsbHkgaW1wb3J0YW50LCBiZWNhdXNlDQp0
aGF0J3MgdGhlIHBvaW50IGFmdGVyIHdoaWNoIHdlIG5ldmVyIGVudGVyIHRoaXMgY29tcGF0aWJp
bGl0eSBwYXRoLg0KDQp+QW5kcmV3DQo=


From xen-devel-bounces@lists.xenproject.org Fri Feb 04 13:46:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 13:46:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265547.458940 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFyv4-00011s-TD; Fri, 04 Feb 2022 13:46:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265547.458940; Fri, 04 Feb 2022 13:46:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFyv4-00011l-Q9; Fri, 04 Feb 2022 13:46:34 +0000
Received: by outflank-mailman (input) for mailman id 265547;
 Fri, 04 Feb 2022 13:46:33 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1gJ0=ST=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nFyv3-00011f-Fd
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 13:46:33 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id dc827ebb-85c0-11ec-8eb8-a37418f5ba1a;
 Fri, 04 Feb 2022 14:46:32 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2053.outbound.protection.outlook.com [104.47.14.53]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-11-1JHuihyKMcKqHmiAz9YvoA-1; Fri, 04 Feb 2022 14:46:31 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM6PR0402MB3576.eurprd04.prod.outlook.com (2603:10a6:209:8::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Fri, 4 Feb
 2022 13:46:29 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.014; Fri, 4 Feb 2022
 13:46:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dc827ebb-85c0-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1643982392;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=5Uq4wIgYy4oViaNP3YfY+i1MlGYq3bPdpvji8IhZvys=;
	b=SLY1lqBWzXitbhykDZae9odVyRv9Hp8Liy4AA4Vncq61hWA5FGGYWa2g3w3KrxWUV20t2P
	fCD89tJLONU5P5DBof/cOD6tgr8olblN5qn+LiB+t2DIAU3Un+r/tcV78PKVg4RFNdkARM
	zTd83ak1V6ysXplOjJWjoL4qs8bS1O8=
X-MC-Unique: 1JHuihyKMcKqHmiAz9YvoA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=RGA+2Ylo2wt1D+KQl00TGefAhmphPqX3sUUXSdrs2RerNjA+Gk5+3Sn6O0oN7fTK1s+2ZMQaACmX2I7vOUolB7BoQV8xtOvcXu5H457uZH920IC+Xvri77nEsLAb42JEnAfyhTt8z36D597oOulVXb2ipRk4H4vEYzfQ/aCA1QCtc723r+Nf4vugQcMCmU3maWNABtzHAFR2ES0UO9DF6te1f/w7bHpb/W4+Wed4ljyEq2q7hn55TxXDmz2fvdG+FiFa1waIi9aVUP1poEIA0W6m/dRYimq2JGLIawycEd4kl1YY4WHgbsJ/+J10uZL7BeauX5u9BCMFaXbVEyXLzg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=RyfF67Jj3oWm+xcD9BoIoW5ugD3+fW+zjhMlKkWfeaI=;
 b=JmTWbeCvYomD3ILGketi6iDsIj8K/Ojd+bZezH0Ncmb71xO+vBtgvq9cFyk42XBOiLkjLLw7ldf5792C+YpRZ6eXfcyC3P+YlTbzDlpy2l3C/NarmheIeLs/TqzSf/q6jyDWX5vueL4TFPC9GTAVPxmityvYWsf1qSRi6HVLS4as6Qj88LbgxqwRXFd2v0PAUz9J+wedr/GmfyI9Zs/ARniJdb80YmGdU9I5aDXCQFMs1KnzYWzP1xpCXOgVP/hc+DmIghqP+1oH5qdcu2yN/s2T++1jR5Iexh1q0EfxsQx0oApL7S+VtU4hSWbbWOUygddD8QEz1tKo93TjYtBk6A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <eb818153-3ada-ac46-fb14-da975a61574f@suse.com>
Date: Fri, 4 Feb 2022 14:46:27 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH] tools/guest: Fix comment regarding CPUID compatibility
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
CC: Wei Liu <wl@xen.org>, Anthony Perard <anthony.perard@citrix.com>,
 Juergen Gross <jgross@suse.com>, Xen-devel <xen-devel@lists.xenproject.org>,
 Roger Pau Monne <roger.pau@citrix.com>
References: <20220203181023.1554-1-andrew.cooper3@citrix.com>
 <53b98995-8cef-48b4-7728-3bfbc236af5f@suse.com>
 <f2ce80ee-f30c-dc6f-e4b7-5d8eddb5b3d5@citrix.com>
 <1333696d-d3c2-15a8-1dd5-7cb0a17ef023@suse.com>
 <a28ff9e8-c022-6384-ee04-c21b69a4fdd2@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <a28ff9e8-c022-6384-ee04-c21b69a4fdd2@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM5PR0101CA0027.eurprd01.prod.exchangelabs.com
 (2603:10a6:206:16::40) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 96e50411-88c4-4345-4a9a-08d9e7e4bf1c
X-MS-TrafficTypeDiagnostic: AM6PR0402MB3576:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<AM6PR0402MB3576C1992BBA78C3B597AEFFB3299@AM6PR0402MB3576.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	OvVbCQyqCPFAEcRChG6D41muKfihuTKN4zvoSMZzbWQDZQpwiIJC7Fd5s0pwwA4djrtEF2Rr3R/77R35He9+8pGifE5YLufp9YJb0NX/4hs/J+cxTlUbcbgyw/gOyRZWW4WWj73w26dI0zxK3lYnhGtfJSNn7maUI33Ltj4wp7Q8LbVoCyCYw2N+CBGfhdEhLpr7P9JuTIDud47uJ8nI3DcxvBHmIPempdXCLWRu8zWLjEpbXYTkgOuPck1jFUBPp1uHvkfp3vdLSmtj6g5adY6lWG9gnnVWQmTbaIbA6ZWTUHXSQsOeziMxy4D9d81Y/Uh/T/wEUVu+nskEOeSEkEzoMNUQ2/imDn1kyzSYqKA9xDnLPYw1rbgXMDSdaE2WCyJSCwn2+pWI7xt4NCssyJIzH2e9zHBiCrAw3X3NBDf/edjwUgsjZeKfyrgBcVYZNr+8qnNpdEczRyJrOk4xH+nvsgjiklOOvpJtv9Y1sJuH+zLaNSq7tTULs35nzGHL2TLW8cSQZzcUfMj0rbtqnPU5vfivOr+93su0d9Q3nlQ3Y+nYwDJSizuIP3YwrROwPYe8ZY86qm3tJKguSXt7rc02yA9vIsr9ZUJULE81myJfv808TYmUJ8sKGFccnfqJBl4emiKwNP8CcQiX8w3OvwoLTB6MhjCkwsMFyxyis8pOn8XCXcsjd9JYl8F0MXZK7ysLXrOTuwMroEwYp7R/GV0c6JEJfhCHdkzPYtBC95M=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66476007)(2906002)(38100700002)(8936002)(6512007)(8676002)(53546011)(6506007)(26005)(186003)(66556008)(86362001)(66946007)(83380400001)(4326008)(5660300002)(2616005)(31686004)(6486002)(316002)(54906003)(6916009)(508600001)(36756003)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?VsBccw//Dp8TWl7I1C/Mf6EapNXNquFafYXKnbmk+LSYQBJtjJFJEWxQS9kY?=
 =?us-ascii?Q?mG+NwWhOe0wHm4Ue7xoImXo6EtUJ6o33Omgw17Zu4D0JzMXhyKbTc+Qw7jiJ?=
 =?us-ascii?Q?tuIgx+63uOg4FyeZZnH0nWALCSfPTlbI5XpWsnO5FpQaJfA4SqJ7zbJdBMf8?=
 =?us-ascii?Q?IW292JE5SS2oAfH3WD0COyGlkjhP/jL6yoCUS1SD+S2RPgXlwD1gxx6Z/odM?=
 =?us-ascii?Q?9qCkjxT0KS3BYUmgrDJmX3wnOxSFjH9f23+8SrqsFuF3Zx1+r9gcFl+Udi/q?=
 =?us-ascii?Q?9Y2p6fhbB51fG7R/DbulsLtmqE4pvCfoc66hJcR2uT+ijFcSYhJIgJYfxOe5?=
 =?us-ascii?Q?LcqTTqWta6asGOpNXi1eC77m3y+M0lhnQ08SR3dXup3OjfkR7nUZf+lx9f0n?=
 =?us-ascii?Q?ZBc0ktbWi2sElrctEr2BMVeSCRLX3fl/mkM+d622a3xzIl01co0Zkbm/wy7n?=
 =?us-ascii?Q?lMnuKGxvul5eR9QZiHVF3zrzVbAOJLoPqwe8Ni8vGTFpvsnkr8vI59NK2UFg?=
 =?us-ascii?Q?iZ3ql551nhoMCKn9UpPbWpTrsE6Y7p+eAAEsfxCvo62iBuEvC2h6JqIa2FGM?=
 =?us-ascii?Q?BX+HolWrmVUyzbmVcrY4WyPoPqpJtQo+0vJv9vT3w5BalmRfmVs21I9UNq5f?=
 =?us-ascii?Q?iJIyQGDMjfJIkwPGxMBp2NrnTq3WLNiYYYtyyZlwTZEbhN2TcVHwIp8Akk65?=
 =?us-ascii?Q?ZD78SZAre7yxLh/ZdIFJarAiU4JG31A9NUUfLWaK0nn47wwSPGSU14SotBGB?=
 =?us-ascii?Q?dbPRYA9I9+DBMGcGkFbJFbrD57t89scqVDDNVjnoS0qc9UyB5ZBLxnIEx0MZ?=
 =?us-ascii?Q?fAWw+aiMRRmTCklSc0Gfs5K/PR3eE0ZIMWeAhz9eCNryUQ8d4j6XLiNevvq8?=
 =?us-ascii?Q?Vord92C8XyO1bUkDEsMX04d0CGDmYfklCtissjzO80MBB7gMUWigYa8rmCiz?=
 =?us-ascii?Q?IZpvMMotPZhcLp1h6DXH5awATzbjCQTZygKo3HQ9RfzRRdJ6zp9yjJK3l+Sh?=
 =?us-ascii?Q?NrxGj8aq+1qsBPZPNSs09MEsShMeVOT4v9gHJI2yamgXp/QQiZPmAuyA8hgo?=
 =?us-ascii?Q?mryabKK7Assz8mwiWfV6MnQl5FHhLPxRO0Kr8CHlSe2mwRAf1d2UmbnYLluA?=
 =?us-ascii?Q?USxLMKwsebzBRIoYuNKkuHStsOf/T/AqzSUj5AAQFFCcBNW/TTYRGfoVVpzd?=
 =?us-ascii?Q?0n128Q7EKXXzqvy20HdK/JR3qspVKJcFT6vr5FFDndokfn7oq9mRsVaVvRVv?=
 =?us-ascii?Q?GHTtClTYu2DA6WYfu/DDtad0gXR1yIGxOQ5dxWIn3W99IBn44f1/r0+FkOti?=
 =?us-ascii?Q?+XEajqy5hvZio4B6UOl6Vs042R0Z0gghcvmB4yU1n1C6LcR5QX0w68JDw2vK?=
 =?us-ascii?Q?2T8SSio9cIUcsG77ztypUz6pYYNyrpoYhYAvTmcMuHUGNys54Gd4OUqFykxL?=
 =?us-ascii?Q?dlMffniBTcSIPnnsdYV0Sgs9wVNhGPH7KhHe9djHRMTgocTv7bgsRR8zmmTO?=
 =?us-ascii?Q?tlToNqeqhD2NA5c5R+S8VPtc7UXPwp5KT8d6HsaGRNSOFrXmc0v+/RgXj46H?=
 =?us-ascii?Q?CSjEJhNvGOZw2EMRNlcAcSf8Bh+NVd7PdLTMM0CdwXn5p0pkl+snuJom0SXB?=
 =?us-ascii?Q?nSo2d40cc504oW03Za7ks/o=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 96e50411-88c4-4345-4a9a-08d9e7e4bf1c
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Feb 2022 13:46:29.6685
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1xHse4oGwBMmMsHHWyqOev40ohxyomWH6TmZRPNXQu1Xy3/lnfmof+b6/ZUCpNZ8A5hHCcJs1k7oFjVefzpNJQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR0402MB3576

On 04.02.2022 14:34, Andrew Cooper wrote:
> On 04/02/2022 13:09, Jan Beulich wrote:
>> On 04.02.2022 13:12, Andrew Cooper wrote:
>>> On 04/02/2022 08:31, Jan Beulich wrote:
>>>> On 03.02.2022 19:10, Andrew Cooper wrote:
>>>>> It was Xen 4.14 where CPUID data was added to the migration stream, a=
nd 4.13
>>>>> that we need to worry about with regards to compatibility.  Xen 4.12 =
isn't
>>>>> relevant.
>>>>>
>>>>> Expand and correct the commentary.
>>>>>
>>>>> Fixes: 111c8c33a8a1 ("x86/cpuid: do not expand max leaves on restore"=
)
>>>> But doesn't this commit amend 685e922d6f30 ("tools/libxc: Rework
>>>> xc_cpuid_apply_policy() to use {get,set}_cpu_policy()"), which is
>>>> where DEF_MAX_* disappeared?
>>> No. All that happened in that change was that we switched to using
>>>
>>> cpuid.h:89:#define CPUID_GUEST_NR_EXTD_AMD
>>>
>>> instead, which remained the same size until Xen 4.15 when e9b4fe26364
>>> bumped it.
>> Oh, right. I did try to look for a replacement, but managed to miss
>> this. But then, as much as 4.12 isn't relevant, isn't it the case
>> that the fact that CPUID data was added to the stream in 4.14 isn't
>> relevant here either, and it's instead the bumping in 4.15 which is?
>=20
> The fact that the bump happened is relevant, by virtue of the fact there
> logic added to cope.=C2=A0 The fact it was in 4.15 is not relevant - this
> isn't a list of every ABI-relevant change.
>=20
> CPUID data being added to the stream is critically important, because
> that's the point after which we never enter this compatibility path.

If the bump happened before CPUID data was added to the stream, logic to
cope with migrating-in guests would have been required too, wouldn't it.

But anyway, just to be done with this:
Acked-by: Jan Beulich <jbeulich@suse.com>

Jan



From xen-devel-bounces@lists.xenproject.org Fri Feb 04 13:53:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 13:53:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265555.458951 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFz21-0002VN-N7; Fri, 04 Feb 2022 13:53:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265555.458951; Fri, 04 Feb 2022 13:53:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFz21-0002VG-HW; Fri, 04 Feb 2022 13:53:45 +0000
Received: by outflank-mailman (input) for mailman id 265555;
 Fri, 04 Feb 2022 13:53:45 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1gJ0=ST=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nFz21-0002VA-0P
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 13:53:45 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ddcd0af3-85c1-11ec-8f75-fffcc8bd4f1a;
 Fri, 04 Feb 2022 14:53:44 +0100 (CET)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2055.outbound.protection.outlook.com [104.47.12.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-17-XOte82LdO46m_Upetux8Ow-1; Fri, 04 Feb 2022 14:53:42 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DBBPR04MB7835.eurprd04.prod.outlook.com (2603:10a6:10:1ea::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Fri, 4 Feb
 2022 13:53:39 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.014; Fri, 4 Feb 2022
 13:53:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ddcd0af3-85c1-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1643982823;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=+MY/lD1JtK8C2rlX1n7vsJEdpJ2aqLEXe5vkiEi7t6E=;
	b=Xuhm1EX7XxUY5C+kzUiIcO6Qikj/8eDXZXd9n/3qLXzXriz4EpPEPywM2/mtql+bFR1Y4e
	MSBRPYMehyS9ikgFqWAZGDWMqxdwFsf+0DKAZQWdUV5qWoTVhlYNjkKAtHQ0voxp8z34dI
	Kn7a/HP3udLhDpSYlzEq86GEy2U8xP0=
X-MC-Unique: XOte82LdO46m_Upetux8Ow-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=WGbyMJhzlujMTied3LlP3EcRD3J+Vbio9aVfLRvKkl4BiE+SD8BvIixvxzv24bADZYMu1M8PoaQsPdYhK4k4jP5H6n0zeQLAglY3hle9vzs2u7Mka6x3PmzmjqX2jYXWxrS6LuW+q7S8sZucnxGERWE0v+ohvDJCiM+1jWlOTaS4NfWLiRuUvWvAgAw19YBL7h3NZ3RDp7nbcMziDQXRmKEROvh7OLWlQv3Q70S9jM38lyN+uQx0MuX21G19yVbxnk4Xur/7cGYIopxUnn91SQ9Ekg3M7PjJ0Rtyql9ic/1B8HDH8fYlFcticjTKNcymTqYK/VXS9xaIW4RZTtxBQA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=+MY/lD1JtK8C2rlX1n7vsJEdpJ2aqLEXe5vkiEi7t6E=;
 b=dCeLr6IayNq4sgZCqPCoxs53YAmemQOdB+MmY5DEnF4GA5SyYAKUs2ry3jE3P33Il6SZXxiMb4xcMidCRf9vXWRHsVkwDaJYGlz4sGH5//V+hzOr3d7TIUjl0aVo8cTBCYp0IP/5CDRFO8GRCworAm2QswPpgjv7E3rFvdWXjn6xD4em9y4+9QdSGFtc9sfzKNi2gFL787mpRbezAyq6t1QEi6RgcZ7/NOCqO+781K4b3J0YfI8BW5+sCqLwNK7YjzcHRRQ8Qh0iiw63qN3XUNNpJcywuVdJ+VYE6t8UxIAuWpN5QIuDrz9kFnwMwzY+kz07fwnpe2yQAVjiovppBg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <a6173683-caf6-b1b7-aeb5-eed637d14a0e@suse.com>
Date: Fri, 4 Feb 2022 14:53:37 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v2] docs: document patch rules
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220203125438.21807-1-jgross@suse.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220203125438.21807-1-jgross@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR07CA0025.eurprd07.prod.outlook.com
 (2603:10a6:20b:451::25) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 3f689e08-ecf3-4585-c7d3-08d9e7e5bf69
X-MS-TrafficTypeDiagnostic: DBBPR04MB7835:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<DBBPR04MB7835AAFD34A8BC70111A7998B3299@DBBPR04MB7835.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5516;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	WW45dXPYSrJlMP3V2/GvQ8hgE/GG6gva6QViu/Qc045sQoUyRftB/hZrS/dTU59I1nWEc5L4+Bt/bEl1LG/374qVcz8sa76COm8d2/+Ps1deZi/K4HeDoaQi0UksJSMu0270kKb77r1Rpvd5vVQkb9sSG5gEDT8lPCmagJU2Bl0iZl/gki9IeN8TsWnQdfYRJt7I2t2RKbx/DckK9G7672dEY//EPvdbo1bMCx7CMeywLemFyYZY+xlbmMdvgHuXdUmaLssRImvMs9n1EtKFGL4QodPAmz6vAYOxWVq9mszcUQpltYp+RhELxiSWO+ikbceeiAlM1eZqY4GWkiONgewYps5Fto/i7pcsSBMYxLsclxNvjtdPbHoBGFbyI9GDz7YwRlFfSwkCJ+YMOHCcs73zx0x81k1MeiqZ2oO/5Lv8Kn9efgvT0s1Fhxz2W3f8eoBSAqViHDoBy6AVyVEXGsycYO4To1Ipi1YqG6zrYpKsUFkEyNtF6cGhKVZqtg5YSrgi7CSpkgwv31fuVxa5hzyvIflVLP7lSVooiQjUMl5EnqA1JVo6wKOnW+L4Lh0kBE1cc9Zry51o6y0ZhZSeeCaZ+LdEHUm/yBasdpkvlqX5VPQiy95tHTA7uqm/3RAPxGE8eT/4/miIdMmMb9L6lODswbcv8o12VEscGn2e6bjntqbnNjFYSO3zjpgph4Dyrq/S9lf0rPB3KodZedJYT4KyI6d1EXMRTDvK5TV+X0VeMnrP2omBb2krMFzCrcAw
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66556008)(66476007)(53546011)(5660300002)(6486002)(6506007)(6512007)(4744005)(508600001)(66946007)(54906003)(38100700002)(37006003)(316002)(4326008)(6636002)(86362001)(2906002)(26005)(36756003)(31696002)(6862004)(31686004)(2616005)(186003)(8676002)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?a0FZeFEvMi95RzlHRFdtWm90RHkvcERnaVkrd2o3VmtPMUk5ZU0yd0JZTlFE?=
 =?utf-8?B?QlNoOWNrVXhqWWpQQUpDMUEzYjNJdlZIdVJ3b2NlL29nMVRrMkdSMjV5TGZV?=
 =?utf-8?B?RjJyb1phMjI2OVhCTlFzejB4bzRUSXhUVUpSYVFUcXBMK25FYm5QdEJ3WjZl?=
 =?utf-8?B?TDJkZWRnMk1kOU9uN1VQZS9sODVrVjV3TE81b2RCdWNCRFI4Skx3SkF2NUxk?=
 =?utf-8?B?TEtWNkhLUVp1T1pYWk5pYWwzZmFUamIyK3ZRbnZ6ZldndVZ1VDVRVnNUeEp5?=
 =?utf-8?B?bTdlYUJOR29LZDM3MmhWR3pWRmZ4V2pZeVNOU3BueENVKzlpQXF0SlB1UnRx?=
 =?utf-8?B?QlhKL25pT1RZemdZU1dKYXRvMHdnL1dNS09IKzdhOGFMb2V1N3pwamd5Vmlo?=
 =?utf-8?B?TysvMVRkS25SNlZWaW14MmVFRTlGSDlkSTBnUGcyWHplVlNKWmV2SDFZNHZv?=
 =?utf-8?B?L2pJVVhOamZ5dUhaVUc5aXRtRjZYc09vZ1dKNGRpbmU4bGhqZDBxcUZRb25h?=
 =?utf-8?B?YTQ5bzFaaW9lVU9uRjVwbkRpUUcyOGFCMDF5bVl5c2d2UDhyRlpEM3QvK2Z4?=
 =?utf-8?B?TDJoZkRKQUJaN0dlcXd3TGVMa1diODlNYklyaWFEM09jTHFQbEpJMjE0YkdY?=
 =?utf-8?B?eHlNZUQ3bDQ1QXhmanU5Z1BjbkZQM3RQZWlvTGFyaFFrQjJhRjEzWk5QeUpV?=
 =?utf-8?B?eTlPRDJZYnNPanhEeVZDQllXaW9QMS9vMTZYTndWRitscGFUOU9UMkZaclpS?=
 =?utf-8?B?MHhpMjcvb0hGMWpvUUgzNERybGNxa0RzZUs0S2Ewa2JoL1FKMWRkam1rM0sz?=
 =?utf-8?B?c3RDbmNwc3hOa2FIL25sclM1cTNLWktaSEZ3YVpzUWN2MlB5NEV1ZkxuaXhN?=
 =?utf-8?B?VGM0ZzJVbU54ZFR0MXA0OXhnRit5MGhzRkVNdllLZkE2S2tZZXRWZ1hnNHVr?=
 =?utf-8?B?TzdvNW02OGdtZ3ZZdHFlVGd6MXZvZEtRQlVQUm92YnZzeSthaktETElvRHN5?=
 =?utf-8?B?Rm0ySElyRWhycGR1eVBHVVBMUVk5MXdjUlF6T3hCWjB5TWFCMzdNSjhVNDJi?=
 =?utf-8?B?QlhycHhCcCtFN09vN29YejJadDU0dWZ1b3h5M0dPY3A1R0tmUjZ5NnFReGVl?=
 =?utf-8?B?a3dwODFLcU03d1padnZnTmFKYm1TdURZdXowak1yODR6dWhQTHhSdGpMeGpW?=
 =?utf-8?B?WkZHVlVyVEZML3YxSTVCem0xeE9VOEJyc2EvVlZ1WjBibVl6MnhUN1dyNEF6?=
 =?utf-8?B?a0diT3JqZnpxNXRHYmRrQ2xhaC8rR2tacmxMNUhzbFBkWldxZFFtbEVyaGRJ?=
 =?utf-8?B?ajZMMVQ0b21RSDE5aXpjTWVuNmRVUU1pU3p2YjhGYW44UnlMZjhPNGRTMzEy?=
 =?utf-8?B?YStYKytPU2dqbVJsS2xSZWpZTklPalR2R2VFUks3Tnoya3cwVFR2allNRmRj?=
 =?utf-8?B?MVpRczM4Y2F3WnF1UG40eWg2dVI0Z2dNYyt5RitqSmh1ZnAyQnVSVVkzQXRT?=
 =?utf-8?B?a0dkc1hBaC8rcmQ4cU1iVzhVK0pVMEh4c3FVRFZmZTFqZHdJbG53Tll3SitO?=
 =?utf-8?B?VFdnZkdRWHJRQUQxSmFDQ1ZPZUg0eHhlT01uSk45OGo5VjFWSHRPTUNmeXVW?=
 =?utf-8?B?K0E3ZFdnMkc1aUkzYW9qd25EY21aSnJoOExPd3ErUlM1bWZ1b1FrS2FTTEVh?=
 =?utf-8?B?aWRZZmdPOXZuZjUrSVhweWtoMkxXUHd6UDl1ZitUMWdWOXBwSEhwNXpra0F5?=
 =?utf-8?B?dStHVjY5VThnOWhxN09UQzkzQVhvR1Jrc29VVW4xL0poS3NFMnJaRStQY0ZQ?=
 =?utf-8?B?OUVtQVhNTTZVNlFtSk9ZQ3ZsNjdLK2V3M3FQOWFLNnJTNlVIb3V0WXczVmhD?=
 =?utf-8?B?aUdmZmVwQzBnWHljQlpLMEY2Ry9XZmIwYWpia0x3R0RNbjZTK0tmTTNYY1VM?=
 =?utf-8?B?SS95Yks4bGtOSTZ0QXk5WjdwZG9zekR3aG5NcXRKYXBQZDdJem90dGgzcW9i?=
 =?utf-8?B?ZnBCMER2R1Fsb1kybng2L1I1VFdTdE5abWJPSml2anIxQkpKRytYejJmcDNu?=
 =?utf-8?B?bFFPSjRUdkppcHpNUEp5a3Nqb2NvdHJvbEpscDV6Y2VweCtlUUNCQmpBYUVa?=
 =?utf-8?B?QVpoV2luOHIreXdIRW5CZFMzYUhua013eE90UmdrZS9SY2VVeHBKN0p0TjQx?=
 =?utf-8?Q?YcXvOd2p01Lu4lyEqzQBOno=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3f689e08-ecf3-4585-c7d3-08d9e7e5bf69
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Feb 2022 13:53:39.6574
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /BVrHV4cgq6yFTMY1mNFUPLPOET3G7paCdQKsyyIjYCEZLuJAWqYtTsqwNo049q5vYCjG1QCoVxXyGAWls6J5A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7835

On 03.02.2022 13:54, Juergen Gross wrote:
> Add a document to describe the rules for sending a proper patch.
> 
> As it contains all the information already being present in
> docs/process/tags.pandoc remove that file.
> 
> The "Reviewed-by:" and "Acked-by:" tags are expanded to allow an
> optional restriction of the tag.
> 
> A new tag "Origin:" is added to tag patches taken from another project.
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>

Acked-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Fri Feb 04 13:56:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 13:56:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265564.458962 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFz50-0003Ao-8v; Fri, 04 Feb 2022 13:56:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265564.458962; Fri, 04 Feb 2022 13:56:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFz50-0003Ah-5V; Fri, 04 Feb 2022 13:56:50 +0000
Received: by outflank-mailman (input) for mailman id 265564;
 Fri, 04 Feb 2022 13:56:49 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1gJ0=ST=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nFz4z-0003Ab-8u
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 13:56:49 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4b7acca1-85c2-11ec-8eb8-a37418f5ba1a;
 Fri, 04 Feb 2022 14:56:48 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2058.outbound.protection.outlook.com [104.47.14.58]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-29-01_o3IveMxGxI8fmq-bljQ-1; Fri, 04 Feb 2022 14:56:46 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DB7PR04MB4538.eurprd04.prod.outlook.com (2603:10a6:5:2e::18) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Fri, 4 Feb
 2022 13:56:45 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.014; Fri, 4 Feb 2022
 13:56:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4b7acca1-85c2-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1643983007;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=hqXtvA8QT1El6gi/VOf+F8xHktquhDqteU2+BYDQISo=;
	b=Yqg49wDP1wsl+zYjZFNl+QJcuNds4g65tl6TCRpTQ3pMMtrNUxAPrE4nB2BCHnt0J4BRmI
	sSmtdq5r1SPkNR9mFMq6aRydUe3wv23VI3FnvMgdvD6jKhCuorrYmcTqC2rq18v+uAhEGn
	TvSP4jgn5xlY03uRQ/P6P7jsxrtCmhs=
X-MC-Unique: 01_o3IveMxGxI8fmq-bljQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=JsTR6wHSHp31wDxVapWvddP8JBPJqUD9c6n27atW9IWFQEevAB6keYGckNcEKdnR1br6NwZH6AotWbq37lmRlsYNq8pXcoCzbn8RSOEeNSZs+wbnvlr2eADMdIL2Xtz0634AcSpGVkA/lleYUWUqt5R4HmPTj9qfsK2/m6waZJhSvirbcxw5KsFgGqMjswKDNrR262qdejLd8lvBjwubEJATwWs7EPAYJbkWk5FBruIyI+xpR/iCyOhdsiZm6GeWRDkihahWQtuztLE2t2lZt9mWOVHNUxtU+zP0NIt94iWL6iUebpQu1cZSuR/S0zyVXd4R31KvoOx9iz5AaNc1Xw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=hqXtvA8QT1El6gi/VOf+F8xHktquhDqteU2+BYDQISo=;
 b=B5kwYz5OdHFAFydQn3Nk0657ePZ8vjqcP2YweWhGm8c5HYiyQCGfu/m+mGbBgg0RjhOQCnj7+mEMILCRUpm+92O4xt2mKUfCjCVmhNGyqKtuMvxmLnuKqWlKAuCZy3FyaNzIx/JZOjLEnc290foFRzfLlCUP81Z69yAj4DBg6++2t5cJqrynSLSRFPNPmxDJ8bfAevfXV9m1zedY4WdziQ7EOy0csfHhU3e55EXRKG12gru+noO4R03aJ9IIp5jWn7bQgMYRX1z7lrUeGt8XF3nzG+q5l5Z3BGo83dilmnQkTsDyBjmcja0eikAYtjMI+AfOkfEUqIrz6ruFx2GHag==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <419db65a-a6f2-f812-d51e-7a23d065d460@suse.com>
Date: Fri, 4 Feb 2022 14:56:43 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Content-Language: en-US
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH] x86/Intel: don't log bogus frequency range on Core/Core2
 processors
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0415.eurprd06.prod.outlook.com
 (2603:10a6:20b:461::19) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 8e7944d3-5ce0-4887-e6cd-08d9e7e62e4e
X-MS-TrafficTypeDiagnostic: DB7PR04MB4538:EE_
X-Microsoft-Antispam-PRVS:
	<DB7PR04MB4538A526C2677969D7A54FD5B3299@DB7PR04MB4538.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	YG32QVAjLfr89s11BZaUJXtVUxIk0fO4TrcoDvUdEgcsldImm41S+OVXfEhTEhA7jAjQgtsKUrDzAg7Q2PEIdjIsqofLLOsObJNY/6sCVugszz1j2tuN//wTPkQUJEufwR9OgNC21jWCF6Y6aqneNAfQwgKcO1XTeadhj5U0M0q1wRYv6n6yECgWCQkXznZ20afVvHkTdJ7z1sgHQpubOU/RQentBX1vbKVDDH0Qi1iNpekO/SKXtPaT+GrKRbLSufll5B4FD0NTL6BYPKnhHhlswGoffNB8G0iOIuusl4aBHfjpWo9KvCH26vSaAmRLp4EA22EdNTreIKiAKPnE18ZgWYs89tAgbseDcffALYFN9qMkfjhVeXEFKIV2T1VxTnYSZS7crAZOACp4ac4bPeKr6O9Qm26y7BjByjeBXZJ1LORNeFDUP8wq1U3uurT8Emk1fnoAVaZGc4e7goRCIrASEQ76dt+QhlgYArPIKLWhjdhzGOMOMzJkCcIJ4wWkuvev2kJ9fPc21dE7/Yr0wYK9ynx0QsdknfkC7+PfrQpWiq8edsukVDfrgY4ywmiy0BlXjbIVSqBL8SeayegPI1GbRcgABFMLXcj/S3d+/aPOpkthqMk4kyYaDB2XlIEnXkr9cIdNVTKzxebIZyqTnnxP3T20IV8ztjpkiLhDGkfZjGZiwJ8aSZ28xMvJRCJCnTqS3JZpY8yK7Cimcq57+Tyhb+zKTKWhKzeJoK5bHrjNjDe+LBg8gdMUC0knBr0a
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8676002)(186003)(26005)(38100700002)(5660300002)(66556008)(6916009)(83380400001)(8936002)(66476007)(66946007)(54906003)(316002)(4326008)(31686004)(36756003)(6486002)(6506007)(31696002)(2906002)(86362001)(6512007)(2616005)(508600001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Mm13WTdPUjVwQzZRSzk4eFQ0Q1JKc0FrVDNIYndwTnNIdTBUMGFEaUZXN0Nm?=
 =?utf-8?B?MzBMSDJ1OUExVW5kc1BuYzdOZDBwRXRSRXAyMjVRSjVFbWJRM2tuWVl3amM5?=
 =?utf-8?B?WFNQZUdFVCtqeXFnaXR0MVhEc0V2ZGZjMEk2UEp6ZDk1anVTWm5mNE9JelRG?=
 =?utf-8?B?eTJiSzRBVk15MDMwb1QyTGM0ZDF4cW5SdFF4N3ArU25ZbHFPQ210NjhhUlhl?=
 =?utf-8?B?RlFCU3NJcGxpbEpPdUNaeXk4VkRsc3A5WUxKdVpWNE5ET1NFSnBkeExWZHlW?=
 =?utf-8?B?RHFycklreWgvaWs4dHhBQWFxWmRXVjVQcms4Y3FjNWoyQlBaYnMxM3VtQ3Ro?=
 =?utf-8?B?d29teTFLNUpsMk1EOXcxSW4vNUlFaXJBTEhWYzFqZkI4dWpmUmxndzcwT2pa?=
 =?utf-8?B?TXB5QVNjZTRESitUMEkvSHlGcDB0UkVPM0t5ejVXVUFMM0VIcUpSRkkxcEUx?=
 =?utf-8?B?cFlveE80NEZZT29NL0s1WVZYTnUzSmR0djFQczR6cXU0dkVtdVZDK2F0Qm5v?=
 =?utf-8?B?bk5WLzZ6T0xueStoVUowZk1JYlVCVHl0NjhJSll1UmRzLzM5UU9qUXJxM2dP?=
 =?utf-8?B?bitlUnArUnlJNWJzUmdUYXN3QTRVcFJYNEF5NHdYZHlpZ1NhMlBDdG5yL015?=
 =?utf-8?B?WXh2eGVTcEU3dW1YbzJzMXJ1L3pwNTNOdnMvTE5LWGFKMEl0V3J3NDVHSVhS?=
 =?utf-8?B?UVdPZWJIS0dGekhzRUxsbHdTMkdXNTA4VVdvUlFGUXZSdktZdlY2VHpUdC9a?=
 =?utf-8?B?TDczY3F4Mk5Da3NjdGRyYzFEVFFrcjhoRXZ6SEd1bWNwZk4xeVNBZzVoOGk2?=
 =?utf-8?B?b01YSDlwZmd6aE5SR0tCc0J1VEc2b1dRUlJnWDllQjJWMm5FUzZBakxwRzlm?=
 =?utf-8?B?VUNHNzY4cndKVWprejJZVzNoTjA1amo2Ym9hV090bXFqUDZDM085ZmxjZXU5?=
 =?utf-8?B?RG02eWF5a1BoVUhtVXBRUVdPWHprK1BPUEpDT0xjRUI3RUtlb25GR2w1U0tV?=
 =?utf-8?B?SHJ0bDYzeUhoTmgzUVF1R1F3QkhKWXdiL3pseWlaY2duUTFIejVnK094NDBJ?=
 =?utf-8?B?dDFWODlKb0k3UUhxekxEWEVORkxMN0hySDlPU0dDaWx6cEU3OGFJV1I3QjNl?=
 =?utf-8?B?cmpHQmxMWVJSeUNXRkxMNVdPZmp6U1hWREtORmtpWFBxSFJqa2xsamJCdkNG?=
 =?utf-8?B?NUQ4VkhhV1NPM29rK2R2NzVSSlNaSE1wM3dZaVo1c01OeU5PSjB3QjZMMzRz?=
 =?utf-8?B?L0lBWlhsUU9TOHBMUmN5dHMya000SHFSWXpRbjlvUVlCVUdweWtlVkNsZGVv?=
 =?utf-8?B?ZjZlZW1iUlVKMkNXS3NvVnpJSnU5VVVOQUxDZkMyZm5WSEVaWGZQVnVwQ20x?=
 =?utf-8?B?dzBTRVlJMnNabEU0WmJHc1JXVmxUSkU3LzFNRkthTTI3MXprd2pqL3ZSU1pX?=
 =?utf-8?B?YmdoWWcrc0oyWHBSRVB0QkI4eEZyNmI4RW9nZ2ZhcmJ3Wkx2TStpTWhwaGNp?=
 =?utf-8?B?bkhZeEdML2QvQytoaTIrUmo5dVVzZFBDd2hwMEw3VzVDQm9LNk9ENGhZVEE1?=
 =?utf-8?B?M0JWNC9xZ210SmlVNzAxWE5YUHBBTWlwOHkvVDcxZFMzOTRneEEvbVhNTlJE?=
 =?utf-8?B?bk9qcVNmRC9UTmVpZ25maWlxLzVIc1FlSlo3NHFIQ1FSNTlWdEtOMXpsVzhp?=
 =?utf-8?B?MkIyQXhIYUIrcmVBbmZ4YWdFUkl6N2luU2ZqN3N5NE9DUW5KakJvOTBPMjRJ?=
 =?utf-8?B?Q1FIQk81dnBYZmYzN0wyMkdpRExMVExTZEZRQTRRQ1YvWUdrY25QbkticWZp?=
 =?utf-8?B?U0Racy9TK1F2M2JydlJXZjNWREpWZThsWm5WOXUwWU41MTk4a0RQdkN0WEcv?=
 =?utf-8?B?MU5LQkE0K2hlR0N0TEJZVnhGT3JlcWVqbFdtRW1FdVZTZHZ5cVdJdHF5ZXVK?=
 =?utf-8?B?eStSU0pKdDhUM2gwSXBaR2xLSUd6TXVMd1hlU0lBajRMNitYcHVoTy9PdlRx?=
 =?utf-8?B?VEtFeWhqVG5IUWNxZEcyc2cvVnpXTmdXNUE5WmVBbWFMMlFoaWZoR0ROWklo?=
 =?utf-8?B?eGREVGxleGw2SGw4NlVHcE1PbmgyaUp3ajNnZ0EvV3lrUURDeWJ3S1RCeU0y?=
 =?utf-8?B?dGhRTlJHeW1qTVFjRkVuUFdIdVYrT0cxbzZOOXgzTHYyaXBUMUswWHZRcmZm?=
 =?utf-8?Q?oTlHbF9qDklxLhbzNlPTRKI=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8e7944d3-5ce0-4887-e6cd-08d9e7e62e4e
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Feb 2022 13:56:45.6459
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MOP0mNkrjclnD/3NzlMlYxoWDB2ZTLoiXswsx2R4RuYt1/mCJEJjq7NMXqPC+zYBTa2WGJ4GLxaLeMjImTvIZQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4538

Models 0F and 17 don't have PLATFORM_INFO documented. While it exists on
at least model 0F, the information there doesn't match the scheme used
on newer models (I'm observing a range of 700 ... 600 MHz reported on a
Xeon E5345).

Sadly the Enhanced Intel Core instance of the table entry is not self-
consistent: The numeric description of the low 3 bits doesn't match the
subsequent more textual description in some of the cases; I'm using the
former here.

Include the older Core model 0E as well as the two other Core2 models,
none of which have respective MSR tables in the SDM.

Fixes: f6b6517cd5db ("x86: retrieve and log CPU frequency information")
Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
While the SDM table for the two models lists FSB_FREQ, I'm afraid its
information is of little use here: If anything it could serve as a
reference for the frequency determined by calibrate_APIC_clock().
---
RFC: I may want to rebase over Roger's addition of intel-family.h, but
     first of all I wanted to see whether going this route is deemed
     acceptable at all.

--- a/xen/arch/x86/cpu/intel.c
+++ b/xen/arch/x86/cpu/intel.c
@@ -435,6 +435,26 @@ static void intel_log_freq(const struct
         if ( c->x86 == 6 )
             switch ( c->x86_model )
             {
+                static const unsigned short core_factors[] =
+                    { 26667, 13333, 20000, 16667, 33333, 10000, 40000 };
+
+            case 0x0e: /* Core */
+            case 0x0f: case 0x16: case 0x17: case 0x1d: /* Core2 */
+                /*
+                 * PLATFORM_INFO, while not documented for these, appears to
+                 * exist in at least some cases, but what it holds doesn't
+                 * match the scheme used by newer CPUs.  At a guess, the min
+                 * and max fields look to be reversed, while the scaling
+                 * factor is encoded in FSB_FREQ.
+                 */
+                if ( min_ratio > max_ratio )
+                    SWAP(min_ratio, max_ratio);
+                if ( rdmsr_safe(MSR_FSB_FREQ, msrval) ||
+                     (msrval &= 7) >= ARRAY_SIZE(core_factors) )
+                    return;
+                factor = core_factors[msrval];
+                break;
+
             case 0x1a: case 0x1e: case 0x1f: case 0x2e: /* Nehalem */
             case 0x25: case 0x2c: case 0x2f: /* Westmere */
                 factor = 13333;



From xen-devel-bounces@lists.xenproject.org Fri Feb 04 14:00:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 14:00:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265571.458972 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFz87-0004G9-PH; Fri, 04 Feb 2022 14:00:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265571.458972; Fri, 04 Feb 2022 14:00:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFz87-0004Fc-M1; Fri, 04 Feb 2022 14:00:03 +0000
Received: by outflank-mailman (input) for mailman id 265571;
 Fri, 04 Feb 2022 13:58:25 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=wnvI=ST=walle.cc=michael@srs-se1.protection.inumbo.net>)
 id 1nFz6W-0003p9-Rc
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 13:58:25 +0000
Received: from ssl.serverraum.org (ssl.serverraum.org [2a01:4f8:151:8464::1:2])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 83b6689b-85c2-11ec-8eb8-a37418f5ba1a;
 Fri, 04 Feb 2022 14:58:22 +0100 (CET)
Received: from apollo.. (unknown [IPv6:2a02:810b:4340:43bf:4685:ff:fe12:5967])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange ECDHE (P-384) server-signature RSA-PSS (2048 bits) server-digest
 SHA256) (No client certificate requested)
 by ssl.serverraum.org (Postfix) with ESMTPSA id AA98C2223A;
 Fri,  4 Feb 2022 14:58:19 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 83b6689b-85c2-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301;
	t=1643983101;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Bz66c/6ZEjSDWrbCYW8qMB5DDdnkXBZmEp6BeBUenr8=;
	b=ehu4SAvArB9/ZfJ7cTL4zbH21MVRHidcOgwpIm+ehoA6Ew9USK19X6R+TVczdiAlna3Sn5
	F/KrV5kbdDEMJ3zMIcKdNnhBhnrnocbkeQ278ilatcxm/s8m2+ZsveCdQabtbCK/6PcUJM
	koAqXb44u4smIwqepFyeeteUsRRWiqw=
From: Michael Walle <michael@walle.cc>
To: stefano.stabellini@xilinx.com
Cc: Bertrand.Marquis@arm.com,
	Zhiqiang.Hou@nxp.com,
	brucea@xilinx.com,
	cornelia.bruelhart@zal.aero,
	julien@xen.org,
	leo.krueger@zal.aero,
	oleksandr_andrushchenko@epam.com,
	peng.fan@nxp.com,
	xen-devel@lists.xenproject.org,
	Michael Walle <michael@walle.cc>
Subject: Re: Xen data from meta-virtualization layer
Date: Fri,  4 Feb 2022 14:58:14 +0100
Message-Id: <20220204135814.1033356-1-michael@walle.cc>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <alpine.DEB.2.21.2011241743490.7979@sstabellini-ThinkPad-T480s>
References: <alpine.DEB.2.21.2011241743490.7979@sstabellini-ThinkPad-T480s>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Hi all,

> + Zhiqiang Hou
> 
> On Tue, 24 Nov 2020, Leo Krueger wrote:
> > > >>> On Tue, 17 Nov 2020, Leo Krueger wrote:
> > > >>>> Hi,
> > > >>>>
> > > >>>> I enabled CONFIG_HAS_ITS (what a stupid mistake by me to not set it
> > > >>>> before...) but then had to add the following node to my device tree
> > > >>>>
> > > >>>> 	gic_lpi_base: syscon@0x80000000 {
> > > >>>> 		compatible = "gic-lpi-base";
> > > >>
> > > >> I couldn't find this compatible defined/used in Linux 5.10-rc4. @Leo,
> > > >> could you clarify which flavor/version of Linux you are using?
> > > >
> > > > It is Linux 4.19 from Yocto (Warror release). XEN 4.13.2.
> > > 
> > > Do you have a link to the Linux tree? Is there any additional patches on top of
> > > vanilla?
> > 
> > Linux tree is found here: https://github.com/kontron/linux-smarc-sal28/commits/master-LSDK-19.09
> > (up to the latest commit in that branch)

FWIW, I'm the developer of the support for this board both in the
mentioned branch as well as upstream.

If you don't need graphics you shouldn't really be using the branch
above, but the latest vanilla kernel release.

> [...]
> 
> > > Looking at the DT changes in [0], it looks like the node is not a child of gic@.
> > > So I think Xen will map the region to Dom0.
> > > 
> > > There are two things that I can notice:
> > >    1) This region is RAM, but I can't find any reserve node. Is there any specific
> > > code in Linux to reserve it?
> > >    2) The implementation in U-boot seems to suggest that the firmware will
> > > configure the LPIs and then enable it. If that's the case, then Xen needs to
> > > re-use the table in the DT rather than allocating a new one.
> 
> That Linux tree has no mentions of gic-lpi-base. That means that
> gic-lpi-base is only used in u-boot, not in Linux. In particular the
> most relevant commit is af288cb291da3abef6be0875527729296f7de7a0. 

That node was horrible hack from NXP for u-boot and was removed in
a84cea06bb8fff69810a890ac0e4b47ea5726512.

> In regards to the reserved-memory regions, maybe we are not seeing them
> because Leo posted the host device tree, not the one passed at runtime
> from u-boot to Linux?
> 
> If so, Leo, could you please boot Linux on native (no Xen) and get the
> device tree from there at runtime using dtc -I fs -O dts
> /proc/device-tree ?
> 
> 
> However, the name of the reserved-memory region created by u-boot seems
> to be "lpi_rd_table". I cannot find any mentions of lpi_rd_table in the
> Linux kernel tree either.
> 
> Zhiqiang, Leo is trying to boot Xen on sAL28. Linux booting on Xen
> throws errors in regards to GIC/ITS initialization. On other hardware
> Xen can use and virtualize GICv3 and ITS just fine. Could you please
> explain what is different about sAL28 and how Xen/Linux is expected to
> use the lpi_rd_table reserved-memory region?

I actually stumbled across this thread after trying out Xen myself. I'm
using lastest vanilla u-boot (with pending PSCI patches), vanilla kernel
and vanilla Xen.

So far I've discovered, that xen complains that it cannot route IRQ64 to
dom0. That is because on the LS1028A there is a dual UART (two 16550
with one shared interrupt) and xen takes the first UART and then tries
to map the interrupt of the second UART to linux. For now, I don't know
how this is solved correctly. As a quick hack, I removed the second uart
node from the device tree.

But what is more severe is that the iommu isn't set up correctly. I'm
getting the following faults:

(XEN) smmu: /soc/iommu@5000000: Unexpected global fault, this could be serious
(XEN) smmu: /soc/iommu@5000000: 	GFSR 0x80000002, GFSYNR0 0x00000000, GFSYNR1 0x0000042a, GFSYNR2 0x00000000

If I decode it correctly, the streamid should be 0x2a which would be one
of the PCI devices on the internal root complex. Probably the network
card.

This is the first developer experience with Xen, so please bear with me
:) It seems that Xen doesn't add the master to the IOMMU. To me it seems
that only devices with a 'iommus' dt property are added. But in case of
PCI devices the parent only has a iommu-map property.

And it makes me wonder why Leo has an almost working setup. Maybe I'm
missing some patches though.

-michael


From xen-devel-bounces@lists.xenproject.org Fri Feb 04 14:08:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 14:08:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265582.458984 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFzGM-0005QF-Lf; Fri, 04 Feb 2022 14:08:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265582.458984; Fri, 04 Feb 2022 14:08:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFzGM-0005Q8-H2; Fri, 04 Feb 2022 14:08:34 +0000
Received: by outflank-mailman (input) for mailman id 265582;
 Fri, 04 Feb 2022 14:08:34 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=FJWP=ST=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1nFzGL-0005Q2-Rr
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 14:08:34 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id eef1448c-85c3-11ec-8eb8-a37418f5ba1a;
 Fri, 04 Feb 2022 15:08:32 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: eef1448c-85c3-11ec-8eb8-a37418f5ba1a
From: Thomas Gleixner <tglx@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1643983711;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=SNX1Snmen8jqN1d+Tprj24WFL9DXT+zGfgm398dt/9w=;
	b=GYPJETjivlarCGcd2NnYBL7Qo+KgDYTTNSvwI8Mc1AAL1UNC05tUzwOPd4Dca3PH7Di3CN
	2be/kMF0G7ogbnKJJVYBeYAiapY3dWqqdJzCbleiRNmtIzVNS4jY4TH58gEjgXRVHgs6o8
	qYD9j8qmBFJD3HyGXIfzQXvRI9cayCrj/E8JrqgYoSmKm6+j+xWo6VMfPlPxZkhCCs3reh
	FYqq07Z0trOT7LskDGz2hgmGYJVMq8qMnQO+C/ft4SN5jaGtL1zaTlXKmEHPe8xAyBUSQb
	GBbZECGBb5a/duk5ARL46wCPe7MKtnxPpxThj5sD7RUAv/HhJtv/4f0EwF06Ug==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1643983711;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=SNX1Snmen8jqN1d+Tprj24WFL9DXT+zGfgm398dt/9w=;
	b=2ajljAVIRESQmw2ljEtocIHSocWU8lbZ+4yPSjAvTcvbOdhsdt5OzeN5xJE5SGqZhdMx5s
	FAowyc1MLHlkfYCA==
To: Jan Beulich <jbeulich@suse.com>, Ricardo Neri
 <ricardo.neri-calderon@linux.intel.com>, Peter Zijlstra
 <peterz@infradead.org>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, the
 arch/x86 maintainers <x86@kernel.org>
Subject: Re: x86: insn-eval.c's use of native_store_gdt()
In-Reply-To: <68c4f398-0494-e272-47e0-6803b6865f15@suse.com>
References: <0d687d64-1cf0-8965-0569-bce27cf0a8b7@suse.com>
 <68c4f398-0494-e272-47e0-6803b6865f15@suse.com>
Date: Fri, 04 Feb 2022 15:08:30 +0100
Message-ID: <87fsoyd8rl.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain

On Fri, Feb 04 2022 at 10:23, Jan Beulich wrote:
> On 30.11.2021 12:09, Jan Beulich wrote:
>> I think it is b968e84b509d ("x86/iopl: Fake iopl(3) CLI/STI usage")
>> which uncovered an issue with get_desc() trying to access the GDT, as
>> introduced by 670f928ba09b ("x86/insn-eval: Add utility function to
>> get segment descriptor"). When running in a PV domain under Xen, the
>> (hypervisor's) GDT isn't accessible; with UMIP enabled by Xen even
>> SGDT wouldn't work, as the kernel runs in ring 3.
>> 
>> There's currently no hypercall to retrieve a descriptor from the GDT.
>> It is instead assumed that kernels know where their present GDT
>> lives. Can the native_store_gdt() be replaced there, please?
>> 
>> For context (I don't think it should matter much here) I'm observing
>> this with the kernel put underneath a rather old distro, where
>> hwclock triggers this path.
>
> I'd like to note that the issue still exists in 5.16.

I'd like to note, that I've seen no patches to that effect.

Thanks,

        tglx


From xen-devel-bounces@lists.xenproject.org Fri Feb 04 14:10:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 14:10:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265588.458995 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFzHs-0006jZ-Vp; Fri, 04 Feb 2022 14:10:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265588.458995; Fri, 04 Feb 2022 14:10:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFzHs-0006jS-Sk; Fri, 04 Feb 2022 14:10:08 +0000
Received: by outflank-mailman (input) for mailman id 265588;
 Fri, 04 Feb 2022 14:10:07 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=98b4=ST=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1nFzHr-0006jM-NW
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 14:10:07 +0000
Received: from ppsw-32.csi.cam.ac.uk (ppsw-32.csi.cam.ac.uk [131.111.8.132])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2715d097-85c4-11ec-8f75-fffcc8bd4f1a;
 Fri, 04 Feb 2022 15:10:06 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:53484)
 by ppsw-32.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.136]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1nFzHo-000tMw-1L (Exim 4.95) (return-path <amc96@srcf.net>);
 Fri, 04 Feb 2022 14:10:04 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 23FD01FBCB;
 Fri,  4 Feb 2022 14:10:04 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2715d097-85c4-11ec-8f75-fffcc8bd4f1a
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <1905e626-da65-0541-802e-34e5d06bc1dc@srcf.net>
Date: Fri, 4 Feb 2022 14:10:03 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.1
Content-Language: en-GB
To: Jan Beulich <jbeulich@suse.com>, Andrew Cooper <Andrew.Cooper3@citrix.com>
Cc: Wei Liu <wl@xen.org>, Anthony Perard <anthony.perard@citrix.com>,
 Juergen Gross <jgross@suse.com>, Xen-devel <xen-devel@lists.xenproject.org>,
 Roger Pau Monne <roger.pau@citrix.com>
References: <20220203181023.1554-1-andrew.cooper3@citrix.com>
 <53b98995-8cef-48b4-7728-3bfbc236af5f@suse.com>
 <f2ce80ee-f30c-dc6f-e4b7-5d8eddb5b3d5@citrix.com>
 <1333696d-d3c2-15a8-1dd5-7cb0a17ef023@suse.com>
 <a28ff9e8-c022-6384-ee04-c21b69a4fdd2@citrix.com>
 <eb818153-3ada-ac46-fb14-da975a61574f@suse.com>
From: Andrew Cooper <amc96@srcf.net>
Subject: Re: [PATCH] tools/guest: Fix comment regarding CPUID compatibility
In-Reply-To: <eb818153-3ada-ac46-fb14-da975a61574f@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 04/02/2022 13:46, Jan Beulich wrote:
> On 04.02.2022 14:34, Andrew Cooper wrote:
>> On 04/02/2022 13:09, Jan Beulich wrote:
>>> On 04.02.2022 13:12, Andrew Cooper wrote:
>>>> On 04/02/2022 08:31, Jan Beulich wrote:
>>>>> On 03.02.2022 19:10, Andrew Cooper wrote:
>>>>>> It was Xen 4.14 where CPUID data was added to the migration stream, and 4.13
>>>>>> that we need to worry about with regards to compatibility.  Xen 4.12 isn't
>>>>>> relevant.
>>>>>>
>>>>>> Expand and correct the commentary.
>>>>>>
>>>>>> Fixes: 111c8c33a8a1 ("x86/cpuid: do not expand max leaves on restore")
>>>>> But doesn't this commit amend 685e922d6f30 ("tools/libxc: Rework
>>>>> xc_cpuid_apply_policy() to use {get,set}_cpu_policy()"), which is
>>>>> where DEF_MAX_* disappeared?
>>>> No. All that happened in that change was that we switched to using
>>>>
>>>> cpuid.h:89:#define CPUID_GUEST_NR_EXTD_AMD
>>>>
>>>> instead, which remained the same size until Xen 4.15 when e9b4fe26364
>>>> bumped it.
>>> Oh, right. I did try to look for a replacement, but managed to miss
>>> this. But then, as much as 4.12 isn't relevant, isn't it the case
>>> that the fact that CPUID data was added to the stream in 4.14 isn't
>>> relevant here either, and it's instead the bumping in 4.15 which is?
>> The fact that the bump happened is relevant, by virtue of the fact there
>> logic added to cope.  The fact it was in 4.15 is not relevant - this
>> isn't a list of every ABI-relevant change.
>>
>> CPUID data being added to the stream is critically important, because
>> that's the point after which we never enter this compatibility path.
> If the bump happened before CPUID data was added to the stream, logic to
> cope with migrating-in guests would have been required too, wouldn't it.

Yes, it would have been.

It wasn't an accident that none of the max leaves changed while doing
the Xen CPUID work.

We're unfortunately a long way behind on Intel CPUID leaves, but all(?)
of the new leaves need more complicated migration safely logic than the
toolstack currently knows how to do.

> But anyway, just to be done with this:
> Acked-by: Jan Beulich <jbeulich@suse.com>

Thanks.

~Andrew


From xen-devel-bounces@lists.xenproject.org Fri Feb 04 14:10:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 14:10:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265592.459006 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFzIF-0007BE-82; Fri, 04 Feb 2022 14:10:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265592.459006; Fri, 04 Feb 2022 14:10:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFzIF-0007B7-4m; Fri, 04 Feb 2022 14:10:31 +0000
Received: by outflank-mailman (input) for mailman id 265592;
 Fri, 04 Feb 2022 14:10:30 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nFzID-0007Ak-UY; Fri, 04 Feb 2022 14:10:29 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nFzID-0002DM-TV; Fri, 04 Feb 2022 14:10:29 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nFzID-0000LP-I0; Fri, 04 Feb 2022 14:10:29 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nFzID-00057N-HX; Fri, 04 Feb 2022 14:10:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ZvdbFbOkLefJlq+gilA6D7E4cFhfj8cv8Fm+wY12iH8=; b=3s1JKAKpHSqoYiewXdYqFfK78j
	q5/1Bw/AritzitoRKn1Hv5Av1w4vJ0Ops3XD+i3Wptqb+BjooxHGjBMh7ykVK8geoMRqEMQtTP06n
	Lyg/41pLz5NDyV+AX6B+C2bEU0zwcg/mG5uBs07HEOj1L5fMcwLKVa3bXHa+0ZVbTBxI=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168003-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [seabios test] 168003: tolerable FAIL - PUSHED
X-Osstest-Failures:
    seabios:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    seabios:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    seabios:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    seabios:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    seabios:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    seabios:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    seabios:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    seabios:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    seabios=829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd
X-Osstest-Versions-That:
    seabios=dc776a2d9ca9e1b857e880ff682668871369b4c3
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 04 Feb 2022 14:10:29 +0000

flight 168003 seabios real [real]
flight 168009 seabios real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/168003/
http://logs.test-lab.xenproject.org/osstest/logs/168009/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 168009-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167920
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167920
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167920
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167920
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167920
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass

version targeted for testing:
 seabios              829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd
baseline version:
 seabios              dc776a2d9ca9e1b857e880ff682668871369b4c3

Last test of basis   167920  2022-01-27 16:42:48 Z    7 days
Testing same since   168003  2022-02-03 23:10:24 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Florian Larysch <fl@n621.de>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  fail    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/seabios.git
   dc776a2..829b0f1  829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Fri Feb 04 14:11:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 14:11:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265606.459017 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFzIy-0007wW-LN; Fri, 04 Feb 2022 14:11:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265606.459017; Fri, 04 Feb 2022 14:11:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFzIy-0007wP-IN; Fri, 04 Feb 2022 14:11:16 +0000
Received: by outflank-mailman (input) for mailman id 265606;
 Fri, 04 Feb 2022 14:11:15 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1gJ0=ST=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nFzIw-0006jM-Ny
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 14:11:14 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4fa80da5-85c4-11ec-8f75-fffcc8bd4f1a;
 Fri, 04 Feb 2022 15:11:14 +0100 (CET)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2054.outbound.protection.outlook.com [104.47.12.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-22-FDwd5hQWMrWm5dppO4Xo1g-1; Fri, 04 Feb 2022 15:11:12 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DU2PR04MB8615.eurprd04.prod.outlook.com (2603:10a6:10:2da::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.14; Fri, 4 Feb
 2022 14:11:10 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.014; Fri, 4 Feb 2022
 14:11:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4fa80da5-85c4-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1643983873;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=pXqhIx2/MHFJxsI/48OJ7e6xGK/hEy/VZK/YNYBaj2E=;
	b=Le5XOZ0Rz5NyeKt1Zwnl343Em6v/EFhngOlF7/KGnRVBWT72UQFr3TkwyVRzeipk+a4J6n
	4Y84k+uuTh/RB9RejwCoEtuD+ql31xXIp41Px9X2YW1XhUpqow1zYkyEMwVIuGjuHt5Jsc
	STOBn2c8qrLexyrZEGcArh/JkfOlhu0=
X-MC-Unique: FDwd5hQWMrWm5dppO4Xo1g-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=WOTdsBDW0fmjGxh30NUYg5Fotka5Cq97UuijY2a/1dapSADmS9L4l+MSWR0CZOCw78fE0Shd02Pvm+laGGBDBPzz4Fr6xQj1n4rz6P9RVLIYS5I4Mvn8QfFkg1HFPBbYWLHHyHopiZTAyL/Gk0gRacrNo77bM5406fRFiSjREkmeQujXeF9SHAm1osiOi/Bt0OuvxMhd2u1YRFylq4yu+O2TVnf6BM+fVqwjtMcknM8ehYOHOtyx7QIyxu8kirTxTIiZ5ynBu8grfXAVPItUoTbDjLbO3lDztc/u4QP/ODkrEMUITxGWY0/ra7JpDmrH46F1AZHynvnlvqM/HigE/g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=pXqhIx2/MHFJxsI/48OJ7e6xGK/hEy/VZK/YNYBaj2E=;
 b=jI/oiVd804xd9Fix1OTQBzP4p2GJ6uNJq6PaELPTP9YUCsjRfnFTf9vIY2LynJkn7CWBP4YaGzN5c+NwEuINDQQqzfQBs7mXjYY/GS4Te8c3kdmpebcXVWMXokOkQ3bC0mzkD867a8jnboHo25ntRI/UuQKA2XPXFwScGaboJrHQreBeC0Lnk3O6okHvzZX5pbG7Qs+41oaqSrfDRCIzYWOsidqKUaD6sWa1SyJ9dqOLqDs/8PNgzuK3CQqILYneG1hFwcVrZeHMciT1q9TNe6ojRTTqpkf/7nJKy8gQERnfU2y3/FUS9ry8VcrE1Gj6/KFpBJpSxgqybMl3gxjqHQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <b6f091ed-4fa3-e292-9a21-a780ec90ee09@suse.com>
Date: Fri, 4 Feb 2022 15:11:05 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v6 04/13] vpci: restrict unhandled read/write operations
 for guests
Content-Language: en-US
To: Oleksandr Andrushchenko <andr2000@gmail.com>
Cc: julien@xen.org, sstabellini@kernel.org, oleksandr_tyshchenko@epam.com,
 volodymyr_babchuk@epam.com, artem_mygaiev@epam.com, roger.pau@citrix.com,
 andrew.cooper3@citrix.com, george.dunlap@citrix.com, paul@xen.org,
 bertrand.marquis@arm.com, rahul.singh@arm.com,
 Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>,
 xen-devel@lists.xenproject.org
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-5-andr2000@gmail.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220204063459.680961-5-andr2000@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR04CA0058.eurprd04.prod.outlook.com
 (2603:10a6:20b:f0::35) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c61b4ed2-5fd8-49a9-ccc5-08d9e7e83168
X-MS-TrafficTypeDiagnostic: DU2PR04MB8615:EE_
X-Microsoft-Antispam-PRVS:
	<DU2PR04MB8615A0750D05E16F8D984798B3299@DU2PR04MB8615.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	s49ACWlJPsQmV+Y7nF3RV+evBb9u2f8EoHn6GPk5nlHwmX/M7j3//6q5rv9VVZt1fV6Js3/5Z4BRznktVZIpg4VREasfXGyw8InLyLP8e6sfzhMeMGJ6gHuBvdNrI8kQ2dqOiPQ2t6idNF7ku/kIyaVhG6Trm+TfVqW9jJ3Y0k/VUfLrgt55Ueq1DGQiKB1tOQg/bFm6pAcoCX7tAohaDqmrxIcT39k31JNnm+F1O3Yaf78f4W9xaZ2WSM/r3iR/PnvbdCacaRuKXT4DcnuQIJZTZGTBuH/s9JyfDBlptHntEZ8mhLOPnVAiKn/mjSgQKaY9rZLqkZP/GhMfK10SNizSlK/kOvTWzvd9lu8VcLFFNC4ECqkhFSnzMAh+uY5i1m1iEhsvPk6QVmvQqp6IGtWHaI8lSy+D7Cf6+/3ywN6xVAK2s4xj57bGcsCKMIeNN3DSDoqvn2sPQs3URmV9VWnhRF0QLIvv+9NTpfD+U/4BFDJJzH6RvhZO9yP+G0hbSDfOjAeufDn0noRUKdkFUKacVmTxWZIxRwbjslEeMFTcSAQh+b3XQf+WSCxsDTflzjolVere7iaohkNrPbvv4Wu57FrS4vxQkKsONfCsm4fgnGXfer+bP8bgPiaO/r4eq5GwMBepwZJ9CqDi/AkJedkbUdjDJrK1JdBBgubhKqtINhPFeOFKFvDFQaCXHgpvTsy0ygc2Pw7KtV6E2I1Or/vml+TiUTHD0kmOcMzwDzq6S9N5iRpyxaKzu4vxcfai
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(31696002)(86362001)(83380400001)(6486002)(8676002)(38100700002)(66946007)(5660300002)(4326008)(66476007)(66556008)(8936002)(2906002)(6916009)(53546011)(316002)(6506007)(7416002)(6512007)(6666004)(2616005)(26005)(31686004)(508600001)(186003)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?SVZDVGFYOGxIekplbHg2bVQ1WnY3L0wwM2p0QUZFcHJPQ3E1OHprY2pKS1Br?=
 =?utf-8?B?V2thbGlPSGZDRkNncjVRN2tUS3RaVDlXcDdkTkZMQmpDcFJMelhMSkhwSWg4?=
 =?utf-8?B?R2lIQ3crcVFwTXA2Qkk3RlhpcTVSbjB1SDZZeDlEQnlQbFlVVENYMXhpenV5?=
 =?utf-8?B?a2EzRWtWYjEyNGY5OUkwdlZjcGJKZW9lRWdXKzBoLytmaUhRT0srTE00dll4?=
 =?utf-8?B?QjVrTEQ4NDUvVERPWEtKbklPd2RvSWsveG1teTREQUI0NEJhUEc5NmtSK0xT?=
 =?utf-8?B?UHRsREtmSi9kVFZFUi9PRlhCM2tjYWRnZ0hQR2FMMTgwWERPb1dFK1MxZlpy?=
 =?utf-8?B?a3JiTGRRMUZUTzBSUnM1aDFJa1FQelhIaXFTTlhUbkdWMEYyL2hEZE9rZTlP?=
 =?utf-8?B?K0k2WDNCNWRWdnJ1R0ZVU1NxTG1sdWx4eWtqUFdESUEzYkdYV2hBeVJDUWNV?=
 =?utf-8?B?SENYZEVUU01DeW5uWFdnRFBDQmNEVmxVOU9zQVBaT2dSRDRLcFg5K0FIWTA2?=
 =?utf-8?B?NW5RT0Q5S0VRWFlyYTNiZXgrS2gySkJ1QTVjNXdEandsVEQ2MHdQV2VJdGVn?=
 =?utf-8?B?NWJQYjJzZFNVeUJOU251QjJ2bFB3ZnEvektMKzYxOVQ1YUdZZWtFQ0dONC83?=
 =?utf-8?B?S1ZwdU9pYjN2TmdUdjU1VCs2aUZRYnltbk9oWGtxQ0V6aUg5bWNuOVlLZDZz?=
 =?utf-8?B?cUJqZGJ3MWhDbXl0L2I0bERkcDVncEU1Vnd0c2hyQVphbTB0Qmkza0JqNjB2?=
 =?utf-8?B?UExZMzRkUWFYNzRlNmlMblhXdENDeGZJVU8wUkNvUW5KcXlqcE9OeGxaenQz?=
 =?utf-8?B?VUR1SW95anl0M2Rib24zK0hkMXJ2dW9EUXVEcXJpaFU2RFN3V09PR2N4NDVH?=
 =?utf-8?B?TEpHOFowWHlXek91MkgvQlFsRnVBUEhLZ0VFQTdjRVZlNGJXc08rYUkwN0hF?=
 =?utf-8?B?TjFVeExZUENsM2l3QnEvTWNhbzZuUm9PeXVIelJuSTI4WmsxR0NRdTI4bXJU?=
 =?utf-8?B?SVQxZUl6MXJlTWM1UXJJbGFIVHJYMUtCeXlZdktVSnF6bEJBcEFUbU1xOXgw?=
 =?utf-8?B?NkRpUTJwZytBMkRYRm1XdnVMRk9FTEhraWVUQnJPMWdTZWhiWTVycmx6U01X?=
 =?utf-8?B?MnlacytWOVlkQU9DZjczbW1LYmwwakxsTDdmczdGTU5vaTFOMnpxQWNFaXNv?=
 =?utf-8?B?UjZpMHIzdStvYmdIbXI0bmtjWTRiNXhQN3pZMVBZUmNQYUFrdjNBVThla1RK?=
 =?utf-8?B?dW9ZVWZwZC9IUWxodStFa1lPSHNQRjh6Qy82WUdxNDlNeWEyUElsL3Zha01E?=
 =?utf-8?B?MFJTbm9SajdLV1VCSkg2MDluSndHSllrcVY2ZjhZUDBwOG5TZDVSS3N1amtF?=
 =?utf-8?B?cU5obVRoUnlKR1N1MStFbzVocExZVk81NWhybU84QWZSdXlwejFvMFJGc0xG?=
 =?utf-8?B?L1daNXkxU1VEUkgwcVNSeDJ1VFlxR1ZYaXVyNHc4SEl3WmhmVFNCNFJkV2sv?=
 =?utf-8?B?eGZmRUVJUlY5ditvZFIrVG8xSlRJYVlCd0NjdnA0M3dRWEVqNDQ3WXkyOXhk?=
 =?utf-8?B?dFp6M2NTQW9vRUlQeWtQV0p3OUNSVVI0ckkwU3E4SUJIaWhVeDRBSks0WStW?=
 =?utf-8?B?a1NiYytQbE5jaFA3R0cyS2NOWHhlRjk2MG9wSEF2NXZxRzZQbWhPMFZJdnZV?=
 =?utf-8?B?bFZTWVlDR0RVTmp1b21uUjRybDRKRUJqQ3EvRnRDNldFZmhjbFpVVHhjakVm?=
 =?utf-8?B?eitpQWx3SWxaeGFnNTFMSnBudWRWT0p5T0szQ3pIaDVRQ0E3Vkx1WDVqZFpp?=
 =?utf-8?B?bDFRckQ5aU45aHpnWTRkcUVYVW5MMU9CN2FTRkFoaHdIbmdUMHFWcW9ycUZD?=
 =?utf-8?B?OGFldm0zMUNTM3N4TmkzTDA5ZnlVOGVXQU9sbHJPbldGYUJkeElRYk1oTmJj?=
 =?utf-8?B?Z3ZIMUFyM0FWQThoc09Eci9hM2FEODNHRVk1SVNTTy9zQmZNb2FGM21Ma3kx?=
 =?utf-8?B?MFAyeTFrQUJTZzA0OUJYNDZkY0JRbVBlb1ZVLzJEK1MrQUVwQmh5VmdxOG53?=
 =?utf-8?B?ZlBsRlduaWVYMjZrTFI5RjVBRFRXQlJnc1E2VmFJVnk2cWtYVVdPdmFWNCt2?=
 =?utf-8?B?S0V5RWVtcG1JMTlXQ2owWis3MkpIV2RPcmhNS29RcEQ1MGpaaVJIR1I3TWNK?=
 =?utf-8?Q?iNEsf31j0nVwS8lNdWa0ZKQ=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c61b4ed2-5fd8-49a9-ccc5-08d9e7e83168
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Feb 2022 14:11:09.8422
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aHkwEl5c9R4iEYFDArrehkUFkDmuOSvFxdHq00FaA3PcfylDUIXMsSh1x6i2lJv5tYjyoVPH9vRkVAeaFcOEnQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8615

On 04.02.2022 07:34, Oleksandr Andrushchenko wrote:
> A guest can read and write those registers which are not emulated and
> have no respective vPCI handlers, so it can access the HW directly.

I don't think this describes the present situation. Or did I miss where
devices can actually be exposed to guests already, despite much of the
support logic still missing?

> In order to prevent a guest from reads and writes from/to the unhandled
> registers make sure only hardware domain can access HW directly and restrict
> guests from doing so.

Tangential question: Going over the titles of the remaining patches I
notice patch 6 is going to deal with BAR accesses. But (going just
from the titles) I can't spot anywhere that vendor and device IDs
would be exposed to guests. Yet that's the first thing guests will need
in order to actually recognize devices. As said before, allowing guests
access to such r/o fields is quite likely going to be fine.

> --- a/xen/drivers/vpci/vpci.c
> +++ b/xen/drivers/vpci/vpci.c
> @@ -215,11 +215,15 @@ int vpci_remove_register(struct vpci *vpci, unsigned int offset,
>  }
>  
>  /* Wrappers for performing reads/writes to the underlying hardware. */
> -static uint32_t vpci_read_hw(pci_sbdf_t sbdf, unsigned int reg,
> +static uint32_t vpci_read_hw(bool is_hwdom, pci_sbdf_t sbdf, unsigned int reg,
>                               unsigned int size)

Was the passing around of a boolean the consensus which was reached?
Personally I'd fine it more natural if the two functions checked
current->domain themselves.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Feb 04 14:14:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 14:14:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265618.459028 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFzLd-0000D1-5M; Fri, 04 Feb 2022 14:14:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265618.459028; Fri, 04 Feb 2022 14:14:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFzLd-0000Cu-1c; Fri, 04 Feb 2022 14:14:01 +0000
Received: by outflank-mailman (input) for mailman id 265618;
 Fri, 04 Feb 2022 14:13:59 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1gJ0=ST=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nFzLa-0000Co-V0
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 14:13:58 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b1733bcd-85c4-11ec-8f75-fffcc8bd4f1a;
 Fri, 04 Feb 2022 15:13:58 +0100 (CET)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2111.outbound.protection.outlook.com [104.47.17.111]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-24-eJh_Giq2OXur-nNN86ANiQ-1; Fri, 04 Feb 2022 15:13:56 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DBAPR04MB7208.eurprd04.prod.outlook.com (2603:10a6:10:1a8::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Fri, 4 Feb
 2022 14:13:54 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.014; Fri, 4 Feb 2022
 14:13:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b1733bcd-85c4-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1643984037;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=0I+uOicoGLR2gEmvaPGEtXmhaI6fI+wk9xTKrgKGjhk=;
	b=Osw2YyujS6zSWjNerHGn67y4Z/AEAL1pOEyr9yoAMm+F/1f1jjUmzi/X93khmvbKMV4Q+V
	y2Tk/smVINoRvq1QkAmR/YkNQIyUg/a/2Oj/P3wOsp3PIKMpYw219Z51wcDqpiPqAkKARD
	02z0iVX30fnw0TMgUGagJcN0NTnpsPc=
X-MC-Unique: eJh_Giq2OXur-nNN86ANiQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=iWEDd3BIN9vCC1f/lOtzWdSxQq/py0jBhSSD1n5sHcX/OuXKaVTzixOuKLq3rCVFi7uVkYrUjmAJAdYI3818Epphv5UI0CsN6qzEjU/A3KZNlyrfjRxzmNvpKmx8quwY0SK5pQcdobTKAU2CnVJOo7Ky2x7YXcSE4W5Ai5TnpuSzdm+WPWWqdIoVgP82lJyeXRthdXDEeSpom85C681CUDGgb23HKNzUPAzswmaPJIO+a9JAE3mkYmqkqJxEe4evxYJY1FOdzYUyc1vXp+v3f+K4kucvqnFc/N/2QF7vpovuSabQpDfyvVX39ofXQRE92ZqSZNQqKJifSCjygbOo1g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=0I+uOicoGLR2gEmvaPGEtXmhaI6fI+wk9xTKrgKGjhk=;
 b=PGfVL5qLHEWKxQtza992ZtEPFFxM4UuI0IFM/dmoE9akUJ1+6GaLiQdkuyQVK4EmOAjJBju2Z6w6OlA2bEDUmX0bkwrHt/gLG2QYPD14kpiSYv01PIYS52nTblBTk4+/LwKgEUjZbi/A68pQBxHl5+HdzWpI83CQ1Wx7OCFzL4Pqk0udw18j9t0nAfgGgGbAlaRnQaP0SxpbiGCF4i/BcK/TRW+ChArygPm5LEgIa94czdG9gWLEona4sY5sQo3D6/8ninfIJ4M6q2skcIwuZ3NDdTKTn+/sLmL5PuDzrqWPnktCLZeUDNxky7byvJKNTezGa4+AYRfB3AX+uw7tOw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <f1710902-3085-0f7b-54d3-d65ac5b09e32@suse.com>
Date: Fri, 4 Feb 2022 15:13:52 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: x86: insn-eval.c's use of native_store_gdt()
Content-Language: en-US
To: Thomas Gleixner <tglx@linutronix.de>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 the arch/x86 maintainers <x86@kernel.org>,
 Ricardo Neri <ricardo.neri-calderon@linux.intel.com>,
 Peter Zijlstra <peterz@infradead.org>
References: <0d687d64-1cf0-8965-0569-bce27cf0a8b7@suse.com>
 <68c4f398-0494-e272-47e0-6803b6865f15@suse.com> <87fsoyd8rl.ffs@tglx>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <87fsoyd8rl.ffs@tglx>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0170.eurprd06.prod.outlook.com
 (2603:10a6:20b:45c::30) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a81c7073-8c76-44e3-7c37-08d9e7e8937d
X-MS-TrafficTypeDiagnostic: DBAPR04MB7208:EE_
X-Microsoft-Antispam-PRVS:
	<DBAPR04MB7208D6778598AC23E3D5FF7BB3299@DBAPR04MB7208.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ziVks6Bs9bpUi5gf//gYBsyXQTRY3Ctcx1JLJUxHaujyXSqjW+CuSW+uUkPaXjcI3VxSuIOznl4UTDWBf2MXIS8ALd1LgboSKZDoaVnsxwMhYb8KLgn6tLPQTRm8Il+szRjResfKLgires883G4Q1L0+eoiopCnfZINHLFmcYGunUIHAN2FxluV50/I4gN+9frx5Y/me+2M+U5KdhQoJw1UpxJZyf179Btxc9e8QCu2SRqtDhqBIH8qnEjJbcrmjL+L7hM6+6lcOvpX4z+tHbOc1o69Zqei6m2GAj4FtIXAsBejAYrrK5Lq1BlC2fKAgomqeX4ByD4MC8n2spDX4M6uGd4mUz9dntpHxjH/e1VhqJzURMzX9z4EthIr5Nmilrub6R+IhNTMN/2m+ES8BB3tygZ32owCm/bAJI1uLJuDxNY56MV02NiMuqIVSh4XMt6Xso6HEtLaPkmq8HIBwjWYa7ndrZ1pPxqHy8aY4kC2iteeczjBHGHc008wpbpJsqrpsJu0AIiVxb2ZeMJgmRKSmTkMaOgLJBDo7LmviLYSm7yWCusBOTy8xpUVKK111hSqkEcLbflNXViM6nNJIBa06anmyc6P1PGwwBUk1bW+2fKhE3Xzj26lpj+h+5M0xseWMnC5nB3ZxKPhSA/afwkX288Niu9QsigkXt5PeLYSFYBmQxvtM4VfIT60KSo6XBgiuhDfKgku07y6brJk2iHgzqLRwec06gPUFCZfySY8=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6486002)(6916009)(66556008)(5660300002)(26005)(31696002)(2616005)(8676002)(86362001)(54906003)(4326008)(508600001)(8936002)(6512007)(6506007)(66476007)(66946007)(186003)(53546011)(36756003)(316002)(31686004)(2906002)(38100700002)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?KzJOMWQwd2FlUThNcmVlSzVqVzVNcXdNQzBNSzQydE9RYXdpN1lENDU1Q00z?=
 =?utf-8?B?WkJRUnVDaG1aQXFISkNueTVWa3p2d1hoRHE0eWticlh0UWhHWEozczFlbmhu?=
 =?utf-8?B?cEJ6MER3SEFXNDZDQmtGYWFpcXpOYU0wZTBseGFyNHFMNEFtT3U4ZlFMQ0N5?=
 =?utf-8?B?SVAyUTdmNm1kZnhwL2VqbFRjUzFRRmZYTnE2NmZtd2M1bkx0MnAyNnhkZWpw?=
 =?utf-8?B?SzJvNTdocGZxZDFTWEtiWUV3czAzOGp1WDlUdmdoRzhSWkVSUHBWOHd3RDhu?=
 =?utf-8?B?V0UrUXhBeDRsR3NTTUcwYTJWYlIzUi9UTGNqdUVnalpOYnRKRlJ1KzNjdmts?=
 =?utf-8?B?bGVwdGVrL1FPN2VEWlViaDhNMzBaMUcwZXNrZ0dSRGE0KzFCOGpjNmZkSmln?=
 =?utf-8?B?VGJmd2RHbmNDRW5weGVSSWRnYmMzTU4rL2ZmSFlnejBpa2M0UXRoYVMvOWg4?=
 =?utf-8?B?N3VvNHkzeWQ1NjNHclJLdXNIbmppV2pDTHhocWVLVUZvblQyeDM1bzVEdWYr?=
 =?utf-8?B?RW8vK3l0MXdRYUhnb213VGQwYzJLZnB5eXFIQWZwdG55UWZEN0pIeExKT2Ev?=
 =?utf-8?B?a21CdE9wWElLZmY2ZzZzMVR0MHp1ZjB2VW40T3U2Q21scEo2WGNmcDFKb2Mz?=
 =?utf-8?B?aVVHb3lOUk80eTBMZUV4dy9GL0NoTVdjU1lCTEJUN0NsUm44ZXZWdlBmY09k?=
 =?utf-8?B?YXBtYzJqK3Znd0RNNndWOG1CNTdUa0tBRlpkaDlobUZhS2liVFYzSWRrUzNE?=
 =?utf-8?B?Y3gwRGZhZ093WFVmMVF4d3pRWklxUjNlK2FydWt0M3g5WVhDRnBiSFlhU0V3?=
 =?utf-8?B?Ym9qTjNUODdjQWpFRjd2TGlFTW1qYnpiVVREVnNLQ0hIaFlVQkV5VmN0cWdG?=
 =?utf-8?B?YlhhUXNKTFNaOGdqZU1VM1gwNGROZ3hSNE1PNUU4TEh1aHo4c0ZnQkhwZkVx?=
 =?utf-8?B?c2x0UXB6VG9tS2N0ekhLV2V6cnhsSEw3V0Yzd01ZdXl5VUpqSE9KcW5vaTRX?=
 =?utf-8?B?WEw2aEtDUTFPK2wrWFJIWmpnVHFOUlpPaXJ2MTFvYmFUZ3daMmRPSm9raEJJ?=
 =?utf-8?B?dDNIei9vY1NqSENCU0xJV1pOcVptMS9NRWtYM05NM0NvSVN6aHE5V3IxOGor?=
 =?utf-8?B?TWFkd242c3VrYWVJUlBURGVwU0ZORWhFUEIzRGZpMmdzMjhCbXhoVi9LQXpw?=
 =?utf-8?B?TFRmNGNEQ20zZnJLMk0yRWQ5MnFLMUphVFlDVTVIZ3BwZGJVTG1YNTJuUWVQ?=
 =?utf-8?B?bkNrSDM1c3NscW5SN3V6bEptbnJHKzd0b1hNSkZnSFJDRXdXRW11d2FPUHdi?=
 =?utf-8?B?eHJEb2xJaEE4a05NWmNsYVdWdWdQSkZEcG9qUTBTRHdVem9hR01qTXE1V0JM?=
 =?utf-8?B?NE9NalZsNE1qeDBWY3hzMlVmL2tSRDdiOHkxVFBlTndFa3ZiZWRJVEllYjht?=
 =?utf-8?B?OHVxRUJZSzRSWUd1LzhZVDNaTk9EZmppTCtMNTc4ZXFCVTl5dk1wcDgyQkFN?=
 =?utf-8?B?ekdDK1gzMEhoamtSV0N5SFFrM2NiTTNXSEdsUDhlK0xaeTQ1MXZIdXFGOG5u?=
 =?utf-8?B?SEhPNzdBb3BncUpWelRoeXlBQ1U5ajEwY3JXSEUyaFk1R3dqUkpXYWZDQ29D?=
 =?utf-8?B?dkZXa1J3Q2xMcjdaUzRpbXVsa1J6RFhraDFYcGNPUnNHWDFOeE1PcjJVYTFV?=
 =?utf-8?B?UzlWTFJiT3M3eURnR2RJWm5iRjRJRXdvaTRwMFQ5OWV5K1poaEVTblROcnBO?=
 =?utf-8?B?K0VFL0NUNm5RME02RkxpS3IyV0hCU0ZyclBxQmtRQ0lPelN2elE4WkJlUGxs?=
 =?utf-8?B?NjcxS1FBeEZkZ0VmaFgrQXdlanRsbmZCaE1acEdYLzRxd0hOdERsRWRQTWFE?=
 =?utf-8?B?UGZxNENwSnJoWFRjb3p6NTF2dklmTWRReGY2Z2RwU0JrYjk1STUwWGszdVBI?=
 =?utf-8?B?U1ZyRno1RFJtdkIzaEloZ0YvNFprZ1Y3dERxQ1g2Wk9Wa3dCeXc5LzFVK09G?=
 =?utf-8?B?RmhkOXlJbG5mN3NVRW5PSzFIL3ZYbFhzcU9LWFB4dWJaQUhFUjc1R2ZlMGls?=
 =?utf-8?B?TUozQjVFU3pDR0pYN1NyN0p1a0NKOTg3Q2xLQ0QvQ0g4NVEyYllaZ2ZWN3kx?=
 =?utf-8?B?eUFDdmVqZElrNC9EVGxIV0lZY2RGems2YWZhSDNpTjNESVcxcllQYy83WGN5?=
 =?utf-8?Q?PYFfKkGrqNvh4ZSnezayP/I=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a81c7073-8c76-44e3-7c37-08d9e7e8937d
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Feb 2022 14:13:54.3945
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HWPdn7O04mPzLHaJkgfFSee6csCnHylhRTAB/wHgl4PRvFhJgFCx3vFXx7VzA9TITY+LnAU2S1aKzud3NBFRMQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7208

On 04.02.2022 15:08, Thomas Gleixner wrote:
> On Fri, Feb 04 2022 at 10:23, Jan Beulich wrote:
>> On 30.11.2021 12:09, Jan Beulich wrote:
>>> I think it is b968e84b509d ("x86/iopl: Fake iopl(3) CLI/STI usage")
>>> which uncovered an issue with get_desc() trying to access the GDT, as
>>> introduced by 670f928ba09b ("x86/insn-eval: Add utility function to
>>> get segment descriptor"). When running in a PV domain under Xen, the
>>> (hypervisor's) GDT isn't accessible; with UMIP enabled by Xen even
>>> SGDT wouldn't work, as the kernel runs in ring 3.
>>>
>>> There's currently no hypercall to retrieve a descriptor from the GDT.
>>> It is instead assumed that kernels know where their present GDT
>>> lives. Can the native_store_gdt() be replaced there, please?
>>>
>>> For context (I don't think it should matter much here) I'm observing
>>> this with the kernel put underneath a rather old distro, where
>>> hwclock triggers this path.
>>
>> I'd like to note that the issue still exists in 5.16.
> 
> I'd like to note, that I've seen no patches to that effect.

I could have worded it that way as well, yes.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Feb 04 14:19:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 14:19:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265627.459039 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFzQt-0000v0-P8; Fri, 04 Feb 2022 14:19:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265627.459039; Fri, 04 Feb 2022 14:19:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFzQt-0000ut-Lj; Fri, 04 Feb 2022 14:19:27 +0000
Received: by outflank-mailman (input) for mailman id 265627;
 Fri, 04 Feb 2022 14:19:26 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=46ws=ST=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nFzQs-0000un-J0
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 14:19:26 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 72bf851f-85c5-11ec-8eb8-a37418f5ba1a;
 Fri, 04 Feb 2022 15:19:24 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 72bf851f-85c5-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1643984364;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=+mvk/5f3TYLE0J8IBUrwlOLYKW0t+D0F6uL7TQtujAU=;
  b=UMIlC2XnK6BDDzWM8AY2LjdZdO6GP8MtlVj9eICqvh1DvlobmKt2rtpT
   zrbLALABuStROSV7srMOuPT87MRS/FvdkS9HED90hHoj9Asnav9TRUcr2
   EDOY2zhCwb7OP8NfOnIfkSSuxSgi830yeCITNKqBIxQpsdgnLdJfscK7o
   g=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: it6+N39jIf7n0C1I+1zEjZ7XzBp0Fo5+6Cf6daT+gzttYj+NfZ3TEsK92RWYPVDFx5KwS8avDO
 n7Et0uS2ExGbDt2RnaFqQaCYfbrirQWsKTiuL72RHDctfcAay1J3azAh0NjzYT6HlNRvoILpXD
 UzDftRvyuM0VQu7w3x7FDsUIrcRybhJBOKG/wJW83fT3si9Kc+QskLhzKGSRZM0wnuxGjvjHqA
 fkZXrNBQ3Gdm50DnDdvucy2xmYsDtp/RFDbXf1wBFfAkFIx7LAkrc9GAXGSVbVjNenVWFdkVlz
 ZQdeUbuahlopj8x6BoxJMr/Q
X-SBRS: 5.1
X-MesageID: 62964726
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:ZpjQ/KlVTWhxm5Fu7aQVis3o5gx+IURdPkR7XQ2eYbSJt1+Wr1Gzt
 xJLDG6HO66MN2L0ctsjPo60ph8EvZLdn4BjTwNqry81EiMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BClVlxJVF/fngqoDUUYYoAQgsA180IMsdoUg7wbRh2NY02YLR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 MpvpKa3Qx44BaTRv8hMVhcINQRlEaITrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBNPsM44F/Glp0BnSDOo8QICFSKLPjTNd9Glq154SQqyAD
 yYfQT1VTSTvXRtGARAwNpNurLerl3r/MDIN/Tp5ooJoujOOnWSdyoPFMtXPfceRbd5IhUver
 WXDl0zpDxdfONGBxD6t9nO3mvSJjS79QJgVFrCz6rhtmlL77nMXIA0bUx28u/bRoke7UIMBA
 1cO8SRoq6UunGSpRNTgWxyzoFafowURHdFXFoUHBBqlk/SOpVzDXy5dE2AHOIdOWNIKqSICy
 X2YpdTjHC1UuaCyZSOY+OeyiCieNn1ARYMdXhMsQQwA6tjlhYg8iBPTU9pueJKIYs3J9SLYm
 G7T8nVn71kHpYtSjvjgowib6965jsWRFmYIChPrsnVJB++TTKqsfMSW5FfS9p6sx67JHwDa7
 BDodyVzhd3i7K1hdgTQGI3h/5nzvp5p1QEwZ3Y1RPHNEBz2oxaekXh4um0WGauQGp9slcXVS
 EHSoxhNw5RYIWGna6R6C6roVZhxnfO9S4m0Da+PBjarXnSXXFXclM2JTRXIt10BbWB2yf1vU
 XtlWZrE4Ykm5VRPk2PtGrZ1PU4DzSEi32LDLa0XPDz8uYdykEW9EO9fWHPXN7hRxPrd/G39r
 oYOX+PXmk43eLCvPUHqHXs7cAliwY4TXsut9aS6t4erf2JbJY3WI6SAnOp8K9E5xPk9eyWh1
 ijVZ3K0AWHX3BXvAQ6LdmpiePXoW5N+pmg8JisiIRCj3H1LXGplxP13m0IfceZ1+ep94+RzS
 vVZKcyMDu4WEmbM+igHbIm7p4tnLUz5iQWLNiujQT4+Y58/GFCZpo66JlPipHsUEy66lcoiu
 Ln8hAnVdoUOGlZ5B8HMZfPxk17o5SoBmPh/VlfjK8VIfBm+65BjLiH816dlI8wFJRjZ6CGd0
 gKaXUURqeXX+tdn+9jVn6GU6YyuFrImTEZdGmDa65ewNDXboTX/kdMRDr7QcGmEBm3u+aika
 eFE9N3GMaUKzARQro5xM7d31qZitdHhkKBXk1Z/F3LRYlX1Vr45eiua3dNCv7Fmz6NCvVfkQ
 VqG/9RXNOnbOM7hF1JNdgMpYv7aiKMRkzjWq/80PF/79Gl8+7/eCRdeOByFiSp8KrppMdx6n
 bd96ZBOswHv2AA3NtumjzxP8zXeJ3MNZKwrq5UGDdK5kQEs0FxDPcTRByKeDEtjsDmQ3p3G+
 gOpuZc=
IronPort-HdrOrdr: A9a23:930SM6xVsIgFBbPCwDvsKrPxtOskLtp133Aq2lEZdPULSKOlfp
 GV8MjziyWYtN9wYhAdcdDpAtjmfZr5z+8O3WB3B8beYOCGghrSEGgG1+XfKlLbak/DH4JmpM
 Jdmu1FeaHN5DtB/LfHCWuDYq8dKbC8mcjC74eurEuFDzsaE52Ihz0JdDpzeXcGIjWua6BJcK
 Z1saF81kWdkDksH4+GL0hAe9KGi8zAlZrgbxJDLxk76DOWhTftzLLhCRCX0joXTjsKmN4ZgC
 X4uj28wp/mn+Cwyxfa2WOWx5NKmOH5wt8GIMCXkMAaJhjllw7tToV8XL+puiwzvYiUmRwXue
 iJhy1lE9V46nvXcG3wiRzx2zP42DJr0HPmwU/wuwqUneXJABYBT+ZRj4NQdRXUr2A6ustn7a
 5N12WF87JKEBLphk3Glpb1fiAvsnDxjWspkOYVgXAae5AZcqVtoYsW+14QOIscHRj99JssHI
 BVfY7hDc5tABOnhk3izypSKITGZAVwIv7GeDlPhiWt6UkWoJgjpHFogfD2nR87heUAotd/lq
 D5259T5cJzp/ktHNZA7dc6MLuK41P2MGDx2UKpUB3a/fI8SjrwQ6Ce2sRB2AjtQu1O8KcP
X-IronPort-AV: E=Sophos;i="5.88,342,1635220800"; 
   d="scan'208";a="62964726"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=TyfbEr4/v93385gLdoviaur/J0ELbeNQJOJFmgwOzgbafVF5LSOySyuyGw62RbSugurFEK7vPLKGsHONHu+ip2/OnnFeSTwT5SWCwpEmww1sFyr+I/D2/xIQH0c50u5dhHXevtJGxp/MrHtofg4PE12SUA7zlN3MaEpRDQSFAmAAIHa0vWmP649WKxn1SHGRIXxzv+fV+dgAKIEqPaZPVTkqjrnXeuVB1pB0Du9bvNVCCa6pQAdLou82b+hyPRgAWFYF60d9tMrqL49OVsH4xmZghwRnO/W/MztxR5FLdyZQnw5yGNKCxCODaFQh4+ekmzvW+9UM9Mk+g38CW6YqKQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=cNtyWrjlNOFS1xI2PYkTtYJcph77hlzF9GI9yRvXujE=;
 b=gAeLlkpH3h7jD8RywDByidCrmP1y2oiB4HEJZal0zSotcEasadkHzd3k5j62ioGO0f8V1SVETKTlrnjWk5K/scMwOezv3QGCoJo9G+5VDLLU0PoXMXrOnlIrb/waQaDUpJ7zT8X0W+fkV+f6wMH/ODIoUsKLgddoUNgZVg8C4I/nSsii2A/DgChfm99Sojq68vABRx83P76qk2lJZUqQD6z9tLB4rsTuI9Z8Wgb4wQ/G3cFaaLjlmOfha/pxWhO/b7eXTqjuldjoC+ErwEWtjNxJ22ADjS7HYxzMgngjA1vRniturBi6UfD/VeGDn0/Dc5YTaZF2g80RZ9atH+Q17w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=cNtyWrjlNOFS1xI2PYkTtYJcph77hlzF9GI9yRvXujE=;
 b=kP8gRNMRSYkZ2xoSYr3qcpDfqbuixLDF8XWE3NV1ITyxE4GswlgpoPJTIm4GQVdivr2IwaCE80+gFSToKyNED9vZKJ54BFN76oWW/uVJYykxL/cr60t+h4RX1Aolq976iv+dV+nI53mB61hL1GD1/Lvcuw5643wGF4Dx8R9cT3g=
Date: Fri, 4 Feb 2022 15:19:12 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Andrew Cooper <amc96@srcf.net>
CC: Jan Beulich <jbeulich@suse.com>, Andrew Cooper
	<Andrew.Cooper3@citrix.com>, Wei Liu <wl@xen.org>, Anthony Perard
	<anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, Xen-devel
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] tools/guest: Fix comment regarding CPUID compatibility
Message-ID: <Yf014MB3PvkQmVG1@Air-de-Roger>
References: <20220203181023.1554-1-andrew.cooper3@citrix.com>
 <53b98995-8cef-48b4-7728-3bfbc236af5f@suse.com>
 <f2ce80ee-f30c-dc6f-e4b7-5d8eddb5b3d5@citrix.com>
 <1333696d-d3c2-15a8-1dd5-7cb0a17ef023@suse.com>
 <a28ff9e8-c022-6384-ee04-c21b69a4fdd2@citrix.com>
 <eb818153-3ada-ac46-fb14-da975a61574f@suse.com>
 <1905e626-da65-0541-802e-34e5d06bc1dc@srcf.net>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1905e626-da65-0541-802e-34e5d06bc1dc@srcf.net>
X-ClientProxiedBy: LO2P265CA0045.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:61::33) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 6944deba-5476-4a3f-fe7e-08d9e7e95549
X-MS-TrafficTypeDiagnostic: DM5PR03MB3290:EE_
X-Microsoft-Antispam-PRVS: <DM5PR03MB3290B9F05553C2F465E31BFB8F299@DM5PR03MB3290.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: LfvjzAh6j8BTOQ1hnb3yfK7LJusorcp7hFtypR8yzOJwZxNpyr8bLvQM1p7cAVRZAWHzY6XxoMqz4Aju0rvSkIB6O1ucD7pIkjcyVQKtb3hc+o+QiRSDOhUL8QV1+sg0e4mUW12CSncdXO8yTYJNim/IK5aS8EriulS0LQ0kw30eiFtMXNdcKQ+nxlWLuXApV5Jc8XK2CnE8TWdWXI47FesvIo8aL/GM4jcT+JEAzlr0QSGVN0B2M4xId3uaTgP3bk8TRZsZc9pON196k8ftaIZ4gaKUxldWwy0zoSRq3lNBOQFgTnQH6oNwqJF9AymBcZnLpdBilf/FRhDx+EGm9xNh3rwBqbn8ViZtCaUioVf8VmhzhMk9wCzB2GJTiOhfUmUmaw8SUWbE1A+l3vOwmldI5Jq2p6cVFL8orIqg0vHtdZqNrJSEA069cKBwKs4XrPcpHcy4jo24rsEPQf6RT905GpQTYqGfXUDfmkKq98dAh07JNHwsh2CbsGIUMkP5OXPmEFrWi75kDVPNcTf6/tW44Go+Ivhl1YwRh849wpaQeB/PrFLv6Wcw/IDUCdGhwY3msvRqpTHWSyyELepTwoNC2fkRxmZ4SlJHu6Pcc/yLgxS4Dg1OXmzSBOmRZj3lGRyK3kQdzXYxWt2uigxsaw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(508600001)(86362001)(83380400001)(33716001)(5660300002)(85182001)(82960400001)(6512007)(66556008)(8676002)(66476007)(186003)(66946007)(38100700002)(26005)(4326008)(6666004)(54906003)(6486002)(53546011)(2906002)(8936002)(316002)(9686003)(6506007)(6916009);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QVpEUEJtUS9US01pdVpLOXRPYkNVNFNwVUZCVlFBdXExWXdjd2F5NHhwNGFO?=
 =?utf-8?B?WWxSdWM0bWtpVUtJQ3FjNzRITWg0dFhNRHU3aXBIeTZyRm5rbHpUc3YvTi9n?=
 =?utf-8?B?SmtEL2RpclZhbXUzYlBoQkxHVFpTN2tKUS9HdTRJQkpTeDd1Ym5VTW40YVNS?=
 =?utf-8?B?REdKNmQvd3ROOUNXTUNVMStlVWF0Mi95dm1EZzR1cFZuRVRWOEJ2bERtVzlo?=
 =?utf-8?B?ckpPcEE4TFprQ0J5UzJCWVE2RzRmTTNOOFdPaDM0ZkZKbXZ0SnBKRVNmWW5m?=
 =?utf-8?B?YlV1dXJKRlk4R21BaHJ2cmxmTGtlRk0wM3N2OU5xQkxCVDNsQ1l1ZVYvNHRp?=
 =?utf-8?B?WSsrU0VVbkx5cnhRYmZTQ2o5UUNjcTNuT1U3bXZKTFFQNWQ4L2pQNjNJQWtt?=
 =?utf-8?B?akJUVjlhT0h1bm1MUXBMOHFRZkJpdVhJOHVpQ3JtTmFYQThiRUFvSWJqSUNo?=
 =?utf-8?B?WEJvVFNOOHIwdUdFVG9hdUR1T0xwK0w0Mk90S1h3Z09HOUtDMHN3SGwzekdt?=
 =?utf-8?B?VzVQNHN5L1VHdmYwQWdhVWhOMjVSVkZUOFFxTzZoOUYwVGR1TmRDVWpOQVc2?=
 =?utf-8?B?cmhHRjA4WjlKN3VXTnBad1U0RDJ4dHNTeC9vdnp4bGZWb0xtSFRCTWxRWU9C?=
 =?utf-8?B?aEFsMWhZQmMrRHVRYThFM0lraDlxdEszSkl3Z1hDMEVpbjQ5WENZaW9ZTUNC?=
 =?utf-8?B?R2t3ZEE0emNGd09CbUNNYytuWHAzZXErV2JMYzZxanRkQ01QdnFmNnZDdW1F?=
 =?utf-8?B?NDZ6UWtmUUhONWRIYnJwdXQ5N2paakhMRHBpQ0F4ZUtjTjBLTDdyOUxDN1l5?=
 =?utf-8?B?MFBWMVZqRkk2OUU0QTFIK1RCVkc5a3hDZzlDeXVOYmp1cWVVb2hMbUhGa1FP?=
 =?utf-8?B?OTZKanljR1NoeHQxV3FXSXZ1WVIwSXBORUpjL3lSMG05UGtTMi94czJ4cEQy?=
 =?utf-8?B?Zm5Gd3c5MlpSR3gzRmRKRUZaemh3dVYyam92Z0k0ZEp6bUh2cU1iNk4yZmJN?=
 =?utf-8?B?Y0RMRW1DQWppV2c0OFl4anRYS2RQeGRrdWlPUUxuTEVPKytpYVVnM2VtK29z?=
 =?utf-8?B?MmQ1UXREZ0JDWTVmY2hqVnVzMGZkTnlMamU0bFVUWmxsR3BHL3Y1dkhwaXNp?=
 =?utf-8?B?U01NZHNaSXo1WnRBMCthTm8rRy9sc2pSS1NTdHZSbURmZjFmdEhQdW8yeGdQ?=
 =?utf-8?B?T3p2TlRtYXJseXVKUXFyTWJVUGhHQUQ5ejc1a0I4em5uVVowZGI1MElLbDlG?=
 =?utf-8?B?c0tFSE9HMTJyYi9EZVRYTHkwNjdtOEFxbjdCcnhmcUFSb3N3OTNOT1JsQlZQ?=
 =?utf-8?B?ZGFXTGZ4VTh0aVdQLzl6ZTNRVXZTVmF3d29GOFZadmNZanZIdlVHbXEzVVZq?=
 =?utf-8?B?RG1zUEFUbzFUZ0c2OTVGUUJWazgyaFA5NHNTa2kyck1hZzVuV2VOenlhQnRB?=
 =?utf-8?B?MGlCOUEzU0dEQklVKzNXWkJWTjlkc3ZYVDMwOGJJZm1VNjd6YTl3eGdFL1Bv?=
 =?utf-8?B?eGJqRmZJWGo4QzV6V1ljM1BFVFBjai9QUUxLdEkwYTdGdjJJUXhTS095ZnFs?=
 =?utf-8?B?UW1UU0d3WXlGdmZsZWthZEc4bW5xRlE2WnJPdi9PcXZqWlg1ZE1JYU45dUkr?=
 =?utf-8?B?MlYvWjhEd0pmcVRYNW5nNXpYVHdZemc4cTdTM3V6bmw1bGpob1R3dlk5a0RG?=
 =?utf-8?B?VSsxOTJVU0Y2QjBNTHFCaUM5TFBPRXNJOVAvMitUK1VyZDhHejNvYTBJN1FS?=
 =?utf-8?B?TUtPMmZlVGFEWGV3VFVGTWNxNEM2TTJEUUh6UE5LRTlKc3RMUnNpR3ZGVWVV?=
 =?utf-8?B?Wjd6K1AyOXYxVlg2YjdVc3Ira0cySjZTZTI5a3pIRzVobm9ZTzZ6TmlnZGo2?=
 =?utf-8?B?NmRsalJzVFluTHV3RTRkazRaQnVFNDZKeHF1NWlaMEhsWTZFcXJBS29hZ0tX?=
 =?utf-8?B?UWEzSmJQVTIraFUydFlzZnRzUWFuS0dVT0dLUFU1bmpyMGMzQ1pqQzBrRXNY?=
 =?utf-8?B?YjlCVUlqWE1yYi9kY095YmRiZ1pFQTlMLzR5L3lHUjZ1bzNCTUdqc1FBTmFL?=
 =?utf-8?B?bi9IbU9RSnZvUS84Q1NWYkhpOGswMjBLZ0wyQ1V1NDQrbWtYeVhYRmRrV3g5?=
 =?utf-8?B?RGFheHc5U1RXZmFmRjBlYnFZczVEZE4ySGs2VVJwbTlna08xVkk1MzE4S2Jp?=
 =?utf-8?Q?zDSx08YIjhusctBTo1Ag7cY=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6944deba-5476-4a3f-fe7e-08d9e7e95549
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Feb 2022 14:19:19.6600
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TiIpQaP8XRhfj6H8nmCKIJcPBLHDh8vUCfQoJzt0eeYvuWaoPT4rxvajza9CQVpGTSoPGoHpefNZk1mSCyQeQg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB3290
X-OriginatorOrg: citrix.com

On Fri, Feb 04, 2022 at 02:10:03PM +0000, Andrew Cooper wrote:
> On 04/02/2022 13:46, Jan Beulich wrote:
> > On 04.02.2022 14:34, Andrew Cooper wrote:
> >> On 04/02/2022 13:09, Jan Beulich wrote:
> >>> On 04.02.2022 13:12, Andrew Cooper wrote:
> >>>> On 04/02/2022 08:31, Jan Beulich wrote:
> >>>>> On 03.02.2022 19:10, Andrew Cooper wrote:
> >>>>>> It was Xen 4.14 where CPUID data was added to the migration stream, and 4.13
> >>>>>> that we need to worry about with regards to compatibility.  Xen 4.12 isn't
> >>>>>> relevant.
> >>>>>>
> >>>>>> Expand and correct the commentary.
> >>>>>>
> >>>>>> Fixes: 111c8c33a8a1 ("x86/cpuid: do not expand max leaves on restore")
> >>>>> But doesn't this commit amend 685e922d6f30 ("tools/libxc: Rework
> >>>>> xc_cpuid_apply_policy() to use {get,set}_cpu_policy()"), which is
> >>>>> where DEF_MAX_* disappeared?
> >>>> No. All that happened in that change was that we switched to using
> >>>>
> >>>> cpuid.h:89:#define CPUID_GUEST_NR_EXTD_AMD
> >>>>
> >>>> instead, which remained the same size until Xen 4.15 when e9b4fe26364
> >>>> bumped it.
> >>> Oh, right. I did try to look for a replacement, but managed to miss
> >>> this. But then, as much as 4.12 isn't relevant, isn't it the case
> >>> that the fact that CPUID data was added to the stream in 4.14 isn't
> >>> relevant here either, and it's instead the bumping in 4.15 which is?
> >> The fact that the bump happened is relevant, by virtue of the fact there
> >> logic added to cope.  The fact it was in 4.15 is not relevant - this
> >> isn't a list of every ABI-relevant change.
> >>
> >> CPUID data being added to the stream is critically important, because
> >> that's the point after which we never enter this compatibility path.
> > If the bump happened before CPUID data was added to the stream, logic to
> > cope with migrating-in guests would have been required too, wouldn't it.
> 
> Yes, it would have been.
> 
> It wasn't an accident that none of the max leaves changed while doing
> the Xen CPUID work.
> 
> We're unfortunately a long way behind on Intel CPUID leaves, but all(?)
> of the new leaves need more complicated migration safely logic than the
> toolstack currently knows how to do.
> 
> > But anyway, just to be done with this:
> > Acked-by: Jan Beulich <jbeulich@suse.com>
> 
> Thanks.

Will rebase my CPUID series on top of this, but I will wait for
further comments before sending a new version.

Roger.


From xen-devel-bounces@lists.xenproject.org Fri Feb 04 14:24:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 14:24:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265636.459050 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFzVb-0002N7-FN; Fri, 04 Feb 2022 14:24:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265636.459050; Fri, 04 Feb 2022 14:24:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFzVb-0002N0-Br; Fri, 04 Feb 2022 14:24:19 +0000
Received: by outflank-mailman (input) for mailman id 265636;
 Fri, 04 Feb 2022 14:24:18 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=u+82=ST=epam.com=prvs=4034f0a382=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nFzVa-0002Mu-FP
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 14:24:18 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 21bd3fa4-85c6-11ec-8eb8-a37418f5ba1a;
 Fri, 04 Feb 2022 15:24:16 +0100 (CET)
Received: from pps.filterd (m0174680.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 214ENubT001176;
 Fri, 4 Feb 2022 14:24:06 GMT
Received: from eur04-vi1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2053.outbound.protection.outlook.com [104.47.14.53])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3e15v90014-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 04 Feb 2022 14:24:06 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM0PR03MB4577.eurprd03.prod.outlook.com (2603:10a6:208:c1::33)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Fri, 4 Feb
 2022 14:24:02 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6%3]) with mapi id 15.20.4951.014; Fri, 4 Feb 2022
 14:24:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 21bd3fa4-85c6-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=UBGvwVQ00on9FXtRQUSLoI8kTDs1+6SmnEt5JfWi00QRcGUtFVp9Mb+DhyxIGuBNbgm5iWprXteHFb7WRsD1ZM73ShYdCrGmzxR+Lp5Onu7Cgg1PVtbVMOplejcGloTlQ2zYXLxNndSCA1uFdR56nrYITlP7+KWgQ1BrWuRM63PenYoVlwth4ILmOAVlCWSuxPjQfJgdOCvNj7ufcYX7ombWdn4qvJGZh/bbs4P5sqECvcuBS+KRpthydKlJwC6g53Rs74pVq6GPVuGnr0JF+wQNX+6Jkgw1iw+S1DyJ7v6h4yCTQz7YNzYyGPNQSBN3VIzcB2xaJKVNNSEWfBEE8g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=9VOvhtcv7FhQ67RS/6IdCg/8um4grepF7cuEjXpc9HY=;
 b=drgEkhHrEQYFD66hpikVmX4rBc5pCdtIupP+LG96LAInFi5/mpzfVJ657Sev1I7D4/wqebKKpdU5SQHbxBh4ckFY5Ppx9cpL3VG4CAdWEVKRZ4DWXEatMd5rQcMnMh30V4m97GxtuAf5MR9ORjagNhxPxRYgBgJF++w6H9NkQyhk2WVMcbQgkgw58JGBSsf5VruwbE2PpKBCY22tUgpzKbnKpasiBRfHEM47SOydMwAWBSIkOmhZowgkOU4yENuP4Y8xMnJxN1tUlzNfSS0WId3UqL5u3eQzJnfQSdHR748g/bQJQfF8fE/BPOd5N9qn9MItDWhCEEKnaCTi/fGO4A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=9VOvhtcv7FhQ67RS/6IdCg/8um4grepF7cuEjXpc9HY=;
 b=PacHSp/mDaEPFdgFjyeRyelw1rfRJWD/VebbStLeHMmBahCwOu7pnow/5Yud52s2sAx4kEFQ13OCV/u9y16cbHsRpxCHeUH0iKd8e+Yp1K6+Q9KwWFHTOsM9ZJ6ksv+X1XMCJDKuNJQd1KXZQZMItO2WqI8VSsZu0rtJxQteIEZsfIE3Xwwm5BmE5DfNpZpIAFKOtDJtovVgr6Vf1AYZjtX+CqY/As6vcIle/kogzc6kGUq0D4YeTuaSrYTm/wUQzmKbVyT8x41I9mySPa8LM0nXIRd8pGdtARdHS1wu12trnDkswY7Pst3QYkYnp0qlfRENdVn6FuX2RQrnaAALGg==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "roger.pau@citrix.com" <roger.pau@citrix.com>,
        "andrew.cooper3@citrix.com"
	<andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com"
	<george.dunlap@citrix.com>,
        "paul@xen.org" <paul@xen.org>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>,
        Rahul Singh <rahul.singh@arm.com>,
        Oleksandr
 Andrushchenko <Oleksandr_Andrushchenko@epam.com>,
        "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v6 04/13] vpci: restrict unhandled read/write operations
 for guests
Thread-Topic: [PATCH v6 04/13] vpci: restrict unhandled read/write operations
 for guests
Thread-Index: AQHYGZFbf8/6pUr0mUKzbmboCx8QkqyDbvWAgAADnYA=
Date: Fri, 4 Feb 2022 14:24:02 +0000
Message-ID: <f86a43af-1388-6959-3e71-ba796e4a0c63@epam.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-5-andr2000@gmail.com>
 <b6f091ed-4fa3-e292-9a21-a780ec90ee09@suse.com>
In-Reply-To: <b6f091ed-4fa3-e292-9a21-a780ec90ee09@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: c24766bb-898d-4401-e075-08d9e7e9fe24
x-ms-traffictypediagnostic: AM0PR03MB4577:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM0PR03MB45774329A229A9B4914007BEE7299@AM0PR03MB4577.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 b4DGUXr7l20NDZFAgb/9tXxy4RuEj5e2x/mtVS/pxgHXlCcSbRWMOzKUbojthdH+Ibc6jv4qiX2gcsjlUrGiTG7EGIdB87RO7H+yJts6gBVt1EOwqt+Z9T9YC8q8MeVUwyYEuV2+2YmqO4zKJRE2zrVxAxKfG5AysDje+voxX01Q8G8GYDkckq5zwoiSvkFx2lt6vqeVH5uxQ21YtObNTFv3aCCjgs2/k0WH31Kieb9XagQY7T3WLEoj6vvZ+AyqTdxX6pIZ/KGLKmsJBLZA5YVzIuHRyHyzkzbviYJ6EiTILH2efNsGaFbhX853OL5RrQRI821RXDAp4pN/39xkXTGHcbKQDXj8McwvdS5OwMFqmaOgHEshna34ielV+c2GvaGUZ5YnKOhhqmkTdEx1+1AbkbO8iiEB2rcgzAOwjdZTOJirhhOH3J0oUvhHtkCivou71ALOGt77e2XjC7xTdFi8Krp36MFX3utLqPRlIRXO+bNGOX+92v8jL9GIPXpiBL17NeFhlUPPD4q5UORwG0TTWYz7jSlysR1JXUvD9GYqxnifGiPGG5VlU5rkYv0ZQdw+pPNepnCWGu4FPfm1/zCJYolc5dJkxU44HogisFJAIfpbGICxbDT6NmYGVqyM0kEqABoGKpbs8XzphegLtZAgHseVdP24CY8suyy1/AyMcX1xs0KckKs4qVIyr4E+vOAUbOxvPCQdv1ChbC6YFJI4AbQkB5AhLE7GV6oGCflZnyz4zl7dSklgXZjGcAdb
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66946007)(64756008)(4326008)(66446008)(6916009)(54906003)(76116006)(6512007)(31696002)(66556008)(66476007)(2616005)(31686004)(8936002)(8676002)(86362001)(38070700005)(91956017)(316002)(508600001)(71200400001)(122000001)(6486002)(38100700002)(83380400001)(26005)(7416002)(5660300002)(53546011)(36756003)(2906002)(6506007)(186003)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?RVlYa0xWT1UrSFFtR2N0SFlyaVpBVko4cEhtbnRxZk8vamxJS2oxcGJMNUdh?=
 =?utf-8?B?aEJvc2ZPU1NnSEl0ejN0NTBWbWMrYjZYZTZwckdoWEM3VVprVGIyVWpqcXcx?=
 =?utf-8?B?MGZJK2FxQjU0RzQwUmFLS05zcnZkcjdZSVgrbzF1Uk5pOVluc0RUZlc4U1kz?=
 =?utf-8?B?eGJ5eFpDNjJSNkZCeS9WSnhwdFQ3OFpUeFp1MW5GREJZZ2Q3RXFEUVhUQjkr?=
 =?utf-8?B?Uzc5TThuZzJ3OHBrQytWNnFHMEpyQVF1ZTBySitHSWlHOGpZaG1RNmNPWGg0?=
 =?utf-8?B?V1dxNk9uRGQ1a3ZkcDgvcGNSZmRWWWpkTEh0dU1vYU1sZFZxMFFrR3FaQVVr?=
 =?utf-8?B?dGlHY2MwN2JtcTMvSGk0YnhOS29iWUJ5OWxlS2pXd0FxU0J5ZFlHT1VCWHcy?=
 =?utf-8?B?Wlo0cGJFdDBITzQ2STBpMEhEVUw1Rm44VDRvNmhDSkFaNVA0cXBTWjJVaXB1?=
 =?utf-8?B?cDNQRzNMVk1YV2FCb0xGK2ppbUVEeXlyajltTTVUV3JzNUZWa25iQ05zOWJV?=
 =?utf-8?B?cTMxNTZIeVlqWlcwb3ppbzk3c3JJY3N5SXpzeEVSdEh4MU9Yb09Lc25sTzA0?=
 =?utf-8?B?Rm1oMHlHejh1a2FhaWtSeHZYYloraFgwMHplZHJPanFDYmpWcWU1cDY3MDRl?=
 =?utf-8?B?RVJDS21WKzR1MFcwQzFvc2ZqVUY1ZDVBaVB1ZHhiTDgxQ3A1RUM5ZzdrLzVo?=
 =?utf-8?B?blZCZlZ2YXArMnBZRUFzM3F4QVBIbWFtRFRUMFBiL3NoZ21HMWJGVFpTQ2lq?=
 =?utf-8?B?b3RTQ0EzRVgrRmRibWJSdXg0R1gvZGdHWDVFY2VnS1FMLzQ4S3c0VW9tck9N?=
 =?utf-8?B?S3JJYU9qME02MzczR0JqVjZOSzZyb1BmZkM0SmtSZk1aRzlLRUFRaU83NnVK?=
 =?utf-8?B?S0tFTkZBWkV0S3hFQVU5MVlnY2ttK0tHYStrdXFaODJOVlhpbTY5TTNIUExC?=
 =?utf-8?B?SmRqVW5CSitVSGhZVHRrRHNQNk1EdmV5bFRQZG9KcE5nVkdSWFlPaUZ5Zkpl?=
 =?utf-8?B?elA0TzRiTUticTdYdDZ3blBwWEI5cUZpMVptZGY5WVh1QXFoaVQxVnFzY2VG?=
 =?utf-8?B?Q2ZWNnZpeVAyNUVGK0lZODBQYzdSZTY1RDZvSk93aEJWNnR3WURYRlgxeVFs?=
 =?utf-8?B?UE41UmxNUFRxeDh1bFNQRWorOWNkZUdLRnIvWGlWU0NwZjZqMXFFZ1BoR3Ey?=
 =?utf-8?B?Q21sM1dLZWZqWnpzQ2lEK2Y5dkk5bk1JMkhBVnROZzgzWjRWcGtva2xNU2Jl?=
 =?utf-8?B?MGFYMElkK3BCV3cyR2ZGN0V6VENLYVhlTFRBaFR4Rm9iSjhzWG1SaStHRllL?=
 =?utf-8?B?V2FHdDdZOUM0SlBMWEVkbkNhVVNCRkRaYXpGQWg5bDJJdnV5Q1Q4cUZrcFRj?=
 =?utf-8?B?K3p6NkpjSUNjcHBwNTA4ME0xSjg1all3djhHc1JSSjU1WVR1eFc4TytZWEtU?=
 =?utf-8?B?WHVnVVhLYk9kSWtZMjBNZzUvaFAxckMxbDNFZS8xY203S0R2N1hnc3hQWjF0?=
 =?utf-8?B?RGFkUW16cHM0czYxVnBycHpXYjVwNHMxR0JUL0M3cS8ybHJFbzRpdGNHTUp1?=
 =?utf-8?B?UHJYM2lyb2NpT0dzWFNXcDd3ajZlNUZkY1g4bElRbGp4MEIzMDk4UzBaL0ZF?=
 =?utf-8?B?NzdLWkZHVW91bTRUQytSTXArQkJtRmd5Q1FucFNnWlp5Qk8rYllFSkd6ZnZN?=
 =?utf-8?B?bFBzeE9pandGb0xONUpmYnU2QVF0aEw3R3Y2YzZSVTJra0VUKzJudzlUVlZQ?=
 =?utf-8?B?ZThETmhSU0FHQ1lTU0d5TWZVdDY4bEt0VXVrNkpXcFpaRUN5dldFY3U5V3hM?=
 =?utf-8?B?QzQ4LzdYSjVjc1lqNXBXdDVXbXVwNHRSbUphSmV5VHFmdVVJRktMUjR5VWJr?=
 =?utf-8?B?WjI1VUhjR2ZnTUthcHBmUmsyRGpDaHpHYzhHeGxZVGhVckpmS1A5LzdWcDdx?=
 =?utf-8?B?TDNJR2w4a2V1WS9HSVhDMGMzNm9oQWxnOGVRN3lxRDlybUM4SUhLLzN1KzE0?=
 =?utf-8?B?ci85VkJITmVqcU9iZnZCeElKeHY0dnVqWGpSNCtXUEk3bElEN3VJblE0QlIv?=
 =?utf-8?B?YkVPdUkvRGVQUUlSb1dOREZwTTJCT3lHNTlxY3pzeFlqcWJsdUFVcXpIUlJ2?=
 =?utf-8?B?WHNPcW5lUE50Ym5YWFk2QjNtb01Ua0lFOHp1VGhKSzIrelFxN1pLNm95MStS?=
 =?utf-8?B?UC9LT1ZaZmQzTnowQjZ5RWM3Skp6dFRzdHdKSkM0ZFVjejVaTmthcXIwNzJy?=
 =?utf-8?B?TGZwL1JEeW1QdDd4MytoVWtoaXV3a05iei8wdnpmMlFMbjF2Ry9DNmZmKzlR?=
 =?utf-8?B?eUY1NTMxTExzWmZyMnk1YzM1ZTVXTjdHZ25JYUR4TVQ1SEtURzRidz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <19F2E9986367624F9CAB090E7C9D176A@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c24766bb-898d-4401-e075-08d9e7e9fe24
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Feb 2022 14:24:02.4830
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 2t3C/aD53/4tRPLND0rOuHoVvX3IKGqj82+BAq9BISRcabtkUIzfwvUZe+5PGvOrakd9dvE/sXyYtwAVuzOUq98XYPzsVYs1u1+mz2uK04tn2R8tX3P3rOhd55cel5of
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB4577
X-Proofpoint-GUID: suCDA3JQwx6HzGNeWWnY09x-HrTwujEm
X-Proofpoint-ORIG-GUID: suCDA3JQwx6HzGNeWWnY09x-HrTwujEm
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-04_05,2022-02-03_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 mlxlogscore=999
 suspectscore=0 adultscore=0 malwarescore=0 clxscore=1015 impostorscore=0
 spamscore=0 priorityscore=1501 mlxscore=0 lowpriorityscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2202040081

DQoNCk9uIDA0LjAyLjIyIDE2OjExLCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMDQuMDIuMjAy
MiAwNzozNCwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+PiBBIGd1ZXN0IGNhbiBy
ZWFkIGFuZCB3cml0ZSB0aG9zZSByZWdpc3RlcnMgd2hpY2ggYXJlIG5vdCBlbXVsYXRlZCBhbmQN
Cj4+IGhhdmUgbm8gcmVzcGVjdGl2ZSB2UENJIGhhbmRsZXJzLCBzbyBpdCBjYW4gYWNjZXNzIHRo
ZSBIVyBkaXJlY3RseS4NCj4gSSBkb24ndCB0aGluayB0aGlzIGRlc2NyaWJlcyB0aGUgcHJlc2Vu
dCBzaXR1YXRpb24uIE9yIGRpZCBJIG1pc3Mgd2hlcmUNCj4gZGV2aWNlcyBjYW4gYWN0dWFsbHkg
YmUgZXhwb3NlZCB0byBndWVzdHMgYWxyZWFkeSwgZGVzcGl0ZSBtdWNoIG9mIHRoZQ0KPiBzdXBw
b3J0IGxvZ2ljIHN0aWxsIG1pc3Npbmc/DQpObywgdGhleSBhcmUgbm90IGV4cG9zZWQgeWV0IGFu
ZCB5b3Uga25vdyB0aGF0Lg0KSSB3aWxsIHVwZGF0ZSB0aGUgY29tbWl0IG1lc3NhZ2UNCj4NCj4+
IEluIG9yZGVyIHRvIHByZXZlbnQgYSBndWVzdCBmcm9tIHJlYWRzIGFuZCB3cml0ZXMgZnJvbS90
byB0aGUgdW5oYW5kbGVkDQo+PiByZWdpc3RlcnMgbWFrZSBzdXJlIG9ubHkgaGFyZHdhcmUgZG9t
YWluIGNhbiBhY2Nlc3MgSFcgZGlyZWN0bHkgYW5kIHJlc3RyaWN0DQo+PiBndWVzdHMgZnJvbSBk
b2luZyBzby4NCj4gVGFuZ2VudGlhbCBxdWVzdGlvbjogR29pbmcgb3ZlciB0aGUgdGl0bGVzIG9m
IHRoZSByZW1haW5pbmcgcGF0Y2hlcyBJDQo+IG5vdGljZSBwYXRjaCA2IGlzIGdvaW5nIHRvIGRl
YWwgd2l0aCBCQVIgYWNjZXNzZXMuIEJ1dCAoZ29pbmcganVzdA0KPiBmcm9tIHRoZSB0aXRsZXMp
IEkgY2FuJ3Qgc3BvdCBhbnl3aGVyZSB0aGF0IHZlbmRvciBhbmQgZGV2aWNlIElEcw0KPiB3b3Vs
ZCBiZSBleHBvc2VkIHRvIGd1ZXN0cy4gWWV0IHRoYXQncyB0aGUgZmlyc3QgdGhpbmcgZ3Vlc3Rz
IHdpbGwgbmVlZA0KPiBpbiBvcmRlciB0byBhY3R1YWxseSByZWNvZ25pemUgZGV2aWNlcy4gQXMg
c2FpZCBiZWZvcmUsIGFsbG93aW5nIGd1ZXN0cw0KPiBhY2Nlc3MgdG8gc3VjaCByL28gZmllbGRz
IGlzIHF1aXRlIGxpa2VseSBnb2luZyB0byBiZSBmaW5lLg0KQWdyZWUsIEkgd2FzIHRoaW5raW5n
IGFib3V0IGFkZGluZyBzdWNoIGEgcGF0Y2ggdG8gYWxsb3cgSURzLA0KYnV0IGZpbmFsbHkgZGVj
aWRlZCBub3QgdG8gYWRkIG1vcmUgdG8gdGhpcyBzZXJpZXMuDQpBZ2FpbiwgdGhlIHdob2xlIHRo
aW5nIGlzIG5vdCB3b3JraW5nIHlldCBhbmQgZm9yIHRoZSBkZXZlbG9wbWVudA0KdGhpcyBwYXRj
aCBjYW4vbmVlZHMgdG8gYmUgcmV2ZXJ0ZWQuIFNvLCBlaXRoZXIgd2UgaW1wbGVtZW50IElEcw0K
b3Igbm90IHRoaXMgZG9lc24ndCBjaGFuZ2UgYW55dGhpbmcgd2l0aCB0aGlzIHJlc3BlY3QNCj4N
Cj4+IC0tLSBhL3hlbi9kcml2ZXJzL3ZwY2kvdnBjaS5jDQo+PiArKysgYi94ZW4vZHJpdmVycy92
cGNpL3ZwY2kuYw0KPj4gQEAgLTIxNSwxMSArMjE1LDE1IEBAIGludCB2cGNpX3JlbW92ZV9yZWdp
c3RlcihzdHJ1Y3QgdnBjaSAqdnBjaSwgdW5zaWduZWQgaW50IG9mZnNldCwNCj4+ICAgfQ0KPj4g
ICANCj4+ICAgLyogV3JhcHBlcnMgZm9yIHBlcmZvcm1pbmcgcmVhZHMvd3JpdGVzIHRvIHRoZSB1
bmRlcmx5aW5nIGhhcmR3YXJlLiAqLw0KPj4gLXN0YXRpYyB1aW50MzJfdCB2cGNpX3JlYWRfaHco
cGNpX3NiZGZfdCBzYmRmLCB1bnNpZ25lZCBpbnQgcmVnLA0KPj4gK3N0YXRpYyB1aW50MzJfdCB2
cGNpX3JlYWRfaHcoYm9vbCBpc19od2RvbSwgcGNpX3NiZGZfdCBzYmRmLCB1bnNpZ25lZCBpbnQg
cmVnLA0KPj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGludCBzaXpl
KQ0KPiBXYXMgdGhlIHBhc3NpbmcgYXJvdW5kIG9mIGEgYm9vbGVhbiB0aGUgY29uc2Vuc3VzIHdo
aWNoIHdhcyByZWFjaGVkPw0KV2FzIHRoaXMgcGF0Y2ggY29tbWl0dGVkIHlldD8NCj4gUGVyc29u
YWxseSBJJ2QgZmluZSBpdCBtb3JlIG5hdHVyYWwgaWYgdGhlIHR3byBmdW5jdGlvbnMgY2hlY2tl
ZA0KPiBjdXJyZW50LT5kb21haW4gdGhlbXNlbHZlcy4NClRoaXMgaXMgYWxzbyBwb3NzaWJsZSwg
YnV0IEkgd291bGQgbGlrZSB0byBoZWFyIFJvZ2VyJ3MgdmlldyBvbiB0aGlzIGFzIHdlbGwNCkkg
YW0gZmluZSBlaXRoZXIgd2F5DQo+DQo+IEphbg0KPg0KVGhhbmsgeW91LA0KT2xla3NhbmRy


From xen-devel-bounces@lists.xenproject.org Fri Feb 04 14:26:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 14:26:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265643.459062 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFzXB-0002xA-Tm; Fri, 04 Feb 2022 14:25:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265643.459062; Fri, 04 Feb 2022 14:25:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFzXB-0002x3-O4; Fri, 04 Feb 2022 14:25:57 +0000
Received: by outflank-mailman (input) for mailman id 265643;
 Fri, 04 Feb 2022 14:25:56 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1gJ0=ST=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nFzXA-0002wv-0q
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 14:25:56 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5c728625-85c6-11ec-8f75-fffcc8bd4f1a;
 Fri, 04 Feb 2022 15:25:54 +0100 (CET)
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur03lp2053.outbound.protection.outlook.com [104.47.9.53]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-4-OoMTu6F8N0ym8v04yEzRMg-1; Fri, 04 Feb 2022 15:25:53 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DBAPR04MB7334.eurprd04.prod.outlook.com (2603:10a6:10:1aa::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Fri, 4 Feb
 2022 14:25:46 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.014; Fri, 4 Feb 2022
 14:25:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5c728625-85c6-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1643984754;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=ge2ppEOwPJftV5u4q7KZ5wUkkrkBrNaJNszKBa6VVnE=;
	b=mLYWZFhyZRjevWOCUvFqFPw021yVj4FIbMOalfKJiUaTUmeQfZtr0WAprF8J5tL4TfDJUc
	H0zWYu/1o5FkWk66oEKxI/Tqb1T0fs6ISLEyzJqvGPz3L0VA03gk/Uou813DW68F0ORLi3
	mptD5acsM3v+9+4e6Jm4yznssWvlnNU=
X-MC-Unique: OoMTu6F8N0ym8v04yEzRMg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gwg2Nbv240ENxwcVGP+NAUsrkqWN8JJW51aBX7cNOL+4OZznmsnOaNNfrTc9c+WrXhdmSavAiCkgbUGJsucA/f2OHntpqnLlI2C025XL0vZ6L3Zmq2qSH2ahvd44g2y8nb+VIq5Sj6H4VdyFNI7zvWocbPRYzqcM5K6uWNyH/8CC39lWsFZ7esdr3EyiyQZDufpdbfe6g8Xar8f7R5FZ4OkUmD0w0SH6n4xptsHdW4FqSHKMy96ZPT07qM0cuGSl1LX87hSGDPqa+W0Fj+cphhPldeXTQXqwrkUu5wM9YloGMY7m1phyW5wO/AHAseDy5iMafh8rTZxNfjJ1AxWROQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ge2ppEOwPJftV5u4q7KZ5wUkkrkBrNaJNszKBa6VVnE=;
 b=Bw23Tce9Vb3yMGO8UuhOzzhcdjYfJ3TUCZknixsZarpHur4wtgnxu7lWHGvC7tuHIYMdC69ZBOzpoqdAzjk7EQ/lycHMGUyEkpHtPnl2qKayAu6/ngCa6oLXnmumzvycn8b9on7GtX6ogN0ZlMrt9uq1FXpsipLfjjroeo/j7emDzhJrVUpRDzxZ2euJnRXfU7hmbNR9MGL5enwWng1Z96+H1uFxC5XaiKLo5/MF9pGLCNg2oQQbvPUqK/txxlPLnmdDItxL1BwIE6SINfMHT4cvGd3rPu8UgsQkgotj9BoQVbvHS8N7cI+WUpGRZPI+71T4m3Ya4zQ6hBwhs2+ZVw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <7df2379e-1c30-c362-3106-c7ef23af5c73@suse.com>
Date: Fri, 4 Feb 2022 15:25:44 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v6 09/13] vpci/header: emulate PCI_COMMAND register for
 guests
Content-Language: en-US
To: Oleksandr Andrushchenko <andr2000@gmail.com>
Cc: julien@xen.org, sstabellini@kernel.org, oleksandr_tyshchenko@epam.com,
 volodymyr_babchuk@epam.com, artem_mygaiev@epam.com, roger.pau@citrix.com,
 andrew.cooper3@citrix.com, george.dunlap@citrix.com, paul@xen.org,
 bertrand.marquis@arm.com, rahul.singh@arm.com,
 Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>,
 xen-devel@lists.xenproject.org
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-10-andr2000@gmail.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220204063459.680961-10-andr2000@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR08CA0040.eurprd08.prod.outlook.com
 (2603:10a6:20b:c0::28) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7168e303-af33-4bf0-7492-08d9e7ea3c1e
X-MS-TrafficTypeDiagnostic: DBAPR04MB7334:EE_
X-Microsoft-Antispam-PRVS:
	<DBAPR04MB73347B6C6D26B14AB5A0C3CDB3299@DBAPR04MB7334.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7219;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	EIpiFdASnMdChQFGZ6F1qpaL2EpumaZC1fKiuqKTGJv5MihHKOi0vlR1HYZwblmN1n39yUdVgajvD0xr8ODPiTauUbgWmzAIfFX0zpheBuW2DGMqMPuMgC7+R5COzTV4rmztTN3sDPpi2+GeF9ImIU/GihC8EWGDVxX1yHinZ95G0h+HPnhSviHn239Jga70UsDwtGiLpav6PV3zcCRSQzOEDUz0jfwFsYGXDKsPTcjdiibhPsPM00jxXb+nJoAH3/gYE2fy9GDKlk3CXc5S8KhbZJvMYq3tDek9MWug3TE5YIWtAiFW5XMzZB01BM0VZ6HIYvLmvG31HxeiXbMo2sJBS8meTVVF1D7qEmu8FxR9ELF8biHBtMiSXRNW+RIc659K+JEqlbJOeBjeHoTX7UEnHsJ8G9LItCG7aaoCPVh2ID75o3CGZQfG6pA0l/Lb+SSizTAPwGai+6geJ4BV5afxfgcZLewi1CQdsxR87bzkklKCLlPyEIEiuMTuoIVlt4h3OA24cb2CxY/YSKZ91hBnwhBmVoWMyygj8iLqhx990V2H0HQmGcjwkErQbk4K7hUcVWdOgdYoYdbE3bAUAuCdHj4qmji+d3QZMLLTLNAW3z0RmcYA0Pc1RWXj+wh8dDod7La2J4e7zFVA1jklg3rhQHyUIL12qAv09aaLQCdiLIqyFAHgavI8WumcPOUc0Pgu10H9PuTFgbDzyC5k2/1TIq3SRbW4YUmrSh6VpKc=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(316002)(4326008)(5660300002)(36756003)(6916009)(83380400001)(31686004)(508600001)(66946007)(38100700002)(7416002)(186003)(66476007)(66556008)(8676002)(86362001)(31696002)(6512007)(6506007)(53546011)(2906002)(6486002)(2616005)(26005)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RUFtT2FLdk94QmRQZVRzU1NLNExkYWkrQ0hmTUFBc29hSzhsTWxXU1JLcGZ4?=
 =?utf-8?B?eXRwRDRMdVlEa3l5SVdiczJnODdKSHlndC85L0U5ekxtYXdDYUthTjZPUDcy?=
 =?utf-8?B?UlJrTDdVU0Z1Y1QwUVlCMEtCQmhuUjk2TDhiNTd2b3JHM2VWYmlaREFiOFNR?=
 =?utf-8?B?RkJleGpUbWU1c2QzNktpbnJPOGczWklYZ3RFNzIwazI2TkFWQTRKcS80V3NQ?=
 =?utf-8?B?dDlPa2QrVStrZnVzaG5LdFVYUXo2SU1NWlFnZE5NQ1dnOXJXRmJjZU4xYkRK?=
 =?utf-8?B?MERubHc1OEVyMTdRa2IrYk1IdkVKaHFZUDFGV0hEK2J2T3JlTkhodXQrYmlh?=
 =?utf-8?B?cW5tajZubFFYeHNHdTYxNmtGblA0aXpmRGZyelk0VmhwRmU0WVBUM2hQTUJI?=
 =?utf-8?B?TTFZT040SFFQd2dKZWdWK09odVZqajlXMEc1b1RHYllLK2pkZTRlTEx4TGUy?=
 =?utf-8?B?Nnh5b2JvVlA0Wllza0FwNkI0ait1WUI1Uzd1RWt2RGFvb0hITFArWkE0a0Zr?=
 =?utf-8?B?bWZvZzFJT3hsQzdtaGUwUjNHUkJTWTlkbzBTeEZiUjVtVFF3Q1BxdG9KdnMy?=
 =?utf-8?B?Q3czMGtpVGhWL0t4K1B4UHlrcHFoNGFpMlRHelJKdlNvVjBwaUwzTDgzcGp3?=
 =?utf-8?B?czNTVlVTRURXb0pPU1dPVndMdUhWVThMU2JoUTVlTS9wbURsSGhsRVAzMGtk?=
 =?utf-8?B?ZFpkMXNybjVGbUFodW8vdUcwbStNQXQ4WWJKK0JaVVcvaWdNa01sYTNUc2FF?=
 =?utf-8?B?QUU5alg3ZHQ3Ym5CS09ibTVWS1ZhNjZIOFlIbGtVSitOYlRtSmNleVlIVmhM?=
 =?utf-8?B?SGYxWnRyUlkwNGgrQWErN3hKbE40eGtEb1RuS1FIYmd0ckRyME5lUmVCN3FK?=
 =?utf-8?B?Y1BLNklTVnJ2TVZ2U2VDY3pEemp4aUdjdFJhc2x4VUtjU1hCUm1FMjdvTkx0?=
 =?utf-8?B?Z20wU29GSHNWUGJnaUhkUjFxT3E0cmhvRHdER2ViOWYxT0M5VnllUE5NSU9B?=
 =?utf-8?B?VXBwazZDeSthSFRES1JpNnhEck9QNWduU0JkTlhPcHRCbjUxdjRlbTVYZUl3?=
 =?utf-8?B?MytGWXgvQ1B4UWFKMDRCcUhpVVNlcjkxTldUdlhEaFdHZlFRVzROdWRFQ2Nu?=
 =?utf-8?B?M1BzREhYeTA4ZmdMNVE2dVUxOENES0lkend0ZGJQbExwTWphVmN1RDZOello?=
 =?utf-8?B?bVY3OXFmTW5KSVd5aTVFOWw2QmUvRVVjNHFVVHNaZ0hRN21BUXFydzFWcks5?=
 =?utf-8?B?Z3RyODdWTzR6aUJmTjBLSmdFZ2hBVjVYdlhZZnVsU0FkaXF4aGZ5WEdFRmY0?=
 =?utf-8?B?VmxZbkV5aDVVRFNOMEpzNCtZWGJCVlBhU3BFT0lRajFIRkI1NzNVQThOQjdo?=
 =?utf-8?B?dmczdlRxWkhvRExZNytWZ0FrSTJoSFFHSGpkUTlqdGk4NC81U0w5bFQ3WWRq?=
 =?utf-8?B?VUwxdFVuaFc1MXo5ODlZVFVIMFdiLzBBTDhWNWxSUkF2WWNnWm1DbVpCVnJx?=
 =?utf-8?B?Y3lmSGdCdWxJbU1yaXI0dlJ4dVFQOE9yRUhsOVByRkl1aSszUXg0Szk1VUQ1?=
 =?utf-8?B?VGMxK1JDeFkwTE1tekxHUzZRSG9pZUZXc3hxM1o0Yy9mc25CL3ZleFc1OVcy?=
 =?utf-8?B?c2ZLa1ZuSWFsMGVid3dTSmlPb3QxR1BFNkNLbzJXdnFIbFBMTkczTzBML3Rj?=
 =?utf-8?B?V0piS1FJcDVGZ1F2bC9xTmNJWlFCMW5jWHc1bTlxMmhpSkp5UG9TaENKOHlS?=
 =?utf-8?B?NVlxQTlXNlBZNnoyU2xCQkY4Q085TkRWd0p4K3RDaEh6eDlIa295VWpRakNv?=
 =?utf-8?B?QWJpdy9NMTAxMzZXVldiZGNod1Y3Sy94UitLMFR5WVhBWTFGVmVMdS9EUXI4?=
 =?utf-8?B?WFVsa3dmSUZEbWlnQWx5R2VSMnROTktKbTNsY3VMV1BncVVkZHVRb25pYllO?=
 =?utf-8?B?aFB4U3JscFg1MGErNnRad2xlc2cvVExqOXMzRVhOOGprVVJtZ0xTN2RlU1Aw?=
 =?utf-8?B?UndYUUdZaCticC9EL1dhVkR6UVZ3WjR0QmZ5OCs4Vmh2WUY3Znhkd3J6ZklE?=
 =?utf-8?B?dUphY0NOSXRocExVNWUxQjJ3K1lOUnEwNkt6cEhWVjNqWk00NGltT1RhR2xR?=
 =?utf-8?B?K1lMQlRXMS8xajFxZk9yVTB0WHpxUTF0YUdnZDlmZFdsRHBqUzd1bDZUcjRP?=
 =?utf-8?Q?E5ifeDOQSN05CU7ZI0Jclmc=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7168e303-af33-4bf0-7492-08d9e7ea3c1e
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Feb 2022 14:25:46.7721
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NctcU29Gz05xPQZQjUGNWJazIq7QPdXFLB8t5WdurdSH3OowamBl+3W4Z08AfeNvrs7AIYnCl6JQl1d5POF3sQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7334

On 04.02.2022 07:34, Oleksandr Andrushchenko wrote:
> --- a/xen/drivers/vpci/header.c
> +++ b/xen/drivers/vpci/header.c
> @@ -454,6 +454,22 @@ static void cmd_write(const struct pci_dev *pdev, unsigned int reg,
>          pci_conf_write16(pdev->sbdf, reg, cmd);
>  }
>  
> +static void guest_cmd_write(const struct pci_dev *pdev, unsigned int reg,
> +                            uint32_t cmd, void *data)
> +{
> +    /* TODO: Add proper emulation for all bits of the command register. */
> +
> +#ifdef CONFIG_HAS_PCI_MSI
> +    if ( pdev->vpci->msi->enabled || pdev->vpci->msix->enabled )
> +    {
> +        /* Guest wants to enable INTx. It can't be enabled if MSI/MSI-X enabled. */
> +        cmd |= PCI_COMMAND_INTX_DISABLE;
> +    }
> +#endif
> +
> +    cmd_write(pdev, reg, cmd, data);
> +}

It's not really clear to me whether the TODO warrants this being a
separate function. Personally I'd find it preferable if the logic
was folded into cmd_write().

With this and ...

> --- a/xen/drivers/vpci/msi.c
> +++ b/xen/drivers/vpci/msi.c
> @@ -70,6 +70,10 @@ static void control_write(const struct pci_dev *pdev, unsigned int reg,
>  
>          if ( vpci_msi_arch_enable(msi, pdev, vectors) )
>              return;
> +
> +        /* Make sure guest doesn't enable INTx while enabling MSI. */
> +        if ( !is_hardware_domain(pdev->domain) )
> +            pci_intx(pdev, false);
>      }
>      else
>          vpci_msi_arch_disable(msi, pdev);
> --- a/xen/drivers/vpci/msix.c
> +++ b/xen/drivers/vpci/msix.c
> @@ -92,6 +92,10 @@ static void control_write(const struct pci_dev *pdev, unsigned int reg,
>          for ( i = 0; i < msix->max_entries; i++ )
>              if ( !msix->entries[i].masked && msix->entries[i].updated )
>                  update_entry(&msix->entries[i], pdev, i);
> +
> +        /* Make sure guest doesn't enable INTx while enabling MSI-X. */
> +        if ( !is_hardware_domain(pdev->domain) )
> +            pci_intx(pdev, false);
>      }
>      else if ( !new_enabled && msix->enabled )
>      {

... this done (as requested) behind the back of the guest, what's the
idea wrt the guest reading the command register? That continues to be
wired to vpci_hw_read16() (and hence accesses the underlying hardware
value irrespective of what patch 4 did).

Jan



From xen-devel-bounces@lists.xenproject.org Fri Feb 04 14:30:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 14:30:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265652.459072 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFzbc-0004PI-D5; Fri, 04 Feb 2022 14:30:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265652.459072; Fri, 04 Feb 2022 14:30:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFzbc-0004PB-A7; Fri, 04 Feb 2022 14:30:32 +0000
Received: by outflank-mailman (input) for mailman id 265652;
 Fri, 04 Feb 2022 14:30:30 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1gJ0=ST=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nFzba-0004P4-Qc
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 14:30:30 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0023f67f-85c7-11ec-8eb8-a37418f5ba1a;
 Fri, 04 Feb 2022 15:30:29 +0100 (CET)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2057.outbound.protection.outlook.com [104.47.6.57]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-29-qhuhbnovOBebuRkkjrmUJg-1; Fri, 04 Feb 2022 15:30:26 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM9PR04MB8795.eurprd04.prod.outlook.com (2603:10a6:20b:40a::24)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.16; Fri, 4 Feb
 2022 14:30:25 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.014; Fri, 4 Feb 2022
 14:30:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0023f67f-85c7-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1643985028;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=p2MPSfIlWYqNOO3lvdFtlIz3pwCH/v7OkqRhPjHv7Y8=;
	b=PJ8Qchf1MVwF1EyHSWYcCSGh5z+2SIW1BIQjXYvLouTRJtoiEGXpe3HBicYLtCgauIiKP0
	IF4x4ttOMYVJpIKkajBb08idLsZljL7EgTgGvas49OdGQGMZ41QdZegcBqgXvbMWNDXipz
	xhr4oUY311zWa/L1t8Y3msqx44k+ynQ=
X-MC-Unique: qhuhbnovOBebuRkkjrmUJg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Myb2qmP25wl19U2ZSkbUtuw7+WFycIiDjYNspu8R7p7SMMc44LqHzERGeUKCWjr+8FJrT13FHZdMyXEOXM0Zawt7z2hkdsNCjTKeD+vTGwBh0FY/tHnkgrZMnYFGLLniGikbUji+S/7YoK+TtvFm5BD0y4zuJh72Vor697KTZrsfzhRcRnvrgeI7ZYWBvmXBKb9lwFkldyV7fVsc15Vl9d3cC4UretL2I18LuLaOXVd0hdJmyfS5q29VWRXolJcSHtSKUJV6Td7uaATT4ZALnH7cnRcJZ0VQmMEnDIQZoGzvlYp2z+RncUpQs89Sf3bEU2NcFDsR4nCLtKpeH3dQbg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=p2MPSfIlWYqNOO3lvdFtlIz3pwCH/v7OkqRhPjHv7Y8=;
 b=He5w4tm1nhOAJD/jdMINI8XoJqpRTOyTpbEPYR23wLwjktZN16KOpbTJWKIZaAmmDdFQhviiIM/vVpD7SEcmfpCnBWnKIRvFA78Pw7M1Byop7R6LdDupZV8FlAMH+wTzH/ntuLj6Y1fQCvtPl3hf+kCnT9Flk6oIr1vhZjD9MpsgzC5tTVt5lfWG7kRgEFUEqycdKCRi5loIvEFFCVh5OMnS764MDyhJajLqraqoFRScY1IBIISrwR9wDInTdA+bi4ItNwSZOArnuwjCSH1rrf0fVgeEXJ18bg39KbPZQUp5M9MszRYzgj9kHnhXOT2SGM80ybIPE9cV2AgD2kQung==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <96381d7e-dafc-acee-3abf-f9815deb207c@suse.com>
Date: Fri, 4 Feb 2022 15:30:22 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v6 10/13] vpci/header: reset the command register when
 adding devices
Content-Language: en-US
To: Oleksandr Andrushchenko <andr2000@gmail.com>
Cc: julien@xen.org, sstabellini@kernel.org, oleksandr_tyshchenko@epam.com,
 volodymyr_babchuk@epam.com, artem_mygaiev@epam.com, roger.pau@citrix.com,
 andrew.cooper3@citrix.com, george.dunlap@citrix.com, paul@xen.org,
 bertrand.marquis@arm.com, rahul.singh@arm.com,
 Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>,
 xen-devel@lists.xenproject.org
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-11-andr2000@gmail.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220204063459.680961-11-andr2000@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P195CA0013.EURP195.PROD.OUTLOOK.COM
 (2603:10a6:209:81::26) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d35840c6-6bab-4202-f13f-08d9e7eae1df
X-MS-TrafficTypeDiagnostic: AM9PR04MB8795:EE_
X-Microsoft-Antispam-PRVS:
	<AM9PR04MB8795A2931E3F95E14FC8209BB3299@AM9PR04MB8795.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6108;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	+zehtaGSRfYEwAfzkfqohed6jquI9RuRNVQmDYkbDkKP5q3TJtNLxSQtXQkQNweussWoENClHxbd4tCBjLUc5wGfvKiNJN+a6Zk0v3rnvOy+ly846RUjWq1DIyGmiB0EWIYA/jCdZ6P03XfqEOZVP2+reOAca7pirhsjkv8VYH/zZF7LNb7wesK59NywDHF5QH4W3nRImuy8HxLSWI0LU59XkpXssHLBDBDeMxGyDVQxCi/kW16Yk8ApHa04dsleZyW+eGoqFGY/WXe2/4hcHol/UE0VNwjz0lwYl9YLmd7pDf6jZEk0KtW3teXpL4xYjdeXVdgVMjNrJZZ9HBxfan1TCpmLor3wxauxn8Ip/KjD8Tn5uEvWgc7BiGpd/LSMSwZMjbXhHc08HbuZu0YglbvAKUiQUW3OQiWpWn9UCHuC64MwzD1BF2bZN0q3JxOWSLieObQNdW9ny6tbJcZ60cr083q4IDc0JtH75BpIdAkena1km+aP1jp5r/H4XcoBTAns+LGnDGmG9jUk0UHJDF3rqkRfFN9tLCrZf0atvbekJzGWlCnvL1N5dgTHKCwVIdslLkl6Upv1c/UAJ9xpeE+HLTCPoL3aiRPu8TdTuActIJp3SZJKDhjtWyRUfEyEt+6GjShIHd4cSgkuSGHonXSHhGltzm3PeBRbUjdJgGUOhLtOpHU8q7Lpf+0c3JLFeb4nyC8fAukyT4LwyYJj+b6egOGD2+3HSn1WnwceNoY=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(38100700002)(2906002)(4744005)(508600001)(36756003)(31686004)(8936002)(8676002)(31696002)(86362001)(53546011)(6486002)(6506007)(6512007)(6666004)(4326008)(316002)(6916009)(66946007)(2616005)(26005)(186003)(66556008)(83380400001)(66476007)(5660300002)(7416002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?REhyMWlYcng3c3Q4MnVlM21hZlI1d1FuWHRoNHdlTTdIR0trajN3UjhtdXBF?=
 =?utf-8?B?anZ2c0lrcEN5YXAzbDVaaWVoZ3BVb3o3K2RlYjQ4akljSHlxUFJvaS9qMXNY?=
 =?utf-8?B?Tzd0ZlczdzBvWk5KZStkcmtOOUFOd0EzWHAyOE5jbkxSVFlDVEpiQWVqRGx5?=
 =?utf-8?B?Qys1RFJUcStlOG53TUNjR1RyTUREcXdpMVFzeERESVc5amRRRDRobVJlYTlN?=
 =?utf-8?B?RVRPVERRVVZwRXdTOWhkY3FoZVA0RWdMV1V5dmQ1MHBobTdpby9DYUNEbVJt?=
 =?utf-8?B?bmZYMjNKSVhMOCtWWStPbWNkK3pqUjFyNTRxYkxOcVlSczcxZGRwSHZuOHhp?=
 =?utf-8?B?c1BmVTJSK0NtaDVQc0RZVUFPcHhLd3A3Y2NVNFA4OE85QU9SVktrenhUV3g1?=
 =?utf-8?B?bjVzTmFpdVorc3FEeE5vL3MvSkNHYjZ2QWxlZ2JhcnExOXRJRHZielh3eXUr?=
 =?utf-8?B?YXdQRkl2VVgzNUgwcjFqOWpLYUZQMUorTHgwTmRsZG9RR1NMaDBja2I5ajh4?=
 =?utf-8?B?SW5CcjJkT2M5ZTNQZUhNcThJOTU3S3BVeFJkMENHVkZadWt5M3JyWVRiOXJR?=
 =?utf-8?B?eXl6U2pyKytvNGRMZSszd05LOGtYU0FEMStiaTB5bE9FeHFwc043bndVWU1n?=
 =?utf-8?B?ZHJBOEhUTzZBbWFldXpHNU5Vb0Y0M2pSbks1VlRwcmpMOEFMZUo3QXNDZlNE?=
 =?utf-8?B?c2Vkdm5obUFwU3VBaGdwZllMUDVOUmYyclBUZTFJNGhYMjh6WFBYVDRkQmZh?=
 =?utf-8?B?d0xaR2FwTWVFRGRQS0pGRjcxQkwycGpiMjVzbzdqaEwvZUhTTjUwTmZkR1J4?=
 =?utf-8?B?VmdhbzBUV0srYUE5NnVqbDJWeHhRU3JURlF6TGVDUWhYOGdWcHlsRFQ2d1U3?=
 =?utf-8?B?emRrTHFPbm01TEtVY3VFRlhyT2hQRmowL2QwRmZRRFlhMDVFbWlRbW5jdThx?=
 =?utf-8?B?OVkzYzJFRU0vZGxYK0pZYW9zeldiSWJsS0UwUlZxRHN6RitxNGlZZDFKelM3?=
 =?utf-8?B?ek9jOXFqNjN4RGtzVjRwdjV5SFdhck8vZ1IxdVFQNEduTWRFdlVMNS84ZEYx?=
 =?utf-8?B?Rm94YVJJd0JNcU1Pc21kTHlyQXZwaWg5a1lqbHR5Zlh3d004ZHptRWQzVVZ5?=
 =?utf-8?B?RVJYQTZCKzFqWVRKVWlKdlVQOWJzelBIT0dMQUJOcWZJQm5vVHRBMXZDOG5m?=
 =?utf-8?B?cnRGKzZyZWhOZ3JFcW5VdXNXVytjamVuL2FiYjl0b0dhbGhLdU1FbmY2QXRU?=
 =?utf-8?B?NHdDMkwvUjdMVWRhU2p3OTljSGFtUU5aUmwzcDA2RTY4YTRSVmFhancrMXlR?=
 =?utf-8?B?V0YyNVRiM25ZaEY3OGlhaG5HQW1PM1h4VXZ5OHgvRDJwd1JJOWdOY2k3U2lx?=
 =?utf-8?B?dzFJRzZTdnFrTittMHo1SFozRFlrbTk3bTJheXRxNGV5WFQwQ0lJSVprM2o2?=
 =?utf-8?B?R0dEVy9hRWNGQmpiRGVRenF1eWFHT1NRcDJjcnRRd0xXTEpCWjNCUHlzZmR3?=
 =?utf-8?B?U3hKbDROSFVuSXR2THlLNUZYSFlFdXdZSTh4dm5xUWNRTythQ2Juc1BNbFNX?=
 =?utf-8?B?UDJDcU14d2MraW01c3ZuQkFBaGNldS9wS2pMSkNjb3VkbjIxb1hPVTJvT1NY?=
 =?utf-8?B?NHFKK1ZEN3ZuNXluWEcwNm9kN2F2VVkwMG4xSTYxY2dHRERTQkZUd2FMeHdI?=
 =?utf-8?B?QmsxOFJnM0FWRGcxK0R2TFFPWWk2T2UweEtpd3JKMzJ0VVJ6Rys2YnFpSWNQ?=
 =?utf-8?B?K1RoelNqdVplVzJET29aUVRhV1NTdm5SaGZhVk1aMTZsMmdXamtQbHdEQzR6?=
 =?utf-8?B?Q3d3MHVpaDlJcU05bmhOQldhdWZCeDgxamMzZjZUbElaR0ZzN0Nycm11K1BZ?=
 =?utf-8?B?bDMrc1pheHVtdlZNOGk5ODFUdjFGcFAxZTBHRURGOEQxeGdraUxiOWRCZWh1?=
 =?utf-8?B?eDF6UVA2YU85UGd3RDdRSHN3Y0VjYWFFSVNWbGtyRjU0VFUvMUVzYTJYWlJS?=
 =?utf-8?B?UmhYajBaOE9PNW9xWFg1RnhkM2hCek9FUmRRQ0svWFkyWHlZeDhWRWJPdi9Z?=
 =?utf-8?B?QjNjQ3Bpd05UM0YyTi9xb05GdUMvbTFkUkJvODBJYkk4WnpqRFlmMXVWQU1i?=
 =?utf-8?B?YzZ5eXRkT3ZzK3lWKzRsQjFxbFMzbXF6Q1E4K3V3eXVuSmUwRXlvR0YvQWQr?=
 =?utf-8?Q?Ha/jk43FyZkI/dNiN6OXuUM=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d35840c6-6bab-4202-f13f-08d9e7eae1df
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Feb 2022 14:30:24.9111
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +6IYRYUXt7DcqKiz3WX/iKWbCVIZa8t/dlSzXhD4l3+aJHY/H0s6Kw/7dq0u7JjyNRH4WGnfExJapbq8Fgybdg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8795

On 04.02.2022 07:34, Oleksandr Andrushchenko wrote:
> Reset the command register when assigning a PCI device to a guest:
> according to the PCI spec the PCI_COMMAND register is typically all 0's
> after reset.

It's not entirely clear to me whether setting the hardware register to
zero is okay. What wants to be zero is the value the guest observes
initially.

> --- a/xen/drivers/vpci/header.c
> +++ b/xen/drivers/vpci/header.c
> @@ -454,8 +454,7 @@ static void cmd_write(const struct pci_dev *pdev, unsigned int reg,
>          pci_conf_write16(pdev->sbdf, reg, cmd);
>  }
>  
> -static void guest_cmd_write(const struct pci_dev *pdev, unsigned int reg,
> -                            uint32_t cmd, void *data)
> +static uint32_t emulate_cmd_reg(const struct pci_dev *pdev, uint32_t cmd)

The command register is a 16-bit one, so parameter and return type should
either be plain unsigned int (preferred, see ./CODING_STYLE) or uint16_t
imo.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Feb 04 14:37:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 14:37:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265661.459083 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFziK-0005Cq-8l; Fri, 04 Feb 2022 14:37:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265661.459083; Fri, 04 Feb 2022 14:37:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFziK-0005Cj-5X; Fri, 04 Feb 2022 14:37:28 +0000
Received: by outflank-mailman (input) for mailman id 265661;
 Fri, 04 Feb 2022 14:37:27 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=u+82=ST=epam.com=prvs=4034f0a382=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nFziJ-0005Cd-Jr
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 14:37:27 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f7c5fcad-85c7-11ec-8f75-fffcc8bd4f1a;
 Fri, 04 Feb 2022 15:37:25 +0100 (CET)
Received: from pps.filterd (m0174676.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 214EOI1c024817;
 Fri, 4 Feb 2022 14:37:23 GMT
Received: from eur05-vi1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2168.outbound.protection.outlook.com [104.47.17.168])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e15va81y2-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 04 Feb 2022 14:37:22 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM9PR03MB6996.eurprd03.prod.outlook.com (2603:10a6:20b:2da::7)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.14; Fri, 4 Feb
 2022 14:37:15 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6%3]) with mapi id 15.20.4951.014; Fri, 4 Feb 2022
 14:37:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f7c5fcad-85c7-11ec-8f75-fffcc8bd4f1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Bn0sB43IEpZzbkGpRf4lRal/TYMRrUUUkwQiyfKAF4530hi3B6iNXbts5xZa5bT89NoSqMUkPB1rGIkuU9R3HeHPuPPN+t57BLe8aEa6iaAKubYleGYQxx++lDjs5W+J6RKzoNo9NBN6gdYFpf77Ivi4yg6Z3JW7idNGGUarDnf4NdN5vfRIoUCFsfrN6+kXBxHRvxdgLhPkchvAh9HR9z1V05IULapHfUmZJHYh4qPWGsWYCAHLqj1gvL6qr+USkH67gXHYUqysWd8awXTq9Yo7GTkR7P/c88Pf47ygblyyAZe/y6CnYFfcUVV+ABi8Ou6EaeDJP9ZBJybADDiC+w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=GnR7WvusOa8NAdWCqsvd5ZNFf15QvGL54Y7S0D9pVe8=;
 b=C8xKvJQ/MrDBD67bptoxSGPgH1bGN8LWtciX4Ojhax3oFHcb2kp22003nhRe//GdpkGZdtt3Bp6ubo3R8OJUnPU+/rA8SZ+DBUR/tM4QId4RvKrpETnut3R6INswRH/oUAzbA8ImrB7eimW3IoM/CSq2+iRbboZRpaJ088Dwa8PIEIArUdxklc+ZIcRyAPTuZdcL5phfLx7S8K/QogxF0tvva0xZVXTMxYm3pMj6x04N6bQDRGuTLqvAyWF8DDWv36CNMZIp7dHZxSp5Ue9gKeOX/aZOhf7jUKEr/+15wBAHs6eAjMJtoLzAjoXaVzoBDpUy3xB/WPQ71lGfqF2WwQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=GnR7WvusOa8NAdWCqsvd5ZNFf15QvGL54Y7S0D9pVe8=;
 b=LaJbnzpRVftc68n0aXptJJFR7LRla1S3lpzbNOarQZR4lPrOLGQg64KTmjqwA7IkZzagQ4TP6qEbqApSHwRVNqLj7fBVXKXI8eOWAVqw2U1eyhaBs6wTmVp9t6EsT4OcbFsSRHEdFp2VTMh5MPkIQlnonvbAKlnjKIZSymMSn2UXkoo9FV0yT0pxzEtKoF58acamW1frkeQD/EujeqHZWX4Ygv8oEPUi2qmp4BFk4UTS0cAGJ07Ok8IAISPFkOeJrzaFrJ7CSuqKv9lr7oBYlyqeFEffMPq+Dv84Dvo/jF7tAlSS+kzsp5U/Cs6PLIQ532DSQ6rOvcc8+cVNqG/sMA==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "roger.pau@citrix.com" <roger.pau@citrix.com>,
        "andrew.cooper3@citrix.com"
	<andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com"
	<george.dunlap@citrix.com>,
        "paul@xen.org" <paul@xen.org>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>,
        Rahul Singh <rahul.singh@arm.com>,
        "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        Oleksandr
 Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v6 10/13] vpci/header: reset the command register when
 adding devices
Thread-Topic: [PATCH v6 10/13] vpci/header: reset the command register when
 adding devices
Thread-Index: AQHYGZFg3nazYSvfA0G+yHTbxcxX2ayDdFgAgAAB6wA=
Date: Fri, 4 Feb 2022 14:37:15 +0000
Message-ID: <ef76faac-f9d3-1cb8-06b5-189ccd299542@epam.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-11-andr2000@gmail.com>
 <96381d7e-dafc-acee-3abf-f9815deb207c@suse.com>
In-Reply-To: <96381d7e-dafc-acee-3abf-f9815deb207c@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: ce362a6a-e7d1-48f9-22e5-08d9e7ebd6ad
x-ms-traffictypediagnostic: AM9PR03MB6996:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM9PR03MB69968072D27ECCD10883D439E7299@AM9PR03MB6996.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:6790;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 6Tob70LnFD5yt5UQMV/sJd1tH+PIHMLC1ts9yxivEb7SgZR0FjPJBMQrRZLcL3J2c6pcVWTxWU19EiM/er6w0lTaZE5byUQcs9887ak6xv5EIqInC0mq07zBXlA2g9NSedsQ6fgWvT/LZYnDnbiTRWp767x6pWeTwVFipT6Al69sxQJsuMaBdWhPyPN1H0II1UYMQoHJ6F0they1saIxkq4iMdQiTsRYc+eQi+Sa79x6ibPdqKbaJ92qdg060PXFQYp0lBdXx1+WWBfbYyNTCAXVX7Giyqy/ym/iQyTjkHD0rlO28kqOD7Z1Vug7VJk4GVwsnvh83KPYRkKHLTunkgxtmBdv5xIOxbUb8qkV0LnPXmeYgL3nsDTFEvkPWxSPaPwhQUVKGFWjsxMKVAuzQ4LI3wRNMGZ/dG4BCKGhI4BSUgk4ZXIlIDCWnV+LjJS2VCOTd2yx3P5//4QEMKgqMFGMD5f1W887SzLSxXifuT/U7ISxjT+ZMJGJ56ns9nYAlgh9DKf9ylJ9td0NDF6vRZkfnI7xC1UqY1FpT7hZCqhMknf4Y+uoiE955snFe18BItTTMu87NZc/ESbVErVW/2gDUBzi4STNW70BRK0nIZqJM1f6B8U3kJSWP9+87ge9+NetvavDp9IMZk1N+bpfZsGIUHJOoMizFSbCFmtj2/LECNoLoRR9fi8GvFIGFaZ1OddzU37JwI1M6cuWlsdHgIPrkwXN/z7AksUQJZOlifuY8uN+bJN8SSNb06ZIXjPa
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(508600001)(2616005)(66556008)(71200400001)(6512007)(31696002)(6486002)(8936002)(2906002)(86362001)(26005)(186003)(6506007)(53546011)(107886003)(64756008)(66476007)(66446008)(36756003)(6916009)(4326008)(8676002)(38070700005)(5660300002)(7416002)(38100700002)(76116006)(66946007)(316002)(122000001)(31686004)(83380400001)(54906003)(91956017)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?WVVzeWNCMnVFYktGR2Zya09NN3YxUjJPZ0Exb0RkQ3ozN1lIMlV6SStMMjIw?=
 =?utf-8?B?bE5rZTlWUTFFbTVrclRYV0FGSkVJL1NwamJwQys0M2FiR0hPekRNcjVNVGRN?=
 =?utf-8?B?YXpQOW9RRnRNY3M1TWhrZ0lFaU9XU3ZnL2k5bHJrdW9OMkpvL0YzSUxPNGdv?=
 =?utf-8?B?aWZHTmZTUGp5UlZ2aTlqMndOUGc5aGRDT0Z6Z0RUV0pHRHk0VHloYnhLbVdY?=
 =?utf-8?B?bUh1WlJoYUxMa0YyWnRhNEx5TVZhZVR0TFdhQ2xteWh1ME9LcExCMm5KTVM2?=
 =?utf-8?B?MzY1Q0FTcjQybVhacFdyUytDYmJTL3RaQ2NzSTQyUmdKVmtZOFg5S0JrVXE3?=
 =?utf-8?B?TWRjcUxydmp1NlJ6NDNrNzhBK3F4YnRjbmRuZG1MNzg4eExISmNzRFNma0Zs?=
 =?utf-8?B?RUZpaUh2NTExSTc3RTZUK0F6OHk1YlQvMEE0MjJXREJDcTh5U1lReDVGMVF0?=
 =?utf-8?B?UnRQSjZ4N1lMaWswQWxCaEVKRGRjK1p6QlkwdVVJb2FHSWtnQkp4T0ovRDdQ?=
 =?utf-8?B?M1Nzc2JKZWQyUlBxWFpyaTVRdlBlTCtlek8xd0FuSzQ3Y0Z2eHhWYnhTdlRZ?=
 =?utf-8?B?bGtIYXVGQzNwMy9oWmxrZU1XV2EzZFgveGZ6ZVJOOXU1SnQzYkxGMVNrallW?=
 =?utf-8?B?bk5PYlR6Tld5WFNxWTJDYjFKWVFKODlPNUVSVWpkL3NYWFVJYWtldktZbUYr?=
 =?utf-8?B?bkZQRVhSazl2cFNHbUoyZ25PbVcxT1dSeGZiOUY2SmFsTWxSY29EdEw0TlQz?=
 =?utf-8?B?RzJET0huaUFBc1J4bDFNZHRkTVpyM0pRb3lvZUlWMkkySk9SeHIxbjhjWDdN?=
 =?utf-8?B?UVorTHZwK2psdGx2bVZHUFpSd2RqbWF2RWZPcjRQRVZYL2JxSERkbjdEZ0Zv?=
 =?utf-8?B?d2hLdXpnSXcxSnV0MVg1R1hTd2VqbmRFMHZCdjlVOHpldTlpNEZsYUNFNkVM?=
 =?utf-8?B?cWpVTExhckJHb0w4S2hLKzdkQnVzSU1ITzF5dHA4ZWNtNXU0eTBOUE5Gbkpr?=
 =?utf-8?B?Y3VIVlJzR01NYXkxZmdXOVpzZzBrSnpzZmFUOGFqbmxnQ3RTUE5RcisxeDM3?=
 =?utf-8?B?UEMyc0I1ck1XVlhkYlp2T0ljRjNETUNLQ1NuQm96OW9tTm1FSW95b3RJMEg3?=
 =?utf-8?B?cFU5cDF4NkxwVU5oeWR5eWU1cURNYVlVaEQzaklrazFjYnVSYUdOWlZyZVB0?=
 =?utf-8?B?cU1scUpyekZ2bG1ITTMvR2ltd1pWTTh1WUdJV3FxZGlMUzl0T0JKM2hNdkhF?=
 =?utf-8?B?eWR2blpaVDY2a3pwM08vK3grVFNiNHlvZmYya0x5UElpK3VEdThNY0FuSHVZ?=
 =?utf-8?B?YUtOTG95Vm1YMmR2bDZKYVRWSG4wWUpNTmlkemE3cUwzU094ZXhqSDVDUlJG?=
 =?utf-8?B?M3JOL2NsQllXbUxDeFE5bWNXSUswMWwxbzl0QzMwNkRBVEZtanNRWXY4L1pK?=
 =?utf-8?B?MnhLcEtzSVpOK012ak8rUEpiNVgwTHllNFFNcmxvMW4yaDhRYTZWRnpxdUJY?=
 =?utf-8?B?Y2twcG5xN0F5b0Fxa3RLRlpJSnphVjg0WlRzVmF5WUdVOVJDKzd3TXFIQzcr?=
 =?utf-8?B?dEhKU0lSaGhSWXFaR2dRWVFvOEFacG42QlFUR2RkNjlEWFhZK3EyLzZicjdL?=
 =?utf-8?B?NXBBV1l0OUYraEQ1NS9LQVQrUll5RkZYQVZDTmJpYUlOajBRN3lmK0dHakRH?=
 =?utf-8?B?bnhNQ0gzQVZ1SVpyNUczWmtYR2RjTW9oWjdsZkxTSWhsV1dMUlVyL2Q1d1BD?=
 =?utf-8?B?MHdPcHFMc3NJZjA0VFVRUCtZelRaRzduRkhuRVVBSk5sd1p4bXhIOXhVbWZW?=
 =?utf-8?B?RXA5TzYxdFFLWndnMDgxR01CajZVNlFoTkZCTjF3RzlaZ3Q3NFZnNXJFU1JU?=
 =?utf-8?B?bjlrNXFTNndPZEE2WlA1MytsdmtyM1h0L2RKanBkY3lMcTdMK3M2YW5Ld0pn?=
 =?utf-8?B?V3VkUXRQcG1ub20xeHlFSDZZWlBZNUVtUjlEeUhqS1dhOEI2dkZ5Y1hYaGFs?=
 =?utf-8?B?akJhT1djdXczOEREU1YzaTExNUFjTWdXSGdlem5jdjgwdzJPQnpWdDFUT3Ax?=
 =?utf-8?B?VHloUGhPWWllbzhWRkZhNnNCWThYTEdhNGdkUUpQb0hlaGcrTEdCc0MyVkdM?=
 =?utf-8?B?eS8zUFg3UTl2TzVmUStOR0l1SkdLK0kvQWIwNkVFcGZkUFR6cXJuWHVZY2FD?=
 =?utf-8?B?SDcwVFc5ZHJnUTM3U3dBK08yS1NQVkRDMkhlc0tJOUtQU2NYdHUxSStPSXpr?=
 =?utf-8?B?OGJUUzVHVUdWZ25vSm55QVNsbWluMVdSWkgyMEZkSHpPL1dwN0V3Wnk2Z0pE?=
 =?utf-8?B?eFBodlVJUmRybDdpamg0OGRoS2RaVDZoNVBoYndjQURwa2VMa0tHUT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <0CD2D325CBC8B3478FC96AD288F26088@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ce362a6a-e7d1-48f9-22e5-08d9e7ebd6ad
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Feb 2022 14:37:15.3217
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 8ShTghwaMRSep1puLxAMCrS+2WDrjAl3ClyCRDsoM+M8VbgxpomFRwpkCYBj4as2xmcud56CXqooqWkpZ11kDRhzWgexmFtffg7QKXt8twUzC4myudZ9A2kO7QtD4XEb
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR03MB6996
X-Proofpoint-GUID: 51Azaai7dErBnr6YVqIAwGhFni-CwdA1
X-Proofpoint-ORIG-GUID: 51Azaai7dErBnr6YVqIAwGhFni-CwdA1
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-04_05,2022-02-03_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 adultscore=0
 lowpriorityscore=0 bulkscore=0 phishscore=0 suspectscore=0 clxscore=1015
 priorityscore=1501 malwarescore=0 mlxscore=0 mlxlogscore=999
 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202040082

DQoNCk9uIDA0LjAyLjIyIDE2OjMwLCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMDQuMDIuMjAy
MiAwNzozNCwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+PiBSZXNldCB0aGUgY29t
bWFuZCByZWdpc3RlciB3aGVuIGFzc2lnbmluZyBhIFBDSSBkZXZpY2UgdG8gYSBndWVzdDoNCj4+
IGFjY29yZGluZyB0byB0aGUgUENJIHNwZWMgdGhlIFBDSV9DT01NQU5EIHJlZ2lzdGVyIGlzIHR5
cGljYWxseSBhbGwgMCdzDQo+PiBhZnRlciByZXNldC4NCj4gSXQncyBub3QgZW50aXJlbHkgY2xl
YXIgdG8gbWUgd2hldGhlciBzZXR0aW5nIHRoZSBoYXJkd2FyZSByZWdpc3RlciB0bw0KPiB6ZXJv
IGlzIG9rYXkuIFdoYXQgd2FudHMgdG8gYmUgemVybyBpcyB0aGUgdmFsdWUgdGhlIGd1ZXN0IG9i
c2VydmVzDQo+IGluaXRpYWxseS4NCiJ0aGUgUENJIHNwZWMgc2F5cyB0aGUgUENJX0NPTU1BTkQg
cmVnaXN0ZXIgaXMgdHlwaWNhbGx5IGFsbCAwJ3MgYWZ0ZXIgcmVzZXQuIg0KV2h5IHdvdWxkbid0
IGl0IGJlIG9rPyBXaGF0IGlzIHRoZSBleGFjdCBjb25jZXJuIGhlcmU/DQo+PiAtLS0gYS94ZW4v
ZHJpdmVycy92cGNpL2hlYWRlci5jDQo+PiArKysgYi94ZW4vZHJpdmVycy92cGNpL2hlYWRlci5j
DQo+PiBAQCAtNDU0LDggKzQ1NCw3IEBAIHN0YXRpYyB2b2lkIGNtZF93cml0ZShjb25zdCBzdHJ1
Y3QgcGNpX2RldiAqcGRldiwgdW5zaWduZWQgaW50IHJlZywNCj4+ICAgICAgICAgICBwY2lfY29u
Zl93cml0ZTE2KHBkZXYtPnNiZGYsIHJlZywgY21kKTsNCj4+ICAgfQ0KPj4gICANCj4+IC1zdGF0
aWMgdm9pZCBndWVzdF9jbWRfd3JpdGUoY29uc3Qgc3RydWN0IHBjaV9kZXYgKnBkZXYsIHVuc2ln
bmVkIGludCByZWcsDQo+PiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVpbnQzMl90IGNt
ZCwgdm9pZCAqZGF0YSkNCj4+ICtzdGF0aWMgdWludDMyX3QgZW11bGF0ZV9jbWRfcmVnKGNvbnN0
IHN0cnVjdCBwY2lfZGV2ICpwZGV2LCB1aW50MzJfdCBjbWQpDQo+IFRoZSBjb21tYW5kIHJlZ2lz
dGVyIGlzIGEgMTYtYml0IG9uZSwgc28gcGFyYW1ldGVyIGFuZCByZXR1cm4gdHlwZSBzaG91bGQN
Cj4gZWl0aGVyIGJlIHBsYWluIHVuc2lnbmVkIGludCAocHJlZmVycmVkLCBzZWUgLi9DT0RJTkdf
U1RZTEUpIG9yIHVpbnQxNl90DQo+IGltby4NCkdvZCBjYXRjaCwgdGhhbmsgeW91DQo+IEphbg0K
Pg0KVGhhbmsgeW91LA0KT2xla3NhbmRy


From xen-devel-bounces@lists.xenproject.org Fri Feb 04 14:43:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 14:43:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265669.459094 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFznz-0006at-Um; Fri, 04 Feb 2022 14:43:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265669.459094; Fri, 04 Feb 2022 14:43:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nFznz-0006am-Ri; Fri, 04 Feb 2022 14:43:19 +0000
Received: by outflank-mailman (input) for mailman id 265669;
 Fri, 04 Feb 2022 14:43:19 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=u+82=ST=epam.com=prvs=4034f0a382=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nFzny-0006ag-Ta
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 14:43:19 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c9b77a1e-85c8-11ec-8eb8-a37418f5ba1a;
 Fri, 04 Feb 2022 15:43:17 +0100 (CET)
Received: from pps.filterd (m0174680.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 214ENmGq030566;
 Fri, 4 Feb 2022 14:43:13 GMT
Received: from eur02-he1-obe.outbound.protection.outlook.com
 (mail-he1eur02lp2053.outbound.protection.outlook.com [104.47.5.53])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3e15v902j4-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 04 Feb 2022 14:43:12 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by VI1PR03MB4480.eurprd03.prod.outlook.com (2603:10a6:803:58::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Fri, 4 Feb
 2022 14:43:07 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::d425:9c9f:10a8:fdf6%3]) with mapi id 15.20.4951.014; Fri, 4 Feb 2022
 14:43:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c9b77a1e-85c8-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=awmKGqtwzJMxJpU4H0/u6isPskAuqT/h/a+uzc1nSyp4qJFlBACV31YfBK9peWz6MROnaK4mVeIPCf4RyM+8OppOZFDQULBA02Ey/SzrShM7rZARCA3HCki+PfjOYcrbqI7NsRWEUc5OXfECHjudO0fWz50Ghf+21U8JRLZF1YytMKUt1b6OrXG7/lZ4GbNfgd1FRAzjTpfqsBg9IcpaTp2aR4KYxNXHXl10nSvPaO2kfegn3anq7lH3JjWooPe5e2kBjF6ewaabHfd4qnjir93eTtB9SmK0Y8oOtqTXcUKdosggFvEqnzDq/R8uL7QCC8efDj/9BpdeUEYuZdpmxw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Jr/JeYFNvwkOH3TaAOWqQi8B6Ku515wim4Y54Gn8UFg=;
 b=aQ8A+QHSgsEbOiIfHiVXtafAOW41gXq7W7bteFsnjbCRQuRbsSNHUsAl3Wn027C+m//3LR9AOxAC38w6P365cMUOj4JFy8IaCUzngnsyxt3LKgfu/eqpEemRS9UZ/+S7Mcun6wKKsghGJNstsWCKaBTiuvEspxRi+esPprsr4pE/NgtGTtxlednK1RPWY7/elYL/V19GjRokNABOG6wrq7f4vBV56/hR7Qn7gWjKQZrBCVFG+MhE83NoXi9ovK3B/FlUh15bpiER1Ao1v5I4Sj4zQUksYDdsQPi6mLy308mirMRqIrSOBKv04C5aVbMXyZqcvjom1smbRY1aY98JpA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Jr/JeYFNvwkOH3TaAOWqQi8B6Ku515wim4Y54Gn8UFg=;
 b=eLNfmQ8wVZh7XngsbhQUyx+4pOgxfVVZnHxq9gsQumkryRawUCtWz562Gmm3tnVy2MyRwAjA9QKtbFoRBgYxnBfCx1MzIG/3VaSDPuVHroRewODStXP27yJicW/wZTS7+karjlJifqUURNJsJYvTh9wKr5EDHMeR07QG9J3QiYc7P2GMP07WAlehPgIG50ThsoVre3LHLd6TrojR8JlzuBI26f0siQz3VXBk2EAMT2zCUoztBjYm98pAVTV/xpcsPtSFrqObT9ZXC/N7Sm0xt54FZYSpLLPcQNez4NA/sMwpmpotss5a9+7znij+SGPcl3mA/p76C8KfaBFgzOiAwA==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>,
        Jan Beulich
	<jbeulich@suse.com>
CC: "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Thread-Topic: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Thread-Index: 
 AQHYGZFc/MnzQOjwVEeBBUHLSW0md6yDBUkAgAASSACAAATYAIAAD/WAgAAKNgCAAAbfgIAABnuAgAAQvgCAAAMCAIAAAY4AgAADxICAABrnAA==
Date: Fri, 4 Feb 2022 14:43:07 +0000
Message-ID: <3ad10a99-c706-b95f-1419-2c0c7cf37d58@epam.com>
References: <7209889d-8f17-61cc-72a4-97f6dbc1d54d@suse.com>
 <2cf022f8-b000-11b7-c6b9-90a56bc6e2ea@epam.com>
 <04726915-f39f-9019-436e-4399533c9fc3@suse.com>
 <9ed3f4ac-0a2d-ed45-9872-7c3f356a469e@epam.com>
 <c3a99712-cf7c-37da-aac1-f2ee00e6d53b@suse.com>
 <Yf0KcVD8W05A4fbB@Air-de-Roger>
 <1ed0e342-16cd-2f16-c05c-186667a22762@suse.com>
 <7e3562b5-fc67-f213-e872-f211450d9e2e@epam.com>
 <a8fc599c-f620-c4d1-2077-c57068f46a7f@suse.com>
 <deef8468-d607-e49e-f456-6a8013329ca1@epam.com>
 <Yf0k6aoKK5G3iad1@Air-de-Roger>
In-Reply-To: <Yf0k6aoKK5G3iad1@Air-de-Roger>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 1c8ad558-5114-425c-8b3b-08d9e7eca8a5
x-ms-traffictypediagnostic: VI1PR03MB4480:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <VI1PR03MB44807893195BD4D2725553CDE7299@VI1PR03MB4480.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:7691;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 DsYrJltJ7Olkl7Jf1GFyfADpjPd4zAXkP2oNhtc/CjdKVBhLS4T+PDHrcg+r9QdlO/TOGwl1FGJsMH1i74gF/KXBJCZueUrQmnP2Xapq/23YHe7Bxm03hTWWkTpVED072BrffllED4gObh4H7GLPDPItXK6G9IJpeo4MWvI5zn9aRU2HeDkpcPNg5m2umd3Gsvvbwx19OC64ZZH+zDwPlVGJT07FiOzAjHsjRDyKTghLLGb6bAQweE3Mno5R2EXlpzhpsRZJdDWUoaVXbcdOq3rV9rzLT1g4VJa8Q5qPEyW1UkqGedgQUD10G3RBGzoLyzbEHwUJ8EfXqXWRvbV4ux8zd9Z2ciKr2Ecf2pzfv+6RJua5C8a0oxyzwpRj7UM6nfyGmx0dg0ovUyEwXt2LaoSr7j+aENskvBLwYVJkMChzFKfg+1eMAjSN4Ojnha3BsZ0HcgRe/J7y2xGndbxiz6UafCTFN4NBbZA2wRwUAu1/hxTXA0OjMnoGAQgvo35qcKQA0M1nDs0c//teKIi05AIWwj+qxjK5HE/hJ4DSs8bothXFCoJhCUxfeyadVKbMmocR0nWtXwpALWcZl/SAiVbHwkD8IpwWjkQoDQZibniLLnAE3dE1gSBWUN/spPjl49pv9HEP7EJgfIkASjgDPsoKp8qH5fnx9VwQxIJTFZSwJp/jn/HP5xb/6Vq/3ZFa5rixdRAVH94af6ptdMfsidsxNalyYEb18fYy8G8mxCZPdHNal1W4F+qQiMn9Oojf
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(7416002)(6486002)(107886003)(316002)(31686004)(53546011)(2616005)(26005)(5660300002)(38070700005)(186003)(6506007)(122000001)(54906003)(508600001)(6512007)(8676002)(38100700002)(66946007)(66476007)(8936002)(83380400001)(36756003)(2906002)(91956017)(76116006)(86362001)(71200400001)(66556008)(66446008)(64756008)(31696002)(4326008)(110136005)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?UzBjOWhDdml4ay9oWVNPMC9mMFl6NTFwY0ZIMjJpMzF2REJvNCttOHJjbklX?=
 =?utf-8?B?ODVUaTB6U2JDUXlLaUNyMFgyOUJKUENjaTZDYm5GM0xUZGNMK0tGTXhVbkJW?=
 =?utf-8?B?c0JZM3JqNE9QRUhQdGEvcE9xKy9OdGt4clBOZVEwSGhYd2JtQ0ROMnNwTHNm?=
 =?utf-8?B?Mi9RalpCMnBRL05leVZJTkcrbjJjSkxhL2lHODh2L0ZCTndZeXkwelROajNI?=
 =?utf-8?B?MHhNYUt5bmNOQkhwMVNSdHFuUVc5NmZ3dTg0UVNKSU8vdXNQTEZOVVVWY2tK?=
 =?utf-8?B?WTRWNGZTUTNwMVpWWFYvbjhhM2QzcjNTckU4TEprZk91OVBPUlFZTkoreFJE?=
 =?utf-8?B?U0toOUR6aGUwSmpTSFBIUGR3SkUvSG9lRDdLQmw1ODd1NTFCTmM3WUhhOXY0?=
 =?utf-8?B?enplS3QyVHA3WlhNMVJONjlZRXkvZzdpVDB4WXY4RFM2ZCtyMmhVdE1xbURH?=
 =?utf-8?B?TnNMWXFLR1ZlVTJtTEc4VVgvenpRZGhscEt5bGIwN21YVndmdi9SYkdwc1VN?=
 =?utf-8?B?by9pVlJQRmE2L3hVZmFzOWFVQngzSHNBZjIvWC9PdnROWVdHMXRlZ2ZWV3Nk?=
 =?utf-8?B?a0M4VXl4eUlaVHZUVlFJM2Ezb1l0QTBOZnFvbm9lbG93b2c5SS9HQlhSMEdK?=
 =?utf-8?B?dDVrR28zOTducEVkMldLbTJyNlBWZEZLemJYSHYrS2FwRXM0aC82S3dQRjhH?=
 =?utf-8?B?M1V1NXpmd1Bnd1dYNHI3RkNpT3AveWtLaGlBSnUxNGxkMFNSRi9hVHhWRjlM?=
 =?utf-8?B?TmZrZHRBNkpIYVJoUnBldVI4Q05xeDBrQW40QlU5VWxzbDJNZU0zRzlUdElW?=
 =?utf-8?B?MGlJMHk4VENtcjF4VDg2bTBuTWJSbnJENGFIZnlMcGkzZmhKRU1KTDlCdG5L?=
 =?utf-8?B?TllNK0VJWEJIN1VlQ2lmNFVTVDhjbmFVUnVyMU9PSEJFSFV3TUJPTnNLWmta?=
 =?utf-8?B?VlpzSHh1NWRHODdieUFQU3p6TENhRWY4SFhxeDV2K0IxUE85eG4rQUd2UE9k?=
 =?utf-8?B?SXJYblQwcmVndE94VkZVWEdLYkRaTlRsekhlVHBaUmt5Mk5ZOElaMTUxc3Fy?=
 =?utf-8?B?VUdPNmlLUmU3aDdBTlZ5SnUzRk8rRUtCMzB3cEVTY2xBUUhBOU5sOFg0bFJW?=
 =?utf-8?B?OFgzTkNkVnVTTGpCY01meDBpY1M3bSt5TEw3S3B6NFFuVG4raThEU01wTXdK?=
 =?utf-8?B?V3ZuRW9OMTRWbFRuWitoZXBqa0ZmOUt3dDFtWTA1eWNYb25tN0xDeWNQSjZK?=
 =?utf-8?B?UVhDTS9ZOTJmTjAraHo1MnNSVGJCWGl2SGwxYUFIeWNjazJwN21IYWZJaUZy?=
 =?utf-8?B?cUsyNUJkRjhubWZiS2dpRms5RkdaWUJjaUxzaGt2dStvNStCVE9pdHBRYkJr?=
 =?utf-8?B?M0ZQYVgxWGhhS0dLQmZNc215YkpHQnRRdjd3ZnNBcG1HY2JpMHV2OTJJczI1?=
 =?utf-8?B?ODRLVmMrdWw3d20wdUpXQVROTmtIZWZjb0xXWWt5eEN3WnkyVFlqVUdORGVs?=
 =?utf-8?B?cWIwSzJiMndqK0ZKZ1BzdG0xOUZWUHFia05UVnlTWjFMMWN3WE1oazdkMHR6?=
 =?utf-8?B?eU9RWjBzVW9Uby9oVzMxdGY5L1hDK3BqSXMveTdIL1EyWUJ6dFB6UlZWNXJH?=
 =?utf-8?B?K0RpMzQybGFvdTMwY090ZlJhQUlNWTRIUmtBaThCZndmUGdNZE1xQXFUbk9Q?=
 =?utf-8?B?UnNWVnNsQmdmR3Z6dWlEeUFYb2h2blFoZmpQaGl4TWdlb1FtQytXSGlFT1hO?=
 =?utf-8?B?WmdhSnQ5K3NSR0QyS2JUWkVDRjArdXgvQTJDQWxlN28wcEsxczIyN09SS1JE?=
 =?utf-8?B?VFR6OWhIZk9mbWJCVDdlTzhqTmJQUVJUcDUzTUdaM0VvOWJFYVBKd2pDdlBh?=
 =?utf-8?B?M0lGMGtvQjFCQkhnUHd4Mks0Sm50RDR5UHZTMVpuVE5WV3NZZTYySHRITU00?=
 =?utf-8?B?ODY2YkV0WmhFZXFsdkZtdU02cXZVTHI1b0NUc0EwdEx5cjdzeVJyc3dLN1RD?=
 =?utf-8?B?NytQWUI2OWdDMWVkeGJHR1RVQkxJUFhnOU5HYXk0R2VQZHlyTk54NkJ1a3RK?=
 =?utf-8?B?UDZJYTlES2RYRG1oWEFUSGcyVC9ZRmk3RDF2Mld3WXdoS1g2N0ZCWHBWQVNC?=
 =?utf-8?B?ZkRnemxCVTZwWWZXd1liOWtYaGdWMFFDQ3c2OFZkZHdrYXpxRlZHcXovNFQw?=
 =?utf-8?B?ekQ2L1JTTy9ja0lncGx1YmpKcDdpK0dNOTFlR3B0ek1wc1RTQk9BZ3RiNURy?=
 =?utf-8?B?aXMzMWs3VnNIREx3elRVWTRyR0ZHYzFJZFl6UmQ1eHU4TmhnOXRVV2FNNktR?=
 =?utf-8?B?ZDFhSmJWNm9hNHBLZ1RnZ1dYVDlkNzIrMlNrK2t3emJCWFZBS0JFQT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <1E35A4ACF7E29140AE4A80647C5CB41A@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1c8ad558-5114-425c-8b3b-08d9e7eca8a5
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Feb 2022 14:43:07.6261
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: zxdDLDswhT/Mz3EpiCb+5lsettFgzpWuT17Re7M3CSFU6wYFSGhMvlBOvyH+AcMpK05P2rLYS5R18I/aiBat1vChmbqEEf4kbPMsp2q59iKjtvHlCX02EBDzaA0bkoMJ
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR03MB4480
X-Proofpoint-GUID: d17OWlLByjUBxrNU9ljJT5Et32CXVQ-A
X-Proofpoint-ORIG-GUID: d17OWlLByjUBxrNU9ljJT5Et32CXVQ-A
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-04_06,2022-02-03_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 mlxlogscore=999
 suspectscore=0 adultscore=0 malwarescore=0 clxscore=1015 impostorscore=0
 spamscore=0 priorityscore=1501 mlxscore=0 lowpriorityscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2202040083

DQoNCk9uIDA0LjAyLjIyIDE1OjA2LCBSb2dlciBQYXUgTW9ubsOpIHdyb3RlOg0KPiBPbiBGcmks
IEZlYiAwNCwgMjAyMiBhdCAxMjo1MzoyMFBNICswMDAwLCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5r
byB3cm90ZToNCj4+DQo+PiBPbiAwNC4wMi4yMiAxNDo0NywgSmFuIEJldWxpY2ggd3JvdGU6DQo+
Pj4gT24gMDQuMDIuMjAyMiAxMzozNywgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+
Pj4+IE9uIDA0LjAyLjIyIDEzOjM3LCBKYW4gQmV1bGljaCB3cm90ZToNCj4+Pj4+IE9uIDA0LjAy
LjIwMjIgMTI6MTMsIFJvZ2VyIFBhdSBNb25uw6kgd3JvdGU6DQo+Pj4+Pj4gT24gRnJpLCBGZWIg
MDQsIDIwMjIgYXQgMTE6NDk6MThBTSArMDEwMCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+Pj4+Pj4+
IE9uIDA0LjAyLjIwMjIgMTE6MTIsIE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4+
Pj4+Pj4gT24gMDQuMDIuMjIgMTE6MTUsIEphbiBCZXVsaWNoIHdyb3RlOg0KPj4+Pj4+Pj4+IE9u
IDA0LjAyLjIwMjIgMDk6NTgsIE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4+Pj4+
Pj4+PiBPbiAwNC4wMi4yMiAwOTo1MiwgSmFuIEJldWxpY2ggd3JvdGU6DQo+Pj4+Pj4+Pj4+PiBP
biAwNC4wMi4yMDIyIDA3OjM0LCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyB3cm90ZToNCj4+Pj4+
Pj4+Pj4+PiBAQCAtMjg1LDYgKzI4NiwxMiBAQCBzdGF0aWMgaW50IG1vZGlmeV9iYXJzKGNvbnN0
IHN0cnVjdCBwY2lfZGV2ICpwZGV2LCB1aW50MTZfdCBjbWQsIGJvb2wgcm9tX29ubHkpDQo+Pj4+
Pj4+Pj4+Pj4gICAgICAgICAgICAgICAgICAgICAgIGNvbnRpbnVlOw0KPj4+Pj4+Pj4+Pj4+ICAg
ICAgICAgICAgICAgfQ0KPj4+Pj4+Pj4+Pj4+ICAgICAgIA0KPj4+Pj4+Pj4+Pj4+ICsgICAgICAg
IHNwaW5fbG9jaygmdG1wLT52cGNpX2xvY2spOw0KPj4+Pj4+Pj4+Pj4+ICsgICAgICAgIGlmICgg
IXRtcC0+dnBjaSApDQo+Pj4+Pj4+Pj4+Pj4gKyAgICAgICAgew0KPj4+Pj4+Pj4+Pj4+ICsgICAg
ICAgICAgICBzcGluX3VubG9jaygmdG1wLT52cGNpX2xvY2spOw0KPj4+Pj4+Pj4+Pj4+ICsgICAg
ICAgICAgICBjb250aW51ZTsNCj4+Pj4+Pj4+Pj4+PiArICAgICAgICB9DQo+Pj4+Pj4+Pj4+Pj4g
ICAgICAgICAgICAgICBmb3IgKCBpID0gMDsgaSA8IEFSUkFZX1NJWkUodG1wLT52cGNpLT5oZWFk
ZXIuYmFycyk7IGkrKyApDQo+Pj4+Pj4+Pj4+Pj4gICAgICAgICAgICAgICB7DQo+Pj4+Pj4+Pj4+
Pj4gICAgICAgICAgICAgICAgICAgY29uc3Qgc3RydWN0IHZwY2lfYmFyICpiYXIgPSAmdG1wLT52
cGNpLT5oZWFkZXIuYmFyc1tpXTsNCj4+Pj4+Pj4+Pj4+PiBAQCAtMzAzLDEyICszMTAsMTQgQEAg
c3RhdGljIGludCBtb2RpZnlfYmFycyhjb25zdCBzdHJ1Y3QgcGNpX2RldiAqcGRldiwgdWludDE2
X3QgY21kLCBib29sIHJvbV9vbmx5KQ0KPj4+Pj4+Pj4+Pj4+ICAgICAgICAgICAgICAgICAgIHJj
ID0gcmFuZ2VzZXRfcmVtb3ZlX3JhbmdlKG1lbSwgc3RhcnQsIGVuZCk7DQo+Pj4+Pj4+Pj4+Pj4g
ICAgICAgICAgICAgICAgICAgaWYgKCByYyApDQo+Pj4+Pj4+Pj4+Pj4gICAgICAgICAgICAgICAg
ICAgew0KPj4+Pj4+Pj4+Pj4+ICsgICAgICAgICAgICAgICAgc3Bpbl91bmxvY2soJnRtcC0+dnBj
aV9sb2NrKTsNCj4+Pj4+Pj4+Pj4+PiAgICAgICAgICAgICAgICAgICAgICAgcHJpbnRrKFhFTkxP
R19HX1dBUk5JTkcgIkZhaWxlZCB0byByZW1vdmUgWyVseCwgJWx4XTogJWRcbiIsDQo+Pj4+Pj4+
Pj4+Pj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzdGFydCwgZW5kLCByYyk7DQo+Pj4+
Pj4+Pj4+Pj4gICAgICAgICAgICAgICAgICAgICAgIHJhbmdlc2V0X2Rlc3Ryb3kobWVtKTsNCj4+
Pj4+Pj4+Pj4+PiAgICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIHJjOw0KPj4+Pj4+Pj4+Pj4+
ICAgICAgICAgICAgICAgICAgIH0NCj4+Pj4+Pj4+Pj4+PiAgICAgICAgICAgICAgIH0NCj4+Pj4+
Pj4+Pj4+PiArICAgICAgICBzcGluX3VubG9jaygmdG1wLT52cGNpX2xvY2spOw0KPj4+Pj4+Pj4+
Pj4+ICAgICAgICAgICB9DQo+Pj4+Pj4+Pj4+PiBBdCB0aGUgZmlyc3QgZ2xhbmNlIHRoaXMgc2lt
cGx5IGxvb2tzIGxpa2UgYW5vdGhlciB1bmp1c3RpZmllZCAoaW4gdGhlDQo+Pj4+Pj4+Pj4+PiBk
ZXNjcmlwdGlvbikgY2hhbmdlLCBhcyB5b3UncmUgbm90IGNvbnZlcnRpbmcgYW55dGhpbmcgaGVy
ZSBidXQgeW91DQo+Pj4+Pj4+Pj4+PiBhY3R1YWxseSBhZGQgbG9ja2luZyAoYW5kIEkgcmVhbGl6
ZSB0aGlzIHdhcyB0aGVyZSBiZWZvcmUsIHNvIEknbSBzb3JyeQ0KPj4+Pj4+Pj4+Pj4gZm9yIG5v
dCBwb2ludGluZyB0aGlzIG91dCBlYXJsaWVyKS4NCj4+Pj4+Pj4+Pj4gV2VsbCwgSSB0aG91Z2h0
IHRoYXQgdGhlIGRlc2NyaXB0aW9uIGFscmVhZHkgaGFzICIuLi50aGUgbG9jayBjYW4gYmUNCj4+
Pj4+Pj4+Pj4gdXNlZCAoYW5kIGluIGEgZmV3IGNhc2VzIGlzIHVzZWQgcmlnaHQgYXdheSkgdG8g
Y2hlY2sgd2hldGhlciB2cGNpDQo+Pj4+Pj4+Pj4+IGlzIHByZXNlbnQiIGFuZCB0aGlzIGlzIGVu
b3VnaCBmb3Igc3VjaCB1c2VzIGFzIGhlcmUuDQo+Pj4+Pj4+Pj4+PiAgICAgICBCdXQgdGhlbiBJ
IHdvbmRlciB3aGV0aGVyIHlvdQ0KPj4+Pj4+Pj4+Pj4gYWN0dWFsbHkgdGVzdGVkIHRoaXMsIHNp
bmNlIEkgY2FuJ3QgaGVscCBnZXR0aW5nIHRoZSBpbXByZXNzaW9uIHRoYXQNCj4+Pj4+Pj4+Pj4+
IHlvdSdyZSBpbnRyb2R1Y2luZyBhIGxpdmUtbG9jazogVGhlIGZ1bmN0aW9uIGlzIGNhbGxlZCBm
cm9tIGNtZF93cml0ZSgpDQo+Pj4+Pj4+Pj4+PiBhbmQgcm9tX3dyaXRlKCksIHdoaWNoIGluIHR1
cm4gYXJlIGNhbGxlZCBvdXQgb2YgdnBjaV93cml0ZSgpLiBZZXQgdGhhdA0KPj4+Pj4+Pj4+Pj4g
ZnVuY3Rpb24gYWxyZWFkeSBob2xkcyB0aGUgbG9jaywgYW5kIHRoZSBsb2NrIGlzIG5vdCAoY3Vy
cmVudGx5KQ0KPj4+Pj4+Pj4+Pj4gcmVjdXJzaXZlLiAoRm9yIHRoZSAzcmQgY2FsbGVyIG9mIHRo
ZSBmdW5jdGlvbiAtIGluaXRfYmFycygpIC0gb3RvaA0KPj4+Pj4+Pj4+Pj4gdGhlIGxvY2tpbmcg
bG9va3MgdG8gYmUgZW50aXJlbHkgdW5uZWNlc3NhcnkuKQ0KPj4+Pj4+Pj4+PiBXZWxsLCB5b3Ug
YXJlIGNvcnJlY3Q6IGlmIHRtcCAhPSBwZGV2IHRoZW4gaXQgaXMgY29ycmVjdCB0byBhY3F1aXJl
DQo+Pj4+Pj4+Pj4+IHRoZSBsb2NrLiBCdXQgaWYgdG1wID09IHBkZXYgYW5kIHJvbV9vbmx5ID09
IHRydWUNCj4+Pj4+Pj4+Pj4gdGhlbiB3ZSdsbCBkZWFkbG9jay4NCj4+Pj4+Pj4+Pj4NCj4+Pj4+
Pj4+Pj4gSXQgc2VlbXMgd2UgbmVlZCB0byBoYXZlIHRoZSBsb2NraW5nIGNvbmRpdGlvbmFsLCBl
LmcuIG9ubHkgbG9jaw0KPj4+Pj4+Pj4+PiBpZiB0bXAgIT0gcGRldg0KPj4+Pj4+Pj4+IFdoaWNo
IHdpbGwgYWRkcmVzcyB0aGUgbGl2ZS1sb2NrLCBidXQgaW50cm9kdWNlIEFCQkEgZGVhZGxvY2sg
cG90ZW50aWFsDQo+Pj4+Pj4+Pj4gYmV0d2VlbiB0aGUgdHdvIGxvY2tzLg0KPj4+Pj4+Pj4gSSBh
bSBub3Qgc3VyZSBJIGNhbiBzdWdnZXN0IGEgYmV0dGVyIHNvbHV0aW9uIGhlcmUNCj4+Pj4+Pj4+
IEBSb2dlciwgQEphbiwgY291bGQgeW91IHBsZWFzZSBoZWxwIGhlcmU/DQo+Pj4+Pj4+IFdlbGws
IGZpcnN0IG9mIGFsbCBJJ2QgbGlrZSB0byBtZW50aW9uIHRoYXQgd2hpbGUgaXQgbWF5IGhhdmUg
YmVlbiBva2F5IHRvDQo+Pj4+Pj4+IG5vdCBob2xkIHBjaWRldnNfbG9jayBoZXJlIGZvciBEb20w
LCBpdCBzdXJlbHkgbmVlZHMgYWNxdWlyaW5nIHdoZW4gZGVhbGluZw0KPj4+Pj4+PiB3aXRoIERv
bVUtcycgbGlzdHMgb2YgUENJIGRldmljZXMuIFRoZSByZXF1aXJlbWVudCByZWFsbHkgYXBwbGll
cyB0byB0aGUNCj4+Pj4+Pj4gb3RoZXIgdXNlIG9mIGZvcl9lYWNoX3BkZXYoKSBhcyB3ZWxsIChp
biB2cGNpX2R1bXBfbXNpKCkpLCBleGNlcHQgdGhhdA0KPj4+Pj4+PiB0aGVyZSBpdCBwcm9iYWJs
eSB3YW50cyB0byBiZSBhIHRyeS1sb2NrLg0KPj4+Pj4+Pg0KPj4+Pj4+PiBOZXh0IEknZCBsaWtl
IHRvIHBvaW50IG91dCB0aGF0IGhlcmUgd2UgaGF2ZSB0aGUgc3RpbGwgcGVuZGluZyBpc3N1ZSBv
Zg0KPj4+Pj4+PiBob3cgdG8gZGVhbCB3aXRoIGhpZGRlbiBkZXZpY2VzLCB3aGljaCBEb20wIGNh
biBhY2Nlc3MuIFNlZSBteSBSRkMgcGF0Y2gNCj4+Pj4+Pj4gInZQQ0k6IGFjY291bnQgZm9yIGhp
ZGRlbiBkZXZpY2VzIGluIG1vZGlmeV9iYXJzKCkiLiBXaGF0ZXZlciB0aGUgc29sdXRpb24NCj4+
Pj4+Pj4gaGVyZSwgSSB0aGluayBpdCB3YW50cyB0byBhdCBsZWFzdCBhY2NvdW50IGZvciB0aGUg
ZXh0cmEgbmVlZCB0aGVyZS4NCj4+Pj4+PiBZZXMsIHNvcnJ5LCBJIHNob3VsZCB0YWtlIGNhcmUg
b2YgdGhhdC4NCj4+Pj4+Pg0KPj4+Pj4+PiBOb3cgaXQgaXMgcXVpdGUgY2xlYXIgdGhhdCBwY2lk
ZXZzX2xvY2sgaXNuJ3QgZ29pbmcgdG8gaGVscCB3aXRoIGF2b2lkaW5nDQo+Pj4+Pj4+IHRoZSBk
ZWFkbG9jaywgYXMgaXQncyBpbW8gbm90IGFuIG9wdGlvbiBhdCBhbGwgdG8gYWNxdWlyZSB0aGF0
IGxvY2sNCj4+Pj4+Pj4gZXZlcnl3aGVyZSBlbHNlIHlvdSBhY2Nlc3MgLT52cGNpIChvciBlbHNl
IHRoZSB2cGNpIGxvY2sgaXRzZWxmIHdvdWxkIGJlDQo+Pj4+Pj4+IHBvaW50bGVzcykuIEJ1dCBh
IHBlci1kb21haW4gYXV4aWxpYXJ5IHIvdyBsb2NrIG1heSBoZWxwOiBPdGhlciBwYXRocw0KPj4+
Pj4+PiB3b3VsZCBhY3F1aXJlIGl0IGluIHJlYWQgbW9kZSwgYW5kIGhlcmUgeW91J2QgYWNxdWly
ZSBpdCBpbiB3cml0ZSBtb2RlIChpbg0KPj4+Pj4+PiB0aGUgZm9ybWVyIGNhc2UgYXJvdW5kIHRo
ZSB2cGNpIGxvY2ssIHdoaWxlIGluIHRoZSBsYXR0ZXIgY2FzZSB0aGVyZSBtYXkNCj4+Pj4+Pj4g
dGhlbiBub3QgYmUgYW55IG5lZWQgdG8gYWNxdWlyZSB0aGUgaW5kaXZpZHVhbCB2cGNpIGxvY2tz
IGF0IGFsbCkuIEZUQU9EOg0KPj4+Pj4+PiBJIGhhdmVuJ3QgZnVsbHkgdGhvdWdodCB0aHJvdWdo
IGFsbCBpbXBsaWNhdGlvbnMgKGFuZCBoZW5jZSB3aGV0aGVyIHRoaXMgaXMNCj4+Pj4+Pj4gdmlh
YmxlIGluIHRoZSBmaXJzdCBwbGFjZSk7IEkgZXhwZWN0IHlvdSB3aWxsLCBkb2N1bWVudGluZyB3
aGF0IHlvdSd2ZQ0KPj4+Pj4+PiBmb3VuZCBpbiB0aGUgcmVzdWx0aW5nIHBhdGNoIGRlc2NyaXB0
aW9uLiBPZiBjb3Vyc2UgdGhlIGRvdWJsZSBsb2NrDQo+Pj4+Pj4+IGFjcXVpcmUvcmVsZWFzZSB3
b3VsZCB0aGVuIGxpa2VseSB3YW50IGhpZGluZyBpbiBoZWxwZXIgZnVuY3Rpb25zLg0KPj4+Pj4+
IEkndmUgYmVlbiBhbHNvIHRoaW5raW5nIGFib3V0IHRoaXMsIGFuZCB3aGV0aGVyIGl0J3MgcmVh
bGx5IHdvcnRoIHRvDQo+Pj4+Pj4gaGF2ZSBhIHBlci1kZXZpY2UgbG9jayByYXRoZXIgdGhhbiBh
IHBlci1kb21haW4gb25lIHRoYXQgcHJvdGVjdHMgYWxsDQo+Pj4+Pj4gdnBjaSByZWdpb25zIG9m
IHRoZSBkZXZpY2VzIGFzc2lnbmVkIHRvIHRoZSBkb21haW4uDQo+Pj4+Pj4NCj4+Pj4+PiBUaGUg
T1MgaXMgbGlrZWx5IHRvIHNlcmlhbGl6ZSBhY2Nlc3NlcyB0byB0aGUgUENJIGNvbmZpZyBzcGFj
ZSBhbnl3YXksDQo+Pj4+Pj4gYW5kIHRoZSBvbmx5IHBsYWNlIEkgY291bGQgc2VlIGEgYmVuZWZp
dCBvZiBoYXZpbmcgcGVyLWRldmljZSBsb2NrcyBpcw0KPj4+Pj4+IGluIHRoZSBoYW5kbGluZyBv
ZiBNU0ktWCB0YWJsZXMsIGFzIHRoZSBoYW5kbGluZyBvZiB0aGUgbWFzayBiaXQgaXMNCj4+Pj4+
PiBsaWtlbHkgdmVyeSBwZXJmb3JtYW5jZSBzZW5zaXRpdmUsIHNvIGFkZGluZyBhIHBlci1kb21h
aW4gbG9jayB0aGVyZQ0KPj4+Pj4+IGNvdWxkIGJlIGEgYm90dGxlbmVjay4NCj4+Pj4+IEhtbSwg
d2l0aCBtZXRob2QgMSBhY2Nlc3NlcyBzZXJpYWxpemluZyBnbG9iYWxseSBpcyBiYXNpY2FsbHkN
Cj4+Pj4+IHVuYXZvaWRhYmxlLCBidXQgd2l0aCBNTUNGRyBJIHNlZSBubyByZWFzb24gd2h5IE9T
ZXMgbWF5IG5vdCAobW92ZQ0KPj4+Pj4gdG8pIHBlcm1pdCh0aW5nKSBwYXJhbGxlbCBhY2Nlc3Nl
cywgd2l0aCBzZXJpYWxpemF0aW9uIHBlcmhhcHMgZG9uZQ0KPj4+Pj4gb25seSBhdCBkZXZpY2Ug
bGV2ZWwuIFNlZSBvdXIgb3duIHBjaV9jb25maWdfbG9jaywgd2hpY2ggYXBwbGllcyB0bw0KPj4+
Pj4gb25seSBtZXRob2QgMSBhY2Nlc3Nlczsgd2UgZG9uJ3QgbG9vayB0byBiZSBzZXJpYWxpemlu
ZyBNTUNGRw0KPj4+Pj4gYWNjZXNzZXMgYXQgYWxsLg0KPj4+Pj4NCj4+Pj4+PiBXZSBjb3VsZCBh
bHRlcm5hdGl2ZWx5IGRvIGEgcGVyLWRvbWFpbiByd2xvY2sgZm9yIHZwY2kgYW5kIHNwZWNpYWwg
Y2FzZQ0KPj4+Pj4+IHRoZSBNU0ktWCBhcmVhIHRvIGFsc28gaGF2ZSBhIHBlci1kZXZpY2Ugc3Bl
Y2lmaWMgbG9jay4gQXQgd2hpY2ggcG9pbnQNCj4+Pj4+PiBpdCBiZWNvbWVzIGZhaXJseSBzaW1p
bGFyIHRvIHdoYXQgeW91IHByb3Bvc2UuDQo+Pj4+IEBKYW4sIEBSb2dlcg0KPj4+Pg0KPj4+PiAx
LiBkLT52cGNpX2xvY2sgLSByd2xvY2sgPC0gdGhpcyBwcm90ZWN0cyB2cGNpDQo+Pj4+IDIuIHBk
ZXYtPnZwY2ktPm1zaXhfdGJsX2xvY2sgLSByd2xvY2sgPC0gdGhpcyBwcm90ZWN0cyBNU0ktWCB0
YWJsZXMNCj4+Pj4gb3Igc2hvdWxkIGl0IGJldHRlciBiZSBwZGV2LT5tc2l4X3RibF9sb2NrIGFz
IE1TSS1YIHRhYmxlcyBkb24ndA0KPj4+PiByZWFsbHkgZGVwZW5kIG9uIHZQQ0k/DQo+Pj4gSWYg
c28sIHBlcmhhcHMgaW5kZWVkIGJldHRlciB0aGUgbGF0dGVyLiBCdXQgYXMgc2FpZCBpbiByZXBs
eSB0byBSb2dlciwNCj4+PiBJJ20gbm90IGNvbnZpbmNlZCAoeWV0KSB0aGF0IGRvaW5nIGF3YXkg
d2l0aCB0aGUgcGVyLWRldmljZSBsb2NrIGlzIGENCj4+PiBnb29kIG1vdmUuIEFzIHNhaWQgdGhl
cmUgLSB3ZSdyZSBvdXJzZWx2ZXMgZG9pbmcgZnVsbHkgcGFyYWxsZWwgTU1DRkcNCj4+PiBhY2Nl
c3Nlcywgc28gT1NlcyBvdWdodCB0byBiZSBmaW5lIHRvIGRvIHNvLCB0b28uDQo+PiBCdXQgd2l0
aCBwZGV2LT52cGNpX2xvY2sgd2UgZmFjZSBBQkJBLi4uDQo+IEkgdGhpbmsgaXQgd291bGQgYmUg
ZWFzaWVyIHRvIHN0YXJ0IHdpdGggYSBwZXItZG9tYWluIHJ3bG9jayB0aGF0DQo+IGd1YXJhbnRl
ZXMgcGRldi0+dnBjaSBjYW5ub3QgYmUgcmVtb3ZlZCB1bmRlciBvdXIgZmVldC4gVGhpcyB3b3Vs
ZCBiZQ0KPiB0YWtlbiBpbiByZWFkIG1vZGUgaW4gdnBjaV97cmVhZCx3cml0ZX0gYW5kIGluIHdy
aXRlIG1vZGUgd2hlbg0KPiByZW1vdmluZyBhIGRldmljZSBmcm9tIGEgZG9tYWluLg0KPg0KPiBU
aGVuIHRoZXJlIGFyZSBhbHNvIG90aGVyIGlzc3VlcyByZWdhcmRpbmcgdlBDSSBsb2NraW5nIHRo
YXQgbmVlZCB0bw0KPiBiZSBmaXhlZCwgYnV0IHRoYXQgbG9jayB3b3VsZCBsaWtlbHkgYmUgYSBz
dGFydC4NCk9yIGxldCdzIHNlZSB0aGUgcHJvYmxlbSBhdCBhIGRpZmZlcmVudCBhbmdsZTogdGhp
cyBpcyB0aGUgb25seSBwbGFjZQ0Kd2hpY2ggYnJlYWtzIHRoZSB1c2Ugb2YgcGRldi0+dnBjaV9s
b2NrLiBCZWNhdXNlIGFsbCBvdGhlciBwbGFjZXMNCmRvIG5vdCB0cnkgdG8gYWNxdWlyZSB0aGUg
bG9jayBvZiBhbnkgdHdvIGRldmljZXMgYXQgYSB0aW1lLg0KU28sIHdoYXQgaWYgd2UgcmUtd29y
ayB0aGUgb2ZmZW5kaW5nIHBpZWNlIG9mIGNvZGUgaW5zdGVhZD8NClRoYXQgd2F5IHdlIGRvIG5v
dCBicmVhayBwYXJhbGxlbCBhY2Nlc3MgYW5kIGhhdmUgdGhlIGxvY2sgcGVyLWRldmljZQ0Kd2hp
Y2ggbWlnaHQgYWxzbyBiZSBhIHBsdXMuDQoNCkJ5IHJlLXdvcmsgSSBtZWFuLCB0aGF0IGluc3Rl
YWQgb2YgcmVhZGluZyBhbHJlYWR5IG1hcHBlZCByZWdpb25zDQpmcm9tIHRtcCB3ZSBjYW4gZW1w
bG95IGEgZC0+cGNpX21hcHBlZF9yZWdpb25zIHJhbmdlIHNldCB3aGljaA0Kd2lsbCBob2xkIGFs
bCB0aGUgYWxyZWFkeSBtYXBwZWQgcmFuZ2VzLiBBbmQgd2hlbiBpdCBpcyBuZWVkZWQgdG8gYWNj
ZXNzDQp0aGF0IHJhbmdlIHNldCB3ZSB1c2UgcGNpZGV2c19sb2NrIHdoaWNoIHNlZW1zIHRvIGJl
IHJhcmUuDQpTbywgbW9kaWZ5X2JhcnMgd2lsbCByZWx5IG9uIHBkZXYtPnZwY2lfbG9jayArIHBj
aWRldnNfbG9jayBhbmQNCkFCQkEgd29uJ3QgYmUgcG9zc2libGUgYXQgYWxsLg0KDQo+DQo+IFRo
YW5rcywgUm9nZXIuDQo=


From xen-devel-bounces@lists.xenproject.org Fri Feb 04 14:57:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 14:57:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265679.459104 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nG01x-0008Hh-A5; Fri, 04 Feb 2022 14:57:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265679.459104; Fri, 04 Feb 2022 14:57:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nG01x-0008Ha-6w; Fri, 04 Feb 2022 14:57:45 +0000
Received: by outflank-mailman (input) for mailman id 265679;
 Fri, 04 Feb 2022 14:57:43 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=46ws=ST=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nG01v-0008HA-EH
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 14:57:43 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id cbdf22c8-85ca-11ec-8f75-fffcc8bd4f1a;
 Fri, 04 Feb 2022 15:57:40 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cbdf22c8-85ca-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1643986660;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=+DOo0BrCDS3eLT4mT1tFH4n0pDmdsTXnEmJyURa937w=;
  b=S5hNkxA4OQrxTL2a9D2m297T+P9KpEdKxgj3YwHHpkOrPLbSKw+89FGl
   vGeznOZhBSeiwVEebclo5OCYU3jNw4TwvAUZh45Eb2Dh5X4FqXfyZc++F
   3O6voMWSIlvQdVCnybkkEhAggk5kZRZ09b3LtgkSOv2NyJUK68cx/EAsb
   k=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: EDnuLwiW5DVUk9h5XvklC3s/jjjDU8silNoA9S5sRn1wvagGcJRO9kI/pFQ2oMBiH5l7I2Cq/j
 gkuHnJ5w02Qkkfz3mQc3gu/bgEG3r0fseAN6Rv/zW+IbeVEj/pf4eeeIKEmk4+m0K7MZKO7mtY
 CVLyrjUW2LGMYqj5z0WA88cd3axKFUfbR1KvKqzorBrK+vT4nDNjDxgNsbE6conv2jCDem04yN
 A/nv83mIiBJZQ+fiSh4iDi7Hq/zWPJICxj7XKIhP+2usFwifxWIRDj8fIno5hmE0zSmSym7pxr
 4eCGBYOa5vfhu3b27XfdLoTT
X-SBRS: 5.1
X-MesageID: 63422168
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:wItRea/nA1bfpHC5sWnfDrUDoniTJUtcMsCJ2f8bNWPcYEJGY0x3y
 WscXmmDb/bcNzGnfNl1a4y+90gG65DSz4BmG1ZopH88E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhFWeIdA970Ug5w7Rh3tYz6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhg7
 Y5Kk4WNQjxzGZPHu9hGcUVUUHtXaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguw5K8bmJsUHs2xIxjDFF/c2B5vERs0m4PcGh2tq3JkQTZ4yY
 eIURB5XPCrrRCEMYFkrEaw/t7yzhFrWJmgwRFW9+vNsvjm7IBZK+KDkLd79atGMA8JPkS6wj
 3ja8mHOJwAVPd2S1xKI6nupwOTImEvTUo8ICKex8PIshVSJ33ESEzUfT179qv684mauVtQaJ
 0EK9y4Gqakp6FftXtT7Rwe/onOPolgbQdU4O/cz6ByJjLHV5QmZLmEeS3hKb9lOnPExQTsmx
 1qYheTDDDZksKCWYX+F/7LSpjS3UQAXJ2IfYS4PTSMe/sLu5oo0i3rnadJuE7W8iNHvLhj2z
 yqXtyg1h7gVjskj2r2y+BbMhDfEjprUSg844C3HU2Tj6Rl2DKaCY4Gr8lHd4ex3EJeCTlKBs
 X4HnOCT9OkLS5qKkUSlW/4RFbuk4/KENjz0glN1GZQlsTO39BaekZt4uW8kYh0za4BdJGGvM
 BS7VR5tCIF7LV7xaoluXomKUeMUxovcTva5WrOOR48bCnRuTzOv8CZrbE+W+mnilkkwjK0yU
 aumndaQ4WUyUvo+kmfvLwsJ+fpyn31lmzuPLXzu50n/idKjiGippaDp2bdkRsQw9+u6rQrc6
 L6z3OPamkwEAIUSjsQ6mLP/zGzmz1BmXfgaSOQNL4ZvxzaK/kl7UJc9Jpt6I+RYc1x9zLugw
 51EchYwJKDDrXPGMx6WTXtodaniW51yxVpiY3B3bQ31hSVyOtn0hEv6S3fRVeN8nACE5aUsJ
 8Tphu3aWqgfItg502h1gWbBQHxKK03w2FPm09uNazkjZZ9wLzElCfe/FjYDABImV3Lt3eNn+
 uXI/lqCHfIrGlQzZO6LOanH5w7g4hAgdBdaAhKgzi97Ix63ruCH6kXZ05cKHi37AU6Sm2LHh
 1vKWkpwSCuki9ZdzeQlTJus9u+BO+B/AlBbDy/c67O3PjPd5W2t3clLV+PgQNwXfDqcFHyKa
 boHwvfiHucAmVoW4YNwH6wylfA15sf1pq8cxQNhRS2ZY1OuA7JmA3+HwcgQ6fEdmu4H4VO7C
 hCV591XGbSVI8e5QlQfExUoM7aY3vYOlziMsflseBfm5DV69aasWFlJO0XekzRUKbZ4adt3w
 eootMMMxRa4jx4mboSPgixOrjzeJX0cSaQ38JodBdaz2AYsz1hDZ73aCzP3v87TO4kdbBFyL
 2bN1qTYhrlayk7TSFYJFCDAjbhHmJADmBFW11tedV6HrcXI260s1xpL/DVpEgkMlkdb0/h+M
 3RAPlFuIfnc5C9hgcVOUjz+GwxFAxHFqEX9x0FQyT/cRkisEGfMMHc8KaCG+0VAqzBQeT1S/
 be5zmf5UGm1IJGtj3VqAUM1+eb+SdFR9xHZnJH1FsuIKJA2fD75j/L8fmEPsRbmXZs8iUCvS
 TOGJwqshXkX7RItnpA=
IronPort-HdrOrdr: A9a23:RfOdr64noJhPUAsVTgPXwVCBI+orL9Y04lQ7vn2ZFiY7TiXIra
 yTdaoguCMc6AxxZJkh8erwX5VoZUmsj6KdhrNhQItKPTOWw1dASbsN0WKM+UyDJ8STzJ856U
 4kSdkDNDSSNykKsS+Z2njALz9I+rDum8rJ9ITjJjVWPHlXgslbnnlE422gYytLrWd9dP4E/M
 323Ls5m9PsQwVdUu2LQl0+G8TTrdzCk5zrJTYAGh4c8QGLyRel8qTzHRS01goXF2on+8ZuzU
 H11yjCoomzufCyzRHRk0fV8pRtgdPkjv9OHtaFhMQ5IijlziyoeINicbufuy1dmpDk1H8a1P
 335zswNcV67H3cOkmzvBvWwgHllA0j7nfzoGXo90fLkIjcfnYXGsBBjYVWfl/y8Ew7puxx16
 pNwiawq4dXJQmoplWy2/H4EzVR0makq3srluAey1ZFV5EFVbNXpYsDuGtIDZY7Gj7g4oxPKp
 ggMCjl3ocXTbqmVQGbgoE2q+bcHEjbXy32DnTqg/blkgS/xxtCvg4lLM92pAZ2yHtycegB2w
 3+CNUaqFh5dL5jUUtMPpZwfSKJMB2+ffvtChPaHb21LtBOB5ryw6SHlYndotvaP6A18A==
X-IronPort-AV: E=Sophos;i="5.88,343,1635220800"; 
   d="scan'208";a="63422168"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=fPIOcOHjuRivSVkz08QDb9/1K+TR2LUtdGMo75jKZURJmWcnFXG34kbJFAcRt/IqX+AjotEphqA4EUqmFxgGab/Wx850SpKb0KesHBXQFfVm93vIn92dF+Atu8+39QQNGBPc3lVYxwVMYGy/LGRwj/Z/EEIinWYxaJbZ7F5gYV7XPdn4ZBY0juw0XDbtBqgTMHsdz/F8BEW+9rMeKqSkYQ58HfHHBYsbxeW40Q7frwmcdO2PX9bcIaqCQN9No+UeMtruHN94LOKpNIZ8Fd9t+5ncCh/q8SlUgQOV57RXd1mN7STVDj40IV1p8ZJPNr63m0IDidx2uzujhz0qV3YcrA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=EZG4uaaIYy3T7UgrANn68Yooksm3d6t0ul6ieOOGGNc=;
 b=Izyx4PXz/VOUXrCyTakWuMsArIroqtrGshgvpBWRVXJmCKatuyS2ejAC52jzwqqHNJjaLjVFuwAyvGwHxzwRISJfWQyZSdmLPj/mMNXAgWTIeh4OTzJrwKTM9tfdjY1e3+XrYUbyfyCvwNdXviQFI0eugi5+yjcG8o/EF2HmlZXQYaGZhPemxkX+1c5Pjt5RvUlvkY6IxxxMvJJgBnIFVIAq5RbRtORnrHriuzL9v5RJM0paix33lSTNgzmt/dBXyJMUU7+4ifaMAiqcxjeMYuugj/W6dw2ttec5xqnjsCd+exbp7BUOKUpIeenZs+UDsfzBHRnpEr0vaD2KEpqCZQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=EZG4uaaIYy3T7UgrANn68Yooksm3d6t0ul6ieOOGGNc=;
 b=O4WLxPnVzmNUzwhKIxzgSL0qgSv4YelCpDLhlwLMJYcgkkKoQWmhKWU9XzSjIpc3kGSJFItJ3UX9bmG1CPPqvTH2wRJcZ26OEk+Hq+5TSfXqBaEk+2/K2g4yh/O9Ig1FYy7n5jpAmP5T7o6UQZntzRn9q13U330cQ9sx9+v/Tkk=
Date: Fri, 4 Feb 2022 15:57:32 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: Jan Beulich <jbeulich@suse.com>, "julien@xen.org" <julien@xen.org>,
	"sstabellini@kernel.org" <sstabellini@kernel.org>, Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Artem Mygaiev <Artem_Mygaiev@epam.com>,
	"andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
	"george.dunlap@citrix.com" <george.dunlap@citrix.com>, "paul@xen.org"
	<paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>, Rahul Singh
	<rahul.singh@arm.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Message-ID: <Yf0+3C9nF8+tewLw@Air-de-Roger>
References: <04726915-f39f-9019-436e-4399533c9fc3@suse.com>
 <9ed3f4ac-0a2d-ed45-9872-7c3f356a469e@epam.com>
 <c3a99712-cf7c-37da-aac1-f2ee00e6d53b@suse.com>
 <Yf0KcVD8W05A4fbB@Air-de-Roger>
 <1ed0e342-16cd-2f16-c05c-186667a22762@suse.com>
 <7e3562b5-fc67-f213-e872-f211450d9e2e@epam.com>
 <a8fc599c-f620-c4d1-2077-c57068f46a7f@suse.com>
 <deef8468-d607-e49e-f456-6a8013329ca1@epam.com>
 <Yf0k6aoKK5G3iad1@Air-de-Roger>
 <3ad10a99-c706-b95f-1419-2c0c7cf37d58@epam.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <3ad10a99-c706-b95f-1419-2c0c7cf37d58@epam.com>
X-ClientProxiedBy: LO4P123CA0232.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1a6::21) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 34e13597-1bd2-4ac2-5f0c-08d9e7eeade7
X-MS-TrafficTypeDiagnostic: SN6PR03MB4494:EE_
X-Microsoft-Antispam-PRVS: <SN6PR03MB4494B9B64E22EC2B031FBC568F299@SN6PR03MB4494.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: S4ZvULrE/RT6a63WhgATqJGxHKcMIj+lj8ZAIKsxGmJLJZN7Kc9yhr+geuSTRlHL9UNd//DEPgKnKdRar098RhIc6d5b8xlh8OPCkhHlGUMAm+AH5IEVso7t599z9RhaksfLrAk06KLwCyxhVGGd/ogHs3P4StfDiK8NZUDamQJtbStkh9M8j9CPZByyDwuHkwXAOOFNhOvprA2Kno0R2j5ll6AKFb4Yjpk8dv4RfHD79+D63UtnTO3e5Ucx7SsOTyJhgwJkSRgTIIkE5ut8yrdqpl0WTY75YVwTDgXrM5IKsMA6WDGdYRNtYa5umchTPTdbeNlo/ht//2Mr3aOHxEjHUSEJdA1FGXGVqtRO4lKNQdR/1+RaRl1nEs2ST+bnMkK04p3mqhPRq/SWJIAqcauatXETgh8vUOFYtkmJO8EwA1fN2VaHTq9/UZY9dOzu6/NOAw4TRnoEUzD7fxt631/vgTcACZYeiI+dzm5GG27LQOv4q6tLiGpY6jtvKTTnLWc6vRNel2FQ2N9ulGeHBUZrGpLtDH31HUsscNDZLZRhSynhr3P8Zyoop/DoEr4sg0ANkWgoBxuOzuRLFpfJljcGVy/NU9kNfkEgyJP291DDnAPB9wob9Ewq0VzsqbhoMz9NuX3WjXGQJ381L4a5IQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(53546011)(66556008)(33716001)(66946007)(66476007)(9686003)(4326008)(8936002)(6506007)(38100700002)(6512007)(8676002)(186003)(26005)(83380400001)(6666004)(2906002)(82960400001)(5660300002)(7416002)(316002)(6916009)(85182001)(86362001)(508600001)(54906003)(6486002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RDVRVDVheUdUaWVnNTVqQVhHSndtR0FRaW1WOTJGMVV0TUc2dVJFUy9VTVlK?=
 =?utf-8?B?SHluK3MyWHUxM2t5eFZpdHJodUlhSUo3MXBTRkgzOFBuTENQR0pNMG1lUjJq?=
 =?utf-8?B?N2d2MHhldUlvZWhUdkpGalBQM0I1dlhrbXlOdDdFUm1rM09VN1F6L0tESTdl?=
 =?utf-8?B?aUNDMVMxU0hCZ2Z6alFsNlJlV1pGNkhyZkhyOEYrOWorTHpEYVFLdW9GNzNG?=
 =?utf-8?B?Sm9aZjZFckJsUXNKRWtQSks0dUh4Q3l0bmQ4R09TQUJSbEpiUHA1eTFMMHVI?=
 =?utf-8?B?bDl2SStZNTJEaXduWTRVR09raHo3dXFhV1BncXYvdS9ReWpZYk1LUEFUN1FV?=
 =?utf-8?B?MTZGLzJ0a2dWNm1KdjVDcTJuV3o5WGxxb3R4bXowV09kbk1wSzBkcWRrQWtj?=
 =?utf-8?B?Q0pxOXBOb3VnYUdjU29zL0twNEY0T1dSSzZyUVJTUzJKQWJqSzk0UXcwaU9r?=
 =?utf-8?B?ZUpUMlp6RW15cjlzMjNzNlFEZHJocjc3dkp4eEZrdC9rRVdYV1FZQ3ZQLzlw?=
 =?utf-8?B?YzV5WC9nQXgvbklvRGtvczh1UHV6VFQ2dFVPQ3h4RWlnRURMM0hIYU1qT2hC?=
 =?utf-8?B?eDZOekFoZ25OanRtczdINTRaaGpnaW5Sc3R2TkVyNU91bXJ2ZU9ML3kvMTBm?=
 =?utf-8?B?UGpNZllldkpmdlUvL1Z5d1pSZ1lSZEx0RWhXcWNqczAxa3R0cC83ZE1LSzFP?=
 =?utf-8?B?RjMzL0lnY3U4NDdQOWNXWTRRRmVDK1kyc09pQmJtbXJLMWxCajlCanZqenVJ?=
 =?utf-8?B?a0puNk01SVJnTlNtL0JTOXNHbjBwbml4NVpUNXBVSytLYURMYUFMdCthLzc0?=
 =?utf-8?B?SGFITUg5RGh5U0FaMHJFangyd1A4aVlVdkNtRkFPTVc2M2dob3FpOTkyWFVW?=
 =?utf-8?B?c0lhb2w1TEpMcU56UlRQZ2hlNmZUZHc0MlN4ZzFIS2d2ZjFRV29oTVF3ZVZo?=
 =?utf-8?B?SHJrb3g3bUJ5UkUwcS9vUHd3ZmpHTzNDcXJybG9YUi9nb3g2U3J4YjltaC9R?=
 =?utf-8?B?YlhWREt0WVBacktERjVGRlh2OGI0VVYrNnRnRXpLYktmeGVsbHdhR0hsVmNC?=
 =?utf-8?B?SEJJY004V3g5WkhlMkhNekl5Q1RHQ0hJTjhucXNyNVZzYURjdDJ4MmpwUjRk?=
 =?utf-8?B?NW0yUGNjZTlwMXZTaUZpdGpLbERPdzRsSjhwSWxkMHZ3TkFuOVM5OGdielRI?=
 =?utf-8?B?VjRKeWw4eTh6bHgwZlZwWWJhZ0p3dlFlUzZOSnd0VGRSMUVNbHNmUFJBL1lW?=
 =?utf-8?B?RmtpUEFxSnJ3Mzl4VmxTU0NvWFAyM0tpN0VtWmhmVkVsRTBFL0ppbEJGMTJP?=
 =?utf-8?B?dUhYMS9xNWlidUlqNU1RUUFxSWpoaFFDS2FSeWdaS2ZmR1hVTUtkeWlISmph?=
 =?utf-8?B?ZHhYckZ5ZXo1ektrZHJOdzVpTGVpTUpDWnJneTVydm9TMnFpQ0NXZUFMVUQ1?=
 =?utf-8?B?Yi9lZVFKSkxuSXJSZ2pEZVkrVm5BZWNsYi9hMHNBbmlLL280aG1ZeXdvUHgw?=
 =?utf-8?B?SzFhVEZHL2w4WjhtQmlXakw2bWdCK2VYSUVQS1dhNGlpWkZNSTJvQWNHdERO?=
 =?utf-8?B?MjR1VS9GQkJxazM2NjN4d3NmT09CUWNwUkRjZ3lKdmsyRU1PS1hmK1lQOXM2?=
 =?utf-8?B?djN6YTg1LzJndldVNzIreXFwMjdqSEphS1NTaHBFdzBhczZBU0ZSc2ZsRUds?=
 =?utf-8?B?WGltZzJLcmUxSFlLQzNsTVQxVG9xcTdIb0x5dnpodkxHYVVPSkJaOVYyOStZ?=
 =?utf-8?B?Q3dGeVJSQTcwb213LzdXZFRVREpFM1BRVmFWQVZDRTMxMVd2aHFqUXRXYWdq?=
 =?utf-8?B?Q3B2MEdHWGs3aVFZemd4QUdZczJoRExablpJYitEdGNGUHNseGFGaE5FVFFH?=
 =?utf-8?B?YS9qdnoxN0pycjFPTC92elV0ZzcvWXFnYkFTcFhtWHhuWmRlbzVqT0w4VzVa?=
 =?utf-8?B?R3hmMnlvZUw1eU1QZHZlUHNTSXVteTl1Zi9tN0ZkMUlNMzgrTDN2anBNTXFN?=
 =?utf-8?B?WnJGd1o2cDNzemlDU3FUN0NEZ2Zod09hUDZVNSt3VEg4bWRzWGk2SitmOU9z?=
 =?utf-8?B?a0c5enRSRm5lOS9ic2ZpSXk3Q09SQWs0S1hqQVYvRXJQbnpCMjVQMGFWbWpr?=
 =?utf-8?B?dk9SZmpLVW04cXp6MmRYQThtaWVhUXRKREthL0VKRXFuSHR3QzZhSlRBOUdL?=
 =?utf-8?Q?whcbSLQjg7XfWTjFvubJq/8=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 34e13597-1bd2-4ac2-5f0c-08d9e7eeade7
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Feb 2022 14:57:35.7833
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7nQb7CphjYvpM8acUFISJ7yW4fcxnEnmbeZApxg/UPb5JHredGnlslb0GX/bAk2GXtSzc4aN1eVbi4VC9pi1sA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR03MB4494
X-OriginatorOrg: citrix.com

On Fri, Feb 04, 2022 at 02:43:07PM +0000, Oleksandr Andrushchenko wrote:
> 
> 
> On 04.02.22 15:06, Roger Pau Monné wrote:
> > On Fri, Feb 04, 2022 at 12:53:20PM +0000, Oleksandr Andrushchenko wrote:
> >>
> >> On 04.02.22 14:47, Jan Beulich wrote:
> >>> On 04.02.2022 13:37, Oleksandr Andrushchenko wrote:
> >>>> On 04.02.22 13:37, Jan Beulich wrote:
> >>>>> On 04.02.2022 12:13, Roger Pau Monné wrote:
> >>>>>> On Fri, Feb 04, 2022 at 11:49:18AM +0100, Jan Beulich wrote:
> >>>>>>> On 04.02.2022 11:12, Oleksandr Andrushchenko wrote:
> >>>>>>>> On 04.02.22 11:15, Jan Beulich wrote:
> >>>>>>>>> On 04.02.2022 09:58, Oleksandr Andrushchenko wrote:
> >>>>>>>>>> On 04.02.22 09:52, Jan Beulich wrote:
> >>>>>>>>>>> On 04.02.2022 07:34, Oleksandr Andrushchenko wrote:
> >>>>>>>>>>>> @@ -285,6 +286,12 @@ static int modify_bars(const struct pci_dev *pdev, uint16_t cmd, bool rom_only)
> >>>>>>>>>>>>                       continue;
> >>>>>>>>>>>>               }
> >>>>>>>>>>>>       
> >>>>>>>>>>>> +        spin_lock(&tmp->vpci_lock);
> >>>>>>>>>>>> +        if ( !tmp->vpci )
> >>>>>>>>>>>> +        {
> >>>>>>>>>>>> +            spin_unlock(&tmp->vpci_lock);
> >>>>>>>>>>>> +            continue;
> >>>>>>>>>>>> +        }
> >>>>>>>>>>>>               for ( i = 0; i < ARRAY_SIZE(tmp->vpci->header.bars); i++ )
> >>>>>>>>>>>>               {
> >>>>>>>>>>>>                   const struct vpci_bar *bar = &tmp->vpci->header.bars[i];
> >>>>>>>>>>>> @@ -303,12 +310,14 @@ static int modify_bars(const struct pci_dev *pdev, uint16_t cmd, bool rom_only)
> >>>>>>>>>>>>                   rc = rangeset_remove_range(mem, start, end);
> >>>>>>>>>>>>                   if ( rc )
> >>>>>>>>>>>>                   {
> >>>>>>>>>>>> +                spin_unlock(&tmp->vpci_lock);
> >>>>>>>>>>>>                       printk(XENLOG_G_WARNING "Failed to remove [%lx, %lx]: %d\n",
> >>>>>>>>>>>>                              start, end, rc);
> >>>>>>>>>>>>                       rangeset_destroy(mem);
> >>>>>>>>>>>>                       return rc;
> >>>>>>>>>>>>                   }
> >>>>>>>>>>>>               }
> >>>>>>>>>>>> +        spin_unlock(&tmp->vpci_lock);
> >>>>>>>>>>>>           }
> >>>>>>>>>>> At the first glance this simply looks like another unjustified (in the
> >>>>>>>>>>> description) change, as you're not converting anything here but you
> >>>>>>>>>>> actually add locking (and I realize this was there before, so I'm sorry
> >>>>>>>>>>> for not pointing this out earlier).
> >>>>>>>>>> Well, I thought that the description already has "...the lock can be
> >>>>>>>>>> used (and in a few cases is used right away) to check whether vpci
> >>>>>>>>>> is present" and this is enough for such uses as here.
> >>>>>>>>>>>       But then I wonder whether you
> >>>>>>>>>>> actually tested this, since I can't help getting the impression that
> >>>>>>>>>>> you're introducing a live-lock: The function is called from cmd_write()
> >>>>>>>>>>> and rom_write(), which in turn are called out of vpci_write(). Yet that
> >>>>>>>>>>> function already holds the lock, and the lock is not (currently)
> >>>>>>>>>>> recursive. (For the 3rd caller of the function - init_bars() - otoh
> >>>>>>>>>>> the locking looks to be entirely unnecessary.)
> >>>>>>>>>> Well, you are correct: if tmp != pdev then it is correct to acquire
> >>>>>>>>>> the lock. But if tmp == pdev and rom_only == true
> >>>>>>>>>> then we'll deadlock.
> >>>>>>>>>>
> >>>>>>>>>> It seems we need to have the locking conditional, e.g. only lock
> >>>>>>>>>> if tmp != pdev
> >>>>>>>>> Which will address the live-lock, but introduce ABBA deadlock potential
> >>>>>>>>> between the two locks.
> >>>>>>>> I am not sure I can suggest a better solution here
> >>>>>>>> @Roger, @Jan, could you please help here?
> >>>>>>> Well, first of all I'd like to mention that while it may have been okay to
> >>>>>>> not hold pcidevs_lock here for Dom0, it surely needs acquiring when dealing
> >>>>>>> with DomU-s' lists of PCI devices. The requirement really applies to the
> >>>>>>> other use of for_each_pdev() as well (in vpci_dump_msi()), except that
> >>>>>>> there it probably wants to be a try-lock.
> >>>>>>>
> >>>>>>> Next I'd like to point out that here we have the still pending issue of
> >>>>>>> how to deal with hidden devices, which Dom0 can access. See my RFC patch
> >>>>>>> "vPCI: account for hidden devices in modify_bars()". Whatever the solution
> >>>>>>> here, I think it wants to at least account for the extra need there.
> >>>>>> Yes, sorry, I should take care of that.
> >>>>>>
> >>>>>>> Now it is quite clear that pcidevs_lock isn't going to help with avoiding
> >>>>>>> the deadlock, as it's imo not an option at all to acquire that lock
> >>>>>>> everywhere else you access ->vpci (or else the vpci lock itself would be
> >>>>>>> pointless). But a per-domain auxiliary r/w lock may help: Other paths
> >>>>>>> would acquire it in read mode, and here you'd acquire it in write mode (in
> >>>>>>> the former case around the vpci lock, while in the latter case there may
> >>>>>>> then not be any need to acquire the individual vpci locks at all). FTAOD:
> >>>>>>> I haven't fully thought through all implications (and hence whether this is
> >>>>>>> viable in the first place); I expect you will, documenting what you've
> >>>>>>> found in the resulting patch description. Of course the double lock
> >>>>>>> acquire/release would then likely want hiding in helper functions.
> >>>>>> I've been also thinking about this, and whether it's really worth to
> >>>>>> have a per-device lock rather than a per-domain one that protects all
> >>>>>> vpci regions of the devices assigned to the domain.
> >>>>>>
> >>>>>> The OS is likely to serialize accesses to the PCI config space anyway,
> >>>>>> and the only place I could see a benefit of having per-device locks is
> >>>>>> in the handling of MSI-X tables, as the handling of the mask bit is
> >>>>>> likely very performance sensitive, so adding a per-domain lock there
> >>>>>> could be a bottleneck.
> >>>>> Hmm, with method 1 accesses serializing globally is basically
> >>>>> unavoidable, but with MMCFG I see no reason why OSes may not (move
> >>>>> to) permit(ting) parallel accesses, with serialization perhaps done
> >>>>> only at device level. See our own pci_config_lock, which applies to
> >>>>> only method 1 accesses; we don't look to be serializing MMCFG
> >>>>> accesses at all.
> >>>>>
> >>>>>> We could alternatively do a per-domain rwlock for vpci and special case
> >>>>>> the MSI-X area to also have a per-device specific lock. At which point
> >>>>>> it becomes fairly similar to what you propose.
> >>>> @Jan, @Roger
> >>>>
> >>>> 1. d->vpci_lock - rwlock <- this protects vpci
> >>>> 2. pdev->vpci->msix_tbl_lock - rwlock <- this protects MSI-X tables
> >>>> or should it better be pdev->msix_tbl_lock as MSI-X tables don't
> >>>> really depend on vPCI?
> >>> If so, perhaps indeed better the latter. But as said in reply to Roger,
> >>> I'm not convinced (yet) that doing away with the per-device lock is a
> >>> good move. As said there - we're ourselves doing fully parallel MMCFG
> >>> accesses, so OSes ought to be fine to do so, too.
> >> But with pdev->vpci_lock we face ABBA...
> > I think it would be easier to start with a per-domain rwlock that
> > guarantees pdev->vpci cannot be removed under our feet. This would be
> > taken in read mode in vpci_{read,write} and in write mode when
> > removing a device from a domain.
> >
> > Then there are also other issues regarding vPCI locking that need to
> > be fixed, but that lock would likely be a start.
> Or let's see the problem at a different angle: this is the only place
> which breaks the use of pdev->vpci_lock. Because all other places
> do not try to acquire the lock of any two devices at a time.
> So, what if we re-work the offending piece of code instead?
> That way we do not break parallel access and have the lock per-device
> which might also be a plus.
> 
> By re-work I mean, that instead of reading already mapped regions
> from tmp we can employ a d->pci_mapped_regions range set which
> will hold all the already mapped ranges. And when it is needed to access
> that range set we use pcidevs_lock which seems to be rare.
> So, modify_bars will rely on pdev->vpci_lock + pcidevs_lock and
> ABBA won't be possible at all.

Sadly that won't replace the usage of the loop in modify_bars. This is
not (exclusively) done in order to prevent mapping the same region
multiple times, but rather to prevent unmapping of regions as long as
there's an enabled BAR that's using it.

If you wanted to use something like d->pci_mapped_regions it would
have to keep reference counts to regions, in order to know when a
mapping is no longer required by any BAR on the system with memory
decoding enabled.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Feb 04 16:55:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 16:55:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265732.459272 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nG1rI-0004tM-FX; Fri, 04 Feb 2022 16:54:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265732.459272; Fri, 04 Feb 2022 16:54:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nG1rI-0004tF-CP; Fri, 04 Feb 2022 16:54:52 +0000
Received: by outflank-mailman (input) for mailman id 265732;
 Fri, 04 Feb 2022 16:54:51 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nG1rH-0004t5-Kw; Fri, 04 Feb 2022 16:54:51 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nG1rH-0005ZE-Hj; Fri, 04 Feb 2022 16:54:51 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nG1rG-0007Ok-Vs; Fri, 04 Feb 2022 16:54:51 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nG1rG-0004Qo-VP; Fri, 04 Feb 2022 16:54:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=FDCjuselM9o/nzAsgC7iznlFaocEiczQIHqH/iCLkw0=; b=FcnaR91azx8I0RK5Plj01K6phQ
	Gs7rl+I///+QiQmaL0NZ+sOAfBmt7loHD2WqicLvtt8B9mdUzaqtlJTeQzFLEt+JOwNXliCtXmDLT
	72g55WYi797myFC8D5izko6s7/zFq5nc65RBu4C4BNDXShWp1DEg3QHPp2jeM2FWbYOE=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168004-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 168004: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-freebsd12-amd64:guest-localmigrate/x10:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=1f2cfdd349b7647f438c1e552dc1b983da86d830
X-Osstest-Versions-That:
    linux=27bb0b18c208ecd4c0deda6aad28616d73e4133d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 04 Feb 2022 16:54:50 +0000

flight 168004 linux-linus real [real]
flight 168010 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/168004/
http://logs.test-lab.xenproject.org/osstest/logs/168010/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-freebsd12-amd64 19 guest-localmigrate/x10 fail pass in 168010-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167988
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167988
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167988
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167988
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167988
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167988
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167988
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167988
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                1f2cfdd349b7647f438c1e552dc1b983da86d830
baseline version:
 linux                27bb0b18c208ecd4c0deda6aad28616d73e4133d

Last test of basis   167988  2022-02-02 18:11:17 Z    1 days
Failing since        167993  2022-02-03 04:34:02 Z    1 days    2 attempts
Testing same since   168004  2022-02-04 00:41:22 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  "Eric W. Biederman" <ebiederm@xmission.com>
  Chuck Lever <chuck.lever@oracle.com>
  Dai Ngo <dai.ngo@oracle.com>
  Dan Carpenter <dan.carpenter@oracle.com>
  Eric W. Biederman <ebiederm@xmission.com>
  Igor Pylypiv <ipylypiv@google.com>
  J. Bruce Fields <bfields@redhat.com>
  Jan Kara <jack@suse.cz>
  John Hubbard <jhubbard@nvidia.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Michal Koutný <mkoutny@suse.com>
  Mickaël Salaün <mic@linux.microsoft.com>
  Phil Auld <pauld@redhat.com>
  Randy Dunlap <rdunlap@infradead.org>
  Tabitha Sable <tabitha.c.sable@gmail.com>
  Tejun Heo <tj@kernel.org>
  Thomas Bogendoerfer <tsbogend@alpha.franken.de>
  Tianchen Ding <dtcccc@linux.alibaba.com>
  Waiman Long <longman@redhat.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             fail    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   27bb0b18c208..1f2cfdd349b7  1f2cfdd349b7647f438c1e552dc1b983da86d830 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Fri Feb 04 17:34:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 17:34:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265745.459282 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nG2Ty-0000d9-L0; Fri, 04 Feb 2022 17:34:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265745.459282; Fri, 04 Feb 2022 17:34:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nG2Ty-0000d2-I3; Fri, 04 Feb 2022 17:34:50 +0000
Received: by outflank-mailman (input) for mailman id 265745;
 Fri, 04 Feb 2022 17:34:49 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TTBG=ST=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nG2Tw-0000cw-Uo
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 17:34:49 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id be4f302b-85e0-11ec-8f75-fffcc8bd4f1a;
 Fri, 04 Feb 2022 18:34:47 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: be4f302b-85e0-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1643996087;
  h=from:to:cc:subject:date:message-id:mime-version:
   content-transfer-encoding;
  bh=PbR2rJWgBd8l/U07rE0KMfGiCfSwypoEiPGi9JzCvTA=;
  b=TncU8WpbQ4C8tx6KEf7xXO75Cb6kHKGDlJhzLdCJ9SbTDpT+KmiDsNdY
   dmitf3rtpn3M3orjpNXMIxLCov00NSbyrNRRhcZGPlz4KM3fTAEM8gTHa
   jClrDgI1GKsVEHbK4BRcdge2GUxgd+NXLxp1dfkdnkQTkFcEl2kI1OYWQ
   M=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: J/p6P4ljyjwR5JgK6GAY5wErsKlvYH78QvuY9xbxzHLRbFffYaVybKODu00WHgI4i+HR1zMhTd
 4N+K4kiwvtyqVZYgwguQqIrvEfiF6Hmc+NPjTb//LtZ7oWTGIkCqPeO6qKZAiSxMVhT3q6CBLW
 6fx8wAdcDwWzlUWP/MxF7/Q+K+IltWr+oFRQsJqQ/I3ce38k7a+RVn6zM+gse9HJEz0CJB3SG5
 MwgecVub/nnF5oVlEO6zspdB9xOkzoHbg/oe6hCJ49PVfTBk2Wt5JiTr9PyZA4cXb/Sh9FwXVY
 yvj5SaCLJO/NS9h3SBzIPavZ
X-SBRS: 5.1
X-MesageID: 65732452
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:7Zj6MqBo0WAVFxVW/+Tkw5YqxClBgxIJ4kV8jS/XYbTApDwl32ZTn
 GUaWWiOaKyJZmDwfdl/YYrnpkJX6JCAzYNhQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMo/u1Si6FatANl1ElvU2zbue6WL6s1hxZH1c+En970U47wIbVv6Yz6TSHK1LV0
 T/Ni5W31G+Ng1aY5UpNtspvADs21BjDkGtwUm4WPJinj3eH/5UhN7oNJLnZEpfNatI88thW5
 Qr05OrREmvxp3/BAz4++1rxWhVirrX6ZWBihpfKMkQLb9crSiEai84G2PQghUh/rCSvwNddy
 cx3n5GpbQoWEvfSneNNakwNe81+FfUuFL7vJHG+tYqYzlHccmuqyPJrZK00FdRGoKAtWzgIr
 KFGbmBWBvyAr7veLLaTY+9gnMk8auLsO5sSoCpIxjDFF/c2B5vERs0m4PcGgWhr3JwTR54yY
 eIWSAJuTQTrXidiKwYpDoIe37yNn2PGJmgwRFW9+vNsvjm7IBZK+KfpGMrYfJqNX8o9tmSyq
 3/C/m/5KgoHL9HZwj2Amlq8i+mKkS7lVYY6ELyj6uUskFCV3nYUChAdSR28u/bRt6Klc4sBc
 QpOoHNo9PVsshzwJjXgY/GmiFmVmEEbd9tJKcc38SWA9YaO/QOeVlFRG1atd+canMMxQDUr0
 HqAkNXoGSFjvdWpdJ6NyluHhWjsYHZIdAfucQdBFFJYuIe7/OnfmzqSFo4LLUKjsjHi9dgcK
 RiupTN2ubgchNVjO06TrQGe2GLESnQko2cICuTrsoCNs1sRiG2NPdXABb3nARBodt3xor6p5
 yBspiRmxLpSZaxhbQTUKAn3IJmn5uyeLBrXikN1Ep8q+lyFoiD/JtALvW8jdRw2aa7onAMFh
 meJ4mu9A7cIZBOXgVJfOdrtW6zGM4C8fTgaahwkRoUXOcUgHON21CpveVSRzwjQfLsEyskC1
 WOgWZ/0Vx4yUP0/pBLvHrt1+eJ7l0gWmDKILbimnkvP7FZrTCPMIVvzGADVNb5RAWLtiFi9z
 uuzwOPRmkgGDb2jPnKKmWPRRHhTRUUG6VnNg5Q/Xoa+zsBOQTlJ5yb5zexzdop7sb5Sk+uUr
 HixVlUBkAj0hGHdKBXMYXdmMeu9UZF6pHM9HCotIVf3hCRzPdfxtP8SJ8ktYL0q1O1/1vooH
 fMLTNqNX6ZUQTPd9jVDMZSk9N5+dA6mjB6lNja+ZGRtZIZpQgHEo4e2fgbm+CQUIDCwsM8y/
 ++p2g/BGMJRTAV+FsfGLvmoygrp73QanetzWWrOI8VSJxqwoNQ7dXSpg6Zucc8WKBjFyj+L7
 CqsAE8V9bvXvos40NjVnqTY/Y2nJPRzQxhBFG7B4LfoaSSDpji/wZVNWfqjdCzGUD+m472rY
 OhYwq2uMPADm1oW4YNwH6wykPA77trr4bRb0h5lDDPAaFHyUuFsJXyP3M9usKxRx+AG5VvqC
 xzXotQKa6+UPM7FEUIKIFt3Z+uO4vgYhz3O4KlnO079/iJ2oOKKXEg608NgU8CBwG+Z6L8Y/
 No=
IronPort-HdrOrdr: A9a23:jQtTyas9KfJUF7KCuQErUY717skDetV00zEX/kB9WHVpmszxra
 6TdZMgpHjJYVcqKRUdcL+7WJVoLUmxyXcX2/h1AV7BZniEhILAFugLhuGO/9SJIVyZygc378
 ZdmsZFZ+EYdWIK7/rH3A==
X-IronPort-AV: E=Sophos;i="5.88,343,1635220800"; 
   d="scan'208";a="65732452"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>
Subject: [PATCH] x86/hvm: Fix boot on systems where HVM isn't available
Date: Fri, 4 Feb 2022 17:34:05 +0000
Message-ID: <20220204173405.22759-1-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

c/s 27a63cdac388 ("x86/HVM: convert remaining hvm_funcs hook invocations to
alt-call") went too far with dropping NULL function pointer checks.

smp_callin() calls hvm_cpu_up() unconditionally.  When the platform doesn't
support HVM, hvm_enable() exits without filling in hvm_funcs, after which the
altcall pass nukes the (now unconditional) indirect call, causing:

  (XEN) ----[ Xen-4.17.0-10.18-d  x86_64  debug=y  Not tainted ]----
  (XEN) CPU:    1
  (XEN) RIP:    e008:[<ffff82d04034bef5>] start_secondary+0x393/0x3b7
  (XEN) RFLAGS: 0000000000010086   CONTEXT: hypervisor
  ...
  (XEN) Xen code around <ffff82d04034bef5> (start_secondary+0x393/0x3b7):
  (XEN)  ff ff 8b 05 1b 84 17 00 <0f> 0b 0f ff ff 90 89 c3 85 c0 0f 84 db fe ff ff
  ...
  (XEN) Xen call trace:
  (XEN)    [<ffff82d04034bef5>] R start_secondary+0x393/0x3b7
  (XEN)    [<ffff82d0402000e2>] F __high_start+0x42/0x60

To make matters worse, __stop_this_cpu() calls hvm_cpu_down() unconditionally
too, so what happen next is:

  (XEN) ----[ Xen-4.17.0-10.18-d  x86_64  debug=y  Not tainted ]----
  (XEN) CPU:    0
  (XEN) RIP:    e008:[<ffff82d04034ab02>] __stop_this_cpu+0x12/0x3c
  (XEN) RFLAGS: 0000000000010046   CONTEXT: hypervisor
  ...
  (XEN) Xen code around <ffff82d04034ab02> (__stop_this_cpu+0x12/0x3c):
  (XEN)  48 89 e5 e8 8a 1d fd ff <0f> 0b 0f ff ff 90 0f 06 db e3 48 89 e0 48 0d ff
  ...
  (XEN) Xen call trace:
  (XEN)    [<ffff82d04034ab02>] R __stop_this_cpu+0x12/0x3c
  (XEN)    [<ffff82d04034ac15>] F smp_send_stop+0xdd/0xf8
  (XEN)    [<ffff82d04034a229>] F machine_restart+0xa2/0x298
  (XEN)    [<ffff82d04034a42a>] F arch/x86/shutdown.c#__machine_restart+0xb/0x11
  (XEN)    [<ffff82d04022fd15>] F smp_call_function_interrupt+0xbf/0xea
  (XEN)    [<ffff82d04034acc6>] F call_function_interrupt+0x35/0x37
  (XEN)    [<ffff82d040331a70>] F do_IRQ+0xa3/0x6b5
  (XEN)    [<ffff82d04039482a>] F common_interrupt+0x10a/0x120
  (XEN)    [<ffff82d04031f649>] F __udelay+0x3a/0x51
  (XEN)    [<ffff82d04034d5fb>] F __cpu_up+0x48f/0x734
  (XEN)    [<ffff82d040203c2b>] F cpu_up+0x7d/0xde
  (XEN)    [<ffff82d0404543d3>] F __start_xen+0x200b/0x2618
  (XEN)    [<ffff82d0402000ef>] F __high_start+0x4f/0x60

which recurses until hitting a stack overflow.  The #DF handler, which resets
its stack on each invocation, loops indefinitely.

Reinstate the NULL function pointer checks for hvm_cpu_{up,down}().

Fixes: 27a63cdac388 ("x86/HVM: convert remaining hvm_funcs hook invocations to alt-call")
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>

RFC.  Not tested yet on the imacted hardware.  It's a Xeon PHI with another
werid thing in need of debugging.  First boot is fine, while second
boot (loading microcode this time) has a problem with vmx.

I wonder if we want to modify the callers to check for HVM being enabled,
rather than leaving the NULL pointer checks in a position where they're liable
to be reaped again.

Also, the #UD handler really should identify 0f 0b 0f ff ff as the
clobbered-altcall sequence, and provide a message to that effect.
---
 xen/arch/x86/include/asm/hvm/hvm.h | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/xen/arch/x86/include/asm/hvm/hvm.h b/xen/arch/x86/include/asm/hvm/hvm.h
index a441cbc22159..2dd08567f730 100644
--- a/xen/arch/x86/include/asm/hvm/hvm.h
+++ b/xen/arch/x86/include/asm/hvm/hvm.h
@@ -553,12 +553,16 @@ static inline void hvm_invlpg(struct vcpu *v, unsigned long linear)
 
 static inline int hvm_cpu_up(void)
 {
-    return alternative_call(hvm_funcs.cpu_up);
+    if ( hvm_funcs.cpu_up )
+        return alternative_call(hvm_funcs.cpu_up);
+
+    return 0;
 }
 
 static inline void hvm_cpu_down(void)
 {
-    alternative_vcall(hvm_funcs.cpu_down);
+    if ( hvm_funcs.cpu_down )
+        alternative_vcall(hvm_funcs.cpu_down);
 }
 
 static inline unsigned int hvm_get_insn_bytes(struct vcpu *v, uint8_t *buf)
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Fri Feb 04 18:34:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 18:34:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265753.459294 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nG3Po-0006XZ-3c; Fri, 04 Feb 2022 18:34:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265753.459294; Fri, 04 Feb 2022 18:34:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nG3Po-0006XS-0Y; Fri, 04 Feb 2022 18:34:36 +0000
Received: by outflank-mailman (input) for mailman id 265753;
 Fri, 04 Feb 2022 18:34:34 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nG3Pm-0006XI-Et; Fri, 04 Feb 2022 18:34:34 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nG3Pm-0007Hc-Be; Fri, 04 Feb 2022 18:34:34 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nG3Pl-0003eR-QW; Fri, 04 Feb 2022 18:34:33 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nG3Pl-0006o4-Po; Fri, 04 Feb 2022 18:34:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=DkC6Eh2PAd0QT/E/OgH1uwk5y19IO9xRTO7dsOKAumI=; b=rYYTafXcsSDw0X1DXqu75/qkdQ
	U4CbXlp2antuO3pN0KLjfuP4VwP20W4sUdC9C3sqDfQvNG+hrcso6P3d3OZo7QO3wuCpJlyUC7gPY
	vRSROI6ffycBOoUzf5x/agkJfMi4aKcL5FY/z/RiqwfvHtgjY3ZNypksg4pFU1UV5Uj0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168006-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 168006: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=bf36dcb2a6272a1ea7eb770878df2cbd455a6679
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 04 Feb 2022 18:34:33 +0000

flight 168006 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168006/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              bf36dcb2a6272a1ea7eb770878df2cbd455a6679
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  574 days
Failing since        151818  2020-07-11 04:18:52 Z  573 days  555 attempts
Testing same since   168006  2022-02-04 04:18:55 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brad Laue <brad@brad-x.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Christophe Fergeau <cfergeau@redhat.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Divya Garg <divya.garg@nutanix.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Emilio Herrera <ehespinosa57@gmail.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Ivan Teterevkov <ivan.teterevkov@nutanix.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Lubomir Rintel <lkundrak@v3.sk>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nicolas Lécureuil <neoclust@mageia.org>
  Nicolas Lécureuil <nicolas.lecureuil@siveo.net>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Rohit Kumar <rohit.kumar3@nutanix.com>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  shenjiatong <yshxxsjt715@gmail.com>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tuguoyi <tu.guoyi@h3c.com>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Vineeth Pillai <viremana@linux.microsoft.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yasuhiko Kamata <belphegor@belbel.or.jp>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 96181 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Feb 04 19:07:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 19:07:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265765.459305 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nG3vS-0001QN-Q3; Fri, 04 Feb 2022 19:07:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265765.459305; Fri, 04 Feb 2022 19:07:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nG3vS-0001QG-Mc; Fri, 04 Feb 2022 19:07:18 +0000
Received: by outflank-mailman (input) for mailman id 265765;
 Fri, 04 Feb 2022 19:07:17 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nG3vQ-0001Q5-W5; Fri, 04 Feb 2022 19:07:17 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nG3vQ-0007qr-Tk; Fri, 04 Feb 2022 19:07:16 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nG3vQ-0005So-Fe; Fri, 04 Feb 2022 19:07:16 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nG3vQ-0005iU-FC; Fri, 04 Feb 2022 19:07:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Qzs/0wzBLhw5xZ37+99y3SpcxnAHgfDGqraYPtp+xRY=; b=VLVjAI940UFhRs18jU3yqnQ2pp
	eQdFajz/Jtglktaa/88vkNKazKy51UNPhsdlMF7IQbCHy4kEmYVHfptrklbUwDHYqoErndVb36o/V
	4QawdHTpkF74ZarG/YQQqVbNnP81NjuVgxLL1XkJKNh+kdlPsr1LK2ntWykYc7spwQio=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168011-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 168011: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=820cc393434097f3b7976acdccbf1d96071d6d23
X-Osstest-Versions-That:
    xen=75cc460a1b8cfd8e5d2c4302234ee194defe4872
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 04 Feb 2022 19:07:16 +0000

flight 168011 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168011/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  820cc393434097f3b7976acdccbf1d96071d6d23
baseline version:
 xen                  75cc460a1b8cfd8e5d2c4302234ee194defe4872

Last test of basis   167999  2022-02-03 13:01:51 Z    1 days
Testing same since   168011  2022-02-04 16:01:44 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Jan Beulich <jbeulich@suse.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   75cc460a1b..820cc39343  820cc393434097f3b7976acdccbf1d96071d6d23 -> smoke


From xen-devel-bounces@lists.xenproject.org Fri Feb 04 19:25:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 19:25:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265778.459316 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nG4Ch-0003mI-FT; Fri, 04 Feb 2022 19:25:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265778.459316; Fri, 04 Feb 2022 19:25:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nG4Ch-0003mB-C3; Fri, 04 Feb 2022 19:25:07 +0000
Received: by outflank-mailman (input) for mailman id 265778;
 Fri, 04 Feb 2022 19:25:06 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nG4Cg-0003m5-DS
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 19:25:06 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nG4Cg-000886-2C; Fri, 04 Feb 2022 19:25:06 +0000
Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.2.73])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nG4Cf-0004a2-ST; Fri, 04 Feb 2022 19:25:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=UmYwFKjuZniQ5W8er5h6lo5XNwJ6ZaWyhLALG9Yakdo=; b=QfHyVAhIx8cF1FKh4Ytv/pnEJu
	yzNaAXgblGuwx1OG9pd59LiSU0xT+/A1hjQ4CElF9Svd8wIBXuBYPsxAVMibRLT+omDcOn7tlWOZ4
	7qHWliLMPaRFiZG59Paxts/wiVjrLUGmef4qdA7/kZkCSLSAEvNY7xSzj8fNyvRS/oro=;
Message-ID: <e91bde3e-dc45-c731-7df6-e0e45039d1b2@xen.org>
Date: Fri, 4 Feb 2022 19:25:03 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.1
Subject: Re: [PATCH v2] docs: document patch rules
To: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
References: <20220203125438.21807-1-jgross@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220203125438.21807-1-jgross@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 03/02/2022 12:54, Juergen Gross wrote:
> +## The commit message
> +
> +The commit message is free text describing *why* the patch is done and
> +*how* the goal of the patch is achieved. A good commit message will describe
> +the current situation, the desired goal, and the way this goal is being
> +achieved. Parts of that can be omitted in obvious cases.
> +
> +In case additional changes are done in the patch (like e.g. cleanups), those
> +should be mentioned.
> +
> +When referencing other patches (e.g. `similar to patch xy ...`) those
> +patches should be referenced via their commit id (at least 12 digits)
> +and the patch subject, if the very same patch isn't referenced by the
> +`Fixes:` tag, too:
> +
> +    Similar to commit 67d01cdb5518 ("x86: infrastructure to allow converting
> +    certain indirect calls to direct ones") add ...
> +
> +The following ``git config`` settings can be used to add a pretty format for
> +outputting the above style in the ``git log`` or ``git show`` commands:
> +
> +        [core]
> +                abbrev = 12
> +        [pretty]
> +                fixes = Fixes: %h (\"%s\")
> +
> +Lines in the commit message should not exceed 75 characters, except when

I was under the impression that commit message should be wrap to 72 
characters. This is because tools like "git log" would indent the commit 
message by 8 characters.

> +copying error output directly into the commit message.
> +
> +## Tags
> +
> +Tags are entries in the form
> +
> +    Tag: something
> +
> +In general tags are added in chronological order. So a `Reviewed-by:` tag
> +should be added **after** the `Signed-off-by:` tag, as the review happened
> +after the patch was written.
> +
> +Do not split a tag across multiple lines, tags are exempt from the
> +"wrap at 75 columns" rule in order to simplify parsing scripts.

This would need to be adjusted depending on the answer above.

> +
> +### Origin:
> +
> +Xen has inherited some source files from other open source projects. In case
> +a patch modifying such an inherited file is taken from that project (maybe in
> +modified form), the `Origin:` tag specifies the source of the patch:
> +
> +    Origin: <repository-URL> <commit-id>

NIT: Likes you did for Fixes tags, can you make clear that the commit id 
should be the first 12 characters? So the line...

> +
> +E.g.:
> +
> +    Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git f093b08c47b3

... doesn't get horribly long.

> +
> +All tags **above** the `Origin:` tag are from the original patch (which
> +should all be kept), while tags **after** `Origin:` are related to the
> +normal Xen patch process as described here.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Feb 04 20:31:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 20:31:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265787.459327 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nG5F6-00026H-Cu; Fri, 04 Feb 2022 20:31:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265787.459327; Fri, 04 Feb 2022 20:31:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nG5F6-00026A-9j; Fri, 04 Feb 2022 20:31:40 +0000
Received: by outflank-mailman (input) for mailman id 265787;
 Fri, 04 Feb 2022 20:31:39 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TTBG=ST=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nG5F5-000264-Bw
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 20:31:39 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 719347c0-85f9-11ec-8eb8-a37418f5ba1a;
 Fri, 04 Feb 2022 21:31:36 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 719347c0-85f9-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644006696;
  h=from:to:cc:subject:date:message-id:mime-version:
   content-transfer-encoding;
  bh=082Vz14r1I6zxmaXpv4d2SFEfJ6SAmTaBPQRnb2qKFg=;
  b=V2S8Qrs3wyVQb7xkon9z6Udd5YonpOlpii2CqsKIRGHjIvd3uF6pTHer
   3C5NOPU013ORItcrZ4FwIl08s9FcTWWKjxY6P7bPf+sNO7GCATK0/YQIh
   wWq9u0lkwbWUp+czGFyCLQNCkpqdrOnq5JP+ETcKr+CAyoMJGt1dVjQph
   A=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: 8G6U1+/d5W+/dXI6+OeobctVbrMFSOCzWNsLdRH/r4BHBnxquu3Fl88+wAij+jYXy5xZrI6AR4
 gFPn0d+L8MjdKsDj0Jb/I+9AyD7yNYa41l990Ki6z55XhesAsX45z8pNMQCIcX4AXNkSC7mbOg
 JQAboNz1XGKacHo+WoHY5fnpRVvySwqcJoig3ikVDjAtQ9KoH4T6LmCwrPw/r/MTln4sVovgF9
 2NI0uGLvhRvMlh/0LGoNueDYiPoxRf10POg60YA4h6TBTpkzT/R5xoZA9Roh8LuPq9+znCIMRs
 y/1b1iK3PYZqPAky50azGGWc
X-SBRS: 5.1
X-MesageID: 63449691
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:jeRGMKLaWjI0vGW4FE+RlJMlxSXFcZb7ZxGr2PjKsXjdYENShWEAx
 2IdWG+OOf7cZmKje9AlO4y1pEkDscTVzdZiQAZlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokcxIn5BC5C5xZVG/fjgqoHUVaiUakideSc+EH170Ug7x7Zi6mJVqYPR7z2l6
 IuaT/L3YDdJ6xYsWo7Dw/vewP/HlK2aVAIw5jTSV9gS1LPtvyB94KYkDbOwNxPFrrx8RYZWc
 QphIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbrGvaUXe345iXMfwZ3u7hB3QxOhr2
 ssQh6W8VC43A/XTs/U8UgdhRnQW0a1uoNcrIFC6uM2XiUbHb2Ht07NlC0Re0Y8wo7gtRzsUr
 LpBdW5LPkvra+GemdpXTsFFgMg5IdatF4QYonx6lhnSDOo8QICFSKLPjTNd9Glr2pwfQ6eHD
 yYfQWpuNS7DYjAIBncGCsI5meSi3ljxcxQN/Tp5ooJoujOOnWSdyoPFMsfRe9GMbdVYmACfv
 G2u13v9KgEXMpqY0zXt2nihnPPVlCX3HocbDqSl9+VCiUeWgGcUDXU+a1y/pvWoj1+kbPhWI
 UcU5ykGoLA78QqgSdyVdz+SrWOAvxUcc8FNCOB84waIooLE7gDcCmUaQzppbN09qNRwVTEsz
 kWOnd7iGXpoqrL9YWmG6r6eoDe2OC4UBWwPfykJSU0C+daLiIM8lBXUVf54DbW4yNbyHFnNL
 yui9XZkwe9J1IhSivv9rQuvby+QSobhF1UN/BfJA1Cc4h5QerP9eKe5yFnF1KMVRGqGdWWps
 H8BksmYyekBC5CRiSCAKNkw8KGVC+Wta2OF3wM2d3U133H0oiP4I9gMiN1rDBoxaq45lSnVj
 Fg/UO+7zLtaJzOUYKB+eOpd4Ox6nPG7RbwJuh05B+eig6SdlifapEmChmbKhggBdXTAd4llY
 v93lu73VR4n5VxPlmbeegvk+eZDKtoC7W3SX4vn6B+szKCTYnWYIZ9cbgfVPrtksv7V+1qOm
 zq6Cyds408EOAEZSnKPmbP/0HhQdSRrbXwIg5A/mhG/zvpORzh6Vq65LUIJcI15haVF/tokD
 VnmMnK0PGHX3CWdQS3TMygLQOq2Af5X8CJqVQRxbA3A8yVyPu6HsvxFH7NpJuZPyQCW5aMtJ
 xXzU57bWaonp/Wu02l1UKQRW6Q7L0Xw3VvVZXL/CNX9FrY5LzH0FhbfVlOH3EEz4uCf7KPSe
 pWsiVHWR4QtXQNnAJqEYf6j1Qrp73MchPhzTw3DJdwKIBfg941jKirQiP4rIp5TdUWfl2XCj
 wvGUw0FoeTtopMu9IWbj66zsIr0QfB1GVBXHjeH4O/uZzXa5Geq3aRJTP2MIWLGTGrx9aj7P
 bdVwvjwPecphlFPt4YgQb9nwbhnv4nkpqNAzxQiF3LONgz5BrRlK3iA/M9OqqwSmeMJ5VroA
 hqCo4AIN6+INcXpFE8qCDAkNunTh+sJnjTy7OguJBmo7iFA47faA15ZOAOBiXIBIeItYp8l2
 +oopOUf9xe71kgxKt+Dgy1ZqzaMI3gHX/l1v50WGta22A8iy1UEap3AEC7mppqIbowUYEUtJ
 zaVgovEhqhdmRWeIyZiSyCV0LoPn4kKtTBL0EQGdgaAldfyj/Mq2AFcrGYsRQNPwxQbi+9+N
 wCH7aGuyXliK9uwuPV+Yg==
IronPort-HdrOrdr: A9a23:Gj6SPqxIG5ls4WEMgE1jKrPwIL1zdoMgy1knxilNoRw8SKKlfq
 eV7ZMmPH7P+VIssR4b+exoVJPtfZq+z+8R3WByB8bAYOCOggLBR+sO0WKL+UyHJ8SUzI9gPM
 lbHJSWcOeAb2RHsQ==
X-IronPort-AV: E=Sophos;i="5.88,343,1635220800"; 
   d="scan'208";a="63449691"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>, Juergen Gross
	<jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
	<julien@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, "Bertrand
 Marquis" <bertrand.marquis@arm.com>
Subject: [PATCH] xen/smp: Speed up on_selected_cpus()
Date: Fri, 4 Feb 2022 20:31:15 +0000
Message-ID: <20220204203115.13290-1-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

cpumask_weight() is a horribly expensive way to find if no bits are set, made
worse by the fact that the calculation is performed with the global call_lock
held.

Switch to using cpumask_empty() instead, which will short circuit as soon as
it find any set bit in the cpumask.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>
CC: Juergen Gross <jgross@suse.com>
CC: Stefano Stabellini <sstabellini@kernel.org>
CC: Julien Grall <julien@xen.org>
CC: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
CC: Bertrand Marquis <bertrand.marquis@arm.com>

I have not done performance testing, but I would be surprised if this cannot
be measured on a busy or large box.
---
 xen/common/smp.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/xen/common/smp.c b/xen/common/smp.c
index 781bcf2c246c..a011f541f1ea 100644
--- a/xen/common/smp.c
+++ b/xen/common/smp.c
@@ -50,8 +50,6 @@ void on_selected_cpus(
     void *info,
     int wait)
 {
-    unsigned int nr_cpus;
-
     ASSERT(local_irq_is_enabled());
     ASSERT(cpumask_subset(selected, &cpu_online_map));
 
@@ -59,8 +57,7 @@ void on_selected_cpus(
 
     cpumask_copy(&call_data.selected, selected);
 
-    nr_cpus = cpumask_weight(&call_data.selected);
-    if ( nr_cpus == 0 )
+    if ( cpumask_empty(&call_data.selected) )
         goto out;
 
     call_data.func = func;
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Fri Feb 04 21:11:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 21:11:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265795.459338 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nG5rw-0006DQ-Cs; Fri, 04 Feb 2022 21:11:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265795.459338; Fri, 04 Feb 2022 21:11:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nG5rw-0006DJ-9i; Fri, 04 Feb 2022 21:11:48 +0000
Received: by outflank-mailman (input) for mailman id 265795;
 Fri, 04 Feb 2022 21:11:46 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=6K1X=ST=xilinx.com=stefanos@srs-se1.protection.inumbo.net>)
 id 1nG5ru-0006Ct-DA
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 21:11:46 +0000
Received: from NAM12-DM6-obe.outbound.protection.outlook.com
 (mail-dm6nam12on20611.outbound.protection.outlook.com
 [2a01:111:f400:fe59::611])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0bfc378f-85ff-11ec-8eb8-a37418f5ba1a;
 Fri, 04 Feb 2022 22:11:44 +0100 (CET)
Received: from BN9PR03CA0852.namprd03.prod.outlook.com (2603:10b6:408:13d::17)
 by CH0PR02MB7881.namprd02.prod.outlook.com (2603:10b6:610:ec::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Fri, 4 Feb
 2022 21:11:38 +0000
Received: from BN1NAM02FT044.eop-nam02.prod.protection.outlook.com
 (2603:10b6:408:13d:cafe::68) by BN9PR03CA0852.outlook.office365.com
 (2603:10b6:408:13d::17) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12 via Frontend
 Transport; Fri, 4 Feb 2022 21:11:38 +0000
Received: from xsj-pvapexch01.xlnx.xilinx.com (149.199.62.198) by
 BN1NAM02FT044.mail.protection.outlook.com (10.13.2.155) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.4951.12 via Frontend Transport; Fri, 4 Feb 2022 21:11:37 +0000
Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by
 xsj-pvapexch01.xlnx.xilinx.com (172.19.86.40) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2176.14; Fri, 4 Feb 2022 13:11:37 -0800
Received: from smtp.xilinx.com (172.19.127.96) by
 xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id
 15.1.2176.14 via Frontend Transport; Fri, 4 Feb 2022 13:11:37 -0800
Received: from [10.23.122.228] (port=52490 helo=ubuntu-20.04.2-arm64.shared)
 by smtp.xilinx.com with esmtp (Exim 4.90)
 (envelope-from <stefano.stabellini@xilinx.com>)
 id 1nG5rl-000H0f-H4; Fri, 04 Feb 2022 13:11:37 -0800
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0bfc378f-85ff-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=axUw5Lv6ohylH+zcN+33MWvQtd4+Firg7qYDkA57iIQZKn2XXK0WKDl0elAp5GTMmHUohTwt29kozU5R+w7tLI3R9+GxP3sZss42w5ImoiPGGfz78ARbaZbHFRiaomSnkEZhhvm4+HxvyxCGGdHMEFHOy/16l4d9AxJcyF9yoieQlWVt6Iu9+ZBBiD264JYH17J5wQs0AemOg5lqiTFBCXcpHwfDUksDMNpTFa7C921bods4y+H6nl6klHPX4yiLiJt+dKK0E6kAaBAoC2Ib8PdoHOWWPCmrLW4j/EW9rWIuGNlYgmNKk6cFIxZDINDqo3A44r8h7JVxzTkU/4vSiA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=8to3lxzFcc9fGY7nC5OQK6nQEmZeZxr61EA19JNvnXM=;
 b=BuPZ8qyMglmDKO0LQy7uo7ITruXD0DKQ1rYyx3n0jIOPuSAlmRY5XeaX4jmIQgGOYAMWMEukrDQa2YlsrAicHFRR7ZEc1ew834VlmTvNOxsLXEF0AkNDk5ZQf7N8+ib+wV2SUdYXWGJzQUha3sNekKzSxoaYzox3Q18pnOKalzodLHxOTT1z0ct08y4ltF0xGF7Sb88ZuiL+FWZSZsgiiLfGHzHSr8KNj597FTkeyP/r8HtiQwBuyYMXIWhxFNDLkTrTkfE3TvrJD114cUnmqmaLtpKk6IV7p9JKftQHT8n6qD3DyCkjgyg/f4iEAY2uQlc7pC6/z754jqiTfLziWQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 149.199.62.198) smtp.rcpttodomain=walle.cc smtp.mailfrom=xilinx.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=8to3lxzFcc9fGY7nC5OQK6nQEmZeZxr61EA19JNvnXM=;
 b=nTtIeUJEY71VtLL8ciiAAUFKu8n0YtlxEcOPzjfRzotrwe+B2r00aC4vJtCiOIas+P3hc5I8Dd9LPHz86jxjNCAtt7R7UgGIrNzQlgjDVO5iCk4wKdYtpqx+mk8FlGrl4qx+tLVk1mYgc984QXKpzMYAJMyuEL9nB4uO4G2klL8=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198)
 smtp.mailfrom=xilinx.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=xilinx.com;
Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates
 149.199.62.198 as permitted sender) receiver=protection.outlook.com;
 client-ip=149.199.62.198; helo=xsj-pvapexch01.xlnx.xilinx.com;
Date: Fri, 4 Feb 2022 13:11:37 -0800
From: Stefano Stabellini <stefano.stabellini@xilinx.com>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Michael Walle <michael@walle.cc>
CC: <stefano.stabellini@xilinx.com>, <Bertrand.Marquis@arm.com>,
	<Zhiqiang.Hou@nxp.com>, <brucea@xilinx.com>, <cornelia.bruelhart@zal.aero>,
	<julien@xen.org>, <leo.krueger@zal.aero>, <oleksandr_andrushchenko@epam.com>,
	<peng.fan@nxp.com>, <xen-devel@lists.xenproject.org>
Subject: Re: Xen data from meta-virtualization layer
In-Reply-To: <20220204135814.1033356-1-michael@walle.cc>
Message-ID: <alpine.DEB.2.22.394.2202041256040.4074808@ubuntu-linux-20-04-desktop>
References: <alpine.DEB.2.21.2011241743490.7979@sstabellini-ThinkPad-T480s> <20220204135814.1033356-1-michael@walle.cc>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: edc270d0-b2dc-4dc8-3629-08d9e822eea9
X-MS-TrafficTypeDiagnostic: CH0PR02MB7881:EE_
X-Microsoft-Antispam-PRVS:
	<CH0PR02MB788111846CC217013F053636A0299@CH0PR02MB7881.namprd02.prod.outlook.com>
X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	WNda5XoKS7m6Czcx2R0udCs+4hwyUke1Fyw5uzyWah2OtGNiA/keYFBlgW+WeBsfd5iCxfJl4W9jE91QbyzzoISQUM81cr32wD2smpubC33eE8kG01HNdSi/qb2Tq8t5tZVbThw1QwYAvLPL20bqGi/SfsR1eC7K11xIOPpXWyXnf2NzSEsptac3m9vY8eZ2ryW3XCJK1r4fokTmNISzYcUScfj/WgeYSDDKNm0SX6Pd2oSdxv2ip4+59pd/zh2ZpsDE2adBspAc4xjLPJyGr5/NtKtnNEPWeSMwcHtP/7WWmOI+Os57AdVIhyaoV6kecVADuRCNNo2yNdEU70YDzgkAJD9zb/VkWfhYvsFIaTDDeR8x87HLZM0dV9TqdUjSLO5DjxSEhKYn0IH89weBqf54fmgQOjkxmOF7vr8TW5AFAJZlS4vnZhhaqmKoFsrpL29NXPvNvHEHLLKTrnUhSfNpJb4Fc24JV+/wrbmsRNe8WX0oq+oQL691APa8zlofoM+4hN8cHMyqXc65FIZEDUdhHgLh6Wwf1YsznAjqlIhiIN6amgiXUz0f7ZJv46ssoJ7MaCJk7DQU15YTCVOy9eN9eGCykcGDGTqDPeEdXZDzsv742zchQnhv2om9Z3YXSOkRIG8UMg/x/f1xSIwV+g==
X-Forefront-Antispam-Report:
	CIP:149.199.62.198;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:xsj-pvapexch01.xlnx.xilinx.com;PTR:unknown-62-198.xilinx.com;CAT:NONE;SFS:(13230001)(4636009)(7916004)(46966006)(36840700001)(5660300002)(70206006)(2906002)(47076005)(44832011)(9686003)(36860700001)(508600001)(336012)(426003)(82310400004)(186003)(26005)(33716001)(316002)(8936002)(4326008)(356005)(6916009)(9786002)(7636003)(54906003)(8676002)(70586007);DIR:OUT;SFP:1101;
X-OriginatorOrg: xilinx.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Feb 2022 21:11:37.8828
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: edc270d0-b2dc-4dc8-3629-08d9e822eea9
X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch01.xlnx.xilinx.com]
X-MS-Exchange-CrossTenant-AuthSource:
	BN1NAM02FT044.eop-nam02.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR02MB7881

On Fri, 4 Feb 2022, Michael Walle wrote:
> > In regards to the reserved-memory regions, maybe we are not seeing them
> > because Leo posted the host device tree, not the one passed at runtime
> > from u-boot to Linux?
> > 
> > If so, Leo, could you please boot Linux on native (no Xen) and get the
> > device tree from there at runtime using dtc -I fs -O dts
> > /proc/device-tree ?
> > 
> > 
> > However, the name of the reserved-memory region created by u-boot seems
> > to be "lpi_rd_table". I cannot find any mentions of lpi_rd_table in the
> > Linux kernel tree either.
> > 
> > Zhiqiang, Leo is trying to boot Xen on sAL28. Linux booting on Xen
> > throws errors in regards to GIC/ITS initialization. On other hardware
> > Xen can use and virtualize GICv3 and ITS just fine. Could you please
> > explain what is different about sAL28 and how Xen/Linux is expected to
> > use the lpi_rd_table reserved-memory region?
> 
> I actually stumbled across this thread after trying out Xen myself. I'm
> using lastest vanilla u-boot (with pending PSCI patches), vanilla kernel
> and vanilla Xen.
> 
> So far I've discovered, that xen complains that it cannot route IRQ64 to
> dom0. That is because on the LS1028A there is a dual UART (two 16550
> with one shared interrupt) and xen takes the first UART and then tries
> to map the interrupt of the second UART to linux. For now, I don't know
> how this is solved correctly. As a quick hack, I removed the second uart
> node from the device tree.

This is an interesting problem. Removing the second UART is a good
workaround for now as there is no obvious solution I think.


> But what is more severe is that the iommu isn't set up correctly. I'm
> getting the following faults:
> 
> (XEN) smmu: /soc/iommu@5000000: Unexpected global fault, this could be serious
> (XEN) smmu: /soc/iommu@5000000: 	GFSR 0x80000002, GFSYNR0 0x00000000, GFSYNR1 0x0000042a, GFSYNR2 0x00000000
> 
> If I decode it correctly, the streamid should be 0x2a which would be one
> of the PCI devices on the internal root complex. Probably the network
> card.

Yes there is DMA transaction with an "unknown" StreamID. I think the
StreamID is 0x42a. It means that there is a DMA master on the board with
StreamID 0x42a that is either:

- not described in device tree
- described in device tree with a different StreamID
- the right StreamID is described device tree, but it is not picked up
  by Xen


> This is the first developer experience with Xen, so please bear with me
> :) It seems that Xen doesn't add the master to the IOMMU. To me it seems
> that only devices with a 'iommus' dt property are added. But in case of
> PCI devices the parent only has a iommu-map property.
> 
> And it makes me wonder why Leo has an almost working setup. Maybe I'm
> missing some patches though.

Xen 4.16 is able to parse StreamID in the "iommus" property and also
"mmu-masters" property. But It is not able to parse the "iommu-map"
property yet. So if 0x42a is described in device tree using "iommu-map"
then the error makes sense.

A simple solution is to replace iommu-map with iommus in device tree.
It is possible that someone in CC to this email might already have a
patch to introduce parsing of iommu-map in Xen.


From xen-devel-bounces@lists.xenproject.org Fri Feb 04 21:54:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 21:54:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265804.459349 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nG6XP-0001tA-Aa; Fri, 04 Feb 2022 21:54:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265804.459349; Fri, 04 Feb 2022 21:54:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nG6XP-0001t3-7G; Fri, 04 Feb 2022 21:54:39 +0000
Received: by outflank-mailman (input) for mailman id 265804;
 Fri, 04 Feb 2022 21:54:37 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=lKAq=ST=gmail.com=dunlapg@srs-se1.protection.inumbo.net>)
 id 1nG6XN-0001sx-Ap
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 21:54:37 +0000
Received: from mail-yb1-xb35.google.com (mail-yb1-xb35.google.com
 [2607:f8b0:4864:20::b35])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 09a01fb6-8605-11ec-8f75-fffcc8bd4f1a;
 Fri, 04 Feb 2022 22:54:34 +0100 (CET)
Received: by mail-yb1-xb35.google.com with SMTP id e145so2502240yba.12
 for <xen-devel@lists.xenproject.org>; Fri, 04 Feb 2022 13:54:34 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 09a01fb6-8605-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=umich.edu; s=google-2016-06-03;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=5Q48td1+7MKpQbIgDJVnLJAd/H0+HKBR1pRInqASI4A=;
        b=Injl1uAsWm5OJfJE6bmaYhuGcIE1vMbLZ3erW8JMLSbEBRtWFARQfstLmtzm/rhyYn
         O34f9pJk0EHAqTuI2IYCSHXPmlRME4krElDVMS4ZNat2NnTizTfimDcz8SzsngdiTfj8
         rRJTYBzu5fFyOZNGl5v1oeyeHmHalulwLi0oyBCFHYOS/tn7YZpLcGnsDQ8yPWrLVZii
         +yXzP0dq3tsB+3NnFPwYDbB5RmoxviVZ8W465sDT9dYwmcbcyeSgBpOuWLoRjkqVR6Pk
         0BfeikMeDpkK7q6iGeLp8lipUwJ9AZbWb2YFz7iF0atKO/1OuX5oHv+s9OnU1J0DMbVQ
         nf6g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=5Q48td1+7MKpQbIgDJVnLJAd/H0+HKBR1pRInqASI4A=;
        b=Wfw0QV2kp5OGTSH7kIXCJSLRawnlJE+GDCK9tOjqMW5Nwc/GO3HLAowInHBIIow4RX
         flTefoKkinpjKMNgQoNUolBsrIl9OlA43g4qBb/58Lnw3rrhEvOJ/YtQVxB6JeXqO/Wo
         HomJih27hsJRAe6hN7PdZe2mTUITk+Bxroabhw5Z/Py5XZEAx7C1fI22MPiDWCTX+JeT
         hkalP3yrbbs7q+A8kyjRB8sgPOB62/MkfrdTLzlsyhNShB8WBG1BIiKWL1Vh7WRfbOpt
         606KQ648XLE06c5hrWDZorUVT9ZNiTqAZV2XuYr5nfE5Kw3YVYFL7fqLADMlSEPalgVv
         SnbQ==
X-Gm-Message-State: AOAM533xP8SVOTEgP/5/ovOt/Eg64V5fSsAVmJKOF/EFRpTk7Pki+9/4
	JObvIOd45LrKenqvIaNrzB/UzaOT3G+JqnI4lNU=
X-Google-Smtp-Source: ABdhPJzpzOmNXzqU/dCFw5FCRBjRR2LsKmI0aVpimy0R3IP8aRGv6YGfj5xmlSflnxMUiLRyB5WGlZeUzvAODGV/p9U=
X-Received: by 2002:a05:6902:1543:: with SMTP id r3mr1262448ybu.507.1644011673202;
 Fri, 04 Feb 2022 13:54:33 -0800 (PST)
MIME-Version: 1.0
References: <d1fd572d-5bfe-21d8-3b50-d9b0646ce2f0@suse.com> <fc340862-6842-3db4-1093-d2df44c1aa9c@suse.com>
In-Reply-To: <fc340862-6842-3db4-1093-d2df44c1aa9c@suse.com>
From: George Dunlap <dunlapg@umich.edu>
Date: Fri, 4 Feb 2022 21:54:21 +0000
Message-ID: <CAFLBxZa3qZ0+1MHxULZCciFPyYppv12TTe=LjcEyJAEr-KJRsg@mail.gmail.com>
Subject: Re: [PATCH 01/16] x86/P2M: rename p2m_remove_page()
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
	Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>, 
	=?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>, 
	George Dunlap <george.dunlap@citrix.com>
Content-Type: multipart/alternative; boundary="000000000000c9b60a05d7384bd0"

--000000000000c9b60a05d7384bd0
Content-Type: text/plain; charset="UTF-8"

On Mon, Jul 5, 2021 at 5:05 PM Jan Beulich <jbeulich@suse.com> wrote:

> This is in preparation to re-using the original name.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>

Hey Jan,

This series overall looks good; thanks for taking this on.

Functionally this patch looks good; just one question...

--- a/xen/arch/x86/mm/p2m.c
> +++ b/xen/arch/x86/mm/p2m.c
> @@ -788,8 +788,8 @@ void p2m_final_teardown(struct domain *d
>  #ifdef CONFIG_HVM
>
>  static int __must_check
> -p2m_remove_page(struct p2m_domain *p2m, gfn_t gfn, mfn_t mfn,
> -                unsigned int page_order)
> +p2m_remove_entry(struct p2m_domain *p2m, gfn_t gfn, mfn_t mfn,
> +                 unsigned int page_order)
>

One question that's naturally raised for both this and the following patch
is, what is the new naming "scheme" for these renamed functions, and how do
they relate to the old scheme?

Overall it seems like the intention is that "guest_physmap_..." can be
called on a domain which may be PV or HVM, while "p2m_..." should only be
called on HVM domains.

There's also "..._entry" vs "..._page".  Is the p2m_remove_page /
p2m_remove_entry distinction have a meaning, and is it the same meaning as
guest_physmap_add_page / guest_physmap_add_entry?  Or is it similar to
p2m_init_nestedp2m / p2m_nestedp2m_init -- we need both functions and
don't want to make the names longer?

 -George

--000000000000c9b60a05d7384bd0
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Mon, Jul 5, 2021 at 5:05 PM Jan Be=
ulich &lt;<a href=3D"mailto:jbeulich@suse.com">jbeulich@suse.com</a>&gt; wr=
ote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px=
 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">This is in =
preparation to re-using the original name.<br>
<br>
Signed-off-by: Jan Beulich &lt;<a href=3D"mailto:jbeulich@suse.com" target=
=3D"_blank">jbeulich@suse.com</a>&gt;<br></blockquote><div><br></div><div>H=
ey Jan,</div><div><br></div><div>This series overall looks good; thanks for=
 taking this on.</div><div><br></div><div>Functionally this patch looks goo=
d; just one question...<br></div><br><blockquote class=3D"gmail_quote" styl=
e=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);paddin=
g-left:1ex">
--- a/xen/arch/x86/mm/p2m.c<br>
+++ b/xen/arch/x86/mm/p2m.c<br>
@@ -788,8 +788,8 @@ void p2m_final_teardown(struct domain *d<br>
=C2=A0#ifdef CONFIG_HVM<br>
<br>
=C2=A0static int __must_check<br>
-p2m_remove_page(struct p2m_domain *p2m, gfn_t gfn, mfn_t mfn,<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 unsigned int page_=
order)<br>
+p2m_remove_entry(struct p2m_domain *p2m, gfn_t gfn, mfn_t mfn,<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0unsigned int=
 page_order)<br></blockquote><div><br></div><div>One question that&#39;s na=
turally raised for both this and the following patch is, what is the new na=
ming &quot;scheme&quot; for these renamed functions, and how do they relate=
 to the old scheme?</div><div><br></div><div>Overall it seems like the inte=
ntion is that &quot;guest_physmap_...&quot; can be called on a domain which=
 may be PV or HVM, while &quot;p2m_...&quot; should only be called on HVM d=
omains.</div><div><br></div><div>There&#39;s also &quot;..._entry&quot; vs =
&quot;..._page&quot;.=C2=A0 Is the p2m_remove_page / p2m_remove_entry disti=
nction have a meaning, and is it the same meaning as guest_physmap_add_page=
 / guest_physmap_add_entry?=C2=A0 Or is it similar to p2m_init_nestedp2m / =
p2m_nestedp2m_init -- we need both functions and=C2=A0 don&#39;t want to ma=
ke the names longer?</div><div><br></div><div>=C2=A0-George</div><br></div>=
</div>

--000000000000c9b60a05d7384bd0--


From xen-devel-bounces@lists.xenproject.org Fri Feb 04 22:08:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 22:08:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265814.459359 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nG6kS-0003V1-Li; Fri, 04 Feb 2022 22:08:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265814.459359; Fri, 04 Feb 2022 22:08:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nG6kS-0003Uu-Io; Fri, 04 Feb 2022 22:08:08 +0000
Received: by outflank-mailman (input) for mailman id 265814;
 Fri, 04 Feb 2022 22:08:07 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=lKAq=ST=gmail.com=dunlapg@srs-se1.protection.inumbo.net>)
 id 1nG6kR-0003Uo-9J
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 22:08:07 +0000
Received: from mail-yb1-xb32.google.com (mail-yb1-xb32.google.com
 [2607:f8b0:4864:20::b32])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ed97617c-8606-11ec-8eb8-a37418f5ba1a;
 Fri, 04 Feb 2022 23:08:06 +0100 (CET)
Received: by mail-yb1-xb32.google.com with SMTP id e145so2582461yba.12
 for <xen-devel@lists.xenproject.org>; Fri, 04 Feb 2022 14:08:06 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ed97617c-8606-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=umich.edu; s=google-2016-06-03;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=PePstMPhLDPHoa5O9/0mJe7sY71Rc1ra8CN2ByZjf2c=;
        b=Ne8BMSKESMSnGjk1sMAS+ZMHnDUOGwVbV3MyGXtkF1+w2SQ3HiXIyS1smE7smJ16hN
         nQmuGD6CvOVoXBzPudCeCjLFzZ7edsTDVQ8h+YIZ0KSrBJ4H0zjcEH3MMZa1rDTauk5g
         wNYba5onIxc9n9kQPXkM4JCGd5jB2097Bl7jOAeh7F4pOeQPWjBJCEJhM6l1RPSKtmJB
         r+AF2cnh+M0D20zW+B8EufoFHuxnglWI60HzT5J9pOowz4s8Jy/L0W5q5zXhEigprfCs
         GxtpQRAR0A3O7CIQTQ2QnJt5rd45W/Z7dXv9ulEp+C306uyDjq4QRTCaCGkUilX1+3UR
         DlPg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=PePstMPhLDPHoa5O9/0mJe7sY71Rc1ra8CN2ByZjf2c=;
        b=yQd5fqd7uV+c6O+dmYxjUF4A90ie/BNd9yxP1eKPL+iZPYjQ6ra4qsZKQRg1G3/o8T
         LkJOwQ+F6VOfBpEPMI805p9mNx0MQe/8v+UotL1Rp9Bg7elBSgI+aWB30Q9rJTI6p+1O
         XJBHAkeDMzatbH41/LkllZBfqsP7WOxY78R0YTOpJ8i3cnw2GF9hvFeGuvTw9XJ+ldow
         ngw/yDiDTW2gVGmR/0beD8jE+aeHQm9yAnkE7H8nV74+j5LtwUajAaqsW4MPF5u/4DAP
         ugkHQ9vqpmqB4Db8hFZCzcwaZOQvs7cXDjwbxGrf5bC+HwqoplWOxtuK9xqa2Aq+eRkL
         cFhg==
X-Gm-Message-State: AOAM530WtKy0G5/gwefkQ4CLbNhKpd9NsyRekKzeXNdxSXCyFOoLTLtt
	B5ICDAQPQpg+WkPgUqoRoj6f2xNTt6M5PPwpmlc=
X-Google-Smtp-Source: ABdhPJytghMeG7tLjYqm+rceZFiHzEcwQgSOGCPAXoXSesI2v+vozrGBhdT9krnsadjttgu4AoIzMOw0vYOHw5NUtXQ=
X-Received: by 2002:a0d:e615:: with SMTP id p21mr1142793ywe.122.1644012485217;
 Fri, 04 Feb 2022 14:08:05 -0800 (PST)
MIME-Version: 1.0
References: <d1fd572d-5bfe-21d8-3b50-d9b0646ce2f0@suse.com> <eaf6f63d-1122-f52d-1147-cda40a9c3387@suse.com>
In-Reply-To: <eaf6f63d-1122-f52d-1147-cda40a9c3387@suse.com>
From: George Dunlap <dunlapg@umich.edu>
Date: Fri, 4 Feb 2022 22:07:54 +0000
Message-ID: <CAFLBxZZQgfYZ=OcyhRedPvK0CZxjrHY-5kRp4EOpJ2LEFL09yg@mail.gmail.com>
Subject: Re: [PATCH 02/16] x86/P2M: introduce p2m_{add,remove}_page()
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
	Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>, 
	=?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>, 
	Paul Durrant <paul@xen.org>, George Dunlap <george.dunlap@citrix.com>
Content-Type: multipart/alternative; boundary="00000000000030128405d7387cbe"

--00000000000030128405d7387cbe
Content-Type: text/plain; charset="UTF-8"

On Mon, Jul 5, 2021 at 5:06 PM Jan Beulich <jbeulich@suse.com> wrote:

> p2m_add_page() is simply a rename from guest_physmap_add_entry().
> p2m_remove_page() then is its counterpart, despite rendering
> guest_physmap_remove_page(). This way callers can use suitable pairs of
> functions (previously violated by hvm/grant_table.c).
>

Obviously this needs some clarification.  While we're here, I find this a
bit confusing; I tend to use the present tense for the way the code is
before the patch, and the imperative for what the patch does; so Id' say:

Rename guest_physmap_add_entry() to p2m_add_page; make
guest_physmap_remove_page a wrapper with p2m_remove_page.  That way callers
can use suitable pairs...

Other than that looks good.

 -George

--00000000000030128405d7387cbe
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Mon, Jul 5, 2021 at 5:06 PM Jan Be=
ulich &lt;<a href=3D"mailto:jbeulich@suse.com">jbeulich@suse.com</a>&gt; wr=
ote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px=
 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">p2m_add_pag=
e() is simply a rename from guest_physmap_add_entry().<br>
p2m_remove_page() then is its counterpart, despite rendering<br>
guest_physmap_remove_page(). This way callers can use suitable pairs of<br>
functions (previously violated by hvm/grant_table.c).<br></blockquote><div>=
<br></div><div>Obviously this needs some clarification.=C2=A0 While we&#39;=
re here, I find this a bit confusing; I tend to use the present tense for t=
he way the code is before the patch, and the imperative for what the patch =
does; so Id&#39; say:</div><div><br></div><div>Rename guest_physmap_add_ent=
ry() to p2m_add_page; make guest_physmap_remove_page a wrapper with p2m_rem=
ove_page.=C2=A0 That way callers can use suitable pairs...<br></div><div>=
=C2=A0</div>Other than that looks good.<br></div><div class=3D"gmail_quote"=
><br></div><div class=3D"gmail_quote">=C2=A0-George<br></div></div>

--00000000000030128405d7387cbe--


From xen-devel-bounces@lists.xenproject.org Fri Feb 04 22:14:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 22:14:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265822.459371 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nG6qH-0004t6-C4; Fri, 04 Feb 2022 22:14:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265822.459371; Fri, 04 Feb 2022 22:14:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nG6qH-0004sz-7i; Fri, 04 Feb 2022 22:14:09 +0000
Received: by outflank-mailman (input) for mailman id 265822;
 Fri, 04 Feb 2022 22:14:07 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=lKAq=ST=gmail.com=dunlapg@srs-se1.protection.inumbo.net>)
 id 1nG6qF-0004st-QU
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 22:14:07 +0000
Received: from mail-yb1-xb31.google.com (mail-yb1-xb31.google.com
 [2607:f8b0:4864:20::b31])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c40ffae8-8607-11ec-8f75-fffcc8bd4f1a;
 Fri, 04 Feb 2022 23:14:06 +0100 (CET)
Received: by mail-yb1-xb31.google.com with SMTP id z62so10488170ybc.11
 for <xen-devel@lists.xenproject.org>; Fri, 04 Feb 2022 14:14:06 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c40ffae8-8607-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=umich.edu; s=google-2016-06-03;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=/IyKpmxVUqjrpIzjSTU9fLzwNvfMzMcv0lxO5bTkELo=;
        b=B1TnZGwfJcQTf+OzFhB3eCaPJpzwz/a8JKgPnxLfLzqkcOo9/BZnit3WYxNs099R+l
         KuiCJM+ViLvDLEE9+CgMWx2yBcjg9qN12m1PWgo2PlIfMrNkzL4qWjYJ9QQTaCvtOFVP
         75iZyybQa/NdtuoETbdCPd/QkWl7+Vj5bIA7olM8GlezQgtQoOfoISK/rdCYkzukHomF
         eTFTpSr3jA5mfPTBceFvB6vZxnjZG3TsLUxwXbIKAmosocbsz2FRFZXHsB+D0db4ziFB
         IgqeSZsc99C6/pJKl4+IFh23ZosqT8WXsiXxfeOthAmI3a0qDtmn7FHvwopD3KuqBUWN
         pqVA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=/IyKpmxVUqjrpIzjSTU9fLzwNvfMzMcv0lxO5bTkELo=;
        b=HMj8SLEQOVwORY7vbS2kmvwojWOJqVLRTZVySDmtLJjWdMdlPHgBCxomCHopEV1MUm
         hIfCmRBMDsusmAkGzMNevc1+VNZnZLSAt1ISC2W6P/MHB0VJdKaZvi85MLN8vXc4LK+z
         GAfbF4KTaKlLewrvctSnvWlkofmNaTJcHf3Zhxujh6tzTPrzwPOUY3rxj7EGlb7+J9lN
         bROfe/sBO93rqm6Q9Y8FClPsIMmzRPtd/7xG3YQqJSVLLgp4+xkEweOxwrhC23To0QYs
         SPNi2SeO/+4wP6wuSIRl16Z+jWtVv1rOuBh3HMyK2JKRo767/mV3eEzgKs+lCM6YJ0dT
         vKTg==
X-Gm-Message-State: AOAM532xx5cwSF2M1moC+Rga7Gvb0ZjN9O7IORsr0gnJl8cLyovb4HG7
	WM2eqdj6v2Toxy6pPcSjl1mowwfvM5rfJb99oP4=
X-Google-Smtp-Source: ABdhPJwixd/IBs8x7FxIDNK7vjfQj+PmqQSnHUusSQ3rqxkF/1+J8Xs05SeulaEHSenDfIB26e9kdUS0h/utyas/Fbw=
X-Received: by 2002:a81:3612:: with SMTP id d18mr1140852ywa.336.1644012845002;
 Fri, 04 Feb 2022 14:14:05 -0800 (PST)
MIME-Version: 1.0
References: <d1fd572d-5bfe-21d8-3b50-d9b0646ce2f0@suse.com> <55643e68-432a-116a-b68e-2200e364e5da@suse.com>
In-Reply-To: <55643e68-432a-116a-b68e-2200e364e5da@suse.com>
From: George Dunlap <dunlapg@umich.edu>
Date: Fri, 4 Feb 2022 22:13:54 +0000
Message-ID: <CAFLBxZYCqCKeuM4XJTNgEwzoAG7P8aw2dP5kHFSSHX_xmuOWBQ@mail.gmail.com>
Subject: Re: [PATCH 03/16] x86/P2M: drop a few CONFIG_HVM
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
	Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>, 
	=?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>, 
	George Dunlap <george.dunlap@citrix.com>
Content-Type: multipart/alternative; boundary="000000000000a1f56605d73891d8"

--000000000000a1f56605d73891d8
Content-Type: text/plain; charset="UTF-8"

On Mon, Jul 5, 2021 at 5:06 PM Jan Beulich <jbeulich@suse.com> wrote:

> This is to make it easier to see which parts of p2m.c still aren't HVM-
> specific: In one case the conditionals sat in an already guarded region,
> while in the other case P2M_AUDIT implies HVM.
>

I think this would be much more easy to understand what's going on if it
was more like this:

---
x86/p2m: P2M_AUDIT implies CONFIG_HVM

Remove one #endif / #ifdef CONFIG_HVM pair to make all the audit code
CONFIG_HVM only.  This is to make it easier to see which parts of p2m.c
still aren't HVM-specific.

While here, remove a redundant set of nested #ifdef CONFIG_HVM.
---

Reviewed-by: George Dunlap <george.dunlap@citrix.com>

--000000000000a1f56605d73891d8
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Mon, Jul 5, 2021 at 5:06 PM Jan Be=
ulich &lt;<a href=3D"mailto:jbeulich@suse.com">jbeulich@suse.com</a>&gt; wr=
ote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px=
 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">This is to =
make it easier to see which parts of p2m.c still aren&#39;t HVM-<br>
specific: In one case the conditionals sat in an already guarded region,<br=
>
while in the other case P2M_AUDIT implies HVM.<br></blockquote><div><br></d=
iv><div>I think this would be much more easy to understand what&#39;s going=
 on if it was more like this:</div><div><br></div><div>---<br></div><div>x8=
6/p2m: P2M_AUDIT implies CONFIG_HVM</div><div><br></div><div><div>Remove on=
e #endif / #ifdef CONFIG_HVM pair to make all the audit code CONFIG_HVM onl=
y.=C2=A0 This is to make it easier to see which parts of p2m.c still aren&#=
39;t HVM-specific. <br></div><div><br></div><div>While here, remove a redun=
dant set of nested #ifdef CONFIG_HVM.</div><div>---<br></div></div><div><br=
></div><div>Reviewed-by: George Dunlap &lt;<a href=3D"mailto:george.dunlap@=
citrix.com">george.dunlap@citrix.com</a>&gt;<br></div></div><div class=3D"g=
mail_quote"><br></div></div>

--000000000000a1f56605d73891d8--


From xen-devel-bounces@lists.xenproject.org Fri Feb 04 22:18:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 22:18:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265830.459382 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nG6u6-0005X6-RX; Fri, 04 Feb 2022 22:18:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265830.459382; Fri, 04 Feb 2022 22:18:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nG6u6-0005Wz-OR; Fri, 04 Feb 2022 22:18:06 +0000
Received: by outflank-mailman (input) for mailman id 265830;
 Fri, 04 Feb 2022 22:18:05 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=lKAq=ST=gmail.com=dunlapg@srs-se1.protection.inumbo.net>)
 id 1nG6u5-0005Wt-Pl
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 22:18:05 +0000
Received: from mail-yb1-xb31.google.com (mail-yb1-xb31.google.com
 [2607:f8b0:4864:20::b31])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 52711dca-8608-11ec-8eb8-a37418f5ba1a;
 Fri, 04 Feb 2022 23:18:04 +0100 (CET)
Received: by mail-yb1-xb31.google.com with SMTP id g14so22645937ybs.8
 for <xen-devel@lists.xenproject.org>; Fri, 04 Feb 2022 14:18:04 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 52711dca-8608-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=umich.edu; s=google-2016-06-03;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=Y1bJBBVbm1YpSOhnZE/fGej23yp2rZRAXlTCOAJ3+z8=;
        b=VvOgdrgAu+oT9UXd3PsebvLBGe9svXs7LdNybcwQ6XkmIIgOMT2nhYxRw3v7Xh5Uji
         4U6UmEQsUb27upNdaOxkZ3D2Zn1lZDwePTtYgiI61/bNvifh3A8CENaMiLvqv4g92MwG
         0jeq7MdmaS6OwOMsMPoHxFoPkRYJ95942ufwold/IOXCDMzySawam2Lak4RDrW9FjDMW
         noqwB5GHEsSpUF4zy10YqYXQb/rAMdpEKedJZbCjn1MDRIfhWPhQs715lwZaCAUHvIbR
         u1KuglQUojlen4ujS6NQORN7Pg0j/HPe15T4nf19J5N/CpFSQptKdFWp7/FSWsUSffyC
         yZwQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=Y1bJBBVbm1YpSOhnZE/fGej23yp2rZRAXlTCOAJ3+z8=;
        b=gNW8vEWAuCW0zuiFG4U2TBr/ZMAzFOrUgk7aED9WBAzJkUkuHplz5/Hy+sJA+fSCwS
         4NYFk7G6p/oXdu+ejshFX9FocYlEIb639WEKDtB2YJcq5WoW0OHk3mBpd06geTZzNFmn
         LmoA3ol0sUCMJBAJTU5FpX0a/XQ3wSXpTImN3WNbmbQ4RrwoA8BrASI5ySEMU1PNe6Ec
         CjGcLRwKm+piRn3NGyV+MuwxPHVb0deoPi3aG/u+EkHB8VCkhpqmxa/OiYsN3FOZxkkc
         a4A/i23dvsO3dLsWCxzfKNFM/R0b7l0T9MzcESqP+xdCTpMqzl/xJQnvC7yUxGzzgj9t
         A1vw==
X-Gm-Message-State: AOAM533IxCXvYAHIGuE/rAwwsMUdPaOy79vJ+/H04lNglCHApxIteZ9N
	/RfGmZ8by2KCy34/8eshJwBBWZvRW/aACDppl5g=
X-Google-Smtp-Source: ABdhPJyArfg+AyCAJIOIjuqMk4dhl2cHzzGGn6Qz92uNL2HAU87Hs6JuJ1hkVZhaN5I+rmuCcL48t46iiH1RlcmJUP4=
X-Received: by 2002:a81:b04f:: with SMTP id x15mr1144684ywk.282.1644013083847;
 Fri, 04 Feb 2022 14:18:03 -0800 (PST)
MIME-Version: 1.0
References: <d1fd572d-5bfe-21d8-3b50-d9b0646ce2f0@suse.com> <2b9d4562-1d44-d038-ea43-fe8b067c6070@suse.com>
In-Reply-To: <2b9d4562-1d44-d038-ea43-fe8b067c6070@suse.com>
From: George Dunlap <dunlapg@umich.edu>
Date: Fri, 4 Feb 2022 22:17:53 +0000
Message-ID: <CAFLBxZbFHPiFLrkYBTvv3WrF56tvqM49h2sTAOgc165vTv1=Vw@mail.gmail.com>
Subject: Re: [PATCH 04/16] x86/P2M: move map_domain_gfn() (again)
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
	Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>, 
	=?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>, 
	George Dunlap <george.dunlap@citrix.com>
Content-Type: multipart/alternative; boundary="000000000000de709005d7389fb4"

--000000000000de709005d7389fb4
Content-Type: text/plain; charset="UTF-8"

On Mon, Jul 5, 2021 at 5:07 PM Jan Beulich <jbeulich@suse.com> wrote:

> The main user is the guest walking code, so move it back there; commit
> 9a6787cc3809 ("x86/mm: build map_domain_gfn() just once") would perhaps
> better have kept it there in the first place. This way it'll only get
> built when it's actually needed (and still only once).
>
> This also eliminates one more CONFIG_HVM conditional from p2m.c.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>

Reviewed-by: George Dunlap <george.dunlap@citrix.com>

--000000000000de709005d7389fb4
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Mon, Jul 5, 2021 at 5:07 PM Jan Be=
ulich &lt;<a href=3D"mailto:jbeulich@suse.com">jbeulich@suse.com</a>&gt; wr=
ote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px=
 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">The main us=
er is the guest walking code, so move it back there; commit<br>
9a6787cc3809 (&quot;x86/mm: build map_domain_gfn() just once&quot;) would p=
erhaps<br>
better have kept it there in the first place. This way it&#39;ll only get<b=
r>
built when it&#39;s actually needed (and still only once).<br>
<br>
This also eliminates one more CONFIG_HVM conditional from p2m.c.<br>
<br>
Signed-off-by: Jan Beulich &lt;<a href=3D"mailto:jbeulich@suse.com" target=
=3D"_blank">jbeulich@suse.com</a>&gt;<br></blockquote><div><br></div><div>R=
eviewed-by: George Dunlap &lt;<a href=3D"mailto:george.dunlap@citrix.com">g=
eorge.dunlap@citrix.com</a>&gt;<br></div><div>=C2=A0</div></div></div>

--000000000000de709005d7389fb4--


From xen-devel-bounces@lists.xenproject.org Fri Feb 04 22:42:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 22:42:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265839.459392 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nG7I1-0000Dz-Sa; Fri, 04 Feb 2022 22:42:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265839.459392; Fri, 04 Feb 2022 22:42:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nG7I1-0000Ds-PT; Fri, 04 Feb 2022 22:42:49 +0000
Received: by outflank-mailman (input) for mailman id 265839;
 Fri, 04 Feb 2022 22:42:48 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=wnvI=ST=walle.cc=michael@srs-se1.protection.inumbo.net>)
 id 1nG7I0-0000DW-1r
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 22:42:48 +0000
Received: from ssl.serverraum.org (ssl.serverraum.org [2a01:4f8:151:8464::1:2])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c549a3d6-860b-11ec-8eb8-a37418f5ba1a;
 Fri, 04 Feb 2022 23:42:46 +0100 (CET)
Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ssl.serverraum.org (Postfix) with ESMTPSA id D23572223A;
 Fri,  4 Feb 2022 23:42:43 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c549a3d6-860b-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301;
	t=1644014564;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=xBouYYDQn0Y1ETqBsjJ4IluMJ7x00/eAmGvWdF7N4Lo=;
	b=mdrN1c1TFf6jS+8vBxc14joHyfdwjje67m0NXF8lAkOcmW3hQSZOrO/8t7kfhEFPaBF+y6
	6GPH7eIcJ4W5E6f7dRb0FJUmzckZvCRyLt05bjR232Pej+SOjfMyqOOhbIdI9d4Y9pCuP9
	nAvhM1o6h737RC72jVioeW+kqGbm/AI=
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date: Fri, 04 Feb 2022 23:42:43 +0100
From: Michael Walle <michael@walle.cc>
To: Stefano Stabellini <stefano.stabellini@xilinx.com>
Cc: Bertrand.Marquis@arm.com, Zhiqiang.Hou@nxp.com, brucea@xilinx.com,
 cornelia.bruelhart@zal.aero, julien@xen.org, leo.krueger@zal.aero,
 oleksandr_andrushchenko@epam.com, peng.fan@nxp.com,
 xen-devel@lists.xenproject.org
Subject: Re: Xen data from meta-virtualization layer
In-Reply-To: <alpine.DEB.2.22.394.2202041256040.4074808@ubuntu-linux-20-04-desktop>
References: <alpine.DEB.2.21.2011241743490.7979@sstabellini-ThinkPad-T480s>
 <20220204135814.1033356-1-michael@walle.cc>
 <alpine.DEB.2.22.394.2202041256040.4074808@ubuntu-linux-20-04-desktop>
User-Agent: Roundcube Webmail/1.4.12
Message-ID: <faa7864d4df6d9373a3c6b489d3e4469@walle.cc>
X-Sender: michael@walle.cc

Hi Stefano,

Am 2022-02-04 22:11, schrieb Stefano Stabellini:
> On Fri, 4 Feb 2022, Michael Walle wrote:
>> > In regards to the reserved-memory regions, maybe we are not seeing them
>> > because Leo posted the host device tree, not the one passed at runtime
>> > from u-boot to Linux?
>> >
>> > If so, Leo, could you please boot Linux on native (no Xen) and get the
>> > device tree from there at runtime using dtc -I fs -O dts
>> > /proc/device-tree ?
>> >
>> >
>> > However, the name of the reserved-memory region created by u-boot seems
>> > to be "lpi_rd_table". I cannot find any mentions of lpi_rd_table in the
>> > Linux kernel tree either.
>> >
>> > Zhiqiang, Leo is trying to boot Xen on sAL28. Linux booting on Xen
>> > throws errors in regards to GIC/ITS initialization. On other hardware
>> > Xen can use and virtualize GICv3 and ITS just fine. Could you please
>> > explain what is different about sAL28 and how Xen/Linux is expected to
>> > use the lpi_rd_table reserved-memory region?
>> 
>> I actually stumbled across this thread after trying out Xen myself. 
>> I'm
>> using lastest vanilla u-boot (with pending PSCI patches), vanilla 
>> kernel
>> and vanilla Xen.
>> 
>> So far I've discovered, that xen complains that it cannot route IRQ64 
>> to
>> dom0. That is because on the LS1028A there is a dual UART (two 16550
>> with one shared interrupt) and xen takes the first UART and then tries
>> to map the interrupt of the second UART to linux. For now, I don't 
>> know
>> how this is solved correctly. As a quick hack, I removed the second 
>> uart
>> node from the device tree.
> 
> This is an interesting problem. Removing the second UART is a good
> workaround for now as there is no obvious solution I think.

But not a very user friendly one, though. I guess the first UART
is disabled/removed by Xen? I haven't looked at how it is handled.

Can't we search for other uarts with the same interrupt and disable
these, too? Maybe conditionally by the SoC compatible?

>> But what is more severe is that the iommu isn't set up correctly. I'm
>> getting the following faults:
>> 
>> (XEN) smmu: /soc/iommu@5000000: Unexpected global fault, this could be 
>> serious
>> (XEN) smmu: /soc/iommu@5000000: 	GFSR 0x80000002, GFSYNR0 0x00000000, 
>> GFSYNR1 0x0000042a, GFSYNR2 0x00000000
>> 
>> If I decode it correctly, the streamid should be 0x2a which would be 
>> one
>> of the PCI devices on the internal root complex. Probably the network
>> card.
> 
> Yes there is DMA transaction with an "unknown" StreamID. I think the
> StreamID is 0x42a. It means that there is a DMA master on the board 
> with
> StreamID 0x42a that is either:
> 
> - not described in device tree
> - described in device tree with a different StreamID
> - the right StreamID is described device tree, but it is not picked up
>   by Xen

See below.

>> This is the first developer experience with Xen, so please bear with 
>> me
>> :) It seems that Xen doesn't add the master to the IOMMU. To me it 
>> seems
>> that only devices with a 'iommus' dt property are added. But in case 
>> of
>> PCI devices the parent only has a iommu-map property.
>> 
>> And it makes me wonder why Leo has an almost working setup. Maybe I'm
>> missing some patches though.
> 
> Xen 4.16 is able to parse StreamID in the "iommus" property and also
> "mmu-masters" property. But It is not able to parse the "iommu-map"
> property yet. So if 0x42a is described in device tree using "iommu-map"
> then the error makes sense.
> 
> A simple solution is to replace iommu-map with iommus in device tree.

I'm not sure this is so easy, because they are dynamically assigned
by the bootloader. Sure for now I could do that I guess, but iommu=0
works as well ;)

I now got Xen and Linux booting and see the same problems with the
GIC ITS, that is that the enetc interrupts aren't delivered to the
dom0 linux. I've also applied the patch in this thread and I'm
seeing the same as Leo. Full boot log is here [1].

I noticed the following.
[    0.168544] pci 0000:00:00.0: Failed to add - passthrough or 
MSI/MSI-X might fail!

Not sure if it should work nonetheless.

> It is possible that someone in CC to this email might already have a
> patch to introduce parsing of iommu-map in Xen.

I guess they've used the old mmu-masters property.

Btw. I don't know if it matters, but the SMARC-sAL28 normally doesn't
use TF-A and runs without it. Nonetheless, I've booted the board with
the bl31 from NXP and it doesn't help either. There is still a
difference between the NXP bootflow which uses bl1/bl2/bl31/u-boot
and this board which uses u-boot-spl/u-boot or u-boot-spl/bl31/u-boot.

I just found GIC setup code in the bl31. I'll also have a look there.

-michael

[1] https://pastebin.com/raw/XMjE3BvG


From xen-devel-bounces@lists.xenproject.org Fri Feb 04 23:30:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 23:30:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265848.459404 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nG81X-0004QH-He; Fri, 04 Feb 2022 23:29:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265848.459404; Fri, 04 Feb 2022 23:29:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nG81X-0004QA-Dt; Fri, 04 Feb 2022 23:29:51 +0000
Received: by outflank-mailman (input) for mailman id 265848;
 Fri, 04 Feb 2022 23:29:50 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+Jar=ST=gmail.com=julien.grall.oss@srs-se1.protection.inumbo.net>)
 id 1nG81W-0004Q4-4b
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 23:29:50 +0000
Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com
 [2a00:1450:4864:20::435])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 57989bb6-8612-11ec-8f75-fffcc8bd4f1a;
 Sat, 05 Feb 2022 00:29:48 +0100 (CET)
Received: by mail-wr1-x435.google.com with SMTP id f17so14028013wrx.1
 for <xen-devel@lists.xenproject.org>; Fri, 04 Feb 2022 15:29:48 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 57989bb6-8612-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=fhBu9ZA0oxZTBNNS6i+4wooMfskOYkVOkdHvMUQFW34=;
        b=YOpk0LUa9TnhR9Po0IHOtQGOJNtLuzLRj+zalJyTRDSKhTJy3efDeiRUP6qaVY1deB
         EFrBLUshRFnVvDP0fHyHVfkQygHr/ZTEFZHcKZOVmWzF3Lu6Y0SrGhIHV3H7xWTslgtJ
         UVmXEZJ7cLqWkwgaClsrQgm4xl++c8sD0xiCMnER57Qdnw2TtOBewsGo76CcWzKDbo9C
         pU+Mjfze35TTKpFcHLI4zZpyqfxaU+S/CfDloL5IOJ7eS2wleOaWfR5WOdQqvaSdJW4k
         Mkn1UF27PsDaYQ/7bZk6JmX7ZImn4VoRqu3KsssmlBKfwXs0IznL9653S8MsoWV3Pj3v
         P1Yw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=fhBu9ZA0oxZTBNNS6i+4wooMfskOYkVOkdHvMUQFW34=;
        b=VaY3I3Nu0MmOGSuyinlgxYJ1MEjNCARwg/3g888SH2kQdVrJXQs+WUa6p99sawPUPx
         UIjyTNVTP4l72Msh2qC//ZtDbaUzTgiyFT7Fcn94r4G8HAg2V2Y8r+mv7HxKsG2amfTE
         CK/y/yNy/YGENYlm5BIL9aeMSpGK0P3Zf5rwDDHclbj+0q80W9qfc86qoQ2fTFHSy6Mp
         1RFiOWNOU7StWbcXbNK/tsepP48qfBcqxprhxWtF2G+ipLUZpRNbSYvKGVBRSYun5fSB
         um0977OHwqgi0PcWqtqSTmP2KdrljcEt8/xvfJv8chyPYPxGzsADmy5TXtgQ/8rPpysG
         k8aQ==
X-Gm-Message-State: AOAM530B4aogrHdIiwkct0v+r2iT57l3Bj+4iy29Z4rRc1Pep9O4QfJR
	lzpWnn6US7EmgbVr2irAUny08dSE/ZY+kL5VIAM=
X-Google-Smtp-Source: ABdhPJwUYSjOtreQ6af6zZEi9QXx+6VHXqT6SYrV+VzTvPfuPSQ2rkDLuDOQDnXwyZQs/IY0cxUCyNxIm+1ZFVJ3Q4g=
X-Received: by 2002:adf:9169:: with SMTP id j96mr947909wrj.710.1644017386460;
 Fri, 04 Feb 2022 15:29:46 -0800 (PST)
MIME-Version: 1.0
References: <alpine.DEB.2.21.2011241743490.7979@sstabellini-ThinkPad-T480s>
 <20220204135814.1033356-1-michael@walle.cc> <alpine.DEB.2.22.394.2202041256040.4074808@ubuntu-linux-20-04-desktop>
 <faa7864d4df6d9373a3c6b489d3e4469@walle.cc>
In-Reply-To: <faa7864d4df6d9373a3c6b489d3e4469@walle.cc>
From: Julien Grall <julien.grall.oss@gmail.com>
Date: Fri, 4 Feb 2022 23:29:34 +0000
Message-ID: <CAJ=z9a0GX31E-yQRO3BpOujOCX09yOeeROkC57PzAUTUm3HV6g@mail.gmail.com>
Subject: Re: Xen data from meta-virtualization layer
To: Michael Walle <michael@walle.cc>
Cc: Stefano Stabellini <stefano.stabellini@xilinx.com>, 
	Bertrand Marquis <Bertrand.Marquis@arm.com>, Zhiqiang.Hou@nxp.com, brucea@xilinx.com, 
	cornelia.bruelhart@zal.aero, leo.krueger@zal.aero, 
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>, Peng Fan <peng.fan@nxp.com>, 
	xen-devel <xen-devel@lists.xenproject.org>
Content-Type: text/plain; charset="UTF-8"

Hi Michael,

On Fri, 4 Feb 2022 at 22:42, Michael Walle <michael@walle.cc> wrote:
> Am 2022-02-04 22:11, schrieb Stefano Stabellini:
> > On Fri, 4 Feb 2022, Michael Walle wrote:
> >> > In regards to the reserved-memory regions, maybe we are not seeing them
> >> > because Leo posted the host device tree, not the one passed at runtime
> >> > from u-boot to Linux?
> >> >
> >> > If so, Leo, could you please boot Linux on native (no Xen) and get the
> >> > device tree from there at runtime using dtc -I fs -O dts
> >> > /proc/device-tree ?
> >> >
> >> >
> >> > However, the name of the reserved-memory region created by u-boot seems
> >> > to be "lpi_rd_table". I cannot find any mentions of lpi_rd_table in the
> >> > Linux kernel tree either.
> >> >
> >> > Zhiqiang, Leo is trying to boot Xen on sAL28. Linux booting on Xen
> >> > throws errors in regards to GIC/ITS initialization. On other hardware
> >> > Xen can use and virtualize GICv3 and ITS just fine. Could you please
> >> > explain what is different about sAL28 and how Xen/Linux is expected to
> >> > use the lpi_rd_table reserved-memory region?
> >>
> >> I actually stumbled across this thread after trying out Xen myself.
> >> I'm
> >> using lastest vanilla u-boot (with pending PSCI patches), vanilla
> >> kernel
> >> and vanilla Xen.
> >>
> >> So far I've discovered, that xen complains that it cannot route IRQ64
> >> to
> >> dom0. That is because on the LS1028A there is a dual UART (two 16550
> >> with one shared interrupt) and xen takes the first UART and then tries
> >> to map the interrupt of the second UART to linux. For now, I don't
> >> know
> >> how this is solved correctly. As a quick hack, I removed the second
> >> uart
> >> node from the device tree.
> >
> > This is an interesting problem. Removing the second UART is a good
> > workaround for now as there is no obvious solution I think.
>
> But not a very user friendly one, though. I guess the first UART
> is disabled/removed by Xen? I haven't looked at how it is handled.
>
> Can't we search for other uarts with the same interrupt and disable
> these, too? Maybe conditionally by the SoC compatible?

The problem sounds quite similar to the one we had on sunxi. Although
the UART was on the same page rather than sharing interrupts.

Xen has per-platform hook to prevent a device been assigned
to dom0. For an example, you could look at:

https://xenbits.xen.org/gitweb/?p=xen.git;a=blob;f=xen/arch/arm/platforms/sunxi.c

> >> This is the first developer experience with Xen, so please bear with
> >> me
> >> :) It seems that Xen doesn't add the master to the IOMMU. To me it
> >> seems
> >> that only devices with a 'iommus' dt property are added. But in case
> >> of
> >> PCI devices the parent only has a iommu-map property.
> >>
> >> And it makes me wonder why Leo has an almost working setup. Maybe I'm
> >> missing some patches though.
> >
> > Xen 4.16 is able to parse StreamID in the "iommus" property and also
> > "mmu-masters" property. But It is not able to parse the "iommu-map"
> > property yet. So if 0x42a is described in device tree using "iommu-map"
> > then the error makes sense.
> >
> > A simple solution is to replace iommu-map with iommus in device tree.
>
> I'm not sure this is so easy, because they are dynamically assigned
> by the bootloader. Sure for now I could do that I guess, but iommu=0
> works as well ;)
>
> I now got Xen and Linux booting and see the same problems with the
> GIC ITS, that is that the enetc interrupts aren't delivered to the
> dom0 linux. I've also applied the patch in this thread and I'm
> seeing the same as Leo. Full boot log is here [1].
>
> I noticed the following.
> [    0.168544] pci 0000:00:00.0: Failed to add - passthrough or
> MSI/MSI-X might fail!

This message is harmless. This is printed because Xen on Arm
doesn't hypercall the hypercall to add a PCI device. On Arm,
we don't need it yet (it might be necessary for PCI passthrough) and
MSI/MSI-X are handled/registered the same way as on bare-metal
(for your case through the ITS)

>
> Not sure if it should work nonetheless.

I looked through the log and couldn't spot anything obvious. However,
skimming through Linux, I noticed there are some changes in the
ITS for freescale (now NXP) such as:

drivers/irqchip/irq-gic-v3-its-fsl-mc-msi.c

Is it something that might be used on the board you are using?

If the answer is yes, then my suggestion would be to look
how this is meant to interact with the ITS. It might be possible
that we are missing some pieces in Xen to properly support it.

>
> > It is possible that someone in CC to this email might already have a
> > patch to introduce parsing of iommu-map in Xen.

Pass. I don't have any and couldn't find any submission on the ML.


>
> I guess they've used the old mmu-masters property.
>
> Btw. I don't know if it matters, but the SMARC-sAL28 normally doesn't
> use TF-A and runs without it. Nonetheless, I've booted the board with
> the bl31 from NXP and it doesn't help either. There is still a
> difference between the NXP bootflow which uses bl1/bl2/bl31/u-boot
> and this board which uses u-boot-spl/u-boot or u-boot-spl/bl31/u-boot.
>
> I just found GIC setup code in the bl31. I'll also have a look there.
>
> -michael
>
> [1] https://pastebin.com/raw/XMjE3BvG


From xen-devel-bounces@lists.xenproject.org Fri Feb 04 23:59:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 04 Feb 2022 23:59:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265857.459415 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nG8Tx-0007hX-Qm; Fri, 04 Feb 2022 23:59:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265857.459415; Fri, 04 Feb 2022 23:59:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nG8Tx-0007hQ-Ns; Fri, 04 Feb 2022 23:59:13 +0000
Received: by outflank-mailman (input) for mailman id 265857;
 Fri, 04 Feb 2022 23:59:12 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=wnvI=ST=walle.cc=michael@srs-se1.protection.inumbo.net>)
 id 1nG8Tw-0007hI-7p
 for xen-devel@lists.xenproject.org; Fri, 04 Feb 2022 23:59:12 +0000
Received: from ssl.serverraum.org (ssl.serverraum.org [176.9.125.105])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7205f1de-8616-11ec-8eb8-a37418f5ba1a;
 Sat, 05 Feb 2022 00:59:10 +0100 (CET)
Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ssl.serverraum.org (Postfix) with ESMTPSA id 7DF3F2223A;
 Sat,  5 Feb 2022 00:59:08 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7205f1de-8616-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301;
	t=1644019149;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=kmWPFjjYyqYzUUzH0cXKRlvYTCQ/CsSJIfo38qefcGk=;
	b=o8nP1K9+6doIrTXqyPHp9V61cIWRIXY6T/povkEi+FJJBS5vHD9e9eB9S+t3VMncNzMN5N
	iPe2dZ6MrmtuuO/SmyUngVKnwThVc2qd10OunD0cOaFD+1qg+VqAnxqw4nVUKJndpy8UJY
	KQ5YsOe3OmeguVhD772NHTVCcZqVHC4=
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date: Sat, 05 Feb 2022 00:59:08 +0100
From: Michael Walle <michael@walle.cc>
To: Julien Grall <julien.grall.oss@gmail.com>
Cc: Stefano Stabellini <stefano.stabellini@xilinx.com>, Bertrand Marquis
 <Bertrand.Marquis@arm.com>, Zhiqiang.Hou@nxp.com, brucea@xilinx.com,
 cornelia.bruelhart@zal.aero, leo.krueger@zal.aero, Oleksandr Andrushchenko
 <oleksandr_andrushchenko@epam.com>, Peng Fan <peng.fan@nxp.com>, xen-devel
 <xen-devel@lists.xenproject.org>
Subject: Re: Xen data from meta-virtualization layer
In-Reply-To: <CAJ=z9a0GX31E-yQRO3BpOujOCX09yOeeROkC57PzAUTUm3HV6g@mail.gmail.com>
References: <alpine.DEB.2.21.2011241743490.7979@sstabellini-ThinkPad-T480s>
 <20220204135814.1033356-1-michael@walle.cc>
 <alpine.DEB.2.22.394.2202041256040.4074808@ubuntu-linux-20-04-desktop>
 <faa7864d4df6d9373a3c6b489d3e4469@walle.cc>
 <CAJ=z9a0GX31E-yQRO3BpOujOCX09yOeeROkC57PzAUTUm3HV6g@mail.gmail.com>
User-Agent: Roundcube Webmail/1.4.12
Message-ID: <93c22ab5739616843584d73fe4dd0a3a@walle.cc>
X-Sender: michael@walle.cc

Hi Julien,

Am 2022-02-05 00:29, schrieb Julien Grall:
[..]
>> But not a very user friendly one, though. I guess the first UART
>> is disabled/removed by Xen? I haven't looked at how it is handled.
>> 
>> Can't we search for other uarts with the same interrupt and disable
>> these, too? Maybe conditionally by the SoC compatible?
> 
> The problem sounds quite similar to the one we had on sunxi. Although
> the UART was on the same page rather than sharing interrupts.
> 
> Xen has per-platform hook to prevent a device been assigned
> to dom0. For an example, you could look at:
> 
> https://xenbits.xen.org/gitweb/?p=xen.git;a=blob;f=xen/arch/arm/platforms/sunxi.c

Nice. At least, this is working now ;) I'll send a patch in
the next few days.

I guess it's safe to assume that we can always remove both UARTs
on the LS1028A (probably on most layerscapes). The most common
use case is to use the first UART for Xen. You could run Xen
without console (?), then you'd miss the possibility to map
the DUART. Or there could be a new driver for the LPUART on the
LS1028A. In this case, the DUART wouldn't be used by Xen either.

But I think we should start simple and just remove the DUART
altogether via that hook.

-michael


From xen-devel-bounces@lists.xenproject.org Sat Feb 05 00:24:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 05 Feb 2022 00:24:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265865.459426 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nG8sK-00031d-Ly; Sat, 05 Feb 2022 00:24:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265865.459426; Sat, 05 Feb 2022 00:24:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nG8sK-00031W-HG; Sat, 05 Feb 2022 00:24:24 +0000
Received: by outflank-mailman (input) for mailman id 265865;
 Sat, 05 Feb 2022 00:24:22 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nG8sI-00031M-CB; Sat, 05 Feb 2022 00:24:22 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nG8sI-0005Op-9c; Sat, 05 Feb 2022 00:24:22 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nG8sH-0004vw-Lm; Sat, 05 Feb 2022 00:24:21 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nG8sH-0007Tc-J1; Sat, 05 Feb 2022 00:24:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=5KfEFmDHDSowv8DQL8365Y4GzeIUYR55ehAA/3oL7YA=; b=4kmGqhFjUIlF/OHrVf09p+rhJD
	cXr6saSdcaqixnNG0Ql5l/zxqy+Be6HegkAp5gKg3XR7Wmua3o5SfQa04dgYkUMxp6BtZe0SV5IQn
	bQ3K7x2xoR17KtZKiznHE3jssUlRtSt10XIfoZsj7HmHk6Nx8y/r/z76oHF6/umR0SMc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168008-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 168008: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-credit1:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=75cc460a1b8cfd8e5d2c4302234ee194defe4872
X-Osstest-Versions-That:
    xen=75cc460a1b8cfd8e5d2c4302234ee194defe4872
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 05 Feb 2022 00:24:21 +0000

flight 168008 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168008/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-credit1  22 guest-start/debian.repeat  fail pass in 168001

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168001
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168001
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168001
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168001
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168001
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168001
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168001
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168001
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168001
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168001
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168001
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168001
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 xen                  75cc460a1b8cfd8e5d2c4302234ee194defe4872
baseline version:
 xen                  75cc460a1b8cfd8e5d2c4302234ee194defe4872

Last test of basis   168008  2022-02-04 11:09:13 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  fail    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Sat Feb 05 02:14:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 05 Feb 2022 02:14:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265881.459443 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGAap-0007Cc-UY; Sat, 05 Feb 2022 02:14:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265881.459443; Sat, 05 Feb 2022 02:14:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGAap-0007CU-OQ; Sat, 05 Feb 2022 02:14:27 +0000
Received: by outflank-mailman (input) for mailman id 265881;
 Sat, 05 Feb 2022 02:14:26 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Hh+u=SU=gmail.com=robherring2@srs-se1.protection.inumbo.net>)
 id 1nGAan-0007CO-TY
 for xen-devel@lists.xenproject.org; Sat, 05 Feb 2022 02:14:26 +0000
Received: from mail-oi1-f170.google.com (mail-oi1-f170.google.com
 [209.85.167.170]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 55fed28c-8629-11ec-8f75-fffcc8bd4f1a;
 Sat, 05 Feb 2022 03:14:24 +0100 (CET)
Received: by mail-oi1-f170.google.com with SMTP id q186so10623261oih.8
 for <xen-devel@lists.xenproject.org>; Fri, 04 Feb 2022 18:14:24 -0800 (PST)
Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net.
 [66.90.148.213])
 by smtp.gmail.com with ESMTPSA id i23sm1389213otj.19.2022.02.04.18.14.22
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 04 Feb 2022 18:14:22 -0800 (PST)
Received: (nullmailer pid 3618455 invoked by uid 1000);
 Sat, 05 Feb 2022 02:14:21 -0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 55fed28c-8629-11ec-8f75-fffcc8bd4f1a
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:references
         :mime-version:content-disposition:in-reply-to;
        bh=bavDyoeix3ivKrmvk1c86k8fQHTEv2BfyXOQ+LGiGnA=;
        b=MZEBnC6eaqx3T0DUfyoW4fcwcJwoQfbfvqWGLdrUZqfHyzh+FFNKH0o64QYRF0kkO0
         sm/04ugnVMQKbhiXBPZBZxbqThDLyoXhvzdbVd04OD8KyiM7cC1rt8jPA+hrKEvIXiFZ
         34pXtwM2iZUWBb6LCeaoeeGxDeqPF55vU9r8nO5V+/LYVXTrulY0ZtmHOLFsvfeO66Am
         k4pxJJ00qarDeA8LB/QhPwpm/hDDcw+oP7N8BvKsqYZDlMsBhj9u0KlgwAk47tr3h0/h
         R1Nh6hEgZUAf472Dv7HbMkJ8RTxlzVf5f4RoIP6LyikQJDUrRHALYMVb2WnFXn3dgrEy
         WMtA==
X-Gm-Message-State: AOAM532QzaXOOPAPtODdgI4w3e9cpHvJON7PVwbm9IeQgxoU4+xQKvuN
	96JWG+BT0T8rZvXDX56a/zXXGEC4Lw==
X-Google-Smtp-Source: ABdhPJzohhI86BDByZJvtg/GYgD3FQPT2/j3rlDpD888Vi5x4ag/iD4VE+2Pi/X/ul8DPGRoE3J0Dw==
X-Received: by 2002:aca:c056:: with SMTP id q83mr2812199oif.294.1644027263107;
        Fri, 04 Feb 2022 18:14:23 -0800 (PST)
Date: Fri, 4 Feb 2022 20:14:21 -0600
From: Rob Herring <robh@kernel.org>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Robin Murphy <robin.murphy@arm.com>, Sergiy Kibrik <Sergiy_Kibrik@epam.com>, Julien Grall <julien@xen.org>, Oleksandr Tyshchenko <olekstysh@gmail.com>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v3 1/2] dt-bindings: arm: xen: document Xen iommu device
Message-ID: <Yf3dfUtYoB8wpWkl@robh.at.kernel.org>
References: <20220117123251.140867-1-Sergiy_Kibrik@epam.com>
 <20220117123251.140867-2-Sergiy_Kibrik@epam.com>
 <e88b882f-4b5d-a801-fc68-66b7f790e11c@arm.com>
 <PAXPR03MB81144A63E18CAF10E785E2A7F0209@PAXPR03MB8114.eurprd03.prod.outlook.com>
 <447f89ca-86c0-dc35-e7ac-e6639a573670@arm.com>
 <alpine.DEB.2.22.394.2201261050300.27308@ubuntu-linux-20-04-desktop>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.22.394.2201261050300.27308@ubuntu-linux-20-04-desktop>

On Wed, Jan 26, 2022 at 10:56:39AM -0800, Stefano Stabellini wrote:
> On Wed, 26 Jan 2022, Robin Murphy wrote:
> > On 2022-01-26 15:09, Sergiy Kibrik wrote:
> > > Hi Robin,
> > > 
> > > > 
> > > > This could break Linux guests, since depending on the deferred probe
> > > > timeout setting it could lead to drivers never probing because the "IOMMU"
> > > > never becomes available.
> > > > 
> > > 
> > > I've noticed no deferred probe timeouts when booting with this patch. Could
> > > you please explain more on how this would break guests?
> > 
> > Right now I think it would actually require command-line intervention, e.g.
> > "fw_devlink=on" or "deferred_probe_timeout=3600" (with modules enabled for the
> > latter to take full effect), but I'm wary of the potential for future config
> > options to control those behaviours by default.

fw_devlink=on is now the default (for at least a couple of cycles).

> 
> If deferred_probe_timeout=3600 was specified, we would just need an
> IOMMU driver in Linux for the "xen,iommu-el2-v1" node to solve the
> problem, right? I guess I am trying to say that it wouldn't be a device
> tree interface problem but rather a Linux implementation discussion.

You would have to add that IOMMU driver to old, existing kernels if you 
want compatibility with a new DT. Otherwise, that kernel would stop 
booting with a new DT.

Rob



From xen-devel-bounces@lists.xenproject.org Sat Feb 05 05:27:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 05 Feb 2022 05:27:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265890.459453 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGDbU-00087N-4C; Sat, 05 Feb 2022 05:27:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265890.459453; Sat, 05 Feb 2022 05:27:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGDbU-00087G-1D; Sat, 05 Feb 2022 05:27:20 +0000
Received: by outflank-mailman (input) for mailman id 265890;
 Sat, 05 Feb 2022 03:07:26 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=NIY/=SU=linux.intel.com=ricardo.neri-calderon@srs-se1.protection.inumbo.net>)
 id 1nGBQ6-0003qp-5I
 for xen-devel@lists.xenproject.org; Sat, 05 Feb 2022 03:07:26 +0000
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id bbce3f5e-8630-11ec-8f75-fffcc8bd4f1a;
 Sat, 05 Feb 2022 04:07:22 +0100 (CET)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 04 Feb 2022 19:07:20 -0800
Received: from ranerica-svr.sc.intel.com ([172.25.110.23])
 by FMSMGA003.fm.intel.com with ESMTP; 04 Feb 2022 19:07:20 -0800
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bbce3f5e-8630-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
  d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
  t=1644030442; x=1675566442;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=SVt+kz06lumoHSJeOZCowvMvVSRtLKaNCZWiLQNIEik=;
  b=ZiMEAJ/hoN4nKUT3QfTeYEseCkyDDmGcQ4IX9hhq8Nl/YDXGFtj8xeEk
   gRiKNxp72fxwtzeeidVLZH9tZngMNwWjLk9FkM0DxuGA5uQliPSQWbTg8
   2KG2jf02Tb0ZWNipEr0a2lNBMYBIsPfasR8/ECTkalwby7cAAjLjD8GLu
   T6PX4iwmaGXNoY8oy5rh6iQkkaDr7dUjt5p1LkuCkvIzJO6isjnJKAnU1
   Hs9ESMMG1Uc8AP2Hbwc4PYcnwYCzCPyFDoigtjtglSJG5qA+Nx2s1kG2g
   bQ0dg1O6BNmVIcz6c4NKgQ4QrJ8lNqGT4bSe7/8d8rJgwpaTXfdly34aC
   g==;
X-IronPort-AV: E=McAfee;i="6200,9189,10248"; a="272990459"
X-IronPort-AV: E=Sophos;i="5.88,344,1635231600"; 
   d="scan'208";a="272990459"
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.88,344,1635231600"; 
   d="scan'208";a="621020506"
Date: Fri, 4 Feb 2022 19:09:09 -0800
From: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	the arch/x86 maintainers <x86@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>
Subject: Re: x86: insn-eval.c's use of native_store_gdt()
Message-ID: <20220205030909.GA12533@ranerica-svr.sc.intel.com>
References: <0d687d64-1cf0-8965-0569-bce27cf0a8b7@suse.com>
 <68c4f398-0494-e272-47e0-6803b6865f15@suse.com>
 <87fsoyd8rl.ffs@tglx>
 <f1710902-3085-0f7b-54d3-d65ac5b09e32@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f1710902-3085-0f7b-54d3-d65ac5b09e32@suse.com>
User-Agent: Mutt/1.9.4 (2018-02-28)

On Fri, Feb 04, 2022 at 03:13:52PM +0100, Jan Beulich wrote:
> On 04.02.2022 15:08, Thomas Gleixner wrote:
> > On Fri, Feb 04 2022 at 10:23, Jan Beulich wrote:
> >> On 30.11.2021 12:09, Jan Beulich wrote:
> >>> I think it is b968e84b509d ("x86/iopl: Fake iopl(3) CLI/STI usage")
> >>> which uncovered an issue with get_desc() trying to access the GDT, as
> >>> introduced by 670f928ba09b ("x86/insn-eval: Add utility function to
> >>> get segment descriptor"). When running in a PV domain under Xen, the
> >>> (hypervisor's) GDT isn't accessible; with UMIP enabled by Xen even
> >>> SGDT wouldn't work, as the kernel runs in ring 3.
> >>>
> >>> There's currently no hypercall to retrieve a descriptor from the GDT.
> >>> It is instead assumed that kernels know where their present GDT
> >>> lives. Can the native_store_gdt() be replaced there, please?
> >>>
> >>> For context (I don't think it should matter much here) I'm observing
> >>> this with the kernel put underneath a rather old distro, where
> >>> hwclock triggers this path.
> >>
> >> I'd like to note that the issue still exists in 5.16.
> > 
> > I'd like to note, that I've seen no patches to that effect.
> 
> I could have worded it that way as well, yes.

Hi Jan, I am sorry I missed your email. I'll look at the issue you
describe and get back to you.

Thanks and BR,
Ricardo


From xen-devel-bounces@lists.xenproject.org Sat Feb 05 05:33:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 05 Feb 2022 05:33:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265900.459465 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGDha-00015t-Rk; Sat, 05 Feb 2022 05:33:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265900.459465; Sat, 05 Feb 2022 05:33:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGDha-00015m-Oi; Sat, 05 Feb 2022 05:33:38 +0000
Received: by outflank-mailman (input) for mailman id 265900;
 Sat, 05 Feb 2022 05:33:37 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nGDhZ-00015c-83; Sat, 05 Feb 2022 05:33:37 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nGDhY-0004Wx-VT; Sat, 05 Feb 2022 05:33:37 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nGDhY-0005gw-C2; Sat, 05 Feb 2022 05:33:36 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nGDhY-0001P7-Aj; Sat, 05 Feb 2022 05:33:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=YKMc5XBVsgkAxuuUavnPWb87KeZAlxR2EJoPfjJL/BQ=; b=ftVaktwDfCSMdmp2V75BrampHj
	IEUlCkvDmmupdbnr91Zd4khHpgEsJCoRvS7rFieNT1Eu2GRFIlgs5r7gCBiKuibvjVwafF6VV8GOp
	OzNRCvDUyY6c6xHSFybInGFyL3T2xi39BuF/VL+qcR/Ypfr7P6Pwi3EVyqrI7fpUPaNQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168012-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 168012: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-credit1:guest-start.2:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=dcb85f85fa6f142aae1fe86f399d4503d49f2b60
X-Osstest-Versions-That:
    linux=1f2cfdd349b7647f438c1e552dc1b983da86d830
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 05 Feb 2022 05:33:36 +0000

flight 168012 linux-linus real [real]
flight 168020 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/168012/
http://logs.test-lab.xenproject.org/osstest/logs/168020/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-credit1  23 guest-start.2       fail pass in 168020-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168004
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168004
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168004
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168004
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168004
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168004
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168004
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168004
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                dcb85f85fa6f142aae1fe86f399d4503d49f2b60
baseline version:
 linux                1f2cfdd349b7647f438c1e552dc1b983da86d830

Last test of basis   168004  2022-02-04 00:41:22 Z    1 days
Testing same since   168012  2022-02-04 16:57:25 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alex Elder <elder@linaro.org>
  Alexander Aring <aahringo@redhat.com>
  Alexandre Belloni <alexandre.belloni@bootlin.com>
  Alexei Starovoitov <ast@kernel.org>
  Andrii Nakryiko <andrii@kernel.org>
  Arınç ÜNAL <arinc.unal@arinc9.com>
  Camel Guo <camelg@axis.com>
  Christian Brauner <christian.brauner@ubuntu.com>
  Cristian Marussi <cristian.marussi@arm.com>
  Daniel Borkmann <daniel@iogearbox.net>
  David S. Miller <davem@davemloft.net>
  Dima Chumak <dchumak@nvidia.com>
  Dmitry V. Levin <ldv@altlinux.org>
  Duoming Zhou <duoming@zju.edu.cn>
  Eric Dumazet <edumazet@google.com>
  Florian Westphal <fw@strlen.de>
  Gal Pressman <gal@nvidia.com>
  Geert Uytterhoeven <geert@linux-m68k.org>
  Georgi Valkov <gvalkov@abv.bg>
  Gurucharan G <gurucharanx.g@intel.com>
  Haiyue Wang <haiyue.wang@intel.com>
  He Fengqing <hefengqing@huawei.com>
  Hou Tao <hotforest@gmail.com>
  Hou Tao <houtao1@huawei.com>
  Imam Hassan Reza Biswas <imam.hassan.reza.biswas@intel.com>
  Jakub Kicinski <kuba@kernel.org>
  Jan Kiszka <jan.kiszka@siemens.com>
  Jean-Philippe Brucker <jean-philippe@linaro.org>
  Jedrzej Jagielski <jedrzej.jagielski@intel.com>
  Jisheng Zhang <jszhang@kernel.org>
  John Fastabend <john.fastabend@gmail.com>
  Jonathan McDowell <noodles@earth.li>
  Karen Sornek <karen.sornek@intel.com>
  Karsten Graul <kgraul@linux.ibm.com>
  Kees Cook <keescook@chromium.org>
  Khalid Manaa <khalidm@nvidia.com>
  Li Zhijian <lizhijian@cn.fujitsu.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Lior Nahmanson <liorna@nvidia.com>
  Maher Sanalla <msanalla@nvidia.com>
  Maor Dickman <maord@nvidia.com>
  Maxim Mikityanskiy <maximmi@nvidia.com>
  Miquel Raynal <miquel.raynal@bootlin.com>
  Muhammad Usama Anjum <usama.anjum@collabora.com>
  Nathan Chancellor <nathan@kernel.org>
  Nechama Kraus <nechamax.kraus@linux.intel.com>
  Nícolas F. R. A. Prado <nfraprado@collabora.com>
  Pablo Neira Ayuso <pablo@netfilter.org>
  Paolo Abeni <pabeni@redhat.com>
  Paul Moore <paul@paul-moore.com>
  Phil Sutter <phil@nwl.cc>
  Raed Salem <raeds@nvidia.com>
  Raju Rangoju <Raju.Rangoju@amd.com>
  Roi Dayan <roid@nvidia.com>
  Saeed Mahameed <saeedm@nvidia.com>
  Sasha Neftin <sasha.neftin@intel.com>
  Sean Young <sean@mess.org>
  Shuah Khan <skhan@linuxfoundation.org>
  Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
  Slawomir Laba <slawomirx.laba@intel.com>
  Soheil Hassas Yeganeh <soheil@google.com>
  Steen Hegelund <steen.hegelund@microchip.com>
  Stefan Schmidt <stefan@datenfreihafen.org>
  Sudheesh Mavila <sudheesh.mavila@amd.com>
  Sylwester Dziedziuch <sylwesterx.dziedziuch@intel.com>
  syzbot+5239d0e1778a500d477a@syzkaller.appspotmail.com
  Tom Lendacky <thomas.lendacky@amd.com>
  Tony Nguyen <anthony.l.nguyen@intel.com>
  Vincenzo Frascino <vincenzo.frascino@arm.com>
  Viresh Kumar <viresh.kumar@linaro.org>
  Vlad Buslov <vladbu@nvidia.com>
  Vratislav Bendel <vbendel@redhat.com>
  Wen Gu <guwen@linux.alibaba.com>
  Yang Xu <xuyang2018.jy@fujitsu.com>
  Yannick Vignon <yannick.vignon@nxp.com>
  Yuji Ishikawa <yuji2.ishikawa@toshiba.co.jp>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  fail    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   1f2cfdd349b7..dcb85f85fa6f  dcb85f85fa6f142aae1fe86f399d4503d49f2b60 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Sat Feb 05 05:45:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 05 Feb 2022 05:45:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265920.459508 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGDsp-0002ue-Bd; Sat, 05 Feb 2022 05:45:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265920.459508; Sat, 05 Feb 2022 05:45:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGDsp-0002uW-8F; Sat, 05 Feb 2022 05:45:15 +0000
Received: by outflank-mailman (input) for mailman id 265920;
 Sat, 05 Feb 2022 05:45:14 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nGDso-0002u7-Bk; Sat, 05 Feb 2022 05:45:14 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nGDso-0004jA-9a; Sat, 05 Feb 2022 05:45:14 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nGDsn-00067E-VB; Sat, 05 Feb 2022 05:45:14 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nGDsn-0000Ad-Ul; Sat, 05 Feb 2022 05:45:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=/xp8ywu+wim6Ysb5uLmTY6Vc2iBN11mdtCiAe0UuEpE=; b=GXT8atzj4MBePBoxiLN8NlA0df
	aVQqMNUhOnq0SSjl2ltDMqcsUhHXrTR4YJ+D9K5ydnyqSpZFRRS+Ww6DRXuQeMxtNcEVyqAKYNowa
	VFWR3KyYyfdhuyxr4vhorgut0X0P7ikOyTq+FiCpfrk0Tns/KhOU4ZMl8m7lIkkHDeZc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168013-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.14-testing test] 168013: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-4.14-testing:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:debian-di-install:fail:heisenbug
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=f2eaa786062970eee41df1ffba1475f4ab36c234
X-Osstest-Versions-That:
    xen=b636efa6cc88a27366a4e75eea68f0a8019c0906
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 05 Feb 2022 05:45:13 +0000

flight 168013 xen-4.14-testing real [real]
flight 168019 xen-4.14-testing real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/168013/
http://logs.test-lab.xenproject.org/osstest/logs/168019/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 168019-retest
 test-arm64-arm64-libvirt-raw 12 debian-di-install   fail pass in 168019-retest

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-libvirt-raw 14 migrate-support-check fail in 168019 never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail in 168019 never pass
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167964
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167964
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167964
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167964
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167964
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167964
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167964
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 167964
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 167964
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167964
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167964
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167964
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  f2eaa786062970eee41df1ffba1475f4ab36c234
baseline version:
 xen                  b636efa6cc88a27366a4e75eea68f0a8019c0906

Last test of basis   167964  2022-01-31 10:06:35 Z    4 days
Testing same since   168013  2022-02-04 17:06:25 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Jan Beulich <jbeulich@suse.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   b636efa6cc..f2eaa78606  f2eaa786062970eee41df1ffba1475f4ab36c234 -> stable-4.14


From xen-devel-bounces@lists.xenproject.org Sat Feb 05 09:47:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 05 Feb 2022 09:47:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265947.459539 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGHfL-0000JQ-40; Sat, 05 Feb 2022 09:47:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265947.459539; Sat, 05 Feb 2022 09:47:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGHfK-0000JJ-Vi; Sat, 05 Feb 2022 09:47:34 +0000
Received: by outflank-mailman (input) for mailman id 265947;
 Sat, 05 Feb 2022 09:47:33 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=acBu=SU=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nGHfJ-0000JC-HJ
 for xen-devel@lists.xenproject.org; Sat, 05 Feb 2022 09:47:33 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a1b70d28-8668-11ec-8eb8-a37418f5ba1a;
 Sat, 05 Feb 2022 10:47:31 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a1b70d28-8668-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644054450;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=osbsXyjwKjznnBdprwpNhVW5NtFBisfsbqbChZrE9ac=;
  b=Y+BN+TXefmguzBZFq6zBJIt2Ifmvc/F+jEH0x6MmOKIbnc7mUGI0of3/
   9upzahJa/Q07sJQAnPeAe4W+F89IuPGVJy3MLWbqcen+liEmNWNUQLubI
   3DfZnnR7Wr2/QZAkBqeYhdP/PNb0kByUrOwbc9DO5Fobos+DeNT8YW8Uk
   g=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: rVg03h7mJbN6QyslJ+L5yjrufcTDfVFPflsaGWqCf5VxhTHRR3YochAhypqwMRFexDhzINSmWG
 2TykpVVegeJf42tM0KYrVdvStiB7gSQi/2rAUzxBq1wYrLcqTIEHX7KGhF+T3NMAXXpI5uGZ3j
 8TUnTDbqZCngpH2XL6h8hvYLrlPsTJFXU4JZwbmyYT10LWkvyYjC/XXEUGN5TeM6UIZoI/kFhz
 qGJeJGAPMmnyfMQC4ntbNvHBj7P3cZMv6zA4DOlJpYJELvwmBuMMGxapito6SjYbTJ6Gr4Afu/
 STVJj09IcLA9ORn+3pTiM7LG
X-SBRS: 5.1
X-MesageID: 63472751
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Ky8Qga6sbIMvvP+rSi3z+QxRtN7AchMFZxGqfqrLsTDasY5as4F+v
 jEeWGHVOq3YYWSmfNp3aNi3pBgP75OEnIRnTFA4pSE2Hi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FV8MpBsJ00o5wbZj2tMw2LBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z7
 /trpMC6WSYSB7TTntkPUBlbPCBYBPgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALNs7kMZlZonh95TrYEewnUdbIRKCiCdpwgmxs2ZoRQK+2i
 8wxNDpNNwTRckV2YkoHKosdvtaNh3P9fGgNwL6SjfVuuDWCpOBr65DyNPLFd9rMQt9a9m66j
 G/b+2XyAjkBKceSjzGC9xqEluLJ2C/2Ro8WPLm57eJxxk2ewHQJDx8bXkf9puO24nNSQPoGd
 RZSoHB36/Fvqgr7FbERQiFUvlajkDgNB9BAMtYD8R6L97jX4wW2B049G2sphMMdiOc6Qjkj1
 1msltzvBCByvLD9dU9x5ot4vhvpZ3FLcDZqiTssCFJcvoK9+N1bYgfnE447eJNZmOEZDt0ZL
 9qiiCElz4segscQv0lQ1QCW2mn8znQlo+Nc2+k2Yo5Hxl4hDGJGT9bxgbQ+0RqmBNzEJrVml
 CNc8/VyFMhUUfmweNWlGY3h5o2B6fefKyH7ilVyBZQn/DnF0yf9IdwIuGkhexkxbpZsldrVj
 Kn74145CHh7ZyPCUEOKS9jpV5RCIVbISbwJqcw4nvIRO8MsJWdrDQllZFKK3nCFraTfufpXB
 HtvSu71VSxyIf0+lFKeHr5BuZd2lnFW7T6CHvjTkkX4uZLAPyT9YelebzOzghURsfrsTPP9q
 I0EaaNnCnx3DYXDX8Ug2dRPdABRcylnWsyeRg4+XrfrHzeK0VoJUpf56bggZ5Zkj+JSkOLJ9
 Wu6QUhW1Bz0gnivFOlAQikLhGrHUcktoHQlEzYrOFr0iXEvbZz2tPUUdoctfKlh/+tmlKYmQ
 /4AcsSGI/JOVjWYpGhNMcij9NRvJEaxmAaDHyu5ezxjLZRucBPEp43/dQz1+ShQUifu7Zkio
 6et3x/wSIYYQ1gwF97fbf+ilgvjvXUUlO9ocVHPJ91fJBfl/IRwcnSjhf4rOcAcbx7Ew2LCh
 QqRBB4Zo8jLopM0r4aV1fzV8d/xHrInTERAHmTd4bKnDgXg/zKukd1aTeKFXTHBT2eoqq+sU
 vpYkqPnO/odkVcU74clS+R3zbgz7sfErqNBylg2B23CalmmB+8yInSC2sUT5KRByqUA5FmzU
 0OLvNJbJa+IKIXuF1tIfFgpaeGK1Pc1nDjO7KtqfBWmtXEvpLfXA19POxSsiTBGKOonOYwo9
 u4tpcoK5lHtkREtKNuH0nhZ+mnkwqbsiEn7WkX22LPWtzc=
IronPort-HdrOrdr: A9a23:SwjlzqOFxF3Bh8BcTv+jsMiBIKoaSvp037BN7TEXdfU1SL39qy
 nApoV46faZslYssRIb+OxoWpPwJ080nKQdieN9UYtKNDOWwVdAR7sSiLcKrQeQeBEW39QtrZ
 uJLMNFY+EYd2IVsS9R2njCLz9a+ra6zJw=
X-IronPort-AV: E=Sophos;i="5.88,345,1635220800"; 
   d="scan'208";a="63472751"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=NDcv2xeNMntv10hFgxNp/TLCX8OthqM/HyXK0ukVaPlSzJenVcExj058dIODcQKMNRlZdTIHj7Pb/AA3omuON4oC0cUXYfFjAiR6epcYtipzJgHqQQHhfqvD49fc02YKUlqG9Yjyw1tWRwLetrfSmmcCLom7jFIRkKNoUvs2kicrk7csASIbpImg8/4y6Y17pONjAq7sUbxwd4q/bBJdSblXp3qj4RAiaOZInDZJqg34Loso8sK/TdsNK1kdsW+EIzWCmdzvqrzvqck6Lq5qntn9FrnOBVkJ9TYewxTKLzGOGvaUdnpPQwc5fG58GtYazwfZ5vdowwPctD8IjlNh5A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ZcG19WZEEaInoxE72n0JRMdTZ489sXc4DheM9r8Lovs=;
 b=FDLOJxd8w+eEttvIMYc+cQkcO5Fkl13n7a+q6haA1bWvQ/DfG9BKz5j/t75tk2HTx2SfwtI40kcbjCU7evyRynLGwwl08EkdyiVAuLXyp8S3nzp7S5nKaM7ckiReS8D+9kRNyBeeKAHlTkp0u6X9qm9Y5LfA7r/J3Ifw/oOLlYVca6m7+OfBAyOP9rud/nbNgkvog2MJNlrLYYBiVR6HzjVTsIfZBYCavCbbgYygW7m3gpZNp4UkJBymG12gMBGdyrvl5zx1QYtTGKuP0gGCRdBzJO1a4Ltgg3p7IVVbYAQpMJTl8EWcI/7aGMxV4AAaTleUmGlRA7j9vmBJYdMDUg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ZcG19WZEEaInoxE72n0JRMdTZ489sXc4DheM9r8Lovs=;
 b=BBJ2+gDx+lcsD9h0VjRrPT4wcdgalG0uV0GOcYaYXmRz84SVPm7M8FYnXF/XylM32aEwwyNeaahZvz6xSvwM1bAEvVgaAviU0OrpjPgHnl81wkg2gzMPDeP+hBLGo7PoshRHPGfpbria83hp6TOkVxWpH2ifYyRL+VWo0DoCKC0=
Date: Sat, 5 Feb 2022 10:47:19 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Jan Beulich
	<JBeulich@suse.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH] x86/hvm: Fix boot on systems where HVM isn't available
Message-ID: <Yf5HpzveBK+Ho3Nt@Air-de-Roger>
References: <20220204173405.22759-1-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220204173405.22759-1-andrew.cooper3@citrix.com>
X-ClientProxiedBy: LO4P123CA0511.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:272::12) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 70e60372-a497-4c2f-0ad9-08d9e88c835e
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6454:EE_
X-Microsoft-Antispam-PRVS: <SJ0PR03MB64542CB1F3A3D723D8DF6BB38F2A9@SJ0PR03MB6454.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: hJGjWME1tKsOtIGSnMnTa2BuMGDZ6+qdAaKK/M2Tkn17NfV3YIEsOUnENJ2faWpSlxsmJ3W9EMLER/EHgrnK9p/2lsgzSYEkvQ8KYFA1x7DR6od3Nb+/TCzT2YknFR1NbfdqPWO3bF+SWix9Oy0R/Psyt6s/EJzIW9Dzilo8n6orWv7saUEYJ00DkmqEI8tP9XMJ09AlRoQgWjoNdxK9E3KAMczQQROhhst0BSHN9A2oAPwlpNi2nWm5eZpBGEmjAI85P1+x/5Hu9YQeVFXQa1MFFOfEqQTdiBJrVU2/cWeLjmXVscPSOLibiTLGQeoYBsz0bOI2vL8ThH8xQr4TwCYNbrQAop1+hU3u9B3GQ3nUNOu4i7zSEOZ67Gz9iRVultkEFV8Pytu32ib99AbOHzYq0pguKd43dZOjXLZ2CtmIda92gOJJfO/6neEQcxzTLOxYbPwd64G8wsRprw+bpgh2bziY0atWFY4q88dfbfA8pSxe7+I0fsJg6oU75SBWA/PqWmtM3tJsoGibuDPL5dqgTOLDD5bmEwfUy8JbYLy5poOQ1XJIjKIHsfVEFtDDTisPHvWHgogBBaGGHh10fwrpscPzUXubtMRG2hveJeHBoeIUgRYov5rUWjgosawZQDhPCluXbc59MlkicqFQVDAaNYRrbAjxY3NfFwM7bEgoCQlTo9ZWDZz3j3SHuZ14za7Cays80baeRAAas/02hg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(33716001)(82960400001)(6666004)(2906002)(508600001)(6486002)(85182001)(5660300002)(4326008)(8936002)(186003)(8676002)(26005)(316002)(66476007)(66556008)(66946007)(6636002)(6862004)(54906003)(38100700002)(86362001)(6512007)(9686003)(6506007)(67856001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dWhZQm9CemQ5WkZXbldLazd2RnlBUnNZQmk2MHk0d2J3SzZ5MllQb1ZhSCs3?=
 =?utf-8?B?UzZTMWNZQTFMUVVVaWk2RzdlTmFKUUZmeWQ2YUQzQjdhMFd1dURLbnlZa0Nl?=
 =?utf-8?B?NERaUWNEVi9FSVhVdHh3SGtJWGY2TExLUWlFeGRBOWFBTXoxQVhaek53QVZT?=
 =?utf-8?B?b3FBTTUwdlpUeDhEQy9ONGs2azVBUUtPYVpBaHlpc3JaZDh4N0JTT0FjZlF3?=
 =?utf-8?B?NkNRWEVHTHo5aG44ZitNNEJZZ0FSUDJIVnYrUkswbGJxOXkrSzlEUS82S1RP?=
 =?utf-8?B?dUIxZGxNTWt0bkJjQ2krVXJhZzk0aWh5UDdDNUZaNXowOW9GL2hwSnVsamQv?=
 =?utf-8?B?MVAwU2UweUExbDV2WWp2ejU0bnBLcWxmSDROOFRCWk9zK055WTZWdmpydE9P?=
 =?utf-8?B?RnFDcjc5MStpSmhadklVVElsN0xUcTJDKzM5RG9CSXVnYTZiVHVaSkRLWUlG?=
 =?utf-8?B?VnV2S28zd2loQ2t1NjF1UnRLeVZNNEJkQmRHc0UwRHowSUd3V1o4c1J6bkc3?=
 =?utf-8?B?L1Y4T3BTNDMxMzFPTE1qdFFITHdjSmNXcmFZZXlXSFg4OXd3RFR0RXB2Z2d4?=
 =?utf-8?B?bnJmNDlQSmVOek9pbVBDM1pwSVhXTEJNZnVuVGllWGtsR044TC9KNFlzMXJC?=
 =?utf-8?B?RkQyTUY3ZVF2WWcxRmRpVFE5KzE0bjJNanVoclkxc2d1RG1EVmNPb3lvNmZ3?=
 =?utf-8?B?TjExRCt0V3VjRUtxOVhoT0plZWg5VnBPYXRWd0trQmdhNElaUlE5ZkJMc09P?=
 =?utf-8?B?eHIrb3hFZnlheG5sMmxxMmVoblllSkpRZUpHcG9iQk16UHd0UmNnQ3ZVWnNk?=
 =?utf-8?B?Z3ovUUFLNy9VOHA5Q0F0ZWJRUUN2dWpGNDVIYjRobG5UYndJMC9qVjgzMTdB?=
 =?utf-8?B?WHBjWU81QzFlUStxNVQybzRVRlFyTlBvcmQyMlQxOWxvSVpsUlZ4TjlIN0lp?=
 =?utf-8?B?S0UzdUtOWTdsa2VNR3ltOTRlVlFwNFh6ZnFUR09wWm5HUXhsTFFDZS9YM29L?=
 =?utf-8?B?SmcwUTBvN2o4UUg2dm8wVmFRYjg2L2JMeDFlY3Rjc3hZVlJkczVkbnNVVGJT?=
 =?utf-8?B?TitUblNrQXc3MkZWK1FmU1ZXa1B1MzJWVFFEMHMyaUFuNVJkQWx2ZzAzaE1V?=
 =?utf-8?B?SkdEMzF3WExlVW9sYU5RWGY5a0RmRFI4ZFpQZGN2WWxMTUx2Ri8wTjdlUm0x?=
 =?utf-8?B?YWtsWUlCbkRRWmpJSzFMV2xVR3BnOXhTekc4L2pScy9IbzREbVdKVzMrTU1o?=
 =?utf-8?B?RWN5UW1JR3k3YUQySGZzTTIwOVo0V0E2dnNBRDZ3Q21XYzlOOWZKdExycmQw?=
 =?utf-8?B?bEdkRFBqUDBsRDJCUDY1TTVZNmtZUmZldkxNMEVxWVdXa3hQT1U1QkJLbTVz?=
 =?utf-8?B?V1lGa1RGUm1hYmRaWXdDQk5KZWVDdmpYSGFFRS9IYndlREd6OTUxbUdUdlY5?=
 =?utf-8?B?dGF1dGNYM1pYOTJZNnJnZ0VyNjlEdTVDSkF3MWdoNXdNQ3A5ZUVmbCtjNmpJ?=
 =?utf-8?B?a2gyQWxyZ1ZrRCtvQWZVWGlFNG1OdHZlSXZPRGlXWm12eGlGQzQrMlZnN0pZ?=
 =?utf-8?B?MzJ1M0RsRk1US1RwdFVzeHFvbTFxWWxzQ3lHVmNEcGt2UWY4WFlqejFOUUl2?=
 =?utf-8?B?YkMzWS9MamdHdTNGMnBEUWlQSHJaZWxKVm9taFBld0k5bVFlbXhxL0h5R2Jo?=
 =?utf-8?B?bEFqWW1NWi9udjhKT2RIbmpiaUlaRmdQRnBCZWxwWUFXZmlHNXI5cU9aM2tj?=
 =?utf-8?B?ZmhpOXBFdEpSbUYxbHV0VGJyZU1xQVVDL1RUZjZpNDJPdGNsU1BlNG1LcVZw?=
 =?utf-8?B?T1YweDhNWmM2SkVwUFpKb1l5ZkMxWWRDdHJJSzJmb0I2MUNFNzh3by9PcFpS?=
 =?utf-8?B?U0tJSmo4RGw2dzEzZ25pZWY2b3pLWDNsN09mUXFrb2V0SGplM1pZTWxVTEh5?=
 =?utf-8?B?S0NvYnJQU1FSclo3V295ZzhYYWQxVzF0ZGQ4bDhnbG5VbTRBTVlVU0J6cys5?=
 =?utf-8?B?MVoxaUE4U3RtV3ozeUpJYlZXNVk4ZzhOWnBXUjVFVVlkcW1tMm8vRFB3U2pq?=
 =?utf-8?B?Y2ZMNXRKbEdxVVAraENHSUwweDZwTHBWMTYxUkpNOXJCVTNIYXZxNmhkeFVG?=
 =?utf-8?B?ajExZWgxUkZhQlpRWFN1Qm9PZWtnRlhVNWhkN0xsVzBLR0UyZ3pwSTh0SEJN?=
 =?utf-8?Q?UWBoL9PHwu8jFfgsQQjyr5U=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 70e60372-a497-4c2f-0ad9-08d9e88c835e
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2022 09:47:24.9491
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2XGToyr+mn2c++c25P/rWz80FA416ICaIijsJJqiTJq8O6aUKqI01+qMih+S+akiA9D+hphX8DvGEpf0zX6F3g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6454
X-OriginatorOrg: citrix.com

On Fri, Feb 04, 2022 at 05:34:05PM +0000, Andrew Cooper wrote:
> c/s 27a63cdac388 ("x86/HVM: convert remaining hvm_funcs hook invocations to
> alt-call") went too far with dropping NULL function pointer checks.
> 
> smp_callin() calls hvm_cpu_up() unconditionally.  When the platform doesn't
> support HVM, hvm_enable() exits without filling in hvm_funcs, after which the
> altcall pass nukes the (now unconditional) indirect call, causing:
> 
>   (XEN) ----[ Xen-4.17.0-10.18-d  x86_64  debug=y  Not tainted ]----
>   (XEN) CPU:    1
>   (XEN) RIP:    e008:[<ffff82d04034bef5>] start_secondary+0x393/0x3b7
>   (XEN) RFLAGS: 0000000000010086   CONTEXT: hypervisor
>   ...
>   (XEN) Xen code around <ffff82d04034bef5> (start_secondary+0x393/0x3b7):
>   (XEN)  ff ff 8b 05 1b 84 17 00 <0f> 0b 0f ff ff 90 89 c3 85 c0 0f 84 db fe ff ff
>   ...
>   (XEN) Xen call trace:
>   (XEN)    [<ffff82d04034bef5>] R start_secondary+0x393/0x3b7
>   (XEN)    [<ffff82d0402000e2>] F __high_start+0x42/0x60
> 
> To make matters worse, __stop_this_cpu() calls hvm_cpu_down() unconditionally
> too, so what happen next is:
> 
>   (XEN) ----[ Xen-4.17.0-10.18-d  x86_64  debug=y  Not tainted ]----
>   (XEN) CPU:    0
>   (XEN) RIP:    e008:[<ffff82d04034ab02>] __stop_this_cpu+0x12/0x3c
>   (XEN) RFLAGS: 0000000000010046   CONTEXT: hypervisor
>   ...
>   (XEN) Xen code around <ffff82d04034ab02> (__stop_this_cpu+0x12/0x3c):
>   (XEN)  48 89 e5 e8 8a 1d fd ff <0f> 0b 0f ff ff 90 0f 06 db e3 48 89 e0 48 0d ff
>   ...
>   (XEN) Xen call trace:
>   (XEN)    [<ffff82d04034ab02>] R __stop_this_cpu+0x12/0x3c
>   (XEN)    [<ffff82d04034ac15>] F smp_send_stop+0xdd/0xf8
>   (XEN)    [<ffff82d04034a229>] F machine_restart+0xa2/0x298
>   (XEN)    [<ffff82d04034a42a>] F arch/x86/shutdown.c#__machine_restart+0xb/0x11
>   (XEN)    [<ffff82d04022fd15>] F smp_call_function_interrupt+0xbf/0xea
>   (XEN)    [<ffff82d04034acc6>] F call_function_interrupt+0x35/0x37
>   (XEN)    [<ffff82d040331a70>] F do_IRQ+0xa3/0x6b5
>   (XEN)    [<ffff82d04039482a>] F common_interrupt+0x10a/0x120
>   (XEN)    [<ffff82d04031f649>] F __udelay+0x3a/0x51
>   (XEN)    [<ffff82d04034d5fb>] F __cpu_up+0x48f/0x734
>   (XEN)    [<ffff82d040203c2b>] F cpu_up+0x7d/0xde
>   (XEN)    [<ffff82d0404543d3>] F __start_xen+0x200b/0x2618
>   (XEN)    [<ffff82d0402000ef>] F __high_start+0x4f/0x60
> 
> which recurses until hitting a stack overflow.  The #DF handler, which resets
> its stack on each invocation, loops indefinitely.
> 
> Reinstate the NULL function pointer checks for hvm_cpu_{up,down}().
> 
> Fixes: 27a63cdac388 ("x86/HVM: convert remaining hvm_funcs hook invocations to alt-call")
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

> ---
> CC: Jan Beulich <JBeulich@suse.com>
> CC: Roger Pau Monné <roger.pau@citrix.com>
> CC: Wei Liu <wl@xen.org>
> 
> RFC.  Not tested yet on the imacted hardware.  It's a Xeon PHI with another
> werid thing in need of debugging.  First boot is fine, while second
> boot (loading microcode this time) has a problem with vmx.
> 
> I wonder if we want to modify the callers to check for HVM being enabled,
> rather than leaving the NULL pointer checks in a position where they're liable
> to be reaped again.

What about adding a couple of comments to hvm_cpu_{up,down} to note
they are called unconditionally regardless of whether HVM is present
or not?

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Sat Feb 05 10:18:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 05 Feb 2022 10:18:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265955.459549 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGI9A-0003aQ-Hn; Sat, 05 Feb 2022 10:18:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265955.459549; Sat, 05 Feb 2022 10:18:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGI9A-0003aJ-Ed; Sat, 05 Feb 2022 10:18:24 +0000
Received: by outflank-mailman (input) for mailman id 265955;
 Sat, 05 Feb 2022 10:18:22 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=acBu=SU=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nGI98-0003a8-B3
 for xen-devel@lists.xenproject.org; Sat, 05 Feb 2022 10:18:22 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ef63a3ca-866c-11ec-8f75-fffcc8bd4f1a;
 Sat, 05 Feb 2022 11:18:20 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ef63a3ca-866c-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644056300;
  h=from:to:cc:subject:date:message-id:
   content-transfer-encoding:mime-version;
  bh=2M9egmCI4HzA9LZ1aBDt/P1gEY3wNlimUe6nb151H7M=;
  b=Aoq8t8yyk1sXAqnvSfeuiLzjHmG9X/MxJm/UiVBwTcSx1RhVMbd2m+sh
   lh80Tg5SxGUjvPSsb2bf5jcMx4UxCL4t76DtWd8zbvHmcpSR6kUJtdMNb
   +3NVZHUEt62+fleK803phEtrWpQj8P0WyXdW6IQu5JEMpYwu/kZDLtB2k
   U=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: vu/wimMayj2EusvVM661aDL50nzLQa4XmstURWNMBYZMFI89q4+vAeOvO+dx1tw2bv1Y8KGOwp
 v0vJrR6P2cQG4u6LOeYeuHz+afUAT0JkUv/EnNN3EppXj4cwpYpmY42e/kzSAXjZZf58z1VVQh
 y9DiKMLTImK2vwADjrAppMcpKKpuECHjq4QykBVWlMXMV7UjvboudaqNU5lYY6RzSQSLy2rUT6
 SV38sDXxI8GCI/PpRrX1sGrGwOyyUzCkTk1f7ahCcMIBm5wcnMLu0HMl9SWlPCv7HH0ZP+y+Cy
 MHIl/gno2KCNugCgKXvGx6gx
X-SBRS: 5.1
X-MesageID: 63020098
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:/tJ6Ea4LJ9C6QXeVE/LcxgxRtN7AchMFZxGqfqrLsTDasY5as4F+v
 mUYD22OOauDMWGmKY9/b9i3pE9Q657SytAwSQNsqywxHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FV8MpBsJ00o5wbZj2tMw2LBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z7
 dBO67ezZwATAKTrvu83cD1+NjFRMvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALNs7kMZlZonh95TrYEewnUdbIRKCiCdpwgmxo3JgWTKa2i
 8wxbRdzMBf+Pxd0B1opBtF93+SI10WibGgNwL6SjfVuuDWCpOBr65DyNPLFd9rMQt9a9m6ar
 G/b+2XyAjkBKceSjzGC9xqEluLJ2C/2Ro8WPLm57eJxxk2ewHQJDx8bXkf9puO24nNSQPoGd
 RZSoHB36/Fvqgr7FbERQiFUvlahux1CcNl+FNcE4SarwYD3xyC8FkcLG2sphMMdiOc6Qjkj1
 1msltzvBCByvLD9dU9x5ot4vhvpZ3FLcDZqiTssCFJcvoK9+N1bYgfnE447eJNZmOEZDt0ZL
 9qiiCElz4segscQv0lQ1QCW2mn8znQlo+Nc2+k2Yo5Hxl4hDGJGT9bxgbQ+0RqmBNzEJrVml
 CNc8/VyFMhUUfmweNWlGY3h5o2B6fefKyH7ilVyBZQn/DnF0yf9IdwIuGkhexkxbpZsldrVj
 Kn74145CHh7ZyPCUEOKS9jpV5RCIVbISbwJqcw4nvIRO8MsJWdrDQllZFKK3nCFraTfufpXB
 HtvSu71VSxyIf0+lFKeHr5BuZd2lnFW7T6CHvjTkkX4uZLAPyT9YelebzOzghURsfrsTPP9q
 I0EaaNnCnx3DYXDX8Ug2dRPdABRcylnWsyeRg4+XrfrHzeK0VoJUpf56bggZ5Zkj+JSkOLJ9
 Wu6QUhW1Bz0gnivFOlAQikLhGrHUcktoHQlEzYrOFr0iXEvbZz2tPUUdoctfKlh/+tmlKYmQ
 /4AcsSGI/JOVjWYpGhNMcij9NRvJEaxmAaDHyu5ezxjLZRucBPEp43/dQz1+ShQUifu7Zkio
 6et3x/wSIYYQ1gwF97fbf+ilgvjvXUUlO9ocVHPJ91fJBfl/IRwcnSjhf4rOcAcbx7Ew2LCh
 QqRBB4Zo8jLopM0r4aV1fzV8d/xHrInTERAHmTd4bKnDgXg/zKukd1aTeKFXTHBT2eoqq+sU
 vpYkqPnO/odkVcU74clS+R3zbgz7sfErqNBylg2B23CalmmB+8yInSC2sUT5KRByqUA5FmzU
 0OLvNJbJa+IKIXuF1tIfFgpaeGK1Pc1nDjO7KtqfBWmtXEvpLfXA19POxSsiTBGKOonOYwo9
 u4tpcoK5lHtkREtKNuH0nhZ+mnkwqbsiEn7WkX22LPWtzc=
IronPort-HdrOrdr: A9a23:o7yWc634t4TXsDpENR7fxwqjBVxyeYIsimQD101hICG9Lfb3qy
 n+ppsmPEHP5Ar5OEtBpTiBUJPwJk80kqQFnLX5XI3SJjUO3VHIEGgM1/qa/9SNIVyaygc/79
 YfT0EdMqyJMbESt6+Ti2PUYrVQouVvmJrY+ts2pE0dKz2CBZsQizuQXW2gYzFLrUR9dNIEPa
 vZwvACiyureHwRYMj+Ln4ZX9Lbr9mOsJ79exYJCzMu9QHL1FqTmfTHOind+i1bfyJEwL8k/2
 SAuwvl5p+7u/X+7hPHzWfc47lfhdOk4NpeA86njNQTN1zX+02VTbUkf4fHkCE+oemp5lpvuN
 7Qoy04N8A20H/VdnHdm2qb5yDQlBIVr1Pyw16RhnXu5ebjQighNsZHjYVFNjPE9ksJprhHoe
 129lPck6ASIQLLnSz76dSNfQptjFCIrX0rlvNWp2BDULEZdKRaoeUkjQ9o+a87bWPHAb0cYa
 lT5Jm23ocUTbraVQGVgoBX+q3jYpxpdS32AHTruaSuokxrdT5Cvg4lLfck7wc9HaQGOux5Dt
 T/Q9VVfY51P7wrhNpGdZw8qOuMexrwqEH3QSuvyWqOLtB0B5uKke+y3IkI
X-IronPort-AV: E=Sophos;i="5.88,345,1635220800"; 
   d="scan'208";a="63020098"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=RLzjjzEfAAtNXh2YIi58GFXnJh9GsbLa4VYhA+V5t7X1UBcR32sMeXgiPt8fVntIJD7Q8vZzQDekjt7y1EUCTkDmwx27S4yHZOhr329lxlIoAyxN5uRoChB9r0+JUSFX8Z64fP+XHao3RyyEJToNP651S6KFn4NgWjbUBB238C3EGzUIBq+GsM1jBRpRttWcen/sFKVZakJAIbb/1VZAb8j+mqGutWsi52ZfPvQOvLH8zs6YA5CfMq0sPy0x0HtqmITSierBrkFz+Rcf7SIecSvfiyYkrobS0WjJyDteLtaHjNa5E4dB4VKokBG/T4C7OqHlvzj8PN8qeKj9cV7rVQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=WVTS8os2R3JAl8Zb/Mnli4SsMsV4iD+DmljA87DcI6I=;
 b=Pbk1y1L4IPdctph+56vSxg2VVYotDV0Em5AOXUr7jcsQ+TKvVFwnMDUkRQMVkEgeDiPbsPy+ctwXkvB996LTum7w+r8QbRi5vX5GvPcLznCG0+FUlgCLE1BrH/lpgq9J1aYSPwTs3eB/uvH9VABus3jWCTLai+xStJ96aVScafGd2lFJkCp+tUnCo4fxWU4p834CrX+IoZSCkChYXHyi1y6w+nS2KnFKFI3WqbgFmdA/q5WmJXFnYmR00PXLlvCbMPE/xcN203NAlR+bnpy2owLcULXCmTQJTEYlaGyKX7UOYlFT3yJ5TzIYpvNXpSKBMN+y7ZuQeiJbbEaOYLBt6Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=WVTS8os2R3JAl8Zb/Mnli4SsMsV4iD+DmljA87DcI6I=;
 b=AGhd4rt+88sv/0DHlYyMeUCdkH1XpBN7r0pOWucckxDZFZq7nSE0c7Oyf9ijVQDgguVd2uPgORsuC3d4eeaQ1BIxYC50el8q3sq/OaOUMl/4vkPtwZUPL9DeCPJ7cfx0moJ3KtwK17nt7Lp93JQ7Pj6GdqQqUwRv2tRhIM0xbzs=
From: Roger Pau Monne <roger.pau@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Roger Pau Monne <roger.pau@citrix.com>, Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: [PATCH] dom0/pvh: fix processing softirqs during memory map population
Date: Sat,  5 Feb 2022 11:18:06 +0100
Message-ID: <20220205101806.35927-1-roger.pau@citrix.com>
X-Mailer: git-send-email 2.34.1
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO4P123CA0198.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1a4::23) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 613b5d61-3e4d-4aa1-c729-08d9e890d06b
X-MS-TrafficTypeDiagnostic: SN6PR03MB3904:EE_
X-Microsoft-Antispam-PRVS: <SN6PR03MB390470363998E17D73A894808F2A9@SN6PR03MB3904.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4714;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: RS/yxsYhr0ZQCfuMspWQh9CFMgEYU9zEUfugH1vrh9doB3cScN4Idvpu2nvqB7JBTciZtkzsgiOgkb7RjvP6IWJbCPEFIZPpy0EhTqCwW3RoAfYgDoMRtf+RAjpGVUYVE6Nue4vohtPOlSdAvD8TvqKkdEDypfakGF8U4wPdhDst6l4UN5WVnU661zDtemXh2ow8s0NzMpfMlVGWj+NA9TUfWSlL0f9WLgj8/i1wScCMToFhVGDbRN5g6JcSEiiD0xbzaPukoz32JebDlNioKMgE+BRCSWgbjbL7Iq8L2/QsDhhhjt6gq6qfAYw8H6GGFa7eO4wvs9DKrYYP9qxgKLgUGZDwuG9qdqlbDf0v+rI3kqFBOGsILZ6xyZyQWiB+9sbXpU45r0AE3cf+f1JZSTHRygq0/DG9/4/XKw8MK4DPmmKu7a9amvLnG+8OeC1/IysrOQbj4Zv4ZEiphvr0yRPGT/vnWroPjqYNbLQM+xt6cXGO7fjgD+VpUgxk+fNKs79acFdeCizguc6OMVTQibPHSM8zxaRhMZQK8Fm1S1c/tk9xa5NHCKTwY0aujaXxvFc1Z9F4AuwoulUOd54CjAw2ywPqwuf8MelKpQ9slm6xpSP1Fn6jtWI66Sj++l3AwfdDn1+ppD4qpaB+9Wflaw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(8936002)(4326008)(83380400001)(26005)(82960400001)(8676002)(38100700002)(66946007)(5660300002)(6486002)(66556008)(66476007)(1076003)(2616005)(316002)(6916009)(54906003)(86362001)(6666004)(6506007)(6512007)(2906002)(508600001)(36756003)(186003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YzJUK2R2UktmYWhMRUJwNlJadDBhdCsxTjlxTVhEODZ1UTdKY1greWN0SS9k?=
 =?utf-8?B?WWdMdjZWMDZERFFVWkNZckw1NzgrYnBDcFdXUWRFMWFHZkJMVnlMVlZSYkNv?=
 =?utf-8?B?YWcxSjBlZ2c1c1UyTWVqM0dCRE1tZ3lPbEpRc2NrRnk1U0p0MFVCcmlXVEhL?=
 =?utf-8?B?V2FBbmlwakZlbHV5eTBCM2R1RHgrc3RncG1BY1R5M2tiOS9rRnBjNmgxYVEz?=
 =?utf-8?B?WndZYUI4WnBVM2F1MG9lUUFVT0tUNG5CQnNGcEpTOWk0N2VqRWxrcmtWcm9z?=
 =?utf-8?B?ZmE2V1FiZ2RxK3NrVEt4NnJXeTFCaW1YdmxqV1ZwTFhUWUUzUzY4ditBQUdC?=
 =?utf-8?B?TEJ6VmRia2piVUREMTRkcHlLNUF4Rk03alJkYVB5em1VRkZMenB2ZWN2ejRJ?=
 =?utf-8?B?Y05nYTlnU2s0djREUjVHUXlQQzl5Y3pYYnJKYlNoREtPazNHSXR1eVlwMDd3?=
 =?utf-8?B?dmREV24rM2ZpSUNUWmIzak4ydnZyazBTaHpaWmRVaUtPOHBMdDBldjhXdWdQ?=
 =?utf-8?B?Yk1WQUI2OTJrT3hmUlFTVmFUMzU0VGZSeGRMQjJJMnYxUmRtVHZ5Z2hhVUVh?=
 =?utf-8?B?bWtKYUpmTkhoSVNzNnhBckNoWDhvQnVMcExyMGZtY2l2bTEraGI3anFOTTFx?=
 =?utf-8?B?N1ZJV2F3TzE2dUp4QXhDQjV6cFBvYXdDcU1qRnY0U2FhYmY5b0p4WUpKQXg2?=
 =?utf-8?B?bnNwd2J4TU9hSEJoVkxXUUJLYlQybHJuRlhjUkdnaDJjVDVSeFJIeE5xc1NO?=
 =?utf-8?B?NklqbGRBZFpMWjVkRkU0MENHZUdjS09Ia1dmN21RN3dZaDF4bTlVTUltMHlw?=
 =?utf-8?B?aWpsYUV2emNWVHpJOXR5eWZGUkhXVHY0Z0N1dmdURWVKL3RJelREV3NxYk84?=
 =?utf-8?B?OGZDWXVIMEpXeThWNFdrMnhrWlE1anN3blhXdVAxVWxqVnVTMk1wOGVxTFQ1?=
 =?utf-8?B?OG1OMU1QNTFTM2cybENGRFhkdmwzeHBqOTJFL2VkYzBvS1BCZWlwVUxLbGNi?=
 =?utf-8?B?eGxFMk5zc0RvMVVaSFIxVFozeTFwNk9SVzNYWTFjbk54eUhKSjhKMHJUUGtX?=
 =?utf-8?B?TWwzWVJ5NnIzVEFjS1UzdlZmemtYOXFNcWhhUVlhM3FiZTV2Q2lPbmlsdGVz?=
 =?utf-8?B?YWlCcGY5VklzcFBZeUdhek9SWUVKVE9rUS9oanpGMTlWVW1FVy9VNFRKQ3Zk?=
 =?utf-8?B?OHlzMEt2WGVRcnJuRk80eU9DTHBnUmF6OXhja3kyK1R3L3JSc1BacWNDN3RO?=
 =?utf-8?B?a1JxUDh1ZktwRDM4clRncTZVV3drS2lVdmZURmxnUk5RZkNhMTM1QkZMRmpn?=
 =?utf-8?B?dWFEWWQxOUtGaTFqY2JuZ3gxSmlFRXVTWE91TXlEeEtQUDdJSFR0cnBYTEUw?=
 =?utf-8?B?N09lZVhUNFVDbUZCY1F0Y2QrNG04ZTE5dHBZaDRsRUM0L2hGRzFTcXlERWpa?=
 =?utf-8?B?bXJXRFNZcGQ0SlNSM2NTTDNmSmNUWUwzdG9JM25zSHlwTFdFNWozOWZKajh0?=
 =?utf-8?B?UitKcEtya3hpWU0weGlST2gxSFFnOHhaMkMxV1hkdEswRWR0dElQTS81TlZJ?=
 =?utf-8?B?alVjTzJTTjBXalE5UVBvQi93eG1uenJaUFMrcjVjejJ2bzdTYnN3OHNHRGZx?=
 =?utf-8?B?dUx3ZHVKRExzQ3Y3K1dYMDJjeGdRa0NHTzFQSzFUNFpXVGd6djNYYUw3VjBI?=
 =?utf-8?B?VU9ObGFhWmpTenpEdjJ3c2xMeVN0bm12WkNnaUQyd3BScEVoZU1mdlA5UlpC?=
 =?utf-8?B?RTBLd01ORFpKOGIvRllTZE5Xd0RIa1VuN2hmSG10K2xkWjNxTm4xUzR3NkJp?=
 =?utf-8?B?eTkwVC9scjRkZWpwajJhK2h2S04rS1RzcGdnMFdzVHBiNnBNeWphWWw1R2Yr?=
 =?utf-8?B?TGwwTW9hQ0FCN2l0UGlnZjZVRGE4OEVCc0xScngvdzZIUFB1Q3dpZ0VENnhW?=
 =?utf-8?B?RXJpNkg2cWpiZ2pBUFNadHJQN1NlTXFMVGxXcVJ5KzNZSm1MK3c3TlhGNjR6?=
 =?utf-8?B?cnFQcVJHSUdTZ3JSUUhTTmZuK2lsU0NTM0JYZm9BRWF3YkdOUlZGQlRTLzFw?=
 =?utf-8?B?N2pZZ3hBZnZCR3NWbmtXb0g4YkJ5WVEvaWhvMXcrR21nTUs4aUxhRVRYeVln?=
 =?utf-8?B?YkNiTFdEckQ3TUQvcDJGeUpqN29ZeGxqM09YbGVTQy8xbjd0OE9ONG45Y0Vx?=
 =?utf-8?Q?d7ZQav8DXoQ+m+FGdJcX9xQ=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 613b5d61-3e4d-4aa1-c729-08d9e890d06b
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2022 10:18:12.1493
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AG5MZrrVGdXuYSZxt/YvA7eRAMztr5D/oV1bkCKzt1ysiP3deL8VHijwxynW2bCtrE8PVM/aohPNgIGwo+gUqg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR03MB3904
X-OriginatorOrg: citrix.com

Make sure softirqs are processed at least once for every call to
pvh_populate_memory_range. It's likely that none of the calls to
pvh_populate_memory_range will perform 64 iterations, in which case
softirqs won't be processed for the whole duration of the p2m
population.

In order to force softirqs to be processed at least once for every
pvh_populate_memory_range call move the increasing of 'i' to be done
after evaluation, so on the first loop iteration softirqs will
unconditionally be processed.

Fixes: 5427134eae ('x86: populate PVHv2 Dom0 physical memory map')
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
 xen/arch/x86/hvm/dom0_build.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/arch/x86/hvm/dom0_build.c b/xen/arch/x86/hvm/dom0_build.c
index 549ff8ec7c..78d6f1012a 100644
--- a/xen/arch/x86/hvm/dom0_build.c
+++ b/xen/arch/x86/hvm/dom0_build.c
@@ -186,7 +186,7 @@ static int __init pvh_populate_memory_range(struct domain *d,
         start += 1UL << order;
         nr_pages -= 1UL << order;
         order_stats[order]++;
-        if ( (++i % MAP_MAX_ITER) == 0 )
+        if ( (i++ % MAP_MAX_ITER) == 0 )
             process_pending_softirqs();
     }
 
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Sat Feb 05 10:32:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 05 Feb 2022 10:32:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265963.459560 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGIMW-0005pE-LV; Sat, 05 Feb 2022 10:32:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265963.459560; Sat, 05 Feb 2022 10:32:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGIMW-0005p7-IP; Sat, 05 Feb 2022 10:32:12 +0000
Received: by outflank-mailman (input) for mailman id 265963;
 Sat, 05 Feb 2022 10:32:11 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nGIMV-0005ox-Gz; Sat, 05 Feb 2022 10:32:11 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nGIMV-0001hU-Do; Sat, 05 Feb 2022 10:32:11 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nGIMU-0004K6-VB; Sat, 05 Feb 2022 10:32:11 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nGIMU-0000Hs-TO; Sat, 05 Feb 2022 10:32:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=BdVX+qEJJbQrlqFHwiUxcKcINPNfDsh0IYMOuFcoEXc=; b=3JYcF1hXTtASysnJ8fGVJetV0v
	su31yjV4rh2U2GhH7BE/QYAX1ubSaKpKPgXMVPtBufMwtLGBpBqX9qLeOGZ4c+MY2R4G9lJXBMi7y
	IFqfXRCkA5qn3uM9ljZNkkxRRSlaHuYIRaevBUoigPEuSxYgq8K2HeIhe4z2NCkiUDgQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168014-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.15-testing test] 168014: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-4.15-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=7f3b726c6a73ed82d6825f52763bf8943aea5316
X-Osstest-Versions-That:
    xen=3a9450fe5eb0fda8b7069f37d21ce2655bb59da6
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 05 Feb 2022 10:32:10 +0000

flight 168014 xen-4.15-testing real [real]
flight 168023 xen-4.15-testing real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/168014/
http://logs.test-lab.xenproject.org/osstest/logs/168023/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 168023-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167996
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167996
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167996
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167996
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167996
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167996
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167996
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167996
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167996
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 167996
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167996
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 167996
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  7f3b726c6a73ed82d6825f52763bf8943aea5316
baseline version:
 xen                  3a9450fe5eb0fda8b7069f37d21ce2655bb59da6

Last test of basis   167996  2022-02-03 12:39:16 Z    1 days
Testing same since   168014  2022-02-04 17:06:37 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Jan Beulich <jbeulich@suse.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   3a9450fe5e..7f3b726c6a  7f3b726c6a73ed82d6825f52763bf8943aea5316 -> stable-4.15


From xen-devel-bounces@lists.xenproject.org Sat Feb 05 11:07:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 05 Feb 2022 11:07:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265990.459624 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGIuY-0001Q1-6e; Sat, 05 Feb 2022 11:07:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265990.459624; Sat, 05 Feb 2022 11:07:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGIuY-0001Pu-2c; Sat, 05 Feb 2022 11:07:22 +0000
Received: by outflank-mailman (input) for mailman id 265990;
 Sat, 05 Feb 2022 11:07:20 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=yEFf=SU=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nGIuW-0001Po-0q
 for xen-devel@lists.xenproject.org; Sat, 05 Feb 2022 11:07:20 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c84c5a77-8673-11ec-8eb8-a37418f5ba1a;
 Sat, 05 Feb 2022 12:07:18 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id CF933210E8;
 Sat,  5 Feb 2022 11:07:17 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 981B013A6D;
 Sat,  5 Feb 2022 11:07:17 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id SfUNI2Va/mEnGgAAMHmgww
 (envelope-from <jgross@suse.com>); Sat, 05 Feb 2022 11:07:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c84c5a77-8673-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1644059237; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=TRWuygi4XX00RZd4Z/flt6YuzTCY1qHucKFqYYdqECk=;
	b=RuNzHPxI03EkbNLga0ROpvLhex6+EwI/f1oiH6I+PBPNN2m1UcO4YqHpF3T6uAU1Fi1OpY
	oAdus1gzFGNMLaaWStuTvZ+CvOk1qE/ebm0xEuMc1rJJUymh4ot6Dxy1vWgQWpJUgxLpcO
	/7B+kno00KLPDeif8jdtBn7BLQ0VWmw=
From: Juergen Gross <jgross@suse.com>
To: torvalds@linux-foundation.org
Cc: linux-kernel@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	boris.ostrovsky@oracle.com
Subject: [GIT PULL] xen: branch for v5.17-rc3
Date: Sat,  5 Feb 2022 12:07:17 +0100
Message-Id: <20220205110717.16946-1-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Linus,

Please git pull the following tag:

 git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-5.17a-rc3-tag

xen: branch for v5.17-rc3

It contains the following patches:

- 3 documentation fixes related to Xen
- a patch for enabling x2apic mode when available when running as
  hardware virtualized guest under Xen
- a cleanup and fix for a corner case of vcpu enumeration when running
  a paravirtualized Xen guest

Thanks.

Juergen






From xen-devel-bounces@lists.xenproject.org Sat Feb 05 11:13:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 05 Feb 2022 11:13:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.265998.459635 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGJ03-0002ns-Qy; Sat, 05 Feb 2022 11:13:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 265998.459635; Sat, 05 Feb 2022 11:13:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGJ03-0002nl-Nc; Sat, 05 Feb 2022 11:13:03 +0000
Received: by outflank-mailman (input) for mailman id 265998;
 Sat, 05 Feb 2022 11:13:03 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=yEFf=SU=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nGJ03-0002nf-D2
 for xen-devel@lists.xenproject.org; Sat, 05 Feb 2022 11:13:03 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 952d7519-8674-11ec-8f75-fffcc8bd4f1a;
 Sat, 05 Feb 2022 12:13:02 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 894831F37D;
 Sat,  5 Feb 2022 11:13:01 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 38C0D13B24;
 Sat,  5 Feb 2022 11:13:01 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id WSepC71b/mGPGwAAMHmgww
 (envelope-from <jgross@suse.com>); Sat, 05 Feb 2022 11:13:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 952d7519-8674-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1644059581; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=X1PvuDAEPQTFy4s9r+sr8P1ck2l4wpoBR6MmCqPrevQ=;
	b=Ic+DT1l8uDYuirElOMjYKSeCjgCtpoDZ8bp6gHBlhkHFvyrzApc6VdHXw537lAnd3f79db
	PM6uFPyrPdE0rl1ek/X4H6AEfieD91kFIToAonYmTuLu1hE0Fex7VkGxTr2eMXSiDwRwuQ
	roaUnkw9Wf/4rXV4xRBK+mnHuI/p/7g=
Message-ID: <ce764d2a-7368-6fbc-b44b-5c56f876d4d4@suse.com>
Date: Sat, 5 Feb 2022 12:13:00 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Subject: Re: [PATCH v2] docs: document patch rules
Content-Language: en-US
To: Julien Grall <julien@xen.org>, xen-devel@lists.xenproject.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
References: <20220203125438.21807-1-jgross@suse.com>
 <e91bde3e-dc45-c731-7df6-e0e45039d1b2@xen.org>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <e91bde3e-dc45-c731-7df6-e0e45039d1b2@xen.org>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------NTAG9sN85UgH2H1dL8dul0zz"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------NTAG9sN85UgH2H1dL8dul0zz
Content-Type: multipart/mixed; boundary="------------AJL3ZBFSt8tesuqg0Bgx80kv";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Julien Grall <julien@xen.org>, xen-devel@lists.xenproject.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Message-ID: <ce764d2a-7368-6fbc-b44b-5c56f876d4d4@suse.com>
Subject: Re: [PATCH v2] docs: document patch rules
References: <20220203125438.21807-1-jgross@suse.com>
 <e91bde3e-dc45-c731-7df6-e0e45039d1b2@xen.org>
In-Reply-To: <e91bde3e-dc45-c731-7df6-e0e45039d1b2@xen.org>

--------------AJL3ZBFSt8tesuqg0Bgx80kv
Content-Type: multipart/mixed; boundary="------------Zuk8IKGv90zOO45QW1lE95de"

--------------Zuk8IKGv90zOO45QW1lE95de
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMDQuMDIuMjIgMjA6MjUsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gSGksDQo+IA0KPiBP
biAwMy8wMi8yMDIyIDEyOjU0LCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gKyMjIFRoZSBj
b21taXQgbWVzc2FnZQ0KPj4gKw0KPj4gK1RoZSBjb21taXQgbWVzc2FnZSBpcyBmcmVlIHRl
eHQgZGVzY3JpYmluZyAqd2h5KiB0aGUgcGF0Y2ggaXMgZG9uZSBhbmQNCj4+ICsqaG93KiB0
aGUgZ29hbCBvZiB0aGUgcGF0Y2ggaXMgYWNoaWV2ZWQuIEEgZ29vZCBjb21taXQgbWVzc2Fn
ZSB3aWxsIA0KPj4gZGVzY3JpYmUNCj4+ICt0aGUgY3VycmVudCBzaXR1YXRpb24sIHRoZSBk
ZXNpcmVkIGdvYWwsIGFuZCB0aGUgd2F5IHRoaXMgZ29hbCBpcyBiZWluZw0KPj4gK2FjaGll
dmVkLiBQYXJ0cyBvZiB0aGF0IGNhbiBiZSBvbWl0dGVkIGluIG9idmlvdXMgY2FzZXMuDQo+
PiArDQo+PiArSW4gY2FzZSBhZGRpdGlvbmFsIGNoYW5nZXMgYXJlIGRvbmUgaW4gdGhlIHBh
dGNoIChsaWtlIGUuZy4gDQo+PiBjbGVhbnVwcyksIHRob3NlDQo+PiArc2hvdWxkIGJlIG1l
bnRpb25lZC4NCj4+ICsNCj4+ICtXaGVuIHJlZmVyZW5jaW5nIG90aGVyIHBhdGNoZXMgKGUu
Zy4gYHNpbWlsYXIgdG8gcGF0Y2ggeHkgLi4uYCkgdGhvc2UNCj4+ICtwYXRjaGVzIHNob3Vs
ZCBiZSByZWZlcmVuY2VkIHZpYSB0aGVpciBjb21taXQgaWQgKGF0IGxlYXN0IDEyIGRpZ2l0
cykNCj4+ICthbmQgdGhlIHBhdGNoIHN1YmplY3QsIGlmIHRoZSB2ZXJ5IHNhbWUgcGF0Y2gg
aXNuJ3QgcmVmZXJlbmNlZCBieSB0aGUNCj4+ICtgRml4ZXM6YCB0YWcsIHRvbzoNCj4+ICsN
Cj4+ICvCoMKgwqAgU2ltaWxhciB0byBjb21taXQgNjdkMDFjZGI1NTE4ICgieDg2OiBpbmZy
YXN0cnVjdHVyZSB0byBhbGxvdyANCj4+IGNvbnZlcnRpbmcNCj4+ICvCoMKgwqAgY2VydGFp
biBpbmRpcmVjdCBjYWxscyB0byBkaXJlY3Qgb25lcyIpIGFkZCAuLi4NCj4+ICsNCj4+ICtU
aGUgZm9sbG93aW5nIGBgZ2l0IGNvbmZpZ2BgIHNldHRpbmdzIGNhbiBiZSB1c2VkIHRvIGFk
ZCBhIHByZXR0eSANCj4+IGZvcm1hdCBmb3INCj4+ICtvdXRwdXR0aW5nIHRoZSBhYm92ZSBz
dHlsZSBpbiB0aGUgYGBnaXQgbG9nYGAgb3IgYGBnaXQgc2hvd2BgIGNvbW1hbmRzOg0KPj4g
Kw0KPj4gK8KgwqDCoMKgwqDCoMKgIFtjb3JlXQ0KPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoCBhYmJyZXYgPSAxMg0KPj4gK8KgwqDCoMKgwqDCoMKgIFtwcmV0dHldDQo+
PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGZpeGVzID0gRml4ZXM6ICVoIChc
IiVzXCIpDQo+PiArDQo+PiArTGluZXMgaW4gdGhlIGNvbW1pdCBtZXNzYWdlIHNob3VsZCBu
b3QgZXhjZWVkIDc1IGNoYXJhY3RlcnMsIGV4Y2VwdCB3aGVuDQo+IA0KPiBJIHdhcyB1bmRl
ciB0aGUgaW1wcmVzc2lvbiB0aGF0IGNvbW1pdCBtZXNzYWdlIHNob3VsZCBiZSB3cmFwIHRv
IDcyIA0KPiBjaGFyYWN0ZXJzLiBUaGlzIGlzIGJlY2F1c2UgdG9vbHMgbGlrZSAiZ2l0IGxv
ZyIgd291bGQgaW5kZW50IHRoZSBjb21taXQgDQo+IG1lc3NhZ2UgYnkgOCBjaGFyYWN0ZXJz
Lg0KDQpJIHRvb2sgdGhhdCB2YWx1ZSBmcm9tIHRoZSBkb2NzL3Byb2Nlc3MvdGFncy5wYW5k
b2MgZmlsZS4NCg0KQlRXLCBnaXQgbG9nIGlzIGluZGVudGluZyB0aGUgY29tbWl0IG1lc3Nh
Z2UgYnkgNCBjaGFyYWN0ZXJzIG9uIG15DQpzeXN0ZW0uDQoNCj4gDQo+PiArY29weWluZyBl
cnJvciBvdXRwdXQgZGlyZWN0bHkgaW50byB0aGUgY29tbWl0IG1lc3NhZ2UuDQo+PiArDQo+
PiArIyMgVGFncw0KPj4gKw0KPj4gK1RhZ3MgYXJlIGVudHJpZXMgaW4gdGhlIGZvcm0NCj4+
ICsNCj4+ICvCoMKgwqAgVGFnOiBzb21ldGhpbmcNCj4+ICsNCj4+ICtJbiBnZW5lcmFsIHRh
Z3MgYXJlIGFkZGVkIGluIGNocm9ub2xvZ2ljYWwgb3JkZXIuIFNvIGEgYFJldmlld2VkLWJ5
OmAgDQo+PiB0YWcNCj4+ICtzaG91bGQgYmUgYWRkZWQgKiphZnRlcioqIHRoZSBgU2lnbmVk
LW9mZi1ieTpgIHRhZywgYXMgdGhlIHJldmlldyANCj4+IGhhcHBlbmVkDQo+PiArYWZ0ZXIg
dGhlIHBhdGNoIHdhcyB3cml0dGVuLg0KPj4gKw0KPj4gK0RvIG5vdCBzcGxpdCBhIHRhZyBh
Y3Jvc3MgbXVsdGlwbGUgbGluZXMsIHRhZ3MgYXJlIGV4ZW1wdCBmcm9tIHRoZQ0KPj4gKyJ3
cmFwIGF0IDc1IGNvbHVtbnMiIHJ1bGUgaW4gb3JkZXIgdG8gc2ltcGxpZnkgcGFyc2luZyBz
Y3JpcHRzLg0KPiANCj4gVGhpcyB3b3VsZCBuZWVkIHRvIGJlIGFkanVzdGVkIGRlcGVuZGlu
ZyBvbiB0aGUgYW5zd2VyIGFib3ZlLg0KPiANCj4+ICsNCj4+ICsjIyMgT3JpZ2luOg0KPj4g
Kw0KPj4gK1hlbiBoYXMgaW5oZXJpdGVkIHNvbWUgc291cmNlIGZpbGVzIGZyb20gb3RoZXIg
b3BlbiBzb3VyY2UgcHJvamVjdHMuIA0KPj4gSW4gY2FzZQ0KPj4gK2EgcGF0Y2ggbW9kaWZ5
aW5nIHN1Y2ggYW4gaW5oZXJpdGVkIGZpbGUgaXMgdGFrZW4gZnJvbSB0aGF0IHByb2plY3Qg
DQo+PiAobWF5YmUgaW4NCj4+ICttb2RpZmllZCBmb3JtKSwgdGhlIGBPcmlnaW46YCB0YWcg
c3BlY2lmaWVzIHRoZSBzb3VyY2Ugb2YgdGhlIHBhdGNoOg0KPj4gKw0KPj4gK8KgwqDCoCBP
cmlnaW46IDxyZXBvc2l0b3J5LVVSTD4gPGNvbW1pdC1pZD4NCj4gDQo+IE5JVDogTGlrZXMg
eW91IGRpZCBmb3IgRml4ZXMgdGFncywgY2FuIHlvdSBtYWtlIGNsZWFyIHRoYXQgdGhlIGNv
bW1pdCBpZCANCj4gc2hvdWxkIGJlIHRoZSBmaXJzdCAxMiBjaGFyYWN0ZXJzPyBTbyB0aGUg
bGluZS4uLg0KDQpPa2F5Lg0KDQoNCkp1ZXJnZW4NCg==
--------------Zuk8IKGv90zOO45QW1lE95de
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------Zuk8IKGv90zOO45QW1lE95de--

--------------AJL3ZBFSt8tesuqg0Bgx80kv--

--------------NTAG9sN85UgH2H1dL8dul0zz
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmH+W7wFAwAAAAAACgkQsN6d1ii/Ey8Y
Hgf/UQmJHc3llqFxNkNAAsNO0xFsgOqovEjaW5yg0BgxqH2l4abC4LUIefmpGZ85n9AcxGa1kpWO
098u+kdDZVEqOR0PTO2RqSLnWzZ3LB5bZm/1iP4ct0t4MwmWZH2QNvLoRWTfJuse45UyvNo20Of3
xt0JCmghChN4/7KvkMP92MAHXCYNkouGBTKRjNaPvZWsEjdrm+OLXiQyFkGGMTtEbmLInqgyNhfU
HQOqnClGdpuvOGAUJYn6Zoscadbeku9xUY3DLRRQXgf6bAouHRAU5bmYjKYrmKqoHIZi4q10oxE7
EYYBKE9E7AEPAL7/1Qizkp6cLjcZEwoBmoM72aM3Qg==
=KgzN
-----END PGP SIGNATURE-----

--------------NTAG9sN85UgH2H1dL8dul0zz--


From xen-devel-bounces@lists.xenproject.org Sat Feb 05 12:26:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 05 Feb 2022 12:26:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266008.459645 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGK90-0001BZ-8K; Sat, 05 Feb 2022 12:26:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266008.459645; Sat, 05 Feb 2022 12:26:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGK90-0001BS-5B; Sat, 05 Feb 2022 12:26:22 +0000
Received: by outflank-mailman (input) for mailman id 266008;
 Sat, 05 Feb 2022 12:26:21 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nGK8z-0001BI-2b; Sat, 05 Feb 2022 12:26:21 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nGK8y-0003dB-Vd; Sat, 05 Feb 2022 12:26:20 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nGK8y-0001Es-GQ; Sat, 05 Feb 2022 12:26:20 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nGK8y-0002Ka-Fy; Sat, 05 Feb 2022 12:26:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=xKfFze3WaWXlhr+tP7IFM//KJHgVoDwK52OKY8xswf4=; b=qD6Kue5uY/KELkc55RswaovwGo
	CAAN46A1RYGYG5Rob3L9fR6OjAlRKKNNtqpCiLH3KUciBb/Qh5itMYWjmVnk8ZBZlHB+oWOMQjVe2
	IldQDQ/8p3b0N8wOe8oPQB1BbTZbs/SscI75GGFBFM+wAffSUKxMaTh3CL32iz97U+68=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168017-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 168017: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=a4b7aa362d94bbe0287663cab9af4ab503f6185d
X-Osstest-Versions-That:
    ovmf=33189f05278345eab608ff56e87905bdeacdbd47
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 05 Feb 2022 12:26:20 +0000

flight 168017 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168017/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 a4b7aa362d94bbe0287663cab9af4ab503f6185d
baseline version:
 ovmf                 33189f05278345eab608ff56e87905bdeacdbd47

Last test of basis   167989  2022-02-02 18:40:35 Z    2 days
Testing same since   168017  2022-02-04 18:41:45 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Ard Biesheuvel <ardb@kernel.org>
  Michael D Kinney <michael.d.kinney@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   33189f0527..a4b7aa362d  a4b7aa362d94bbe0287663cab9af4ab503f6185d -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Sat Feb 05 12:40:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 05 Feb 2022 12:40:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266020.459657 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGKMZ-0003SO-Hn; Sat, 05 Feb 2022 12:40:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266020.459657; Sat, 05 Feb 2022 12:40:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGKMZ-0003SH-Ej; Sat, 05 Feb 2022 12:40:23 +0000
Received: by outflank-mailman (input) for mailman id 266020;
 Sat, 05 Feb 2022 12:40:22 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nGKMY-0003S7-Fv; Sat, 05 Feb 2022 12:40:22 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nGKMY-0003po-Ah; Sat, 05 Feb 2022 12:40:22 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nGKMX-0001yD-La; Sat, 05 Feb 2022 12:40:21 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nGKMX-0001bD-L8; Sat, 05 Feb 2022 12:40:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=YvYmAs6piBbpsABO3F4I4x8Sm3KoU/FDq2HE32CxFWs=; b=tWLnxkDjQCVPJBThjF1uu/55gt
	ynlpKQchmix/gIjivGCzqzOqfZI8gqYbUNdcCdtSLApX0Z6DKvfQABSaO8GI23dIlmEy+NOM5nBVa
	ij0myLjDyusHkhOtdvstpu0+yx1NM+B4qoNWoyY9KC9jo2R08PuR+X6fvg9mhPQsRj54=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168015-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.16-testing test] 168015: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-4.16-testing:test-amd64-i386-xl-xsm:guest-saverestore.2:fail:heisenbug
    xen-4.16-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=0da8f3d23f86dafc4781cb75f46722841b87bdbf
X-Osstest-Versions-That:
    xen=0b7aba57b310cfc41287a88c4f9198739706dd71
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 05 Feb 2022 12:40:21 +0000

flight 168015 xen-4.16-testing real [real]
flight 168025 xen-4.16-testing real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/168015/
http://logs.test-lab.xenproject.org/osstest/logs/168025/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-i386-xl-xsm       19 guest-saverestore.2 fail pass in 168025-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167997
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167997
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167997
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167997
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167997
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167997
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail like 167997
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167997
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167997
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167997
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 167997
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167997
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 167997
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  0da8f3d23f86dafc4781cb75f46722841b87bdbf
baseline version:
 xen                  0b7aba57b310cfc41287a88c4f9198739706dd71

Last test of basis   167997  2022-02-03 12:39:17 Z    1 days
Testing same since   168015  2022-02-04 17:06:48 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Jan Beulich <jbeulich@suse.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       fail    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   0b7aba57b3..0da8f3d23f  0da8f3d23f86dafc4781cb75f46722841b87bdbf -> stable-4.16


From xen-devel-bounces@lists.xenproject.org Sat Feb 05 12:41:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 05 Feb 2022 12:41:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266030.459667 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGKO0-00043u-Vg; Sat, 05 Feb 2022 12:41:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266030.459667; Sat, 05 Feb 2022 12:41:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGKO0-00043n-Sf; Sat, 05 Feb 2022 12:41:52 +0000
Received: by outflank-mailman (input) for mailman id 266030;
 Sat, 05 Feb 2022 12:41:51 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nGKNz-00042t-Au
 for xen-devel@lists.xenproject.org; Sat, 05 Feb 2022 12:41:51 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nGKNs-0003sI-V2; Sat, 05 Feb 2022 12:41:44 +0000
Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.193])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nGKNs-0006D8-O6; Sat, 05 Feb 2022 12:41:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=br2bWfu0j617ZJE9HPhSK16fvT3XRgngGuhXvhXBy6M=; b=OxMiI2pS4FEZqYDQwMKiE9gCWK
	QPpj3tyy++riGRdRtsI1zqdYczlWXu2cI9Vi+UyV5Zx16i3OF1pzMZkrmZvhgII0Dj2F8EPgFIFc2
	sgg3PgmG1JrtBRPtrl3pGr9iYPx6q5MqVHq0+vF8K8z1SKwgBJPktM+pXPvfla6m92fg=;
Message-ID: <dfe15bd7-8816-2b7a-2193-6ec4efaccded@xen.org>
Date: Sat, 5 Feb 2022 12:41:42 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.1
Subject: Re: Xen data from meta-virtualization layer
To: Michael Walle <michael@walle.cc>
Cc: Stefano Stabellini <stefano.stabellini@xilinx.com>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>, Zhiqiang.Hou@nxp.com,
 brucea@xilinx.com, cornelia.bruelhart@zal.aero, leo.krueger@zal.aero,
 Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>,
 Peng Fan <peng.fan@nxp.com>, xen-devel <xen-devel@lists.xenproject.org>
References: <alpine.DEB.2.21.2011241743490.7979@sstabellini-ThinkPad-T480s>
 <20220204135814.1033356-1-michael@walle.cc>
 <alpine.DEB.2.22.394.2202041256040.4074808@ubuntu-linux-20-04-desktop>
 <faa7864d4df6d9373a3c6b489d3e4469@walle.cc>
 <CAJ=z9a0GX31E-yQRO3BpOujOCX09yOeeROkC57PzAUTUm3HV6g@mail.gmail.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <CAJ=z9a0GX31E-yQRO3BpOujOCX09yOeeROkC57PzAUTUm3HV6g@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit



On 04/02/2022 23:29, Julien Grall wrote:
> This message is harmless. This is printed because Xen on Arm
> doesn't hypercall the hypercall to add a PCI device. On Arm,

I meant "doesn't need the hypercall...".

> we don't need it yet (it might be necessary for PCI passthrough) and
> MSI/MSI-X are handled/registered the same way as on bare-metal
> (for your case through the ITS)
> 
>>
>> Not sure if it should work nonetheless.
> 
> I looked through the log and couldn't spot anything obvious. However,
> skimming through Linux, I noticed there are some changes in the
> ITS for freescale (now NXP) such as:
> 
> drivers/irqchip/irq-gic-v3-its-fsl-mc-msi.c
> 
> Is it something that might be used on the board you are using?
> 
> If the answer is yes, then my suggestion would be to look
> how this is meant to interact with the ITS. It might be possible
> that we are missing some pieces in Xen to properly support it.

Another tree you might want to look at is 
https://source.codeaurora.org/external/imx/imx-xen. It contains a bunch 
of patches for NXP SoC that was never upstreamed.

> 
>>
>>> It is possible that someone in CC to this email might already have a
>>> patch to introduce parsing of iommu-map in Xen.
> 
> Pass. I don't have any and couldn't find any submission on the ML.
> 
> 
>>
>> I guess they've used the old mmu-masters property.
>>
>> Btw. I don't know if it matters, but the SMARC-sAL28 normally doesn't
>> use TF-A and runs without it. Nonetheless, I've booted the board with
>> the bl31 from NXP and it doesn't help either. There is still a
>> difference between the NXP bootflow which uses bl1/bl2/bl31/u-boot
>> and this board which uses u-boot-spl/u-boot or u-boot-spl/bl31/u-boot.
>>
>> I just found GIC setup code in the bl31. I'll also have a look there.
>>
>> -michael
>>
>> [1] https://pastebin.com/raw/XMjE3BvG

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Sat Feb 05 15:48:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 05 Feb 2022 15:48:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266054.459726 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGNIV-0004Ju-K4; Sat, 05 Feb 2022 15:48:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266054.459726; Sat, 05 Feb 2022 15:48:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGNIV-0004Jn-H1; Sat, 05 Feb 2022 15:48:23 +0000
Received: by outflank-mailman (input) for mailman id 266054;
 Sat, 05 Feb 2022 15:48:22 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nGNIU-0004JY-2J; Sat, 05 Feb 2022 15:48:22 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nGNIT-00070N-W4; Sat, 05 Feb 2022 15:48:22 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nGNIT-0003An-Ar; Sat, 05 Feb 2022 15:48:21 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nGNIT-0006V7-AP; Sat, 05 Feb 2022 15:48:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=aOC+N7qq5mlPgg0ga8yzpRzouUhYsi7E60SaxvhQkSo=; b=r56Dpqw0A3Ul9I/PMQpP3a37vn
	BeE0u5gvq7e/0QUlMfHsbjFkoHnTu7DT8Wlpi+b8PYrqBHUUV/Jr+KRRyDlkRME2/wBdNVTR52ME8
	aqD8n4XNTfWhhc2JSx97iX8YuxNyE5AkqoDbNLGhYAE04ubkA3BBYvo2ReAP/mddsqao=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168016-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 168016: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-amd64-i386-freebsd10-amd64:guest-start/freebsd.repeat:fail:heisenbug
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=31f59af395922b7f40799e75db6e15ff52d8f94a
X-Osstest-Versions-That:
    qemuu=8f3e5ce773c62bb5c4a847f3a9a5c98bbb3b359f
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 05 Feb 2022 15:48:21 +0000

flight 168016 qemu-mainline real [real]
flight 168026 qemu-mainline real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/168016/
http://logs.test-lab.xenproject.org/osstest/logs/168026/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-i386-freebsd10-amd64 21 guest-start/freebsd.repeat fail pass in 168026-retest

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168000
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168000
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168000
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168000
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168000
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168000
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168000
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168000
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                31f59af395922b7f40799e75db6e15ff52d8f94a
baseline version:
 qemuu                8f3e5ce773c62bb5c4a847f3a9a5c98bbb3b359f

Last test of basis   168000  2022-02-03 16:08:17 Z    1 days
Testing same since   168016  2022-02-04 17:37:00 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  John Snow <jsnow@redhat.com>
  Peter Maydell <peter.maydell@linaro.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              fail    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   8f3e5ce773..31f59af395  31f59af395922b7f40799e75db6e15ff52d8f94a -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Sat Feb 05 17:59:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 05 Feb 2022 17:59:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266067.459737 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGPKs-0008MS-0h; Sat, 05 Feb 2022 17:58:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266067.459737; Sat, 05 Feb 2022 17:58:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGPKr-0008ML-TB; Sat, 05 Feb 2022 17:58:57 +0000
Received: by outflank-mailman (input) for mailman id 266067;
 Sat, 05 Feb 2022 17:58:57 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=B8c5=SU=linuxfoundation.org=torvalds@srs-se1.protection.inumbo.net>)
 id 1nGPKr-0008MF-7y
 for xen-devel@lists.xenproject.org; Sat, 05 Feb 2022 17:58:57 +0000
Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com
 [2a00:1450:4864:20::62f])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 38b43ebf-86ad-11ec-8eb8-a37418f5ba1a;
 Sat, 05 Feb 2022 18:58:30 +0100 (CET)
Received: by mail-ej1-x62f.google.com with SMTP id st12so4461476ejc.4
 for <xen-devel@lists.xenproject.org>; Sat, 05 Feb 2022 09:58:28 -0800 (PST)
Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com.
 [209.85.221.49])
 by smtp.gmail.com with ESMTPSA id p5sm212254ejr.105.2022.02.05.09.58.26
 for <xen-devel@lists.xenproject.org>
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Sat, 05 Feb 2022 09:58:26 -0800 (PST)
Received: by mail-wr1-f49.google.com with SMTP id f17so17327047wrx.1
 for <xen-devel@lists.xenproject.org>; Sat, 05 Feb 2022 09:58:26 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 38b43ebf-86ad-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linux-foundation.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=WXQN/i75UpM9/xOZNnsDaFN+ADwpyirVq8QEFHiKvd0=;
        b=PegbMigLRlHjM3CKIz16Ycv/mUvmdJBAgkBr/+/h71H9yIQ6RZwnx+IWeyI1/NTm4M
         /5lz8h/5g1V7wYcwxakyZ4E+oaHWUKSOgTQ9YQscYwglYW6V3XUOJPlUjOmt6Z1RcQtm
         jzvZ7KpvdoX49rGUYwPTVXdujyDcjBUJ8A2lY=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=WXQN/i75UpM9/xOZNnsDaFN+ADwpyirVq8QEFHiKvd0=;
        b=fvwMxWzmFOcaA/pYtR2MRbWqbmAzfeoJg9Xp26xcJDDRvBMzKsw4fBHwrZfSffMt23
         nrLjj3iX3lJQxW42Lp192hYDCNqUSX1pxGJ34XWPZ2h8zpmYSgb7PxNF9FIcgNowvtVt
         2fkyKa3DyncDb0RKHXiVF38QBYofvvHjmLFOAB7WenPXJMXgzH+KYdkYPCSqM0PTD+QS
         5kPqHR7gDKlfOF5JSb3A4NOFJQEcWJsEH9FAhzA291QBoas54Lg5XD+0w4+8FvwWvHPf
         FDRFcWhghva18Q6PJN93jgf6o1gDZUJ+BbrDnncu//f2F5LI8XTxsVw7oiziggcKx8FR
         UemA==
X-Gm-Message-State: AOAM531wiUSh8LkdqJShr6lYPrqli8fl9ly9SKEd56kcVCvjzjTGwFtl
	OPSAMWHDfCCkuKdTO9nwcjcuunzh/SRkylhe
X-Google-Smtp-Source: ABdhPJwsNssjiTrjIiZhjT3slrlbr1RfyrsRKxXLpoRr6I2BK5ESIrZp7j02tVapTzVL0qyoL/PKKA==
X-Received: by 2002:a17:907:1b16:: with SMTP id mp22mr3967224ejc.537.1644083907622;
        Sat, 05 Feb 2022 09:58:27 -0800 (PST)
X-Received: by 2002:a5d:500c:: with SMTP id e12mr3760593wrt.193.1644083904052;
 Sat, 05 Feb 2022 09:58:24 -0800 (PST)
MIME-Version: 1.0
References: <20220205110717.16946-1-jgross@suse.com>
In-Reply-To: <20220205110717.16946-1-jgross@suse.com>
From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Sat, 5 Feb 2022 09:58:08 -0800
X-Gmail-Original-Message-ID: <CAHk-=wjp-h4bFWsWSPQ+5o6iuiPwiFNRNxfDSaDjURzVU6Af7A@mail.gmail.com>
Message-ID: <CAHk-=wjp-h4bFWsWSPQ+5o6iuiPwiFNRNxfDSaDjURzVU6Af7A@mail.gmail.com>
Subject: Re: [GIT PULL] xen: branch for v5.17-rc3
To: Juergen Gross <jgross@suse.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, xen-devel@lists.xenproject.org, 
	Boris Ostrovsky <boris.ostrovsky@oracle.com>
Content-Type: text/plain; charset="UTF-8"

On Sat, Feb 5, 2022 at 3:07 AM Juergen Gross <jgross@suse.com> wrote:
>
> Please git pull the following tag:
>
>  git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-5.17a-rc3-tag

Diffstat? Shortlog?

This is not a valid pull request.

           Linus


From xen-devel-bounces@lists.xenproject.org Sat Feb 05 18:43:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 05 Feb 2022 18:43:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266075.459749 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGQ1K-0004rN-Cn; Sat, 05 Feb 2022 18:42:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266075.459749; Sat, 05 Feb 2022 18:42:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGQ1K-0004rG-9k; Sat, 05 Feb 2022 18:42:50 +0000
Received: by outflank-mailman (input) for mailman id 266075;
 Sat, 05 Feb 2022 18:42:49 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=B8c5=SU=linuxfoundation.org=torvalds@srs-se1.protection.inumbo.net>)
 id 1nGQ1J-0004rA-AP
 for xen-devel@lists.xenproject.org; Sat, 05 Feb 2022 18:42:49 +0000
Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com
 [2a00:1450:4864:20::531])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 69984477-86b3-11ec-8eb8-a37418f5ba1a;
 Sat, 05 Feb 2022 19:42:47 +0100 (CET)
Received: by mail-ed1-x531.google.com with SMTP id cz16so2348522edb.8
 for <xen-devel@lists.xenproject.org>; Sat, 05 Feb 2022 10:42:47 -0800 (PST)
Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com.
 [209.85.128.50])
 by smtp.gmail.com with ESMTPSA id kw5sm1887123ejc.140.2022.02.05.10.42.45
 for <xen-devel@lists.xenproject.org>
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Sat, 05 Feb 2022 10:42:45 -0800 (PST)
Received: by mail-wm1-f50.google.com with SMTP id
 l123-20020a1c2581000000b0037b9d960079so2892749wml.0
 for <xen-devel@lists.xenproject.org>; Sat, 05 Feb 2022 10:42:45 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 69984477-86b3-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linux-foundation.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=Yedd43eoRIQVyiayOZs+IHIZcg34X3iy8HzQvrX9+vc=;
        b=hJAo4nCSeYMJ9Z1J9DLNxUS3UWhozfpff6fWvdKoMHKOHVRLCUA9T84HiX8JsPuWD+
         zlF7puaUJnJzD2sBbcdSHRZKQXScVFP+1RPq1+bhEyQ6TSceYhr3Kc1o0sz0eIcKdXmQ
         Q09O3kCl53O/XzGFDSeS63WviWTSewwSwtZpw=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=Yedd43eoRIQVyiayOZs+IHIZcg34X3iy8HzQvrX9+vc=;
        b=jyCf/D9a1JbkjaJwZ+KKTBgl9z67cpFPCFz2RDr/NOLLm3Hk6xyIep37utypoWV8Nu
         wGzASP9osP5lSfHDsIOnl5Isvg2ihKDsME8bZWTExaW52BLpZPx9nT3jdXmgcD4mRnAb
         rDibqyPoFvUUJgHs9g6CDC/Knh+WjpwglBXWo8cXrqN9TnjyLZkzWsKgXV3qWnW+JAkv
         DocugYTdZp/nstwlim6Q/5xBwAUulZB5EeNtDn6VRoazWdTLVhbA9opJ85KLIqM96UCe
         uAdZOrHu6i6Sy2QI4kCcs5UhjETZrufhXpSWHPlnWNACFWr5nzXxhn3SXqBz6Y5wJpKa
         sCLw==
X-Gm-Message-State: AOAM530GO2DGssRZA0zM2RD3RimGxijGjKahi+yw2e/FO/AAWTgFe0fK
	GRJDZ971NQaaYydn++/f97sppjsAwJ0kSKrY
X-Google-Smtp-Source: ABdhPJz3hkCN8v17i3lb3hTqGAAQdcu9hZU0Jg6DcHU4iDT1z0FRZSmt4BElLPuoSfZjx2M5p2bu5A==
X-Received: by 2002:a05:6402:5209:: with SMTP id s9mr5770381edd.154.1644086566545;
        Sat, 05 Feb 2022 10:42:46 -0800 (PST)
X-Received: by 2002:a05:600c:3846:: with SMTP id s6mr7597505wmr.26.1644086565037;
 Sat, 05 Feb 2022 10:42:45 -0800 (PST)
MIME-Version: 1.0
References: <20220205110717.16946-1-jgross@suse.com> <CAHk-=wjp-h4bFWsWSPQ+5o6iuiPwiFNRNxfDSaDjURzVU6Af7A@mail.gmail.com>
In-Reply-To: <CAHk-=wjp-h4bFWsWSPQ+5o6iuiPwiFNRNxfDSaDjURzVU6Af7A@mail.gmail.com>
From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Sat, 5 Feb 2022 10:42:29 -0800
X-Gmail-Original-Message-ID: <CAHk-=wj_ObnioAixXdec63_aXXaS8SUEAsMQgfiHwhXNOYMn5Q@mail.gmail.com>
Message-ID: <CAHk-=wj_ObnioAixXdec63_aXXaS8SUEAsMQgfiHwhXNOYMn5Q@mail.gmail.com>
Subject: Re: [GIT PULL] xen: branch for v5.17-rc3
To: Juergen Gross <jgross@suse.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, xen-devel@lists.xenproject.org, 
	Boris Ostrovsky <boris.ostrovsky@oracle.com>
Content-Type: text/plain; charset="UTF-8"

On Sat, Feb 5, 2022 at 9:58 AM Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> On Sat, Feb 5, 2022 at 3:07 AM Juergen Gross <jgross@suse.com> wrote:
> >
> > Please git pull the following tag:
> >
> >  git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-5.17a-rc3-tag
>
> Diffstat? Shortlog?
>
> This is not a valid pull request.

Oh well. You're likely offline - I ended up just checking your
description instead.

But in general I really do want shortlog and diffstat as a way to
double-check that the pull contains what you think and claim it does,
and there are no surprises..

               Linus


From xen-devel-bounces@lists.xenproject.org Sat Feb 05 18:45:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 05 Feb 2022 18:45:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266082.459760 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGQ40-0005T1-SM; Sat, 05 Feb 2022 18:45:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266082.459760; Sat, 05 Feb 2022 18:45:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGQ40-0005Su-OL; Sat, 05 Feb 2022 18:45:36 +0000
Received: by outflank-mailman (input) for mailman id 266082;
 Sat, 05 Feb 2022 18:45:35 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=G0mZ=SU=kernel.org=pr-tracker-bot@srs-se1.protection.inumbo.net>)
 id 1nGQ3z-0005Sj-AR
 for xen-devel@lists.xenproject.org; Sat, 05 Feb 2022 18:45:35 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org
 [2604:1380:4601:e00::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c8ebf6a2-86b3-11ec-8eb8-a37418f5ba1a;
 Sat, 05 Feb 2022 19:45:31 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 11985B80CAC;
 Sat,  5 Feb 2022 18:45:26 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPS id D61B1C340E8;
 Sat,  5 Feb 2022 18:45:24 +0000 (UTC)
Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org
 (localhost.localdomain [127.0.0.1])
 by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id
 C58A2E5D07E; Sat,  5 Feb 2022 18:45:24 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c8ebf6a2-86b3-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1644086724;
	bh=fcalSUfcC3f+A4OPK37VCIh9FGFzTW9J646wvOQUfd4=;
	h=Subject:From:In-Reply-To:References:Date:To:Cc:From;
	b=jfrYf5pgoQt/pgjiwYAAWXNH4J5yx7nB2f7MsQqX5d5wXlHvtT2YKxTPrMB0Gqq8t
	 Wvs539nPCJfCsoRHVDliTaEtkqfg3B/HbTjmikv7H1N8fyPniUaZwHVjlMTR6x4B1a
	 tOscvPcEiFHVPJ+9a7I2QKnS7gzMA1fZTz42DyzOO6UhY3GmFxtkLE+1F2Yr5R5iaP
	 MmmnC3rUB16DkUrE6Hw0B8f6POneUnN7tyMmcgwIdhfirx69zgN9x+GIUi0qfNHyTV
	 kMMCtno6SsaysWYnOSVPTY1kZTsSQY0zI99AmBltiti/hBCuSAZn36W+wrUu5f9Yb0
	 C1PAWTjyamH+g==
Subject: Re: [GIT PULL] xen: branch for v5.17-rc3
From: pr-tracker-bot@kernel.org
In-Reply-To: <20220205110717.16946-1-jgross@suse.com>
References: <20220205110717.16946-1-jgross@suse.com>
X-PR-Tracked-List-Id: <linux-kernel.vger.kernel.org>
X-PR-Tracked-Message-Id: <20220205110717.16946-1-jgross@suse.com>
X-PR-Tracked-Remote: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-5.17a-rc3-tag
X-PR-Tracked-Commit-Id: e25a8d959992f61b64a58fc62fb7951dc6f31d1f
X-PR-Merge-Tree: torvalds/linux.git
X-PR-Merge-Refname: refs/heads/master
X-PR-Merge-Commit-Id: 90c9e950c0def5c354b4a6154a2ddda3e5f214ac
Message-Id: <164408672480.8633.6221021066979381394.pr-tracker-bot@kernel.org>
Date: Sat, 05 Feb 2022 18:45:24 +0000
To: Juergen Gross <jgross@suse.com>
Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com

The pull request you sent on Sat,  5 Feb 2022 12:07:17 +0100:

> git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-5.17a-rc3-tag

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/90c9e950c0def5c354b4a6154a2ddda3e5f214ac

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html


From xen-devel-bounces@lists.xenproject.org Sat Feb 05 19:01:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 05 Feb 2022 19:01:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266092.459771 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGQJS-0007pe-Ar; Sat, 05 Feb 2022 19:01:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266092.459771; Sat, 05 Feb 2022 19:01:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGQJS-0007pX-7s; Sat, 05 Feb 2022 19:01:34 +0000
Received: by outflank-mailman (input) for mailman id 266092;
 Sat, 05 Feb 2022 19:01:33 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nGQJR-0007pN-3M; Sat, 05 Feb 2022 19:01:33 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nGQJR-0002Qw-0l; Sat, 05 Feb 2022 19:01:33 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nGQJQ-0004zZ-II; Sat, 05 Feb 2022 19:01:32 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nGQJQ-0001o0-Hr; Sat, 05 Feb 2022 19:01:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=xFiXEFskEba2IOH644UGwIzowJgawY7XkMKtfhmNeco=; b=MIQZartAkXNuMDO+FSG3rLY9M4
	wxy+SwjwjWa9v8LGfzFP3K4cq01syrLJtjhyz3iOMlxYxHgJ9xXFJQg5NVmlW8F7sJiLxRSKDK0mD
	5oS/iBLIjJ+n9q03ke9OQbbF+MjW07BMJ2VVwyyVAFV6ND5QPFK38h2HbT98z3baNhgQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168021-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 168021: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=f087335034eb03e4ac8b1d93d18fbbca842467d3
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 05 Feb 2022 19:01:32 +0000

flight 168021 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168021/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              f087335034eb03e4ac8b1d93d18fbbca842467d3
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  575 days
Failing since        151818  2020-07-11 04:18:52 Z  574 days  556 attempts
Testing same since   168021  2022-02-05 04:23:36 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brad Laue <brad@brad-x.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Christophe Fergeau <cfergeau@redhat.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Divya Garg <divya.garg@nutanix.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Emilio Herrera <ehespinosa57@gmail.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Ivan Teterevkov <ivan.teterevkov@nutanix.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Lubomir Rintel <lkundrak@v3.sk>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nicolas Lécureuil <neoclust@mageia.org>
  Nicolas Lécureuil <nicolas.lecureuil@siveo.net>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Rohit Kumar <rohit.kumar3@nutanix.com>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  shenjiatong <yshxxsjt715@gmail.com>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tuguoyi <tu.guoyi@h3c.com>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Vineeth Pillai <viremana@linux.microsoft.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yasuhiko Kamata <belphegor@belbel.or.jp>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 96326 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Feb 05 20:14:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 05 Feb 2022 20:14:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266106.459786 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGRRq-0006HW-QN; Sat, 05 Feb 2022 20:14:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266106.459786; Sat, 05 Feb 2022 20:14:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGRRq-0006HP-NM; Sat, 05 Feb 2022 20:14:18 +0000
Received: by outflank-mailman (input) for mailman id 266106;
 Sat, 05 Feb 2022 20:14:17 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nGRRp-0006HF-KT; Sat, 05 Feb 2022 20:14:17 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nGRRp-0003fX-I4; Sat, 05 Feb 2022 20:14:17 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nGRRo-0008OM-7r; Sat, 05 Feb 2022 20:14:16 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nGRRo-0006Oe-7P; Sat, 05 Feb 2022 20:14:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=aAH4m6wP6p6kd+SxvhopjwyPir9nyQUn7QgQQJ6k7+w=; b=exkz20Tc17U9ideMPlGth0cmdm
	xuZOVuTn1VAcutz+fWmgOLb34Kc2+55q/vKasJVlXTFq5hiAJRDUGxX/k3+vH3OSNXfWvxtESQbcP
	lES8znAaDhcPXxCuZvkYNs3+ROpBKiOanBO4c0OkPglJfp/sIt9dGzkjfC46ie31HX0M=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168018-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 168018: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=820cc393434097f3b7976acdccbf1d96071d6d23
X-Osstest-Versions-That:
    xen=75cc460a1b8cfd8e5d2c4302234ee194defe4872
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 05 Feb 2022 20:14:16 +0000

flight 168018 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168018/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168008
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168008
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168008
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168008
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168008
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168008
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168008
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168008
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168008
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168008
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168008
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168008
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 xen                  820cc393434097f3b7976acdccbf1d96071d6d23
baseline version:
 xen                  75cc460a1b8cfd8e5d2c4302234ee194defe4872

Last test of basis   168008  2022-02-04 11:09:13 Z    1 days
Testing same since   168018  2022-02-05 00:39:33 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Jan Beulich <jbeulich@suse.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   75cc460a1b..820cc39343  820cc393434097f3b7976acdccbf1d96071d6d23 -> master


From xen-devel-bounces@lists.xenproject.org Sat Feb 05 21:06:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 05 Feb 2022 21:06:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266119.459797 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGSGe-00037o-R3; Sat, 05 Feb 2022 21:06:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266119.459797; Sat, 05 Feb 2022 21:06:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGSGe-00037h-O3; Sat, 05 Feb 2022 21:06:48 +0000
Received: by outflank-mailman (input) for mailman id 266119;
 Sat, 05 Feb 2022 21:06:46 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=vIk1=SU=citrix.com=George.Dunlap@srs-se1.protection.inumbo.net>)
 id 1nGSGc-00037a-Ox
 for xen-devel@lists.xenproject.org; Sat, 05 Feb 2022 21:06:46 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 84a6b80a-86c7-11ec-8eb8-a37418f5ba1a;
 Sat, 05 Feb 2022 22:06:44 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 84a6b80a-86c7-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644095204;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=bBcNgdzqaIV25K+0a8PQTba+I3Zfq0Gy/TP+peWPSvE=;
  b=M4cIoGZZvrlXN0fM7p0H/O1XEg7wYDmD4LOlFpYgXGpRxj0p5Rt4VXmA
   EtNWQJJJLwiJxyDzkelR3ztpTp9KmRLYTPiA+P6o6W4ybi+bIKKfyHyaJ
   4kFQtjPfA7uHfFEHX9i4IKS9pQdVMOe6DyJU66+jnitVvlbYgHJuzLZjZ
   E=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: U0iOjcFc4Bq0eNLUcwwYIhfO+R3SSl33MRcxtvQX/0XT8ojPcNCmk6NvI4jQyIZH8sCyUFDukC
 GcC2Z5OFgCQruybd1BP+6I5lqkFZECzcJDHPoPN58FM9RM4vtA/KDd0D+YHkW/PTDLG+RjClCD
 glayBs7GrSJRQeDJsaCs/rCX4V62+fvNALrQov7lAToLkpO6pf9NkH/1u88AeRd4fwii6IRkEY
 zI0ZeEM2ugEnYzxXgd3BuJFFlQ1FU7O3zEkkOJfaj/kUeRrIlnM1bWsHLlMXqcrolSCtmJK3YM
 DoJ5L3ZA8bdqetUINh97mJpB
X-SBRS: 5.1
X-MesageID: 63979404
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:LhB3daNrPuTJtl/vrR1HkMFynXyQoLVcMsEvi/4bfWQNrUol1GQGx
 jFKUGDUMvaOM2Gge4x3Pt+yoEoGv5aDm4A1Swto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6UUsxNbVU8En1500o+w7RRbrNA2rBVPSvc4
 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq
 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYoxuik4poz
 thria2Pd1YpA4H2scEXYxYNRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs
 6VFdnZdNXhvhMrvqF6/YsZhgd4sIY/HIYUbs2lIxjDFF/c2B5vERs0m4PcGh2Zv15wWQZ4yY
 eIWeAJ0cy/wZSdjeWZLNag/uduommfWJmgwRFW9+vNsvjm7IBZK+KfpGMrYfJqNX8o9tlaVo
 CfK8nr0BjkeNceD0nyV/3S0nOjNkCjnHoUIG9WQ1NRnnVmSzWw7EwANWB2wpvzRt6Klc4sBc
 QpOoHNo9PVsshzwJjXgY/GmiFCvskQFXdd2L9wF1lCN94buyiOTNmdRG1atd+canMMxQDUr0
 HqAkNXoGSFjvdWpdJ6NyluHhWjsYHZIdAfucQdBFFJYuIe7/OnfmzqSFo4LLUKjsjHi9dgcK
 RiupTN2ubgchNVjO06TrQGe2GLESnQko2cICuTrsoCNs1sRiG2NPdXABb3nARBodtvxor6p5
 yBspiRmxLpSZaxhbQTUKAn3IJmn5uyeLBrXikN1Ep8q+lyFoiD/IdgIuG4heh81Yq7onAMFh
 meJ5Gu9A7cIZBOXgVJfOdrtW6zGM4C8fTgaahwkRoUXOcUgHON21CpveVSRzwjQfLsEyskC1
 WOgWZ/0Vx4yUP0/pBLvHrt1+eJ7l0gWmDKILbimnkvP+eTFPha9F+xaWGZim8hktctoVi2Oq
 I0BXyZLoj0CONDDjt7/q9JKfQtUfCRkWfgbaaV/L4a+H+avI0l4Y9f5yrI9YY112aNTk+bD5
 HamXUFEjlH4gBX6xc+iMxiPsZvjAsRyq2wVJyspMQr60nQve9/3vqwea4E2bf8s8+k6lax4S
 PwMesOhBPVTS2uYp2RBPMel9IEyJg62gQ+uPja+ZGRtdZBXWAGUqMTveRHi9XdSA3Pv59c+u
 bCpyijSXYEHG1Z5FM/TZf/2lwGxsHERlfhcRUzNJtUPKkzg/JIzc376j+MtItFKIhLGn2PI2
 wGTCBYehO/Mv45qr4WZ2fHa99+kSrIsEFBbEm/X6aeNGRPbpmfzk5VdVOuofCzGUD+m8quVe
 ugIner3N+cKnQgWvtMkQapr1683+/Dmu6ReklZ/BHzOYlmmVuFgL32B0ZUdv6FB3OYE6w6/W
 0bJ8dhGI7SZfsjiFQdJdgYia+2C09ASmyXTsqtpcBmruncv8erVS1hWMjmNlDdZfel8P44Sy
 Os8vNIbtl6kgR0wP9fa1i1Z+gxg9JDbv3nLYn3CPLLWtw==
IronPort-HdrOrdr: A9a23:IiY5Lq/L0K/e36izVjtuk+F8db1zdoMgy1knxilNoENuHfBwxv
 rDoB1E73LJYW4qKQwdcdDpAtjkfZtFnaQFr7X5To3SIDUO31HYbb2KjLGSjAEIfheRygcz79
 YYT0ETMqySMbE+t7eB3ODaKadh/DDkytHRuQ629R4EJmsKC52IrT0JcTpzencGHjWubqBJcK
 Z0k/A3wQZIDk5nCfhTaEN1PdTrlpnurtbLcBQGDxko5E2lljWz8oP3FBCew1M3Ty5P6a1Kyx
 mHryXJooGY992rwB7V0GHeq75MnsH699dFDMuQzuAINzTXjBqybogJYczBgNl1mpDr1L8Zqq
 iKn/4SBbU015oXRBDtnfLZ4Xil7N/p0Q679bbXuwq5nSWzfkNENyMIv/MmTvKe0Tt8gDg06t
 M640uJ85VQFh/OhyL7+pzBUAxrjFO9pT44nfcUlGE3a/pVVFfAxbZvjX+9Pa1wVB4S0rpXW9
 WGzfuskMp+YBefdTTUr2NvyNujUjA6GQqHWFELvoiQ3yJNlH50wkMEzIhH901wuK4VWt1B/a
 DJI65onLZBQosfar98Hv4IRY+yBnbWSRzBPWqOKRDsFb0BOXjKt5nriY9Fqd2CadgN1t8/iZ
 7BWFRXuSo7fF/vE9SH2NlR/hXEUAyGLH3QIwFllu5EU5HHNcjW2By4OScTepGb0oYi6+XgKo
 OOBK4=
X-IronPort-AV: E=Sophos;i="5.88,346,1635220800"; 
   d="scan'208";a="63979404"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=RciyYAx32QMF15E4su+ygtpN4ZtLj+EGqjpcl5L6ZwU/hp+LdVfEJXsn3N4JAA254UCZ/Gh4fiB9ulELfHcISvoyoE9qHee/ptMD7vV/UaY8l+iSsvcBEiO0G3XtbbJOAOJjxp+r4+pFDunWaIRxnLTuQs1EuFfXxw9nFcfCJ0yf1dyqAbfyznp+02bMy81/+Fu7B1pE/nf4s+FNFgfBXmxZQDJd1MBCaJVN6fGEn+Dwoo0bwtPjkGeR9/HiA0/cRzAy6gNKsvmQtk6AyDr9Tb/F/zl4CX6zEOU0Zb/IJ4ciAkRIyoMa2ddUL7BdIzpmFjmsbKzIzZBVN7ueGt+VYQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=bBcNgdzqaIV25K+0a8PQTba+I3Zfq0Gy/TP+peWPSvE=;
 b=k2U93ROcZipFt3yij51V2+PAQVXYppZmjTWgOae8pPZ1aOcx4RFZ+16xmvaPAUAXgdy82Hjs3EEPcucnC6lxtiqcc+FpxENHvcpCRvAesUvRtkfiijMwpA1SC1v0dPN/jOJcH/54aZXsgnBpOzpmtmYgM4qGKG89sW+ND/F7OYJKgzGA8tNtJ0aSOHRodDNT8ZtBQGdNGwKWrxeZSzgC1So56Fh/NTXVmAECXuDbsN3ZbMrQj49al/YeEE/o92GrpV80oFmsU5Cqp+zF/KrgjEwmXjmIHYXIdEK/J3q/dz0+PuLjsSN6x07cAX5P54I92+41TRR9/JVMBxWlpCLUwg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=bBcNgdzqaIV25K+0a8PQTba+I3Zfq0Gy/TP+peWPSvE=;
 b=mtFRoIiMhwEQJEMsG4RLipHuacUZ4R+QtZhoWxOhzWjDHNg3aloKLKXm4MmkDEAzkRiHVJ+WOfSraTmHApiZxakxDK/sCQP1pCVYRR0NzPITRQw+zEdiTHPsdfeJBOCswEKKgPZsaBFGC43KNSyEsLSgfeUJeLeXdjejETAmsO0=
From: George Dunlap <George.Dunlap@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Andrew
 Cooper" <Andrew.Cooper3@citrix.com>, Wei Liu <wl@xen.org>, Roger Pau Monne
	<roger.pau@citrix.com>
Subject: Re: [PATCH 05/16] x86/mm: move guest_physmap_{add,remove}_page()
Thread-Topic: [PATCH 05/16] x86/mm: move guest_physmap_{add,remove}_page()
Thread-Index: AQHXcbfpNpZFZZE1mEO1hN8seL+XRKyGxRaA
Date: Sat, 5 Feb 2022 21:06:38 +0000
Message-ID: <E3A90AE4-1325-49C6-B043-2CBFF1F6F273@citrix.com>
References: <d1fd572d-5bfe-21d8-3b50-d9b0646ce2f0@suse.com>
 <3636b781-d84e-6e95-6bb8-bc6a7c596912@suse.com>
In-Reply-To: <3636b781-d84e-6e95-6bb8-bc6a7c596912@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3693.60.0.1.1)
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: da6df83d-8312-433e-914f-08d9e8eb6670
x-ms-traffictypediagnostic: BN7PR03MB4388:EE_
x-microsoft-antispam-prvs: <BN7PR03MB4388ED62DC74A4AC30FB260A992A9@BN7PR03MB4388.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:6430;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: oYCOPmesQBQJnTGPpi5pztYoCg2/LkgtiFJdczDsQyFAuqckGyPVX5XBYzHEpINGd7ITxNTH1TEa34/zM9NtHmFvIcMrq/8j5wG0SCnU37K+LSPD4ZWyIQKFytKYXwDH/ma5z5vrq38rF/IMtAC0PuPMbuIxovsDHzGLdj9m9a2pMV+oXpJzdX7YYgqC39fSJCgqBZDcKRS3PAP6ffuyILl1XSmUF3g5CmXyOGMUuo7fFTlZccprIq7fLz0hHTZ3q1mnqmfGPm4i4apDN/T5aPFQO0crYFQ+TK+wNYH1noFuKV/BaV+6ug0LKsG9iAcpds7kN4rKRi5lrf10aZnjG3NYHU5alMtm+yRYPKWt7ZoIIfiORrpSFcy3hI06D6GQjSxH4C6SdzfxBBo4BJ1Js7mxVvVql0GDGeUBC0WvCpUqdCdHIHpQc2mzaFiJPFYuP7knrx8a3PEb8HmWQV7SXFdAcx7/hAyxEdAjHkHfR3T7ANpQRmfFaiKvCLU4DXg6+b3nrc+r8RKiF7kJ7UcoaMq6NQSQi9bk+JiWkcWHUsDI0aLpWXHlTPdy6OydrttWOhzrqJcg5KXCmgGG7Qbx9lZTU5iv/fMWe2qY7yh0murSbxOR9XaDT35lOVGq5f/MaoH+ZilPWX+HGB29HVElpPfSTL1f0tQ68FDrzSHMoI3KWv2jP3uKAoITDLWoMfn5qSaa8t6COex0lo5ekRYOqUhmZ2LI3sYGkDSWIY1WAWTIZBgWwlAQORDPHHFki8U+
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(26005)(186003)(86362001)(66476007)(8936002)(38100700002)(107886003)(66556008)(66946007)(76116006)(4326008)(82960400001)(508600001)(33656002)(6916009)(6486002)(64756008)(54906003)(2616005)(66446008)(316002)(91956017)(71200400001)(8676002)(2906002)(6506007)(6512007)(53546011)(122000001)(5660300002)(4744005)(38070700005)(36756003)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?3Ckks0KUxotlKq7uNOLV5WucSXkJm30nlL5IyY4o3pK57o7diUvqEA0zsh2H?=
 =?us-ascii?Q?UBeinALvE4Oq0iI3ytKjiXEJYutYhkMyzLnTvwPlDCVcwslDtHUTmybeUorZ?=
 =?us-ascii?Q?uXZrOlcc/iL2M504c6bneew80COGJ//Gt9HFswxnc0iJcY5mZ/Jv6y72toDG?=
 =?us-ascii?Q?xrL6z52x2++x/vcq0Jc6oSBSdBB/cOO1pCmMMTNrvGGNNbEZD/3hHewWBGRb?=
 =?us-ascii?Q?OE0bymQz3EeCSIC2du7h1Z+Vopz5h+8LgR+8+4eFu5dJKoCWexF/Brj7UpTe?=
 =?us-ascii?Q?CZ26V0hM93jGPTFSw8NCR/+l1pqJPc7ZKrI0k36R4mLEZ44TwygKvHojn4Gx?=
 =?us-ascii?Q?4eFgPBqGPq54DisOUaDy7V+qgloXEX+QfGKgrIe7tHBWOeIRRqghf2VZ5KuX?=
 =?us-ascii?Q?E6nHv1NUa3m/QxDAaBDaRBxewaEyTbrw739sgVdawyalZj7VB2xcSTubI1h6?=
 =?us-ascii?Q?HNlEeDt0XG+POGW1bwcoiWvcF3ziwdir2bWFrbgPHi7lV6tkrTYiBVUJeXSk?=
 =?us-ascii?Q?q79amLVNyDGkPDbacffBaAGXrRhitSCJ9tOE+el8bjA2DoWwpMUhMISj44rT?=
 =?us-ascii?Q?qncsilxLpdb1J6eLdM8RGIrsbXlDqTD+xyC/Iun1Dd9haXasU8+Ysbk4XBsE?=
 =?us-ascii?Q?yGhSVbrj7tucBfNPUKjQHTzfIJBit/sEwQd3Df3iXNlzGhUeiSBJzPhMoZ0b?=
 =?us-ascii?Q?OxspnFahhQXyBMHwum5NZqTMQyJXY6CGorNSP3aS9F5NTaBeFDNzBMElP0F1?=
 =?us-ascii?Q?gBoVCnbbiflZsrvK3MJSzEe8mpLon5QfF/1U8B/qFLbimfe5yMEi1S+406JY?=
 =?us-ascii?Q?JqalZkEcEjBePZU7EbYryLauGiJZWL1DXLLJZYOFe9qsZqMTth31TmyUHn++?=
 =?us-ascii?Q?Iw/t7WDOs3tMmIIDsUSJme4JrQigMaMPoBn7hdLBr52KMB3oc06ErOJqNX35?=
 =?us-ascii?Q?SVge66g+3cbdBQaBZN1AeVN9S6nzIexMrac8gcvyO/Gm6q7MlG6iF71roG3k?=
 =?us-ascii?Q?l6LyiQlQKKfOFqc2AO/8smZJVAtpInkfts/faJFNUT1mggf0aO69n72grPyg?=
 =?us-ascii?Q?Yu0FMmDSW8tdsyQ7je6bKcwi5A+MNbQeirvHNjSGD26kXsAI8YTXyvwx1H+i?=
 =?us-ascii?Q?WTHmXK6Oq16oIHSV2u6kIFtV73E8HHrnCk9sjn9ETPAIjjlCs6mhsr7sY8ma?=
 =?us-ascii?Q?KQVKcs3V1jGWc2lCWk9Nxb/0FbeTrC5Cc8FR2WR6ocH3B0wJR24wzOhz+Nyd?=
 =?us-ascii?Q?Lg0iKGap5o2xaVSbatqs0Z273OlOo69RPWpsKuK1f1Gm92zguy8e5Ry9OZwa?=
 =?us-ascii?Q?e6PlzuGyFwVFUC8he7Xneg8XM1Ia/yF5TaZLEtSayC6FDtKNJ/MlwjRh9UOq?=
 =?us-ascii?Q?br75m9erBjkuxTRJ/drOyWxDtyFbBVck66tmI8i+8xo0Fu7nV9AzMjxUxH+3?=
 =?us-ascii?Q?Z7ovOTk5AQDxDGYxNGzzTBhgzXe5/reTeioIKkDN3CoouuRTHUhxIY2thYYf?=
 =?us-ascii?Q?S1XrmnQgm4NTJsomxhJGEzZRSzI+x7h7rMCnEs+S7j2WH4OmR0wL56qEfU/e?=
 =?us-ascii?Q?9Z2+zigcYeTk5AGj6JAxtBhOAIl0L1+ZLzBlKFtwva/piuzF0EO6TsfmE6/9?=
 =?us-ascii?Q?yjlg3T61VFDEcV1HvThr0/zkR0QAkc4dJeAEFIBOOeCdl/zeB1NWX2tjJlAj?=
 =?us-ascii?Q?I2q9jcS4Iix3hAN/nZqAlYIkUz0=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <B8735DF42A121D4597793C3C5C145780@namprd03.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: da6df83d-8312-433e-914f-08d9e8eb6670
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Feb 2022 21:06:38.1216
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: PET/MKuNPXdcMZp6t7yOEY0WiPkTxsg+X8dnsk2q79pGGRlJqKK9bsolXpK7PZM6/kaI2+Xaq0NTUC3M1BFOFjSQW7jMVbALP0kp4oGPW1M=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB4388
X-OriginatorOrg: citrix.com



> On Jul 5, 2021, at 5:07 PM, Jan Beulich <JBeulich@suse.com> wrote:
>=20
> ... to a new file, separating the functions from their HVM-specific
> backing ones, themselves only dealing with the non-translated case.
>=20
> To avoid having a new CONFIG_HVM conditional in there, do away with
> the inline placeholder.
>=20
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: George Dunlap <george.dunlap@citrix.com>



From xen-devel-bounces@lists.xenproject.org Sat Feb 05 21:09:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 05 Feb 2022 21:09:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266126.459807 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGSJD-0003k3-8o; Sat, 05 Feb 2022 21:09:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266126.459807; Sat, 05 Feb 2022 21:09:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGSJD-0003jw-5t; Sat, 05 Feb 2022 21:09:27 +0000
Received: by outflank-mailman (input) for mailman id 266126;
 Sat, 05 Feb 2022 21:09:25 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=vIk1=SU=citrix.com=George.Dunlap@srs-se1.protection.inumbo.net>)
 id 1nGSJB-0003jo-U5
 for xen-devel@lists.xenproject.org; Sat, 05 Feb 2022 21:09:25 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e3b87fb2-86c7-11ec-8f75-fffcc8bd4f1a;
 Sat, 05 Feb 2022 22:09:23 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e3b87fb2-86c7-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644095363;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=VThZqsP0hF+BBVqsQwoAOJ1CnDhBpeqvJqFOhAvnfOc=;
  b=ZW+QE+1NrqJCpJC1bBWtzc8uk4xVKMx9uH2b/3GASxjONTz2D4kX3G37
   aDkPulEfjm72R8ZLEd0TfNsc1Uuw2pnxHHd/vH7bUM1Y+T3qTLPIYY/Hj
   QC6UGicQvJK/f9mAvI5nwpw1esNf+WZni+zIqGqpfkbALocOiaxYbMocy
   U=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: wYUqT4zFvHe43JS4YJiis1mBm8CtL1wLjyWeBj4RhzAX5HNIiBJvNURP5HqgG0mLqaR8I/763f
 xH8FuARomth3awvkv6UfyeBcRvYfqkUMSbJ5Aqs/mBUIdPXLqwcWFrySDjEywSLFPiTPMA9/n4
 qAbpikjsEiWd3P23IlV//JoH2g1oEl9ws/8SW4l/ZRzs8OLMjDWAWhzDiUgpV8qoVN3+ory5Pd
 HgIQfJgESj7Iut0vGgikRbXQXH3IggyXPjbUz06jkfNC5Mpwe/KsAqcZ3wdmWAz8ucBzUA5Zyy
 TDRWsMYZ38l7W+TlfIU/E8XZ
X-SBRS: 5.1
X-MesageID: 63486111
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:EsczIKwi42d8dd0GwcB6t+fVwSrEfRIJ4+MujC+fZmUNrF6WrkUCn
 GQWW2/Taa6JYjGjeNx1aoq18xsHv5Lcn9JmSARk+yAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAhLeNYYH1500g7wbZk2tQAbeWRWGthh
 /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL
 wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt9tam
 PJVs4Dpcxw0DPPsnu8Ra0R1QxgraMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr
 6ZBbmlQMFbT3Ipaw5riIgVorusuK9PkMcUzp3dkxCnxBvc6W5HTBa7N4Le02R9u3ZweQ6+HP
 qL1bxIzdDjFURtfO2sbGaJlmN+FiFjwYTxH/Qf9Sa0fvDGIkV0ZPKLWGMXRUsyHQ4NShEnwj
 nLL+SH1Dw8XMPSbyCGZ6TS8i+nXhyT5VYkOUrqi+ZZConee22gSAx0+TkagrL+yjUvWZj5EA
 xVKoGx09/F0rRH1CImmN/GlnJKalhU3C/1IFfFj0hqQ+PT05Q2VPjUpHgcUPbTKq/QKbTAt0
 1aImfbgCjpurKCZRBqhy1uEkd+hEXNLdDFfPEfoWSNAuoC++99r0nojW/4+SPbdszHjJd3nL
 9lmRgAajq5bs8ME3r7TEbvv02P1/cihouLYC2zqsoOZAuFROdbNi2+AswGzARN8wGCxFATpU
 J8swJD20Qz2JcvR/BFhuc1UdF1T296LMSfHnXlkFIQ7+jKm9haLJN4MvGkmfBg2bJ5YKVcFh
 XM/XysLufe/21PxNcdKj3+ZUZx2ncAM6/y5PhwrUja+SscoL1LWlM2fTUWRw3rsgCARfVIXY
 v+mnTKXJS9CU8xPlWPuL89EiOND7n1ulAv7GMGgpzz6gOX2TCDOE98tbgDRBt3VGYvZ+W05B
 f4EbJDUo/ieOcWjChTqHXk7dwxTfSNlVMyp96S6tIere2JbJY3oMNeIqZsJcI15haVF0ODO+
 3C2QEhDz1Tjw3bALG23hrpLMdsDhL5z8iA2OzICJ1Gt1yRxaIqj9v5HJZA2YaMm5KpoyvstF
 6sJfMCJA/JuTDXb+mtCMcmh/dI6LBn71xiTOyeFYSQke8IyTQL+5dK5LBDk8zMDD3TruJJm8
 aGgzA7SXbEKWx9mUJTNcPuqwl7o5Sodlet+UlHmON5WfEmwooFmJzao1q08It0WKAWFzTyfj
 l7EDRAdrOjLgok07NiW2vzU89b3S7NzRxMIEXPa4LC6MTjh0lCimYIQAvyVeT39VX/v/Pnwb
 +ti0PyhYuYMm0xHstQgHu8zn74+/dbmu5RT0h9gQCfQd12uB75tfiuG0M1IuvEfz7NVo1LrC
 EeG+90cMrSVIsL1VlUWIVN9POiE0PgVnBjU7Og0fxqmtHMmouLfXBUAJQSIhQxcMKBxYdEsz
 uoWscIL7xCy10gxOdGcgyEIr2mBIxTsiUn8Wk321GMztjcW9w==
IronPort-HdrOrdr: A9a23:F9nIN6t9SPzWyQeG4XJ9yLyY7skC0oMji2hC6mlwRA09TyXGra
 +TdaUguSMc1gx9ZJh5o6H8BEGBKUmskKKceeEqTPmftXrdyReVxeZZnMrfKlzbamLDH4tmu5
 uIHJIOceEYYWIK7voSpTPIaerIo+P3sJxA592ut0uFJDsCA8oLjmdE40SgYzZLrWF9dMAE/f
 Gnl656Tk+bCBIqh7OAdx44tob41r/2vaOjRSRDKw8s6QGIgz/twqX9CQKk0hAXVC4K6as+8E
 De+jaJpZmLgrWe8FvxxmXT55NZlJ/K0d1YHvGBjcATN3HFlhuoXoJ8QLeP1QpF4t1HqWxa1e
 UkkS1QePib2EmhOF1dZiGdgjUI5Qxer0MKD2Xo2UcL7/aJHw7SQPAx+r6xOiGplXbI+usMjZ
 6jlljpx6Z/HFfOmj/w6MPPUAwvnk2ooWA6mepWlHBHV5ACAYUh57D2bCtuYeY99Q/Bmcga+d
 NVfYrhDTdtACenRmGcunMqzM2nX3w1EBvDSk8eutaN2zwTmHxi1UMXyMEWg39FrfsGOtV5zv
 WBNr4tmKBFT8cQY644DOAdQdGvAmiIRR7XKmqdLVnuCalCMXPQrJz85qkz+YiRCdE15Yp3nI
 6EXEJTtGY0dU6rAcqS3IdT+hSIW2m5VSSF8LAW23G4gMyLeFPGC1zwdLkeqbrWnxxEOLypZx
 +aAuMiP8Pe
X-IronPort-AV: E=Sophos;i="5.88,346,1635220800"; 
   d="scan'208";a="63486111"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ZBOfeayyjK7541SFCw9puvDxqGARRF0xYVF7uJ1521Mf+nyG6qQBbtxKbQHoCgBU2Nsf6bg0rrEZDNNdhi0+JP01QV+ErWqyX7jOJ13MBdqhP3vO+WrPw38+frc7yDohn1aP+3emBFq/MDDg280jUZ3uuEVPXFVylDik6eOYlXHbmn/EewMsSOiAkv+fRgRoGfJh9w2ZLLJKq8vNzPgP7S/DRAML3a2SnCv2saMmZTGWen60+kmOL1VHrHz9frxG19XBrOVzn1aLQawCcOOYVtqtNLEg9SYNjsv1NFoTAed8OfmYgr9HqPbH89QOawmsorOv4vqhz9jyiR8xecrJww==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=VThZqsP0hF+BBVqsQwoAOJ1CnDhBpeqvJqFOhAvnfOc=;
 b=a3IzMIX7ezTMvErnbCrEUAHv2YULOxbyGvYERJP2Wvqxe5qrHTYTmqc2p8CGTg7++v012nF9wXPMcHs6n9g93y3ALSgA9AR9FZJov+MkJcjSOV7c8rUSuReT97SPFYPq/Xkbk9CNKEh9zCQnajRJVthBRRoBwB7rbBAA8hGCzJoGM0aGNeESFIEWEeKMVjTK9YIts8wJmf9wMRvmWoPl1JNt4NmTQ+WS2gxPL2uLs2Csf8tAqLoM1xIBgIYVM7Y0chrwtPgQcl85iQtInU/DQr7Dgokk2wbN8H53TI6lxq7YXQyPmd2NaKvILPxC2Z6iJOgfAW0Dx/7s7Yx+XMqbVw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=VThZqsP0hF+BBVqsQwoAOJ1CnDhBpeqvJqFOhAvnfOc=;
 b=bsqiKyCjeBSu/TV7RFKypH+BcD77+g/xvffzwFtm5kNr4kNftF2vu9g/dR3/SCFQwqzKlSumvvXnQNPEDbRT8CiQqgoLDnCW+Y8BZ0pnXt0adYlJxuJkTS5v7wRrP4M1aSHpXQe8j2DZzzLK6CZXV18Rhv2wJjDB98+GgVs1+0w=
From: George Dunlap <George.Dunlap@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Andrew
 Cooper" <Andrew.Cooper3@citrix.com>, Wei Liu <wl@xen.org>, Roger Pau Monne
	<roger.pau@citrix.com>
Subject: Re: [PATCH 06/16] x86/mm: split set_identity_p2m_entry() into PV and
 HVM parts
Thread-Topic: [PATCH 06/16] x86/mm: split set_identity_p2m_entry() into PV and
 HVM parts
Thread-Index: AQHXcbgBTxDdyiQTqEquM7UvU49ReKyGxdMA
Date: Sat, 5 Feb 2022 21:09:16 +0000
Message-ID: <360968C5-AC73-435A-9AD1-63BCC0ED8EC6@citrix.com>
References: <d1fd572d-5bfe-21d8-3b50-d9b0646ce2f0@suse.com>
 <90ea840a-0966-0cf8-39f0-f8ef3fb45786@suse.com>
In-Reply-To: <90ea840a-0966-0cf8-39f0-f8ef3fb45786@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3693.60.0.1.1)
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 052d5c3e-9871-446f-e188-08d9e8ebc512
x-ms-traffictypediagnostic: SA0PR03MB5386:EE_
x-microsoft-antispam-prvs: <SA0PR03MB5386D6DB58608B45D584011A992A9@SA0PR03MB5386.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:1824;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: tSqCCO0DwGeicqNF+tGcg4MIQnc/mu5EEVU2y2aeNlbXVZdP0Kg0gwtjIZ/AHJCQb1g/kavW2B9jCSrFFOIcpRAcHBZXMuGDC72XUzr/PwhvVu9bzVzU5cZgbEeD5/vDmbOcb8YLsKfbeOmXgvutQYpvFj26DgvJLtkc4cBTsvilWkrfXIJkbDwEab37ZmK19D3APIqweQc+jqBIrSM+kxs41neA6rJxdtRNqTM4L5W7850z4ccV4bEWoj4DVKJTZFFmImEyvg7A3krki/pL9nuDEGbFPcbOMulALUDaDLW6FYIDhZNYHUzav3ELdGUKHJrjoc7jfKZxFsoAtu8wi533YA5G5AkRLWZOC2ptpWNc8QhRYNiWOaSECuAiuUQkKGSYbk8GTTWTI23DFfv+evmKB8aqJhgMe60ida/6UDPH4tEGtzF7QiC0YSbnddHZlA6+TXd/KbSff6MaM70Qy8mvyHeBnO7p6qtc0Yu/ikSF511QD0No1P8SgIVlkXh1+0Mn3hcSDfElwVP5ql5Pv4R17TWQhG7Wbq1PZDLGspJisTssJyBoUfXEqJJs5pECrr2WlJKYq0Es8pVmVwVifHsiC1rXGq5jCMbq0Mt2YGK9bPOsCNLCcTDihLiINqh3zwzdXL8lK7gvAcZGQWntCBE+pUinIRc9L0H8xoXz/zKlEQB5eMUsA3z9rkBprOSd2vKViDWtqHXy2v2tdLLSpORAZCxsbNqXsQ5Ys7QR83rYaGEZCN6DxNB9yj0C1j3qDMnxN2wGqJo2ujx71eEiVA==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(4326008)(186003)(122000001)(5660300002)(82960400001)(26005)(71200400001)(76116006)(36756003)(2616005)(508600001)(107886003)(38100700002)(33656002)(66476007)(6486002)(91956017)(8676002)(6512007)(8936002)(64756008)(54906003)(558084003)(38070700005)(66446008)(316002)(6916009)(66556008)(6506007)(66946007)(53546011)(86362001)(2906002)(70780200001)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?f0hSVZFMvIXO2EVlIB9WDxS19ReFpiaHhYs4VIA7qVDNEDjDkIX3y/0YZDtA?=
 =?us-ascii?Q?rAsox2zbU488mqj6ATLB0XIbW4r2ZO0Rk6sHF8LMnJIRPQ0UEcwyW5TpsNKu?=
 =?us-ascii?Q?66oynPpiwvFamTboI59mZj73GG/dM0KbmiVgwZqhb7QNYh/PCTv4Qy+Gll/T?=
 =?us-ascii?Q?ZnmexrsReiVLY6oDQIlRMxYRZQqUTOQJ95w5VcqBBo7OJPlybNYpUSLXf7i6?=
 =?us-ascii?Q?XkN7vyLeQlaismGVB0gCunl61rOO225UoGqqzy4y83HYdzxIWPQBHrYGYx8H?=
 =?us-ascii?Q?INtPlvO4VIlWaMAh9EWjqrm4m8JA7oQ9FC0sJRH+IaXz8JuRKvxOv7p4bEDB?=
 =?us-ascii?Q?Ylrl1l6l8UGHf3e4fRT58p4sYvr2YBNqknkyndsMj6yv8Uy2XE29bz92hJxo?=
 =?us-ascii?Q?YWgtnZdqEMRX5CityRzqgJJozszDUc6+hJ+VxKBEJ1bAjo2nDRjFs2s8Wrh1?=
 =?us-ascii?Q?8u166HYvCEjAw1A1Ta7Rcf5vC+wBLKQYQEKJlZEJpsovvlyJPHg0gvLLe3Ui?=
 =?us-ascii?Q?I3OHDPqz9GYKstT5+Z0R24jZDNO4FCiQF1yiWfuAZCQStuwfu66BAAGXlv68?=
 =?us-ascii?Q?pGcYeSKlDpGGAaxMD5s+PLgvRext4MXOOeGFbIFf3d5oyErSiR6PMhu44mX+?=
 =?us-ascii?Q?e1HUkpbcL/yakwtGOJsAdbKsWQX+D/uM0m/zAUe+1ZERxXIsJqDIZu2dwZjH?=
 =?us-ascii?Q?oRHr0jMKMnloFNA27afJQc9nJnHfNX53ybeKJTBf78fQ05BVmUETGPPY0cFK?=
 =?us-ascii?Q?I1BowbaB0pPhF4D1SqTY17MevuheGZtQ9VAhGIbFdtMrr+lF3r5qeaaYOWSG?=
 =?us-ascii?Q?FSiqkZNwV6Q/POz5e41Vd83Nndg8vbhj4OQal6g1m4jJxDAp+r8SPapbMFWR?=
 =?us-ascii?Q?TL7gBBXjN9STRaFJr4t7BnnZeJy/vk2a4EaHbHKQx9n20ewcLLMYhDvxtZGo?=
 =?us-ascii?Q?6rm8fXKesf0vbHjfpFAjK0jGFcccPUec3xG/kBG+PCfTca8SvZf23SnNApYT?=
 =?us-ascii?Q?cv1/Sq3v9ncjy9FJhxuaWdEThWIPBNvKHIzG9yRDjuDd7K309z0HQwT2DAz4?=
 =?us-ascii?Q?Yhmn2WejBoMn0LKy/GsH8dP61McswHoOU4MnAmoHBQQp/D4jUyzH1tGe+n1c?=
 =?us-ascii?Q?u4eJkGqkkMg/QhOn0tQUZeEbqYGn+OTRmjktBVhh/75rlP0M0eTJEQi42DNJ?=
 =?us-ascii?Q?nX2lB0XGBQsoTf+CUffe0/Xzkxhk1Vx6ei5RTQMZB22ZakOtbYwMyaPoYGdt?=
 =?us-ascii?Q?mxmGK8GIgELK5Fdukwx4aG47kpssaqg5R8wa4zALYv7nM3Y/xd6Otj8aaVYh?=
 =?us-ascii?Q?lahHSQlNQSvTEK/mwLE84iwKMD6Qp6SU97M9MUAY5Gq+KvcHLXWy8xdBcLVb?=
 =?us-ascii?Q?4DvMjT9Fp3QDp9NTQhUOLw3hBnGAVTtF0b8bPC8MT8MOSGrUTgNyGv8LtnDW?=
 =?us-ascii?Q?F0/ylkahSYXMO4FSV4mKjcSfYmQSZrmF+mXEGbl0npZlr/YEkR6/RftL0yhl?=
 =?us-ascii?Q?MOKZwJddEiCpIxjkSC+BFORjFzNC5PJUoM5Q1VVcVtSgHro1GU1DnZdSPGGr?=
 =?us-ascii?Q?QR+qcdPxKpuHx/3acjtjr8Og6bH5P6wWYfZY4YNmMCR3c8rU7nyHpYzCiDbQ?=
 =?us-ascii?Q?kJZaIhDhHI7T8GKaSWVIPKT3LBdg1NCEEs2szVcTnRWrmvDXnusxzdy0g51x?=
 =?us-ascii?Q?+PNrEZ8B1dIJYqwOmvM1vOoc/PQ=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <7F4212A9ABDBBC4A9FCE985ECADFC214@namprd03.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 052d5c3e-9871-446f-e188-08d9e8ebc512
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Feb 2022 21:09:16.9849
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 2CE/CaWgfpsnthS6ymnuvnVFq/oIZe96VIeZTr1MGOMl23v6LqhiB+CfWvQUSXQ3zK2hJZEd8TpuXQGV/UcADWyZV5yDEgHLZ6fdE003Ypg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR03MB5386
X-OriginatorOrg: citrix.com



> On Jul 5, 2021, at 5:07 PM, Jan Beulich <JBeulich@suse.com> wrote:
>=20
> ..., moving the former into the new physmap.c.
>=20
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: George Dunlap <george.dunlap@ctirix.com>



From xen-devel-bounces@lists.xenproject.org Sat Feb 05 21:17:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 05 Feb 2022 21:17:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266135.459819 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGSQo-0005ES-2t; Sat, 05 Feb 2022 21:17:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266135.459819; Sat, 05 Feb 2022 21:17:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGSQn-0005EL-Vn; Sat, 05 Feb 2022 21:17:17 +0000
Received: by outflank-mailman (input) for mailman id 266135;
 Sat, 05 Feb 2022 21:17:16 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=vIk1=SU=citrix.com=George.Dunlap@srs-se1.protection.inumbo.net>)
 id 1nGSQm-0005EF-JI
 for xen-devel@lists.xenproject.org; Sat, 05 Feb 2022 21:17:16 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id fc48ff93-86c8-11ec-8eb8-a37418f5ba1a;
 Sat, 05 Feb 2022 22:17:14 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fc48ff93-86c8-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644095834;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=UHUGVH8XVBYvDuaonDUZyEt9BuG+bhZRb7ezM55T+qc=;
  b=gzRL7bnUPRZWSpaGsvQVNDsjm6PjFO+VJ20cy/o75GitbeETlHpfgbYz
   ej2L/kvfYdKLJvcf4BsPX/X+EDDXslGAipE7UofRKsAvjyehEtQsjH6fO
   WOmU7SjpBkU1o0SiwAwRVs/hdZj13vYvXkjQD404oZOyAENCZHQjnnPbn
   c=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: VwHg50y4pQRUJgKRqNNIUl+H/V/SVZrXFTVhnn/rPhVxXdBMUanG84dNK7ZfW9fSLu5fies7n2
 S/WcekcIj7zpXxfMe+yZb8aJyCeWRFPPPi0xSxRR8pEeesqxrK1UIH9ylARxcvQua4nh8hYiYg
 85Jj8dSB95o30uDIVxM2/hJZ2Hu2uhctr8bT+kkDlxsrzeEa9UBMp9lgHuDrWunS80CcU4Dnyg
 FczoCfqWQy5vyqQqB7oWXdeilQHcmRV/4AGw/3mm4LdGC+Si+N1XLZTYaCBGggAMriGW/kBzey
 ZAOCiNT511o/AHFhL6ZPJwUa
X-SBRS: 5.1
X-MesageID: 65782955
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:259yoqsfcy2E446dEtm0VkzROufnVK5ZMUV32f8akzHdYApBsoF/q
 tZmKWmOPfqNYGahLdp+bd/noUwDvpTUz4JgSQU9rS4xQXtG+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZQP0VOZigHtIQMsadUsxKbVIiGHdJZS5LwbZj2NYy2YXhWWthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 NplurbzajoCffD3msslehpYNgJPLI105+qSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DE44YoH5tix3EC/IvWbjIQrnQ5M8e1zA17ixLNaiDO
 JpDOGcyBPjGSwx/IkYIUJQSp9yPrHLOeCV0lkqllbVitgA/yyQuieOwYbI5YOeiWsF9jkue4
 GXc8AzRARwENdrZ1TuM9FqtgPPCmWXwX4d6PJ+S++NugVaT7ncOExBQXly+ydGph0j7V99BJ
 kg8/is1sbN05EGtVsP6XRCzvDiDpBF0ZjZLO7RkskfXkPOSulvHQDhfJtJcVDA4nMAcBh8X/
 RzUpNHGPRVssJi2eGO9xKjB+FteJhMpBWMFYCYFSy4M7N/ivJw/g3rzczpzLEKmpoarQG+tm
 lhmuAB73uxO1pBTi81X6Hia22rEm3TfcuIiCuw7tEqB5xgxWoOqbpfABbPzvacZd9bxorVsU
 RE5dymiAAImUMnleM+lGrxl8FSVCxCtamC0bblHRMFJythV0yT/Fb28GRknTKuTDu4KeCXyf
 GjYsh5L6ZlYMROCNPErP9rpU5t1k/C8RbwJs8w4iPIUP/CdkyfcpElTibO4hTixwCDAb4ljU
 XtkTSpcJSlDUvk2pNZHb+wczaUq1kgDKZD7HvjGI+Cc+ePGPha9EO5dWHPXN7xRxP7U8W39r
 ocEX+PXmko3eLOlOEH/r9VMRW3m2FBmXPgaXeQMLbXdSuencUl8Y8LsLUQJIdA8z/8Lx7uXo
 hlQmCZwkTLCuJEOEi3TAlhLY7LzR5dv63U9OC0nJ1Gz3HY/J42o6c8im1EfJNHLLcRvkqx5S
 ecrYcKFDqgdQzjL4W1FP5L8sJZjZFKgggfXZ3ipZz02fphBQQ3V+4C7IluzpXdWVifn59Ejp
 7CA1x/ARcZRTQpVE8uLOumkyEm8vCZBlbsqDVfIONRaZG7l7JNud37qlvYyLsxVcUfDyzKW2
 hy4GxAdoeWR8YY5/MOQ3fKPrpuzEvs4FU1fRjGJ4bGzPCjc32yi3Y4fD7rYIWGDDDv5ofzwa
 /9UwvfwNOw8sGxL64csQax2ya8e5sf0o+MIxApTA3iWPU+gDaltIyfa0JAX5LFN3LJQpSC/R
 lmLpotBIbyMNc7oTAwRKQ4iYrjR3P0YgGCPv/E8IUG87y5r5ruXF05VOkDU2iBaKbJ0NqIjw
 Psg55FKu1Du1EJyP4bUlD1Q+kSNMmcEAvcuuZwtCYP2jhYmlwNZapvGBy6quJyCZr2g6KXxz
 uN4UEYau4lh+w==
IronPort-HdrOrdr: A9a23:7/ilGKGpsG2JVhVXpLqFspLXdLJyesId70hD6qkvc3Nom52j+/
 xGws536fatskdtZJkh8erwXZVp2RvnhN9ICPoqTMuftW7dySuVxeBZnMXfKljbdREWmdQtrJ
 uIH5IOa+EYSGIK9/oSgzPIUOrIouP3iJxA7N22pxwGLGFXguNbnnxE426gYxBLrWJ9dP4E/e
 +nl6x6Tk2bCBMqh6qAdxs4dtmGg+eOuIPtYBYACRJiwhKJlymU5LnzFAXd9gsCUhtUqI1Ss1
 Ttokjc3OGOovu7whjT2yv49JJNgubszdNFGYilltUVEDPxkQylDb4RHoFq/QpF5N1H2mxa1u
 UkkC1QZvibLEmhJl1dlCGdnDUIFgxesEMKh2Xo20cL6vaJOw7SQ/Ax+76xNCGpt3bI9esMoJ
 5jziaXsYFaAgjHmzm479/UVwtynk7xunY6l/UP5kYvHLf2x4Uh2bD2bCtuYeY99Q/Bmcsa+d
 NVfYvhDTdtACSnRmGcunMqzM2nX3w1EBvDSk8eutaN2zwTmHxi1UMXyMEWg39FrfsGOtZ5zv
 WBNr4tmKBFT8cQY644DOAdQdGvAmiIRR7XKmqdLVnuCalCMXPQrJz85qkz+YiRCdA15Yp3nI
 6EXEJTtGY0dU6rAcqS3IdT+hSIW2m5VSSF8LAX23G4gMy0eFPGC1zwdLkeqbrXnxxEOLypZx
 +aAuMiP8Pe
X-IronPort-AV: E=Sophos;i="5.88,346,1635220800"; 
   d="scan'208";a="65782955"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=moRqSyIg3jsMvxoIPSGnKXa/EhHT2rKFCIJqjHezSZsezm6AGnQ0i5OZk7JZ27i9fYsIq10nSzqiJO4/k4XlokBbQlH05yPlRMbfskuZFypSrEsvT+jVweykYHa7DIKoZdvbSm/+2FHy0PrNfsC9G6CHjxDD2kuRnIgvG12nDBLcdSx+TtK0RanrbHsvNw3QWxsVollnfzJXQr2HKyO/zMwSIi0GgEk5zJ6z8RNqYCfcgTd2DC0sONBDKkbZT2ei8+iC+/97cf9wRa+D8BU9YfHWV8GVgJlU7TzOJVfba2Pulo4rBteAHCSB0IZWgdljAAJn669MZkTDw7tiTvt//g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=UHUGVH8XVBYvDuaonDUZyEt9BuG+bhZRb7ezM55T+qc=;
 b=KWCrkxyXTR30/T3NYq3TpaAXogsBnRzbfbCH+IxTkMCeR5KukP5GdXSrbYlsWfzuAFYEob5bvZffFjPJyjWyNbaqY4gLq1thtWk4JLTtvyAb0ECYNbMc07xpCuVCOCFeXeQc3rFte0kr84NNPm4w2jl7SsIPYyG4pG8w1VyYfOV91JWyJccDLG1vsK0D1BpfGMuVKtUZfp6xB/V/CvU7gofIHgqusjdkybwl0QNSxOaJo2NUCfMIXeZFJiYgXyCoHvnrG/BA2KqQmcQCn7wbayYM81y13XfRVksbq1T2pJ4tT90nXz1Fl5VzGAjtkJ9p0a5o2pqVsDSxxceUSzfwag==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=UHUGVH8XVBYvDuaonDUZyEt9BuG+bhZRb7ezM55T+qc=;
 b=nt3x5y38Qo14nm6n33vN+aHWPbVUnZx5yJUXmGzdg8KLpfGcJK4/4nBkO9qBk6ZnMOPsogt+pmD0PtOgHKyIFbav0Ew8itMA66VeZEVsZTpnI7nDEcSOSv9/ltEsAs3gc/Up7cEfeJ1uoZ4nx6tUA94qmLD2SIITCZZYPqm54M0=
From: George Dunlap <George.Dunlap@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Andrew
 Cooper" <Andrew.Cooper3@citrix.com>, Wei Liu <wl@xen.org>, Roger Pau Monne
	<roger.pau@citrix.com>, Kevin Tian <kevin.tian@intel.com>
Subject: Re: [PATCH 07/16] x86/P2M: p2m_{alloc,free}_ptp() and
 p2m_alloc_table() are HVM-only
Thread-Topic: [PATCH 07/16] x86/P2M: p2m_{alloc,free}_ptp() and
 p2m_alloc_table() are HVM-only
Thread-Index: AQHXcbg11+nupplxqUK7UHem5UW9BayGyAYA
Date: Sat, 5 Feb 2022 21:17:09 +0000
Message-ID: <99920444-F6CD-4026-8680-F3C18484F070@citrix.com>
References: <d1fd572d-5bfe-21d8-3b50-d9b0646ce2f0@suse.com>
 <fcd39881-e225-d1a7-a168-9aa9fd9a7735@suse.com>
In-Reply-To: <fcd39881-e225-d1a7-a168-9aa9fd9a7735@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3693.60.0.1.1)
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: e5bddee4-7049-4e6f-e179-08d9e8ecde9d
x-ms-traffictypediagnostic: DM5PR03MB2666:EE_
x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
x-microsoft-antispam-prvs: <DM5PR03MB26661F57C78A13E5F131FD76992A9@DM5PR03MB2666.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:1227;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: ZSFeOpRd8Dm/+QmayRw2kFz97mLdQ3mWulEd9vqU7Pbba3Jkl5rEFK1rheydqc0aaCQhOR1wNudK1CQJYGe0Hza1R76q7KldrB+1/yhgYChzm/uyJ5Geo9ulOJ2Ou7rtt5TWskT+Uz7lJxPtkBrvtAhjxXChFSTcWTdfed2mTcFda7o9X2ClciShNy5hhC0tFX4UWa1epLFZ1ud1xzU/s2NERmc81750Oo6KXzT8MYS/+MEx53K5jmvqvdaG10l0fZ2JC1A+ntD16MTCEt24+M7hbPXwG7u7yp/JdC3W2mcgfIJkKBr5u34y7shOyZPOf1k4QXgSNz4mS33HeCsxhL+ovUMWkT7SV/jjrwQnpJ38iEtSFlneYUVMww1W7Top25CE8ormlrkEvhX2JOgO/CinGuZtZ4pyzubQz/bNIwy57er3a8WXFZyy2/7f13MaZLxnyUAK0dsnKYTGrmcLZTdqkL/wMrSJMKYZhW0vVGQBtOEfgmo29Xqa63S6UHE2Q9Xb8tC9/Uay7AHiwh9yVnWbu/vzudEaLkT67Mgtx06Grl9Aeg/wQzmEl81VQUgAb72aklXcPHk28fUJgniiUs5LdfeRhMh5/Y05aPk3kxShc29LJ59KAlVdKdvopPpNRVgs2gHc8kW9QN9aoSnfixcRqAjhPTvOpTu4EcpX9jw9EmYcdK3Qqv/O9OKLaUs5oDEK3RQ6dFiIB6mxqURCeQqD+v3FD9U8PJF3KSIKGEE=
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(122000001)(36756003)(71200400001)(6512007)(2906002)(38100700002)(2616005)(5660300002)(53546011)(6486002)(54906003)(64756008)(8936002)(8676002)(4326008)(66476007)(66446008)(66556008)(316002)(66946007)(86362001)(6916009)(76116006)(91956017)(26005)(558084003)(33656002)(38070700005)(6506007)(508600001)(186003)(82960400001)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?J/TTVb77sh4g09q6yS0MgTMBSp/5W5bqJqWHk0uHhD+UXlnK5d8EN9kZ/eqn?=
 =?us-ascii?Q?puW93/TdOFBW8gnulW3mPiBhu+17pEnieJtFZAwD7g5Z+8HmGp9lw1zEHm/a?=
 =?us-ascii?Q?ueDxtzvJ+dFY4jOjG0v/w41hXl8Lr5jU6s9ZJEPq/lAY3wCAxN2vFC/13pSh?=
 =?us-ascii?Q?Hq5BRUESlb4P81edSaBou/8o5XegBp7NsgQ/O2J7ys3Nl48+KMCob51UHrsu?=
 =?us-ascii?Q?sZzBbn6RxOppXADlMZPXonPuUZKDhrgpvgyQNXaEttGrcfyDmaxo132TeqSR?=
 =?us-ascii?Q?2ilGHsJoWp4zlGRTROwgyWZaiJTpKf8dQ5cUqWfS/6pID+08djZutTNj2Jqb?=
 =?us-ascii?Q?POR9q1F6eowHaP3YZ/cARrlBrhc5chAzXyQk9dcDenPUhshyYlWEPzSdTX45?=
 =?us-ascii?Q?3NeIyPvY18FXbTyZS8Ib3pR3lF7CbuX+lBaC6qzNa12dEFpnwObaw8+azygI?=
 =?us-ascii?Q?DdJa6q/8f/zevlnszZlPHtDZDO8RNSPtbQx8Zgt4d8dHqiT3HFHj0iA+joJe?=
 =?us-ascii?Q?a0CCrrYEaDl5yvNg4Kn53AJTx1oUMktFBWOnWVKL9J8LUMCyShRYVeSv+d4I?=
 =?us-ascii?Q?zdSsCUk6JTU9eHQaFaNGbzCvx6iKSAGQBqvZRdUtAT3/cfVMeZlD8vlXscDv?=
 =?us-ascii?Q?w1Pc4bDQeXB9pZuq9v+K7CoPS+M1M9QDTMElJui9iJdFcr56lp5Hrs6gem1F?=
 =?us-ascii?Q?xtRIkN38zT1BQAmn8fSqv0c7KuDWRbkzF/NgceK2cUz1PWThzkGcJEQKPEa4?=
 =?us-ascii?Q?l9uWRbeIRqcYORo8qspYYma70GLdhfA+rb8cacHainnRN3ytUYi3a8MS6Aff?=
 =?us-ascii?Q?k4S2jb1atqNS7mLWvZdaohbl/cnekbF6pze48OR0ctXgEF1+ux8XDcGYQw0+?=
 =?us-ascii?Q?UiA6OQxqv4gqs517AZDhbKf8TxeoEgSXI93H/KjIfv/TvT+8N7S9DA1g8ie9?=
 =?us-ascii?Q?iCc7dqLYQtk0WbkdS2SGTn2p33gn1i1NQXEIYImFfR8+fHMmb2pRJjsbejax?=
 =?us-ascii?Q?UZ3qrdkrlOj4m+4+i8gX2XKm4KSgEhhGPX8VQ/cwNCkjnX00xALrrE3IwRML?=
 =?us-ascii?Q?j6IOnuEKEfCGeTTfUpfNNKJB+JVgeMW/+V4AHifrQkkZRTgoNDx34+l+iVUs?=
 =?us-ascii?Q?IU1ZzM0qwHZPyC8NH7SK1DY5CePK/g/2BKEepncrpiIi1TQ5j8x8wDPqmW5c?=
 =?us-ascii?Q?/O/ua+lF84FMp1q4UyXvYyxpDdGNzM/DCeR1N3/yKALOVk34vzXrVn4BtU+F?=
 =?us-ascii?Q?k2WX20pOkuT+VJr1s1H0ne8WS+Mi73JZBaexQ4kAJivvzWrMRM5kIs03L3qk?=
 =?us-ascii?Q?Sn4J24ZWm3lKNawbRHbQ3wyDASDvQWVgs9zvXZn6O0ZmEzzRgHkgciCuB84A?=
 =?us-ascii?Q?DEcf1rKygO/3IsXQV9RKnCPHCWie4EkieJE5owsVGFrJgT5ZTsPRgvrMtSx8?=
 =?us-ascii?Q?NYJ0chkD03WsuCC6DNp9+MJup9zRggILSEJu1+BEqgM4d2wUMvrFuEBZojRb?=
 =?us-ascii?Q?yc2ffD4CJlZQq6hHkB+CsHJjEsT1oYTUNxPq4DCH2QCsXSpIoU0hHzluLcA/?=
 =?us-ascii?Q?2SOdqKuz50wnJEZ7b4QLD6dbEtbCcf1NufOxUpL/THtngAFVbksJujzPSzkd?=
 =?us-ascii?Q?GlpWStUa4Vxu1u4jtdS1a6QoJMCzQLD7FOKnllJYrPzQUR8I6uGU/jymgtbt?=
 =?us-ascii?Q?X8TX9mAtHFNyLWKjGGrd/CtCDl8=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <89AD5DB88BFCBF4CBAC5A9FA9B5DE0D4@namprd03.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e5bddee4-7049-4e6f-e179-08d9e8ecde9d
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Feb 2022 21:17:09.3200
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 2UFhHeu1WqIa3dgeZvEPVH3QHcekbttccdxdo+2tjUOlEKCpLzffcUlBHcq/fkozXE+3+sPY08PQq8NTtNmvhNvuEFhJN6kK5vKFRUCo/LY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2666
X-OriginatorOrg: citrix.com



> On Jul 5, 2021, at 5:09 PM, Jan Beulich <JBeulich@suse.com> wrote:
>=20
> This also includes the two p2m related fields.
>=20
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: George Dunlap <george.dunlap@citrix.com>



From xen-devel-bounces@lists.xenproject.org Sat Feb 05 21:29:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 05 Feb 2022 21:29:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266144.459830 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGScq-0006lb-Ba; Sat, 05 Feb 2022 21:29:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266144.459830; Sat, 05 Feb 2022 21:29:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGScq-0006lU-8L; Sat, 05 Feb 2022 21:29:44 +0000
Received: by outflank-mailman (input) for mailman id 266144;
 Sat, 05 Feb 2022 21:29:43 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=vIk1=SU=citrix.com=George.Dunlap@srs-se1.protection.inumbo.net>)
 id 1nGScp-0006lN-8N
 for xen-devel@lists.xenproject.org; Sat, 05 Feb 2022 21:29:43 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b9db6810-86ca-11ec-8f75-fffcc8bd4f1a;
 Sat, 05 Feb 2022 22:29:41 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b9db6810-86ca-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644096581;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=ILYKtrJXEtUez2j+naLBzP7MvZQD5iPKKi7rHGXvfr8=;
  b=g/gDQa2PMiWjP1tbDN3lKQ4UR/BVAm0m0zKIAJXNgbw77G4u2BX0w2QU
   bjh0C5Keb0qZ1bKqyPzZWPZWYmRPXC+skPevwyxcnGNOWWrG3UxgivVKD
   TMsECw1fEYW3XhNDHTeCT+GnrD8SXs6q41RvugmbNLlIGgfKS3p5GG8FI
   Q=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: lhbLRTjsRHqS6GrYBrCNpcBZmXnqF4pX0ui/8Pco2fsbjPJcMk4C7lL0GmWYoFiHu7lWSQA4/h
 kG+/b+HxSUb0bempSn4bOXUYJfNUUh6JvExKejG1gQSh/ZFm0MeujnWvk36CMKwt+0jLexlIcC
 3DFlNSWv4bIx7BaU032t5bBhjpyeRi3VoXQGwL8ENQux5PaWkfHvyum1VY7j1xPKhb+sD2houZ
 a8pWeSps+fAxRg6WAec8uRjIH9T9bRwoLxrBo1CWJfVoHddKPd0KcKHKOjaIEx82RuTNXXOwW9
 vgqKq+yHLrYRhM/XVRVOtATB
X-SBRS: 5.1
X-MesageID: 63033335
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:E/B+BKMhhbaWOdXvrR1HkMFynXyQoLVcMsEvi/4bfWQNrUorhTAFn
 TNMWT2DP/2Dajf1Ldh3aYuzoR4B65LTzNZqHgto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6UUsxNbVU8En1500o+w7RRbrNA2rBVPSvc4
 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq
 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYoxWFxOh8y
 9JSiYaTezcQD/WLibQyegYNRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs
 6VFdnZdNXhvhMrvqF6/YsZhgd4sIY/HIYUbs2lIxjDFF/c2B5vERs0m4PcGh29r3ZsVQJ4yY
 eJHczp/aSzRTCcWeQwuL7UUsriapGDGJmgwRFW9+vNsvjm7IBZK+KfpGMrYfJqNX8o9tlaVo
 CfK8nr0BjkeNceD0nyV/3S0nOjNkCjnHoUIG9WQ1NRnnVmSzWw7EwANWB2wpvzRt6Klc4sBc
 QpOoHNo9PVsshzwJjXgY/GmiF6I5SYRWN1PL/cZ2jG0+/KT8la2L3dRG1atd+canMMxQDUr0
 HqAkNXoGSFjvdWpdJ6NyluHhWjsYHZIdAfucQdBFFJYuIe7/OnfmzqSFo4LLUKjsjHi9dgcK
 RiupTN2ubgchNVjO06TrQGe2GLESnQko2cICuTrsoCNs1sRiG2NPdXABb3nARBodtvxor6p5
 yBspiRmxLpSZaxhbQTUKAn3IJmn5uyeLBrXikN1Ep8q+lyFoiD/IdgIuG4heh81Yq7onAMFh
 meJ5Gu9A7cIZBOXgVJfOdrtW6zGM4C8fTgaahwkRoUXOcUgHON21CpveVSRzwjQfLsEyskC1
 WOgWZ/0Vx4yUP0/pBLvHrt1+eJ7l0gWmDKILbimnkvP+eTFPha9F+xaWGZim8hktctoVi2Oq
 I0BXyZLoj0CONDDjt7/q9JKfQtUfCRkWfgbaaV/L4a+H+avI0l4Y9f5yrI9YY112aNTk+bD5
 HamXUFEjlH4gBX6xc+iMBiPsZvjAsRyq2wVJyspMQr60nQve9/3vqwea4E2bf8s8+k6lax4S
 PwMesOhBPVTS2uYp2RBPMel9IEyJg62gQ+uPja+ZGRtdZBXWAGUqMTveRHi9XdSA3Pv59c+u
 bCpyijSXYEHG1Z5FM/TZf/2lwGxsHERlfhcRUzNJtUPKkzg/JIzc376j+MtItFKIhLGn2PI2
 wGTCBYehO/Mv45qr4WZ2fHa99+kSrIsEFBbEm/X6aeNGRPbpmfzk5VdVOuofCzGUD+m8quVe
 ugIner3N+cKnQgWvtMkQapr1683+/Dmu6ReklZ/BHzOYlmmVuFgL32B0ZUdv6FB3OYE6w6/W
 0bJ8dhGI7SZfsjiFQdJdgYia+2C09ASmyXTsqtpcBmruncv8erVS1hWMjmNlDdZfel8P44Sy
 Os8vNIbtl6kgR0wP9fa1i1Z+gxg9JDbv3nLYn3CPLLWtw==
IronPort-HdrOrdr: A9a23:xCpf0Kt8zudxJNNwjtLpeHd/7skC0IMji2hC6mlwRA09TyXGra
 6TdaUguiMc1gx8ZJh5o6H9BEGBKUmskaKceeEqTPaftXrdyRSVxeZZnMvfKlzbamPDH4tmtJ
 uIHJIOcOEYYWIK7/oSpTPIburIo+P3s5xA592utEuFJDsCA8oLgmcJaTpzUHcGPjWubaBJSa
 Z0jfA3wAZIDE5nF/hTcUN1OdQryee78a7OUFojPVoK+QOOhTSn5PrRCB6DxCoTVDtJ3PML7X
 XFuxaR3NTgj9iLjjvnk0PD5ZVfn9XsjvFZAtaXt8QTIjLwzi61eYVaXaGYtjxdmpDr1L9qqq
 iJn/4TBbU015rjRBDtnfIr4Xi57N8a0Q6k9bZfuwq5nSW2fkNhNyMLv/MmTvKQ0TtQgDg76t
 MW44vRjeslMTrQ2Cv6/NTGTBdsiw69pmcji/caizhFXZIZc6I5l/1TwKvEeK1wbB4SxbpXW9
 WGNvusrsq+sGnqGEzxry1q2pihT34zFhCJTgwLvdGUySFfmDR8w1EDzMISk38c/NZlIqM0qN
 jsI+BtjvVDX8UWZaVyCKMIRta2EHXERVbJPHiJKVrqGakbMzbGqoLx4r8y+Oa2EaZ4gKcaid
 DEShdVpGQyc0XhBYmH24BK6AnERCGnUTHk2qhlltBEU33HNfPW2AG4OSUTevqb0oMi65fgKo
 SO0bptcoveEVc=
X-IronPort-AV: E=Sophos;i="5.88,346,1635220800"; 
   d="scan'208";a="63033335"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=YOSbIIY+49IuyjzwPpIULMe314Pr6n4faqc+O6p+7P7uWmZL3b+ksGE1MjjWoHGq+3KPucncQUztPXbHvBNMD+KI4xvL+8fJq31Xys8IcUZAeJ1ROgVwNVNR1Uo5E2TP5fZloXsH4RTG5yN/qZ8Y7ri3RmatrThu7XNXJq6mRMfxc98GQJ/nRO6PjtDMMIwZxFwJVH+4P0Acf8Vlx1hrO0mcnmuDiXNvHKb06F0B8ZPLc5pz4/RqIV/hoDZz7lXGSxICw0/8+wlwrOnq+cuEHMuZOCzuwKxRPRkAw6/9EZ6F6bKhmbX4RzQERP6NiBHO8EJCimsGx4P6UBYcetXcdw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=6A3Tuku/0GdrmDCeToXondAN5ZO6FISbV8Tp3BuboDY=;
 b=jH6YXy4H767OIK15Tzj0yOuqH3fZJiNXQnor233OD6gnNBuuFuvcgmc12C3Rc6qnDzQ4dKQ7C7OtwVs5K0nM0bhSRnpoh1897f0V+jRQTeCtWRQLAeFhQVm2iIGJXXPwmj65gf/9HxOKTx04j4SWrC4+spBMX8qpTKej1yemfl83UuI4qlT1x0U+pILlspjOrAZLJUacprdqdmThb7TPZQmLCwZaTy53PFqY+/zMuIVyiRlhd05+D2SxKlv46+l+6aT57BKb54Zg17K+Ik8IW3gSQrqFQD5ZJ3bIZjLmlAq/Xtacu/Fq+Gn652geQPlW5JrVzUKrd46WuUnaTQEgnA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=6A3Tuku/0GdrmDCeToXondAN5ZO6FISbV8Tp3BuboDY=;
 b=MOZDiXx06vPi9hJBr9ot6eXlMgf/iVj6cZbmbdeD7mLmRNlkiSix3+TDTUqQdreTFxEGxImNY3HhpG8EDZ6+89LjeiR+FElLVslvZGnZhPxcAgY+kIpFa6dHJvIsBfS6LekXLiCKEyh4VhSZyB/NQpKeU8LWOXicKlwfT9RZRLc=
From: George Dunlap <George.Dunlap@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Andrew
 Cooper" <Andrew.Cooper3@citrix.com>, Wei Liu <wl@xen.org>, Roger Pau Monne
	<roger.pau@citrix.com>
Subject: Re: [PATCH 08/16] x86/P2M: PoD, altp2m, and nested-p2m are HVM-only
Thread-Topic: [PATCH 08/16] x86/P2M: PoD, altp2m, and nested-p2m are HVM-only
Thread-Index: AQHXcbg9+9E9Zp3QUEWtGX2TK6aCNayGy30A
Date: Sat, 5 Feb 2022 21:29:33 +0000
Message-ID: <0C051DFA-9147-42DB-AA36-0DED3D192F43@citrix.com>
References: <d1fd572d-5bfe-21d8-3b50-d9b0646ce2f0@suse.com>
 <694a6590-0018-223a-c796-3e1469ec354a@suse.com>
In-Reply-To: <694a6590-0018-223a-c796-3e1469ec354a@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3693.60.0.1.1)
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 0a81960e-72ea-4e90-13df-08d9e8ee9a19
x-ms-traffictypediagnostic: BYAPR03MB3845:EE_
x-microsoft-antispam-prvs: <BYAPR03MB384593A7E9E6CAC333BBE547992A9@BYAPR03MB3845.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:5516;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: QDeioCJSdK0XoKB0zgo6XYrEzFxZajMVec6mqHHMdCrkIPXExRGHH7UHqHNCzEafY2e+fwNvRMjxy/f2sQwQvXr4ayNWe5/RYisAQZTuHL1FBGArar4kXVq8xpAsW9TrOhCgEtFk13FtwF1wknP1uCRuSjNZHw6VyQ88AcH+0AjdMsjFWNgaIlLZt/iYiaAX9h4zXfI4e92fafIJE22ixVj2TesyJoucsDLN8NpnHQ7Z1oFnEkTr15lZpokdjetV7OUvlnwXi0/I17etYQnBRX4pIiv8zust6E5uefmeIexdKPGgixixk4LMS8lu00aCHkdpP6rIHNNirv8I6HqxDVgR2Ly5HztdJaTVgp8z6Gy0PVpLHKHwKehmxQNQt+LiK/DaSa2+UWPqGU8S+uiMqACzINrET79g6EsXZ8FZZYlgqAStkrepxpT1VBlWFqClw/3gLIwwM/LBXSXhvePmgog8aCxlNGtWx87jgYmrffd4kNK8wErdm1CR6WRsP6JcAEPkmyXG9RNi0fBzp8LKalI5X+tmk71OaJpYD/wEXKa7bSqimW/zIwXD0/ENtNMDEhFk8jt3QORIZaBjZWoQDlu/cvwJz8VGtXyKwTMPcNu8CeAdrqnVgcvTn0w/vE7Tbc1zycivpHfNZyLdfZDQp4yELorxlAo8OHsVxLb8gucq1znHBJQK3auikQ+wBbem7/nfvRzqduvbSUs/tzmcjH+X1CNOeZDxITtPAGzfnJCjvx7oyL2IiGdt/xhdvNv2VIB5JgB0x3KuCmqaRYm/azvdK0tX9GCVblUVLgzo8/Y=
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6506007)(66946007)(53546011)(6512007)(5660300002)(83380400001)(2906002)(82960400001)(6486002)(8676002)(38070700005)(86362001)(122000001)(508600001)(6916009)(64756008)(107886003)(91956017)(38100700002)(26005)(186003)(33656002)(316002)(66446008)(2616005)(54906003)(66476007)(66556008)(76116006)(8936002)(71200400001)(4326008)(36756003)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?49i5zNffZggWslnSZXRWQMbLhybgPyIgeYxkdTyftczt4NzkdKNqzFwZG9ra?=
 =?us-ascii?Q?pi2UtGY0I4eX0cc3pxY1eZRxr2461X7sgVBooEx7y59Dgc2IK8OjZ+U//DUc?=
 =?us-ascii?Q?T322veeuhvwzWUlPbjpffqM6aO+wARliJdCmsKyrMPmRe8B3KB3NdogBFLbI?=
 =?us-ascii?Q?hLdQgofcvh8lW1JwyXRYrO1w06YA1KBDpHNtCoeh/lNLf9+X55/83bVc/Ht5?=
 =?us-ascii?Q?3RBQOJCXyvn3kLr6csUd6NPe9n6wzjkUWLmmwFWfRSQto5Xmgcc9l5mKV69C?=
 =?us-ascii?Q?jToXNKWGLL0jiWo0VpnC5ouR0e+yOUdt2J8vvyQX7SUbQE9DdWsqwGfe3tHu?=
 =?us-ascii?Q?1cgXuE1URcl2o+T04umllcGBywHZNiEpdhMaP94EQ8GfzXaeHodKxEGPcsk7?=
 =?us-ascii?Q?LyDux2YCBgGmb3dcDKJZCrztPIrAbFRpMAWkLpOk4L3GSEkPS/QckoGUwMJv?=
 =?us-ascii?Q?DaFY9v+HLkb/MZYaPz3ra78aw8KWPBRSL5cTQe3zYga0yET/u8EYF9s7NPsP?=
 =?us-ascii?Q?CjnOE6hVki1koz7YGknlgqWLERmPORyQzxtA0sCMMWqD51MhkoZU5ED65hOn?=
 =?us-ascii?Q?bHKXw8+OlyUby8qVZ7LDVgdUa/aqxNhEHNv6lPdicIveKapnL1Rd3rf4EgrY?=
 =?us-ascii?Q?gC2Tk5moIFcKEXCLh2oWPtGfpioMQp/msvUJlbH38cBh6ktDdAevH8p1ZkIu?=
 =?us-ascii?Q?dmSHFS+mvF3gGwqMkTgDFU8FMgwlxKlH8RHWf17lMBGHn4w76/mjjdrlA6P+?=
 =?us-ascii?Q?PBWpgkxrriYnz6ceoRueiX9Q3A4neGAsrwxVftbKvG2ilrLvYXsT3RSdCTzY?=
 =?us-ascii?Q?+O8Ox2vjRioz2lGsPHCnVRldGqCDN+J4eqjoGuP7WW1umg+upLJd4Lmk1kY3?=
 =?us-ascii?Q?//juw9lgMVMb2QnMGbP1nZAOiOSgh6PuaFGWqlbpR2mJI5q6G9bt0MN7Yajs?=
 =?us-ascii?Q?M5ACBn3Ik9rlCB4j3mBDULf4E2bQp6tflPTg3huRUaiuGBySyGzYH7XgOPz/?=
 =?us-ascii?Q?+aN6RZzCeimr1IYIIq19bD3dtcB3LmseNwityrbuC8KISgOMISVzxxJLaVUG?=
 =?us-ascii?Q?GN7tSVVDXWSonsfH+sTfXKkqyARlQB/X6ggN6gl6QvJwG09zk2U9j1+X2zVo?=
 =?us-ascii?Q?/KL5reurkk2cgy75eqD1DowJCdVMDEahrnXXhs3dYZxD+2wcqkuuNwZIhxF2?=
 =?us-ascii?Q?6oDj0hPoVbCr/jXKC2oaN6si/Ftwl/LlqwHplqG+S6Z7SVRp2xDE8t3ljL1C?=
 =?us-ascii?Q?cmWhRK5uzRRIlu0QEp7dhujjuQeQWwEMOdLT3nU2wF+zfkb6NJDrqVqMH0vO?=
 =?us-ascii?Q?cv2jR6259okdF5xJf1Vt083ynKXTYQN5zVjaSiUiOhoreBsEiZn5JlhcLUZn?=
 =?us-ascii?Q?WbMia2dNwadS63Lief/eC3G4CbFrv6dvPblSQIThiZy9/Yik89OwXJKE+SA/?=
 =?us-ascii?Q?fQ3ugVAuXmKoQW24L2I+vhkUzZZIF73jkp86BPl6nTGBQbqBn3fOMuG00qgM?=
 =?us-ascii?Q?Xi6AK68Mca+P5UJl4/de4EvsqBVTssBGOaFIdqz/fQYS5aDJYb1Nz74BsNmK?=
 =?us-ascii?Q?K6Lrec/SRRxoFs61dBonGXV4loEc9bb7ZkNU3LWVYB6G+PVXv2zaC0t5Fgxy?=
 =?us-ascii?Q?uc0oqZU+VUXTMc/ViorvOFIiHwnvdG3E9fi4e3muQARUQspIgIy2eySMkO0o?=
 =?us-ascii?Q?fRIw4LT/pf7SGt8n3pOGkCTDzYo=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <D759E4FEAA9F454092D58830EF79762A@namprd03.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0a81960e-72ea-4e90-13df-08d9e8ee9a19
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Feb 2022 21:29:33.3893
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: KV4MzCgOv0nx5pqVWgFvrEARHLEMQrKbk6/3SZSqG5ZSkc36F84iEUc8Ub7c5tcOQse4WlNOsMMQgAqer9FjgbknFysFMXUD4sLU3QzSYPk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB3845
X-OriginatorOrg: citrix.com



> On Jul 5, 2021, at 5:09 PM, Jan Beulich <JBeulich@suse.com> wrote:
>=20
> There's no need to initialize respective data for PV domains. Note that
> p2m_teardown_{alt,nested}p2m() will handle the lack-of-initialization
> case fine.
>=20
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>=20
> --- a/xen/arch/x86/mm/p2m.c
> +++ b/xen/arch/x86/mm/p2m.c
> @@ -102,6 +102,9 @@ static int p2m_initialise(struct domain
>     p2m->default_access =3D p2m_access_rwx;
>     p2m->p2m_class =3D p2m_host;
>=20
> +    if ( !is_hvm_domain(d) )
> +        return 0;
> +
>     p2m_pod_init(p2m);
>     p2m_nestedp2m_init(p2m);


>=20
> @@ -259,7 +262,7 @@ int p2m_init(struct domain *d)
>     int rc;
>=20
>     rc =3D p2m_init_hostp2m(d);
> -    if ( rc )
> +    if ( rc || !is_hvm_domain(d) )
>         return rc;
>=20
> #ifdef CONFIG_HVM
> --- a/xen/arch/x86/mm/p2m.h
> +++ b/xen/arch/x86/mm/p2m.h
> @@ -17,6 +17,8 @@
>=20
> #include <xen/mem_access.h>
>=20
> +void p2m_pod_init(struct p2m_domain *p2m);
> +
> int p2m_add_identity_entry(struct domain *d, unsigned long gfn,
>                            p2m_access_t p2ma, unsigned int flag);
> int p2m_remove_identity_entry(struct domain *d, unsigned long gfn);
> --- a/xen/arch/x86/mm/p2m-pod.c
> +++ b/xen/arch/x86/mm/p2m-pod.c
> @@ -1135,6 +1135,12 @@ p2m_pod_demand_populate(struct p2m_domai
>     mfn_t mfn;
>     unsigned long i;
>=20
> +    if ( !p2m_is_hostp2m(p2m) )
> +    {
> +        ASSERT_UNREACHABLE();
> +        return false;
> +    }
> +
>     ASSERT(gfn_locked_by_me(p2m, gfn));
>     pod_lock(p2m);

Why this check rather than something which explicitly says HVM?

If you really mean to check for HVM here but are just using this as a short=
cut, it needs a comment.

With that addressed:

Reviewed-by: George Dunlap <george.dunlap@citrix.com>

 -George



From xen-devel-bounces@lists.xenproject.org Sat Feb 05 21:32:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 05 Feb 2022 21:32:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266152.459841 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGSf8-00088C-ON; Sat, 05 Feb 2022 21:32:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266152.459841; Sat, 05 Feb 2022 21:32:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGSf8-000885-LK; Sat, 05 Feb 2022 21:32:06 +0000
Received: by outflank-mailman (input) for mailman id 266152;
 Sat, 05 Feb 2022 21:32:05 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=vIk1=SU=citrix.com=George.Dunlap@srs-se1.protection.inumbo.net>)
 id 1nGSf7-00087z-1U
 for xen-devel@lists.xenproject.org; Sat, 05 Feb 2022 21:32:05 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 02fb71f8-86cb-11ec-8f75-fffcc8bd4f1a;
 Sat, 05 Feb 2022 22:32:03 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 02fb71f8-86cb-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644096723;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=4EloWy78GVyeOCzWi6VlHtbP+brzLx9/WSU0ZrbQUHo=;
  b=U4EW07I2RqvKcZtdHNkBYBd6+DQ0BlS3OPqqNmPH2sTX8CQB2dFtGwPz
   QjbWr1sWkcp4/XzcfYehM413MST1v6tOC95S8LPmTwDz5p/QZNmtHe0iy
   3kxKYXGvzFvcLaXFTryPYSiUh/icIKG2xcqyKGexNyC4eqN7mEuJ8TG+Y
   g=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: fEznHv0NA13M42ubL0inE5u9jFO9O5oU/A0C9zhcX30sJEkzGy2FRrJ4tiFRlTZwIB0CfEtWJ7
 iBq0fT4vYLIYBU5s+xAd7sWrdDM/MCLiYAiUES3BvEgW18qIv7jxfT2rYphGwLKTtO9mx9sbCv
 gSPJ3c2ETbRp148sU9PAgjTt5DrpVvhCcAHjyUYae92vKjNlKJn8+slpQUUJ842kIorDgb70Wp
 5ygJo/j6h0zfDG/dtcAUVetTkz5W3VAyp7gwIMpklIYBDWMX8zKROieY3UcVtyZFIwQYhDDSv3
 KdtO56NzEg0H2OkA1KlRT1Cs
X-SBRS: 5.1
X-MesageID: 63574984
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:jwpydK+Nm5CgrNh0shGYDrUDYnmTJUtcMsCJ2f8bNWPcYEJGY0x3m
 DQZUTzUOvyINjfxcotxaYu+9RxUsJ/RmNU2SwBspXo8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhFWeIdA970Ug5w7Rh39Yy6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhs+
 Ytv7oW+RD0JHYLX28tMbjVREg1xaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguwMIc7xM45ZlmxmyTjBJf0nXYrCU+PB4towMDIY2JsTQqqPN
 5ZxhTxHUEqZf0RhAG4tEblgjO721lnHUxllkQfAzUYwyzeKl1EguFT3C/LKfvSaSMMTmVyXz
 krW8mK8DhwEOdi3zTue7mnqluLJhTn8Wo8ZCPu/7PECqH+5y3EXCRYWfUCmuvT/gUm7M++zM
 GRNpHBo9/JrshX2EJ+tBHVUvUJooDYBaoRySPQ05Tut6YXPoCnIO0QNTxJOPYlOWNANeRQm0
 VqAntXMDDNpsaGIRX/1yop4vQ9eKgBOczZcOHZsoR8tpoC6/dpt1k6nosNLTfbt5uAZDw0c1
 NxjQMIWo7wIxfAG2Kyglbwsq2L9/8OZJuLZC+i+Y45E0u+bTNP9D2BLwQKChRqlEGp/ZgPc1
 JTjs5PGhN3i9bnXyESwrBwlRdlFHcqtPjzGmkJIFJI87Tmr8HPLVdkOvG0mfB82bZhcJW+Bj
 KrvVeV5vsI70JyCNvcfXm5MI55ykfiI+SrNCpg4keaikrAuLVTarUmClGab3nz3kVhErE3ME
 czzTCpYNl5DUf4P5GPvH481iOZ3rghjlTK7bc2qlHyPjOvBDFbLEu1tGAXVMYgEAFas/Vy9H
 yB3bJDRlX2ykYTWP0HqzGLkBQpWdChgW8Gq9JA/myzqClMOJVzNwsT5mNsJU4dkg75UhqHP+
 HS8UVVf013xmTvMLgDiV5ypQOmHsU9XoS1pMCoyE0yv3nR/M4+j4L1GL8k8fKU99fwlxvlxF
 qFXd8KFC/VJazLG5zVCMsWt8N08LEym1VCUIi6oQDkjZJo8FQbHzcDpI1n0/y4UAyvp6cZn+
 ++81hnWSIYoThh5CJqEc+qmyl685CBPmO97U0bSDMNUfUHgrNpjJyDr16dlKMAQMxTTgDCd0
 l/OUxsfoODMpa4z8cXI2v/Y/9v4TbMmExMDTWfB7LuwOS3LxUaZwNdNALSSYDTQdGLo46H+N
 +9b+O7xba8cl1FQvosiT7sylfAi58HirqNxxxh/GCmZdEyiD75tLyXU3cRLsaERlLZVtRHvB
 xCK89hef76IJNnkABgaIw98NraP0vQdmz/z6/UpIRqluH8rreTfCUgCbQORjCF9LaduNNJ3y
 Ogsj8ca9gijh0d4Kd2BlC1VqzyBI3Fov3/LbX3G7FsHUjYW92w=
IronPort-HdrOrdr: A9a23:Hc9uN62D40dI3vmiMMCgKwqjBRZyeYIsimQD101hICG9Lfb2qy
 n+ppgmPEHP5Qr5AEtQ5OxpOMG7MBbhHQYc2/heAV7QZnibhILOFvAi0WKC+UyuJ8SazIBgPM
 hbAtFD4bHLfDtHZIPBkXOF+rUbsZm6GcKT9J/jJh5WJGkAAcAB0+46MHfhLqQffngdOXNTLu
 v52iMznUvHRZ1hVLXdOpBqZZmgm/T70LbdJTIWDR8u7weDyRmy7qThLhSe1hACFxtS3LYL6w
 H+4k/Ez5Tml8v+5g7X1mfV4ZgTssDm0MF/CMuFjdVQAinwizyveJ9qV9S5zXIISaCUmRMXee
 v30lAd1vdImjXsl6aO0ELQMjzboXITArnZuAelaDXY0JfErXkBerV8bMpiA2XkAgwbzYxBOe
 twrhKknosSAhXakCvn4d/UExlsi0qvuHIn1fUelnpFTOIlGfVsRRx2xjIlLH4sJlOz1GkcKp
 gkMCgc3ocjTXqKK3TC+mV/yt2lWXo+Wh+AX0gZo8SQlzxbhmpwwUcUzNEW2i5ozuNwd7BUo+
 Dfdqh4nrBHScEbKap7GecaWMOyTmjAWwjFPm6eKUnuUKsHJ3XOoZjq56hd3pDmRLUYiJ8p3J
 jRWlJRsmA/P0roFM2VxZVOtgvARW2sNA6dg/22J6IJzIEUaICbQxFreWpe5PdI+c9vcfEzc8
 zDTa5rPw==
X-IronPort-AV: E=Sophos;i="5.88,346,1635220800"; 
   d="scan'208";a="63574984"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=I2gWORwSj6lwkUl9IT6OD8KglYuzU9X/cCoJ6HWjh81ny6nCF97ZMPXxBj7L4jfctMXYmT6n9Eok51sV91vVPr015/LKTDjfzaNJ/OkXFl88N1dQDTCDg4hkGhvAhRwGvtwZiRfQgvvVQi30Yj/jrgqWEKUOjx9y8x08NN0UYGcIf6Jiv6s8tVPA1jIfM6RUZT1zUJ4OQNd1BA0zSCs6ZPS+KqwLBYH52zFwCypot+iQpszvKBnj4UHY6ArvQ1sIPNq976f3jG0kVC5b6HGex4m4Axzw52bK20PV5v9b+HaUPeRNQfTAmAjtggnVRYuBzog1h+FsIobLGf30eSeAsA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=4EloWy78GVyeOCzWi6VlHtbP+brzLx9/WSU0ZrbQUHo=;
 b=NbMbB2Gjvhf0xiIIXBFLMnAnhjtPEgPL+7AlWJdcM6SMnkJXKER2FUJZa/qECNDbms2CKNc14vJEJ93m6AzujRdr9jC4u0fMENrAK3p1ckAak6WK03I2njiiti67YGNOsKwTe7Vv3os3bOGVqjOPHbqfiqN7f4raR8TbuBc46yCEk0xw5HvPLfBSmRsPDii3sRh0vJTglCscM/R/mheQJlFL9Ln8NjWNNMKbTT+Y06LtxIS4j0Q1J20TELu07zOJ1/Fe/w2DZj+042MrIQZFJ4c9/Y1lJneaLIOZkGJO9t3VVbY2ax2PcwX8ZX49CE61h8uK7ji8oLnVJ5OFWkn2jA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=4EloWy78GVyeOCzWi6VlHtbP+brzLx9/WSU0ZrbQUHo=;
 b=FSplxvzZkFriVbR4Tq/ETd2yOaqFUa7Rn1bV7C6L1zm+Fv5op5aOu+DY25L4neUPsz61B6KGhvq6lD8/v4m6SQlHaSKT742zM9Cao84mE90WpmnWVUC0ltq1DtkHiterz5U7s5lpBjnq5ESC46AJKXZum9CVte/mMz9H6XfOzsM=
From: George Dunlap <George.Dunlap@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Andrew
 Cooper" <Andrew.Cooper3@citrix.com>, Wei Liu <wl@xen.org>, Roger Pau Monne
	<roger.pau@citrix.com>
Subject: Re: [PATCH 09/16] x86/P2M: split out init/teardown functions
Thread-Topic: [PATCH 09/16] x86/P2M: split out init/teardown functions
Thread-Index: AQHXcbhcry3GWuRhgUGQXT1+yvRBDayGzBSA
Date: Sat, 5 Feb 2022 21:31:39 +0000
Message-ID: <DF086923-0C6D-4F8B-9D19-6714F24E9456@citrix.com>
References: <d1fd572d-5bfe-21d8-3b50-d9b0646ce2f0@suse.com>
 <01024f3c-22e9-cdf5-46b7-c9479c8937b1@suse.com>
In-Reply-To: <01024f3c-22e9-cdf5-46b7-c9479c8937b1@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3693.60.0.1.1)
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 386cb861-8cb0-43dd-ff0a-08d9e8eee56a
x-ms-traffictypediagnostic: CY1PR03MB2170:EE_
x-microsoft-antispam-prvs: <CY1PR03MB21709F520AF96790E358EB88992A9@CY1PR03MB2170.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:2958;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: J3FNri9mN79jv6mfBcsRnMSSG4HsMRg5lZvlcJ15eZZY2InEgWbNKmvduJvXLLKzXLMQkDh/kRDLlMdNy2Obv0T+6eDVfMkcwfh6RAMF/a6raH2bGaLglso97SWivY9HUyd7iBkMBl+oLl9lRSTzUPleAE1Hw926huxB4z5baAkwTBn9GBsiWyzvlaDheAlcbQtEAxz5uhdlEeeB0WyfsoFA1w784yMU1kaK9jjBsB0tB4Nd/z2msyGoHV9aXARR2wnjuJtx202S5oN04sFpWYpcphem8hIEcoZCGDs5XJcEgUV4TixDhkRmALV9Q+8XgolQqFU3fgou5mud4MC9OvA9BrDkeFPVLKjq7ENS43m2cMyETZAP9IIVxA9sM3XBHAb9XmcuS2Lpz+4WpGI4P6Kyuek3QcKxOgK2FecfGke5ifOs9B72I4sVCiEJYP7wM1x2CHykfEue4V375RSz5OeH8b+1FrEyrm2JeLyZ8mPnT4IqTb3UoVwDGFgRwalVhcCs2XtTY6Wo9HgtqDNcgBm8lJyRlsTkVmw011helEZ4oKlev3TDkGsw6HTStvhAcatsWzNbFz/xDpyOB5yeTTK/+59UlXa7GORJ54E9ug2kGCW3nkfbjqd90BB6F0SvQFcPLasZ0ZaxgbWoArVQj9E1TZ3uYe1tuLyPLFHwYQqMcHGmBi1HBD08Ui8HJGoCqJQKAKY3AjqSpLwtL8jrJaYKoavcUiUUQx/duuzr42tZaoWusKTjcuQO6tlnMP5O
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(86362001)(66946007)(76116006)(91956017)(26005)(54906003)(316002)(6486002)(64756008)(4326008)(8936002)(66476007)(66446008)(66556008)(8676002)(6506007)(6916009)(508600001)(186003)(82960400001)(33656002)(38070700005)(6512007)(4744005)(2906002)(107886003)(36756003)(2616005)(38100700002)(5660300002)(53546011)(122000001)(71200400001)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?gwQfv9tB3MfEcfd9oOTC3o5YPiz3u0y77WPzQliCtylJzhmWZdo2/TdBFQiT?=
 =?us-ascii?Q?bv7VesCxmIWaQEL/wurqlyI3LQIz31vR4dhzaGNMfVMh/mOPO+ArYMzphety?=
 =?us-ascii?Q?hu4DP26IxvexQxs3P0EOcgMK0Zq0nJ/ISscFRAGrWi+DYCDJ0cRot4Ft81Uj?=
 =?us-ascii?Q?cBMgtAswnkyeGfzNVbMZHnKvoM4n2oVbsMImm42uRHIr5Xv1kEUrZiOcR95R?=
 =?us-ascii?Q?90c4zFTYhza4XOs/3cwcZSUp9nif+7/jTAsruBokU2nHdegd/lTmZd+lOYOb?=
 =?us-ascii?Q?w4ZxSbSKA58rw1igUwuwCQ8jEIlJzVG0nH2ClUuoqyCeRVDsbqBQAz9oJvo4?=
 =?us-ascii?Q?KMBQR8DA4nDfkvXsxKjQHX+d9Tvb/WtiAAMctO6/l6/KQr/g6fOK//vGS6zA?=
 =?us-ascii?Q?FjIDGyu4ewQ9MFS5w/k8SRIC454Juc5Gn56gbjmV9C53QIopmnUGWkVig07Y?=
 =?us-ascii?Q?+FsF3CkMXEypHGAjlfRtvMlwof9MYTFHdQz/ZDUrD5S0PMMdEy6sADOgdzuI?=
 =?us-ascii?Q?4nWGKayoDtRCkUp7JQGqK0MavQ8pZ0ctRkO8amGzg2itb6Q1BtGoZVBCGnwv?=
 =?us-ascii?Q?yhMWelnKnA3ucBQii2KRfmCw8vLjVOFP9fAUxSlDy6g8L9758rDUOHugULMR?=
 =?us-ascii?Q?+VAdTAex1UAvRy9ibFxBe1V8v3PbEXZShxXGqg4RDcdgiXelfUF/7p6epdbl?=
 =?us-ascii?Q?K/UvMglgNY7ZeWN0Apu+ZmVKyh69XJPGrN824xk6I4tFiMR5o7QYRuFGUmRk?=
 =?us-ascii?Q?Uvst0y2h+vBC/Byvqlk8HjxBF64gvQH4+8Eixh5KNNhhUwpPHoAqnLmmJNBi?=
 =?us-ascii?Q?bdaYIWaUxoktxIPqmy+Wol6byt8GZvlVFequ/IgnXcCiN5TXRhNbby/MtPEH?=
 =?us-ascii?Q?YURXC+4FJSfq/nW6j0pUW5Jdh9Y1NQ52GiT0cxJ6I0E4xV0NHQt5xpWZJEOL?=
 =?us-ascii?Q?aYsg87gNbRDkcDje/cmdF5XGAChW8jHMMLyohow4s2uORVtbxu/q3oRbeYSn?=
 =?us-ascii?Q?ISmr5i1ASG6/usNVt8J7XJsbwixqgCvH85yd9rXu/J6kD3CSDv1lyydGGIB1?=
 =?us-ascii?Q?H4lgGlC6vCpNSROIL83Ev/p/Gw6ZKArZ9nBWxT8+C+CnI3oqdTJkPORxqQUC?=
 =?us-ascii?Q?3JYa0s00SWmyRVVJ/sbhOZ6xjKB+tMGlzV1Z6aOdzVT1osZJiamk+GxUcdjj?=
 =?us-ascii?Q?xk5ncawMZPOS/zaKM2O29onpXxcNguWvw8n8uR1oHddqsPypN0pIPHwy2rkD?=
 =?us-ascii?Q?nFRND1vyS/N0ARYRxv4h8DWxpbWIacDIrXDG+seO0VcUEtf5migAUIoC9p9J?=
 =?us-ascii?Q?Mby7nunpeaOma5UrX5inNDCyLJMiDkvX0r3aHZ74Cq6Y6bpTmDSonJm47PLY?=
 =?us-ascii?Q?G9DKIMBN1ipjjWYxDqJzItlvLQ2etqCYgiDfrRn6Uv38Mlh5fU1Qeo0cDAmf?=
 =?us-ascii?Q?Pxzh8XAH2w73l/ZbIvAc9Q/cF1HLw2geOEl/KhTnPQE+7b+d5zzD+tcHLgSt?=
 =?us-ascii?Q?wAvRJ+HMU+JjYL2svYM8YXE6L2GlOO0EGJl7hNxJs6uGyPHOVZO1y/HQTI1D?=
 =?us-ascii?Q?QiK+ys8ei7oJgcUMA+pVuQq+6d7J35szs7JG/0BeBU5BUscwKKosEZg7gDoe?=
 =?us-ascii?Q?Micb0amV2zB/4H1TWBHwDMzULJZiJBvQVwVB8Xx/IYUOfCCX09G2XqP30i6d?=
 =?us-ascii?Q?CLCfKoWu0uk5Hl+EPF+Ng01d2BE=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <5DE10B24C88D5540B4A99F876D62C4AD@namprd03.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 386cb861-8cb0-43dd-ff0a-08d9e8eee56a
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Feb 2022 21:31:39.7397
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: pZGvY+QhDDiEbpD+2oBdwRn0TccTHw906ub8uQnxQP35a+CgDF5Oy/A6ZSo8lb6+oARVkIq8sBIZuw9MpTlETHXZov7i0LXoUVD0ZwG2xi4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR03MB2170
X-OriginatorOrg: citrix.com



> On Jul 5, 2021, at 5:10 PM, Jan Beulich <JBeulich@suse.com> wrote:
>=20
> Mostly just code movement, and certainly no functional change intended.
> In p2m_final_teardown() the calls to p2m_teardown_{alt,nested}p2m() need
> to be guarded by an is_hvm_domain() check now, though. This matches
> p2m_init(). And p2m_is_logdirty_range() also gets moved inside the (so
> far) adjacent #ifdef.
>=20
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: George Dunlap <george.dunlap@citrix.com>



From xen-devel-bounces@lists.xenproject.org Sat Feb 05 22:58:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 05 Feb 2022 22:58:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266160.459852 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGU0k-0007N4-9k; Sat, 05 Feb 2022 22:58:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266160.459852; Sat, 05 Feb 2022 22:58:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGU0k-0007Mx-6Z; Sat, 05 Feb 2022 22:58:30 +0000
Received: by outflank-mailman (input) for mailman id 266160;
 Sat, 05 Feb 2022 22:58:28 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=pZml=SU=xilinx.com=ayankuma@srs-se1.protection.inumbo.net>)
 id 1nGU0i-0007Ml-DY
 for xen-devel@lists.xenproject.org; Sat, 05 Feb 2022 22:58:28 +0000
Received: from NAM11-BN8-obe.outbound.protection.outlook.com
 (mail-bn8nam11on20608.outbound.protection.outlook.com
 [2a01:111:f400:7eae::608])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1ef6dd0e-86d7-11ec-8eb8-a37418f5ba1a;
 Sat, 05 Feb 2022 23:58:25 +0100 (CET)
Received: from SN6PR08CA0005.namprd08.prod.outlook.com (2603:10b6:805:66::18)
 by SN4PR0201MB8742.namprd02.prod.outlook.com (2603:10b6:806:1e9::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.11; Sat, 5 Feb
 2022 22:58:22 +0000
Received: from SN1NAM02FT0054.eop-nam02.prod.protection.outlook.com
 (2603:10b6:805:66:cafe::f9) by SN6PR08CA0005.outlook.office365.com
 (2603:10b6:805:66::18) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12 via Frontend
 Transport; Sat, 5 Feb 2022 22:58:22 +0000
Received: from xir-pvapexch02.xlnx.xilinx.com (149.199.80.198) by
 SN1NAM02FT0054.mail.protection.outlook.com (10.97.4.242) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.4951.12 via Frontend Transport; Sat, 5 Feb 2022 22:58:21 +0000
Received: from xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) by
 xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2176.14; Sat, 5 Feb 2022 22:58:20 +0000
Received: from smtp.xilinx.com (172.21.105.198) by
 xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server id
 15.1.2176.14 via Frontend Transport; Sat, 5 Feb 2022 22:58:20 +0000
Received: from [10.108.8.223] (port=45840 helo=xcbayankuma41x.xilinx.com)
 by smtp.xilinx.com with esmtp (Exim 4.90)
 (envelope-from <ayan.kumar.halder@xilinx.com>)
 id 1nGU0a-0005LJ-F4; Sat, 05 Feb 2022 22:58:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1ef6dd0e-86d7-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=LILh+it+5vqBhG2eIFkc/OvQhZxCiiWxTnfUyRu1lHrtIllcx3qhLQM736BI+rnVzuhtDKjZJxwglIy8KuXtsf20u2s7x4x0xdviTT+4kc87zRPUdJRq9YMCeRIdNBpjF+u/m902btQoxIdgzNwx/9zd3Bt7r8N2MA6Y28q2UrsNsx3niyHWEk/HIF1ZKH3gonVIuW5MojWO9i4cks3iU/GqRnQo0ofOmXu6ECzsVEj8k1nbUCc7uaWU//hr5iCqqxcTmBNBht2hqOyyaT7piafZ22l2ECe0w9m8sDJCZy7NIdXT07h2nZE8NsTa+Ee6FaRzthIP03csG8rZLQZZKg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Kz2Ce14/b/jlMByaBpB+zZOHlM5iXKOu5ov6OIoPRIA=;
 b=PkNGmyMKpZocBb2ARUQ0Vtoh8pwMM3VcHTbCN5r2RsYKaYaTHD5fcDBXT4tzjwBuWBwXl6JSdHAwjqcxwr6hl7RWfwotBVv79tGn4eEtvC+YPjYyRHYJ+FvPigiFl+SyWdwIfv8GMS+4+z3gby/Xi5trcJP5MyuWriEWjZx+JQ0AS+yyJZRp7t8a4Fa42rgjacS9NyuXPak/4ehHom4yOEn/aolgker4marDT8cfRlF6gN3EtbwZ+Csl2cDN/vgO1vSoSjDjwL64WYSsIw4uQqqasYhyNYfRuLOZ5hWHqlZ8S6R+pbrVtlThAEz3ZSutv6l3s7RAK6JHUDc0Yg5YAw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 149.199.80.198) smtp.rcpttodomain=lists.xenproject.org
 smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none
 header.from=xilinx.com; dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Kz2Ce14/b/jlMByaBpB+zZOHlM5iXKOu5ov6OIoPRIA=;
 b=g3Gcye5+NjCrrp7lxBjdreRySHQb+9f0Alp8PFsJeKQngk1mLbSwfM/YXX/tGiENnhBvIoJ4DFVzuOLtn4NDxCtGAUPmnhYuhTxM9fdJR0j10ZeKB15U1oAv+piKYY09khUISxKty1yuO+rp74iHOGy9+Az5ea/CqNASD4etDMw=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198)
 smtp.mailfrom=xilinx.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=xilinx.com;
Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates
 149.199.80.198 as permitted sender) receiver=protection.outlook.com;
 client-ip=149.199.80.198; helo=xir-pvapexch02.xlnx.xilinx.com;
From: Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>
To: <xen-devel@lists.xenproject.org>, <ayankuma@xilinx.com>
CC: <sstabellini@kernel.org>, <stefanos@xilinx.com>, <julien@xen.org>,
	<Volodymyr_Babchuk@epam.com>, <bertrand.marquis@arm.com>
Subject: [XEN v7 1/2] xen/arm64: Decode ldr/str post increment operations
Date: Sat, 5 Feb 2022 22:58:15 +0000
Message-ID: <20220205225816.5952-2-ayankuma@xilinx.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20220205225816.5952-1-ayankuma@xilinx.com>
References: <20220205225816.5952-1-ayankuma@xilinx.com>
MIME-Version: 1.0
Content-Type: text/plain
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: fa08bafe-6aac-4926-4860-08d9e8fb022f
X-MS-TrafficTypeDiagnostic: SN4PR0201MB8742:EE_
X-Microsoft-Antispam-PRVS:
	<SN4PR0201MB874204B2B0887264F924233EB22A9@SN4PR0201MB8742.namprd02.prod.outlook.com>
X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	MO2MVIzKe4fTnmMu48J+Nmmyxl8RpyNTIuo0lxjmKaSHavKcW2p66ovS5yyInUrh8jlVd5RjVmH5fEKn0vOyWfkdoTFYHDzNVZ35Cr+WQ/1rqyyBakqazg9lGUavZMRz54q/V7+UolGkxPaFzEWlcERlFodTLIh6ne9jAzHHNWlhS5RMo0tFFTV3QNCjsWrNadlNveVevddv3OqJxNS9ZDpt0E2YW4k1DoanOMknmvoaDb/WuzZzxZ/GDuHHGrCs4gwUdOHfjVZpRwNnePECyrKVrw/eRGHwT2ntOMrqJWo7epX5+RLtNhC6Aq4TrGsftNSTHTLtwIUXbjzH9qkl53xZSzuP8V+3FKC5W2Nfrbgirshs8XWKp6qv25NWwU0/ym1CRdYzV3uWBd4sVh3hg2R4UvbFA8OYbBlaD4b/hhYBIgmTedDlPaIN3mOrqqw/HYrzFepv9pm//o88Zx3MJHjUrTy7HspoTLL+7WSqjx0v3JxiRRo4rX8cEk8/Ape0yiOcarXKF0v8SIqiotVeF2q3u9euW5TclmCkUxXmpER+cFPXBmG2wGSq4aQWLP6cnmxusF7MxiS+jy2SMEOYfcrOiR0gCLyJ3c4WoTcf0tBQM4Qae3uh3QJX19vfe/eKAz1lc793hH3kxu1D/QkE7EQ4Z0V3VJyRRCsrWiLci053NwOgLezls7FkZjt2IfFl
X-Forefront-Antispam-Report:
	CIP:149.199.80.198;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:xir-pvapexch02.xlnx.xilinx.com;PTR:unknown-80-198.xilinx.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(316002)(70206006)(83380400001)(2906002)(6666004)(36860700001)(7696005)(47076005)(4326008)(70586007)(508600001)(8936002)(9786002)(7049001)(5660300002)(36756003)(8676002)(110136005)(356005)(7636003)(426003)(54906003)(1076003)(186003)(26005)(336012)(2616005)(82310400004)(6636002)(102446001);DIR:OUT;SFP:1101;
X-OriginatorOrg: xilinx.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2022 22:58:21.8068
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: fa08bafe-6aac-4926-4860-08d9e8fb022f
X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.80.198];Helo=[xir-pvapexch02.xlnx.xilinx.com]
X-MS-Exchange-CrossTenant-AuthSource:
	SN1NAM02FT0054.eop-nam02.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR0201MB8742

At the moment, Xen does not decode any of the arm64 instructions. This
means that hsr_dabt.isv = 0, Xen cannot handle those instructions. This
will lead to Xen abort the guests (from which those instructions
originated).

With this patch, Xen is able to decode ldr/str post indexing instructions.
These are a subset of instructions for which hsr_dabt.isv = 0

The following instructions are now supported by Xen :-
1.      ldr     x2,    [x1],    #8
2.      ldr     w2,    [x1],    #-4
3.      ldr     x2,    [x1],    #-8
4.      ldr     w2,    [x1],    #4
5.      ldrh    w2,    [x1],    #2
6.      ldrb    w2,    [x1],    #1
7.      str     x2,    [x1],    #8
8.      str     w2,    [x1],    #-4
9.      strh    w2,    [x1],    #2
10.     strb    w2,    [x1],    #1

In the subsequent patches, decode_arm64() will get invoked when
hsr_dabt.isv=0.

Signed-off-by: Ayan Kumar Halder <ayankuma@xilinx.com>
---

Changelog :-

v2..v5 - Mentioned in the cover letter.

v6 - 1. Fixed the code style issues as mentioned in v5.

v7 - No change.

 xen/arch/arm/decode.c           | 80 ++++++++++++++++++++++++++++++++-
 xen/arch/arm/decode.h           | 49 +++++++++++++++++---
 xen/arch/arm/include/asm/mmio.h |  4 ++
 xen/arch/arm/io.c               |  2 +-
 4 files changed, 125 insertions(+), 10 deletions(-)

diff --git a/xen/arch/arm/decode.c b/xen/arch/arm/decode.c
index 792c2e92a7..3f2d2a3f62 100644
--- a/xen/arch/arm/decode.c
+++ b/xen/arch/arm/decode.c
@@ -23,6 +23,7 @@
 #include <xen/types.h>
 
 #include <asm/current.h>
+#include <asm/mmio.h>
 
 #include "decode.h"
 
@@ -84,6 +85,78 @@ bad_thumb2:
     return 1;
 }
 
+static int decode_arm64(register_t pc, mmio_info_t *info)
+{
+    union instr opcode = {0};
+    struct hsr_dabt *dabt = &info->dabt;
+    struct instr_details *dabt_instr = &info->dabt_instr;
+
+    if ( raw_copy_from_guest(&opcode.value, (void * __user)pc, sizeof (opcode)) )
+    {
+        gprintk(XENLOG_ERR, "Could not copy the instruction from PC\n");
+        goto bad_loadstore;
+    }
+
+    /*
+     * Refer Arm v8 ARM DDI 0487G.b, Page - C6-1107
+     * "Shared decode for all encodings" (under ldr immediate)
+     * If n == t && n != 31, then the return value is implementation defined
+     * (can be WBSUPPRESS, UNKNOWN, UNDEFINED or NOP). Thus, we do not support
+     * this. This holds true for ldrb/ldrh immediate as well.
+     *
+     * Also refer, Page - C6-1384, the above described behaviour is same for
+     * str immediate. This holds true for strb/strh immediate as well
+     */
+    if ( (opcode.ldr_str.rn == opcode.ldr_str.rt) && (opcode.ldr_str.rn != 31) )
+    {
+        gprintk(XENLOG_ERR, "Rn should not be equal to Rt except for r31\n");
+        goto bad_loadstore;
+    }
+
+    /* First, let's check for the fixed values */
+    if ( (opcode.value & POST_INDEX_FIXED_MASK) != POST_INDEX_FIXED_VALUE )
+    {
+        gprintk(XENLOG_ERR,
+                "Decoding instruction 0x%x is not supported", opcode.value);
+        goto bad_loadstore;
+    }
+
+    if ( opcode.ldr_str.v != 0 )
+    {
+        gprintk(XENLOG_ERR,
+                "ldr/str post indexing for vector types are not supported\n");
+        goto bad_loadstore;
+    }
+
+    /* Check for STR (immediate) */
+    if ( opcode.ldr_str.opc == 0 )
+        dabt->write = 1;
+    /* Check for LDR (immediate) */
+    else if ( opcode.ldr_str.opc == 1 )
+        dabt->write = 0;
+    else
+    {
+        gprintk(XENLOG_ERR,
+                "Decoding ldr/str post indexing is not supported for this variant\n");
+        goto bad_loadstore;
+    }
+
+    gprintk(XENLOG_INFO,
+            "opcode->ldr_str.rt = 0x%x, opcode->ldr_str.size = 0x%x, opcode->ldr_str.imm9 = %d\n",
+            opcode.ldr_str.rt, opcode.ldr_str.size, opcode.ldr_str.imm9);
+
+    update_dabt(dabt, opcode.ldr_str.rt, opcode.ldr_str.size, false);
+
+    dabt_instr->rn = opcode.ldr_str.rn;
+    dabt_instr->imm9 = opcode.ldr_str.imm9;
+
+    return 0;
+
+ bad_loadstore:
+    gprintk(XENLOG_ERR, "unhandled Arm instruction 0x%x\n", opcode.value);
+    return 1;
+}
+
 static int decode_thumb(register_t pc, struct hsr_dabt *dabt)
 {
     uint16_t instr;
@@ -150,10 +223,13 @@ bad_thumb:
     return 1;
 }
 
-int decode_instruction(const struct cpu_user_regs *regs, struct hsr_dabt *dabt)
+int decode_instruction(const struct cpu_user_regs *regs, mmio_info_t *info)
 {
     if ( is_32bit_domain(current->domain) && regs->cpsr & PSR_THUMB )
-        return decode_thumb(regs->pc, dabt);
+        return decode_thumb(regs->pc, &info->dabt);
+
+    if ( !psr_mode_is_32bit(regs) )
+        return decode_arm64(regs->pc, info);
 
     /* TODO: Handle ARM instruction */
     gprintk(XENLOG_ERR, "unhandled ARM instruction\n");
diff --git a/xen/arch/arm/decode.h b/xen/arch/arm/decode.h
index 4613763bdb..fe7512a053 100644
--- a/xen/arch/arm/decode.h
+++ b/xen/arch/arm/decode.h
@@ -23,19 +23,54 @@
 #include <asm/regs.h>
 #include <asm/processor.h>
 
-/**
- * Decode an instruction from pc
- * /!\ This function is not intended to fully decode an instruction. It
- * considers that the instruction is valid.
+/*
+ * Refer to the ARMv8 ARM (DDI 0487G.b), Section C4.1.4 Loads and Stores
+ * Page 318 specifies the following bit pattern for
+ * "load/store register (immediate post-indexed)".
+ *
+ * 31 30 29  27 26 25  23   21 20              11   9         4       0
+ * ___________________________________________________________________
+ * |size|1 1 1 |V |0 0 |opc |0 |      imm9     |0 1 |  Rn     |  Rt   |
+ * |____|______|__|____|____|__|_______________|____|_________|_______|
+ */
+union instr {
+    uint32_t value;
+    struct {
+        unsigned int rt:5;     /* Rt register */
+        unsigned int rn:5;     /* Rn register */
+        unsigned int fixed1:2; /* value == 01b */
+        signed int imm9:9;            /* imm9 */
+        unsigned int fixed2:1; /* value == 0b */
+        unsigned int opc:2;    /* opc */
+        unsigned int fixed3:2; /* value == 00b */
+        unsigned int v:1;      /* vector */
+        unsigned int fixed4:3; /* value == 111b */
+        unsigned int size:2;   /* size */
+    } ldr_str;
+};
+
+#define POST_INDEX_FIXED_MASK   0x3B200C00
+#define POST_INDEX_FIXED_VALUE  0x38000400
+
+/* Decode an instruction from pc
+ * /!\ This function is intended to decode an instruction. It considers that the
+ * instruction is valid.
  *
- * This function will get:
- *  - The transfer register
+ * In case of thumb mode, this function will get:
+ *  - The transfer register (ie Rt)
  *  - Sign bit
  *  - Size
+ *
+ * In case of arm64 mode, this function will get:
+ * - The transfer register (ie Rt)
+ * - The source register (ie Rn)
+ * - Size
+ * - Immediate offset
+ * - Read or write
  */
 
 int decode_instruction(const struct cpu_user_regs *regs,
-                       struct hsr_dabt *dabt);
+                       mmio_info_t *info);
 
 #endif /* __ARCH_ARM_DECODE_H_ */
 
diff --git a/xen/arch/arm/include/asm/mmio.h b/xen/arch/arm/include/asm/mmio.h
index 7ab873cb8f..3354d9c635 100644
--- a/xen/arch/arm/include/asm/mmio.h
+++ b/xen/arch/arm/include/asm/mmio.h
@@ -29,6 +29,10 @@
 typedef struct
 {
     struct hsr_dabt dabt;
+    struct instr_details {
+        unsigned long rn:5;
+        signed int imm9:9;
+    } dabt_instr;
     paddr_t gpa;
 } mmio_info_t;
 
diff --git a/xen/arch/arm/io.c b/xen/arch/arm/io.c
index 729287e37c..a289d393f9 100644
--- a/xen/arch/arm/io.c
+++ b/xen/arch/arm/io.c
@@ -134,7 +134,7 @@ enum io_state try_handle_mmio(struct cpu_user_regs *regs,
     {
         int rc;
 
-        rc = decode_instruction(regs, &info.dabt);
+        rc = decode_instruction(regs, &info);
         if ( rc )
         {
             gprintk(XENLOG_DEBUG, "Unable to decode instruction\n");
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Sat Feb 05 22:58:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 05 Feb 2022 22:58:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266161.459858 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGU0k-0007PL-LO; Sat, 05 Feb 2022 22:58:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266161.459858; Sat, 05 Feb 2022 22:58:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGU0k-0007Ol-E3; Sat, 05 Feb 2022 22:58:30 +0000
Received: by outflank-mailman (input) for mailman id 266161;
 Sat, 05 Feb 2022 22:58:29 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=pZml=SU=xilinx.com=ayankuma@srs-se1.protection.inumbo.net>)
 id 1nGU0j-0007Ml-6H
 for xen-devel@lists.xenproject.org; Sat, 05 Feb 2022 22:58:29 +0000
Received: from NAM04-BN8-obe.outbound.protection.outlook.com
 (mail-bn8nam08on20603.outbound.protection.outlook.com
 [2a01:111:f400:7e8d::603])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1fe6ca6c-86d7-11ec-8eb8-a37418f5ba1a;
 Sat, 05 Feb 2022 23:58:26 +0100 (CET)
Received: from SN4PR0401CA0005.namprd04.prod.outlook.com
 (2603:10b6:803:21::15) by BN6PR02MB3234.namprd02.prod.outlook.com
 (2603:10b6:405:65::35) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Sat, 5 Feb
 2022 22:58:22 +0000
Received: from SN1NAM02FT0052.eop-nam02.prod.protection.outlook.com
 (2603:10b6:803:21:cafe::16) by SN4PR0401CA0005.outlook.office365.com
 (2603:10b6:803:21::15) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12 via Frontend
 Transport; Sat, 5 Feb 2022 22:58:22 +0000
Received: from xir-pvapexch01.xlnx.xilinx.com (149.199.80.198) by
 SN1NAM02FT0052.mail.protection.outlook.com (10.97.5.70) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.4951.12 via Frontend Transport; Sat, 5 Feb 2022 22:58:21 +0000
Received: from xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) by
 xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2176.14; Sat, 5 Feb 2022 22:58:20 +0000
Received: from smtp.xilinx.com (172.21.105.198) by
 xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server id
 15.1.2176.14 via Frontend Transport; Sat, 5 Feb 2022 22:58:19 +0000
Received: from [10.108.8.223] (port=45840 helo=xcbayankuma41x.xilinx.com)
 by smtp.xilinx.com with esmtp (Exim 4.90)
 (envelope-from <ayan.kumar.halder@xilinx.com>)
 id 1nGU0Y-0005LJ-SX; Sat, 05 Feb 2022 22:58:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1fe6ca6c-86d7-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=NDsWfXwJ2JZsZNTg7WmanJ+8taD7Ez07bwBiRaqeJu8mjXymiaNkUCtSBx3ii0rJDAeD8fUYxIC7JJMUv26heSoxyHkfaPH42J3Ura3yvAmZ3Gb1skcvaqy8O4y09MRywM+OKNfGcbHvarntqR/k7z97TVpjYs4sswTX2Zo5txOWXeVZjQrMzoQeexANBxWvbHbiFzTaZrD/VQDnpH/dwpIdUUGSjJyVTOZM2SHDi7wFjQygR+3dVmd2arKzmuQGOzaLgVIvfv16ROpTmHturbargHn5FbRXpmexJEhJA+RfZs31r+b5asUb16UVDFH3clmg9Rk6Zvi5luNi5qMZPA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=4VqlO1ntTl/yRfiLIXFfIRXVtxXzh0hwXYse28sFqdc=;
 b=QLAzDEeEgCnaprDKmT3ivdky4vxqxtbq33g09jw0dIFU1JXuRJt/UOAnqacgXlQxizZb64yzhxMCG1ANb89OJGRXTyItMO0cY+5UHBvWPW9rU1y4uvsIO2MC19m9ZucCkezQ8X3KMpuGbNroFDkaHoW0ZMrT6/44fs7HJA1lDmgfnIJvIJ0c3OA2VxOk60m39WZfbqnOXgOeGCJz9VqQbHB9f4F+LOHeyyoA/xwwFx09iNs+u1Is7crM59vGXNBxfljPrv0AhwnvdNfv+g0s5qoSwRnDIrubrvW2OJuob42C/ynYhRWj+6HDr2W6smdkJl0DxYIfYQwCzy3YdKQG1w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 149.199.80.198) smtp.rcpttodomain=lists.xenproject.org
 smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none
 header.from=xilinx.com; dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=4VqlO1ntTl/yRfiLIXFfIRXVtxXzh0hwXYse28sFqdc=;
 b=jQQ42rJBRj4ibtg6uGOi5ygq6UhPS5FxknNa/XIjKl3iBpD42Zr0T6RfIEjge3u66Yrk+Kc2e0Zew0OuksxJz/ywueWRTriTKMy24f3aYx1Ayfb807jWuBRzwigkggeTL1c9hfKgNMsXvhCPsYWR8RT29iNtS6UWGTqmsmtkMCg=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198)
 smtp.mailfrom=xilinx.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=xilinx.com;
Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates
 149.199.80.198 as permitted sender) receiver=protection.outlook.com;
 client-ip=149.199.80.198; helo=xir-pvapexch01.xlnx.xilinx.com;
From: Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>
To: <xen-devel@lists.xenproject.org>, <ayankuma@xilinx.com>
CC: <sstabellini@kernel.org>, <stefanos@xilinx.com>, <julien@xen.org>,
	<Volodymyr_Babchuk@epam.com>, <bertrand.marquis@arm.com>
Subject: [XEN v7 0/2] xen/arm64: io: Decode ldr/str post-indexing instruction
Date: Sat, 5 Feb 2022 22:58:14 +0000
Message-ID: <20220205225816.5952-1-ayankuma@xilinx.com>
X-Mailer: git-send-email 2.17.1
MIME-Version: 1.0
Content-Type: text/plain
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 35d7953c-1b4c-445a-062d-08d9e8fb01fa
X-MS-TrafficTypeDiagnostic: BN6PR02MB3234:EE_
X-Microsoft-Antispam-PRVS:
	<BN6PR02MB3234E7E0F891601E2AAC6CFFB22A9@BN6PR02MB3234.namprd02.prod.outlook.com>
X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply
X-MS-Oob-TLC-OOBClassifiers: OLM:5516;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	LK2fcIgUj/g6QlK95BXqnVs4upArXKl3edarBKLdCUWfydaWMpqIuWQsfwP0CBN5ISx1aEP/OaerIjbLpRG8IM3AoJpYCbesTzGxCqf1OjQgsrLycqxLfN7G4Sfr1Gw8G+9TjxqtNmGCbcQS502wiynGs1oP8fSSQiYnTeziBzRBWtVt97o3Xd9nXFPVYKYLe/zezvSaVwy/l7XVaQ+UwlPonZyhj4JgSsFsRqz7fU8NmzT1+iep5haccTmfoeNIMyc04/xQ5hWffVOcnLfvxWtVabrblKvMuzpQ2XS2Zo3S2Sh4fykg5eOnTPXE/Pm2HFzw+QLz5xs8UDv9CY9U5c1hONLw70TcON0RAgDStNrOFDtByyXBPgew3+4q/zXRvg9cjSb/wz4d4k5bK/zzUWfy6ZlIywh1+xXGoVkw3abhYOcA3QND1DEaz5/ayGRpW9eGAJ4ESICAOvzzklsKC/9MWG92DIw6ikvCMLT99f/+U0f0q1Q/0mhCZdMTSuc7IFmuaJlaqOqdYNLxdzTk+oG4I5eZQGIqqLY+k+ylOpoZT0dv+VWbTebDx+Epedv67tu/hpj77kb6hoyNtXjFirDlrI3Eq19WrM6+fi/9MHH0g0xmuor7PwdaZ1a4QybVgfv3tzvx7jTISgNYBJv61EZHIbVK+oNfkMGHmNYun7oLIgLcvEZxvF39nyAsyuENDppvk9ZolQNyc/YVMR3Niw==
X-Forefront-Antispam-Report:
	CIP:149.199.80.198;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:xir-pvapexch01.xlnx.xilinx.com;PTR:unknown-80-198.xilinx.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(110136005)(508600001)(1076003)(7696005)(36756003)(6666004)(83380400001)(47076005)(426003)(8936002)(8676002)(7049001)(26005)(2616005)(336012)(186003)(70586007)(70206006)(4326008)(2906002)(7636003)(356005)(316002)(6636002)(5660300002)(36860700001)(54906003)(82310400004)(9786002)(102446001)(473944003);DIR:OUT;SFP:1101;
X-OriginatorOrg: xilinx.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2022 22:58:21.4421
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 35d7953c-1b4c-445a-062d-08d9e8fb01fa
X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.80.198];Helo=[xir-pvapexch01.xlnx.xilinx.com]
X-MS-Exchange-CrossTenant-AuthSource:
	SN1NAM02FT0052.eop-nam02.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR02MB3234

Hi All,

The patch series introduces support to decode instructions by Xen when ISS
is invalid. Currently, when the guest executes post indexing ldr/str instructions
on emulated MMIO, these instruction was trapped into Xen as a data abort.
Xen reads hsr_dabt.isv = 0, so ISS is invalid. Therefore, it reads the
faulting instruction's opcode from guest's PC. It decodes and executes the
instruction on the emulated region.

Ayan Kumar Halder (2):
  xen/arm64: Decode ldr/str post increment operations
  xen/arm64: io: Support instructions (for which ISS is not valid) on
    emulated MMIO region using MMIO/ioreq handler

 xen/arch/arm/arm32/traps.c        |   7 ++
 xen/arch/arm/arm64/traps.c        |  47 +++++++++++++
 xen/arch/arm/decode.c             |  81 +++++++++++++++++++++-
 xen/arch/arm/decode.h             |  48 +++++++++++--
 xen/arch/arm/include/asm/domain.h |   4 ++
 xen/arch/arm/include/asm/ioreq.h  |   1 +
 xen/arch/arm/include/asm/mmio.h   |  20 +++++-
 xen/arch/arm/include/asm/traps.h  |   2 +
 xen/arch/arm/io.c                 | 108 ++++++++++++++++++++----------
 xen/arch/arm/ioreq.c              |  12 ++--
 xen/arch/arm/traps.c              |  85 ++++++++++++++++++++---
 xen/arch/x86/include/asm/ioreq.h  |   3 +
 xen/include/xen/sched.h           |   2 +
 13 files changed, 362 insertions(+), 58 deletions(-)

Changelog :-
v2 - 1. Updated the rn register after reading from it. (Pointed by Julien,
        Stefano)
     2. Used a union to represent the instruction opcode (Suggestd by Bertrand)
     3. Fixed coding style issues (Pointed by Julien)
     4. In the previous patch, I was updating dabt->sign based on the signedness
        of imm9. This was incorrect. As mentioned in ARMv8 ARM  DDI 0487G.b,
        Page 3221, SSE indicates the signedness of the data item loaded. In our
        case, the data item loaded is always unsigned.

v3- 1. Handled all the variants of ldr/str (ie 64, 32, 16, 8 bit variants).
       Thus, I have removed the check for "instr->code.opc == 0" (Suggested by
       Andre)
    2. Handled the scenario when rn = SP, rt = XZR (Suggested by Jan, Andre)
    3. Added restriction for "rt != rn" (Suggested by Andre)
    4. Moved union ldr_str_instr_class {} to decode.h. This is the header included
       by io.c and decode.c (where the union is referred). (Suggested by Jan)
    5. Indentation and typo fixes (Suggested by Jan)

v4- 1. Fixed the patch as per Stefano's comments on v3. They are as follows :-
        1.1 Use macros to determine the fixed values in the instruction opcode
        1.2 Checked if instr != NULL
        1.3 Changed some data types and added #define ARM_64 for AArch64 specific
            code
        1.4 Moved post_increment_register() to decode.c so that the decoding
            logic is confined to a single file.
        1.5 Moved some checks from post_increment_register() to
            decode_loadstore_postindexing()
        1.6 Removed a duplicate check
    2. Updated the commit message as per Andre's comments.
    3. Changed the names of a label and some comments. *32bit* was erroneously
       mentioned in a label and comments in decode_loadstore_postindexing()
       although the function handled all variants of ldr/str post indexing.

v5- 1. Renamed decode_loadstore_postindexing() to decode_arm64(). The reason
       being this will be extended in future to support more instructions for
       which hsr_badt.isv = 0
    2. Introduce a function try_decode_instruction_invalid_iss() to determine
       if the instruction needs to be decoded before invoking decode_instruction().

       It checks :-
       2.1  dabt->s1ptw - Returns IO_UNHANDLED
       2.2  dabt->cache - Returns IO_IGNORED. (new enum instroduced to let the
            caller know that the instruction needs to be ignored by Xen. Thus
            the caller needs to increment the PC and return to the guest.

    3. Invoked try_decode_instruction_invalid_iss() from the following 2 places :-
        3.a - try_handle_mmio() - When we have determined that there is a valid
              mmio handler.
        3.b - try_fwd_ioserv()
        When ioserver completes the io request, the acknowledgement is sent via
        handle_ioserv(). Here, we need to increment the register. As there is no
        common data shared between try_fwd_ioserv() and handle_ioserv(), we need
        to decode the instruction again in handle_ioserv() to determine rn, imm9.

        (NOTE to Reviewers) - This does not feel correct. However, I could not
        think of a better approach. Please provide your inputs.

    4. Augumented struct hsr_dabt{} with struct hsr_dabt_instr_details{} to hold
       rn and imm9. This is passed to post_increment_register() to update rn.
    5. Other style changes as suggested in v4.

v6 - 1. Split the patch into three parts.

v7 - 1. Merged patch2 and patch3 into a single patch.

-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Sat Feb 05 22:58:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 05 Feb 2022 22:58:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266162.459874 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGU0m-0007sb-VR; Sat, 05 Feb 2022 22:58:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266162.459874; Sat, 05 Feb 2022 22:58:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGU0m-0007sN-RJ; Sat, 05 Feb 2022 22:58:32 +0000
Received: by outflank-mailman (input) for mailman id 266162;
 Sat, 05 Feb 2022 22:58:31 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=pZml=SU=xilinx.com=ayankuma@srs-se1.protection.inumbo.net>)
 id 1nGU0l-0007Mw-6h
 for xen-devel@lists.xenproject.org; Sat, 05 Feb 2022 22:58:31 +0000
Received: from NAM12-MW2-obe.outbound.protection.outlook.com
 (mail-mw2nam12on20627.outbound.protection.outlook.com
 [2a01:111:f400:fe5a::627])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 206ceea8-86d7-11ec-8f75-fffcc8bd4f1a;
 Sat, 05 Feb 2022 23:58:28 +0100 (CET)
Received: from SN4PR0401CA0010.namprd04.prod.outlook.com
 (2603:10b6:803:21::20) by BL0PR02MB6515.namprd02.prod.outlook.com
 (2603:10b6:208:17e::18) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.11; Sat, 5 Feb
 2022 22:58:23 +0000
Received: from SN1NAM02FT0052.eop-nam02.prod.protection.outlook.com
 (2603:10b6:803:21:cafe::ad) by SN4PR0401CA0010.outlook.office365.com
 (2603:10b6:803:21::20) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12 via Frontend
 Transport; Sat, 5 Feb 2022 22:58:23 +0000
Received: from xir-pvapexch01.xlnx.xilinx.com (149.199.80.198) by
 SN1NAM02FT0052.mail.protection.outlook.com (10.97.5.70) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.4951.12 via Frontend Transport; Sat, 5 Feb 2022 22:58:22 +0000
Received: from xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) by
 xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2176.14; Sat, 5 Feb 2022 22:58:21 +0000
Received: from smtp.xilinx.com (172.21.105.198) by
 xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server id
 15.1.2176.14 via Frontend Transport; Sat, 5 Feb 2022 22:58:21 +0000
Received: from [10.108.8.223] (port=45840 helo=xcbayankuma41x.xilinx.com)
 by smtp.xilinx.com with esmtp (Exim 4.90)
 (envelope-from <ayan.kumar.halder@xilinx.com>)
 id 1nGU0b-0005LJ-OU; Sat, 05 Feb 2022 22:58:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 206ceea8-86d7-11ec-8f75-fffcc8bd4f1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=kIriFnIQBOXwuRP8OJHKTHJS1+7NgilqHRxsEwkEYm/FW1nqdI7OhqblQ69B6ELYOwglUNDX5u3PdtisPs1L+HuDy2a2JipcKeMWjdMr7OpJej8I6ETG3loYBdR/g7t7aPmToNyrCL0GPOamOnXHjMYwlX9/AKTeSMHkgoLBCItDf9DAKm/8kZQPUlh4DDRcab4762JOoR6DiGw1mvlJ2RIcEMfhlmkT/IwjXE+GbIzHh2B2bZr+pux6qfBWG2LfxhxAwjzaD8xBO9hJ+QhzQXfiwpHQ9YBFYti8ySrqbnu8jnS/1r87ENTCSuGQ4Dgy9ZIcpG3BbsJghEeC+3HZxA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=x9q3Pk1GKbbWLocFk/cvHDGnaEDTZBGVMHVoyqFAQec=;
 b=YkDqcXggY5QvITYF8Digen+wLWXe0N65x1ugohLFmR8In9NN/gyrHBohUuaDl2IhVVdY8DVLdTyEY9hXC2XcGa1IWOhGDlnn1r7k4TUqdXnVM+JCX1gKFW81qBtqCs8sTd6ljZwXP3Yaf+PRjUJP4IdsHYYYPwwmLrZuILZvfXLmPocPY6PYzlmF7Tmx8utAx+3BtP6ZhNiS8vkLL13C51SRzHAfQnoO03lElyjOIJYF/zZj9cGYqexeez4sMGW4KItertjGwTsetPIqlZA1eITF5XMjYbWSZDlz9tpNKTKj3LagrKgYCstyGTrHxbAWoxzFzbuuiuswZXMHsb/PRw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 149.199.80.198) smtp.rcpttodomain=lists.xenproject.org
 smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none
 header.from=xilinx.com; dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=x9q3Pk1GKbbWLocFk/cvHDGnaEDTZBGVMHVoyqFAQec=;
 b=JxKbBnwdlJpZh0qAClHlOxPHSx0LTmU937FdEUK+9LPPvUBFPlXcTBuYHlIpathi5IrTuQc53d4Qpmtan/9/Xg92Wtfdndn8hbRc0j1D9arxEHi/xW0mzUFbXkj/o6UOtpAOg0DRKnutPiVUxb+2n4savMBL0CkeP7C95ibW98A=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198)
 smtp.mailfrom=xilinx.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=xilinx.com;
Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates
 149.199.80.198 as permitted sender) receiver=protection.outlook.com;
 client-ip=149.199.80.198; helo=xir-pvapexch01.xlnx.xilinx.com;
From: Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>
To: <xen-devel@lists.xenproject.org>, <ayankuma@xilinx.com>
CC: <sstabellini@kernel.org>, <stefanos@xilinx.com>, <julien@xen.org>,
	<Volodymyr_Babchuk@epam.com>, <bertrand.marquis@arm.com>
Subject: [XEN v7 2/2] xen/arm64: io: Support instructions (for which ISS is not valid) on emulated MMIO region using MMIO/ioreq handler
Date: Sat, 5 Feb 2022 22:58:16 +0000
Message-ID: <20220205225816.5952-3-ayankuma@xilinx.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20220205225816.5952-1-ayankuma@xilinx.com>
References: <20220205225816.5952-1-ayankuma@xilinx.com>
MIME-Version: 1.0
Content-Type: text/plain
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c9068e51-5a7a-4947-97db-08d9e8fb02d0
X-MS-TrafficTypeDiagnostic: BL0PR02MB6515:EE_
X-Microsoft-Antispam-PRVS:
	<BL0PR02MB6515046912F4635BDBACD2EEB22A9@BL0PR02MB6515.namprd02.prod.outlook.com>
X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply
X-MS-Oob-TLC-OOBClassifiers: OLM:6108;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	bsCKsZKrwk6cPtmEcZOHWOIlwLcwa0B9MRFNZpbcnsFSz358R0+M+silFqexffsKertXlnp/uuUbya03SqtxKhvHRPgVIcLVm24sfJuYA3LnT0bxlnv9PwJqZ36e/rzXuK5BK3BjfH2ICxqFuZ3WxPa3VA76aPt/mNCmTaauhrM+w43ZyLhJt/eRB/BFQR/EytQbh7HbGSihBIJzQu7c2b8DsTNyqwRaLmU675HPDUz5osYYN9RprtDXttp/kxP64Ary+Jti4X+g69WgzJzDa4zJG2XJsFoBIZAZ8JdU5tomfCdLiVXGZ9B5DXUEF9XjAv6jC10zMc1/PB8myhmnrOi4fQeWtUp5eyignQcWpI8slqKZ0QtPaQIw0543f7POFRXLaxvJUvUhQCjLlRyubRaQxo8oAm9OXfd/nHx2TyzY0YxeESdxG8Bt4xXrosOmCeCUCREoj6Og6qzZYbuspcCtshXJDlUxEndWCrFaWFRr1fF3zsf1gJ1fVMjshfFhTJmZLaURfE6giC0JwC1bo4+GH27jtXHZYXB1dxQipYAPUJ72LWtimFVV1hZKpZPmc+OKs/Gglj3bYzFJekoEyEklM2ItNofwXGijp8re6/8csOr80XnwaqU4o460D9XbTpdM2Ve2uPthJxM6V50PyGasZUMBO99rTTHwX5vL2nDDOtudAUuPf/iDguJ/1bA6WgJ+PsI1QX1zng6vL0/EOg==
X-Forefront-Antispam-Report:
	CIP:149.199.80.198;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:xir-pvapexch01.xlnx.xilinx.com;PTR:unknown-80-198.xilinx.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(6636002)(316002)(356005)(8936002)(110136005)(54906003)(4326008)(70586007)(70206006)(7049001)(8676002)(508600001)(7636003)(36756003)(47076005)(9786002)(336012)(26005)(2906002)(186003)(426003)(1076003)(2616005)(83380400001)(36860700001)(82310400004)(30864003)(5660300002)(6666004)(7696005)(102446001)(473944003);DIR:OUT;SFP:1101;
X-OriginatorOrg: xilinx.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2022 22:58:22.8483
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: c9068e51-5a7a-4947-97db-08d9e8fb02d0
X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.80.198];Helo=[xir-pvapexch01.xlnx.xilinx.com]
X-MS-Exchange-CrossTenant-AuthSource:
	SN1NAM02FT0052.eop-nam02.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR02MB6515

When an instruction is trapped in Xen due to translation fault, Xen checks if
the ISS is valid. If not, Xen tries to resolve the translation fault using
p2m page tables. In case if it is a data abort, Xen will try to map the mmio
region to the guest (ie tries to emulate the mmio region).

If the ISS is not valid, then Xen tries to decode the instruction. In case of
ioreq, Xen  saves the decoding state, rn and imm9 to vcpu_io. Whenever the
vcpu handles the ioreq successfully, it will read the decoding state to
determine if the instruction decoded was a ldr/str post indexing (ie
INSTR_LDR_STR_POSTINDEXING). If so, it uses these details to post increment rn.

In case of mmio handler, if the mmio operation was successful, then Xen retrives
the decoding state, rn and imm9. For state == INSTR_LDR_STR_POSTINDEXING, Xen
will update rn.

If there is an error encountered while decoding the instruction, Xen will issue
an abort to the guest. If the instruction was related to cache maintenance, Xen
will not decode the instruction or do any MMIO operation. Rather it simply
increments the PC and returns to the guest. If the instruction was trapped due
to stage1 page translation table walk, Xen will update the page tables and will
return to the guest so that it can retry the instruction. To handle all these
different states, we have introduced 'enum instr_decode_state'.

Signed-off-by: Ayan Kumar Halder <ayankuma@xilinx.com>
---

Changelog :-

v2..v5 - Mentioned in the cover letter.

v6 - 1. Mantained the decoding state of the instruction. This is used by the
caller to either abort the guest or retry or ignore or perform read/write on
the mmio region.

2. try_decode() invokes decoding for both aarch64 and thumb state. (Previously
it used to invoke decoding only for aarch64 state). Thus, it handles all the
checking of the registers before invoking any decoding of instruction.
try_decode_instruction_invalid_iss() has thus been removed.

3. Introduced a new field('enum instr_decode_state state') inside
'struct instr_details'. This holds the decoding state of the instruction.
This is later read by the post_increment_register() to determine if rn needs to
be incremented. Also, this is read by the callers of try_decode_instruction()
to determine if the instruction was valid or ignored or to be retried or
error or decoded successfully.

4. Also stored 'instr_details' inside 'struct ioreq'. This enables
arch_ioreq_complete_mmio() to invoke post_increment_register() without decoding
the instruction again.

5. Check hsr.dabt.valid in do_trap_stage2_abort_guest(). If it is not valid,
then decode the instruction. This ensures that try_handle_mmio() is invoked only
when the instruction is either valid or decoded successfully.

6. Inside do_trap_stage2_abort_guest(), if hsr.dabt.valid is not set, then
resolve the translation fault before trying to decode the instruction. If
translation fault is resolved, then return to the guest to execute the instruction
again.


v7 - 1. Moved the decoding instruction details ie instr_details from 'struct ioreq'
to 'struct vcpu_io'.

2. The instruction is decoded only when we get a data abort.

3. Replaced ASSERT_UNREACHABLE() with domain_crash(). The reason being asserts
can be disabled in some builds. In this scenario when the guest's cpsr is in an
erroneous state, Xen should crash the guest.

4. Introduced check_p2m() which invokes p2m_resolve_translation_fault() and
try_map_mmio() to resolve translation fault by configuring the page tables. This
gets invoked first if ISS is invalid and it is an instruction abort. If it is
a data abort and hsr.dabt.s1ptw is set or try_handle_mmio() returns IO_UNHANDLED,
then check_p2m() gets invoked again.

 xen/arch/arm/arm32/traps.c        |   7 ++
 xen/arch/arm/arm64/traps.c        |  47 +++++++++++++
 xen/arch/arm/decode.c             |   1 +
 xen/arch/arm/decode.h             |   3 +-
 xen/arch/arm/include/asm/domain.h |   4 ++
 xen/arch/arm/include/asm/ioreq.h  |   1 +
 xen/arch/arm/include/asm/mmio.h   |  16 ++++-
 xen/arch/arm/include/asm/traps.h  |   2 +
 xen/arch/arm/io.c                 | 108 ++++++++++++++++++++----------
 xen/arch/arm/ioreq.c              |  12 ++--
 xen/arch/arm/traps.c              |  85 ++++++++++++++++++++---
 xen/arch/x86/include/asm/ioreq.h  |   3 +
 xen/include/xen/sched.h           |   2 +
 13 files changed, 240 insertions(+), 51 deletions(-)

diff --git a/xen/arch/arm/arm32/traps.c b/xen/arch/arm/arm32/traps.c
index 9c9790a6d1..70c6238196 100644
--- a/xen/arch/arm/arm32/traps.c
+++ b/xen/arch/arm/arm32/traps.c
@@ -18,9 +18,11 @@
 
 #include <xen/lib.h>
 #include <xen/kernel.h>
+#include <xen/sched.h>
 
 #include <public/xen.h>
 
+#include <asm/mmio.h>
 #include <asm/processor.h>
 #include <asm/traps.h>
 
@@ -82,6 +84,11 @@ void do_trap_data_abort(struct cpu_user_regs *regs)
         do_unexpected_trap("Data Abort", regs);
 }
 
+void post_increment_register(const struct instr_details *instr)
+{
+    domain_crash(current->domain);
+}
+
 /*
  * Local variables:
  * mode: C
diff --git a/xen/arch/arm/arm64/traps.c b/xen/arch/arm/arm64/traps.c
index 9113a15c7a..a6766689b3 100644
--- a/xen/arch/arm/arm64/traps.c
+++ b/xen/arch/arm/arm64/traps.c
@@ -23,6 +23,7 @@
 #include <asm/processor.h>
 
 #include <public/xen.h>
+#include <xen/sched.h>
 
 static const char *handler[]= {
         "Synchronous Abort",
@@ -44,6 +45,52 @@ void do_bad_mode(struct cpu_user_regs *regs, int reason)
     panic("bad mode\n");
 }
 
+void post_increment_register(const struct instr_details *instr)
+{
+    struct cpu_user_regs *regs = guest_cpu_user_regs();
+    register_t val = 0;
+
+    /* Currently, we handle only ldr/str post indexing instructions */
+    if ( instr->state != INSTR_LDR_STR_POSTINDEXING )
+        return;
+
+    /*
+     * Handle when rn = SP
+     * Refer ArmV8 ARM DDI 0487G.b, Page - D1-2463 "Stack pointer register
+     * selection"
+     * t = SP_EL0
+     * h = SP_ELx
+     * and M[3:0] (Page - C5-474 "When exception taken from AArch64 state:")
+     */
+    if (instr->rn == 31 )
+    {
+        if ( (regs->cpsr & PSR_MODE_MASK) == PSR_MODE_EL1h )
+            val = regs->sp_el1;
+        else if ( ((regs->cpsr & PSR_MODE_MASK) == PSR_MODE_EL1t) ||
+                    ((regs->cpsr & PSR_MODE_MASK) == PSR_MODE_EL0t) )
+            val = regs->sp_el0;
+        else
+        {
+            domain_crash(current->domain);
+            return;
+        }
+    }
+    else
+        val = get_user_reg(regs, instr->rn);
+
+    val += instr->imm9;
+
+    if ( instr->rn == 31 )
+    {
+        if ( (regs->cpsr & PSR_MODE_MASK) == PSR_MODE_EL1h )
+            regs->sp_el1 = val;
+        else
+            regs->sp_el0 = val;
+    }
+    else
+        set_user_reg(regs, instr->rn, val);
+}
+
 /*
  * Local variables:
  * mode: C
diff --git a/xen/arch/arm/decode.c b/xen/arch/arm/decode.c
index 3f2d2a3f62..0a4d9d2772 100644
--- a/xen/arch/arm/decode.c
+++ b/xen/arch/arm/decode.c
@@ -147,6 +147,7 @@ static int decode_arm64(register_t pc, mmio_info_t *info)
 
     update_dabt(dabt, opcode.ldr_str.rt, opcode.ldr_str.size, false);
 
+    dabt_instr->state = INSTR_LDR_STR_POSTINDEXING;
     dabt_instr->rn = opcode.ldr_str.rn;
     dabt_instr->imm9 = opcode.ldr_str.imm9;
 
diff --git a/xen/arch/arm/decode.h b/xen/arch/arm/decode.h
index fe7512a053..6a09b07b46 100644
--- a/xen/arch/arm/decode.h
+++ b/xen/arch/arm/decode.h
@@ -52,7 +52,8 @@ union instr {
 #define POST_INDEX_FIXED_MASK   0x3B200C00
 #define POST_INDEX_FIXED_VALUE  0x38000400
 
-/* Decode an instruction from pc
+/*
+ * Decode an instruction from pc
  * /!\ This function is intended to decode an instruction. It considers that the
  * instruction is valid.
  *
diff --git a/xen/arch/arm/include/asm/domain.h b/xen/arch/arm/include/asm/domain.h
index 9b3647587a..29efbbd334 100644
--- a/xen/arch/arm/include/asm/domain.h
+++ b/xen/arch/arm/include/asm/domain.h
@@ -266,6 +266,10 @@ static inline void arch_vcpu_block(struct vcpu *v) {}
 /* vPCI is not available on Arm */
 #define has_vpci(d)    ({ (void)(d); false; })
 
+struct arch_vcpu_io {
+    struct instr_details *dabt_instr; /* when the instruction is decoded */
+};
+
 #endif /* __ASM_DOMAIN_H__ */
 
 /*
diff --git a/xen/arch/arm/include/asm/ioreq.h b/xen/arch/arm/include/asm/ioreq.h
index 50185978d5..a2f2cf76c7 100644
--- a/xen/arch/arm/include/asm/ioreq.h
+++ b/xen/arch/arm/include/asm/ioreq.h
@@ -52,6 +52,7 @@ static inline void msix_write_completion(struct vcpu *v)
 {
 }
 
+
 /* This correlation must not be altered */
 #define IOREQ_STATUS_HANDLED     IO_HANDLED
 #define IOREQ_STATUS_UNHANDLED   IO_UNHANDLED
diff --git a/xen/arch/arm/include/asm/mmio.h b/xen/arch/arm/include/asm/mmio.h
index 3354d9c635..fb7ff72cdc 100644
--- a/xen/arch/arm/include/asm/mmio.h
+++ b/xen/arch/arm/include/asm/mmio.h
@@ -26,12 +26,23 @@
 
 #define MAX_IO_HANDLER  16
 
+enum instr_decode_state
+{
+    INSTR_ERROR,                    /* Error encountered while decoding instr */
+    INSTR_VALID,                    /* ISS is valid, so no need to decode */
+    INSTR_LDR_STR_POSTINDEXING,     /* Instruction is decoded successfully.
+                                       It is ldr/str post indexing */
+    INSTR_IGNORE,                   /* Instruction is to be ignored (ie NOP) */
+    INSTR_RETRY                     /* Instruction is to be retried */
+};
+
 typedef struct
 {
     struct hsr_dabt dabt;
     struct instr_details {
         unsigned long rn:5;
         signed int imm9:9;
+        enum instr_decode_state state;
     } dabt_instr;
     paddr_t gpa;
 } mmio_info_t;
@@ -69,14 +80,15 @@ struct vmmio {
 };
 
 enum io_state try_handle_mmio(struct cpu_user_regs *regs,
-                              const union hsr hsr,
-                              paddr_t gpa);
+                              mmio_info_t *info);
 void register_mmio_handler(struct domain *d,
                            const struct mmio_handler_ops *ops,
                            paddr_t addr, paddr_t size, void *priv);
 int domain_io_init(struct domain *d, int max_count);
 void domain_io_free(struct domain *d);
 
+void try_decode_instruction(const struct cpu_user_regs *regs,
+                            mmio_info_t *info);
 
 #endif  /* __ASM_ARM_MMIO_H__ */
 
diff --git a/xen/arch/arm/include/asm/traps.h b/xen/arch/arm/include/asm/traps.h
index 2ed2b85c6f..95c46ad391 100644
--- a/xen/arch/arm/include/asm/traps.h
+++ b/xen/arch/arm/include/asm/traps.h
@@ -109,6 +109,8 @@ static inline register_t sign_extend(const struct hsr_dabt dabt, register_t r)
     return r;
 }
 
+void post_increment_register(const struct instr_details *instr);
+
 #endif /* __ASM_ARM_TRAPS__ */
 /*
  * Local variables:
diff --git a/xen/arch/arm/io.c b/xen/arch/arm/io.c
index a289d393f9..25bc7e481a 100644
--- a/xen/arch/arm/io.c
+++ b/xen/arch/arm/io.c
@@ -95,57 +95,97 @@ static const struct mmio_handler *find_mmio_handler(struct domain *d,
     return handler;
 }
 
+void try_decode_instruction(const struct cpu_user_regs *regs,
+                            mmio_info_t *info)
+{
+    int rc;
+
+    /*
+     * Erratum 766422: Thumb store translation fault to Hypervisor may
+     * not have correct HSR Rt value.
+     */
+    if ( check_workaround_766422() && (regs->cpsr & PSR_THUMB) &&
+         info->dabt.write )
+    {
+        rc = decode_instruction(regs, info);
+        if ( rc )
+        {
+            gprintk(XENLOG_DEBUG, "Unable to decode instruction\n");
+            info->dabt_instr.state = INSTR_ERROR;
+            return;
+        }
+    }
+
+    /* If ISS is valid, then no need to decode the instruction any further */
+    if ( info->dabt.valid )
+    {
+        info->dabt_instr.state = INSTR_VALID;
+        return;
+    }
+
+    /*
+     * Xen should not decode the instruction when it was trapped due to
+     * translation fault.
+     */
+    if ( info->dabt.s1ptw )
+    {
+        info->dabt_instr.state = INSTR_RETRY;
+        return;
+    }
+
+    /*
+     * If the fault occurred due to cache maintenance or address translation
+     * instructions, then Xen needs to ignore these instructions.
+     */
+    if ( info->dabt.cache )
+    {
+        info->dabt_instr.state = INSTR_IGNORE;
+        return;
+    }
+
+    /*
+     * Armv8 processor does not provide a valid syndrome for decoding some
+     * instructions. So in order to process these instructions, Xen must
+     * decode them.
+     */
+    rc = decode_instruction(regs, info);
+    if ( rc )
+    {
+        gprintk(XENLOG_ERR, "Unable to decode instruction\n");
+        info->dabt_instr.state = INSTR_ERROR;
+    }
+}
+
 enum io_state try_handle_mmio(struct cpu_user_regs *regs,
-                              const union hsr hsr,
-                              paddr_t gpa)
+                              mmio_info_t *info)
 {
     struct vcpu *v = current;
     const struct mmio_handler *handler = NULL;
-    const struct hsr_dabt dabt = hsr.dabt;
-    mmio_info_t info = {
-        .gpa = gpa,
-        .dabt = dabt
-    };
+    int rc;
 
-    ASSERT(hsr.ec == HSR_EC_DATA_ABORT_LOWER_EL);
+    ASSERT(info->dabt.ec == HSR_EC_DATA_ABORT_LOWER_EL);
 
-    handler = find_mmio_handler(v->domain, info.gpa);
+    handler = find_mmio_handler(v->domain, info->gpa);
     if ( !handler )
     {
-        int rc;
-
-        rc = try_fwd_ioserv(regs, v, &info);
+        rc = try_fwd_ioserv(regs, v, info);
         if ( rc == IO_HANDLED )
             return handle_ioserv(regs, v);
 
         return rc;
     }
 
-    /* All the instructions used on emulated MMIO region should be valid */
-    if ( !dabt.valid )
-        return IO_ABORT;
-
     /*
-     * Erratum 766422: Thumb store translation fault to Hypervisor may
-     * not have correct HSR Rt value.
+     * At this point, we know that the instruction is either valid or has been
+     * decoded successfully. Thus, Xen should be allowed to execute the
+     * instruction on the emulated MMIO region.
      */
-    if ( check_workaround_766422() && (regs->cpsr & PSR_THUMB) &&
-         dabt.write )
-    {
-        int rc;
-
-        rc = decode_instruction(regs, &info);
-        if ( rc )
-        {
-            gprintk(XENLOG_DEBUG, "Unable to decode instruction\n");
-            return IO_ABORT;
-        }
-    }
-
-    if ( info.dabt.write )
-        return handle_write(handler, v, &info);
+    if ( info->dabt.write )
+        rc = handle_write(handler, v, info);
     else
-        return handle_read(handler, v, &info);
+        rc = handle_read(handler, v, info);
+
+    return rc;
 }
 
 void register_mmio_handler(struct domain *d,
diff --git a/xen/arch/arm/ioreq.c b/xen/arch/arm/ioreq.c
index 308650b400..ec830a7a4a 100644
--- a/xen/arch/arm/ioreq.c
+++ b/xen/arch/arm/ioreq.c
@@ -26,7 +26,8 @@
 enum io_state handle_ioserv(struct cpu_user_regs *regs, struct vcpu *v)
 {
     const union hsr hsr = { .bits = regs->hsr };
-    const struct hsr_dabt dabt = hsr.dabt;
+    struct hsr_dabt dabt = hsr.dabt;
+
     /* Code is similar to handle_read */
     register_t r = v->io.req.data;
 
@@ -47,6 +48,7 @@ enum io_state try_fwd_ioserv(struct cpu_user_regs *regs,
                              struct vcpu *v, mmio_info_t *info)
 {
     struct vcpu_io *vio = &v->io;
+    struct dabt_instr *instr = &info->dabt_instr;
     ioreq_t p = {
         .type = IOREQ_TYPE_COPY,
         .addr = info->gpa,
@@ -65,6 +67,8 @@ enum io_state try_fwd_ioserv(struct cpu_user_regs *regs,
     };
     struct ioreq_server *s = NULL;
     enum io_state rc;
+    bool instr_decoded = false;
+    const union hsr hsr = { .bits = regs->hsr };
 
     if ( vio->req.state != STATE_IOREQ_NONE )
     {
@@ -76,10 +80,8 @@ enum io_state try_fwd_ioserv(struct cpu_user_regs *regs,
     if ( !s )
         return IO_UNHANDLED;
 
-    if ( !info->dabt.valid )
-        return IO_ABORT;
-
     vio->req = p;
+    vio->info.dabt_instr = instr;
 
     rc = ioreq_send(s, &p, 0);
     if ( rc != IO_RETRY || v->domain->is_shutting_down )
@@ -95,6 +97,7 @@ enum io_state try_fwd_ioserv(struct cpu_user_regs *regs,
 bool arch_ioreq_complete_mmio(void)
 {
     struct vcpu *v = current;
+    struct instr_details *dabt_instr = v->io.info.dabt_instr;
     struct cpu_user_regs *regs = guest_cpu_user_regs();
     const union hsr hsr = { .bits = regs->hsr };
 
@@ -106,6 +109,7 @@ bool arch_ioreq_complete_mmio(void)
 
     if ( handle_ioserv(regs, v) == IO_HANDLED )
     {
+        post_increment_register(dabt_instr);
         advance_pc(regs, hsr);
         return true;
     }
diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c
index 9339d12f58..fb5a2f9634 100644
--- a/xen/arch/arm/traps.c
+++ b/xen/arch/arm/traps.c
@@ -1893,6 +1893,21 @@ static bool try_map_mmio(gfn_t gfn)
     return !map_regions_p2mt(d, gfn, 1, mfn, p2m_mmio_direct_c);
 }
 
+static inline bool check_p2m(bool is_data, paddr_t gpa)
+{
+    /*
+     * First check if the translation fault can be resolved by the P2M subsystem.
+     * If that's the case nothing else to do.
+     */
+    if ( p2m_resolve_translation_fault(current->domain,gaddr_to_gfn(gpa)) )
+        return true;
+
+    if ( is_data && try_map_mmio(gaddr_to_gfn(gpa)) )
+        return true;
+
+    return false;
+}
+
 static void do_trap_stage2_abort_guest(struct cpu_user_regs *regs,
                                        const union hsr hsr)
 {
@@ -1906,6 +1921,7 @@ static void do_trap_stage2_abort_guest(struct cpu_user_regs *regs,
     paddr_t gpa;
     uint8_t fsc = xabt.fsc & ~FSC_LL_MASK;
     bool is_data = (hsr.ec == HSR_EC_DATA_ABORT_LOWER_EL);
+    mmio_info_t info;
 
     /*
      * If this bit has been set, it means that this stage-2 abort is caused
@@ -1959,6 +1975,25 @@ static void do_trap_stage2_abort_guest(struct cpu_user_regs *regs,
         return;
     }
     case FSC_FLT_TRANS:
+    {
+        info.gpa = gpa;
+        info.dabt = hsr.dabt;
+
+        /* Check that the ISS is invalid and it is not data abort. */
+        if ( !hsr.dabt.valid && !is_data )
+        {
+
+            /*
+             * Assumption :- Most of the times when we get a translation fault
+             * and the ISS is invalid, the underlying cause is that the page
+             * tables have not been set up correctly.
+             */
+            if ( check_p2m(is_data, gpa) )
+                return;
+            else
+                goto inject_abt;
+        }
+
         /*
          * Attempt first to emulate the MMIO as the data abort will
          * likely happen in an emulated region.
@@ -1967,13 +2002,49 @@ static void do_trap_stage2_abort_guest(struct cpu_user_regs *regs,
          */
         if ( is_data )
         {
-            enum io_state state = try_handle_mmio(regs, hsr, gpa);
+            enum io_state state;
+
+            try_decode_instruction(regs, &info);
+
+            /*
+             * If the instruction was to be ignored by Xen, then it should return
+             * to the caller which will increment the PC, so that the guest can
+             * execute the next instruction.
+             */
+            if ( info.dabt_instr.state == INSTR_IGNORE )
+            {
+                advance_pc(regs, hsr);
+                return;
+            }
+
+            /*
+             * If Xen could not decode the instruction for any reason, then it
+             * should ask the caller to abort the guest.
+             */
+            else if ( info.dabt_instr.state == INSTR_ERROR )
+                goto inject_abt;
+
+            /*
+             * When the instruction needs to be retried by the guest after
+             * resolving the translation fault.
+             */
+            else if ( info.dabt_instr.state == INSTR_RETRY )
+                goto set_page_tables;
+
+            state = try_handle_mmio(regs, &info);
 
             switch ( state )
             {
             case IO_ABORT:
                 goto inject_abt;
             case IO_HANDLED:
+                /*
+                 * If the instruction was decoded and has executed successfully
+                 * on the MMIO region, then Xen should execute the next part of
+                 * the instruction. (for eg increment the rn if it is a
+                 * post-indexing instruction.
+                 */
+                post_increment_register(&info.dabt_instr);
                 advance_pc(regs, hsr);
                 return;
             case IO_RETRY:
@@ -1985,18 +2056,12 @@ static void do_trap_stage2_abort_guest(struct cpu_user_regs *regs,
             }
         }
 
-        /*
-         * First check if the translation fault can be resolved by the
-         * P2M subsystem. If that's the case nothing else to do.
-         */
-        if ( p2m_resolve_translation_fault(current->domain,
-                                           gaddr_to_gfn(gpa)) )
-            return;
-
-        if ( is_data && try_map_mmio(gaddr_to_gfn(gpa)) )
+ set_page_tables:
+        if ( check_p2m(is_data, gpa) )
             return;
 
         break;
+    }
     default:
         gprintk(XENLOG_WARNING,
                 "Unsupported FSC: HSR=%#"PRIregister" DFSC=%#x\n",
diff --git a/xen/arch/x86/include/asm/ioreq.h b/xen/arch/x86/include/asm/ioreq.h
index d06ce9a6ea..ecfe7f9fdb 100644
--- a/xen/arch/x86/include/asm/ioreq.h
+++ b/xen/arch/x86/include/asm/ioreq.h
@@ -26,6 +26,9 @@
 #include <asm/hvm/ioreq.h>
 #endif
 
+struct arch_vcpu_io {
+};
+
 #endif /* __ASM_X86_IOREQ_H__ */
 
 /*
diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
index 37f78cc4c4..afe5508be8 100644
--- a/xen/include/xen/sched.h
+++ b/xen/include/xen/sched.h
@@ -160,6 +160,8 @@ struct vcpu_io {
     /* I/O request in flight to device model. */
     enum vio_completion  completion;
     ioreq_t              req;
+    /* Arch specific info pertaining to the io request */
+    struct arch_vcpu_io  info;
 };
 
 struct vcpu
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Sun Feb 06 01:28:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 06 Feb 2022 01:28:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266190.459885 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGWLI-00089K-Rl; Sun, 06 Feb 2022 01:27:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266190.459885; Sun, 06 Feb 2022 01:27:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGWLI-00089D-Nv; Sun, 06 Feb 2022 01:27:52 +0000
Received: by outflank-mailman (input) for mailman id 266190;
 Sun, 06 Feb 2022 01:27:50 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nGWLG-000893-TU; Sun, 06 Feb 2022 01:27:50 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nGWLG-0002cb-Qn; Sun, 06 Feb 2022 01:27:50 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nGWLG-00070Z-7X; Sun, 06 Feb 2022 01:27:50 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nGWLG-0006Ys-4i; Sun, 06 Feb 2022 01:27:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=1KnZMPCcsz97g/9BsGtEnKov35/3K8jes0wjCrol5BE=; b=YHuGUqjU1HMhWV1VPdzDCrtZ8X
	ji2uFwu/PbTGRkJoVrAUOCNNJKMALvE8+p+q1vyV4vhZv2cvk6sYtacEBFXtNe0EacIHtzMZWFoLa
	i3OGV8GxY0VTpy8Utj4GAtwgkMF6NuUgSQlEGsfrBGryOrLVfKdw/fWghH/6ZeDe0qWs=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168022-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 168022: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-libvirt-qcow2:guest-start/debian.repeat:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=0457e5153e0e8420134f60921349099e907264ca
X-Osstest-Versions-That:
    linux=dcb85f85fa6f142aae1fe86f399d4503d49f2b60
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 06 Feb 2022 01:27:50 +0000

flight 168022 linux-linus real [real]
flight 168028 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/168022/
http://logs.test-lab.xenproject.org/osstest/logs/168028/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-libvirt-qcow2 19 guest-start/debian.repeat fail pass in 168028-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168012
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168012
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168012
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168012
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168012
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168012
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168012
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168012
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                0457e5153e0e8420134f60921349099e907264ca
baseline version:
 linux                dcb85f85fa6f142aae1fe86f399d4503d49f2b60

Last test of basis   168012  2022-02-04 16:57:25 Z    1 days
Testing same since   168022  2022-02-05 05:38:07 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Aditya Garg <gargaditya08@live.com>
  Agustin Gutierrez <agustin.gutierrez@amd.com>
  Ajish Koshy <Ajish.Koshy@microchip.com>
  Ajit Kumar Pandey <AjitKumar.Pandey@amd.com>
  Albert Geantă <albertgeanta@gmail.com>
  Alex Deucher <alexander.deucher@amd.com>
  Alexander Stein <alexander.stein@ew.tq-group.com>
  Andrew Morton <akpm@linux-foundation.org>
  Anitha Chrisanthus <anitha.chrisanthus@intel.com>
  Anton Lundin <glance@acc.umu.se>
  Aun-Ali Zaidi <admin@kodeit.net>
  Bernard Metzler <bmt@zurich.ibm.com>
  Bjorn Helgaas <bhelgaas@google.com>
  Catalin Marinas <catalin.marinas@arm.com>
  Charles Keepax <ckeepax@opensource.cirrus.com>
  Chen Wandun <chenwandun@huawei.com>
  Chris Leech <cleech@redhat.com>
  Christian Gmeiner <christian.gmeiner@gmail.com>
  Christian König <christian.koenig@amd.com>
  Christian Lachner <gladiac@gmail.com>
  Christoph Hellwig <hch@lst.de>
  Christophe JAILLET <christophe.jaillet@wanadoo.fr>
  Damien Le Moal <damien.lemoal@opensource.wdc.com>
  Dan Carpenter <dan.carpenter@oracle.com>
  Daniel Vetter <daniel.vetter@ffwll.ch>
  Daniel Wheeler <daniel.wheeler@amd.com>
  Dave Airlie <airlied@redhat.com>
  David Hildenbrand <david@redhat.com>
  David Howells <dhowells@redhat.com>
  David Rientjes <rientjes@google.com>
  David Sterba <dsterba@suse.com>
  Dmitry Ivanov <dmitry.ivanov2@hpe.com>
  Dmitry Osipenko <digetx@gmail.com>
  Dominik Brodowski <linux@dominikbrodowski.net>
  Dominique Martinet <asmadeus@codewreck.org>
  Dong Aisheng <aisheng.dong@nxp.com>
  Evan Quan <evan.quan@amd.com>
  Filipe Manana <fdmanana@suse.com>
  Francesco Dolcini <francesco.dolcini@toradex.com>
  Gao Xiang <hsiangkao@linux.alibaba.com>
  Geert Uytterhoeven <geert+renesas@glider.be>
  Geert Uytterhoeven <geert@linux-m68k.org>
  Guangwu Zhang <guazhang@redhat.com>
  Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
  Guenter Roeck <linux@roeck-us.net>
  Guoqing Jiang <guoqing.jiang@linux.dev>
  Helge Deller <deller@gmx.de>
  Ilya Dryomov <idryomov@gmail.com>
  Imre Deak <imre.deak@intel.com>
  Jack Wang <jinpu.wang@ionos.com>
  Jason A. Donenfeld <Jason@zx2c4.com>
  Jason Gunthorpe <jgg@nvidia.com>
  Jeff Layton <jlayton@kernel.org>
  Jens Axboe <axboe@kernel.dk>
  Jiasheng Jiang <jiasheng@iscas.ac.cn>
  Joerg Roedel <jroedel@suse.de>
  John Garry <john.garry@huawei.com>
  John Harrison <John.C.Harrison@Intel.com>
  John Meneghini <jmeneghi@redhat.com>
  John Stultz <john.stultz@linaro.org>
  Jonas Hahnfeld <hahnjo@hahnjo.de>
  Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
  Jordy Zomer <jordy@pwning.systems>
  Jukka Heikintalo <heikintalo.jukka@gmail.com>
  Julian Braha <julianbraha@gmail.com>
  Karol Herbst <kherbst@redhat.com>
  Lang Yu <Lang.Yu@amd.com>
  Leon Möller <jkhsjdhjs@totally.rip>
  Leon Romanovsky <leonro@nvidia.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Lu Baolu <baolu.lu@linux.intel.com>
  Maor Gottlieb <maorg@nvidia.com>
  Marek Vasut <marex@denx.de>
  Mario Limonciello <mario.limonciello@amd.com>
  Mark Brown <broonie@kernel.org>
  Mark Zhang <markzhang@nvidia.com>
  Martin K. Petersen <martin.petersen@oracle.com>
  Martin Wilck <mwilck@suse.com>
  Matthew Brost <matthew.brost@intel.com>
  Miaoqian Lin <linmq006@gmail.com>
  Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>
  Mike Rapoport <rppt@linux.ibm.com>
  Miles Chen <miles.chen@mediatek.com>
  Ming Lei <ming.lei@redhat.com>
  Minghao Chi <chi.minghao@zte.com.cn>
  Nathan Chancellor <nathan@kernel.org>
  Nick Desaulniers <ndesaulniers@google.com>
  Nick Lopez <github@glowingmonkey.org>
  Pasha Tatashin <pasha.tatashin@soleen.com>
  Paul Hsieh <paul.hsieh@amd.com>
  Paweł Susicki <pawel.susicki@gmail.com>
  Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
  Qu Wenruo <wqu@suse.com>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Randy Dunlap <rdunlap@infradead.org>
  Robert Hancock <robert.hancock@calian.com>
  Rohith Surabattula <rohiths@microsoft.com>
  Ryan Bair <ryandbair@gmail.com>
  Sagi Grimberg <sagi@grimberg.me>
  Saurav Kashyap <skashyap@marvell.com>
  Sergey Shtylyov <s.shtylyov@omp.ru>
  Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
  Shuah Khan <skhan@linuxfoundation.org>
  Shyam Prasad N <sprasad@microsoft.com>
  Song Liu <song@kernel.org>
  Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
  Steve French <stfrench@microsoft.com>
  Stylon Wang <stylon.wang@amd.com>
  Su Yue <l@damenly.su>
  Sumit Semwal <sumit.semwal@linaro.org>
  Sven Schnelle <svens@stackframe.org>
  Takashi Iwai <tiwai@suse.de>
  Thomas Zimmermann <tzimmermann@suse.de>
  Tom Rix <trix@redhat.com>
  Tvrtko Ursulin <tvrtko.ursulin@intel.com>
  Uday Shankar <ushankar@purestorage.com>
  Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
  Vijayanand Jitta <quic_vjitta@quicinc.com>
  Ville Syrjälä <ville.syrjala@linux.intel.com>
  Viswas G <Viswas.G@microchip.com>
  Vlastimil Babka <vbabka@suse.cz>
  Zhan Liu <Zhan.Liu@amd.com>
  Zi Yan <ziy@nvidia.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               fail    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   dcb85f85fa6f1..0457e5153e0e8  0457e5153e0e8420134f60921349099e907264ca -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Sun Feb 06 04:42:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 06 Feb 2022 04:42:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266203.459896 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGZN0-0001Tm-0e; Sun, 06 Feb 2022 04:41:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266203.459896; Sun, 06 Feb 2022 04:41:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGZMz-0001Te-Rh; Sun, 06 Feb 2022 04:41:49 +0000
Received: by outflank-mailman (input) for mailman id 266203;
 Sun, 06 Feb 2022 04:41:48 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nGZMy-0001TU-DZ; Sun, 06 Feb 2022 04:41:48 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nGZMy-0006b5-7h; Sun, 06 Feb 2022 04:41:48 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nGZMw-00010U-SG; Sun, 06 Feb 2022 04:41:47 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nGZMw-0000be-Qa; Sun, 06 Feb 2022 04:41:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=TWOX6AXispDWdxqYJsAiNyRH1i2FimQp+vZqtMx54os=; b=cqvKNd/lEcgBvHJI3S7KBVg/13
	8VM3CNZPL5IvlncKX+ydPphn4qFK41SjzWcdzrbGwqZ5J9gZ7AY6QixnxP45hoysKhnaNw093BIrm
	StYwasq+PDVBoouR4iutWFODWgT3i4/AXgd25FsiqpT/cwwCBqQgV/hfWvCIZh9TVl1s=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168024-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-5.4 test] 168024: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-5.4:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=b8f53f91712808313bf7b5bd9947d7095968248a
X-Osstest-Versions-That:
    linux=2570bb2729c7cbcecf9a4abc1e740b02a722b6e6
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 06 Feb 2022 04:41:46 +0000

flight 168024 linux-5.4 real [real]
flight 168030 linux-5.4 real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/168024/
http://logs.test-lab.xenproject.org/osstest/logs/168030/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 168030-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167974
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167974
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 167974
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167974
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167974
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167974
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167974
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167974
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 167974
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167974
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167974
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167974
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 linux                b8f53f91712808313bf7b5bd9947d7095968248a
baseline version:
 linux                2570bb2729c7cbcecf9a4abc1e740b02a722b6e6

Last test of basis   167974  2022-02-01 16:40:36 Z    4 days
Testing same since   168024  2022-02-05 11:44:31 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  "Eric W. Biederman" <ebiederm@xmission.com>
  Bjorn Helgaas <bhelgaas@google.com>
  Eric Dumazet <edumazet@google.com>
  Eric W. Biederman <ebiederm@xmission.com>
  Florian Fainelli <f.fainelli@gmail.com>
  Georgi Valkov <gvalkov@abv.bg>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Guenter Roeck <linux@roeck-us.net>
  Jakub Kicinski <kuba@kernel.org>
  Jan Kiszka <jan.kiszka@siemens.com>
  Johannes Weiner <hannes@cmpxchg.org>
  Jon Hunter <jonathanh@nvidia.com>
  Joseph Bao <joseph.bao@intel.com>
  Linux Kernel Functional Testing <lkft@linaro.org>
  Lukas Wunner <lukas@wunner.de>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Raju Rangoju <Raju.Rangoju@amd.com>
  Shuah Khan <skhan@linuxfoundation.org>
  Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
  Slade Watkins <slade@sladewatkins.com>
  Sudheesh Mavila <sudheesh.mavila@amd.com>
  Suren Baghdasaryan <surenb@google.com>
  Tabitha Sable <tabitha.c.sable@gmail.com>
  Tejun Heo <tj@kernel.org>
  Tianchen Ding <dtcccc@linux.alibaba.com>
  Tom Lendacky <thomas.lendacky@amd.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   2570bb2729c7c..b8f53f9171280  b8f53f91712808313bf7b5bd9947d7095968248a -> tested/linux-5.4


From xen-devel-bounces@lists.xenproject.org Sun Feb 06 06:02:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 06 Feb 2022 06:02:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266217.459907 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGadA-0001Bs-66; Sun, 06 Feb 2022 06:02:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266217.459907; Sun, 06 Feb 2022 06:02:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGadA-0001Bl-2m; Sun, 06 Feb 2022 06:02:36 +0000
Received: by outflank-mailman (input) for mailman id 266217;
 Sun, 06 Feb 2022 06:02:34 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=thp5=SV=yahoo.com=akm2tosher@srs-se1.protection.inumbo.net>)
 id 1nGad7-0001Bb-Sf
 for xen-devel@lists.xenproject.org; Sun, 06 Feb 2022 06:02:34 +0000
Received: from sonic313-37.consmr.mail.ne1.yahoo.com
 (sonic313-37.consmr.mail.ne1.yahoo.com [66.163.185.60])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5deab646-8712-11ec-8f75-fffcc8bd4f1a;
 Sun, 06 Feb 2022 07:02:31 +0100 (CET)
Received: from sonic.gate.mail.ne1.yahoo.com by
 sonic313.consmr.mail.ne1.yahoo.com with HTTP; Sun, 6 Feb 2022 06:02:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5deab646-8712-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1644127348; bh=64dZg5Kq7nmVHL0EFHFGeSk3OvC+bM/+NWLW4wquqS0=; h=Date:From:To:Cc:Subject:References:From:Subject:Reply-To; b=LAJwLxAlePaKGTbFsyfyGOvdM4Z2zbPH42HyiXzSYjDdYJOyM090gSWgdkVxVHKXPqQ7gW62Rzloz6GUy4HeFXM0CXH1b4pLrNT8SLJ3cvbc/FfDKTArr7Qeqj1SJhD0BwZ0Q05zHj0dRmUa02n1vTVIkkJsnpaYhl0pNDYQ1LfjpJTyI7n1D6UTgV5D+6szWgyqqncQHTn71YRBsyKkPMg7c2s0thjPHAEcZvoN8Cgh8IXzTzmvsQUqMf5pmFxHvsom15G6BvLEPLIzebmhByjfUXhgkm8707jkrjXcvQ6R/VyP2yRrMwdqQWPmiiwyFy9aTtdsT5OiSij0dxxqsg==
X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1644127348; bh=KRDHbZZKXr6AZdtF09mjGXD9OTRpvv1aESFUXWSu3RG=; h=X-Sonic-MF:Date:From:To:Subject:From:Subject; b=LLGfamuv2qYQj11G129Y3c9fvGu35x4usPqEGCl3p8iiwhvGPqtwUml6W3I44rf/4nFG2QKeVxLwR5XIF+XS+Rl8huRmyRE9b0obauGJGjzpsGTCjX1xUPFhWT8V9r/c3nzSEonl0tLo5Isq7Azg1JW4CGHXaQdjUcTmS7Dw/CTPmAaXXxiQUSN5wg+4kBAgz+2waYC6JYDEEX14ArSmeG6MoRGFHXNfHFpjSuFF7PRxQbZZFoeeIoOCKRq23csz/2hKBd6aGtDKhby/OBXUSVivsS/eqtJLLv2vl3OluPd43nRKQm6Mbvwp/iy+35PKcY7OZb8Y5f3ReF4/atu92A==
X-YMail-OSG: l4eypU0VM1k9T2AzUAQWUD6GfOQ1bvHBrXUdnZaLbTToDAwl6617YKtrVLDs3EG
 HX.f.R7IXHs_LGWnteSkMB5EynMAzqDFUxJOzRHLGYw0r6hK9GvWcDJp2qiGKT_DkYqXQQv_XTwH
 Igi4uHeuQ2TGTMTwuO6pz7v4AFLDy9d6ZUX0HtrQjZ1HKvaK22os98roLATK6YW2XCsRw4kpg8dJ
 bwKCG_tn4qOb3NnoUCknwKQe_Wv48Lt6Cc0nBmMZpH7AKQuid2Ei55ofnEM_1p1i2lBbWQln7Afm
 mtcXLI_jr3CHPEkP24gBCMVWqMtaZFcp4SZVn8dGcYGmr4cSr2EOBdNmF7gVCoNBoAHSsVXpuY0h
 LTBaBZbUBnVpTSPfAyTdvZm4PKxYmKcZdFSL_2cg0PgG1PNFPzrH_kkgrFHvBf757Seph1lJQ5ZX
 toyDUnU4K99Xmj0kc8EfA8LigurBTF8TYAPFjN1Eki5FEBAYLyYeVjXKRdvyDuqxURt5XdR9dXF7
 H4VjcSfdAgEqSsKkNToIl1A8rKaDE8E_xdH.KZ.kMsNvqAHPH53xSpoUQ7fXGB_FxRoGvbgrNhap
 k5QQW08W3nQitpTWW_3rj1jF8czUaOmaSYTO7Iuc1qD7w4zRZCGIqY6dsFPnovQdYtfpg4.Xnzm9
 Kk2A4LL.H7DjMlVanvwtr9KEREmWmWHheO_IkT1GA14CFCI1nPPGRQdH8XtSeigNc4c8ryTKnrlw
 _8G6Ce2TF7mqi6UU7rieqZBlc44MoijAmhAjT2TP65LOMlMqBrbvjtcR440yCoXwuvosxH866BVk
 eudzTqSIreucHTrp8F_wL0oGO3LPbVDmoBwaljoJjQjJrIosQvoO2DPVEilsPri6yKWhjgww7Avc
 E3vp.nVGj0Pz38rubmKRsfyU0xuCIbHZ56fQpw.DQzYBJAiZjzXGzKvbbEWrTnz_3.ihZvevm3ga
 nmFbk4PzvJNsJ1sa9hNpdQYTdawp3AYv3c4D7adA0CBgnMeM5vXUed0KBctds20Z1TSR5rIlixly
 koJwVMTi216HTFAl6.Mh.fEGHXjo_VtRHmCZGNnUqQeh1FdsLftWNaOEtnQsX6i_NHfB5H5_payX
 gqCPGJ9Vfr7Nqeb6dHolVLU3PVTldK2ffpegh_ZJR1ECD9yiA89Vd.hVFY02hvVhZGzK.I4HDZFD
 c0XEjlw1RlznxeeX28r2oBo6VVtPp7PyxE6pbBs54qUIdgFF1jA2BUBzu8YunisFLmWuEDWJTOuD
 2r5yQ2G.P2rCmSNREeNGMpNRB_llW2sKcw6iRqJY4AiWevW7a27.il0E.six56xzfFvR9VUkcfcH
 32eLr2ek2OtXbbiMWC7jkAl2Vx4fcRjs_h3Fls3GJtVrbxzdLAqVM9ob4xH7tIn5zb1sM9sVAe.U
 z_Lm.iNsUU3GJKUSUAVPKZDhAffxa_gwng7_UR9Mts_FpX28MRybg8BbF4hFRGrC5KKAFlljNAr6
 jGl4ODGTbDEx9nyEDxlh7mcZtBdl9ZWKRIDro4XpAyDjHtgfZrQwQKT_KAB7k.hTIY0LGmOCXdbJ
 sZ_Cg3oGd2Ek98fQ3zRfYL.16yFI0mC7HJp1.yqzIFEfYI8.4sDgFBy65.dL3J6Nb3T4uWhKWhbB
 QQ0MK3UMPOlZVVxDVkwMyWXGLBrkePTDg22mHHT4_svTsIKcIJMbKj89e7Qd0MMGHlO6cd1ZlGUe
 Yv5JWprphpC8WNTk1EFt.9CF58b7C8EuZgz3ajsXZsRlLKpz5vHlEbs.8WdgJBFr2vAqMusFmW3E
 4wRLpjhpClS_5KpDI5PK_FUmW8jeLzP9rgy8QskThQ7X5RyoQ8MCllpsonL_D.gctdT2odP8BJqw
 u7kZNm8Zsrr2CLLYOP7PR5cWMbe4QCJOj3ce7XnsJIELPz.su3YTD_dfSdNBJhpArLb2HPUFYZOe
 zvroUqMPJ6ziYCoKagTCx7JMhW4kSqdP1C4VY8ao9XgK4nZC5osQlBjawQWjTkipuyc9fBZIQ1aZ
 oDNA6rjNnMnrCARfzJcN5DJ0ySCFh4f0AGBe7oqLhmaoTcP9a7JmGgGGr7oXPp9wJnQ_mGt5RZy5
 yftDTolNSNq24z5H8HnBPBy7246dgLzuukLqoRyBBTKa0OzWuHoAzWChsU..S1Ted_ox6Lw6lBWr
 dQH.RihlTOHV39Bv3Fj8wJ182Q86mPn5j9o84mtG_6rsVHRnuy61mIyse45oNR8JMIkTu5I4ikEF
 _1fDS8ZaX1eDlHtDpSq1f6E_AHRJDdpYaviKOSg--
X-Sonic-MF: <akm2tosher@yahoo.com>
Date: Sun, 6 Feb 2022 05:59:57 +0000 (UTC)
From: tosher 1 <akm2tosher@yahoo.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: "roger.pau@citrix.com" <roger.pau@citrix.com>, 
	"xadimgnik@gmail.com" <xadimgnik@gmail.com>, 
	"oleksandr_andrushchenko@epam.com" <oleksandr_andrushchenko@epam.com>
Message-ID: <709142925.628001.1644127197288@mail.yahoo.com>
Subject: PCI passthrough support for PVH mode
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
References: <709142925.628001.1644127197288.ref@mail.yahoo.com>
X-Mailer: WebService/1.1.19711 YMailNorrin
Content-Length: 374

Hi,

Back in the year 2020, I was inquiring into the status of PCI passthrough support for PVH guests. At that time, Arm people were working on using vPCI for guest VMs. The expectation was to port that implementation to x86 once ready.

I was wondering if there is any update on this. Does Xen support PCI passthrough for PVH mode yet? Please let me know.

Thanks,
Mehrab


From xen-devel-bounces@lists.xenproject.org Sun Feb 06 06:13:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 06 Feb 2022 06:13:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266225.459918 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGanV-0002e9-5O; Sun, 06 Feb 2022 06:13:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266225.459918; Sun, 06 Feb 2022 06:13:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGanV-0002e2-1g; Sun, 06 Feb 2022 06:13:17 +0000
Received: by outflank-mailman (input) for mailman id 266225;
 Sun, 06 Feb 2022 06:13:16 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Bc/j=SV=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nGanT-0002dw-W0
 for xen-devel@lists.xenproject.org; Sun, 06 Feb 2022 06:13:16 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id de5a32c9-8713-11ec-8eb8-a37418f5ba1a;
 Sun, 06 Feb 2022 07:13:14 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 566A11F388;
 Sun,  6 Feb 2022 06:13:14 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 31E09139EF;
 Sun,  6 Feb 2022 06:13:14 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id mzC4Cvpm/2HaTgAAMHmgww
 (envelope-from <jgross@suse.com>); Sun, 06 Feb 2022 06:13:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: de5a32c9-8713-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1644127994; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=b9j627IG0HosD/OkE7yv/PUGv9f5Phy0U58ez6FidSA=;
	b=qZuYxtySHuOFdLvYOZGS1P08ZpAk5JDRAKNpQLNKCkAp/N8Id85O7GMCq+zHItGqw634m9
	Bh75uuZ5KkaUn9M34PDXTA251R284uNygPMTj1pHO4j+JsoJK6NPsgu2ZMTc6Z1JxT4/I5
	rOmRuNfK8K9mg30mgd2FmSu0vjeUuks=
Message-ID: <2ad6d8db-9926-4a69-94c9-ae669e24f404@suse.com>
Date: Sun, 6 Feb 2022 07:13:13 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Subject: Re: [GIT PULL] xen: branch for v5.17-rc3
Content-Language: en-US
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
 xen-devel@lists.xenproject.org, Boris Ostrovsky <boris.ostrovsky@oracle.com>
References: <20220205110717.16946-1-jgross@suse.com>
 <CAHk-=wjp-h4bFWsWSPQ+5o6iuiPwiFNRNxfDSaDjURzVU6Af7A@mail.gmail.com>
 <CAHk-=wj_ObnioAixXdec63_aXXaS8SUEAsMQgfiHwhXNOYMn5Q@mail.gmail.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <CAHk-=wj_ObnioAixXdec63_aXXaS8SUEAsMQgfiHwhXNOYMn5Q@mail.gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------CMKgQ4RDZI8wpr20AGMwomTw"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------CMKgQ4RDZI8wpr20AGMwomTw
Content-Type: multipart/mixed; boundary="------------f0d5uFHCDvNCO6K6U4UOXrXq";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
 xen-devel@lists.xenproject.org, Boris Ostrovsky <boris.ostrovsky@oracle.com>
Message-ID: <2ad6d8db-9926-4a69-94c9-ae669e24f404@suse.com>
Subject: Re: [GIT PULL] xen: branch for v5.17-rc3
References: <20220205110717.16946-1-jgross@suse.com>
 <CAHk-=wjp-h4bFWsWSPQ+5o6iuiPwiFNRNxfDSaDjURzVU6Af7A@mail.gmail.com>
 <CAHk-=wj_ObnioAixXdec63_aXXaS8SUEAsMQgfiHwhXNOYMn5Q@mail.gmail.com>
In-Reply-To: <CAHk-=wj_ObnioAixXdec63_aXXaS8SUEAsMQgfiHwhXNOYMn5Q@mail.gmail.com>

--------------f0d5uFHCDvNCO6K6U4UOXrXq
Content-Type: multipart/mixed; boundary="------------zi2i02yO9nq6JwG4192Jh06i"

--------------zi2i02yO9nq6JwG4192Jh06i
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMDUuMDIuMjIgMTk6NDIsIExpbnVzIFRvcnZhbGRzIHdyb3RlOg0KPiBPbiBTYXQsIEZl
YiA1LCAyMDIyIGF0IDk6NTggQU0gTGludXMgVG9ydmFsZHMNCj4gPHRvcnZhbGRzQGxpbnV4
LWZvdW5kYXRpb24ub3JnPiB3cm90ZToNCj4+DQo+PiBPbiBTYXQsIEZlYiA1LCAyMDIyIGF0
IDM6MDcgQU0gSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPiB3cm90ZToNCj4+Pg0K
Pj4+IFBsZWFzZSBnaXQgcHVsbCB0aGUgZm9sbG93aW5nIHRhZzoNCj4+Pg0KPj4+ICAgZ2l0
Oi8vZ2l0Lmtlcm5lbC5vcmcvcHViL3NjbS9saW51eC9rZXJuZWwvZ2l0L3hlbi90aXAuZ2l0
IGZvci1saW51cy01LjE3YS1yYzMtdGFnDQo+Pg0KPj4gRGlmZnN0YXQ/IFNob3J0bG9nPw0K
Pj4NCj4+IFRoaXMgaXMgbm90IGEgdmFsaWQgcHVsbCByZXF1ZXN0Lg0KDQpPaCwgSSdtIHNv
cnJ5IGZvciB0aGF0Lg0KDQpTZWVtcyBhcyBpZiBhIHJlY2VudCBzeXN0ZW0gdXBkYXRlIHB1
bGxlZCBpbiBhIG5ld2VyIHZlcnNpb24gb2YgZ2l0IHdpdGgNCmNoYW5nZWQgYmVoYXZpb3Is
IGFuZCBteSBzY3JpcHQgZ2VuZXJhdGluZyB0aGUgcHVsbCByZXF1ZXN0IHNpbGVudGx5DQpp
Z25vcmVkIHRoZSBlcnJvciB3aGVuIHRyeWluZyB0byBhZGQgdGhlIGRpZmZzdGF0IGFuZCBz
aG9ydGxvZy4NCg0KSSd2ZSBmaXhlZCBteSBnaXQgY29uZmlnIGFuZCBteSBzY3JpcHQuDQoN
Cj4gT2ggd2VsbC4gWW91J3JlIGxpa2VseSBvZmZsaW5lIC0gSSBlbmRlZCB1cCBqdXN0IGNo
ZWNraW5nIHlvdXINCj4gZGVzY3JpcHRpb24gaW5zdGVhZC4NCg0KVGhhbmsgeW91IHZlcnkg
bXVjaCwNCg0KDQpKdWVyZ2VuDQo=
--------------zi2i02yO9nq6JwG4192Jh06i
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------zi2i02yO9nq6JwG4192Jh06i--

--------------f0d5uFHCDvNCO6K6U4UOXrXq--

--------------CMKgQ4RDZI8wpr20AGMwomTw
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmH/ZvkFAwAAAAAACgkQsN6d1ii/Ey/2
eQf+KWt5Kw+RsNxYlOG+m/x2Q5y5B9P/pxgtPxG3Txx1Zp7Dk8HpVCu9NHRdrZOL/1AQ0sL+qrnp
vb3OB/vsrbdcPqlotTTtUwUwRVORAmKRshB40eMOwTII+PTaQQREYmd7jZqzM9kIXFcjg3JPNkZu
WAWIwkZ/MYWwTLJxWI4g636LoUPfxHam1gfwSEN5NZE/sXDHY91gdLjFgGrURxUqg0G1bZ6kJOmY
b5d/OabusR0XTOJoSSDEt7yo5iKzpWWZ8y6H2EtLv/QUSNKCVav2nt/zdstTespM1FJqFfdNMAi7
oMNdVGHTTnaat8MaxX5HgAiP8ZP07ycNOfpQigffuw==
=wNJW
-----END PGP SIGNATURE-----

--------------CMKgQ4RDZI8wpr20AGMwomTw--


From xen-devel-bounces@lists.xenproject.org Sun Feb 06 07:03:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 06 Feb 2022 07:03:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266233.459929 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGba0-0007eG-1X; Sun, 06 Feb 2022 07:03:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266233.459929; Sun, 06 Feb 2022 07:03:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGbZz-0007e9-UL; Sun, 06 Feb 2022 07:03:23 +0000
Received: by outflank-mailman (input) for mailman id 266233;
 Sun, 06 Feb 2022 07:03:22 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nGbZy-0007du-Lu; Sun, 06 Feb 2022 07:03:22 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nGbZy-0000ss-IT; Sun, 06 Feb 2022 07:03:22 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nGbZy-0005Oi-1z; Sun, 06 Feb 2022 07:03:22 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nGbZy-0006PE-1X; Sun, 06 Feb 2022 07:03:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=+Ps1wHf3SBWjaDIJIVKU5OfqEwjkeCxi0DifqkpQm+g=; b=nkkcTPuLBEnZ9eyTQg3qF60nUe
	hAwQz1MYkzp6OK87+OF9ICvElPpjeVLeRCyBTi8iwExqbid6hab9EZaAbz9Mx9ZJ5mN/p7X1o4SGE
	f4wh4M8ehvnGpsPEotcOhUGsUdLr3lrghA4I3ahIhguddKQC+mZHIV8PcggmRTOk3aBk=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168027-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 168027: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-unstable:test-arm64-arm64-xl-vhd:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=820cc393434097f3b7976acdccbf1d96071d6d23
X-Osstest-Versions-That:
    xen=820cc393434097f3b7976acdccbf1d96071d6d23
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 06 Feb 2022 07:03:22 +0000

flight 168027 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168027/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 168018
 test-arm64-arm64-xl-vhd      17 guest-start/debian.repeat  fail pass in 168018

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168018
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168018
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168018
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168018
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168018
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168018
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168018
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168018
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168018
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168018
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168018
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168018
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 xen                  820cc393434097f3b7976acdccbf1d96071d6d23
baseline version:
 xen                  820cc393434097f3b7976acdccbf1d96071d6d23

Last test of basis   168027  2022-02-05 20:17:48 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Sun Feb 06 10:22:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 06 Feb 2022 10:22:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266256.459940 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGegR-00013U-Ij; Sun, 06 Feb 2022 10:22:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266256.459940; Sun, 06 Feb 2022 10:22:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGegR-00013N-FH; Sun, 06 Feb 2022 10:22:15 +0000
Received: by outflank-mailman (input) for mailman id 266256;
 Sun, 06 Feb 2022 10:22:14 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nGegQ-00013D-3y; Sun, 06 Feb 2022 10:22:14 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nGegQ-0004lk-2A; Sun, 06 Feb 2022 10:22:14 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nGegP-0005sQ-MT; Sun, 06 Feb 2022 10:22:13 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nGegP-0001Lg-LL; Sun, 06 Feb 2022 10:22:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=/L5hWDAUAGI4bTqGXS3L54nn3bl+biUKhE5J8w4Olho=; b=5brysufkif9FnAObnlNTeu8CVg
	ycMRb4uOgS33wCf/1L65M9JgWozn/qxq8ll/oaZ50HECFRkk88FatljeZxcupIzlEuNnBYu4VfZQh
	D3/Pq8J41zQwIDamRxYtDXwFNt0+m2nTQznC6phh6BHSWjPBR7pYo1AUSssLmgNbWyCk=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168033-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-coverity test] 168033: all pass - PUSHED
X-Osstest-Versions-This:
    xen=820cc393434097f3b7976acdccbf1d96071d6d23
X-Osstest-Versions-That:
    xen=9ce3ef20b4f085a7dc8ee41b0fec6fdeced3773e
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 06 Feb 2022 10:22:13 +0000

flight 168033 xen-unstable-coverity real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168033/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 xen                  820cc393434097f3b7976acdccbf1d96071d6d23
baseline version:
 xen                  9ce3ef20b4f085a7dc8ee41b0fec6fdeced3773e

Last test of basis   167984  2022-02-02 09:19:38 Z    4 days
Testing same since   168033  2022-02-06 09:19:52 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
  Jan Beulich <jbeulich@suse.com>
  Luca Fancellu <luca.fancellu@arm.com>
  Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Sergey Temerkhanov <s.temerkhanov@gmail.com>

jobs:
 coverity-amd64                                               pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   9ce3ef20b4..820cc39343  820cc393434097f3b7976acdccbf1d96071d6d23 -> coverity-tested/smoke


From xen-devel-bounces@lists.xenproject.org Sun Feb 06 10:44:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 06 Feb 2022 10:44:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266268.459951 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGf2A-0003PN-FH; Sun, 06 Feb 2022 10:44:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266268.459951; Sun, 06 Feb 2022 10:44:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGf2A-0003PG-Bl; Sun, 06 Feb 2022 10:44:42 +0000
Received: by outflank-mailman (input) for mailman id 266268;
 Sun, 06 Feb 2022 10:44:41 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nGf29-0003P6-KL; Sun, 06 Feb 2022 10:44:41 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nGf29-00056F-HI; Sun, 06 Feb 2022 10:44:41 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nGf28-000724-Vw; Sun, 06 Feb 2022 10:44:41 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nGf28-0005IX-VU; Sun, 06 Feb 2022 10:44:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=tLNRK6AN4iG1gZ7XjoVgLpSTTfDUbVQqkdGr7zIy0IE=; b=Mo9QiNBpxEALkTNTUlis3ksS6y
	hJgjC8/hASjsQxxRsOb94SBGRc/QsY3Ls+VZOmveWRsVALIYaXYloCXAWLM7bHE2Xm/HvVYZoCYgb
	so/ugpzB9yJZcJdCEORf4LSph98AXpntWuVyb81+G25BQJC4zfjPZ4zn7dngE56s713A=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168031-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 168031: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=e7be6be775e07cb373ff5d0bf933a36cd0b44f88
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 06 Feb 2022 10:44:40 +0000

flight 168031 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168031/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              e7be6be775e07cb373ff5d0bf933a36cd0b44f88
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  576 days
Failing since        151818  2020-07-11 04:18:52 Z  575 days  557 attempts
Testing same since   168031  2022-02-06 04:21:52 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brad Laue <brad@brad-x.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Christophe Fergeau <cfergeau@redhat.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Divya Garg <divya.garg@nutanix.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Emilio Herrera <ehespinosa57@gmail.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Ivan Teterevkov <ivan.teterevkov@nutanix.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Lubomir Rintel <lkundrak@v3.sk>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nicolas Lécureuil <neoclust@mageia.org>
  Nicolas Lécureuil <nicolas.lecureuil@siveo.net>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Rohit Kumar <rohit.kumar3@nutanix.com>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  shenjiatong <yshxxsjt715@gmail.com>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tuguoyi <tu.guoyi@h3c.com>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Vineeth Pillai <viremana@linux.microsoft.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yasuhiko Kamata <belphegor@belbel.or.jp>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 96470 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Feb 06 12:06:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 06 Feb 2022 12:06:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266282.459962 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGgIs-0002gu-FJ; Sun, 06 Feb 2022 12:06:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266282.459962; Sun, 06 Feb 2022 12:06:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGgIs-0002gn-AG; Sun, 06 Feb 2022 12:06:02 +0000
Received: by outflank-mailman (input) for mailman id 266282;
 Sun, 06 Feb 2022 12:06:01 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nGgIr-0002gd-3j; Sun, 06 Feb 2022 12:06:01 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nGgIq-0006QY-T7; Sun, 06 Feb 2022 12:06:00 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nGgIq-0002jA-Jc; Sun, 06 Feb 2022 12:06:00 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nGgIq-0002Q9-JB; Sun, 06 Feb 2022 12:06:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=6qVExG4DrvnNvKwv9wB9Tf6hiLjEbNA7S8Pw85153dk=; b=MSjWCdPS43LE1KoC9hJerlaRmN
	9F3+CL2IawbMRsI0C1+vVmfjuUhBUxL6OQU2aO8KjL9t67ciwSqMV3PV77hbTheqN6uhYP09m5z4f
	3OnvyWoF9E3cgZ/k41P4x2lMP6h1wp9BGXU0fy0/59Jeo5SWajWSuEaIzX/kG6625nMA=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168029-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 168029: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=90c9e950c0def5c354b4a6154a2ddda3e5f214ac
X-Osstest-Versions-That:
    linux=0457e5153e0e8420134f60921349099e907264ca
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 06 Feb 2022 12:06:00 +0000

flight 168029 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168029/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168022
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168022
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168022
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168022
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168022
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168022
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168022
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168022
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                90c9e950c0def5c354b4a6154a2ddda3e5f214ac
baseline version:
 linux                0457e5153e0e8420134f60921349099e907264ca

Last test of basis   168022  2022-02-05 05:38:07 Z    1 days
Testing same since   168029  2022-02-06 01:42:09 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Anup Patel <anup@brainfault.org>
  Anup Patel <apatel@ventanamicro.com>
  Christian Brauner <brauner@kernel.org>
  Darrick J. Wong <djwong@kernel.org>
  Dave Chinner <dchinner@redhat.com>
  Demi Marie Obenour <demiobenour@gmail.com>
  James Morse <james.morse@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Janosch Frank <frankja@linux.ibm.com>
  Jim Mattson <jmattson@google.com>
  Juergen Gross <jgross@suse.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Marc Zyngier <maz@kernel.org>
  Mark Rutland <mark.rutland@arm.com>
  Mayuresh Chitale <mchitale@ventanamicro.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Randy Dunlap <rdunlap@infradead.org>
  Roger Pau Monne <roger.pau@citrix.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Sean Christopherson <seanjc@google.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   0457e5153e0e8..90c9e950c0def  90c9e950c0def5c354b4a6154a2ddda3e5f214ac -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Sun Feb 06 16:54:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 06 Feb 2022 16:54:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266297.459972 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGknm-0004OO-Vp; Sun, 06 Feb 2022 16:54:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266297.459972; Sun, 06 Feb 2022 16:54:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGknm-0004OH-Sf; Sun, 06 Feb 2022 16:54:14 +0000
Received: by outflank-mailman (input) for mailman id 266297;
 Sun, 06 Feb 2022 16:54:13 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nGknl-0004O7-Ix; Sun, 06 Feb 2022 16:54:13 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nGknl-0003Fk-Es; Sun, 06 Feb 2022 16:54:13 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nGknk-0001wj-VW; Sun, 06 Feb 2022 16:54:13 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nGknk-0003gK-V2; Sun, 06 Feb 2022 16:54:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=61U9X2DEigDcooCrL/GiW6wsCQtPR7lTEESlRNdtPZs=; b=Yb9GaKqjhB4dn4GD8Yz12EBSw+
	r8FFxA4aLiO3MUh6zceY1ZjveE1MAq3K6uHfGJVXnbi1cFBLKOUWagceJqXdPR2fS4VVOi2u+PLnv
	NiWUeA8a3gkklTCovTnv8Kr2wJHfd9lMkf33+6hHnsUIGabb+iHge3EcTcLBXvzKx6TQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168032-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 168032: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-unstable:test-arm64-arm64-xl-vhd:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=820cc393434097f3b7976acdccbf1d96071d6d23
X-Osstest-Versions-That:
    xen=820cc393434097f3b7976acdccbf1d96071d6d23
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 06 Feb 2022 16:54:12 +0000

flight 168032 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168032/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 168027 pass in 168032
 test-arm64-arm64-xl-vhd 17 guest-start/debian.repeat fail in 168027 pass in 168032
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 168027

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168027
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168027
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168027
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168027
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168027
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168027
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168027
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168027
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168027
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168027
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168027
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168027
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 xen                  820cc393434097f3b7976acdccbf1d96071d6d23
baseline version:
 xen                  820cc393434097f3b7976acdccbf1d96071d6d23

Last test of basis   168032  2022-02-06 07:05:35 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Sun Feb 06 19:28:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 06 Feb 2022 19:28:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266313.459984 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGnDJ-0001XN-7A; Sun, 06 Feb 2022 19:28:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266313.459984; Sun, 06 Feb 2022 19:28:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGnDJ-0001XG-4B; Sun, 06 Feb 2022 19:28:45 +0000
Received: by outflank-mailman (input) for mailman id 266313;
 Sun, 06 Feb 2022 19:28:44 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nGnDI-0001XA-6a
 for xen-devel@lists.xenproject.org; Sun, 06 Feb 2022 19:28:44 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nGnDH-0005se-Ah; Sun, 06 Feb 2022 19:28:43 +0000
Received: from 54-240-197-224.amazon.com ([54.240.197.224]
 helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com)
 by xenbits.xenproject.org with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nGnDH-0007Ok-0w; Sun, 06 Feb 2022 19:28:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:
	Subject:Cc:To:From; bh=/H8pFttg2YhVccQhF2eKBXnyu08W1Blzbzg94oHYGZE=; b=dbLT13
	zvRYgytuSSGw4njvzoHeMF/vCt94opKMqDIv7vQRnoyzFjoLnFs5tAi0Tft2nHej37TrN3sSkTd0H
	eU/0M5caSh5IwP1xBl8yJU3gDAOABBZTOcFJqCpmCRG6OYHaVKvzsyBmWoaAruCGOTUX2MUQaN5+K
	zbXefrgKI0Y=;
From: Julien Grall <julien@xen.org>
To: xen-devel@lists.xenproject.org
Cc: ehem+xen@m5p.com,
	Julien Grall <jgrall@amazon.com>,
	Jan Beulich <jbeulich@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Wei Liu <wl@xen.org>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>
Subject: [PATCH RFC 0/3] xen/arm: Allow dom0 to use the EFI framebuffer
Date: Sun,  6 Feb 2022 19:28:36 +0000
Message-Id: <20220206192839.75711-1-julien@xen.org>
X-Mailer: git-send-email 2.32.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Julien Grall <jgrall@amazon.com>

Hi all,

This is a follow-up of the discussion [1].

When booting using EFI on Raspberry Pi 4, the graphical output will
be using the EFI framebuffer.

On baremetal, the information for the graphic output is retrieved
using the boot services. However, under Xen, dom0 has no access
to the EFI boot services. So we need to a different way to inform Dom0.

For x86 PV dom0, this is using the start_info. On Arm we have no such
thing, so this patch will introduce a new hypercall. This will
require a change in Linux [2] (Based on the 5.17-rc2) to issue the
hypercall and fill-up screen info.

I will properly send the Linux patch once we agree on the interface
between Xen and dom0.

With this series + Linux, I am able to use XFCE in dom0 on the
RPi 4 when booting using UEFI + ACPI.

Looking through the dmesg, there are still a few TODOs to handle:
    - Linux is not able to use the BGRT (Invalid address). This is
      because the driver checks the Image address is part of the UEFI
      Boot Services Area. Such area is not exposed to dom0 (yet).
      By-passing the check doesn't much help because all the EFI Boot
      Services area are given to the normal allocator. So we would
      need to reserve them.
    - The Wifi driver is crashing because it is dereferencing a NULL
      pointer (only seem to happen on Xen).
    - There are error messages of drivers trying to access the EFI
      runtime services (e.g. to fetch firmware for a device) but fails.
      This is expected as Xen doesn't yet expose the EFI runtimes
      services yet.

/!\ This has only been tested on Arm. I will sanity test x86 for the
next version.

Cheers,

[1] https://lore.kernel.org/xen-devel/YY3tSAFTCR4r2FaI@mattapan.m5p.com/
[2] https://pastebin.com/ztUm9Bf3

Julien Grall (3):
  xen/efi: Always query the console information and get GOP
  xen/arm: efi: Introduce and fill the vga_console_info
  xen: Introduce a platform sub-op to retrieve the VGA information

 xen/arch/arm/efi/efi-boot.h       |  6 --
 xen/arch/arm/platform_hypercall.c | 15 +++++
 xen/arch/arm/setup.c              |  4 ++
 xen/arch/x86/efi/efi-boot.h       | 72 -----------------------
 xen/common/efi/boot.c             | 96 +++++++++++++++++++++++++++----
 xen/include/public/platform.h     |  2 +
 xen/include/xen/vga.h             |  2 +-
 7 files changed, 106 insertions(+), 91 deletions(-)

-- 
2.32.0



From xen-devel-bounces@lists.xenproject.org Sun Feb 06 19:28:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 06 Feb 2022 19:28:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266315.460006 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGnDN-00023b-Mu; Sun, 06 Feb 2022 19:28:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266315.460006; Sun, 06 Feb 2022 19:28:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGnDN-00023R-Iu; Sun, 06 Feb 2022 19:28:49 +0000
Received: by outflank-mailman (input) for mailman id 266315;
 Sun, 06 Feb 2022 19:28:47 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nGnDL-00022Q-QV
 for xen-devel@lists.xenproject.org; Sun, 06 Feb 2022 19:28:47 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nGnDK-0005sy-RB; Sun, 06 Feb 2022 19:28:46 +0000
Received: from 54-240-197-224.amazon.com ([54.240.197.224]
 helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com)
 by xenbits.xenproject.org with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nGnDK-0007Ok-FF; Sun, 06 Feb 2022 19:28:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References:
	In-Reply-To:Message-Id:Date:Subject:Cc:To:From;
	bh=At0G3eg7j5P+J2/OwNksy7nZbwWKktpJk5zKue+aCUs=; b=ubR3d92i9BDoPIkoIXp2mhYIb+
	OBGSxCNFxlOWArOHyLQStiLI8orDDJLe7W6wH2VaGjZTPh+GKndo7thAHa/ONpx42PpiFkxPfRzHM
	QPKZ8bfPIEYszy/WgqPggHewJbd7npapB6sb9Pqprmztr/xL2FLSohFz8x5NyRaTfsjI=;
From: Julien Grall <julien@xen.org>
To: xen-devel@lists.xenproject.org
Cc: ehem+xen@m5p.com,
	Julien Grall <jgrall@amazon.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Wei Liu <wl@xen.org>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>
Subject: [PATCH RFC 2/3] xen/arm: efi: Introduce and fill the vga_console_info
Date: Sun,  6 Feb 2022 19:28:38 +0000
Message-Id: <20220206192839.75711-3-julien@xen.org>
X-Mailer: git-send-email 2.32.0
In-Reply-To: <20220206192839.75711-1-julien@xen.org>
References: <20220206192839.75711-1-julien@xen.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Julien Grall <jgrall@amazon.com>

In a follow-up patch will we want to add support for EFI framebuffer
in dom0. Yet, Xen may not use the framebuffer, so it would be ideal
to not have to enable CONFIG_VIDEO/CONFIG_VGA.

Introduce vga_console_info in a hacky way and move the code
to fill it up from x86 to common.

Signed-off-by: Julien Grall <jgrall@amazon.com>

----

This is a bit of a hack. Sent early to gather opinion on whether
we should enable allow Dom0 to use the EFI Framebuffer even
if Xen is built with CONFIG_VIDEO=n on Arm.
---
 xen/arch/arm/efi/efi-boot.h |  6 ---
 xen/arch/arm/setup.c        |  4 ++
 xen/arch/x86/efi/efi-boot.h | 72 ------------------------------------
 xen/common/efi/boot.c       | 74 ++++++++++++++++++++++++++++++++++++-
 xen/include/xen/vga.h       |  2 +-
 5 files changed, 78 insertions(+), 80 deletions(-)

diff --git a/xen/arch/arm/efi/efi-boot.h b/xen/arch/arm/efi/efi-boot.h
index ae8627134e5a..17a3d46c59ae 100644
--- a/xen/arch/arm/efi/efi-boot.h
+++ b/xen/arch/arm/efi/efi-boot.h
@@ -1000,12 +1000,6 @@ static void __init efi_arch_console_init(UINTN cols, UINTN rows)
 {
 }
 
-static void __init efi_arch_video_init(EFI_GRAPHICS_OUTPUT_PROTOCOL *gop,
-                                       UINTN info_size,
-                                       EFI_GRAPHICS_OUTPUT_MODE_INFORMATION *mode_info)
-{
-}
-
 static void __init efi_arch_flush_dcache_area(const void *vaddr, UINTN size)
 {
     __flush_dcache_area(vaddr, size);
diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
index d5d0792ed48a..a336ee58179c 100644
--- a/xen/arch/arm/setup.c
+++ b/xen/arch/arm/setup.c
@@ -71,6 +71,10 @@ static unsigned long opt_xenheap_megabytes __initdata;
 integer_param("xenheap_megabytes", opt_xenheap_megabytes);
 #endif
 
+#ifndef CONFIG_VIDEO
+struct xen_vga_console_info vga_console_info;
+#endif
+
 domid_t __read_mostly max_init_domid;
 
 static __used void init_done(void)
diff --git a/xen/arch/x86/efi/efi-boot.h b/xen/arch/x86/efi/efi-boot.h
index f69509a2103a..cba3fa75a475 100644
--- a/xen/arch/x86/efi/efi-boot.h
+++ b/xen/arch/x86/efi/efi-boot.h
@@ -3,7 +3,6 @@
  * is intended to be included by common/efi/boot.c _only_, and
  * therefore can define arch specific global variables.
  */
-#include <xen/vga.h>
 #include <asm/e820.h>
 #include <asm/edd.h>
 #include <asm/microcode.h>
@@ -497,77 +496,6 @@ static void __init efi_arch_console_init(UINTN cols, UINTN rows)
 #endif
 }
 
-static void __init efi_arch_video_init(EFI_GRAPHICS_OUTPUT_PROTOCOL *gop,
-                                       UINTN info_size,
-                                       EFI_GRAPHICS_OUTPUT_MODE_INFORMATION *mode_info)
-{
-#ifdef CONFIG_VIDEO
-    int bpp = 0;
-
-    switch ( mode_info->PixelFormat )
-    {
-    case PixelRedGreenBlueReserved8BitPerColor:
-        vga_console_info.u.vesa_lfb.red_pos = 0;
-        vga_console_info.u.vesa_lfb.red_size = 8;
-        vga_console_info.u.vesa_lfb.green_pos = 8;
-        vga_console_info.u.vesa_lfb.green_size = 8;
-        vga_console_info.u.vesa_lfb.blue_pos = 16;
-        vga_console_info.u.vesa_lfb.blue_size = 8;
-        vga_console_info.u.vesa_lfb.rsvd_pos = 24;
-        vga_console_info.u.vesa_lfb.rsvd_size = 8;
-        bpp = 32;
-        break;
-    case PixelBlueGreenRedReserved8BitPerColor:
-        vga_console_info.u.vesa_lfb.red_pos = 16;
-        vga_console_info.u.vesa_lfb.red_size = 8;
-        vga_console_info.u.vesa_lfb.green_pos = 8;
-        vga_console_info.u.vesa_lfb.green_size = 8;
-        vga_console_info.u.vesa_lfb.blue_pos = 0;
-        vga_console_info.u.vesa_lfb.blue_size = 8;
-        vga_console_info.u.vesa_lfb.rsvd_pos = 24;
-        vga_console_info.u.vesa_lfb.rsvd_size = 8;
-        bpp = 32;
-        break;
-    case PixelBitMask:
-        bpp = set_color(mode_info->PixelInformation.RedMask, bpp,
-                        &vga_console_info.u.vesa_lfb.red_pos,
-                        &vga_console_info.u.vesa_lfb.red_size);
-        bpp = set_color(mode_info->PixelInformation.GreenMask, bpp,
-                        &vga_console_info.u.vesa_lfb.green_pos,
-                        &vga_console_info.u.vesa_lfb.green_size);
-        bpp = set_color(mode_info->PixelInformation.BlueMask, bpp,
-                        &vga_console_info.u.vesa_lfb.blue_pos,
-                        &vga_console_info.u.vesa_lfb.blue_size);
-        if ( mode_info->PixelInformation.ReservedMask )
-            bpp = set_color(mode_info->PixelInformation.ReservedMask, bpp,
-                            &vga_console_info.u.vesa_lfb.rsvd_pos,
-                            &vga_console_info.u.vesa_lfb.rsvd_size);
-        if ( bpp > 0 )
-            break;
-        /* fall through */
-    default:
-        PrintErr(L"Current graphics mode is unsupported!\r\n");
-        bpp  = 0;
-        break;
-    }
-    if ( bpp > 0 )
-    {
-        vga_console_info.video_type = XEN_VGATYPE_EFI_LFB;
-        vga_console_info.u.vesa_lfb.gbl_caps = 2; /* possibly non-VGA */
-        vga_console_info.u.vesa_lfb.width =
-            mode_info->HorizontalResolution;
-        vga_console_info.u.vesa_lfb.height = mode_info->VerticalResolution;
-        vga_console_info.u.vesa_lfb.bits_per_pixel = bpp;
-        vga_console_info.u.vesa_lfb.bytes_per_line =
-            (mode_info->PixelsPerScanLine * bpp + 7) >> 3;
-        vga_console_info.u.vesa_lfb.lfb_base = gop->Mode->FrameBufferBase;
-        vga_console_info.u.vesa_lfb.ext_lfb_base = gop->Mode->FrameBufferBase >> 32;
-        vga_console_info.u.vesa_lfb.lfb_size =
-            (gop->Mode->FrameBufferSize + 0xffff) >> 16;
-    }
-#endif
-}
-
 static void __init efi_arch_memory_setup(void)
 {
     unsigned int i;
diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c
index 80e4e32623c4..2bc38ae40fff 100644
--- a/xen/common/efi/boot.c
+++ b/xen/common/efi/boot.c
@@ -20,6 +20,7 @@
 #endif
 #include <xen/string.h>
 #include <xen/stringify.h>
+#include <xen/vga.h>
 #ifdef CONFIG_X86
 /*
  * Keep this arch-specific modified include in the common file, as moving
@@ -1025,6 +1026,77 @@ static void __init efi_get_apple_properties(void)
     }
 }
 
+static void __init efi_video_init(EFI_GRAPHICS_OUTPUT_PROTOCOL *gop,
+                                  UINTN info_size,
+                                  EFI_GRAPHICS_OUTPUT_MODE_INFORMATION *mode_info)
+{
+#if defined(CONFIG_VIDEO) || defined(CONFIG_ARM)
+    int bpp = 0;
+
+    switch ( mode_info->PixelFormat )
+    {
+    case PixelRedGreenBlueReserved8BitPerColor:
+        vga_console_info.u.vesa_lfb.red_pos = 0;
+        vga_console_info.u.vesa_lfb.red_size = 8;
+        vga_console_info.u.vesa_lfb.green_pos = 8;
+        vga_console_info.u.vesa_lfb.green_size = 8;
+        vga_console_info.u.vesa_lfb.blue_pos = 16;
+        vga_console_info.u.vesa_lfb.blue_size = 8;
+        vga_console_info.u.vesa_lfb.rsvd_pos = 24;
+        vga_console_info.u.vesa_lfb.rsvd_size = 8;
+        bpp = 32;
+        break;
+    case PixelBlueGreenRedReserved8BitPerColor:
+        vga_console_info.u.vesa_lfb.red_pos = 16;
+        vga_console_info.u.vesa_lfb.red_size = 8;
+        vga_console_info.u.vesa_lfb.green_pos = 8;
+        vga_console_info.u.vesa_lfb.green_size = 8;
+        vga_console_info.u.vesa_lfb.blue_pos = 0;
+        vga_console_info.u.vesa_lfb.blue_size = 8;
+        vga_console_info.u.vesa_lfb.rsvd_pos = 24;
+        vga_console_info.u.vesa_lfb.rsvd_size = 8;
+        bpp = 32;
+        break;
+    case PixelBitMask:
+        bpp = set_color(mode_info->PixelInformation.RedMask, bpp,
+                        &vga_console_info.u.vesa_lfb.red_pos,
+                        &vga_console_info.u.vesa_lfb.red_size);
+        bpp = set_color(mode_info->PixelInformation.GreenMask, bpp,
+                        &vga_console_info.u.vesa_lfb.green_pos,
+                        &vga_console_info.u.vesa_lfb.green_size);
+        bpp = set_color(mode_info->PixelInformation.BlueMask, bpp,
+                        &vga_console_info.u.vesa_lfb.blue_pos,
+                        &vga_console_info.u.vesa_lfb.blue_size);
+        if ( mode_info->PixelInformation.ReservedMask )
+            bpp = set_color(mode_info->PixelInformation.ReservedMask, bpp,
+                            &vga_console_info.u.vesa_lfb.rsvd_pos,
+                            &vga_console_info.u.vesa_lfb.rsvd_size);
+        if ( bpp > 0 )
+            break;
+        /* fall through */
+    default:
+        PrintErr(L"Current graphics mode is unsupported!\r\n");
+        bpp  = 0;
+        break;
+    }
+    if ( bpp > 0 )
+    {
+        vga_console_info.video_type = XEN_VGATYPE_EFI_LFB;
+        vga_console_info.u.vesa_lfb.gbl_caps = 2; /* possibly non-VGA */
+        vga_console_info.u.vesa_lfb.width =
+            mode_info->HorizontalResolution;
+        vga_console_info.u.vesa_lfb.height = mode_info->VerticalResolution;
+        vga_console_info.u.vesa_lfb.bits_per_pixel = bpp;
+        vga_console_info.u.vesa_lfb.bytes_per_line =
+            (mode_info->PixelsPerScanLine * bpp + 7) >> 3;
+        vga_console_info.u.vesa_lfb.lfb_base = gop->Mode->FrameBufferBase;
+        vga_console_info.u.vesa_lfb.ext_lfb_base = gop->Mode->FrameBufferBase >> 32;
+        vga_console_info.u.vesa_lfb.lfb_size =
+            (gop->Mode->FrameBufferSize + 0xffff) >> 16;
+    }
+#endif
+}
+
 static void __init efi_set_gop_mode(EFI_GRAPHICS_OUTPUT_PROTOCOL *gop, UINTN gop_mode)
 {
     EFI_GRAPHICS_OUTPUT_MODE_INFORMATION *mode_info;
@@ -1042,7 +1114,7 @@ static void __init efi_set_gop_mode(EFI_GRAPHICS_OUTPUT_PROTOCOL *gop, UINTN gop
     /* Get graphics and frame buffer info. */
     status = gop->QueryMode(gop, gop->Mode->Mode, &info_size, &mode_info);
     if ( !EFI_ERROR(status) )
-        efi_arch_video_init(gop, info_size, mode_info);
+        efi_video_init(gop, info_size, mode_info);
 }
 
 #define INVALID_VIRTUAL_ADDRESS (0xBAAADUL << \
diff --git a/xen/include/xen/vga.h b/xen/include/xen/vga.h
index f72b63d446b1..39b4c2eae198 100644
--- a/xen/include/xen/vga.h
+++ b/xen/include/xen/vga.h
@@ -11,7 +11,7 @@
 
 #include <xen/video.h>
 
-#ifdef CONFIG_VGA
+#if defined(CONFIG_VGA) || defined(CONFIG_ARM)
 extern struct xen_vga_console_info vga_console_info;
 #endif
 
-- 
2.32.0



From xen-devel-bounces@lists.xenproject.org Sun Feb 06 19:28:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 06 Feb 2022 19:28:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266314.459994 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGnDK-0001mv-Em; Sun, 06 Feb 2022 19:28:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266314.459994; Sun, 06 Feb 2022 19:28:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGnDK-0001mo-Bo; Sun, 06 Feb 2022 19:28:46 +0000
Received: by outflank-mailman (input) for mailman id 266314;
 Sun, 06 Feb 2022 19:28:45 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nGnDJ-0001Yz-9u
 for xen-devel@lists.xenproject.org; Sun, 06 Feb 2022 19:28:45 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nGnDJ-0005sk-2e; Sun, 06 Feb 2022 19:28:45 +0000
Received: from 54-240-197-224.amazon.com ([54.240.197.224]
 helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com)
 by xenbits.xenproject.org with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nGnDI-0007Ok-Pk; Sun, 06 Feb 2022 19:28:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References:
	In-Reply-To:Message-Id:Date:Subject:Cc:To:From;
	bh=afEtY43khqyixlLlQcgO+P5/SZzjDhtwscVQfHzNp6w=; b=3VtDXi3lemG7IAYf+DmdTdw7XG
	49nHZrGfVfH6KIvICROvXnt8LH95v6Sej6Sy7FnViBrQXDiaJJb1l+o+QRrc1ldMXYFjpYQAv1eYJ
	X3NDNAzLRWK5CGxby0CF8bXGWhzQaeQ333HMRgF785hVqYEJTA4e9biey1Mb5SmPPmyI=;
From: Julien Grall <julien@xen.org>
To: xen-devel@lists.xenproject.org
Cc: ehem+xen@m5p.com,
	Julien Grall <jgrall@amazon.com>,
	Jan Beulich <jbeulich@suse.com>
Subject: [PATCH RFC 1/3] xen/efi: Always query the console information and get GOP
Date: Sun,  6 Feb 2022 19:28:37 +0000
Message-Id: <20220206192839.75711-2-julien@xen.org>
X-Mailer: git-send-email 2.32.0
In-Reply-To: <20220206192839.75711-1-julien@xen.org>
References: <20220206192839.75711-1-julien@xen.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Julien Grall <jgrall@amazon.com>

Currently, the EFI stub will only query the console information and
get the GOP when using the configuration file.

However, GRUB is never providing the a configuration file. So the
EFI framebuffer will not be usable at least on Arm (support will
be added in a follow-up patch).

Move out the code outside of the configuration file section.

Take the opportunity to remove the variable 'size' which was
set but never used (interestingly GCC is only complaining if it is
initialization when declaring the variable).

With this change, GCC 8.3 will complain of argc potentially been
used unitiatlized. I suspect this is because the argc will
be iniitalized and used in a different if code-blocks. Yet they
are using the same check.

Signed-off-by: Julien Grall <jgrall@amazon.com>

----

It is not entirely clear to me why the GOP was only fetched when
the configuration file is used.

I have tested this on RPI4 and it seems to work. Any chance this
was done to workaround an x86 platform?
---
 xen/common/efi/boot.c | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c
index 12fd0844bd55..80e4e32623c4 100644
--- a/xen/common/efi/boot.c
+++ b/xen/common/efi/boot.c
@@ -1129,9 +1129,11 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable)
     static EFI_GUID __initdata shim_lock_guid = SHIM_LOCK_PROTOCOL_GUID;
     EFI_LOADED_IMAGE *loaded_image;
     EFI_STATUS status;
-    unsigned int i, argc;
+    /* Initialize argc to stop GCC complaining */
+    unsigned int i, argc = 0;
     CHAR16 **argv, *file_name, *cfg_file_name = NULL, *options = NULL;
-    UINTN gop_mode = ~0;
+    UINTN gop_mode = ~0, cols = 0, rows = 0;
+
     EFI_SHIM_LOCK_PROTOCOL *shim_lock;
     EFI_GRAPHICS_OUTPUT_PROTOCOL *gop = NULL;
     union string section = { NULL }, name;
@@ -1219,18 +1221,16 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable)
 
     efi_arch_relocate_image(0);
 
+    if ( StdOut->QueryMode(StdOut, StdOut->Mode->Mode,
+                           &cols, &rows) == EFI_SUCCESS )
+        efi_arch_console_init(cols, rows);
+
+    gop = efi_get_gop();
+
     if ( use_cfg_file )
     {
         EFI_FILE_HANDLE dir_handle;
-        UINTN depth, cols, rows, size;
-
-        size = cols = rows = depth = 0;
-
-        if ( StdOut->QueryMode(StdOut, StdOut->Mode->Mode,
-                               &cols, &rows) == EFI_SUCCESS )
-            efi_arch_console_init(cols, rows);
-
-        gop = efi_get_gop();
+        UINTN depth = 0;
 
         /* Get the file system interface. */
         dir_handle = get_parent_handle(loaded_image, &file_name);
-- 
2.32.0



From xen-devel-bounces@lists.xenproject.org Sun Feb 06 19:28:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 06 Feb 2022 19:28:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266316.460017 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGnDP-0002Lo-V2; Sun, 06 Feb 2022 19:28:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266316.460017; Sun, 06 Feb 2022 19:28:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGnDP-0002Lf-Qg; Sun, 06 Feb 2022 19:28:51 +0000
Received: by outflank-mailman (input) for mailman id 266316;
 Sun, 06 Feb 2022 19:28:50 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nGnDO-0002J7-OM
 for xen-devel@lists.xenproject.org; Sun, 06 Feb 2022 19:28:50 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nGnDM-0005t8-Ch; Sun, 06 Feb 2022 19:28:48 +0000
Received: from 54-240-197-224.amazon.com ([54.240.197.224]
 helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com)
 by xenbits.xenproject.org with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nGnDM-0007Ok-4h; Sun, 06 Feb 2022 19:28:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References:
	In-Reply-To:Message-Id:Date:Subject:Cc:To:From;
	bh=dwa+CM0UGV4Uyu3tQxS0S6kaMZiyK2FzF7bR+EHTABc=; b=ppyd+fukvMObK1Y2M4+VtmDg6w
	3E8oAypWDgoe7HSHp252yR2ftQtXhjHOYNlRTy4MoqwvT51uHuVZLl9dB/ukzZCJH1NS+SvloMmQd
	Ptj9JPP1BFMPwyEdx/+W+vz5LmL8AvDtspb/bndh37q80j1sTFckn+2CWLZiMNoCFwdU=;
From: Julien Grall <julien@xen.org>
To: xen-devel@lists.xenproject.org
Cc: ehem+xen@m5p.com,
	Julien Grall <jgrall@amazon.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Wei Liu <wl@xen.org>
Subject: [PATCH RFC 3/3] xen: Introduce a platform sub-op to retrieve the VGA information
Date: Sun,  6 Feb 2022 19:28:39 +0000
Message-Id: <20220206192839.75711-4-julien@xen.org>
X-Mailer: git-send-email 2.32.0
In-Reply-To: <20220206192839.75711-1-julien@xen.org>
References: <20220206192839.75711-1-julien@xen.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Julien Grall <jgrall@amazon.com>

When using EFI, the VGA information is fetched using the EFI
boot services. However, Xen will have exited the boot services.
Therefore, we need to find a different way to pass the information
to dom0.

For PV dom0, they are part of the start_info. But this is not
something that exists on Arm. So the best way would to be to
use a hypercall.

For now the structure layout is based on dom0_vga_console_info
for convenience. I am open on another proposal.

Signed-off-by: Julien Grall <jgrall@amazon.com>

----

TODO:
    - Check the structure size has not changed (I would like to
      avoid bumping the platform interface).
---
 xen/arch/arm/platform_hypercall.c | 15 +++++++++++++++
 xen/include/public/platform.h     |  2 ++
 2 files changed, 17 insertions(+)

diff --git a/xen/arch/arm/platform_hypercall.c b/xen/arch/arm/platform_hypercall.c
index 8efac7ee602a..78ad328e2ab8 100644
--- a/xen/arch/arm/platform_hypercall.c
+++ b/xen/arch/arm/platform_hypercall.c
@@ -10,6 +10,7 @@
 #include <xen/sched.h>
 #include <xen/guest_access.h>
 #include <xen/spinlock.h>
+#include <xen/vga.h>
 #include <public/platform.h>
 #include <xsm/xsm.h>
 #include <asm/current.h>
@@ -58,6 +59,20 @@ long do_platform_op(XEN_GUEST_HANDLE_PARAM(xen_platform_op_t) u_xenpf_op)
             ret = -EINVAL;
         break;
 
+    case XENPF_firmware_info:
+        switch ( op->u.firmware_info.type )
+        {
+        case XEN_FW_VGA_INFO:
+            BUILD_BUG_ON(sizeof(op->u.firmware_info.u.vga) !=
+                         sizeof(vga_console_info));
+            memcpy(&op->u.firmware_info.u.vga, &vga_console_info,
+                   sizeof(vga_console_info));
+            if ( __copy_to_guest(u_xenpf_op, op, 1) )
+                ret = -EFAULT;
+            break;
+        }
+        break;
+
     default:
         ret = -ENOSYS;
         break;
diff --git a/xen/include/public/platform.h b/xen/include/public/platform.h
index a4c0eb62249a..4de42ce6cbc5 100644
--- a/xen/include/public/platform.h
+++ b/xen/include/public/platform.h
@@ -244,6 +244,7 @@ DEFINE_XEN_GUEST_HANDLE(xenpf_efi_runtime_call_t);
 #define  XEN_FW_EFI_PCI_ROM        5
 #define  XEN_FW_EFI_APPLE_PROPERTIES 6
 #define XEN_FW_KBD_SHIFT_FLAGS    5
+#define XEN_FW_VGA_INFO           6
 struct xenpf_firmware_info {
     /* IN variables. */
     uint32_t type;
@@ -311,6 +312,7 @@ struct xenpf_firmware_info {
 
         /* Int16, Fn02: Get keyboard shift flags. */
         uint8_t kbd_shift_flags; /* XEN_FW_KBD_SHIFT_FLAGS */
+        struct dom0_vga_console_info vga;
     } u;
 };
 typedef struct xenpf_firmware_info xenpf_firmware_info_t;
-- 
2.32.0



From xen-devel-bounces@lists.xenproject.org Sun Feb 06 19:34:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 06 Feb 2022 19:34:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266345.460028 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGnIh-0004fg-Fv; Sun, 06 Feb 2022 19:34:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266345.460028; Sun, 06 Feb 2022 19:34:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGnIh-0004fZ-Cf; Sun, 06 Feb 2022 19:34:19 +0000
Received: by outflank-mailman (input) for mailman id 266345;
 Sun, 06 Feb 2022 19:34:18 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nGnIg-0004fT-S4
 for xen-devel@lists.xenproject.org; Sun, 06 Feb 2022 19:34:18 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nGnIg-00060A-Ac; Sun, 06 Feb 2022 19:34:18 +0000
Received: from 54-240-197-231.amazon.com ([54.240.197.231] helo=[10.95.100.36])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nGnIg-0007vw-4Q; Sun, 06 Feb 2022 19:34:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=81bRU4yUN6Mj75pzfVwhkQvRSIUMqjMBT5hMJ6SyBCY=; b=F20uP6BhSo750S/vszhyV0NSz7
	YBkT4710r0MmZWpPbWyuxgbBDldk/GN2QiKonrkx55aANcTAoz2PF+c9G1+Pl1B8z6mcNA41rGux9
	jeQnUuie3EwfoOheEWDjb4sVGUvHYpwv0DtklxYlxrA2jAvJ7FN2gqR/qzSl2Mn9rfyM=;
Message-ID: <4fec5e75-95da-4dc5-ebea-c53c10486a11@xen.org>
Date: Sun, 6 Feb 2022 19:34:16 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.1
Subject: Re: [PATCH v2] docs: document patch rules
To: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
References: <20220203125438.21807-1-jgross@suse.com>
 <e91bde3e-dc45-c731-7df6-e0e45039d1b2@xen.org>
 <ce764d2a-7368-6fbc-b44b-5c56f876d4d4@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <ce764d2a-7368-6fbc-b44b-5c56f876d4d4@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi,

On 05/02/2022 11:13, Juergen Gross wrote:
> On 04.02.22 20:25, Julien Grall wrote:
>> Hi,
>>
>> On 03/02/2022 12:54, Juergen Gross wrote:
>>> +## The commit message
>>> +
>>> +The commit message is free text describing *why* the patch is done and
>>> +*how* the goal of the patch is achieved. A good commit message will 
>>> describe
>>> +the current situation, the desired goal, and the way this goal is being
>>> +achieved. Parts of that can be omitted in obvious cases.
>>> +
>>> +In case additional changes are done in the patch (like e.g. 
>>> cleanups), those
>>> +should be mentioned.
>>> +
>>> +When referencing other patches (e.g. `similar to patch xy ...`) those
>>> +patches should be referenced via their commit id (at least 12 digits)
>>> +and the patch subject, if the very same patch isn't referenced by the
>>> +`Fixes:` tag, too:
>>> +
>>> +    Similar to commit 67d01cdb5518 ("x86: infrastructure to allow 
>>> converting
>>> +    certain indirect calls to direct ones") add ...
>>> +
>>> +The following ``git config`` settings can be used to add a pretty 
>>> format for
>>> +outputting the above style in the ``git log`` or ``git show`` commands:
>>> +
>>> +        [core]
>>> +                abbrev = 12
>>> +        [pretty]
>>> +                fixes = Fixes: %h (\"%s\")
>>> +
>>> +Lines in the commit message should not exceed 75 characters, except 
>>> when
>>
>> I was under the impression that commit message should be wrap to 72 
>> characters. This is because tools like "git log" would indent the 
>> commit message by 8 characters.
> 
> I took that value from the docs/process/tags.pandoc file.

I also checked Linux documentation and they ask to wrap to 75 characters 
as well. Not sure where I got the 72 characters from...

There rest of my comments are NITs so:

Reviewed-by: Julien Grall <jgrall@amazon.com>

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Sun Feb 06 19:40:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 06 Feb 2022 19:40:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266354.460038 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGnOb-00069N-8k; Sun, 06 Feb 2022 19:40:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266354.460038; Sun, 06 Feb 2022 19:40:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGnOb-00069G-5c; Sun, 06 Feb 2022 19:40:25 +0000
Received: by outflank-mailman (input) for mailman id 266354;
 Sun, 06 Feb 2022 19:40:24 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nGnOa-00069A-A5
 for xen-devel@lists.xenproject.org; Sun, 06 Feb 2022 19:40:24 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nGnOY-000667-Nd; Sun, 06 Feb 2022 19:40:22 +0000
Received: from 54-240-197-231.amazon.com ([54.240.197.231] helo=[10.95.100.36])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nGnOY-0008R6-H9; Sun, 06 Feb 2022 19:40:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=INA/C+kES4Jq6I2wN0+I8BSOO6aAG413dNpma96PzfE=; b=ByyK/SfhJ0cpXxoIX46AIGYBM5
	FtBef8iWoKba8MjGwKFvMHvCVikCfSxVBBQDqj9Y8VbT5ujH1H9vBb2lF8nTWD06eboC94HFZqnJ+
	NDRczi+NVu38X98InQ4abEfRjCY3MNne/W9YRxUB8mUvWivdtk8dj1dV1E9FOxx+y9H8=;
Message-ID: <9a67c97c-0c61-ecee-067a-f1bdd0280b8b@xen.org>
Date: Sun, 6 Feb 2022 19:40:20 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.1
Subject: Re: [PATCH] xen/smp: Speed up on_selected_cpus()
To: Andrew Cooper <andrew.cooper3@citrix.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
Cc: Jan Beulich <JBeulich@suse.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Wei Liu <wl@xen.org>, Juergen Gross
 <jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <20220204203115.13290-1-andrew.cooper3@citrix.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220204203115.13290-1-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi,

On 04/02/2022 20:31, Andrew Cooper wrote:
> cpumask_weight() is a horribly expensive way to find if no bits are set, made
> worse by the fact that the calculation is performed with the global call_lock
> held.

I looked at the archive because I was wondering why we were using 
cpumask_weight here. It looks like this was a left-over of the rework in 
ac3fc35d919c "x86: Fix flush_area_mask() and on_selected_cpus() to not 
race updates".

> 
> Switch to using cpumask_empty() instead, which will short circuit as soon as
> it find any set bit in the cpumask.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Reviewed-by: Julien Grall <jgrall@amazon.com>

> ---
> CC: Jan Beulich <JBeulich@suse.com>
> CC: Roger Pau Monné <roger.pau@citrix.com>
> CC: Wei Liu <wl@xen.org>
> CC: Juergen Gross <jgross@suse.com>
> CC: Stefano Stabellini <sstabellini@kernel.org>
> CC: Julien Grall <julien@xen.org>
> CC: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
> CC: Bertrand Marquis <bertrand.marquis@arm.com>
> 
> I have not done performance testing, but I would be surprised if this cannot
> be measured on a busy or large box.
> ---
>   xen/common/smp.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/xen/common/smp.c b/xen/common/smp.c
> index 781bcf2c246c..a011f541f1ea 100644
> --- a/xen/common/smp.c
> +++ b/xen/common/smp.c
> @@ -50,8 +50,6 @@ void on_selected_cpus(
>       void *info,
>       int wait)
>   {
> -    unsigned int nr_cpus;
> -
>       ASSERT(local_irq_is_enabled());
>       ASSERT(cpumask_subset(selected, &cpu_online_map));
>   
> @@ -59,8 +57,7 @@ void on_selected_cpus(
>   
>       cpumask_copy(&call_data.selected, selected);
>   
> -    nr_cpus = cpumask_weight(&call_data.selected);
> -    if ( nr_cpus == 0 )
> +    if ( cpumask_empty(&call_data.selected) )
>           goto out;
>   
>       call_data.func = func;

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Feb 07 02:23:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 02:23:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266363.460049 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGtg9-0002Zr-5p; Mon, 07 Feb 2022 02:22:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266363.460049; Mon, 07 Feb 2022 02:22:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGtg9-0002Zk-2O; Mon, 07 Feb 2022 02:22:57 +0000
Received: by outflank-mailman (input) for mailman id 266363;
 Mon, 07 Feb 2022 02:22:55 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nGtg7-0002Za-4B; Mon, 07 Feb 2022 02:22:55 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nGtg6-0006wS-SO; Mon, 07 Feb 2022 02:22:54 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nGtg6-0006kH-Br; Mon, 07 Feb 2022 02:22:54 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nGtg6-0000zy-AO; Mon, 07 Feb 2022 02:22:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=GXKUJhSoKVUnytwqMqYAkaXQAqAwQy6+s6naJFTkjzs=; b=MxsdV9ZkzXFsWwUpnWIlzy17qI
	FTw3OBCCkNaLTS83vQX2Irk8WmRNeooJ6ZLImbezn/hOSYjhhG7gLJfPzbFcSAK4ztuds3Qoic9yZ
	81RBUhDmuwqW3a7nzabbWqln93WyRitfHn3MDHVZJL+MTh8pc6wAGHqkzDKaMMic9rCQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168034-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 168034: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=0d564a3e32ba8494014c67cdd2ebf0fb71860dff
X-Osstest-Versions-That:
    qemuu=31f59af395922b7f40799e75db6e15ff52d8f94a
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 07 Feb 2022 02:22:54 +0000

flight 168034 qemu-mainline real [real]
flight 168036 qemu-mainline real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/168034/
http://logs.test-lab.xenproject.org/osstest/logs/168036/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 168036-retest

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168016
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168016
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168016
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168016
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168016
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168016
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168016
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168016
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                0d564a3e32ba8494014c67cdd2ebf0fb71860dff
baseline version:
 qemuu                31f59af395922b7f40799e75db6e15ff52d8f94a

Last test of basis   168016  2022-02-04 17:37:00 Z    2 days
Testing same since   168034  2022-02-06 18:38:21 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Ani Sinha <ani@anisinha.ca>
  David Hildenbrand <david@redhat.com>
  Dmitry V. Orekhov dima.orekhov@gmail.com
  Eric DeVolder <eric.devolder@oracle.com>
  Igor Mammedov <imammedo@redhat.com>
  Michael S. Tsirkin <mst@redhat.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Peter Maydell <peter.maydell@linaro.org>
  Raphael Norwitz <raphael.norwitz@nutanix.com>
  Thomas Huth <thuth@redhat.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  fail    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   31f59af395..0d564a3e32  0d564a3e32ba8494014c67cdd2ebf0fb71860dff -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Mon Feb 07 05:00:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 05:00:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266376.460061 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGw8E-0001GY-Sj; Mon, 07 Feb 2022 05:00:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266376.460061; Mon, 07 Feb 2022 05:00:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGw8E-0001GR-O2; Mon, 07 Feb 2022 05:00:06 +0000
Received: by outflank-mailman (input) for mailman id 266376;
 Mon, 07 Feb 2022 05:00:05 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nGw8D-0001FQ-OA; Mon, 07 Feb 2022 05:00:05 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nGw8D-00023l-LW; Mon, 07 Feb 2022 05:00:05 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nGw8D-0005wh-2k; Mon, 07 Feb 2022 05:00:05 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nGw8D-0002A5-27; Mon, 07 Feb 2022 05:00:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=jCLDrpPf7PiyiAFHm1bltYSAry8sNkdA1YX5WZyKFiU=; b=E3GZ4TL7pPVQJt42VOoUElePa1
	u3yvOG7QUOCQDQX4voFhF0ZCyUGNEUZ6BSSt46rnsRDhCBPM+4EBMSeHDJW1ohcb6r6ReIk6D1OYg
	jqPizWMYRPG8ZnAcuyLrb35zcnZB+EyvPlLdVZIzvGS65NrFi2/bQcZQzrwSjgt5RE6A=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168035-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 168035: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-arm64-arm64-libvirt-raw:guest-start/debian.repeat:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=d8ad2ce873abab1cfd38779c626b79cef6307aac
X-Osstest-Versions-That:
    linux=90c9e950c0def5c354b4a6154a2ddda3e5f214ac
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 07 Feb 2022 05:00:05 +0000

flight 168035 linux-linus real [real]
flight 168039 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/168035/
http://logs.test-lab.xenproject.org/osstest/logs/168039/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-libvirt-raw 17 guest-start/debian.repeat fail pass in 168039-retest
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 168039-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168029
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168029
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168029
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168029
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168029
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168029
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168029
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168029
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                d8ad2ce873abab1cfd38779c626b79cef6307aac
baseline version:
 linux                90c9e950c0def5c354b4a6154a2ddda3e5f214ac

Last test of basis   168029  2022-02-06 01:42:09 Z    1 days
Testing same since   168035  2022-02-06 18:41:13 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Ameer Hamza <amhamza.mgc@gmail.com>
  Anshuman Khandual <anshuman.khandual@arm.com>
  Arnaldo Carvalho de Melo <acme@redhat.com>
  Borislav Petkov <bp@suse.de>
  Changbin Du <changbin.du@gmail.com>
  Dinh Nguyen <dinguyen@kernel.org>
  German Gomez <german.gomez@arm.com>
  hongnanli <hongnan.li@linux.alibaba.com>
  Ian Rogers <irogers@google.com>
  Jiri Olsa <jolsa@redhat.com>
  John Garry <john.garry@huawei.com>
  Josh Poimboeuf <jpoimboe@redhat.com>
  Leo Yan <leo.yan@linaro.org>
  Linus Torvalds <torvalds@linux-foundation.org>
  Lukas Czerner <lczerner@redhat.com>
  Marco Elver <elver@google.com>
  Masanari Iida <standby24x7@gmail.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Namhyung Kim <namhyung@gmail.com>
  Namhyung Kim <namhyung@kernel.org>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Peter Zijlstra <peterz@infradead.org>
  Ritesh Harjani <riteshh@linux.ibm.com>
  Rob Herring <robh@kernel.org>
  Sergei Trofimovich <slyich@gmail.com>
  Sergey Shtylyov <s.shtylyov@omp.ru>
  Theodore Ts'o <tytso@mit.edu>
  Thomas Gleixner <tglx@linutronix.de>
  Tristan Hume <tristan@thume.ca>
  Xin Yin <yinxin.x@bytedance.com>
  Yang Li <yang.lee@linux.alibaba.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   90c9e950c0def..d8ad2ce873aba  d8ad2ce873abab1cfd38779c626b79cef6307aac -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Mon Feb 07 06:37:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 06:37:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266393.460072 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGxdl-0001Xg-Ts; Mon, 07 Feb 2022 06:36:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266393.460072; Mon, 07 Feb 2022 06:36:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGxdl-0001XZ-Pj; Mon, 07 Feb 2022 06:36:45 +0000
Received: by outflank-mailman (input) for mailman id 266393;
 Mon, 07 Feb 2022 06:36:45 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nGxdl-0001XP-Bn; Mon, 07 Feb 2022 06:36:45 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nGxdl-0003ng-8x; Mon, 07 Feb 2022 06:36:45 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nGxdk-0001wx-V5; Mon, 07 Feb 2022 06:36:45 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nGxdk-0006SY-UY; Mon, 07 Feb 2022 06:36:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=8gh+gtdZQ3N3tkL6Ho3v9oV3Q/dLpiy/lExBtl9zL+g=; b=C/sp37mX6RWylF/zS/VlJZ4qOm
	5orINeza1oRMZ/LZsTJKBsGE7aglxmiBI4mQmtZ8yTWioiR6OJ0mYd6BT5tk7ZaS2CenvVa3xWWrF
	1Z96zKR6hAZEMdNL3otnZPvQo8c4fsrA/PF6IDOIBP1PLqJS9er7Sbnh0YRkdpBUR2vc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168038-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 168038: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=6fb09da89f88000a7592171a0ce08cf1feaa0646
X-Osstest-Versions-That:
    ovmf=a4b7aa362d94bbe0287663cab9af4ab503f6185d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 07 Feb 2022 06:36:44 +0000

flight 168038 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168038/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 6fb09da89f88000a7592171a0ce08cf1feaa0646
baseline version:
 ovmf                 a4b7aa362d94bbe0287663cab9af4ab503f6185d

Last test of basis   168017  2022-02-04 18:41:45 Z    2 days
Testing same since   168038  2022-02-07 01:55:23 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Chris Jones <christopher.jones@arm.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   a4b7aa362d..6fb09da89f  6fb09da89f88000a7592171a0ce08cf1feaa0646 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Mon Feb 07 06:41:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 06:41:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266406.460083 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGxik-0002yh-Hc; Mon, 07 Feb 2022 06:41:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266406.460083; Mon, 07 Feb 2022 06:41:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGxik-0002ya-EF; Mon, 07 Feb 2022 06:41:54 +0000
Received: by outflank-mailman (input) for mailman id 266406;
 Mon, 07 Feb 2022 06:41:53 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=ddl1=SW=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nGxij-0002yJ-4Z
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 06:41:53 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 085e69de-87e1-11ec-8f75-fffcc8bd4f1a;
 Mon, 07 Feb 2022 07:41:52 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id C29571F37F;
 Mon,  7 Feb 2022 06:41:51 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7A64F13519;
 Mon,  7 Feb 2022 06:41:51 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id DuVoHC+/AGLDUgAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 07 Feb 2022 06:41:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 085e69de-87e1-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1644216111; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=6vgAg81WHIk6Tx0jiVRvumBbWbcKMPtr0lnAzK9JTuw=;
	b=I39FyKOyM28BJZbv/ZOgZBEDu0hkQOD4+PmvEjjyxgjB6FkuhJCElT0Uh5oYK2HuHWHzJA
	mYNORkXY0e8pnmAXo53MFcA2DQMx7BzcoR4d1oaKwphgudV3m6hCev4YZE+sFZyBmrRR/h
	EYY0QaCZy6dwkW7LJZog1IVWyuUz1eo=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: [PATCH v2 0/5] tools: remove include/xen-external directory
Date: Mon,  7 Feb 2022 07:41:42 +0100
Message-Id: <20220207064147.9585-1-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

The tools/include/xen-external directory contains a header file from
FreeBSD used to generate Xen header files. This series is replacing the
complete directory by a single header with the same semantics.

Changes in V2:
- remove stale comment in patch 1

Juergen Gross (5):
  tools/include: generate a _xen_list.h file
  tools/libs/light: replace _libxl_list.h with _xen_list.h
  tools/libs/toolcore: replace _xentoolcore_list.h with _xen_list.h
  tools/libs/evtchn: use _xen_list.h
  tools/include: remove xen-external directory

 .gitignore                                    |    1 -
 tools/include/Makefile                        |    2 +
 tools/include/_xen_list.h                     |  509 ++++++++
 tools/include/libxl.h                         |    4 +-
 tools/include/xen-external/README             |   24 -
 tools/include/xen-external/bsd-COPYRIGHT      |  126 --
 tools/include/xen-external/bsd-queue.3        | 1044 -----------------
 .../xen-external/bsd-sys-queue-h-seddery      |   74 --
 tools/include/xen-external/bsd-sys-queue.h    |  637 ----------
 tools/include/xentoolcore_internal.h          |    4 +-
 tools/libs/evtchn/minios.c                    |   20 +-
 tools/libs/light/Makefile                     |   10 +-
 tools/libs/light/libxl.c                      |   40 +-
 tools/libs/light/libxl_aoutils.c              |   20 +-
 tools/libs/light/libxl_device.c               |   27 +-
 tools/libs/light/libxl_disk.c                 |    4 +-
 tools/libs/light/libxl_domain.c               |   18 +-
 tools/libs/light/libxl_event.c                |  128 +-
 tools/libs/light/libxl_fork.c                 |   44 +-
 tools/libs/light/libxl_internal.h             |   86 +-
 tools/libs/light/libxl_qmp.c                  |   19 +-
 tools/libs/light/libxl_stream_read.c          |   20 +-
 tools/libs/toolcore/Makefile                  |    8 -
 23 files changed, 729 insertions(+), 2140 deletions(-)
 create mode 100644 tools/include/_xen_list.h
 delete mode 100644 tools/include/xen-external/README
 delete mode 100644 tools/include/xen-external/bsd-COPYRIGHT
 delete mode 100644 tools/include/xen-external/bsd-queue.3
 delete mode 100755 tools/include/xen-external/bsd-sys-queue-h-seddery
 delete mode 100644 tools/include/xen-external/bsd-sys-queue.h

-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Mon Feb 07 06:41:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 06:41:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266409.460106 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGxil-0003ON-VP; Mon, 07 Feb 2022 06:41:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266409.460106; Mon, 07 Feb 2022 06:41:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGxil-0003NJ-OD; Mon, 07 Feb 2022 06:41:55 +0000
Received: by outflank-mailman (input) for mailman id 266409;
 Mon, 07 Feb 2022 06:41:54 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=ddl1=SW=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nGxik-0002yP-Kr
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 06:41:54 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 08e550ca-87e1-11ec-8eb8-a37418f5ba1a;
 Mon, 07 Feb 2022 07:41:52 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id BE1F21F386;
 Mon,  7 Feb 2022 06:41:52 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 954EC13519;
 Mon,  7 Feb 2022 06:41:52 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id sB8XIzC/AGLDUgAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 07 Feb 2022 06:41:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 08e550ca-87e1-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1644216112; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=O9L5VCHqoZDN85JbspHZhwKfGz0YeeeAr6knmmOSjvM=;
	b=fqfGbK+AjBnN9kden99G3s2VjnS2aqDvCscd2EKdW332AzAsrEzxGWjWxnRXdYD27mDaaP
	W6ricm/CcUTP20KgsLhwjIFPssGRNLb3ObT0xJM0DcSCrDociLS4DiOl1QJYPJzlA0W2la
	KoUZ7LGdapoAitMjLIm30Xh9MHEivSU=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>
Subject: [PATCH v2 4/5] tools/libs/evtchn: use _xen_list.h
Date: Mon,  7 Feb 2022 07:41:46 +0100
Message-Id: <20220207064147.9585-5-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220207064147.9585-1-jgross@suse.com>
References: <20220207064147.9585-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Instead of including xen-external/bsd-sys-queue.h use the header
_xen_list.h in minios.c.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 tools/libs/evtchn/minios.c | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/tools/libs/evtchn/minios.c b/tools/libs/evtchn/minios.c
index 30f98bc7e4..65cfccfd09 100644
--- a/tools/libs/evtchn/minios.c
+++ b/tools/libs/evtchn/minios.c
@@ -20,7 +20,7 @@
  * Split off from xc_minios.c
  */
 
-#include "xen-external/bsd-sys-queue.h"
+#include "_xen_list.h"
 #include <mini-os/types.h>
 #include <mini-os/os.h>
 #include <mini-os/lib.h>
@@ -38,10 +38,10 @@
 
 #include "private.h"
 
-LIST_HEAD(port_list, port_info);
+XEN_LIST_HEAD(port_list, struct port_info);
 
 struct port_info {
-    LIST_ENTRY(port_info) list;
+    XEN_LIST_ENTRY(struct port_info) list;
     evtchn_port_t port;
     bool pending;
     bool bound;
@@ -62,7 +62,7 @@ static struct port_info *port_alloc(xenevtchn_handle *xce)
     port_info->port = -1;
     port_info->bound = false;
 
-    LIST_INSERT_HEAD(port_list, port_info, list);
+    XEN_LIST_INSERT_HEAD(port_list, port_info, list);
 
     return port_info;
 }
@@ -72,7 +72,7 @@ static void port_dealloc(struct port_info *port_info)
     if ( port_info->bound )
         unbind_evtchn(port_info->port);
 
-    LIST_REMOVE(port_info, list);
+    XEN_LIST_REMOVE(port_info, list);
     free(port_info);
 }
 
@@ -81,7 +81,7 @@ static int evtchn_close_fd(struct file *file)
     struct port_info *port_info, *tmp;
     struct port_list *port_list = file->dev;
 
-    LIST_FOREACH_SAFE(port_info, port_list, list, tmp)
+    XEN_LIST_FOREACH_SAFE(port_info, port_list, list, tmp)
         port_dealloc(port_info);
     free(port_list);
 
@@ -126,7 +126,7 @@ int osdep_evtchn_open(xenevtchn_handle *xce, unsigned int flags)
     }
 
     file->dev = list;
-    LIST_INIT(list);
+    XEN_LIST_INIT(list);
     xce->fd = fd;
     printf("evtchn_open() -> %d\n", fd);
 
@@ -173,7 +173,7 @@ static void evtchn_handler(evtchn_port_t port, struct pt_regs *regs, void *data)
     assert(file);
     port_list = file->dev;
     mask_evtchn(port);
-    LIST_FOREACH(port_info, port_list, list)
+    XEN_LIST_FOREACH(port_info, port_list, list)
     {
         if ( port_info->port == port )
             goto found;
@@ -257,7 +257,7 @@ int xenevtchn_unbind(xenevtchn_handle *xce, evtchn_port_t port)
     struct port_info *port_info;
     struct port_list *port_list = file->dev;
 
-    LIST_FOREACH(port_info, port_list, list)
+    XEN_LIST_FOREACH(port_info, port_list, list)
     {
         if ( port_info->port == port )
         {
@@ -314,7 +314,7 @@ xenevtchn_port_or_error_t xenevtchn_pending(xenevtchn_handle *xce)
 
     file->read = false;
 
-    LIST_FOREACH(port_info, port_list, list)
+    XEN_LIST_FOREACH(port_info, port_list, list)
     {
         if ( port_info->port != -1 && port_info->pending )
         {
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Mon Feb 07 06:41:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 06:41:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266407.460087 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGxik-00031q-Qd; Mon, 07 Feb 2022 06:41:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266407.460087; Mon, 07 Feb 2022 06:41:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGxik-00030W-MF; Mon, 07 Feb 2022 06:41:54 +0000
Received: by outflank-mailman (input) for mailman id 266407;
 Mon, 07 Feb 2022 06:41:54 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=ddl1=SW=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nGxij-0002yP-Rz
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 06:41:53 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 08762e80-87e1-11ec-8eb8-a37418f5ba1a;
 Mon, 07 Feb 2022 07:41:52 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 02A4D210F3;
 Mon,  7 Feb 2022 06:41:52 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id CA71F13519;
 Mon,  7 Feb 2022 06:41:51 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id IDQIMC+/AGLDUgAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 07 Feb 2022 06:41:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 08762e80-87e1-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1644216112; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=mCUb5g78LuJVrOtCJeFF2txQ1SfvngrUecaJfWrIMSg=;
	b=d2uVq85MoPreBkE3vvjYcNOhddy4m2VjdVk1NUxkocWQADPs+aLKRuZ0lpEU5MayHQWaqL
	pLr2ReNHBhw572FdsMZA6n77VVHxD6y0szQ7sFXWeYjBFoGmJJwJGW6qWO10T3Tc9Y0IJZ
	2H6h/43BSA10kIP2c5JgW2WKrm6VF+o=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>
Subject: [PATCH v2 1/5] tools/include: generate a _xen_list.h file
Date: Mon,  7 Feb 2022 07:41:43 +0100
Message-Id: <20220207064147.9585-2-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220207064147.9585-1-jgross@suse.com>
References: <20220207064147.9585-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Today tools/include contains two basically identical header files
generated from the same source. They just differ by the used name space
and they are being generated from different Makefiles via a perl
script.

Prepare to have only one such header by using a more generic namespace
"XEN" for _xen_list.h.

As the original header hasn't been updated in the Xen tree since its
introduction about 10 years ago, and the updates of FreeBSD side have
mostly covered BSD internal debugging aids, just don't generate the
new header during build, especially as using the current FreeBSD
version of the file would require some updates of the perl script,
which are potentially more work than just doing the needed editing by
hand. Additionally this enables to remove the not needed debugging
extensions of FreeBSD.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 tools/include/Makefile    |   2 +
 tools/include/_xen_list.h | 509 ++++++++++++++++++++++++++++++++++++++
 2 files changed, 511 insertions(+)
 create mode 100644 tools/include/_xen_list.h

diff --git a/tools/include/Makefile b/tools/include/Makefile
index d7b51006e0..d965987f55 100644
--- a/tools/include/Makefile
+++ b/tools/include/Makefile
@@ -70,11 +70,13 @@ install: all
 	$(INSTALL_DATA) xen/io/*.h $(DESTDIR)$(includedir)/xen/io
 	$(INSTALL_DATA) xen/sys/*.h $(DESTDIR)$(includedir)/xen/sys
 	$(INSTALL_DATA) xen/xsm/*.h $(DESTDIR)$(includedir)/xen/xsm
+	$(INSTALL_DATA) _xen_list.h $(DESTDIR)$(includedir)
 
 .PHONY: uninstall
 uninstall:
 	echo "[FIXME] uninstall headers"
 	rm -rf $(DESTDIR)$(includedir)/xen
+	rm -f $(DESTDIR)$(includedir)/_xen_list.h
 
 .PHONY: clean
 clean:
diff --git a/tools/include/_xen_list.h b/tools/include/_xen_list.h
new file mode 100644
index 0000000000..ce246f95c9
--- /dev/null
+++ b/tools/include/_xen_list.h
@@ -0,0 +1,509 @@
+/*-
+ * Copyright (c) 1991, 1993
+ *	The Regents of the University of California.  All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *    notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *    notice, this list of conditions and the following disclaimer in the
+ *    documentation and/or other materials provided with the distribution.
+ * 4. Neither the name of the University nor the names of its contributors
+ *    may be used to endorse or promote products derived from this software
+ *    without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND
+ * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+ * ARE DISCLAIMED.  IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE
+ * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+ * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
+ * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
+ * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
+ * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
+ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
+ * SUCH DAMAGE.
+ *
+ *	@(#)queue.h	8.5 (Berkeley) 8/20/94
+ * $FreeBSD$
+ */
+
+#ifndef XEN__SYS_QUEUE_H_
+#define	XEN__SYS_QUEUE_H_
+
+/* #include <sys/cdefs.h> */
+
+/*
+ * This file defines four types of data structures: singly-linked lists,
+ * singly-linked tail queues, lists and tail queues.
+ *
+ * A singly-linked list is headed by a single forward pointer. The elements
+ * are singly linked for minimum space and pointer manipulation overhead at
+ * the expense of O(n) removal for arbitrary elements. New elements can be
+ * added to the list after an existing element or at the head of the list.
+ * Elements being removed from the head of the list should use the explicit
+ * macro for this purpose for optimum efficiency. A singly-linked list may
+ * only be traversed in the forward direction.  Singly-linked lists are ideal
+ * for applications with large datasets and few or no removals or for
+ * implementing a LIFO queue.
+ *
+ * A singly-linked tail queue is headed by a pair of pointers, one to the
+ * head of the list and the other to the tail of the list. The elements are
+ * singly linked for minimum space and pointer manipulation overhead at the
+ * expense of O(n) removal for arbitrary elements. New elements can be added
+ * to the list after an existing element, at the head of the list, or at the
+ * end of the list. Elements being removed from the head of the tail queue
+ * should use the explicit macro for this purpose for optimum efficiency.
+ * A singly-linked tail queue may only be traversed in the forward direction.
+ * Singly-linked tail queues are ideal for applications with large datasets
+ * and few or no removals or for implementing a FIFO queue.
+ *
+ * A list is headed by a single forward pointer (or an array of forward
+ * pointers for a hash table header). The elements are doubly linked
+ * so that an arbitrary element can be removed without a need to
+ * traverse the list. New elements can be added to the list before
+ * or after an existing element or at the head of the list. A list
+ * may only be traversed in the forward direction.
+ *
+ * A tail queue is headed by a pair of pointers, one to the head of the
+ * list and the other to the tail of the list. The elements are doubly
+ * linked so that an arbitrary element can be removed without a need to
+ * traverse the list. New elements can be added to the list before or
+ * after an existing element, at the head of the list, or at the end of
+ * the list. A tail queue may be traversed in either direction.
+ *
+ * For details on the use of these macros, see the queue(3) manual page.
+ *
+ *
+ *				XEN_SLIST	XEN_LIST	XEN_STAILQ	XEN_TAILQ
+ * _HEAD			+	+	+	+
+ * _HEAD_INITIALIZER		+	+	+	+
+ * _ENTRY			+	+	+	+
+ * _INIT			+	+	+	+
+ * _EMPTY			+	+	+	+
+ * _FIRST			+	+	+	+
+ * _NEXT			+	+	+	+
+ * _PREV			-	-	-	+
+ * _LAST			-	-	+	+
+ * _FOREACH			+	+	+	+
+ * _FOREACH_SAFE		+	+	+	+
+ * _FOREACH_REVERSE		-	-	-	+
+ * _FOREACH_REVERSE_SAFE	-	-	-	+
+ * _INSERT_HEAD			+	+	+	+
+ * _INSERT_BEFORE		-	+	-	+
+ * _INSERT_AFTER		+	+	+	+
+ * _INSERT_TAIL			-	-	+	+
+ * _CONCAT			-	-	+	+
+ * _REMOVE_AFTER		+	-	+	-
+ * _REMOVE_HEAD			+	-	+	-
+ * _REMOVE			+	+	+	+
+ * _SWAP			+	+	+	+
+ *
+ */
+
+/*
+ * Singly-linked List declarations.
+ */
+#define	XEN_SLIST_HEAD(name, type)					\
+struct name {								\
+	type *slh_first;	/* first element */			\
+}
+
+#define	XEN_SLIST_HEAD_INITIALIZER(head)				\
+	{ 0 }
+
+#define	XEN_SLIST_ENTRY(type)						\
+struct {								\
+	type *sle_next;	/* next element */				\
+}
+
+/*
+ * Singly-linked List functions.
+ */
+#define	XEN_SLIST_EMPTY(head)	((head)->slh_first == 0)
+
+#define	XEN_SLIST_FIRST(head)	((head)->slh_first)
+
+#define	XEN_SLIST_FOREACH(var, head, field)				\
+	for ((var) = XEN_SLIST_FIRST((head));				\
+	    (var);							\
+	    (var) = XEN_SLIST_NEXT((var), field))
+
+#define	XEN_SLIST_FOREACH_SAFE(var, head, field, tvar)			\
+	for ((var) = XEN_SLIST_FIRST((head));				\
+	    (var) && ((tvar) = XEN_SLIST_NEXT((var), field), 1);	\
+	    (var) = (tvar))
+
+#define	XEN_SLIST_FOREACH_PREVPTR(var, varp, head, field)		\
+	for ((varp) = &XEN_SLIST_FIRST((head));				\
+	    ((var) = *(varp)) != 0;					\
+	    (varp) = &XEN_SLIST_NEXT((var), field))
+
+#define	XEN_SLIST_INIT(head) do {					\
+	XEN_SLIST_FIRST((head)) = 0;					\
+} while (0)
+
+#define	XEN_SLIST_INSERT_AFTER(slistelm, elm, field) do {		\
+	XEN_SLIST_NEXT((elm), field) = XEN_SLIST_NEXT((slistelm), field);\
+	XEN_SLIST_NEXT((slistelm), field) = (elm);			\
+} while (0)
+
+#define	XEN_SLIST_INSERT_HEAD(head, elm, field) do {			\
+	XEN_SLIST_NEXT((elm), field) = XEN_SLIST_FIRST((head));		\
+	XEN_SLIST_FIRST((head)) = (elm);				\
+} while (0)
+
+#define	XEN_SLIST_NEXT(elm, field)	((elm)->field.sle_next)
+
+#define	XEN_SLIST_REMOVE(head, elm, type, field) do {			\
+	if (XEN_SLIST_FIRST((head)) == (elm)) {				\
+		XEN_SLIST_REMOVE_HEAD((head), field);			\
+	}								\
+	else {								\
+		type *curelm = XEN_SLIST_FIRST((head));			\
+		while (XEN_SLIST_NEXT(curelm, field) != (elm))		\
+			curelm = XEN_SLIST_NEXT(curelm, field);		\
+		XEN_SLIST_REMOVE_AFTER(curelm, field);			\
+	}								\
+} while (0)
+
+#define XEN_SLIST_REMOVE_AFTER(elm, field) do {				\
+	XEN_SLIST_NEXT(elm, field) =					\
+	    XEN_SLIST_NEXT(XEN_SLIST_NEXT(elm, field), field);		\
+} while (0)
+
+#define	XEN_SLIST_REMOVE_HEAD(head, field) do {				\
+	XEN_SLIST_FIRST((head)) = XEN_SLIST_NEXT(XEN_SLIST_FIRST((head)), field);\
+} while (0)
+
+#define XEN_SLIST_SWAP(head1, head2, type) do {				\
+	type *swap_first = XEN_SLIST_FIRST(head1);			\
+	XEN_SLIST_FIRST(head1) = XEN_SLIST_FIRST(head2);		\
+	XEN_SLIST_FIRST(head2) = swap_first;				\
+} while (0)
+
+/*
+ * Singly-linked Tail queue declarations.
+ */
+#define	XEN_STAILQ_HEAD(name, type)					\
+struct name {								\
+	type *stqh_first;/* first element */				\
+	type **stqh_last;/* addr of last next element */		\
+}
+
+#define	XEN_STAILQ_HEAD_INITIALIZER(head)				\
+	{ 0, &(head).stqh_first }
+
+#define	XEN_STAILQ_ENTRY(type)						\
+struct {								\
+	type *stqe_next;	/* next element */			\
+}
+
+/*
+ * Singly-linked Tail queue functions.
+ */
+#define	XEN_STAILQ_CONCAT(head1, head2) do {				\
+	if (!XEN_STAILQ_EMPTY((head2))) {				\
+		*(head1)->stqh_last = (head2)->stqh_first;		\
+		(head1)->stqh_last = (head2)->stqh_last;		\
+		XEN_STAILQ_INIT((head2));				\
+	}								\
+} while (0)
+
+#define	XEN_STAILQ_EMPTY(head)	((head)->stqh_first == 0)
+
+#define	XEN_STAILQ_FIRST(head)	((head)->stqh_first)
+
+#define	XEN_STAILQ_FOREACH(var, head, field)				\
+	for((var) = XEN_STAILQ_FIRST((head));				\
+	   (var);							\
+	   (var) = XEN_STAILQ_NEXT((var), field))
+
+
+#define	XEN_STAILQ_FOREACH_SAFE(var, head, field, tvar)			\
+	for ((var) = XEN_STAILQ_FIRST((head));				\
+	    (var) && ((tvar) = XEN_STAILQ_NEXT((var), field), 1);	\
+	    (var) = (tvar))
+
+#define	XEN_STAILQ_INIT(head) do {					\
+	XEN_STAILQ_FIRST((head)) = 0;					\
+	(head)->stqh_last = &XEN_STAILQ_FIRST((head));			\
+} while (0)
+
+#define	XEN_STAILQ_INSERT_AFTER(head, tqelm, elm, field) do {		\
+	if ((XEN_STAILQ_NEXT((elm), field) = XEN_STAILQ_NEXT((tqelm), field)) == 0)\
+		(head)->stqh_last = &XEN_STAILQ_NEXT((elm), field);	\
+	XEN_STAILQ_NEXT((tqelm), field) = (elm);			\
+} while (0)
+
+#define	XEN_STAILQ_INSERT_HEAD(head, elm, field) do {			\
+	if ((XEN_STAILQ_NEXT((elm), field) = XEN_STAILQ_FIRST((head))) == 0)\
+		(head)->stqh_last = &XEN_STAILQ_NEXT((elm), field);	\
+	XEN_STAILQ_FIRST((head)) = (elm);				\
+} while (0)
+
+#define	XEN_STAILQ_INSERT_TAIL(head, elm, field) do {			\
+	XEN_STAILQ_NEXT((elm), field) = 0;				\
+	*(head)->stqh_last = (elm);					\
+	(head)->stqh_last = &XEN_STAILQ_NEXT((elm), field);		\
+} while (0)
+
+#define	XEN_STAILQ_LAST(head, type, field)				\
+	(XEN_STAILQ_EMPTY((head)) ?					\
+		0 :							\
+	        ((type *)(void *)					\
+		((char *)((head)->stqh_last) - offsetof(type, field))))
+
+#define	XEN_STAILQ_NEXT(elm, field)	((elm)->field.stqe_next)
+
+#define	XEN_STAILQ_REMOVE(head, elm, type, field) do {			\
+	if (XEN_STAILQ_FIRST((head)) == (elm)) {			\
+		XEN_STAILQ_REMOVE_HEAD((head), field);			\
+	}								\
+	else {								\
+		type *curelm = XEN_STAILQ_FIRST((head));		\
+		while (XEN_STAILQ_NEXT(curelm, field) != (elm))		\
+			curelm = XEN_STAILQ_NEXT(curelm, field);	\
+		XEN_STAILQ_REMOVE_AFTER(head, curelm, field);		\
+	}								\
+} while (0)
+
+#define XEN_STAILQ_REMOVE_AFTER(head, elm, field) do {			\
+	if ((XEN_STAILQ_NEXT(elm, field) =				\
+	     XEN_STAILQ_NEXT(XEN_STAILQ_NEXT(elm, field), field)) == 0)	\
+		(head)->stqh_last = &XEN_STAILQ_NEXT((elm), field);	\
+} while (0)
+
+#define	XEN_STAILQ_REMOVE_HEAD(head, field) do {			\
+	if ((XEN_STAILQ_FIRST((head)) =					\
+	     XEN_STAILQ_NEXT(XEN_STAILQ_FIRST((head)), field)) == 0)	\
+		(head)->stqh_last = &XEN_STAILQ_FIRST((head));		\
+} while (0)
+
+#define XEN_STAILQ_SWAP(head1, head2, type) do {			\
+	type *swap_first = XEN_STAILQ_FIRST(head1);			\
+	type **swap_last = (head1)->stqh_last;				\
+	XEN_STAILQ_FIRST(head1) = XEN_STAILQ_FIRST(head2);		\
+	(head1)->stqh_last = (head2)->stqh_last;			\
+	XEN_STAILQ_FIRST(head2) = swap_first;				\
+	(head2)->stqh_last = swap_last;					\
+	if (XEN_STAILQ_EMPTY(head1))					\
+		(head1)->stqh_last = &XEN_STAILQ_FIRST(head1);		\
+	if (XEN_STAILQ_EMPTY(head2))					\
+		(head2)->stqh_last = &XEN_STAILQ_FIRST(head2);		\
+} while (0)
+
+
+/*
+ * List declarations.
+ */
+#define	XEN_LIST_HEAD(name, type)					\
+struct name {								\
+	type *lh_first;	/* first element */				\
+}
+
+#define	XEN_LIST_HEAD_INITIALIZER(head)					\
+	{ 0 }
+
+#define	XEN_LIST_ENTRY(type)						\
+struct {								\
+	type *le_next;	/* next element */				\
+	type **le_prev;	/* address of previous next element */		\
+}
+
+/*
+ * List functions.
+ */
+
+#define	XEN_LIST_EMPTY(head)	((head)->lh_first == 0)
+
+#define	XEN_LIST_FIRST(head)	((head)->lh_first)
+
+#define	XEN_LIST_FOREACH(var, head, field)				\
+	for ((var) = XEN_LIST_FIRST((head));				\
+	    (var);							\
+	    (var) = XEN_LIST_NEXT((var), field))
+
+#define	XEN_LIST_FOREACH_SAFE(var, head, field, tvar)			\
+	for ((var) = XEN_LIST_FIRST((head));				\
+	    (var) && ((tvar) = XEN_LIST_NEXT((var), field), 1);		\
+	    (var) = (tvar))
+
+#define	XEN_LIST_INIT(head) do {					\
+	XEN_LIST_FIRST((head)) = 0;					\
+} while (0)
+
+#define	XEN_LIST_INSERT_AFTER(listelm, elm, field) do {			\
+	if ((XEN_LIST_NEXT((elm), field) = XEN_LIST_NEXT((listelm), field)) != 0)\
+		XEN_LIST_NEXT((listelm), field)->field.le_prev =	\
+		    &XEN_LIST_NEXT((elm), field);			\
+	XEN_LIST_NEXT((listelm), field) = (elm);			\
+	(elm)->field.le_prev = &XEN_LIST_NEXT((listelm), field);	\
+} while (0)
+
+#define	XEN_LIST_INSERT_BEFORE(listelm, elm, field) do {		\
+	(elm)->field.le_prev = (listelm)->field.le_prev;		\
+	XEN_LIST_NEXT((elm), field) = (listelm);			\
+	*(listelm)->field.le_prev = (elm);				\
+	(listelm)->field.le_prev = &XEN_LIST_NEXT((elm), field);	\
+} while (0)
+
+#define	XEN_LIST_INSERT_HEAD(head, elm, field) do {			\
+	if ((XEN_LIST_NEXT((elm), field) = XEN_LIST_FIRST((head))) != 0)\
+		XEN_LIST_FIRST((head))->field.le_prev = &XEN_LIST_NEXT((elm), field);\
+	XEN_LIST_FIRST((head)) = (elm);					\
+	(elm)->field.le_prev = &XEN_LIST_FIRST((head));			\
+} while (0)
+
+#define	XEN_LIST_NEXT(elm, field)	((elm)->field.le_next)
+
+#define	XEN_LIST_REMOVE(elm, field) do {				\
+	if (XEN_LIST_NEXT((elm), field) != 0)				\
+		XEN_LIST_NEXT((elm), field)->field.le_prev =		\
+		    (elm)->field.le_prev;				\
+	*(elm)->field.le_prev = XEN_LIST_NEXT((elm), field);		\
+} while (0)
+
+#define XEN_LIST_SWAP(head1, head2, type, field) do {			\
+	type *swap_tmp = XEN_LIST_FIRST((head1));			\
+	XEN_LIST_FIRST((head1)) = XEN_LIST_FIRST((head2));		\
+	XEN_LIST_FIRST((head2)) = swap_tmp;				\
+	if ((swap_tmp = XEN_LIST_FIRST((head1))) != 0)			\
+		swap_tmp->field.le_prev = &XEN_LIST_FIRST((head1));	\
+	if ((swap_tmp = XEN_LIST_FIRST((head2))) != 0)			\
+		swap_tmp->field.le_prev = &XEN_LIST_FIRST((head2));	\
+} while (0)
+
+/*
+ * Tail queue declarations.
+ */
+#define	XEN_TAILQ_HEAD(name, type)					\
+struct name {								\
+	type *tqh_first;	/* first element */			\
+	type **tqh_last;	/* addr of last next element */		\
+}
+
+#define	XEN_TAILQ_HEAD_INITIALIZER(head)				\
+	{ 0, &(head).tqh_first }
+
+#define	XEN_TAILQ_ENTRY(type)						\
+struct {								\
+	type *tqe_next;	/* next element */				\
+	type **tqe_prev;	/* address of previous next element */	\
+}
+
+/*
+ * Tail queue functions.
+ */
+
+#define	XEN_TAILQ_CONCAT(head1, head2, field) do {			\
+	if (!XEN_TAILQ_EMPTY(head2)) {					\
+		*(head1)->tqh_last = (head2)->tqh_first;		\
+		(head2)->tqh_first->field.tqe_prev = (head1)->tqh_last;	\
+		(head1)->tqh_last = (head2)->tqh_last;			\
+		XEN_TAILQ_INIT((head2));				\
+	}								\
+} while (0)
+
+#define	XEN_TAILQ_EMPTY(head)	((head)->tqh_first == 0)
+
+#define	XEN_TAILQ_FIRST(head)	((head)->tqh_first)
+
+#define	XEN_TAILQ_FOREACH(var, head, field)				\
+	for ((var) = XEN_TAILQ_FIRST((head));				\
+	    (var);							\
+	    (var) = XEN_TAILQ_NEXT((var), field))
+
+#define	XEN_TAILQ_FOREACH_SAFE(var, head, field, tvar)			\
+	for ((var) = XEN_TAILQ_FIRST((head));				\
+	    (var) && ((tvar) = XEN_TAILQ_NEXT((var), field), 1);	\
+	    (var) = (tvar))
+
+#define	XEN_TAILQ_FOREACH_REVERSE(var, head, headname, field)		\
+	for ((var) = XEN_TAILQ_LAST((head), headname);			\
+	    (var);							\
+	    (var) = XEN_TAILQ_PREV((var), headname, field))
+
+#define	XEN_TAILQ_FOREACH_REVERSE_SAFE(var, head, headname, field, tvar)	\
+	for ((var) = XEN_TAILQ_LAST((head), headname);			\
+	    (var) && ((tvar) = XEN_TAILQ_PREV((var), headname, field), 1);\
+	    (var) = (tvar))
+
+#define	XEN_TAILQ_INIT(head) do {					\
+	XEN_TAILQ_FIRST((head)) = 0;					\
+	(head)->tqh_last = &XEN_TAILQ_FIRST((head));			\
+} while (0)
+
+#define	XEN_TAILQ_INSERT_AFTER(head, listelm, elm, field) do {		\
+	if ((XEN_TAILQ_NEXT((elm), field) = XEN_TAILQ_NEXT((listelm), field)) != 0)\
+		XEN_TAILQ_NEXT((elm), field)->field.tqe_prev =		\
+		    &XEN_TAILQ_NEXT((elm), field);			\
+	else {								\
+		(head)->tqh_last = &XEN_TAILQ_NEXT((elm), field);	\
+	}								\
+	XEN_TAILQ_NEXT((listelm), field) = (elm);			\
+	(elm)->field.tqe_prev = &XEN_TAILQ_NEXT((listelm), field);	\
+} while (0)
+
+#define	XEN_TAILQ_INSERT_BEFORE(listelm, elm, field) do {		\
+	(elm)->field.tqe_prev = (listelm)->field.tqe_prev;		\
+	XEN_TAILQ_NEXT((elm), field) = (listelm);			\
+	*(listelm)->field.tqe_prev = (elm);				\
+	(listelm)->field.tqe_prev = &XEN_TAILQ_NEXT((elm), field);	\
+} while (0)
+
+#define	XEN_TAILQ_INSERT_HEAD(head, elm, field) do {			\
+	if ((XEN_TAILQ_NEXT((elm), field) = XEN_TAILQ_FIRST((head))) != 0)\
+		XEN_TAILQ_FIRST((head))->field.tqe_prev =		\
+		    &XEN_TAILQ_NEXT((elm), field);			\
+	else								\
+		(head)->tqh_last = &XEN_TAILQ_NEXT((elm), field);	\
+	XEN_TAILQ_FIRST((head)) = (elm);				\
+	(elm)->field.tqe_prev = &XEN_TAILQ_FIRST((head));		\
+} while (0)
+
+#define	XEN_TAILQ_INSERT_TAIL(head, elm, field) do {			\
+	XEN_TAILQ_NEXT((elm), field) = 0;				\
+	(elm)->field.tqe_prev = (head)->tqh_last;			\
+	*(head)->tqh_last = (elm);					\
+	(head)->tqh_last = &XEN_TAILQ_NEXT((elm), field);		\
+} while (0)
+
+#define	XEN_TAILQ_LAST(head, headname)					\
+	(*(((struct headname *)((head)->tqh_last))->tqh_last))
+
+#define	XEN_TAILQ_NEXT(elm, field) ((elm)->field.tqe_next)
+
+#define	XEN_TAILQ_PREV(elm, headname, field)				\
+	(*(((struct headname *)((elm)->field.tqe_prev))->tqh_last))
+
+#define	XEN_TAILQ_REMOVE(head, elm, field) do {				\
+	if ((XEN_TAILQ_NEXT((elm), field)) != 0)			\
+		XEN_TAILQ_NEXT((elm), field)->field.tqe_prev =		\
+		    (elm)->field.tqe_prev;				\
+	else {								\
+		(head)->tqh_last = (elm)->field.tqe_prev;		\
+	}								\
+	*(elm)->field.tqe_prev = XEN_TAILQ_NEXT((elm), field);		\
+} while (0)
+
+#define XEN_TAILQ_SWAP(head1, head2, type, field) do {			\
+	type *swap_first = (head1)->tqh_first;				\
+	type **swap_last = (head1)->tqh_last;				\
+	(head1)->tqh_first = (head2)->tqh_first;			\
+	(head1)->tqh_last = (head2)->tqh_last;				\
+	(head2)->tqh_first = swap_first;				\
+	(head2)->tqh_last = swap_last;					\
+	if ((swap_first = (head1)->tqh_first) != 0)			\
+		swap_first->field.tqe_prev = &(head1)->tqh_first;	\
+	else								\
+		(head1)->tqh_last = &(head1)->tqh_first;		\
+	if ((swap_first = (head2)->tqh_first) != 0)			\
+		swap_first->field.tqe_prev = &(head2)->tqh_first;	\
+	else								\
+		(head2)->tqh_last = &(head2)->tqh_first;		\
+} while (0)
+
+#endif /* !XEN__SYS_QUEUE_H_ */
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Mon Feb 07 06:41:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 06:41:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266408.460096 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGxil-0003AF-C2; Mon, 07 Feb 2022 06:41:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266408.460096; Mon, 07 Feb 2022 06:41:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGxil-00038C-2V; Mon, 07 Feb 2022 06:41:55 +0000
Received: by outflank-mailman (input) for mailman id 266408;
 Mon, 07 Feb 2022 06:41:54 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=ddl1=SW=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nGxij-0002yJ-SV
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 06:41:53 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 08c8b7e2-87e1-11ec-8f75-fffcc8bd4f1a;
 Mon, 07 Feb 2022 07:41:52 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 8E1D6210F5;
 Mon,  7 Feb 2022 06:41:52 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4A50313AE0;
 Mon,  7 Feb 2022 06:41:52 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id YL7LEDC/AGLDUgAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 07 Feb 2022 06:41:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 08c8b7e2-87e1-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1644216112; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=DK2mZf2XcCWtbckgaq35hrodV2t5uC1fp6yq02EjuJE=;
	b=feiArxLSwd7kwPdDhWHzHYxzZsQgEjqNh9Z2GKEOMBZO8t2zIQcNg53vq0PtJqsId1GTHU
	qXFv3Z4HdmY6EmGH+tmilK5tOBn4H8eu1uK9PHWlgVs3/ER+DgWts+cNcp3uyhoTZdpvVj
	0bYmbENIzKBTsBzyxTVndFxKDNzIoA8=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>
Subject: [PATCH v2 3/5] tools/libs/toolcore: replace _xentoolcore_list.h with _xen_list.h
Date: Mon,  7 Feb 2022 07:41:45 +0100
Message-Id: <20220207064147.9585-4-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220207064147.9585-1-jgross@suse.com>
References: <20220207064147.9585-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Remove generating _xentoolcore_list.h and use the common _xen_list.h
instead.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 .gitignore                           | 1 -
 tools/include/xentoolcore_internal.h | 4 ++--
 tools/libs/toolcore/Makefile         | 8 --------
 3 files changed, 2 insertions(+), 11 deletions(-)

diff --git a/.gitignore b/.gitignore
index 3f9d55ba87..afe78c787c 100644
--- a/.gitignore
+++ b/.gitignore
@@ -227,7 +227,6 @@ tools/hotplug/NetBSD/rc.d/xencommons
 tools/hotplug/NetBSD/rc.d/xendriverdomain
 tools/include/acpi
 tools/include/_libxl*.h
-tools/include/_xentoolcore_list.h
 tools/include/xen/*
 tools/include/xen-xsm/*
 tools/include/xen-foreign/*.(c|h|size)
diff --git a/tools/include/xentoolcore_internal.h b/tools/include/xentoolcore_internal.h
index 04f5848f09..deccefd612 100644
--- a/tools/include/xentoolcore_internal.h
+++ b/tools/include/xentoolcore_internal.h
@@ -27,7 +27,7 @@
 #include <stddef.h>
 
 #include "xentoolcore.h"
-#include "_xentoolcore_list.h"
+#include "_xen_list.h"
 
 /*---------- active handle registration ----------*/
 
@@ -87,7 +87,7 @@ typedef int Xentoolcore__Restrict_Callback(Xentoolcore__Active_Handle*,
 
 struct Xentoolcore__Active_Handle {
     Xentoolcore__Restrict_Callback *restrict_callback;
-    XENTOOLCORE_LIST_ENTRY(Xentoolcore__Active_Handle) entry;
+    XEN_LIST_ENTRY(Xentoolcore__Active_Handle) entry;
 };
 
 void xentoolcore__register_active_handle(Xentoolcore__Active_Handle*);
diff --git a/tools/libs/toolcore/Makefile b/tools/libs/toolcore/Makefile
index ed4ae00694..9c013b2879 100644
--- a/tools/libs/toolcore/Makefile
+++ b/tools/libs/toolcore/Makefile
@@ -3,7 +3,6 @@ include $(XEN_ROOT)/tools/Rules.mk
 
 MAJOR	= 1
 MINOR	= 0
-AUTOINCS := $(XEN_INCLUDE)/_xentoolcore_list.h
 
 LIBHEADER := xentoolcore.h
 
@@ -12,10 +11,3 @@ SRCS-y	+= handlereg.c
 include $(XEN_ROOT)/tools/libs/libs.mk
 
 PKG_CONFIG_DESC := Central support for Xen Hypervisor userland libraries
-
-$(LIB_OBJS): $(AUTOINCS)
-$(PIC_OBJS): $(AUTOINCS)
-
-$(XEN_INCLUDE)/_xentoolcore_list.h: $(XEN_INCLUDE)/xen-external/bsd-sys-queue-h-seddery $(XEN_INCLUDE)/xen-external/bsd-sys-queue.h
-	$(PERL) $^ --prefix=xentoolcore >$(notdir $@).new
-	$(call move-if-changed,$(notdir $@).new,$@)
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Mon Feb 07 06:41:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 06:41:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266410.460127 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGxio-00044V-Bs; Mon, 07 Feb 2022 06:41:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266410.460127; Mon, 07 Feb 2022 06:41:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGxio-00044M-73; Mon, 07 Feb 2022 06:41:58 +0000
Received: by outflank-mailman (input) for mailman id 266410;
 Mon, 07 Feb 2022 06:41:56 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=ddl1=SW=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nGxil-0002yP-L1
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 06:41:56 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 089b9bab-87e1-11ec-8eb8-a37418f5ba1a;
 Mon, 07 Feb 2022 07:41:52 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 43AC9210F4;
 Mon,  7 Feb 2022 06:41:52 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0EDF813519;
 Mon,  7 Feb 2022 06:41:52 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id mO8+AjC/AGLDUgAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 07 Feb 2022 06:41:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 089b9bab-87e1-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1644216112; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=ioM7WbcIe/sYDvywckVh1bsSGpG8hSYfcSzh25quefQ=;
	b=OQm9h6XcTy99/JQla5bATAjEhu4IRwHJnc5E3OY+J5QZWS3Bl+/OCZm9fOBkOmlW8A3C9W
	aNunZXUHYZTjgGf4ygUODxgo02tQYp4KyuWtXONvvflZHbU+nDZ5XX/CPZS7Xb/LYM7rm6
	j/OZ5dFLpq80A6mDyvYbQKysLXDW7Io=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>
Subject: [PATCH v2 2/5] tools/libs/light: replace _libxl_list.h with _xen_list.h
Date: Mon,  7 Feb 2022 07:41:44 +0100
Message-Id: <20220207064147.9585-3-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220207064147.9585-1-jgross@suse.com>
References: <20220207064147.9585-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Remove generating _libxl_list.h and use the common _xen_list.h instead.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 tools/include/libxl.h                |   4 +-
 tools/libs/light/Makefile            |  10 +--
 tools/libs/light/libxl.c             |  40 ++++-----
 tools/libs/light/libxl_aoutils.c     |  20 ++---
 tools/libs/light/libxl_device.c      |  27 +++---
 tools/libs/light/libxl_disk.c        |   4 +-
 tools/libs/light/libxl_domain.c      |  18 ++--
 tools/libs/light/libxl_event.c       | 128 +++++++++++++--------------
 tools/libs/light/libxl_fork.c        |  44 ++++-----
 tools/libs/light/libxl_internal.h    |  86 +++++++++---------
 tools/libs/light/libxl_qmp.c         |  19 ++--
 tools/libs/light/libxl_stream_read.c |  20 ++---
 12 files changed, 206 insertions(+), 214 deletions(-)

diff --git a/tools/include/libxl.h b/tools/include/libxl.h
index 2bbbd21f0b..51a9b6cfac 100644
--- a/tools/include/libxl.h
+++ b/tools/include/libxl.h
@@ -747,7 +747,7 @@
 typedef struct libxl__ctx libxl_ctx;
 
 #include <libxl_uuid.h>
-#include <_libxl_list.h>
+#include <_xen_list.h>
 
 /* API compatibility. */
 #ifdef LIBXL_API_VERSION
@@ -1448,7 +1448,7 @@ typedef struct {
 } libxl_enum_string_table;
 
 struct libxl_event;
-typedef LIBXL_TAILQ_ENTRY(struct libxl_event) libxl_ev_link;
+typedef XEN_TAILQ_ENTRY(struct libxl_event) libxl_ev_link;
 
 /*
  * A boolean variable with an explicit default state.
diff --git a/tools/libs/light/Makefile b/tools/libs/light/Makefile
index be32d95d39..5642955672 100644
--- a/tools/libs/light/Makefile
+++ b/tools/libs/light/Makefile
@@ -153,14 +153,14 @@ LIBXL_TEST_OBJS += $(foreach t, $(LIBXL_TESTS_INSIDE),libxl_test_$t.opic)
 TEST_PROG_OBJS += $(foreach t, $(LIBXL_TESTS_PROGS),test_$t.o) test_common.o
 TEST_PROGS += $(foreach t, $(LIBXL_TESTS_PROGS),test_$t)
 
-AUTOINCS = $(XEN_INCLUDE)/_libxl_list.h _libxl_save_msgs_callout.h _libxl_save_msgs_helper.h
+AUTOINCS = _libxl_save_msgs_callout.h _libxl_save_msgs_helper.h
 AUTOSRCS = _libxl_save_msgs_callout.c _libxl_save_msgs_helper.c
 
 CLIENTS = testidl libxl-save-helper
 
 SAVE_HELPER_OBJS = libxl_save_helper.o _libxl_save_msgs_helper.o
 
-LIBHEADER := libxl.h libxl_event.h libxl_json.h _libxl_types.h _libxl_types_json.h _libxl_list.h libxl_utils.h libxl_uuid.h
+LIBHEADER := libxl.h libxl_event.h libxl_json.h _libxl_types.h _libxl_types_json.h libxl_utils.h libxl_uuid.h
 
 NO_HEADERS_CHK := y
 
@@ -201,17 +201,13 @@ _libxl.api-for-check: $(XEN_INCLUDE)/libxl.h $(AUTOINCS)
 		>$@.new
 	mv -f $@.new $@
 
-$(XEN_INCLUDE)/_libxl_list.h: $(XEN_INCLUDE)/xen-external/bsd-sys-queue-h-seddery $(XEN_INCLUDE)/xen-external/bsd-sys-queue.h
-	$(PERL) $^ --prefix=libxl >$(notdir $@).new
-	$(call move-if-changed,$(notdir $@).new,$@)
-
 _libxl_save_msgs_helper.c _libxl_save_msgs_callout.c \
 _libxl_save_msgs_helper.h _libxl_save_msgs_callout.h: \
 		libxl_save_msgs_gen.pl
 	$(PERL) -w $< $@ >$@.new
 	$(call move-if-changed,$@.new,$@)
 
-$(XEN_INCLUDE)/libxl.h: $(XEN_INCLUDE)/_libxl_types.h $(XEN_INCLUDE)/_libxl_list.h
+$(XEN_INCLUDE)/libxl.h: $(XEN_INCLUDE)/_libxl_types.h
 $(XEN_INCLUDE)/libxl_json.h: $(XEN_INCLUDE)/_libxl_types_json.h
 libxl_internal.h: _libxl_types_internal.h _libxl_types_private.h _libxl_types_internal_private.h
 libxl_internal_json.h: _libxl_types_internal_json.h
diff --git a/tools/libs/light/libxl.c b/tools/libs/light/libxl.c
index 667ae6409b..a0bf7d186f 100644
--- a/tools/libs/light/libxl.c
+++ b/tools/libs/light/libxl.c
@@ -41,29 +41,29 @@ int libxl_ctx_alloc(libxl_ctx **pctx, int version,
     ctx->nogc_gc.alloc_maxsize = -1;
     ctx->nogc_gc.owner = ctx;
 
-    LIBXL_TAILQ_INIT(&ctx->occurred);
+    XEN_TAILQ_INIT(&ctx->occurred);
 
     ctx->osevent_hooks = 0;
 
     ctx->poller_app = 0;
-    LIBXL_LIST_INIT(&ctx->pollers_event);
-    LIBXL_LIST_INIT(&ctx->pollers_idle);
-    LIBXL_LIST_INIT(&ctx->pollers_active);
+    XEN_LIST_INIT(&ctx->pollers_event);
+    XEN_LIST_INIT(&ctx->pollers_idle);
+    XEN_LIST_INIT(&ctx->pollers_active);
 
-    LIBXL_LIST_INIT(&ctx->efds);
-    LIBXL_TAILQ_INIT(&ctx->etimes);
+    XEN_LIST_INIT(&ctx->efds);
+    XEN_TAILQ_INIT(&ctx->etimes);
 
     ctx->watch_slots = 0;
-    LIBXL_SLIST_INIT(&ctx->watch_freeslots);
+    XEN_SLIST_INIT(&ctx->watch_freeslots);
     libxl__ev_fd_init(&ctx->watch_efd);
 
     ctx->xce = 0;
-    LIBXL_LIST_INIT(&ctx->evtchns_waiting);
+    XEN_LIST_INIT(&ctx->evtchns_waiting);
     libxl__ev_fd_init(&ctx->evtchn_efd);
 
-    LIBXL_LIST_INIT(&ctx->aos_inprogress);
+    XEN_LIST_INIT(&ctx->aos_inprogress);
 
-    LIBXL_TAILQ_INIT(&ctx->death_list);
+    XEN_TAILQ_INIT(&ctx->death_list);
     libxl__ev_xswatch_init(&ctx->death_watch);
 
     ctx->childproc_hooks = &libxl__childproc_default_hooks;
@@ -122,14 +122,14 @@ int libxl_ctx_alloc(libxl_ctx **pctx, int version,
 static void free_disable_deaths(libxl__gc *gc,
                                 struct libxl__evgen_domain_death_list *l) {
     libxl_evgen_domain_death *death;
-    while ((death = LIBXL_TAILQ_FIRST(l)))
+    while ((death = XEN_TAILQ_FIRST(l)))
         libxl__evdisable_domain_death(gc, death);
 }
 
 static void discard_events(struct libxl__event_list *l) {
     /* doesn't bother unlinking from the list, so l is corrupt on return */
     libxl_event *ev, *next;
-    LIBXL_TAILQ_FOREACH_SAFE(ev, l, link, next)
+    XEN_TAILQ_FOREACH_SAFE(ev, l, link, next)
         libxl_event_free(0, ev);
 }
 
@@ -150,7 +150,7 @@ int libxl_ctx_free(libxl_ctx *ctx)
     free_disable_deaths(gc, &CTX->death_reported);
 
     libxl_evgen_disk_eject *eject;
-    while ((eject = LIBXL_LIST_FIRST(&CTX->disk_eject_evgens)))
+    while ((eject = XEN_LIST_FIRST(&CTX->disk_eject_evgens)))
         libxl__evdisable_disk_eject(gc, eject);
 
     libxl_childproc_setmode(CTX,0,0);
@@ -162,10 +162,10 @@ int libxl_ctx_free(libxl_ctx *ctx)
 
     /* Now there should be no more events requested from the application: */
 
-    assert(LIBXL_LIST_EMPTY(&ctx->efds));
-    assert(LIBXL_TAILQ_EMPTY(&ctx->etimes));
-    assert(LIBXL_LIST_EMPTY(&ctx->evtchns_waiting));
-    assert(LIBXL_LIST_EMPTY(&ctx->aos_inprogress));
+    assert(XEN_LIST_EMPTY(&ctx->efds));
+    assert(XEN_TAILQ_EMPTY(&ctx->etimes));
+    assert(XEN_LIST_EMPTY(&ctx->evtchns_waiting));
+    assert(XEN_LIST_EMPTY(&ctx->aos_inprogress));
 
     if (ctx->xch) xc_interface_close(ctx->xch);
     libxl_version_info_dispose(&ctx->version_info);
@@ -174,10 +174,10 @@ int libxl_ctx_free(libxl_ctx *ctx)
 
     libxl__poller_put(ctx, ctx->poller_app);
     ctx->poller_app = NULL;
-    assert(LIBXL_LIST_EMPTY(&ctx->pollers_event));
-    assert(LIBXL_LIST_EMPTY(&ctx->pollers_active));
+    assert(XEN_LIST_EMPTY(&ctx->pollers_event));
+    assert(XEN_LIST_EMPTY(&ctx->pollers_active));
     libxl__poller *poller, *poller_tmp;
-    LIBXL_LIST_FOREACH_SAFE(poller, &ctx->pollers_idle, entry, poller_tmp) {
+    XEN_LIST_FOREACH_SAFE(poller, &ctx->pollers_idle, entry, poller_tmp) {
         libxl__poller_dispose(poller);
         free(poller);
     }
diff --git a/tools/libs/light/libxl_aoutils.c b/tools/libs/light/libxl_aoutils.c
index c4c095a5ba..c2d42e7cac 100644
--- a/tools/libs/light/libxl_aoutils.c
+++ b/tools/libs/light/libxl_aoutils.c
@@ -106,7 +106,7 @@ void libxl__datacopier_init(libxl__datacopier_state *dc)
     libxl__ao_abortable_init(&dc->abrt);
     libxl__ev_fd_init(&dc->toread);
     libxl__ev_fd_init(&dc->towrite);
-    LIBXL_TAILQ_INIT(&dc->bufs);
+    XEN_TAILQ_INIT(&dc->bufs);
 }
 
 void libxl__datacopier_kill(libxl__datacopier_state *dc)
@@ -117,9 +117,9 @@ void libxl__datacopier_kill(libxl__datacopier_state *dc)
     libxl__ao_abortable_deregister(&dc->abrt);
     libxl__ev_fd_deregister(gc, &dc->toread);
     libxl__ev_fd_deregister(gc, &dc->towrite);
-    LIBXL_TAILQ_FOREACH_SAFE(buf, &dc->bufs, entry, tbuf)
+    XEN_TAILQ_FOREACH_SAFE(buf, &dc->bufs, entry, tbuf)
         free(buf);
-    LIBXL_TAILQ_INIT(&dc->bufs);
+    XEN_TAILQ_INIT(&dc->bufs);
 }
 
 static void datacopier_callback(libxl__egc *egc, libxl__datacopier_state *dc,
@@ -182,7 +182,7 @@ void libxl__datacopier_prefixdata(libxl__egc *egc, libxl__datacopier_state *dc,
         memcpy(buf->buf, ptr, buf->used);
 
         dc->used += buf->used;
-        LIBXL_TAILQ_INSERT_TAIL(&dc->bufs, buf, entry);
+        XEN_TAILQ_INSERT_TAIL(&dc->bufs, buf, entry);
     }
 }
 
@@ -235,18 +235,18 @@ static void datacopier_readable(libxl__egc *egc, libxl__ev_fd *ev,
             r = read(ev->fd, dc->readbuf + dc->used, dc->bytes_to_read);
         } else {
             while (dc->used >= dc->maxsz) {
-                libxl__datacopier_buf *rm = LIBXL_TAILQ_FIRST(&dc->bufs);
+                libxl__datacopier_buf *rm = XEN_TAILQ_FIRST(&dc->bufs);
                 dc->used -= rm->used;
                 assert(dc->used >= 0);
-                LIBXL_TAILQ_REMOVE(&dc->bufs, rm, entry);
+                XEN_TAILQ_REMOVE(&dc->bufs, rm, entry);
                 free(rm);
             }
 
-            buf = LIBXL_TAILQ_LAST(&dc->bufs, libxl__datacopier_bufs);
+            buf = XEN_TAILQ_LAST(&dc->bufs, libxl__datacopier_bufs);
             if (!buf || buf->used >= sizeof(buf->buf)) {
                 buf = libxl__malloc(NOGC, sizeof(*buf));
                 buf->used = 0;
-                LIBXL_TAILQ_INSERT_TAIL(&dc->bufs, buf, entry);
+                XEN_TAILQ_INSERT_TAIL(&dc->bufs, buf, entry);
             }
             r = read(ev->fd, buf->buf + buf->used,
                      min_t(size_t, sizeof(buf->buf) - buf->used,
@@ -331,11 +331,11 @@ static void datacopier_writable(libxl__egc *egc, libxl__ev_fd *ev,
     }
     assert(revents & POLLOUT);
     for (;;) {
-        libxl__datacopier_buf *buf = LIBXL_TAILQ_FIRST(&dc->bufs);
+        libxl__datacopier_buf *buf = XEN_TAILQ_FIRST(&dc->bufs);
         if (!buf)
             break;
         if (!buf->used) {
-            LIBXL_TAILQ_REMOVE(&dc->bufs, buf, entry);
+            XEN_TAILQ_REMOVE(&dc->bufs, buf, entry);
             free(buf);
             continue;
         }
diff --git a/tools/libs/light/libxl_device.c b/tools/libs/light/libxl_device.c
index 36c4e41e4d..e6025d135e 100644
--- a/tools/libs/light/libxl_device.c
+++ b/tools/libs/light/libxl_device.c
@@ -1476,7 +1476,7 @@ static void qdisk_spawn_outcome(libxl__egc *egc, libxl__dm_spawn_state *dmss,
  */
 typedef struct libxl__ddomain_device {
     libxl__device *dev;
-    LIBXL_SLIST_ENTRY(struct libxl__ddomain_device) next;
+    XEN_SLIST_ENTRY(struct libxl__ddomain_device) next;
 } libxl__ddomain_device;
 
 /*
@@ -1485,8 +1485,8 @@ typedef struct libxl__ddomain_device {
 typedef struct libxl__ddomain_guest {
     uint32_t domid;
     int num_qdisks;
-    LIBXL_SLIST_HEAD(, struct libxl__ddomain_device) devices;
-    LIBXL_SLIST_ENTRY(struct libxl__ddomain_guest) next;
+    XEN_SLIST_HEAD(, struct libxl__ddomain_device) devices;
+    XEN_SLIST_ENTRY(struct libxl__ddomain_guest) next;
 } libxl__ddomain_guest;
 
 /*
@@ -1496,7 +1496,7 @@ typedef struct libxl__ddomain_guest {
 typedef struct {
     libxl__ao *ao;
     libxl__ev_xswatch watch;
-    LIBXL_SLIST_HEAD(, struct libxl__ddomain_guest) guests;
+    XEN_SLIST_HEAD(, struct libxl__ddomain_guest) guests;
 } libxl__ddomain;
 
 static libxl__ddomain_guest *search_for_guest(libxl__ddomain *ddomain,
@@ -1504,7 +1504,7 @@ static libxl__ddomain_guest *search_for_guest(libxl__ddomain *ddomain,
 {
     libxl__ddomain_guest *dguest;
 
-    LIBXL_SLIST_FOREACH(dguest, &ddomain->guests, next) {
+    XEN_SLIST_FOREACH(dguest, &ddomain->guests, next) {
         if (dguest->domid == domid)
             return dguest;
     }
@@ -1516,7 +1516,7 @@ static libxl__ddomain_device *search_for_device(libxl__ddomain_guest *dguest,
 {
     libxl__ddomain_device *ddev;
 
-    LIBXL_SLIST_FOREACH(ddev, &dguest->devices, next) {
+    XEN_SLIST_FOREACH(ddev, &dguest->devices, next) {
 #define LIBXL_DEVICE_CMP(dev1, dev2, entry) (dev1->entry == dev2->entry)
         if (LIBXL_DEVICE_CMP(ddev->dev, dev, backend_devid) &&
             LIBXL_DEVICE_CMP(ddev->dev, dev, backend_domid) &&
@@ -1537,8 +1537,8 @@ static void check_and_maybe_remove_guest(libxl__gc *gc,
 {
     assert(ddomain);
 
-    if (dguest != NULL && LIBXL_SLIST_FIRST(&dguest->devices) == NULL) {
-        LIBXL_SLIST_REMOVE(&ddomain->guests, dguest, libxl__ddomain_guest,
+    if (dguest != NULL && XEN_SLIST_FIRST(&dguest->devices) == NULL) {
+        XEN_SLIST_REMOVE(&ddomain->guests, dguest, libxl__ddomain_guest,
                            next);
         LOGD(DEBUG, dguest->domid, "Removed domain from the list of active guests");
         /* Clear any leftovers in libxl/<domid> */
@@ -1572,7 +1572,7 @@ static int add_device(libxl__egc *egc, libxl__ao *ao,
     ddev = libxl__zalloc(NOGC, sizeof(*ddev));
     ddev->dev = libxl__zalloc(NOGC, sizeof(*ddev->dev));
     *ddev->dev = *dev;
-    LIBXL_SLIST_INSERT_HEAD(&dguest->devices, ddev, next);
+    XEN_SLIST_INSERT_HEAD(&dguest->devices, ddev, next);
     LOGD(DEBUG, dev->domid, "Added device %s to the list of active devices",
          libxl__device_backend_path(gc, dev));
 
@@ -1649,8 +1649,7 @@ static int remove_device(libxl__egc *egc, libxl__ao *ao,
      * above or from add_device make a copy of the data they use, so
      * there's no risk of dereferencing.
      */
-    LIBXL_SLIST_REMOVE(&dguest->devices, ddev, libxl__ddomain_device,
-                       next);
+    XEN_SLIST_REMOVE(&dguest->devices, ddev, libxl__ddomain_device, next);
     LOGD(DEBUG, dev->domid, "Removed device %s from the list of active devices",
          libxl__device_backend_path(gc, dev));
 
@@ -1716,8 +1715,8 @@ static void backend_watch_callback(libxl__egc *egc, libxl__ev_xswatch *watch,
         /* Create a new guest struct and initialize it */
         dguest = libxl__zalloc(NOGC, sizeof(*dguest));
         dguest->domid = dev->domid;
-        LIBXL_SLIST_INIT(&dguest->devices);
-        LIBXL_SLIST_INSERT_HEAD(&ddomain->guests, dguest, next);
+        XEN_SLIST_INIT(&dguest->devices);
+        XEN_SLIST_INSERT_HEAD(&ddomain->guests, dguest, next);
         LOGD(DEBUG, dguest->domid, "Added domain to the list of active guests");
     }
     ddev = search_for_device(dguest, dev);
@@ -1766,7 +1765,7 @@ int libxl_device_events_handler(libxl_ctx *ctx,
     int i, j, k;
 
     ddomain.ao = ao;
-    LIBXL_SLIST_INIT(&ddomain.guests);
+    XEN_SLIST_INIT(&ddomain.guests);
 
     rc = libxl__get_domid(gc, &domid);
     if (rc) {
diff --git a/tools/libs/light/libxl_disk.c b/tools/libs/light/libxl_disk.c
index 93936d0dd0..a5ca77850f 100644
--- a/tools/libs/light/libxl_disk.c
+++ b/tools/libs/light/libxl_disk.c
@@ -88,7 +88,7 @@ int libxl_evenable_disk_eject(libxl_ctx *ctx, uint32_t guest_domid,
     memset(evg, 0, sizeof(*evg));
     evg->user = user;
     evg->domid = guest_domid;
-    LIBXL_LIST_INSERT_HEAD(&CTX->disk_eject_evgens, evg, entry);
+    XEN_LIST_INSERT_HEAD(&CTX->disk_eject_evgens, evg, entry);
 
     uint32_t domid = libxl_get_stubdom_id(ctx, guest_domid);
 
@@ -133,7 +133,7 @@ int libxl_evenable_disk_eject(libxl_ctx *ctx, uint32_t guest_domid,
 void libxl__evdisable_disk_eject(libxl__gc *gc, libxl_evgen_disk_eject *evg) {
     CTX_LOCK;
 
-    LIBXL_LIST_REMOVE(evg, entry);
+    XEN_LIST_REMOVE(evg, entry);
 
     if (libxl__ev_xswatch_isregistered(&evg->watch))
         libxl__ev_xswatch_deregister(gc, &evg->watch);
diff --git a/tools/libs/light/libxl_domain.c b/tools/libs/light/libxl_domain.c
index 544a9bf59d..d544a60777 100644
--- a/tools/libs/light/libxl_domain.c
+++ b/tools/libs/light/libxl_domain.c
@@ -867,7 +867,7 @@ static void domain_death_occurred(libxl__egc *egc,
 
     LOGD(DEBUG, evg->domid, "%s", why);
 
-    libxl_evgen_domain_death *evg_next = LIBXL_TAILQ_NEXT(evg, entry);
+    libxl_evgen_domain_death *evg_next = XEN_TAILQ_NEXT(evg, entry);
     *evg_upd = evg_next;
 
     libxl_event *ev = NEW_EVENT(egc, DOMAIN_DEATH, evg->domid, evg->user);
@@ -875,8 +875,8 @@ static void domain_death_occurred(libxl__egc *egc,
     libxl__event_occurred(egc, ev);
 
     evg->death_reported = 1;
-    LIBXL_TAILQ_REMOVE(&CTX->death_list, evg, entry);
-    LIBXL_TAILQ_INSERT_HEAD(&CTX->death_reported, evg, entry);
+    XEN_TAILQ_REMOVE(&CTX->death_list, evg, entry);
+    XEN_TAILQ_INSERT_HEAD(&CTX->death_reported, evg, entry);
 }
 
 static void domain_death_xswatch_callback(libxl__egc *egc, libxl__ev_xswatch *w,
@@ -887,12 +887,12 @@ static void domain_death_xswatch_callback(libxl__egc *egc, libxl__ev_xswatch *w,
 
     CTX_LOCK;
 
-    evg = LIBXL_TAILQ_FIRST(&CTX->death_list);
+    evg = XEN_TAILQ_FIRST(&CTX->death_list);
 
     for (;;) {
         if (!evg) goto out;
 
-        int nentries = LIBXL_TAILQ_NEXT(evg, entry) ? 200 : 1;
+        int nentries = XEN_TAILQ_NEXT(evg, entry) ? 200 : 1;
         xc_domaininfo_t domaininfos[nentries];
         const xc_domaininfo_t *got = domaininfos, *gotend;
 
@@ -966,7 +966,7 @@ static void domain_death_xswatch_callback(libxl__egc *egc, libxl__ev_xswatch *w,
 
                 evg->shutdown_reported = 1;
             }
-            evg = LIBXL_TAILQ_NEXT(evg, entry);
+            evg = XEN_TAILQ_NEXT(evg, entry);
         }
 
         assert(rc); /* rc==0 results in us eating all evgs and quitting */
@@ -1015,13 +1015,13 @@ void libxl__evdisable_domain_death(libxl__gc *gc,
     CTX_LOCK;
 
     if (!evg->death_reported)
-        LIBXL_TAILQ_REMOVE(&CTX->death_list, evg, entry);
+        XEN_TAILQ_REMOVE(&CTX->death_list, evg, entry);
     else
-        LIBXL_TAILQ_REMOVE(&CTX->death_reported, evg, entry);
+        XEN_TAILQ_REMOVE(&CTX->death_reported, evg, entry);
 
     free(evg);
 
-    if (!LIBXL_TAILQ_FIRST(&CTX->death_list) &&
+    if (!XEN_TAILQ_FIRST(&CTX->death_list) &&
         libxl__ev_xswatch_isregistered(&CTX->death_watch))
         libxl__ev_xswatch_deregister(gc, &CTX->death_watch);
 
diff --git a/tools/libs/light/libxl_event.c b/tools/libs/light/libxl_event.c
index 7c5387e94f..c8bcd13960 100644
--- a/tools/libs/light/libxl_event.c
+++ b/tools/libs/light/libxl_event.c
@@ -165,7 +165,7 @@ static void ao__check_destroy(libxl_ctx *ctx, libxl__ao *ao);
  */
 static void pollers_note_osevent_added(libxl_ctx *ctx) {
     libxl__poller *poller;
-    LIBXL_LIST_FOREACH(poller, &ctx->pollers_active, active_entry)
+    XEN_LIST_FOREACH(poller, &ctx->pollers_active, active_entry)
         poller->osevents_added = 1;
 }
 
@@ -189,7 +189,7 @@ void libxl__egc_ao_cleanup_1_baton(libxl__gc *gc)
     if (CTX->poller_app->osevents_added)
         baton_wake(gc, CTX->poller_app);
 
-    LIBXL_LIST_FOREACH(search, &CTX->pollers_active, active_entry) {
+    XEN_LIST_FOREACH(search, &CTX->pollers_active, active_entry) {
         if (search == CTX->poller_app)
             /* This one is special.  We can't give it the baton. */
             continue;
@@ -279,7 +279,7 @@ void libxl__egc_ao_cleanup_1_baton(libxl__gc *gc)
 struct libxl__osevent_hook_nexus {
     void *ev;
     void *for_app_reg;
-    LIBXL_SLIST_ENTRY(libxl__osevent_hook_nexus) next;
+    XEN_SLIST_ENTRY(libxl__osevent_hook_nexus) next;
 };
 
 static void *osevent_ev_from_hook_nexus(libxl_ctx *ctx,
@@ -293,7 +293,7 @@ static void osevent_release_nexus(libxl__gc *gc,
                                   libxl__osevent_hook_nexus *nexus)
 {
     nexus->ev = 0;
-    LIBXL_SLIST_INSERT_HEAD(nexi_idle, nexus, next);
+    XEN_SLIST_INSERT_HEAD(nexi_idle, nexus, next);
 }
 
 /*----- OSEVENT* hook functions for nexusop "alloc" -----*/
@@ -301,9 +301,9 @@ static void osevent_hook_pre_alloc(libxl__gc *gc, void *ev,
                                    libxl__osevent_hook_nexi *nexi_idle,
                                    libxl__osevent_hook_nexus **nexus_r)
 {
-    libxl__osevent_hook_nexus *nexus = LIBXL_SLIST_FIRST(nexi_idle);
+    libxl__osevent_hook_nexus *nexus = XEN_SLIST_FIRST(nexi_idle);
     if (nexus) {
-        LIBXL_SLIST_REMOVE_HEAD(nexi_idle, next);
+        XEN_SLIST_REMOVE_HEAD(nexi_idle, next);
     } else {
         nexus = libxl__zalloc(NOGC, sizeof(*nexus));
     }
@@ -364,7 +364,7 @@ int libxl__ev_fd_register(libxl__gc *gc, libxl__ev_fd *ev,
     ev->events = events;
     ev->func = func;
 
-    LIBXL_LIST_INSERT_HEAD(&CTX->efds, ev, entry);
+    XEN_LIST_INSERT_HEAD(&CTX->efds, ev, entry);
     pollers_note_osevent_added(CTX);
 
     rc = 0;
@@ -409,10 +409,10 @@ void libxl__ev_fd_deregister(libxl__gc *gc, libxl__ev_fd *ev)
     DBG("ev_fd=%p deregister fd=%d", ev, ev->fd);
 
     OSEVENT_HOOK_VOID(fd,deregister, release, ev->fd, ev->nexus->for_app_reg);
-    LIBXL_LIST_REMOVE(ev, entry);
+    XEN_LIST_REMOVE(ev, entry);
     ev->fd = -1;
 
-    LIBXL_LIST_FOREACH(poller, &CTX->pollers_active, active_entry)
+    XEN_LIST_FOREACH(poller, &CTX->pollers_active, active_entry)
         poller->fds_deregistered = 1;
 
  out:
@@ -504,7 +504,7 @@ static void time_deregister(libxl__gc *gc, libxl__ev_time *ev)
         OSEVENT_HOOK_VOID(timeout,modify,
                           noop /* release nexus in _occurred_ */,
                           &ev->nexus->for_app_reg, right_away);
-        LIBXL_TAILQ_REMOVE(&CTX->etimes, ev, entry);
+        XEN_TAILQ_REMOVE(&CTX->etimes, ev, entry);
     }
 }
 
@@ -640,7 +640,7 @@ static void time_occurs(libxl__egc *egc, libxl__ev_time *etime, int rc)
 libxl__ev_xswatch *libxl__watch_slot_contents(libxl__gc *gc, int slotnum)
 {
     libxl__ev_watch_slot *slot = &CTX->watch_slots[slotnum];
-    libxl__ev_watch_slot *slotcontents = LIBXL_SLIST_NEXT(slot, empty);
+    libxl__ev_watch_slot *slotcontents = XEN_SLIST_NEXT(slot, empty);
 
     if (slotcontents == NULL ||
         ((uintptr_t)slotcontents >= (uintptr_t)CTX->watch_slots &&
@@ -672,7 +672,7 @@ libxl__ev_xswatch *libxl__watch_slot_contents(libxl__gc *gc, int slotnum)
 static void libxl__set_watch_slot_contents(libxl__ev_watch_slot *slot,
                                            libxl__ev_xswatch *w)
 {
-    /* we look a bit behind the curtain of LIBXL_SLIST, to explicitly
+    /* we look a bit behind the curtain of XEN_SLIST, to explicitly
      * assign to the pointer that's the next link.  See the comment
      * by the definition of libxl__ev_watch_slot */
     slot->empty.sle_next = (void*)w;
@@ -784,7 +784,7 @@ int libxl__ev_xswatch_register(libxl__gc *gc, libxl__ev_xswatch *w,
         if (rc) goto out_rc;
     }
 
-    if (LIBXL_SLIST_EMPTY(&CTX->watch_freeslots)) {
+    if (XEN_SLIST_EMPTY(&CTX->watch_freeslots)) {
         /* Free list is empty so there is not in fact a linked
          * free list in the array and we can safely realloc it */
         int newarraysize = (CTX->watch_nslots + 1) << 2;
@@ -794,14 +794,13 @@ int libxl__ev_xswatch_register(libxl__gc *gc, libxl__ev_xswatch *w,
                            CTX->watch_slots, sizeof(*newarray) * newarraysize);
         if (!newarray) goto out_nomem;
         for (i = CTX->watch_nslots; i < newarraysize; i++)
-            LIBXL_SLIST_INSERT_HEAD(&CTX->watch_freeslots,
-                                    &newarray[i], empty);
+            XEN_SLIST_INSERT_HEAD(&CTX->watch_freeslots, &newarray[i], empty);
         CTX->watch_slots = newarray;
         CTX->watch_nslots = newarraysize;
     }
-    use = LIBXL_SLIST_FIRST(&CTX->watch_freeslots);
+    use = XEN_SLIST_FIRST(&CTX->watch_freeslots);
     assert(use);
-    LIBXL_SLIST_REMOVE_HEAD(&CTX->watch_freeslots, empty);
+    XEN_SLIST_REMOVE_HEAD(&CTX->watch_freeslots, empty);
 
     path_copy = strdup(path);
     if (!path_copy) goto out_nomem;
@@ -832,7 +831,7 @@ int libxl__ev_xswatch_register(libxl__gc *gc, libxl__ev_xswatch *w,
     rc = ERROR_NOMEM;
  out_rc:
     if (use)
-        LIBXL_SLIST_INSERT_HEAD(&CTX->watch_freeslots, use, empty);
+        XEN_SLIST_INSERT_HEAD(&CTX->watch_freeslots, use, empty);
     free(path_copy);
     watches_check_fd_deregister(gc);
     CTX_UNLOCK;
@@ -856,7 +855,7 @@ void libxl__ev_xswatch_deregister(libxl__gc *gc, libxl__ev_xswatch *w)
             LOGEV(ERROR, errno, "remove watch for path %s", w->path);
 
         libxl__ev_watch_slot *slot = &CTX->watch_slots[w->slotnum];
-        LIBXL_SLIST_INSERT_HEAD(&CTX->watch_freeslots, slot, empty);
+        XEN_SLIST_INSERT_HEAD(&CTX->watch_freeslots, slot, empty);
         w->slotnum = -1;
         CTX->nwatches--;
         watches_check_fd_deregister(gc);
@@ -927,7 +926,7 @@ static void evtchn_fd_callback(libxl__egc *egc, libxl__ev_fd *ev,
             return;
         }
 
-        LIBXL_LIST_FOREACH(evev, &CTX->evtchns_waiting, entry)
+        XEN_LIST_FOREACH(evev, &CTX->evtchns_waiting, entry)
             if (port == evev->port)
                 goto found;
         /* not found */
@@ -937,7 +936,7 @@ static void evtchn_fd_callback(libxl__egc *egc, libxl__ev_fd *ev,
     found:
         DBG("ev_evtchn=%p port=%d signaled", evev, port);
         evev->waiting = 0;
-        LIBXL_LIST_REMOVE(evev, entry);
+        XEN_LIST_REMOVE(evev, entry);
         evev->callback(egc, evev);
     }
 }
@@ -972,7 +971,7 @@ int libxl__ctx_evtchn_init(libxl__gc *gc) {
 
 static void evtchn_check_fd_deregister(libxl__gc *gc)
 {
-    if (CTX->xce && LIBXL_LIST_EMPTY(&CTX->evtchns_waiting))
+    if (CTX->xce && XEN_LIST_EMPTY(&CTX->evtchns_waiting))
         libxl__ev_fd_deregister(gc, &CTX->evtchn_efd);
 }
 
@@ -1003,7 +1002,7 @@ int libxl__ev_evtchn_wait(libxl__gc *gc, libxl__ev_evtchn *evev)
     }
 
     evev->waiting = 1;
-    LIBXL_LIST_INSERT_HEAD(&CTX->evtchns_waiting, evev, entry);
+    XEN_LIST_INSERT_HEAD(&CTX->evtchns_waiting, evev, entry);
     return 0;
 
  out:
@@ -1020,7 +1019,7 @@ void libxl__ev_evtchn_cancel(libxl__gc *gc, libxl__ev_evtchn *evev)
         return;
 
     evev->waiting = 0;
-    LIBXL_LIST_REMOVE(evev, entry);
+    XEN_LIST_REMOVE(evev, entry);
     evtchn_check_fd_deregister(gc);
 }
 
@@ -1095,7 +1094,7 @@ int libxl__ev_devstate_wait(libxl__ao *ao, libxl__ev_devstate *ds,
 
 void libxl__ev_immediate_register(libxl__egc *egc, libxl__ev_immediate *ei)
 {
-    LIBXL_STAILQ_INSERT_TAIL(&egc->ev_immediates, ei, entry);
+    XEN_STAILQ_INSERT_TAIL(&egc->ev_immediates, ei, entry);
 }
 
 /*
@@ -1221,7 +1220,7 @@ static int beforepoll_internal(libxl__gc *gc, libxl__poller *poller,
 
 #define REQUIRE_FDS(BODY) do{                                          \
                                                                        \
-        LIBXL_LIST_FOREACH(efd, &CTX->efds, entry)                     \
+        XEN_LIST_FOREACH(efd, &CTX->efds, entry)                       \
             REQUIRE_FD(efd->fd, efd->events, BODY);                    \
                                                                        \
         REQUIRE_FD(poller->wakeup_pipe[0], POLLIN, BODY);              \
@@ -1298,7 +1297,7 @@ static int beforepoll_internal(libxl__gc *gc, libxl__poller *poller,
     poller->fds_deregistered = 0;
     poller->osevents_added = 0;
 
-    libxl__ev_time *etime = LIBXL_TAILQ_FIRST(&CTX->etimes);
+    libxl__ev_time *etime = XEN_TAILQ_FIRST(&CTX->etimes);
     if (etime) {
         int our_timeout;
         struct timeval rel;
@@ -1436,7 +1435,7 @@ static void afterpoll_internal(libxl__egc *egc, libxl__poller *poller,
          * so that we don't call the same function again. */
         int revents;
 
-        LIBXL_LIST_FOREACH(efd, &CTX->efds, entry) {
+        XEN_LIST_FOREACH(efd, &CTX->efds, entry) {
 
             if (!efd->events)
                 continue;
@@ -1454,7 +1453,7 @@ static void afterpoll_internal(libxl__egc *egc, libxl__poller *poller,
     }
 
     for (;;) {
-        libxl__ev_time *etime = LIBXL_TAILQ_FIRST(&CTX->etimes);
+        libxl__ev_time *etime = XEN_TAILQ_FIRST(&CTX->etimes);
         if (!etime)
             break;
 
@@ -1494,8 +1493,8 @@ void libxl_osevent_register_hooks(libxl_ctx *ctx,
 {
     GC_INIT(ctx);
     CTX_LOCK;
-    assert(LIBXL_LIST_EMPTY(&ctx->efds));
-    assert(LIBXL_TAILQ_EMPTY(&ctx->etimes));
+    assert(XEN_LIST_EMPTY(&ctx->efds));
+    assert(XEN_TAILQ_EMPTY(&ctx->etimes));
     ctx->osevent_hooks = hooks;
     ctx->osevent_user = user;
     CTX_UNLOCK;
@@ -1534,7 +1533,7 @@ void libxl_osevent_occurred_timeout(libxl_ctx *ctx, void *for_libxl)
     if (!ev) goto out;
     assert(!ev->infinite);
 
-    LIBXL_TAILQ_REMOVE(&CTX->etimes, ev, entry);
+    XEN_TAILQ_REMOVE(&CTX->etimes, ev, entry);
 
     time_occurs(egc, ev, ERROR_TIMEDOUT);
 
@@ -1577,9 +1576,9 @@ static void egc_run_callbacks(libxl__egc *egc)
     libxl__aop_occurred *aop, *aop_tmp;
     libxl__ev_immediate *ei;
 
-    while (!LIBXL_STAILQ_EMPTY(&egc->ev_immediates)) {
-        ei = LIBXL_STAILQ_FIRST(&egc->ev_immediates);
-        LIBXL_STAILQ_REMOVE_HEAD(&egc->ev_immediates, entry);
+    while (!XEN_STAILQ_EMPTY(&egc->ev_immediates)) {
+        ei = XEN_STAILQ_FIRST(&egc->ev_immediates);
+        XEN_STAILQ_REMOVE_HEAD(&egc->ev_immediates, entry);
         CTX_LOCK;
         /* This callback is internal to libxl and expects CTX to be
          * locked. */
@@ -1587,15 +1586,15 @@ static void egc_run_callbacks(libxl__egc *egc)
         CTX_UNLOCK;
     }
 
-    LIBXL_TAILQ_FOREACH_SAFE(ev, &egc->occurred_for_callback, link, ev_tmp) {
-        LIBXL_TAILQ_REMOVE(&egc->occurred_for_callback, ev, link);
+    XEN_TAILQ_FOREACH_SAFE(ev, &egc->occurred_for_callback, link, ev_tmp) {
+        XEN_TAILQ_REMOVE(&egc->occurred_for_callback, ev, link);
         LOG(DEBUG,"event %p callback type=%s",
             ev, libxl_event_type_to_string(ev->type));
         CTX->event_hooks->event_occurs(CTX->event_hooks_user, ev);
     }
 
-    LIBXL_TAILQ_FOREACH_SAFE(aop, &egc->aops_for_callback, entry, aop_tmp) {
-        LIBXL_TAILQ_REMOVE(&egc->aops_for_callback, aop, entry);
+    XEN_TAILQ_FOREACH_SAFE(aop, &egc->aops_for_callback, entry, aop_tmp) {
+        XEN_TAILQ_REMOVE(&egc->aops_for_callback, aop, entry);
         LOG(DEBUG,"ao %p: progress report: callback aop=%p", aop->ao, aop);
         aop->how->callback(CTX, aop->ev, aop->how->for_callback);
 
@@ -1607,9 +1606,9 @@ static void egc_run_callbacks(libxl__egc *egc)
     }
 
     libxl__ao *ao, *ao_tmp;
-    LIBXL_TAILQ_FOREACH_SAFE(ao, &egc->aos_for_callback,
-                             entry_for_callback, ao_tmp) {
-        LIBXL_TAILQ_REMOVE(&egc->aos_for_callback, ao, entry_for_callback);
+    XEN_TAILQ_FOREACH_SAFE(ao, &egc->aos_for_callback,
+                           entry_for_callback, ao_tmp) {
+        XEN_TAILQ_REMOVE(&egc->aos_for_callback, ao, entry_for_callback);
         LOG(DEBUG,"ao %p: completion callback", ao);
         ao->how.callback(CTX, ao->rc, ao->how.u.for_callback);
         CTX_LOCK;
@@ -1648,12 +1647,12 @@ void libxl__event_occurred(libxl__egc *egc, libxl_event *event)
          * from libxl.  This helps avoid reentrancy bugs: parts of
          * libxl that call libxl__event_occurred do not have to worry
          * that libxl might be reentered at that point. */
-        LIBXL_TAILQ_INSERT_TAIL(&egc->occurred_for_callback, event, link);
+        XEN_TAILQ_INSERT_TAIL(&egc->occurred_for_callback, event, link);
         return;
     } else {
         libxl__poller *poller;
-        LIBXL_TAILQ_INSERT_TAIL(&CTX->occurred, event, link);
-        LIBXL_LIST_FOREACH(poller, &CTX->pollers_event, entry)
+        XEN_TAILQ_INSERT_TAIL(&CTX->occurred, event, link);
+        XEN_LIST_FOREACH(poller, &CTX->pollers_event, entry)
             libxl__poller_wakeup(gc, poller);
     }
 }
@@ -1691,7 +1690,7 @@ static int event_check_internal(libxl__egc *egc, libxl_event **event_r,
     libxl_event *ev;
     int rc;
 
-    LIBXL_TAILQ_FOREACH(ev, &CTX->occurred, link) {
+    XEN_TAILQ_FOREACH(ev, &CTX->occurred, link) {
         if (!(typemask & ((uint64_t)1 << ev->type)))
             continue;
 
@@ -1699,7 +1698,7 @@ static int event_check_internal(libxl__egc *egc, libxl_event **event_r,
             continue;
 
         /* got one! */
-        LIBXL_TAILQ_REMOVE(&CTX->occurred, ev, link);
+        XEN_TAILQ_REMOVE(&CTX->occurred, ev, link);
         *event_r = ev;
         rc = 0;
         goto out;
@@ -1820,9 +1819,9 @@ libxl__poller *libxl__poller_get(libxl__gc *gc)
     /* must be called with ctx locked */
     int rc;
 
-    libxl__poller *p = LIBXL_LIST_FIRST(&CTX->pollers_idle);
+    libxl__poller *p = XEN_LIST_FIRST(&CTX->pollers_idle);
     if (p) {
-        LIBXL_LIST_REMOVE(p, entry);
+        XEN_LIST_REMOVE(p, entry);
     } else {
         p = libxl__zalloc(NOGC, sizeof(*p));
 
@@ -1833,16 +1832,15 @@ libxl__poller *libxl__poller_get(libxl__gc *gc)
         }
     }
 
-    LIBXL_LIST_INSERT_HEAD(&CTX->pollers_active, p,
-                           active_entry);
+    XEN_LIST_INSERT_HEAD(&CTX->pollers_active, p, active_entry);
     return p;
 }
 
 void libxl__poller_put(libxl_ctx *ctx, libxl__poller *p)
 {
     if (!p) return;
-    LIBXL_LIST_REMOVE(p, active_entry);
-    LIBXL_LIST_INSERT_HEAD(&ctx->pollers_idle, p, entry);
+    XEN_LIST_REMOVE(p, active_entry);
+    XEN_LIST_INSERT_HEAD(&ctx->pollers_idle, p, entry);
 }
 
 void libxl__poller_wakeup(libxl__gc *gc, libxl__poller *p)
@@ -2048,7 +2046,7 @@ void libxl__ao_create_fail(libxl__ao *ao)
     assert(!ao->complete);
     assert(!ao->progress_reports_outstanding);
     assert(!ao->aborting);
-    LIBXL_LIST_REMOVE(ao, inprogress_entry);
+    XEN_LIST_REMOVE(ao, inprogress_entry);
     libxl__ao__destroy(CTX, ao);
 }
 
@@ -2070,7 +2068,7 @@ void libxl__ao_complete(libxl__egc *egc, libxl__ao *ao, int rc)
     assert(!ao->nested_progeny);
     ao->complete = 1;
     ao->rc = rc;
-    LIBXL_LIST_REMOVE(ao, inprogress_entry);
+    XEN_LIST_REMOVE(ao, inprogress_entry);
     if (ao->outstanding_killed_child)
         LOG(DEBUG, "ao %p: .. but waiting for %d fork to exit",
             ao, ao->outstanding_killed_child);
@@ -2107,7 +2105,7 @@ void libxl__ao_complete_check_progress_reports(libxl__egc *egc, libxl__ao *ao)
             libxl__poller_wakeup(gc, ao->poller);
     } else if (ao->how.callback) {
         LOG(DEBUG, "ao %p: complete for callback", ao);
-        LIBXL_TAILQ_INSERT_TAIL(&egc->aos_for_callback, ao, entry_for_callback);
+        XEN_TAILQ_INSERT_TAIL(&egc->aos_for_callback, ao, entry_for_callback);
     } else {
         libxl_event *ev;
         ev = NEW_EVENT(egc, OPERATION_COMPLETE, ao->domid, ao->how.u.for_event);
@@ -2148,7 +2146,7 @@ libxl__ao *libxl__ao_create(libxl_ctx *ctx, uint32_t domid,
                "ao %p: create: how=%p callback=%p poller=%p",
                ao, how, ao->how.callback, ao->poller);
 
-    LIBXL_LIST_INSERT_HEAD(&ctx->aos_inprogress, ao, inprogress_entry);
+    XEN_LIST_INSERT_HEAD(&ctx->aos_inprogress, ao, inprogress_entry);
 
     return ao;
 
@@ -2255,7 +2253,7 @@ static int ao__abort(libxl_ctx *ctx, libxl__ao *parent)
 
     parent->aborting = 1;
 
-    if (LIBXL_LIST_EMPTY(&parent->abortables)) {
+    if (XEN_LIST_EMPTY(&parent->abortables)) {
         LIBXL__LOG(ctx, LIBXL__LOG_DEBUG,
                    "ao %p: abort requested and noted, but no-one interested",
                    parent);
@@ -2264,13 +2262,13 @@ static int ao__abort(libxl_ctx *ctx, libxl__ao *parent)
     }
 
     /* We keep calling abort hooks until there are none left */
-    while (!LIBXL_LIST_EMPTY(&parent->abortables)) {
+    while (!XEN_LIST_EMPTY(&parent->abortables)) {
         assert(!parent->complete);
 
-        libxl__ao_abortable *abrt = LIBXL_LIST_FIRST(&parent->abortables);
+        libxl__ao_abortable *abrt = XEN_LIST_FIRST(&parent->abortables);
         assert(parent == ao_nested_root(abrt->ao));
 
-        LIBXL_LIST_REMOVE(abrt, entry);
+        XEN_LIST_REMOVE(abrt, entry);
         abrt->registered = 0;
 
         LIBXL__LOG(ctx, LIBXL__LOG_DEBUG,
@@ -2300,7 +2298,7 @@ int libxl_ao_abort(libxl_ctx *ctx, const libxl_asyncop_how *how)
     libxl__ctx_lock(ctx);
     int rc;
 
-    LIBXL_LIST_FOREACH(search, &ctx->aos_inprogress, inprogress_entry) {
+    XEN_LIST_FOREACH(search, &ctx->aos_inprogress, inprogress_entry) {
         if (how) {
             /* looking for ao to be reported by callback or event */
             if (search->poller)
@@ -2356,7 +2354,7 @@ int libxl__ao_abortable_register(libxl__ao_abortable *abrt)
     }
 
     DBG("ao=%p, abrt=%p: registering (root=%p)", ao, abrt, root);
-    LIBXL_LIST_INSERT_HEAD(&root->abortables, abrt, entry);
+    XEN_LIST_INSERT_HEAD(&root->abortables, abrt, entry);
     abrt->registered = 1;
 
     return 0;
@@ -2372,7 +2370,7 @@ _hidden void libxl__ao_abortable_deregister(libxl__ao_abortable *abrt)
     AO_GC;
 
     DBG("ao=%p, abrt=%p: deregistering (root=%p)", ao, abrt, root);
-    LIBXL_LIST_REMOVE(abrt, entry);
+    XEN_LIST_REMOVE(abrt, entry);
     abrt->registered = 0;
 }
 
@@ -2408,7 +2406,7 @@ void libxl__ao_progress_report(libxl__egc *egc, libxl__ao *ao,
         aop->ao = ao;
         aop->ev = ev;
         aop->how = how;
-        LIBXL_TAILQ_INSERT_TAIL(&egc->aops_for_callback, aop, entry);
+        XEN_TAILQ_INSERT_TAIL(&egc->aops_for_callback, aop, entry);
         LOG(DEBUG,"ao %p: progress report: callback queued aop=%p",ao,aop);
     } else {
         LOG(DEBUG,"ao %p: progress report: event queued ev=%p type=%s",
diff --git a/tools/libs/light/libxl_fork.c b/tools/libs/light/libxl_fork.c
index 5d47dceb8a..676a14bb28 100644
--- a/tools/libs/light/libxl_fork.c
+++ b/tools/libs/light/libxl_fork.c
@@ -37,14 +37,14 @@
  */
 
 struct libxl__carefd {
-    LIBXL_LIST_ENTRY(libxl__carefd) entry;
+    XEN_LIST_ENTRY(libxl__carefd) entry;
     int fd;
 };
 
 static pthread_mutex_t no_forking = PTHREAD_MUTEX_INITIALIZER;
 static int atfork_registered;
-static LIBXL_LIST_HEAD(, libxl__carefd) carefds =
-    LIBXL_LIST_HEAD_INITIALIZER(carefds);
+static XEN_LIST_HEAD(, libxl__carefd) carefds =
+    XEN_LIST_HEAD_INITIALIZER(carefds);
 
 /* Protected against concurrency by no_forking.  sigchld_users is
  * protected against being interrupted by SIGCHLD (and thus read
@@ -52,8 +52,8 @@ static LIBXL_LIST_HEAD(, libxl__carefd) carefds =
  * below). */
 static bool sigchld_installed; /* 0 means not */
 static pthread_mutex_t sigchld_defer_mutex = PTHREAD_MUTEX_INITIALIZER;
-static LIBXL_LIST_HEAD(, libxl_ctx) sigchld_users =
-    LIBXL_LIST_HEAD_INITIALIZER(sigchld_users);
+static XEN_LIST_HEAD(, libxl_ctx) sigchld_users =
+    XEN_LIST_HEAD_INITIALIZER(sigchld_users);
 static struct sigaction sigchld_saved_action;
 
 static void sigchld_removehandler_core(void); /* idempotent */
@@ -105,7 +105,7 @@ libxl__carefd *libxl__carefd_record(libxl_ctx *ctx, int fd)
     libxl_fd_set_cloexec(ctx, fd, 1);
     cf = libxl__zalloc(&ctx->nogc_gc, sizeof(*cf));
     cf->fd = fd;
-    LIBXL_LIST_INSERT_HEAD(&carefds, cf, entry);
+    XEN_LIST_INSERT_HEAD(&carefds, cf, entry);
     return cf;
 }
 
@@ -141,7 +141,7 @@ void libxl_postfork_child_noexec(libxl_ctx *ctx)
 
     atfork_lock();
 
-    LIBXL_LIST_FOREACH_SAFE(cf, &carefds, entry, cf_tmp) {
+    XEN_LIST_FOREACH_SAFE(cf, &carefds, entry, cf_tmp) {
         if (cf->fd >= 0) {
             r = close(cf->fd);
             if (r)
@@ -151,7 +151,7 @@ void libxl_postfork_child_noexec(libxl_ctx *ctx)
         }
         free(cf);
     }
-    LIBXL_LIST_INIT(&carefds);
+    XEN_LIST_INIT(&carefds);
 
     if (sigchld_installed) {
         /* We are in theory not at risk of concurrent execution of the
@@ -172,7 +172,7 @@ void libxl_postfork_child_noexec(libxl_ctx *ctx)
          * use SIGCHLD, but instead just waits for the child(ren). */
         defer_sigchld();
 
-        LIBXL_LIST_INIT(&sigchld_users);
+        XEN_LIST_INIT(&sigchld_users);
         /* After this the ->sigchld_user_registered entries in the
          * now-obsolete contexts may be lies.  But that's OK because
          * no-one will look at them. */
@@ -190,7 +190,7 @@ int libxl__carefd_close(libxl__carefd *cf)
     atfork_lock();
     int r = cf->fd < 0 ? 0 : close(cf->fd);
     int esave = errno;
-    LIBXL_LIST_REMOVE(cf, entry);
+    XEN_LIST_REMOVE(cf, entry);
     atfork_unlock();
     free(cf);
     errno = esave;
@@ -238,7 +238,7 @@ static void sigchld_handler(int signo)
     int r = pthread_mutex_lock(&sigchld_defer_mutex);
     assert(!r);
 
-    LIBXL_LIST_FOREACH(notify, &sigchld_users, sigchld_users_entry) {
+    XEN_LIST_FOREACH(notify, &sigchld_users, sigchld_users_entry) {
         int e = libxl__self_pipe_wakeup(notify->sigchld_selfpipe[1]);
         if (e) abort(); /* errors are probably EBADF, very bad */
     }
@@ -362,11 +362,11 @@ static void sigchld_user_remove(libxl_ctx *ctx) /* idempotent */
     atfork_lock();
     defer_sigchld();
 
-    LIBXL_LIST_REMOVE(ctx, sigchld_users_entry);
+    XEN_LIST_REMOVE(ctx, sigchld_users_entry);
 
     release_sigchld();
 
-    if (LIBXL_LIST_EMPTY(&sigchld_users))
+    if (XEN_LIST_EMPTY(&sigchld_users))
         sigchld_removehandler_core();
 
     atfork_unlock();
@@ -404,7 +404,7 @@ int libxl__sigchld_needed(libxl__gc *gc) /* non-reentrant, idempotent */
 
         defer_sigchld();
 
-        LIBXL_LIST_INSERT_HEAD(&sigchld_users, CTX, sigchld_users_entry);
+        XEN_LIST_INSERT_HEAD(&sigchld_users, CTX, sigchld_users_entry);
 
         release_sigchld();
         atfork_unlock();
@@ -421,7 +421,7 @@ static bool chldmode_ours(libxl_ctx *ctx, bool creating)
 {
     switch (ctx->childproc_hooks->chldowner) {
     case libxl_sigchld_owner_libxl:
-        return creating || !LIBXL_LIST_EMPTY(&ctx->children);
+        return creating || !XEN_LIST_EMPTY(&ctx->children);
     case libxl_sigchld_owner_mainloop:
         return 0;
     case libxl_sigchld_owner_libxl_always:
@@ -452,7 +452,7 @@ static void childproc_reaped_ours(libxl__egc *egc, libxl__ev_child *ch,
                                  int status)
 {
     pid_t pid = ch->pid;
-    LIBXL_LIST_REMOVE(ch, entry);
+    XEN_LIST_REMOVE(ch, entry);
     ch->pid = -1;
     ch->callback(egc, ch, pid, status);
 }
@@ -462,7 +462,7 @@ static int childproc_reaped(libxl__egc *egc, pid_t pid, int status)
     EGC_GC;
     libxl__ev_child *ch;
 
-    LIBXL_LIST_FOREACH(ch, &CTX->children, entry)
+    XEN_LIST_FOREACH(ch, &CTX->children, entry)
         if (ch->pid == pid)
             goto found;
 
@@ -497,7 +497,7 @@ static void childproc_checkall(libxl__egc *egc)
         int status;
         pid_t got;
 
-        LIBXL_LIST_FOREACH(ch, &CTX->children, entry) {
+        XEN_LIST_FOREACH(ch, &CTX->children, entry) {
             got = checked_waitpid(egc, ch->pid, &status);
             if (got)
                 goto found;
@@ -625,7 +625,7 @@ pid_t libxl__ev_child_fork(libxl__gc *gc, libxl__ev_child *ch,
 
     ch->pid = pid;
     ch->callback = death;
-    LIBXL_LIST_INSERT_HEAD(&CTX->children, ch, entry);
+    XEN_LIST_INSERT_HEAD(&CTX->children, ch, entry);
     rc = pid;
 
  out:
@@ -640,7 +640,7 @@ void libxl_childproc_setmode(libxl_ctx *ctx, const libxl_childproc_hooks *hooks,
     GC_INIT(ctx);
     CTX_LOCK;
 
-    assert(LIBXL_LIST_EMPTY(&CTX->children));
+    assert(XEN_LIST_EMPTY(&CTX->children));
 
     if (!hooks)
         hooks = &libxl__childproc_default_hooks;
@@ -698,10 +698,10 @@ void libxl__ev_child_kill_deregister(libxl__ao *ao, libxl__ev_child *ch,
     new_ch->ao = ao;
     new_ch->ch.pid = pid;
     new_ch->ch.callback = deregistered_child_callback;
-    LIBXL_LIST_INSERT_HEAD(&CTX->children, &new_ch->ch, entry);
+    XEN_LIST_INSERT_HEAD(&CTX->children, &new_ch->ch, entry);
     ao->outstanding_killed_child++;
 
-    LIBXL_LIST_REMOVE(ch, entry);
+    XEN_LIST_REMOVE(ch, entry);
     ch->pid = -1;
     int r = kill(pid, sig);
     if (r)
diff --git a/tools/libs/light/libxl_internal.h b/tools/libs/light/libxl_internal.h
index 37d5c27756..c0e7779d97 100644
--- a/tools/libs/light/libxl_internal.h
+++ b/tools/libs/light/libxl_internal.h
@@ -245,7 +245,7 @@ struct libxl__ev_fd {
     short events;
     libxl__ev_fd_callback *func;
     /* remainder is private for libxl__ev_fd... */
-    LIBXL_LIST_ENTRY(libxl__ev_fd) entry;
+    XEN_LIST_ENTRY(libxl__ev_fd) entry;
     libxl__osevent_hook_nexus *nexus;
 };
 
@@ -260,7 +260,7 @@ struct libxl__ao_abortable {
     libxl__ao_abortable_callback *callback;
     /* remainder is private for abort machinery */
     bool registered;
-    LIBXL_LIST_ENTRY(libxl__ao_abortable) entry;
+    XEN_LIST_ENTRY(libxl__ao_abortable) entry;
     /*
      * For nested aos:
      *  Semantically, abort affects the whole tree of aos,
@@ -296,7 +296,7 @@ struct libxl__ev_time {
     libxl__ev_time_callback *func;
     /* remainder is private for libxl__ev_time... */
     int infinite; /* not registered in list or with app if infinite */
-    LIBXL_TAILQ_ENTRY(libxl__ev_time) entry;
+    XEN_TAILQ_ENTRY(libxl__ev_time) entry;
     struct timeval abs;
     libxl__osevent_hook_nexus *nexus;
     libxl__ao_abortable abrt;
@@ -323,7 +323,7 @@ struct libxl__ev_evtchn {
     int port;
     /* remainder is private for libxl__ev_evtchn_... */
     bool waiting;
-    LIBXL_LIST_ENTRY(libxl__ev_evtchn) entry;
+    XEN_LIST_ENTRY(libxl__ev_evtchn) entry;
 };
 
 /*
@@ -341,7 +341,7 @@ struct libxl__ev_evtchn {
  * xswatch pointers when we store and retrieve them.
  */
 typedef struct libxl__ev_watch_slot {
-    LIBXL_SLIST_ENTRY(struct libxl__ev_watch_slot) empty;
+    XEN_SLIST_ENTRY(struct libxl__ev_watch_slot) empty;
 } libxl__ev_watch_slot;
 
 _hidden libxl__ev_xswatch *libxl__watch_slot_contents(libxl__gc *gc,
@@ -357,7 +357,7 @@ struct libxl__ev_child {
     pid_t pid; /* -1 means unused ("unregistered", ie Idle) */
     libxl__ev_child_callback *callback;
     /* remainder is private for libxl__ev_... */
-    LIBXL_LIST_ENTRY(struct libxl__ev_child) entry;
+    XEN_LIST_ENTRY(struct libxl__ev_child) entry;
 };
 
 /* libxl__ev_immediate
@@ -370,7 +370,7 @@ struct libxl__ev_immediate {
     /* filled by user */
     void (*callback)(libxl__egc *, libxl__ev_immediate *);
     /* private to libxl__ev_immediate */
-    LIBXL_STAILQ_ENTRY(libxl__ev_immediate) entry;
+    XEN_STAILQ_ENTRY(libxl__ev_immediate) entry;
 };
 void libxl__ev_immediate_register(libxl__egc *, libxl__ev_immediate *);
 
@@ -582,7 +582,7 @@ _hidden void libxl__qmp_param_add_integer(libxl__gc *gc,
 struct libxl__evgen_domain_death {
     uint32_t domid;
     unsigned shutdown_reported:1, death_reported:1;
-    LIBXL_TAILQ_ENTRY(libxl_evgen_domain_death) entry;
+    XEN_TAILQ_ENTRY(libxl_evgen_domain_death) entry;
         /* on list .death_reported ? CTX->death_list : CTX->death_reported */
     libxl_ev_user user;
 };
@@ -592,7 +592,7 @@ libxl__evdisable_domain_death(libxl__gc*, libxl_evgen_domain_death*);
 struct libxl__evgen_disk_eject {
     libxl__ev_xswatch watch;
     uint32_t domid;
-    LIBXL_LIST_ENTRY(libxl_evgen_disk_eject) entry;
+    XEN_LIST_ENTRY(libxl_evgen_disk_eject) entry;
     libxl_ev_user user;
     char *vdev, *be_ptr_path;
 };
@@ -620,7 +620,7 @@ struct libxl__poller {
      * The "poller_app" is never idle, but is sometimes on
      * pollers_event.
      */
-    LIBXL_LIST_ENTRY(libxl__poller) entry;
+    XEN_LIST_ENTRY(libxl__poller) entry;
 
     struct pollfd *fd_polls;
     int fd_polls_allocd;
@@ -653,7 +653,7 @@ struct libxl__poller {
      * a promise to also make this check, so the baton will never be
      * dropped.
      */
-    LIBXL_LIST_ENTRY(libxl__poller) active_entry;
+    XEN_LIST_ENTRY(libxl__poller) active_entry;
     bool fds_deregistered;
     bool osevents_added;
 };
@@ -687,7 +687,7 @@ struct libxl__ctx {
        * documented in the libxl public interface.
        */
 
-    LIBXL_TAILQ_HEAD(libxl__event_list, libxl_event) occurred;
+    XEN_TAILQ_HEAD(libxl__event_list, libxl_event) occurred;
 
     int osevent_in_hook;
     const libxl_osevent_hooks *osevent_hooks;
@@ -696,40 +696,40 @@ struct libxl__ctx {
        * for restrictions on the use of the osevent fields. */
 
     libxl__poller *poller_app; /* libxl_osevent_beforepoll and _afterpoll */
-    LIBXL_LIST_HEAD(, libxl__poller) pollers_event, pollers_idle;
-    LIBXL_LIST_HEAD(, libxl__poller) pollers_active;
+    XEN_LIST_HEAD(, libxl__poller) pollers_event, pollers_idle;
+    XEN_LIST_HEAD(, libxl__poller) pollers_active;
 
-    LIBXL_SLIST_HEAD(libxl__osevent_hook_nexi, libxl__osevent_hook_nexus)
+    XEN_SLIST_HEAD(libxl__osevent_hook_nexi, libxl__osevent_hook_nexus)
         hook_fd_nexi_idle, hook_timeout_nexi_idle;
-    LIBXL_LIST_HEAD(, libxl__ev_fd) efds;
-    LIBXL_TAILQ_HEAD(, libxl__ev_time) etimes;
+    XEN_LIST_HEAD(, libxl__ev_fd) efds;
+    XEN_TAILQ_HEAD(, libxl__ev_time) etimes;
 
     libxl__ev_watch_slot *watch_slots;
     int watch_nslots, nwatches;
-    LIBXL_SLIST_HEAD(, libxl__ev_watch_slot) watch_freeslots;
+    XEN_SLIST_HEAD(, libxl__ev_watch_slot) watch_freeslots;
     uint32_t watch_counter; /* helps disambiguate slot reuse */
     libxl__ev_fd watch_efd;
 
     xenevtchn_handle *xce; /* waiting must be done only with libxl__ev_evtchn* */
-    LIBXL_LIST_HEAD(, libxl__ev_evtchn) evtchns_waiting;
+    XEN_LIST_HEAD(, libxl__ev_evtchn) evtchns_waiting;
     libxl__ev_fd evtchn_efd;
 
-    LIBXL_LIST_HEAD(, libxl__ao) aos_inprogress;
+    XEN_LIST_HEAD(, libxl__ao) aos_inprogress;
 
-    LIBXL_TAILQ_HEAD(libxl__evgen_domain_death_list, libxl_evgen_domain_death)
+    XEN_TAILQ_HEAD(libxl__evgen_domain_death_list, libxl_evgen_domain_death)
         death_list /* sorted by domid */,
         death_reported;
     libxl__ev_xswatch death_watch;
 
-    LIBXL_LIST_HEAD(, libxl_evgen_disk_eject) disk_eject_evgens;
+    XEN_LIST_HEAD(, libxl_evgen_disk_eject) disk_eject_evgens;
 
     const libxl_childproc_hooks *childproc_hooks;
     void *childproc_user;
     int sigchld_selfpipe[2]; /* [0]==-1 means handler not installed */
     libxl__ev_fd sigchld_selfpipe_efd;
-    LIBXL_LIST_HEAD(, libxl__ev_child) children;
+    XEN_LIST_HEAD(, libxl__ev_child) children;
     bool sigchld_user_registered;
-    LIBXL_LIST_ENTRY(libxl_ctx) sigchld_users_entry;
+    XEN_LIST_ENTRY(libxl_ctx) sigchld_users_entry;
 
     libxl_version_info version_info;
 
@@ -774,9 +774,9 @@ struct libxl__egc {
      * The egc and its gc may be accessed only on the creating thread. */
     struct libxl__gc gc;
     struct libxl__event_list occurred_for_callback;
-    LIBXL_TAILQ_HEAD(, libxl__ao) aos_for_callback;
-    LIBXL_TAILQ_HEAD(, libxl__aop_occurred) aops_for_callback;
-    LIBXL_STAILQ_HEAD(, libxl__ev_immediate) ev_immediates;
+    XEN_TAILQ_HEAD(, libxl__ao) aos_for_callback;
+    XEN_TAILQ_HEAD(, libxl__aop_occurred) aops_for_callback;
+    XEN_STAILQ_HEAD(, libxl__ev_immediate) ev_immediates;
 };
 
 struct libxl__aop_occurred {
@@ -787,7 +787,7 @@ struct libxl__aop_occurred {
      * While an aop exists, it corresponds to one refcount in
      * ao->progress_reports_outstanding, preventing ao destruction.
      */
-    LIBXL_TAILQ_ENTRY(libxl__aop_occurred) entry;
+    XEN_TAILQ_ENTRY(libxl__aop_occurred) entry;
     libxl__ao *ao;
     libxl_event *ev;
     const libxl_asyncprogress_how *how;
@@ -819,13 +819,13 @@ struct libxl__ao {
     int nested_progeny;
     int progress_reports_outstanding;
     int rc;
-    LIBXL_LIST_HEAD(, libxl__ao_abortable) abortables;
-    LIBXL_LIST_ENTRY(libxl__ao) inprogress_entry;
+    XEN_LIST_HEAD(, libxl__ao_abortable) abortables;
+    XEN_LIST_ENTRY(libxl__ao) inprogress_entry;
     libxl__gc gc;
     libxl_asyncop_how how;
     libxl__poller *poller;
     uint32_t domid;
-    LIBXL_TAILQ_ENTRY(libxl__ao) entry_for_callback;
+    XEN_TAILQ_ENTRY(libxl__ao) entry_for_callback;
     int outstanding_killed_child;
 };
 
@@ -2379,10 +2379,10 @@ bool libxl__stubdomain_is_linux(libxl_domain_build_info *b_info)
 
 #define LIBXL_INIT_EGC(egc,ctx) do{                     \
         LIBXL_INIT_GC((egc).gc,ctx);                    \
-        LIBXL_TAILQ_INIT(&(egc).occurred_for_callback); \
-        LIBXL_TAILQ_INIT(&(egc).aos_for_callback);      \
-        LIBXL_TAILQ_INIT(&(egc).aops_for_callback);     \
-        LIBXL_STAILQ_INIT(&(egc).ev_immediates);        \
+        XEN_TAILQ_INIT(&(egc).occurred_for_callback);   \
+        XEN_TAILQ_INIT(&(egc).aos_for_callback);        \
+        XEN_TAILQ_INIT(&(egc).aops_for_callback);       \
+        XEN_STAILQ_INIT(&(egc).ev_immediates);          \
     } while(0)
 
 _hidden void libxl__egc_ao_cleanup_1_baton(libxl__gc *gc);
@@ -3141,7 +3141,7 @@ typedef void libxl__datacopier_callback(libxl__egc *egc,
 
 struct libxl__datacopier_buf {
     /* private to datacopier */
-    LIBXL_TAILQ_ENTRY(libxl__datacopier_buf) entry;
+    XEN_TAILQ_ENTRY(libxl__datacopier_buf) entry;
     int used;
     char buf[1000];
 };
@@ -3163,7 +3163,7 @@ struct libxl__datacopier_state {
     libxl__ao_abortable abrt;
     libxl__ev_fd toread, towrite;
     ssize_t used;
-    LIBXL_TAILQ_HEAD(libxl__datacopier_bufs, libxl__datacopier_buf) bufs;
+    XEN_TAILQ_HEAD(libxl__datacopier_bufs, libxl__datacopier_buf) bufs;
 };
 
 _hidden void libxl__datacopier_init(libxl__datacopier_state *dc);
@@ -3443,7 +3443,7 @@ typedef struct libxl__stream_read_state libxl__stream_read_state;
 
 typedef struct libxl__sr_record_buf {
     /* private to stream read helper */
-    LIBXL_STAILQ_ENTRY(struct libxl__sr_record_buf) entry;
+    XEN_STAILQ_ENTRY(struct libxl__sr_record_buf) entry;
     libxl__sr_rec_hdr hdr;
     void *body; /* iff hdr.length != 0 */
 } libxl__sr_record_buf;
@@ -3473,7 +3473,7 @@ struct libxl__stream_read_state {
     /* Main stream-reading data. */
     libxl__datacopier_state dc; /* Only used when reading a record */
     libxl__sr_hdr hdr;
-    LIBXL_STAILQ_HEAD(, libxl__sr_record_buf) record_queue; /* NOGC */
+    XEN_STAILQ_HEAD(, libxl__sr_record_buf) record_queue; /* NOGC */
     enum {
         SRS_PHASE_NORMAL,
         SRS_PHASE_BUFFERING,
@@ -4599,9 +4599,9 @@ static inline int libxl__defbool_is_default(libxl_defbool *db)
 #define LIBXL_TAILQ_INSERT_SORTED(head, entry, elm_new, elm_search,     \
                                   search_body, new_after_search_p)      \
     do {                                                                \
-        for ((elm_search) = LIBXL_TAILQ_FIRST((head));                  \
+        for ((elm_search) = XEN_TAILQ_FIRST((head));                    \
              (elm_search);                                              \
-             (elm_search) = LIBXL_TAILQ_NEXT((elm_search), entry)) {    \
+             (elm_search) = XEN_TAILQ_NEXT((elm_search), entry)) {      \
             search_body;                                                \
             if (!(new_after_search_p))                                  \
                 break;                                                  \
@@ -4610,9 +4610,9 @@ static inline int libxl__defbool_is_default(libxl_defbool *db)
          * to place elm_new, or NULL meaning we want to put elm_new at  \
          * the end */                                                   \
         if ((elm_search))                                               \
-            LIBXL_TAILQ_INSERT_BEFORE((elm_search), (elm_new), entry);  \
+            XEN_TAILQ_INSERT_BEFORE((elm_search), (elm_new), entry);    \
         else                                                            \
-            LIBXL_TAILQ_INSERT_TAIL((head), (elm_new), entry);          \
+            XEN_TAILQ_INSERT_TAIL((head), (elm_new), entry);            \
     } while(0)
 
 
diff --git a/tools/libs/light/libxl_qmp.c b/tools/libs/light/libxl_qmp.c
index fb146a54cb..8faa102e4d 100644
--- a/tools/libs/light/libxl_qmp.c
+++ b/tools/libs/light/libxl_qmp.c
@@ -63,7 +63,7 @@
 
 #include <yajl/yajl_gen.h>
 
-#include "_libxl_list.h"
+#include "_xen_list.h"
 #include "libxl_internal.h"
 
 /* #define DEBUG_RECEIVED */
@@ -107,7 +107,7 @@ typedef struct callback_id_pair {
     qmp_callback_t callback;
     void *opaque;
     qmp_request_context *context;
-    LIBXL_STAILQ_ENTRY(struct callback_id_pair) next;
+    XEN_STAILQ_ENTRY(struct callback_id_pair) next;
 } callback_id_pair;
 
 struct libxl__qmp_handler {
@@ -123,7 +123,7 @@ struct libxl__qmp_handler {
     uint32_t domid;
 
     int last_id_used;
-    LIBXL_STAILQ_HEAD(callback_list, callback_id_pair) callback_list;
+    XEN_STAILQ_HEAD(callback_list, callback_id_pair) callback_list;
     struct {
         int major;
         int minor;
@@ -189,7 +189,7 @@ static callback_id_pair *qmp_get_callback_from_id(libxl__qmp_handler *qmp,
     if (id_object) {
         id = libxl__json_object_get_integer(id_object);
 
-        LIBXL_STAILQ_FOREACH(pp, &qmp->callback_list, next) {
+        XEN_STAILQ_FOREACH(pp, &qmp->callback_list, next) {
             if (pp->id == id) {
                 return pp;
             }
@@ -217,7 +217,7 @@ static void qmp_handle_error_response(libxl__gc *gc, libxl__qmp_handler *qmp,
             /* tell that the id have been processed */
             qmp->wait_for_id = 0;
         }
-        LIBXL_STAILQ_REMOVE(&qmp->callback_list, pp, callback_id_pair, next);
+        XEN_STAILQ_REMOVE(&qmp->callback_list, pp, callback_id_pair, next);
         free(pp);
     }
 
@@ -266,8 +266,7 @@ static int qmp_handle_response(libxl__gc *gc, libxl__qmp_handler *qmp,
                 /* tell that the id have been processed */
                 qmp->wait_for_id = 0;
             }
-            LIBXL_STAILQ_REMOVE(&qmp->callback_list, pp, callback_id_pair,
-                                next);
+            XEN_STAILQ_REMOVE(&qmp->callback_list, pp, callback_id_pair, next);
             free(pp);
         }
         return 0;
@@ -325,7 +324,7 @@ static libxl__qmp_handler *qmp_init_handler(libxl__gc *gc, uint32_t domid)
     qmp->domid = domid;
     qmp->timeout = 5;
 
-    LIBXL_STAILQ_INIT(&qmp->callback_list);
+    XEN_STAILQ_INIT(&qmp->callback_list);
 
     return qmp;
 }
@@ -383,7 +382,7 @@ static void qmp_close(libxl__qmp_handler *qmp)
     callback_id_pair *tmp = NULL;
 
     close(qmp->qmp_fd);
-    LIBXL_STAILQ_FOREACH(pp, &qmp->callback_list, next) {
+    XEN_STAILQ_FOREACH(pp, &qmp->callback_list, next) {
         free(tmp);
         tmp = pp;
     }
@@ -547,7 +546,7 @@ static char *qmp_send_prepare(libxl__gc *gc, libxl__qmp_handler *qmp,
     elm->callback = callback;
     elm->opaque = opaque;
     elm->context = context;
-    LIBXL_STAILQ_INSERT_TAIL(&qmp->callback_list, elm, next);
+    XEN_STAILQ_INSERT_TAIL(&qmp->callback_list, elm, next);
 
     LOGD(DEBUG, qmp->domid, "next qmp command: '%s'", buf);
 
diff --git a/tools/libs/light/libxl_stream_read.c b/tools/libs/light/libxl_stream_read.c
index 99a6714e76..e64e8f0ead 100644
--- a/tools/libs/light/libxl_stream_read.c
+++ b/tools/libs/light/libxl_stream_read.c
@@ -214,7 +214,7 @@ void libxl__stream_read_init(libxl__stream_read_state *stream)
     stream->sync_teardown = false;
     FILLZERO(stream->dc);
     FILLZERO(stream->hdr);
-    LIBXL_STAILQ_INIT(&stream->record_queue);
+    XEN_STAILQ_INIT(&stream->record_queue);
     stream->phase = SRS_PHASE_NORMAL;
     stream->recursion_guard = false;
     stream->incoming_record = NULL;
@@ -402,7 +402,7 @@ static void stream_continue(libxl__egc *egc,
          * processing the record.  There should never be two records
          * in the queue.
          */
-        if (LIBXL_STAILQ_EMPTY(&stream->record_queue))
+        if (XEN_STAILQ_EMPTY(&stream->record_queue))
             setup_read_record(egc, stream);
         else {
             if (process_record(egc, stream))
@@ -412,7 +412,7 @@ static void stream_continue(libxl__egc *egc,
              * process_record() had better have consumed the one and
              * only record in the queue.
              */
-            assert(LIBXL_STAILQ_EMPTY(&stream->record_queue));
+            assert(XEN_STAILQ_EMPTY(&stream->record_queue));
         }
         break;
 
@@ -428,7 +428,7 @@ static void stream_continue(libxl__egc *egc,
          * the tail to spot the CHECKPOINT_END record, and switch to
          * the unbuffering phase.
          */
-        libxl__sr_record_buf *rec = LIBXL_STAILQ_LAST(
+        libxl__sr_record_buf *rec = XEN_STAILQ_LAST(
             &stream->record_queue, libxl__sr_record_buf, entry);
 
         assert(stream->in_checkpoint);
@@ -537,7 +537,7 @@ static void record_body_done(libxl__egc *egc,
     if (rc)
         goto err;
 
-    LIBXL_STAILQ_INSERT_TAIL(&stream->record_queue, rec, entry);
+    XEN_STAILQ_INSERT_TAIL(&stream->record_queue, rec, entry);
     stream->incoming_record = NULL;
 
     stream_continue(egc, stream);
@@ -567,9 +567,9 @@ static bool process_record(libxl__egc *egc,
     int rc = 0;
 
     /* Pop a record from the head of the queue. */
-    assert(!LIBXL_STAILQ_EMPTY(&stream->record_queue));
-    rec = LIBXL_STAILQ_FIRST(&stream->record_queue);
-    LIBXL_STAILQ_REMOVE_HEAD(&stream->record_queue, entry);
+    assert(!XEN_STAILQ_EMPTY(&stream->record_queue));
+    rec = XEN_STAILQ_FIRST(&stream->record_queue);
+    XEN_STAILQ_REMOVE_HEAD(&stream->record_queue, entry);
 
     LOG(DEBUG, "Record: %u, length %u", rec->hdr.type, rec->hdr.length);
 
@@ -813,9 +813,9 @@ static void stream_done(libxl__egc *egc,
 
     /* The record queue had better be empty if the stream believes
      * itself to have been successful. */
-    assert(LIBXL_STAILQ_EMPTY(&stream->record_queue) || stream->rc);
+    assert(XEN_STAILQ_EMPTY(&stream->record_queue) || stream->rc);
 
-    LIBXL_STAILQ_FOREACH_SAFE(rec, &stream->record_queue, entry, trec)
+    XEN_STAILQ_FOREACH_SAFE(rec, &stream->record_queue, entry, trec)
         free_record(rec);
 
     if (!stream->back_channel) {
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Mon Feb 07 06:41:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 06:41:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266411.460132 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGxip-00049a-01; Mon, 07 Feb 2022 06:41:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266411.460132; Mon, 07 Feb 2022 06:41:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGxio-00047V-OM; Mon, 07 Feb 2022 06:41:58 +0000
Received: by outflank-mailman (input) for mailman id 266411;
 Mon, 07 Feb 2022 06:41:56 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=ddl1=SW=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nGxim-0002yJ-3R
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 06:41:56 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 09122631-87e1-11ec-8f75-fffcc8bd4f1a;
 Mon, 07 Feb 2022 07:41:53 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 09CBB210F6;
 Mon,  7 Feb 2022 06:41:53 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C99E913519;
 Mon,  7 Feb 2022 06:41:52 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id gNrALzC/AGLDUgAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 07 Feb 2022 06:41:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 09122631-87e1-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1644216113; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=9PIRJvROq4WGxqvOvdeBhrJLUoEN4dl0PDZArfMcTVw=;
	b=PAqFmQxT48Qo/a4tQAIbED9+Znoo55B5wo3zh6AZuHZf5TdPaeZhtiBgt7BWl5jjbrme4z
	SEtrIxCZuaJ7Dm7TNT2ey0fLy3EsM66EaVhYm7fAhC0iN0waBW7T/gI5b5/wjugt2wsDkO
	DmhvdYddpz2DaGj8cW6iTOQcamzLuI4=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>
Subject: [PATCH v2 5/5] tools/include: remove xen-external directory
Date: Mon,  7 Feb 2022 07:41:47 +0100
Message-Id: <20220207064147.9585-6-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220207064147.9585-1-jgross@suse.com>
References: <20220207064147.9585-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

There is no user of tools/include/xen-external/* left. Remove it.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 tools/include/xen-external/README             |   24 -
 tools/include/xen-external/bsd-COPYRIGHT      |  126 --
 tools/include/xen-external/bsd-queue.3        | 1044 -----------------
 .../xen-external/bsd-sys-queue-h-seddery      |   74 --
 tools/include/xen-external/bsd-sys-queue.h    |  637 ----------
 5 files changed, 1905 deletions(-)
 delete mode 100644 tools/include/xen-external/README
 delete mode 100644 tools/include/xen-external/bsd-COPYRIGHT
 delete mode 100644 tools/include/xen-external/bsd-queue.3
 delete mode 100755 tools/include/xen-external/bsd-sys-queue-h-seddery
 delete mode 100644 tools/include/xen-external/bsd-sys-queue.h

diff --git a/tools/include/xen-external/README b/tools/include/xen-external/README
deleted file mode 100644
index 93c2bc9cd8..0000000000
--- a/tools/include/xen-external/README
+++ /dev/null
@@ -1,24 +0,0 @@
-WARNING - DO NOT EDIT THINGS IN THIS DIRECTORY
-----------------------------------------------
-
-These files were obtained elsewhere and should only be updated by
-copying new versions from the source location, as documented below:
-
-bsd-COPYRIGHT
-bsd-sys-queue.h
-bsd-queue.3
-
-  Obtained from the FreeBSD SVN using the following commands:
-    svn co -r 221843 svn://svn.freebsd.org/base/head/sys/sys/
-    svn co -r 221843 svn://svn.freebsd.org/base/head/share/man/man3
-    svn cat -r 221843 http://svn.freebsd.org/base/head/COPYRIGHT >tools/libxl/external/bsd-COPYRIGHT
-
-Exceptions:
-
-README
-
-  This file
-
-bsd-sys-queue-h-seddery
-
-  Script to transform the above into a new namespace.
diff --git a/tools/include/xen-external/bsd-COPYRIGHT b/tools/include/xen-external/bsd-COPYRIGHT
deleted file mode 100644
index 6dc5d16b46..0000000000
--- a/tools/include/xen-external/bsd-COPYRIGHT
+++ /dev/null
@@ -1,126 +0,0 @@
-# $FreeBSD$
-#	@(#)COPYRIGHT	8.2 (Berkeley) 3/21/94
-
-The compilation of software known as FreeBSD is distributed under the
-following terms:
-
-Copyright (c) 1992-2011 The FreeBSD Project. All rights reserved.
-
-Redistribution and use in source and binary forms, with or without
-modification, are permitted provided that the following conditions
-are met:
-1. Redistributions of source code must retain the above copyright
-   notice, this list of conditions and the following disclaimer.
-2. Redistributions in binary form must reproduce the above copyright
-   notice, this list of conditions and the following disclaimer in the
-   documentation and/or other materials provided with the distribution.
-
-THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
-ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
-IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
-ARE DISCLAIMED.  IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
-FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
-DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
-OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
-HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
-LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
-OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
-SUCH DAMAGE.
-
-The 4.4BSD and 4.4BSD-Lite software is distributed under the following
-terms:
-
-All of the documentation and software included in the 4.4BSD and 4.4BSD-Lite
-Releases is copyrighted by The Regents of the University of California.
-
-Copyright 1979, 1980, 1983, 1986, 1988, 1989, 1991, 1992, 1993, 1994
-	The Regents of the University of California.  All rights reserved.
-
-Redistribution and use in source and binary forms, with or without
-modification, are permitted provided that the following conditions
-are met:
-1. Redistributions of source code must retain the above copyright
-   notice, this list of conditions and the following disclaimer.
-2. Redistributions in binary form must reproduce the above copyright
-   notice, this list of conditions and the following disclaimer in the
-   documentation and/or other materials provided with the distribution.
-3. All advertising materials mentioning features or use of this software
-   must display the following acknowledgement:
-This product includes software developed by the University of
-California, Berkeley and its contributors.
-4. Neither the name of the University nor the names of its contributors
-   may be used to endorse or promote products derived from this software
-   without specific prior written permission.
-
-THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND
-ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
-IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
-ARE DISCLAIMED.  IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE
-FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
-DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
-OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
-HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
-LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
-OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
-SUCH DAMAGE.
-
-The Institute of Electrical and Electronics Engineers and the American
-National Standards Committee X3, on Information Processing Systems have
-given us permission to reprint portions of their documentation.
-
-In the following statement, the phrase ``this text'' refers to portions
-of the system documentation.
-
-Portions of this text are reprinted and reproduced in electronic form in
-the second BSD Networking Software Release, from IEEE Std 1003.1-1988, IEEE
-Standard Portable Operating System Interface for Computer Environments
-(POSIX), copyright C 1988 by the Institute of Electrical and Electronics
-Engineers, Inc.  In the event of any discrepancy between these versions
-and the original IEEE Standard, the original IEEE Standard is the referee
-document.
-
-In the following statement, the phrase ``This material'' refers to portions
-of the system documentation.
-
-This material is reproduced with permission from American National
-Standards Committee X3, on Information Processing Systems.  Computer and
-Business Equipment Manufacturers Association (CBEMA), 311 First St., NW,
-Suite 500, Washington, DC 20001-2178.  The developmental work of
-Programming Language C was completed by the X3J11 Technical Committee.
-
-The views and conclusions contained in the software and documentation are
-those of the authors and should not be interpreted as representing official
-policies, either expressed or implied, of the Regents of the University
-of California.
-
-
-NOTE: The copyright of UC Berkeley's Berkeley Software Distribution ("BSD")
-source has been updated.  The copyright addendum may be found at
-ftp://ftp.cs.berkeley.edu/pub/4bsd/README.Impt.License.Change and is
-included below.
-
-July 22, 1999
-
-To All Licensees, Distributors of Any Version of BSD:
-
-As you know, certain of the Berkeley Software Distribution ("BSD") source
-code files require that further distributions of products containing all or
-portions of the software, acknowledge within their advertising materials
-that such products contain software developed by UC Berkeley and its
-contributors.
-
-Specifically, the provision reads:
-
-"     * 3. All advertising materials mentioning features or use of this software
-      *    must display the following acknowledgement:
-      *    This product includes software developed by the University of
-      *    California, Berkeley and its contributors."
-
-Effective immediately, licensees and distributors are no longer required to
-include the acknowledgement within advertising materials.  Accordingly, the
-foregoing paragraph of those BSD Unix files containing it is hereby deleted
-in its entirety.
-
-William Hoskins
-Director, Office of Technology Licensing
-University of California, Berkeley
diff --git a/tools/include/xen-external/bsd-queue.3 b/tools/include/xen-external/bsd-queue.3
deleted file mode 100644
index 007ca5c629..0000000000
--- a/tools/include/xen-external/bsd-queue.3
+++ /dev/null
@@ -1,1044 +0,0 @@
-.\" Copyright (c) 1993
-.\"	The Regents of the University of California.  All rights reserved.
-.\"
-.\" Redistribution and use in source and binary forms, with or without
-.\" modification, are permitted provided that the following conditions
-.\" are met:
-.\" 1. Redistributions of source code must retain the above copyright
-.\"    notice, this list of conditions and the following disclaimer.
-.\" 2. Redistributions in binary form must reproduce the above copyright
-.\"    notice, this list of conditions and the following disclaimer in the
-.\"    documentation and/or other materials provided with the distribution.
-.\" 3. All advertising materials mentioning features or use of this software
-.\"    must display the following acknowledgement:
-.\"	This product includes software developed by the University of
-.\"	California, Berkeley and its contributors.
-.\" 4. Neither the name of the University nor the names of its contributors
-.\"    may be used to endorse or promote products derived from this software
-.\"    without specific prior written permission.
-.\"
-.\" THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND
-.\" ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
-.\" IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
-.\" ARE DISCLAIMED.  IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE
-.\" FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
-.\" DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
-.\" OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
-.\" HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
-.\" LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
-.\" OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
-.\" SUCH DAMAGE.
-.\"
-.\"	@(#)queue.3	8.2 (Berkeley) 1/24/94
-.\" $FreeBSD$
-.\"
-.Dd May 13, 2011
-.Dt QUEUE 3
-.Os
-.Sh NAME
-.Nm SLIST_EMPTY ,
-.Nm SLIST_ENTRY ,
-.Nm SLIST_FIRST ,
-.Nm SLIST_FOREACH ,
-.Nm SLIST_FOREACH_SAFE ,
-.Nm SLIST_HEAD ,
-.Nm SLIST_HEAD_INITIALIZER ,
-.Nm SLIST_INIT ,
-.Nm SLIST_INSERT_AFTER ,
-.Nm SLIST_INSERT_HEAD ,
-.Nm SLIST_NEXT ,
-.Nm SLIST_REMOVE_AFTER ,
-.Nm SLIST_REMOVE_HEAD ,
-.Nm SLIST_REMOVE ,
-.Nm SLIST_SWAP ,
-.Nm STAILQ_CONCAT ,
-.Nm STAILQ_EMPTY ,
-.Nm STAILQ_ENTRY ,
-.Nm STAILQ_FIRST ,
-.Nm STAILQ_FOREACH ,
-.Nm STAILQ_FOREACH_SAFE ,
-.Nm STAILQ_HEAD ,
-.Nm STAILQ_HEAD_INITIALIZER ,
-.Nm STAILQ_INIT ,
-.Nm STAILQ_INSERT_AFTER ,
-.Nm STAILQ_INSERT_HEAD ,
-.Nm STAILQ_INSERT_TAIL ,
-.Nm STAILQ_LAST ,
-.Nm STAILQ_NEXT ,
-.Nm STAILQ_REMOVE_AFTER ,
-.Nm STAILQ_REMOVE_HEAD ,
-.Nm STAILQ_REMOVE ,
-.Nm STAILQ_SWAP ,
-.Nm LIST_EMPTY ,
-.Nm LIST_ENTRY ,
-.Nm LIST_FIRST ,
-.Nm LIST_FOREACH ,
-.Nm LIST_FOREACH_SAFE ,
-.Nm LIST_HEAD ,
-.Nm LIST_HEAD_INITIALIZER ,
-.Nm LIST_INIT ,
-.Nm LIST_INSERT_AFTER ,
-.Nm LIST_INSERT_BEFORE ,
-.Nm LIST_INSERT_HEAD ,
-.Nm LIST_NEXT ,
-.Nm LIST_REMOVE ,
-.Nm LIST_SWAP ,
-.Nm TAILQ_CONCAT ,
-.Nm TAILQ_EMPTY ,
-.Nm TAILQ_ENTRY ,
-.Nm TAILQ_FIRST ,
-.Nm TAILQ_FOREACH ,
-.Nm TAILQ_FOREACH_SAFE ,
-.Nm TAILQ_FOREACH_REVERSE ,
-.Nm TAILQ_FOREACH_REVERSE_SAFE ,
-.Nm TAILQ_HEAD ,
-.Nm TAILQ_HEAD_INITIALIZER ,
-.Nm TAILQ_INIT ,
-.Nm TAILQ_INSERT_AFTER ,
-.Nm TAILQ_INSERT_BEFORE ,
-.Nm TAILQ_INSERT_HEAD ,
-.Nm TAILQ_INSERT_TAIL ,
-.Nm TAILQ_LAST ,
-.Nm TAILQ_NEXT ,
-.Nm TAILQ_PREV ,
-.Nm TAILQ_REMOVE ,
-.Nm TAILQ_SWAP
-.Nd implementations of singly-linked lists, singly-linked tail queues,
-lists and tail queues
-.Sh SYNOPSIS
-.In sys/queue.h
-.\"
-.Fn SLIST_EMPTY "SLIST_HEAD *head"
-.Fn SLIST_ENTRY "TYPE"
-.Fn SLIST_FIRST "SLIST_HEAD *head"
-.Fn SLIST_FOREACH "TYPE *var" "SLIST_HEAD *head" "SLIST_ENTRY NAME"
-.Fn SLIST_FOREACH_SAFE "TYPE *var" "SLIST_HEAD *head" "SLIST_ENTRY NAME" "TYPE *temp_var"
-.Fn SLIST_HEAD "HEADNAME" "TYPE"
-.Fn SLIST_HEAD_INITIALIZER "SLIST_HEAD head"
-.Fn SLIST_INIT "SLIST_HEAD *head"
-.Fn SLIST_INSERT_AFTER "TYPE *listelm" "TYPE *elm" "SLIST_ENTRY NAME"
-.Fn SLIST_INSERT_HEAD "SLIST_HEAD *head" "TYPE *elm" "SLIST_ENTRY NAME"
-.Fn SLIST_NEXT "TYPE *elm" "SLIST_ENTRY NAME"
-.Fn SLIST_REMOVE_AFTER "TYPE *elm" "SLIST_ENTRY NAME"
-.Fn SLIST_REMOVE_HEAD "SLIST_HEAD *head" "SLIST_ENTRY NAME"
-.Fn SLIST_REMOVE "SLIST_HEAD *head" "TYPE *elm" "TYPE" "SLIST_ENTRY NAME"
-.Fn SLIST_SWAP "SLIST_HEAD *head1" "SLIST_HEAD *head2" "SLIST_ENTRY NAME"
-.\"
-.Fn STAILQ_CONCAT "STAILQ_HEAD *head1" "STAILQ_HEAD *head2"
-.Fn STAILQ_EMPTY "STAILQ_HEAD *head"
-.Fn STAILQ_ENTRY "TYPE"
-.Fn STAILQ_FIRST "STAILQ_HEAD *head"
-.Fn STAILQ_FOREACH "TYPE *var" "STAILQ_HEAD *head" "STAILQ_ENTRY NAME"
-.Fn STAILQ_FOREACH_SAFE "TYPE *var" "STAILQ_HEAD *head" "STAILQ_ENTRY NAME" "TYPE *temp_var"
-.Fn STAILQ_HEAD "HEADNAME" "TYPE"
-.Fn STAILQ_HEAD_INITIALIZER "STAILQ_HEAD head"
-.Fn STAILQ_INIT "STAILQ_HEAD *head"
-.Fn STAILQ_INSERT_AFTER "STAILQ_HEAD *head" "TYPE *listelm" "TYPE *elm" "STAILQ_ENTRY NAME"
-.Fn STAILQ_INSERT_HEAD "STAILQ_HEAD *head" "TYPE *elm" "STAILQ_ENTRY NAME"
-.Fn STAILQ_INSERT_TAIL "STAILQ_HEAD *head" "TYPE *elm" "STAILQ_ENTRY NAME"
-.Fn STAILQ_LAST "STAILQ_HEAD *head" "TYPE" "STAILQ_ENTRY NAME"
-.Fn STAILQ_NEXT "TYPE *elm" "STAILQ_ENTRY NAME"
-.Fn STAILQ_REMOVE_AFTER "STAILQ_HEAD *head" "TYPE *elm" "STAILQ_ENTRY NAME"
-.Fn STAILQ_REMOVE_HEAD "STAILQ_HEAD *head" "STAILQ_ENTRY NAME"
-.Fn STAILQ_REMOVE "STAILQ_HEAD *head" "TYPE *elm" "TYPE" "STAILQ_ENTRY NAME"
-.Fn STAILQ_SWAP "STAILQ_HEAD *head1" "STAILQ_HEAD *head2" "STAILQ_ENTRY NAME"
-.\"
-.Fn LIST_EMPTY "LIST_HEAD *head"
-.Fn LIST_ENTRY "TYPE"
-.Fn LIST_FIRST "LIST_HEAD *head"
-.Fn LIST_FOREACH "TYPE *var" "LIST_HEAD *head" "LIST_ENTRY NAME"
-.Fn LIST_FOREACH_SAFE "TYPE *var" "LIST_HEAD *head" "LIST_ENTRY NAME" "TYPE *temp_var"
-.Fn LIST_HEAD "HEADNAME" "TYPE"
-.Fn LIST_HEAD_INITIALIZER "LIST_HEAD head"
-.Fn LIST_INIT "LIST_HEAD *head"
-.Fn LIST_INSERT_AFTER "TYPE *listelm" "TYPE *elm" "LIST_ENTRY NAME"
-.Fn LIST_INSERT_BEFORE "TYPE *listelm" "TYPE *elm" "LIST_ENTRY NAME"
-.Fn LIST_INSERT_HEAD "LIST_HEAD *head" "TYPE *elm" "LIST_ENTRY NAME"
-.Fn LIST_NEXT "TYPE *elm" "LIST_ENTRY NAME"
-.Fn LIST_REMOVE "TYPE *elm" "LIST_ENTRY NAME"
-.Fn LIST_SWAP "LIST_HEAD *head1" "LIST_HEAD *head2" "TYPE" "LIST_ENTRY NAME"
-.\"
-.Fn TAILQ_CONCAT "TAILQ_HEAD *head1" "TAILQ_HEAD *head2" "TAILQ_ENTRY NAME"
-.Fn TAILQ_EMPTY "TAILQ_HEAD *head"
-.Fn TAILQ_ENTRY "TYPE"
-.Fn TAILQ_FIRST "TAILQ_HEAD *head"
-.Fn TAILQ_FOREACH "TYPE *var" "TAILQ_HEAD *head" "TAILQ_ENTRY NAME"
-.Fn TAILQ_FOREACH_SAFE "TYPE *var" "TAILQ_HEAD *head" "TAILQ_ENTRY NAME" "TYPE *temp_var"
-.Fn TAILQ_FOREACH_REVERSE "TYPE *var" "TAILQ_HEAD *head" "HEADNAME" "TAILQ_ENTRY NAME"
-.Fn TAILQ_FOREACH_REVERSE_SAFE "TYPE *var" "TAILQ_HEAD *head" "HEADNAME" "TAILQ_ENTRY NAME" "TYPE *temp_var"
-.Fn TAILQ_HEAD "HEADNAME" "TYPE"
-.Fn TAILQ_HEAD_INITIALIZER "TAILQ_HEAD head"
-.Fn TAILQ_INIT "TAILQ_HEAD *head"
-.Fn TAILQ_INSERT_AFTER "TAILQ_HEAD *head" "TYPE *listelm" "TYPE *elm" "TAILQ_ENTRY NAME"
-.Fn TAILQ_INSERT_BEFORE "TYPE *listelm" "TYPE *elm" "TAILQ_ENTRY NAME"
-.Fn TAILQ_INSERT_HEAD "TAILQ_HEAD *head" "TYPE *elm" "TAILQ_ENTRY NAME"
-.Fn TAILQ_INSERT_TAIL "TAILQ_HEAD *head" "TYPE *elm" "TAILQ_ENTRY NAME"
-.Fn TAILQ_LAST "TAILQ_HEAD *head" "HEADNAME"
-.Fn TAILQ_NEXT "TYPE *elm" "TAILQ_ENTRY NAME"
-.Fn TAILQ_PREV "TYPE *elm" "HEADNAME" "TAILQ_ENTRY NAME"
-.Fn TAILQ_REMOVE "TAILQ_HEAD *head" "TYPE *elm" "TAILQ_ENTRY NAME"
-.Fn TAILQ_SWAP "TAILQ_HEAD *head1" "TAILQ_HEAD *head2" "TYPE" "TAILQ_ENTRY NAME"
-.\"
-.Sh DESCRIPTION
-These macros define and operate on four types of data structures:
-singly-linked lists, singly-linked tail queues, lists, and tail queues.
-All four structures support the following functionality:
-.Bl -enum -compact -offset indent
-.It
-Insertion of a new entry at the head of the list.
-.It
-Insertion of a new entry after any element in the list.
-.It
-O(1) removal of an entry from the head of the list.
-.It
-Forward traversal through the list.
-.It
-Swawpping the contents of two lists.
-.El
-.Pp
-Singly-linked lists are the simplest of the four data structures
-and support only the above functionality.
-Singly-linked lists are ideal for applications with large datasets
-and few or no removals,
-or for implementing a LIFO queue.
-Singly-linked lists add the following functionality:
-.Bl -enum -compact -offset indent
-.It
-O(n) removal of any entry in the list.
-.El
-.Pp
-Singly-linked tail queues add the following functionality:
-.Bl -enum -compact -offset indent
-.It
-Entries can be added at the end of a list.
-.It
-O(n) removal of any entry in the list.
-.It
-They may be concatenated.
-.El
-However:
-.Bl -enum -compact -offset indent
-.It
-All list insertions must specify the head of the list.
-.It
-Each head entry requires two pointers rather than one.
-.It
-Code size is about 15% greater and operations run about 20% slower
-than singly-linked lists.
-.El
-.Pp
-Singly-linked tailqs are ideal for applications with large datasets and
-few or no removals,
-or for implementing a FIFO queue.
-.Pp
-All doubly linked types of data structures (lists and tail queues)
-additionally allow:
-.Bl -enum -compact -offset indent
-.It
-Insertion of a new entry before any element in the list.
-.It
-O(1) removal of any entry in the list.
-.El
-However:
-.Bl -enum -compact -offset indent
-.It
-Each element requires two pointers rather than one.
-.It
-Code size and execution time of operations (except for removal) is about
-twice that of the singly-linked data-structures.
-.El
-.Pp
-Linked lists are the simplest of the doubly linked data structures and support
-only the above functionality over singly-linked lists.
-.Pp
-Tail queues add the following functionality:
-.Bl -enum -compact -offset indent
-.It
-Entries can be added at the end of a list.
-.It
-They may be traversed backwards, from tail to head.
-.It
-They may be concatenated.
-.El
-However:
-.Bl -enum -compact -offset indent
-.It
-All list insertions and removals must specify the head of the list.
-.It
-Each head entry requires two pointers rather than one.
-.It
-Code size is about 15% greater and operations run about 20% slower
-than singly-linked lists.
-.El
-.Pp
-In the macro definitions,
-.Fa TYPE
-is the name of a user defined structure,
-that must contain a field of type
-.Li SLIST_ENTRY ,
-.Li STAILQ_ENTRY ,
-.Li LIST_ENTRY ,
-or
-.Li TAILQ_ENTRY ,
-named
-.Fa NAME .
-The argument
-.Fa HEADNAME
-is the name of a user defined structure that must be declared
-using the macros
-.Li SLIST_HEAD ,
-.Li STAILQ_HEAD ,
-.Li LIST_HEAD ,
-or
-.Li TAILQ_HEAD .
-See the examples below for further explanation of how these
-macros are used.
-.Sh SINGLY-LINKED LISTS
-A singly-linked list is headed by a structure defined by the
-.Nm SLIST_HEAD
-macro.
-This structure contains a single pointer to the first element
-on the list.
-The elements are singly linked for minimum space and pointer manipulation
-overhead at the expense of O(n) removal for arbitrary elements.
-New elements can be added to the list after an existing element or
-at the head of the list.
-An
-.Fa SLIST_HEAD
-structure is declared as follows:
-.Bd -literal -offset indent
-SLIST_HEAD(HEADNAME, TYPE) head;
-.Ed
-.Pp
-where
-.Fa HEADNAME
-is the name of the structure to be defined, and
-.Fa TYPE
-is the type of the elements to be linked into the list.
-A pointer to the head of the list can later be declared as:
-.Bd -literal -offset indent
-struct HEADNAME *headp;
-.Ed
-.Pp
-(The names
-.Li head
-and
-.Li headp
-are user selectable.)
-.Pp
-The macro
-.Nm SLIST_HEAD_INITIALIZER
-evaluates to an initializer for the list
-.Fa head .
-.Pp
-The macro
-.Nm SLIST_EMPTY
-evaluates to true if there are no elements in the list.
-.Pp
-The macro
-.Nm SLIST_ENTRY
-declares a structure that connects the elements in
-the list.
-.Pp
-The macro
-.Nm SLIST_FIRST
-returns the first element in the list or NULL if the list is empty.
-.Pp
-The macro
-.Nm SLIST_FOREACH
-traverses the list referenced by
-.Fa head
-in the forward direction, assigning each element in
-turn to
-.Fa var .
-.Pp
-The macro
-.Nm SLIST_FOREACH_SAFE
-traverses the list referenced by
-.Fa head
-in the forward direction, assigning each element in
-turn to
-.Fa var .
-However, unlike
-.Fn SLIST_FOREACH
-here it is permitted to both remove
-.Fa var
-as well as free it from within the loop safely without interfering with the
-traversal.
-.Pp
-The macro
-.Nm SLIST_INIT
-initializes the list referenced by
-.Fa head .
-.Pp
-The macro
-.Nm SLIST_INSERT_HEAD
-inserts the new element
-.Fa elm
-at the head of the list.
-.Pp
-The macro
-.Nm SLIST_INSERT_AFTER
-inserts the new element
-.Fa elm
-after the element
-.Fa listelm .
-.Pp
-The macro
-.Nm SLIST_NEXT
-returns the next element in the list.
-.Pp
-The macro
-.Nm SLIST_REMOVE_AFTER
-removes the element after
-.Fa elm
-from the list. Unlike
-.Fa SLIST_REMOVE ,
-this macro does not traverse the entire list.
-.Pp
-The macro
-.Nm SLIST_REMOVE_HEAD
-removes the element
-.Fa elm
-from the head of the list.
-For optimum efficiency,
-elements being removed from the head of the list should explicitly use
-this macro instead of the generic
-.Fa SLIST_REMOVE
-macro.
-.Pp
-The macro
-.Nm SLIST_REMOVE
-removes the element
-.Fa elm
-from the list.
-.Pp
-The macro
-.Nm SLIST_SWAP
-swaps the contents of
-.Fa head1
-and
-.Fa head2 .
-.Sh SINGLY-LINKED LIST EXAMPLE
-.Bd -literal
-SLIST_HEAD(slisthead, entry) head =
-    SLIST_HEAD_INITIALIZER(head);
-struct slisthead *headp;		/* Singly-linked List head. */
-struct entry {
-	...
-	SLIST_ENTRY(entry) entries;	/* Singly-linked List. */
-	...
-} *n1, *n2, *n3, *np;
-
-SLIST_INIT(&head);			/* Initialize the list. */
-
-n1 = malloc(sizeof(struct entry));	/* Insert at the head. */
-SLIST_INSERT_HEAD(&head, n1, entries);
-
-n2 = malloc(sizeof(struct entry));	/* Insert after. */
-SLIST_INSERT_AFTER(n1, n2, entries);
-
-SLIST_REMOVE(&head, n2, entry, entries);/* Deletion. */
-free(n2);
-
-n3 = SLIST_FIRST(&head);
-SLIST_REMOVE_HEAD(&head, entries);	/* Deletion from the head. */
-free(n3);
-					/* Forward traversal. */
-SLIST_FOREACH(np, &head, entries)
-	np-> ...
-					/* Safe forward traversal. */
-SLIST_FOREACH_SAFE(np, &head, entries, np_temp) {
-	np->do_stuff();
-	...
-	SLIST_REMOVE(&head, np, entry, entries);
-	free(np);
-}
-
-while (!SLIST_EMPTY(&head)) {		/* List Deletion. */
-	n1 = SLIST_FIRST(&head);
-	SLIST_REMOVE_HEAD(&head, entries);
-	free(n1);
-}
-.Ed
-.Sh SINGLY-LINKED TAIL QUEUES
-A singly-linked tail queue is headed by a structure defined by the
-.Nm STAILQ_HEAD
-macro.
-This structure contains a pair of pointers,
-one to the first element in the tail queue and the other to
-the last element in the tail queue.
-The elements are singly linked for minimum space and pointer
-manipulation overhead at the expense of O(n) removal for arbitrary
-elements.
-New elements can be added to the tail queue after an existing element,
-at the head of the tail queue, or at the end of the tail queue.
-A
-.Fa STAILQ_HEAD
-structure is declared as follows:
-.Bd -literal -offset indent
-STAILQ_HEAD(HEADNAME, TYPE) head;
-.Ed
-.Pp
-where
-.Li HEADNAME
-is the name of the structure to be defined, and
-.Li TYPE
-is the type of the elements to be linked into the tail queue.
-A pointer to the head of the tail queue can later be declared as:
-.Bd -literal -offset indent
-struct HEADNAME *headp;
-.Ed
-.Pp
-(The names
-.Li head
-and
-.Li headp
-are user selectable.)
-.Pp
-The macro
-.Nm STAILQ_HEAD_INITIALIZER
-evaluates to an initializer for the tail queue
-.Fa head .
-.Pp
-The macro
-.Nm STAILQ_CONCAT
-concatenates the tail queue headed by
-.Fa head2
-onto the end of the one headed by
-.Fa head1
-removing all entries from the former.
-.Pp
-The macro
-.Nm STAILQ_EMPTY
-evaluates to true if there are no items on the tail queue.
-.Pp
-The macro
-.Nm STAILQ_ENTRY
-declares a structure that connects the elements in
-the tail queue.
-.Pp
-The macro
-.Nm STAILQ_FIRST
-returns the first item on the tail queue or NULL if the tail queue
-is empty.
-.Pp
-The macro
-.Nm STAILQ_FOREACH
-traverses the tail queue referenced by
-.Fa head
-in the forward direction, assigning each element
-in turn to
-.Fa var .
-.Pp
-The macro
-.Nm STAILQ_FOREACH_SAFE
-traverses the tail queue referenced by
-.Fa head
-in the forward direction, assigning each element
-in turn to
-.Fa var .
-However, unlike
-.Fn STAILQ_FOREACH
-here it is permitted to both remove
-.Fa var
-as well as free it from within the loop safely without interfering with the
-traversal.
-.Pp
-The macro
-.Nm STAILQ_INIT
-initializes the tail queue referenced by
-.Fa head .
-.Pp
-The macro
-.Nm STAILQ_INSERT_HEAD
-inserts the new element
-.Fa elm
-at the head of the tail queue.
-.Pp
-The macro
-.Nm STAILQ_INSERT_TAIL
-inserts the new element
-.Fa elm
-at the end of the tail queue.
-.Pp
-The macro
-.Nm STAILQ_INSERT_AFTER
-inserts the new element
-.Fa elm
-after the element
-.Fa listelm .
-.Pp
-The macro
-.Nm STAILQ_LAST
-returns the last item on the tail queue.
-If the tail queue is empty the return value is
-.Dv NULL .
-.Pp
-The macro
-.Nm STAILQ_NEXT
-returns the next item on the tail queue, or NULL this item is the last.
-.Pp
-The macro
-.Nm STAILQ_REMOVE_AFTER
-removes the element after
-.Fa elm
-from the tail queue. Unlike
-.Fa STAILQ_REMOVE ,
-this macro does not traverse the entire tail queue.
-.Pp
-The macro
-.Nm STAILQ_REMOVE_HEAD
-removes the element at the head of the tail queue.
-For optimum efficiency,
-elements being removed from the head of the tail queue should
-use this macro explicitly rather than the generic
-.Fa STAILQ_REMOVE
-macro.
-.Pp
-The macro
-.Nm STAILQ_REMOVE
-removes the element
-.Fa elm
-from the tail queue.
-.Pp
-The macro
-.Nm STAILQ_SWAP
-swaps the contents of
-.Fa head1
-and
-.Fa head2 .
-.Sh SINGLY-LINKED TAIL QUEUE EXAMPLE
-.Bd -literal
-STAILQ_HEAD(stailhead, entry) head =
-    STAILQ_HEAD_INITIALIZER(head);
-struct stailhead *headp;		/* Singly-linked tail queue head. */
-struct entry {
-	...
-	STAILQ_ENTRY(entry) entries;	/* Tail queue. */
-	...
-} *n1, *n2, *n3, *np;
-
-STAILQ_INIT(&head);			/* Initialize the queue. */
-
-n1 = malloc(sizeof(struct entry));	/* Insert at the head. */
-STAILQ_INSERT_HEAD(&head, n1, entries);
-
-n1 = malloc(sizeof(struct entry));	/* Insert at the tail. */
-STAILQ_INSERT_TAIL(&head, n1, entries);
-
-n2 = malloc(sizeof(struct entry));	/* Insert after. */
-STAILQ_INSERT_AFTER(&head, n1, n2, entries);
-					/* Deletion. */
-STAILQ_REMOVE(&head, n2, entry, entries);
-free(n2);
-					/* Deletion from the head. */
-n3 = STAILQ_FIRST(&head);
-STAILQ_REMOVE_HEAD(&head, entries);
-free(n3);
-					/* Forward traversal. */
-STAILQ_FOREACH(np, &head, entries)
-	np-> ...
-					/* Safe forward traversal. */
-STAILQ_FOREACH_SAFE(np, &head, entries, np_temp) {
-	np->do_stuff();
-	...
-	STAILQ_REMOVE(&head, np, entry, entries);
-	free(np);
-}
-					/* TailQ Deletion. */
-while (!STAILQ_EMPTY(&head)) {
-	n1 = STAILQ_FIRST(&head);
-	STAILQ_REMOVE_HEAD(&head, entries);
-	free(n1);
-}
-					/* Faster TailQ Deletion. */
-n1 = STAILQ_FIRST(&head);
-while (n1 != NULL) {
-	n2 = STAILQ_NEXT(n1, entries);
-	free(n1);
-	n1 = n2;
-}
-STAILQ_INIT(&head);
-.Ed
-.Sh LISTS
-A list is headed by a structure defined by the
-.Nm LIST_HEAD
-macro.
-This structure contains a single pointer to the first element
-on the list.
-The elements are doubly linked so that an arbitrary element can be
-removed without traversing the list.
-New elements can be added to the list after an existing element,
-before an existing element, or at the head of the list.
-A
-.Fa LIST_HEAD
-structure is declared as follows:
-.Bd -literal -offset indent
-LIST_HEAD(HEADNAME, TYPE) head;
-.Ed
-.Pp
-where
-.Fa HEADNAME
-is the name of the structure to be defined, and
-.Fa TYPE
-is the type of the elements to be linked into the list.
-A pointer to the head of the list can later be declared as:
-.Bd -literal -offset indent
-struct HEADNAME *headp;
-.Ed
-.Pp
-(The names
-.Li head
-and
-.Li headp
-are user selectable.)
-.Pp
-The macro
-.Nm LIST_HEAD_INITIALIZER
-evaluates to an initializer for the list
-.Fa head .
-.Pp
-The macro
-.Nm LIST_EMPTY
-evaluates to true if there are no elements in the list.
-.Pp
-The macro
-.Nm LIST_ENTRY
-declares a structure that connects the elements in
-the list.
-.Pp
-The macro
-.Nm LIST_FIRST
-returns the first element in the list or NULL if the list
-is empty.
-.Pp
-The macro
-.Nm LIST_FOREACH
-traverses the list referenced by
-.Fa head
-in the forward direction, assigning each element in turn to
-.Fa var .
-.Pp
-The macro
-.Nm LIST_FOREACH_SAFE
-traverses the list referenced by
-.Fa head
-in the forward direction, assigning each element in turn to
-.Fa var .
-However, unlike
-.Fn LIST_FOREACH
-here it is permitted to both remove
-.Fa var
-as well as free it from within the loop safely without interfering with the
-traversal.
-.Pp
-The macro
-.Nm LIST_INIT
-initializes the list referenced by
-.Fa head .
-.Pp
-The macro
-.Nm LIST_INSERT_HEAD
-inserts the new element
-.Fa elm
-at the head of the list.
-.Pp
-The macro
-.Nm LIST_INSERT_AFTER
-inserts the new element
-.Fa elm
-after the element
-.Fa listelm .
-.Pp
-The macro
-.Nm LIST_INSERT_BEFORE
-inserts the new element
-.Fa elm
-before the element
-.Fa listelm .
-.Pp
-The macro
-.Nm LIST_NEXT
-returns the next element in the list, or NULL if this is the last.
-.Pp
-The macro
-.Nm LIST_REMOVE
-removes the element
-.Fa elm
-from the list.
-.Pp
-The macro
-.Nm LIST_SWAP
-swaps the contents of
-.Fa head1
-and
-.Fa head2 .
-.Sh LIST EXAMPLE
-.Bd -literal
-LIST_HEAD(listhead, entry) head =
-    LIST_HEAD_INITIALIZER(head);
-struct listhead *headp;			/* List head. */
-struct entry {
-	...
-	LIST_ENTRY(entry) entries;	/* List. */
-	...
-} *n1, *n2, *n3, *np, *np_temp;
-
-LIST_INIT(&head);			/* Initialize the list. */
-
-n1 = malloc(sizeof(struct entry));	/* Insert at the head. */
-LIST_INSERT_HEAD(&head, n1, entries);
-
-n2 = malloc(sizeof(struct entry));	/* Insert after. */
-LIST_INSERT_AFTER(n1, n2, entries);
-
-n3 = malloc(sizeof(struct entry));	/* Insert before. */
-LIST_INSERT_BEFORE(n2, n3, entries);
-
-LIST_REMOVE(n2, entries);		/* Deletion. */
-free(n2);
-					/* Forward traversal. */
-LIST_FOREACH(np, &head, entries)
-	np-> ...
-
-					/* Safe forward traversal. */
-LIST_FOREACH_SAFE(np, &head, entries, np_temp) {
-	np->do_stuff();
-	...
-	LIST_REMOVE(np, entries);
-	free(np);
-}
-
-while (!LIST_EMPTY(&head)) {		/* List Deletion. */
-	n1 = LIST_FIRST(&head);
-	LIST_REMOVE(n1, entries);
-	free(n1);
-}
-
-n1 = LIST_FIRST(&head);			/* Faster List Deletion. */
-while (n1 != NULL) {
-	n2 = LIST_NEXT(n1, entries);
-	free(n1);
-	n1 = n2;
-}
-LIST_INIT(&head);
-.Ed
-.Sh TAIL QUEUES
-A tail queue is headed by a structure defined by the
-.Nm TAILQ_HEAD
-macro.
-This structure contains a pair of pointers,
-one to the first element in the tail queue and the other to
-the last element in the tail queue.
-The elements are doubly linked so that an arbitrary element can be
-removed without traversing the tail queue.
-New elements can be added to the tail queue after an existing element,
-before an existing element, at the head of the tail queue,
-or at the end of the tail queue.
-A
-.Fa TAILQ_HEAD
-structure is declared as follows:
-.Bd -literal -offset indent
-TAILQ_HEAD(HEADNAME, TYPE) head;
-.Ed
-.Pp
-where
-.Li HEADNAME
-is the name of the structure to be defined, and
-.Li TYPE
-is the type of the elements to be linked into the tail queue.
-A pointer to the head of the tail queue can later be declared as:
-.Bd -literal -offset indent
-struct HEADNAME *headp;
-.Ed
-.Pp
-(The names
-.Li head
-and
-.Li headp
-are user selectable.)
-.Pp
-The macro
-.Nm TAILQ_HEAD_INITIALIZER
-evaluates to an initializer for the tail queue
-.Fa head .
-.Pp
-The macro
-.Nm TAILQ_CONCAT
-concatenates the tail queue headed by
-.Fa head2
-onto the end of the one headed by
-.Fa head1
-removing all entries from the former.
-.Pp
-The macro
-.Nm TAILQ_EMPTY
-evaluates to true if there are no items on the tail queue.
-.Pp
-The macro
-.Nm TAILQ_ENTRY
-declares a structure that connects the elements in
-the tail queue.
-.Pp
-The macro
-.Nm TAILQ_FIRST
-returns the first item on the tail queue or NULL if the tail queue
-is empty.
-.Pp
-The macro
-.Nm TAILQ_FOREACH
-traverses the tail queue referenced by
-.Fa head
-in the forward direction, assigning each element in turn to
-.Fa var .
-.Fa var
-is set to
-.Dv NULL
-if the loop completes normally, or if there were no elements.
-.Pp
-The macro
-.Nm TAILQ_FOREACH_REVERSE
-traverses the tail queue referenced by
-.Fa head
-in the reverse direction, assigning each element in turn to
-.Fa var .
-.Pp
-The macros
-.Nm TAILQ_FOREACH_SAFE
-and
-.Nm TAILQ_FOREACH_REVERSE_SAFE
-traverse the list referenced by
-.Fa head
-in the forward or reverse direction respectively,
-assigning each element in turn to
-.Fa var .
-However, unlike their unsafe counterparts,
-.Nm TAILQ_FOREACH
-and
-.Nm TAILQ_FOREACH_REVERSE
-permit to both remove
-.Fa var
-as well as free it from within the loop safely without interfering with the
-traversal.
-.Pp
-The macro
-.Nm TAILQ_INIT
-initializes the tail queue referenced by
-.Fa head .
-.Pp
-The macro
-.Nm TAILQ_INSERT_HEAD
-inserts the new element
-.Fa elm
-at the head of the tail queue.
-.Pp
-The macro
-.Nm TAILQ_INSERT_TAIL
-inserts the new element
-.Fa elm
-at the end of the tail queue.
-.Pp
-The macro
-.Nm TAILQ_INSERT_AFTER
-inserts the new element
-.Fa elm
-after the element
-.Fa listelm .
-.Pp
-The macro
-.Nm TAILQ_INSERT_BEFORE
-inserts the new element
-.Fa elm
-before the element
-.Fa listelm .
-.Pp
-The macro
-.Nm TAILQ_LAST
-returns the last item on the tail queue.
-If the tail queue is empty the return value is
-.Dv NULL .
-.Pp
-The macro
-.Nm TAILQ_NEXT
-returns the next item on the tail queue, or NULL if this item is the last.
-.Pp
-The macro
-.Nm TAILQ_PREV
-returns the previous item on the tail queue, or NULL if this item
-is the first.
-.Pp
-The macro
-.Nm TAILQ_REMOVE
-removes the element
-.Fa elm
-from the tail queue.
-.Pp
-The macro
-.Nm TAILQ_SWAP
-swaps the contents of
-.Fa head1
-and
-.Fa head2 .
-.Sh TAIL QUEUE EXAMPLE
-.Bd -literal
-TAILQ_HEAD(tailhead, entry) head =
-    TAILQ_HEAD_INITIALIZER(head);
-struct tailhead *headp;			/* Tail queue head. */
-struct entry {
-	...
-	TAILQ_ENTRY(entry) entries;	/* Tail queue. */
-	...
-} *n1, *n2, *n3, *np;
-
-TAILQ_INIT(&head);			/* Initialize the queue. */
-
-n1 = malloc(sizeof(struct entry));	/* Insert at the head. */
-TAILQ_INSERT_HEAD(&head, n1, entries);
-
-n1 = malloc(sizeof(struct entry));	/* Insert at the tail. */
-TAILQ_INSERT_TAIL(&head, n1, entries);
-
-n2 = malloc(sizeof(struct entry));	/* Insert after. */
-TAILQ_INSERT_AFTER(&head, n1, n2, entries);
-
-n3 = malloc(sizeof(struct entry));	/* Insert before. */
-TAILQ_INSERT_BEFORE(n2, n3, entries);
-
-TAILQ_REMOVE(&head, n2, entries);	/* Deletion. */
-free(n2);
-					/* Forward traversal. */
-TAILQ_FOREACH(np, &head, entries)
-	np-> ...
-					/* Safe forward traversal. */
-TAILQ_FOREACH_SAFE(np, &head, entries, np_temp) {
-	np->do_stuff();
-	...
-	TAILQ_REMOVE(&head, np, entries);
-	free(np);
-}
-					/* Reverse traversal. */
-TAILQ_FOREACH_REVERSE(np, &head, tailhead, entries)
-	np-> ...
-					/* TailQ Deletion. */
-while (!TAILQ_EMPTY(&head)) {
-	n1 = TAILQ_FIRST(&head);
-	TAILQ_REMOVE(&head, n1, entries);
-	free(n1);
-}
-					/* Faster TailQ Deletion. */
-n1 = TAILQ_FIRST(&head);
-while (n1 != NULL) {
-	n2 = TAILQ_NEXT(n1, entries);
-	free(n1);
-	n1 = n2;
-}
-TAILQ_INIT(&head);
-.Ed
-.Sh SEE ALSO
-.Xr tree 3
-.Sh HISTORY
-The
-.Nm queue
-functions first appeared in
-.Bx 4.4 .
diff --git a/tools/include/xen-external/bsd-sys-queue-h-seddery b/tools/include/xen-external/bsd-sys-queue-h-seddery
deleted file mode 100755
index 3f8716d9ff..0000000000
--- a/tools/include/xen-external/bsd-sys-queue-h-seddery
+++ /dev/null
@@ -1,74 +0,0 @@
-#!/usr/bin/perl -p
-#
-# This script is part of the Xen build system.  It has a very
-# permissive licence to avoid complicating the licence of the
-# generated header file and to allow this seddery to be reused by
-# other projects.
-#
-# Permission is hereby granted, free of charge, to any person
-# obtaining a copy of this individual file (the "Software"), to deal
-# in the Software without restriction, including without limitation
-# the rights to use, copy, modify, merge, publish, distribute,
-# sublicense, and/or sell copies of the Software, and to permit
-# persons to whom the Software is furnished to do so, subject to the
-# following conditions:
-#
-# The above copyright notice and this permission notice shall be
-# included in all copies or substantial portions of the Software.
-#
-# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
-# EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
-# MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
-# NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS
-# BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN
-# ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
-# CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
-# SOFTWARE.
-#
-# Copyright (C) 2011 Citrix Ltd
-
-our $namespace, $ucnamespace;
-
-BEGIN {
-    die unless @ARGV;
-    $namespace = pop @ARGV;
-    $namespace =~ s/^--prefix=// or die;
-    $ucnamespace = uc $namespace;
-
-    print <<END or die $!;
-/*
- * DO NOT EDIT THIS FILE
- *
- * Generated automatically by bsd-sys-queue-h-seddery to
- *  - introduce ${ucnamespace}_ and ${namespace}_ namespace prefixes
- *  - turn "struct type" into "type" so that type arguments
- *     to the macros are type names not struct tags
- *  - remove the reference to sys/cdefs.h, which is not needed
- *
- * The purpose of this seddery is to allow the resulting file to be
- * freely included by software which might also want to include other
- * list macros; to make it usable when struct tags are not being used
- * or not known; to make it more portable.
- */
-END
-}
-
-s/\b( _SYS_QUEUE |
-      SLIST | LIST | STAILQ | TAILQ | QUEUE
-      )/${ucnamespace}_$1/xg;
-
-s/\b( TRACEBUF | TRASHIT |
-      QMD_
-      )/${ucnamespace}__$1/xg;
-
-s/\b(
-      qm_
-      )/${namespace}__$1/xg;
-
-s/\b struct \s+ type \b/type/xg;
-
-s,^\#include.*sys/cdefs.*,/* $& */,xg;
-
-s,\b __offsetof \b ,offsetof,xg;
-
-s/\b( NULL )/0/xg;
diff --git a/tools/include/xen-external/bsd-sys-queue.h b/tools/include/xen-external/bsd-sys-queue.h
deleted file mode 100644
index 274e636c53..0000000000
--- a/tools/include/xen-external/bsd-sys-queue.h
+++ /dev/null
@@ -1,637 +0,0 @@
-/*-
- * Copyright (c) 1991, 1993
- *	The Regents of the University of California.  All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- *    notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- *    notice, this list of conditions and the following disclaimer in the
- *    documentation and/or other materials provided with the distribution.
- * 4. Neither the name of the University nor the names of its contributors
- *    may be used to endorse or promote products derived from this software
- *    without specific prior written permission.
- *
- * THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND
- * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
- * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
- * ARE DISCLAIMED.  IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE
- * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
- * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
- * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
- * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
- * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
- * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
- * SUCH DAMAGE.
- *
- *	@(#)queue.h	8.5 (Berkeley) 8/20/94
- * $FreeBSD$
- */
-
-#ifndef _SYS_QUEUE_H_
-#define	_SYS_QUEUE_H_
-
-#include <sys/cdefs.h>
-
-/*
- * This file defines four types of data structures: singly-linked lists,
- * singly-linked tail queues, lists and tail queues.
- *
- * A singly-linked list is headed by a single forward pointer. The elements
- * are singly linked for minimum space and pointer manipulation overhead at
- * the expense of O(n) removal for arbitrary elements. New elements can be
- * added to the list after an existing element or at the head of the list.
- * Elements being removed from the head of the list should use the explicit
- * macro for this purpose for optimum efficiency. A singly-linked list may
- * only be traversed in the forward direction.  Singly-linked lists are ideal
- * for applications with large datasets and few or no removals or for
- * implementing a LIFO queue.
- *
- * A singly-linked tail queue is headed by a pair of pointers, one to the
- * head of the list and the other to the tail of the list. The elements are
- * singly linked for minimum space and pointer manipulation overhead at the
- * expense of O(n) removal for arbitrary elements. New elements can be added
- * to the list after an existing element, at the head of the list, or at the
- * end of the list. Elements being removed from the head of the tail queue
- * should use the explicit macro for this purpose for optimum efficiency.
- * A singly-linked tail queue may only be traversed in the forward direction.
- * Singly-linked tail queues are ideal for applications with large datasets
- * and few or no removals or for implementing a FIFO queue.
- *
- * A list is headed by a single forward pointer (or an array of forward
- * pointers for a hash table header). The elements are doubly linked
- * so that an arbitrary element can be removed without a need to
- * traverse the list. New elements can be added to the list before
- * or after an existing element or at the head of the list. A list
- * may only be traversed in the forward direction.
- *
- * A tail queue is headed by a pair of pointers, one to the head of the
- * list and the other to the tail of the list. The elements are doubly
- * linked so that an arbitrary element can be removed without a need to
- * traverse the list. New elements can be added to the list before or
- * after an existing element, at the head of the list, or at the end of
- * the list. A tail queue may be traversed in either direction.
- *
- * For details on the use of these macros, see the queue(3) manual page.
- *
- *
- *				SLIST	LIST	STAILQ	TAILQ
- * _HEAD			+	+	+	+
- * _HEAD_INITIALIZER		+	+	+	+
- * _ENTRY			+	+	+	+
- * _INIT			+	+	+	+
- * _EMPTY			+	+	+	+
- * _FIRST			+	+	+	+
- * _NEXT			+	+	+	+
- * _PREV			-	-	-	+
- * _LAST			-	-	+	+
- * _FOREACH			+	+	+	+
- * _FOREACH_SAFE		+	+	+	+
- * _FOREACH_REVERSE		-	-	-	+
- * _FOREACH_REVERSE_SAFE	-	-	-	+
- * _INSERT_HEAD			+	+	+	+
- * _INSERT_BEFORE		-	+	-	+
- * _INSERT_AFTER		+	+	+	+
- * _INSERT_TAIL			-	-	+	+
- * _CONCAT			-	-	+	+
- * _REMOVE_AFTER		+	-	+	-
- * _REMOVE_HEAD			+	-	+	-
- * _REMOVE			+	+	+	+
- * _SWAP			+	+	+	+
- *
- */
-#ifdef QUEUE_MACRO_DEBUG
-/* Store the last 2 places the queue element or head was altered */
-struct qm_trace {
-	char * lastfile;
-	int lastline;
-	char * prevfile;
-	int prevline;
-};
-
-#define	TRACEBUF	struct qm_trace trace;
-#define	TRASHIT(x)	do {(x) = (void *)-1;} while (0)
-#define	QMD_SAVELINK(name, link)	void **name = (void *)&(link)
-
-#define	QMD_TRACE_HEAD(head) do {					\
-	(head)->trace.prevline = (head)->trace.lastline;		\
-	(head)->trace.prevfile = (head)->trace.lastfile;		\
-	(head)->trace.lastline = __LINE__;				\
-	(head)->trace.lastfile = __FILE__;				\
-} while (0)
-
-#define	QMD_TRACE_ELEM(elem) do {					\
-	(elem)->trace.prevline = (elem)->trace.lastline;		\
-	(elem)->trace.prevfile = (elem)->trace.lastfile;		\
-	(elem)->trace.lastline = __LINE__;				\
-	(elem)->trace.lastfile = __FILE__;				\
-} while (0)
-
-#else
-#define	QMD_TRACE_ELEM(elem)
-#define	QMD_TRACE_HEAD(head)
-#define	QMD_SAVELINK(name, link)
-#define	TRACEBUF
-#define	TRASHIT(x)
-#endif	/* QUEUE_MACRO_DEBUG */
-
-/*
- * Singly-linked List declarations.
- */
-#define	SLIST_HEAD(name, type)						\
-struct name {								\
-	struct type *slh_first;	/* first element */			\
-}
-
-#define	SLIST_HEAD_INITIALIZER(head)					\
-	{ NULL }
-
-#define	SLIST_ENTRY(type)						\
-struct {								\
-	struct type *sle_next;	/* next element */			\
-}
-
-/*
- * Singly-linked List functions.
- */
-#define	SLIST_EMPTY(head)	((head)->slh_first == NULL)
-
-#define	SLIST_FIRST(head)	((head)->slh_first)
-
-#define	SLIST_FOREACH(var, head, field)					\
-	for ((var) = SLIST_FIRST((head));				\
-	    (var);							\
-	    (var) = SLIST_NEXT((var), field))
-
-#define	SLIST_FOREACH_SAFE(var, head, field, tvar)			\
-	for ((var) = SLIST_FIRST((head));				\
-	    (var) && ((tvar) = SLIST_NEXT((var), field), 1);		\
-	    (var) = (tvar))
-
-#define	SLIST_FOREACH_PREVPTR(var, varp, head, field)			\
-	for ((varp) = &SLIST_FIRST((head));				\
-	    ((var) = *(varp)) != NULL;					\
-	    (varp) = &SLIST_NEXT((var), field))
-
-#define	SLIST_INIT(head) do {						\
-	SLIST_FIRST((head)) = NULL;					\
-} while (0)
-
-#define	SLIST_INSERT_AFTER(slistelm, elm, field) do {			\
-	SLIST_NEXT((elm), field) = SLIST_NEXT((slistelm), field);	\
-	SLIST_NEXT((slistelm), field) = (elm);				\
-} while (0)
-
-#define	SLIST_INSERT_HEAD(head, elm, field) do {			\
-	SLIST_NEXT((elm), field) = SLIST_FIRST((head));			\
-	SLIST_FIRST((head)) = (elm);					\
-} while (0)
-
-#define	SLIST_NEXT(elm, field)	((elm)->field.sle_next)
-
-#define	SLIST_REMOVE(head, elm, type, field) do {			\
-	QMD_SAVELINK(oldnext, (elm)->field.sle_next);			\
-	if (SLIST_FIRST((head)) == (elm)) {				\
-		SLIST_REMOVE_HEAD((head), field);			\
-	}								\
-	else {								\
-		struct type *curelm = SLIST_FIRST((head));		\
-		while (SLIST_NEXT(curelm, field) != (elm))		\
-			curelm = SLIST_NEXT(curelm, field);		\
-		SLIST_REMOVE_AFTER(curelm, field);			\
-	}								\
-	TRASHIT(*oldnext);						\
-} while (0)
-
-#define SLIST_REMOVE_AFTER(elm, field) do {				\
-	SLIST_NEXT(elm, field) =					\
-	    SLIST_NEXT(SLIST_NEXT(elm, field), field);			\
-} while (0)
-
-#define	SLIST_REMOVE_HEAD(head, field) do {				\
-	SLIST_FIRST((head)) = SLIST_NEXT(SLIST_FIRST((head)), field);	\
-} while (0)
-
-#define SLIST_SWAP(head1, head2, type) do {				\
-	struct type *swap_first = SLIST_FIRST(head1);			\
-	SLIST_FIRST(head1) = SLIST_FIRST(head2);			\
-	SLIST_FIRST(head2) = swap_first;				\
-} while (0)
-
-/*
- * Singly-linked Tail queue declarations.
- */
-#define	STAILQ_HEAD(name, type)						\
-struct name {								\
-	struct type *stqh_first;/* first element */			\
-	struct type **stqh_last;/* addr of last next element */		\
-}
-
-#define	STAILQ_HEAD_INITIALIZER(head)					\
-	{ NULL, &(head).stqh_first }
-
-#define	STAILQ_ENTRY(type)						\
-struct {								\
-	struct type *stqe_next;	/* next element */			\
-}
-
-/*
- * Singly-linked Tail queue functions.
- */
-#define	STAILQ_CONCAT(head1, head2) do {				\
-	if (!STAILQ_EMPTY((head2))) {					\
-		*(head1)->stqh_last = (head2)->stqh_first;		\
-		(head1)->stqh_last = (head2)->stqh_last;		\
-		STAILQ_INIT((head2));					\
-	}								\
-} while (0)
-
-#define	STAILQ_EMPTY(head)	((head)->stqh_first == NULL)
-
-#define	STAILQ_FIRST(head)	((head)->stqh_first)
-
-#define	STAILQ_FOREACH(var, head, field)				\
-	for((var) = STAILQ_FIRST((head));				\
-	   (var);							\
-	   (var) = STAILQ_NEXT((var), field))
-
-
-#define	STAILQ_FOREACH_SAFE(var, head, field, tvar)			\
-	for ((var) = STAILQ_FIRST((head));				\
-	    (var) && ((tvar) = STAILQ_NEXT((var), field), 1);		\
-	    (var) = (tvar))
-
-#define	STAILQ_INIT(head) do {						\
-	STAILQ_FIRST((head)) = NULL;					\
-	(head)->stqh_last = &STAILQ_FIRST((head));			\
-} while (0)
-
-#define	STAILQ_INSERT_AFTER(head, tqelm, elm, field) do {		\
-	if ((STAILQ_NEXT((elm), field) = STAILQ_NEXT((tqelm), field)) == NULL)\
-		(head)->stqh_last = &STAILQ_NEXT((elm), field);		\
-	STAILQ_NEXT((tqelm), field) = (elm);				\
-} while (0)
-
-#define	STAILQ_INSERT_HEAD(head, elm, field) do {			\
-	if ((STAILQ_NEXT((elm), field) = STAILQ_FIRST((head))) == NULL)	\
-		(head)->stqh_last = &STAILQ_NEXT((elm), field);		\
-	STAILQ_FIRST((head)) = (elm);					\
-} while (0)
-
-#define	STAILQ_INSERT_TAIL(head, elm, field) do {			\
-	STAILQ_NEXT((elm), field) = NULL;				\
-	*(head)->stqh_last = (elm);					\
-	(head)->stqh_last = &STAILQ_NEXT((elm), field);			\
-} while (0)
-
-#define	STAILQ_LAST(head, type, field)					\
-	(STAILQ_EMPTY((head)) ?						\
-		NULL :							\
-	        ((struct type *)(void *)				\
-		((char *)((head)->stqh_last) - __offsetof(struct type, field))))
-
-#define	STAILQ_NEXT(elm, field)	((elm)->field.stqe_next)
-
-#define	STAILQ_REMOVE(head, elm, type, field) do {			\
-	QMD_SAVELINK(oldnext, (elm)->field.stqe_next);			\
-	if (STAILQ_FIRST((head)) == (elm)) {				\
-		STAILQ_REMOVE_HEAD((head), field);			\
-	}								\
-	else {								\
-		struct type *curelm = STAILQ_FIRST((head));		\
-		while (STAILQ_NEXT(curelm, field) != (elm))		\
-			curelm = STAILQ_NEXT(curelm, field);		\
-		STAILQ_REMOVE_AFTER(head, curelm, field);		\
-	}								\
-	TRASHIT(*oldnext);						\
-} while (0)
-
-#define STAILQ_REMOVE_AFTER(head, elm, field) do {			\
-	if ((STAILQ_NEXT(elm, field) =					\
-	     STAILQ_NEXT(STAILQ_NEXT(elm, field), field)) == NULL)	\
-		(head)->stqh_last = &STAILQ_NEXT((elm), field);		\
-} while (0)
-
-#define	STAILQ_REMOVE_HEAD(head, field) do {				\
-	if ((STAILQ_FIRST((head)) =					\
-	     STAILQ_NEXT(STAILQ_FIRST((head)), field)) == NULL)		\
-		(head)->stqh_last = &STAILQ_FIRST((head));		\
-} while (0)
-
-#define STAILQ_SWAP(head1, head2, type) do {				\
-	struct type *swap_first = STAILQ_FIRST(head1);			\
-	struct type **swap_last = (head1)->stqh_last;			\
-	STAILQ_FIRST(head1) = STAILQ_FIRST(head2);			\
-	(head1)->stqh_last = (head2)->stqh_last;			\
-	STAILQ_FIRST(head2) = swap_first;				\
-	(head2)->stqh_last = swap_last;					\
-	if (STAILQ_EMPTY(head1))					\
-		(head1)->stqh_last = &STAILQ_FIRST(head1);		\
-	if (STAILQ_EMPTY(head2))					\
-		(head2)->stqh_last = &STAILQ_FIRST(head2);		\
-} while (0)
-
-
-/*
- * List declarations.
- */
-#define	LIST_HEAD(name, type)						\
-struct name {								\
-	struct type *lh_first;	/* first element */			\
-}
-
-#define	LIST_HEAD_INITIALIZER(head)					\
-	{ NULL }
-
-#define	LIST_ENTRY(type)						\
-struct {								\
-	struct type *le_next;	/* next element */			\
-	struct type **le_prev;	/* address of previous next element */	\
-}
-
-/*
- * List functions.
- */
-
-#if (defined(_KERNEL) && defined(INVARIANTS))
-#define	QMD_LIST_CHECK_HEAD(head, field) do {				\
-	if (LIST_FIRST((head)) != NULL &&				\
-	    LIST_FIRST((head))->field.le_prev !=			\
-	     &LIST_FIRST((head)))					\
-		panic("Bad list head %p first->prev != head", (head));	\
-} while (0)
-
-#define	QMD_LIST_CHECK_NEXT(elm, field) do {				\
-	if (LIST_NEXT((elm), field) != NULL &&				\
-	    LIST_NEXT((elm), field)->field.le_prev !=			\
-	     &((elm)->field.le_next))					\
-	     	panic("Bad link elm %p next->prev != elm", (elm));	\
-} while (0)
-
-#define	QMD_LIST_CHECK_PREV(elm, field) do {				\
-	if (*(elm)->field.le_prev != (elm))				\
-		panic("Bad link elm %p prev->next != elm", (elm));	\
-} while (0)
-#else
-#define	QMD_LIST_CHECK_HEAD(head, field)
-#define	QMD_LIST_CHECK_NEXT(elm, field)
-#define	QMD_LIST_CHECK_PREV(elm, field)
-#endif /* (_KERNEL && INVARIANTS) */
-
-#define	LIST_EMPTY(head)	((head)->lh_first == NULL)
-
-#define	LIST_FIRST(head)	((head)->lh_first)
-
-#define	LIST_FOREACH(var, head, field)					\
-	for ((var) = LIST_FIRST((head));				\
-	    (var);							\
-	    (var) = LIST_NEXT((var), field))
-
-#define	LIST_FOREACH_SAFE(var, head, field, tvar)			\
-	for ((var) = LIST_FIRST((head));				\
-	    (var) && ((tvar) = LIST_NEXT((var), field), 1);		\
-	    (var) = (tvar))
-
-#define	LIST_INIT(head) do {						\
-	LIST_FIRST((head)) = NULL;					\
-} while (0)
-
-#define	LIST_INSERT_AFTER(listelm, elm, field) do {			\
-	QMD_LIST_CHECK_NEXT(listelm, field);				\
-	if ((LIST_NEXT((elm), field) = LIST_NEXT((listelm), field)) != NULL)\
-		LIST_NEXT((listelm), field)->field.le_prev =		\
-		    &LIST_NEXT((elm), field);				\
-	LIST_NEXT((listelm), field) = (elm);				\
-	(elm)->field.le_prev = &LIST_NEXT((listelm), field);		\
-} while (0)
-
-#define	LIST_INSERT_BEFORE(listelm, elm, field) do {			\
-	QMD_LIST_CHECK_PREV(listelm, field);				\
-	(elm)->field.le_prev = (listelm)->field.le_prev;		\
-	LIST_NEXT((elm), field) = (listelm);				\
-	*(listelm)->field.le_prev = (elm);				\
-	(listelm)->field.le_prev = &LIST_NEXT((elm), field);		\
-} while (0)
-
-#define	LIST_INSERT_HEAD(head, elm, field) do {				\
-	QMD_LIST_CHECK_HEAD((head), field);				\
-	if ((LIST_NEXT((elm), field) = LIST_FIRST((head))) != NULL)	\
-		LIST_FIRST((head))->field.le_prev = &LIST_NEXT((elm), field);\
-	LIST_FIRST((head)) = (elm);					\
-	(elm)->field.le_prev = &LIST_FIRST((head));			\
-} while (0)
-
-#define	LIST_NEXT(elm, field)	((elm)->field.le_next)
-
-#define	LIST_REMOVE(elm, field) do {					\
-	QMD_SAVELINK(oldnext, (elm)->field.le_next);			\
-	QMD_SAVELINK(oldprev, (elm)->field.le_prev);			\
-	QMD_LIST_CHECK_NEXT(elm, field);				\
-	QMD_LIST_CHECK_PREV(elm, field);				\
-	if (LIST_NEXT((elm), field) != NULL)				\
-		LIST_NEXT((elm), field)->field.le_prev = 		\
-		    (elm)->field.le_prev;				\
-	*(elm)->field.le_prev = LIST_NEXT((elm), field);		\
-	TRASHIT(*oldnext);						\
-	TRASHIT(*oldprev);						\
-} while (0)
-
-#define LIST_SWAP(head1, head2, type, field) do {			\
-	struct type *swap_tmp = LIST_FIRST((head1));			\
-	LIST_FIRST((head1)) = LIST_FIRST((head2));			\
-	LIST_FIRST((head2)) = swap_tmp;					\
-	if ((swap_tmp = LIST_FIRST((head1))) != NULL)			\
-		swap_tmp->field.le_prev = &LIST_FIRST((head1));		\
-	if ((swap_tmp = LIST_FIRST((head2))) != NULL)			\
-		swap_tmp->field.le_prev = &LIST_FIRST((head2));		\
-} while (0)
-
-/*
- * Tail queue declarations.
- */
-#define	TAILQ_HEAD(name, type)						\
-struct name {								\
-	struct type *tqh_first;	/* first element */			\
-	struct type **tqh_last;	/* addr of last next element */		\
-	TRACEBUF							\
-}
-
-#define	TAILQ_HEAD_INITIALIZER(head)					\
-	{ NULL, &(head).tqh_first }
-
-#define	TAILQ_ENTRY(type)						\
-struct {								\
-	struct type *tqe_next;	/* next element */			\
-	struct type **tqe_prev;	/* address of previous next element */	\
-	TRACEBUF							\
-}
-
-/*
- * Tail queue functions.
- */
-#if (defined(_KERNEL) && defined(INVARIANTS))
-#define	QMD_TAILQ_CHECK_HEAD(head, field) do {				\
-	if (!TAILQ_EMPTY(head) &&					\
-	    TAILQ_FIRST((head))->field.tqe_prev !=			\
-	     &TAILQ_FIRST((head)))					\
-		panic("Bad tailq head %p first->prev != head", (head));	\
-} while (0)
-
-#define	QMD_TAILQ_CHECK_TAIL(head, field) do {				\
-	if (*(head)->tqh_last != NULL)					\
-	    	panic("Bad tailq NEXT(%p->tqh_last) != NULL", (head)); 	\
-} while (0)
-
-#define	QMD_TAILQ_CHECK_NEXT(elm, field) do {				\
-	if (TAILQ_NEXT((elm), field) != NULL &&				\
-	    TAILQ_NEXT((elm), field)->field.tqe_prev !=			\
-	     &((elm)->field.tqe_next))					\
-		panic("Bad link elm %p next->prev != elm", (elm));	\
-} while (0)
-
-#define	QMD_TAILQ_CHECK_PREV(elm, field) do {				\
-	if (*(elm)->field.tqe_prev != (elm))				\
-		panic("Bad link elm %p prev->next != elm", (elm));	\
-} while (0)
-#else
-#define	QMD_TAILQ_CHECK_HEAD(head, field)
-#define	QMD_TAILQ_CHECK_TAIL(head, headname)
-#define	QMD_TAILQ_CHECK_NEXT(elm, field)
-#define	QMD_TAILQ_CHECK_PREV(elm, field)
-#endif /* (_KERNEL && INVARIANTS) */
-
-#define	TAILQ_CONCAT(head1, head2, field) do {				\
-	if (!TAILQ_EMPTY(head2)) {					\
-		*(head1)->tqh_last = (head2)->tqh_first;		\
-		(head2)->tqh_first->field.tqe_prev = (head1)->tqh_last;	\
-		(head1)->tqh_last = (head2)->tqh_last;			\
-		TAILQ_INIT((head2));					\
-		QMD_TRACE_HEAD(head1);					\
-		QMD_TRACE_HEAD(head2);					\
-	}								\
-} while (0)
-
-#define	TAILQ_EMPTY(head)	((head)->tqh_first == NULL)
-
-#define	TAILQ_FIRST(head)	((head)->tqh_first)
-
-#define	TAILQ_FOREACH(var, head, field)					\
-	for ((var) = TAILQ_FIRST((head));				\
-	    (var);							\
-	    (var) = TAILQ_NEXT((var), field))
-
-#define	TAILQ_FOREACH_SAFE(var, head, field, tvar)			\
-	for ((var) = TAILQ_FIRST((head));				\
-	    (var) && ((tvar) = TAILQ_NEXT((var), field), 1);		\
-	    (var) = (tvar))
-
-#define	TAILQ_FOREACH_REVERSE(var, head, headname, field)		\
-	for ((var) = TAILQ_LAST((head), headname);			\
-	    (var);							\
-	    (var) = TAILQ_PREV((var), headname, field))
-
-#define	TAILQ_FOREACH_REVERSE_SAFE(var, head, headname, field, tvar)	\
-	for ((var) = TAILQ_LAST((head), headname);			\
-	    (var) && ((tvar) = TAILQ_PREV((var), headname, field), 1);	\
-	    (var) = (tvar))
-
-#define	TAILQ_INIT(head) do {						\
-	TAILQ_FIRST((head)) = NULL;					\
-	(head)->tqh_last = &TAILQ_FIRST((head));			\
-	QMD_TRACE_HEAD(head);						\
-} while (0)
-
-#define	TAILQ_INSERT_AFTER(head, listelm, elm, field) do {		\
-	QMD_TAILQ_CHECK_NEXT(listelm, field);				\
-	if ((TAILQ_NEXT((elm), field) = TAILQ_NEXT((listelm), field)) != NULL)\
-		TAILQ_NEXT((elm), field)->field.tqe_prev = 		\
-		    &TAILQ_NEXT((elm), field);				\
-	else {								\
-		(head)->tqh_last = &TAILQ_NEXT((elm), field);		\
-		QMD_TRACE_HEAD(head);					\
-	}								\
-	TAILQ_NEXT((listelm), field) = (elm);				\
-	(elm)->field.tqe_prev = &TAILQ_NEXT((listelm), field);		\
-	QMD_TRACE_ELEM(&(elm)->field);					\
-	QMD_TRACE_ELEM(&listelm->field);				\
-} while (0)
-
-#define	TAILQ_INSERT_BEFORE(listelm, elm, field) do {			\
-	QMD_TAILQ_CHECK_PREV(listelm, field);				\
-	(elm)->field.tqe_prev = (listelm)->field.tqe_prev;		\
-	TAILQ_NEXT((elm), field) = (listelm);				\
-	*(listelm)->field.tqe_prev = (elm);				\
-	(listelm)->field.tqe_prev = &TAILQ_NEXT((elm), field);		\
-	QMD_TRACE_ELEM(&(elm)->field);					\
-	QMD_TRACE_ELEM(&listelm->field);				\
-} while (0)
-
-#define	TAILQ_INSERT_HEAD(head, elm, field) do {			\
-	QMD_TAILQ_CHECK_HEAD(head, field);				\
-	if ((TAILQ_NEXT((elm), field) = TAILQ_FIRST((head))) != NULL)	\
-		TAILQ_FIRST((head))->field.tqe_prev =			\
-		    &TAILQ_NEXT((elm), field);				\
-	else								\
-		(head)->tqh_last = &TAILQ_NEXT((elm), field);		\
-	TAILQ_FIRST((head)) = (elm);					\
-	(elm)->field.tqe_prev = &TAILQ_FIRST((head));			\
-	QMD_TRACE_HEAD(head);						\
-	QMD_TRACE_ELEM(&(elm)->field);					\
-} while (0)
-
-#define	TAILQ_INSERT_TAIL(head, elm, field) do {			\
-	QMD_TAILQ_CHECK_TAIL(head, field);				\
-	TAILQ_NEXT((elm), field) = NULL;				\
-	(elm)->field.tqe_prev = (head)->tqh_last;			\
-	*(head)->tqh_last = (elm);					\
-	(head)->tqh_last = &TAILQ_NEXT((elm), field);			\
-	QMD_TRACE_HEAD(head);						\
-	QMD_TRACE_ELEM(&(elm)->field);					\
-} while (0)
-
-#define	TAILQ_LAST(head, headname)					\
-	(*(((struct headname *)((head)->tqh_last))->tqh_last))
-
-#define	TAILQ_NEXT(elm, field) ((elm)->field.tqe_next)
-
-#define	TAILQ_PREV(elm, headname, field)				\
-	(*(((struct headname *)((elm)->field.tqe_prev))->tqh_last))
-
-#define	TAILQ_REMOVE(head, elm, field) do {				\
-	QMD_SAVELINK(oldnext, (elm)->field.tqe_next);			\
-	QMD_SAVELINK(oldprev, (elm)->field.tqe_prev);			\
-	QMD_TAILQ_CHECK_NEXT(elm, field);				\
-	QMD_TAILQ_CHECK_PREV(elm, field);				\
-	if ((TAILQ_NEXT((elm), field)) != NULL)				\
-		TAILQ_NEXT((elm), field)->field.tqe_prev = 		\
-		    (elm)->field.tqe_prev;				\
-	else {								\
-		(head)->tqh_last = (elm)->field.tqe_prev;		\
-		QMD_TRACE_HEAD(head);					\
-	}								\
-	*(elm)->field.tqe_prev = TAILQ_NEXT((elm), field);		\
-	TRASHIT(*oldnext);						\
-	TRASHIT(*oldprev);						\
-	QMD_TRACE_ELEM(&(elm)->field);					\
-} while (0)
-
-#define TAILQ_SWAP(head1, head2, type, field) do {			\
-	struct type *swap_first = (head1)->tqh_first;			\
-	struct type **swap_last = (head1)->tqh_last;			\
-	(head1)->tqh_first = (head2)->tqh_first;			\
-	(head1)->tqh_last = (head2)->tqh_last;				\
-	(head2)->tqh_first = swap_first;				\
-	(head2)->tqh_last = swap_last;					\
-	if ((swap_first = (head1)->tqh_first) != NULL)			\
-		swap_first->field.tqe_prev = &(head1)->tqh_first;	\
-	else								\
-		(head1)->tqh_last = &(head1)->tqh_first;		\
-	if ((swap_first = (head2)->tqh_first) != NULL)			\
-		swap_first->field.tqe_prev = &(head2)->tqh_first;	\
-	else								\
-		(head2)->tqh_last = &(head2)->tqh_first;		\
-} while (0)
-
-#endif /* !_SYS_QUEUE_H_ */
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Mon Feb 07 07:29:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 07:29:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266466.460149 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGyT8-0001xj-BD; Mon, 07 Feb 2022 07:29:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266466.460149; Mon, 07 Feb 2022 07:29:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGyT8-0001xc-8H; Mon, 07 Feb 2022 07:29:50 +0000
Received: by outflank-mailman (input) for mailman id 266466;
 Mon, 07 Feb 2022 07:29:49 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=owYM=SW=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nGyT7-0001xW-0h
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 07:29:49 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ba0fb410-87e7-11ec-8f75-fffcc8bd4f1a;
 Mon, 07 Feb 2022 08:29:47 +0100 (CET)
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2059.outbound.protection.outlook.com [104.47.1.59]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-12-OVmlwWugPF-LAq75rShKug-1; Mon, 07 Feb 2022 08:29:45 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by HE1PR0402MB3513.eurprd04.prod.outlook.com (2603:10a6:7:87::29)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Mon, 7 Feb
 2022 07:29:43 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.018; Mon, 7 Feb 2022
 07:29:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ba0fb410-87e7-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644218987;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=jvASHfV8EVi/c7V/xCEFY/mhTVJcHzBNIBTR+4OJZ5U=;
	b=TsjRJ02JQAyEIF7kEFS2o87UiSZnhDPL4KnWq5sy32MreXlayvobNbnRpVS8tXsd2yg/+Y
	zJLyRgaVHCqbqvsnbLJ/AS70Huvm5AzST7h1R/6DDrT44GTfd/r8CFqZ9Xt0wtYKbdMMjH
	Gcr39Y9IU72e2nloXq6uGjKqmSxCfwI=
X-MC-Unique: OVmlwWugPF-LAq75rShKug-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=n8Lh958Gaa1f1tfPhgD1QDCh9Tdo544c8QqIC9zalGmAKzgliLlFSBm0zzuG9AcKni7OKBKlRnToA0SNdV+0LpAH2zdrOQbAxdbNn2H/iXKa/NfxK27NHsd5XT90EEaxgGX4wXbEhlrjMsfXCbr4em/0jq7D2km76JatVL4khHcxMUJfW4Lba6j32RT5EyA7hXHlGhwZ1urkQczWxeIkpoW186Tb3BOXUldYHbkFYUa51q/I0+539z2Vs74wtbYMc4TxjZ+gX3p1FIXWbbU48kEU0bLi3vuvWmCcPvSdQ+eMOvDq7HMmB9s6Wc2PjzxgWT47uBZVFkxY9tYYbX4c0g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=jvASHfV8EVi/c7V/xCEFY/mhTVJcHzBNIBTR+4OJZ5U=;
 b=WjgQ+FZlcH21hZY6Y+j1HwZKvwHusH51+q1AgwuBT9VrZdFZF0iTYAeOmb8qq4DEYkS9JTHDgsMcKbmhkuT9A124phY/vj/6d2pTLhY6YLJXD3rMo+3E0LEOZokGjLZ+h7ROuHZICkNZ4oi5WZPlHW6L/HfEf3qfEZ+1mWZbqPMl0BEaLaJW9BVQ/Lp06hUwClB+iREPP8JWvqgd6LzxMgrMEm1Xjy/0Uso1lOGvl2UhNWTqN9M33GJlmQNNrMBXHmIi5CgcC6RXSbXu2aqGQudao8iQgNu07Fr4eLNJtc+a9ZFzF5nK04c7jGqw8YRKCUB/BtVeDPTwfneHJDKk0Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <6f0a015b-c48f-76ed-9a51-39c045ff5927@suse.com>
Date: Mon, 7 Feb 2022 08:29:43 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v6 10/13] vpci/header: reset the command register when
 adding devices
Content-Language: en-US
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Cc: "julien@xen.org" <julien@xen.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Artem Mygaiev <Artem_Mygaiev@epam.com>,
 "roger.pau@citrix.com" <roger.pau@citrix.com>,
 "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
 "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
 "paul@xen.org" <paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-11-andr2000@gmail.com>
 <96381d7e-dafc-acee-3abf-f9815deb207c@suse.com>
 <ef76faac-f9d3-1cb8-06b5-189ccd299542@epam.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <ef76faac-f9d3-1cb8-06b5-189ccd299542@epam.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM7PR03CA0016.eurprd03.prod.outlook.com
 (2603:10a6:20b:130::26) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 39e2ab6e-2cdd-4155-c49c-08d9ea0b9bb7
X-MS-TrafficTypeDiagnostic: HE1PR0402MB3513:EE_
X-Microsoft-Antispam-PRVS:
	<HE1PR0402MB35135E6565190A8C96963A19B32C9@HE1PR0402MB3513.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	6m4C9RVEG8yANCeEuwslYUuKTbzKNdtJkTWMH3wO+RLasdMHTZ/ueK8ALErVO+UlsIYEGwCvIMo4I1ojN0wl22UfwlCa+Z5kUQAmva3Lv6mzRq8CHmw8csCXhsShsWNfsDRNQJI0sED7n1INsEqqx/tupN9KPnuqP0Mm8xLjAfl3PlsXw3X+tnVh8n8AfZW/LqI781wtS12RYv7h0AFfgSdI+zWujRt/0euwmhJSSQNVvIUj0OPJsHXQM1jMsn3H8Wp4KUwBc06lABl5LsnREJC+Nzpj0PTE5Pop0AiPSUGuR/WJk/7q5XmktA1D62k3pto7R3YO7aQ+kf0BOBK66UEIfq05pXmg3zgP5RF1veq645086LJZV7xO1ObHlq2j+Hey60SspqQZ+W1NPFIwbIPIy3WWg+KHYehBu+Q9tvIsSEo25S6XiFPSg1OHPoK9Ot0KIGbhstatAdjel2pEFJ6fSbDQFSUG9TiD8kxWdrHenegFG7q8EWh+VbiUc3ckEoa6YMqcCCOwNSOV1kcUY1EzHy+dq9IQ5mjrIHD5sHf7CFjzuwv72h3iSldeS8UdKnE8/QBijuuSi/945ydNy9NwJ9EJAjgroopH7qe6IMOV34GAu9hOnYyXFLMxzKg3v0s6qzCRqSEvTyshpicnl2l6iE0+XbSYg7zt0s0bfvCD6Kft9Dx9qxR4CMyjF6EVPV0zgvLAnW55WsP5lb3ljruujjmYA7c1phlbeHvNIQg=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(83380400001)(508600001)(54906003)(6486002)(86362001)(2616005)(53546011)(6916009)(6512007)(186003)(6506007)(26005)(31696002)(2906002)(36756003)(8936002)(7416002)(5660300002)(38100700002)(4326008)(8676002)(66946007)(31686004)(66556008)(316002)(66476007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?OTdXRFFjcVI3Z0F0c0xGSjN3Q3NGOUlJMmppcTA4clorbDJFSkNJVnVWa0dt?=
 =?utf-8?B?VlZQYjdwVHl6UUhsQmt6RnBVcDUzcS9ZNzAvb0hWemFTWHl4elBiT3liRG9D?=
 =?utf-8?B?b09idVkwREJBM2cwUGgrZ3lzL0gzbFFHc2RHMGliWFFycWk5YTZ1QXhNLytv?=
 =?utf-8?B?THYvbVQ1TlplNDJwYU1iMXBPRzE3T2tiSjVrNGQ5UGpibVAvblZaaEFJLzB3?=
 =?utf-8?B?SThGRGwvbjRFOWM4cW1MNDQ3RG5FeVk5ZmFZQVIyWDhJcGkzdGJ1OGFmUHNT?=
 =?utf-8?B?L1dvUVd1L044QTgzRERDKy92dmpwZWptNWd0ajAxWHNiMVVjSHAyc0FQZjNX?=
 =?utf-8?B?cG5yQ3JWdGNEODIrRC9xditBSEpESGhhb3RSYU52cER3aDZpZjFvdm1hNGli?=
 =?utf-8?B?djB3TmY0VW9xUnRMekxZVnNIYWt4Uk5FTDIxZjZBYktWU2J1Z042WUI0d0o4?=
 =?utf-8?B?YytxdE5kR2ZkMXAwY2RyV3JPUEp2cVZOdVVGeDJWUzd6MHJiQW1PcGFJSUdp?=
 =?utf-8?B?c2x2cHBOa1FmR2Z0SStveFdSN3Z2cHRRdlRyYllkZmtVM2RWblZaSHVabXpG?=
 =?utf-8?B?L3N6aFZTYkx3dUhSRmFsQU44Z2ppbWxxNkg2bkhtNWxLdTByN2tNbXFRK2xR?=
 =?utf-8?B?VytGOWxtL0lNTWExSXpzU1pyTFJaZGlTTFhIRUJJanFtZU9QaG9BSjlSTmg5?=
 =?utf-8?B?MGMrTmdBOGVoQW5JQUYvZWphZysvSzIrSWRkVms4Ui96TERlMEZEaFZKT0lX?=
 =?utf-8?B?VTg0eDJrL0wyQk9PMXRNMEtuejZvMHg1QjhWNGJKczN2WitUR1lwd2tySVlw?=
 =?utf-8?B?RGNuaTM3eEwxbnNrMTlWa3g0Z2RWQjh6YlNBOHNmVHcvbUlBS0ZBWkJGcmNR?=
 =?utf-8?B?cnRBelg1T0ttd3Q2QVNVSmIxSUVtbWFyOENpN0t4akNWQ3lQWithUVJ4OFNS?=
 =?utf-8?B?eTNKRGVSYXM3TzJKcFBpL3pxejU0OFZWakZIdFFUYmovZ21FbWNoK0twOVNq?=
 =?utf-8?B?WVRsTXE5c0JNTExoRHlhKzlaL2xjVWFnblNRS1RIZm0wZnM0RysvM2o5aHN6?=
 =?utf-8?B?ZjYwSnpKR2UzZ2t1c210SzZBODd0d3J4WDBXTWpzT2xjb0x0OExKMmlVY1pa?=
 =?utf-8?B?c004ZFViUnE3K0JxTXRuL2IzWUtEcXlMQ0ZTZGprOUJ3ZGlXaGJyaE1UMlpq?=
 =?utf-8?B?clBsL3pJUHdBbG94VFYweE5vKzFZMjVDY0syMEt3U0NiS0I0NkcyMFFpSkdJ?=
 =?utf-8?B?Vm0yemlGckpKVVlUWDcyVEN1Tmw0TmZlRGZZOXRiL3F0N0drcTZqL2dVa2Y5?=
 =?utf-8?B?YUc0cFBRUzlGUlhHa2V4ZUcyL0piMjFmM0U0WGFZbHdaTzB1d3Y4RU9wWlRX?=
 =?utf-8?B?Skc4bzlvb3BRZ2xrcFFZaU0vMWpIL2psc0k2TlNxY2phbkd0d0c4QkdVZDlS?=
 =?utf-8?B?SGZkRWRVVVBDbkpjdFVkMnlpTkd3RlB3TlJScmN0Sks2OWFha3V0OFJ0UTE4?=
 =?utf-8?B?MFNkdWk5MGliMmtHSnFJWmtKME1wdkNvMWJXSEQ1enp5a3d1eGJEVHFPSnRJ?=
 =?utf-8?B?azIybVlQSXRMVUpwZXJMME1RNGxlVEtxanVCbTl3alI5NVBGRElCZ1pBOENo?=
 =?utf-8?B?L1J2MjIrSXVzdnFpcWVSeVEvTm1WcS9QNTZERTZXbTFPdGoxWklBRTJzVFcr?=
 =?utf-8?B?dExITkZOWUVDUGZBbktOeXFzN0czTkxNVGZGbDRpd2x3SldwRU5lV0k1SGJO?=
 =?utf-8?B?UUdVMk9QekJ1a2swZG85ZUxoM1plSXVKTW1Qem9SakFHVTVkSFE0SURESW81?=
 =?utf-8?B?MEJMZHAzU0VQNDd2UmdGdFlyTG5YWnZ0Q1RYN2dKeG9tM0ZIbk5nOEd6ZElS?=
 =?utf-8?B?SWNSMTM3dU1IcnhGcmU0RjZtNnNxV1RNQUdGc0FweUQvWjc1SXF6OCszeC9L?=
 =?utf-8?B?c0YxWDE0bDRMMjBjM3ppcmpSV3NBTVhmTUZ4NThBTjBQMmdna0RjUGZUYVA3?=
 =?utf-8?B?dWErTGcrczNLZ3VyVy9ka25VcE1PMVpuVitwMmhMcTh4aDhjall1N2Zqb01P?=
 =?utf-8?B?cFpTWTJiYUswbTZPQWc2RE5vSW9BRURQQzdYM1NmK2tPTGZYZTlqbm5maVkw?=
 =?utf-8?B?VDZrNUUrcXltSzBGVlpLM2pPQjZmdGhwV0lmR2RQTEFkdTliclJOUVhzMXE2?=
 =?utf-8?Q?1t1/QHT+MKvehc+ejTeZTRo=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 39e2ab6e-2cdd-4155-c49c-08d9ea0b9bb7
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2022 07:29:43.0499
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JL20Ptw09rxXHJhJYfwm+kqy7o/1i8ZWy2K+SdcyoD3Y65pffFYM+dssPBKBjp9Rxyu0649b/uhANYS7bUmroA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0402MB3513

On 04.02.2022 15:37, Oleksandr Andrushchenko wrote:
> On 04.02.22 16:30, Jan Beulich wrote:
>> On 04.02.2022 07:34, Oleksandr Andrushchenko wrote:
>>> Reset the command register when assigning a PCI device to a guest:
>>> according to the PCI spec the PCI_COMMAND register is typically all 0's
>>> after reset.
>> It's not entirely clear to me whether setting the hardware register to
>> zero is okay. What wants to be zero is the value the guest observes
>> initially.
> "the PCI spec says the PCI_COMMAND register is typically all 0's after reset."
> Why wouldn't it be ok? What is the exact concern here?

The concern is - as voiced is similar ways before, perhaps in other
contexts - that you need to consider bit-by-bit whether overwriting
with 0 what is currently there is okay. Xen and/or Dom0 may have put
values there which they expect to remain unaltered. I guess
PCI_COMMAND_SERR is a good example: While the guest's view of this
will want to be zero initially, the host having set it to 1 may not
easily be overwritten with 0, or else you'd effectively imply giving
the guest control of the bit.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 07 07:30:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 07:30:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266471.460160 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGyU3-0003DC-L8; Mon, 07 Feb 2022 07:30:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266471.460160; Mon, 07 Feb 2022 07:30:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGyU3-0003D5-I1; Mon, 07 Feb 2022 07:30:47 +0000
Received: by outflank-mailman (input) for mailman id 266471;
 Mon, 07 Feb 2022 07:30:46 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nGyU2-0003Cp-Lx; Mon, 07 Feb 2022 07:30:46 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nGyU2-0004if-Ij; Mon, 07 Feb 2022 07:30:46 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nGyU2-00055N-1D; Mon, 07 Feb 2022 07:30:46 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nGyU2-0007be-0m; Mon, 07 Feb 2022 07:30:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=PXdxGcIrsoTCusqne9bfPLIINiICkq59quSz22wG3yI=; b=jjrpKEsWUls4Lk38/ewI0JOMIM
	vRA1u2PakPPVdsmMfBi+DMc3+cbCpBPQ54mRyed5vZf90TftWJcWSizrHYGUasE+l/HHZyRaz4ZoO
	kTfq/jC9Itj7e4Ks63p1dTL9oUPdoYhj9Ve58M3pw7g6DInNCt2vZdFnGmpx784ZjtmQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168040-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 168040: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=e7be6be775e07cb373ff5d0bf933a36cd0b44f88
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 07 Feb 2022 07:30:46 +0000

flight 168040 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168040/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              e7be6be775e07cb373ff5d0bf933a36cd0b44f88
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  577 days
Failing since        151818  2020-07-11 04:18:52 Z  576 days  558 attempts
Testing same since   168031  2022-02-06 04:21:52 Z    1 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brad Laue <brad@brad-x.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Christophe Fergeau <cfergeau@redhat.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Divya Garg <divya.garg@nutanix.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Emilio Herrera <ehespinosa57@gmail.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Ivan Teterevkov <ivan.teterevkov@nutanix.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Lubomir Rintel <lkundrak@v3.sk>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nicolas Lécureuil <neoclust@mageia.org>
  Nicolas Lécureuil <nicolas.lecureuil@siveo.net>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Rohit Kumar <rohit.kumar3@nutanix.com>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  shenjiatong <yshxxsjt715@gmail.com>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tuguoyi <tu.guoyi@h3c.com>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Vineeth Pillai <viremana@linux.microsoft.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yasuhiko Kamata <belphegor@belbel.or.jp>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 96470 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Feb 07 07:41:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 07:41:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266488.460171 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGye6-0004mS-LP; Mon, 07 Feb 2022 07:41:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266488.460171; Mon, 07 Feb 2022 07:41:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGye6-0004mL-I2; Mon, 07 Feb 2022 07:41:10 +0000
Received: by outflank-mailman (input) for mailman id 266488;
 Mon, 07 Feb 2022 07:41:09 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=owYM=SW=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nGye5-0004mF-9G
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 07:41:09 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4fa3861b-87e9-11ec-8eb8-a37418f5ba1a;
 Mon, 07 Feb 2022 08:41:07 +0100 (CET)
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2054.outbound.protection.outlook.com [104.47.1.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-24-o1nknDzdPx2swUU95rTgbw-1; Mon, 07 Feb 2022 08:41:06 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DBAPR04MB7272.eurprd04.prod.outlook.com (2603:10a6:10:1ad::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Mon, 7 Feb
 2022 07:41:02 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.018; Mon, 7 Feb 2022
 07:41:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4fa3861b-87e9-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644219667;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=1+HZbSM2dItKwztAzlpbiDWHRe2tHjMxRwCxBvZmn8E=;
	b=WkTUM2D4v/c5H9FDlCdXvlv9WbfzI5VeBIirgxN+NpupyMCcbL6q6/Cr1UlhF+Oehcku4H
	n1caSys7iem/bH3vuH04TWD5/BKwRXvPLRvHIHCcT2Xij1bzY9cbEziCtVFrJC82BSF5BH
	R4gAA2ifIpqZn3YqOY1CWdi99BgaduQ=
X-MC-Unique: o1nknDzdPx2swUU95rTgbw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=e5it5mG5GmhPobwXX09dJe38scO/cySnSyBJz1kXP/uUcnrq6w2pJlay9WvSil3+Q/3wZGyeSuYhOQnoo8BF/K/cjHqI/bbzbRwD0i2AP6cICzBJCH/qvMsYeJpKl1W8yTOkaS1U7FcvtLnVG9vyM0shlcuv8rniRT5Tlhcbjpsfu/2LduxGmqZz36wzGLyhu30JumclGCtOKyTx6XVtbMBeLwwHJSx1hlBcc4PX4vyqlCzz4L4si23iTKZPgbt+9ulBgSMIyYgBGr8yERaKu2V4kIrPih9Pic44l1FejAX4xb/PPq8UIyHtiek2dq5MXgBnjXF0BgFjB62Kx31XZQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=1+HZbSM2dItKwztAzlpbiDWHRe2tHjMxRwCxBvZmn8E=;
 b=ZOlVrvdGzjmBVsGE0ZyoX7odu3oM11wcG2clwxSezbc6cLVW+vQY0Yd5Vj9UfkZaXIEH7uVnu3fGFwb5qUFqSpxvQhcCrWVP1Ob50mnqfPP19d0mEngEoQ6qt1smRyS69IEiYdQSpJAcxa2ExjN1wpsEhpxj2f3qQyAHu+PIK+beOxc+YlpC3LKbOi54pujBcZnHWzx6KGQyzyoeuBHxXCeZC5I/OT8wzVG1iynOc3AHTPJpwkb+B+o3OzD0caYtOkxY2a7sjXPon6qfoWbPCzG150V+jESBu/GTBfdhQeFXbuNfJuiSNPbam7iYM/3FJAiDVMxB5tv6crLu/Y6HHA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <2501ce9d-40e5-b49d-b0e5-435544d17d4a@suse.com>
Date: Mon, 7 Feb 2022 08:41:03 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 lkml <linux-kernel@vger.kernel.org>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH] xen/x86: obtain full video frame buffer address for Dom0 also
 under EFI
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR02CA0012.eurprd02.prod.outlook.com
 (2603:10a6:20b:6e::25) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: bae4e898-5a66-4465-c815-08d9ea0d30f2
X-MS-TrafficTypeDiagnostic: DBAPR04MB7272:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<DBAPR04MB7272CE5CB13BA1526B8F972DB32C9@DBAPR04MB7272.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4303;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	KDzK7V5BMfvIo8Q4ZUZ33BLd9FMXwa8iXwDl3suz0KT04KO5GroZynYttX3ymtzb023XoyFrZsUfa/e+k/GbmFiqE3evaDzgM4N9gl4Ep5dl6Rw7D4Zvlh+dtVQfV2VvlyFJCY2vCc8MZ3u8w3sAwmctgt1L9N97I9T5ZvO+2j93bR+vJqYfQah0/hYOhnazIW89dd7c7WTmXLkIC5wUK+kP33kfKBbUnoas+qoqVLG28Z1kumha4T7GKgEDHLUWGgQT01/WJlPorMrNI1B90O3KNTAF8wUVe8IdWek309wBFfKNr89sWbahV6wFk7h12YenXZXZZ/5kqwOg6GbyD/3OYOO9t6+Os8GeiQlkh1mvAg6yQcRMTTLhdwTgKlmDehkztaBVLR7UvkkeWTXksEVTqnoTz9EqhnoQof9WGoaAbHoVbrpRVZer2jpQLqPFFtiqBmOQ5oKOrD664aNito7+pG3VaPO3/Nt2OfhKim1Arb3vuB6yRK5l+DBV/3dMX/HLKeywvclV8JJCQbDaSrncDvglJ9MII2xBHuGBu8d12mkmIYKQg/vzpxHd4P8CQtyWPfVFMy/CiJ/vKzsV+3PHLHidh4+h1asLUrgr5MFKQ5phsZ/yF1RELcHLZ5r3TwhqBE8cBII5cJXQTDIh3VJ7OXl4ZoFK4vwSMdjpblQ6C78SeP+VRaCVHNIcoDgGM/zmRyL+KF4z0TvzGWLkfwQ7CBzvH5s9HHLrdiolYFE=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2906002)(316002)(38100700002)(6486002)(2616005)(4326008)(54906003)(110136005)(86362001)(5660300002)(31696002)(31686004)(36756003)(6512007)(66946007)(8936002)(83380400001)(8676002)(6506007)(26005)(186003)(66556008)(66476007)(508600001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?eHl1b2szVDAzZkVVbWc4RHM4M1VtMUZxYVVTRUZIU0wzTTFWQjlXc3RWOWhy?=
 =?utf-8?B?bnR1aVNWdmw1V1lDRnppMlFzdUJTcFVRTWhEb3JkQzhUWXdxejdtcDFqM0hn?=
 =?utf-8?B?elNGRUxSWlA2a3dhbXlzM2xaaDRxdTRtYTBSN2N6TDRZTXdGbVBiOEVXclN5?=
 =?utf-8?B?M3lZNjd1ZmoxM3hLeEluYkFoNXdmK1BYNHJBRFE3emR4b0w4Q2tDYitUTWth?=
 =?utf-8?B?QXRjbzJhREZ2Z1Vnc05CMTl4SUwyQXdubjZCeDc3cXRZc1BJT01uTzNzcmR2?=
 =?utf-8?B?ZmVuRkRzbEpvNUVLV0s3Q3U4QWhGL2gxYmdsZ0V0Y1FqcUhGZ2tpVmh0c2to?=
 =?utf-8?B?d2RteWE2MzVGMkFxczJoSWR4VTNKdjh1TXdGamRRRXdLNGk1dDhTRDhxQXh6?=
 =?utf-8?B?Ni9zYTJYbHNOZVBwMXhIcG5wMTc3NVJkNkJwWWpYS1VyMFZ3ckphM1JOQVpQ?=
 =?utf-8?B?WU1sbWJMVGg1QkJqdWtCMWxvbS9zY21IdmliZTRLY3I5RGxXcGFIRG5EV1gz?=
 =?utf-8?B?V1hVbG56RUpNYzh6L25rMm1JbGlxVUlyb0lvS05sejBxeDE0aW9zY2lXdVdR?=
 =?utf-8?B?Q1Z3N3ltVXRyUVVIbkNOdjNCbUp4TmlZVG95U0lsTGl2QUs5V2VkVm5oR1Fr?=
 =?utf-8?B?dS8rci9nV2dCNWt0K2xhdUIwR1pSTi85STdnbFRNdHIzMHFFdjdqYWFYMEJ1?=
 =?utf-8?B?ZVNyd0s4QzNDbkhPL1NIMEJ0K3YrK0FQOUJ2YVdleDR3aXM3b28vTTV4amtK?=
 =?utf-8?B?RTgyblBsZnF1NzFMNHM4eFpEKzU5UWNYK0JlWSszbTB3SXNXVmwrRzNPOVh3?=
 =?utf-8?B?V3MxVTQxMndMNFpFc2NLZ0t5RVRYcUlCZ1F2dU9ubmI1Z1o4ZVhQVFcvQXdw?=
 =?utf-8?B?TjM3SExGRkhSL090aFUxNFpGWlZVcGVZcnpUTTJteHdqT0RwYzZFaEhLTk1P?=
 =?utf-8?B?bDJUWjBKdUgwaTl6cWJ5UVh5UmFXVy9SRFpaY0g2aFNuUDB6Z3hqdVhEUnh4?=
 =?utf-8?B?RWsvUU9XUkJFY0orOEM2RmdaWkt6Tm5OQTlCWlVXaGRkT2swcURNU1hhL0dE?=
 =?utf-8?B?bnQ4RUtUOFBublgyeUV2WnU2bzdBSzFQb3VKYWZHa0p4TktJUUM1VFFEOXlE?=
 =?utf-8?B?b2pHUEkzenpVNm0zOWk3d1hyQkVzWFRoZkpsMTJPU2tpay9saDlOcXJ4ZXRD?=
 =?utf-8?B?REc0K201VWV4Rmx0RnFIY1E2Vy9TWGRDb2V5TGdaY3hnRUNIZjRZSVE0UVNW?=
 =?utf-8?B?S2psWjZqWUI5WDB2SS9WQzlnL0FFV0d0cDVDYTUvQ05YeVlrVjhIZGJ0VDAx?=
 =?utf-8?B?WHl1elBGNk1DSFVFcmQySGVZMFc1VWg5ZFM3c0h4QjExZi9GVndUSm0wZUgz?=
 =?utf-8?B?UTZLWlQwQUtsdFczSnNPMnErM1l3Q1oreElFY25YVTlCR0hQeHFQVzRoUzF0?=
 =?utf-8?B?eFhLOFhDK1NVam1IalZnSkhGbU9FQVR2S0VhSHdGUlZDZjJYc2k2NCtJai9J?=
 =?utf-8?B?R2hReWJsMWdHdkVESjYyamtmaXRvNjdWNXdrdGU0UDVpQU9YdG5zVDFlbk90?=
 =?utf-8?B?WXFvaXdQazhLUzdZVUhSS0Ywak02TzdzZjFjeGlUWVY3UnNETGpzM3Q0dDNU?=
 =?utf-8?B?QXJQYW1yUXQ2ZHNLKyt3MkVseUtRMzhsMnV5VTdhL1B1UDRTUkFJM1NxV1hh?=
 =?utf-8?B?NVFzVlAraW5uaTB1SWJHV2hnTjNhaWoyR0JSSVYwNWZ4cjUwUGYvOUpad2Fi?=
 =?utf-8?B?cDd0NHU3WVk0SkVZTWZ0SXdSb1I0OHl1WkFtNmczMGIvNkVBSnVmbGs2Qnhx?=
 =?utf-8?B?aTRMTThqMlp3YU9OcXR3RENEMjM5YlFwOVIvNlpwa1RhRWw3MjFlUkdTaDF2?=
 =?utf-8?B?K0ZLZDdzUGhtNVUzU3dBOWUvMFdBeDVibUlReENHWDQzOGxWN2hkVXVibzJt?=
 =?utf-8?B?ZDdjQk5QMFB1cUFjOW10N0Z6UG9CdFJ6a0RqMjgyVDJ4a05RNTEwbHpZOVZM?=
 =?utf-8?B?cStZRUt6TFFhZ2U4MjlCRXNCYzIxc1htN2RrK3BuSEV4cTd0TnpIYzQyL0c3?=
 =?utf-8?B?KzF1YUtlYWkyUkpReVFvL3J5NHY5c2hUT3VOVWlLdTBNU3NUQ0ZjWE96YmNi?=
 =?utf-8?B?V0IwN0llak5WTHVyVE1oN1djcFg3N1F5OS9ROTJVM2pTbEVlOSs1a0FVUC8y?=
 =?utf-8?Q?ikIL2VDe0j2qNe2Dv+Q6JWc=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bae4e898-5a66-4465-c815-08d9ea0d30f2
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2022 07:41:02.7733
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SRzZYyJ017p5qHhZ9YPyvR0wFBlqc8KfwWwnUB43f0pbFyi89GmbMxKnlnhy2Box7tr/sG1cwQjth0UvpLtzcg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7272

The initial change would not work when Xen was booted from EFI: There is
an early exit from the case block in that case. Move the necessary code
ahead of that.

Fixes: 335e4dd67b48 ("xen/x86: obtain upper 32 bits of video frame buffer address for Dom0")
Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/arch/x86/xen/vga.c
+++ b/arch/x86/xen/vga.c
@@ -57,6 +57,14 @@ void __init xen_init_vga(const struct do
 		screen_info->rsvd_size = info->u.vesa_lfb.rsvd_size;
 		screen_info->rsvd_pos = info->u.vesa_lfb.rsvd_pos;
 
+		if (size >= offsetof(struct dom0_vga_console_info,
+				     u.vesa_lfb.ext_lfb_base)
+		    + sizeof(info->u.vesa_lfb.ext_lfb_base)
+		    && info->u.vesa_lfb.ext_lfb_base) {
+			screen_info->ext_lfb_base = info->u.vesa_lfb.ext_lfb_base;
+			screen_info->capabilities |= VIDEO_CAPABILITY_64BIT_BASE;
+		}
+
 		if (info->video_type == XEN_VGATYPE_EFI_LFB) {
 			screen_info->orig_video_isVGA = VIDEO_TYPE_EFI;
 			break;
@@ -66,14 +74,6 @@ void __init xen_init_vga(const struct do
 				     u.vesa_lfb.mode_attrs)
 		    + sizeof(info->u.vesa_lfb.mode_attrs))
 			screen_info->vesa_attributes = info->u.vesa_lfb.mode_attrs;
-
-		if (size >= offsetof(struct dom0_vga_console_info,
-				     u.vesa_lfb.ext_lfb_base)
-		    + sizeof(info->u.vesa_lfb.ext_lfb_base)
-		    && info->u.vesa_lfb.ext_lfb_base) {
-			screen_info->ext_lfb_base = info->u.vesa_lfb.ext_lfb_base;
-			screen_info->capabilities |= VIDEO_CAPABILITY_64BIT_BASE;
-		}
 		break;
 	}
 }



From xen-devel-bounces@lists.xenproject.org Mon Feb 07 07:57:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 07:57:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266499.460181 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGyuA-0006Pp-5a; Mon, 07 Feb 2022 07:57:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266499.460181; Mon, 07 Feb 2022 07:57:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGyuA-0006Pi-1d; Mon, 07 Feb 2022 07:57:46 +0000
Received: by outflank-mailman (input) for mailman id 266499;
 Mon, 07 Feb 2022 07:57:45 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=owYM=SW=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nGyu9-0006Pc-1M
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 07:57:45 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a151a82c-87eb-11ec-8eb8-a37418f5ba1a;
 Mon, 07 Feb 2022 08:57:43 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2052.outbound.protection.outlook.com [104.47.14.52]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-29-7rK-2w55NhyHNkkn-wwLPw-1; Mon, 07 Feb 2022 08:57:42 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DBBPR04MB7867.eurprd04.prod.outlook.com (2603:10a6:10:1e5::6) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Mon, 7 Feb
 2022 07:57:40 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.018; Mon, 7 Feb 2022
 07:57:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a151a82c-87eb-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644220663;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Kzv55B+liJ3xu1Svsph715mjQ5mphwDYUJs5l0cHa1I=;
	b=O06UseV9RKD6/pL+BhhYHDp2/InveBeiX2BZZwmpGf5+CmZy+go+NsjKR+LLfkDszIqN/b
	6Mh2bfKP1SmDOL2vRJKMgqwbwPHnYi4IVUsf0AJmj7Ua6BVkVBhQVpTHHp8JJdL7u3qJs2
	cOVM9E4umodMcxbYw1l/kSVQzS9ZwvU=
X-MC-Unique: 7rK-2w55NhyHNkkn-wwLPw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Tj14ib4tsbFVTn8ynr5JfU0EgO+n5JWgpNtBCUHnyEKNGlWEzZ5iLJCGRsPrL6GqZY0fxJfUgm0vVXiXioQfAD/E7kYrUZ/beDt8koeicts3xkX4ah4EqJ5Om7wfJpwqF54M4mzr3Yibko7ZJ5JvS+SMxMSz7xhww4ksV1SMS/mPgx0jngO1rN/RhAUcb/hs76fDoa1ljhMTBDsPtKWv/Ff3FpSsYC8kZJfuVy17UxWQThhMjrN7r25gkVbNeR9UkFzA97ukOD8SECOQtXY/5K+jwdappXaOF6LBwrlrwelYdp+uETAttivkMAlr39eak1f6BWquW3dPiPyvNEqs+g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Kzv55B+liJ3xu1Svsph715mjQ5mphwDYUJs5l0cHa1I=;
 b=HKIFXXNuAgMWfV9OoLgGYlVCkTF/ff/cCFGRzHHsRaQKoLK5NOLEof/0JtNpe7CuZQ92l2GF7U6IjjMV38ngxSIMNvRSpElmjonzkw/O8OxgcLtU2A2OqEZLIDYU2g3vStN3RFjcl+uWK19PDBEu9GYswoDMR8WDi5ZgSDl3e5Y19F/wVy0Jiwz3j9fBkl9OpNKBw0UXDN7u92fE2ZDDiQJ9GfRfaOZLnFDqTgvV7VkVBqn619b7JT210FQgOQ6KkbTwX+pbLxU7qELlAfwSOrcHJk0rIVb+jX0WgtBiLwDtTxiRzONpWWFjoptA7km/HlSX6VFU0R237sBcYydmJw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <0e64c52c-1e9c-e89b-abb8-50171d885926@suse.com>
Date: Mon, 7 Feb 2022 08:57:41 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: PCI passthrough support for PVH mode
Content-Language: en-US
To: tosher 1 <akm2tosher@yahoo.com>
Cc: "roger.pau@citrix.com" <roger.pau@citrix.com>,
 "xadimgnik@gmail.com" <xadimgnik@gmail.com>,
 "oleksandr_andrushchenko@epam.com" <oleksandr_andrushchenko@epam.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <709142925.628001.1644127197288.ref@mail.yahoo.com>
 <709142925.628001.1644127197288@mail.yahoo.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <709142925.628001.1644127197288@mail.yahoo.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0101CA0013.eurprd01.prod.exchangelabs.com
 (2603:10a6:206:16::26) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a07a3a03-12ff-4a70-f842-08d9ea0f8372
X-MS-TrafficTypeDiagnostic: DBBPR04MB7867:EE_
X-Microsoft-Antispam-PRVS:
	<DBBPR04MB786772A51A237129B1B1B848B32C9@DBBPR04MB7867.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	YxrPQjN468CMxwDyf6X/sqH2/j5GpDsEY5Gs1pF52AVWh9+STGZrGLgC6E9h7uHZkeUDhSfHaTxRIJYw1yS/Z906s1TNzqCT3zbCZ4buoywANdxXh0PNW/3tZzLUKo8QnDfEZBzNCTJXUgaYlR5JVhONndTo1HDae+VUyDYlpFkA5GRGW3PB7wZYgZQ85Qd58LoOQ3zEkxPY+o4sQ0VCMPmgM7upj/15MpCb4pe1usklU26loo5WkD0Yas2hwfs2JIRn6cBOHUUtm5LfK33ub30G4Qy7AldMbth98AjNr1DkSGSy45RyCaW9WWnucvAPSKJbrPlQHyTNkjsf/4FjMz0cpeqoV6WYfXZUhmuFc58jkjVbjbqObGCkOD4NmhiPUyaVy79wTVRbHXJZEx6VyfPQfFCldf9gR65dBwdnrp1Nro61GmfPm/bb6LhToaQsvJcO7+wEAIE4DR8xUDf0xIQwZLBGgran5L9wUcgBTdhxAuUksmRllrP/qbvXgBwSEBazzfThWL5aI1O1AVdKxNWTZvXelxrZ2ovkdmWbmXCE1BIbLunXSd5MmyB6Pi2rKPVyUGqaz7A17SYRUbQv0Mevt0OHBPFh6oNeX6Y6okwiALvaOEjB1xcsItSKPW+fsbXDxP/6E/UoHJDqFGPuGNPeLymvCYLcgAbTjSZB0e1jX5/rKHZ7Gtx04NXErNxkprnx/ewbqgVhm6f+ZdibDBsxzP9fAcD1YzZmzdiXlzA=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(36756003)(26005)(186003)(54906003)(6506007)(316002)(6512007)(6916009)(38100700002)(2616005)(2906002)(31686004)(53546011)(4744005)(31696002)(86362001)(66946007)(83380400001)(5660300002)(508600001)(8936002)(4326008)(8676002)(6486002)(66556008)(66476007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?SVdBc0xtTXkycmJHOTVINUg5bTdlUlhZaXlDWk5oQnV1SE9QNVVCb21na0ZD?=
 =?utf-8?B?dUZFbWVZZS9iamkvSXFGeW43YWdsYjlsWk52ZUFIY0NvSEFmbFBXZVFyTmcz?=
 =?utf-8?B?ekJObEdBN3NwWnRrdWNZT0tXQkJmbmZMRmJ5bjg1SC9leTZMN01KZmkrUDZI?=
 =?utf-8?B?VWNmUEtXNWgxMndDcU5NTGE3dWVhaVk5Tld6OTJwVW5LL3hKa0tYbGZQVTAz?=
 =?utf-8?B?TkxZNXpOWEY1ckFPckxibXkrYjJKSVMrQmVwamhnYXlveHY2WHp5Z3FuZnpj?=
 =?utf-8?B?N1pnbWZ3Nmc2c1Y2VkVRSElUbFc2ZGRxQVgyckhsU0xtbktUbkxKRnplMnll?=
 =?utf-8?B?WEV2bzZEb2tJZ09JS2VRdUVOVytoQ3ozTVJWRHNRZVhWUkNHMjZqcFdhUHp5?=
 =?utf-8?B?cDNUdEJhM3g2SjFSV1ZYbk9LRjhsUmNzWm5Od2lRcHN3RG5UVjU2bmlJdnZE?=
 =?utf-8?B?VFZXaW9TMCt4MkxjbDdnZXZHQWl3Ymk0Ukdod0pqK2hIZW9IeVNUM0RGK3NW?=
 =?utf-8?B?WFA4UVd4aUdCTFh1VGlWb0t5cU0yS3krNnVMWE5KNXVHSHNiMDJvVkFkOXov?=
 =?utf-8?B?dkgyamJsNk5ZaFdBSWRBU0N0cGpkK2lpOGI0Rm5mWjRkcjNYSkgxWkhkVnRv?=
 =?utf-8?B?Y292VW80ekxOQlF0ZWh0akhFRjcyS244aFI3MUtjazl4bCtSNHQ1b2ZpWkE4?=
 =?utf-8?B?djZaUkliSGphd2Y1WHZtTlUxc2lQYlFESXJMK25LMjJDc0ZTMElSSE9lTVNy?=
 =?utf-8?B?U0FidjVtazdBbzByR1pDT3V2eE5tU3NCOWtiZXVqREZCSE9nZkloeWZJVG12?=
 =?utf-8?B?dStraHJMeklZSzlqbFFjWUp6SjZqTzl1WTFpb0RVMDhkSnZPU2Y4VUdaTU9Q?=
 =?utf-8?B?ekFGQUNRWHdBMVA4ZUtRVVBKQ3BYV1A2S3hUdGw1dTA0TmFHQ1o0VGt6RW5y?=
 =?utf-8?B?NGJXQnprYlBBd3g1NDkycXpUNktReG1BVVgzRnpiaHpsMnZRWk9WbDdDYlNU?=
 =?utf-8?B?OHNuYU9YdlFwclVCQXc5alZwa1NNSkYvSWlNL2hzSnZmLy9TWnpuSGNSSHU5?=
 =?utf-8?B?Ty91UmEybkFicWpkTkpDdVUvWDQ5SENoYzVObm9GZ3IwUGJqckt1aWlhZVNz?=
 =?utf-8?B?bndPZTZIcTFPYlE0cEpXUzF3Qm1zS0NTQk50VlE5UWcwN3ZSaVJqU0VpQ3Bx?=
 =?utf-8?B?U0xKY0RaZTJmaFFrTnJiYlhlRUJhaG1naGtFaEJ1akQ1T2tNMWlWMkZ4U1RP?=
 =?utf-8?B?V21WU3Yyd3pRSm1zRzFCdUlET09uWkJ2U3FIUEdBWHkrUlI4SThUdGF1NHpm?=
 =?utf-8?B?T2ZoamNpRzQ4V2dpL2luQ3dTdG91d0t1U1J4Z2Jqc05RR1JIS2dsdTBnTHox?=
 =?utf-8?B?RWFEZXJROEtnYlNOR3JqL2ZzT0NwcjFDM0lxRWVoa0M0ckxiWFliNE40STRI?=
 =?utf-8?B?NzV3RWxxajEyWUgzV2JWUGE1eURpZVg1NXUwOS81L3FOd205N1ZEZHRVMmpz?=
 =?utf-8?B?WExZejhjd3NGVjd2ZDlhQUM0WUZzMlpRMmZsb1B0NUdEaEkxRWNqSjlER291?=
 =?utf-8?B?NkJrQmdUOXN4L01KYXBXc3dqL01aT0IzUCtDZ2NxMExrTmxGcUZrcm5pb2RG?=
 =?utf-8?B?MjBLczArUDh4eEJFMmVwUm8vM0hFZWZlbXRBNC8xL05BUENHdWxmZHRkcXNZ?=
 =?utf-8?B?R3F0UXc3U3h2NG1LMWlRbXZlUWp5NHpudXhqNzVHbytkekN4UHg4ckpOQk9V?=
 =?utf-8?B?U2xBeXorajd0WDRneXNGdVRiek04Zi9XNjR5bVZHZ3pSa1lEelp3S0F0MWg4?=
 =?utf-8?B?cG8wUkFrTVNJZmJCU0Fvd29WdURXcGgzMDdFQVhLYXRrSzVkMkU5NVRNN3RK?=
 =?utf-8?B?U3BEWlJac05jdzFvQTJNaysyTWZiSkI3M3lGZGpYUkJFVXlMdkFRZWRGcTcx?=
 =?utf-8?B?WUprY0NMQTRKTUIrMmI3Mmx5alRYcCtWeEhwa3RFcDZrNzNkbGhMQjdxeFpL?=
 =?utf-8?B?YVhra1hMeTY5YmJwNG5KRjZ4OEdTV2F5cXZIT25VME9saVNaL0FkWGw5MjZD?=
 =?utf-8?B?OUxoMUIxQTIxTkM1am9YU3hPOXV5bFptRWtWcHA3ZkNWT3lHNUFSUWJVZytv?=
 =?utf-8?B?Y2svRjZKUElWckZhVTdJV0I2VVJXTmRxWGdyZUFxOWtheFBJK3R0azZVSG9D?=
 =?utf-8?Q?flgLhbWzGX56VJ+CEaFPa1w=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a07a3a03-12ff-4a70-f842-08d9ea0f8372
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2022 07:57:40.1801
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BzTIQcZlDRFl20uhBb2wJrJNII9ukfgSXjG4p86XqSzwC+96V8QVj5rpKfMFHu4NGREDOKynQEfU75VT0ZLMiA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7867

On 06.02.2022 06:59, tosher 1 wrote:
> Back in the year 2020, I was inquiring into the status of PCI passthrough support for PVH guests. At that time, Arm people were working on using vPCI for guest VMs. The expectation was to port that implementation to x86 once ready.
> 
> I was wondering if there is any update on this. Does Xen support PCI passthrough for PVH mode yet? Please let me know.

The Arm work is still WIP, and in how far it's going to be straightforward to
re-use that code for x86 is still unclear (afaict at least).

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 07 08:11:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 08:11:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266516.460193 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGz7N-0000lv-Li; Mon, 07 Feb 2022 08:11:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266516.460193; Mon, 07 Feb 2022 08:11:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGz7N-0000lo-Il; Mon, 07 Feb 2022 08:11:25 +0000
Received: by outflank-mailman (input) for mailman id 266516;
 Mon, 07 Feb 2022 08:11:23 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=owYM=SW=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nGz7L-0000li-UG
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 08:11:23 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 89499e78-87ed-11ec-8f75-fffcc8bd4f1a;
 Mon, 07 Feb 2022 09:11:22 +0100 (CET)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2104.outbound.protection.outlook.com [104.47.18.104]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-10-578sGXC5OdyC4YIgvIE-jw-2; Mon, 07 Feb 2022 09:11:21 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM0PR04MB6324.eurprd04.prod.outlook.com (2603:10a6:208:13f::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Mon, 7 Feb
 2022 08:11:19 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.018; Mon, 7 Feb 2022
 08:11:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 89499e78-87ed-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644221482;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=XywlAjTsXDZgrpXx3Ss1iRAl8VekY6dFKCueH/IrcNY=;
	b=WhDXsuVDSjwLF5E55Kxfvnn9g7BxAEKNylzoHnoiebeUpsaL/p9fP9oY6D1RgW9eyb2fgb
	x0q7+avwVxqJGGdsGEf9CdmVoEaQTvDsH73/qyEO2r59/VnHnnISjW9oRdgfw9+v2ssyFU
	i1Sa4w+Dpf8lAYnZWtJsMA4/VWZraeY=
X-MC-Unique: 578sGXC5OdyC4YIgvIE-jw-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=MuYdGtPVsURcoc2G9nd9C5X77zGcucfS7M+vFoz/cuxzVzKthkCwfSVURC5xqvm8wa+M4mSyfhSOuLIvxEg7I1uoLgIlfk8emvFMcZDlVXeqpjb07vcoy8lfMwfJOvepYk+Q6NoDcmIGGuFYYroZJGS1Gt1uDJVWuvWjFRIF+P5FK095UHjO3Vm0xIuvDJgpCpdT0S3yq5LUIywxbjpULOqNZGNiKxfL50yGeiUFvh4wVPXBtGA2SslUQQC5pHXZZ9IgvliYUrV4ox0Hr10AECtURIVdvXFxExzldezCxo3pDj6iyekSoN0irA60H3uiojUzV6NlUogyXzHN0hdHRg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=XywlAjTsXDZgrpXx3Ss1iRAl8VekY6dFKCueH/IrcNY=;
 b=cZy02JQqoTGxkCGEphKC2x/rU71Sl+kRCfkFgBKUGOaUdLWA6Aa+bf3HuNWby86gBCSLW7LWO7FXV7zyeBkOngtYi2MHm+i5pzt0Y0ZLgaNI4CZToEkEm61eKNvBsTB8rF6Q5eJbSUCBbIHvZcKXpLSBy6t5MVpaOR5NczI3HMYU5VDMHQ/AAB+lTp3YQAleohpGZYKwWawaPyqO1qeK8oPcgyfnCdIxZ8rnJVSE3FWjgKH1PJqp2tRW+ypFiKDFPlS4HfFjHFsWDwtCRk5lSFqXbjcRTtda1/iQeRYvr3fh6QIgxT8uz2JwAtati0Se3Nb3JGBzip0r1XlcPXRnPQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <613d2033-47ba-1f67-9d90-322caeaef5dc@suse.com>
Date: Mon, 7 Feb 2022 09:11:19 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH] xen/smp: Speed up on_selected_cpus()
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Juergen Gross <jgross@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20220204203115.13290-1-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220204203115.13290-1-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P191CA0085.EURP191.PROD.OUTLOOK.COM
 (2603:10a6:209:8a::26) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 1ac65ce2-5ced-4aea-8c2c-08d9ea116b81
X-MS-TrafficTypeDiagnostic: AM0PR04MB6324:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB6324C648EF0355EEF8654BB1B32C9@AM0PR04MB6324.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	6wmu00PMN6BsN1GVNE+YrHArrsExogbSyL4Yv9aOOvgabDCbOCT8U4qCVAR4j0AEGgWUhnf6NJQunmyHiQ8G7xStitKJ8Wrcyp/2UU47F4c8iR4wDAdWdhM5OfkGHL8DnWt54q0tWhjVjjqXydqWpSGDEoElitUXfvUhfsV5zrBcXpo1LS+9EGrSee+1TJgUiirsHDlkOdwuzTGeLxmX/TjGhIu85JDgX3JlSGg4DABb/agPUayimHejPSn7WWXUKIdcsjtRFT8sfUbb5oUPNwy4inf8SQpkHOYcldCubpLEK6j6kCsj5/fCPNeRggJYjCOd9VBv9UTXqXp5xP8hTml/Fijdtpk+LBbS1pzEROZLQUK0ACIBfVFtHVV3vlQqsd/a5zy8vLv0I4uRtCmAtayfHbWRmbRxniOOQ8vYv7Ztibb6aX2wNParyqdxxdTdM4PjBCi7oo9bkJQROs6ofXGLfOf9IS0YQUO6k/EMUuwYBnjFkOELpYFqYAGHmXjeqSrAM1XrCm1l6Q4+G35LcjgI06xutgZFynoegsEc1WbTrmLbK5D40quHFeZcy3k4ANUV2oNCre+eE8W0ZWmZF4zCgFg3ngvrC/hrOj3AswJ2gIAgPniYqHIyTNz6JW8azTOb1hKk2HSPx1t8l0T5GYBWEWjxkfEOw0xV3lenHt0x6lKU4+S59PWdppPYe7s2NIFN+mCEw7C1bM/MDFObchm3zyNv7pcmOX7aRXet/lUmBrFVlXFLMQARg3izB/0m
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2616005)(8936002)(66556008)(4326008)(83380400001)(66476007)(8676002)(36756003)(508600001)(6486002)(26005)(31686004)(38100700002)(6506007)(86362001)(31696002)(53546011)(6512007)(5660300002)(4744005)(316002)(66946007)(186003)(54906003)(6916009)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bjIvN1JNNjZBT3NLek00R0NqV3hoVzN4VXdDdHJrL3IzLzI4elRRQnVTd3h2?=
 =?utf-8?B?NmJUbndvRUxKbWQ4aktQTFNXMjRoQS9KZjFPdU10cDdWbWdTMmpOTHVjSERz?=
 =?utf-8?B?ZlBzdE1XTVNtb3JFWTBETU9qdXNpVk4vcmk5LzBFaDVUUjlUNmdtQ2RqU0FL?=
 =?utf-8?B?YUNHQU54UWtIRkpyUWxvZGlVT3VFRTNESGRJZzFHTGVPRnBYU2tERUxOc1E4?=
 =?utf-8?B?eVI2ZmlpUkV6UWRITHZMR0ZBbzZvelBKSncyNm5KQklBNWZ6dEtQS0hvWEM4?=
 =?utf-8?B?aFdkV0U2NWc1clVJcGREKzUyRlJLTWZjaG1QUkM0QmNmZmhyQ2VxRTZhU0Rn?=
 =?utf-8?B?dUJ3UkpmOGFWUXAyVXE2cnVURHZRY3lYK0puN1lIMFE4RjZ5SjRXN3lZeG9S?=
 =?utf-8?B?THM4TmZVeW1Id0gySjBKVzB0KzUyRWtFVkxSWGZZVXRVZjFzSjVIWDFmMGpx?=
 =?utf-8?B?amRwZ2hMOCsvbzZBdWY0VnB0a1cvNE9HZWVoVk5OdEg3NkJZYTdyWmpZc28v?=
 =?utf-8?B?NExBRElwUnY3MHluMEdraFFhUFdJeEVHUStDUTlnV1dxckxzc0tiekY0RU42?=
 =?utf-8?B?UVNuZCtGQUQ4TEZ3WENoVmNFSzNOVzEwSXpOalQya3VrOTg0REgybm4ydFhF?=
 =?utf-8?B?cnF3NTZ3dlRDV09qVHc3bnpmR2ZJQ2FRR2R6LzFtdVduN2UrYThxUmc0dEV4?=
 =?utf-8?B?RklzbFZVbW1Cd0Z6ditqcUZuY1Y2b0lQV0JNbUdXZlI2b0FYdGROOXFZYWdW?=
 =?utf-8?B?c254emZDRWE3a3B3dEdPWUUrMnQrR3g1NHNoL1NHNXZ0OER6RUlTcXF1aHNV?=
 =?utf-8?B?SkFUYkN1NUVRR3ByMlBsckZ2NWZMN09zS1B5UTRHNXVVV1F2bXlpQVJrKzlx?=
 =?utf-8?B?YmJ1RmFNQWVRSzlMRWJFd1BRdk5tVFVoQkJHc212NnVtZWNvMzdJV0tQbk5k?=
 =?utf-8?B?dVY3ZnJYRlBlQXliVHkrSGxsUW9LZzNLRUNUTzIyczJFWkR2ZFVycW9rZXVX?=
 =?utf-8?B?S0dHVnQxa0tqVWxTOXVmVENyLzBZTk1KbS93bzhyYmRWMmU2eTRwSzRueW9J?=
 =?utf-8?B?bW15UkJ5T2d2R0R2ZUlJRThid0RxN0dVOHdxakpNOWFnREU0eFQwaUsvOXht?=
 =?utf-8?B?YnNxRjIvVmo0aGVIaXFvSGIzT1NpdGdPYzlvZlVTa2daSFhBdnlKTk54Ujcy?=
 =?utf-8?B?aXNpK3NGMXZGeEUzOEhpZllvR3BZRVkxbzN2LzBvWktWcWJSdHoxcnhKSnV3?=
 =?utf-8?B?RXBRNXMrU0pYWER0My82Q29RU0ZaYktUQWJaalZ1UnJ6NERDRzR1VVhmb1Fz?=
 =?utf-8?B?MDFvbFFhUTJaYXpFWUJJblUvbS91emJBTzFNR0VHbmNFVVBldWc0Ny9sSmN0?=
 =?utf-8?B?V0pDQ1ZxcWNET1pRTDV6OURDckhWV0tGd0d3dWRCcWJ1bFJCalRHZm9JTEdO?=
 =?utf-8?B?aTllMXJoeXlJZ3RvVDhXRDV5bXR5d3J2ZW1UcEk1Zis1WG1kMmRTNmxMVGFX?=
 =?utf-8?B?WFpVdG42aG1vZzBmTnNLejh6dkVweDhiUkFmeVlMbDdBQ2o4V1U4dXVMY0Fr?=
 =?utf-8?B?VWprTktERUZKM0FrbjBXSUVQb21IYUIyblZLeGhJa0piVW5BdlBXckhKMGJX?=
 =?utf-8?B?WXJycVduYkx3VE5KaHlYdTFKSWJrKzByREhQd0YraHRpUk8xcGxtYVNTQ2Nm?=
 =?utf-8?B?dEt5dDY1UkR4cm1qdHB6akFzb1h3NC9QUFlzOEo0U1k0Vk8vRDdTTWhCV0tB?=
 =?utf-8?B?QnhkRTl0blBTZ3Fhb2tNNU14OWQ4bjN5QytIVit0VEs4aGtxa1YyT05qT3I0?=
 =?utf-8?B?bm9XbFllTk9GTzBra0liaTJvcG9tL1VBaHk0MC82VHpncVNBOENzUTZmc29k?=
 =?utf-8?B?eWNIL0ZqMVVyMjdsY3R0SzZHQmdYcG90WWpSQ0lqeW9xSUF1b2w0a0FqMFJk?=
 =?utf-8?B?QUd6SWRsYzdLbzgvbFp4c2JPZTExUWxDaFpzUStkTUJLRWlBNzFlZVk3V0xV?=
 =?utf-8?B?RE1NamsyanJPZnpGS2lJVEg4cmlVTXdWYmdjekt6VkV5cW8wWlhibkt1RHVn?=
 =?utf-8?B?UUErYTJWV0RHOGs1KzMvV21xNm9PczZIeW5lZEtYbmpaaEs0OWJOZUZ1VnFu?=
 =?utf-8?B?dGw3TGVKRFJMOUQvMWEyakNRM0pvYlhVMFI0VDVUWndxSHZVb0YvSmdFd0tV?=
 =?utf-8?Q?BNuNH0UqVp7RZ1iJ2kvOHaA=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1ac65ce2-5ced-4aea-8c2c-08d9ea116b81
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2022 08:11:19.0194
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8CEwGQ+mO6ks/XGPmCzaFYmRJQ1LFRc0VkeFgQcRVOkMkcgIkf6GIhIo9XC/r7Hgcp65LZQU1ZFUiEJ1RayLhg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6324

On 04.02.2022 21:31, Andrew Cooper wrote:
> cpumask_weight() is a horribly expensive way to find if no bits are set, made
> worse by the fact that the calculation is performed with the global call_lock
> held.
> 
> Switch to using cpumask_empty() instead, which will short circuit as soon as
> it find any set bit in the cpumask.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

May I suggest to drop "horribly"? How expensive one is compared to the other
depends on the number of CPUs actually enumerated in the system. (And of
course I still have that conversion to POPCNT alternatives patching pending,
where Roger did ask for some re-work in reply to v2, but where it has
remained unclear whether investing time into that wouldn't be in vein,
considering some of your replies on v1. Thus would have further shrunk the
difference, without me meaning to say the change here isn't a good one.)

Reviewed-by: Jan Beulich <jbeulich@suse.com>

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 07 08:21:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 08:21:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266525.460203 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGzGt-0002Hp-K1; Mon, 07 Feb 2022 08:21:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266525.460203; Mon, 07 Feb 2022 08:21:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGzGt-0002Hi-Gy; Mon, 07 Feb 2022 08:21:15 +0000
Received: by outflank-mailman (input) for mailman id 266525;
 Mon, 07 Feb 2022 08:21:14 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=owYM=SW=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nGzGs-0002Hc-HT
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 08:21:14 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e988459f-87ee-11ec-8f75-fffcc8bd4f1a;
 Mon, 07 Feb 2022 09:21:13 +0100 (CET)
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2055.outbound.protection.outlook.com [104.47.1.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-7-RYPd-Z1KNluAVQgnyDyi6A-1; Mon, 07 Feb 2022 09:21:12 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DB8PR04MB7130.eurprd04.prod.outlook.com (2603:10a6:10:123::9) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Mon, 7 Feb
 2022 08:21:10 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.018; Mon, 7 Feb 2022
 08:21:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e988459f-87ee-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644222073;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=mTscNh/07aaJzB8pmmM9mgW6InXgsKWxhdU4rgAVIqw=;
	b=VDKcjzgsrbvwO9QpcJntshOxaJeWVbvzjAH6MNdwa+EhpYqoyfjP+IPkW0Wp4u7lqtRMVI
	pGi3KScFyvEIKhL1WrSEsQhE/GPZILxVZwXNmskQizzB8NnxeHZUh9plJtMeleEIRxwxaA
	G2yw2gR+iY3IrIcCORfxIie565TCZo0=
X-MC-Unique: RYPd-Z1KNluAVQgnyDyi6A-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=fTltv12dAhhfy7nlhftL8xwjQDuQBgTQkAnK4hXaO10Bv4yfLJYKSLYCnPgxlHeCsf9RwZECCKJsKUq/6MGf+FYnHmuwcJToXaxKnNFYq1HRoxI6k35wzmtb3Cp9NU5Wc8pZHC1s3vbw4/jwNYnarJcaVjomLQR6fhT1wnSNIYGD3wu1ulTu/BjSlWziQgjAI7LFE2Yaq1bpCWyl67S5kTB/qe/s6gIyR20EEfVAt+C6638hiApMU3jBuWOsATcN9c0/HhEoyjoKJFgfOTwRgyPG7CJki+kPYLerHmnWP+uEtKvWzvSi1JDke6+OA2w0q04f253ZyMvs8TnO8O2j5Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=mTscNh/07aaJzB8pmmM9mgW6InXgsKWxhdU4rgAVIqw=;
 b=gCA+vkv5Su90lOlBXDA70uyjkvmuVowO6oAa2HPq9Z0dCMSoBJAKyv6v8thsl6JemrT7mHv3m8M6wHo0+fhMM37oMfx+CVup90Wo5UzSonLWVDJy5KNfzd2GkiHSFjFMNWID0+OujIEHm/SZgIJeKbMSqQ/cSLQl+zwrvrYBdcZAvBU5S4aGQO9IST35DiSX4LS7QrczE8ebA+TXH9dw9CGUptaeH5fiRe9+akaOCMGVmoHCc+np5FblAknjMz5xHyA/5PI8TGMcxNGahiBxklmq/4i+37yj4prll0sAwlYCdgcVhMKrfSFD8bdr1aK9tcWHybXPcgwRxjTJzGw/DA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <10266b94-7399-2f76-24e8-57ac6a1ac258@suse.com>
Date: Mon, 7 Feb 2022 09:21:11 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH] dom0/pvh: fix processing softirqs during memory map
 population
Content-Language: en-US
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220205101806.35927-1-roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220205101806.35927-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0701CA0069.eurprd07.prod.outlook.com
 (2603:10a6:203:2::31) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 3b7176ed-6a01-4ed6-55d9-08d9ea12cbcb
X-MS-TrafficTypeDiagnostic: DB8PR04MB7130:EE_
X-Microsoft-Antispam-PRVS:
	<DB8PR04MB7130F0A909154F0991704FD1B32C9@DB8PR04MB7130.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	1LVMg2FecOt4bgFIq6VKyzb1BmHenCGIXnft0AdIRqoD7HYlfQHaahDpXyrf/esdzvBwbG/VjYbUqkNyVk6k4QZq/v5SrlFbR0BiqircXCe8iCfDnFuCEmlGN0szPA/ZAgvHa+Bh834iMP3GD+Gt5PBGtu4tLoXD4MDrCoxoGTM1Ba3f2L8KBz9+XrhOEPmEI0Ne/WuF7b1McKnHFD8/AYDza7w3FIskQppPB/o7peiwv2yakIWjuNFyfLEgTZpi+St/XPilifOXsdYRFZmsz/9ZUzpf+0ts1y8mGKtoghK5EzAxwNfll5ly+D7ZhRz40Xk2dBE0gvdatwljUA3UrSPg2EvkhtA7hFHr8W9YvKnZ6jswTnS7MFAZUZOxXnSlJONPnwEjUOzSUeXcaNBkEsyFJvzRIrKxcxicKAXza1P5M4VKR0+o29nr/eJG7RmU3QthFeeN29wHVWKFFTvQTADIxk9xkLWqoA+sLjR12eHxB9YoDpMbrtdQCOH2YnccCfV6WW2fjsfo748UbvAyR7JPzRRhu4By9XKT8oOqzj98VEx07OviEDKzSsXO45fY+AHWqVMxkWPVxHsrsxkK6VbtX5pxnMa+djFj2UnDvs7ibss5Hjl41TxPfCc+9/wGA9zEJEe8bBCMRMxsHe6oOtMQfiviZL7BP7XV+/EeLJ/LQPkEpWZD4rMe2wEC3j0VenyFGQG0G0FNzKX18klNzYsB7cqGz82tWET+7ZhIcWg=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(31696002)(86362001)(54906003)(38100700002)(8936002)(8676002)(66476007)(4326008)(66556008)(316002)(66946007)(6916009)(83380400001)(2906002)(5660300002)(6486002)(2616005)(6506007)(508600001)(6512007)(31686004)(26005)(53546011)(186003)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?S1pVdExpRjdIUExPYjdlZVE3bEtPelVGa0s2azlDNFJOdUEyakw1RzdwNVA4?=
 =?utf-8?B?MktLZzlIMzhzQ29rc3Q5eHpEOVArM0ZIR04rVzEyOWpCV3F4azdUWlJhbVVw?=
 =?utf-8?B?SEZSZFdtUnpUMkVCbURYN3ZkYTYwaWRpQ2RIL0d2NlZIdjZNN1FUa0tDa2dz?=
 =?utf-8?B?TW9abVppcC8rWFpKMnl2T1FudGFYREh6SHpDa1VwNSt2dlNPbVZsMGMwaHZB?=
 =?utf-8?B?YlV6Y3o1R2RwZWcxVU4yYm12UkkrdEh0N0hVYU9lUDIyZzlzWVdUSUs0amUw?=
 =?utf-8?B?YkhCbXVhUTM5YUphSjNrSVVWZ2prTWFlTlBudXQwTjV4RGdZNkxRa1NkaGpJ?=
 =?utf-8?B?d1JYRWhVUWxoNkdhN0ZyRmtFd2Zjdk8wSVJxSWkrNFRJdkpnWXlBbHlSdVRN?=
 =?utf-8?B?bStPTGgvUkZGWUV3Y0I2NzkxK1o5QTJoWmRJOENLVFhDRXJNWTkwWWNRTzBs?=
 =?utf-8?B?Sm1WVUJNZ0dUT0VSMDRNSFV1b0psLytWNEdOWjVCaDFBV0ttSDNoQnhBSE1r?=
 =?utf-8?B?RkVWZEZnVVBwS1FsWEp4YU1kV2Q0eVFpNE9aZHVMWVBMdkxQMG11WTJsbDRm?=
 =?utf-8?B?ckkvVUdKYTdINWVROEhMVWlPMHVxRjFZaHRLK0V4T3gxdkpvb0xiR3lHUnAy?=
 =?utf-8?B?aG9qc21Xc043Y004S0VNWktQOTdsbFZlS3dKeUExdTgrL0h1ZVFQWTFraFFF?=
 =?utf-8?B?c2JwY1VNNG56T0pLVVltTmpaRFpSSWtUMGdwVG9sY0NyTElhbjdRc1hnemh2?=
 =?utf-8?B?TVM4TUJJbENpSWNNSU5VTHAybW83WGEzOTR0bHBkbDM0dnpoUFROV1A1cmRy?=
 =?utf-8?B?SHg4U250RXRoR2lKd1ZPUGQ4RWV4UDNmaVZIQ21wNVYzVTNNY1Y2K3JOTGUz?=
 =?utf-8?B?UVZXZkppU3R0U0JDUENSMTZGVXp2TVZFTzE5cUdxcU94NDRXbEpaZkRiQ0pO?=
 =?utf-8?B?U1ZxVXY4bnA4Y1cwb21vNjBBZnRBYWR0bVVkZ1dCNTZSUFZldmpvZXpRWUV4?=
 =?utf-8?B?d2p2TnN1Y280enVnR0I3N3hNRmpYK0lQb3dBQ2ZCd1VZeVh5Q1pSTzhIQjhO?=
 =?utf-8?B?R0NFa1JxYkFwOWd3ZWJIUktjUWE3dDRZUXNxb3lpQmthczIyZDRsR3IxcUhP?=
 =?utf-8?B?U3J0OFhIMXFtVEZLTElJYlRYbjZWWE9VSWlYeDZland5QVhMalNlY20zcGV3?=
 =?utf-8?B?ckVVQVJPVnE1OHQwd2EvRk9lUUZmT0xPRmp1YlJ1OElMZUZucmRKWmc4QmFm?=
 =?utf-8?B?MDFmR2dJRTdBYVUzM0ZRSVY5MXJyZG44eFk3NE1BaTBMSFp4OW9XUmszd0xK?=
 =?utf-8?B?Q1dwdGtuaDNoOHdqWFQxR1BpcFdzemxQS1grNTBOWDNRTGFYbXUvR3VJNWdr?=
 =?utf-8?B?R21DUEhQaEU0SC80eHNqNWlVbE1MUHdEUkVBRlc3emVZQmdHTzVPblRuU0o4?=
 =?utf-8?B?cDlTSTdPQ0x4NG5sU0EzSUhjYURMN0p3N0tsZXNYL3J2SkxlTTkvemM2b0hx?=
 =?utf-8?B?Rk1jUGtJMTkrTkloYy9jb2laMWJJYjMvbFh1UitadnZHZ0xMbzY4YmJ4VEVB?=
 =?utf-8?B?Qk1UZUI3b01mYXhyVmFVcUM0c3g0S3l2NlQySHk2Uk5QUmxvRmJEMVFOZTRo?=
 =?utf-8?B?aDBxRnlwYm9IL01yTEYwRVQzSjhnS044QU9xZ0FrN01LcXVmODZ6ZHBnRHpE?=
 =?utf-8?B?d1kvcnQzRnl4U2JHVkVIWHV4dWV5QkRxaE5yQ2w1R01BazU5YmhoNkJqR3hC?=
 =?utf-8?B?VDRBczNubm1wZXlxckJoY0RoTEg4R1RzeDVTbTJjSTBtb1JMRVg0b0NKelM5?=
 =?utf-8?B?WkZDSU15TDhwOHduYTA2VnlDV0ZpNlJBRVBjY1J2bU9QdWMzeHJ4NTdTeG5X?=
 =?utf-8?B?R1I3Z2pTSVlNSUxPR2FQeFU3RkRXb01LYlNrSUpneCtJWm8xMFRUdEtlS2Uw?=
 =?utf-8?B?bEMzdVNGWjM3VkdGNmk0eXFvdTNjNjhkdmZlR2tSc0huUGN6aXJHV1FSNlVo?=
 =?utf-8?B?WTlDeXV0dFZFRWthRUpaTXZDeFJhNitWYWdmb0hVbUlOMjdiY2YyYmhHZVJE?=
 =?utf-8?B?WC9nTFEzOVBFQkQ5QzBPTHZSZllPeXRPQ05RR3YxNURTcXQwd21aV203QjZW?=
 =?utf-8?B?Qk1mRlQ2THVoN2svU2hXdlhwdU1SdUxiRUtmUktsU05EclVnbEtJZ3hWY1pQ?=
 =?utf-8?Q?hCUMVYhJ9Cv1R5n0yjPHu4E=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3b7176ed-6a01-4ed6-55d9-08d9ea12cbcb
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2022 08:21:10.0766
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Xwm4ZlJ17McR+MX1DYvSzq8S71T/Lm5qy6JqoKXRRnQRtyItPNvqt8tkLcKGt1nTaQvrLnYYohHZl0oUlUa+8w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB7130

On 05.02.2022 11:18, Roger Pau Monne wrote:
> Make sure softirqs are processed at least once for every call to
> pvh_populate_memory_range. It's likely that none of the calls to
> pvh_populate_memory_range will perform 64 iterations, in which case
> softirqs won't be processed for the whole duration of the p2m
> population.
> 
> In order to force softirqs to be processed at least once for every
> pvh_populate_memory_range call move the increasing of 'i' to be done
> after evaluation, so on the first loop iteration softirqs will
> unconditionally be processed.

Nit: The change still guarantees one invocation only for every
iteration not encountering an error. That's fine from a functional
pov, but doesn't fully match what you claim.

> --- a/xen/arch/x86/hvm/dom0_build.c
> +++ b/xen/arch/x86/hvm/dom0_build.c
> @@ -186,7 +186,7 @@ static int __init pvh_populate_memory_range(struct domain *d,
>          start += 1UL << order;
>          nr_pages -= 1UL << order;
>          order_stats[order]++;
> -        if ( (++i % MAP_MAX_ITER) == 0 )
> +        if ( (i++ % MAP_MAX_ITER) == 0 )
>              process_pending_softirqs();
>      }

This way is perhaps easiest, so

Acked-by: Jan Beulich <jbeulich@suse.com>

but I'd like you to consider to avoid doing this on the first
iteration. How about keeping the code here as is, but instead
insert an invocation in the sole caller (and there unconditionally
at the end of every successful loop iteration)?

Furthermore, how about taking the opportunity and deleting the mis-
named and single-use-only MAP_MAX_ITER define?

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 07 08:29:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 08:29:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266536.460215 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGzOn-000336-K7; Mon, 07 Feb 2022 08:29:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266536.460215; Mon, 07 Feb 2022 08:29:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGzOn-00032z-Gw; Mon, 07 Feb 2022 08:29:25 +0000
Received: by outflank-mailman (input) for mailman id 266536;
 Mon, 07 Feb 2022 08:29:24 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=owYM=SW=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nGzOm-00032t-GJ
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 08:29:24 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0d79a193-87f0-11ec-8eb8-a37418f5ba1a;
 Mon, 07 Feb 2022 09:29:23 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2176.outbound.protection.outlook.com [104.47.17.176]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-7-vMHiqXIwPXmVZiPelz3b_Q-1; Mon, 07 Feb 2022 09:29:22 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB6333.eurprd04.prod.outlook.com (2603:10a6:803:fe::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Mon, 7 Feb
 2022 08:29:20 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.018; Mon, 7 Feb 2022
 08:29:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0d79a193-87f0-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644222562;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=wB7/UuM4am76mp9BiKb156REv1HjI39T7VQH49ocQNE=;
	b=I7ai0398zas0Y2YmlD/UYOMIHAMdse1KZtuRIlL+HrV9pw4j18fEfiS0uMXdrArpwxlyIw
	5dEFBQa4VnPNGEqBlrTj6dM5Zmn39nMY7gxhlZ/QbyfE+J5p6XzQVzuNJG7jXypqxo7nkI
	LuBstJ8ndgaeRd8pCOTKk1KLEtvVc9k=
X-MC-Unique: vMHiqXIwPXmVZiPelz3b_Q-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=SFbS9wHbGfWOLM2t0DSvyPI7ZR36IiZXybARD+6P01aoHPRleym/yE5T0JQuRbL86QLXX0GkGKv7OFzNPsk6wHpm5Xr+JIolKC8rkL4q58puQ1v9dGm6MiUYKPvyGqXSkdUqulUBCmSTXxqRMWmghWwEXGhaRv7zsVNoA3N9wtbgDdyaHy/QGy+z/Y+pOcv0c5E0JAlKe89XUizZCWuth4WRQJfUT1LIHcimMRsb0Grnup/7UpEzvgRfoqJBSHlez//dRTFn9+XzS2zTEK1/tqRos5JDwEoH0fvHcfVfhPkBW5YAQd95w1xHabbv8Da1omA2BTyfbuifM5bLsuE2gg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=zY8wF/cgDacGMiqAmzd3t1NrwEoSzJYZ79svQg7JFr0=;
 b=XeEEKEJtCpvmWuJiLunqWLlO4XKLlnARdCffEF6mDC5KkFc5+z3kDGZJBNdqVTQdyZJa+Ftrz7xi2h4e5MBsp5T+0bsEwKl1/+14rdOQRY2IhKMaHWmbgvPxRk6TI44K6MAEA1GA6HZSsXbzZNNOnr41GpnxcVMUwvxLqzpz7gnwFvLFt2M59UxFGlkfU7FSyiBzm2JNErLMlQ/u1pMsfKF0dlce4iyN1YrLKhN07GES8dJPKqzilxW8DzH6sFSmbVYZBMxTJKXrTAOsUVcrVF9aC4mhtWTswKyupWnKASPpmqRGQHaJ8Ezjudkfgx3+dsWfXOSgQyV8cZZCky5JhA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <4555a325-96c5-4fc8-5d6f-a5fe0f47146d@suse.com>
Date: Mon, 7 Feb 2022 09:29:20 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH] x86/hvm: Fix boot on systems where HVM isn't available
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <20220204173405.22759-1-andrew.cooper3@citrix.com>
 <Yf5HpzveBK+Ho3Nt@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Yf5HpzveBK+Ho3Nt@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6P194CA0069.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:209:84::46) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 0afe2a26-e354-487d-ce26-08d9ea13efb7
X-MS-TrafficTypeDiagnostic: VI1PR04MB6333:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB63332EFA9B33D4E75675485DB32C9@VI1PR04MB6333.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7219;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	DJIziOgMnwVNYVEMYC8+VZKkCLyA8dC/GEAWoxoinPF/MUjg7Rfk8c+xauEWMlgi2vTrawHCD5X5i9S6jxAN6P33ne/gpG1BeZ+N7a7wC2So6fF4MWP1bAaG38LQzhFuvc/VnRuAv52cKfLZGhzQ/xJ2FxbUSb5J8z3shGkE/btvRg6sevXDq87+FUHCcRkxFTwGyXRiTkLkqViOCfWj+ajr/nFl+ULIxzqITNH17VGV4CuuQkDLmJyVrEUXM6NwMCQrqjgLj32zy1MGcsL3PJYgL7Qq5xLn1POtnC2v3iGW1UnIvFLjjSoFee8B3k1lxI4lPeSV5ru1dUn5/jBTV6O38gpzZoI3qcHI07vxzpIE/GUkuywTJffXu6PQhQpmu4JGv17XLTnu2ycmL6e9T8LfwI4IS7wpIwHTw/KUqWI1KpBcA200yg9nko5LRDIP7k02N3P8wMsVARt7qeWgTa6TyrgVuoDcmyY+N22+ukPdyKx5Czeeh+jxXvxsUbIR3DVfHRadLGLYkXwQUKvtP9IjsjFb6vBnFTLxBfrk5WL+04nysM3l9ue7YnSf3ewyoj0zoUalCL9PZr2WR1BdIz9EdwxqFNYYVgRj52nj66sg0lxrxyk9tjignN6mbYaSaoCQT8rng5xHmOJ7nchmAawBCXav+he6Q9dJgcdSPRaEBrP2fJeYqb/gPkaDQ24Wde3AS2sEY8QVxH3DaOm2vl8qfeCiuOKnEb4hWt6lB5s=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6486002)(54906003)(36756003)(26005)(186003)(83380400001)(6512007)(6506007)(6666004)(5660300002)(31686004)(53546011)(6916009)(316002)(31696002)(4326008)(8676002)(66556008)(66476007)(2906002)(8936002)(66946007)(86362001)(508600001)(2616005)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?w0+aHfmDEJ2SuKg2yu/uGDxBgYd8JSPizblmUzZFeFjJhetsrEM80aadxEqk?=
 =?us-ascii?Q?q78k1gGesRXqMea/lQDmc7gA1AWnoTk0fvvK9iRXP9T52n0enFo3GYoyIrAw?=
 =?us-ascii?Q?IuwyXwn2Nk3tPl4d3ezMSHvYHmNPQoU1vtbCdR3a+14Pqk8KYDHD0l09qEjX?=
 =?us-ascii?Q?5AQnF7ArQOATwU9LxRQYFu+bbNqsricYN2zKHytHvRUnUtPG8/fl1LewnP9J?=
 =?us-ascii?Q?zPIBDo2a/noBEc0FkBDl06tSPhWIIWtCTqZCIcKYhXzIwPNW72be4Y52Ua7H?=
 =?us-ascii?Q?3B8y6ZtAXDLbD7/If3FWQ0joYWZBRN/8RlQL+ySDKfyFQ7sRfy8kpafg8gif?=
 =?us-ascii?Q?IS1mgkzLolaGYafT57rtfd9GSye68FarmZDOjwjlfwvvaRVU5PiBTwf5LSse?=
 =?us-ascii?Q?ppY3It43gog6uCoj0arKgghWcM1uNhNzCl3xYmIQspinhoJCnVIVhJXXcTeu?=
 =?us-ascii?Q?AzPT8p+zqpo9xWYdmR/+pfBURvyj/EzsTloRNFE+zZmwFzAmCe71J1/28eLa?=
 =?us-ascii?Q?rssjVb04zV9WGvoPi6oJIi//IhYASE6dzaCZkm2qdI8chbVcCem0nTP3fSic?=
 =?us-ascii?Q?GmNH17mcqMB/JRo4dnbx5w+fY9VA8HDi34C2/bXQXcz0eEkz8InrneqqhYF1?=
 =?us-ascii?Q?BZrjeQk0Psf4bZVvK4VQJjm+gOb4irPNlCIeJMGh4xKYd/4JRQgJyGsflSOQ?=
 =?us-ascii?Q?iwYwi36KdgtlWzxWMgHo3NfJOJOA8xpxeHY8Xh47xQej4FRzvAg/efPyOWak?=
 =?us-ascii?Q?9r8JiDJGgIe7sMXpIGH/00CEie6jJNIwpAWJUjvqyspDi3q5ZSxCejwc71GB?=
 =?us-ascii?Q?00joMPnwh5UAB6o5HxdqhZUd5vs/KcoRXTfK4rdR5IwTzdQACHhy8R7zxeJ9?=
 =?us-ascii?Q?+B4+nRNqnUQiCVVFm+Iq2pjoTWTdgPbJtYTUNOGGN7dFX4NB2f0MrTSZMRXP?=
 =?us-ascii?Q?itxvc1cXyIVVoBd58DQfNkyX+72eYDVPfK/wV1fUjCNiu0WCyxD6qVPHoj7Q?=
 =?us-ascii?Q?oR9FEf3K7G8hM8OGwkTmCJPTuRWEzfLuyAHZ+k8NhPmyWvdx2wLfhPPeN/+W?=
 =?us-ascii?Q?3LFPidzuUMYVGfXVYgBGCc7bA6FjJJ2BKsEujrV1X5qJS3kRxw/ZoRf7FW+a?=
 =?us-ascii?Q?9EMEfZYWtm9YLN1K4kWNCn3nEW7SZMwGKGVJD9/W/Z35PHpsIJnM5l8FBnF2?=
 =?us-ascii?Q?1WXTHg4vVZIQXGF9eDxQln5RKDKjs3onddZpTTjojnS39iChBYyV7d4TfGJr?=
 =?us-ascii?Q?B+CFKX2iiyICdXRo44zldaaXpsmd+nb0tOUm6jqjNrlD3KKMJcjMjMioAr9h?=
 =?us-ascii?Q?lYfhwrBm8MzPTh9PvM/n+vAyWCN2HrWVaq5+eItC84ju+fzGDyJV5lXVIfur?=
 =?us-ascii?Q?VWzwY4I/H3glilbuuNQN2CHtmV/Jz/ILIEWkfYSkjW7fA0mfN46+AKwo+JLG?=
 =?us-ascii?Q?GcFA0LksC53dkBOstxuaTC4knHnDqmJrnBFpwOqyZPewZ3mSWhebzgKHrg2H?=
 =?us-ascii?Q?BK3VwQ6EMXXrDn6yZ6ALD4dwolE5kKURM3HA5gwAO29/aFpTy2HyVB80oazT?=
 =?us-ascii?Q?yg4Ddv/nhRWMrwtpqbHofoH4vB7qOMEXrQNqDA3/CavMkRvKCCcoMWktjNFT?=
 =?us-ascii?Q?fmhMkXaNVZqSWSiBtd7CUNA=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0afe2a26-e354-487d-ce26-08d9ea13efb7
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2022 08:29:19.8433
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6sv8yws7bAAIfe7T/4+5nrYiMcw97khzpVLiO9tzYx0IDihOSPZjdRk1E+7dFch/YGzLYr370GzPyGVM2HcCsg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6333

On 05.02.2022 10:47, Roger Pau Monn=C3=A9 wrote:
> On Fri, Feb 04, 2022 at 05:34:05PM +0000, Andrew Cooper wrote:
>> c/s 27a63cdac388 ("x86/HVM: convert remaining hvm_funcs hook invocations=
 to
>> alt-call") went too far with dropping NULL function pointer checks.

Oh, I'm sorry, I should have noticed this.

>> smp_callin() calls hvm_cpu_up() unconditionally.  When the platform does=
n't
>> support HVM, hvm_enable() exits without filling in hvm_funcs, after whic=
h the
>> altcall pass nukes the (now unconditional) indirect call, causing:
>>
>>   (XEN) ----[ Xen-4.17.0-10.18-d  x86_64  debug=3Dy  Not tainted ]----
>>   (XEN) CPU:    1
>>   (XEN) RIP:    e008:[<ffff82d04034bef5>] start_secondary+0x393/0x3b7
>>   (XEN) RFLAGS: 0000000000010086   CONTEXT: hypervisor
>>   ...
>>   (XEN) Xen code around <ffff82d04034bef5> (start_secondary+0x393/0x3b7)=
:
>>   (XEN)  ff ff 8b 05 1b 84 17 00 <0f> 0b 0f ff ff 90 89 c3 85 c0 0f 84 d=
b fe ff ff
>>   ...
>>   (XEN) Xen call trace:
>>   (XEN)    [<ffff82d04034bef5>] R start_secondary+0x393/0x3b7
>>   (XEN)    [<ffff82d0402000e2>] F __high_start+0x42/0x60
>>
>> To make matters worse, __stop_this_cpu() calls hvm_cpu_down() unconditio=
nally
>> too, so what happen next is:
>>
>>   (XEN) ----[ Xen-4.17.0-10.18-d  x86_64  debug=3Dy  Not tainted ]----
>>   (XEN) CPU:    0
>>   (XEN) RIP:    e008:[<ffff82d04034ab02>] __stop_this_cpu+0x12/0x3c
>>   (XEN) RFLAGS: 0000000000010046   CONTEXT: hypervisor
>>   ...
>>   (XEN) Xen code around <ffff82d04034ab02> (__stop_this_cpu+0x12/0x3c):
>>   (XEN)  48 89 e5 e8 8a 1d fd ff <0f> 0b 0f ff ff 90 0f 06 db e3 48 89 e=
0 48 0d ff
>>   ...
>>   (XEN) Xen call trace:
>>   (XEN)    [<ffff82d04034ab02>] R __stop_this_cpu+0x12/0x3c
>>   (XEN)    [<ffff82d04034ac15>] F smp_send_stop+0xdd/0xf8
>>   (XEN)    [<ffff82d04034a229>] F machine_restart+0xa2/0x298
>>   (XEN)    [<ffff82d04034a42a>] F arch/x86/shutdown.c#__machine_restart+=
0xb/0x11
>>   (XEN)    [<ffff82d04022fd15>] F smp_call_function_interrupt+0xbf/0xea
>>   (XEN)    [<ffff82d04034acc6>] F call_function_interrupt+0x35/0x37
>>   (XEN)    [<ffff82d040331a70>] F do_IRQ+0xa3/0x6b5
>>   (XEN)    [<ffff82d04039482a>] F common_interrupt+0x10a/0x120
>>   (XEN)    [<ffff82d04031f649>] F __udelay+0x3a/0x51
>>   (XEN)    [<ffff82d04034d5fb>] F __cpu_up+0x48f/0x734
>>   (XEN)    [<ffff82d040203c2b>] F cpu_up+0x7d/0xde
>>   (XEN)    [<ffff82d0404543d3>] F __start_xen+0x200b/0x2618
>>   (XEN)    [<ffff82d0402000ef>] F __high_start+0x4f/0x60
>>
>> which recurses until hitting a stack overflow.  The #DF handler, which r=
esets
>> its stack on each invocation, loops indefinitely.
>>
>> Reinstate the NULL function pointer checks for hvm_cpu_{up,down}().
>>
>> Fixes: 27a63cdac388 ("x86/HVM: convert remaining hvm_funcs hook invocati=
ons to alt-call")
>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>=20
> Reviewed-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>

>> ---
>> CC: Jan Beulich <JBeulich@suse.com>
>> CC: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>
>> CC: Wei Liu <wl@xen.org>
>>
>> RFC.  Not tested yet on the imacted hardware.  It's a Xeon PHI with anot=
her
>> werid thing in need of debugging.  First boot is fine, while second
>> boot (loading microcode this time) has a problem with vmx.

Sounds not unfamiliar: My meanwhile oldish Romley needs to be cold-
booted for VMX to actually be usable (not locked) on APs.

>> I wonder if we want to modify the callers to check for HVM being enabled=
,
>> rather than leaving the NULL pointer checks in a position where they're =
liable
>> to be reaped again.
>=20
> What about adding a couple of comments to hvm_cpu_{up,down} to note
> they are called unconditionally regardless of whether HVM is present
> or not?

I second this as the perhaps better alternative: The S3 path is
similarly affected (and you may want to mention this in the
description), so this would mean up to 5 conditionals (at the
source level) instead of the just two you get away with here.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 07 08:35:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 08:35:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266545.460226 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGzUT-0004Rw-9a; Mon, 07 Feb 2022 08:35:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266545.460226; Mon, 07 Feb 2022 08:35:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGzUT-0004Rp-5d; Mon, 07 Feb 2022 08:35:17 +0000
Received: by outflank-mailman (input) for mailman id 266545;
 Mon, 07 Feb 2022 08:35:16 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=owYM=SW=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nGzUS-0004Rj-5G
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 08:35:16 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id df1bb4c1-87f0-11ec-8f75-fffcc8bd4f1a;
 Mon, 07 Feb 2022 09:35:14 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2177.outbound.protection.outlook.com [104.47.17.177]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-41-oCWiB_DcNeSPS9v1-oL3WQ-1; Mon, 07 Feb 2022 09:35:13 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by HE1PR0401MB2555.eurprd04.prod.outlook.com (2603:10a6:3:84::9) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Mon, 7 Feb
 2022 08:35:11 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.018; Mon, 7 Feb 2022
 08:35:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: df1bb4c1-87f0-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644222914;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=IR1Sa7Q6SJr+f4dIgzplWhh6/ah/H9TUn9U3Wf2dutA=;
	b=jWTr+3ZQSsE7FHF95anYcpdRA6e87XInEYjEQs1AvpFpligcOQwRnd8hlBGxBdcmcnHYkx
	nIlIAZTZxb1Jj7F+gH9DDQxEyCYfrsFGYy3q2nl4jsbAndVhSAgnJzsbNwna/Ay+jO9qXp
	HhgpwRwi59yPKZ6shWHh1wostaxsc/w=
X-MC-Unique: oCWiB_DcNeSPS9v1-oL3WQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=N81hTzsV+PNnET5nl4eYekmBlwrXBRtttQgOS29HXovRgtOw/wJXQTwjwX1Zmc2c9IZkj46aUBdqQVEw4lYOGoq4kOde6TU9BB3W5vtci7AOlOudtD50e2jcRm2tCjZAKwawjnoi2tmH6EgoDMR4HsJYBw5062Lpmgs5ezOJ9MVV4GPOt4rXc8aQTm+dXFZ4VaKy1raZ/7j2+IIIZsJs2w/I+0OpZXvGuidp5pbyLJU751GVJyAmjyrXD57alwoPOUb74ega47FGu867adNq0VCZ2o5804YxKojDAuwGm/MEh3GvZxBUqFlcQdp/6Oc5H4P47p5zhHeGjl1wNRmhJg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=IR1Sa7Q6SJr+f4dIgzplWhh6/ah/H9TUn9U3Wf2dutA=;
 b=BsWWinet9lvsPiaXt2e4S0Uwzs8aGFZvD/PyvAq2tj8Ga9KeeP/K+J9C44Y2Mi3c/L2mMHRr9X66drx5tDQu1W7zOB8X9gbq1i4mmEqoc/+12wsijVLZQhP0F4CMtzgjXTkKOWh1GJsp3CkzpcwCR2CIaLqyJuzSOecsd+0baAss8Xhfjd+uqVnZdZrkzhnpCNa2I8WEOxMqx5u4YqhLZR0nG0Yu7nLFWlQqkzCdc6ykdQQ5MwqdlIIvi99vq63iLRf5lz+OPr1UMZgsOMQFf2aLZT0sAASDy4pgCO5IJOjmadvwlJAx/ew4tVTeH4cwLJFnTV01pVeryjEAKUI4qA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <107963a5-fdd5-c1b7-9dd8-3ad7567f2463@suse.com>
Date: Mon, 7 Feb 2022 09:35:11 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH RFC 0/3] xen/arm: Allow dom0 to use the EFI framebuffer
Content-Language: en-US
To: Julien Grall <julien@xen.org>
Cc: ehem+xen@m5p.com, Julien Grall <jgrall@amazon.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 xen-devel@lists.xenproject.org
References: <20220206192839.75711-1-julien@xen.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220206192839.75711-1-julien@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0301CA0020.eurprd03.prod.outlook.com
 (2603:10a6:206:14::33) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d1a46620-b80b-4364-2266-08d9ea14c0f9
X-MS-TrafficTypeDiagnostic: HE1PR0401MB2555:EE_
X-Microsoft-Antispam-PRVS:
	<HE1PR0401MB2555823B9552BD7A4CE87D48B32C9@HE1PR0401MB2555.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	dQSIrSvjwtC7GYG/sxmfPM25uNRreHeqLmcIEKk3w+Edt9cfEM0g+J11OtQnCrUUpfALwKHn+eZ3ubdIZhD51+qILd4sRDBJl/LJ8PJO8MbjQfxW3KoG8U+aqGZoGyFKw6v3kLZWec1/ma+/TWomgeIn5HNbINAY6NP1cTVzipqbfR9xBRB2ozlUE03HRr41u6aCDcBKpGqCwxuMy5c7G25ZO4NuyBl1NKDs3B5NLApD7XYbFnTRYCm5tqOgEUEKZtJSfxcnfZIQN/ock2SwJXIzEucgDbZDQ2Eh4cgAj72Z/ULNUofMXJK/FPG7BfcQyIWxOxkqssp8/FgHm7AYUz+a/7GNOQ227lnnNzpTpQJetFLy1cCxq+bHDdIkuY7v/GQrGCyg+LGNV/BxDedfLbQAkp6DF+ghyY/grMKxD+5L0Bw68TcJmNv7P2Z6yID43Elm1vxGgAPvXpMDVjgtaJx7f+qC68ehORkc934UxvrEYs8t36ZTtxH+JKtZrV1mKDErfcbBBfrnCCGQnMq+GKY2IAtsfRDXAVtCIIYUao8R/e2sSb5qTwhjnevVQdRYQirjHWVPSFfT4yGzv7wk1Xgb4y/t6Lf+qbyKiIPS1IYNndRytT9lZaeeVtN//X5EqFZxHiaE9TUHOtHZJdoCz7+4w6OBiDgQBUcxwpJGX2Q9x5bQ62QyTlAWy6RetajE1Zcam3niefghJrxQTCPE8oBEBtVdgojRTMgqyPiPctE=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66946007)(66556008)(4326008)(8676002)(8936002)(66476007)(53546011)(54906003)(6916009)(316002)(36756003)(6506007)(4744005)(31686004)(186003)(26005)(2616005)(2906002)(6512007)(86362001)(5660300002)(38100700002)(7416002)(6486002)(508600001)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?eCs5aWU3WGRxYlRuWVQ2dVM0NEV6ZW1JdmEzclc3N00wK0RFY1pKcURMUjR5?=
 =?utf-8?B?QnRwWjdtWGlpOFRpamhaZWZjeTJlbURJM2xXUjV6aVJBWmdoeGw4Vkh0NnU4?=
 =?utf-8?B?S0wrWjdJZEJKNloydXNUc0d3ZmhkNitRODNRWlhCVHFnMGc1NldjQjBIbm9w?=
 =?utf-8?B?MFFCYzBTRXcvQzZFVDhDd0xKNmNXVXRCZS85eG1OYWtQVFpleVp1V0dINWU1?=
 =?utf-8?B?L3Q4MUlXYlVndW9icjRRNkhvTjVlZkI0cHB2RHNIUWRENnI3NEpNZTRoOEJh?=
 =?utf-8?B?ZlFlS2hMc0NKTERRbllnSnhMMWd6ZnZsV3pOSVFBY0Z3UGV6QWVwSmdKSDE4?=
 =?utf-8?B?NFhRWng4TTRydm5Ic2lzdmF5YzduQ0laWjJqYUkrdGd6eW91NWxOZUdkRFNW?=
 =?utf-8?B?N3dERnRVWEdaZWoxUExSdTE1TXoxc3g0dlZwOHQ5UkFaaG85Zjh6bzkwY1Vl?=
 =?utf-8?B?eDd6SzZ3VzdtMjBPWXc1aXAra2dPaTFoVWdnVExGQjNWakVNTTBkOXlLTWJQ?=
 =?utf-8?B?SUZQUFZzT01RaHJ0QUJBTDUvNTgzUzhXK0lXQmRWZmgyTzlkNDJnK2R3dDhT?=
 =?utf-8?B?YnVSWHFVSVFBOXJxL0RJc3g4cERQN0RobnBXdXZMRTJ2amtOVmtOOStIdktE?=
 =?utf-8?B?SVk4aTVVL1ZDRjRPa3VYYm9EZ1phTWxXSTFjd3MzZ292RmU2OUdxVHlOL3A1?=
 =?utf-8?B?cER3U2NrRmpRaTJXMWs4ay9tODc0VDVkOTFXazlHS3pQR0JJS25KVklpclIz?=
 =?utf-8?B?UDZTTXZzcVpuUmtFdUtJRXlTRXhxWHVmVnM2Tksxd3doSVNBNDErVjV4MDFC?=
 =?utf-8?B?ZkViMm1HSUNXbFRTbFJCWEVrNUd0U0lsbm13YW1SdlE3OWxKS2w0WUwvR1V4?=
 =?utf-8?B?SEZkYzlPU2xKQVZrN2o5ZkNaSGZvOXFnZXNmSGMvNlZPYml0SlROV1B3ZFpr?=
 =?utf-8?B?TVJEVjFCUWU4Uk5SQUNteEZpNG4zaHBzR1kxL0k1T1E0OFFaN1lKSnh4NXhx?=
 =?utf-8?B?bDVsZ0QzYzNSdGdneC9ITUlmeWdOTWNJbGhnQXhFNFdNVklLSFFhbzYweGxr?=
 =?utf-8?B?Rk11YXg3b3dzQTBaZ3VCSkVHODlVZ1hEaGJZT21pYlJCRERpc2tBZHFTRC9L?=
 =?utf-8?B?cm1uaGxwVWFPQnI5YzBtMVJON2JNaUpzSjYzVzBiZ0N4Z2xTVW02NWhXT2NR?=
 =?utf-8?B?V09qTk9zNGQxSWxBZE1BTmZyR0FEZk9Bb21vOS9QTjdMS08zNDNydlJSNDNR?=
 =?utf-8?B?NFRCTEpwWVpZRnlvd0pkcXVWSC9Va1QrZjJieVZPdEhDOXI2QUpERHBKa3Za?=
 =?utf-8?B?dFA2a1Jod3FGVUpnaW85dmk4WC9VRTVFVk1mVGZyUm5Yb0ZMQlp5WExxdnhV?=
 =?utf-8?B?VDhOWHJVSFZJMzgwZ21nZ2hWWGpSQ0djZC9FQUdVV3orVTByVE9BaDlGaUNJ?=
 =?utf-8?B?bSt1b2pPQktQd05Fc2ZRNUlacDROT1BhakJ6dmFVT09Zb2wzRHduNjJkWWN1?=
 =?utf-8?B?ditLeXpMclpUZFZGNHBHN01PN1ozQkpCUWlmUWRHR1prcG5ndTFEb3lwSTNR?=
 =?utf-8?B?SG1aQTlZbTZMZTBFdVhtRWhlRGlhdFZxZUlqc25GQmZHSlZjVE9KR2RaOWVZ?=
 =?utf-8?B?UUJQbDZ3MDJMWTM4dmhOdzV2NzkvOWh0dEUxdWJqckRDbDdRSjFhSE1XWkFp?=
 =?utf-8?B?R282WGJzamZ1U1JmS0VTeU5CZ0lyemtPNmZ5ZnV4M1pLaE1qTGczM2VHcFU5?=
 =?utf-8?B?WkNoejN3VW0rV1AvUzdSb3JuemJOdlR2eWd2R2txdHBDKytlNlZ3S2k1VDJa?=
 =?utf-8?B?SURqMVpNSE9zczlLZ2NxVEpwSEV0N3d3MUlRU0lEZnlwWENxMUJlZDhneDRt?=
 =?utf-8?B?a1BDdHlTZllhU2V6Wk1Ja1V6bHhCK0JlVGRxYnB0emR2VmVabXYzNncxck9k?=
 =?utf-8?B?TFc1YTdWYVVJNGkrK0FleVoyTk10cWV5M1hqYU9xVWhXRXQ5S1g5SW1OQjFE?=
 =?utf-8?B?Z1BUZ0x0NFJKREVvajk0TktVcktQRHZLajQvbFJnVnMxeXExczJqRXdSUm1R?=
 =?utf-8?B?TmJienUyVGJoVHBEQXkxdC8zcnljcUpWalM1ZE85MWhXSTUwK0dUVnlvcU9j?=
 =?utf-8?B?YWRQRnFkMStiRVFjZHArSzh2dGZhMThISkgrV3UrbVBIaWZUTlJVbE50b3lY?=
 =?utf-8?Q?asNt4Amo92Aw3NcJxOcLmpM=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d1a46620-b80b-4364-2266-08d9ea14c0f9
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2022 08:35:10.8840
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZDvKSGA96qesJgA7IcgB33AZPVYcdq7ZI/5dJxoNuPwtkfTvRv8IK6GMeYQ+d/vNb8BUheqYIEbTdCLxApboIg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0401MB2555

On 06.02.2022 20:28, Julien Grall wrote:
> Looking through the dmesg, there are still a few TODOs to handle:
>     - Linux is not able to use the BGRT (Invalid address). This is
>       because the driver checks the Image address is part of the UEFI
>       Boot Services Area. Such area is not exposed to dom0 (yet).
>       By-passing the check doesn't much help because all the EFI Boot
>       Services area are given to the normal allocator. So we would
>       need to reserve them.

Respective checking is supposed to by done by (only) Xen in our case.
I thought we do so, hence if there's a bug in there I think it wants
fixing on the Xen side. The Dom0 kernel should never be exposed the
Boot Services areas, and hence it should really trust Xen having done
whatever needs doing.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 07 08:46:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 08:46:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266554.460237 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGzfX-0005vW-CS; Mon, 07 Feb 2022 08:46:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266554.460237; Mon, 07 Feb 2022 08:46:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGzfX-0005vP-8T; Mon, 07 Feb 2022 08:46:43 +0000
Received: by outflank-mailman (input) for mailman id 266554;
 Mon, 07 Feb 2022 08:46:42 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=owYM=SW=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nGzfV-0005vG-UC
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 08:46:42 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 77256537-87f2-11ec-8f75-fffcc8bd4f1a;
 Mon, 07 Feb 2022 09:46:39 +0100 (CET)
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur01lp2052.outbound.protection.outlook.com [104.47.0.52]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-40-RED-pm_0NTieZlRUkgnRig-1; Mon, 07 Feb 2022 09:46:38 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM7PR04MB7063.eurprd04.prod.outlook.com (2603:10a6:20b:11e::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Mon, 7 Feb
 2022 08:46:36 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.018; Mon, 7 Feb 2022
 08:46:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 77256537-87f2-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644223599;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=lxlGo5YVbELHevjqX0pMZXl6Q5m9uHmz6oHkG3ocQqc=;
	b=GyBMpwDTwpnfBnN4X+iwCb4K7n4YBzZLqzW3VP4ot2A83QQFtdl0H7qW5UNlsMcozwP1Wj
	wKtLuyGzZkFHbVaYk87HAxAIcjFmxc6pmYweTIRvFsqKhQtylmB4Li2zMKmjHe2wsp9F0T
	tiCRWWtwLK2WgX8sSGr26NZiRl5f/0M=
X-MC-Unique: RED-pm_0NTieZlRUkgnRig-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=lOIb9WFdhu3EOVVQ0iLUYBQPeT0fi0Ksgq+yI43vhq7W4PVawveVzPeFX5mEDZ+75g1gJ3UT2eMbniawLs1uJPQ7JC41fEZvZKs+WxOLJAAR9eHvVSS5XA0w+RG02FXj/Z/rAVu5TNr/kI7IUe4EwHJJjBAqOp94OQ/nk61kYhZ/nt7HIpVBVkJsk66S2qNVRzME7CPOGJmd+NgSj2wAB9wvAgCRqi7o3mOKZsQsVazDMbDCW6UfJHAc6jvrSMV8gpfWsV/E6Lcy9i8sc1jQR2VXymj6ZEm9LXhS+7aeXknlSn35/VzFKRfqmnDBXCD4I9ymRm+pEFqli5Gz7JqiBw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=lxlGo5YVbELHevjqX0pMZXl6Q5m9uHmz6oHkG3ocQqc=;
 b=XIHAIvX71hifnvhefRDZL4JxDXgYsEMooI135VrkYroASpNe0HtVLzaMA8cwtzMj0D2hfmSyMGJh7sFhct5VQrW59ENinHDvdMrhcoFQQAKSlqgbPTwZelrlJFQO0z8Ja53QCUrT8Uyih5S8CgxR9PDHzxbctVUxCIE0YIwHdCmjpXudgpVmTeUHEnGRDL3aq/H06RwCE+/g55Jh9R+KO7RhEuaPPhRpuDEKAkOdq3S702nJ6eZDgkXXbrUrcanxkuVno0DytXZJd3prU7eZ11lqawLK8msp/t/ofdFj9xRJX+0e6/lzn0K4qWgktWcmZsTJ+jM614wqA9nqIaqP7w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <88741681-929f-4cda-e841-023bdbf8f772@suse.com>
Date: Mon, 7 Feb 2022 09:46:36 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH RFC 1/3] xen/efi: Always query the console information and
 get GOP
Content-Language: en-US
To: Julien Grall <julien@xen.org>
Cc: ehem+xen@m5p.com, Julien Grall <jgrall@amazon.com>,
 xen-devel@lists.xenproject.org, Daniel Kiper <daniel.kiper@oracle.com>
References: <20220206192839.75711-1-julien@xen.org>
 <20220206192839.75711-2-julien@xen.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220206192839.75711-2-julien@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR05CA0023.eurprd05.prod.outlook.com
 (2603:10a6:20b:488::13) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 64d8f6cc-130a-4fe3-5ce3-08d9ea16593d
X-MS-TrafficTypeDiagnostic: AM7PR04MB7063:EE_
X-Microsoft-Antispam-PRVS:
	<AM7PR04MB706368D8649DCBBBF768EACCB32C9@AM7PR04MB7063.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:341;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	rKWI8c1MNHopPALXgeWKEtnDwkvvR+K14WbrfOJ5jlN1WADmYUlA5rnJ5euzNUfoYk7B+Fl30GXqrQVs/pLuIXuy/jy1g2EXKVkNaP2bYrxtoFC11EVBWdlWutCSd2koXD0RcSudPENeKr8F7+L9RZit7xPd6UdR0tmZwP+BGTi1Bu81BBA9sQutm0gdCTMssFGQp9oBjF5t1dglF6edbopF1p61VocaM296GHBiHFoTTEKN95fpFC9Q0cB0IFHy/e0wzkgvBMS9RpVxVI7qACRBECSbCK+VtOedHrAHvQx/QWxVP4m56FS9HWiDvfunzI1zCz9BJLcIAblHJEZ29sIs816Xd1/FXTomjBTg806QuTjtvPIsh5sUrH7EOfW5aa6PzUhAg3X1o3fvuhb/mzSw/fV6jbNlvujQ7ey9i2O1CPnJGlTECazmDTMgOKCUtT7w24Hn2NVTRWAcMGeT9mKWRid8YX+Q0Mr/E/Yz1WpCfruPusbM8XI7efpKG9sdRpowLHI5+4mC4Zmj4XUpx6Gn0qmXCHEs3JYk2O5v0WilqSwp/lO6LjiHfFS8VEnebOyf84toVBsmraJPATcNGsH/+c6wX5jrQ8PNQCGZ/g8HAjkCECxXZGzwkP6+vWT69qUDo182e4KSp+JdmgIlCJU50FiAIan8WUNm9FjFI8OzZSioS9a+lJ7QMGCUXfO1/zQUbMPmGWdwX4WQwx/mOOydwEvsNhvmNm9aTXNCK9g=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(36756003)(26005)(186003)(54906003)(6506007)(316002)(6512007)(6916009)(38100700002)(2616005)(2906002)(31686004)(53546011)(31696002)(86362001)(66946007)(5660300002)(508600001)(83380400001)(8676002)(8936002)(4326008)(6486002)(66556008)(66476007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aFZEWXhFeTNaMTBTd2FoZ3BWWUZMMG9jQ2hSOGVrdVhaaVVkNCtlZXNCWmE0?=
 =?utf-8?B?dXdXRUtpWmpFWmc3VHRLRmFYK0dva0szcVpGbld3LzVzL2FkS1NsTVB4TldZ?=
 =?utf-8?B?cFFtM3RhYWd0N2xORmh1Z3JZd1h5a2h0emdOQ3ZmcnVYNG5DLzR3TjVrRTl5?=
 =?utf-8?B?ZXl1QllqWDRHa1MrZmJER3pyV3RkVU9kZUtRY1ZkemNpU243QkN0WGhoWDN1?=
 =?utf-8?B?SThXY1VKdS9MNnV1YTNTOWFpTWdWUHpvKzY3eWZGM3FhdENDL1RtbTFpa2py?=
 =?utf-8?B?clNqdVJMak9mdU5jOGpmdUpIN2dkdmJiZEtyMkN0R3MycGxhUVROem5PRFlx?=
 =?utf-8?B?aHJ4SXhrcVN2UXk3TGRRVVU1WXhLSXJRMTR2eUI5akF1c2M0RzR0Y0ZZMWt4?=
 =?utf-8?B?RmlhTmY4U1dIa1dhdDFuaFFBdHRacHdhcVVZc3hpYlJ4MWNuVm5nZjVuQXVW?=
 =?utf-8?B?R3pDZSt6eThMUnhkMldLTWJxQTl2dTBGdGdjTDFXc1NaZ0tuejJlbFZjd2sy?=
 =?utf-8?B?YjI2R0dtL3U1QjZzNnhNZW1XV1pCR29FMU4zaEJnaE9hU1JMOUdGZkRrOENo?=
 =?utf-8?B?NjNsbEQrbk1ONUVaTXEyYlBJZGNQWnVBeWUyS2Q2TFFyZ3o4ekZnb1FZaU9S?=
 =?utf-8?B?dFQ0OHEzYkN2NUVmM0duQUJMcGFzbTJZVURidDc2TTVrVXpqY2NSaTBtRmQv?=
 =?utf-8?B?em1jYXdIM2VjRklOR1ZXdDF2UmhhQ2xKdFl3THhnRE1RY1pmd25BSHUwck1T?=
 =?utf-8?B?cU9iVytzQXVaajNGeWZSVHNBby8yUVVVSDJkOGhFSEoyVVlOWWhaaTRGT2Nt?=
 =?utf-8?B?RVBzU2NUNHI5RWI3ajdRWjdsbDA5R0VrbGhzUW90d2JNdUJvNjNsRFl1WWE5?=
 =?utf-8?B?M2h1TkxoSlFKZUlHMERkV3RMYS9KVTl1SlVtZWozTEVpVndzcFVMQWQzNWhE?=
 =?utf-8?B?cm1aY2lQZzFlRmRBNDZWOEJkT1d4R0x0M0V4WVRBZzk0NlVEYTkxZkxLQVFm?=
 =?utf-8?B?ZTV0a2Rjd0JsMHUvczlpVy8zWGtOZ3d3b2xxWndVQ0VJcmxmdkR5TGc1Zkxo?=
 =?utf-8?B?YkhPbzBKbjM0Y3dSdVJYRkh3U0I0SDRMeEs5KzRlYnNtU3QzdlcranlvY3Yr?=
 =?utf-8?B?NitSRHlCb2N5dUU2UW50enF5ZFQyckx5WE1BZmYvK3BOVGdRTzNFcFNBQy9l?=
 =?utf-8?B?S0NXSEw5cDE2b1dKUUluWHVYZk9nTURNTFlCWjE4TDBUM1ZwL0tLU21KK2Nt?=
 =?utf-8?B?WWk0RzBydWtVOHFQRWorckdFYUJ3UnNrU0VTWkM3NE15NmlxVjdBWE11dm5W?=
 =?utf-8?B?aUVwcHIyYk5sV1pjRkVoVktSeTgwVGtPUU9LVmtqWTlFRnpxOVRkQmp6V1hv?=
 =?utf-8?B?am80TXZuSit6YVRVbWdFVDNuaGhYR0JGOHZYWVVwT0lxRFdNaDZTSXk4cDdo?=
 =?utf-8?B?S0FvMWZGSndhSGwzVXNNZmNxYm9GU0ZlMldJYnhXUllrWktzeFRBd0xSTFBv?=
 =?utf-8?B?Sm9MaTRIVGdLbERTNHZ4RlVUUEVGODZkNHVtOU1idzY2ak5UQWx1UWw5NXZj?=
 =?utf-8?B?VTI1ZnVLb1UrTDlmcU00ZkFuZ0E1SjhxbmRyUm9ZSDRwbE9QTFZMY2ZUcmxM?=
 =?utf-8?B?UzIzeUdNZU5WQTlPVjNPS1NyWTFNbUwyZzNYNTd4VHlyVGI5cy9CRDdKM1A4?=
 =?utf-8?B?NHVOY0RQL0dnK0gzYkxSVm45R1VIL0t1VGdVK3R2M0I1YUdnSVp2S281aCtp?=
 =?utf-8?B?bDM1L3d5UWFNelltQktmL0VIaEFobmIwZjZ0THo5TWdnQ2ljcVBqZmVtVXJh?=
 =?utf-8?B?NVc3OXRwcmdUNktRM3hId1FPUEtpZ1Q3S254ZDltL0VrL0hOVWlzL1Ara2wy?=
 =?utf-8?B?UFpNYXFHY3BVUC8vWlpnMmFZTFpscUdLakVMZnJENlVqNzdVMkNrKzlRMmhQ?=
 =?utf-8?B?UmZxVXpGbzRtUkJIb1NmdVFHOE83MW56di9DbjJLa0pqNHdyZTMxOGF0a0ZD?=
 =?utf-8?B?ajNMTXhzbkp4eDRwMjd5Vi9JWjVPclNOdElidDY1TkZNWjZUZ0JkM3Njdkho?=
 =?utf-8?B?YzlEMTBMZWZLNEpQOHN3NlBRS0E2aVdTYTA2aTlrN00vUnRtR2krbkNmMmla?=
 =?utf-8?B?VVBWTGpzcWhTVUppOWlqRExvM0VsSVR5cHQwN1NtTVlxTExPc3JmQUNlSDhx?=
 =?utf-8?Q?EnwgM+hWJWTbd75Pg3g2dIc=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 64d8f6cc-130a-4fe3-5ce3-08d9ea16593d
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2022 08:46:35.9665
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mH2D6xfXLXxxroj2Nv8lw7d1fE1/5rU+HiLMAyjbuZFodF9Igl6QjW8ZDKlrpjZvmOOmCH350zavyNPdzkrZ6Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB7063

On 06.02.2022 20:28, Julien Grall wrote:
> From: Julien Grall <jgrall@amazon.com>
> 
> Currently, the EFI stub will only query the console information and
> get the GOP when using the configuration file.
> 
> However, GRUB is never providing the a configuration file. So the
> EFI framebuffer will not be usable at least on Arm (support will
> be added in a follow-up patch).
> 
> Move out the code outside of the configuration file section.
> 
> Take the opportunity to remove the variable 'size' which was
> set but never used (interestingly GCC is only complaining if it is
> initialization when declaring the variable).
> 
> With this change, GCC 8.3 will complain of argc potentially been
> used unitiatlized. I suspect this is because the argc will
> be iniitalized and used in a different if code-blocks. Yet they
> are using the same check.

I'm inclined to suggest this wants to be a separate change, with its
own justification. You're not touching any use of argc here, after
all.

> Signed-off-by: Julien Grall <jgrall@amazon.com>
> 
> ----
> 
> It is not entirely clear to me why the GOP was only fetched when
> the configuration file is used.
> 
> I have tested this on RPI4 and it seems to work. Any chance this
> was done to workaround an x86 platform?

This was done so in the context of making the code work for Arm. See
commit c38cf865ec82 ("EFI: ignore EFI commandline, skip console setup
when booted from GRUB"), the description of which explicitly says

"Don't do EFI console or video configuration when booted by GRUB.  The EFI boot
 code does some console and video initialization to support native EFI boot from
 the EFI boot manager or EFI shell.  This initlization should not be done when
 booted using GRUB."

What you say now is effectively the opposite (and unlike back then
x86 is now able to use this code path as well, so needs considering
too). Cc-ing Daniel for possibly having a GrUB-side opinion.

Jan

> --- a/xen/common/efi/boot.c
> +++ b/xen/common/efi/boot.c
> @@ -1129,9 +1129,11 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable)
>      static EFI_GUID __initdata shim_lock_guid = SHIM_LOCK_PROTOCOL_GUID;
>      EFI_LOADED_IMAGE *loaded_image;
>      EFI_STATUS status;
> -    unsigned int i, argc;
> +    /* Initialize argc to stop GCC complaining */
> +    unsigned int i, argc = 0;
>      CHAR16 **argv, *file_name, *cfg_file_name = NULL, *options = NULL;
> -    UINTN gop_mode = ~0;
> +    UINTN gop_mode = ~0, cols = 0, rows = 0;
> +
>      EFI_SHIM_LOCK_PROTOCOL *shim_lock;
>      EFI_GRAPHICS_OUTPUT_PROTOCOL *gop = NULL;
>      union string section = { NULL }, name;
> @@ -1219,18 +1221,16 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable)
>  
>      efi_arch_relocate_image(0);
>  
> +    if ( StdOut->QueryMode(StdOut, StdOut->Mode->Mode,
> +                           &cols, &rows) == EFI_SUCCESS )
> +        efi_arch_console_init(cols, rows);
> +
> +    gop = efi_get_gop();
> +
>      if ( use_cfg_file )
>      {
>          EFI_FILE_HANDLE dir_handle;
> -        UINTN depth, cols, rows, size;
> -
> -        size = cols = rows = depth = 0;
> -
> -        if ( StdOut->QueryMode(StdOut, StdOut->Mode->Mode,
> -                               &cols, &rows) == EFI_SUCCESS )
> -            efi_arch_console_init(cols, rows);
> -
> -        gop = efi_get_gop();
> +        UINTN depth = 0;
>  
>          /* Get the file system interface. */
>          dir_handle = get_parent_handle(loaded_image, &file_name);



From xen-devel-bounces@lists.xenproject.org Mon Feb 07 08:53:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 08:53:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266565.460248 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGzm3-0007Rc-5I; Mon, 07 Feb 2022 08:53:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266565.460248; Mon, 07 Feb 2022 08:53:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGzm3-0007RV-28; Mon, 07 Feb 2022 08:53:27 +0000
Received: by outflank-mailman (input) for mailman id 266565;
 Mon, 07 Feb 2022 08:53:25 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=ddl1=SW=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nGzm1-0007RO-5q
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 08:53:25 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 68475709-87f3-11ec-8f75-fffcc8bd4f1a;
 Mon, 07 Feb 2022 09:53:24 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 833D51F37E;
 Mon,  7 Feb 2022 08:53:23 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 55A2513ABC;
 Mon,  7 Feb 2022 08:53:23 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id SldeEgPeAGIyCQAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 07 Feb 2022 08:53:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 68475709-87f3-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1644224003; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=gbYYpP1ofdmOnvO7Y4oyOOzmxBbTDWXucvcUs4lpTwE=;
	b=CrZH/FBjNv0FoVkBxkBMDn6Y86r+hYNL/zLLRtkfwHdN1V90MR6krwMqRqUpEl83zZz1Gj
	ki/hN3xQ98BAhKFxx9j93S4aEXIzd3tMPWF2Oj9/ISCNOqLWcvcO3W700Z0CdTgK05a0Tr
	bezLHUdToL5Jir4zMMZAEkM2w+c/QzY=
Message-ID: <ee3648f2-203a-70be-1a5f-ac1df45a054e@suse.com>
Date: Mon, 7 Feb 2022 09:53:22 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Subject: Re: [PATCH] xen/x86: obtain full video frame buffer address for Dom0
 also under EFI
Content-Language: en-US
To: Jan Beulich <jbeulich@suse.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 lkml <linux-kernel@vger.kernel.org>
References: <2501ce9d-40e5-b49d-b0e5-435544d17d4a@suse.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <2501ce9d-40e5-b49d-b0e5-435544d17d4a@suse.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------hh6pmzbHEFuApL2yB5aX6lcw"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------hh6pmzbHEFuApL2yB5aX6lcw
Content-Type: multipart/mixed; boundary="------------CiOl9PFExzxoTfP3ssHzdoKF";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <jbeulich@suse.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 lkml <linux-kernel@vger.kernel.org>
Message-ID: <ee3648f2-203a-70be-1a5f-ac1df45a054e@suse.com>
Subject: Re: [PATCH] xen/x86: obtain full video frame buffer address for Dom0
 also under EFI
References: <2501ce9d-40e5-b49d-b0e5-435544d17d4a@suse.com>
In-Reply-To: <2501ce9d-40e5-b49d-b0e5-435544d17d4a@suse.com>

--------------CiOl9PFExzxoTfP3ssHzdoKF
Content-Type: multipart/mixed; boundary="------------i2lh93ijwOC0lpitsXG2i3Nn"

--------------i2lh93ijwOC0lpitsXG2i3Nn
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMDcuMDIuMjIgMDg6NDEsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBUaGUgaW5pdGlhbCBj
aGFuZ2Ugd291bGQgbm90IHdvcmsgd2hlbiBYZW4gd2FzIGJvb3RlZCBmcm9tIEVGSTogVGhl
cmUNCj4gaXMgYW4gZWFybHkgZXhpdCBmcm9tIHRoZSBjYXNlIGJsb2NrIGluIHRoYXQgY2Fz
ZS4gTW92ZSB0aGUgbmVjZXNzYXJ5DQo+IGNvZGUgYWhlYWQgb2YgdGhhdC4NCj4gDQo+IEZp
eGVzOiAzMzVlNGRkNjdiNDggKCJ4ZW4veDg2OiBvYnRhaW4gdXBwZXIgMzIgYml0cyBvZiB2
aWRlbyBmcmFtZQ0KPiBidWZmZXIgYWRkcmVzcyBmb3IgRG9tMCIpIFNpZ25lZC1vZmYtYnk6
IEphbiBCZXVsaWNoDQo+IDxqYmV1bGljaEBzdXNlLmNvbT4NCg0KUmV2aWV3ZWQtYnk6IEp1
ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4NCg0KDQpKdWVyZ2VuDQo=
--------------i2lh93ijwOC0lpitsXG2i3Nn
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------i2lh93ijwOC0lpitsXG2i3Nn--

--------------CiOl9PFExzxoTfP3ssHzdoKF--

--------------hh6pmzbHEFuApL2yB5aX6lcw
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmIA3gIFAwAAAAAACgkQsN6d1ii/Ey+2
jwf9HhMOA9zsQr5UHsYQs6eP2EcbyibSA8xTSUmyqWlyfHbgNB34Se1NQoET6x5Dlk4wG9/9fB3V
3v8SacvDlwGpOzoM4yoG6eSNrzN+Me3h2Ozs33JvZtQyHNhg2JhQYD3w5DLgT6ei4ammyZ7O8KH7
yKmp3tSaE3eMbalbnuis4zPxIUEsUkMzFX5hN3opRG86L6ABzREVPjlLZ4RfoLp9IUouj8dN16zX
IUMc0JRcWKkByCfsc5TS23iH1HJItSkSAkaMLri0rj7FcJGmRy7SA+N9kRnF6zAyghhHIOLw5G1W
kOAl8LN4TJ7Ry1PWSt0GHsnBkQSTTFE3CDvtsNeBKg==
=JjD3
-----END PGP SIGNATURE-----

--------------hh6pmzbHEFuApL2yB5aX6lcw--


From xen-devel-bounces@lists.xenproject.org Mon Feb 07 08:53:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 08:53:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266567.460259 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGzmS-0007vH-F2; Mon, 07 Feb 2022 08:53:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266567.460259; Mon, 07 Feb 2022 08:53:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGzmS-0007vA-BK; Mon, 07 Feb 2022 08:53:52 +0000
Received: by outflank-mailman (input) for mailman id 266567;
 Mon, 07 Feb 2022 08:53:51 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=owYM=SW=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nGzmR-0007uy-Nf
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 08:53:51 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 77b205b2-87f3-11ec-8eb8-a37418f5ba1a;
 Mon, 07 Feb 2022 09:53:50 +0100 (CET)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2107.outbound.protection.outlook.com [104.47.18.107]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-29-p1sANG96NRaoWJXxRMVpjA-1; Mon, 07 Feb 2022 09:53:48 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM7PR04MB7063.eurprd04.prod.outlook.com (2603:10a6:20b:11e::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Mon, 7 Feb
 2022 08:53:47 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.018; Mon, 7 Feb 2022
 08:53:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 77b205b2-87f3-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644224029;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=bbajDJNRxGbgxuYUH8E1+csdYq9ygwMnbguqJxXnRUc=;
	b=Lzr7Unwh8WxFihjJFFb+5XYOrPh2kooGere4IAfokEJEZcgoDd6yB3AnZvBmfguPHuUp8H
	1S5Q0TS9zCPtxy4/YT2iAjmSvTRHy8gAB0RERnXJyVoydQncq1845eZ8X+RtF8+/2xBkX/
	6XEwez5uVyJFr4KD+ga94QCvG2vZm3g=
X-MC-Unique: p1sANG96NRaoWJXxRMVpjA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=iU5iVbImd7RTHkKaWFP+I3kZqMkA00d4JmSYtFY7aQVc7TgwsspzFgXdNu9E7TFUhC4s6Jg9P8azDozkpE/jqnGQaxihfV67ZSGMmINcd61n56Ax4szQg47JT6gW+3zYkKJ4DYWEV4vud4MilkZl2fY1QiLnaOOm1xT0gskiS6MV6vCpSovvXTNLpoamB9NOPNLrVmmMTDxDZISFPDzV5UroTIpRsBEPvsAx/bMUudG5Q+SX8OYBS/THO3O0x0x4/A8aGbU1StBBaH0QZeaLLhQFCfzlIwBc42xFpypy1MCEP15mZ9ojr9FqcK63DT+nKsYqxsXkkqKiqt3LafsYbw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=bbajDJNRxGbgxuYUH8E1+csdYq9ygwMnbguqJxXnRUc=;
 b=glZqj8e8vkqJFkxQtIwrdiNRBWCBy63oRM09mx8tUUnNxpqlqThvtrZQ+7YN54E0MvAjvlEW8mQ8+o9FJzmswiEE/sWaEgP2913TitZojHA1gwc+Ooq8GSV6UW03tBRbWOQdqqEtYCymvVO6Qluu3utOMe+mh33oWNK9AYCr1cI+wEdi1WZmI8qCaMMf/+AgATgUNyqPz2CGP8OnxQkfnnLHm66j98h5El5x8LhlDtbUEqekPUoXYfFpu1Y0Z79KKcbGpPJfveVwkKTtJBdDc8WRUhdtewHj6ERxQRUEcgLmh391ylsYkWe/FpjKhaqDnxs0XI2VAnYbagi/UR6mUQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <6249db03-01b5-e1bb-75ad-5946e16f639d@suse.com>
Date: Mon, 7 Feb 2022 09:53:48 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH RFC 2/3] xen/arm: efi: Introduce and fill the
 vga_console_info
Content-Language: en-US
To: Julien Grall <julien@xen.org>
Cc: ehem+xen@m5p.com, Julien Grall <jgrall@amazon.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 xen-devel@lists.xenproject.org
References: <20220206192839.75711-1-julien@xen.org>
 <20220206192839.75711-3-julien@xen.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220206192839.75711-3-julien@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR10CA0033.EURPRD10.PROD.OUTLOOK.COM
 (2603:10a6:209:89::46) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 3f85f17e-83f6-482b-790f-08d9ea175ab2
X-MS-TrafficTypeDiagnostic: AM7PR04MB7063:EE_
X-Microsoft-Antispam-PRVS:
	<AM7PR04MB7063B3650583308937EB9C97B32C9@AM7PR04MB7063.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	fodQGPU8sJ1VW62UqGPvapSBPMU0E89APfb1Vmqsm9X3vMPcgRtQLAxt5qwibW7qHBYJhsthoQ7PJkGAtTUsYm8J7dJ/t00UAL79zAxzx3g1/bXrESLCoAq6HztsyGzLyRH1/pxWuUX2YFQqqV0cs4OhExoBREGKb601maUL0WP1e+P5SvSL+EZVkIH6sNF2AEOlm3taF1g3kUuXcJ4l1rjkTMbqqAV1zD6+uPsags/Tr7dpQt1bcPVF9Wx8SWMXTwZj8iuFTED2vBzflbpDltTg5/UVqz2W2A9qEcvYe3KxWHcz1W4g8AD/kDYTFtSv7mTCE3UQC8RclH7HkcHGy4Ej+O6WUZQl0uOaj8EvCvpt9Kx07zULVcSto+qeLfy0ePHVmYOkoQ1QsFXgDkvJfziC/MCQeuP5D6k3EkkO06VhP1JHK9wyRp8eG5bizGr4s8bxGysxIrn9+0hhNvzdMqtqdljsr09Hmgxf+GqVq2iFvyK3LbYfRMonLfguWJj1N58LYpYq4bE7KNfQ7s4xQe4oMWWf1P8gZnOmvWdxkIpwhlAl4BUn8BJo9Q26dbfsogueu9vLrO/NQ/88ryaAyaQwXQ9+VDDdd1uEgIaWQB4UfTWojy4BDT8/YdCoXCLIYGyi9kvZifWSFvsW8zBkcenzbD7VI8x4rO1HaFAIlRU9DzoCHX2kdbUR2kv+CFP6XSpgadAtIugL23vj4A6lC+BL7q6iUDCBdoWauulkI/0=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66946007)(31696002)(86362001)(8936002)(4326008)(8676002)(66556008)(66476007)(6486002)(5660300002)(83380400001)(508600001)(7416002)(6512007)(6916009)(36756003)(26005)(186003)(316002)(6506007)(54906003)(31686004)(53546011)(38100700002)(2906002)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?SjNWUEdlL0h1ZklSckpYYzFrQWpjU25VNlEvcnlIVTlyd0VYd0lmcHJTdWJ0?=
 =?utf-8?B?WG95YW02VGU5QUk3WmlmQUhJd0l0UEg3dzc5U1VOM0VwZnpXVGtIaHF2SEh4?=
 =?utf-8?B?V3hDdVd3SmVsQ1VsdnljSXhHdSthU05EZ3YrUktZSmc0djJ5Nnp0RWdVdm1q?=
 =?utf-8?B?TTJDT2VhdjdrcFRhSGF3dDBwUjlBdWZEYk5JY1EzQytOT0NySjkxQWpnNFhj?=
 =?utf-8?B?bkJQa3I2SXZIRFY1WHlDTVVHSVIvOWorL1o5cEhHSWVZb3FJM0E1UnpnM3VD?=
 =?utf-8?B?WWdxTWpQei9DQm9JRTBrYi9FVnlHM0wrM0VMRTR2cjlxNzlYclM3eGdJbEEy?=
 =?utf-8?B?bThTRHRVenhoS3VVS09aZk9wZk5CSExuL01PcSsvaHI4Y3p2OTd1bDk0a1cx?=
 =?utf-8?B?dDArbi9EamgxTXBzWWVhNmtJNVdPRktoQ0VLd0VUZjdPQkZEdGd1U2NTeGRF?=
 =?utf-8?B?ZWhpZVQ4QTYrVjM1M1ZPaHZvQ25OamI1ZVVKZWZYNlhsVnpuME1wVFgycHlz?=
 =?utf-8?B?S1BCaDh3Y0NzTHJBQjdKQ3h3KzAxQ1RWUXo2bG8zNnZzQnp0K1daREYydXFN?=
 =?utf-8?B?RkV1VVowTWc5RjhwYm40eDExSUdFYmFMSWJGdWJhTDdOK3cxbFBsazdlNW1l?=
 =?utf-8?B?ZXhGKzBSdDJlYURUZUhnM2pEMngxUGdBdmJLWTN3d3U3NEJsSXRmaVlXd1Bh?=
 =?utf-8?B?SmFCYmhCVU1VNHNiYk1GSHRYdGpnZkhaN0lMcTRXYlU1ZzcrQ2lJYzd6dVhD?=
 =?utf-8?B?QWkrWlNNeEVidmJRZHNvWk9vdFlWbVNvbmZZUjFpNTNnZm9SNE5aaHYxcG1J?=
 =?utf-8?B?U2Vmd2tGMzl4UGtTNDNrRS8wTHVrcitOMEUramNJYzBZZnA0a0VrQis2MWdP?=
 =?utf-8?B?eitkS2NxUnFvenB0SUJMWDJFSTVmdHdsVGRQOHl6SHcrWUFDc2VFUW9JM252?=
 =?utf-8?B?OEZrK09USVp4aXRFdTFaYXVQbklTZWhVc2o1N2djdWpCSFJxM2NiZjZpak5J?=
 =?utf-8?B?NXVmWmlhWEdrMXk1SThHVS82VXB2Zk15MGRjNWU4UUlocWNVNVhRcEo0SjVU?=
 =?utf-8?B?dEtRSUVRVFpLYXJCcVVaMUZpeDJrVkI2S3Z2Tzk3dDZuQUw1VXdEZG9wcWR4?=
 =?utf-8?B?TzQrNW5neWNJb3pMYnVXV3kvUDRKMWFFM1c1WEVkSUU1c1I0OCtEc0JlK3lu?=
 =?utf-8?B?TmpCdEVXakV2M1N3NzJENFlROGxoU281NUxRRjU1Ym0vSkMvYm8zUDVzOTBW?=
 =?utf-8?B?UWNYQ29jQytVbnRqYzVzUktZSHNnZlc5QVp4eTJNMWZwUDZJbTRyYkRkd0FB?=
 =?utf-8?B?TmIvVGVPYTRHWFlvdlFFTUtJNXBMa1BMY3dybHhWMkZEWkhoekNuYjNKZmgz?=
 =?utf-8?B?NmhPUDBwbmVTejdVc2pFM0pkUjRZT0RSSnU2RGFiejRUcnV4OVBJOERqMjkw?=
 =?utf-8?B?NEx0Z2lJSUVESjh1MVJLMG92YTZWS3dGbkRid1diR3RqK043SU9RTE9WcWVM?=
 =?utf-8?B?S3E1d0RlRVZaMWRFdWlGZllGS3JWaEFFcm83RFpYQkRoajRPc3lrR1pTbnEy?=
 =?utf-8?B?NnNsR3l0eHY3c1JIdlkzU3RyOUt0dG1iVmJWSWFxNy9sUE9PZGFJR2hudkZv?=
 =?utf-8?B?Y2xob1VVbmEvWE83Y2kxRGFZY3p6WWc5T3Q0a1d6YVQ5ZjhuQ2REeUhOSUtn?=
 =?utf-8?B?NGdwcmdnUkhFVXVqRnJqNG9MalZmU0lxc0ZGZEQxYzNWcnREdXhWWkl1bDN3?=
 =?utf-8?B?K3FpczVZdE9SRlFNTElpUm12VStjZFVyMGMyOEd1K3c3eUdpdnpYbDVPc2tQ?=
 =?utf-8?B?cmxOaEV1NXJDU2QyRS9Ca1JlZzBTN0pGREkxYk5uby9ablJCVC9aeUtVWXRV?=
 =?utf-8?B?SDc1eEY1ZnFnenB4dlV6UnNjalkvUkxhY3ZjM3BXYXdkS2l5MmFWTmxHeXYz?=
 =?utf-8?B?K0ZEOGNtVDZPVnVwaXRFQVRFQmFhOVlYbklmR1R6SE5kRlZReVZxay84bVZJ?=
 =?utf-8?B?MnB6U21SQ09TSHUwVGpQZDJhMW5wQW92TEVMSzVhbGJ3UlJoSUFLejM1ZDQ5?=
 =?utf-8?B?VDJjb3dmWS9jSWVPYzJObm1PQ2R2YW10ajFEWFR2L2V5dTBMVktibG4vY2tX?=
 =?utf-8?B?SXRXSlNsMmxvN3hLTTZ0RlZtOE5TQ1p5UjdEd1k4Z0o4YTFkT1ZpQVdaZVd4?=
 =?utf-8?Q?iUFWlBEBA4dLrtBfnukuyc4=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3f85f17e-83f6-482b-790f-08d9ea175ab2
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2022 08:53:47.7678
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bdg28+HGF11YwEVUR8UEHReQeeLoKJY1fUfM20BR9mA+Nk4DRBe2HnLFFUK1ruZUMwUBXkWWi1+/ky8l8fEAaw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB7063

On 06.02.2022 20:28, Julien Grall wrote:
> From: Julien Grall <jgrall@amazon.com>
> 
> In a follow-up patch will we want to add support for EFI framebuffer
> in dom0. Yet, Xen may not use the framebuffer, so it would be ideal
> to not have to enable CONFIG_VIDEO/CONFIG_VGA.
> 
> Introduce vga_console_info in a hacky way and move the code
> to fill it up from x86 to common.
> 
> Signed-off-by: Julien Grall <jgrall@amazon.com>
> 
> ----
> 
> This is a bit of a hack. Sent early to gather opinion on whether
> we should enable allow Dom0 to use the EFI Framebuffer even
> if Xen is built with CONFIG_VIDEO=n on Arm.

I have no input here; this will need to be settled among you Arm folks.
I have no objection to the code movement, just one nit:

> @@ -1025,6 +1026,77 @@ static void __init efi_get_apple_properties(void)
>      }
>  }
>  
> +static void __init efi_video_init(EFI_GRAPHICS_OUTPUT_PROTOCOL *gop,
> +                                  UINTN info_size,
> +                                  EFI_GRAPHICS_OUTPUT_MODE_INFORMATION *mode_info)
> +{
> +#if defined(CONFIG_VIDEO) || defined(CONFIG_ARM)
> +    int bpp = 0;
> +
> +    switch ( mode_info->PixelFormat )
> +    {
> +    case PixelRedGreenBlueReserved8BitPerColor:
> +        vga_console_info.u.vesa_lfb.red_pos = 0;
> +        vga_console_info.u.vesa_lfb.red_size = 8;
> +        vga_console_info.u.vesa_lfb.green_pos = 8;
> +        vga_console_info.u.vesa_lfb.green_size = 8;
> +        vga_console_info.u.vesa_lfb.blue_pos = 16;
> +        vga_console_info.u.vesa_lfb.blue_size = 8;
> +        vga_console_info.u.vesa_lfb.rsvd_pos = 24;
> +        vga_console_info.u.vesa_lfb.rsvd_size = 8;
> +        bpp = 32;
> +        break;
> +    case PixelBlueGreenRedReserved8BitPerColor:
> +        vga_console_info.u.vesa_lfb.red_pos = 16;
> +        vga_console_info.u.vesa_lfb.red_size = 8;
> +        vga_console_info.u.vesa_lfb.green_pos = 8;
> +        vga_console_info.u.vesa_lfb.green_size = 8;
> +        vga_console_info.u.vesa_lfb.blue_pos = 0;
> +        vga_console_info.u.vesa_lfb.blue_size = 8;
> +        vga_console_info.u.vesa_lfb.rsvd_pos = 24;
> +        vga_console_info.u.vesa_lfb.rsvd_size = 8;
> +        bpp = 32;
> +        break;
> +    case PixelBitMask:
> +        bpp = set_color(mode_info->PixelInformation.RedMask, bpp,
> +                        &vga_console_info.u.vesa_lfb.red_pos,
> +                        &vga_console_info.u.vesa_lfb.red_size);
> +        bpp = set_color(mode_info->PixelInformation.GreenMask, bpp,
> +                        &vga_console_info.u.vesa_lfb.green_pos,
> +                        &vga_console_info.u.vesa_lfb.green_size);
> +        bpp = set_color(mode_info->PixelInformation.BlueMask, bpp,
> +                        &vga_console_info.u.vesa_lfb.blue_pos,
> +                        &vga_console_info.u.vesa_lfb.blue_size);
> +        if ( mode_info->PixelInformation.ReservedMask )
> +            bpp = set_color(mode_info->PixelInformation.ReservedMask, bpp,
> +                            &vga_console_info.u.vesa_lfb.rsvd_pos,
> +                            &vga_console_info.u.vesa_lfb.rsvd_size);
> +        if ( bpp > 0 )
> +            break;
> +        /* fall through */
> +    default:
> +        PrintErr(L"Current graphics mode is unsupported!\r\n");
> +        bpp  = 0;
> +        break;
> +    }
> +    if ( bpp > 0 )
> +    {
> +        vga_console_info.video_type = XEN_VGATYPE_EFI_LFB;
> +        vga_console_info.u.vesa_lfb.gbl_caps = 2; /* possibly non-VGA */
> +        vga_console_info.u.vesa_lfb.width =
> +            mode_info->HorizontalResolution;
> +        vga_console_info.u.vesa_lfb.height = mode_info->VerticalResolution;
> +        vga_console_info.u.vesa_lfb.bits_per_pixel = bpp;
> +        vga_console_info.u.vesa_lfb.bytes_per_line =
> +            (mode_info->PixelsPerScanLine * bpp + 7) >> 3;
> +        vga_console_info.u.vesa_lfb.lfb_base = gop->Mode->FrameBufferBase;
> +        vga_console_info.u.vesa_lfb.ext_lfb_base = gop->Mode->FrameBufferBase >> 32;
> +        vga_console_info.u.vesa_lfb.lfb_size =
> +            (gop->Mode->FrameBufferSize + 0xffff) >> 16;
> +    }
> +#endif
> +}

While you move this code, could you please insert blank lines between
non-fall-through case blocks, and perhaps another one between the switch()
and the if() blocks? And it looks like
- the "gop" parameter could also do with becoming pointer-to-const,
- the expanded #ifdef could do with a comment briefly explaining why Arm
  needs-special casing.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 07 08:58:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 08:58:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266583.460270 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGzqS-0000Gm-Vj; Mon, 07 Feb 2022 08:58:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266583.460270; Mon, 07 Feb 2022 08:58:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGzqS-0000Gf-SY; Mon, 07 Feb 2022 08:58:00 +0000
Received: by outflank-mailman (input) for mailman id 266583;
 Mon, 07 Feb 2022 08:58:00 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=owYM=SW=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nGzqS-0000GZ-3v
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 08:58:00 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0bf63413-87f4-11ec-8eb8-a37418f5ba1a;
 Mon, 07 Feb 2022 09:57:58 +0100 (CET)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2053.outbound.protection.outlook.com [104.47.6.53]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-31-vGB2GFO-P3ySKGDXTGJK_Q-1; Mon, 07 Feb 2022 09:57:57 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DB7PR04MB5483.eurprd04.prod.outlook.com (2603:10a6:10:86::16) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Mon, 7 Feb
 2022 08:57:55 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.018; Mon, 7 Feb 2022
 08:57:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0bf63413-87f4-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644224278;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=9ZYDkpSFsIdm1YfqalckYcs9mzKa546JvAv4YG5D2G4=;
	b=CkL3sfTTfX1Vf8LQQxfK9JRS7VYs/Gd4xTQRNIVqgHyW+SL3aoNANZxFeiuc3P1O9t/F8r
	YoVNukG06Y8/YSCZFjmgHR6xKJP8JmYKGJu82CRr37BYvnK9c2tWjM/wCAKgDAqaF/shRm
	wwl3uu3FqEDK6aIjP+g2WZ5dWk6Lslw=
X-MC-Unique: vGB2GFO-P3ySKGDXTGJK_Q-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=aJzIWNqbOHCHQ/PEPwqC3BxxTuG3/o0D4l0QiqoPWpw26zVGTy9LLv7ItZOFjIlKJLqSIaC7GUNeFiR92nMle68ozTP7mGq1CbPhKjNgHZVRoa6ERNEXuZddCYIZ3exmvHPrAX2EUIvwtTHiA7LAOGpsIlwqjVCuG/IOiYS9pckZ62ktSn6uhtPz7+2OSKK2jI5tpH7qyh2wPjWLtxxk8B8vDEiBkcZK0b8NV5P/aXhdY8AiisnYsgcL+Ac6uvKwQI+r1cT8s7drOUprnFJWLM/KsILBOxdUqAgG63YcD/24UMUNJ+yLm6n1plVGRO2NpzJ3LU8khC+bp/Tw7RI7Vw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=9ZYDkpSFsIdm1YfqalckYcs9mzKa546JvAv4YG5D2G4=;
 b=LFP3zttaktWzBwAeDOFwHk4ln1Od0m3FIZ1HYrZZJK+P9r7mQG2vmXzCwoDa9s6ojxGGNf/JlMhLU/VcGSFGJcSBnuEG7HYtvvX4fHKuWQvG0nVAS+S0sijlzyL3YQyNJGt4Xu3Djkh0ED1tHrQBIKxrgovCgwoniPROAsy6Y9LQj7PLYM/MeH6duhCJ7OrXRq/8Pw0q3REoTkT7uY4Ry4gzZLNtjDIXXdMedS8Hh/PMinc6ElP8FBHXZzq6ECJP4tVBcUEEtJV4APeoPfpOe61TD0yC5GK8U81wfHwr8qwhhqeTTe+KHkEefVdQX9mxKwnqD0fMHpeHN+RPGKYwDA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <4da70949-7d6c-65a4-662a-301bb7075bc0@suse.com>
Date: Mon, 7 Feb 2022 09:57:55 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH RFC 3/3] xen: Introduce a platform sub-op to retrieve the
 VGA information
Content-Language: en-US
To: Julien Grall <julien@xen.org>
Cc: ehem+xen@m5p.com, Julien Grall <jgrall@amazon.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>
References: <20220206192839.75711-1-julien@xen.org>
 <20220206192839.75711-4-julien@xen.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220206192839.75711-4-julien@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0701CA0053.eurprd07.prod.outlook.com
 (2603:10a6:203:2::15) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: df58d11e-b294-4427-2e5a-08d9ea17ee01
X-MS-TrafficTypeDiagnostic: DB7PR04MB5483:EE_
X-Microsoft-Antispam-PRVS:
	<DB7PR04MB5483323BAAAF2BC5039F9BAEB32C9@DB7PR04MB5483.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	C91hv5wqNOaSfnPesFBaqccxB0DeOYnoovO8qlE6LcbSOrisPEltZkpuWmF3kEviIVz5hHGnptX9mnra2vQSYYJXsPaTzLafoA4ZfVfGhREQHm6ST2HbOlZhxTJg2UV3zFBtw0fbr/n52tvTbp55jYCJrl7qEqfPiY71PZBuJISrIir4otDL9sDBMONlGB34AG6m+IDmX/VFUm3Nu+3Wat+i5LV9hZkgXu6kMvkLM/ql4v6xFMUZsinf/RULkdwtTG8jXyj3aGju8TcEjOi19Yb0Xw5l4A9t9ACS/tw/gZVaCl30a7W1MuQCx02haoHKc/hSHNTLL4/OfFiYwo9SWe6FEhQ1d6HMdY241tuGKjwyqsQKelRUDzIkldA8TWJAT2QO1npgEo8O9cWet3aYMfjIF2/TaW+IYwa6fHyvEp12klMUi+LUcz7fJjFRquMB+ZqLiAzQMy0VsVZ8P6CWpq6PVzMinOEH0U+aoGCVfhk5N6qh6w0kfrF7OaJBwpVEJBZW/UOcpgLAT1E4wGBVRSne4AQhAZStStVSD40gvNjWbzFyhRyAVvJwMaxiV5EuCxwlNXZkSPj09uCDSYkVVJYIE8HLK2LSQJHT3AXOvyF6qjSBbbMuJYIGMfnknRv62hO8u20RmOkL9k8fL+xzY849sc/zRA7+HQrRyoQhYutsBpp8aQ0p1UqBYh4cXQpFy0xQQah/HnmQqsjBso+/vnvrVIVv2xCjjAKhKsivO0o=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6506007)(2616005)(2906002)(316002)(31696002)(36756003)(31686004)(5660300002)(7416002)(38100700002)(53546011)(86362001)(66946007)(508600001)(4326008)(8676002)(8936002)(66476007)(66556008)(6486002)(186003)(26005)(6916009)(54906003)(6512007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UUVPSTE1TnJDeUFrNTA0RzdIZXAwR1ZuSTVqQ0VSYysyRWpKTnd0WkJxWjFp?=
 =?utf-8?B?WG5yMU9aL3FheklrN0ZWb2hJM0ExNDNkeGdTTnhKQnJIT29GaGVqWUhLMmd1?=
 =?utf-8?B?K1R6U3FpWkdWQ0lKWFZ1RWxLYzNqV3ZEdjlsVTlFbjQ0V3pnNDFzQ0pNYlhl?=
 =?utf-8?B?UXMvem1iTXhOMy9RSnFBNEdpRHFPbndNbVdFdHVYNnZibk5UVTJaNEdLckRi?=
 =?utf-8?B?cmRnL2NjM1NQRUlFRlFZOEc5NnBTajFuYXI2U29RdENHWDR3ZUttdzQrWlF4?=
 =?utf-8?B?OEk2azFncWVkZVgvVjM3dGJZdTdJeWFBd2N4d0VTUVByNzl0ZnB5VC9Tb3BS?=
 =?utf-8?B?ZVpqSzMwSzhsbUdhcC9GTHRvcE9kU0xmY2xHNjNBUlgvQ3RwVkNmTHEyckVF?=
 =?utf-8?B?VkJTY3kzT0taOE1LcUI3dWUvaG1adkxka3l4Qmw0SFYyakhBUTJuNU4rdGhr?=
 =?utf-8?B?NGhscERvWnpMcTJMRm8wNXF4T1dJa25ZNFlMc3dmcXo4M2kwNjJYVEdTdTNu?=
 =?utf-8?B?TkVJS3ZYcjZPaWlUc3Z6d1IvQi9KTGx5YkZyZm9LZ1VCM1JDZUJ3TCtNNENk?=
 =?utf-8?B?QXU5dTQ0ejBnOFdJMzhaMlhFK1M2YVpVb1JNMVFHUGt1R0t0b2RYSk9rSExu?=
 =?utf-8?B?VTM4KzVhdFIrSEt5TTZXQkRJdjVmNkFVMVJKbFBHckMxcENTVXZFK3RoRzYz?=
 =?utf-8?B?RnE3VnluRk5lU1J3NDFnVnk1TEtSSzBObE9oT05Vblg4cWZ3UVl6Z290TldG?=
 =?utf-8?B?cDZOc29xbE1TVThiZExoRHlpbmIvTVNBdTV3U2tvUVVxSXB4L21hekV2S1RH?=
 =?utf-8?B?Qk9jN1JTdk1ZYzNDcHhEbmZIQ2xEOHJqYnVES200Zi9PTi9nWnoxNWFXY2o1?=
 =?utf-8?B?QmxyYVZqaVQ2a0NRQkhHSFNZN3U3bDlSY2w0UVNLRTNTMkJtTHYwMU1nSE9k?=
 =?utf-8?B?K0o4VG4yS0kyWG9tOHp2ZExOL1M3aENQdjArS1VXNnlKT0lBbm10c1dPQjVv?=
 =?utf-8?B?QXRTajdMUnBLSG0xRkoxODBUQ1IwMkp6dlAzNThpc2dCOTU1a1Vqbm5kRm9C?=
 =?utf-8?B?ZStXOEpGSjYvczBtRG1CQjJYcDRqUTZzSlNEYkpHVmZSNmNxTjl0cmpQbC9K?=
 =?utf-8?B?OXhQYkFoOU5yWlFPcHk5QTVtK25wUE5WVUZyNlorOEc5c2U5UjdTZ1lKcFU3?=
 =?utf-8?B?YlFiL2M3V1lzQysycDNZRlhVdWR6akpWcGVrSGVpMTBVaHM2cVNaZjVjNDdS?=
 =?utf-8?B?RmsvYWoyTUtEaUVFa2RNQlQ2Tyt2dm5MWCtEdGlQdDBHUll0anlhaEJmQlB3?=
 =?utf-8?B?N3NNRWttR1JqYjlpNGRZbjdJam9HckdmL0t4WmtGOTlhSjJINlBabmhzek1X?=
 =?utf-8?B?TkV0TnNSbU80TDZoMy96UExndW8zeGtqNTkwSjNMTVNWSUV1eCs3QWN0V05N?=
 =?utf-8?B?QmQ1QWJ4djM3SVBwOGxMQTFPb1dPdzluanRac0p3d1ZhblVhaDBDQ2s4bDU1?=
 =?utf-8?B?aUtwOXlzL2NnN1lhT3dTZ05wQ1d4TC84dmg2Wkg2eEg3dXJWRmJzQ1J2YkRt?=
 =?utf-8?B?bDIyMDJ6b1BSY2tNR1dPWkdJc2QwOEFPdE1UR3drMHVlbmlsdG96UXVXcFF2?=
 =?utf-8?B?NGNPUzEwbXRFVkZlMlFqN1Zkb3IvV1MwZUhhaWVoMnlzNW9IUzFJZ1hQNVVP?=
 =?utf-8?B?ZHJrYVJ5Qmx3ZUoxZ0dkcUZRWGRrdjRjUzM2RkxVTThYVmhMR3FhdFlVemFl?=
 =?utf-8?B?di84UTVYQTZiQmEwanJ5Z1Z5dStXdEMwSXFlY3B1dlEvZENVQlVBWVVoKzVk?=
 =?utf-8?B?QTNRa1hEdmJrMTRvekVZUWlsUW9wR2UxalBPU09zQkFMNzJwVVFIdmU4NE5R?=
 =?utf-8?B?NFhzdWFoTWU1ZTVZN01YK2ZrampZVDQ1ZWVHYTI5b3Z3QTc3RHhyRUEzYXUv?=
 =?utf-8?B?eVRESnpjZXYwZ2xRcm5PS3ZldUxtQUp4QmxDNlpFSXVlWXo1WWorZWhDN1ZM?=
 =?utf-8?B?cVJIeGNYcklNaFNPNHd5M3NhYW9VZHpIVlJkYkRGMExScDdyc0dXbVdlQ2xF?=
 =?utf-8?B?Ty9IZGpjWXlXNWtWVDRaazcrV0oxbXdsZitTNEpxMkduQ1lFOVJ3ck13bzlr?=
 =?utf-8?B?REo3MXU0aDROVTJ6NFE3d1g2bUd5ZFRRRGIrM3hPQ3gxUStvemRXWmdSZExW?=
 =?utf-8?Q?pMf2EIwYkD/zuiH2Jj9tytI=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: df58d11e-b294-4427-2e5a-08d9ea17ee01
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2022 08:57:54.9712
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EKBjrhWtLMuft2o9t5cfIeJxf1Xd6QVi02lUVzpRbmbi8iL7Z/IDE/dpLgHe9zCG490XF0DAEACLWrJoRfDWeQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB5483

On 06.02.2022 20:28, Julien Grall wrote:
> From: Julien Grall <jgrall@amazon.com>
> 
> When using EFI, the VGA information is fetched using the EFI
> boot services. However, Xen will have exited the boot services.
> Therefore, we need to find a different way to pass the information
> to dom0.
> 
> For PV dom0, they are part of the start_info. But this is not
> something that exists on Arm. So the best way would to be to
> use a hypercall.
> 
> For now the structure layout is based on dom0_vga_console_info
> for convenience. I am open on another proposal.
> 
> Signed-off-by: Julien Grall <jgrall@amazon.com>

Cc-ing Roger as this may want using for PVH Dom0 also on x86; my
first attempt to propagate this information was rejected.

> --- a/xen/include/public/platform.h
> +++ b/xen/include/public/platform.h
> @@ -244,6 +244,7 @@ DEFINE_XEN_GUEST_HANDLE(xenpf_efi_runtime_call_t);
>  #define  XEN_FW_EFI_PCI_ROM        5
>  #define  XEN_FW_EFI_APPLE_PROPERTIES 6
>  #define XEN_FW_KBD_SHIFT_FLAGS    5
> +#define XEN_FW_VGA_INFO           6

Perhaps s/VGA/VIDEO/, despite ...

>  struct xenpf_firmware_info {
>      /* IN variables. */
>      uint32_t type;
> @@ -311,6 +312,7 @@ struct xenpf_firmware_info {
>  
>          /* Int16, Fn02: Get keyboard shift flags. */
>          uint8_t kbd_shift_flags; /* XEN_FW_KBD_SHIFT_FLAGS */
> +        struct dom0_vga_console_info vga;

... the structure name including "vga" (but if the #define is adjusted,
the field name would want to become "video" as well).

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 07 09:03:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 09:03:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266594.460281 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGzw5-0001m8-P6; Mon, 07 Feb 2022 09:03:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266594.460281; Mon, 07 Feb 2022 09:03:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nGzw5-0001m1-LA; Mon, 07 Feb 2022 09:03:49 +0000
Received: by outflank-mailman (input) for mailman id 266594;
 Mon, 07 Feb 2022 09:03:48 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=ddl1=SW=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nGzw4-0001lr-N2
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 09:03:48 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id dbd730f0-87f4-11ec-8eb8-a37418f5ba1a;
 Mon, 07 Feb 2022 10:03:47 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 4561F1F37E;
 Mon,  7 Feb 2022 09:03:47 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id F00D013ABC;
 Mon,  7 Feb 2022 09:03:46 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id AkC0OHLgAGJfDwAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 07 Feb 2022 09:03:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dbd730f0-87f4-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1644224627; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=UcpeWOmsslIWOUxmtpmxHMbNhY2YhRusOGrMBtg2BVw=;
	b=vI1OEdxseCVGf9E5dOuf9woMveJ3p6oHriT6OWvBZxjzaLpYg+BDYW2pmQP4E7sAg907Jp
	RNhvWe10d+NaNXwZmYdL2AwhnMJ9quidCS+NdAasKG683C+XjzRUV9Nqguy4MAYuwyqQZT
	Pg1XuNe41d3npRINuV27dDinvKPa1zc=
Message-ID: <af1d3964-74fb-3a34-b154-3983773cc2da@suse.com>
Date: Mon, 7 Feb 2022 10:03:46 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Subject: Re: [PATCH 2/2] xen/x86: detect support for extended destination ID
Content-Language: en-US
To: Roger Pau Monne <roger.pau@citrix.com>, linux-kernel@vger.kernel.org
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,
 x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
 xen-devel@lists.xenproject.org
References: <20220120152527.7524-1-roger.pau@citrix.com>
 <20220120152527.7524-3-roger.pau@citrix.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <20220120152527.7524-3-roger.pau@citrix.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------0N6qyxuCrT1Ax3yh1HeUf4I3"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------0N6qyxuCrT1Ax3yh1HeUf4I3
Content-Type: multipart/mixed; boundary="------------m3T60W0vRyw6N6WViKUASGUG";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Roger Pau Monne <roger.pau@citrix.com>, linux-kernel@vger.kernel.org
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,
 x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
 xen-devel@lists.xenproject.org
Message-ID: <af1d3964-74fb-3a34-b154-3983773cc2da@suse.com>
Subject: Re: [PATCH 2/2] xen/x86: detect support for extended destination ID
References: <20220120152527.7524-1-roger.pau@citrix.com>
 <20220120152527.7524-3-roger.pau@citrix.com>
In-Reply-To: <20220120152527.7524-3-roger.pau@citrix.com>

--------------m3T60W0vRyw6N6WViKUASGUG
Content-Type: multipart/mixed; boundary="------------LCUIzEqLifaexRxzRb20UrU9"

--------------LCUIzEqLifaexRxzRb20UrU9
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMjAuMDEuMjIgMTY6MjUsIFJvZ2VyIFBhdSBNb25uZSB3cm90ZToNCj4gWGVuIGFsbG93
cyB0aGUgdXNhZ2Ugb2Ygc29tZSBwcmV2aW91c2x5IHJlc2VydmVkIGJpdHMgaW4gdGhlIElP
LUFQSUMNCj4gUlRFIGFuZCB0aGUgTVNJIGFkZHJlc3MgZmllbGRzIGluIG9yZGVyIHRvIHN0
b3JlIGhpZ2ggYml0cyBmb3IgdGhlDQo+IHRhcmdldCBBUElDIElELiBTdWNoIGZlYXR1cmUg
aXMgYWxyZWFkeSBpbXBsZW1lbnRlZCBieSBRRU1VL0tWTSBhbmQNCj4gSHlwZXJWLCBzbyBp
biBvcmRlciB0byBlbmFibGUgaXQganVzdCBhZGQgdGhlIGhhbmRsZXIgdGhhdCBjaGVja3Mg
Zm9yDQo+IGl0J3MgcHJlc2VuY2UuDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBSb2dlciBQYXUg
TW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT4NCg0KUmV2aWV3ZWQtYnk6IEp1ZXJnZW4g
R3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4NCg0KDQpKdWVyZ2VuDQo=
--------------LCUIzEqLifaexRxzRb20UrU9
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------LCUIzEqLifaexRxzRb20UrU9--

--------------m3T60W0vRyw6N6WViKUASGUG--

--------------0N6qyxuCrT1Ax3yh1HeUf4I3
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmIA4HIFAwAAAAAACgkQsN6d1ii/Ey+1
sQf7B+e9vs576KwlvQfr+qAHnKdRcUb1b+5BbgYqUaOB4jiJf5UHIrRPmHOXFta/2SfKF8c2e43T
bN2vgYrxZofXAZ2dqb1aWmb2omJmeZIqiMApiVY4JsBG560BTfQKywf0Uf7Byb1oqjB/3nV2yagO
URDv+hXr3KBqe9wuRX2eDL2G8OuUtmhneHrsXJbwiMXEup1isT34CZ/9uPA7zxp8I0eZQHIE9XAW
D2ubKdamCGjOLmy/RU1EAkyXNPACvHRFEcIUAkSM2plqPpNwk495Ajb0psObihy/hs3ycTeA4sCA
uBYguu1qGLdQF/qBiAudEKuwOxXjoV6cPNvU5uguTQ==
=5hD0
-----END PGP SIGNATURE-----

--------------0N6qyxuCrT1Ax3yh1HeUf4I3--


From xen-devel-bounces@lists.xenproject.org Mon Feb 07 09:20:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 09:20:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266603.460292 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH0CL-00044u-6z; Mon, 07 Feb 2022 09:20:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266603.460292; Mon, 07 Feb 2022 09:20:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH0CL-00044n-3d; Mon, 07 Feb 2022 09:20:37 +0000
Received: by outflank-mailman (input) for mailman id 266603;
 Mon, 07 Feb 2022 09:20:35 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=owYM=SW=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nH0CJ-00044h-Op
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 09:20:35 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 3400838a-87f7-11ec-8eb8-a37418f5ba1a;
 Mon, 07 Feb 2022 10:20:34 +0100 (CET)
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2058.outbound.protection.outlook.com [104.47.1.58]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-17--5yqlGBnMNOmLppktJ3P7Q-1; Mon, 07 Feb 2022 10:20:32 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by HE1PR0402MB3612.eurprd04.prod.outlook.com (2603:10a6:7:7f::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Mon, 7 Feb
 2022 09:20:31 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.018; Mon, 7 Feb 2022
 09:20:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3400838a-87f7-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644225634;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=NWVIcuAI03ir6QzaPqtvoKoNBC94D5lPp1xYNb/0onk=;
	b=gKnY24edqyXQSppBQSTvDfb+uKB5hbxy4Kh6R1KNPLEXjexq0GGbpYj6N1sVp6z+rc9O5j
	AkgfnVJeFYOruJFg859ztQDdSAFVD6BP3nUIVIpuZH1YQttG/EAoXXqp9Py/9Ag8exUL7H
	cid1i7x76YUc+fSAC0lGITkwjnqymoQ=
X-MC-Unique: -5yqlGBnMNOmLppktJ3P7Q-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=iMIkYtAS2IMwZRXFvkB0fs39kZA6AwZSIbN1RGuB5yO4/MkV7sz4v2diXYQuYjlMRgRRtUewAnabW7FIlt5azQzRM3T4TEptnZ9/Hn1cb8+aG20jSp7k6LOGg7JR4G3pO0DUFoVI9HxJABzpwkWhMqh7nlfqKbko0oTF0ATWbjA+KBvp3cgqXdgCNegDgbNgxelz8WlUs5uy62DnQA7Gp/qIRWEwVxp1kJuOqbvb6ZXCZj+a5/qqvNNfI28WJC+kLpqDrInTmixgT1XDw+Js2snZzxOI1bUt3w7pu5EPdxhesbd2BgMpDzq5CqMlyyorJUPQfR7ga010P8WsUutAoQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=NWVIcuAI03ir6QzaPqtvoKoNBC94D5lPp1xYNb/0onk=;
 b=mUM/XoffOR4gLUEBn9snH9yDiSjJA1vIvZr7WVbrD84f0DJ6rKbpCK39A2XTJ7URwBGB73ZuccM7HX9ujXWfix25Oiq9H2ji1URyhHPhwF5b4vcQ9fFkBVRcqNAbREPo0u0wPLBoiYaoii3nz///uQ2GYpGrlCqCAZSG7iPMcQ4oUvVDLLflCtjZhewPdjfFq5GHz1oXL8LqnGjoepx8d9oD6tfu6XRHGoNsJAfjtsbfFT/T31QJYOLg9Gpcq8iXbJ5ZKrvisPUISzJnGC3CF4TADJoE1qK9dftZWHegwFtgnluyeIm+/v0PbEvBKWKMucCx60SbHfkmKQYVmny8nw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <49e85771-b20b-6aa8-4afd-562c6fb202b5@suse.com>
Date: Mon, 7 Feb 2022 10:20:32 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH 01/16] x86/P2M: rename p2m_remove_page()
Content-Language: en-US
To: George Dunlap <dunlapg@umich.edu>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>
References: <d1fd572d-5bfe-21d8-3b50-d9b0646ce2f0@suse.com>
 <fc340862-6842-3db4-1093-d2df44c1aa9c@suse.com>
 <CAFLBxZa3qZ0+1MHxULZCciFPyYppv12TTe=LjcEyJAEr-KJRsg@mail.gmail.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <CAFLBxZa3qZ0+1MHxULZCciFPyYppv12TTe=LjcEyJAEr-KJRsg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR04CA0094.eurprd04.prod.outlook.com
 (2603:10a6:20b:50e::23) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d4d8abd7-f9a0-4e0a-f50d-08d9ea1b1665
X-MS-TrafficTypeDiagnostic: HE1PR0402MB3612:EE_
X-Microsoft-Antispam-PRVS:
	<HE1PR0402MB3612934BD8356792B8EA62EDB32C9@HE1PR0402MB3612.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	RnOrMGOYl0SLGzHqZkNO1UiSrDLXHpL4PCGvXQB5W7DpHvXH70tZKeDJVj/RuJm5MZ+hBPeLauvxYvx5pZ7B3jKJ2XcWyNWdcsBjYZrAS2o00lCl+Ujn8gm1Nm91DFjQiweA+YS5iZ8dGPpcbY7Eg6k6RYDLyXEW110GRrSfdpnSPNUif2oiUtOjXNkTYTbJ4K43W9J75529DQXGeOOG9YHNQyYqIKDHrGsdLwFYz2gZI3uL8jMjcvO/QMjatzbyEmzqCJREUzbO4H6m11hRBpuGFotOBfdZdreSP9IcB70/igoHJQ03U2AHAjVI8HRnRIz26qrO3vmdko/j6bnkN4ZPr4IVVFdEsyRsfHfg5cSj8T6JYMXJH6gHu7EJ/EaXvIdGuen5G65EAR7cN3N3SYW8At0YlCPmdH9B5WCtJ6GQQ0TBy+Tgz7Ghtst43AD23YbgHhG9IY08cUZ856Ajddg9tZASM44f/GbCTZyonV7oenZ5L+5mfas1tyhf3FrmhGU5GnKRh4OP4oAaqt+UVb95LMCSKdg+b5NAMUrljAT5puCBz83kVvvG9qSAVVsqPYWcwxXFSG5CnXuTL2+Wj/iDWDOCbN3zn/udoMvVgcXMTG9qqQdKcno0LQhNef7vms2xHleYkUC9AZmsK9jA3Mw+KqcH9lBWyQiF72Euiy5ADSXlVX+mFXg+dGxTgp9vwit+VrR/tWpYbuc5q+LDiQj6HFWzNcCXcLsDcHJ43WE=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(36756003)(6486002)(86362001)(31696002)(2906002)(54906003)(316002)(6916009)(508600001)(5660300002)(6512007)(186003)(26005)(2616005)(83380400001)(31686004)(4326008)(66946007)(38100700002)(8676002)(66476007)(66556008)(53546011)(8936002)(6506007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dExBNXhObDg3K2lYWE90SXE4YStHTStUZW9odnRZM3k3elh6NS9Fcnhvb3NE?=
 =?utf-8?B?L1ZXUzIzWFlBeXJ1d0lHU0ZWeVZmWXlBZXpkdFZKY1lpTzJISWY3TzdnL0tl?=
 =?utf-8?B?SlNPQlMxbnNOTVNnaUVjSEM2UGhEQm53RFlBMktYUVp3VlJsb0Iva0ZpWVAx?=
 =?utf-8?B?SXAvdXp4bjlGWkl4TWpRWTlhQUtEZnF2WDh2VGcrVHZITjd4ejRaRTI3Tkxx?=
 =?utf-8?B?TjU2ZGxyT2ZETWgxaWdVZVdHNGNtSXlJd0lkNmdEZGNCaUhpWk9VNFEwckdx?=
 =?utf-8?B?eGJiOWNSdGxFQjBSTHFyaUhFQmRSUXIvd0sva3FwWFlxTmlYcEh2eVRkUUdt?=
 =?utf-8?B?aE9NVFdkLzJ4TXNqeDdRUnhzaEhTNERVQ1MzRnZGS1RWMm5QbTFPMDk5bWpt?=
 =?utf-8?B?SSs2YkhUOUR6RTA3endRM0ExYXdrZHRwRTNHK1Yzbmt1T2k4cjFUejBOWGk2?=
 =?utf-8?B?YnBkMUtBNEpNeTNOVkpSRmhSc0RRK3M1aXNXcU1RcnpZM3ZRR0QzTlRyN0tn?=
 =?utf-8?B?K0FaVjRYVHZvT1dncmZkS2NWdUZxalZqYmJMNytJczNLWVJ5cWdKSzg3cVFZ?=
 =?utf-8?B?VDdNYzJXSHlIelJjRjZRQnU3ZG45OGxOMVZEU3JlWTZCbW1VNnZHSEVyT1RF?=
 =?utf-8?B?aVc0YnM4ZEs2UGUvajRINS9NVjA0QnUzSkR5THpVbi82RlNhYXUrMkp0RTA0?=
 =?utf-8?B?bFZUZmlQRTV1aFdVZ3FkYjUxbVU1amtyK0xzV1IwSDJsYVFtTnBIR0VCWTBT?=
 =?utf-8?B?TC9YTzYwOGRvK2RQMGJ0a3NaQUZmS1g1enJkU1Z1TTY5SHI1QjU0R1o4dEpG?=
 =?utf-8?B?a1NpTXpjdnZ2V0dZVW9XazljODhtdjhjclRWOUFkOWg1WFhkNHd3NWVsWjN0?=
 =?utf-8?B?b2Y0VEh0Q1JiVXNyZ1B1V1pyUkJBYzNZVFJMN2tLeUxaOUV4anJLM3p3UHA5?=
 =?utf-8?B?RGpSN0lRQU1sSjg2aENEajRWaVNkNlhXUW03R1ZPck9nZXF6a2g2OENQRnVz?=
 =?utf-8?B?d0NmQ0JsZjJlNTlDYmg5TjAwRXRabWRKd2RDdlhEbmxhUDkyYS9OQzNqM2kx?=
 =?utf-8?B?dmNXbVFqaEh0cEQ1UnpvQmFUbGYyc0hjWklQRW9kL05kTVJCT1hXUkRNNGcv?=
 =?utf-8?B?dDZOeG9ESzdFbDVjSXFjNjhEYUZybUtWV3loWDhIR2dQdXBWaHBsejYwSTV2?=
 =?utf-8?B?b0VrOXNwZmJzNUxFbzlvUkc0a2tEcGg1SSt3WXlJQXRkeU41bHpOQWozZ0Ez?=
 =?utf-8?B?Rjh3VUxpaVExaEpVTnpBTmJuM2wrTTBjRnlmVUI4djhXNk4zbkVSdG5leWVo?=
 =?utf-8?B?UUo4Qmw5d2tWNGxWMDgrNkZiSFFZZ1Z3eWRHOGN5bmo2VEdUR01paVRqNTA3?=
 =?utf-8?B?dEc3K0JwdVY2R0d6dG5ucXdUY3JSYWFiR3hiVFJCMDhwcEw2dHJNbmEvb1VW?=
 =?utf-8?B?MEtEUDFVM3dqbjNUMUZWR2JwcVBaMy9GRjRVOWJpZ2ZIcTBSeUwvWlJQL2Jp?=
 =?utf-8?B?amFQWThLd2JiRXdva0RUVHhhK2JZeXhCVWdzdk5tdHhsSDNwQlNlaXZ3WTR3?=
 =?utf-8?B?OEtyZ0U0ZTFud2dUV3hYVE92SXB0VGFCZHlUdGNCNEpyeEZERDVTQjhOanM4?=
 =?utf-8?B?TkxGRHd1azdwcnJvZ1Y0Skhaamd1MFIvbmhxa3JFKzdMbVB0VGRBSW84QXFX?=
 =?utf-8?B?MmgzRENVNDJYQzQwKzB0KzdtSGdXWHdSa00wS21HVVdwODZxZ3JTS09YcU4x?=
 =?utf-8?B?MUhaR3Z4dFhUQVJpdEZBQzdsU0FWem83dlBzM3VHRkZKSFJyR2ZpUXIzSEhi?=
 =?utf-8?B?aHhjbzlnaDhRQlUrdnBod2RYTmdiRlhsdFRrbEhjU1dNTk5wUVJFbjN0clY5?=
 =?utf-8?B?Y01jZ1oyTnBLRVgrejM1YkVwWEIyY1pTT3BycWtKYnZoaWF3QjBCMFVRLzFh?=
 =?utf-8?B?RkRUSGJPWm9tTVdKbWhZNlQvdUlKZ0VUcHpCR3cyR2ZHaHh0ekRmVldqWDhD?=
 =?utf-8?B?Y2FMbG1xU3hSV3NDanNQZkl5Q2FGdGJjOVQ3OGNnWGJqNVY1dVFaaEJON0Y0?=
 =?utf-8?B?bld3akhxaVlDQVB5aERRQXd3WG9PdGVKRnFHVkNPR0dLZjdUM1UvQmhNOS9u?=
 =?utf-8?B?U1FBNmYxMFE5Ui9KSE5rUFh4YmlaNG1Td2puMGJ5ZjVzcVdJOS9rQmJiWlVH?=
 =?utf-8?Q?9W7ffct/EIB7B+LLqvWxa2M=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d4d8abd7-f9a0-4e0a-f50d-08d9ea1b1665
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2022 09:20:31.2620
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YgGgt19aDJy0ZMwJxtLo9b6rDbdhlZTy6Qyy9kYcodErW1Nwk7q4/2oShOG1AtzKf/iDUyHuO+fsYVyMiiTJDQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0402MB3612

On 04.02.2022 22:54, George Dunlap wrote:
> On Mon, Jul 5, 2021 at 5:05 PM Jan Beulich <jbeulich@suse.com> wrote:
> --- a/xen/arch/x86/mm/p2m.c
>> +++ b/xen/arch/x86/mm/p2m.c
>> @@ -788,8 +788,8 @@ void p2m_final_teardown(struct domain *d
>>  #ifdef CONFIG_HVM
>>
>>  static int __must_check
>> -p2m_remove_page(struct p2m_domain *p2m, gfn_t gfn, mfn_t mfn,
>> -                unsigned int page_order)
>> +p2m_remove_entry(struct p2m_domain *p2m, gfn_t gfn, mfn_t mfn,
>> +                 unsigned int page_order)
>>
> 
> One question that's naturally raised for both this and the following patch
> is, what is the new naming "scheme" for these renamed functions, and how do
> they relate to the old scheme?
> 
> Overall it seems like the intention is that "guest_physmap_..." can be
> called on a domain which may be PV or HVM, while "p2m_..." should only be
> called on HVM domains.

Yes. I think by the end of the series all p2m_...() named functions
pertain to HVM domains only.

> There's also "..._entry" vs "..._page".  Is the p2m_remove_page /
> p2m_remove_entry distinction have a meaning, and is it the same meaning as
> guest_physmap_add_page / guest_physmap_add_entry?

In the next patch a pair p2m_{add,remove}_page() is introduced.
p2m_remove_entry() remains a static helper for the latter of the two,
assuming the GFN is already locked. I've used the "page" vs "entry" in
the names just like it was used prior to patch 2; I'd be happy to take
suggestions on what else could be used in place of "entry" (but I'd
like to stick to "page").

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 07 09:38:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 09:38:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266612.460303 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH0Tf-0005eA-OU; Mon, 07 Feb 2022 09:38:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266612.460303; Mon, 07 Feb 2022 09:38:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH0Tf-0005e3-L8; Mon, 07 Feb 2022 09:38:31 +0000
Received: by outflank-mailman (input) for mailman id 266612;
 Mon, 07 Feb 2022 09:38:31 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=owYM=SW=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nH0Tf-0005du-09
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 09:38:31 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b4df92fe-87f9-11ec-8f75-fffcc8bd4f1a;
 Mon, 07 Feb 2022 10:38:29 +0100 (CET)
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur03lp2051.outbound.protection.outlook.com [104.47.10.51]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-14-bZBLMa94OvWTZzCYsb01Aw-1; Mon, 07 Feb 2022 10:38:28 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DB6PR0401MB2469.eurprd04.prod.outlook.com (2603:10a6:4:34::7) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Mon, 7 Feb
 2022 09:38:26 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.018; Mon, 7 Feb 2022
 09:38:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b4df92fe-87f9-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644226709;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=SnC2UznGjDVROvbGU1mF5qH5Fp/581JGnSKukwxZp0U=;
	b=DgUY58LrPd4BrfN1ASARDgnVqXcyEOdXhwdlCCJQSZOpH3eghh91x7VnpxE3dt/xEAyqck
	bIftnLXlGArdpFnqMWBcmjydnpUnoLdiCfO3M9LnFkieEgjxGDn6U4XnNhbAfANSnGKcC+
	5dQwoAIYJvo/YuzkRZ5yOEyvNL8lJiw=
X-MC-Unique: bZBLMa94OvWTZzCYsb01Aw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=LMey19zXuLcnWftzZCtL1aofE9Y6oz4aPyYGvlQMjDeCAKxTZ9DGnyaIojEWEJjAyl58fMZqDwuD7mPOF+rVnG8RwodbS3dPhJc/T3IA1RIOn9gBOOmzJeM6nlv9dZMtYX8FqOOwKe0hNUmo9b72TpPZPaGO2cpovnhhpqpCqyXXZOxb9P+gIeUqQHud25AuNHMGF5onUrHB4iC9sTu8AqSdaZR4I1VwOpu5mfZp+vZ86JUFO54QFaex7lRRHdp/DjtOvdI9fE1dCRcMTI9XnnRK/b8ir9TYsi8O/I+nKDolhOenEEs0HF3mL4XbEHUT91/XwLoIja9s+jRtwf0U8A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=SnC2UznGjDVROvbGU1mF5qH5Fp/581JGnSKukwxZp0U=;
 b=e995fgMt7vlRerm7P1muB9oEwayJSjq+vFrRDLajJulNLL2ekdOebl968EpK8YaIhKJIu32pD7RqBa21/rdUxxrGJCm/+S1s38t0G3EJD3KjyS0QviZSlN6/JyH+sMcmZ0ZRZSNrF+YUyub6jl3ap2fzB3UDCOvSTsVzmnVGNf9tRjVM6fNFElgshrZ9XOL1+yf4bicovnp5hCDXsmm84/xE56WREALZ3k4tDay0sCi4GYVhdFhawTiO3pr2stOIQ3Y1Sxx7HzomQu4HP9LMaNbZAXzU/Re/hHwDmtEgpNvJId0CCJOqwPi33q3mqEiVkj0mjQLdFzUoPZOEGmiWNw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <f986aadb-0eff-0f51-be42-16c31999cb08@suse.com>
Date: Mon, 7 Feb 2022 10:38:24 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH 02/16] x86/P2M: introduce p2m_{add,remove}_page()
Content-Language: en-US
To: George Dunlap <dunlapg@umich.edu>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Paul Durrant <paul@xen.org>, George Dunlap <george.dunlap@citrix.com>
References: <d1fd572d-5bfe-21d8-3b50-d9b0646ce2f0@suse.com>
 <eaf6f63d-1122-f52d-1147-cda40a9c3387@suse.com>
 <CAFLBxZZQgfYZ=OcyhRedPvK0CZxjrHY-5kRp4EOpJ2LEFL09yg@mail.gmail.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <CAFLBxZZQgfYZ=OcyhRedPvK0CZxjrHY-5kRp4EOpJ2LEFL09yg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR0P281CA0044.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:48::7) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 850d59a7-f18d-4182-f7cf-08d9ea1d9716
X-MS-TrafficTypeDiagnostic: DB6PR0401MB2469:EE_
X-Microsoft-Antispam-PRVS:
	<DB6PR0401MB24694CC8962AB2077A9B2929B32C9@DB6PR0401MB2469.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ba3sFaGL24n1Si+WKyRTTMUWJqKG/l/rtwRWiAk5xV1FW26R/g+HysbSDLxHZIGQ94cL26qGLABHnxtTNedJVsu/m++qNf1eNfkvdL+a24+kbyfKRVSz/8wYr8fxq6l1DeY7fX538KL+MNddTaArhOUnA+xhbyT+sglc7YyvY6dOIMdLuqX+XvLmIsHs4zwxd9x8JWjwvZIJdigJlrgNr/7SosyJmJjYBtBnNy8Wr4tVkA7sNt10HVuZE6Ielm6YVoekmF4MRlUb9A8wMllNEpJN8s5cjRV66qa5SC63kIHVkb3KPUOOiD0hiBD9F7P3wrAt9FqlsmIQDA1z99uAKTBsFN8WpGgzlAjN7iyYZOhk0OyJR0JFZ09i5ejPxkzpLnxxA+KpOSFbqNzZeEKSOl6cVqodbXfUTawuqm9p2UUg93v4jBE6qpx9lA6vatErKepfoFpfok8nuiAXxw/F85dR9WJIcB/PkDYTDTgZh8I4pOhiJh1EVeedGs/TyrKpdw+ZPyPj3NUmF+FOK9jONYE95hLOMMuHGcDTudVEXiSwDxQjirnjU1EJCZdSNyQr6MGP0I0PrqDMgzFfhEoR0TPJoYCTB2pxpPEQbPhZU7WbF9a9p9PIuQwVqIsZIAreVHMbzEG8cmHkevkVsvG4RHribydmJExgLGteuiAe0Dyt1V0k7U7a3WFPh8bHYj++X5YXJ3c7pSXyIgoWBzKk+f1QKnja+rSmxPMNI83hbTY=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(36756003)(31686004)(66946007)(4326008)(8936002)(8676002)(38100700002)(83380400001)(6916009)(5660300002)(54906003)(66556008)(66476007)(2616005)(2906002)(6486002)(316002)(508600001)(186003)(26005)(86362001)(31696002)(6506007)(6512007)(53546011)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?YlYxcHN1WEFlcmgzMCtWdTdDb2QrUytLMFl1TTVEUmRyUU5jUHJEcGFtenN1?=
 =?utf-8?B?NStSVFIrTVdMNmZtV1N2dEpCR3I1TktNUW0wTC9WN1lZS25BN2Z5TFRHamNI?=
 =?utf-8?B?VXF0YXRnVzhHdkNnb0ZXTjZQNVNJUXRlMVh1cklTVnpXTFJMdGFHTTlGU0dB?=
 =?utf-8?B?OENmaFBDYjJERU5nV3hoYkxHY0k3ZWsxL0pzUlRoVG5GZVpZS3FTa0d5aVZ6?=
 =?utf-8?B?Y0tCNUZ3cUJrclRjMTdpQmJiZUdPM2NCNTk0N3oxRFhWcnRVaXV2eHpVa0V5?=
 =?utf-8?B?RTRoMFlRL1l4RXp1R2pnSGI1b0pmVGpLTEN2WHZaNnJUWHNVV21ZWmhPSWwx?=
 =?utf-8?B?Q1IzSHR0Q1d3SzZFc0pHVEZ4NjlrcFdqaFdTQ1JlWkhaaklEYnVkNlhVVEV4?=
 =?utf-8?B?enVtRGxkTVM1OTEzWUZlSGlTY2RRRjhNR3pxZ3g0UkVtcW50aVNSYTZaM3cw?=
 =?utf-8?B?a2NKZGNxOHR0SHJVa3JSbVk5aHN5L3IyeXVvbWswb0VQSlRsTVVabWFpcFU3?=
 =?utf-8?B?VWI5M1BaUWpzdkZJWTZrWDIyL2twTnB4TXRnMGVYTTQ2VGNoMkp4TE9mUXV6?=
 =?utf-8?B?ckNTMTU5b0pvdGRMWHFKWkJucWptaVRDcG5aNUFDckl6L3JnUzBPRGNRNm9E?=
 =?utf-8?B?YjJibXJNYU1Uc0oyMjVORFNhZzNpckg2ejVTRzI3TUJPY25HbC9SRnUrSFFx?=
 =?utf-8?B?WmFQYk13ZXplcUNjcEpBYldobGtpNUN5REVyeUxSeFl4elNzRW1keWF5SDFL?=
 =?utf-8?B?RkpRRFpzekJqUEl3N3QyQ2owRVh1dHIrNC9HZ29aVUVEQmNQRjg4L0I1QzZs?=
 =?utf-8?B?MGROcXpOL2ZIRVJYcUQ5MUozZzFsRktGaFY3b29USC9pWjBQKzMxcWt0UTI5?=
 =?utf-8?B?aThXR1p3VDRjb0RRaSsraDM1NGRYRXRRQUxaZ2pzUW9pNGdiYnVycFhDTTdB?=
 =?utf-8?B?NFNyKzYvaUs5QmY0QitMRFBPRjVVZHBPQUhncjVGVVphZ2J4TUdzYVg0TXFQ?=
 =?utf-8?B?SFI5bTdRWjlvbFFNUWpsVmJnQ2l5cURBV1g4SGZneG4xMGYwSHZjTk9uZjJm?=
 =?utf-8?B?L2N6cUcvMEVueXQvbEl4UzQvVGsxRldNYmdkMWZ4L1Q5YWtSNGlZSlZpTkJZ?=
 =?utf-8?B?Y2ZVMnpYQitITzJMQTBDZkxqQ3huNytuMmFzRzg5NjNwZkNuY2FvMnhUUzNi?=
 =?utf-8?B?bWNBbitTV0lzdUVjTkkxN1VCL2UycXRKMFJObjA0bm45VkhBWTh1QnlpRDFi?=
 =?utf-8?B?TDR0dVg5MEtKM2JJL3dwVUhMV0tHMEZ1b2x6b0pzemlHemloa3llSkNrdzBq?=
 =?utf-8?B?S2ZtTW1aUVdrd1FUY2hMbUhwNjd6OWluSFVXNmZpWUJ3akNvOVdoc29kcXp2?=
 =?utf-8?B?TjY4RkxOSXdGRUcwdk1uZ2xZMlFRUUt0L2JVc3hIMjQ2SHhPNi96d3ZNK3Bs?=
 =?utf-8?B?S1lnZXdseWVwWDEwYnQ5R2V1VUM5dnA2TU1zeVUyS0pTSXBwYTJSVkZuQXA1?=
 =?utf-8?B?Mk5PU3R1MEpxd2Y3c1cyVjhSVEN1bDRoNTRoUGp6azRTcXJpUUFxaDBMYVRt?=
 =?utf-8?B?TG5oamcyd1BXNm5OUXAzWXU2UjF5cERHNGRpazRGalhUNTdpZU1WejZLYmEx?=
 =?utf-8?B?MTJNWU1paGUvcDQxbWM4QnFpbmZYVVZ5VzhuaU40Yjk2MUMyQXoxS2dYWVBU?=
 =?utf-8?B?amVKOGhWZkkzRVp1ekIwRE9NQ3hLYmlHbUROM2dNNGdkOVBSa3krMEhFdG9n?=
 =?utf-8?B?cFFtMzdZR3pXUUFsbUFGZ1RpaFVhMGJkMlh2OTJoYUR0UkF2OFIwbnlmaGFk?=
 =?utf-8?B?bmxIVnJ0Q3Z1aUdDMmN1aFlEcDhqMHZmOHdyWHRwcTRoZ0ZrT2dYbEI5RVl4?=
 =?utf-8?B?ZzVMYndiQWh5eGU2M1ppclllZk9XeDVCaWF5Ly9KODg0TmRRUk5yN2plWk0w?=
 =?utf-8?B?RCs0U0NlTStvQjV1NHNNN1M2eTNuMURoTE5pUDJJWFBJL1VDUTlKNkRNMHNE?=
 =?utf-8?B?TlFUTXgwcUJXaVlXbXRyemVWR0ZHQ0RPbVlKTGhLVXpTQW9ONHdHU1NJVlZG?=
 =?utf-8?B?bklMSlJTVEZrYTI3dmQyQWQwYUlybndxY2thNFBHWG10WmxCdUhjQThMVXZl?=
 =?utf-8?B?TGdpQWx0UnlRcnV1YUdjY3RCcEZiOVZzeHI3eHQvZUlmTitMcG53QkErV3Ez?=
 =?utf-8?Q?5jvTdnhLc7eeQauaJ08YkS8=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 850d59a7-f18d-4182-f7cf-08d9ea1d9716
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2022 09:38:26.0701
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QeOPZPK1Zto5f0UWFrPoffwz4c2fgTiLgU+GKSfsy0qvIV7CBZal0RPwxbDtPnayGxG0wE237AUnnAC55YFl1g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0401MB2469

On 04.02.2022 23:07, George Dunlap wrote:
> On Mon, Jul 5, 2021 at 5:06 PM Jan Beulich <jbeulich@suse.com> wrote:
> 
>> p2m_add_page() is simply a rename from guest_physmap_add_entry().
>> p2m_remove_page() then is its counterpart, despite rendering
>> guest_physmap_remove_page().

First of all: It has been long ago that I noticed that this sentence
misses words. It now ends "...  a trivial wrapper."

>> This way callers can use suitable pairs of
>> functions (previously violated by hvm/grant_table.c).
>>
> 
> Obviously this needs some clarification.  While we're here, I find this a
> bit confusing; I tend to use the present tense for the way the code is
> before the patch, and the imperative for what the patch does; so Id' say:
> 
> Rename guest_physmap_add_entry() to p2m_add_page; make
> guest_physmap_remove_page a wrapper with p2m_remove_page.  That way callers
> can use suitable pairs...

Well, yes, I understand you might word it this way. I'm not convinced
of the fixed scheme you mention for present vs imperative use to be a
universal fit though, requiring to always be followed. When reading
the description with the title in mind (and with the previously missing
words added), I find the use of present tense quite reasonable here.
I'm further slightly puzzled by you keeping the use of present tense in
"That way callers can use ...".

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 07 09:51:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 09:51:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266623.460314 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH0gM-0007vT-4K; Mon, 07 Feb 2022 09:51:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266623.460314; Mon, 07 Feb 2022 09:51:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH0gL-0007vM-Vy; Mon, 07 Feb 2022 09:51:37 +0000
Received: by outflank-mailman (input) for mailman id 266623;
 Mon, 07 Feb 2022 09:51:36 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=hYSm=SW=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nH0gJ-0007vB-NJ
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 09:51:36 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 86c6fbae-87fb-11ec-8eb8-a37418f5ba1a;
 Mon, 07 Feb 2022 10:51:33 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 86c6fbae-87fb-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644227493;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=qrESZAZwNitO38rK1W33xK14LFSnyhyngExHlGoL6LY=;
  b=Y8w9ROszvyf6+/byzu4TvYeaop/Jhqz+1a4BUl6Ay5bsPpf+FxuL3lrB
   1tBVIKY1SaJPF/ITM4ga3EUWrX4tqQmq4qyFiRH/f8dzD/AdL4OzglCpC
   ieo3NtNG8b6h7UCpr3tbr05xPRDvJmu1LVeuZgj6HM5qVfcjZp6hr/iRI
   k=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: zt+8SZ0SQeDt8hbh1NPZZlrgaqKz4jLSI+CP31NNcvCMvV52gdQrfw7Cd5H1bcdk7V7j8UNyp8
 gWKr4sGl9oBD4P1mLZ/Y0BCIgNBvoUU8arx8MskVY5pzrHA0/dJEL0fX3RqsUBO22prCwoMFMr
 nVpRXqOL/9zGQ6yoNwSfpQD9RZlLtbzheBSn5X1smW9j6gjCq0gOTM5hUYN7KI4VaLW4cwPHUz
 MlX+7G67SIVs8/DtJJwIeGNpqlrHHMzD8AK8Mn/IM3Givop2R7xHgUAB1vhjru+LSwSD0pmgab
 sqV/+ZRrm9ILr73cZXGJphXG
X-SBRS: 5.1
X-MesageID: 63630354
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:01kKsaKqW/NRE0qTFE+RA5IlxSXFcZb7ZxGr2PjKsXjdYENS0zNTm
 mBJXGuHbPfcNmf3ctFxb4S/9kNV7cXRx4M2SQBlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokcxIn5BC5C5xZVG/fjgqoHUVaiUakideSc+EH170Ug7xLZg6mJVqYPR7z2l6
 IuaT/L3YDdJ6xYsWo7Dw/vewP/HlK2aVAIw5jTSV9gS1LPtvyB94KYkDbOwNxPFrrx8RYZWc
 QphIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbrGvaUXe345iXMfwZ3u7hB22wM5fy
 /NctaeCE1YIYqvOh8U2cDNHRnQW0a1uoNcrIFC6uM2XiUbHb2Ht07NlC0Re0Y8wo7gtRzsUr
 LpBdW5LPkvra+GemdpXTsF2gcsuNo/zNZ43sXB81zDJS/0hRPgvRo2UvoEDhGxt2qiiG978e
 cpCRAhpVi7NSARfOAgzGdFnseuR0yyXnzpw9wvO+PtfD3Lo5Bx81v3hPcTYfvSORN5JhQCIq
 2Te5WP7DxoGctuFxlKt7XaEluLJ2yThV+o6Fre16/pri1273XEIBVsdUl7TnBWiohfgAZQFc
 RVSo3dw6/hpnKC2cjXjdyLnvlCHmA8cYOgKQsxm7gOS64H3yRnMUwDoUQV9QNAhscY3Qxkj2
 VmIg87lCFRTjVGFdZ6O3uzK9G3vYED5OUdHPHZZFlVdv7EPtalu1kqnczp1LEKiYjQZ8xnUy
 ivCkiUxjq57YSUjh/TipgCvb95BS/H0ou8JCuf/AzjNAuBRPtfNi2mUBb/zt6coEWphZgPd1
 EXoYuDHhAz0MbmDlTaWXMIGF6yz6vCOPVX02AAzQ8Bwrm3zqiT6Jui8BQ2Sw28zY645lcLBO
 heP6Wu9GrcPVJdVUUOHS93oUJl7pUQRPd/kSurVfrJzjmtZL2e6ENVVTRfIhQjFyRF0+YlmY
 MvzWZv8XB4yVPU8pBLrFrh1+eFwnEgWmziMLa0XOjz6iNJyklbOEuxbWLZPB8hkhJ65TPL9q
 YoGZ5DUmkkADIUToED/qOYuELzDFlBibbjeoM1LbO+TZA1gHWAqEfjKxr09PYdimsxoei3go
 hlRg2dUlwjyg2PpMwKPZiwxYb/jR88n/3k6ITYtLRCj3H16OdSj66IWdp0We7g79bM8ka4oH
 qddI8jQUO5STjnn+igGacWvpoJVaxn21xmFODCoYWZjcsc4FRDJ4NLtYiDm6DIKUnisrcI7r
 rD5jlHbTJMPSh5MFsHTbP7znVq9sWJEwLB5XlfSI8kVc0LpqdA4Jyv0h/4xAscNNRScmWfKi
 1fIWU8V/LCfrZU0/d/FgbG/g72oS+YuTFBHG2T77KqtMXWI9GSU3oIdAv2DeirQVT2o9fz6N
 /lV1fz1LNYOgE1O79hnC79uwK8zu4nvqrtdwlg2FXnHdQ32WLZpI33A1shTrKxdgLRevFLuC
 E6I/9BbP5SPOd/kTwFNdFZ0MLzb2KFGgCTW4NQ0PF7+tX1+87ewWElPOwWB1X5GJ7xvPYJ5m
 eostab6MeBkZsbG5jpesh1pyg==
IronPort-HdrOrdr: A9a23:X6wYTarDEaMX0XvyrnifED4aV5oveYIsimQD101hICG9Ffbo8P
 xG/c5rsSMc7Qx7ZJhOo7y90cW7Lk80lqQU3WByB9mftWDd0QPDQb2KhrGC/xTQXwH46+5Bxe
 NBXsFFebjN5IFB/KXHCd+DYrQd/OU=
X-IronPort-AV: E=Sophos;i="5.88,349,1635220800"; 
   d="scan'208";a="63630354"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=J+PnEo3G0jvQVNklo6I4OUWkuHJRvy/xDW6jWrYD8McNcBDFe4/qE2aqjp2Y0AwirrJ9jnfkSJD+3Y9kfWRLrJQ3aapTsxMllaO1EFW/6anbsPiea4+hN3mfycfjQKCgQ8JZf6pQ82zMOpTNkJVHRJFa5s73iDV5EjzYITQ5PW1nVVKy/3C9AxUt/xFdf0IDGTIotS+n6hW3uvxlSEGeu0PJ/3ljWWIz+43VLyRWUynkki0siBUoyuUdirCEauhZaKziVN4WOZ+oDFiYAncfsvU/XPE3A/fM9Gmet0t6X9FtFCmV/XT9tZiw0mZsY2eBzB+U5I/ZkZClzx+2IvBFgQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=XiOfI3zwfLnqqgoXiik9Wlkdk/H7DaolRG8yaxJP5LM=;
 b=NdwCgppNJoTW1QsJEsOz62WFM+jBBIQh0i9Mv/roYbUAqW2/WYQqLkd2MbfFiKQT/FNQhEh0ba9g26mfh6+oHMJARuogEtGYrPAI8HFJOG98V7WUNvoX+0fsQ2zPF3hGHDGQR7L15Yf8WINppEzsMvnpmTZKexQc/AoQGZ6QzmiX+KZHqDdJNGb4oWUDSsXMEG454ZMxy7TCg0IanMtYZ/DQkSBDGhqhKeH/wAon4fAnK1LldWZoYboXkMyULuUmloq+lm35udg7zFgpwZkvNpuK1eHVNo4W+sP2udO3No83HNlLq9qL5p0UKCSbOF5XiOda3ghxsj2BmZpOdb+39Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=XiOfI3zwfLnqqgoXiik9Wlkdk/H7DaolRG8yaxJP5LM=;
 b=LzDj+FoBkEZeaYiNqWbybm8BO2OH8FyNZEOzq2k1EiUm02AbmTZDegMHSOi4tdxaBPhDpUNhX/48mu8HxwEJQdJAv1Gtnqrf+N8VttYiKOd+Nx+ADKjXm0RwmXwbhWs5f5h7lPE2Ys469YeVWoeRTIwrps8jPFFDnPt2D4TfdCI=
Date: Mon, 7 Feb 2022 10:51:02 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] dom0/pvh: fix processing softirqs during memory map
 population
Message-ID: <YgDrhhiJsH3r1i5x@Air-de-Roger>
References: <20220205101806.35927-1-roger.pau@citrix.com>
 <10266b94-7399-2f76-24e8-57ac6a1ac258@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <10266b94-7399-2f76-24e8-57ac6a1ac258@suse.com>
X-ClientProxiedBy: MR2P264CA0060.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:500:31::24) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 0060474a-2598-4129-8937-08d9ea1f66b3
X-MS-TrafficTypeDiagnostic: BN6PR03MB2562:EE_
X-Microsoft-Antispam-PRVS: <BN6PR03MB2562AE1028F7861AED8CF3CF8F2C9@BN6PR03MB2562.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: TjtetQam1F+d/FgQVBTtlt06i7IoSMJzPrzIgDvCBC42rctuwhJQYjsdUn0obGmWAl6bqeGlmFkXwlHpKg4SCHjibZItY73+T3E1v5X42w9P/W/cQlD627omTwxMIlz/9f5JC6pRcBMGAWllDGNTLQXlkhQFWzr9diSMsoKADppgSUv2h/RL3EKyc/9sJZD7YNCq67UounWKJ6NXhOF9gdtNMQ/CNZ5l0I8H3JgGhCkcmz9GdAzsN4kJJ3dZ7/EZyRQqHfbVvGCQbtHx+Mhd1N6JAa9Urx+z3Zbx1qkL0j9eUcCKf6ZbRe5qk5XiWvwwcQLlFh81Qd0wlmL6cbYFqCsBmW47AYPjt71S5nzpu35rBGU8K1PYPsP/twoLFppllONYME4EtzhR4TfTvdOF8GOrTP47cDhj5sluW2fir9dn1jDESyX6MV7iQ/dQg6bxtRWdN1hSsBwm5+sat4klN1XW2EhsMWQ5zyvCq2gFxpU6aRsoPEaiVw8eLuK4n8qSImEvclsUIsqAhcM6HAwsAwQ3BUXT5oEqkw+VnpxjwJBXOOsiCSpiyrC9jYhy+0fMrDXdsh/IuRkP7vstJyDFo8pkOBXOLU6FQAO2tTAADgFJ0BecSBUJcwR9zDWrUsCyks1CZII/Fg0SQ3wCXkrinA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(508600001)(83380400001)(33716001)(53546011)(6486002)(2906002)(6666004)(6512007)(85182001)(9686003)(26005)(186003)(6506007)(38100700002)(5660300002)(86362001)(66476007)(66946007)(66556008)(82960400001)(6916009)(316002)(54906003)(8676002)(8936002)(4326008);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N2dxZW9RdVVhZ1J3c3ptTXBEYjFHVlB6VStxWnVGK3g3c3BSQitPOWFwbEo4?=
 =?utf-8?B?VlhLNkhDQU9tK1lYR0RMeUVqN1lyTlkyUkJqMFJ3eHRRM0VvTGZLMktzdDlC?=
 =?utf-8?B?R0Jyc0FRM3ltQWNjMGNub2R4SzhQY1pKRnpFem9iQ2MwTjlGcXVmT3lwUFB5?=
 =?utf-8?B?QkFXLzMwSzdKSkFLbUVydWphU3U3NndmNWVIQ0xzNFExUXk3VUh6Mi9uTnBB?=
 =?utf-8?B?aStueithM3U0cFFFMEY4aXZRU3ZvYmNxS1gzZHNHWGY3VVlwWHZid2NFWGMr?=
 =?utf-8?B?WWIvTkhtMXhYSU92bTFLWnJDdTdvc1dZUnVDdzJPZU50RU40OEpzTnJIM2xn?=
 =?utf-8?B?UElLVWNLd1ZGK2RYaitVZDVvYlJhRGREQ1ZoUWtCSVFrS2djVXJLZ1lOTkJB?=
 =?utf-8?B?TUVUaUowbHMvUGwwK3UvZ3ZiQVFLejRDeVZlMjMvZEpkeFNHSXc3MUVacmpC?=
 =?utf-8?B?SHZGclpOZ0EvVnMwWmRXZnk0WVo2cXpFdDZHU2VjYmIvcFpvbGQxSXQrZVBx?=
 =?utf-8?B?aHFYNGhRM2lsTDN2YndkeWprcTExTVhRSG5OZFAwUWJvd1htdmUySmVPdDBQ?=
 =?utf-8?B?N3Z3a0R6NnB0Uk5WQkFoNTFWLzZSRTIzQjROMDEvMUlnRW1RYnZPaFVaajBX?=
 =?utf-8?B?ZnkrNXRYY0VQbWl2Ym5mMW1xYmU3VlNoNjN0U0JaeWx0SThOMFFpSEZNRjZi?=
 =?utf-8?B?dWE1djA5c3BGaGRHS3JxU0hOZnZyQy9kYy9mVG9aOTY5K0pnOFZ0dURnNHpE?=
 =?utf-8?B?TCtVcTVpMVg4VlBUZGo1L2FYWVZtY2lkV1dwSzQ4emRSbVozVG00eDBYYm51?=
 =?utf-8?B?M21iTDl3U0xZMnlkLzlhUXBFbkp6VTBBQUxuRW9vZTRSdFZOaXZQeldOY2dj?=
 =?utf-8?B?eGl2SUc1dHZ1RHdNbnNsN1g2Y0t4MEpqQ01GY0ExZUNnMC8zMWRLL1N5MFJx?=
 =?utf-8?B?a3BNYWxDRmlQZVh2WXBmQmdidDMzTXJhOUQxa2xUNHVBZmorbng1LzFDbkNZ?=
 =?utf-8?B?M1psN3I1L2Z0TU5tWVVwWExvL3U4ZURxMWlLaGpWNW9ua0l6akkrWlIwR3Jp?=
 =?utf-8?B?eFdRMjRxUVJBWGFKUDFBS0h5d1kzbitXbjR5UW9teGtVRTJtUFJKbkJpSXAw?=
 =?utf-8?B?ZVRjQ1duQ2JCZElOamZzNFNsUVEyVVRSQk9iYnNrT1lsN1pjSnhScFk1cG9v?=
 =?utf-8?B?MTY1RnJ4N0VQQlh6MWFKQnhQVVpqYWlEUVpLYjF2T3BOOUk3d3IwOWlYZU5T?=
 =?utf-8?B?UTdsNE42Y0w0cWttL3R6ampxaEYvMEt1NVFnZmwxeDlHamx5bit2U1o5QU50?=
 =?utf-8?B?aUp1c2J1RDVmQnVXdUJTblU1QUwrMGZoTFVOM3pnYjhaVmpxaVAzekQ4c3Ex?=
 =?utf-8?B?cXVxSUUvQnErUlBHTm1SbTgwL3FHZXRnM2p2QmZlMkhHSTdoRWd4UXNFR2hF?=
 =?utf-8?B?RVQ1UXZuMDd1cy83ditnakVTeUpOM1hQc0pObThkSUpMd0JBRGY5bno3YU5w?=
 =?utf-8?B?OXlKdkVUMjRxOHdXeG1wOEhSWDZjR2VxU1E1V2FKd05vVUtCcWs0K3lXTzVE?=
 =?utf-8?B?K1J1eUtIRDM3R1lrS09pd0UzdjNibGZqUzdqZzVDRG8zbStLOU1iN3NCd09I?=
 =?utf-8?B?RzNHOCt6Y29ZYjdzckc0SzZRTGc5emdQOHJvNUdXeHdmQWM0aW5FbzFjNmYv?=
 =?utf-8?B?QWUxTWRvNlIvQkpUSlpWYi95SXNoczh5eWh6cmcrblg1ajdJTFVlL3RLYmh0?=
 =?utf-8?B?MWJqUVdkSjExTnQzb1RmR1ZYQkpncEs4OUxiYzJodHI4ZFJTaFE2WHlnTDAw?=
 =?utf-8?B?Vy9UMW00UnRxdEh4LzBxU1IyNGliUElqYVFBbXNDUktobEl0N3R1aUFxb1ZG?=
 =?utf-8?B?RU5KcUhxU1lueGdKQk1SblRYYnBXeHQ2SmNkV0FsRkhvZFQ5VE1QekxabzN3?=
 =?utf-8?B?dGRIcVBpdEZ6T1BMZEpyblAxY2ljNkJ1OG5obnJOOUJIeTlsYXZzRGxKRTJO?=
 =?utf-8?B?VHBCeEVQVkJlQk1xa3E0cnlCd21Wc0ZpWDZvVXRnVE1Bby9VM2xVdGFrcE1y?=
 =?utf-8?B?RHNSRmV0YnVJZ05DVEorbFoyVDhSY1lYUmxFVzVkWEF2Wnp5NHJpNTAwVS9K?=
 =?utf-8?B?QlUxTnBESXlBblJDSUhGVk50T3FrVkdnVUVMcFBTclpVRGxXaG9ZVHNkQzB5?=
 =?utf-8?Q?XXOcclNa/jnqOb5upVnlbN8=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0060474a-2598-4129-8937-08d9ea1f66b3
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2022 09:51:23.9750
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Cs1r2NHkSL3XGEaieCavxiIvvbMlao0y6mJUETqLPBPavoF++txoqyv2bbC5rLQq3S4jyRSzySCIGalZsu6DLA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2562
X-OriginatorOrg: citrix.com

On Mon, Feb 07, 2022 at 09:21:11AM +0100, Jan Beulich wrote:
> On 05.02.2022 11:18, Roger Pau Monne wrote:
> > Make sure softirqs are processed at least once for every call to
> > pvh_populate_memory_range. It's likely that none of the calls to
> > pvh_populate_memory_range will perform 64 iterations, in which case
> > softirqs won't be processed for the whole duration of the p2m
> > population.
> > 
> > In order to force softirqs to be processed at least once for every
> > pvh_populate_memory_range call move the increasing of 'i' to be done
> > after evaluation, so on the first loop iteration softirqs will
> > unconditionally be processed.
> 
> Nit: The change still guarantees one invocation only for every
> iteration not encountering an error. That's fine from a functional
> pov, but doesn't fully match what you claim.

OK, will fix on next iteration.

> > --- a/xen/arch/x86/hvm/dom0_build.c
> > +++ b/xen/arch/x86/hvm/dom0_build.c
> > @@ -186,7 +186,7 @@ static int __init pvh_populate_memory_range(struct domain *d,
> >          start += 1UL << order;
> >          nr_pages -= 1UL << order;
> >          order_stats[order]++;
> > -        if ( (++i % MAP_MAX_ITER) == 0 )
> > +        if ( (i++ % MAP_MAX_ITER) == 0 )
> >              process_pending_softirqs();
> >      }
> 
> This way is perhaps easiest, so
> 
> Acked-by: Jan Beulich <jbeulich@suse.com>
> 
> but I'd like you to consider to avoid doing this on the first
> iteration. How about keeping the code here as is, but instead
> insert an invocation in the sole caller (and there unconditionally
> at the end of every successful loop iteration)?

In fact I was thinking that we should call process_pending_softirqs on
every iteration: the calls to guest_physmap_add_page could use a 1G
page order, so if not using sync-pt (at least until your series for
IOMMU super-page support is committed) mapping a whole 1G page using
4K chunks on the IOMMU page-tables could be quite time consuming, and
hence we would likely need to process softirqs on every iteration.

> 
> Furthermore, how about taking the opportunity and deleting the mis-
> named and single-use-only MAP_MAX_ITER define?

Right, let me know your opinion about the comment above.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Feb 07 09:51:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 09:51:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266624.460319 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH0gM-0007xg-Ct; Mon, 07 Feb 2022 09:51:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266624.460319; Mon, 07 Feb 2022 09:51:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH0gM-0007x8-7F; Mon, 07 Feb 2022 09:51:38 +0000
Received: by outflank-mailman (input) for mailman id 266624;
 Mon, 07 Feb 2022 09:51:36 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=owYM=SW=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nH0gK-0007vB-KO
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 09:51:36 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 88b38ab2-87fb-11ec-8eb8-a37418f5ba1a;
 Mon, 07 Feb 2022 10:51:34 +0100 (CET)
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur02lp2057.outbound.protection.outlook.com [104.47.5.57]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-5-fSsQYmgiOKib0r30aXbAoQ-1; Mon, 07 Feb 2022 10:51:32 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM6PR04MB6166.eurprd04.prod.outlook.com (2603:10a6:20b:b6::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Mon, 7 Feb
 2022 09:51:30 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.018; Mon, 7 Feb 2022
 09:51:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 88b38ab2-87fb-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644227494;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=pwgq335aOJOtqXr46wEMq33uLC4uGbizI9qqa8QslsU=;
	b=VfI0C+xeuP2vVA5ldTA9HvoB4+dMIQ0U5pTmiawC8tKMOEl5zPngP4RZAhj5iqGCRJmmf4
	05WHosO8UK6Lt6GCEHBVJ39co1t3/Nrudh9SPl7rP3YXS7wBCm7sE118UiWJibRAz7iFrN
	xxNooxqgzKLd5nndbrQn/OlvrnWryZM=
X-MC-Unique: fSsQYmgiOKib0r30aXbAoQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=EGuj1CgOaTHaOba19z8DpKUNXI76cr0SHK8fbMesAio1QaZ5OR7nHewZUPvD47fM7Etsrnj9fZ/I6L+VyDvbGk+qMZGlwq4BzM4uKX1Kp6d9rm83v2uz/Ot6o/p/qv5Hu/HHTbVDB0TmFh3jgjtO/bUaapgX0INJS0yLHcWvCJ7ef/M+GuhpOSPKYGgf0nM+m3fLE8TNYFnNsNfjnra/PzosGl95gPmzQYHcgj13Fv7Nn7KTlZDWXQfNbBLGT5cej9GtmSSoIB8b/5W9uNKzqAWSW4FWDRCpanaYbz1f4lLb9NgNEO9i+ZM3mJn0TsKF4OpHBFGYeC43aq0zAXaNJQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=pwgq335aOJOtqXr46wEMq33uLC4uGbizI9qqa8QslsU=;
 b=QRfnpGj6mH9FZGYpU6fOoKHLuF0Pjz1jX6tzsHzlb55DNtusdbvBm/Ouio8ObnefLZ2tVbXr+RYwJK7+KFGKQdaIBVD2ccpQqGn0VXgtEeiDFfC9i+PM0rXtTNztKDOQWJSbC87x0LCMNPsCbdQGLDSv5fjAtWey1K4PJai7/b5s7U/DAMAXeq7xKHAmA3y3EOfEXa8DHLhfvRwr6pR3i/tIpqq0RLuq2aetmXolIRgSt272aVdmBTdbua3XdXdumMTKQpzJOkCzNRTNnzqNUPR8K2cbXdcc/OItufX/f3UL62oonh+pCmBYglbIPJRD77iyCCDfHYRKfomlS+JhjA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <1cb63467-787a-0a75-0f77-893a0b7e0ac3@suse.com>
Date: Mon, 7 Feb 2022 10:51:28 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH 03/16] x86/P2M: drop a few CONFIG_HVM
Content-Language: en-US
To: George Dunlap <dunlapg@umich.edu>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>
References: <d1fd572d-5bfe-21d8-3b50-d9b0646ce2f0@suse.com>
 <55643e68-432a-116a-b68e-2200e364e5da@suse.com>
 <CAFLBxZYCqCKeuM4XJTNgEwzoAG7P8aw2dP5kHFSSHX_xmuOWBQ@mail.gmail.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <CAFLBxZYCqCKeuM4XJTNgEwzoAG7P8aw2dP5kHFSSHX_xmuOWBQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR08CA0038.eurprd08.prod.outlook.com
 (2603:10a6:20b:c0::26) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c1244574-72a8-4573-b358-08d9ea1f6ac7
X-MS-TrafficTypeDiagnostic: AM6PR04MB6166:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB6166426083205AA88BE34CFAB32C9@AM6PR04MB6166.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	kODZ9lrdG/RCJVyJFw0473cWYIziwiPm3KIlPL+HzUt0DWu1ZXHo298QhXgF5bW4KjY2/FizfRJo+HKkGR6mgus/MzJFjhG7k0QvuIq4CsxG/74YteG8XGwdbBTmcX/ztejAKn41GeIAgDqO3Qky0IXHV/DUV7+EoEiJCRWT9Ox1Yvd/bGkwd/A6K5PeqY4ySLKMTPy8wBOe/mL0JjUpTj+h5nZKivcUcSpIjbYUbPp4BGW5fuPoa0OUoPCki4qLhbrzFAtQBtbc4i+5lrT0TOcKKmeZ5NjmBZ2p4UGWv3LpzvfBHv3E5NAe3i0x53Q7u4QTscIR6+bZnI+bHek+AAiq26A+m8otqk5bz4LFMpGCiGqVXSkBKiuMrG/natCGXejzuLb3PpV49vGWexWiQyvs45sZsYuv46ls+sqrtl+H5pPudCcFy/rdTPj6TB6F1/TBsGFgNDLuEMrALp/88VctvsO4PR8WWJu9xZMGs2v1rwdSBz5Ii/Lj9IWupla+svXtpelsXLFiG9hEKBJYi1vf7ZLdqZppWWAQ5E5FTi2Cz1AIyGQKXtJR/M9TC5QcOtCtriYeRXmjN6VrMZYkFfpZudy47MUPNHLd7beznjcjdxBtL3exqZnu+HF8d00rQjronuPHq7zxHXpX72sPsr6pB48zZvWovjYOStxcntEp8SnbDnzjgQmOmvWPzpvDUuUTgm1jO3DXk6JkJZEjOhWCIqrT6up9iLb9tnzEgRw=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(86362001)(31696002)(54906003)(38100700002)(8676002)(8936002)(4326008)(66476007)(66556008)(316002)(66946007)(6916009)(2906002)(5660300002)(6486002)(2616005)(31686004)(6506007)(6512007)(508600001)(53546011)(26005)(186003)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UGI2T1phcm9razUrRjJWc0JxTEZiT2hlVmRzM21ubkQvZUdOSzVtRG5vZGp2?=
 =?utf-8?B?QWdjV3Y3MENmYjFUQW9oSmNCTHdRYXEyRHNJT3FzOGFPQzFERzV4aHNVeUY3?=
 =?utf-8?B?TkR0eUJCTDFxZ2lvS0dzUGRSM09rcVBmSmVsdEJ4RVRoODBQWmVUSUFqS0NC?=
 =?utf-8?B?bjJ3QUV2Q2c0a2czanJRV0FzTnVJTXpCV2U4UWVvY2p2NG1kWXFJdEVLTlRo?=
 =?utf-8?B?N1BjUkRWa01Hb1R3b3VBRkRvN2hqNGl0L2paanc2VWtKa0FZUUVaL3dyNlU2?=
 =?utf-8?B?TTEvNDNnaTdjdEtueERlUzhKYlcwZlEybVdVbEJjS084VTM5dG0xcWFpNE1q?=
 =?utf-8?B?WlRtZnh6aE8yNnBOeFUrYTlZcFF5d2lBS0hvVldlaGg4NUFiOGNKU09pNU5V?=
 =?utf-8?B?V0dJbzN4Y1pkUitIaXJSVWRlUkgvVENGU1hzdmE4aWFzdEFRQThHblprYlVT?=
 =?utf-8?B?MHZnYjA1WVk2UnJBT2JZRzZtQjh3eHJJK2hucmRDTmZDVmpMYWJ0bWc1WU9K?=
 =?utf-8?B?NWdtRk8rQnJscmx3VVNQekpWMXNUNmV5alZYNFFaZ2lUc1NiL3BlTitqOFZ4?=
 =?utf-8?B?KytCUEFoaEdhUjQ3K2FrM0lOQnl0cVlUdUNCTGk5MHlnaG45Rnp3bEgrZXhT?=
 =?utf-8?B?Y0tjdU96WjFWTUNsZXRicklmMU1OVERKTitTeGZkaTlyR3huTGpMaThsaWpL?=
 =?utf-8?B?OXVweGlBQ3o2T2pLbGtSQm15WTRRaDFyaG5LbllwTC9icEV5MnFtZWhxQmFD?=
 =?utf-8?B?YW9pRWZhWHVvR29Ub2d4bUJpbk5jWkpKVnFtUTVNc0xsbXlCaHkzVmZWMVJ5?=
 =?utf-8?B?UjRIdWNwemZCUFlSZUxYWWt5MEtTT045YnZnemdOWUtwY3ZqcWZNWHlTUmhF?=
 =?utf-8?B?YjhmWnBOdURHcThBZ2pONVkrbWd3MnUzZUVYVVZGbkF3TXUxR1d0cllEbzlD?=
 =?utf-8?B?RG9rSUN2dGxYSmczOGV3OURTckFiUjlIZHRtNGRUWTlnbXBpVmNsZDErL3R4?=
 =?utf-8?B?OGR1VHZIVmpEbXZYS0RRT0FlRVB6THdEVFJCVGNFZ3ptNndpbXMydUJuZFRZ?=
 =?utf-8?B?WWtaeDdFRU5iZDVKbFd2Y1Z5TFdHZEk5bHZrOThoNGx3R01OUUwxS0tjcG5y?=
 =?utf-8?B?YlQ5czhTZktvRzVVNitiVVR3VnZUd1BLS0d6cDRTYlFyNmNrcjJNMzZROTFR?=
 =?utf-8?B?bTJVU0hUNk5FZHVUNzBZRzgrdnlLL3VsOXlZckVLcDg3MlhsSU5TUTF4K28z?=
 =?utf-8?B?a1VuWXpiR216ZG1jTEhmanJjcUhJQU9NV1NMYmFmakw1QU8rK3N3QjJldDhl?=
 =?utf-8?B?ajhRQmVHZThhSEltNGpPcHBCeFl0MkhKSUZpbHR5R3lKNUxqbjFKMHR4UFll?=
 =?utf-8?B?OHByajhOcXBKa0lXb2FoT0xLeUhDRDFyeHd0UDQ5WHRxSWIvK3FUYk96UVdL?=
 =?utf-8?B?Wm9VSWRQTlk4MlM4NStJSEhlTnJTRG9qODdDU3R5M0hyQnBRak5jOFVsQzU3?=
 =?utf-8?B?RUYvYkF2MFBKcTcxTGtkMTAvb2tjNVRvdVYyYk91aXVWMnpaT3RObERXS3lk?=
 =?utf-8?B?SXQ1dFRPTWQ3djM5WUJ2UWR1cFV5MWFQSmR4ZElyLzYwMGhkRGx1QzVlTTRi?=
 =?utf-8?B?NEJReE1OeERvM0tTdXdkY3dlanYxRVFHbTlYRjNXQWZKVmU4SWY3eWRQeHpv?=
 =?utf-8?B?bm5wYUtSemhLdnVGZEZxb21VQkxhSzh6SEVUNE53Z3lzMHI4Qmt5WVNhL0dv?=
 =?utf-8?B?V2Zka3J6LzNDM3R4bzBTWG10aHhtUE11bUQvWjVDZmdKdis1YjJiRHVuOXBt?=
 =?utf-8?B?SythSzlrdE0raW9VbWkyWElWcXJSZmIzci80R2hCR3M0QlJUSU5TU3ZpZ1Y4?=
 =?utf-8?B?dHNhU2F2eWVuNEMzbDJ4UWlza2lTNWJUaXZnMjhybTZid0FvSGs3enUrZmI5?=
 =?utf-8?B?Vk5XaTE0OHlIMzhRaXBQaHhiV09ENnRZMXQ3Y2QzcVM4c0JUeGZMaHIvL3c4?=
 =?utf-8?B?bWUyZlhzRGtacmxlclBXSndPeENIam5MVWMzdGtENk9JUGV5MnRZSDdPekg3?=
 =?utf-8?B?N3QxVkQvaEdrVmpBMFkrVU9kcHMzbC9ia3F5WWRpNVVzNTc3MmdkV3JRYnZw?=
 =?utf-8?B?dHRNOWNydzB1Sk5zdHVTMHJZQlR3UEVsK2xVZ3lZM2MzWFg1NGNINGlWNFJo?=
 =?utf-8?Q?hi6ug8vp5Xfn/Mhv48pesqk=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c1244574-72a8-4573-b358-08d9ea1f6ac7
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2022 09:51:30.7868
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vkpUvmMmvFfcP/cem/vqjhERQdxvqNZJCbhTwZft0xxBmUIL2gzjLF7nakQVqzGVVladyg9OpOVlOzLGdqFI/Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB6166

On 04.02.2022 23:13, George Dunlap wrote:
> On Mon, Jul 5, 2021 at 5:06 PM Jan Beulich <jbeulich@suse.com> wrote:
> 
>> This is to make it easier to see which parts of p2m.c still aren't HVM-
>> specific: In one case the conditionals sat in an already guarded region,
>> while in the other case P2M_AUDIT implies HVM.
>>
> 
> I think this would be much more easy to understand what's going on if it
> was more like this:
> 
> ---
> x86/p2m: P2M_AUDIT implies CONFIG_HVM
> 
> Remove one #endif / #ifdef CONFIG_HVM pair to make all the audit code
> CONFIG_HVM only.  This is to make it easier to see which parts of p2m.c
> still aren't HVM-specific.
> 
> While here, remove a redundant set of nested #ifdef CONFIG_HVM.
> ---
> 
> Reviewed-by: George Dunlap <george.dunlap@citrix.com>

Thanks. Unless you tell me otherwise I'll assume the changed title and
description are merely a suggestion, not a requirement for your R-b to
apply. I continue to like my variant better; in particular I'd like to
not mention P2M_AUDIT in the title and this way avoid "While here, ..."
or alike.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 07 09:52:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 09:52:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266634.460336 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH0hd-0000cf-LN; Mon, 07 Feb 2022 09:52:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266634.460336; Mon, 07 Feb 2022 09:52:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH0hd-0000cS-I7; Mon, 07 Feb 2022 09:52:57 +0000
Received: by outflank-mailman (input) for mailman id 266634;
 Mon, 07 Feb 2022 09:52:56 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=owYM=SW=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nH0hc-0000cK-II
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 09:52:56 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b9191dcc-87fb-11ec-8f75-fffcc8bd4f1a;
 Mon, 07 Feb 2022 10:52:55 +0100 (CET)
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur02lp2054.outbound.protection.outlook.com [104.47.5.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-16-59Ph7fXENt-UfNEfK00QbA-1; Mon, 07 Feb 2022 10:52:54 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM6PR04MB6166.eurprd04.prod.outlook.com (2603:10a6:20b:b6::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Mon, 7 Feb
 2022 09:52:53 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.018; Mon, 7 Feb 2022
 09:52:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b9191dcc-87fb-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644227575;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=iMF+NdZa3rhWgQA9szyZZhoiagBTVUgzEnIUFbf1G94=;
	b=XQml6ZQjXxK6Lr6IotUiFd/98jSbtvWdCu6F1u9Z6rkF6N17JzwEaVZz89blIyQf6KlSuR
	2blbVbCL8n+tLngK08BpEXgpZfHuvmLp8HGqheYI0iZuaQDqaNMDrTKrix3ALQC6bJVqx2
	d6Y5HkWiP4HcaKePN1lzOs6zryC/teg=
X-MC-Unique: 59Ph7fXENt-UfNEfK00QbA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=DY0/f0n7b+1IYNutyR6QYvg//WqwUDJ3eI0ad+swcj4HPpj3t4mFaH+XrElfGeRoLDkU0ZmjuvxtKGSX7hxVVHsAiDd73gq7BJIPaVRUUiJpd4/+4TN9csODMp3+Ran8etggbeeAMpM6BKnIHDT770rXIfjP/pLgp0XWDCSz/pzDvYN3mx6MzWmYi/oTz7g31jWdsKGiZISYSi972Aeu5D8KVJpzApTiBgW3B37hhpr8G5rfgjBmGI0z9GQ3YXKX8IZw1J+yPIbwTg6G5/CDo9h08hzVIHBJn9Ur6zVdLfbASBrw91x6wxn7FKaZKd3NQ3AyCAp7EVXWMdax64SQfw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Yld6LlMD3YNTlB7jKatulCSudWVWc+yVLJhJMQevo3Q=;
 b=hayKKoVThXUNebK7mskNXPygJ72UoaogP/nHnFN0FaI77RlBow0A8TxiShUjeKnEYXNCtrtYz/b1i0nmEeffagfoUcbk/K3gnzMDMqxveXB3w5crfoua+pbarNgV6dT6GcImGP1q5Jm3ILqgKTdjVS9ibu+lfn53b8XsRXqCBcnBDmPx+d4aXqYYWzXY/tl8qdteKMqjOg0UuCr1dYCb46RHckfVUtR6QkRnp4pnvxc30TXABTkAEXKOdsQLHqoAva26nKEyFaH2c12b2uXlLGcol/V4OYTz6Ca3tIPD7YOcgZM+sk9UDZaL6+ndtGi/qAjkggj7/c+rrUw5dKvIUQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <c30f30d4-ac93-8b47-14df-2a5e64bf2487@suse.com>
Date: Mon, 7 Feb 2022 10:52:50 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH] dom0/pvh: fix processing softirqs during memory map
 population
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220205101806.35927-1-roger.pau@citrix.com>
 <10266b94-7399-2f76-24e8-57ac6a1ac258@suse.com>
 <YgDrhhiJsH3r1i5x@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YgDrhhiJsH3r1i5x@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6PR0502CA0040.eurprd05.prod.outlook.com
 (2603:10a6:20b:56::17) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 16adf07c-6c7c-4470-f864-08d9ea1f9bbe
X-MS-TrafficTypeDiagnostic: AM6PR04MB6166:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB61669DE454A0AA48404843DDB32C9@AM6PR04MB6166.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	QvLjIOelvfGn52rA5Fp9JqTUdX1g5KXPCt1uxjlJaQ2bNG+iE0Ki71HtsVpEsmrae3Y+6QEfv1cquOrmgvfI8EzrXhGniVrqHDJTTVri5BQUPPfSCwlSNu2OGNi8k+v/l8G867G8zPFEEjsT9ctDb+LeYAdrQTMRMMlG/HSQptWfe7vLknxLWM99MzKxBFLb+SKnt7C2qGkfjkFbyiw8K7SDmfVon3frjJpfZEbNlfGdqPnmE98nCSYSfKKfdGikfm0rv+rAAjZeEBCk2NM0Zi4zEP5/MWklOX3WjsyGSwcspE1aj/NTx8ZN451EVUiOQZva8d/FCP5zD95Wc0O0hwrACQGNIeAGnVePVr0fnnJwsoJZzWgwYchcI5fz+sUqDF/YAG/kD1h2IXcWZaaHgsZXD8znmI/s3VYZpXjXmP141Hj0pYU4NRA3obQHdk0s0yeFvr/R6q/BxEqg907+syVVkbv20WgXXbybma7716O8yjRQFOI8wnN0BJ2TyNkuZVh1vxNQkSVajiWgj+GAo8CpHKIovNq3vNdjCihwdJEkecIc+9yrlnF6X8wwMBa7vsRe63PNTA/41/xcos7tW+Ti6T6+SPhsGxPw4pv6EcgTPSMEiMLApIqDDs9WwlcIK+RW6dtwUsSO2j5ka/eHjRCVep67nS2kU/oxzfW49KS4LnSjnwRFa8dp3PCXDwutGG2vgmFMBMsJXNLPhT6lqHZEbBJuZztdniyYSBvHLXg=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(86362001)(31696002)(54906003)(38100700002)(8676002)(8936002)(4326008)(66476007)(66556008)(316002)(66946007)(6916009)(83380400001)(2906002)(5660300002)(6486002)(2616005)(31686004)(6506007)(6512007)(508600001)(53546011)(26005)(186003)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?XkQRjJfN8qAetZPQlY62ZW2EG5FNBfFy4RzU22hH88qc4h43c1CFvM8gUX3C?=
 =?us-ascii?Q?JVhMh/gzF23Ycb51HEwy/dPKeS4cNSoTK/pGTJm7G4rtVwREgbDPPW86Mj8Z?=
 =?us-ascii?Q?rq6kWfV3JGMd++gFsVMQ8spXftsZCvgHF7jcBt+qp2SbY2eI7GdJhJduVpRd?=
 =?us-ascii?Q?nfFUEGat31gudWJ93DkI17WSAEqa5zuxpuJ2oo0HKcJ1b3K5IQ9Ulp9A8LyB?=
 =?us-ascii?Q?ToB+pTJAADpDu44J7ougpFat5VEjhgXgvdrUsBT231Xx3KxlSxGlp+Ekg6w2?=
 =?us-ascii?Q?Y5BytDReyt2EV1rGrVrTuyJrivWUtVUlhNGix98It3zr77ZycPIygV9Uo+ab?=
 =?us-ascii?Q?KsgRx1H8LI5dQL/LyN6DTbVK8duj6puZ7TOnMPVQ6t7Ewnv0owPxRiIfdrX0?=
 =?us-ascii?Q?jijqFZK4c+NKgIKo+LG/W/j5rjP3yS3uLhq09SsqV5Yk720aVFZqvZRujyb7?=
 =?us-ascii?Q?qKLOa713UIiTNHXu5OQk6116KS0Xqb916mbvCQ3gP+1VNBqU1j2KsA42A0cn?=
 =?us-ascii?Q?ceORRRktFlXdYGM71Axt0wLYgGcoae+NgRPpE+Af8G6857FBzIrHp7p4+dqB?=
 =?us-ascii?Q?RZGI7KdIJQysFnI8BxkXdnjCxm46sOnmSKwOfRmfTEGFFb5J1BPYZjBamdTq?=
 =?us-ascii?Q?UeSD7T9eKDhoNSmuQsoisrJNKnPlJ5+trXaG/+6uUBUOuSFN2fCf/YjJpHsn?=
 =?us-ascii?Q?mSwy2nplraKavekDKkMXxAWfajlysszyDOeIcPOfrE/U3iTCvbwdL80tRQJH?=
 =?us-ascii?Q?8Inu2nKRLsOJ2W1GWY/wG/y/MRIz6tZ3t4gbS0xM3k2nPPbl0rLAUKOy/BWD?=
 =?us-ascii?Q?CbKSOlmDdEC068Fdl852zJMQeikzelY+ZlR6pBM/KYgm74qT59gd65d2jorR?=
 =?us-ascii?Q?7ESmQFYZXVjiEvbbsuqB4m4YocpfDLID+NhMdMm3qjfMPohkN9f4WkfxRi/m?=
 =?us-ascii?Q?KxdBgWQGEaNsPE35Sbd4/nnLFuXRxLP4G/0UgCDy4ANXJ48YIBDUN8ppNB3X?=
 =?us-ascii?Q?W4UnppSadvs31GUEqS8TnkjqjTFYF5Omds5u8d6325FSTAwfiteVahbWBR9R?=
 =?us-ascii?Q?wsfO0kFnjKGx0OQ0s7NvHKv+UHcQt4YeZldd4vQSt7SGoryj3RrIoCRPgAOF?=
 =?us-ascii?Q?UBWuCSd4KwnAVHsJeKqgM5GgFafkmE51he91JWhPyl+a+zpbwUY5SMtHvKpK?=
 =?us-ascii?Q?QcquPsvNPkgiKpxcqm/VM0SXMR7/+fDUSZ2hJ+fthvRWQwDpljIG6h05dLMG?=
 =?us-ascii?Q?yIIYdF5G6oZb2VHlRL2vSqDnHpYa1Wq5rL1/kUTFdVs1FxWddTbk6kCSI0xD?=
 =?us-ascii?Q?g3eTqsfYDu29WsMm4YEbrZC9aXVpe1Pf45wspiU0PeBT+Cbz5hIswd44aHC+?=
 =?us-ascii?Q?508q0n5QeH+H2D5wxGWhUV4XGi7e47++MmIAqApTlZYSXQLEs3IF8nZkzAm4?=
 =?us-ascii?Q?RY6R1LW3Adx1D05D2vf6zNMJPemHj8yl/dE585pTLW6XhOMiq4U60z3D1owW?=
 =?us-ascii?Q?OaaYBgdq4WlnlrV4b4uWegI1Eq8t33UnmdQmFyZeobMtl2JHpc1+AjN+obWI?=
 =?us-ascii?Q?RK8bjNd7/xLlSRhnaueUY8Pi/dGpZ3ChIC6n6t8mAObsOq0lY0B1iZAH82k5?=
 =?us-ascii?Q?oJLffCPjGemKZ/6b47HTEKo=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 16adf07c-6c7c-4470-f864-08d9ea1f9bbe
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2022 09:52:52.9380
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LZRiBd58CcVEyB8Hkw9sCweeDw6qUVyUAPqghqUKc0kzVfdReHUQCb/KEAL0fXD94DFL7ToyZJyxQmTroPIygA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB6166

On 07.02.2022 10:51, Roger Pau Monn=C3=A9 wrote:
> On Mon, Feb 07, 2022 at 09:21:11AM +0100, Jan Beulich wrote:
>> On 05.02.2022 11:18, Roger Pau Monne wrote:
>>> --- a/xen/arch/x86/hvm/dom0_build.c
>>> +++ b/xen/arch/x86/hvm/dom0_build.c
>>> @@ -186,7 +186,7 @@ static int __init pvh_populate_memory_range(struct =
domain *d,
>>>          start +=3D 1UL << order;
>>>          nr_pages -=3D 1UL << order;
>>>          order_stats[order]++;
>>> -        if ( (++i % MAP_MAX_ITER) =3D=3D 0 )
>>> +        if ( (i++ % MAP_MAX_ITER) =3D=3D 0 )
>>>              process_pending_softirqs();
>>>      }
>>
>> This way is perhaps easiest, so
>>
>> Acked-by: Jan Beulich <jbeulich@suse.com>
>>
>> but I'd like you to consider to avoid doing this on the first
>> iteration. How about keeping the code here as is, but instead
>> insert an invocation in the sole caller (and there unconditionally
>> at the end of every successful loop iteration)?
>=20
> In fact I was thinking that we should call process_pending_softirqs on
> every iteration: the calls to guest_physmap_add_page could use a 1G
> page order, so if not using sync-pt (at least until your series for
> IOMMU super-page support is committed) mapping a whole 1G page using
> 4K chunks on the IOMMU page-tables could be quite time consuming, and
> hence we would likely need to process softirqs on every iteration.

Good point; please do so.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 07 10:11:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 10:11:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266652.460346 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH0za-00037z-Af; Mon, 07 Feb 2022 10:11:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266652.460346; Mon, 07 Feb 2022 10:11:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH0za-00037s-7Y; Mon, 07 Feb 2022 10:11:30 +0000
Received: by outflank-mailman (input) for mailman id 266652;
 Mon, 07 Feb 2022 10:11:29 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=owYM=SW=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nH0zZ-00037m-4Q
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 10:11:29 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 50177480-87fe-11ec-8eb8-a37418f5ba1a;
 Mon, 07 Feb 2022 11:11:27 +0100 (CET)
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur02lp2050.outbound.protection.outlook.com [104.47.5.50]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-6-n6nfZUvJNEaMMCLuGQzWUg-2; Mon, 07 Feb 2022 11:11:26 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AS8PR04MB7605.eurprd04.prod.outlook.com (2603:10a6:20b:292::6)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Mon, 7 Feb
 2022 10:11:24 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.018; Mon, 7 Feb 2022
 10:11:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 50177480-87fe-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644228687;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=8YH8xXPsjaApYBZN9h+yF+I+pqBSmrixHWlVUqXll7E=;
	b=j/YNNoKhhnmPZP8P6nZHkxqbJ7e2qrpA07H3R2/psixbGIoquLGBCiIPIvmByMCKDYqH7J
	xtIDAxMlQmNEfaA3RwqQczlWwjW6tgCl3P79T8At1zw4XV6K+YV9jm8Suj0BW7TGJidhM8
	fQ1xJkCwc2lstHhmJPCHR/3/RXqrb8c=
X-MC-Unique: n6nfZUvJNEaMMCLuGQzWUg-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=i9/4kvfgOB2QWNmql3FuDFU1GVQeffmMYtfS8LMC4kOCm/NqlVZgpHKMzI3GqcQO7uHO5V+4gmWfVLh0BXDYRMqWF1KzEqcTStBpTQNEF9rE0cHozNywCuuKpU0xDwhfZCjEdO9VwquCQ5Htmwyrc5ts4FJqGyxafpx9IxXJJdv7xkuPPBxlzl2utjTERpkv0IU2tpatBS3rLAwHfaKuy9Q3gIt18l8wlVWAcagcKFGmX3G7JwQOsIPxzRTjmz8O2mo/U87jLcXoUB+qKwRn631gV5Ac2sUOmn0kGl5OP2lQa3clADO/USewmsfszx5GATOkRBr+t9HJMTvifTyqFw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=8YH8xXPsjaApYBZN9h+yF+I+pqBSmrixHWlVUqXll7E=;
 b=QHx+86vzPIUGxrj9ShEde8FM13s6y/GGO23hnTN1luBkbLOJgnEDeM564nIxZ8jid2l2EeAmIRZDOkwQo2rHD6xgvFESp3/2LTcWKmrscRnqQzS4MBLgwFE68j1TLHHB3PxlEcm5W4aM4fk756cecv0Tc4AThg7ZXq7AlSTDb6dJ+YfxnBROVyGL6TKaCd/lZxPxh5eZ/Aip+C6RIuGRm+wz8I9FS1/HXJrV4RSO3qfkdbAX4NwfciQKholk0HoJ/6Yu7crodqlAu8UFyjTGac/+iaS5RKZRApwFe8aqbUyHvkLCvtxWqIUBUhRM5geMyusv5hfsUmQ3C6D199B4/A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <ccc16e12-2036-d71b-5521-71685f0ab38d@suse.com>
Date: Mon, 7 Feb 2022 11:11:22 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH 08/16] x86/P2M: PoD, altp2m, and nested-p2m are HVM-only
Content-Language: en-US
To: George Dunlap <George.Dunlap@citrix.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <Andrew.Cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 Roger Pau Monne <roger.pau@citrix.com>
References: <d1fd572d-5bfe-21d8-3b50-d9b0646ce2f0@suse.com>
 <694a6590-0018-223a-c796-3e1469ec354a@suse.com>
 <0C051DFA-9147-42DB-AA36-0DED3D192F43@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <0C051DFA-9147-42DB-AA36-0DED3D192F43@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR05CA0040.eurprd05.prod.outlook.com
 (2603:10a6:20b:489::23) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7f3d3b9c-0ce9-43c4-b557-08d9ea22326c
X-MS-TrafficTypeDiagnostic: AS8PR04MB7605:EE_
X-Microsoft-Antispam-PRVS:
	<AS8PR04MB76056B5BC7D13B57FFF0A423B32C9@AS8PR04MB7605.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	PowBbF9VVxd2rsQfgcxL6SbOZapmyTdcU4VG7wPGv6bkHpjM4CPRVIetRu2bV0mDs6fqhlYXdRB8oUGAh+Q/wOXz1W1qVTSotlxmvtQ+wMC7hLl2KM1qxUwS8eRSUYN8B/IejULuPMCHBBRPp8TjHcJw7Ock1o8nd0/R8q0f3lcYiqozZlD8YByUa8FNjOkSHBQZh43zoxL3jd0+Gi/XiYtka5lssHcivyJk1/Ie7ePFjhZLLrpEF0g1QBO15BQao1zCpbZE1mRX/X/aaBYUlwJ9lj55MraINK8aGufS58AZL0R8nab3gjpqAme9sECzNUc4H2sDwThcpSekDXlSKiVi/tG0icWX4RcA0KTmdpLySRWibNujo/i/MrQxf/K9H7/cJU7F5bIVR4IBugWkkjmisn6yz7Gn+C5XeWsXFpPtXjoVLmp6ruPfXrLvuRcsiW6HHDh2kz8a1XvCbcIE0I+7luEayua7yAbVyL1hKnhYK9iM+hLDKqJj1c1hzGScJBx4Pgry2jErrpD4fTqLDyg5oSa7Xa6cTxqce1DtqgjR091nb60SAbCGLSCFhXBJn6kSuF/BmAHMQnOQx70q6+AHaAkmmiB4BChOX+8cfTlEvLJvyM6zWD+6wxbOs/Mux8n8VhOcb/GAN1OkRDVomR2pDlVOXy3cY05t/Kfp4u59Vb21cMLGqykx//mrXyOoGw6JCVhuVB+NxCLy4CCIGB8uPoZ11I/695V5fdkDvQ4=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2616005)(83380400001)(4326008)(8936002)(66556008)(31686004)(66476007)(8676002)(36756003)(508600001)(26005)(6486002)(6506007)(86362001)(31696002)(53546011)(6512007)(5660300002)(38100700002)(66946007)(316002)(54906003)(2906002)(6916009)(186003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?OHZwNlhyb2YxNHR5cFhkb0srMzBDaGxyKy84UFRmeGM2RFh0TUJuRkx3d1N4?=
 =?utf-8?B?cVhIOHZ4dDJ5eTBIVlp3RjJ2UFprV0c5Nmgzdnl3L2tLanhoMGw1dGVHL3VX?=
 =?utf-8?B?RVViRjZkTWxLM2d0aEQvby9yRjdYeFY0alFXb0xZK1NGc1BCd2gwK0Z3cHh1?=
 =?utf-8?B?SlB2U1l2Zi9Yd1pRdFE4YlNIMmkvTjRRZ3YzOUJVbm1uQ3pxOVJ2eUVVMWRO?=
 =?utf-8?B?VXY0YkdUeElUREgzMXk2ZFlHZVJjb0xtS2tWQXg0OEs3Tzd6MEFxaWZQRWRX?=
 =?utf-8?B?dkJnV2ZpR0dzM1BBL3lWUm9QaHBNL0hjL013S2h2elh3S0NoNDdyeUp0RmVt?=
 =?utf-8?B?R2VCSWZZZGNuT3NVWWhOTGF6UWZNbkRXdTNrc3ArcjlnQmpIc2FlUWJ2azhT?=
 =?utf-8?B?M0draU9UNnlwMkZubVhJZmxTMGJZbUpJTlhUaVhWTmwybnRIbENjQVBTRkhR?=
 =?utf-8?B?ek5mazVaY3A4WFFPRUhYb1p3VTU5cHJMUVhVRHZ1eSsvQVdMdEZiVkNMQU14?=
 =?utf-8?B?Sm50NGI5dlprOE5yUVFUMUxCZmRaQVBlNDBJWVZKc3RnQnhZNUdSQTFHVkFu?=
 =?utf-8?B?dnRkVUpmUlZqVW9MNTJOWCtOTWp0K0dDT0N4b2xQZ0JBUktjVmhsRi8yYWtF?=
 =?utf-8?B?czczdlkrbU5QV3BrZkplVUZYdUM5RVUrMmhrdm1wMlcyenRJQ3RKV3pxYXl2?=
 =?utf-8?B?RFFobklZeklxdXovMEZIdW5uVHl1bVY2M2doZVBlbzhtMWdvMEJQZy8ySVpi?=
 =?utf-8?B?Wi8xL0Jzc05xdzZuLzFOTGhKVERpcDdPcGw1NmVabXVyYlVHSEc0Y0Y2ZnlS?=
 =?utf-8?B?N1poRFdGeHMraGNaLzJuZkJjSXhJVEpEUk43ZFB1azRkNUpWUzJnTWdqMC9Z?=
 =?utf-8?B?MFRKUXB1SVFPZCs5Zmp4MXFYelh3c1FqNHVicmxYY245TlpTcnRuc2Y3MXVT?=
 =?utf-8?B?cnY5aXA4S1BYSjlzYkNOUENRYmZ1TXVRdmViQ1ZTMmxpRFplNkZTMktrWlB5?=
 =?utf-8?B?SHNRZytUWVh3WWk2VkM0bGhsOUM1K2duQXplTDFJeG44aWdVcGQvQkJ0UjhJ?=
 =?utf-8?B?VUNzN2kvd1dlT3luZkkzYWNERHpzZi9DclVtdkpKUWVxUzhTakhaYS9BUHlZ?=
 =?utf-8?B?cHB3K2JHYWVnclRqZzlFRHZzcHBRR09GQUFGdHpWOXRnclllOFRncU1uRzhs?=
 =?utf-8?B?UTQxeUJPSGI4bHliblNPL0htRkhOUThUZzF3aTNWbnI1cXkwbjN0VDhWMGxa?=
 =?utf-8?B?clE3aGEvVmZXcUhUNnBhejdDNU45bnZvTEgzd1lxKzFGMXdzWGorT0s2dGo0?=
 =?utf-8?B?UmhWZktuTWM0dVdLS1JOWEpIWXlLbjlhQ2pSQk9YeFYzTTVFTllYMFdCQlJC?=
 =?utf-8?B?QStDbjkwQXltdzJtaUVudEk4ZUZSajBZdytGYzdnOFlTMUJjcTFDUWVvRnUz?=
 =?utf-8?B?cW5VUFU1QUxlamVGbXYrVjdqdStoTFh5SGVMaU1BS2sxb21TZ2U3L1EyYlBX?=
 =?utf-8?B?MFN5ZHdkZUY2amVIeHdKRUxiVVFIVk5NclJGN3cwTHlJQll3dnMwK0dlMm1Y?=
 =?utf-8?B?Vi8razQ4eUc3UUhLdFhRUkRDL2xOeG9aUHAxUlAxNHcwQ0F6Q1FwWVNqMlhN?=
 =?utf-8?B?S1R4RGdEenFKeGlobVRBRHFrbTk0RmIyNDFQNE5STFluY2hRU0JaMGZVaGtX?=
 =?utf-8?B?UVgrdVBLZFFML1hJL1J5YWh1bVdRSzRiS3BkZkU4aWVjNWZlWjhjc2txbXJV?=
 =?utf-8?B?VVVENG8ycDdzRDRyU2hiOGlLeHd1c0o0cEhRREVDWnA4ZVkwNjZpMlhNRmtW?=
 =?utf-8?B?ejhEK1JCMnRNSHpVSlNMbGhFRWtpTHg2YTlMNEZUcHVPRWFhUGpvV0k0RklS?=
 =?utf-8?B?VW1oYU13b2daREJGUmdwaGo2TlhkY3BtN0F5VUQ2QWk3RDNIVURkT1F1Uk5u?=
 =?utf-8?B?ZE5CeFpMTERsUFRyTkdhZDRqNG52RnBjNURsSlo4WkVPNVZxdlVaVm1qbDNS?=
 =?utf-8?B?NlJialZFaWNVVFJhUE1URG96RHQ4Nmp2OStEUDJoRkd6bXlMbE0xQjd1YUZ6?=
 =?utf-8?B?cnFJb1JseC93QjBjY1lING05K1BTRUkvT2lLQjVEa2I5Rk9iK3k5RFdFMjJz?=
 =?utf-8?B?N3hUVlhsTUE1RVpnZUptZHJPbmR2NjdST2tNYjdYSEc3c2VIL2w0VTk0T1hh?=
 =?utf-8?Q?MOoK5WaA9+GwaBkpQM7VBNI=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7f3d3b9c-0ce9-43c4-b557-08d9ea22326c
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2022 10:11:24.6971
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ED3UC7trCih21YPrcnJiaPPq3YO0gLQgJN32CmAtVXCp95iH6jjhPoPlLh03pcRbb5XadmWO91z35lftritHyQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7605

On 05.02.2022 22:29, George Dunlap wrote:
>> On Jul 5, 2021, at 5:09 PM, Jan Beulich <JBeulich@suse.com> wrote:
>> --- a/xen/arch/x86/mm/p2m-pod.c
>> +++ b/xen/arch/x86/mm/p2m-pod.c
>> @@ -1135,6 +1135,12 @@ p2m_pod_demand_populate(struct p2m_domai
>>     mfn_t mfn;
>>     unsigned long i;
>>
>> +    if ( !p2m_is_hostp2m(p2m) )
>> +    {
>> +        ASSERT_UNREACHABLE();
>> +        return false;
>> +    }
>> +
>>     ASSERT(gfn_locked_by_me(p2m, gfn));
>>     pod_lock(p2m);
> 
> Why this check rather than something which explicitly says HVM?

Checking for just HVM is too lax here imo. PoD operations should
never be invoked for alternative or nested p2ms; see the various
uses of p2m_get_hostp2m() in p2m-pod.c. However, looking at the
call sites again, I no longer see why I did put in
ASSERT_UNREACHABLE() here. IOW ...

> If you really mean to check for HVM here but are just using this as a shortcut, it needs a comment.

... it's not just a shortcut, yet it feels as if even then you'd
want a comment attached. I'm not really sure though what such a
comment might say which goes beyond what the use p2m_is_hostp2m()
already communicates.

> With that addressed:
> 
> Reviewed-by: George Dunlap <george.dunlap@citrix.com>

Thanks, but as per above I'll wait with making use of this.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 07 10:35:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 10:35:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266661.460357 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH1Mf-0005W4-9O; Mon, 07 Feb 2022 10:35:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266661.460357; Mon, 07 Feb 2022 10:35:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH1Mf-0005Vx-68; Mon, 07 Feb 2022 10:35:21 +0000
Received: by outflank-mailman (input) for mailman id 266661;
 Mon, 07 Feb 2022 10:35:20 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=c1Gu=SW=linux.alibaba.com=jiapeng.chong@srs-se1.protection.inumbo.net>)
 id 1nH1Me-0005Vr-0q
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 10:35:20 +0000
Received: from out30-133.freemail.mail.aliyun.com
 (out30-133.freemail.mail.aliyun.com [115.124.30.133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a279d0f1-8801-11ec-8eb8-a37418f5ba1a;
 Mon, 07 Feb 2022 11:35:17 +0100 (CET)
Received: from localhost(mailfrom:jiapeng.chong@linux.alibaba.com
 fp:SMTPD_---0V3qO.zD_1644230107) by smtp.aliyun-inc.com(127.0.0.1);
 Mon, 07 Feb 2022 18:35:12 +0800
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a279d0f1-8801-11ec-8eb8-a37418f5ba1a
X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R201e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04394;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=13;SR=0;TI=SMTPD_---0V3qO.zD_1644230107;
From: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
To: boris.ostrovsky@oracle.com
Cc: jgross@suse.com,
	sstabellini@kernel.org,
	tglx@linutronix.de,
	mingo@redhat.com,
	bp@alien8.de,
	dave.hansen@linux.intel.com,
	x86@kernel.org,
	hpa@zytor.com,
	xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org,
	Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
	Abaci Robot <abaci@linux.alibaba.com>
Subject: [PATCH] xen/x2apic: Fix inconsistent indenting
Date: Mon,  7 Feb 2022 18:35:06 +0800
Message-Id: <20220207103506.102008-1-jiapeng.chong@linux.alibaba.com>
X-Mailer: git-send-email 2.20.1.7.g153144c
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Eliminate the follow smatch warning:

arch/x86/xen/enlighten_hvm.c:189 xen_cpu_dead_hvm() warn: inconsistent
indenting.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 arch/x86/xen/enlighten_hvm.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/x86/xen/enlighten_hvm.c b/arch/x86/xen/enlighten_hvm.c
index 6448c5071117..6f4c9b57eda8 100644
--- a/arch/x86/xen/enlighten_hvm.c
+++ b/arch/x86/xen/enlighten_hvm.c
@@ -185,8 +185,7 @@ static int xen_cpu_dead_hvm(unsigned int cpu)
 
 	if (xen_have_vector_callback && xen_feature(XENFEAT_hvm_safe_pvclock))
 		xen_teardown_timer(cpu);
-
-       return 0;
+	return 0;
 }
 
 static bool no_vector_callback __initdata;
-- 
2.20.1.7.g153144c



From xen-devel-bounces@lists.xenproject.org Mon Feb 07 10:36:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 10:36:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266668.460369 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH1Na-00063T-Ix; Mon, 07 Feb 2022 10:36:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266668.460369; Mon, 07 Feb 2022 10:36:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH1Na-00063M-FY; Mon, 07 Feb 2022 10:36:18 +0000
Received: by outflank-mailman (input) for mailman id 266668;
 Mon, 07 Feb 2022 10:36:17 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=ddl1=SW=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nH1NZ-0005wh-9l
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 10:36:17 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c7370740-8801-11ec-8f75-fffcc8bd4f1a;
 Mon, 07 Feb 2022 11:36:16 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id D94691F37E;
 Mon,  7 Feb 2022 10:36:15 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9A00B13B92;
 Mon,  7 Feb 2022 10:36:15 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 4qQ5JB/2AGJeQgAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 07 Feb 2022 10:36:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c7370740-8801-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1644230175; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=IigLRlJyl3GnO9/rAuPdXj1reb21GnqbYc745JCT4VM=;
	b=h0LiGBDd5zv5AKSm6Q4MIMFe0vZnGMQYKYvU9SREQ4ie7Wq4VKwuZNy5F255pBPwMbF2Iu
	RQBWuubFKmZw7BYQ7O5XbE1BsuEl/wg3fVChg60YT6Y2E/zfKQTRXDZvu8ELXNllnN/8xp
	53J8Y011JjiYTFYaDBS+QamY+n4PGTw=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>
Subject: [PATCH] xen/public: partially revert commit 7c7f7e8fba01
Date: Mon,  7 Feb 2022 11:36:13 +0100
Message-Id: <20220207103613.32260-1-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Commit 7c7f7e8fba01 changed xen/include/public/memory.h in an incompatible
way. Unfortunately the changed parts were already in use in the Linux
kernel, so an update of the header in the kernel would result in a build
breakage.

Even when removing its usage from the kernel the used flag bit should be
marked as reserved in order to avoid to give it a different semantic in
the future.

Do a partial revert of said commit in order to enable the kernel to take
an updated version of memory.h.

Fixes: 7c7f7e8fba01 ("include/public/memory.h: remove the XENMEM_rsrc_acq_caller_owned flag")
Signed-off-by: Juergen Gross <jgross@suse.com>
---
 xen/common/memory.c         |  2 +-
 xen/include/public/memory.h | 12 +++++++++++-
 2 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/xen/common/memory.c b/xen/common/memory.c
index 0d7c413df8..9b5214a8a9 100644
--- a/xen/common/memory.c
+++ b/xen/common/memory.c
@@ -1234,7 +1234,7 @@ static int acquire_resource(
     if ( copy_from_guest(&xmar, arg, 1) )
         return -EFAULT;
 
-    if ( xmar.pad != 0 )
+    if ( xmar.flags != 0 )
         return -EINVAL;
 
     /*
diff --git a/xen/include/public/memory.h b/xen/include/public/memory.h
index 383a9468c3..fd768e0b7b 100644
--- a/xen/include/public/memory.h
+++ b/xen/include/public/memory.h
@@ -662,7 +662,17 @@ struct xen_mem_acquire_resource {
      * two calls.
      */
     uint32_t nr_frames;
-    uint32_t pad;
+
+    /*
+     * OUT - Must be zero on entry. On return this may contain a bitwise
+     *       OR of the following values.
+     */
+    uint32_t flags;
+
+    /* No longer supported - will be never set */
+#define _XENMEM_rsrc_acq_caller_owned 0
+#define XENMEM_rsrc_acq_caller_owned (1u << _XENMEM_rsrc_acq_caller_owned)
+
     /*
      * IN - the index of the initial frame to be mapped. This parameter
      *      is ignored if nr_frames is 0.  This value may be updated
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Mon Feb 07 10:38:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 10:38:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266678.460379 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH1Pu-0006ko-VY; Mon, 07 Feb 2022 10:38:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266678.460379; Mon, 07 Feb 2022 10:38:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH1Pu-0006kh-Sg; Mon, 07 Feb 2022 10:38:42 +0000
Received: by outflank-mailman (input) for mailman id 266678;
 Mon, 07 Feb 2022 10:38:42 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=ddl1=SW=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nH1Pu-0006kZ-5J
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 10:38:42 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1d72738b-8802-11ec-8f75-fffcc8bd4f1a;
 Mon, 07 Feb 2022 11:38:40 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id E92B1210FB;
 Mon,  7 Feb 2022 10:38:40 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 91D9913B92;
 Mon,  7 Feb 2022 10:38:40 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id WvUeIrD2AGKWQwAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 07 Feb 2022 10:38:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1d72738b-8802-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1644230320; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=fRg/KrCpHSrUBFXxA9iQ6SfefZdasVbcPfiKOyC6LFI=;
	b=OD1PYXh8UCh7QewQ4/YGePNXBt+v2QnFCkXYRwH7/iVCTVslzxZIkYVvkNIRSJKDXGLJvR
	E/D/zlC8kUWFX46d2GfUnrdlJbzyJiyhQ26RVKg4WeTZiflxeqGlBNMvky0M4/G3o1FCpm
	uXP8RMJnay3eUl0Iv9KwdfKEhoFkVkQ=
Message-ID: <6b06a133-d39b-46bf-d574-c1afeb92b2b0@suse.com>
Date: Mon, 7 Feb 2022 11:38:39 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Subject: Re: [PATCH] xen/x2apic: Fix inconsistent indenting
Content-Language: en-US
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
 boris.ostrovsky@oracle.com
Cc: sstabellini@kernel.org, tglx@linutronix.de, mingo@redhat.com,
 bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
 xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
 Abaci Robot <abaci@linux.alibaba.com>
References: <20220207103506.102008-1-jiapeng.chong@linux.alibaba.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <20220207103506.102008-1-jiapeng.chong@linux.alibaba.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------zR35Epbl73u6X4Sy41IhP7Md"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------zR35Epbl73u6X4Sy41IhP7Md
Content-Type: multipart/mixed; boundary="------------oBn0DW5buLl1Hm6LsSbXJ0eh";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
 boris.ostrovsky@oracle.com
Cc: sstabellini@kernel.org, tglx@linutronix.de, mingo@redhat.com,
 bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
 xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
 Abaci Robot <abaci@linux.alibaba.com>
Message-ID: <6b06a133-d39b-46bf-d574-c1afeb92b2b0@suse.com>
Subject: Re: [PATCH] xen/x2apic: Fix inconsistent indenting
References: <20220207103506.102008-1-jiapeng.chong@linux.alibaba.com>
In-Reply-To: <20220207103506.102008-1-jiapeng.chong@linux.alibaba.com>

--------------oBn0DW5buLl1Hm6LsSbXJ0eh
Content-Type: multipart/mixed; boundary="------------toO60Ntrx6rFcpP7aGO4CUDO"

--------------toO60Ntrx6rFcpP7aGO4CUDO
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMDcuMDIuMjIgMTE6MzUsIEppYXBlbmcgQ2hvbmcgd3JvdGU6DQo+IEVsaW1pbmF0ZSB0
aGUgZm9sbG93IHNtYXRjaCB3YXJuaW5nOg0KPiANCj4gYXJjaC94ODYveGVuL2VubGlnaHRl
bl9odm0uYzoxODkgeGVuX2NwdV9kZWFkX2h2bSgpIHdhcm46IGluY29uc2lzdGVudA0KPiBp
bmRlbnRpbmcuDQo+IA0KPiBSZXBvcnRlZC1ieTogQWJhY2kgUm9ib3QgPGFiYWNpQGxpbnV4
LmFsaWJhYmEuY29tPg0KPiBTaWduZWQtb2ZmLWJ5OiBKaWFwZW5nIENob25nIDxqaWFwZW5n
LmNob25nQGxpbnV4LmFsaWJhYmEuY29tPg0KDQpSZXZpZXdlZC1ieTogSnVlcmdlbiBHcm9z
cyA8amdyb3NzQHN1c2UuY29tPg0KDQoNCkp1ZXJnZW4NCg==
--------------toO60Ntrx6rFcpP7aGO4CUDO
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------toO60Ntrx6rFcpP7aGO4CUDO--

--------------oBn0DW5buLl1Hm6LsSbXJ0eh--

--------------zR35Epbl73u6X4Sy41IhP7Md
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmIA9rAFAwAAAAAACgkQsN6d1ii/Ey97
bAf/RSXbgw75TsvUhawE1zOJM8BYbjzzOKBLRiNG8JaLsJ7mmVXhstO0jpTN5G6YkAZ2lakHuCZL
rrLDuUacd5qPKU5XHVnEZV0+R1yCB/kPVehodV9ASXaMofoywzMeOkDUMmay+ldh556KJ2VtJ7RJ
IsxgVdpHuh8rFzn39SAAH1LAPms7Ji44T1fBSpNuBo6uwS6JqXE17dzRP5jYxreMj9TuuIp1rCJA
3n7C85oYER3+d3yD6ToMksIdeJonlxGWxz4ebmu0ur1GRqDh7pV0iZ/cJ0NjoO6BfLSPjOjb2+SK
3dftV0LeUJb/p2FXytZIs8dCwk6kvNSMl85JruFr7Q==
=PtrF
-----END PGP SIGNATURE-----

--------------zR35Epbl73u6X4Sy41IhP7Md--


From xen-devel-bounces@lists.xenproject.org Mon Feb 07 10:38:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 10:38:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266679.460391 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH1Q3-00073q-8R; Mon, 07 Feb 2022 10:38:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266679.460391; Mon, 07 Feb 2022 10:38:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH1Q3-00073j-4x; Mon, 07 Feb 2022 10:38:51 +0000
Received: by outflank-mailman (input) for mailman id 266679;
 Mon, 07 Feb 2022 10:38:50 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nH1Q2-00073M-BC; Mon, 07 Feb 2022 10:38:50 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nH1Q2-00006t-80; Mon, 07 Feb 2022 10:38:50 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nH1Q1-0004Nb-PO; Mon, 07 Feb 2022 10:38:49 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nH1Q1-0005zS-Ov; Mon, 07 Feb 2022 10:38:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=adTuc0/5BO6tc22yIwHr1PIdFdUbzjx3CCph257Oo1A=; b=M0VI19DWYs9UXcDzcG1VWr8GYn
	/YtIDFxWPWH3qeoOlw6j3PC2YJoJ3TT3JfhTrr7YG5wOaVWsvdDx5O0QUYc9c1tNLLOqJULL37Y4u
	aIfK+h6uH1oRIaSXAIIZ1JQishgAtIZB+dtCke/8KZwN4BKWET3SzTkEwb42Gkp2pT/Y=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168042-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 168042: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=f78b937c95ddc4f7a29e41fee98e96076828a108
X-Osstest-Versions-That:
    ovmf=6fb09da89f88000a7592171a0ce08cf1feaa0646
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 07 Feb 2022 10:38:49 +0000

flight 168042 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168042/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 f78b937c95ddc4f7a29e41fee98e96076828a108
baseline version:
 ovmf                 6fb09da89f88000a7592171a0ce08cf1feaa0646

Last test of basis   168038  2022-02-07 01:55:23 Z    0 days
Testing same since   168042  2022-02-07 06:41:36 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Gerd Hoffmann <kraxel@redhat.com>
  Jake Garver <jake@nvidia.com>
  Jake Garver via groups.io <jake=nvidia.com@groups.io>
  Wei6 Xu <wei6.xu@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   6fb09da89f..f78b937c95  f78b937c95ddc4f7a29e41fee98e96076828a108 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Mon Feb 07 10:46:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 10:46:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266704.460401 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH1Xh-0000OJ-7t; Mon, 07 Feb 2022 10:46:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266704.460401; Mon, 07 Feb 2022 10:46:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH1Xh-0000OC-4r; Mon, 07 Feb 2022 10:46:45 +0000
Received: by outflank-mailman (input) for mailman id 266704;
 Mon, 07 Feb 2022 10:46:43 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=owYM=SW=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nH1Xf-0000O6-Ca
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 10:46:43 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3c05cb7e-8803-11ec-8f75-fffcc8bd4f1a;
 Mon, 07 Feb 2022 11:46:41 +0100 (CET)
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2053.outbound.protection.outlook.com [104.47.8.53]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-32-tFyAzUNQPNOKZNEvDkpQQA-1; Mon, 07 Feb 2022 11:46:40 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DU0PR04MB9444.eurprd04.prod.outlook.com (2603:10a6:10:35c::5) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Mon, 7 Feb
 2022 10:46:39 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.018; Mon, 7 Feb 2022
 10:46:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3c05cb7e-8803-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644230801;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=cUjpp8UpJffA04V3EbdopeSNBUXOJLg4fXPA0jqT3xk=;
	b=lZGMRdr3Epp03aFk1MTSrsQVQnyxeAA6ewZYBvM+/eXJOqgjdiOEoVQOGonVMUw4PP+GkK
	fghZnO59fK1Nydvmwr/H5FXUOdyeka4h/D/JLwYBLOFYkm0oxPZLFfzJBoCzvrwnQzxV/f
	arhlar39YHBawfxMR1Y2vuCUYtEfHDc=
X-MC-Unique: tFyAzUNQPNOKZNEvDkpQQA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=fR7y2og+GQNLkB6bF6Njb+baSoGekstzngIqby7smq5sgZWo7tpGx5Vfn0DyHAkk8zNGFEEV6hhsAgo0ZBkvYoJK1kXrZUi2ZmTSDd39XrWqWKXjSd78ngz/2UxqbQG/UzVrhljsHM97paaYwIGAY+cywonp6+0ciuqjYOtmdRKWgQ3BzGiPWEH+Xsr6YwpYtNVkq2cypepZ/gjMZOaDuOfHGTMOkdDjyQdhgZla64N3sWMjJIL98gLMg+FhaZtYRFl1kAvHVHnA77VXJ1Y4+rTX59YjdrURMcWIshRuMA/ZVsFvy8SRQ8mWE5w361wS+vLIP6yD9Dw9M40SZo/uMw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=cUjpp8UpJffA04V3EbdopeSNBUXOJLg4fXPA0jqT3xk=;
 b=Ze9NZYzWFvuBtWlyBYt4iPD+swc0x2XSAiXM04SK7yK5Fpq51nfnCdBwGB4DHz4KHFBLfsksi6s8DvwW3+iKHbHIJwd0RWIJqBN5cqx/Ng9Adohx/B1zX0NXWCHCyid//Lg6abN0USLwKh9WnQjw6I5S3vJ4ZWatO+rx0WmMGcI4o+JIrSP5U45Y3Q2GSixkinuFpd3AI3DkNWe4DQpiCQ4U1hf+rxaVA3jPjn/IYPc2kl8xCXmJQKjb33ULgPmDwy3IAbDqV9RPOV/exm3GyrMpx1MkR0Isn6pktxH/pvWWIoFLLWui91GNGMoJT6jtmUFm9SVxOP/EQtMwHIGXQg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <c2c185cb-2368-cd61-df72-7792b075746e@suse.com>
Date: Mon, 7 Feb 2022 11:46:36 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH] xen/public: partially revert commit 7c7f7e8fba01
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220207103613.32260-1-jgross@suse.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220207103613.32260-1-jgross@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0346.eurprd06.prod.outlook.com
 (2603:10a6:20b:466::21) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 3308b0f8-e465-4ccc-8a7c-08d9ea271eb4
X-MS-TrafficTypeDiagnostic: DU0PR04MB9444:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<DU0PR04MB9444ABAB934ACCB90AF8A10EB32C9@DU0PR04MB9444.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	FKBg1Y1MognvSzW0Q4rkJmhaWJxxwOUbYYMXzJeOrvCZzho7mQjV+VT+Yqjive50sPr7aqE6gz715M1iu97865sPsdOZTpEBMRamDLQEbPv94637yyCGLB07RK89FIvfSVXUgw7ifDpq6pnGZ8U8us8GsnrgKQq8x85x+CbCyOYhXQfo4WRs7pzRcmnQYzc68AlUILujNWCDfV7VXXX9TS0nJ05UFLsxRvwUpoxKtJFDFeCG9lFe80SVstDAs1MrIggysD2t22O47d301miEaUOdt67MSpSFR/eMLPFyg8w+E7fUKxLPELMiIGSrov8ExKiCd0he6pJk/OxOupBAxg1OdA3XsQtWI0d1AV4DKb1cfajprCksnPYDVFbvkXGhpxbs343oePlCJryhvTEQqVdOGippNagaZURC8mfPCq1LK96lZ53zWgwCujxOn+WhMW7G/yCh/LfUfOJLkazQI4nzHBkT6qwu3Qz8u5cCJLR7DIUoqNLKuhMaRxG7Vs6hSTrFg6OV9dNuTMsOQGoScecilIKmk/V8Tcfwb6eRMqtili+SqaBq6BRDrRwBt17MOiOjFNOhAit9Eef4UgvqgcXBQS2wpGWtg31uCG8PqyyTl1yE+1c4rQ3/XVgOy8MT1FWWJyX24OBoVGkgb8Nf5DWl22bjBUPCSsNb+oUcOvdiYO2fmeNH+Nvag9obtY5RV9fBy0JBenuRNWnStbz/SGZDqC/couIV8Ds3ZCIWCCbrTWrJWaAKSTwiAYY5cPjUhH7ntt+6L4e7p2FPQeOwjQ==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2906002)(86362001)(2616005)(26005)(6636002)(316002)(186003)(37006003)(54906003)(508600001)(38100700002)(6512007)(6862004)(4326008)(6506007)(8676002)(66556008)(6666004)(5660300002)(66476007)(31696002)(8936002)(66946007)(53546011)(31686004)(6486002)(36756003)(83380400001)(98903001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?SDJsS2NqRTgxd0gybWpXQWR5bXhtOUUxTDE4Uzl3QTlaME41YWQ1eEsrQzdy?=
 =?utf-8?B?ZkFlQUhKckFxL1RQRTl1RzhGRmpYU0lJdnVaVytob0lzR1hwUHpyTWd5Wnd1?=
 =?utf-8?B?dmlsVmkrVG81czhtaEVHdjErR0xvMmNHZFN3bUdlQ3lLQitERmJGTXlUZDVK?=
 =?utf-8?B?VXhsbmdydzB4SnJlRFpuVXBSc09QSFVpbU54RW9SNHdBQjhkQ0VwWDdOaHhv?=
 =?utf-8?B?N1ZWSzRHdVJ1dWZrTlhqeStwbVoxYWdFT1dnVnlVZEpyU2pQcUhXc0JWeXhF?=
 =?utf-8?B?ajNlTFltRnpzU0lGaXQrYkp0OXBQaHU2MTZZMkhxK1RrL3dSdVMwUnJzVUVK?=
 =?utf-8?B?cmxrVzk4aDg0RktUQ29ESUJFUVZ5WHk3YWRETUcxV0NIMXlEL1ZVQzVzMEE5?=
 =?utf-8?B?MVNJYjdQNkFjU2FZZU1LU0U4Z2hCYnRZRm5QOWp5Mm5QN0lPbVp3SEc0VUZC?=
 =?utf-8?B?c1dZQzlwbEFGOVFkaTJxRmdza09vV0FjK0ZYd0NVUUJpYUJiQzAxQm5LZ1Vz?=
 =?utf-8?B?cXhqSTZoRU1OTkpzMDRvVjBhNDJTd0NKQWhseHh5ZGoyb1plTVg2RVU4a0pp?=
 =?utf-8?B?Q2NYY3NvZzhseFBFZ1QzYStlTWVsb1lYSVhWenZwanE5YlpHOFRBL05LN0VS?=
 =?utf-8?B?L0NLcUxBMmVZVGlqbXJzZTArelowL2x4b05KcU9kMTZkL00wZEF4Rlh5Mlkv?=
 =?utf-8?B?cFk1V3V5SHNNRWlrYldnUFphUXlpdENrSlFYT2ZmeXpEcjM3RHBMYWVJTG5W?=
 =?utf-8?B?Q1N4eTdSK01GaTFNeW5uaWx3VTV1MHh2TzlzQ3VFVzlSMytZZ21mdTBBYms2?=
 =?utf-8?B?TkR0M3Ava3N3N1IxdTJuWUZ5SXk0bk1ueU1yRzVzMXl4ZVhpY1BCcnI3T2E3?=
 =?utf-8?B?Y25udzhVTGdHOUpWVlBHMFhVeHB5cGp4cEE5SzNVWGFrOWtxcDRxUnhHU2d6?=
 =?utf-8?B?MnphV2ZRWFg5RVcwU1VmRlhuRmZFcmg1OHFnSVdlSXZacStTa0V2UnJ1UjdT?=
 =?utf-8?B?L3JSSVoxOVdDak84OG1lalR5TkR2VGFWekR0eHdjeGhEMWZIUkZ4MkJxc1hK?=
 =?utf-8?B?bnZ0TGJUT1AwT25NeUU0SjNVY1BJdnMwbzBOemN6c1ZuSDJieGRBOEVtS0sr?=
 =?utf-8?B?OVVhajZPRkl6YW8rVHdDVnFBRUxhMHpMZjZkMjc2U25CY0FnYWhOSmJvUHc0?=
 =?utf-8?B?ZTdQWHFYY0NmTHZSZWY1dDZoclBzVVNHNEJRd2E1MEdBNW1VeEdBYU1md1F2?=
 =?utf-8?B?K25BS0dhSk14WVdFVFZVYURSbUIzeHBicVJacW5OekliVjdjN3Zqc3htUmFt?=
 =?utf-8?B?RlVqY0VNSm40Rmszc2pxeHhCaXZpTjdUM2RWR3A5cktIUU04cDRZOHorMkJ0?=
 =?utf-8?B?OEdNYitYQ0w3RjF4RUJRU1RBVExESXFDN1VRSldMSnVKd0ZoN3h4TUJKZXF2?=
 =?utf-8?B?WTVLL2VseWdtcWxVcStzbUFIWFY1SldZZjNJVk80VWZZb2Q2bWFhYVEwTFFk?=
 =?utf-8?B?QnAyM2FJYjdNMHphMUYvd0VrOU1IQVhMZGNUaVFFS20wN1NUck10TEFsUGJ2?=
 =?utf-8?B?UEVjaU5aWWMwWjhPaS9EUGpGaVA2TnI0YWZXZWxsQ0pIdEhHZFRCYk5mSjhE?=
 =?utf-8?B?QkNTNmxtWkhGN0ZUOXVPa0NVWVBZQ2lhbUt3Q3hYNjJ6eVRkT3RCQ3lTSStp?=
 =?utf-8?B?ekFjQVFvckJZUGs0REZ1bzl6STFONy9Ra2tDOTVqZDJRMlU5WGtQSEo1QXZa?=
 =?utf-8?B?ZXhQMkFDVGYyWk0vWW9tWDBCNzB6MFNoZHlUZEpJKy90a2syMm5jL04yRHlC?=
 =?utf-8?B?NTRVL0FBeEhaVVhJTENMdUNvNzQ2aGlVRW9Sbmw5clRnTXI5OS9FMW1FSFNW?=
 =?utf-8?B?NmUyVytNUHpFUzdaODBwTEh1L0tCWmZSTHhNLzEyaEtxWnhjVGs3RUphU3ha?=
 =?utf-8?B?RTJMSnVkdmFmSW8xNkgwRm9FaHF6amwvaHZwbDZQMUpxcFpkd0NXS09YSjdB?=
 =?utf-8?B?YUQwQ1hCMUtFdnJwVzZwOHVhb3JsTjUwV2tFTld0akdLYW16cGEwdDBvMVhU?=
 =?utf-8?B?ZzBOQUtyS3U3UHBRQnJpbjdGbVE2MDVDMGtOcUFjQTZES1FyRTN2UHpQeU1r?=
 =?utf-8?B?akp6YlhHY1NmMDBQcS93b2kzTjEwMGtQdGJDOUJycFg2SXl1RTlENGJxRUZF?=
 =?utf-8?Q?s5lIzOtZ7NKtVBbcm1QGHhQ=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3308b0f8-e465-4ccc-8a7c-08d9ea271eb4
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2022 10:46:39.1751
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: z07LEEl9N9vR+VwZ6gKU5Gy7fdWI2hlFrlHyaYymYQFAkSWzjuJKKDp1CpeVhKMkLJOv7yAPJTWPQ3eAUdJ+MA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR04MB9444

On 07.02.2022 11:36, Juergen Gross wrote:
> Commit 7c7f7e8fba01 changed xen/include/public/memory.h in an incompatible
> way. Unfortunately the changed parts were already in use in the Linux
> kernel, so an update of the header in the kernel would result in a build
> breakage.
> 
> Even when removing its usage from the kernel the used flag bit should be
> marked as reserved in order to avoid to give it a different semantic in
> the future.
> 
> Do a partial revert of said commit in order to enable the kernel to take
> an updated version of memory.h.

I don't think it should be a partial revert, and as said on irc I'm of
the opinion that ...

> Fixes: 7c7f7e8fba01 ("include/public/memory.h: remove the XENMEM_rsrc_acq_caller_owned flag")

... it's 0e2e54966af5 which should have taken measures to protect
against re-use of the flag as an output.

> --- a/xen/include/public/memory.h
> +++ b/xen/include/public/memory.h
> @@ -662,7 +662,17 @@ struct xen_mem_acquire_resource {
>       * two calls.
>       */
>      uint32_t nr_frames;
> -    uint32_t pad;
> +
> +    /*
> +     * OUT - Must be zero on entry. On return this may contain a bitwise
> +     *       OR of the following values.
> +     */
> +    uint32_t flags;
> +
> +    /* No longer supported - will be never set */
> +#define _XENMEM_rsrc_acq_caller_owned 0
> +#define XENMEM_rsrc_acq_caller_owned (1u << _XENMEM_rsrc_acq_caller_owned)

I think this goes too far: Neither do we want to re-introduce the
#define-s, nor should we re-fix the purpose of the padding field
to be OUT (only). All we need to make sure is that the field
coming in as zero won't get responded to by setting bit 0 of it.
Imo this can only reasonably be done by way of adding a comment.
This comment may, in turn, mention XENMEM_rsrc_acq_caller_owned
of course.

Btw., if the field was to become OUT-only again, I think you'd
also need to revert the change to xen/common/compat/memory.c. At
least to not leave a trap for someone to later fall into.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 07 10:57:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 10:57:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266713.460413 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH1hb-0001t8-7M; Mon, 07 Feb 2022 10:56:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266713.460413; Mon, 07 Feb 2022 10:56:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH1hb-0001t1-3z; Mon, 07 Feb 2022 10:56:59 +0000
Received: by outflank-mailman (input) for mailman id 266713;
 Mon, 07 Feb 2022 10:56:57 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=H0qh=SW=linaro.org=alex.bennee@srs-se1.protection.inumbo.net>)
 id 1nH1hZ-0001sl-1m
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 10:56:57 +0000
Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com
 [2a00:1450:4864:20::536])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a9ff72c3-8804-11ec-8eb8-a37418f5ba1a;
 Mon, 07 Feb 2022 11:56:55 +0100 (CET)
Received: by mail-ed1-x536.google.com with SMTP id w14so29120157edd.10
 for <xen-devel@lists.xenproject.org>; Mon, 07 Feb 2022 02:56:55 -0800 (PST)
Received: from zen.linaroharston ([51.148.130.216])
 by smtp.gmail.com with ESMTPSA id e10sm1298608ejx.53.2022.02.07.02.56.53
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Mon, 07 Feb 2022 02:56:53 -0800 (PST)
Received: from zen (localhost [127.0.0.1])
 by zen.linaroharston (Postfix) with ESMTP id 5DE631FFB7;
 Mon,  7 Feb 2022 10:56:53 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a9ff72c3-8804-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=user-agent:from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=DYQAeF5GF08SrkAlmINB1uRvHTmAMikhM34e6HF23rU=;
        b=j+a4GsF1L5bMH9MhCVgPtvDz//jf68ODPuhV+N3oSsFIR2maaZouWsPgO3Ag8he94s
         2Q2khjCkLe9rrZwcng5+sMORzsg9HkNkS/H/fr3S4NfKQj3+/VuhAgdTpeGoDtNwX5jC
         1C1nTw/Azv9gXb8GdH5vlmb7fgVovmwoQK/N3SFDKSJ1fJzEuJ/tEdnQSVARPFyp+nuf
         mgJ6cPoXKNTke7xcA7fEB6tTbd60VeqpUQ2+uzmO1isJb1TI0kxGwhyQnuu4siRuD5L6
         x/iuToRqvGQ1pd3ZpGGUdy8AbmknkTLYPi8OXRw6TGL4qW2mmi451We/9IagJtAE2Akk
         AylQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:user-agent:from:to:cc:subject:date:message-id
         :mime-version:content-transfer-encoding;
        bh=DYQAeF5GF08SrkAlmINB1uRvHTmAMikhM34e6HF23rU=;
        b=zz7rrOk+00UvNk6tQGnGFWFuimm7fLoZlZqzRnGG/cAXOGBIOXYpwZoj6VBpqsUBmZ
         3xXh0hyKw/QOu5ZZJsJi8qPI2qn5P5ZrU7CG5yZ62LsRFr6lOJZVKvq6ZGl00algARig
         ozOu63EU+GPaMi+0uEDvaJ1XOydyLXsJwcS93xe+/kTjhN1DlzsgLSfU63xj3ksCK/1Y
         +m8I7V0fZ6Fmy7w96JQVuU3b+406Q385JHsxyR8y2L8J5pf+zDgHm0KEgfMH2sHDe1Bs
         5Y2mCqleaEnruzLLqgWTmx5GoDRqK6RoW3zfD16VzChaKKyeDGPREPFsWiKJXhI25qtt
         Stdw==
X-Gm-Message-State: AOAM533BcXQlghrY7QLfnY/jDA9tS60ACrDanWTy7Cv/ymqhJU72IPHz
	OPDKMP829S+7Jzg2Njw6Bqm2yw==
X-Google-Smtp-Source: ABdhPJwcmRzFt4vbaC5A6qq6GvCXeou2Trroty8hockxfYbDxVusmIg9JoKbVn/d5PvLy9ofuC60WA==
X-Received: by 2002:a05:6402:1d8b:: with SMTP id dk11mr7576789edb.246.1644231414809;
        Mon, 07 Feb 2022 02:56:54 -0800 (PST)
User-agent: mu4e 1.7.7; emacs 28.0.91
From: Alex =?utf-8?Q?Benn=C3=A9e?= <alex.bennee@linaro.org>
To: Stefano Stabellini <stefano.stabellini@xilinx.com>, Vincent Guittot
 <vincent.guittot@linaro.org>
Cc: stratos-dev@op-lists.linaro.org, xen-devel@lists.xenproject.org, AKASHI
 Takahiro <takahiro.akashi@linaro.org>, Arnd Bergmann
 <arnd.bergmann@linaro.org>, Christopher Clark
 <christopher.w.clark@gmail.com>, Dmytro Firsov <dmytro_firsov@epam.com>,
 Julien Grall <julien@xen.org>, Volodymyr Babchuk
 <Volodymyr_Babchuk@epam.com>
Subject: Metadata and signalling channels for Zephyr virtio-backends on Xen
Date: Mon, 07 Feb 2022 10:20:49 +0000
Message-ID: <87h79bgd1m.fsf@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


Hi Stefano,

Vincent gave an update on his virtio-scmi work at the last Stratos sync
call and the discussion moved onto next steps. Currently the demo setup
is intermediated by a double-ended vhost-user daemon running on the
devbox acting as a go between a number of QEMU instances representing
the front and back-ends. You can view the architecture with Vincents
diagram here:

  https://docs.google.com/drawings/d/1YSuJUSjEdTi2oEUq4oG4A9pBKSEJTAp6hhcHK=
KhmYHs/edit?usp=3Dsharing

The key virtq handling is done over the special carve outs of shared
memory between the front end and guest. However the signalling is
currently over a virtio device on the backend. This is useful for the
PoC but obviously in a real system we don't have a hidden POSIX system
acting as a go between not to mention the additional latency it causes
with all those context switches.

I was hoping we could get some more of the Xen experts to the next
Stratos sync (17th Feb) to go over approaches for a properly hosted on
Xen approach. From my recollection (Vincent please correct me if I'm
wrong) of last week the issues that need solving are:

 * How to handle configuration steps as FE guests come up

The SCMI server will be a long running persistent backend because it is
managing real HW resources. However the guests may be ephemeral (or just
restarted) so we can't just hard-code everything in a DTB. While the
virtio-negotiation in the config space covers most things we still need
information like where in the guests address space the shared memory
lives and at what offset into that the queues are created. As far as I'm
aware the canonical source of domain information is XenStore
(https://wiki.xenproject.org/wiki/XenStore) but this relies on a Dom0
type approach. Is there an alternative for dom0less systems or do we
need a dom0-light approach, for example using STR-21 (Ensure Zephyr can
run cleanly as a Dom0 guest) providing just enough services for FE's to
register metadata and BE's to read it?

 * How to handle mapping of memory

AIUI the Xen model is the FE guest explicitly makes grant table requests
to expose portions of it's memory to other domains. Can the BE query the
hypervisor itself to discover the available grants or does it require
coordination with Dom0/XenStore for that information to be available to
the BE domain?

 * How to handle signalling

I guess this requires a minimal implementation of the IOREQ calls for
Zephyr so we can register the handler in the backend? Does the IOREQ API
allow for a IPI style notifications using the global GIC IRQs?

Forgive the incomplete notes from the Stratos sync, I was trying to type
while participating in the discussion so hopefully this email captures
what was missed:

  https://linaro.atlassian.net/wiki/spaces/STR/pages/28682518685/2022-02-03=
+Project+Stratos+Sync+Meeting+Notes

Vincent, anything to add?

--=20
Alex Benn=C3=A9e


From xen-devel-bounces@lists.xenproject.org Mon Feb 07 11:00:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 11:00:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266721.460424 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH1l7-0003HJ-O2; Mon, 07 Feb 2022 11:00:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266721.460424; Mon, 07 Feb 2022 11:00:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH1l7-0003HC-KR; Mon, 07 Feb 2022 11:00:37 +0000
Received: by outflank-mailman (input) for mailman id 266721;
 Mon, 07 Feb 2022 11:00:36 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=ddl1=SW=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nH1l6-0003H6-TL
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 11:00:36 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2d65cf19-8805-11ec-8eb8-a37418f5ba1a;
 Mon, 07 Feb 2022 12:00:36 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 8C3F51F37F;
 Mon,  7 Feb 2022 11:00:35 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5495A13B95;
 Mon,  7 Feb 2022 11:00:35 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id JcwYE9P7AGJbTwAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 07 Feb 2022 11:00:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2d65cf19-8805-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1644231635; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=Skg+/3yiCn3aEwOF3aD7Xz6Cd0t9r2OO6orxKa1AUks=;
	b=QYNUypcub+itCu6TwFmFvd9BzuPnAm+XZ8TWeUbkr6kSsxDJOBHfaPvt8fMbckO7d1GM11
	JKdbfI8ZODDsv7nEAqruAHmSQm2pneYE45+d4TrGKY7SkN06LC0UZBpyD1ffAgd92NSpGh
	YeBlDr1B9yaIfpsQxYLBJyc/jfScm1c=
Message-ID: <9bba716a-8ea3-a104-65d4-28d62f69f22b@suse.com>
Date: Mon, 7 Feb 2022 12:00:34 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Content-Language: en-US
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220207103613.32260-1-jgross@suse.com>
 <c2c185cb-2368-cd61-df72-7792b075746e@suse.com>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH] xen/public: partially revert commit 7c7f7e8fba01
In-Reply-To: <c2c185cb-2368-cd61-df72-7792b075746e@suse.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------kRvLf9500P84AtVUv0H2oPC4"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------kRvLf9500P84AtVUv0H2oPC4
Content-Type: multipart/mixed; boundary="------------tZCqQVhm4NKIkrAjEnfuBba0";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
Message-ID: <9bba716a-8ea3-a104-65d4-28d62f69f22b@suse.com>
Subject: Re: [PATCH] xen/public: partially revert commit 7c7f7e8fba01
References: <20220207103613.32260-1-jgross@suse.com>
 <c2c185cb-2368-cd61-df72-7792b075746e@suse.com>
In-Reply-To: <c2c185cb-2368-cd61-df72-7792b075746e@suse.com>

--------------tZCqQVhm4NKIkrAjEnfuBba0
Content-Type: multipart/mixed; boundary="------------vQGj0YOBxQIpqJBzwjn3IzG3"

--------------vQGj0YOBxQIpqJBzwjn3IzG3
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMDcuMDIuMjIgMTE6NDYsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAwNy4wMi4yMDIy
IDExOjM2LCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gQ29tbWl0IDdjN2Y3ZThmYmEwMSBj
aGFuZ2VkIHhlbi9pbmNsdWRlL3B1YmxpYy9tZW1vcnkuaCBpbiBhbiBpbmNvbXBhdGlibGUN
Cj4+IHdheS4gVW5mb3J0dW5hdGVseSB0aGUgY2hhbmdlZCBwYXJ0cyB3ZXJlIGFscmVhZHkg
aW4gdXNlIGluIHRoZSBMaW51eA0KPj4ga2VybmVsLCBzbyBhbiB1cGRhdGUgb2YgdGhlIGhl
YWRlciBpbiB0aGUga2VybmVsIHdvdWxkIHJlc3VsdCBpbiBhIGJ1aWxkDQo+PiBicmVha2Fn
ZS4NCj4+DQo+PiBFdmVuIHdoZW4gcmVtb3ZpbmcgaXRzIHVzYWdlIGZyb20gdGhlIGtlcm5l
bCB0aGUgdXNlZCBmbGFnIGJpdCBzaG91bGQgYmUNCj4+IG1hcmtlZCBhcyByZXNlcnZlZCBp
biBvcmRlciB0byBhdm9pZCB0byBnaXZlIGl0IGEgZGlmZmVyZW50IHNlbWFudGljIGluDQo+
PiB0aGUgZnV0dXJlLg0KPj4NCj4+IERvIGEgcGFydGlhbCByZXZlcnQgb2Ygc2FpZCBjb21t
aXQgaW4gb3JkZXIgdG8gZW5hYmxlIHRoZSBrZXJuZWwgdG8gdGFrZQ0KPj4gYW4gdXBkYXRl
ZCB2ZXJzaW9uIG9mIG1lbW9yeS5oLg0KPiANCj4gSSBkb24ndCB0aGluayBpdCBzaG91bGQg
YmUgYSBwYXJ0aWFsIHJldmVydCwgYW5kIGFzIHNhaWQgb24gaXJjIEknbSBvZg0KPiB0aGUg
b3BpbmlvbiB0aGF0IC4uLg0KPiANCj4+IEZpeGVzOiA3YzdmN2U4ZmJhMDEgKCJpbmNsdWRl
L3B1YmxpYy9tZW1vcnkuaDogcmVtb3ZlIHRoZSBYRU5NRU1fcnNyY19hY3FfY2FsbGVyX293
bmVkIGZsYWciKQ0KPiANCj4gLi4uIGl0J3MgMGUyZTU0OTY2YWY1IHdoaWNoIHNob3VsZCBo
YXZlIHRha2VuIG1lYXN1cmVzIHRvIHByb3RlY3QNCj4gYWdhaW5zdCByZS11c2Ugb2YgdGhl
IGZsYWcgYXMgYW4gb3V0cHV0Lg0KDQpUaGUgZGVzaWduIG9mIHRoYXQgZmVhdHVyZSB3YXMg
Zmxhd2VkIGZyb20gdGhlIGJlZ2lubmluZywgYXMgaXQgd2FzIHVzZWQNCmluIHRoZSBrZXJu
ZWwgcmlnaHQgYXdheS4gU28gSSB0aGluayB0aGUgaW5pdGlhbCByZXZlcnQgd2FzIHRoZQ0K
ZWZmZWN0aXZlIHN0YXJ0IG9mIHRoZSBwcm9ibGVtLg0KDQo+IA0KPj4gLS0tIGEveGVuL2lu
Y2x1ZGUvcHVibGljL21lbW9yeS5oDQo+PiArKysgYi94ZW4vaW5jbHVkZS9wdWJsaWMvbWVt
b3J5LmgNCj4+IEBAIC02NjIsNyArNjYyLDE3IEBAIHN0cnVjdCB4ZW5fbWVtX2FjcXVpcmVf
cmVzb3VyY2Ugew0KPj4gICAgICAgICogdHdvIGNhbGxzLg0KPj4gICAgICAgICovDQo+PiAg
ICAgICB1aW50MzJfdCBucl9mcmFtZXM7DQo+PiAtICAgIHVpbnQzMl90IHBhZDsNCj4+ICsN
Cj4+ICsgICAgLyoNCj4+ICsgICAgICogT1VUIC0gTXVzdCBiZSB6ZXJvIG9uIGVudHJ5LiBP
biByZXR1cm4gdGhpcyBtYXkgY29udGFpbiBhIGJpdHdpc2UNCj4+ICsgICAgICogICAgICAg
T1Igb2YgdGhlIGZvbGxvd2luZyB2YWx1ZXMuDQo+PiArICAgICAqLw0KPj4gKyAgICB1aW50
MzJfdCBmbGFnczsNCj4+ICsNCj4+ICsgICAgLyogTm8gbG9uZ2VyIHN1cHBvcnRlZCAtIHdp
bGwgYmUgbmV2ZXIgc2V0ICovDQo+PiArI2RlZmluZSBfWEVOTUVNX3JzcmNfYWNxX2NhbGxl
cl9vd25lZCAwDQo+PiArI2RlZmluZSBYRU5NRU1fcnNyY19hY3FfY2FsbGVyX293bmVkICgx
dSA8PCBfWEVOTUVNX3JzcmNfYWNxX2NhbGxlcl9vd25lZCkNCj4gDQo+IEkgdGhpbmsgdGhp
cyBnb2VzIHRvbyBmYXI6IE5laXRoZXIgZG8gd2Ugd2FudCB0byByZS1pbnRyb2R1Y2UgdGhl
DQo+ICNkZWZpbmUtcywgbm9yIHNob3VsZCB3ZSByZS1maXggdGhlIHB1cnBvc2Ugb2YgdGhl
IHBhZGRpbmcgZmllbGQNCj4gdG8gYmUgT1VUIChvbmx5KS4gQWxsIHdlIG5lZWQgdG8gbWFr
ZSBzdXJlIGlzIHRoYXQgdGhlIGZpZWxkDQo+IGNvbWluZyBpbiBhcyB6ZXJvIHdvbid0IGdl
dCByZXNwb25kZWQgdG8gYnkgc2V0dGluZyBiaXQgMCBvZiBpdC4NCj4gSW1vIHRoaXMgY2Fu
IG9ubHkgcmVhc29uYWJseSBiZSBkb25lIGJ5IHdheSBvZiBhZGRpbmcgYSBjb21tZW50Lg0K
PiBUaGlzIGNvbW1lbnQgbWF5LCBpbiB0dXJuLCBtZW50aW9uIFhFTk1FTV9yc3JjX2FjcV9j
YWxsZXJfb3duZWQNCj4gb2YgY291cnNlLg0KDQpUaGUga2VybmVsIGNvdWxkIGJlIGNoYW5n
ZWQgdG8gbm8gbG9uZ2VyIHVzZSB0aGF0ICNkZWZpbmUgYmVmb3JlDQp1cGRhdGluZyB0aGUg
aGVhZGVyIGZyb20gWGVuLCBidXQgYXJlIHdlIHJlYWxseSBzdXJlIHRoZXJlIGFyZSBubw0K
b3RoZXIgdXNlcnMsIHRvbz8NCg0KSSdtIGZpbmUgZG9pbmcgaXQgdGhhdCB3YXksIGJ1dCBJ
IHRoaW5rIEkgc2hvdWxkIHNwZWxsIG91dCB0aGUNCmNvbnNlcXVlbmNlcyBvZiB0aGF0IGRl
Y2lzaW9uLg0KDQo+IEJ0dy4sIGlmIHRoZSBmaWVsZCB3YXMgdG8gYmVjb21lIE9VVC1vbmx5
IGFnYWluLCBJIHRoaW5rIHlvdSdkDQo+IGFsc28gbmVlZCB0byByZXZlcnQgdGhlIGNoYW5n
ZSB0byB4ZW4vY29tbW9uL2NvbXBhdC9tZW1vcnkuYy4gQXQNCj4gbGVhc3QgdG8gbm90IGxl
YXZlIGEgdHJhcCBmb3Igc29tZW9uZSB0byBsYXRlciBmYWxsIGludG8uDQoNCk9rYXksIGlm
IHlvdSBsaWtlIHRoYXQgYmV0dGVyLg0KDQoNCkp1ZXJnZW4NCg==
--------------vQGj0YOBxQIpqJBzwjn3IzG3
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------vQGj0YOBxQIpqJBzwjn3IzG3--

--------------tZCqQVhm4NKIkrAjEnfuBba0--

--------------kRvLf9500P84AtVUv0H2oPC4
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmIA+9IFAwAAAAAACgkQsN6d1ii/Ey/+
KAf/cejz/uXT10FFCnIp7Z81h8RfqRT8L2yktt5cQOSo1Hh07q0gQDrFRfESu6Pi1Zwofj54i0BU
a/AHcFwjjulBa6l9lMncLM4dLGfNcIsCsbKD1EHAZngCk/R0AGUzWYA+jX3MLfpzYUQAJioWzd/e
YNlx45lE44nYZmNT5fVH/W+RqaEAIR4z0Z1I9Kdk9fGt8QzN0ib5gkvTYRnJoVud7U1bUzHhWWyc
bPuyOgJUR68zoAvwP5O4ajg5sdxT3KHf7JE9M52NR/j5K0FB5Aox2BokKeo2EwBhKWXGaF46+jyH
mdujhnoEh5/n5zarUqQM01zU3tSJozvoIW4ZJ5GtCA==
=BZ0j
-----END PGP SIGNATURE-----

--------------kRvLf9500P84AtVUv0H2oPC4--


From xen-devel-bounces@lists.xenproject.org Mon Feb 07 11:20:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 11:20:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266733.460434 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH24U-0005gE-Ip; Mon, 07 Feb 2022 11:20:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266733.460434; Mon, 07 Feb 2022 11:20:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH24U-0005g7-Fk; Mon, 07 Feb 2022 11:20:38 +0000
Received: by outflank-mailman (input) for mailman id 266733;
 Mon, 07 Feb 2022 11:20:37 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=F54n=SW=epam.com=prvs=403792ff6c=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nH24T-0005g1-7D
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 11:20:37 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f6c29ab6-8807-11ec-8eb8-a37418f5ba1a;
 Mon, 07 Feb 2022 12:20:34 +0100 (CET)
Received: from pps.filterd (m0174677.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 217ANgpu010764;
 Mon, 7 Feb 2022 11:20:24 GMT
Received: from eur03-db5-obe.outbound.protection.outlook.com
 (mail-db5eur03lp2054.outbound.protection.outlook.com [104.47.10.54])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e31mpgbt4-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Mon, 07 Feb 2022 11:20:12 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by VI1PR0302MB2799.eurprd03.prod.outlook.com (2603:10a6:800:e3::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Mon, 7 Feb
 2022 11:08:39 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77%3]) with mapi id 15.20.4951.018; Mon, 7 Feb 2022
 11:08:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f6c29ab6-8807-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=eau21nHmx+VqIpeGpCEG3owgNE9cbRQo9kvDyFvpW4zefX75236XbMqwtq2orEy7qnDBZ7/cnFp87l/h6r33Wg9VMoTQTl1sJxD4KRbdS2H3AEZnxCyub1uRzJUklChqCfEuB+OLWGG9w1TWzTlFNfyvSIUflL42i+ZNv1ixeBtpMxKtBBtScWPdFh0HnGRSvcO7F76mpV6gsG/nN+n5o7s4ydK8FN0FEsH3GgtRDOxEFQsTzZMtc8dOed6SDtTjYXyXSvokECKrfkhbem2QdvHtYzXqe1HhOLqyk6W3FdkbCbI/4r/9Ln8726rTbm7kWqwlPWEFG4+wZDnWaQFKgw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ne6e1hMeSJwkPeCDDln4Jm0UqnvdDWnuRSV13DYT+oc=;
 b=Qjc/ckUlTcO5DMM6sH9lsqK+jcmL4U0eTNDs75xR9N0SWcmRrRpNgiOhQHk6eVFtcuYKDcBwwMsLpBmxExoma5nVoSGpUgw/VbCXAUTrE47uppOXk2qrU807UPcY/MPGmjAt4Bf6YlHvKsmJhxtmZK5MDiLCtIWLvhGH839eri8FT/AJzYwPAG+RkRQjSMot7/l30vgp405MEL8qlrDDsKB36zB2b7MmNEs89epOxCmdDdQRi4rtLKj6oomwmRHGekPnY86OBfA9+OCWvDjDdMNTBKtU37V4/VACTLuqw2syki8dodkg/1k+DlCfKHxYMTy765EGt1Xa9kjesB1xUg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ne6e1hMeSJwkPeCDDln4Jm0UqnvdDWnuRSV13DYT+oc=;
 b=J+d0BNpaRtt6HPtZciwlGW4cvKqC3LsJdGMkvB8BzTDIUMRpp0sQxXiKryOZtfxk2lZoHjBfTMvqz83DT42x7GvatQijTdYxqkTU68TVxauM+0hY/MhBXpZSYQ86EaiYj+LfleLT8MrAb3rklXNfHYsMf4qWr1hP4oCIbBmmxfjj0TnxaZ3j387EDlvmErscAgSY9Gi1TykwamZgKeFBEqao1ZQ4S9nAdt8HQvXLNWc/F0FGSgghjL7Xl75g5a+yDQ38nnHtSxWActEUJ9WlJxUQhUpU0ZzcPvzjDKOwo5GI3WmnRfFPPuYq2TAun+Gm9mW9+6pZGkCdfPET+coM2g==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>,
        Jan Beulich
	<jbeulich@suse.com>
CC: "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Thread-Topic: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Thread-Index: 
 AQHYGZFc/MnzQOjwVEeBBUHLSW0md6yDBUkAgAASSACAAATYAIAAD/WAgAAKNgCAAAbfgIAABnuAgAAQvgCAAAMCAIAAAY4AgAADxICAABrnAIAABAgAgAR3CoA=
Date: Mon, 7 Feb 2022 11:08:39 +0000
Message-ID: <c5fea3bb-834b-eeb7-d7a1-1ee609037a9f@epam.com>
References: <04726915-f39f-9019-436e-4399533c9fc3@suse.com>
 <9ed3f4ac-0a2d-ed45-9872-7c3f356a469e@epam.com>
 <c3a99712-cf7c-37da-aac1-f2ee00e6d53b@suse.com>
 <Yf0KcVD8W05A4fbB@Air-de-Roger>
 <1ed0e342-16cd-2f16-c05c-186667a22762@suse.com>
 <7e3562b5-fc67-f213-e872-f211450d9e2e@epam.com>
 <a8fc599c-f620-c4d1-2077-c57068f46a7f@suse.com>
 <deef8468-d607-e49e-f456-6a8013329ca1@epam.com>
 <Yf0k6aoKK5G3iad1@Air-de-Roger>
 <3ad10a99-c706-b95f-1419-2c0c7cf37d58@epam.com>
 <Yf0+3C9nF8+tewLw@Air-de-Roger>
In-Reply-To: <Yf0+3C9nF8+tewLw@Air-de-Roger>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 5a425cb8-36e4-442f-0ed8-08d9ea2a31d7
x-ms-traffictypediagnostic: VI1PR0302MB2799:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <VI1PR0302MB279956727B2933F342462575E72C9@VI1PR0302MB2799.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8273;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 6t5s7+kTMN+B631fuNGsZ/cmQ/ZidRtQPaKq3FiPNCZgaztWny4kpMJTvLuxHBxoSGtWBozYr0bRlv5Sc7damwfSJUjNGTYqfcCIK5I/DpKqD6tCUZiVBozz5/95CHjg0HSlSkqqjsXYmNda3gYvZUpFqoL5UGgE0QamiO/ml/NqTR5zxwFP952yNG0dfbJoUXjMa6LpZoE2Fp1a5rDnNaDmyPu6qeT3TTxZLlhCzrMjinwyC6lewwSPJJUTOdd1ioVOBAzQWMgetjbeYBDHf3eLBhSh345KW465cMKhk52lc31E87R9piE4OXiBn/2kkBAMHxgtUPqa3KwGpGWKi/ixotKIs/QIFX/ksGzxUWsvfe2IBBRAg+2ZrMN+yNqtygFQJYze5BO4NONS7AgIFydYFA+z5soXQe60Z7et7PwGtFxNVlXrKzmYwsVyxyLqjAN5rX3Sb/sBSOUGh6k8shX0SGvV3/xUUNuCT5YNaYAe3En7dj7zI1IbnPCIX5wKvMveab1W41N0vgF4jmbraEDj9JhLJ0HbGssA8y2+p/P7UZKIC6Yu+o4Ll8KzW1NURsGqLNcRML0ZuNpVszI42cQpXCqc51dv95gqLRYemRmDrrO3lsRzUK1mvUCxDFrZLDfPr4gO3cYYIZbVccoME/3abfITvyqU+xLdmv1R9JEy+b9SGycMsiySLBAQ2MnKD2SInto2T/j+6qAkdOCAgrOh75P/aMddQTsy0GRUWXNqYOn5rSvy3cyAh9vVPd4s
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(508600001)(122000001)(36756003)(6506007)(2906002)(6486002)(64756008)(66446008)(66476007)(66556008)(66946007)(76116006)(8676002)(8936002)(4326008)(55236004)(38100700002)(71200400001)(91956017)(86362001)(53546011)(110136005)(5660300002)(107886003)(31686004)(6512007)(38070700005)(7416002)(2616005)(26005)(30864003)(186003)(83380400001)(316002)(54906003)(31696002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?MEN4b1NkUEI4MjBLSEJUZHhNaXhxVjg0cTVERmg1M0VjM0RMcXB3NHk2ellq?=
 =?utf-8?B?UytHNUV1bHp1TlhNTjRjQjUwb29pOFl3TkZRRmZ5aTFyYkFoY1BMYjQ4M3BW?=
 =?utf-8?B?djRXakJWZDJtVTdJVEdudmVnRk41NnlkMnZVUjdvQjRHcXM0dlVvNFcwWlpW?=
 =?utf-8?B?VWNBczdVcXBvalNyYms5djlhTVpJT1FqVy81M0RmY2E5SENzckZ1VHFtanRj?=
 =?utf-8?B?NzZLZUMwK3E2M20wWVNJbE11dnU3K25HQlp5eEpEMkllWW80OWZUY0dpRUJR?=
 =?utf-8?B?NllvaU1jSmdTTWFQYitXKzFPRmhpeWlyeCt0L1RnT3lVa1ExR3gydFNBcVBt?=
 =?utf-8?B?cWczVEI4U1dnaklSdnpWWXlkbDhLd2NZVEQ3aHlZdExZL3kwc0pYYmtKRVN2?=
 =?utf-8?B?b3Vxd3lyRS9IZWNlZDRidmxVdzl4Q09VZWFmbzlWR0krc3c4QWxnSWhnZjVQ?=
 =?utf-8?B?Y3p5cGFpeFBpRGRqdGNicG1Fc0x4YVNoWm9KbHVkQXF3TlVZZzlaSTVJN044?=
 =?utf-8?B?VGRkWjc3WTlDalRZTUhNNmlsNHVtYVloaGg3UzR0MXNLSjh1QUVYR2I0Y2RY?=
 =?utf-8?B?RHhyaDdyaXc3M1pOWml2YVdvNzhnTlhXK3B4UnZjczdXaStlV3JYUkxIRTk2?=
 =?utf-8?B?U1lKN1FoR1EyV2FNVFFpWWJueTE3anhaeTZkTHRmWjVRQmd3Si9YaHU0eXZC?=
 =?utf-8?B?Vlo0VTRFRC9OcXBIRExCOEhYUHFwN3k0TW5UUFhGU0ZyNk1YUkFKNFh2bktp?=
 =?utf-8?B?aFpTdHhCQTVhN3Y4bE96ZkpHdHpOTm1wMXROWTlqdWdQRzAzc1NSbHdYcVNQ?=
 =?utf-8?B?NjI3WGJkTThyTUlIWmxXa3I2UUdTTFN2T2hXK2ZKSHp4QjVaMm5FdVdtRDMw?=
 =?utf-8?B?Vi9pM1doWFhLOGlIb0R4ZEdkSHNnVUNyMGNwUVZIL0RCMVpObEdDQmpuWmVM?=
 =?utf-8?B?NkN4MzBUWFpzQXBEVDZOemF1NTJ4YW9kNGFzZFk5N3BweC9IMTBTdldnVUFT?=
 =?utf-8?B?bStoRStZM1dBbGtPS2ZhZ3Z1NDhNZ29UVy9JV2gwc28yWSs3US91VUFhdkl1?=
 =?utf-8?B?bkkzWlU0bXBGaWpJcnRuMElzc1o2NU5OMXU0SjNvY1g3L1NEYmoxOXZYQmJw?=
 =?utf-8?B?QUpRbVF6YUltdldmY2pSeVhWejhkbFg2aUhFMVZYUFp5T1k5NVVvdUFjdnd6?=
 =?utf-8?B?RHRKQVhvU3FSdVFZWVo0LytNcmY4Nm1McGF2U08xZi9vVlJ4SUE5S1NiNTR6?=
 =?utf-8?B?SFd5cmxibnBQd2tlQzhTMnQyd0QxaDRrdlVuZFFGeFVwUlpWOWF0bmk3MENn?=
 =?utf-8?B?a0lKd2xZSFZJN0dyTkdBLzdFNVZBR29Zd0JuQlVqQzVPZy9kZjB2cWcxVUdV?=
 =?utf-8?B?UVpiZFNiVnJtdUVqOE1Fd3RuK1F5V3I4Y0JlbHV6endqWUEyUXlvZlRsNElr?=
 =?utf-8?B?dzVncHlWck9kK0E4ZnEwakdZMkRMRHVXN1BaSnRGK0ZQVG0yMFRTWkFwV3lT?=
 =?utf-8?B?TmNTS1d2dG5uSEtVTHhrb01VYzBuN0tubnpyQ2psTGJNYVNwVDhvbGNvY21B?=
 =?utf-8?B?d2U5Q2N2elY4YWpsMzFSTU9ZM0gra2lTY2NhWDhWbVBDclpnU0I0L0hEMTd2?=
 =?utf-8?B?QTM2dUZLbVJqbTkzL1VsNGljSDVPYmVydzBHcmpxak5iUERscytyYlJrL05z?=
 =?utf-8?B?YzJYbkF2U3VPQzJWUEZxekY0akNyRHpsMHVpN2p2RlNmQ2oxTDVqMTJqSEpU?=
 =?utf-8?B?ek8wUk0vRnVkcHYvU3hyOXlNVUhqbUM2R0o3N1poZ1dyUWg5UHNwOGpCQ3l5?=
 =?utf-8?B?ZDZEamI0aEhDSUVGczdpRjhIeVZTNWRwSGpZRXZHVFJXajY4TnlPT0xlcTln?=
 =?utf-8?B?djNhYi9JNmV6MyszTm1TRm5JQVhkT3JYLzZ3NktRNi80dTM5alhZK2hYL2g3?=
 =?utf-8?B?UHdDNXJjU0NXc1k3WjBiSnRaVE9XRVZRY01GSXZ1aWdZWjZ1RWpMM2ZjUzZv?=
 =?utf-8?B?M1FvVHpZampBZ3V5SjNSWnpDYmJFWitFQWdwY2ttTmxGM292WWdweTdYellX?=
 =?utf-8?B?Z2dvKzZ1eWRnbzZuV3N5U0o3VHY4b3M2bmxiY0hDY3NPbHF1OEtzSFcxV00z?=
 =?utf-8?B?OUxSQ1JObk1HbUhoSFZxd1ROb3lYODk2dXZwTzlWWGh5dUZVL2VCR0YwU2Nz?=
 =?utf-8?B?NitqWW1uNUMxeldiRlJHTXNtK0Y4VzRSNkVjT1RZQXZDNlR2ZkxCcXR3SldN?=
 =?utf-8?B?ODkydDBRcERoelZLR2t4TzFCRVJQTHB3Sk54K2hHR3FOL2xCb1BWc0UwOXZG?=
 =?utf-8?B?OUh0RHk4NFlDU1ZneEhtcG1jcExWSlhlSER4NTkvZURzdDk5dEZ6Zz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <7BD7600184D77B45AB2FF7FC9C32EDA0@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5a425cb8-36e4-442f-0ed8-08d9ea2a31d7
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Feb 2022 11:08:39.4089
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: MdagILXLYYq/UG5OTdXQYrtNcW41+tV+AXwJ5FjrLXAgNYU/c+5TfTwshC6P3MXsDZrME1W5VwFXdYewTThfmH6cWHOBYogCW12m8mtUvcXf3/jkFaSOgniElkPRupdW
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0302MB2799
X-Proofpoint-GUID: RTo6LQex5kA0VKPFvrbS1XwNWNzkAa7Y
X-Proofpoint-ORIG-GUID: RTo6LQex5kA0VKPFvrbS1XwNWNzkAa7Y
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-07_04,2022-02-07_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 malwarescore=0
 mlxlogscore=999 lowpriorityscore=0 suspectscore=0 spamscore=0
 priorityscore=1501 impostorscore=0 bulkscore=0 clxscore=1015 adultscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202070074

SGVsbG8sDQoNCk9uIDA0LjAyLjIyIDE2OjU3LCBSb2dlciBQYXUgTW9ubsOpIHdyb3RlOg0KPiBP
biBGcmksIEZlYiAwNCwgMjAyMiBhdCAwMjo0MzowN1BNICswMDAwLCBPbGVrc2FuZHIgQW5kcnVz
aGNoZW5rbyB3cm90ZToNCj4+DQo+PiBPbiAwNC4wMi4yMiAxNTowNiwgUm9nZXIgUGF1IE1vbm7D
qSB3cm90ZToNCj4+PiBPbiBGcmksIEZlYiAwNCwgMjAyMiBhdCAxMjo1MzoyMFBNICswMDAwLCBP
bGVrc2FuZHIgQW5kcnVzaGNoZW5rbyB3cm90ZToNCj4+Pj4gT24gMDQuMDIuMjIgMTQ6NDcsIEph
biBCZXVsaWNoIHdyb3RlOg0KPj4+Pj4gT24gMDQuMDIuMjAyMiAxMzozNywgT2xla3NhbmRyIEFu
ZHJ1c2hjaGVua28gd3JvdGU6DQo+Pj4+Pj4gT24gMDQuMDIuMjIgMTM6MzcsIEphbiBCZXVsaWNo
IHdyb3RlOg0KPj4+Pj4+PiBPbiAwNC4wMi4yMDIyIDEyOjEzLCBSb2dlciBQYXUgTW9ubsOpIHdy
b3RlOg0KPj4+Pj4+Pj4gT24gRnJpLCBGZWIgMDQsIDIwMjIgYXQgMTE6NDk6MThBTSArMDEwMCwg
SmFuIEJldWxpY2ggd3JvdGU6DQo+Pj4+Pj4+Pj4gT24gMDQuMDIuMjAyMiAxMToxMiwgT2xla3Nh
bmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+Pj4+Pj4+Pj4+IE9uIDA0LjAyLjIyIDExOjE1LCBK
YW4gQmV1bGljaCB3cm90ZToNCj4+Pj4+Pj4+Pj4+IE9uIDA0LjAyLjIwMjIgMDk6NTgsIE9sZWtz
YW5kciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4+Pj4+Pj4+Pj4+IE9uIDA0LjAyLjIyIDA5OjUy
LCBKYW4gQmV1bGljaCB3cm90ZToNCj4+Pj4+Pj4+Pj4+Pj4gT24gMDQuMDIuMjAyMiAwNzozNCwg
T2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+Pj4+Pj4+Pj4+Pj4+PiBAQCAtMjg1LDYg
KzI4NiwxMiBAQCBzdGF0aWMgaW50IG1vZGlmeV9iYXJzKGNvbnN0IHN0cnVjdCBwY2lfZGV2ICpw
ZGV2LCB1aW50MTZfdCBjbWQsIGJvb2wgcm9tX29ubHkpDQo+Pj4+Pj4+Pj4+Pj4+PiAgICAgICAg
ICAgICAgICAgICAgICAgIGNvbnRpbnVlOw0KPj4+Pj4+Pj4+Pj4+Pj4gICAgICAgICAgICAgICAg
fQ0KPj4+Pj4+Pj4+Pj4+Pj4gICAgICAgIA0KPj4+Pj4+Pj4+Pj4+Pj4gKyAgICAgICAgc3Bpbl9s
b2NrKCZ0bXAtPnZwY2lfbG9jayk7DQo+Pj4+Pj4+Pj4+Pj4+PiArICAgICAgICBpZiAoICF0bXAt
PnZwY2kgKQ0KPj4+Pj4+Pj4+Pj4+Pj4gKyAgICAgICAgew0KPj4+Pj4+Pj4+Pj4+Pj4gKyAgICAg
ICAgICAgIHNwaW5fdW5sb2NrKCZ0bXAtPnZwY2lfbG9jayk7DQo+Pj4+Pj4+Pj4+Pj4+PiArICAg
ICAgICAgICAgY29udGludWU7DQo+Pj4+Pj4+Pj4+Pj4+PiArICAgICAgICB9DQo+Pj4+Pj4+Pj4+
Pj4+PiAgICAgICAgICAgICAgICBmb3IgKCBpID0gMDsgaSA8IEFSUkFZX1NJWkUodG1wLT52cGNp
LT5oZWFkZXIuYmFycyk7IGkrKyApDQo+Pj4+Pj4+Pj4+Pj4+PiAgICAgICAgICAgICAgICB7DQo+
Pj4+Pj4+Pj4+Pj4+PiAgICAgICAgICAgICAgICAgICAgY29uc3Qgc3RydWN0IHZwY2lfYmFyICpi
YXIgPSAmdG1wLT52cGNpLT5oZWFkZXIuYmFyc1tpXTsNCj4+Pj4+Pj4+Pj4+Pj4+IEBAIC0zMDMs
MTIgKzMxMCwxNCBAQCBzdGF0aWMgaW50IG1vZGlmeV9iYXJzKGNvbnN0IHN0cnVjdCBwY2lfZGV2
ICpwZGV2LCB1aW50MTZfdCBjbWQsIGJvb2wgcm9tX29ubHkpDQo+Pj4+Pj4+Pj4+Pj4+PiAgICAg
ICAgICAgICAgICAgICAgcmMgPSByYW5nZXNldF9yZW1vdmVfcmFuZ2UobWVtLCBzdGFydCwgZW5k
KTsNCj4+Pj4+Pj4+Pj4+Pj4+ICAgICAgICAgICAgICAgICAgICBpZiAoIHJjICkNCj4+Pj4+Pj4+
Pj4+Pj4+ICAgICAgICAgICAgICAgICAgICB7DQo+Pj4+Pj4+Pj4+Pj4+PiArICAgICAgICAgICAg
ICAgIHNwaW5fdW5sb2NrKCZ0bXAtPnZwY2lfbG9jayk7DQo+Pj4+Pj4+Pj4+Pj4+PiAgICAgICAg
ICAgICAgICAgICAgICAgIHByaW50ayhYRU5MT0dfR19XQVJOSU5HICJGYWlsZWQgdG8gcmVtb3Zl
IFslbHgsICVseF06ICVkXG4iLA0KPj4+Pj4+Pj4+Pj4+Pj4gICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgc3RhcnQsIGVuZCwgcmMpOw0KPj4+Pj4+Pj4+Pj4+Pj4gICAgICAgICAgICAgICAg
ICAgICAgICByYW5nZXNldF9kZXN0cm95KG1lbSk7DQo+Pj4+Pj4+Pj4+Pj4+PiAgICAgICAgICAg
ICAgICAgICAgICAgIHJldHVybiByYzsNCj4+Pj4+Pj4+Pj4+Pj4+ICAgICAgICAgICAgICAgICAg
ICB9DQo+Pj4+Pj4+Pj4+Pj4+PiAgICAgICAgICAgICAgICB9DQo+Pj4+Pj4+Pj4+Pj4+PiArICAg
ICAgICBzcGluX3VubG9jaygmdG1wLT52cGNpX2xvY2spOw0KPj4+Pj4+Pj4+Pj4+Pj4gICAgICAg
ICAgICB9DQo+Pj4+Pj4+Pj4+Pj4+IEF0IHRoZSBmaXJzdCBnbGFuY2UgdGhpcyBzaW1wbHkgbG9v
a3MgbGlrZSBhbm90aGVyIHVuanVzdGlmaWVkIChpbiB0aGUNCj4+Pj4+Pj4+Pj4+Pj4gZGVzY3Jp
cHRpb24pIGNoYW5nZSwgYXMgeW91J3JlIG5vdCBjb252ZXJ0aW5nIGFueXRoaW5nIGhlcmUgYnV0
IHlvdQ0KPj4+Pj4+Pj4+Pj4+PiBhY3R1YWxseSBhZGQgbG9ja2luZyAoYW5kIEkgcmVhbGl6ZSB0
aGlzIHdhcyB0aGVyZSBiZWZvcmUsIHNvIEknbSBzb3JyeQ0KPj4+Pj4+Pj4+Pj4+PiBmb3Igbm90
IHBvaW50aW5nIHRoaXMgb3V0IGVhcmxpZXIpLg0KPj4+Pj4+Pj4+Pj4+IFdlbGwsIEkgdGhvdWdo
dCB0aGF0IHRoZSBkZXNjcmlwdGlvbiBhbHJlYWR5IGhhcyAiLi4udGhlIGxvY2sgY2FuIGJlDQo+
Pj4+Pj4+Pj4+Pj4gdXNlZCAoYW5kIGluIGEgZmV3IGNhc2VzIGlzIHVzZWQgcmlnaHQgYXdheSkg
dG8gY2hlY2sgd2hldGhlciB2cGNpDQo+Pj4+Pj4+Pj4+Pj4gaXMgcHJlc2VudCIgYW5kIHRoaXMg
aXMgZW5vdWdoIGZvciBzdWNoIHVzZXMgYXMgaGVyZS4NCj4+Pj4+Pj4+Pj4+Pj4gICAgICAgIEJ1
dCB0aGVuIEkgd29uZGVyIHdoZXRoZXIgeW91DQo+Pj4+Pj4+Pj4+Pj4+IGFjdHVhbGx5IHRlc3Rl
ZCB0aGlzLCBzaW5jZSBJIGNhbid0IGhlbHAgZ2V0dGluZyB0aGUgaW1wcmVzc2lvbiB0aGF0DQo+
Pj4+Pj4+Pj4+Pj4+IHlvdSdyZSBpbnRyb2R1Y2luZyBhIGxpdmUtbG9jazogVGhlIGZ1bmN0aW9u
IGlzIGNhbGxlZCBmcm9tIGNtZF93cml0ZSgpDQo+Pj4+Pj4+Pj4+Pj4+IGFuZCByb21fd3JpdGUo
KSwgd2hpY2ggaW4gdHVybiBhcmUgY2FsbGVkIG91dCBvZiB2cGNpX3dyaXRlKCkuIFlldCB0aGF0
DQo+Pj4+Pj4+Pj4+Pj4+IGZ1bmN0aW9uIGFscmVhZHkgaG9sZHMgdGhlIGxvY2ssIGFuZCB0aGUg
bG9jayBpcyBub3QgKGN1cnJlbnRseSkNCj4+Pj4+Pj4+Pj4+Pj4gcmVjdXJzaXZlLiAoRm9yIHRo
ZSAzcmQgY2FsbGVyIG9mIHRoZSBmdW5jdGlvbiAtIGluaXRfYmFycygpIC0gb3RvaA0KPj4+Pj4+
Pj4+Pj4+PiB0aGUgbG9ja2luZyBsb29rcyB0byBiZSBlbnRpcmVseSB1bm5lY2Vzc2FyeS4pDQo+
Pj4+Pj4+Pj4+Pj4gV2VsbCwgeW91IGFyZSBjb3JyZWN0OiBpZiB0bXAgIT0gcGRldiB0aGVuIGl0
IGlzIGNvcnJlY3QgdG8gYWNxdWlyZQ0KPj4+Pj4+Pj4+Pj4+IHRoZSBsb2NrLiBCdXQgaWYgdG1w
ID09IHBkZXYgYW5kIHJvbV9vbmx5ID09IHRydWUNCj4+Pj4+Pj4+Pj4+PiB0aGVuIHdlJ2xsIGRl
YWRsb2NrLg0KPj4+Pj4+Pj4+Pj4+DQo+Pj4+Pj4+Pj4+Pj4gSXQgc2VlbXMgd2UgbmVlZCB0byBo
YXZlIHRoZSBsb2NraW5nIGNvbmRpdGlvbmFsLCBlLmcuIG9ubHkgbG9jaw0KPj4+Pj4+Pj4+Pj4+
IGlmIHRtcCAhPSBwZGV2DQo+Pj4+Pj4+Pj4+PiBXaGljaCB3aWxsIGFkZHJlc3MgdGhlIGxpdmUt
bG9jaywgYnV0IGludHJvZHVjZSBBQkJBIGRlYWRsb2NrIHBvdGVudGlhbA0KPj4+Pj4+Pj4+Pj4g
YmV0d2VlbiB0aGUgdHdvIGxvY2tzLg0KPj4+Pj4+Pj4+PiBJIGFtIG5vdCBzdXJlIEkgY2FuIHN1
Z2dlc3QgYSBiZXR0ZXIgc29sdXRpb24gaGVyZQ0KPj4+Pj4+Pj4+PiBAUm9nZXIsIEBKYW4sIGNv
dWxkIHlvdSBwbGVhc2UgaGVscCBoZXJlPw0KPj4+Pj4+Pj4+IFdlbGwsIGZpcnN0IG9mIGFsbCBJ
J2QgbGlrZSB0byBtZW50aW9uIHRoYXQgd2hpbGUgaXQgbWF5IGhhdmUgYmVlbiBva2F5IHRvDQo+
Pj4+Pj4+Pj4gbm90IGhvbGQgcGNpZGV2c19sb2NrIGhlcmUgZm9yIERvbTAsIGl0IHN1cmVseSBu
ZWVkcyBhY3F1aXJpbmcgd2hlbiBkZWFsaW5nDQo+Pj4+Pj4+Pj4gd2l0aCBEb21VLXMnIGxpc3Rz
IG9mIFBDSSBkZXZpY2VzLiBUaGUgcmVxdWlyZW1lbnQgcmVhbGx5IGFwcGxpZXMgdG8gdGhlDQo+
Pj4+Pj4+Pj4gb3RoZXIgdXNlIG9mIGZvcl9lYWNoX3BkZXYoKSBhcyB3ZWxsIChpbiB2cGNpX2R1
bXBfbXNpKCkpLCBleGNlcHQgdGhhdA0KPj4+Pj4+Pj4+IHRoZXJlIGl0IHByb2JhYmx5IHdhbnRz
IHRvIGJlIGEgdHJ5LWxvY2suDQo+Pj4+Pj4+Pj4NCj4+Pj4+Pj4+PiBOZXh0IEknZCBsaWtlIHRv
IHBvaW50IG91dCB0aGF0IGhlcmUgd2UgaGF2ZSB0aGUgc3RpbGwgcGVuZGluZyBpc3N1ZSBvZg0K
Pj4+Pj4+Pj4+IGhvdyB0byBkZWFsIHdpdGggaGlkZGVuIGRldmljZXMsIHdoaWNoIERvbTAgY2Fu
IGFjY2Vzcy4gU2VlIG15IFJGQyBwYXRjaA0KPj4+Pj4+Pj4+ICJ2UENJOiBhY2NvdW50IGZvciBo
aWRkZW4gZGV2aWNlcyBpbiBtb2RpZnlfYmFycygpIi4gV2hhdGV2ZXIgdGhlIHNvbHV0aW9uDQo+
Pj4+Pj4+Pj4gaGVyZSwgSSB0aGluayBpdCB3YW50cyB0byBhdCBsZWFzdCBhY2NvdW50IGZvciB0
aGUgZXh0cmEgbmVlZCB0aGVyZS4NCj4+Pj4+Pj4+IFllcywgc29ycnksIEkgc2hvdWxkIHRha2Ug
Y2FyZSBvZiB0aGF0Lg0KPj4+Pj4+Pj4NCj4+Pj4+Pj4+PiBOb3cgaXQgaXMgcXVpdGUgY2xlYXIg
dGhhdCBwY2lkZXZzX2xvY2sgaXNuJ3QgZ29pbmcgdG8gaGVscCB3aXRoIGF2b2lkaW5nDQo+Pj4+
Pj4+Pj4gdGhlIGRlYWRsb2NrLCBhcyBpdCdzIGltbyBub3QgYW4gb3B0aW9uIGF0IGFsbCB0byBh
Y3F1aXJlIHRoYXQgbG9jaw0KPj4+Pj4+Pj4+IGV2ZXJ5d2hlcmUgZWxzZSB5b3UgYWNjZXNzIC0+
dnBjaSAob3IgZWxzZSB0aGUgdnBjaSBsb2NrIGl0c2VsZiB3b3VsZCBiZQ0KPj4+Pj4+Pj4+IHBv
aW50bGVzcykuIEJ1dCBhIHBlci1kb21haW4gYXV4aWxpYXJ5IHIvdyBsb2NrIG1heSBoZWxwOiBP
dGhlciBwYXRocw0KPj4+Pj4+Pj4+IHdvdWxkIGFjcXVpcmUgaXQgaW4gcmVhZCBtb2RlLCBhbmQg
aGVyZSB5b3UnZCBhY3F1aXJlIGl0IGluIHdyaXRlIG1vZGUgKGluDQo+Pj4+Pj4+Pj4gdGhlIGZv
cm1lciBjYXNlIGFyb3VuZCB0aGUgdnBjaSBsb2NrLCB3aGlsZSBpbiB0aGUgbGF0dGVyIGNhc2Ug
dGhlcmUgbWF5DQo+Pj4+Pj4+Pj4gdGhlbiBub3QgYmUgYW55IG5lZWQgdG8gYWNxdWlyZSB0aGUg
aW5kaXZpZHVhbCB2cGNpIGxvY2tzIGF0IGFsbCkuIEZUQU9EOg0KPj4+Pj4+Pj4+IEkgaGF2ZW4n
dCBmdWxseSB0aG91Z2h0IHRocm91Z2ggYWxsIGltcGxpY2F0aW9ucyAoYW5kIGhlbmNlIHdoZXRo
ZXIgdGhpcyBpcw0KPj4+Pj4+Pj4+IHZpYWJsZSBpbiB0aGUgZmlyc3QgcGxhY2UpOyBJIGV4cGVj
dCB5b3Ugd2lsbCwgZG9jdW1lbnRpbmcgd2hhdCB5b3UndmUNCj4+Pj4+Pj4+PiBmb3VuZCBpbiB0
aGUgcmVzdWx0aW5nIHBhdGNoIGRlc2NyaXB0aW9uLiBPZiBjb3Vyc2UgdGhlIGRvdWJsZSBsb2Nr
DQo+Pj4+Pj4+Pj4gYWNxdWlyZS9yZWxlYXNlIHdvdWxkIHRoZW4gbGlrZWx5IHdhbnQgaGlkaW5n
IGluIGhlbHBlciBmdW5jdGlvbnMuDQo+Pj4+Pj4+PiBJJ3ZlIGJlZW4gYWxzbyB0aGlua2luZyBh
Ym91dCB0aGlzLCBhbmQgd2hldGhlciBpdCdzIHJlYWxseSB3b3J0aCB0bw0KPj4+Pj4+Pj4gaGF2
ZSBhIHBlci1kZXZpY2UgbG9jayByYXRoZXIgdGhhbiBhIHBlci1kb21haW4gb25lIHRoYXQgcHJv
dGVjdHMgYWxsDQo+Pj4+Pj4+PiB2cGNpIHJlZ2lvbnMgb2YgdGhlIGRldmljZXMgYXNzaWduZWQg
dG8gdGhlIGRvbWFpbi4NCj4+Pj4+Pj4+DQo+Pj4+Pj4+PiBUaGUgT1MgaXMgbGlrZWx5IHRvIHNl
cmlhbGl6ZSBhY2Nlc3NlcyB0byB0aGUgUENJIGNvbmZpZyBzcGFjZSBhbnl3YXksDQo+Pj4+Pj4+
PiBhbmQgdGhlIG9ubHkgcGxhY2UgSSBjb3VsZCBzZWUgYSBiZW5lZml0IG9mIGhhdmluZyBwZXIt
ZGV2aWNlIGxvY2tzIGlzDQo+Pj4+Pj4+PiBpbiB0aGUgaGFuZGxpbmcgb2YgTVNJLVggdGFibGVz
LCBhcyB0aGUgaGFuZGxpbmcgb2YgdGhlIG1hc2sgYml0IGlzDQo+Pj4+Pj4+PiBsaWtlbHkgdmVy
eSBwZXJmb3JtYW5jZSBzZW5zaXRpdmUsIHNvIGFkZGluZyBhIHBlci1kb21haW4gbG9jayB0aGVy
ZQ0KPj4+Pj4+Pj4gY291bGQgYmUgYSBib3R0bGVuZWNrLg0KPj4+Pj4+PiBIbW0sIHdpdGggbWV0
aG9kIDEgYWNjZXNzZXMgc2VyaWFsaXppbmcgZ2xvYmFsbHkgaXMgYmFzaWNhbGx5DQo+Pj4+Pj4+
IHVuYXZvaWRhYmxlLCBidXQgd2l0aCBNTUNGRyBJIHNlZSBubyByZWFzb24gd2h5IE9TZXMgbWF5
IG5vdCAobW92ZQ0KPj4+Pj4+PiB0bykgcGVybWl0KHRpbmcpIHBhcmFsbGVsIGFjY2Vzc2VzLCB3
aXRoIHNlcmlhbGl6YXRpb24gcGVyaGFwcyBkb25lDQo+Pj4+Pj4+IG9ubHkgYXQgZGV2aWNlIGxl
dmVsLiBTZWUgb3VyIG93biBwY2lfY29uZmlnX2xvY2ssIHdoaWNoIGFwcGxpZXMgdG8NCj4+Pj4+
Pj4gb25seSBtZXRob2QgMSBhY2Nlc3Nlczsgd2UgZG9uJ3QgbG9vayB0byBiZSBzZXJpYWxpemlu
ZyBNTUNGRw0KPj4+Pj4+PiBhY2Nlc3NlcyBhdCBhbGwuDQo+Pj4+Pj4+DQo+Pj4+Pj4+PiBXZSBj
b3VsZCBhbHRlcm5hdGl2ZWx5IGRvIGEgcGVyLWRvbWFpbiByd2xvY2sgZm9yIHZwY2kgYW5kIHNw
ZWNpYWwgY2FzZQ0KPj4+Pj4+Pj4gdGhlIE1TSS1YIGFyZWEgdG8gYWxzbyBoYXZlIGEgcGVyLWRl
dmljZSBzcGVjaWZpYyBsb2NrLiBBdCB3aGljaCBwb2ludA0KPj4+Pj4+Pj4gaXQgYmVjb21lcyBm
YWlybHkgc2ltaWxhciB0byB3aGF0IHlvdSBwcm9wb3NlLg0KPj4+Pj4+IEBKYW4sIEBSb2dlcg0K
Pj4+Pj4+DQo+Pj4+Pj4gMS4gZC0+dnBjaV9sb2NrIC0gcndsb2NrIDwtIHRoaXMgcHJvdGVjdHMg
dnBjaQ0KPj4+Pj4+IDIuIHBkZXYtPnZwY2ktPm1zaXhfdGJsX2xvY2sgLSByd2xvY2sgPC0gdGhp
cyBwcm90ZWN0cyBNU0ktWCB0YWJsZXMNCj4+Pj4+PiBvciBzaG91bGQgaXQgYmV0dGVyIGJlIHBk
ZXYtPm1zaXhfdGJsX2xvY2sgYXMgTVNJLVggdGFibGVzIGRvbid0DQo+Pj4+Pj4gcmVhbGx5IGRl
cGVuZCBvbiB2UENJPw0KPj4+Pj4gSWYgc28sIHBlcmhhcHMgaW5kZWVkIGJldHRlciB0aGUgbGF0
dGVyLiBCdXQgYXMgc2FpZCBpbiByZXBseSB0byBSb2dlciwNCj4+Pj4+IEknbSBub3QgY29udmlu
Y2VkICh5ZXQpIHRoYXQgZG9pbmcgYXdheSB3aXRoIHRoZSBwZXItZGV2aWNlIGxvY2sgaXMgYQ0K
Pj4+Pj4gZ29vZCBtb3ZlLiBBcyBzYWlkIHRoZXJlIC0gd2UncmUgb3Vyc2VsdmVzIGRvaW5nIGZ1
bGx5IHBhcmFsbGVsIE1NQ0ZHDQo+Pj4+PiBhY2Nlc3Nlcywgc28gT1NlcyBvdWdodCB0byBiZSBm
aW5lIHRvIGRvIHNvLCB0b28uDQo+Pj4+IEJ1dCB3aXRoIHBkZXYtPnZwY2lfbG9jayB3ZSBmYWNl
IEFCQkEuLi4NCj4+PiBJIHRoaW5rIGl0IHdvdWxkIGJlIGVhc2llciB0byBzdGFydCB3aXRoIGEg
cGVyLWRvbWFpbiByd2xvY2sgdGhhdA0KPj4+IGd1YXJhbnRlZXMgcGRldi0+dnBjaSBjYW5ub3Qg
YmUgcmVtb3ZlZCB1bmRlciBvdXIgZmVldC4gVGhpcyB3b3VsZCBiZQ0KPj4+IHRha2VuIGluIHJl
YWQgbW9kZSBpbiB2cGNpX3tyZWFkLHdyaXRlfSBhbmQgaW4gd3JpdGUgbW9kZSB3aGVuDQo+Pj4g
cmVtb3ZpbmcgYSBkZXZpY2UgZnJvbSBhIGRvbWFpbi4NCj4+Pg0KPj4+IFRoZW4gdGhlcmUgYXJl
IGFsc28gb3RoZXIgaXNzdWVzIHJlZ2FyZGluZyB2UENJIGxvY2tpbmcgdGhhdCBuZWVkIHRvDQo+
Pj4gYmUgZml4ZWQsIGJ1dCB0aGF0IGxvY2sgd291bGQgbGlrZWx5IGJlIGEgc3RhcnQuDQo+PiBP
ciBsZXQncyBzZWUgdGhlIHByb2JsZW0gYXQgYSBkaWZmZXJlbnQgYW5nbGU6IHRoaXMgaXMgdGhl
IG9ubHkgcGxhY2UNCj4+IHdoaWNoIGJyZWFrcyB0aGUgdXNlIG9mIHBkZXYtPnZwY2lfbG9jay4g
QmVjYXVzZSBhbGwgb3RoZXIgcGxhY2VzDQo+PiBkbyBub3QgdHJ5IHRvIGFjcXVpcmUgdGhlIGxv
Y2sgb2YgYW55IHR3byBkZXZpY2VzIGF0IGEgdGltZS4NCj4+IFNvLCB3aGF0IGlmIHdlIHJlLXdv
cmsgdGhlIG9mZmVuZGluZyBwaWVjZSBvZiBjb2RlIGluc3RlYWQ/DQo+PiBUaGF0IHdheSB3ZSBk
byBub3QgYnJlYWsgcGFyYWxsZWwgYWNjZXNzIGFuZCBoYXZlIHRoZSBsb2NrIHBlci1kZXZpY2UN
Cj4+IHdoaWNoIG1pZ2h0IGFsc28gYmUgYSBwbHVzLg0KPj4NCj4+IEJ5IHJlLXdvcmsgSSBtZWFu
LCB0aGF0IGluc3RlYWQgb2YgcmVhZGluZyBhbHJlYWR5IG1hcHBlZCByZWdpb25zDQo+PiBmcm9t
IHRtcCB3ZSBjYW4gZW1wbG95IGEgZC0+cGNpX21hcHBlZF9yZWdpb25zIHJhbmdlIHNldCB3aGlj
aA0KPj4gd2lsbCBob2xkIGFsbCB0aGUgYWxyZWFkeSBtYXBwZWQgcmFuZ2VzLiBBbmQgd2hlbiBp
dCBpcyBuZWVkZWQgdG8gYWNjZXNzDQo+PiB0aGF0IHJhbmdlIHNldCB3ZSB1c2UgcGNpZGV2c19s
b2NrIHdoaWNoIHNlZW1zIHRvIGJlIHJhcmUuDQo+PiBTbywgbW9kaWZ5X2JhcnMgd2lsbCByZWx5
IG9uIHBkZXYtPnZwY2lfbG9jayArIHBjaWRldnNfbG9jayBhbmQNCj4+IEFCQkEgd29uJ3QgYmUg
cG9zc2libGUgYXQgYWxsLg0KPiBTYWRseSB0aGF0IHdvbid0IHJlcGxhY2UgdGhlIHVzYWdlIG9m
IHRoZSBsb29wIGluIG1vZGlmeV9iYXJzLiBUaGlzIGlzDQo+IG5vdCAoZXhjbHVzaXZlbHkpIGRv
bmUgaW4gb3JkZXIgdG8gcHJldmVudCBtYXBwaW5nIHRoZSBzYW1lIHJlZ2lvbg0KPiBtdWx0aXBs
ZSB0aW1lcywgYnV0IHJhdGhlciB0byBwcmV2ZW50IHVubWFwcGluZyBvZiByZWdpb25zIGFzIGxv
bmcgYXMNCj4gdGhlcmUncyBhbiBlbmFibGVkIEJBUiB0aGF0J3MgdXNpbmcgaXQuDQo+DQo+IElm
IHlvdSB3YW50ZWQgdG8gdXNlIHNvbWV0aGluZyBsaWtlIGQtPnBjaV9tYXBwZWRfcmVnaW9ucyBp
dCB3b3VsZA0KPiBoYXZlIHRvIGtlZXAgcmVmZXJlbmNlIGNvdW50cyB0byByZWdpb25zLCBpbiBv
cmRlciB0byBrbm93IHdoZW4gYQ0KPiBtYXBwaW5nIGlzIG5vIGxvbmdlciByZXF1aXJlZCBieSBh
bnkgQkFSIG9uIHRoZSBzeXN0ZW0gd2l0aCBtZW1vcnkNCj4gZGVjb2RpbmcgZW5hYmxlZC4NCkkg
bWlzc2VkIHRoaXMgcGF0aCwgdGhhbmsgeW91DQoNCkkgdHJpZWQgdG8gYW5hbHl6ZSB0aGUgbG9j
a2luZyBpbiBwY2kvdnBjaS4NCg0KRmlyc3Qgb2YgYWxsIHNvbWUgY29udGV4dCB0byByZWZyZXNo
IHRoZSB0YXJnZXQgd2Ugd2FudDoNCnRoZSByYXRpb25hbGUgYmVoaW5kIG1vdmluZyBwZGV2LT52
cGNpLT5sb2NrIG91dHNpZGUNCmlzIHRvIGJlIGFibGUgZHluYW1pY2FsbHkgY3JlYXRlIGFuZCBk
ZXN0cm95IHBkZXYtPnZwY2kuDQpTbywgZm9yIHRoYXQgcmVhc29uIGxvY2sgbmVlZHMgdG8gYmUg
bW92ZWQgb3V0c2lkZSBvZiB0aGUgcGRldi0+dnBjaS4NCg0KU29tZSBvZiB0aGUgY2FsbGVycyBv
ZiB0aGUgdlBDSSBjb2RlIGFuZCBsb2NraW5nIHVzZWQ6DQoNCj09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09DQp2cGNpX21taW9fcmVhZC92cGNpX21tY2ZnX3JlYWQNCj09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQogwqAgLSB2cGNpX2VjYW1fcmVhZA0K
IMKgIC0gdnBjaV9yZWFkDQogwqDCoCAhISEhISEhISBwZGV2IGlzIGFjcXVpcmVkLCB0aGVuIHBk
ZXYtPnZwY2lfbG9jayBpcyB1c2VkICEhISEhISEhDQogwqDCoCAtIG1zaXg6DQogwqDCoMKgIC0g
Y29udHJvbF9yZWFkDQogwqDCoCAtIGhlYWRlcjoNCiDCoMKgwqAgLSBndWVzdF9iYXJfcmVhZA0K
IMKgwqAgLSBtc2k6DQogwqDCoMKgIC0gY29udHJvbF9yZWFkDQogwqDCoMKgIC0gYWRkcmVzc19y
ZWFkL2FkZHJlc3NfaGlfcmVhZA0KIMKgwqDCoCAtIGRhdGFfcmVhZA0KIMKgwqDCoCAtIG1hc2tf
cmVhZA0KDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KdnBjaV9tbWlv
X3dyaXRlL3ZwY2lfbW1jZmdfd3JpdGUNCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09DQogwqAgLSB2cGNpX2VjYW1fd3JpdGUNCiDCoCAtIHZwY2lfd3JpdGUNCiDCoMKgICEh
ISEhISEhIHBkZXYgaXMgYWNxdWlyZWQsIHRoZW4gcGRldi0+dnBjaV9sb2NrIGlzIHVzZWQgISEh
ISEhISENCiDCoMKgIC0gbXNpeDoNCiDCoMKgwqAgLSBjb250cm9sX3dyaXRlDQogwqDCoCAtIGhl
YWRlcjoNCiDCoMKgwqAgLSBiYXJfd3JpdGUvZ3Vlc3RfYmFyX3dyaXRlDQogwqDCoMKgIC0gY21k
X3dyaXRlL2d1ZXN0X2NtZF93cml0ZQ0KIMKgwqDCoCAtIHJvbV93cml0ZQ0KIMKgwqDCoMKgIC0g
YWxsIHdyaXRlIGhhbmRsZXJzIG1heSBjYWxsIG1vZGlmeV9iYXJzDQogwqDCoMKgwqDCoCBtb2Rp
ZnlfYmFycw0KIMKgwqAgLSBtc2k6DQogwqDCoMKgIC0gY29udHJvbF93cml0ZQ0KIMKgwqDCoCAt
IGFkZHJlc3Nfd3JpdGUvYWRkcmVzc19oaV93cml0ZQ0KIMKgwqDCoCAtIGRhdGFfd3JpdGUNCiDC
oMKgwqAgLSBtYXNrX3dyaXRlDQoNCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09DQpwY2lfYWRkX2RldmljZTogbG9ja2VkIHdpdGggcGNpZGV2c19sb2NrDQo9PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KIMKgIC0gdnBjaV9hZGRfaGFuZGxlcnMNCiDC
oMKgICsrKysrKysrIHBkZXYtPnZwY2lfbG9jayBpcyB1c2VkICsrKysrKysrDQoNCj09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQpwY2lfcmVtb3ZlX2RldmljZTogbG9ja2Vk
IHdpdGggcGNpZGV2c19sb2NrDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PQ0KLSB2cGNpX3JlbW92ZV9kZXZpY2UNCiDCoCArKysrKysrKyBwZGV2LT52cGNpX2xvY2sgaXMg
dXNlZCArKysrKysrKw0KLSBwY2lfY2xlYW51cF9tc2kNCi0gZnJlZV9wZGV2DQoNCj09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQpYRU5fRE9NQ1RMX2Fzc2lnbl9kZXZpY2U6
IGxvY2tlZCB3aXRoIHBjaWRldnNfbG9jaw0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT0NCi0gYXNzaWduX2RldmljZQ0KIMKgLSB2cGNpX2RlYXNzaWduX2RldmljZQ0KIMKg
LSBwZGV2X21zaXhfYXNzaWduDQogwqAtIHZwY2lfYXNzaWduX2RldmljZQ0KIMKgIC0gdnBjaV9h
ZGRfaGFuZGxlcnMNCiDCoMKgwqAgKysrKysrKysgcGRldi0+dnBjaV9sb2NrIGlzIHVzZWQgKysr
KysrKysNCg0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NClhFTl9ET01D
VExfZGVhc3NpZ25fZGV2aWNlOiBsb2NrZWQgd2l0aCBwY2lkZXZzX2xvY2sNCj09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotIGRlYXNzaWduX2RldmljZQ0KIMKgLSB2cGNp
X2RlYXNzaWduX2RldmljZQ0KIMKgwqAgKysrKysrKysgcGRldi0+dnBjaV9sb2NrIGlzIHVzZWQg
KysrKysrKysNCiDCoCAtIHZwY2lfcmVtb3ZlX2RldmljZQ0KDQoNCj09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09DQptb2RpZnlfYmFycyBpcyBhIHNwZWNpYWwgY2FzZTogdGhp
cyBpcyB0aGUgb25seSBmdW5jdGlvbiB3aGljaCB0cmllcyB0byBsb2NrDQp0d28gcGNpX2RldiBk
ZXZpY2VzOiBpdCBpcyBkb25lIHRvIGNoZWNrIGZvciBvdmVybGFwcyB3aXRoIG90aGVyIEJBUnMg
d2hpY2ggbWF5IGhhdmUgYmVlbg0KYWxyZWFkeSBtYXBwZWQgb3IgdW5tYXBwZWQuDQoNClNvLCB0
aGlzIGlzIHRoZSBvbmx5IGNhc2Ugd2hpY2ggbWF5IGRlYWRsb2NrIGJlY2F1c2Ugb2YgcGNpX2Rl
di0+dnBjaV9sb2NrLg0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCg0K
Qm90dG9tIGxpbmU6DQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KDQox
LiB2cGNpX3tyZWFkfHdyaXRlfSBhcmUgbm90IHByb3RlY3RlZCB3aXRoIHBjaWRldnNfbG9jayBh
bmQgY2FuIHJ1biBpbg0KcGFyYWxsZWwgd2l0aCBwY2lfcmVtb3ZlX2RldmljZSB3aGljaCBjYW4g
cmVtb3ZlIHBkZXYgYWZ0ZXIgdnBjaV97cmVhZHx3cml0ZX0NCmFjcXVpcmVkIHRoZSBwZGV2IHBv
aW50ZXIuIFRoaXMgbWF5IGxlYWQgdG8gYSBmYWlsIGR1ZSB0byBwZGV2IGRlcmVmZXJlbmNlLg0K
DQpTbywgdG8gcHJvdGVjdCBwZGV2IGRlcmVmZXJlbmNlIHZwY2lfe3JlYWR8d3JpdGV9IG11c3Qg
YWxzbyB1c2UgcGRldnNfbG9jay4NCg0KMi4gVGhlIG9ubHkgb2ZmZW5kaW5nIHBsYWNlIHdoaWNo
IGlzIGluIHRoZSB3YXkgb2YgcGNpX2Rldi0+dnBjaV9sb2NrIGlzDQptb2RpZnlfYmFycy4gSWYg
aXQgY2FuIGJlIHJlLXdvcmtlZCB0byB0cmFjayBhbHJlYWR5IG1hcHBlZCBhbmQgdW5tYXBwZWQN
CnJlZ2lvbnMgdGhlbiB3ZSBjYW4gYXZvaWQgaGF2aW5nIGEgcG9zc2libGUgZGVhZGxvY2sgYW5k
IGNhbiB1c2UNCnBjaV9kZXYtPnZwY2lfbG9jayAocmFuZ2VzZXRzIHdvbid0IGhlbHAgaGVyZSBh
cyB3ZSBhbHNvIG5lZWQgcmVmY291bnRpbmcgYmUNCmltcGxlbWVudGVkKS4NCg0KSWYgcGNpZGV2
c19sb2NrIGlzIHVzZWQgZm9yIHZwY2lfe3JlYWR8d3JpdGV9IHRoZW4gbm8gZGVhZGxvY2sgaXMg
cG9zc2libGUsDQpidXQgbW9kaWZ5X2JhcnMgY29kZSBtdXN0IGJlIHJlLXdvcmtlZCBub3QgdG8g
bG9jayBpdHNlbGYgKHBkZXYtPnZwY2lfbG9jayBhbmQNCnRtcC0+dnBjaV9sb2NrIHdoZW4gcGRl
diA9PSB0bXAsIHRoaXMgaXMgbWlub3IpLg0KDQozLiBXZSBtYXkgdGhpbmsgYWJvdXQgYSBwZXIt
ZG9tYWluIHJ3bG9jayBhbmQgcGRldi0+dnBjaV9sb2NrLCBzbyB0aGlzIHNvbHZlcw0KbW9kaWZ5
X2JhcnMncyB0d28gcGRldnMgYWNjZXNzLiBCdXQgdGhpcyBkb2Vzbid0IHNvbHZlIHBvc3NpYmxl
IHBkZXYNCmRlLXJlZmVyZW5jZSBpbiB2cGNpX3tyZWFkfHdyaXRlfSB2cyBwY2lfcmVtb3ZlX2Rl
dmljZS4NCg0KQFJvZ2VyLCBASmFuLCBJIHdvdWxkIGxpa2UgdG8gaGVhciB3aGF0IGRvIHlvdSB0
aGluayBhYm91dCB0aGUgYWJvdmUgYW5hbHlzaXMNCmFuZCBob3cgY2FuIHdlIHByb2NlZWQgd2l0
aCBsb2NraW5nIHJlLXdvcms/DQoNClRoYW5rIHlvdSBpbiBhZHZhbmNlLA0KT2xla3NhbmRyDQo=


From xen-devel-bounces@lists.xenproject.org Mon Feb 07 11:21:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 11:21:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266737.460445 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH24z-00067s-SN; Mon, 07 Feb 2022 11:21:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266737.460445; Mon, 07 Feb 2022 11:21:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH24z-00067l-PN; Mon, 07 Feb 2022 11:21:09 +0000
Received: by outflank-mailman (input) for mailman id 266737;
 Mon, 07 Feb 2022 11:21:08 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=hYSm=SW=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nH24y-0005g1-1N
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 11:21:08 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 06083685-8808-11ec-8eb8-a37418f5ba1a;
 Mon, 07 Feb 2022 12:21:00 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 06083685-8808-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644232860;
  h=from:to:cc:subject:date:message-id:
   content-transfer-encoding:mime-version;
  bh=vcsYA2v40DuaHoLQYHthAJyUBBIGwi3lVmjj7nEksm8=;
  b=SDZo2t2cnmsyL8TuvfsW2JJRSAg491cTGdrsQOUlBQ/u3j2a9JJtaXeM
   nwjc46LhzjKnq8wilxerj4WJwSVeD+4sorSasw2JzbenobWR/8fHbvok7
   938Uc/WU9nJxIy3uzH2agYr6RT5gc4LZnSpZXZhUV07eVb9/BSSvWbFZa
   U=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: qVouVBDJbFsDxREK6eTiWWkS5JI4RCLH+r9nZrnizGQWUcyjBgJ41mRhRYg5H/ERT7v/oQHC8u
 eXijRPEaCKCUWblAkuXM6nAYdykM7TgAH+sksChX7b4t0vVsc/3baPpM3BQ3JFAaD5s83CIejL
 WeK4DNdU3s5Sj5vfcGu+z6WSwTLIrPiWwjpicvlbiCVD/FkSbZw6BRUTSBQxfZ/W1D0paP8yPv
 DaUO+NQNdcnfdVpeZaRrZGFeMl3gwTB80gttXbXAfmnAuafOpJH+u3F9II63oP/D2l4tfk2hM5
 yDMyDSLmsX4/0Pj0a+B99q7Z
X-SBRS: 5.1
X-MesageID: 63093442
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:ySfLy6+ugzauiatL6T5mDrUDUnmTJUtcMsCJ2f8bNWPcYEJGY0x3n
 TcaCDqEa63fYmP2edwjYNnkoUNT7MCHmNFjGwNq/ng8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhFWeIdA970Ug5w7Rh3dYx6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPgo+
 vlu5ZWrDj0rYPLXsuZAekQHNDBXaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguw5K8bmJsUHs2xIxjDFF/c2B5vERs0m4PcGh29h3ZwSR54yY
 eIAaxpAPRL7OCFFBVJJBbJ5uvahmEbWJmgwRFW9+vNsvjm7IBZK+KfpGMrYfJqNX8o9tkSSq
 3/C/m/5KgoHL9HZwj2Amlq8i+mKkS7lVYY6ELyj6uUskFCV3nYUChAdSR28u/bRt6Klc4sBc
 QpOoHNo9PVsshzwJjXgY/GmiCe2kj1MUsEXKe9ktxqnyPf9vlm+F0FRG1atd+canMMxQDUr0
 HqAkNXoGSFjvdWpdJ6NyluHhWjsYHZIdAfucQdBFFJYuIe7/OnfmzqSFo4LLUKjsjHi9dgcK
 RiupTN2ubgchNVjO06TrQGe2GLESnQko2cICuTrsoCNs1kRiG2NPdXABb3nARFodtfxc7V5l
 CJY8/VyFchXZX13qASDQf8WAJai7OufPTvXjDZHRsd9q238oif9LNoJu1mSwXuF1e5eKFfUj
 LL741sNtPe/wlP2BUOIX25BI5tzlvWxfTgUfvvVcsBPcvBMmPyvp0lTibqr9zm1yiAEyPhnU
 b/CKJrEJStKWMxPkWvtL89AgOBD7n5lnwv7G8ukpylLJJLDPRZ5v59eawDQBg34hYvZyDjoH
 yF3bZfTm04BAbGhPkE6M+c7dDg3EJTyPrivw+R/fe+fOAt2XmYnDv7a27Q6fIJ52a9Sk4/1E
 ruVBSe0EXLz2i/KLxukcHdmZO+9VJpztytjbyctIUypyz4oZoP2tPUTcJ4+fL8G8u1/zKErE
 6lZKpvYWvkfGC7a/zk9bIXmqNAwfhqcmg/TbTGuZyIyfsA8SlWRqMPkZAbm6AIHEjGz6Zklu
 7Sl2w6CGcgDSg1uAdz4cvWqy1/t73ERlPgrBxnDI8VJeVWq+49vcnSjgvgyKsAKCBPC2jrFi
 FrGXUZG/bHA+tZn/sPIiKaIq5aSP9F/RkcKTXPG6buWNDXB+jbxy4F3T+vVLyvWU3n5+fv+a
 LwNne38KvAOgH1Dr5F4T+Rw1as76tbi++1awwBjECmZZlinEOo9cHyP3M0JvaxR3L5J/wCxX
 xvXqNVdPLyIPuLjEUIQe1V5PrjSi6lMl2mA9+kxLWX7+DRzreiOXkhlNhWRjDBQceluO4Q/z
 OZ94MMb5mRTUPbx3gpqWsyMy1mxEw==
IronPort-HdrOrdr: A9a23:aVnRm6wrDVK3qNNYKL4jKrPxwOskLtp133Aq2lEZdPULSKOlfp
 GV8MjziyWYtN9wYhAdcdDpAtjlfZq6z+8O3WBxB8bYYOCCggWVxe5ZnO3fKlHbak/DH41mpN
 hdmspFeaTN5DFB5K6QimnIcOrIqOP3jJxA7t2uqEuFIzsaDp2JuGxCe3um+wBNNUB7LKt8MK
 DZyttMpjKmd3hSRsOnBkMdV+yGg9HQjprpbTMPGhZisWC1/HiVwY+/NyLd8gYVUjtJz7tn2W
 /Zkzbh7qHml/2g0BfT20La8pwTstr8zdloAtCKl6EuW33RozftQL4kd6yJvTgzru3qwFE2kO
 PUqxNlBMh342O5RBDAnTLdny3blBo+4X7rzlGVxVH5p9bieT48A81dwapEbxrw8SMbzZ1B+Z
 MO+1jcm4tcDBvGkii4zcPPTQtWmk29pmdnufIPjkZYTZAVZNZq3MEiFXtuYdk99R/BmcEa+L
 EENrCd2B8WSyLRU5nhhBgh/DT2NU5DXStvQSA5y7moOnZt7TJEJnAjtb0id0E7heAAoql/lp
 r525tT5cFzp7ctHNpA7cc6MLyK4z/2MGTx2Fz7GyWVKEhAAQOJl6LK
X-IronPort-AV: E=Sophos;i="5.88,349,1635220800"; 
   d="scan'208";a="63093442"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=A2NVlwOP9FuScixiZ5Ra+iJbOoPiaCEfJQi4+4Ok+7/bcrqSj9FAzz/pFIJI1vUY9IPubXb36jRZpXgMldWOlINUCMHgJljYOkpMMQzqEJZsq+SfABJF5KvFWnybu1RN1NQbT4shiYicbm3NhWInlryEnDOIrjkiQnzglICeGFPuHF3srTYwdYWLfwLh5yS4AI0wyxe4ilxzEzHgIPRuWoF8Enm/q3Bg+L/tgpHnpa1dLxb8pJAtnuGOMSq7GtWH2joMO15R6xmsOk2Xw6RHMCHL7DuFoxETl8Y+uH5euh+HgrRc0e+oF5hZAD/zpUsoEAWpNyTGaDOGgtJhduX85w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=VEeXKVbnTMbn+YEPq4f+m3PlgmzvcLxxiTX+clLn82I=;
 b=h8fih15CJ8aVLDURuvVCD2m+p2pQl0QjXkKmJE5xHbkiPxfvC0IAz39mqpK1rnl8jgZZeEaRjGcV+g9nD4cxioBu+P+YfkdKIeilGAcelXHNO4n1kZSf8iGHa3YPlX/7xsLihgXmpympTp1Zu6feBFJdSP5QjIdjY8vTaocIiHE64EfkwKx0Tq3cjVMN+LM4oFUANuiZDnE7vgeWyG+Ne9stppCl6Y0EX4xAr9QAsMUQruT+qquG+Faw1oghC4BtAJSYszEz5ly+n0jL1Sdhhm6tto89hvZV1i0WaUayFllGOG5xWx5Xjd7V67ZuG/ZfmxKl0d0RsBYcGu9X2fBQ+A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=VEeXKVbnTMbn+YEPq4f+m3PlgmzvcLxxiTX+clLn82I=;
 b=QItI8m38KZdHLJ9ppJA5lvbRs0ziQTmU5PLPZScYV8rutFPcVY8r1le+iOfXWPY7Ke5Yq+5jI0tn9+Kln6cfvRqJwi1VYrFp9C7+9DJkCF5yfB2fdLDjdhOWDCQUluvQ6MesX31h7HpwrO8AfgslSvnF3DyZj5Gz9KeGNifd0uQ=
From: Roger Pau Monne <roger.pau@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Roger Pau Monne <roger.pau@citrix.com>, Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: [PATCH v2] dom0/pvh: fix processing softirqs during memory map population
Date: Mon,  7 Feb 2022 12:20:08 +0100
Message-ID: <20220207112008.51085-1-roger.pau@citrix.com>
X-Mailer: git-send-email 2.34.1
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO2P123CA0044.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600::32)
 To SA0PR03MB5610.namprd03.prod.outlook.com (2603:10b6:806:b2::9)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 434b424c-43be-4748-b803-08d9ea2bd287
X-MS-TrafficTypeDiagnostic: CY4PR03MB2806:EE_
X-Microsoft-Antispam-PRVS: <CY4PR03MB28067B911A36A310C567F4898F2C9@CY4PR03MB2806.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:422;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: pBfF3EYAA/WAYfHV4de/RBWJWctZPmFpoEbnqErp6tc4SR/jNrBiIJtVzVhsGV/2CdKoE1u9cXie0V6jE6tWhCq3CJB8TzCIy/uYbrE9W1SNSMfUzzHElIJBBzpFanv2/VLwLcu3gRX9IXDHA1jLmFGWO6fI2QeRrkDtKObtbkuyfY3QA5aloupvIpJf21ofamcsE+74PpwtqQlUio/6f/kCFzDO9xbf368Yo+39OWEa+tqJ0lqoL3K2a6FyIkFb+cKrjN6ikz9oBx7dOr5JFB6jKV/NKzgstBWJgWkjY9BVhkZhSyhtfmVWtY6hBF39198cZYMjHVBNJSQkKCpWIb+Z8KmtFacIwcqXeJ9j4/Eq6AG8dr7Yi6VTvpdp6z2ql8whdhxUeAbXIiuxZRXO/C9ktBBlETZ8KjhWBD7GC2JI/WQbasa3o1XxX0+IXVoRhgiYbhjh0b8Jk5jiGenFjjRt2v+eXT5MxmdtcgPfMyXWrAlVEo2nhi4nn9zhC2j6YO355LL3A+iISVAlwWjTmwHk/qPH7yRza8lYCqDC5WmhuHN3NeU7RkDhjz78pV5vwWjMnYK+VUftlXOSp1WoC3cLn9/m8t4P6Z4TSZqh93lc9WSCsNjPLJ7YBcj3JOr9EWIfbm95KZIdHpObQfH5jQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA0PR03MB5610.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(2906002)(1076003)(5660300002)(508600001)(54906003)(6916009)(6666004)(36756003)(6486002)(83380400001)(2616005)(38100700002)(82960400001)(186003)(6506007)(66476007)(316002)(66556008)(6512007)(26005)(86362001)(66946007)(8936002)(4326008)(8676002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dmUzSVJyd1dadG9ReFpxQmt6bnRPRUx5b1BTZW5HVG5JaXNlVzhEeTdpbng0?=
 =?utf-8?B?VW8xRHNYNllmNk9WRzZKYmRucDlQOHBCeit3Nm54TW1GNmh3RGQrcEJLVG8w?=
 =?utf-8?B?UmQ1RFpYeG9BTDdjMjN5eE9UUkxkeWgra1lGak1qZ1AzcHdvUHJhMDE5aVF0?=
 =?utf-8?B?SlVXVzdpQnpLY0VBaEJFdUdGRGFJaWVSYS9kZW5ISWNoRXdzSkhaRmdwWmVB?=
 =?utf-8?B?RTdOWlBCTUtlOVh1RkdsUzlHSU5EaTdOQ1c2RE9VaG93bFY2MU1tQVhjTlpZ?=
 =?utf-8?B?MnZQMjlrUlpMS3VGZDBHUVkxOXFpbmJucmV5T2RodkswSFREazR3RUFJTFdj?=
 =?utf-8?B?TjczN1lMOGlHQXI4MUQxZnd3UjJaQnVYN3hHSVVXL3lzN0RzdnlRa1BtWUUz?=
 =?utf-8?B?L0pWaitQcmgyT2RoMzJPMVJUeGtvZmJOa0k0cEJZejJpL0tFcy9qUEhvaC9n?=
 =?utf-8?B?c20wRXQ3Q09Cb3Z1UmhFWnBqWUxCeW1VMEdsL3Z1amYyeDBFRFNtL1JtL2s2?=
 =?utf-8?B?SXBacnZNVUdzTDBmRDg0OHlzNngvRFRZTHlQZVZzOFlkY1JMUXQ5SFljWnJB?=
 =?utf-8?B?UXBiMDRDZmZqdmVHem02N256aGk5Titoc0xxYzY2czVVTHVxUGJ4RG9ZLytS?=
 =?utf-8?B?ejNOYlgxY2NKNFhTRE9ZK012OTBkVjl4QXV5Z1VwVmFwVjB6OExWUjRkb2I4?=
 =?utf-8?B?ZytybWRyTGZDV0FrMHppaG1xdlpuWDNvVFlzTEZxUkJ0UWxHZnJvWlRrbjJS?=
 =?utf-8?B?S0pSODR0V2RmRitud3RpYkNuVEsydm4xMk03cSs2WXRVN3ErTkJNRGNHK2dS?=
 =?utf-8?B?SHhRNTJ6ZUNhOHNkeDJPMkF5b2RKSU5Dc0RtbXRJaGFaRERUTjl3anVwTHln?=
 =?utf-8?B?dWpPQTZscFVQSTFmT20wL2RnVzM4TlgyTm9RVGorVUhTTzNFMVBoZVVKREVZ?=
 =?utf-8?B?c0xhdFhOM2VWQTdpL3VUVFV4Ny95Q1Z2T2lkcUVUN3Y0QlM4OTBXU1UvQjBJ?=
 =?utf-8?B?SS91K2NvZ1RpanEzQ2xrTm13Sm1IN3l0bW5sSXh4RW1YUk9hM3FBc01lS0cx?=
 =?utf-8?B?UkVrelVpK20yUy8venNRamt4Qk02NmlGTm1lUmF6ODIzYmJsODdKRlZGUktm?=
 =?utf-8?B?Q0pHbGlPeERKVHZGbmFzcmg4U2o4UFdleWhwRVN2QzFsUFBDb1JOczBVeU4v?=
 =?utf-8?B?b1VMcUk0SGVCWGpkamtmN2Uzc2JZQmY2Wkk1Ykl3MjB5czdjWWc2ZnBOV2tQ?=
 =?utf-8?B?WGlOaGE2OWdFVmNvcERRdDFQY0FjZWthZUNFakF3K296L1FIeUdxMEw1WElF?=
 =?utf-8?B?Zkphb3JyU3R6eE5tWVVsY2MvM3BiQmk4cDhpVVJ3UTZ6QmRPcjQ0RkJFN1lC?=
 =?utf-8?B?bkhBNmMzbWw1ZFJpUzAxSHV6TzZiS1MzVnA5cFNyRFBrdHRZd0p0NlJrMWpp?=
 =?utf-8?B?Z3h6UndxYzN2TnM5ZW1sTjBpMDRRK21NaUhoL3BZWGZBYXRrbDFtbCtaZTRa?=
 =?utf-8?B?RVZyNnVSamk5SXhmQi9wOVhMQlNBNXQ2aWRjQmlBZjE1RnV6Yk14Nm5SR3ZT?=
 =?utf-8?B?YVU0R0g2NWdBMTVSNEc3YUJrbmczTXg5OGRzYXdIMkJWc1I0bzQ0Y3NialN3?=
 =?utf-8?B?Wmxrdm1rVVpNWVVieUhhZlh3eTFmYkJxcGVVYmdVd3M2ZGRNaGhDSGlWZ0g3?=
 =?utf-8?B?alMvenJWNFhETHQ2eDBaYkxBbmQwZXp4WVdjS2wrVVg5bFREdm0xQ1RjWFIv?=
 =?utf-8?B?TnVmb0ViTUU5RG1INGNvZURsOHVIWFpVQXJYalk3WTROdmlXa041L3VBbExx?=
 =?utf-8?B?ejJOdkJvZUd6cGIrM29BU01FOFJlSk9UVFV1U042WlZ3QnZPVklsM1VxSDlH?=
 =?utf-8?B?eWJpMmFaRlhRZjNuQm8yU3h3cVNNOHgxdXZTYUVXWjNoMjJvZFcyQVhPQzBS?=
 =?utf-8?B?S3g2TzhRa0pHTktrL0d1OTNraiszM0VOS3lKZnVmRXZ5VVMzeWZRRGlsOGRx?=
 =?utf-8?B?clFUNUZKcEtqcVViUmY0R3h5VFh6b1E0RzNWbFZtdmc3SDBoaEE1ajdjeEh5?=
 =?utf-8?B?Mmo2QzNsZythcElvZldhalhQZGZzbFB0MDlDbUI5YVlqK1VEM1o0NlZZV0Jq?=
 =?utf-8?B?czZBdmdrWUR4ZndENSsrOVd0WHJhbkVCbHJPRXRoZll3ODJZcm1nOS9OUHE3?=
 =?utf-8?Q?Jm5uqLQ5u48Wdi0A8+/r7fU=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 434b424c-43be-4748-b803-08d9ea2bd287
X-MS-Exchange-CrossTenant-AuthSource: SA0PR03MB5610.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2022 11:20:19.1896
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /ggk1RzVaV0ZfO/rKqYeEqgQS+LEK025rX5sUoBTacST4tkGnwoYW9930Ad2t0ajWwgxPiiHP9WORi/VcTTgGg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR03MB2806
X-OriginatorOrg: citrix.com

Make sure softirqs are processed after every successful call to
guest_physmap_add_page. Even if only a single page is to be added,
it's unknown whether the p2m or the IOMMU will require splitting the
provided page into smaller ones, and thus in case of having to break
a 1G page into 4K entries the amount of time taken by a single of
those additions will be non-trivial. Stay on the safe side an check
for pending softirqs on ever successful loop iteration.

Fixes: 5427134eae ('x86: populate PVHv2 Dom0 physical memory map')
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Changes since v1:
 - Unconditionally process softirqs after every successful loop
   iteration.
---
 xen/arch/x86/hvm/dom0_build.c | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/xen/arch/x86/hvm/dom0_build.c b/xen/arch/x86/hvm/dom0_build.c
index 549ff8ec7c..cbc28113cb 100644
--- a/xen/arch/x86/hvm/dom0_build.c
+++ b/xen/arch/x86/hvm/dom0_build.c
@@ -114,10 +114,9 @@ static int __init pvh_populate_memory_range(struct domain *d,
         { .align = PFN_DOWN(MB(2)), .order = PAGE_ORDER_2M },
         { .align = PFN_DOWN(KB(4)), .order = PAGE_ORDER_4K },
     };
-    unsigned int max_order = MAX_ORDER, i = 0;
+    unsigned int max_order = MAX_ORDER;
     struct page_info *page;
     int rc;
-#define MAP_MAX_ITER 64
 
     while ( nr_pages != 0 )
     {
@@ -186,12 +185,16 @@ static int __init pvh_populate_memory_range(struct domain *d,
         start += 1UL << order;
         nr_pages -= 1UL << order;
         order_stats[order]++;
-        if ( (++i % MAP_MAX_ITER) == 0 )
-            process_pending_softirqs();
+        /*
+         * Process pending softirqs on every successful loop: it's unknown
+         * whether the p2m/IOMMU code will have split the page into multiple
+         * smaller entries, and thus the time consumed would be much higher
+         * than populating a single entry.
+         */
+        process_pending_softirqs();
     }
 
     return 0;
-#undef MAP_MAX_ITER
 }
 
 /* Steal RAM from the end of a memory region. */
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Mon Feb 07 11:26:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 11:26:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266753.460457 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH2AG-0006z3-L6; Mon, 07 Feb 2022 11:26:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266753.460457; Mon, 07 Feb 2022 11:26:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH2AG-0006yw-I6; Mon, 07 Feb 2022 11:26:36 +0000
Received: by outflank-mailman (input) for mailman id 266753;
 Mon, 07 Feb 2022 11:26:36 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nH2AG-0006ym-6W; Mon, 07 Feb 2022 11:26:36 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nH2AF-0000zX-TZ; Mon, 07 Feb 2022 11:26:35 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nH2AF-0005dP-B4; Mon, 07 Feb 2022 11:26:35 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nH2AF-0005mm-AY; Mon, 07 Feb 2022 11:26:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=6I6FCs5cAQs1SVjKc/ZEmstH8qhgZCHsz3C6weRYNRE=; b=uysw4jYk4o0pRGsPqUOb8OA54a
	OZys8U1lJYDNX7NkSOtJtu5ifkolga2gBvzZisXqYpDsjXK0iw4eLLUuW99zNSiEBRVBvOD5k7BkC
	KoydWg4dU5zRy09T2hkj0/9BJDHr0iDbFl1rcqzSpT/vb89fSgn1+xGb4Kpqr1FxmpIg=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168037-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 168037: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-i386-libvirt-xsm:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=820cc393434097f3b7976acdccbf1d96071d6d23
X-Osstest-Versions-That:
    xen=820cc393434097f3b7976acdccbf1d96071d6d23
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 07 Feb 2022 11:26:35 +0000

flight 168037 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168037/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-i386-libvirt-xsm  20 guest-start/debian.repeat  fail pass in 168032
 test-armhf-armhf-xl-rtds     18 guest-start/debian.repeat  fail pass in 168032

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168032
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168032
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168032
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168032
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail like 168032
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168032
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168032
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168032
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168032
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168032
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168032
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168032
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168032
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 xen                  820cc393434097f3b7976acdccbf1d96071d6d23
baseline version:
 xen                  820cc393434097f3b7976acdccbf1d96071d6d23

Last test of basis   168037  2022-02-07 01:51:51 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  fail    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Mon Feb 07 11:27:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 11:27:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266764.460468 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH2BF-0007aZ-1J; Mon, 07 Feb 2022 11:27:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266764.460468; Mon, 07 Feb 2022 11:27:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH2BE-0007aS-Tc; Mon, 07 Feb 2022 11:27:36 +0000
Received: by outflank-mailman (input) for mailman id 266764;
 Mon, 07 Feb 2022 11:27:36 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=F54n=SW=epam.com=prvs=403792ff6c=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nH2BE-0007aK-3O
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 11:27:36 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f17d245f-8808-11ec-8eb8-a37418f5ba1a;
 Mon, 07 Feb 2022 12:27:34 +0100 (CET)
Received: from pps.filterd (m0174680.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 2179ge3Y031345;
 Mon, 7 Feb 2022 11:27:30 GMT
Received: from eur02-ve1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2053.outbound.protection.outlook.com [104.47.6.53])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3e2xqt1b5r-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Mon, 07 Feb 2022 11:27:30 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by VI1PR0302MB2829.eurprd03.prod.outlook.com (2603:10a6:800:da::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Mon, 7 Feb
 2022 11:27:25 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77%3]) with mapi id 15.20.4951.018; Mon, 7 Feb 2022
 11:27:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f17d245f-8808-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=CtrIs+uIvqu48KuICGcBEHAFrHDWfE/Sswk+/LpBwCnabFhn4iBVD7qSTjEJCRgtV343zdCtuCsdGZxPiykEJWv+3wvR8byGFwnjLBpaNLlsPstVqFWqnfPdVWASqRapfe/61UaNpCH0h28WCBRspbN7NGhdnSIoik0k888yy3VbnW0klgptFyYV2z46RqUpV8wH8g11R14BWtzhe8m8uw20Mktfc4kYxFdGeLElmfx3m25rFpJM6XlMyXlIulKPGF8QPMuycyJDe93Dw/6oBL1gH3Ohu11WSkylUOkq/ClVcZplJp1DCr4lICEP/xL3GZCmcLLizxp3StK9EI/DtQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=kDt+cwtoR7ZZwhNkFnxN2q6lMj2E9WZmyXTOAn4yw7Q=;
 b=IE/+d6vqrPWaAknFTqQgj7Z72h6HfZza2Hs5izYRNYw0YhpfGhlNVrBaTWjcZEmoPlf4zHy+Yqg4lpUnuFX95EBoNsaDwFkfHGn5b/drnkzbmzVZ31fj846QNiQv/ZJ0BzyLX/e/BEOA1YDpTIuwBGm3lrBLHg6vdchYsbWlNRbRCkLLjp8CpFuCSbTBixO/m3+hvXBNBEvV+blRzG1N2iJ7K/JRCmjjYgXnvlTjO9Wv1X23D5rHrwvqz3uUtJGSUzw4+zMsCeKlshINZoIko1ffb4JUEZ3iXM295Gc/YdZx9rO13OtPuwt5F/LyBf/GVHyNzQnSu9mg9zTyc/orkA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=kDt+cwtoR7ZZwhNkFnxN2q6lMj2E9WZmyXTOAn4yw7Q=;
 b=SX7DKGSOrBBT2cHztDbs84agvGB7oszCyBDzJBcdQFtB+Y5imKhScVbN19s9GPq6GRfoSEbwE7sPe8nK5Oc9+NFQR+cYo944zuRtY80BOqVnpk0HH2Rev72cb6+bb4in+875xC1XiA+WbPwrcM1XUieuw1Ufosa/Zq2fZBj6h/zLhmE5C4CxySq13RY0qZRiGvIAKgAI99/+gSF+0p/zjy482R3tD6KcBQy0pAXOWNeluFR3Asn7fDoJUw84MJBIlk+XNSkdWJAuSNWCs516+GRLAJZxhooLq4J2vc7/epmrpwb9S5pQPhl6d4BqFzQwK+i6a+DroxAjKNSSE41UMw==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "roger.pau@citrix.com" <roger.pau@citrix.com>,
        "andrew.cooper3@citrix.com"
	<andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com"
	<george.dunlap@citrix.com>,
        "paul@xen.org" <paul@xen.org>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>,
        Rahul Singh <rahul.singh@arm.com>,
        "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v6 10/13] vpci/header: reset the command register when
 adding devices
Thread-Topic: [PATCH v6 10/13] vpci/header: reset the command register when
 adding devices
Thread-Index: AQHYGZFg3nazYSvfA0G+yHTbxcxX2ayDdFgAgAAB6wCABD+NgIAAQmgA
Date: Mon, 7 Feb 2022 11:27:25 +0000
Message-ID: <2ad372d4-a181-9307-ef50-a5adb61dae66@epam.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-11-andr2000@gmail.com>
 <96381d7e-dafc-acee-3abf-f9815deb207c@suse.com>
 <ef76faac-f9d3-1cb8-06b5-189ccd299542@epam.com>
 <6f0a015b-c48f-76ed-9a51-39c045ff5927@suse.com>
In-Reply-To: <6f0a015b-c48f-76ed-9a51-39c045ff5927@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 145ea3a2-01dc-4d1c-2644-08d9ea2cd116
x-ms-traffictypediagnostic: VI1PR0302MB2829:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <VI1PR0302MB28291296C4E8395D9FB32E1EE72C9@VI1PR0302MB2829.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 KSlB7i/+gpY722HMwnPUnIjYvLRzIn7yN2vdWTY9cNY9rmNu8GIHO4nZ2ieM3q2+vyWDkFlkn/GZVPIQT6h4pEcIlwxjzOcVBGs8FL0XWGtHRoH3xFqoBLl9nw5TB8atsuMTRxgDFAucOMeGR71UDyIC0mNpNMF5raPTHsaKJGMgX5qC6lwcfePmvzjuNEP3Z31T7kRA1YcjJy2d+ARGCA0yw2ygM8CXW8GYoRBMOC+HyTLB9gvBfIN3KRkVsuaOaSoQgHQ6WBzWSt9CDSqIK5Qn/00+B3i/D8UrIv+glDpNBjIkQclsRqkv/yuN7yn3NnFQ/zsdY2NZg/avyoOaVob50hNS/feo4ThshwBBrCBH2ex0apsE16j16oqe9pr+O0mdtvu9EZU8RY0BxTGN62rbW70OjVzIlRydPUBtB+R++wb/LKgAD7WInCHsNyDw1MTtzdQBhhVrp3YfYGEvG6e3A8wSxFQn6kLaZBD+thw59QVRplVK50R/NWfhPrTkLRCgwOgo+LzxfNUVzaiW7mBlk8tCXwDb7m3XtIafEmR8hzuMPnWtZj94mP+UKUMIyVqsLmS3WlYLcV1cU/vY547ZxtvdBpysfNQahefgKkyptuLbOQk0eqlP0Pv4DuTDOJipxRcp8JFUZiUfvqPXkcKjOiJs4LsoH0zsubCet29AHMbJWJaIchjL00OE4HndIRn0aWYhHX9KaBfdrHTtCgP9W94VVOAUf9a/oTIWgn0crfP8W9XKBjweXOKyiBII/JeYzPa48HwvNAZFMloY0zkwNzcN7G7/3IQqj+OwFn/GQGLS90a7RWGT0e8rvrx3
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(2906002)(966005)(2616005)(31686004)(6486002)(26005)(186003)(38100700002)(7416002)(508600001)(31696002)(6512007)(86362001)(5660300002)(76116006)(66476007)(53546011)(55236004)(122000001)(54906003)(316002)(6916009)(64756008)(91956017)(71200400001)(4326008)(8676002)(8936002)(66556008)(66446008)(66946007)(38070700005)(83380400001)(36756003)(6506007)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?N3BGRlp3bDBwa1VDWjhYbVFtNnBwd01EYm4wdW5BTWwzanR1UndLZ3ltNWJw?=
 =?utf-8?B?d2h5YnZTL3JOWEkyQURBNjVKZldIVzBxZHI5amNzTWE1YnB2QW5kRGJveDVw?=
 =?utf-8?B?MGRsOEtWYmh2N2Y5QXRjVmEyYXBxdjI3em9kWlV1YkwvOURPcGNRVGNkM000?=
 =?utf-8?B?dmtpUm5Cd09ReTgxNjBYa2xMK2diSHpQcXA2cDl2anlpMDdUUTNjdkYxb1Rm?=
 =?utf-8?B?SjhyaVBMdENpclZlOGYxQVRyVW0vcVg0RFlSUDlrLzFUcTUzOG5kem9HV2J6?=
 =?utf-8?B?RExTQnAzclBqS2xYMU5WVWY2ajExVFBZRUtkMmRRb1NqY0JmZ3NZQWJLNDBN?=
 =?utf-8?B?K1ZOVU9GTVR4bzIvRXVUU3NmcVNvMzE2eE5hR1N1YkFpRC81MTYwYVBLcXpT?=
 =?utf-8?B?a050Z05sdkZDVHFkRWRwNmdoRTJjMDkwSXZwL0NLN29BbHl6RzFMWDNDcFBJ?=
 =?utf-8?B?R2FLeGRzSU9SbnJKaUNka2EyaUlEb1pTcE0rUkdpcW84emtpUkxNKzUvNGZD?=
 =?utf-8?B?R0V6ankwa2h1RWVhczZncUI0bUNzeG9hRFJUdzQycW9uR0UzQWtiT1Yvc1VG?=
 =?utf-8?B?YlIyamE2dlVlZzFMaURVL20vaTVhRjBDV1d4VVg1K2hLU1lUUS95WWJUQng1?=
 =?utf-8?B?MzFpRWZ5Z042clZNbFJYYUpnQnUzd3FoTENlUFdYaWRacFFWaUlyQ2pOWHNn?=
 =?utf-8?B?RXJGS3FMcUFNbGV2d1dCV2VoM3NrYU4zaVRiUmJvSkpBdzVDV1p2QkNtbFoz?=
 =?utf-8?B?ZkJuUWg1TVVqTVJMdlkvckMycmppM2RJV3Vyby9tcWFwbktOQ0xnWU9IT3Rw?=
 =?utf-8?B?NUdPT2Vzc2RiVXozK3hxWGd3WTR2dXF0b2MvSS94N0h2Skw1WWdzbVlsY1o0?=
 =?utf-8?B?SysrS2ZzaUVMcUo1QXVvRVBjZVNUNEJ0a1pHUm9jb3ZVRUhVVyttbzJ4UGJK?=
 =?utf-8?B?K2VKK2xhYmtNV0JtOWZVNWtpbzRzK0FWRGpIRlV1N3pIajhpTzJqVXFFdUVt?=
 =?utf-8?B?YkI5Q1JmMWdqbU1YS0RKb0IzR2tMT1ZvMklyS1FIb0svQXc2dHo5YnhFNFFq?=
 =?utf-8?B?T2Y3dS9RM0kwZUQ5TVV3MHdNWHh4d28ya2J6anZib0FQZm5wOGM2aVFxbEkw?=
 =?utf-8?B?SjNHbXlQNitPNXlnbVp4TEJ4eXB1N01ZQXJtQ1BjcDBxQlZ6M0lyY2cveUEv?=
 =?utf-8?B?QkxJREVBeUgxYk5tN2xNQXYwZkgzVldDZ0duTDJRc3YybjM1V0xUQWZ0MWxR?=
 =?utf-8?B?SzAvWnZ6MmRNQk9wTld6bmRCZWtTcURrY0lVQWhJYnpyWGdSZkx0R1JkOStN?=
 =?utf-8?B?QU1XM2l6RmN1ek42bFZSUjl1eVRvMWRBcXdDcmtxampGQmFXRGlJaWRxNDdG?=
 =?utf-8?B?bDZGTFpzdS9FRVVEWTlNa1hMNVZFanE4U2VKT29pUzRYR29CcTRkY2wwbDJr?=
 =?utf-8?B?SjExWnNWc2haaWZnN0dLUzJXOEE3M3l1cUdKYlBqTW9ZblpNOFBjT3A4NTBO?=
 =?utf-8?B?eCt1L2syWERXUTB1N1pzU1RDaURpeitwSk5Gd2xTaEdTVG1BOTZWY0o4ekZv?=
 =?utf-8?B?ckxrY1NoUThlbzNwQWc5bWRRYkdaUzZ6bC8rTlNkaWl0eFpQc1VQQm4vOC9o?=
 =?utf-8?B?NTBmVzUzRm5rbWFWdjhqb1gzbSt1Q1o3SVlPeVN0YklFa2VyWS9YNG9sYWsx?=
 =?utf-8?B?dXRtdjZsZk00aFRwNUtoZlNlZlhka0crQVhPakpubjJ6TWhHeU5yZ3FqR2M1?=
 =?utf-8?B?RlZnUmhJZ2JzdTV5VjRNak11OVpwSlZlUkN0LzNvemxQRDA4SStQWXlyMzNP?=
 =?utf-8?B?TEdJS1RYNVVNaVM0OVRpZDgzMGJ0Sy9KaThIeVU3Vm9VYTZJMUZmQko3WmRU?=
 =?utf-8?B?eDA3eXVURm83NFFwR21VZzVBSkNOZU54aGNPcG9tWVphaG1uYjk4YXU1cWJa?=
 =?utf-8?B?ZjczcDdJTUo0Q1IxRHl2NllUOTBZdFE0SnBUVnJuTXFYamV5UlFLN2FTYkds?=
 =?utf-8?B?a2JnQkpwS1JHeTVoQ1lMKysza3JONEdBNGo1NVJWZHpFTmdCZkdHTHZQL25o?=
 =?utf-8?B?WkdoaEk4a01nNExnVWVFalJwWFl3WjNuc2xlYkZDMFdRUno4VzNLUHNNc2t3?=
 =?utf-8?B?OFNZT0FxTjNRWUMrRTJETGNmcVpGblZQNzJON09Fd0xENmJYSkp4WklVTFdk?=
 =?utf-8?B?WHFZNnpOb3NuZlRtMmxwUkg3d0U4NXNMWXBVdXNoMUV2eWlTQWtaR0UyV2VI?=
 =?utf-8?B?R1RSUUozQlFCZDRBeG1BSk44U2IxRXlUcGhnY0VOSGZ6VWZMeWU4VFFBM2Nz?=
 =?utf-8?B?UWxjaTdtUWZIbEt5WlhlV1BZV0xVTmFpY3FBS2FicVliZktmYXVXUT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <C5836A6A90722944833021E64453E7F3@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 145ea3a2-01dc-4d1c-2644-08d9ea2cd116
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Feb 2022 11:27:25.5892
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: DmQFpMYEgfQIqoMYYqQetoRoCPHfoFtdAABXvX6mmq1sPx7BCM0wXEavilpgfNrYvx7PpxawmRUME36Ur25q5Pn5AssRY2x2m0V83qLdfTET93GL+GglS3IXArqi8Oud
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0302MB2829
X-Proofpoint-GUID: KXaxsyHVC7ziJF_ypjYmEaZ56TX_vh8_
X-Proofpoint-ORIG-GUID: KXaxsyHVC7ziJF_ypjYmEaZ56TX_vh8_
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-07_04,2022-02-07_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0
 priorityscore=1501 impostorscore=0 mlxscore=0 adultscore=0 malwarescore=0
 clxscore=1015 suspectscore=0 lowpriorityscore=0 mlxlogscore=999
 phishscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202070074

DQoNCk9uIDA3LjAyLjIyIDA5OjI5LCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMDQuMDIuMjAy
MiAxNTozNywgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+PiBPbiAwNC4wMi4yMiAx
NjozMCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+Pj4gT24gMDQuMDIuMjAyMiAwNzozNCwgT2xla3Nh
bmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+Pj4+IFJlc2V0IHRoZSBjb21tYW5kIHJlZ2lzdGVy
IHdoZW4gYXNzaWduaW5nIGEgUENJIGRldmljZSB0byBhIGd1ZXN0Og0KPj4+PiBhY2NvcmRpbmcg
dG8gdGhlIFBDSSBzcGVjIHRoZSBQQ0lfQ09NTUFORCByZWdpc3RlciBpcyB0eXBpY2FsbHkgYWxs
IDAncw0KPj4+PiBhZnRlciByZXNldC4NCj4+PiBJdCdzIG5vdCBlbnRpcmVseSBjbGVhciB0byBt
ZSB3aGV0aGVyIHNldHRpbmcgdGhlIGhhcmR3YXJlIHJlZ2lzdGVyIHRvDQo+Pj4gemVybyBpcyBv
a2F5LiBXaGF0IHdhbnRzIHRvIGJlIHplcm8gaXMgdGhlIHZhbHVlIHRoZSBndWVzdCBvYnNlcnZl
cw0KPj4+IGluaXRpYWxseS4NCj4+ICJ0aGUgUENJIHNwZWMgc2F5cyB0aGUgUENJX0NPTU1BTkQg
cmVnaXN0ZXIgaXMgdHlwaWNhbGx5IGFsbCAwJ3MgYWZ0ZXIgcmVzZXQuIg0KPj4gV2h5IHdvdWxk
bid0IGl0IGJlIG9rPyBXaGF0IGlzIHRoZSBleGFjdCBjb25jZXJuIGhlcmU/DQo+IFRoZSBjb25j
ZXJuIGlzIC0gYXMgdm9pY2VkIGlzIHNpbWlsYXIgd2F5cyBiZWZvcmUsIHBlcmhhcHMgaW4gb3Ro
ZXINCj4gY29udGV4dHMgLSB0aGF0IHlvdSBuZWVkIHRvIGNvbnNpZGVyIGJpdC1ieS1iaXQgd2hl
dGhlciBvdmVyd3JpdGluZw0KPiB3aXRoIDAgd2hhdCBpcyBjdXJyZW50bHkgdGhlcmUgaXMgb2th
eS4gWGVuIGFuZC9vciBEb20wIG1heSBoYXZlIHB1dA0KPiB2YWx1ZXMgdGhlcmUgd2hpY2ggdGhl
eSBleHBlY3QgdG8gcmVtYWluIHVuYWx0ZXJlZC4gSSBndWVzcw0KPiBQQ0lfQ09NTUFORF9TRVJS
IGlzIGEgZ29vZCBleGFtcGxlOiBXaGlsZSB0aGUgZ3Vlc3QncyB2aWV3IG9mIHRoaXMNCj4gd2ls
bCB3YW50IHRvIGJlIHplcm8gaW5pdGlhbGx5LCB0aGUgaG9zdCBoYXZpbmcgc2V0IGl0IHRvIDEg
bWF5IG5vdA0KPiBlYXNpbHkgYmUgb3ZlcndyaXR0ZW4gd2l0aCAwLCBvciBlbHNlIHlvdSdkIGVm
ZmVjdGl2ZWx5IGltcGx5IGdpdmluZw0KPiB0aGUgZ3Vlc3QgY29udHJvbCBvZiB0aGUgYml0Lg0K
V2UgaGF2ZSBhbHJlYWR5IGRpc2N1c3NlZCBpbiBncmVhdCBkZXRhaWwgUENJX0NPTU1BTkQgZW11
bGF0aW9uIFsxXS4NCkF0IHRoZSBlbmQgeW91IHdyb3RlIFsxXToNCiJXZWxsLCBpbiBvcmRlciBm
b3IgdGhlIHdob2xlIHRoaW5nIHRvIGJlIHNlY3VyaXR5IHN1cHBvcnRlZCBpdCBuZWVkcyB0bw0K
YmUgZXhwbGFpbmVkIGZvciBldmVyeSBiaXQgd2h5IGl0IGlzIHNhZmUgdG8gYWxsb3cgdGhlIGd1
ZXN0IHRvIGRyaXZlIGl0Lg0KVW50aWwgeW91IG1lYW4gdlBDSSB0byByZWFjaCB0aGF0IHN0YXRl
LCBsZWF2aW5nIFRPRE8gbm90ZXMgaW4gdGhlIGNvZGUNCmZvciBhbnl0aGluZyBub3QgaW52ZXN0
aWdhdGVkIG1heSBpbmRlZWQgYmUgZ29vZCBlbm91Z2guDQoNCkphbiINCg0KU28sIHRoaXMgaXMg
d2h5IEkgbGVmdCBhIFRPRE8gaW4gdGhlIFBDSV9DT01NQU5EIGVtdWxhdGlvbiBmb3Igbm93IGFu
ZCBvbmx5DQpjYXJlIGFib3V0IElOVHggd2hpY2ggaXMgaG9ub3JlZCB3aXRoIHRoZSBjb2RlIGlu
IHRoaXMgcGF0Y2guDQo+DQo+IEphbg0KPg0KDQpUaGFuayB5b3UsDQpPbGVrc2FuZHINCg0KWzFd
IGh0dHBzOi8vcGF0Y2h3b3JrLmtlcm5lbC5vcmcvcHJvamVjdC94ZW4tZGV2ZWwvcGF0Y2gvMjAy
MTA5MDMxMDA4MzEuMTc3NzQ4LTktYW5kcjIwMDBAZ21haWwuY29tLw0KWzJdIGh0dHBzOi8vbGlz
dHMueGVucHJvamVjdC5vcmcvYXJjaGl2ZXMvaHRtbC94ZW4tZGV2ZWwvMjAyMS0wOS9tc2cwMDcz
Ny5odG1s


From xen-devel-bounces@lists.xenproject.org Mon Feb 07 11:58:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 11:58:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266777.460479 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH2fD-0002SG-IW; Mon, 07 Feb 2022 11:58:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266777.460479; Mon, 07 Feb 2022 11:58:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH2fD-0002S9-FW; Mon, 07 Feb 2022 11:58:35 +0000
Received: by outflank-mailman (input) for mailman id 266777;
 Mon, 07 Feb 2022 11:58:34 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=hYSm=SW=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nH2fB-0002S3-VQ
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 11:58:34 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 43da9580-880d-11ec-8eb8-a37418f5ba1a;
 Mon, 07 Feb 2022 12:58:31 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 43da9580-880d-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644235111;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=EjwaVC1lOWXbxNK4ho7Km/hkukehryEVbCaMpGrr2Gk=;
  b=HbG5e7r0aMIYtwMx557AjF9b8AxBXZEnNrY4P1FeDLldOxPUwxQ9V+HW
   +61RoRrPJ3Q9tiZu9RbRpd9YqcnQ407PQh+8e/mazdtOoi027tPw2u4F7
   x/VwHa0tBkfAA3xr5OKLPQdGVvQFk6si7+mbwoGh3J5IwPgULiuL2q94h
   M=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: jkFriPrE20WyII4DKXoa+b1H6ehKmfe5a7Oe9IkTuBQ++3GT5ONYUgKexR5Mtj8KZqYDXRixcy
 KpcMItXx6VLNTaOU0+Gdc9bpJjEJpvh0xP4IDR0fo7D7vnwPvMgSVEqIx5A8YSEj0TKI0hZ6kj
 WXXjUS2ECt+GymQ3EyBB4w6/Ln3ep4o8vRTtXBfrkPZzaUmchkCRn5w3GP4iET8mb3JBfy54TG
 C50BxczQu93ejH8R9S3cUhOvAdghIobKp57uxS3+LH5X86tGlTQ8bJpA64UEQYjA5QTmRzt0EI
 UldklG6ruKjxHvfU4kFc6Zpv
X-SBRS: 5.1
X-MesageID: 65845262
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:IAe4w6pR/WOHqARp0gwEiQedUJdeBmJHYxIvgKrLsJaIsI4StFCzt
 garIBmCOfmJamb3fYslb9+/o0kD75Dcz9dnGwZu/iEwFCIUo5uZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlZT4vE2xbuKU5NTsY0idfic5Dndx4f5fs7Rh2NQw24DmW1rlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCnbfoQwgSGoLipNYQS0ZBPDt3JYl/x7CSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFJkYtXx6iynQEN4tQIzZQrWM7thdtNs1rp4TTaqDP
 ZRDAdZpRETvYx5lBw82NL87uvyruCD/dC9esE3A8MLb5ECMlVcsgdABKuH9cNGQWd9cmEreo
 2vc5nn4GTkTLtnZwj2AmlqSgevIkTL+SZglPrSy/f53g3We3mUWThYRUDOTsfS/z0KzRd9bA
 0gV4TY167g/8lSxSdvwVAH+p2SL1jYDX/JAHut87xuCooLP+BqQDGUASj9HafQludUwSDhs0
 UWG9/vrGDhuvbu9WX+bsLCOoluaOyIYMGsDbi8sVhYe7p/op4RbphDAVN9nFIa8i9TnHje2y
 DePxAAzh7gWzt4G0Y2+oEiBiDWpzqUlVSZsuF+RBDj8qFokOsj1PORE9GQ3895rdIyWdX2uk
 kQ2ltDB9c8UBImprROCFbBl8K6S296JNzjVgFhKFpYn9iiw93PLQb288A2SN28ybJ9aJGaBj
 Fv7/FoIucQNZCfCgbpfPtrpY/nG25QMAjgMuhr8StNVKqZ8ewaclM2FTR7Bhju9+KTAfExWB
 Ht6TSpOJStAYUiE5GDvLwv47VPM7npvrV4/vbihk3yaPUO2PRZ5s4stPlqUdfwe56iZugjT+
 Ns3H5LUl0kGAbSnPHiNqNV7wbU2wZ8TX8GeliCqXrTbfloO9J8JV5c9Po/Ni6Q6xv8Ix48kD
 1m2W1NCyUqXuJE0AV7iV5yXU5u2BcwXhStiZUQEZA/0s1B+MdfHxPpOLPMfIOh4nMQ9lqQcZ
 6deJK297gFnF22vF8I1NsKm8uSPtX2D2GqzAsZSSGJjJs47GV2VpYOMk8mG3HBmMxdbfPAW+
 tWI/gjaXYACV0JlCsPXY+io1FS/oT4Wn+caYqcCCoA7lJzE/Nc4JirvoOUwJs1QexzPyiHDj
 1SdAAsCpPmLqIgwqYGbiaeBpoavMu1/AksFQDWLsefobXHXrji53ItNcOeUZjSBBmn6z7qvO
 LdOxPbmPfxZwFsT69hgE6xmxL4V7sf0o+MI1RxtGXjGNgz5Cr5pLnSc89NIs6lBmu1QtQesA
 xrd8dhGI7SZfsjiFQdJdgYia+2C09ASmyXTsqtpcBmruncv8ePeA0tIPhSKhChMF5dPMdsok
 bU7pcobyw2jkR52YNyIuT9ZqjaXJXsaXqR56pxDWN33ihAmw01paIDHDnOk+4mGbthBPxV4I
 jKQg6ae1b1QylCbLig2HHnJm+FcmY4PqFZBy1pbfwaFnd/Mh/kW2hxN8GtoElQJn0sfi+8ja
 HJ2M0BVJLmV+2Y6jcdOaGmgBgVdCUDL4Uf20VYIyDXUQkTAurYh94Hh1TJhJHwkzl8=
IronPort-HdrOrdr: A9a23:CwDYRajtqFwJ8vu+yxww7HfOMXBQXzh13DAbv31ZSRFFG/FwyP
 rAoB1L73PJYWgqNU3I+ergBEGBKUmskqKdxbNhR4tKPTOWw1dASbsN0WKM+UyDJ8STzJ856U
 4kSdkCNDSSNykFsS+Z2njALz9I+rDum8rJ9ITjJjVWPHlXgslbnnhE422gYytLrWd9dP4E/M
 323Ls6m9PsQwVeUu2LQl0+G8TTrdzCk5zrJTYAGh4c8QGLyRel8qTzHRS01goXF2on+8ZpzU
 H11yjCoomzufCyzRHRk0fV8pRtgdPkjv9OHtaFhMQ5IijlziyoeINicbufuy1dmpDl1H8a1P
 335zswNcV67H3cOkmzvBvWwgHllA0j7nfzoGXo9kfLkIjcfnYXGsBBjYVWfl/y8Ew7puxx16
 pNwiawq4dXJQmoplWz2/H4EzVR0makq3srluAey1ZFV5EFVbNXpYsDuGtIDZY7Gj7g4oxPKp
 gjMCjl3ocWTbqmVQGYgoE2q+bcHUjbXy32D3Tqg/blnQS/xxtCvgklLM92pAZ1yHtycegA2w
 3+CNUZqFh5dL5iUUtMPpZxfSKJMB2/ffvtChPlHb21LtBPB5ryw6SHkondotvaPKA18A==
X-IronPort-AV: E=Sophos;i="5.88,349,1635220800"; 
   d="scan'208";a="65845262"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=F89Cevid0G0s+zXzmuUGe7LwDC/wc4TM/0a/IzWBS1LsmkazTBAlt0JzWN0d8bHUMLBMjWwqxuy0CV6gmjbB0TAfyTOo9DceodUCJZjVCtxhsTuSiKntRzKi9Ads+lGuLzkfO5nMI8vaWOFUuC/7pc5pwo4MjzqoD4JL8RpWDTqG9cZz4/Z+Ic7QZ+e2JAGFtoGO5FUqwK0AdwbZYWgXkwOQ2ugRG41QxsCX3dgbR3CExHoSS72bZxUVT+L2EMIKskLbYR1zf+7HH7VppqxYButKwk6fSTZskaKlzjQf1FSeI1okQJ6L0FVU94HyaD0djLN65YUVgr1i/3MZsL+yJw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Iq+8m9qsftcZOIGoD/LsdsZv4D2ECNj+IK28MoDaZ5w=;
 b=eCxEmBv/YoI/boJnF/ulAGQn2UfKO5A0od1DcZ/HbOYy1iIbYljtzxR8i/60ljwRZOr3D8Np8yFPfi7bpO2s6DttRO+jU/3jJTcBBsN9aSZaqqOhZ0wZP5vycjaD1MWCsWZA3osHPGpTV1PDpYJn/gE5T+pOymFjxkXqxCT7604g8w1bNAx5ndLzqaTW5MKh2jxdxSLkU+NS3rrddNydJPD3gJsJc8BrQYf2Q9P3t7G2Xi8yOkp2+Qq20OG+Pplzgp1KabIf3YbWDiABAQ4AkNjXVCRxLwp3fT5FiBsqetvSSmf2Qogizlip5CihGxB6u0sRtOC1cN+6tU0ANgG6Jw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Iq+8m9qsftcZOIGoD/LsdsZv4D2ECNj+IK28MoDaZ5w=;
 b=GD49VYEFNAxUlDMCVuHlDeyWRVyGsqSXpiXxXPHUX8kWw2FGa1HCopg6bgZijHBu2BLGy6N3OPBSyj1VmyLs+CpFj8MKd8Mzjy07RsfvCZ7sDEOuRI/n9MtLTa90ZsbTDlAapqsb80RBXQzmM7Uan8srX9I3EUX7N3o1c90TBi0=
Date: Mon, 7 Feb 2022 12:58:16 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Julien Grall <julien@xen.org>, <ehem+xen@m5p.com>, Julien Grall
	<jgrall@amazon.com>, Stefano Stabellini <sstabellini@kernel.org>, Volodymyr
 Babchuk <Volodymyr_Babchuk@epam.com>, Bertrand Marquis
	<bertrand.marquis@arm.com>, Andrew Cooper <andrew.cooper3@citrix.com>, George
 Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH RFC 3/3] xen: Introduce a platform sub-op to retrieve the
 VGA information
Message-ID: <YgEJWLF/yp8YkU2M@Air-de-Roger>
References: <20220206192839.75711-1-julien@xen.org>
 <20220206192839.75711-4-julien@xen.org>
 <4da70949-7d6c-65a4-662a-301bb7075bc0@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <4da70949-7d6c-65a4-662a-301bb7075bc0@suse.com>
X-ClientProxiedBy: LO4P123CA0518.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:272::11) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7da7129b-1ba8-491c-5387-08d9ea312260
X-MS-TrafficTypeDiagnostic: DM6PR03MB3785:EE_
X-Microsoft-Antispam-PRVS: <DM6PR03MB378554082A610EAD76D5C8B18F2C9@DM6PR03MB3785.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: TnJAFqfypU4zMb7f785MR30VbQ+jwIRMjSEwyK1DaQqdqa0gOQG+w8Z8JC/TFqD2Istf+wP6HWUmFPEPhEyweNjj7l1ejoG8Eymhmbye5yrEJ0kC4HjUftkHfAFwEGed6H5E62Vf30XQh2Z3U/iL50a4GXOrVDtACoChlSmRJR+z2LITaiwwg0Fys1QgNkgxrrnwVDu5Rus+flVya1uSsexgMrT+ufmHy79HPr1gXZ2tSXHOVpQlFyyFUMPMzyjhtw5NJJfd9egp8Ft9AmoTIvC6Et2ayXqCOUXw1sVqbq/n5CIUI/F7O3p24kcFiEZTORyg41ebcU86vvr2wJJovWFmWz0aMV9Wp4DeUDlWMb0m/VcukPqTM1vmq0WzkZe2wov4qOe3H/x29kh2qaJcIuifrJdiFlyJdnLX/Ly9CoDYdo4zIWRLxKusJz166P5Xfa2uosYcQH1RqSo4OqLhzNkBULpD8ZCQWlNyhjLNQgEuIEiVT/Jg8BKpPadZRhjvszeWTovwtWzAEdq6H+v8LyI76Ob+5K0C8LRjW56wph7bYCkPdizZ8n6/t6LS06oukW1wxHJxeu+iSaYr8vWmgWMeFlSLmnYZ4hqd20kPw0au/Ue5f3eVGfBn4/7mqnJT1dFWdle5QZDjwz6ck92jVA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(6916009)(82960400001)(33716001)(6486002)(86362001)(54906003)(85182001)(316002)(38100700002)(8676002)(6666004)(4326008)(8936002)(66476007)(66946007)(6506007)(66556008)(53546011)(5660300002)(6512007)(2906002)(186003)(26005)(508600001)(9686003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b0NUZ2tCSEFFRFpMT1gvSENicjFZTUp4RjNxVVYzdnpDek94VkNCSWpVTkJx?=
 =?utf-8?B?bG1qb212dTg1UUxoKzk3Y1U3Wit3RG1MMllkRENIckdNN2E4a0t6aGJXZW5v?=
 =?utf-8?B?YWtUaVJHQkw4eUcrRURraE9ZaWYwdmJ6VERuMktoZ25laDFhUWxRNk1yZW10?=
 =?utf-8?B?TGFMWE1ubXZzaHlEQm8rSnJka1Axc29Kc29hK1RHWXJFaVdNb005Z2grVnp0?=
 =?utf-8?B?WWVMV1hVNVViWWZGb2JLM1J4U3ZFWElJa1ZzbGIyUzhScHdxZ1ZDQVhIOTAr?=
 =?utf-8?B?NU1aN3VpZDl4MURKSXM0Sngzd3pSY01BeHcxRWRrY0graThXVjluMWpMZFFm?=
 =?utf-8?B?MnN2K2pKeXhrZlJRdDdEUmdLdE1VME1PZGUxS2FOZE1lamR6bE9BYTZ4OFlh?=
 =?utf-8?B?dmNnSVBKY0hPY2lvUTRCY2UxVUNpSVAwdjkzUERWcW5BdXpsS0F2Ti9QVDFt?=
 =?utf-8?B?akltcTM1bU96VnFjK3JLWE8vQXFEVHJGS3V5ejZraTlaSldxVHRURjBNMzd3?=
 =?utf-8?B?NFFJYUJJdnFtVVRmOUNWbDhQZVUvczZJSklKMlZRblJUUHFVMEFvVVpzU04z?=
 =?utf-8?B?ZWoyZU1OelJuUm5DWm15THdXQ09YcFg5d1Z3a1ZYdEZlSTVpK0hCUEZ2VS92?=
 =?utf-8?B?bUc0MG5SVmg5SEFZTU5rcStXQzVkN0lkWTZrK293NWhsTGp5SjArSTlDNFNl?=
 =?utf-8?B?TEYrNzVsNWVHWXZ4OUtTSm1hZ0ZoOVdQRm95aE02cjVOUVU1MGNSUjVDb1VE?=
 =?utf-8?B?VUhyeTJuNHJVQlFwMkhtRWIreUptcCt0eWluWnlWb3dNRUtBdGllVWlpd3JC?=
 =?utf-8?B?QUlyRi9acTNoQWJTVUs5dEwwNFZmeDJXSitkczhzSFAxQWhrV0Z1M3RBdW9J?=
 =?utf-8?B?MTdBSEJsWmE2LzdHcGViZnliVWM0TFRtdHpEbUI3QWdHcUtDRk1oWnZXYUVF?=
 =?utf-8?B?ekY2ZGZtOTFQTDJSdWM3cGFwbWk3ODYvOC9WZkV0TU93UlpiSVJ3d3hOQUcv?=
 =?utf-8?B?RmR1WTFVazRUYnNqZ2UvMzY3UDd1cmtPL3cwa1BDcjBES0xkdG5rS3pBa0pH?=
 =?utf-8?B?SG9adlRKL0pqL0MxV0RheTRsK2JxajlXL2xwSitCWHFWWWhPSFA1KzNjeTRi?=
 =?utf-8?B?Z3drRkdPTVlDQisvUkFOUEM4NzhpQkt6VU1ia1JXUllsOWJobEc5TjRCZmRY?=
 =?utf-8?B?Ym9uV2FDQ0haWGluQ244ZEFoWjRBOUkxb1p0K3YwaEE1VnM4eExLQU5LUFZN?=
 =?utf-8?B?SzB3cG9mUk5uTG9WcmFjSmVjcUYyZnFZK3B6RmtoNUxoWDV4cFROYVkzWVk2?=
 =?utf-8?B?Q0lEL0p5bkNsMXpSbGNkMWpTTUdrQkNuZlRkSjQ4ZDJPRnhtQUpsK2RyazlY?=
 =?utf-8?B?S29KTUVjYkpETittek4wTGloTGhtQXRybGd6eFpDRTJiS055VlhacHovMGtZ?=
 =?utf-8?B?VktLcGE2SXk2aU1OTXNsMXZ2MFJuVExGS2h4R0ZmZ2l6ZXRwd2REcGlDMlZQ?=
 =?utf-8?B?SHNZOXZiZXVmekIrZGR0VGhpRlB2YWcyZFFtSVZqNHFrS1k3dStHaFdYRlZq?=
 =?utf-8?B?NTQwUUozbUdGKzFUMnNHdHMrZ1NKUS9zSEEvVDRMUGdiTWlDRE9ZZzRBTVZs?=
 =?utf-8?B?L2svNHVmbFBwdG1DSkJiclB4WXZ4QnRvbEZ5UjRwTzIyUlAwaU5ranF6Y21C?=
 =?utf-8?B?a3UrQ0NtRFRqNGJiTUtnQS9xK1IwQXFTR2M3bllWaXUrKzFXQ0tNdlJHaTYz?=
 =?utf-8?B?N2x1d1lROWVOWkllditZc051UGFLZm55SFpzYlZ1ZWJrcjBxbzdvZ0hianJ0?=
 =?utf-8?B?TkxWa1FSNHcyV2FSNE1oZnc1cjdyemdGcklNTmF4VHZJTTVFYzhFVGJFNkxl?=
 =?utf-8?B?elV3TWZBUno0OUFWVmZvZGRaZEU1WHh6YUVqeTU2VWFRUDZqaXJqZTc3ZTY3?=
 =?utf-8?B?b3I1M3dJK05MMHg0ZFFqVmZiNndNOXlTaEh0ckZmR21CbDNwOWNBdTJQWVhJ?=
 =?utf-8?B?T1hWTGRoUExMeTJqYUpPNVUzWlNadHl1OFgrOFhhSmFuTXQ4eWwyRW92cWpJ?=
 =?utf-8?B?TXBjMkJDR0VONlFSRWY0aCtmOXV2WUQvdGd3NzNCZFJvV0lHdG1ITUg5aE9j?=
 =?utf-8?B?WjIyT1p3UG9UZHdtdmhzSUh5WWtNVlZDN0JqUjVxcGtCQUJRNnVwY3NDV2xh?=
 =?utf-8?Q?TeTqGhqLomlWuec6T8wvZO4=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7da7129b-1ba8-491c-5387-08d9ea312260
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2022 11:58:20.2389
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iEdpUleytzunD6Okg6s5lz5sBFjE2EIrvvbdCJRfFPUqw1yqu7ldbUZZdUxz25NUzw2Nu2Kt9Eiu2aUHDxlgyQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3785
X-OriginatorOrg: citrix.com

On Mon, Feb 07, 2022 at 09:57:55AM +0100, Jan Beulich wrote:
> On 06.02.2022 20:28, Julien Grall wrote:
> > From: Julien Grall <jgrall@amazon.com>
> > 
> > When using EFI, the VGA information is fetched using the EFI
> > boot services. However, Xen will have exited the boot services.
> > Therefore, we need to find a different way to pass the information
> > to dom0.
> > 
> > For PV dom0, they are part of the start_info. But this is not
> > something that exists on Arm. So the best way would to be to
> > use a hypercall.
> > 
> > For now the structure layout is based on dom0_vga_console_info
> > for convenience. I am open on another proposal.
> > 
> > Signed-off-by: Julien Grall <jgrall@amazon.com>
> 
> Cc-ing Roger as this may want using for PVH Dom0 also on x86; my
> first attempt to propagate this information was rejected.

I think it's easier to use a Xen specific layout in XENPF, as that's
already a Xen specific interface.

I wonder however if passing the information here (instead of doing it
in the start info or equivalent) could cause a delay in the
initialization of the video console. I guess the same happens when
using the Xen consoles (either the hypercall one or the shared ring),
so it's fine.

> > --- a/xen/include/public/platform.h
> > +++ b/xen/include/public/platform.h
> > @@ -244,6 +244,7 @@ DEFINE_XEN_GUEST_HANDLE(xenpf_efi_runtime_call_t);
> >  #define  XEN_FW_EFI_PCI_ROM        5
> >  #define  XEN_FW_EFI_APPLE_PROPERTIES 6
> >  #define XEN_FW_KBD_SHIFT_FLAGS    5
> > +#define XEN_FW_VGA_INFO           6
> 
> Perhaps s/VGA/VIDEO/, despite ...
> 
> >  struct xenpf_firmware_info {
> >      /* IN variables. */
> >      uint32_t type;
> > @@ -311,6 +312,7 @@ struct xenpf_firmware_info {
> >  
> >          /* Int16, Fn02: Get keyboard shift flags. */
> >          uint8_t kbd_shift_flags; /* XEN_FW_KBD_SHIFT_FLAGS */
> > +        struct dom0_vga_console_info vga;
> 
> ... the structure name including "vga" (but if the #define is adjusted,
> the field name would want to become "video" as well).

It's my understanding that this will forcefully be
XEN_VGATYPE_EFI_LFB, at which point we could consider giving a type
name to the vesa_lfb field of dom0_vga_console_info (video_lfb) and
use the same struct here?

There's no need to propagate XEN_VGATYPE_TEXT_MODE_3 into this
interface.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Feb 07 12:35:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 12:35:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266789.460490 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH3EM-0006Xj-JB; Mon, 07 Feb 2022 12:34:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266789.460490; Mon, 07 Feb 2022 12:34:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH3EM-0006Xc-F0; Mon, 07 Feb 2022 12:34:54 +0000
Received: by outflank-mailman (input) for mailman id 266789;
 Mon, 07 Feb 2022 12:34:53 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=owYM=SW=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nH3EL-0006XW-8j
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 12:34:53 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 581d976a-8812-11ec-8eb8-a37418f5ba1a;
 Mon, 07 Feb 2022 13:34:51 +0100 (CET)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2051.outbound.protection.outlook.com [104.47.13.51]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-41-Ui77F_qhMhWFKoNT2CI0Pw-1; Mon, 07 Feb 2022 13:34:49 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM6PR04MB5415.eurprd04.prod.outlook.com (2603:10a6:20b:93::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Mon, 7 Feb
 2022 12:34:47 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.018; Mon, 7 Feb 2022
 12:34:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 581d976a-8812-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644237290;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Z4HYMEJVPW4eKi04+wILEJ/uWqOBbCmoano1A7sqoUI=;
	b=NCIWq6RTcMWSu4WEUF/ZYUscHhvZuycUaLNyidhiBIo+9mnfRHj9v6Ygu+AmvXchqQJNka
	8kb+BYbQOH2Mgl4vzmjrgHoM3386sBBQYowdnduZKYlylGXgdLMFxjGVQYOFfebV68xPgB
	hkz64nFwFqfvgzYj6xRDxBZq+db7U0Q=
X-MC-Unique: Ui77F_qhMhWFKoNT2CI0Pw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=fPCunMMh6ig0r6QBgHcyCEJFx2uJLNuHcHLK3F8c7WRTEXMMPzzBglGbZBVhiGw7zStxjN8e9SkDwjmufjPztOqHhe5vg58M/X4J1isQbXo/CpMlnc55opnaJXCFKsaVLCRrCFf6Z9PSMhbvcvmWNSdplFYofC/Lz8dWossTg48JZ1TE4//TW+y5lc8ULKFUNN5cpZqLIZQ7sLl/SBLSfxqa+AjU4a+B1nK7LnRpjaeqI4zkTgy2vce5O2NL8xMvaDfvtQS5HU3T+assVqmqmlTQLNOR7LoUMcz2QdQ/Q+VXpEQu+HqGRJ8+f4qfEZxJ32FtnwnSl21/9P5gCPsftw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Z4HYMEJVPW4eKi04+wILEJ/uWqOBbCmoano1A7sqoUI=;
 b=drNh7IWtVAUlPIZW2ZR2VgPLjuMVlCKfgHlaLme9xZK/0+EkrZXNJ71cD+homjJCqvup47xc6myKCZegeqw+OJPl/4GyINBuaQURAFn+xYPB2JTcZsoeA51ibESNZXp8HlJrB3jPG/PRP7w9TdW6KDzGEHReUPTfnRPTb85aKkQX3BA3SEzvZaASl4VPwI/eHzjMP/f9G5dDpAZ/xBE27/mrb24zEo2bHMEBGsK5oV3OnLNCb/R2RLmP7+SkKEQV0Hum4CrtDKOvZ2PtM4SgYJD0myxg8XLki3uNYFJlRQnDI0DRIDHA6Jk9pqPoh9mg/YTUgrqq1F3nEr9qv8Ewog==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <a71b7835-cbbb-74bd-d25d-6824f6f10683@suse.com>
Date: Mon, 7 Feb 2022 13:34:44 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Content-Language: en-US
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Cc: "julien@xen.org" <julien@xen.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Artem Mygaiev <Artem_Mygaiev@epam.com>,
 "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
 "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
 "paul@xen.org" <paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <04726915-f39f-9019-436e-4399533c9fc3@suse.com>
 <9ed3f4ac-0a2d-ed45-9872-7c3f356a469e@epam.com>
 <c3a99712-cf7c-37da-aac1-f2ee00e6d53b@suse.com>
 <Yf0KcVD8W05A4fbB@Air-de-Roger>
 <1ed0e342-16cd-2f16-c05c-186667a22762@suse.com>
 <7e3562b5-fc67-f213-e872-f211450d9e2e@epam.com>
 <a8fc599c-f620-c4d1-2077-c57068f46a7f@suse.com>
 <deef8468-d607-e49e-f456-6a8013329ca1@epam.com>
 <Yf0k6aoKK5G3iad1@Air-de-Roger>
 <3ad10a99-c706-b95f-1419-2c0c7cf37d58@epam.com>
 <Yf0+3C9nF8+tewLw@Air-de-Roger>
 <c5fea3bb-834b-eeb7-d7a1-1ee609037a9f@epam.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <c5fea3bb-834b-eeb7-d7a1-1ee609037a9f@epam.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P195CA0095.EURP195.PROD.OUTLOOK.COM
 (2603:10a6:209:86::36) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 31113e00-6e11-45a7-4186-08d9ea3639bc
X-MS-TrafficTypeDiagnostic: AM6PR04MB5415:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB5415DC9159E87EBF8CB0E66BB32C9@AM6PR04MB5415.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	h4joJ//g0AEvTnWE7OBOXeoJMnYIz8c2tt9DyWACx0Qm5rOztDzfhrKSs1Q6/SJ8L0X704vDHc9LLamtHSMOWn0kHhEtqnANgwQsi1mlrFhr7bYbf/NlW2hQOXJjJ1rqVPDwjY2OkG9CB3cOTqnOVhQtTVOHz+hpaOnVZXr4Yd+dh0brzJqNYIhnE+VKJImpo30kGU/NPKrXsPuEsC4k38d5MShbdzQFc2hh6Cfb+K7R5F8xwcvQonutB0neJgmFCc3ahbJ2vym5nNCarJCSFHPrWtnc/6XMuuhMHxeZyKkfLvR56WTulnUA1BMTqk+9y/BTrK1zm7fDYB6oRLcVH/44eUyr34G3r3yAZxVNGdI0qAxe+/n6r58h5y5ARe5P+qtqYgmTwhUvlc2j3lQFoAoWlvvF7XAe/Ju1ZX5RRBLvlZM7QCOflJ285oJtrXI1TpBU/KlVxI8vL9MV+R8eIZK8uuT1OWuEdLtHh06zaKjX96QX3KiSfySXoc2evzjqdgbk/yPdjO8LhLjl2v+2e+LRY9L/R13Q0OBFZemSO6szSRUK7bDLQdtB1pusdZJpgn6lJVUvrz9ndQrPigFEB1lrpAFLOoQouAs3ADojUT0Tx6pRO+dOQjp+ZIZiElMrKxrRUR3Cq/cfCTY4sEXsIgV6CCPKQEn91Aa0yNW048lw71XD7mPhefs4ZNh+QkUfmTU+EApA7j01EPAueipWGh3QIDGoNx1Ifuyq7guG1qc=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(5660300002)(6512007)(4744005)(38100700002)(53546011)(86362001)(31696002)(6666004)(54906003)(186003)(2906002)(6916009)(6506007)(66946007)(316002)(7416002)(31686004)(66476007)(8936002)(4326008)(2616005)(66556008)(6486002)(26005)(83380400001)(8676002)(36756003)(508600001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dkpWQ3lIRW9iUkdTVjhvV2I1UnB4VGZjSTBUb3ZQNWJHOWQ0bU9sakVENEhw?=
 =?utf-8?B?TTdYQitkTGtBOHB4bCtkKzNobkxnWE9EckZ5eFNhOUllbVM0OStqTEx2ZDBh?=
 =?utf-8?B?aVVKdGw3eFpuM2hjdXBLbkQ4Y2VmYndaejlMamFtOE9qckl1WHBjaTAvVXhR?=
 =?utf-8?B?ejdlRnZWZ3BYK3A4a3gyYUFCSU5namorcmkzRWp5MnBRSFRCNm04VXhxMTE1?=
 =?utf-8?B?cWVSc0haNGFrZUxPY0YrbThvQ3FTOVF1ZE9nTEQzbDhyL0FNNG1YTi83V1VC?=
 =?utf-8?B?YzM4Ymw3ajkzRVFWT1NQMStRcVVDN0FRVHBTcjZ0SEg4dmVFRFNnQVZvVDZZ?=
 =?utf-8?B?UnpVMVVDdjJsaDBsT0orMy9vT2p2R0NzdVF1aVJ0cTZzem04cCtDQXIvQUlY?=
 =?utf-8?B?WUJjVkgzSkh4MXRwMGJxeUpaT2YycjU0d2xud1VUeFd2YnBNK3hRcDRRTDN2?=
 =?utf-8?B?TytGWmZxRnZZUW1PQURvMlV2emlZWjZ4ZjROT1pzQkNpdlRqVHQ2NTFESGxi?=
 =?utf-8?B?aERxZCtYZytIRGhNTVJCSDVoa1Rwc1ZEZEw5V04vbklBSjBDSmErQTFqcU5D?=
 =?utf-8?B?dmpqckYybjNaZmpaM2RrQ1BSVi9oTHVUelhyTWlwOWpaOGVBc1hvbm9aMnFH?=
 =?utf-8?B?QlpUVW5UbXcxcEJub01VamI2UDdWK3pmTHAxdmdQK2tXN1cvdGZqN3lRbHlV?=
 =?utf-8?B?Qy9JYTBkdEFiWGI5b3FIbEUxTXpLQjE4QzBQOTVqTFhhR2ZiTFdXeGZabzRW?=
 =?utf-8?B?Ynp0K2x0ZjJ2eUkwUGRLMnpxUTEydmpMcWdPRVRVdTl2VW9mSHN5ZWZvYmQ0?=
 =?utf-8?B?SVhlYi9JWHF4SHlOZkQyb0UyNEFvVEl5SnJOaUxBTnEwMjV6cUI0SjB0bTZR?=
 =?utf-8?B?M3o3aFRHNTVQOXR6NjI3Zzh5NHc5MDZyaFQwbFNjc2RaVE5QWFZWckxJaFIy?=
 =?utf-8?B?NUNFUFluTDloelEzL1hwc0RSYVBHeEErNm9HOFQrMFBzYis3S3ducUNpY0kr?=
 =?utf-8?B?UVU1OFE5aHZLWnBxeDRsWCtvY0FaUlNOS3hqQXdzOWR5dzNjL3dUTGZNMmZN?=
 =?utf-8?B?em5WZWlEeklsZUlIbksvWURMUkVvNm9nYVpmcXBqUGo5Qm82WFlhQTFtUEJZ?=
 =?utf-8?B?enJaSnJRbTFoajQvVzFxN2xvUTcyR05kY3IzYkt4di91RlkrN0U2V2VNSGln?=
 =?utf-8?B?N2NjM0JRczFEZGZ0ekRUK3BVMkI3MWs5ZW1yb3lmL2JGVVN5Z3pFQ1lGTzZ2?=
 =?utf-8?B?Vmt6N2lyd3FzakRQaHlWWTFscEFLU1RnYVZoaVpvQm9pelJ5YStFYVpReHhj?=
 =?utf-8?B?Sjc3U1QzVXVwb3N5VWpocjdnUEU3R2VxZ2tEc3BmWW1HNjRvc1pWSjM4MURn?=
 =?utf-8?B?NnFjT2JkaXhSditrWXJKdFViODFxSzBiS0hGOFViemxVRU15RnhEQ1R1amRH?=
 =?utf-8?B?VTNZV0JjRUFaV2xxV3hIVTFNSENaZ2dyRkwySmF0Y3EyNW9OU1dsNUM2Sm5O?=
 =?utf-8?B?L2tmMWRMSWNFVXl2TE1lSTNqeUNVck5FUDFuaTJ3dXR4dldtRlhWbkZvdDZh?=
 =?utf-8?B?eDlKOXBBd1RjR2Q1M3hKVElIZWxTSGNnQ0loeVR1Qy9ITlNuNDY3YTF1Rkt3?=
 =?utf-8?B?OHFoSjN0eVg0ZzVucXdDZ1BRM2lKdkNZaFl5ZEZ3Z2RuN2ovVUdHZHlCU3lz?=
 =?utf-8?B?YXdiTSt4YU5GM0VxeU5Gbm53VFpLRG9aQzlhdWdrM0huMGx1QmwrNm1jV3Nz?=
 =?utf-8?B?RU9xN2JneUJwaHc2ZUF4SDE2UCtjcytSWlNsa3pUM3NyT3F5MnlsM0FWbGlq?=
 =?utf-8?B?WkJ4c1AyY0hsZGZnZUpPUGpvenQyNnBkcUtib3VETndyVHZmNTVzUldsY0hF?=
 =?utf-8?B?VlB4UlNzbWtVRCtKeXFjSGJFdWMrSWlTSmd3ZFVQYnlIdFJoVSt1Vk8zUjVQ?=
 =?utf-8?B?ejNLSUtQeVhxOFU4Y3QwMmNFblVWN0FNeXhoSWwrWnZzOWlqMzVBNmlQbHZL?=
 =?utf-8?B?eS9jWWFFM1JMU0FmTkVDbGNWRndTbTVKWGtJeDFYbkkwU3ZHeDRNMk5hL3JY?=
 =?utf-8?B?Ym4wdng0S2FtRDdmVWZ1bCtWSCtyQVN3S0tROVpiZVpkaUpROXNyNHBZZTRo?=
 =?utf-8?B?Y2FSekhYa2dJZTMycEFoVWpjSjJVWVdBbXdQVUNqdkM0N2FvdXFIK1dOcHhN?=
 =?utf-8?Q?8d/g7YHCzsBABwchTpW3v24=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 31113e00-6e11-45a7-4186-08d9ea3639bc
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2022 12:34:46.9595
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1FETDjQtWLfMAPZbrK5/u4z+er255IB9MVKLJ+e0BabJ0f9RrZ3FvNuTeWlN2vbBdKw3Y4KYDKt6C6Ptmvl15Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5415

On 07.02.2022 12:08, Oleksandr Andrushchenko wrote:
> 1. vpci_{read|write} are not protected with pcidevs_lock and can run in
> parallel with pci_remove_device which can remove pdev after vpci_{read|write}
> acquired the pdev pointer. This may lead to a fail due to pdev dereference.
> 
> So, to protect pdev dereference vpci_{read|write} must also use pdevs_lock.

I think this is not the only place where there is a theoretical race
against pci_remove_device(). I would recommend to separate the
overall situation with pcidevs_lock from the issue here. I don't view
it as an option to acquire pcidevs_lock in vpci_{read,write}(). If
anything, we need proper refcounting of PCI devices (at which point
likely a number of lock uses can go away).

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 07 12:38:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 12:38:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266798.460501 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH3I1-0007Bs-3n; Mon, 07 Feb 2022 12:38:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266798.460501; Mon, 07 Feb 2022 12:38:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH3I0-0007Bl-Vk; Mon, 07 Feb 2022 12:38:40 +0000
Received: by outflank-mailman (input) for mailman id 266798;
 Mon, 07 Feb 2022 12:38:39 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=owYM=SW=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nH3Hz-0007Bf-NI
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 12:38:39 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id dfa07ba1-8812-11ec-8f75-fffcc8bd4f1a;
 Mon, 07 Feb 2022 13:38:38 +0100 (CET)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2055.outbound.protection.outlook.com [104.47.13.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-16-3x787tPcO1-nh4f4bCkPoQ-1; Mon, 07 Feb 2022 13:38:37 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM6PR04MB5415.eurprd04.prod.outlook.com (2603:10a6:20b:93::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Mon, 7 Feb
 2022 12:38:35 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.018; Mon, 7 Feb 2022
 12:38:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dfa07ba1-8812-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644237518;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=ZVwdK2e0+//SUF7WggRKgo4oJIYl1NTAT0qMqKjbX8M=;
	b=AgYTBV3p3mD8LQHYEaXKS3YpOvPQQH2ZSdTiGd6N3Rk3aytygk5D9Vr8z+QFhpmSyAjTE1
	wxRzSQLKzZ+T0XHOpKFJPhmHIEovZTtz/51rMJ6dWm3LZUALetABbJJhL1HVbFnR9boFrl
	1tbZPAhz2o1Sl3t+dXJMy7J729v1Wv4=
X-MC-Unique: 3x787tPcO1-nh4f4bCkPoQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=QKFCV8GaP9mHD+oUZW+jWMRsd0ESgmHR3bnAw5z/wbuyEtJvcrtdd770YCbSWluCm/oxNcwWRa711JJeNpwnt+b3GQRK1msppOgz55FnDXQD8qx1uFmW8KrZ6fKIfuwOBVIpmjVxfQcI9SGEpqfxAlP/M2zeNi2KCXV5uL6AqcnRj9bZP/dpIitFi7LjUkOqJ3k/AQZN0bd6gX2ahFIJHT32FRF/Ry4BbXJBbbXuiRtuEUHuX89r6z7wQ1zqxJzNDAmEccAnRTrG/SZTWsjEOI6dbIHhCa6V4YJybA518R0qWumzZIMS/iQrlmay58Epc4aOJPndDftLGZIHt2xGkA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ZVwdK2e0+//SUF7WggRKgo4oJIYl1NTAT0qMqKjbX8M=;
 b=jJwHdlXm+EYIf+YgrouEejj6cCV5/YAj/p4b0exD+Wbp33DZLvJOw+8zvd1C6rjkLxOyoqVpdf5vI6zStX9LRGBpG/MODzJ5AZWDC9DnTcQJbMzghJXb40721677ALuatPqgxAfgj4Q7olvcj7JEvKTKBRKATNOsopJeX0K3x+WP4vuYY9INb1TOPqDLr6qEgxrrfIA2E34OxM2ynZ8RcNeiogLAFcfEGq/xH4UlRJnPW9uxKMEmD5RdE7dbXyX1V+5A31ILbpKHyxoKT4HtawOJlkR9Yu+JCnchfXiQ8VO9FKAFfhlWd8uWFRzcYzFBiLeRpz0gMzYQWp/w0DQCOQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <49380584-0577-96f2-ef1c-a96eabf0d227@suse.com>
Date: Mon, 7 Feb 2022 13:38:33 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v6 10/13] vpci/header: reset the command register when
 adding devices
Content-Language: en-US
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Cc: "julien@xen.org" <julien@xen.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Artem Mygaiev <Artem_Mygaiev@epam.com>,
 "roger.pau@citrix.com" <roger.pau@citrix.com>,
 "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
 "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
 "paul@xen.org" <paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-11-andr2000@gmail.com>
 <96381d7e-dafc-acee-3abf-f9815deb207c@suse.com>
 <ef76faac-f9d3-1cb8-06b5-189ccd299542@epam.com>
 <6f0a015b-c48f-76ed-9a51-39c045ff5927@suse.com>
 <2ad372d4-a181-9307-ef50-a5adb61dae66@epam.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <2ad372d4-a181-9307-ef50-a5adb61dae66@epam.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P195CA0084.EURP195.PROD.OUTLOOK.COM
 (2603:10a6:209:86::25) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 3cf65a11-d519-41cb-f7e1-08d9ea36c1d6
X-MS-TrafficTypeDiagnostic: AM6PR04MB5415:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB541554D9FD5EAAB0E5A7B9A6B32C9@AM6PR04MB5415.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	/01hvzmpH0O1MsXx3ky9fax3nx+HOda1M1RDd78I465n8+UHtEpaIm8SeTuQdknDd4NwxKj4kvyc9oK6NtBSxQSWPB/X4CxxK3k+ondTIA2rrPafPg1WGCmvfZb0NN9clQW3Y/2egqfhRKwvXXIwxEgp9lA+aWprQnAnrV9u6UFsO7p1D29AdiTHTYl4/GJMwUvDzG8b/NPdEYm4NJxcme56kBLg+/cBlX4T+bw52JqFmXEDHbWyLFaDctqXuX54D7Z9j5veoOqjzkU55A2gTauYlHdtQfD+cC4Vqp82NyQkPFKubS8qtC80YIs5P5avThf9JA2kujHp2dSvyKoRgstZZ1JZRp7z+dgIzw8BeFIVhtWFW14Wnimkjk2bAzf5Emt8YtIjx7I2MY6Cn20jhrYJ1VZRONR8y32oyfmRKrsNWZCyg6W1j3KnxqZ8aYP7yyh1q8QI4FMRnAgGFlEfnnBrySa9zuZ01etxij3l4+j4NiByxnTfSNfm/cvaN+0finYYtTiF5CT7qEWW8EUThRmj5TFp56hG2VIOU77aDmUxC5bXseWgOvj3TvwaTQnEQk7uWFcLgOrjzjt8lXqCAb0Ha1+oGjewrNVXuewGHLUQMolBtux27uC0KtoqG29wRH4RgN7auyL/M20LD31ZRPq6GhuFMNTvKKoHeCX1SKijFVRQCLx+VhaJl3Qj7bXkpQOTfIvVywuW7neIjyR00VCr/aVOOyV4WKlONqkhsVhvrahNO+OqxAKWqndzr2XJ
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(5660300002)(6512007)(38100700002)(53546011)(86362001)(31696002)(54906003)(186003)(2906002)(6916009)(6506007)(66946007)(316002)(7416002)(31686004)(66476007)(8936002)(4326008)(2616005)(66556008)(6486002)(26005)(83380400001)(8676002)(36756003)(508600001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UmFVTUVrUVBPNGIxS09ycHpZYTlCeTVFL25WMUpGdmlkYkh1OGRnRlJIdFVs?=
 =?utf-8?B?WjZMb3FJNnFQamFjc2pGTXFiK1NINDN5Tk5jVkcwOG1Gd05pUUtFSXdXYlJK?=
 =?utf-8?B?QkFjSUhxUmhrVjJFZkF4ZDVRdUIraEVNS0Zjd1NSbmY0Y2xaZmNVOE9lOSth?=
 =?utf-8?B?ekhGN3VqMDRxbzYyTGplbWZLWEFjYzZTeFlnQ2dYbkF4cTBnSzN3OFNJU1gz?=
 =?utf-8?B?RFVpSFk4bmhBYmNlMnNINm9Kdlg2ejR1d21QeDBPcWtNbkE3K2I1UmQyQS9V?=
 =?utf-8?B?aSs0TmF3QzVPck53WVlqY3oxd2tDRzNVNTR6MnBJUk4wVU9DUHQ5NGVpSVFR?=
 =?utf-8?B?RXlGRVhDS0pIUEhlWjFob3RJc0F4eE5EaUFNbFQxQk9LYmZXRnVKTUMyVHBQ?=
 =?utf-8?B?K3F3WjJwL3RzZ3IrYXRYUDZaNFdMTEk3cDkrdzEvKysxTktUUGxWWmFEaFo1?=
 =?utf-8?B?MUJ4ZE5Ua292RGtXOHA1YWdGc1lZTWw0azd3bW54VlduUnBpSERiU3hTRndE?=
 =?utf-8?B?V25nallTdzdyWTZoQnd3UkEzNW45MmV1K25rUUhiMndTVUJkUHE1ank1dnM0?=
 =?utf-8?B?OHpZbEtpS2pFeTNZT3FUZWhLT0Q2U1JGZDMyQUpDZTBQTUp5R3BHcWRMTnpt?=
 =?utf-8?B?c0E3Zk0vbjNJeWtVYmZUelh6OUFPUFdFa0swYXd4M1VDazVZNE5qdkR0Sllu?=
 =?utf-8?B?K2hyV20xd0hmYzJzbWlSNXpaamJqY3BBUFFLWDhpbDJ6QzJuZlhEVHkxMGto?=
 =?utf-8?B?MUhuRjYxRkljd1N6d011VDcra1Y5VTB1bnVMTWtZZVNUWVUwRmVuN0IweWZq?=
 =?utf-8?B?RDIvV0lRRzFPcE9pZTZCLzZhR1BBQThFZ1BneDRyQmduNitPQVFLNVFTK1FE?=
 =?utf-8?B?dW5uazNkS05XUjdDSk1nMXY4ejhsc0hzVm5RRHJwaHE2OXBVRjFkak1JYjk3?=
 =?utf-8?B?aG5GQmlZTDN5TndXTHp3S25zQWJucVhsL2d5dlFGenVDM3N6QjArQ3FUR2FG?=
 =?utf-8?B?RmRHU1JsaGtKQ29Ma0tLb05nYmE0ODJ4ajJSUlJtd2dPOCs2Zy9uSEU1RXU5?=
 =?utf-8?B?R3RDVnhCZ0tsUVhORUZQa21VMGhNZXBPdXJIRHRsTE9BNVFUN1l3RUU3NVly?=
 =?utf-8?B?am9uNWRBbUQrak1pbXhhSkthdThiaFpKV0U0TkhHZHNhOXdMcXRsZy9EZkZO?=
 =?utf-8?B?WERPbEI0VmQ3WmxNQkE2V3RmdysxeFJPYnp3WDVSd21MYWlKeC95UklyTko3?=
 =?utf-8?B?aGozbFVQOGVSWU1QVG4zTWVVaUV1WjRrNkxWbTVXenN0Yjg2UzN3b2JIblZN?=
 =?utf-8?B?bk1BOVJiQjdsdk42cHV4R2x3NDQwTUZTWWFpTUl0N0hreFFpdkYzNzhwNzVS?=
 =?utf-8?B?Zk1XY0pNeDcwdVpiWjluS2xsdTJqNnhsQVBCT3F3OGRCdUVFbThjcld4YU52?=
 =?utf-8?B?Y3F2akpKUnB0ZlRwTVZCd3I3dGg5MGNJK0JsSVdIVUJxRGVFNm1mODdVZzA3?=
 =?utf-8?B?TDlrRkRyTExaRzVlRTJnVzQvTHJrK0FsVUd3cXZOcG1KM0pLdGwyNk90NEc1?=
 =?utf-8?B?NE1PZ2E4YlMycFhqQVJCcFV5SGlORWl5UTFlUWROUVVNWFlJVGhBZkJNT3dv?=
 =?utf-8?B?ckF1NWpUdTZHTzNIR0hvTEpncnJhQUtYb0VwZFhDQkdRSFBQMTAzSlFDNlYx?=
 =?utf-8?B?OEZtcXJmbDdIUW1waDI0UmRXa2FoWHhJRXNJdXduaUlZMlV4RjNqOGRNMU4z?=
 =?utf-8?B?cS9HRTNiQWdHa1FSMVY2eTRnaFI0T1NsdlF1Z2FyWi9Ma0o3OHhZRW12eUk0?=
 =?utf-8?B?Z2hVbVdJZmljd2Z5QmJ0K0wzSWNhWFFnQWk2c1J1T1l2Z05tcTVKTk1uNTla?=
 =?utf-8?B?NkF0Q0RBQkJ2WlJkbDBOQ2QwczR0UUV6V1hFNnBQREpWZFdXOGpsQzgxLzlv?=
 =?utf-8?B?TFdTNnlSYVBHNU0rYWtzblQ1d1BGRUd2dTdtZ2FFMjJtTk1wOVQ2UnI4M0lx?=
 =?utf-8?B?ZmljdjNNZUo1NGFaTXhtQ0ZhOXBhdUxxRElUQWx0Y2xqeW8yenhoclpxdmt0?=
 =?utf-8?B?S1pZUGhWZTdaY2dZdUpvdy9TYlBZRVlrUHZrTHpUVzNZNTcyZUZaQUthYmhK?=
 =?utf-8?B?OUczNXMzb1pPTFRuZjdzVEtLVEFHYk1zYjA0WGFOMFllaU1ObEozbFQ0ZGxa?=
 =?utf-8?Q?K1NEczcPd+CMjjdimw9Xppo=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3cf65a11-d519-41cb-f7e1-08d9ea36c1d6
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2022 12:38:35.2110
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jeXxsXkmG+QIiRPVn/l8E0SI1maIIX5tEgo+MLB4lSDoCTdm9I6Zdu9I9hZeVKOlFzeOh3lPwviQH0cejSmmiw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5415

On 07.02.2022 12:27, Oleksandr Andrushchenko wrote:
> 
> 
> On 07.02.22 09:29, Jan Beulich wrote:
>> On 04.02.2022 15:37, Oleksandr Andrushchenko wrote:
>>> On 04.02.22 16:30, Jan Beulich wrote:
>>>> On 04.02.2022 07:34, Oleksandr Andrushchenko wrote:
>>>>> Reset the command register when assigning a PCI device to a guest:
>>>>> according to the PCI spec the PCI_COMMAND register is typically all 0's
>>>>> after reset.
>>>> It's not entirely clear to me whether setting the hardware register to
>>>> zero is okay. What wants to be zero is the value the guest observes
>>>> initially.
>>> "the PCI spec says the PCI_COMMAND register is typically all 0's after reset."
>>> Why wouldn't it be ok? What is the exact concern here?
>> The concern is - as voiced is similar ways before, perhaps in other
>> contexts - that you need to consider bit-by-bit whether overwriting
>> with 0 what is currently there is okay. Xen and/or Dom0 may have put
>> values there which they expect to remain unaltered. I guess
>> PCI_COMMAND_SERR is a good example: While the guest's view of this
>> will want to be zero initially, the host having set it to 1 may not
>> easily be overwritten with 0, or else you'd effectively imply giving
>> the guest control of the bit.
> We have already discussed in great detail PCI_COMMAND emulation [1].
> At the end you wrote [1]:
> "Well, in order for the whole thing to be security supported it needs to
> be explained for every bit why it is safe to allow the guest to drive it.
> Until you mean vPCI to reach that state, leaving TODO notes in the code
> for anything not investigated may indeed be good enough.
> 
> Jan"
> 
> So, this is why I left a TODO in the PCI_COMMAND emulation for now and only
> care about INTx which is honored with the code in this patch.

Right. The issue I see is that the description does not have any
mention of this, but instead talks about simply writing zero.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 07 12:41:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 12:41:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266807.460512 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH3L0-00005S-I0; Mon, 07 Feb 2022 12:41:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266807.460512; Mon, 07 Feb 2022 12:41:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH3L0-00005L-ET; Mon, 07 Feb 2022 12:41:46 +0000
Received: by outflank-mailman (input) for mailman id 266807;
 Mon, 07 Feb 2022 12:41:45 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=owYM=SW=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nH3Ky-00005F-Va
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 12:41:44 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4e354091-8813-11ec-8f75-fffcc8bd4f1a;
 Mon, 07 Feb 2022 13:41:44 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2170.outbound.protection.outlook.com [104.47.17.170]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-14-TE3A7iSROz21CoTMATeUGw-1; Mon, 07 Feb 2022 13:41:42 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM0PR04MB5203.eurprd04.prod.outlook.com (2603:10a6:208:c1::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Mon, 7 Feb
 2022 12:41:40 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.018; Mon, 7 Feb 2022
 12:41:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4e354091-8813-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644237703;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=duSxtW2eQ3TsYRP9Wn9zG9Pu7EqttDmD111mvNROXkQ=;
	b=b2nHT/PBQmqdPUUXZ3nJJEZtnrqIF4gHEVrWlWoAxZFBsFh2SnxZ+vn9d/sonbiJf2vmQJ
	5JRTeoHUXJnan+sxwAP/eqxD02TJzvDeK33CbcwmrSHy9hafAh2t/PYEgqyfg5n/A+AL0S
	gs+WsdxrYSA3EN+B6PfHVn+lTuHYUSs=
X-MC-Unique: TE3A7iSROz21CoTMATeUGw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=QQCsllE0Hr2fcXSZy17vYkKMECY3lg4bHblaehz/CRN4f56IzIEItqTkace1I5eoCk5kgaFFfDrsZKgJ4RJ3p2CR7cW6zdmoQjo7lEx1F6pNQw+XSuslnjVSzMKBXCfsHQu+C6PvmQnKiAe65G8pKWCpzWEUmtEol0LZqUdwcEwMddrpyvsfqlGzWrT1ufcFUKw8IMrLGiIf9gl+e865Qzq5RP/6S38xesudmEvbmZWG4BfdVKFrevqYU7weRRpY7kO/tMn/SqHjmbItEHuY/3EtG9bQpXe0+g67tpSyzMcL4m7y90xRMqPXGjUwwPYDJnJti+DPbr8glXbwwE3kYQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=4R10ktZCtmCirU7Gcu/ja3tt9ZkhyyzH680Pa3r7kZM=;
 b=D2jw4KblAs62Lte/8Zd8054m3hXTCQC/sYNbTDgfXnBwBE4DvPKXcYe3At4SmDORIO9+9j3Lto5uW8dDaEIGDiRXeooWdRyuZOxVVtCx7kz7ZkMXAmIqfrTN7p3mCZOPcYPVR3Ka+0VvSpRN6uC4gTATXJnbLI3OmI2byrjFfDhJiXS1YP4wv5JnakfB3KNPRGSC4lUnYxzbPP7vcmkHaUHvsXqAF/RXpY2vGBquRN3JGV/DOtTbbtnf2vWUgPBEN9q+MqrGvwPs4IYvqMMUMeomICFYtxIxmyYgUtF1avKwISp2LeeQUumvX8Vez0+MU9Dff75CXpfL7T5d7De9iw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <66b9fd95-bac4-55f7-2f3e-701f8444f37f@suse.com>
Date: Mon, 7 Feb 2022 13:41:38 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v2] dom0/pvh: fix processing softirqs during memory map
 population
Content-Language: en-US
To: Roger Pau Monne <roger.pau@citrix.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220207112008.51085-1-roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220207112008.51085-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0311.eurprd06.prod.outlook.com
 (2603:10a6:20b:45b::8) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b183020e-fc86-49b1-bc44-08d9ea37303d
X-MS-TrafficTypeDiagnostic: AM0PR04MB5203:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB52035CD73EB2E5B54ED33373B32C9@AM0PR04MB5203.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2449;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	WOm3oVW7tZXyaAbZrWs+HCeqJgRrq8M7AcDip7vw/teiQMNSgygdfv1Fg+CAKF8QDzVTFGid/mRUw12nq6uhzKzN867j/kQrbOBEWO6C3RJC8FFAcFwFprZ1t2TSj9ttzolt60Away2MS0bT+hRHQS1wf/B3PQIc0/fKAFEPnUJTRXmJxPK/l68MFNOOEpXcvHPRA1ijh7OoTMUjvRUsEC94JSD4CNLt/w1K/hFER7eKUC2CCVVbtklAN1TzKwxT/UN4IjJIPmKXAdwATUraL2n8UKaalPHDcqV5AeDhppoY7o5MBpB5LHB3joprELGivTubaBa4ivc5HlUoOB6+fAPlupbt19gZLwPHT/3R+BOWOlGDYv4jsF83+BErrXqqYy+1rmBzJ5D39/XgG5QPuu+I5H21ttoMQbR2n+xQABBzgrRiLkZPqaL1yVDQ5OzK2DTbkvido5mrcicnLuVF19kktl0bG/6rPGS217+QkLC0Or29/NTBFvUiPUkeMXLM1Lm73mbF067wlvxx8OuRs3Dg7ZpWQc/vpUX4MXVrMkFVd+Yqwg17SMKUrCr7jG+ctrNpuQAaFKapb8IieYf9kr+a+2Ku+dudUAmnGIX3G2yfz0HA0AhvS+A05hyq61OFlJiH47nsgpmtr+M7UkKyGS3oW0ms7bD5qNUshZM9xObvJOuRozQ+YhylfJ2ELUpjLm6eYbNS4ynoPfepz4GJyh7z/zzgYIuRHnFN27dPoRE=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(316002)(2906002)(38100700002)(6916009)(6486002)(4326008)(54906003)(4744005)(86362001)(5660300002)(31696002)(36756003)(53546011)(6512007)(31686004)(6506007)(8936002)(66946007)(8676002)(26005)(66556008)(186003)(66476007)(2616005)(508600001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?PxvFY4HB6SD0fu88ErbF9MhFB0Jpqj9mvbq5XCl4libW+TEhpep9F0nOdgW1?=
 =?us-ascii?Q?MeFwx+ehl6E9hRgKuF9ywWZ7FDeiFHLtO5NB/sB/BaUgnfPT96b6/PKuSON9?=
 =?us-ascii?Q?8s+uVZCXkR1JV445k5uRo5elztIwsWZjXcYn1woEz226aBnAUgqCGPXijaq8?=
 =?us-ascii?Q?5d5zidgyuUVDgt5sgKBgg8gTr1J0VP/vSVvO5TWyW66T20UIHVtmtAp+05BB?=
 =?us-ascii?Q?7ULoGnhwSwo5JJ6eFuxFUumIgmj6BC+/r88mlClp9Plj22nZWAgVU3VGk6Lo?=
 =?us-ascii?Q?EP2iuHhlzY4xkMeO0WSP24HeIJn01gWgwHMa/m1VtcphVPnd1MQhPT2XRbjz?=
 =?us-ascii?Q?OQUYJKiu32iqlmCGWrpp6y+BwmBjSYPjB35I0m0L3MpQ6AYgD+zFUskn7ISY?=
 =?us-ascii?Q?IkIl5J4cFgJZ411j6/014t/Le6A5XQKYAWRiuslxn4JV2EpRpjOi3875pVAV?=
 =?us-ascii?Q?6nGXEBsglpOj1M/HoBphUoLE9kO8zLMNOLmQYoLtydKZOEj3OaVYNPzG35GV?=
 =?us-ascii?Q?6HXtOjE7tpZzhyPcmi9JMspJ9Kj1oAdCSg3JoW6jmwXYTG31h5g+CfcSFPWY?=
 =?us-ascii?Q?q9cWNbZUC6RVMED0fUAIcPJs23JGZuPp39rZYJ1KG59QrvmSr2or+/561OHt?=
 =?us-ascii?Q?3Rfu4KZuLqaePeigQ0hvmCJcDMHCLjqIpDXk63qtlNPiCMp/xdsXEchAeRu2?=
 =?us-ascii?Q?ncSaalpv1E/Nwl/vr1davIyoItWMaNd+lT+0AYe6rqWKhyfafjpNMUf/FG6A?=
 =?us-ascii?Q?eiz8mn/oPnI5/QcP6zWGMkDqcTh+5em0lmdTCKmcej4rrLDHBvmGqnpj2QI2?=
 =?us-ascii?Q?AlNAeXmi6A9H3v1XlKc2dhnL7zqYZd1Jvq0AkNh6sP6GCLV0ZLQjp3mQsGaB?=
 =?us-ascii?Q?lQk/6xLH9IiZLch9c7bJA9WwQ97w6nDi0FZCFoAfAZqh6F35nDtDF6nQZlj7?=
 =?us-ascii?Q?QL0fX1eVDxIlR1z7FeVzF503qOwl+Jk+5jvTTFA/Aes+WWVLhQhuG/6i+xld?=
 =?us-ascii?Q?60t8STIjfvZqmQ9giwBlN/OoV36zpfGpfDuveI1nYfRZWhJIFMMHCZugwtCa?=
 =?us-ascii?Q?4bIH2U1kNNNHEjIrqmtMcosUcbbBw/QQq5Fxnu7Kj5Xk3rJHmy0Haex207i1?=
 =?us-ascii?Q?Zv/DmCBBsc2McHdmHexJbpuiosBOZt3rry/qci/2PhOBHriD1aKKHm3SGUJZ?=
 =?us-ascii?Q?bhrJH1E9zRr8kIk/Hs5wRK1IEuk/F0lH3n/OkStwV6O946rUfae3SJvEBrqm?=
 =?us-ascii?Q?zlCXS/2z3i6StRE29SBaHpPymWopoiiL4rA5k/RIgvFMGp+AJdeRZzu63mcp?=
 =?us-ascii?Q?znkQuVsDWHcdJ9z99H7F1K0XnYpGk3SxE5uMlYSXgSmuV1fr5mI1xvrshNcH?=
 =?us-ascii?Q?8c24fKxodKD4e14dUuxfsBLH3UE7NMOa6HL7bmwPeBuoi7U8gNI+HGTBKPNL?=
 =?us-ascii?Q?HU7HuYVrLnblcmjE+GIaPTJirDaOb1aZmhd49vD/1fzjKDc0Y8ZiF0dgjzBA?=
 =?us-ascii?Q?PkuwOPmoLn2TVWNym31CAXGZDRliAgZnhWYKNqR7STIQScuUHDa8G8ME5k7w?=
 =?us-ascii?Q?jpSWk9h0aFKUrAa2ItOLxyZ5UG62CmiQM/aS5TEFbhk4p1bJC6f9+nvUxnW0?=
 =?us-ascii?Q?zvELzpBgXLXvdlyqGD47CF8=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b183020e-fc86-49b1-bc44-08d9ea37303d
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2022 12:41:40.5120
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Sc0r1Ff18pmJ3PhxfIKfbRRBK7NBfNPqtDHMka97nMxCcDwo3Cy2qAEaAnprKRjSeBq6Qgl8ISZCcK/5pPJBnQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5203

On 07.02.2022 12:20, Roger Pau Monne wrote:
> Make sure softirqs are processed after every successful call to
> guest_physmap_add_page. Even if only a single page is to be added,
> it's unknown whether the p2m or the IOMMU will require splitting the
> provided page into smaller ones, and thus in case of having to break
> a 1G page into 4K entries the amount of time taken by a single of
> those additions will be non-trivial. Stay on the safe side an check
> for pending softirqs on ever successful loop iteration.
>=20
> Fixes: 5427134eae ('x86: populate PVHv2 Dom0 physical memory map')
> Signed-off-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>

Nit: I guess it's "and" and "every" in the last sentence. I'd be
happy to adjust while committing.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 07 12:44:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 12:44:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266817.460523 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH3NV-0000my-24; Mon, 07 Feb 2022 12:44:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266817.460523; Mon, 07 Feb 2022 12:44:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH3NU-0000mr-VG; Mon, 07 Feb 2022 12:44:20 +0000
Received: by outflank-mailman (input) for mailman id 266817;
 Mon, 07 Feb 2022 12:44:19 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=owYM=SW=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nH3NT-0000ml-T3
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 12:44:19 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id aa740287-8813-11ec-8eb8-a37418f5ba1a;
 Mon, 07 Feb 2022 13:44:18 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2173.outbound.protection.outlook.com [104.47.17.173]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-14-L0ijYg2hOeOD3d9XJJfcVg-1; Mon, 07 Feb 2022 13:44:17 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM0PR04MB5203.eurprd04.prod.outlook.com (2603:10a6:208:c1::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Mon, 7 Feb
 2022 12:44:15 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.018; Mon, 7 Feb 2022
 12:44:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: aa740287-8813-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644237858;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=mc0EmJ2Mg3cHfSZS4ns3R9Ze/ls3uF4kcDlF/rxSnzg=;
	b=H+kQIrx1EAm3PrIPIfJZHTI0MJauZwkiMzLGYAd1D5IW06dJSiXtsZeETzQufOFPhdizGv
	nYBnR17XNSo340GQZCBGq5ay6bx8jPdmqnIygAs4Q0Hhjfe8vJLRjQB4Jhyu4u48BA2mnN
	MsftAZae+hfpWAy5V4sZOe0WN2a6yDw=
X-MC-Unique: L0ijYg2hOeOD3d9XJJfcVg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=lmWQeIFfiKL0YuATWWkOVdSk0PGOgb2grDq1nEPD9gJmZo3mBn8WQWAs3A9wuGOftykAA+ZdwCG0FWKoLZs3yNdeA5AKRhvYC6jZHlORPOGV0TVKBuoEg8RhXGmonQDN+OPLfOfiaUxBoHwOvKx+1QTOmeTUuV0qni5p0sRlXatUW5UTf+/DHJAh0aZZyEWCsNITuhwawf2NPjT5K7jl5j3ZJdNoqkRR+kF+vFi3LdxYUi7mGhm/Znxq8lt5Xno9Pk3iZpfK+4EddF0dnVYBx/7DUlCeTe3S0bxAyTHW0WndZJE/HWsCnPsiR0TikIKuGH0Baot2khGbuaFJehlTIg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=UgOgIVGHqp6uwlV6qACYzpHBiaLrb2SMnM4IY0n+KVc=;
 b=YDLvmkR8lRjlMQNoPoF/Ocxq22qmXjXEnuk/MLfOy4chaGoDaRm8QOVRdd1eK9AeWdpHSYYPr8AMuG1tbSLduB8d5KLvxYyIpk9l+0ipo93vBmUTjPh0WxHspUAKOWP7HPBWOS43CynRVgpoy+DUn6WLGw5ZLs3hlPGoHkEdyR5Yr/bLiCW0zFREBYYtvV+V4k60gded8heiQtsVPQoSeLl1hBG/4uJFj7gw1xcRolLvIXBM6pA7Xnrh7KxmI0URo0aRY3Xn0BVw87nHdpGzJoTxy2Aef6BHpbStfNjatw0qzfHK1aTnA1KepoCLPbATUi99zY/tLOCYgAP/qBpGvA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <13afa877-d885-0419-96c2-96754f1750ac@suse.com>
Date: Mon, 7 Feb 2022 13:44:13 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH RFC 3/3] xen: Introduce a platform sub-op to retrieve the
 VGA information
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Julien Grall <julien@xen.org>
CC: ehem+xen@m5p.com, Julien Grall <jgrall@amazon.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220206192839.75711-1-julien@xen.org>
 <20220206192839.75711-4-julien@xen.org>
 <4da70949-7d6c-65a4-662a-301bb7075bc0@suse.com>
 <YgEJWLF/yp8YkU2M@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YgEJWLF/yp8YkU2M@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6PR04CA0053.eurprd04.prod.outlook.com
 (2603:10a6:20b:f0::30) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ae9e99f2-abaf-42d1-b466-08d9ea378c8e
X-MS-TrafficTypeDiagnostic: AM0PR04MB5203:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB520378F8503412A52DF7B657B32C9@AM0PR04MB5203.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3276;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	W+3SUsXXTdRT8oqjxjsLzqe7OeYz3C7LxKhRb3RRXirzDNij5wcrIRY7GhlGjyhzheDu8b6szO9MwfiDKchfCVU4F1/6YLLiVMQw9P0v7UQMx6nwQAHicQ8hy5BB+KbLdYe571cSXF6Dt/j8uZ633K+Sw+QGG8dSt6Fsu5WWMSrz3xDZLnXVqiVw9AdfBgPnI5dyn/oX7/sFYRGGMiWvcoXGINS+suRecYjEOLzygfq6Za6fREa6PedW/qKFaYp5pRbSCmQ8yro3nIMcRdc/K16cxCzMIgucZns4SRvOhTElC5Ou6H8PnD454fmYwPp2tweaMM8h6oee8P4Q+2VLgYbCtcNIFv9Hy6pcuvzRD2zDyN10ptB+bw8cAOW4tqpde9asHsJM7HByc/b5EtXzBf+jTPnIIzmVmoHJ+DBxX3nHxfQRsrTCAheDWj127wN3/ru4lkaBsU9U/EKjm4bN+6aBfp+oUhqHx8T0xVqWmxrWlOgiMpnP632x686zB4pQXC+A952RlRNqRmxrVBkXKJO0CN/HXg6cvuBoT6mYJOTtuyaUnrZlOe4KTK2zxEWnzDOdPCa7KG0H1wKuBDy0pHsXYCOfoTRejIVblmpY+hGSEZEk7wqJb//gHpiI9/szHbGu0Kf+75mV/t7ZH/qzbsCghxJK2WFlvcn4Jj2AXDjHc2FddGeur3pQbldZeiDRzzK9xMvvBuP9Zck8AGmQIvSbSej1DzuPH0nfw6s5Deg=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8676002)(36756003)(6506007)(8936002)(53546011)(6512007)(31686004)(66946007)(26005)(2616005)(508600001)(66556008)(186003)(66476007)(4326008)(54906003)(2906002)(316002)(6486002)(38100700002)(31696002)(5660300002)(110136005)(4744005)(7416002)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?Yli1toXiCnDQMe25+0TO0TFKtzGqOv1uFI11vd0O7Z+UF1B6FO+o/825gBoS?=
 =?us-ascii?Q?Y9FiSYbUCvdWzCjuAaJh+tFFxERP141ubNcWkO4FIBxa6PasZtaQ7nee4ilR?=
 =?us-ascii?Q?I6zkmu0q0ZsmgR5zdTFI8rT5FMGdXBSgH1ummwoQ7xEy0yi4vTxN5AhnNGkU?=
 =?us-ascii?Q?YtKjpwuQO6c27393DybnrFNZZ0OXcr/R80Hn3n8BBAdHdteuGy0A8K1R6nXn?=
 =?us-ascii?Q?FK5eCQOEv3W9AbzxdP/Vp7KxG1SPg3VhmzVGf9y6NSqdLaFJkRScOToov+xi?=
 =?us-ascii?Q?jublsdJbWUJyD9i56PO1gkgfFZxmf9zKMWwchK/5VuXEJsKrfD3zl59+IGn+?=
 =?us-ascii?Q?1yk2edh011cJBuV7auu57AAs11uEZjQi/pLGeaOz/WbsdwxbjV38k5xpOjyI?=
 =?us-ascii?Q?kf7ePeCN7UIE4qivwV8g1KjB4AguYNDQZPPQKSOXalz6LEeDCf+DGHU1cov/?=
 =?us-ascii?Q?4DRZxt7nAHfaGLR0IKm9mD7RmvZ941VpPYxxYsnXpzvrftiboYvvBFMogZoQ?=
 =?us-ascii?Q?2LYhfTPjG0SqH6bGfIVXmV0+jsL95umneOtWtBCjp8Ft5qhNjqvY7KI0cSvW?=
 =?us-ascii?Q?hizZeC2vBipZ5/SNchN5oteVP8MYa5AIinCq/kqi7P6EGXbYoHY3OG+7/lVU?=
 =?us-ascii?Q?01ZlFfeLRnBKym61RdRkWdyu0uu9/LbpIqR3Dz6MTYWx1Hbi3FRQIuj+5b8j?=
 =?us-ascii?Q?BNT/7Xj1e/GyK+9cTOKoT6KRkYvXQakzhS6633NZLHcRHk41LCpLGiYswgcy?=
 =?us-ascii?Q?Dc6Ap/POnPkGnXPv22vmLJkKaYxBD8I8KVOW+LopOQDKDuL8cKf6VHCW2CBR?=
 =?us-ascii?Q?MUEXqC/onuQtw7GYswh11wTcY45OKezMDK2lmjnbwFIaQWhL+ibruovoj2sP?=
 =?us-ascii?Q?dwYvdZGzi9SjJHgepVSuJh8wh7FVV/J0ZnCiCJ+bnIvpcETad65HT0I7zvGg?=
 =?us-ascii?Q?pX1WwDspajVwGcTnf6KSVClwNKaYSUY7yfgDhPyDWke6uxlEbmW/NbjVHKZY?=
 =?us-ascii?Q?WXgPG+zCHExwu1TMPgaa6wz1e/Tz+NS4g2kk6ijGGpFW/Yytr+4+GtfXx3+9?=
 =?us-ascii?Q?vmq49LCx0HFCZIVAK2mvsDvVlOfgPVgAI7aT8Toi8wPS75Z5B10ehHs3+7If?=
 =?us-ascii?Q?XfoSpL7CxzPm0fmQAEk8VNZEB6zPy/tyeKhO7FSGnrweavNM3cGP928gUkAv?=
 =?us-ascii?Q?U0pixzCawD+IP29m6pTO6cy71qW3+nC8cZ1M4UgY8yemQcF1sLtQ3qjRnNfl?=
 =?us-ascii?Q?CZh/O7PYnxzANqNeib7FcPmV+26LrVHlqJj2hHZWldKS8F0LXzijhfosuD8a?=
 =?us-ascii?Q?9LUnk2OWENCGjnBuhJId/v4vksA0Wk8YQBNVUL1Mk2Y8rgyfICzw8786Qbzn?=
 =?us-ascii?Q?267CKOXOnPr8mLNWV7ukzi7f+flXadNO6+liFfqYECV7qnqTZetXQvf2nrn2?=
 =?us-ascii?Q?2sLZksDkJZjgvsbMOOFfLTtU4zg7/HZr6p8AVwGP5Kjag3FVRPAyc3oiGJgl?=
 =?us-ascii?Q?DpZ0qjJ8pV+CCd8WdL+jtnVEhwhxYH+a4Ob9ooVacp5jmNOzCPLwZ9s1ECaY?=
 =?us-ascii?Q?kJ7BXcS9fMoYr7bm7mw1IwsqQCnnPPV7GiatmkUONzJe805UVS2EYoMyXOL5?=
 =?us-ascii?Q?H+ba58UHFivbIGsVLpiT6Ec=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ae9e99f2-abaf-42d1-b466-08d9ea378c8e
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2022 12:44:15.3774
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 61+X7hIdYBynHxaEJO1U8T2CF3yCvf/+Db0Q2pXrRCTf0isZq/TM8v/hfw6nt19odqn1XhWb0604UakOMnruhQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5203

On 07.02.2022 12:58, Roger Pau Monn=C3=A9 wrote:
> On Mon, Feb 07, 2022 at 09:57:55AM +0100, Jan Beulich wrote:
>> On 06.02.2022 20:28, Julien Grall wrote:
>>> @@ -311,6 +312,7 @@ struct xenpf_firmware_info {
>>> =20
>>>          /* Int16, Fn02: Get keyboard shift flags. */
>>>          uint8_t kbd_shift_flags; /* XEN_FW_KBD_SHIFT_FLAGS */
>>> +        struct dom0_vga_console_info vga;
>>
>> ... the structure name including "vga" (but if the #define is adjusted,
>> the field name would want to become "video" as well).
>=20
> It's my understanding that this will forcefully be
> XEN_VGATYPE_EFI_LFB, at which point we could consider giving a type
> name to the vesa_lfb field of dom0_vga_console_info (video_lfb) and
> use the same struct here?
>=20
> There's no need to propagate XEN_VGATYPE_TEXT_MODE_3 into this
> interface.

Hmm, yes, this is probably better / more clean. Julien, thoughts?

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 07 12:46:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 12:46:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266826.460533 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH3Pq-0001OO-Em; Mon, 07 Feb 2022 12:46:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266826.460533; Mon, 07 Feb 2022 12:46:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH3Pq-0001OH-Bd; Mon, 07 Feb 2022 12:46:46 +0000
Received: by outflank-mailman (input) for mailman id 266826;
 Mon, 07 Feb 2022 12:46:45 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=owYM=SW=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nH3Pp-0001OB-7f
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 12:46:45 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0107be40-8814-11ec-8f75-fffcc8bd4f1a;
 Mon, 07 Feb 2022 13:46:44 +0100 (CET)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2058.outbound.protection.outlook.com [104.47.12.58]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-29-P2hLgr-CPP6s_uV8sZgd5A-1; Mon, 07 Feb 2022 13:46:42 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4143.eurprd04.prod.outlook.com (2603:10a6:803:46::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Mon, 7 Feb
 2022 12:46:40 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.018; Mon, 7 Feb 2022
 12:46:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0107be40-8814-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644238003;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=JwlBKYbv/zKdEzC/6AL8tV37IW1fDoFnfkUJOLWzqDM=;
	b=bEwlc9UUngFhERqplCO1Npq9u4vcRAYjwfn2uLp9/GxUEEpGkJZsXcNnL5xo0NOb/P9Q4R
	l1U7ZOFgWQmkFsGg6U+OqCx3O8MgTd2N5YoJuabiWDzHWNAGhOUSr/zV3qG36wcZgTmGRJ
	68oCAdJ9tzKs/bx3+79mZ5uAh7HlN68=
X-MC-Unique: P2hLgr-CPP6s_uV8sZgd5A-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=kZnDc2br8dl6DIP7ZlRdHT7vVlvnZfrMaaEq+COyxWBIltDmyf3cvP/BhpVRzedzqDN6I3aQ/nVFgOGKHuyOSgSL5xDdlSb0yV4J7bGPBdQmfVVd9kCXA3SXOrQFwM3vjuyu6L2qLqS5WKL9NzwuU2VJYuVkkPoGuN7CvPDAmgytewXSju9bMKvuxqtNubxAdsTe5ljjL6/3K6R0UfsTKybi2ye8QzRdtu4wcBziGWsiKTHI8NtCw7x4wGwHS3rBSL3PTw9i0nq+KhKiab+7s5ULzWxUKObD5Ec9rhXB1Rln8vIH7/vFTnYSWswDzhgYks8kpRtOr7W2k+OREH0G1A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=JwlBKYbv/zKdEzC/6AL8tV37IW1fDoFnfkUJOLWzqDM=;
 b=lE3Cfe9LhqOxw/c5FONPmR0fOUwqmFaU7ENoe+2+OEBT/+TkZpEaujaLC6JUBNw9ONFwvTeY8DP6yC4qJz0pW3ueSziTiSAvaiAs9qty3V3dVgaKbPLEPuhWiZl/Hbxy2aBDRJHN7skCopLtPInn0TNzYtpGtdtk4d7an4SeopSD75PiZqGMS/Rd2ETvVb9JxWZBtKxTrCyzCClpzKQU+ox/iotD0pf0/cnek2xK3oPmPQdhGa36L01dBXNcPTmM1tEloJcS0URKnPeeGgPOHtxsCoT7sLJ+GSDHrOmV6x+eRnaPYa9zRE0qa6FeJbhA1FcM1TE2t/RRauN8AjFQOA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <11b3a2be-0ca9-6464-e9a3-392f7495793e@suse.com>
Date: Mon, 7 Feb 2022 13:46:38 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH] xen/public: partially revert commit 7c7f7e8fba01
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220207103613.32260-1-jgross@suse.com>
 <c2c185cb-2368-cd61-df72-7792b075746e@suse.com>
 <9bba716a-8ea3-a104-65d4-28d62f69f22b@suse.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <9bba716a-8ea3-a104-65d4-28d62f69f22b@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0129.eurprd04.prod.outlook.com
 (2603:10a6:20b:127::14) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4561440e-9310-42d2-55e1-08d9ea37e31e
X-MS-TrafficTypeDiagnostic: VI1PR04MB4143:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB4143918A3E8B32D43AD8B026B32C9@VI1PR04MB4143.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	BOeCLrD2M7Nw8Sw0kMtW8Rt/sMzf/jteiXYSlknIZ1iz+g+k+QCmipztHI09c0L6ivkQonBsLA3Ecq2Es5/Zrl5i+ISG0kg2CeoiqLUV/SdFwSF4PMfJ+g8jglrFVG/c6UV64s20AfRGTPjZ4pMohxo0kVQudKvP3mSY8gm7kb1JdL3XZcyUzp86icKsJToIJLSajdhtcNmCUu1pLk1wV3l+veO+AEl4AyjrXvllxxC0epiqcLU3WqYc0XqBQIJqLpkrMWl2OM05cO9GPNixOT5pQMwuqYodWdaEKO5VQHrESoYsb81GoWArnrFCZ1jb3nUX6oGjacRhbHzoHxeiVhEde1Kfc+3KDnbMsSMat/ryMBCb2ptIh3zvEYIep0wzatUF+sM8+rgkozRVKrq5fcd8Xms6815e250T6snMZMGmjCQ2f8q0uf6sKXnjwk/FVR6EaZUAGykoAgkLZdGUFk0W7r46y7JgBIiv4F+mbBGXmbXiiAlNKOcpBG8HY6zgY+IvnTRXuMJWa3Zxs7KJXc+u98fJUAbLvk5YHqgCprMLs5k6Z36BebuNQdE4K4PhwRPCMjGdRICXmvNlK4m4Jvx10u0uv2ar4tKPJP0z57PSf95b933gbB7HtjkIxB6DQifErfMaTJCr9o6Foa1xUHMfa5ARrJND+mWe82E5GGxu3sHFM1XGo3IkQW26e/B3oqvr3AUkqvnIIRMv1SepgycCERoLkpJHVBdA39vNpbruH1n2z46W6y2aClsL4tGU
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6862004)(66556008)(66946007)(8676002)(4326008)(8936002)(66476007)(53546011)(6636002)(54906003)(37006003)(316002)(83380400001)(6506007)(36756003)(31686004)(6486002)(186003)(26005)(2616005)(2906002)(5660300002)(86362001)(6512007)(38100700002)(31696002)(508600001)(98903001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?enlmb0I3Vm5mbk05M1dvaDVUMDRIc00yMWUydWtUNGFnMVhPRG1HRnl1Zmhr?=
 =?utf-8?B?ZEY1dHIweGg2a3N1VEhwYk9SRXdEbjByRHhkTStMUWNXSnlIYWYyS2hPNE1X?=
 =?utf-8?B?N0RoMTNpMm53amM0d2dQUndPQUtBQ0wvM2d5YmpUTzh6UGVPMFNSckdsMnNJ?=
 =?utf-8?B?VFN4RGpOcUd3bGpvRVV5dmVTL1pBLzI3a3FUMWZ4UjJNbVh0M2dwaWNLSDR3?=
 =?utf-8?B?Zy9kdVp5WHEvLzMzUjQxaXUzdU4yL2VUVnFNb2pkUThxMlpNdHM5eTljbGJx?=
 =?utf-8?B?QVgvRVdkMHdRejBVdlUzZ0xZN0Iyc2c5d0J5aE9BRThlRkxJSER3eTBOQ3kx?=
 =?utf-8?B?WEpzNDExbi8zUmtPMHZHQjhONmt4azZGdytJMThVNHcwY3h5OE9GQjdtZ0pp?=
 =?utf-8?B?S0oydm1rditPcUFDM3BtM09iTWlWaTkvbnd1Uk96cWlLR3lMQW5VVmtHRi9B?=
 =?utf-8?B?c2RGanhtNnhCdTZHVEgxdGdia3RwcHhyY0pQNEFGN0s4VHJrajVXV1ZlUStV?=
 =?utf-8?B?cG5JTkI0bnNvVURTVFJGM2w4MXNibThNclZHTG56QTY3VEpwUWtZdndoOEo4?=
 =?utf-8?B?bkNUUmF3TG5Db0dubmxuekJHS2J5RTc0NmFjc3JkSWlpYmtmeG9WQnJzaDV0?=
 =?utf-8?B?NS92K1pNUm84WU9JQWhGaEpBMXBqR0JUS0grb0Z3WThvbUhzMzdJL2luSTky?=
 =?utf-8?B?OVo0blJ5Z3Z1Y25zcjBlcy9UL0dOYWZWMXdMamVYcUVzaG00ck53M1EvMnUy?=
 =?utf-8?B?dEY1MjFPY1QvMnZCRnRDQXBuaVpQVFZGeHJrZ1VkY3RvOUhMMUlKU1NmUmc0?=
 =?utf-8?B?ZzVEMWxyeGNHY0RJU0lHcTFoczQ3akV5bklNTFBOUWFVTmVXeU1Sc0FZcUVL?=
 =?utf-8?B?RHYzUWNJWnB4MVlZOXU1MTlOMjJWZHArRzBqZ09jbWlWZjc1UzZ1N1FjQzdN?=
 =?utf-8?B?a3I3M0Y5cGdKaEN0WjRLWTVZc2V6bDVwTER3eWFONm9UU1lKclJ2dmxraTNQ?=
 =?utf-8?B?UXpseFFWMTdIMUhjemlWa3N4Q1RwWmNGdG5iRFZYUlgxVDZQK3hFUFdSQlAz?=
 =?utf-8?B?d2pNVitsTEdpUmxRSkN2b2JycVNRS3VZZTZDbyt1UzVnSndmc0tvT0thcTFh?=
 =?utf-8?B?UDVjMnpnNWdhc2lPMWtyaktaUytjRzE2SVY4WmR5OXRGd1FJbFhuSGUyTXRm?=
 =?utf-8?B?Y3J3TXc4bmFEYWlhQ0NUUG53M1NObGhGOU5QcWxSWmNkRVBmZms0c1h4Tllw?=
 =?utf-8?B?VTJzcHk2NER4b0c3b3hla3p3d080Q1ZEQzBIdFQwaWJiSjhpVEVTTWRMMWg3?=
 =?utf-8?B?NWVlSmhKR2krRHdlVG9sZEx2YTRvT3dadlczUkMyTXBWamg2RVNYazFCWGhE?=
 =?utf-8?B?SFNVODFNcWNBTkVOYitoSDRkQ2NZTkxjSVpKclpaeVIveTJ4NkFjaHE4aml4?=
 =?utf-8?B?OG5BSmVqME9CUjBOcDM5OVhQV0dJT3l1Rm9IOTFyL1ByTFIrK0pZV3lCRHQ5?=
 =?utf-8?B?Zk96NmIwZ0FUb1Zma3B5ZEl5QUVTY2Zxd0w0eTI4TEp0OXJ5cVF2Z1lSYW9v?=
 =?utf-8?B?ckhyME9rcFNEeHlhZ2xkTHZzR3pGLzhNQ2c3QjlwMlRYa0R5ZUlyazVraU1Q?=
 =?utf-8?B?ZGV1UUxnVlZRY2QvUVBoalZtM2EzWGxQbXgySDFUZjhvbjdpRGExT2M5TFRM?=
 =?utf-8?B?bVRUQjRneHptbStnRFAvUFJyclJMSk9FRmpGMTBGd0VHYyt3ZEtmOFZoaklX?=
 =?utf-8?B?WElEai8vVnBqbWZoanJLditDYkMwaTEyM2lIMFp1QnMyQTM1dHJXcWR1bFB4?=
 =?utf-8?B?U1BtcStNTXk2NnBsQmRlOFJEamdIN0VMQVVWcHNHVG0ra25uZmhiSzYvaFdS?=
 =?utf-8?B?VFZkc29QdHJBMXY2YzJzejMwS1d5R3BhWjUydGRCUHRhWktLZGk5UWJKL1Ey?=
 =?utf-8?B?ai9Sa21GcmhTeFVTSWJGeU1jdEMxYUpIc1VGbEU2V05GRjdRZ3hMR1ZKNHlB?=
 =?utf-8?B?Q0xNL3ozb1JiTVdrRzhKWXBIZ25SMlpsSklheWlvS1ZKbjlON0podnc3L0pa?=
 =?utf-8?B?RlN4WDcwU1F3blhRUGw3Z3ZKZVFyTkhpaEl3UlcwNEhEdVcxWm51YnBQUjFF?=
 =?utf-8?B?MEk0cTVJcUNrWWh0QkxvbVZUN2paSGtYdUJQMnVjb0FUVTg3RTBPSGhrOVVq?=
 =?utf-8?Q?uP0LunMgPotbLOMTElShpHo=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4561440e-9310-42d2-55e1-08d9ea37e31e
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2022 12:46:40.5715
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KbgHc+A/Chk2k7369es15g/9glEuOH/R1NNxTp3os7tfTHDiBFAuPHnNeGM1wLeYmEl070S346PuJqJPLSI+YQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4143

On 07.02.2022 12:00, Juergen Gross wrote:
> On 07.02.22 11:46, Jan Beulich wrote:
>> On 07.02.2022 11:36, Juergen Gross wrote:
>>> --- a/xen/include/public/memory.h
>>> +++ b/xen/include/public/memory.h
>>> @@ -662,7 +662,17 @@ struct xen_mem_acquire_resource {
>>>        * two calls.
>>>        */
>>>       uint32_t nr_frames;
>>> -    uint32_t pad;
>>> +
>>> +    /*
>>> +     * OUT - Must be zero on entry. On return this may contain a bitwise
>>> +     *       OR of the following values.
>>> +     */
>>> +    uint32_t flags;
>>> +
>>> +    /* No longer supported - will be never set */
>>> +#define _XENMEM_rsrc_acq_caller_owned 0
>>> +#define XENMEM_rsrc_acq_caller_owned (1u << _XENMEM_rsrc_acq_caller_owned)
>>
>> I think this goes too far: Neither do we want to re-introduce the
>> #define-s, nor should we re-fix the purpose of the padding field
>> to be OUT (only). All we need to make sure is that the field
>> coming in as zero won't get responded to by setting bit 0 of it.
>> Imo this can only reasonably be done by way of adding a comment.
>> This comment may, in turn, mention XENMEM_rsrc_acq_caller_owned
>> of course.
> 
> The kernel could be changed to no longer use that #define before
> updating the header from Xen, but are we really sure there are no
> other users, too?

Pretty sure. And I think in this case it's better to break the build
of consumers (so we're sure they'd notice, assuming they import the
header directly in the first place). It's rather an exceptional case
after all.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 07 12:47:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 12:47:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266833.460545 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH3QL-0001vW-OW; Mon, 07 Feb 2022 12:47:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266833.460545; Mon, 07 Feb 2022 12:47:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH3QL-0001vP-Kl; Mon, 07 Feb 2022 12:47:17 +0000
Received: by outflank-mailman (input) for mailman id 266833;
 Mon, 07 Feb 2022 12:47:16 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=hYSm=SW=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nH3QK-0001ru-9s
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 12:47:16 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 11646bd7-8814-11ec-8eb8-a37418f5ba1a;
 Mon, 07 Feb 2022 13:47:13 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 11646bd7-8814-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644238033;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=fIkhgpoA9HInbkbMdb7M92sMZI4UpmRyJhdzVvkWngs=;
  b=HbXSh4EenxvGotyDTau04s8Jx8hs5WOIj9tScDs2OyBVgWh/8P+Y/7fb
   haKc8htGchxezYd9bvkBS09IOh4fDsde2l3zAe1LO2/di/fUaM3oG1ROM
   cCom50+NHWRxiLES/gSeY+Bj6/WyrNoZ5w1uSMLdo5O5ZZ+gLTHxfbZMJ
   0=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: C77i+etr9D9s9HzZMGOP5iruX7lF1LAegDo276ZtMBgn+z6hMzDHlEpj3H4VHoyVChg7kKjiDv
 8KsR1JJiG6MR6oSCzEgCX9mJAFcaX+bJG6Srew7a29qQqZXg8ITp+u7lzqsETvcMa6JTgMsKAi
 jJLFzd4wx0ij8jTI14q+ztI0df7OYKuXHOcWJWL1fgFmoTZtHXJjzTuzgsG9KesHgbwSxMsJgp
 7Ue1DbTTy0K7CqtauucUkJGK9OPC8q8CQxkreDEC1vwYdym802LY4vXVJTUdtmTficOeTR+faF
 cCQm0DcvFaqrOSudc8Mj0Et0
X-SBRS: 5.1
X-MesageID: 64044594
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:I78iBa4KV7PUh9byCHx4DgxRtBjBchMFZxGqfqrLsTDasY5as4F+v
 mJJXjqHM6zba2X1L41yOtmyphhUsJ7UyYdrGVRr+Cg9Hi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FV8MpBsJ00o5wbZj2tEw2LBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z6
 twW5aa9VQISIbCTycYQSyQGIwFTBPgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALNs7kMZlZonh95TrYEewnUdbIRKCiCdpwgmto2pwTTKq2i
 8wxQjFfZwn7RyJ2PkoVMZEymryz3SnUWmgNwL6SjfVuuDWCpOBr65D1OcfRUsyHQ4NShEnwj
 kvc42n8NTQLO9WexCSt/2qlg6nEmiaTcIgfDqGi//hmxlia3HUOCQY+XEG+5/K+jyaWS99Zb
 kAZ5Ccqhawz71CwCMnwWQWip3yJtQJaXMBfe8Ug4QGQzuzP4gCWBkANVDsHY9sj3OcIQjgt2
 k6MjsneLzVlu72ISlqQ7r6R6zi1PEA9L2UPeCsFRgst+MT4rcc4iRenZvFnHa2uh9v5AwbZx
 TyQsTM+jLUei80M/6ij9FWBiDWpzrDLUwo06wP/Tm+jqARja+aNQIil6kPS6/paG7qIVVmKv
 HUCmM+24fgHCNeGkynlaP4WALij6vKBMTvdqV1iBZ8s83Kq4XHLQGxLyGggfgEzaJ9CIGK3J
 h+I0e9M2HNNFFmjNv9Nbp60MNs3kvnCGMzYCMD0Q+MbN/CdazS71C1pYEeR2UXkn04tjbwzN
 P+nTCq8MZoJIf85lWTrHo/xxZdun3ljnj2LGfgX2jz6ieL2WZKDdVsS3LJihMgd5bjMngja+
 s032yCim0QGC72WjsU6HOcuwbE2wZoTWMqeRy9/LLfrzu9a9IYJUa65/F/ZU9Y595m5b8+Rl
 p1HZmdWyUDkmVrMIhiQZ3ZoZdvHBMgj8StqZHVybAzxgBDPhLpDC49FJvMKkUQPrrQ/nZaYs
 dFZEyl/Phi/YmueoGlMBXUMhIdjaA6qlWqz09mNO1ACk2pbb1WRoLfMJ1K3nAFXV3bfnZZu8
 tWIi1KAKbJeFlsKJJiNMpqHkQju1UXxbcovBiMk1PEIIx6ymGWrQgSs5sIKzzYkc0malmDEh
 lrJXX/1Z4Dl+ucIzTUAvojdx6+BGOpiBEtKWW7d6Le9Ly7B+WS/h4RHVY61kfr1DQsYIY2uO
 rdYye/SKvoCkAoYuoZwCe8zn6k/+8Hut/lRyQE9RCfHaFGiC7VBJHia3JYQ6v0Rl+EB4QbmC
 FiS/tR6OKmSPJ+3GlAmOwd4PP+I0usZm2eO4K1tcln6/iJ+4JGOTV5WY0uXkCVYIbYsaNElz
 O4ttdQ48Qu6jhZ2YN+KgjoNrzaHL2AaUrVhvZYfWde5hg0uw1BEQJrdFi6pv83fN4QSahEne
 2bGirDDirJQwlv5X0AyTXWdj/BAgZkuuQxRyANQLVq+hdeY1OQ82wdc8GprQ10NnAlHye96J
 kNiK1ZxefeV5z5ticVOAzKsFgVGCEHL80D90QJUxmjQTk3uXW3RNmwtf+2K+RlBoW5bezFa+
 pCeyXrkDmm2LJ2ggHNqVB43seHnQPxw6hbGyZKuEMmyFpUnZSbo3/21bm0Sphq7Wc48iSUrf
 wWxEDqcvUEjCRMtng==
IronPort-HdrOrdr: A9a23:JP4JXalLjuNkONqWlugNqtaxoMHpDfIf3DAbv31ZSRFFG/Fwwf
 re5cjztCWE7Qr4Ohkb8+xoXZPsfZqyz/JICOUqUotKPzOW2ldATrsD0WK4+UyHJ8SWzIc0vp
 uIFZIRNDSaNykYsS+V2miF+3lL+qj+zEgF792uq0uE7GtRGsZd0zs=
X-IronPort-AV: E=Sophos;i="5.88,349,1635220800"; 
   d="scan'208";a="64044594"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=YfqTni3B5TxJrLGsfm8JtrjtnT/gv+HrrzfG9uO4bN04pJaO1a5tdrGeZO41eMWuAaXhzRJd11wOzvDiGT0iwEyv0jIpd0y7l/UEy1oS+Gf839/huqKmuvSGCEqEfISXoITOvLWt7AO8icm46t3GMzg+MWCd4fnAStezwlvTmQC9kR5UyJ+cWEwnU/MT8FYYCchD5enU17I4IHMhUWBZlFZMmHRcGVwB8zYclgMaWWmp+zvxC0RKr7B20rYZgXC+SR+UTsumTmQjvQxT8KH/PxBdksf7IwniOchtrc1cnf6wCRhXcf0vjKjo23jPMP2nHDVNoRstuSV8j6SNObejjA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=3KuWjwX3k3PvN++BhxGf/KpKmjdqGgmetGnkm6W1AME=;
 b=CIAsvP7/KxtPPM+1Ov6DssQyx1RNVSRBJtZADmdBl7LqNV2K2HPfNdBhDKLTYWuacQKxeE9EAuBtdhG7IEOShSnKXHqGr2p1WmntFb6TQtb9o2Q8ydeOOAJBBtNJMwlhgxDrIlUi1jEdCViYv0gRsIP3Vw6J+tK2PVQoSdlcJKhi9Ogqi7clJWchJOntcUFRQTE54GKyMVSYvciNe1t9zluAFyWgQih8v9noTWswo4MzS9KkDtl/md1FTQXtYfBTsGfQ4IzY86kHKKgigKCLLmIGbBJl1V5PJ0OnQnhGCIMG5Co7CaZO7YEo23kL3IJoKlgSKaD6aOHWlhyHog94JA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=3KuWjwX3k3PvN++BhxGf/KpKmjdqGgmetGnkm6W1AME=;
 b=Vj4EUsOkC+pU7J05rCOaf0HGGWOnOKRfnsLVbGEoE6iprAyNO6PYq0Y7AhC/cISTPAcsFoXZ0D0oogvOW9OzWQYT2uBN1VZzlTquFbWExDjQB8+i8IlpH1pniRdJDaDGnLTsrObwqKbW4kdimBDuH495LlTlamOgEDZeLDUVvG8=
Date: Mon, 7 Feb 2022 13:46:57 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: Jan Beulich <jbeulich@suse.com>, "julien@xen.org" <julien@xen.org>,
	"sstabellini@kernel.org" <sstabellini@kernel.org>, Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Artem Mygaiev <Artem_Mygaiev@epam.com>,
	"andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
	"george.dunlap@citrix.com" <george.dunlap@citrix.com>, "paul@xen.org"
	<paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>, Rahul Singh
	<rahul.singh@arm.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Message-ID: <YgEUwTxhnWVMGMJK@Air-de-Roger>
References: <c3a99712-cf7c-37da-aac1-f2ee00e6d53b@suse.com>
 <Yf0KcVD8W05A4fbB@Air-de-Roger>
 <1ed0e342-16cd-2f16-c05c-186667a22762@suse.com>
 <7e3562b5-fc67-f213-e872-f211450d9e2e@epam.com>
 <a8fc599c-f620-c4d1-2077-c57068f46a7f@suse.com>
 <deef8468-d607-e49e-f456-6a8013329ca1@epam.com>
 <Yf0k6aoKK5G3iad1@Air-de-Roger>
 <3ad10a99-c706-b95f-1419-2c0c7cf37d58@epam.com>
 <Yf0+3C9nF8+tewLw@Air-de-Roger>
 <c5fea3bb-834b-eeb7-d7a1-1ee609037a9f@epam.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <c5fea3bb-834b-eeb7-d7a1-1ee609037a9f@epam.com>
X-ClientProxiedBy: LO4P123CA0516.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:272::9) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 8850c97b-ef91-41c7-f7ce-08d9ea37f0cd
X-MS-TrafficTypeDiagnostic: BN8PR03MB4676:EE_
X-Microsoft-Antispam-PRVS: <BN8PR03MB46767A840046B7358E312B038F2C9@BN8PR03MB4676.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: dh5qAHumA8782pJKL2gM1cU6hGF3oXc8n1Sed3nnqfZyZEoYEHUNCj1ewccRQqhRSencvsMllaXQpvnB/jnajvKGVvkCKNx9WC9D3rdjzue69+FyuyvIQutIpku8X0ZApX1nq9NHorEf7ac/nh32A9Fl3SzpRnBIVmgH2g4hnf7j9atdl97ek1/7Xiz9Dx/4CEsxOuOIXEiUpgd4L24uSO7bMnSvf7teviKPb+nHZFZ4nNI9ycCs5asUQmYCipkK7mFap5ZtYIEgR6xEgw32AvpcMHB/CR8X+J0n3hIDYMka3srkydbhlF44gROOFx1VnogDsf8RXedyU3r/7gNsX6rxQe2ofmSGF3A07ZVWtJEnz4+4kJCFbfRYOpqrVhTKq8zSXiiBOMup/6V6HH1Vrcmaiy4okuuNG7FL74RCLMyIgAhTH+B0gLCEdHs4vcegt1plukAn2OCE/IFPN8U80YUJOUcGFLHhRT+n7PyaozZRUtflWP+g9h9INx7j6SekPpBRH90cX1JAbPiBPGrYt3vPanp/xdwlfbULZJwFyCrAocOdG4+7T/1S2V51YfYsHs/eN2i9T1JigDyb/oe6IzNgQCvPz3KrREthCe0DoYp4hVqqVS0bGd4Tl7XwEOu0vpPDTtO22qRgtOlzqZxatA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(66476007)(30864003)(7416002)(83380400001)(66556008)(5660300002)(66946007)(186003)(26005)(2906002)(38100700002)(85182001)(82960400001)(6486002)(6666004)(9686003)(6506007)(6512007)(6916009)(54906003)(33716001)(4326008)(316002)(86362001)(8676002)(8936002)(53546011)(508600001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T3Q1YmkxV2FQMFM5MU53L244eFhwSW40RFpzdHJIaFk5dktablJPVEVBT1I5?=
 =?utf-8?B?OUxxcUhRSHB1Mm9wbnJJM1orbGNxNlB2UzIrT0JyRFg1MHltc1VpZUFBKzRN?=
 =?utf-8?B?Q2pJYnphQjFNWXZMcklRcVlXQ0toZitwME5Wb3pXaHZpa0ZQaS9MYVNsUmk5?=
 =?utf-8?B?RzlWM1lLMnRlZURLWVlCd0RDQjJKQ0N0M0ZNdEFmcE8ybFFHeStVekRoWlpX?=
 =?utf-8?B?MkpoK2hwVU1XajJDSGhwaFV3RlhyZVAyV29lUzJaeHlDWmJyejVDVlVNRWlr?=
 =?utf-8?B?Zmc4NU5sNWN3TUkwanZBVkRUdDl3Q2hyY0dlT2lmQWY2dFg0Y0ZOTEhoNU1M?=
 =?utf-8?B?d0thUm1EN2NxczZZNCtHN3U5MWVwbjRmQWYxTFR4allzRjgxdHFTSmhxZC9w?=
 =?utf-8?B?eTJLZThMTk00TEFkQlVQTWN6RWhHaUpWVldMRi9FQThNVVNnYm9uMjd6YlM1?=
 =?utf-8?B?VThiaE8zQ3pSTTJLb2QwRDZjUi9HSVJma3doNElHUEgzNGEyN3JDS25JT01S?=
 =?utf-8?B?YjNianlkS2tUTkY3OVkxdHBvU0xhdHFrRGIvNXRWWG5FNXB5WWQ5U1ZNNThI?=
 =?utf-8?B?ZFhaOFZmNXM4SHRjMXN3Nkxodm5JN21UeTEzUlhNa1d1Wm5lMWhPVldPUktT?=
 =?utf-8?B?ZGdYeTVhdlFUbk4vcVFLRk5SMDJPTFhudEZuSHJzL1JaY3RnMTU4TXo1eFh3?=
 =?utf-8?B?UkcrWTcvVVdKTnFpQVY3Yi9QWmJmMysrS1Q0eElNaHRXWEFLdTVTd1VJaFFy?=
 =?utf-8?B?M2Mxc0Z1VXdzM085bWFwWDRjK1UyL3NTM1BUV2RVU0xYZVY2R3IzR2lvWTJl?=
 =?utf-8?B?cVZ1U3c4WEpwOVNCUWxwVk5NOEcrRVRUMktyb3llL3UzTXNkUWxjaGdQSHRB?=
 =?utf-8?B?TkhWVGdxUWpFSTNKenhCUXZPWnBpbjJBdlJpSHhVa3RxWFRXSGFWWE5VMUd6?=
 =?utf-8?B?dEVpTEQ2cytWVEJ3M1NOd3FIcGxOd3AycWJjVmtFb0lUZE9qcG90bEh4R1lz?=
 =?utf-8?B?S2tJc2pGRmk3Z3V0Ly84aFBHR2ZvSE04dTNqeUl6WlRmZ2FIWW0rQi9nZlJk?=
 =?utf-8?B?eStGVDlJUktKZlRtNFZJWVIrdStURjZGaUNBZlZhSlNIczJzT1prL0V4TWUr?=
 =?utf-8?B?NGZTVFdzSW50M09WaFozSWJNMGJ4VTVFMEdDbnpENHhOS2xWNEtJcDZFcnps?=
 =?utf-8?B?NFB6VGIrRVRHaVkvSFUwcXYyaWEvcDgxTCtwcmZnM2tuWFNmbDlCeGF6TXBj?=
 =?utf-8?B?bUUxYmE3elZSUWtOTnF6MkJ4N1AxRG41QmQyWVUreEZHRC9rVFpXQXlhcXZV?=
 =?utf-8?B?RzJiTU1tWHYrTGxIVHhFVmZnVUNydzA1MnE1Q2ZncXNuRFAvcC9sZUo4VkJW?=
 =?utf-8?B?cVFvdEY3KzlWejhqMDcxM1FKTTZvYnpPMHZPYlNiQ24xcjVSalY3TTg5K3pO?=
 =?utf-8?B?NDJMYkJZN1lDKzczdS82NVZQeUk4Y3Y0YWhXV0YrbURjWUpVT3pXZU15SnJU?=
 =?utf-8?B?U2ZSUVdUM2RORVBEdldCckZTaE84a29iVG1Yc3hLMDRBL0ExMFEybzJINmV2?=
 =?utf-8?B?Z2JCemFUNHllemlqdmJreldsSVVaM1JLZTRDbjEyelpuaG03MGs2R09Ud0kw?=
 =?utf-8?B?aVFYc3JSWEk2aUxaVGFobm04LzNad0ZWR3k4U09OSUJlOWtPMmh5ZUlPV09W?=
 =?utf-8?B?NDMwSXJnSHNmdEFROEFSaTFFRlFxZG1udUF0N0FOcnF0WU1kMURycjdlUjdH?=
 =?utf-8?B?c0Qzc2dEclFweG5SOU44NnkyTmpPQzRqamd5KzF5aEk2b2ZaQUFHaHNlOExp?=
 =?utf-8?B?SDQvRHlKa3hCQ0NlcW5uNjgycS9pMFpxb0EwcitvNUM0N0lQbk5aZ0ZqRWhn?=
 =?utf-8?B?Qk4rQUtDRFUzaWczdDkvcGtBdTQ2NlJIeDJpTlBMTWw5alFxdkw5b1l3cVNL?=
 =?utf-8?B?MEs3RHFSemhpNDNkWWVVaVMzL09rcTh4eE81V1VIbWt2TCt4N0JRQnRLWEdM?=
 =?utf-8?B?Zkxyb0o3c2Ewc0prVzFrU2dFc25rSU9YSHdHVlIvUDdKbFcrYUEwSU8zS20x?=
 =?utf-8?B?bTdkNUd5VHFTcEZLUkR3WHRQcDR4V0J3T3hIallhY0RFNXdGSnp1RDJGWCtG?=
 =?utf-8?B?TjA3UEJjMTFBL3VoQytqQ3F5bDluQ1MvWGpjUUxGSUhtYXA2RFdMelZMV0lu?=
 =?utf-8?Q?HZQGpOAdqif2dIO1n6m0y3k=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8850c97b-ef91-41c7-f7ce-08d9ea37f0cd
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2022 12:47:03.5809
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vaDmwg0uVQkNvFnibg4nw/qPXP775YP2rCXWLoD5DcJRJWZtT5hCcHQWfqxQ/dlKLtcl3WGE3kjVVANTmsdnpQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR03MB4676
X-OriginatorOrg: citrix.com

On Mon, Feb 07, 2022 at 11:08:39AM +0000, Oleksandr Andrushchenko wrote:
> Hello,
> 
> On 04.02.22 16:57, Roger Pau Monné wrote:
> > On Fri, Feb 04, 2022 at 02:43:07PM +0000, Oleksandr Andrushchenko wrote:
> >>
> >> On 04.02.22 15:06, Roger Pau Monné wrote:
> >>> On Fri, Feb 04, 2022 at 12:53:20PM +0000, Oleksandr Andrushchenko wrote:
> >>>> On 04.02.22 14:47, Jan Beulich wrote:
> >>>>> On 04.02.2022 13:37, Oleksandr Andrushchenko wrote:
> >>>>>> On 04.02.22 13:37, Jan Beulich wrote:
> >>>>>>> On 04.02.2022 12:13, Roger Pau Monné wrote:
> >>>>>>>> On Fri, Feb 04, 2022 at 11:49:18AM +0100, Jan Beulich wrote:
> >>>>>>>>> On 04.02.2022 11:12, Oleksandr Andrushchenko wrote:
> >>>>>>>>>> On 04.02.22 11:15, Jan Beulich wrote:
> >>>>>>>>>>> On 04.02.2022 09:58, Oleksandr Andrushchenko wrote:
> >>>>>>>>>>>> On 04.02.22 09:52, Jan Beulich wrote:
> >>>>>>>>>>>>> On 04.02.2022 07:34, Oleksandr Andrushchenko wrote:
> >>>>>>>>>>>>>> @@ -285,6 +286,12 @@ static int modify_bars(const struct pci_dev *pdev, uint16_t cmd, bool rom_only)
> >>>>>>>>>>>>>>                        continue;
> >>>>>>>>>>>>>>                }
> >>>>>>>>>>>>>>        
> >>>>>>>>>>>>>> +        spin_lock(&tmp->vpci_lock);
> >>>>>>>>>>>>>> +        if ( !tmp->vpci )
> >>>>>>>>>>>>>> +        {
> >>>>>>>>>>>>>> +            spin_unlock(&tmp->vpci_lock);
> >>>>>>>>>>>>>> +            continue;
> >>>>>>>>>>>>>> +        }
> >>>>>>>>>>>>>>                for ( i = 0; i < ARRAY_SIZE(tmp->vpci->header.bars); i++ )
> >>>>>>>>>>>>>>                {
> >>>>>>>>>>>>>>                    const struct vpci_bar *bar = &tmp->vpci->header.bars[i];
> >>>>>>>>>>>>>> @@ -303,12 +310,14 @@ static int modify_bars(const struct pci_dev *pdev, uint16_t cmd, bool rom_only)
> >>>>>>>>>>>>>>                    rc = rangeset_remove_range(mem, start, end);
> >>>>>>>>>>>>>>                    if ( rc )
> >>>>>>>>>>>>>>                    {
> >>>>>>>>>>>>>> +                spin_unlock(&tmp->vpci_lock);
> >>>>>>>>>>>>>>                        printk(XENLOG_G_WARNING "Failed to remove [%lx, %lx]: %d\n",
> >>>>>>>>>>>>>>                               start, end, rc);
> >>>>>>>>>>>>>>                        rangeset_destroy(mem);
> >>>>>>>>>>>>>>                        return rc;
> >>>>>>>>>>>>>>                    }
> >>>>>>>>>>>>>>                }
> >>>>>>>>>>>>>> +        spin_unlock(&tmp->vpci_lock);
> >>>>>>>>>>>>>>            }
> >>>>>>>>>>>>> At the first glance this simply looks like another unjustified (in the
> >>>>>>>>>>>>> description) change, as you're not converting anything here but you
> >>>>>>>>>>>>> actually add locking (and I realize this was there before, so I'm sorry
> >>>>>>>>>>>>> for not pointing this out earlier).
> >>>>>>>>>>>> Well, I thought that the description already has "...the lock can be
> >>>>>>>>>>>> used (and in a few cases is used right away) to check whether vpci
> >>>>>>>>>>>> is present" and this is enough for such uses as here.
> >>>>>>>>>>>>>        But then I wonder whether you
> >>>>>>>>>>>>> actually tested this, since I can't help getting the impression that
> >>>>>>>>>>>>> you're introducing a live-lock: The function is called from cmd_write()
> >>>>>>>>>>>>> and rom_write(), which in turn are called out of vpci_write(). Yet that
> >>>>>>>>>>>>> function already holds the lock, and the lock is not (currently)
> >>>>>>>>>>>>> recursive. (For the 3rd caller of the function - init_bars() - otoh
> >>>>>>>>>>>>> the locking looks to be entirely unnecessary.)
> >>>>>>>>>>>> Well, you are correct: if tmp != pdev then it is correct to acquire
> >>>>>>>>>>>> the lock. But if tmp == pdev and rom_only == true
> >>>>>>>>>>>> then we'll deadlock.
> >>>>>>>>>>>>
> >>>>>>>>>>>> It seems we need to have the locking conditional, e.g. only lock
> >>>>>>>>>>>> if tmp != pdev
> >>>>>>>>>>> Which will address the live-lock, but introduce ABBA deadlock potential
> >>>>>>>>>>> between the two locks.
> >>>>>>>>>> I am not sure I can suggest a better solution here
> >>>>>>>>>> @Roger, @Jan, could you please help here?
> >>>>>>>>> Well, first of all I'd like to mention that while it may have been okay to
> >>>>>>>>> not hold pcidevs_lock here for Dom0, it surely needs acquiring when dealing
> >>>>>>>>> with DomU-s' lists of PCI devices. The requirement really applies to the
> >>>>>>>>> other use of for_each_pdev() as well (in vpci_dump_msi()), except that
> >>>>>>>>> there it probably wants to be a try-lock.
> >>>>>>>>>
> >>>>>>>>> Next I'd like to point out that here we have the still pending issue of
> >>>>>>>>> how to deal with hidden devices, which Dom0 can access. See my RFC patch
> >>>>>>>>> "vPCI: account for hidden devices in modify_bars()". Whatever the solution
> >>>>>>>>> here, I think it wants to at least account for the extra need there.
> >>>>>>>> Yes, sorry, I should take care of that.
> >>>>>>>>
> >>>>>>>>> Now it is quite clear that pcidevs_lock isn't going to help with avoiding
> >>>>>>>>> the deadlock, as it's imo not an option at all to acquire that lock
> >>>>>>>>> everywhere else you access ->vpci (or else the vpci lock itself would be
> >>>>>>>>> pointless). But a per-domain auxiliary r/w lock may help: Other paths
> >>>>>>>>> would acquire it in read mode, and here you'd acquire it in write mode (in
> >>>>>>>>> the former case around the vpci lock, while in the latter case there may
> >>>>>>>>> then not be any need to acquire the individual vpci locks at all). FTAOD:
> >>>>>>>>> I haven't fully thought through all implications (and hence whether this is
> >>>>>>>>> viable in the first place); I expect you will, documenting what you've
> >>>>>>>>> found in the resulting patch description. Of course the double lock
> >>>>>>>>> acquire/release would then likely want hiding in helper functions.
> >>>>>>>> I've been also thinking about this, and whether it's really worth to
> >>>>>>>> have a per-device lock rather than a per-domain one that protects all
> >>>>>>>> vpci regions of the devices assigned to the domain.
> >>>>>>>>
> >>>>>>>> The OS is likely to serialize accesses to the PCI config space anyway,
> >>>>>>>> and the only place I could see a benefit of having per-device locks is
> >>>>>>>> in the handling of MSI-X tables, as the handling of the mask bit is
> >>>>>>>> likely very performance sensitive, so adding a per-domain lock there
> >>>>>>>> could be a bottleneck.
> >>>>>>> Hmm, with method 1 accesses serializing globally is basically
> >>>>>>> unavoidable, but with MMCFG I see no reason why OSes may not (move
> >>>>>>> to) permit(ting) parallel accesses, with serialization perhaps done
> >>>>>>> only at device level. See our own pci_config_lock, which applies to
> >>>>>>> only method 1 accesses; we don't look to be serializing MMCFG
> >>>>>>> accesses at all.
> >>>>>>>
> >>>>>>>> We could alternatively do a per-domain rwlock for vpci and special case
> >>>>>>>> the MSI-X area to also have a per-device specific lock. At which point
> >>>>>>>> it becomes fairly similar to what you propose.
> >>>>>> @Jan, @Roger
> >>>>>>
> >>>>>> 1. d->vpci_lock - rwlock <- this protects vpci
> >>>>>> 2. pdev->vpci->msix_tbl_lock - rwlock <- this protects MSI-X tables
> >>>>>> or should it better be pdev->msix_tbl_lock as MSI-X tables don't
> >>>>>> really depend on vPCI?
> >>>>> If so, perhaps indeed better the latter. But as said in reply to Roger,
> >>>>> I'm not convinced (yet) that doing away with the per-device lock is a
> >>>>> good move. As said there - we're ourselves doing fully parallel MMCFG
> >>>>> accesses, so OSes ought to be fine to do so, too.
> >>>> But with pdev->vpci_lock we face ABBA...
> >>> I think it would be easier to start with a per-domain rwlock that
> >>> guarantees pdev->vpci cannot be removed under our feet. This would be
> >>> taken in read mode in vpci_{read,write} and in write mode when
> >>> removing a device from a domain.
> >>>
> >>> Then there are also other issues regarding vPCI locking that need to
> >>> be fixed, but that lock would likely be a start.
> >> Or let's see the problem at a different angle: this is the only place
> >> which breaks the use of pdev->vpci_lock. Because all other places
> >> do not try to acquire the lock of any two devices at a time.
> >> So, what if we re-work the offending piece of code instead?
> >> That way we do not break parallel access and have the lock per-device
> >> which might also be a plus.
> >>
> >> By re-work I mean, that instead of reading already mapped regions
> >> from tmp we can employ a d->pci_mapped_regions range set which
> >> will hold all the already mapped ranges. And when it is needed to access
> >> that range set we use pcidevs_lock which seems to be rare.
> >> So, modify_bars will rely on pdev->vpci_lock + pcidevs_lock and
> >> ABBA won't be possible at all.
> > Sadly that won't replace the usage of the loop in modify_bars. This is
> > not (exclusively) done in order to prevent mapping the same region
> > multiple times, but rather to prevent unmapping of regions as long as
> > there's an enabled BAR that's using it.
> >
> > If you wanted to use something like d->pci_mapped_regions it would
> > have to keep reference counts to regions, in order to know when a
> > mapping is no longer required by any BAR on the system with memory
> > decoding enabled.
> I missed this path, thank you
> 
> I tried to analyze the locking in pci/vpci.
> 
> First of all some context to refresh the target we want:
> the rationale behind moving pdev->vpci->lock outside
> is to be able dynamically create and destroy pdev->vpci.
> So, for that reason lock needs to be moved outside of the pdev->vpci.
> 
> Some of the callers of the vPCI code and locking used:
> 
> ======================================
> vpci_mmio_read/vpci_mmcfg_read
> ======================================
>    - vpci_ecam_read
>    - vpci_read
>     !!!!!!!! pdev is acquired, then pdev->vpci_lock is used !!!!!!!!
>     - msix:
>      - control_read
>     - header:
>      - guest_bar_read
>     - msi:
>      - control_read
>      - address_read/address_hi_read
>      - data_read
>      - mask_read
> 
> ======================================
> vpci_mmio_write/vpci_mmcfg_write
> ======================================
>    - vpci_ecam_write
>    - vpci_write
>     !!!!!!!! pdev is acquired, then pdev->vpci_lock is used !!!!!!!!
>     - msix:
>      - control_write
>     - header:
>      - bar_write/guest_bar_write
>      - cmd_write/guest_cmd_write
>      - rom_write
>       - all write handlers may call modify_bars
>        modify_bars
>     - msi:
>      - control_write
>      - address_write/address_hi_write
>      - data_write
>      - mask_write
> 
> ======================================
> pci_add_device: locked with pcidevs_lock
> ======================================
>    - vpci_add_handlers
>     ++++++++ pdev->vpci_lock is used ++++++++
> 
> ======================================
> pci_remove_device: locked with pcidevs_lock
> ======================================
> - vpci_remove_device
>    ++++++++ pdev->vpci_lock is used ++++++++
> - pci_cleanup_msi
> - free_pdev
> 
> ======================================
> XEN_DOMCTL_assign_device: locked with pcidevs_lock
> ======================================
> - assign_device
>   - vpci_deassign_device
>   - pdev_msix_assign
>   - vpci_assign_device
>    - vpci_add_handlers
>      ++++++++ pdev->vpci_lock is used ++++++++
> 
> ======================================
> XEN_DOMCTL_deassign_device: locked with pcidevs_lock
> ======================================
> - deassign_device
>   - vpci_deassign_device
>     ++++++++ pdev->vpci_lock is used ++++++++
>    - vpci_remove_device
> 
> 
> ======================================
> modify_bars is a special case: this is the only function which tries to lock
> two pci_dev devices: it is done to check for overlaps with other BARs which may have been
> already mapped or unmapped.
> 
> So, this is the only case which may deadlock because of pci_dev->vpci_lock.
> ======================================
> 
> Bottom line:
> ======================================
> 
> 1. vpci_{read|write} are not protected with pcidevs_lock and can run in
> parallel with pci_remove_device which can remove pdev after vpci_{read|write}
> acquired the pdev pointer. This may lead to a fail due to pdev dereference.
> 
> So, to protect pdev dereference vpci_{read|write} must also use pdevs_lock.

We would like to take the pcidevs_lock only while fetching the device
(ie: pci_get_pdev_by_domain), afterwards it should be fine to lock the
device using a vpci specific lock so calls to vpci_{read,write} can be
partially concurrent across multiple domains.

In fact I think Jan had already pointed out that the pci lock would
need taking while searching for the device in vpci_{read,write}.

It seems to me that if you implement option 3 below taking the
per-domain rwlock in read mode in vpci_{read|write} will already
protect you from the device being removed if the same per-domain lock
is taken in write mode in vpci_remove_device.

> 2. The only offending place which is in the way of pci_dev->vpci_lock is
> modify_bars. If it can be re-worked to track already mapped and unmapped
> regions then we can avoid having a possible deadlock and can use
> pci_dev->vpci_lock (rangesets won't help here as we also need refcounting be
> implemented).

I think a refcounting based solution will be very complex to
implement. I'm however happy to be proven wrong.

> If pcidevs_lock is used for vpci_{read|write} then no deadlock is possible,
> but modify_bars code must be re-worked not to lock itself (pdev->vpci_lock and
> tmp->vpci_lock when pdev == tmp, this is minor).

Taking the pcidevs lock (a global lock) is out of the picture IMO, as
it's going to serialize all calls of vpci_{read|write}, and would
create too much contention on the pcidevs lock.

> 3. We may think about a per-domain rwlock and pdev->vpci_lock, so this solves
> modify_bars's two pdevs access. But this doesn't solve possible pdev
> de-reference in vpci_{read|write} vs pci_remove_device.

pci_remove device will call vpci_remove_device, so as long as
vpci_remove_device taken the per-domain lock in write (exclusive) mode
it should be fine.

> @Roger, @Jan, I would like to hear what do you think about the above analysis
> and how can we proceed with locking re-work?

I think the per-domain rwlock seems like a good option. I would do
that as a pre-patch.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Feb 07 12:48:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 12:48:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266845.460556 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH3Rg-0002ej-7l; Mon, 07 Feb 2022 12:48:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266845.460556; Mon, 07 Feb 2022 12:48:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH3Rg-0002ec-3w; Mon, 07 Feb 2022 12:48:40 +0000
Received: by outflank-mailman (input) for mailman id 266845;
 Mon, 07 Feb 2022 12:48:38 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=hYSm=SW=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nH3Re-0002eU-R7
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 12:48:38 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 43c18c5b-8814-11ec-8eb8-a37418f5ba1a;
 Mon, 07 Feb 2022 13:48:37 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 43c18c5b-8814-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644238117;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=fzA7pERzn3oX+a6qUMCOOOx7IB5bl2eywGcGy+CJuPU=;
  b=VyHRN9npkPBsBhHlcCffg+Ea0SXx+t4M7U+Ct9pVuGCHwlHTs9U4dWA2
   /JEZTgHL9EhpS87Qg938OnaMuxKqZKXuBjJOWKjbBYHLMFFxT4JdnXJGB
   84SQoXIkh3l11T8gz/o1vLHKiRQ9m+KD4hVXaYjEc98PRXxrVb9FB9lkt
   U=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: hAcr5ycEG9K7NYtsP33Jd+uio//h5vNzVPe5nJMshX1QOnKo/4Mi3sZBsISlO73sQTGp8BaW+K
 ryUWwZV8gFkSl0bbirMCb3pFVn+mbm8GGinh7ETT2BZWk18U8hVL34hK58P1mbTn1SpLWpZgEg
 C0Tf4mJM3W+LvKNip1ET5mPAQAClAH3arAyQSvq1XDDP4Qcc+4nHp8bG8+3b1FSmb1McYsZ2oc
 3l6Sact8Ko1n4Y0Jpll8D4N56/7hmaYniW55YsmjH01eqeW0rrM1tgeZ6T7hjorMvq781+xTTj
 2YAOrWfnhAZPaSzHvGMUJysr
X-SBRS: 5.1
X-MesageID: 63550260
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:hNMxvK86cfJjY6LE2E6KDrUDUnmTJUtcMsCJ2f8bNWPcYEJGY0x3n
 DYWDzqGbquDa2qjetp0Ydu/oU0A7cPVmN43HlE+qig8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhFWeIdA970Ug5w7Rh3dYx6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPg25
 vQRkqXsTzskJ4DRw9RECghgOgFhaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguw5K8bmJsUHs2xIxjDFF/c2B5vERs0m4PcGh2pt3poQRZ4yY
 eI2RCVIVwTgZiQfJ0xQApVkt8y3rSLWJmgwRFW9+vNsvjm7IBZK+KjgNp/Zd8KHQe1Rn12Ev
 STW8mLhGBYYOdeDjz2f/RqEmevnjS79HoUIG9WQ9PRnnVmSzWw7EwANWB2wpvzRt6Klc4sBc
 QpOoHNo9PVsshzwJjXgY/GmiDmqn0I7YoZWL+AjxRzW+vON8j6wJndRG1atd+canMMxQDUr0
 HqAkNXoGSFjvdWpdJ6NyluHhWjsYHZIdAfucQdBFFJYuIe7/OnfmzqSFo4LLUKjsjHi9dgcK
 RiupTN2ubgchNVjO06TrQGe2GLESnQko2cICuTrsoCNs1kRiG2NPdXABb3nARFodtfxc7V5l
 CJY8/VyFchXZX13qASDQf8WAJai7OufPTvXjDZHRsd9q238oif9LNoJu1mSwXuF1e5eKFfUj
 LL741sNtPe/wlP2BUOIX25BI5tzlvWxfTgUfvvVcsBPcvBMmPyvp0lTibqr9zm1yiAEyPhnU
 b/CKJrEJStKWMxPkWvtL89AgOBD7n5lnwv7G8ukpylLJJLDPRZ5v59eawDQBg34hYvZyDjoH
 yF3bZfTm04BAbGhPkE6M+c7dDg3EJTyPrivw+R/fe+fOAt2XmYnDv7a27Q6fIJ52a9Sk4/1E
 ruVASe0EXLz2i/KLxukcHdmZO+9VJpztytjbyctIUypyz4oZoP2tPUTcJ4+fL8G8u1/zKErE
 6lZKpvYWvkfGC7a/zk9bIXmqNAwfhqcmg/TbTGuZyIyfsA8SlWRqMPkZAbm6AIHEjGz6Zklu
 7Sl2w6CGcgDSg1uAdz4cvWqy1/t73ERlPgrBxnDI8VJeVWq+49vcnSjgvgyKsAKCBPC2jrFi
 FrGXUZG/bHA+tZn/sPIiKaIq5aSP9F/RkcKTXPG6buWNDXB+jbxy4F3T+vVLyvWU3n5+fv+a
 LwNne38KvAOgH1Dr5F4T+Rw1as76tbi++1awwBjECmZZlinEOo9cHyP3M0JvaxR3L5J/wCxX
 xvXqNVdPLyIPuLjEUIQe1V5PrjSi6lMl2mA9+kxLWX7+DRzreiOXkhlNhWRjDBQceluO4Q/z
 OZ94MMb5mRTUPbx3gpqWsyMy1mxEw==
IronPort-HdrOrdr: A9a23:e7uGEaMmYM2pa8BcT1n155DYdb4zR+YMi2TDiHofdfUFSKClfp
 6V8cjztSWUtN4QMEtQ/uxoHJPwO080kqQFnLX5XI3SJzUO3VHHEGgM1/qB/9SNIVyaygcZ79
 YdT0EcMqyAMbEZt7eC3ODQKb9Jq7PmgcOVbKXlvg9QpGlRGt9dBmxCe2Cm+yNNNW177c1TLu
 vi2iMLnUvqRV0nKuCAQlUVVenKoNPG0LrgfB49HhYirC2Dlymh5rLWGwWRmk52aUID/Z4StU
 z+1yDp7KSqtP+2jjfaym/o9pxT3P/s0MFKCsCggtUcbh/slgGrToJ8XKDqhkF+nMifrHIR1P
 XcqRYpOMp+r1vXY2GOuBPonzLt1T4/gkWSv2OwsD/Gm4jUVTg6A81OicZyaR3C8Xctu9l6ze
 Ziw3+Zn4A/N2KPoA3No/zzEz16nEu9pnQv1cQJiWZEbIcYYLhN6aQC4UJuFosaFi6S0vFpLA
 BXNrCd2B9qSyLYU5iA1VMfguBEH05DUitue3Jy+/B8iFNt7TVEJ0hx/r1pop5PzuN4d3B+3Z
 W2Dk1frsA7ciYnV9MMOA4/e7rENoXse2OEDIvAGyWuKEk4U0i93qIfpo9Fo92XRA==
X-IronPort-AV: E=Sophos;i="5.88,349,1635220800"; 
   d="scan'208";a="63550260"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gn+PlzccHCN8y+ZsNGGUB1RShozU4sqjsz0cZjqScWGbf3bHGJEOfTS4XnbO03fS29OktKJLWAfpAqZA9PShq+lH9G8FfNJBC88VOFqIBnfWawFz2eNALP/65xWFAgzzXw/0WyP9Wqq7DH7QMAk2zA6Rg2vlNI++7+rDJGYPdwB8IJHd86At1SfJn/UrcfXspktfapcmPXG2Sd2QX3v+4CufyiCZjeKVG1VjaIkNWJ7FuDtGxtuK4wBe61+kBJ54RxVJnMUIpep0ktoJx5vD5ZznGe3wNFZNCqvlCSbRULQ4nBz9cUnFpZfxt5mrdodElA2lI7pExnZz8DUt0hhAUA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=3zmQxJViorRrssZzWRe1BalHYhj3cXuzLAVaMQND/0s=;
 b=Vdno5hXIo0lqMrp7V56KluTV7hY/+0lsI/BkB3pjGTqXGX9hhioG1rYw7Nr+BfLOTlIaz4A3rQuW4Z0G/mmZk4sg3W81iq2YVL1hgbJ3nTALw/a5nk2CcoCD4+uMACOVQnpr6dyvVTeobLu56+W55TYH+58HDo8CsY+Jq5lBEuvZMTmijGWkSG5ojWScNSgXoM0JA3kODsD2WRuEft82ce8K37PDmunvxIszg6hYoqVQ94uNZr/G5TR2XYp1Gi38K7XTRuXL36gBkb0DrcCCA+bDKv3O7284vfoat49PztdYXv6jpZT+uQzYrU1c22GW7fz/h0MB+3x4P23KYdJCgw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=3zmQxJViorRrssZzWRe1BalHYhj3cXuzLAVaMQND/0s=;
 b=E+Khbm7GdWU64QPDINxKS7QTsua+cexx1TwgO48hUbqwfBG8c37kZMs7gIri4GvHk2nEpwycf9ubSpZDjc6ZR7P69k9uZMBUoG/4roDD4yybSmgPyjypjvOAUDnGBqdPD7LLmGnAVc+ZMzQrtcyf4C0w/c1YcEpWYF8NKy9/PpA=
Date: Mon, 7 Feb 2022 13:48:21 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2] dom0/pvh: fix processing softirqs during memory map
 population
Message-ID: <YgEVFeW5SDtvavyK@Air-de-Roger>
References: <20220207112008.51085-1-roger.pau@citrix.com>
 <66b9fd95-bac4-55f7-2f3e-701f8444f37f@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <66b9fd95-bac4-55f7-2f3e-701f8444f37f@suse.com>
X-ClientProxiedBy: LO4P123CA0037.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:152::6) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ec999278-cbde-4f83-8ece-08d9ea3821f4
X-MS-TrafficTypeDiagnostic: BYAPR03MB4037:EE_
X-Microsoft-Antispam-PRVS: <BYAPR03MB40374E83D3A687F551A0A4C48F2C9@BYAPR03MB4037.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6108;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: F8CHPMIPo3TbbZLm0u33jRzgnRX9viYjIeEUtOjo7O5es9QmDgi5BScisQrppS+O6iEHGAWxdzC4Et2iXbplKgiJTVgTUQlVL9eB84bun1gDlWoh3l9HBbarz7cDls+VngScP8Sy9wEoC0oO2HSGmAhUGG8Z2XN5w82Ha26qFKG8uT6By8nNw8QmJ5NAw9MLhlk5lU5AW8e+pac5e4pszAOIffjePeiH9XF1zSUw5ITsJuPsBoA7rcnLFlSM5Rpkh6zed8lOlFlBHJrfoduGy/+FrnWLvWdj+W5CYGwhSj9LADojgomBH+ZrLQYAclAMfYFqa07Ltbgo597txLkniMid/pmU1pJz9rASkrbqPrKgm8bhLlyLAiX6zGbVlN9dEyVy2agvXBWFoEu7WDqKnvqypSmEnUawugmKw0upS71C7+Qz8D+UPOOMOWXoTvsLfonhXx6jlYZa6XSh+JBuYl/0NiMB38qPXuK0EdeAwQCFCVWqFMKoAF7x7rloyVvWv0FK4nzd72Vph+crz0OrGbpdhbP5HCOThUQopCyWBwdEbacafWoaHq/6vKolwZPGjPAJ3M4TWq2gOdaAQ3g1RwVAB3S5s67upeoFAn9yxkd65z7s6fB7Llotq3/hHjg/Vma2gTkMwjuCwJhTZZtPaA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(9686003)(508600001)(186003)(26005)(85182001)(6512007)(6916009)(316002)(6486002)(2906002)(5660300002)(4744005)(33716001)(38100700002)(53546011)(54906003)(8936002)(66946007)(8676002)(66476007)(86362001)(66556008)(6666004)(82960400001)(6506007)(4326008);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b0FqRE1YdENoaFNMZGhoTUhwNEw1d1o3MlFUeGV2cHIwdTM2cWFheUdMeEg2?=
 =?utf-8?B?SnBpK1JxajVRdUltR1U0a0tQa0F2MDlWclFIK1BuN3dnbDdiVmF1TmVBK2ww?=
 =?utf-8?B?U3VOd1J4cFU5Y0x6YmtkckxsNE9oLy9YK0dFTWg1L0ZFOWcxUk5SZU02VnMv?=
 =?utf-8?B?R1E1WStuQkVieUI0M0RXUHpUS3k1MTVUT2h2MzJZcS91eGg5OXJCWU5IWWRn?=
 =?utf-8?B?QzNHTWVnaUJraDFMZHM4d2QyeFA1REtmN21yS1c0cVdvN3E4WUM0akZkMFhZ?=
 =?utf-8?B?UnljRW84WVh1RkJBcHp0dGRTTzNJU2tKOVpvSXRvazFJaHQ3djlaU2xzcnJG?=
 =?utf-8?B?UVMyeEJJaDMyeGJUNjVOZDVYdEcwbzRHU3l3NTNqbXRIeXdvTXpjdUFPb01T?=
 =?utf-8?B?b2xXWUFSNHlQdmdNWU5CMG5QZ1FZdW93WEJVS2MxQnMzeUh4SWR1OGFwY3NL?=
 =?utf-8?B?NndIQmI3emNIaDY0T0hEZmVvRnRyRUJESWM5VmtENElEWlVSKzFTSEhKeDRY?=
 =?utf-8?B?bTJva05Ka3Q1RVZzWWhnMnpYQWlTcHRsd3lHdkdoSFhNK1ByMGErYzZ3bys1?=
 =?utf-8?B?RE5PVndnNmx2TjQxekw4aWgvcnlFMEZDTnVrcHgwMGhJZGJNRWc4bkN0Ri9K?=
 =?utf-8?B?MmVBbXNNYUs2TTRqeEt3c0tpWC9NTnI0S1d1MkVKNWRaeWh1Q2FwRnhZTGZP?=
 =?utf-8?B?R0dhTVI2cDNmZkJNNmp3V2k4T3p2ejlNQjZGTmlBWkVxUUZnbWNqTnZUc0NC?=
 =?utf-8?B?eVJnWHV2TGxxTDhubW9TNTBkUldNMFJ4TEU4QmFjTVZQZkdMci9wL0NLRFF0?=
 =?utf-8?B?eURZcXFwOWNkamxXcnFlbEdieXQ1THRqMkhISGhGMFJiTDlveDFPYVFRaG53?=
 =?utf-8?B?WEdua1JHcFN0azVqZ3ZteU1JSTl0Z2xVd1k5Ykdqcnh5SEhOa2VpaUtTRkFx?=
 =?utf-8?B?S1hIdVVBYmFnMzFUU3B2UEJIQUh2MlV2ZFNkcmJ4dUVoSDZhUmNTY1NGZWZ1?=
 =?utf-8?B?NnpJZmR0R01oWkpLbTdIUnYyR1dQTXd1M1ZVQW1uUEUxUmlINFNiQStLdVo5?=
 =?utf-8?B?eERaTkZ1ZFAyOTBkS1FSaUtEZGN4UHZnM2l0Rm9JUHpGbVRMcTRpdUNmSTA4?=
 =?utf-8?B?U1pRcHJ0T05TLy9VMVVOK1ZpaTAxQW01bGViQUcva2pSbDN0L0JSWUVuRktJ?=
 =?utf-8?B?cWVrb0FCdTA1OHEvbzV5b3lJdHBvc3dINjUwTTNSdThLbmZNU0UvQStWZ3M5?=
 =?utf-8?B?OS9Id1VIY3hxSGQrZnNMa3h6dDk1MVhIVWVrM0dhRW5JOCtzRVpNd21sSWc2?=
 =?utf-8?B?VWp0MVcrU2U2YWlVeVhFcUdmMWg0TmJVWG5Oc3lrUnUvdVo4bzZHYXhDWEVC?=
 =?utf-8?B?VjEzTXhTWnlHeHJnUklBYkxmdGljWVFwaTNkamJJQ0c0M3NyWSt2M3FiV1VS?=
 =?utf-8?B?dlhoSXhkZmxESXMyNzZ2R1VtcnhkUWFLZVhGcWFyaFBkQU1nVHNnbERBbmRw?=
 =?utf-8?B?SDlZbnFZenZXOVpSc1Q2S2xHOE1KblpKZVF3c2lMekE2M01TSi9HS01HTFlW?=
 =?utf-8?B?L1dRRENsa1BweXJTdjlBcmlTemNzL3N1RzMyNGlYU1h5ODdTeFV3NEF1RERR?=
 =?utf-8?B?d0hSdDB4bDYvWUZ3UWlLVnNtdk9VSER6OGVsTHRXOXZJVU93ZUdnZm13Yktl?=
 =?utf-8?B?Vm9mZENNSURtanZQc2FUWldZS2xUTFVVMjBwQWo1L3RDTGMwdVN5Vzc2R20x?=
 =?utf-8?B?RlB3b25DYnI4WFUvaTF3dGtsRTRRblVtaHp2aFhITUlPTWJpcy9rdExYT0kv?=
 =?utf-8?B?bFJhY25MckJ2TUhRV1BVMFYxQUVnbnE5cHJOVUp3c2JvSFkyTHRqZnRhemZ2?=
 =?utf-8?B?dTNHQlFzekpkOVdSRnYyenE3cDdwNndzcXpvQnRaci9Ia2x6b2Fub09ocjUz?=
 =?utf-8?B?N0pVd29HRklrcXFFQjN0cDhiaXFOVVZCUTB0NllEOGc1WVNxdG80YngxbGdo?=
 =?utf-8?B?UXdvQWZDWjBrbWE3ZHRJdkZmbHhsMWZ5Uk02T3hkQmlMWUYzWVVEL1NwMGNT?=
 =?utf-8?B?ODNidzlidDArc2R5ZkRiSitYbE85Sm9EdU95RUZnczlTVDY1M1Q1U3hKUUdp?=
 =?utf-8?B?NEFxb1IwRU1RLzBlZVF4VzhmcWltcDZZaTd1c014S1lBMkk1bEFxUnMrTGYy?=
 =?utf-8?Q?qK3Hzj/pEpQRrqryd1wcMOQ=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ec999278-cbde-4f83-8ece-08d9ea3821f4
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2022 12:48:25.9004
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jrbJkzAN3I0v7LSPfMHkCGgWN2aVOvOxP6JJoquHqAd0FoiXGyg+v/pSvAnmOS2VsPH57eDgpfURCUpKpbUSNA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4037
X-OriginatorOrg: citrix.com

On Mon, Feb 07, 2022 at 01:41:38PM +0100, Jan Beulich wrote:
> On 07.02.2022 12:20, Roger Pau Monne wrote:
> > Make sure softirqs are processed after every successful call to
> > guest_physmap_add_page. Even if only a single page is to be added,
> > it's unknown whether the p2m or the IOMMU will require splitting the
> > provided page into smaller ones, and thus in case of having to break
> > a 1G page into 4K entries the amount of time taken by a single of
> > those additions will be non-trivial. Stay on the safe side an check
> > for pending softirqs on ever successful loop iteration.
> > 
> > Fixes: 5427134eae ('x86: populate PVHv2 Dom0 physical memory map')
> > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> 
> Reviewed-by: Jan Beulich <jbeulich@suse.com>
> 
> Nit: I guess it's "and" and "every" in the last sentence. I'd be
> happy to adjust while committing.

Yes please, if you are happy to adjust on commit.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Feb 07 12:48:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 12:48:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266848.460567 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH3Rx-00034g-GJ; Mon, 07 Feb 2022 12:48:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266848.460567; Mon, 07 Feb 2022 12:48:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH3Rx-00034X-Bm; Mon, 07 Feb 2022 12:48:57 +0000
Received: by outflank-mailman (input) for mailman id 266848;
 Mon, 07 Feb 2022 12:48:55 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=ddl1=SW=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nH3Rv-00032i-S7
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 12:48:55 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 492a5f0d-8814-11ec-8f75-fffcc8bd4f1a;
 Mon, 07 Feb 2022 13:48:45 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 203C71F37E;
 Mon,  7 Feb 2022 12:48:53 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id DDE7513BF5;
 Mon,  7 Feb 2022 12:48:52 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id UTjWNDQVAWJEDQAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 07 Feb 2022 12:48:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 492a5f0d-8814-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1644238133; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=T+yLJ1HC6XKwwdt1xrfZ5TMCElmKEFqXJba0PRNdDhY=;
	b=sbEX48MYhQz6ruqrv7fiU/UFyryCAi9f/R5cReDzKrT92zClqKGiu/gvwSZZkb09MbO9CQ
	/jDc5LlBSzHxdyMkHj9Oh6t4ZjF8riE12+3UogdRseQUeubH9olSJfJeGk9JC7+rY69UTM
	gnfL9zWRLURP3YY8gYdp3nyfcwIN0fI=
Message-ID: <cc4bfd5a-d574-7950-5638-ddac85ffe650@suse.com>
Date: Mon, 7 Feb 2022 13:48:52 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Subject: Re: [PATCH] xen/public: partially revert commit 7c7f7e8fba01
Content-Language: en-US
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220207103613.32260-1-jgross@suse.com>
 <c2c185cb-2368-cd61-df72-7792b075746e@suse.com>
 <9bba716a-8ea3-a104-65d4-28d62f69f22b@suse.com>
 <11b3a2be-0ca9-6464-e9a3-392f7495793e@suse.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <11b3a2be-0ca9-6464-e9a3-392f7495793e@suse.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------CAE4S9venc9Dn8tyZe5JsY2J"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------CAE4S9venc9Dn8tyZe5JsY2J
Content-Type: multipart/mixed; boundary="------------OAAhB8NlPwxY2Eqoyt80ZwXi";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
Message-ID: <cc4bfd5a-d574-7950-5638-ddac85ffe650@suse.com>
Subject: Re: [PATCH] xen/public: partially revert commit 7c7f7e8fba01
References: <20220207103613.32260-1-jgross@suse.com>
 <c2c185cb-2368-cd61-df72-7792b075746e@suse.com>
 <9bba716a-8ea3-a104-65d4-28d62f69f22b@suse.com>
 <11b3a2be-0ca9-6464-e9a3-392f7495793e@suse.com>
In-Reply-To: <11b3a2be-0ca9-6464-e9a3-392f7495793e@suse.com>

--------------OAAhB8NlPwxY2Eqoyt80ZwXi
Content-Type: multipart/mixed; boundary="------------QiXcbOXLxRXa0JvEo2YoSUMp"

--------------QiXcbOXLxRXa0JvEo2YoSUMp
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMDcuMDIuMjIgMTM6NDYsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAwNy4wMi4yMDIy
IDEyOjAwLCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gT24gMDcuMDIuMjIgMTE6NDYsIEph
biBCZXVsaWNoIHdyb3RlOg0KPj4+IE9uIDA3LjAyLjIwMjIgMTE6MzYsIEp1ZXJnZW4gR3Jv
c3Mgd3JvdGU6DQo+Pj4+IC0tLSBhL3hlbi9pbmNsdWRlL3B1YmxpYy9tZW1vcnkuaA0KPj4+
PiArKysgYi94ZW4vaW5jbHVkZS9wdWJsaWMvbWVtb3J5LmgNCj4+Pj4gQEAgLTY2Miw3ICs2
NjIsMTcgQEAgc3RydWN0IHhlbl9tZW1fYWNxdWlyZV9yZXNvdXJjZSB7DQo+Pj4+ICAgICAg
ICAgKiB0d28gY2FsbHMuDQo+Pj4+ICAgICAgICAgKi8NCj4+Pj4gICAgICAgIHVpbnQzMl90
IG5yX2ZyYW1lczsNCj4+Pj4gLSAgICB1aW50MzJfdCBwYWQ7DQo+Pj4+ICsNCj4+Pj4gKyAg
ICAvKg0KPj4+PiArICAgICAqIE9VVCAtIE11c3QgYmUgemVybyBvbiBlbnRyeS4gT24gcmV0
dXJuIHRoaXMgbWF5IGNvbnRhaW4gYSBiaXR3aXNlDQo+Pj4+ICsgICAgICogICAgICAgT1Ig
b2YgdGhlIGZvbGxvd2luZyB2YWx1ZXMuDQo+Pj4+ICsgICAgICovDQo+Pj4+ICsgICAgdWlu
dDMyX3QgZmxhZ3M7DQo+Pj4+ICsNCj4+Pj4gKyAgICAvKiBObyBsb25nZXIgc3VwcG9ydGVk
IC0gd2lsbCBiZSBuZXZlciBzZXQgKi8NCj4+Pj4gKyNkZWZpbmUgX1hFTk1FTV9yc3JjX2Fj
cV9jYWxsZXJfb3duZWQgMA0KPj4+PiArI2RlZmluZSBYRU5NRU1fcnNyY19hY3FfY2FsbGVy
X293bmVkICgxdSA8PCBfWEVOTUVNX3JzcmNfYWNxX2NhbGxlcl9vd25lZCkNCj4+Pg0KPj4+
IEkgdGhpbmsgdGhpcyBnb2VzIHRvbyBmYXI6IE5laXRoZXIgZG8gd2Ugd2FudCB0byByZS1p
bnRyb2R1Y2UgdGhlDQo+Pj4gI2RlZmluZS1zLCBub3Igc2hvdWxkIHdlIHJlLWZpeCB0aGUg
cHVycG9zZSBvZiB0aGUgcGFkZGluZyBmaWVsZA0KPj4+IHRvIGJlIE9VVCAob25seSkuIEFs
bCB3ZSBuZWVkIHRvIG1ha2Ugc3VyZSBpcyB0aGF0IHRoZSBmaWVsZA0KPj4+IGNvbWluZyBp
biBhcyB6ZXJvIHdvbid0IGdldCByZXNwb25kZWQgdG8gYnkgc2V0dGluZyBiaXQgMCBvZiBp
dC4NCj4+PiBJbW8gdGhpcyBjYW4gb25seSByZWFzb25hYmx5IGJlIGRvbmUgYnkgd2F5IG9m
IGFkZGluZyBhIGNvbW1lbnQuDQo+Pj4gVGhpcyBjb21tZW50IG1heSwgaW4gdHVybiwgbWVu
dGlvbiBYRU5NRU1fcnNyY19hY3FfY2FsbGVyX293bmVkDQo+Pj4gb2YgY291cnNlLg0KPj4N
Cj4+IFRoZSBrZXJuZWwgY291bGQgYmUgY2hhbmdlZCB0byBubyBsb25nZXIgdXNlIHRoYXQg
I2RlZmluZSBiZWZvcmUNCj4+IHVwZGF0aW5nIHRoZSBoZWFkZXIgZnJvbSBYZW4sIGJ1dCBh
cmUgd2UgcmVhbGx5IHN1cmUgdGhlcmUgYXJlIG5vDQo+PiBvdGhlciB1c2VycywgdG9vPw0K
PiANCj4gUHJldHR5IHN1cmUuIEFuZCBJIHRoaW5rIGluIHRoaXMgY2FzZSBpdCdzIGJldHRl
ciB0byBicmVhayB0aGUgYnVpbGQNCj4gb2YgY29uc3VtZXJzIChzbyB3ZSdyZSBzdXJlIHRo
ZXknZCBub3RpY2UsIGFzc3VtaW5nIHRoZXkgaW1wb3J0IHRoZQ0KPiBoZWFkZXIgZGlyZWN0
bHkgaW4gdGhlIGZpcnN0IHBsYWNlKS4gSXQncyByYXRoZXIgYW4gZXhjZXB0aW9uYWwgY2Fz
ZQ0KPiBhZnRlciBhbGwuDQoNCk9rYXksIEknbGwganVzdCBhZGQgYSBjb21tZW50IHJlZ2Fy
ZGluZyB0aGUgcmVzZXJ2ZWQgYml0IHRoZW4sIHdpdGhvdXQNCnJldmVydGluZyBhbnkgcGFy
dCBvZiBjb21taXQgN2M3ZjdlOGZiYTAxLg0KDQoNCkp1ZXJnZW4NCg==
--------------QiXcbOXLxRXa0JvEo2YoSUMp
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------QiXcbOXLxRXa0JvEo2YoSUMp--

--------------OAAhB8NlPwxY2Eqoyt80ZwXi--

--------------CAE4S9venc9Dn8tyZe5JsY2J
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmIBFTQFAwAAAAAACgkQsN6d1ii/Ey89
Dwf7BIQwwDWqwXJF7WvPjnLsuxUbryPjaRFn6L3iEFD3SfAL8ALSWpVh8EM/Q11DnnJxEYsOxnVJ
igzv/CPVX5/kgX0exGH6FsWK3HV4x5i7L4GHctXXcBhu1PwXqSCNuVsedGCP16mM236OnTer7h5V
kA3HlO3P1wFc8fwkNcC/bpb8tcUnrfj+VYfxqpDqFyyxFjRLU1FYfajRTO/8K+tRFjBhdfxVjWPo
Qqvj3tVNpMBsP1BRFsvkmVq0M5pFNCqC1Zsz/v57UsJOqpIRLSLdkYWCbyooOl5x9+uA5P8aMqum
oKT11hW6lodJipC/zm25WV/VRlLDRDqx4AMeUIOnhQ==
=vnKt
-----END PGP SIGNATURE-----

--------------CAE4S9venc9Dn8tyZe5JsY2J--


From xen-devel-bounces@lists.xenproject.org Mon Feb 07 12:51:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 12:51:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266866.460578 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH3Ui-0004cc-Ur; Mon, 07 Feb 2022 12:51:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266866.460578; Mon, 07 Feb 2022 12:51:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH3Ui-0004cV-RY; Mon, 07 Feb 2022 12:51:48 +0000
Received: by outflank-mailman (input) for mailman id 266866;
 Mon, 07 Feb 2022 12:51:46 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=F54n=SW=epam.com=prvs=403792ff6c=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nH3Ug-0004cO-JN
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 12:51:46 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ae2c2c0c-8814-11ec-8f75-fffcc8bd4f1a;
 Mon, 07 Feb 2022 13:51:35 +0100 (CET)
Received: from pps.filterd (m0174682.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 217CkTpJ021665;
 Mon, 7 Feb 2022 12:51:39 GMT
Received: from eur01-db5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2056.outbound.protection.outlook.com [104.47.2.56])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3e33qkg0mm-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Mon, 07 Feb 2022 12:51:39 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by PA4PR03MB7213.eurprd03.prod.outlook.com (2603:10a6:102:bf::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Mon, 7 Feb
 2022 12:51:35 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77%3]) with mapi id 15.20.4951.018; Mon, 7 Feb 2022
 12:51:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ae2c2c0c-8814-11ec-8f75-fffcc8bd4f1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=WkTgNck5XFF76tB4rLHfNrcm4EPbu4FUm29muvKmt3SDcWE/p57amPYfYc8jOX6QTjBAS9fDtGngxCRWmD3+JAzNoSElA8T6rUkY1iNxYJR6DP7PfuPf3WWjjJKwzrOLs+VRUMbLIkrCijai6gaOVcJaPyH4ciZDsFhI+GgrChhLJ5DyOnNkHx2OuhNZk+PTAN3x6rCeNgoeDiReaYPd081ArSVIl/Et579VuEMWlo5yQ5Y2Ra+leV8M7SxHOmE6U91UVQsJlC0J+rnWr0CGOROIK+DrGamQPbaqbSylCnvKuU7W0X8K2MRkKw5+19yQOzM3Eq4S7c2dOOcifTcfSg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=hFUU194To8W+mV03GI198BEReCHaKlCmeWf+2yC75do=;
 b=EZMCcA2luwiIQiEB6mqFEb9MG9r+PRCj47DqmNlf+sy0/c1dhr4YF0S5rDehTM1mfUlN/jQ2Y8sHV005bOJk4X7vzHOzSK2wslmvOP6O3BYMq4ATbcy/2jQ8o/twpgsxcS/fQLRaBq2DhCGSx4rcVag21VB0ch62oY2WY0Qsb6Bz/xRZuOP+ogqmNGspXhAV+azNyb1u2biFy+fd0IWDyC0/ciMcOSZsOxeETNlEcOgzPFyO+o+ZSaGJyzNmEMiP+90joslzS4xfzeQDdgBGAR4R5m4qI5WZWsRKhsef6lLs9a7l+vDnZkJOIbokMiLobO5FcIcdxZS0Gsz/r9j5mg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=hFUU194To8W+mV03GI198BEReCHaKlCmeWf+2yC75do=;
 b=UeY/W4lU0el27imRHjtjvBY6y6ExehFNFs1QwdqB8ueO3gbKdrYqTGle4BYr9i5ztNGWN2XCJ+D4pdw/IzP6GsIqXsxkjizAcfzV5wJaBYvFKZaCXURvWoTNqF0jQ5+UswAAiL7e+1L/xW4rAGKsAQvLWB2okOXtaiQdPW5Z72TaGjmZpixZnBPU86cg6ttUAVqEdu9lYfXVk1AzFhN4kYIYuI5xvK9YeIa+52LGYR+G6C4QRyo3I/p9lzTKG3V0lys4JyUJc1zxezK1uQETevxLcnk5jDEfhY0t+qMN7nsf66W0nT6YiLeBo8aaiTAjzTT5BLcaWtpWIiU1OqohQg==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "roger.pau@citrix.com" <roger.pau@citrix.com>,
        "andrew.cooper3@citrix.com"
	<andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com"
	<george.dunlap@citrix.com>,
        "paul@xen.org" <paul@xen.org>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>,
        Rahul Singh <rahul.singh@arm.com>,
        "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        Oleksandr
 Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v6 10/13] vpci/header: reset the command register when
 adding devices
Thread-Topic: [PATCH v6 10/13] vpci/header: reset the command register when
 adding devices
Thread-Index: 
 AQHYGZFg3nazYSvfA0G+yHTbxcxX2ayDdFgAgAAB6wCABD+NgIAAQmgAgAAT4YCAAAOjAA==
Date: Mon, 7 Feb 2022 12:51:35 +0000
Message-ID: <fbd410d1-84ad-2309-ca05-b9ac7f95f1f9@epam.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-11-andr2000@gmail.com>
 <96381d7e-dafc-acee-3abf-f9815deb207c@suse.com>
 <ef76faac-f9d3-1cb8-06b5-189ccd299542@epam.com>
 <6f0a015b-c48f-76ed-9a51-39c045ff5927@suse.com>
 <2ad372d4-a181-9307-ef50-a5adb61dae66@epam.com>
 <49380584-0577-96f2-ef1c-a96eabf0d227@suse.com>
In-Reply-To: <49380584-0577-96f2-ef1c-a96eabf0d227@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: ad655505-3d3b-4cf6-7082-08d9ea3892fb
x-ms-traffictypediagnostic: PA4PR03MB7213:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <PA4PR03MB72137AD0F8E5B64E2B02FE32E72C9@PA4PR03MB7213.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:4502;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 pIWjNUzMiOn1/BlPDKGYeZvRqpKaZcpMzFRR+BReGWfn2XwSf3gkEXaRFBmQ9Zt699zZW7b7Kul4vfXnn22lSrFXlhbWBSbD9VefA0toKZnEIGLL8CWOk8xPD/T75P4Pwh4Wf0w+cUi16sCiDcnlTf+CT/shUAuxWtyG8n8hmf3u66z9YqU9tJeTA6hwBIr8ztzDT+dlAO+lvcBgl2+ibyOfwfXv6cCwEZ0AGAEytSLiiyAga30EBRoRyjBDRlbhzWAus7RTjcQkO8vAqzE5OyQn3Xdn+rUlPBs1xtQMYZTCHp70dnwmFDPyEu8lRXXn9Wa3afIpSQxwlZ5rTTvr5yDA1kivzxmM5s2azO/DydLF9edbVqS+TH8r5+wcoo/G4iRVIJp2YbKHAl2q3zdoeESakUMmHWUbJI5Ilq141QU7SFwulA7I9szqMZ0oAwqKRIIp1RhSbkWzQ2aO2GQi4y1910A4XPH4RT+NowF4KJ1KxGkFAqZSrn6Vx/2acsjrbT6XhwRwkdeqww+Pm0meG3tf8ZFUEacu7Z1OI2NG4zPD7JktaKhsNZkfBtN60gONaCdFGHHrEp1uQUr9kK7ZAxfbOLsLhdKHmCctv+GW/Luly5hgL9lKdRaISXcpqaYJU3WXsL8Zubg7/VZhN2y6zRTjiOIPRmKKQ+/UykjyZQqzYlch4ADv3lEHZ/MFBiQO2dVXKyCIS/8R5B/5BXgdHFEwyfO1//xgLrgr5Yda5SA/UsrHK1bKgfhb5lnhM1sN
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(316002)(7416002)(2906002)(6486002)(38100700002)(6916009)(54906003)(4326008)(86362001)(122000001)(5660300002)(31696002)(38070700005)(6512007)(107886003)(508600001)(8676002)(6506007)(91956017)(76116006)(8936002)(66946007)(55236004)(53546011)(83380400001)(64756008)(36756003)(26005)(186003)(71200400001)(66556008)(66476007)(31686004)(66446008)(2616005)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?MlZxMGRaOXNEVEhCbmRvKzdkbTc1RXBzeHUwSXo4ZkhwVFZnWkExTWNTK3pX?=
 =?utf-8?B?R1FTQXhNclUyYWVwWlpGZXhkM1ROblR5SHA4MDRKdDZ3QmZhbkpEU1dob0RG?=
 =?utf-8?B?Z1ZINmN0OUV5MTZPb0d6RmxaVHlIa3FSZ01xMUFnTTdWMks5Zkl4cmU5OVRP?=
 =?utf-8?B?Y2ZBckt0Vm1kSkhZa0RzREZHVUtPRkFWdSs4ZHN1a0lVVzdnbEZXdE1GaEFt?=
 =?utf-8?B?S0lLN3lBTHdrMDZJM3VoWmFrUVduWVNUeGxnRms4YlE0bXU1V0xSK1Z6Qmp5?=
 =?utf-8?B?VXdZOGFtOHhjbkVEYi9Qczg1YnVDdnBSMnJ4UVhpN0J1VmI5U3RMZTd6M09u?=
 =?utf-8?B?aVl4OEVsTk42a2hMUDlwNTRRcGFnTVdVakJEZUJxdGJtTUI1QzI4SlJybUZ2?=
 =?utf-8?B?V0dicjdaVjRCa1BIMVcyYVJSb2pJR2Yrb3FaUUczUzNQdjN1L0pXcjN0N2JZ?=
 =?utf-8?B?ejZnbmpJQU1ydmRwWnJzZmZLRmZtS1dITy96K1ZmNGcwWHlTdkg3ZkJnVVFq?=
 =?utf-8?B?U1UxQVo4M3o0eUNPQ0VwSStmWmVZSVZWd0VLb2VwaGIrdzRyV1JCbGtReS9J?=
 =?utf-8?B?eWdsVWZCVWlrYWRTSTZ6RHkxMEd6VmVVTDFPaUhTNWRYbTVjZ1k5dCtuaGNk?=
 =?utf-8?B?NGRhRUtReW5UUjYzSTNWWjhnSFlpUW5qV05NUGNJMlZMMVhUZVN4MGlFUXBW?=
 =?utf-8?B?WURzdllUVjdzeG9sZXR4WHd4UG9UdFRaMHEvZEZkKzNpN1FsWWo5N3ZlYTR0?=
 =?utf-8?B?ZzdNeTltek5ScHoyZlVYTzdocDh5azhZWENYMGR0dmR0dXdrQ0xmWllDQTRT?=
 =?utf-8?B?SjQxNkEyN1JKcnFKSER2R2VKT0Q2eWxQTWxKQlAxWmg1Tm5PR3h0eEgyQ2Za?=
 =?utf-8?B?YkRTQlFRMHlWM1VSSFltbllEa0hjak1XM0xjVHEzUVBDNGgzNGpFNnNDTWFR?=
 =?utf-8?B?ZTU1UFVuSFVMVDNscnFRSmlyTFh4MFNnWnRuR0lYTUkzblpYWjEwWERJY1JQ?=
 =?utf-8?B?blNJY3hzNUZtUGl6SWVMczkzM0VyenNHbDRvTlNZem5CN2RMc3lCQlp3K251?=
 =?utf-8?B?aDhlV0dYMEhMSjZqWEdJa0tSVlFUTlFlSy8zN2tNcktwY2dqMnEzMmZ5WEpx?=
 =?utf-8?B?M3BweitYRDR5d3I5bWp2U2Y4YytaY0d6N2l2djRDK3VIS0ozdGNwRDVEK0NI?=
 =?utf-8?B?b2pYejloQWlBNVJ1ZGlGSTBsaXhPMHVxTVk0ODN5bWJPYVV1R2xUOG5jZ1BB?=
 =?utf-8?B?UGR5Nk1wYndlWnlwNDBYY1JOOXZIMldiMy9HQ3U0Q0wzWmNRMnRqK0xnelFj?=
 =?utf-8?B?aUdEa0pMYmRwQUt4UDhhL1BoVTExZnA5ek1yc2V2OHpyMFpDM002cG9ENk9J?=
 =?utf-8?B?ZFpLOU1GS1B6Wkh1Q3VsTmdRbDUwYTJ3Z3dta1o2cXhGaFROY21OOTA3VG5n?=
 =?utf-8?B?N1BSL3NOUEkzT1hCM3BGalkrNGhuM3pXUEluOUlMbnUydVZab3FpVFRUcSs4?=
 =?utf-8?B?dmtweFB6Vm04M2YvRnRDS3ErVU1PbnRBM3QxaktHcERNYW1Cc2k2RmFNYU14?=
 =?utf-8?B?VTVKOXkvWjJWTHp1VllSQ2h2YjdEYnhSQW5QVElRY2hOYXBZaURSdVlEUlND?=
 =?utf-8?B?TmxIeHJJU2NNYjNCNEhESXNlYzlNWXFoS2JreXlWR2lBWFB5Qzk2MlEyNUlX?=
 =?utf-8?B?UnhQaDdseTJGemhJQ1V4QlJlNGhReVYrR0xaL3dJY3FTYlZ2S1oyODJRdEhI?=
 =?utf-8?B?VmFub3g0MzVUNTNCbTRmMUVMbGtCMWthSGwxbUtDTlEvSStzb3UyWlUrTDEw?=
 =?utf-8?B?MHB5U2x0T0ZSZkUxVjBmMkRlZGFwT1B5NmJnTkM1ZEZXekZ3aUN3d1FvejRt?=
 =?utf-8?B?OGM3ZEU3V1R2NERVQmFiYU16L1hYMDZLb2FPTmp6QmlWbFE5RWNqWS9kY3Bz?=
 =?utf-8?B?aWR6RWNTMnBKanBpSWNLM2VaUzdDUFh0Y0pIelZDbmp0Nlh6YnBLakZjZ21F?=
 =?utf-8?B?RlZzS1ZVS1E5bjZzNHRVT29UTCtQWU1sTHBQRG5OelFnSGM4NHNQS1BVV3pw?=
 =?utf-8?B?WE10SXNWem5lalhWU1lLVTBKQWNvbmNyRmY0ZWdoSWhQdnNtV2JJUms4NlZm?=
 =?utf-8?B?T2czUTc3TGErNURCM3F3bjBpZlAvTlIwc1ZGcXlBNjNYMkMyZGdYWitlb0RO?=
 =?utf-8?B?R2JXMG1jb3ZTNzZUN0pjRnVSRHlmMXVWWUFqQnAzTmtaZWxsSm5yQnpxNUxV?=
 =?utf-8?B?c2Y5TzNBZnIvTHVucDRKVFdMN2U3RjRtQ1hkWVZJOEtScTJsV2g1THV1RVZy?=
 =?utf-8?B?N1JRVVNneXdkbkFPamJMaVFXbHBsN2NYTWZaRGpnV1djVlhVUkZWdz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <E2DAC35BDA7B6544BE0D043650236365@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ad655505-3d3b-4cf6-7082-08d9ea3892fb
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Feb 2022 12:51:35.4187
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: T0Guc7EJ+Idm2O3gMu0dmI6/i31CvgK96BCPAZpIoRmWzQMN+f3+FffU9AS1rx4CkovaGs9PJmGWJ1CKdQry495skBp3XtyDrijaCESiQ4A7mFdFbHqWvJkyiDT7Wmv8
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR03MB7213
X-Proofpoint-GUID: z59leMm8dasn8w2fCyQmheSDfR9pCbaX
X-Proofpoint-ORIG-GUID: z59leMm8dasn8w2fCyQmheSDfR9pCbaX
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-07_04,2022-02-07_02,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0
 adultscore=0 impostorscore=0 priorityscore=1501 bulkscore=0
 lowpriorityscore=0 mlxscore=0 suspectscore=0 malwarescore=0 spamscore=0
 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202070083

DQoNCk9uIDA3LjAyLjIyIDE0OjM4LCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMDcuMDIuMjAy
MiAxMjoyNywgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+Pg0KPj4gT24gMDcuMDIu
MjIgMDk6MjksIEphbiBCZXVsaWNoIHdyb3RlOg0KPj4+IE9uIDA0LjAyLjIwMjIgMTU6MzcsIE9s
ZWtzYW5kciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4+PiBPbiAwNC4wMi4yMiAxNjozMCwgSmFu
IEJldWxpY2ggd3JvdGU6DQo+Pj4+PiBPbiAwNC4wMi4yMDIyIDA3OjM0LCBPbGVrc2FuZHIgQW5k
cnVzaGNoZW5rbyB3cm90ZToNCj4+Pj4+PiBSZXNldCB0aGUgY29tbWFuZCByZWdpc3RlciB3aGVu
IGFzc2lnbmluZyBhIFBDSSBkZXZpY2UgdG8gYSBndWVzdDoNCj4+Pj4+PiBhY2NvcmRpbmcgdG8g
dGhlIFBDSSBzcGVjIHRoZSBQQ0lfQ09NTUFORCByZWdpc3RlciBpcyB0eXBpY2FsbHkgYWxsIDAn
cw0KPj4+Pj4+IGFmdGVyIHJlc2V0Lg0KPj4+Pj4gSXQncyBub3QgZW50aXJlbHkgY2xlYXIgdG8g
bWUgd2hldGhlciBzZXR0aW5nIHRoZSBoYXJkd2FyZSByZWdpc3RlciB0bw0KPj4+Pj4gemVybyBp
cyBva2F5LiBXaGF0IHdhbnRzIHRvIGJlIHplcm8gaXMgdGhlIHZhbHVlIHRoZSBndWVzdCBvYnNl
cnZlcw0KPj4+Pj4gaW5pdGlhbGx5Lg0KPj4+PiAidGhlIFBDSSBzcGVjIHNheXMgdGhlIFBDSV9D
T01NQU5EIHJlZ2lzdGVyIGlzIHR5cGljYWxseSBhbGwgMCdzIGFmdGVyIHJlc2V0LiINCj4+Pj4g
V2h5IHdvdWxkbid0IGl0IGJlIG9rPyBXaGF0IGlzIHRoZSBleGFjdCBjb25jZXJuIGhlcmU/DQo+
Pj4gVGhlIGNvbmNlcm4gaXMgLSBhcyB2b2ljZWQgaXMgc2ltaWxhciB3YXlzIGJlZm9yZSwgcGVy
aGFwcyBpbiBvdGhlcg0KPj4+IGNvbnRleHRzIC0gdGhhdCB5b3UgbmVlZCB0byBjb25zaWRlciBi
aXQtYnktYml0IHdoZXRoZXIgb3ZlcndyaXRpbmcNCj4+PiB3aXRoIDAgd2hhdCBpcyBjdXJyZW50
bHkgdGhlcmUgaXMgb2theS4gWGVuIGFuZC9vciBEb20wIG1heSBoYXZlIHB1dA0KPj4+IHZhbHVl
cyB0aGVyZSB3aGljaCB0aGV5IGV4cGVjdCB0byByZW1haW4gdW5hbHRlcmVkLiBJIGd1ZXNzDQo+
Pj4gUENJX0NPTU1BTkRfU0VSUiBpcyBhIGdvb2QgZXhhbXBsZTogV2hpbGUgdGhlIGd1ZXN0J3Mg
dmlldyBvZiB0aGlzDQo+Pj4gd2lsbCB3YW50IHRvIGJlIHplcm8gaW5pdGlhbGx5LCB0aGUgaG9z
dCBoYXZpbmcgc2V0IGl0IHRvIDEgbWF5IG5vdA0KPj4+IGVhc2lseSBiZSBvdmVyd3JpdHRlbiB3
aXRoIDAsIG9yIGVsc2UgeW91J2QgZWZmZWN0aXZlbHkgaW1wbHkgZ2l2aW5nDQo+Pj4gdGhlIGd1
ZXN0IGNvbnRyb2wgb2YgdGhlIGJpdC4NCj4+IFdlIGhhdmUgYWxyZWFkeSBkaXNjdXNzZWQgaW4g
Z3JlYXQgZGV0YWlsIFBDSV9DT01NQU5EIGVtdWxhdGlvbiBbMV0uDQo+PiBBdCB0aGUgZW5kIHlv
dSB3cm90ZSBbMV06DQo+PiAiV2VsbCwgaW4gb3JkZXIgZm9yIHRoZSB3aG9sZSB0aGluZyB0byBi
ZSBzZWN1cml0eSBzdXBwb3J0ZWQgaXQgbmVlZHMgdG8NCj4+IGJlIGV4cGxhaW5lZCBmb3IgZXZl
cnkgYml0IHdoeSBpdCBpcyBzYWZlIHRvIGFsbG93IHRoZSBndWVzdCB0byBkcml2ZSBpdC4NCj4+
IFVudGlsIHlvdSBtZWFuIHZQQ0kgdG8gcmVhY2ggdGhhdCBzdGF0ZSwgbGVhdmluZyBUT0RPIG5v
dGVzIGluIHRoZSBjb2RlDQo+PiBmb3IgYW55dGhpbmcgbm90IGludmVzdGlnYXRlZCBtYXkgaW5k
ZWVkIGJlIGdvb2QgZW5vdWdoLg0KPj4NCj4+IEphbiINCj4+DQo+PiBTbywgdGhpcyBpcyB3aHkg
SSBsZWZ0IGEgVE9ETyBpbiB0aGUgUENJX0NPTU1BTkQgZW11bGF0aW9uIGZvciBub3cgYW5kIG9u
bHkNCj4+IGNhcmUgYWJvdXQgSU5UeCB3aGljaCBpcyBob25vcmVkIHdpdGggdGhlIGNvZGUgaW4g
dGhpcyBwYXRjaC4NCj4gUmlnaHQuIFRoZSBpc3N1ZSBJIHNlZSBpcyB0aGF0IHRoZSBkZXNjcmlw
dGlvbiBkb2VzIG5vdCBoYXZlIGFueQ0KPiBtZW50aW9uIG9mIHRoaXMsIGJ1dCBpbnN0ZWFkIHRh
bGtzIGFib3V0IHNpbXBseSB3cml0aW5nIHplcm8uDQpIb3cgZG8geW91IHdhbnQgdGhhdCBtZW50
aW9uZWQ/IEV4dGVuZGVkIGNvbW1pdCBtZXNzYWdlIG9yDQpqdXN0IGEgbGluayB0byB0aGUgdGhy
ZWFkIFsxXT8NCldpdGggdGhlIGFib3ZlIGRvbmUsIGRvIHlvdSB0aGluayB0aGF0IHdyaXRpbmcg
MCdzIGlzIGFuIGFjY2VwdGFibGUNCmFwcHJvYWNoIGFzIG9mIG5vdz8NCj4gSmFuDQo+DQpUaGFu
ayB5b3UsDQpPbGVrc2FuZHI=


From xen-devel-bounces@lists.xenproject.org Mon Feb 07 12:55:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 12:55:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266877.460589 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH3Xt-0005Je-JJ; Mon, 07 Feb 2022 12:55:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266877.460589; Mon, 07 Feb 2022 12:55:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH3Xt-0005JX-G3; Mon, 07 Feb 2022 12:55:05 +0000
Received: by outflank-mailman (input) for mailman id 266877;
 Mon, 07 Feb 2022 12:55:04 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=owYM=SW=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nH3Xs-0005JR-5r
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 12:55:04 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2a160cef-8815-11ec-8eb8-a37418f5ba1a;
 Mon, 07 Feb 2022 13:55:02 +0100 (CET)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2057.outbound.protection.outlook.com [104.47.13.57]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-23-8tWZRZ5qO0eAsylcQB6IDA-1; Mon, 07 Feb 2022 13:55:00 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by HE1PR0401MB2363.eurprd04.prod.outlook.com (2603:10a6:3:25::8) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.17; Mon, 7 Feb
 2022 12:54:58 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.018; Mon, 7 Feb 2022
 12:54:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2a160cef-8815-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644238502;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=979PX1I0R6Ko1kf1qG7DviEMdxQrwOkr/l8gOMvtMDM=;
	b=cbN1U5ZjDw5Btam/TwRXsz1eoFj3hiXD/UI/R6pw//RFGC+S3DLXmfBXlSwG1ztJScCEKV
	I6UjH+UuxLpnlh/aZT1zrPu690eCjzuMtNj/QvMRml1YTIylBH9zNcDI16mirbLZ0j6NXM
	rKM9O8DVmAo43z4KwyHV5JnNvNYvuHE=
X-MC-Unique: 8tWZRZ5qO0eAsylcQB6IDA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=hslUalNb2kcAqUMPWfxGrPGZdUSQIBm3p+zc95I2ymD8Ir65mgUE+t1VXpsFGNVljnbNB0fR0hTs6bXXfxlk2ee/stxxv55lrCIBZMmMPzTtf9V02GxSJH5RpTbGqtUiZebxoXWksQHVP79aHuGPE2aHoHBAAC08U2HZjTa3d4BOj2pvIpWLb2RuW/tVcrT7a1bqJFQigfjXBbDDIBJcwbgxAkSP3yaBArwmP8PKT3ZtzCwBYrytkil43oEswTQdU/UlvL2XlQLZLzrAC2jzXd8Gws6CWDeD6pPKdKJDFEziOVm3HD28y5b0jL1f7efwX8MuhDOZGlqdc2GhS59i2Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=979PX1I0R6Ko1kf1qG7DviEMdxQrwOkr/l8gOMvtMDM=;
 b=CnXlt9lX/N9g8Nz9rKSG+COhZcEWFLoiq7BpccTylXMitAjVUeF4YxiSBYlW6Blii4dhfp236SqTSdtZpBKEWeNruPojORDQTEyjZoGFvfaS4ZBDwcuUxd4TjtB1W9AFnJxtKLzJSqvKO2gEEka62zXo8Pg6Gcj36PbTPweblQReq3Rz/PYUYkDULU3tT9P1kNqA+IG6z6CHKDbC6deUHPmbtaXhiXPHbi58gqXap7alnr7YB/ws88SwzdmLQrNNdEUW8aQOT30PKddRk2+ocOC0nRYkt+Vl9NyXPG61XFtoEzEXf0PAIaGTuy5Z+SUA+Izwt1kwQEoU6ShhLYvY3Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <dbef1c95-818c-427c-1963-75d584843cff@suse.com>
Date: Mon, 7 Feb 2022 13:54:55 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v6 10/13] vpci/header: reset the command register when
 adding devices
Content-Language: en-US
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Cc: "julien@xen.org" <julien@xen.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Artem Mygaiev <Artem_Mygaiev@epam.com>,
 "roger.pau@citrix.com" <roger.pau@citrix.com>,
 "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
 "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
 "paul@xen.org" <paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-11-andr2000@gmail.com>
 <96381d7e-dafc-acee-3abf-f9815deb207c@suse.com>
 <ef76faac-f9d3-1cb8-06b5-189ccd299542@epam.com>
 <6f0a015b-c48f-76ed-9a51-39c045ff5927@suse.com>
 <2ad372d4-a181-9307-ef50-a5adb61dae66@epam.com>
 <49380584-0577-96f2-ef1c-a96eabf0d227@suse.com>
 <fbd410d1-84ad-2309-ca05-b9ac7f95f1f9@epam.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <fbd410d1-84ad-2309-ca05-b9ac7f95f1f9@epam.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0601CA0071.eurprd06.prod.outlook.com
 (2603:10a6:206::36) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a9157604-b695-462b-0221-08d9ea390bcd
X-MS-TrafficTypeDiagnostic: HE1PR0401MB2363:EE_
X-Microsoft-Antispam-PRVS:
	<HE1PR0401MB2363122E1A0F5DF3828DE847B32C9@HE1PR0401MB2363.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4303;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	f9vPjsAyzKiHdaae/OsT0ZSfNxhTGoocfxcLLkVADaqVsGAfLuxYk8ZW3RSOx1ISvZRkORJgd93VUSTOpb3m5DryCBRU5dNgM6gtQNXrtv3OhqcjwgtGxx7kdUwyAwJWiAoUdLxZOMEGtquyfcKoHBBsJ/HvfYFG/WQD+a+eQbe/+1GtecQ1WtK7WsRcYmaBVMYy7vuD8r7K7WKCuRb8C2i4M8ahicv86skeqowiA+SdBImNyWL4jfFnAfRhrCt3we7tS5eU4W9siOzinYAExyoixzAgZCgPkZFG8bUmfBQCQ/RqlsSsqLAL+H3PfdgcpUMa6bX/SyHpPEtd5KDRF8EhbwUXDH2ODpSbKSrZvsfaUcm4GNU8UGPpItp7lxcluZ58afv/K8Uj/Jejxe7dype1M77niJKmt0VVzpqjExuZvUxbaWjJEQc1wx4Lc7mYtqRgOUDLrycwXkQrtgvGvsXwpfyUd1i/7ZkV/Bsrroo6F6mP0/iWRQI9d8vinYOCPD08ni7Wyu1//tLCAIZlLO7cSjU19KbK6rB185riM6b3vT29Rwa/lBXTYiaAMlr6jUS0rgExcCnph8vTY/9/gE9TACelJS/aBu607Z+a/FRqGAQgTfe93+cwnyJFvUWSg9XQGGThHMvSrGRYWZUh3i5apsQUiPxiA8MYal2kDv5blF4TamYE7KL5ExT31AcDa7ugYkRbkFNRnf3zC5f1B67Uf8jbaI2gTd5ZVwARMFo=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(26005)(31686004)(186003)(86362001)(2906002)(5660300002)(7416002)(6512007)(66946007)(6506007)(6666004)(83380400001)(2616005)(53546011)(8676002)(8936002)(66476007)(66556008)(31696002)(4326008)(54906003)(36756003)(316002)(6916009)(508600001)(38100700002)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?MmVOWEV4elpoV1dKaHUyN2gwL3FrTzFpTjdacngralF2ZGpqY09GQnNvd1J4?=
 =?utf-8?B?eXVSK2g5d3hkc0J5VHhUZkllZzZLdlFyblpsc0FkNlo3SC96cGRmbVNBSEdK?=
 =?utf-8?B?dDFsbmt4d3ZHWFNwNytCZytiTzMzSVdnN09BMnRzSm1qSnpNTzYySU03UmNT?=
 =?utf-8?B?bmZQazJtQzcrMTZnNFo1K2R3ekdFZ2tyWDYwbGpoTk9Sc2toU3M5Y1F4dkNC?=
 =?utf-8?B?blJKL2RmWnE4bHNnbWp0RkYyRkFXNjM4Z2k2aGNKWUF0MStOVmJxZ3V3R09H?=
 =?utf-8?B?R1B3aVhIcVF6NGJpUEZxZlhUcjFtL0hoQ0lUazdLS21sU1J6V05UZ2lnWkxL?=
 =?utf-8?B?amNJZHdlang3K1ZrbU54Y1hGWEpHaGZFejFTRityWVR2RzVvT1FOOFVNMXVk?=
 =?utf-8?B?VCtSZyt5ZnliS2p4VStZaWdxSTNjV0tLVi8xenJwcUxpOGVpbE9OZU9UZ3RC?=
 =?utf-8?B?WGQyNUNKVVB4OGt3U0t0amhacHJYOFB0T0tyWFNXQ0xtclU5R29xN0JXR1Jl?=
 =?utf-8?B?a2hKKy9xS2p4TVVablMyT09PWVlUMzJDaEVXMFNxR21yeExlMDB1R04wUjV6?=
 =?utf-8?B?SGxSS2MzRlVkaXkxKzQzeWdpenc0VXpBRk8vczhkNTNMUGJ0Y0hodjRndE9K?=
 =?utf-8?B?bGczYkhoWkpHc251aktudm1TcnFBcXR2R1dJSXg4aEJaNVkrSDJpVjRiamQ0?=
 =?utf-8?B?RWxqeE0xZy93Q0pKaXMzSmRET3VLQVZIYjlqOE5rU2VrNlVqdWhIOVBuOHFJ?=
 =?utf-8?B?M0I3SSt4R3pIVERDekNwVWozTEJrcWkxMzFFRGFWTVBQR2NZbEZhc0NNWWcx?=
 =?utf-8?B?Ni9TQXMycnJ6M3p0UlF2OUNTRE45bFJtT09VSVJheDVpakpySTBnZE9zc05z?=
 =?utf-8?B?UTd4SzdCOGxCUE5ZQWFXOWE2ZFZqNmZWN1F0dTlBQXVvVS82OHdWenA1c3J4?=
 =?utf-8?B?UWV0ZFF5ZHYxRldRdEdDYzFKVFp4b0p4TnFwbFFPUGRJYkZUNDJ4N0RwOTVr?=
 =?utf-8?B?dnlWR2FFdHlxeFFVdGZ6andiK3A4WThaWmhJYlBuVUQxOVNqNXR1UDM5QVNY?=
 =?utf-8?B?dlgrN2RaOEhwT1h4RlhuOWVjSDBJQUpjT2ZkMU5IeDY2djhVN1NJQnZtVTRU?=
 =?utf-8?B?eWRGVlR5c3Y2bzZ3dElqNVl0RXFCTnhRNnNRaUF0dDNxdmRLcmpWbTJnZnRN?=
 =?utf-8?B?bTBQNHNOUE9kMjRxZlU1UzBUOGRSak1EUDdJVmh1RXNGd2V1c3h2Vm5sMTE4?=
 =?utf-8?B?bUtKL0RHRWlwRmVGdFhoWkthNUE1aWxCcy94K3BCTTgwMlpXdTFtTVRxUUd6?=
 =?utf-8?B?b2FHcENncktFYXMxOWZTVUp3aSt3V1pjNkdXMFVIQjB6dDZSUGk2d1hxZEFu?=
 =?utf-8?B?STlWK3QrU0hwUmI0MEc4RFBBQXQwaTFod1RJa0pqdGY4RHB5anc3Q2RYSXVM?=
 =?utf-8?B?b21VdTJhdVphNi9Na2VnTEJudjRIZWROOExEZE1FbnpNcUJUbUZvUVhnY3Rl?=
 =?utf-8?B?VlBrMS9zY1hBcDVTT1dQTkdMeW54ZWQ0MmVBem51UW4ydTFSeldnVGN6aEZV?=
 =?utf-8?B?alkrMHhVQ3IxS0VtSmNlK05CaXNlcURRM2hDUWppd0hod0J0YWNtdS9USFgr?=
 =?utf-8?B?VHB5dUQvbDBsMWxvYlh4cENGcklscGhiWFNPYkxCNmsrVjFOUjE4VHVPVHNS?=
 =?utf-8?B?MElpYjJDL1V2M3Q2eDhRMk03NEs2aSswdkZUS1RoLzQzOWhCV2hxYlpMemJ4?=
 =?utf-8?B?SmJXODViTzdYT2xTR0MxMFMzWWVHSWVVWWx5Wkp0NjFXNVZEb0ZHTWJHV2Vs?=
 =?utf-8?B?aE5TUnI0R2I0VlNOSERpT2NFT0ZEOFRaeU13d3NxaThSTmloakxhQmR4aEhN?=
 =?utf-8?B?L0JNd1NLY3pFUEE1TXo0Uks5S2E4a1llS0ZwZm1EajUrTWlqNnhwYkJLa1ZF?=
 =?utf-8?B?YWNkQ1ZyeU5RWGxLM1kvcmJoQmlDd3UwekN1OFFmNU5oRzYzd3dnQ3pteTh0?=
 =?utf-8?B?R3FaR3pmWXM5SXR4N3paTUtJSkY5eDVuQTlRY21PMEJ2SkZQUk1UOWtTSkZK?=
 =?utf-8?B?VXhVR0dGWFpYajlDZ2JVdnJVQXdEK1hZYlBVR01rcUNwU1M5MTZZVzRWc3Jn?=
 =?utf-8?B?Tk9kR2plOU5LcGI5SFYzcnBZZTRUQU1NZzVUTWQrRU5UcFJ5OUVLTkdRUndr?=
 =?utf-8?Q?KfIB0mt0DyTxSyG2q2t24rU=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a9157604-b695-462b-0221-08d9ea390bcd
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2022 12:54:58.3218
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gCygJDhQmq5Jd6j58QD16vNENNR4kZDdCjsR3gQmoAFff0csuGcUhkCOef17cLNu/wiERMow/QN8o2nztV7R1w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0401MB2363

On 07.02.2022 13:51, Oleksandr Andrushchenko wrote:
> 
> 
> On 07.02.22 14:38, Jan Beulich wrote:
>> On 07.02.2022 12:27, Oleksandr Andrushchenko wrote:
>>>
>>> On 07.02.22 09:29, Jan Beulich wrote:
>>>> On 04.02.2022 15:37, Oleksandr Andrushchenko wrote:
>>>>> On 04.02.22 16:30, Jan Beulich wrote:
>>>>>> On 04.02.2022 07:34, Oleksandr Andrushchenko wrote:
>>>>>>> Reset the command register when assigning a PCI device to a guest:
>>>>>>> according to the PCI spec the PCI_COMMAND register is typically all 0's
>>>>>>> after reset.
>>>>>> It's not entirely clear to me whether setting the hardware register to
>>>>>> zero is okay. What wants to be zero is the value the guest observes
>>>>>> initially.
>>>>> "the PCI spec says the PCI_COMMAND register is typically all 0's after reset."
>>>>> Why wouldn't it be ok? What is the exact concern here?
>>>> The concern is - as voiced is similar ways before, perhaps in other
>>>> contexts - that you need to consider bit-by-bit whether overwriting
>>>> with 0 what is currently there is okay. Xen and/or Dom0 may have put
>>>> values there which they expect to remain unaltered. I guess
>>>> PCI_COMMAND_SERR is a good example: While the guest's view of this
>>>> will want to be zero initially, the host having set it to 1 may not
>>>> easily be overwritten with 0, or else you'd effectively imply giving
>>>> the guest control of the bit.
>>> We have already discussed in great detail PCI_COMMAND emulation [1].
>>> At the end you wrote [1]:
>>> "Well, in order for the whole thing to be security supported it needs to
>>> be explained for every bit why it is safe to allow the guest to drive it.
>>> Until you mean vPCI to reach that state, leaving TODO notes in the code
>>> for anything not investigated may indeed be good enough.
>>>
>>> Jan"
>>>
>>> So, this is why I left a TODO in the PCI_COMMAND emulation for now and only
>>> care about INTx which is honored with the code in this patch.
>> Right. The issue I see is that the description does not have any
>> mention of this, but instead talks about simply writing zero.
> How do you want that mentioned? Extended commit message or
> just a link to the thread [1]?

What I'd like you to describe is what the change does without
fundamentally implying it'll end up being zero which gets written
to the register. Stating as a conclusion that for the time being
this means writing zero is certainly fine (and likely helpful if
made explicit).

> With the above done, do you think that writing 0's is an acceptable
> approach as of now?

Well, yes, provided we have a sufficiently similar understanding
of what "acceptable" here means.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 07 12:57:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 12:57:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266885.460600 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH3Zw-0005wg-03; Mon, 07 Feb 2022 12:57:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266885.460600; Mon, 07 Feb 2022 12:57:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH3Zv-0005wZ-T8; Mon, 07 Feb 2022 12:57:11 +0000
Received: by outflank-mailman (input) for mailman id 266885;
 Mon, 07 Feb 2022 12:57:10 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=F54n=SW=epam.com=prvs=403792ff6c=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nH3Zu-0005wR-JF
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 12:57:10 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 74bd9234-8815-11ec-8eb8-a37418f5ba1a;
 Mon, 07 Feb 2022 13:57:08 +0100 (CET)
Received: from pps.filterd (m0174677.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 217BhOL2032550;
 Mon, 7 Feb 2022 12:57:05 GMT
Received: from eur01-db5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2057.outbound.protection.outlook.com [104.47.2.57])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e31mpgtef-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Mon, 07 Feb 2022 12:57:04 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by PA4PR03MB7213.eurprd03.prod.outlook.com (2603:10a6:102:bf::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Mon, 7 Feb
 2022 12:57:01 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77%3]) with mapi id 15.20.4951.018; Mon, 7 Feb 2022
 12:57:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 74bd9234-8815-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=CqJeWZVxv5dR2UW5/WswZ3tikfXRTbnVYm5VYXzY5K1qgjwmCesitapFUabDsg3CRgETCvehYuOR1RGxYhyvLDM793Y+KmQa4c2Pitg4NcqjC6LoVm7gaPaezsbR4v/FAW/ev9EAk6FsNUFG4JzIYmhfw0PQvUMAJ4ZDrNWRs/uY9Gt48JWGbGgobXIYrCijdAdRJr5YRgPvAMOb3qRozdUSg167ruJDyB2IRhCFl43a+VRf+U83Dqg+s5xVFN7jJqmezMtkIPSOhWO6u5w3Nd4mNgnPq8PD9xFDpfXcuk/VbX4m0rS6E2cMmgiEZXLkWAFG+o0yRRnE0+X5WReAhg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=CtWl24wVUiCAmPhliY2OEMQ2kE9TkCcumqYM9tE56sw=;
 b=SiHspuD/BFJvoEIX95QdqQxykB+Ww9BFCO51o1WQG9oxH8Pv9QP6sTFG/iZQwbSC4QJxYy7HF3o5A+0EP4MjHO+hUiXLivaF5sATgxII+NnVQ7aI4q1Tsn/31XILhOZIo5HyB5rsQasiFFogsCPOsy8cUNCzSa5QrHOEfa3FIxwwS32Yw6WvPydcOHDzYFaTPvTtIXvB2TMKIl0JC10pLxgoXFzBKWlKtxmavcvgv0IJKnetPBUsSChuzXVSl5+KQ01HexVkK1kwryD2r2rcZ9+E7JQ3EPpCIf3fDz4I6IaTNkKw7uhbzNAfH5Nm4NMoFiB4hAHXVP+85dtlNk6Inw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=CtWl24wVUiCAmPhliY2OEMQ2kE9TkCcumqYM9tE56sw=;
 b=ALOu8SXUJ3Lm6xeH8f9slAc9Rk/AOBzg/m3MvqIcVLY8v5muYZKt+V6rb1ZQaBllTav/iICuEAGNvhU+UbqQH0MClKeBf+jJR25dTEuFiU/7sde5eLMTlromhuAkRK65OJs2mV/VT8+VpB5f9r4byjuA2Suka2O1IBnTfD9aQtihlizi2+QACBrgKzoaAKpC3noiAXPTDhdzFyfbODdhjRaFF0hdaNCVaE5S1Tjw/pTw5nzJepVaCBvZi8rc20fhkZyiTR9yMhXqlQhNbM1kIh4MUEQQz81DPkyzrlBhThLbUnEMuPM0Bzyz+l+m2DwszP1Z6ryWsyA8LIRivqfOWw==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?=
	<roger.pau@citrix.com>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Thread-Topic: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Thread-Index: 
 AQHYGZFc/MnzQOjwVEeBBUHLSW0md6yDBUkAgAASSACAAATYAIAAD/WAgAAKNgCAAAbfgIAABnuAgAAQvgCAAAMCAIAAAY4AgAADxICAABrnAIAABAgAgAR3CoCAABgPAIAABjkA
Date: Mon, 7 Feb 2022 12:57:00 +0000
Message-ID: <6787ff3d-aea1-d2d6-a1dd-96e80a29b8b5@epam.com>
References: <04726915-f39f-9019-436e-4399533c9fc3@suse.com>
 <9ed3f4ac-0a2d-ed45-9872-7c3f356a469e@epam.com>
 <c3a99712-cf7c-37da-aac1-f2ee00e6d53b@suse.com>
 <Yf0KcVD8W05A4fbB@Air-de-Roger>
 <1ed0e342-16cd-2f16-c05c-186667a22762@suse.com>
 <7e3562b5-fc67-f213-e872-f211450d9e2e@epam.com>
 <a8fc599c-f620-c4d1-2077-c57068f46a7f@suse.com>
 <deef8468-d607-e49e-f456-6a8013329ca1@epam.com>
 <Yf0k6aoKK5G3iad1@Air-de-Roger>
 <3ad10a99-c706-b95f-1419-2c0c7cf37d58@epam.com>
 <Yf0+3C9nF8+tewLw@Air-de-Roger>
 <c5fea3bb-834b-eeb7-d7a1-1ee609037a9f@epam.com>
 <a71b7835-cbbb-74bd-d25d-6824f6f10683@suse.com>
In-Reply-To: <a71b7835-cbbb-74bd-d25d-6824f6f10683@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 6ef655c3-f9fd-4667-7608-08d9ea395508
x-ms-traffictypediagnostic: PA4PR03MB7213:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <PA4PR03MB7213DD80700B127F37C60C66E72C9@PA4PR03MB7213.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 11JKtwgoj4UHh+QDRpRe8W6mxabdrdxPF9RTdXPPLAAR04aMFc9nCH/9R4wKChSc2EI2DUwgNWWhN6cdAi3dT3ynBtQBkaK3lqezxK6Po6AnbkntyFtHeJpxEaHfbFGpoOzMt/pcuoKHOxSvcNO85lzFvKsXp4sg4tzEaY5RldCDmc3CXcqM4RzeajzmY0R3XCvO1Aa24Bglt4YysB50XMG39X3VRM16eoyuiuYT3zXlPSVxvZtUwQ9IvRNmXxufqnxYbY0K4rxDK86vycg8GNrlt6f6ZbJGyvwKEZqRnd0Nd/EGn6j43vwGZavphEEDwP45q5yVyF4mKrZcbyoHTFbmKxSU/ExbosFuiId4XRVFB3D1NsleeqJ6J49PWobqSr3pl+ihSzRyW0lGrzpae6L9mzsF9Z92MMMmkc6RxEcMFJOYR+IjTpHkE/auIKinIQP9t26lH9yHIUQNeO8Z5Eui+CZySJL9GkKxCo3Dhi4G11Mvdwgt6uT/uIGUDhe6Q28vs4tpAUp4bzVEXivBRKCwoW48LRIUExBj/CJoTV7OTECTDvwDxx2/HM5cBKRjSFZ+W8c8i2DOyZeXvaukQWsMZw02mOrZEEqH7wOh4lhhpg71DtiM01VneM9TKvF97NG1gS01AzTSFWBpW0eAJkc8ZOHz7Lx/q/9RrPck3x+18Y/KzASSO7vPArdJjJ4mDYnnMutDw2DiAjnn08Fwjt5syeJ2n+NN8xBOXBRjSQpUyteW33OpnRltF5bywdFD
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(316002)(7416002)(2906002)(6486002)(38100700002)(6916009)(54906003)(4326008)(86362001)(122000001)(5660300002)(31696002)(38070700005)(6512007)(107886003)(508600001)(8676002)(6506007)(91956017)(76116006)(8936002)(66946007)(55236004)(53546011)(83380400001)(64756008)(36756003)(26005)(186003)(71200400001)(66556008)(66476007)(31686004)(66446008)(2616005)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?RWRmL2orUk9TY21tbk1iQTdiV1hVcm1xbXl4dDIwbXBYMVBhVXVIZ281bWtR?=
 =?utf-8?B?WlI2S0c3K1NxTjcyaTJzZDM4eHZtekg4ajl5RTRPUE5ZekZHOWhrL0F3bUZO?=
 =?utf-8?B?R0pPcDlEa21hQUIrVHR0aVpVTVBxZzFVMVpIb0licWV1WmlDMVBCeVJvTWRJ?=
 =?utf-8?B?bXVGV1I0bXBHYkJoVWxHQkoxQjBsbndqSGtOZzFHOFVEaXFZRDZmZGEyWVE1?=
 =?utf-8?B?QVdtUVJBMzBmUDZ3cDRLVkR6Y2ZsSW9KV1J3aWVUWTRVZTAyRGd1QmRoZy9E?=
 =?utf-8?B?ZUdlN0lpeWQrRlFBNktabTQ1bWU0SGZwV2k5anJXN3gzdFZRd3RaaVZrNDBq?=
 =?utf-8?B?RmpwNnZGelgzTE9IOXorblZZY2JUcGZiK1FhRUJzcjEwNmdRQndvK1BMVy9V?=
 =?utf-8?B?M042SDBpNkh1L3JPQnNSVnA4cXBwTHB2MzRyTlZpUGQxQ05TTXlJYzUrMTZE?=
 =?utf-8?B?RjFIOVd3YkMxRDVpTWlyVGZLdGxHbUwreDZyTUZmSmRmVUl5VlVFMVphOXE5?=
 =?utf-8?B?QXo5WG9JeWloTEFQKzF4RXA5akJrT1JiRFBuZ0xRY0s3a1d3UnZhWmN2OFdX?=
 =?utf-8?B?V2NCV0l1eXNFNW11eDFPd0xyTEdHaDh4cXpyc1Q4dmt0aTZiamozV2wwd1Az?=
 =?utf-8?B?NTZJbHpzQmprL0lZYVB6RnI4eXJFMUgzcjFSMkJ1VkxqOEJ3dFUxYnIvNlZH?=
 =?utf-8?B?QzlrY2R6VjF4L3ZCOGZnSmEvdkRVYmxpWkZzT3hpUFpQVmVRSVpTdmY4aUp0?=
 =?utf-8?B?bS8wWnY3ZUhUV0ZicEUzcjI0ZVFOSnJRQjFxVktvczc2MWhRQVFwTmtxVWZk?=
 =?utf-8?B?MTdrYlN3YlYxZzFkQThaS0ZvN0EwV1QyUHBJaHFCbEovNjlJMlNYeGJzbHR6?=
 =?utf-8?B?dzl6VlU5NHRuekRXdFVONzdVSTZLU2pzcG5rRTl1SjZwS1dDNFFaSnJna3NL?=
 =?utf-8?B?ZDZ1dDZjZTMxOWVjYXkvZ3prbGlWM2t4cDZsTFhnWjkrelk3Z1Bja09FUG52?=
 =?utf-8?B?S0I2SGtDNDJHY2hvaDhjdDUyOEE5NzJObnhpNnNZc2tqaFp5MkNZNWZxYU56?=
 =?utf-8?B?Zk50WEVvQnN0aVFHd0pHYkpzTC9za3B0RWlBdHhLcGltb2d1YXB6MnU0b2NV?=
 =?utf-8?B?bVBFQnRoeHBnYm0wMjMzTnFqZTM3V085cTFqeEViT0lhbUo5bFdQU0w2STFM?=
 =?utf-8?B?UUxMVjE0RGZDbkRTU3pkVk5SNTcvcklwamNIZXE5dnZKUktPdUp6L3V4WEhB?=
 =?utf-8?B?bG9kWlZ4eERxdjZMbTNuVDBFK2gwMTZ0NDZ1U1ErcCt3Ky95TWFrV1Q4RWN3?=
 =?utf-8?B?QmpLUWVHL21vWkZPTnJVSjBJVWhLMFdjK1FtbmNvaXIwb3ErRXRUcXJNYnJ1?=
 =?utf-8?B?OTluK3lHOCtick5uSjJnK2xWL25WbGFTalQzS2Y3dVNCR0FzZWpkaGE5cHh0?=
 =?utf-8?B?cE9oVUxNdjBUcEFmcHptMHZ0WEdTVWQ5UWJUNTlSTHlVWUtJVTU0M2xWSUt0?=
 =?utf-8?B?ZENSOVN4Z0FsTTVyS2ZKdTArWDBEYy8wWkwxL1p0VVIwRTVpOXJXdXBoUm9X?=
 =?utf-8?B?VDd2ZXhZbFlkNWt3ZXF3M3VHdm0xV3BCY25tU0pFL2IzalJwN0RmNlRIRHNG?=
 =?utf-8?B?VkZuZ29NNVV1cEo0anVhQVM5TjduclZwNHUzT2VRRG1teDJPL2ZMNWptSkxP?=
 =?utf-8?B?Z0wrWS92bCtrSy9UaDZZUkdaZTg1eFZsKzZOcVBKTW1aK24rQS9rMzN0aERk?=
 =?utf-8?B?a2pXSkNmWXZxdjRwZFJjL2lMdlQxZUgvQ0FSRUlXa053N1hmSlh1aTlTcStK?=
 =?utf-8?B?MGc3SHVQTHBnTk1Rb3RIQ1V5YXhqYVRWWWsxU2VJYUdEWFI5MURnMXovQ3Fq?=
 =?utf-8?B?VlJJczJtWEMrSmxOcUNDdWRBMG1yMnFKeFRjNnVTclZNbXBFVFovYzZjSlAz?=
 =?utf-8?B?ckFabWcxbkROVWxNNlpBSGZwMHZVK0hvc2dPN2lDbEFlWDB2Vks1ODIvMmUy?=
 =?utf-8?B?eFFMZnFVRjk3UHZqdVR4enRYVllhb2gwVnhZQmRPMDRkVEJRc2lYMTRkcGNE?=
 =?utf-8?B?TlZUN1A1Vlg4RjU3REprZDZtTVhMd2Foam5vaTdySzZaV2l0dGtQTGZzSWEw?=
 =?utf-8?B?THlBQmc1aFhvc056VkhTMnUvd1J6Y2Uwc1ZFQW9rZ1BLZ0c1WndSY21hR0U4?=
 =?utf-8?B?blVYdTdjSmlHNkZETGE3amdLM3c1Zm5YSFZyaDlnUnhMR0MvRHZuTDdDUVBZ?=
 =?utf-8?B?UE1WWjlLK3FsYkdFaENOZjdCWExCQWFtQmMvaE81Y1dvd2JQczdrMk1nb1Jq?=
 =?utf-8?B?eE0zWVY0dmJpVm1ZMEpzeEtDNmxQNU1Pa0RSTlNTdjRlS2hRa2JhQT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <BC083524A4E8BF48B68D03E60EFA0D84@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6ef655c3-f9fd-4667-7608-08d9ea395508
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Feb 2022 12:57:00.9351
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 9ifow1ic9dqnlq0yukzq+s+YMku1ruFMusRz3Whlf9zliJVSFePT+WZJMStwxBHAKSvSpaIlyvFKUnOXU+0KAzOg1cyKyen/pVZd/dyjjAieUT5FAip7VadUs050dUam
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR03MB7213
X-Proofpoint-GUID: nHxzycjJgjo-_NE9ysea566s9V9936rc
X-Proofpoint-ORIG-GUID: nHxzycjJgjo-_NE9ysea566s9V9936rc
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-07_04,2022-02-07_02,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 malwarescore=0
 mlxlogscore=670 lowpriorityscore=0 suspectscore=0 spamscore=0
 priorityscore=1501 impostorscore=0 bulkscore=0 clxscore=1015 adultscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202070083

DQoNCk9uIDA3LjAyLjIyIDE0OjM0LCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMDcuMDIuMjAy
MiAxMjowOCwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+PiAxLiB2cGNpX3tyZWFk
fHdyaXRlfSBhcmUgbm90IHByb3RlY3RlZCB3aXRoIHBjaWRldnNfbG9jayBhbmQgY2FuIHJ1biBp
bg0KPj4gcGFyYWxsZWwgd2l0aCBwY2lfcmVtb3ZlX2RldmljZSB3aGljaCBjYW4gcmVtb3ZlIHBk
ZXYgYWZ0ZXIgdnBjaV97cmVhZHx3cml0ZX0NCj4+IGFjcXVpcmVkIHRoZSBwZGV2IHBvaW50ZXIu
IFRoaXMgbWF5IGxlYWQgdG8gYSBmYWlsIGR1ZSB0byBwZGV2IGRlcmVmZXJlbmNlLg0KPj4NCj4+
IFNvLCB0byBwcm90ZWN0IHBkZXYgZGVyZWZlcmVuY2UgdnBjaV97cmVhZHx3cml0ZX0gbXVzdCBh
bHNvIHVzZSBwZGV2c19sb2NrLg0KPiBJIHRoaW5rIHRoaXMgaXMgbm90IHRoZSBvbmx5IHBsYWNl
IHdoZXJlIHRoZXJlIGlzIGEgdGhlb3JldGljYWwgcmFjZQ0KPiBhZ2FpbnN0IHBjaV9yZW1vdmVf
ZGV2aWNlKCkuDQpOb3QgYXQgYWxsLCB0aGF0IHdhcyBqdXN0IHRvIGRlbW9uc3RyYXRlIG9uZSBv
ZiB0aGUgcG9zc2libGUgc291cmNlcyBvZiByYWNlcy4NCj4gICBJIHdvdWxkIHJlY29tbWVuZCB0
byBzZXBhcmF0ZSB0aGUNCj4gb3ZlcmFsbCBzaXR1YXRpb24gd2l0aCBwY2lkZXZzX2xvY2sgZnJv
bSB0aGUgaXNzdWUgaGVyZS4NCkRvIHlvdSBhZ3JlZSB0aGF0IHRoZXJlIGlzIGFscmVhZHkgYW4g
aXNzdWUgd2l0aCB0aGF0PyBJbiB0aGUgY3VycmVudGx5IGV4aXN0aW5nIGNvZGU/DQo+ICAgSSBk
b24ndCB2aWV3DQo+IGl0IGFzIGFuIG9wdGlvbiB0byBhY3F1aXJlIHBjaWRldnNfbG9jayBpbiB2
cGNpX3tyZWFkLHdyaXRlfSgpLg0KWWVzLCB0aGF0IHdvdWxkIGh1cnQgdG9vIG11Y2gsIEkgYWdy
ZWUuIEJ1dCB0aGlzIG5lZWRzIHRvIGJlIHNvbHZlZA0KPiAgIElmDQo+IGFueXRoaW5nLCB3ZSBu
ZWVkIHByb3BlciByZWZjb3VudGluZyBvZiBQQ0kgZGV2aWNlcyAoYXQgd2hpY2ggcG9pbnQNCj4g
bGlrZWx5IGEgbnVtYmVyIG9mIGxvY2sgdXNlcyBjYW4gZ28gYXdheSkuDQpJdCBzZWVtcyBzby4g
VGhlbiBub3Qgb25seSBwZGV2J3MgbmVlZCByZWZjb3VudGluZywgYnV0IHBkZXYtPnZwY2kgYXMg
d2VsbA0KDQpXaGF0J3MgeW91ciB2aWV3IG9uIGhvdyBjYW4gd2UgYWNoaWV2ZSBib3RoIGdvYWxz
Pw0KcGRldiBhbmQgcGRldi0+dnBjaSBhbmQgbG9ja2luZy9yZWZjb3VudGluZw0KVGhpcyBpcyBy
ZWFsbHkgY3J1Y2lhbCBmb3IgYWxsIHRoZSBjb2RlIGZvciBQQ0kgcGFzc3Rocm91Z2ggb24gQXJt
IGJlY2F1c2UNCndpdGhvdXQgdGhpcyBncm91bmQgd29yayBkb25lIHdlIGNhbid0IGFjY2VwdCBh
bGwgdGhlIHBhdGNoZXMgd2hpY2ggcmVseQ0Kb24gdGhpczogdlBDSSBjaGFuZ2VzLCBNU0kvTVNJ
LVggZXRjLg0KPg0KPiBKYW4NCj4NClRoYW5rIHlvdSwNCk9sZWtzYW5kcg==


From xen-devel-bounces@lists.xenproject.org Mon Feb 07 13:02:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 13:02:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266895.460611 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH3ev-0007N3-Jc; Mon, 07 Feb 2022 13:02:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266895.460611; Mon, 07 Feb 2022 13:02:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH3ev-0007Mw-Gf; Mon, 07 Feb 2022 13:02:21 +0000
Received: by outflank-mailman (input) for mailman id 266895;
 Mon, 07 Feb 2022 13:02:19 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nH3et-0007Mm-QO; Mon, 07 Feb 2022 13:02:19 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nH3et-0002hX-Lp; Mon, 07 Feb 2022 13:02:19 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nH3et-00083p-7O; Mon, 07 Feb 2022 13:02:19 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nH3et-000739-6y; Mon, 07 Feb 2022 13:02:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=l8lAiu8XE83QY+IqmYmq0tF3cntGuIxCNsGkI79ctxo=; b=McSwVrP2Wmr3DTXW0oJD5f0S4j
	YcwuVOfWRZ3M8VdsSR6t25IL75UbEHC4UBpAAUKj1/dpu7Z68Kz/d4Y87J4p1hJXU8QyVqGRqaDbL
	eJluQppZ0fTGwl5GSe3gd9xC1e7u1Y+in32xQK+TZ6p3gr9nfJr7gzUhYjY1D/4P3RbE=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168044-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xtf test] 168044: all pass - PUSHED
X-Osstest-Versions-This:
    xtf=bc0abf2a5498d4691538bf34496ca0f0f189951b
X-Osstest-Versions-That:
    xtf=61e6f40b07d256bd62ae7b231a3eeecd49d0b15b
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 07 Feb 2022 13:02:19 +0000

flight 168044 xtf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168044/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 xtf                  bc0abf2a5498d4691538bf34496ca0f0f189951b
baseline version:
 xtf                  61e6f40b07d256bd62ae7b231a3eeecd49d0b15b

Last test of basis   165349  2021-10-04 12:43:20 Z  126 days
Testing same since   168044  2022-02-07 11:41:42 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>

jobs:
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-amd64-pvops                                            pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xtf.git
   61e6f40..bc0abf2  bc0abf2a5498d4691538bf34496ca0f0f189951b -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Mon Feb 07 13:02:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 13:02:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266900.460622 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH3fH-0007p1-04; Mon, 07 Feb 2022 13:02:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266900.460622; Mon, 07 Feb 2022 13:02:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH3fG-0007ou-TH; Mon, 07 Feb 2022 13:02:42 +0000
Received: by outflank-mailman (input) for mailman id 266900;
 Mon, 07 Feb 2022 13:02:41 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=owYM=SW=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nH3fE-0007l7-Nt
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 13:02:40 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 3abcf20c-8816-11ec-8eb8-a37418f5ba1a;
 Mon, 07 Feb 2022 14:02:40 +0100 (CET)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2051.outbound.protection.outlook.com [104.47.13.51]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-4-jEKGO2JvNpuZYuyOoA89pA-1; Mon, 07 Feb 2022 14:02:38 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM0PR0402MB3313.eurprd04.prod.outlook.com (2603:10a6:208:1c::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Mon, 7 Feb
 2022 13:02:35 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.018; Mon, 7 Feb 2022
 13:02:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3abcf20c-8816-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644238959;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=P4WWKhgOi3M36MYz/R47AZ5xPpJCEJa3GFJDXQgEYPk=;
	b=hz/vzqNQ8bDZe0C/N9/IJWJom5Byrop65eh+zC05b40tVm9jKEZ+9oAPGL8x7nDdOCuGL/
	SqP/F/M/ha/fgVdk4YL+vJU+TR0hiW3toe5/KeWsRRVKZUvT72wKdMVVN0TpsLvZKI0Q8b
	uDWGCOjJueH+G1VppRawflu7CRsNxYQ=
X-MC-Unique: jEKGO2JvNpuZYuyOoA89pA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=e1CpGsIWlQCn8KJ6AQp/b3ysDT5Q+UdZxzBaOyIYRXr+I/Hiozx9sNA6caTMDda3WaXb/Cjk1BoYfzTl/3wObESHnEUINlHs1laIuV5l4Dr7Dk+L/Amww+rFHXYxH0Q+00ISBC4s8n/8F1dvQn7ufYt3qKuts+WsFQ27m5QQbLPSB6p+3Pm8XvzurKi9QBOw1s7GcFptHfVF0oIf661UrvAKWhSwVVSm0dhBO1J3Zj7m5rFyMSSAY0E5VfH1ghXI6l+tzMcnQLV0OYbVuOrGmUTKdgPswp2bfwroS+ih8gmjqTDdNImD/mLjuKTt/Yt6Q73tuY4CIoL1tpseKWSXXA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=P4WWKhgOi3M36MYz/R47AZ5xPpJCEJa3GFJDXQgEYPk=;
 b=BjganenY7zv/VH/f9IR5rdIVfk0D+uvWrYjdfVPwopQRRtKTXJDK32BR3CNL43mver3CXljK8kDlej5hMONSxtIIWd6AhBMvMsj7kviHtPpGsm4AIGWZBaS+snrCtLfCaU5lCqMi7t6i2ZW9Fxu+W5Vwh1uSX2k71M5Unx53H8EhAze7e3cNACiaAhdVmvPvCqEsbE8XnfeV7oZy10Cx92gL/cvEw/jpxR/yQtpsO4dlbjEQjZgQo5NJVjGdnC+C0dVox+dqfARlF6K1w4sZtgdnK4bFGjjA/rPomp/atfayDcJ+GhNhzzQIznCMTYVdR/buDU4Wx56wljjgNCgLew==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <c51d671d-8ad5-591f-f21d-5af04220308e@suse.com>
Date: Mon, 7 Feb 2022 14:02:33 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Content-Language: en-US
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Cc: "julien@xen.org" <julien@xen.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Artem Mygaiev <Artem_Mygaiev@epam.com>,
 "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
 "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
 "paul@xen.org" <paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <04726915-f39f-9019-436e-4399533c9fc3@suse.com>
 <9ed3f4ac-0a2d-ed45-9872-7c3f356a469e@epam.com>
 <c3a99712-cf7c-37da-aac1-f2ee00e6d53b@suse.com>
 <Yf0KcVD8W05A4fbB@Air-de-Roger>
 <1ed0e342-16cd-2f16-c05c-186667a22762@suse.com>
 <7e3562b5-fc67-f213-e872-f211450d9e2e@epam.com>
 <a8fc599c-f620-c4d1-2077-c57068f46a7f@suse.com>
 <deef8468-d607-e49e-f456-6a8013329ca1@epam.com>
 <Yf0k6aoKK5G3iad1@Air-de-Roger>
 <3ad10a99-c706-b95f-1419-2c0c7cf37d58@epam.com>
 <Yf0+3C9nF8+tewLw@Air-de-Roger>
 <c5fea3bb-834b-eeb7-d7a1-1ee609037a9f@epam.com>
 <a71b7835-cbbb-74bd-d25d-6824f6f10683@suse.com>
 <6787ff3d-aea1-d2d6-a1dd-96e80a29b8b5@epam.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <6787ff3d-aea1-d2d6-a1dd-96e80a29b8b5@epam.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR0P281CA0012.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:15::17) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d7c9d32a-489c-4b4d-b9f0-08d9ea3a1c2f
X-MS-TrafficTypeDiagnostic: AM0PR0402MB3313:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR0402MB33132F85F40539C9C643E4D5B32C9@AM0PR0402MB3313.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	dWvL3kP1bOqWPnr/7PcYshRhH1Eig6wwSWVyp9RX3h4fvMeOKkn4kBgP1egdAfCDXyZ7RJBqrZgNvLScPoK8UySGHiE7bl9ssmyyjdgcv2Ix+BnjpBYGLHX13mPbvoaX1Vg6TaXtH7p9erZTYURDxXyBpnu5oJ8BC1uvqL5msADmBlEazwFVlc5ULRBdg7g1354sL1LAPe2AfMhR8MR5IqKgpTX8DiNLv9Qcoa5rXnPFkD2+0Ljjg282lmSf5KLcmwuM+qj11NHJZbDgHPXHsyl7RPBTaiGMUnN3vHgEDtxMI1wQ/aHp2wDoz4v7mYT6/SrtZTYkSPxNKhRp+ibJ/meQywYJjTLE5N4pgz1tPnlqgTcd4W1Q8TAhj9qG0AX4c8bAiI42gbh/DN2+ug1+Xdp10EXKVLd6XcQ70fDE6XJrLc6NfhZEKC8J0L4rp3tJVqBvkQnAXWq67Zu0LVGPfbv1tQMm4+bcfrKJCrKoJBrR1tNkQA3KW8UJfsaFbBLs92F8YaPrfys9rUcnNnp4kF065apZ5gBsRZcSRZHlof//7tJOakam4tI99JH/9u2m2UhWY2Nfzt40s6kvoatlygEsnPpMecpa4e5WiZLuSpQ6XIkvxWoRhu0aOkeOYJDblhD9AFNPtFmaplw9AkGYsFINwHdqr0Jm6WtljhBqF2qx/peuT9poWJw3AoTWxQ70qM+ZakMM+AqjbP0YNAOowqsJS6FsehLwsV/r/um4+5Q=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66476007)(508600001)(2906002)(6506007)(66556008)(8936002)(8676002)(6486002)(66946007)(38100700002)(4326008)(53546011)(86362001)(5660300002)(31686004)(6512007)(7416002)(2616005)(6916009)(26005)(186003)(83380400001)(316002)(54906003)(31696002)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?QUMzOXVHamE3MUozdmNrUGdsakk5SHdwcjNqbk9aTjdqSXU2cXFwY3NPakxk?=
 =?utf-8?B?VkhTcG1BelErK2ZZc2lqR2lvQTRpZ3dqMnRvQmdlWnFlMGlZQjJaeEFSaG9P?=
 =?utf-8?B?WVJDY3EzejNQVHovKzQrbzhpMlBJSjZIbUZLd0xzZVdISWhRMkhWOGRUZjYv?=
 =?utf-8?B?TlErNUdBeDB1MXQ3SDJWdzNwWHZTZkRyQWxMVnI3S0VweXMxYWR5VDJnUVRJ?=
 =?utf-8?B?TWRIWmxRMmJqMk1GVDdKSWo4cDZ6NzhMZVVIalJHNE9PWFhSeXpzdDJKOG51?=
 =?utf-8?B?WTBZUk1RS3g0Qk1uQXlkdW1WZzNuNUpEUkNwWjVsK2ZZKzFVQmFoUno3UFpJ?=
 =?utf-8?B?WmltU0tBYVJUclA5VS85eWhmaWxwNjYxOUhWV1dVQTdPZ0llUCtuMXdsRlMv?=
 =?utf-8?B?L0hiZHcvRkRnK2JIVmVvbURFd0FmdldkOVoycU9EMk9hRVJ6OXIzM2toLzhO?=
 =?utf-8?B?ZkpaRk5kNi8rSDlnVW1WNjVBV1p3bzhkSjdoZWxtbkRHd0dTOU43ZnZFYXpP?=
 =?utf-8?B?WWdJaUhqTitHVEJKTU9VaDJqL3dkQTdyREg5SXZ2RzhSVEw1VHlGQXdua29B?=
 =?utf-8?B?Q1V3RFhlZnFONElFaTBOL3BrbndLaGlkOHJtZW9hRHdDSCtFU1B6YUJNbFBx?=
 =?utf-8?B?Q0tuRnVtOWR4eWlxdDYvVEhsSHZVVXI0b011V1lhTWZEYWx6VlJGVGJqblhw?=
 =?utf-8?B?OEtKZGtuaWZjRkFBRWZzd2xLQnFkdHJLZmJaNVNReHFKUnNvN20rVWN4ekw4?=
 =?utf-8?B?eEU3M0NERjZzSXBzZnQzMUY3UEp1a1Bhdnk0RHdGRTVwMjF6eTE1ZHM1aFov?=
 =?utf-8?B?WVVZYXMwYzBTcCtzdzRxMHcrUHI3T2NOQlgrTk1DNk03RWRkbHFuckJRbjVT?=
 =?utf-8?B?b3lIVzY3ZmVYYnhFZm95eEpDQUs0TnRxSVdhL3FrSFg1ejhIOTg1UjJWeHRN?=
 =?utf-8?B?enZlQjdTeDlJc0dpUThMVy9Ua3gwMVN2RTRmRWZtK1AxdHNvR3pXb1d2OFFp?=
 =?utf-8?B?a2x3K2RGVGxpYzMzeXIwNGlXUWdmUVVoUnNHMWxwYWdMNURGVU1HY2t0Wm1L?=
 =?utf-8?B?cnpJMkJ5Y25BQTAzcDA3WElpYTZzZXFHR1J1bk10Q3dXM1JHcXA3dzllTmta?=
 =?utf-8?B?UFZ3Sy92amFzcHlKcE9jSldNdXFENnN4emRBL1pweG5jZnk5M3BmaGp4S3hr?=
 =?utf-8?B?YWdiOS9nTWhFcTY3akZjR1NPWTgrczJXbzVtZEZGYW5panMzUU92cVBNNWw2?=
 =?utf-8?B?aDZ2UUV1ckg1N1QzNk1LRThxQnU3bVpzbTM5VkhJeWVPVk1MNmI0Y240cHFM?=
 =?utf-8?B?VmVSeXFiR1NSWllYVHJjZS9QK3h3bm1TUFJZMFI5TWVYUGNNRVI0eHplN1lN?=
 =?utf-8?B?MGRUZGVzejA4cWw5b1NmZ0g0TzNtbEdjU0FVMDU3V0VtWDgvcnM1QStzRzJq?=
 =?utf-8?B?eXhtYThsQkY1cDBzSFFsQWZZbEVQSENyWmNhbmlFRFRXdjhXRTYxaWl0R0p3?=
 =?utf-8?B?WTkraitIdWJnNjUvM095MUlVaVdwWldPMmc4MEljV2tIQXhySStsRkRya01Q?=
 =?utf-8?B?b2dxdGxCRkg5bFJQeE1DeXVnMUQvTjV0WHdHd0xPYTNJaTZ4TDZ0RThnZlla?=
 =?utf-8?B?N2Q0aG0rOUhWVW1FaEtsS2xIM0Z3WHQ3RkIrM0tkTTV6Y1JYdUdoaUR1eUR5?=
 =?utf-8?B?NU1MLzFlSktHZitHRnZFN1VTVmErRTlCOWRNRSt3QlhJVjNLVnNpYmJKWDln?=
 =?utf-8?B?QldML3N6dXBmU3NQYWN5ckt4SWlybkZXUFBBanhHSUo4MmlJOW10MU9jT3Y3?=
 =?utf-8?B?bnVyYzdtQ0pGOXI4b3pmaGl6YXNyNVFMM1Q2Z1VaQ09CbGdkT0c0VkIxTm5y?=
 =?utf-8?B?aWpZSlN0K2NRTmxITWxwWWxUczBkQUVDU0s2dXNtV1NQMUFaVlpjUHdpRFlV?=
 =?utf-8?B?RjBuZERESTArYUh2TE5WQm9qanNjWHRBZWNsR3FYNXJrbFJpbU1aV0QzWE5L?=
 =?utf-8?B?WFdQeW1wQ1cvbTV6TFREM0JpNjV0c2FUNC9MVWJIRldCUU5LUXJ6RE9DdzBN?=
 =?utf-8?B?WUpvTGoxSURDMUl6UTQwV3N2c0JHdXdkZDJGbzFCeDE5TnE0blFLelZaZURJ?=
 =?utf-8?B?S0VLTXJXajl6ZVpOUEYxa21IN3hhVjgwb3NSbWgxSjY5SFFTZnZicHI0LzJR?=
 =?utf-8?Q?+rdhCIc2P25lDRHdqFE/sbE=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d7c9d32a-489c-4b4d-b9f0-08d9ea3a1c2f
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2022 13:02:35.2934
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Eufm4RBkDHMVJ5wcuRBl25gg2nsy2yrFp7NZupn8ZYmfWuafpSjZ/1SIAMR+GrYdU1BC+MDB2ScYJgzw+ujCGg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0402MB3313

On 07.02.2022 13:57, Oleksandr Andrushchenko wrote:
> 
> 
> On 07.02.22 14:34, Jan Beulich wrote:
>> On 07.02.2022 12:08, Oleksandr Andrushchenko wrote:
>>> 1. vpci_{read|write} are not protected with pcidevs_lock and can run in
>>> parallel with pci_remove_device which can remove pdev after vpci_{read|write}
>>> acquired the pdev pointer. This may lead to a fail due to pdev dereference.
>>>
>>> So, to protect pdev dereference vpci_{read|write} must also use pdevs_lock.
>> I think this is not the only place where there is a theoretical race
>> against pci_remove_device().
> Not at all, that was just to demonstrate one of the possible sources of races.
>>   I would recommend to separate the
>> overall situation with pcidevs_lock from the issue here.
> Do you agree that there is already an issue with that? In the currently existing code?
>>   I don't view
>> it as an option to acquire pcidevs_lock in vpci_{read,write}().
> Yes, that would hurt too much, I agree. But this needs to be solved
>>   If
>> anything, we need proper refcounting of PCI devices (at which point
>> likely a number of lock uses can go away).
> It seems so. Then not only pdev's need refcounting, but pdev->vpci as well
> 
> What's your view on how can we achieve both goals?
> pdev and pdev->vpci and locking/refcounting

I don't see why pdev->vpci might need refcounting. And just to state it
in different words: I'd like to suggest to leave aside the pdev locking
as long as it's _just_ to protect against hot remove of a device. That's
orthogonal to what you need for vPCI, where you need to protect
against the device disappearing from a guest (without at the same time
disappearing from the host).

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 07 13:53:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 13:53:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266951.460649 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH4Sh-0004v8-9d; Mon, 07 Feb 2022 13:53:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266951.460649; Mon, 07 Feb 2022 13:53:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH4Sh-0004v1-6T; Mon, 07 Feb 2022 13:53:47 +0000
Received: by outflank-mailman (input) for mailman id 266951;
 Mon, 07 Feb 2022 13:53:46 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=F54n=SW=epam.com=prvs=403792ff6c=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nH4Sg-0004uv-0N
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 13:53:46 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 567d4182-881d-11ec-8f75-fffcc8bd4f1a;
 Mon, 07 Feb 2022 14:53:34 +0100 (CET)
Received: from pps.filterd (m0174676.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 217Dm9A1019379;
 Mon, 7 Feb 2022 13:53:38 GMT
Received: from eur05-db8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2110.outbound.protection.outlook.com [104.47.17.110])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e2w1r20r1-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Mon, 07 Feb 2022 13:53:38 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by DBBPR03MB6777.eurprd03.prod.outlook.com (2603:10a6:10:205::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Mon, 7 Feb
 2022 13:53:34 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77%3]) with mapi id 15.20.4951.018; Mon, 7 Feb 2022
 13:53:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 567d4182-881d-11ec-8f75-fffcc8bd4f1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=mxtcviru0bND9VXyWEcTB6LEdiK6Ddy1lLopw7uDYn7B8x3ddCkacQbTYM7Ie6VLx906o2eEHA5iTX7I9OTvYcIO5VQ2CxJHBwoECze1Ian+7+tgpvKHkT8P/LW+hME4wkOu3oyEAWstgaobz+ihNlvt20f0ViHSBWc7gpTP9MxK66HhpdnaROc+Tg2w+gWmyUU9m3co8LOt3UoccaDyVF5wJIbyvgfCCzxHFdj0S9IBtEfoiTLGEJ/R14FYekHZeZSSMWSU32yy7Z7CcZf8UZGxDYnv95VALf2UsjUNlp4TCHpXgoGRvlhzQfAnDd1RxIDnTGiLjOJN+z7Fds0gKQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=i9BpWkJI0qKeVQk+iJq1PdNxbNzJBvxpV5JA6TXAlYQ=;
 b=CjLXIn5OfpvTwNoc5P6uXLF14mWY+Hgbpqn4GCBm0gMqjTb4cInh+oJg510MeJ3C0aY4TTva/o7s0FRQyQENedMrCr3/rQwuCsST4CAbUzFJe1vUFLA/MzwDyZ/U11rH4oL5Ojd5puAk38QAJNHO3+5wTkkohYtGvDj7IHCh7WJAN1wSXi6F5cbFCW8Qb7lRCI8FnPwLSDcldEtd/6fUHJ/CafHjN/jQRCMire/kryQFsgggw4DCgjv5NagkRPa3xBd7UOFBHL8ODeAZAMdbdBjJZAQgT1L05qoMIx44qbNiy/FcXVaoLUQ4zfmJIopJu05tBGphUwhvioycfKhCsA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=i9BpWkJI0qKeVQk+iJq1PdNxbNzJBvxpV5JA6TXAlYQ=;
 b=UfnbM1ZIcI4oP0qlqos88vOkdJqv/kfU1hAJ+01RlHkI445+7Huf3DpYFGDj5h7T5fwNyX+pYmpauiDbqEH+4ke/v5dEUmrwj64PjU8sHpLwbU5MEO7KC7Y9TpuYQX7crOXhswwbRiaSlVIt9onQ4PZ1+Y1kF6AGZfLFSEKBvqm9r7HiP13S4wxy77dcePCuEBKwvXvbX1D5GYl24ZPzyXyk2gSH0nvmkzlNQloYl00LB1yXUJ1jMBGIlUu3EjShFufW7zSuKbuLcdvHCl+ITpiR43WqO9ttHtV8ajRgY5PSREP7b7UE/dhHGmZhNaSXdvkaKOhGIoTDb3HwrjPFiA==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>,
        Jan Beulich
	<jbeulich@suse.com>
CC: "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Thread-Topic: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Thread-Index: 
 AQHYGZFc/MnzQOjwVEeBBUHLSW0md6yDBUkAgAASSACAAATYAIAAD/WAgAAKNgCAAAbfgIAABnuAgAAQvgCAAAMCAIAAAY4AgAADxICAABrnAIAABAgAgAR3CoCAABt5gIAAEpuA
Date: Mon, 7 Feb 2022 13:53:34 +0000
Message-ID: <9ce90193-74a0-5642-d22b-6b8c3340c3cf@epam.com>
References: <c3a99712-cf7c-37da-aac1-f2ee00e6d53b@suse.com>
 <Yf0KcVD8W05A4fbB@Air-de-Roger>
 <1ed0e342-16cd-2f16-c05c-186667a22762@suse.com>
 <7e3562b5-fc67-f213-e872-f211450d9e2e@epam.com>
 <a8fc599c-f620-c4d1-2077-c57068f46a7f@suse.com>
 <deef8468-d607-e49e-f456-6a8013329ca1@epam.com>
 <Yf0k6aoKK5G3iad1@Air-de-Roger>
 <3ad10a99-c706-b95f-1419-2c0c7cf37d58@epam.com>
 <Yf0+3C9nF8+tewLw@Air-de-Roger>
 <c5fea3bb-834b-eeb7-d7a1-1ee609037a9f@epam.com>
 <YgEUwTxhnWVMGMJK@Air-de-Roger>
In-Reply-To: <YgEUwTxhnWVMGMJK@Air-de-Roger>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 18c0a388-fb8a-4c03-20d9-08d9ea413bc3
x-ms-traffictypediagnostic: DBBPR03MB6777:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <DBBPR03MB6777BA2975157C6DB8E59B3BE72C9@DBBPR03MB6777.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 BaW2lP8c6SmO/xEoO+Ag9XneN9K+m3t27XOcKVpFyPWGCbj4KSTO+keLRN7Nxei5gU9+RVY9PlK2pEMKQ6HXPpcIYSUN+MgH0IjOH/qfpLjf899LQ5Go4Eb8223EwM4vNeLHYYgjRj18bd98vWhVusJOUz2rAegHxieTvCMItvkKncRtpbETOHuucRsyCKwAO9NT6Z1IvOSgD2CH+BX76yEhXrd16oSJVmpq0fkZV4zJMzTgN5l8I3i0RKWu6E84096/c3YaJa7cxIrTUfJQvLli972cWtxLSSKaOQRA8WmHNJMpSjIMiiZCe96iipfhFCNmVDqMmLTB7oLl++lNcOd/akWhxYjslnVhy5YJMdx3VLSSm4jdYAQHzxaOn/8gsZ8FIVnZ1IwtFjA8RsdyE6sjxmvZ8quI/M+aKamD47aNlKizK8S8W4+welCD2FP5AYtD7hf0dj/GX4YhQKy5RzplCK/cxBl54Ik74QHr3qzZ3BWoWes5aapVnLX0YQW/waqHrXq0xJQZRtgbUSEM/74uyrp1WIUfkjcr0hzB8hWk12vnFQyV71XJE/1Bv3I2Ryyfyi2CT/8iyhZsI4HFDzF6kMYO8w/9s+omzvx7fBN2u6oyvLEUCeArT+1S8vCT767uwvp5o+l7+gzKCvq+Gmu4+h3oUgLcCTVbXCXj6XwDspSvn0YtqHlIAFS1/7ChR0QJNVxK2eV8TV1cnxTmGN6RjJ2Lxj6aMkzaawT/VtqhoD7U47Q60sydW0gqfOK8
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(5660300002)(107886003)(2906002)(83380400001)(30864003)(6486002)(7416002)(55236004)(53546011)(36756003)(31686004)(26005)(2616005)(71200400001)(6506007)(508600001)(6512007)(186003)(38070700005)(54906003)(38100700002)(31696002)(66946007)(86362001)(66476007)(66556008)(316002)(4326008)(64756008)(66446008)(110136005)(76116006)(122000001)(8936002)(8676002)(91956017)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?eGVISlExOUoxL2I4VUo5MUkrRkVmbnUrQXIrWU1mUWdXUjlJaUhOQkpXOHk3?=
 =?utf-8?B?bzZnblhZREFHTk1LTHdkQnFnazQ1eFhQMUlLbzFadGswZnUrQUtQLzVnREpY?=
 =?utf-8?B?cWlVREVObTIySWZHZCtTOXpyWXZ0U1FTbkI3QXAxcWVUV2NzNWE4bjhNNENN?=
 =?utf-8?B?N0w5MEpwSGFnTGJvaUsxeDBKUS9KdGtmcksvcmgyZ3VDM2wzQ2VGZEJENVhK?=
 =?utf-8?B?aUVLQnNUTXhLRGtOdVM5bk9HamZwOEdBRWliWFhUWTZTR01ONGJmcVNLdjFD?=
 =?utf-8?B?R3poTngreDRkVVBrblJtbHMwWkpJTEh4NjhmMktWeStvS1puMmFlNlBrZVY5?=
 =?utf-8?B?YUJKbDUrRjErTU1WSk9va3lBYWZncm0wMkphMlViVXZCcVlNN3Q0NUVVQ0Fa?=
 =?utf-8?B?cnZ6V3d3YWMzVVFMcEZQUERNaUZ4cThpa00xcFd4SCs5Z0xWeW5EYmlacTA5?=
 =?utf-8?B?RUxrSEhJcnFZaTlLR1EwVVdUbm1nZlF2Yk1CVnJXbFNBZXR4cFhIdHprUVNM?=
 =?utf-8?B?djM5VzZ4Vy90RTR5Nms3MDVLRlpsSXNheWsrenRTcGljMEtPa05BcEEwWXBo?=
 =?utf-8?B?MWVZbVZzZkNhS1k4MDBSYVlVWklvM0sxNWJ0QmNISmNtS3lsTytXT1l2cGcx?=
 =?utf-8?B?eWREeXJqck4yb0pHVDBaS3pIWVdDTXdvRGFkdGtLMDgvMHNFaFF1WUIvaUoz?=
 =?utf-8?B?Zm9IMXcxYjdoWDNrOGJlZXpLTElmK0RLdmsxSDJESVJoYmp3U0hVK0RqVnEr?=
 =?utf-8?B?VjhxU0xBY24xcHZsTTE1ZExTaXpXelNCUW1KdWtxaFQxWVZkeUFDQi9INXZm?=
 =?utf-8?B?cmF1d2lJMFhsdmVON1ZZeURZaUx5QUJ2enhLZ0FYZFdoalk0QmQyUFppVmlv?=
 =?utf-8?B?eU13R1J1N1RQMXIyTVV3bi9iZ0VLeE1ZWUJwRlV2SENtN3ZLN0tqSjBQU3VH?=
 =?utf-8?B?SktLUmFtSmp5R09jM29yQ0dKZGJ4aExjemR0RlphNE8rd2UxaE1uZ2JXbjlv?=
 =?utf-8?B?TEtvV2JOT3dFU0tRYlNzYXZuRXJxanFMRmJKRCs2TVN2WHV2WGRFcXdZcnhq?=
 =?utf-8?B?L2JXeXkwdVUrUDVqUGdoSTVVT0hHR254d2w3dEsvVE5hcVRHb1RpcGYyRnJI?=
 =?utf-8?B?Z0J2WUEyVW9uOGgxRnFGVW5POUNBbGkwdXRpYnlIdU5kckxuc0JPakk2Q2dz?=
 =?utf-8?B?NEVxSDdISjAvYkxZbDV6aUdMajNLeGdqaUk0dTRuK244TzhPV3pidnR4bTJD?=
 =?utf-8?B?R3JNcVVXM3pnOGdmMGxmQ2E0ZGRyeG1LTVVtV1g4dE5oVlNOTXhWK3poRUxn?=
 =?utf-8?B?VEhPckxndXZFZFdDSDJjOFVDRDIyeXZiR0hoR3lkUVRCUjU5cXJTMUxSL3g4?=
 =?utf-8?B?bE1qNnY0d3R5WFZ4V0NWT1U3akRSd0dodStrS0Z6SnhPM3MxZmJZR3B3UTJP?=
 =?utf-8?B?TUNWWG9MUFhDV3JxQVNRMGtOdTRLYkdBK3dHQXlCOFNvSFlyQ2dFV2dDbTJV?=
 =?utf-8?B?cDkzclM1TWpOdzhod3ZZOXhwdEJoa1VueEpNM0tJSWppeTdLNnhiSnVKdEhT?=
 =?utf-8?B?dUx4SVUwSlhVYkQ1dExCZ3h5OC9hQ1ZJbStCTFB3U2JrcWVGaTZrSGxSc3Fh?=
 =?utf-8?B?RjlQSnhjR09mN2RSYWJkbnRsaTVHZTF6YXdsZ2Y0WU5seFVIMG9KMVpjNHY2?=
 =?utf-8?B?Si9WUlJxUEN0bG1lKzNKZWliWU45dGxqckI2SGY2RWFkemtCTlo1ZVVKSVdV?=
 =?utf-8?B?RWlqYXhCb0lidk9wQ3AyYVVUM3RsYUZ0RSsyWWkvU1NBN3ppaTlVMGpUTFo2?=
 =?utf-8?B?L0ZVOGFpek10V2ptUXZCT0hQemlEb3hMN2xNc2pTTzRvNXVYMEtPWXVrUnRk?=
 =?utf-8?B?ZkdFMWlZOVN3aU9XWW53VzRUcUwvUzd6UjFKMERDQnIwY3pEMmRrWUNyRHlR?=
 =?utf-8?B?UHd3Uy9QK21rSVdxNXZkY3QyQzREM01peDdaK2hNVU03VE5yQW1GZkFBcTlL?=
 =?utf-8?B?czNsNGZRdi9XTFNiZXVjb28xbTIyMGpoUGd0TDJIRTVBZ1U4ZlNRVG1kQS9i?=
 =?utf-8?B?akIwWlZlZisrQlZHaEs2dWRSZkR6akZqT0NYZzhKSEk2RS9xOURNUFJzUUdO?=
 =?utf-8?B?M3VvL0M3UVhLWVRPaEYwOGpKYTJaOWFLR3pEQW44TkRJU3RNT2ZmcUYycWVy?=
 =?utf-8?B?SkNQY2ZUMllFZThCS0VrSllHOWZzc3JXcW5QRGZrei92NUl6NFI2SGZ0Skxn?=
 =?utf-8?B?THVVYTJncU1uVmw1Qll6TFdjUEtuMkhNdEdWS2w4aUVHOGZsd3FlOWF2MnRy?=
 =?utf-8?B?aFJLMEVpUXJzRy9PamdybHFYMmJ1d1cwUGdWQngzcU14bEVDVStBQT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <7F27F0B1B7810F42A96B157F8C074390@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 18c0a388-fb8a-4c03-20d9-08d9ea413bc3
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Feb 2022 13:53:34.4803
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: APkMHNEe6KlTDjWzqlAIufLJJXjhvmQ4Y1EOyO4qb/Yo3b9LyFMJ/qVm1/9mJWNQ/RV8+a0TJwDuV/Yc5YqJ60e4ZKHijC2WsDwW8wjhqL6JxUJXkaqnRiQWlVuNpGMN
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR03MB6777
X-Proofpoint-ORIG-GUID: m15yaJP7NnVIcyOsjXPehtmJss4v7uZr
X-Proofpoint-GUID: m15yaJP7NnVIcyOsjXPehtmJss4v7uZr
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-07_05,2022-02-07_02,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 adultscore=0
 clxscore=1015 impostorscore=0 phishscore=0 priorityscore=1501 bulkscore=0
 spamscore=0 mlxscore=0 malwarescore=0 suspectscore=0 lowpriorityscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2202070090

DQoNCk9uIDA3LjAyLjIyIDE0OjQ2LCBSb2dlciBQYXUgTW9ubsOpIHdyb3RlOg0KPiBPbiBNb24s
IEZlYiAwNywgMjAyMiBhdCAxMTowODozOUFNICswMDAwLCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5r
byB3cm90ZToNCj4+IEhlbGxvLA0KPj4NCj4+IE9uIDA0LjAyLjIyIDE2OjU3LCBSb2dlciBQYXUg
TW9ubsOpIHdyb3RlOg0KPj4+IE9uIEZyaSwgRmViIDA0LCAyMDIyIGF0IDAyOjQzOjA3UE0gKzAw
MDAsIE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4+PiBPbiAwNC4wMi4yMiAxNTow
NiwgUm9nZXIgUGF1IE1vbm7DqSB3cm90ZToNCj4+Pj4+IE9uIEZyaSwgRmViIDA0LCAyMDIyIGF0
IDEyOjUzOjIwUE0gKzAwMDAsIE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4+Pj4+
IE9uIDA0LjAyLjIyIDE0OjQ3LCBKYW4gQmV1bGljaCB3cm90ZToNCj4+Pj4+Pj4gT24gMDQuMDIu
MjAyMiAxMzozNywgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+Pj4+Pj4+PiBPbiAw
NC4wMi4yMiAxMzozNywgSmFuIEJldWxpY2ggd3JvdGU6DQo+Pj4+Pj4+Pj4gT24gMDQuMDIuMjAy
MiAxMjoxMywgUm9nZXIgUGF1IE1vbm7DqSB3cm90ZToNCj4+Pj4+Pj4+Pj4gT24gRnJpLCBGZWIg
MDQsIDIwMjIgYXQgMTE6NDk6MThBTSArMDEwMCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+Pj4+Pj4+
Pj4+PiBPbiAwNC4wMi4yMDIyIDExOjEyLCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyB3cm90ZToN
Cj4+Pj4+Pj4+Pj4+PiBPbiAwNC4wMi4yMiAxMToxNSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+Pj4+
Pj4+Pj4+Pj4+IE9uIDA0LjAyLjIwMjIgMDk6NTgsIE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIHdy
b3RlOg0KPj4+Pj4+Pj4+Pj4+Pj4gT24gMDQuMDIuMjIgMDk6NTIsIEphbiBCZXVsaWNoIHdyb3Rl
Og0KPj4+Pj4+Pj4+Pj4+Pj4+IE9uIDA0LjAyLjIwMjIgMDc6MzQsIE9sZWtzYW5kciBBbmRydXNo
Y2hlbmtvIHdyb3RlOg0KPj4+Pj4+Pj4+Pj4+Pj4+PiBAQCAtMjg1LDYgKzI4NiwxMiBAQCBzdGF0
aWMgaW50IG1vZGlmeV9iYXJzKGNvbnN0IHN0cnVjdCBwY2lfZGV2ICpwZGV2LCB1aW50MTZfdCBj
bWQsIGJvb2wgcm9tX29ubHkpDQo+Pj4+Pj4+Pj4+Pj4+Pj4+ICAgICAgICAgICAgICAgICAgICAg
ICAgIGNvbnRpbnVlOw0KPj4+Pj4+Pj4+Pj4+Pj4+PiAgICAgICAgICAgICAgICAgfQ0KPj4+Pj4+
Pj4+Pj4+Pj4+PiAgICAgICAgIA0KPj4+Pj4+Pj4+Pj4+Pj4+PiArICAgICAgICBzcGluX2xvY2so
JnRtcC0+dnBjaV9sb2NrKTsNCj4+Pj4+Pj4+Pj4+Pj4+Pj4gKyAgICAgICAgaWYgKCAhdG1wLT52
cGNpICkNCj4+Pj4+Pj4+Pj4+Pj4+Pj4gKyAgICAgICAgew0KPj4+Pj4+Pj4+Pj4+Pj4+PiArICAg
ICAgICAgICAgc3Bpbl91bmxvY2soJnRtcC0+dnBjaV9sb2NrKTsNCj4+Pj4+Pj4+Pj4+Pj4+Pj4g
KyAgICAgICAgICAgIGNvbnRpbnVlOw0KPj4+Pj4+Pj4+Pj4+Pj4+PiArICAgICAgICB9DQo+Pj4+
Pj4+Pj4+Pj4+Pj4+ICAgICAgICAgICAgICAgICBmb3IgKCBpID0gMDsgaSA8IEFSUkFZX1NJWkUo
dG1wLT52cGNpLT5oZWFkZXIuYmFycyk7IGkrKyApDQo+Pj4+Pj4+Pj4+Pj4+Pj4+ICAgICAgICAg
ICAgICAgICB7DQo+Pj4+Pj4+Pj4+Pj4+Pj4+ICAgICAgICAgICAgICAgICAgICAgY29uc3Qgc3Ry
dWN0IHZwY2lfYmFyICpiYXIgPSAmdG1wLT52cGNpLT5oZWFkZXIuYmFyc1tpXTsNCj4+Pj4+Pj4+
Pj4+Pj4+Pj4gQEAgLTMwMywxMiArMzEwLDE0IEBAIHN0YXRpYyBpbnQgbW9kaWZ5X2JhcnMoY29u
c3Qgc3RydWN0IHBjaV9kZXYgKnBkZXYsIHVpbnQxNl90IGNtZCwgYm9vbCByb21fb25seSkNCj4+
Pj4+Pj4+Pj4+Pj4+Pj4gICAgICAgICAgICAgICAgICAgICByYyA9IHJhbmdlc2V0X3JlbW92ZV9y
YW5nZShtZW0sIHN0YXJ0LCBlbmQpOw0KPj4+Pj4+Pj4+Pj4+Pj4+PiAgICAgICAgICAgICAgICAg
ICAgIGlmICggcmMgKQ0KPj4+Pj4+Pj4+Pj4+Pj4+PiAgICAgICAgICAgICAgICAgICAgIHsNCj4+
Pj4+Pj4+Pj4+Pj4+Pj4gKyAgICAgICAgICAgICAgICBzcGluX3VubG9jaygmdG1wLT52cGNpX2xv
Y2spOw0KPj4+Pj4+Pj4+Pj4+Pj4+PiAgICAgICAgICAgICAgICAgICAgICAgICBwcmludGsoWEVO
TE9HX0dfV0FSTklORyAiRmFpbGVkIHRvIHJlbW92ZSBbJWx4LCAlbHhdOiAlZFxuIiwNCj4+Pj4+
Pj4+Pj4+Pj4+Pj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0YXJ0LCBlbmQsIHJj
KTsNCj4+Pj4+Pj4+Pj4+Pj4+Pj4gICAgICAgICAgICAgICAgICAgICAgICAgcmFuZ2VzZXRfZGVz
dHJveShtZW0pOw0KPj4+Pj4+Pj4+Pj4+Pj4+PiAgICAgICAgICAgICAgICAgICAgICAgICByZXR1
cm4gcmM7DQo+Pj4+Pj4+Pj4+Pj4+Pj4+ICAgICAgICAgICAgICAgICAgICAgfQ0KPj4+Pj4+Pj4+
Pj4+Pj4+PiAgICAgICAgICAgICAgICAgfQ0KPj4+Pj4+Pj4+Pj4+Pj4+PiArICAgICAgICBzcGlu
X3VubG9jaygmdG1wLT52cGNpX2xvY2spOw0KPj4+Pj4+Pj4+Pj4+Pj4+PiAgICAgICAgICAgICB9
DQo+Pj4+Pj4+Pj4+Pj4+Pj4gQXQgdGhlIGZpcnN0IGdsYW5jZSB0aGlzIHNpbXBseSBsb29rcyBs
aWtlIGFub3RoZXIgdW5qdXN0aWZpZWQgKGluIHRoZQ0KPj4+Pj4+Pj4+Pj4+Pj4+IGRlc2NyaXB0
aW9uKSBjaGFuZ2UsIGFzIHlvdSdyZSBub3QgY29udmVydGluZyBhbnl0aGluZyBoZXJlIGJ1dCB5
b3UNCj4+Pj4+Pj4+Pj4+Pj4+PiBhY3R1YWxseSBhZGQgbG9ja2luZyAoYW5kIEkgcmVhbGl6ZSB0
aGlzIHdhcyB0aGVyZSBiZWZvcmUsIHNvIEknbSBzb3JyeQ0KPj4+Pj4+Pj4+Pj4+Pj4+IGZvciBu
b3QgcG9pbnRpbmcgdGhpcyBvdXQgZWFybGllcikuDQo+Pj4+Pj4+Pj4+Pj4+PiBXZWxsLCBJIHRo
b3VnaHQgdGhhdCB0aGUgZGVzY3JpcHRpb24gYWxyZWFkeSBoYXMgIi4uLnRoZSBsb2NrIGNhbiBi
ZQ0KPj4+Pj4+Pj4+Pj4+Pj4gdXNlZCAoYW5kIGluIGEgZmV3IGNhc2VzIGlzIHVzZWQgcmlnaHQg
YXdheSkgdG8gY2hlY2sgd2hldGhlciB2cGNpDQo+Pj4+Pj4+Pj4+Pj4+PiBpcyBwcmVzZW50IiBh
bmQgdGhpcyBpcyBlbm91Z2ggZm9yIHN1Y2ggdXNlcyBhcyBoZXJlLg0KPj4+Pj4+Pj4+Pj4+Pj4+
ICAgICAgICAgQnV0IHRoZW4gSSB3b25kZXIgd2hldGhlciB5b3UNCj4+Pj4+Pj4+Pj4+Pj4+PiBh
Y3R1YWxseSB0ZXN0ZWQgdGhpcywgc2luY2UgSSBjYW4ndCBoZWxwIGdldHRpbmcgdGhlIGltcHJl
c3Npb24gdGhhdA0KPj4+Pj4+Pj4+Pj4+Pj4+IHlvdSdyZSBpbnRyb2R1Y2luZyBhIGxpdmUtbG9j
azogVGhlIGZ1bmN0aW9uIGlzIGNhbGxlZCBmcm9tIGNtZF93cml0ZSgpDQo+Pj4+Pj4+Pj4+Pj4+
Pj4gYW5kIHJvbV93cml0ZSgpLCB3aGljaCBpbiB0dXJuIGFyZSBjYWxsZWQgb3V0IG9mIHZwY2lf
d3JpdGUoKS4gWWV0IHRoYXQNCj4+Pj4+Pj4+Pj4+Pj4+PiBmdW5jdGlvbiBhbHJlYWR5IGhvbGRz
IHRoZSBsb2NrLCBhbmQgdGhlIGxvY2sgaXMgbm90IChjdXJyZW50bHkpDQo+Pj4+Pj4+Pj4+Pj4+
Pj4gcmVjdXJzaXZlLiAoRm9yIHRoZSAzcmQgY2FsbGVyIG9mIHRoZSBmdW5jdGlvbiAtIGluaXRf
YmFycygpIC0gb3RvaA0KPj4+Pj4+Pj4+Pj4+Pj4+IHRoZSBsb2NraW5nIGxvb2tzIHRvIGJlIGVu
dGlyZWx5IHVubmVjZXNzYXJ5LikNCj4+Pj4+Pj4+Pj4+Pj4+IFdlbGwsIHlvdSBhcmUgY29ycmVj
dDogaWYgdG1wICE9IHBkZXYgdGhlbiBpdCBpcyBjb3JyZWN0IHRvIGFjcXVpcmUNCj4+Pj4+Pj4+
Pj4+Pj4+IHRoZSBsb2NrLiBCdXQgaWYgdG1wID09IHBkZXYgYW5kIHJvbV9vbmx5ID09IHRydWUN
Cj4+Pj4+Pj4+Pj4+Pj4+IHRoZW4gd2UnbGwgZGVhZGxvY2suDQo+Pj4+Pj4+Pj4+Pj4+Pg0KPj4+
Pj4+Pj4+Pj4+Pj4gSXQgc2VlbXMgd2UgbmVlZCB0byBoYXZlIHRoZSBsb2NraW5nIGNvbmRpdGlv
bmFsLCBlLmcuIG9ubHkgbG9jaw0KPj4+Pj4+Pj4+Pj4+Pj4gaWYgdG1wICE9IHBkZXYNCj4+Pj4+
Pj4+Pj4+Pj4gV2hpY2ggd2lsbCBhZGRyZXNzIHRoZSBsaXZlLWxvY2ssIGJ1dCBpbnRyb2R1Y2Ug
QUJCQSBkZWFkbG9jayBwb3RlbnRpYWwNCj4+Pj4+Pj4+Pj4+Pj4gYmV0d2VlbiB0aGUgdHdvIGxv
Y2tzLg0KPj4+Pj4+Pj4+Pj4+IEkgYW0gbm90IHN1cmUgSSBjYW4gc3VnZ2VzdCBhIGJldHRlciBz
b2x1dGlvbiBoZXJlDQo+Pj4+Pj4+Pj4+Pj4gQFJvZ2VyLCBASmFuLCBjb3VsZCB5b3UgcGxlYXNl
IGhlbHAgaGVyZT8NCj4+Pj4+Pj4+Pj4+IFdlbGwsIGZpcnN0IG9mIGFsbCBJJ2QgbGlrZSB0byBt
ZW50aW9uIHRoYXQgd2hpbGUgaXQgbWF5IGhhdmUgYmVlbiBva2F5IHRvDQo+Pj4+Pj4+Pj4+PiBu
b3QgaG9sZCBwY2lkZXZzX2xvY2sgaGVyZSBmb3IgRG9tMCwgaXQgc3VyZWx5IG5lZWRzIGFjcXVp
cmluZyB3aGVuIGRlYWxpbmcNCj4+Pj4+Pj4+Pj4+IHdpdGggRG9tVS1zJyBsaXN0cyBvZiBQQ0kg
ZGV2aWNlcy4gVGhlIHJlcXVpcmVtZW50IHJlYWxseSBhcHBsaWVzIHRvIHRoZQ0KPj4+Pj4+Pj4+
Pj4gb3RoZXIgdXNlIG9mIGZvcl9lYWNoX3BkZXYoKSBhcyB3ZWxsIChpbiB2cGNpX2R1bXBfbXNp
KCkpLCBleGNlcHQgdGhhdA0KPj4+Pj4+Pj4+Pj4gdGhlcmUgaXQgcHJvYmFibHkgd2FudHMgdG8g
YmUgYSB0cnktbG9jay4NCj4+Pj4+Pj4+Pj4+DQo+Pj4+Pj4+Pj4+PiBOZXh0IEknZCBsaWtlIHRv
IHBvaW50IG91dCB0aGF0IGhlcmUgd2UgaGF2ZSB0aGUgc3RpbGwgcGVuZGluZyBpc3N1ZSBvZg0K
Pj4+Pj4+Pj4+Pj4gaG93IHRvIGRlYWwgd2l0aCBoaWRkZW4gZGV2aWNlcywgd2hpY2ggRG9tMCBj
YW4gYWNjZXNzLiBTZWUgbXkgUkZDIHBhdGNoDQo+Pj4+Pj4+Pj4+PiAidlBDSTogYWNjb3VudCBm
b3IgaGlkZGVuIGRldmljZXMgaW4gbW9kaWZ5X2JhcnMoKSIuIFdoYXRldmVyIHRoZSBzb2x1dGlv
bg0KPj4+Pj4+Pj4+Pj4gaGVyZSwgSSB0aGluayBpdCB3YW50cyB0byBhdCBsZWFzdCBhY2NvdW50
IGZvciB0aGUgZXh0cmEgbmVlZCB0aGVyZS4NCj4+Pj4+Pj4+Pj4gWWVzLCBzb3JyeSwgSSBzaG91
bGQgdGFrZSBjYXJlIG9mIHRoYXQuDQo+Pj4+Pj4+Pj4+DQo+Pj4+Pj4+Pj4+PiBOb3cgaXQgaXMg
cXVpdGUgY2xlYXIgdGhhdCBwY2lkZXZzX2xvY2sgaXNuJ3QgZ29pbmcgdG8gaGVscCB3aXRoIGF2
b2lkaW5nDQo+Pj4+Pj4+Pj4+PiB0aGUgZGVhZGxvY2ssIGFzIGl0J3MgaW1vIG5vdCBhbiBvcHRp
b24gYXQgYWxsIHRvIGFjcXVpcmUgdGhhdCBsb2NrDQo+Pj4+Pj4+Pj4+PiBldmVyeXdoZXJlIGVs
c2UgeW91IGFjY2VzcyAtPnZwY2kgKG9yIGVsc2UgdGhlIHZwY2kgbG9jayBpdHNlbGYgd291bGQg
YmUNCj4+Pj4+Pj4+Pj4+IHBvaW50bGVzcykuIEJ1dCBhIHBlci1kb21haW4gYXV4aWxpYXJ5IHIv
dyBsb2NrIG1heSBoZWxwOiBPdGhlciBwYXRocw0KPj4+Pj4+Pj4+Pj4gd291bGQgYWNxdWlyZSBp
dCBpbiByZWFkIG1vZGUsIGFuZCBoZXJlIHlvdSdkIGFjcXVpcmUgaXQgaW4gd3JpdGUgbW9kZSAo
aW4NCj4+Pj4+Pj4+Pj4+IHRoZSBmb3JtZXIgY2FzZSBhcm91bmQgdGhlIHZwY2kgbG9jaywgd2hp
bGUgaW4gdGhlIGxhdHRlciBjYXNlIHRoZXJlIG1heQ0KPj4+Pj4+Pj4+Pj4gdGhlbiBub3QgYmUg
YW55IG5lZWQgdG8gYWNxdWlyZSB0aGUgaW5kaXZpZHVhbCB2cGNpIGxvY2tzIGF0IGFsbCkuIEZU
QU9EOg0KPj4+Pj4+Pj4+Pj4gSSBoYXZlbid0IGZ1bGx5IHRob3VnaHQgdGhyb3VnaCBhbGwgaW1w
bGljYXRpb25zIChhbmQgaGVuY2Ugd2hldGhlciB0aGlzIGlzDQo+Pj4+Pj4+Pj4+PiB2aWFibGUg
aW4gdGhlIGZpcnN0IHBsYWNlKTsgSSBleHBlY3QgeW91IHdpbGwsIGRvY3VtZW50aW5nIHdoYXQg
eW91J3ZlDQo+Pj4+Pj4+Pj4+PiBmb3VuZCBpbiB0aGUgcmVzdWx0aW5nIHBhdGNoIGRlc2NyaXB0
aW9uLiBPZiBjb3Vyc2UgdGhlIGRvdWJsZSBsb2NrDQo+Pj4+Pj4+Pj4+PiBhY3F1aXJlL3JlbGVh
c2Ugd291bGQgdGhlbiBsaWtlbHkgd2FudCBoaWRpbmcgaW4gaGVscGVyIGZ1bmN0aW9ucy4NCj4+
Pj4+Pj4+Pj4gSSd2ZSBiZWVuIGFsc28gdGhpbmtpbmcgYWJvdXQgdGhpcywgYW5kIHdoZXRoZXIg
aXQncyByZWFsbHkgd29ydGggdG8NCj4+Pj4+Pj4+Pj4gaGF2ZSBhIHBlci1kZXZpY2UgbG9jayBy
YXRoZXIgdGhhbiBhIHBlci1kb21haW4gb25lIHRoYXQgcHJvdGVjdHMgYWxsDQo+Pj4+Pj4+Pj4+
IHZwY2kgcmVnaW9ucyBvZiB0aGUgZGV2aWNlcyBhc3NpZ25lZCB0byB0aGUgZG9tYWluLg0KPj4+
Pj4+Pj4+Pg0KPj4+Pj4+Pj4+PiBUaGUgT1MgaXMgbGlrZWx5IHRvIHNlcmlhbGl6ZSBhY2Nlc3Nl
cyB0byB0aGUgUENJIGNvbmZpZyBzcGFjZSBhbnl3YXksDQo+Pj4+Pj4+Pj4+IGFuZCB0aGUgb25s
eSBwbGFjZSBJIGNvdWxkIHNlZSBhIGJlbmVmaXQgb2YgaGF2aW5nIHBlci1kZXZpY2UgbG9ja3Mg
aXMNCj4+Pj4+Pj4+Pj4gaW4gdGhlIGhhbmRsaW5nIG9mIE1TSS1YIHRhYmxlcywgYXMgdGhlIGhh
bmRsaW5nIG9mIHRoZSBtYXNrIGJpdCBpcw0KPj4+Pj4+Pj4+PiBsaWtlbHkgdmVyeSBwZXJmb3Jt
YW5jZSBzZW5zaXRpdmUsIHNvIGFkZGluZyBhIHBlci1kb21haW4gbG9jayB0aGVyZQ0KPj4+Pj4+
Pj4+PiBjb3VsZCBiZSBhIGJvdHRsZW5lY2suDQo+Pj4+Pj4+Pj4gSG1tLCB3aXRoIG1ldGhvZCAx
IGFjY2Vzc2VzIHNlcmlhbGl6aW5nIGdsb2JhbGx5IGlzIGJhc2ljYWxseQ0KPj4+Pj4+Pj4+IHVu
YXZvaWRhYmxlLCBidXQgd2l0aCBNTUNGRyBJIHNlZSBubyByZWFzb24gd2h5IE9TZXMgbWF5IG5v
dCAobW92ZQ0KPj4+Pj4+Pj4+IHRvKSBwZXJtaXQodGluZykgcGFyYWxsZWwgYWNjZXNzZXMsIHdp
dGggc2VyaWFsaXphdGlvbiBwZXJoYXBzIGRvbmUNCj4+Pj4+Pj4+PiBvbmx5IGF0IGRldmljZSBs
ZXZlbC4gU2VlIG91ciBvd24gcGNpX2NvbmZpZ19sb2NrLCB3aGljaCBhcHBsaWVzIHRvDQo+Pj4+
Pj4+Pj4gb25seSBtZXRob2QgMSBhY2Nlc3Nlczsgd2UgZG9uJ3QgbG9vayB0byBiZSBzZXJpYWxp
emluZyBNTUNGRw0KPj4+Pj4+Pj4+IGFjY2Vzc2VzIGF0IGFsbC4NCj4+Pj4+Pj4+Pg0KPj4+Pj4+
Pj4+PiBXZSBjb3VsZCBhbHRlcm5hdGl2ZWx5IGRvIGEgcGVyLWRvbWFpbiByd2xvY2sgZm9yIHZw
Y2kgYW5kIHNwZWNpYWwgY2FzZQ0KPj4+Pj4+Pj4+PiB0aGUgTVNJLVggYXJlYSB0byBhbHNvIGhh
dmUgYSBwZXItZGV2aWNlIHNwZWNpZmljIGxvY2suIEF0IHdoaWNoIHBvaW50DQo+Pj4+Pj4+Pj4+
IGl0IGJlY29tZXMgZmFpcmx5IHNpbWlsYXIgdG8gd2hhdCB5b3UgcHJvcG9zZS4NCj4+Pj4+Pj4+
IEBKYW4sIEBSb2dlcg0KPj4+Pj4+Pj4NCj4+Pj4+Pj4+IDEuIGQtPnZwY2lfbG9jayAtIHJ3bG9j
ayA8LSB0aGlzIHByb3RlY3RzIHZwY2kNCj4+Pj4+Pj4+IDIuIHBkZXYtPnZwY2ktPm1zaXhfdGJs
X2xvY2sgLSByd2xvY2sgPC0gdGhpcyBwcm90ZWN0cyBNU0ktWCB0YWJsZXMNCj4+Pj4+Pj4+IG9y
IHNob3VsZCBpdCBiZXR0ZXIgYmUgcGRldi0+bXNpeF90YmxfbG9jayBhcyBNU0ktWCB0YWJsZXMg
ZG9uJ3QNCj4+Pj4+Pj4+IHJlYWxseSBkZXBlbmQgb24gdlBDST8NCj4+Pj4+Pj4gSWYgc28sIHBl
cmhhcHMgaW5kZWVkIGJldHRlciB0aGUgbGF0dGVyLiBCdXQgYXMgc2FpZCBpbiByZXBseSB0byBS
b2dlciwNCj4+Pj4+Pj4gSSdtIG5vdCBjb252aW5jZWQgKHlldCkgdGhhdCBkb2luZyBhd2F5IHdp
dGggdGhlIHBlci1kZXZpY2UgbG9jayBpcyBhDQo+Pj4+Pj4+IGdvb2QgbW92ZS4gQXMgc2FpZCB0
aGVyZSAtIHdlJ3JlIG91cnNlbHZlcyBkb2luZyBmdWxseSBwYXJhbGxlbCBNTUNGRw0KPj4+Pj4+
PiBhY2Nlc3Nlcywgc28gT1NlcyBvdWdodCB0byBiZSBmaW5lIHRvIGRvIHNvLCB0b28uDQo+Pj4+
Pj4gQnV0IHdpdGggcGRldi0+dnBjaV9sb2NrIHdlIGZhY2UgQUJCQS4uLg0KPj4+Pj4gSSB0aGlu
ayBpdCB3b3VsZCBiZSBlYXNpZXIgdG8gc3RhcnQgd2l0aCBhIHBlci1kb21haW4gcndsb2NrIHRo
YXQNCj4+Pj4+IGd1YXJhbnRlZXMgcGRldi0+dnBjaSBjYW5ub3QgYmUgcmVtb3ZlZCB1bmRlciBv
dXIgZmVldC4gVGhpcyB3b3VsZCBiZQ0KPj4+Pj4gdGFrZW4gaW4gcmVhZCBtb2RlIGluIHZwY2lf
e3JlYWQsd3JpdGV9IGFuZCBpbiB3cml0ZSBtb2RlIHdoZW4NCj4+Pj4+IHJlbW92aW5nIGEgZGV2
aWNlIGZyb20gYSBkb21haW4uDQo+Pj4+Pg0KPj4+Pj4gVGhlbiB0aGVyZSBhcmUgYWxzbyBvdGhl
ciBpc3N1ZXMgcmVnYXJkaW5nIHZQQ0kgbG9ja2luZyB0aGF0IG5lZWQgdG8NCj4+Pj4+IGJlIGZp
eGVkLCBidXQgdGhhdCBsb2NrIHdvdWxkIGxpa2VseSBiZSBhIHN0YXJ0Lg0KPj4+PiBPciBsZXQn
cyBzZWUgdGhlIHByb2JsZW0gYXQgYSBkaWZmZXJlbnQgYW5nbGU6IHRoaXMgaXMgdGhlIG9ubHkg
cGxhY2UNCj4+Pj4gd2hpY2ggYnJlYWtzIHRoZSB1c2Ugb2YgcGRldi0+dnBjaV9sb2NrLiBCZWNh
dXNlIGFsbCBvdGhlciBwbGFjZXMNCj4+Pj4gZG8gbm90IHRyeSB0byBhY3F1aXJlIHRoZSBsb2Nr
IG9mIGFueSB0d28gZGV2aWNlcyBhdCBhIHRpbWUuDQo+Pj4+IFNvLCB3aGF0IGlmIHdlIHJlLXdv
cmsgdGhlIG9mZmVuZGluZyBwaWVjZSBvZiBjb2RlIGluc3RlYWQ/DQo+Pj4+IFRoYXQgd2F5IHdl
IGRvIG5vdCBicmVhayBwYXJhbGxlbCBhY2Nlc3MgYW5kIGhhdmUgdGhlIGxvY2sgcGVyLWRldmlj
ZQ0KPj4+PiB3aGljaCBtaWdodCBhbHNvIGJlIGEgcGx1cy4NCj4+Pj4NCj4+Pj4gQnkgcmUtd29y
ayBJIG1lYW4sIHRoYXQgaW5zdGVhZCBvZiByZWFkaW5nIGFscmVhZHkgbWFwcGVkIHJlZ2lvbnMN
Cj4+Pj4gZnJvbSB0bXAgd2UgY2FuIGVtcGxveSBhIGQtPnBjaV9tYXBwZWRfcmVnaW9ucyByYW5n
ZSBzZXQgd2hpY2gNCj4+Pj4gd2lsbCBob2xkIGFsbCB0aGUgYWxyZWFkeSBtYXBwZWQgcmFuZ2Vz
LiBBbmQgd2hlbiBpdCBpcyBuZWVkZWQgdG8gYWNjZXNzDQo+Pj4+IHRoYXQgcmFuZ2Ugc2V0IHdl
IHVzZSBwY2lkZXZzX2xvY2sgd2hpY2ggc2VlbXMgdG8gYmUgcmFyZS4NCj4+Pj4gU28sIG1vZGlm
eV9iYXJzIHdpbGwgcmVseSBvbiBwZGV2LT52cGNpX2xvY2sgKyBwY2lkZXZzX2xvY2sgYW5kDQo+
Pj4+IEFCQkEgd29uJ3QgYmUgcG9zc2libGUgYXQgYWxsLg0KPj4+IFNhZGx5IHRoYXQgd29uJ3Qg
cmVwbGFjZSB0aGUgdXNhZ2Ugb2YgdGhlIGxvb3AgaW4gbW9kaWZ5X2JhcnMuIFRoaXMgaXMNCj4+
PiBub3QgKGV4Y2x1c2l2ZWx5KSBkb25lIGluIG9yZGVyIHRvIHByZXZlbnQgbWFwcGluZyB0aGUg
c2FtZSByZWdpb24NCj4+PiBtdWx0aXBsZSB0aW1lcywgYnV0IHJhdGhlciB0byBwcmV2ZW50IHVu
bWFwcGluZyBvZiByZWdpb25zIGFzIGxvbmcgYXMNCj4+PiB0aGVyZSdzIGFuIGVuYWJsZWQgQkFS
IHRoYXQncyB1c2luZyBpdC4NCj4+Pg0KPj4+IElmIHlvdSB3YW50ZWQgdG8gdXNlIHNvbWV0aGlu
ZyBsaWtlIGQtPnBjaV9tYXBwZWRfcmVnaW9ucyBpdCB3b3VsZA0KPj4+IGhhdmUgdG8ga2VlcCBy
ZWZlcmVuY2UgY291bnRzIHRvIHJlZ2lvbnMsIGluIG9yZGVyIHRvIGtub3cgd2hlbiBhDQo+Pj4g
bWFwcGluZyBpcyBubyBsb25nZXIgcmVxdWlyZWQgYnkgYW55IEJBUiBvbiB0aGUgc3lzdGVtIHdp
dGggbWVtb3J5DQo+Pj4gZGVjb2RpbmcgZW5hYmxlZC4NCj4+IEkgbWlzc2VkIHRoaXMgcGF0aCwg
dGhhbmsgeW91DQo+Pg0KPj4gSSB0cmllZCB0byBhbmFseXplIHRoZSBsb2NraW5nIGluIHBjaS92
cGNpLg0KPj4NCj4+IEZpcnN0IG9mIGFsbCBzb21lIGNvbnRleHQgdG8gcmVmcmVzaCB0aGUgdGFy
Z2V0IHdlIHdhbnQ6DQo+PiB0aGUgcmF0aW9uYWxlIGJlaGluZCBtb3ZpbmcgcGRldi0+dnBjaS0+
bG9jayBvdXRzaWRlDQo+PiBpcyB0byBiZSBhYmxlIGR5bmFtaWNhbGx5IGNyZWF0ZSBhbmQgZGVz
dHJveSBwZGV2LT52cGNpLg0KPj4gU28sIGZvciB0aGF0IHJlYXNvbiBsb2NrIG5lZWRzIHRvIGJl
IG1vdmVkIG91dHNpZGUgb2YgdGhlIHBkZXYtPnZwY2kuDQo+Pg0KPj4gU29tZSBvZiB0aGUgY2Fs
bGVycyBvZiB0aGUgdlBDSSBjb2RlIGFuZCBsb2NraW5nIHVzZWQ6DQo+Pg0KPj4gPT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCj4+IHZwY2lfbW1pb19yZWFkL3ZwY2lfbW1j
ZmdfcmVhZA0KPj4gPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCj4+ICAg
wqAgLSB2cGNpX2VjYW1fcmVhZA0KPj4gICDCoCAtIHZwY2lfcmVhZA0KPj4gICDCoMKgICEhISEh
ISEhIHBkZXYgaXMgYWNxdWlyZWQsIHRoZW4gcGRldi0+dnBjaV9sb2NrIGlzIHVzZWQgISEhISEh
ISENCj4+ICAgwqDCoCAtIG1zaXg6DQo+PiAgIMKgwqDCoCAtIGNvbnRyb2xfcmVhZA0KPj4gICDC
oMKgIC0gaGVhZGVyOg0KPj4gICDCoMKgwqAgLSBndWVzdF9iYXJfcmVhZA0KPj4gICDCoMKgIC0g
bXNpOg0KPj4gICDCoMKgwqAgLSBjb250cm9sX3JlYWQNCj4+ICAgwqDCoMKgIC0gYWRkcmVzc19y
ZWFkL2FkZHJlc3NfaGlfcmVhZA0KPj4gICDCoMKgwqAgLSBkYXRhX3JlYWQNCj4+ICAgwqDCoMKg
IC0gbWFza19yZWFkDQo+Pg0KPj4gPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT0NCj4+IHZwY2lfbW1pb193cml0ZS92cGNpX21tY2ZnX3dyaXRlDQo+PiA9PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PQ0KPj4gICDCoCAtIHZwY2lfZWNhbV93cml0ZQ0KPj4g
ICDCoCAtIHZwY2lfd3JpdGUNCj4+ICAgwqDCoCAhISEhISEhISBwZGV2IGlzIGFjcXVpcmVkLCB0
aGVuIHBkZXYtPnZwY2lfbG9jayBpcyB1c2VkICEhISEhISEhDQo+PiAgIMKgwqAgLSBtc2l4Og0K
Pj4gICDCoMKgwqAgLSBjb250cm9sX3dyaXRlDQo+PiAgIMKgwqAgLSBoZWFkZXI6DQo+PiAgIMKg
wqDCoCAtIGJhcl93cml0ZS9ndWVzdF9iYXJfd3JpdGUNCj4+ICAgwqDCoMKgIC0gY21kX3dyaXRl
L2d1ZXN0X2NtZF93cml0ZQ0KPj4gICDCoMKgwqAgLSByb21fd3JpdGUNCj4+ICAgwqDCoMKgwqAg
LSBhbGwgd3JpdGUgaGFuZGxlcnMgbWF5IGNhbGwgbW9kaWZ5X2JhcnMNCj4+ICAgwqDCoMKgwqDC
oCBtb2RpZnlfYmFycw0KPj4gICDCoMKgIC0gbXNpOg0KPj4gICDCoMKgwqAgLSBjb250cm9sX3dy
aXRlDQo+PiAgIMKgwqDCoCAtIGFkZHJlc3Nfd3JpdGUvYWRkcmVzc19oaV93cml0ZQ0KPj4gICDC
oMKgwqAgLSBkYXRhX3dyaXRlDQo+PiAgIMKgwqDCoCAtIG1hc2tfd3JpdGUNCj4+DQo+PiA9PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KPj4gcGNpX2FkZF9kZXZpY2U6IGxv
Y2tlZCB3aXRoIHBjaWRldnNfbG9jaw0KPj4gPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT0NCj4+ICAgwqAgLSB2cGNpX2FkZF9oYW5kbGVycw0KPj4gICDCoMKgICsrKysrKysr
IHBkZXYtPnZwY2lfbG9jayBpcyB1c2VkICsrKysrKysrDQo+Pg0KPj4gPT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT0NCj4+IHBjaV9yZW1vdmVfZGV2aWNlOiBsb2NrZWQgd2l0
aCBwY2lkZXZzX2xvY2sNCj4+ID09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
DQo+PiAtIHZwY2lfcmVtb3ZlX2RldmljZQ0KPj4gICDCoCArKysrKysrKyBwZGV2LT52cGNpX2xv
Y2sgaXMgdXNlZCArKysrKysrKw0KPj4gLSBwY2lfY2xlYW51cF9tc2kNCj4+IC0gZnJlZV9wZGV2
DQo+Pg0KPj4gPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCj4+IFhFTl9E
T01DVExfYXNzaWduX2RldmljZTogbG9ja2VkIHdpdGggcGNpZGV2c19sb2NrDQo+PiA9PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KPj4gLSBhc3NpZ25fZGV2aWNlDQo+PiAg
IMKgLSB2cGNpX2RlYXNzaWduX2RldmljZQ0KPj4gICDCoC0gcGRldl9tc2l4X2Fzc2lnbg0KPj4g
ICDCoC0gdnBjaV9hc3NpZ25fZGV2aWNlDQo+PiAgIMKgIC0gdnBjaV9hZGRfaGFuZGxlcnMNCj4+
ICAgwqDCoMKgICsrKysrKysrIHBkZXYtPnZwY2lfbG9jayBpcyB1c2VkICsrKysrKysrDQo+Pg0K
Pj4gPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCj4+IFhFTl9ET01DVExf
ZGVhc3NpZ25fZGV2aWNlOiBsb2NrZWQgd2l0aCBwY2lkZXZzX2xvY2sNCj4+ID09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09DQo+PiAtIGRlYXNzaWduX2RldmljZQ0KPj4gICDC
oC0gdnBjaV9kZWFzc2lnbl9kZXZpY2UNCj4+ICAgwqDCoCArKysrKysrKyBwZGV2LT52cGNpX2xv
Y2sgaXMgdXNlZCArKysrKysrKw0KPj4gICDCoCAtIHZwY2lfcmVtb3ZlX2RldmljZQ0KPj4NCj4+
DQo+PiA9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KPj4gbW9kaWZ5X2Jh
cnMgaXMgYSBzcGVjaWFsIGNhc2U6IHRoaXMgaXMgdGhlIG9ubHkgZnVuY3Rpb24gd2hpY2ggdHJp
ZXMgdG8gbG9jaw0KPj4gdHdvIHBjaV9kZXYgZGV2aWNlczogaXQgaXMgZG9uZSB0byBjaGVjayBm
b3Igb3ZlcmxhcHMgd2l0aCBvdGhlciBCQVJzIHdoaWNoIG1heSBoYXZlIGJlZW4NCj4+IGFscmVh
ZHkgbWFwcGVkIG9yIHVubWFwcGVkLg0KPj4NCj4+IFNvLCB0aGlzIGlzIHRoZSBvbmx5IGNhc2Ug
d2hpY2ggbWF5IGRlYWRsb2NrIGJlY2F1c2Ugb2YgcGNpX2Rldi0+dnBjaV9sb2NrLg0KPj4gPT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCj4+DQo+PiBCb3R0b20gbGluZToN
Cj4+ID09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQo+Pg0KPj4gMS4gdnBj
aV97cmVhZHx3cml0ZX0gYXJlIG5vdCBwcm90ZWN0ZWQgd2l0aCBwY2lkZXZzX2xvY2sgYW5kIGNh
biBydW4gaW4NCj4+IHBhcmFsbGVsIHdpdGggcGNpX3JlbW92ZV9kZXZpY2Ugd2hpY2ggY2FuIHJl
bW92ZSBwZGV2IGFmdGVyIHZwY2lfe3JlYWR8d3JpdGV9DQo+PiBhY3F1aXJlZCB0aGUgcGRldiBw
b2ludGVyLiBUaGlzIG1heSBsZWFkIHRvIGEgZmFpbCBkdWUgdG8gcGRldiBkZXJlZmVyZW5jZS4N
Cj4+DQo+PiBTbywgdG8gcHJvdGVjdCBwZGV2IGRlcmVmZXJlbmNlIHZwY2lfe3JlYWR8d3JpdGV9
IG11c3QgYWxzbyB1c2UgcGRldnNfbG9jay4NCj4gV2Ugd291bGQgbGlrZSB0byB0YWtlIHRoZSBw
Y2lkZXZzX2xvY2sgb25seSB3aGlsZSBmZXRjaGluZyB0aGUgZGV2aWNlDQo+IChpZTogcGNpX2dl
dF9wZGV2X2J5X2RvbWFpbiksIGFmdGVyd2FyZHMgaXQgc2hvdWxkIGJlIGZpbmUgdG8gbG9jayB0
aGUNCj4gZGV2aWNlIHVzaW5nIGEgdnBjaSBzcGVjaWZpYyBsb2NrIHNvIGNhbGxzIHRvIHZwY2lf
e3JlYWQsd3JpdGV9IGNhbiBiZQ0KPiBwYXJ0aWFsbHkgY29uY3VycmVudCBhY3Jvc3MgbXVsdGlw
bGUgZG9tYWlucy4NClRoaXMgbWVhbnMgdGhpcyBjYW4ndCBiZSBkb25lIGEgcHJlLXJlcSBwYXRj
aCwgYnV0IGFzIGEgcGFydCBvZiB0aGUNCnBhdGNoIHdoaWNoIGNoYW5nZXMgbG9ja2luZy4NCj4N
Cj4gSW4gZmFjdCBJIHRoaW5rIEphbiBoYWQgYWxyZWFkeSBwb2ludGVkIG91dCB0aGF0IHRoZSBw
Y2kgbG9jayB3b3VsZA0KPiBuZWVkIHRha2luZyB3aGlsZSBzZWFyY2hpbmcgZm9yIHRoZSBkZXZp
Y2UgaW4gdnBjaV97cmVhZCx3cml0ZX0uDQpJIHdhcyByZWZlcnJpbmcgdG8gdGhlIHRpbWUgYWZ0
ZXIgd2UgZm91bmQgcGRldiBhbmQgaXQgaXMgY3VycmVudGx5DQpwb3NzaWJsZSB0byBmcmVlIHBk
ZXYgd2hpbGUgdXNpbmcgaXQgYWZ0ZXIgdGhlIHNlYXJjaA0KPg0KPiBJdCBzZWVtcyB0byBtZSB0
aGF0IGlmIHlvdSBpbXBsZW1lbnQgb3B0aW9uIDMgYmVsb3cgdGFraW5nIHRoZQ0KPiBwZXItZG9t
YWluIHJ3bG9jayBpbiByZWFkIG1vZGUgaW4gdnBjaV97cmVhZHx3cml0ZX0gd2lsbCBhbHJlYWR5
DQo+IHByb3RlY3QgeW91IGZyb20gdGhlIGRldmljZSBiZWluZyByZW1vdmVkIGlmIHRoZSBzYW1l
IHBlci1kb21haW4gbG9jaw0KPiBpcyB0YWtlbiBpbiB3cml0ZSBtb2RlIGluIHZwY2lfcmVtb3Zl
X2RldmljZS4NClllcywgaXQgc2hvdWxkLiBBZ2FpbiB0aGlzIGNhbid0IGJlIGRvbmUgYXMgYSBw
cmUtcmVxIHBhdGNoIGJlY2F1c2UNCnRoaXMgcmVsaWVzIG9uIHBkZXYtPnZwY2lfbG9jaw0KPg0K
Pj4gMi4gVGhlIG9ubHkgb2ZmZW5kaW5nIHBsYWNlIHdoaWNoIGlzIGluIHRoZSB3YXkgb2YgcGNp
X2Rldi0+dnBjaV9sb2NrIGlzDQo+PiBtb2RpZnlfYmFycy4gSWYgaXQgY2FuIGJlIHJlLXdvcmtl
ZCB0byB0cmFjayBhbHJlYWR5IG1hcHBlZCBhbmQgdW5tYXBwZWQNCj4+IHJlZ2lvbnMgdGhlbiB3
ZSBjYW4gYXZvaWQgaGF2aW5nIGEgcG9zc2libGUgZGVhZGxvY2sgYW5kIGNhbiB1c2UNCj4+IHBj
aV9kZXYtPnZwY2lfbG9jayAocmFuZ2VzZXRzIHdvbid0IGhlbHAgaGVyZSBhcyB3ZSBhbHNvIG5l
ZWQgcmVmY291bnRpbmcgYmUNCj4+IGltcGxlbWVudGVkKS4NCj4gSSB0aGluayBhIHJlZmNvdW50
aW5nIGJhc2VkIHNvbHV0aW9uIHdpbGwgYmUgdmVyeSBjb21wbGV4IHRvDQo+IGltcGxlbWVudC4g
SSdtIGhvd2V2ZXIgaGFwcHkgdG8gYmUgcHJvdmVuIHdyb25nLg0KSSBjYW4ndCBlc3RpbWF0ZSwg
YnV0IEkgaGF2ZSBhIGZlZWxpbmcgdGhhdCBhbGwgdGhlc2UgcGxheXMgYXJvdW5kIGxvY2tpbmcN
CmlzIGp1c3QgYmVjYXVzZSBvZiB0aGlzIHNpbmdsZSBwaWVjZSBvZiBjb2RlLiBObyBvdGhlciBw
bGFjZSBzdWZmZXIgZnJvbQ0KcGRldi0+dnBjaV9sb2NrIGFuZCBubyBkLT5sb2NrDQo+DQo+PiBJ
ZiBwY2lkZXZzX2xvY2sgaXMgdXNlZCBmb3IgdnBjaV97cmVhZHx3cml0ZX0gdGhlbiBubyBkZWFk
bG9jayBpcyBwb3NzaWJsZSwNCj4+IGJ1dCBtb2RpZnlfYmFycyBjb2RlIG11c3QgYmUgcmUtd29y
a2VkIG5vdCB0byBsb2NrIGl0c2VsZiAocGRldi0+dnBjaV9sb2NrIGFuZA0KPj4gdG1wLT52cGNp
X2xvY2sgd2hlbiBwZGV2ID09IHRtcCwgdGhpcyBpcyBtaW5vcikuDQo+IFRha2luZyB0aGUgcGNp
ZGV2cyBsb2NrIChhIGdsb2JhbCBsb2NrKSBpcyBvdXQgb2YgdGhlIHBpY3R1cmUgSU1PLCBhcw0K
PiBpdCdzIGdvaW5nIHRvIHNlcmlhbGl6ZSBhbGwgY2FsbHMgb2YgdnBjaV97cmVhZHx3cml0ZX0s
IGFuZCB3b3VsZA0KPiBjcmVhdGUgdG9vIG11Y2ggY29udGVudGlvbiBvbiB0aGUgcGNpZGV2cyBs
b2NrLg0KSSB1bmRlcnN0YW5kIHRoYXQuIEJ1dCBpZiB3ZSB3b3VsZCBsaWtlIHRvIGZpeCB0aGUg
ZXhpc3RpbmcgY29kZSBJIHNlZQ0Kbm8gb3RoZXIgYWx0ZXJuYXRpdmUuDQo+DQo+PiAzLiBXZSBt
YXkgdGhpbmsgYWJvdXQgYSBwZXItZG9tYWluIHJ3bG9jayBhbmQgcGRldi0+dnBjaV9sb2NrLCBz
byB0aGlzIHNvbHZlcw0KPj4gbW9kaWZ5X2JhcnMncyB0d28gcGRldnMgYWNjZXNzLiBCdXQgdGhp
cyBkb2Vzbid0IHNvbHZlIHBvc3NpYmxlIHBkZXYNCj4+IGRlLXJlZmVyZW5jZSBpbiB2cGNpX3ty
ZWFkfHdyaXRlfSB2cyBwY2lfcmVtb3ZlX2RldmljZS4NCj4gcGNpX3JlbW92ZSBkZXZpY2Ugd2ls
bCBjYWxsIHZwY2lfcmVtb3ZlX2RldmljZSwgc28gYXMgbG9uZyBhcw0KPiB2cGNpX3JlbW92ZV9k
ZXZpY2UgdGFrZW4gdGhlIHBlci1kb21haW4gbG9jayBpbiB3cml0ZSAoZXhjbHVzaXZlKSBtb2Rl
DQo+IGl0IHNob3VsZCBiZSBmaW5lLg0KSSB0aGluayBJIG5lZWQgdG8gc2VlIGlmIHRoZXJlIGFy
ZSBhbnkgb3RoZXIgcGxhY2VzIHdoaWNoIHNpbWlsYXJseQ0KcmVxdWlyZSB0aGUgd3JpdGUgbG9j
aw0KPg0KPj4gQFJvZ2VyLCBASmFuLCBJIHdvdWxkIGxpa2UgdG8gaGVhciB3aGF0IGRvIHlvdSB0
aGluayBhYm91dCB0aGUgYWJvdmUgYW5hbHlzaXMNCj4+IGFuZCBob3cgY2FuIHdlIHByb2NlZWQg
d2l0aCBsb2NraW5nIHJlLXdvcms/DQo+IEkgdGhpbmsgdGhlIHBlci1kb21haW4gcndsb2NrIHNl
ZW1zIGxpa2UgYSBnb29kIG9wdGlvbi4gSSB3b3VsZCBkbw0KPiB0aGF0IGFzIGEgcHJlLXBhdGNo
Lg0KSXQgaXMuIEJ1dCBpdCBzZWVtcyBpdCB3b24ndCBzb2x2ZSB0aGUgdGhpbmcgd2Ugc3RhcnRl
ZCB0aGlzIGFkdmVudHVyZSBmb3I6DQoNCldpdGggcGVyLWRvbWFpbiByZWFkIGxvY2sgYW5kIHN0
aWxsIEFCQkEgaW4gbW9kaWZ5X2JhcnMgKGhvcGUgdGhlIGJlbG93DQppcyBjb3JyZWN0bHkgc2Vl
biB3aXRoIGEgbW9ub3NwYWNlIGZvbnQpOg0KDQpjcHUwOiB2cGNpX3dyaXRlLT4gZC0+UkxvY2sg
LT4gcGRldjEtPmxvY2sgLT7CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oCByb21fd3JpdGUgLT4gbW9kaWZ5X2JhcnM6IHRtcCAocGRldjIpIC0+bG9jaw0KY3B1MTrCoMKg
wqDCoMKgwqDCoCB2cGNpX3dyaXRlLT4gZC0+UkxvY2sgcGRldjItPmxvY2sgLT4gY21kX3dyaXRl
IC0+IG1vZGlmeV9iYXJzOiB0bXAgKHBkZXYxKSAtPmxvY2sNCg0KVGhlcmUgaXMgbm8gQVBJIHRv
IHVwZ3JhZGUgcmVhZCBsb2NrIHRvIHdyaXRlIGxvY2sgaW4gbW9kaWZ5X2JhcnMgd2hpY2ggY291
bGQgaGVscCwNCnNvIGluIGJvdGggY2FzZXMgdnBjaV93cml0ZSBzaG91bGQgdGFrZSB3cml0ZSBs
b2NrLg0KDQpBbSBJIG1pc3Npbmcgc29tZXRoaW5nIGhlcmU/DQo+DQo+IFRoYW5rcywgUm9nZXIu
DQpUaGFuayB5b3UsDQpPbGVrc2FuZHI=


From xen-devel-bounces@lists.xenproject.org Mon Feb 07 14:02:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 14:02:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266962.460660 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH4bQ-0006WC-9D; Mon, 07 Feb 2022 14:02:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266962.460660; Mon, 07 Feb 2022 14:02:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH4bQ-0006W5-4f; Mon, 07 Feb 2022 14:02:48 +0000
Received: by outflank-mailman (input) for mailman id 266962;
 Mon, 07 Feb 2022 14:02:47 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nH4bP-0006Vv-2O; Mon, 07 Feb 2022 14:02:47 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nH4bP-0003oQ-0c; Mon, 07 Feb 2022 14:02:47 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nH4bO-00014k-Lf; Mon, 07 Feb 2022 14:02:46 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nH4bO-0003OI-LD; Mon, 07 Feb 2022 14:02:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=5x/8UJnM1nwrjMbytt0n24HtR3tNsXzAZxWh/qs59qk=; b=BWhg+5+8FBKyiQSTB544BlR13I
	kGTzV5dWSjWs3PbV1A0MjsPR5OFZeAZX1DefX+7urYloJ0lofsuJgKauP5dYOZj24WSck2rOAgiPP
	m5PEsLyuQzvN3BAFZT/mgCpjhW88fRmEhFVMGqTAM5VavIUSK2ZjLghUeVdrYRJYY6Uw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168043-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 168043: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=96b8b5fd108a1f27960eee3915c0b10db191c849
X-Osstest-Versions-That:
    ovmf=f78b937c95ddc4f7a29e41fee98e96076828a108
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 07 Feb 2022 14:02:46 +0000

flight 168043 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168043/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 96b8b5fd108a1f27960eee3915c0b10db191c849
baseline version:
 ovmf                 f78b937c95ddc4f7a29e41fee98e96076828a108

Last test of basis   168042  2022-02-07 06:41:36 Z    0 days
Testing same since   168043  2022-02-07 10:42:40 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Matt DeVillier <matt.devillier@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   f78b937c95..96b8b5fd10  96b8b5fd108a1f27960eee3915c0b10db191c849 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Mon Feb 07 14:09:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 14:09:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266975.460671 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH4hr-0007CF-Vo; Mon, 07 Feb 2022 14:09:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266975.460671; Mon, 07 Feb 2022 14:09:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH4hr-0007C8-SV; Mon, 07 Feb 2022 14:09:27 +0000
Received: by outflank-mailman (input) for mailman id 266975;
 Mon, 07 Feb 2022 14:09:26 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nH4hq-0007By-KZ; Mon, 07 Feb 2022 14:09:26 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nH4hq-0003uJ-FU; Mon, 07 Feb 2022 14:09:26 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nH4hq-0001DE-0m; Mon, 07 Feb 2022 14:09:26 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nH4hq-00037F-0H; Mon, 07 Feb 2022 14:09:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=15sZCMuj73Lu40UBT9FEftyDJ27LbNMCRjgMlrpz2fI=; b=ye1En+rzzbDXkWaQTzxijpoV4V
	dAeAKznjtVEnTMyTF1O976osG+d5cVhxZTXM9RPOF0PepxnvUvRqi+aMQlz05cNk3iDKlmrj16VaK
	QmytahpVueu4jugfhYUPgZ/hcD9D2YYFu0k+VnpzGtXIXQDcDh2AuoCEKwlkHIh4LS8I=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168041-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 168041: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:heisenbug
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=dfd42facf1e4ada021b939b4e19c935dcdd55566
X-Osstest-Versions-That:
    linux=d8ad2ce873abab1cfd38779c626b79cef6307aac
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 07 Feb 2022 14:09:26 +0000

flight 168041 linux-linus real [real]
flight 168045 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/168041/
http://logs.test-lab.xenproject.org/osstest/logs/168045/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail pass in 168045-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail in 168045 never pass
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168035
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168035
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168035
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168035
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168035
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168035
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168035
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168035
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                dfd42facf1e4ada021b939b4e19c935dcdd55566
baseline version:
 linux                d8ad2ce873abab1cfd38779c626b79cef6307aac

Last test of basis   168035  2022-02-06 18:41:13 Z    0 days
Testing same since   168041  2022-02-07 05:04:10 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Linus Torvalds <torvalds@linux-foundation.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           fail    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   d8ad2ce873aba..dfd42facf1e4a  dfd42facf1e4ada021b939b4e19c935dcdd55566 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Mon Feb 07 14:11:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 14:11:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266987.460682 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH4jY-00006x-D0; Mon, 07 Feb 2022 14:11:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266987.460682; Mon, 07 Feb 2022 14:11:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH4jY-00006q-9F; Mon, 07 Feb 2022 14:11:12 +0000
Received: by outflank-mailman (input) for mailman id 266987;
 Mon, 07 Feb 2022 14:11:11 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=owYM=SW=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nH4jX-00006f-38
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 14:11:11 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c729abd9-881f-11ec-8f75-fffcc8bd4f1a;
 Mon, 07 Feb 2022 15:11:01 +0100 (CET)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2053.outbound.protection.outlook.com [104.47.6.53]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-7-NOGjNVOoOHSfr3SAqaSDWw-1; Mon, 07 Feb 2022 15:11:08 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM0PR04MB6244.eurprd04.prod.outlook.com (2603:10a6:208:143::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Mon, 7 Feb
 2022 14:11:06 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.018; Mon, 7 Feb 2022
 14:11:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c729abd9-881f-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644243070;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=8QP5TCoyeHmpSS0YtYXiHeghGiapLO1wWkBFNN1DPn4=;
	b=gbTiZrOYpfhlSNKtKHHG1IqkIinghzEAY81jT1afzSITYrDbC72ML5zbhza65lTInHjcyK
	WEYvf84INiM1JtiUHyGpt0QHoMOWBIFQeIUg/orsK0mco7fD2pORZHAIkU2N8y2FKgvmIU
	V5EjQtyDntX0E80QnUBRb5SBOz1T78o=
X-MC-Unique: NOGjNVOoOHSfr3SAqaSDWw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=afFAQic8k5hyCxEW2o/zQJuvY7yVhpIDmuOVfVifmWJ4IX+nHhn7p/b3xvHZzTZBeJrVlykTiYheQUjROpmPYo6nwgFCydWIfVHaaFYz/WRWMkDg8CfIu9SCU33pe8tZwDgy6mD+OYoCnFT0hq/cfdxikvvUXavvhWumIKyqjWFtmfTGlZLu99s7m8MJE1jlzM+8OL1kBhO3QijxLfrMaYSCNnYXbLGnxa0jgAdGpfW9rhHLZ5F4o14P1++Zhm8UaiY7LjeYfzMEprCFX8Pr7zS607Je89RIHtotu/XSmjPK0XMP9Dv0RDa0Y2CM+6hMVNpjRgrrsb78FHVzABM72Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Qo2Txv+cann+/Sw+Ehm5UvgQnQa77eTqW0JzwA4xoHc=;
 b=HX56dOFZ3VxQsoiBKh8hq4FMVyr3Um+obKBpBEEzHfznYxM1xbDwjd6bMsFDkpkiLY+WE4VxtvMX1tUpJchQ2Lp1bdx3QLQj5u16Ud1F96gkGfccHzFtHNEhNtYo6CPjxknDGbY+wzO88ioeOneukDPnAy+6yFLpxoLRf88gVImCsS3wmYNKQe8HU1o4Pu+fTE55Bzkbwc18Qk0fp+JexDwg+Qn3rKBig5mXm7zBvgibxFqyD0Wjc97rTSgAdcLoBV8ptQ1szsEC7K8lHP6Hb2csqrW88GkI53qBHMTcd6lmDAT9WfXZtsZCk6tgHLK/p7fUD4Y/bKqM9W+MUNSJog==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <1f65ae7a-898d-2c27-0ada-d71d778b0627@suse.com>
Date: Mon, 7 Feb 2022 15:11:03 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Content-Language: en-US
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: "julien@xen.org" <julien@xen.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Artem Mygaiev <Artem_Mygaiev@epam.com>,
 "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
 "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
 "paul@xen.org" <paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <c3a99712-cf7c-37da-aac1-f2ee00e6d53b@suse.com>
 <Yf0KcVD8W05A4fbB@Air-de-Roger>
 <1ed0e342-16cd-2f16-c05c-186667a22762@suse.com>
 <7e3562b5-fc67-f213-e872-f211450d9e2e@epam.com>
 <a8fc599c-f620-c4d1-2077-c57068f46a7f@suse.com>
 <deef8468-d607-e49e-f456-6a8013329ca1@epam.com>
 <Yf0k6aoKK5G3iad1@Air-de-Roger>
 <3ad10a99-c706-b95f-1419-2c0c7cf37d58@epam.com>
 <Yf0+3C9nF8+tewLw@Air-de-Roger>
 <c5fea3bb-834b-eeb7-d7a1-1ee609037a9f@epam.com>
 <YgEUwTxhnWVMGMJK@Air-de-Roger>
 <9ce90193-74a0-5642-d22b-6b8c3340c3cf@epam.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <9ce90193-74a0-5642-d22b-6b8c3340c3cf@epam.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0399.eurprd06.prod.outlook.com
 (2603:10a6:20b:461::12) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 8fc0b82b-661d-4d9e-d2f2-08d9ea43ae5c
X-MS-TrafficTypeDiagnostic: AM0PR04MB6244:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB6244EE03E23E9DB87896FDD4B32C9@AM0PR04MB6244.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	wFkNBC+Do6MRIFOE1Ewp45rSR1cuSSyw9d125VJVzujEnWiqk2oy2qD+FmkpTaAsXt2e2/ygnwDP+aQiPZyJHtATSurB5z1sRN8oQZr3SI01GvRdgMcQfiyofiLNKoqTX8qsUHAMxYPS5ZvQWMyNEuBlmFBwFiAEh28+XbyQt0Tp1vvXzk6fBQ5AEkXs7e5iasW0PGs7gdPseQFLS/bf5g+UyKUJII6NTA6e7008lyJliEtepAd6PV7i2dwdPLuzR/Txi2k9lLGKE/M4Z9ogHptFO9F7x6gqw+2tAXhT7OmhO/J3CAnXcO82qA0wqmLWG2oM0yxXiw4UHGsZ5zjYsn1/A8ATm6XJNu+LAnGTjU8GeFLyzv20JpgWP1se8o1GVTr4cJEN7p88aTn/QYyyhjpcvkxHHh6zYwNCgIbjMlULnekFaHqMWTno1csvyxPXdaVYjKivOzpBVyaaikq+5hvzDPxgD61gyxezwZL2XI5ObvNd6Y6jtZs23KF1qqkzeXP2gnAVp33+UQHv6QaUZusGslnqomCwqA/lHZtO7VAc7Nahp7k/bLlL2fKTW7xkOP3ED3hkF4mYti3Tv4y6qxMI8H9Q0mnpHy3clvffFtJkwOMN/ush3WjUwGscK52BZofNhGhV/UnB6yFCN4I+C/f/fJ8zOBiNB7+mWxl8XT2lKLbq0JxwO2IJdu+5eQ3pNzd9TibuYDRFa4v2wsLcEoN42/vx6rwfKJtv/1nGGqE=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(5660300002)(6512007)(4744005)(53546011)(31696002)(86362001)(54906003)(6666004)(7416002)(6506007)(2906002)(6916009)(186003)(38100700002)(66946007)(316002)(66556008)(66476007)(2616005)(8936002)(4326008)(26005)(8676002)(6486002)(31686004)(508600001)(83380400001)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?usfpoACuZfCxJCxQit3Q4kXUT1aA467h2PbLdHadYlmOHlTTg+8NlR6s/a/v?=
 =?us-ascii?Q?kH5zwUvviSj/9wEtHTrmlkw2qJMxZMQsNbbMeU3cHLP74ld/VFA6U+bljrRs?=
 =?us-ascii?Q?PGKkZwYyDFjr4rAjHNZGvwA0b/Pv9eLww6HN+fgGFVomNoyCePCeKEjYiyw1?=
 =?us-ascii?Q?z/Ek//X1y0kiyQQDHuu0Nu0dpnbV/c3XJOrC2YvfDMR75LZhozy5OyFO40LM?=
 =?us-ascii?Q?MK/dPZBaZ6DG3jkyLAexNvvLzHV9/pPr4F5nABnIP5YYnoAQEW7eg0l9dYbw?=
 =?us-ascii?Q?PMwG+TcXKy+9PxV1JGRPm32/3hpwxZy0UHdqcPfF908bXL7Y/nKxi0Bo2i7s?=
 =?us-ascii?Q?T7OD/B/t2BKsjVH+kehZgUNFPYj0cS/ZzqKie4FvYwLlJQQ8Pg4/pa3QlGcn?=
 =?us-ascii?Q?spWgCi0m/3tk5t5FGSJln9o2kglpNVVhmB+AW98Ot0cb4zM0tkDlX8rQfvwE?=
 =?us-ascii?Q?R8FhT0dT0q0GNFvJFzzh2ZYzpiG/9IKFExH9LzLl+Wfjac1yPqLAvcFoE2NS?=
 =?us-ascii?Q?/Tj0dFJFR8OcTN1DNpC2KbG0FrOI+oeYGZ4tldBJyc02Ae4jri0D0HNIo1OL?=
 =?us-ascii?Q?c0fOiclNbX+9Hoszs6ob8sULRyw/HEQvIPJAA+/WbsgRepLHRpsOyKpC94LG?=
 =?us-ascii?Q?MVFpB+6dFxgB2J7o4wz0mU+84E3/xVUi8lV8eZaTEWZ+qMVnHbxsgdGuBRh/?=
 =?us-ascii?Q?R1837g9QBs0vWUlzOJ1bUYrXc3aHRoWLIKJnw0BU9a1o24rDoAUwL4x7eTg4?=
 =?us-ascii?Q?kzIsu9qemravmtUIqIqDbaZQH0Yewbf0BqeWDDO0Rxj2js8mCByriyFEnnib?=
 =?us-ascii?Q?XnwBiHJ7/b+BKt9Vt2DefDXm9pPlfgoXhHWyjgmRLDkstPOx15a/BVZv/Sbl?=
 =?us-ascii?Q?lpIZniq1vPY7CjGfHF90vm6jmkFSK5dGr24qUiRw3s669QmvYj7oDhShaoz5?=
 =?us-ascii?Q?u6MTVQrHhBHR+ad8rEHre+DfYQQhbuprAiSUm/vm/EPlhzFVIVHt8jmt2Xas?=
 =?us-ascii?Q?dv+TH8qJdKsp+hxaH65n222qtBDWv+6tY6Gvno2lcBu+4q774hbLpfTBCogp?=
 =?us-ascii?Q?h+lA78WGGZ5dR5iH8JAxGivG6T73hwDJRlNLlZlejXDQ6rOVH0Ovw2ZxRbNP?=
 =?us-ascii?Q?w5n6HEl65Z8jc32v5QcX8DJK1QmAomh0wXGCVf4cyEzhwtUdPK0EviomSU8q?=
 =?us-ascii?Q?OrWGfMj0ddPanLt79jTSQsWnop6w9bRRA3ZQnTRPrH7/URLFJqSxPuAIjg2d?=
 =?us-ascii?Q?uz7JZ/T7h4L6AilF1LpMKEzAzZLHW8pIj9rjmWd5d0VGc8E8JdM784C+GtNL?=
 =?us-ascii?Q?E2uBzXgngpgdXZ1RHO6DGiFwYtnorKaR0yPMhR5qNxgCYvp2rTAL0v/x1/5C?=
 =?us-ascii?Q?DXTPd02buT39+hr9XWYrg/HFWfxAQ9SGuTs5gL3XbELzDdTHwELUfbI4MyZH?=
 =?us-ascii?Q?rHG77DCunJATypiHlIHzk6XUiBrlIOOD/OxT918xTReSl4QARiArZFLTl2/3?=
 =?us-ascii?Q?P+90vFpw+N9YDNe2Nz/W5//GS4HjYojlstyNzQAD4yTtS1yLWE7AIyAzXPgn?=
 =?us-ascii?Q?KkWw6JvUJgPXtZ2lXWfq59TyKVLKAYPXBhHWELSoxjDH1jDEroGWkgeJMuf7?=
 =?us-ascii?Q?3O2T870ETMfOt7bb0WTOOIc=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8fc0b82b-661d-4d9e-d2f2-08d9ea43ae5c
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2022 14:11:06.0694
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 79M5im2dvIvCCjAVDzUSXyfr81qxZRrVw9Qn1MEraURGhh576ONzbgKoQOGyqu2719yEEhQakYVsDQ+Lv5947Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6244

On 07.02.2022 14:53, Oleksandr Andrushchenko wrote:
> On 07.02.22 14:46, Roger Pau Monn=C3=A9 wrote:
>> I think the per-domain rwlock seems like a good option. I would do
>> that as a pre-patch.
> It is. But it seems it won't solve the thing we started this adventure fo=
r:
>=20
> With per-domain read lock and still ABBA in modify_bars (hope the below
> is correctly seen with a monospace font):
>=20
> cpu0: vpci_write-> d->RLock -> pdev1->lock ->=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 rom_write -> modify_bars: tmp (p=
dev2) ->lock
> cpu1:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 vpci_write-> d->RLock pde=
v2->lock -> cmd_write -> modify_bars: tmp (pdev1) ->lock
>=20
> There is no API to upgrade read lock to write lock in modify_bars which c=
ould help,
> so in both cases vpci_write should take write lock.

Hmm, yes, I think you're right: It's not modify_bars() itself which needs
to acquire the write lock, but its (perhaps indirect) caller. Effectively
vpci_write() would need to take the write lock if the range written
overlaps the BARs or the command register.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 07 14:17:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 14:17:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.266999.460693 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH4q0-0000yv-8B; Mon, 07 Feb 2022 14:17:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 266999.460693; Mon, 07 Feb 2022 14:17:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH4q0-0000yo-54; Mon, 07 Feb 2022 14:17:52 +0000
Received: by outflank-mailman (input) for mailman id 266999;
 Mon, 07 Feb 2022 14:17:51 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=F54n=SW=epam.com=prvs=403792ff6c=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nH4pz-0000yg-5S
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 14:17:51 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b986f9ba-8820-11ec-8eb8-a37418f5ba1a;
 Mon, 07 Feb 2022 15:17:48 +0100 (CET)
Received: from pps.filterd (m0174679.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 217EEke8023747;
 Mon, 7 Feb 2022 14:17:45 GMT
Received: from eur04-he1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2052.outbound.protection.outlook.com [104.47.13.52])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e350ur0hx-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Mon, 07 Feb 2022 14:17:44 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by DU0PR03MB8161.eurprd03.prod.outlook.com (2603:10a6:10:350::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.17; Mon, 7 Feb
 2022 14:17:39 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77%3]) with mapi id 15.20.4951.018; Mon, 7 Feb 2022
 14:17:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b986f9ba-8820-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=IHIqcJc84klNqvwajaL8hRkCu6QfTWrEibdgZe5PdBDuDKJXO1DM1x+Rq5fYtWhyHSdMJkgS+qlorblmGXmIvYHrlpWxVgwTB6eH+XAB/m+osPWudRJYZTkSzOHrAyAHqnSAlpu7M7VUHhkfxgbDD3M17QCWB8qj5uYfvYf/1aNClg+vGlsrhOwelSN3zj3+9WGy1DgclSVlbmBIt5peClLZFCjb5JRcSKviVwn6oibpKMHmVuJHpaQ0cBg37wiCxTvwyJm6tlf3S7/f4YBW7vX+NGAJM+uaNzhSdnQU1pA+Z28d3JUAWFqTbxyMTDOW+e3eITGCBPyk/e6uy+kyUA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=e8rpdXTfmATKVvJzL2xVXLPvv37qTKoSS5f1czfgJ8g=;
 b=AL20v3A9+nQIWPe7GFo6B0TCXB22eJn+7MPYtYixNtOroWiw8SzaxygXuSFRi4qP5+/VAtIG081MhAjQRTOpyIHdTTmDPeXMOHjhhXtscucJ+UotVp4SVtnUpvbs3utegdQ/5Wj+Ap5iaAAYs+mZP+/piRSaVKhDxr9RfgEA+iorRv9HxeldAoIPN5dyQ+DR2udsMVIOV/gHKdqYlQQb1tiT9r/R1EmyrBlkDrs8BQf4vIGBk9Gyrpm7A+XQr8s5MPRvX8oDuc6BD4Ylt0z/TlgOLphWJw2xAutWjkqjR3QOiBnM1cs9Wv+H0ZlCnrANtYh/rVCA9Hhcm3DUtoMPIg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=e8rpdXTfmATKVvJzL2xVXLPvv37qTKoSS5f1czfgJ8g=;
 b=D4IwCv/AvG3JGk13Qca4n4fS1aOJzLfjt0K7XtdMXq20QJgVAkpS92bSHCq7gVgBk5aEMSmGkg9m9mNR513ZOrk0SmqgpV+8UQLIAff/WoKP9nNwahAYKRN76nNSs2YCJw5sg0T4DUsWcGADii3CJxm48yKdee9AvBIN1AvcHV34hNGwRv/odLCXxXWTzwdldIPmQBHvMH7hQ+A62wRbcGJEsh+nIgn3SZtnVifY2lghhOBQoFbDAR/M+aT4INEY3dckoQmIaKftcM5EqqmtxbDu3jG6MsVIVdvkFt3h6JFD4IdG010B7uSC1uLMtzXex9uPUKGoI4fX06uNuyYXAw==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "roger.pau@citrix.com" <roger.pau@citrix.com>,
        "andrew.cooper3@citrix.com"
	<andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com"
	<george.dunlap@citrix.com>,
        "paul@xen.org" <paul@xen.org>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>,
        Rahul Singh <rahul.singh@arm.com>,
        "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        Oleksandr
 Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v6 10/13] vpci/header: reset the command register when
 adding devices
Thread-Topic: [PATCH v6 10/13] vpci/header: reset the command register when
 adding devices
Thread-Index: 
 AQHYGZFg3nazYSvfA0G+yHTbxcxX2ayDdFgAgAAB6wCABD+NgIAAQmgAgAAT4YCAAAOjAIAAAPCAgAAXGIA=
Date: Mon, 7 Feb 2022 14:17:36 +0000
Message-ID: <f34cc940-7f5f-aebd-60d9-d1a3d85d1283@epam.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-11-andr2000@gmail.com>
 <96381d7e-dafc-acee-3abf-f9815deb207c@suse.com>
 <ef76faac-f9d3-1cb8-06b5-189ccd299542@epam.com>
 <6f0a015b-c48f-76ed-9a51-39c045ff5927@suse.com>
 <2ad372d4-a181-9307-ef50-a5adb61dae66@epam.com>
 <49380584-0577-96f2-ef1c-a96eabf0d227@suse.com>
 <fbd410d1-84ad-2309-ca05-b9ac7f95f1f9@epam.com>
 <dbef1c95-818c-427c-1963-75d584843cff@suse.com>
In-Reply-To: <dbef1c95-818c-427c-1963-75d584843cff@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 2270420e-0a25-48e6-016d-08d9ea449756
x-ms-traffictypediagnostic: DU0PR03MB8161:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <DU0PR03MB81610AB7F185F47C3E07918EE72C9@DU0PR03MB8161.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:5236;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 ITngoXg5HGUYZ08FLXHrVLG3fYJlT/i4Osca5NKc741w7zY++9C/CIdxPxdPGvvLhDXTtjv5AouMSWFmXrrBZDNa0i3rulnjZWZy121qoZAg6WCpVjvyf+6bKXBNA2B6slq53bxvcxtq3lx3ntTd/QO+bQj3QXmCSZUioAXt3Tz91nduKSN/wWnPgF5P6GGDXs3zKe/4uvH9h4EQLZZYYES9xoTmp+e46c8WvBbHsHdYMB5QlyAHIP9ruetzVcO8iVy+Y5+EgI1rwiTMrylWd8zk32rOYyUX650FdHi7YKB7kjGOPhUfmN7wzZdeNotaKqWJCtgCBcssMDAepMhuFLb/NbnI1IU8FyvP1YkW3pBTEqRpRMjvjgf5CLZTGqp/bQbgDg2uUvs4lmj/sUBK6NJ5c68n6CLbhclxTIBVVksyKs7gH+hIQa5ADjjO5UDtH2zONR1Nz9uMLdFJa4/zaK5w8+PgOrCgpLZtVh9B4s6LkzWwvGaW33ZpbvoOCvPuKGSNZINgbKQH/0PnpNrSB1sgIcD0rKxu4CtVjO5KokRt2GB1DD+/b9v49ULKuEdgwiBpXDQyCak8Vljuq223ntH8T+SyhXD11v57HXfBYGIqZk3tkpFrf2P6PFiW5Cebus9SKnhdXjF6rspKhuBqLt1qrhCNvPKzQSg9eipl729d+3pE1CBla4XRBRZgRaCufdtmtK5QVP0BRwVABngAUKMeTCD0nZyrJHUv+SED4DFTEfjaeKW2kchMQEc0/bQnbhLPhTqQ7MRpxNI2QborAB7w9Nt+h1/zHG5+2P2ZOKtPg1Xa/o2pwFb/Sxnz9euVT0ITlizpW2d7gtLqKWxl1uWrEY7ynhRhgIgUZTfBF7E=
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38070700005)(31686004)(186003)(83380400001)(2906002)(26005)(6512007)(31696002)(2616005)(122000001)(7416002)(5660300002)(107886003)(508600001)(55236004)(53546011)(38100700002)(86362001)(36756003)(6506007)(66446008)(8936002)(64756008)(66476007)(66556008)(66946007)(91956017)(4326008)(8676002)(71200400001)(6916009)(76116006)(54906003)(6486002)(316002)(966005)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?OGYwMkV4aWxUd0JJRkllWnR5RStKcEg0Z2krSDErUDZoWUUyb2xlcFFvTEVS?=
 =?utf-8?B?b1FZZDdPQ3BvdkFZNVdVc280N2s3ZFZsR0YwcXNScmg0dTRSSFpZQmJFd1NE?=
 =?utf-8?B?aHJILzlJK1JTbjhSMkVHMnJJS09OR2JDOWhZZ0VPZWQrVEoxSytHMDEyK2JR?=
 =?utf-8?B?Zkd1WGJyWG1TdmtncmxkVmtEUCttWFFFcURxdWhjQmdZSUQ3MWZmUWtXNXBo?=
 =?utf-8?B?S3J3WnZyRTdXRUd1bGdDYW1xT2xEOXppN3I3Nit5RlVkcnpicjNydmFSOUpa?=
 =?utf-8?B?SXhJRTJWdFZBL0pFajA5ZitmWkg3Z1RybHhNRDRyb2srWTBTc2xBaDZuZ0pp?=
 =?utf-8?B?d095QmR4MlkwYTg3RXhlZFI4RHVKQnBZY2VCY1NQMTU5eXBxaTNNcEJzL0Fx?=
 =?utf-8?B?ZEhuTXNHUEdZZjFCeDZsMXRsUVkvMC91dFJXeGhaQ0F2V3F2WkNIUUxVRHVr?=
 =?utf-8?B?L1hiSDBPZnVlbW9RT3BuNG9vV2o5bGJPeFVmMm52OTA4VGFwSmluVTRpY2xW?=
 =?utf-8?B?TjJiUlh5UDZzZlJMTC9WaW5aRTYzWjhiRm1oMWFLZkh2bEZlNkloWGMzRlVj?=
 =?utf-8?B?TXBXSGFxeDZEWHlOYkxZL0NjL29HOEJNdjQ1dkxJOUEwVkkyd2drRHhFdVlO?=
 =?utf-8?B?YS9URktERmxlRHlVNWZqZ3dVS2RHZCt6RjBNSGk1Mys5dFJEdjUvaUdkN0Fq?=
 =?utf-8?B?ZGZhdkJIMUhwZGdLaXBaOTlYVy9HSE9hZ3F1eUJrakZCSnlaeFpKZjlYSDNQ?=
 =?utf-8?B?Tk1PSERRSmsySDh1MkpISVZ2QWVzNzV4UExKTDJsVVZQVkwrN2tFOU5hRWhu?=
 =?utf-8?B?LzF5Z1pPNEVHRkRmRWh2Z29HemFrNjBrNnRnWW1JdkpNZ3dGbGVzRVFiV2Q1?=
 =?utf-8?B?cFdkTmhyZ2ptVVRtVXhkYUMwUmZ0aFIrT2d0MlJsS1U0L1J2QzdUeEZ4N0c3?=
 =?utf-8?B?L0ZJT29DY090WmNPblMxczJFK0IwUU1xK0E5VWRWdnB6b3ZkVFhEdzh6eDJr?=
 =?utf-8?B?VG5jV0FpdkdDNkZnMlVKcnhFcnZjVXVSc0lzdzlrbjZsbllnaTBQaEJudFFr?=
 =?utf-8?B?UXBLWEt2ZXFkOHVGZGpTNmFNd3ZPVXY5ZEhzOW1rMGNOelIvakN2dDF5NTM3?=
 =?utf-8?B?SUIzVHVpdmxQRlRJODJZZmg2VlZVQTlGSkZ6UjM5K0pwc0c2Y3cvbTQvWFlx?=
 =?utf-8?B?UXd3VXlUSXpFbUQvaExBS0Erd2NXVU8wcXAvSWZRN1RWMUxxQVNYVG43N2VF?=
 =?utf-8?B?bngwNVNoeS9LMEdoZzhXNnJGdmRHUTlqUTZFL0l4OU0wdThzTGhSRlpIZlcz?=
 =?utf-8?B?S1RaZTZtZmxobE9vQzRVdXVDT2xNYUo1RlFXMTRqbnJjbUtBYitRUDJJdDZD?=
 =?utf-8?B?a0FYMUNTdldRY0pQOVIxZmpaQmM0WDhwbnBCaUx1UnVQcG9YRjJqc2dUdG9D?=
 =?utf-8?B?dWJXV1AxQlUyUXQ0VXhnWlZGTnZQeGZrZ2xDVDZxaEgzbUZXZ2d6aXlPdGZn?=
 =?utf-8?B?a25BWkdEK3I3ekp6RWlEUTVZQVkwTlY3ZURRc291eldsTnNoL3ozUGZnV0c3?=
 =?utf-8?B?V3dKdklIUmJvTWlDcGJkbW5iVHk2a0tGRythNnEyaVFUQjdQRFlkTlhYeFRB?=
 =?utf-8?B?eHdqWkJud1pxR3J2NnRFTkFGZU5xZUJPL1A5RFFvMmJoT2E3M1J6SXVLeGJx?=
 =?utf-8?B?L29hZ2xnYTIySzk3U0lNaVpGcTJGSWwzNW1tU2oybWwrQWpnNW43N0x3Nk9F?=
 =?utf-8?B?WEZhZnZRN1g3Yy9CejFCY3hDNEl1eGluTzRmeElScmc1TEtyL21OWG1qb3pi?=
 =?utf-8?B?Y2N4dlB2dFZ0ZzVUblM1dzA4MWNWd09NRFlUSG1KTEw2VFJGTWR2MGJ6Ujd1?=
 =?utf-8?B?aVk2ZlREcjZ0bzN5WW91d2kwQ2wzZk5JMGYzUlBMTEJrWFkwbzhKUktmVFFJ?=
 =?utf-8?B?bWRTR01rUDVJZmNTRnVwd08vN3BDa0xzR215MVVJR1hOWmxTcGo3REI3by9u?=
 =?utf-8?B?QWUxZW9Fak84SzJoYWtYTEFhdW04bGJDQnF1TmhSa2QxWjJvd21tVXdKem85?=
 =?utf-8?B?SmJxV0ZiVjFOdnE5dTdtbFdvUmkyYitDK0hGanovQ2gwb3RTZUw5STN6RDds?=
 =?utf-8?B?Z240dVdJbUIrR0RqZ2NiaitKalZ4STBMSUV0TFlGS0J6MzR1OElEc2p4aFR0?=
 =?utf-8?B?THdQQU9lcmttTWF5VytTQ01yZWZwTCtIT2Q2cy9YS3EzR3FBb1JCSk9BWWlZ?=
 =?utf-8?B?dG9oQ1BxaCs1NlhGdE9PZFVaUEdnYmhRUHdOdVdWVytYc2l0NC9rTk9PR2c0?=
 =?utf-8?B?T2cxNjd3ZEhHeUFZWkwvUWp0WlE4ZmJ3OVhwcktCdkhiWmQ0R2Q0Zz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <E68137B4CF247E4D8B60690E507F13D5@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2270420e-0a25-48e6-016d-08d9ea449756
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Feb 2022 14:17:36.6057
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: hvKgFDkiSxlLxvtFYX1iBoANOVKImlsfLvHNvPiTFEHXhmgrvScZyBuaL9hVqAPxQmGTPcdZL0e3pm05ySTYvrGcH0jyQPe5GhaI4RmlTRRuJOKOI+SPGftyXxTJopAH
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR03MB8161
X-Proofpoint-GUID: CeXT7c2qfJTAXVTt9cCjtMojXV92fRDo
X-Proofpoint-ORIG-GUID: CeXT7c2qfJTAXVTt9cCjtMojXV92fRDo
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-07_05,2022-02-07_02,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1015
 impostorscore=0 phishscore=0 mlxscore=0 spamscore=0 priorityscore=1501
 lowpriorityscore=0 mlxlogscore=999 bulkscore=0 malwarescore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202070092

DQoNCk9uIDA3LjAyLjIyIDE0OjU0LCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMDcuMDIuMjAy
MiAxMzo1MSwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+Pg0KPj4gT24gMDcuMDIu
MjIgMTQ6MzgsIEphbiBCZXVsaWNoIHdyb3RlOg0KPj4+IE9uIDA3LjAyLjIwMjIgMTI6MjcsIE9s
ZWtzYW5kciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4+PiBPbiAwNy4wMi4yMiAwOToyOSwgSmFu
IEJldWxpY2ggd3JvdGU6DQo+Pj4+PiBPbiAwNC4wMi4yMDIyIDE1OjM3LCBPbGVrc2FuZHIgQW5k
cnVzaGNoZW5rbyB3cm90ZToNCj4+Pj4+PiBPbiAwNC4wMi4yMiAxNjozMCwgSmFuIEJldWxpY2gg
d3JvdGU6DQo+Pj4+Pj4+IE9uIDA0LjAyLjIwMjIgMDc6MzQsIE9sZWtzYW5kciBBbmRydXNoY2hl
bmtvIHdyb3RlOg0KPj4+Pj4+Pj4gUmVzZXQgdGhlIGNvbW1hbmQgcmVnaXN0ZXIgd2hlbiBhc3Np
Z25pbmcgYSBQQ0kgZGV2aWNlIHRvIGEgZ3Vlc3Q6DQo+Pj4+Pj4+PiBhY2NvcmRpbmcgdG8gdGhl
IFBDSSBzcGVjIHRoZSBQQ0lfQ09NTUFORCByZWdpc3RlciBpcyB0eXBpY2FsbHkgYWxsIDAncw0K
Pj4+Pj4+Pj4gYWZ0ZXIgcmVzZXQuDQo+Pj4+Pj4+IEl0J3Mgbm90IGVudGlyZWx5IGNsZWFyIHRv
IG1lIHdoZXRoZXIgc2V0dGluZyB0aGUgaGFyZHdhcmUgcmVnaXN0ZXIgdG8NCj4+Pj4+Pj4gemVy
byBpcyBva2F5LiBXaGF0IHdhbnRzIHRvIGJlIHplcm8gaXMgdGhlIHZhbHVlIHRoZSBndWVzdCBv
YnNlcnZlcw0KPj4+Pj4+PiBpbml0aWFsbHkuDQo+Pj4+Pj4gInRoZSBQQ0kgc3BlYyBzYXlzIHRo
ZSBQQ0lfQ09NTUFORCByZWdpc3RlciBpcyB0eXBpY2FsbHkgYWxsIDAncyBhZnRlciByZXNldC4i
DQo+Pj4+Pj4gV2h5IHdvdWxkbid0IGl0IGJlIG9rPyBXaGF0IGlzIHRoZSBleGFjdCBjb25jZXJu
IGhlcmU/DQo+Pj4+PiBUaGUgY29uY2VybiBpcyAtIGFzIHZvaWNlZCBpcyBzaW1pbGFyIHdheXMg
YmVmb3JlLCBwZXJoYXBzIGluIG90aGVyDQo+Pj4+PiBjb250ZXh0cyAtIHRoYXQgeW91IG5lZWQg
dG8gY29uc2lkZXIgYml0LWJ5LWJpdCB3aGV0aGVyIG92ZXJ3cml0aW5nDQo+Pj4+PiB3aXRoIDAg
d2hhdCBpcyBjdXJyZW50bHkgdGhlcmUgaXMgb2theS4gWGVuIGFuZC9vciBEb20wIG1heSBoYXZl
IHB1dA0KPj4+Pj4gdmFsdWVzIHRoZXJlIHdoaWNoIHRoZXkgZXhwZWN0IHRvIHJlbWFpbiB1bmFs
dGVyZWQuIEkgZ3Vlc3MNCj4+Pj4+IFBDSV9DT01NQU5EX1NFUlIgaXMgYSBnb29kIGV4YW1wbGU6
IFdoaWxlIHRoZSBndWVzdCdzIHZpZXcgb2YgdGhpcw0KPj4+Pj4gd2lsbCB3YW50IHRvIGJlIHpl
cm8gaW5pdGlhbGx5LCB0aGUgaG9zdCBoYXZpbmcgc2V0IGl0IHRvIDEgbWF5IG5vdA0KPj4+Pj4g
ZWFzaWx5IGJlIG92ZXJ3cml0dGVuIHdpdGggMCwgb3IgZWxzZSB5b3UnZCBlZmZlY3RpdmVseSBp
bXBseSBnaXZpbmcNCj4+Pj4+IHRoZSBndWVzdCBjb250cm9sIG9mIHRoZSBiaXQuDQo+Pj4+IFdl
IGhhdmUgYWxyZWFkeSBkaXNjdXNzZWQgaW4gZ3JlYXQgZGV0YWlsIFBDSV9DT01NQU5EIGVtdWxh
dGlvbiBbMV0uDQo+Pj4+IEF0IHRoZSBlbmQgeW91IHdyb3RlIFsxXToNCj4+Pj4gIldlbGwsIGlu
IG9yZGVyIGZvciB0aGUgd2hvbGUgdGhpbmcgdG8gYmUgc2VjdXJpdHkgc3VwcG9ydGVkIGl0IG5l
ZWRzIHRvDQo+Pj4+IGJlIGV4cGxhaW5lZCBmb3IgZXZlcnkgYml0IHdoeSBpdCBpcyBzYWZlIHRv
IGFsbG93IHRoZSBndWVzdCB0byBkcml2ZSBpdC4NCj4+Pj4gVW50aWwgeW91IG1lYW4gdlBDSSB0
byByZWFjaCB0aGF0IHN0YXRlLCBsZWF2aW5nIFRPRE8gbm90ZXMgaW4gdGhlIGNvZGUNCj4+Pj4g
Zm9yIGFueXRoaW5nIG5vdCBpbnZlc3RpZ2F0ZWQgbWF5IGluZGVlZCBiZSBnb29kIGVub3VnaC4N
Cj4+Pj4NCj4+Pj4gSmFuIg0KPj4+Pg0KPj4+PiBTbywgdGhpcyBpcyB3aHkgSSBsZWZ0IGEgVE9E
TyBpbiB0aGUgUENJX0NPTU1BTkQgZW11bGF0aW9uIGZvciBub3cgYW5kIG9ubHkNCj4+Pj4gY2Fy
ZSBhYm91dCBJTlR4IHdoaWNoIGlzIGhvbm9yZWQgd2l0aCB0aGUgY29kZSBpbiB0aGlzIHBhdGNo
Lg0KPj4+IFJpZ2h0LiBUaGUgaXNzdWUgSSBzZWUgaXMgdGhhdCB0aGUgZGVzY3JpcHRpb24gZG9l
cyBub3QgaGF2ZSBhbnkNCj4+PiBtZW50aW9uIG9mIHRoaXMsIGJ1dCBpbnN0ZWFkIHRhbGtzIGFi
b3V0IHNpbXBseSB3cml0aW5nIHplcm8uDQo+PiBIb3cgZG8geW91IHdhbnQgdGhhdCBtZW50aW9u
ZWQ/IEV4dGVuZGVkIGNvbW1pdCBtZXNzYWdlIG9yDQo+PiBqdXN0IGEgbGluayB0byB0aGUgdGhy
ZWFkIFsxXT8NCj4gV2hhdCBJJ2QgbGlrZSB5b3UgdG8gZGVzY3JpYmUgaXMgd2hhdCB0aGUgY2hh
bmdlIGRvZXMgd2l0aG91dA0KPiBmdW5kYW1lbnRhbGx5IGltcGx5aW5nIGl0J2xsIGVuZCB1cCBi
ZWluZyB6ZXJvIHdoaWNoIGdldHMgd3JpdHRlbg0KPiB0byB0aGUgcmVnaXN0ZXIuIFN0YXRpbmcg
YXMgYSBjb25jbHVzaW9uIHRoYXQgZm9yIHRoZSB0aW1lIGJlaW5nDQo+IHRoaXMgbWVhbnMgd3Jp
dGluZyB6ZXJvIGlzIGNlcnRhaW5seSBmaW5lIChhbmQgbGlrZWx5IGhlbHBmdWwgaWYNCj4gbWFk
ZSBleHBsaWNpdCkuDQpYZW4gYW5kL29yIERvbTAgbWF5IGhhdmUgcHV0IHZhbHVlcyBpbiBQQ0lf
Q09NTUFORCB3aGljaCB0aGV5IGV4cGVjdA0KdG8gcmVtYWluIHVuYWx0ZXJlZC4gUENJX0NPTU1B
TkRfU0VSUiBiaXQgaXMgYSBnb29kIGV4YW1wbGU6IHdoaWxlIHRoZQ0KZ3Vlc3QncyB2aWV3IG9m
IHRoaXMgd2lsbCB3YW50IHRvIGJlIHplcm8gaW5pdGlhbGx5LCB0aGUgaG9zdCBoYXZpbmcgc2V0
DQppdCB0byAxIG1heSBub3QgZWFzaWx5IGJlIG92ZXJ3cml0dGVuIHdpdGggMCwgb3IgZWxzZSB3
ZSdkIGVmZmVjdGl2ZWx5DQppbXBseSBnaXZpbmcgdGhlIGd1ZXN0IGNvbnRyb2wgb2YgdGhlIGJp
dC4gVGh1cywgUENJX0NPTU1BTkQgcmVnaXN0ZXIgbmVlZHMNCnByb3BlciBlbXVsYXRpb24gaW4g
b3JkZXIgdG8gaG9ub3IgaG9zdCdzIHNldHRpbmdzLg0KDQpUaGVyZSBhcmUgZXhhbXBsZXMgb2Yg
ZW11bGF0b3JzIFsxXSwgWzJdIHdoaWNoIGFscmVhZHkgZGVhbCB3aXRoIFBDSV9DT01NQU5EDQpy
ZWdpc3RlciBlbXVsYXRpb24gYW5kIGl0IHNlZW1zIHRoYXQgYXQgbW9zdCB0aGV5IGNhcmUgYWJv
dXQgdGhlIG9ubHkgSU5UWA0KYml0IChiZXNpZGVzIElPL21lbW9yeSBlbmFibGUgYW5kIGJ1cyBt
dXN0ZXIgd2hpY2ggYXJlIHdyaXRlIHRocm91Z2gpLg0KSXQgY291bGQgYmUgYmVjYXVzZSBpbiBv
cmRlciB0byBwcm9wZXJseSBlbXVsYXRlIHRoZSBQQ0lfQ09NTUFORCByZWdpc3Rlcg0Kd2UgbmVl
ZCB0byBrbm93IGFib3V0IHRoZSB3aG9sZSBQQ0kgdG9wb2xvZ3ksIGUuZy4gaWYgYW55IHNldHRp
bmcgaW4gZGV2aWNlJ3MNCmNvbW1hbmQgcmVnaXN0ZXIgaXMgYWxpZ25lZCB3aXRoIHRoZSB1cHN0
cmVhbSBwb3J0IGV0Yy4NClRoaXMgbWFrZXMgbWUgdGhpbmsgdGhhdCBiZWNhdXNlIG9mIHRoaXMg
Y29tcGxleGl0eSBvdGhlcnMganVzdCBpZ25vcmUgdGhhdC4NCk5laXRoZXIgSSB0aGluayB0aGlz
IGNhbiBiZSBlYXNpbHkgZG9uZSBpbiBYZW4gY2FzZS4NCg0KQWNjb3JkaW5nIHRvICJQQ0kgTE9D
QUwgQlVTIFNQRUNJRklDQVRJT04sIFJFVi4gMy4wIiwgc2VjdGlvbiAiNi4yLjINCkRldmljZSBD
b250cm9sIiBzYXlzIHRoYXQgdGhlIHJlc2V0IHN0YXRlIG9mIHRoZSBjb21tYW5kIHJlZ2lzdGVy
IGlzDQp0eXBpY2FsbHkgMCwgc28gcmVzZXQgdGhlIGNvbW1hbmQgcmVnaXN0ZXIgd2hlbiBhc3Np
Z25pbmcgYSBQQ0kgZGV2aWNlDQp0byBhIGd1ZXN0IHQgYWxsIDAncyBhbmQgZm9yIG5vdyBvbmx5
IG1ha2Ugc3VyZSBJTlR4IGJpdCBpcyBzZXQgYWNjb3JkaW5nDQp0byBpZiBNU0kvTVNJLVggZW5h
YmxlZC4NCg0KWzFdIGh0dHBzOi8vZ2l0aHViLmNvbS9xZW11L3FlbXUvYmxvYi9tYXN0ZXIvaHcv
eGVuL3hlbl9wdF9jb25maWdfaW5pdC5jI0wzMTANClsyXSBodHRwczovL2dpdGh1Yi5jb20vcHJv
amVjdGFjcm4vYWNybi1oeXBlcnZpc29yL2Jsb2IvbWFzdGVyL2h5cGVydmlzb3IvaHcvcGNpLmMj
TDMzNg0KDQpXaWxsIHRoZSBhYm92ZSBkZXNjcmlwdGlvbiBiZSBlbm91Z2g/DQoNCkl0IGFsc28g
c2VlbXMgdG8gYmUgYSBnb29kIG1vdmUgdG8gc3F1YXNoIHRoZSBmb2xsb3dpbmcgcGF0Y2hlczoN
CltQQVRDSCB2NiAwOS8xM10gdnBjaS9oZWFkZXI6IGVtdWxhdGUgUENJX0NPTU1BTkQgcmVnaXN0
ZXIgZm9yIGd1ZXN0cw0KW1BBVENIIHY2IDEwLzEzXSB2cGNpL2hlYWRlcjogcmVzZXQgdGhlIGNv
bW1hbmQgcmVnaXN0ZXIgd2hlbiBhZGRpbmcgZGV2aWNlcw0KDQphcyB0aGV5IGltcGxlbWVudCBh
IHNpbmdsZSBwaWVjZSBvZiBmdW5jdGlvbmFsaXR5IG5vdy4NCj4+IFdpdGggdGhlIGFib3ZlIGRv
bmUsIGRvIHlvdSB0aGluayB0aGF0IHdyaXRpbmcgMCdzIGlzIGFuIGFjY2VwdGFibGUNCj4+IGFw
cHJvYWNoIGFzIG9mIG5vdz8NCj4gV2VsbCwgeWVzLCBwcm92aWRlZCB3ZSBoYXZlIGEgc3VmZmlj
aWVudGx5IHNpbWlsYXIgdW5kZXJzdGFuZGluZw0KPiBvZiB3aGF0ICJhY2NlcHRhYmxlIiBoZXJl
IG1lYW5zLg0KPg0KPiBKYW4NCj4NClRoYW5rIHlvdSwNCk9sZWtzYW5kcg==


From xen-devel-bounces@lists.xenproject.org Mon Feb 07 14:19:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 14:19:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267007.460704 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH4rd-0001as-Kh; Mon, 07 Feb 2022 14:19:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267007.460704; Mon, 07 Feb 2022 14:19:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH4rd-0001al-Gw; Mon, 07 Feb 2022 14:19:33 +0000
Received: by outflank-mailman (input) for mailman id 267007;
 Mon, 07 Feb 2022 14:19:32 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=hYSm=SW=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nH4rb-0001aN-Nz
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 14:19:31 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f4b0758b-8820-11ec-8eb8-a37418f5ba1a;
 Mon, 07 Feb 2022 15:19:29 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f4b0758b-8820-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644243569;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=z+qQ1BJWH3Lg23iiCmDq7BXv2Pw8ho6v4ITMlzIp+zc=;
  b=EdSoJKzPChlKqQBIvtDzok2aj0Z53AaY+X0qJryuzW54JFNbRtAKODra
   8g8GHij+Y4yhr7OYI/l9952Ey/B0uuwgvme+lCPPjXZ9rVXDQ9kikq2EH
   P1pUrLvNO4o7XC09R6T8PTXV37DFwuaZ27YgcLxGhfgUd+2YhXLYoaAc+
   8=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: ChSud4KGdLmQ+eAnpWWn4ZDCv8nX5pnFRATy3o6pnkna7SCg9C6cU8y1dmKwlnkfUgMlVLmMuF
 f28e4ckQk/cVcHZrYeXLQBkKRX0OIe4Ncg0w9x3ccuynmL3XpbU2sr0q2pPIPHGYAcTfs/FHrZ
 RPe2WWQV4CLIYfzJj1439VmCKoHyMPffpugsFPXguOV+rF2csPURmgIHrkTAwarDZ7WXpXIjbj
 jPgegiJIQeYUgPny5j80XntbIPGNTQNu4mVCe/rEtFkFzxM8LVKYGrTsuxerzlYOr1tHdV4WJm
 ORL8V7fqo1kZzXY8DV3I2dfr
X-SBRS: 5.1
X-MesageID: 63648670
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:h7zCm66qeJt5BJnypm9sZwxRtBjBchMFZxGqfqrLsTDasY5as4F+v
 mAWXWGEPv2MYGXzf4t3YNixoxxXsMKGn9FiTlQ9/Hw1Hi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FV8MpBsJ00o5wbZj2tEw27BVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zk
 /hn7qCgElkSPJbHid05CxxaLgMuIvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALNs7kMZlZonh95TrYEewnUdbIRKCiCdpwgmxu2pAQQq62i
 8wxbSg2SQjFaC90CF49EKkQt8bwgUemfGgNwL6SjfVuuDWCpOBr65D1OcfRUsyHQ4NShEnwj
 kvc42n8NTQLO9WexCSt/2qlg6nEmiaTcIgfDqGi//hmxlia3HUOCQY+XEG+5/K+jyaWS99Zb
 kAZ5Ccqhawz71CwCMnwWQWip3yJtQJaXMBfe8Ug4QGQzuzP4gCWBkANVDsHY9sj3OcIQjgt2
 k6MjsneLzVlu72ISlqQ7r6R6zi1PEA9L2UPeCsFRgst+MT4rcc4iRenZvFnHa2uh9v5AwbZx
 TyQsTM+jLUei80M/6ij9FWBiDWpzrDLUwo06wP/Tm+jqARja+aNQIil6kPS6/paG7qIVVmKv
 HUCmM+24fgHCNeGkynlaP4WALij6vKBMTvdqV1iBZ8s83Kq4XHLQGxLyGggfgEzaJ9CIGK3J
 h+I0e9M2HNNFCCHR/RLc9nvMMYRxrnZMYzgVM32PsUbN/CdazS71C1pYEeR2UXkn04tjbwzN
 P+nTCq8MZoJIf85lWTrHo/xxZdun3ljnj2LGfgX2jz6ieL2WZKDdVsS3LJihMgd5bjMngja+
 s032yCim0QGC72WjsU6HOcuwbE2wZoTWMqeRy9/LLfrzu9a9IYJUa65/F/ZU9Y595m5b8+Rl
 p1HZmdWyUDkmVrMIhiQZ3ZoZdvHBMgj8StqZHVybAzxgBDPhLpDC49FJvMKkUQPrrQ/nZaYs
 dFZEyl/Phi/YmueoGlMBXUMhIdjaA6qlWqz09mNO1ACk2pbb1WRoLfMJ1K3nAFXV3bfnZZu8
 tWIi1KAKbJeFlsKJJiNMpqHkQju1UXxbcovBiMk1PEIIx6ymGWrQgSs5sIKzzYkc0malmDEh
 lrJXX/1Z4Dl+ucIzTUAvojdx6+BGOpiBEtKWW7d6Le9Ly7B+WS/h4RHVY61kfr1DgsYIY2uO
 rdYye/SKvoCkAoYuoZwCe8zn6k/+8Hut/lRyQE9RCfHaFGiC7VBJHia3JYQ6v0Rl+EB4QbmC
 FiS/tR6OKmSPJ+3GlAmOwd4PP+I0usZm2eO4K1tcln6/iJ+4JGOTV5WY0uXkCVYIbYsaNElz
 O4ttdQ48Qu6jhZ2YN+KgjoNrzaHL2AaUrVhvZYfWde5hg0uw1BEQJrdFi6pv83fN4QSahEne
 2bGirDDirJQwlv5X0AyTXWdj/BAgZkuuQxRyANQLVq+hdeY1OQ82wdc8GprQ10NnAlHye96J
 kNiK1ZxefeV5z5ticVOAzKsFgVGCEHL80D90QJUxmjQTk3uXW3RNmwtf+2K+RlBoW5bezFa+
 pCeyXrkDmm2LJ2ggHNqVB43seHnQPxw6hbGyZKuEMmyFpUnZSbo3/21bm0Sphq7Wc48iSUrf
 wWxEDqcvUEjCRMtng==
IronPort-HdrOrdr: A9a23:yQNK76qTvzQe4dUKHPa2ICMaV5uzL9V00zEX/kB9WHVpm5Oj+P
 xGzc526farslsssREb+OxpOMG7MBThHLpOkPMs1NCZLXTbUQqTXfpfBO7ZrQEIdBeOlNK1uZ
 0QFpSWTeeAcWSS7vyKkTVQcexQueVvmZrA7Yy1rwYPcegpUdAZ0+4QMHfkLqQcfnghOXNWLu
 v52iIRzADQBkj/I/7LTUUtbqzmnZnmhZjmaRkJC1oO7xSPtyqh7PrfHwKD1hkTfjtTyfN6mF
 K13jDR1+GGibWW2xXc32jc49B/n8bg8MJKAIiphtIOIjvhpw60bMBKWqGEvhoyvOazgWxa2u
 XkklMFBYBe+nnRdma6rV/E3BTh6i8n7zvYxVqRkRLY0LrEbQN/L/AEqZNScxPf5UZllsp7yr
 h302WQsIcSJQ/cnQzmjuK4GS1Cpw6Rmz4PgOQTh3tQXc81c7lKt7ES+0tTDdMpAD/60oY6C+
 NjZfusq8q+SWnqL0wxg1Mfg+BFBh8Ib1W7qwk5y4CoOgFt7TFEJxBy/r1bop8CnKhNPKWsqd
 60dpiAr4s+PfP+W5gNcNvpcfHHelAlfii8Ql56AW6XXZ3vaEi946Ie3t0OlZSXkdozvdwPpK
 g=
X-IronPort-AV: E=Sophos;i="5.88,350,1635220800"; 
   d="scan'208";a="63648670"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Erq9s3DshoVbOuueouQIiBhO7oiSn7WWHgMm/t//hLYj2VbfL32BiA4YZ/C70b7eagu1pZAHHtrj/36a/hoaU9ngKuYNltwG5/qrUEcp15PidhHUbLd6XtsOskT3Dz9FKjXKJxV+efix2reo4GRqVr85yHiGFMmtLnZUhmj68/U69468kpRUvnS51cygJ78LgQBV+z1lgH2DkuAPk8RxRLwHWKCWdPsvyfRCNOwbblRNiEmLdPGTmCiimB4h/I0aN6FCIJGcSIgRL9HdfkzgL60wPI+X+6X6PeNLrshGG2G0HV5g13ng8zmTgh9s6F7pc2QCtThObP35d9KVA9mrUw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=CtBuAKzR6Tk5ZeZL0ME6i0V2Jq+Z2Q1SPr1dLxa5jDg=;
 b=GMTIhQQquFo8z4ySc3BIX6wvP9/qqzozrEJinbY5Sx3X9kptGMHOllbciBH9kzLZDlu+Gx6g9QtnuEFg+oIeHMrzDsKw7p9o2RTiUDzY8VnOP9zfhkGT1tcKiZvBZ20ANfdaAWUZpxPXKP0MHm5Pvuki4s3otrIRlK3vqh343hy0llIyo/wbp7A564UR2VMuneFNpJujz0H4eq3MW1/yopNTDRm+K56+ImfElmhtUco1FeDWjYutTUX2CQ3AS4bNf1rkUKk1XU9+AJB79z3HbhvCFuDPa/yE/sWlhi9GgPUporl4dGi4vpvgWxaiaqNGuvIZUdk/kd8BM1dT4N2ROw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=CtBuAKzR6Tk5ZeZL0ME6i0V2Jq+Z2Q1SPr1dLxa5jDg=;
 b=Figi42tM2DLxJee9MVKf98AifliqDJ1L8wH3ZaX7azgHYrqiQhYBHp1N7ACZSb8EX/oiHg9aqT+6qwtxNxp9JvSbKQv3kZo8eye1IkfrRXDmKX8dMcKL0NshAFyrGrQgGGhyVOAEuI0dK1IejncORs6C7lP2VzFEMuUJK7ubpDA=
Date: Mon, 7 Feb 2022 15:19:10 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: Jan Beulich <jbeulich@suse.com>, "julien@xen.org" <julien@xen.org>,
	"sstabellini@kernel.org" <sstabellini@kernel.org>, Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Artem Mygaiev <Artem_Mygaiev@epam.com>,
	"andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
	"george.dunlap@citrix.com" <george.dunlap@citrix.com>, "paul@xen.org"
	<paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>, Rahul Singh
	<rahul.singh@arm.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Message-ID: <YgEqXhxOqKq92+Xn@Air-de-Roger>
References: <1ed0e342-16cd-2f16-c05c-186667a22762@suse.com>
 <7e3562b5-fc67-f213-e872-f211450d9e2e@epam.com>
 <a8fc599c-f620-c4d1-2077-c57068f46a7f@suse.com>
 <deef8468-d607-e49e-f456-6a8013329ca1@epam.com>
 <Yf0k6aoKK5G3iad1@Air-de-Roger>
 <3ad10a99-c706-b95f-1419-2c0c7cf37d58@epam.com>
 <Yf0+3C9nF8+tewLw@Air-de-Roger>
 <c5fea3bb-834b-eeb7-d7a1-1ee609037a9f@epam.com>
 <YgEUwTxhnWVMGMJK@Air-de-Roger>
 <9ce90193-74a0-5642-d22b-6b8c3340c3cf@epam.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <9ce90193-74a0-5642-d22b-6b8c3340c3cf@epam.com>
X-ClientProxiedBy: LO2P265CA0183.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:a::27) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 694b8e01-3ce4-4cdb-ef0b-08d9ea44d1cf
X-MS-TrafficTypeDiagnostic: PH0PR03MB5734:EE_
X-Microsoft-Antispam-PRVS: <PH0PR03MB5734E1E8A786CD9689C0DDCA8F2C9@PH0PR03MB5734.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: rq+MnS+fGlqb5NavoQ2NlKoW3TZDWYmPECz+4E+CR3zqphehPzuaR612rxl2Xdh1b6bIrmgW5bgH35iJAhEWt3snrgyr1Oq4ffannDM10n61kTC0xv0JwhqYFE3cS3IwzL7ZGidL3whpuEezjAVXE2Hd9Ob1uULA1cmGtmO8fr6lwKsQE7l7YyySm1exzAQSThb1maJpuuJieotyVmUV6Cu7Vu3+ijAeRvudnMK0G3lwvfvdeKgQ+OYwh2x40E66gQP0zwW3UaUq3kRVp+3IB0BYzsj0gAFQ0mept7B2jQvWiCrqQ7lSn7deOI5MxdX/5qICbVjc/mg6WpMigJV5a5pD3xqXtRc71td8PRNuFg7LXk7bXP07uWk7Nd3GYuKDfLFbrvETxyPI5pjStnG/hVPbtVrjfNkWEzDoQiYeBLnuKlMUhRSQkzHXYfDOGzsVXFlhLNBHoESyQCW4kgpDNUyG30ITYmMnM2aGRaVg+1YQl1Vmyf3yzBC0iUQivk6yUDTihlbUtwP4j0K5vtbQWbzEWGEzE12Or5tt8NBdbUp+z0rCjXg0n7rSfPOKTmW3pfpz+Uos5IDbyKF1LGDIaklqcN3Ccp9fG8MeJ4+8/lPOmOudAuuw+MVLQgOIrKf/pyaqZlDtPDb98PfqxjTndvdomhTCpXIFMzPzAdLCQ3YT9BjHJhT6IQtUbCKmkUOa6NE6KHfI6U00rc142nsvcQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(6506007)(2906002)(54906003)(33716001)(66946007)(316002)(6916009)(508600001)(38100700002)(6666004)(82960400001)(83380400001)(5660300002)(8676002)(4326008)(26005)(86362001)(7416002)(66476007)(186003)(66556008)(53546011)(6486002)(85182001)(6512007)(9686003)(8936002)(67856001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VS9QM1RyRTAzUHJlZXBmMENzbzZGSU85WlZ4OERZUUJsWU5aSzVHK1g0UnVF?=
 =?utf-8?B?RmVTaGlBMm41V1Ayd2h5YWJ0ZUV5TmEvREtxTjJRY3Rwd3p1UlkyRjVaekVP?=
 =?utf-8?B?cDQySEp2NjhzbFVJTFBLSlBMN2NEOHpXZzFrREplVkhLWFBCUVNwaXExZVdq?=
 =?utf-8?B?bnRNdVVHZ2kwYzlaMERnSEtoOU1JY1dvcHFZRFNDdXpTVHBrbzMrRktJR3cv?=
 =?utf-8?B?d1ROcWovVDVTUVBZUzlWWHlPQ08zUklsdTl2SUlDU0x1T1lHeDVvSkd3NDN6?=
 =?utf-8?B?RUZJZUNHZ2pPTEF4aTgrTDU0UmhWVERGK2EvTnN1WnI4S0d3TVhjMEJXdEYv?=
 =?utf-8?B?ODU0a21qaUMvd1EvdnFic0pyeDRRSTl2UUhmZDBidVh2N0R4MlQvUHc2aWh4?=
 =?utf-8?B?aDJ4VUJpbXd6ZGhxempzVGR6NERYYUtVMU91ZjFGV0dmZE1KcGJBTjdpUnEv?=
 =?utf-8?B?TVUvT05zMkhsTzdCR3pQMDJTUFM5amRnaXFieXdaZ01xeDJ0TGh5QWZJRHNS?=
 =?utf-8?B?M0diWGFyajI3MHMzcWx6bzl1OGMvVnR1cC9wUzN3MXkvdGNLWnZRZ1lRSllU?=
 =?utf-8?B?TUljeWhNODJybkR1Y0lqdUJyNFlwbzhyWmpNRzV5WUEyQjB3RlEvcy92UVlz?=
 =?utf-8?B?N0JDTm9FYm0yOENlZllzOGhjZkM3dE1PK1RUMHhwTzI0eWpCblhLUVRFQ2E3?=
 =?utf-8?B?T0ZIM2RZSFBEVjlVYmNwK0pwZkNiTDIrWXV4REd3eVVqcWV4MDg1bzE4UFB5?=
 =?utf-8?B?WVRHa0dlMmdGbnpyTk5JNXViZkNUZU9yTFNhOUtJMTB6Z0pLZnY5Z24wd0Q0?=
 =?utf-8?B?Z0NyVDd4WUxVZFQzdjJ4OWkrZ2JiRU1JL2t6NTZnd1A4U3FQLzZkTDZHYXVx?=
 =?utf-8?B?cUxDTWU5TmtJcTd0UXZISUJ4eHpHcWtuak0yMm9JekgyTXVPaW9tY3FUMHNT?=
 =?utf-8?B?NG1zbHc3bnNzWmt0aldLcWx1anRKL2xIZTN1U1JTUmwzdGtpdXhyeGp3c1Yr?=
 =?utf-8?B?VXdmTmZxUWYreFRSUFR2cGNKS0hhU0Y2QTRkeGY1VVlobTJPT0xMZFBOazB0?=
 =?utf-8?B?RXdvNU5QcFc4YnhOSmVHaE92WHFKYVJHM1UzVGV2bmpaeER4S2o4cU9HRnpQ?=
 =?utf-8?B?MFpwMHdzcGFiUWhXaGl1cHFMOU9lOUJ5ZC9wMVlhS0toeDhacVJEU0hrUUVp?=
 =?utf-8?B?SGowOUd6NlBHRnc1VHk2dEg2RXE3eGRQOU5lK1dlaUtVZk9OV043dU9JelBE?=
 =?utf-8?B?K2dvWlNjd0c2YnVsTmpka3RSMmpESlJYQjFzTE55TUQvSUJCTUtDdHhKcXlV?=
 =?utf-8?B?dU5VVGxNTWVTMHRrNmZLY3VVNDRheWFGSGhpVzJLMUdwUC93OHFTS1dZRzdN?=
 =?utf-8?B?dkQ4NzgwTHpkYWxGSXZuVTc1Zm12MmVMS1o0Wkd3QnZ5UWZZNkNFU0lkU01X?=
 =?utf-8?B?OHBnTnZCZWxtcFQ2b2E5L01BQTYwSzdEUm10VENaZHpXSDQxSFp2eDRpWDE1?=
 =?utf-8?B?QXExZHdYY01iaGxOK1FtUWpLajBmd2d5d25YL29CMk1EV0lHZDZxczkvLzFU?=
 =?utf-8?B?SHBtaXQ3SjFjQU5pLzdrZDErWUtJTXF5dS8xZ21PWXNRYWs1YjFaSk9YUlVQ?=
 =?utf-8?B?dVN4bUV0WDByeTBYN0NtYlUyVktEQWhCTi9QMmQ2bWhKY0hpMEk4aVpGcGFa?=
 =?utf-8?B?emQrdVVDRlZTa0w3MEZnenplZ0lKekRHRlBXbmtueGpWVFJXNjVudU1yOTU2?=
 =?utf-8?B?Z0xaaVpBTHRBUkozSnczMWQ3bFUyRXlxZFRJYWk2U1I0QnQ3WTdicTdZaWdW?=
 =?utf-8?B?dlFobDJ5NTlxK1BBemNqclJ2QlpTcFNDVVlxWWxieXpwZURqcTRvMTdYcE0z?=
 =?utf-8?B?WFhKd3FEYUtQVkFZZ0Z0L1FDaEZSck94Q2pZN3h5VU44TVpaZWNpc3lMQnB6?=
 =?utf-8?B?TDI4T3hib01kdUVKY0tUa2pDdUZsSWxHclY3SkVwMGZ5VGNIbHAyL1ZhV3Rm?=
 =?utf-8?B?MERWVUpuM2U3dUtWSEoreUZ0bUlWMlZpdjZqSDdXcmRKeEhmeHJ4OERHWnpU?=
 =?utf-8?B?NURSMWpBejdqWEVpNWdVYUE4bW1YaUFkZlo2NGhReFZqa29GVW4yUEpMaXox?=
 =?utf-8?B?RTRGMWpTOXdsUHp4cFMyMVZRUzc2YnBjY3g0MlhURWlsdDVvZnhySXZZTzgz?=
 =?utf-8?Q?x477Y9/vo7D6Vty/6HSAbRI=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 694b8e01-3ce4-4cdb-ef0b-08d9ea44d1cf
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2022 14:19:14.9782
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KqqKD2ESBYPGnC/JGlZa06btSwGWydmTahjwp2W8nDh53Cr5ltGXkr/RPMDUYI5T0nU9QuEZG60NbE9l7RJ8JQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB5734
X-OriginatorOrg: citrix.com

On Mon, Feb 07, 2022 at 01:53:34PM +0000, Oleksandr Andrushchenko wrote:
> 
> 
> On 07.02.22 14:46, Roger Pau Monné wrote:
> > On Mon, Feb 07, 2022 at 11:08:39AM +0000, Oleksandr Andrushchenko wrote:
> >> ======================================
> >>
> >> Bottom line:
> >> ======================================
> >>
> >> 1. vpci_{read|write} are not protected with pcidevs_lock and can run in
> >> parallel with pci_remove_device which can remove pdev after vpci_{read|write}
> >> acquired the pdev pointer. This may lead to a fail due to pdev dereference.
> >>
> >> So, to protect pdev dereference vpci_{read|write} must also use pdevs_lock.
> > We would like to take the pcidevs_lock only while fetching the device
> > (ie: pci_get_pdev_by_domain), afterwards it should be fine to lock the
> > device using a vpci specific lock so calls to vpci_{read,write} can be
> > partially concurrent across multiple domains.
> This means this can't be done a pre-req patch, but as a part of the
> patch which changes locking.
> >
> > In fact I think Jan had already pointed out that the pci lock would
> > need taking while searching for the device in vpci_{read,write}.
> I was referring to the time after we found pdev and it is currently
> possible to free pdev while using it after the search
> >
> > It seems to me that if you implement option 3 below taking the
> > per-domain rwlock in read mode in vpci_{read|write} will already
> > protect you from the device being removed if the same per-domain lock
> > is taken in write mode in vpci_remove_device.
> Yes, it should. Again this can't be done as a pre-req patch because
> this relies on pdev->vpci_lock

Hm, no, I don't think so. You could introduce this per-domain rwlock
in a prepatch, and then move the vpci lock outside of the vpci struct.
I see no problem with that.

> >
> >> 2. The only offending place which is in the way of pci_dev->vpci_lock is
> >> modify_bars. If it can be re-worked to track already mapped and unmapped
> >> regions then we can avoid having a possible deadlock and can use
> >> pci_dev->vpci_lock (rangesets won't help here as we also need refcounting be
> >> implemented).
> > I think a refcounting based solution will be very complex to
> > implement. I'm however happy to be proven wrong.
> I can't estimate, but I have a feeling that all these plays around locking
> is just because of this single piece of code. No other place suffer from
> pdev->vpci_lock and no d->lock
> >
> >> If pcidevs_lock is used for vpci_{read|write} then no deadlock is possible,
> >> but modify_bars code must be re-worked not to lock itself (pdev->vpci_lock and
> >> tmp->vpci_lock when pdev == tmp, this is minor).
> > Taking the pcidevs lock (a global lock) is out of the picture IMO, as
> > it's going to serialize all calls of vpci_{read|write}, and would
> > create too much contention on the pcidevs lock.
> I understand that. But if we would like to fix the existing code I see
> no other alternative.
> >
> >> 3. We may think about a per-domain rwlock and pdev->vpci_lock, so this solves
> >> modify_bars's two pdevs access. But this doesn't solve possible pdev
> >> de-reference in vpci_{read|write} vs pci_remove_device.
> > pci_remove device will call vpci_remove_device, so as long as
> > vpci_remove_device taken the per-domain lock in write (exclusive) mode
> > it should be fine.
> I think I need to see if there are any other places which similarly
> require the write lock
> >
> >> @Roger, @Jan, I would like to hear what do you think about the above analysis
> >> and how can we proceed with locking re-work?
> > I think the per-domain rwlock seems like a good option. I would do
> > that as a pre-patch.
> It is. But it seems it won't solve the thing we started this adventure for:
> 
> With per-domain read lock and still ABBA in modify_bars (hope the below
> is correctly seen with a monospace font):
> 
> cpu0: vpci_write-> d->RLock -> pdev1->lock ->                                                  rom_write -> modify_bars: tmp (pdev2) ->lock
> cpu1:        vpci_write-> d->RLock pdev2->lock -> cmd_write -> modify_bars: tmp (pdev1) ->lock
> 
> There is no API to upgrade read lock to write lock in modify_bars which could help,
> so in both cases vpci_write should take write lock.

I've thought more than once that it would be nice to have a
write_{upgrade,downgrade} (read_downgrade maybe?) or similar helper.

I think you could also drop the read lock, take the write lock and
check that &pdev->vpci->header == header in order to be sure
pdev->vpci hasn't been recreated. You would have to do similar in
order to get back again from a write lock into a read one.

We should avoid taking the rwlock in write mode in vpci_write
unconditionally.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Feb 07 14:27:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 14:27:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267019.460715 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH4zQ-0003I1-H9; Mon, 07 Feb 2022 14:27:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267019.460715; Mon, 07 Feb 2022 14:27:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH4zQ-0003Hu-E1; Mon, 07 Feb 2022 14:27:36 +0000
Received: by outflank-mailman (input) for mailman id 267019;
 Mon, 07 Feb 2022 14:27:35 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=hYSm=SW=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nH4zP-0003Hi-NF
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 14:27:35 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1648ad83-8822-11ec-8f75-fffcc8bd4f1a;
 Mon, 07 Feb 2022 15:27:34 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1648ad83-8822-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644244053;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=akr8GOJt3oaCQlB2tmmbBBfx/DbP0CRzK2wTmN7HiVo=;
  b=RD5I6lFYOVZTx3u/ddA1ZV6EYoPN3jl2G1LdZWb3ViSqHkAaHPzWIyrh
   +mB89QQztIQJmIPgknOGcpwmlKtOCOhpGZ/jrS/AaxkxE7ecJI4jBLVSW
   YK50w57uJktF0or33e/3XWHH963oyP57YIJ1XHkWvrPnx7y6a/65ogTUu
   Y=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: fnEeB445qKt3BUhMj0eHj9yx63XTNsjF0dTqE3Rs2qgMOv0CZBak6WUIqzF/7QWHFeb9vGjW3B
 uGL/UQyb0LQdoL7vccENpSrldwXMkYuZAD0rB2Q5pZfUzcNwOuBKWBJM/sup3h5LwYpiSAVtrs
 e/TK5DKEmEhoIGQN+VPba2uJFv2AODXfgagTqYXpqg+fWUN7gZhCrMYx+fendzVovRWXTRvCBq
 mhW9a3cgQB6ee3Ll/HwXwu6i1RAJf2iSO/NcDfVFG1nFcGbDMIXHHAc3GfVnNFSYHPQ3iGD6Kn
 UrxlN4H6HqikliRIIbpKWfDg
X-SBRS: 5.1
X-MesageID: 63559250
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:MWvY2qt1NkAD04akEkyZZavbLufnVHVYMUV32f8akzHdYApBsoF/q
 tZmKT3SOPqLajT8f9lzbYm3oUsCvsfcm9JnHgdq+y4wESoW+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZQP0VOZigHtIQMsadUsxKbVIiGHdJZS5LwbZj2NYy2YfhWWthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 NplubztVkA3YfL3lroiTUdiFyJYYYpC5+qSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DJoQQt2sm1TjEJf0nXYrCU+PB4towMDIY2JsTQKeEO
 pJxhTxHK1ecQBdPAF4sC49ikuOjq1DwfDZjkQfAzUYwyzeKl1EguFT3C/LNc8GObdVYmACfv
 G2u103jHhwfA/mOxjOE/2yEi/fGmGXwX4d6PLe17OJwiVufgGkaEgQLVECTqOO8zEW5Xrp3O
 0ESvyYjs6U23EiqVcXmGQ21pmaeuRwRUMYWFPc1gCmXw6rJ50CCB24LThZIctlgv8gzLRQU0
 VuOk8LsFCZYmrSfQnKA9Z+ZtTq3fyMSKAcqQisJThAM5dX5l6g1ggjSVdZoEKOzjdrdFCn5x
 naBqy1Wr7cZgNMP1q671UvamD/qrZ/MJiY3+wHWU2SN/g5/Iom/aOSAzlzW7u1JKoqDeWWQp
 3gPm8WY7+cmAImEkWqGR+BlNKqy+/+PPTnYgFhuN5os7TKg/zikZ4843d1lDB43aIBeI2avO
 RKN/1MKjHNOAJe0RaNXPp32FZt19qa+Ksq7bPTXSIZpZockIWdr4xpSTUKX2mnslm0lnqc+J
 YqXfK6QMJoKNUh05GHoHrlAiNfH0gh7nDqOHs6jk3xLxJLDPCb9dFsTDLeZggnVBougqR6dz
 dtQPtDiJ/53ALynOXm/HWL+wDk3wZkH6XLe9pY/mg2reFMO9IQd5xj5m+JJRmCdt/4J/tokB
 1nkMqOi9HLxhGfcNSKBYW15ZbXkUP5X9CxnYXV9ZA/2iiJ6Ou5DCZvzkLNtLNEaGBFLl6YoH
 5Hphe3cahiwdtg302tENsSsxGCTXB+qmRiPL0KYjMsXJPZdq/jy0oa8JGPHrXBWZgLu7JdWi
 +Dwh2vzHMtYLyw/XZm+QKz0lTuZ4yNC8N+eqmOVe7G/jm23q9M0Q8Ew59dqS/wxxeLrnGfDh
 13IUEtH+YEgYeYdqbH0uExNlK/we8NWFUtGBWjLq7GwMCjR5G24xoFcFu2PeFjguKncov/Ki
 Tx9w66uPfsZskxNtoYgQb9nwbhnv4nkpqNAzxQiF3LONgz5BrRlK3iA/M9OqqwSmeMJ5VroA
 hqCqotAJLGEGML5C1pNdgArWfuOiKMPkT7I4PVrfEijvH1r/KCKWFl5NgWXjHAPN6N8NY4om
 L9zuMMf5wGlpAAtN9KK0nJd+2iWdyRSWKQ7rJAKRoTsj1NzmF1FZJXdDA7w4Y2ONIoQYhV7f
 GfMifOb1bpGx0fEf34iLlT33LJQ1cYUpRRH7F4ePFDVyNDLseA6gU9K+jMtQwULkhgei7BvO
 nJmPlFeLLmV+2s6n9BKWm2hFl0TBBCd/UCtmVIFmHeAEhutX23JamY8JfyM7AYS9GcFJmpX+
 7SRyWDEVzf2fZ6ugntuCBA98/GzH8Zs8gDimdy8G5XXFpY3VjPpn6uyaDdasBDgG84w2BXKq
 OQCEDycskEn2fr8e5EGNrQ=
IronPort-HdrOrdr: A9a23:UgWe8KGYPG/gbqJBpLqFQJHXdLJyesId70hD6qkvc3Fom52j/f
 xGws5x6fatskdrZJkh8erwW5VoMkmsj6KdgLN+AV7MZniAhILFFuBfBM7ZskXd8k7Fh6JgPM
 VbAs5D4bTLZDAX4voSojPIaurIq+P3kpxA8N2uq0uFOjsaDp2IgT0YNi+rVmlNACVWD5swE5
 SRouBdoSC7RHgRZsOnQlEYQunqvbTw5dzbSC9DIyRixBiFjDuu5rK/OQOfxA0iXzRGxqpn2X
 TZkjb++r6ov5iAu17hPi7ontRrcenau5l+7f+3+40ow/LX+0KVjbFaKv6/VfYO0aaSARgR4Z
 /xSlwbTrlOAjvqDx2ISF3WqkbdOX8VmgDf4E7djn35rcPjQjUmT8JHmIJCaxPcr1Etpddmzc
 twrimkXjVsfGD9dQnGlpH1vitR5wKJSLsZ4Jwupm0aVZFbZK5arIQZ8k8QGJAcHDji4IRiFO
 V1FsnT6PtfbFvfNhnizyRS6c3pWm52EgaNQ0AEtMDQ2z9KnGphx09dwMAEhH8P+J80VpEB7e
 XZNaZjkq1IU6YtHOhALfZERdHyBn3GQBrKPm7XKVP7FLsfM3aIsJLz6KVd3pDdRHXJ9upEpH
 3saiIoiYcCQTObNSTV5uw0zvnkehTMYR39jtpZ+4V0/qbhQbaDC1z3dGwT
X-IronPort-AV: E=Sophos;i="5.88,350,1635220800"; 
   d="scan'208";a="63559250"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=hqW7AYAaymZiOJ14cMn5u4e7PRmvmWLMoWc3Go5tqOQ+mTCVkz7hxBpspC3BXKuu/edfdaxzytlsnmqNqu92qRK3Rx5T9SYJlvqsPYzSCcAOqKB7wKeqm0KSfuo6pGsuoEJWsBVQUyY0wXTvKuXP87A0OWrSOJm+I+lB+aOoDoUgcC8J6NXXXPerMi8ALpiSQTq+QL3USD6NTrtd03jMlLPhmdko29WK0lxfL67qzc6MyKNUcGP9JZDY1Eww07OflzMQRYfY3Fy7mi90UMfoFEt9qaL0c69yHX2Fg9ktM7YqtKeWkgYLGNwKvXrXdi6p+WHqen7/W63tAV7UPGXR4w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ujlmL1pGk3S5HXxSrKv59ZMnBRiLBJ2kraMVbrRGEXQ=;
 b=QXoJuuKhIlSPrzle6KJWmsDYq8zbbqmnpQ1UIcxNsdMFIc0y5yRFvfQCp8lf5YNr5QygS1NUTkYiBkjPNMmMMa7v6o7RrFG81TuRd/THGYEyQPrNznvZZO23oztaQgSy1Vy+5OabLr7/1Ha4D33ctJwJL1DOuh58SBTXlaihFWPYH+FurzM9kCMSzZ00K7d9VXRDBkd+yWbd+4xdyPn7ixH6/2EH0jHmgA3opCe5krU1Vx6HoyvfVoRC7usc/xRZ8Mi76AysBNX06YkcVsH2r7554M6QPRB6h+frW+09XQgSAza53IFQy4bWeb0R88J0Zz9NLujwzZfqzA2DIiUJJA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ujlmL1pGk3S5HXxSrKv59ZMnBRiLBJ2kraMVbrRGEXQ=;
 b=CHVFpJLpPlEDxv23UrIpd6l5TF/Jrm57IKoWoBC+P5pQ6s6PRJFbAvxk2zBTyjcRO5UtkCqNSJSxcuIRMkzOeJmPFCw/F/zJ/lCi/vBFYUbSxGHLtwZ9+GjSKKFRoYmwdXSWGB/Wy/NCBbjhV3Uhe5DlzMEVryI8Lwn4QkycAgI=
Date: Mon, 7 Feb 2022 15:27:18 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>,
	"julien@xen.org" <julien@xen.org>, "sstabellini@kernel.org"
	<sstabellini@kernel.org>, Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Artem Mygaiev <Artem_Mygaiev@epam.com>,
	"andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
	"george.dunlap@citrix.com" <george.dunlap@citrix.com>, "paul@xen.org"
	<paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>, Rahul Singh
	<rahul.singh@arm.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Message-ID: <YgEsRuckQJIQlkzf@Air-de-Roger>
References: <7e3562b5-fc67-f213-e872-f211450d9e2e@epam.com>
 <a8fc599c-f620-c4d1-2077-c57068f46a7f@suse.com>
 <deef8468-d607-e49e-f456-6a8013329ca1@epam.com>
 <Yf0k6aoKK5G3iad1@Air-de-Roger>
 <3ad10a99-c706-b95f-1419-2c0c7cf37d58@epam.com>
 <Yf0+3C9nF8+tewLw@Air-de-Roger>
 <c5fea3bb-834b-eeb7-d7a1-1ee609037a9f@epam.com>
 <YgEUwTxhnWVMGMJK@Air-de-Roger>
 <9ce90193-74a0-5642-d22b-6b8c3340c3cf@epam.com>
 <1f65ae7a-898d-2c27-0ada-d71d778b0627@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1f65ae7a-898d-2c27-0ada-d71d778b0627@suse.com>
X-ClientProxiedBy: LO4P123CA0381.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:18f::8) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d121a1dc-1ddd-454a-113f-08d9ea45f484
X-MS-TrafficTypeDiagnostic: BYAPR03MB4184:EE_
X-Microsoft-Antispam-PRVS: <BYAPR03MB4184D031E66063C00E6999BA8F2C9@BYAPR03MB4184.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: QenGAvZ0J2lPw84rrX8Me4LGsRau4sEq/fDo8VaL4cvy9qNWFgBhI0KwuTSkiqlh8fiVkuB0KhvtSdhZ6/zi1Hllh1MfacB6vDvJ4VbeWUx+8eo03z8UTpVbkzYiEPSKfouiPRDk6ezRb5jgKbvJ8eEj02CUETZsvM2C8W2xdWOpmUibdw1PPeBetyis8k7NGAyS8QiUwbrVz5rHEoVylStQc6upskIEq+z5iWmWq/Q20tZoZMnZP3Mzyi+o/sulOptbtzPiGDt3hltaGe3D9JJefFSChht8+B1+5AJSNvDL0aB7hASI1dNcfU1xI/KEQbjBBgqJY8vwulEvB3I4+AF8G/1jZMCFNS955RQyyAaRVpw4p0W15VGHo/vlKoV2KK2SYodDO4vKmuxh2hlJ96vlcjN245+gpnvqp3GHEx8YGSdifv6B2Okk7GFWkKuPyqGOnLGcaGsEk4VztJKog7zGz1dhv5tIFB/N8HcmMy2lC1jF0+Hiecn4k0pjCK+wLuD+SkY7IIaIjym/abFPoIBBxrEPQ+dFbLWe1e2CqritL10BZWf6pc2QPimlwzpAZfthMeQ8xDSzfK2Ihexq1CXEsnZhKETffGJOFc0d+a2am3P82ixdxPV+XXNuVDz20zQnIibLJMyid65Gtz+ctA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(316002)(6486002)(8936002)(6916009)(508600001)(85182001)(33716001)(9686003)(6512007)(54906003)(82960400001)(66556008)(86362001)(8676002)(5660300002)(6506007)(66946007)(4326008)(66476007)(83380400001)(7416002)(53546011)(2906002)(26005)(38100700002)(6666004)(186003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RU1tTnhoMDlKK3Q3SFBMc3o1Tm1UQjVXNjVEL08reDI3ekZwTG1uZmdwVkt6?=
 =?utf-8?B?Y2c0MmVSN2lhendDeUt0NkFDRDRHVklsSXlDbXR3ZnREZjY4cXRVQUd3cTlO?=
 =?utf-8?B?SFVZVzE4dnNZN21EYXVhR0NyWHpFT1JPci9ld25YZlpYTGFVUnFpaXR5Tnlv?=
 =?utf-8?B?c2c3Nkg2RTI4NExHRE1IWUFhdUdaSjFNN2syOTBhajN0eGFLV0dVVUZpc3Qx?=
 =?utf-8?B?SjFBbVBUT29xeWZNZEg2cFdxbmdjWWtYT2tvTno0Ui9aUGJzalg4cHFOTHJH?=
 =?utf-8?B?NkxVNlFCZk1xVERLRmNMM1hsNDdrT2wyVGhhQ2J2bG5jR2RqTTNoaE03Q3d1?=
 =?utf-8?B?WGpLZW1UdUliTTByWHlGa2w0YW84NEVMTXlaOHgrVDZQWStJYld6UGZ4M1F2?=
 =?utf-8?B?R1Jxd1FOWUE2cHFpNE5RSmZvNHhIc1ZSMzRUL05iRVpZS0swamVxK2tNcGIx?=
 =?utf-8?B?dHd4algyK1ZucTRWUHlycGF4RDRxbVVqc1JZUWpWT2xHN0dMRnB3U2MrT3lu?=
 =?utf-8?B?RmRXeU5HL2I4ZTRRdk9rT29mR09zVHlIbHcxYXU4bndaMkp1Rm1KZTNRU3pv?=
 =?utf-8?B?dHRBUDVyTFhXYXVqVVBHYkhmcmVMVCtwdnE1aWVFc1dpZlkzK2E1dE1Ka0hw?=
 =?utf-8?B?YU9MV3drTXFoTFVuQzhrMWtlZ3ZFQW4rV2UyRm1LZkFBOHBldVNZVFNlTjY3?=
 =?utf-8?B?WTZ0SmZaamc5b3FTdHpiVHRWbG02ZE52UndXWEc5SytpVVMzenNXTC9IVnhO?=
 =?utf-8?B?SFU4NG9saVVkVG9mTnZZVmk2NmhUQ3cwZysxMzByb1JWVms0KzJLcmI2Tlp4?=
 =?utf-8?B?ZVAxRDZkaEZCSkJxMEI0OUJSNEJaQWN6d3IrYzIzeEg3VGJ1REo1aWtFcUFq?=
 =?utf-8?B?R0pZNDhLZ1M2RXJ6ZmFEZ09ldks3R0lQT3ZsZmx5ZjR0T3VXZDZwbFdHQW1H?=
 =?utf-8?B?Z21abkZjTnpvQmhpa2dUcHRDTm5FVjAvTjFsak5UQnZZR2F1bGZXTVd4Z0hh?=
 =?utf-8?B?SktKTjVKWlBZdWs0VmR4bE5DU1ozaGNhNEVNWjh4amkxTkJIYnRrS29tMXkx?=
 =?utf-8?B?cjJqcEppVmhodVZVQzBOQjZHRG9wKzNIUTBES0pUSGd2M0tpeGhvbW9sM2ln?=
 =?utf-8?B?b2tGTUVybUtTQUpoMFZySnEyUzkvSXhWUHR6TDNaTkVmYzFPWFBINTBJUTBl?=
 =?utf-8?B?TzR2MWtsa3pmZWhRa0h0REJkQ3E1dlBjbGtHbXdIN2UvdE1SVWxpTC9NTXdi?=
 =?utf-8?B?ZEUvbklETVpEcWxFYkRnTnlBYnZqVURYamw5VlJSWEJsWDArMEluckdWcURB?=
 =?utf-8?B?YTh0cGxKVkxPdUMvT3Z2RENQV3ZpNm5aV2J6dkI0N090RHRKMXNIc2NxbC8r?=
 =?utf-8?B?bnYrRGoyOWxFRmVKTlUrbVpkV1djNGxjSTVqMGl3d1lHRXVrdFo5dVM4WjFw?=
 =?utf-8?B?QXZFR1hwSFYrSm1zazFTRWNCS2djMjJHUWlGU2JVUGFBVmloRGZWUCtMUGpD?=
 =?utf-8?B?eXQxenhTRFpSSG1yMGc4V2ZZeDRzWTViaWJ6bTZqYS9hNXZkVTV6NVJwaUZ2?=
 =?utf-8?B?clNDU2FuZ29QMjNLMlc5a3cxNkFndi92S2tvVjJ5RjNqUFJ3cUFTNW1TeFc5?=
 =?utf-8?B?YmVGaE9LcW01ajlQOU1pck1aMVdyam55ZTBEdkRjWGlUTzhQSmUrMGw2MFBr?=
 =?utf-8?B?TU5jVHFESkpSeURXNlVBV3RjdHFtek1KcVhERTBHbGg4TUNBS3A3VTBWc3Fz?=
 =?utf-8?B?Q1N6ZklWUmRlTFBZNmdyU0ozdUdTOEUvL1RhbEU5aVovNHNhRTFxYlhaVkE4?=
 =?utf-8?B?YTJqME1MaS9GSnJBME0yT1lBWG50VzNCU0ZkbmhXVkRQRFhsbHQ4SXdjK1Jw?=
 =?utf-8?B?TG9KVTJ0dWUvMWJLcVBhcWdhUS9vU3NJK29ndEtmcEhScC9iUlpCb09iNG9h?=
 =?utf-8?B?Y2UvRkU2OElpbTJaMU9lT2hEVnBzdzlNYXc4MFIydWtOTGlsekhZa2xGeFdV?=
 =?utf-8?B?MGVZOTFnTTd3SGNSbDV6MnpCdDR0aWcvc0pxSzlvM0RHaGpWUk9DNFFZYzRU?=
 =?utf-8?B?ellHV0pxOWUyTkk1UkpkN1ZFaHZzemg4K2w5ZW05Z2lmTlk4SmJRVElVeUVq?=
 =?utf-8?B?YmxwSUJ1Q0Yzb0xQK3ZIaTRKQm9iUnBxNlZzVlVmdUc4aFZ5bTVEdzU4ZTFr?=
 =?utf-8?Q?GhfUDC21JMzmWZZck+nqTtU=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d121a1dc-1ddd-454a-113f-08d9ea45f484
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2022 14:27:22.7605
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LW5OmlIIW452YjdUREvOSK+AwkY4DKktlnc9TSxUfVwZlv4qfMd/tfYS/Lnzp7/jFOq4z9Z/ECqNg7gvsywkHA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4184
X-OriginatorOrg: citrix.com

On Mon, Feb 07, 2022 at 03:11:03PM +0100, Jan Beulich wrote:
> On 07.02.2022 14:53, Oleksandr Andrushchenko wrote:
> > On 07.02.22 14:46, Roger Pau Monné wrote:
> >> I think the per-domain rwlock seems like a good option. I would do
> >> that as a pre-patch.
> > It is. But it seems it won't solve the thing we started this adventure for:
> > 
> > With per-domain read lock and still ABBA in modify_bars (hope the below
> > is correctly seen with a monospace font):
> > 
> > cpu0: vpci_write-> d->RLock -> pdev1->lock ->                                                  rom_write -> modify_bars: tmp (pdev2) ->lock
> > cpu1:        vpci_write-> d->RLock pdev2->lock -> cmd_write -> modify_bars: tmp (pdev1) ->lock
> > 
> > There is no API to upgrade read lock to write lock in modify_bars which could help,
> > so in both cases vpci_write should take write lock.
> 
> Hmm, yes, I think you're right: It's not modify_bars() itself which needs
> to acquire the write lock, but its (perhaps indirect) caller. Effectively
> vpci_write() would need to take the write lock if the range written
> overlaps the BARs or the command register.

I'm confused. If we use a per-domain rwlock approach there would be no
need to lock tmp again in modify_bars, because we should hold the
rwlock in write mode, so there's no ABBA?

We will have however to drop the per domain read and vpci locks and
pick the per-domain lock in write mode.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Feb 07 14:27:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 14:27:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267020.460726 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH4zY-0003ak-QI; Mon, 07 Feb 2022 14:27:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267020.460726; Mon, 07 Feb 2022 14:27:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH4zY-0003aZ-MT; Mon, 07 Feb 2022 14:27:44 +0000
Received: by outflank-mailman (input) for mailman id 267020;
 Mon, 07 Feb 2022 14:27:43 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=F54n=SW=epam.com=prvs=403792ff6c=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nH4zX-0003ZU-IL
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 14:27:43 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1b4bfc75-8822-11ec-8eb8-a37418f5ba1a;
 Mon, 07 Feb 2022 15:27:42 +0100 (CET)
Received: from pps.filterd (m0174679.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 217EEgIk023707;
 Mon, 7 Feb 2022 14:27:38 GMT
Received: from eur05-am6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2108.outbound.protection.outlook.com [104.47.18.108])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e350ur22y-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Mon, 07 Feb 2022 14:27:38 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by VI1PR0302MB3181.eurprd03.prod.outlook.com (2603:10a6:803:20::28)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Mon, 7 Feb
 2022 14:27:34 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77%3]) with mapi id 15.20.4951.018; Mon, 7 Feb 2022
 14:27:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1b4bfc75-8822-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Og7NKwuYM1RS0ElTfeuVX+L+YIFRnUJC+Lk7oPq/KXYHBmuiSkFLDAuT9ZSGd+0N39HnONOs4ehBxcjLKnclFESLgzG9RgdL0A4Pv9jwycCWaZhl//0+13AijQCQYCBU/6llfF7X+ZKj749ys6snOql1YtDA/D7CiPgftnumu51FJw9wxzzQDpEczgV236LQ/pkjH3uVYQaGtwxSqljYTPjdGtSrnXKXYSJOaYGVH16TJU4QvdVARu+kaszeIj5EhGyQb0aQ/PdvOU7WYjHya2bvjW2/ucQ7jX1BCbW6myyMca8FsUuoR3/geeUVnJEdTBG9cN6kOeyP6F//jl0AtQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=CFitlRpoEQ6qy5DSpWUWar+1P+kUxJFK6CfNp+aMM/8=;
 b=WZvDmZy1DEl2jxhlqLy+tklxXeQv2Q7rlvhz1BliNwpS00A0PDzndxrP3Sv9uOC3VKvyqcx9qV20dhh8FQhLwadcBsUEF7E5/17zmtllYcepjHJKxpyLtV563p0u2o8imeEq7PUawwJYFRKRCN9mWE8vEhkfgD4X7hANNgCTNaUVU39U/F/W+kzqoXbtJU+XzUDxima9VLO4sqbfoOZj6B+MWJkVjuyuTfg2v+oYvbOLRvg4QDWuArNVZyf/Bsmz2/0Af1n9o8pyqr4BCAlMAtJn6rLSO74zpCPKkIWW73UBYJooN4+WHnMfLlxcbjJu3AmHi6pW1UhylfXg09/AIQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=CFitlRpoEQ6qy5DSpWUWar+1P+kUxJFK6CfNp+aMM/8=;
 b=O0bsJWzLygw7OEAjK2OqlHSwNJaZ9us0QXiKtdMkw11DeeL7MtxPQXKRAiEHLVkNIa/wx4dVoRnXYYrqEE6pqGoN4wyXWiCSxJUSKbT79I2V1jfGYi4UfczQaHSjt+gKypdaMRkkELW/JsehBgl79Pc+KAuZfGsacYPGUHg8yREEYMskOa242SUFaLLo/2jBWetEDPwBZKunsSZlOVpjwL3gy7m7lDUsL3mdqtLLT4wLm3/l8rrbBMPHDzMsCRLwa/WNc8+aU0T8y7jj2NGeDRh0bV7qsVHJwzDQIhzStJONONBharpwb/xlka5fdELA653TDdnwLjRLRexPl7zUPw==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: Jan Beulich <jbeulich@suse.com>, "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org" <sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Thread-Topic: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Thread-Index: 
 AQHYGZFc/MnzQOjwVEeBBUHLSW0md6yDBUkAgAASSACAAATYAIAAD/WAgAAKNgCAAAbfgIAABnuAgAAQvgCAAAMCAIAAAY4AgAADxICAABrnAIAABAgAgAR3CoCAABt5gIAAEpuAgAAHKQCAAAJXgA==
Date: Mon, 7 Feb 2022 14:27:33 +0000
Message-ID: <38b779e6-94fc-b54f-39e2-f97739b6846a@epam.com>
References: <1ed0e342-16cd-2f16-c05c-186667a22762@suse.com>
 <7e3562b5-fc67-f213-e872-f211450d9e2e@epam.com>
 <a8fc599c-f620-c4d1-2077-c57068f46a7f@suse.com>
 <deef8468-d607-e49e-f456-6a8013329ca1@epam.com>
 <Yf0k6aoKK5G3iad1@Air-de-Roger>
 <3ad10a99-c706-b95f-1419-2c0c7cf37d58@epam.com>
 <Yf0+3C9nF8+tewLw@Air-de-Roger>
 <c5fea3bb-834b-eeb7-d7a1-1ee609037a9f@epam.com>
 <YgEUwTxhnWVMGMJK@Air-de-Roger>
 <9ce90193-74a0-5642-d22b-6b8c3340c3cf@epam.com>
 <YgEqXhxOqKq92+Xn@Air-de-Roger>
In-Reply-To: <YgEqXhxOqKq92+Xn@Air-de-Roger>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 4f2b7f17-7183-4228-fbde-08d9ea45fb5f
x-ms-traffictypediagnostic: VI1PR0302MB3181:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <VI1PR0302MB3181DB54B5986333B746C768E72C9@VI1PR0302MB3181.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 lWWVC6Anryf7sz5P3OmBcLnk4TkizX62QHSTz1X+yE7CuVBpwr6wQA6gSwDNF/7JJleVFL1GD5ewTnGN0ExCjFQ7QsO/pTzcYoJ3e+O43rWiwZBD9CISvPMRz0RLtz6BtGfa3qWeh7SbX8sX434m/I6eA2+IDy/TeUUtjbHYNBmCWpvosvlFKevih31z7A/73oBt1+18SmsVEV5RAAcJXdQg+1CtvrTaUUhXqQdTSXFM2YifXSSqVP9/vWCpbkuTgZcRPqv2W8lRDi8XUS4qiA8//+XvyesXC7gelZEJXKrVleewfpaQHMzbJz8P61SVt7x5SZkBIwmvlznDpcPX+gIvv27k9XX22/qpzdGr8fnmxDNYQBJG1CKUOz8I+xqn4sHKRv287p+3yXauq5MNXJovKjKLH3z3O8hjfUIKb/RhB0iy9+pLEeOtyVL/WsTDgZOLPHfV/8uv1GvAzn2VKPVwUCwPynlU3RRpEYIWPhkpxMX3zZl0dp17emE640uN0ZpAn934iusc+ao1GDEnjXnFTME8FiAZOujPOEuXi7wo5YfgwL10s9ofut2/hYopLjP/IEvHVJhs6aRqdoJcQn9N8nY8p5sffVnUFvmUqyDnyUKTZVHkgM7hlvcTKqlpOzjiDz+Wb6Wi3M9r1EDqNWRHrbbQgZJ5MvU8nw+eq/NigdVE36Yr/RtLNUPa2JLKXuaix7wfCyia23cZhfg7CUazEMd/EmRwvhur1oJby7wOVCdA9Sn0dy9ZsGX2Zk4L
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(508600001)(6506007)(2906002)(122000001)(53546011)(66446008)(6486002)(76116006)(66946007)(8936002)(66476007)(66556008)(8676002)(64756008)(4326008)(86362001)(91956017)(71200400001)(38100700002)(55236004)(38070700005)(31686004)(5660300002)(7416002)(6512007)(2616005)(6916009)(26005)(186003)(83380400001)(316002)(31696002)(36756003)(54906003)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?YzY4SzB2bDN4RTRaWDcvbDYxaHI4YU5UL1pXWmRXY3BHN3UyZVZiR3dTMDhK?=
 =?utf-8?B?bVRvK0FGSmRyUW5tU0JsZEJtekF4S0p3SkhBNG1ORG1XeSszTlZBRGRNQ3Fv?=
 =?utf-8?B?Y2ZLKzBwYUF6d2NQMFZIYXZSME9XMFMwcGRub2JHdStBWTR5dTUwa1pvQk52?=
 =?utf-8?B?b0xhWUtFa3FPanc4dDZGenlPdUVTNytBcUtQK3crNUdoVVJpcDNYSXZRRS9t?=
 =?utf-8?B?ODFIb0tMTlByQk5hYXdQNlc2WVkyb2Vza01TMmtDa3ZKU3VxYUdwVXZFWnpY?=
 =?utf-8?B?dmNHTHEySnlYaU1lQkxpb3daT0xjbFlYdDc2TEVVeVFPS3RpakdZTXBWZkRP?=
 =?utf-8?B?a0F2ME5Ca3VuVjJxMVdPaU9xRFYzL1lOdS84NDZVTExwU2YwcGZqV3NkblQw?=
 =?utf-8?B?bEhoMVFxSnVpUEJhM1ZpU2FEM04zdHJRSWVzcVZCVGkwUlY1b3lwWG9HeDlD?=
 =?utf-8?B?d251N1VlcEs3cTh0ZUFCYVBQa3BxWExXUkI5ZVhBU1FlRW1iYlJTUkpIRUJJ?=
 =?utf-8?B?WjhuUDAwSjlsekF1bnNpUkVib3crYXB1dUVKazl4OU9rN0RmN3BoV1BnMTRR?=
 =?utf-8?B?R2wwZXBpMzlnenJXYlFWcGRlTjU1bDZIblQvSXpTYy92eXVNMjlNNnU4TU9a?=
 =?utf-8?B?RTVEUklKbTdGc1FwNFdWMjcyejJPdVJvckx2V055S29WbmRRYW9jUFpGM1Y4?=
 =?utf-8?B?QkJvcGt3eVAvQTgyY0NHZk4vMzdmYnVEcmNKekY1UHRDci94S3BvOTM4c2p1?=
 =?utf-8?B?U1FqdDRkM0xrQWFOZHNkQ3dLWmx0VEFWVVZwdlJiWFZuY0Q2UnltMzhFVDYv?=
 =?utf-8?B?c0NpVnNqOFJCWVJ6T1VNbmI3eEhJdnJWQncxQ2dMak83R2ROUWZlcHFBMGFB?=
 =?utf-8?B?dlFCR0Z4cVBmOHF4OTUreXpjR1VQZlBPbER6MjBNV2Z0WkRnQ2NaQ3p3ODZ1?=
 =?utf-8?B?TnlKSGV5NzdUYTk2SVlEZ1ZReVFJeHdxdXE0YmZUNVFjbWcrWUI0QkRPd05K?=
 =?utf-8?B?VlhNOUNJc1d6MGlqdm52Y0dHWVU3bDFUeXZEMHQva21LWTJOZk1yYzR6aFo4?=
 =?utf-8?B?L0ZXelNPVWU4MGVGL3djU0dPek5uTlBSaFRCQ292THA4NUt1YjJaaHBvUy94?=
 =?utf-8?B?dm1UbTl6Q1FtbDdTV25EaDRRajYwVzBMUWxaeGVWa29uRi9JNHFHVjhIQWJ5?=
 =?utf-8?B?ZHQyRjZwbWxVRnFpbHVJQyt1amc1dXlUQUhDT2xqNmZFOFNOTmN1YVFib2pX?=
 =?utf-8?B?c3lRVEQyM05wZGtYQjdNTFlhNWE0NnZlZ2VGUTJoUnNPNDEwYzdPTlNBSXlx?=
 =?utf-8?B?aWtuSjc5M21kWi9XdTRZWTc2UzFjQWpvQTF0WTBLL2c0clRaaDBlMEdaVExr?=
 =?utf-8?B?RnJLb3hmZ2ZOVStpell2YjkwM3V2dzNRVXVYbVV2bFI2Szdxbk1pMkVsRHVW?=
 =?utf-8?B?RFJPODYrK1NIUkRnUXV1dEhZZmkrOVE1OUZ1enhiL2lTaUwyckFaVjJycG5q?=
 =?utf-8?B?U1A4QW5xa0YrS0pGc3UwcXM0SnRKM2RJd25CdXFaWUtiakk5U3oyQjNPeGg2?=
 =?utf-8?B?WHdnVXo5UXdYSjNTaTU1QTN5YWNRNlZiVTR2WDBkYjNMeHlhNytZektLRHp3?=
 =?utf-8?B?MTYxM2lQV21MNkh5d2lzZ2gzODd1OG83Q0xpdXM3UFpDV2tWbStNU0JMUW5x?=
 =?utf-8?B?MmYyaThUbUgxZ1UyV3ozeGt0MlREemdpK0ZtQnRsUXA4R0pmbTNMdVBEL1N3?=
 =?utf-8?B?SGdHTFo3bnhkUXhmeHFncjg5SlBtQ2xlMVUyK1RKRFNiT3dhbHdGUnBWZCtZ?=
 =?utf-8?B?eEFTVmtqbjFJQkxQZWhYZGVKZUdweTFvZUtNZXlwVWhqMHpnSkNkZ2t4V1dl?=
 =?utf-8?B?aE5sVHQwcU9oNmlHb1NWa3MrQ2pwWTR5ZkZoakVPT2xVNmp6ZXM4TWdGTzNh?=
 =?utf-8?B?ZW1XR0RJS0ozMkFzUzNYVWZNcVZ0b1cvZFhPZW5mWk9WR21JM3NJSXMyemF2?=
 =?utf-8?B?VFB4QTNZVDRWRmQycVFhdUJodE54bTNXTEZHclY4MkljWGJrMEo4NjZHTE1k?=
 =?utf-8?B?aDFtR291WkkydkErbmJaUzNQaitRR0FDRlR4Z3F4eWlZTjVhOWtReGUreWZ4?=
 =?utf-8?B?Z2tpM3M2dkR0TkJNeDdxdzRVTU0rSVh5dXc3Tm5yaFpOUmJxWjFPUXlaK1Ir?=
 =?utf-8?B?QXFtNUFZUUEyMHNDNE1wRXVraGpwcytZWDZKZjhVQ1VJcVlLTlZwdTFZUDNy?=
 =?utf-8?B?S0pyRDFSc0w3dC80TzN6N3lGQUYvbjNLMHVQNGhjV2E4cEw1czRWRUdMQVMv?=
 =?utf-8?B?dlFhbExwaW9BTUpZV1RxK1ljRWVTNzZ2RUMzcnpVK05rODRvYzJMZz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <DF34A2A5E5FD12408B0CD5CFDF202B56@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4f2b7f17-7183-4228-fbde-08d9ea45fb5f
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Feb 2022 14:27:33.9556
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: OLIDV3CujGp/+OEPXiNlNdEkflYbfWwyIr1Ff8qWzuMAvc52l2KU4qQyuBZe30XUMc2G5/ay7kiGnZqGtyL+J3lbVVDCw1DMTZaYLUniraz9YpABhOvsObWQjM6RwxX7
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0302MB3181
X-Proofpoint-GUID: RkYBYeFL5wma1lLtUb55Z7nqssqN37br
X-Proofpoint-ORIG-GUID: RkYBYeFL5wma1lLtUb55Z7nqssqN37br
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-07_05,2022-02-07_02,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1015
 impostorscore=0 phishscore=0 mlxscore=0 spamscore=0 priorityscore=1501
 lowpriorityscore=0 mlxlogscore=411 bulkscore=0 malwarescore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202070092

DQoNCk9uIDA3LjAyLjIyIDE2OjE5LCBSb2dlciBQYXUgTW9ubsOpIHdyb3RlOg0KPiBPbiBNb24s
IEZlYiAwNywgMjAyMiBhdCAwMTo1MzozNFBNICswMDAwLCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5r
byB3cm90ZToNCj4+DQo+PiBPbiAwNy4wMi4yMiAxNDo0NiwgUm9nZXIgUGF1IE1vbm7DqSB3cm90
ZToNCj4+PiBPbiBNb24sIEZlYiAwNywgMjAyMiBhdCAxMTowODozOUFNICswMDAwLCBPbGVrc2Fu
ZHIgQW5kcnVzaGNoZW5rbyB3cm90ZToNCj4+Pj4gPT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT0NCj4+Pj4NCj4+Pj4gQm90dG9tIGxpbmU6DQo+Pj4+ID09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09DQo+Pj4+DQo+Pj4+IDEuIHZwY2lfe3JlYWR8d3JpdGV9
IGFyZSBub3QgcHJvdGVjdGVkIHdpdGggcGNpZGV2c19sb2NrIGFuZCBjYW4gcnVuIGluDQo+Pj4+
IHBhcmFsbGVsIHdpdGggcGNpX3JlbW92ZV9kZXZpY2Ugd2hpY2ggY2FuIHJlbW92ZSBwZGV2IGFm
dGVyIHZwY2lfe3JlYWR8d3JpdGV9DQo+Pj4+IGFjcXVpcmVkIHRoZSBwZGV2IHBvaW50ZXIuIFRo
aXMgbWF5IGxlYWQgdG8gYSBmYWlsIGR1ZSB0byBwZGV2IGRlcmVmZXJlbmNlLg0KPj4+Pg0KPj4+
PiBTbywgdG8gcHJvdGVjdCBwZGV2IGRlcmVmZXJlbmNlIHZwY2lfe3JlYWR8d3JpdGV9IG11c3Qg
YWxzbyB1c2UgcGRldnNfbG9jay4NCj4+PiBXZSB3b3VsZCBsaWtlIHRvIHRha2UgdGhlIHBjaWRl
dnNfbG9jayBvbmx5IHdoaWxlIGZldGNoaW5nIHRoZSBkZXZpY2UNCj4+PiAoaWU6IHBjaV9nZXRf
cGRldl9ieV9kb21haW4pLCBhZnRlcndhcmRzIGl0IHNob3VsZCBiZSBmaW5lIHRvIGxvY2sgdGhl
DQo+Pj4gZGV2aWNlIHVzaW5nIGEgdnBjaSBzcGVjaWZpYyBsb2NrIHNvIGNhbGxzIHRvIHZwY2lf
e3JlYWQsd3JpdGV9IGNhbiBiZQ0KPj4+IHBhcnRpYWxseSBjb25jdXJyZW50IGFjcm9zcyBtdWx0
aXBsZSBkb21haW5zLg0KPj4gVGhpcyBtZWFucyB0aGlzIGNhbid0IGJlIGRvbmUgYSBwcmUtcmVx
IHBhdGNoLCBidXQgYXMgYSBwYXJ0IG9mIHRoZQ0KPj4gcGF0Y2ggd2hpY2ggY2hhbmdlcyBsb2Nr
aW5nLg0KPj4+IEluIGZhY3QgSSB0aGluayBKYW4gaGFkIGFscmVhZHkgcG9pbnRlZCBvdXQgdGhh
dCB0aGUgcGNpIGxvY2sgd291bGQNCj4+PiBuZWVkIHRha2luZyB3aGlsZSBzZWFyY2hpbmcgZm9y
IHRoZSBkZXZpY2UgaW4gdnBjaV97cmVhZCx3cml0ZX0uDQo+PiBJIHdhcyByZWZlcnJpbmcgdG8g
dGhlIHRpbWUgYWZ0ZXIgd2UgZm91bmQgcGRldiBhbmQgaXQgaXMgY3VycmVudGx5DQo+PiBwb3Nz
aWJsZSB0byBmcmVlIHBkZXYgd2hpbGUgdXNpbmcgaXQgYWZ0ZXIgdGhlIHNlYXJjaA0KPj4+IEl0
IHNlZW1zIHRvIG1lIHRoYXQgaWYgeW91IGltcGxlbWVudCBvcHRpb24gMyBiZWxvdyB0YWtpbmcg
dGhlDQo+Pj4gcGVyLWRvbWFpbiByd2xvY2sgaW4gcmVhZCBtb2RlIGluIHZwY2lfe3JlYWR8d3Jp
dGV9IHdpbGwgYWxyZWFkeQ0KPj4+IHByb3RlY3QgeW91IGZyb20gdGhlIGRldmljZSBiZWluZyBy
ZW1vdmVkIGlmIHRoZSBzYW1lIHBlci1kb21haW4gbG9jaw0KPj4+IGlzIHRha2VuIGluIHdyaXRl
IG1vZGUgaW4gdnBjaV9yZW1vdmVfZGV2aWNlLg0KPj4gWWVzLCBpdCBzaG91bGQuIEFnYWluIHRo
aXMgY2FuJ3QgYmUgZG9uZSBhcyBhIHByZS1yZXEgcGF0Y2ggYmVjYXVzZQ0KPj4gdGhpcyByZWxp
ZXMgb24gcGRldi0+dnBjaV9sb2NrDQo+IEhtLCBubywgSSBkb24ndCB0aGluayBzby4gWW91IGNv
dWxkIGludHJvZHVjZSB0aGlzIHBlci1kb21haW4gcndsb2NrDQo+IGluIGEgcHJlcGF0Y2gsIGFu
ZCB0aGVuIG1vdmUgdGhlIHZwY2kgbG9jayBvdXRzaWRlIG9mIHRoZSB2cGNpIHN0cnVjdC4NCj4g
SSBzZWUgbm8gcHJvYmxlbSB3aXRoIHRoYXQuDQo+DQo+Pj4+IDIuIFRoZSBvbmx5IG9mZmVuZGlu
ZyBwbGFjZSB3aGljaCBpcyBpbiB0aGUgd2F5IG9mIHBjaV9kZXYtPnZwY2lfbG9jayBpcw0KPj4+
PiBtb2RpZnlfYmFycy4gSWYgaXQgY2FuIGJlIHJlLXdvcmtlZCB0byB0cmFjayBhbHJlYWR5IG1h
cHBlZCBhbmQgdW5tYXBwZWQNCj4+Pj4gcmVnaW9ucyB0aGVuIHdlIGNhbiBhdm9pZCBoYXZpbmcg
YSBwb3NzaWJsZSBkZWFkbG9jayBhbmQgY2FuIHVzZQ0KPj4+PiBwY2lfZGV2LT52cGNpX2xvY2sg
KHJhbmdlc2V0cyB3b24ndCBoZWxwIGhlcmUgYXMgd2UgYWxzbyBuZWVkIHJlZmNvdW50aW5nIGJl
DQo+Pj4+IGltcGxlbWVudGVkKS4NCj4+PiBJIHRoaW5rIGEgcmVmY291bnRpbmcgYmFzZWQgc29s
dXRpb24gd2lsbCBiZSB2ZXJ5IGNvbXBsZXggdG8NCj4+PiBpbXBsZW1lbnQuIEknbSBob3dldmVy
IGhhcHB5IHRvIGJlIHByb3ZlbiB3cm9uZy4NCj4+IEkgY2FuJ3QgZXN0aW1hdGUsIGJ1dCBJIGhh
dmUgYSBmZWVsaW5nIHRoYXQgYWxsIHRoZXNlIHBsYXlzIGFyb3VuZCBsb2NraW5nDQo+PiBpcyBq
dXN0IGJlY2F1c2Ugb2YgdGhpcyBzaW5nbGUgcGllY2Ugb2YgY29kZS4gTm8gb3RoZXIgcGxhY2Ug
c3VmZmVyIGZyb20NCj4+IHBkZXYtPnZwY2lfbG9jayBhbmQgbm8gZC0+bG9jaw0KPj4+PiBJZiBw
Y2lkZXZzX2xvY2sgaXMgdXNlZCBmb3IgdnBjaV97cmVhZHx3cml0ZX0gdGhlbiBubyBkZWFkbG9j
ayBpcyBwb3NzaWJsZSwNCj4+Pj4gYnV0IG1vZGlmeV9iYXJzIGNvZGUgbXVzdCBiZSByZS13b3Jr
ZWQgbm90IHRvIGxvY2sgaXRzZWxmIChwZGV2LT52cGNpX2xvY2sgYW5kDQo+Pj4+IHRtcC0+dnBj
aV9sb2NrIHdoZW4gcGRldiA9PSB0bXAsIHRoaXMgaXMgbWlub3IpLg0KPj4+IFRha2luZyB0aGUg
cGNpZGV2cyBsb2NrIChhIGdsb2JhbCBsb2NrKSBpcyBvdXQgb2YgdGhlIHBpY3R1cmUgSU1PLCBh
cw0KPj4+IGl0J3MgZ29pbmcgdG8gc2VyaWFsaXplIGFsbCBjYWxscyBvZiB2cGNpX3tyZWFkfHdy
aXRlfSwgYW5kIHdvdWxkDQo+Pj4gY3JlYXRlIHRvbyBtdWNoIGNvbnRlbnRpb24gb24gdGhlIHBj
aWRldnMgbG9jay4NCj4+IEkgdW5kZXJzdGFuZCB0aGF0LiBCdXQgaWYgd2Ugd291bGQgbGlrZSB0
byBmaXggdGhlIGV4aXN0aW5nIGNvZGUgSSBzZWUNCj4+IG5vIG90aGVyIGFsdGVybmF0aXZlLg0K
Pj4+PiAzLiBXZSBtYXkgdGhpbmsgYWJvdXQgYSBwZXItZG9tYWluIHJ3bG9jayBhbmQgcGRldi0+
dnBjaV9sb2NrLCBzbyB0aGlzIHNvbHZlcw0KPj4+PiBtb2RpZnlfYmFycydzIHR3byBwZGV2cyBh
Y2Nlc3MuIEJ1dCB0aGlzIGRvZXNuJ3Qgc29sdmUgcG9zc2libGUgcGRldg0KPj4+PiBkZS1yZWZl
cmVuY2UgaW4gdnBjaV97cmVhZHx3cml0ZX0gdnMgcGNpX3JlbW92ZV9kZXZpY2UuDQo+Pj4gcGNp
X3JlbW92ZSBkZXZpY2Ugd2lsbCBjYWxsIHZwY2lfcmVtb3ZlX2RldmljZSwgc28gYXMgbG9uZyBh
cw0KPj4+IHZwY2lfcmVtb3ZlX2RldmljZSB0YWtlbiB0aGUgcGVyLWRvbWFpbiBsb2NrIGluIHdy
aXRlIChleGNsdXNpdmUpIG1vZGUNCj4+PiBpdCBzaG91bGQgYmUgZmluZS4NCj4+IEkgdGhpbmsg
SSBuZWVkIHRvIHNlZSBpZiB0aGVyZSBhcmUgYW55IG90aGVyIHBsYWNlcyB3aGljaCBzaW1pbGFy
bHkNCj4+IHJlcXVpcmUgdGhlIHdyaXRlIGxvY2sNCj4+Pj4gQFJvZ2VyLCBASmFuLCBJIHdvdWxk
IGxpa2UgdG8gaGVhciB3aGF0IGRvIHlvdSB0aGluayBhYm91dCB0aGUgYWJvdmUgYW5hbHlzaXMN
Cj4+Pj4gYW5kIGhvdyBjYW4gd2UgcHJvY2VlZCB3aXRoIGxvY2tpbmcgcmUtd29yaz8NCj4+PiBJ
IHRoaW5rIHRoZSBwZXItZG9tYWluIHJ3bG9jayBzZWVtcyBsaWtlIGEgZ29vZCBvcHRpb24uIEkg
d291bGQgZG8NCj4+PiB0aGF0IGFzIGEgcHJlLXBhdGNoLg0KPj4gSXQgaXMuIEJ1dCBpdCBzZWVt
cyBpdCB3b24ndCBzb2x2ZSB0aGUgdGhpbmcgd2Ugc3RhcnRlZCB0aGlzIGFkdmVudHVyZSBmb3I6
DQo+Pg0KPj4gV2l0aCBwZXItZG9tYWluIHJlYWQgbG9jayBhbmQgc3RpbGwgQUJCQSBpbiBtb2Rp
ZnlfYmFycyAoaG9wZSB0aGUgYmVsb3cNCj4+IGlzIGNvcnJlY3RseSBzZWVuIHdpdGggYSBtb25v
c3BhY2UgZm9udCk6DQo+Pg0KPj4gY3B1MDogdnBjaV93cml0ZS0+IGQtPlJMb2NrIC0+IHBkZXYx
LT5sb2NrIC0+wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcm9tX3dy
aXRlIC0+IG1vZGlmeV9iYXJzOiB0bXAgKHBkZXYyKSAtPmxvY2sNCj4+IGNwdTE6wqDCoMKgwqDC
oMKgwqAgdnBjaV93cml0ZS0+IGQtPlJMb2NrIHBkZXYyLT5sb2NrIC0+IGNtZF93cml0ZSAtPiBt
b2RpZnlfYmFyczogdG1wIChwZGV2MSkgLT5sb2NrDQo+Pg0KPj4gVGhlcmUgaXMgbm8gQVBJIHRv
IHVwZ3JhZGUgcmVhZCBsb2NrIHRvIHdyaXRlIGxvY2sgaW4gbW9kaWZ5X2JhcnMgd2hpY2ggY291
bGQgaGVscCwNCj4+IHNvIGluIGJvdGggY2FzZXMgdnBjaV93cml0ZSBzaG91bGQgdGFrZSB3cml0
ZSBsb2NrLg0KPiBJJ3ZlIHRob3VnaHQgbW9yZSB0aGFuIG9uY2UgdGhhdCBpdCB3b3VsZCBiZSBu
aWNlIHRvIGhhdmUgYQ0KPiB3cml0ZV97dXBncmFkZSxkb3duZ3JhZGV9IChyZWFkX2Rvd25ncmFk
ZSBtYXliZT8pIG9yIHNpbWlsYXIgaGVscGVyLg0KWWVzLCB0aGlzIGlzIHRoZSByZWFsIHVzZS1j
YXNlIGZvciB0aGF0DQo+DQo+IEkgdGhpbmsgeW91IGNvdWxkIGFsc28gZHJvcCB0aGUgcmVhZCBs
b2NrLCB0YWtlIHRoZSB3cml0ZSBsb2NrIGFuZA0KPiBjaGVjayB0aGF0ICZwZGV2LT52cGNpLT5o
ZWFkZXIgPT0gaGVhZGVyIGluIG9yZGVyIHRvIGJlIHN1cmUNCj4gcGRldi0+dnBjaSBoYXNuJ3Qg
YmVlbiByZWNyZWF0ZWQuDQpBbmQgaGF2ZSBwZGV2IGZyZWVkIGluIGJldHdlZW4uLi4uDQo+ICAg
WW91IHdvdWxkIGhhdmUgdG8gZG8gc2ltaWxhciBpbg0KPiBvcmRlciB0byBnZXQgYmFjayBhZ2Fp
biBmcm9tIGEgd3JpdGUgbG9jayBpbnRvIGEgcmVhZCBvbmUuDQpOb3Qgc3VyZSB0aGlzIGlzIHJl
bGlhYmxlLg0KPg0KPiBXZSBzaG91bGQgYXZvaWQgdGFraW5nIHRoZSByd2xvY2sgaW4gd3JpdGUg
bW9kZSBpbiB2cGNpX3dyaXRlDQo+IHVuY29uZGl0aW9uYWxseS4NClllcywgYnV0IHdpdGhvdXQg
dXBncmFkaW5nIHRoZSByZWFkIGxvY2sgSSBzZWUgbm8gd2F5IGl0IGNhbiBiZSBkb25lDQo+DQo+
IFRoYW5rcywgUm9nZXIuDQpUaGFuayB5b3UsDQpPbGVrc2FuZHI=


From xen-devel-bounces@lists.xenproject.org Mon Feb 07 14:29:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 14:29:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267037.460736 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH51C-0004Zs-Bg; Mon, 07 Feb 2022 14:29:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267037.460736; Mon, 07 Feb 2022 14:29:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH51C-0004Zl-8k; Mon, 07 Feb 2022 14:29:26 +0000
Received: by outflank-mailman (input) for mailman id 267037;
 Mon, 07 Feb 2022 14:29:25 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=F54n=SW=epam.com=prvs=403792ff6c=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nH51B-0004ZZ-6P
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 14:29:25 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 581f47eb-8822-11ec-8f75-fffcc8bd4f1a;
 Mon, 07 Feb 2022 15:29:24 +0100 (CET)
Received: from pps.filterd (m0174683.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 217EE0rl030905;
 Mon, 7 Feb 2022 14:29:19 GMT
Received: from eur03-ve1-obe.outbound.protection.outlook.com
 (mail-ve1eur03lp2050.outbound.protection.outlook.com [104.47.9.50])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3e350h026e-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Mon, 07 Feb 2022 14:29:19 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by VI1PR0302MB2589.eurprd03.prod.outlook.com (2603:10a6:800:df::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Mon, 7 Feb
 2022 14:28:43 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77%3]) with mapi id 15.20.4951.018; Mon, 7 Feb 2022
 14:28:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 581f47eb-8822-11ec-8f75-fffcc8bd4f1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=hZCv1l1F64NzO+6U1RzvK+J89Jkf0xvaln1i6eJ5XNlQdB+JlDc+WXHlGmH6aEqPfqO5Tdza1zuNeYA7cnYiHY9fpsZU1Y5pfi+X64i4tqTrokYuklPpoy6vp36czl+ChL+Rafc7uBo2ngUPIlidRzWUVKLkhkUDU6gP7e9CHpkT+Vmd8TMTXZya4UvQrnxSqQA/u5/QuTlaqTXilD4BlT9PVh7iiatwmSfxnJTSM2MVZ4eICek4k9E4+5k9jG7ibgHnlmlUiHFnmPpAYRFnbmlHLJK3Kqj9nkDtUh1T4a9HakaTnQjcteHzwklA4wU4W/TnSA84e500GsBotpljIQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=UAcMnT8uCKiLODXO71H8yGt0byHfus7KS6BKcroKuNc=;
 b=OkTyZJLH/84zmBFEQ7+UlX/jdzehfo03PiFaofXig5JJMAY2QDYwMW8Qer35cnvIpuunjoSTyKHYe/V3uoT6+vgEI8qyeDUuvd4/v9fV0oCviUK/BFW5yN8Aq38HB4/1SQVNdytCmDhXq3g9488Zrh9XcAw4vUDIBidYDbf2mIM64ba84Xzzsw/0UNcYXjrjx90LZMlq4QfBABRTVq6o8+oFqBxoTGBMhAR8VPkLXdw2eQyfzFjQ1ShS/J/kaQe6f8tCrVzv71yv6mIqQKh9pZxls3YX2Y/C/EMtGXzTjbgTzhXEKBfjy8KKVnPocF8xlODDtt0t+7/0zD43xPeegA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=UAcMnT8uCKiLODXO71H8yGt0byHfus7KS6BKcroKuNc=;
 b=T3v/3DnYPo1uyW0/vV0JU2dcZFgJSs2Y8AVh3m+DKRqhk3oPq/NoyFSbi8DCBXBggRTY8HI1i+Sq0GV17zaFSXjmpPah1nAMz8zrw1YV2U24elehauIYDnjs/SiZmwV6hMOSOnMbHtmHGfEc4j5hhScCSA/X0HbCl/WxoQuJHl7MAtoRxmgvD1/YlJTnL/Z1x3BAdDV8Cwo+Ffaw9xGnXU7wNg2YahX1PfZkdLlm5vN7JdtVG2d1QRCiJ2v3gRpvujvR1DhadMtWaO5xJ4u/HQ04fkXqgTPX9Ov54fKKkFOyhCGAxieqIxcB9vL9On/ZE77amKaFhRRbYN5II5buHw==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?=
	<roger.pau@citrix.com>
Subject: Re: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Thread-Topic: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Thread-Index: 
 AQHYGZFc/MnzQOjwVEeBBUHLSW0md6yDBUkAgAASSACAAATYAIAAD/WAgAAKNgCAAAbfgIAABnuAgAAQvgCAAAMCAIAAAY4AgAADxICAABrnAIAABAgAgAR3CoCAABt5gIAAEpuAgAAE5ICAAATvAA==
Date: Mon, 7 Feb 2022 14:28:43 +0000
Message-ID: <2a66bdf0-a284-4d76-17c1-0e147a262c25@epam.com>
References: <c3a99712-cf7c-37da-aac1-f2ee00e6d53b@suse.com>
 <Yf0KcVD8W05A4fbB@Air-de-Roger>
 <1ed0e342-16cd-2f16-c05c-186667a22762@suse.com>
 <7e3562b5-fc67-f213-e872-f211450d9e2e@epam.com>
 <a8fc599c-f620-c4d1-2077-c57068f46a7f@suse.com>
 <deef8468-d607-e49e-f456-6a8013329ca1@epam.com>
 <Yf0k6aoKK5G3iad1@Air-de-Roger>
 <3ad10a99-c706-b95f-1419-2c0c7cf37d58@epam.com>
 <Yf0+3C9nF8+tewLw@Air-de-Roger>
 <c5fea3bb-834b-eeb7-d7a1-1ee609037a9f@epam.com>
 <YgEUwTxhnWVMGMJK@Air-de-Roger>
 <9ce90193-74a0-5642-d22b-6b8c3340c3cf@epam.com>
 <1f65ae7a-898d-2c27-0ada-d71d778b0627@suse.com>
In-Reply-To: <1f65ae7a-898d-2c27-0ada-d71d778b0627@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 66e6ff66-2aa7-40af-106b-08d9ea4624a1
x-ms-traffictypediagnostic: VI1PR0302MB2589:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <VI1PR0302MB2589B3C08BE5136186FD75ADE72C9@VI1PR0302MB2589.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8882;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 QKseVBaSOccA7AV2k4BQ4wzRvYXyVF4imWxNFfi1P+sjPGYrZjLyc3tf//12RpLVzH55Ciye8pTk8iNg6SRyXdqfJyHZwKSY0ktLx+JpK7I+Dg0mGbVfNSYrQzWlCmVlGpK/Muk9RMFtWK5aYI4KmxqWxogH7uxonJdFfn7XL5I9iF8IRFPnccEqUe7p0u0vl0LxFynaUKRxdQ5vkLNz1t4AfnYED+tw5UuZEF+UBj0l7MY9KMuGXQOSRcJmk5P3Dkpl/qeJ5JRm9FzLpbnnp9RqeeoUxMfC7BuTzggbUdl7QaIg2+wVj9Y5Ogg6HqCw/b46RxyyJPDMnhvO2pkAUKzL2aQcjJV1C2a/1XTLOSzTcTXvx1xEpF5SDtLW1asnLZMS+QteRa6E9GlufKCKZQhI+teEMGJTwXcPgBYl4X/VWC6cNpW77Dg8g5yZ5c2wuV4C9SV95yPSH2eXOkG9oxkSieatlF6D4iXHanXpbzBlSIhrOs2ZV32WGPDL+wjqQmTixELqOHqTM1UyTgYlTS0n0MYhfeg0syexjsf0zkP3u1g1zotfLevmGaKppC+gGnvsViEKjEe6yVxO+7yNmJ7no9hXT8pWDo/5HsmWrvhuQ5p9xlbLmZNBpH8PJ/5+Oni0oDyqzdyJu086AEIoue6HbO5hCMWN7Dyj8J6cQllcKaOCAj2ZtAvcMeHqr0zJrEPoPbF5vEfQbKY6uk+ZOwu8Weu6DnBCPPlbzHKOK0s=
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(4326008)(508600001)(91956017)(66476007)(8936002)(66556008)(8676002)(6916009)(64756008)(66446008)(76116006)(66946007)(83380400001)(54906003)(6512007)(6486002)(26005)(186003)(38070700005)(2616005)(2906002)(316002)(7416002)(36756003)(31686004)(31696002)(6506007)(122000001)(55236004)(53546011)(38100700002)(86362001)(71200400001)(5660300002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?QmtMUWd5MStlSUpFeTBOUWI2Zjg2UEM4TTRoYjhTVzBVVXdRNTZpbzdPVTNJ?=
 =?utf-8?B?dmYvNE82WlhhZ1o5OVd2ZmRQYTAxbHd3MUFNQ256d1FCU0treE0rRjFXY2pM?=
 =?utf-8?B?SWlyMERiRkF1N29HTi9WaWZVeHJrQVNJVDVZVis1MWhScmJXRzZKbGJtdnZo?=
 =?utf-8?B?dUswd3hXMFZYVWdHT1BWaTRza3JUV0RtamRQUGV6YVdlT2E0STE4NXFDSVNJ?=
 =?utf-8?B?RUxSM25nOWkzaFJzZ29BWXVGbjVwblREUWM1RVZ0Rk1BeXJFaTIyYlR2VDF6?=
 =?utf-8?B?OWtlN3NxaXQ4TDNWRGppb0ZjcG82OUtEaW1zZnBVNUVWWW9PTGZaQmVrODRy?=
 =?utf-8?B?dmpoWUNlcElydks4Q0JuQ3kzVVJrd1ZEYVd4K0EzRVZJOWlwS04yNkh5RnlT?=
 =?utf-8?B?T3hETnNlNjFHa2hHa0R6dVB1TUFCUW9PanJXS0xIcTNrQ2p0WmttYXdUaUdK?=
 =?utf-8?B?VWo3Z2s5ci81c3RueHNUK2FCMUZmc3VtcWFkQXpqbGFkS3NXNjNLVDQ2UWsx?=
 =?utf-8?B?NE5pTmlOc3BQM0Fpb0xpL2VYVDg4NWp2dFAxQmJpaEJvVW1sMXdzbUdydSto?=
 =?utf-8?B?b1dReDdhV0ZNQ1R6Um9kaXlWQ2ZYWHRNQkFiOTAwNWVMQlhFeG5jVFZNYmdX?=
 =?utf-8?B?WVd3Mlc4b1RrS0g0SGJSb1pSN0xsa2JtN1p2eGlFR1NKaFdvb0FmMk1obmRq?=
 =?utf-8?B?dlQzeGNqc2JnaDkzU3RmU1RoUW42N1JmcGdndWhGNmhiZDh4NGQ2WUlsRkI1?=
 =?utf-8?B?OVVxTkJiWjhJRWErVHZTUDBWVmh1SjR4M3d5VDZYNzA5ZW1vMW9yM214V0ZT?=
 =?utf-8?B?MzNOZE5ZcUpldVBSMzdzbnNCeEc3S1lTOVhYNFBxY2kxVFI5TWFQUHNIR3dB?=
 =?utf-8?B?REY5NU1ob1V4ZW4ySkxFTnZOc2wrdkhuYlBJa3pQd1BQNFN3WFVLTm5LRDNM?=
 =?utf-8?B?SVVkdVhVampjQmZsamhEVlkzbVFrTEl1Vmd3UXdncUphVHIvMmlDYnFsNlRo?=
 =?utf-8?B?WExDM2hxakZyQVFxNi9JR0I1UUt6dktabnVod3VsRy9VZndjRVE0SjVIZmdJ?=
 =?utf-8?B?L3B0b2Y1eTVGTjJ3VzdKTTgvT0pVOVQyODlLalorVUhmVDd6TGdRdnIrMkdE?=
 =?utf-8?B?c2ptUmsyNlRqYm5RWG53TFRveEFyMmhNdHdPbGlscEJkamtzNzlaMzlsZDU3?=
 =?utf-8?B?cHdLcmRDV21Lekx5dWNmVmRFcGxiSFZpMWJFMkxsMW1iR3VWbFRJcGZic0dG?=
 =?utf-8?B?MjZnM3I4eWVkbHNDWitVamxYUVFHakV4UGxPV2NlemVYWnp1V1NiQnJneVo4?=
 =?utf-8?B?VUtDb3ZLOVl5TnhieE5YWkhhVDVXamFSaE9BVitSdWRxZjMxUE5ka2t5ZkF3?=
 =?utf-8?B?SFpqWkxQeUhDdlFBcC9ncGpCMGlCK2pIY0ZkajQ4WEJkTkFkQ2hzRytHWWxM?=
 =?utf-8?B?cmgvNkNnTXpKckpxMFVVSjVJN05PL2dPcERSS3VMaHV6TVR2SngrWG9ta3Mx?=
 =?utf-8?B?M3c4Y2xLZlNpcXA1R21TSnJGSk94TmVUUFRuUEhtaC9OamhNMzFsbnRxS2xa?=
 =?utf-8?B?M0NMa0cvdVJIb0kxNm5TczFGSElHTi8xMTdRYllZM0Y3OC9oeVpRY2RSQkhm?=
 =?utf-8?B?a1ZwRjJaTm1iSkJxTGdua0JzRmhUb3hJS0phRzU1RkI0TzJMQkRVdjYzYzBj?=
 =?utf-8?B?NTdVMjZKeEZjK0tVeXBvbFNiNitMQmxyeGFzcFVtQWNkM0JDQnJJZTBORzA1?=
 =?utf-8?B?SUg5OHNtaWlFekQrUmFnR2F3bm9CM29JcFRRRDhxaXVFOUdmb3dGM2p3NWRL?=
 =?utf-8?B?d1JKU2t1bXArUjkwTmtyZG1zS3h6M2V3SUdWeG1aZ2kreVZpcWMrbitiWDZT?=
 =?utf-8?B?cDVTRGRidWNEL2ZFRjFITTNjZExLSURnS2wya1VVNVlabEExNWpCeGVUcXhU?=
 =?utf-8?B?c0IyOXNtVjRCNzF5S3dkVThITEt5Tk5pY3NsVENudXpOK1QrSXBDYnBTMXBq?=
 =?utf-8?B?S0Zqc3VvQS9PLy80T3daSlRrL0tBdDhONGI4cDVBS2xuN2pBaWpzSEM5cDRp?=
 =?utf-8?B?bEhrNG9laEZibEhnUmtxMWpqSmdBanp6ZTRBYjJZUVJDcDh2R2IyWFB0QzFV?=
 =?utf-8?B?YUpSRGl0VzU5YjZiY0lJMlJROHRoZnY0TzlOcVVsR2ptcHV2a2NLS1g0UUlJ?=
 =?utf-8?B?aFlKTFhSL1h5dkF3aklURTQzeVMyMWV3T3pNQmFOQ3I4cHVsQmk4YVNwM09n?=
 =?utf-8?B?b0FUSG1FcTNPd2tZQS9XM2pseVhETngzRGdTT2pmZ05pNG82WjBsU3pndkhj?=
 =?utf-8?B?YXBKQWJoL3hBbE5HU2FGNjlOZ0pZU3RTcDFNbUhCdVF0OG11UGliZz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <0E2900BE4F34104295F3BE1E964AFCAC@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 66e6ff66-2aa7-40af-106b-08d9ea4624a1
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Feb 2022 14:28:43.1363
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: LAirtDUZ7kYotQGlk+xHcRYAwESCiP5BCdvbudxmmWg8Oy77IrCyTrpaTLpOXG4WysogrjqTYaBAJfHMXhHybsSy0jnN4yoDvDK7vNneJxq1+OlFdR/4eW+WUxsNvf1W
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0302MB2589
X-Proofpoint-ORIG-GUID: vudyfM0hjtvwmvh8sDMwoLmnfJixRQRi
X-Proofpoint-GUID: vudyfM0hjtvwmvh8sDMwoLmnfJixRQRi
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-07_05,2022-02-07_02,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0
 suspectscore=0 spamscore=0 phishscore=0 priorityscore=1501 clxscore=1015
 mlxlogscore=707 bulkscore=0 malwarescore=0 mlxscore=0 adultscore=0
 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202070093

DQoNCk9uIDA3LjAyLjIyIDE2OjExLCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMDcuMDIuMjAy
MiAxNDo1MywgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+PiBPbiAwNy4wMi4yMiAx
NDo0NiwgUm9nZXIgUGF1IE1vbm7DqSB3cm90ZToNCj4+PiBJIHRoaW5rIHRoZSBwZXItZG9tYWlu
IHJ3bG9jayBzZWVtcyBsaWtlIGEgZ29vZCBvcHRpb24uIEkgd291bGQgZG8NCj4+PiB0aGF0IGFz
IGEgcHJlLXBhdGNoLg0KPj4gSXQgaXMuIEJ1dCBpdCBzZWVtcyBpdCB3b24ndCBzb2x2ZSB0aGUg
dGhpbmcgd2Ugc3RhcnRlZCB0aGlzIGFkdmVudHVyZSBmb3I6DQo+Pg0KPj4gV2l0aCBwZXItZG9t
YWluIHJlYWQgbG9jayBhbmQgc3RpbGwgQUJCQSBpbiBtb2RpZnlfYmFycyAoaG9wZSB0aGUgYmVs
b3cNCj4+IGlzIGNvcnJlY3RseSBzZWVuIHdpdGggYSBtb25vc3BhY2UgZm9udCk6DQo+Pg0KPj4g
Y3B1MDogdnBjaV93cml0ZS0+IGQtPlJMb2NrIC0+IHBkZXYxLT5sb2NrIC0+wqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcm9tX3dyaXRlIC0+IG1vZGlmeV9iYXJzOiB0
bXAgKHBkZXYyKSAtPmxvY2sNCj4+IGNwdTE6wqDCoMKgwqDCoMKgwqAgdnBjaV93cml0ZS0+IGQt
PlJMb2NrIHBkZXYyLT5sb2NrIC0+IGNtZF93cml0ZSAtPiBtb2RpZnlfYmFyczogdG1wIChwZGV2
MSkgLT5sb2NrDQo+Pg0KPj4gVGhlcmUgaXMgbm8gQVBJIHRvIHVwZ3JhZGUgcmVhZCBsb2NrIHRv
IHdyaXRlIGxvY2sgaW4gbW9kaWZ5X2JhcnMgd2hpY2ggY291bGQgaGVscCwNCj4+IHNvIGluIGJv
dGggY2FzZXMgdnBjaV93cml0ZSBzaG91bGQgdGFrZSB3cml0ZSBsb2NrLg0KPiBIbW0sIHllcywg
SSB0aGluayB5b3UncmUgcmlnaHQ6IEl0J3Mgbm90IG1vZGlmeV9iYXJzKCkgaXRzZWxmIHdoaWNo
IG5lZWRzDQo+IHRvIGFjcXVpcmUgdGhlIHdyaXRlIGxvY2ssIGJ1dCBpdHMgKHBlcmhhcHMgaW5k
aXJlY3QpIGNhbGxlci4gRWZmZWN0aXZlbHkNCj4gdnBjaV93cml0ZSgpIHdvdWxkIG5lZWQgdG8g
dGFrZSB0aGUgd3JpdGUgbG9jayBpZiB0aGUgcmFuZ2Ugd3JpdHRlbg0KPiBvdmVybGFwcyB0aGUg
QkFScyBvciB0aGUgY29tbWFuZCByZWdpc3Rlci4NCkV4YWN0bHksIHZwY2lfd3JpdGUgbmVlZHMg
YSB3cml0ZSBsb2NrLCBidXQgaXQgaXMgbm90IGRlc2lyYWJsZS4NCkFuZCBhZ2FpbiwgdGhlcmUg
aXMgYSBzaW5nbGUgb2ZmZW5kaW5nIHBpZWNlIG9mIGNvZGUgd2hpY2ggd2FudHMgdGhhdC4uLg0K
PiBKYW4NCj4NClRoYW5rIHlvdSwNCk9sZWtzYW5kcg==


From xen-devel-bounces@lists.xenproject.org Mon Feb 07 14:31:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 14:31:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267046.460747 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH52z-0005xC-OS; Mon, 07 Feb 2022 14:31:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267046.460747; Mon, 07 Feb 2022 14:31:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH52z-0005x5-Kk; Mon, 07 Feb 2022 14:31:17 +0000
Received: by outflank-mailman (input) for mailman id 267046;
 Mon, 07 Feb 2022 14:31:15 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=owYM=SW=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nH52x-0005wt-Od
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 14:31:15 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 99c4639a-8822-11ec-8eb8-a37418f5ba1a;
 Mon, 07 Feb 2022 15:31:13 +0100 (CET)
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2051.outbound.protection.outlook.com [104.47.2.51]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-41-5pFxRSd4N3C4Cp0VItJ-ew-1; Mon, 07 Feb 2022 15:31:11 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5648.eurprd04.prod.outlook.com (2603:10a6:803:e5::30)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Mon, 7 Feb
 2022 14:31:09 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.018; Mon, 7 Feb 2022
 14:31:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 99c4639a-8822-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644244273;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=bQPXztmSsN/WlqoqGglenb983o+SKCoxVV8WvV8ZyXI=;
	b=id7a29eBLE68w2QmMt1JT7DZbTzSfTsdur+Fr6CrEJDmUJGMSl50Lkka6eIj8wekrbyw2Q
	GjGuG9IMknTE1UjvtgUF70AdJqzvisj4GvuoaeTROupCQ4rVWkhAxWp2IwGqTRqHA2Oq9W
	xycx0OqoQQ775pal5mWGl/CB3RSktBw=
X-MC-Unique: 5pFxRSd4N3C4Cp0VItJ-ew-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=SM6uArVAjTPQvs8bhAdMFcLpTPZ7+S+5OjuxBLUDu1E+1eqpMPFjoO7acbDnoFLG6nwwLhK90hLVnCOL66aOIh9jNllEspIf+RMW/vJLJMAUvQSyTUY8pwZfKy+hySc4aR6pjpwLFdPPMCfRAfcX32r9O8/vF54iIbBmgh+cTGrFFWu2I8kx7VvoyFg5v0qQcfr8/Vdur1cX48Jj09dEIayco2fe67+YpPvHqWPtUGIqYlZeXSJJ7Cwg2RIKBe1IsipT0KszpKikSHrGON3kopGq6UIv65QahCZHNW4CPmWlM2pIydA8EPvdEB3MzTogmiOd2EVOWzUrWBqw1bLU6Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=bQPXztmSsN/WlqoqGglenb983o+SKCoxVV8WvV8ZyXI=;
 b=oK25qfMAkwvRj2HrW897IysiI88W3COzt+0G+KerncIGspPKGh8v1/1aYxeJpi37UY+jW6KgE1ktk3tOVVRV1vx4wtGZsMBlkD2k7XHc+UZhFtSA/DynAcFcmx99DJrasPWcKK9S3ANsSls4b4AI9NsmHdMUA47+BOqYWcwwqqDMd09iZUeglKEjAI76Vh6DAiFJVnMMUrmQ2SE8geCtRIXdGahFsY5GRFOAJi8tI7l1hELlBsOSiJObPRhexVhuc3rS25NSXekQdZJW0RPPT0/iARrhaP9XWLNinnZG7FZaBVyTCHXXsHzJJpsZUieJp/ccNQhG7g7Mzzo/nCT/Tw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <8f35e7c5-3193-4b10-ae25-df838e2262c7@suse.com>
Date: Mon, 7 Feb 2022 15:31:06 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v6 10/13] vpci/header: reset the command register when
 adding devices
Content-Language: en-US
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Cc: "julien@xen.org" <julien@xen.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Artem Mygaiev <Artem_Mygaiev@epam.com>,
 "roger.pau@citrix.com" <roger.pau@citrix.com>,
 "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
 "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
 "paul@xen.org" <paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-11-andr2000@gmail.com>
 <96381d7e-dafc-acee-3abf-f9815deb207c@suse.com>
 <ef76faac-f9d3-1cb8-06b5-189ccd299542@epam.com>
 <6f0a015b-c48f-76ed-9a51-39c045ff5927@suse.com>
 <2ad372d4-a181-9307-ef50-a5adb61dae66@epam.com>
 <49380584-0577-96f2-ef1c-a96eabf0d227@suse.com>
 <fbd410d1-84ad-2309-ca05-b9ac7f95f1f9@epam.com>
 <dbef1c95-818c-427c-1963-75d584843cff@suse.com>
 <f34cc940-7f5f-aebd-60d9-d1a3d85d1283@epam.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <f34cc940-7f5f-aebd-60d9-d1a3d85d1283@epam.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0301CA0032.eurprd03.prod.outlook.com
 (2603:10a6:206:14::45) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 65270e7a-ed5f-49fe-5279-08d9ea467bab
X-MS-TrafficTypeDiagnostic: VI1PR04MB5648:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB5648E7723EC5BC0B8676593AB32C9@VI1PR04MB5648.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6790;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	vvgOeT/lAspD+kGhO0BcNMqOKA+3HBsH1Be2OZH+mWMijz09bJY1gild/tTiG/tV7cPBAGuwyDZS7e5vX/Wu63oPQnAT+KE6twdwmZ3O/wOYPjYfFTpAltx7j8OYurufmT8A4xngcjmx3HLel4V+5Ak8onxLyP3OKWBul8oYHAZrAcKwsZNv33/ueYB/MltRp+G1g0NFhtnWd3J6vS6dbfYazYoR69KkbNA3ZD/7HhFX2FlULZ74Ufrhx7rFBFxyi+zVclppmvGD/wMe0u7j8Pdwl5HJ/eE9tl20Ev6d21zPKsO8I74OaKGYrB+V7YBscTxRK3BSWrmgKvbFRaonNiOVTFDW9kPFKpxTwyxkGJ33PHXUj63RKKMmi2QEzMr6uRT/c/mRNms0l6Tx49T5MM1B+b84SHsgmBLfZC7OblCJf2dM/wc0bMFEfpxqdsiKMvvoSkGFdrn0LOX0Rr7KyUpPH/ikBr+OX2SRdmDh4pDcqyoUpqqc7q9RmlSjZg3yaXlcuizXEke9Ni4P/wZG9lCICG6+LOnmXBeT1sHd2+Q8PEqFMosFrv2wea7v7M14Ullw/ODOiPk7Gd7hVIspWuuiT7fE/SvkBHjEUf7Yno3B+wflxB3lbugrFeFh30bxMFMIbkvlxFyXari5oY0dRQMuMoap+hVRilWJpwzstuAbjbuiSk43ExqnaXzchGicPnOXEDelK2fjD7ClXpdQ1suKQVicq1cA6VYN44jdNKM=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8676002)(83380400001)(53546011)(6512007)(36756003)(31686004)(6666004)(8936002)(66946007)(26005)(6506007)(508600001)(186003)(66476007)(66556008)(38100700002)(4326008)(54906003)(7416002)(2616005)(2906002)(316002)(6486002)(6916009)(31696002)(5660300002)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?QjZYa05ReFpPVE96OG5JTS85c0txQjdkVm9ZbG1iY3pJQ250U1VMWklhdGs1?=
 =?utf-8?B?VVp4ZzAveDc3YnB1WTBWNmlvcCtMQVFGeGV0Uk9JMnA4L1BLM2E3K240TGRt?=
 =?utf-8?B?SGdhYTZwSTlUOE9wVTY2NmtFS1hnWkpydHVoWjllRXdPSzFiTHJXYTlWMXJh?=
 =?utf-8?B?YTVuVzBINEdMY2RET0xMNHpaMzRobXFHVVAxaFVQMi9Od3FMUjdTZGdqcHFH?=
 =?utf-8?B?VUhHN0IrQU9VbjVhenZvKzFqN1FZWlhNcW0wMmlSRTl3ZVF0Qnd5ZW9hQVlm?=
 =?utf-8?B?TkpVaTZOWUdOenRPYnlGY2xCaFFOc0VqOGNKZWVsbUtudlpSd2pOSXVPTmJp?=
 =?utf-8?B?YWx6Nlh4TThzeFR2OFNJL2UxcExyK3Q5UHVLTmdjODVNVDhYWTFMaUNCSzF5?=
 =?utf-8?B?OURCc1BidjNoaUF4cVZUM09vNUUxZmx0UUlISEUyNmoyN0JWWjdBd2dOd0pK?=
 =?utf-8?B?SFkrVHNyaFNUbSt1UHdWU2I0NklrMHBRNDM4VGFFQ2hoN0p2bHErd3E4aXc0?=
 =?utf-8?B?OExXRVdVV0JXWWVzYnhnVzc3aEVJamMwd0lEVjlMbyt4L0p4QzNaSWJKVWVR?=
 =?utf-8?B?Nm1JdVdCdGV2aXJMMFkydWRJckNnaU9Kb01zVm1LNHEybUxBekpaSnV0dytV?=
 =?utf-8?B?am1PdnVoWXhHaktGd29xWmMxUEg4dUt0ekgvVDJ1L3ZNVWN2ZDVBRERuTVAx?=
 =?utf-8?B?alhSUWFhdU82UnpsYWV1WmRRTVFncmNNc2lUOFd2dHBFU3ZBeEFmOGVXRVVT?=
 =?utf-8?B?NExnekxuc2p3R2MxYWlRdmtCTFFnRUFIZlEycGpRSzN2ellia01lVFR6SmxR?=
 =?utf-8?B?c3RoR3EvWHZGTWkvUzRuRWNIcFdzTGRmbFhPaGw3TEFlcjcyM3EzM0hueU9x?=
 =?utf-8?B?aVowbk5ZTzFEREJMbm41ZHRReVkyMGNTVFcvWXlMMUIwZGZyOWR1L3UvMkxX?=
 =?utf-8?B?SU5rRUFKNTVQMFYrUUtIS0F6THdua0VHZTZWTkhUN3JkWUZmMEVzWFUzT2lj?=
 =?utf-8?B?RGF0c0VJTzFZMVlCcU1LcC9sNGNxK211cnVTU2J0eUV6RlJoY0lEVm5lQ2dv?=
 =?utf-8?B?Yi9xYkRDWFJBZWk1SHdkMzdtUk5US2xnUlR0QkJVWE8zanpsQUx1WWgxK2Nl?=
 =?utf-8?B?NGplYmZlRkdoRG0rOVhVdmRGaENVVGlJcUNEQlJpbFFmcGQwY2Nxb0ZpM3l5?=
 =?utf-8?B?TjhXYkJYMnhyQjNYSVpQd1RHSmpzeU5KdkdhcEVOMktMSUpzcmk4WE9YR2sr?=
 =?utf-8?B?QU5lTk1BM0tlNVVuZjJzQUIrbkcwSlk1bGtZSjRyRkpEaVBrNHdGK1p3TzRK?=
 =?utf-8?B?ckZOc21YUjF5cnUyckFlWDcrbnl5VVMwMGxKaFN2UU4rYUFOZjJsM09WMmR3?=
 =?utf-8?B?dS9UdkpudXVLdTV6bTFXMkdDR214TFFwOGh4NEpzU2VDc1JlTHBkNUl2MzVU?=
 =?utf-8?B?cGM3azdNbDBxVVg4eGR2TWRGeDVOK0JBSWQ1d253Y2kzcTgzdTJjbVhPOUQ4?=
 =?utf-8?B?SXR1MFJFNnZERjd0Zlh0NEhJSElKRmFqZTFwYU9GQmtOUlJtUEFRUnJiVWxE?=
 =?utf-8?B?eHVENDdZVUVDOGp2Nm5salo0Z3NjbUd1ZlBsUWJyU0xWTnBCTTVBdUNYdFVa?=
 =?utf-8?B?clBFdnlQSHdNTkxlZTlhUkxFMWsxQWFDNEJXb3BHUyt2YStaMlR3NEhMM1Jk?=
 =?utf-8?B?WkUwVFkrT2ptVGtpeDlZSHlsdHBvanRBSVMwaC9KV3dMOFE3RUVLSmRYaDFk?=
 =?utf-8?B?KzJLd1dQTjZKck56cHRJYXZOY0V6K3JqN1YzaFBMTHpNODU0aW9wblBQeWVR?=
 =?utf-8?B?aEUvL3dLNzlXcThwUFhvTEpGdXZKYVFCbzIxeXBTSDRZdGRWSVpjY1hFTDN1?=
 =?utf-8?B?NWxWeUdBOENjS0N4WUlVT2w4TDk0Q2JtaE5LVmdTazFWVXE3dGg4RHlKaEJJ?=
 =?utf-8?B?MldwNDB6dnJDT1g3Sk1HamRZSjlyVjllMEJwUEkzbEpKR1prdU1LYlhaZ1gz?=
 =?utf-8?B?WS9zYjNOZjROcVpvVWxGdWpOZTY3ZXJSMnhickdROFFYbEhTZXN0MFRwN3g1?=
 =?utf-8?B?K2EvazBxc1BjOXNUSmJvYm5sQmhpVDI4WThxVndSaFBBU00vZmYzcGNzMnYz?=
 =?utf-8?B?SDJwU1JjRFBxWlRZODVXcTdkL1oxWlJMSlBMTUx0WTRYZStZbHNoVmYyVmxQ?=
 =?utf-8?Q?FiHypAiCzCLbSP6HqJvCTcQ=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 65270e7a-ed5f-49fe-5279-08d9ea467bab
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2022 14:31:09.5102
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VThkhggbWKhKRQKvlVIb9+oC6R09vT/zYpE5QjiITefry7Aw2OTlMys5ITrC1To+cdZlaqDbh4hzw0kWBaKYRw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5648

On 07.02.2022 15:17, Oleksandr Andrushchenko wrote:
> 
> 
> On 07.02.22 14:54, Jan Beulich wrote:
>> On 07.02.2022 13:51, Oleksandr Andrushchenko wrote:
>>>
>>> On 07.02.22 14:38, Jan Beulich wrote:
>>>> On 07.02.2022 12:27, Oleksandr Andrushchenko wrote:
>>>>> On 07.02.22 09:29, Jan Beulich wrote:
>>>>>> On 04.02.2022 15:37, Oleksandr Andrushchenko wrote:
>>>>>>> On 04.02.22 16:30, Jan Beulich wrote:
>>>>>>>> On 04.02.2022 07:34, Oleksandr Andrushchenko wrote:
>>>>>>>>> Reset the command register when assigning a PCI device to a guest:
>>>>>>>>> according to the PCI spec the PCI_COMMAND register is typically all 0's
>>>>>>>>> after reset.
>>>>>>>> It's not entirely clear to me whether setting the hardware register to
>>>>>>>> zero is okay. What wants to be zero is the value the guest observes
>>>>>>>> initially.
>>>>>>> "the PCI spec says the PCI_COMMAND register is typically all 0's after reset."
>>>>>>> Why wouldn't it be ok? What is the exact concern here?
>>>>>> The concern is - as voiced is similar ways before, perhaps in other
>>>>>> contexts - that you need to consider bit-by-bit whether overwriting
>>>>>> with 0 what is currently there is okay. Xen and/or Dom0 may have put
>>>>>> values there which they expect to remain unaltered. I guess
>>>>>> PCI_COMMAND_SERR is a good example: While the guest's view of this
>>>>>> will want to be zero initially, the host having set it to 1 may not
>>>>>> easily be overwritten with 0, or else you'd effectively imply giving
>>>>>> the guest control of the bit.
>>>>> We have already discussed in great detail PCI_COMMAND emulation [1].
>>>>> At the end you wrote [1]:
>>>>> "Well, in order for the whole thing to be security supported it needs to
>>>>> be explained for every bit why it is safe to allow the guest to drive it.
>>>>> Until you mean vPCI to reach that state, leaving TODO notes in the code
>>>>> for anything not investigated may indeed be good enough.
>>>>>
>>>>> Jan"
>>>>>
>>>>> So, this is why I left a TODO in the PCI_COMMAND emulation for now and only
>>>>> care about INTx which is honored with the code in this patch.
>>>> Right. The issue I see is that the description does not have any
>>>> mention of this, but instead talks about simply writing zero.
>>> How do you want that mentioned? Extended commit message or
>>> just a link to the thread [1]?
>> What I'd like you to describe is what the change does without
>> fundamentally implying it'll end up being zero which gets written
>> to the register. Stating as a conclusion that for the time being
>> this means writing zero is certainly fine (and likely helpful if
>> made explicit).
> Xen and/or Dom0 may have put values in PCI_COMMAND which they expect
> to remain unaltered. PCI_COMMAND_SERR bit is a good example: while the
> guest's view of this will want to be zero initially, the host having set
> it to 1 may not easily be overwritten with 0, or else we'd effectively
> imply giving the guest control of the bit. Thus, PCI_COMMAND register needs
> proper emulation in order to honor host's settings.
> 
> There are examples of emulators [1], [2] which already deal with PCI_COMMAND
> register emulation and it seems that at most they care about the only INTX
> bit (besides IO/memory enable and bus muster which are write through).
> It could be because in order to properly emulate the PCI_COMMAND register
> we need to know about the whole PCI topology, e.g. if any setting in device's
> command register is aligned with the upstream port etc.
> This makes me think that because of this complexity others just ignore that.
> Neither I think this can be easily done in Xen case.
> 
> According to "PCI LOCAL BUS SPECIFICATION, REV. 3.0", section "6.2.2
> Device Control" says that the reset state of the command register is
> typically 0, so reset the command register when assigning a PCI device
> to a guest t all 0's and for now only make sure INTx bit is set according
> to if MSI/MSI-X enabled.

"... is typically 0, so when assigning a PCI device reset the guest view of
 the command register to all 0's. For now our emulation only makes sure INTx
 is set according to host requirements, i.e. depending on MSI/MSI-X enabled
 state."

Maybe? (Obviously a fresh device given to a guest will have MSI/MSI-X 
disabled, so I'm not sure that aspect really needs mentioning.)

But: What's still missing here then is the separation of guest and host
views. When we set INTx behind the guest's back, it shouldn't observe the
bit set. Or is this meant to be another (big) TODO?

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 07 14:33:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 14:33:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267055.460759 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH54u-0006bs-3N; Mon, 07 Feb 2022 14:33:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267055.460759; Mon, 07 Feb 2022 14:33:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH54u-0006bl-04; Mon, 07 Feb 2022 14:33:16 +0000
Received: by outflank-mailman (input) for mailman id 267055;
 Mon, 07 Feb 2022 14:33:14 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=owYM=SW=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nH54s-0006bb-MQ
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 14:33:14 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e16f2046-8822-11ec-8eb8-a37418f5ba1a;
 Mon, 07 Feb 2022 15:33:13 +0100 (CET)
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2058.outbound.protection.outlook.com [104.47.2.58]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-32-3do6KZoyO_iZvs6YG_3pUA-1; Mon, 07 Feb 2022 15:33:12 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5648.eurprd04.prod.outlook.com (2603:10a6:803:e5::30)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Mon, 7 Feb
 2022 14:33:10 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.018; Mon, 7 Feb 2022
 14:33:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e16f2046-8822-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644244393;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=uO3NTQVCSYkQL3zC3b2F2lPWwxQRU60We7U6kBLyBL8=;
	b=KE2RI69GllVQNk8ZZhgo4wq8JR39nPg9xnyIbM60KSuPTbmx1+GftszAl9FOorWvL4mvGG
	WcH3qFNCJjtZrvROA7mCSvz4XA8jFTBJcWwU5FUW3oHEkyqKfTkTAPU1r9beVO8eV15oCj
	6UR4sXDHd+IAWbc7bCpA/9FBd+ok114=
X-MC-Unique: 3do6KZoyO_iZvs6YG_3pUA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jTGvfyaJM9sp9WhhCxRXVWvg/hYYX5teT4Jq298o2EyLcnFwxMY5vacIeJAOAFrMkOHTImZ31LZWjoGqC7mLQ4/YWDcbeWeE1cz/AMENvFCy38ttNV07k/2Qv29jhgzr1RB6usC1biR7vxNtpjwWvT4NSFY0pTzXzqWxXBxd52C4OIRt4d8l3zDZNBrXoV80/7dCfit8qEKKcfeGhuhhIVUhaUWnousLQu1FcYb7QG/nquYsC4ZE6ccHI7H5p/CtPjgrQRUf/QEoE429Kc1fM97IzgUWH0NlfcNSv+BYeM87E8qgPhtDfOr8x4iUqOZxQa3OZMjI494qOU57VLE+hQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=rnu4bU5tZdendMLAVNuz7lgls4DjjMkja3Rjnbkr7YM=;
 b=bkU5VwuIFnvprkQZHr9mz0+Pb9VKqAYH/JTMNIhkpI0dZj2Bg2qEn3K35NX3fV759f5yz5f8g9fYWKOh6rd7y1z9ckMf4oWfNi5m/AQJlWGTMaLITEw6ajNEFfTcuGGP7s1cDHPRPACoAzx/oKCGZA5ljH0RCk0QMTQm5qgLn9UjoBx8eYDZ2/Oaq0qlwoYp8DuUXC6tUO2162DU/KVLDANAhtk46YYh2iSOaj5jABktxmCk7QU5OCxl6XnUQOM+/Pj2JjAG98MgnuMR4s1HFhlQ6VrnsmXnuXo9eo1dqBJpn6KkpRh1/rV7WGi/gG2suL4Cberw6pjnuKz3egHhpw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <c9ef8453-cd58-37a3-b290-578a015e301f@suse.com>
Date: Mon, 7 Feb 2022 15:33:08 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>,
 "julien@xen.org" <julien@xen.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Artem Mygaiev <Artem_Mygaiev@epam.com>,
 "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
 "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
 "paul@xen.org" <paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <7e3562b5-fc67-f213-e872-f211450d9e2e@epam.com>
 <a8fc599c-f620-c4d1-2077-c57068f46a7f@suse.com>
 <deef8468-d607-e49e-f456-6a8013329ca1@epam.com>
 <Yf0k6aoKK5G3iad1@Air-de-Roger>
 <3ad10a99-c706-b95f-1419-2c0c7cf37d58@epam.com>
 <Yf0+3C9nF8+tewLw@Air-de-Roger>
 <c5fea3bb-834b-eeb7-d7a1-1ee609037a9f@epam.com>
 <YgEUwTxhnWVMGMJK@Air-de-Roger>
 <9ce90193-74a0-5642-d22b-6b8c3340c3cf@epam.com>
 <1f65ae7a-898d-2c27-0ada-d71d778b0627@suse.com>
 <YgEsRuckQJIQlkzf@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YgEsRuckQJIQlkzf@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM7PR02CA0019.eurprd02.prod.outlook.com
 (2603:10a6:20b:100::29) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9f96e3d5-8bfc-4160-0167-08d9ea46c3bb
X-MS-TrafficTypeDiagnostic: VI1PR04MB5648:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB564821133602A1C0C09B27B2B32C9@VI1PR04MB5648.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	p3D7roFiRHDwiI0sikpSoimnEKViRmf/zJnoJUym6sxyF/Oos60uVt+5haPHnUQyUaDnfAm/0K0ox+IlwgOhmq6YJqwLbR5+4jzHQtxGZQyqDtqbSFCZRcaekFFqX+euvg/owwqfGkhHkyD0BLRkD6+3RTpjH539K3eXdhxecTcqCZ2w78soFPzOdcrxdcDw/5iplW5GlRZ7th+Cmilm+zn0+seaUAFYeTcKu2yJUgC6Vi859zrtT8gJysN7mQ/XDfmAnoGMjKXMuPAzxo7ieRvbPZymlTbQ/UttHNkC1HsFHucNzYrzWNQBkYsPL5O//iYOQUfesAKD0g6KHVR28MLlyt1iOtF2uWseTS9DZciwes10DpEwfMG+5PLXX1UsCitBC9/xTkqLVNotqp3Xr7O9f2IM2iQc12leObZ8T2eNVy4OTSgVQu019NzXt/UZ062XyUzFSvTUo08apr7ixY27W2RHpm+wZwQEUp+5UAH0bjeHmGaR9vJetHUlFRma8WS4+pt8E01ZswXSih/cG12qv35EFCCHUTKbiiGLxQO4wSOAKib6gGa1DLFxIQHK+Serhq7WzOmVRbAw9C+XinhRO7Qus/lx4DZvOfqNIG7nDbH65jDp54gd7wK4DrllmEAzy94MFWaj/OgwdWwJ+3yQ/eDeTYIP9x3ISYy/ZhwNizJExFSaQmjhPa2OATb9RPCqnhXHia9cjJDJhHOQlcIb3NYVXR1PLD8PH1/HWdk=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8676002)(83380400001)(53546011)(6512007)(36756003)(31686004)(8936002)(66946007)(26005)(6506007)(508600001)(186003)(66476007)(66556008)(38100700002)(4326008)(54906003)(7416002)(2616005)(2906002)(316002)(6486002)(6916009)(31696002)(5660300002)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?KSU0jCfnDpMZN8AMzSeFGO9ASDW7vz4OofT19SyhIxDYtVg2GlexiKinkVW5?=
 =?us-ascii?Q?byK6j1I2//snndx7bF0Xl5l934N935EP+hdxz3YFCsmKSRJdYRqLOMF0FH23?=
 =?us-ascii?Q?3Gk8ayYVj0h2/17mzwd8f5+zK+UF9PRf6DIXyC7QEcfLLz9htSZ+V4U+nBou?=
 =?us-ascii?Q?eFY4XQXkpBhNggdK+2V8gFIc3AfHO46f6Tju0KKZCQKQPXX/tWh+ZjhjRxZr?=
 =?us-ascii?Q?sfpJpZKSzbxrm9oEjTA1Kmdlh+NlqA3Bhz5jneBijwoGd1Nt7AFtqQ0E6DGv?=
 =?us-ascii?Q?cy5wCcZY+EA3n3FPOy1FHWk21+d+AfWC+yEvgOdhR2vgTIkg2OuYRCW3GhLU?=
 =?us-ascii?Q?OkFmFlAC9DNbxgF8ehV4QfC2f0NUF+G16mHxSmVbyHH2UUTnIuGdiKLWn2NT?=
 =?us-ascii?Q?0WllXu8XUlt7dk20IHZ29izIRSvHzKn5BL2VSMf3FZL6m559uxdOLOqfWe6Y?=
 =?us-ascii?Q?JNBGW/N8vN2TEeZQ5NL3aEm7BFzVrkZdhXgNfRXcnVCoXfVdSjbdBoPYTdN0?=
 =?us-ascii?Q?gqgyD4ZoJbt7fLhmI+HNnQfTp0jSGcQhGjDVjYLQLu9xHh9xEC3NVgWfBt4v?=
 =?us-ascii?Q?jkviTm1Xx6NytsUHOl2+MZGAhUfRV2Kza+GfLCPPPx77ix/4WCuy2+iNMF5g?=
 =?us-ascii?Q?Kg6+7723EbgYJ1PWitjevCk7aa7gIU2FxxKeqESsMVNIq53GwhV1FuVU96iy?=
 =?us-ascii?Q?itrkNe1AGPdVAdEKqUooyTn/AQq3WQSqGKNvxjkXTdtdGRSi7mCl5fKOFwOe?=
 =?us-ascii?Q?zB/4E1wdjf2DpPoSVINSnLzlSruQB5WP8gyYCu/2N6vkrgvXCoHYyCwsOM6U?=
 =?us-ascii?Q?+Kii4J8vPd4zWR2xVvkb2G+3T6m0ZRD/tMZ/i8xrTqfmDLiE/QyqAxV/hGeV?=
 =?us-ascii?Q?J3OZjDWqnNw8ooSeGVcGE5L5/uBiqwpm4118/PBeFwQntHNazklDmZ2+z8cr?=
 =?us-ascii?Q?hhsg/QRyYNGo7xHZHIZLTyL84yI2Yi4hf7N9W2Og7ALqGbePPCuiuSArtBzD?=
 =?us-ascii?Q?P3Bjge8FO18Cy8qNNu0r4Vm6BOdp04jNzEHzOfrqJwBBqV+/+1Gjdi/gBalV?=
 =?us-ascii?Q?zJhn0huN8r6qYuUMjCLvoiIBjeum88BybzZv6+SKE74n3QIK0EVOOgm2mpa7?=
 =?us-ascii?Q?R54Q/Aq5OhTJYrFXxxT0msp1fknPS3+/CfXLJdbr6YIpTz3eKXm2CkuS87uY?=
 =?us-ascii?Q?g01hKo+sQPrp4iwKj/vV97ik8eEs+GIG534N/aPnG4TGvnnQPlvKgWnLvGp7?=
 =?us-ascii?Q?lIAJwr8XSPy3e5ZcXZvva2hoQIlYUo/dCqJ6pzEx0DPlI5JWhYWePh1VOiBw?=
 =?us-ascii?Q?D4J3j7oAbefJPXZeWwJCTg0SsgiXSyBMM/zTbbe3BpX6WWARgh8RPlpqmwOK?=
 =?us-ascii?Q?7Tjt7ahtM2vA08vO6w3Xc6oNPy1dD3G14GPm81bGexKUBLDcFcoYfYZ9fPxe?=
 =?us-ascii?Q?I/KAe6ParL2upqQWBsSyb3HCN2Bc6cyegWAZi4WZ4I345gDzFeSOeUahsb5j?=
 =?us-ascii?Q?R72Q6dIKvVHWtW+HKBUZSH+wsBTrvdN+AvJtjD9gpJG7+SUWW3d98qkRWotE?=
 =?us-ascii?Q?xbfRnXvp27cNuDVX/5UlfmPL5aK2vue/WJMI2QFO2ugCW6lnbAP2bA4J58CH?=
 =?us-ascii?Q?5q19cLrHvmWC5EAnMDvgydY=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9f96e3d5-8bfc-4160-0167-08d9ea46c3bb
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2022 14:33:10.3465
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RJhfg+F6wue+AS7YdyInnz/qJS/lWQeCtW0PCNreGuB8sf6egr453cAUhh3V3kjIHHMN2YCCeOBiffJssu/GSQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5648

On 07.02.2022 15:27, Roger Pau Monn=C3=A9 wrote:
> On Mon, Feb 07, 2022 at 03:11:03PM +0100, Jan Beulich wrote:
>> On 07.02.2022 14:53, Oleksandr Andrushchenko wrote:
>>> On 07.02.22 14:46, Roger Pau Monn=C3=A9 wrote:
>>>> I think the per-domain rwlock seems like a good option. I would do
>>>> that as a pre-patch.
>>> It is. But it seems it won't solve the thing we started this adventure =
for:
>>>
>>> With per-domain read lock and still ABBA in modify_bars (hope the below
>>> is correctly seen with a monospace font):
>>>
>>> cpu0: vpci_write-> d->RLock -> pdev1->lock ->=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 rom_write -> modify_bars: tmp=
 (pdev2) ->lock
>>> cpu1:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 vpci_write-> d->RLock p=
dev2->lock -> cmd_write -> modify_bars: tmp (pdev1) ->lock
>>>
>>> There is no API to upgrade read lock to write lock in modify_bars which=
 could help,
>>> so in both cases vpci_write should take write lock.
>>
>> Hmm, yes, I think you're right: It's not modify_bars() itself which need=
s
>> to acquire the write lock, but its (perhaps indirect) caller. Effectivel=
y
>> vpci_write() would need to take the write lock if the range written
>> overlaps the BARs or the command register.
>=20
> I'm confused. If we use a per-domain rwlock approach there would be no
> need to lock tmp again in modify_bars, because we should hold the
> rwlock in write mode, so there's no ABBA?
>=20
> We will have however to drop the per domain read and vpci locks and
> pick the per-domain lock in write mode.

Well, yes, with intermediate dropping of the lock acquiring in write mode
can be done in modify_bars(). I'm not convinced (yet) that such intermediat=
e
dropping is actually going to be okay.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 07 14:35:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 14:35:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267067.460770 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH56l-0007HV-Ih; Mon, 07 Feb 2022 14:35:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267067.460770; Mon, 07 Feb 2022 14:35:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH56l-0007HO-FT; Mon, 07 Feb 2022 14:35:11 +0000
Received: by outflank-mailman (input) for mailman id 267067;
 Mon, 07 Feb 2022 14:35:10 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=F54n=SW=epam.com=prvs=403792ff6c=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nH56k-0007HI-RC
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 14:35:10 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 25ea9a9f-8823-11ec-8eb8-a37418f5ba1a;
 Mon, 07 Feb 2022 15:35:09 +0100 (CET)
Received: from pps.filterd (m0174679.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 217EEgf3023712;
 Mon, 7 Feb 2022 14:35:05 GMT
Received: from eur05-am6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2104.outbound.protection.outlook.com [104.47.18.104])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e350ur3cq-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Mon, 07 Feb 2022 14:35:05 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM6PR03MB3815.eurprd03.prod.outlook.com (2603:10a6:20b:1a::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Mon, 7 Feb
 2022 14:35:02 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77%3]) with mapi id 15.20.4951.018; Mon, 7 Feb 2022
 14:35:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 25ea9a9f-8823-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=A1SN0MQZIZr0om6V/g9lCvzQ0iXCW0uNtgmNHj7JAoasq+XzuYWYMSx0pqIBYMfc8x0A5tOmATxf+lkFAOZTjydWpycCYR4oipDIV9ZjeeWOEmabN8cGCdM71kg4ODdE4jg4sxwgoLI2gar+X6TK7d83Zp4s//72VwOz1NJq4kKaCPIJquJech0EphCFdvD9bvXilMblGDAve1byuluQ0oOaUFAzi+kok26iPGAMxcAFOGpXsmvj8FCI3dta3ti65ONoOu0bfDEkxeS1SbQ6b+f21kbDi6yGbug/R269eIh+QHfNv9N+qARakJoPQJZaEj7hmVjWx1q6Xw6plNaBWQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=GRojDeEmDv4UlyC6iOri4DoNWhCV9lp6lLLGdRBtIvo=;
 b=bBNMWmiSrKIDUSMSBCZK2Zy25kvXijROeuNIHReR05/cYuwzyRWlP1I/fXEfvESpHsqESmOz12H1v2HrNTO8rkEiiBouohfBvwBFWxm47Ay/JWpCm3MXaqn3BtTynVvKoTnbRGEHHCXiARK8qviBqYF6zdN8gNWGz2YxAqyzIfPSFvMk8fK0e2ncqfwRC159K1Md6DazIAePZXEAlbgWw5u3l9mtLMZpAfVs50WPTuPbS3+ALtMP77E8zJy08bwAJ7E1jRVSVeZByM3UFyP4kbH4h9pyf+nAKz6Cj3CIkUYs31/Yjo7Rlw23vtTalbM/xzv3iTmsvIo8jpBUWipG9A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=GRojDeEmDv4UlyC6iOri4DoNWhCV9lp6lLLGdRBtIvo=;
 b=EZJRJ2EoMDpryQYSJo9CKSH1D+ZfAQC8DCk8jJPbLGehH9Vqo7uYyiQjd28gzj2kAAqWRrWysbxcyE39ABPO2jH8q3Be+j4dKSn3qgSyVuU51fxR9GKox0txX62wIptUJjUhuDTsvxwje3jnFuVmVzw9mEzfXQaMF8Yg7AJIjCZl6Gzsy4+i4lJvSQp1/oPjANm7JQIvXHixbG4pdd8UWbI0oHJCz2Cuecb9JtJLPCDKgR+tII21SWgaUIPi9Jnui8SQqlWj9hqz1/3VUe+eTvoC/1tcQLgH5CiYOcejhDtb1nSLfLm/nmpaXy03VxlHIe8dCeVqew0ELJTMv4BtYg==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>,
        Jan Beulich
	<jbeulich@suse.com>
CC: "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Thread-Topic: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Thread-Index: 
 AQHYGZFc/MnzQOjwVEeBBUHLSW0md6yDBUkAgAASSACAAATYAIAAD/WAgAAKNgCAAAbfgIAABnuAgAAQvgCAAAMCAIAAAY4AgAADxICAABrnAIAABAgAgAR3CoCAABt5gIAAEpuAgAAE5ICAAASKAIAAAiiA
Date: Mon, 7 Feb 2022 14:35:02 +0000
Message-ID: <a2a42c1d-d379-00cd-5d55-f443cdb02e97@epam.com>
References: <7e3562b5-fc67-f213-e872-f211450d9e2e@epam.com>
 <a8fc599c-f620-c4d1-2077-c57068f46a7f@suse.com>
 <deef8468-d607-e49e-f456-6a8013329ca1@epam.com>
 <Yf0k6aoKK5G3iad1@Air-de-Roger>
 <3ad10a99-c706-b95f-1419-2c0c7cf37d58@epam.com>
 <Yf0+3C9nF8+tewLw@Air-de-Roger>
 <c5fea3bb-834b-eeb7-d7a1-1ee609037a9f@epam.com>
 <YgEUwTxhnWVMGMJK@Air-de-Roger>
 <9ce90193-74a0-5642-d22b-6b8c3340c3cf@epam.com>
 <1f65ae7a-898d-2c27-0ada-d71d778b0627@suse.com>
 <YgEsRuckQJIQlkzf@Air-de-Roger>
In-Reply-To: <YgEsRuckQJIQlkzf@Air-de-Roger>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 1b94cee1-0fb5-4edd-2b16-08d9ea470676
x-ms-traffictypediagnostic: AM6PR03MB3815:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM6PR03MB38152BD22386AEC0413E461EE72C9@AM6PR03MB3815.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 fJ1IKr54q0IovgOnZ2OVGhWR1G9OruFAzegkLLD2rxARz6IBfSFgUUn9nus5k848WsGavOhO6oFfkeJw+XsGanCZtfp4EkZgl1UYlDIkkiQQUdqvjoB2dkSjgWHLmA/Wo/yQAdYR4fkDJMfyKcpTJbqSQSuj6VEpRZzp+4dS6QyD7OsQRPARMcvRo48ZCdwYR/WogNzIXfy1kJtKVueHRo1jLIw558uz3CAxbIYP9fIyRMrJAKbd4DQwm2tdcw4n0XKUQIso7IH6FfFTYmUhkM9bg1v100Oanxjepn6xnGi74zg09Abj/Y7SW+8Wa8SX+5+d36Go/uQiFvJ42KyYGBJzFzLQ1+F7KZPvZPqnJtyLftp4qUBcFB8lW0C1FFtXi0lc4jcQsvk8VNyJLlM/NxHdDLvodx7QTgv8W4wISVAk7zwQaWJk88AQtG+uOJiO4a+fXGUD4OKHgEfmr1GCmjlTAOWWB+XesD8QefkqxGxkVrBlWvJvkRi17Nqty+0tESqZx14RmoSto/qru7EnL40HRr2QChi5v0HWiDyKU1pBNhxjdNaFnYvYOhYDG+Opv9YeHKMXqYvbvi14Rq+gjsN905t60ScxEy57dHM8rh99JjP3Q0FQPG1G/87vrgCxLEkqlk4xc7ZffxQ7i7vQcGkYMpYLyukZ1M2qtBFox4i95aQzuAwV9t4uNZ4Y/YDzATm/1cjcdzk3uWBB0Yjxs6xNo5q5EjnEKlOEC6+3pwk=
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(122000001)(31696002)(5660300002)(508600001)(186003)(55236004)(6486002)(7416002)(54906003)(110136005)(107886003)(6506007)(36756003)(2616005)(26005)(316002)(53546011)(31686004)(38100700002)(6512007)(8936002)(71200400001)(64756008)(66946007)(66446008)(66476007)(66556008)(76116006)(4326008)(8676002)(38070700005)(86362001)(91956017)(2906002)(83380400001)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?dlpHRFlzSTlZVnpuMHM1eUNYWHZhU3RWT2Y2elRrc0ZLNVZxSWUweUJoTnFZ?=
 =?utf-8?B?VjIxd3JOV2xjSmRYZktCYm9DcXBvc21PUE9KU0d2THF2Sy9BUjNOb0pVazY3?=
 =?utf-8?B?YktjUi9iMGtWVm1zSDkwaHJVNUdvZ1pqejRTTE16R0pLRjJqMDlsL09jcVZM?=
 =?utf-8?B?Q1ZQUFVQWEp4R3hxaVpHQ214Z1hFeTZwdzcyMFllTUk3aExGYytPZmZQTnp4?=
 =?utf-8?B?NW5WT1R3QzBVWFNrSFVsZGZ2ZHJFQm1GdnFoV1dQRkpQdGgxem9UbTdQZUxm?=
 =?utf-8?B?WjZUd0Y0dUpRQlpkcWdYZDFVaUlpUUNOQ0dSV205UjB3b0lQOUxpbFlVcTBa?=
 =?utf-8?B?UXBtU1lyYlQ5cFFqSTRrbGd3QTlsK1U4S0NjblBtOWVTak9iejQ3OVZ4dVVD?=
 =?utf-8?B?ZnBiTW5pQWFXL01samFtNkZqQzdvNENKSjllM0s4cE12SWtEanRQQmhaNUc3?=
 =?utf-8?B?V2hIY1l6ek5LWDRYUE4wV2l3S09LOXVvNXN1WHR0V1lzNHExN3paZXpsczRQ?=
 =?utf-8?B?c05ZWU1GS1RMbkYrOEV1OEFGbEo2SVF5VFFBT2NobE9IKzlnY283cmFFRktn?=
 =?utf-8?B?bER6WmgxSHpZMmp1azBINnNybk94RnlrblJsZ09tVGp3aTJzM0Q0SDUvZ3V2?=
 =?utf-8?B?WUxrVEpjNk1BM3RBcXNCRUJFZHBUdU9QY0VMWDZwUWxDS1N1bjg3djNPZWEr?=
 =?utf-8?B?cXowRVhhWXBYaDA3R2RJSjJjWWtuZEJPMklBNFAwaUVXSm9OTlBPREJXOVQz?=
 =?utf-8?B?cCt0eEdaZ2kyMENpa3loS2pkelYwUGVvaG42b2FrNE84MVd4T05iazh6WDI3?=
 =?utf-8?B?WVlReXlHUGdRNTY1WmFLRmZ4elc0NnVVUko1MElwY2M0TnlLeERBYzFlVVJn?=
 =?utf-8?B?ZlZkTnFDVHF4YUFRZjRkcjQyYStlQUtrVzlXSldkeEJYeC9JcWlmWG5QZEU4?=
 =?utf-8?B?dUZpbTNmTnFPUk0yNmNxRFNvNkFqOW1jTXQ5VlVwUFB3VW1scUJxdUZUU2Fo?=
 =?utf-8?B?dTVzU2Y4WGM5Q1VFR09EWnVqZ3RyZ3BnUm51UDJzalBuS0c0YlZ2bTdBTkN6?=
 =?utf-8?B?dmtVRGplM2dXNlZLcUVZeXllU3hTRFJIVXB2aXJiU3AxZUpkZ2dWTHhPRUxu?=
 =?utf-8?B?bmZPK0pmZDBYRUVvRFZnaC9vV2pMdHBCajB4SjZjeFI3TENRQ2M5cjBSRTU1?=
 =?utf-8?B?aGhFcHdPS28rSmdCRVRueFBHeGhtdk8wSHJVRXhocXF5dGlvaUV2S2pJeDNI?=
 =?utf-8?B?bmVYVWtSSndWUFdhRGZRYXhyM0lZUkFaaFZHVzFHTkNDMENoQk9GOXlsL3VG?=
 =?utf-8?B?b2NudEFZdXR4a1YvQXpSemU0bVFid09nbk9hUEg3T0lReHhDcjk5ODJlak02?=
 =?utf-8?B?by9SWjZYbnZlUHdpckZ0MUVHUDhyUEc1TE1hcmdnM3U0VHRnRVZyQnhhYk14?=
 =?utf-8?B?ZnNsQUQwa2RLSGwrMHZJZS9ydlBROWcvSUZjdGpVY2ltTHg1eFBQVFNsVURR?=
 =?utf-8?B?Yml4NFA2STBDQ2t5SnRkMDM1c05NR2s0STBGYnRscFNvWTNMOHE3R3l4cEl0?=
 =?utf-8?B?U3RBMnI2dGtoVjYxUEc2NEF2YnJiSkRVQjAzZXFKM2xaSHZGR0N0cDJVd3ZR?=
 =?utf-8?B?djJQQWZ6aW5wMTN6V3ZFT1V3VHlOZzRCSGF0ZmFjcm8zMWlXSXFzcXh2V0o0?=
 =?utf-8?B?cGVHQUhjcUZoWHpTcnBTZWlOMmlLTXp5L2dZMDJqN1VwWW16ME9YemMveHhQ?=
 =?utf-8?B?QXpSaldoaFNLUHdGcmtlOW5ZYkVCMlVmWEpBRVZWOVBHbHJ2dVAyWS9GaGty?=
 =?utf-8?B?b3dkcG1ncXVEODBNdk45cHZrUU1EMTlGUmNhb2MxYThNMVNobHZOb2F0bmhv?=
 =?utf-8?B?K1ZwU0drYWtXN256TEl4bmp0ZklGNC85WlpYT2FNQUR2REpDWDcrMXpTNFNE?=
 =?utf-8?B?Smh3MHZldEZCRklFUjhnVUhjdTdIbkdyZ01naWJnWExmV3M1Z09jQnNJS2Fx?=
 =?utf-8?B?YWVXRjZlYU96aTc4c0N6TjZxMEkySUpuVVZFb1dLa0tvdHVFTFVvZDl4Szhr?=
 =?utf-8?B?RVZsb0xJRmg3dDF6a29DcU5PeHNtbmtyM29VVm9uWndycEdkeVRIRmxzMnVD?=
 =?utf-8?B?NFNZblhkcUIxZDVUMzBSWjZQTDNsbmRIM2dNMW4vVnlNZ1ArSlNhSHhaUjBy?=
 =?utf-8?B?OVlnY2w5YjUzUllQZVR0dENiOGFXeU5yempnYjVIUFArc3dwV1k5QU1TYWxN?=
 =?utf-8?B?NmJNQ0tTR0NjY0hXL0JJOHNFb1FBU1IrZDNCblZBQWp2YVBUc3owSzRxd1FH?=
 =?utf-8?B?bHh1Z2xPZ1ZnRkNxUW9XbkhiR3pOLyt6NUFBZmJ2UW1XZ2xBNURmZz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <4D6C8A1A12735B4E84F4B8799B8BAC84@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1b94cee1-0fb5-4edd-2b16-08d9ea470676
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Feb 2022 14:35:02.0058
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 0sCuGEK8Cjnc0tahrLGpCio3M9Ox4AA4zHYibnk5eNsJPEDO9HBawM4AYre7Go3rD84/cn22/r4aua1kza0ResSNtycOWO+CuFsg7JsCULqyixiXmUmQmi4v/Q4ojFF3
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR03MB3815
X-Proofpoint-GUID: q7owqDPmlrZe65JmuYCGcQHagohK-EGy
X-Proofpoint-ORIG-GUID: q7owqDPmlrZe65JmuYCGcQHagohK-EGy
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-07_05,2022-02-07_02,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1015
 impostorscore=0 phishscore=0 mlxscore=0 spamscore=0 priorityscore=1501
 lowpriorityscore=0 mlxlogscore=543 bulkscore=0 malwarescore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202070093

DQoNCk9uIDA3LjAyLjIyIDE2OjI3LCBSb2dlciBQYXUgTW9ubsOpIHdyb3RlOg0KPiBPbiBNb24s
IEZlYiAwNywgMjAyMiBhdCAwMzoxMTowM1BNICswMTAwLCBKYW4gQmV1bGljaCB3cm90ZToNCj4+
IE9uIDA3LjAyLjIwMjIgMTQ6NTMsIE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4+
IE9uIDA3LjAyLjIyIDE0OjQ2LCBSb2dlciBQYXUgTW9ubsOpIHdyb3RlOg0KPj4+PiBJIHRoaW5r
IHRoZSBwZXItZG9tYWluIHJ3bG9jayBzZWVtcyBsaWtlIGEgZ29vZCBvcHRpb24uIEkgd291bGQg
ZG8NCj4+Pj4gdGhhdCBhcyBhIHByZS1wYXRjaC4NCj4+PiBJdCBpcy4gQnV0IGl0IHNlZW1zIGl0
IHdvbid0IHNvbHZlIHRoZSB0aGluZyB3ZSBzdGFydGVkIHRoaXMgYWR2ZW50dXJlIGZvcjoNCj4+
Pg0KPj4+IFdpdGggcGVyLWRvbWFpbiByZWFkIGxvY2sgYW5kIHN0aWxsIEFCQkEgaW4gbW9kaWZ5
X2JhcnMgKGhvcGUgdGhlIGJlbG93DQo+Pj4gaXMgY29ycmVjdGx5IHNlZW4gd2l0aCBhIG1vbm9z
cGFjZSBmb250KToNCj4+Pg0KPj4+IGNwdTA6IHZwY2lfd3JpdGUtPiBkLT5STG9jayAtPiBwZGV2
MS0+bG9jayAtPsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHJvbV93
cml0ZSAtPiBtb2RpZnlfYmFyczogdG1wIChwZGV2MikgLT5sb2NrDQo+Pj4gY3B1MTrCoMKgwqDC
oMKgwqDCoCB2cGNpX3dyaXRlLT4gZC0+UkxvY2sgcGRldjItPmxvY2sgLT4gY21kX3dyaXRlIC0+
IG1vZGlmeV9iYXJzOiB0bXAgKHBkZXYxKSAtPmxvY2sNCj4+Pg0KPj4+IFRoZXJlIGlzIG5vIEFQ
SSB0byB1cGdyYWRlIHJlYWQgbG9jayB0byB3cml0ZSBsb2NrIGluIG1vZGlmeV9iYXJzIHdoaWNo
IGNvdWxkIGhlbHAsDQo+Pj4gc28gaW4gYm90aCBjYXNlcyB2cGNpX3dyaXRlIHNob3VsZCB0YWtl
IHdyaXRlIGxvY2suDQo+PiBIbW0sIHllcywgSSB0aGluayB5b3UncmUgcmlnaHQ6IEl0J3Mgbm90
IG1vZGlmeV9iYXJzKCkgaXRzZWxmIHdoaWNoIG5lZWRzDQo+PiB0byBhY3F1aXJlIHRoZSB3cml0
ZSBsb2NrLCBidXQgaXRzIChwZXJoYXBzIGluZGlyZWN0KSBjYWxsZXIuIEVmZmVjdGl2ZWx5DQo+
PiB2cGNpX3dyaXRlKCkgd291bGQgbmVlZCB0byB0YWtlIHRoZSB3cml0ZSBsb2NrIGlmIHRoZSBy
YW5nZSB3cml0dGVuDQo+PiBvdmVybGFwcyB0aGUgQkFScyBvciB0aGUgY29tbWFuZCByZWdpc3Rl
ci4NCj4gSSdtIGNvbmZ1c2VkLiBJZiB3ZSB1c2UgYSBwZXItZG9tYWluIHJ3bG9jayBhcHByb2Fj
aCB0aGVyZSB3b3VsZCBiZSBubw0KPiBuZWVkIHRvIGxvY2sgdG1wIGFnYWluIGluIG1vZGlmeV9i
YXJzLCBiZWNhdXNlIHdlIHNob3VsZCBob2xkIHRoZQ0KPiByd2xvY2sgaW4gd3JpdGUgbW9kZSwg
c28gdGhlcmUncyBubyBBQkJBPw0KdGhpcyBpcyBvbmx5IHBvc3NpYmxlIHdpdGggd2hhdCB5b3Ug
d3JvdGUgYmVsb3c6DQo+DQo+IFdlIHdpbGwgaGF2ZSBob3dldmVyIHRvIGRyb3AgdGhlIHBlciBk
b21haW4gcmVhZCBhbmQgdnBjaSBsb2NrcyBhbmQNCj4gcGljayB0aGUgcGVyLWRvbWFpbiBsb2Nr
IGluIHdyaXRlIG1vZGUuDQpJIHRoaW5rIHRoaXMgaXMgZ29pbmcgdG8gYmUgdW5yZWxpYWJsZS4g
V2UgbmVlZCBhIHJlbGlhYmxlIHdheSB0bw0KdXBncmFkZSByZWFkIGxvY2sgdG8gd3JpdGUgbG9j
ay4NClRoZW4sIHdlIGNhbiBkcm9wIHBkZXYtPnZwY2lfbG9jayBhdCBhbGwsIGJlY2F1c2Ugd2Ug
YXJlIGFsd2F5cw0KcHJvdGVjdGVkIHdpdGggZC0+cndsb2NrIGFuZCB0aG9zZSB3aG8gd2FudCB0
byBmcmVlIHBkZXYtPnZwY2kNCndpbGwgdXNlIHdyaXRlIGxvY2suDQoNClNvLCBwZXItZG9tYWlu
IHJ3bG9jayB3aXRoIHdyaXRlIHVwZ3JhZGUgaW1wbGVtZW50ZWQgbWludXMgcGRldi0+dnBjaQ0K
c2hvdWxkIGRvIHRoZSB0cmljaw0KPiBUaGFua3MsIFJvZ2VyLg0KVGhhbmsgeW91LA0KT2xla3Nh
bmRy


From xen-devel-bounces@lists.xenproject.org Mon Feb 07 14:45:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 14:45:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267077.460781 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH5Gp-0000K9-IJ; Mon, 07 Feb 2022 14:45:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267077.460781; Mon, 07 Feb 2022 14:45:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH5Gp-0000Jy-Ek; Mon, 07 Feb 2022 14:45:35 +0000
Received: by outflank-mailman (input) for mailman id 267077;
 Mon, 07 Feb 2022 14:45:33 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=wO/0=SW=citrix.com=George.Dunlap@srs-se1.protection.inumbo.net>)
 id 1nH5Gn-0000Js-Tp
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 14:45:33 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 98e59eea-8824-11ec-8eb8-a37418f5ba1a;
 Mon, 07 Feb 2022 15:45:32 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 98e59eea-8824-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644245132;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=/pugh4+jctYEopv1WC2RGw/SQ6WGIWa3Xn5kDAHyWjc=;
  b=ZqsQIOlUi/FZ/548TQ0RUqI9rF+I2EM2rBOTQRtxnsKyCSrsFJoDhTTO
   NsIZx+qaUOFFnjBcucSRgmYKNEY96utPXjJmeUdF8MyhQIUU5cdsZM1qh
   P6dR0DzUf9YWvKtjBzMtj5rO5pY3wTxr3qJU4v1/I89WN/lkB5e/VIjLj
   U=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: ha34woI5ICOzLwqm43c++QiipTZ20Mn/Ka2t9Slbr7ZGkQndwe+c9S5R0NEeqcq7pZog1jGl9C
 JwRt0aJ48I9lBefUKu0mkUQ6MLJwKZiwySn+qxpVydEL2lqmC01c0cyrooZhBGKpopKizJaTD+
 RRFaIEufeA5V1/OP7zUdppbp2F1SKGPQcp+FfWa6YUKq1BtseJVr6D8e1Gyi2hxLyeTXCKKCH+
 USFcrX6LX105mM6FSqUQ8tbUyUy/TaRHqZnkLyv63Sjl+jBKJ1aE7B3nttT+RaAr9PPCHe72Aa
 mXCBF+6LAQmj3IMmMw2OHtgI
X-SBRS: 5.1
X-MesageID: 63651125
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:d/vyD6mTTnH9RlklpfZ6hsvo5gxfIURdPkR7XQ2eYbSJt1+Wr1Gzt
 xIXXD+EOqneYTDzcot0aoTlph4E6MfUz9FhSQc/+CBjRCMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BClVlxJVF/fngqoDUUYYoAQgsA180IMsdoUg7wbRh2NY32YLR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 I9c66PtaBk1B6fnm886dQZoLRsuO6ITrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBObmO5kQtzdM0DfdBO4OSpHfWaTao9Rf2V/cg+gQRqiDP
 pNDNFKDajzfUyVPY2cbA64Oo8eDhlnHMANfskiK8P9fD2/7k1UqjemF3MDuUsOObdVYmACfv
 G2u13T0BFQWOcKSzRKB82mwnanfkCXjQoUQGbaksPlwjzW7xGYeFRkXXluTuuSihwi1XNc3F
 qAP0nNw9+5orhXtF4SjGU3jyJKZgvICc4BBTdJnyR+R86D/4C2+IHc0cAQRbtNz4afaWgcW/
 lOOmtroAxlmv7uUVW+R+9+okN+iBcQGBTRcPHFZFGPp9/Gm+dhu1UyXEr6PBYbo1oWdJN3m/
 9ydQMHSbZ03hNVD6ai09Euvb9mE9smQFV5dCuk6swuYAuJFiGyNOtbABbvzt68owGOlor6p5
 ilspiRmxLpSZaxhbQTUKAn3IJmn5uyeLBrXikN1Ep8q+lyFoiD/IdkBuWggdR0waa7onAMFh
 2eJ6GtsCGJ7ZiP2PcebnartYyjV8UQQPYu8Da2FBja/SpNwaBWG7ElTib24hAjQfLwXufhnY
 /+zKJ/0ZV5DUPgP5GfmFo81jO5wrghjlDy7bc6glXyPj+HBDEN5vJ9YaTNimMhit/jayOgUm
 v4CX/a3J+J3CrGnMnKJoNJMcTjn7xETXPjLliCeTcbaSiJOE2A9Ef7Bh7Qnfo1uhaNOkenUu
 Hq6XydlJJDX3BUr8C2GNSJubq3BR5F6oS5pNCAgJw/wiXMifZyu/OEUcJ5uJesr8+lqzPhVS
 fgZeprfXqQTG2qfozlNP4PgqIFCdQiwgV7cNSSSfzViLYVrQBbE+4G4c1K3pjUOFCe+qeA3v
 6akilHAWZMGSgk7VJTWZfujwkmfp38YnO4uDULELsMKIBfn8ZRwKjy3hfgyepleJRLGzzqc9
 gCXHRZH+rWd/95rqIHE3PnWoZ2oHu1yGlthM1PatbvmZzPH+meDwJNbVLradz7qS26pqr6pY
 v9Yzq+gPaRfzkpKqYd1D51i0bk6u4n0v7ZfwwlpQCfLYlCsBu8yK3WKx5AS5KhEx7sfsgqqQ
 EOfvNJdPOzRas/iFVcQIisjb/iCiq5IymWDs6xtLRWo/jJz8ZqGTV5WbkuFhyFqJbdoNJ8on
 LU6s8kM5g3j0hcnP75qVMyPG7hg+pDYb5gaiw==
IronPort-HdrOrdr: A9a23:iujnbq0HEEf4rkIviDVUCgqjBEgkLtp133Aq2lEZdPU0SKGlfg
 6V/MjztCWE7Ar5PUtLpTnuAsa9qB/nm6KdgrNhWItKPjOW21dARbsKheffKlXbcBEWndQtt5
 uIHZIeNDXxZ2IK8PoT4mODYqodKA/sytHWuQ/cpU0dMz2Dc8tbnmBE4p7wKDwMeOFBb6BJcq
 a01458iBeLX28YVci/DmltZZm4mzWa/KiWGCLvHnQcmXGzsQ8=
X-IronPort-AV: E=Sophos;i="5.88,350,1635220800"; 
   d="scan'208";a="63651125"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=kFRjAIN4x2ovsvrwkmnVIs0DmFRQtB3Fj0wNb2JsmpceC4R0rin2InsCP+OPRWuRkcKlcjhXsw3ZvgD8h0xlsgUne/Z/cGgftKlUzmKVFCbMlJbwpWadYFSvOyWjpwdNrS/C06CEvtEQgCgJs6cfZyOjNRyPSqNyP8eKniSuVqF5wGEQfGlK0wWe5hsVXes2SVTWexS6PEhHjUK3nIwu0VdhGKxU/7zfnUS9xETrsTvWcV8hJ1qX/TGQq6almuU5gF+ndHO2cYyyxMqMrw55PxvSQFQto6a3HsIuaxoz6KyfZC0uhiL66PpBvupPtxEA3hOJszQk0GBIpN3RUByNlg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=/pugh4+jctYEopv1WC2RGw/SQ6WGIWa3Xn5kDAHyWjc=;
 b=faQ9/4DEXMKQgSrTPAs8dVzZ8DfxtO5nPSomlBHzgXO2G/nZ40wFXjNefTfQ3+y0/tDJovb/zJ9hsL9wJzh7s6d12iStFwFBIL5K7K6VhR6axDcw8y281q7eGuoPx5uKel2Uq3azqEo1w9h2M9EQAAAN0WfZZoYgwnjc/QNgE8DYDtCSE4NZ6iFuo2yl6P2r9Etxa8k7cmhbfC7/+QOUaJRckIFT9BYoJZ8opNMAiUBLyc1vR4+V8+7zcSaYDl4gVz2vGl0lKNOYBOWbFT+M+H86JPU5I9rs5Pg0cyUPzs9xFkyOj1OvOA2TByGAOW33JS9Dz8eR2YlxV2YIfnbsmg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=/pugh4+jctYEopv1WC2RGw/SQ6WGIWa3Xn5kDAHyWjc=;
 b=rSPnuOpeWhSJFudfUw4SUbzdU/NwT79xpa08XIBP21RHqPG792k76TGweBw/whmQWKhB3/mZljSWsWP5Ncq8CnpD2to5Me9jwvTZfmbDfXahJNGIAJngN1espbFrnQ5frAVCRQ9s+HFr9lP+lCJjdykjQZ+LlvcpGIXiSq+2dNQ=
From: George Dunlap <George.Dunlap@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Andrew
 Cooper" <Andrew.Cooper3@citrix.com>, Wei Liu <wl@xen.org>, Roger Pau Monne
	<roger.pau@citrix.com>
Subject: Re: [PATCH 08/16] x86/P2M: PoD, altp2m, and nested-p2m are HVM-only
Thread-Topic: [PATCH 08/16] x86/P2M: PoD, altp2m, and nested-p2m are HVM-only
Thread-Index: AQHXcbg9+9E9Zp3QUEWtGX2TK6aCNayGy30AgAJnLwCAAEyRgA==
Date: Mon, 7 Feb 2022 14:45:27 +0000
Message-ID: <E8945018-F8D5-4930-8E5B-ACBCB039BC2F@citrix.com>
References: <d1fd572d-5bfe-21d8-3b50-d9b0646ce2f0@suse.com>
 <694a6590-0018-223a-c796-3e1469ec354a@suse.com>
 <0C051DFA-9147-42DB-AA36-0DED3D192F43@citrix.com>
 <ccc16e12-2036-d71b-5521-71685f0ab38d@suse.com>
In-Reply-To: <ccc16e12-2036-d71b-5521-71685f0ab38d@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3693.60.0.1.1)
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: ab99897e-d2b9-4f04-21d0-08d9ea487b2e
x-ms-traffictypediagnostic: BLAPR03MB5556:EE_
x-microsoft-antispam-prvs: <BLAPR03MB555671D5DEBE73F5D219F9BD992C9@BLAPR03MB5556.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:397;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: vHzmYmqQC6WezcMOeEOKqtHtSMiaMrmLos46TOAeUhy9I6I9xziCR8nw3vEZuxfBNXKznycIKeTb4dGF0h9p5H+4ImOi0Q7yRfpk912kvsEc0tfvXXnmAiaVZjxd1BqmUG6xxKPPw/N2rU1LP/fHyOBxkOhp0sjloIHc6wxAVK2qDxhp230DH61aKePPDxG4HA+s92JDsO+E91I/7b8s89Ja9MRJYBifuQkGxCKa9SVdLvJDbg8gYhXPn+lCskT7HkQn+Lhk4mRkFJyyECGkPcZV4y8k73NhqlbV+vLNCKKoxs9/AZRcbT54wU+B9bkkUqy728lpr/PPRWrox03i18B1UdZo+G8wpwyQnw1f0ohIGhWg/H/lhB7ha4pI4qc3vW8lANzYL5Wlp3W/I6Nli3J9fUEruwXcHrhe3p/jYKNi3sIzYm9i25l5LjwX3XDCKHw0eEdB448Z5jbgDpP/itTgq81SaLuOhdY0E72bqKqwsauJIsOXxUZOR+7HsbKVmDDEVHSrFRuoGTzjjzshkRnVYjN4Ip1Gdzzq1jfjrfQ68l6OnUE0zBZGVy8xeRKeJcSc20P5hV8imO64MEbz/jD27gdZtoNzFjLF1Lh1huZSRrG6WqeoEcYqDJYl2+JIqHjsMoxuzBQOzSI2u0x3tv6VRyCJedErkyG9IYgDGWuOUvBqieGOKsG7PyDNA6Qr4rf8o97PaJk+gHivZ7cuJBWTem5pZNEJ5nKU9XSOTaOtTtkPTJCUbIbYR+RW6yXh
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38100700002)(122000001)(66446008)(6506007)(2906002)(64756008)(66556008)(66476007)(5660300002)(8676002)(83380400001)(8936002)(4326008)(38070700005)(36756003)(107886003)(66946007)(91956017)(6486002)(6916009)(186003)(2616005)(316002)(26005)(86362001)(82960400001)(54906003)(53546011)(508600001)(33656002)(71200400001)(76116006)(6512007)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?aWJUY05IWnhRaVFkaGJCWmNqck55LzNNeWk4T01GMWpaTXhlREVISHVKSFZO?=
 =?utf-8?B?ZnVkL2dTT3lkVjV5c3hUVjdGa3VuUUlIVjVsTjVVR3UwUVNKTEg4SzYrU0JL?=
 =?utf-8?B?NkRpRC9DK3ZtemxnR0N2dWhJYUNkMnUweldYT1YyZER4WHdMd2h4VUQyQTlV?=
 =?utf-8?B?aXFSanRocS95ak0zamR0dVRHeEsyS04zV1paTGtoeWxNZGIxZC9ycEJMdHgw?=
 =?utf-8?B?RTN6SWVneURBeDNVQ0h5aFdxUlJGVWhPRHhFd0lNNU4zekFBaXVWMWd1aU0v?=
 =?utf-8?B?OWZlSnZLdTRBTnFGR2RDVFFRVEluMmNDK0NUZlRUcDFpbSsxcWVZS2FHbTZq?=
 =?utf-8?B?enhRdTdHR0tmbzBNRXNNVkRXa0pRMFJyckhoaWhGOWcyN2F2UEJxWi9lcm14?=
 =?utf-8?B?MHBRNXMweDFBeFVrNUNUMTdEQStTMDNwTnRXNDlDaERqbW5sTXg1cUkxU3g4?=
 =?utf-8?B?RnVCS0tKVlRHQ2NEeVJTbkpKVzVPZkdHR3RyWXI5L0QrZUFrbS9acjJhZnJa?=
 =?utf-8?B?cm40TmVnR3ZEM09PSmF1TTdaNDJyN3NnVXpJVjY5ZDVaTXhYNGltTVFLYUVx?=
 =?utf-8?B?dm00Tkk4RExoaVpodW9VVXdadzJwSjBJQjBHSVVSa1dMMzFBNWN0ak01Um5Y?=
 =?utf-8?B?d3Z4bXRvd2V3M1QyUzcvcTJNNkVwcEpxeVlkcjdjdVBlc1FsL29xc1Nvd2RG?=
 =?utf-8?B?SFFlM1hRZVFMT09JUlJyRDRlT2dTWE9Dd3dybHBJMFU4R1VlOXBYRzk3MCtw?=
 =?utf-8?B?MU16Y2VtU0lPZ2RLMXZCUWNCWDBnbTRUSzIzb3VuYXY0a0x5R1hCVWsybkJW?=
 =?utf-8?B?WHE3RHRGY3R4cmY3bUMySm04OEMyL0d3YkxvUFh2VWZ5bmhXV1FaM3dHc3gx?=
 =?utf-8?B?MkpReXVUQjBqWDhZazdYVVFtU3p0b1NFa2dwamtkL3JCcVR1bEovSFBkZ1Zj?=
 =?utf-8?B?WmwvWXFTNHFzY3FYa0xlNWt6dVJ3eTZVNk1aeHdjMG9oWUZCWUNyYmVmL0ZU?=
 =?utf-8?B?TGVBRHJHb2hNTHBkMEppVjRwVHBJRXZrTHBQb1ZTVVUyU1JuMDhwLzl5c1hi?=
 =?utf-8?B?Qk1VMHRUbXRrbE4rNjZoNjA4Vk85Y0xZc1JNN2I3WkFSRXV6ZGVSZUZiSFY5?=
 =?utf-8?B?OU1YTUc0WEpsWnN6Vkp4Z0ZUVnAvcDJKeUFMMmZ1LzdNdEdXaWVUMUtRMjZJ?=
 =?utf-8?B?TTVnRkxOMFA0MFJnMWRqWml4VU90Q2NjcWJXbGxETy9HbVlWWXBIT1BhZ3g4?=
 =?utf-8?B?WXZQZ2JoaUVwQzJLMkNXTlh1M291UEZoc2I5R290VUxQdG1hQXFyZjE4U1ZK?=
 =?utf-8?B?ZkZxcytJNHc1NXBmc2Zrc0FEL01qMUxxbHNuVk9JVEZxanMxMGl6b0M2a3RB?=
 =?utf-8?B?OVI4L2tnc1pCNlQzNEJrRmhvd0tETXVBdEExb1luUml6bFJmb2duUEk4TWpo?=
 =?utf-8?B?UUVsU3Urc3lHemRuSU0vRXJ5bno1Rkt5UUFYSHRYVS9LQ1ZvaURIanZ6QUdk?=
 =?utf-8?B?NTlEYTFadFdqaC9CeXR6L2FXT3RJdmJpcm5RNWJJRzdRQlpZRE1PZ1BhRUc2?=
 =?utf-8?B?UkoxN1AvM0RxaXVIL3pJdG5MR3h4L2c3V0hlSThMMUNsSlhFaGNtNm4zUGZ3?=
 =?utf-8?B?c0FueGhxWWIwZ0hDeTdZaUdTM0luekJOa2hWbmlCRUkzL2tvOWRmc0lnYWYy?=
 =?utf-8?B?THdGYzI5aDdMNTlPcjdPaFJSNERwWEJFd0pKclVPUnRHeENTbTAzckc4ZmpM?=
 =?utf-8?B?WjE3THlpM3E1Q0xXdFI0b3U2VG92Kzh0STI4dHQ4T05MSGxhcjEyL2FJMDJQ?=
 =?utf-8?B?V0FEdjNka2JQdEdRWDZCNGQ2bHRVZktPSlFrcmlUeEFSVzhEM1pGanBHR2VR?=
 =?utf-8?B?WHlHdkdkdU0ycDM4WTVjNCtSenowb0wyWUdIMTMvckFpYlRDcGtldWtGb3ZV?=
 =?utf-8?B?UkJ6cjc2WFIzTDJGYXFKZkFkWWUyWTBRZm9wZDg3QUNLdTdlbVlabUMyY256?=
 =?utf-8?B?NkNvd1U2TXNwYmdINzhzcUs2NWdTRTZKME05eUJrTktNbnJ0dWZxcDdESklG?=
 =?utf-8?B?SC9QajFUYTJuMXkydzRCWlBlcUpJT2JZemhsQTFVL0FReGFQOWkwcVNteUtP?=
 =?utf-8?B?dWZwUTg4SG9tdVJWaEFQUExKaVIzSW1POUFLK1NCa2JQKytBV0VYZUwxaFl5?=
 =?utf-8?B?YjlQelVqendtcjMyVmFjNnB6SzJYQVQzSzBrTmU0R2dCSDhVZ3pBekJyNVZX?=
 =?utf-8?Q?oan9+oyjAyn+wwX379AI0ESh+8WoZHF1RYnP+yq6L4=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <2BA7D49C6F0ADA4B9A1963E645D33D06@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ab99897e-d2b9-4f04-21d0-08d9ea487b2e
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Feb 2022 14:45:27.3708
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 1nr9SrGs+TJbP1sN+avKpl9y+YWm31M3xv7iTneIZ0K9MByBEguRwXorkSUMXANmcGucHrKdKCDObov+ZDC16DJz4qJw2neKFabVU0h0G80=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR03MB5556
X-OriginatorOrg: citrix.com

DQoNCj4gT24gRmViIDcsIDIwMjIsIGF0IDEwOjExIEFNLCBKYW4gQmV1bGljaCA8amJldWxpY2hA
c3VzZS5jb20+IHdyb3RlOg0KPiANCj4gT24gMDUuMDIuMjAyMiAyMjoyOSwgR2VvcmdlIER1bmxh
cCB3cm90ZToNCj4+PiBPbiBKdWwgNSwgMjAyMSwgYXQgNTowOSBQTSwgSmFuIEJldWxpY2ggPEpC
ZXVsaWNoQHN1c2UuY29tPiB3cm90ZToNCj4+PiAtLS0gYS94ZW4vYXJjaC94ODYvbW0vcDJtLXBv
ZC5jDQo+Pj4gKysrIGIveGVuL2FyY2gveDg2L21tL3AybS1wb2QuYw0KPj4+IEBAIC0xMTM1LDYg
KzExMzUsMTIgQEAgcDJtX3BvZF9kZW1hbmRfcG9wdWxhdGUoc3RydWN0IHAybV9kb21haQ0KPj4+
ICAgIG1mbl90IG1mbjsNCj4+PiAgICB1bnNpZ25lZCBsb25nIGk7DQo+Pj4gDQo+Pj4gKyAgICBp
ZiAoICFwMm1faXNfaG9zdHAybShwMm0pICkNCj4+PiArICAgIHsNCj4+PiArICAgICAgICBBU1NF
UlRfVU5SRUFDSEFCTEUoKTsNCj4+PiArICAgICAgICByZXR1cm4gZmFsc2U7DQo+Pj4gKyAgICB9
DQo+Pj4gKw0KPj4+ICAgIEFTU0VSVChnZm5fbG9ja2VkX2J5X21lKHAybSwgZ2ZuKSk7DQo+Pj4g
ICAgcG9kX2xvY2socDJtKTsNCj4+IA0KPj4gV2h5IHRoaXMgY2hlY2sgcmF0aGVyIHRoYW4gc29t
ZXRoaW5nIHdoaWNoIGV4cGxpY2l0bHkgc2F5cyBIVk0/DQo+IA0KPiBDaGVja2luZyBmb3IganVz
dCBIVk0gaXMgdG9vIGxheCBoZXJlIGltby4gUG9EIG9wZXJhdGlvbnMgc2hvdWxkDQo+IG5ldmVy
IGJlIGludm9rZWQgZm9yIGFsdGVybmF0aXZlIG9yIG5lc3RlZCBwMm1zOyBzZWUgdGhlIHZhcmlv
dXMNCj4gdXNlcyBvZiBwMm1fZ2V0X2hvc3RwMm0oKSBpbiBwMm0tcG9kLmMuDQoNClRoZSBmYWN0
IHJlbWFpbnMgdGhhdCBpdCBkb2VzbuKAmXQgbWF0Y2ggd2hhdCB0aGUgcGF0Y2ggZGVzY3JpcHRp
b25zIHNheXMsIGFuZCB5b3XigJlyZSBtYWtpbmcgbWUsIHRoZSByZXZpZXdlciwgZ3Vlc3Mgd2h5
IHlvdSBjaGFuZ2VkIGl0IOKAlCBhbG9uZyB3aXRoIGFueW9uZSBlbHNlIGNvbWluZyBiYWNrIHRv
IHRyeSB0byBmaWd1cmUgb3V0IHdoeSB0aGUgY29kZSB3YXMgdGhpcyB3YXkuDQoNCklmIHlvdSB3
YW50IG1lIHRvIGFwcHJvdmUgb2YgdGhlIGRlY2lzaW9uIHRvIG1ha2UgdGhlIGNoZWNrIG1vcmUg
c3RyaWN0IHRoYW4gc2ltcGx5IEhWTSwgdGhlbiB5b3UgbmVlZCB0byBtYWtlIGl0IGNsZWFyIHdo
eSB5b3XigJlyZSBkb2luZyBpdC4gIEFkZGluZyBhIHNlbnRlbmNlIGluIHRoZSBjb21taXQgbWVz
c2FnZSBzaG91bGQgYmUgZmluZS4NCg0KIC1HZW9yZ2U=


From xen-devel-bounces@lists.xenproject.org Mon Feb 07 14:46:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 14:46:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267083.460792 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH5HV-0000pQ-SH; Mon, 07 Feb 2022 14:46:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267083.460792; Mon, 07 Feb 2022 14:46:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH5HV-0000pJ-Ol; Mon, 07 Feb 2022 14:46:17 +0000
Received: by outflank-mailman (input) for mailman id 267083;
 Mon, 07 Feb 2022 14:46:16 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=F54n=SW=epam.com=prvs=403792ff6c=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nH5HT-0000eB-QT
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 14:46:16 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b28ac2fe-8824-11ec-8f75-fffcc8bd4f1a;
 Mon, 07 Feb 2022 15:46:14 +0100 (CET)
Received: from pps.filterd (m0174681.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 217EctJR012284;
 Mon, 7 Feb 2022 14:46:09 GMT
Received: from eur04-vi1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2059.outbound.protection.outlook.com [104.47.14.59])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3e35c781ad-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Mon, 07 Feb 2022 14:46:09 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM0PR03MB5937.eurprd03.prod.outlook.com (2603:10a6:208:165::26)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Mon, 7 Feb
 2022 14:46:05 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77%3]) with mapi id 15.20.4951.018; Mon, 7 Feb 2022
 14:46:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b28ac2fe-8824-11ec-8f75-fffcc8bd4f1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=UM8VymYne46Br8804nQtNPSMXIvmt3+J8YAvyWp6jIvmuqtkHn4ElJElKRMV/M19jbkNN1mcw2Wc4V6GVGIpuF5jXLetLv5ZzS461Ky/stbOr5l8xxBDXG9I355ohiL0B+9jqvna5wj9IlZ9YMt8Hj0VwdNE/3vmQ3V9709LnJAj7W03D7YFrgOVCHG2mQlul2RipJN7+5mmSyfKftsx6enEK6RrLGJItGXB8C1SbxSw6tX6cvlYR8/5SsmnaLKX6VHb3IOH44OyKCTnbDA01iS61edfy3MggWnRlbF6O/ZaFWJ7sPJbX4TGMfUiQbVzmzFMyMwR1ffSb1rXSjxjhg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=8cI7EtVoLc7NMaLqwoj262WZ2K+x4EFdMuX2iEHjjzw=;
 b=CTeWXlQ1r8Om6Qqcl/BZcbfigC00SxvJgevXdo502VFN2ncUTzLjOebQF8YntWr8ftfwZm8Dn8yKhehMvIPFizbzdPDhr8wusbOgPiipx68Z3b+MOsOUkoGH+NJt4MsH+B4vIygRojoLnRk5KCPSmMGqUzi8b+F8DZECWOlQKWPLBTnPrDs6kyGCPAMEauBxIUED5VZ6FblsEUWy6DFB0oTDcKk3esyKJXUuqcBYwddrTfxnQLfQ3c1WsOyQV3fXRDjnl8p7NIot9ni7L8FkAFdymrhUjx7cHjutVMuR7Uamdd1stX6oH1OD/IQ9XL5ZeOF7y3RDVOEAnAdOeq2kvg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=8cI7EtVoLc7NMaLqwoj262WZ2K+x4EFdMuX2iEHjjzw=;
 b=lnRVKMljf8Cle1HW/zAJ7VwQAUDokRi/d7kDjq+40nlrSrqqUVw2Dio/ZSKKp9ugoxMrjZuU3cb2IzlKCLEtzqkPa7wfBbDdoPiSxA4gehkViREllIvbwf+vdPNe+h92R6FaEhIPP75h+VV5xlbMzfAG/spYpycCvTLver8YYujqcPSKpuqJRQlIGUxvfXOXa/o8eHRUw5+QKFWf4F8Wk5xBPHhWpCtr1SACeysqWWLudSdvB4+9l+Y4RfNEqPBktlPYevQ17/75PubOjea2ucyVqcSLRe/yobIbR9tfCL5jDvjIvBmBYOm+k2QYnnZv0PagLOtC3NABN0wJlLNyfw==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "roger.pau@citrix.com" <roger.pau@citrix.com>,
        "andrew.cooper3@citrix.com"
	<andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com"
	<george.dunlap@citrix.com>,
        "paul@xen.org" <paul@xen.org>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>,
        Rahul Singh <rahul.singh@arm.com>,
        "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v6 10/13] vpci/header: reset the command register when
 adding devices
Thread-Topic: [PATCH v6 10/13] vpci/header: reset the command register when
 adding devices
Thread-Index: 
 AQHYGZFg3nazYSvfA0G+yHTbxcxX2ayDdFgAgAAB6wCABD+NgIAAQmgAgAAT4YCAAAOjAIAAAPCAgAAXGICAAAPHAIAABC8A
Date: Mon, 7 Feb 2022 14:46:05 +0000
Message-ID: <6b4ea90d-cc9c-edf7-e579-a84d72431d7a@epam.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-11-andr2000@gmail.com>
 <96381d7e-dafc-acee-3abf-f9815deb207c@suse.com>
 <ef76faac-f9d3-1cb8-06b5-189ccd299542@epam.com>
 <6f0a015b-c48f-76ed-9a51-39c045ff5927@suse.com>
 <2ad372d4-a181-9307-ef50-a5adb61dae66@epam.com>
 <49380584-0577-96f2-ef1c-a96eabf0d227@suse.com>
 <fbd410d1-84ad-2309-ca05-b9ac7f95f1f9@epam.com>
 <dbef1c95-818c-427c-1963-75d584843cff@suse.com>
 <f34cc940-7f5f-aebd-60d9-d1a3d85d1283@epam.com>
 <8f35e7c5-3193-4b10-ae25-df838e2262c7@suse.com>
In-Reply-To: <8f35e7c5-3193-4b10-ae25-df838e2262c7@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 1633ce61-3491-4440-26bc-08d9ea4891af
x-ms-traffictypediagnostic: AM0PR03MB5937:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM0PR03MB5937B65955CB52AEB692704AE72C9@AM0PR03MB5937.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:7691;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 9XQ3pYRRDTawHliea1zqo7Hvv2SgSH9uVXUngtRKfW0n0HJ+wRs/CQBG6UiLtszfWxe/LhESNhXefahIkjL4dUqh7eG3GzfmncGPDknBDZ9zcK3EvTD/noxrACeiLuwk6LJbTBTHPuRfPsq06buB1az/S1ZjKxJ7W2tzTKlE6KIlJp7+gCdXj3DFbnJ5tVM+z/qkwWVAxBAL+k86ndru+3hQCHwwYo6ZNP1PQl+XH6MX7EPBgj3/lrgcbc5JUc//MwSvfvRisNU8vpKSVXWV/cKoGAfv7im+KwDTNi2o/3B9gJ8dvd7XZynmHl9/EIBtHhrucZV01Plu0+ii+h8botVhnr2P63W1jxSfpjv/SSBziaC5AJVD/EdMIbTdoLUcI4HgKLEhKQKJS3SnXMStBoQaH1BS9Yuv8bOznDHXZvBIOBf3Dn+EtrP8mZsN4Rl5hK43ZFpYTTwZlqmMEKoq1Y9PhC5i/1Q3vWNN6ymoTcUrfb9oTeaCvA8rBH3aqEl2+fp8Z12Sm26zmKQP760QHvNHCEg+nWuw6yPM5N4IHnsbT7r97dCXoW9+DyPBkNm9y8dDFxeFRGA7XoTDyOXS9OyEj4934li17nPhKvP+BbAeje/1gq+vTMiCbaJImDysxa2Xj8CTOz2GEGYDfx19K/SDsGjaNgBpYrt40r5jJA9SJUlVWfx1CnqxY6Optcn1Chie8ZEDa3F8yT2h9SkE/fR378TA6FrwBvM3lxGMeY+t/nUAfXMevtr4NtiABjBC
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(2906002)(2616005)(31686004)(86362001)(6486002)(26005)(186003)(38100700002)(7416002)(6512007)(508600001)(31696002)(5660300002)(71200400001)(66556008)(55236004)(36756003)(53546011)(316002)(54906003)(6916009)(91956017)(66446008)(66946007)(8676002)(64756008)(76116006)(4326008)(8936002)(66476007)(38070700005)(122000001)(83380400001)(6506007)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?K1BQT3N4aENyTDNCY2RPajI0UGh0a0VtMFRicDVSNERreHdrZnBkT1dzTW92?=
 =?utf-8?B?TEJ1Q0lzZjA5aEQwWk5yR2s4aFUrOWEwYVhpbGdDREV3YVh4eG8ralJzYXho?=
 =?utf-8?B?OUtJdzZhV2pDTjlkVGVWMHdHUS95MXVRQVRqdG9QeHpvRWwwU0NnRUlIajBV?=
 =?utf-8?B?YWRxTGdqVGRIT3UwZVZiTWVjZ2IvNVdUME1qYTkvWVBRN0hiNzc0UjJyRzlE?=
 =?utf-8?B?cG9YY0dib2s3WWZ3WWx5OTNMRkJpMHhOZys3MHo1d1dYdU5pUzBVaXRnY1lW?=
 =?utf-8?B?ZVUxY0RLTmtRZjR6d1NyUHovdTl3bEtiVUJ5ZjZTbzJuZjVwNzQrMlplalMw?=
 =?utf-8?B?NFBDc1FHTGNadFl2UzBLbmtCTmdPTTBnUTdCQ0ZsbnBvMXdDSWxVSkFFaVk0?=
 =?utf-8?B?b05aK3dKQXMvV1FvWFBPb3o0WkJPb3JxK1VWUEpDZjdJRTdiZ0ltZS9icjhM?=
 =?utf-8?B?T294cmtheEJDS2VESHNIL0RvOWlKMXRwM3BKaFBsUDRKVkduNW1iWFU1cWlz?=
 =?utf-8?B?bHh3Q0FOQWZvbjJPR2R0dVhsVlZXNlUyQW1zRVVCWHZIdEt6aXhuL1NVczE2?=
 =?utf-8?B?R3pOclZmandaK3hJZ29reDRkU1luYnZyTDNqNjgrRDVtYXdITHZ5MFRZS2Z0?=
 =?utf-8?B?d1ZZZWtUTUI2R0JVakRKMHJZOXMyVEh6d1l2cWNkMHpaejJweWZUTW5ZVWVp?=
 =?utf-8?B?dllocVcxK2U1bXNHODZOTnhWWjkwMHBvZm04emY3MlBRbE93bDQvaFB4bk1s?=
 =?utf-8?B?UU1zOVh4U0VZR3I0dzVKU2tIZVprcWRuSnM2TEVhcVp3TTZkaHpIL2g2V1JE?=
 =?utf-8?B?TU04dXhxSjd3ZzRoYjlEYTlGWElYelpDc3UvcTY2TGx1aUlyMGRUZjhwZHBN?=
 =?utf-8?B?UU1BSkNuQlpKU0ZlWTluVzZyS2JmNHl6Ykd1eCtkMllRY2xMTHZKK0NybWZl?=
 =?utf-8?B?WlluQ0F3anAzZmdJUHNaRWVpWW9XRk5jSE5Uait3dHFLSFdHb214U0NBRk05?=
 =?utf-8?B?V0xQSHVGWVZWYjl0WTdmQUNpelJXREJ3bjVtQUZiZVBzR0ZhZjE1NU56MUM4?=
 =?utf-8?B?dmExNmhvUkhYZlJoQ0NJeHYzSnlFZ2cxcmNzVy9jTGNENFZBQUpXU01HOGtD?=
 =?utf-8?B?NG5KMGh0RTJSZ3JCYjBvNEZMcXFudStiYUluaDNkdmFRYm1oZ3VNRjUzdFRl?=
 =?utf-8?B?OUgwVStWWDJBbEMxK3lYUFI5b3pOMDNmS2NjVmhHeUJMdHlxeU42a25Bcytz?=
 =?utf-8?B?cTQ0c1Q0WUFRN245WlQ1QkJPb2NNZXFTbzB6TVhDSEhEWXZNZkJrWFFkb2l5?=
 =?utf-8?B?TDF5Mm9laW92UWZGaEFUYm15K2ZlSXJzSHl0TFBjY2xrUmpCOE5zV3VZc1pZ?=
 =?utf-8?B?ejd1YUVpR05zK2hLanovbEk0ckRpZDdtSVJmOER4Vyt3UTZxZjJ5bS83M1Bn?=
 =?utf-8?B?UDc1UWprSjE0dmR1dVdrZXFQYkJJeHc4WGdGcGJuU0tPS0VDazBLUmRCbTZ1?=
 =?utf-8?B?Q3Zjc1o1dFpjQXZ4aTgxZzZLMmwxTm9sWHdhdzRDTGpnekdsZkhOQXlZN29I?=
 =?utf-8?B?aVh2azZmUGNINFBSb3R1akxNanEyOEMzWXJzRFVpVUd2c1p6cFFEMHZsNDk5?=
 =?utf-8?B?N1RNeEpQQ1BQWWhIRElSSzY5RW14UlJ5eEVpSjFMS1F3R1NRbVJTTlkrVTgy?=
 =?utf-8?B?YWQrMDJudDZvMWM1U2h4TmFZdFlQS0NoL2JVOUhSQ05sVldGR2dzdUhtdmxX?=
 =?utf-8?B?Q3hZZ3huUDFHbStMYVY0UVFJcWk5M3B5MFp5d2orOW9hVjIvME1adzhpTGJs?=
 =?utf-8?B?amwvWWdGZXFRQmFnZTBKTFpLbFk2RHVKTUN4Z1lyTVZNZmIxUkFMcXRURjRj?=
 =?utf-8?B?QTJSU21oenk4QnMxSUxGZEg3cEtBaE5iYUJTTnc1V2tNeEVQWGFKekg3bDJi?=
 =?utf-8?B?SlBVZk95VUtXaHByblZGMXVWTDl6Skg1ZTFjV1NWNFA2NURjb3kvMHVZSG9E?=
 =?utf-8?B?VCtDQ3lRakhJSUlLclI5UHBzNUVNZHlsWjZoL2lIa1JLQXZCUWFseE0vOUZz?=
 =?utf-8?B?ZjhMZjhKeTFrREFCQVVMYnh0ZEViNStWWXZZQTNrd2RxNG9DWVlpcVQ0Nndu?=
 =?utf-8?B?UTFmTHN0MHEvQ3JRUEg4TG9wVzVVWW5aZGhKczEvY3Q3akJNaFlyYlpyZmdI?=
 =?utf-8?B?Nzc0ZTBGQ3EwYWZNaEpmZzQzUXJnUHRLUUp3VjNEUmtHZTRqdk93dlRuTmNn?=
 =?utf-8?B?RWRHUHMrampOUjNNdldQaEZpNHFUUG1iaFRrSmY5MkYwQTc1YWxuSFJWVVlP?=
 =?utf-8?B?b3lMVnB1b0JmcmVtbTFjbGRGQnV1S3VHY1U3V0VjQm9kVm9mU1pSUT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <37926AC802958B4996B7A893B6D88722@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1633ce61-3491-4440-26bc-08d9ea4891af
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Feb 2022 14:46:05.1418
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: /NEyDnTZk4P4Eizu81BNV0B10sMsIgofOZ5Rt7lvFHWI53mmWL1a8g2RVl694Elo57ggbQP8b8o1TfI4HEFhnBoiuhwvCq/cYin/Eq9HG+bmJznIzo1bZTpcErPAqaQ6
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB5937
X-Proofpoint-GUID: iYJn7jT5lu3nfbJGuNQlUK8YhJxiz00S
X-Proofpoint-ORIG-GUID: iYJn7jT5lu3nfbJGuNQlUK8YhJxiz00S
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-07_05,2022-02-07_02,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501
 impostorscore=0 mlxlogscore=999 lowpriorityscore=0 malwarescore=0
 suspectscore=0 bulkscore=0 adultscore=0 phishscore=0 spamscore=0
 clxscore=1015 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202070094

DQoNCk9uIDA3LjAyLjIyIDE2OjMxLCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMDcuMDIuMjAy
MiAxNToxNywgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+Pg0KPj4gT24gMDcuMDIu
MjIgMTQ6NTQsIEphbiBCZXVsaWNoIHdyb3RlOg0KPj4+IE9uIDA3LjAyLjIwMjIgMTM6NTEsIE9s
ZWtzYW5kciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4+PiBPbiAwNy4wMi4yMiAxNDozOCwgSmFu
IEJldWxpY2ggd3JvdGU6DQo+Pj4+PiBPbiAwNy4wMi4yMDIyIDEyOjI3LCBPbGVrc2FuZHIgQW5k
cnVzaGNoZW5rbyB3cm90ZToNCj4+Pj4+PiBPbiAwNy4wMi4yMiAwOToyOSwgSmFuIEJldWxpY2gg
d3JvdGU6DQo+Pj4+Pj4+IE9uIDA0LjAyLjIwMjIgMTU6MzcsIE9sZWtzYW5kciBBbmRydXNoY2hl
bmtvIHdyb3RlOg0KPj4+Pj4+Pj4gT24gMDQuMDIuMjIgMTY6MzAsIEphbiBCZXVsaWNoIHdyb3Rl
Og0KPj4+Pj4+Pj4+IE9uIDA0LjAyLjIwMjIgMDc6MzQsIE9sZWtzYW5kciBBbmRydXNoY2hlbmtv
IHdyb3RlOg0KPj4+Pj4+Pj4+PiBSZXNldCB0aGUgY29tbWFuZCByZWdpc3RlciB3aGVuIGFzc2ln
bmluZyBhIFBDSSBkZXZpY2UgdG8gYSBndWVzdDoNCj4+Pj4+Pj4+Pj4gYWNjb3JkaW5nIHRvIHRo
ZSBQQ0kgc3BlYyB0aGUgUENJX0NPTU1BTkQgcmVnaXN0ZXIgaXMgdHlwaWNhbGx5IGFsbCAwJ3MN
Cj4+Pj4+Pj4+Pj4gYWZ0ZXIgcmVzZXQuDQo+Pj4+Pj4+Pj4gSXQncyBub3QgZW50aXJlbHkgY2xl
YXIgdG8gbWUgd2hldGhlciBzZXR0aW5nIHRoZSBoYXJkd2FyZSByZWdpc3RlciB0bw0KPj4+Pj4+
Pj4+IHplcm8gaXMgb2theS4gV2hhdCB3YW50cyB0byBiZSB6ZXJvIGlzIHRoZSB2YWx1ZSB0aGUg
Z3Vlc3Qgb2JzZXJ2ZXMNCj4+Pj4+Pj4+PiBpbml0aWFsbHkuDQo+Pj4+Pj4+PiAidGhlIFBDSSBz
cGVjIHNheXMgdGhlIFBDSV9DT01NQU5EIHJlZ2lzdGVyIGlzIHR5cGljYWxseSBhbGwgMCdzIGFm
dGVyIHJlc2V0LiINCj4+Pj4+Pj4+IFdoeSB3b3VsZG4ndCBpdCBiZSBvaz8gV2hhdCBpcyB0aGUg
ZXhhY3QgY29uY2VybiBoZXJlPw0KPj4+Pj4+PiBUaGUgY29uY2VybiBpcyAtIGFzIHZvaWNlZCBp
cyBzaW1pbGFyIHdheXMgYmVmb3JlLCBwZXJoYXBzIGluIG90aGVyDQo+Pj4+Pj4+IGNvbnRleHRz
IC0gdGhhdCB5b3UgbmVlZCB0byBjb25zaWRlciBiaXQtYnktYml0IHdoZXRoZXIgb3ZlcndyaXRp
bmcNCj4+Pj4+Pj4gd2l0aCAwIHdoYXQgaXMgY3VycmVudGx5IHRoZXJlIGlzIG9rYXkuIFhlbiBh
bmQvb3IgRG9tMCBtYXkgaGF2ZSBwdXQNCj4+Pj4+Pj4gdmFsdWVzIHRoZXJlIHdoaWNoIHRoZXkg
ZXhwZWN0IHRvIHJlbWFpbiB1bmFsdGVyZWQuIEkgZ3Vlc3MNCj4+Pj4+Pj4gUENJX0NPTU1BTkRf
U0VSUiBpcyBhIGdvb2QgZXhhbXBsZTogV2hpbGUgdGhlIGd1ZXN0J3MgdmlldyBvZiB0aGlzDQo+
Pj4+Pj4+IHdpbGwgd2FudCB0byBiZSB6ZXJvIGluaXRpYWxseSwgdGhlIGhvc3QgaGF2aW5nIHNl
dCBpdCB0byAxIG1heSBub3QNCj4+Pj4+Pj4gZWFzaWx5IGJlIG92ZXJ3cml0dGVuIHdpdGggMCwg
b3IgZWxzZSB5b3UnZCBlZmZlY3RpdmVseSBpbXBseSBnaXZpbmcNCj4+Pj4+Pj4gdGhlIGd1ZXN0
IGNvbnRyb2wgb2YgdGhlIGJpdC4NCj4+Pj4+PiBXZSBoYXZlIGFscmVhZHkgZGlzY3Vzc2VkIGlu
IGdyZWF0IGRldGFpbCBQQ0lfQ09NTUFORCBlbXVsYXRpb24gWzFdLg0KPj4+Pj4+IEF0IHRoZSBl
bmQgeW91IHdyb3RlIFsxXToNCj4+Pj4+PiAiV2VsbCwgaW4gb3JkZXIgZm9yIHRoZSB3aG9sZSB0
aGluZyB0byBiZSBzZWN1cml0eSBzdXBwb3J0ZWQgaXQgbmVlZHMgdG8NCj4+Pj4+PiBiZSBleHBs
YWluZWQgZm9yIGV2ZXJ5IGJpdCB3aHkgaXQgaXMgc2FmZSB0byBhbGxvdyB0aGUgZ3Vlc3QgdG8g
ZHJpdmUgaXQuDQo+Pj4+Pj4gVW50aWwgeW91IG1lYW4gdlBDSSB0byByZWFjaCB0aGF0IHN0YXRl
LCBsZWF2aW5nIFRPRE8gbm90ZXMgaW4gdGhlIGNvZGUNCj4+Pj4+PiBmb3IgYW55dGhpbmcgbm90
IGludmVzdGlnYXRlZCBtYXkgaW5kZWVkIGJlIGdvb2QgZW5vdWdoLg0KPj4+Pj4+DQo+Pj4+Pj4g
SmFuIg0KPj4+Pj4+DQo+Pj4+Pj4gU28sIHRoaXMgaXMgd2h5IEkgbGVmdCBhIFRPRE8gaW4gdGhl
IFBDSV9DT01NQU5EIGVtdWxhdGlvbiBmb3Igbm93IGFuZCBvbmx5DQo+Pj4+Pj4gY2FyZSBhYm91
dCBJTlR4IHdoaWNoIGlzIGhvbm9yZWQgd2l0aCB0aGUgY29kZSBpbiB0aGlzIHBhdGNoLg0KPj4+
Pj4gUmlnaHQuIFRoZSBpc3N1ZSBJIHNlZSBpcyB0aGF0IHRoZSBkZXNjcmlwdGlvbiBkb2VzIG5v
dCBoYXZlIGFueQ0KPj4+Pj4gbWVudGlvbiBvZiB0aGlzLCBidXQgaW5zdGVhZCB0YWxrcyBhYm91
dCBzaW1wbHkgd3JpdGluZyB6ZXJvLg0KPj4+PiBIb3cgZG8geW91IHdhbnQgdGhhdCBtZW50aW9u
ZWQ/IEV4dGVuZGVkIGNvbW1pdCBtZXNzYWdlIG9yDQo+Pj4+IGp1c3QgYSBsaW5rIHRvIHRoZSB0
aHJlYWQgWzFdPw0KPj4+IFdoYXQgSSdkIGxpa2UgeW91IHRvIGRlc2NyaWJlIGlzIHdoYXQgdGhl
IGNoYW5nZSBkb2VzIHdpdGhvdXQNCj4+PiBmdW5kYW1lbnRhbGx5IGltcGx5aW5nIGl0J2xsIGVu
ZCB1cCBiZWluZyB6ZXJvIHdoaWNoIGdldHMgd3JpdHRlbg0KPj4+IHRvIHRoZSByZWdpc3Rlci4g
U3RhdGluZyBhcyBhIGNvbmNsdXNpb24gdGhhdCBmb3IgdGhlIHRpbWUgYmVpbmcNCj4+PiB0aGlz
IG1lYW5zIHdyaXRpbmcgemVybyBpcyBjZXJ0YWlubHkgZmluZSAoYW5kIGxpa2VseSBoZWxwZnVs
IGlmDQo+Pj4gbWFkZSBleHBsaWNpdCkuDQo+PiBYZW4gYW5kL29yIERvbTAgbWF5IGhhdmUgcHV0
IHZhbHVlcyBpbiBQQ0lfQ09NTUFORCB3aGljaCB0aGV5IGV4cGVjdA0KPj4gdG8gcmVtYWluIHVu
YWx0ZXJlZC4gUENJX0NPTU1BTkRfU0VSUiBiaXQgaXMgYSBnb29kIGV4YW1wbGU6IHdoaWxlIHRo
ZQ0KPj4gZ3Vlc3QncyB2aWV3IG9mIHRoaXMgd2lsbCB3YW50IHRvIGJlIHplcm8gaW5pdGlhbGx5
LCB0aGUgaG9zdCBoYXZpbmcgc2V0DQo+PiBpdCB0byAxIG1heSBub3QgZWFzaWx5IGJlIG92ZXJ3
cml0dGVuIHdpdGggMCwgb3IgZWxzZSB3ZSdkIGVmZmVjdGl2ZWx5DQo+PiBpbXBseSBnaXZpbmcg
dGhlIGd1ZXN0IGNvbnRyb2wgb2YgdGhlIGJpdC4gVGh1cywgUENJX0NPTU1BTkQgcmVnaXN0ZXIg
bmVlZHMNCj4+IHByb3BlciBlbXVsYXRpb24gaW4gb3JkZXIgdG8gaG9ub3IgaG9zdCdzIHNldHRp
bmdzLg0KPj4NCj4+IFRoZXJlIGFyZSBleGFtcGxlcyBvZiBlbXVsYXRvcnMgWzFdLCBbMl0gd2hp
Y2ggYWxyZWFkeSBkZWFsIHdpdGggUENJX0NPTU1BTkQNCj4+IHJlZ2lzdGVyIGVtdWxhdGlvbiBh
bmQgaXQgc2VlbXMgdGhhdCBhdCBtb3N0IHRoZXkgY2FyZSBhYm91dCB0aGUgb25seSBJTlRYDQo+
PiBiaXQgKGJlc2lkZXMgSU8vbWVtb3J5IGVuYWJsZSBhbmQgYnVzIG11c3RlciB3aGljaCBhcmUg
d3JpdGUgdGhyb3VnaCkuDQo+PiBJdCBjb3VsZCBiZSBiZWNhdXNlIGluIG9yZGVyIHRvIHByb3Bl
cmx5IGVtdWxhdGUgdGhlIFBDSV9DT01NQU5EIHJlZ2lzdGVyDQo+PiB3ZSBuZWVkIHRvIGtub3cg
YWJvdXQgdGhlIHdob2xlIFBDSSB0b3BvbG9neSwgZS5nLiBpZiBhbnkgc2V0dGluZyBpbiBkZXZp
Y2Uncw0KPj4gY29tbWFuZCByZWdpc3RlciBpcyBhbGlnbmVkIHdpdGggdGhlIHVwc3RyZWFtIHBv
cnQgZXRjLg0KPj4gVGhpcyBtYWtlcyBtZSB0aGluayB0aGF0IGJlY2F1c2Ugb2YgdGhpcyBjb21w
bGV4aXR5IG90aGVycyBqdXN0IGlnbm9yZSB0aGF0Lg0KPj4gTmVpdGhlciBJIHRoaW5rIHRoaXMg
Y2FuIGJlIGVhc2lseSBkb25lIGluIFhlbiBjYXNlLg0KPj4NCj4+IEFjY29yZGluZyB0byAiUENJ
IExPQ0FMIEJVUyBTUEVDSUZJQ0FUSU9OLCBSRVYuIDMuMCIsIHNlY3Rpb24gIjYuMi4yDQo+PiBE
ZXZpY2UgQ29udHJvbCIgc2F5cyB0aGF0IHRoZSByZXNldCBzdGF0ZSBvZiB0aGUgY29tbWFuZCBy
ZWdpc3RlciBpcw0KPj4gdHlwaWNhbGx5IDAsIHNvIHJlc2V0IHRoZSBjb21tYW5kIHJlZ2lzdGVy
IHdoZW4gYXNzaWduaW5nIGEgUENJIGRldmljZQ0KPj4gdG8gYSBndWVzdCB0IGFsbCAwJ3MgYW5k
IGZvciBub3cgb25seSBtYWtlIHN1cmUgSU5UeCBiaXQgaXMgc2V0IGFjY29yZGluZw0KPj4gdG8g
aWYgTVNJL01TSS1YIGVuYWJsZWQuDQo+ICIuLi4gaXMgdHlwaWNhbGx5IDAsIHNvIHdoZW4gYXNz
aWduaW5nIGEgUENJIGRldmljZSByZXNldCB0aGUgZ3Vlc3QgdmlldyBvZg0KPiAgIHRoZSBjb21t
YW5kIHJlZ2lzdGVyIHRvIGFsbCAwJ3MuIEZvciBub3cgb3VyIGVtdWxhdGlvbiBvbmx5IG1ha2Vz
IHN1cmUgSU5UeA0KPiAgIGlzIHNldCBhY2NvcmRpbmcgdG8gaG9zdCByZXF1aXJlbWVudHMsIGku
ZS4gZGVwZW5kaW5nIG9uIE1TSS9NU0ktWCBlbmFibGVkDQo+ICAgc3RhdGUuIg0KVGhpcyBzb3Vu
ZHMgZ29vZCwgSSB3aWxsIHVzZSBpdC4gVGhhbmsgeW91DQo+DQo+IE1heWJlPyAoT2J2aW91c2x5
IGEgZnJlc2ggZGV2aWNlIGdpdmVuIHRvIGEgZ3Vlc3Qgd2lsbCBoYXZlIE1TSS9NU0ktWA0KPiBk
aXNhYmxlZCwgc28gSSdtIG5vdCBzdXJlIHRoYXQgYXNwZWN0IHJlYWxseSBuZWVkcyBtZW50aW9u
aW5nLikNCj4NCj4gQnV0OiBXaGF0J3Mgc3RpbGwgbWlzc2luZyBoZXJlIHRoZW4gaXMgdGhlIHNl
cGFyYXRpb24gb2YgZ3Vlc3QgYW5kIGhvc3QNCj4gdmlld3MuIFdoZW4gd2Ugc2V0IElOVHggYmVo
aW5kIHRoZSBndWVzdCdzIGJhY2ssIGl0IHNob3VsZG4ndCBvYnNlcnZlIHRoZQ0KPiBiaXQgc2V0
LiBPciBpcyB0aGlzIG1lYW50IHRvIGJlIGFub3RoZXIgKGJpZykgVE9ETz8NCkJ1dCwgcGF0Y2gg
W1BBVENIIHY2IDA5LzEzXSB2cGNpL2hlYWRlcjogZW11bGF0ZSBQQ0lfQ09NTUFORCByZWdpc3Rl
ciBmb3IgZ3Vlc3RzDQphbHJlYWR5IHRha2VzIGNhcmUgb2YgaXQsIEkgbWVhbiB0aGF0IGl0IHdp
bGwgc2V0L3Jlc2V0IElOVHggZm9yIHRoZSBndWVzdA0KYWNjb3JkaW5nIHRvIE1TSS9NU0ktWC4g
U28sIGlmIHdlIHNxdWFzaCB0aGVzZSB0d28gcGF0Y2hlcyB0aGUgd2hvbGUNCnBpY3R1cmUgd2ls
bCBiZSBzZWVuIGF0IG9uY2UuDQo+DQo+IEphbg0KPg0KVGhhbmsgeW91LA0KT2xla3NhbmRy


From xen-devel-bounces@lists.xenproject.org Mon Feb 07 15:06:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 15:06:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267097.460803 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH5ah-0003KM-Kz; Mon, 07 Feb 2022 15:06:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267097.460803; Mon, 07 Feb 2022 15:06:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH5ah-0003KF-Ho; Mon, 07 Feb 2022 15:06:07 +0000
Received: by outflank-mailman (input) for mailman id 267097;
 Mon, 07 Feb 2022 15:06:05 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=owYM=SW=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nH5af-0003K9-FS
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 15:06:05 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 779a6970-8827-11ec-8f75-fffcc8bd4f1a;
 Mon, 07 Feb 2022 16:06:03 +0100 (CET)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2058.outbound.protection.outlook.com [104.47.13.58]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-26-bFTQhUw3Mw2WfNvTQZYsuQ-1; Mon, 07 Feb 2022 16:06:01 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB2992.eurprd04.prod.outlook.com (2603:10a6:802:9::10) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Mon, 7 Feb
 2022 15:05:59 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.018; Mon, 7 Feb 2022
 15:05:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 779a6970-8827-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644246363;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=15dLJ1kaBNPyyCxQhByvkocAZParuX/lDB4KtnLwn20=;
	b=QdyHavaO7Q3NFRnBxwesBuOs0D5CPl7rmHaAxmZ+PUOOFRjHtYiVoTWqOGvFeYo6bqRs8F
	IfPnBOo+bekNH5tUZju3NOVJNmGBB73SuWCOCbaCyi9QP/fm2iwvm0hgaMEtios+N9G5Hu
	5YNHVCMWqOIZNBlECzsVZ35C0P/pcDY=
X-MC-Unique: bFTQhUw3Mw2WfNvTQZYsuQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XzT3TL7qZaQ1nHPjkstil2CB6QqfY2Z2hB68Umftx+XS14tQOe4j0LEpQYTW8/1Or49ggtdYhOEbKab1SOW7FqbwTUl7z8BDuDsLDW/PL2Fozir8vo7ZwLXXh4i4x6RYbGfvSVID3mnrOnMEx2B5B0eQgey6aQe7kYHa0hvxsRyZSlhIyKNDoAA27MmmpxA9wqwh93uNevZbO0Vp0rZDqTJ37Xmh1sPXVSeMtu6mGFj0fiItI2xjaQSnvE0Ikx+KYnfglUvumdJkMR89kJ4yf/sygcDSAMNlUkecmnAMYNeaQOVd5fVQdgbcYOm3MUGGl6kLMwKR5YfxuAgT5F1AqQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=15dLJ1kaBNPyyCxQhByvkocAZParuX/lDB4KtnLwn20=;
 b=kHnPr2PsUANVvyBboHY1FoFHHIJQxbQ9lBCxLqddg4YTU9Ku1VabRlkRiZ9zpXKjur90c1B4QwGd5ccU956Omn+w9Ra4NBl+fKVBr2hnBNCBASUN/U2LaRuWijsyEnOsmtE2hxR41Gg46x1JW7vSzidwAqafyO9i3B36XQQwOhPX16Ok7vSl1u1hrA/2lpK+llmc1yfnYwSU2S+np0WSzKlyNp8AZDkly+tBaXXvVNS8ahkHyqLI5RDpKvxjFj7W44nTe5AcBE+EJDrr9/HcKYXcSZhqymBHQ1VbTVeYhh4sKc5YOQzjGwjFn6H9OPTunDt6+w4R7t3qKRJRLGue8A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <f6f16729-8404-6703-11c6-dd7a4ebc658c@suse.com>
Date: Mon, 7 Feb 2022 16:05:57 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v6 10/13] vpci/header: reset the command register when
 adding devices
Content-Language: en-US
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Cc: "julien@xen.org" <julien@xen.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Artem Mygaiev <Artem_Mygaiev@epam.com>,
 "roger.pau@citrix.com" <roger.pau@citrix.com>,
 "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
 "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
 "paul@xen.org" <paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-11-andr2000@gmail.com>
 <96381d7e-dafc-acee-3abf-f9815deb207c@suse.com>
 <ef76faac-f9d3-1cb8-06b5-189ccd299542@epam.com>
 <6f0a015b-c48f-76ed-9a51-39c045ff5927@suse.com>
 <2ad372d4-a181-9307-ef50-a5adb61dae66@epam.com>
 <49380584-0577-96f2-ef1c-a96eabf0d227@suse.com>
 <fbd410d1-84ad-2309-ca05-b9ac7f95f1f9@epam.com>
 <dbef1c95-818c-427c-1963-75d584843cff@suse.com>
 <f34cc940-7f5f-aebd-60d9-d1a3d85d1283@epam.com>
 <8f35e7c5-3193-4b10-ae25-df838e2262c7@suse.com>
 <6b4ea90d-cc9c-edf7-e579-a84d72431d7a@epam.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <6b4ea90d-cc9c-edf7-e579-a84d72431d7a@epam.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM7PR03CA0011.eurprd03.prod.outlook.com
 (2603:10a6:20b:130::21) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 09fc7c37-b053-4958-a60c-08d9ea4b594a
X-MS-TrafficTypeDiagnostic: VI1PR04MB2992:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB2992EFDA72C526907D5CE327B32C9@VI1PR04MB2992.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	aHnONTeIi3B9MTCBfL2GkQmqzkeuNkCzKPH8dr24CWn5/zO0OUL24hkwIiYwm4ePQJCXyryi66HU0sHyRYsslG2pBTMtqlYsQv/D84Hbkn9lciTyMf8NQSb2Qzm+UXyNplIdh6CWj2hZtqFCWvt7kqiMwtGw56RHtiKkK9R7EO60WxP2sgjYByRDphpTrncHr7USL0PXrtn/uj7usG0ulL1Fx6DOhM9hZGIQ3CAcTmYgrT7dE3oEAcXvn9YRk6hkZrEY+y+ihzqZMUN20UXNo/L6BUGbnT2Tu0FQIp7OJ2YhoQHmej+Onces+TCxxyIxJL5jZyTyj1YQfiwOWb4PlSlxboU/xPD8PNY56tXT7Pnb1ykaY6nIcZ5H94xO5IsYdzBCrLw/d46LOF/bCCJchnGCmwZYmbemSfbCB1vAHzWergidAIHpBeo3fnFdk4LQgc6khMVIbEDT5TghpxMtVprSntL8wjzJAyum0w+QtHiVj+xNNsutfTDCQN7mp95/fufo+ZHLr8sMRVOzOqWoaWLpjZo3YSjSqht67Uy6nacsTNy4fcYn/CpDRUVYNXzkrx9xgmsq9Llje/hMWGCzRLTFb3Z8EF+6rjjPB/SH1JUuiuFubGA/nj2CzpnbJo3XLW7nbWUHfIzOUUYNL2Nud5yxeJOm7koUm3g96J7U1iXnTbOj7oyg7HbfwOnnx2rEFiWczZRD/hxlswJW61pq6LFImpm5Yzng5l9MdGrtscw=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(7416002)(6916009)(2616005)(5660300002)(54906003)(31686004)(6512007)(36756003)(31696002)(186003)(26005)(4744005)(316002)(2906002)(6486002)(8676002)(66556008)(66946007)(8936002)(66476007)(508600001)(53546011)(6506007)(86362001)(4326008)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?MVZCbHNYUVJaL012ZmUxREt1NmxOZUd5MzI0L3V3T05IaTU4L3JkZWd2Tktj?=
 =?utf-8?B?aGdCRGk2VUtvOFZNbGgwQ1RnTy92S1BSK296WlZBTUl1TzBFUVZLa0xJNDRl?=
 =?utf-8?B?S2JHOWFIWWNwRFQ3WlNzNDh2c0xYSldiVm5haWRMZXl3ajAzSWlqdHhHYXNT?=
 =?utf-8?B?MDhQbjB3Q2I3bFJ1REdMeUVFSVpuQlphUlR4dElZckIvRWlzSGZYSlU3WnRV?=
 =?utf-8?B?ZDdwNklnQ1BTeVVSaHo2d3g4aWQyYlBJM0lYREttT21LTmNPYnloa2Y5d3lj?=
 =?utf-8?B?T3AvRzZWWDBwNk1uVUw2WnJGRHpCSDhhYWZPMEk2OGZXQmxCZUhjR21JeFM2?=
 =?utf-8?B?WFFJaG1FOVNES0E0a2pYbnJIVFhZS01EbERSN044SG0vWlc5cVREVGR4dm1y?=
 =?utf-8?B?ZTgrM2Y1WktJUGI2c04yTDJuSUVYb3FyUDhsS2UyS1Vra3RuemVFem9HYnhm?=
 =?utf-8?B?VmNTV3VmV1lwU1N0WEdhU3FpUDBvczloNnRXYzdQSzFTT1kyblhCZHdtQkZi?=
 =?utf-8?B?MWZlOUxSTGgrUFd2QS90aHllbGM4VW1pU1dpMGZ1WVZWSkNPcWxLL2NiOEVo?=
 =?utf-8?B?U2RRL3p1cXZpdXdqakhyZE1lTnZUT0kvOGppblA4TmduQ3h5Q2UxQmsvTHp4?=
 =?utf-8?B?dUlwMjM4UUR5dGxPTUVFcWx1ZTJsUzl0TWtHanl6RldHcGc1RnVJV29oRTd2?=
 =?utf-8?B?YmhWQ0EyNU1ZZVExYzJDWG9ITTRnRzZYOWJjenBCY1JPTUVjWXRObTRGNXR3?=
 =?utf-8?B?bFJhRmhkM3RSQ2VhQlowMUNPaTNrY3MzeGpTWHZzLzErdHpFSXYvSnRidEli?=
 =?utf-8?B?WkpySnBvWGhudkNabitTdVBVNm5XOXpIZnpFNENsNzlvOXZObHF5d1VMTXRw?=
 =?utf-8?B?RmthODFjcER2Y0crTXVtWGxuUXBsemhxOUlTRm1tWmRSOFFRdDRZMnB4NnZ4?=
 =?utf-8?B?Rjl3bWJ2QTdHV25MRkdQN1NPK01DOWhWUEJyVEU3QkRibkxCTkhSRmRkWG5Y?=
 =?utf-8?B?enlLQ0RkRHExK09FQUN0NExFS0Z4Vlp3MDV6UVdOQ0J5THNjdHdoN0twenJQ?=
 =?utf-8?B?RDduOUlCR1kwd1R6WHZTaTZkOHVmaTExUlo2WTE1NHpDOWRuV01BTlNCak5w?=
 =?utf-8?B?RzB4Umg2b0JJaXdYL2s0bzJnb2Y2RGIyZXpYR2pIVEdjWHlkOFVySElwSXJW?=
 =?utf-8?B?Z2FIZTltTU5MRmFTZ2FocDNDeDRQMWtSK3JxejFDd29kQ2xueUN6OUYwUkdQ?=
 =?utf-8?B?U3A1UVY3UlVEZnB4bG55NitvL201Ujlud2svSkdBQzZnakV4dnpnT0hQUFhj?=
 =?utf-8?B?dEFQYUlWdy91TGt3V21nenJEc1RJU0RBNnlUUmdJSXNLaWsyM1ZDOUVmUll5?=
 =?utf-8?B?T21EK1d0UmVMMU1ST0Npc3BYQnVOcWVJVERwcGZORUloNTJiQ1RWZllQWnhy?=
 =?utf-8?B?S1VNZ3NPdHJidDBhVlZIVithUkdZLzliYUxWbjB1TTdtbEp0RlpNWWFETWEw?=
 =?utf-8?B?S1JOMzVDOW9rVFhwNkxPOFl3RGJONU9aNUIvdytEQ0g2TGh5d2s1SHVzRnlE?=
 =?utf-8?B?Zm9iSEFXVUxuWS9PenAwclk1dmRLNFZnQTdiZ1NNZkwzUDRPRkJ3VHRoa0Zv?=
 =?utf-8?B?VXdMSmQxY0hqaFBsS0FXQ0xYSittWnVNTWc0R0JxeVpQeVNNeWt1dFBlK0gz?=
 =?utf-8?B?L0VrQ1dDamNrQVJ1cktaR0UxTVJPc2lLejBUeFRzdXZNbkJ2L25id0lWU0Zr?=
 =?utf-8?B?RUxGbUFyTVUrSDFzV1o3UjkvMitiSXJWb3UwcGVhVzRVdGY3MzFoblFoSVln?=
 =?utf-8?B?ZWdKaUFKUmxOKzFoRVJoL2p3aHFOeE85V25GRHBDaWFnOG9wVktJYTQrczkw?=
 =?utf-8?B?bVlPNXUwZlVnZ1p0RTdoSDQ4aVZIT0ZRaDdweWQ5dm00d2ZWMlZ4QVRyUVBo?=
 =?utf-8?B?b2Q0WDVpSWR6UkpaTDMxak9QSzdtRVFnTW4vRlFvcFhNanhOdklzK0VrUmVv?=
 =?utf-8?B?Q2JVZzUwazMzRWpkVGk4bHpNV21nQTVkbEZIbUtDYzBtWjBocm93UW1nMWR6?=
 =?utf-8?B?bmNkOU83Y0Rpckh5ekJCa1EwRHR3UWM1eTM3NStTYTZmQ1JZWnBrYzgraHZs?=
 =?utf-8?B?MWdLa0J6QksycFkxaEVMc1Q2cmhHWjFYUHZ0N2x1b1ZaSGpHd2RoMG5Sc3pL?=
 =?utf-8?Q?eI94+/zd2wdIvBkek9iEbM8=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 09fc7c37-b053-4958-a60c-08d9ea4b594a
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2022 15:05:59.2553
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9sZYKry8o6gQW8xafdzW3WntSxUvoHRz3j6puK9E4VJ/QXWZ0vW3qqqxCgP8Qc+byowznanxTi14ZNl/zi4/+Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB2992

On 07.02.2022 15:46, Oleksandr Andrushchenko wrote:
> On 07.02.22 16:31, Jan Beulich wrote:
>> But: What's still missing here then is the separation of guest and host
>> views. When we set INTx behind the guest's back, it shouldn't observe the
>> bit set. Or is this meant to be another (big) TODO?
> But, patch [PATCH v6 09/13] vpci/header: emulate PCI_COMMAND register for guests
> already takes care of it, I mean that it will set/reset INTx for the guest
> according to MSI/MSI-X. So, if we squash these two patches the whole
> picture will be seen at once.

Does it? I did get the impression that the guest would be able to observe
the bit set even after writing zero to it (while a reason exists that Xen
wants the bit set).

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 07 15:11:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 15:11:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267106.460814 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH5gA-0004kE-Ah; Mon, 07 Feb 2022 15:11:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267106.460814; Mon, 07 Feb 2022 15:11:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH5gA-0004k7-7I; Mon, 07 Feb 2022 15:11:46 +0000
Received: by outflank-mailman (input) for mailman id 267106;
 Mon, 07 Feb 2022 15:11:45 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=F54n=SW=epam.com=prvs=403792ff6c=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nH5g9-0004jx-0l
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 15:11:45 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4157305e-8828-11ec-8eb8-a37418f5ba1a;
 Mon, 07 Feb 2022 16:11:43 +0100 (CET)
Received: from pps.filterd (m0174679.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 217EEgac023710;
 Mon, 7 Feb 2022 15:11:39 GMT
Received: from eur04-vi1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2053.outbound.protection.outlook.com [104.47.14.53])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e350ur8gg-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Mon, 07 Feb 2022 15:11:39 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by DB7PR03MB4523.eurprd03.prod.outlook.com (2603:10a6:10:19::27) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Mon, 7 Feb
 2022 15:11:33 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77%3]) with mapi id 15.20.4951.018; Mon, 7 Feb 2022
 15:11:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4157305e-8828-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Rb2s6utuF4l/Fk0QuN5hc79ijeRTNg4F5aRo+/Mwg0enPWxVMzUWI68eoaLwK7Cbf1CCz6BIBC7Ew6G79amMmb/IiBjbrCDsEr4dMsNOx3o81JGOmrbrEsLzfRENdVKxZyDiA0Cy/H+xk6J0Z/Oi5Fx+GB0ad9lXSU8UfkXg1LV2YfhCn2Sza3+0w7T8nCFYHVVOJ7W87zNFhiN3PlKf11lmkL8Hk4r0b7ZH7JTzm2HWCUmLFi5/ytIZZg4mG0nTEMF5QRsXwP9JBx7A+MOlAibU0/hmHHGuJYC5Uw9bGnqdESAB/FfKhmNc0rUaqlwp3f6lkt1ZrM+5+NoZ6JNu9A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=dibTvYft0ltfhGCH+vWFW/7Xw2VZD5kAewZOlI9fu60=;
 b=nr+2eqZ0/SpfGsXvK9yg3ei3ldERx13zj5tvXaz25vCGRd3L+4zVKHOCmf/v/WShoPJogXzzyBdWKrfBfCZPRn04HWi+eupgRNcYkwN6pRUPk8W6KppLRcEWBW+Vo54D+Zt2k4nRJjUfunCEzHcB3dL//ctvwROtewAeRi+FCeZOQRikw/BPpUvLSHvX2RwbgGW9UJcmGFxvX3sejrHBJxVVl0UzyUkkM6n0V5kIkCQcCXYoleJBSVkHbJyJzblRNuCLg3vdveJdn0UvDcO0ykHtwmHqxa1o148a+J8SZHMUVqdcdzX9gzZARWC0+/c/zQPY2tCrBWYX9/rLL4pHMw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=dibTvYft0ltfhGCH+vWFW/7Xw2VZD5kAewZOlI9fu60=;
 b=S6JUbE9FCtoR8K0S6tUE4lHEGLxaKgQ9EQKbdAhv8NXStEIpcggqYoobhp2gCK3g1r/I1w20Z05l2sZE/t+li53fM5DRzXKOrCWmskodIwS+9+0TvmteIWP1RyPOi3yrVSpRjhQLISQm0WZ2t/QIYQ+q3SU651HbLggRKzzuWMqJNCCoz1cYurtweiPvxKoNG+4RqHLRfZvbL+CDOWP9ZUyvRsDAeQhAq44Bu52AEWMF1wwS5oO8HPYf4KCwK0jdcsLQV77UcFcKhRoMQmMdBI/gm8bxQww3xQUwI75kBxDdrkpOxbJHoIbmSDPXbsmXnHgKCbm1k8ksapSv9tg3JA==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>,
        Jan Beulich
	<jbeulich@suse.com>
CC: "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Thread-Topic: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Thread-Index: 
 AQHYGZFc/MnzQOjwVEeBBUHLSW0md6yDBUkAgAASSACAAATYAIAAD/WAgAAKNgCAAAbfgIAABnuAgAAQvgCAAAMCAIAAAY4AgAADxICAABrnAIAABAgAgAR3CoCAABt5gIAAEpuAgAAE5ICAAASKAIAAAiiAgAAKNYA=
Date: Mon, 7 Feb 2022 15:11:33 +0000
Message-ID: <e8fc7872-c7d0-f389-c507-335b809ffcbc@epam.com>
References: <7e3562b5-fc67-f213-e872-f211450d9e2e@epam.com>
 <a8fc599c-f620-c4d1-2077-c57068f46a7f@suse.com>
 <deef8468-d607-e49e-f456-6a8013329ca1@epam.com>
 <Yf0k6aoKK5G3iad1@Air-de-Roger>
 <3ad10a99-c706-b95f-1419-2c0c7cf37d58@epam.com>
 <Yf0+3C9nF8+tewLw@Air-de-Roger>
 <c5fea3bb-834b-eeb7-d7a1-1ee609037a9f@epam.com>
 <YgEUwTxhnWVMGMJK@Air-de-Roger>
 <9ce90193-74a0-5642-d22b-6b8c3340c3cf@epam.com>
 <1f65ae7a-898d-2c27-0ada-d71d778b0627@suse.com>
 <YgEsRuckQJIQlkzf@Air-de-Roger>
 <a2a42c1d-d379-00cd-5d55-f443cdb02e97@epam.com>
In-Reply-To: <a2a42c1d-d379-00cd-5d55-f443cdb02e97@epam.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: f7a36dfa-9280-4598-fef7-08d9ea4c20d6
x-ms-traffictypediagnostic: DB7PR03MB4523:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <DB7PR03MB4523A3DD9DE814469A2F79B8E72C9@DB7PR03MB4523.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 c0zZyHGOLZntVsnFOwxOLOayz8zdBbwXhbqt0bw7GHGNlRvOWEiuS+0DM6PhPlavNKQyNgTMiJ50+RT/mkI1pEcakMurWyQlL9KFUEuQI5puhwxP/gylp9BH42Gsvr4TYaoBBkAL9odB6pagZDwYNuXs7+dTcMvLeod+IMHmvIZSPvOisPCCuwCGU41gX1oX9czycCXeIOuYDZWSMnkv051NQtqjdNjx3dPbPmsNZYxNNGF5BIkwsESKhA8+Js6CYQnSXzouwPrG9g1O/27qjLdnnkTLBREjX1HMgGnV9NBPboKPz/SVgW6h6Cdbn3CwM900BaR8Y645RqWa39sOLL30P7s8QdYzreW6e0m4h/6DTTfOdAzgsxxPn/OCtgUFRhebKuOI0i9O+IkV/5CgR6uo2mC04AIer6XsAxfMFO0OZupjAqLwcGjwv5U3x3ipG0pRrj545+nRTLoqNSiYjMQuUeRf9yZVN5uVvWZCosl+9JsypVCCk880xUYMd1Aw6t/wit910P5OTZiSZNZWlkP6yKWulG9gb3ZmPjNuAuuml/c/DCFLxLooWQUQXIkmQSxm72/efmwi1WcD8AsHGgbbn4DL2jn6Yd7tnpHRtYqNBkryZ6jOhzOxCqBMjHJEVaIy5aW9zYI7tdVbwz6ZQcBObIqK7Ei21xfKb2m6OYFCbd7Oa1O3CM3T1r9BLBQ6ORVabGVis9ssfg3lZxU6RV5wI+3Fz4hiwdEXKSlB3nc9cpUPdZowys8/PxfKk0zrmni8GMs4TZnvyljs9RTcROR37IKy/ojLrO4kY2jDSLWJsG2yf6pE/k+iZb0NC4IdIaSwYBktjpoiX0SKtzwGrQ==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(91956017)(53546011)(76116006)(8676002)(38070700005)(71200400001)(8936002)(64756008)(66446008)(4326008)(66946007)(55236004)(66556008)(66476007)(110136005)(54906003)(316002)(122000001)(83380400001)(36756003)(2906002)(6506007)(6486002)(966005)(186003)(26005)(2616005)(107886003)(31686004)(5660300002)(508600001)(6512007)(38100700002)(7416002)(86362001)(31696002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?cS9ld2E5NldwQUJnK1FmVzNMQm5oYlVlWFV1UWpWY0hPRWVBNnVTQUZySS9i?=
 =?utf-8?B?R2QvZG8wUGh5RHNZL3FpTlE2VHpGSzdOTmdaWmFEaEhWSnR3TUNDbmFvVEVN?=
 =?utf-8?B?RVlJMXRRTk5ZQzR0aDM4WXBkM2h1UVBvT2x4VWlWWW9CRWNTSlBLWk15Z0E3?=
 =?utf-8?B?NEJDeUdJYmNMU044MHFtUkF3N01DU2QwMUNla00ySjBKNjJ3L3V3eUxKR0xZ?=
 =?utf-8?B?OGdvSVQ3UHRFcjhpenI3NFN1WWIwKy95VTNmdkRRWGZkbDkzbU50TERTcEJT?=
 =?utf-8?B?ZG02c1psWnIrN0RhVVprejVNWVJsWkZieENPclhTdUxWakdrS3hvRnFLaXh4?=
 =?utf-8?B?dy9LYWhWQmFDeFVxUlhWSjAwMFNVTDlSVVBoa3pzMytTUEtPZVJEU3FlN1c2?=
 =?utf-8?B?eUtFWVpMUTI3YW1VNnF0ZmZJMW1UNXQrU1F4MUk3QlpPV0VKV3hDL2VmTWUr?=
 =?utf-8?B?eVZ4YmgvUXlTNkxMemVXc25VNHdjYlJRYWVwalhJb094aTZBeHFBRFFkRVdD?=
 =?utf-8?B?amQreXFKUFlNaTNjRVlwTXVzSWM0ZDlVbUFpbGhiNkp5VW5VTWljMlhBekV5?=
 =?utf-8?B?ODRSaGx1VlVxbE0vUUZQZGg4UEJMeUtRaXJocjlneldvSy81Wk5GL3dIZGZ0?=
 =?utf-8?B?WjJvN2xWSExRUXFBQTVSUUtYckZqNmdTQ2VuWmg3ZE5hOUE4c2tkMzA1Nm85?=
 =?utf-8?B?TmEvVkd6TkYyYWVFaXJFdG14bExvUy9CcVNqQXR6cWVCd0M5MXN5UmZPQkJO?=
 =?utf-8?B?UnkzVWV2cDBiK2NqdkRnR2FwbTYrY0kzN3RxQ0l1WXN6TkdHTmxlaitkcC8r?=
 =?utf-8?B?M0JvN2ViOVZDRitYaXNKeWV1aGFzTXh2b2JlT0RDbitSQzhPUEs5VmtIY0Fh?=
 =?utf-8?B?N2p5UnBDK09UenVvdkxqTlRkYUl6RHU4ZkZ6SUU0SFBXRnRIMytJL2R1SVF5?=
 =?utf-8?B?OFRBYVczR3dEcVN2NTZlRmxzeU1GWG94Qld0K0dtUHBDRjZlT2dPSzVNalFw?=
 =?utf-8?B?YnpTUTZCY3Rva21mQzBGMHRob29lMlU3WmlhUnhZRjROb1J4TTRMOUYyTG11?=
 =?utf-8?B?T0UvU20rZ0lOdkQzSnRwbFlwRTRjYUR2ZEVZQUFSZXF3RDF6RHZIcmN0K0Ny?=
 =?utf-8?B?QzVDNnRmbUg1TmpISWd4K3JoRjRCcVBITXVLWHk0OUphb3M5TjZxbE5DbGI3?=
 =?utf-8?B?YlRKTjBWcHNzLzF5THh4QXpqc04vdWYrQkNtcTN4Ymh1SWNScldxa2F1dS9p?=
 =?utf-8?B?OUp1YUFETzN5NElyK0VaUVB5eHJJVVhVN2ZobXVQV1BJMmFoTU5VK3kxcFMx?=
 =?utf-8?B?ZGhuaTRXdGVIN1djZkUrZU5EYkprUmRCNDFnVkJQNFFmdlZ5K0grWUFSVng5?=
 =?utf-8?B?eTNDRHdMR0V4Y1pzMVgyN3k0Qm5rTnMzK2M4OStNanNVTC9sZG82MXZycFov?=
 =?utf-8?B?ZFhXaEVHb052WU1ZdzJCdFk3TFJ2cC9RNEUyQVBQQmdWSDAxMURJeW1GVDZ1?=
 =?utf-8?B?cGFaeC9DV28xK3VpY1Bsa1BoVWNTT2dEbk9vUHdKS2RZa2VXZmVsTGpzcldD?=
 =?utf-8?B?cUUzUGZQb1NmTDQ2M1dzY2FMeGJ4NDdPbmxOY1dyRlkvVkpHMWxiOXNCMy9C?=
 =?utf-8?B?R1BmOTZnKy8zUHhOc1dIUFh1SlgrOUJoMEFtY3dGZTR4Ui9kTldYNEZacXZh?=
 =?utf-8?B?N1lOeHpHWk9XclNOS293cFk0L3BVbExHR1FDdlZKVDIwSVQ4d1BERlFLQk9N?=
 =?utf-8?B?K0RkbndBKzlpQlI3ekhkVzZ1QmtISlRwODdOL0VEQlNZMVdidEpzcGFVQURQ?=
 =?utf-8?B?OE1KU2VNZTVOeEpkeDY4RHhGN20vSmFaSFlDREhVa2pUSTNxRGQvcnZ2dGk4?=
 =?utf-8?B?eEEwU3ZyTUhvd1NHZW4rcVNzaUduZjVrUVhUazVKVzdCekFKYkgyTWlRU1Va?=
 =?utf-8?B?MC92Tm1TVlRUNGFyNTlEcDVKenVvZ0FieU1UNWlvdmtHNFI2NmpmekE2RHEr?=
 =?utf-8?B?UEFBeTVteGU5Z3A2UGI0UjVIellYeUwwclg5VDBCb3RzZGUxVFFpM1JJTE5u?=
 =?utf-8?B?Sngyb29Va2RiNGYyWEdJSGZyV3hjbjVTam93cVBqOUh6V2xydXFZRGxEdXVh?=
 =?utf-8?B?T0I5VytmKy8wQW00RkN3L0Y0LzkyRTZPSlFHMGYxSzNMMkM5RFRySktjbUQy?=
 =?utf-8?B?NDV3c1c3Yk9aWlZaZEY5Wmh6T1FtT1ZzNktPamtxZFppWFlFRVFMRkt0bTA1?=
 =?utf-8?B?dDl6L2FXbENveEFIRHE1VnFUTlErTDlGRkhmTFlvK0U3V0xlaGVTMGJwekIx?=
 =?utf-8?B?VDdNYkVCbStzOUxwNU91RlUxWEpteENaZlJSL2dFcC96VUVydnNCckp3VkdP?=
 =?utf-8?Q?Y33au60hgY82HVPA=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <F1D8E10EE9B02B41BDB8895043A0D63A@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f7a36dfa-9280-4598-fef7-08d9ea4c20d6
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Feb 2022 15:11:33.7917
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: lRdbDyJ/W9yaphMnMI6h4DTScd3deUZRUv4KGmYVEm56T3ARBLHaJyNCQy2mkOGUTGOxBPkZ36MvEU4pyNZ+x+fSQ+QyFLr76gvt+f+jyzsxpsREed2/Hv8l5EOT8ZDD
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR03MB4523
X-Proofpoint-GUID: 5OD4F47qKZtgWDv_aDOgiSj9Srf6aXKI
X-Proofpoint-ORIG-GUID: 5OD4F47qKZtgWDv_aDOgiSj9Srf6aXKI
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-07_05,2022-02-07_02,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1015
 impostorscore=0 phishscore=0 mlxscore=0 spamscore=0 priorityscore=1501
 lowpriorityscore=0 mlxlogscore=730 bulkscore=0 malwarescore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202070098

DQoNCk9uIDA3LjAyLjIyIDE2OjM1LCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyB3cm90ZToNCj4N
Cj4gT24gMDcuMDIuMjIgMTY6MjcsIFJvZ2VyIFBhdSBNb25uw6kgd3JvdGU6DQo+PiBPbiBNb24s
IEZlYiAwNywgMjAyMiBhdCAwMzoxMTowM1BNICswMTAwLCBKYW4gQmV1bGljaCB3cm90ZToNCj4+
PiBPbiAwNy4wMi4yMDIyIDE0OjUzLCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyB3cm90ZToNCj4+
Pj4gT24gMDcuMDIuMjIgMTQ6NDYsIFJvZ2VyIFBhdSBNb25uw6kgd3JvdGU6DQo+Pj4+PiBJIHRo
aW5rIHRoZSBwZXItZG9tYWluIHJ3bG9jayBzZWVtcyBsaWtlIGEgZ29vZCBvcHRpb24uIEkgd291
bGQgZG8NCj4+Pj4+IHRoYXQgYXMgYSBwcmUtcGF0Y2guDQo+Pj4+IEl0IGlzLiBCdXQgaXQgc2Vl
bXMgaXQgd29uJ3Qgc29sdmUgdGhlIHRoaW5nIHdlIHN0YXJ0ZWQgdGhpcyBhZHZlbnR1cmUgZm9y
Og0KPj4+Pg0KPj4+PiBXaXRoIHBlci1kb21haW4gcmVhZCBsb2NrIGFuZCBzdGlsbCBBQkJBIGlu
IG1vZGlmeV9iYXJzIChob3BlIHRoZSBiZWxvdw0KPj4+PiBpcyBjb3JyZWN0bHkgc2VlbiB3aXRo
IGEgbW9ub3NwYWNlIGZvbnQpOg0KPj4+Pg0KPj4+PiBjcHUwOiB2cGNpX3dyaXRlLT4gZC0+Ukxv
Y2sgLT4gcGRldjEtPmxvY2sgLT7CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoCByb21fd3JpdGUgLT4gbW9kaWZ5X2JhcnM6IHRtcCAocGRldjIpIC0+bG9jaw0KPj4+PiBj
cHUxOsKgwqDCoMKgwqDCoMKgIHZwY2lfd3JpdGUtPiBkLT5STG9jayBwZGV2Mi0+bG9jayAtPiBj
bWRfd3JpdGUgLT4gbW9kaWZ5X2JhcnM6IHRtcCAocGRldjEpIC0+bG9jaw0KPj4+Pg0KPj4+PiBU
aGVyZSBpcyBubyBBUEkgdG8gdXBncmFkZSByZWFkIGxvY2sgdG8gd3JpdGUgbG9jayBpbiBtb2Rp
ZnlfYmFycyB3aGljaCBjb3VsZCBoZWxwLA0KPj4+PiBzbyBpbiBib3RoIGNhc2VzIHZwY2lfd3Jp
dGUgc2hvdWxkIHRha2Ugd3JpdGUgbG9jay4NCj4+PiBIbW0sIHllcywgSSB0aGluayB5b3UncmUg
cmlnaHQ6IEl0J3Mgbm90IG1vZGlmeV9iYXJzKCkgaXRzZWxmIHdoaWNoIG5lZWRzDQo+Pj4gdG8g
YWNxdWlyZSB0aGUgd3JpdGUgbG9jaywgYnV0IGl0cyAocGVyaGFwcyBpbmRpcmVjdCkgY2FsbGVy
LiBFZmZlY3RpdmVseQ0KPj4+IHZwY2lfd3JpdGUoKSB3b3VsZCBuZWVkIHRvIHRha2UgdGhlIHdy
aXRlIGxvY2sgaWYgdGhlIHJhbmdlIHdyaXR0ZW4NCj4+PiBvdmVybGFwcyB0aGUgQkFScyBvciB0
aGUgY29tbWFuZCByZWdpc3Rlci4NCj4+IEknbSBjb25mdXNlZC4gSWYgd2UgdXNlIGEgcGVyLWRv
bWFpbiByd2xvY2sgYXBwcm9hY2ggdGhlcmUgd291bGQgYmUgbm8NCj4+IG5lZWQgdG8gbG9jayB0
bXAgYWdhaW4gaW4gbW9kaWZ5X2JhcnMsIGJlY2F1c2Ugd2Ugc2hvdWxkIGhvbGQgdGhlDQo+PiBy
d2xvY2sgaW4gd3JpdGUgbW9kZSwgc28gdGhlcmUncyBubyBBQkJBPw0KPiB0aGlzIGlzIG9ubHkg
cG9zc2libGUgd2l0aCB3aGF0IHlvdSB3cm90ZSBiZWxvdzoNCj4+IFdlIHdpbGwgaGF2ZSBob3dl
dmVyIHRvIGRyb3AgdGhlIHBlciBkb21haW4gcmVhZCBhbmQgdnBjaSBsb2NrcyBhbmQNCj4+IHBp
Y2sgdGhlIHBlci1kb21haW4gbG9jayBpbiB3cml0ZSBtb2RlLg0KPiBJIHRoaW5rIHRoaXMgaXMg
Z29pbmcgdG8gYmUgdW5yZWxpYWJsZS4gV2UgbmVlZCBhIHJlbGlhYmxlIHdheSB0bw0KPiB1cGdy
YWRlIHJlYWQgbG9jayB0byB3cml0ZSBsb2NrLg0KPiBUaGVuLCB3ZSBjYW4gZHJvcCBwZGV2LT52
cGNpX2xvY2sgYXQgYWxsLCBiZWNhdXNlIHdlIGFyZSBhbHdheXMNCj4gcHJvdGVjdGVkIHdpdGgg
ZC0+cndsb2NrIGFuZCB0aG9zZSB3aG8gd2FudCB0byBmcmVlIHBkZXYtPnZwY2kNCj4gd2lsbCB1
c2Ugd3JpdGUgbG9jay4NCj4NCj4gU28sIHBlci1kb21haW4gcndsb2NrIHdpdGggd3JpdGUgdXBn
cmFkZSBpbXBsZW1lbnRlZCBtaW51cyBwZGV2LT52cGNpDQo+IHNob3VsZCBkbyB0aGUgdHJpY2sN
CkxpbnV4IGRvZXNuJ3QgaW1wbGVtZW50IHdyaXRlIHVwZ3JhZGUgYW5kIGl0IHNlZW1zIGZvciBh
IHJlYXNvbiBbMV06DQoiQWxzbywgeW91IGNhbm5vdCDigJx1cGdyYWRl4oCdIGEgcmVhZC1sb2Nr
IHRvIGEgd3JpdGUtbG9jaywgc28gaWYgeW91IGF0IF9hbnlfIHRpbWUNCm5lZWQgdG8gZG8gYW55
IGNoYW5nZXMgKGV2ZW4gaWYgeW91IGRvbuKAmXQgZG8gaXQgZXZlcnkgdGltZSksIHlvdSBoYXZl
IHRvIGdldA0KdGhlIHdyaXRlLWxvY2sgYXQgdGhlIHZlcnkgYmVnaW5uaW5nLiINCg0KU28sIEkg
YW0gbm90IHN1cmUgd2UgY2FuIGhhdmUgdGhlIHNhbWUgZm9yIFhlbi4uLg0KDQpBdCB0aGUgbW9t
ZW50IEkgc2VlIGF0IGxlYXN0IHR3byBwb3NzaWJsZSB3YXlzIHRvIHNvbHZlIHRoZSBpc3N1ZToN
CjEuIE1ha2UgdnBjaV93cml0ZSB1c2Ugd3JpdGUgbG9jaywgdGh1cyBtYWtlIGFsbCB3cml0ZSBh
Y2Nlc3NlcyBzeW5jaHJvbml6ZWQNCmZvciB0aGUgZ2l2ZW4gZG9tYWluLCByZWFkIGFyZSBmdWxs
eSBwYXJhbGxlbA0KDQoyLiBSZS1pbXBsZW1lbnQgcGRldi90bXAgb3ZlcmxhcHBpbmcgZGV0ZWN0
aW9uIHdpdGggc29tZXRoaW5nIHdoaWNoIHdvbid0DQpyZXF1aXJlIHBkZXYtPnZwY2lfbG9jay90
bXAtPnZwY2lfbG9jaw0KDQozLiBEcm9wIHJlYWQgYW5kIGFjcXVpcmUgd3JpdGUgbG9jayBpbiBt
b2RpZnlfYmFycy4uLiBidXQgdGhpcyBpcyBub3QgcmVsaWFibGUNCmFuZCB3aWxsIGhpZGUgYSBm
cmVlKHBkZXYtPnZwY2kpIGJ1Zw0KDQpAUm9nZXIsIEBKYW46IEFueSBvdGhlciBzdWdnZXN0aW9u
cz8NCg0KVGhhbmsgeW91LA0KT2xla3NhbmRyDQoNClsxXSBodHRwczovL3d3dy5rZXJuZWwub3Jn
L2RvYy9odG1sL2xhdGVzdC9sb2NraW5nL3NwaW5sb2Nrcy5odG1sI2xlc3Nvbi0yLXJlYWRlci13
cml0ZXItc3BpbmxvY2tz


From xen-devel-bounces@lists.xenproject.org Mon Feb 07 15:14:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 15:14:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267114.460825 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH5iW-0005Ms-OR; Mon, 07 Feb 2022 15:14:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267114.460825; Mon, 07 Feb 2022 15:14:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH5iW-0005Ml-LK; Mon, 07 Feb 2022 15:14:12 +0000
Received: by outflank-mailman (input) for mailman id 267114;
 Mon, 07 Feb 2022 15:14:11 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=F54n=SW=epam.com=prvs=403792ff6c=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nH5iU-0005Mf-VS
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 15:14:10 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 98e8383e-8828-11ec-8eb8-a37418f5ba1a;
 Mon, 07 Feb 2022 16:14:09 +0100 (CET)
Received: from pps.filterd (m0174678.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 217ENmqD002244;
 Mon, 7 Feb 2022 15:14:06 GMT
Received: from eur03-am5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2052.outbound.protection.outlook.com [104.47.8.52])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e3552g7mw-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Mon, 07 Feb 2022 15:14:06 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by DB7PR03MB3579.eurprd03.prod.outlook.com (2603:10a6:5:4::26) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4951.18; Mon, 7 Feb 2022 15:14:00 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77%3]) with mapi id 15.20.4951.018; Mon, 7 Feb 2022
 15:14:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 98e8383e-8828-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=aYVuSX2DpmN/wHKARgBufxe0Uu7DUx9dh0GfgZOtbsgjuOCll36jH0YfgK2NiJ16075fTu6NYKMIcegkPHc+uuZZQlTxV+cWwB4MNoAgwQnsvZw+46LHNpgQABwmfkdhpyvhlENbJV7bm918KtRtGUmYWGHMA6tGojHuMssAL2xjLmqGRD88sU3ZZMQYa47MerIS4lkJFfrt84e++dKCl3HKjLWkCf9VPA9zmkSAi0MSjW0lLG2oyKxH3gnMLwUgn1dO3eiXaCRDclanLC64ODF7hsdVB0yV4QzSiL4SwG7oPBrDsGwwiPZvSjKr3/cVXN1fr/aXBGqhVF7OH0YkpA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=SZp+nQWwXrMM/PPKvVGJiei+Rn/mNFCHzzWEQW/SgBI=;
 b=GldUGI8j0M2K6BXuBgW0+Pgl1HlP3Emd3ONPcU4cXk+IPVYnktRXeDqVj12zpAMGDMMq8y2N46eJQ0bshuxVw7zYida3pzaiMOZglc1Vv8ydtFidMNKq+ysfn+qw1YIDJB4ldjLm1I00G4jF5efnrD3MD/bpIWjYQ8cxykflACCq86Bc+48HdQ2Pj8P1Ef8Rn/8T7SDp8jiL6oiCT9PipNWuxCTh1N5MB99sTKG96dr4fUSVlPfvKpaWPD6gq9e3NpG4pX1XXwiysGMkAWBTlH9F1RvJpHN93Wq0P+CGcoydklEXHutiHFw6m37YJM0CJ7XWKImlyrN3ppsqqr2sxg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=SZp+nQWwXrMM/PPKvVGJiei+Rn/mNFCHzzWEQW/SgBI=;
 b=khsfgpyYdVQTlWErWmTF/vW9MznhjbBLUxtPVh3LlFMsxd8zc3DP+i9EuykUNoOmXXhYhzI2GLcnUbRklH9mIlFiaNeoYBkTOlHrlc5uWuT9kW9QGYGLIJK8774SXVqNuki//tQpsWavauRZmVEWhpzOSh4AzPx2IswRrdeg1soq8zoKegZ8UImNx3HxKhhvuCMYKodLs45Gg3FB3QJmkyEaWhxoFHmKf1jTP2c+3hTni9HJxaqYRURC25ruMx3aCkm6+LqnzHLzyRKznxDQ+gqB5VK3jjmF60gzR1XkrMZzb1nAYZDRkqo9SkZpBu3xYlyhZZ6EaCGPtnXHr8DYEg==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "roger.pau@citrix.com" <roger.pau@citrix.com>,
        "andrew.cooper3@citrix.com"
	<andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com"
	<george.dunlap@citrix.com>,
        "paul@xen.org" <paul@xen.org>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>,
        Rahul Singh <rahul.singh@arm.com>,
        "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        Oleksandr
 Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v6 10/13] vpci/header: reset the command register when
 adding devices
Thread-Topic: [PATCH v6 10/13] vpci/header: reset the command register when
 adding devices
Thread-Index: 
 AQHYGZFg3nazYSvfA0G+yHTbxcxX2ayDdFgAgAAB6wCABD+NgIAAQmgAgAAT4YCAAAOjAIAAAPCAgAAXGICAAAPHAIAABC8AgAAFjoCAAAI+gA==
Date: Mon, 7 Feb 2022 15:14:00 +0000
Message-ID: <c5eee75b-bcf3-7e31-e25b-0bf0b217267a@epam.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-11-andr2000@gmail.com>
 <96381d7e-dafc-acee-3abf-f9815deb207c@suse.com>
 <ef76faac-f9d3-1cb8-06b5-189ccd299542@epam.com>
 <6f0a015b-c48f-76ed-9a51-39c045ff5927@suse.com>
 <2ad372d4-a181-9307-ef50-a5adb61dae66@epam.com>
 <49380584-0577-96f2-ef1c-a96eabf0d227@suse.com>
 <fbd410d1-84ad-2309-ca05-b9ac7f95f1f9@epam.com>
 <dbef1c95-818c-427c-1963-75d584843cff@suse.com>
 <f34cc940-7f5f-aebd-60d9-d1a3d85d1283@epam.com>
 <8f35e7c5-3193-4b10-ae25-df838e2262c7@suse.com>
 <6b4ea90d-cc9c-edf7-e579-a84d72431d7a@epam.com>
 <f6f16729-8404-6703-11c6-dd7a4ebc658c@suse.com>
In-Reply-To: <f6f16729-8404-6703-11c6-dd7a4ebc658c@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 031b094d-da9e-4df3-20b4-08d9ea4c781f
x-ms-traffictypediagnostic: DB7PR03MB3579:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <DB7PR03MB357925528FAEC5A9255EB7DBE72C9@DB7PR03MB3579.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 OgVgK8BmTXv9AElFjv1PtM5ayx6pF37EVcYh3rX0XRezED8Gk3F5tuS7uuyT8f6qUhvTDB6qjAlwcVVifjgvMWHsRV8Z5xgOiASDAG6WqUOQQlNR8cUjxQH88UN9BdhOqkdE5lzUz0PTaJKx9F2mbphTzFlT4brtQPUPRstGEppr/ewP9LoDbFqgByB9QDCqnCbkBP/Bl5ibqERkG1764JOrjToUJNDg118nZx0y3m5osqVxqxHOLkurRRLX46BLFfwpzoEQJgQHEYW1SspQzqBELLTuNCV1SsUPUG4eOQcfUMsYxctZF3zsvWQ42BzUH1fjPqtM9dSmiUstMZM9GJZeywigQ9Yck2bptj5R1Zkv13d5hyI0aN6M6kffK10yQLsKr27Q6eUHxRI4YHv/WVfMUVnzPxuX1iPv/PaLs7SFXleUPFzfpIzhVWJM95R0PxVfFIjzyEQc+qA9kIJOO71wcxnmzBrVJvVwhncFubyL0Hd/LzanrhUevBpL16/ZmqtxYdnqv/fmeV6lSdNeIcyoB8uLBxy69RCqixa7PKGdKzIbYajv5eSnHaNMNTYmOxcTXCkzZzYDs75mBMCDaX++TEzLsyjjpzxRd5xdcs6cB6ZI0pl5DA53NiMqyvFzzbRTXAZOZlcS+eqyhdM0n2fPF+3q5vjTtdf1PvLnsdOlaZSXOpVXeecXXtaaQj6sPZ8qcohrjoicZqNkHGeM6+ZsPJqd/UaTgtWig+h20+g=
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(316002)(7416002)(2906002)(2616005)(6916009)(6486002)(4326008)(38100700002)(54906003)(86362001)(122000001)(5660300002)(31696002)(38070700005)(55236004)(36756003)(31686004)(6512007)(91956017)(66946007)(76116006)(8936002)(8676002)(64756008)(53546011)(26005)(71200400001)(66446008)(186003)(66556008)(66476007)(107886003)(6506007)(508600001)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?UVRKM1EwRkNDVmE2QUJFSy8xOFU4aDN4U3VTNzBZVUNYUHROSXB2SE1XL1Rk?=
 =?utf-8?B?Y0VhQkF6OFNacUZ4cHd6d1YySWR4a2dPblpib0NPZW0xM1p6VGt1R3RSUlJr?=
 =?utf-8?B?enZ2Y2d5Qm9GNWtubzFUM3ZPTHBYdkQ3ejdGd1BxdlBDblgraHNXYm1MU0Zp?=
 =?utf-8?B?QTJvbHdNRDNFZFJISEJENVdJaG9BZitOeC8vRHFPOCtrMWM5SUx2MHpYRDFN?=
 =?utf-8?B?bWFETExqZjV3a2RmMnRxU0doamZFbFYySy9KVTJ5NENwWFExcXVEai9uREdW?=
 =?utf-8?B?QklFYjRudFA4LzlML0daOVN1Tm9JOERXSWxHVHJqcTJ0dUFoYmlvN2NYL1Ix?=
 =?utf-8?B?T1k5ZkZUQUpWbnJFQWdQeVNZbk5mUm5KZnIwVmZxeURBa0hjTndiVE02UTd4?=
 =?utf-8?B?c011bm4xYmxjNjZ0UU9sV2NrajVWOGpBd25vZTJTZDFDUndmejA1WFkrUFRu?=
 =?utf-8?B?TDZjZncwbERlalFkVitjd3ZyQmpGODJjekxtQm5JY25CejU0Nll6bFRJUk0x?=
 =?utf-8?B?S2xXMTJoMEczRHZpdVR2WGkwckRQT3g5Ymg0NXpoYlBrSDdKd0FEeStYVXdR?=
 =?utf-8?B?M1J3VzA5ZzNYRTNkVVBuN25TcEJYTFA0Q2dqMmplOUwrSmQ1bUpoTWpGOURl?=
 =?utf-8?B?SkYxcmpMZ3NBYURxTEhZczN3NHhwT3BZdCtIZDAwdytwS0tWVE9WaDVjb3V4?=
 =?utf-8?B?MEswOWFzUTJMcFozVUtNV3ZKeGpIMzdtT3o1a29lSnhkY0xIM3IwM1JUREN4?=
 =?utf-8?B?VVFLRS91L21QN3pkR2UxSGh3eUptSnJkNkE3Q1FrYmJPK3Y4aDlsdTB1aHJU?=
 =?utf-8?B?ajNyWUlyQ0VFaHh1TGttZ2J5WVMwM0xiOTg1T1FpRno3V0dGRVYzV01Gc3dH?=
 =?utf-8?B?RjN0c0xZQnVUaWJ6dzI1KysrTkdXZ0h1dDh0Zi9FNkxLWkx4b2U2RWhaQ21u?=
 =?utf-8?B?dW9KczZocEx5b3RjZENIaUs1NEwzb2xJZW05d2wrQmpjdUtyUTJVWllTQ3Ry?=
 =?utf-8?B?NVA1K053VE1sYk5nWUN1OVdoM1VzWWpaQWIvUVEzYzUrTU9HajNPdldFWnh1?=
 =?utf-8?B?L3JZZFNITlRxZzhvd2VHUjNzcHBTNkM2bjZ0NXJkMTA2c1pTSVVZOWZrSkxQ?=
 =?utf-8?B?VDFrRDB2RDZDSThHeVZHak5yYUxxNnY1R0NXYm4yVlpQVDBoWmluNFFPRkVQ?=
 =?utf-8?B?QlcyYThMTERvcVVFYml5QTQ2b3k3ME9yd0x0OWkweTZGdk5FajFkbkVFb2hC?=
 =?utf-8?B?WVFXT2ZGaVZSUE5LS1RhQVN2VHRMQjZZeWFQUUtRaWhlUUZQcnVyYjl4TVVt?=
 =?utf-8?B?czR4cmxOZU1NUUFYdVhZTUpKR0tHYys4endHaTZWUkJSVUxVQ05qNTU1NHl4?=
 =?utf-8?B?d1RjZHhIdGQvZDNwZlQyb2lzOUl1M2JkK0lVOVRPMDlXQXY3cjhsdXVvZTJm?=
 =?utf-8?B?aW1Rb2p5dGNDVHAxRXl5ZE5yYWUzazM1YWxGbDRRM1R1TEdxVjFBd3FRc1pi?=
 =?utf-8?B?L0dxM01FYktVMXc2TEN6S3lScUFtc3NnK21sSXhWcTZDTm9wdXFWMVkwRkRp?=
 =?utf-8?B?c21OQjdCY01IYWwydlgyYnhybHZjcXA4bDVFWENJL1d5M24yQ1FMQnVaTW82?=
 =?utf-8?B?UEszZjBITHRvbk94WUVFYjczMXB2MVUzNFc1MzNOb01NaDNYWU9KMjZwSFA5?=
 =?utf-8?B?YkN3VEFBaVFGOEJDSS9NUHVpblRzQjhYbG92YU0vTmh5cG5Qa25WcVJpS0dp?=
 =?utf-8?B?WjRBOVBwVlVjYVlLSGlvVjhpcHpmdkY4RGh4bWoxcWQ4NUFUS2FkN2JEUEpE?=
 =?utf-8?B?SjkvYWtJV0dTTCszN0x4U0d0ZTFZdVk2MGVlWTlyT0hVZDF4NTIxeW81em9X?=
 =?utf-8?B?Ymgwbjd5ZXhDRG5ZZnF2ZmtSZC9saSt3OWFVRm1oTnRLV21lS3lNK2NBKy9h?=
 =?utf-8?B?WU40SnZZTFo3UzBlcmU1MWhrM3VONnNJTXFyR29RM1VOVkxLM2pDVjFtaVp1?=
 =?utf-8?B?UlFuN3ZnaGhIWkFjUG9HaUwwMmJqb1kvQ3VqUWhVWWl2ZFFDdk94U2VQaktj?=
 =?utf-8?B?Z1pIaFFBVWlJVzFPM3NSQ252ZGdydkFaNkJtMUFobGRzMGJqN3hGVytSYzhv?=
 =?utf-8?B?bWFoRnVuMmFuY1EwSEMwRi9UZkg0YjRvYXl5ZFZ2N3FDUjB6Y1pXdVNFZ2VP?=
 =?utf-8?B?d1BYTnFENXdKVE1jWFZKY3Zqc2d6R1lEQWNyWjN5ZjJ1Nng1YzhHVXA2NmZo?=
 =?utf-8?B?OXdBb0JaKzFDZ0xKcHp1cG1Wa0FkL0huV0pJVEp0bDhrRjMzQUJYc0p2cG13?=
 =?utf-8?B?elo5cUgvbkQxZnVsRkp3MXJiOUlEM1RoV2dhSC80MFh4THVQbmVLWlVmK1R4?=
 =?utf-8?Q?yNlRpumCuiHkVnps=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <D682B7665033D14BBDCC3BC61FCAFE13@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 031b094d-da9e-4df3-20b4-08d9ea4c781f
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Feb 2022 15:14:00.2262
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: GGIGBrab+YMxlS4Yak8y++fprr84J6teSJG1BcTc53kOu/RyGPPM2/qmR5IAmO21PS7ZcTtTxXPufS7CsfO8V+GXPAwgpS2lFm8U4j1IMw81NaDEw/MNxAUx6TJBUVjg
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR03MB3579
X-Proofpoint-ORIG-GUID: 12i6N7aPE2unoUddlVMdLuD6HzEXecMx
X-Proofpoint-GUID: 12i6N7aPE2unoUddlVMdLuD6HzEXecMx
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-07_05,2022-02-07_02,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 adultscore=0
 clxscore=1015 impostorscore=0 malwarescore=0 mlxlogscore=627
 suspectscore=0 spamscore=0 bulkscore=0 priorityscore=1501 phishscore=0
 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202070098

DQoNCk9uIDA3LjAyLjIyIDE3OjA1LCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMDcuMDIuMjAy
MiAxNTo0NiwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+PiBPbiAwNy4wMi4yMiAx
NjozMSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+Pj4gQnV0OiBXaGF0J3Mgc3RpbGwgbWlzc2luZyBo
ZXJlIHRoZW4gaXMgdGhlIHNlcGFyYXRpb24gb2YgZ3Vlc3QgYW5kIGhvc3QNCj4+PiB2aWV3cy4g
V2hlbiB3ZSBzZXQgSU5UeCBiZWhpbmQgdGhlIGd1ZXN0J3MgYmFjaywgaXQgc2hvdWxkbid0IG9i
c2VydmUgdGhlDQo+Pj4gYml0IHNldC4gT3IgaXMgdGhpcyBtZWFudCB0byBiZSBhbm90aGVyIChi
aWcpIFRPRE8/DQo+PiBCdXQsIHBhdGNoIFtQQVRDSCB2NiAwOS8xM10gdnBjaS9oZWFkZXI6IGVt
dWxhdGUgUENJX0NPTU1BTkQgcmVnaXN0ZXIgZm9yIGd1ZXN0cw0KPj4gYWxyZWFkeSB0YWtlcyBj
YXJlIG9mIGl0LCBJIG1lYW4gdGhhdCBpdCB3aWxsIHNldC9yZXNldCBJTlR4IGZvciB0aGUgZ3Vl
c3QNCj4+IGFjY29yZGluZyB0byBNU0kvTVNJLVguIFNvLCBpZiB3ZSBzcXVhc2ggdGhlc2UgdHdv
IHBhdGNoZXMgdGhlIHdob2xlDQo+PiBwaWN0dXJlIHdpbGwgYmUgc2VlbiBhdCBvbmNlLg0KPiBE
b2VzIGl0PyBJIGRpZCBnZXQgdGhlIGltcHJlc3Npb24gdGhhdCB0aGUgZ3Vlc3Qgd291bGQgYmUg
YWJsZSB0byBvYnNlcnZlDQo+IHRoZSBiaXQgc2V0IGV2ZW4gYWZ0ZXIgd3JpdGluZyB6ZXJvIHRv
IGl0ICh3aGlsZSBhIHJlYXNvbiBleGlzdHMgdGhhdCBYZW4NCj4gd2FudHMgdGhlIGJpdCBzZXQp
Lg0KWWVzLCB5b3UgYXJlIGNvcnJlY3Q6IGd1ZXN0IG1pZ2h0IG5vdCBzZWUgd2hhdCBpdCB3YW50
ZWQgdG8gc2V0Lg0KSSBtZWFudCB0aGF0IFhlbiB3b24ndCBhbGxvdyByZXNldHRpbmcgSU5UeCBp
ZiBpdCBpcyBub3QgcG9zc2libGUNCmR1ZSB0byBNU0kvTVNJLVgNCg0KQW55d2F5cywgSSB0aGlu
ayBzcXVhc2hpbmcgd2lsbCBiZSBhIGdvb2QgaWRlYSB0byBoYXZlIHRoZSByZWxldmFudA0KZnVu
Y3Rpb25hbGl0eSBpbiBhIHNpbmdsZSBjaGFuZ2Ugc2V0LiBXaWxsIHRoaXMgd29yayBmb3IgeW91
Pw0KPiBKYW4NCj4NClRoYW5rIHlvdSwNCk9sZWtzYW5kcg==


From xen-devel-bounces@lists.xenproject.org Mon Feb 07 15:23:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 15:23:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267126.460836 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH5rZ-0006ta-PS; Mon, 07 Feb 2022 15:23:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267126.460836; Mon, 07 Feb 2022 15:23:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH5rZ-0006tT-M6; Mon, 07 Feb 2022 15:23:33 +0000
Received: by outflank-mailman (input) for mailman id 267126;
 Mon, 07 Feb 2022 15:23:32 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=owYM=SW=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nH5rY-0006t7-9q
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 15:23:32 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e82651aa-8829-11ec-8f75-fffcc8bd4f1a;
 Mon, 07 Feb 2022 16:23:31 +0100 (CET)
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2058.outbound.protection.outlook.com [104.47.8.58]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-34-_FTcQM1QOfyTVz68aXFNOQ-2; Mon, 07 Feb 2022 16:23:30 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by HE1PR0402MB2761.eurprd04.prod.outlook.com (2603:10a6:3:e2::9) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Mon, 7 Feb
 2022 15:23:28 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.018; Mon, 7 Feb 2022
 15:23:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e82651aa-8829-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644247411;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=MCeSFh10N9Ftigv8rn7PHORI3Qhf5yu5FxYcJO10plM=;
	b=Dt7po/gF7JCN9yqbdkmIYvf7YqTM0Bam+v6C0NLO5rCIvoyIgtsc5eMQIV+HF3mzeH82Uj
	hfC1Pc8ePU3NgsnF5RE3noj8PyrpbjmOijM56mw35rLM254xjHpTAueCz3JFYruy91ciPO
	BvR7+s2ZenCS36c2e/h7x05hxhqg28E=
X-MC-Unique: _FTcQM1QOfyTVz68aXFNOQ-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ZOUUs8a9G5zGMnx9HaY67MmG3iJPNmYSGXSDI/Wsbzkurxb4ALd13Y9Zq4OQx5PXODvNIheq0QXooeZCdeggBDpd23CcxGj+/4+Pq5PGnhmheDsWxIAiBCmYkp7bbWUykOoBWAe6aYnCRtmK6Y9K0pBCad22F9wVvB9qj8pNhy4Qe7pOrDzSYdYLKNhK0VStHtOU9vbmcbp5FIe5YDH0OsKMdq79bekBAIWS+bfsmR+TEJECnNqBnRPv7KpJ+2M2QB9uXNipRnTSW2u1pF7mI2Jr/1dKMOGIfRV5aDIQ51AnbeN+1XK9xiQVh0sdwHXVuRu1Hxe4WMtrd+GJk2RfDw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=05l7ZYLdRIwwriqqWm0poDjmnN1jNoCs55GRcALMQKU=;
 b=cj+aWaAgbj+YNocVGT4s/z1cNK20TX2H6K2V56sQmy55S2Z66CKgdP3fEGv5HKLV4ihikFDcBmslejemL2G9sLGAxPAHshuCH2Q9Iru2qVssXHGdVye+8u1UD0VOqk59yCVzjavO5G9allORMIPW6HMKa8PTuM+CkQ6T+ml1+nDlEVB5aga7bdC0Y3Cha0Vgt7noqj0iXBI9F9vB0DfTkhEb6d7SEXQXaJYsaHcVrrXoZacZIoSJ/kHx6TSoV1poFXeKY7hefmNGemHFtTPYhlGsFZchwA+3OSfqueRXYchcbK/1pJHv3ziYE19uPzQ409gEGt29kD1rE8TLuiF4Zw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <1425efc7-42e9-bb50-8db7-356fe1db1477@suse.com>
Date: Mon, 7 Feb 2022 16:23:26 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH 08/16] x86/P2M: PoD, altp2m, and nested-p2m are HVM-only
Content-Language: en-US
To: George Dunlap <George.Dunlap@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <Andrew.Cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 Roger Pau Monne <roger.pau@citrix.com>
References: <d1fd572d-5bfe-21d8-3b50-d9b0646ce2f0@suse.com>
 <694a6590-0018-223a-c796-3e1469ec354a@suse.com>
 <0C051DFA-9147-42DB-AA36-0DED3D192F43@citrix.com>
 <ccc16e12-2036-d71b-5521-71685f0ab38d@suse.com>
 <E8945018-F8D5-4930-8E5B-ACBCB039BC2F@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <E8945018-F8D5-4930-8E5B-ACBCB039BC2F@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS8PR04CA0072.eurprd04.prod.outlook.com
 (2603:10a6:20b:313::17) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2cb19420-b091-4730-92fb-08d9ea4dca4a
X-MS-TrafficTypeDiagnostic: HE1PR0402MB2761:EE_
X-Microsoft-Antispam-PRVS:
	<HE1PR0402MB2761115C8622361A4752CB87B32C9@HE1PR0402MB2761.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:800;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	gnwegLlZOVFHjZACYHs25L4jY0gGWq9F2GUFu/GLc599sj/0Hv9uas0MSijt67xWAwR3/HlKxSjt5xNEpSlX/H/0ThCTRouOv33Oz9FuZrQ3dWluFih7ttP3+DwIPP3RBBOydxPh/r2FH850rC7+EoznoqQe0Sw4WU4Uk+TTm1lGLsqNWa2wl5sZ1g0plOHaOfmR1PyMSKQ+9Iw3zfSjECMLXJ9JzmCQ6rM4Gzj8nsOcDnIRxYOyeOkdaV39yjNxwrQANM4TYKKFo+gEDyqoutGx9aY9kNKhL2YUPellxptiI+P2Gu1CC+vcHE7/J65NnuTSmzf4ZHFHNl3SxUo1EM/0uGCWMlN1II6dcDe49aEo90T3IqfT4HCvtNHngBwM3f/rJj/v0zpOOJG3BKgpu30Unym5sjrUZ/Vfps+fvHl5cUbeh5rX7roFlQzVcnB3icz01NkwJhDyd9BZ3ARPXv7YuWnSsx2/qIYARFN4mCV6vnqhugw+gBsrb2JuvoHY6gFVJFs0Y7Qk0zoh8Ryr2bCrk+6VEyJRGJmDrqzobeo0u90wljhgvd5RhzA7p3vXYKPrWnvWwEYreSG8zCU9YPQf1ahotyGFXn9SZ+aA6IeGXzaS/64R+3NP4qGZpZOURvFe9kqraf6XAFARvTUk82fG1e0Fw3xy2A+QHPo5RldKxC6cIWoZ1S671Wr9oS3WcvfcLBBJg00NqxgrJ8nRON5RMdxCz7vyGSfDolZKr9w=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2616005)(66556008)(4326008)(66476007)(8936002)(31686004)(8676002)(83380400001)(36756003)(508600001)(6486002)(26005)(6506007)(38100700002)(86362001)(31696002)(53546011)(5660300002)(6512007)(66946007)(2906002)(316002)(6916009)(54906003)(186003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?sIu9THsDPddUBqoErqKoYjZpX8F8AP9SBImXyJVjvO20y4FNce6jJi/oVXZd?=
 =?us-ascii?Q?bVqg4cFJAJoG+pwhAgmwRxCrFXPm3tH4jBSEJNBrXEqS63bpxwr9AN8+qKqL?=
 =?us-ascii?Q?zFnCCnJdxFhCmis6+46eiWNPAwbGufw+KrBkl3aMPx4jdmu5fI3S8S1RT2qP?=
 =?us-ascii?Q?LJ7YdMfQJQLmE6zxiyAEq767CGp1SV3iylIO0dkcW3va2mw+AT/Nf06sd2a8?=
 =?us-ascii?Q?Px6Us9GsAqI2qlNiFuUr745DMATgwb5rO3fAu0uPSf2c5FBqesKdsFRJ9HJ/?=
 =?us-ascii?Q?/dVi4Iz++q5fMsPwNMDQhQRUV2KS2nyUY88mwbwi2uDdAMS0eLNo/HKrgeHM?=
 =?us-ascii?Q?G/yFvemcwlWWdm/skAqphdL0YyHrcqWKnJtbASTqS4ovHL1/0R34I7FgXz+3?=
 =?us-ascii?Q?OQ6vaxFk1NzL9y11IqRQws09CJayFIVpIX+6juf/2JwMaxWvaMTAL9CpKLvO?=
 =?us-ascii?Q?Lvvx1Qq8hmK+ywjWYhS3AUeGWZvu1h/JsZcu7lek65TQaAWqGOSrVb9f6poI?=
 =?us-ascii?Q?a/LmEBrtw0ZBEQ/DTGflJM/y2H0MYxLQ52S3NW2epilZLJ93wsgEk0fwKqi9?=
 =?us-ascii?Q?IDUYRBQBGrhHCtkhToV6FG332EdEqjAs6uA5BrhKOA+Fi8U+Cmcs3BheCaz/?=
 =?us-ascii?Q?vQB4/AEPBPrVgUKMx5K1mRrs09vgWw/niJY8WPHXi4PakLkHXrd9KJwdrNq8?=
 =?us-ascii?Q?WupVafqjBW+HquL0i396QcOstKN5qQg/v8SlFo7YbhoeX2sQR24KFqmbJx35?=
 =?us-ascii?Q?SputDjFw4/1BtBpuBWijsDjTnB5Ut+SlqDENpBcsxTIyLdB/f9njV9Oh0b55?=
 =?us-ascii?Q?Ewtx+ihzQQKlgOM36k/TU+x/M9dSBJdiHnSIy9xHPNdrt1b+JdnwXX843xSy?=
 =?us-ascii?Q?wXSeE2KT4mVc0xLllSsBCzpEzqyq+d8gS0JrrakmX+UHHSHT2culFvMJ5XUB?=
 =?us-ascii?Q?xi8T50yN9++pqmLHaAGMyIBFrkIqd8yImNWxsmuG9yh6egOD/kVoNUc4fU5t?=
 =?us-ascii?Q?4gWR/xYvh93shpC72JPBbd57gVjY9LbUwJwS0x9zr7ol9Ke164qfBx7yeDRA?=
 =?us-ascii?Q?Z8TXrCecdGK8sdjdmFVx+hPG+ASImHVAU4N32a1DKsvpkTCLBkJ1jDiRwvXi?=
 =?us-ascii?Q?p5ELoLd9aSJgX6cSXE8buy9mT1Qu8IfrL8WbaAq7azST9IS2Q7JawSY8oqBL?=
 =?us-ascii?Q?1xL3UjWqdwoyQdkheX6KkqXoLHPcOA430wANHGl0CW4S5jET3Fl62dqIPMFn?=
 =?us-ascii?Q?Lt2ra8DlCEmePh0Wpq/zj01ADVQp16OzSczEGEfpBl9t4HyVn5izpG+QFMbI?=
 =?us-ascii?Q?s2HtmoL0l8hJ0aHDqk5CUaFvipyYoQbpXbWUDohaLQ2O/u/6TIhWtt775eAQ?=
 =?us-ascii?Q?WsVW5XZw9m6SQMT+Kkt5Y8MsCxJiUVOwsQgT3PMFOheA6qDWKHuYWKuynX31?=
 =?us-ascii?Q?cGI4qehPaD93i3GY+2a6JueTdhkQdXKWg2EaA/r1cUmakzQ7yQBG4oyLeGS4?=
 =?us-ascii?Q?aND9Puh4+HgFIj3kLDpTcxvA7uHcLdXHjk2fZckdVKa+MJjzWuE/EVyNHP6n?=
 =?us-ascii?Q?eL5P5FZoEPLstk2n4o1J2bgoqfoL2uwMZrrogxuCRv4/s1rnmiohc3frWXT2?=
 =?us-ascii?Q?vFqbViA51XXZ27fk5KsyOHA=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2cb19420-b091-4730-92fb-08d9ea4dca4a
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2022 15:23:27.8464
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VC/QNd9zuDqsVwQThiLpHGwdoabMLBkWPsm/ZUomx790iTks1gNo/xRnrb5d7DBfwQRAELcj8bcaxrFs9KKwBA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0402MB2761

On 07.02.2022 15:45, George Dunlap wrote:
>> On Feb 7, 2022, at 10:11 AM, Jan Beulich <jbeulich@suse.com> wrote:
>> On 05.02.2022 22:29, George Dunlap wrote:
>>>> On Jul 5, 2021, at 5:09 PM, Jan Beulich <JBeulich@suse.com> wrote:
>>>> --- a/xen/arch/x86/mm/p2m-pod.c
>>>> +++ b/xen/arch/x86/mm/p2m-pod.c
>>>> @@ -1135,6 +1135,12 @@ p2m_pod_demand_populate(struct p2m_domai
>>>>    mfn_t mfn;
>>>>    unsigned long i;
>>>>
>>>> +    if ( !p2m_is_hostp2m(p2m) )
>>>> +    {
>>>> +        ASSERT_UNREACHABLE();
>>>> +        return false;
>>>> +    }
>>>> +
>>>>    ASSERT(gfn_locked_by_me(p2m, gfn));
>>>>    pod_lock(p2m);
>>>
>>> Why this check rather than something which explicitly says HVM?
>>
>> Checking for just HVM is too lax here imo. PoD operations should
>> never be invoked for alternative or nested p2ms; see the various
>> uses of p2m_get_hostp2m() in p2m-pod.c.
>=20
> The fact remains that it doesn=E2=80=99t match what the patch description=
s says, and you=E2=80=99re making me, the reviewer, guess why you changed i=
t =E2=80=94 along with anyone else coming back to try to figure out why the=
 code was this way.
>=20
> If you want me to approve of the decision to make the check more strict t=
han simply HVM, then you need to make it clear why you=E2=80=99re doing it.=
  Adding a sentence in the commit message should be fine.

I've added a paragraph, but already after your first reply I was
asking myself whether I actually need that change here. It's
more of the "just to be on the safe side" nature, I think. But
it's been quite a while since I put this change together, so I
may also have forgotten about some subtle aspect.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 07 15:27:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 15:27:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267135.460846 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH5uz-0007XO-7x; Mon, 07 Feb 2022 15:27:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267135.460846; Mon, 07 Feb 2022 15:27:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH5uz-0007XH-4x; Mon, 07 Feb 2022 15:27:05 +0000
Received: by outflank-mailman (input) for mailman id 267135;
 Mon, 07 Feb 2022 15:27:03 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=owYM=SW=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nH5ux-0007XB-4m
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 15:27:03 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 65b5b22a-882a-11ec-8eb8-a37418f5ba1a;
 Mon, 07 Feb 2022 16:27:02 +0100 (CET)
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2054.outbound.protection.outlook.com [104.47.8.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-25-Os0zWyWPOW-wZ-5sth2Zfw-1; Mon, 07 Feb 2022 16:27:00 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by HE1PR0402MB2761.eurprd04.prod.outlook.com (2603:10a6:3:e2::9) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Mon, 7 Feb
 2022 15:26:58 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.018; Mon, 7 Feb 2022
 15:26:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 65b5b22a-882a-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644247621;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=QpGu4kVAeVZG2Z26ppMJeIHhbkIH9q871b3Gy7eOgMI=;
	b=mlMfBbgBCCUo3httgCqIVGOu7A3kco9zPsfR00nPg19i9WNxi9wuEYFQzTy/W9CKHYvx8C
	7WExnVbr6c/Hn0pNyo2kayyHo9B75GxhVn2v+8RGxfkqe0abG3R2QaqwqSqPcBdw2Bhphs
	wGEmLUxA7+wHM5KCj5Hamzi6xsxpY6w=
X-MC-Unique: Os0zWyWPOW-wZ-5sth2Zfw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=S/0ZpW9tA3bs3dD7ukAVC306LZ4dZ9Oy349RMcXzAGnyTp0rhK3NZqXMd0FV3jOF/mzCxnaXI1CxO+1xGc6IMnc2HzqO7J93JXM9R8DgR/SyIhj6WngJ8yiHgREE2kngJ0E0Ffdd82UZcO7ZE2lJkXNWwIkB4N+jwlshxSWkwI6uEZtFutr6zhgYI9+ULFkN7ApKmbl1T8J6GxRNHdmqgGEzzjF8Yo6/+taUDiYJMEABCeMu2uxcdQIG0B0Jk50XKQMbscTGHdfSLTaRn5S+05ys6f+VR2mxcmrgN39/Gast17M3YdRZKN4sdyKrNAh/tAxFZAh7fzjPQxhJfG8zmw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=0/4gJ9De7Bte+knbZCCadeMWEbTc2zuA08UDK9acSz0=;
 b=ap5u9EuliktG4YphGfHzMItkK/yYFz51sCX3LDqAdH6NhDPBSxFgHH4LFrrgl6XIi62u+TWinuc00ybo7bgTQ+OOwoeNGxnz8YKYle9mMiYApmKj5uqshJiTUuIJAFgRfn/Egfp/kmcEynwGDyNCLeHR5k21TQpSDgrlOpkOW8CuekjdiLuhH0bFUWTXuTZ0s/A3Y7ttU8R+9bhKpL/Sf2UG3+gFnKH6Ii8BNq4N+hV1noN9her5ktBQovk/fZpgESVDgcFGz3DGx8QXrkmIZmPlCjF27F2Rgz2Evb/EHvbdbEknObRhVWXKlYUROUmA/RLwdSvKn6Q10CPkce0+fw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <21c8125a-2f79-1a4a-494c-db9e4be2a1a6@suse.com>
Date: Mon, 7 Feb 2022 16:26:56 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Content-Language: en-US
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: "julien@xen.org" <julien@xen.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Artem Mygaiev <Artem_Mygaiev@epam.com>,
 "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
 "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
 "paul@xen.org" <paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <7e3562b5-fc67-f213-e872-f211450d9e2e@epam.com>
 <a8fc599c-f620-c4d1-2077-c57068f46a7f@suse.com>
 <deef8468-d607-e49e-f456-6a8013329ca1@epam.com>
 <Yf0k6aoKK5G3iad1@Air-de-Roger>
 <3ad10a99-c706-b95f-1419-2c0c7cf37d58@epam.com>
 <Yf0+3C9nF8+tewLw@Air-de-Roger>
 <c5fea3bb-834b-eeb7-d7a1-1ee609037a9f@epam.com>
 <YgEUwTxhnWVMGMJK@Air-de-Roger>
 <9ce90193-74a0-5642-d22b-6b8c3340c3cf@epam.com>
 <1f65ae7a-898d-2c27-0ada-d71d778b0627@suse.com>
 <YgEsRuckQJIQlkzf@Air-de-Roger>
 <a2a42c1d-d379-00cd-5d55-f443cdb02e97@epam.com>
 <e8fc7872-c7d0-f389-c507-335b809ffcbc@epam.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <e8fc7872-c7d0-f389-c507-335b809ffcbc@epam.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM5PR0301CA0007.eurprd03.prod.outlook.com
 (2603:10a6:206:14::20) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: fb0efeca-5f1a-4b1f-a19e-08d9ea4e47ce
X-MS-TrafficTypeDiagnostic: HE1PR0402MB2761:EE_
X-Microsoft-Antispam-PRVS:
	<HE1PR0402MB2761D5C3F092B5F37B5B52DDB32C9@HE1PR0402MB2761.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	QSQtm5l6xQN24+9it1vumHqugXIVC4f5QwNVC7q0rfiP3gddKJtPdyN7I27WgymluAwfzyUCSvf4Su7GNEqMnHT7p0zrxNDs7jlEvanQGPznmlgARzY5r2V5gta8nYT/2Nk85/bhnabqc0yGv6u87GiHgbtRw3SptO9fS7TI149jJ4EiPmhqAWBV77V/RxtuDXGGApo7JSGfKGTUl1xR4mv+/Hcr1dETXKH3iTJNcJto8hurGUx1/CM1tDMcEhQjGVAmfubR7TcgDoYyvCxHsZlxlq6iBvv6vaRIjdQxgByd2PqgltFnjTMCp5c2mareUt3dEFrLruwGopZYvPUJ/li2L+GcFtLvIsujmXaiJIbAYhG83kAWI0lKT0dB+BCj2kJxDKZPOhq81bm5TwtDhj+GnRr4R6MNuwo0pTCXQZ2Ga1X2Q9TcduHypV2EeP2OJTg6mBz+2VkqcAyx8/MMC1iOrxI1F9Zxq8d84Ti5Bgtig+/crmHAJ6AHIIUWpQv6Zaqbu6OxVJ1XfO6H7SKwcj8TlQDmPy9IAuUE7LXewewExSIRgWa7qFqaScHWvxRSDyeNHIrHzAvagpf5fE6tJwsd/npkk02A8ObMvLSxc8EtwqkRxfufAspyhhj1EIqtPx2ty7xNsjkZfey1bpuLzj75DrOT38MHYx8NqVY9jYpgpdtMpOUDsCdbnXvrPuk6dwJA/+nYwkayLAfVuCsjNX/2JP4dfVj2P/6lMpXwv8Ih0ZzxMtX0k5pNzNd/gUolJtcmO4s14oT+gPqDfX5xlOtiO2uUsOOxpTmBk/+0ateKx3u5MdfflJV5cskOfH9f
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2616005)(66556008)(4326008)(66476007)(8936002)(31686004)(8676002)(83380400001)(36756003)(508600001)(6486002)(966005)(26005)(6506007)(38100700002)(86362001)(31696002)(53546011)(5660300002)(6512007)(66946007)(2906002)(316002)(7416002)(6916009)(54906003)(186003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?SthCRT+H3FR4zxRpxaekTJ6HNVu256ZePzAwDmah0MDyR0UYY8ofh4Iv79b4?=
 =?us-ascii?Q?GWUCXKJz3neB/KwsD9e0VZsd0lmHoH9AY0tYcN/vMcCNhPLNSgrkcEUaB7IT?=
 =?us-ascii?Q?0whN5csk5i4orWpnomihxOBNixpog4ue2ZbSN0JaLNKNEH6qvpIL+1XqkbRG?=
 =?us-ascii?Q?dFwUe02vngZIYzxs8vZTPPPqI2zwi0hW9P7mjOLztVAmgehi3qLsU1XuZmOz?=
 =?us-ascii?Q?68D5Xe3SslsNTWf3gR89LrMMwcEEKpiSmn0a9j4Adiv8TAyaKmT9BIJK/uRk?=
 =?us-ascii?Q?7N1X7pp5Bcb69RNaZkQ3lwK49o3+PeUAh3ntqSt7DB7NeZraiTfYb66qHBOb?=
 =?us-ascii?Q?GiH07NoORtVzsSf0dNAgziRXEjp+sxE1xYo66H9C2fcpmwCwSZ4cp8whF03v?=
 =?us-ascii?Q?Dz+DG5LnsS4AM05USluwdfoOyNHQxn1SFXJGh1fLjx/IWHC09kXcm54cOLOj?=
 =?us-ascii?Q?PlfzGCGLkTDqUBvrmXURQmDqftqTmlYkA1FRjKai8Q9a4mTq8dZ42okQogOW?=
 =?us-ascii?Q?+OkNT29bdgfGOEgOtRypnIs81VpuZKij4uv+sBBe5dICz3WLg8xkPTQO5qjZ?=
 =?us-ascii?Q?35SWhRw4mRgNvxnEUmEyihv5wqGkvRUcQ0n0rTu293HDRS/ujQyuIy/UZzOq?=
 =?us-ascii?Q?toX1vnmqdtPjaQsBrW82gzhTG0lVwJiCcl+teIBCN1ObyGHtKAXWM/bEWBbG?=
 =?us-ascii?Q?MY3/wOrBfie1/0bcujzx+pAKwa+nBJsa73DznkKj/jETxzSSkWHHz/RiPuw2?=
 =?us-ascii?Q?Z0LtgtGLMnuZSVFQWu9TXGdJ17gJY7KVIpbdnEAUAseH04NTX3FLmO5XrJJ4?=
 =?us-ascii?Q?e0bjEoqA70XXyvATxFaBArv64tniLHaKyQ4bzZse94ajEGaOTLfLtJXJU5Ai?=
 =?us-ascii?Q?4Ek9wOcVGIn4odfaatfHgAF+8IjiPIyax7Kk5pw28l+vbUPYV3aOAi4uj8NN?=
 =?us-ascii?Q?7/6AsXD/P+PO4yGmUlsv9Oa6BfbEnJf/f6hKv16nj+Lh36WYrhTZVSq9RSdh?=
 =?us-ascii?Q?0QH7xH7P4C4/36iIBfZ7u/p7/tvnmebRRVR19BQxVN+XnK2WFY2nxtOGu6lf?=
 =?us-ascii?Q?5/YlR7g7KO7gxbPbwYRQUUXtyuTit5BGDuiHlLNHyvj4HSqZU02gIAM9cl01?=
 =?us-ascii?Q?sKk1RJHqdKJEZqBqhCBclY/QCJeN4LKhaAQhgm+NENy0/qVvRrkzs6o3KtCq?=
 =?us-ascii?Q?+wG7fMYdZj5dfiBdUOuZ/G8oyWHb/6FLHfGpPdxX4tv6afBWD6LrIKvLizq0?=
 =?us-ascii?Q?XvIH8uREYwSHPxNy+9mx7EMmASnsLX2s+Z21N1R97CGXtrJk5hc6v2aRn3OP?=
 =?us-ascii?Q?5kllpJvz13Nhv6ufox6lof7nLS5f2WG9zFMlIhQJTQuG4A6ray9UA48kN1dt?=
 =?us-ascii?Q?noCIU4Zh5q91Tty8L1YKtdJxNPnC+SeqMFnzUcwTSle/L3lkIJ3jqJaMH0gu?=
 =?us-ascii?Q?4MI5MSMagrTbO0I+LiJvvUOGwPgsBQpIUJa5shO0k4Ar9RKQVPIJ4e8avZWC?=
 =?us-ascii?Q?nvkoPycdFwPTwaZkU97iswloaD/9jRURdadFcfN3jGAENCJG/MkLcEqeVAsY?=
 =?us-ascii?Q?NTONWsxLt58gd3cn23gmisaK9WQVBNkns2RQ3/9CHq8xuLEaPBhyIBxdg09C?=
 =?us-ascii?Q?6wwQ0K/aM7wAJ9+d6T92SVA=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fb0efeca-5f1a-4b1f-a19e-08d9ea4e47ce
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2022 15:26:58.4114
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EBtW2F54Vq5MSJpMDFm3LGAA9Pii29rGGu6E9nSJE/5CS/3UfUfdAxHMCM4BGf5MZ/CBwinr02iRKcx55hwRWg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0402MB2761

On 07.02.2022 16:11, Oleksandr Andrushchenko wrote:
>=20
>=20
> On 07.02.22 16:35, Oleksandr Andrushchenko wrote:
>>
>> On 07.02.22 16:27, Roger Pau Monn=C3=A9 wrote:
>>> On Mon, Feb 07, 2022 at 03:11:03PM +0100, Jan Beulich wrote:
>>>> On 07.02.2022 14:53, Oleksandr Andrushchenko wrote:
>>>>> On 07.02.22 14:46, Roger Pau Monn=C3=A9 wrote:
>>>>>> I think the per-domain rwlock seems like a good option. I would do
>>>>>> that as a pre-patch.
>>>>> It is. But it seems it won't solve the thing we started this adventur=
e for:
>>>>>
>>>>> With per-domain read lock and still ABBA in modify_bars (hope the bel=
ow
>>>>> is correctly seen with a monospace font):
>>>>>
>>>>> cpu0: vpci_write-> d->RLock -> pdev1->lock ->=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 rom_write -> modify_bars: tmp=
 (pdev2) ->lock
>>>>> cpu1:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 vpci_write-> d->RLock=
 pdev2->lock -> cmd_write -> modify_bars: tmp (pdev1) ->lock
>>>>>
>>>>> There is no API to upgrade read lock to write lock in modify_bars whi=
ch could help,
>>>>> so in both cases vpci_write should take write lock.
>>>> Hmm, yes, I think you're right: It's not modify_bars() itself which ne=
eds
>>>> to acquire the write lock, but its (perhaps indirect) caller. Effectiv=
ely
>>>> vpci_write() would need to take the write lock if the range written
>>>> overlaps the BARs or the command register.
>>> I'm confused. If we use a per-domain rwlock approach there would be no
>>> need to lock tmp again in modify_bars, because we should hold the
>>> rwlock in write mode, so there's no ABBA?
>> this is only possible with what you wrote below:
>>> We will have however to drop the per domain read and vpci locks and
>>> pick the per-domain lock in write mode.
>> I think this is going to be unreliable. We need a reliable way to
>> upgrade read lock to write lock.
>> Then, we can drop pdev->vpci_lock at all, because we are always
>> protected with d->rwlock and those who want to free pdev->vpci
>> will use write lock.
>>
>> So, per-domain rwlock with write upgrade implemented minus pdev->vpci
>> should do the trick
> Linux doesn't implement write upgrade and it seems for a reason [1]:
> "Also, you cannot =E2=80=9Cupgrade=E2=80=9D a read-lock to a write-lock, =
so if you at _any_ time
> need to do any changes (even if you don=E2=80=99t do it every time), you =
have to get
> the write-lock at the very beginning."
>=20
> So, I am not sure we can have the same for Xen...
>=20
> At the moment I see at least two possible ways to solve the issue:
> 1. Make vpci_write use write lock, thus make all write accesses synchroni=
zed
> for the given domain, read are fully parallel

1b. Make vpci_write use write lock for writes to command register and BARs
only; keep using the read lock for all other writes.

Jan

> 2. Re-implement pdev/tmp overlapping detection with something which won't
> require pdev->vpci_lock/tmp->vpci_lock
>=20
> 3. Drop read and acquire write lock in modify_bars... but this is not rel=
iable
> and will hide a free(pdev->vpci) bug
>=20
> @Roger, @Jan: Any other suggestions?
>=20
> Thank you,
> Oleksandr
>=20
> [1] https://www.kernel.org/doc/html/latest/locking/spinlocks.html#lesson-=
2-reader-writer-spinlocks



From xen-devel-bounces@lists.xenproject.org Mon Feb 07 15:28:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 15:28:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267142.460858 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH5wh-00086p-LK; Mon, 07 Feb 2022 15:28:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267142.460858; Mon, 07 Feb 2022 15:28:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH5wh-00086i-IK; Mon, 07 Feb 2022 15:28:51 +0000
Received: by outflank-mailman (input) for mailman id 267142;
 Mon, 07 Feb 2022 15:28:50 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=owYM=SW=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nH5wg-00086Y-U4
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 15:28:50 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a607ae19-882a-11ec-8f75-fffcc8bd4f1a;
 Mon, 07 Feb 2022 16:28:49 +0100 (CET)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2110.outbound.protection.outlook.com [104.47.18.110]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-37-vWVLXGNcOSi6pMf49fNF9Q-1; Mon, 07 Feb 2022 16:28:48 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DB3PR0402MB3692.eurprd04.prod.outlook.com (2603:10a6:8:2::15) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Mon, 7 Feb
 2022 15:28:45 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.018; Mon, 7 Feb 2022
 15:28:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a607ae19-882a-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644247729;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=IoblLvFqcIPo+HHTIm8PgWsqgdJMWvE442czxCiHNts=;
	b=BMi5POK5UdnGpl0o/3kZrQhLQdeQ/djydGAigB7FKpjcbdbJhiQGs0YHa5Lyy6baavNuqS
	keUgqXXRwkaNc7WBMU0RSZErhpelPAPeZ+R1/lKYKogKKg6cvs7T8uxvpIkcjk4Wg7X3h/
	fwjKMUv5mUnBo4XwEVeyV7N7s+7nBXo=
X-MC-Unique: vWVLXGNcOSi6pMf49fNF9Q-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=AUm4JQYfgAHjyQG6U6FcPPc04/O0Tg/Bc4mHqJFy12rZSBI0bIb4HtpKybdxRHxeUq7qQIiFl+dPaK6VuqtW1GIot90dEvTp+9UtslFaHPAiQcyZZcX/4gJv6s+Q9VzI+Mt31TkTbReoMFLOTHhVm5Amh4dRpuqhThXaLYAtq0hd6Se5C6WD4pbmWabdDsB1UDnuLL56Px4agKLfLnulI0im9TmtaKd9417p5No68KSWXDihDcD3QsERaGx5apRFeb8P7x3+HiEVcZnbVSI59skHGfU72Rack2fe2nhZegxtQ8tNuipmbn+acFbULl8tChu/V7X7vljo5DzJvNeshA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=IoblLvFqcIPo+HHTIm8PgWsqgdJMWvE442czxCiHNts=;
 b=nbKyMPoYB8dyByNJYtKobz+LRfABEu2nBcQNpNd0a1zqFzq/0jHrIxxdSsdRtfLIu9Fj5WHQs0AKK30DDXGTKaQuj068wqSqd0nZuPWwXyCwi8V69ohFqxmUFcvtNl/bqiPqfnIUpSqukF3+HtnJ7dhLWvOs1Fc0H/N/PrRLHr45NkjqvqXNwChRuAQltIAKraNuIHKwJE7zilw6luT0ipRzJ3XEEwLXplDhmOrwh9I8hzMEpcFNWVP+D/t8VM7CQfMyA8s3qsNHJDGiRKUVgA/Ux2EPOeG/D5odGkX9G//QUnSKdtnb3Yy+wMIl+BhSSPFlmYAkstNLOmjEW9zZhg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <06408e4c-3b9b-256c-9fe3-73d9a5383907@suse.com>
Date: Mon, 7 Feb 2022 16:28:43 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v6 10/13] vpci/header: reset the command register when
 adding devices
Content-Language: en-US
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Cc: "julien@xen.org" <julien@xen.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Artem Mygaiev <Artem_Mygaiev@epam.com>,
 "roger.pau@citrix.com" <roger.pau@citrix.com>,
 "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
 "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
 "paul@xen.org" <paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-11-andr2000@gmail.com>
 <96381d7e-dafc-acee-3abf-f9815deb207c@suse.com>
 <ef76faac-f9d3-1cb8-06b5-189ccd299542@epam.com>
 <6f0a015b-c48f-76ed-9a51-39c045ff5927@suse.com>
 <2ad372d4-a181-9307-ef50-a5adb61dae66@epam.com>
 <49380584-0577-96f2-ef1c-a96eabf0d227@suse.com>
 <fbd410d1-84ad-2309-ca05-b9ac7f95f1f9@epam.com>
 <dbef1c95-818c-427c-1963-75d584843cff@suse.com>
 <f34cc940-7f5f-aebd-60d9-d1a3d85d1283@epam.com>
 <8f35e7c5-3193-4b10-ae25-df838e2262c7@suse.com>
 <6b4ea90d-cc9c-edf7-e579-a84d72431d7a@epam.com>
 <f6f16729-8404-6703-11c6-dd7a4ebc658c@suse.com>
 <c5eee75b-bcf3-7e31-e25b-0bf0b217267a@epam.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <c5eee75b-bcf3-7e31-e25b-0bf0b217267a@epam.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P192CA0096.EURP192.PROD.OUTLOOK.COM
 (2603:10a6:209:8d::37) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 04d30859-30c7-4a7a-c01b-08d9ea4e878f
X-MS-TrafficTypeDiagnostic: DB3PR0402MB3692:EE_
X-Microsoft-Antispam-PRVS:
	<DB3PR0402MB369289C5E1489488CCAA5D90B32C9@DB3PR0402MB3692.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	RpNisiF9omLKFSEyNvI2pF8bTCJHnXRCYflhNPqkR541lDDA2ee+c06nXgIDuBI/TPsBc5Wd77fOrdBo4jPaFgNRehYZR/GWG89QPGx63lRp6/+RczrIWomoW95Zi1KdW2cbkA9hws76P6KW3qFGBRZuMWLtOIor/93kFdjE7XFIwthzOn67aQYd2g498vaAab9VwwaOHl6eFBGOiDrPbnaeBwxfUw+MhGPr9G6eORKbOL5PKnHAgwjWqbRqlzwJ/hxJ66lUq+rD2+MFEn4BQYTdREIQgmqZG3racxzsc1hasuN9DzjsTHiSitI1m3nEqEXKImbBTHOHe2UN31s5fyjzoUUtkT4+vYbVmbt1qgj0fit1JqHIII7BkyXjKtkKcP3IBkDR5dcO4GdK8o4icml5JKk+YGY/jMnNtoFpZkON0G3mFu2XX4J6d2xg+Qn+nrota4OIztevHdqm36y3BB+IsqAtZ4g6gae9nN/31dKUBx2z5O6yeeWQg2TIqInmEWvrbO3ZE7D3xtLKaSRO+ITCRBfS6ThsEZlRffNMmjJfffBCWQFS7SPzC3HaT0Ff58IdVlQ5QFCTGWAHWY4nGTOJ/mfLwXnNxsYoCDJRcX6c0Kvt303TDq+DFfb1VWnOn2nF2lNDiaqQQyeMo06RS3rD4CP4fKlQTP26Mh41sHx54lji8giH2q4/gvuD6NnaFTkd8saobg7qi1/Bldj24pTEpXwlvE+bXXplMHYvPMo=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2906002)(2616005)(6486002)(31686004)(26005)(186003)(7416002)(38100700002)(31696002)(86362001)(508600001)(5660300002)(6512007)(66556008)(316002)(6916009)(54906003)(66476007)(4326008)(66946007)(8676002)(8936002)(53546011)(36756003)(6506007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Q3RRMlBmaCtBeTFqeDgwVjIxWXZBTXpPR1RYWDdrVWtRV05XSGxpZUQvcENR?=
 =?utf-8?B?VGpaN3Y2SGxRQ3JxTVpBYWg1SHR5RWM0cjg5NGsvdmlobXBWcEpKSnBsREph?=
 =?utf-8?B?bjl5LzN1R3RqS1ZWS2VVZDloVXRIUlp6Z0FJQjJ6cVB0SUdsL3lDakdldzha?=
 =?utf-8?B?Um5XZjZoMGFvUHVtMVRmUk1ub0loK1NLbkEvUTU5MXJvczBxOXYySnhJRHk3?=
 =?utf-8?B?Q1E5Y3lwUEVwQWE5eitWdlI5VDJ3UFMveWdJVXkvWHhQT2d1YTZMWC9JKzBV?=
 =?utf-8?B?UmlOQ2o2THF3blNGNE9UNkYzcHVZclZ6RTVtbVFtTHlBSFB0NkRlMUNnTGZw?=
 =?utf-8?B?SGpzbkJHSEV5RzBvSzJmUzB2dU9YNmdhYndvS3dkbVA1KzZ1MElLU2poZUdq?=
 =?utf-8?B?S2hGeVFLQlIrcUd5aGhSVGJGb0Q1eElWSGZCdzdaY0hxcUlTSGVzTEJaU1Rq?=
 =?utf-8?B?bVM3bE9GRFFxRFQwV2VHbnRKbFVjKzZtb1ZKWG5DZWFhTFdxeWJha0Z5ajhv?=
 =?utf-8?B?TDhDYjlkOVQ0bDc5T3U4MDNXS1BjNTJDeU81WlJWRFdIelhSWG43Q1k3THJh?=
 =?utf-8?B?NDUrYkpSYzZaamVCQW9uUVdFVk5ZN29kekxvUy9oaWd6TGhYbGYwWDVzQlQ3?=
 =?utf-8?B?cGhTQ2htbjZ4QXdMM1I3eHo5L0cvWExpbGNFVW1aVGhLZlZSeXcweFV3ZXBl?=
 =?utf-8?B?ak1KUEF1emk1TFlUUnZPcHJuQVRYRC94OW9rdmJ2aWtRbTNRTnlBVUtsdTVK?=
 =?utf-8?B?STlXZ2l6RkdkYW1Wc2tkL1J0SlpIeU9XVnFxTjM5eXZrUXMrODJUcVJjanpR?=
 =?utf-8?B?N1B5SmEyOEtLcitMdjhML3d0TURKOTJDL2xCWG53RjF6cWpoSGxJUnUzajFx?=
 =?utf-8?B?bUl0a3BJcnBpNDFFY0pDS2hoVmJmQ3lHQTRNWkU4eWswZGY5dy9WV3NnTDM1?=
 =?utf-8?B?YTRwWm5BeDR5c0FUWVNtYVhER2puU1VSQ01vN0Y1T1lnaUllVWZVZkVmbG5a?=
 =?utf-8?B?K2dYR2FUeFNVaGpJUlFqRENBSmFmQnNBQk9DL2YybWhzSjE0a3QzT1VsZXlZ?=
 =?utf-8?B?WDdTRGlKTjFET2dkUUpuaER2M2N0RVpQL3pXQXRKTGtHeTVyY3NqNzNYWHY1?=
 =?utf-8?B?VnRoZHRZVUlGNXpzYVB4VzlJOGxlcG9qbHIzS2RXS0VqU3NZeXNkRW11eVFX?=
 =?utf-8?B?ZWxoQng3dS91UTAyNXNxb2twazROMkN0TmtlcVdpQVlDMWg2VzF6c2RPOGor?=
 =?utf-8?B?QlBQOFdXaDhYZzZhOFhaUzE3U2piWjJuWk03LzlWVzFLVmFQYWR6N2xUYm1j?=
 =?utf-8?B?Rzl1NzZJdzU3Wm1JKytXblN2ZnpYcHV2d2xObWs4bjJNSXZvM0ZUbVVrM212?=
 =?utf-8?B?anhRZUZGREVUbXhHejROY3FZenI4ZE1paE90YjB6M3FqaVY2Z1k3eUF3Z0JY?=
 =?utf-8?B?Mzc2UEMvY2duNXVZSkcxTHdYSmdBT2hnYXBzZTFFRkwwRHJXZU5zU3E0Y3NU?=
 =?utf-8?B?K25QOTgxUExoRkxScm9ERitORkVPZmE3TFowL2hoZDJBTXZFUnVaT1YxRG83?=
 =?utf-8?B?SDlQVXR0ck5Vd2R6VU9pU0YyS1REQy9hTzNDelNNUFlPWCtnU2NKb3BBZnE0?=
 =?utf-8?B?Y3VsY2IvcHNZOTdKYUNJdnZyVDhLNmdZN3grZ0tpMWQvTkY4MVdWZ01uYWpD?=
 =?utf-8?B?cENlSS80NnRTdlJibk1SSC94UkZYTmhTcUFZUmU0dk5TQWUzVDQxZXVMK29E?=
 =?utf-8?B?V3lOblR6a29sRXoxV0VCZS8wRDVLMzl5SEM0TlJTTWd0cHdjRkFzWUNxR0Qy?=
 =?utf-8?B?b0lTdG5FWVc1SXBnRWxDQWxBdXNDb1FtVVo1bVEyLzFTTkNRMEJXMTMvL2F0?=
 =?utf-8?B?aHBjM1ZXUGhZeE0vWmxmUlE5VXVhaDlFSlJZZXdsRnJIMm9VTTJDMWxyeDRt?=
 =?utf-8?B?bXAxdU9YNjVBZ1Z3VUY2WEVSYVl3VkRCbjZIU2VML2hLODJEYVRUNjNMY3hI?=
 =?utf-8?B?S3RITFZXS3Z6ZDM1d09JRXAwb05PWWorMnNUa3JSM2M2cUZQZm5Zem1qaWVX?=
 =?utf-8?B?bmViVWZLWW95RTJKL0syQjhoYVpUTWZwcjRlR0U4SlZEd28vQ283bm5hRWZP?=
 =?utf-8?B?M3dEeWtEamV3ajhBZmVRaHFndVE3T3JScVNBOGNNNmdoQmtGc3R3Z01QRGx1?=
 =?utf-8?Q?ahRqQL9VdWBUkDOwMODHegc=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 04d30859-30c7-4a7a-c01b-08d9ea4e878f
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2022 15:28:45.3579
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AwOWrgHfVwDoKE5MCOFoXeldIBtA+lrqzlLMaBibolGBekCDna7Bh3UW5K2KxAYztPZemFiZxXnuhzFuvZq+dQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0402MB3692

On 07.02.2022 16:14, Oleksandr Andrushchenko wrote:
> On 07.02.22 17:05, Jan Beulich wrote:
>> On 07.02.2022 15:46, Oleksandr Andrushchenko wrote:
>>> On 07.02.22 16:31, Jan Beulich wrote:
>>>> But: What's still missing here then is the separation of guest and host
>>>> views. When we set INTx behind the guest's back, it shouldn't observe the
>>>> bit set. Or is this meant to be another (big) TODO?
>>> But, patch [PATCH v6 09/13] vpci/header: emulate PCI_COMMAND register for guests
>>> already takes care of it, I mean that it will set/reset INTx for the guest
>>> according to MSI/MSI-X. So, if we squash these two patches the whole
>>> picture will be seen at once.
>> Does it? I did get the impression that the guest would be able to observe
>> the bit set even after writing zero to it (while a reason exists that Xen
>> wants the bit set).
> Yes, you are correct: guest might not see what it wanted to set.
> I meant that Xen won't allow resetting INTx if it is not possible
> due to MSI/MSI-X
> 
> Anyways, I think squashing will be a good idea to have the relevant
> functionality in a single change set. Will this work for you?

It might work, but I'd prefer things which can sensibly be separate to
remain separate.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 07 15:49:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 15:49:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267155.460869 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH6Gc-00025o-GZ; Mon, 07 Feb 2022 15:49:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267155.460869; Mon, 07 Feb 2022 15:49:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH6Gc-00025h-DC; Mon, 07 Feb 2022 15:49:26 +0000
Received: by outflank-mailman (input) for mailman id 267155;
 Mon, 07 Feb 2022 15:49:25 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=wO/0=SW=citrix.com=George.Dunlap@srs-se1.protection.inumbo.net>)
 id 1nH6Gb-00025b-Cd
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 15:49:25 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 845f1f96-882d-11ec-8f75-fffcc8bd4f1a;
 Mon, 07 Feb 2022 16:49:23 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 845f1f96-882d-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644248963;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=MY7Z5FwUiaPGBlJzHz/bNmCDZrW81h1hOhMJKyQZMPM=;
  b=AMT1CzWGjVKDlWexqGRqY74mcDn3eQMW4Anvy3DRRuXB17yFYeRSZh50
   y2bvTcIBwybBls/kITe0LQEpxvGZOB+MRR1tCT8BYiacFmDQHKmjYrIpN
   GMiV5jkKaeBtvPXU+0+Kwck0V3Q11KBdV3ujA9RS8DYe/2nHUOx5Zo616
   I=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: d523P19b6Rg0LPIMo/cyDpWhQJ1Ir6Y5uhxQSl8blDEit1iJsLYp1g6jkD/jpfM+SZT/QTLTBW
 n+of6KM87F5uXZx/c59ClsO3FQiMwK8M2MIMAoZEF6J7Qx6NeZblvwpOoRPO+kqcDm4TE5XNKL
 G6DzypXYdDiQtY4rFHk8sL4ufxJFR6LUsGBKMwSjEEVfIcZMhPaheQd+569vsJmwJW+TxpCSxT
 jnhwb+aoXMgE6rhKK6Cj/hnuxNAHGLDJRhbthpCV53Uyw2R8LoJJi0ytaMxmAPJi+J+x/TGki8
 qUGtRCNv6jOJ8Z/IMNXr0yDp
X-SBRS: 5.1
X-MesageID: 63567136
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:ccr59K97bi8VEnwJOIF4DrUDeXmTJUtcMsCJ2f8bNWPcYEJGY0x3x
 mdMXGqGafmJNjH8KYp1aozk9B5V65bTyoRgQFZuqSE8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhFWeIdA970Ug5w7Rh3dYy6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhXw
 YwQm6aBFDsgI63DpdpEaxJ4I3xXaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguwMIc7xM45ZlmxmyTjBJf0nXYrCU+PB4towMDIY2JsTQ6mHP
 JRxhTxHdgT7bj4SBHMrMJ8HocyXnkvieWFTkQfAzUYwyzeKl1EguFT3C/LKfvSaSMMTmVyXz
 kre9nn9KgEXMpqY0zXt2mKhgKrDkD32XKoWFaak7bh6jVuL3GsRBRYKE1yhrpGRiESzRtZeI
 Ew84Tc1oO4580nDZtXgWRmxuHGsoxsdUNoWHuEngDxh0YKNvVzfXDJdCGccNpp276faWADGy
 Hevloq0KwZe7YGcVHKSy4nNlTiSCXU8eDpqiTA/cSMJ5NzqoYcWhx3JT8p+HKPdsuAZCQ0c0
 BjR8nFg2ux7YdojkvzioAuZ227ESo3hE1Ztjjg7SF5J+e+QiGSNQ4WzoWbW4v9bRGpyZgnQ5
 SNU8yRyAQ1nMH1sqMBvaLhXdF1Kz6zcWNE5vbKIN8NwnwlBA1b5IehtDMhWfS+FyPosdz7ze
 1P0sghM/pJVN3bCRfYpP97oWp1zk/m6TI+NuhXogj1mOMkZSeN61Hs2OR74M57FzCDAbp3Ty
 b/EKJ3xXB72+IxszSasRvd17FPY7ntW+I8nfriil07P+ePHPBa9EO5ZWHPTPrFRxP7V+239r
 ocAX+PUkE83eLOlPUHqHXs7cAliwY4TXsut9aS6t4erf2JbJY3WI6WNmON6Jd05wPg9eyWh1
 ijVZ3K0AWHX3BXvAQ6LdmpiePXoW5N+pmg8JisiIRCj3H1LXGplxP13m0IfceZ1+ep94+RzS
 vVZKcyMDu4WEmbM+igHbIm7p4tnLUz5iQWLNiujQT4+Y58/GFCZpo66JlPipHsUEy66lcoiu
 Ln8hAnVdoUOGlZ5B8HMZfPxk17o5SoBmPh/VlfjK8VIfBm+65BjLiH816dlI8wFJRjZ6CGd0
 gKaXUURqeXX+tdn+9jVn6GU6YyuFrImTEZdGmDa65ewNDXboTX/kdMRDr7QcGmEBm3u+aika
 eFE9N3GMaUKzARQro5xM7d31qZitdHhkKBXk1Z/F3LRYlX1Vr45eiua3dNCv7Fmz6NCvVfkQ
 VqG/9RXNOnbOM7hF1JNdgMpYv7aiKMRkzjWq/80PF/79Gl8+7/eCRdeOByFiSp8KrppMdx6n
 bd96ZBOswHv2AA3NtumjzxP8zXeJ3MNZKwrq5UGDdK5kQEs0FxDPcTRByKeDEtjsDmQ3p3G+
 gOpuZc=
IronPort-HdrOrdr: A9a23:5M7dxqF+ei1SautspLqF5JLXdLJyesId70hD6qkvc3Bom52j+v
 xGws5w6fatskdrZJhSo6H7BEDgewKXyXcR2+Ys1NiZLW7bUQeTTL2KqLGSuwEIeBeOu9K1t5
 0QFZSWYeeYZTMV7PoSojPIaurIq+P3kpxA8N2uq0uFOjsaDp2IgT0JaTpzQHcGHDWvpPcCZc
 ahD5981nydUEVSReiAPD0iQ/XJocHNmdbdeBYDQyUq8Q+UkFqTmeTHOind9TslaXdo3aoo93
 TDnkjC/62m98uwzATRvlWjtKh+qZ/L5uF4QOqRl8MSNjLgzjywbIAkYaCLoSwuydvftWrCxO
 O8+isIDoBW0Tf8b2u1qRzi103LyzA18ULvzleenD/KvdH5bChSMbsPuatpNj/ir2YwttB116
 xGm0iDsYBMMB/GlCPho/DVShBRkFauq3ZKq59cs5Ufa/peVFZil/1dwKpnKuZDIMs80vFjLA
 BaNrCd2B+RSyLfU5mWhBgp/DXmZAVPIv7PeDl/hiXS6UkboJkx9Tpm+OUP2ngH754zUJ9C+q
 DNNblpjqhHSosMYbt6H/ppe7r/NoXhe2O6DIupGyWQKEjHAQO/l7fnpLEuoO26cp0By5U/3J
 zHTVNDrGY3P0bjE9eH0pFH+g3EBDzVZ0Wn9uhOo5xi/rHsTrviNiOODFgojsu7uv0aRsnWQe
 y6Np5aC+LqaWHuBYFK1QvjXIQ6EwhXbOQF/tIgH16eqMPCLYPn8uTdbfbIPbLoVS0pX2vua0
 FzKAQb5P8wm3xDdkWI8SQ5akmdCHAXp6gAbpQy19JjuLQwCg==
X-IronPort-AV: E=Sophos;i="5.88,350,1635220800"; 
   d="scan'208";a="63567136"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=DhK1kFYLvZJahA6Fc41McMyoB24nrqJKRS9Z3JdykS4jVdSO1sl94LfnROWRN+DokjLLxFrTrnXztgSmwTfbzIyHVll0nsMBkJ/eE2jRtAAkoed+sEfExAnt04Wb8Z2QuVAtRgbStxhEpevEwdANgSbJZB0Dz08r/4e26kxgV0kDBmKosy3JBAjLwU8FZx2Xc69bL6L+A3+2bbp42OoaX7BMzcJdqE4k8bmhij7IrvkZHMWll+WnJp4P2DCcFb3Us2Ambt1EAEudT0NxEEbbHiRowTyhVf2GCYs5gAEUxgLcAC3iSvOVopRr3+FkxXrHbQXM1yXtSwEN56lK7xuzTg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=MY7Z5FwUiaPGBlJzHz/bNmCDZrW81h1hOhMJKyQZMPM=;
 b=b16+GZ30saxSAKczhlUa5ZbPNAcht2c55cx8eJXbRgTBYbStnysb1LGhWfaJrnnreVb++4PVqCTYOrn9c+FBGT4BPZf1SM1MY3gKSj9tgQ7o5hwjKkc5uIVu4BSW/kwj4lo/VGFnmDJQZcolmTJvoSnSVUu0Jr5k734cJmcleJ1SkNjkFyn5PRSBT2/mN3k7lPE7sJHilrBXzIonCWPVZ0z5b+7pCorBlHbN5FY3YTsXZeZq9OodD+b2yTtnWrgfcFZ1jBWZd7RKsBQjh6hmyWu1/JZiVf8UEoF396w4DCurEhAE/8MPuXpM6rekEW6Bb9uqf8OZ07Vbhy5ciTgNxg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=MY7Z5FwUiaPGBlJzHz/bNmCDZrW81h1hOhMJKyQZMPM=;
 b=sQFCEWGIwQUyn/aKpV5f+pHyQJ4erjJHw5yUxkR5DBcULZoWu5Q2wc6mGya0E96dUyg6iT3nxFsVqRo1uK7TQ+H4GUXw6Fohtrqnex2P6sxHdUvWDZHaIMLUJIsu8Bwnw7hFdDxtrb7xzA+DhMlbG6VO/Oqck5lUJrfbJNcmKfs=
From: George Dunlap <George.Dunlap@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: George Dunlap <dunlapg@umich.edu>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, Andrew Cooper <Andrew.Cooper3@citrix.com>,
	Wei Liu <wl@xen.org>, Roger Pau Monne <roger.pau@citrix.com>, Paul Durrant
	<paul@xen.org>
Subject: Re: [PATCH 02/16] x86/P2M: introduce p2m_{add,remove}_page()
Thread-Topic: [PATCH 02/16] x86/P2M: introduce p2m_{add,remove}_page()
Thread-Index: AQHXcbe4nq39qHT4NkaFiXaxZQKxtayFQ+EAgAPllgCAAGedgA==
Date: Mon, 7 Feb 2022 15:49:17 +0000
Message-ID: <26C975A8-9ECD-4330-8852-4D308D386A46@citrix.com>
References: <d1fd572d-5bfe-21d8-3b50-d9b0646ce2f0@suse.com>
 <eaf6f63d-1122-f52d-1147-cda40a9c3387@suse.com>
 <CAFLBxZZQgfYZ=OcyhRedPvK0CZxjrHY-5kRp4EOpJ2LEFL09yg@mail.gmail.com>
 <f986aadb-0eff-0f51-be42-16c31999cb08@suse.com>
In-Reply-To: <f986aadb-0eff-0f51-be42-16c31999cb08@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3693.60.0.1.1)
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: d6ff1a86-3e8c-465d-d58f-08d9ea516654
x-ms-traffictypediagnostic: BY5PR03MB5362:EE_
x-microsoft-antispam-prvs: <BY5PR03MB53621D2727E205AF36FCEE9B992C9@BY5PR03MB5362.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8882;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: aiJ9PqA0JopeJJNr+l64KYaTOUiCDk0ZF+06oudo4J848fDlWGjteS6stcKGuNTO5essn/o43RcW5hGuLM7bhwa5jJeru6tUC3JPnDxNl6zRGT334wv6yI5DLaLvM7grBSgV7KkxX6mridzDzlyvUKDADdu0oMr0P4Uy60+yHcGRCkpiT7QdErOWB5Y28LhENxM+AM7AGTiVCrgoVLPAE6M9516isvMa1smuoYI+LPStLFwYmG0hOISIS8/PYAfDjrWEoJYlr8GQagKOMLXVjhueBrTuVAIFOulefsccIvCvkRzV9DgCAI7FM1CRvFhwquK/VP71/ZBxUtM0WW82ziOvvKZcasvQauT+LvZEJzkg4ZSMHEhQTSTCNKlQvvczcsJuNBqs2Jc61zyNU6HzWwowiRdh8QUr/ID9rknBcqXUcD3VyFyu826dAHAe6OEjyKuMwnksqSo6JqzL8JOFwLSF0g9yiYwlXE9EfXJkqn1j5TiIxpDH1T938QvOkasUoVcG1gLVPmrLZW+ECFHAnFvcoBiyCb568gLsXZKpEKUzJ0dHSCQYOaOoPJI1vcOY2+6ZVca/rqxueQF09fctdLh6HylO7puF0W1s2/nMuKZmgocSPL0r/5RRF5EfDlRKT3ZWkuG/MSoBmg1dnjQDFxYZsgX/dFBWkFzHXCa1Rkb2g5jLy+xJUFu7QeURts8IHdJprBH+1PaA2sjNsfKrsvJ8/0p2L1nwj+9zIMyCt1wit+TdySjvDy/wLZQWpgEi
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(91956017)(6486002)(508600001)(64756008)(8936002)(8676002)(38100700002)(2906002)(66476007)(76116006)(66446008)(66946007)(66556008)(36756003)(186003)(2616005)(5660300002)(6916009)(26005)(6512007)(316002)(53546011)(54906003)(82960400001)(38070700005)(83380400001)(6506007)(86362001)(122000001)(4326008)(33656002)(71200400001)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?K0xDczlPdm9yODcremVia21kaDFISmpWelljcE91WEtDSXdoSkR5TEtkTFh6?=
 =?utf-8?B?ZE83Sm1samRYemhBd1pncWxySUlsdmk3MllNYVhmV3lPVlhlVW5pWDZwTHJw?=
 =?utf-8?B?S3BFTk1WRUFGb3ozc1J2bHV1enhnQ24xSmhIaExnekh5bU43YkdMUXQxSW0y?=
 =?utf-8?B?VWpSdjJGNWE5UHd3cU1BTmF1emR2bTJQcGtPRjF1Uk96VzBuRkk1MnlqenJx?=
 =?utf-8?B?S0lrZ1FrWnRieFcranpTb3pLd0tWQ3E4bGQ3cTdnWGhqMEJPajBpSldMYlJj?=
 =?utf-8?B?Qk53YVJpclMxcit3ckIvRWRCYWx4YUdJM0pKaFlveFU4U01GNFJHc2ZHRC9s?=
 =?utf-8?B?YUNWRkQ2b3dKeXBucUJua00xWXZmemNEaEk1QTJSeE1pbkdlTURaTmxObU9I?=
 =?utf-8?B?Z3VpcXNJMEZtZkgxaU1NeHVaL2psYWdwanJKVDh2MHZURFRlS3JFT2R2emhu?=
 =?utf-8?B?U0s2M1pZYldzUit6aVZSWnFTSWsvbng3NXp2VFNkMndKazl5QUdpS1Q3QWlT?=
 =?utf-8?B?YzN4MXl0SjJlRFpidjV0WndoU3Y4SGpLcTZUaGVCRXUxV3FGMVVKak92WmQ3?=
 =?utf-8?B?RjN6Z0RjT2huM3NLczIvZDFoSElqbGlHQUF5eWRCY1JIZ29hTmUrWFhPNGJw?=
 =?utf-8?B?ekZmRUpVRkNxeVptR2FUNXhrZTZPNUF2bzdDb1dERU1LM1hZYk1JRVh5UTRx?=
 =?utf-8?B?akVvc2NHa1pTUDc2cEFRbXZwOU5kTVdOUjF2QXQxeDRzRHhhY2lJMTBkdzFP?=
 =?utf-8?B?RENKQ24ybzlSTnQyLzN3VUhUQmVCcnhTSGVuTHBiM1dzd01kcisyQ3JzRVBC?=
 =?utf-8?B?RWNvZytWK3VURDhva2I2NFR2V2EzVG1LTk5lYVNSNHEwOWZWdnR3UnRJMS9j?=
 =?utf-8?B?ZE82UjFFSHYwTHFlcncxRkZUbjNSRTkxYUlHZFY3M1V6WDRRd3ZUZzY3S0Fn?=
 =?utf-8?B?dnpNTytnQ1Q1MWJYLzJkS1J5d0lBQml4MXppOTdFQWo1TGtUS2UwTDk4a29r?=
 =?utf-8?B?dWpoMk9XeHpiV3VPVktnTjltM3ptNTcxM1BKaFp2aCtVNnBEb3ZyZ3RTdnBi?=
 =?utf-8?B?a09mR0NRYjBaYS9obEVDVWE3K210aGtRWHRwS2lrZlFNSDBoc0hzbW45bWRv?=
 =?utf-8?B?MllsMnNoVUhYNitrTjF2b3JwUjR1aDFIcDYxMXI3dEdBZ2ExakVldmU0aEpi?=
 =?utf-8?B?dGtLTHRyZDF0VGdmeS9SWE43ZEdwaEVjWTE4SFZXaE41TkJtaU9rZURBWGhu?=
 =?utf-8?B?SStabnNrMktwWnVBdHpsQVVzZlJKekswbW92U0lVMUZjaHBiWWNwRkJodGVq?=
 =?utf-8?B?QnBwN0NPTVVudUhGZVNqMU1BMjdCY09CMk1ra0NmbE1OeHMycXJNTGNUVVgw?=
 =?utf-8?B?M2FHbkIvaG95cEZrcjlQTGxBMDM3VDlES1FRanBxWC96QU5JalpQZXBCRWpo?=
 =?utf-8?B?RDFRT25BaWRINmxzY2s0RXNkMmR1Um1LcEpNT0paanFOUysvN3A3L083R2tu?=
 =?utf-8?B?SnpjTnhOc2tEaysvM1hGM2grRlZwdnlJRGRVY0hHQ1JhclN1ci9MTDNpbnhh?=
 =?utf-8?B?Y2RCdnZ1Q2owRE5UeEJqbGxteVNWaFQvbWVJNXAycVRUSVF1ZVB4WVZrbFdz?=
 =?utf-8?B?R1ZRdk01ZUsyUkhmL3pMa3NRVTdmcHNLWllHN3NKRjc3UEtHcW9XZHdYbEh2?=
 =?utf-8?B?VjBHSlFpQ3RTUXl6UzFOODVMNlhUeTJqM2Zkam4zaFJYWGxERDJ5aVQ1WHVR?=
 =?utf-8?B?QjRMMDNidjlacDM1U1VIMVJwbng2VVhHVmUvTnlleWo3TCtjWFIxWW9qY08w?=
 =?utf-8?B?VUFhTUV3QXFZcThtTWVUWjVNb3ZrcFhEWEwrN1E0bGkzdmk5OHZkNWlVQk42?=
 =?utf-8?B?dEkrM1RzVnkyNlEvQWtmbCtDUndXVDFWeUNldFlyWllOaVUyM3h1UWtwdDVw?=
 =?utf-8?B?NzRzN3YxUEJEdW5vRnlia3RGanpLWWp5OWltWHZCQzR0TXdHblVXcUZoZE1s?=
 =?utf-8?B?eGNFZTN2NFhxZEhPMXFLcG9RbSs3WG02YjlmUHMvWk5kcUg4K2JWcG9GbmJV?=
 =?utf-8?B?Nnl5VExaSXVXc3pUNmtTc3k3alZpNlkxeHBGUkpmeVRqTnJ4UzVzcmpzc1Vj?=
 =?utf-8?B?bEtMa1FCREN6YTFVMzJVTkU5Z2ltR0g2NzE1RXlLd2tjZ2RuWUx4M1dqQmtM?=
 =?utf-8?B?eHVGMFNiS29RL01vcWNMWk9zRndZT2c2RGNFcS9TUFU2WWlxL3BzT2dBSW13?=
 =?utf-8?Q?5kw7082gwC21kIq2XMT8DQiIeLlA+on4p60ybutztk=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <47426208BE01BD4CB96E92C80BE60D92@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d6ff1a86-3e8c-465d-d58f-08d9ea516654
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Feb 2022 15:49:17.8784
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ZkanR4oZ9Xcvd28I5WoMMiflT5AfzF/Ib7CEA0ia735l5Ae2IcBeJiMj4BhJg68HVPJ57g8CiY0qis8SPKrmjVrvFwjHhJL0FUoB38BKHLs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB5362
X-OriginatorOrg: citrix.com

DQoNCj4gT24gRmViIDcsIDIwMjIsIGF0IDk6MzggQU0sIEphbiBCZXVsaWNoIDxqYmV1bGljaEBz
dXNlLmNvbT4gd3JvdGU6DQo+IA0KPiBPbiAwNC4wMi4yMDIyIDIzOjA3LCBHZW9yZ2UgRHVubGFw
IHdyb3RlOg0KPj4gT24gTW9uLCBKdWwgNSwgMjAyMSBhdCA1OjA2IFBNIEphbiBCZXVsaWNoIDxq
YmV1bGljaEBzdXNlLmNvbT4gd3JvdGU6DQo+PiANCj4+PiBwMm1fYWRkX3BhZ2UoKSBpcyBzaW1w
bHkgYSByZW5hbWUgZnJvbSBndWVzdF9waHlzbWFwX2FkZF9lbnRyeSgpLg0KPj4+IHAybV9yZW1v
dmVfcGFnZSgpIHRoZW4gaXMgaXRzIGNvdW50ZXJwYXJ0LCBkZXNwaXRlIHJlbmRlcmluZw0KPj4+
IGd1ZXN0X3BoeXNtYXBfcmVtb3ZlX3BhZ2UoKS4NCj4gDQo+IEZpcnN0IG9mIGFsbDogSXQgaGFz
IGJlZW4gbG9uZyBhZ28gdGhhdCBJIG5vdGljZWQgdGhhdCB0aGlzIHNlbnRlbmNlDQo+IG1pc3Nl
cyB3b3Jkcy4gSXQgbm93IGVuZHMgIi4uLiAgYSB0cml2aWFsIHdyYXBwZXIuIg0KPiANCj4+PiBU
aGlzIHdheSBjYWxsZXJzIGNhbiB1c2Ugc3VpdGFibGUgcGFpcnMgb2YNCj4+PiBmdW5jdGlvbnMg
KHByZXZpb3VzbHkgdmlvbGF0ZWQgYnkgaHZtL2dyYW50X3RhYmxlLmMpLg0KPj4+IA0KPj4gDQo+
PiBPYnZpb3VzbHkgdGhpcyBuZWVkcyBzb21lIGNsYXJpZmljYXRpb24uICBXaGlsZSB3ZSdyZSBo
ZXJlLCBJIGZpbmQgdGhpcyBhDQo+PiBiaXQgY29uZnVzaW5nOyBJIHRlbmQgdG8gdXNlIHRoZSBw
cmVzZW50IHRlbnNlIGZvciB0aGUgd2F5IHRoZSBjb2RlIGlzDQo+PiBiZWZvcmUgdGhlIHBhdGNo
LCBhbmQgdGhlIGltcGVyYXRpdmUgZm9yIHdoYXQgdGhlIHBhdGNoIGRvZXM7IHNvIElkJyBzYXk6
DQo+PiANCj4+IFJlbmFtZSBndWVzdF9waHlzbWFwX2FkZF9lbnRyeSgpIHRvIHAybV9hZGRfcGFn
ZTsgbWFrZQ0KPj4gZ3Vlc3RfcGh5c21hcF9yZW1vdmVfcGFnZSBhIHdyYXBwZXIgd2l0aCBwMm1f
cmVtb3ZlX3BhZ2UuICBUaGF0IHdheSBjYWxsZXJzDQo+PiBjYW4gdXNlIHN1aXRhYmxlIHBhaXJz
Li4uDQo+IA0KPiBXZWxsLCB5ZXMsIEkgdW5kZXJzdGFuZCB5b3UgbWlnaHQgd29yZCBpdCB0aGlz
IHdheS4gSSdtIG5vdCBjb252aW5jZWQNCj4gb2YgdGhlIGZpeGVkIHNjaGVtZSB5b3UgbWVudGlv
biBmb3IgcHJlc2VudCB2cyBpbXBlcmF0aXZlIHVzZSB0byBiZSBhDQo+IHVuaXZlcnNhbCBmaXQg
dGhvdWdoLCByZXF1aXJpbmcgdG8gYWx3YXlzIGJlIGZvbGxvd2VkLiBXaGVuIHJlYWRpbmcNCj4g
dGhlIGRlc2NyaXB0aW9uIHdpdGggdGhlIHRpdGxlIGluIG1pbmQgKGFuZCB3aXRoIHRoZSBwcmV2
aW91c2x5IG1pc3NpbmcNCj4gd29yZHMgYWRkZWQpLCBJIGZpbmQgdGhlIHVzZSBvZiBwcmVzZW50
IHRlbnNlIHF1aXRlIHJlYXNvbmFibGUgaGVyZS4NCg0KVGhlIHdheSB5b3Ugd3JvdGUgaXQgaXMg
YW1iaWd1b3VzIGdyYW1tYXRpY2FsbHk7IGl0IGNvdWxkIGVpdGhlciBtZWFuLCDigJxSaWdodCBu
b3cgcDJtX2FkZF9wYWdlKCkgaXMgc2ltcGx5IGEgcmVuYW1lLCBhbmQgc2/igKbigJ0gb3IgaXQg
Y291bGQgbWVhbiwg4oCcSW4gdGhpcyBwYXRjaCwgcDJtX2FkZF9wYWdlKCkgaXMgc2ltcGx5IGEg
cmVuYW1lLuKAnSAgSWYgYSByZWFkZXIgc3RhcnRzIGludGVycHJldGluZyBpdCB0aGUgZmlyc3Qg
d2F5LCB0aGVuIHRoZXnigJlsbCByZWFkIGFsb25nIHVudGlsIGl0IGRvZXNu4oCZdCBtYWtlIHNl
bnNlIGFueSBtb3JlLCB0aGVuIGhhdmUgdG8gcmUtZXZhbHVhdGUgdGhlIHdob2xlIHBhcmFncmFw
aC4NCg0KSXQgc2VlbXMgdG8gbWUgdGhhdCBteSBwcm9wb3NhbCBpcyB1bmFtYmlndW91cy4NCg0K
PiBJJ20gZnVydGhlciBzbGlnaHRseSBwdXp6bGVkIGJ5IHlvdSBrZWVwaW5nIHRoZSB1c2Ugb2Yg
cHJlc2VudCB0ZW5zZSBpbg0KPiAiVGhhdCB3YXkgY2FsbGVycyBjYW4gdXNlIC4uLiIuDQoNCkkg
d291bGRu4oCZdCBjYWxsIHRoYXQgdGhlIHByZXNlbnQgdGVuc2U7IEnigJltIHN1cmUgYSByZWFs
IGxpbmd1aXN0IHdvdWxkIGhhdmUgYSBuYW1lIGZvciBpdC4gQ29uc2lkZXIgdGhlIHNlbnRlbmNl
LCDigJxQdXQgdGhlIGJveCBuZWFyIHRoZSBkb29yOyB0aGF0IHdheSB3ZSBjYW4gZmluZCBpdCBl
YXNpbHkgd2hlbiB3ZSBuZWVkIGl0LuKAnSAgVGhlIHNlY29uZCBoYWxmIG9mIHRoZSBzZW50ZW5j
ZSBpcyBzZXQgaW4gdGhlIGh5cG90aGV0aWNhbCB1bml2ZXJzZSBpbiB3aGljaCB0aGUgaW1wZXJh
dGl2ZSBoYXMgYmVlbiBjYXJyaWVkIG91dC4NCg0KIC1HZW9yZ2UNCg0KDQo=


From xen-devel-bounces@lists.xenproject.org Mon Feb 07 15:58:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 15:58:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267165.460880 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH6Pd-0003YF-DD; Mon, 07 Feb 2022 15:58:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267165.460880; Mon, 07 Feb 2022 15:58:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH6Pd-0003Y8-AB; Mon, 07 Feb 2022 15:58:45 +0000
Received: by outflank-mailman (input) for mailman id 267165;
 Mon, 07 Feb 2022 15:58:43 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nH6Pb-0003Xy-D4; Mon, 07 Feb 2022 15:58:43 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nH6Pb-0006SE-0M; Mon, 07 Feb 2022 15:58:43 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nH6Pa-0003jB-Hr; Mon, 07 Feb 2022 15:58:42 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nH6Pa-0006Jc-HR; Mon, 07 Feb 2022 15:58:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=WAgh/35bhk+fUfie2IzmBVxpc+EHWHU+hPbwubQq1hU=; b=RZcoHAp1tYbIL2ky3ttaE0NCaf
	fa8sapYARXfapiVrbpVwZ+3h0weZorWheYNHbW+iO/PF8+Ee4cGqWUNTl+iq8Np239Fwi4t7zvPuH
	6AqsCgqqFsq4+HHs34CVEZMsP08vHDo5nMRndyDcqjR+XavheEsNjjSYS7FiQLc929Nw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168046-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 168046: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=1f54eaa725f45e0c66c28f8d47fa8fb33f7be52c
X-Osstest-Versions-That:
    ovmf=96b8b5fd108a1f27960eee3915c0b10db191c849
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 07 Feb 2022 15:58:42 +0000

flight 168046 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168046/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 1f54eaa725f45e0c66c28f8d47fa8fb33f7be52c
baseline version:
 ovmf                 96b8b5fd108a1f27960eee3915c0b10db191c849

Last test of basis   168043  2022-02-07 10:42:40 Z    0 days
Testing same since   168046  2022-02-07 14:11:34 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Gerd Hoffmann <kraxel@redhat.com>
  Leif Lindholm <leif@nuviainc.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   96b8b5fd10..1f54eaa725  1f54eaa725f45e0c66c28f8d47fa8fb33f7be52c -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Mon Feb 07 16:00:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 16:00:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267176.460891 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH6Qr-00049i-Qe; Mon, 07 Feb 2022 16:00:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267176.460891; Mon, 07 Feb 2022 16:00:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH6Qr-00048v-Mk; Mon, 07 Feb 2022 16:00:01 +0000
Received: by outflank-mailman (input) for mailman id 267176;
 Mon, 07 Feb 2022 16:00:00 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=F54n=SW=epam.com=prvs=403792ff6c=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nH6Qq-00048g-4N
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 16:00:00 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id feacb15f-882e-11ec-8eb8-a37418f5ba1a;
 Mon, 07 Feb 2022 16:59:58 +0100 (CET)
Received: from pps.filterd (m0174683.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 217FmQG7009571;
 Mon, 7 Feb 2022 15:59:52 GMT
Received: from eur02-he1-obe.outbound.protection.outlook.com
 (mail-he1eur02lp2053.outbound.protection.outlook.com [104.47.5.53])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3e36cw01je-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Mon, 07 Feb 2022 15:59:52 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by PR3PR03MB6684.eurprd03.prod.outlook.com (2603:10a6:102:78::9) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Mon, 7 Feb
 2022 15:59:49 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77%3]) with mapi id 15.20.4951.018; Mon, 7 Feb 2022
 15:59:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: feacb15f-882e-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=mvRz0AUThSV68jGgRZu9ME08QykmUpLlUDaDYvyD5uH7Scx31NNTUjrGJf3M0ntpkSnT0ADYg2+dOBZBnwAwNaCgkNaaBJ5+d1lmHKlemSDpSlRB9R5FBM9J7Juox1RLQf1J4Y14gJofFexRlYlj0bYOsGHjIQK177vKxi2PwpPoG8bD0lvzmvAxgcgLCu47FR96yS2PcLJlNnkrlLD4/2miY4NETebaErGk4t94xXRB9IVOWDevgTJ4BIDaf+XFOTev6BVpBa8qhaORdZOrlohem+mJtgchzRm6OdudHS3NrGYcNQSKgbjUl2212z6NhJ76w0qPuu8cxvkQqx4rAg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=kpY/66G44ayxxo5csJuPIW+GRqPkDjn6+f0c0h9nrow=;
 b=HG0PCAxpmRgnsCvvClR5Sn0gAk9K6bseWOL8KXkOcvZUCjavmcCaXH7I1kAw3kHGgx80FHShKN35pRIuDPiztspKQIKHTO3BwCXLJ9ru6omMqzs8RPtXvOJf0lNqnqH5ukN3hY7a7AU0xkx8i+LEX9aiOcvHu3dNpxywen0OKc8YHujrTZeoDIokqyIewW3BXighrBJZP7QdCS7/QwpOcxPu51x9PzmdYby6sfqm7FzMjYhe1S3TmywhVWibtu0pdGKO9ftLFwzQnghiGBv5KZaqL1Hr5TANt9VdDmDGi/dBLPDNfLo5FTsR77jFR+PWNEOGg2rTWzkYGnlxSQ1Oug==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=kpY/66G44ayxxo5csJuPIW+GRqPkDjn6+f0c0h9nrow=;
 b=SZAZZtxgGk3362yJI/ry92sXTMAuFly3kurzzqQ7VOPdGRQFvBFoJlN14NM5Nfau9G+mf4S9Nqn9YVTikR572Nl1FpJtfCn7tGk6bbxb79/tFaT9veBpCg1QSG1Wpw+IF4t7gcbqPryKQcLGxHpVXoyXiL61qCFXXUKaT8YldBippSWbOS37b4kYvJ60pxmpO937tgTytf2bryldqXuWpE0NfjSFTS7ymYQVT62cc8QKDI3+5C/3kZFcWXeB04/JbDvkseiqpYQ5UnWK72Szc+n8DJTz2qJBkgNUhbjtUnxEOoyxy4BAGcGEzQQEC0j2sJoaxb7gdoNBuZaXHA8hsQ==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "roger.pau@citrix.com" <roger.pau@citrix.com>,
        "andrew.cooper3@citrix.com"
	<andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com"
	<george.dunlap@citrix.com>,
        "paul@xen.org" <paul@xen.org>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>,
        Rahul Singh <rahul.singh@arm.com>,
        "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v6 10/13] vpci/header: reset the command register when
 adding devices
Thread-Topic: [PATCH v6 10/13] vpci/header: reset the command register when
 adding devices
Thread-Index: 
 AQHYGZFg3nazYSvfA0G+yHTbxcxX2ayDdFgAgAAB6wCABD+NgIAAQmgAgAAT4YCAAAOjAIAAAPCAgAAXGICAAAPHAIAABC8AgAAFjoCAAAI+gIAABB6AgAAIsAA=
Date: Mon, 7 Feb 2022 15:59:49 +0000
Message-ID: <064a5d95-9841-863e-8486-497cb7fefc7f@epam.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-11-andr2000@gmail.com>
 <96381d7e-dafc-acee-3abf-f9815deb207c@suse.com>
 <ef76faac-f9d3-1cb8-06b5-189ccd299542@epam.com>
 <6f0a015b-c48f-76ed-9a51-39c045ff5927@suse.com>
 <2ad372d4-a181-9307-ef50-a5adb61dae66@epam.com>
 <49380584-0577-96f2-ef1c-a96eabf0d227@suse.com>
 <fbd410d1-84ad-2309-ca05-b9ac7f95f1f9@epam.com>
 <dbef1c95-818c-427c-1963-75d584843cff@suse.com>
 <f34cc940-7f5f-aebd-60d9-d1a3d85d1283@epam.com>
 <8f35e7c5-3193-4b10-ae25-df838e2262c7@suse.com>
 <6b4ea90d-cc9c-edf7-e579-a84d72431d7a@epam.com>
 <f6f16729-8404-6703-11c6-dd7a4ebc658c@suse.com>
 <c5eee75b-bcf3-7e31-e25b-0bf0b217267a@epam.com>
 <06408e4c-3b9b-256c-9fe3-73d9a5383907@suse.com>
In-Reply-To: <06408e4c-3b9b-256c-9fe3-73d9a5383907@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: f59c70f2-3662-4ac4-31e9-08d9ea52debc
x-ms-traffictypediagnostic: PR3PR03MB6684:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <PR3PR03MB6684A18756AAB2A87B0B0602E72C9@PR3PR03MB6684.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 Qvv9ZQfWqoeCD6cOnh1vNoY60kJSxKxFTI9IubpDnnO1DGuI3hdmq2JVApbjUT06hcQY8SxPVenZpkrO+eVT5UB8jSNmxGVqrkpmLA90prTz10TrCsMPTAB/t3xDYD27oqdJMfnFcTo7cI3sxTCCLyR2/9Qt9xQSeYN4dCRckoJ+L+egU49lnNRWnBk4GctzIDIBJHzdj9CcsNvLDrNP1YDIW3wZ5OfKOSiWF8Ijcx6J9T/n0rhYy0EA7Q6LD46QxT2KCJElQqg+EJ3mblR+wg0+fJ8acNErrbgT7Ah33UNdKZ18OI7Ut1kupi5guo2CycEnw/RpQALHbmmKxpR9x3t4Oj+w9ub4WW19Q52oDV3MPFC3ZEtHM2m250q8pPveHQSJXbmZBLVN+FhwZ1jue7ce5ZCGSsGfh9Bb14S2tYfjlJ/dReWm6Fb45BUNMwBPtKeFKZLd8kJgU+LfCVdV1vpda3xr/jfDqTvy9KeQATPDxDZuShAp9J4qtiIO2tT6juabPt+3XNqQrGma657dVB+Yk85jScoDmM3WBbfsW8pvMOJFEs/nLnxHqJJjSjp/yFBXIESpBex1IpMDGEciePOUnZGXRq1IZgAl0nX0hCywXN8BTRKXFmq9NZZEfMU4mbGhjvXtliaxIAlRrbLsgNi3muaZUXWqjjtH46SkEqadRRe9/s30IEjcBLu5kVwaLmgT6Bn4AWKhhffjDNutTdMuuq4Ix8fiF/J9flQiSZQ=
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66946007)(91956017)(31696002)(38070700005)(86362001)(4326008)(8936002)(66446008)(66476007)(6486002)(66556008)(76116006)(64756008)(8676002)(7416002)(508600001)(5660300002)(55236004)(54906003)(71200400001)(6916009)(186003)(6512007)(36756003)(26005)(316002)(6506007)(31686004)(53546011)(122000001)(38100700002)(2616005)(2906002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?YzZ5Q0pSeERBYWdGWXVzMC8rMjZFRld6aVNNUUpxSlVWNTI4N1VlWTRoYWhZ?=
 =?utf-8?B?c3Z2UVBJaER2djd5NnRDb09aYW1SL0N1MW0wWSt4UlByR2QvSDRxZnd0TmdO?=
 =?utf-8?B?S0x1VzhXM3YxbnJ2WWg4eGd4c29PK1hTcjdWb2lwRitXU2lGNjJ2Zm5ESTVw?=
 =?utf-8?B?dUpKbEY3RzZXMDFzYVF1dXJicHc2OE42TkIxZmFvYjBPUlNsZnRCL082Qjl3?=
 =?utf-8?B?RU02SWFsK3kreGVjUExEcnBCQ29pRURoV0NTVzY4ZVBJeDdOYnhRc3l0eFVL?=
 =?utf-8?B?bE14SUFHMTZuZFo4bmt1T2FKVGtFN2QveE5jVGEzYm96N0ZuK3ZVNyttVkJm?=
 =?utf-8?B?N1JwUHljaFhFSmNuazNTL2N0MGF3eGhlQURUMU5JM1FmTkFnV2ZQd0lEa01H?=
 =?utf-8?B?bEkrdzc0SnFabC9FbXBjVlIxMlFOS1UyakZLeVlSQzhkWllLQVdBU1dScEth?=
 =?utf-8?B?Vk1tZFVDNy92RzJvNExobEF1Rzdac3lwc2Q0a0krQ3Bpcjh1OVR0cVUwbjBX?=
 =?utf-8?B?THZ1R0p3WGpZYjR1UDdGUGdMQTJXcFZESDdaSXNNNGh6RytmbjE5MG50aFBs?=
 =?utf-8?B?U01hVi81NHZ6Qm1nVUxtbUJSM3ZBcnNweWlSYmhoMTNWaytmQmhpRERVcmJX?=
 =?utf-8?B?ZzR0TWE1Ty9BSDY4TmFjZFhidktNRUNmbzRDK0NjaFh3Mk9DcXp6UWhpUlk3?=
 =?utf-8?B?VHZ5SHBwS1locHFuZHp3ek1rUm5xbmJ0elZId2dLQXh5Z1NVNHl2ZEI0SU5Q?=
 =?utf-8?B?UzRlaTdGWkhzWDFIbE9MSkJDZUFwaWFXRG5ub2JEVHI1OXV5ZnoyTWRYV1FK?=
 =?utf-8?B?TEdrSFh1REN5cmlzVUhWM2NuYTdBMDBJY3ZhbnZDZnhqNEl0eENYYXRTWEU3?=
 =?utf-8?B?MlJMRTlGVFpadmtoODlsTDRNMktRRWpXbjIwVUtOenlMdGlKVW5WSWluZHhz?=
 =?utf-8?B?RnluTk56UUoxOTNFR0NWS2VXVmZpNGpFWmx1bW1kSFVCenprbWk3QzZRQVZm?=
 =?utf-8?B?VUlaR3NCcURjV25rSFNEN3BGaHZHMk9jUTRiYlM5QW9hZEM5ck8rcHpLR2xD?=
 =?utf-8?B?Nmg1QU5hY3hETjlGQnJab0c5d2NtWlpISjJaTnhPdVhRNkdRUXJBM2wxNWtO?=
 =?utf-8?B?U3RyZ3BmOEdaLytoYjF1U3RkRFNCb3Vnc1AvSUhwd3ptb3hJU2YxUHBmdkhI?=
 =?utf-8?B?UERuWDgycWNZbEsxeTUwZmhOYWlOYnlvUmp3K0FOaGtpTlNZcUc3NVFNTHNo?=
 =?utf-8?B?ZiswOTIvUkxFUCt1SE5Lb2phbkNCNGlnTDdjMmxJYlF1V21oVVRmbEE0S0lp?=
 =?utf-8?B?M25EbkN5RHVXcXY1ZkpqVGFqZm1DdnFkUzNpNVc2SW53RmxJMWVBL3JxR2ds?=
 =?utf-8?B?SE10bGd1eXNGMS9rKzhJbTlWYTdTSUF1aFJEZnpSVFpoc2VqQmxSR2pGSm1O?=
 =?utf-8?B?U3RvSWV2RStrU3ppZGN3WmlaTDVpMzJiTDBKRDJ4TFVkb3RxY3VZdFhxR2hr?=
 =?utf-8?B?U3pOWU9TL21heTg3dy9qL2VsYUt5bkR6S0dnZ3l6YytNQVFYK0ljQjAwTFJk?=
 =?utf-8?B?VzQwSXI1bnFpdFpaUUsyTVo5QTdrajRmMStmZ21ISGdrWENyc1JsNW9KVHVY?=
 =?utf-8?B?WVlOQkFQUXkyQ0hTVFE2enVyaHRwS3J2TVVyR1lVTjRHamJ4dFhHZWgyRHow?=
 =?utf-8?B?ak5qeldEMFZ1WVYxVE1qZ0FjQzFROXFWTG9JOUJ5ZFV3N092MTFkMlJFV1N6?=
 =?utf-8?B?RUlwRWQ0OGxlK1RnWGJqTkRMVDVXaHlRZTNObUE5ZEV3WXBWS3hrbmdnT1ZW?=
 =?utf-8?B?US9GK1hNdnFhVThQQW9MTUF3UEZ0MEdta0d6NXMrc3QyY09uanVoUXFScCti?=
 =?utf-8?B?cXhOK3RFK3dVVURnQmNiRC9uZ01vclRTRDdYZ3huWlhIWE1oN3g3L2V6QWpX?=
 =?utf-8?B?ZUErOTRUY1cxYzZLc3gwNHJBK2QwTjBRb0U4TGdURElpeE9PL0ZMRjZPb0dR?=
 =?utf-8?B?dXE5eVJId0Nhc25IY0ZuUVZOZjNwNU5xaUswMisxOGxrVUlUTjdhZnM5YjND?=
 =?utf-8?B?aTBXb3I1aTRzRnpBWTNGVGNtWERxRW5CWXMzQms1MVNrVmNxQ084dC85U0pu?=
 =?utf-8?B?bzI4MFllZ21hZEhhWEcrb3pqOTMrc2xLaU9tUlhRMllDVWtuTUFUQXhnbW5r?=
 =?utf-8?B?a28rVFRMZVRIUkpITWZ3UHEzM05UR1l0b05FYjJWUVo4ZWNtYU13VTk4R3Rv?=
 =?utf-8?B?VWJYbTd3c3pCS05Vd1dRcVVUTjY5Nlo3dXlBb0paTXZRMkpMMW1aOEw5NGhP?=
 =?utf-8?B?YWwweVZpUmNscHJYMFVwdUV5K0RMRFdzV3hRcEEyZFdlSkpPdE53TTRmZHJH?=
 =?utf-8?Q?EqORUjRHNd/yxJOA=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <FF80018098A95748AECD469ACF93717B@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f59c70f2-3662-4ac4-31e9-08d9ea52debc
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Feb 2022 15:59:49.3791
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 0YHNRewxEmetDZsOEQe6akSmzgYjOil8ub2DBTRHmdrrIMviK9mRYv61VsSDiGeVdz6cfxyAwTYQ3AxZK4QeWnskMjt59z/G6JiNe5puRxxW5Jc+WPw3f0e0mhta1/cz
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR03MB6684
X-Proofpoint-GUID: 07fNzmO4YQy5amGLE8Ft1xI5xeoJ20YZ
X-Proofpoint-ORIG-GUID: 07fNzmO4YQy5amGLE8Ft1xI5xeoJ20YZ
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-07_06,2022-02-07_02,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 suspectscore=0
 bulkscore=0 adultscore=0 spamscore=0 lowpriorityscore=0 phishscore=0
 clxscore=1015 priorityscore=1501 malwarescore=0 impostorscore=0
 mlxlogscore=674 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202070101

DQoNCk9uIDA3LjAyLjIyIDE3OjI4LCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMDcuMDIuMjAy
MiAxNjoxNCwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+PiBPbiAwNy4wMi4yMiAx
NzowNSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+Pj4gT24gMDcuMDIuMjAyMiAxNTo0NiwgT2xla3Nh
bmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+Pj4+IE9uIDA3LjAyLjIyIDE2OjMxLCBKYW4gQmV1
bGljaCB3cm90ZToNCj4+Pj4+IEJ1dDogV2hhdCdzIHN0aWxsIG1pc3NpbmcgaGVyZSB0aGVuIGlz
IHRoZSBzZXBhcmF0aW9uIG9mIGd1ZXN0IGFuZCBob3N0DQo+Pj4+PiB2aWV3cy4gV2hlbiB3ZSBz
ZXQgSU5UeCBiZWhpbmQgdGhlIGd1ZXN0J3MgYmFjaywgaXQgc2hvdWxkbid0IG9ic2VydmUgdGhl
DQo+Pj4+PiBiaXQgc2V0LiBPciBpcyB0aGlzIG1lYW50IHRvIGJlIGFub3RoZXIgKGJpZykgVE9E
Tz8NCj4+Pj4gQnV0LCBwYXRjaCBbUEFUQ0ggdjYgMDkvMTNdIHZwY2kvaGVhZGVyOiBlbXVsYXRl
IFBDSV9DT01NQU5EIHJlZ2lzdGVyIGZvciBndWVzdHMNCj4+Pj4gYWxyZWFkeSB0YWtlcyBjYXJl
IG9mIGl0LCBJIG1lYW4gdGhhdCBpdCB3aWxsIHNldC9yZXNldCBJTlR4IGZvciB0aGUgZ3Vlc3QN
Cj4+Pj4gYWNjb3JkaW5nIHRvIE1TSS9NU0ktWC4gU28sIGlmIHdlIHNxdWFzaCB0aGVzZSB0d28g
cGF0Y2hlcyB0aGUgd2hvbGUNCj4+Pj4gcGljdHVyZSB3aWxsIGJlIHNlZW4gYXQgb25jZS4NCj4+
PiBEb2VzIGl0PyBJIGRpZCBnZXQgdGhlIGltcHJlc3Npb24gdGhhdCB0aGUgZ3Vlc3Qgd291bGQg
YmUgYWJsZSB0byBvYnNlcnZlDQo+Pj4gdGhlIGJpdCBzZXQgZXZlbiBhZnRlciB3cml0aW5nIHpl
cm8gdG8gaXQgKHdoaWxlIGEgcmVhc29uIGV4aXN0cyB0aGF0IFhlbg0KPj4+IHdhbnRzIHRoZSBi
aXQgc2V0KS4NCj4+IFllcywgeW91IGFyZSBjb3JyZWN0OiBndWVzdCBtaWdodCBub3Qgc2VlIHdo
YXQgaXQgd2FudGVkIHRvIHNldC4NCj4+IEkgbWVhbnQgdGhhdCBYZW4gd29uJ3QgYWxsb3cgcmVz
ZXR0aW5nIElOVHggaWYgaXQgaXMgbm90IHBvc3NpYmxlDQo+PiBkdWUgdG8gTVNJL01TSS1YDQo+
Pg0KPj4gQW55d2F5cywgSSB0aGluayBzcXVhc2hpbmcgd2lsbCBiZSBhIGdvb2QgaWRlYSB0byBo
YXZlIHRoZSByZWxldmFudA0KPj4gZnVuY3Rpb25hbGl0eSBpbiBhIHNpbmdsZSBjaGFuZ2Ugc2V0
LiBXaWxsIHRoaXMgd29yayBmb3IgeW91Pw0KPiBJdCBtaWdodCB3b3JrLCBidXQgSSdkIHByZWZl
ciB0aGluZ3Mgd2hpY2ggY2FuIHNlbnNpYmx5IGJlIHNlcGFyYXRlIHRvDQo+IHJlbWFpbiBzZXBh
cmF0ZS4NCk9rLCB0d28gcGF0Y2hlcw0KPiBKYW4NCj4NCg==


From xen-devel-bounces@lists.xenproject.org Mon Feb 07 16:01:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 16:01:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267186.460902 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH6SC-00064f-Cx; Mon, 07 Feb 2022 16:01:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267186.460902; Mon, 07 Feb 2022 16:01:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH6SC-00064Y-97; Mon, 07 Feb 2022 16:01:24 +0000
Received: by outflank-mailman (input) for mailman id 267186;
 Mon, 07 Feb 2022 16:01:22 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=kaUt=SW=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nH6SA-00064S-P0
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 16:01:22 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2f7ee4b3-882f-11ec-8f75-fffcc8bd4f1a;
 Mon, 07 Feb 2022 17:01:20 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2f7ee4b3-882f-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644249680;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=RVMMGcshLYbP+PZLZfceTFwbCv1XB7f4eHmsO1KU/SM=;
  b=XxFO5HZ18QXOt/+wrhUnzRbReX+vfE4+BvNBZi2NtvgSq6uDqS4PRBsU
   Eq68pB2SQxgjytEOuQ8NHgH7Vvf/uBiF/1jo+C506+l242clXih1z3PrZ
   2rhTXX3fCjr3rpl7gRLNztytKRn1mGVTftIddhnLB3u7OBiVhDGmzCrcd
   U=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: GWof63ljdIl+8znsHOqtglYI4iHAiA1fFtyr6ofjbA3s52/+Zf2L/O3Ie0i/W0BcrQRO6NiIxS
 yI/uBJrrfrxs8llhF133NRQK7idhwomzIh4UbjxXDLfP0pB2IzJAu6lParFzd/NpxL7HXxhRyv
 AUyFrPFTDhF2ccZC2Wz67xLjROQTRGCf1SnQxw9WT4+fdERN7pifGRs2epzpZISEIuw+4Jn+LK
 s5aRevaShRCr7ltScS5Y7WP6S3EKBJEG/46mmZHR2s8RMo3wfRcO5uiRnuEWF7qDU9u3dE1J3F
 +3RVrj2PPtC4n3PqjCfcFFrB
X-SBRS: 5.1
X-MesageID: 63657343
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:gck4m69DbNEJX3Ned3hGDrUDWHmTJUtcMsCJ2f8bNWPcYEJGY0x3m
 DMYXzjUPfyMZWGgeYx/b9vk8ExSsJ7Xm4AwQFFupSE8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhFWeIdA970Ug5w7Rh3dYy6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPgux
 Mtik6W1az4GFZLToKMnchsGTQZHaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguwKKsXxMZxZkXZn1TzDVt4tQIzZQrWM7thdtNs1rp4VQ6uBP
 JZCAdZpRDH+QDgfGnwcMa4jh+fvt0vgWmJX9F3A8MLb5ECMlVcsgdABKuH9ZdiiVchT2EGCq
 Qru72n/Rx0XKtGb4T6E6W63wP/CmzvhX4AfH6H+8eRl6HWRzGEODBwdVXOgvOK0zEW5Xrpix
 1c8o3R06/JorQryE4e7D0bQTGO4UgA0BNZOPMsD7SO05YHr/D7ePEkGEGBmUYlz3CMpfgAC2
 liMltLvIDVgtryJVH6QnoupQSOO1Ts9djFbO3JdJecRy5y6+dxo0EqTJjp2OPPt1rXI9SfML
 ydmRcTUr5EaloY12qqy5jgraBr898GSHmbZCug6N19JDz+Vhqb4PeRECnCBtJ6sybp1qXHb7
 RA5dzC2trxmMH10vHXlrB8xNL+o/e2ZFzbXnERiGZIsnxz0pSL/JNEJuW8vfh4yWirhRdMOS
 BWC0T69GbcJZCf6BUOJS97Z5zsWIVjISo2+C6G8gitmaZltbg6XlByClmbLt10BZHMEyPllU
 b/CKJ7EJS9DVcxPkWrnL89AgORD7n1vmgv7G8uhpzz5iuX2WZJgYepcWLd4Rrtit/3sTcS82
 4s3CvZmPD0FDLSuOXeGrdFPRb3IRFBiba3LRwVsXrfrCiJtGX07Cu+XxrUkeod/mL9SmPuO9
 Xa4MnK0AnKm1RUr8C2GNSJubq3BR5F6oS5pNCAgJw/wiXMifZyu/OEUcJ5uJesr8+lqzPhVS
 fgZeprfXqQTG2qfozlNP4PgqIFCdQiwgV7cNSSSfzViLYVrQBbE+4G4c1K3pjUOFCe+qeA3v
 6akilHAWZMGSgk7VJTWZfujwkmfp38YnO4uDULELsMKIBfn8ZRwKjy3hfgyepleJRLGzzqc9
 gCXHRZH+rWd/95rqIHE3PnWoZ2oHu1yGlthM1PatbvmZzPH+meDwJNbVLradz7qS26pqr6pY
 v9Yzq+gPaRfzkpKqYd1D51i0bk6u4n0v7ZfwwlpQCfLYlCsBu8yK3WKx5AS5KhEx7sfsgqqQ
 EOfvNJdPOzRas/iFVcQIisjb/iCiq5IymWDs6xtLRWo/jJz8ZqGTV5WbkuFhyFqJbdoNJ8on
 LU6s8kM5g3j0hcnP75qVMyPG7hg+pDYb5gaiw==
IronPort-HdrOrdr: A9a23:oDmk3aFL9BDOfHjVpLqFTJHXdLJyesId70hD6qkvc3Nom52j+/
 xGws536fatskdtZJkh8erwXZVp2RvnhNBICPoqTMuftW7dySqVxeBZnMTfKljbdREWmdQtrJ
 uIH5IOa+EYSGIK9/oSgzPIU+rIouP3iJxA7N22pxwGLGFXguNbnnxE426gYxdLrWJ9dP4E/e
 +nl6x6Tk2bCBMqh6qAdxs4dtmGg+eOuIPtYBYACRJiwhKJlymU5LnzFAXd9gsCUhtUqI1Ssl
 Ttokjc3OGOovu7whjT2yv49JJNgubszdNFGYilltUVEDPxkQylDb4RGYFq/QpF5d1H2mxa1+
 UkkC1QefibLEmhJ11dlCGdnzUIFgxes0MKh2Xo2kcL6vaJOw7SQ/Ax+76xNCGptnbI9esMoJ
 6ilQiixutqJAKFkyLn69fSURZ20kKyvHo5iOYWy2dSSI0EddZq3MYiFW5uYd899RjBmcsa+S
 hVfbXhzecTdUnfY2HSv2FpztDpVnMvHg2eSkxHvsCOyTBZkH1w0kNdnaUk7zs93YN4T4MB6/
 XPM6xumr0LRsgKbbhlDONERcesEGTCTR/FLWrXK1X6E6MMPW7LtvfMkfgIzfDvfIZNwIo5mZ
 zHXl8dvWkue1j2AcnLx5FP+gClehT1Yd0s8LAp23FUgMyPeFPbC1z1dLl1qbrSnxw2OLyvZ8
 qO
X-IronPort-AV: E=Sophos;i="5.88,350,1635220800"; 
   d="scan'208";a="63657343"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=YIqLeKMUEFuvoW8lmRe6UydowfFU3yhktN7v6GDM6tfBX6TAdjvW25Cv/fCxMkzw7KGVlw3LXyx1lgOYQmRQdEF22pL9/romvdPLX/MlUG61/rMQiiOJlz33f2onI5nDLtfulQfeu4pu28Ar0vVk/N/IKFeohvZ2ED8a1D0lTeShR6KAet1FiOQSl2w8DCBU/1pgnLe60t62bwyiUAfRi8nGg20e3cJZibmmrHljUQYu91aQtFNaXl6YZ3tF5nuG29jYJeziC7jC+bgScjROwv+6mOoSum92z/9FhnnAJejYyumd5VEB+kF1KjVW0AzhP32icZwYQqC00AGj4b4JmA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=RVMMGcshLYbP+PZLZfceTFwbCv1XB7f4eHmsO1KU/SM=;
 b=eZXiTZCLeDwxinSYKx8MbNonTAowprmsMIjbXwHc5UoXUmc+mKHY5Xo0gkobtgG0k348TsmdOadUSgb6D2LM9Vg4khBtpOztZijFJcNu451rWriOztTpGv9ULPSDr6CWzxta7eSk/tmb/xShquDjW5fUDlO4dDVEB3w4Nv9ZZLh6RH5ISfzE/jvzKYtdXujpxOSGHNdVGmMNJkwnRWnTNIa0KT1pDV+kK/cWf9GMhFTlaqzfBIkrBKX4x40vuD79iffqrUpBYpABOMbkix7cyBIL+kTSVChZNNKq3QWqSxpXD/mS8P3L0zOBTgEqMAxhPLHIA6u4tx9j85DtvbI4iA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=RVMMGcshLYbP+PZLZfceTFwbCv1XB7f4eHmsO1KU/SM=;
 b=ZI6uSKTvhbM69NaIbc031wNi2jMF+syK/7cREf0YBVWv0JUUxdkZmRR1Se8SCm0/OuLHJB4Ke+oqQsno6/+qSiJnx1quzFqlrqp2Y/l8yazlwKUWqk+RAweAOsy72/QpQLs+qUq9f7yn7lsMfdVwmJjoMaDxOYNkffAyfz6oLsQ=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>, "Roger
 Pau Monne" <roger.pau@citrix.com>
Subject: Re: [PATCH] x86/hvm: Fix boot on systems where HVM isn't available
Thread-Topic: [PATCH] x86/hvm: Fix boot on systems where HVM isn't available
Thread-Index: AQHYGe2Id8FyB0tJFkegbPCVP/nSPKyEtt+AgAMO4ACAAH4rAA==
Date: Mon, 7 Feb 2022 16:00:55 +0000
Message-ID: <0a39be87-0c0b-5ac4-8c89-6a4844034bd6@citrix.com>
References: <20220204173405.22759-1-andrew.cooper3@citrix.com>
 <Yf5HpzveBK+Ho3Nt@Air-de-Roger>
 <4555a325-96c5-4fc8-5d6f-a5fe0f47146d@suse.com>
In-Reply-To: <4555a325-96c5-4fc8-5d6f-a5fe0f47146d@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.1
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 91b69103-4538-4a13-dc5c-08d9ea530618
x-ms-traffictypediagnostic: CO1PR03MB5937:EE_
x-microsoft-antispam-prvs: <CO1PR03MB59377D2B7178ABD30165F0CCBA2C9@CO1PR03MB5937.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8273;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: kpzwp94BXAnfAN4Txri2ppSaPQePrHBuapUS3raGkDNAGbn/Pf+rezRUGQHrXc7yC7if46PAlUTvO/CEwBvEWtHno2sO6i5SL1uT5cD0ygdcn/IBvJue940B0fTnbh23pJgSL96jv+SIDa7fe1PMFYW608CEJCJrvun/8hW1TwEhLTK/ow8crtoNzaDG6rH5230R/mYoGYwayqhLNJ5xdyqOKjDmnzf/JDY4roK/mtGqfpCKBmG/7IM/rFrlQ2sQY385ezjtVR574ImTLZP+K/ZNkKV9QUMxD+5wruv9W+DuQ2btUfieoxmFJioyhIlQj79PeAR6ILuFF0EF0n9ssTPG0hcUi/Eg4D29dF3q5py9BFHYVHJ9RsU24uCmcjevwAdwCPrSUvxDEeD5hWrko00YD0icRZ94z0cdW5GfZK1QplOf1K4UXEAQH5Zs3COvyG33n4aBM0ccp8T8zqL4cNdiNrHCBGcc3Ww/E4S8q82dWhLqarqlx5uhAFT/uWylnE7K1zRqo1xi5tTxwJ8i7+3cPessE/47CVB9DxLWYG42EVYQP8X4KJ5Rwyo2lJioL37sMm0YldK4OJwQQTthUIuMSeNKUkGA7Fw72gzlPbmzpGbX1gG8j/3gWoicjaYJSw8/x1cjMevma6IpUUpH62IR+cEOP7NS5BiWRxlbdwA9958A5zOPksjsNVOKjVe5rnhxpKteOeRtJc2o8b67VELdpFyRXs7NCXwO51cJHFi1olJSHPmDTitL7cTzmsiB2lZh9DvSPyBC++flRsz9BQ==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(83380400001)(316002)(6916009)(8936002)(38100700002)(122000001)(107886003)(64756008)(31686004)(66476007)(66556008)(66446008)(66946007)(54906003)(2906002)(4326008)(91956017)(76116006)(5660300002)(36756003)(8676002)(38070700005)(71200400001)(82960400001)(508600001)(2616005)(6512007)(6506007)(53546011)(26005)(186003)(31696002)(6486002)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?THN0UVpCcjBNZ2wxbXdPSm55ZHU2Z014aFBxaTc4amRReWJxUzFtUWVMa0NI?=
 =?utf-8?B?aDkrS2RCcUNJWGFZM1Q1cmFHVFdNMU1YYVJBVjFHNDZVWUJFUVV4WlB5SmlZ?=
 =?utf-8?B?WUNzQXViY2tNWW10M25QTGhFTGFoM2lVNUt4cHpMUmR2cUlCNVpUK200cFRL?=
 =?utf-8?B?cEk0RzZ4Y3V4RjI0QkFka0U1cjFzN2hWMWJCK1czNUJxaGJBeTQ5UEhwL1Rj?=
 =?utf-8?B?dWNFbEcwNU5DQXg0ZllqY0QzRUltQWx5Z0Q1SVgwcVZNSjdKZGY4dFp3ZHVy?=
 =?utf-8?B?Rk9rK2RxanRhbGdadGhRWGtuMFRnVGU0ME5jWWUxSGg4c3RUSnFyWDJsU1Fr?=
 =?utf-8?B?bE9KUEFwaStnMjlnYzl1cUF0WTVWdW4zWjRtT0VSMytDVnBkNVMzenFIU20r?=
 =?utf-8?B?NjliMTlFTlVoMDdLVi9RT2lCSE1WOGpHK3JMYVdEaVpnR1pqdXJONkJtY3lI?=
 =?utf-8?B?b21LWVNIUTFHQ1dLWnA5Q1NCTytlRHJTUm9BL29LUFh6NlNJb1ZKeGhnZkhK?=
 =?utf-8?B?MThGOFhwYVd3TU5IdFE2bW9hbU9sTWJaRFVUUk1leFVuL3JONHhSdlIxd1g2?=
 =?utf-8?B?SWhTV0tvUElGb0U1b00zY0laSm1GN0ZpYlJBS2hUK3VPcnNKaHR1UXVPK3Vp?=
 =?utf-8?B?Ni9Lc2VpaFY5bEFvaGFLYzE3T0VWV2RBaHFMMVB4ZTd2VUMxZUlSUHFhZks3?=
 =?utf-8?B?WVZWZWFKUFU2YWVLRitiVk83eXJyaUd1K09adlUrVWFYMTNVNU14eWRWWVBD?=
 =?utf-8?B?SElPUWZpQVJCa3dMTmVPOHlacnQrTHJiUVpDWlpxSlZHTnpSSVZ5TTBGT1dL?=
 =?utf-8?B?UURIVDE4RnhxYmNORHloMG9CbXBoYVdSM0E2ck9YTFhaU29RYzVjRk82M3JI?=
 =?utf-8?B?T25mRWZ6QkE0by85MUlNa1N6WjN4MzNlYWg4UzU5cGdRcXRvdHJTUUhodXZZ?=
 =?utf-8?B?cmo2dWtXMlo1UVdUbkZGMUJqS1FrV3BvUjlrajB5V0RBUGh2WGVTZ25DNzFr?=
 =?utf-8?B?TU4rOUdQbklBaCt1YXdWbEgxb2VVbkhWc1cyZFJJRXhaV1FmRHNvdEVVQmJn?=
 =?utf-8?B?MzFJRVNyMnQzdFVmanhoOTNvVUxXN0N5OVVvYmhwRHBaS0p4ak9MODVBdFdG?=
 =?utf-8?B?ckFjTWxWdUw3dnRQVmN2SkRydWxQZ3NLbU4vYzl1RnN6bUV2NkZsRVBZMDd6?=
 =?utf-8?B?YTlMV3o4VGwrYVJSR0tUSk1DaXhoM1dkRWZqc2Z0WG9KSlNhTzBDRldpWVdJ?=
 =?utf-8?B?SmNJWW55YlhrUGFmVDdHMkxmRzlMUSsvT1p1aHZHTlYyVU9zZWY3R2RoSndm?=
 =?utf-8?B?Z3dRWTR5WkZFaHh1bzZDR3plaUdWZU8rVVVvYSt6Rk1naTVkbmt3eEo4L0xr?=
 =?utf-8?B?QWM2RHhnazliaUMrbXVKYncra3oxOFg1NzB3eDFLTDlCTkhYNFBvOU9JY1o0?=
 =?utf-8?B?b3hnMWhDKzQzdzU1Unc4dDEwR2l5Z0NnVVdLRHNYaE52ajVDbCtQT2hhdEdC?=
 =?utf-8?B?djlycEJydXh3MkRkUXRaUStQeTBKdTl0N1NMUGUzTmJiQW5UTkUvV3owSnRo?=
 =?utf-8?B?MzJVWkZnQkQ5QXF4K2YzZm9VRUFwRVQ5WnFQQnRhY0tYcVkyWE9IZkU3YTI1?=
 =?utf-8?B?akR5WUpJRGJOanZYSGNTcHNjLzc1dnd4dEZ6b0RVMklZcSs0WFp2TUR0R0N1?=
 =?utf-8?B?UFNtUG1HODV5Qkw3TXBjY0xoeDB1aE1yRXhlaFdBRTFBNHIvMUtSYUpNcjhU?=
 =?utf-8?B?dE1MZFQzKzZUNmVJcWZaSXJWQTkvdXp2ZzRoRGM1cGJ5M01Dd3hHZ0FGSy9B?=
 =?utf-8?B?WDZ1cVIrc096WlQwYmI5THlyMnlyL1ZuREcvRmE0eXdWQ04yWGtxRG9kdFpi?=
 =?utf-8?B?T3VGS2JPQlFCRUVldmlMSDBEY05kendBNm9MdkdEVVp1WHBOR3F6YlVkc0M4?=
 =?utf-8?B?ZmVnOGtqbTg4VTVBMGpad0thYTdVMW9tcHhqa0U5T3Q5Z0xQQ3RiUDM2R3pC?=
 =?utf-8?B?WVBHdmpwZWxHdTE5UnRIdTUreGhTM2dNVzB5UWd2Tk9SOWU2Wk94cDU3cHd3?=
 =?utf-8?B?ZlZoTHUwLyt5NEdZN01sRGUrUzNxWld4Z2VWOW9UYndUeWtyQU5Ed1NkWGFz?=
 =?utf-8?B?d3RiU3NoOUc2SDZ1U29mZkxBcndlWld5Q3dOZUJadTQwcElHeGsraHRtNFJZ?=
 =?utf-8?B?RTdDVjZxOVRoemlCWHlhK1lZMUc0VHN0a0tzdW1ObzQxTlFEYWNTcGI2T3gz?=
 =?utf-8?B?ZjAwK0hleTRta2djcXZWVU5jYmtRPT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <55C25F31FD20C74DA0EBBB7A67BE156E@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 91b69103-4538-4a13-dc5c-08d9ea530618
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Feb 2022 16:00:55.3394
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: g0QO8fUVNlRKRohMyvhgOESYjcxI8VPejrVM6GwLZOc0dx4hgTnr3aE4fWcGTLgsXJHVZ6mkH2Lw0zkZRQhIHKqAPG0tj9C0llf53UmBVWU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR03MB5937
X-OriginatorOrg: citrix.com

T24gMDcvMDIvMjAyMiAwODoyOSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDA1LjAyLjIwMjIg
MTA6NDcsIFJvZ2VyIFBhdSBNb25uw6kgd3JvdGU6DQo+PiBPbiBGcmksIEZlYiAwNCwgMjAyMiBh
dCAwNTozNDowNVBNICswMDAwLCBBbmRyZXcgQ29vcGVyIHdyb3RlOg0KPj4+IGMvcyAyN2E2M2Nk
YWMzODggKCJ4ODYvSFZNOiBjb252ZXJ0IHJlbWFpbmluZyBodm1fZnVuY3MgaG9vayBpbnZvY2F0
aW9ucyB0bw0KPj4+IGFsdC1jYWxsIikgd2VudCB0b28gZmFyIHdpdGggZHJvcHBpbmcgTlVMTCBm
dW5jdGlvbiBwb2ludGVyIGNoZWNrcy4NCj4gT2gsIEknbSBzb3JyeSwgSSBzaG91bGQgaGF2ZSBu
b3RpY2VkIHRoaXMuDQo+DQo+Pj4gc21wX2NhbGxpbigpIGNhbGxzIGh2bV9jcHVfdXAoKSB1bmNv
bmRpdGlvbmFsbHkuICBXaGVuIHRoZSBwbGF0Zm9ybSBkb2Vzbid0DQo+Pj4gc3VwcG9ydCBIVk0s
IGh2bV9lbmFibGUoKSBleGl0cyB3aXRob3V0IGZpbGxpbmcgaW4gaHZtX2Z1bmNzLCBhZnRlciB3
aGljaCB0aGUNCj4+PiBhbHRjYWxsIHBhc3MgbnVrZXMgdGhlIChub3cgdW5jb25kaXRpb25hbCkg
aW5kaXJlY3QgY2FsbCwgY2F1c2luZzoNCj4+Pg0KPj4+ICAgKFhFTikgLS0tLVsgWGVuLTQuMTcu
MC0xMC4xOC1kICB4ODZfNjQgIGRlYnVnPXkgIE5vdCB0YWludGVkIF0tLS0tDQo+Pj4gICAoWEVO
KSBDUFU6ICAgIDENCj4+PiAgIChYRU4pIFJJUDogICAgZTAwODpbPGZmZmY4MmQwNDAzNGJlZjU+
XSBzdGFydF9zZWNvbmRhcnkrMHgzOTMvMHgzYjcNCj4+PiAgIChYRU4pIFJGTEFHUzogMDAwMDAw
MDAwMDAxMDA4NiAgIENPTlRFWFQ6IGh5cGVydmlzb3INCj4+PiAgIC4uLg0KPj4+ICAgKFhFTikg
WGVuIGNvZGUgYXJvdW5kIDxmZmZmODJkMDQwMzRiZWY1PiAoc3RhcnRfc2Vjb25kYXJ5KzB4Mzkz
LzB4M2I3KToNCj4+PiAgIChYRU4pICBmZiBmZiA4YiAwNSAxYiA4NCAxNyAwMCA8MGY+IDBiIDBm
IGZmIGZmIDkwIDg5IGMzIDg1IGMwIDBmIDg0IGRiIGZlIGZmIGZmDQo+Pj4gICAuLi4NCj4+PiAg
IChYRU4pIFhlbiBjYWxsIHRyYWNlOg0KPj4+ICAgKFhFTikgICAgWzxmZmZmODJkMDQwMzRiZWY1
Pl0gUiBzdGFydF9zZWNvbmRhcnkrMHgzOTMvMHgzYjcNCj4+PiAgIChYRU4pICAgIFs8ZmZmZjgy
ZDA0MDIwMDBlMj5dIEYgX19oaWdoX3N0YXJ0KzB4NDIvMHg2MA0KPj4+DQo+Pj4gVG8gbWFrZSBt
YXR0ZXJzIHdvcnNlLCBfX3N0b3BfdGhpc19jcHUoKSBjYWxscyBodm1fY3B1X2Rvd24oKSB1bmNv
bmRpdGlvbmFsbHkNCj4+PiB0b28sIHNvIHdoYXQgaGFwcGVuIG5leHQgaXM6DQo+Pj4NCj4+PiAg
IChYRU4pIC0tLS1bIFhlbi00LjE3LjAtMTAuMTgtZCAgeDg2XzY0ICBkZWJ1Zz15ICBOb3QgdGFp
bnRlZCBdLS0tLQ0KPj4+ICAgKFhFTikgQ1BVOiAgICAwDQo+Pj4gICAoWEVOKSBSSVA6ICAgIGUw
MDg6WzxmZmZmODJkMDQwMzRhYjAyPl0gX19zdG9wX3RoaXNfY3B1KzB4MTIvMHgzYw0KPj4+ICAg
KFhFTikgUkZMQUdTOiAwMDAwMDAwMDAwMDEwMDQ2ICAgQ09OVEVYVDogaHlwZXJ2aXNvcg0KPj4+
ICAgLi4uDQo+Pj4gICAoWEVOKSBYZW4gY29kZSBhcm91bmQgPGZmZmY4MmQwNDAzNGFiMDI+IChf
X3N0b3BfdGhpc19jcHUrMHgxMi8weDNjKToNCj4+PiAgIChYRU4pICA0OCA4OSBlNSBlOCA4YSAx
ZCBmZCBmZiA8MGY+IDBiIDBmIGZmIGZmIDkwIDBmIDA2IGRiIGUzIDQ4IDg5IGUwIDQ4IDBkIGZm
DQo+Pj4gICAuLi4NCj4+PiAgIChYRU4pIFhlbiBjYWxsIHRyYWNlOg0KPj4+ICAgKFhFTikgICAg
WzxmZmZmODJkMDQwMzRhYjAyPl0gUiBfX3N0b3BfdGhpc19jcHUrMHgxMi8weDNjDQo+Pj4gICAo
WEVOKSAgICBbPGZmZmY4MmQwNDAzNGFjMTU+XSBGIHNtcF9zZW5kX3N0b3ArMHhkZC8weGY4DQo+
Pj4gICAoWEVOKSAgICBbPGZmZmY4MmQwNDAzNGEyMjk+XSBGIG1hY2hpbmVfcmVzdGFydCsweGEy
LzB4Mjk4DQo+Pj4gICAoWEVOKSAgICBbPGZmZmY4MmQwNDAzNGE0MmE+XSBGIGFyY2gveDg2L3No
dXRkb3duLmMjX19tYWNoaW5lX3Jlc3RhcnQrMHhiLzB4MTENCj4+PiAgIChYRU4pICAgIFs8ZmZm
ZjgyZDA0MDIyZmQxNT5dIEYgc21wX2NhbGxfZnVuY3Rpb25faW50ZXJydXB0KzB4YmYvMHhlYQ0K
Pj4+ICAgKFhFTikgICAgWzxmZmZmODJkMDQwMzRhY2M2Pl0gRiBjYWxsX2Z1bmN0aW9uX2ludGVy
cnVwdCsweDM1LzB4MzcNCj4+PiAgIChYRU4pICAgIFs8ZmZmZjgyZDA0MDMzMWE3MD5dIEYgZG9f
SVJRKzB4YTMvMHg2YjUNCj4+PiAgIChYRU4pICAgIFs8ZmZmZjgyZDA0MDM5NDgyYT5dIEYgY29t
bW9uX2ludGVycnVwdCsweDEwYS8weDEyMA0KPj4+ICAgKFhFTikgICAgWzxmZmZmODJkMDQwMzFm
NjQ5Pl0gRiBfX3VkZWxheSsweDNhLzB4NTENCj4+PiAgIChYRU4pICAgIFs8ZmZmZjgyZDA0MDM0
ZDVmYj5dIEYgX19jcHVfdXArMHg0OGYvMHg3MzQNCj4+PiAgIChYRU4pICAgIFs8ZmZmZjgyZDA0
MDIwM2MyYj5dIEYgY3B1X3VwKzB4N2QvMHhkZQ0KPj4+ICAgKFhFTikgICAgWzxmZmZmODJkMDQw
NDU0M2QzPl0gRiBfX3N0YXJ0X3hlbisweDIwMGIvMHgyNjE4DQo+Pj4gICAoWEVOKSAgICBbPGZm
ZmY4MmQwNDAyMDAwZWY+XSBGIF9faGlnaF9zdGFydCsweDRmLzB4NjANCj4+Pg0KPj4+IHdoaWNo
IHJlY3Vyc2VzIHVudGlsIGhpdHRpbmcgYSBzdGFjayBvdmVyZmxvdy4gIFRoZSAjREYgaGFuZGxl
ciwgd2hpY2ggcmVzZXRzDQo+Pj4gaXRzIHN0YWNrIG9uIGVhY2ggaW52b2NhdGlvbiwgbG9vcHMg
aW5kZWZpbml0ZWx5Lg0KPj4+DQo+Pj4gUmVpbnN0YXRlIHRoZSBOVUxMIGZ1bmN0aW9uIHBvaW50
ZXIgY2hlY2tzIGZvciBodm1fY3B1X3t1cCxkb3dufSgpLg0KPj4+DQo+Pj4gRml4ZXM6IDI3YTYz
Y2RhYzM4OCAoIng4Ni9IVk06IGNvbnZlcnQgcmVtYWluaW5nIGh2bV9mdW5jcyBob29rIGludm9j
YXRpb25zIHRvIGFsdC1jYWxsIikNCj4+PiBTaWduZWQtb2ZmLWJ5OiBBbmRyZXcgQ29vcGVyIDxh
bmRyZXcuY29vcGVyM0BjaXRyaXguY29tPg0KPj4gUmV2aWV3ZWQtYnk6IFJvZ2VyIFBhdSBNb25u
w6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPg0KPiBSZXZpZXdlZC1ieTogSmFuIEJldWxpY2ggPGpi
ZXVsaWNoQHN1c2UuY29tPg0KDQpUaGFua3MuDQoNCj4NCj4+PiAtLS0NCj4+PiBDQzogSmFuIEJl
dWxpY2ggPEpCZXVsaWNoQHN1c2UuY29tPg0KPj4+IENDOiBSb2dlciBQYXUgTW9ubsOpIDxyb2dl
ci5wYXVAY2l0cml4LmNvbT4NCj4+PiBDQzogV2VpIExpdSA8d2xAeGVuLm9yZz4NCj4+Pg0KPj4+
IFJGQy4gIE5vdCB0ZXN0ZWQgeWV0IG9uIHRoZSBpbWFjdGVkIGhhcmR3YXJlLiAgSXQncyBhIFhl
b24gUEhJIHdpdGggYW5vdGhlcg0KPj4+IHdlcmlkIHRoaW5nIGluIG5lZWQgb2YgZGVidWdnaW5n
LiAgRmlyc3QgYm9vdCBpcyBmaW5lLCB3aGlsZSBzZWNvbmQNCj4+PiBib290IChsb2FkaW5nIG1p
Y3JvY29kZSB0aGlzIHRpbWUpIGhhcyBhIHByb2JsZW0gd2l0aCB2bXguDQo+IFNvdW5kcyBub3Qg
dW5mYW1pbGlhcjogTXkgbWVhbndoaWxlIG9sZGlzaCBSb21sZXkgbmVlZHMgdG8gYmUgY29sZC0N
Cj4gYm9vdGVkIGZvciBWTVggdG8gYWN0dWFsbHkgYmUgdXNhYmxlIChub3QgbG9ja2VkKSBvbiBB
UHMuDQoNClRoaXMgaXMgc29tZXRoaW5nIHdoaWNoIGdvZXMgd3JvbmcgYXMgYSBjb25zZXF1ZW5j
ZSBvZiBsb2FkaW5nIG1pY3JvY29kZS4NCg0KPj4+IEkgd29uZGVyIGlmIHdlIHdhbnQgdG8gbW9k
aWZ5IHRoZSBjYWxsZXJzIHRvIGNoZWNrIGZvciBIVk0gYmVpbmcgZW5hYmxlZCwNCj4+PiByYXRo
ZXIgdGhhbiBsZWF2aW5nIHRoZSBOVUxMIHBvaW50ZXIgY2hlY2tzIGluIGEgcG9zaXRpb24gd2hl
cmUgdGhleSdyZSBsaWFibGUNCj4+PiB0byBiZSByZWFwZWQgYWdhaW4uDQo+PiBXaGF0IGFib3V0
IGFkZGluZyBhIGNvdXBsZSBvZiBjb21tZW50cyB0byBodm1fY3B1X3t1cCxkb3dufSB0byBub3Rl
DQo+PiB0aGV5IGFyZSBjYWxsZWQgdW5jb25kaXRpb25hbGx5IHJlZ2FyZGxlc3Mgb2Ygd2hldGhl
ciBIVk0gaXMgcHJlc2VudA0KPj4gb3Igbm90Pw0KPiBJIHNlY29uZCB0aGlzIGFzIHRoZSBwZXJo
YXBzIGJldHRlciBhbHRlcm5hdGl2ZTogVGhlIFMzIHBhdGggaXMNCj4gc2ltaWxhcmx5IGFmZmVj
dGVkIChhbmQgeW91IG1heSB3YW50IHRvIG1lbnRpb24gdGhpcyBpbiB0aGUNCj4gZGVzY3JpcHRp
b24pLCBzbyB0aGlzIHdvdWxkIG1lYW4gdXAgdG8gNSBjb25kaXRpb25hbHMgKGF0IHRoZQ0KPiBz
b3VyY2UgbGV2ZWwpIGluc3RlYWQgb2YgdGhlIGp1c3QgdHdvIHlvdSBnZXQgYXdheSB3aXRoIGhl
cmUuDQoNCk9rLsKgIEkndmUgYWRkZWQ6DQoNCi8qIENhbGxlZCBpbiBib290L3Jlc3VtZSBwYXRo
cy7CoCBNdXN0IGNvcGUgd2l0aCBubyBIVk0gc3VwcG9ydC4gKi8NCg0KYW5kOg0KDQovKiBDYWxs
ZWQgaW4gc2h1dGRvd24gcGF0aHMuwqAgTXVzdCBjb3BlIHdpdGggbm8gSFZNIHN1cHBvcnQuICov
DQoNCn5BbmRyZXcNCg==


From xen-devel-bounces@lists.xenproject.org Mon Feb 07 16:08:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 16:08:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267198.460913 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH6YR-0006nQ-3b; Mon, 07 Feb 2022 16:07:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267198.460913; Mon, 07 Feb 2022 16:07:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH6YR-0006nJ-0P; Mon, 07 Feb 2022 16:07:51 +0000
Received: by outflank-mailman (input) for mailman id 267198;
 Mon, 07 Feb 2022 16:07:49 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=F54n=SW=epam.com=prvs=403792ff6c=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nH6YP-0006nD-75
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 16:07:49 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 160effd0-8830-11ec-8f75-fffcc8bd4f1a;
 Mon, 07 Feb 2022 17:07:46 +0100 (CET)
Received: from pps.filterd (m0174679.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 217EEi4D023735;
 Mon, 7 Feb 2022 16:07:42 GMT
Received: from eur04-he1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2055.outbound.protection.outlook.com [104.47.13.55])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e350urgmf-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Mon, 07 Feb 2022 16:07:42 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by PR3PR03MB6409.eurprd03.prod.outlook.com (2603:10a6:102:74::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Mon, 7 Feb
 2022 16:07:38 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77%3]) with mapi id 15.20.4951.018; Mon, 7 Feb 2022
 16:07:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 160effd0-8830-11ec-8f75-fffcc8bd4f1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Db5XRegZ9noZ4BFAvJ06I3iB+a5F++lHaN4r0bbpg8+lrxeK8ZAFd3HI9wvPfGyx3tfUS7yF+8QhiH6Hgil2zAZV2o2S5VuUG+x58wih48uqSj5Umzq0iEhpU2KUQns6j3I5Ay84i0rx9Q0oO3et8L4H85ISb6/l9z5MoIVrKxutxh3V3supLolBmP4i0LycfssXNhLTMUIGPwsM8UBgdZxJ1qEW3OJsuHAx7oIVrhNAaryLK3WH1hU7kOdWE4qa3H3jqEzYBp6ItM+ET5i6OdzYW8Xr/Ex8MCG4JxQ1ns9vbDQWOzHmvbCgB1n7FqVjnlZPZSbKFn82dqwAOVq/hA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=+SWn2Kpgl1k1I3RrcfPxZW18O59t4Yy656K63/S4fUQ=;
 b=mwXNERONey6NLI1cezvHSu6WjSBlkxI13uzT2Cf7iE0u49WG3U0wOwuxPbA0oXloQqKwktULr9AossJBY+ZkW4YxETF6jJOhi2uagUddQUP9CZUeq42FiW35gF7A0k8WoUABlS5Bi5joCGK4ykG53fEQ9ibsrYfPZi5JAFtJzUDUHoJlWAzdWYhDe0C4nUTFs6jJtzJymQ4OwCaO8amF6G4mIH4cgQmstdTVDNBmVGI+KI8RMij23p0RmMYZDzZF9A+Ghgvnc1UENFRQWyphuZq06mzVs84aZd8xnQoIlqeC4cE1cbsdCaaL4B6OWZqIZJak1Cl1Jtanbf11xcletw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=+SWn2Kpgl1k1I3RrcfPxZW18O59t4Yy656K63/S4fUQ=;
 b=nnjyWfCTaAZl8f3nrPfrFiRR0YioORJ0+b6z8r2X5ejpXGmlmAGpBM817vpt5OxBxCZ3bfsv7fUvPwixc2GgtJui2QbJcU33dE63eElhuBMP2GOxwS4lBN9IN8shuK670y/o6GngwlzNBdB5OWRx4fhsYVOsq3fWlFFDaZt+0lU0lvOT1SogvZL3S/UkrwR/UuqvZ54rmKFIR0ugmxGEeVotP4H+d0RmomdUptU4s3j2ZV5vVlAQdMKrg1Su0E3arpROUly1of5j04VEHoHZ9Vml0cv8g3e9Hrj6PQnl62CoOv3MSR5BEg+pkVIckgDq+wH+f+Pcy4aurVUo4RFHFQ==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?=
	<roger.pau@citrix.com>
Subject: Re: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Thread-Topic: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Thread-Index: 
 AQHYGZFc/MnzQOjwVEeBBUHLSW0md6yDBUkAgAASSACAAATYAIAAD/WAgAAKNgCAAAbfgIAABnuAgAAQvgCAAAMCAIAAAY4AgAADxICAABrnAIAABAgAgAR3CoCAABt5gIAAEpuAgAAE5ICAAASKAIAAAiiAgAAKNYCAAARNAIAAC1wA
Date: Mon, 7 Feb 2022 16:07:37 +0000
Message-ID: <4276fe72-558b-7d95-6430-d4330989dbe8@epam.com>
References: <7e3562b5-fc67-f213-e872-f211450d9e2e@epam.com>
 <a8fc599c-f620-c4d1-2077-c57068f46a7f@suse.com>
 <deef8468-d607-e49e-f456-6a8013329ca1@epam.com>
 <Yf0k6aoKK5G3iad1@Air-de-Roger>
 <3ad10a99-c706-b95f-1419-2c0c7cf37d58@epam.com>
 <Yf0+3C9nF8+tewLw@Air-de-Roger>
 <c5fea3bb-834b-eeb7-d7a1-1ee609037a9f@epam.com>
 <YgEUwTxhnWVMGMJK@Air-de-Roger>
 <9ce90193-74a0-5642-d22b-6b8c3340c3cf@epam.com>
 <1f65ae7a-898d-2c27-0ada-d71d778b0627@suse.com>
 <YgEsRuckQJIQlkzf@Air-de-Roger>
 <a2a42c1d-d379-00cd-5d55-f443cdb02e97@epam.com>
 <e8fc7872-c7d0-f389-c507-335b809ffcbc@epam.com>
 <21c8125a-2f79-1a4a-494c-db9e4be2a1a6@suse.com>
In-Reply-To: <21c8125a-2f79-1a4a-494c-db9e4be2a1a6@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: b0e3f12e-62f8-460e-ec0a-08d9ea53f610
x-ms-traffictypediagnostic: PR3PR03MB6409:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <PR3PR03MB64096157DDE2AE000208C1BFE72C9@PR3PR03MB6409.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 FKmiA696oJj75rwJ2AWp19xQc2HZlwWVZDE9rl7NW+kOBkaK1WSS1lxXDiTJU7wtGKFNbScOAAArwjXUrIExQRXE/PCuq1oAKllT2n+VBg2w/UUSb4cJIxNsqb6fRcGMQVC/xmlPSGHaLzfNl1tJZxznxwhUKMWRsGTqiscw4aL9UmqQLmaXKzi/N65RP7pCQDorasuB6XYW4wfYg+UZtzkizYpKv0hRpwrKzQyzcU7v5ynlCThMqH5hLyjIOXKPc7AaG/335DcC77k0xLeUhWcfouEkwBNMFrcxQajHqQ+HLU4plAySE4MOIYrZH5tELo7ESNJ0uYwrp30nCEZXe9VZYtQo7aXrzt7GplueFO8sqPXssyDLHvMoxeoAgxlbG82tBaKSXALSihCushvGfxVfh7wwfyKDA2dH7jlU5shEBaxFXBLB5asw+gBsPya5d2skSX4nyHDW/23B72knJdYNkbqL6LkNSMioCVxzyNXONzFpmmzQEk+liRXe9OtkpOQChitOM+AlsbYhNpLJ7DfBTQourR9QqRiskExglleMyujoUTx8PvHJgUPZFUrV+TkZunrzgOXKjHOmFf8KP6acKxV5QFiPX/2Oh+IJG9SbYHQ3lmF1RbO16kdI7STVXSrZGKi9igX6K3pEcE+Cpwpiw61I6825Gpv67T2sjfqZlq3BAVEqVgZUAwLvA2dZl4A9fcnLGEEqXzBEq+d3a3U28I0j2HDu2hpTTFNqlrVrWLzzd155Zjp3kDH6Fu0i
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(26005)(36756003)(186003)(6506007)(316002)(54906003)(38070700005)(6512007)(6916009)(71200400001)(2906002)(38100700002)(2616005)(122000001)(55236004)(31686004)(53546011)(31696002)(7416002)(91956017)(86362001)(66946007)(5660300002)(83380400001)(508600001)(6486002)(8936002)(4326008)(8676002)(76116006)(64756008)(66476007)(66446008)(66556008)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?V1JDNGVlOHJWYWVxakRrejBSc3g5KzQ0M3pnbEpDTFZISkN6QnpZWWtzeHJD?=
 =?utf-8?B?M1VMYkNYdm54cUVmQTJzclh0bmF6b3ZzOGt2T1RnYTFMRER3S0JCV3F4dlNl?=
 =?utf-8?B?MDkrZENva25zclYySTliRjZ5RHdCeEhBOFhnMzJ1TXMyajZVODJlTzBJcjFP?=
 =?utf-8?B?MDJadjlJYzQ2S1VRZnBvSjRDbjVZdlpkMHh0dW5kQ3BXd1l5SVRKV2NJSFli?=
 =?utf-8?B?OXlMT0haL0s0UUlkbm13UlV0ZlJoWTJ0YVAwU3c1YVorSTNFelhVR0R6ZXdi?=
 =?utf-8?B?cGd2aWNXN3NWbzU4OWdjSWxyUXpRQzNVSlhKK2lZU1hJajZta25obVRybWov?=
 =?utf-8?B?VVdlT1ZSYS8wK2RMNFhVYlpjcTJiWjBwRDJ1NmJyZWIwcWY5VWNZUGxjQ2xB?=
 =?utf-8?B?R2RvOWVBVmRnalVCNXlkL1dRMU5JdVhrbjkxUi92aE5vV2VOcldqbElrM25D?=
 =?utf-8?B?cmNaRGlIMVUyY2JWOGFpVGNYcUxmOWtubjd6K2lIdmdEMXZjZ0lmaFpPbWhC?=
 =?utf-8?B?bHI1Nzg3aUsxbGN3UFB3d09Ja0M1M2NqQjB5OTNyQzE4b3MveTJqRU1lMThB?=
 =?utf-8?B?ZzAraGZZYU9OVi9aMnhWdW1nT2htRG9TUWJDeFNUcXpMd0prSzBIa08wcFZG?=
 =?utf-8?B?bzY4VzdnYlRDTnRYWkRLSTBNR3YvTC85MVhySGYvTWRLVkZZcUFRV1ltRnV3?=
 =?utf-8?B?dFVRQ3RlZWwxaC9jSFMvT0t3R1ZQU0R1V2xHUlhOT3VlWXFNRnJBYjJocFlq?=
 =?utf-8?B?OHdpYThYbE9wL2Q5T2ZrY3NkZ0p2ekw1MVFLSkRCcWpkbkx6VFJnaFRwWUt5?=
 =?utf-8?B?QVR1OVZxL1JwWWZQVklYWHpjcG5mdkhRclV0eFM5Wm1GSThaSnlkMGpIc3hp?=
 =?utf-8?B?bDd5YStOZ3JnOXhBZWpLNDZ0WGJkSUVZc0tIYWR1VmhpQ1NwUmNUdHJUcEc0?=
 =?utf-8?B?MUVYejhrMzFXdzBzaDNHaStlVHJ2eTF0T1dRbVFHdDVrMHZNcEJEMFYrdjJ2?=
 =?utf-8?B?YXpJcG4zM0x6U3FzemxWSEtDQ29oVWxDZ0NmU2ZldHUrTWZnT0J4eFFMeW1R?=
 =?utf-8?B?Y3RDNTZBRzRiVkdJaUJJMExENVFKcnJ5QWljMXVHdUNMdzljTjJzcVVMdTVi?=
 =?utf-8?B?eW1ROE1PY3k1TUdmL3VaMWI3azUrb1BDWEtjQmRPWTd5OERYMUdYTXVaN2Iz?=
 =?utf-8?B?d0dESGwzczVBd1NnZllLVHBTQVhKcjV0WWlWTERESSt2TktKcG91dThCZjdW?=
 =?utf-8?B?TlNDeGtXTmU3b1J0VWlRQjI1VklKS0tQNFhabERucHBaSy9iZWRGWkgya2ly?=
 =?utf-8?B?NXpicnJxV2taQmFXSXp6eXg1d3ZMZkJYbkF4NDBnNVlmK0l5akxtK3lOWENF?=
 =?utf-8?B?V3V0RFNTM09JU1ZZWDFCamFzOWo3ZzN4SzREV3FpcUZDYkE0ZVRlbUtwQllI?=
 =?utf-8?B?R0lQRnhUb2FOS0xwWkd5bDVXTnlwRXRWMDRjcHBwMVQzbUp4RGM2d3pGenNz?=
 =?utf-8?B?NEdSYWhVd0dHSGJrZVEwb2UvZGt1Ly9STFlDMFkwWnVJU3F3bW5ZNmJ4Y1I2?=
 =?utf-8?B?MXdCckNTZWppSEwvMkI1WlhzU1AycW9yclU2WFo4dnQ5ZUdlQXF0YkNuMUZo?=
 =?utf-8?B?T1FOdStLZ1kvUUo3aENZNVd1cWoyb2h1ZndobnB4eFVTTUtZQU4yRFRDYlM4?=
 =?utf-8?B?UERLVHMwd1JpaWpGdjBnTldiSVo0RmNDVHFvSDdOQ2FGOG5qVTRNaFNNUFln?=
 =?utf-8?B?a29mQVQvQTdOZnB4ZmNrdjJVZm9IYThVNEozcFFKeDZsRWh0cWZFOHVpSXB0?=
 =?utf-8?B?MlNXZTZ3eTl5SzU5WGtqM2lXOWRZYm1mL1VqS1VNZkFTSkc0WXRzWDY5eVY4?=
 =?utf-8?B?cnUwaS8zTFdYRGZRbjN6TVZlOFlQYnhjUVdyNFdLSGExUGxDMTdWRGhYeG9T?=
 =?utf-8?B?WGhsNVRIV1Qxb0FkTjNXcGU1TmtzV2syRDA0YjQvZHZHS2lyVGtxdHNXTkZG?=
 =?utf-8?B?YU1HMndkVXA1eHZuYW5jK1JOZm9wVktPY0JZSTM4R3Y4NmxxbWU4TldLSTNS?=
 =?utf-8?B?N2dwLzM5R1BjeVVXRDlGYkw0L0JObnNLalIzdnF6VlE5cTgyLytjWVdObkdH?=
 =?utf-8?B?QlJtckhXR2RITmZ3aXlKb0o1WFZiQkNYRHZyZGNKTUNGTFRPY2o5TU5tZ29x?=
 =?utf-8?B?TUIyTkp5a2lZdlo3UW93S01ydzN0akZ0WHZobGhMNjdlb1FwbWtCa1Q1Umpt?=
 =?utf-8?B?U1MwdHphbWdQZE9TNFArK05BWkc0MVEwOENCcUtmQkN4N05NVFhmWVF1QVoz?=
 =?utf-8?B?NXNVMzhSR3BLUnU3U0kzcVZESTdyaElSR2JiV2NiOG4rZXdaVkEzMmd0Ukkz?=
 =?utf-8?Q?cg/tJXZL7jP3/uJI=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <CF9E95552CF43D48873BBA15D4B1F04F@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b0e3f12e-62f8-460e-ec0a-08d9ea53f610
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Feb 2022 16:07:37.9875
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: thoXpcI97TxFpP+X1HRMb2BvhBL2YkXrECkxmb7csKShyqv631pkj1+bPzRgWpqWcu7czdj3+Mc7oRbPAIW8K7yIx3558fzbao6dzXoHyV7Vn6UMGtiRsRi3A5ADGiM9
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR03MB6409
X-Proofpoint-GUID: euhFo-nVDmh645TQleWGKeF3ejdhGhi7
X-Proofpoint-ORIG-GUID: euhFo-nVDmh645TQleWGKeF3ejdhGhi7
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-07_06,2022-02-07_02,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1015
 impostorscore=0 phishscore=0 mlxscore=0 spamscore=0 priorityscore=1501
 lowpriorityscore=0 mlxlogscore=999 bulkscore=0 malwarescore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202070102

DQoNCk9uIDA3LjAyLjIyIDE3OjI2LCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMDcuMDIuMjAy
MiAxNjoxMSwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+Pg0KPj4gT24gMDcuMDIu
MjIgMTY6MzUsIE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4+IE9uIDA3LjAyLjIy
IDE2OjI3LCBSb2dlciBQYXUgTW9ubsOpIHdyb3RlOg0KPj4+PiBPbiBNb24sIEZlYiAwNywgMjAy
MiBhdCAwMzoxMTowM1BNICswMTAwLCBKYW4gQmV1bGljaCB3cm90ZToNCj4+Pj4+IE9uIDA3LjAy
LjIwMjIgMTQ6NTMsIE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4+Pj4+IE9uIDA3
LjAyLjIyIDE0OjQ2LCBSb2dlciBQYXUgTW9ubsOpIHdyb3RlOg0KPj4+Pj4+PiBJIHRoaW5rIHRo
ZSBwZXItZG9tYWluIHJ3bG9jayBzZWVtcyBsaWtlIGEgZ29vZCBvcHRpb24uIEkgd291bGQgZG8N
Cj4+Pj4+Pj4gdGhhdCBhcyBhIHByZS1wYXRjaC4NCj4+Pj4+PiBJdCBpcy4gQnV0IGl0IHNlZW1z
IGl0IHdvbid0IHNvbHZlIHRoZSB0aGluZyB3ZSBzdGFydGVkIHRoaXMgYWR2ZW50dXJlIGZvcjoN
Cj4+Pj4+Pg0KPj4+Pj4+IFdpdGggcGVyLWRvbWFpbiByZWFkIGxvY2sgYW5kIHN0aWxsIEFCQkEg
aW4gbW9kaWZ5X2JhcnMgKGhvcGUgdGhlIGJlbG93DQo+Pj4+Pj4gaXMgY29ycmVjdGx5IHNlZW4g
d2l0aCBhIG1vbm9zcGFjZSBmb250KToNCj4+Pj4+Pg0KPj4+Pj4+IGNwdTA6IHZwY2lfd3JpdGUt
PiBkLT5STG9jayAtPiBwZGV2MS0+bG9jayAtPsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgIHJvbV93cml0ZSAtPiBtb2RpZnlfYmFyczogdG1wIChwZGV2MikgLT5sb2Nr
DQo+Pj4+Pj4gY3B1MTrCoMKgwqDCoMKgwqDCoCB2cGNpX3dyaXRlLT4gZC0+UkxvY2sgcGRldjIt
PmxvY2sgLT4gY21kX3dyaXRlIC0+IG1vZGlmeV9iYXJzOiB0bXAgKHBkZXYxKSAtPmxvY2sNCj4+
Pj4+Pg0KPj4+Pj4+IFRoZXJlIGlzIG5vIEFQSSB0byB1cGdyYWRlIHJlYWQgbG9jayB0byB3cml0
ZSBsb2NrIGluIG1vZGlmeV9iYXJzIHdoaWNoIGNvdWxkIGhlbHAsDQo+Pj4+Pj4gc28gaW4gYm90
aCBjYXNlcyB2cGNpX3dyaXRlIHNob3VsZCB0YWtlIHdyaXRlIGxvY2suDQo+Pj4+PiBIbW0sIHll
cywgSSB0aGluayB5b3UncmUgcmlnaHQ6IEl0J3Mgbm90IG1vZGlmeV9iYXJzKCkgaXRzZWxmIHdo
aWNoIG5lZWRzDQo+Pj4+PiB0byBhY3F1aXJlIHRoZSB3cml0ZSBsb2NrLCBidXQgaXRzIChwZXJo
YXBzIGluZGlyZWN0KSBjYWxsZXIuIEVmZmVjdGl2ZWx5DQo+Pj4+PiB2cGNpX3dyaXRlKCkgd291
bGQgbmVlZCB0byB0YWtlIHRoZSB3cml0ZSBsb2NrIGlmIHRoZSByYW5nZSB3cml0dGVuDQo+Pj4+
PiBvdmVybGFwcyB0aGUgQkFScyBvciB0aGUgY29tbWFuZCByZWdpc3Rlci4NCj4+Pj4gSSdtIGNv
bmZ1c2VkLiBJZiB3ZSB1c2UgYSBwZXItZG9tYWluIHJ3bG9jayBhcHByb2FjaCB0aGVyZSB3b3Vs
ZCBiZSBubw0KPj4+PiBuZWVkIHRvIGxvY2sgdG1wIGFnYWluIGluIG1vZGlmeV9iYXJzLCBiZWNh
dXNlIHdlIHNob3VsZCBob2xkIHRoZQ0KPj4+PiByd2xvY2sgaW4gd3JpdGUgbW9kZSwgc28gdGhl
cmUncyBubyBBQkJBPw0KPj4+IHRoaXMgaXMgb25seSBwb3NzaWJsZSB3aXRoIHdoYXQgeW91IHdy
b3RlIGJlbG93Og0KPj4+PiBXZSB3aWxsIGhhdmUgaG93ZXZlciB0byBkcm9wIHRoZSBwZXIgZG9t
YWluIHJlYWQgYW5kIHZwY2kgbG9ja3MgYW5kDQo+Pj4+IHBpY2sgdGhlIHBlci1kb21haW4gbG9j
ayBpbiB3cml0ZSBtb2RlLg0KPj4+IEkgdGhpbmsgdGhpcyBpcyBnb2luZyB0byBiZSB1bnJlbGlh
YmxlLiBXZSBuZWVkIGEgcmVsaWFibGUgd2F5IHRvDQo+Pj4gdXBncmFkZSByZWFkIGxvY2sgdG8g
d3JpdGUgbG9jay4NCj4+PiBUaGVuLCB3ZSBjYW4gZHJvcCBwZGV2LT52cGNpX2xvY2sgYXQgYWxs
LCBiZWNhdXNlIHdlIGFyZSBhbHdheXMNCj4+PiBwcm90ZWN0ZWQgd2l0aCBkLT5yd2xvY2sgYW5k
IHRob3NlIHdobyB3YW50IHRvIGZyZWUgcGRldi0+dnBjaQ0KPj4+IHdpbGwgdXNlIHdyaXRlIGxv
Y2suDQo+Pj4NCj4+PiBTbywgcGVyLWRvbWFpbiByd2xvY2sgd2l0aCB3cml0ZSB1cGdyYWRlIGlt
cGxlbWVudGVkIG1pbnVzIHBkZXYtPnZwY2kNCj4+PiBzaG91bGQgZG8gdGhlIHRyaWNrDQo+PiBM
aW51eCBkb2Vzbid0IGltcGxlbWVudCB3cml0ZSB1cGdyYWRlIGFuZCBpdCBzZWVtcyBmb3IgYSBy
ZWFzb24gWzFdOg0KPj4gIkFsc28sIHlvdSBjYW5ub3Qg4oCcdXBncmFkZeKAnSBhIHJlYWQtbG9j
ayB0byBhIHdyaXRlLWxvY2ssIHNvIGlmIHlvdSBhdCBfYW55XyB0aW1lDQo+PiBuZWVkIHRvIGRv
IGFueSBjaGFuZ2VzIChldmVuIGlmIHlvdSBkb27igJl0IGRvIGl0IGV2ZXJ5IHRpbWUpLCB5b3Ug
aGF2ZSB0byBnZXQNCj4+IHRoZSB3cml0ZS1sb2NrIGF0IHRoZSB2ZXJ5IGJlZ2lubmluZy4iDQo+
Pg0KPj4gU28sIEkgYW0gbm90IHN1cmUgd2UgY2FuIGhhdmUgdGhlIHNhbWUgZm9yIFhlbi4uLg0K
Pj4NCj4+IEF0IHRoZSBtb21lbnQgSSBzZWUgYXQgbGVhc3QgdHdvIHBvc3NpYmxlIHdheXMgdG8g
c29sdmUgdGhlIGlzc3VlOg0KPj4gMS4gTWFrZSB2cGNpX3dyaXRlIHVzZSB3cml0ZSBsb2NrLCB0
aHVzIG1ha2UgYWxsIHdyaXRlIGFjY2Vzc2VzIHN5bmNocm9uaXplZA0KPj4gZm9yIHRoZSBnaXZl
biBkb21haW4sIHJlYWQgYXJlIGZ1bGx5IHBhcmFsbGVsDQo+IDFiLiBNYWtlIHZwY2lfd3JpdGUg
dXNlIHdyaXRlIGxvY2sgZm9yIHdyaXRlcyB0byBjb21tYW5kIHJlZ2lzdGVyIGFuZCBCQVJzDQo+
IG9ubHk7IGtlZXAgdXNpbmcgdGhlIHJlYWQgbG9jayBmb3IgYWxsIG90aGVyIHdyaXRlcy4NCkkg
YW0gbm90IHF1aXRlIHN1cmUgaG93IHRvIGRvIHRoYXQuIERvIHlvdSBtZWFuIHNvbWV0aGluZyBs
aWtlOg0Kdm9pZCB2cGNpX3dyaXRlKHBjaV9zYmRmX3Qgc2JkZiwgdW5zaWduZWQgaW50IHJlZywg
dW5zaWduZWQgaW50IHNpemUsDQogwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHVpbnQz
Ml90IGRhdGEpDQpbc25pcF0NCiDCoMKgwqAgbGlzdF9mb3JfZWFjaF9lbnRyeSAoIHIsICZwZGV2
LT52cGNpLT5oYW5kbGVycywgbm9kZSApDQp7DQpbc25pcF0NCiDCoMKgwqAgaWYgKCByLT5uZWVk
c193cml0ZV9sb2NrKQ0KIMKgwqDCoCDCoMKgwqAgd3JpdGVfbG9jayhkLT52cGNpX2xvY2spDQog
wqDCoMKgIGVsc2UNCiDCoMKgwqAgwqDCoMKgIHJlYWRfbG9jayhkLT52cGNpX2xvY2spDQouLi4u
DQoNCkFuZCBwcm92aWRlIHJ3IGFzIGFuIGFyZ3VtZW50IHRvOg0KDQppbnQgdnBjaV9hZGRfcmVn
aXN0ZXIoc3RydWN0IHZwY2kgKnZwY2ksIHZwY2lfcmVhZF90ICpyZWFkX2hhbmRsZXIsDQogwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHZwY2lfd3JpdGVfdCAqd3Jp
dGVfaGFuZGxlciwgdW5zaWduZWQgaW50IG9mZnNldCwNCiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqAgdW5zaWduZWQgaW50IHNpemUsIHZvaWQgKmRhdGEsIC0tLT4+
PiBib29sIHdyaXRlX3BhdGggPDw8LS0tLS0pDQoNCklzIHRoaXMgd2hhdCB5b3UgbWVhbj8NCg0K
V2l0aCB0aGUgYWJvdmUsIGlmIHdlIGhhdmUgZC0+dnBjaV9sb2NrLCBJIHRoaW5rIHdlIGNhbiBk
cm9wDQpwZGV2LT52cGNpX2xvY2sgYXQgYWxsDQoNClRoYW5rIHlvdSwNCk9sZWtzYW5kcg0KDQpQ
LlMuIEkgZG9uJ3QgdGhpbmsgeW91IG1lYW4gd2UganVzdCBkcm9wIHRoZSByZWFkIGxvY2sgYW5k
IGFjcXVpcmUgd3JpdGUgbG9jaw0KYXMgaXQgbGVhZHMgdG8gdGhlIG1lbnRpb25lZCBiZWZvcmUg
dW5yZWxpYWJpbGl0eS4NCg==


From xen-devel-bounces@lists.xenproject.org Mon Feb 07 16:08:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 16:08:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267206.460924 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH6ZB-0007L9-Iw; Mon, 07 Feb 2022 16:08:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267206.460924; Mon, 07 Feb 2022 16:08:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH6ZB-0007L2-FB; Mon, 07 Feb 2022 16:08:37 +0000
Received: by outflank-mailman (input) for mailman id 267206;
 Mon, 07 Feb 2022 16:08:36 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=hYSm=SW=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nH6ZA-0007Kq-B5
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 16:08:36 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 329b8c22-8830-11ec-8f75-fffcc8bd4f1a;
 Mon, 07 Feb 2022 17:08:34 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 329b8c22-8830-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644250114;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=RDRDAxOv4vlR3Ub5vRqx2g31TMmRHTezg+oAg/H9tXo=;
  b=Ct7ZXAO/ZircH4TGTidMi0hG/J2AqwFzGZnDFIPXbOg4CdtlDUhni9EM
   lR8D41gmYrBl7oWwWQHyNlMH3z558dllQXTsgtx4s8PNaDJ8Q/k47bs5/
   xKgShvSEXOcQ7AJ7bTQpEa8qWY+JdB+9qxSwC7Th6UchcsN0/KcTkZMA6
   4=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: RQgt49YBbZYuTld1IJPQk8VkKRR/Fym01dt7Vv/0n8/pSDICe+cJ106jOHOp2WCB0l5rZCYvDO
 48nja1N0cdzRBKZEqvAMnG+keppcvEvf1f5vUahgUfxWpEjlP4Cc3+YNPsxPbzer0Y3HeBVnfz
 QqbIWLaV9YYkXTwdJCdqLnyKjZzKQIfOeBYxysLDOgp47n0GoaMa00x9dXSz13V4YTcXjKDEe9
 0tewcZjwVcEgnCq2Y0lhd3mhNB5uTHBJ68A0gCO7pDPRrXgapDuJ6O+YVF5I3uSTtT5biSgDYj
 hqpgyalFajlM6B8bOwoJM+m3
X-SBRS: 5.1
X-MesageID: 63659437
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:QMdf4K0W/4TKb/AdAfbD5fN3kn2cJEfYwER7XKvMYLTBsI5bpzRVm
 mIdXTjUM/eCYGT1eoojaNi1pkMGuZDWnNQ1TABkpC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkS5PE3oHJ9RGQ74nRLlbHILOCanAZqTNMEn9700o5w7Fh2OaEvPDia++zk
 YKqyyHgEAfNNw5cagr4PIra9XuDFNyr0N8plgRWicJj5TcypFFMZH4rHomjLmOQf2VhNrXSq
 9Avbl2O1jixEx8FUrtJm1tgG6EAaua60QOm0hK6V0U+6/TrS+NbPqsTbZIhhUlrZzqhr8FK2
 MpPvsKLcAIpF6zgicZDCwlbKnQrVUFG0OevzXmXtMWSywvNcmf2wuUoB0YzVWEa0r8pWycUr
 6VecW1TKEDY7w616OvTpu1EnMMsIdOtJIoCknph0SvYHbAtRpWrr6Diu4QGgWZs3Z8m8fD2S
 +VaSSVkfhf5eTZ1YE8qKYkCv76tiSyqG9FfgA3M/vdmi4TJ9yRp2aXpGMrYfJqNX8o9tm+Cu
 m/DyEHoDRgbOcK3xCKM9zSngeqntSn2Qp4IHbu0sPtjmkSOx3c7AQcTE1C8pJGRmkO4Ht5SN
 UEQ0i4vtrQpslymSMHnWB+1q2LCuQQTM/JKGu0n7EeWy6zb4y6QHG1CRTlEAPQYs8sxSS0vx
 0W+tdrjDjxys5WYUXuYsLyTqFuaHiwYLnQLYyMeeiID78P+u4E4jh/JTdFLHba8i5v+HjSY6
 zKAoTU6hr4TpdUWzKj99lfC6xquu5zIQwgd9gjRGGW/4WtRQ4qoZJeh71TB2spRN4aSTlSHv
 38sltCX6aYFCpTlvDeWXOwHEbWt5vCEGD7Rm1hiG98m7TvFxpK4VdkOunckfh4va5taP2+yC
 KPOhe9PzK9CB2u1b6QpWLu0C+0r4bnCS4z1VcmBO7KifaNNXAOA+ShvY2uZ0GbsjFUgnMkDB
 HuLTSq/JS1EUPo6lVJaU89YiOZ2nX5mmQs/ULiml0zP7FaIWJKCpV7p2nOqZ/tx0q6LqR69H
 z13Z5rTkEU3vAETj0DqHW8vwbIicCJT6XPe8ZU/mgu/zu1OQjBJNhMp6el9E7GJZowM/gsyw
 lmzW1VD1H30jmDdJAOBZxhLMe2zAc8u9CtlbHZ1Zj5EPkTPhq71vc8im2YfJ+F7pISPM9YoJ
 xX6RylwKqsWEWmWk9jsRZL8sJZjZHyWafGmZEKYjMwEV8c4HWTho4a8FiO2rXVmJnfn5KMW/
 uz7viuGEMVrb1o5Vq7+Nqnwp25dSFBAwYqeqWOTeYINEKgtmaA3QxHMYggfeZ1VeU6dl2fFi
 257w34w/IHwnmP8y/GQ7YispIa1CepuWE1cGmjQ97GtMifGuGGkxOd9vCygJ1gxjUv4p/evY
 /t71fb5PKFVlVpGqdMkQb1q0bg/953koLoDllZoG3DCblKKDLJ8IybZgZkT5/MVnrIJ6xGrX
 k+v+8VBPenbMs3SD1NMdhEuaf6O1K9Il2CKv+g1Okjz+AR+4KGDDRdJJxCJhSEEdOl1PYopz
 P0PoskT7wDj2BMmPszf1nJf9niWL2xGWKIi78lIDIjugwst61dDfZ2DVXOmvMDRM41BaxB4L
 CWViazOg6Vn6nDDK3djR2LQ2ed9hIgVvEwYxlE1OFnUyMHOgeU63UMN/G1vHBhV1BhOz8l6J
 nNvax9uPayL8jpl2JpDUmSrF10TDRGV4BWsmV4AlWmfREi0TG3damY6PL/Vrkwe9mtdeBld/
 a2Zlzm5AWq7Ipmp03tgQ1NhptziUcd1p1/Ll82QFsiYG4U3PGj+iai0aGtU8xbqDKvdXqEcS
 TWGKAqoVZDGCA==
IronPort-HdrOrdr: A9a23:oduGBaF6Bl75yxXNpLqE7MeALOsnbusQ8zAXPidKOHtom62j5q
 STdZEgviMc5wx8ZJhNo7+90cq7IU80l6Qa3WB5B97LNmTbUQCTTb1K3M/PxCDhBj271sM179
 YET0GmMqySMbGtt7eZ3DWF
X-IronPort-AV: E=Sophos;i="5.88,350,1635220800"; 
   d="scan'208";a="63659437"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=VNaeeHvGsilSC0Kuc322HwmQa8JiSj47XKtR0NeuVuyiLRRZ41QLaQHYq1f1KX/9gRyNqXYSSpVKwwvY9gm/U1RjIer+YbvGuiQ/S4xJwIxLY9TwbQeHpCNOQtKLlh6AecdgJfS+cRoQUqMAjpPK3ffQCb0H0R1S6wNJnWQtNpCH+p9lKV7ltNfMVdgMQ+E2w6/5CcMLdHpJDVI5JAjpx5dwJfu7FiIWVDCZ7SRgj8eUBKgSYB9Rh6J8z8dzy5IKUPJckeSYfI086JzJvM0gB0t5x/ouG6Rhbb+DvDlaYmr1tdExfGU1dk9jSvxqtwVGwLGspaxCKxlHnGbpLTT5GQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Rx4MvDk5QIewHCsNtq9PZOT1rF/nb3JP8sHO7rhVH+k=;
 b=Yb8sAjhe5Ogv6FlZWKyhVLlSubzLJ+PXOqK6u6jbw8xKFMA8u8fLlNVGtsPKYiBuailgMFnIGXbqx1qdW2F2jDKddcXnuJRUNZ7NLl3TrWrlh02pGUW75SInFLV+7ZsIK1C3rdynOhIhUo1ZsHX0HxTRE1bJdeljtk/0ORg8hTPhAfWmUyG+W0e+/LosfHkXuPEhTitAQJrY0FZkYfXBsHAkaMzFtaYwf1v2/zwkOAWUkivC9L8OiWC/FNXa+T1vVJdt4pOnAgANiDwMULZeLLrP7bg/UZRDplaIygC6NXh4GnpQ7/5bF6TvyDq7FtF/QH5bg7+c3Pyck6JZh4D0Mg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Rx4MvDk5QIewHCsNtq9PZOT1rF/nb3JP8sHO7rhVH+k=;
 b=ojSHxf/Qd0zQXQyEpj25Jkh7zwH7NQ7mtMWGRHdldweHHdksVSFaL2MvEYTumNGLRQ662UCY2qsUHa/dsRapTWi1O3SMu9BbtKUdNHPX97i2sGaqCziqGxRTEWgDnhiGhK7wZIspvAYy5Y32TYwEDIk0zVQjR9f0TsunzuoHu2k=
Date: Mon, 7 Feb 2022 17:08:17 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>,
	"julien@xen.org" <julien@xen.org>, "sstabellini@kernel.org"
	<sstabellini@kernel.org>, Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Artem Mygaiev <Artem_Mygaiev@epam.com>,
	"andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
	"george.dunlap@citrix.com" <george.dunlap@citrix.com>, "paul@xen.org"
	<paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>, Rahul Singh
	<rahul.singh@arm.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Message-ID: <YgFD8TFWwBqAe3U9@Air-de-Roger>
References: <3ad10a99-c706-b95f-1419-2c0c7cf37d58@epam.com>
 <Yf0+3C9nF8+tewLw@Air-de-Roger>
 <c5fea3bb-834b-eeb7-d7a1-1ee609037a9f@epam.com>
 <YgEUwTxhnWVMGMJK@Air-de-Roger>
 <9ce90193-74a0-5642-d22b-6b8c3340c3cf@epam.com>
 <1f65ae7a-898d-2c27-0ada-d71d778b0627@suse.com>
 <YgEsRuckQJIQlkzf@Air-de-Roger>
 <a2a42c1d-d379-00cd-5d55-f443cdb02e97@epam.com>
 <e8fc7872-c7d0-f389-c507-335b809ffcbc@epam.com>
 <21c8125a-2f79-1a4a-494c-db9e4be2a1a6@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <21c8125a-2f79-1a4a-494c-db9e4be2a1a6@suse.com>
X-ClientProxiedBy: LO4P123CA0492.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1ab::11) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 33624a73-541f-47a8-fef3-08d9ea54119a
X-MS-TrafficTypeDiagnostic: CH0PR03MB5969:EE_
X-Microsoft-Antispam-PRVS: <CH0PR03MB5969D3E07680587D03CE4DB78F2C9@CH0PR03MB5969.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: xvdBFoy2RflDGw6V2m0v+O0sJmSh5WGKXO/eRVZEs8K6RneTgGgyH+vROLPCXup5yt3pBloGzWoqU7wWvabYk6jg6A2XNlZURGlBmWhABPLDQe5MWB6kqmROdgZbqDKfdimNyhAw6Yr6a+WdxFVXtM/BVHaQZUmyykAZJCnhyKneilZSWCpwazH/ozX2u9degJ726xu0YYtcwG5tAg9qJHxpVPqnqogwP/D5z40OYDDBdMhVoI/erH6paiwInXvAPBeGOuMmIUM+BHEOepcro2Ly1uCxxsFKmCfNCBVZBZipKV0rbcO6D6vwOBOAJreS8ibPp7VS8SayOofmhTrxWD8O/9W/iR6qnUjoq7FP8Fevb4WCNaQsLZF8ToEbXn3LOLU+dqiJlbPwJZt9H0qJyeScidSoL91uogt7aQn0NUt9kLrawhAkIpupIno8aoDVX2s45s/6CZH1o9IhX4MFEPEKmGRAlGeyyUMB3LAGYEwZuZyJdzdE3ERrLmmPK3tFa/B29lBSqXLJaW4/3HORD+I0qyT6m0368srk51pwRfjIHJxtWjXNfKiJYd47mF9qkka3aAaiHV3YJ0AsyNjAOoeUYbuNi7anyFs6Gmc6Mtbp/tUrhiEyhfT+lMQsgoJmfK0mwO2oOyg+2ad2h2xk+g==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(6506007)(83380400001)(53546011)(54906003)(6512007)(6666004)(316002)(82960400001)(33716001)(4326008)(9686003)(86362001)(85182001)(38100700002)(66946007)(2906002)(66476007)(66556008)(6486002)(508600001)(8936002)(8676002)(26005)(6916009)(7416002)(5660300002)(186003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M3lpL20xUDh0M3VyL2V2U1pTd3NtTGJUbHA0blpRRzNlaEYxc2hUN3kvTjBh?=
 =?utf-8?B?SFNGc08wZ2FGRVNvZ0RON1h6SHpNV3pjcTZ1d3NuRXN2RnB5cVEvTG9vTXh5?=
 =?utf-8?B?aG9VVnJZakROTThoUnpVZ3hHWHp0aHEya3daQjFUWmlYVjJ3L2hDUEg3Mkdn?=
 =?utf-8?B?cjdDU1pyc2JLUlhQR3ZzRnlsUXFKVVRabVNmQWJOSW5OdnZaN1Rtd0x0bndJ?=
 =?utf-8?B?Y0FTcDdLek8wWDc5V2E2OHlVOWdaWTYxTlFYWmd0dkhrM2dSRG9WbmdMSitZ?=
 =?utf-8?B?bURjNC9FZ2FEVW54UzhwNlZWY0ozOUcrQTJmY1FCTFlodytXT0N0dWN1ZEpE?=
 =?utf-8?B?OTlaS2tmQS9nZVZGTW9KSE11b1NKRUd0THBDTEJST2N3T1Y3enBCcWQ3bGZ3?=
 =?utf-8?B?OVp1LzlkeXcvVkpkenFkSmhLc083ZHVUUU5aVkNKb3FoN244eVNvMXNJVTR0?=
 =?utf-8?B?YlNQUlQwNS85aGEwTTJrMHBneENRZnd6VTBvRlA4SUpwRUhxdW0xMVMwdnEy?=
 =?utf-8?B?NDd2L05sajlkOTRLeE5WaW5aV2RyTFlBSExDK3QwTXJGeDBvVktpT1RqaEhj?=
 =?utf-8?B?cFROMzM1YmkwV0lFcGtCSU9xUThPTmZ6RnRtNUh5SnhqcGV6NVh0ZWRQWkRw?=
 =?utf-8?B?NUpYQ1E0RWxKYXJ2eHpNanhERVM1b0pCbmN2QS92VnVBZjVVdGNPWTZlN25t?=
 =?utf-8?B?OHZuNTYyMXh6cUNrZGlobnhONTNTWlRpN0NPNGsyblNxaGNJa0Z2eDlrOTFK?=
 =?utf-8?B?WjR3N0crYWhVdUtycGsxZFNyaUJGTmNiUUxpN3lIVFlTYjVQV2FzRzdteUpa?=
 =?utf-8?B?VGJwOEFLSjFuVzMrQms0MHBrRnpEUy9kSWIrNmhzWDMrRkhBLzhxNlRYd3Fl?=
 =?utf-8?B?RHN6c012VDRvbVJkYU5IK3lRci9ocXZycDVDbHlJK2Vhc0RCUmFtdHBjUkMx?=
 =?utf-8?B?T3ljQjJaeEdYMUdIOStQQjgzN1BjTTJWRURZcGJKeGp4YnEyVlo2aDVtOGVZ?=
 =?utf-8?B?MXQvang2M1hvV3M5MjlRMW1XL1NGM3N5cVhDVmJoUHBrWWVNVitiNFJsNFo0?=
 =?utf-8?B?OUJINks4cTBnVlVFK0J4OVBBRGRFTDk3MlpWYUxMTXo4U244QkZXd0g5Q20r?=
 =?utf-8?B?YWJ4QVFweGlUcXVZb3JjcnBLOEVQMzRNUk91ZXY1NVpjRGJJL25XWWNMOTkz?=
 =?utf-8?B?blhycHErL2FVZzBUVXZSV2JvK0lBRU1ob29kazhvR3Z5K2JOTFFLOEtrdzNt?=
 =?utf-8?B?Z3RIZklRcmM5ODlrVE9zWnRKOWEzdnVKdkdoZjUySWgxN1NZM0NNckpHZ3Qw?=
 =?utf-8?B?WkkwaFQ2K0ZDV1RDMVBmWGVZWDU2RURLUEloeW1GQUUwNTNIZ0J4M05qRlZp?=
 =?utf-8?B?cHFsbUpQQ1RaNWZnZjFJNHkycFJCWmlxUWg4TWNQK240b3ZEZ3BlZFN3U043?=
 =?utf-8?B?NWFCWkh2K3BXRFY1cDM3MWs4dnVkRXlhRDJkV2NVaVgyeHYrSjdoZXFnN0tv?=
 =?utf-8?B?TDhqaUtINjBJRHBIMFlYcjJERzdWZ3NCS09yOE9ZcmhUbXZyZURhTEJ1WmVX?=
 =?utf-8?B?YWZLTGNVSnkyeTNxL2lnRldHUXRPNzJ1eC8vK2NKbFBMTHorQUZSTGZzRW5M?=
 =?utf-8?B?blh5NkdmUmhJUjZEeEJHSDU1WUV5MFBOYjFxUFdZMjVsTWFSZ01XMmRNMG1K?=
 =?utf-8?B?WG9kRmVlNzJsQWRXd1F5ZUMxRnhyZjFNeHRDZzFFRkd2dnVxT1k4M2JPbTdJ?=
 =?utf-8?B?UkhlTXB2RDcxRnJiajY0ZGpoME5jY0w5WWhSM0RrcGpEcHpFanV2UnY2MWFj?=
 =?utf-8?B?cVVkSHU5M2VMWS9mU2FrcFhIdXVRYmp2R3B1RlRlT2tGNHhnVnI2OTRENk1i?=
 =?utf-8?B?MDlRdnI5Tnl6eGdOZ0R3V1ZvQjZPWGdPbXF2TWhxMmhKZUtxM3Jha3VLNUVY?=
 =?utf-8?B?ZTJLOHhjMCs4Rk5KUEU4MktKRlB2aHp0eEF6N05NL2pWdjVPSHFZY3NLWVhW?=
 =?utf-8?B?MlBwVGlZV1VBNTBQdmxObFYrMEZVMFVaTHNZcko2L1p1ejB4TDFiRnRJVHlt?=
 =?utf-8?B?S2JoK3g5aGVNS09CM3VHOFpvUEp3MXB6QkZFaTl4SWxucjQySzVBNFNmeTFJ?=
 =?utf-8?B?RG1yTldNUkZDb0trSmdCMDJBMTdQdVNPbHp2TUZQa3FPMnUrd2ZwdzF2T0Vx?=
 =?utf-8?Q?EiAgSRaac/Y7Nqu9k2GDDpg=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 33624a73-541f-47a8-fef3-08d9ea54119a
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2022 16:08:24.4420
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VnXtRdwXumbOzgziFkkZtCmzTHwXT1+GYpQnYmxCDfv80X4q4SfMjwpwcUbVDX36FGCKdVe4fVXrjFs5gB23LA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR03MB5969
X-OriginatorOrg: citrix.com

On Mon, Feb 07, 2022 at 04:26:56PM +0100, Jan Beulich wrote:
> On 07.02.2022 16:11, Oleksandr Andrushchenko wrote:
> > 
> > 
> > On 07.02.22 16:35, Oleksandr Andrushchenko wrote:
> >>
> >> On 07.02.22 16:27, Roger Pau Monné wrote:
> >>> On Mon, Feb 07, 2022 at 03:11:03PM +0100, Jan Beulich wrote:
> >>>> On 07.02.2022 14:53, Oleksandr Andrushchenko wrote:
> >>>>> On 07.02.22 14:46, Roger Pau Monné wrote:
> >>>>>> I think the per-domain rwlock seems like a good option. I would do
> >>>>>> that as a pre-patch.
> >>>>> It is. But it seems it won't solve the thing we started this adventure for:
> >>>>>
> >>>>> With per-domain read lock and still ABBA in modify_bars (hope the below
> >>>>> is correctly seen with a monospace font):
> >>>>>
> >>>>> cpu0: vpci_write-> d->RLock -> pdev1->lock ->                                                  rom_write -> modify_bars: tmp (pdev2) ->lock
> >>>>> cpu1:        vpci_write-> d->RLock pdev2->lock -> cmd_write -> modify_bars: tmp (pdev1) ->lock
> >>>>>
> >>>>> There is no API to upgrade read lock to write lock in modify_bars which could help,
> >>>>> so in both cases vpci_write should take write lock.
> >>>> Hmm, yes, I think you're right: It's not modify_bars() itself which needs
> >>>> to acquire the write lock, but its (perhaps indirect) caller. Effectively
> >>>> vpci_write() would need to take the write lock if the range written
> >>>> overlaps the BARs or the command register.
> >>> I'm confused. If we use a per-domain rwlock approach there would be no
> >>> need to lock tmp again in modify_bars, because we should hold the
> >>> rwlock in write mode, so there's no ABBA?
> >> this is only possible with what you wrote below:
> >>> We will have however to drop the per domain read and vpci locks and
> >>> pick the per-domain lock in write mode.
> >> I think this is going to be unreliable. We need a reliable way to
> >> upgrade read lock to write lock.
> >> Then, we can drop pdev->vpci_lock at all, because we are always
> >> protected with d->rwlock and those who want to free pdev->vpci
> >> will use write lock.
> >>
> >> So, per-domain rwlock with write upgrade implemented minus pdev->vpci
> >> should do the trick
> > Linux doesn't implement write upgrade and it seems for a reason [1]:
> > "Also, you cannot “upgrade” a read-lock to a write-lock, so if you at _any_ time
> > need to do any changes (even if you don’t do it every time), you have to get
> > the write-lock at the very beginning."
> > 
> > So, I am not sure we can have the same for Xen...
> > 
> > At the moment I see at least two possible ways to solve the issue:
> > 1. Make vpci_write use write lock, thus make all write accesses synchronized
> > for the given domain, read are fully parallel
> 
> 1b. Make vpci_write use write lock for writes to command register and BARs
> only; keep using the read lock for all other writes.

We do not support writing to the BARs with memory decoding enabled
currently for dom0, so we would only need to pick the lock in write
mode for the command register and ROM BAR write handler AFAICT.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Feb 07 16:13:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 16:13:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267218.460935 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH6dq-0000P2-50; Mon, 07 Feb 2022 16:13:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267218.460935; Mon, 07 Feb 2022 16:13:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH6dq-0000Ov-1W; Mon, 07 Feb 2022 16:13:26 +0000
Received: by outflank-mailman (input) for mailman id 267218;
 Mon, 07 Feb 2022 16:13:25 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=owYM=SW=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nH6dp-0000Op-Bc
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 16:13:25 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id dff485cd-8830-11ec-8f75-fffcc8bd4f1a;
 Mon, 07 Feb 2022 17:13:24 +0100 (CET)
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur03lp2054.outbound.protection.outlook.com [104.47.10.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-10-mIIyAKGAO8uzwVfWFU_ZSg-1; Mon, 07 Feb 2022 17:13:22 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM0PR04MB5073.eurprd04.prod.outlook.com (2603:10a6:208:c9::26)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Mon, 7 Feb
 2022 16:13:21 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.018; Mon, 7 Feb 2022
 16:13:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dff485cd-8830-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644250403;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=iplvXesFN17jy4tRCZrgJ9CBYSljiVxdQhy+PPo6CTY=;
	b=YpeaaIEmbUY/ZD+ZovmahIpm4PGBohDQl5ig11CYn3hiWwGV2Z58Le8m4Fy+wWJFWb1sHb
	K0uuEL0FsmQya8ANZDLyPA5MjJdZlmyt4todgZzy+aLvxutdakm78S6E7n3Wiw16UICcDw
	5avft4LGJfSniq1Dbkef6UF9okDcq3g=
X-MC-Unique: mIIyAKGAO8uzwVfWFU_ZSg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=QVsyKuA+VUXyI9PLun+DswdXirA3Nks3GVt9/m7MB7QCI8v/92WOjp1jtnTfYgrT2QGVc2j0J05uz7iN6FHjuwPUsWySLzObgMmMAYNjrq8DM6S7UYPnQpCTctxvu5CPuwRZ1kSHJPfcsytkyXVlqR9Jf7fsAOwc3fal8Ng90rnIeVMvgE1nKNBVQTm195YfkurRuVMK2QvXiZiwSoEsmhz17xyA/4bx5ZqYkqWAn4vHXIkbbXTt7bn+WdMSoW1jjuFRPVNefkHx0mBK/i/qaCjtuPuRKAFxCJRzpKRfJt8UHfJpfMxK0sPNSOvsQf33txEVHrcOzpJxOp+/vmDJTQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=dx9Qo03/kuQYs//ODUf1qfbKkv996AYQIvs+Bf9Wxos=;
 b=jNA2sgELMKQSAl6uLUlmD2W0OjyJyF7pIx+mQK0XiZnUo0MoLKoY3shGBb3/XgLFXOtdX4VEWyRpI0u0HH7rXK9T8kOoEiVtI1cd58xYKk+J394PzPuyvUITQCsBdXM5QJjbHyItEx6ndDcztwGcMEspIZNEwpt8Wc5WZ6AadNd6e3m2jfZQEwV3Q9rK8v7ScG3Ht8tLvCrfNqFzBHgITJ6IzJRV9Zjzmpjnaz3nrj+d0uM1hc0xZ2H8xuH/RDAfvcW+cqfAU2Aqn4ekSk2349Yt2d7D7ypleybD1n0a39SteU4dB39QispWmsomvPcyafTDK1f2PQQILJQqreePbQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <ba35b9f5-158d-909f-5000-e789c8bfffa1@suse.com>
Date: Mon, 7 Feb 2022 17:12:57 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>,
 "julien@xen.org" <julien@xen.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Artem Mygaiev <Artem_Mygaiev@epam.com>,
 "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
 "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
 "paul@xen.org" <paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <3ad10a99-c706-b95f-1419-2c0c7cf37d58@epam.com>
 <Yf0+3C9nF8+tewLw@Air-de-Roger>
 <c5fea3bb-834b-eeb7-d7a1-1ee609037a9f@epam.com>
 <YgEUwTxhnWVMGMJK@Air-de-Roger>
 <9ce90193-74a0-5642-d22b-6b8c3340c3cf@epam.com>
 <1f65ae7a-898d-2c27-0ada-d71d778b0627@suse.com>
 <YgEsRuckQJIQlkzf@Air-de-Roger>
 <a2a42c1d-d379-00cd-5d55-f443cdb02e97@epam.com>
 <e8fc7872-c7d0-f389-c507-335b809ffcbc@epam.com>
 <21c8125a-2f79-1a4a-494c-db9e4be2a1a6@suse.com>
 <YgFD8TFWwBqAe3U9@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YgFD8TFWwBqAe3U9@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM5PR0601CA0049.eurprd06.prod.outlook.com
 (2603:10a6:206::14) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 8ea8f178-c5df-4373-e5e3-08d9ea54c22c
X-MS-TrafficTypeDiagnostic: AM0PR04MB5073:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB5073E8DC4F1335C753A34AD3B32C9@AM0PR04MB5073.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	J7AvGsq0+06OxXaWV2pwaC4aQwD8b7QBzV+4uehfu0jflQFdXmTaEr9P5/sM9a1r78nhyNDp9kk7EeHNmY48mCiEYFxR38y6ZGsFVO5fAaNw2re2vPXjX7b0bVufQGmRkUYxfpAe33ONdTUCgezKyhQzQqrh9z29ZymFPv7aWvefXbzWJvKV7CLZ28WqjhLfCTIiiFAC888349Kahyso41OBfXtd0fspg3e3FL2unV9wsuANE2LQrmMLFVEMI8g12vORy+wMgwmBxPy6rxUpCemT5SJwmvS9T24sibWx3+NvdKVa1y8V9hL6bA8d9LsIfeQxaDewJlEBtvwtYeGK8OHQseURL4Xz9X7VgfBz91m/n0oBRwxwNWydcxMrxZRBX9V1bZU4rZX7KBaxzGUS2+FYfZw36qSZoJrAGB7owG8uUesNsziNLKen19BEd2XJBFzfYhZgl0o7HxXd6snt0hAr0iRBEAr2m8ganQwudMQrT7fnpW2E4YGVt4Q0Skk+mpiT2kjF8ELfcfdrCCtd/zu52GK9Rc1ZrseySYa4g1laQ8nuWLpZP7AYUhtfKiQoW8IPuc2wCTuodoiMqejgKPIdKCMLsGdMUb0PF2ENDft57nAcNOfKriBxFBiH2Jm1N3iLrRNymHwFNTgJcjVX+4UtM+fcqtzTeU6uajt5A9tV2fnRuJ5omNYC8onWd3mYh0R5ATYAhlZNyJwfSLj3eIMoG1Hv8aNygIDwzqMogWA=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(7416002)(6916009)(2616005)(54906003)(5660300002)(6512007)(31686004)(31696002)(36756003)(186003)(26005)(83380400001)(316002)(2906002)(66476007)(66556008)(66946007)(8936002)(8676002)(6486002)(508600001)(53546011)(6506007)(6666004)(86362001)(38100700002)(4326008)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?MwmcdwvEr9eXipxVNufNDwEHhHSdNb3QDh1aUkc8QO5OdSpwGsq88qrcaeqR?=
 =?us-ascii?Q?nloybAHaV/ou8EgZ3WjJdKMpSWLhF33J6S0937SmLNzALUuqbvUN9u7cR5Tj?=
 =?us-ascii?Q?+4YMal1suy2G3fhGquA0bOfK9WkHw/AdXl/1Tjxc1UAea2xM4og7QVVpgQnr?=
 =?us-ascii?Q?QtIHJFo0VWyF/NCcMHs+M+gQLvEflBibyPn8jnw8U1JICyeFOPQojo5nNEEV?=
 =?us-ascii?Q?q9foJoQnPi+mfbrQ6H9Grq94leCm+s4TMYOzLCIkuejqMBw6KbcwNTEqoBYx?=
 =?us-ascii?Q?Et1Nllp/f84IXsKQv2YWkEurdXaW5/TJ4SBpwV3272eSJz1ZatC546osH7uZ?=
 =?us-ascii?Q?b19LU8Pidu76G8WpofvXNcZK8l5ZGGAcHcjkdvOb7Q9T8s3rJeZHUShlsvOK?=
 =?us-ascii?Q?9lScmn45QCs9TtMCyQufhQ3UGe8rketNiaqrZvNA0Z2ZDmnPhIIRDg1ZaBVz?=
 =?us-ascii?Q?TivK+v6G844+Tj6Rkh0QQdYBQaND2iPxDbik0U0AIPksptJQkUT1DPEmSvW1?=
 =?us-ascii?Q?YB8wLMIPxgC6sKk0JiGnjS/b5o+T8okO4/BkVCI8SGt0xBUKolZQSGDYjLvM?=
 =?us-ascii?Q?OTCKmYhLQIEviR0XJBX4lIf8XHv6op8h0x+kjgh8h7rqQS3uvQFA0DmKPDdW?=
 =?us-ascii?Q?0fLIHug46fFyzNybmugHzttn8QRn8aeI4TCqTyg3t2vbSmh1EEdB/LKGZjDT?=
 =?us-ascii?Q?759K1BuCuaeHyaFHV0RazpXSqoQCq3BiwCNW3HSDw6LcXs5ptaDSD11v24nT?=
 =?us-ascii?Q?jgq5v5yDXB4QXcrz4do57MVhoKhcbDfGeQIYiwgxZHu31jnay8wuBtI0DKe3?=
 =?us-ascii?Q?ThrJyb5RapviLH9/qQnFL2bD8m5bNCUvmnSFmxj53snwBwoRCmRIxXVJixp3?=
 =?us-ascii?Q?tNgkher4ZAp82YeFCLcqDC0rK/FCFdZCOieqbmqTseIqucIFs8wayFXgjJE8?=
 =?us-ascii?Q?WAQrZk4GC/w4JsOq6DZLOyIWO9rgvuWD9hBrrPytvaz/VE22NNTOiJLvcbm+?=
 =?us-ascii?Q?m8EdRj2S6Q0+McwEYrTS724yRaAsItIxS5AnsYx0WfTxQZ3VI0Bg7dsVBNf3?=
 =?us-ascii?Q?iSQkfFVy/Ws/3sIP/5HG2mke7rJPkNWuotWocsMdjygA6uqUt7b63vSDBmKs?=
 =?us-ascii?Q?6YtIip+iWrAiTDuav0UqhOyMZ2c1S2jszrLxxW08UTEAyj6/e9Ucixc+URfc?=
 =?us-ascii?Q?fNmaDtAjVBCRhh/NSvwDci5OSbmZLZFAdpcuibQ2+2CbnbK1TliLxbIbj6Zi?=
 =?us-ascii?Q?k/GclpjwajU1LI5/3EHy7kfJKaQ8Y00FiVgbjrYYyMg8iaJcaoP64Q3htA8Y?=
 =?us-ascii?Q?f07cyG0i4KZOGPrtIjlrbfOe9gOK4HcoT4f5TkCJTl9t4PWpUxarHfJ5qUUg?=
 =?us-ascii?Q?gA8gZJ9jwFv1EgCYc0nEzpLH0MJxbK78z8GIRVxKpT9aKwqf1zPElKD1kMne?=
 =?us-ascii?Q?v01/clLJkvMRGU62RIxt5xc6hT1pdsMdDjpoEiQge2Rgn3hCBn5GTN1gjxMQ?=
 =?us-ascii?Q?DCqDgQuYS8Oz/HoCfqz9WT6GVCkmL1lQhx2Azd8d2e+cI4hD25VpuCu8DTuf?=
 =?us-ascii?Q?DzCRrFX2uuHrcbxcdriXNBRHaSNwNhau46/ZVY5sqCQkL/vuwx1s/I0z4rKP?=
 =?us-ascii?Q?UzeIMkNjBSnT/IaqlEA3cZY=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8ea8f178-c5df-4373-e5e3-08d9ea54c22c
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2022 16:13:20.7385
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 39Pxzedij0RDyhs9idLOPVks4qq8pVIV9OlZ5FSF/mudVzkpheO00TJU43kW5fDR1Yu5Zn//LlaRkDiL0eRmpw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5073

On 07.02.2022 17:08, Roger Pau Monn=C3=A9 wrote:
> On Mon, Feb 07, 2022 at 04:26:56PM +0100, Jan Beulich wrote:
>> On 07.02.2022 16:11, Oleksandr Andrushchenko wrote:
>>>
>>>
>>> On 07.02.22 16:35, Oleksandr Andrushchenko wrote:
>>>>
>>>> On 07.02.22 16:27, Roger Pau Monn=C3=A9 wrote:
>>>>> On Mon, Feb 07, 2022 at 03:11:03PM +0100, Jan Beulich wrote:
>>>>>> On 07.02.2022 14:53, Oleksandr Andrushchenko wrote:
>>>>>>> On 07.02.22 14:46, Roger Pau Monn=C3=A9 wrote:
>>>>>>>> I think the per-domain rwlock seems like a good option. I would do
>>>>>>>> that as a pre-patch.
>>>>>>> It is. But it seems it won't solve the thing we started this advent=
ure for:
>>>>>>>
>>>>>>> With per-domain read lock and still ABBA in modify_bars (hope the b=
elow
>>>>>>> is correctly seen with a monospace font):
>>>>>>>
>>>>>>> cpu0: vpci_write-> d->RLock -> pdev1->lock ->=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 rom_write -> modify_bars: =
tmp (pdev2) ->lock
>>>>>>> cpu1:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 vpci_write-> d->RLo=
ck pdev2->lock -> cmd_write -> modify_bars: tmp (pdev1) ->lock
>>>>>>>
>>>>>>> There is no API to upgrade read lock to write lock in modify_bars w=
hich could help,
>>>>>>> so in both cases vpci_write should take write lock.
>>>>>> Hmm, yes, I think you're right: It's not modify_bars() itself which =
needs
>>>>>> to acquire the write lock, but its (perhaps indirect) caller. Effect=
ively
>>>>>> vpci_write() would need to take the write lock if the range written
>>>>>> overlaps the BARs or the command register.
>>>>> I'm confused. If we use a per-domain rwlock approach there would be n=
o
>>>>> need to lock tmp again in modify_bars, because we should hold the
>>>>> rwlock in write mode, so there's no ABBA?
>>>> this is only possible with what you wrote below:
>>>>> We will have however to drop the per domain read and vpci locks and
>>>>> pick the per-domain lock in write mode.
>>>> I think this is going to be unreliable. We need a reliable way to
>>>> upgrade read lock to write lock.
>>>> Then, we can drop pdev->vpci_lock at all, because we are always
>>>> protected with d->rwlock and those who want to free pdev->vpci
>>>> will use write lock.
>>>>
>>>> So, per-domain rwlock with write upgrade implemented minus pdev->vpci
>>>> should do the trick
>>> Linux doesn't implement write upgrade and it seems for a reason [1]:
>>> "Also, you cannot =E2=80=9Cupgrade=E2=80=9D a read-lock to a write-lock=
, so if you at _any_ time
>>> need to do any changes (even if you don=E2=80=99t do it every time), yo=
u have to get
>>> the write-lock at the very beginning."
>>>
>>> So, I am not sure we can have the same for Xen...
>>>
>>> At the moment I see at least two possible ways to solve the issue:
>>> 1. Make vpci_write use write lock, thus make all write accesses synchro=
nized
>>> for the given domain, read are fully parallel
>>
>> 1b. Make vpci_write use write lock for writes to command register and BA=
Rs
>> only; keep using the read lock for all other writes.
>=20
> We do not support writing to the BARs with memory decoding enabled
> currently for dom0, so we would only need to pick the lock in write
> mode for the command register and ROM BAR write handler AFAICT.

Oh, right - this then makes for even less contention due to needing to
acquire the lock in write mode.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 07 16:15:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 16:15:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267226.460945 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH6gB-00010J-Hd; Mon, 07 Feb 2022 16:15:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267226.460945; Mon, 07 Feb 2022 16:15:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH6gB-00010C-Ec; Mon, 07 Feb 2022 16:15:51 +0000
Received: by outflank-mailman (input) for mailman id 267226;
 Mon, 07 Feb 2022 16:15:50 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=owYM=SW=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nH6gA-000105-AV
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 16:15:50 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 364a4905-8831-11ec-8eb8-a37418f5ba1a;
 Mon, 07 Feb 2022 17:15:49 +0100 (CET)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2054.outbound.protection.outlook.com [104.47.13.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-2-wymMWLWgP5-pLSO631y9qA-1; Mon, 07 Feb 2022 17:15:47 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM0PR04MB4850.eurprd04.prod.outlook.com (2603:10a6:208:c7::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Mon, 7 Feb
 2022 16:15:45 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.018; Mon, 7 Feb 2022
 16:15:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 364a4905-8831-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644250548;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=e5mk183SW42wH3C3Nr2RfwR6aiDk3tIcNQYfMe3Il+c=;
	b=neO6LZw6YdLYtOJ+Jt596DglXcT6I2sSJ/R0NSGxj9c0PukMxzC15xnLbNMvs0hQnbOBN0
	RKt4U7rYffF/1c1UT9+nFar9dNvpdGm7IRJcuP+nWW7SPg5Cej3409yxLl4R3ONjI+YkhO
	w0pyqRxc8zgFXVbwxolJOn3+swSIAj0=
X-MC-Unique: wymMWLWgP5-pLSO631y9qA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=J16YcKCdNiINNCdSL+LT7JAkk3OkFa+Ni1jdLlu6JemRgzwtBWG13GijqKynMJQvQkmHxlFWgOy2k6LcmGd1XJeIRx79TptL3s98Gb2z0jrM9cyX9MyI8akKdwM2SXhD/pmy97W2QlRyjtpRfEhbYb7VkFWcoRranwq4IozPzwvf8say1Kg/8jgALN22psXcbI/YEp3XrWU6XbF3R06a62ACJo7MNxb3oYIa1lqEHjzVamX3MuTBvZ1/IzIvn04cQ9nbjStoM3kxhS6nSEyoOrm37H/EgCoNALZeVbDv5a3oW8tKYLvLCEhVHmNu6YlZ4pmOuaXWBB5KLdLYpSfi1Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=nSVMMSC7IHwKzp7nhCdWYqKZz9yr8xZqfHy5Kf+TDng=;
 b=L3eocde0XPGiwjxFVVO+a7RJi/uA2IWgoOTRVUS5QpASjNGg4Ji2hoVtrhvmG4n36661I1aeVRWNVKaM/ZGpSFTmGhMCm2vhZsJjbXZoYknr8t5gIBFPOiHVlyat92E1wR7aFyafvx4cuvQaE/nf3kj+cK8je2rAoYcQFuD2pUKf3Ncy4zGl2IL5tfgsYEdVXsauIC/08mjmZS49G36kdNR37bJ54Yy43NoTZkEDeORIUVjhpbX0s167iixYDs7/n7ITloLFI9zG9w8LCSX7kkgwjRId0MK+7QNvGpLTgmASAXGBAB6FanF6iuAJVCRFsY3G/mk8UQEgEDdlQnLvAA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <ad985f4a-10f0-4a2d-df02-cde915fea3f1@suse.com>
Date: Mon, 7 Feb 2022 17:15:43 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Content-Language: en-US
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: "julien@xen.org" <julien@xen.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Artem Mygaiev <Artem_Mygaiev@epam.com>,
 "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
 "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
 "paul@xen.org" <paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <7e3562b5-fc67-f213-e872-f211450d9e2e@epam.com>
 <a8fc599c-f620-c4d1-2077-c57068f46a7f@suse.com>
 <deef8468-d607-e49e-f456-6a8013329ca1@epam.com>
 <Yf0k6aoKK5G3iad1@Air-de-Roger>
 <3ad10a99-c706-b95f-1419-2c0c7cf37d58@epam.com>
 <Yf0+3C9nF8+tewLw@Air-de-Roger>
 <c5fea3bb-834b-eeb7-d7a1-1ee609037a9f@epam.com>
 <YgEUwTxhnWVMGMJK@Air-de-Roger>
 <9ce90193-74a0-5642-d22b-6b8c3340c3cf@epam.com>
 <1f65ae7a-898d-2c27-0ada-d71d778b0627@suse.com>
 <YgEsRuckQJIQlkzf@Air-de-Roger>
 <a2a42c1d-d379-00cd-5d55-f443cdb02e97@epam.com>
 <e8fc7872-c7d0-f389-c507-335b809ffcbc@epam.com>
 <21c8125a-2f79-1a4a-494c-db9e4be2a1a6@suse.com>
 <4276fe72-558b-7d95-6430-d4330989dbe8@epam.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <4276fe72-558b-7d95-6430-d4330989dbe8@epam.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM5PR1001CA0067.EURPRD10.PROD.OUTLOOK.COM
 (2603:10a6:206:15::44) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 66ce40ce-d060-430e-0007-08d9ea551894
X-MS-TrafficTypeDiagnostic: AM0PR04MB4850:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB485056B739BABFB6811C8DB9B32C9@AM0PR04MB4850.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	y8Maa/N8Xuq74zbgjnGAmgQWGO9IZdr0QeLNWaBlUdzRALOT8or0kCikjyIlhXT5woIC5PlEgLpQi/IaNfOCzVu1Lg76tY5lYZkfGglbvzdMPkHAQzqesNQ0Oh02FUOFVbO2QoxYb9dzfea73d5n4zvvf4tlmV2+UvQz7buDByiwtqe9ZoTrx2LgK4EdSnEUoIhqniZASJHLWuLuwjwA9iKmFtUrG8FIFa2pzFbTtR2sFNAGDLvwsNn/DCw5CBw6glrE/enBoMMcid7slBeFkJwKmsrOnNTsK1yshMGcJPxV4uSTuInMrUa8hkL+g4p8Seb/orkRLgh5lU8BIbu6v/rrCOQCUSgM6hn8e8JBvEn0BB8SmZ+lpf1GNMBuduTwt5MChdcIfCdkyaLAyzLHfoGWZV9UpuFxgQAkBEb+cNA3JUbp8oAy7jWma9KxS4StbpuSskaoub28dX1o3R5kfK9TX6rnC11+kav07nPMTgl7xcTUdZ+JGygAfS+YRkfrDHfPTeqF/9ZkFc7mfQgJPpCHGsHFhhbq3TBCegl7AVJVSO9+MzpbdX5ehhyZgoKoTtgXlEH/nKvOHbY4Uwjg5YV79TWxuHQR2oFUFy9RmkMMEfeucu3Vfz9LoBWny6Qyp8tk4ZcO+q9ENGwdQQ20DeWfLr/FYV2SX41cAEKG10l/4dsuZj6ta8SH7Zt1OiyGof5HGtyNaCblhdq3GYbyEimmjQDk20F5eGwnu+Snino=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8676002)(36756003)(83380400001)(6512007)(6506007)(53546011)(31686004)(8936002)(66946007)(26005)(2616005)(66476007)(186003)(66556008)(508600001)(54906003)(2906002)(38100700002)(316002)(6486002)(6916009)(31696002)(5660300002)(4744005)(7416002)(86362001)(4326008)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?+780CN9V3gSs+h7FvlRZu6GZD+tYdsqNvOKHf8b/f+MooY0AzT4RzBCRIDnv?=
 =?us-ascii?Q?8nVAbRyIKST46njNCeyB28M7GLSZ9cXD4YpUm8sXMkSUMLIOpXN/O27SRVim?=
 =?us-ascii?Q?M3bq1/legzomZ+9rYh8rxL7w4W//7EEub+FWsG/AbBK0yo2hoy/n3j4cyEcK?=
 =?us-ascii?Q?Tft4ktsaTBC2UKkOZLFFFvdcuJolGecxc8c7ce1vAbZ0jlTaXkeJg1B/Rz8D?=
 =?us-ascii?Q?Db8IfgbcI8/1Fn7kn3qMsMivaHY0rnSSMvGHlEj+bs7/hBQDlfjQwm+2xwXP?=
 =?us-ascii?Q?I57QkmQgnsaRwH4mYjdXJa4iTBgTD3Ce6R1BObIs2xLnt38jVEITBuJSmZ82?=
 =?us-ascii?Q?Jl7i0JNwCG8CG1zqX/p1eU4NHSYjZgLLg+V2TcaN1x29/6GoWj0XS6AgSD+g?=
 =?us-ascii?Q?QfyA5d3jQC+N9pK07U99z8GDCVAZYyCsnzAcv1Yx+SoxNyoFHBxRKb4LNbFe?=
 =?us-ascii?Q?UHabW+l9M/yu4P/8km9Ioaf4B6pK8loXz70xlBf2h8Kwvp30fk6TkY73vBTs?=
 =?us-ascii?Q?beDkQAUjD+ZtY+77/CAV8oxYS3plFC34OCukMfq+CALR5h1mOUX/25LOgsHA?=
 =?us-ascii?Q?rT+xmojU/z9ZqOzSDAov+/CMA3yDDaMhl9f4lee6QB7iumltKRXRujXVWk+c?=
 =?us-ascii?Q?tctoLmzXsGLCz/obmBfUrm4fhrsGdJDTou92unZgGBMmoToCm9C+M+eX/nJ8?=
 =?us-ascii?Q?fQcBdUHg58etIORvFOJFeHxZ2Jzm4oqWdcg0C2A2eThwjOvAq8Ip+r0XDczn?=
 =?us-ascii?Q?5A8LW8DF8ftoeeMU3YFOeURkpFUm5FtCWoodDR6gqwbDqN9Iw2hQ5W1JaO/t?=
 =?us-ascii?Q?a6kDephp+jJ3xsAYdXx9dwkQ3wcAnSpJ0+jMrEanJF+4p+jnUnFXYB6yaoea?=
 =?us-ascii?Q?xdVK2Iuk+SjR2jpJ/FUUbHoZoXGx0BtfEunKz72WRbWoJbf/LkyznMiXDAnP?=
 =?us-ascii?Q?ORTuI/c5zYDDHZW/Y+4q6VbSEtcKieszmR+d10rIdP4qAOp6SKGDY59GG6so?=
 =?us-ascii?Q?RCJ1z5KT9ifKJZJQz/sKAXmKDvqDg211WV1wKpdx4fLHqOPgZtC1LJZDRm7P?=
 =?us-ascii?Q?8BCARNm6SfEjj9X1Th2JT8ybyfYVKApU/b1K7hLmNpRF93nPFqaheJO/g5OP?=
 =?us-ascii?Q?EnWP0PXaE/bUAASl4YteqmpoX/BnrOkJeCdJJK73dNnjXv0iAsdxsUX5ch04?=
 =?us-ascii?Q?UIL8fjH669BLQjk3Z32e8lZfdHK9ttQ1HQWFKZQdkugXCjqaNFFrhkeDlrVg?=
 =?us-ascii?Q?xPx3uxgfSagBc1X4uIoYbolvcZKO3ixSSP/oOHMT1MIQV3o+XeAzZphqZ1js?=
 =?us-ascii?Q?Weeb0lqO31XFxDiZF9yDy37xMWV+r+R9nvP2pFFzDrvvERUCItIHQ5vLUWs0?=
 =?us-ascii?Q?DaLrpFj3VE0WrY7MsUoA0Wl5W7oPaG5N/C+nzpmQILa+VxmKahaYwR7/odOt?=
 =?us-ascii?Q?f3nrIpYv1D0DV+98CEikjbp2hMIrRmjDsXV3de9uKgXTfKEfuEJKYhA2H1sn?=
 =?us-ascii?Q?KJ/n5NAvIsdySnqDT1sX8gNVoumfolj547eR6e8tOnx2yIF/CLolW3/0XmT5?=
 =?us-ascii?Q?H2FkYA4EZ8vgd3pFmBUKnNtizFZyA5YzPhIYJQ1xJJxxw9YpZvMT8BqOQtlO?=
 =?us-ascii?Q?70a7FNzQ6lOjcufkOS5zyiA=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 66ce40ce-d060-430e-0007-08d9ea551894
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2022 16:15:45.6514
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GNH490iO4ftR8Fng+uCuw/vD4JD0I4vy1/yAPVyXQTqQhB/r4zz7XGPUUz7hRqOKOQjrPIklIZDf7GBlhvT6nw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4850

On 07.02.2022 17:07, Oleksandr Andrushchenko wrote:
> On 07.02.22 17:26, Jan Beulich wrote:
>> 1b. Make vpci_write use write lock for writes to command register and BA=
Rs
>> only; keep using the read lock for all other writes.
> I am not quite sure how to do that. Do you mean something like:
> void vpci_write(pci_sbdf_t sbdf, unsigned int reg, unsigned int size,
>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0 uint32_t data)
> [snip]
>  =C2=A0=C2=A0=C2=A0 list_for_each_entry ( r, &pdev->vpci->handlers, node =
)
> {
> [snip]
>  =C2=A0=C2=A0=C2=A0 if ( r->needs_write_lock)
>  =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 write_lock(d->vpci_lock)
>  =C2=A0=C2=A0=C2=A0 else
>  =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 read_lock(d->vpci_lock)
> ....
>=20
> And provide rw as an argument to:
>=20
> int vpci_add_register(struct vpci *vpci, vpci_read_t *read_handler,
>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 vpci_write_t *write_=
handler, unsigned int offset,
>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 unsigned int size, v=
oid *data, --->>> bool write_path <<<-----)
>=20
> Is this what you mean?

This sounds overly complicated. You can derive locally in vpci_write(),
from just its "reg" and "size" parameters, whether the lock needs taking
in write mode.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 07 16:22:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 16:22:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267238.460957 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH6mS-0002Ux-By; Mon, 07 Feb 2022 16:22:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267238.460957; Mon, 07 Feb 2022 16:22:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH6mS-0002Uq-8v; Mon, 07 Feb 2022 16:22:20 +0000
Received: by outflank-mailman (input) for mailman id 267238;
 Mon, 07 Feb 2022 16:22:19 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=F54n=SW=epam.com=prvs=403792ff6c=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nH6mR-0002Uk-6L
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 16:22:19 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1d528b75-8832-11ec-8eb8-a37418f5ba1a;
 Mon, 07 Feb 2022 17:22:17 +0100 (CET)
Received: from pps.filterd (m0174679.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 217EEgv2023710;
 Mon, 7 Feb 2022 16:22:13 GMT
Received: from eur03-ve1-obe.outbound.protection.outlook.com
 (mail-ve1eur03lp2057.outbound.protection.outlook.com [104.47.9.57])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e350urkm4-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Mon, 07 Feb 2022 16:22:13 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM0PR03MB6082.eurprd03.prod.outlook.com (2603:10a6:208:155::33)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Mon, 7 Feb
 2022 16:21:23 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77%3]) with mapi id 15.20.4951.018; Mon, 7 Feb 2022
 16:21:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1d528b75-8832-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Ap4HJzKyz5iHdd7mMcrUwvojqkC9/eHLGUvQtyk0X+6deh9uWmm9N0gLb6chW3w7lxSY+GUwjIObma0j4yEvPHNS07d9jtbDjrbJ+3u00yr0xS1MIf7g4RpwukH2c2jY2VB4f/91e63zK1MRQainjV5AwQuOv5BmFOq/SK2LO1YALJAaaoOGkzHUqv6daVSHj+qOs8J7Yll0Lvtb5+7CewRrp6BgdIpYbqQbKTq5LPagXjU4nlBF742m68bCE5zYRv/rHgzB1nNYEm1hEmGBDb+4Vw2fzeAc8t9HfAPiYHyefgK1CQwmCbVPwkQOxEApHQFxLple0rKvN2gPBAPdmQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Eq+7EehcGxEh9vh0mJqI1Rybd16iu+rAMKtz8Cqgw50=;
 b=K89mmmX6D311Z87mrxgiDumL65MCTZY1u+HlCkcUpuEviSBGOSjxz2f/6coyNVO61cUFLZLoMV7Kh/lq6XDagG9jlTsYmLkZKCUOD7jVHfVcn7aSQvt3HHDSjlgz8y1fiovZhx/lLQ5nWMygKItK5IzvsRJAeMWfehVrHV3YTHBS0GZHVyy1STCP6tSG8H4GUiGBTTkFTr5fyQ4RBwA8WNF6uOXNFpQ6Yt99tWKlPDUqdJr2pfolY/0CHpDBMSmKclveIYtKqvc40+PqZk61ZcgQEn2Ar0s5DxCldLIS3Vsn+HgoupAf89VFiR4MYMUVO2kOaVUcwJDTyXBS04rpQw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Eq+7EehcGxEh9vh0mJqI1Rybd16iu+rAMKtz8Cqgw50=;
 b=BLSA3E1jk58hotGL81AI+yzJOllnspRDTiaPcp8lSrXMU/d/vAuV2avWYKyxfTxhNOnhlqxnkbPfTIoqWBeLISYHfBstCB4rfuZNOKnrXNTWGoc5ad96T2JNDi/BcAznoufa1bEn3hoFVFAdwrmYHdKa1sLLOW+pqWNN7xjQEk+MF/JXuCTJAYLQjHzxcLdRzyiOY0ljaivT1ZQ4X//+9062rHfc4/NuWFSPltYL6JWATZzfe6/jAkgFhE+NkpOWyfV+uK/DOGWgAp750d+aJPejo0WIgoE7nIITl6QkDIURw755Vz+nezec5ujuTXtP84efVqJgvnUPS/Nvw5nleg==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>,
        =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?=
	<roger.pau@citrix.com>
CC: "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Thread-Topic: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Thread-Index: 
 AQHYGZFc/MnzQOjwVEeBBUHLSW0md6yDBUkAgAASSACAAATYAIAAD/WAgAAKNgCAAAbfgIAABnuAgAAQvgCAAAMCAIAAAY4AgAADxICAABrnAIAABAgAgAR3CoCAABt5gIAAEpuAgAAE5ICAAASKAIAAAiiAgAAKNYCAAARNAIAAC1wAgAACRYCAAAGVgA==
Date: Mon, 7 Feb 2022 16:21:23 +0000
Message-ID: <f7669670-8eeb-9966-5ba3-e8f9c03ce3d3@epam.com>
References: <7e3562b5-fc67-f213-e872-f211450d9e2e@epam.com>
 <a8fc599c-f620-c4d1-2077-c57068f46a7f@suse.com>
 <deef8468-d607-e49e-f456-6a8013329ca1@epam.com>
 <Yf0k6aoKK5G3iad1@Air-de-Roger>
 <3ad10a99-c706-b95f-1419-2c0c7cf37d58@epam.com>
 <Yf0+3C9nF8+tewLw@Air-de-Roger>
 <c5fea3bb-834b-eeb7-d7a1-1ee609037a9f@epam.com>
 <YgEUwTxhnWVMGMJK@Air-de-Roger>
 <9ce90193-74a0-5642-d22b-6b8c3340c3cf@epam.com>
 <1f65ae7a-898d-2c27-0ada-d71d778b0627@suse.com>
 <YgEsRuckQJIQlkzf@Air-de-Roger>
 <a2a42c1d-d379-00cd-5d55-f443cdb02e97@epam.com>
 <e8fc7872-c7d0-f389-c507-335b809ffcbc@epam.com>
 <21c8125a-2f79-1a4a-494c-db9e4be2a1a6@suse.com>
 <4276fe72-558b-7d95-6430-d4330989dbe8@epam.com>
 <ad985f4a-10f0-4a2d-df02-cde915fea3f1@suse.com>
In-Reply-To: <ad985f4a-10f0-4a2d-df02-cde915fea3f1@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 03fac357-e402-45ed-e467-08d9ea55e24a
x-ms-traffictypediagnostic: AM0PR03MB6082:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM0PR03MB6082128110C0D3512F361604E72C9@AM0PR03MB6082.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 maoRQI+8U242d38gBI8ZUvLpl2acEuPFvSXg6fzbv+AeiVCR9R5zxSmY4jj4lnahTOQOvd4Ix+DdYR+6ZT1cRP/etSgvModMxdna43U/NFOBR7DSHWqEBgqNp+WM49ZkuhuDmUGJj03cL69+2d5uRcb08Gpt0CZ8+MgqAg0W5KrYuUQILVC7wvt9C7S/IcJivCFae50mgbDDFmhTGEuCAEue+JmOihrOJrUa6MCETCxseJCTsHK/p7ZY9eQS+SrnxABWIqjJ3QPr7IDf9Znk0MfmgeT+OcKR9yKyS7wVQmj7fzPo+icDGDFb4EeLtB5KwEJvmcloQ6M6HBFX9f+cUS/lvv5HiXIWmHr6Ke4wgGY/Gna1Vt0MSfBgI9RRe7btZnphU89BbH5Pv9d+GkTOnJOXkMniQj6v3GDBC7EAccGFFnNzjBw/DnTs9r/xQw+qhwD6I9F3/JGMa2lLeZLxQlDviWH/HVGndNrgBaNIv5v++0+liVrYc7LPdBhPkAyTjXgGj74qr0xYzA/Q5Qsk59Vqw0DO2Hefag2m/ioxUtij1pyABwxxiw17CYEH4jeQD3m3RtSnP6iGc7xnF64Ed0V7BUMFEuRsvkp89K8ZIVbxdAJSNpD+d/wiG1s74awhnwv4a7DIGvykSCPho9p19SShsGDMDo7VDdpQ4GGGbhhRhq+td2KE16T03MW7/NdT/9QDOFDOK7Ntvh3i2JuSW1mGaEd/rdE3lsk4Y25bcK7KN4PrTfJvMLu7WoAL35Ks
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(8676002)(64756008)(83380400001)(53546011)(36756003)(6512007)(55236004)(31686004)(8936002)(76116006)(91956017)(66946007)(26005)(6506007)(107886003)(508600001)(71200400001)(66446008)(186003)(66476007)(66556008)(38100700002)(4326008)(54906003)(7416002)(2906002)(2616005)(316002)(6486002)(31696002)(5660300002)(38070700005)(110136005)(122000001)(86362001)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?ekhCeU1CbXgxVndlTXp6ZUdZU0V2bzBCRkxRTTRpbUEyN0tRSUtHa0laK01u?=
 =?utf-8?B?ZXNFenBDajVLZWUwSHl2TG1SeUpOcmU3RFdEd0NjRnV5Y0dkRmR6eks0WkJF?=
 =?utf-8?B?ZGFXSVdsbWFMbmM2VWFSUVI4clJWK0ptT2NuMXVaRGswOExqQ2RlZmF2V0FD?=
 =?utf-8?B?U2Qya3llUzB3bm5EUkg1cTJqLzF5ZTBvYms0RU41KzdKUmNMRGt1TmkwZGdh?=
 =?utf-8?B?UTY3Z014MW1LcXVaYnhGaXJnWmxLdFQ3b28vME5WRjFhZWtSL3pFVlNkMGIx?=
 =?utf-8?B?bFBSZUk4bGVreXdRdEFiSEY0NXYrbE5ET2h4c0pBSEwxbkhPQmdhMGdUTWt3?=
 =?utf-8?B?QThvVFBveE9VcXhGU29Lc1BTeDBwVm9qTWtOYU9Ya1pTRUZoYVJCU05EOEFK?=
 =?utf-8?B?aTNoZllISnZ6bmp2clhEa0IralVobzFiUEI5cXphbUx3OGJLWktCMFFCazM3?=
 =?utf-8?B?YzhBVlJnZGQwdFgxT0NDR3JVQm9kalZxMXdIUE10RmtGQU16NWV5dXFRVmln?=
 =?utf-8?B?TERFQTRZeHFQOTFsell2bWNNTU0vc1h2MTJnZVRad3ZlSGJrVkJ3dm0rUDg3?=
 =?utf-8?B?NVhFNHY5dytNR3RXT2ZScHVXZkU5d203WnlxSnVFLzlydEtTOUEvVk9wNGFQ?=
 =?utf-8?B?UTNjMlV5QVBBS1gxQjNIcFdHMEV1cVNZWnZkS0orb0lYSUVsK0d1VDl5Z3lM?=
 =?utf-8?B?OHJ0b2U3SWpyL2pRcUh3eldjUjh1SUx4YS9aZUJnQmRLcTRmK1dIUTlqNVIy?=
 =?utf-8?B?OVRiYy93TnFwUFN1bnR2NC94MEVxVU5FOEJ5YXRySXk0YXZOREwzVmg4TnFF?=
 =?utf-8?B?TVpGeXVVSlhjZ3NjNDIvK1JFbDJCVmRKY1ZmWHRNOVlsRG1rOVI5WVd2Qmlw?=
 =?utf-8?B?OEdvbGpoWnM1VlYyME5HcDJoVi81QlR4OU9ROEtDS2NzcUczdllQdlZUYk81?=
 =?utf-8?B?aUFhc2tyOGhxNUpQNUVsSEJqMkpqaWJhcXh4N296RHArM3ZkL3d4SURCWjNk?=
 =?utf-8?B?d1RiVWhPbkRLOXlOdUh2R01UYUFvL2I2OGw1SlBkdHdtci9yUnR6U2lnVG44?=
 =?utf-8?B?SVF6ZVdBZStiWkUzZFZvYUpVVEpDb3B5V1pIN1lkYWZTVmtmY1V3Q3JuT29M?=
 =?utf-8?B?dWhkbzRSVWdNQ0swTE5BbEZpN3dycHIrcjQyeWFoeU9qZUxjd0h1aW1hN21w?=
 =?utf-8?B?NG9IOUNLWlkxZnQ2VFg1cElrbldpYys5blF3M0ZVOS8rRmdJeStlNUZpYjA0?=
 =?utf-8?B?NFR4VUFObTM4OUJPL3JuVzdrMTZ1MlBHSHc4NnBsWTBBY1BINzRtTTlLMGVW?=
 =?utf-8?B?OC8xWFdKcjFVazBuOUJMOEFVZTgyQytPdUR3RzJVUDc1ZXZ4bUJ2OVJSa1Vw?=
 =?utf-8?B?UGMzRTZBaGZ1aU5jZG1qck41V3VUVkxBRE5TamFoRWFrSGhBWDEzUmloYmNr?=
 =?utf-8?B?ZzR2V1BFL3gzZUd1eWxZRGd1Z0ZZbXNoVmk1S0o4R0xHQ1lEeHlnbDUxc0NW?=
 =?utf-8?B?alM3RWFoT0RBWU9QZkpzeUM3NDR4dXcrK0w1NTcrdVg5V0RPT2ZzZmVmREZr?=
 =?utf-8?B?cmtnMy9JVWVJdGNJa3oySlM4VkNWdU1UajJvYjZpdjc0QzB6d2ZhdUNIRVdz?=
 =?utf-8?B?UG5hcllybjB4cTg2dVdLOVR2T2JhalpySFlFbkQ1ejZFc2FTQXlpS2ZmWjU4?=
 =?utf-8?B?Y3YrYVNTS2lVK1hlby9SL296NXQwWDZVVVFNaEpHL3lxcWZlYS94bFhQTXdu?=
 =?utf-8?B?ayttN01LcVMrOHBJQklzdDkxZ0hRdElJaWF5YzI5RkFneTBNQ0ZMbGhsdmRS?=
 =?utf-8?B?d1lSNWVwSzZIUWpNZ2phbFFMdGczTTJwWmUzUnAxMjZ6MzhKazhjVFBtOGdz?=
 =?utf-8?B?aUU5QWMxVGx2YTMxMjQwVlZpVWsvdThNbDd2RVZaZjljVmQ2UkhSUkgvMU5u?=
 =?utf-8?B?cWRxZ2pwQ2wvazhELzlRNVIvQVluRzFjejVibEJ3VGNKR1pJYUV4OXJ5eXl2?=
 =?utf-8?B?bGpha2QxckNQeGhRTDQ5bEN5cXlLdkxydTZVUFp6TTAxTXI4bjBjaVBLQS9Q?=
 =?utf-8?B?RlMzRlkwT2IwU2tMTXRtUVNsVFhFd2xlK1hoVDNzejRNTjBMbXk1UXptM2hC?=
 =?utf-8?B?NWI4QTFaOGcyTjVMREhkb3hCb1FHTno4QVc0V0RSelYzam5WRmVQaUF5a2ph?=
 =?utf-8?B?eUlxV3B0Wk5xTUcyZ0NwUzZNOGZFa0lOcy9hV2VZNDkyR080U0RxSTAyMVh6?=
 =?utf-8?B?V3k4RnJxMmRUZHp6bVloRHpGQ2J5bUpyS1dVTWdMb2daUkN1Z3NBM1lnVmgy?=
 =?utf-8?B?cXcxM21FSUFRakplOGpQTWNYUnFZSDdSSWdHUDRVa01HNU16UFpFeVlvcU9Z?=
 =?utf-8?Q?qrPNGvgkCZYReM4k=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <AB8602DEC795FA42AA9F80F782552A25@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 03fac357-e402-45ed-e467-08d9ea55e24a
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Feb 2022 16:21:23.8220
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Wi7cu1mRvqw6hc3AVuFsR14aLeUM857u8CcxLHAh6GBpneA1p/WDC6BYYmyT2yJMtaAd+mzCtTwCur59NHbU+hta3b2qDQSbKBuLzXr5Zh4OAf7jLoQqWB6JW2cIqM+7
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB6082
X-Proofpoint-GUID: d-zq-QY_VO3LVTayeY9Ly1wliB1R0Zjn
X-Proofpoint-ORIG-GUID: d-zq-QY_VO3LVTayeY9Ly1wliB1R0Zjn
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-07_06,2022-02-07_02,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1015
 impostorscore=0 phishscore=0 mlxscore=0 spamscore=0 priorityscore=1501
 lowpriorityscore=0 mlxlogscore=978 bulkscore=0 malwarescore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202070102

DQoNCk9uIDA3LjAyLjIyIDE4OjE1LCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMDcuMDIuMjAy
MiAxNzowNywgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+PiBPbiAwNy4wMi4yMiAx
NzoyNiwgSmFuIEJldWxpY2ggd3JvdGU6DQo+Pj4gMWIuIE1ha2UgdnBjaV93cml0ZSB1c2Ugd3Jp
dGUgbG9jayBmb3Igd3JpdGVzIHRvIGNvbW1hbmQgcmVnaXN0ZXIgYW5kIEJBUnMNCj4+PiBvbmx5
OyBrZWVwIHVzaW5nIHRoZSByZWFkIGxvY2sgZm9yIGFsbCBvdGhlciB3cml0ZXMuDQo+PiBJIGFt
IG5vdCBxdWl0ZSBzdXJlIGhvdyB0byBkbyB0aGF0LiBEbyB5b3UgbWVhbiBzb21ldGhpbmcgbGlr
ZToNCj4+IHZvaWQgdnBjaV93cml0ZShwY2lfc2JkZl90IHNiZGYsIHVuc2lnbmVkIGludCByZWcs
IHVuc2lnbmVkIGludCBzaXplLA0KPj4gICDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAg
dWludDMyX3QgZGF0YSkNCj4+IFtzbmlwXQ0KPj4gICDCoMKgwqAgbGlzdF9mb3JfZWFjaF9lbnRy
eSAoIHIsICZwZGV2LT52cGNpLT5oYW5kbGVycywgbm9kZSApDQo+PiB7DQo+PiBbc25pcF0NCj4+
ICAgwqDCoMKgIGlmICggci0+bmVlZHNfd3JpdGVfbG9jaykNCj4+ICAgwqDCoMKgIMKgwqDCoCB3
cml0ZV9sb2NrKGQtPnZwY2lfbG9jaykNCj4+ICAgwqDCoMKgIGVsc2UNCj4+ICAgwqDCoMKgIMKg
wqDCoCByZWFkX2xvY2soZC0+dnBjaV9sb2NrKQ0KPj4gLi4uLg0KPj4NCj4+IEFuZCBwcm92aWRl
IHJ3IGFzIGFuIGFyZ3VtZW50IHRvOg0KPj4NCj4+IGludCB2cGNpX2FkZF9yZWdpc3RlcihzdHJ1
Y3QgdnBjaSAqdnBjaSwgdnBjaV9yZWFkX3QgKnJlYWRfaGFuZGxlciwNCj4+ICAgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHZwY2lfd3JpdGVfdCAqd3JpdGVfaGFu
ZGxlciwgdW5zaWduZWQgaW50IG9mZnNldCwNCj4+ICAgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgIHVuc2lnbmVkIGludCBzaXplLCB2b2lkICpkYXRhLCAtLS0+Pj4g
Ym9vbCB3cml0ZV9wYXRoIDw8PC0tLS0tKQ0KPj4NCj4+IElzIHRoaXMgd2hhdCB5b3UgbWVhbj8N
Cj4gVGhpcyBzb3VuZHMgb3Zlcmx5IGNvbXBsaWNhdGVkLiBZb3UgY2FuIGRlcml2ZSBsb2NhbGx5
IGluIHZwY2lfd3JpdGUoKSwNCj4gZnJvbSBqdXN0IGl0cyAicmVnIiBhbmQgInNpemUiIHBhcmFt
ZXRlcnMsIHdoZXRoZXIgdGhlIGxvY2sgbmVlZHMgdGFraW5nDQo+IGluIHdyaXRlIG1vZGUuDQpZ
ZXMsIEkgc3RhcnRlZCB3cml0aW5nIGEgcmVwbHkgd2l0aCB0aGF0LiBTbywgdGhlIHN1bW1hcnkg
KFJPTQ0KcG9zaXRpb24gZGVwZW5kcyBvbiBoZWFkZXIgdHlwZSk6DQppZiAoIChyZWcgPT0gUENJ
X0NPTU1BTkQpIHx8IChyZWcgPT0gUk9NKSApDQp7DQogwqDCoMKgIHJlYWQgUENJX0NPTU1BTkQg
YW5kIHNlZSBpZiBtZW1vcnkgb3IgSU8gZGVjb2RpbmcgYXJlIGVuYWJsZWQuDQogwqDCoMKgIGlm
ICggZW5hYmxlZCApDQogwqDCoMKgIMKgwqDCoCB3cml0ZV9sb2NrKGQtPnZwY2lfbG9jaykNCiDC
oMKgwqAgZWxzZQ0KIMKgwqDCoCDCoMKgwqAgcmVhZF9sb2NrKGQtPnZwY2lfbG9jaykNCn0NCg0K
RG8geW91IGFsc28gdGhpbmsgd2UgY2FuIGRyb3AgcGRldi0+dnBjaSAob3IgY3VycmVudGx5IHBk
ZXYtPnZwY2ktPmxvY2spDQphdCBhbGwgdGhlbj8NCj4gSmFuDQo+DQo+DQpUaGFuayB5b3UsDQpP
bGVrc2FuZHI=


From xen-devel-bounces@lists.xenproject.org Mon Feb 07 16:28:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 16:28:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267247.460967 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH6sj-0003AL-3Z; Mon, 07 Feb 2022 16:28:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267247.460967; Mon, 07 Feb 2022 16:28:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH6si-0003AE-W9; Mon, 07 Feb 2022 16:28:48 +0000
Received: by outflank-mailman (input) for mailman id 267247;
 Mon, 07 Feb 2022 16:28:47 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=owYM=SW=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nH6sh-0003A8-5f
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 16:28:47 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0528e1de-8833-11ec-8eb8-a37418f5ba1a;
 Mon, 07 Feb 2022 17:28:45 +0100 (CET)
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2050.outbound.protection.outlook.com [104.47.1.50]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-41-Yk7yNIw6MSm50xEL0sQNig-1; Mon, 07 Feb 2022 17:28:44 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DB9PR04MB9329.eurprd04.prod.outlook.com (2603:10a6:10:36f::9) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Mon, 7 Feb
 2022 16:28:42 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.018; Mon, 7 Feb 2022
 16:28:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0528e1de-8833-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644251325;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=v+yJ9eyaSl/nJiqAGwb9GJNT4J1X1vX9QpP4jwt+04c=;
	b=bUuIpLPuJhOMrZ6Kyt8xGXf1MPW7hiazXZObVhON6Oc2HX13YWPqqSvQ2WPiX/gcKWvHis
	Ii85y6qxPWQRcgyHrHL5HL+mgNhRbEYeeIhcQrf+yawipM26sL75FLmIeDPvt4OqsZ8hgQ
	qPh/pcWQMmKb4FFjNjPmEuJO6Zh75As=
X-MC-Unique: Yk7yNIw6MSm50xEL0sQNig-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gdH0kreFYSbBYHWAuON5ld70/9r4B3FpEUVfQU6xkfhJ3gN8+mA6uPKwnGdjCDmuH5AFub/h0SVDgARXDFCED7JGOpznKbsRNxHvOQgcxke5ZFtblFDQkG5S8W7lf7Pn/gjnB0UhAnjChSmyr2bdj/3toQcwDjMJ0a9Nm/ZneRwg7O4zWcQTJuGOVhqFZkUa+EcRu+AWSGkVRmpR0p9+icMH9VnvlC985gNv2iVCEC18/zF/ZXgKupwvDSeZbmfTGPYoqFwEmrOi8o0ddN8JBCKCuWzEvTS85BzZjOe/TNuRtHSg1MzjY1NTxBeZHrWUUeNW6NXEUo/rKynifFOv4A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=v+yJ9eyaSl/nJiqAGwb9GJNT4J1X1vX9QpP4jwt+04c=;
 b=d2H97uchH0BZWm/Vw2J+o4/KIGddEYJ3h6V68WhhKeLrM9xij4aFfb8sWChKq6vA/S0uMBI1Ojk2TOfXThCuv8NsCxCPoeHqdbiNKXPz99iCg07rOltI6MIvG/CzVsT1ejUrLrs0om4JdXjNoNfYBynyMs3PgOoEwcnhZIoIYRQ87SH6Q08/7G4s7UvNu5TROL4L9vf6b/+jvSoE1xjKHBq1H/CiRwdw9DnYLBn8UfMHAAyCIEctqUpBtgg8pWcSLHwpqdxzDkvrx8jn1amhXJ9zObEABewq77kQJzJEhkFAAKTgCkQvZ24C9DMZK3bqtRIan9FulecbM2fw5IIo/A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <16cea1df-3d0f-d404-2b88-aab47ad5548b@suse.com>
Date: Mon, 7 Feb 2022 17:28:40 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v6 05/13] vpci: add hooks for PCI device assign/de-assign
Content-Language: en-US
To: Oleksandr Andrushchenko <andr2000@gmail.com>
Cc: julien@xen.org, sstabellini@kernel.org, oleksandr_tyshchenko@epam.com,
 volodymyr_babchuk@epam.com, artem_mygaiev@epam.com, roger.pau@citrix.com,
 andrew.cooper3@citrix.com, george.dunlap@citrix.com, paul@xen.org,
 bertrand.marquis@arm.com, rahul.singh@arm.com,
 Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>,
 xen-devel@lists.xenproject.org
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-6-andr2000@gmail.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220204063459.680961-6-andr2000@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P191CA0040.EURP191.PROD.OUTLOOK.COM
 (2603:10a6:209:7f::17) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 3fe6bdfc-555d-4e2d-f839-08d9ea56e797
X-MS-TrafficTypeDiagnostic: DB9PR04MB9329:EE_
X-Microsoft-Antispam-PRVS:
	<DB9PR04MB9329A4C9CAC84E2FAD7E952FB32C9@DB9PR04MB9329.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	q9GXvfyJmAkgrz8AppqdfYyOoiMdiQS2GxEjxBewi0jIYF1XjoA6SZOlyPR/efE7R9rhItl9e5o6/rGMQT2T+8IxzI9LnPDKWYXduGjaIqWhKUPNSh3D4SQhhdER+czvyKmE6kY+pJeUzhOF5FeaI+lVjcETl2UZX+mefrzV5uZXjcLH5EbxxbYIwmtM077Z4m+NxUo9MtC/YDFV7eWOppvmlt0w+hcRCfuYtyhiVH6WdyrQKjVVRS3m9U71SG9xZYhKHgbNrFxx+3ZbTGmbz7a33kOZsLPM3whUAv9xbkGZnzMOn8qUuIHDPvEzphRYtra6921fsUzrR0Y2SJrXGwO7169Hp8OdlqfPEv10AXOp2bJJ9VGTnONe7DD4vtMIdzjSSgtiRZC0PV4T02XB9dSITN/XzmcjRD/QxX26f2b0RhiMk8dlzci5erB4Op8CgzB4EzapIm7kRB8BrgnQOSTwEDGyz7K8nIMepU6Ap90npC+uZsRVYiTXinKHreZsIQX4VYvB4z+q+5p4FEUIo1cM7g3g8hsEj6G/7jNiIr3LtqUWQoDwqHpEqOVp+JBB4q0TGUU9MQLYwcrkxUXq3+AiXVnGSe94VhCGceHMZTbqLr1bwirRjVRCFEQrLjQmm6c9bTbD1+173BV1/5f47w0KsLPM6qfku39VIIAgEObC1MG0p1qzLJ6kIpoH1ORn/u9gZQ/V80ApqYJ1OTlXyqQh9dsMAAV3WVZlzboKvYA=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(53546011)(36756003)(508600001)(31696002)(86362001)(66476007)(66556008)(6512007)(6506007)(83380400001)(2616005)(4326008)(26005)(186003)(5660300002)(6916009)(316002)(66946007)(6486002)(8676002)(8936002)(38100700002)(7416002)(2906002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?cTNoNGJ1VHFJUTdwZWNWRGNBN3ZPY2lRVnY0T0gyazdxNm9BYkRuZ0pVUGhI?=
 =?utf-8?B?TjROWDVMVmJKcXVIYVhYb3dIa2w1OCtPb3FCNVYwOFFGY25JV1ZLS0JySHhD?=
 =?utf-8?B?SzRqMk9HUjJPVC9odGkxYUFmVWFlTlgwaUpZb0ZhL0lENFZnL3BFOXcyMjkr?=
 =?utf-8?B?QjRROEtJVXBPQ0JXeW1YZmxkL2NBbmFPam53VTZpOWhKR2lmQkRDOW9reG9D?=
 =?utf-8?B?dGtMYXFDVDVUMHFNbFljbmpITVB0VG14N1JXNFhKTmUxaXBBMmtXMWttcHMv?=
 =?utf-8?B?LzNlbXg2RldocWZHVTdoWUhrMFc1NC90MlVadHFNZTl4eDEvNDZzbUZQejI4?=
 =?utf-8?B?WnN5VnZUN2dKU2Y4TkIzL3pqUmxwWjVzcnZsQkVZb3JLK01rb3c1dWljVGJU?=
 =?utf-8?B?OEhIaCt5TkQ1c1BjV2tVaW5CdjBicFdSK1JERmFzeGhaZHhOMnFKT29SWXdh?=
 =?utf-8?B?T1NzZEhZb1lZMkdMZXVNZERvOHVUZEVRL2pjbUVtMWlpSW4vVFVsQmdWRzR2?=
 =?utf-8?B?TE90c3pVTzQ3T1E2eHZ1aDdxUmsvWjBJcjZGbHExSHJkZFQ4enV5Nnc4N2RD?=
 =?utf-8?B?SWYzTExoOTR3WUw3S3FrY2Y3ckduNXIvdlhoQXdUcFJ6a2pqY1k3bm52OWsv?=
 =?utf-8?B?ajhzMFNzVHNUbW9LY0o4eklUbG00U29rQTZabkhrWllBQ0FHaDVRQ1Z6cEEx?=
 =?utf-8?B?UHEwOCtwUTVoL0lwVS9aUUdqSVBlMHY0OUhaWGZuc0VjU25GNmhFbWlBS0NV?=
 =?utf-8?B?MFBMRk4yK09VWnlobmJsQnhBaGtqQzg2Z1FVTnpEbEVWRTBBQ1ZxcUJsanJT?=
 =?utf-8?B?UVQzZnM1Z0I5WUx0c2xLcW5RWjhZbEV1KzhPSGRQb1FVb3NkdTBDWEtBaVJR?=
 =?utf-8?B?MmtRREZXZi9WRTJOUnozMC9Jb2FDRUVnV3NpRThUWVRhL0hWVnkrSzhEejV6?=
 =?utf-8?B?OU5JM0owTURiOHZmNW1FcCtLV253NTRWUkF2d1J2TVhUdENOckVsZnB0SXJL?=
 =?utf-8?B?VkNsUkExN3RTajFWc0ROOTRkTUNtNVg1QTR4TE85U3BXaHBHK0dXNEJWV1hC?=
 =?utf-8?B?RGluOHpqNHRDRDM1UHc3V21vQzZmd010cXp5VVhDTERHM0ZLbjl5TTdrUHAv?=
 =?utf-8?B?OWpucUQ1REJTZlRwd3JaSDVJWUxtMkZ5MSs1YVVBVGM1K0VCc3RJYWNTbytV?=
 =?utf-8?B?Mmgvb3g1Q1AzMnpZZ3NCNzRwNWxjRWswWTFaNEE4b0wvNDJTWGpyOElPbW1U?=
 =?utf-8?B?K3ZxOXFHVkhPRUpvTnpIOEY2bjFLK3UvYjM4L0FuVFlVSlhZaWVVajJtVG1a?=
 =?utf-8?B?YjJhVHhZQStCeGhvN1hIdDhURkpqWElHOC9YVVppR3VkdzZHazZ3a042UWJK?=
 =?utf-8?B?ZFdPNG1naXZhSDk3aGo3Z0krVE1oRVJnMjE4MnNWcjk4Q2lQNkVaRlJSeWlT?=
 =?utf-8?B?MURFM1BNWVRRak1DS3hCa1pCSTZocEczb3J5NTkxS2FJUVJrL1Z4ajZ4QTF0?=
 =?utf-8?B?eWFQejdtc0lRcmxjYnFqNXVSWG40QlhQbEFscVVXd3Jkdm1sbzNnMXBVMm84?=
 =?utf-8?B?Sm1vQ08wT1BnQ2tlTWFITVdXcXFqUUdNb2hVRVlPbDhLSW5vQUpoNDVrY2hR?=
 =?utf-8?B?N0ZFVUVHSWhBcXI2SThTNHNvK0hKTzJIMlpWKyt3UVMzNmNXSVl6OTdYUnZM?=
 =?utf-8?B?TXJRYWFCSFl2d1dqeDlGOTBoL0JWWXpHMkpVcHpIUERqZ2JTb21wVWh3VDhz?=
 =?utf-8?B?V3NaZjhjeTcvaGZnV2JPWVd4cWRhYTR3clA3RUdrR0IyS2trc0JUTHUvbzlU?=
 =?utf-8?B?eEJqaE4xQ2xpdU5yQVg4NS9JanJ1V1hYcEFsd0tUWVI3OGJFR0JyM3FwbVFI?=
 =?utf-8?B?QWNDUlVTaS8xMjRiTDc4dFFvbG1Ibm5KbkRzUFdieDY2MU4vSFlseXdxUmhL?=
 =?utf-8?B?clFQb3oyMmZWZVNhazdBY0g5MHhjN0hKekpMT0lXSSt0ZU9lUlZSOERtZVo3?=
 =?utf-8?B?ZnJ1Qjhldmd4V09kcDhDT3pxTXlEWXBoV3pXSmNlT05kK0cwQm1hTFdFTXk2?=
 =?utf-8?B?SDF3TnA5ejRsS2tYR2l6MFBvNExUQkFHZHZSeGY3N211MEdoakpMUE1ZSmZn?=
 =?utf-8?B?N2MwaHJiTm40ZFAwb1picHFWTEpmTUxlNGpnem8wcG5sUm8wMlpMSnFhSERC?=
 =?utf-8?Q?BNYwpkYtcHl8Pp16/mjTmw4=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3fe6bdfc-555d-4e2d-f839-08d9ea56e797
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2022 16:28:42.4781
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: l92nvIkTeYvBaN1hrZWRiR5a3UyfN8WhXzPkkDS0ech7d/Ye75qnA7G1p05EwJX+ngnGVwznT4xDh4WLc1G5Fg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9329

On 04.02.2022 07:34, Oleksandr Andrushchenko wrote:
> @@ -1507,6 +1511,8 @@ static int assign_device(struct domain *d, u16 seg, u8 bus, u8 devfn, u32 flag)
>                          pci_to_dev(pdev), flag);
>      }
>  
> +    rc = vpci_assign_device(d, pdev);
> +
>   done:
>      if ( rc )
>          printk(XENLOG_G_WARNING "%pd: assign (%pp) failed (%d)\n",

There's no attempt to undo anything in the case of getting back an
error. ISTR this being deemed okay on the basis that the tool stack
would then take whatever action, but whatever it is that is supposed
to deal with errors here wants spelling out in the description.
What's important is that no caller up the call tree may be left with
the impression that the device is still owned by the original
domain. With how you have it, the device is going to be owned by the
new domain, but not really usable.

> --- a/xen/drivers/vpci/vpci.c
> +++ b/xen/drivers/vpci/vpci.c
> @@ -99,6 +99,33 @@ int vpci_add_handlers(struct pci_dev *pdev)
>  
>      return rc;
>  }
> +
> +#ifdef CONFIG_HAS_VPCI_GUEST_SUPPORT
> +/* Notify vPCI that device is assigned to guest. */
> +int vpci_assign_device(struct domain *d, struct pci_dev *pdev)
> +{
> +    int rc;
> +
> +    if ( !has_vpci(d) )
> +        return 0;
> +
> +    rc = vpci_add_handlers(pdev);
> +    if ( rc )
> +        vpci_deassign_device(d, pdev);
> +
> +    return rc;
> +}
> +
> +/* Notify vPCI that device is de-assigned from guest. */
> +void vpci_deassign_device(struct domain *d, struct pci_dev *pdev)
> +{
> +    if ( !has_vpci(d) )
> +        return;
> +
> +    vpci_remove_device(pdev);
> +}
> +#endif /* CONFIG_HAS_VPCI_GUEST_SUPPORT */

While for the latter function you look to need two parameters, do you
really need them also in the former one?

Symmetry considerations make me wonder though whether the de-assign
hook shouldn't be called earlier, when pdev->domain still has the
original owner. At which point the 2nd parameter could disappear there
as well.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 07 16:38:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 16:38:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267256.460978 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH71Z-0004ck-0S; Mon, 07 Feb 2022 16:37:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267256.460978; Mon, 07 Feb 2022 16:37:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH71Y-0004cd-Tg; Mon, 07 Feb 2022 16:37:56 +0000
Received: by outflank-mailman (input) for mailman id 267256;
 Mon, 07 Feb 2022 16:37:56 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=owYM=SW=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nH71Y-0004cX-4o
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 16:37:56 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4cb3ba4f-8834-11ec-8eb8-a37418f5ba1a;
 Mon, 07 Feb 2022 17:37:55 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2171.outbound.protection.outlook.com [104.47.17.171]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-41-0kKyA77CP_qSec7lv1WvGQ-1; Mon, 07 Feb 2022 17:37:53 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM6PR04MB6246.eurprd04.prod.outlook.com (2603:10a6:20b:bc::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Mon, 7 Feb
 2022 16:37:51 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.018; Mon, 7 Feb 2022
 16:37:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4cb3ba4f-8834-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644251874;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=NQuY2Ha1SAcxC+SIoY65EjeeZujx0YBOcHmcl01a08Q=;
	b=Dvzh+sWnbkdCOKIdOnJJ0de2MWfpnRqQAMiak9o6RN1lB4LwzjWnwvVk/dPD7oshUidJNM
	aU/1rsLh0/dTM7C9G91OWM9XQhWI5aPbrB2R1EZXSFEA5LoNkktZRbK42EXrHN9mUqqAng
	m9xH38ZIUnMEcd3fpbEsI62wlGiXb0o=
X-MC-Unique: 0kKyA77CP_qSec7lv1WvGQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Uj88K/sthJ5TD6WeUvYPZyCOGY0VVOw3vE41aStQJO1xHzggpzxCbyhiYHZHAausn4X7sAZYD1D+pgOVii1q8qcVQmO86XOeMZLyFhUStXYafhM+SpZXoMJoZ+tE9rLz9Vu5XbL0YJrPGDfruGzPBL6t4h3w4UHT7bl2pvA3VTlSbPNv1IKrEx44V//P4gzIGKoe+4oYTWV8md8gKn9XgFPsz7Kcq+wtq6MTfX88wqQ1v+Ezn3Dl3FS2lV1vUDthR+GkZPoCsQULyZGy8TQIzEtXl1TNt1eox7IRjQ9+t2oLKTI1703/Z/zJL3kXBLq9wrJofO2XILBnkG6fpUpdkg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ZAHNb6VYbu3Zo8raeT6jyRxhzlTg98SLOUNeWj2Ehjc=;
 b=HDrbqfVbBO0Yt+F22ugWxTZyVwBdKkNTx6U9r5OBZH7AgCwf6DmcBBvLanA2gyvb+zQXwIuOEfq3/1SvUQSAHjeqbD7Y0RGhiwZdSOG017MnR0KdyOKqabZFnt5rahsRsqXYzIFVhJWmCFjTwDMzE5A1ngTxWv2052YKDb6NLpH6ArdlpxvtVnjEFi6pV51rTnQyyrlzlk60PFxV11TTh1wP7EsFdwllpvF5HN9qyQ/eaOjaAukb/VmBFgeZl4O5UGYLOSUWN94ybgrzKaeNMb2z8HZd7UWxKkSrq6h7bUvwBCIqrdX8x5hhuIdDoQ9rkt9Y/f3WgGG1rkDzcCFazw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <73e08285-6bb1-5842-899f-bd6502406e49@suse.com>
Date: Mon, 7 Feb 2022 17:37:49 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Content-Language: en-US
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: "julien@xen.org" <julien@xen.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Artem Mygaiev <Artem_Mygaiev@epam.com>,
 "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
 "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
 "paul@xen.org" <paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <7e3562b5-fc67-f213-e872-f211450d9e2e@epam.com>
 <a8fc599c-f620-c4d1-2077-c57068f46a7f@suse.com>
 <deef8468-d607-e49e-f456-6a8013329ca1@epam.com>
 <Yf0k6aoKK5G3iad1@Air-de-Roger>
 <3ad10a99-c706-b95f-1419-2c0c7cf37d58@epam.com>
 <Yf0+3C9nF8+tewLw@Air-de-Roger>
 <c5fea3bb-834b-eeb7-d7a1-1ee609037a9f@epam.com>
 <YgEUwTxhnWVMGMJK@Air-de-Roger>
 <9ce90193-74a0-5642-d22b-6b8c3340c3cf@epam.com>
 <1f65ae7a-898d-2c27-0ada-d71d778b0627@suse.com>
 <YgEsRuckQJIQlkzf@Air-de-Roger>
 <a2a42c1d-d379-00cd-5d55-f443cdb02e97@epam.com>
 <e8fc7872-c7d0-f389-c507-335b809ffcbc@epam.com>
 <21c8125a-2f79-1a4a-494c-db9e4be2a1a6@suse.com>
 <4276fe72-558b-7d95-6430-d4330989dbe8@epam.com>
 <ad985f4a-10f0-4a2d-df02-cde915fea3f1@suse.com>
 <f7669670-8eeb-9966-5ba3-e8f9c03ce3d3@epam.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <f7669670-8eeb-9966-5ba3-e8f9c03ce3d3@epam.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: FR3P281CA0075.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:1f::23) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4a3c3d00-a596-4d19-4591-08d9ea582f10
X-MS-TrafficTypeDiagnostic: AM6PR04MB6246:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB62469773D2E3DAA6A3060257B32C9@AM6PR04MB6246.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	wAR785CzXnwnBvoO4EqXSxbyh6UxK5AY1AYrHBqwr/n2ogMjs1YwxKPA2YIsz0NYgIJHHD7ZQuuFGzLo5eoIgFFyBuEJ53emD+A9pzk/swoyKK5yCBZlCCpH5NdZwFRrEJQEVAWdSR0aj0N0rQWyqtvC+dGXacv9jtUMSN2Jm3rzs7hjxyD2ViW3IdzT/ZYcEo0DP18gmDxRjbP8fyfWigwTTAtOt1EocwL/VLjJEK5lNVxQbvW4Xb798+ukColLvUh/02Vk17MxnjyBGre/jQOV7sq0+IbMn3CqCwSYrlLWoCzJ4nO4M+82ABmfQAFyFvMzgYAaPX07cRFFMOBLv+oNjE1q3ZNOJtkDqx0sLq8GusN164UiwKjYfSJvGnkMl+sW6dp9r6o3tHY2SisT9tE0sijhSquw5leoYFfGi+eQPQK3y0XocFJ6HtpKBGiVuln9ZcoksQf69TRRloT67norFomrDvHO1LFmontCgRMbpMF2nhpKO4HxVUpS7DhDQahIu2dndvqx7myib8j7mKP/ui120wRbP4lCf3KqDW5UM5Gmk2751OSVVsnB2+4z/Tp+WotuS2wSsziykoYyVuen1cyC7Crb8w3wTFtOjmQTwDjF4SDYZYKCwbzHH2uByDBRdEq1AUD/NwFBdLZSgBuSnjAiw2KY91TbvtEcR+8obcorlOunzrRePQTajrtghsa5vUg5YFxV22BPCKVnI76HRvKchcqtS9afjvPS/t0=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6512007)(5660300002)(6506007)(2906002)(38100700002)(31696002)(53546011)(86362001)(54906003)(316002)(7416002)(186003)(6916009)(66946007)(66476007)(66556008)(8936002)(4326008)(2616005)(26005)(6486002)(31686004)(8676002)(508600001)(83380400001)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?ULWwTZgMBdajo38r/SKKmuhIvSs3PuIcqn5Ab/qM6dUQaMBjJWQEHnRU4VNz?=
 =?us-ascii?Q?UAgPHr3SXbA1DR7bxG+/idCoUC7hD0DRsMqxRAj8rTfRLnR+AqqDEWNHX+xm?=
 =?us-ascii?Q?OdZqiDkJRA4zlp4136PmN1tZ0BUFJKPmzi1m/8tEpwsDRN3hfOdw2FmGFGIC?=
 =?us-ascii?Q?2eMckisM/wQp4b9zhuDfZ+Y0j/f3zDfr6ZelnIowu9qTSSskyVpO9BHkH56F?=
 =?us-ascii?Q?HOna7pqMvUypyocD3CKmO8MxfEt7fuMXQBtZeOxK99qE6SGTlPO4bFtE8FyZ?=
 =?us-ascii?Q?YBOsmSIqSdtMDeRq81ZzQBdmKb5GABreUyolSuk3V8BL1/JGyO9V81n3fkOI?=
 =?us-ascii?Q?BCUkQ6gTjObFSa4470LSoS/RFScoY0Qv9WB0NvT8QBXkgq8cdl4dFSwetkrW?=
 =?us-ascii?Q?Mdy68wcTaFig3yOpXlGtroj/Ex0WI890mbGoRepMwlkKt9rpnOwl8daMoSr6?=
 =?us-ascii?Q?ZDTV05kyKBF8LWW5nzxqAQd5TlfvM41E+Nyg+nksDSZDW/rxTyyJvLIvjio+?=
 =?us-ascii?Q?Y131YX+X0G9K3ShEPveHsD6p5mHmd2ebpj2l5tqrKuolNYu5uHgWEdYLXYl/?=
 =?us-ascii?Q?SxZh2l9WAUUiakQ3mdb0IS5vohNIJuJsmm3+/NUoWJ2YS0cvu+hzGSjXuRFn?=
 =?us-ascii?Q?V2kpJjiNcNynXkNxYEXmByvTUHUuJptiHnd7niBzqn+NI9RbCrAO5eEBPtEJ?=
 =?us-ascii?Q?hLAdvEgkM9WihRfn0Tl37ThJ6kGjYr2uaTfb9SH9jhyb8E7JO3ntoQQc8iJ1?=
 =?us-ascii?Q?jy3P4dXKShZl3nCcxQ0gQY6nI49j8EYAwUG3ea+0QCkn+ajURZMUqtJCxJ8S?=
 =?us-ascii?Q?japltqioBuZAh/4Cy1QaI5UcnPkScS3KwyyPS7Kb1O1kyGbehuZ1q/Zlqs/Y?=
 =?us-ascii?Q?ID+wEnYBAMwVuMlYH+4GZQTA4cvaJZjxNfbx4b6aoS7SA35YQmo+J8TRzVGJ?=
 =?us-ascii?Q?bztVQhiULHrT5MmDY+vsuQswDi3rcgv/znYgNe22b2cMQic4hGTJjo+hWtEz?=
 =?us-ascii?Q?uLKQprONNug0aQg3sS9mua39N6qo4Wp3POXv6SgOfBrDsPnNHfK11zE5jI/S?=
 =?us-ascii?Q?+/ItlXPXSvRsF6/RiW6HDWK5kalHuGiJYHCjNqv2gb5mA98szQQ76pfn+eNt?=
 =?us-ascii?Q?b0Rd6ISPboCOnb2okVTG5PEwsaT8bAYyU5PpqdNC+O6oCl6qiVCUCQojJvAo?=
 =?us-ascii?Q?DHx0+KoiViQ5U7moa+hNyw/xvV7JM2A8+OQ3uj0fdE5wQnlH/lO+QgBprg+Q?=
 =?us-ascii?Q?A10XLYYYnybfa5E6/u/IeSupL2yysUNtAJy9Xp1Z6EAT/9JEVfvW6fHIZIb/?=
 =?us-ascii?Q?C4pmWodRlRC/NmJsPzmwM544M0d6s65uEShB/J90lOuTXfMrb+F+0OUZ3mav?=
 =?us-ascii?Q?myK3fh86PecqDVTwy473bmHZrOpeIBepvJFDWLkEDxFtAPZzor/Ol8dd67BD?=
 =?us-ascii?Q?1gqDfDpbmYYz1rXgX5z4HVPnLtYx3nJem+u1/uKALxKFzyBJApS2MzgBxwUK?=
 =?us-ascii?Q?HqC99FC1pmxPBfcfEudrmo8foH3OWNzBlUbzoBxEeCEkNCmwomSav/ZG1zY2?=
 =?us-ascii?Q?+MFaU1IuwIAuTiC9Ij/BXiLUdjNr6BhdbtC17J2pnZ3mIpcgS4tseFZWu0ui?=
 =?us-ascii?Q?7egDYulA3DY/SxT5EzEMG5w=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4a3c3d00-a596-4d19-4591-08d9ea582f10
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2022 16:37:51.8502
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bhlarDbv3xrs330yTzFYNASKTi937bXCSQxj0M7hIoBn/xLeQc8q+mt5WbqDv3ftlSBRuY87fHJluPXkVdb2aA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB6246

On 07.02.2022 17:21, Oleksandr Andrushchenko wrote:
>=20
>=20
> On 07.02.22 18:15, Jan Beulich wrote:
>> On 07.02.2022 17:07, Oleksandr Andrushchenko wrote:
>>> On 07.02.22 17:26, Jan Beulich wrote:
>>>> 1b. Make vpci_write use write lock for writes to command register and =
BARs
>>>> only; keep using the read lock for all other writes.
>>> I am not quite sure how to do that. Do you mean something like:
>>> void vpci_write(pci_sbdf_t sbdf, unsigned int reg, unsigned int size,
>>>   =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0 uint32_t data)
>>> [snip]
>>>   =C2=A0=C2=A0=C2=A0 list_for_each_entry ( r, &pdev->vpci->handlers, no=
de )
>>> {
>>> [snip]
>>>   =C2=A0=C2=A0=C2=A0 if ( r->needs_write_lock)
>>>   =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 write_lock(d->vpci_lock)
>>>   =C2=A0=C2=A0=C2=A0 else
>>>   =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 read_lock(d->vpci_lock)
>>> ....
>>>
>>> And provide rw as an argument to:
>>>
>>> int vpci_add_register(struct vpci *vpci, vpci_read_t *read_handler,
>>>   =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 vpci_write_t *wri=
te_handler, unsigned int offset,
>>>   =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 unsigned int size=
, void *data, --->>> bool write_path <<<-----)
>>>
>>> Is this what you mean?
>> This sounds overly complicated. You can derive locally in vpci_write(),
>> from just its "reg" and "size" parameters, whether the lock needs taking
>> in write mode.
> Yes, I started writing a reply with that. So, the summary (ROM
> position depends on header type):
> if ( (reg =3D=3D PCI_COMMAND) || (reg =3D=3D ROM) )
> {
>  =C2=A0=C2=A0=C2=A0 read PCI_COMMAND and see if memory or IO decoding are=
 enabled.
>  =C2=A0=C2=A0=C2=A0 if ( enabled )
>  =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 write_lock(d->vpci_lock)
>  =C2=A0=C2=A0=C2=A0 else
>  =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 read_lock(d->vpci_lock)
> }

Hmm, yes, you can actually get away without using "size", since both
command register and ROM BAR are 32-bit aligned registers, and 64-bit
accesses get split in vpci_ecam_write().

For the command register the memory- / IO-decoding-enabled check may
end up a little more complicated, as the value to be written also
matters. Maybe read the command register only for the ROM BAR write,
using the write lock uniformly for all command register writes?

> Do you also think we can drop pdev->vpci (or currently pdev->vpci->lock)
> at all then?

I haven't looked at this in any detail, sorry. It sounds possible,
yes.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 07 16:44:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 16:44:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267267.460990 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH78E-00065Z-Sy; Mon, 07 Feb 2022 16:44:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267267.460990; Mon, 07 Feb 2022 16:44:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH78E-00065S-PU; Mon, 07 Feb 2022 16:44:50 +0000
Received: by outflank-mailman (input) for mailman id 267267;
 Mon, 07 Feb 2022 16:44:49 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=F54n=SW=epam.com=prvs=403792ff6c=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nH78D-00065M-5L
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 16:44:49 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4218df48-8835-11ec-8f75-fffcc8bd4f1a;
 Mon, 07 Feb 2022 17:44:47 +0100 (CET)
Received: from pps.filterd (m0174677.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 217GEJ5s029682;
 Mon, 7 Feb 2022 16:44:43 GMT
Received: from eur05-vi1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2176.outbound.protection.outlook.com [104.47.17.176])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e36ry857u-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Mon, 07 Feb 2022 16:44:43 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by DB9PR03MB7772.eurprd03.prod.outlook.com (2603:10a6:10:2cf::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Mon, 7 Feb
 2022 16:44:39 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77%3]) with mapi id 15.20.4951.018; Mon, 7 Feb 2022
 16:44:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4218df48-8835-11ec-8f75-fffcc8bd4f1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=PmjQaCxLCkW41b2yeXCFZyoLRvxyJuq9tbVFXmO7zk32U1TclltF13vGok8BfjN1oMjX0Nnl+NLp3jP6zy/v9e+5xgogAKpMPpGaWY56pPoQNOuPh+qH5fUiuREk1AYQ9DyZpRlUBxl2FGHTHejdAVABXdvMhixaT9L1tuxWos15Iux1844KTn/oLOnFb5iZaKbOIreKVFlqXz4Ryi8NXAQzS7w3JktPS/PcZs4aqr6cczgDvTKTQvQvTcr4g4iMAeImMlt2ozN7GFJyBASfOdxOcQMiHAsT5qe6Ryt15CTVBGts55YfzbxM+a9Czt88N+7KqwE5BCdkoBE0W5XocQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=FPtLNQl4wa16AG8n+cCPeqs62kNtmEA81rCQe4PyN1I=;
 b=ZXWn/UbioAj1OQVjN+QUaBY/1XVJE8Jo8q+tf3T7pIdaGqXgTAfSmxRWsH9h4zTkgAdtAK1FmpOGOkbRthYB4VYRWjZuGVvMGgDEZMHOcd0pYZ4XvowIhNzTtGoo0ks+QYz5EsF+zwwTXO5aE7laTgnL9nB/T+AhnZMqNXO/YRB53WGQCuqcMSlJAH/0TmEoHVxtnDwI2pKXXQgP+hKW9arHEtb1+gEP/c6tu9+pPRL1Nkn2X40A69e6OhxhMJ4beLneulmClKVB6AhUQwBkr94m8foIfm7imaHN64t3Ty/ZkfCyRG+w/2wKdN2VqvSa9ojSXV+B1mZXaUdjbzgmxw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=FPtLNQl4wa16AG8n+cCPeqs62kNtmEA81rCQe4PyN1I=;
 b=rBh8g7oXgiR6zfd9GJq27M2V1MNFeixaSVBPqY/RcBxoAjd5Hgn04+rGM9pjlgIQBxAkoVjy90MaG+xAggj6w32VQx1HRYMI026ffmhzLe2zAZ4IRlurRBOyRkuJxQJqe7oDjH/RFEjsCkbj+b2lMJlQ3H4jRrA2tlyW2QQ+u/OgL5F3TKxb83O0VNqs36ewdlsyZnfCIKPKIs6SCrhSqQwrjycnh1liO3fdjzzPtPV/u7Q+1SQBIzXfbXwMtIZmof6MF4KXL9//ZE+/PninkHvYHeFEuK3K9nRsBKNiqVc7BdYsa5zhy7ry1Bdc5uuhs33kZ/zh9wgs4DKESotJww==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?=
	<roger.pau@citrix.com>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Thread-Topic: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Thread-Index: 
 AQHYGZFc/MnzQOjwVEeBBUHLSW0md6yDBUkAgAASSACAAATYAIAAD/WAgAAKNgCAAAbfgIAABnuAgAAQvgCAAAMCAIAAAY4AgAADxICAABrnAIAABAgAgAR3CoCAABt5gIAAEpuAgAAE5ICAAASKAIAAAiiAgAAKNYCAAARNAIAAC1wAgAACRYCAAAGVgIAABJiAgAAB5wA=
Date: Mon, 7 Feb 2022 16:44:39 +0000
Message-ID: <be3f4222-6580-4c89-a202-c003b6feb9b4@epam.com>
References: <7e3562b5-fc67-f213-e872-f211450d9e2e@epam.com>
 <a8fc599c-f620-c4d1-2077-c57068f46a7f@suse.com>
 <deef8468-d607-e49e-f456-6a8013329ca1@epam.com>
 <Yf0k6aoKK5G3iad1@Air-de-Roger>
 <3ad10a99-c706-b95f-1419-2c0c7cf37d58@epam.com>
 <Yf0+3C9nF8+tewLw@Air-de-Roger>
 <c5fea3bb-834b-eeb7-d7a1-1ee609037a9f@epam.com>
 <YgEUwTxhnWVMGMJK@Air-de-Roger>
 <9ce90193-74a0-5642-d22b-6b8c3340c3cf@epam.com>
 <1f65ae7a-898d-2c27-0ada-d71d778b0627@suse.com>
 <YgEsRuckQJIQlkzf@Air-de-Roger>
 <a2a42c1d-d379-00cd-5d55-f443cdb02e97@epam.com>
 <e8fc7872-c7d0-f389-c507-335b809ffcbc@epam.com>
 <21c8125a-2f79-1a4a-494c-db9e4be2a1a6@suse.com>
 <4276fe72-558b-7d95-6430-d4330989dbe8@epam.com>
 <ad985f4a-10f0-4a2d-df02-cde915fea3f1@suse.com>
 <f7669670-8eeb-9966-5ba3-e8f9c03ce3d3@epam.com>
 <73e08285-6bb1-5842-899f-bd6502406e49@suse.com>
In-Reply-To: <73e08285-6bb1-5842-899f-bd6502406e49@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 858336a2-3ba3-46e3-846a-08d9ea59220b
x-ms-traffictypediagnostic: DB9PR03MB7772:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <DB9PR03MB77729F4F1D8D1D4B50EB8B8AE72C9@DB9PR03MB7772.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 TP1EBDHYX6QPKAbFnwimWW/2W7QjBMWfE3WEoLqu+2/FJAjPxUrc0MtLBuABTb8PVJNodIdIE8YQUpu/uKsE9nPUj05hY1NXjxUdExME1wAWLryAnSjL8Spt6y5G//RQSAA2HQiETxL4F2FlMDnc16kpReI6EizRuKtrd5J/PlblmOWYaEhBktJd85HDcOT42H4EGTj5rjNwzuwC2IYdUeeqoDiYBeX2fTue9El50DUAnChRFgKUYee5csVrV97emh8qIfrwruvWGY//KKOBLD2fTOqpTF69y3PtKhsQM/0EWckNTVfoXNca3qCr3t/rZ78ucXtGfhyOgYORhAH9+cnHL1nvJFATv11CqhZUeqXjCXgz1ehBM0EcZfwmTm9ERV7jst2tb2Ub06NFN5EzzkE3H0S+K3LU75BArV3ZhWRrYKTfCwiW7dsiVNKsjMIgCk7MyvoSLPxjZUstOxqFWOaEzMSRpOewP/wHr/O6/FVX+LtDZKbIrqa+2an7TBqClIGS+vAsDab+hXwWTanAALZ6tbHO0/WjMi9IKqnOU6Yji2JIKkN4v0W9xdlsp2ehBx2KmPNsgkvQ6ly66yOK8qnsxEQSqrwrfacg6nilYWF+6nXUvAerHacSIgc4vgRQkb7TiBA0ICFjOg2EJSA3X8kAMjcoPoh5+t4jCmHrsF7D9jcUG7wF1DQhBIvJ7L1cTFi4bNxYSnGRuaue/QYKlmspGLk2OSzdci4mj/Ft9S4=
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(86362001)(107886003)(2906002)(2616005)(508600001)(6486002)(316002)(54906003)(36756003)(6916009)(31686004)(7416002)(55236004)(5660300002)(122000001)(8676002)(4326008)(8936002)(66556008)(53546011)(6506007)(64756008)(6512007)(91956017)(76116006)(31696002)(186003)(26005)(38070700005)(83380400001)(66946007)(71200400001)(38100700002)(66446008)(66476007)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?eUt3ZEZQL2pyYmlpM2dSUzlyZjI1dmFxaHN2NENYYXRjQlU4OXhOOVEvdHRS?=
 =?utf-8?B?aG1YbVQ3QkdOOXRVdyt2MnYvWlV5UWtMVGR3TU5tYUd0eWtIZmNhWEpubG9X?=
 =?utf-8?B?VTE2ME5ITGpmQzV1UnJLaWkwZHY2NDVKNnpjSVRCaGtEU1ZmOUhYVGp5ekZW?=
 =?utf-8?B?ajV5NzhUYTgyQXZ0ZHlGZ05lOVAwb3NTNFhVVjVpZW5BM21idjJZL0pzbHNl?=
 =?utf-8?B?bGExOWltNytDSTdsQlo5OWQySXh6RnR6eTdGZktWeEk0dnJvOFF3SFZheHlQ?=
 =?utf-8?B?NGQ3ZUVMa3hISzgra012TmN3enFrU2VZVHRNaHBLb3A4SDV3OFdnaThoS1Jr?=
 =?utf-8?B?QmNBRExoQWIyTW94a2d6ZFFxU3hWU1lBdlhFU2NsNXJiY01XQ2NqeGlja29N?=
 =?utf-8?B?cDFicUNnRDBNNXBpdWhDT2VjeXhFY0gvQlF2MmZ0OHlvenZ3S3E1TGs0emo5?=
 =?utf-8?B?ZmRmcFE0dnVSUzBsSnhOSnRiTkp0YzBpdkVMVndsbHhaT3pQR09vZm1xTHhF?=
 =?utf-8?B?dGdsOW1FMDkrb3NjVmdvUnYrTGxYTjhLaklQRDZOWmtpT1IrWm0zU2VjMjZj?=
 =?utf-8?B?djlyOFEzSFZXcFZYdjRPS3N5VUlCczVSdFZ4SVZiclYvVjg2eDlZODU5UWRI?=
 =?utf-8?B?bHplVWk4UGJlZytkeVdIN08wMkpHRmJoYWxwMDlXTDBaVzlRWVZHQ0hIR1BP?=
 =?utf-8?B?YjA0cjdHWG1YVGs0RkF2a0VpcVlsbjVnVEpxWGFSU0YySWtEM2g1QTRLWUdr?=
 =?utf-8?B?QVBNbm1LVnlQWmhnc2kvaTRMaFlOdS9zZE44NEswcnFjQ01Oc1ZXSTFlK295?=
 =?utf-8?B?Z0RKVEVTcTdOVml5T2xvcEZTbG8ybTVJQ05MRThvbW9TaHlFUmVUTFY2RlJN?=
 =?utf-8?B?NFFtejZiL2tMeFl3YTdPeFNsMUpxWFpVS2VrUG1CQklndmxrbWM0Y04wVGhS?=
 =?utf-8?B?Y2YxcEZOVkhtSEVwcWlLYy9JdFRMYXpraks1b0Nsa1pSK29nR080ZVhqSWtY?=
 =?utf-8?B?ZndSb3o0d3l5dXZhYjIwU25JQ3JEZkNSd05nNkVabEZkOXZIY3FTVUdiZ1dG?=
 =?utf-8?B?WTZxK2FkYUdGWmNVbThMNzM4cDVKSDJWZWdUMWVTMDNsVWlXVFpuY0ZMbExS?=
 =?utf-8?B?aWtaa3Z5dzB2Q0lOSldUL05ydzhIQTZKcEJnby9BTGEzZUpOalJMdmFoN2lL?=
 =?utf-8?B?ZzlZTE9uTWViZElHRTY5TlR3WFpTZWE4aEhYYi9rT3JJS0ZGa0NGZGJvbDhM?=
 =?utf-8?B?MTJTYzFQd0xocmVGdXVybmtmQk9OU0ptK2FzR2xYQzVaWk0wOG9icFlHYzVu?=
 =?utf-8?B?Tk45Q01xOTMrcnJnTDMzMFQxUEZ0aGpTZ0lFd2RySWhKd3ltemlSNVQwNnF4?=
 =?utf-8?B?Qk8xZHVvVjNjWFVXcDUrdzEwQllQUXZCa2YwMmV2VjhFNU1PYUtmRENkV2po?=
 =?utf-8?B?QTdhcTB1WWtlVkt6cFEvbHFPZThwbGZIdkpEOEp5TlhzV244U2RRVFdNbGgx?=
 =?utf-8?B?eGhGcTNFcXNLSkh3RG9yNkhZbVJnVTEvUzFoM1VieGxSTkFaUi8xcTR5Y1Ry?=
 =?utf-8?B?VEhHamU5L0l3WENucTEyMDV2NlIzRUFuc1RUWUJQRHZFd011cVM1QVQ2V3NO?=
 =?utf-8?B?ZDZTYXg3QW9ST00xSWZVeG00Zm1ENXR2OE94dGhkaENXby8wL1ZxY2hUTzNN?=
 =?utf-8?B?VG16VWI5Y0txOVBocWwxZmpBdCs0b0MvWEJOSWwzQnV3ZWY2Q2l4NHRsY2Mr?=
 =?utf-8?B?dGFSQXppZ3pMMVVRS0JZcXFxQU04aDFxQnB6ci9Na1drMHRnNVpvWW1QRElK?=
 =?utf-8?B?a05jVjNrUDMxalI2MG5oMTFNNlZzbDBodm1rZ05YaEw2UVF5K3ppSjNNRGdp?=
 =?utf-8?B?SytUcDBPb0JjOGV0U0tndEpQbUZ5a2xiQlY1K043MWJjalRSSWhMNVFIb2xQ?=
 =?utf-8?B?TXpwUXU2M3k5NVlDM0RhaVpkaXB5YTRHS0JsVys5dWJCRHNqQTRDbVlnWmVj?=
 =?utf-8?B?ZENXVUVqNWk3YjJPREV6SHMxUEVwSE5KUnFLNXhrRk5IdU5KN01pRUI4N1Ru?=
 =?utf-8?B?L09TQ1JMSEhyWTdEaUJKMG9RU3FyUDAyM3k4VGVMeDBvQWR2NXVyaUJGOTFy?=
 =?utf-8?B?a0RMeHlOcG5XQUIxZDRkbjZVd2lYWThGbnY2UVd5WEtFekRta0J5SldvZFFX?=
 =?utf-8?B?NU5EMHJNNnpDM1BuSHBNRTUrTUZJaldaWWFBN2RETjYwaUl3ZlczT0NYcHNV?=
 =?utf-8?B?eDVGSjZ1YVhzMXZwcHRCMEFzWEVlWVR3cXdnVFBDN1lMeW9JcTBJSGpaTzVY?=
 =?utf-8?B?LzFOUGdORWxnWTFkOWFFenJGWCthcmgwL0dFTExycXJaazVUMUhkWGFodnJw?=
 =?utf-8?Q?OKGJs/ifyRW/8N9k=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <8B12754EEB02F843BA0A6324AABA9ECC@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 858336a2-3ba3-46e3-846a-08d9ea59220b
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Feb 2022 16:44:39.1930
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Jcicyq3nodBz8xzo0QE7+v+KjX9GSYuO4zlNJMqDJ2ndbWIaukc4sXR+1JlP2D+Ay6cNpzpddIM0bnU6OO9sowCxwJGS+PDpQC4fgSRQiTl4y1xBGCPIo8beYhVyrwuo
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR03MB7772
X-Proofpoint-GUID: QHzyYGgTuZv9bQCXwPzs41bPQ-gne9B_
X-Proofpoint-ORIG-GUID: QHzyYGgTuZv9bQCXwPzs41bPQ-gne9B_
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-07_06,2022-02-07_02,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 spamscore=0
 lowpriorityscore=0 adultscore=0 phishscore=0 impostorscore=0
 malwarescore=0 clxscore=1015 priorityscore=1501 suspectscore=0 bulkscore=0
 mlxlogscore=876 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202070104

DQoNCk9uIDA3LjAyLjIyIDE4OjM3LCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMDcuMDIuMjAy
MiAxNzoyMSwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+Pg0KPj4gT24gMDcuMDIu
MjIgMTg6MTUsIEphbiBCZXVsaWNoIHdyb3RlOg0KPj4+IE9uIDA3LjAyLjIwMjIgMTc6MDcsIE9s
ZWtzYW5kciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4+PiBPbiAwNy4wMi4yMiAxNzoyNiwgSmFu
IEJldWxpY2ggd3JvdGU6DQo+Pj4+PiAxYi4gTWFrZSB2cGNpX3dyaXRlIHVzZSB3cml0ZSBsb2Nr
IGZvciB3cml0ZXMgdG8gY29tbWFuZCByZWdpc3RlciBhbmQgQkFScw0KPj4+Pj4gb25seTsga2Vl
cCB1c2luZyB0aGUgcmVhZCBsb2NrIGZvciBhbGwgb3RoZXIgd3JpdGVzLg0KPj4+PiBJIGFtIG5v
dCBxdWl0ZSBzdXJlIGhvdyB0byBkbyB0aGF0LiBEbyB5b3UgbWVhbiBzb21ldGhpbmcgbGlrZToN
Cj4+Pj4gdm9pZCB2cGNpX3dyaXRlKHBjaV9zYmRmX3Qgc2JkZiwgdW5zaWduZWQgaW50IHJlZywg
dW5zaWduZWQgaW50IHNpemUsDQo+Pj4+ICAgIMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oCB1aW50MzJfdCBkYXRhKQ0KPj4+PiBbc25pcF0NCj4+Pj4gICAgwqDCoMKgIGxpc3RfZm9yX2Vh
Y2hfZW50cnkgKCByLCAmcGRldi0+dnBjaS0+aGFuZGxlcnMsIG5vZGUgKQ0KPj4+PiB7DQo+Pj4+
IFtzbmlwXQ0KPj4+PiAgICDCoMKgwqAgaWYgKCByLT5uZWVkc193cml0ZV9sb2NrKQ0KPj4+PiAg
ICDCoMKgwqAgwqDCoMKgIHdyaXRlX2xvY2soZC0+dnBjaV9sb2NrKQ0KPj4+PiAgICDCoMKgwqAg
ZWxzZQ0KPj4+PiAgICDCoMKgwqAgwqDCoMKgIHJlYWRfbG9jayhkLT52cGNpX2xvY2spDQo+Pj4+
IC4uLi4NCj4+Pj4NCj4+Pj4gQW5kIHByb3ZpZGUgcncgYXMgYW4gYXJndW1lbnQgdG86DQo+Pj4+
DQo+Pj4+IGludCB2cGNpX2FkZF9yZWdpc3RlcihzdHJ1Y3QgdnBjaSAqdnBjaSwgdnBjaV9yZWFk
X3QgKnJlYWRfaGFuZGxlciwNCj4+Pj4gICAgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgIHZwY2lfd3JpdGVfdCAqd3JpdGVfaGFuZGxlciwgdW5zaWduZWQgaW50IG9m
ZnNldCwNCj4+Pj4gICAgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
IHVuc2lnbmVkIGludCBzaXplLCB2b2lkICpkYXRhLCAtLS0+Pj4gYm9vbCB3cml0ZV9wYXRoIDw8
PC0tLS0tKQ0KPj4+Pg0KPj4+PiBJcyB0aGlzIHdoYXQgeW91IG1lYW4/DQo+Pj4gVGhpcyBzb3Vu
ZHMgb3Zlcmx5IGNvbXBsaWNhdGVkLiBZb3UgY2FuIGRlcml2ZSBsb2NhbGx5IGluIHZwY2lfd3Jp
dGUoKSwNCj4+PiBmcm9tIGp1c3QgaXRzICJyZWciIGFuZCAic2l6ZSIgcGFyYW1ldGVycywgd2hl
dGhlciB0aGUgbG9jayBuZWVkcyB0YWtpbmcNCj4+PiBpbiB3cml0ZSBtb2RlLg0KPj4gWWVzLCBJ
IHN0YXJ0ZWQgd3JpdGluZyBhIHJlcGx5IHdpdGggdGhhdC4gU28sIHRoZSBzdW1tYXJ5IChST00N
Cj4+IHBvc2l0aW9uIGRlcGVuZHMgb24gaGVhZGVyIHR5cGUpOg0KPj4gaWYgKCAocmVnID09IFBD
SV9DT01NQU5EKSB8fCAocmVnID09IFJPTSkgKQ0KPj4gew0KPj4gICDCoMKgwqAgcmVhZCBQQ0lf
Q09NTUFORCBhbmQgc2VlIGlmIG1lbW9yeSBvciBJTyBkZWNvZGluZyBhcmUgZW5hYmxlZC4NCj4+
ICAgwqDCoMKgIGlmICggZW5hYmxlZCApDQo+PiAgIMKgwqDCoCDCoMKgwqAgd3JpdGVfbG9jayhk
LT52cGNpX2xvY2spDQo+PiAgIMKgwqDCoCBlbHNlDQo+PiAgIMKgwqDCoCDCoMKgwqAgcmVhZF9s
b2NrKGQtPnZwY2lfbG9jaykNCj4+IH0NCj4gSG1tLCB5ZXMsIHlvdSBjYW4gYWN0dWFsbHkgZ2V0
IGF3YXkgd2l0aG91dCB1c2luZyAic2l6ZSIsIHNpbmNlIGJvdGgNCj4gY29tbWFuZCByZWdpc3Rl
ciBhbmQgUk9NIEJBUiBhcmUgMzItYml0IGFsaWduZWQgcmVnaXN0ZXJzLCBhbmQgNjQtYml0DQo+
IGFjY2Vzc2VzIGdldCBzcGxpdCBpbiB2cGNpX2VjYW1fd3JpdGUoKS4NCkJ1dCwgT1MgbWF5IHdh
bnQgcmVhZGluZyBhIHNpbmdsZSBieXRlIG9mIFJPTSBCQVIsIHNvIEkgdGhpbmsNCkknbGwgbmVl
ZCB0byBjaGVjayBpZiByZWcrc2l6ZSBmYWxsIGludG8gUENJX0NPTUFORCBhbmQgUk9NIEJBUg0K
cmFuZ2VzDQo+DQo+IEZvciB0aGUgY29tbWFuZCByZWdpc3RlciB0aGUgbWVtb3J5LSAvIElPLWRl
Y29kaW5nLWVuYWJsZWQgY2hlY2sgbWF5DQo+IGVuZCB1cCBhIGxpdHRsZSBtb3JlIGNvbXBsaWNh
dGVkLCBhcyB0aGUgdmFsdWUgdG8gYmUgd3JpdHRlbiBhbHNvDQo+IG1hdHRlcnMuIE1heWJlIHJl
YWQgdGhlIGNvbW1hbmQgcmVnaXN0ZXIgb25seSBmb3IgdGhlIFJPTSBCQVIgd3JpdGUsDQo+IHVz
aW5nIHRoZSB3cml0ZSBsb2NrIHVuaWZvcm1seSBmb3IgYWxsIGNvbW1hbmQgcmVnaXN0ZXIgd3Jp
dGVzPw0KU291bmRzIGdvb2QgZm9yIHRoZSBzdGFydC4NCkFub3RoZXIgY29uY2VybiBpcyB0aGF0
IGlmIHdlIGdvIHdpdGggYSByZWFkX2xvY2sgYW5kIHRoZW4gaW4gdGhlDQp1bmRlcmx5aW5nIGNv
ZGUgd2UgZGlzYWJsZSBtZW1vcnkgZGVjb2RpbmcgYW5kIHRyeSBkb2luZw0Kc29tZXRoaW5nIGFu
ZCBjYWxsaW5nIGNtZF93cml0ZSBoYW5kbGVyIGZvciBhbnkgcmVhc29uIHRoZW4uLi4uDQoNCkkg
bWVhbiB0aGF0IHRoZSBjaGVjayBpbiB0aGUgdnBjaV93cml0ZSBpcyBzb21ld2hhdCB3ZSBjYW4g
dG9sZXJhdGUsDQpidXQgdGhlbiBpdCBpcyBtdXN0IGJlIGNvbnNpZGVyZWQgdGhhdCBubyBjb2Rl
IGluIHRoZSByZWFkIHBhdGgNCmlzIGFsbG93ZWQgdG8gcGVyZm9ybSB3cml0ZSBwYXRoIGZ1bmN0
aW9ucy4gV2hpY2ggYnJpbmdzIGEgcHJldHR5DQp2YWxpZCB1c2UtY2FzZTogc2F5IGluIHJlYWQg
bW9kZSB3ZSBkZXRlY3QgYW4gdW5yZWNvdmVyYWJsZSBlcnJvcg0KYW5kIG5lZWQgdG8gcmVtb3Zl
IHRoZSBkZXZpY2U6DQp2cGNpX3Byb2Nlc3NfcGVuZGluZyAtPiBFUlJPUiAtPiB2cGNpX3JlbW92
ZV9kZXZpY2Ugb3Igc2ltaWxhci4NCg0KV2hhdCBkbyB3ZSBkbyB0aGVuPyBJdCBpcyBhbGwgZ29p
bmcgdG8gYmUgZnJhZ2lsZS4uLg0KPg0KPj4gRG8geW91IGFsc28gdGhpbmsgd2UgY2FuIGRyb3Ag
cGRldi0+dnBjaSAob3IgY3VycmVudGx5IHBkZXYtPnZwY2ktPmxvY2spDQo+PiBhdCBhbGwgdGhl
bj8NCj4gSSBoYXZlbid0IGxvb2tlZCBhdCB0aGlzIGluIGFueSBkZXRhaWwsIHNvcnJ5LiBJdCBz
b3VuZHMgcG9zc2libGUsDQo+IHllcy4NCj4NCj4gSmFuDQo+DQpUaGFuayB5b3UsDQpPbGVrc2Fu
ZHI=


From xen-devel-bounces@lists.xenproject.org Mon Feb 07 16:46:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 16:46:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267274.461001 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH79L-0006eV-75; Mon, 07 Feb 2022 16:45:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267274.461001; Mon, 07 Feb 2022 16:45:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH79L-0006eO-38; Mon, 07 Feb 2022 16:45:59 +0000
Received: by outflank-mailman (input) for mailman id 267274;
 Mon, 07 Feb 2022 16:45:57 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nH79J-0006eG-Rb
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 16:45:57 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nH79J-0007r7-JM; Mon, 07 Feb 2022 16:45:57 +0000
Received: from 54-240-197-226.amazon.com ([54.240.197.226] helo=[10.85.34.134])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nH79J-0004Jf-Dh; Mon, 07 Feb 2022 16:45:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=fAkTXZjB6ApF7OPcL97clowM//E+N4IUnr9AhGn2Hp4=; b=cxfsI6c1qR4c6o7JvDhvNdFNgN
	RO85FbTL3QhZHjoplAzqighIZB4OjvTBmlQ4iLuuezY52uXMdDRIrsERhiNWMIAjdTz6t71kd9qGt
	8se+GUHpXex7D6tmoOVoo8BOYC/xsGVLkbiza0IX5kY9mcXu5t3SCc8YdZGE2zUC7DPw=;
Message-ID: <5da1b0da-0e9d-1f10-0667-39ce8dd04c39@xen.org>
Date: Mon, 7 Feb 2022 16:45:55 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.1
Subject: Re: [XEN PATCH v3] xen/arm: introduce dummy iommu node for dom0
To: Sergiy Kibrik <Sergiy_Kibrik@epam.com>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <olekstysh@gmail.com>,
 Andrii Anisov <Andrii_Anisov@epam.com>
References: <20220111112611.90508-1-Sergiy_Kibrik@epam.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220111112611.90508-1-Sergiy_Kibrik@epam.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 11/01/2022 11:26, Sergiy Kibrik wrote:
> Currently no IOMMU properties are exposed to dom0, thus kernel by default
> assumes no protection and enables swiotlb-xen, which leads to costly and
> unnecessary buffers bouncing.
> 
> To let kernel know which device is behing IOMMU and hence needs no swiotlb
> services we introduce dummy xen-iommu node in FDT and link protected device
> nodes to it, using here device tree iommu bindings.
> 
> Signed-off-by: Sergiy Kibrik <Sergiy_Kibrik@epam.com>
> ---
> Cc: Stefano Stabellini <sstabellini@kernel.org>
> Cc: Julien Grall <julien@xen.org>
> Cc: Oleksandr Tyshchenko <olekstysh@gmail.com>
> Cc: Andrii Anisov <Andrii_Anisov@epam.com>
> 
> 
> Changelog:
> 
> v3: rebased over staging & remove redundand phandle_iommu attribute, discussion:
> 	https://lists.xenproject.org/archives/html/xen-devel/2021-12/msg01753.html
> 
> v2: re-use common iommu dt bindings to let guests know which devices are protected:
> 	https://lists.xenproject.org/archives/html/xen-devel/2021-10/msg00073.html
> 
>   xen/arch/arm/domain_build.c           | 42 +++++++++++++++++++++++++++
>   xen/include/public/device_tree_defs.h |  1 +
>   2 files changed, 43 insertions(+)
> 
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index 6931c022a2..b82ba72fac 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -845,6 +845,12 @@ static int __init write_properties(struct domain *d, struct kernel_info *kinfo,
>           }
>       }
>   
> +    if ( iommu_node && is_iommu_enabled(d) && dt_device_is_protected(node) )

I think it should be sufficient to check dt_device_is_protected() 
because it is set it means that device behind an IOMMU known by Xen. So 
iommu_node will always be valid.

Furthermore, you can't assign to dom0 a device that was protected with 
enabling the IOMMU for the domain.

> +    {
> +        res = fdt_property_cell(kinfo->fdt, "iommus", GUEST_PHANDLE_IOMMU);
> +        if ( res )
> +            return res;
> +    }
>       return 0;
>   }
>   
> @@ -1479,6 +1485,38 @@ static int __init make_cpus_node(const struct domain *d, void *fdt)
>       return res;
>   }
>   
> +static int __init make_iommu_node(const struct domain *d,
> +                                  const struct kernel_info *kinfo)
> +{
> +    const char compat[] = "xen,iommu-el2-v1";
> +    int res;
> +
> +    if ( !is_iommu_enabled(d) )
> +        return 0;
> +
> +    dt_dprintk("Create iommu node\n");
> +
> +    res = fdt_begin_node(kinfo->fdt, "xen-iommu");
> +    if ( res )
> +        return res;
> +
> +    res = fdt_property(kinfo->fdt, "compatible", compat, sizeof(compat));
> +    if ( res )
> +        return res;
> +
> +    res = fdt_property_cell(kinfo->fdt, "#iommu-cells", 0);
> +    if ( res )
> +        return res;
> +
> +    res = fdt_property_cell(kinfo->fdt, "phandle", GUEST_PHANDLE_IOMMU);

Please don't hardocode the phandle for the IOMMU. Instead we should use 
one for an IOMMU that is used by Xen.

This will reduce the risk to use a phandle that could be possibly used 
in the host Device-Tree.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Feb 07 17:06:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 17:06:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267285.461011 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH7T2-0000cC-So; Mon, 07 Feb 2022 17:06:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267285.461011; Mon, 07 Feb 2022 17:06:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH7T2-0000c5-Pp; Mon, 07 Feb 2022 17:06:20 +0000
Received: by outflank-mailman (input) for mailman id 267285;
 Mon, 07 Feb 2022 17:06:19 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=owYM=SW=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nH7T1-0000bz-B0
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 17:06:19 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 43b8a1a4-8838-11ec-8f75-fffcc8bd4f1a;
 Mon, 07 Feb 2022 18:06:18 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2054.outbound.protection.outlook.com [104.47.14.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-34-EpD4W0BoNQizTdK9xpGtlQ-1; Mon, 07 Feb 2022 18:06:16 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by HE1PR04MB3307.eurprd04.prod.outlook.com (2603:10a6:7:23::18) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Mon, 7 Feb
 2022 17:06:13 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.018; Mon, 7 Feb 2022
 17:06:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 43b8a1a4-8838-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644253577;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Eak0n+eKgYksPTt8z/Zey1HNNYwAIEU4CabgD8aYCic=;
	b=H8jNTQ8MzXdBMZASNOPzTYPnVNETvYk3/eTPS8ZNzYe4qrhtEXp12qe0H1Oy3W5RC+aU1O
	FAlGRZ0nEB0Xuvj91ASuvX8+tNdWgq1G84pkODSK7m/7wT4hip0hdcDQcCIrzEEbDd7aA0
	mes//zS15WPx5OIRTmGCl5laV73hZuw=
X-MC-Unique: EpD4W0BoNQizTdK9xpGtlQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ZHH2YIysjoC9lYoti0unk3dYLgIp670699Xm+aFdSvhlg420GV9T5kv3O+E5RYbyYv86Nt2lJT97Ri0UKcJGA8pUM3nawiYLx8pZtZqTjkSPkivbMHjY/CAyDzXPd7hr6nrUg5UQu08OXsBKrcqeu9BtqtWoB5bt5vkUAJEzooaOyDoLbwNgKSzvyKDpmPZfaX6GtxrTC+71VZWVFUayRTNZ8hEnnGh4v2lDx95N1aadaKSLBTt0YAqiKEUxVrJMJvcJCPgAv8M3oMO3gzZahF38FropV/Lf1uqHxTDSDAksYzMgyfogpy/PD7V+mVtOrKZyRrfM23HMGpxP4DLQLg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Eak0n+eKgYksPTt8z/Zey1HNNYwAIEU4CabgD8aYCic=;
 b=HFgJo4iQCebTrZAUBdLcVHNBnjMbbLI5DgPr3feH7cYbdkfLD80VlJ7i4E0PCVdCXog3ZW8ycz3llchDMroo6tZIKMpEMjBqDbA+B92JkEyvNk65k90H24YKoPZKuxB1M775Tn+fHGUS1W3d71QNwm/B9XdHyHgf1a/1qDMapO2Kzq6aBVL2gZxlR1x79EqnzUS2z9u9VYgbBce/3NK+M8ZRvh8ZEQXzfSBbatLtV6+91SDH0IgaaFEJcqtxoLgDgDKkdhj+16FptHx4RUxbkpvqww0g5L1/vcG1EWGhbVJIdJGB4Bv1zhXVewAoInmvavoO54bBwi+h0VG87VB3RQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <61d85343-9a37-6409-449d-a662ae5258c5@suse.com>
Date: Mon, 7 Feb 2022 18:06:10 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v6 06/13] vpci/header: implement guest BAR register
 handlers
Content-Language: en-US
To: Oleksandr Andrushchenko <andr2000@gmail.com>
Cc: julien@xen.org, sstabellini@kernel.org, oleksandr_tyshchenko@epam.com,
 volodymyr_babchuk@epam.com, artem_mygaiev@epam.com, roger.pau@citrix.com,
 andrew.cooper3@citrix.com, george.dunlap@citrix.com, paul@xen.org,
 bertrand.marquis@arm.com, rahul.singh@arm.com,
 Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>,
 xen-devel@lists.xenproject.org
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-7-andr2000@gmail.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220204063459.680961-7-andr2000@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR3P281CA0001.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:1d::10) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4c9bce83-bf17-41aa-f6ec-08d9ea5c2535
X-MS-TrafficTypeDiagnostic: HE1PR04MB3307:EE_
X-Microsoft-Antispam-PRVS:
	<HE1PR04MB3307ABE811EE3EDCC1FDC27EB32C9@HE1PR04MB3307.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Dys1/aG/08dxPhKi4zUiVX0/JLdQnW8MA6OBaSxdjZpRjfnl+ncp+3cug+iRxkmNyWzBbvsg7IWajU1ega6yf8aNHZ1PYjiypYOW+n3fNUJfN0yLrhPgfgOfRsJA47ZP9XAJCNW50RStc2boBGMI1LRDkBfBHEvRlIhqMdbtEJmZxRsgpMkS0aWU8zaueJdk/xew23LN+nV+C4BhfaEp/X3092hAVylWOwfSfvzDdfPTNgUxZWkkdGfdaQ8A0rLIeRBWEKpuVAztGVu4mnUApkSbHBmI3IQhR/Krtlx58KMQbL6wBtInSfCGVfuql10m6XxvScBBn4233vJvlmUC8omxr8CpS18RvW2w4M9cJS34T88vDrSN0CsJcCtZBooM3qbYoojRhwJSCju4JTJP2lWuqxbOyloGTnD1TRoelLkUSNcCXWDCOD8vDi8QGvFTfXM9rC5nfmpr9s7gB/FZx0D3DyO2y8niwDS/hrKXssmXs2/tu7Ht0Gx45X3lxZdjWxCzl4pMujmoBGOgVpLEzF/q/L2zenj2AxRNHZOPtD04IMb6v+yiNsGzdkZfkwklDvp7K3SXNxZgG92UGPhBmQjgCuzmcVYWL7Qb1eOYOOs1e70049PYzcF5lcWtmfI5h/scnbuBmWBeCErMCho8wQ+/uhM66UiM6djb9/OYp546BeW0DBSAqZZi+ULxSnPlOe4zwqnnC9SAYXaUlCTGHAFBjhpEmvldXtwy9ehUWu4=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(5660300002)(2616005)(36756003)(7416002)(83380400001)(186003)(2906002)(26005)(508600001)(53546011)(8936002)(316002)(8676002)(4326008)(86362001)(66476007)(6506007)(66946007)(31686004)(6486002)(66556008)(6916009)(38100700002)(6512007)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dHNwd0RzT21PUHhQaS9CdXp4MDg0OWFudWxWZWt5WWxwR3ZHcmg3UUZoTkNl?=
 =?utf-8?B?RDFMVWZhRXJISDh2VkhlcWsyK2FjSzJlNlU4N0FBZUFIWkJvaVoyM1lTM0dD?=
 =?utf-8?B?Y3hpSzk1RURaWlIyTnd4WTFjZGtUTkhxTWN2N3o4aU44M2hyczVLb3o5djhB?=
 =?utf-8?B?RkRoU1VOUHYxekhsRENzL29FWWlNL1ByQWxaazF1dDhsMS9TdDZIeUhHbEg5?=
 =?utf-8?B?enhGVWVkOWVMckVyQWNrZ0lmTW1oQUJTQTRNcWk2Q0I1MUVNV1I2Slh2VWdN?=
 =?utf-8?B?QVM4eU9FWllRdVVEUXFNODViczdXQVZ2MGFkd3RnUkp5SzFRM2xFemhJNXlC?=
 =?utf-8?B?TkxuWS9PRmF3TXd6RHJRSWhBWmdFR1JTTmFXNGpKL3hqMjFMTmd6RHJ0S1p3?=
 =?utf-8?B?OHFsWEQxZUpwMlFxbmVEL0xYU2ZDZnhkTU01ejVIMW04ODgzbFE3UTZ4MzJL?=
 =?utf-8?B?NGd4VFJtNCtOcE95YmJDVytlQzUzaEtyWkhnVUtjTlNMK01XcXlSSHFiaktX?=
 =?utf-8?B?eEJDNlBBREpzdW1vY1JNT2lweEFUUmFtWXBNN3RIYUlEV2ZEakF3UFoza05J?=
 =?utf-8?B?NUNGek1FUkR4M0FQcGpsOGVJc2dRRDRqbWs4UjBLa3NJNEF3VFFYcURiakVa?=
 =?utf-8?B?RzN4dmgyMEI1WHdaYnExaDBMd1BjazUvVkMxejZtMlEwRVg4Wncwc0NZa1pV?=
 =?utf-8?B?Wnlqa240Vktlb05IemtXRFdsczVpSC91RVRjVlM0MFpPVFU5Yks4b1VOUERP?=
 =?utf-8?B?eDZEMWgwaCthRmg5WDljUlJqOENSVEFHaExaZlVZa04xSHdSSVNsQ0pDT1Yw?=
 =?utf-8?B?ODgyTDdUVUlxcy96ejI2TThLZHBONHd0YXdxOVYrZ3I3bzdtKzljc2hyTkxl?=
 =?utf-8?B?MzJRaUZSVUZMZDNUNjFMRFlVZ1pYeks1dmtiY2YwWXhBbndPT1BsV0hESzRn?=
 =?utf-8?B?MTRvSzZmRkUveW51Tk5zcWtmeFlMSk5BNnkwOW5hU243ekVvSlJVVmc0bzRQ?=
 =?utf-8?B?d2FJQkt3M2dQblErZDBYeWNlU0ZmamY2cEpNMzJaaVFCdzM1WlBmbFBnRFZa?=
 =?utf-8?B?ZDRDMHE4M0llbWNnb2V2Ly92cHJ6NVVOTWJyaEFPdWpWYTZNdUZNM1ovMGlw?=
 =?utf-8?B?N29EWWN2dmhvSGY5NVR6dDhON1BSMU9FbCszL0s5WTBMbVZxeFVQZ1QvbVFH?=
 =?utf-8?B?Z0xWSll1WjRLTGM1ZFJRTHNGcEViZllGemZmSkdHVVh3Z0R4RS9FUkpPcG1v?=
 =?utf-8?B?UGxodFRRaksra1ViMVVzRUVHRXBCMUIzQXN4dlFJNW1IOFB0bmM4UU1ST0Rk?=
 =?utf-8?B?dXhrSzFjTzk1K24rWCtyUHJUNzFNMUhFdWxPTGdGWjRNZXhxV3FubkNjU0ZS?=
 =?utf-8?B?d2JadUhqSXpJckRnK0wyUlp2Vi9oVUpnQUs3ZzJ5U1F3eWNTTTZaSFNPQTEv?=
 =?utf-8?B?d1F3b1pLU0g3UGd1VmY2YUVuR1ZDN1JjTXdiOS9SbEhPSGNhTW9KeXh3dENE?=
 =?utf-8?B?emxYZFJOdmFGNjRxMGI5cEU1dGxFMFBaQ2s0TlJia3VsY3BUcWpORkpJT1JU?=
 =?utf-8?B?aHd5ZENFZ2RGbnA3SktJYklCVnEwbllNMm1mbGdLMUdnempIaDU2QlpjMlJK?=
 =?utf-8?B?Y0xHSURKNHhDNVliOXdiMmh6TTVteWkzcnJocWk3cWZBaGFQSHhXUGM0SCtO?=
 =?utf-8?B?NkxEVm9PU2dtd2pYNXQrYlA3bjZwVkhUTDYvVFdRenpybEhua05hbzlJUWpE?=
 =?utf-8?B?N21WWDE4YjRoZkxLalFySXBOVGVsTCt1R2RhZmswcTFpQ01PN1FlMjlIZGZN?=
 =?utf-8?B?ME9Sc0x4b240N01xVkJYa3YzWFNtYTc5cXR3SDBCUElrWktSU29wL25qYWwy?=
 =?utf-8?B?WDJlTitTSlJadzhsNnNSU1VnNzh5YWF5SVR2ZklhVnM4YmpySnRiWHpuK0lM?=
 =?utf-8?B?cWtHTzNWOHVWTkEwcTlkSVdwZkViL0RtWUpuOVBNZmVzZDZqbTZFbmlEQTNV?=
 =?utf-8?B?RUNvRGJKcnZmU0U5bkhzNElRZmtuU1FCdXNCU0UwSEtzaFA3eTRjK0pMazZ3?=
 =?utf-8?B?dWRMNThXSWZvRHQ1UkQxcE9NV3BUTGxPd1RmME9tK0w1bkdiS3RGZHh0ckk0?=
 =?utf-8?B?R0hRSHVYNnFRMFF4UHh2aEhBbHVBek1xdUVMYjA4Vmt6QnpabTkzazVNRHBp?=
 =?utf-8?Q?Kq9SVxorEd2W9wbY4QJpHoY=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4c9bce83-bf17-41aa-f6ec-08d9ea5c2535
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2022 17:06:13.4007
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 70bmkCArd6aSNWDGXJOcaSy6IBUheMkiJa3sSqf53MA28NOPZu6SQLAr5emZgI/UW47U0WnsUSbdN3DIkdnLsw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR04MB3307

On 04.02.2022 07:34, Oleksandr Andrushchenko wrote:
> +static uint32_t guest_bar_ignore_read(const struct pci_dev *pdev,
> +                                      unsigned int reg, void *data)
> +{
> +    return 0;
> +}
> +
> +static int bar_ignore_access(const struct pci_dev *pdev, unsigned int reg,
> +                             struct vpci_bar *bar)
> +{
> +    if ( is_hardware_domain(pdev->domain) )
> +        return 0;
> +
> +    return vpci_add_register(pdev->vpci, guest_bar_ignore_read, NULL,
> +                             reg, 4, bar);
> +}

For these two functions: I'm not sure "ignore" is an appropriate
term here. unused_bar_read() and unused_bar() maybe? Or,
considering we already have VPCI_BAR_EMPTY, s/unused/empty/ ? I'm
also not sure we really need the is_hardware_domain() check here:
Returning 0 for Dom0 is going to be fine as well; there's no need
to fetch the value from actual hardware. The one exception might
be for devices with buggy BAR behavior ...

> @@ -516,6 +594,11 @@ static int init_bars(struct pci_dev *pdev)
>          if ( (val & PCI_BASE_ADDRESS_SPACE) == PCI_BASE_ADDRESS_SPACE_IO )
>          {
>              bars[i].type = VPCI_BAR_IO;
> +
> +            rc = bar_ignore_access(pdev, reg, &bars[i]);
> +            if ( rc )
> +                return rc;

Elsewhere the command register is restored on error paths.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 07 17:06:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 17:06:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267288.461023 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH7TW-00012U-9Y; Mon, 07 Feb 2022 17:06:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267288.461023; Mon, 07 Feb 2022 17:06:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH7TW-00011i-6D; Mon, 07 Feb 2022 17:06:50 +0000
Received: by outflank-mailman (input) for mailman id 267288;
 Mon, 07 Feb 2022 17:06:48 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=kaUt=SW=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nH7TU-0000bz-CD
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 17:06:48 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 541cda71-8838-11ec-8f75-fffcc8bd4f1a;
 Mon, 07 Feb 2022 18:06:47 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 541cda71-8838-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644253607;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=uvVhDJQWqMKWPbwaT60cpH0Ssdw9h6aA84VtREa7C+o=;
  b=hqRgKltqNm//mmtHkuerSJwsaXso9LAd7R7ZwTnR5P10ndEAHco65a9R
   LdsgWNgUEZWOEwlSgDLxaD3nGqBO9NwFFMxWeC+5dx8uT8t60Ky2eIhs9
   HzOkYu2zRjt4Z8t0dh351bRl+V2UhrI0dMb+QNiDcDBVaZxQPLGeYYGVn
   4=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: FZYgv2BIVj0YSGpZ88KL4Jgc+PHDz7HrGESVVev2sq8orw9uI3TQgSFSa8bG0CVgqytTg+gCiM
 HMQsHZp/UQsOPM+PWGEcYaEfOmxOIiqhoADJMumsR8izaKlKsUetkkvOzUx6rPKwMSc0sNGnvR
 ShTorvbw4NP2rRZjVOkdLlaYR0ExK/c7xi/oJ991kFIOacGSHp1mV2MIyldvay4wzdOhppeMqB
 VPf7u8wu5uCXmJ2Vm/sg4kqR8P2/Ki9o7bov+59K4Bk+S0RZNjcVsrfFx5MK217ESLviPjekeH
 3GdFfY9SAXzXaMqRT15cZSMl
X-SBRS: 5.1
X-MesageID: 64069245
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:w5UhUqP5m7ZliTLvrR3rkcFynXyQoLVcMsEvi/4bfWQNrUoghGYPy
 mtKDGuBOqmCNGDxe4pxat7n8UoOsZaAx4Q2HQto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6UUsxNbVU8En1500o8w7RRbrNA2rBVPSvc4
 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq
 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYoziojtxel
 JYOjLabVSsHB63yx9otTyANRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs
 6VFdnZdNXhvhMrvqF6/YsBqit4uM4/AO4QHt2s75TrYEewnUdbIRKCiCdpwgmto2JEUQau2i
 8wxd2dqSCXRQyF2HmgYOLRnzOK1xVOkfGgNwL6SjfVuuDWCpOBr65DTN97Sds2PVN9itE+Sr
 WLb/Ez0GhgfcteYzFKt8G+oh+LJtTP2XsQVDrLQ3u5nhhify3IeDDUSVECnur+ph0imQdVdJ
 kcIvC00osAa/kGxUsP0WRH+pXeepwMdQPJZCeh84waIooLL5y6JC25CSSROAPQkvsIrQT0h1
 neSgsjkQzdotdW9UmmB/72ZqTezPyk9LmIYYyIACwwf7LHLoo4piQnUZs1+C6PzhdrwcQwc2
 BjT8nJ43e9Ky5dWiePrpjgrng5AuLDEbx85yVmUHVuPxR9VSrelWdOW2UTiuKMowJmicnGNu
 30Nms675e8IDI2QmCHlfNjhDI1F9N7ebmSC3AcH840Jsm30piX9Jdw4DCRWeR8xWvvobwMFd
 6M6Vel5wJZIdEWnYqZsC25aI5R7lPOwfTgJux29UzavXnSTXFLdlM2NTRTJt4wIrKTLuftuU
 ap3ie72UR4n5V1PlVJavds1374x3TwZzmjOX539xBnP+ePAOCLMGO5cbgrUN7tRAEa4TOL9q
 Yc3Cid3408HDL2Wjtf/reb/0mzm3VBkXMur+qS7h8aIIxZ8GXFJNhMi6ehJRmCRpIwMzr2g1
 ijkAidwkQOj7VWaeVTiQi0yM9vHAMcgxVplZnZEFQjzhBAejXOHsf53m20fJuJ8qoSODJdcE
 pE4Ril3Kq4TE2ScpWVBMsWVQU4LXE3DuD9i9hGNOVAXV5VhWxbI6pnjeA7u/zMJFS25qY01p
 LjI6+8RacZrq91KAJmEZfSx4Um2uHRByut+U1GReotYeVn28ZgsICv016dlL8YJIBTF5z2by
 wfJXktI+biT+9c4oIvTmKSJj4a1CO8iTEBUKHbWsOStPi7A82v9nYIZCLSUfSrQXX/f8bm5Y
 bkH1On1NfAKxQ4Ys4d1H7tx47g54t/j++1Twgh+RS2ZZFW3ELJwZHKB2JAX5KFKw7ZYvyqwW
 16OpYYGaenYZpu9HQdIdgQ/b+mF2fUFoRXo7Kw4cBfg+St63LubSkEObROCvzNQceluO4Q/z
 OZ/5MNPs16jigAnO8qthzxP8zjeNWQJVqgqu81IAILvjQZ3mFhObYaFV33z6ZCLLd5NLlMrM
 nmfg6+b3+ZQwU/LcnwSE3nR3LUC2cRS6U4SlFJSdU6Untflh+Ms2EwD+Ds6eQ1Z0xFb3r8hI
 WNsLUB0ef2D8joAaBKvhIxw99Wt3CGkx3E=
IronPort-HdrOrdr: A9a23:mwhwX6tUUY71ffoZPXv9h6g67skC0oMji2hC6mlwRA09TyXGra
 +TdaUguSMc1gx9ZJh5o6H8BEGBKUmskKKceeEqTPmftXrdyReVxeZZnMrfKlzbamLDH4tmu5
 uIHJIOceEYYWIK7voSpTPIaerIo+P3sJxA592ut0uFJDsCA8oLjmdE40SgYzZLrWF9dMAE/f
 Gnl656Tk+bCBIqh7OAdx44tob41r/2vaOjRSRDKw8s6QGIgz/twqX9CQKk0hAXVC4K6as+8E
 De+jaJpZmLgrWe8FvxxmXT55NZlJ/K0d1YHvGBjcATN3HFlhuoXoJ8QLeP1QpF4t1HqWxa1e
 UkkS1QePib2EmhOF1dZiGdgjUI5Qxer0MKD2Xo2UcL7/aJHw7SQPAx+r6xOiGplXbI+usMjZ
 6jlljpx6a+R3n77VXAzsmNWBdwmkWup30+1eYVknxESIMbLKRctIoF4SpuYd099Q/Bmcga+d
 NVfYrhDTdtACenRmGcunMqzM2nX3w1EBvDSk8eutaN2zwTmHxi1UMXyMEWg39FrfsGOtV5zv
 WBNr4tmKBFT8cQY644DOAdQdGvAmiIRR7XKmqdLVnuCalCMXPQrJz85qkz+YiRCdE15Yp3nI
 6EXEJTtGY0dU6rAcqS3IdT+hSIW2m5VSSF8LAW23G4gMyLeFPGC1zwdLkeqbrWnxxEOLypZx
 +aAuMiP8Pe
X-IronPort-AV: E=Sophos;i="5.88,350,1635220800"; 
   d="scan'208";a="64069245"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=atl5Os6GcVO+jz4RNiwKeClZmShtlNLzJyhV2npDcHfP8aoIeF0tQR2O0+2g5yCsM8tiVA0ou2d+9rynsWmIBGtjF0XgCb2ZN0UW9IrM5p/39PoQwZKEezqsosVg9QI6z25lJwERoLBibI3zV5t9smItTTGAG8ptLTYa0+3jCFQAMXCfoT1J5aSs/8SPppVztMHCMErZty/PemqA8OAWIyUDvq0X+xNJ9n7HPZs9T9KZaLXXtEZnQRu7QOE/aO9+FET+T4ht4Y+qeWDlLSj3brBOUT2ncWeJDNsOrnVRB4L+GstJkBi8Mh7Xaut5u4qkJSV9rJmMCeMyl1q58COdDQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=uvVhDJQWqMKWPbwaT60cpH0Ssdw9h6aA84VtREa7C+o=;
 b=NVzjI5vev8wq1rJt7jZsnuaT7rK3sRXD24KlnZlI0bn/5FINj48D2+PNO1wG2BbIAgenfLzWmUoLwMG6gZYb7X4uSQkZDm+yNH3fEbHsRxaOd7j9v/tRH6lSENtNJemzPZHfAHivJa9xvTJWundkv43PVVb9j+8/QVsNLTNGc8F+PtUYZvBGCZIJbVmWZZdFgpGUB61VI5gsadEBpB56rAKoCRNKhShFd8+MEfP4gW2D/0wuQmIypkLggKXjRvptME3BGD31GKxqiinDJ/4w03Frro8fxsfoDOukp/0mYQm7WK7R8GtMOOFjI9rVwON6Bzk9nTT6a/7uy4+T2mi3sg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=uvVhDJQWqMKWPbwaT60cpH0Ssdw9h6aA84VtREa7C+o=;
 b=TcJzzFDIkgvMULhTBL0fEIRcqPScSrxLJl06xr0RpNHlpLiDLsEaiEvIh0Rhm4iXGFFAcalkP1FpdFzCqALSDywMmAM01l4qXZ8xT8EmLosTRRDQl3IZywEUzSzKMEessTQFKSgGAQOuK3UFJ+Lvj7jd50LatldoXVCSG+nTnjQ=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>, "Juergen
 Gross" <jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>,
	"Julien Grall" <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>,
	Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] xen/smp: Speed up on_selected_cpus()
Thread-Topic: [PATCH] xen/smp: Speed up on_selected_cpus()
Thread-Index: AQHYGgY/F0hg0t0KmkKX/IIzwuTua6yHwIWAgACVkwA=
Date: Mon, 7 Feb 2022 17:06:41 +0000
Message-ID: <7805e1a3-e80b-91e9-afd3-aa3b1f93afef@citrix.com>
References: <20220204203115.13290-1-andrew.cooper3@citrix.com>
 <613d2033-47ba-1f67-9d90-322caeaef5dc@suse.com>
In-Reply-To: <613d2033-47ba-1f67-9d90-322caeaef5dc@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.1
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 1da02f79-673d-49eb-4471-08d9ea5c3602
x-ms-traffictypediagnostic: BN6PR03MB3236:EE_
x-microsoft-antispam-prvs: <BN6PR03MB32364DEFBE6B3FBBA5AD4EAEBA2C9@BN6PR03MB3236.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8882;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: L1Ws6V+Wf8bTzfPz+P3nPegYWLBRqePHrJXFaErhXkTgMjNch8xBGhWGK/9KteANV4UWl2MYSXiOkhdJrRl/fH5HGeXZsDWqWoDK55Gp/EtIHUCGK1K5+o5TsOSreLjHJhPu55XH1e/yPTxym1ph8xt82NDG9QQHQZnQZZVWcMvMHXQ4tbRooqBOyAiO/6ujXNgdbtRChcKB8qU/9/gEku2GuKfX4uq1i0HA9Z8yOhdJdNZ1UDcxZF6GvQ6o6aXn/k18LJwo2dyf066DlowtguYogcYaTZnP+avCPV9FlIpF0NGg07jrNLcVsDVlZ3MUMOKYyYXU76SU4gFAdo5pdNwxxSerk0LDMYfyUfiLED7xprQV3DDWsrCZh65XBpWB/K+5fHq+eNDpq+06JioArC9rAG9CGgd2ithb47B0cvk5JSgIvxBTmGb/eLWunBWaG8DZ/FFNO0///Cb7cd6v4NYVbCoSB0rJgrlW3e4ILsPnk0vUi2QbgVyXKoyWSH2EkGu5gAASXcRX2mIVFAKPdhwY5WmLizatZEanALJPzkw7kELoCWUMgcqQhNOzMaJD4QfkM492qYkxMAIAfI0Sar9SnKe53ZM3yWv9K94xbKUa4ZA+f+L1HgfMvdtAWBtIsTwl1Xby+cTbKfiZYDOH4+9IY0JkWTeTEoyxfT1QBq+bppzK2FDbe7rg7MLzsP6MW7rTvhZt4ovTsOrwr2qhiUX50n2LOx4fMgDrpafVsXmZk9qw4CVMSKR1boIEoNfKCpiAV75AB36as0MyqCk+eQ==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(316002)(54906003)(508600001)(6916009)(36756003)(38100700002)(6486002)(82960400001)(2906002)(31696002)(66556008)(66476007)(26005)(31686004)(66946007)(83380400001)(38070700005)(5660300002)(91956017)(122000001)(66446008)(8936002)(4326008)(71200400001)(2616005)(8676002)(76116006)(53546011)(64756008)(86362001)(186003)(6506007)(6512007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?clZZQWErcjVPRVlEVWl6YURIYVloeEU3RGgzVmkwbWhjSU11aXpYcXF5a2lj?=
 =?utf-8?B?b2NNVUV6K0lwZGVkc2Vub1pDMHUwTmErU0h1UjJtWkl2YXpLcEpIVllDT0dZ?=
 =?utf-8?B?My9CNitlb3pEdlI1VHVUdkEyVlBkcWtqOUNuRjVPVXZjc2dSWWN0QWFQcGFD?=
 =?utf-8?B?cy9FVm90QkpqWmMwMFZhVTFpSEV2eStheWZWVCtiNEd6aE52SGVrRDZIaThD?=
 =?utf-8?B?Uy8xNVhDZ2ErYXFtVkpCdENaUnF6VXZBSkZMamVheTRRd1lZdlBqWXE1clM0?=
 =?utf-8?B?eUZSYWlRcEQ0WDcrQ29xM296V1ZiUEtwNWV5b1N4aUhOVW9tZ25EUFhGcFRC?=
 =?utf-8?B?NDM0N0V5clZhYXlqeXlJQ0l1eDhDRXlXL0l5S2VVQjlueDVlVE5EY0Mra0FE?=
 =?utf-8?B?ajlHL2pkTUxvdWlZOFRya2JGdVBJUWFBdzRhWE9STjkvWGttcm9QSjJlTU9M?=
 =?utf-8?B?ZlFuWjVTaCtVRm5rVTZaMnNSMkhmT2wwVE5YeHRlcGVuWU8va0NJRmptRHBr?=
 =?utf-8?B?RjBHaklaRHBmZE54eG9rNHdrVHk5d0NLZjdjWjhHTXkrWnV1YjA5d3o3MlZI?=
 =?utf-8?B?TlRCL09vb1FZNEllY3ZndVVkM2NiOXp2UndhRW1wMElwdlY5UUNCSTl4dXQ3?=
 =?utf-8?B?UERjNkpBUndiTllFeCtNcnNLTW1ocEZDSCtsNHdwTkt2S2p2MmMyY2h5VmRz?=
 =?utf-8?B?RnZVTEpESDQwNGdLNUNIazMrc25oK2xzeUJjckxsV1JDbHVyY2J1dGVxUXpH?=
 =?utf-8?B?UlJrMWlSbmVjTjc4MFpMZi9FS05kbUpiTjQxMVJNWklLNFR4ZWtPT2JPTDFa?=
 =?utf-8?B?UzV5TTRKOE9aYlN1OTlHVHFTYjJUMFVjeVhEb0JSS1ZPMDV0V3M4TjVUZEJZ?=
 =?utf-8?B?SkxnM0NJdkxEZHptZW0yV2Y0WU8yajZkeHp3Z2xxM0p1VXJKU1hKRDlhNTVj?=
 =?utf-8?B?TGFGTkg5N3FEazNPQUdoRXJpYk9CQVVQMzdUUTIxSjZWZG1Sb2N6T0Y3Vzdo?=
 =?utf-8?B?a0tQb1F2Zm9xY1JLdGdkcGNPOWh1VUx3dDljN3NxV1IwYnJTaXpvdEQrTGtk?=
 =?utf-8?B?Mk9ndHNnekI1WnlCMVBKdE9tM08ySHNMZzBJcVIvRThFVW1OcElwU0Q2VTR0?=
 =?utf-8?B?SE1JZmJVV0RPSnovNklDR0tFRFArM0MvMEhNRzM1am02Ly80OWpVdHY0MTNo?=
 =?utf-8?B?eUlua0srYUJudVhTc09NZkx6TjJhcXZXMCtTdktCNXhjR2xOM0grMUV3cGo5?=
 =?utf-8?B?dEwrK1FLMXR2cEtZeFJybTk3SENFT1VrSGdOYWhDYjlMc0ZsMGp0S2p6VGZU?=
 =?utf-8?B?MGRIRjZvOVFZYkVnMjY1YnZqOFVUSUtFdjZOM0ExOEdBWVJRU3RuMWRwYy9J?=
 =?utf-8?B?ZFk2RStSVG1XMzZJUzJaOW85UmNudjBIYTVHWTEwREp3RDNTRVN4TzU5enh2?=
 =?utf-8?B?U20vVVZhYjZmUCtVYW45Y0dhb1ByQ3p1dThyT2JLT2I0U1pQRVpIMENOZ2wr?=
 =?utf-8?B?VTdQTVRzaW16dHFjVjI0eVg5V0p3NklqZGdQbjh1Q25MRjQ1WnFjTmlVdU9O?=
 =?utf-8?B?Q2dscEhyWERCcEk0b2o0eE1SZko0dXAyTWV4SHl5WHFNYnl0ZHYya2d3Sk1H?=
 =?utf-8?B?S3hWUy9oUU1ONit2dzdsVFAybm9vTURueS9kckkwbndtMzVmbXp0Nlh6ZTcz?=
 =?utf-8?B?ZmtTYWsvVWFhTlhJQkcveHNoTjRpL25WSUxUZjJEeGFlYUJHbkVJVnBwUHc5?=
 =?utf-8?B?WVM4Z3dZYVd1N2FZV0ViazVLT0ZrdHArWFJ6enowOWVTSjEwenNQQlF0cWQv?=
 =?utf-8?B?d0NjQ1VDL1cyWWhZK1RFN0k4ajhSaW0vZ2FldmcraVZPSUMyNmhwZUFOb1Nr?=
 =?utf-8?B?dVVFMjM4NlM2VUw5VUluTjhWbzBUVjA5dzYrUzdEMHp1Ym9OOWJLUTZBdWNP?=
 =?utf-8?B?QVZ2QU5OaVVQeFpWMm5iRFp0aytzcnp4UlhDRFd6NXhDSkNpNnBjWEM2bTRF?=
 =?utf-8?B?L0FDOXVyUDl4SkYyZmpMemFBQWRaV0U1TDBLT3BLaFh3NnA0OWswdU0wTmRn?=
 =?utf-8?B?RWlSeE9GMmd1N3czOFNxRnVCaFF3RUtXZy92ZGIrNkJNOTF2T3o3Nlp6SzJ6?=
 =?utf-8?B?aWFybHEwYXN3eXIzSzJFYmxLT2x6d2lyK01JMzJ4Yy9JeHJnWWxuK3hyV3BU?=
 =?utf-8?B?aFNVbzdhaFBTR0tvS0VjMUxEZThUVkVkSExySmVUcTNjK2RqWGZKSkM5YXM4?=
 =?utf-8?B?b1ZIS1NuYm1INkRWSXRGTVRqVXd3PT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <621FD0B4B6B14A4FB431C530257E60B2@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1da02f79-673d-49eb-4471-08d9ea5c3602
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Feb 2022 17:06:41.2551
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: RVAUVd9HjeePwamqKhj9SBcQCLlb8tubyR8ZatvepDDIbEnnZSGm/gMIykp1kh8TGdsO3n3U12VI+VNVogN8921wubJdXVQ0nX7BENi9cd4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB3236
X-OriginatorOrg: citrix.com

T24gMDcvMDIvMjAyMiAwODoxMSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDA0LjAyLjIwMjIg
MjE6MzEsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBjcHVtYXNrX3dlaWdodCgpIGlzIGEgaG9y
cmlibHkgZXhwZW5zaXZlIHdheSB0byBmaW5kIGlmIG5vIGJpdHMgYXJlIHNldCwgbWFkZQ0KPj4g
d29yc2UgYnkgdGhlIGZhY3QgdGhhdCB0aGUgY2FsY3VsYXRpb24gaXMgcGVyZm9ybWVkIHdpdGgg
dGhlIGdsb2JhbCBjYWxsX2xvY2sNCj4+IGhlbGQuDQo+Pg0KPj4gU3dpdGNoIHRvIHVzaW5nIGNw
dW1hc2tfZW1wdHkoKSBpbnN0ZWFkLCB3aGljaCB3aWxsIHNob3J0IGNpcmN1aXQgYXMgc29vbiBh
cw0KPj4gaXQgZmluZCBhbnkgc2V0IGJpdCBpbiB0aGUgY3B1bWFzay4NCj4+DQo+PiBTaWduZWQt
b2ZmLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPg0KPiBNYXkg
SSBzdWdnZXN0IHRvIGRyb3AgImhvcnJpYmx5Ij8gSG93IGV4cGVuc2l2ZSBvbmUgaXMgY29tcGFy
ZWQgdG8gdGhlIG90aGVyDQo+IGRlcGVuZHMgb24gdGhlIG51bWJlciBvZiBDUFVzIGFjdHVhbGx5
IGVudW1lcmF0ZWQgaW4gdGhlIHN5c3RlbS4NCg0KSW4gYWJzb2x1dGUgdGVybXMgcGVyaGFwcywg
YnV0IHRoZXkgYm90aCBzY2FsZSBhcyBPKG5yX2NwdXMpLsKgIEhhbW1pbmcNCndlaWdodCBoYXMg
YSBmYXIgbGFyZ2VyIGNvbnN0YW50Lg0KDQo+ICAoQW5kIG9mDQo+IGNvdXJzZSBJIHN0aWxsIGhh
dmUgdGhhdCBjb252ZXJzaW9uIHRvIFBPUENOVCBhbHRlcm5hdGl2ZXMgcGF0Y2hpbmcgcGVuZGlu
ZywNCj4gd2hlcmUgUm9nZXIgZGlkIGFzayBmb3Igc29tZSByZS13b3JrIGluIHJlcGx5IHRvIHYy
LCBidXQgd2hlcmUgaXQgaGFzDQo+IHJlbWFpbmVkIHVuY2xlYXIgd2hldGhlciBpbnZlc3Rpbmcg
dGltZSBpbnRvIHRoYXQgd291bGRuJ3QgYmUgaW4gdmVpbiwNCj4gY29uc2lkZXJpbmcgc29tZSBv
ZiB5b3VyIHJlcGxpZXMgb24gdjEuIFRodXMgd291bGQgaGF2ZSBmdXJ0aGVyIHNocnVuayB0aGUN
Cj4gZGlmZmVyZW5jZSwgd2l0aG91dCBtZSBtZWFuaW5nIHRvIHNheSB0aGUgY2hhbmdlIGhlcmUg
aXNuJ3QgYSBnb29kIG9uZS4pDQoNClRoZXJlIGlzIGEgcGVyZmVjdGx5IGNsZWFyIGFuZCBzaW1w
bGUgd2F5IGZvcndhcmQuwqAgSXQncyB0aGUgb25lIHdoaWNoDQpkb2Vzbid0IGZpZ2h0IHRoZSBv
cHRpbWlzZXIgYW5kIGFjdGl2ZWx5IHJlZ3Jlc3MgdGhlIGNvZGUgZ2VuZXJhdGlvbiBpbg0KdGhl
IGNhbGxpbmcgZnVuY3Rpb25zLCBhbmQgYWRkIGFuIHVucmVhc29uYWJsZSBxdWFudGl0eSB0ZWNo
bmljYWwgZGVidA0KaW50byB0aGUgbWFyZ2luYWwgcGF0aHMuDQoNCkkgd2lsbCBhY2sgYSB2ZXJz
aW9uIHdoZXJlIHlvdSdyZSBub3QgYWRkaW5nIGNvbXBsZXhpdHkgZm9yIG5lZ2F0aXZlIGdhaW5z
Lg0KDQp+QW5kcmV3DQo=


From xen-devel-bounces@lists.xenproject.org Mon Feb 07 17:16:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 17:16:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267305.461033 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH7cK-0002jC-6g; Mon, 07 Feb 2022 17:15:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267305.461033; Mon, 07 Feb 2022 17:15:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH7cK-0002j5-3m; Mon, 07 Feb 2022 17:15:56 +0000
Received: by outflank-mailman (input) for mailman id 267305;
 Mon, 07 Feb 2022 17:15:54 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nH7cI-0002iz-LH
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 17:15:54 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nH7cH-0008P7-Uy; Mon, 07 Feb 2022 17:15:53 +0000
Received: from 54-240-197-226.amazon.com ([54.240.197.226] helo=[10.85.34.134])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nH7cH-0003VD-O5; Mon, 07 Feb 2022 17:15:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=9AklaNXkc/eUFtckciNNpWEwowtxTE53TdJJ8omKKpk=; b=mNPJMjNXabSK9whZNl1tFOMvky
	AA5BLcaBK6y0JplqBert/gz25WuFUR5QE15UGdbnqI3fzI3ib8KlmhSCtfqPZdr+Jqq6AkCfIZ916
	w1FEWwdz1YoKuGD/KQlfeMz09Kgzl9HCMiUQSx/Ns/T0hBzWmrTG15OqORP+LbK6ZaKc=;
Message-ID: <a54213c4-1c68-694e-c130-d95faeef3953@xen.org>
Date: Mon, 7 Feb 2022 17:15:50 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.1
Subject: Re: [PATCH V5] xen/gnttab: Store frame GFN in struct page_info on Arm
To: Oleksandr Tyshchenko <olekstysh@gmail.com>, xen-devel@lists.xenproject.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Bob Eshleman <bobbyeshleman@gmail.com>,
 Alistair Francis <alistair.francis@wdc.com>,
 Connor Davis <connojdavis@gmail.com>
References: <1641424268-12968-1-git-send-email-olekstysh@gmail.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <1641424268-12968-1-git-send-email-olekstysh@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Oleksandr,

On 05/01/2022 23:11, Oleksandr Tyshchenko wrote:
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> 
> Rework Arm implementation to store grant table frame GFN
> in struct page_info directly instead of keeping it in
> standalone status/shared arrays. This patch is based on
> the assumption that grant table page is the xenheap page.

I would write "grant table pages are xenheap pages" or "a grant table 
page is a xenheap page".

[...]

> diff --git a/xen/arch/arm/include/asm/grant_table.h b/xen/arch/arm/include/asm/grant_table.h
> index d31a4d6..d6fda31 100644
> --- a/xen/arch/arm/include/asm/grant_table.h
> +++ b/xen/arch/arm/include/asm/grant_table.h
> @@ -11,11 +11,6 @@
>   #define INITIAL_NR_GRANT_FRAMES 1U
>   #define GNTTAB_MAX_VERSION 1
>   
> -struct grant_table_arch {
> -    gfn_t *shared_gfn;
> -    gfn_t *status_gfn;
> -};
> -
>   static inline void gnttab_clear_flags(struct domain *d,
>                                         unsigned int mask, uint16_t *addr)
>   {
> @@ -46,41 +41,12 @@ int replace_grant_host_mapping(unsigned long gpaddr, mfn_t mfn,
>   #define gnttab_dom0_frames()                                             \
>       min_t(unsigned int, opt_max_grant_frames, PFN_DOWN(_etext - _stext))
>   
> -#define gnttab_init_arch(gt)                                             \
> -({                                                                       \
> -    unsigned int ngf_ = (gt)->max_grant_frames;                          \
> -    unsigned int nsf_ = grant_to_status_frames(ngf_);                    \
> -                                                                         \
> -    (gt)->arch.shared_gfn = xmalloc_array(gfn_t, ngf_);                  \
> -    (gt)->arch.status_gfn = xmalloc_array(gfn_t, nsf_);                  \
> -    if ( (gt)->arch.shared_gfn && (gt)->arch.status_gfn )                \
> -    {                                                                    \
> -        while ( ngf_-- )                                                 \
> -            (gt)->arch.shared_gfn[ngf_] = INVALID_GFN;                   \
> -        while ( nsf_-- )                                                 \
> -            (gt)->arch.status_gfn[nsf_] = INVALID_GFN;                   \
> -    }                                                                    \
> -    else                                                                 \
> -        gnttab_destroy_arch(gt);                                         \
> -    (gt)->arch.shared_gfn ? 0 : -ENOMEM;                                 \
> -})
> -
> -#define gnttab_destroy_arch(gt)                                          \
> -    do {                                                                 \
> -        XFREE((gt)->arch.shared_gfn);                                    \
> -        XFREE((gt)->arch.status_gfn);                                    \
> -    } while ( 0 )
> -
>   #define gnttab_set_frame_gfn(gt, st, idx, gfn, mfn)                      \
>       ({                                                                   \
> -        int rc_ = 0;                                                     \
>           gfn_t ogfn = gnttab_get_frame_gfn(gt, st, idx);                  \
> -        if ( gfn_eq(ogfn, INVALID_GFN) || gfn_eq(ogfn, gfn) ||           \
> -             (rc_ = guest_physmap_remove_page((gt)->domain, ogfn, mfn,   \
> -                                              0)) == 0 )                 \
> -            ((st) ? (gt)->arch.status_gfn                                \
> -                  : (gt)->arch.shared_gfn)[idx] = (gfn);                 \
> -        rc_;                                                             \
> +        (!gfn_eq(ogfn, INVALID_GFN) && !gfn_eq(ogfn, gfn))               \
> +         ? guest_physmap_remove_page((gt)->domain, ogfn, mfn, 0)         \
> +         : 0;                                                            \

Given that we are implementing something similar to an M2P, I was 
expecting the implementation to be pretty much the same as the x86 helper.

Would you be able to outline why it is different?

>       })
>   
>   #define gnttab_get_frame_gfn(gt, st, idx) ({                             \
> @@ -88,11 +54,21 @@ int replace_grant_host_mapping(unsigned long gpaddr, mfn_t mfn,
>           : gnttab_shared_gfn(NULL, gt, idx);                              \
>   })
>   
> -#define gnttab_shared_gfn(d, t, i)                                       \
> -    (((i) >= nr_grant_frames(t)) ? INVALID_GFN : (t)->arch.shared_gfn[i])
> +#define gnttab_shared_page(t, i) ({                                      \
> +    virt_to_page((t)->shared_raw[i]);                                    \
> +})

This can be simplified to:

#define gnttab_shared_page(t, i) virt_to_page((t)->shared_raw[i])

> +
> +#define gnttab_status_page(t, i) ({                                      \
> +    virt_to_page((t)->status[i]);                                        \
> +})

Same here.

>   
> -#define gnttab_status_gfn(d, t, i)                                       \
> -    (((i) >= nr_status_frames(t)) ? INVALID_GFN : (t)->arch.status_gfn[i])
> +#define gnttab_shared_gfn(d, t, i) ({                                    \
> +    page_get_xenheap_gfn(gnttab_shared_page(t, i));                      \
> +})

Same here

> +
> +#define gnttab_status_gfn(d, t, i) ({                                    \
> +    page_get_xenheap_gfn(gnttab_status_page(t, i));                      \
> +})

Same here.

>   
>   #define gnttab_need_iommu_mapping(d)                    \
>       (is_domain_direct_mapped(d) && is_iommu_enabled(d))
> diff --git a/xen/arch/arm/include/asm/mm.h b/xen/arch/arm/include/asm/mm.h
> index 424aaf2..b99044c 100644
> --- a/xen/arch/arm/include/asm/mm.h
> +++ b/xen/arch/arm/include/asm/mm.h
> @@ -98,9 +98,22 @@ struct page_info
>   #define PGT_writable_page PG_mask(1, 1)  /* has writable mappings?         */
>   #define PGT_type_mask     PG_mask(1, 1)  /* Bits 31 or 63.                 */
>   
> - /* Count of uses of this frame as its current type. */
> -#define PGT_count_width   PG_shift(2)
> -#define PGT_count_mask    ((1UL<<PGT_count_width)-1)
> + /* 2-bit count of uses of this frame as its current type. */
> +#define PGT_count_mask    PG_mask(3, 3)
> +
> +/*
> + * Stored in bits [28:0] or [60:0] GFN if page is xenheap page.

This comment would be easier to understand if you add resp. (arm32) and 
(arm64) after each range.

> + */
> +#define PGT_gfn_width     PG_shift(3)
> +#define PGT_gfn_mask      ((1UL<<PGT_gfn_width)-1)
> +
> +#define PGT_INVALID_XENHEAP_GFN   _gfn(PGT_gfn_mask)
> +
> +/*
> + * An arch-specific initialization pattern is needed for the type_info field
> + * as it's GFN portion can contain the valid GFN if page is xenheap page.
> + */
> +#define PGT_TYPE_INFO_INIT_PATTERN   gfn_x(PGT_INVALID_XENHEAP_GFN)
>   
>    /* Cleared when the owning guest 'frees' this page. */
>   #define _PGC_allocated    PG_shift(1)
> @@ -358,6 +371,25 @@ void clear_and_clean_page(struct page_info *page);
>   
>   unsigned int arch_get_dma_bitsize(void);
>   
> +static inline gfn_t page_get_xenheap_gfn(const struct page_info *p)
> +{
> +    gfn_t gfn_ = _gfn(p->u.inuse.type_info & PGT_gfn_mask);
> +
> +    ASSERT(is_xen_heap_page(p));
> +
> +    return gfn_eq(gfn_, PGT_INVALID_XENHEAP_GFN) ? INVALID_GFN : gfn_;
> +}
> +
> +static inline void page_set_xenheap_gfn(struct page_info *p, gfn_t gfn)
> +{
> +    gfn_t gfn_ = gfn_eq(gfn, INVALID_GFN) ? PGT_INVALID_XENHEAP_GFN : gfn;
> +
> +    ASSERT(is_xen_heap_page(p));
> +
> +    p->u.inuse.type_info &= ~PGT_gfn_mask;
> +    p->u.inuse.type_info |= gfn_x(gfn_);
> +}

This is not going to be atomic. So can you outline which locking 
mechanism should be used to protect access (set/get) to the GFN?

I will do another review of the patch once I know what we locking should 
protect the accesses.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Feb 07 17:30:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 17:30:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267314.461045 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH7qY-000508-Gs; Mon, 07 Feb 2022 17:30:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267314.461045; Mon, 07 Feb 2022 17:30:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH7qY-000501-Dr; Mon, 07 Feb 2022 17:30:38 +0000
Received: by outflank-mailman (input) for mailman id 267314;
 Mon, 07 Feb 2022 17:30:36 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=kaUt=SW=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nH7qW-0004zv-L5
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 17:30:36 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a6740094-883b-11ec-8eb8-a37418f5ba1a;
 Mon, 07 Feb 2022 18:30:33 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a6740094-883b-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644255034;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=V4d6ybWiEa/Ld6eapg8aG+8Qyid761iXYUAw8ZLMYZA=;
  b=gq4wLSYjuOsCHSgS0WhhW3ZB6X2bCb+OUdGfnqGurvegZZcysE25XF+c
   Zaw+KQfJ4uNG0FppOY7hrfOVX0zCkHeE1oJrfiCoIFH4JSV0q9ptXRZGX
   ADf+WT5njFBEvABNIS1uqe32HIMKM3UrMv2+umVfKe7SA2CL4Os+UwI2L
   E=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: lwO0WcjaoKWZYHY8QbRIfeKjU8AuTdv5My/GvARdrlu0edbXU3/gOpuFUir5dvgL3hRGAr1jqo
 QYlrCMXFqcO1JVhrszjP0/XCOOeXLAhk2IjOlnUBKw9iSL6xtlVD0YZw4+sOTrkW6YUfZAWxjF
 kP4gg9aw/F00RNhBzaZ5LCIORO8F6jAecYw1231Rad+5aTaTLz0/Dov2o7gq1cZglkfv8NNBut
 O3a49nupQLEOYhO91lR/g1uvLNeltGq3VrNZPKt9uSwomOe0QQzMIp6AtteObXoTRRYL/lWEHQ
 TSTuhhDTATbE5vM5zT3huw71
X-SBRS: 5.1
X-MesageID: 63123714
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:FjCL6atb3Tqvu4F5iY28wvzKZOfnVBhYMUV32f8akzHdYApBsoF/q
 tZmKTqGPqnZZGuhLdAnOty28RxXvpLcz4MyQQFl+3wyFisT+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZQP0VOZigHtIQMsadUsxKbVIiGHdJZS5LwbZj2NYy2YfhWWthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 Nplvruecg04BqD1g+VaUx8DSwx7O6pN0eqSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DFYUToHx/ixreCu4rW8vrSKTW/95Imjw3g6iiGN6AP
 JNDMmU2MHwsZTVGBFpKKokxrt2ipUKvcBFIi3KJtYQOtj27IAtZj+G2bYu9lsaxbd5Ogk+Sq
 2bC/mL4KhIXLtqSzXyC6H3Eru3AhyTgQ6oJCaa1sPVthTW7zGEJFAcfU1f9pPCjk1O/QPpWM
 UlS8S0rxYAM80isQsj4TgePineOtR4BWPJdC+Q/rgqKz8L88wufQ2QJUDNFQNgnr9MtAywn0
 EeTmNHkDiApt6eaIVqf67OVoDWaKSUTa2gYakcsUg8t89Tl5oYpgXrnbPxuDaq0hd3dAizrz
 naBqy1WulkIpZdVjePhpwmB2m/y4MiSJuIo2unJdmmCwDhzdbaoXpeprljdtq5tKYCeRXDU6
 RDohPOixOwJCJiMkgmET+MMAKyl6p65DdHMvbJ8N8J/rmrwohZPaagVuWgjfxkxbq7obBe0O
 Be7hO9H2HNE0JJGh4dTapn5NcklxLOI+T/NBqGNNYomjnScmWa6EMBSiay4gjqFfKsEy/hX1
 XKnnSGEVydyNEif5GDqL9rxKJdyrszE+UvdRIrg0zOs2qeEaXieRN8taQXSMrlotfra8V+Mq
 L6z0vdmLD0FAYXDjtT/q9ZPfTjm01BnbXwJlyCnXrHaeVc3cI3QI/TQ3akga+RYc1d9zY/1E
 oWGchYAkjLX3CSfQS3TMywLQO6/DP5X8CNgVQRxbAnA8yZ4O+6HsvxAH6bbiJF6rYSPO9YvF
 KJbEyhBa9wSIgn6F8M1N8Wk/Nc8JUj02Wpj/UONOVACQnKpfCSQkvfMdQrz7igeSC2xsMo1u
 bq70Q3HB5EEQmxf4Az+NppDFnu94ioQnvxcRUzNLoUBcUng6tEyeSfwkuU2M4cHLhCanmmW0
 AOfABE5o+jRotBqrImV1P7c94r5QfFjGkd6HnXA6erkPyft4Wf+k5RLV/yFfG6BWTqsqrmif
 +hc09r1LOYDwARRq4N5HrsylfA+6tLjqqV01ANhGHmXPV2nBqk5eiuN3NVVt70Lzbhc4FPkV
 kWK89hcGLOIJMK6TwJBeFt7NryOjKhGlCPT4PI5JFTByBV2pLfXA19POxSsiTBGKOcnOo0S3
 up86tUd7Bayi0R2P4/e3DxU7WmFMlcJT74j6sMBGIbuhwcmlgNCbJjbBnOk6Z2DcYwRYEwjI
 zvSj6venbVMgEHFdiNrR3TK2ONcg7UIuQxLkwBedwjYxIKdi69lxgBV/BQ2Uh9Rn0dO3O9EM
 2R2M1F4ePeV9DByickfB22hFmmt3vFCFpAdH7fRqFDkcg==
IronPort-HdrOrdr: A9a23:JfTnu6j/9966+237TjybFOSpTHBQXt4ji2hC6mlwRA09TyX+rb
 HIoB17726RtN91YhodcL+7VJVoLUmyyXcX2+ks1NWZMjUO0VHAROsO0WKI+VzdMhy72ulB1b
 pxN4hSYeeAaGSSVPyKgzVQxexQouW6zA==
X-IronPort-AV: E=Sophos;i="5.88,350,1635220800"; 
   d="scan'208";a="63123714"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=hfhrg1CYK/YY2MRKEGQqRtyj9fomHsB2X5cZMHdwBarl5T9vU5Q2CPGaug4lJ/xLRyvVTo+/Umbx9PCz+LB/TiCtDOxwh7AB/5rDFInoTWwwFYEssG5vHPhV6r9uahztjiBvMBkSY8+uTrYa56rjyitvmxOjyygtRmhb3ryL5ajoxF6fuv2XDv++UaGS11DlAj8sM2U4UD9YkOqIWovNsHInL5cWe8JEv4hdzp10ikZY8IpuDrDa4oUfqlrM4BlKxY0WXWKWdl/KPG9nThJqoDoKnAA5MkBN1vDiGuWHCZ3bLECRVXI5LShQNYK2pRdBWLKKNQOHYi5UuyTzcheMjw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=V4d6ybWiEa/Ld6eapg8aG+8Qyid761iXYUAw8ZLMYZA=;
 b=UGvHqpvp1rbGMZDZFMESiAyqMIES7NBzmAb7E799UzX/zj0ZZmPgjMSSOxUPERuwoqtGgPSerxF7fQVjkEnopzJo/mAk2fCdMfMTedhSQhFpxXgu5lg+ncuZLKrw/GlFGWfTIyn8YNl61Xt8zU3B16gVO4e6lnhppMoxwgL5pscdtPuX8xGQgezXZsFWaBI1Q+x3tgcSEQAPrQBJItRzeoHYdSAgymYWJZzk5u2xQzyBWDcwfqXqAz7UeE34qz1p0RXipzs2N5HzmUkAOe9cB58/YypWhuxK1+WCH+kmDGpAlNMxZs9ub/06WBy0w1VQo+X15qQAcbzwqODB9odepA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=V4d6ybWiEa/Ld6eapg8aG+8Qyid761iXYUAw8ZLMYZA=;
 b=NctZVnC1YmUA/f3RgmcNYasdrfawzMfCo8jBJUe5amppQ4U4pyX5yV++ef7NrGogNQEuA0w/tk5R800U2+ria30Ze0ALltz11Iz4wq8XIZjwEVilZqoXw7SZ66AWqrgL11/U75kUdX7BgZpXzAHIl6ismdnXKyIRyp9WqTeuCN0=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Julien Grall <julien@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
CC: Jan Beulich <JBeulich@suse.com>, Roger Pau Monne <roger.pau@citrix.com>,
	Wei Liu <wl@xen.org>, Juergen Gross <jgross@suse.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>
Subject: Re: [PATCH] xen/smp: Speed up on_selected_cpus()
Thread-Topic: [PATCH] xen/smp: Speed up on_selected_cpus()
Thread-Index: AQHYGgY/F0hg0t0KmkKX/IIzwuTua6yG7rMAgAFuCIA=
Date: Mon, 7 Feb 2022 17:30:26 +0000
Message-ID: <456de888-c550-6abb-0949-9908a9b84425@citrix.com>
References: <20220204203115.13290-1-andrew.cooper3@citrix.com>
 <9a67c97c-0c61-ecee-067a-f1bdd0280b8b@xen.org>
In-Reply-To: <9a67c97c-0c61-ecee-067a-f1bdd0280b8b@xen.org>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.1
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 9ba82d1b-c840-4d89-fbf8-08d9ea5f8745
x-ms-traffictypediagnostic: CY1PR03MB2156:EE_
x-microsoft-antispam-prvs: <CY1PR03MB215672C951F854C760ABB424BA2C9@CY1PR03MB2156.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: DeeCJzDUFdEGC8yrccgbSm/ce0Vbo3c05wfK6xQbl136b8IAeyoKVdDkNvhjcD2WzBTsOT04kKaQoZzTeCXpkvos5D9iTlilFwGDZzyMnJ7yQMn35zKeBiLy7EsrS3JnWp8km/tPwdSP01BXKRCUX6GHKD3ej5XG+54qoAWya9Q+8YYGlYxbBPzG41WmtUjEcG/Bl0pC/MM/Dr7NdS+1u6eWYkdu4kI3nxkNGv6aGNBrCSkBrQYy2dA2yjRG0IawZnEgHqSH7E03BFttX/S8kTFWkSxxUqRHwnRhduZOeILciwo9DC1cyr2OsTq2q0Cuco0fwYZUd+wfyojhO40tflkCazV1CkHChMoyYOw1+ziR/BfQ/sxJh4rRHLQKqNwJDrz/39trKHzPVyq5AIyxb64ulHUZo9pBw9JoW6NOseWN0niDkhsh1Gs6AROO3A+cAgKYrKT0in2Y1hqHqLI/NXpnHuzsCTceCVYEfpWzzIe4BMUiWhQg2t8sC7bgSL9DjH1xUctKnL07mZ7tc+KgOTeHebhnVP7+vVUS2hL54ivsPhku85QOunx5muyaJBUJ9QfIhoPpQfAQmzzBf+hIgav5cAsqh1v63wRLF/XiFbIMkdvqCCRr4zVsG7Wi8IdTPorkOMKWFcfOp+YjGA1PPkFvpV8oTzKzWK9KQgWHNihZM4ONzJ6xrfjC31O7OTQEK162xbYJR8OpvLWQkYgJcB8rOenkAkKQrkr3msxFYEpCKkaTMQWmlmsL5XOGE4ElK8P/f8aNmf+AlM0UDmFkGw==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6486002)(83380400001)(31686004)(508600001)(38100700002)(82960400001)(122000001)(316002)(26005)(91956017)(110136005)(53546011)(66476007)(8936002)(66556008)(66446008)(54906003)(186003)(38070700005)(36756003)(5660300002)(2906002)(2616005)(66946007)(86362001)(6512007)(31696002)(71200400001)(76116006)(4326008)(8676002)(6506007)(64756008)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?RXE1anU3U0hlTjlRdTNFU0JNaEdlRWI2cXBpSFVwM21oN0ptY3FqYzNwZkFy?=
 =?utf-8?B?TE9RSjFxNzc5ays4eHU0cTdOT0wrSit4dFBTbDF6TWMwb0dsWGplaXRaOFI1?=
 =?utf-8?B?ek1ERWF4WFo5bVhUdUZtQ25xcGZLMnZEenk0ZTJXaXdXWUJqUCt1U2N3cFpX?=
 =?utf-8?B?b1lFMWFvdUlQd2FmY1RlcUFkN3ZWbUNrZ2crOXFnVU5hNTVFMHVkV0RoSzVq?=
 =?utf-8?B?ejIxNUZiaW5FVThpK2grMlhpUXZGWnkrb0QxWG1OQW1uN0FkU1g3TjZKb21S?=
 =?utf-8?B?YnVJL0ZtaVZwV0gvUTRvYVlZUjFNcTFQVU1MTDh3M2I3KzB3T3lNa09XemFr?=
 =?utf-8?B?V3Z4Y3NXZ05nbmNoaWppanpOSm50Y2x0QWhoTmM2M3hkWXNvaXlaSFVjUy8z?=
 =?utf-8?B?bHVGc05UU3J4RXF6VEZLSjBVa3dHQ1Q1QWNucXlyZncwWGorU3RVNHlFdmR0?=
 =?utf-8?B?SW9rTHIwbnB1YU9TdFdNNExyY3Q2RjdUQ3BlWHJHZ2pMQmgzMVlDTTFGYmZV?=
 =?utf-8?B?U1EveGwxbktXenA2N0R0eUJadlN0czhRY21jeHJwVUlWSWc2bHZwcVlETHBJ?=
 =?utf-8?B?NWhDOVRTbVpKS0FxNlBVcXJRN0tGOFpsY1hSRU1ydkZoTmRKOFdEamtwd1JO?=
 =?utf-8?B?U2l0TlFQRHpEWHgvOHByeC9uZDc1b2RSK2xXUFdueEowQ00wMURtUHNSeWhU?=
 =?utf-8?B?bmRjT0M3SWNlU0xQUlJxOERiaDRYSWhPdFgydGtPbzZQT2xNdVAwSXp5a1RW?=
 =?utf-8?B?R3FoOU5BRkhJSlhQajZVSUJwT1k2WXpXTFRtb1dpWE52STFsVWZKV25BdENi?=
 =?utf-8?B?N2UrckwzWW9kTVFvM2ZDb1MrZFdBeDhaK3BwTlRUeU9hUjBUWFhwLzVTZWto?=
 =?utf-8?B?bjVkMVRTMjEyWXNrdmFxN3JNUWZ6SmFlMkVmaHlSb0llTkNsZmwxd29vUHVt?=
 =?utf-8?B?eVc4azBaRlp1aHhDTGdFbld6WTNaWXJrN1g0RTB2aklPRWtMWS9aam1IOG1k?=
 =?utf-8?B?MlJweVF6SDNOSU5LdVRnVnVodm9RL1VpS0tTVEJCSFFPdWRoa3l4Qm9EWEFP?=
 =?utf-8?B?bGdxcGovVE40TElPVmtnMndUU2txdVFyNDFwN1dpR3NtSk0rTWZBL3ZMcGF5?=
 =?utf-8?B?ekFWM3pkYmE2Z0kyRkFWNnovR2VZeXFxMDlwV2pNTFNkZFZ3QjFXb0hiZnl3?=
 =?utf-8?B?QXBYRzNTOGdzY3c4Y25iazB6M1lKVExTZ3dnc0VIbFRYZjB2NVRNZFA1QVdm?=
 =?utf-8?B?Y2k4aThQenBIYjlCUVZ5L3ozRHZ1TFRCTE5zN2J6OXhkY1lWb0pCeG9LRk9h?=
 =?utf-8?B?STBwb2dVWjVKWCtlTE5KbklTc2xiOHFPTHNaYTdVV0pQNFpsbFpsWnZMc1N6?=
 =?utf-8?B?QXIwZ05nT05QQkxmcG9ac09WTmhNelpqckFxdXhVN2svazY1RWd3dm16ZUxB?=
 =?utf-8?B?RXk0ZUJHMEczN2F0QmNDbmRZSG1MY2FjWGdaVk9taVJpRWt4blNYOUxNZVBQ?=
 =?utf-8?B?OTNVZ0p4a3BxVmlmeVZNTWloKzRuOHVOcU1HVk00VTM3bzgrUlRrM3VzbSts?=
 =?utf-8?B?RjJpY1EwVlg3Yk9GTytGaEl0RzI0RHdiUktiMGk1Zlk0N2FBNFZTU2tJYU5O?=
 =?utf-8?B?bllnMFZlQXpEcTNqSVI0ZkZKczF4U1ZGYUF1RjAxRGI2Y3NzbjdKZXNTTDJ6?=
 =?utf-8?B?Vy9oOE9GYys5c3VUdzJOc3dmSnYxRlRKVEFWRUZveWFEQWdscGp4ZWk2b3dZ?=
 =?utf-8?B?ZXZ5SXJIdWdjeitmRXYyZjYvTXlsekkrT2J6U1ZhRUpUVW5JNmRVTzgvTUZ0?=
 =?utf-8?B?VW1QalUvMnRXNU9HYWhOSjRNeHJTaWhSYW5QeGZ3emowQ1Rra3BtZncvL3Ft?=
 =?utf-8?B?OGduU3VFaW51TnJyVXZNcGtNY3c3c1ZLV21UVGREOWdoMjZRUE8vbkx6aDRY?=
 =?utf-8?B?emh2K3dyU3BKQVBoK3ZvYytUTVp0UFl5YXZNZ0tWeDhqaURFNmYwOXhOM09X?=
 =?utf-8?B?cjNDd29JOHAvZXpUYituL2w0Sy9Zd1dLSWVYYkN4OUgxeENIblRrNzRnVTRM?=
 =?utf-8?B?RkNYUW96QmNFeUc5TzI0U295dVVkT2t1R2prd205a3BVYXhxSGh4TElidTV0?=
 =?utf-8?B?c2E3Y1IzK2JJcFBoV2piTVFhemo0NmQ1MndjYTFzVEtZdjh6OGM4RFJoTmEz?=
 =?utf-8?B?Zk5aZUFmK0szc3d2bDZEQXBPTXZMUHgydW9xVlRXcFpWU3l0WTh5M2VEbkVX?=
 =?utf-8?B?ZTE4dzgwL3N4dWxXeHZWS2MvUHpBPT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <291715F8E02CD744A98269F125804E96@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9ba82d1b-c840-4d89-fbf8-08d9ea5f8745
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Feb 2022 17:30:26.1001
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: bP7pOqtL6vTgceKGCmGtDmvM284lRTjACqIUEuN3//vjvJWbKm2+YSStLZ1xjDHL1GEYumzqPIQpk6zyIqZH8fDXhpVBJGYGwDbepPwluAA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR03MB2156
X-OriginatorOrg: citrix.com

T24gMDYvMDIvMjAyMiAxOTo0MCwgSnVsaWVuIEdyYWxsIHdyb3RlOg0KPiBIaSwNCj4NCj4gT24g
MDQvMDIvMjAyMiAyMDozMSwgQW5kcmV3IENvb3BlciB3cm90ZToNCj4+IGNwdW1hc2tfd2VpZ2h0
KCkgaXMgYSBob3JyaWJseSBleHBlbnNpdmUgd2F5IHRvIGZpbmQgaWYgbm8gYml0cyBhcmUNCj4+
IHNldCwgbWFkZQ0KPj4gd29yc2UgYnkgdGhlIGZhY3QgdGhhdCB0aGUgY2FsY3VsYXRpb24gaXMg
cGVyZm9ybWVkIHdpdGggdGhlIGdsb2JhbA0KPj4gY2FsbF9sb2NrDQo+PiBoZWxkLg0KPg0KPiBJ
IGxvb2tlZCBhdCB0aGUgYXJjaGl2ZSBiZWNhdXNlIEkgd2FzIHdvbmRlcmluZyB3aHkgd2Ugd2Vy
ZSB1c2luZw0KPiBjcHVtYXNrX3dlaWdodCBoZXJlLiBJdCBsb29rcyBsaWtlIHRoaXMgd2FzIGEg
bGVmdC1vdmVyIG9mIHRoZSByZXdvcmsNCj4gaW4gYWMzZmMzNWQ5MTljICJ4ODY6IEZpeCBmbHVz
aF9hcmVhX21hc2soKSBhbmQgb25fc2VsZWN0ZWRfY3B1cygpIHRvDQo+IG5vdCByYWNlIHVwZGF0
ZXMiLg0KDQpUaGF0IGNoYW5nZSBzaHVmZmxlZCB0aGUgY29kZSwgYnV0IGRpZG4ndCBpbnRyb2R1
Y2UgdGhlIHByb2JsZW0uDQoNCkknbSBwcmV0dHkgc3VyZSBpdCB3YXMgNDMzZjE0Njk5ZDQ4IHdo
aWNoIGRyb3BwZWQgdGhlICE9MCB1c2VyIG9mIG5yX2NwdXMuDQoNCg0KVGFsa2luZyBvZiwgdGhl
cmUgaXMgbW9yZSBlZmZpY2llbmN5IHRvIGJlIGdhaW5lZCBieSByZXdvcmtpbmcgdGhlDQpzZWNv
bmQgY3B1bWFza19lbXB0eSgpIGNhbGwgdG8gbm90IHJlc3RhcnQgZnJvbSAwIG9uIGZhaWx1cmUs
IGJlY2F1c2UNCnRoYXQgcmVtb3ZlcyB1c2VsZXNzIHJlYWRzLg0KDQoNCj4NCj4+DQo+PiBTd2l0
Y2ggdG8gdXNpbmcgY3B1bWFza19lbXB0eSgpIGluc3RlYWQsIHdoaWNoIHdpbGwgc2hvcnQgY2ly
Y3VpdCBhcw0KPj4gc29vbiBhcw0KPj4gaXQgZmluZCBhbnkgc2V0IGJpdCBpbiB0aGUgY3B1bWFz
ay4NCj4+DQo+PiBTaWduZWQtb2ZmLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0Bj
aXRyaXguY29tPg0KPg0KPiBSZXZpZXdlZC1ieTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9u
LmNvbT4NCg0KVGhhbmtzLg0KDQp+QW5kcmV3DQo=


From xen-devel-bounces@lists.xenproject.org Mon Feb 07 17:42:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 17:42:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267325.461055 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH81R-0006Z1-Ol; Mon, 07 Feb 2022 17:41:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267325.461055; Mon, 07 Feb 2022 17:41:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH81R-0006Yu-Li; Mon, 07 Feb 2022 17:41:53 +0000
Received: by outflank-mailman (input) for mailman id 267325;
 Mon, 07 Feb 2022 17:41:53 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nH81R-0006Yo-87
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 17:41:53 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nH81L-0000h4-TF; Mon, 07 Feb 2022 17:41:47 +0000
Received: from 54-240-197-226.amazon.com ([54.240.197.226] helo=[10.85.34.134])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nH81L-0006Nh-M9; Mon, 07 Feb 2022 17:41:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=7ut4eDQhFUpXJ39YNWdkNKE95R/eFzuGjwWnxKStmNA=; b=OxP7Y2zDmXz2GjWXhHxDI7tooF
	+STC7ivxfPa92cjRcQCJmScygEyR1fNZ7HeOXR5qeFSM38OvxOep9oOkYCcfl/Zr0By6Yk6aC3t+V
	ahuELoLhzlr12ftx1RwW9dM6UiRYG0xfwKHA0REptXdyjUMwNo9mRpgjmYNarlf/op+I=;
Message-ID: <ef4f77d7-2ad7-998e-c32b-534fdbc64e7f@xen.org>
Date: Mon, 7 Feb 2022 17:41:44 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.1
Subject: Re: [PATCH V5] xen/gnttab: Store frame GFN in struct page_info on Arm
To: Oleksandr <olekstysh@gmail.com>, Jan Beulich <jbeulich@suse.com>
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Bob Eshleman <bobbyeshleman@gmail.com>,
 Alistair Francis <alistair.francis@wdc.com>,
 Connor Davis <connojdavis@gmail.com>, xen-devel@lists.xenproject.org
References: <1641424268-12968-1-git-send-email-olekstysh@gmail.com>
 <a7a905fe-3feb-507a-7ce4-ed7dce78de86@suse.com>
 <aeba1af9-8386-3bca-dfbd-1c9110ae09de@gmail.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <aeba1af9-8386-3bca-dfbd-1c9110ae09de@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

Sorry for the late reply.

On 06/01/2022 16:30, Oleksandr wrote:

So I agree with Jan that the name should be adjusted if it stays where 
it is.

That said, I would actually prefer the adjustment in alloc_heap_pages(). 
It is one less assignment per page and I don't expect any issue with 
setting the bits to INVALID_GFN everywhere in the future on Arm.

Note that you would also need to update acquire_staticmem_pages().

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Feb 07 17:59:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 17:59:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267344.461079 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH8Ig-0008Gj-Ii; Mon, 07 Feb 2022 17:59:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267344.461079; Mon, 07 Feb 2022 17:59:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH8Ig-0008Gc-FA; Mon, 07 Feb 2022 17:59:42 +0000
Received: by outflank-mailman (input) for mailman id 267344;
 Mon, 07 Feb 2022 17:59:41 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nH8If-0008GS-AA
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 17:59:41 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nH8Ia-00010T-Cu; Mon, 07 Feb 2022 17:59:36 +0000
Received: from 54-240-197-226.amazon.com ([54.240.197.226] helo=[10.85.34.134])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nH8Ia-0007y3-6c; Mon, 07 Feb 2022 17:59:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=AavZM4+nCYf+hhVDj31Q3ZFwyC5BD6Mtnm1gpxv4Wd4=; b=c+5v4bKH5tCMvMLeieX0hgMsni
	v6m/C1H0+myKjMMWSmDOibqrtY5qiVpjYiUoQThZuTRUpcRn4QgMRXK1ecrc+jztecG9vd/gRNHp8
	hT8+4GL1j2WjcvUsGp4Nt+OtaLqHIPQyIhjurGB5kA/0zd7jpb2rpSENlZkRL0XNc9W0=;
Message-ID: <da4fc5cc-d80e-b4d6-7c96-0f9eb47a9304@xen.org>
Date: Mon, 7 Feb 2022 17:59:33 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.1
Subject: Re: [PATCH V5] xen/gnttab: Store frame GFN in struct page_info on Arm
To: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>
Cc: Oleksandr <olekstysh@gmail.com>, Jan Beulich <jbeulich@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Bob Eshleman <bobbyeshleman@gmail.com>,
 Alistair Francis <alistair.francis@wdc.com>,
 Connor Davis <connojdavis@gmail.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <1641424268-12968-1-git-send-email-olekstysh@gmail.com>
 <a7a905fe-3feb-507a-7ce4-ed7dce78de86@suse.com>
 <aeba1af9-8386-3bca-dfbd-1c9110ae09de@gmail.com>
 <ef4f77d7-2ad7-998e-c32b-534fdbc64e7f@xen.org>
 <46822a8c-998b-6ebb-5e2a-c9df5f7650e9@epam.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <46822a8c-998b-6ebb-5e2a-c9df5f7650e9@epam.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit



On 07/02/2022 17:58, Oleksandr Tyshchenko wrote:
> 
> On 07.02.22 19:41, Julien Grall wrote:
>> On 06/01/2022 16:30, Oleksandr wrote:
>>
>> So I agree with Jan that the name should be adjusted if it stays where
>> it is.
>>
>> That said, I would actually prefer the adjustment in
>> alloc_heap_pages(). It is one less assignment per page and I don't
>> expect any issue with setting the bits to INVALID_GFN everywhere in
>> the future on Arm.
> 
> 
> Sorry I lost the context. To clarify, are you speaking about what I
> proposed at [1]?

That's correct.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Feb 07 18:09:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 18:09:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267353.461090 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH8SV-0001Oo-HQ; Mon, 07 Feb 2022 18:09:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267353.461090; Mon, 07 Feb 2022 18:09:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH8SV-0001Oh-DL; Mon, 07 Feb 2022 18:09:51 +0000
Received: by outflank-mailman (input) for mailman id 267353;
 Mon, 07 Feb 2022 18:09:49 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=AL18=SW=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nH8ST-0001OZ-Pl
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 18:09:49 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 218376f4-8841-11ec-8eb8-a37418f5ba1a;
 Mon, 07 Feb 2022 19:09:48 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 218376f4-8841-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644257387;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=qkHwRzhltIRkcT9Wbarwt28GgDFnfnuxzN3r2dxedDM=;
  b=D1tvw46KTOX9d4pYxf6Tydp4wWSRdM8W8gF7OZdgIqwMHPq8mTiKBGrF
   HmItmVU8BBjo7z25OB58YNtnx8R/e5qplpmJSUYo/kNM092LhLSBkP62C
   AhQmrdZSHhCmdggSlOFPeArCx/g900jweA3P/+hDu78khFrMrpp3Ds6mI
   M=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: ejr2Jbima21KmU9P6HKhbLrC3Aafop39/0JgiI9JokD7gxiqrFjzP3IYfBjA16r5b8EKJ18gi+
 tKr1XDge/mwpzodF64Qrx7TDFfj2hAVQTG0IwGQGLFjgu9y7S3cGk0XXBzEwhK6uQMgGdQMp8s
 amtI/Gfoxv9M2fdPtqPasX3EjL478PDy6lL17/2bruZTx/aDXa5gtUh1Wq/ly89WxIwfUqs6PD
 oQRqOoPYX19mZnBppOFWmWvJVUV6XkWoDp8Eo/ZssPlDHhpqeJ60w8kGEaq8En0uvieghj4lwR
 1ABDm9uyRBnQn4421+ah3qlk
X-SBRS: 5.1
X-MesageID: 63669087
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:XIWA7qNraNbmpxvvrR1ekMFynXyQoLVcMsEvi/4bfWQNrUolhj1Sn
 TEYXWmCOPyLMGOkeo0jO4+w8RgGvZLdm4c2TQto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6UUsxNbVU8En1500o8w7RRbrNA2rBVPSvc4
 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq
 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYow7TgMlx5
 NxfjL2pRjUxfaf0pccYSDANRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs
 6VFdnZdNXhvhMrvqF6/YuBqmsQkKtitJI4Fs2ts5TrYEewnUdbIRKCiCdpwgmxu2JEWTam2i
 8wxSyRqUyTpIEZ2NFoKKqJvscz42nXtSmgNwL6SjfVuuDWCpOBr65DvOtfIft2BRe1Og12V4
 GnB+gzRAAweNdGZ4SqI9DSrnOCntTjgRIsYGbm89/hrqF6e3GoeDFsRT1TTifu2kEmlQPpEN
 lcZvCEpqMAa5EGtC9XwQRC8iHqFpQIHHcpdFfUg7wOAwbaS5ByWbkAbShZRZdpgs9U5LQHGz
 XfQwYmvX2Y29uTIFzTNrd94sA9eJwAud3AbZQMNXzIk+tbRuMI5ti/sS81KRfvdYsLOJRn8x
 DWDrS4bjroVjNIW26jTwW0rkw5AtbCSEFdru1y/snaNq1ogOdX7P9DABU3zsK4YRLt1WGVtq
 5TtdyK2yOkVRa+AmyWWKAnmNOH4vq3VWNEwbLMGInXAy9hP0yP5FWyzyGsnTKuMDirjUWW4C
 HI/QSsLuPdu0IKCNMebmb6ZBcUw1rTHHt/4TP3SZdcmSsEvKFPerXg3Ox/KhjuFfK0QfUYXY
 8bzTCpRJSxCVfQPIMSeG4/xLoPHNghhnDiOFPgXPjys0KaEZW79dFv2GADmUwzN14vd+F+92
 48Gb6OikkwDOMWjMni/2dNCdjgicClkbbio8JY/XrDYfWJb9JQJVqa5LUUJINc+wcy4V47go
 xmAZ6Ov4ACj3C2cd1TWNSwLhXGGdc8XkE/X9BcEZT6As0XPq671hEvGX5doL7Qh6sJ5yvt4E
 6sMd8maW6wdQTXb4TUNK5L6qdU6JhisgAuPOQujYSQ+IME8F1CYpIe8c1u97jQKAwq2qdA6/
 ++q2DTETMdRXA9lFsvXNq6ilgvjoXgHletudELUOd0PKl70+Y1nJnWp3P86Ks0BMzvZwT6e2
 1rECBsUv7CV8YQ07MPIleaPqILwS7lyGU9THm/667eqNHaFojr/kNEYCOvRJGLTTmL5/qmmd
 N559fCkPa1VhktOvqp9D61vkfA06ezwquII1Q9jBnjKMQimU+syPnmc0MBTnaRR3bsF6xCuU
 0eC99QGa7WEPMTpTAwYKAY/N7nR0PgVnn/Z7OgvIVW87yhypeLVXUJXNhiKqSpcMLoqb991n
 bZ/4JYbu16llx4nEtealSQFpW2DI0sJX7gjqpxHUpTgjRAmyw0abJHRYsMsDEpjtzmY3pEWH
 wKp
IronPort-HdrOrdr: A9a23:C6jL4KBDoZuY0n3lHems55DYdb4zR+YMi2TC1yhKJyC9Vvbo8/
 xG/c5rsCMc5wx9ZJhNo7y90ey7MBThHP1OkOss1NWZPDUO0VHAROoJ0WKh+UyCJ8SXzJ866U
 4KSclD4bPLYmRHsQ==
X-IronPort-AV: E=Sophos;i="5.88,350,1635220800"; 
   d="scan'208";a="63669087"
Date: Mon, 7 Feb 2022 18:09:40 +0000
From: Anthony PERARD <anthony.perard@citrix.com>
To: Juergen Gross <jgross@suse.com>
CC: <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, "Jan
 Beulich" <jbeulich@suse.com>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>
Subject: Re: [PATCH v2 0/5] tools: remove include/xen-external directory
Message-ID: <YgFgZADfaoLNor4T@perard.uk.xensource.com>
References: <20220207064147.9585-1-jgross@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220207064147.9585-1-jgross@suse.com>

On Mon, Feb 07, 2022 at 07:41:42AM +0100, Juergen Gross wrote:
> The tools/include/xen-external directory contains a header file from
> FreeBSD used to generate Xen header files. This series is replacing the
> complete directory by a single header with the same semantics.
> 
> Changes in V2:
> - remove stale comment in patch 1

Just need to fix the build now, otherwise, the series looks fine:
https://gitlab.com/xen-project/patchew/xen/-/pipelines/464803007
^ xentoolcore conversion seems unfinished.

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Mon Feb 07 18:21:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 18:21:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267364.461123 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH8eA-0004FS-7L; Mon, 07 Feb 2022 18:21:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267364.461123; Mon, 07 Feb 2022 18:21:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH8eA-0004FL-3k; Mon, 07 Feb 2022 18:21:54 +0000
Received: by outflank-mailman (input) for mailman id 267364;
 Mon, 07 Feb 2022 18:21:52 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=E+Gq=SW=citrix.com=Jane.Malalane@srs-se1.protection.inumbo.net>)
 id 1nH8e8-0003rG-Ei
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 18:21:52 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d0ddd19b-8842-11ec-8eb8-a37418f5ba1a;
 Mon, 07 Feb 2022 19:21:51 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d0ddd19b-8842-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644258110;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=GkKTcTZiNh1+hb7yPpxCjXnkYET2lQ1dJBUO9p9Q0d4=;
  b=eK5QpiHEv8SLEqnE2qPl4KC0mSqfMYcAcqGMWMEPW0b1EbgsiqkXGLr+
   32njOdVzi0gKz129o3DqVlKrE0GCHCUrFALIDKkRLVhPNnk35LYtvTMLI
   5op+xA+14346U7ceEW0nidYMjMvuD0xUZO3ku8GRsVZ+vsDoNT2skH/9X
   w=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: SBh0kkoPNRTFTZT3XZMTM2U0+puMCbu/KfgIASf2AzexXFRgdVMJTaUGebOjzZVnZl1WtrlecT
 54apB2MRI8OsYcFhyWCIms501NM3CxF/SkyWgpD0yicx3LPai334Rpyd/qpdVJSoZfylG0zeaM
 olz6RPAqku+Ifwxx6Y5m6eKUU3IHhJwWvDD7Z4gAbG2aFg9q82uipiwf+BdloJ+C7lJJar6Oyn
 gvZHNsjP9ZWzeVLVDZiCgVPZWGTsUmCl2TKrDBhD9IhSPhrlLT2nZzwxV/0HpCCSDqV9bBspHK
 g1ZgyWc8kQVwxbRLLB5ptsSr
X-SBRS: 5.1
X-MesageID: 63127623
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:eWMKL6hCas00JmqtA68UjXaTX161BxYKZh0ujC45NGQN5FlHY01je
 htvXWCAPv+KMDSgLYt1aNywo08F6MCAztI1HFRsrn1jRC4b9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oAMKRCQ7InQLlbGILes1htZGEk0GE/NtTo5w7Rj2tQw3oDja++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /1k65+MWysDGpTXu+4kX0h3L31SJa1JreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHJNYUS/FRpyTjdBPAraZvCX7/L9ZlT2zJYasVmQ62HP
 ZVHM2EHgBLoT0EIBV5QUKgFwKSXnyLHShparn6euv9ii4TU5FMoi+W8WDbPQfS0QsFSkledt
 3jx1W3zCREHN/SS0TOAtHmrg4fnhjjnUYgfELm58P9Cg1CJwGEXThoMWjOTq/SjllS3Xd4ZL
 kUO4zcvtoA77kntRd74NzW7rWCFuFgAWtNWO+w89AyJjKHT5m6xBHUCCDhIa9Uktco/bT0sy
 lKN2djuAFRHsrKPTmmG3qyJtj70Mi8QRUcSaClBQQYb7t3LpIAokgmJXttlCLSyjND+BXf32
 T/ihCo0iqgXjMUL/76m5l2BiDWpzrDLUwo06wP/Tm+jqARja+aNeIiA+VXdq/FaI+6kokKp5
 SZe3ZLEtaZXUM/LxHflrPgx8K+BzqiGDC/wq3pWBLorzjj81EL/UZhQ72QrTKt2CfosdTjsa
 U7VnApe4p5PIXenBZNKj5KN59cClva5S4m8PhzARp8XO8UqKlfblM17TRPIhwjQfF4QfbbT0
 HtxWeKlFj4kBKtu11JarM9NgOZwlkjSKY4+LK0XLihLM5LDPhZ5qp9faTNii9zVC4ve8W3oH
 y53bZfi9vmmeLSWjtPr2YASN0sWCnMwGIr7rcdaHsbafFY6QTB4UqGAm+p6E2CAo0iyvr2Zl
 kxRp2cCkAav7ZE5AVniho9fhEPHAs8k8CNT0d0ENle0wXkzCbtDH49EH6bbiYIPrbQ5pdYtF
 qFtU5zZXpxnF2SWkxxAPMKVhNEzK3yD21nUVwL7O2dXQnKVb1GQkjMSVlC0r3dm4+venZZWn
 oBMISuBHcNTHFozUJmKAB9tpnvo1UUgdCtJdxOgCrFulI/EqdACx/XZgqBlLscSBw/EwzfGh
 Q+aDQ1B/bvGopMv8cmPjqeB9t/7H+x7F0tcPm/a8bfpanWKojv9mddNALSSYDTQdGLo46H+N
 +9b+O7xba8cl1FQvosiT7sylfAi58HirqNxxxh/GCmZdEyiD75teyHU3cRGuqBX6KVevA+6B
 hCG9tVAYO3bM8L5Cl8BYgEia73bh/0TnzDT69UzIVn7u3ArrObWDx0KMkDV2iJHLbZzPIc0+
 ssbuZYbu16llx4nEtealSQIpW6CGWMNDvc8vZYADY611gdykgNeYYbRAzPd6Y2Ub4keKVEjJ
 zKZifaQh7lYwUaeIXM/GWKUgLhYjJUK/htL0EUDNxKCnd+c3q072xhY8DIWSAVJz0oYj7Iva
 zYzb0Ald7+T+zpIhdRYWzH+Eg5MMxSV50jtxgZbj2beVUSpCjTAIWBV1TxhJ6zFH7awpgRmw
 Yw=
IronPort-HdrOrdr: A9a23:fY9mpa8cBxsAlhz13r5uk+DgI+orL9Y04lQ7vn2YSXRuHPBw8P
 re5cjztCWE7gr5N0tBpTntAsW9qDbnhPtICOoqTNCftWvdyQiVxehZhOOIqVDd8m/Fh4pgPM
 9bAtBD4bbLbGSS4/yU3ODBKadD/OW6
X-IronPort-AV: E=Sophos;i="5.88,350,1635220800"; 
   d="scan'208";a="63127623"
From: Jane Malalane <jane.malalane@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Jane Malalane <jane.malalane@citrix.com>, Wei Liu <wl@xen.org>, "Anthony
 PERARD" <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, "Andrew
 Cooper" <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, Julien Grall
	<julien@xen.org>, "Stefano Stabellini" <sstabellini@kernel.org>, Volodymyr
 Babchuk <Volodymyr_Babchuk@epam.com>, Bertrand Marquis
	<bertrand.marquis@arm.com>, Jun Nakajima <jun.nakajima@intel.com>, Kevin Tian
	<kevin.tian@intel.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>
Subject: [PATCH v2 1/2] xen+tools: Report Interrupt Controller Virtualization capabilities on x86
Date: Mon, 7 Feb 2022 18:21:00 +0000
Message-ID: <20220207182101.31941-2-jane.malalane@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220207182101.31941-1-jane.malalane@citrix.com>
References: <20220207182101.31941-1-jane.malalane@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

Add XEN_SYSCTL_PHYSCAP_ARCH_ASSISTED_xapic and
XEN_SYSCTL_PHYSCAP_ARCH_ASSISTED_x2apic to report accelerated xapic
and x2apic, on x86 hardware.
No such features are currently implemented on AMD hardware.

For that purpose, also add an arch-specific "capabilities" parameter
to struct xen_sysctl_physinfo.

Signed-off-by: Jane Malalane <jane.malalane@citrix.com>
Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Wei Liu <wl@xen.org>
CC: Anthony PERARD <anthony.perard@citrix.com>
CC: Juergen Gross <jgross@suse.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
CC: George Dunlap <george.dunlap@citrix.com>
CC: Jan Beulich <jbeulich@suse.com>
CC: Julien Grall <julien@xen.org>
CC: Stefano Stabellini <sstabellini@kernel.org>
CC: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
CC: Bertrand Marquis <bertrand.marquis@arm.com>
CC: Jun Nakajima <jun.nakajima@intel.com>
CC: Kevin Tian <kevin.tian@intel.com>
CC: "Roger Pau Monné" <roger.pau@citrix.com>

v2:
 * Use one macro LIBXL_HAVE_PHYSINFO_ASSISTED_APIC instead of two
 * Pass xcpyshinfo as a pointer in libxl__arch_get_physinfo
 * Set assisted_x{2}apic_available to be conditional upon "bsp" and
   annotate it with __ro_after_init
 * Change XEN_SYSCTL_PHYSCAP_ARCH_ASSISTED_X{2}APIC to
   .._X86_ASSISTED_X{2}APIC
 * Keep XEN_SYSCTL_PHYSCAP_X86_ASSISTED_X{2}APIC contained within
   sysctl.h
 * Fix padding introduced in struct xen_sysctl_physinfo and bump
   XEN_SYSCTL_INTERFACE_VERSION
---
 tools/golang/xenlight/helpers.gen.go |  4 ++++
 tools/golang/xenlight/types.gen.go   |  6 ++++++
 tools/include/libxl.h                |  7 +++++++
 tools/libs/light/libxl.c             |  3 +++
 tools/libs/light/libxl_arch.h        |  4 ++++
 tools/libs/light/libxl_arm.c         |  5 +++++
 tools/libs/light/libxl_types.idl     |  2 ++
 tools/libs/light/libxl_x86.c         | 11 +++++++++++
 tools/ocaml/libs/xc/xenctrl.ml       |  5 +++++
 tools/ocaml/libs/xc/xenctrl.mli      |  5 +++++
 tools/xl/xl_info.c                   |  6 ++++--
 xen/arch/x86/hvm/vmx/vmcs.c          |  9 +++++++++
 xen/arch/x86/include/asm/domain.h    |  3 +++
 xen/arch/x86/sysctl.c                |  7 +++++++
 xen/include/public/sysctl.h          |  8 +++++++-
 15 files changed, 82 insertions(+), 3 deletions(-)

diff --git a/tools/golang/xenlight/helpers.gen.go b/tools/golang/xenlight/helpers.gen.go
index b746ff1081..dd4e6c9f14 100644
--- a/tools/golang/xenlight/helpers.gen.go
+++ b/tools/golang/xenlight/helpers.gen.go
@@ -3373,6 +3373,8 @@ x.CapVmtrace = bool(xc.cap_vmtrace)
 x.CapVpmu = bool(xc.cap_vpmu)
 x.CapGnttabV1 = bool(xc.cap_gnttab_v1)
 x.CapGnttabV2 = bool(xc.cap_gnttab_v2)
+x.CapAssistedXapic = bool(xc.cap_assisted_xapic)
+x.CapAssistedX2Apic = bool(xc.cap_assisted_x2apic)
 
  return nil}
 
@@ -3407,6 +3409,8 @@ xc.cap_vmtrace = C.bool(x.CapVmtrace)
 xc.cap_vpmu = C.bool(x.CapVpmu)
 xc.cap_gnttab_v1 = C.bool(x.CapGnttabV1)
 xc.cap_gnttab_v2 = C.bool(x.CapGnttabV2)
+xc.cap_assisted_xapic = C.bool(x.CapAssistedXapic)
+xc.cap_assisted_x2apic = C.bool(x.CapAssistedX2Apic)
 
  return nil
  }
diff --git a/tools/golang/xenlight/types.gen.go b/tools/golang/xenlight/types.gen.go
index b1e84d5258..5f384b767c 100644
--- a/tools/golang/xenlight/types.gen.go
+++ b/tools/golang/xenlight/types.gen.go
@@ -389,6 +389,10 @@ RunHotplugScripts Defbool
 DriverDomain Defbool
 Passthrough Passthrough
 XendSuspendEvtchnCompat Defbool
+ArchX86 struct {
+AssistedXapic Defbool
+AssistedX2Apic Defbool
+}
 }
 
 type DomainRestoreParams struct {
@@ -1014,6 +1018,8 @@ CapVmtrace bool
 CapVpmu bool
 CapGnttabV1 bool
 CapGnttabV2 bool
+CapAssistedXApic bool
+CapAssistedX2apic bool
 }
 
 type Connectorinfo struct {
diff --git a/tools/include/libxl.h b/tools/include/libxl.h
index 2bbbd21f0b..924e142628 100644
--- a/tools/include/libxl.h
+++ b/tools/include/libxl.h
@@ -528,6 +528,13 @@
 #define LIBXL_HAVE_MAX_GRANT_VERSION 1
 
 /*
+ * LIBXL_HAVE_PHYSINFO_ASSISTED_APIC indicates that libxl_physinfo has
+ * cap_assisted_x{2}apic fields, which indicates the availability of x{2}APIC
+ * hardware assisted virtualization.
+ */
+#define LIBXL_HAVE_PHYSINFO_ASSISTED_APIC 1
+
+/*
  * libxl ABI compatibility
  *
  * The only guarantee which libxl makes regarding ABI compatibility
diff --git a/tools/libs/light/libxl.c b/tools/libs/light/libxl.c
index 667ae6409b..fabb474221 100644
--- a/tools/libs/light/libxl.c
+++ b/tools/libs/light/libxl.c
@@ -15,6 +15,7 @@
 #include "libxl_osdeps.h"
 
 #include "libxl_internal.h"
+#include "libxl_arch.h"
 
 int libxl_ctx_alloc(libxl_ctx **pctx, int version,
                     unsigned flags, xentoollog_logger * lg)
@@ -410,6 +411,8 @@ int libxl_get_physinfo(libxl_ctx *ctx, libxl_physinfo *physinfo)
     physinfo->cap_gnttab_v2 =
         !!(xcphysinfo.capabilities & XEN_SYSCTL_PHYSCAP_gnttab_v2);
 
+    libxl__arch_get_physinfo(physinfo, &xcphysinfo);
+
     GC_FREE;
     return 0;
 }
diff --git a/tools/libs/light/libxl_arch.h b/tools/libs/light/libxl_arch.h
index 1522ecb97f..207ceac6a1 100644
--- a/tools/libs/light/libxl_arch.h
+++ b/tools/libs/light/libxl_arch.h
@@ -86,6 +86,10 @@ int libxl__arch_extra_memory(libxl__gc *gc,
                              uint64_t *out);
 
 _hidden
+void libxl__arch_get_physinfo(libxl_physinfo *physinfo,
+                              const xc_physinfo_t *xcphysinfo);
+
+_hidden
 void libxl__arch_update_domain_config(libxl__gc *gc,
                                       libxl_domain_config *dst,
                                       const libxl_domain_config *src);
diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c
index eef1de0939..39fdca1b49 100644
--- a/tools/libs/light/libxl_arm.c
+++ b/tools/libs/light/libxl_arm.c
@@ -1431,6 +1431,11 @@ int libxl__arch_passthrough_mode_setdefault(libxl__gc *gc,
     return rc;
 }
 
+void libxl__arch_get_physinfo(libxl_physinfo *physinfo,
+                              const xc_physinfo_t *xcphysinfo)
+{
+}
+
 void libxl__arch_update_domain_config(libxl__gc *gc,
                                       libxl_domain_config *dst,
                                       const libxl_domain_config *src)
diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl
index 2a42da2f7d..42ac6c357b 100644
--- a/tools/libs/light/libxl_types.idl
+++ b/tools/libs/light/libxl_types.idl
@@ -1068,6 +1068,8 @@ libxl_physinfo = Struct("physinfo", [
     ("cap_vpmu", bool),
     ("cap_gnttab_v1", bool),
     ("cap_gnttab_v2", bool),
+    ("cap_assisted_xapic", bool),
+    ("cap_assisted_x2apic", bool),
     ], dir=DIR_OUT)
 
 libxl_connectorinfo = Struct("connectorinfo", [
diff --git a/tools/libs/light/libxl_x86.c b/tools/libs/light/libxl_x86.c
index 1feadebb18..e0a06ecfe3 100644
--- a/tools/libs/light/libxl_x86.c
+++ b/tools/libs/light/libxl_x86.c
@@ -866,6 +866,17 @@ int libxl__arch_passthrough_mode_setdefault(libxl__gc *gc,
     return rc;
 }
 
+void libxl__arch_get_physinfo(libxl_physinfo *physinfo,
+                              const xc_physinfo_t *xcphysinfo)
+{
+    physinfo->cap_assisted_xapic =
+        !!(xcphysinfo->arch_capabilities &
+           XEN_SYSCTL_PHYSCAP_X86_ASSISTED_XAPIC);
+    physinfo->cap_assisted_x2apic =
+        !!(xcphysinfo->arch_capabilities &
+           XEN_SYSCTL_PHYSCAP_X86_ASSISTED_X2APIC);
+}
+
 void libxl__arch_update_domain_config(libxl__gc *gc,
                                       libxl_domain_config *dst,
                                       const libxl_domain_config *src)
diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl.ml
index 7503031d8f..7ce832d605 100644
--- a/tools/ocaml/libs/xc/xenctrl.ml
+++ b/tools/ocaml/libs/xc/xenctrl.ml
@@ -127,6 +127,10 @@ type physinfo_cap_flag =
 	| CAP_Gnttab_v1
 	| CAP_Gnttab_v2
 
+type physinfo_cap_arch_flag =
+	| CAP_ARCH_ASSISTED_XAPIC
+	| CAP_ARCH_ASSISTED_X2APIC
+
 type physinfo =
 {
 	threads_per_core : int;
@@ -139,6 +143,7 @@ type physinfo =
 	scrub_pages      : nativeint;
 	(* XXX hw_cap *)
 	capabilities     : physinfo_cap_flag list;
+	arch_capabilities : physinfo_cap_arch_flag list;
 	max_nr_cpus      : int;
 }
 
diff --git a/tools/ocaml/libs/xc/xenctrl.mli b/tools/ocaml/libs/xc/xenctrl.mli
index d1d9c9247a..a2b15130ee 100644
--- a/tools/ocaml/libs/xc/xenctrl.mli
+++ b/tools/ocaml/libs/xc/xenctrl.mli
@@ -112,6 +112,10 @@ type physinfo_cap_flag =
   | CAP_Gnttab_v1
   | CAP_Gnttab_v2
 
+type physinfo_cap_arch_flag =
+  | CAP_ARCH_ASSISTED_XAPIC
+  | CAP_ARCH_ASSISTED_X2APIC
+
 type physinfo = {
   threads_per_core : int;
   cores_per_socket : int;
@@ -122,6 +126,7 @@ type physinfo = {
   free_pages       : nativeint;
   scrub_pages      : nativeint;
   capabilities     : physinfo_cap_flag list;
+  arch_capabilities : physinfo_cap_arch_flag list;
   max_nr_cpus      : int; (** compile-time max possible number of nr_cpus *)
 }
 type version = { major : int; minor : int; extra : string; }
diff --git a/tools/xl/xl_info.c b/tools/xl/xl_info.c
index 712b7638b0..3205270754 100644
--- a/tools/xl/xl_info.c
+++ b/tools/xl/xl_info.c
@@ -210,7 +210,7 @@ static void output_physinfo(void)
          info.hw_cap[4], info.hw_cap[5], info.hw_cap[6], info.hw_cap[7]
         );
 
-    maybe_printf("virt_caps              :%s%s%s%s%s%s%s%s%s%s%s\n",
+    maybe_printf("virt_caps              :%s%s%s%s%s%s%s%s%s%s%s%s%s\n",
          info.cap_pv ? " pv" : "",
          info.cap_hvm ? " hvm" : "",
          info.cap_hvm && info.cap_hvm_directio ? " hvm_directio" : "",
@@ -221,7 +221,9 @@ static void output_physinfo(void)
          info.cap_vmtrace ? " vmtrace" : "",
          info.cap_vpmu ? " vpmu" : "",
          info.cap_gnttab_v1 ? " gnttab-v1" : "",
-         info.cap_gnttab_v2 ? " gnttab-v2" : ""
+         info.cap_gnttab_v2 ? " gnttab-v2" : "",
+         info.cap_assisted_xapic ? " assisted_xapic" : "",
+         info.cap_assisted_x2apic ? " assisted_x2apic" : ""
         );
 
     vinfo = libxl_get_version_info(ctx);
diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c
index 7ab15e07a0..4060aef1bd 100644
--- a/xen/arch/x86/hvm/vmx/vmcs.c
+++ b/xen/arch/x86/hvm/vmx/vmcs.c
@@ -343,6 +343,15 @@ static int vmx_init_vmcs_config(bool bsp)
             MSR_IA32_VMX_PROCBASED_CTLS2, &mismatch);
     }
 
+    /* Check whether hardware supports accelerated xapic and x2apic. */
+    if ( bsp )
+    {
+        assisted_xapic_available = cpu_has_vmx_virtualize_apic_accesses;
+        assisted_x2apic_available = (cpu_has_vmx_apic_reg_virt ||
+                                     cpu_has_vmx_virtual_intr_delivery) &&
+                                    cpu_has_vmx_virtualize_x2apic_mode;
+    }
+
     /* The IA32_VMX_EPT_VPID_CAP MSR exists only when EPT or VPID available */
     if ( _vmx_secondary_exec_control & (SECONDARY_EXEC_ENABLE_EPT |
                                         SECONDARY_EXEC_ENABLE_VPID) )
diff --git a/xen/arch/x86/include/asm/domain.h b/xen/arch/x86/include/asm/domain.h
index e62e109598..72431df26d 100644
--- a/xen/arch/x86/include/asm/domain.h
+++ b/xen/arch/x86/include/asm/domain.h
@@ -756,6 +756,9 @@ static inline void pv_inject_sw_interrupt(unsigned int vector)
                       : is_pv_32bit_domain(d) ? PV32_VM_ASSIST_MASK \
                                               : PV64_VM_ASSIST_MASK)
 
+extern bool assisted_xapic_available;
+extern bool assisted_x2apic_available;
+
 #endif /* __ASM_DOMAIN_H__ */
 
 /*
diff --git a/xen/arch/x86/sysctl.c b/xen/arch/x86/sysctl.c
index aff52a13f3..642cc96985 100644
--- a/xen/arch/x86/sysctl.c
+++ b/xen/arch/x86/sysctl.c
@@ -69,6 +69,9 @@ struct l3_cache_info {
     unsigned long size;
 };
 
+bool __ro_after_init assisted_xapic_available;
+bool __ro_after_init assisted_x2apic_available;
+
 static void l3_cache_get(void *arg)
 {
     struct cpuid4_info info;
@@ -135,6 +138,10 @@ void arch_do_physinfo(struct xen_sysctl_physinfo *pi)
         pi->capabilities |= XEN_SYSCTL_PHYSCAP_hap;
     if ( IS_ENABLED(CONFIG_SHADOW_PAGING) )
         pi->capabilities |= XEN_SYSCTL_PHYSCAP_shadow;
+    if ( assisted_xapic_available )
+        pi->arch_capabilities |= XEN_SYSCTL_PHYSCAP_X86_ASSISTED_XAPIC;
+    if ( assisted_x2apic_available )
+        pi->arch_capabilities |= XEN_SYSCTL_PHYSCAP_X86_ASSISTED_X2APIC;
 }
 
 long arch_do_sysctl(
diff --git a/xen/include/public/sysctl.h b/xen/include/public/sysctl.h
index 55252e97f2..11328bbf78 100644
--- a/xen/include/public/sysctl.h
+++ b/xen/include/public/sysctl.h
@@ -35,7 +35,7 @@
 #include "domctl.h"
 #include "physdev.h"
 
-#define XEN_SYSCTL_INTERFACE_VERSION 0x00000014
+#define XEN_SYSCTL_INTERFACE_VERSION 0x00000015
 
 /*
  * Read console content from Xen buffer ring.
@@ -111,6 +111,10 @@ struct xen_sysctl_tbuf_op {
 /* Max XEN_SYSCTL_PHYSCAP_* constant.  Used for ABI checking. */
 #define XEN_SYSCTL_PHYSCAP_MAX XEN_SYSCTL_PHYSCAP_gnttab_v2
 
+/* The platform supports x{2}apic hardware assisted emulation. */
+#define XEN_SYSCTL_PHYSCAP_X86_ASSISTED_XAPIC  (1u << 0)
+#define XEN_SYSCTL_PHYSCAP_X86_ASSISTED_X2APIC (1u << 1)
+
 struct xen_sysctl_physinfo {
     uint32_t threads_per_core;
     uint32_t cores_per_socket;
@@ -120,6 +124,8 @@ struct xen_sysctl_physinfo {
     uint32_t max_node_id; /* Largest possible node ID on this host */
     uint32_t cpu_khz;
     uint32_t capabilities;/* XEN_SYSCTL_PHYSCAP_??? */
+    uint32_t arch_capabilities;/* XEN_SYSCTL_PHYSCAP_X86{ARM}_??? */
+    uint32_t pad; /* Must be zero. */
     uint64_aligned_t total_pages;
     uint64_aligned_t free_pages;
     uint64_aligned_t scrub_pages;
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 07 18:21:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 18:21:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267362.461101 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH8dx-0003bd-Gm; Mon, 07 Feb 2022 18:21:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267362.461101; Mon, 07 Feb 2022 18:21:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH8dx-0003bW-Dt; Mon, 07 Feb 2022 18:21:41 +0000
Received: by outflank-mailman (input) for mailman id 267362;
 Mon, 07 Feb 2022 18:21:39 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=E+Gq=SW=citrix.com=Jane.Malalane@srs-se1.protection.inumbo.net>)
 id 1nH8dv-0003bN-PJ
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 18:21:39 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c89408de-8842-11ec-8f75-fffcc8bd4f1a;
 Mon, 07 Feb 2022 19:21:38 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c89408de-8842-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644258098;
  h=from:to:cc:subject:date:message-id:mime-version:
   content-transfer-encoding;
  bh=Yce9W6x79QGe5U5nLNq7SWN19QAgA4n10rhq6HVqPoI=;
  b=Xo6XTathqYM+u/Ux6ziY0/12UFfHKC2qRRS3ot7O8ZPOg6QJ4qtwr9VN
   cnL8rG19M8qwFH1xebvgCkRNknGcbCJ3u3CQMUxZj/+WV1Fzb6XmyQxKD
   jhpIXy/hFcpwPa9r3Y97N5Jui3U+endruFKdIFJAwZaO0gF8qQxXcGq8b
   k=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: IO5K9y9HhIqRLEMRP8RRdLEWwEMs3qoeeMmM0zWwGvmSeSY2DoVQ/3VRPI7ZaomF5hSBoLg+s8
 ouc+rqMjDAGGNxsJ4fksurgiKRU87H/WX0A+06sORT8qQMKU9uqTiqNF8Re9s+8lAueGyHbdKk
 IdDFT/z3bXAsz9YPORIKmLLu5Cg40pEvwiFbUoqbGAkay7bi4pBTYBkzam2oYi+Qnm5HCSEHfg
 i6ON6gvXjZEolxAI6wnlMNl0mJSsVPHUcdbUuft30s7cCg2To2pkJEYBxZ7HmY79f/ZOfhtLch
 CiYOSCwQYBrl4VYLY9RubaAJ
X-SBRS: 5.1
X-MesageID: 64075063
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:saou06qTUvFJ9JpLTH9lrsXosmNeBmI4YhIvgKrLsJaIsI4StFCzt
 garIBmOMq6CZjCkctkgaYu28BkBupHWx9MwQFBvqik2RCgS+JuZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlZT4vE2xbuKU5NTsY0idfic5Dndx4f5fs7Rh2NQw24DmW1nlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCnaKfbS0VIa/Fo+g6fzdcOhhhPYYcoLCSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFKEWvHwm6DjdBPIvR53rSKTW/95Imjw3g6iiGN6AO
 5JGNGIxN3wsZTVGK3goGZZlgt7yvUuncDJa80OeiZIotj27IAtZj+G2bYu9lsaxbdVYmAOUq
 3zL+0z9AwoGL5qPxDyd6HWui+TT2yThV+ov+KaQr6AwxgfJnypKVUNQBQDTTeSFZlCWZf17A
 XAL+CMVoY8e2kiCd8b9dEfgryvR1vIDYOZ4H+o/4QCL76Pb5QeFG2QJJgJ8hMwaWNweHmJzi
 ALQ9z/9LXk26eDOFyrBnluBhW7qYUAowXk+iTjopOfvy/3qu8kNgx3GVb6P+4bl34SuSVkcL
 91nxRXSZon/b+ZWjc1XHnid2lpAQ6QlqSZvt23qspqNtF8RWWJcT9XABaLnxfhBNp2FaVKKo
 WIJncOThMhXU83RzX3UGbtcRujyjxpgDNE7qQQ+d6TNChz3oyLzFWyuyG0WyLhV3jYsJmayP
 R67VfJ5755PJnq6BZKbkKrqY/nGOZPITIy/PtiNN4ImSsEoKGevoXE/DWbNjjuFuBV9zskXZ
 8zBGe7yVilyNEiS5GfvLwvr+eRwnX5WKKK6bc2T8ilLJpLEOCfFEulUbATSBg37hYvdyDjoH
 x9kH5Pi431ivCfWOUE7KKYfcgIHK2YVH5fzp5AFf+KPOFM+SmogF+XQ0fUqfIk8x/ZZkeLB/
 3ecXE5EyQWg2S2beFvSMn0zOqnyWZtfrG4gOXB+N1ifxHV+M52k670SdsVrcOB/pvBj1/N9U
 9IMZ96EXqZUUj3C9jlENcv9oYVueQ6FnwWLOyb5MjEzc4Q5H17C+8P+fxup/y4LV3Llucw7q
 rym9wXaXZtcGFgyUJeIMKqilgrjs2IcleR+W1rzDuNSIEi8opJ3LyHRj+MsJ51eIxv02TbHh
 R2dBg0VpLeRrtZtosXJn62Ns6ygD/B6QhhBB2De4Lu7aXva826kzdMSWeqEZ2mABmb9+aHkb
 uRJ1fDsdvYAmQ8S4YZ7Fr9qy4M45sfu+OAGnlg1Qi2TYgT5EK5kL1mHwdJL5/9EybJusAerX
 l6Cp4tBMrKTNcK5SFMcKWLJtAhYOS34TtUK0ckIHQ==
IronPort-HdrOrdr: A9a23:Eo1Kcq4JKa0Qk4kywAPXwMTXdLJyesId70hD6qhwISY6TiX+rb
 HIoB17726RtN9/YhEdcLy7VJVoIkmskKKdg7NhXotKNTOO0ADDQb2KhbGSpQEIcBeeygcy78
 hdmtBFeb/NMWQ=
X-IronPort-AV: E=Sophos;i="5.88,350,1635220800"; 
   d="scan'208";a="64075063"
From: Jane Malalane <jane.malalane@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Jane Malalane <jane.malalane@citrix.com>
Subject: [PATCH v2 0/2] xen: Report and use hardware APIC virtualization capabilities
Date: Mon, 7 Feb 2022 18:20:59 +0000
Message-ID: <20220207182101.31941-1-jane.malalane@citrix.com>
X-Mailer: git-send-email 2.11.0
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

Jane Malalane (2):
  xen+tools: Report Interrupt Controller Virtualization capabilities on
    x86
  x86/xen: Allow per-domain usage of hardware virtualized APIC

 docs/man/xl.cfg.5.pod.in              | 10 +++++++++
 docs/man/xl.conf.5.pod.in             | 12 ++++++++++
 tools/golang/xenlight/helpers.gen.go  | 16 +++++++++++++
 tools/golang/xenlight/types.gen.go    |  6 +++++
 tools/include/libxl.h                 | 14 ++++++++++++
 tools/libs/light/libxl.c              |  3 +++
 tools/libs/light/libxl_arch.h         |  9 ++++++--
 tools/libs/light/libxl_arm.c          | 12 ++++++++--
 tools/libs/light/libxl_create.c       | 23 +++++++++++--------
 tools/libs/light/libxl_types.idl      |  4 ++++
 tools/libs/light/libxl_x86.c          | 42 +++++++++++++++++++++++++++++++++--
 tools/ocaml/libs/xc/xenctrl.ml        |  7 ++++++
 tools/ocaml/libs/xc/xenctrl.mli       |  7 ++++++
 tools/ocaml/libs/xc/xenctrl_stubs.c   |  2 +-
 tools/xl/xl.c                         |  8 +++++++
 tools/xl/xl.h                         |  2 ++
 tools/xl/xl_info.c                    |  6 +++--
 tools/xl/xl_parse.c                   | 16 +++++++++++++
 xen/arch/x86/domain.c                 | 28 ++++++++++++++++++++++-
 xen/arch/x86/hvm/vmx/vmcs.c           | 13 +++++++++++
 xen/arch/x86/hvm/vmx/vmx.c            | 14 +++++-------
 xen/arch/x86/include/asm/domain.h     |  3 +++
 xen/arch/x86/include/asm/hvm/domain.h |  6 +++++
 xen/arch/x86/sysctl.c                 |  7 ++++++
 xen/arch/x86/traps.c                  |  8 +++----
 xen/include/public/arch-x86/xen.h     |  2 ++
 xen/include/public/sysctl.h           |  8 ++++++-
 27 files changed, 255 insertions(+), 33 deletions(-)

-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 07 18:21:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 18:21:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267363.461111 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH8e3-0003sY-PM; Mon, 07 Feb 2022 18:21:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267363.461111; Mon, 07 Feb 2022 18:21:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH8e3-0003sR-MS; Mon, 07 Feb 2022 18:21:47 +0000
Received: by outflank-mailman (input) for mailman id 267363;
 Mon, 07 Feb 2022 18:21:46 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=E+Gq=SW=citrix.com=Jane.Malalane@srs-se1.protection.inumbo.net>)
 id 1nH8e2-0003rG-3k
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 18:21:46 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id cc31fc32-8842-11ec-8eb8-a37418f5ba1a;
 Mon, 07 Feb 2022 19:21:43 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cc31fc32-8842-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644258103;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=0XTOLAnBMrMDqngU7nmiL5ddS04Uw/To/WSMXa29m/A=;
  b=EGPMrYg2dNxVMCQroLXBcG1k317lv6cKNZjV8ighzAU9Ks/pWEPLoHNM
   brV+JuUDGh/h8+k13mm9JvKMOAfG/DvLFbdlyFYIxIDT2iL1dJgMWMlrq
   MPFLIUz/02M4WVR0RZbu7bXzQ9HpmFkjyCsxP9gGJmXgSYDi0GnDQ7z6H
   8=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: T3R5fMvCYDm98IDc3cMvpC5ZfIvf7PIFIXPH0chGPizKGJJ4ajJ/OpK5q6uHvYhgo1VA7cx+U4
 bDYau0XgWst7vgnhMahtLTErk8twuBQognLxxi2mMaFhr3l9EfOlbPjENq7orMF1p1WRJ5riCg
 WKmK4TwcNDfifFKWpu3bcrXz2HWiCOTmStfSyz4Pg1InWrd1mOCtgF7mqQ1/FlwIYbtVhD8A2M
 wIUtm/NKP2tnbnRVRZAri1pdjR61NL9T8C6lGLntEdsl14nJzNQlA0gGBpjMLEGuRCPdCBbhDJ
 nKSyl4PmmKvdTWYANwyQv29l
X-SBRS: 5.1
X-MesageID: 63670008
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:wpgam60FJ1AGs5YsgPbD5Xx2kn2cJEfYwER7XKvMYLTBsI5bpzEHx
 2RMXz+HaK2PMWT9edlyaIq38BgDsZbTm9BlGQc5pC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkS5PE3oHJ9RGQ74nRLlbHILOCanAZqTNMEn9700o5w7Fh2OaEvPDia++zk
 YKqyyHgEAfNNw5cagr4PIra9XuDFNyr0N8plgRWicJj5TcypFFMZH4rHomjLmOQf2VhNrXSq
 9Avbl2O1jixEx8FUrtJm1tgG6EAaua60QOm0hK6V0U+6/TrS+NbPqsTbZIhhUlrZzqhmMBv1
 9Nhl4CLeF0jAKvDwM9CAysDHHQrVUFG0OevzXmXtMWSywvNcmf2wuUoB0YzVWEa0r8pWycUr
 6VecW1TKEDY7w616OvTpu1EpM0lIY/ONYcWvnhmwBnSDOo8QICFSKLPjTNd9Glr2J8WRa6OD
 yYfQT5GbgrkTCRjAQdNNc49lvm3l3rBSCIN/Tp5ooJoujOOnWSdyoPFK8HJc9aHQcFUmEewp
 W/c+Wn9RBYAO7S3yyeB83+qrv/Cm2X8Qo16PIO/8vlmkViC3Fs5ARcdVUa4ifShg0v4UNVaQ
 2QY8zQjhbI//0uqSp/6RRLQiHyLpBkHQPJLDvY3rgqKz8L88wufQ2QJUDNFQNgnr9MtAywn0
 EeTmNHkDiApt6eaIVqC8p+EoDX0PjIaRUcAbyIZSQoO4/H4vZo+yBnIS75e/LWd14OvX2uqm
 nbT8XZ41+57YdM3O7uT+kDZnDSAhITyf1Q/2APYBkn6vjEia9vwD2C30mTz4fFFJYefa1COu
 nkYhsSThNwz4YGxeD+lG7tUQuzwjxqRGHiF2AM0QcF9n9i40yP7JehtDCdCyFCF2yruURvge
 wfttAxY//e/11P6PPYsM+pd5ynHpJUM9OgJtNiJNLKigbArLWdrGR2CgmbKjgjQfLAEy/1XB
 HtiWZ/E4YwmIapm1iGqYOwWzKUmwCszrUuKG8ynlkX+iOTPPifOIVvgDLdpRrpohJ5oXS2Pq
 4oPXyd040k3vBLCjtn/rtdIcAFiwYkTDpHqsc1HHtNv0SI9cFzN/8T5mOt7E6Q8xvw9vr6Ro
 hmVBx8JoHKi1CavAVjbNRhLNui1Nb4h9i1TAMDZFQvxs5TVSd30t/l3mlpeVeRPydGPOtYuE
 6BVIJvRXqsTItkFkhxEBaTAQEVZXEzDrWqz0+CNOlDTprZsGF7E/MHKZAzq+HVcBya7r5Jm8
 bahyhnaUdwIQAE7VJTab/emzlWQu3kBmb0tAxuUc4cLIEi8opJ3LyHRj+MsJ51eIxv02TbHh
 R2dBg0VpLeRrtZtosXJn62Ns6ygD/B6QhhBB2De4LvvbXva82OvzJVuSuGNeTyBBmr49L/7P
 bdezu3mMe1Bl1FP6tIuH7FuxKM4xt3uu74FkVg0QCSVNwymU+oyLGOH0M9Dsrx26oVY4QbmC
 FiS/tR6OKmSPJ+3GlAmOwd4PP+I0usZm2eO4K1tcln6/iJ+4JGOTV5WY0uXkCVYIbZ4bNElz
 OMmtJJE4gCzkEN3YNOPjyQS/GWQNH0QFa4gs8hCUoPsjwMqzHBEYIDdVXCqsM3eNY0UPxl4O
 CKQiYrDm69YlxjLfHcEHHTQ2fZQ2MYVsxdQwV5ef1mEl7IpXBPsMMG9Jdjvcjlo8w==
IronPort-HdrOrdr: A9a23:6tttQa+0D8s+Au1OT7xuk+DgI+orL9Y04lQ7vn2YSXRuHPBw8P
 re5cjztCWE7gr5N0tBpTntAsW9qDbnhPtICOoqTNCftWvdyQiVxehZhOOIqVDd8m/Fh4pgPM
 9bAtBD4bbLbGSS4/yU3ODBKadD/OW6
X-IronPort-AV: E=Sophos;i="5.88,350,1635220800"; 
   d="scan'208";a="63670008"
From: Jane Malalane <jane.malalane@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Jane Malalane <jane.malalane@citrix.com>, Wei Liu <wl@xen.org>, "Anthony
 PERARD" <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, "Andrew
 Cooper" <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, Julien Grall
	<julien@xen.org>, "Stefano Stabellini" <sstabellini@kernel.org>, Christian
 Lindig <christian.lindig@citrix.com>, David Scott <dave@recoil.org>,
	"Volodymyr Babchuk" <Volodymyr_Babchuk@epam.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>
Subject: [PATCH v2 2/2] x86/xen: Allow per-domain usage of hardware virtualized APIC
Date: Mon, 7 Feb 2022 18:21:01 +0000
Message-ID: <20220207182101.31941-3-jane.malalane@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220207182101.31941-1-jane.malalane@citrix.com>
References: <20220207182101.31941-1-jane.malalane@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

Introduce a new per-domain creation x86 specific flag to
select whether hardware assisted virtualization should be used for
x{2}APIC.

A per-domain option is added to xl in order to select the usage of
x{2}APIC hardware assisted vitualization, as well as a global
configuration option.

Having all APIC interaction exit to Xen for emulation is slow and can
induce much overhead. Hardware can speed up x{2}APIC by running APIC
read/write accesses without taking a VM exit.

Being able to disable x{2}APIC hardware assisted vitualization can be
useful for testing and debugging purposes.

Signed-off-by: Jane Malalane <jane.malalane@citrix.com>
Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Wei Liu <wl@xen.org>
CC: Anthony PERARD <anthony.perard@citrix.com>
CC: Juergen Gross <jgross@suse.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
CC: George Dunlap <george.dunlap@citrix.com>
CC: Jan Beulich <jbeulich@suse.com>
CC: Julien Grall <julien@xen.org>
CC: Stefano Stabellini <sstabellini@kernel.org>
CC: Christian Lindig <christian.lindig@citrix.com>
CC: David Scott <dave@recoil.org>
CC: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
CC: "Roger Pau Monné" <roger.pau@citrix.com>

v2:
 * Add a LIBXL_HAVE_ASSISTED_APIC macro
 * Pass xcpyshinfo as a pointer in libxl__arch_get_physinfo
 * Add a return statement in now "int"
   libxl__arch_domain_build_info_setdefault
 * Preserve libxl__arch_domain_build_info_setdefault 's location in
   libxl_create.c
 * Correct x{2}apic default setting logic in
   libxl__arch_domain_prepare_config
 * Correct logic for parsing assisted_x{2}apic host/guest options in
   xl_parse.c and initialize them to -1 in xl.c
 * Use guest options directly in vmx_vlapic_msr_changed
 * Fix indentation of bool assisted_x{2}apic in struct hvm_domain
 * Add a change in xenctrl_stubs.c to pass xenctrl ABI checks
---
 docs/man/xl.cfg.5.pod.in              | 10 ++++++++++
 docs/man/xl.conf.5.pod.in             | 12 ++++++++++++
 tools/golang/xenlight/helpers.gen.go  | 12 ++++++++++++
 tools/include/libxl.h                 |  7 +++++++
 tools/libs/light/libxl_arch.h         |  5 +++--
 tools/libs/light/libxl_arm.c          |  7 +++++--
 tools/libs/light/libxl_create.c       | 23 ++++++++++++++---------
 tools/libs/light/libxl_types.idl      |  2 ++
 tools/libs/light/libxl_x86.c          | 31 +++++++++++++++++++++++++++++--
 tools/ocaml/libs/xc/xenctrl.ml        |  2 ++
 tools/ocaml/libs/xc/xenctrl.mli       |  2 ++
 tools/ocaml/libs/xc/xenctrl_stubs.c   |  2 +-
 tools/xl/xl.c                         |  8 ++++++++
 tools/xl/xl.h                         |  2 ++
 tools/xl/xl_parse.c                   | 16 ++++++++++++++++
 xen/arch/x86/domain.c                 | 28 +++++++++++++++++++++++++++-
 xen/arch/x86/hvm/vmx/vmcs.c           |  4 ++++
 xen/arch/x86/hvm/vmx/vmx.c            | 14 +++++---------
 xen/arch/x86/include/asm/hvm/domain.h |  6 ++++++
 xen/arch/x86/traps.c                  |  8 ++++----
 xen/include/public/arch-x86/xen.h     |  2 ++
 21 files changed, 173 insertions(+), 30 deletions(-)

diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in
index b98d161398..1d98bbd182 100644
--- a/docs/man/xl.cfg.5.pod.in
+++ b/docs/man/xl.cfg.5.pod.in
@@ -1862,6 +1862,16 @@ firmware tables when using certain older guest Operating
 Systems. These tables have been superseded by newer constructs within
 the ACPI tables.
 
+=item B<assisted_xAPIC=BOOLEAN>
+B<(x86 only)> Enables or disables hardware assisted virtualization for xapic.
+This allows accessing APIC registers without a VM-exit.
+The default is settable via L<xl.conf(5)>.
+
+=item B<assisted_x2APIC=BOOLEAN>
+B<(x86 only)> Enables or disables hardware assisted virtualization for x2apic.
+This allows accessing APIC registers without a VM-exit.
+The default is settable via L<xl.conf(5)>.
+
 =item B<nx=BOOLEAN>
 
 B<(x86 only)> Hides or exposes the No-eXecute capability. This allows a guest
diff --git a/docs/man/xl.conf.5.pod.in b/docs/man/xl.conf.5.pod.in
index df20c08137..30993827e5 100644
--- a/docs/man/xl.conf.5.pod.in
+++ b/docs/man/xl.conf.5.pod.in
@@ -107,6 +107,18 @@ Sets the default value for the C<max_grant_version> domain config value.
 
 Default: maximum grant version supported by the hypervisor.
 
+=item B<assisted_xAPIC=BOOLEAN>
+
+If enabled, domains will use xAPIC hardware assisted virtualization by default.
+
+Default: enabled if supported.
+
+=item B<assisted_x2APIC=BOOLEAN>
+
+If enabled, domains will use x2APIC hardware assisted virtualization by default.
+
+Default: enabled if supported.
+
 =item B<vif.default.script="PATH">
 
 Configures the default hotplug script used by virtual network devices.
diff --git a/tools/golang/xenlight/helpers.gen.go b/tools/golang/xenlight/helpers.gen.go
index dd4e6c9f14..90e7b9b205 100644
--- a/tools/golang/xenlight/helpers.gen.go
+++ b/tools/golang/xenlight/helpers.gen.go
@@ -636,6 +636,12 @@ x.Passthrough = Passthrough(xc.passthrough)
 if err := x.XendSuspendEvtchnCompat.fromC(&xc.xend_suspend_evtchn_compat);err != nil {
 return fmt.Errorf("converting field XendSuspendEvtchnCompat: %v", err)
 }
+if err := x.ArchX86.AssistedXapic.fromC(&xc.arch_x86.assisted_xapic);err != nil {
+return fmt.Errorf("converting field ArchX86.AssistedXapic: %v", err)
+}
+if err := x.ArchX86.AssistedX2Apic.fromC(&xc.arch_x86.assisted_x2apic);err != nil {
+return fmt.Errorf("converting field ArchX86.AssistedX2Apic: %v", err)
+}
 
  return nil}
 
@@ -679,6 +685,12 @@ xc.passthrough = C.libxl_passthrough(x.Passthrough)
 if err := x.XendSuspendEvtchnCompat.toC(&xc.xend_suspend_evtchn_compat); err != nil {
 return fmt.Errorf("converting field XendSuspendEvtchnCompat: %v", err)
 }
+if err := x.ArchX86.AssistedXapic.toC(&xc.arch_x86.assisted_xapic); err != nil {
+return fmt.Errorf("converting field ArchX86.AssistedXapic: %v", err)
+}
+if err := x.ArchX86.AssistedX2Apic.toC(&xc.arch_x86.assisted_x2apic); err != nil {
+return fmt.Errorf("converting field ArchX86.AssistedX2Apic: %v", err)
+}
 
  return nil
  }
diff --git a/tools/include/libxl.h b/tools/include/libxl.h
index 924e142628..83944c17ae 100644
--- a/tools/include/libxl.h
+++ b/tools/include/libxl.h
@@ -535,6 +535,13 @@
 #define LIBXL_HAVE_PHYSINFO_ASSISTED_APIC 1
 
 /*
+ * LIBXL_HAVE_ASSISTED_APIC indicates that libxl_domain_build_info has
+ * assisted_x{2}apic fields, for enabling hardware assisted virtualization for
+ * x{2}apic per domain.
+ */
+#define LIBXL_HAVE_ASSISTED_APIC 1
+
+/*
  * libxl ABI compatibility
  *
  * The only guarantee which libxl makes regarding ABI compatibility
diff --git a/tools/libs/light/libxl_arch.h b/tools/libs/light/libxl_arch.h
index 207ceac6a1..03b89929e6 100644
--- a/tools/libs/light/libxl_arch.h
+++ b/tools/libs/light/libxl_arch.h
@@ -71,8 +71,9 @@ void libxl__arch_domain_create_info_setdefault(libxl__gc *gc,
                                                libxl_domain_create_info *c_info);
 
 _hidden
-void libxl__arch_domain_build_info_setdefault(libxl__gc *gc,
-                                              libxl_domain_build_info *b_info);
+int libxl__arch_domain_build_info_setdefault(libxl__gc *gc,
+                                             libxl_domain_build_info *b_info,
+                                             const libxl_physinfo *physinfo);
 
 _hidden
 int libxl__arch_passthrough_mode_setdefault(libxl__gc *gc,
diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c
index 39fdca1b49..ba5b8f433f 100644
--- a/tools/libs/light/libxl_arm.c
+++ b/tools/libs/light/libxl_arm.c
@@ -1384,8 +1384,9 @@ void libxl__arch_domain_create_info_setdefault(libxl__gc *gc,
     }
 }
 
-void libxl__arch_domain_build_info_setdefault(libxl__gc *gc,
-                                              libxl_domain_build_info *b_info)
+int libxl__arch_domain_build_info_setdefault(libxl__gc *gc,
+                                             libxl_domain_build_info *b_info,
+                                             const libxl_physinfo *physinfo)
 {
     /* ACPI is disabled by default */
     libxl_defbool_setdefault(&b_info->acpi, false);
@@ -1399,6 +1400,8 @@ void libxl__arch_domain_build_info_setdefault(libxl__gc *gc,
     memset(&b_info->u, '\0', sizeof(b_info->u));
     b_info->type = LIBXL_DOMAIN_TYPE_INVALID;
     libxl_domain_build_info_init_type(b_info, LIBXL_DOMAIN_TYPE_PVH);
+
+    return 0;
 }
 
 int libxl__arch_passthrough_mode_setdefault(libxl__gc *gc,
diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_create.c
index d7a40d7550..843e523df9 100644
--- a/tools/libs/light/libxl_create.c
+++ b/tools/libs/light/libxl_create.c
@@ -264,7 +264,20 @@ int libxl__domain_build_info_setdefault(libxl__gc *gc,
     if (!b_info->event_channels)
         b_info->event_channels = 1023;
 
-    libxl__arch_domain_build_info_setdefault(gc, b_info);
+    libxl_physinfo info;
+
+    rc = libxl_get_physinfo(CTX, &info);
+    if (rc) {
+        LOG(ERROR, "failed to get hypervisor info");
+        return rc;
+    }
+
+    rc = libxl__arch_domain_build_info_setdefault(gc, b_info, &info);
+    if (rc) {
+        LOG(ERROR, "unable to set domain arch build info defaults");
+        return rc;
+    }
+
     libxl_defbool_setdefault(&b_info->dm_restrict, false);
 
     if (b_info->iommu_memkb == LIBXL_MEMKB_DEFAULT)
@@ -457,14 +470,6 @@ int libxl__domain_build_info_setdefault(libxl__gc *gc,
     }
 
     if (b_info->max_grant_version == LIBXL_MAX_GRANT_DEFAULT) {
-        libxl_physinfo info;
-
-        rc = libxl_get_physinfo(CTX, &info);
-        if (rc) {
-            LOG(ERROR, "failed to get hypervisor info");
-            return rc;
-        }
-
         if (info.cap_gnttab_v2)
             b_info->max_grant_version = 2;
         else if (info.cap_gnttab_v1)
diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl
index 42ac6c357b..db5eb0a0b3 100644
--- a/tools/libs/light/libxl_types.idl
+++ b/tools/libs/light/libxl_types.idl
@@ -648,6 +648,8 @@ libxl_domain_build_info = Struct("domain_build_info",[
                                ("vuart", libxl_vuart_type),
                               ])),
     ("arch_x86", Struct(None, [("msr_relaxed", libxl_defbool),
+                               ("assisted_xapic", libxl_defbool),
+                               ("assisted_x2apic", libxl_defbool),
                               ])),
     # Alternate p2m is not bound to any architecture or guest type, as it is
     # supported by x86 HVM and ARM support is planned.
diff --git a/tools/libs/light/libxl_x86.c b/tools/libs/light/libxl_x86.c
index e0a06ecfe3..f0fa0ceea2 100644
--- a/tools/libs/light/libxl_x86.c
+++ b/tools/libs/light/libxl_x86.c
@@ -23,6 +23,14 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc,
     if (libxl_defbool_val(d_config->b_info.arch_x86.msr_relaxed))
         config->arch.misc_flags |= XEN_X86_MSR_RELAXED;
 
+    if (d_config->c_info.type != LIBXL_DOMAIN_TYPE_PV)
+    {
+        if (libxl_defbool_val(d_config->b_info.arch_x86.assisted_xapic))
+            config->arch.misc_flags |= XEN_X86_ASSISTED_XAPIC;
+
+        if (libxl_defbool_val(d_config->b_info.arch_x86.assisted_x2apic))
+            config->arch.misc_flags |= XEN_X86_ASSISTED_X2APIC;
+    }
     return 0;
 }
 
@@ -819,11 +827,30 @@ void libxl__arch_domain_create_info_setdefault(libxl__gc *gc,
 {
 }
 
-void libxl__arch_domain_build_info_setdefault(libxl__gc *gc,
-                                              libxl_domain_build_info *b_info)
+int libxl__arch_domain_build_info_setdefault(libxl__gc *gc,
+                                             libxl_domain_build_info *b_info,
+                                             const libxl_physinfo *physinfo)
 {
     libxl_defbool_setdefault(&b_info->acpi, true);
     libxl_defbool_setdefault(&b_info->arch_x86.msr_relaxed, false);
+
+    if (b_info->type != LIBXL_DOMAIN_TYPE_PV)
+    {
+        libxl_defbool_setdefault(&b_info->arch_x86.assisted_xapic,
+                             physinfo->cap_assisted_xapic);
+        libxl_defbool_setdefault(&b_info->arch_x86.assisted_x2apic,
+                             physinfo->cap_assisted_x2apic);
+    }
+
+    if (b_info->type == LIBXL_DOMAIN_TYPE_PV &&
+        (!libxl_defbool_is_default(b_info->arch_x86.assisted_xapic) ||
+         !libxl_defbool_is_default(b_info->arch_x86.assisted_x2apic)))
+    {
+        LOG(ERROR, "Interrupt Controller Virtualization not supported for PV");
+        return ERROR_INVAL;
+    }
+
+    return 0;
 }
 
 int libxl__arch_passthrough_mode_setdefault(libxl__gc *gc,
diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl.ml
index 7ce832d605..cce30d8731 100644
--- a/tools/ocaml/libs/xc/xenctrl.ml
+++ b/tools/ocaml/libs/xc/xenctrl.ml
@@ -50,6 +50,8 @@ type x86_arch_emulation_flags =
 
 type x86_arch_misc_flags =
 	| X86_MSR_RELAXED
+	| X86_ASSISTED_XAPIC
+	| X86_ASSISTED_X2APIC
 
 type xen_x86_arch_domainconfig =
 {
diff --git a/tools/ocaml/libs/xc/xenctrl.mli b/tools/ocaml/libs/xc/xenctrl.mli
index a2b15130ee..67a22ec15c 100644
--- a/tools/ocaml/libs/xc/xenctrl.mli
+++ b/tools/ocaml/libs/xc/xenctrl.mli
@@ -44,6 +44,8 @@ type x86_arch_emulation_flags =
 
 type x86_arch_misc_flags =
   | X86_MSR_RELAXED
+  | X86_ASSISTED_XAPIC
+  | X86_ASSISTED_X2APIC
 
 type xen_x86_arch_domainconfig = {
   emulation_flags: x86_arch_emulation_flags list;
diff --git a/tools/ocaml/libs/xc/xenctrl_stubs.c b/tools/ocaml/libs/xc/xenctrl_stubs.c
index 5b4fe72c8d..0aa957d379 100644
--- a/tools/ocaml/libs/xc/xenctrl_stubs.c
+++ b/tools/ocaml/libs/xc/xenctrl_stubs.c
@@ -239,7 +239,7 @@ CAMLprim value stub_xc_domain_create(value xch, value wanted_domid, value config
 
 		cfg.arch.misc_flags = ocaml_list_to_c_bitmap
 			/* ! x86_arch_misc_flags X86_ none */
-			/* ! XEN_X86_ XEN_X86_MSR_RELAXED all */
+			/* ! XEN_X86_ XEN_X86_ASSISTED_X2APIC max */
 			(VAL_MISC_FLAGS);
 
 #undef VAL_MISC_FLAGS
diff --git a/tools/xl/xl.c b/tools/xl/xl.c
index 2d1ec18ea3..31eb223309 100644
--- a/tools/xl/xl.c
+++ b/tools/xl/xl.c
@@ -57,6 +57,8 @@ int max_grant_frames = -1;
 int max_maptrack_frames = -1;
 int max_grant_version = LIBXL_MAX_GRANT_DEFAULT;
 libxl_domid domid_policy = INVALID_DOMID;
+int assisted_xapic = -1;
+int assisted_x2apic = -1;
 
 xentoollog_level minmsglevel = minmsglevel_default;
 
@@ -201,6 +203,12 @@ static void parse_global_config(const char *configfile,
     if (!xlu_cfg_get_long (config, "claim_mode", &l, 0))
         claim_mode = l;
 
+    if (!xlu_cfg_get_long (config, "assisted_xapic", &l, 0))
+        assisted_xapic = l;
+
+    if (!xlu_cfg_get_long (config, "assisted_x2apic", &l, 0))
+        assisted_x2apic = l;
+
     xlu_cfg_replace_string (config, "remus.default.netbufscript",
         &default_remus_netbufscript, 0);
     xlu_cfg_replace_string (config, "colo.default.proxyscript",
diff --git a/tools/xl/xl.h b/tools/xl/xl.h
index c5c4bedbdd..528deb3feb 100644
--- a/tools/xl/xl.h
+++ b/tools/xl/xl.h
@@ -286,6 +286,8 @@ extern libxl_bitmap global_vm_affinity_mask;
 extern libxl_bitmap global_hvm_affinity_mask;
 extern libxl_bitmap global_pv_affinity_mask;
 extern libxl_domid domid_policy;
+extern int assisted_xapic;
+extern int assisted_x2apic;
 
 enum output_format {
     OUTPUT_FORMAT_JSON,
diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c
index 117fcdcb2b..0ab9b145fe 100644
--- a/tools/xl/xl_parse.c
+++ b/tools/xl/xl_parse.c
@@ -1681,6 +1681,22 @@ void parse_config_data(const char *config_source,
         xlu_cfg_get_defbool(config, "vpt_align", &b_info->u.hvm.vpt_align, 0);
         xlu_cfg_get_defbool(config, "apic", &b_info->apic, 0);
 
+        e = xlu_cfg_get_long(config, "assisted_xapic", &l , 0);
+        if ((e == ESRCH && assisted_xapic != -1)) /* use global default if present */
+            libxl_defbool_set(&b_info->arch_x86.assisted_xapic, assisted_xapic);
+        else if (!e)
+            libxl_defbool_set(&b_info->arch_x86.assisted_xapic, l);
+        else
+            exit(1);
+
+        e = xlu_cfg_get_long(config, "assisted_x2apic", &l, 0);
+        if ((e == ESRCH && assisted_x2apic != -1)) /* use global default if present */
+            libxl_defbool_set(&b_info->arch_x86.assisted_x2apic, assisted_x2apic);
+        else if (!e)
+            libxl_defbool_set(&b_info->arch_x86.assisted_x2apic, l);
+        else
+            exit(1);
+
         switch (xlu_cfg_get_list(config, "viridian",
                                  &viridian, &num_viridian, 1))
         {
diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c
index ef1812dc14..9033a0e181 100644
--- a/xen/arch/x86/domain.c
+++ b/xen/arch/x86/domain.c
@@ -619,6 +619,8 @@ int arch_sanitise_domain_config(struct xen_domctl_createdomain *config)
     bool hvm = config->flags & XEN_DOMCTL_CDF_hvm;
     bool hap = config->flags & XEN_DOMCTL_CDF_hap;
     bool nested_virt = config->flags & XEN_DOMCTL_CDF_nested_virt;
+    bool assisted_xapic = config->arch.misc_flags & XEN_X86_ASSISTED_XAPIC;
+    bool assisted_x2apic = config->arch.misc_flags & XEN_X86_ASSISTED_X2APIC;
     unsigned int max_vcpus;
 
     if ( hvm ? !hvm_enabled : !IS_ENABLED(CONFIG_PV) )
@@ -685,13 +687,31 @@ int arch_sanitise_domain_config(struct xen_domctl_createdomain *config)
         }
     }
 
-    if ( config->arch.misc_flags & ~XEN_X86_MSR_RELAXED )
+    if ( config->arch.misc_flags & ~(XEN_X86_MSR_RELAXED |
+                                     XEN_X86_ASSISTED_XAPIC |
+                                     XEN_X86_ASSISTED_X2APIC) )
     {
         dprintk(XENLOG_INFO, "Invalid arch misc flags %#x\n",
                 config->arch.misc_flags);
         return -EINVAL;
     }
 
+    if ( (assisted_xapic || assisted_x2apic) && !hvm )
+    {
+        dprintk(XENLOG_INFO,
+                "Interrupt Controller Virtualization not supported for PV\n");
+        return -EINVAL;
+    }
+
+    if ( (assisted_xapic && !assisted_xapic_available) ||
+         (assisted_x2apic && !assisted_x2apic_available) )
+    {
+        dprintk(XENLOG_INFO,
+                "Hardware assisted x%sAPIC requested but not available\n",
+                assisted_xapic && !assisted_xapic_available ? "" : "2");
+        return -EINVAL;
+    }
+
     return 0;
 }
 
@@ -863,6 +883,12 @@ int arch_domain_create(struct domain *d,
 
     d->arch.msr_relaxed = config->arch.misc_flags & XEN_X86_MSR_RELAXED;
 
+    d->arch.hvm.assisted_xapic =
+        config->arch.misc_flags & XEN_X86_ASSISTED_XAPIC;
+
+    d->arch.hvm.assisted_x2apic =
+        config->arch.misc_flags & XEN_X86_ASSISTED_X2APIC;
+
     return 0;
 
  fail:
diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c
index 4060aef1bd..614db5c4a4 100644
--- a/xen/arch/x86/hvm/vmx/vmcs.c
+++ b/xen/arch/x86/hvm/vmx/vmcs.c
@@ -1157,6 +1157,10 @@ static int construct_vmcs(struct vcpu *v)
         __vmwrite(PLE_WINDOW, ple_window);
     }
 
+    if ( !v->domain->arch.hvm.assisted_xapic )
+        v->arch.hvm.vmx.secondary_exec_control &=
+            ~SECONDARY_EXEC_VIRTUALIZE_APIC_ACCESSES;
+
     if ( cpu_has_vmx_secondary_exec_control )
         __vmwrite(SECONDARY_VM_EXEC_CONTROL,
                   v->arch.hvm.vmx.secondary_exec_control);
diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c
index 36c8a12cfe..3c9ff60154 100644
--- a/xen/arch/x86/hvm/vmx/vmx.c
+++ b/xen/arch/x86/hvm/vmx/vmx.c
@@ -3333,16 +3333,11 @@ static void vmx_install_vlapic_mapping(struct vcpu *v)
 
 void vmx_vlapic_msr_changed(struct vcpu *v)
 {
-    int virtualize_x2apic_mode;
     struct vlapic *vlapic = vcpu_vlapic(v);
     unsigned int msr;
 
-    virtualize_x2apic_mode = ( (cpu_has_vmx_apic_reg_virt ||
-                                cpu_has_vmx_virtual_intr_delivery) &&
-                               cpu_has_vmx_virtualize_x2apic_mode );
-
-    if ( !cpu_has_vmx_virtualize_apic_accesses &&
-         !virtualize_x2apic_mode )
+    if ( ! v->domain->arch.hvm.assisted_xapic &&
+         ! v->domain->arch.hvm.assisted_x2apic )
         return;
 
     vmx_vmcs_enter(v);
@@ -3352,7 +3347,8 @@ void vmx_vlapic_msr_changed(struct vcpu *v)
     if ( !vlapic_hw_disabled(vlapic) &&
          (vlapic_base_address(vlapic) == APIC_DEFAULT_PHYS_BASE) )
     {
-        if ( virtualize_x2apic_mode && vlapic_x2apic_mode(vlapic) )
+        if ( v->domain->arch.hvm.assisted_x2apic
+             && vlapic_x2apic_mode(vlapic) )
         {
             v->arch.hvm.vmx.secondary_exec_control |=
                 SECONDARY_EXEC_VIRTUALIZE_X2APIC_MODE;
@@ -3373,7 +3369,7 @@ void vmx_vlapic_msr_changed(struct vcpu *v)
                 vmx_clear_msr_intercept(v, MSR_X2APIC_SELF, VMX_MSR_W);
             }
         }
-        else
+        else if ( v->domain->arch.hvm.assisted_xapic )
             v->arch.hvm.vmx.secondary_exec_control |=
                 SECONDARY_EXEC_VIRTUALIZE_APIC_ACCESSES;
     }
diff --git a/xen/arch/x86/include/asm/hvm/domain.h b/xen/arch/x86/include/asm/hvm/domain.h
index 698455444e..92bf53483c 100644
--- a/xen/arch/x86/include/asm/hvm/domain.h
+++ b/xen/arch/x86/include/asm/hvm/domain.h
@@ -117,6 +117,12 @@ struct hvm_domain {
 
     bool                   is_s3_suspended;
 
+    /* xAPIC hardware assisted virtualization. */
+    bool                   assisted_xapic;
+
+    /* x2APIC hardware assisted virtualization. */
+    bool                   assisted_x2apic;
+
     /* hypervisor intercepted msix table */
     struct list_head       msixtbl_list;
 
diff --git a/xen/arch/x86/traps.c b/xen/arch/x86/traps.c
index 485bd66971..33694acc99 100644
--- a/xen/arch/x86/traps.c
+++ b/xen/arch/x86/traps.c
@@ -1115,7 +1115,8 @@ void cpuid_hypervisor_leaves(const struct vcpu *v, uint32_t leaf,
         if ( !is_hvm_domain(d) || subleaf != 0 )
             break;
 
-        if ( cpu_has_vmx_apic_reg_virt )
+        if ( cpu_has_vmx_apic_reg_virt &&
+             v->domain->arch.hvm.assisted_xapic )
             res->a |= XEN_HVM_CPUID_APIC_ACCESS_VIRT;
 
         /*
@@ -1124,9 +1125,8 @@ void cpuid_hypervisor_leaves(const struct vcpu *v, uint32_t leaf,
          * and wrmsr in the guest will run without VMEXITs (see
          * vmx_vlapic_msr_changed()).
          */
-        if ( cpu_has_vmx_virtualize_x2apic_mode &&
-             cpu_has_vmx_apic_reg_virt &&
-             cpu_has_vmx_virtual_intr_delivery )
+        if ( (cpu_has_vmx_apic_reg_virt && cpu_has_vmx_virtual_intr_delivery) &&
+             v->domain->arch.hvm.assisted_x2apic )
             res->a |= XEN_HVM_CPUID_X2APIC_VIRT;
 
         /*
diff --git a/xen/include/public/arch-x86/xen.h b/xen/include/public/arch-x86/xen.h
index 7acd94c8eb..9da32c6239 100644
--- a/xen/include/public/arch-x86/xen.h
+++ b/xen/include/public/arch-x86/xen.h
@@ -317,6 +317,8 @@ struct xen_arch_domainconfig {
  * doesn't allow the guest to read or write to the underlying MSR.
  */
 #define XEN_X86_MSR_RELAXED (1u << 0)
+#define XEN_X86_ASSISTED_XAPIC (1u << 1)
+#define XEN_X86_ASSISTED_X2APIC (1u << 2)
     uint32_t misc_flags;
 };
 
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 07 18:53:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 18:53:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267391.461134 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH98K-00085r-LU; Mon, 07 Feb 2022 18:53:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267391.461134; Mon, 07 Feb 2022 18:53:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH98K-00085k-I3; Mon, 07 Feb 2022 18:53:04 +0000
Received: by outflank-mailman (input) for mailman id 267391;
 Mon, 07 Feb 2022 18:53:02 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nH98I-00085e-Hb
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 18:53:02 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nH98F-00022N-9f; Mon, 07 Feb 2022 18:52:59 +0000
Received: from 54-240-197-226.amazon.com ([54.240.197.226] helo=[10.85.34.134])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nH98F-0004OE-2D; Mon, 07 Feb 2022 18:52:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=LjFK9kSn+qCo144a/hzlwdWrolI/1oXV5tiXZ6qnNj0=; b=CH3gxZ1fGL+Go86DUviSW7ZGc2
	HCxXwXCX7VtYwrJThxvZOpMltgLDpzfwdCP7/Rhq5WaW+1QPjS6VKFj2jbx7pGFgg/gYOuUSR+W4w
	9Sto+CGkgpGswIskjCbi/6QR59wO9ka8/fki6K79NpIh0pKxZnXdgEzGLyqIMs7eqQsM=;
Message-ID: <26cdd9cf-15d6-a463-b1bb-28964005f618@xen.org>
Date: Mon, 7 Feb 2022 18:52:57 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.1
Subject: Re: [PATCH RFC 1/3] xen/efi: Always query the console information and
 get GOP
To: Jan Beulich <jbeulich@suse.com>
Cc: ehem+xen@m5p.com, Julien Grall <jgrall@amazon.com>,
 xen-devel@lists.xenproject.org, Daniel Kiper <daniel.kiper@oracle.com>
References: <20220206192839.75711-1-julien@xen.org>
 <20220206192839.75711-2-julien@xen.org>
 <88741681-929f-4cda-e841-023bdbf8f772@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <88741681-929f-4cda-e841-023bdbf8f772@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Jan,

On 07/02/2022 08:46, Jan Beulich wrote:
> On 06.02.2022 20:28, Julien Grall wrote:
>> From: Julien Grall <jgrall@amazon.com>
>>
>> Currently, the EFI stub will only query the console information and
>> get the GOP when using the configuration file.
>>
>> However, GRUB is never providing the a configuration file. So the
>> EFI framebuffer will not be usable at least on Arm (support will
>> be added in a follow-up patch).
>>
>> Move out the code outside of the configuration file section.
>>
>> Take the opportunity to remove the variable 'size' which was
>> set but never used (interestingly GCC is only complaining if it is
>> initialization when declaring the variable).
>>
>> With this change, GCC 8.3 will complain of argc potentially been
>> used unitiatlized. I suspect this is because the argc will
>> be iniitalized and used in a different if code-blocks. Yet they
>> are using the same check.
> 
> I'm inclined to suggest this wants to be a separate change, with its
> own justification. You're not touching any use of argc here, after
> all.

Ok. I will split it.

> 
>> Signed-off-by: Julien Grall <jgrall@amazon.com>
>>
>> ----
>>
>> It is not entirely clear to me why the GOP was only fetched when
>> the configuration file is used.
>>
>> I have tested this on RPI4 and it seems to work. Any chance this
>> was done to workaround an x86 platform?
> 
> This was done so in the context of making the code work for Arm. See
> commit c38cf865ec82 ("EFI: ignore EFI commandline, skip console setup
> when booted from GRUB"), the description of which explicitly says
> 
> "Don't do EFI console or video configuration when booted by GRUB.  The EFI boot
>   code does some console and video initialization to support native EFI boot from
>   the EFI boot manager or EFI shell.  This initlization should not be done when
>   booted using GRUB."

I read that and still couldn't figure out why this was done like that.

> 
> What you say now is effectively the opposite (and unlike back then
> x86 is now able to use this code path as well, so needs considering
> too). Cc-ing Daniel for possibly having a GrUB-side opinion.

I am quite interested to know the answer. Linux is able to use the EFI 
framebuffer when booting via GRUB. So I am a bit puzzled why we are 
preventing this setup on dom0/Xen.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Feb 07 18:56:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 18:56:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267399.461144 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH9BI-0000G7-3x; Mon, 07 Feb 2022 18:56:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267399.461144; Mon, 07 Feb 2022 18:56:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH9BI-0000G0-0q; Mon, 07 Feb 2022 18:56:08 +0000
Received: by outflank-mailman (input) for mailman id 267399;
 Mon, 07 Feb 2022 18:56:07 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nH9BH-0000Fu-4E
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 18:56:07 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nH9B8-00025U-3B; Mon, 07 Feb 2022 18:55:58 +0000
Received: from 54-240-197-226.amazon.com ([54.240.197.226] helo=[10.85.34.134])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nH9B7-0004kB-T8; Mon, 07 Feb 2022 18:55:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=PvXddK7ZLsr1uVljwtgdIfh5FouFoHEvfXArANRrzWc=; b=EwAk9gWqppOalFZZpA0XFh6o88
	EdlRweI7hCIiA9XZFThkoiT4V6l2ke/mgos0ksAtAxs/FijevmQUYVBuci7B9WjgMMPC8LFgxt7bc
	orGCJ9Zhe2vNTSSk7AxOpdGu8y0rfywNQP/jzwPeN7t1ktP8oRhK8Lu8V6MtBDjbwimQ=;
Message-ID: <adabf0a7-63b6-6c3b-2701-408848f30261@xen.org>
Date: Mon, 7 Feb 2022 18:55:55 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.1
Subject: Re: [PATCH RFC 2/3] xen/arm: efi: Introduce and fill the
 vga_console_info
To: Jan Beulich <jbeulich@suse.com>
Cc: ehem+xen@m5p.com, Julien Grall <jgrall@amazon.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 xen-devel@lists.xenproject.org
References: <20220206192839.75711-1-julien@xen.org>
 <20220206192839.75711-3-julien@xen.org>
 <6249db03-01b5-e1bb-75ad-5946e16f639d@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <6249db03-01b5-e1bb-75ad-5946e16f639d@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 07/02/2022 08:53, Jan Beulich wrote:
> On 06.02.2022 20:28, Julien Grall wrote:
>> From: Julien Grall <jgrall@amazon.com>
>>
>> In a follow-up patch will we want to add support for EFI framebuffer
>> in dom0. Yet, Xen may not use the framebuffer, so it would be ideal
>> to not have to enable CONFIG_VIDEO/CONFIG_VGA.
>>
>> Introduce vga_console_info in a hacky way and move the code
>> to fill it up from x86 to common.
>>
>> Signed-off-by: Julien Grall <jgrall@amazon.com>
>>
>> ----
>>
>> This is a bit of a hack. Sent early to gather opinion on whether
>> we should enable allow Dom0 to use the EFI Framebuffer even
>> if Xen is built with CONFIG_VIDEO=n on Arm.
> 
> I have no input here; this will need to be settled among you Arm folks.
> I have no objection to the code movement, just one nit:
> 
>> @@ -1025,6 +1026,77 @@ static void __init efi_get_apple_properties(void)
>>       }
>>   }
>>   
>> +static void __init efi_video_init(EFI_GRAPHICS_OUTPUT_PROTOCOL *gop,
>> +                                  UINTN info_size,
>> +                                  EFI_GRAPHICS_OUTPUT_MODE_INFORMATION *mode_info)
>> +{
>> +#if defined(CONFIG_VIDEO) || defined(CONFIG_ARM)
>> +    int bpp = 0;
>> +
>> +    switch ( mode_info->PixelFormat )
>> +    {
>> +    case PixelRedGreenBlueReserved8BitPerColor:
>> +        vga_console_info.u.vesa_lfb.red_pos = 0;
>> +        vga_console_info.u.vesa_lfb.red_size = 8;
>> +        vga_console_info.u.vesa_lfb.green_pos = 8;
>> +        vga_console_info.u.vesa_lfb.green_size = 8;
>> +        vga_console_info.u.vesa_lfb.blue_pos = 16;
>> +        vga_console_info.u.vesa_lfb.blue_size = 8;
>> +        vga_console_info.u.vesa_lfb.rsvd_pos = 24;
>> +        vga_console_info.u.vesa_lfb.rsvd_size = 8;
>> +        bpp = 32;
>> +        break;
>> +    case PixelBlueGreenRedReserved8BitPerColor:
>> +        vga_console_info.u.vesa_lfb.red_pos = 16;
>> +        vga_console_info.u.vesa_lfb.red_size = 8;
>> +        vga_console_info.u.vesa_lfb.green_pos = 8;
>> +        vga_console_info.u.vesa_lfb.green_size = 8;
>> +        vga_console_info.u.vesa_lfb.blue_pos = 0;
>> +        vga_console_info.u.vesa_lfb.blue_size = 8;
>> +        vga_console_info.u.vesa_lfb.rsvd_pos = 24;
>> +        vga_console_info.u.vesa_lfb.rsvd_size = 8;
>> +        bpp = 32;
>> +        break;
>> +    case PixelBitMask:
>> +        bpp = set_color(mode_info->PixelInformation.RedMask, bpp,
>> +                        &vga_console_info.u.vesa_lfb.red_pos,
>> +                        &vga_console_info.u.vesa_lfb.red_size);
>> +        bpp = set_color(mode_info->PixelInformation.GreenMask, bpp,
>> +                        &vga_console_info.u.vesa_lfb.green_pos,
>> +                        &vga_console_info.u.vesa_lfb.green_size);
>> +        bpp = set_color(mode_info->PixelInformation.BlueMask, bpp,
>> +                        &vga_console_info.u.vesa_lfb.blue_pos,
>> +                        &vga_console_info.u.vesa_lfb.blue_size);
>> +        if ( mode_info->PixelInformation.ReservedMask )
>> +            bpp = set_color(mode_info->PixelInformation.ReservedMask, bpp,
>> +                            &vga_console_info.u.vesa_lfb.rsvd_pos,
>> +                            &vga_console_info.u.vesa_lfb.rsvd_size);
>> +        if ( bpp > 0 )
>> +            break;
>> +        /* fall through */
>> +    default:
>> +        PrintErr(L"Current graphics mode is unsupported!\r\n");
>> +        bpp  = 0;
>> +        break;
>> +    }
>> +    if ( bpp > 0 )
>> +    {
>> +        vga_console_info.video_type = XEN_VGATYPE_EFI_LFB;
>> +        vga_console_info.u.vesa_lfb.gbl_caps = 2; /* possibly non-VGA */
>> +        vga_console_info.u.vesa_lfb.width =
>> +            mode_info->HorizontalResolution;
>> +        vga_console_info.u.vesa_lfb.height = mode_info->VerticalResolution;
>> +        vga_console_info.u.vesa_lfb.bits_per_pixel = bpp;
>> +        vga_console_info.u.vesa_lfb.bytes_per_line =
>> +            (mode_info->PixelsPerScanLine * bpp + 7) >> 3;
>> +        vga_console_info.u.vesa_lfb.lfb_base = gop->Mode->FrameBufferBase;
>> +        vga_console_info.u.vesa_lfb.ext_lfb_base = gop->Mode->FrameBufferBase >> 32;
>> +        vga_console_info.u.vesa_lfb.lfb_size =
>> +            (gop->Mode->FrameBufferSize + 0xffff) >> 16;
>> +    }
>> +#endif
>> +}
> 
> While you move this code, could you please insert blank lines between
> non-fall-through case blocks, and perhaps another one between the switch()
> and the if() blocks? And it looks like
> - the "gop" parameter could also do with becoming pointer-to-const,

I can do that.

> - the expanded #ifdef could do with a comment briefly explaining why Arm
>    needs-special casing.
Agree. I will wait input with the others regarding the #ifdef approach 
before respinning this patch.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Feb 07 19:24:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 19:24:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267412.461155 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH9cf-0003Y3-HJ; Mon, 07 Feb 2022 19:24:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267412.461155; Mon, 07 Feb 2022 19:24:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH9cf-0003Xw-EM; Mon, 07 Feb 2022 19:24:25 +0000
Received: by outflank-mailman (input) for mailman id 267412;
 Mon, 07 Feb 2022 19:24:24 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nH9ce-0003Xq-Lk
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 19:24:24 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nH9cU-0002c2-SF; Mon, 07 Feb 2022 19:24:14 +0000
Received: from 54-240-197-226.amazon.com ([54.240.197.226] helo=[10.85.34.134])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nH9cU-00070F-K7; Mon, 07 Feb 2022 19:24:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=p69XJ0hdfEN0/M4op2DGkrF+U6ZHhEPVTZpgEMa0jYk=; b=TjlYrBO7dtKPOj41w2ohexNTVL
	ur7gFugSDkj+zVbLECscrYTPXYBvrAp12UkL+dwyukbXdhO4aqg8uRWab3fIK7T3+uDSA1Js4cBGq
	Oq7mFyvEThJHvTEn6pYZ2KmFMeImwwqMF4PWID18tqt8nacrILPl8/Vi9o9WjY4e7eRA=;
Message-ID: <1bd5cef7-a83b-cd51-2ae1-ae2f6db00385@xen.org>
Date: Mon, 7 Feb 2022 19:24:12 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.1
Subject: Re: [PATCH RFC 3/3] xen: Introduce a platform sub-op to retrieve the
 VGA information
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Jan Beulich <jbeulich@suse.com>
Cc: ehem+xen@m5p.com, Julien Grall <jgrall@amazon.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220206192839.75711-1-julien@xen.org>
 <20220206192839.75711-4-julien@xen.org>
 <4da70949-7d6c-65a4-662a-301bb7075bc0@suse.com>
 <YgEJWLF/yp8YkU2M@Air-de-Roger>
From: Julien Grall <julien@xen.org>
In-Reply-To: <YgEJWLF/yp8YkU2M@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Roger,

On 07/02/2022 11:58, Roger Pau Monné wrote:
> On Mon, Feb 07, 2022 at 09:57:55AM +0100, Jan Beulich wrote:
>> On 06.02.2022 20:28, Julien Grall wrote:
>>> From: Julien Grall <jgrall@amazon.com>
>>>
>>> When using EFI, the VGA information is fetched using the EFI
>>> boot services. However, Xen will have exited the boot services.
>>> Therefore, we need to find a different way to pass the information
>>> to dom0.
>>>
>>> For PV dom0, they are part of the start_info. But this is not
>>> something that exists on Arm. So the best way would to be to
>>> use a hypercall.
>>>
>>> For now the structure layout is based on dom0_vga_console_info
>>> for convenience. I am open on another proposal.
>>>
>>> Signed-off-by: Julien Grall <jgrall@amazon.com>
>>
>> Cc-ing Roger as this may want using for PVH Dom0 also on x86; my
>> first attempt to propagate this information was rejected.
> 
> I think it's easier to use a Xen specific layout in XENPF, as that's
> already a Xen specific interface.
> 
> I wonder however if passing the information here (instead of doing it
> in the start info or equivalent) could cause a delay in the
> initialization of the video console.

My current plan for Arm is to issue the hypercall as part of an 
earlyinit call. But we can do much earlier (i.e. xen_early_init() which 
is called from setup_arch()) if necessary.

This should be early enough for Arm. How about x86?

> I guess the same happens when
> using the Xen consoles (either the hypercall one or the shared ring),
> so it's fine.
> 
>>> --- a/xen/include/public/platform.h
>>> +++ b/xen/include/public/platform.h
>>> @@ -244,6 +244,7 @@ DEFINE_XEN_GUEST_HANDLE(xenpf_efi_runtime_call_t);
>>>   #define  XEN_FW_EFI_PCI_ROM        5
>>>   #define  XEN_FW_EFI_APPLE_PROPERTIES 6
>>>   #define XEN_FW_KBD_SHIFT_FLAGS    5
>>> +#define XEN_FW_VGA_INFO           6
>>
>> Perhaps s/VGA/VIDEO/, despite ...
>>
>>>   struct xenpf_firmware_info {
>>>       /* IN variables. */
>>>       uint32_t type;
>>> @@ -311,6 +312,7 @@ struct xenpf_firmware_info {
>>>   
>>>           /* Int16, Fn02: Get keyboard shift flags. */
>>>           uint8_t kbd_shift_flags; /* XEN_FW_KBD_SHIFT_FLAGS */
>>> +        struct dom0_vga_console_info vga;
>>
>> ... the structure name including "vga" (but if the #define is adjusted,
>> the field name would want to become "video" as well).
> 

[...]

(Re-ordered the quote as it makes more sense for my reply)

> There's no need to propagate XEN_VGATYPE_TEXT_MODE_3 into this
> interface.

So for Arm, we are only caring about XEN_VGATYPE_EFI_LFB. I wasn't sure 
what would be your need on x86. Hence, why I keep it.

If you don't need then, then I am happy to trim the structure for the 
new hypercall.

 > It's my understanding that this will forcefully be
 > XEN_VGATYPE_EFI_LFB, at which point we could consider giving a type
 > name to the vesa_lfb field of dom0_vga_console_info (video_lfb) and
 > use the same struct here?>

Just to clarify, are you suggesting to only pass video_lfb? IOW, we will 
always assume it is an EFI framebuffer and not pass the video_type.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Feb 07 19:35:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 19:35:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267421.461167 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH9mh-00052C-Fi; Mon, 07 Feb 2022 19:34:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267421.461167; Mon, 07 Feb 2022 19:34:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nH9mh-000525-Cm; Mon, 07 Feb 2022 19:34:47 +0000
Received: by outflank-mailman (input) for mailman id 267421;
 Mon, 07 Feb 2022 19:34:45 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nH9mf-00051s-P4; Mon, 07 Feb 2022 19:34:45 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nH9mf-0002mo-LX; Mon, 07 Feb 2022 19:34:45 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nH9me-00058M-VE; Mon, 07 Feb 2022 19:34:45 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nH9me-000770-UV; Mon, 07 Feb 2022 19:34:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=45saJKPgPvtaxFklVIyZ/aZ4Q+Y0sMyerXs5kGe4g7M=; b=KzXoEFoIUm3f+w76dqz1JcwJZO
	K5jQJA3oMuUYzO73zbG0PVNJD6WreHUpI2BPFv9dOGSNuhQl7/gFDYczKokKm1f9M0IVA4YylQTNu
	TyMQhspxVXzX+fUM4eKFFfmGBd2wuOVD2emxC8Z8u0NcbYUMMxCHvEMUqGyVFyveOGFg=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168048-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 168048: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=b360b0b589697da267f5d3a553e65635b91ebae2
X-Osstest-Versions-That:
    ovmf=1f54eaa725f45e0c66c28f8d47fa8fb33f7be52c
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 07 Feb 2022 19:34:44 +0000

flight 168048 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168048/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 b360b0b589697da267f5d3a553e65635b91ebae2
baseline version:
 ovmf                 1f54eaa725f45e0c66c28f8d47fa8fb33f7be52c

Last test of basis   168046  2022-02-07 14:11:34 Z    0 days
Testing same since   168048  2022-02-07 17:10:21 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Xiaoyu Lu <xiaoyu1.lu@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   1f54eaa725..b360b0b589  b360b0b589697da267f5d3a553e65635b91ebae2 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Mon Feb 07 21:39:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 21:39:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267439.461177 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHBj3-0007rU-EQ; Mon, 07 Feb 2022 21:39:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267439.461177; Mon, 07 Feb 2022 21:39:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHBj3-0007rN-BH; Mon, 07 Feb 2022 21:39:09 +0000
Received: by outflank-mailman (input) for mailman id 267439;
 Mon, 07 Feb 2022 21:39:08 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nHBj2-0007rD-0u; Mon, 07 Feb 2022 21:39:08 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nHBj1-0004wr-Ue; Mon, 07 Feb 2022 21:39:07 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nHBj1-0000Ef-Js; Mon, 07 Feb 2022 21:39:07 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nHBj1-0002zR-JP; Mon, 07 Feb 2022 21:39:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=lFDleFdCptV65roSxCS60aQ5sr4YviVcgtgb41ddk1E=; b=ZvOnDo9JD9N2SAQ383znfu4GMw
	7foV1bRWYInJhT3DiZ1PHrmT8sLnoQ7AZKPId3wcZlOJeNDMTPvAPyxiV6QbC66G+Wboql00De66N
	Crx0IwzBBnjerY7+DtigLjRFT3hib5v4nL1TMIl02COEJC39DWOdoFchWsP4m1nqZ+uY=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168049-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 168049: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=10d33220f2363a21a52a394159118ab4ddaed50e
X-Osstest-Versions-That:
    xen=820cc393434097f3b7976acdccbf1d96071d6d23
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 07 Feb 2022 21:39:07 +0000

flight 168049 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168049/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  10d33220f2363a21a52a394159118ab4ddaed50e
baseline version:
 xen                  820cc393434097f3b7976acdccbf1d96071d6d23

Last test of basis   168011  2022-02-04 16:01:44 Z    3 days
Testing same since   168049  2022-02-07 18:01:43 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Roger Pau Monne <roger.pau@citrix.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   820cc39343..10d33220f2  10d33220f2363a21a52a394159118ab4ddaed50e -> smoke


From xen-devel-bounces@lists.xenproject.org Mon Feb 07 22:22:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 07 Feb 2022 22:22:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267452.461189 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHCOn-0004LK-Ha; Mon, 07 Feb 2022 22:22:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267452.461189; Mon, 07 Feb 2022 22:22:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHCOn-0004LD-Da; Mon, 07 Feb 2022 22:22:17 +0000
Received: by outflank-mailman (input) for mailman id 267452;
 Mon, 07 Feb 2022 22:22:16 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nHCOm-0004L3-8A; Mon, 07 Feb 2022 22:22:16 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nHCOm-0005h7-3Y; Mon, 07 Feb 2022 22:22:16 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nHCOl-0002jf-Ie; Mon, 07 Feb 2022 22:22:15 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nHCOl-00055I-HD; Mon, 07 Feb 2022 22:22:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=3qIw+kaSV2ga2U9qPBW4QCDNFHJUaTpm0vQUF8E/f4A=; b=mOmx+Ac0hfFAxQ3PYpCoGZFX0J
	A9mu91ZASZlA9gZhSyEcfEJWjobGhu+8l77K0XMFRiddPmxObbtNkyhM/TtJ42ns7HQfY6i7L9vBb
	xIOlm/BNUc8wJLM02EUuxrf08Yg438EdoeRsHNj8Br0ZQP7tBQDrZva/YJfOBBaCRqAo=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168047-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 168047: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=55ef0b702bc2c90c3c4ed97f97676d8f139e5ca1
X-Osstest-Versions-That:
    qemuu=0d564a3e32ba8494014c67cdd2ebf0fb71860dff
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 07 Feb 2022 22:22:15 +0000

flight 168047 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168047/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168034
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168034
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168034
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168034
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168034
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168034
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168034
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168034
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                55ef0b702bc2c90c3c4ed97f97676d8f139e5ca1
baseline version:
 qemuu                0d564a3e32ba8494014c67cdd2ebf0fb71860dff

Last test of basis   168034  2022-02-06 18:38:21 Z    1 days
Testing same since   168047  2022-02-07 15:37:04 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Cameron Esfahani <dirty@apple.com>
  Laurent Vivier <laurent@vivier.eu>
  Patrick Venture <venture@google.com>
  Paul Brook <paul@nowt.org>
  Peter Maydell <peter.maydell@linaro.org>
  Serge Belyshev <belyshev@depni.sinp.msu.ru>
  Shu-Chun Weng <scw@google.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   0d564a3e32..55ef0b702b  55ef0b702bc2c90c3c4ed97f97676d8f139e5ca1 -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 00:16:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 00:16:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267467.461199 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHEBJ-0006ry-NL; Tue, 08 Feb 2022 00:16:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267467.461199; Tue, 08 Feb 2022 00:16:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHEBJ-0006rr-KJ; Tue, 08 Feb 2022 00:16:29 +0000
Received: by outflank-mailman (input) for mailman id 267467;
 Tue, 08 Feb 2022 00:16:27 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Yqj2=SX=xilinx.com=stefanos@srs-se1.protection.inumbo.net>)
 id 1nHEBH-0006rl-A7
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 00:16:27 +0000
Received: from NAM12-BN8-obe.outbound.protection.outlook.com
 (mail-bn8nam12on20608.outbound.protection.outlook.com
 [2a01:111:f400:fe5b::608])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 59181628-8874-11ec-8f75-fffcc8bd4f1a;
 Tue, 08 Feb 2022 01:16:25 +0100 (CET)
Received: from SN7PR04CA0039.namprd04.prod.outlook.com (2603:10b6:806:120::14)
 by SJ0PR02MB8467.namprd02.prod.outlook.com (2603:10b6:a03:3f7::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Tue, 8 Feb
 2022 00:16:21 +0000
Received: from SN1NAM02FT0047.eop-nam02.prod.protection.outlook.com
 (2603:10b6:806:120:cafe::64) by SN7PR04CA0039.outlook.office365.com
 (2603:10b6:806:120::14) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12 via Frontend
 Transport; Tue, 8 Feb 2022 00:16:21 +0000
Received: from xsj-pvapexch02.xlnx.xilinx.com (149.199.62.198) by
 SN1NAM02FT0047.mail.protection.outlook.com (10.97.5.120) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.4951.12 via Frontend Transport; Tue, 8 Feb 2022 00:16:20 +0000
Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by
 xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2176.14; Mon, 7 Feb 2022 16:16:02 -0800
Received: from smtp.xilinx.com (172.19.127.95) by
 xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id
 15.1.2176.14 via Frontend Transport; Mon, 7 Feb 2022 16:16:02 -0800
Received: from [10.23.120.145] (port=57738 helo=ubuntu-20.04.2-arm64.shared)
 by smtp.xilinx.com with esmtp (Exim 4.90)
 (envelope-from <stefano.stabellini@xilinx.com>)
 id 1nHEAs-0000aw-OH; Mon, 07 Feb 2022 16:16:02 -0800
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 59181628-8874-11ec-8f75-fffcc8bd4f1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=fC34V4nEzOc+yAZQN7mc2KehnIgytZNDmU7vNQbXiRJFgTM/p+nILlqPPsG5EOOE3/px/TNASriO80y8mzVRB5Ogik+OVhse0pqZvExPVxO/lOTmCbtnaNxr4UySE4Xlbfc/GRlhZZccOV1XQaTXaETTo7J8+MNFStEphr5u0Oxs3usBHKZAlbkvd1ZNakvzVaReuH+yqW3Y4kw0ast0Y5j2ua+zBQE6kkSlUcjA9QpLOAWatO+gWhVm9OK0c0nQv1bO0RPJSC7TzyR1yBItCOJDhg8I1wad3oqNLMTLoW+64m23cCZTxIzEwtcNe44fYcp+T1kXezd/n94v9C3awQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=E3cE+QEJk3oDCyfgnZSUOJPrIkDlMVuDo/g5tSaRvZQ=;
 b=dCaZF3GQrIdEJpSKSM5H+UMBrMLZe3FFFabbdMsb2XLcSGFTRct8G6rASlkA1/Rf5bFHb8EOXhmuxFgwgktXJaciKelLdgyOAG2eSyQmFofoJkfDfGM/PQdW8evCEcUIDrso5CBNI2KgYkyzxhS671t+SYQOSRkx+cTuQUFBG6esxuD21hFYI3qgZmnKROPIh+wL63Z3sV7NS0tzSqpf2vRoM5xEljA6lrLWOqd/O/e3oOYB+GH6teEHG1CkbXNC5waxm69h3fhc0eR/kvHuX9xSrQhlC3SFnMQ+DDircZ+vgHiXienseplZnhPs+2UTG7WTadjnd1m9uVkvgW/WZA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 149.199.62.198) smtp.rcpttodomain=linaro.org smtp.mailfrom=xilinx.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=E3cE+QEJk3oDCyfgnZSUOJPrIkDlMVuDo/g5tSaRvZQ=;
 b=hfqSCRviHjrNumr43W1/bZ3wG8VQ2+EtwvkY4Sk3IWvZdjYuxXn0rkal2GnBZT6dbyq3YImfm5N43odBL/D49Pn8/PtkGmxF7RoiCGZaExgcCzPc6YJsxWpSFyT8ZAyHTx7gUzSZ0ccJxuaqI2k92TKmsZRW/eAOp8pZnLGQgnQ=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198)
 smtp.mailfrom=xilinx.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=xilinx.com;
Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates
 149.199.62.198 as permitted sender) receiver=protection.outlook.com;
 client-ip=149.199.62.198; helo=xsj-pvapexch02.xlnx.xilinx.com;
Date: Mon, 7 Feb 2022 16:16:02 -0800
From: Stefano Stabellini <stefano.stabellini@xilinx.com>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: =?UTF-8?Q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>
CC: Stefano Stabellini <stefano.stabellini@xilinx.com>, Vincent Guittot
	<vincent.guittot@linaro.org>, <stratos-dev@op-lists.linaro.org>,
	<xen-devel@lists.xenproject.org>, AKASHI Takahiro
	<takahiro.akashi@linaro.org>, Arnd Bergmann <arnd.bergmann@linaro.org>,
	Christopher Clark <christopher.w.clark@gmail.com>, Dmytro Firsov
	<dmytro_firsov@epam.com>, Julien Grall <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, <Oleksandr_Tyshchenko@epam.com>,
	<Artem_Mygaiev@epam.com>, <bertrand.marquis@arm.com>, <Wei.Chen@arm.com>,
	<Ed.Doxat@arm.com>, <Oleksii_Moisieiev@epam.com>
Subject: Re: Metadata and signalling channels for Zephyr virtio-backends on
 Xen
In-Reply-To: <87h79bgd1m.fsf@linaro.org>
Message-ID: <alpine.DEB.2.22.394.2202071419270.2091381@ubuntu-linux-20-04-desktop>
References: <87h79bgd1m.fsf@linaro.org>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed;
	boundary="8323329-618230339-1644272516=:2091381"
Content-ID: <alpine.DEB.2.22.394.2202071422170.2091381@ubuntu-linux-20-04-desktop>
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 98622387-adad-41e0-1bc5-08d9ea983bcc
X-MS-TrafficTypeDiagnostic: SJ0PR02MB8467:EE_
X-Microsoft-Antispam-PRVS:
	<SJ0PR02MB8467B0FA374EE11A2088223BA02D9@SJ0PR02MB8467.namprd02.prod.outlook.com>
X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	+7jXePYhCFGO5My4ecuXhXQXt+H6A0p/OcAbkHwMKCi1fslCaw8B2Tqo1VHx86JwwwipwOf9dUrK+w85WlKjaWrTfvZQWxe5bqHHGBmIVhkkziMAegLDuHaX6G67+wrZRJMa+uCfUQ2MsJn1GY9qWoadmF5wkNW0Eh2celNl7Vm8bNi9/RXV0xdt5XKnjwHStAfCkxIwQaz6QQHNxqljifqYXbsipxYXJ/RSSfQBnGqR41+WD6kjHmm28X9jc5q8VKql4+hbOQ63N89jtquQ8W/Qn552N0xQxb6T4YxMC4/rQJFAMw587VAzYYx+XmnCfNy3YPdcILVEe/m9WQopPLeUs4KhduTknzfQASNIWF8j6MJZYU7YHP16Tirp5CJ8Z8WGcaHjag+iDFzuAMsK9WNeg8BB0tNzA/1yLzhIinWH86xeW157yREWOXX7s51dN4sz60qhUucjDcC2UrbfiGF7vOQpQeKof62kQQIMYA3YDWLYJIMuvMh2kjLEwRuq3BajasV6MoXS2xKra8Dno/Drbr6CDnR9uENl43zoIKbNrPXkyyuR17fWY1G9kJUrEDhg4x/g+KF01RABKffDdk6L/Dl994PQFv7KWFKv7qjCsCYW6HFCdi+7zh9sm0z2vbdzwcKFg4B7KTSdPqs6Vn49BaGfyoBKiQxvv+AF0PkEmcklBVV+ymyGE7cWfjhG2UBT7C2uJtnDvyk3+Gy4bVgoeEEHxXLgyUP3vQvw0HI=
X-Forefront-Antispam-Report:
	CIP:149.199.62.198;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:xsj-pvapexch02.xlnx.xilinx.com;PTR:unknown-62-198.xilinx.com;CAT:NONE;SFS:(13230001)(7916004)(4636009)(46966006)(36840700001)(508600001)(6916009)(9686003)(33964004)(316002)(2906002)(8676002)(44832011)(7416002)(4326008)(9786002)(8936002)(70206006)(5660300002)(70586007)(83380400001)(54906003)(356005)(82310400004)(966005)(47076005)(7636003)(36860700001)(33716001)(186003)(336012)(26005)(426003)(66574015);DIR:OUT;SFP:1101;
X-OriginatorOrg: xilinx.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2022 00:16:20.8015
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 98622387-adad-41e0-1bc5-08d9ea983bcc
X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch02.xlnx.xilinx.com]
X-MS-Exchange-CrossTenant-AuthSource:
	SN1NAM02FT0047.eop-nam02.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR02MB8467

--8323329-618230339-1644272516=:2091381
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Content-ID: <alpine.DEB.2.22.394.2202071422171.2091381@ubuntu-linux-20-04-desktop>

On Mon, 7 Feb 2022, Alex Bennée wrote:
> Hi Stefano,
> 
> Vincent gave an update on his virtio-scmi work at the last Stratos sync
> call and the discussion moved onto next steps.

Hi Alex,

I don't know the specifics of virtio-scmi, but if it is about power,
clocks, reset, etc. like the original SCMI protocol, then virtio-scmi is
likely going to be very different from all the other virtio frontends
and backends. That's because SCMI requires a full view of the system,
which is different from something like virtio-net that is limited to the
emulation of 1 device. For this reason, it is likely that the
virtio-scmi backend would be a better fit in Xen itself, rather than run
in userspace inside a VM.

FYI, a good and promising approach to handle both SCMI and SCPI is the
series recently submitted by EPAM to mediate SCMI and SCPI requests in
Xen: https://marc.info/?l=xen-devel&m=163947444032590

(Another "special" virtio backend is virtio-iommu for similar reasons:
the guest p2m address mappings and also the IOMMU drivers are in Xen.
It is not immediately clear whether a virtio-iommu backend would need to
be in Xen or run as a process in dom0/domU.)

On the other hand, for all the other "normal" protocols (e.g.
virtio-net, virtio-block, etc.) the backend would naturally run as a
process in dom0 or domU (e.g. QEMU in Dom0) as one would expect.


> Currently the demo setup
> is intermediated by a double-ended vhost-user daemon running on the
> devbox acting as a go between a number of QEMU instances representing
> the front and back-ends. You can view the architecture with Vincents
> diagram here:
> 
>   https://docs.google.com/drawings/d/1YSuJUSjEdTi2oEUq4oG4A9pBKSEJTAp6hhcHKKhmYHs/edit?usp=sharing
> 
> The key virtq handling is done over the special carve outs of shared
> memory between the front end and guest. However the signalling is
> currently over a virtio device on the backend. This is useful for the
> PoC but obviously in a real system we don't have a hidden POSIX system
> acting as a go between not to mention the additional latency it causes
> with all those context switches.
> 
> I was hoping we could get some more of the Xen experts to the next
> Stratos sync (17th Feb) to go over approaches for a properly hosted on
> Xen approach. From my recollection (Vincent please correct me if I'm
> wrong) of last week the issues that need solving are:

Unfortunately I have a regular conflict which prevents me from being
able to join the Stratos calls. However, I can certainly make myself
available for one call (unless something unexpected comes up).


>  * How to handle configuration steps as FE guests come up
> 
> The SCMI server will be a long running persistent backend because it is
> managing real HW resources. However the guests may be ephemeral (or just
> restarted) so we can't just hard-code everything in a DTB. While the
> virtio-negotiation in the config space covers most things we still need
> information like where in the guests address space the shared memory
> lives and at what offset into that the queues are created. As far as I'm
> aware the canonical source of domain information is XenStore
> (https://wiki.xenproject.org/wiki/XenStore) but this relies on a Dom0
> type approach. Is there an alternative for dom0less systems or do we
> need a dom0-light approach, for example using STR-21 (Ensure Zephyr can
> run cleanly as a Dom0 guest) providing just enough services for FE's to
> register metadata and BE's to read it?

I'll try to answer the question for a generic virtio frontend and
backend instead (not SCMI because SCMI is unique due to the reasons
above.)

Yes, xenstore is the easiest way to exchange configuration information
between domains. I think EPAM used xenstore to exchange the
configuration information in their virtio-block demo. There is a way to
use xenstore even between dom0less VMs:
https://marc.info/?l=xen-devel&m=164340547602391 Not just xenstore but
full PV drivers too. However, in the dom0less case xenstore is going to
become available some time after boot, not immediately at startup time.
That's because you need to wait until xenstored is up and running.

There are other ways to send data from one VM to another which are
available immediately at boot, such as Argo and static shared memory.

But dom0less is all about static partitioning, so it makes sense to
exploit the build-time tools to the fullest. In the dom0less case, we
already know what is going to run on the target before it is even turned
on. As an example, we might have already prepared an environment with 3
VMs using Yocto and ImageBuilder. We could also generate all
configurations needed and place them inside each VMs using Yocto's
standard tools and ImageBuilder. So for dom0less, I recommend to go via
a different route and pre-generate the configuration directly where
needed instead of doing dynamic discovery.


>  * How to handle mapping of memory
> 
> AIUI the Xen model is the FE guest explicitly makes grant table requests
> to expose portions of it's memory to other domains. Can the BE query the
> hypervisor itself to discover the available grants or does it require
> coordination with Dom0/XenStore for that information to be available to
> the BE domain?

Typically the frontend passes grant table references to the backend
(i.e. instead of plain guest physical addresses on the virtio ring.)
Then, the backend maps the grants; Xen checks that the mapping is
allowed.

We might be able to use the same model with virtio devices. A special
pseudo-IOMMU driver in Linux would return a grant table reference and an
offset as "DMA address". The "DMA address" is passed to the virtio
backend over the virtio ring. The backend would map the grant table
reference using the regular grant table hypercalls.


>  * How to handle signalling
> 
> I guess this requires a minimal implementation of the IOREQ calls for
> Zephyr so we can register the handler in the backend? Does the IOREQ API
> allow for a IPI style notifications using the global GIC IRQs?
> 
> Forgive the incomplete notes from the Stratos sync, I was trying to type
> while participating in the discussion so hopefully this email captures
> what was missed:
> 
>   https://linaro.atlassian.net/wiki/spaces/STR/pages/28682518685/2022-02-03+Project+Stratos+Sync+Meeting+Notes

Yes, any emulation backend (including virtio backends) would require an
IOREQ implementation, which includes notifications via event channels.
Event channels are delivered as a GIC PPI interrupt to the Linux kernel.
Then, the kernel sends the notification to userspace via a file
descriptor.
--8323329-618230339-1644272516=:2091381--


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 00:53:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 00:53:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267476.461211 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHElE-0002WJ-Fd; Tue, 08 Feb 2022 00:53:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267476.461211; Tue, 08 Feb 2022 00:53:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHElE-0002WC-Ci; Tue, 08 Feb 2022 00:53:36 +0000
Received: by outflank-mailman (input) for mailman id 267476;
 Tue, 08 Feb 2022 00:53:35 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=sPwi=SX=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nHElD-0002W6-1m
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 00:53:35 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8945398c-8879-11ec-8f75-fffcc8bd4f1a;
 Tue, 08 Feb 2022 01:53:32 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 56C9860ED6;
 Tue,  8 Feb 2022 00:53:31 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 57E27C340ED;
 Tue,  8 Feb 2022 00:53:30 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8945398c-8879-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1644281610;
	bh=BKvtTLmbWxb5jV3BD/gKrYbJ6FspEd+ihRTcx/qBHEE=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=kFemCdk9YkMAKK3gkKKC/Xyps4rO+0ZjNa+cPU6KYIJiUedzkeyq2yi0dYYfXgI85
	 LgcAiZ/bKVLHdBZ4FyB0AVqWSQjgleB8ecgPbZZiFc4R5HD8htric3iqJ7qSpGY/56
	 LIsBwm96Cnt3gTaoblz3DweMenZ/5J7ekNmWd6DL6eiteKwxjnlHjw9C37YJC+zv05
	 D6dFuZR0JQNJPUiGgOcFzYPd0am7p13bLO2l7fRimfiCi07ypkfawzH1oelAtgWJdv
	 IpL/tU2I1MIR1SDLJzrFtSfcAI33Fw61yYk7qR/+we+VOzDvsiQzDx6UEj5dJh2hVd
	 FhmTbcNgazf+w==
Date: Mon, 7 Feb 2022 16:53:23 -0800 (PST)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Rob Herring <robh@kernel.org>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    Robin Murphy <robin.murphy@arm.com>, 
    Sergiy Kibrik <Sergiy_Kibrik@epam.com>, Julien Grall <julien@xen.org>, 
    Oleksandr Tyshchenko <olekstysh@gmail.com>, 
    "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, 
    "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, 
    "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v3 1/2] dt-bindings: arm: xen: document Xen iommu
 device
In-Reply-To: <Yf3dfUtYoB8wpWkl@robh.at.kernel.org>
Message-ID: <alpine.DEB.2.22.394.2202071616300.2091381@ubuntu-linux-20-04-desktop>
References: <20220117123251.140867-1-Sergiy_Kibrik@epam.com> <20220117123251.140867-2-Sergiy_Kibrik@epam.com> <e88b882f-4b5d-a801-fc68-66b7f790e11c@arm.com> <PAXPR03MB81144A63E18CAF10E785E2A7F0209@PAXPR03MB8114.eurprd03.prod.outlook.com>
 <447f89ca-86c0-dc35-e7ac-e6639a573670@arm.com> <alpine.DEB.2.22.394.2201261050300.27308@ubuntu-linux-20-04-desktop> <Yf3dfUtYoB8wpWkl@robh.at.kernel.org>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Fri, 4 Feb 2022, Rob Herring wrote:
> On Wed, Jan 26, 2022 at 10:56:39AM -0800, Stefano Stabellini wrote:
> > On Wed, 26 Jan 2022, Robin Murphy wrote:
> > > On 2022-01-26 15:09, Sergiy Kibrik wrote:
> > > > Hi Robin,
> > > > 
> > > > > 
> > > > > This could break Linux guests, since depending on the deferred probe
> > > > > timeout setting it could lead to drivers never probing because the "IOMMU"
> > > > > never becomes available.
> > > > > 
> > > > 
> > > > I've noticed no deferred probe timeouts when booting with this patch. Could
> > > > you please explain more on how this would break guests?
> > > 
> > > Right now I think it would actually require command-line intervention, e.g.
> > > "fw_devlink=on" or "deferred_probe_timeout=3600" (with modules enabled for the
> > > latter to take full effect), but I'm wary of the potential for future config
> > > options to control those behaviours by default.
> 
> fw_devlink=on is now the default (for at least a couple of cycles).
> 
> > 
> > If deferred_probe_timeout=3600 was specified, we would just need an
> > IOMMU driver in Linux for the "xen,iommu-el2-v1" node to solve the
> > problem, right? I guess I am trying to say that it wouldn't be a device
> > tree interface problem but rather a Linux implementation discussion.
> 
> You would have to add that IOMMU driver to old, existing kernels if you 
> want compatibility with a new DT. Otherwise, that kernel would stop 
> booting with a new DT.

The tiny "xen,iommu-el2-v1" driver could be backported to the stable
trees, I would imagine. Otherwise, do you have another suggestion?

It looks like fw_devlink=on applies to supplier/consumer interfaces.
If that is the problem, then maybe we should avoid supplier/consumer
interfaces altogether. Instead, we could add a new Xen specific
property, e.g.:

    device@ff0000 {
        compatible = "this,device";

        xen,iommu = "on";
    };


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 02:00:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 02:00:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267486.461222 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHFnx-00038N-Fk; Tue, 08 Feb 2022 02:00:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267486.461222; Tue, 08 Feb 2022 02:00:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHFnx-00038F-9R; Tue, 08 Feb 2022 02:00:29 +0000
Received: by outflank-mailman (input) for mailman id 267486;
 Tue, 08 Feb 2022 02:00:28 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nHFnw-000385-Fy; Tue, 08 Feb 2022 02:00:28 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nHFnw-0003aY-Co; Tue, 08 Feb 2022 02:00:28 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nHFnv-0003yb-OW; Tue, 08 Feb 2022 02:00:27 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nHFnv-0006G2-O3; Tue, 08 Feb 2022 02:00:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=jbhrZHOxcSen/c0SUvzINlkRp+EMQnV6OiGJyZam1Bo=; b=hYf6mr9StabswGCtDPQDUqqs1Z
	NbmEif5mCuW0SdlpTwKn4GUvSk5giy74bdWDc++3pLzpsevawyLtm1J0qOTpdfsMwpNCQ3fsalOLh
	mdTQgUMEArDjKGtYgHiHKbEc80T76XDSkJYndDHZbtsRyuDrDoVfG7UhJhyO6W2ZSuJk=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168050-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 168050: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=2ade8eef993c37a2a43e51a9b1f6c25509a2acce
X-Osstest-Versions-That:
    linux=dfd42facf1e4ada021b939b4e19c935dcdd55566
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 08 Feb 2022 02:00:27 +0000

flight 168050 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168050/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168041
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168041
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168041
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168041
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168041
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168041
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168041
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168041
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                2ade8eef993c37a2a43e51a9b1f6c25509a2acce
baseline version:
 linux                dfd42facf1e4ada021b939b4e19c935dcdd55566

Last test of basis   168041  2022-02-07 05:04:10 Z    0 days
Testing same since   168050  2022-02-07 20:39:51 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abderraouf Adjal <adjal.arf@gmail.com>
  Adrian Hunter <adrian.hunter@intel.com>
  Andrey Skvortsov <andrej.skvortzov@gmail.com>
  Christian Brauner <brauner@kernel.org>
  Damien Le Moal <damien.lemoal@opensource.wdc.com>
  Eric Biggers <ebiggers@google.com>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Jiasheng Jiang <jiasheng@iscas.ac.cn>
  Linus Torvalds <torvalds@linux-foundation.org>
  Mimi Zohar <zohar@linux.ibm.com>
  Roberto Sassu <roberto.sassu@huawei.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Ulf Hansson <ulf.hansson@linaro.org>
  Xiaoke Wang <xkernel.wang@foxmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   dfd42facf1e4a..2ade8eef993c3  2ade8eef993c37a2a43e51a9b1f6c25509a2acce -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 05:06:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 05:06:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267434.461238 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHIhu-0003dP-2k; Tue, 08 Feb 2022 05:06:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267434.461238; Tue, 08 Feb 2022 05:06:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHIht-0003ch-Td; Tue, 08 Feb 2022 05:06:25 +0000
Received: by outflank-mailman (input) for mailman id 267434;
 Mon, 07 Feb 2022 19:56:36 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ErhA=SW=epam.com=prvs=40371fc674=oleksandr_tyshchenko@srs-se1.protection.inumbo.net>)
 id 1nHA7n-0007Nh-KM
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 19:56:36 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0b8a83b7-8850-11ec-8f75-fffcc8bd4f1a;
 Mon, 07 Feb 2022 20:56:32 +0100 (CET)
Received: from pps.filterd (m0174681.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 217JDoK5013657;
 Mon, 7 Feb 2022 19:56:27 GMT
Received: from eur04-he1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2057.outbound.protection.outlook.com [104.47.13.57])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3e39d583np-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Mon, 07 Feb 2022 19:56:26 +0000
Received: from DB8PR03MB6108.eurprd03.prod.outlook.com (2603:10a6:10:ed::15)
 by AM6PR03MB3653.eurprd03.prod.outlook.com (2603:10a6:209:39::24) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Mon, 7 Feb
 2022 19:56:21 +0000
Received: from DB8PR03MB6108.eurprd03.prod.outlook.com
 ([fe80::e975:b192:b8cd:4f73]) by DB8PR03MB6108.eurprd03.prod.outlook.com
 ([fe80::e975:b192:b8cd:4f73%5]) with mapi id 15.20.4951.018; Mon, 7 Feb 2022
 19:56:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0b8a83b7-8850-11ec-8f75-fffcc8bd4f1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ESLMgZZGA88Zk75sXZ/YQMMNqCDnFBkA6v3fCGh8qk0MWulNgdM/6cp5CIyTAhDlfklqR+hweQqIqLAN9FU5AJtdyDNK8pgZFod0mmdgZ47ioRdZPY3QifxIiAqpkNqv2qvGnBfgo0MYnRS5A0ZLomzaO62jrXvJvrLco6IpWueFLQXys9C/Lf3Nz1mUX2ddxR7XBsFFRziF7UhbAd4y47SD4uQatgqoRt+hb6oaELKLJhPvyjX/4klTGsGVHv+hOMmBE4o9wzxdjXtxMsHVqwcecyJEp9OFs/TEiilT9Vks73OLp/obrcfXpXH48EpIhiCFIBN4koOww8yM/f0ftQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=sG8SuObR37LhrJtG8rJw46HmeV7FqgtRuSoQmK9TJrE=;
 b=lok83KqoUy087EeFdOw0gLTz3LWHriC/4HNw2YFggUB9Jin6tNjzy4/l5/csYrwxho86nOnxJZP/Q3c7Ui4mRPgzPJIEo3t97wQvFiT050xugDsmcMr54f2fFYZ7Ij7JGAQRwNHcEMo/B63g7BOpOMZ+RNHPuqT4nsR4xkX1OaDZN7ZvJJSE/FM979GUdRRuZAggyhrM5/9B3Wn83zKSsRIi344A9PJXfe+3/8sQuOPc9xCcaTNo7FlWU8vRVx4HzinFI/cNdywcaE9/UxugMS5FLrW6Td1ENUdz1GDktTjf9L1CNMwDi5c5UnsYhQDs796QQQLg/5xuuopPAEQUvA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=sG8SuObR37LhrJtG8rJw46HmeV7FqgtRuSoQmK9TJrE=;
 b=qLqImc3miJVj73w5+h9xB8sWOHePe3YjCVVA89p2QhSNy79ABzM0aR6deliMJxDc421syfGiGOyBbpDdPfTLGUnqXqJgzCUtiShlYt9YjjN2ZTv2xOwB2Z446UjcXNodovUcHv0mGmqPiLSr2XZKOgeqk0BtcnC21zhFsOrYLcUnA2ptBeodzJYIGPwDe7l2h7H26JV7bqn/dyNi+IOaI1JiIMczIugYA2ZwXgrBpobp3QzWrV7X3OEF7kENRWEuAeqdnLBHSAv+0MBL3mvejuz0XkuP435hOoh10d4KLZ0deKRjMJegdZEVBQmDibNcM0bY5dwrJ8Vl+VnBrHHyAw==
From: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>
To: Julien Grall <julien@xen.org>
CC: Oleksandr Tyshchenko <olekstysh@gmail.com>,
        "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        Stefano
 Stabellini <sstabellini@kernel.org>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Andrew Cooper <andrew.cooper3@citrix.com>,
        George Dunlap
	<george.dunlap@citrix.com>,
        Jan Beulich <jbeulich@suse.com>, Wei Liu
	<wl@xen.org>,
        =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>,
        Bob Eshleman <bobbyeshleman@gmail.com>,
        Alistair Francis
	<alistair.francis@wdc.com>,
        Connor Davis <connojdavis@gmail.com>
Subject: Re: [PATCH V5] xen/gnttab: Store frame GFN in struct page_info on Arm
Thread-Topic: [PATCH V5] xen/gnttab: Store frame GFN in struct page_info on
 Arm
Thread-Index: AQHYAomKM/4d8JNsdEqc8nNA4dib2KyIh6IAgAAs1wA=
Date: Mon, 7 Feb 2022 19:56:21 +0000
Message-ID: <78d94e1e-6db4-25c1-adb8-e4bdbfe42774@epam.com>
References: <1641424268-12968-1-git-send-email-olekstysh@gmail.com>
 <a54213c4-1c68-694e-c130-d95faeef3953@xen.org>
In-Reply-To: <a54213c4-1c68-694e-c130-d95faeef3953@xen.org>
Accept-Language: en-US, ru-RU
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 47a3c6f1-062a-463c-8e3f-08d9ea73e9b5
x-ms-traffictypediagnostic: AM6PR03MB3653:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM6PR03MB3653ECB7EB47E085DA82E236862C9@AM6PR03MB3653.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:2657;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 vsxkmZ1c3yD2hAgWODe+N+G5oec5FuUt2PxO77pEaToYAcgyw5VgiJmmSvoVXgI3F5lfr7fmVoT+0adUCgaEinWZeeF8UShxsnOAM9X8kiArEEodRHTqD56Tj2citWKm1UgInfEVkaubRcy8T7gWPFGhC2w5NSzCDCXifm3bwv+R76+xBXPKZcFS550ndE5+6MEphzW7+cFu65qgUqfLj9QpjKlMX9h/BWYj5Re72vcBv2aiiCdDMB/5FZLBdY2o22QdTa7rmBLYUn+XgmLTHBK87Sz7iFnSw73sb053MHQqeQ8hHkgzJ+1XlK7/hyoC2t/eN2KR23dv5AzUr0W3sfyaUyYAhvwTZ31YnomVU5VoVh90HCorUYC9NkgwJcJYRqNluRXUt1mvP5SdNpSJNs0apHz/7B4WfqrKLOQBFZbooRXONN5W6dzVPXafBHV+jdmNy3A3PBzhXVJgktnM3+aqbbRvhvbwXn5KeDxF8RiEjmdwuKVkOHIm32d/NJDYmGsv2CXluj/ekjTHg20C8/2mV5FbHlNqOd4dUVE0W2Cc3Rjzw2/8iZ450jpyj3geFbhQTMp25Lv1K3hd+nvw1YaS8kdZorsXCsXYvY+yw63xrxLBkymB3NUaa9iuGgVV9CBbDV9CF3KSk7X5pk3Vo9H/RaibJjR7YcRqWqXRncoIQAZJ+rw7m42KW5Qb8cfapRV3/O0gLjjzkEDlzwbYg1CxV6a2TXsohSY9fmQcuOzlt3Epyt/5N84IrtwWRzTB
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB8PR03MB6108.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66476007)(66556008)(8676002)(86362001)(8936002)(66946007)(66446008)(2906002)(38070700005)(31696002)(64756008)(76116006)(4326008)(91956017)(122000001)(38100700002)(7416002)(508600001)(2616005)(36756003)(55236004)(6512007)(71200400001)(6506007)(83380400001)(6486002)(54906003)(26005)(186003)(316002)(6916009)(5660300002)(31686004)(53546011)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?NXg5ZVdjZmhlUkJDQ2F4eEZBMUNyZXdjRnFCUWNmdXN2OVpVdkZHK3ZjQ09w?=
 =?utf-8?B?RHpwdGJ0VHIzZGVuMWNnWVBkOE5ud2RacVdEbUpnWXFBSWlGRC9pREpjWnBZ?=
 =?utf-8?B?Q0s4UVZUOFlpV0lDSmpqdHR6TnRkRkREYXlsMkk4UXZDVGtja3B1aEp1NHBn?=
 =?utf-8?B?ZFdpUUI4QTRmQTR0cFlENmxXSTludjhjazRDUjJjdGwrbFZRd1VHa2hKbGN5?=
 =?utf-8?B?azhnZDFVVTNTeEhLSTNXQm82ZFVJdHJuWCtFWC94RzFueTZNdzZTN3ZHWWpp?=
 =?utf-8?B?SXlwU1RxdW40ejA5OFkrL2Vac2NQTDNGeW50aDlSdDR4UTZ3Um4xUDZyVHZG?=
 =?utf-8?B?OG02TXh3cis5VmdhRk9rZTVRem8wUCtxUlVuVEpRTlc4Ty93YkVNdlIxV0Nt?=
 =?utf-8?B?bXFtZXBBVExpUEptU0pjU1NRbXJFVmp6UVBRRzVoL2NUUmREVFB1aFQyWCtW?=
 =?utf-8?B?VVVjcDBDZThycnAyMjNaK3RGdjMvZ1R0MVFqdVpKNWRQNXdyMC9pejY0a2Ur?=
 =?utf-8?B?NUVwb1pjMEJEMm1wV29OZlJpTUd1dmVXMzhVR1NOTWg1KzNzQVIzc3hxSWV6?=
 =?utf-8?B?cnJGdHNGdnIyUldyRldoNEF5QUpXMVJUM2ZaY3hua215cmxkNWZ1U2dGTW1y?=
 =?utf-8?B?anNGTlZKSUxTWFgrODZRUm4vRWJ3SjlmYkIrenZ5YTFuSjc4SkhLUzhzQ01u?=
 =?utf-8?B?dUhtQ2lJdDJ0cmhkaWFQVkNFRVJlc3dyOSsyWU9xT1VMZzhHWnNEVndvRGpV?=
 =?utf-8?B?L0czbVlrNFpzM0pmSmhuUFVlNnNHNDU2eHkvUkdabVB3RTBIUjdLTEZDdi9i?=
 =?utf-8?B?T2xzeVFhT3U0MU4yVGRUUisvSm1UUjh4VGp4cExPWDBSQTRGK3ZjcG45K3My?=
 =?utf-8?B?bEp2WDJoanBhOGdaUzNkN0dXcjFwcDA5UjNvenJkQms4SlJhUE1uU2NKUGN3?=
 =?utf-8?B?Y1dyQkgzeS9tUlVBL3pRdU84d2VGTlc4TFI0VHk1NjVSSTF1VG5sSGxKclFs?=
 =?utf-8?B?SFBZa0cwREl3S3dpRnp6elFOTm0raFNyQ1d6b1dBdkpBaWxLMG04cGVQbWFR?=
 =?utf-8?B?Q2RGa3pvQ3lMeVVFdW9jbUl0VmQyWWFJSWNIdkU3RStLSTkzWk9ERFM1alZr?=
 =?utf-8?B?U1hyTWE4dkhmZ3lvVnFtQkswTFhnQTRwTXRPN0F6NDZrejNuQng2cVRsT0pt?=
 =?utf-8?B?aUNLcGI3anY3aGs1bVdya05NMHp6RXBWSUExY3VocTBKcHdyVW5VQlU3ZWpW?=
 =?utf-8?B?Z2FZNWREdzVjL0RnNlkrWmN4QUZ0Wm9XZFhsZWhwZWpiTUcxWitBNUZualZU?=
 =?utf-8?B?U1MyMkJPOGFreFRtNWF4alZXMnN2YndadXdXTHFBMjFqM3VvbEo5YjVYRVYv?=
 =?utf-8?B?SU9tc1JobTFFc2haUlhZTWVPL3RnZmMzS3kxbkc1MWF1bGFmTkdLdUVMeU1F?=
 =?utf-8?B?RXBCVUtNTWFBU1UwNWx1TjQ2a3BZMElJVk9ORlVOL3ZTQ3grVU50bFpJcDcw?=
 =?utf-8?B?MDFlVWR3elNVZWFyb3c2WTQ4UmtDZEt6bFBnZVFIMkloNWhRWG9kcVlCdDhS?=
 =?utf-8?B?TWRMWnJYRWNmWUtoaGpHb0ZXK1hhRGpNZWNQVXphVmd6aTl0eFd2R0Ziem5W?=
 =?utf-8?B?eTZjWHlQaEwyeUI3SWNZcURaV2FFTEVueGwwM29UOWw1bzBTeHBFY01NZSts?=
 =?utf-8?B?Q1dCTHNBZGlNVzJGSE92aFdiSjlQdWlYVGVORHQ2S2pRUUFHbUNiUjBQR0JU?=
 =?utf-8?B?aElNTjEzc0g2ejliRlBRbHN6NzFNZ1NOM1QvaW1ucXBwOU5kem9wWUh4Vlll?=
 =?utf-8?B?d0pqNWtNcVhRWU9JS3JwMGkxRWU4QTA0TWNMb2FUTWZKMTFwaFZkVTlRK2ZV?=
 =?utf-8?B?eVN3eG9ic2hpV0pvTkJQRXRpOGdXK1RBQVg3OUpvUTMrRFc3VzBTM1lyem90?=
 =?utf-8?B?UFVlLzV4ZHEvQ0hodDJCQ0pTRnRUWTNVN3FHbXVPR0ZlVENNdGVZb3hWdFJp?=
 =?utf-8?B?RWhXZzRaa2U5bmExWlZoNkE2eStETlc3bDBablVhb3VaZ3phMElNNHFob3VO?=
 =?utf-8?B?RERGVnlWRFRRb0ttQjNwemw1Uld0QXdJcnN5Wm96d2h4em5pa2RFZGNXSDhF?=
 =?utf-8?B?RytscE55WVQ1K2NyL1ZWQjBWczNLLzdWQ3BTYThIcnBnVXRrWXlOK1M4NkZ3?=
 =?utf-8?B?NGZuNW5RS3h6K3ZpaGw2U1hBajdtRXp2MndydUtuT2NMak5hQWYyYWRORDBS?=
 =?utf-8?Q?ltoqZU8TBspoEpb2VklhZXlk3KTKzVHv+X40WhjYU4=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <65A1CF88C702504D904A2A8200C21C8E@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DB8PR03MB6108.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 47a3c6f1-062a-463c-8e3f-08d9ea73e9b5
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Feb 2022 19:56:21.2139
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: j78cJSpHbpvJgyZ+d6FwYGYTEHg8T3V0oIauwWP3xUhqtRj+bUNf/ym/rYSdwet6ZbzBSQgkaF2VtTzr3LRt407FmQK1kJj0yZTbBu09eGE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR03MB3653
X-Proofpoint-GUID: PZMUodN9l353mJDCC8Yx6cnCAtEjk7x0
X-Proofpoint-ORIG-GUID: PZMUodN9l353mJDCC8Yx6cnCAtEjk7x0
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-07_06,2022-02-07_02,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0
 impostorscore=0 suspectscore=0 bulkscore=0 priorityscore=1501 phishscore=0
 adultscore=0 mlxlogscore=999 mlxscore=0 spamscore=0 clxscore=1015
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202070118

DQpPbiAwNy4wMi4yMiAxOToxNSwgSnVsaWVuIEdyYWxsIHdyb3RlOg0KPiBIaSBPbGVrc2FuZHIs
DQoNCg0KSGkgSnVsaWVuDQoNCg0KPg0KPg0KPiBPbiAwNS8wMS8yMDIyIDIzOjExLCBPbGVrc2Fu
ZHIgVHlzaGNoZW5rbyB3cm90ZToNCj4+IEZyb206IE9sZWtzYW5kciBUeXNoY2hlbmtvIDxvbGVr
c2FuZHJfdHlzaGNoZW5rb0BlcGFtLmNvbT4NCj4+DQo+PiBSZXdvcmsgQXJtIGltcGxlbWVudGF0
aW9uIHRvIHN0b3JlIGdyYW50IHRhYmxlIGZyYW1lIEdGTg0KPj4gaW4gc3RydWN0IHBhZ2VfaW5m
byBkaXJlY3RseSBpbnN0ZWFkIG9mIGtlZXBpbmcgaXQgaW4NCj4+IHN0YW5kYWxvbmUgc3RhdHVz
L3NoYXJlZCBhcnJheXMuIFRoaXMgcGF0Y2ggaXMgYmFzZWQgb24NCj4+IHRoZSBhc3N1bXB0aW9u
IHRoYXQgZ3JhbnQgdGFibGUgcGFnZSBpcyB0aGUgeGVuaGVhcCBwYWdlLg0KPg0KPiBJIHdvdWxk
IHdyaXRlICJncmFudCB0YWJsZSBwYWdlcyBhcmUgeGVuaGVhcCBwYWdlcyIgb3IgImEgZ3JhbnQg
dGFibGUgDQo+IHBhZ2UgaXMgYSB4ZW5oZWFwIHBhZ2UiLg0KDQoNCm9rLCB3aWxsIGRvDQoNCg0K
Pg0KPiBbLi4uXQ0KPg0KPj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9pbmNsdWRlL2FzbS9n
cmFudF90YWJsZS5oIA0KPj4gYi94ZW4vYXJjaC9hcm0vaW5jbHVkZS9hc20vZ3JhbnRfdGFibGUu
aA0KPj4gaW5kZXggZDMxYTRkNi4uZDZmZGEzMSAxMDA2NDQNCj4+IC0tLSBhL3hlbi9hcmNoL2Fy
bS9pbmNsdWRlL2FzbS9ncmFudF90YWJsZS5oDQo+PiArKysgYi94ZW4vYXJjaC9hcm0vaW5jbHVk
ZS9hc20vZ3JhbnRfdGFibGUuaA0KPj4gQEAgLTExLDExICsxMSw2IEBADQo+PiDCoCAjZGVmaW5l
IElOSVRJQUxfTlJfR1JBTlRfRlJBTUVTIDFVDQo+PiDCoCAjZGVmaW5lIEdOVFRBQl9NQVhfVkVS
U0lPTiAxDQo+PiDCoCAtc3RydWN0IGdyYW50X3RhYmxlX2FyY2ggew0KPj4gLcKgwqDCoCBnZm5f
dCAqc2hhcmVkX2dmbjsNCj4+IC3CoMKgwqAgZ2ZuX3QgKnN0YXR1c19nZm47DQo+PiAtfTsNCj4+
IC0NCj4+IMKgIHN0YXRpYyBpbmxpbmUgdm9pZCBnbnR0YWJfY2xlYXJfZmxhZ3Moc3RydWN0IGRv
bWFpbiAqZCwNCj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB1bnNpZ25lZCBpbnQgbWFzaywgdWlu
dDE2X3QgDQo+PiAqYWRkcikNCj4+IMKgIHsNCj4+IEBAIC00Niw0MSArNDEsMTIgQEAgaW50IHJl
cGxhY2VfZ3JhbnRfaG9zdF9tYXBwaW5nKHVuc2lnbmVkIGxvbmcgDQo+PiBncGFkZHIsIG1mbl90
IG1mbiwNCj4+IMKgICNkZWZpbmUgZ250dGFiX2RvbTBfZnJhbWVzKCkgXA0KPj4gwqDCoMKgwqDC
oCBtaW5fdCh1bnNpZ25lZCBpbnQsIG9wdF9tYXhfZ3JhbnRfZnJhbWVzLCBQRk5fRE9XTihfZXRl
eHQgLSANCj4+IF9zdGV4dCkpDQo+PiDCoCAtI2RlZmluZSBnbnR0YWJfaW5pdF9hcmNoKGd0KSBc
DQo+PiAtKHsgXA0KPj4gLcKgwqDCoCB1bnNpZ25lZCBpbnQgbmdmXyA9IA0KPj4gKGd0KS0+bWF4
X2dyYW50X2ZyYW1lczvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoCBcDQo+PiAtwqDCoMKgIHVuc2lnbmVkIGludCBuc2ZfID0gDQo+PiBncmFudF90b19z
dGF0dXNfZnJhbWVzKG5nZl8pO8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
IFwNCj4+IC0gXA0KPj4gLcKgwqDCoCAoZ3QpLT5hcmNoLnNoYXJlZF9nZm4gPSB4bWFsbG9jX2Fy
cmF5KGdmbl90LCANCj4+IG5nZl8pO8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAg
XA0KPj4gLcKgwqDCoCAoZ3QpLT5hcmNoLnN0YXR1c19nZm4gPSB4bWFsbG9jX2FycmF5KGdmbl90
LCANCj4+IG5zZl8pO8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgXA0KPj4gLcKg
wqDCoCBpZiAoIChndCktPmFyY2guc2hhcmVkX2dmbiAmJiAoZ3QpLT5hcmNoLnN0YXR1c19nZm4g
DQo+PiApwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIFwNCj4+IC0geyBcDQo+PiAtwqDC
oMKgwqDCoMKgwqAgd2hpbGUgKCBuZ2ZfLS0gDQo+PiApwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgIFwNCj4+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgIChndCktPmFyY2gu
c2hhcmVkX2dmbltuZ2ZfXSA9IA0KPj4gSU5WQUxJRF9HRk47wqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgIFwNCj4+IC3CoMKgwqDCoMKgwqDCoCB3aGlsZSAoIG5zZl8tLSANCj4+
ICnCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgXA0KPj4gLcKgwqDCoMKg
wqDCoMKgwqDCoMKgwqAgKGd0KS0+YXJjaC5zdGF0dXNfZ2ZuW25zZl9dID0gDQo+PiBJTlZBTElE
X0dGTjvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgXA0KPj4gLSB9IFwNCj4+
IC0gZWxzZSBcDQo+PiAtIGdudHRhYl9kZXN0cm95X2FyY2goZ3QpOyBcDQo+PiAtwqDCoMKgIChn
dCktPmFyY2guc2hhcmVkX2dmbiA/IDAgOiANCj4+IC1FTk9NRU07wqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBcDQo+PiAtfSkN
Cj4+IC0NCj4+IC0jZGVmaW5lIGdudHRhYl9kZXN0cm95X2FyY2goZ3QpIFwNCj4+IC3CoMKgwqAg
ZG8geyBcDQo+PiAtIFhGUkVFKChndCktPmFyY2guc2hhcmVkX2dmbik7IFwNCj4+IC0gWEZSRUUo
KGd0KS0+YXJjaC5zdGF0dXNfZ2ZuKTsgXA0KPj4gLcKgwqDCoCB9IHdoaWxlICggMCApDQo+PiAt
DQo+PiDCoCAjZGVmaW5lIGdudHRhYl9zZXRfZnJhbWVfZ2ZuKGd0LCBzdCwgaWR4LCBnZm4sIA0K
Pj4gbWZuKcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBcDQo+PiAo
eyBcDQo+PiAtwqDCoMKgwqDCoMKgwqAgaW50IHJjXyA9IA0KPj4gMDvCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBcDQo+PiDCoMKgwqDCoMKgwqDCoMKgwqAg
Z2ZuX3Qgb2dmbiA9IGdudHRhYl9nZXRfZnJhbWVfZ2ZuKGd0LCBzdCwgDQo+PiBpZHgpO8KgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgXA0KPj4gLcKgwqDCoMKgwqDCoMKgIGlmICgg
Z2ZuX2VxKG9nZm4sIElOVkFMSURfR0ZOKSB8fCBnZm5fZXEob2dmbiwgZ2ZuKSANCj4+IHx8wqDC
oMKgwqDCoMKgwqDCoMKgwqAgXA0KPj4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAocmNfID0g
Z3Vlc3RfcGh5c21hcF9yZW1vdmVfcGFnZSgoZ3QpLT5kb21haW4sIG9nZm4sIA0KPj4gbWZuLMKg
wqAgXA0KPj4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAwKSkgPT0gMCANCj4+
ICnCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBcDQo+PiAtwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoCAoKHN0KSA/IA0KPj4gKGd0KS0+YXJjaC5zdGF0dXNfZ2ZuwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgXA0KPj4gLcKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgOiAoZ3QpLT5hcmNoLnNoYXJlZF9nZm4p
W2lkeF0gPSANCj4+IChnZm4pO8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIFwNCj4+
IC0gcmNfOyBcDQo+PiArwqDCoMKgwqDCoMKgwqAgKCFnZm5fZXEob2dmbiwgSU5WQUxJRF9HRk4p
ICYmICFnZm5fZXEob2dmbiwgDQo+PiBnZm4pKcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAg
XA0KPj4gK8KgwqDCoMKgwqDCoMKgwqAgPyBndWVzdF9waHlzbWFwX3JlbW92ZV9wYWdlKChndCkt
PmRvbWFpbiwgb2dmbiwgbWZuLCANCj4+IDApwqDCoMKgwqDCoMKgwqDCoCBcDQo+PiArwqDCoMKg
wqDCoMKgwqDCoCA6IA0KPj4gMDvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIFwNCj4NCj4gR2l2ZW4gdGhhdCB3ZSBhcmUgaW1wbGVt
ZW50aW5nIHNvbWV0aGluZyBzaW1pbGFyIHRvIGFuIE0yUCwgSSB3YXMgDQo+IGV4cGVjdGluZyB0
aGUgaW1wbGVtZW50YXRpb24gdG8gYmUgcHJldHR5IG11Y2ggdGhlIHNhbWUgYXMgdGhlIHg4NiAN
Cj4gaGVscGVyLg0KPg0KPiBXb3VsZCB5b3UgYmUgYWJsZSB0byBvdXRsaW5lIHdoeSBpdCBpcyBk
aWZmZXJlbnQ/DQoNCkJlaW5nIGhvbmVzdCwgSSBkaWRuJ3QgdGhpbmsgYWJvdXQgaXQgc28gZmFy
LsKgIEJ1dCwgSSBhZ3JlZSB3aXRoIHRoZSANCnF1ZXN0aW9uLg0KDQpJdCBmZWVscyB0byBtZSB0
aGF0IEFybSB2YXJpYW50IGNhbiBub3cgYmVoYXZlIGFzIHg4NiBvbmUgKGFzIA0KeGVubWVtX2Fk
ZF90b19waHlzbWFwX29uZSgpIG5vdyBjaGVja3MgZm9yIHRoZSBwcmlvciBtYXBwaW5nKSwgSSBt
ZWFuIHRvIA0KdXNlIElOVkFMSURfR0ZOIGFzIGFuIGluZGljYXRpb24gdG8gcmVtb3ZlIGEgcGFn
ZS4NCg0KV2hhdCBkbyB5b3UgdGhpbms/DQoNCg0KPg0KPg0KPj4gwqDCoMKgwqDCoCB9KQ0KPj4g
wqAgwqAgI2RlZmluZSBnbnR0YWJfZ2V0X2ZyYW1lX2dmbihndCwgc3QsIGlkeCkgDQo+PiAoe8Kg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIFwN
Cj4+IEBAIC04OCwxMSArNTQsMjEgQEAgaW50IHJlcGxhY2VfZ3JhbnRfaG9zdF9tYXBwaW5nKHVu
c2lnbmVkIGxvbmcgDQo+PiBncGFkZHIsIG1mbl90IG1mbiwNCj4+IMKgwqDCoMKgwqDCoMKgwqDC
oCA6IGdudHRhYl9zaGFyZWRfZ2ZuKE5VTEwsIGd0LCANCj4+IGlkeCk7wqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBcDQo+PiDCoCB9KQ0K
Pj4gwqAgLSNkZWZpbmUgZ250dGFiX3NoYXJlZF9nZm4oZCwgdCwgDQo+PiBpKcKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqAgXA0KPj4gLcKgwqDCoCAoKChpKSA+PSBucl9ncmFudF9mcmFtZXModCkpID8gSU5W
QUxJRF9HRk4gOiANCj4+ICh0KS0+YXJjaC5zaGFyZWRfZ2ZuW2ldKQ0KPj4gKyNkZWZpbmUgZ250
dGFiX3NoYXJlZF9wYWdlKHQsIGkpIA0KPj4gKHvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBcDQo+PiArIHZp
cnRfdG9fcGFnZSgodCktPnNoYXJlZF9yYXdbaV0pOyBcDQo+PiArfSkNCj4NCj4gVGhpcyBjYW4g
YmUgc2ltcGxpZmllZCB0bzoNCj4NCj4gI2RlZmluZSBnbnR0YWJfc2hhcmVkX3BhZ2UodCwgaSkg
dmlydF90b19wYWdlKCh0KS0+c2hhcmVkX3Jhd1tpXSkNCg0KDQphZ3JlZSwgd2lsbCBkbw0KDQoN
Cj4NCj4+ICsNCj4+ICsjZGVmaW5lIGdudHRhYl9zdGF0dXNfcGFnZSh0LCBpKSANCj4+ICh7wqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqAgXA0KPj4gKyB2aXJ0X3RvX3BhZ2UoKHQpLT5zdGF0dXNbaV0pOyBcDQo+
PiArfSkNCj4NCj4gU2FtZSBoZXJlLg0KDQpvaw0KDQoNCj4NCj4+IMKgIC0jZGVmaW5lIGdudHRh
Yl9zdGF0dXNfZ2ZuKGQsIHQsIA0KPj4gaSnCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIFwNCj4+IC3CoMKg
wqAgKCgoaSkgPj0gbnJfc3RhdHVzX2ZyYW1lcyh0KSkgPyBJTlZBTElEX0dGTiA6IA0KPj4gKHQp
LT5hcmNoLnN0YXR1c19nZm5baV0pDQo+PiArI2RlZmluZSBnbnR0YWJfc2hhcmVkX2dmbihkLCB0
LCBpKSANCj4+ICh7wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBcDQo+PiArwqDCoMKgIHBhZ2VfZ2V0X3hlbmhlYXBf
Z2ZuKGdudHRhYl9zaGFyZWRfcGFnZSh0LCANCj4+IGkpKTvCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqAgXA0KPj4gK30pDQo+DQo+IFNhbWUgaGVyZQ0KDQpvaw0KDQoN
Cj4NCj4+ICsNCj4+ICsjZGVmaW5lIGdudHRhYl9zdGF0dXNfZ2ZuKGQsIHQsIGkpIA0KPj4gKHvC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgIFwNCj4+ICvCoMKgwqAgcGFnZV9nZXRfeGVuaGVhcF9nZm4oZ250dGFiX3N0
YXR1c19wYWdlKHQsIA0KPj4gaSkpO8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoCBcDQo+PiArfSkNCj4NCj4gU2FtZSBoZXJlLg0KDQpvaw0KDQoNCj4NCj4+IMKgIMKg
ICNkZWZpbmUgZ250dGFiX25lZWRfaW9tbXVfbWFwcGluZyhkKcKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgIFwNCj4+IMKgwqDCoMKgwqAgKGlzX2RvbWFpbl9kaXJlY3RfbWFw
cGVkKGQpICYmIGlzX2lvbW11X2VuYWJsZWQoZCkpDQo+PiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gv
YXJtL2luY2x1ZGUvYXNtL21tLmggDQo+PiBiL3hlbi9hcmNoL2FybS9pbmNsdWRlL2FzbS9tbS5o
DQo+PiBpbmRleCA0MjRhYWYyLi5iOTkwNDRjIDEwMDY0NA0KPj4gLS0tIGEveGVuL2FyY2gvYXJt
L2luY2x1ZGUvYXNtL21tLmgNCj4+ICsrKyBiL3hlbi9hcmNoL2FybS9pbmNsdWRlL2FzbS9tbS5o
DQo+PiBAQCAtOTgsOSArOTgsMjIgQEAgc3RydWN0IHBhZ2VfaW5mbw0KPj4gwqAgI2RlZmluZSBQ
R1Rfd3JpdGFibGVfcGFnZSBQR19tYXNrKDEsIDEpwqAgLyogaGFzIHdyaXRhYmxlIA0KPj4gbWFw
cGluZ3M/wqDCoMKgwqDCoMKgwqDCoCAqLw0KPj4gwqAgI2RlZmluZSBQR1RfdHlwZV9tYXNrwqDC
oMKgwqAgUEdfbWFzaygxLCAxKcKgIC8qIEJpdHMgMzEgb3IgDQo+PiA2My7CoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoCAqLw0KPj4gwqAgLSAvKiBDb3VudCBvZiB1c2VzIG9mIHRoaXMg
ZnJhbWUgYXMgaXRzIGN1cnJlbnQgdHlwZS4gKi8NCj4+IC0jZGVmaW5lIFBHVF9jb3VudF93aWR0
aMKgwqAgUEdfc2hpZnQoMikNCj4+IC0jZGVmaW5lIFBHVF9jb3VudF9tYXNrwqDCoMKgICgoMVVM
PDxQR1RfY291bnRfd2lkdGgpLTEpDQo+PiArIC8qIDItYml0IGNvdW50IG9mIHVzZXMgb2YgdGhp
cyBmcmFtZSBhcyBpdHMgY3VycmVudCB0eXBlLiAqLw0KPj4gKyNkZWZpbmUgUEdUX2NvdW50X21h
c2vCoMKgwqAgUEdfbWFzaygzLCAzKQ0KPj4gKw0KPj4gKy8qDQo+PiArICogU3RvcmVkIGluIGJp
dHMgWzI4OjBdIG9yIFs2MDowXSBHRk4gaWYgcGFnZSBpcyB4ZW5oZWFwIHBhZ2UuDQo+DQo+IFRo
aXMgY29tbWVudCB3b3VsZCBiZSBlYXNpZXIgdG8gdW5kZXJzdGFuZCBpZiB5b3UgYWRkIHJlc3Au
IChhcm0zMikgDQo+IGFuZCAoYXJtNjQpIGFmdGVyIGVhY2ggcmFuZ2UuDQoNCmFncmVlLCB3aWxs
IGRvDQoNCg0KPg0KPg0KPj4gKyAqLw0KPj4gKyNkZWZpbmUgUEdUX2dmbl93aWR0aMKgwqDCoMKg
IFBHX3NoaWZ0KDMpDQo+PiArI2RlZmluZSBQR1RfZ2ZuX21hc2vCoMKgwqDCoMKgICgoMVVMPDxQ
R1RfZ2ZuX3dpZHRoKS0xKQ0KPj4gKw0KPj4gKyNkZWZpbmUgUEdUX0lOVkFMSURfWEVOSEVBUF9H
Rk7CoMKgIF9nZm4oUEdUX2dmbl9tYXNrKQ0KPj4gKw0KPj4gKy8qDQo+PiArICogQW4gYXJjaC1z
cGVjaWZpYyBpbml0aWFsaXphdGlvbiBwYXR0ZXJuIGlzIG5lZWRlZCBmb3IgdGhlIA0KPj4gdHlw
ZV9pbmZvIGZpZWxkDQo+PiArICogYXMgaXQncyBHRk4gcG9ydGlvbiBjYW4gY29udGFpbiB0aGUg
dmFsaWQgR0ZOIGlmIHBhZ2UgaXMgeGVuaGVhcCANCj4+IHBhZ2UuDQo+PiArICovDQo+PiArI2Rl
ZmluZSBQR1RfVFlQRV9JTkZPX0lOSVRfUEFUVEVSTiBnZm5feChQR1RfSU5WQUxJRF9YRU5IRUFQ
X0dGTikNCj4+IMKgIMKgwqAgLyogQ2xlYXJlZCB3aGVuIHRoZSBvd25pbmcgZ3Vlc3QgJ2ZyZWVz
JyB0aGlzIHBhZ2UuICovDQo+PiDCoCAjZGVmaW5lIF9QR0NfYWxsb2NhdGVkwqDCoMKgIFBHX3No
aWZ0KDEpDQo+PiBAQCAtMzU4LDYgKzM3MSwyNSBAQCB2b2lkIGNsZWFyX2FuZF9jbGVhbl9wYWdl
KHN0cnVjdCBwYWdlX2luZm8gKnBhZ2UpOw0KPj4gwqAgwqAgdW5zaWduZWQgaW50IGFyY2hfZ2V0
X2RtYV9iaXRzaXplKHZvaWQpOw0KPj4gwqAgK3N0YXRpYyBpbmxpbmUgZ2ZuX3QgcGFnZV9nZXRf
eGVuaGVhcF9nZm4oY29uc3Qgc3RydWN0IHBhZ2VfaW5mbyAqcCkNCj4+ICt7DQo+PiArwqDCoMKg
IGdmbl90IGdmbl8gPSBfZ2ZuKHAtPnUuaW51c2UudHlwZV9pbmZvICYgUEdUX2dmbl9tYXNrKTsN
Cj4+ICsNCj4+ICvCoMKgwqAgQVNTRVJUKGlzX3hlbl9oZWFwX3BhZ2UocCkpOw0KPj4gKw0KPj4g
K8KgwqDCoCByZXR1cm4gZ2ZuX2VxKGdmbl8sIFBHVF9JTlZBTElEX1hFTkhFQVBfR0ZOKSA/IElO
VkFMSURfR0ZOIDogZ2ZuXzsNCj4+ICt9DQo+PiArDQo+PiArc3RhdGljIGlubGluZSB2b2lkIHBh
Z2Vfc2V0X3hlbmhlYXBfZ2ZuKHN0cnVjdCBwYWdlX2luZm8gKnAsIGdmbl90IGdmbikNCj4+ICt7
DQo+PiArwqDCoMKgIGdmbl90IGdmbl8gPSBnZm5fZXEoZ2ZuLCBJTlZBTElEX0dGTikgPyBQR1Rf
SU5WQUxJRF9YRU5IRUFQX0dGTiANCj4+IDogZ2ZuOw0KPj4gKw0KPj4gK8KgwqDCoCBBU1NFUlQo
aXNfeGVuX2hlYXBfcGFnZShwKSk7DQo+PiArDQo+PiArwqDCoMKgIHAtPnUuaW51c2UudHlwZV9p
bmZvICY9IH5QR1RfZ2ZuX21hc2s7DQo+PiArwqDCoMKgIHAtPnUuaW51c2UudHlwZV9pbmZvIHw9
IGdmbl94KGdmbl8pOw0KPj4gK30NCj4NCj4gVGhpcyBpcyBub3QgZ29pbmcgdG8gYmUgYXRvbWlj
LiBTbyBjYW4geW91IG91dGxpbmUgd2hpY2ggbG9ja2luZyANCj4gbWVjaGFuaXNtIHNob3VsZCBi
ZSB1c2VkIHRvIHByb3RlY3QgYWNjZXNzIChzZXQvZ2V0KSB0byB0aGUgR0ZOPw0KDQoNCkkgdGhp
bmssIHRoZSBQMk0gbG9jay4NCg0KDQo+DQo+DQo+IEkgd2lsbCBkbyBhbm90aGVyIHJldmlldyBv
ZiB0aGUgcGF0Y2ggb25jZSBJIGtub3cgd2hhdCB3ZSBsb2NraW5nIA0KPiBzaG91bGQgcHJvdGVj
dCB0aGUgYWNjZXNzZXMuDQo+DQo+IENoZWVycywNCj4NCi0tIA0KUmVnYXJkcywNCg0KT2xla3Nh
bmRyIFR5c2hjaGVua28NCg==


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 05:06:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 05:06:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267337.461233 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHIht-0003ab-PE; Tue, 08 Feb 2022 05:06:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267337.461233; Tue, 08 Feb 2022 05:06:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHIht-0003aU-Ln; Tue, 08 Feb 2022 05:06:25 +0000
Received: by outflank-mailman (input) for mailman id 267337;
 Mon, 07 Feb 2022 17:58:25 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ErhA=SW=epam.com=prvs=40371fc674=oleksandr_tyshchenko@srs-se1.protection.inumbo.net>)
 id 1nH8HR-0008EP-L6
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 17:58:25 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8a724a8a-883f-11ec-8eb8-a37418f5ba1a;
 Mon, 07 Feb 2022 18:58:24 +0100 (CET)
Received: from pps.filterd (m0174679.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 217HhGRo022567;
 Mon, 7 Feb 2022 17:58:19 GMT
Received: from eur05-vi1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2174.outbound.protection.outlook.com [104.47.17.174])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e377b8834-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Mon, 07 Feb 2022 17:58:19 +0000
Received: from DB8PR03MB6108.eurprd03.prod.outlook.com (2603:10a6:10:ed::15)
 by VI1PR03MB4062.eurprd03.prod.outlook.com (2603:10a6:803:70::20) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Mon, 7 Feb
 2022 17:58:14 +0000
Received: from DB8PR03MB6108.eurprd03.prod.outlook.com
 ([fe80::e975:b192:b8cd:4f73]) by DB8PR03MB6108.eurprd03.prod.outlook.com
 ([fe80::e975:b192:b8cd:4f73%5]) with mapi id 15.20.4951.018; Mon, 7 Feb 2022
 17:58:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8a724a8a-883f-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=lJKqqxzz4z0DjZw9DPkUz02F+8wu3M/lwESewqEty9NA4GlQuIyrnIwKDPxCS5mDj7/9MpTplStiDfIK34+RAdIiZDY0QA4fQna9JfvdCfddKiqZMWtUUDJRLItkllaTMaRECvA7UF67dJtkHptl3DEwrkE7fl9LdwjWE9RhhcDCyZIfPxXQ9mdnl1WdS6Do3YBaYW5SlGnpmxI5uy4zsjTT/iZN7lZ51/jSac4KQJvSZMkfKhaLyE5mm9mQX+7qcpZD5XZoGf3uHTuOTLjZqu/wPFfq3I48V8+ozx+5pGAG5FXu6Z+ygQU6iVxtNz7hnras+d0DRLInjIghk+4Qvg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=hsIXGB17eFaEWtUTc9hevLg1d7sVITjjbZekA2/V+0M=;
 b=SmOgxKyoEd5QhcLH2jpzjfK8bGUK9HIJMyCGn7TovIkJQZeV69FlBVpLopeRfylnjw6P+Uo8jNDURLwqQtzl+J2vntgkkzwoez8MYFaW255D2iS9RnLzTL2Rw7FmyuRVJxDBSOGRCwOGSN3ZdV4QGkOm9gk+9TW7is46bCIqZRFT2Khw0sfYpRSbh2WO6ocxpRHA0RoC4E6JcknVwog1oECWqh/7hxzReM1znXxX02JAlvPbHmYdfcTWXECPltq1CvoG7ffirHSB+tUVqYL0zy2YBC8dY/pv0/hWMvOxpAWhG2T9W8INo7gUQw67B+XXGUNE74plh183sAJLQ1zZqw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=hsIXGB17eFaEWtUTc9hevLg1d7sVITjjbZekA2/V+0M=;
 b=TP2eyssj+VWFw1GlkG2gj4wU0MplRRZ578nv+WL50utaPcaFMM2Lk+5izezFo3CZE5ktKauSVEfKVQGXWy7bjlURB9K1MI9RNhiKtD4XFeBI2QHMSosvs4TrZhMiu31qgPX7E9OIoMHOLRG6m8qlOzRpunjIHbNZAgDOUSM7vqQJBCGvgCun/Ux4yVybFGaNdiLLfZqo79gjNSE0w3Ccb9vQ1VhtzBB/kfi4piA1KRdNC2ScafvQFqRvEttNU2cGxJfTAKuAekTHsON6auVW3o1PEPcVpp9HtZX/I/rd/xzuur7XBfmwLFIepnPpu/8ggdPtRrfnmUfo9kH9H6A3yQ==
From: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>
To: Julien Grall <julien@xen.org>
CC: Oleksandr <olekstysh@gmail.com>, Jan Beulich <jbeulich@suse.com>,
        Stefano
 Stabellini <sstabellini@kernel.org>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Andrew Cooper <andrew.cooper3@citrix.com>,
        George Dunlap
	<george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
        =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>,
        Bob Eshleman
	<bobbyeshleman@gmail.com>,
        Alistair Francis <alistair.francis@wdc.com>,
        Connor Davis <connojdavis@gmail.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH V5] xen/gnttab: Store frame GFN in struct page_info on Arm
Thread-Topic: [PATCH V5] xen/gnttab: Store frame GFN in struct page_info on
 Arm
Thread-Index: AQHYAomKM/4d8JNsdEqc8nNA4dib2KxWDBOAgAAkKACAMl6jAIAABJuA
Date: Mon, 7 Feb 2022 17:58:14 +0000
Message-ID: <46822a8c-998b-6ebb-5e2a-c9df5f7650e9@epam.com>
References: <1641424268-12968-1-git-send-email-olekstysh@gmail.com>
 <a7a905fe-3feb-507a-7ce4-ed7dce78de86@suse.com>
 <aeba1af9-8386-3bca-dfbd-1c9110ae09de@gmail.com>
 <ef4f77d7-2ad7-998e-c32b-534fdbc64e7f@xen.org>
In-Reply-To: <ef4f77d7-2ad7-998e-c32b-534fdbc64e7f@xen.org>
Accept-Language: en-US, ru-RU
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: d6e640da-93a9-4f37-4560-08d9ea63699c
x-ms-traffictypediagnostic: VI1PR03MB4062:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <VI1PR03MB40625C9C5790F397D1D863B7862C9@VI1PR03MB4062.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8882;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 XIhKzCHQ/S7Zka5FUTweyon3gTazImaGM37wS9BZrFUC7JuVItUroixGNZlXB5Jmq1m/mX9BHKVCC3HqIYqO+ukiez3xtz41cgAi+CXtaV4WW3+bnsIAjeRxIQznOhw6i1ecP2dQsvdj1PeI8dlpQbKrUAS3L8GDpSbTJ6TmSJHMvV5arrI+ePdQjTgLS+cNglUU5r984jbGycBP2yFQAx8IqjrMLRuYirxZm5saQqyNEdWb3b56kSS7GZm1myCYWLcSrmbkbjYKOnjhg38YMtx1N/xMh0nL1kLoZSirX74yYTvXYFsr0P4OsxF2HQUKj2NpH4Odj0sjNxqk0qGXvtphUZctUmd03seTmqqqLAFVs+T0CqNIEPwyM2p4Tm6q0MoCkcYy0um/OQxfEAwECBcZhWbPDdu6NwLv03ShoXdqOlqlT7p9xPClXZUReUyPR9OBkos6wD+Hz6OYYhXp72s9qlRq+hG0IIm7vZdJhBws4B/TXAngIClztbg7X0ErI3PZjZXjmDLn+KGkaYobu4TU2sptqtR7VHi+Wf4Hy5i/NnN5Pji3dqCsZw7o9tRWJD6+5XTAZIdt9FplYHP71mwN1aGU0MOsmu/9uw6fldwZvAcAMF3Yh+3lkH4F3zjZZC4cLGBg8snhRjQ5Ll80ohLQPFX8xmYbwNk0H3hO5o6KSRH/5yTXY4us/QQBvEIT6pPyUkLQLYVSdEEAD1krFfdD8IR5qOXAHL6ZKKveYDuXHPgOIcMHCywE2Jd2/2zP1mI0ST7biQbK69zK3OQrvYoOr1ido3t6FujJouS6bEpgiGBrfjrzoW9Egr+dtnWM
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB8PR03MB6108.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(316002)(38100700002)(2906002)(6916009)(966005)(6486002)(508600001)(54906003)(7416002)(4744005)(122000001)(4326008)(86362001)(5660300002)(31696002)(38070700005)(53546011)(31686004)(55236004)(6512007)(6506007)(8936002)(66946007)(91956017)(76116006)(8676002)(64756008)(36756003)(83380400001)(26005)(66476007)(186003)(71200400001)(66446008)(66556008)(2616005)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?bnhwM0J5SVlmSXNYa2lqYXM4WXdHK2tuOG9JeTZWM1NEU2FuY1Q4MStSWXBr?=
 =?utf-8?B?eHVlUVVuUGt6STJGTisya24zT0sxVkU4YnV4Ykd3QTJTWEtRZG5NNjBzekFB?=
 =?utf-8?B?VEJBSnBlU044VkhEazJ1dUg5ZVdJQlFFRGpyZHp1YlFLTnVvbm5NRGFmVzAv?=
 =?utf-8?B?bHNpMEllZ1dkUmRoejIzYkpDTWRiNDBXeU5KZldTVk1qMW8yV0lVYU50R09M?=
 =?utf-8?B?M2dnWXUwZ0k0U3RQZWoyME5qSjZqM2FHMEtUZkVPSjg4Z1VsRWZmZEpmdDND?=
 =?utf-8?B?ZmY0UlpzTlFKTFFSK05oY3VSblRRdkw0eG54T2V5cG9qTW1CWTNicC9aeUg4?=
 =?utf-8?B?R3RST2NLQ0xvUUdNaFJBU1hxSTcrdFY1RUVyYzdHcExGVEo0ZG80WGF3RVJT?=
 =?utf-8?B?akUxeWVGSGwxUVdVV09kWDVDcXZKbjhjL0ZWQk1VQWcxRFl2aTRrWHpjdlVZ?=
 =?utf-8?B?all4SnVzdExtdjJwQU5USmZ3SVZvRVZYaE1IazFwNTZjNER2L2RiNlNRbzV6?=
 =?utf-8?B?dXVyS0RpL0lpa21jTkNlUVVYbkxwSCtWSndLdXByZEF2V3p0VTl1WFFsK05O?=
 =?utf-8?B?eGYzN1lHbUZydStsNVJxdFdqWGJFVDZTMGFjSk5FL29OQ2V5M3VnMkR3SmNw?=
 =?utf-8?B?a3JYMUl3NWRrTjhsb0ZLUEJxWGZjeTFDVmxEcEV4RExoRzdSUDk3dnJrWEJn?=
 =?utf-8?B?V3lic09sRTN2TnF0cFNHWjVTeTZVVUVOZTJYbnUyZFl4NGViVGFQRmxGYndU?=
 =?utf-8?B?Y2tVODV6eS9qT0o1TktCMUlUSUh6Q2VlT3pDZlg3cW12aTVrQTh1SnlrbERl?=
 =?utf-8?B?U3IzcHNXN1RpQWpySWRyTFNtV2Z1NUhSdElZd0ppRkwwYlFtckczZ2xwRDRi?=
 =?utf-8?B?VVoydVpMVGVQVTR6eDc5ZmtnaDJJMXhHQVVHS1lsY2IxZG5MV0tIZGJlWVVJ?=
 =?utf-8?B?ZllubjFhb1pqOHZMcXZvUWhJUzhKSjFra3dYMGJid3M0OW1WZXJ0aXJrUGZ4?=
 =?utf-8?B?TFlydjM2QlJxM1pnZlgwaThjQWxLTVBXSzVEelVteVZHZTU3bGF4Wm4vVDFa?=
 =?utf-8?B?VzNrcmR6N1B3LzNrZmgxZXlJaUpvVTJha0lSb3FEQ29tYmJ0RTJ4QUIwNW1M?=
 =?utf-8?B?ZUs5TmlnamVHUjF0aHpORDI5eVE4NHNHMHZScFkrL1hsNWNpaFd5NFVGcWJu?=
 =?utf-8?B?M3BGT3ZZeXJxSHBicDJQNTJ3YTk5WkYxYUUzeUhoZ28ySmFPRDJ2T3RWRUhZ?=
 =?utf-8?B?UzhrUGN0TEdzQUdOSDFkbXVnUHhOTlRSZkdTLzFvMWtvWGwvUkJZaXBib1Zj?=
 =?utf-8?B?a2srRU1aa0c5dTRMRVBIQmtJbHd5RldnMm1hQTZ6MHhmY1laeWhTRTYrMzdY?=
 =?utf-8?B?MnBIY29SVCtvTjluMmRYYzhxRGlrMWNvZU9JWFBxWWl0ZDBBS2lhb1gwTlVS?=
 =?utf-8?B?Z3ErYjZXRjA2YTRNeGtIdFhBZnpYOWgrYnJESXpoNFFUQzJ1bGszSDdQUWxr?=
 =?utf-8?B?TTdlT1lWeGFOOEc4dDhYQllTdHRVcjVvQTBvMmpxeFlFZ3hhU0FyeENYOS9F?=
 =?utf-8?B?eUc5cW54Z21OYUNyOURLVUpaSXZjaHhlRUNOSXg0SUxuTndaVFJ2Y2pKbkQy?=
 =?utf-8?B?VHB1ZE1JeTBzSmNSWkVsKzdUTWhaNGlramt6bFBETEVGOFN2TWNOTFZJaGIv?=
 =?utf-8?B?VnRsQlpoV0FzSE1GSVk1OGFMbHVHS21NS243VXhKY3d6ZDNqVlNkUERFSGVL?=
 =?utf-8?B?REdXemhCVWRNT05yQVB0WFR6UDZrWENaWHhxSENHSkU5VUZYbmIraHVsdHdK?=
 =?utf-8?B?NTR0bE1JN0hEejRiempTdEtsZmZXS3cxRWY0dHJITWpSOFJiUnlycHVNd1ZT?=
 =?utf-8?B?amhYenlsRGpHV0F4alU3NTRzMFZsaWgzNnd5RDJqT1RmSEVzNkdWTWxIdXFY?=
 =?utf-8?B?MzRUcHh5bkc2ejI5QjV6dmUvaC85TGJzOVZwaGp6RHBQcXhBZy9aT3MwNy8z?=
 =?utf-8?B?cDBxb2pHelErZFdnd29BeDNoUjJSaFQzMVUzbW1zWFJNVXA5VU4xdkUvRjJU?=
 =?utf-8?B?VnIvbS9vamVibHdmSWRrVU9iY3ArK0FDTUtGWmNsNDBSa1o4eXBjc0JvUVRx?=
 =?utf-8?B?dVBvd2JpNlBOMEQ5d3VrTE5zS3B5OVhzYVFIN09xVnp1NmNyYXlHQXprZ1lq?=
 =?utf-8?B?cHJPSmxkZGlXR0N2RThzVUlySVhrWFVCZzQrN3I3a0cxeGxpWWV5bHVGOG01?=
 =?utf-8?Q?Jq0p+cwfadbHgT0/khfCc1due2V7S8L/+2UzKlq3aE=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <D4887C915859FA45930C02158F3F826B@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DB8PR03MB6108.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d6e640da-93a9-4f37-4560-08d9ea63699c
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Feb 2022 17:58:14.3365
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: rk5yCl3sUkGs4jO4QesHDQFGXZ9niwmoXmyDldb8jDkkzKRxCrMaz8PcVUX+r0cER26pOdnLyV4kmH+IW3+J34So6cHgPpzrgJua7St+WYM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR03MB4062
X-Proofpoint-ORIG-GUID: BtVVE05XEHOGRV7Yp0tAxDL_8sMhkDDA
X-Proofpoint-GUID: BtVVE05XEHOGRV7Yp0tAxDL_8sMhkDDA
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-07_06,2022-02-07_02,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0
 impostorscore=0 clxscore=1011 priorityscore=1501 mlxlogscore=851
 spamscore=0 malwarescore=0 bulkscore=0 adultscore=0 lowpriorityscore=0
 phishscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202070111

DQpPbiAwNy4wMi4yMiAxOTo0MSwgSnVsaWVuIEdyYWxsIHdyb3RlOg0KPiBIaSwNCg0KDQpIaSBK
dWxpZW4NCg0KDQo+DQo+IFNvcnJ5IGZvciB0aGUgbGF0ZSByZXBseS4NCg0KbnANCg0KDQo+DQo+
IE9uIDA2LzAxLzIwMjIgMTY6MzAsIE9sZWtzYW5kciB3cm90ZToNCj4NCj4gU28gSSBhZ3JlZSB3
aXRoIEphbiB0aGF0IHRoZSBuYW1lIHNob3VsZCBiZSBhZGp1c3RlZCBpZiBpdCBzdGF5cyB3aGVy
ZSANCj4gaXQgaXMuDQo+DQo+IFRoYXQgc2FpZCwgSSB3b3VsZCBhY3R1YWxseSBwcmVmZXIgdGhl
IGFkanVzdG1lbnQgaW4gDQo+IGFsbG9jX2hlYXBfcGFnZXMoKS4gSXQgaXMgb25lIGxlc3MgYXNz
aWdubWVudCBwZXIgcGFnZSBhbmQgSSBkb24ndCANCj4gZXhwZWN0IGFueSBpc3N1ZSB3aXRoIHNl
dHRpbmcgdGhlIGJpdHMgdG8gSU5WQUxJRF9HRk4gZXZlcnl3aGVyZSBpbiANCj4gdGhlIGZ1dHVy
ZSBvbiBBcm0uDQoNCg0KU29ycnkgSSBsb3N0IHRoZSBjb250ZXh0LiBUbyBjbGFyaWZ5LCBhcmUg
eW91IHNwZWFraW5nIGFib3V0IHdoYXQgSSANCnByb3Bvc2VkIGF0IFsxXT8NCg0KDQpJZiB5ZXMs
IHRoZW4gLi4uDQoNCg0KPg0KPiBOb3RlIHRoYXQgeW91IHdvdWxkIGFsc28gbmVlZCB0byB1cGRh
dGUgYWNxdWlyZV9zdGF0aWNtZW1fcGFnZXMoKS4NCg0KDQogwqAuLi4geWVzLCB3aWxsIGRvLg0K
DQoNClsxXSANCmh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL3hlbi1kZXZlbC9iNDgzMjI4NC05YmZj
LWQ2MDAtMTRiMS0xNzg0ZjUzZTVkOWZAZ21haWwuY29tLw0KDQoNCj4NCj4NCj4gQ2hlZXJzLA0K
Pg0KLS0gDQpSZWdhcmRzLA0KDQpPbGVrc2FuZHIgVHlzaGNoZW5rbw0K


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 05:06:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 05:06:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267436.461246 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHIhu-0003ki-GF; Tue, 08 Feb 2022 05:06:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267436.461246; Tue, 08 Feb 2022 05:06:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHIhu-0003ib-7h; Tue, 08 Feb 2022 05:06:26 +0000
Received: by outflank-mailman (input) for mailman id 267436;
 Mon, 07 Feb 2022 20:04:33 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ErhA=SW=epam.com=prvs=40371fc674=oleksandr_tyshchenko@srs-se1.protection.inumbo.net>)
 id 1nHAFV-0008Kx-6N
 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 20:04:33 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 28bd38ae-8851-11ec-8eb8-a37418f5ba1a;
 Mon, 07 Feb 2022 21:04:31 +0100 (CET)
Received: from pps.filterd (m0174680.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 217JjYOI027387;
 Mon, 7 Feb 2022 20:04:26 GMT
Received: from eur05-am6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2110.outbound.protection.outlook.com [104.47.18.110])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3e39v6021w-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Mon, 07 Feb 2022 20:04:26 +0000
Received: from DB8PR03MB6108.eurprd03.prod.outlook.com (2603:10a6:10:ed::15)
 by AM6PR03MB3653.eurprd03.prod.outlook.com (2603:10a6:209:39::24) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Mon, 7 Feb
 2022 20:04:19 +0000
Received: from DB8PR03MB6108.eurprd03.prod.outlook.com
 ([fe80::e975:b192:b8cd:4f73]) by DB8PR03MB6108.eurprd03.prod.outlook.com
 ([fe80::e975:b192:b8cd:4f73%5]) with mapi id 15.20.4951.018; Mon, 7 Feb 2022
 20:04:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 28bd38ae-8851-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=BEke78kK7gJbaU9FwrFKAJzdBOYxt5Z0utl5Wu3y6V0ayuNQLqev69OMxY607XGdZ6n+YT6NpneXTwa0XreMakItqmYKE+pYDr9eY7Uxx7bXMvVEY5zePeZi++gG7HU2KDzxqQYL0580WAGJeCmATp9uwfBKTRQ1/miYGktmG3v7WkhXhHH9Uk4x4SwT1Xa26nE9qkbPpoR2xwqa+dAOVEul2tMDPOl6B0Z3MFheD0bwTzsRHQnqAZ6PLvehOzjiyT7ere2MDB1mr7vs6ztkIiYWGtY3Z3f0IFzJAAYoqjKZ9cacZtZzqzvXbqoAzqbXLh8wsL1JrQ18zDGxS2cRVQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=3q+4tKJYOMjBfbsHP4XIsGbDN7rsMa8a8W0Nzt5979g=;
 b=ZNVbUKh6JTs9UXTlNNuEyFfhSuoA+xTrfr0lZjFhqs8rIsa3Y9qtA/FK5CyRcLQj3IDryH/uzWjClO4lyala6nVy7sIO5DywAP9BD7xPardFzaXH6EdSX6nt1ecr9rddFLdPsGhlBfPX/wlZO+MIs7Be/mCU0DYKRi+VzsKDwRPj9c49AToSRjL1DgNeHrGBLPlMs4mQyloh89kQ164MbAFKnMGS9InZd8Wkj/6SfCqYxRyfpZMiHMi5lQcyGZ7EX1AfFkXiMeuKCxdsYP8BW8Pn9fwqUfTnVk577XQycqo69DyE/lH+ma+CfXlUMOSISBySqWgoDLMExy4DPm+lvg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=3q+4tKJYOMjBfbsHP4XIsGbDN7rsMa8a8W0Nzt5979g=;
 b=Dbmo0/nGGO98aP92vvPaurOo4dz9NkYuDyAQ5821Bci4xDMqCJNlsTDIE/RwEjjStJwHWbYOrk1E+1+agkhtMu0tqjcNvcOBjRfsWKncn68RtjwItAps3NX11CF4ql0BLqMAqOGVG+uaBt6PaakD9OdXXPWo14S9cMA2EXsofTZ3JyNuHM5kFQYnrL+DvLnCXOQYvcA6mcStevfgAfc6RSBqqO7qNnFcEgE7NM+//HEC15I7/ufgaDvZmvsflXsXI3RUrsgvgUGHq9QpUrLS9hssdygVFMdkNn7rWbDwlJ9Vcyj2ERtqzfuYLFgNFe4O02mxG4ERs6948+YHlq9L9Q==
From: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>
To: Julien Grall <julien@xen.org>
CC: Oleksandr <olekstysh@gmail.com>, Jan Beulich <jbeulich@suse.com>,
        Stefano
 Stabellini <sstabellini@kernel.org>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Andrew Cooper <andrew.cooper3@citrix.com>,
        George Dunlap
	<george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
        =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>,
        Bob Eshleman
	<bobbyeshleman@gmail.com>,
        Alistair Francis <alistair.francis@wdc.com>,
        Connor Davis <connojdavis@gmail.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH V5] xen/gnttab: Store frame GFN in struct page_info on Arm
Thread-Topic: [PATCH V5] xen/gnttab: Store frame GFN in struct page_info on
 Arm
Thread-Index: 
 AQHYAomKM/4d8JNsdEqc8nNA4dib2KxWDBOAgAAkKACAMl6jAIAABJuAgAAAX4CAACLbAA==
Date: Mon, 7 Feb 2022 20:04:19 +0000
Message-ID: <a7c1be96-431e-feb2-aaa3-166a58ea158e@epam.com>
References: <1641424268-12968-1-git-send-email-olekstysh@gmail.com>
 <a7a905fe-3feb-507a-7ce4-ed7dce78de86@suse.com>
 <aeba1af9-8386-3bca-dfbd-1c9110ae09de@gmail.com>
 <ef4f77d7-2ad7-998e-c32b-534fdbc64e7f@xen.org>
 <46822a8c-998b-6ebb-5e2a-c9df5f7650e9@epam.com>
 <da4fc5cc-d80e-b4d6-7c96-0f9eb47a9304@xen.org>
In-Reply-To: <da4fc5cc-d80e-b4d6-7c96-0f9eb47a9304@xen.org>
Accept-Language: en-US, ru-RU
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 72113f5d-ba06-463c-ceb8-08d9ea7506c4
x-ms-traffictypediagnostic: AM6PR03MB3653:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM6PR03MB3653FE27E3BE155E8F348BBE862C9@AM6PR03MB3653.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 VQsc+sKu0xMwwi4Y1MddKkc45g1kgKWL0WB6/MwJKVbgwbBwNyM4ngKnNR/2NDwaAOKoHvkux7ElovTJvjPVKXUD664rX18j1K0esiDmfK7soBaK0qPt1j+OJsjsnArEaNF7C+2wX5Butr1cXNEXb3ZzAAxWn3z6f7AtXFoc12VEg9F4zliI5u7yEHb4jqUgtj3BWgv7ZIUlO4/p49zJ+on9Sy7Md+bLeCtFnpqjA5ghk/y6rRmrignaYheJXaFdRKt3ANxOCtnTGT8GfZCyIBR1p8Vh//1s+XfHGOsaRNVvRGiTccBE4hHz9DjR5sHaotzD6fS311UXpXgcD1Yi/nhy/NVcR6PJ7sCW0BMJEmrTBsQyowPpLXUcyfOjh/zAGBGmO6FvxM1EWeUoi/VMmCJ7N8z4gJKN5luZNOU7AMRKq9TZWIdNCjkWBZ/BmNUsMlV0LSwTODU2BZha4R2EkBMRH0vmjtEpnDcTr14LGf8H+E7wogoZ3EPHRydDtKpBVhV27dNwdJ1o1Ba4aOhS6qGOQug85i3rb5XRSNwWqBZqG67tc3YC7wGcPL5rCQpVs1+ay/cp6fBqlcL9ik4PBKxgJY/f51tYy7FpkZ+WL73Iyi/ICgvdCI+amCmx7Y/8RpM6H4UnPHHsaJ4JJ3T8rd2vAqnLEjITePSwyqyCJmNhQhiREyCkXF5j3WC22Z8QVBtfYqYfeM1uuh8tDy0DIXvjD/C7zSlHYG8QV/2jXurJvdiiCC0Lmsjxi5VBufoG
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB8PR03MB6108.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66476007)(66556008)(8676002)(86362001)(8936002)(66946007)(66446008)(2906002)(38070700005)(31696002)(64756008)(76116006)(4326008)(91956017)(122000001)(38100700002)(4744005)(7416002)(508600001)(2616005)(36756003)(55236004)(6512007)(71200400001)(6506007)(6486002)(54906003)(26005)(186003)(316002)(6916009)(5660300002)(31686004)(53546011)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?ZllLMCtLZ3ppOStlVGtEZWVKeDlXVXJLUm1yTUhhN3pma0doUC9VRVRjQk1Q?=
 =?utf-8?B?NmFOSG9wZ1k3eUNCRi81V1NsNDVrV1BraXZJcHM4a3R3amlBMUd2ZHc2amM2?=
 =?utf-8?B?dEo1NlR0eWZyaEFSVEJ2SEYrUkQ1Q1NJdWtoMEx4YlAwSWFWaWFzdHcrZzh6?=
 =?utf-8?B?eEMxdWtVY3JHa3lXVm1vWVE3V2JNSHdvSlN1anRlbjhUY2hEMS82ajdhMVE5?=
 =?utf-8?B?cEU3WDZUUzlUSms1TTRPakVFNFZxS1hNUndaeHFZeFNCUzllSk9rQWJ2SUNT?=
 =?utf-8?B?WWEvTkNkTHVhcUpHTzJLRXZ5YXQ5WGJWdHhJYW1UUHVpZkd4dnZ2bEV5WFcw?=
 =?utf-8?B?YkpCcUdpMXFKQnZqZzVIa1BUdmRwdmh1aUVQK2YycTZ6VHBoWGI5ZnBLMURR?=
 =?utf-8?B?K1BCWDZnSlQrN2F2OW9WNmJ6c2dpdnorNFdWWnl6R01xSTUvc0pQNzh1ZGxo?=
 =?utf-8?B?dmR4NWZLNGZHblBlcGpZWFp4SnRabHUvdzgwNlJISUZYTk5peStJVzdqc2JG?=
 =?utf-8?B?K1ZMdDlld2F4d2FmaDQ3eWUyUXBHTnhhVDFvQlVscW9CU3NEc2NOV2ZPZG1T?=
 =?utf-8?B?Z0JEWit6cSt2QjVPbG5OSVBnaWUyYWNQTWhpR0pSZURYV211SlkvUU9QRWRu?=
 =?utf-8?B?TmtLQmFEWURYVUVYcGYwMXJNbVliMDg4QnFWWCtXNXVTUXhvNWF2eloyYU9V?=
 =?utf-8?B?bGJ0Y3RaT1Fzem1QQXhqdEtJajlmQmc2TTQvRTI1YVB6ZE9iam1sOWRuQjVr?=
 =?utf-8?B?SGhGdUtaK1ZiWEZKMXNhSjJ3VHpJTWFZc095cDBNbXF3ZVRDRGFIQlppRVIw?=
 =?utf-8?B?b1h3a3g4OS9GdTRKV2pGbXBWWW9sUFovQXJLc25ldFZkYTNHaW9PTHZFZjNh?=
 =?utf-8?B?d3RuRUhnR1dmdGtTS3NHQ1VxVnVTQ2tEMDhJY3NvbmxDZVZsS2xqTURhbGJ4?=
 =?utf-8?B?SVBJdmNrRE9VUERnbDc5eFlWVXpGbnd2L0JmRmJNZWFpb0hSb29FZ3N2eTBn?=
 =?utf-8?B?MERxR3cvY244MG9Pb0UvWDhZdXVWZXp5NUllUytmM1ZpVDRVN0x5eE92TEJ5?=
 =?utf-8?B?M2tzbFh0NTlUR2pJTVBwdzc0M205aFltYnAzdmZGS2NKUHVkWmR6UnRoRDM4?=
 =?utf-8?B?TnFOWjUrRWRLai9nWVpOM0hxalYxaCthNURKQTE3c2xoUjZ5VUdlSDUvSHFU?=
 =?utf-8?B?QTJKLzdXY045YmU3bXpxaVVlSk1QVm56RXd5eUJ1RUgxcHhWSjUzalk0WWdz?=
 =?utf-8?B?bDFzNXlJUFpVZUVTUmdYRkFGNWdiOFdrOG9VZk1BWC9tREQxMzUzeXFSczlr?=
 =?utf-8?B?MTVCQU4xRy9uckZ1ZFpFbERGL2FIem9xSVVLVVVMYzZmQ1djMXFzYU1qT3BW?=
 =?utf-8?B?bzNndU4zVWhIMkFuTkxIalhSa2E0dFFJYXVFeW90RExSQW1Vc1NKRkpFVEdv?=
 =?utf-8?B?dnYvWWR2OE9WTEJsL1I4bVZZb1dGV1BBNTNGUHU5UFU3WnVRSXd0TjBoZXFa?=
 =?utf-8?B?QitQYyszQVFadVVsK3NaaUJIcDBnU1VSRGpnMHU2YU5DdkNQRGJQNmZSOVBO?=
 =?utf-8?B?dXExWmlVbEgvdlB6N1VHRmVtRGgvMHdCMlJ3amNkM2tnM2hPVU1FaEZnckhS?=
 =?utf-8?B?VHN6TEl4dSt6S1A2TnprUGtXTmxITVVGak42MWxQbzIrTU41Ry8yOWdjZStj?=
 =?utf-8?B?ZloraG04ckNmaVZkelFyOWN6bktIaisvYWVEQnlOeFh2U0ZTeEpiQk1YTmhq?=
 =?utf-8?B?akRUWnJhNzI3U2hMSzh3ZjE0SzFQbGk1aG96SlV0cGR6SlN1YkN5WWgxZVRw?=
 =?utf-8?B?Q1B0RjlUVzBHZWRiZGpRaUVOTzVFZW95U0xsWWZRUmF2bUdmSHQ5dHhHQXh2?=
 =?utf-8?B?YXhzeVV1U2N1RUNKYlN1SzNkQVZMRlRlekRLNy9ybU0xbXdReW8yVUhISEFO?=
 =?utf-8?B?d0w3SFc1RGY2Y2s3Y2FrUytwejc2NjY1VGRoZ05QVUFhejJTdTdFRndBT1lm?=
 =?utf-8?B?TUpqMm15N2NzQW84RmdpamxHZDlXdGhmZXV0NlU0RWNtb1pYYVpxWWV4ckV5?=
 =?utf-8?B?aG52QWdEUUgrK21ZamFVcUlmNGlFZjFUS1NBbGdMZVVjSEF3QUpsRjNLTVdj?=
 =?utf-8?B?b2ZBZFFqQjVtK0dvc1dCUVBjbDNNeW1DL3JQRlc5emI3QU0wZ05SSDVySStn?=
 =?utf-8?B?Z1ArMDRPMDM4a2h6b2NKWEFkRWp6QnZjamZ4cVV6TTFvOXV3TXk4M21xUW91?=
 =?utf-8?Q?6yw0xfyGYI+8nOKce/SyskyoVyY/03gVjtO9WXnUk0=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <F2766C9237B83944B028310C43DF392E@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DB8PR03MB6108.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 72113f5d-ba06-463c-ceb8-08d9ea7506c4
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Feb 2022 20:04:19.4801
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 98IJ43PXlBFRUgl2RLQrOl1f555iDH1gUjrH8vfbT/SPQxkiqYYtJu7ho+fGURbRhk9zD305Z0/HJ08fW12eeyx+WLiJ5u+gST7mQj9OZzo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR03MB3653
X-Proofpoint-GUID: CXtEeiRaLDV1Kb3uQNxRrdNMSJbsVYSJ
X-Proofpoint-ORIG-GUID: CXtEeiRaLDV1Kb3uQNxRrdNMSJbsVYSJ
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-07_06,2022-02-07_02,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0
 impostorscore=0 clxscore=1015 priorityscore=1501 malwarescore=0
 bulkscore=0 mlxlogscore=905 mlxscore=0 spamscore=0 lowpriorityscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202070118

DQpPbiAwNy4wMi4yMiAxOTo1OSwgSnVsaWVuIEdyYWxsIHdyb3RlOg0KDQpIaSBKdWxpZW4NCg0K
DQo+DQo+DQo+IE9uIDA3LzAyLzIwMjIgMTc6NTgsIE9sZWtzYW5kciBUeXNoY2hlbmtvIHdyb3Rl
Og0KPj4NCj4+IE9uIDA3LjAyLjIyIDE5OjQxLCBKdWxpZW4gR3JhbGwgd3JvdGU6DQo+Pj4gT24g
MDYvMDEvMjAyMiAxNjozMCwgT2xla3NhbmRyIHdyb3RlOg0KPj4+DQo+Pj4gU28gSSBhZ3JlZSB3
aXRoIEphbiB0aGF0IHRoZSBuYW1lIHNob3VsZCBiZSBhZGp1c3RlZCBpZiBpdCBzdGF5cyB3aGVy
ZQ0KPj4+IGl0IGlzLg0KPj4+DQo+Pj4gVGhhdCBzYWlkLCBJIHdvdWxkIGFjdHVhbGx5IHByZWZl
ciB0aGUgYWRqdXN0bWVudCBpbg0KPj4+IGFsbG9jX2hlYXBfcGFnZXMoKS4gSXQgaXMgb25lIGxl
c3MgYXNzaWdubWVudCBwZXIgcGFnZSBhbmQgSSBkb24ndA0KPj4+IGV4cGVjdCBhbnkgaXNzdWUg
d2l0aCBzZXR0aW5nIHRoZSBiaXRzIHRvIElOVkFMSURfR0ZOIGV2ZXJ5d2hlcmUgaW4NCj4+PiB0
aGUgZnV0dXJlIG9uIEFybS4NCj4+DQo+Pg0KPj4gU29ycnkgSSBsb3N0IHRoZSBjb250ZXh0LiBU
byBjbGFyaWZ5LCBhcmUgeW91IHNwZWFraW5nIGFib3V0IHdoYXQgSQ0KPj4gcHJvcG9zZWQgYXQg
WzFdPw0KPg0KPiBUaGF0J3MgY29ycmVjdC4NCg0KDQpUaGFuayB5b3UgZm9yIHRoZSBjbGFyaWZp
Y2F0aW9uLg0KDQoNCj4NCj4gQ2hlZXJzLA0KPg0KLS0gDQpSZWdhcmRzLA0KDQpPbGVrc2FuZHIg
VHlzaGNoZW5rbw0K


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 05:32:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 05:32:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267528.461266 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHJ6s-00080p-Nt; Tue, 08 Feb 2022 05:32:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267528.461266; Tue, 08 Feb 2022 05:32:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHJ6s-00080i-K4; Tue, 08 Feb 2022 05:32:14 +0000
Received: by outflank-mailman (input) for mailman id 267528;
 Tue, 08 Feb 2022 05:32:13 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=co3W=SX=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nHJ6r-00080c-IZ
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 05:32:13 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 77283f77-88a0-11ec-8f75-fffcc8bd4f1a;
 Tue, 08 Feb 2022 06:32:12 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 6A3E2210F5;
 Tue,  8 Feb 2022 05:32:11 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 31EFB13483;
 Tue,  8 Feb 2022 05:32:11 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id c1TwClsAAmLYAQAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 08 Feb 2022 05:32:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 77283f77-88a0-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1644298331; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=Mp8RfcIImegUW97/EwpSKc9/Nx5qsPeExShdbHIc2Yc=;
	b=B0NDypWqDLWXl1iUfICwz6KIpvvXTb1Rsg++VZN2daSOEBbbfSQplwa3t07aFq4A5DR/qz
	48wBjK440kJ9lqCu+rFrDcMghjvJf7nQi3SwH3AFKzMEvXafVX1thKG8MZtH7OmWBhCyJO
	m2ntXl7QEh2hLPy8dQugAEBp9ath5Yc=
Message-ID: <60aa8654-a40f-e5fa-e669-d8fba72a4866@suse.com>
Date: Tue, 8 Feb 2022 06:32:10 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Content-Language: en-US
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: xen-devel@lists.xenproject.org, Wei Liu <wl@xen.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>
References: <20220207064147.9585-1-jgross@suse.com>
 <YgFgZADfaoLNor4T@perard.uk.xensource.com>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH v2 0/5] tools: remove include/xen-external directory
In-Reply-To: <YgFgZADfaoLNor4T@perard.uk.xensource.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------75mXxfsOLO9kCUlKji3OQXek"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------75mXxfsOLO9kCUlKji3OQXek
Content-Type: multipart/mixed; boundary="------------24rI7c4JOpARgjGI897T2wIY";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: xen-devel@lists.xenproject.org, Wei Liu <wl@xen.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>
Message-ID: <60aa8654-a40f-e5fa-e669-d8fba72a4866@suse.com>
Subject: Re: [PATCH v2 0/5] tools: remove include/xen-external directory
References: <20220207064147.9585-1-jgross@suse.com>
 <YgFgZADfaoLNor4T@perard.uk.xensource.com>
In-Reply-To: <YgFgZADfaoLNor4T@perard.uk.xensource.com>

--------------24rI7c4JOpARgjGI897T2wIY
Content-Type: multipart/mixed; boundary="------------Rb9Q2mO73Yr5Agvqc4eP0bTJ"

--------------Rb9Q2mO73Yr5Agvqc4eP0bTJ
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMDcuMDIuMjIgMTk6MDksIEFudGhvbnkgUEVSQVJEIHdyb3RlOg0KPiBPbiBNb24sIEZl
YiAwNywgMjAyMiBhdCAwNzo0MTo0MkFNICswMTAwLCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0K
Pj4gVGhlIHRvb2xzL2luY2x1ZGUveGVuLWV4dGVybmFsIGRpcmVjdG9yeSBjb250YWlucyBh
IGhlYWRlciBmaWxlIGZyb20NCj4+IEZyZWVCU0QgdXNlZCB0byBnZW5lcmF0ZSBYZW4gaGVh
ZGVyIGZpbGVzLiBUaGlzIHNlcmllcyBpcyByZXBsYWNpbmcgdGhlDQo+PiBjb21wbGV0ZSBk
aXJlY3RvcnkgYnkgYSBzaW5nbGUgaGVhZGVyIHdpdGggdGhlIHNhbWUgc2VtYW50aWNzLg0K
Pj4NCj4+IENoYW5nZXMgaW4gVjI6DQo+PiAtIHJlbW92ZSBzdGFsZSBjb21tZW50IGluIHBh
dGNoIDENCj4gDQo+IEp1c3QgbmVlZCB0byBmaXggdGhlIGJ1aWxkIG5vdywgb3RoZXJ3aXNl
LCB0aGUgc2VyaWVzIGxvb2tzIGZpbmU6DQo+IGh0dHBzOi8vZ2l0bGFiLmNvbS94ZW4tcHJv
amVjdC9wYXRjaGV3L3hlbi8tL3BpcGVsaW5lcy80NjQ4MDMwMDcNCj4gXiB4ZW50b29sY29y
ZSBjb252ZXJzaW9uIHNlZW1zIHVuZmluaXNoZWQuDQoNCkhtbSwgd2VpcmQuDQoNClNlZW1z
IEkgZGlkIG9ubHkgYW4gaW5jcmVtZW50YWwgYnVpbGQsIGJ1dCBJIHRoaW5rIGl0IHNob3Vs
ZCBoYXZlIGZhaWxlZA0KbmV2ZXJ0aGVsZXNzLiBJIHN1c3BlY3Qgc29tZXRoaW5nIGlzIHdy
b25nIHdpdGggdGhlIGRlcGVuZGVuY2llcy4NCg0KDQpKdWVyZ2VuDQo=
--------------Rb9Q2mO73Yr5Agvqc4eP0bTJ
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------Rb9Q2mO73Yr5Agvqc4eP0bTJ--

--------------24rI7c4JOpARgjGI897T2wIY--

--------------75mXxfsOLO9kCUlKji3OQXek
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmICAFoFAwAAAAAACgkQsN6d1ii/Ey+7
AAf/d+n92T6hO+MJUdlpImh8AgdfYMYPbwo1oCnzU0178wGq5SyvZEaUIeix5NtOZ1Tp4vUNyoOU
rvHw/Hq2QzO9xxNKCxGkGRmDr2dXLPGKo2RjZBa44GhrWf1eVGeqihD65U+5FrJzwT4pH/gNQVQ9
fstRQQQps6QfS8h2fX3XlIucPSfXuenpttM+JoSOKxzQysSzfTaLY6kh5xTcqEDG/+OYlFkXVjhf
c1aZdR32cDzsJcLXx0czWpMXvuUcJjWmAwdO3K1o2IOzjQxcE3UujlTs+Z45GgQIh8ckmPR81pvb
p9x8RvJUuqGdxsO5uF86eJ8AmUDa93hz97UX+R6DWg==
=KtLY
-----END PGP SIGNATURE-----

--------------75mXxfsOLO9kCUlKji3OQXek--


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 07:06:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 07:06:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267540.461293 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHKaL-000068-W7; Tue, 08 Feb 2022 07:06:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267540.461293; Tue, 08 Feb 2022 07:06:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHKaL-0008Vx-Rq; Tue, 08 Feb 2022 07:06:45 +0000
Received: by outflank-mailman (input) for mailman id 267540;
 Tue, 08 Feb 2022 07:06:44 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=co3W=SX=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nHKaK-0008AS-Jw
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 07:06:44 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ab265d4d-88ad-11ec-8f75-fffcc8bd4f1a;
 Tue, 08 Feb 2022 08:06:42 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 3D4EB21107;
 Tue,  8 Feb 2022 07:06:42 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 153E113483;
 Tue,  8 Feb 2022 07:06:42 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 2JryA4IWAmKxHgAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 08 Feb 2022 07:06:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ab265d4d-88ad-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1644304002; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=O9L5VCHqoZDN85JbspHZhwKfGz0YeeeAr6knmmOSjvM=;
	b=pFucpYKdrfeC2ykt7q9s1nWnrqV9sAt2QBSB7t8ntYAIrAVTwHTjybqR5qsz4S4axFwM0c
	I3lTx8sVoDDqvpJrj+v2WwBEYcCNynb/JSFyNGONSn9qt+eJkoHzm8058dHyjHkkwSLTOQ
	uVQaVMTC5a+vK4a39m9Btnset4Z+ZJY=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>
Subject: [PATCH v3 4/5] tools/libs/evtchn: use _xen_list.h
Date: Tue,  8 Feb 2022 08:06:37 +0100
Message-Id: <20220208070638.5909-5-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220208070638.5909-1-jgross@suse.com>
References: <20220208070638.5909-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Instead of including xen-external/bsd-sys-queue.h use the header
_xen_list.h in minios.c.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 tools/libs/evtchn/minios.c | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/tools/libs/evtchn/minios.c b/tools/libs/evtchn/minios.c
index 30f98bc7e4..65cfccfd09 100644
--- a/tools/libs/evtchn/minios.c
+++ b/tools/libs/evtchn/minios.c
@@ -20,7 +20,7 @@
  * Split off from xc_minios.c
  */
 
-#include "xen-external/bsd-sys-queue.h"
+#include "_xen_list.h"
 #include <mini-os/types.h>
 #include <mini-os/os.h>
 #include <mini-os/lib.h>
@@ -38,10 +38,10 @@
 
 #include "private.h"
 
-LIST_HEAD(port_list, port_info);
+XEN_LIST_HEAD(port_list, struct port_info);
 
 struct port_info {
-    LIST_ENTRY(port_info) list;
+    XEN_LIST_ENTRY(struct port_info) list;
     evtchn_port_t port;
     bool pending;
     bool bound;
@@ -62,7 +62,7 @@ static struct port_info *port_alloc(xenevtchn_handle *xce)
     port_info->port = -1;
     port_info->bound = false;
 
-    LIST_INSERT_HEAD(port_list, port_info, list);
+    XEN_LIST_INSERT_HEAD(port_list, port_info, list);
 
     return port_info;
 }
@@ -72,7 +72,7 @@ static void port_dealloc(struct port_info *port_info)
     if ( port_info->bound )
         unbind_evtchn(port_info->port);
 
-    LIST_REMOVE(port_info, list);
+    XEN_LIST_REMOVE(port_info, list);
     free(port_info);
 }
 
@@ -81,7 +81,7 @@ static int evtchn_close_fd(struct file *file)
     struct port_info *port_info, *tmp;
     struct port_list *port_list = file->dev;
 
-    LIST_FOREACH_SAFE(port_info, port_list, list, tmp)
+    XEN_LIST_FOREACH_SAFE(port_info, port_list, list, tmp)
         port_dealloc(port_info);
     free(port_list);
 
@@ -126,7 +126,7 @@ int osdep_evtchn_open(xenevtchn_handle *xce, unsigned int flags)
     }
 
     file->dev = list;
-    LIST_INIT(list);
+    XEN_LIST_INIT(list);
     xce->fd = fd;
     printf("evtchn_open() -> %d\n", fd);
 
@@ -173,7 +173,7 @@ static void evtchn_handler(evtchn_port_t port, struct pt_regs *regs, void *data)
     assert(file);
     port_list = file->dev;
     mask_evtchn(port);
-    LIST_FOREACH(port_info, port_list, list)
+    XEN_LIST_FOREACH(port_info, port_list, list)
     {
         if ( port_info->port == port )
             goto found;
@@ -257,7 +257,7 @@ int xenevtchn_unbind(xenevtchn_handle *xce, evtchn_port_t port)
     struct port_info *port_info;
     struct port_list *port_list = file->dev;
 
-    LIST_FOREACH(port_info, port_list, list)
+    XEN_LIST_FOREACH(port_info, port_list, list)
     {
         if ( port_info->port == port )
         {
@@ -314,7 +314,7 @@ xenevtchn_port_or_error_t xenevtchn_pending(xenevtchn_handle *xce)
 
     file->read = false;
 
-    LIST_FOREACH(port_info, port_list, list)
+    XEN_LIST_FOREACH(port_info, port_list, list)
     {
         if ( port_info->port != -1 && port_info->pending )
         {
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Tue Feb 08 07:06:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 07:06:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267541.461309 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHKaN-0000Vm-8Q; Tue, 08 Feb 2022 07:06:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267541.461309; Tue, 08 Feb 2022 07:06:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHKaN-0000Uv-4m; Tue, 08 Feb 2022 07:06:47 +0000
Received: by outflank-mailman (input) for mailman id 267541;
 Tue, 08 Feb 2022 07:06:46 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=co3W=SX=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nHKaL-0008AS-K6
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 07:06:46 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ab49eb61-88ad-11ec-8f75-fffcc8bd4f1a;
 Tue, 08 Feb 2022 08:06:42 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 7B33B2110A;
 Tue,  8 Feb 2022 07:06:42 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 48DB813483;
 Tue,  8 Feb 2022 07:06:42 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id oIhxEIIWAmKxHgAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 08 Feb 2022 07:06:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ab49eb61-88ad-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1644304002; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=9PIRJvROq4WGxqvOvdeBhrJLUoEN4dl0PDZArfMcTVw=;
	b=mfy5fXqJzm0eOg/72w/B4AlvdDkCI4fbugLKDzk6YCl7Rn3o1j6Ej7lvKtgvuhDxuV5R9J
	LcRgd8sGHtCmypH5nN6skg/tL9zb1uAx9aTy52jJNFgGvRvhQYLZzpvrsxRQJr9HY0vF1F
	tnldAcD+iSwhFPgPdE07PWOg2+JvQxU=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>
Subject: [PATCH v3 5/5] tools/include: remove xen-external directory
Date: Tue,  8 Feb 2022 08:06:38 +0100
Message-Id: <20220208070638.5909-6-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220208070638.5909-1-jgross@suse.com>
References: <20220208070638.5909-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

There is no user of tools/include/xen-external/* left. Remove it.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 tools/include/xen-external/README             |   24 -
 tools/include/xen-external/bsd-COPYRIGHT      |  126 --
 tools/include/xen-external/bsd-queue.3        | 1044 -----------------
 .../xen-external/bsd-sys-queue-h-seddery      |   74 --
 tools/include/xen-external/bsd-sys-queue.h    |  637 ----------
 5 files changed, 1905 deletions(-)
 delete mode 100644 tools/include/xen-external/README
 delete mode 100644 tools/include/xen-external/bsd-COPYRIGHT
 delete mode 100644 tools/include/xen-external/bsd-queue.3
 delete mode 100755 tools/include/xen-external/bsd-sys-queue-h-seddery
 delete mode 100644 tools/include/xen-external/bsd-sys-queue.h

diff --git a/tools/include/xen-external/README b/tools/include/xen-external/README
deleted file mode 100644
index 93c2bc9cd8..0000000000
--- a/tools/include/xen-external/README
+++ /dev/null
@@ -1,24 +0,0 @@
-WARNING - DO NOT EDIT THINGS IN THIS DIRECTORY
-----------------------------------------------
-
-These files were obtained elsewhere and should only be updated by
-copying new versions from the source location, as documented below:
-
-bsd-COPYRIGHT
-bsd-sys-queue.h
-bsd-queue.3
-
-  Obtained from the FreeBSD SVN using the following commands:
-    svn co -r 221843 svn://svn.freebsd.org/base/head/sys/sys/
-    svn co -r 221843 svn://svn.freebsd.org/base/head/share/man/man3
-    svn cat -r 221843 http://svn.freebsd.org/base/head/COPYRIGHT >tools/libxl/external/bsd-COPYRIGHT
-
-Exceptions:
-
-README
-
-  This file
-
-bsd-sys-queue-h-seddery
-
-  Script to transform the above into a new namespace.
diff --git a/tools/include/xen-external/bsd-COPYRIGHT b/tools/include/xen-external/bsd-COPYRIGHT
deleted file mode 100644
index 6dc5d16b46..0000000000
--- a/tools/include/xen-external/bsd-COPYRIGHT
+++ /dev/null
@@ -1,126 +0,0 @@
-# $FreeBSD$
-#	@(#)COPYRIGHT	8.2 (Berkeley) 3/21/94
-
-The compilation of software known as FreeBSD is distributed under the
-following terms:
-
-Copyright (c) 1992-2011 The FreeBSD Project. All rights reserved.
-
-Redistribution and use in source and binary forms, with or without
-modification, are permitted provided that the following conditions
-are met:
-1. Redistributions of source code must retain the above copyright
-   notice, this list of conditions and the following disclaimer.
-2. Redistributions in binary form must reproduce the above copyright
-   notice, this list of conditions and the following disclaimer in the
-   documentation and/or other materials provided with the distribution.
-
-THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
-ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
-IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
-ARE DISCLAIMED.  IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
-FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
-DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
-OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
-HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
-LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
-OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
-SUCH DAMAGE.
-
-The 4.4BSD and 4.4BSD-Lite software is distributed under the following
-terms:
-
-All of the documentation and software included in the 4.4BSD and 4.4BSD-Lite
-Releases is copyrighted by The Regents of the University of California.
-
-Copyright 1979, 1980, 1983, 1986, 1988, 1989, 1991, 1992, 1993, 1994
-	The Regents of the University of California.  All rights reserved.
-
-Redistribution and use in source and binary forms, with or without
-modification, are permitted provided that the following conditions
-are met:
-1. Redistributions of source code must retain the above copyright
-   notice, this list of conditions and the following disclaimer.
-2. Redistributions in binary form must reproduce the above copyright
-   notice, this list of conditions and the following disclaimer in the
-   documentation and/or other materials provided with the distribution.
-3. All advertising materials mentioning features or use of this software
-   must display the following acknowledgement:
-This product includes software developed by the University of
-California, Berkeley and its contributors.
-4. Neither the name of the University nor the names of its contributors
-   may be used to endorse or promote products derived from this software
-   without specific prior written permission.
-
-THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND
-ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
-IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
-ARE DISCLAIMED.  IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE
-FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
-DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
-OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
-HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
-LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
-OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
-SUCH DAMAGE.
-
-The Institute of Electrical and Electronics Engineers and the American
-National Standards Committee X3, on Information Processing Systems have
-given us permission to reprint portions of their documentation.
-
-In the following statement, the phrase ``this text'' refers to portions
-of the system documentation.
-
-Portions of this text are reprinted and reproduced in electronic form in
-the second BSD Networking Software Release, from IEEE Std 1003.1-1988, IEEE
-Standard Portable Operating System Interface for Computer Environments
-(POSIX), copyright C 1988 by the Institute of Electrical and Electronics
-Engineers, Inc.  In the event of any discrepancy between these versions
-and the original IEEE Standard, the original IEEE Standard is the referee
-document.
-
-In the following statement, the phrase ``This material'' refers to portions
-of the system documentation.
-
-This material is reproduced with permission from American National
-Standards Committee X3, on Information Processing Systems.  Computer and
-Business Equipment Manufacturers Association (CBEMA), 311 First St., NW,
-Suite 500, Washington, DC 20001-2178.  The developmental work of
-Programming Language C was completed by the X3J11 Technical Committee.
-
-The views and conclusions contained in the software and documentation are
-those of the authors and should not be interpreted as representing official
-policies, either expressed or implied, of the Regents of the University
-of California.
-
-
-NOTE: The copyright of UC Berkeley's Berkeley Software Distribution ("BSD")
-source has been updated.  The copyright addendum may be found at
-ftp://ftp.cs.berkeley.edu/pub/4bsd/README.Impt.License.Change and is
-included below.
-
-July 22, 1999
-
-To All Licensees, Distributors of Any Version of BSD:
-
-As you know, certain of the Berkeley Software Distribution ("BSD") source
-code files require that further distributions of products containing all or
-portions of the software, acknowledge within their advertising materials
-that such products contain software developed by UC Berkeley and its
-contributors.
-
-Specifically, the provision reads:
-
-"     * 3. All advertising materials mentioning features or use of this software
-      *    must display the following acknowledgement:
-      *    This product includes software developed by the University of
-      *    California, Berkeley and its contributors."
-
-Effective immediately, licensees and distributors are no longer required to
-include the acknowledgement within advertising materials.  Accordingly, the
-foregoing paragraph of those BSD Unix files containing it is hereby deleted
-in its entirety.
-
-William Hoskins
-Director, Office of Technology Licensing
-University of California, Berkeley
diff --git a/tools/include/xen-external/bsd-queue.3 b/tools/include/xen-external/bsd-queue.3
deleted file mode 100644
index 007ca5c629..0000000000
--- a/tools/include/xen-external/bsd-queue.3
+++ /dev/null
@@ -1,1044 +0,0 @@
-.\" Copyright (c) 1993
-.\"	The Regents of the University of California.  All rights reserved.
-.\"
-.\" Redistribution and use in source and binary forms, with or without
-.\" modification, are permitted provided that the following conditions
-.\" are met:
-.\" 1. Redistributions of source code must retain the above copyright
-.\"    notice, this list of conditions and the following disclaimer.
-.\" 2. Redistributions in binary form must reproduce the above copyright
-.\"    notice, this list of conditions and the following disclaimer in the
-.\"    documentation and/or other materials provided with the distribution.
-.\" 3. All advertising materials mentioning features or use of this software
-.\"    must display the following acknowledgement:
-.\"	This product includes software developed by the University of
-.\"	California, Berkeley and its contributors.
-.\" 4. Neither the name of the University nor the names of its contributors
-.\"    may be used to endorse or promote products derived from this software
-.\"    without specific prior written permission.
-.\"
-.\" THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND
-.\" ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
-.\" IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
-.\" ARE DISCLAIMED.  IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE
-.\" FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
-.\" DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
-.\" OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
-.\" HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
-.\" LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
-.\" OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
-.\" SUCH DAMAGE.
-.\"
-.\"	@(#)queue.3	8.2 (Berkeley) 1/24/94
-.\" $FreeBSD$
-.\"
-.Dd May 13, 2011
-.Dt QUEUE 3
-.Os
-.Sh NAME
-.Nm SLIST_EMPTY ,
-.Nm SLIST_ENTRY ,
-.Nm SLIST_FIRST ,
-.Nm SLIST_FOREACH ,
-.Nm SLIST_FOREACH_SAFE ,
-.Nm SLIST_HEAD ,
-.Nm SLIST_HEAD_INITIALIZER ,
-.Nm SLIST_INIT ,
-.Nm SLIST_INSERT_AFTER ,
-.Nm SLIST_INSERT_HEAD ,
-.Nm SLIST_NEXT ,
-.Nm SLIST_REMOVE_AFTER ,
-.Nm SLIST_REMOVE_HEAD ,
-.Nm SLIST_REMOVE ,
-.Nm SLIST_SWAP ,
-.Nm STAILQ_CONCAT ,
-.Nm STAILQ_EMPTY ,
-.Nm STAILQ_ENTRY ,
-.Nm STAILQ_FIRST ,
-.Nm STAILQ_FOREACH ,
-.Nm STAILQ_FOREACH_SAFE ,
-.Nm STAILQ_HEAD ,
-.Nm STAILQ_HEAD_INITIALIZER ,
-.Nm STAILQ_INIT ,
-.Nm STAILQ_INSERT_AFTER ,
-.Nm STAILQ_INSERT_HEAD ,
-.Nm STAILQ_INSERT_TAIL ,
-.Nm STAILQ_LAST ,
-.Nm STAILQ_NEXT ,
-.Nm STAILQ_REMOVE_AFTER ,
-.Nm STAILQ_REMOVE_HEAD ,
-.Nm STAILQ_REMOVE ,
-.Nm STAILQ_SWAP ,
-.Nm LIST_EMPTY ,
-.Nm LIST_ENTRY ,
-.Nm LIST_FIRST ,
-.Nm LIST_FOREACH ,
-.Nm LIST_FOREACH_SAFE ,
-.Nm LIST_HEAD ,
-.Nm LIST_HEAD_INITIALIZER ,
-.Nm LIST_INIT ,
-.Nm LIST_INSERT_AFTER ,
-.Nm LIST_INSERT_BEFORE ,
-.Nm LIST_INSERT_HEAD ,
-.Nm LIST_NEXT ,
-.Nm LIST_REMOVE ,
-.Nm LIST_SWAP ,
-.Nm TAILQ_CONCAT ,
-.Nm TAILQ_EMPTY ,
-.Nm TAILQ_ENTRY ,
-.Nm TAILQ_FIRST ,
-.Nm TAILQ_FOREACH ,
-.Nm TAILQ_FOREACH_SAFE ,
-.Nm TAILQ_FOREACH_REVERSE ,
-.Nm TAILQ_FOREACH_REVERSE_SAFE ,
-.Nm TAILQ_HEAD ,
-.Nm TAILQ_HEAD_INITIALIZER ,
-.Nm TAILQ_INIT ,
-.Nm TAILQ_INSERT_AFTER ,
-.Nm TAILQ_INSERT_BEFORE ,
-.Nm TAILQ_INSERT_HEAD ,
-.Nm TAILQ_INSERT_TAIL ,
-.Nm TAILQ_LAST ,
-.Nm TAILQ_NEXT ,
-.Nm TAILQ_PREV ,
-.Nm TAILQ_REMOVE ,
-.Nm TAILQ_SWAP
-.Nd implementations of singly-linked lists, singly-linked tail queues,
-lists and tail queues
-.Sh SYNOPSIS
-.In sys/queue.h
-.\"
-.Fn SLIST_EMPTY "SLIST_HEAD *head"
-.Fn SLIST_ENTRY "TYPE"
-.Fn SLIST_FIRST "SLIST_HEAD *head"
-.Fn SLIST_FOREACH "TYPE *var" "SLIST_HEAD *head" "SLIST_ENTRY NAME"
-.Fn SLIST_FOREACH_SAFE "TYPE *var" "SLIST_HEAD *head" "SLIST_ENTRY NAME" "TYPE *temp_var"
-.Fn SLIST_HEAD "HEADNAME" "TYPE"
-.Fn SLIST_HEAD_INITIALIZER "SLIST_HEAD head"
-.Fn SLIST_INIT "SLIST_HEAD *head"
-.Fn SLIST_INSERT_AFTER "TYPE *listelm" "TYPE *elm" "SLIST_ENTRY NAME"
-.Fn SLIST_INSERT_HEAD "SLIST_HEAD *head" "TYPE *elm" "SLIST_ENTRY NAME"
-.Fn SLIST_NEXT "TYPE *elm" "SLIST_ENTRY NAME"
-.Fn SLIST_REMOVE_AFTER "TYPE *elm" "SLIST_ENTRY NAME"
-.Fn SLIST_REMOVE_HEAD "SLIST_HEAD *head" "SLIST_ENTRY NAME"
-.Fn SLIST_REMOVE "SLIST_HEAD *head" "TYPE *elm" "TYPE" "SLIST_ENTRY NAME"
-.Fn SLIST_SWAP "SLIST_HEAD *head1" "SLIST_HEAD *head2" "SLIST_ENTRY NAME"
-.\"
-.Fn STAILQ_CONCAT "STAILQ_HEAD *head1" "STAILQ_HEAD *head2"
-.Fn STAILQ_EMPTY "STAILQ_HEAD *head"
-.Fn STAILQ_ENTRY "TYPE"
-.Fn STAILQ_FIRST "STAILQ_HEAD *head"
-.Fn STAILQ_FOREACH "TYPE *var" "STAILQ_HEAD *head" "STAILQ_ENTRY NAME"
-.Fn STAILQ_FOREACH_SAFE "TYPE *var" "STAILQ_HEAD *head" "STAILQ_ENTRY NAME" "TYPE *temp_var"
-.Fn STAILQ_HEAD "HEADNAME" "TYPE"
-.Fn STAILQ_HEAD_INITIALIZER "STAILQ_HEAD head"
-.Fn STAILQ_INIT "STAILQ_HEAD *head"
-.Fn STAILQ_INSERT_AFTER "STAILQ_HEAD *head" "TYPE *listelm" "TYPE *elm" "STAILQ_ENTRY NAME"
-.Fn STAILQ_INSERT_HEAD "STAILQ_HEAD *head" "TYPE *elm" "STAILQ_ENTRY NAME"
-.Fn STAILQ_INSERT_TAIL "STAILQ_HEAD *head" "TYPE *elm" "STAILQ_ENTRY NAME"
-.Fn STAILQ_LAST "STAILQ_HEAD *head" "TYPE" "STAILQ_ENTRY NAME"
-.Fn STAILQ_NEXT "TYPE *elm" "STAILQ_ENTRY NAME"
-.Fn STAILQ_REMOVE_AFTER "STAILQ_HEAD *head" "TYPE *elm" "STAILQ_ENTRY NAME"
-.Fn STAILQ_REMOVE_HEAD "STAILQ_HEAD *head" "STAILQ_ENTRY NAME"
-.Fn STAILQ_REMOVE "STAILQ_HEAD *head" "TYPE *elm" "TYPE" "STAILQ_ENTRY NAME"
-.Fn STAILQ_SWAP "STAILQ_HEAD *head1" "STAILQ_HEAD *head2" "STAILQ_ENTRY NAME"
-.\"
-.Fn LIST_EMPTY "LIST_HEAD *head"
-.Fn LIST_ENTRY "TYPE"
-.Fn LIST_FIRST "LIST_HEAD *head"
-.Fn LIST_FOREACH "TYPE *var" "LIST_HEAD *head" "LIST_ENTRY NAME"
-.Fn LIST_FOREACH_SAFE "TYPE *var" "LIST_HEAD *head" "LIST_ENTRY NAME" "TYPE *temp_var"
-.Fn LIST_HEAD "HEADNAME" "TYPE"
-.Fn LIST_HEAD_INITIALIZER "LIST_HEAD head"
-.Fn LIST_INIT "LIST_HEAD *head"
-.Fn LIST_INSERT_AFTER "TYPE *listelm" "TYPE *elm" "LIST_ENTRY NAME"
-.Fn LIST_INSERT_BEFORE "TYPE *listelm" "TYPE *elm" "LIST_ENTRY NAME"
-.Fn LIST_INSERT_HEAD "LIST_HEAD *head" "TYPE *elm" "LIST_ENTRY NAME"
-.Fn LIST_NEXT "TYPE *elm" "LIST_ENTRY NAME"
-.Fn LIST_REMOVE "TYPE *elm" "LIST_ENTRY NAME"
-.Fn LIST_SWAP "LIST_HEAD *head1" "LIST_HEAD *head2" "TYPE" "LIST_ENTRY NAME"
-.\"
-.Fn TAILQ_CONCAT "TAILQ_HEAD *head1" "TAILQ_HEAD *head2" "TAILQ_ENTRY NAME"
-.Fn TAILQ_EMPTY "TAILQ_HEAD *head"
-.Fn TAILQ_ENTRY "TYPE"
-.Fn TAILQ_FIRST "TAILQ_HEAD *head"
-.Fn TAILQ_FOREACH "TYPE *var" "TAILQ_HEAD *head" "TAILQ_ENTRY NAME"
-.Fn TAILQ_FOREACH_SAFE "TYPE *var" "TAILQ_HEAD *head" "TAILQ_ENTRY NAME" "TYPE *temp_var"
-.Fn TAILQ_FOREACH_REVERSE "TYPE *var" "TAILQ_HEAD *head" "HEADNAME" "TAILQ_ENTRY NAME"
-.Fn TAILQ_FOREACH_REVERSE_SAFE "TYPE *var" "TAILQ_HEAD *head" "HEADNAME" "TAILQ_ENTRY NAME" "TYPE *temp_var"
-.Fn TAILQ_HEAD "HEADNAME" "TYPE"
-.Fn TAILQ_HEAD_INITIALIZER "TAILQ_HEAD head"
-.Fn TAILQ_INIT "TAILQ_HEAD *head"
-.Fn TAILQ_INSERT_AFTER "TAILQ_HEAD *head" "TYPE *listelm" "TYPE *elm" "TAILQ_ENTRY NAME"
-.Fn TAILQ_INSERT_BEFORE "TYPE *listelm" "TYPE *elm" "TAILQ_ENTRY NAME"
-.Fn TAILQ_INSERT_HEAD "TAILQ_HEAD *head" "TYPE *elm" "TAILQ_ENTRY NAME"
-.Fn TAILQ_INSERT_TAIL "TAILQ_HEAD *head" "TYPE *elm" "TAILQ_ENTRY NAME"
-.Fn TAILQ_LAST "TAILQ_HEAD *head" "HEADNAME"
-.Fn TAILQ_NEXT "TYPE *elm" "TAILQ_ENTRY NAME"
-.Fn TAILQ_PREV "TYPE *elm" "HEADNAME" "TAILQ_ENTRY NAME"
-.Fn TAILQ_REMOVE "TAILQ_HEAD *head" "TYPE *elm" "TAILQ_ENTRY NAME"
-.Fn TAILQ_SWAP "TAILQ_HEAD *head1" "TAILQ_HEAD *head2" "TYPE" "TAILQ_ENTRY NAME"
-.\"
-.Sh DESCRIPTION
-These macros define and operate on four types of data structures:
-singly-linked lists, singly-linked tail queues, lists, and tail queues.
-All four structures support the following functionality:
-.Bl -enum -compact -offset indent
-.It
-Insertion of a new entry at the head of the list.
-.It
-Insertion of a new entry after any element in the list.
-.It
-O(1) removal of an entry from the head of the list.
-.It
-Forward traversal through the list.
-.It
-Swawpping the contents of two lists.
-.El
-.Pp
-Singly-linked lists are the simplest of the four data structures
-and support only the above functionality.
-Singly-linked lists are ideal for applications with large datasets
-and few or no removals,
-or for implementing a LIFO queue.
-Singly-linked lists add the following functionality:
-.Bl -enum -compact -offset indent
-.It
-O(n) removal of any entry in the list.
-.El
-.Pp
-Singly-linked tail queues add the following functionality:
-.Bl -enum -compact -offset indent
-.It
-Entries can be added at the end of a list.
-.It
-O(n) removal of any entry in the list.
-.It
-They may be concatenated.
-.El
-However:
-.Bl -enum -compact -offset indent
-.It
-All list insertions must specify the head of the list.
-.It
-Each head entry requires two pointers rather than one.
-.It
-Code size is about 15% greater and operations run about 20% slower
-than singly-linked lists.
-.El
-.Pp
-Singly-linked tailqs are ideal for applications with large datasets and
-few or no removals,
-or for implementing a FIFO queue.
-.Pp
-All doubly linked types of data structures (lists and tail queues)
-additionally allow:
-.Bl -enum -compact -offset indent
-.It
-Insertion of a new entry before any element in the list.
-.It
-O(1) removal of any entry in the list.
-.El
-However:
-.Bl -enum -compact -offset indent
-.It
-Each element requires two pointers rather than one.
-.It
-Code size and execution time of operations (except for removal) is about
-twice that of the singly-linked data-structures.
-.El
-.Pp
-Linked lists are the simplest of the doubly linked data structures and support
-only the above functionality over singly-linked lists.
-.Pp
-Tail queues add the following functionality:
-.Bl -enum -compact -offset indent
-.It
-Entries can be added at the end of a list.
-.It
-They may be traversed backwards, from tail to head.
-.It
-They may be concatenated.
-.El
-However:
-.Bl -enum -compact -offset indent
-.It
-All list insertions and removals must specify the head of the list.
-.It
-Each head entry requires two pointers rather than one.
-.It
-Code size is about 15% greater and operations run about 20% slower
-than singly-linked lists.
-.El
-.Pp
-In the macro definitions,
-.Fa TYPE
-is the name of a user defined structure,
-that must contain a field of type
-.Li SLIST_ENTRY ,
-.Li STAILQ_ENTRY ,
-.Li LIST_ENTRY ,
-or
-.Li TAILQ_ENTRY ,
-named
-.Fa NAME .
-The argument
-.Fa HEADNAME
-is the name of a user defined structure that must be declared
-using the macros
-.Li SLIST_HEAD ,
-.Li STAILQ_HEAD ,
-.Li LIST_HEAD ,
-or
-.Li TAILQ_HEAD .
-See the examples below for further explanation of how these
-macros are used.
-.Sh SINGLY-LINKED LISTS
-A singly-linked list is headed by a structure defined by the
-.Nm SLIST_HEAD
-macro.
-This structure contains a single pointer to the first element
-on the list.
-The elements are singly linked for minimum space and pointer manipulation
-overhead at the expense of O(n) removal for arbitrary elements.
-New elements can be added to the list after an existing element or
-at the head of the list.
-An
-.Fa SLIST_HEAD
-structure is declared as follows:
-.Bd -literal -offset indent
-SLIST_HEAD(HEADNAME, TYPE) head;
-.Ed
-.Pp
-where
-.Fa HEADNAME
-is the name of the structure to be defined, and
-.Fa TYPE
-is the type of the elements to be linked into the list.
-A pointer to the head of the list can later be declared as:
-.Bd -literal -offset indent
-struct HEADNAME *headp;
-.Ed
-.Pp
-(The names
-.Li head
-and
-.Li headp
-are user selectable.)
-.Pp
-The macro
-.Nm SLIST_HEAD_INITIALIZER
-evaluates to an initializer for the list
-.Fa head .
-.Pp
-The macro
-.Nm SLIST_EMPTY
-evaluates to true if there are no elements in the list.
-.Pp
-The macro
-.Nm SLIST_ENTRY
-declares a structure that connects the elements in
-the list.
-.Pp
-The macro
-.Nm SLIST_FIRST
-returns the first element in the list or NULL if the list is empty.
-.Pp
-The macro
-.Nm SLIST_FOREACH
-traverses the list referenced by
-.Fa head
-in the forward direction, assigning each element in
-turn to
-.Fa var .
-.Pp
-The macro
-.Nm SLIST_FOREACH_SAFE
-traverses the list referenced by
-.Fa head
-in the forward direction, assigning each element in
-turn to
-.Fa var .
-However, unlike
-.Fn SLIST_FOREACH
-here it is permitted to both remove
-.Fa var
-as well as free it from within the loop safely without interfering with the
-traversal.
-.Pp
-The macro
-.Nm SLIST_INIT
-initializes the list referenced by
-.Fa head .
-.Pp
-The macro
-.Nm SLIST_INSERT_HEAD
-inserts the new element
-.Fa elm
-at the head of the list.
-.Pp
-The macro
-.Nm SLIST_INSERT_AFTER
-inserts the new element
-.Fa elm
-after the element
-.Fa listelm .
-.Pp
-The macro
-.Nm SLIST_NEXT
-returns the next element in the list.
-.Pp
-The macro
-.Nm SLIST_REMOVE_AFTER
-removes the element after
-.Fa elm
-from the list. Unlike
-.Fa SLIST_REMOVE ,
-this macro does not traverse the entire list.
-.Pp
-The macro
-.Nm SLIST_REMOVE_HEAD
-removes the element
-.Fa elm
-from the head of the list.
-For optimum efficiency,
-elements being removed from the head of the list should explicitly use
-this macro instead of the generic
-.Fa SLIST_REMOVE
-macro.
-.Pp
-The macro
-.Nm SLIST_REMOVE
-removes the element
-.Fa elm
-from the list.
-.Pp
-The macro
-.Nm SLIST_SWAP
-swaps the contents of
-.Fa head1
-and
-.Fa head2 .
-.Sh SINGLY-LINKED LIST EXAMPLE
-.Bd -literal
-SLIST_HEAD(slisthead, entry) head =
-    SLIST_HEAD_INITIALIZER(head);
-struct slisthead *headp;		/* Singly-linked List head. */
-struct entry {
-	...
-	SLIST_ENTRY(entry) entries;	/* Singly-linked List. */
-	...
-} *n1, *n2, *n3, *np;
-
-SLIST_INIT(&head);			/* Initialize the list. */
-
-n1 = malloc(sizeof(struct entry));	/* Insert at the head. */
-SLIST_INSERT_HEAD(&head, n1, entries);
-
-n2 = malloc(sizeof(struct entry));	/* Insert after. */
-SLIST_INSERT_AFTER(n1, n2, entries);
-
-SLIST_REMOVE(&head, n2, entry, entries);/* Deletion. */
-free(n2);
-
-n3 = SLIST_FIRST(&head);
-SLIST_REMOVE_HEAD(&head, entries);	/* Deletion from the head. */
-free(n3);
-					/* Forward traversal. */
-SLIST_FOREACH(np, &head, entries)
-	np-> ...
-					/* Safe forward traversal. */
-SLIST_FOREACH_SAFE(np, &head, entries, np_temp) {
-	np->do_stuff();
-	...
-	SLIST_REMOVE(&head, np, entry, entries);
-	free(np);
-}
-
-while (!SLIST_EMPTY(&head)) {		/* List Deletion. */
-	n1 = SLIST_FIRST(&head);
-	SLIST_REMOVE_HEAD(&head, entries);
-	free(n1);
-}
-.Ed
-.Sh SINGLY-LINKED TAIL QUEUES
-A singly-linked tail queue is headed by a structure defined by the
-.Nm STAILQ_HEAD
-macro.
-This structure contains a pair of pointers,
-one to the first element in the tail queue and the other to
-the last element in the tail queue.
-The elements are singly linked for minimum space and pointer
-manipulation overhead at the expense of O(n) removal for arbitrary
-elements.
-New elements can be added to the tail queue after an existing element,
-at the head of the tail queue, or at the end of the tail queue.
-A
-.Fa STAILQ_HEAD
-structure is declared as follows:
-.Bd -literal -offset indent
-STAILQ_HEAD(HEADNAME, TYPE) head;
-.Ed
-.Pp
-where
-.Li HEADNAME
-is the name of the structure to be defined, and
-.Li TYPE
-is the type of the elements to be linked into the tail queue.
-A pointer to the head of the tail queue can later be declared as:
-.Bd -literal -offset indent
-struct HEADNAME *headp;
-.Ed
-.Pp
-(The names
-.Li head
-and
-.Li headp
-are user selectable.)
-.Pp
-The macro
-.Nm STAILQ_HEAD_INITIALIZER
-evaluates to an initializer for the tail queue
-.Fa head .
-.Pp
-The macro
-.Nm STAILQ_CONCAT
-concatenates the tail queue headed by
-.Fa head2
-onto the end of the one headed by
-.Fa head1
-removing all entries from the former.
-.Pp
-The macro
-.Nm STAILQ_EMPTY
-evaluates to true if there are no items on the tail queue.
-.Pp
-The macro
-.Nm STAILQ_ENTRY
-declares a structure that connects the elements in
-the tail queue.
-.Pp
-The macro
-.Nm STAILQ_FIRST
-returns the first item on the tail queue or NULL if the tail queue
-is empty.
-.Pp
-The macro
-.Nm STAILQ_FOREACH
-traverses the tail queue referenced by
-.Fa head
-in the forward direction, assigning each element
-in turn to
-.Fa var .
-.Pp
-The macro
-.Nm STAILQ_FOREACH_SAFE
-traverses the tail queue referenced by
-.Fa head
-in the forward direction, assigning each element
-in turn to
-.Fa var .
-However, unlike
-.Fn STAILQ_FOREACH
-here it is permitted to both remove
-.Fa var
-as well as free it from within the loop safely without interfering with the
-traversal.
-.Pp
-The macro
-.Nm STAILQ_INIT
-initializes the tail queue referenced by
-.Fa head .
-.Pp
-The macro
-.Nm STAILQ_INSERT_HEAD
-inserts the new element
-.Fa elm
-at the head of the tail queue.
-.Pp
-The macro
-.Nm STAILQ_INSERT_TAIL
-inserts the new element
-.Fa elm
-at the end of the tail queue.
-.Pp
-The macro
-.Nm STAILQ_INSERT_AFTER
-inserts the new element
-.Fa elm
-after the element
-.Fa listelm .
-.Pp
-The macro
-.Nm STAILQ_LAST
-returns the last item on the tail queue.
-If the tail queue is empty the return value is
-.Dv NULL .
-.Pp
-The macro
-.Nm STAILQ_NEXT
-returns the next item on the tail queue, or NULL this item is the last.
-.Pp
-The macro
-.Nm STAILQ_REMOVE_AFTER
-removes the element after
-.Fa elm
-from the tail queue. Unlike
-.Fa STAILQ_REMOVE ,
-this macro does not traverse the entire tail queue.
-.Pp
-The macro
-.Nm STAILQ_REMOVE_HEAD
-removes the element at the head of the tail queue.
-For optimum efficiency,
-elements being removed from the head of the tail queue should
-use this macro explicitly rather than the generic
-.Fa STAILQ_REMOVE
-macro.
-.Pp
-The macro
-.Nm STAILQ_REMOVE
-removes the element
-.Fa elm
-from the tail queue.
-.Pp
-The macro
-.Nm STAILQ_SWAP
-swaps the contents of
-.Fa head1
-and
-.Fa head2 .
-.Sh SINGLY-LINKED TAIL QUEUE EXAMPLE
-.Bd -literal
-STAILQ_HEAD(stailhead, entry) head =
-    STAILQ_HEAD_INITIALIZER(head);
-struct stailhead *headp;		/* Singly-linked tail queue head. */
-struct entry {
-	...
-	STAILQ_ENTRY(entry) entries;	/* Tail queue. */
-	...
-} *n1, *n2, *n3, *np;
-
-STAILQ_INIT(&head);			/* Initialize the queue. */
-
-n1 = malloc(sizeof(struct entry));	/* Insert at the head. */
-STAILQ_INSERT_HEAD(&head, n1, entries);
-
-n1 = malloc(sizeof(struct entry));	/* Insert at the tail. */
-STAILQ_INSERT_TAIL(&head, n1, entries);
-
-n2 = malloc(sizeof(struct entry));	/* Insert after. */
-STAILQ_INSERT_AFTER(&head, n1, n2, entries);
-					/* Deletion. */
-STAILQ_REMOVE(&head, n2, entry, entries);
-free(n2);
-					/* Deletion from the head. */
-n3 = STAILQ_FIRST(&head);
-STAILQ_REMOVE_HEAD(&head, entries);
-free(n3);
-					/* Forward traversal. */
-STAILQ_FOREACH(np, &head, entries)
-	np-> ...
-					/* Safe forward traversal. */
-STAILQ_FOREACH_SAFE(np, &head, entries, np_temp) {
-	np->do_stuff();
-	...
-	STAILQ_REMOVE(&head, np, entry, entries);
-	free(np);
-}
-					/* TailQ Deletion. */
-while (!STAILQ_EMPTY(&head)) {
-	n1 = STAILQ_FIRST(&head);
-	STAILQ_REMOVE_HEAD(&head, entries);
-	free(n1);
-}
-					/* Faster TailQ Deletion. */
-n1 = STAILQ_FIRST(&head);
-while (n1 != NULL) {
-	n2 = STAILQ_NEXT(n1, entries);
-	free(n1);
-	n1 = n2;
-}
-STAILQ_INIT(&head);
-.Ed
-.Sh LISTS
-A list is headed by a structure defined by the
-.Nm LIST_HEAD
-macro.
-This structure contains a single pointer to the first element
-on the list.
-The elements are doubly linked so that an arbitrary element can be
-removed without traversing the list.
-New elements can be added to the list after an existing element,
-before an existing element, or at the head of the list.
-A
-.Fa LIST_HEAD
-structure is declared as follows:
-.Bd -literal -offset indent
-LIST_HEAD(HEADNAME, TYPE) head;
-.Ed
-.Pp
-where
-.Fa HEADNAME
-is the name of the structure to be defined, and
-.Fa TYPE
-is the type of the elements to be linked into the list.
-A pointer to the head of the list can later be declared as:
-.Bd -literal -offset indent
-struct HEADNAME *headp;
-.Ed
-.Pp
-(The names
-.Li head
-and
-.Li headp
-are user selectable.)
-.Pp
-The macro
-.Nm LIST_HEAD_INITIALIZER
-evaluates to an initializer for the list
-.Fa head .
-.Pp
-The macro
-.Nm LIST_EMPTY
-evaluates to true if there are no elements in the list.
-.Pp
-The macro
-.Nm LIST_ENTRY
-declares a structure that connects the elements in
-the list.
-.Pp
-The macro
-.Nm LIST_FIRST
-returns the first element in the list or NULL if the list
-is empty.
-.Pp
-The macro
-.Nm LIST_FOREACH
-traverses the list referenced by
-.Fa head
-in the forward direction, assigning each element in turn to
-.Fa var .
-.Pp
-The macro
-.Nm LIST_FOREACH_SAFE
-traverses the list referenced by
-.Fa head
-in the forward direction, assigning each element in turn to
-.Fa var .
-However, unlike
-.Fn LIST_FOREACH
-here it is permitted to both remove
-.Fa var
-as well as free it from within the loop safely without interfering with the
-traversal.
-.Pp
-The macro
-.Nm LIST_INIT
-initializes the list referenced by
-.Fa head .
-.Pp
-The macro
-.Nm LIST_INSERT_HEAD
-inserts the new element
-.Fa elm
-at the head of the list.
-.Pp
-The macro
-.Nm LIST_INSERT_AFTER
-inserts the new element
-.Fa elm
-after the element
-.Fa listelm .
-.Pp
-The macro
-.Nm LIST_INSERT_BEFORE
-inserts the new element
-.Fa elm
-before the element
-.Fa listelm .
-.Pp
-The macro
-.Nm LIST_NEXT
-returns the next element in the list, or NULL if this is the last.
-.Pp
-The macro
-.Nm LIST_REMOVE
-removes the element
-.Fa elm
-from the list.
-.Pp
-The macro
-.Nm LIST_SWAP
-swaps the contents of
-.Fa head1
-and
-.Fa head2 .
-.Sh LIST EXAMPLE
-.Bd -literal
-LIST_HEAD(listhead, entry) head =
-    LIST_HEAD_INITIALIZER(head);
-struct listhead *headp;			/* List head. */
-struct entry {
-	...
-	LIST_ENTRY(entry) entries;	/* List. */
-	...
-} *n1, *n2, *n3, *np, *np_temp;
-
-LIST_INIT(&head);			/* Initialize the list. */
-
-n1 = malloc(sizeof(struct entry));	/* Insert at the head. */
-LIST_INSERT_HEAD(&head, n1, entries);
-
-n2 = malloc(sizeof(struct entry));	/* Insert after. */
-LIST_INSERT_AFTER(n1, n2, entries);
-
-n3 = malloc(sizeof(struct entry));	/* Insert before. */
-LIST_INSERT_BEFORE(n2, n3, entries);
-
-LIST_REMOVE(n2, entries);		/* Deletion. */
-free(n2);
-					/* Forward traversal. */
-LIST_FOREACH(np, &head, entries)
-	np-> ...
-
-					/* Safe forward traversal. */
-LIST_FOREACH_SAFE(np, &head, entries, np_temp) {
-	np->do_stuff();
-	...
-	LIST_REMOVE(np, entries);
-	free(np);
-}
-
-while (!LIST_EMPTY(&head)) {		/* List Deletion. */
-	n1 = LIST_FIRST(&head);
-	LIST_REMOVE(n1, entries);
-	free(n1);
-}
-
-n1 = LIST_FIRST(&head);			/* Faster List Deletion. */
-while (n1 != NULL) {
-	n2 = LIST_NEXT(n1, entries);
-	free(n1);
-	n1 = n2;
-}
-LIST_INIT(&head);
-.Ed
-.Sh TAIL QUEUES
-A tail queue is headed by a structure defined by the
-.Nm TAILQ_HEAD
-macro.
-This structure contains a pair of pointers,
-one to the first element in the tail queue and the other to
-the last element in the tail queue.
-The elements are doubly linked so that an arbitrary element can be
-removed without traversing the tail queue.
-New elements can be added to the tail queue after an existing element,
-before an existing element, at the head of the tail queue,
-or at the end of the tail queue.
-A
-.Fa TAILQ_HEAD
-structure is declared as follows:
-.Bd -literal -offset indent
-TAILQ_HEAD(HEADNAME, TYPE) head;
-.Ed
-.Pp
-where
-.Li HEADNAME
-is the name of the structure to be defined, and
-.Li TYPE
-is the type of the elements to be linked into the tail queue.
-A pointer to the head of the tail queue can later be declared as:
-.Bd -literal -offset indent
-struct HEADNAME *headp;
-.Ed
-.Pp
-(The names
-.Li head
-and
-.Li headp
-are user selectable.)
-.Pp
-The macro
-.Nm TAILQ_HEAD_INITIALIZER
-evaluates to an initializer for the tail queue
-.Fa head .
-.Pp
-The macro
-.Nm TAILQ_CONCAT
-concatenates the tail queue headed by
-.Fa head2
-onto the end of the one headed by
-.Fa head1
-removing all entries from the former.
-.Pp
-The macro
-.Nm TAILQ_EMPTY
-evaluates to true if there are no items on the tail queue.
-.Pp
-The macro
-.Nm TAILQ_ENTRY
-declares a structure that connects the elements in
-the tail queue.
-.Pp
-The macro
-.Nm TAILQ_FIRST
-returns the first item on the tail queue or NULL if the tail queue
-is empty.
-.Pp
-The macro
-.Nm TAILQ_FOREACH
-traverses the tail queue referenced by
-.Fa head
-in the forward direction, assigning each element in turn to
-.Fa var .
-.Fa var
-is set to
-.Dv NULL
-if the loop completes normally, or if there were no elements.
-.Pp
-The macro
-.Nm TAILQ_FOREACH_REVERSE
-traverses the tail queue referenced by
-.Fa head
-in the reverse direction, assigning each element in turn to
-.Fa var .
-.Pp
-The macros
-.Nm TAILQ_FOREACH_SAFE
-and
-.Nm TAILQ_FOREACH_REVERSE_SAFE
-traverse the list referenced by
-.Fa head
-in the forward or reverse direction respectively,
-assigning each element in turn to
-.Fa var .
-However, unlike their unsafe counterparts,
-.Nm TAILQ_FOREACH
-and
-.Nm TAILQ_FOREACH_REVERSE
-permit to both remove
-.Fa var
-as well as free it from within the loop safely without interfering with the
-traversal.
-.Pp
-The macro
-.Nm TAILQ_INIT
-initializes the tail queue referenced by
-.Fa head .
-.Pp
-The macro
-.Nm TAILQ_INSERT_HEAD
-inserts the new element
-.Fa elm
-at the head of the tail queue.
-.Pp
-The macro
-.Nm TAILQ_INSERT_TAIL
-inserts the new element
-.Fa elm
-at the end of the tail queue.
-.Pp
-The macro
-.Nm TAILQ_INSERT_AFTER
-inserts the new element
-.Fa elm
-after the element
-.Fa listelm .
-.Pp
-The macro
-.Nm TAILQ_INSERT_BEFORE
-inserts the new element
-.Fa elm
-before the element
-.Fa listelm .
-.Pp
-The macro
-.Nm TAILQ_LAST
-returns the last item on the tail queue.
-If the tail queue is empty the return value is
-.Dv NULL .
-.Pp
-The macro
-.Nm TAILQ_NEXT
-returns the next item on the tail queue, or NULL if this item is the last.
-.Pp
-The macro
-.Nm TAILQ_PREV
-returns the previous item on the tail queue, or NULL if this item
-is the first.
-.Pp
-The macro
-.Nm TAILQ_REMOVE
-removes the element
-.Fa elm
-from the tail queue.
-.Pp
-The macro
-.Nm TAILQ_SWAP
-swaps the contents of
-.Fa head1
-and
-.Fa head2 .
-.Sh TAIL QUEUE EXAMPLE
-.Bd -literal
-TAILQ_HEAD(tailhead, entry) head =
-    TAILQ_HEAD_INITIALIZER(head);
-struct tailhead *headp;			/* Tail queue head. */
-struct entry {
-	...
-	TAILQ_ENTRY(entry) entries;	/* Tail queue. */
-	...
-} *n1, *n2, *n3, *np;
-
-TAILQ_INIT(&head);			/* Initialize the queue. */
-
-n1 = malloc(sizeof(struct entry));	/* Insert at the head. */
-TAILQ_INSERT_HEAD(&head, n1, entries);
-
-n1 = malloc(sizeof(struct entry));	/* Insert at the tail. */
-TAILQ_INSERT_TAIL(&head, n1, entries);
-
-n2 = malloc(sizeof(struct entry));	/* Insert after. */
-TAILQ_INSERT_AFTER(&head, n1, n2, entries);
-
-n3 = malloc(sizeof(struct entry));	/* Insert before. */
-TAILQ_INSERT_BEFORE(n2, n3, entries);
-
-TAILQ_REMOVE(&head, n2, entries);	/* Deletion. */
-free(n2);
-					/* Forward traversal. */
-TAILQ_FOREACH(np, &head, entries)
-	np-> ...
-					/* Safe forward traversal. */
-TAILQ_FOREACH_SAFE(np, &head, entries, np_temp) {
-	np->do_stuff();
-	...
-	TAILQ_REMOVE(&head, np, entries);
-	free(np);
-}
-					/* Reverse traversal. */
-TAILQ_FOREACH_REVERSE(np, &head, tailhead, entries)
-	np-> ...
-					/* TailQ Deletion. */
-while (!TAILQ_EMPTY(&head)) {
-	n1 = TAILQ_FIRST(&head);
-	TAILQ_REMOVE(&head, n1, entries);
-	free(n1);
-}
-					/* Faster TailQ Deletion. */
-n1 = TAILQ_FIRST(&head);
-while (n1 != NULL) {
-	n2 = TAILQ_NEXT(n1, entries);
-	free(n1);
-	n1 = n2;
-}
-TAILQ_INIT(&head);
-.Ed
-.Sh SEE ALSO
-.Xr tree 3
-.Sh HISTORY
-The
-.Nm queue
-functions first appeared in
-.Bx 4.4 .
diff --git a/tools/include/xen-external/bsd-sys-queue-h-seddery b/tools/include/xen-external/bsd-sys-queue-h-seddery
deleted file mode 100755
index 3f8716d9ff..0000000000
--- a/tools/include/xen-external/bsd-sys-queue-h-seddery
+++ /dev/null
@@ -1,74 +0,0 @@
-#!/usr/bin/perl -p
-#
-# This script is part of the Xen build system.  It has a very
-# permissive licence to avoid complicating the licence of the
-# generated header file and to allow this seddery to be reused by
-# other projects.
-#
-# Permission is hereby granted, free of charge, to any person
-# obtaining a copy of this individual file (the "Software"), to deal
-# in the Software without restriction, including without limitation
-# the rights to use, copy, modify, merge, publish, distribute,
-# sublicense, and/or sell copies of the Software, and to permit
-# persons to whom the Software is furnished to do so, subject to the
-# following conditions:
-#
-# The above copyright notice and this permission notice shall be
-# included in all copies or substantial portions of the Software.
-#
-# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
-# EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
-# MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
-# NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS
-# BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN
-# ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
-# CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
-# SOFTWARE.
-#
-# Copyright (C) 2011 Citrix Ltd
-
-our $namespace, $ucnamespace;
-
-BEGIN {
-    die unless @ARGV;
-    $namespace = pop @ARGV;
-    $namespace =~ s/^--prefix=// or die;
-    $ucnamespace = uc $namespace;
-
-    print <<END or die $!;
-/*
- * DO NOT EDIT THIS FILE
- *
- * Generated automatically by bsd-sys-queue-h-seddery to
- *  - introduce ${ucnamespace}_ and ${namespace}_ namespace prefixes
- *  - turn "struct type" into "type" so that type arguments
- *     to the macros are type names not struct tags
- *  - remove the reference to sys/cdefs.h, which is not needed
- *
- * The purpose of this seddery is to allow the resulting file to be
- * freely included by software which might also want to include other
- * list macros; to make it usable when struct tags are not being used
- * or not known; to make it more portable.
- */
-END
-}
-
-s/\b( _SYS_QUEUE |
-      SLIST | LIST | STAILQ | TAILQ | QUEUE
-      )/${ucnamespace}_$1/xg;
-
-s/\b( TRACEBUF | TRASHIT |
-      QMD_
-      )/${ucnamespace}__$1/xg;
-
-s/\b(
-      qm_
-      )/${namespace}__$1/xg;
-
-s/\b struct \s+ type \b/type/xg;
-
-s,^\#include.*sys/cdefs.*,/* $& */,xg;
-
-s,\b __offsetof \b ,offsetof,xg;
-
-s/\b( NULL )/0/xg;
diff --git a/tools/include/xen-external/bsd-sys-queue.h b/tools/include/xen-external/bsd-sys-queue.h
deleted file mode 100644
index 274e636c53..0000000000
--- a/tools/include/xen-external/bsd-sys-queue.h
+++ /dev/null
@@ -1,637 +0,0 @@
-/*-
- * Copyright (c) 1991, 1993
- *	The Regents of the University of California.  All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- *    notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- *    notice, this list of conditions and the following disclaimer in the
- *    documentation and/or other materials provided with the distribution.
- * 4. Neither the name of the University nor the names of its contributors
- *    may be used to endorse or promote products derived from this software
- *    without specific prior written permission.
- *
- * THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND
- * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
- * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
- * ARE DISCLAIMED.  IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE
- * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
- * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
- * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
- * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
- * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
- * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
- * SUCH DAMAGE.
- *
- *	@(#)queue.h	8.5 (Berkeley) 8/20/94
- * $FreeBSD$
- */
-
-#ifndef _SYS_QUEUE_H_
-#define	_SYS_QUEUE_H_
-
-#include <sys/cdefs.h>
-
-/*
- * This file defines four types of data structures: singly-linked lists,
- * singly-linked tail queues, lists and tail queues.
- *
- * A singly-linked list is headed by a single forward pointer. The elements
- * are singly linked for minimum space and pointer manipulation overhead at
- * the expense of O(n) removal for arbitrary elements. New elements can be
- * added to the list after an existing element or at the head of the list.
- * Elements being removed from the head of the list should use the explicit
- * macro for this purpose for optimum efficiency. A singly-linked list may
- * only be traversed in the forward direction.  Singly-linked lists are ideal
- * for applications with large datasets and few or no removals or for
- * implementing a LIFO queue.
- *
- * A singly-linked tail queue is headed by a pair of pointers, one to the
- * head of the list and the other to the tail of the list. The elements are
- * singly linked for minimum space and pointer manipulation overhead at the
- * expense of O(n) removal for arbitrary elements. New elements can be added
- * to the list after an existing element, at the head of the list, or at the
- * end of the list. Elements being removed from the head of the tail queue
- * should use the explicit macro for this purpose for optimum efficiency.
- * A singly-linked tail queue may only be traversed in the forward direction.
- * Singly-linked tail queues are ideal for applications with large datasets
- * and few or no removals or for implementing a FIFO queue.
- *
- * A list is headed by a single forward pointer (or an array of forward
- * pointers for a hash table header). The elements are doubly linked
- * so that an arbitrary element can be removed without a need to
- * traverse the list. New elements can be added to the list before
- * or after an existing element or at the head of the list. A list
- * may only be traversed in the forward direction.
- *
- * A tail queue is headed by a pair of pointers, one to the head of the
- * list and the other to the tail of the list. The elements are doubly
- * linked so that an arbitrary element can be removed without a need to
- * traverse the list. New elements can be added to the list before or
- * after an existing element, at the head of the list, or at the end of
- * the list. A tail queue may be traversed in either direction.
- *
- * For details on the use of these macros, see the queue(3) manual page.
- *
- *
- *				SLIST	LIST	STAILQ	TAILQ
- * _HEAD			+	+	+	+
- * _HEAD_INITIALIZER		+	+	+	+
- * _ENTRY			+	+	+	+
- * _INIT			+	+	+	+
- * _EMPTY			+	+	+	+
- * _FIRST			+	+	+	+
- * _NEXT			+	+	+	+
- * _PREV			-	-	-	+
- * _LAST			-	-	+	+
- * _FOREACH			+	+	+	+
- * _FOREACH_SAFE		+	+	+	+
- * _FOREACH_REVERSE		-	-	-	+
- * _FOREACH_REVERSE_SAFE	-	-	-	+
- * _INSERT_HEAD			+	+	+	+
- * _INSERT_BEFORE		-	+	-	+
- * _INSERT_AFTER		+	+	+	+
- * _INSERT_TAIL			-	-	+	+
- * _CONCAT			-	-	+	+
- * _REMOVE_AFTER		+	-	+	-
- * _REMOVE_HEAD			+	-	+	-
- * _REMOVE			+	+	+	+
- * _SWAP			+	+	+	+
- *
- */
-#ifdef QUEUE_MACRO_DEBUG
-/* Store the last 2 places the queue element or head was altered */
-struct qm_trace {
-	char * lastfile;
-	int lastline;
-	char * prevfile;
-	int prevline;
-};
-
-#define	TRACEBUF	struct qm_trace trace;
-#define	TRASHIT(x)	do {(x) = (void *)-1;} while (0)
-#define	QMD_SAVELINK(name, link)	void **name = (void *)&(link)
-
-#define	QMD_TRACE_HEAD(head) do {					\
-	(head)->trace.prevline = (head)->trace.lastline;		\
-	(head)->trace.prevfile = (head)->trace.lastfile;		\
-	(head)->trace.lastline = __LINE__;				\
-	(head)->trace.lastfile = __FILE__;				\
-} while (0)
-
-#define	QMD_TRACE_ELEM(elem) do {					\
-	(elem)->trace.prevline = (elem)->trace.lastline;		\
-	(elem)->trace.prevfile = (elem)->trace.lastfile;		\
-	(elem)->trace.lastline = __LINE__;				\
-	(elem)->trace.lastfile = __FILE__;				\
-} while (0)
-
-#else
-#define	QMD_TRACE_ELEM(elem)
-#define	QMD_TRACE_HEAD(head)
-#define	QMD_SAVELINK(name, link)
-#define	TRACEBUF
-#define	TRASHIT(x)
-#endif	/* QUEUE_MACRO_DEBUG */
-
-/*
- * Singly-linked List declarations.
- */
-#define	SLIST_HEAD(name, type)						\
-struct name {								\
-	struct type *slh_first;	/* first element */			\
-}
-
-#define	SLIST_HEAD_INITIALIZER(head)					\
-	{ NULL }
-
-#define	SLIST_ENTRY(type)						\
-struct {								\
-	struct type *sle_next;	/* next element */			\
-}
-
-/*
- * Singly-linked List functions.
- */
-#define	SLIST_EMPTY(head)	((head)->slh_first == NULL)
-
-#define	SLIST_FIRST(head)	((head)->slh_first)
-
-#define	SLIST_FOREACH(var, head, field)					\
-	for ((var) = SLIST_FIRST((head));				\
-	    (var);							\
-	    (var) = SLIST_NEXT((var), field))
-
-#define	SLIST_FOREACH_SAFE(var, head, field, tvar)			\
-	for ((var) = SLIST_FIRST((head));				\
-	    (var) && ((tvar) = SLIST_NEXT((var), field), 1);		\
-	    (var) = (tvar))
-
-#define	SLIST_FOREACH_PREVPTR(var, varp, head, field)			\
-	for ((varp) = &SLIST_FIRST((head));				\
-	    ((var) = *(varp)) != NULL;					\
-	    (varp) = &SLIST_NEXT((var), field))
-
-#define	SLIST_INIT(head) do {						\
-	SLIST_FIRST((head)) = NULL;					\
-} while (0)
-
-#define	SLIST_INSERT_AFTER(slistelm, elm, field) do {			\
-	SLIST_NEXT((elm), field) = SLIST_NEXT((slistelm), field);	\
-	SLIST_NEXT((slistelm), field) = (elm);				\
-} while (0)
-
-#define	SLIST_INSERT_HEAD(head, elm, field) do {			\
-	SLIST_NEXT((elm), field) = SLIST_FIRST((head));			\
-	SLIST_FIRST((head)) = (elm);					\
-} while (0)
-
-#define	SLIST_NEXT(elm, field)	((elm)->field.sle_next)
-
-#define	SLIST_REMOVE(head, elm, type, field) do {			\
-	QMD_SAVELINK(oldnext, (elm)->field.sle_next);			\
-	if (SLIST_FIRST((head)) == (elm)) {				\
-		SLIST_REMOVE_HEAD((head), field);			\
-	}								\
-	else {								\
-		struct type *curelm = SLIST_FIRST((head));		\
-		while (SLIST_NEXT(curelm, field) != (elm))		\
-			curelm = SLIST_NEXT(curelm, field);		\
-		SLIST_REMOVE_AFTER(curelm, field);			\
-	}								\
-	TRASHIT(*oldnext);						\
-} while (0)
-
-#define SLIST_REMOVE_AFTER(elm, field) do {				\
-	SLIST_NEXT(elm, field) =					\
-	    SLIST_NEXT(SLIST_NEXT(elm, field), field);			\
-} while (0)
-
-#define	SLIST_REMOVE_HEAD(head, field) do {				\
-	SLIST_FIRST((head)) = SLIST_NEXT(SLIST_FIRST((head)), field);	\
-} while (0)
-
-#define SLIST_SWAP(head1, head2, type) do {				\
-	struct type *swap_first = SLIST_FIRST(head1);			\
-	SLIST_FIRST(head1) = SLIST_FIRST(head2);			\
-	SLIST_FIRST(head2) = swap_first;				\
-} while (0)
-
-/*
- * Singly-linked Tail queue declarations.
- */
-#define	STAILQ_HEAD(name, type)						\
-struct name {								\
-	struct type *stqh_first;/* first element */			\
-	struct type **stqh_last;/* addr of last next element */		\
-}
-
-#define	STAILQ_HEAD_INITIALIZER(head)					\
-	{ NULL, &(head).stqh_first }
-
-#define	STAILQ_ENTRY(type)						\
-struct {								\
-	struct type *stqe_next;	/* next element */			\
-}
-
-/*
- * Singly-linked Tail queue functions.
- */
-#define	STAILQ_CONCAT(head1, head2) do {				\
-	if (!STAILQ_EMPTY((head2))) {					\
-		*(head1)->stqh_last = (head2)->stqh_first;		\
-		(head1)->stqh_last = (head2)->stqh_last;		\
-		STAILQ_INIT((head2));					\
-	}								\
-} while (0)
-
-#define	STAILQ_EMPTY(head)	((head)->stqh_first == NULL)
-
-#define	STAILQ_FIRST(head)	((head)->stqh_first)
-
-#define	STAILQ_FOREACH(var, head, field)				\
-	for((var) = STAILQ_FIRST((head));				\
-	   (var);							\
-	   (var) = STAILQ_NEXT((var), field))
-
-
-#define	STAILQ_FOREACH_SAFE(var, head, field, tvar)			\
-	for ((var) = STAILQ_FIRST((head));				\
-	    (var) && ((tvar) = STAILQ_NEXT((var), field), 1);		\
-	    (var) = (tvar))
-
-#define	STAILQ_INIT(head) do {						\
-	STAILQ_FIRST((head)) = NULL;					\
-	(head)->stqh_last = &STAILQ_FIRST((head));			\
-} while (0)
-
-#define	STAILQ_INSERT_AFTER(head, tqelm, elm, field) do {		\
-	if ((STAILQ_NEXT((elm), field) = STAILQ_NEXT((tqelm), field)) == NULL)\
-		(head)->stqh_last = &STAILQ_NEXT((elm), field);		\
-	STAILQ_NEXT((tqelm), field) = (elm);				\
-} while (0)
-
-#define	STAILQ_INSERT_HEAD(head, elm, field) do {			\
-	if ((STAILQ_NEXT((elm), field) = STAILQ_FIRST((head))) == NULL)	\
-		(head)->stqh_last = &STAILQ_NEXT((elm), field);		\
-	STAILQ_FIRST((head)) = (elm);					\
-} while (0)
-
-#define	STAILQ_INSERT_TAIL(head, elm, field) do {			\
-	STAILQ_NEXT((elm), field) = NULL;				\
-	*(head)->stqh_last = (elm);					\
-	(head)->stqh_last = &STAILQ_NEXT((elm), field);			\
-} while (0)
-
-#define	STAILQ_LAST(head, type, field)					\
-	(STAILQ_EMPTY((head)) ?						\
-		NULL :							\
-	        ((struct type *)(void *)				\
-		((char *)((head)->stqh_last) - __offsetof(struct type, field))))
-
-#define	STAILQ_NEXT(elm, field)	((elm)->field.stqe_next)
-
-#define	STAILQ_REMOVE(head, elm, type, field) do {			\
-	QMD_SAVELINK(oldnext, (elm)->field.stqe_next);			\
-	if (STAILQ_FIRST((head)) == (elm)) {				\
-		STAILQ_REMOVE_HEAD((head), field);			\
-	}								\
-	else {								\
-		struct type *curelm = STAILQ_FIRST((head));		\
-		while (STAILQ_NEXT(curelm, field) != (elm))		\
-			curelm = STAILQ_NEXT(curelm, field);		\
-		STAILQ_REMOVE_AFTER(head, curelm, field);		\
-	}								\
-	TRASHIT(*oldnext);						\
-} while (0)
-
-#define STAILQ_REMOVE_AFTER(head, elm, field) do {			\
-	if ((STAILQ_NEXT(elm, field) =					\
-	     STAILQ_NEXT(STAILQ_NEXT(elm, field), field)) == NULL)	\
-		(head)->stqh_last = &STAILQ_NEXT((elm), field);		\
-} while (0)
-
-#define	STAILQ_REMOVE_HEAD(head, field) do {				\
-	if ((STAILQ_FIRST((head)) =					\
-	     STAILQ_NEXT(STAILQ_FIRST((head)), field)) == NULL)		\
-		(head)->stqh_last = &STAILQ_FIRST((head));		\
-} while (0)
-
-#define STAILQ_SWAP(head1, head2, type) do {				\
-	struct type *swap_first = STAILQ_FIRST(head1);			\
-	struct type **swap_last = (head1)->stqh_last;			\
-	STAILQ_FIRST(head1) = STAILQ_FIRST(head2);			\
-	(head1)->stqh_last = (head2)->stqh_last;			\
-	STAILQ_FIRST(head2) = swap_first;				\
-	(head2)->stqh_last = swap_last;					\
-	if (STAILQ_EMPTY(head1))					\
-		(head1)->stqh_last = &STAILQ_FIRST(head1);		\
-	if (STAILQ_EMPTY(head2))					\
-		(head2)->stqh_last = &STAILQ_FIRST(head2);		\
-} while (0)
-
-
-/*
- * List declarations.
- */
-#define	LIST_HEAD(name, type)						\
-struct name {								\
-	struct type *lh_first;	/* first element */			\
-}
-
-#define	LIST_HEAD_INITIALIZER(head)					\
-	{ NULL }
-
-#define	LIST_ENTRY(type)						\
-struct {								\
-	struct type *le_next;	/* next element */			\
-	struct type **le_prev;	/* address of previous next element */	\
-}
-
-/*
- * List functions.
- */
-
-#if (defined(_KERNEL) && defined(INVARIANTS))
-#define	QMD_LIST_CHECK_HEAD(head, field) do {				\
-	if (LIST_FIRST((head)) != NULL &&				\
-	    LIST_FIRST((head))->field.le_prev !=			\
-	     &LIST_FIRST((head)))					\
-		panic("Bad list head %p first->prev != head", (head));	\
-} while (0)
-
-#define	QMD_LIST_CHECK_NEXT(elm, field) do {				\
-	if (LIST_NEXT((elm), field) != NULL &&				\
-	    LIST_NEXT((elm), field)->field.le_prev !=			\
-	     &((elm)->field.le_next))					\
-	     	panic("Bad link elm %p next->prev != elm", (elm));	\
-} while (0)
-
-#define	QMD_LIST_CHECK_PREV(elm, field) do {				\
-	if (*(elm)->field.le_prev != (elm))				\
-		panic("Bad link elm %p prev->next != elm", (elm));	\
-} while (0)
-#else
-#define	QMD_LIST_CHECK_HEAD(head, field)
-#define	QMD_LIST_CHECK_NEXT(elm, field)
-#define	QMD_LIST_CHECK_PREV(elm, field)
-#endif /* (_KERNEL && INVARIANTS) */
-
-#define	LIST_EMPTY(head)	((head)->lh_first == NULL)
-
-#define	LIST_FIRST(head)	((head)->lh_first)
-
-#define	LIST_FOREACH(var, head, field)					\
-	for ((var) = LIST_FIRST((head));				\
-	    (var);							\
-	    (var) = LIST_NEXT((var), field))
-
-#define	LIST_FOREACH_SAFE(var, head, field, tvar)			\
-	for ((var) = LIST_FIRST((head));				\
-	    (var) && ((tvar) = LIST_NEXT((var), field), 1);		\
-	    (var) = (tvar))
-
-#define	LIST_INIT(head) do {						\
-	LIST_FIRST((head)) = NULL;					\
-} while (0)
-
-#define	LIST_INSERT_AFTER(listelm, elm, field) do {			\
-	QMD_LIST_CHECK_NEXT(listelm, field);				\
-	if ((LIST_NEXT((elm), field) = LIST_NEXT((listelm), field)) != NULL)\
-		LIST_NEXT((listelm), field)->field.le_prev =		\
-		    &LIST_NEXT((elm), field);				\
-	LIST_NEXT((listelm), field) = (elm);				\
-	(elm)->field.le_prev = &LIST_NEXT((listelm), field);		\
-} while (0)
-
-#define	LIST_INSERT_BEFORE(listelm, elm, field) do {			\
-	QMD_LIST_CHECK_PREV(listelm, field);				\
-	(elm)->field.le_prev = (listelm)->field.le_prev;		\
-	LIST_NEXT((elm), field) = (listelm);				\
-	*(listelm)->field.le_prev = (elm);				\
-	(listelm)->field.le_prev = &LIST_NEXT((elm), field);		\
-} while (0)
-
-#define	LIST_INSERT_HEAD(head, elm, field) do {				\
-	QMD_LIST_CHECK_HEAD((head), field);				\
-	if ((LIST_NEXT((elm), field) = LIST_FIRST((head))) != NULL)	\
-		LIST_FIRST((head))->field.le_prev = &LIST_NEXT((elm), field);\
-	LIST_FIRST((head)) = (elm);					\
-	(elm)->field.le_prev = &LIST_FIRST((head));			\
-} while (0)
-
-#define	LIST_NEXT(elm, field)	((elm)->field.le_next)
-
-#define	LIST_REMOVE(elm, field) do {					\
-	QMD_SAVELINK(oldnext, (elm)->field.le_next);			\
-	QMD_SAVELINK(oldprev, (elm)->field.le_prev);			\
-	QMD_LIST_CHECK_NEXT(elm, field);				\
-	QMD_LIST_CHECK_PREV(elm, field);				\
-	if (LIST_NEXT((elm), field) != NULL)				\
-		LIST_NEXT((elm), field)->field.le_prev = 		\
-		    (elm)->field.le_prev;				\
-	*(elm)->field.le_prev = LIST_NEXT((elm), field);		\
-	TRASHIT(*oldnext);						\
-	TRASHIT(*oldprev);						\
-} while (0)
-
-#define LIST_SWAP(head1, head2, type, field) do {			\
-	struct type *swap_tmp = LIST_FIRST((head1));			\
-	LIST_FIRST((head1)) = LIST_FIRST((head2));			\
-	LIST_FIRST((head2)) = swap_tmp;					\
-	if ((swap_tmp = LIST_FIRST((head1))) != NULL)			\
-		swap_tmp->field.le_prev = &LIST_FIRST((head1));		\
-	if ((swap_tmp = LIST_FIRST((head2))) != NULL)			\
-		swap_tmp->field.le_prev = &LIST_FIRST((head2));		\
-} while (0)
-
-/*
- * Tail queue declarations.
- */
-#define	TAILQ_HEAD(name, type)						\
-struct name {								\
-	struct type *tqh_first;	/* first element */			\
-	struct type **tqh_last;	/* addr of last next element */		\
-	TRACEBUF							\
-}
-
-#define	TAILQ_HEAD_INITIALIZER(head)					\
-	{ NULL, &(head).tqh_first }
-
-#define	TAILQ_ENTRY(type)						\
-struct {								\
-	struct type *tqe_next;	/* next element */			\
-	struct type **tqe_prev;	/* address of previous next element */	\
-	TRACEBUF							\
-}
-
-/*
- * Tail queue functions.
- */
-#if (defined(_KERNEL) && defined(INVARIANTS))
-#define	QMD_TAILQ_CHECK_HEAD(head, field) do {				\
-	if (!TAILQ_EMPTY(head) &&					\
-	    TAILQ_FIRST((head))->field.tqe_prev !=			\
-	     &TAILQ_FIRST((head)))					\
-		panic("Bad tailq head %p first->prev != head", (head));	\
-} while (0)
-
-#define	QMD_TAILQ_CHECK_TAIL(head, field) do {				\
-	if (*(head)->tqh_last != NULL)					\
-	    	panic("Bad tailq NEXT(%p->tqh_last) != NULL", (head)); 	\
-} while (0)
-
-#define	QMD_TAILQ_CHECK_NEXT(elm, field) do {				\
-	if (TAILQ_NEXT((elm), field) != NULL &&				\
-	    TAILQ_NEXT((elm), field)->field.tqe_prev !=			\
-	     &((elm)->field.tqe_next))					\
-		panic("Bad link elm %p next->prev != elm", (elm));	\
-} while (0)
-
-#define	QMD_TAILQ_CHECK_PREV(elm, field) do {				\
-	if (*(elm)->field.tqe_prev != (elm))				\
-		panic("Bad link elm %p prev->next != elm", (elm));	\
-} while (0)
-#else
-#define	QMD_TAILQ_CHECK_HEAD(head, field)
-#define	QMD_TAILQ_CHECK_TAIL(head, headname)
-#define	QMD_TAILQ_CHECK_NEXT(elm, field)
-#define	QMD_TAILQ_CHECK_PREV(elm, field)
-#endif /* (_KERNEL && INVARIANTS) */
-
-#define	TAILQ_CONCAT(head1, head2, field) do {				\
-	if (!TAILQ_EMPTY(head2)) {					\
-		*(head1)->tqh_last = (head2)->tqh_first;		\
-		(head2)->tqh_first->field.tqe_prev = (head1)->tqh_last;	\
-		(head1)->tqh_last = (head2)->tqh_last;			\
-		TAILQ_INIT((head2));					\
-		QMD_TRACE_HEAD(head1);					\
-		QMD_TRACE_HEAD(head2);					\
-	}								\
-} while (0)
-
-#define	TAILQ_EMPTY(head)	((head)->tqh_first == NULL)
-
-#define	TAILQ_FIRST(head)	((head)->tqh_first)
-
-#define	TAILQ_FOREACH(var, head, field)					\
-	for ((var) = TAILQ_FIRST((head));				\
-	    (var);							\
-	    (var) = TAILQ_NEXT((var), field))
-
-#define	TAILQ_FOREACH_SAFE(var, head, field, tvar)			\
-	for ((var) = TAILQ_FIRST((head));				\
-	    (var) && ((tvar) = TAILQ_NEXT((var), field), 1);		\
-	    (var) = (tvar))
-
-#define	TAILQ_FOREACH_REVERSE(var, head, headname, field)		\
-	for ((var) = TAILQ_LAST((head), headname);			\
-	    (var);							\
-	    (var) = TAILQ_PREV((var), headname, field))
-
-#define	TAILQ_FOREACH_REVERSE_SAFE(var, head, headname, field, tvar)	\
-	for ((var) = TAILQ_LAST((head), headname);			\
-	    (var) && ((tvar) = TAILQ_PREV((var), headname, field), 1);	\
-	    (var) = (tvar))
-
-#define	TAILQ_INIT(head) do {						\
-	TAILQ_FIRST((head)) = NULL;					\
-	(head)->tqh_last = &TAILQ_FIRST((head));			\
-	QMD_TRACE_HEAD(head);						\
-} while (0)
-
-#define	TAILQ_INSERT_AFTER(head, listelm, elm, field) do {		\
-	QMD_TAILQ_CHECK_NEXT(listelm, field);				\
-	if ((TAILQ_NEXT((elm), field) = TAILQ_NEXT((listelm), field)) != NULL)\
-		TAILQ_NEXT((elm), field)->field.tqe_prev = 		\
-		    &TAILQ_NEXT((elm), field);				\
-	else {								\
-		(head)->tqh_last = &TAILQ_NEXT((elm), field);		\
-		QMD_TRACE_HEAD(head);					\
-	}								\
-	TAILQ_NEXT((listelm), field) = (elm);				\
-	(elm)->field.tqe_prev = &TAILQ_NEXT((listelm), field);		\
-	QMD_TRACE_ELEM(&(elm)->field);					\
-	QMD_TRACE_ELEM(&listelm->field);				\
-} while (0)
-
-#define	TAILQ_INSERT_BEFORE(listelm, elm, field) do {			\
-	QMD_TAILQ_CHECK_PREV(listelm, field);				\
-	(elm)->field.tqe_prev = (listelm)->field.tqe_prev;		\
-	TAILQ_NEXT((elm), field) = (listelm);				\
-	*(listelm)->field.tqe_prev = (elm);				\
-	(listelm)->field.tqe_prev = &TAILQ_NEXT((elm), field);		\
-	QMD_TRACE_ELEM(&(elm)->field);					\
-	QMD_TRACE_ELEM(&listelm->field);				\
-} while (0)
-
-#define	TAILQ_INSERT_HEAD(head, elm, field) do {			\
-	QMD_TAILQ_CHECK_HEAD(head, field);				\
-	if ((TAILQ_NEXT((elm), field) = TAILQ_FIRST((head))) != NULL)	\
-		TAILQ_FIRST((head))->field.tqe_prev =			\
-		    &TAILQ_NEXT((elm), field);				\
-	else								\
-		(head)->tqh_last = &TAILQ_NEXT((elm), field);		\
-	TAILQ_FIRST((head)) = (elm);					\
-	(elm)->field.tqe_prev = &TAILQ_FIRST((head));			\
-	QMD_TRACE_HEAD(head);						\
-	QMD_TRACE_ELEM(&(elm)->field);					\
-} while (0)
-
-#define	TAILQ_INSERT_TAIL(head, elm, field) do {			\
-	QMD_TAILQ_CHECK_TAIL(head, field);				\
-	TAILQ_NEXT((elm), field) = NULL;				\
-	(elm)->field.tqe_prev = (head)->tqh_last;			\
-	*(head)->tqh_last = (elm);					\
-	(head)->tqh_last = &TAILQ_NEXT((elm), field);			\
-	QMD_TRACE_HEAD(head);						\
-	QMD_TRACE_ELEM(&(elm)->field);					\
-} while (0)
-
-#define	TAILQ_LAST(head, headname)					\
-	(*(((struct headname *)((head)->tqh_last))->tqh_last))
-
-#define	TAILQ_NEXT(elm, field) ((elm)->field.tqe_next)
-
-#define	TAILQ_PREV(elm, headname, field)				\
-	(*(((struct headname *)((elm)->field.tqe_prev))->tqh_last))
-
-#define	TAILQ_REMOVE(head, elm, field) do {				\
-	QMD_SAVELINK(oldnext, (elm)->field.tqe_next);			\
-	QMD_SAVELINK(oldprev, (elm)->field.tqe_prev);			\
-	QMD_TAILQ_CHECK_NEXT(elm, field);				\
-	QMD_TAILQ_CHECK_PREV(elm, field);				\
-	if ((TAILQ_NEXT((elm), field)) != NULL)				\
-		TAILQ_NEXT((elm), field)->field.tqe_prev = 		\
-		    (elm)->field.tqe_prev;				\
-	else {								\
-		(head)->tqh_last = (elm)->field.tqe_prev;		\
-		QMD_TRACE_HEAD(head);					\
-	}								\
-	*(elm)->field.tqe_prev = TAILQ_NEXT((elm), field);		\
-	TRASHIT(*oldnext);						\
-	TRASHIT(*oldprev);						\
-	QMD_TRACE_ELEM(&(elm)->field);					\
-} while (0)
-
-#define TAILQ_SWAP(head1, head2, type, field) do {			\
-	struct type *swap_first = (head1)->tqh_first;			\
-	struct type **swap_last = (head1)->tqh_last;			\
-	(head1)->tqh_first = (head2)->tqh_first;			\
-	(head1)->tqh_last = (head2)->tqh_last;				\
-	(head2)->tqh_first = swap_first;				\
-	(head2)->tqh_last = swap_last;					\
-	if ((swap_first = (head1)->tqh_first) != NULL)			\
-		swap_first->field.tqe_prev = &(head1)->tqh_first;	\
-	else								\
-		(head1)->tqh_last = &(head1)->tqh_first;		\
-	if ((swap_first = (head2)->tqh_first) != NULL)			\
-		swap_first->field.tqe_prev = &(head2)->tqh_first;	\
-	else								\
-		(head2)->tqh_last = &(head2)->tqh_first;		\
-} while (0)
-
-#endif /* !_SYS_QUEUE_H_ */
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Tue Feb 08 07:06:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 07:06:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267543.461327 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHKaP-0000rm-A1; Tue, 08 Feb 2022 07:06:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267543.461327; Tue, 08 Feb 2022 07:06:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHKaP-0000rG-1T; Tue, 08 Feb 2022 07:06:49 +0000
Received: by outflank-mailman (input) for mailman id 267543;
 Tue, 08 Feb 2022 07:06:47 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=co3W=SX=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nHKaN-0008SU-4h
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 07:06:47 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id aad21d12-88ad-11ec-8eb8-a37418f5ba1a;
 Tue, 08 Feb 2022 08:06:43 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id BB8D821102;
 Tue,  8 Feb 2022 07:06:41 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8570A13483;
 Tue,  8 Feb 2022 07:06:41 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id +Eg7H4EWAmKxHgAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 08 Feb 2022 07:06:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: aad21d12-88ad-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1644304001; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=ioM7WbcIe/sYDvywckVh1bsSGpG8hSYfcSzh25quefQ=;
	b=EvZ1+6ZiUmyfWehVJQpMMJp8UQZRHNNWsmZuFwvk/6X83OMR4ODSnOHFUIObwJ+Bg4Rxm1
	CXnAiYYFfYqBEAhtvs18ofPw+tkURQKbzkGhWiyjcCZrbgp0S56IPNAIiwAMK50q98h+Bu
	ihHuN+N+Mc5Vy6O6lwRe+DSiSPM5cPE=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>
Subject: [PATCH v3 2/5] tools/libs/light: replace _libxl_list.h with _xen_list.h
Date: Tue,  8 Feb 2022 08:06:35 +0100
Message-Id: <20220208070638.5909-3-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220208070638.5909-1-jgross@suse.com>
References: <20220208070638.5909-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Remove generating _libxl_list.h and use the common _xen_list.h instead.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 tools/include/libxl.h                |   4 +-
 tools/libs/light/Makefile            |  10 +--
 tools/libs/light/libxl.c             |  40 ++++-----
 tools/libs/light/libxl_aoutils.c     |  20 ++---
 tools/libs/light/libxl_device.c      |  27 +++---
 tools/libs/light/libxl_disk.c        |   4 +-
 tools/libs/light/libxl_domain.c      |  18 ++--
 tools/libs/light/libxl_event.c       | 128 +++++++++++++--------------
 tools/libs/light/libxl_fork.c        |  44 ++++-----
 tools/libs/light/libxl_internal.h    |  86 +++++++++---------
 tools/libs/light/libxl_qmp.c         |  19 ++--
 tools/libs/light/libxl_stream_read.c |  20 ++---
 12 files changed, 206 insertions(+), 214 deletions(-)

diff --git a/tools/include/libxl.h b/tools/include/libxl.h
index 2bbbd21f0b..51a9b6cfac 100644
--- a/tools/include/libxl.h
+++ b/tools/include/libxl.h
@@ -747,7 +747,7 @@
 typedef struct libxl__ctx libxl_ctx;
 
 #include <libxl_uuid.h>
-#include <_libxl_list.h>
+#include <_xen_list.h>
 
 /* API compatibility. */
 #ifdef LIBXL_API_VERSION
@@ -1448,7 +1448,7 @@ typedef struct {
 } libxl_enum_string_table;
 
 struct libxl_event;
-typedef LIBXL_TAILQ_ENTRY(struct libxl_event) libxl_ev_link;
+typedef XEN_TAILQ_ENTRY(struct libxl_event) libxl_ev_link;
 
 /*
  * A boolean variable with an explicit default state.
diff --git a/tools/libs/light/Makefile b/tools/libs/light/Makefile
index be32d95d39..5642955672 100644
--- a/tools/libs/light/Makefile
+++ b/tools/libs/light/Makefile
@@ -153,14 +153,14 @@ LIBXL_TEST_OBJS += $(foreach t, $(LIBXL_TESTS_INSIDE),libxl_test_$t.opic)
 TEST_PROG_OBJS += $(foreach t, $(LIBXL_TESTS_PROGS),test_$t.o) test_common.o
 TEST_PROGS += $(foreach t, $(LIBXL_TESTS_PROGS),test_$t)
 
-AUTOINCS = $(XEN_INCLUDE)/_libxl_list.h _libxl_save_msgs_callout.h _libxl_save_msgs_helper.h
+AUTOINCS = _libxl_save_msgs_callout.h _libxl_save_msgs_helper.h
 AUTOSRCS = _libxl_save_msgs_callout.c _libxl_save_msgs_helper.c
 
 CLIENTS = testidl libxl-save-helper
 
 SAVE_HELPER_OBJS = libxl_save_helper.o _libxl_save_msgs_helper.o
 
-LIBHEADER := libxl.h libxl_event.h libxl_json.h _libxl_types.h _libxl_types_json.h _libxl_list.h libxl_utils.h libxl_uuid.h
+LIBHEADER := libxl.h libxl_event.h libxl_json.h _libxl_types.h _libxl_types_json.h libxl_utils.h libxl_uuid.h
 
 NO_HEADERS_CHK := y
 
@@ -201,17 +201,13 @@ _libxl.api-for-check: $(XEN_INCLUDE)/libxl.h $(AUTOINCS)
 		>$@.new
 	mv -f $@.new $@
 
-$(XEN_INCLUDE)/_libxl_list.h: $(XEN_INCLUDE)/xen-external/bsd-sys-queue-h-seddery $(XEN_INCLUDE)/xen-external/bsd-sys-queue.h
-	$(PERL) $^ --prefix=libxl >$(notdir $@).new
-	$(call move-if-changed,$(notdir $@).new,$@)
-
 _libxl_save_msgs_helper.c _libxl_save_msgs_callout.c \
 _libxl_save_msgs_helper.h _libxl_save_msgs_callout.h: \
 		libxl_save_msgs_gen.pl
 	$(PERL) -w $< $@ >$@.new
 	$(call move-if-changed,$@.new,$@)
 
-$(XEN_INCLUDE)/libxl.h: $(XEN_INCLUDE)/_libxl_types.h $(XEN_INCLUDE)/_libxl_list.h
+$(XEN_INCLUDE)/libxl.h: $(XEN_INCLUDE)/_libxl_types.h
 $(XEN_INCLUDE)/libxl_json.h: $(XEN_INCLUDE)/_libxl_types_json.h
 libxl_internal.h: _libxl_types_internal.h _libxl_types_private.h _libxl_types_internal_private.h
 libxl_internal_json.h: _libxl_types_internal_json.h
diff --git a/tools/libs/light/libxl.c b/tools/libs/light/libxl.c
index 667ae6409b..a0bf7d186f 100644
--- a/tools/libs/light/libxl.c
+++ b/tools/libs/light/libxl.c
@@ -41,29 +41,29 @@ int libxl_ctx_alloc(libxl_ctx **pctx, int version,
     ctx->nogc_gc.alloc_maxsize = -1;
     ctx->nogc_gc.owner = ctx;
 
-    LIBXL_TAILQ_INIT(&ctx->occurred);
+    XEN_TAILQ_INIT(&ctx->occurred);
 
     ctx->osevent_hooks = 0;
 
     ctx->poller_app = 0;
-    LIBXL_LIST_INIT(&ctx->pollers_event);
-    LIBXL_LIST_INIT(&ctx->pollers_idle);
-    LIBXL_LIST_INIT(&ctx->pollers_active);
+    XEN_LIST_INIT(&ctx->pollers_event);
+    XEN_LIST_INIT(&ctx->pollers_idle);
+    XEN_LIST_INIT(&ctx->pollers_active);
 
-    LIBXL_LIST_INIT(&ctx->efds);
-    LIBXL_TAILQ_INIT(&ctx->etimes);
+    XEN_LIST_INIT(&ctx->efds);
+    XEN_TAILQ_INIT(&ctx->etimes);
 
     ctx->watch_slots = 0;
-    LIBXL_SLIST_INIT(&ctx->watch_freeslots);
+    XEN_SLIST_INIT(&ctx->watch_freeslots);
     libxl__ev_fd_init(&ctx->watch_efd);
 
     ctx->xce = 0;
-    LIBXL_LIST_INIT(&ctx->evtchns_waiting);
+    XEN_LIST_INIT(&ctx->evtchns_waiting);
     libxl__ev_fd_init(&ctx->evtchn_efd);
 
-    LIBXL_LIST_INIT(&ctx->aos_inprogress);
+    XEN_LIST_INIT(&ctx->aos_inprogress);
 
-    LIBXL_TAILQ_INIT(&ctx->death_list);
+    XEN_TAILQ_INIT(&ctx->death_list);
     libxl__ev_xswatch_init(&ctx->death_watch);
 
     ctx->childproc_hooks = &libxl__childproc_default_hooks;
@@ -122,14 +122,14 @@ int libxl_ctx_alloc(libxl_ctx **pctx, int version,
 static void free_disable_deaths(libxl__gc *gc,
                                 struct libxl__evgen_domain_death_list *l) {
     libxl_evgen_domain_death *death;
-    while ((death = LIBXL_TAILQ_FIRST(l)))
+    while ((death = XEN_TAILQ_FIRST(l)))
         libxl__evdisable_domain_death(gc, death);
 }
 
 static void discard_events(struct libxl__event_list *l) {
     /* doesn't bother unlinking from the list, so l is corrupt on return */
     libxl_event *ev, *next;
-    LIBXL_TAILQ_FOREACH_SAFE(ev, l, link, next)
+    XEN_TAILQ_FOREACH_SAFE(ev, l, link, next)
         libxl_event_free(0, ev);
 }
 
@@ -150,7 +150,7 @@ int libxl_ctx_free(libxl_ctx *ctx)
     free_disable_deaths(gc, &CTX->death_reported);
 
     libxl_evgen_disk_eject *eject;
-    while ((eject = LIBXL_LIST_FIRST(&CTX->disk_eject_evgens)))
+    while ((eject = XEN_LIST_FIRST(&CTX->disk_eject_evgens)))
         libxl__evdisable_disk_eject(gc, eject);
 
     libxl_childproc_setmode(CTX,0,0);
@@ -162,10 +162,10 @@ int libxl_ctx_free(libxl_ctx *ctx)
 
     /* Now there should be no more events requested from the application: */
 
-    assert(LIBXL_LIST_EMPTY(&ctx->efds));
-    assert(LIBXL_TAILQ_EMPTY(&ctx->etimes));
-    assert(LIBXL_LIST_EMPTY(&ctx->evtchns_waiting));
-    assert(LIBXL_LIST_EMPTY(&ctx->aos_inprogress));
+    assert(XEN_LIST_EMPTY(&ctx->efds));
+    assert(XEN_TAILQ_EMPTY(&ctx->etimes));
+    assert(XEN_LIST_EMPTY(&ctx->evtchns_waiting));
+    assert(XEN_LIST_EMPTY(&ctx->aos_inprogress));
 
     if (ctx->xch) xc_interface_close(ctx->xch);
     libxl_version_info_dispose(&ctx->version_info);
@@ -174,10 +174,10 @@ int libxl_ctx_free(libxl_ctx *ctx)
 
     libxl__poller_put(ctx, ctx->poller_app);
     ctx->poller_app = NULL;
-    assert(LIBXL_LIST_EMPTY(&ctx->pollers_event));
-    assert(LIBXL_LIST_EMPTY(&ctx->pollers_active));
+    assert(XEN_LIST_EMPTY(&ctx->pollers_event));
+    assert(XEN_LIST_EMPTY(&ctx->pollers_active));
     libxl__poller *poller, *poller_tmp;
-    LIBXL_LIST_FOREACH_SAFE(poller, &ctx->pollers_idle, entry, poller_tmp) {
+    XEN_LIST_FOREACH_SAFE(poller, &ctx->pollers_idle, entry, poller_tmp) {
         libxl__poller_dispose(poller);
         free(poller);
     }
diff --git a/tools/libs/light/libxl_aoutils.c b/tools/libs/light/libxl_aoutils.c
index c4c095a5ba..c2d42e7cac 100644
--- a/tools/libs/light/libxl_aoutils.c
+++ b/tools/libs/light/libxl_aoutils.c
@@ -106,7 +106,7 @@ void libxl__datacopier_init(libxl__datacopier_state *dc)
     libxl__ao_abortable_init(&dc->abrt);
     libxl__ev_fd_init(&dc->toread);
     libxl__ev_fd_init(&dc->towrite);
-    LIBXL_TAILQ_INIT(&dc->bufs);
+    XEN_TAILQ_INIT(&dc->bufs);
 }
 
 void libxl__datacopier_kill(libxl__datacopier_state *dc)
@@ -117,9 +117,9 @@ void libxl__datacopier_kill(libxl__datacopier_state *dc)
     libxl__ao_abortable_deregister(&dc->abrt);
     libxl__ev_fd_deregister(gc, &dc->toread);
     libxl__ev_fd_deregister(gc, &dc->towrite);
-    LIBXL_TAILQ_FOREACH_SAFE(buf, &dc->bufs, entry, tbuf)
+    XEN_TAILQ_FOREACH_SAFE(buf, &dc->bufs, entry, tbuf)
         free(buf);
-    LIBXL_TAILQ_INIT(&dc->bufs);
+    XEN_TAILQ_INIT(&dc->bufs);
 }
 
 static void datacopier_callback(libxl__egc *egc, libxl__datacopier_state *dc,
@@ -182,7 +182,7 @@ void libxl__datacopier_prefixdata(libxl__egc *egc, libxl__datacopier_state *dc,
         memcpy(buf->buf, ptr, buf->used);
 
         dc->used += buf->used;
-        LIBXL_TAILQ_INSERT_TAIL(&dc->bufs, buf, entry);
+        XEN_TAILQ_INSERT_TAIL(&dc->bufs, buf, entry);
     }
 }
 
@@ -235,18 +235,18 @@ static void datacopier_readable(libxl__egc *egc, libxl__ev_fd *ev,
             r = read(ev->fd, dc->readbuf + dc->used, dc->bytes_to_read);
         } else {
             while (dc->used >= dc->maxsz) {
-                libxl__datacopier_buf *rm = LIBXL_TAILQ_FIRST(&dc->bufs);
+                libxl__datacopier_buf *rm = XEN_TAILQ_FIRST(&dc->bufs);
                 dc->used -= rm->used;
                 assert(dc->used >= 0);
-                LIBXL_TAILQ_REMOVE(&dc->bufs, rm, entry);
+                XEN_TAILQ_REMOVE(&dc->bufs, rm, entry);
                 free(rm);
             }
 
-            buf = LIBXL_TAILQ_LAST(&dc->bufs, libxl__datacopier_bufs);
+            buf = XEN_TAILQ_LAST(&dc->bufs, libxl__datacopier_bufs);
             if (!buf || buf->used >= sizeof(buf->buf)) {
                 buf = libxl__malloc(NOGC, sizeof(*buf));
                 buf->used = 0;
-                LIBXL_TAILQ_INSERT_TAIL(&dc->bufs, buf, entry);
+                XEN_TAILQ_INSERT_TAIL(&dc->bufs, buf, entry);
             }
             r = read(ev->fd, buf->buf + buf->used,
                      min_t(size_t, sizeof(buf->buf) - buf->used,
@@ -331,11 +331,11 @@ static void datacopier_writable(libxl__egc *egc, libxl__ev_fd *ev,
     }
     assert(revents & POLLOUT);
     for (;;) {
-        libxl__datacopier_buf *buf = LIBXL_TAILQ_FIRST(&dc->bufs);
+        libxl__datacopier_buf *buf = XEN_TAILQ_FIRST(&dc->bufs);
         if (!buf)
             break;
         if (!buf->used) {
-            LIBXL_TAILQ_REMOVE(&dc->bufs, buf, entry);
+            XEN_TAILQ_REMOVE(&dc->bufs, buf, entry);
             free(buf);
             continue;
         }
diff --git a/tools/libs/light/libxl_device.c b/tools/libs/light/libxl_device.c
index 36c4e41e4d..e6025d135e 100644
--- a/tools/libs/light/libxl_device.c
+++ b/tools/libs/light/libxl_device.c
@@ -1476,7 +1476,7 @@ static void qdisk_spawn_outcome(libxl__egc *egc, libxl__dm_spawn_state *dmss,
  */
 typedef struct libxl__ddomain_device {
     libxl__device *dev;
-    LIBXL_SLIST_ENTRY(struct libxl__ddomain_device) next;
+    XEN_SLIST_ENTRY(struct libxl__ddomain_device) next;
 } libxl__ddomain_device;
 
 /*
@@ -1485,8 +1485,8 @@ typedef struct libxl__ddomain_device {
 typedef struct libxl__ddomain_guest {
     uint32_t domid;
     int num_qdisks;
-    LIBXL_SLIST_HEAD(, struct libxl__ddomain_device) devices;
-    LIBXL_SLIST_ENTRY(struct libxl__ddomain_guest) next;
+    XEN_SLIST_HEAD(, struct libxl__ddomain_device) devices;
+    XEN_SLIST_ENTRY(struct libxl__ddomain_guest) next;
 } libxl__ddomain_guest;
 
 /*
@@ -1496,7 +1496,7 @@ typedef struct libxl__ddomain_guest {
 typedef struct {
     libxl__ao *ao;
     libxl__ev_xswatch watch;
-    LIBXL_SLIST_HEAD(, struct libxl__ddomain_guest) guests;
+    XEN_SLIST_HEAD(, struct libxl__ddomain_guest) guests;
 } libxl__ddomain;
 
 static libxl__ddomain_guest *search_for_guest(libxl__ddomain *ddomain,
@@ -1504,7 +1504,7 @@ static libxl__ddomain_guest *search_for_guest(libxl__ddomain *ddomain,
 {
     libxl__ddomain_guest *dguest;
 
-    LIBXL_SLIST_FOREACH(dguest, &ddomain->guests, next) {
+    XEN_SLIST_FOREACH(dguest, &ddomain->guests, next) {
         if (dguest->domid == domid)
             return dguest;
     }
@@ -1516,7 +1516,7 @@ static libxl__ddomain_device *search_for_device(libxl__ddomain_guest *dguest,
 {
     libxl__ddomain_device *ddev;
 
-    LIBXL_SLIST_FOREACH(ddev, &dguest->devices, next) {
+    XEN_SLIST_FOREACH(ddev, &dguest->devices, next) {
 #define LIBXL_DEVICE_CMP(dev1, dev2, entry) (dev1->entry == dev2->entry)
         if (LIBXL_DEVICE_CMP(ddev->dev, dev, backend_devid) &&
             LIBXL_DEVICE_CMP(ddev->dev, dev, backend_domid) &&
@@ -1537,8 +1537,8 @@ static void check_and_maybe_remove_guest(libxl__gc *gc,
 {
     assert(ddomain);
 
-    if (dguest != NULL && LIBXL_SLIST_FIRST(&dguest->devices) == NULL) {
-        LIBXL_SLIST_REMOVE(&ddomain->guests, dguest, libxl__ddomain_guest,
+    if (dguest != NULL && XEN_SLIST_FIRST(&dguest->devices) == NULL) {
+        XEN_SLIST_REMOVE(&ddomain->guests, dguest, libxl__ddomain_guest,
                            next);
         LOGD(DEBUG, dguest->domid, "Removed domain from the list of active guests");
         /* Clear any leftovers in libxl/<domid> */
@@ -1572,7 +1572,7 @@ static int add_device(libxl__egc *egc, libxl__ao *ao,
     ddev = libxl__zalloc(NOGC, sizeof(*ddev));
     ddev->dev = libxl__zalloc(NOGC, sizeof(*ddev->dev));
     *ddev->dev = *dev;
-    LIBXL_SLIST_INSERT_HEAD(&dguest->devices, ddev, next);
+    XEN_SLIST_INSERT_HEAD(&dguest->devices, ddev, next);
     LOGD(DEBUG, dev->domid, "Added device %s to the list of active devices",
          libxl__device_backend_path(gc, dev));
 
@@ -1649,8 +1649,7 @@ static int remove_device(libxl__egc *egc, libxl__ao *ao,
      * above or from add_device make a copy of the data they use, so
      * there's no risk of dereferencing.
      */
-    LIBXL_SLIST_REMOVE(&dguest->devices, ddev, libxl__ddomain_device,
-                       next);
+    XEN_SLIST_REMOVE(&dguest->devices, ddev, libxl__ddomain_device, next);
     LOGD(DEBUG, dev->domid, "Removed device %s from the list of active devices",
          libxl__device_backend_path(gc, dev));
 
@@ -1716,8 +1715,8 @@ static void backend_watch_callback(libxl__egc *egc, libxl__ev_xswatch *watch,
         /* Create a new guest struct and initialize it */
         dguest = libxl__zalloc(NOGC, sizeof(*dguest));
         dguest->domid = dev->domid;
-        LIBXL_SLIST_INIT(&dguest->devices);
-        LIBXL_SLIST_INSERT_HEAD(&ddomain->guests, dguest, next);
+        XEN_SLIST_INIT(&dguest->devices);
+        XEN_SLIST_INSERT_HEAD(&ddomain->guests, dguest, next);
         LOGD(DEBUG, dguest->domid, "Added domain to the list of active guests");
     }
     ddev = search_for_device(dguest, dev);
@@ -1766,7 +1765,7 @@ int libxl_device_events_handler(libxl_ctx *ctx,
     int i, j, k;
 
     ddomain.ao = ao;
-    LIBXL_SLIST_INIT(&ddomain.guests);
+    XEN_SLIST_INIT(&ddomain.guests);
 
     rc = libxl__get_domid(gc, &domid);
     if (rc) {
diff --git a/tools/libs/light/libxl_disk.c b/tools/libs/light/libxl_disk.c
index 93936d0dd0..a5ca77850f 100644
--- a/tools/libs/light/libxl_disk.c
+++ b/tools/libs/light/libxl_disk.c
@@ -88,7 +88,7 @@ int libxl_evenable_disk_eject(libxl_ctx *ctx, uint32_t guest_domid,
     memset(evg, 0, sizeof(*evg));
     evg->user = user;
     evg->domid = guest_domid;
-    LIBXL_LIST_INSERT_HEAD(&CTX->disk_eject_evgens, evg, entry);
+    XEN_LIST_INSERT_HEAD(&CTX->disk_eject_evgens, evg, entry);
 
     uint32_t domid = libxl_get_stubdom_id(ctx, guest_domid);
 
@@ -133,7 +133,7 @@ int libxl_evenable_disk_eject(libxl_ctx *ctx, uint32_t guest_domid,
 void libxl__evdisable_disk_eject(libxl__gc *gc, libxl_evgen_disk_eject *evg) {
     CTX_LOCK;
 
-    LIBXL_LIST_REMOVE(evg, entry);
+    XEN_LIST_REMOVE(evg, entry);
 
     if (libxl__ev_xswatch_isregistered(&evg->watch))
         libxl__ev_xswatch_deregister(gc, &evg->watch);
diff --git a/tools/libs/light/libxl_domain.c b/tools/libs/light/libxl_domain.c
index 544a9bf59d..d544a60777 100644
--- a/tools/libs/light/libxl_domain.c
+++ b/tools/libs/light/libxl_domain.c
@@ -867,7 +867,7 @@ static void domain_death_occurred(libxl__egc *egc,
 
     LOGD(DEBUG, evg->domid, "%s", why);
 
-    libxl_evgen_domain_death *evg_next = LIBXL_TAILQ_NEXT(evg, entry);
+    libxl_evgen_domain_death *evg_next = XEN_TAILQ_NEXT(evg, entry);
     *evg_upd = evg_next;
 
     libxl_event *ev = NEW_EVENT(egc, DOMAIN_DEATH, evg->domid, evg->user);
@@ -875,8 +875,8 @@ static void domain_death_occurred(libxl__egc *egc,
     libxl__event_occurred(egc, ev);
 
     evg->death_reported = 1;
-    LIBXL_TAILQ_REMOVE(&CTX->death_list, evg, entry);
-    LIBXL_TAILQ_INSERT_HEAD(&CTX->death_reported, evg, entry);
+    XEN_TAILQ_REMOVE(&CTX->death_list, evg, entry);
+    XEN_TAILQ_INSERT_HEAD(&CTX->death_reported, evg, entry);
 }
 
 static void domain_death_xswatch_callback(libxl__egc *egc, libxl__ev_xswatch *w,
@@ -887,12 +887,12 @@ static void domain_death_xswatch_callback(libxl__egc *egc, libxl__ev_xswatch *w,
 
     CTX_LOCK;
 
-    evg = LIBXL_TAILQ_FIRST(&CTX->death_list);
+    evg = XEN_TAILQ_FIRST(&CTX->death_list);
 
     for (;;) {
         if (!evg) goto out;
 
-        int nentries = LIBXL_TAILQ_NEXT(evg, entry) ? 200 : 1;
+        int nentries = XEN_TAILQ_NEXT(evg, entry) ? 200 : 1;
         xc_domaininfo_t domaininfos[nentries];
         const xc_domaininfo_t *got = domaininfos, *gotend;
 
@@ -966,7 +966,7 @@ static void domain_death_xswatch_callback(libxl__egc *egc, libxl__ev_xswatch *w,
 
                 evg->shutdown_reported = 1;
             }
-            evg = LIBXL_TAILQ_NEXT(evg, entry);
+            evg = XEN_TAILQ_NEXT(evg, entry);
         }
 
         assert(rc); /* rc==0 results in us eating all evgs and quitting */
@@ -1015,13 +1015,13 @@ void libxl__evdisable_domain_death(libxl__gc *gc,
     CTX_LOCK;
 
     if (!evg->death_reported)
-        LIBXL_TAILQ_REMOVE(&CTX->death_list, evg, entry);
+        XEN_TAILQ_REMOVE(&CTX->death_list, evg, entry);
     else
-        LIBXL_TAILQ_REMOVE(&CTX->death_reported, evg, entry);
+        XEN_TAILQ_REMOVE(&CTX->death_reported, evg, entry);
 
     free(evg);
 
-    if (!LIBXL_TAILQ_FIRST(&CTX->death_list) &&
+    if (!XEN_TAILQ_FIRST(&CTX->death_list) &&
         libxl__ev_xswatch_isregistered(&CTX->death_watch))
         libxl__ev_xswatch_deregister(gc, &CTX->death_watch);
 
diff --git a/tools/libs/light/libxl_event.c b/tools/libs/light/libxl_event.c
index 7c5387e94f..c8bcd13960 100644
--- a/tools/libs/light/libxl_event.c
+++ b/tools/libs/light/libxl_event.c
@@ -165,7 +165,7 @@ static void ao__check_destroy(libxl_ctx *ctx, libxl__ao *ao);
  */
 static void pollers_note_osevent_added(libxl_ctx *ctx) {
     libxl__poller *poller;
-    LIBXL_LIST_FOREACH(poller, &ctx->pollers_active, active_entry)
+    XEN_LIST_FOREACH(poller, &ctx->pollers_active, active_entry)
         poller->osevents_added = 1;
 }
 
@@ -189,7 +189,7 @@ void libxl__egc_ao_cleanup_1_baton(libxl__gc *gc)
     if (CTX->poller_app->osevents_added)
         baton_wake(gc, CTX->poller_app);
 
-    LIBXL_LIST_FOREACH(search, &CTX->pollers_active, active_entry) {
+    XEN_LIST_FOREACH(search, &CTX->pollers_active, active_entry) {
         if (search == CTX->poller_app)
             /* This one is special.  We can't give it the baton. */
             continue;
@@ -279,7 +279,7 @@ void libxl__egc_ao_cleanup_1_baton(libxl__gc *gc)
 struct libxl__osevent_hook_nexus {
     void *ev;
     void *for_app_reg;
-    LIBXL_SLIST_ENTRY(libxl__osevent_hook_nexus) next;
+    XEN_SLIST_ENTRY(libxl__osevent_hook_nexus) next;
 };
 
 static void *osevent_ev_from_hook_nexus(libxl_ctx *ctx,
@@ -293,7 +293,7 @@ static void osevent_release_nexus(libxl__gc *gc,
                                   libxl__osevent_hook_nexus *nexus)
 {
     nexus->ev = 0;
-    LIBXL_SLIST_INSERT_HEAD(nexi_idle, nexus, next);
+    XEN_SLIST_INSERT_HEAD(nexi_idle, nexus, next);
 }
 
 /*----- OSEVENT* hook functions for nexusop "alloc" -----*/
@@ -301,9 +301,9 @@ static void osevent_hook_pre_alloc(libxl__gc *gc, void *ev,
                                    libxl__osevent_hook_nexi *nexi_idle,
                                    libxl__osevent_hook_nexus **nexus_r)
 {
-    libxl__osevent_hook_nexus *nexus = LIBXL_SLIST_FIRST(nexi_idle);
+    libxl__osevent_hook_nexus *nexus = XEN_SLIST_FIRST(nexi_idle);
     if (nexus) {
-        LIBXL_SLIST_REMOVE_HEAD(nexi_idle, next);
+        XEN_SLIST_REMOVE_HEAD(nexi_idle, next);
     } else {
         nexus = libxl__zalloc(NOGC, sizeof(*nexus));
     }
@@ -364,7 +364,7 @@ int libxl__ev_fd_register(libxl__gc *gc, libxl__ev_fd *ev,
     ev->events = events;
     ev->func = func;
 
-    LIBXL_LIST_INSERT_HEAD(&CTX->efds, ev, entry);
+    XEN_LIST_INSERT_HEAD(&CTX->efds, ev, entry);
     pollers_note_osevent_added(CTX);
 
     rc = 0;
@@ -409,10 +409,10 @@ void libxl__ev_fd_deregister(libxl__gc *gc, libxl__ev_fd *ev)
     DBG("ev_fd=%p deregister fd=%d", ev, ev->fd);
 
     OSEVENT_HOOK_VOID(fd,deregister, release, ev->fd, ev->nexus->for_app_reg);
-    LIBXL_LIST_REMOVE(ev, entry);
+    XEN_LIST_REMOVE(ev, entry);
     ev->fd = -1;
 
-    LIBXL_LIST_FOREACH(poller, &CTX->pollers_active, active_entry)
+    XEN_LIST_FOREACH(poller, &CTX->pollers_active, active_entry)
         poller->fds_deregistered = 1;
 
  out:
@@ -504,7 +504,7 @@ static void time_deregister(libxl__gc *gc, libxl__ev_time *ev)
         OSEVENT_HOOK_VOID(timeout,modify,
                           noop /* release nexus in _occurred_ */,
                           &ev->nexus->for_app_reg, right_away);
-        LIBXL_TAILQ_REMOVE(&CTX->etimes, ev, entry);
+        XEN_TAILQ_REMOVE(&CTX->etimes, ev, entry);
     }
 }
 
@@ -640,7 +640,7 @@ static void time_occurs(libxl__egc *egc, libxl__ev_time *etime, int rc)
 libxl__ev_xswatch *libxl__watch_slot_contents(libxl__gc *gc, int slotnum)
 {
     libxl__ev_watch_slot *slot = &CTX->watch_slots[slotnum];
-    libxl__ev_watch_slot *slotcontents = LIBXL_SLIST_NEXT(slot, empty);
+    libxl__ev_watch_slot *slotcontents = XEN_SLIST_NEXT(slot, empty);
 
     if (slotcontents == NULL ||
         ((uintptr_t)slotcontents >= (uintptr_t)CTX->watch_slots &&
@@ -672,7 +672,7 @@ libxl__ev_xswatch *libxl__watch_slot_contents(libxl__gc *gc, int slotnum)
 static void libxl__set_watch_slot_contents(libxl__ev_watch_slot *slot,
                                            libxl__ev_xswatch *w)
 {
-    /* we look a bit behind the curtain of LIBXL_SLIST, to explicitly
+    /* we look a bit behind the curtain of XEN_SLIST, to explicitly
      * assign to the pointer that's the next link.  See the comment
      * by the definition of libxl__ev_watch_slot */
     slot->empty.sle_next = (void*)w;
@@ -784,7 +784,7 @@ int libxl__ev_xswatch_register(libxl__gc *gc, libxl__ev_xswatch *w,
         if (rc) goto out_rc;
     }
 
-    if (LIBXL_SLIST_EMPTY(&CTX->watch_freeslots)) {
+    if (XEN_SLIST_EMPTY(&CTX->watch_freeslots)) {
         /* Free list is empty so there is not in fact a linked
          * free list in the array and we can safely realloc it */
         int newarraysize = (CTX->watch_nslots + 1) << 2;
@@ -794,14 +794,13 @@ int libxl__ev_xswatch_register(libxl__gc *gc, libxl__ev_xswatch *w,
                            CTX->watch_slots, sizeof(*newarray) * newarraysize);
         if (!newarray) goto out_nomem;
         for (i = CTX->watch_nslots; i < newarraysize; i++)
-            LIBXL_SLIST_INSERT_HEAD(&CTX->watch_freeslots,
-                                    &newarray[i], empty);
+            XEN_SLIST_INSERT_HEAD(&CTX->watch_freeslots, &newarray[i], empty);
         CTX->watch_slots = newarray;
         CTX->watch_nslots = newarraysize;
     }
-    use = LIBXL_SLIST_FIRST(&CTX->watch_freeslots);
+    use = XEN_SLIST_FIRST(&CTX->watch_freeslots);
     assert(use);
-    LIBXL_SLIST_REMOVE_HEAD(&CTX->watch_freeslots, empty);
+    XEN_SLIST_REMOVE_HEAD(&CTX->watch_freeslots, empty);
 
     path_copy = strdup(path);
     if (!path_copy) goto out_nomem;
@@ -832,7 +831,7 @@ int libxl__ev_xswatch_register(libxl__gc *gc, libxl__ev_xswatch *w,
     rc = ERROR_NOMEM;
  out_rc:
     if (use)
-        LIBXL_SLIST_INSERT_HEAD(&CTX->watch_freeslots, use, empty);
+        XEN_SLIST_INSERT_HEAD(&CTX->watch_freeslots, use, empty);
     free(path_copy);
     watches_check_fd_deregister(gc);
     CTX_UNLOCK;
@@ -856,7 +855,7 @@ void libxl__ev_xswatch_deregister(libxl__gc *gc, libxl__ev_xswatch *w)
             LOGEV(ERROR, errno, "remove watch for path %s", w->path);
 
         libxl__ev_watch_slot *slot = &CTX->watch_slots[w->slotnum];
-        LIBXL_SLIST_INSERT_HEAD(&CTX->watch_freeslots, slot, empty);
+        XEN_SLIST_INSERT_HEAD(&CTX->watch_freeslots, slot, empty);
         w->slotnum = -1;
         CTX->nwatches--;
         watches_check_fd_deregister(gc);
@@ -927,7 +926,7 @@ static void evtchn_fd_callback(libxl__egc *egc, libxl__ev_fd *ev,
             return;
         }
 
-        LIBXL_LIST_FOREACH(evev, &CTX->evtchns_waiting, entry)
+        XEN_LIST_FOREACH(evev, &CTX->evtchns_waiting, entry)
             if (port == evev->port)
                 goto found;
         /* not found */
@@ -937,7 +936,7 @@ static void evtchn_fd_callback(libxl__egc *egc, libxl__ev_fd *ev,
     found:
         DBG("ev_evtchn=%p port=%d signaled", evev, port);
         evev->waiting = 0;
-        LIBXL_LIST_REMOVE(evev, entry);
+        XEN_LIST_REMOVE(evev, entry);
         evev->callback(egc, evev);
     }
 }
@@ -972,7 +971,7 @@ int libxl__ctx_evtchn_init(libxl__gc *gc) {
 
 static void evtchn_check_fd_deregister(libxl__gc *gc)
 {
-    if (CTX->xce && LIBXL_LIST_EMPTY(&CTX->evtchns_waiting))
+    if (CTX->xce && XEN_LIST_EMPTY(&CTX->evtchns_waiting))
         libxl__ev_fd_deregister(gc, &CTX->evtchn_efd);
 }
 
@@ -1003,7 +1002,7 @@ int libxl__ev_evtchn_wait(libxl__gc *gc, libxl__ev_evtchn *evev)
     }
 
     evev->waiting = 1;
-    LIBXL_LIST_INSERT_HEAD(&CTX->evtchns_waiting, evev, entry);
+    XEN_LIST_INSERT_HEAD(&CTX->evtchns_waiting, evev, entry);
     return 0;
 
  out:
@@ -1020,7 +1019,7 @@ void libxl__ev_evtchn_cancel(libxl__gc *gc, libxl__ev_evtchn *evev)
         return;
 
     evev->waiting = 0;
-    LIBXL_LIST_REMOVE(evev, entry);
+    XEN_LIST_REMOVE(evev, entry);
     evtchn_check_fd_deregister(gc);
 }
 
@@ -1095,7 +1094,7 @@ int libxl__ev_devstate_wait(libxl__ao *ao, libxl__ev_devstate *ds,
 
 void libxl__ev_immediate_register(libxl__egc *egc, libxl__ev_immediate *ei)
 {
-    LIBXL_STAILQ_INSERT_TAIL(&egc->ev_immediates, ei, entry);
+    XEN_STAILQ_INSERT_TAIL(&egc->ev_immediates, ei, entry);
 }
 
 /*
@@ -1221,7 +1220,7 @@ static int beforepoll_internal(libxl__gc *gc, libxl__poller *poller,
 
 #define REQUIRE_FDS(BODY) do{                                          \
                                                                        \
-        LIBXL_LIST_FOREACH(efd, &CTX->efds, entry)                     \
+        XEN_LIST_FOREACH(efd, &CTX->efds, entry)                       \
             REQUIRE_FD(efd->fd, efd->events, BODY);                    \
                                                                        \
         REQUIRE_FD(poller->wakeup_pipe[0], POLLIN, BODY);              \
@@ -1298,7 +1297,7 @@ static int beforepoll_internal(libxl__gc *gc, libxl__poller *poller,
     poller->fds_deregistered = 0;
     poller->osevents_added = 0;
 
-    libxl__ev_time *etime = LIBXL_TAILQ_FIRST(&CTX->etimes);
+    libxl__ev_time *etime = XEN_TAILQ_FIRST(&CTX->etimes);
     if (etime) {
         int our_timeout;
         struct timeval rel;
@@ -1436,7 +1435,7 @@ static void afterpoll_internal(libxl__egc *egc, libxl__poller *poller,
          * so that we don't call the same function again. */
         int revents;
 
-        LIBXL_LIST_FOREACH(efd, &CTX->efds, entry) {
+        XEN_LIST_FOREACH(efd, &CTX->efds, entry) {
 
             if (!efd->events)
                 continue;
@@ -1454,7 +1453,7 @@ static void afterpoll_internal(libxl__egc *egc, libxl__poller *poller,
     }
 
     for (;;) {
-        libxl__ev_time *etime = LIBXL_TAILQ_FIRST(&CTX->etimes);
+        libxl__ev_time *etime = XEN_TAILQ_FIRST(&CTX->etimes);
         if (!etime)
             break;
 
@@ -1494,8 +1493,8 @@ void libxl_osevent_register_hooks(libxl_ctx *ctx,
 {
     GC_INIT(ctx);
     CTX_LOCK;
-    assert(LIBXL_LIST_EMPTY(&ctx->efds));
-    assert(LIBXL_TAILQ_EMPTY(&ctx->etimes));
+    assert(XEN_LIST_EMPTY(&ctx->efds));
+    assert(XEN_TAILQ_EMPTY(&ctx->etimes));
     ctx->osevent_hooks = hooks;
     ctx->osevent_user = user;
     CTX_UNLOCK;
@@ -1534,7 +1533,7 @@ void libxl_osevent_occurred_timeout(libxl_ctx *ctx, void *for_libxl)
     if (!ev) goto out;
     assert(!ev->infinite);
 
-    LIBXL_TAILQ_REMOVE(&CTX->etimes, ev, entry);
+    XEN_TAILQ_REMOVE(&CTX->etimes, ev, entry);
 
     time_occurs(egc, ev, ERROR_TIMEDOUT);
 
@@ -1577,9 +1576,9 @@ static void egc_run_callbacks(libxl__egc *egc)
     libxl__aop_occurred *aop, *aop_tmp;
     libxl__ev_immediate *ei;
 
-    while (!LIBXL_STAILQ_EMPTY(&egc->ev_immediates)) {
-        ei = LIBXL_STAILQ_FIRST(&egc->ev_immediates);
-        LIBXL_STAILQ_REMOVE_HEAD(&egc->ev_immediates, entry);
+    while (!XEN_STAILQ_EMPTY(&egc->ev_immediates)) {
+        ei = XEN_STAILQ_FIRST(&egc->ev_immediates);
+        XEN_STAILQ_REMOVE_HEAD(&egc->ev_immediates, entry);
         CTX_LOCK;
         /* This callback is internal to libxl and expects CTX to be
          * locked. */
@@ -1587,15 +1586,15 @@ static void egc_run_callbacks(libxl__egc *egc)
         CTX_UNLOCK;
     }
 
-    LIBXL_TAILQ_FOREACH_SAFE(ev, &egc->occurred_for_callback, link, ev_tmp) {
-        LIBXL_TAILQ_REMOVE(&egc->occurred_for_callback, ev, link);
+    XEN_TAILQ_FOREACH_SAFE(ev, &egc->occurred_for_callback, link, ev_tmp) {
+        XEN_TAILQ_REMOVE(&egc->occurred_for_callback, ev, link);
         LOG(DEBUG,"event %p callback type=%s",
             ev, libxl_event_type_to_string(ev->type));
         CTX->event_hooks->event_occurs(CTX->event_hooks_user, ev);
     }
 
-    LIBXL_TAILQ_FOREACH_SAFE(aop, &egc->aops_for_callback, entry, aop_tmp) {
-        LIBXL_TAILQ_REMOVE(&egc->aops_for_callback, aop, entry);
+    XEN_TAILQ_FOREACH_SAFE(aop, &egc->aops_for_callback, entry, aop_tmp) {
+        XEN_TAILQ_REMOVE(&egc->aops_for_callback, aop, entry);
         LOG(DEBUG,"ao %p: progress report: callback aop=%p", aop->ao, aop);
         aop->how->callback(CTX, aop->ev, aop->how->for_callback);
 
@@ -1607,9 +1606,9 @@ static void egc_run_callbacks(libxl__egc *egc)
     }
 
     libxl__ao *ao, *ao_tmp;
-    LIBXL_TAILQ_FOREACH_SAFE(ao, &egc->aos_for_callback,
-                             entry_for_callback, ao_tmp) {
-        LIBXL_TAILQ_REMOVE(&egc->aos_for_callback, ao, entry_for_callback);
+    XEN_TAILQ_FOREACH_SAFE(ao, &egc->aos_for_callback,
+                           entry_for_callback, ao_tmp) {
+        XEN_TAILQ_REMOVE(&egc->aos_for_callback, ao, entry_for_callback);
         LOG(DEBUG,"ao %p: completion callback", ao);
         ao->how.callback(CTX, ao->rc, ao->how.u.for_callback);
         CTX_LOCK;
@@ -1648,12 +1647,12 @@ void libxl__event_occurred(libxl__egc *egc, libxl_event *event)
          * from libxl.  This helps avoid reentrancy bugs: parts of
          * libxl that call libxl__event_occurred do not have to worry
          * that libxl might be reentered at that point. */
-        LIBXL_TAILQ_INSERT_TAIL(&egc->occurred_for_callback, event, link);
+        XEN_TAILQ_INSERT_TAIL(&egc->occurred_for_callback, event, link);
         return;
     } else {
         libxl__poller *poller;
-        LIBXL_TAILQ_INSERT_TAIL(&CTX->occurred, event, link);
-        LIBXL_LIST_FOREACH(poller, &CTX->pollers_event, entry)
+        XEN_TAILQ_INSERT_TAIL(&CTX->occurred, event, link);
+        XEN_LIST_FOREACH(poller, &CTX->pollers_event, entry)
             libxl__poller_wakeup(gc, poller);
     }
 }
@@ -1691,7 +1690,7 @@ static int event_check_internal(libxl__egc *egc, libxl_event **event_r,
     libxl_event *ev;
     int rc;
 
-    LIBXL_TAILQ_FOREACH(ev, &CTX->occurred, link) {
+    XEN_TAILQ_FOREACH(ev, &CTX->occurred, link) {
         if (!(typemask & ((uint64_t)1 << ev->type)))
             continue;
 
@@ -1699,7 +1698,7 @@ static int event_check_internal(libxl__egc *egc, libxl_event **event_r,
             continue;
 
         /* got one! */
-        LIBXL_TAILQ_REMOVE(&CTX->occurred, ev, link);
+        XEN_TAILQ_REMOVE(&CTX->occurred, ev, link);
         *event_r = ev;
         rc = 0;
         goto out;
@@ -1820,9 +1819,9 @@ libxl__poller *libxl__poller_get(libxl__gc *gc)
     /* must be called with ctx locked */
     int rc;
 
-    libxl__poller *p = LIBXL_LIST_FIRST(&CTX->pollers_idle);
+    libxl__poller *p = XEN_LIST_FIRST(&CTX->pollers_idle);
     if (p) {
-        LIBXL_LIST_REMOVE(p, entry);
+        XEN_LIST_REMOVE(p, entry);
     } else {
         p = libxl__zalloc(NOGC, sizeof(*p));
 
@@ -1833,16 +1832,15 @@ libxl__poller *libxl__poller_get(libxl__gc *gc)
         }
     }
 
-    LIBXL_LIST_INSERT_HEAD(&CTX->pollers_active, p,
-                           active_entry);
+    XEN_LIST_INSERT_HEAD(&CTX->pollers_active, p, active_entry);
     return p;
 }
 
 void libxl__poller_put(libxl_ctx *ctx, libxl__poller *p)
 {
     if (!p) return;
-    LIBXL_LIST_REMOVE(p, active_entry);
-    LIBXL_LIST_INSERT_HEAD(&ctx->pollers_idle, p, entry);
+    XEN_LIST_REMOVE(p, active_entry);
+    XEN_LIST_INSERT_HEAD(&ctx->pollers_idle, p, entry);
 }
 
 void libxl__poller_wakeup(libxl__gc *gc, libxl__poller *p)
@@ -2048,7 +2046,7 @@ void libxl__ao_create_fail(libxl__ao *ao)
     assert(!ao->complete);
     assert(!ao->progress_reports_outstanding);
     assert(!ao->aborting);
-    LIBXL_LIST_REMOVE(ao, inprogress_entry);
+    XEN_LIST_REMOVE(ao, inprogress_entry);
     libxl__ao__destroy(CTX, ao);
 }
 
@@ -2070,7 +2068,7 @@ void libxl__ao_complete(libxl__egc *egc, libxl__ao *ao, int rc)
     assert(!ao->nested_progeny);
     ao->complete = 1;
     ao->rc = rc;
-    LIBXL_LIST_REMOVE(ao, inprogress_entry);
+    XEN_LIST_REMOVE(ao, inprogress_entry);
     if (ao->outstanding_killed_child)
         LOG(DEBUG, "ao %p: .. but waiting for %d fork to exit",
             ao, ao->outstanding_killed_child);
@@ -2107,7 +2105,7 @@ void libxl__ao_complete_check_progress_reports(libxl__egc *egc, libxl__ao *ao)
             libxl__poller_wakeup(gc, ao->poller);
     } else if (ao->how.callback) {
         LOG(DEBUG, "ao %p: complete for callback", ao);
-        LIBXL_TAILQ_INSERT_TAIL(&egc->aos_for_callback, ao, entry_for_callback);
+        XEN_TAILQ_INSERT_TAIL(&egc->aos_for_callback, ao, entry_for_callback);
     } else {
         libxl_event *ev;
         ev = NEW_EVENT(egc, OPERATION_COMPLETE, ao->domid, ao->how.u.for_event);
@@ -2148,7 +2146,7 @@ libxl__ao *libxl__ao_create(libxl_ctx *ctx, uint32_t domid,
                "ao %p: create: how=%p callback=%p poller=%p",
                ao, how, ao->how.callback, ao->poller);
 
-    LIBXL_LIST_INSERT_HEAD(&ctx->aos_inprogress, ao, inprogress_entry);
+    XEN_LIST_INSERT_HEAD(&ctx->aos_inprogress, ao, inprogress_entry);
 
     return ao;
 
@@ -2255,7 +2253,7 @@ static int ao__abort(libxl_ctx *ctx, libxl__ao *parent)
 
     parent->aborting = 1;
 
-    if (LIBXL_LIST_EMPTY(&parent->abortables)) {
+    if (XEN_LIST_EMPTY(&parent->abortables)) {
         LIBXL__LOG(ctx, LIBXL__LOG_DEBUG,
                    "ao %p: abort requested and noted, but no-one interested",
                    parent);
@@ -2264,13 +2262,13 @@ static int ao__abort(libxl_ctx *ctx, libxl__ao *parent)
     }
 
     /* We keep calling abort hooks until there are none left */
-    while (!LIBXL_LIST_EMPTY(&parent->abortables)) {
+    while (!XEN_LIST_EMPTY(&parent->abortables)) {
         assert(!parent->complete);
 
-        libxl__ao_abortable *abrt = LIBXL_LIST_FIRST(&parent->abortables);
+        libxl__ao_abortable *abrt = XEN_LIST_FIRST(&parent->abortables);
         assert(parent == ao_nested_root(abrt->ao));
 
-        LIBXL_LIST_REMOVE(abrt, entry);
+        XEN_LIST_REMOVE(abrt, entry);
         abrt->registered = 0;
 
         LIBXL__LOG(ctx, LIBXL__LOG_DEBUG,
@@ -2300,7 +2298,7 @@ int libxl_ao_abort(libxl_ctx *ctx, const libxl_asyncop_how *how)
     libxl__ctx_lock(ctx);
     int rc;
 
-    LIBXL_LIST_FOREACH(search, &ctx->aos_inprogress, inprogress_entry) {
+    XEN_LIST_FOREACH(search, &ctx->aos_inprogress, inprogress_entry) {
         if (how) {
             /* looking for ao to be reported by callback or event */
             if (search->poller)
@@ -2356,7 +2354,7 @@ int libxl__ao_abortable_register(libxl__ao_abortable *abrt)
     }
 
     DBG("ao=%p, abrt=%p: registering (root=%p)", ao, abrt, root);
-    LIBXL_LIST_INSERT_HEAD(&root->abortables, abrt, entry);
+    XEN_LIST_INSERT_HEAD(&root->abortables, abrt, entry);
     abrt->registered = 1;
 
     return 0;
@@ -2372,7 +2370,7 @@ _hidden void libxl__ao_abortable_deregister(libxl__ao_abortable *abrt)
     AO_GC;
 
     DBG("ao=%p, abrt=%p: deregistering (root=%p)", ao, abrt, root);
-    LIBXL_LIST_REMOVE(abrt, entry);
+    XEN_LIST_REMOVE(abrt, entry);
     abrt->registered = 0;
 }
 
@@ -2408,7 +2406,7 @@ void libxl__ao_progress_report(libxl__egc *egc, libxl__ao *ao,
         aop->ao = ao;
         aop->ev = ev;
         aop->how = how;
-        LIBXL_TAILQ_INSERT_TAIL(&egc->aops_for_callback, aop, entry);
+        XEN_TAILQ_INSERT_TAIL(&egc->aops_for_callback, aop, entry);
         LOG(DEBUG,"ao %p: progress report: callback queued aop=%p",ao,aop);
     } else {
         LOG(DEBUG,"ao %p: progress report: event queued ev=%p type=%s",
diff --git a/tools/libs/light/libxl_fork.c b/tools/libs/light/libxl_fork.c
index 5d47dceb8a..676a14bb28 100644
--- a/tools/libs/light/libxl_fork.c
+++ b/tools/libs/light/libxl_fork.c
@@ -37,14 +37,14 @@
  */
 
 struct libxl__carefd {
-    LIBXL_LIST_ENTRY(libxl__carefd) entry;
+    XEN_LIST_ENTRY(libxl__carefd) entry;
     int fd;
 };
 
 static pthread_mutex_t no_forking = PTHREAD_MUTEX_INITIALIZER;
 static int atfork_registered;
-static LIBXL_LIST_HEAD(, libxl__carefd) carefds =
-    LIBXL_LIST_HEAD_INITIALIZER(carefds);
+static XEN_LIST_HEAD(, libxl__carefd) carefds =
+    XEN_LIST_HEAD_INITIALIZER(carefds);
 
 /* Protected against concurrency by no_forking.  sigchld_users is
  * protected against being interrupted by SIGCHLD (and thus read
@@ -52,8 +52,8 @@ static LIBXL_LIST_HEAD(, libxl__carefd) carefds =
  * below). */
 static bool sigchld_installed; /* 0 means not */
 static pthread_mutex_t sigchld_defer_mutex = PTHREAD_MUTEX_INITIALIZER;
-static LIBXL_LIST_HEAD(, libxl_ctx) sigchld_users =
-    LIBXL_LIST_HEAD_INITIALIZER(sigchld_users);
+static XEN_LIST_HEAD(, libxl_ctx) sigchld_users =
+    XEN_LIST_HEAD_INITIALIZER(sigchld_users);
 static struct sigaction sigchld_saved_action;
 
 static void sigchld_removehandler_core(void); /* idempotent */
@@ -105,7 +105,7 @@ libxl__carefd *libxl__carefd_record(libxl_ctx *ctx, int fd)
     libxl_fd_set_cloexec(ctx, fd, 1);
     cf = libxl__zalloc(&ctx->nogc_gc, sizeof(*cf));
     cf->fd = fd;
-    LIBXL_LIST_INSERT_HEAD(&carefds, cf, entry);
+    XEN_LIST_INSERT_HEAD(&carefds, cf, entry);
     return cf;
 }
 
@@ -141,7 +141,7 @@ void libxl_postfork_child_noexec(libxl_ctx *ctx)
 
     atfork_lock();
 
-    LIBXL_LIST_FOREACH_SAFE(cf, &carefds, entry, cf_tmp) {
+    XEN_LIST_FOREACH_SAFE(cf, &carefds, entry, cf_tmp) {
         if (cf->fd >= 0) {
             r = close(cf->fd);
             if (r)
@@ -151,7 +151,7 @@ void libxl_postfork_child_noexec(libxl_ctx *ctx)
         }
         free(cf);
     }
-    LIBXL_LIST_INIT(&carefds);
+    XEN_LIST_INIT(&carefds);
 
     if (sigchld_installed) {
         /* We are in theory not at risk of concurrent execution of the
@@ -172,7 +172,7 @@ void libxl_postfork_child_noexec(libxl_ctx *ctx)
          * use SIGCHLD, but instead just waits for the child(ren). */
         defer_sigchld();
 
-        LIBXL_LIST_INIT(&sigchld_users);
+        XEN_LIST_INIT(&sigchld_users);
         /* After this the ->sigchld_user_registered entries in the
          * now-obsolete contexts may be lies.  But that's OK because
          * no-one will look at them. */
@@ -190,7 +190,7 @@ int libxl__carefd_close(libxl__carefd *cf)
     atfork_lock();
     int r = cf->fd < 0 ? 0 : close(cf->fd);
     int esave = errno;
-    LIBXL_LIST_REMOVE(cf, entry);
+    XEN_LIST_REMOVE(cf, entry);
     atfork_unlock();
     free(cf);
     errno = esave;
@@ -238,7 +238,7 @@ static void sigchld_handler(int signo)
     int r = pthread_mutex_lock(&sigchld_defer_mutex);
     assert(!r);
 
-    LIBXL_LIST_FOREACH(notify, &sigchld_users, sigchld_users_entry) {
+    XEN_LIST_FOREACH(notify, &sigchld_users, sigchld_users_entry) {
         int e = libxl__self_pipe_wakeup(notify->sigchld_selfpipe[1]);
         if (e) abort(); /* errors are probably EBADF, very bad */
     }
@@ -362,11 +362,11 @@ static void sigchld_user_remove(libxl_ctx *ctx) /* idempotent */
     atfork_lock();
     defer_sigchld();
 
-    LIBXL_LIST_REMOVE(ctx, sigchld_users_entry);
+    XEN_LIST_REMOVE(ctx, sigchld_users_entry);
 
     release_sigchld();
 
-    if (LIBXL_LIST_EMPTY(&sigchld_users))
+    if (XEN_LIST_EMPTY(&sigchld_users))
         sigchld_removehandler_core();
 
     atfork_unlock();
@@ -404,7 +404,7 @@ int libxl__sigchld_needed(libxl__gc *gc) /* non-reentrant, idempotent */
 
         defer_sigchld();
 
-        LIBXL_LIST_INSERT_HEAD(&sigchld_users, CTX, sigchld_users_entry);
+        XEN_LIST_INSERT_HEAD(&sigchld_users, CTX, sigchld_users_entry);
 
         release_sigchld();
         atfork_unlock();
@@ -421,7 +421,7 @@ static bool chldmode_ours(libxl_ctx *ctx, bool creating)
 {
     switch (ctx->childproc_hooks->chldowner) {
     case libxl_sigchld_owner_libxl:
-        return creating || !LIBXL_LIST_EMPTY(&ctx->children);
+        return creating || !XEN_LIST_EMPTY(&ctx->children);
     case libxl_sigchld_owner_mainloop:
         return 0;
     case libxl_sigchld_owner_libxl_always:
@@ -452,7 +452,7 @@ static void childproc_reaped_ours(libxl__egc *egc, libxl__ev_child *ch,
                                  int status)
 {
     pid_t pid = ch->pid;
-    LIBXL_LIST_REMOVE(ch, entry);
+    XEN_LIST_REMOVE(ch, entry);
     ch->pid = -1;
     ch->callback(egc, ch, pid, status);
 }
@@ -462,7 +462,7 @@ static int childproc_reaped(libxl__egc *egc, pid_t pid, int status)
     EGC_GC;
     libxl__ev_child *ch;
 
-    LIBXL_LIST_FOREACH(ch, &CTX->children, entry)
+    XEN_LIST_FOREACH(ch, &CTX->children, entry)
         if (ch->pid == pid)
             goto found;
 
@@ -497,7 +497,7 @@ static void childproc_checkall(libxl__egc *egc)
         int status;
         pid_t got;
 
-        LIBXL_LIST_FOREACH(ch, &CTX->children, entry) {
+        XEN_LIST_FOREACH(ch, &CTX->children, entry) {
             got = checked_waitpid(egc, ch->pid, &status);
             if (got)
                 goto found;
@@ -625,7 +625,7 @@ pid_t libxl__ev_child_fork(libxl__gc *gc, libxl__ev_child *ch,
 
     ch->pid = pid;
     ch->callback = death;
-    LIBXL_LIST_INSERT_HEAD(&CTX->children, ch, entry);
+    XEN_LIST_INSERT_HEAD(&CTX->children, ch, entry);
     rc = pid;
 
  out:
@@ -640,7 +640,7 @@ void libxl_childproc_setmode(libxl_ctx *ctx, const libxl_childproc_hooks *hooks,
     GC_INIT(ctx);
     CTX_LOCK;
 
-    assert(LIBXL_LIST_EMPTY(&CTX->children));
+    assert(XEN_LIST_EMPTY(&CTX->children));
 
     if (!hooks)
         hooks = &libxl__childproc_default_hooks;
@@ -698,10 +698,10 @@ void libxl__ev_child_kill_deregister(libxl__ao *ao, libxl__ev_child *ch,
     new_ch->ao = ao;
     new_ch->ch.pid = pid;
     new_ch->ch.callback = deregistered_child_callback;
-    LIBXL_LIST_INSERT_HEAD(&CTX->children, &new_ch->ch, entry);
+    XEN_LIST_INSERT_HEAD(&CTX->children, &new_ch->ch, entry);
     ao->outstanding_killed_child++;
 
-    LIBXL_LIST_REMOVE(ch, entry);
+    XEN_LIST_REMOVE(ch, entry);
     ch->pid = -1;
     int r = kill(pid, sig);
     if (r)
diff --git a/tools/libs/light/libxl_internal.h b/tools/libs/light/libxl_internal.h
index 37d5c27756..c0e7779d97 100644
--- a/tools/libs/light/libxl_internal.h
+++ b/tools/libs/light/libxl_internal.h
@@ -245,7 +245,7 @@ struct libxl__ev_fd {
     short events;
     libxl__ev_fd_callback *func;
     /* remainder is private for libxl__ev_fd... */
-    LIBXL_LIST_ENTRY(libxl__ev_fd) entry;
+    XEN_LIST_ENTRY(libxl__ev_fd) entry;
     libxl__osevent_hook_nexus *nexus;
 };
 
@@ -260,7 +260,7 @@ struct libxl__ao_abortable {
     libxl__ao_abortable_callback *callback;
     /* remainder is private for abort machinery */
     bool registered;
-    LIBXL_LIST_ENTRY(libxl__ao_abortable) entry;
+    XEN_LIST_ENTRY(libxl__ao_abortable) entry;
     /*
      * For nested aos:
      *  Semantically, abort affects the whole tree of aos,
@@ -296,7 +296,7 @@ struct libxl__ev_time {
     libxl__ev_time_callback *func;
     /* remainder is private for libxl__ev_time... */
     int infinite; /* not registered in list or with app if infinite */
-    LIBXL_TAILQ_ENTRY(libxl__ev_time) entry;
+    XEN_TAILQ_ENTRY(libxl__ev_time) entry;
     struct timeval abs;
     libxl__osevent_hook_nexus *nexus;
     libxl__ao_abortable abrt;
@@ -323,7 +323,7 @@ struct libxl__ev_evtchn {
     int port;
     /* remainder is private for libxl__ev_evtchn_... */
     bool waiting;
-    LIBXL_LIST_ENTRY(libxl__ev_evtchn) entry;
+    XEN_LIST_ENTRY(libxl__ev_evtchn) entry;
 };
 
 /*
@@ -341,7 +341,7 @@ struct libxl__ev_evtchn {
  * xswatch pointers when we store and retrieve them.
  */
 typedef struct libxl__ev_watch_slot {
-    LIBXL_SLIST_ENTRY(struct libxl__ev_watch_slot) empty;
+    XEN_SLIST_ENTRY(struct libxl__ev_watch_slot) empty;
 } libxl__ev_watch_slot;
 
 _hidden libxl__ev_xswatch *libxl__watch_slot_contents(libxl__gc *gc,
@@ -357,7 +357,7 @@ struct libxl__ev_child {
     pid_t pid; /* -1 means unused ("unregistered", ie Idle) */
     libxl__ev_child_callback *callback;
     /* remainder is private for libxl__ev_... */
-    LIBXL_LIST_ENTRY(struct libxl__ev_child) entry;
+    XEN_LIST_ENTRY(struct libxl__ev_child) entry;
 };
 
 /* libxl__ev_immediate
@@ -370,7 +370,7 @@ struct libxl__ev_immediate {
     /* filled by user */
     void (*callback)(libxl__egc *, libxl__ev_immediate *);
     /* private to libxl__ev_immediate */
-    LIBXL_STAILQ_ENTRY(libxl__ev_immediate) entry;
+    XEN_STAILQ_ENTRY(libxl__ev_immediate) entry;
 };
 void libxl__ev_immediate_register(libxl__egc *, libxl__ev_immediate *);
 
@@ -582,7 +582,7 @@ _hidden void libxl__qmp_param_add_integer(libxl__gc *gc,
 struct libxl__evgen_domain_death {
     uint32_t domid;
     unsigned shutdown_reported:1, death_reported:1;
-    LIBXL_TAILQ_ENTRY(libxl_evgen_domain_death) entry;
+    XEN_TAILQ_ENTRY(libxl_evgen_domain_death) entry;
         /* on list .death_reported ? CTX->death_list : CTX->death_reported */
     libxl_ev_user user;
 };
@@ -592,7 +592,7 @@ libxl__evdisable_domain_death(libxl__gc*, libxl_evgen_domain_death*);
 struct libxl__evgen_disk_eject {
     libxl__ev_xswatch watch;
     uint32_t domid;
-    LIBXL_LIST_ENTRY(libxl_evgen_disk_eject) entry;
+    XEN_LIST_ENTRY(libxl_evgen_disk_eject) entry;
     libxl_ev_user user;
     char *vdev, *be_ptr_path;
 };
@@ -620,7 +620,7 @@ struct libxl__poller {
      * The "poller_app" is never idle, but is sometimes on
      * pollers_event.
      */
-    LIBXL_LIST_ENTRY(libxl__poller) entry;
+    XEN_LIST_ENTRY(libxl__poller) entry;
 
     struct pollfd *fd_polls;
     int fd_polls_allocd;
@@ -653,7 +653,7 @@ struct libxl__poller {
      * a promise to also make this check, so the baton will never be
      * dropped.
      */
-    LIBXL_LIST_ENTRY(libxl__poller) active_entry;
+    XEN_LIST_ENTRY(libxl__poller) active_entry;
     bool fds_deregistered;
     bool osevents_added;
 };
@@ -687,7 +687,7 @@ struct libxl__ctx {
        * documented in the libxl public interface.
        */
 
-    LIBXL_TAILQ_HEAD(libxl__event_list, libxl_event) occurred;
+    XEN_TAILQ_HEAD(libxl__event_list, libxl_event) occurred;
 
     int osevent_in_hook;
     const libxl_osevent_hooks *osevent_hooks;
@@ -696,40 +696,40 @@ struct libxl__ctx {
        * for restrictions on the use of the osevent fields. */
 
     libxl__poller *poller_app; /* libxl_osevent_beforepoll and _afterpoll */
-    LIBXL_LIST_HEAD(, libxl__poller) pollers_event, pollers_idle;
-    LIBXL_LIST_HEAD(, libxl__poller) pollers_active;
+    XEN_LIST_HEAD(, libxl__poller) pollers_event, pollers_idle;
+    XEN_LIST_HEAD(, libxl__poller) pollers_active;
 
-    LIBXL_SLIST_HEAD(libxl__osevent_hook_nexi, libxl__osevent_hook_nexus)
+    XEN_SLIST_HEAD(libxl__osevent_hook_nexi, libxl__osevent_hook_nexus)
         hook_fd_nexi_idle, hook_timeout_nexi_idle;
-    LIBXL_LIST_HEAD(, libxl__ev_fd) efds;
-    LIBXL_TAILQ_HEAD(, libxl__ev_time) etimes;
+    XEN_LIST_HEAD(, libxl__ev_fd) efds;
+    XEN_TAILQ_HEAD(, libxl__ev_time) etimes;
 
     libxl__ev_watch_slot *watch_slots;
     int watch_nslots, nwatches;
-    LIBXL_SLIST_HEAD(, libxl__ev_watch_slot) watch_freeslots;
+    XEN_SLIST_HEAD(, libxl__ev_watch_slot) watch_freeslots;
     uint32_t watch_counter; /* helps disambiguate slot reuse */
     libxl__ev_fd watch_efd;
 
     xenevtchn_handle *xce; /* waiting must be done only with libxl__ev_evtchn* */
-    LIBXL_LIST_HEAD(, libxl__ev_evtchn) evtchns_waiting;
+    XEN_LIST_HEAD(, libxl__ev_evtchn) evtchns_waiting;
     libxl__ev_fd evtchn_efd;
 
-    LIBXL_LIST_HEAD(, libxl__ao) aos_inprogress;
+    XEN_LIST_HEAD(, libxl__ao) aos_inprogress;
 
-    LIBXL_TAILQ_HEAD(libxl__evgen_domain_death_list, libxl_evgen_domain_death)
+    XEN_TAILQ_HEAD(libxl__evgen_domain_death_list, libxl_evgen_domain_death)
         death_list /* sorted by domid */,
         death_reported;
     libxl__ev_xswatch death_watch;
 
-    LIBXL_LIST_HEAD(, libxl_evgen_disk_eject) disk_eject_evgens;
+    XEN_LIST_HEAD(, libxl_evgen_disk_eject) disk_eject_evgens;
 
     const libxl_childproc_hooks *childproc_hooks;
     void *childproc_user;
     int sigchld_selfpipe[2]; /* [0]==-1 means handler not installed */
     libxl__ev_fd sigchld_selfpipe_efd;
-    LIBXL_LIST_HEAD(, libxl__ev_child) children;
+    XEN_LIST_HEAD(, libxl__ev_child) children;
     bool sigchld_user_registered;
-    LIBXL_LIST_ENTRY(libxl_ctx) sigchld_users_entry;
+    XEN_LIST_ENTRY(libxl_ctx) sigchld_users_entry;
 
     libxl_version_info version_info;
 
@@ -774,9 +774,9 @@ struct libxl__egc {
      * The egc and its gc may be accessed only on the creating thread. */
     struct libxl__gc gc;
     struct libxl__event_list occurred_for_callback;
-    LIBXL_TAILQ_HEAD(, libxl__ao) aos_for_callback;
-    LIBXL_TAILQ_HEAD(, libxl__aop_occurred) aops_for_callback;
-    LIBXL_STAILQ_HEAD(, libxl__ev_immediate) ev_immediates;
+    XEN_TAILQ_HEAD(, libxl__ao) aos_for_callback;
+    XEN_TAILQ_HEAD(, libxl__aop_occurred) aops_for_callback;
+    XEN_STAILQ_HEAD(, libxl__ev_immediate) ev_immediates;
 };
 
 struct libxl__aop_occurred {
@@ -787,7 +787,7 @@ struct libxl__aop_occurred {
      * While an aop exists, it corresponds to one refcount in
      * ao->progress_reports_outstanding, preventing ao destruction.
      */
-    LIBXL_TAILQ_ENTRY(libxl__aop_occurred) entry;
+    XEN_TAILQ_ENTRY(libxl__aop_occurred) entry;
     libxl__ao *ao;
     libxl_event *ev;
     const libxl_asyncprogress_how *how;
@@ -819,13 +819,13 @@ struct libxl__ao {
     int nested_progeny;
     int progress_reports_outstanding;
     int rc;
-    LIBXL_LIST_HEAD(, libxl__ao_abortable) abortables;
-    LIBXL_LIST_ENTRY(libxl__ao) inprogress_entry;
+    XEN_LIST_HEAD(, libxl__ao_abortable) abortables;
+    XEN_LIST_ENTRY(libxl__ao) inprogress_entry;
     libxl__gc gc;
     libxl_asyncop_how how;
     libxl__poller *poller;
     uint32_t domid;
-    LIBXL_TAILQ_ENTRY(libxl__ao) entry_for_callback;
+    XEN_TAILQ_ENTRY(libxl__ao) entry_for_callback;
     int outstanding_killed_child;
 };
 
@@ -2379,10 +2379,10 @@ bool libxl__stubdomain_is_linux(libxl_domain_build_info *b_info)
 
 #define LIBXL_INIT_EGC(egc,ctx) do{                     \
         LIBXL_INIT_GC((egc).gc,ctx);                    \
-        LIBXL_TAILQ_INIT(&(egc).occurred_for_callback); \
-        LIBXL_TAILQ_INIT(&(egc).aos_for_callback);      \
-        LIBXL_TAILQ_INIT(&(egc).aops_for_callback);     \
-        LIBXL_STAILQ_INIT(&(egc).ev_immediates);        \
+        XEN_TAILQ_INIT(&(egc).occurred_for_callback);   \
+        XEN_TAILQ_INIT(&(egc).aos_for_callback);        \
+        XEN_TAILQ_INIT(&(egc).aops_for_callback);       \
+        XEN_STAILQ_INIT(&(egc).ev_immediates);          \
     } while(0)
 
 _hidden void libxl__egc_ao_cleanup_1_baton(libxl__gc *gc);
@@ -3141,7 +3141,7 @@ typedef void libxl__datacopier_callback(libxl__egc *egc,
 
 struct libxl__datacopier_buf {
     /* private to datacopier */
-    LIBXL_TAILQ_ENTRY(libxl__datacopier_buf) entry;
+    XEN_TAILQ_ENTRY(libxl__datacopier_buf) entry;
     int used;
     char buf[1000];
 };
@@ -3163,7 +3163,7 @@ struct libxl__datacopier_state {
     libxl__ao_abortable abrt;
     libxl__ev_fd toread, towrite;
     ssize_t used;
-    LIBXL_TAILQ_HEAD(libxl__datacopier_bufs, libxl__datacopier_buf) bufs;
+    XEN_TAILQ_HEAD(libxl__datacopier_bufs, libxl__datacopier_buf) bufs;
 };
 
 _hidden void libxl__datacopier_init(libxl__datacopier_state *dc);
@@ -3443,7 +3443,7 @@ typedef struct libxl__stream_read_state libxl__stream_read_state;
 
 typedef struct libxl__sr_record_buf {
     /* private to stream read helper */
-    LIBXL_STAILQ_ENTRY(struct libxl__sr_record_buf) entry;
+    XEN_STAILQ_ENTRY(struct libxl__sr_record_buf) entry;
     libxl__sr_rec_hdr hdr;
     void *body; /* iff hdr.length != 0 */
 } libxl__sr_record_buf;
@@ -3473,7 +3473,7 @@ struct libxl__stream_read_state {
     /* Main stream-reading data. */
     libxl__datacopier_state dc; /* Only used when reading a record */
     libxl__sr_hdr hdr;
-    LIBXL_STAILQ_HEAD(, libxl__sr_record_buf) record_queue; /* NOGC */
+    XEN_STAILQ_HEAD(, libxl__sr_record_buf) record_queue; /* NOGC */
     enum {
         SRS_PHASE_NORMAL,
         SRS_PHASE_BUFFERING,
@@ -4599,9 +4599,9 @@ static inline int libxl__defbool_is_default(libxl_defbool *db)
 #define LIBXL_TAILQ_INSERT_SORTED(head, entry, elm_new, elm_search,     \
                                   search_body, new_after_search_p)      \
     do {                                                                \
-        for ((elm_search) = LIBXL_TAILQ_FIRST((head));                  \
+        for ((elm_search) = XEN_TAILQ_FIRST((head));                    \
              (elm_search);                                              \
-             (elm_search) = LIBXL_TAILQ_NEXT((elm_search), entry)) {    \
+             (elm_search) = XEN_TAILQ_NEXT((elm_search), entry)) {      \
             search_body;                                                \
             if (!(new_after_search_p))                                  \
                 break;                                                  \
@@ -4610,9 +4610,9 @@ static inline int libxl__defbool_is_default(libxl_defbool *db)
          * to place elm_new, or NULL meaning we want to put elm_new at  \
          * the end */                                                   \
         if ((elm_search))                                               \
-            LIBXL_TAILQ_INSERT_BEFORE((elm_search), (elm_new), entry);  \
+            XEN_TAILQ_INSERT_BEFORE((elm_search), (elm_new), entry);    \
         else                                                            \
-            LIBXL_TAILQ_INSERT_TAIL((head), (elm_new), entry);          \
+            XEN_TAILQ_INSERT_TAIL((head), (elm_new), entry);            \
     } while(0)
 
 
diff --git a/tools/libs/light/libxl_qmp.c b/tools/libs/light/libxl_qmp.c
index fb146a54cb..8faa102e4d 100644
--- a/tools/libs/light/libxl_qmp.c
+++ b/tools/libs/light/libxl_qmp.c
@@ -63,7 +63,7 @@
 
 #include <yajl/yajl_gen.h>
 
-#include "_libxl_list.h"
+#include "_xen_list.h"
 #include "libxl_internal.h"
 
 /* #define DEBUG_RECEIVED */
@@ -107,7 +107,7 @@ typedef struct callback_id_pair {
     qmp_callback_t callback;
     void *opaque;
     qmp_request_context *context;
-    LIBXL_STAILQ_ENTRY(struct callback_id_pair) next;
+    XEN_STAILQ_ENTRY(struct callback_id_pair) next;
 } callback_id_pair;
 
 struct libxl__qmp_handler {
@@ -123,7 +123,7 @@ struct libxl__qmp_handler {
     uint32_t domid;
 
     int last_id_used;
-    LIBXL_STAILQ_HEAD(callback_list, callback_id_pair) callback_list;
+    XEN_STAILQ_HEAD(callback_list, callback_id_pair) callback_list;
     struct {
         int major;
         int minor;
@@ -189,7 +189,7 @@ static callback_id_pair *qmp_get_callback_from_id(libxl__qmp_handler *qmp,
     if (id_object) {
         id = libxl__json_object_get_integer(id_object);
 
-        LIBXL_STAILQ_FOREACH(pp, &qmp->callback_list, next) {
+        XEN_STAILQ_FOREACH(pp, &qmp->callback_list, next) {
             if (pp->id == id) {
                 return pp;
             }
@@ -217,7 +217,7 @@ static void qmp_handle_error_response(libxl__gc *gc, libxl__qmp_handler *qmp,
             /* tell that the id have been processed */
             qmp->wait_for_id = 0;
         }
-        LIBXL_STAILQ_REMOVE(&qmp->callback_list, pp, callback_id_pair, next);
+        XEN_STAILQ_REMOVE(&qmp->callback_list, pp, callback_id_pair, next);
         free(pp);
     }
 
@@ -266,8 +266,7 @@ static int qmp_handle_response(libxl__gc *gc, libxl__qmp_handler *qmp,
                 /* tell that the id have been processed */
                 qmp->wait_for_id = 0;
             }
-            LIBXL_STAILQ_REMOVE(&qmp->callback_list, pp, callback_id_pair,
-                                next);
+            XEN_STAILQ_REMOVE(&qmp->callback_list, pp, callback_id_pair, next);
             free(pp);
         }
         return 0;
@@ -325,7 +324,7 @@ static libxl__qmp_handler *qmp_init_handler(libxl__gc *gc, uint32_t domid)
     qmp->domid = domid;
     qmp->timeout = 5;
 
-    LIBXL_STAILQ_INIT(&qmp->callback_list);
+    XEN_STAILQ_INIT(&qmp->callback_list);
 
     return qmp;
 }
@@ -383,7 +382,7 @@ static void qmp_close(libxl__qmp_handler *qmp)
     callback_id_pair *tmp = NULL;
 
     close(qmp->qmp_fd);
-    LIBXL_STAILQ_FOREACH(pp, &qmp->callback_list, next) {
+    XEN_STAILQ_FOREACH(pp, &qmp->callback_list, next) {
         free(tmp);
         tmp = pp;
     }
@@ -547,7 +546,7 @@ static char *qmp_send_prepare(libxl__gc *gc, libxl__qmp_handler *qmp,
     elm->callback = callback;
     elm->opaque = opaque;
     elm->context = context;
-    LIBXL_STAILQ_INSERT_TAIL(&qmp->callback_list, elm, next);
+    XEN_STAILQ_INSERT_TAIL(&qmp->callback_list, elm, next);
 
     LOGD(DEBUG, qmp->domid, "next qmp command: '%s'", buf);
 
diff --git a/tools/libs/light/libxl_stream_read.c b/tools/libs/light/libxl_stream_read.c
index 99a6714e76..e64e8f0ead 100644
--- a/tools/libs/light/libxl_stream_read.c
+++ b/tools/libs/light/libxl_stream_read.c
@@ -214,7 +214,7 @@ void libxl__stream_read_init(libxl__stream_read_state *stream)
     stream->sync_teardown = false;
     FILLZERO(stream->dc);
     FILLZERO(stream->hdr);
-    LIBXL_STAILQ_INIT(&stream->record_queue);
+    XEN_STAILQ_INIT(&stream->record_queue);
     stream->phase = SRS_PHASE_NORMAL;
     stream->recursion_guard = false;
     stream->incoming_record = NULL;
@@ -402,7 +402,7 @@ static void stream_continue(libxl__egc *egc,
          * processing the record.  There should never be two records
          * in the queue.
          */
-        if (LIBXL_STAILQ_EMPTY(&stream->record_queue))
+        if (XEN_STAILQ_EMPTY(&stream->record_queue))
             setup_read_record(egc, stream);
         else {
             if (process_record(egc, stream))
@@ -412,7 +412,7 @@ static void stream_continue(libxl__egc *egc,
              * process_record() had better have consumed the one and
              * only record in the queue.
              */
-            assert(LIBXL_STAILQ_EMPTY(&stream->record_queue));
+            assert(XEN_STAILQ_EMPTY(&stream->record_queue));
         }
         break;
 
@@ -428,7 +428,7 @@ static void stream_continue(libxl__egc *egc,
          * the tail to spot the CHECKPOINT_END record, and switch to
          * the unbuffering phase.
          */
-        libxl__sr_record_buf *rec = LIBXL_STAILQ_LAST(
+        libxl__sr_record_buf *rec = XEN_STAILQ_LAST(
             &stream->record_queue, libxl__sr_record_buf, entry);
 
         assert(stream->in_checkpoint);
@@ -537,7 +537,7 @@ static void record_body_done(libxl__egc *egc,
     if (rc)
         goto err;
 
-    LIBXL_STAILQ_INSERT_TAIL(&stream->record_queue, rec, entry);
+    XEN_STAILQ_INSERT_TAIL(&stream->record_queue, rec, entry);
     stream->incoming_record = NULL;
 
     stream_continue(egc, stream);
@@ -567,9 +567,9 @@ static bool process_record(libxl__egc *egc,
     int rc = 0;
 
     /* Pop a record from the head of the queue. */
-    assert(!LIBXL_STAILQ_EMPTY(&stream->record_queue));
-    rec = LIBXL_STAILQ_FIRST(&stream->record_queue);
-    LIBXL_STAILQ_REMOVE_HEAD(&stream->record_queue, entry);
+    assert(!XEN_STAILQ_EMPTY(&stream->record_queue));
+    rec = XEN_STAILQ_FIRST(&stream->record_queue);
+    XEN_STAILQ_REMOVE_HEAD(&stream->record_queue, entry);
 
     LOG(DEBUG, "Record: %u, length %u", rec->hdr.type, rec->hdr.length);
 
@@ -813,9 +813,9 @@ static void stream_done(libxl__egc *egc,
 
     /* The record queue had better be empty if the stream believes
      * itself to have been successful. */
-    assert(LIBXL_STAILQ_EMPTY(&stream->record_queue) || stream->rc);
+    assert(XEN_STAILQ_EMPTY(&stream->record_queue) || stream->rc);
 
-    LIBXL_STAILQ_FOREACH_SAFE(rec, &stream->record_queue, entry, trec)
+    XEN_STAILQ_FOREACH_SAFE(rec, &stream->record_queue, entry, trec)
         free_record(rec);
 
     if (!stream->back_channel) {
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Tue Feb 08 07:06:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 07:06:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267539.461288 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHKaL-0008Qb-Hn; Tue, 08 Feb 2022 07:06:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267539.461288; Tue, 08 Feb 2022 07:06:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHKaL-0008QU-E9; Tue, 08 Feb 2022 07:06:45 +0000
Received: by outflank-mailman (input) for mailman id 267539;
 Tue, 08 Feb 2022 07:06:43 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=co3W=SX=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nHKaJ-0008AS-KA
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 07:06:43 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ab0a14c1-88ad-11ec-8f75-fffcc8bd4f1a;
 Tue, 08 Feb 2022 08:06:42 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 0DE5C21106;
 Tue,  8 Feb 2022 07:06:42 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C09B613B7F;
 Tue,  8 Feb 2022 07:06:41 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id APeoLYEWAmKxHgAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 08 Feb 2022 07:06:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ab0a14c1-88ad-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1644304002; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Y3JYUku98qeZg6VOnInB3O+12NYpmiH94/YoTHJL2nY=;
	b=e3dxfCJaE87YJujX3F8bFRkPyXU/qA/bzF08wB6YXTUTKBRgV1aoYKGfA+O+4W+fbD9DDV
	pBwIbabSpdcJoe2SHv4MiEBy+4+FeYOqr/UlYSAlwVzJPn8hM2WGplgESwOgiO3NtGX8mf
	4Q/rGZ7Wl4dslBsX3wl4jxbBahcZWGs=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>
Subject: [PATCH v3 3/5] tools/libs/toolcore: replace _xentoolcore_list.h with _xen_list.h
Date: Tue,  8 Feb 2022 08:06:36 +0100
Message-Id: <20220208070638.5909-4-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220208070638.5909-1-jgross@suse.com>
References: <20220208070638.5909-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Remove generating _xentoolcore_list.h and use the common _xen_list.h
instead.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
v3:
- fix build (Anthony PERARD)
---
 .gitignore                           | 1 -
 tools/include/xentoolcore_internal.h | 4 ++--
 tools/libs/toolcore/Makefile         | 8 --------
 tools/libs/toolcore/handlereg.c      | 8 ++++----
 4 files changed, 6 insertions(+), 15 deletions(-)

diff --git a/.gitignore b/.gitignore
index 3f9d55ba87..afe78c787c 100644
--- a/.gitignore
+++ b/.gitignore
@@ -227,7 +227,6 @@ tools/hotplug/NetBSD/rc.d/xencommons
 tools/hotplug/NetBSD/rc.d/xendriverdomain
 tools/include/acpi
 tools/include/_libxl*.h
-tools/include/_xentoolcore_list.h
 tools/include/xen/*
 tools/include/xen-xsm/*
 tools/include/xen-foreign/*.(c|h|size)
diff --git a/tools/include/xentoolcore_internal.h b/tools/include/xentoolcore_internal.h
index 04f5848f09..deccefd612 100644
--- a/tools/include/xentoolcore_internal.h
+++ b/tools/include/xentoolcore_internal.h
@@ -27,7 +27,7 @@
 #include <stddef.h>
 
 #include "xentoolcore.h"
-#include "_xentoolcore_list.h"
+#include "_xen_list.h"
 
 /*---------- active handle registration ----------*/
 
@@ -87,7 +87,7 @@ typedef int Xentoolcore__Restrict_Callback(Xentoolcore__Active_Handle*,
 
 struct Xentoolcore__Active_Handle {
     Xentoolcore__Restrict_Callback *restrict_callback;
-    XENTOOLCORE_LIST_ENTRY(Xentoolcore__Active_Handle) entry;
+    XEN_LIST_ENTRY(Xentoolcore__Active_Handle) entry;
 };
 
 void xentoolcore__register_active_handle(Xentoolcore__Active_Handle*);
diff --git a/tools/libs/toolcore/Makefile b/tools/libs/toolcore/Makefile
index ed4ae00694..9c013b2879 100644
--- a/tools/libs/toolcore/Makefile
+++ b/tools/libs/toolcore/Makefile
@@ -3,7 +3,6 @@ include $(XEN_ROOT)/tools/Rules.mk
 
 MAJOR	= 1
 MINOR	= 0
-AUTOINCS := $(XEN_INCLUDE)/_xentoolcore_list.h
 
 LIBHEADER := xentoolcore.h
 
@@ -12,10 +11,3 @@ SRCS-y	+= handlereg.c
 include $(XEN_ROOT)/tools/libs/libs.mk
 
 PKG_CONFIG_DESC := Central support for Xen Hypervisor userland libraries
-
-$(LIB_OBJS): $(AUTOINCS)
-$(PIC_OBJS): $(AUTOINCS)
-
-$(XEN_INCLUDE)/_xentoolcore_list.h: $(XEN_INCLUDE)/xen-external/bsd-sys-queue-h-seddery $(XEN_INCLUDE)/xen-external/bsd-sys-queue.h
-	$(PERL) $^ --prefix=xentoolcore >$(notdir $@).new
-	$(call move-if-changed,$(notdir $@).new,$@)
diff --git a/tools/libs/toolcore/handlereg.c b/tools/libs/toolcore/handlereg.c
index baec55e2a4..b43cb0e8ac 100644
--- a/tools/libs/toolcore/handlereg.c
+++ b/tools/libs/toolcore/handlereg.c
@@ -31,7 +31,7 @@
 #include <assert.h>
 
 static pthread_mutex_t handles_lock = PTHREAD_MUTEX_INITIALIZER;
-static XENTOOLCORE_LIST_HEAD(, Xentoolcore__Active_Handle) handles;
+static XEN_LIST_HEAD(, Xentoolcore__Active_Handle) handles;
 
 static void lock(void) {
     int e = pthread_mutex_lock(&handles_lock);
@@ -45,13 +45,13 @@ static void unlock(void) {
 
 void xentoolcore__register_active_handle(Xentoolcore__Active_Handle *ah) {
     lock();
-    XENTOOLCORE_LIST_INSERT_HEAD(&handles, ah, entry);
+    XEN_LIST_INSERT_HEAD(&handles, ah, entry);
     unlock();
 }
 
 void xentoolcore__deregister_active_handle(Xentoolcore__Active_Handle *ah) {
     lock();
-    XENTOOLCORE_LIST_REMOVE(ah, entry);
+    XEN_LIST_REMOVE(ah, entry);
     unlock();
 }
 
@@ -60,7 +60,7 @@ int xentoolcore_restrict_all(domid_t domid) {
     Xentoolcore__Active_Handle *ah;
 
     lock();
-    XENTOOLCORE_LIST_FOREACH(ah, &handles, entry) {
+    XEN_LIST_FOREACH(ah, &handles, entry) {
         r = ah->restrict_callback(ah, domid);
         if (r) goto out;
     }
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Tue Feb 08 07:06:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 07:06:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267538.461277 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHKaK-0008B3-8y; Tue, 08 Feb 2022 07:06:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267538.461277; Tue, 08 Feb 2022 07:06:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHKaK-0008Aw-5g; Tue, 08 Feb 2022 07:06:44 +0000
Received: by outflank-mailman (input) for mailman id 267538;
 Tue, 08 Feb 2022 07:06:42 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=co3W=SX=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nHKaI-0008AS-SC
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 07:06:42 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id aaa26fdb-88ad-11ec-8f75-fffcc8bd4f1a;
 Tue, 08 Feb 2022 08:06:41 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 494FC1F37C;
 Tue,  8 Feb 2022 07:06:41 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 03C7113483;
 Tue,  8 Feb 2022 07:06:40 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id xVo3O4AWAmKxHgAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 08 Feb 2022 07:06:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: aaa26fdb-88ad-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1644304001; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=S+1TdT4Amyy2uLXf8W6qeb6Ha8uG8anpXDpgcCtj+m4=;
	b=MeTOp3SvXw9MkS0s+HP7jVqGivqLoGj8YnSpKwW54X/mixkwqfqqqIZ8ziu8aOfQ8fGgse
	lJ9MCP/njHGm2yfDmK/FxWR0zgIrP73dl1/DJShWFEWaNtzjFZqQcVhpwXm/r5dRxkXJaq
	Rg5MvJsVSqsl8GqEvBCmYNbxPjGk4iw=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: [PATCH v3 0/5] tools: remove include/xen-external directory
Date: Tue,  8 Feb 2022 08:06:33 +0100
Message-Id: <20220208070638.5909-1-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

The tools/include/xen-external directory contains a header file from
FreeBSD used to generate Xen header files. This series is replacing the
complete directory by a single header with the same semantics.

Changes in V3:
- fix patch 3

Changes in V2:
- remove stale comment in patch 1

Juergen Gross (5):
  tools/include: generate a _xen_list.h file
  tools/libs/light: replace _libxl_list.h with _xen_list.h
  tools/libs/toolcore: replace _xentoolcore_list.h with _xen_list.h
  tools/libs/evtchn: use _xen_list.h
  tools/include: remove xen-external directory

 .gitignore                                    |    1 -
 tools/include/Makefile                        |    2 +
 tools/include/_xen_list.h                     |  509 ++++++++
 tools/include/libxl.h                         |    4 +-
 tools/include/xen-external/README             |   24 -
 tools/include/xen-external/bsd-COPYRIGHT      |  126 --
 tools/include/xen-external/bsd-queue.3        | 1044 -----------------
 .../xen-external/bsd-sys-queue-h-seddery      |   74 --
 tools/include/xen-external/bsd-sys-queue.h    |  637 ----------
 tools/include/xentoolcore_internal.h          |    4 +-
 tools/libs/evtchn/minios.c                    |   20 +-
 tools/libs/light/Makefile                     |   10 +-
 tools/libs/light/libxl.c                      |   40 +-
 tools/libs/light/libxl_aoutils.c              |   20 +-
 tools/libs/light/libxl_device.c               |   27 +-
 tools/libs/light/libxl_disk.c                 |    4 +-
 tools/libs/light/libxl_domain.c               |   18 +-
 tools/libs/light/libxl_event.c                |  128 +-
 tools/libs/light/libxl_fork.c                 |   44 +-
 tools/libs/light/libxl_internal.h             |   86 +-
 tools/libs/light/libxl_qmp.c                  |   19 +-
 tools/libs/light/libxl_stream_read.c          |   20 +-
 tools/libs/toolcore/Makefile                  |    8 -
 tools/libs/toolcore/handlereg.c               |    8 +-
 24 files changed, 733 insertions(+), 2144 deletions(-)
 create mode 100644 tools/include/_xen_list.h
 delete mode 100644 tools/include/xen-external/README
 delete mode 100644 tools/include/xen-external/bsd-COPYRIGHT
 delete mode 100644 tools/include/xen-external/bsd-queue.3
 delete mode 100755 tools/include/xen-external/bsd-sys-queue-h-seddery
 delete mode 100644 tools/include/xen-external/bsd-sys-queue.h

-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Tue Feb 08 07:06:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 07:06:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267542.461321 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHKaO-0000nV-PQ; Tue, 08 Feb 2022 07:06:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267542.461321; Tue, 08 Feb 2022 07:06:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHKaO-0000nM-Lm; Tue, 08 Feb 2022 07:06:48 +0000
Received: by outflank-mailman (input) for mailman id 267542;
 Tue, 08 Feb 2022 07:06:46 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=co3W=SX=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nHKaM-0008SU-FU
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 07:06:46 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id aaa78e9e-88ad-11ec-8eb8-a37418f5ba1a;
 Tue, 08 Feb 2022 08:06:43 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 7B27721100;
 Tue,  8 Feb 2022 07:06:41 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 518F213483;
 Tue,  8 Feb 2022 07:06:41 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id MDOZEoEWAmKxHgAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 08 Feb 2022 07:06:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: aaa78e9e-88ad-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1644304001; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=mCUb5g78LuJVrOtCJeFF2txQ1SfvngrUecaJfWrIMSg=;
	b=pi/Zzj2yFuUYK3zI2wgKrrv6EjPrpmA5sZOzeuNymMF3PfC/PMaTYE0u+90TQYnELNimOM
	Kug1IfOJnrcHuXLg2MbaAneVTqVVvCV3pSlDVRFBbm1i3gs3emQ3gNdxPiBz1jPg9EMCTU
	4HIvxh42ecZL8lfIh2gxX5iNq6uDmlo=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>
Subject: [PATCH v3 1/5] tools/include: generate a _xen_list.h file
Date: Tue,  8 Feb 2022 08:06:34 +0100
Message-Id: <20220208070638.5909-2-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220208070638.5909-1-jgross@suse.com>
References: <20220208070638.5909-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Today tools/include contains two basically identical header files
generated from the same source. They just differ by the used name space
and they are being generated from different Makefiles via a perl
script.

Prepare to have only one such header by using a more generic namespace
"XEN" for _xen_list.h.

As the original header hasn't been updated in the Xen tree since its
introduction about 10 years ago, and the updates of FreeBSD side have
mostly covered BSD internal debugging aids, just don't generate the
new header during build, especially as using the current FreeBSD
version of the file would require some updates of the perl script,
which are potentially more work than just doing the needed editing by
hand. Additionally this enables to remove the not needed debugging
extensions of FreeBSD.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 tools/include/Makefile    |   2 +
 tools/include/_xen_list.h | 509 ++++++++++++++++++++++++++++++++++++++
 2 files changed, 511 insertions(+)
 create mode 100644 tools/include/_xen_list.h

diff --git a/tools/include/Makefile b/tools/include/Makefile
index d7b51006e0..d965987f55 100644
--- a/tools/include/Makefile
+++ b/tools/include/Makefile
@@ -70,11 +70,13 @@ install: all
 	$(INSTALL_DATA) xen/io/*.h $(DESTDIR)$(includedir)/xen/io
 	$(INSTALL_DATA) xen/sys/*.h $(DESTDIR)$(includedir)/xen/sys
 	$(INSTALL_DATA) xen/xsm/*.h $(DESTDIR)$(includedir)/xen/xsm
+	$(INSTALL_DATA) _xen_list.h $(DESTDIR)$(includedir)
 
 .PHONY: uninstall
 uninstall:
 	echo "[FIXME] uninstall headers"
 	rm -rf $(DESTDIR)$(includedir)/xen
+	rm -f $(DESTDIR)$(includedir)/_xen_list.h
 
 .PHONY: clean
 clean:
diff --git a/tools/include/_xen_list.h b/tools/include/_xen_list.h
new file mode 100644
index 0000000000..ce246f95c9
--- /dev/null
+++ b/tools/include/_xen_list.h
@@ -0,0 +1,509 @@
+/*-
+ * Copyright (c) 1991, 1993
+ *	The Regents of the University of California.  All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *    notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *    notice, this list of conditions and the following disclaimer in the
+ *    documentation and/or other materials provided with the distribution.
+ * 4. Neither the name of the University nor the names of its contributors
+ *    may be used to endorse or promote products derived from this software
+ *    without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND
+ * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+ * ARE DISCLAIMED.  IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE
+ * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+ * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
+ * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
+ * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
+ * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
+ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
+ * SUCH DAMAGE.
+ *
+ *	@(#)queue.h	8.5 (Berkeley) 8/20/94
+ * $FreeBSD$
+ */
+
+#ifndef XEN__SYS_QUEUE_H_
+#define	XEN__SYS_QUEUE_H_
+
+/* #include <sys/cdefs.h> */
+
+/*
+ * This file defines four types of data structures: singly-linked lists,
+ * singly-linked tail queues, lists and tail queues.
+ *
+ * A singly-linked list is headed by a single forward pointer. The elements
+ * are singly linked for minimum space and pointer manipulation overhead at
+ * the expense of O(n) removal for arbitrary elements. New elements can be
+ * added to the list after an existing element or at the head of the list.
+ * Elements being removed from the head of the list should use the explicit
+ * macro for this purpose for optimum efficiency. A singly-linked list may
+ * only be traversed in the forward direction.  Singly-linked lists are ideal
+ * for applications with large datasets and few or no removals or for
+ * implementing a LIFO queue.
+ *
+ * A singly-linked tail queue is headed by a pair of pointers, one to the
+ * head of the list and the other to the tail of the list. The elements are
+ * singly linked for minimum space and pointer manipulation overhead at the
+ * expense of O(n) removal for arbitrary elements. New elements can be added
+ * to the list after an existing element, at the head of the list, or at the
+ * end of the list. Elements being removed from the head of the tail queue
+ * should use the explicit macro for this purpose for optimum efficiency.
+ * A singly-linked tail queue may only be traversed in the forward direction.
+ * Singly-linked tail queues are ideal for applications with large datasets
+ * and few or no removals or for implementing a FIFO queue.
+ *
+ * A list is headed by a single forward pointer (or an array of forward
+ * pointers for a hash table header). The elements are doubly linked
+ * so that an arbitrary element can be removed without a need to
+ * traverse the list. New elements can be added to the list before
+ * or after an existing element or at the head of the list. A list
+ * may only be traversed in the forward direction.
+ *
+ * A tail queue is headed by a pair of pointers, one to the head of the
+ * list and the other to the tail of the list. The elements are doubly
+ * linked so that an arbitrary element can be removed without a need to
+ * traverse the list. New elements can be added to the list before or
+ * after an existing element, at the head of the list, or at the end of
+ * the list. A tail queue may be traversed in either direction.
+ *
+ * For details on the use of these macros, see the queue(3) manual page.
+ *
+ *
+ *				XEN_SLIST	XEN_LIST	XEN_STAILQ	XEN_TAILQ
+ * _HEAD			+	+	+	+
+ * _HEAD_INITIALIZER		+	+	+	+
+ * _ENTRY			+	+	+	+
+ * _INIT			+	+	+	+
+ * _EMPTY			+	+	+	+
+ * _FIRST			+	+	+	+
+ * _NEXT			+	+	+	+
+ * _PREV			-	-	-	+
+ * _LAST			-	-	+	+
+ * _FOREACH			+	+	+	+
+ * _FOREACH_SAFE		+	+	+	+
+ * _FOREACH_REVERSE		-	-	-	+
+ * _FOREACH_REVERSE_SAFE	-	-	-	+
+ * _INSERT_HEAD			+	+	+	+
+ * _INSERT_BEFORE		-	+	-	+
+ * _INSERT_AFTER		+	+	+	+
+ * _INSERT_TAIL			-	-	+	+
+ * _CONCAT			-	-	+	+
+ * _REMOVE_AFTER		+	-	+	-
+ * _REMOVE_HEAD			+	-	+	-
+ * _REMOVE			+	+	+	+
+ * _SWAP			+	+	+	+
+ *
+ */
+
+/*
+ * Singly-linked List declarations.
+ */
+#define	XEN_SLIST_HEAD(name, type)					\
+struct name {								\
+	type *slh_first;	/* first element */			\
+}
+
+#define	XEN_SLIST_HEAD_INITIALIZER(head)				\
+	{ 0 }
+
+#define	XEN_SLIST_ENTRY(type)						\
+struct {								\
+	type *sle_next;	/* next element */				\
+}
+
+/*
+ * Singly-linked List functions.
+ */
+#define	XEN_SLIST_EMPTY(head)	((head)->slh_first == 0)
+
+#define	XEN_SLIST_FIRST(head)	((head)->slh_first)
+
+#define	XEN_SLIST_FOREACH(var, head, field)				\
+	for ((var) = XEN_SLIST_FIRST((head));				\
+	    (var);							\
+	    (var) = XEN_SLIST_NEXT((var), field))
+
+#define	XEN_SLIST_FOREACH_SAFE(var, head, field, tvar)			\
+	for ((var) = XEN_SLIST_FIRST((head));				\
+	    (var) && ((tvar) = XEN_SLIST_NEXT((var), field), 1);	\
+	    (var) = (tvar))
+
+#define	XEN_SLIST_FOREACH_PREVPTR(var, varp, head, field)		\
+	for ((varp) = &XEN_SLIST_FIRST((head));				\
+	    ((var) = *(varp)) != 0;					\
+	    (varp) = &XEN_SLIST_NEXT((var), field))
+
+#define	XEN_SLIST_INIT(head) do {					\
+	XEN_SLIST_FIRST((head)) = 0;					\
+} while (0)
+
+#define	XEN_SLIST_INSERT_AFTER(slistelm, elm, field) do {		\
+	XEN_SLIST_NEXT((elm), field) = XEN_SLIST_NEXT((slistelm), field);\
+	XEN_SLIST_NEXT((slistelm), field) = (elm);			\
+} while (0)
+
+#define	XEN_SLIST_INSERT_HEAD(head, elm, field) do {			\
+	XEN_SLIST_NEXT((elm), field) = XEN_SLIST_FIRST((head));		\
+	XEN_SLIST_FIRST((head)) = (elm);				\
+} while (0)
+
+#define	XEN_SLIST_NEXT(elm, field)	((elm)->field.sle_next)
+
+#define	XEN_SLIST_REMOVE(head, elm, type, field) do {			\
+	if (XEN_SLIST_FIRST((head)) == (elm)) {				\
+		XEN_SLIST_REMOVE_HEAD((head), field);			\
+	}								\
+	else {								\
+		type *curelm = XEN_SLIST_FIRST((head));			\
+		while (XEN_SLIST_NEXT(curelm, field) != (elm))		\
+			curelm = XEN_SLIST_NEXT(curelm, field);		\
+		XEN_SLIST_REMOVE_AFTER(curelm, field);			\
+	}								\
+} while (0)
+
+#define XEN_SLIST_REMOVE_AFTER(elm, field) do {				\
+	XEN_SLIST_NEXT(elm, field) =					\
+	    XEN_SLIST_NEXT(XEN_SLIST_NEXT(elm, field), field);		\
+} while (0)
+
+#define	XEN_SLIST_REMOVE_HEAD(head, field) do {				\
+	XEN_SLIST_FIRST((head)) = XEN_SLIST_NEXT(XEN_SLIST_FIRST((head)), field);\
+} while (0)
+
+#define XEN_SLIST_SWAP(head1, head2, type) do {				\
+	type *swap_first = XEN_SLIST_FIRST(head1);			\
+	XEN_SLIST_FIRST(head1) = XEN_SLIST_FIRST(head2);		\
+	XEN_SLIST_FIRST(head2) = swap_first;				\
+} while (0)
+
+/*
+ * Singly-linked Tail queue declarations.
+ */
+#define	XEN_STAILQ_HEAD(name, type)					\
+struct name {								\
+	type *stqh_first;/* first element */				\
+	type **stqh_last;/* addr of last next element */		\
+}
+
+#define	XEN_STAILQ_HEAD_INITIALIZER(head)				\
+	{ 0, &(head).stqh_first }
+
+#define	XEN_STAILQ_ENTRY(type)						\
+struct {								\
+	type *stqe_next;	/* next element */			\
+}
+
+/*
+ * Singly-linked Tail queue functions.
+ */
+#define	XEN_STAILQ_CONCAT(head1, head2) do {				\
+	if (!XEN_STAILQ_EMPTY((head2))) {				\
+		*(head1)->stqh_last = (head2)->stqh_first;		\
+		(head1)->stqh_last = (head2)->stqh_last;		\
+		XEN_STAILQ_INIT((head2));				\
+	}								\
+} while (0)
+
+#define	XEN_STAILQ_EMPTY(head)	((head)->stqh_first == 0)
+
+#define	XEN_STAILQ_FIRST(head)	((head)->stqh_first)
+
+#define	XEN_STAILQ_FOREACH(var, head, field)				\
+	for((var) = XEN_STAILQ_FIRST((head));				\
+	   (var);							\
+	   (var) = XEN_STAILQ_NEXT((var), field))
+
+
+#define	XEN_STAILQ_FOREACH_SAFE(var, head, field, tvar)			\
+	for ((var) = XEN_STAILQ_FIRST((head));				\
+	    (var) && ((tvar) = XEN_STAILQ_NEXT((var), field), 1);	\
+	    (var) = (tvar))
+
+#define	XEN_STAILQ_INIT(head) do {					\
+	XEN_STAILQ_FIRST((head)) = 0;					\
+	(head)->stqh_last = &XEN_STAILQ_FIRST((head));			\
+} while (0)
+
+#define	XEN_STAILQ_INSERT_AFTER(head, tqelm, elm, field) do {		\
+	if ((XEN_STAILQ_NEXT((elm), field) = XEN_STAILQ_NEXT((tqelm), field)) == 0)\
+		(head)->stqh_last = &XEN_STAILQ_NEXT((elm), field);	\
+	XEN_STAILQ_NEXT((tqelm), field) = (elm);			\
+} while (0)
+
+#define	XEN_STAILQ_INSERT_HEAD(head, elm, field) do {			\
+	if ((XEN_STAILQ_NEXT((elm), field) = XEN_STAILQ_FIRST((head))) == 0)\
+		(head)->stqh_last = &XEN_STAILQ_NEXT((elm), field);	\
+	XEN_STAILQ_FIRST((head)) = (elm);				\
+} while (0)
+
+#define	XEN_STAILQ_INSERT_TAIL(head, elm, field) do {			\
+	XEN_STAILQ_NEXT((elm), field) = 0;				\
+	*(head)->stqh_last = (elm);					\
+	(head)->stqh_last = &XEN_STAILQ_NEXT((elm), field);		\
+} while (0)
+
+#define	XEN_STAILQ_LAST(head, type, field)				\
+	(XEN_STAILQ_EMPTY((head)) ?					\
+		0 :							\
+	        ((type *)(void *)					\
+		((char *)((head)->stqh_last) - offsetof(type, field))))
+
+#define	XEN_STAILQ_NEXT(elm, field)	((elm)->field.stqe_next)
+
+#define	XEN_STAILQ_REMOVE(head, elm, type, field) do {			\
+	if (XEN_STAILQ_FIRST((head)) == (elm)) {			\
+		XEN_STAILQ_REMOVE_HEAD((head), field);			\
+	}								\
+	else {								\
+		type *curelm = XEN_STAILQ_FIRST((head));		\
+		while (XEN_STAILQ_NEXT(curelm, field) != (elm))		\
+			curelm = XEN_STAILQ_NEXT(curelm, field);	\
+		XEN_STAILQ_REMOVE_AFTER(head, curelm, field);		\
+	}								\
+} while (0)
+
+#define XEN_STAILQ_REMOVE_AFTER(head, elm, field) do {			\
+	if ((XEN_STAILQ_NEXT(elm, field) =				\
+	     XEN_STAILQ_NEXT(XEN_STAILQ_NEXT(elm, field), field)) == 0)	\
+		(head)->stqh_last = &XEN_STAILQ_NEXT((elm), field);	\
+} while (0)
+
+#define	XEN_STAILQ_REMOVE_HEAD(head, field) do {			\
+	if ((XEN_STAILQ_FIRST((head)) =					\
+	     XEN_STAILQ_NEXT(XEN_STAILQ_FIRST((head)), field)) == 0)	\
+		(head)->stqh_last = &XEN_STAILQ_FIRST((head));		\
+} while (0)
+
+#define XEN_STAILQ_SWAP(head1, head2, type) do {			\
+	type *swap_first = XEN_STAILQ_FIRST(head1);			\
+	type **swap_last = (head1)->stqh_last;				\
+	XEN_STAILQ_FIRST(head1) = XEN_STAILQ_FIRST(head2);		\
+	(head1)->stqh_last = (head2)->stqh_last;			\
+	XEN_STAILQ_FIRST(head2) = swap_first;				\
+	(head2)->stqh_last = swap_last;					\
+	if (XEN_STAILQ_EMPTY(head1))					\
+		(head1)->stqh_last = &XEN_STAILQ_FIRST(head1);		\
+	if (XEN_STAILQ_EMPTY(head2))					\
+		(head2)->stqh_last = &XEN_STAILQ_FIRST(head2);		\
+} while (0)
+
+
+/*
+ * List declarations.
+ */
+#define	XEN_LIST_HEAD(name, type)					\
+struct name {								\
+	type *lh_first;	/* first element */				\
+}
+
+#define	XEN_LIST_HEAD_INITIALIZER(head)					\
+	{ 0 }
+
+#define	XEN_LIST_ENTRY(type)						\
+struct {								\
+	type *le_next;	/* next element */				\
+	type **le_prev;	/* address of previous next element */		\
+}
+
+/*
+ * List functions.
+ */
+
+#define	XEN_LIST_EMPTY(head)	((head)->lh_first == 0)
+
+#define	XEN_LIST_FIRST(head)	((head)->lh_first)
+
+#define	XEN_LIST_FOREACH(var, head, field)				\
+	for ((var) = XEN_LIST_FIRST((head));				\
+	    (var);							\
+	    (var) = XEN_LIST_NEXT((var), field))
+
+#define	XEN_LIST_FOREACH_SAFE(var, head, field, tvar)			\
+	for ((var) = XEN_LIST_FIRST((head));				\
+	    (var) && ((tvar) = XEN_LIST_NEXT((var), field), 1);		\
+	    (var) = (tvar))
+
+#define	XEN_LIST_INIT(head) do {					\
+	XEN_LIST_FIRST((head)) = 0;					\
+} while (0)
+
+#define	XEN_LIST_INSERT_AFTER(listelm, elm, field) do {			\
+	if ((XEN_LIST_NEXT((elm), field) = XEN_LIST_NEXT((listelm), field)) != 0)\
+		XEN_LIST_NEXT((listelm), field)->field.le_prev =	\
+		    &XEN_LIST_NEXT((elm), field);			\
+	XEN_LIST_NEXT((listelm), field) = (elm);			\
+	(elm)->field.le_prev = &XEN_LIST_NEXT((listelm), field);	\
+} while (0)
+
+#define	XEN_LIST_INSERT_BEFORE(listelm, elm, field) do {		\
+	(elm)->field.le_prev = (listelm)->field.le_prev;		\
+	XEN_LIST_NEXT((elm), field) = (listelm);			\
+	*(listelm)->field.le_prev = (elm);				\
+	(listelm)->field.le_prev = &XEN_LIST_NEXT((elm), field);	\
+} while (0)
+
+#define	XEN_LIST_INSERT_HEAD(head, elm, field) do {			\
+	if ((XEN_LIST_NEXT((elm), field) = XEN_LIST_FIRST((head))) != 0)\
+		XEN_LIST_FIRST((head))->field.le_prev = &XEN_LIST_NEXT((elm), field);\
+	XEN_LIST_FIRST((head)) = (elm);					\
+	(elm)->field.le_prev = &XEN_LIST_FIRST((head));			\
+} while (0)
+
+#define	XEN_LIST_NEXT(elm, field)	((elm)->field.le_next)
+
+#define	XEN_LIST_REMOVE(elm, field) do {				\
+	if (XEN_LIST_NEXT((elm), field) != 0)				\
+		XEN_LIST_NEXT((elm), field)->field.le_prev =		\
+		    (elm)->field.le_prev;				\
+	*(elm)->field.le_prev = XEN_LIST_NEXT((elm), field);		\
+} while (0)
+
+#define XEN_LIST_SWAP(head1, head2, type, field) do {			\
+	type *swap_tmp = XEN_LIST_FIRST((head1));			\
+	XEN_LIST_FIRST((head1)) = XEN_LIST_FIRST((head2));		\
+	XEN_LIST_FIRST((head2)) = swap_tmp;				\
+	if ((swap_tmp = XEN_LIST_FIRST((head1))) != 0)			\
+		swap_tmp->field.le_prev = &XEN_LIST_FIRST((head1));	\
+	if ((swap_tmp = XEN_LIST_FIRST((head2))) != 0)			\
+		swap_tmp->field.le_prev = &XEN_LIST_FIRST((head2));	\
+} while (0)
+
+/*
+ * Tail queue declarations.
+ */
+#define	XEN_TAILQ_HEAD(name, type)					\
+struct name {								\
+	type *tqh_first;	/* first element */			\
+	type **tqh_last;	/* addr of last next element */		\
+}
+
+#define	XEN_TAILQ_HEAD_INITIALIZER(head)				\
+	{ 0, &(head).tqh_first }
+
+#define	XEN_TAILQ_ENTRY(type)						\
+struct {								\
+	type *tqe_next;	/* next element */				\
+	type **tqe_prev;	/* address of previous next element */	\
+}
+
+/*
+ * Tail queue functions.
+ */
+
+#define	XEN_TAILQ_CONCAT(head1, head2, field) do {			\
+	if (!XEN_TAILQ_EMPTY(head2)) {					\
+		*(head1)->tqh_last = (head2)->tqh_first;		\
+		(head2)->tqh_first->field.tqe_prev = (head1)->tqh_last;	\
+		(head1)->tqh_last = (head2)->tqh_last;			\
+		XEN_TAILQ_INIT((head2));				\
+	}								\
+} while (0)
+
+#define	XEN_TAILQ_EMPTY(head)	((head)->tqh_first == 0)
+
+#define	XEN_TAILQ_FIRST(head)	((head)->tqh_first)
+
+#define	XEN_TAILQ_FOREACH(var, head, field)				\
+	for ((var) = XEN_TAILQ_FIRST((head));				\
+	    (var);							\
+	    (var) = XEN_TAILQ_NEXT((var), field))
+
+#define	XEN_TAILQ_FOREACH_SAFE(var, head, field, tvar)			\
+	for ((var) = XEN_TAILQ_FIRST((head));				\
+	    (var) && ((tvar) = XEN_TAILQ_NEXT((var), field), 1);	\
+	    (var) = (tvar))
+
+#define	XEN_TAILQ_FOREACH_REVERSE(var, head, headname, field)		\
+	for ((var) = XEN_TAILQ_LAST((head), headname);			\
+	    (var);							\
+	    (var) = XEN_TAILQ_PREV((var), headname, field))
+
+#define	XEN_TAILQ_FOREACH_REVERSE_SAFE(var, head, headname, field, tvar)	\
+	for ((var) = XEN_TAILQ_LAST((head), headname);			\
+	    (var) && ((tvar) = XEN_TAILQ_PREV((var), headname, field), 1);\
+	    (var) = (tvar))
+
+#define	XEN_TAILQ_INIT(head) do {					\
+	XEN_TAILQ_FIRST((head)) = 0;					\
+	(head)->tqh_last = &XEN_TAILQ_FIRST((head));			\
+} while (0)
+
+#define	XEN_TAILQ_INSERT_AFTER(head, listelm, elm, field) do {		\
+	if ((XEN_TAILQ_NEXT((elm), field) = XEN_TAILQ_NEXT((listelm), field)) != 0)\
+		XEN_TAILQ_NEXT((elm), field)->field.tqe_prev =		\
+		    &XEN_TAILQ_NEXT((elm), field);			\
+	else {								\
+		(head)->tqh_last = &XEN_TAILQ_NEXT((elm), field);	\
+	}								\
+	XEN_TAILQ_NEXT((listelm), field) = (elm);			\
+	(elm)->field.tqe_prev = &XEN_TAILQ_NEXT((listelm), field);	\
+} while (0)
+
+#define	XEN_TAILQ_INSERT_BEFORE(listelm, elm, field) do {		\
+	(elm)->field.tqe_prev = (listelm)->field.tqe_prev;		\
+	XEN_TAILQ_NEXT((elm), field) = (listelm);			\
+	*(listelm)->field.tqe_prev = (elm);				\
+	(listelm)->field.tqe_prev = &XEN_TAILQ_NEXT((elm), field);	\
+} while (0)
+
+#define	XEN_TAILQ_INSERT_HEAD(head, elm, field) do {			\
+	if ((XEN_TAILQ_NEXT((elm), field) = XEN_TAILQ_FIRST((head))) != 0)\
+		XEN_TAILQ_FIRST((head))->field.tqe_prev =		\
+		    &XEN_TAILQ_NEXT((elm), field);			\
+	else								\
+		(head)->tqh_last = &XEN_TAILQ_NEXT((elm), field);	\
+	XEN_TAILQ_FIRST((head)) = (elm);				\
+	(elm)->field.tqe_prev = &XEN_TAILQ_FIRST((head));		\
+} while (0)
+
+#define	XEN_TAILQ_INSERT_TAIL(head, elm, field) do {			\
+	XEN_TAILQ_NEXT((elm), field) = 0;				\
+	(elm)->field.tqe_prev = (head)->tqh_last;			\
+	*(head)->tqh_last = (elm);					\
+	(head)->tqh_last = &XEN_TAILQ_NEXT((elm), field);		\
+} while (0)
+
+#define	XEN_TAILQ_LAST(head, headname)					\
+	(*(((struct headname *)((head)->tqh_last))->tqh_last))
+
+#define	XEN_TAILQ_NEXT(elm, field) ((elm)->field.tqe_next)
+
+#define	XEN_TAILQ_PREV(elm, headname, field)				\
+	(*(((struct headname *)((elm)->field.tqe_prev))->tqh_last))
+
+#define	XEN_TAILQ_REMOVE(head, elm, field) do {				\
+	if ((XEN_TAILQ_NEXT((elm), field)) != 0)			\
+		XEN_TAILQ_NEXT((elm), field)->field.tqe_prev =		\
+		    (elm)->field.tqe_prev;				\
+	else {								\
+		(head)->tqh_last = (elm)->field.tqe_prev;		\
+	}								\
+	*(elm)->field.tqe_prev = XEN_TAILQ_NEXT((elm), field);		\
+} while (0)
+
+#define XEN_TAILQ_SWAP(head1, head2, type, field) do {			\
+	type *swap_first = (head1)->tqh_first;				\
+	type **swap_last = (head1)->tqh_last;				\
+	(head1)->tqh_first = (head2)->tqh_first;			\
+	(head1)->tqh_last = (head2)->tqh_last;				\
+	(head2)->tqh_first = swap_first;				\
+	(head2)->tqh_last = swap_last;					\
+	if ((swap_first = (head1)->tqh_first) != 0)			\
+		swap_first->field.tqe_prev = &(head1)->tqh_first;	\
+	else								\
+		(head1)->tqh_last = &(head1)->tqh_first;		\
+	if ((swap_first = (head2)->tqh_first) != 0)			\
+		swap_first->field.tqe_prev = &(head2)->tqh_first;	\
+	else								\
+		(head2)->tqh_last = &(head2)->tqh_first;		\
+} while (0)
+
+#endif /* !XEN__SYS_QUEUE_H_ */
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Tue Feb 08 07:16:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 07:16:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267589.461343 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHKjo-0004LQ-IK; Tue, 08 Feb 2022 07:16:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267589.461343; Tue, 08 Feb 2022 07:16:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHKjo-0004LJ-F4; Tue, 08 Feb 2022 07:16:32 +0000
Received: by outflank-mailman (input) for mailman id 267589;
 Tue, 08 Feb 2022 07:16:30 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=co3W=SX=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nHKjm-0004LD-Hk
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 07:16:30 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 08945fd5-88af-11ec-8eb8-a37418f5ba1a;
 Tue, 08 Feb 2022 08:16:28 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 680761F37C;
 Tue,  8 Feb 2022 07:16:28 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 24FB413483;
 Tue,  8 Feb 2022 07:16:28 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id rOylB8wYAmLrIQAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 08 Feb 2022 07:16:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 08945fd5-88af-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1644304588; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=h1Aps2fmeF2kXxgGc60gFYOcm/Eewiu7EEHlr6uHJUk=;
	b=CocLRIu/V9JZpqquPeYXvGD2g8uE3wBxK+6yZ5qbY+49w4jc7IwgydQex0DkMcTONoDTBU
	xdNn6xDyxOglkwUPsBYS4t8rcCCqgptpADAlTkhi4rTVI0d0GNLV3iC2+7Fju1mrr8VX+8
	nHacG/jYieGP48zSZOjzB0rpHzOyjp0=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>,
	Julien Grall <jgrall@amazon.com>
Subject: [PATCH v3] docs: document patch rules
Date: Tue,  8 Feb 2022 08:16:26 +0100
Message-Id: <20220208071626.6594-1-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Add a document to describe the rules for sending a proper patch.

As it contains all the information already being present in
docs/process/tags.pandoc remove that file.

The "Reviewed-by:" and "Acked-by:" tags are expanded to allow an
optional restriction of the tag.

A new tag "Origin:" is added to tag patches taken from another project.

Signed-off-by: Juergen Gross <jgross@suse.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Julien Grall <jgrall@amazon.com>
---
v3:
- add note regarding commit id length for Origin: (Julien Grall)
v2:
- expanded commit message (Roger Pau Monné)
- some rewordings (Roger Pau Monné, Jan Beulich)
- add "Requested-by:" description (Jan Beulich)
- rename "Taken-from:" to "Origin:" (Jan Beulich)
- add reviewers as recipients of patch (Jan Beulich)
- style fixes (Roger Pau Monné, Jan Beulich)
---
 docs/process/sending-patches.pandoc | 300 ++++++++++++++++++++++++++++
 docs/process/tags.pandoc            |  55 -----
 2 files changed, 300 insertions(+), 55 deletions(-)
 create mode 100644 docs/process/sending-patches.pandoc
 delete mode 100644 docs/process/tags.pandoc

diff --git a/docs/process/sending-patches.pandoc b/docs/process/sending-patches.pandoc
new file mode 100644
index 0000000000..7ff7826c99
--- /dev/null
+++ b/docs/process/sending-patches.pandoc
@@ -0,0 +1,300 @@
+# How a proper patch should look like
+
+This is a brief description how a proper patch for the Xen project should
+look like. Examples and tooling tips are not part of this document, those
+can be found in the
+[Xen Wiki](https://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches).
+
+## The patch subject
+
+The first line at the top of the patch should contain a short description of
+what the patch does, and hints as to what code it touches. This line is used
+as the **Subject** line of the mail when sending the patch.
+
+The hint which code is touched is usually in form of an abstract entity
+(like e.g. `build` for the build system), or a component (like `tools` or
+`iommu`). Further specification is possible via adding a sub-component with
+a slash (e.g. `tools/xenstore`):
+
+    <component>: <description>
+
+E.g.:
+
+    xen/arm: increase memory banks number define value
+    tools/libxenevtchn: deduplicate xenevtchn_fd()
+    MAINTAINERS: update my email address
+    build: correct usage comments in Kbuild.include
+
+The description should give a rough hint *what* is done in the patch.
+
+The subject line should in general not exceed 80 characters. It must be
+followed by a blank line.
+
+## The commit message
+
+The commit message is free text describing *why* the patch is done and
+*how* the goal of the patch is achieved. A good commit message will describe
+the current situation, the desired goal, and the way this goal is being
+achieved. Parts of that can be omitted in obvious cases.
+
+In case additional changes are done in the patch (like e.g. cleanups), those
+should be mentioned.
+
+When referencing other patches (e.g. `similar to patch xy ...`) those
+patches should be referenced via their commit id (at least 12 digits)
+and the patch subject, if the very same patch isn't referenced by the
+`Fixes:` tag, too:
+
+    Similar to commit 67d01cdb5518 ("x86: infrastructure to allow converting
+    certain indirect calls to direct ones") add ...
+
+The following ``git config`` settings can be used to add a pretty format for
+outputting the above style in the ``git log`` or ``git show`` commands:
+
+        [core]
+                abbrev = 12
+        [pretty]
+                fixes = Fixes: %h (\"%s\")
+
+Lines in the commit message should not exceed 75 characters, except when
+copying error output directly into the commit message.
+
+## Tags
+
+Tags are entries in the form
+
+    Tag: something
+
+In general tags are added in chronological order. So a `Reviewed-by:` tag
+should be added **after** the `Signed-off-by:` tag, as the review happened
+after the patch was written.
+
+Do not split a tag across multiple lines, tags are exempt from the
+"wrap at 75 columns" rule in order to simplify parsing scripts.
+
+### Origin:
+
+Xen has inherited some source files from other open source projects. In case
+a patch modifying such an inherited file is taken from that project (maybe in
+modified form), the `Origin:` tag specifies the source of the patch:
+
+    Origin: <repository-URL> <commit-id>
+
+E.g.:
+
+    Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git f093b08c47b3
+
+The commit id should be shortened to its first 12 characters.
+
+All tags **above** the `Origin:` tag are from the original patch (which
+should all be kept), while tags **after** `Origin:` are related to the
+normal Xen patch process as described here.
+
+### Fixes:
+
+If your patch fixes a bug in a specific commit, e.g. you found an issue using
+``git bisect``, please use the `Fixes:` tag with the first 12 characters of
+the commit id, and the one line summary.
+
+    Fixes: <commit-id> ("<patch-subject>")
+
+E.g.:
+
+    Fixes: 67d01cdb5518 ("x86: infrastructure to allow converting certain indirect calls to direct ones")
+
+### Backport:
+
+A backport tag is an optional tag in the commit message to request a
+given commit to be backported to the released trees:
+
+    Backport: <version> [# <comment>]
+
+E.g.:
+
+    Backport: 4.9+
+
+It marks a commit for being a candidate for backports to all released
+trees from 4.9 onward.
+
+The backport requester is expected to specify which currently supported
+releases need the backport; but encouraged to specify a release as far
+back as possible which applies. If the requester doesn't know the oldest
+affected tree, they are encouraged to append a comment like the
+following:
+
+    Backport: 4.9+ # maybe older
+
+Maintainers request the Backport tag to be added on commit. Contributors
+are welcome to mark their patches with the Backport tag when they deem
+appropriate. Maintainers will request for it to be removed when that is
+not the case.
+
+Please note that the Backport tag is a **request** for backport, which
+will still need to be evaluated by the maintainers. Maintainers might
+ask the requester to help with the backporting work if it is not
+trivial.
+
+### Reported-by:
+
+This optional tag can be used to give credit to someone reporting an issue.
+It is in the format:
+
+    Reported-by: name <email@domain>
+
+E.g.:
+
+    Reported-by: Jane Doe <jane.doe@example.org>
+
+As the email address will be made public via git, the reporter of an issue
+should be asked whether he/she is fine with being mentioned in the patch.
+
+### Suggested-by:
+
+This optional tag can be used to give credit to someone having suggested the
+solution the patch is implementing. It is in the format:
+
+    Suggested-by: name <email@domain>
+
+E.g.:
+
+    Suggested-by: Jane Doe <jane.doe@example.org>
+
+As the email address will be made public via git, the reporter of an issue
+should be asked whether he/she is fine with being mentioned in the patch.
+
+### Requested-by:
+
+This tag is very similar to the `Suggested-by:` tag, but it refers to an
+explicit request to add the patch. It is in the format:
+
+    Requested-by: name <email@domain>
+
+E.g.:
+
+    Requested-by: Jane Doe <jane.doe@example.org>
+
+### Signed-off-by:
+
+This mandatory tag specifies the author(s) of a patch (for each author a
+separate `Signed-off-by:` tag is needed). It is in the format:
+
+    Signed-off-by: name <email@domain>
+
+E.g.:
+
+    Signed-off-by: Jane Doe <jane.doe@example.org>
+
+The author must be a natural person (not a team or just a company) and the
+`Signed-off-by:` tag must include the real name of the author (no pseudonym).
+
+By signing the patch with her/his name the author explicitly confirms to have
+made the contribution conforming to the `Developer's Certificate of Origin`:
+
+    Developer's Certificate of Origin 1.1
+    
+    By making a contribution to this project, I certify that:
+    
+    (a) The contribution was created in whole or in part by me and I
+        have the right to submit it under the open source license
+        indicated in the file; or
+    
+    (b) The contribution is based upon previous work that, to the best
+        of my knowledge, is covered under an appropriate open source
+        license and I have the right under that license to submit that
+        work with modifications, whether created in whole or in part
+        by me, under the same open source license (unless I am
+        permitted to submit under a different license), as indicated
+        in the file; or
+    
+    (c) The contribution was provided directly to me by some other
+        person who certified (a), (b) or (c) and I have not modified
+        it.
+    
+    (d) I understand and agree that this project and the contribution
+        are public and that a record of the contribution (including all
+        personal information I submit with it, including my sign-off) is
+        maintained indefinitely and may be redistributed consistent with
+        this project or the open source license(s) involved.
+
+### Reviewed-by:
+
+A `Reviewed-by:` tag can only be given by a reviewer of the patch. With
+responding to a sent patch adding the `Reviewed-by:` tag the reviewer
+(which can be anybody) confirms to have looked thoroughly at the patch and
+didn't find any issue (being it technical, legal or formal ones). If the
+review is covering only some parts of the patch, those parts can optionally
+be specified (multiple areas can be either separated by commas, or be covered
+with multiple `Reviewed-by:` tags). It is in the format:
+
+    Reviewed-by: name <email@domain> [# area[, area]]
+
+E.g.:
+
+    Reviewed-by: Jane Doe <jane.doe@example.org>
+    Reviewed-by: Jane Doe <jane.doe@example.org> # xen/x86
+
+In case a patch is being resent an already given `Reviewed-by:` tag can and
+should be included, if the patch didn't meaningfully change the portions of the
+patch covered by the tag, or if the reviewer already made clear it would be
+fine to make specific changes and no *other* changes have been made.
+
+### Acked-by:
+
+Similar to `Reviewed-by:` the `Acked-by:` tag is given by someone having looked
+at the patch. The `Acked-by:` tag can only be given by a **maintainer** of the
+modified code, and it only covers the code the maintainer is responsible for.
+With the `Acked-by:` tag the maintainer states, that he/she is fine with the
+changes in principle, but didn't do a thorough review. The format is:
+
+    Acked-by: name <email@domain> [# area[, area]]
+
+E.g.:
+
+    Acked-by: Jane Doe <jane.doe@example.org>
+
+Including the `Acked-by:` tag in a patch is done under the same rules as for
+the `Reviewed-by:` tag, with the implied code area the maintainer who gave the
+`Acked-by:` tag is responsible for (if no area was specified with the tag).
+
+### Tested-by:
+
+The `Tested-by:` tag is another tag given by someone else. The one giving it
+confirms to have tested the patch without finding any functional issues. The
+format is:
+
+    Tested-by: name <email@domain>
+
+E.g.:
+
+    Tested-by: Jane Doe <jane.doe@example.org>
+
+Including the `Tested-by:` tag in a patch is done under the same rules as for
+the `Reviewed-by:` tag, now limited to the patch not having been modified
+regarding code logic (having changed only coding style, comments, or message
+texts is fine).
+
+## Patch version history (change log), further comments
+
+When sending revised versions of a patch it is good practice to include a
+change log after a line containing only `---` (this line will result in the
+following text not being included in the commit message). This change log
+will help reviewers to spot which parts of the patch have changed. Attributing
+changes due to reviewer comments will help the reviewer even more, e.g.:
+
+    ---
+    Changes in v2:
+    - changed function foo() as requested by Jane Doe
+    - code style fixed
+
+In some cases it might be desirable to add some more information for readers
+of the patch, like potential enhancements, other possible solutions, etc.,
+which should not be part of the commit message. This information can be
+added after the `---` line, too.
+
+## Recipients of the patch
+
+A patch should always be sent **to** the xen-devel mailing list
+<xen-devel@lists.xenproject.org> and all maintainers and designated reviewers
+of all touched code areas should get a copy of the mail via **Cc**. In case
+some other recipients are known to be interested in the patch, they can be
+added via **Cc**, too.
diff --git a/docs/process/tags.pandoc b/docs/process/tags.pandoc
deleted file mode 100644
index 1841cb87a8..0000000000
--- a/docs/process/tags.pandoc
+++ /dev/null
@@ -1,55 +0,0 @@
-Tags: No line splitting
------------------------
-Do not split a tag across multiple lines, tags are exempt from the
-"wrap at 75 columns" rule in order to simplify parsing scripts.  For
-example:
-
-        Fixes: 67d01cdb5518 ("x86: infrastructure to allow converting certain indirect calls to direct ones")
-
-
-Fixes Tag
----------
-
-If your patch fixes a bug in a specific commit, e.g. you found an issue using
-``git bisect``, please use the 'Fixes:' tag with the first 12 characters of
-the SHA-1 ID, and the one line summary.
-
-The following ``git config`` settings can be used to add a pretty format for
-outputting the above style in the ``git log`` or ``git show`` commands:
-
-        [core]
-                abbrev = 12
-        [pretty]
-                fixes = Fixes: %h (\"%s\")
-
-
-Backport Tag
-------------
-
-A backport tag is an optional tag in the commit message to request a
-given commit to be backported to the released trees:
-
-    Backport: 4.9+
-
-It marks a commit for being a candidate for backports to all released
-trees from 4.9 onward.
-
-The backport requester is expected to specify which currently supported
-releases need the backport; but encouraged to specify a release as far
-back as possible which applies. If the requester doesn't know the oldest
-affected tree, they are encouraged to append a comment like the
-following:
-
-    Backport: 4.9+ # maybe older
-
-Maintainers request the Backport tag to be added on commit. Contributors
-are welcome to mark their patches with the Backport tag when they deem
-appropriate. Maintainers will request for it to be removed when that is
-not the case.
-
-Please note that the Backport tag is a **request** for backport, which
-will still need to be evaluated by the maintainers. Maintainers might
-ask the requester to help with the backporting work if it is not
-trivial.
-
-When possible, please use the Fixes tag instead (or in addition).
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Tue Feb 08 07:36:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 07:36:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267608.461354 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHL2X-0006ln-5v; Tue, 08 Feb 2022 07:35:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267608.461354; Tue, 08 Feb 2022 07:35:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHL2X-0006lg-2b; Tue, 08 Feb 2022 07:35:53 +0000
Received: by outflank-mailman (input) for mailman id 267608;
 Tue, 08 Feb 2022 07:35:52 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1FiY=SX=epam.com=prvs=40383cc40e=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nHL2W-0006la-3p
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 07:35:52 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id bbe3553e-88b1-11ec-8eb8-a37418f5ba1a;
 Tue, 08 Feb 2022 08:35:49 +0100 (CET)
Received: from pps.filterd (m0174681.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 2185hYvW027891;
 Tue, 8 Feb 2022 07:35:43 GMT
Received: from eur01-he1-obe.outbound.protection.outlook.com
 (mail-he1eur01lp2056.outbound.protection.outlook.com [104.47.0.56])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3e3j920d7a-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Tue, 08 Feb 2022 07:35:41 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by PA4PR03MB7101.eurprd03.prod.outlook.com (2603:10a6:102:eb::9) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Tue, 8 Feb
 2022 07:35:34 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77%3]) with mapi id 15.20.4951.019; Tue, 8 Feb 2022
 07:35:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bbe3553e-88b1-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Hvnnp+L4K/qFR7pncIsp8AUH9T+wNVdBAbwwdgB7KLGQN8zGvtx1yuV4JvYjYj7mhs/zaEXDxn0wzbKRR/LYHz34SWjRZ2TjuNnsKNO7WOqPmPPcL+HvSuWhbG3I//93JA+cmPEF9AiJidvUgNrKkYQK8kT9rFVlOGWA+LMy93x5KVadTMzzrPAJq8CK/7Wsiov5WNNmFM3SZkmPeDJdPx5XxsQVrB4/nm2cSEotDY0KdgYoCuNCner0d+31sbZtJQsq8mZgxMwxP9i1pyx9+2SBjWMWfy2Nw1BtpIiFkuckUicyOHXO+RKt9V0cFnOjmoXXy3yMuomJh5SWOcAJ2Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Pn9nzzHmCPMZQ330jOvkVVzAhCffJTjMHNM9mARK4fM=;
 b=XFyUYvZVTxzc3Q0Hog8iRYpG+QaA4p9ba3uYsPvqxNCWU1AGka9MCDCqB6ajv5m23u9BCsD/6NS4+TUHtHmGL9pgZ0vbJUX2sodW+lHqocmYV9upKxb71WvSfDu2FPpHBU4TyKeBimLdIXbDbSi2tWtDb9h5gTV17I+fSN3MMTuS5Z2RTxR6SNIqpWDYNkAZxTrULlLY4fOB96P4LzhXlVnZB0gV9WA3lqsg3tuC02T6gyHIEqagACmFwvxWWsnpoIjN2oVBIKMX5UoNlP8v7rCeEKPlc6OnT+Z58TJ6mgg84+elBCVf/DW5U3tR70o0umFFYi0fWhaYOBWLRYrBvA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Pn9nzzHmCPMZQ330jOvkVVzAhCffJTjMHNM9mARK4fM=;
 b=JLWL8pprazAqmvxhG9/Bp5K1O5m6fPDrYCiZDtvWHPig/k2Qh9XVZQuURNUu6tPwQibn7BtDfO9DvcNx0iddfUG8t7MDjnLtFaD0y7k1UbZratjOSmwsCxo2DlA9skvY7oPzCNqJl5sBTEi2n2D7fdt8iTn2P3rdi4+YaQXY3xcuGFyCln3L1BHS2yA+V43yz5wbKJpAzPf7Rz+Hyu9sBflZ2ZjKoAbdzo1ULuokq/ix9YXlZ8yxtt2YnqCHWvboj7eBnIi1kJ9uNtzll3kRJf/MJvQ6Hxx/kf7uIxfirlz4+VvXiHCypwMyf3CgYhs1aNdA2HyHSNMGtdj3N+7P7A==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>,
        =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?=
	<roger.pau@citrix.com>
CC: "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Thread-Topic: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Thread-Index: 
 AQHYGZFc/MnzQOjwVEeBBUHLSW0md6yDBUkAgAASSACAAATYAIAAD/WAgAAKNgCAAAbfgIAABnuAgAAQvgCAAAMCAIAAAY4AgAADxICAABrnAIAABAgAgAR3CoCAABt5gIAAEpuAgAAE5ICAAASKAIAAAiiAgAAKNYCAAARNAIAAC1wAgAACRYCAAAGVgIAABJiAgAAB5wCAAPjsgA==
Date: Tue, 8 Feb 2022 07:35:34 +0000
Message-ID: <e91965c5-0802-adf8-0c17-522f86ebf231@epam.com>
References: <7e3562b5-fc67-f213-e872-f211450d9e2e@epam.com>
 <a8fc599c-f620-c4d1-2077-c57068f46a7f@suse.com>
 <deef8468-d607-e49e-f456-6a8013329ca1@epam.com>
 <Yf0k6aoKK5G3iad1@Air-de-Roger>
 <3ad10a99-c706-b95f-1419-2c0c7cf37d58@epam.com>
 <Yf0+3C9nF8+tewLw@Air-de-Roger>
 <c5fea3bb-834b-eeb7-d7a1-1ee609037a9f@epam.com>
 <YgEUwTxhnWVMGMJK@Air-de-Roger>
 <9ce90193-74a0-5642-d22b-6b8c3340c3cf@epam.com>
 <1f65ae7a-898d-2c27-0ada-d71d778b0627@suse.com>
 <YgEsRuckQJIQlkzf@Air-de-Roger>
 <a2a42c1d-d379-00cd-5d55-f443cdb02e97@epam.com>
 <e8fc7872-c7d0-f389-c507-335b809ffcbc@epam.com>
 <21c8125a-2f79-1a4a-494c-db9e4be2a1a6@suse.com>
 <4276fe72-558b-7d95-6430-d4330989dbe8@epam.com>
 <ad985f4a-10f0-4a2d-df02-cde915fea3f1@suse.com>
 <f7669670-8eeb-9966-5ba3-e8f9c03ce3d3@epam.com>
 <73e08285-6bb1-5842-899f-bd6502406e49@suse.com>
 <be3f4222-6580-4c89-a202-c003b6feb9b4@epam.com>
In-Reply-To: <be3f4222-6580-4c89-a202-c003b6feb9b4@epam.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: e5a4f32a-0a2a-4c3d-e14d-08d9ead597b7
x-ms-traffictypediagnostic: PA4PR03MB7101:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <PA4PR03MB71015945297DFB2543CB5B97E72D9@PA4PR03MB7101.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 12Bw5VdoT4J4TLCSOU8KqM56qvJ6LXwVYiwxccWNMQ64tsY3+idB6Umhk1cNE3a/GGzdouDpMYvPFUo5rzQTKyUJeSruqCRxaXmO36yH7Wa8Ezt6I/cpgXDSRBa9CkdwE4Gyqmhvh9Q7xVpUdjUZQYrpsEa9q4tIxrwJV1Xif6dPv1Cn521MhXh7Pjb3ckIBm3tlfGBF9+352Vz6IGFnMgu9S9r8fyYJ0/9cMU24xSG4S7dmimtrWuk9Eo3PmuXDR7UtPrFFIOOfsGprYN0Ih6YfavtDM/Q1yUGiMQyd0M5mgm8gYKo32PRNKgtYav0/lt3kTmW3DDjk1eWAsOIpp7HRUPhLQx4S8SZ58clNjUpQKiS2qzMF8bCCnuFvYecHlSW+ED2EsEqaueyj6FmvJ7f+SQnaHEzCb+e4REXsmf/WMp7oL+SktAnJGesqXjzJhKMALrHmwDpAjTuJS9pylDRmHIKTC89PyUy9whz0bQA+uZJQSTbFMCAx0QfwVj+VX9Z0pl6RPjbAa473sKPZAm8VSRBDIglJqNHnr/ek1vvQG6qX2w8ApILoh8CcK0YaPqLsxF2XGJBm6JGHZ8NwuV596VI9EKmMOuRiZI65W3olnd/JUiZhFj6pHh/JBim/lZ8FRmY+1qqf5pN0mopvvI2khawitIu223PkKWONBc3YfpFZotWl8i4/J613zbm35gQA46To1bP31tjffIeXv9K1HBvvTD4ayrwmfMrFWBygyc3sDpTq+6FGWovAQH1Ko5cE0hKEcdkwVVRm6nPxDU34GYw1mlE9a3N5ZIr9MeRdmHiBFGOIBw2pPNuTH5Rz
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38100700002)(66446008)(31686004)(316002)(2616005)(8676002)(66946007)(66556008)(66476007)(76116006)(31696002)(6506007)(91956017)(64756008)(8936002)(4326008)(6512007)(53546011)(71200400001)(110136005)(54906003)(508600001)(7416002)(83380400001)(86362001)(5660300002)(186003)(36756003)(122000001)(26005)(966005)(2906002)(38070700005)(6486002)(55236004)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?RTRienhpaFFTcUJrM3FlWlBmQUh4bjBJUzFES0RRc2JWTFpmamhsOHBVaklr?=
 =?utf-8?B?MjlONTVLMXFQSTZrNWhwRVhFR2FvdE05c2FNWGRVRG1yQUk3WTRVWi93QUVi?=
 =?utf-8?B?OGdPcjgwNS94Q1I0cStEVDQ1U29VS2V3YlZ5a3hGU016dXBVU1lKa1RQU1Ew?=
 =?utf-8?B?YU1vSWtRd201RjYyYy94cXRpTmFPV2x1V2hOOTFsRlFmYnVXQVlYRU9QWVV3?=
 =?utf-8?B?L1V3OXVUSVlEbTl3ZElTM3VGdXVkMmVQeUlxSElmQjUyNmVlOHBHRkdBTWN3?=
 =?utf-8?B?OXJaVkswOWZqMDdiblRab3RjQmdlR0hiVnlOZUY3N2JFWTBOOWFUeEltOWNQ?=
 =?utf-8?B?ZTZEV0ZSU1ZibkM3cGxWRFBMRTlmZC9HTzdGamp1L1ZlQkZ2bmpraWFteDFU?=
 =?utf-8?B?cEpKeDVKM3M0aTFWN0xUb0h1aDlIR3NzQVpucHBVRnZBLzBlQmJZMjY0cFY4?=
 =?utf-8?B?NEFhUUJ0MUhtNGdBLy83WUptaWRRSUxqVktwc1R4bkZ0cmVuZDdINnpqUnU0?=
 =?utf-8?B?WlJxZ2N4eGxTdit0YStZb0E3WlZ0SURCZEdoUDJKTVZJT05GUzNpWnExOGJw?=
 =?utf-8?B?Nmhwa1l1MFpQM3B5UnFST0IrU2taUURVandkcFlIY2pHVG9OQlpFRzB2NnFS?=
 =?utf-8?B?eU1VN0psUi9rQjJaSVpiQmlFYkZsZENqK0VLUnhUZVRWQ1FmcEtmSkg1aWs0?=
 =?utf-8?B?djQwZXMxVGVSajMvMmhINXE1ZzNiSGhvV2hnUlJYM1VkYXV0YmZqVXRkSUY1?=
 =?utf-8?B?aXIyRmd4bXJFay9LWFMrOW1oR0puYS92a3BnZmlGRHlDU0MvdEVhaU5VTytw?=
 =?utf-8?B?bVZUa1RjU2ExeWZKRWM2QUZva1V4SjNwQWNUU2Zzb0toano4S09RTW1ib25a?=
 =?utf-8?B?UktjTnhHenNxZjNVODd1N1RuQ2ZGL0dGS2NodzRYL1YzN0FOMWxKWU1MeVJQ?=
 =?utf-8?B?b1Q4WHJQcTlZcjNjV2xtLy9LUEJJUS8vV2JZUkhKN3BMUmRzN1RlVjlvSk9S?=
 =?utf-8?B?d1hJMWR3MEw1d2lOVnByLyswcmxmYXZqUlBheDZYSVZtWGxZWXZqSUh1SXNJ?=
 =?utf-8?B?NW9NMldjSHNMR3M5YmMwKzk0ejZ2bGo3NjJITklZT3dDU0lWT1lhWlppSXdO?=
 =?utf-8?B?dHJadEY0YUtxMzN5OHZPVkNWcWtxay9KM2FSWEZGK1NZaXYyakRtaTd3MENq?=
 =?utf-8?B?K2FoZDFwQUtrT2ZIQjJ6eU9yK0lFMGN0OWN5aTdUd2t2ZWxvMkpVcWNhYkly?=
 =?utf-8?B?Qnl1eVBGY29ENUZkR1U1YUhpK3psSkxBUnZtYXY0MUZBNkc2amNiVm9KVisw?=
 =?utf-8?B?c21VVCtRcUZUbkY0UDFxcmYvOE9SdXAzNWZaVjJwWXpLcDVCQWZZVWZNNEZF?=
 =?utf-8?B?MkREYW1jSDczdWZUUjhDM0w2czRQVUlkMmZGVWY5S3k5cmRFZFg4RmZwS245?=
 =?utf-8?B?Z25oRmo5WGJrYlZrTnFCY29lRW0ydEdzdVpMdytFUDQyYm1KVVk2K01rMWZC?=
 =?utf-8?B?cTJzbmVoMGlFWFV3c2hudjhSMGFnTUtEZDlFajliRlJIZktOSWpVNE4yaSt6?=
 =?utf-8?B?b0gvV2FrNWRTWnZzVFdjRW9vUTJkR2svVzc3NGJxbmJLcnkrbDdCTGtiWndt?=
 =?utf-8?B?VGhyT2VReDJZeFdEU29zU1lQbHVHdmJGb1QrVVg3YWRFY1NPUzExd3lLMVV5?=
 =?utf-8?B?dWxlamk3Z0psdkE5RVdLWW9JY2NqMTdNMVQ4QjRmc29WbTJoc0oySVF4dk4r?=
 =?utf-8?B?NmNpcVNIdkU1ZVdBKysxRTQ4dmpzZFFMYXBGaEtRUmJlVWN2U2h0Tkk4MlE1?=
 =?utf-8?B?VDBYcEVieGVROElIZWN3ZG5WTENtN0FnY0Zsek1pMHluVE5xbUV6K3FCR2Vt?=
 =?utf-8?B?NWJyTFJTdGEwZzZ4c3A0OTNVWVZzbUFnWXRSMEM1dFkwZ0pPK3lCZFZYdXk0?=
 =?utf-8?B?Njd0NXVLZkVZb2ZkWWM5bjIvd09MR21vb0NwNGF6R1VSUG55ZzZQNFgwZVlO?=
 =?utf-8?B?Um9nNHJaQys1bzFJTkkvVjZxTyswbVo2dlpyV2JWRVgwTUEvMllWalpzMmJC?=
 =?utf-8?B?OEhyaW1NZmloMThjODM3WkQ4VVdXTFV4VUlmS2tqR1IzbXQ2WGVFblpXOStD?=
 =?utf-8?B?SHlUa1hrK2R4WjRJeHRxSGZhdUFuUzIzU0tUbWFhQytKWUU2QU9zVGxIa0Mw?=
 =?utf-8?B?WGhZRU5lSUMxZ2U4NU4yRUtLOVdjMWhxM3V2ZnU1L2t5bEdyZTFQUjVtdjI3?=
 =?utf-8?B?Y0pVZHhuSEJGMnVFUFI1cUdVZU9nT1V5ZnVickRnYVdHeUp0eS9la0JmL21v?=
 =?utf-8?B?cjlsVkxDbGlZc1Z4Z3FSMFF1eXVmdThGZkNOb3g1OTN2dnZEQUkrYkVlZ1dL?=
 =?utf-8?Q?CFuiQJ1tXMKObmc8=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <ACCE32CC8F033E4384E4D9C3A5F41170@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e5a4f32a-0a2a-4c3d-e14d-08d9ead597b7
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2022 07:35:34.2573
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ozckva1syKEq+LXqBCdewNMTP1d7OCPpwQfOStm0HvOAMXCV3rSyEihl87oaE4Za25r1+ssgYoGKfv4Y3EWYOvcGA1Z0jhRTbhAcA4IIbeBro2Jy5mPpGFSAReKQHpZB
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR03MB7101
X-Proofpoint-ORIG-GUID: -BRspPAzALk10VXHnAUDbmuZdIwAGWvq
X-Proofpoint-GUID: -BRspPAzALk10VXHnAUDbmuZdIwAGWvq
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-08_02,2022-02-07_02,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0
 lowpriorityscore=0 phishscore=0 bulkscore=0 mlxlogscore=999
 impostorscore=0 malwarescore=0 mlxscore=0 priorityscore=1501
 suspectscore=0 clxscore=1015 spamscore=0 classifier=spam adjust=0
 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2202080039

DQoNCk9uIDA3LjAyLjIyIDE4OjQ0LCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyB3cm90ZToNCj4N
Cj4gT24gMDcuMDIuMjIgMTg6MzcsIEphbiBCZXVsaWNoIHdyb3RlOg0KPj4gT24gMDcuMDIuMjAy
MiAxNzoyMSwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+Pj4gT24gMDcuMDIuMjIg
MTg6MTUsIEphbiBCZXVsaWNoIHdyb3RlOg0KPj4+PiBPbiAwNy4wMi4yMDIyIDE3OjA3LCBPbGVr
c2FuZHIgQW5kcnVzaGNoZW5rbyB3cm90ZToNCj4+Pj4+IE9uIDA3LjAyLjIyIDE3OjI2LCBKYW4g
QmV1bGljaCB3cm90ZToNCj4+Pj4+PiAxYi4gTWFrZSB2cGNpX3dyaXRlIHVzZSB3cml0ZSBsb2Nr
IGZvciB3cml0ZXMgdG8gY29tbWFuZCByZWdpc3RlciBhbmQgQkFScw0KPj4+Pj4+IG9ubHk7IGtl
ZXAgdXNpbmcgdGhlIHJlYWQgbG9jayBmb3IgYWxsIG90aGVyIHdyaXRlcy4NCj4+Pj4+IEkgYW0g
bm90IHF1aXRlIHN1cmUgaG93IHRvIGRvIHRoYXQuIERvIHlvdSBtZWFuIHNvbWV0aGluZyBsaWtl
Og0KPj4+Pj4gdm9pZCB2cGNpX3dyaXRlKHBjaV9zYmRmX3Qgc2JkZiwgdW5zaWduZWQgaW50IHJl
ZywgdW5zaWduZWQgaW50IHNpemUsDQo+Pj4+PiAgICAgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgIHVpbnQzMl90IGRhdGEpDQo+Pj4+PiBbc25pcF0NCj4+Pj4+ICAgICDCoMKgwqAgbGlz
dF9mb3JfZWFjaF9lbnRyeSAoIHIsICZwZGV2LT52cGNpLT5oYW5kbGVycywgbm9kZSApDQo+Pj4+
PiB7DQo+Pj4+PiBbc25pcF0NCj4+Pj4+ICAgICDCoMKgwqAgaWYgKCByLT5uZWVkc193cml0ZV9s
b2NrKQ0KPj4+Pj4gICAgIMKgwqDCoCDCoMKgwqAgd3JpdGVfbG9jayhkLT52cGNpX2xvY2spDQo+
Pj4+PiAgICAgwqDCoMKgIGVsc2UNCj4+Pj4+ICAgICDCoMKgwqAgwqDCoMKgIHJlYWRfbG9jayhk
LT52cGNpX2xvY2spDQo+Pj4+PiAuLi4uDQo+Pj4+Pg0KPj4+Pj4gQW5kIHByb3ZpZGUgcncgYXMg
YW4gYXJndW1lbnQgdG86DQo+Pj4+Pg0KPj4+Pj4gaW50IHZwY2lfYWRkX3JlZ2lzdGVyKHN0cnVj
dCB2cGNpICp2cGNpLCB2cGNpX3JlYWRfdCAqcmVhZF9oYW5kbGVyLA0KPj4+Pj4gICAgIMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB2cGNpX3dyaXRlX3QgKndyaXRl
X2hhbmRsZXIsIHVuc2lnbmVkIGludCBvZmZzZXQsDQo+Pj4+PiAgICAgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHVuc2lnbmVkIGludCBzaXplLCB2b2lkICpkYXRh
LCAtLS0+Pj4gYm9vbCB3cml0ZV9wYXRoIDw8PC0tLS0tKQ0KPj4+Pj4NCj4+Pj4+IElzIHRoaXMg
d2hhdCB5b3UgbWVhbj8NCj4+Pj4gVGhpcyBzb3VuZHMgb3Zlcmx5IGNvbXBsaWNhdGVkLiBZb3Ug
Y2FuIGRlcml2ZSBsb2NhbGx5IGluIHZwY2lfd3JpdGUoKSwNCj4+Pj4gZnJvbSBqdXN0IGl0cyAi
cmVnIiBhbmQgInNpemUiIHBhcmFtZXRlcnMsIHdoZXRoZXIgdGhlIGxvY2sgbmVlZHMgdGFraW5n
DQo+Pj4+IGluIHdyaXRlIG1vZGUuDQo+Pj4gWWVzLCBJIHN0YXJ0ZWQgd3JpdGluZyBhIHJlcGx5
IHdpdGggdGhhdC4gU28sIHRoZSBzdW1tYXJ5IChST00NCj4+PiBwb3NpdGlvbiBkZXBlbmRzIG9u
IGhlYWRlciB0eXBlKToNCj4+PiBpZiAoIChyZWcgPT0gUENJX0NPTU1BTkQpIHx8IChyZWcgPT0g
Uk9NKSApDQo+Pj4gew0KPj4+ICAgIMKgwqDCoCByZWFkIFBDSV9DT01NQU5EIGFuZCBzZWUgaWYg
bWVtb3J5IG9yIElPIGRlY29kaW5nIGFyZSBlbmFibGVkLg0KPj4+ICAgIMKgwqDCoCBpZiAoIGVu
YWJsZWQgKQ0KPj4+ICAgIMKgwqDCoCDCoMKgwqAgd3JpdGVfbG9jayhkLT52cGNpX2xvY2spDQo+
Pj4gICAgwqDCoMKgIGVsc2UNCj4+PiAgICDCoMKgwqAgwqDCoMKgIHJlYWRfbG9jayhkLT52cGNp
X2xvY2spDQo+Pj4gfQ0KPj4gSG1tLCB5ZXMsIHlvdSBjYW4gYWN0dWFsbHkgZ2V0IGF3YXkgd2l0
aG91dCB1c2luZyAic2l6ZSIsIHNpbmNlIGJvdGgNCj4+IGNvbW1hbmQgcmVnaXN0ZXIgYW5kIFJP
TSBCQVIgYXJlIDMyLWJpdCBhbGlnbmVkIHJlZ2lzdGVycywgYW5kIDY0LWJpdA0KPj4gYWNjZXNz
ZXMgZ2V0IHNwbGl0IGluIHZwY2lfZWNhbV93cml0ZSgpLg0KPiBCdXQsIE9TIG1heSB3YW50IHJl
YWRpbmcgYSBzaW5nbGUgYnl0ZSBvZiBST00gQkFSLCBzbyBJIHRoaW5rDQo+IEknbGwgbmVlZCB0
byBjaGVjayBpZiByZWcrc2l6ZSBmYWxsIGludG8gUENJX0NPTUFORCBhbmQgUk9NIEJBUg0KPiBy
YW5nZXMNCj4+IEZvciB0aGUgY29tbWFuZCByZWdpc3RlciB0aGUgbWVtb3J5LSAvIElPLWRlY29k
aW5nLWVuYWJsZWQgY2hlY2sgbWF5DQo+PiBlbmQgdXAgYSBsaXR0bGUgbW9yZSBjb21wbGljYXRl
ZCwgYXMgdGhlIHZhbHVlIHRvIGJlIHdyaXR0ZW4gYWxzbw0KPj4gbWF0dGVycy4gTWF5YmUgcmVh
ZCB0aGUgY29tbWFuZCByZWdpc3RlciBvbmx5IGZvciB0aGUgUk9NIEJBUiB3cml0ZSwNCj4+IHVz
aW5nIHRoZSB3cml0ZSBsb2NrIHVuaWZvcm1seSBmb3IgYWxsIGNvbW1hbmQgcmVnaXN0ZXIgd3Jp
dGVzPw0KPiBTb3VuZHMgZ29vZCBmb3IgdGhlIHN0YXJ0Lg0KPiBBbm90aGVyIGNvbmNlcm4gaXMg
dGhhdCBpZiB3ZSBnbyB3aXRoIGEgcmVhZF9sb2NrIGFuZCB0aGVuIGluIHRoZQ0KPiB1bmRlcmx5
aW5nIGNvZGUgd2UgZGlzYWJsZSBtZW1vcnkgZGVjb2RpbmcgYW5kIHRyeSBkb2luZw0KPiBzb21l
dGhpbmcgYW5kIGNhbGxpbmcgY21kX3dyaXRlIGhhbmRsZXIgZm9yIGFueSByZWFzb24gdGhlbi4u
Li4NCj4NCj4gSSBtZWFuIHRoYXQgdGhlIGNoZWNrIGluIHRoZSB2cGNpX3dyaXRlIGlzIHNvbWV3
aGF0IHdlIGNhbiB0b2xlcmF0ZSwNCj4gYnV0IHRoZW4gaXQgaXMgbXVzdCBiZSBjb25zaWRlcmVk
IHRoYXQgbm8gY29kZSBpbiB0aGUgcmVhZCBwYXRoDQo+IGlzIGFsbG93ZWQgdG8gcGVyZm9ybSB3
cml0ZSBwYXRoIGZ1bmN0aW9ucy4gV2hpY2ggYnJpbmdzIGEgcHJldHR5DQo+IHZhbGlkIHVzZS1j
YXNlOiBzYXkgaW4gcmVhZCBtb2RlIHdlIGRldGVjdCBhbiB1bnJlY292ZXJhYmxlIGVycm9yDQo+
IGFuZCBuZWVkIHRvIHJlbW92ZSB0aGUgZGV2aWNlOg0KPiB2cGNpX3Byb2Nlc3NfcGVuZGluZyAt
PiBFUlJPUiAtPiB2cGNpX3JlbW92ZV9kZXZpY2Ugb3Igc2ltaWxhci4NCj4NCj4gV2hhdCBkbyB3
ZSBkbyB0aGVuPyBJdCBpcyBhbGwgZ29pbmcgdG8gYmUgZnJhZ2lsZS4uLg0KSSBoYXZlIHRyaWVk
IHRvIHN1bW1hcml6ZSB0aGUgb3B0aW9ucyB3ZSBoYXZlIHdydCBsb2NraW5nDQphbmQgd291bGQg
bG92ZSB0byBoZWFyIGZyb20gQFJvZ2VyIGFuZCBASmFuLg0KDQpJbiBldmVyeSB2YXJpYW50IHRo
ZXJlIGlzIGEgdGFzayBvZiBkZWFsaW5nIHdpdGggdGhlIG92ZXJsYXANCmRldGVjdGlvbiBpbiBt
b2RpZnlfYmFycywgc28gdGhpcyBpcyB0aGUgb25seSBwbGFjZSBhcyBvZiBub3cNCndoaWNoIG5l
ZWRzIHNwZWNpYWwgdHJlYXRtZW50Lg0KDQpFeGlzdGluZyBsaW1pdGF0aW9uczogdGhlcmUgaXMg
bm8gd2F5IHRvIHVwZ3JhZGUgYSByZWFkIGxvY2sgdG8gYSB3cml0ZQ0KbG9jaywgc28gcGF0aHMg
d2hpY2ggbWF5IHJlcXVpcmUgd3JpdGUgbG9jayBwcm90ZWN0aW9uIG5lZWQgdG8gdXNlDQp3cml0
ZSBsb2NrIGZyb20gdGhlIHZlcnkgYmVnaW5uaW5nLiBXb3JrYXJvdW5kcyBjYW4gYmUgYXBwbGll
ZC4NCg0KMS4gUGVyLWRvbWFpbiBydyBsb2NrLCBha2EgZC0+dnBjaV9sb2NrDQo9PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KTm90
ZTogd2l0aCBwZXItZG9tYWluIHJ3IGxvY2sgaXQgaXMgcG9zc2libGUgdG8gZG8gd2l0aG91dCBp
bnRyb2R1Y2luZw0KcGVyLWRldmljZSBsb2Nrcywgc28gcGRldi0+dnBjaS0+bG9jayBjYW4gYmUg
cmVtb3ZlZCBhbmQgbm8gcGRldi0+dnBjaV9sb2NrDQpzaG91bGQgYmUgcmVxdWlyZWQuDQoNClRo
aXMgaXMgb25seSBnb2luZyB0byB3b3JrIGluIGNhc2UgaWYgdnBjaV93cml0ZSBhbHdheXMgdGFr
ZXMgdGhlIHdyaXRlIGxvY2sNCmFuZCB2cGNpX3JlYWQgdGFrZXMgYSByZWFkIGxvY2sgYW5kIG5v
IHBhdGggaW4gdnBjaV9yZWFkIGlzIGFsbG93ZWQgdG8NCnBlcmZvcm0gd3JpdGUgcGF0aCBvcGVy
YXRpb25zLg0KdnBjaV9wcm9jZXNzX3BlbmRpbmcgdXNlcyB3cml0ZSBsb2NrIGFzIGl0IGhhdmUg
dnBjaV9yZW1vdmVfZGV2aWNlIGluIGl0cw0KZXJyb3IgcGF0aC4NCg0KUHJvczoNCi0gbm8gcGVy
LWRldmljZSB2cGNpIGxvY2sgaXMgbmVlZGVkPw0KLSBzb2x2ZXMgb3ZlcmxhcCBjb2RlIEFCQkEg
aW4gbW9kaWZ5X2JhcnMNCg0KQ29uczoNCi0gYWxsIHdyaXRlcyBhcmUgc2VyaWFsaXplZA0KLSBu
ZWVkIHRvIGNhcmVmdWxseSBzZWxlY3QgcmVhZCBwYXRocywgc28gdGhleSBhcmUgZ3VhcmFudGVl
ZCBub3QgdG8gbGVhZA0KIMKgIHRvIGxvY2sgdXBncmFkZSB1c2UtY2FzZXMNCg0KMS4xLiBTZW1p
IHJlYWQgbG9jayB1cGdyYWRlIGluIG1vZGlmeSBiYXJzDQotLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQ0KSW4gdGhpcyBjYXNlIGJv
dGggdnBjaV9yZWFkIGFuZCB2cGNpX3dyaXRlIHRha2UgYSByZWFkIGxvY2sgYW5kIHdoZW4gaXQg
Y29tZXMNCnRvIG1vZGlmeV9iYXJzOg0KDQoxLiByZWFkX3VubG9jayhkLT52cGNpX2xvY2spDQoy
LiB3cml0ZV9sb2NrKGQtPnZwY2lfbG9jaykNCjMuIENoZWNrIHRoYXQgcGRldi0+dnBjaSBpcyBz
dGlsbCBhdmFpbGFibGUgYW5kIGlzIHRoZSBzYW1lIG9iamVjdDoNCmlmIChwZGV2LT52cGNpICYm
IChwZGV2LT52cGNpID09IG9sZF92cGNpKSApDQp7DQogwqDCoMKgIC8qIHZwY2kgc3RydWN0dXJl
IGlzIHZhbGlkIGFuZCBjYW4gYmUgdXNlZC4gKi8NCn0NCmVsc2UNCnsNCiDCoMKgwqAgLyogdnBj
aSBoYXMgZ29uZSwgcmV0dXJuIGFuIGVycm9yLiAqLw0KfQ0KDQpQcm9zOg0KLSBubyBwZXItZGV2
aWNlIHZwY2kgbG9jayBpcyBuZWVkZWQ/DQotIHNvbHZlcyBvdmVybGFwIGNvZGUgQUJCQSBpbiBt
b2RpZnlfYmFycw0KLSByZWFkZXJzIGFuZCB3cml0ZXJzIGFyZSBOT1Qgc2VyaWFsaXplZA0KLSBO
TyBuZWVkIHRvIGNhcmVmdWxseSBzZWxlY3QgcmVhZCBwYXRocywgc28gdGhleSBhcmUgZ3VhcmFu
dGVlZCBub3QgdG8gbGVhZA0KIMKgIHRvIGxvY2sgdXBncmFkZSB1c2UtY2FzZXMNCg0KQ29uczoN
Ci0gPz8/DQoNCjIuIHBlci1kZXZpY2UgbG9jayAocGRldi0+dnBjaV9sb2NrKSArIGQtPm92ZXJs
YXBfY2hrX2xvY2sNCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09DQpJbiBvcmRlciB0byBzb2x2ZSBvdmVybGFwIEFCQkEsIHdlIGlu
dHJvZHVjZSBhIHBlci1kb21haW4gaGVscGVyDQpsb2NrIHRvIHByb3RlY3QgdGhlIG92ZXJsYXBw
aW5nIGNvZGUgaW4gbW9kaWZ5X2JhcnM6DQoNCiDCoMKgwqAgb2xkX3ZwY2kgPSBwZGV2LT52cGNp
Ow0KIMKgwqDCoCBzcGluX3VubG9jayhwZGV2LT52cGNpX2xvY2spOw0KIMKgwqDCoCBzcGluX2xv
Y2socGRldi0+ZG9tYWluLT5vdmVybGFwX2Noa19sb2NrKTsNCiDCoMKgwqAgc3Bpbl9sb2NrKHBk
ZXYtPnZwY2lfbG9jayk7DQogwqDCoMKgIGlmICggcGRldi0+dnBjaSAmJiAocGRldi0+dnBjaSA9
PSBvbGRfdnBjaSkgKQ0KIMKgwqDCoMKgwqDCoMKgIGZvcl9lYWNoX3BkZXYgKCBwZGV2LT5kb21h
aW4sIHRtcCApDQogwqDCoMKgwqDCoMKgwqAgew0KIMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgaWYg
KCB0bXAgIT0gcGRldiApDQogwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB7DQogwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgIHNwaW5fbG9jayh0bXAtPnZwY2lfbG9jayk7DQogwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgIGlmICggdG1wLT52cGNpICkNCiDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAuLi4NCiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIH0NCiDC
oMKgwqDCoMKgwqDCoCB9DQoNClByb3M6DQotIGFsbCBhY2Nlc3NlcyBhcmUgaW5kZXBlbmRlbnQs
IG9ubHkgdGhlIHNhbWUgZGV2aWNlIGFjY2VzcyBpcyBzZXJpYWxpemVkDQotIG5vIG5lZWQgdG8g
Y2FyZSBhYm91dCByZWFkZXJzIGFuZCB3cml0ZXJzIHdydCByZWFkIGxvY2sgdXBncmFkZSBpc3N1
ZXMNCg0KQ29uczoNCi0gaGVscGVyIHNwaW4gbG9jaw0KDQozLiBNb3ZlIG92ZXJsYXAgZGV0ZWN0
aW9uIGludG8gcHJvY2VzcyBwZW5kaW5nDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KVGhlcmUgaXMgYSBSb2dlcidzIHBhdGNo
IFsxXSB3aGljaCBhZGRzIGEgcG9zc2liaWxpdHkgZm9yIHZwY2lfcHJvY2Vzc19wZW5kaW5nDQp0
byBwZXJmb3JtIGRpZmZlcmVudCB0YXNrcyByYXRoZXIgdGhhbiBqdXN0IG1hcC91bm1hcC4gV2l0
aCB0aGlzIHBhdGNoIGV4dGVuZGVkDQppbiBhIHdheSB0aGF0IGl0IGNhbiBob2xkIGEgcmVxdWVz
dCBxdWV1ZSBpdCBpcyBwb3NzaWJsZSB0byBkZWxheSBleGVjdXRpb24NCm9mIHRoZSBvdmVybGFw
IGNvZGUgdW50aWwgbm8gcGRldi0+dnBjaV9sb2NrIGlzIGhlbGQsIGJ1dCBiZWZvcmUgcmV0dXJu
aW5nIHRvDQphIGd1ZXN0IGFmdGVyIHZwY2lfe3JlYWR8d3JpdGV9IG9yIHNpbWlsYXIuDQoNClBy
b3M6DQotIG5vIG5lZWQgdG8gZW11bGF0ZSByZWFkIGxvY2sgdXBncmFkZQ0KLSBmdWxseSBwYXJh
bGxlbCByZWFkL3dyaXRlDQotIHF1ZXVlIGluIHRoZSB2cGNpX3Byb2Nlc3NfcGVuZGluZyB3aWxs
IGxhdGVyIG9uIGJlIHVzZWQgYnkgU1ItSU9WLA0KIMKgIHNvIHRoaXMgaXMgZ29pbmcgdG8gaGVs
cCB0aGUgZnV0dXJlIGNvZGUNCkNvbnM6DQotID8/Pw0KDQo0LiBSZS13cml0ZSBvdmVybGFwIGRl
dGVjdGlvbiBjb2RlDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PQ0KSXQgaXMgcG9zc2libGUgdG8gcmUtd3JpdGUgb3ZlcmxhcCBk
ZXRlY3Rpb24gY29kZSwgc28gdGhlIGluZm9ybWF0aW9uIGFib3V0IHRoZQ0KbWFwcGVkL3VubWFw
cGVkIHJlZ2lvbnMgaXMgbm90IHJlYWQgZnJvbSB2cGNpLT5oZWFkZXItPmJhcnNbaV0gb2YgZWFj
aCBkZXZpY2UsDQpidXQgaW5zdGVhZCB0aGVyZSBpcyBhIHBlci1kb21haW4gc3RydWN0dXJlIHdo
aWNoIGhvbGRzIHRoZSByZWdpb25zIGFuZA0KaW1wbGVtZW50cyByZWZlcmVuY2UgY291bnRpbmcu
DQoNClByb3M6DQotIHNvbHZlcyBBQkJBDQoNCkNvbnM6DQotIHZlcnkgY29tcGxleCBjb2RlIGlz
IGV4cGVjdGVkDQoNCjUuIFlvdSBuYW1lIGl0DQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KDQogRnJvbSBhbGwgdGhlIGFib3Zl
IEkgd291bGQgcmVjb21tZW5kIHdlIGdvIHdpdGggb3B0aW9uIDIgd2hpY2ggc2VlbXMgdG8gcmVs
aWFibHkNCnNvbHZlIEFCQkEgYW5kIGRvZXMgbm90IGJyaW5nIGNvbnMgb2YgdGhlIG90aGVyIGFw
cHJvYWNoZXMuDQoNClRoYW5rIHlvdSBpbiBhZHZhbmNlLA0KT2xla3NhbmRyDQoNClsxXSBodHRw
czovL2xvcmUua2VybmVsLm9yZy9hbGwvNUJBQkE2RUYwMjAwMDA3ODAwMUVDNDUyQHBydjEtbWgu
cHJvdm8ubm92ZWxsLmNvbS9ULyNtMjMxZmIwNTg2MDA3NzI1YmZkODUzOGJiOTdmZjE3NzdhMzY4
NDJjZg==


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 07:42:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 07:42:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267619.461365 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHL91-0008GE-0z; Tue, 08 Feb 2022 07:42:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267619.461365; Tue, 08 Feb 2022 07:42:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHL90-0008G7-Se; Tue, 08 Feb 2022 07:42:34 +0000
Received: by outflank-mailman (input) for mailman id 267619;
 Tue, 08 Feb 2022 07:42:34 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=co3W=SX=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nHL90-0008G1-4h
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 07:42:34 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id acf2fee5-88b2-11ec-8f75-fffcc8bd4f1a;
 Tue, 08 Feb 2022 08:42:33 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 997AE1F37C;
 Tue,  8 Feb 2022 07:42:32 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 51BC513310;
 Tue,  8 Feb 2022 07:42:32 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 6UiREugeAmJuKgAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 08 Feb 2022 07:42:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: acf2fee5-88b2-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1644306152; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=RkNVJ8B50ZJGLSJsqgFPrNnsyQy6qOKAOEmYrLaw3oU=;
	b=eddlgDv8TnhY8YtMap9NK02ImSBXAh/JBx2Ts438iP7aS+v58Ua0GrnTDviKSk2P0zdvga
	Jn25nqZbJxS52lxXkd9xQF+Mu2dAnpT8OGw4HEVhfZM39FER9VKHf6oLn0fKEn/TJg8A/X
	Nex1jCoezOeQv/HAoMInxwsDxYp6ERI=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>
Subject: [PATCH v2] xen/public: add comment to struct xen_mem_acquire_resource
Date: Tue,  8 Feb 2022 08:42:30 +0100
Message-Id: <20220208074230.7901-1-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Commit 7c7f7e8fba01 changed xen/include/public/memory.h in an incompatible
way. Unfortunately the changed parts were already in use in the Linux
kernel, so an update of the header in the kernel would result in a build
breakage.

As the change of above commit was in a section originally meant to be not
stable, it was the usage in the kernel which was wrong.

Add a comment to the modified struct for not reusing the now removed bit,
in order to avoid kernels using it stumbling over a possible new meaning
of the bit.

In case the kernel is updating to a new version of the header, the wrong
use case must be removed first.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
V2:
- only add comment instead of reverting commit 7c7f7e8fba01 (Jan Beulich)
---
 xen/include/public/memory.h | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/xen/include/public/memory.h b/xen/include/public/memory.h
index 383a9468c3..86513057f7 100644
--- a/xen/include/public/memory.h
+++ b/xen/include/public/memory.h
@@ -662,6 +662,11 @@ struct xen_mem_acquire_resource {
      * two calls.
      */
     uint32_t nr_frames;
+    /*
+     * Padding field, must be zero on input.
+     * The lowest bit was named XENMEM_rsrc_acq_caller_owned in a previous
+     * version and should not be reused in future.
+     */
     uint32_t pad;
     /*
      * IN - the index of the initial frame to be mapped. This parameter
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Tue Feb 08 08:00:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 08:00:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267637.461376 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHLQW-0002h8-U0; Tue, 08 Feb 2022 08:00:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267637.461376; Tue, 08 Feb 2022 08:00:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHLQW-0002h1-R3; Tue, 08 Feb 2022 08:00:40 +0000
Received: by outflank-mailman (input) for mailman id 267637;
 Tue, 08 Feb 2022 08:00:38 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1FiY=SX=epam.com=prvs=40383cc40e=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nHLQU-0002gt-Ja
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 08:00:38 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 31d29bb6-88b5-11ec-8f75-fffcc8bd4f1a;
 Tue, 08 Feb 2022 09:00:36 +0100 (CET)
Received: from pps.filterd (m0174681.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 2187rNV4021871;
 Tue, 8 Feb 2022 08:00:31 GMT
Received: from eur05-db8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2111.outbound.protection.outlook.com [104.47.17.111])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3e3mh7g0rm-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Tue, 08 Feb 2022 08:00:31 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM6PR03MB5457.eurprd03.prod.outlook.com (2603:10a6:20b:cb::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Tue, 8 Feb
 2022 08:00:28 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77%3]) with mapi id 15.20.4951.019; Tue, 8 Feb 2022
 08:00:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 31d29bb6-88b5-11ec-8f75-fffcc8bd4f1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=nRlnwY34tkcOpvBpl96fr2ss1mjuwoOb6/Qc9MATCxj/aI7Ea0uEqjk6bjcIEIy7l2z7r8rmv7TEe2BodZ4UsGMeh492jsWp2UbW5Z/3thZa5OZ2qPKBvg6dtseh84O+NXc1n+cGwNNi8ha+eVoM+H1M0cl1t70SqaqOvXpbTcyWCV0BijgwZaYVgQq2L0N4jf49bEspQ17u5B1qn2uphT6oq7qutfLRJy2LwH/lXakoZCDHK9dRP+eQvEvs7Oi5/FSE1EyaqZqhs0Cc29NihVlVIEe5+nM0UF9nhJMmIPT2uD0r3XXdJBoH65bsw7SRWZB6Q9DFaBuWc41lIuIZ7g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=JSXkDlzILY7kwi8NyLXpJsr0LsQIlPej9iYjEc1YIDo=;
 b=QZmzFraRdU7W8yu7HSkYAdyQraoBuKbM/evLPk3bJw29bVOgKtPIdTqs0u40jTDv5XhrZCO+VJONVPghFzOdFyY+GHN+Tky2c837nQ0cTC48k81oVRgQPZGsIdTx2uS5FSEPqQl2ib9AGsKpxO715LbU6YMFDyv834pX3k/W8UvOL1mCnI5FxurxDBQJ9HQAdyISuzKuaCUtJWMHs6OnIUdZCz2gceucRuHMlDX0relXFCemp62zV2PQBgeeueWv2fEFRV0WZiH4eRHIRc+g+2X/ptqfpYgL8nKocZQoa0624tMbNffO6EfqwD5hsnpkepVHJUvyduzrD/QcS0ybUw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=JSXkDlzILY7kwi8NyLXpJsr0LsQIlPej9iYjEc1YIDo=;
 b=n5qb9PidI6PFDKtWpFkzPrA/NygWGd1DuVvkK9D2o7FfvomtpgW4DC8WnqQE3HHA0MsRoRzB+dkv8mFtGFehvIVuR7RxV4i1ndjskFKvc1BTq6EWA4EzlWu2KcJrohJbz0+QGmx8tMwQplbdQTifts16YNniYPoxELOoinuNQexIi+F0ezC64DS8sMFqEjSl+eG+iy5NX7kkdy+N/DrRFYQLafwgQ3igOWK1bBl6hb3IbCn6rhDnBXnhtZsFBGtcpwuFjpfhZXXjbU1Doh0HvqAlOxlYwOFyFwAJAzakENsW+yxXluPXAU20rH9sg3aE/UMHXvJV9ISuo5uymPbsLw==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: "roger.pau@citrix.com" <roger.pau@citrix.com>,
        Jan Beulich
	<jbeulich@suse.com>
CC: "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v6 04/13] vpci: restrict unhandled read/write operations
 for guests
Thread-Topic: [PATCH v6 04/13] vpci: restrict unhandled read/write operations
 for guests
Thread-Index: AQHYGZFbf8/6pUr0mUKzbmboCx8QkqyDbvWAgAADnYCABd4pgA==
Date: Tue, 8 Feb 2022 08:00:28 +0000
Message-ID: <5a87c401-4ebd-1d5c-b98d-1b535f63be65@epam.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-5-andr2000@gmail.com>
 <b6f091ed-4fa3-e292-9a21-a780ec90ee09@suse.com>
 <f86a43af-1388-6959-3e71-ba796e4a0c63@epam.com>
In-Reply-To: <f86a43af-1388-6959-3e71-ba796e4a0c63@epam.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 0da6cd61-71c9-455c-d601-08d9ead91223
x-ms-traffictypediagnostic: AM6PR03MB5457:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM6PR03MB54572FCF7E6B9A9E2B210EE5E72D9@AM6PR03MB5457.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 ORj6y++7fznYWV9jMNOXn3gCI0Z2WzZzMeMY7fF4yQngvDl0U09PirYyXtxVdtq0l4gYN9HdCcAnZPSgwmmDkgdXDyR0PvucR5uiQEMMG3XYVcrsrDBHeaPz1O8Fk5XhnR0PqB3uG7odJQeS5YAe6i555HNCzbKH+ARJqdktDNJzFeclPZfMeJr48HeD4a1wAjEP8vgiYCPlQH8X08qCq9p3IbCaNKvfbuz6lpvLSAJmNp8OTyZGFYalFFZFONVbNpXuuN1DKaU62lt/EGftAUM72kDFhhCr8ID9Sdk1HnjWYV8281JRO7IHV2pJTBm8X2Lp2NcDm9r3Pz40I7OTj6V0dQfsBTiY7sswGn5ETECBQFv/boz9VNnYMBXybgD+yAmNFQihXoqS2XxNv5s0ECKBwIFqOvese4SLkSGGGqqbKIs6b7gPotGTkr7CBJpO5UNFZpHogSQnICOP3UOkOTmHpz3CaapnbF5Z2mtQh0guNa/BxzUc8NGj8KL8yM/L+3Ywc1uppeJlyk3a7SIfYPMUjACCKVxKh8SytiYCz+NojVUjTo1QiAlWP9IJ2f0Go47R1eFSHDPPTQmtNoH4L16awfarH3jBRRgXAjFhfO/Ld34zI4HaPPBlbnZ8KEcbWiQZmOyfx5iPc6668z2GJCc1MYFkcqj18iKPqaoVL/ZSak5dYgOfDS4infKOPqtA/7EFDtt4psg1h/p+xkVtkt9FSTyWak/SXoAaDPN1gX2ZHkqsCFNxCG75QXTLRheN
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(86362001)(66556008)(66946007)(38070700005)(4326008)(91956017)(76116006)(8676002)(36756003)(5660300002)(7416002)(6486002)(8936002)(66446008)(64756008)(83380400001)(122000001)(38100700002)(54906003)(110136005)(31696002)(2906002)(66476007)(316002)(71200400001)(2616005)(31686004)(55236004)(53546011)(186003)(6506007)(26005)(508600001)(107886003)(6512007)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?Y3haZ1JlTmpkUFYvQWFvV2ZxV09wbmY4aEx3bXlzaFdoakM4VnpOUmlhd2ZP?=
 =?utf-8?B?N0JzMFRNMGN6MlpmRjNGZUN6RzlIQlZiSkRjUDdqcFVvUmZ4RmlzdFZ1c3NL?=
 =?utf-8?B?RXdmY3hEZXo1VHg3dk5RbGNZd1d2Q213ekRJcDVGM3BsNzl4bi8wNFlWZ0lq?=
 =?utf-8?B?T0RsK2tobVhtN21ua3RGOCs3dzBNUnp4dURuQm9nbnFLbFBLd3kvTXNBZGgw?=
 =?utf-8?B?S3ZxcHhJTjU3amtLK29jYm5XZGZ0YUVkK0I2cWtuQmdiL1lwMUt3N1RyMm1G?=
 =?utf-8?B?SnBBOTJ5d2E2akJDY002NFhIODRqczBNQ0tyQ3N3cDZEOGNzNmZkR0c0WlNP?=
 =?utf-8?B?ZG1PRkJBZnozU3RQU0dJNHI4b0VZWWMyNnRrTFpDQTJlVDZweG03UkcwR0s2?=
 =?utf-8?B?a1hBeWd6dVRqUnN6K3NqcGdUeEF1Uy8xeWw5OVBWeTBER0pKcjloMEN0RGla?=
 =?utf-8?B?c0crUHJKQUhaNkl2U1RkeHdJS2ZHWEhCOEZLNzM3QStPUlEvSXd5aU4yb24z?=
 =?utf-8?B?WjNHRmM4RFpJam82T0VQcnpsZW85UDJqOGNPcU1vU2hRVzRQSGE3alBVemk1?=
 =?utf-8?B?aEIyQko5eitTWW5HUmF0OUFySEk3cjc5bjBIb2ttZE5GL0tqNk5wWHNHTzA5?=
 =?utf-8?B?azVFZ0tVWisvZjA1cU9QaFdVTDNJcm5WZnJFUzh3dGFqQ1AybFlpM1EyU0ts?=
 =?utf-8?B?cW5FSFpoNDErWXpoZXlsTDNHcmRqUTY5dGkwV2YveUR5anJjaGVsTkliZm1J?=
 =?utf-8?B?YkxFMlgvRFV5YkFSMmJIdmF2bExVQjdaOGRqUEIrNHBjdFRxUlgxOUFzQkVN?=
 =?utf-8?B?MXplSkloa1Fnc2ZFbnhta2E3ODhDVnpjV2Z0SzBvYXpFd25lMVVua01tekdv?=
 =?utf-8?B?aEN4SHk4ejdmZUZyMmhjTzgzSkZFK2VIenpSaXJ1NE5oTGl1MWRNWDVxcDFp?=
 =?utf-8?B?TmFXYkcyMU45azl4aDlzcnpvbVNuSEdCK1ZoMWJINjlWYUpnbmpwR2RLcmxt?=
 =?utf-8?B?c3FHWFhNN2RLZmFpbW1EVEJhT3NMbkoxak9YQkdSUVdXTDlSWVE5bjRUWXp4?=
 =?utf-8?B?dVVSS2lQWTRYUFdXUVZYSmFDZnlsMFQ2N1lZaDluSmIrSTg2c1ZaN3d5WUIy?=
 =?utf-8?B?dHhOL2FTbXBQMG1HN0ZRU1hER0JnNEp0UWtvTUdMcWRSMUZuNlprWVJmOGFJ?=
 =?utf-8?B?REdOdmZSOVRWYnRWY2NURnEzM1ZsTGdYYUh5VHg5U0NCUDVwQ0NQcXpKOFFl?=
 =?utf-8?B?NytoTHVZOFVmUGpNNk1OZkt5RDB3WGoraFlweXFLVXE3U3NidFFNemVUV2ZN?=
 =?utf-8?B?ajUwcFVWaHE2NGx6TWF1Q29BZUM2QlhYZWE0NzVtckdpVzNYT2R1Wlg1Sjd5?=
 =?utf-8?B?bEFMbk1JT0dpcnR0Z3RCc3oyTEk4ZlN5TWlXczdEZTA3YSswcGRVNlFidWs2?=
 =?utf-8?B?RDBIN1ZyaE8wMHlvVnZTZEdYRlp5b1oxSGdyVDJZeTlTeUlQcnRMbVIrbXgv?=
 =?utf-8?B?aURDRjJnZXZnWWdXbFJKejJEZWgxUDB2WlBva2V4WW9pTzByUXdNc0FkaEhR?=
 =?utf-8?B?bDVveXhab29kUVU3WVkvSUtyOURveExFTTg3NnZqZVRjSUNkYmJpdkg3RDdk?=
 =?utf-8?B?TC9aQzFXRnFSWjRlazc1dktzOERvUGxLRTdQS1Bzc3hLTjk0N1Q2S1c2d2ti?=
 =?utf-8?B?RGNqNGtnMGNGTlpHYUJZc2VwU1JnNnVGSk5kWTZ5S2kyN21XbjZFWDVLZmMx?=
 =?utf-8?B?WGNCVDZZWkV6QnU5UlMwTEdkdlRiWTVaZDVMVkJJZ1BZYUw3UXVDMG9UaUt1?=
 =?utf-8?B?V21pcXBxckY2c0VOdDRTVy9nbWl5TDdtRVB5RThvbFFCZHBEelRESkRwUjBy?=
 =?utf-8?B?bjlwMjA0RnhxbzNBTzZCMVdOd3JtOEJWU21jZkpyUE1lTkVMOWdsUWJ5WmM3?=
 =?utf-8?B?ak0zZlZHY09ka1A4REhmQlA1b3BmSHJMenkvaWkxNWRzeWNtLzN0K0V2RGhN?=
 =?utf-8?B?NWV2c21xUDlrUm9SSjZaYWpldVdEd1JLS0FOb2s2cjF4dEw5aGxsL29CZU5v?=
 =?utf-8?B?eGRWbllxUTFOdW94VGkyVVQ5ZzBML0Q4aG5rOG84aUtERlZ1ZzB2UGFEampE?=
 =?utf-8?B?TzQ0OGJkUUVwdkRhWFkzRVIxM3BoT3dEaklBc0FrbHNUYW15d3ladVI5MlM4?=
 =?utf-8?B?RGR3YWFUNFhTMDNhd01NeFZ3Y29TWXBYbEpBMUVSbmY5cGlxcm9OZHUzQmFx?=
 =?utf-8?B?SUZNY3hMRnhMZWF0cHh5clRvZlBnTnpnQit3SzNtcVZZaHJXc2w3N010MEVZ?=
 =?utf-8?B?UTBGVDhzdVIwdkkxTEFWaHVGZnluOFZzUG1STUVjcC9sdHBqQ0JzQzVVVGpG?=
 =?utf-8?Q?6TrpMVgaiNQFL3dg=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <6B45FA74D8CE0F46ACCC7468DE0227D9@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0da6cd61-71c9-455c-d601-08d9ead91223
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2022 08:00:28.1683
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: L6lLFtUrLrdwTHcTJrOdoLGT/dxZVoYWExHuRW7WVntMnZ2qHt8JejAP7ylimTz/Mhyw1y8ZpHhxo4MFzUhB6NHy7FItJuTjSVON+AAzG31MQNq6GKx+PuZ/FerX17Wa
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR03MB5457
X-Proofpoint-GUID: C9EedLsI0h05hhyLELMb5mhXjq8TAS9T
X-Proofpoint-ORIG-GUID: C9EedLsI0h05hhyLELMb5mhXjq8TAS9T
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-08_02,2022-02-07_02,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0
 lowpriorityscore=0 bulkscore=0 mlxlogscore=999 priorityscore=1501
 impostorscore=0 spamscore=0 adultscore=0 malwarescore=0 mlxscore=0
 phishscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202080043

DQpPbiAwNC4wMi4yMiAxNjoyNCwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+DQo+
IE9uIDA0LjAyLjIyIDE2OjExLCBKYW4gQmV1bGljaCB3cm90ZToNCj4+IE9uIDA0LjAyLjIwMjIg
MDc6MzQsIE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4+IEEgZ3Vlc3QgY2FuIHJl
YWQgYW5kIHdyaXRlIHRob3NlIHJlZ2lzdGVycyB3aGljaCBhcmUgbm90IGVtdWxhdGVkIGFuZA0K
Pj4+IGhhdmUgbm8gcmVzcGVjdGl2ZSB2UENJIGhhbmRsZXJzLCBzbyBpdCBjYW4gYWNjZXNzIHRo
ZSBIVyBkaXJlY3RseS4NCj4+IEkgZG9uJ3QgdGhpbmsgdGhpcyBkZXNjcmliZXMgdGhlIHByZXNl
bnQgc2l0dWF0aW9uLiBPciBkaWQgSSBtaXNzIHdoZXJlDQo+PiBkZXZpY2VzIGNhbiBhY3R1YWxs
eSBiZSBleHBvc2VkIHRvIGd1ZXN0cyBhbHJlYWR5LCBkZXNwaXRlIG11Y2ggb2YgdGhlDQo+PiBz
dXBwb3J0IGxvZ2ljIHN0aWxsIG1pc3Npbmc/DQo+IE5vLCB0aGV5IGFyZSBub3QgZXhwb3NlZCB5
ZXQgYW5kIHlvdSBrbm93IHRoYXQuDQo+IEkgd2lsbCB1cGRhdGUgdGhlIGNvbW1pdCBtZXNzYWdl
DQpCVFcsIGFsbCB0aGlzIHdvcmsgaXMgYWJvdXQgYWRkaW5nIHZwY2kgZm9yIGd1ZXN0cyBhbmQg
b2YgY291cnNlIHRoaXMNCmlzIG5vdCBnb2luZyB0byBiZSBlbmFibGVkIHJpZ2h0IGF3YXkuDQpJ
IHdvdWxkIGxpa2UgdG8gaGVhciB0aGUgY29tbW9uIGFjY2VwdGFibGUgd2F5IG9mIGRvY3VtZW50
aW5nIHN1Y2gNCnRoaW5nczogZWl0aGVyIHdlIGp1c3Qgc2F5IHNvbWV0aGluZyBsaWtlICJBIGd1
ZXN0IGNhbiByZWFkIGFuZCB3cml0ZSINCmVsc2V3aGVyZSBvciB3ZSBuZWVkIHRvIGludmVudCBz
b21ldGhpbmcgbmV1dHJhbCBub3QgZGlyZWN0bHkgbWVudGlvbmluZw0Kd2hhdCB0aGUgY2hhbmdl
IGRvZXMuIFdpdGggdGhlIGxhdGVyIGl0IGFsbCBzZWVtcyBhIGJpdCBjb25mdXNpbmcgSU1PDQph
cyB3ZSBkbyBrbm93IHdoYXQgd2UgYXJlIGRvaW5nIGFuZCBmb3Igd2hhdCByZWFzb246IGVuYWJs
ZSB2cGNpIGZvciBndWVzdHMNCj4+PiBJbiBvcmRlciB0byBwcmV2ZW50IGEgZ3Vlc3QgZnJvbSBy
ZWFkcyBhbmQgd3JpdGVzIGZyb20vdG8gdGhlIHVuaGFuZGxlZA0KPj4+IHJlZ2lzdGVycyBtYWtl
IHN1cmUgb25seSBoYXJkd2FyZSBkb21haW4gY2FuIGFjY2VzcyBIVyBkaXJlY3RseSBhbmQgcmVz
dHJpY3QNCj4+PiBndWVzdHMgZnJvbSBkb2luZyBzby4NCj4+IFRhbmdlbnRpYWwgcXVlc3Rpb246
IEdvaW5nIG92ZXIgdGhlIHRpdGxlcyBvZiB0aGUgcmVtYWluaW5nIHBhdGNoZXMgSQ0KPj4gbm90
aWNlIHBhdGNoIDYgaXMgZ29pbmcgdG8gZGVhbCB3aXRoIEJBUiBhY2Nlc3Nlcy4gQnV0IChnb2lu
ZyBqdXN0DQo+PiBmcm9tIHRoZSB0aXRsZXMpIEkgY2FuJ3Qgc3BvdCBhbnl3aGVyZSB0aGF0IHZl
bmRvciBhbmQgZGV2aWNlIElEcw0KPj4gd291bGQgYmUgZXhwb3NlZCB0byBndWVzdHMuIFlldCB0
aGF0J3MgdGhlIGZpcnN0IHRoaW5nIGd1ZXN0cyB3aWxsIG5lZWQNCj4+IGluIG9yZGVyIHRvIGFj
dHVhbGx5IHJlY29nbml6ZSBkZXZpY2VzLiBBcyBzYWlkIGJlZm9yZSwgYWxsb3dpbmcgZ3Vlc3Rz
DQo+PiBhY2Nlc3MgdG8gc3VjaCByL28gZmllbGRzIGlzIHF1aXRlIGxpa2VseSBnb2luZyB0byBi
ZSBmaW5lLg0KPiBBZ3JlZSwgSSB3YXMgdGhpbmtpbmcgYWJvdXQgYWRkaW5nIHN1Y2ggYSBwYXRj
aCB0byBhbGxvdyBJRHMsDQo+IGJ1dCBmaW5hbGx5IGRlY2lkZWQgbm90IHRvIGFkZCBtb3JlIHRv
IHRoaXMgc2VyaWVzLg0KPiBBZ2FpbiwgdGhlIHdob2xlIHRoaW5nIGlzIG5vdCB3b3JraW5nIHll
dCBhbmQgZm9yIHRoZSBkZXZlbG9wbWVudA0KPiB0aGlzIHBhdGNoIGNhbi9uZWVkcyB0byBiZSBy
ZXZlcnRlZC4gU28sIGVpdGhlciB3ZSBpbXBsZW1lbnQgSURzDQo+IG9yIG5vdCB0aGlzIGRvZXNu
J3QgY2hhbmdlIGFueXRoaW5nIHdpdGggdGhpcyByZXNwZWN0DQpSb2dlciwgZG8geW91IHdhbnQg
YW4gYWRkaXRpb25hbCBwYXRjaCB3aXRoIElEcyBpbiB2Nz8NCj4+PiAtLS0gYS94ZW4vZHJpdmVy
cy92cGNpL3ZwY2kuYw0KPj4+ICsrKyBiL3hlbi9kcml2ZXJzL3ZwY2kvdnBjaS5jDQo+Pj4gQEAg
LTIxNSwxMSArMjE1LDE1IEBAIGludCB2cGNpX3JlbW92ZV9yZWdpc3RlcihzdHJ1Y3QgdnBjaSAq
dnBjaSwgdW5zaWduZWQgaW50IG9mZnNldCwNCj4+PiAgICB9DQo+Pj4gICAgDQo+Pj4gICAgLyog
V3JhcHBlcnMgZm9yIHBlcmZvcm1pbmcgcmVhZHMvd3JpdGVzIHRvIHRoZSB1bmRlcmx5aW5nIGhh
cmR3YXJlLiAqLw0KPj4+IC1zdGF0aWMgdWludDMyX3QgdnBjaV9yZWFkX2h3KHBjaV9zYmRmX3Qg
c2JkZiwgdW5zaWduZWQgaW50IHJlZywNCj4+PiArc3RhdGljIHVpbnQzMl90IHZwY2lfcmVhZF9o
dyhib29sIGlzX2h3ZG9tLCBwY2lfc2JkZl90IHNiZGYsIHVuc2lnbmVkIGludCByZWcsDQo+Pj4g
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBpbnQgc2l6ZSkNCj4+IFdh
cyB0aGUgcGFzc2luZyBhcm91bmQgb2YgYSBib29sZWFuIHRoZSBjb25zZW5zdXMgd2hpY2ggd2Fz
IHJlYWNoZWQ/DQo+IFdhcyB0aGlzIHBhdGNoIGNvbW1pdHRlZCB5ZXQ/DQo+PiBQZXJzb25hbGx5
IEknZCBmaW5lIGl0IG1vcmUgbmF0dXJhbCBpZiB0aGUgdHdvIGZ1bmN0aW9ucyBjaGVja2VkDQo+
PiBjdXJyZW50LT5kb21haW4gdGhlbXNlbHZlcy4NCj4gVGhpcyBpcyBhbHNvIHBvc3NpYmxlLCBi
dXQgSSB3b3VsZCBsaWtlIHRvIGhlYXIgUm9nZXIncyB2aWV3IG9uIHRoaXMgYXMgd2VsbA0KPiBJ
IGFtIGZpbmUgZWl0aGVyIHdheQ0KUm9nZXIsIHdoYXQncyB5b3VyIG1haW50YWluZXIncyBwcmVm
ZXJlbmNlIGhlcmU/IEFkZGl0aW9uYWwgYXJndW1lbnQNCnRvIHZwY2lfcmVhZF9odyBvZiBtYWtl
IGl0IHVzZSBjdXJyZW50LT5kb21haW4gaW50ZXJuYWxseT8NCg0KVGhhbmsgeW91LA0KT2xla3Nh
bmRy


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 08:07:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 08:07:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267647.461386 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHLWj-0003O2-L5; Tue, 08 Feb 2022 08:07:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267647.461386; Tue, 08 Feb 2022 08:07:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHLWj-0003Nv-I2; Tue, 08 Feb 2022 08:07:05 +0000
Received: by outflank-mailman (input) for mailman id 267647;
 Tue, 08 Feb 2022 08:07:04 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1FiY=SX=epam.com=prvs=40383cc40e=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nHLWi-0003Np-Cg
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 08:07:04 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 179122a4-88b6-11ec-8eb8-a37418f5ba1a;
 Tue, 08 Feb 2022 09:07:01 +0100 (CET)
Received: from pps.filterd (m0174678.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 2187LXe3005776;
 Tue, 8 Feb 2022 08:06:58 GMT
Received: from eur05-am6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2113.outbound.protection.outlook.com [104.47.18.113])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e3m2cg59s-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Tue, 08 Feb 2022 08:06:58 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AS8PR03MB6853.eurprd03.prod.outlook.com (2603:10a6:20b:23e::7)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Tue, 8 Feb
 2022 08:06:54 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77%3]) with mapi id 15.20.4951.019; Tue, 8 Feb 2022
 08:06:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 179122a4-88b6-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=dGhhjEl03bpK8yDFzAnWTrz5mCFThOW7Ey22Boue175fXNsO5yMJxuYAiibwucOrvxsuRVahPbkZ0KkJRW8WLKlUGRoqk8B6rsgwEC333HFlgcgXAoLesWMNxadwPnCJSyF3eMRfqtEzkZ6y/NXdERghacKUEq2y8r8gfsG3J3FZxX12wgGN3sZdJnSQ/RKFd1qpZl3NKZdOPCiWIl95PdOvPpTWhVhYHgcV3zNAKn/Jel56cTM/EG6CNn/XwBQU9+XJP/y3mooJ4NV8iM7+1nZr0jbd8l7FU+n8YQgq6qwm50kawBN9ifH2J7vjxaKjwCw1YJtzZEIj1xdw/xT3gg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=WOppeeF7lJW9AgRbC1oJFoap/cAQXccHD6FCmvHzk7g=;
 b=UD++qDNa1+6QxezPjVfGc5I8E6djBpCwchUN4+x/woEabW/6LITQANhShbwul1jqVwlESa1n0Onf9aeI7q3Ab1fsZh+gEGYuSZg3mISd2gSSPSsrOinuFuU5r3dMiyasOQdCQyE8qdfSP4VS7cBrAueuST0P5gAbx/TbDj6niD5EJN2lmFCo+htikjS4deHnuITcXw3kGficjCEyKe9Bx3I7ksc+QXtrBqDzh2PSePCc6ttnVlLpcJoJ2H+wZTINqrgs+fYtJuZ9sF0V9NaVEpWW/S5aZYUs1PvtPT0UR+SWrBf0ISP27eoWUFKO3gaH6skGlXo3G9YZCgF6eRKs7g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=WOppeeF7lJW9AgRbC1oJFoap/cAQXccHD6FCmvHzk7g=;
 b=L7rs6cRpy4a8DQGTyKxeFykw57NnTZbNybbj6NbRFZTQ/cd20TvB5BjaX0hTe6Cj0C2VOKyRKSy3NbOsH//LT2bnrzs41okLjoYopN6nR9InxpFrblfLcNPGmUmTz5v/6Qrb7TKw60qja93fRzWrWj8+k2g8bZ/Lm2bPwpbh2fhHYCRfsvOgWjeWGfrQbP/u2cEd4/3CnP3YLZCG/irwCHkdHDCClYElnoy+keb+Pa8apHsGn6wYlBBEUWNTvzkK84OzqSpg4l+uAU8y8GQygv2I4bhiPFAHuSuGdaV0cjndAdFMCKoarpfHW5psDOpe1wPwj4C/ILvDgC4IdJpd1Q==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "roger.pau@citrix.com" <roger.pau@citrix.com>,
        "andrew.cooper3@citrix.com"
	<andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com"
	<george.dunlap@citrix.com>,
        "paul@xen.org" <paul@xen.org>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>,
        Rahul Singh <rahul.singh@arm.com>,
        "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        Oleksandr
 Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v6 06/13] vpci/header: implement guest BAR register
 handlers
Thread-Topic: [PATCH v6 06/13] vpci/header: implement guest BAR register
 handlers
Thread-Index: AQHYGZFd6D+qnME8W0+wTH+v8YZ8DayIVt4AgAD7qYA=
Date: Tue, 8 Feb 2022 08:06:54 +0000
Message-ID: <66992013-f438-246b-451d-d96f6eea22c0@epam.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-7-andr2000@gmail.com>
 <61d85343-9a37-6409-449d-a662ae5258c5@suse.com>
In-Reply-To: <61d85343-9a37-6409-449d-a662ae5258c5@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: e97eb72d-50c9-49a4-8cd9-08d9ead9f860
x-ms-traffictypediagnostic: AS8PR03MB6853:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AS8PR03MB68530D910C75B79ACE7D0793E72D9@AS8PR03MB6853.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:4941;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 Gp5VNZHkHpTd3ayonkU7Csq1GC0zRaUYLvenyhTjWD+AJzx6O5/q8QYvxzgEi1QUiQg3dIox/EMKdM/Z3WL0AYf7ZUurF9MnRIi0Kn7M6iBKDM86y18ZqCxOhCsft/YMWfdRt3RL7gzcwUczLYmCi/kNwjJn+UoZyLkOx76wGMrjndFchoeDbj56W3b9KdWEPRtUw64XilwHF7gYYnefYou1LguRkkvnFzNd8d/oUPMi6WotJkDicSyAQET0ic5EYNaMPayPlpOqYf+UpzdtVYtfi7TWfFuNAs90Ec95zw6CaPnkNrcTtmbAFZ/U1yGFx+B1jrj9LxWq/ZMaX7l+ka7Jl/2ZDBCmMsEb7HSIuHcVikB3JAovdIzz/8uwT4w+/OOavz6B88B6eAAL5fi5m1rIj+LZPRFJwH7p6A+BteqZQA9fuG7sXJDtQP4O9DDdtw84tAL8xqsVhYe7bd9v4+KlJEwEs+siqydD/XeuLNUCO8TgRqdfGWvLlD7RhT9j0DFX/6LXwNg7ZL6OshS6b6mopJ9y09GHE+4Foy7J2gFnQTU7vGxfTAupzNGiJMYFhLyHm3xuLnV/GZU1WY2xjnvLlYua+miJauleWjSmaHAqOrw3Gbv37framXI/0zpy1KMfDIqkonQ5iDYjPAS1k/SccDjb/7jxbusUsJPKHiCFQORJk20TdfRfERRew7QFyqlvJS8zLMhITg77LMFHSuqdx8+clqwqpV2M7dYn5yZ57gYCcS6FnN+GB60P12LQ
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(107886003)(26005)(31686004)(53546011)(8676002)(36756003)(64756008)(6506007)(8936002)(76116006)(66946007)(91956017)(6512007)(86362001)(508600001)(83380400001)(186003)(66446008)(71200400001)(66556008)(66476007)(2616005)(7416002)(5660300002)(31696002)(4326008)(54906003)(316002)(2906002)(6486002)(55236004)(38070700005)(122000001)(6916009)(38100700002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?NUpuVTlUNW56RGRDZlAzb0wvajVQS1hHS2lTLzdOcXhwM2hJaGxFWEZqYmw1?=
 =?utf-8?B?bTZpcnV1Y2hCSy9rY1NqZjZXOWEvZi8wUWt5VjdNRE1JRFNnZ0l4SDVSTURC?=
 =?utf-8?B?dEZucTRtb2tHNjV0NFMrRTF4SE8zNXFyUG9LUk9oNDNSQi9aSm55WnJrNU5y?=
 =?utf-8?B?S1pTM3NDZ2ZBMHpLTlNvOWVUME51TjFRcDJsZG5jVFd6Y2QzWW1LbVp6YTla?=
 =?utf-8?B?OU9GTjVCYXU1SGJ3SHdjMmNPakp2cVFHQnJxT0s1Q2ViclFpWXNudU53Zkd3?=
 =?utf-8?B?RUJrdWJqWjBtV290emc1OGR1WjJhZWV6M0FKMnkwQnZ0aWpUU2pUZWZncG1n?=
 =?utf-8?B?MWRsdFV6WHNab1p5M0ZTUlk4RDJ3TytsTC9sSnJ2TEI2MEpkSE9ZRGNBZzk2?=
 =?utf-8?B?Y3BCNjhsUXoxYktzWTFMdG9zN2hpdGZicUZCTG1taHk2WkY3eEQxMG5lUXQ3?=
 =?utf-8?B?bXBYVkV6L21FNmdaOHZsb2kvVnRVbGkvN1kzNjZtQm9qQ09iQlZBRldidWhK?=
 =?utf-8?B?cDA2STlrb3gxSkdyL25GRGxVM3M0K3J5MXpRUmh3QmpscXJiUlJFQ2ZLNXhN?=
 =?utf-8?B?NXNnWEIzcm9pVzdZcUJrUGtDcUo2WFg0RHptU1RQUkltNWk3R0tMdHp3Rncy?=
 =?utf-8?B?bDc5YnNPTDlBL2l6TnMxRnhrMDJHOGR2S3ZtT1h1a1Fkamh2ci80UDVVQlNC?=
 =?utf-8?B?cm5oOG15SXZhK25PWTU4M3FpbWhGQWo0dlQwdzJRSkJvQWxUOGsrbzZpWjVR?=
 =?utf-8?B?TW11T3VTS29aVXM5bkRUNDdwUU5raXFubXRWOTdZbkhaazBaLzgxNHk1N1Zw?=
 =?utf-8?B?N0l1bDFtcGgycTk2Sk9Td3g2aVVVZVppTFdpKzBHYUtzbElWMFBtN1J5MU43?=
 =?utf-8?B?SytQT3FKaEwwbkJFNFczandZVnlhbjU0TGY4eXpHa3VIN0xVZDU3OUFnZjFm?=
 =?utf-8?B?eUIzd0ZzeUp1ZDNBbERpYWltcmRFbzU3d3R1Qmw1S3RUb3Vzeks2ZVdrNTE5?=
 =?utf-8?B?MzNOVU1udzVkY1FUSVJqZDhWYk9CUUtlcG5xR2dmV2ZFbUFtd1pXQUQvbjlZ?=
 =?utf-8?B?R3lOQmd5Nk9meDZvVXpJNk8zd0NYYzJtbXdwQjRqZTljMThqNWc4NUI1bVNY?=
 =?utf-8?B?VkdDSzFzZFk3TkZGdlFNNFdYck1yN1VMMXBvTHVrSXpXbVlISVo4U1RLSlpS?=
 =?utf-8?B?OUZiZ1hxSWZId21yWndGN21FSXJWay8wRzVQZnIrbFRBVmdVYlBVWU16eFNI?=
 =?utf-8?B?M3JyS2NKSWJCaEF0QlcwdUtMSWJ4UWNNSHZjekZpODIzRXNBSDdKVnNPaHNZ?=
 =?utf-8?B?bk0yTWl1bDF0Q25wZHA0RkxDVjIwRlZ1WXVOeEpYMDdKTTZXcHBLV1ZvVXE0?=
 =?utf-8?B?TXU1SStMVFlaVmw3OCt1ZkxLN2dQMjVWSFNpQ2E4WlRSZjZ0R0pDcE1xbnV6?=
 =?utf-8?B?TU1RZUdmc0pJbEVOQ1RDM3N6eUU5VzBURjVoTE8vOWRaVFFLNXdNaEZxUDJ1?=
 =?utf-8?B?S3hlOTFOTVNaVjVObURVWE9zcFVnQkxSOFRZZDNLMENQU0JZeTFsR1NMeXFi?=
 =?utf-8?B?QUJ5YWJJSStydVF2Q3ZsSUs4WTVKVzMyUENPVU5UUy9RNTJucjQwbldFa0Vr?=
 =?utf-8?B?S0kwVlJWSnIyZXNSTXkxYUhxemdPZXBYbnVqQkNRdkVRN0xjVmRlZlRNRFYy?=
 =?utf-8?B?L3ZHYXB3d3BPZTlhTXJudDdSeGxzaWlIanpPV3hGa2JSRzNjRzdQVjRMcWdD?=
 =?utf-8?B?aWhzdjdVVlJRMFB1bmFqczlGTXZlTFg3YXpUMkNzOFlENzdaeVZkaXduaEJw?=
 =?utf-8?B?UW4wR0hMTkJ2dXN6cnc4ZXhOTEdNN2ZvQTJ2OTZ6VU9hb2hsMlljdHE5Wmk4?=
 =?utf-8?B?VzJDWUdjbm1UZjRQZDNLcTcxUm9CM1hTbEhSb1JFckQ2cVplN0dqdFdZTjh2?=
 =?utf-8?B?QTZuMFVMZDVBSWVSc3Y0Y3ljdE1oM0FqSUw2QXV4R3pvMzN3QjQvSkhreFNi?=
 =?utf-8?B?eWZ4N3V0dk91Um9tT29tMHJHa21NbWdZRlI3MGJSZ3JzMXdiUlE3VEd5TE8z?=
 =?utf-8?B?WktyOGtQV3BvNEt1NGc5L005cWU3elZidGNHbjEwVzFiZllmTUhwdGxKSzc2?=
 =?utf-8?B?UDVkZWJ1NHFTaGVoL2Fwa2tuQ1NWTGcxNEhvRC9qWTBneFdIWEliNjloRjlL?=
 =?utf-8?B?cmhpMVRvVys2MGtCM1JOejRiVjdjcWpIRjJ5ZjVMcDQ4UG40S2MxY2ZKdU5I?=
 =?utf-8?B?TWIybmJUTlVhSWxhS1k0SDhUSDNHSkVXRnhtSFMzTC85QjVZd0VJQXFsMXow?=
 =?utf-8?B?YVNqY01ja05Zb0lubm9JV1FxdFREM1NFNE1Cdk44dFd4Mm45cG9pcU13MkxS?=
 =?utf-8?Q?YV2o1t36MRa4Df2s=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <FBF4676D0F96FA48A371CF7F443F69CA@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e97eb72d-50c9-49a4-8cd9-08d9ead9f860
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2022 08:06:54.4109
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: WoCL5v/RDnGFP8Cd9OVs1s7YT9PBmqmHW0aD+pLcNOpSwpcT0Vpa3zki8fnyO9m6LTmGKxqMoqFBkPazwTGf85T8jNRE6avK7Yx/ySlzGmNeIlv55jLVBYJBhHh5LPxz
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR03MB6853
X-Proofpoint-GUID: 2QKAIB8pUn5Ls55dh079If4wnwX5yq1C
X-Proofpoint-ORIG-GUID: 2QKAIB8pUn5Ls55dh079If4wnwX5yq1C
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-08_02,2022-02-07_02,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501
 bulkscore=0 adultscore=0 suspectscore=0 clxscore=1015 lowpriorityscore=0
 phishscore=0 mlxscore=0 malwarescore=0 spamscore=0 mlxlogscore=976
 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202080043

DQoNCk9uIDA3LjAyLjIyIDE5OjA2LCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMDQuMDIuMjAy
MiAwNzozNCwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+PiArc3RhdGljIHVpbnQz
Ml90IGd1ZXN0X2Jhcl9pZ25vcmVfcmVhZChjb25zdCBzdHJ1Y3QgcGNpX2RldiAqcGRldiwNCj4+
ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGludCByZWcs
IHZvaWQgKmRhdGEpDQo+PiArew0KPj4gKyAgICByZXR1cm4gMDsNCj4+ICt9DQo+PiArDQo+PiAr
c3RhdGljIGludCBiYXJfaWdub3JlX2FjY2Vzcyhjb25zdCBzdHJ1Y3QgcGNpX2RldiAqcGRldiwg
dW5zaWduZWQgaW50IHJlZywNCj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0cnVj
dCB2cGNpX2JhciAqYmFyKQ0KPj4gK3sNCj4+ICsgICAgaWYgKCBpc19oYXJkd2FyZV9kb21haW4o
cGRldi0+ZG9tYWluKSApDQo+PiArICAgICAgICByZXR1cm4gMDsNCj4+ICsNCj4+ICsgICAgcmV0
dXJuIHZwY2lfYWRkX3JlZ2lzdGVyKHBkZXYtPnZwY2ksIGd1ZXN0X2Jhcl9pZ25vcmVfcmVhZCwg
TlVMTCwNCj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJlZywgNCwgYmFyKTsNCj4+
ICt9DQo+IEZvciB0aGVzZSB0d28gZnVuY3Rpb25zOiBJJ20gbm90IHN1cmUgImlnbm9yZSIgaXMg
YW4gYXBwcm9wcmlhdGUNCj4gdGVybSBoZXJlLiB1bnVzZWRfYmFyX3JlYWQoKSBhbmQgdW51c2Vk
X2JhcigpIG1heWJlPyBPciwNCj4gY29uc2lkZXJpbmcgd2UgYWxyZWFkeSBoYXZlIFZQQ0lfQkFS
X0VNUFRZLCBzL3VudXNlZC9lbXB0eS8gPyBJJ20NCj4gYWxzbyBub3Qgc3VyZSB3ZSByZWFsbHkg
bmVlZCB0aGUgaXNfaGFyZHdhcmVfZG9tYWluKCkgY2hlY2sgaGVyZToNCj4gUmV0dXJuaW5nIDAg
Zm9yIERvbTAgaXMgZ29pbmcgdG8gYmUgZmluZSBhcyB3ZWxsOyB0aGVyZSdzIG5vIG5lZWQNCj4g
dG8gZmV0Y2ggdGhlIHZhbHVlIGZyb20gYWN0dWFsIGhhcmR3YXJlLiBUaGUgb25lIGV4Y2VwdGlv
biBtaWdodA0KPiBiZSBmb3IgZGV2aWNlcyB3aXRoIGJ1Z2d5IEJBUiBiZWhhdmlvciAuLi4NCldl
bGwsIEkgdGhpbmsgdGhpcyBzaG91bGQgYmUgb2ssIHNvIHRoZW4NCi0gcy9ndWVzdF9iYXJfaWdu
b3JlX3JlYWQvZW1wdHlfYmFyX3JlYWQNCi0gcy9iYXJfaWdub3JlX2FjY2Vzcy9lbXB0eV9iYXIN
Ci0gbm8gaXNfaGFyZHdhcmVfZG9tYWluIGNoZWNrDQo+DQo+PiBAQCAtNTE2LDYgKzU5NCwxMSBA
QCBzdGF0aWMgaW50IGluaXRfYmFycyhzdHJ1Y3QgcGNpX2RldiAqcGRldikNCj4+ICAgICAgICAg
ICBpZiAoICh2YWwgJiBQQ0lfQkFTRV9BRERSRVNTX1NQQUNFKSA9PSBQQ0lfQkFTRV9BRERSRVNT
X1NQQUNFX0lPICkNCj4+ICAgICAgICAgICB7DQo+PiAgICAgICAgICAgICAgIGJhcnNbaV0udHlw
ZSA9IFZQQ0lfQkFSX0lPOw0KPj4gKw0KPj4gKyAgICAgICAgICAgIHJjID0gYmFyX2lnbm9yZV9h
Y2Nlc3MocGRldiwgcmVnLCAmYmFyc1tpXSk7DQo+PiArICAgICAgICAgICAgaWYgKCByYyApDQo+
PiArICAgICAgICAgICAgICAgIHJldHVybiByYzsNCj4gRWxzZXdoZXJlIHRoZSBjb21tYW5kIHJl
Z2lzdGVyIGlzIHJlc3RvcmVkIG9uIGVycm9yIHBhdGhzLg0KT2ssIEkgd2lsbCByZXN0b3JlDQo+
DQo+IEphbg0KPg0KVGhhbmsgeW91LA0KT2xla3NhbmRy


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 08:13:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 08:13:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267658.461397 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHLdE-0004qM-ET; Tue, 08 Feb 2022 08:13:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267658.461397; Tue, 08 Feb 2022 08:13:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHLdE-0004qF-BZ; Tue, 08 Feb 2022 08:13:48 +0000
Received: by outflank-mailman (input) for mailman id 267658;
 Tue, 08 Feb 2022 08:13:47 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1FiY=SX=epam.com=prvs=40383cc40e=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nHLdD-0004q9-2E
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 08:13:47 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 087803a4-88b7-11ec-8eb8-a37418f5ba1a;
 Tue, 08 Feb 2022 09:13:45 +0100 (CET)
Received: from pps.filterd (m0174677.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 2187D1mT022166;
 Tue, 8 Feb 2022 08:13:42 GMT
Received: from eur04-he1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2054.outbound.protection.outlook.com [104.47.13.54])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e3kc2rbgq-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Tue, 08 Feb 2022 08:13:42 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by PA4PR03MB6927.eurprd03.prod.outlook.com (2603:10a6:102:ee::7) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Tue, 8 Feb
 2022 08:13:38 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77%3]) with mapi id 15.20.4951.019; Tue, 8 Feb 2022
 08:13:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 087803a4-88b7-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=B0sgjKu+24e50whOrTleAJBoD/OgU3Hdfk/fh5A3YnddLRuhLTVn4tUfcbtPCt+4YfiMQzAT6b0lVcJYm6h2/shgLw6uL0NUf05IdIKaXMz5Ot6eg1R7xcmIG1413Kivh6R7yKgSshxVitWtTzRgpET1NFgOhmmsS33/lOoPokVqlTOSh4f9eBLV7/TLO6CH8mCnUwjIZxc00c9HPdBzPrd8/ZSkFC7pi7sDoeJ9ht/7Tm6THxr4zEdcNE9xIle6kOJ13LlwYd0+MLANCtKkVoy0dclMcbgwCVxwQvieNh9LYkDTLdLzoKBFp0RIrMGDFna4HRFgMmoWrUYKkChkew==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=D8ch4WfXor1N/AUY7DVD+/V13wWWbKYKrQu3rRj8EQc=;
 b=lCDAph4BlBnUntnvY5U1+pGoJonkFWCXGalZldnM4i5Mk79TG2/4CPy8hcKeRm2lZ67CzPFGAOt72Tqha2EPULuT01SB1GkDZ5Q24X3uaKO1uZsYbm0Z29InXwmoPKTvoF0UINVKAmGljoc2tnzxdPXhB4BUTDY4zDvP6HClYygLQ6wR+d0OFVXoHC1Zbt8Uc7zOftUFk2Xw0BnExgHwY9xkVuvufyJtW0bmVuIMShI3yPytY9OTcnPzbhD5gdrOPRaIbJSZDym77TMVY5uZLWfHHgsHWYD2ufvvpf6U7T/uKs66gI0/maYc1PRA8LD1c/FdIh8qiBVeIqSGLjqmoA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=D8ch4WfXor1N/AUY7DVD+/V13wWWbKYKrQu3rRj8EQc=;
 b=Gaw3iEdlYwpXTJ3MruS2d8PgxQjQIEpkFDHqHgOFsPwJUGfIwnGKYu5h160D3j2EotqqZqRgNyuar9k4jXie/BPE7UaMeYskmtLk8VOCa4WkyVY4+vPOdYHdQIPJ4S4QRbYVddvWfTKTIZH07t8DpI45RAiLdB9FvLaYyqtcg0xV1m3UcamsuZjBalyYff9A76nvBP2YsdaykQ48anJJZBejSToKhE58+MzDvjUlxKTEbhR3F/7Zg3DXb8ZbGoDRWhlIEeqZ4HE9/R1acsvaaK8EkaIkvv2hsroymZbXSEIaqzeqBlZVWsumab/h8echvWsVrHjur6IOuepY+zv6+Q==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "roger.pau@citrix.com" <roger.pau@citrix.com>,
        "andrew.cooper3@citrix.com"
	<andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com"
	<george.dunlap@citrix.com>,
        "paul@xen.org" <paul@xen.org>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>,
        Rahul Singh <rahul.singh@arm.com>,
        Oleksandr
 Andrushchenko <Oleksandr_Andrushchenko@epam.com>,
        "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v6 09/13] vpci/header: emulate PCI_COMMAND register for
 guests
Thread-Topic: [PATCH v6 09/13] vpci/header: emulate PCI_COMMAND register for
 guests
Thread-Index: AQHYGZFfEau2yoVfs02TXHZP7JM5E6yDcw0AgAXhW4A=
Date: Tue, 8 Feb 2022 08:13:37 +0000
Message-ID: <0ff2a524-9a65-861a-df87-cf3f682862d7@epam.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-10-andr2000@gmail.com>
 <7df2379e-1c30-c362-3106-c7ef23af5c73@suse.com>
In-Reply-To: <7df2379e-1c30-c362-3106-c7ef23af5c73@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: e761a04a-3111-4037-b0ca-08d9eadae8e0
x-ms-traffictypediagnostic: PA4PR03MB6927:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <PA4PR03MB6927762135C3FAAFE0286EA2E72D9@PA4PR03MB6927.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 1esZIxf2jY306GdXGS7sKyy7/PJX0kjKrBj61jWlX0KLTPxzi/XuFai1LAxFe9xrBibbTVzrZExVwP87skN37HTOEiU814tNSD7NKlXaVBSPDEXCsCmPu3JeX0AZXyDrwE7CAQ2MweFpEmwpNP9uJe13GPYlV57Gq6aMYSY7AfXeM7dmC7t3GeuNd2Osw9vm9k/mTY4IbYVweeYduAyQ6kSt1UHhmmNn4uiMG7OGFiIJF9CpbiOVbu/MbcAqFoqiIMYFsIbSq6zmM9EuC8kWTPJ6sKIZwQ+md+wQPNLTJc7hcwgeIjLXMEmnN1f/h1bGIVHwFmB3PhAbVZBvmqQQpXRWJhaIxBR1MXTaXN07TUj19kWotUz9ZbXJd5Hk4wornTEkGD3D0ZeqDIZHLJh3t/LOWXWNHxw2+U+0uZY/O+8f/W/gHcxC42GNfmb/dMjV8xY/CCk8AVQmT+/0jmk4NZ0ij9+QvWhBBjj2cG1AQhWv4IMrMoChIaDvcrjNgeHDfIvvCSZByttJRcmapU2aoGZWPN3T6VC1iOFt86q/q5BTsIPIoPwN35dg8T90y9RST4fcrqVwfQgqKFJ0QHaf9Y1RxfhiKmMFl+Zqd1c07btfwWOiZgz4sSxwaPfacbu9L6/VNxAbORJAYCcygUhMsIilie05LcQwBYqtCysiQkkLWjz6/WfdzR6BEXrM2Ef6ACcCwToOKEBlChPN8OJtMra/G1+83DcCPs6rrRKo8TDKACh7DUA6yr6zjliw8HVh
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66446008)(7416002)(83380400001)(122000001)(31686004)(66556008)(66476007)(64756008)(5660300002)(38070700005)(6506007)(91956017)(36756003)(76116006)(316002)(6916009)(54906003)(86362001)(6486002)(71200400001)(508600001)(53546011)(55236004)(38100700002)(8676002)(2616005)(4326008)(2906002)(8936002)(66946007)(186003)(26005)(6512007)(31696002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?YjhFVGhWaTdDcVozMjhVUURNUTA4a3MzY1YycFBvOFRjbSs5Tm13MzlyeGVn?=
 =?utf-8?B?eFJiM1Rrdnd3Q25Bby9iL2M5RDNFdEZIU3d4eGlxeXM4aEQyd3VMTHQ3WVJk?=
 =?utf-8?B?NEhhdXlNaUowc21YUEtTRkprd2RXeFBrZXpqT09DRHBTZVg5MGhObDhEOTZW?=
 =?utf-8?B?ckZKaU9YNU1nYWdjbWp4NzBLa1BKbnVuT1lUUjk1VjUrdytxV3FReFF6MUNH?=
 =?utf-8?B?MzBEQm9GNWJiNnY0L3NWVWFEd3lvaHZIby9UaW1tQ3Q3OGF0REU3QTBreVZu?=
 =?utf-8?B?dTZ3czdQWDNDYWxGRzVWcHIyZk4wV3lvTFMrUlZuckpwbjNwaGpFalNIUURO?=
 =?utf-8?B?U3B5WDMyUGtZRHRzMER6MmhUaEowaWpUN3E2WnAzRCsrRUpEeHNnYlhPRVQ0?=
 =?utf-8?B?WlAwOXhqKzVIb1phNlpjRmRKaS96TlFERVNyelRRaXBCRVZkT29RN0dmNGty?=
 =?utf-8?B?NXFtZEdRQW9QS0hBRlJoRnE0aUxvUGZzM3hHcU96MmtUSTJ3NVArNDdheTVW?=
 =?utf-8?B?TWdLblZ4Y0U1KzN3cjhzbGhFYUdlTEJYeU9OenFDQWtUOVZEQkxBd2k3ZWxy?=
 =?utf-8?B?V3BPVVpWbHhoVzdBaHZ4MGdoUEpNKzh3L3pTcTA2RUpnb0Z0VVZMK0dyQjZn?=
 =?utf-8?B?SXRGSmxmNkhGS05CYW53Q3IycnZZckQzbVlxM2N6elN4eHV1RUh3NXpKdmR2?=
 =?utf-8?B?a2phMjhaQUNkT0N4R2gzbnNYeWFHcmJ6cGxNN0NodTJ3blJJRGlwNkhvcGZH?=
 =?utf-8?B?ZXpKaHhTeTJPQTlobkdJVXZJL0lYU0NxZlMrdlV3N1RiaXBQMjU5c0ZHS1Rv?=
 =?utf-8?B?dzk0Z3RxbVRMWVJDY1RDdmRXdzFhNUJJSG9ERHhhcjI1eTZUVGNxUUVlODBw?=
 =?utf-8?B?WFZtbm1nakI0cXZKZUFtTVhkRFV3Q0ZjZlNyRDBZVlJqOUJISEpLcHdUbzIx?=
 =?utf-8?B?cXZtWDZ0VnVBRmJZN0lPVlVVelQ0RmRpbnpIa3I0NEhpbUhQZ3ZYcWNTaGNr?=
 =?utf-8?B?SzJjMjFRQmJIRGRDVjRzRkcxeWtiNHZkbGVpRzBzOFkvakpNTFZqaXBtblkw?=
 =?utf-8?B?bFpRRmlaRFFNVjg1WGx2SGo5U2VrbWhUSE1Bei9Bb1V4SUwzWEpiR1lkZUlU?=
 =?utf-8?B?SmlYM3E4eG96amhBU3hZeXE1Sk9qc2tuaUNVR3BRQjR1MXlKLytmUll0a2pp?=
 =?utf-8?B?Z1Q2eTNNVG01alpmTUpWajRkOXE1TFNjMmFhNGxpSVMyTHpTcHpFOUxFTi9U?=
 =?utf-8?B?SVVaZE9pSGlQUnVkU0J0YUVFenlmMEN5Q2NIMUZzWHMyc21mUWtFRlJmTEtk?=
 =?utf-8?B?ZUFWcUpPZTlwZ3ppdEQxaFNXTlY5SDVNNDFoczBOL3Q5WHZXNlJnODc5bVky?=
 =?utf-8?B?Z0UxU1Nta1NHaGkzTnFrNGZFRk9URTVMYzFNSGM2bWovTHNSTUJoLzVkVTFq?=
 =?utf-8?B?ZmJ4OE5lVjhQY0NyRGkzcmlYcm9MSElXWDFGQ0hhN2R3RDRJTkhHdjdMNTFG?=
 =?utf-8?B?Zmo3TFZ1V04raFEyMUtZeEppTCtQTmZjL3M0OE5DbzRtWFkyL1RrbGQ2cHEy?=
 =?utf-8?B?STFYa2tCOGo3NDhSSlhIdkp2Sm5Pb2d2RFdRUmNHR2h6a2syNndJOG5MQVFD?=
 =?utf-8?B?Zm9oSFhSYnRqMkR2UjFGUGtGZGx4Qy9NZGNDNXB2aDlzSTVDQnF5cE4wSzh5?=
 =?utf-8?B?bk9FSERFUVlVdSs3Z1V5aGVucGxmSnowbm9jeG81K1BBY0YzUjlSaHE3aXNG?=
 =?utf-8?B?Y2p3L0ZndFF2d29uSFJEbGVCMkFmdmxoU3UweGkyMElXZXBRZWt3eGx5R2Nl?=
 =?utf-8?B?UDBXeGUyVjB6dDREQmNWQUNzb1psT2QyWWVIVFI1Zk9MUVZkcDhUVmtYVmlr?=
 =?utf-8?B?M05oS1B6TkdKMTBCbk5xa3U3RmRRK3BKWGxmdkdMbGM5bUpYYW55eTJhTjNR?=
 =?utf-8?B?Nk9zR3hwaXdNUldGWkJCbWt5Rzg2T0QwR2paeTRVeFNOcmdwVlNMbGNHNGtP?=
 =?utf-8?B?QWl2aitzMnVtT054emhNMENjWFhadldCUnZCbVo2MHd0Wkh6bXpUdmp2bzJB?=
 =?utf-8?B?RzRwbkVCR1ZvWHA4bllxcjlZdmExRFRnNlVkN2dzUjRpc0dRVUJjMmh1Mkp5?=
 =?utf-8?B?TzQwSzVUY1YzdnJjdzVCMmQ3SnJmY3U4UERXZDhBc1RyUGNYcEdXcVRkdms4?=
 =?utf-8?B?b01yQnhiS3hlQUR6clRFNHkzY1lTcHdORWxnc1gxdXZPZS9qV0xHZWUzUDRG?=
 =?utf-8?B?MHcvb3IrZmxEL3lVaDZ4OGwySXU2REdtM29Tbi9GMnlsVmxXdFJRNzNQSmVE?=
 =?utf-8?B?QWF3RlY5Z0xUKzhQT09xUEd6RUhidks0U0s4a2RDYnFYRytpMTM2SFFuV3Fm?=
 =?utf-8?Q?uhtrrEm/9MmDCs3w=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <91E3CA620D38A64BB7B121787C2D06C7@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e761a04a-3111-4037-b0ca-08d9eadae8e0
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2022 08:13:37.9351
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Bpp8iZnZjziBgRiFFSCv6nyX3Ioq+4Tivl2I+8uSwXERaWfV9+zARxVDNJ4/exEKp+iBGXXlXebd5I8IZ+3S5m3/zNlzAmmXTfd2LxhUoojZOmrQsAOOlT1+dZRqLEGR
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR03MB6927
X-Proofpoint-GUID: 93oHW9lRI-NApiXidVTyNbDlLxSdu2HG
X-Proofpoint-ORIG-GUID: 93oHW9lRI-NApiXidVTyNbDlLxSdu2HG
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-08_02,2022-02-07_02,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0
 lowpriorityscore=0 phishscore=0 priorityscore=1501 impostorscore=0
 mlxscore=0 mlxlogscore=874 adultscore=0 suspectscore=0 spamscore=0
 malwarescore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2201110000 definitions=main-2202080045

DQoNCk9uIDA0LjAyLjIyIDE2OjI1LCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMDQuMDIuMjAy
MiAwNzozNCwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+PiAtLS0gYS94ZW4vZHJp
dmVycy92cGNpL2hlYWRlci5jDQo+PiArKysgYi94ZW4vZHJpdmVycy92cGNpL2hlYWRlci5jDQo+
PiBAQCAtNDU0LDYgKzQ1NCwyMiBAQCBzdGF0aWMgdm9pZCBjbWRfd3JpdGUoY29uc3Qgc3RydWN0
IHBjaV9kZXYgKnBkZXYsIHVuc2lnbmVkIGludCByZWcsDQo+PiAgICAgICAgICAgcGNpX2NvbmZf
d3JpdGUxNihwZGV2LT5zYmRmLCByZWcsIGNtZCk7DQo+PiAgIH0NCj4+ICAgDQo+PiArc3RhdGlj
IHZvaWQgZ3Vlc3RfY21kX3dyaXRlKGNvbnN0IHN0cnVjdCBwY2lfZGV2ICpwZGV2LCB1bnNpZ25l
ZCBpbnQgcmVnLA0KPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICB1aW50MzJfdCBjbWQs
IHZvaWQgKmRhdGEpDQo+PiArew0KPj4gKyAgICAvKiBUT0RPOiBBZGQgcHJvcGVyIGVtdWxhdGlv
biBmb3IgYWxsIGJpdHMgb2YgdGhlIGNvbW1hbmQgcmVnaXN0ZXIuICovDQo+PiArDQo+PiArI2lm
ZGVmIENPTkZJR19IQVNfUENJX01TSQ0KPj4gKyAgICBpZiAoIHBkZXYtPnZwY2ktPm1zaS0+ZW5h
YmxlZCB8fCBwZGV2LT52cGNpLT5tc2l4LT5lbmFibGVkICkNCj4+ICsgICAgew0KPj4gKyAgICAg
ICAgLyogR3Vlc3Qgd2FudHMgdG8gZW5hYmxlIElOVHguIEl0IGNhbid0IGJlIGVuYWJsZWQgaWYg
TVNJL01TSS1YIGVuYWJsZWQuICovDQo+PiArICAgICAgICBjbWQgfD0gUENJX0NPTU1BTkRfSU5U
WF9ESVNBQkxFOw0KPj4gKyAgICB9DQo+PiArI2VuZGlmDQo+PiArDQo+PiArICAgIGNtZF93cml0
ZShwZGV2LCByZWcsIGNtZCwgZGF0YSk7DQo+PiArfQ0KPiBJdCdzIG5vdCByZWFsbHkgY2xlYXIg
dG8gbWUgd2hldGhlciB0aGUgVE9ETyB3YXJyYW50cyB0aGlzIGJlaW5nIGENCj4gc2VwYXJhdGUg
ZnVuY3Rpb24uIFBlcnNvbmFsbHkgSSdkIGZpbmQgaXQgcHJlZmVyYWJsZSBpZiB0aGUgbG9naWMN
Cj4gd2FzIGZvbGRlZCBpbnRvIGNtZF93cml0ZSgpLg0KTm90IHN1cmUgY21kX3dyaXRlIG5lZWRz
IHRvIGhhdmUgZ3Vlc3QncyBsb2dpYy4gQW5kIHdoYXQncyB0aGUNCnByb2ZpdD8gTGF0ZXIgb24s
IHdoZW4gd2UgZGVjaWRlIGhvdyBQQ0lfQ09NTUFORCBjYW4gYmUgZW11bGF0ZWQNCnRoaXMgY29k
ZSB3aWxsIGxpdmUgaW4gZ3Vlc3RfY21kX3dyaXRlIGFueXdheXMNCj4NCj4gV2l0aCB0aGlzIGFu
ZCAuLi4NCj4NCj4+IC0tLSBhL3hlbi9kcml2ZXJzL3ZwY2kvbXNpLmMNCj4+ICsrKyBiL3hlbi9k
cml2ZXJzL3ZwY2kvbXNpLmMNCj4+IEBAIC03MCw2ICs3MCwxMCBAQCBzdGF0aWMgdm9pZCBjb250
cm9sX3dyaXRlKGNvbnN0IHN0cnVjdCBwY2lfZGV2ICpwZGV2LCB1bnNpZ25lZCBpbnQgcmVnLA0K
Pj4gICANCj4+ICAgICAgICAgICBpZiAoIHZwY2lfbXNpX2FyY2hfZW5hYmxlKG1zaSwgcGRldiwg
dmVjdG9ycykgKQ0KPj4gICAgICAgICAgICAgICByZXR1cm47DQo+PiArDQo+PiArICAgICAgICAv
KiBNYWtlIHN1cmUgZ3Vlc3QgZG9lc24ndCBlbmFibGUgSU5UeCB3aGlsZSBlbmFibGluZyBNU0ku
ICovDQo+PiArICAgICAgICBpZiAoICFpc19oYXJkd2FyZV9kb21haW4ocGRldi0+ZG9tYWluKSAp
DQo+PiArICAgICAgICAgICAgcGNpX2ludHgocGRldiwgZmFsc2UpOw0KPj4gICAgICAgfQ0KPj4g
ICAgICAgZWxzZQ0KPj4gICAgICAgICAgIHZwY2lfbXNpX2FyY2hfZGlzYWJsZShtc2ksIHBkZXYp
Ow0KPj4gLS0tIGEveGVuL2RyaXZlcnMvdnBjaS9tc2l4LmMNCj4+ICsrKyBiL3hlbi9kcml2ZXJz
L3ZwY2kvbXNpeC5jDQo+PiBAQCAtOTIsNiArOTIsMTAgQEAgc3RhdGljIHZvaWQgY29udHJvbF93
cml0ZShjb25zdCBzdHJ1Y3QgcGNpX2RldiAqcGRldiwgdW5zaWduZWQgaW50IHJlZywNCj4+ICAg
ICAgICAgICBmb3IgKCBpID0gMDsgaSA8IG1zaXgtPm1heF9lbnRyaWVzOyBpKysgKQ0KPj4gICAg
ICAgICAgICAgICBpZiAoICFtc2l4LT5lbnRyaWVzW2ldLm1hc2tlZCAmJiBtc2l4LT5lbnRyaWVz
W2ldLnVwZGF0ZWQgKQ0KPj4gICAgICAgICAgICAgICAgICAgdXBkYXRlX2VudHJ5KCZtc2l4LT5l
bnRyaWVzW2ldLCBwZGV2LCBpKTsNCj4+ICsNCj4+ICsgICAgICAgIC8qIE1ha2Ugc3VyZSBndWVz
dCBkb2Vzbid0IGVuYWJsZSBJTlR4IHdoaWxlIGVuYWJsaW5nIE1TSS1YLiAqLw0KPj4gKyAgICAg
ICAgaWYgKCAhaXNfaGFyZHdhcmVfZG9tYWluKHBkZXYtPmRvbWFpbikgKQ0KPj4gKyAgICAgICAg
ICAgIHBjaV9pbnR4KHBkZXYsIGZhbHNlKTsNCj4+ICAgICAgIH0NCj4+ICAgICAgIGVsc2UgaWYg
KCAhbmV3X2VuYWJsZWQgJiYgbXNpeC0+ZW5hYmxlZCApDQo+PiAgICAgICB7DQo+IC4uLiB0aGlz
IGRvbmUgKGFzIHJlcXVlc3RlZCkgYmVoaW5kIHRoZSBiYWNrIG9mIHRoZSBndWVzdCwgd2hhdCdz
IHRoZQ0KPiBpZGVhIHdydCB0aGUgZ3Vlc3QgcmVhZGluZyB0aGUgY29tbWFuZCByZWdpc3Rlcj8g
VGhhdCBjb250aW51ZXMgdG8gYmUNCj4gd2lyZWQgdG8gdnBjaV9od19yZWFkMTYoKSAoYW5kIGhl
bmNlIGFjY2Vzc2VzIHRoZSB1bmRlcmx5aW5nIGhhcmR3YXJlDQo+IHZhbHVlIGlycmVzcGVjdGl2
ZSBvZiB3aGF0IHBhdGNoIDQgZGlkKS4NClllcywgZ29vZCBwb2ludC4gV2UgbmVlZCB0byBhZGQg
Z3Vlc3RfY21kX3JlYWQgY291bnRlcnBhcnQsDQpzbyB3ZSBjYW4gYWxzbyBpbXBsZW1lbnQgdGhl
IHNhbWUgbG9naWMgYXMgaW4gZ3Vlc3RfY21kX3dyaXRlDQp3cnQgdG8gSU5UeCBiaXQuDQo+DQo+
IEphbg0KPg0KVGhhbmsgeW91LA0KT2xla3NhbmRy


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 08:32:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 08:32:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267667.461409 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHLvE-0007AC-1d; Tue, 08 Feb 2022 08:32:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267667.461409; Tue, 08 Feb 2022 08:32:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHLvD-0007A5-U6; Tue, 08 Feb 2022 08:32:23 +0000
Received: by outflank-mailman (input) for mailman id 267667;
 Tue, 08 Feb 2022 08:32:22 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1FiY=SX=epam.com=prvs=40383cc40e=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nHLvC-00079z-6k
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 08:32:22 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a15f9b4e-88b9-11ec-8eb8-a37418f5ba1a;
 Tue, 08 Feb 2022 09:32:20 +0100 (CET)
Received: from pps.filterd (m0174680.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 2188Ntd6012327;
 Tue, 8 Feb 2022 08:32:16 GMT
Received: from eur04-he1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2059.outbound.protection.outlook.com [104.47.13.59])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3e3myg817j-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Tue, 08 Feb 2022 08:32:16 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by VE1PR03MB5568.eurprd03.prod.outlook.com (2603:10a6:803:11a::32)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Tue, 8 Feb
 2022 08:32:12 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77%3]) with mapi id 15.20.4951.019; Tue, 8 Feb 2022
 08:32:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a15f9b4e-88b9-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=leLeCDVdfoCxKFzIhl0ZHoRgBq9YMz2fSfBVcGLuIA++G845e6kDRpfTblx6XzJFvnxSIQGuVAP32ueBWu0QGDTvei6Jv9/QZHe+SHlhVxUDDXExqShz67L2Q2dLNRQCPV2W6PCYifrWQemx8ZheMK32IdwBZhbaVxHJLy+Pg8bAbJVkQypDGJDbGlZNfa/BFUQfiIJFP5JbLaQFG3DvE3uszkJWgSr7JtjaVJfGrShI8Mho2gaUwXqz9jvK6qWXkQUT/OXWnTPqrlwVXAyIzmoSEXTnY5E6Ed0AJK3Hoq1Yj2kh5+ZhKwfeznT9124SrJlfz9bezvsW6jxvPZmeyw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=eEBK7Y5VIxevNiBEHlqkr7/GKIvefWR9lNVpLA60g/Q=;
 b=LgICt82DjfNhOj9kmru3SojLvb6ZjvjzfQhRBBG4tjYtqeIufkgN/3X025B9+kBmmC9NODBSTu35jxYLlmM/2As8PduHNt0qHWE8tm8D3w5eiLs+YGicgdGYmF+YjWqKsr1qkoblG98tqOeUWh+85rNAUbtOZO5ezqBgDCESvnB5/JjqB1o3OhjmHvllsaXRVPiIlH5YKBdarqQCuY0zdq9Eou6281nztzZ5zwD3vxp7IkQsP+jOaNB/xJKZgcwLhDOdKzTtjJEepdhUucdFD6mu2TmUoWI7TDYd6ohhK/HEbCYjEvBbyOmGuIzOgeoiacGGLWTX18gM8umulBTlPA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=eEBK7Y5VIxevNiBEHlqkr7/GKIvefWR9lNVpLA60g/Q=;
 b=aY8TYnU2mnEksGvyZ2ABvIIV+0t0klVVee9K18k7kZ4YTfHthqsFFnoZBhh7Xdvt6OH8NoNEPnwY1Y4mOUEuPoHJQ+7pVh3fVaL16nnZ99uAg88plIdrIMiDh6BMesq1rR125DS8VZuFCpkrYbgkofxJr3xsprX5WZ/n6iD318M+RyHtdzNbOD7QUaGEqiWpDa6YyxIWdXmf4GJ5fbL9tTsHYQ2pUqFDQaf0mynTtJmgUi3R9As/2cd6BVXdM1ORZ5eBZE3yCxMp2H3h/6Al/ZnDU3AdScSm4eACOaaZmRyNOS+Z8dI/jc0FqhOfaD0l8/pvO/I1z3W2E6SKvGu1gw==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "roger.pau@citrix.com" <roger.pau@citrix.com>,
        "andrew.cooper3@citrix.com"
	<andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com"
	<george.dunlap@citrix.com>,
        "paul@xen.org" <paul@xen.org>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>,
        Rahul Singh <rahul.singh@arm.com>,
        "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        Oleksandr
 Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v6 05/13] vpci: add hooks for PCI device assign/de-assign
Thread-Topic: [PATCH v6 05/13] vpci: add hooks for PCI device assign/de-assign
Thread-Index: AQHYGZFdYv4W1RdbQkeQtzN+PyKqmqyITGQAgAENNIA=
Date: Tue, 8 Feb 2022 08:32:11 +0000
Message-ID: <3fe6dbe3-51c6-f87f-23f9-cf2e1a924326@epam.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-6-andr2000@gmail.com>
 <16cea1df-3d0f-d404-2b88-aab47ad5548b@suse.com>
In-Reply-To: <16cea1df-3d0f-d404-2b88-aab47ad5548b@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 1873c5ac-191d-40d7-2289-08d9eadd80db
x-ms-traffictypediagnostic: VE1PR03MB5568:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <VE1PR03MB55682F1577CF99F62CA28816E72D9@VE1PR03MB5568.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 s3OzUmvr0+VA//WMtWgJmPzcoy2avOOeeDYbLdcDf21IByq570GLmU1YzabjkjNNS2/Ou6pXoJBYHFv1ezhPEHMboWV6me7MvvFAltfpuKOEeEj0HLBDMKJ+7UK2BVa0YYH6ZD/pdzjA1EejfiEbmUJe6w6hUx+ctZ56JVYzFYnQ3SEY7BTz7KkH6IjAdx6YYOs3WMqtKWEo5oZQE9QZ77g1uYHFNkrtRC5r6AKlWixO3iQUmlY6Qh2XovcnmLyffOMjQtlwKl3YpCZ2iJRG0czcnnuEvq+U5h6jfyJGPigNNKLHdsSBHTbnQ5EIX34UZdvK2P/6/ur1D29zBhEMa3QR91dxU6R0aWzUlQX+/FSBd/dTBAmQODZZCXZa9ZyDMk1hiUZArTYon+AxgY0YC2lFXJA5RzsVAiLybewgVfIMtKmE/MT3W75uTs0LEKgIeBZTv98vyMa1vvtIefHkCROzUTq+X3E9p7RBN3Aa3NyrfGyz9XAz8J8eQHGVr3C2/2xWuES6DU+p2hCXY8SxDxvuWp0lPyThIbmkupDyO40jB03qm6TOnonBUAGdnqCqOy+uta9KNIY3CrPOWVHJQz0zuM5jcYFMsDSz/LN7wvQs/ioZoUGsRli0or3DxZOS8tGZy4SgPFqQbJFsgkIi0AXbpqIHfaTrijg99eAPXcd8At+WNaHRnXgjJCXWlHiZYCBqvVZyhCzgB3nDKlWR718k+r0dGy0x5GImBPkvKT/8nEjXyCbalzxPtWUx0jDyBIoIUp6fMBRZeJ3NbZFqgsmplXMPvYHIis6eREbMobE=
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(107886003)(71200400001)(2616005)(31686004)(55236004)(53546011)(122000001)(6512007)(316002)(508600001)(66946007)(6506007)(2906002)(186003)(26005)(54906003)(38070700005)(5660300002)(36756003)(6486002)(7416002)(66476007)(8676002)(91956017)(76116006)(86362001)(4326008)(6916009)(31696002)(83380400001)(8936002)(66446008)(64756008)(38100700002)(66556008)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?aVZ0N2RYbDZzT1FJeDlURDk1L2U1SlZvd295a2NrYkFsblFkQ0dwSHFmNlVC?=
 =?utf-8?B?aElWS203WmYxeUUwcVN1WWNnblpONHc5djVrRkx3cW5KQWoxTUhIZ1F2ajFP?=
 =?utf-8?B?dTJhandGRTR5aStyQXlMeWcvaEVnNjNTSXFhTUtwY1cxVDlhZnlSazZyeHBR?=
 =?utf-8?B?TVB4VHRtRGozMklXRjhqbWh0NjMxVm1EbkxrNXdsUXZXdVI2ak84My9DK3ls?=
 =?utf-8?B?UjN1aWdZU3NRUVg0cElRRXdlQ2RTOUt0UEtudEhJei9PblFjK3JMNkNNaHhs?=
 =?utf-8?B?RktXTlFqRkpFbjd4WXNDVXFBL3FOYTF4MFhSVHd1MkxiQmFvaXZ5V3VqTHhG?=
 =?utf-8?B?ZlB5d1ljV3BYblJLN3EvampGQWY3VGZYd2NncmE5WEN1YkdvR1ZYdU8wWG0w?=
 =?utf-8?B?ZUIzZysvWUloUERSbG1xcm5tKzczTFpDK2lYbTNkRWhqcUdENGlRS2F1MjJP?=
 =?utf-8?B?cHI3eG1PRmc0MnVIRW5hWXVxMGd6SmdvNFNzUm9YcWtWakJHUkxON0F2SEZC?=
 =?utf-8?B?bDBEbzhkR2hDNysrTy9kQ0w0c2EzQXVVLzAyVlcxTFRtYVB4UjBvMXdLQ1Bs?=
 =?utf-8?B?eTVseTAwMHZTeFBlc09naEFSRUNBWk8yVXVRUk9XWXlXV1dXanhDb3lUK2w0?=
 =?utf-8?B?UzdYcnpDQUZxTElDd0ZvV2ZYMHZ2TXA0UGhBd0g4RFM0VmdkV3JLb1pwaHlH?=
 =?utf-8?B?VnRSZk9Kdm0zc2w5cTEvSUE1enpUZnZIWGNQdUNwZURBSEZEWHJxTUxwU01B?=
 =?utf-8?B?bUxSZHFubUZTOXhjSExObWp3SHhYYStBbmFiMW5ZSnp3dTVpL2ZEWTlFc2ty?=
 =?utf-8?B?WEVGbVRneXA1Yis3L0VPUUxoR2pVdjZxZFJYOVpyeUZOTTlmeGZ2Z1JHaHNq?=
 =?utf-8?B?ZVdKVnFDK1JkRk5IMkwxd1BIM0phZW5GTmd4UnptK1ozNkJvckx1YkFlaVE5?=
 =?utf-8?B?c0NMZHdJLy80N1VpVUIvdjFIbjhlcmZXOElVWFk2Si9MRitzU3FPTTRCQW1O?=
 =?utf-8?B?a29ON1pUckczdE1oSkpDWmFoZzJneDlUNTBBa0RwS2JUTEViSHdKbndIU2Vi?=
 =?utf-8?B?bkx4TitidTFuN0Nic2JqNklhUjJEMloxV2tseGtuUEJ6dlpxZmZRZkhKVHNP?=
 =?utf-8?B?QjRCbzZHc1RwK0NwQjF2NSt1VmNncTVoSStQK3kzOVJ5bEZMcHZNVk85UXVa?=
 =?utf-8?B?Ny9ON3NsbDBEZmxQbVZ4cWw1RkpPZTlXcEVkZG13SFBVVk1TdldMeHRwMGtX?=
 =?utf-8?B?MTJWTzk5RmI0ZThOR3kzT294WlNFYUY4Z2pUYWxSYWxHcklyVWVaa3I4MERn?=
 =?utf-8?B?SG5CR1lNK1BwWlFtNU40Zm8yV1NyYitlTndaajg2Zm4rdWxVanVzdWZGSFpQ?=
 =?utf-8?B?WjYxZk1OL09qUXJDbWN0MUhmc1NmSUJaNi9qdjFVMEtjR3NsdHNFNERib3Iv?=
 =?utf-8?B?VFNFb2NQSkd6Nm1WRm9sdjI5UGdJZFJZcUNRREVjZ3dVcXp5UFBZck9kMjZT?=
 =?utf-8?B?SFVkL0cySSttbnIzYVF4djZ4aWNPaklHL0xiSC85RzhENmVzaUFUd3kwZUlD?=
 =?utf-8?B?d3JFQlZuZmFhbWRDa3ZqdFIxNXhET1g2b3pwRjlvdHZJNlJ1TnJLNXhhdGEr?=
 =?utf-8?B?anR3TkFGeDUvUzkvcTdJWmJpcUtMR1J0Z1hiU0lZa1hrcHRtVEhYZmNMOGZq?=
 =?utf-8?B?dld3Yzk5ZHUwdjNEZ1JIZTg3UDQ5YjJ0TG9TNDBnSWNqd0NHaU5jZU9jam1X?=
 =?utf-8?B?ZmxzRFBGalZNKzhFb0REU3hNckhhN2xMTGtBa3Y3WUdmbmV1Vit4RlB0eWhq?=
 =?utf-8?B?ZUxSQkhNU3ptV0RGS2xVeGFVQkJBSTFBNll4S3VKQ2hTL0JsSnVQVG0rZDN3?=
 =?utf-8?B?WENXMjZPZ3BWV1IzMVQyeUZEeEVxNERVQ1g5a0c1Qks0a1ZJdFZhQW5nQ0Rh?=
 =?utf-8?B?cjBuOTFHUFl4ekRFMmpVSEhOVkNyRU84TDZaSDBDNndUMHdiV0ZROW1tU1RZ?=
 =?utf-8?B?bEs5WlJXVGRWQURpbFlxVXBINnJsTkEydFQ2TWFBOWRHNEt5MGxUR2RWQWxM?=
 =?utf-8?B?eFFKZ2kycmx0eUlJaU9NTnJWZmMzSjcrSU1URHhWQjhwN3hYcUEyQkJMVUpF?=
 =?utf-8?B?MEhSQ1NTSU11MEFHVE1IbnA3eURaOWRIaG1na1JpYVZEdW1EclJzT0FJV2tS?=
 =?utf-8?B?YXBKWjhuK1ROcUc1MWN5MUZlU2xRQ3ZJMnZMTHk4VGtGRUppb2ZaaU1Dd0pR?=
 =?utf-8?B?b1puNHpjNXMxRjVsMzZjRk5TRHppZ1NOQ1Uvam51eGt3QnpoeEVDeGpWZitS?=
 =?utf-8?B?Z0lJczFOYzFLM0l4dWdGWVdWKzVkUDJjL3NwMmdMSlFnVTlIVm9FZi9jbzQy?=
 =?utf-8?Q?4IpXOxLneiYRg2yk=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <C447B1F74D8FD647878A52914CB19AD7@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1873c5ac-191d-40d7-2289-08d9eadd80db
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2022 08:32:11.9059
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: oQeTVFSCODuMz8bs4H7I5113ZybXFoKmC4HINvN2sqP4c8KKtoilU76UXR/jY11mrR12LtGsJsDpyiY+MFX1bW+U1A0Ldlx6m52IwDDMwJSR9HY65cb6RHJTyewssluH
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR03MB5568
X-Proofpoint-ORIG-GUID: VDmZLeJDp9V9oBVmpPCl64Xov0eHjJnY
X-Proofpoint-GUID: VDmZLeJDp9V9oBVmpPCl64Xov0eHjJnY
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-08_02,2022-02-07_02,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999
 suspectscore=0 priorityscore=1501 lowpriorityscore=0 spamscore=0
 malwarescore=0 impostorscore=0 mlxscore=0 clxscore=1015 bulkscore=0
 adultscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202080047

DQoNCk9uIDA3LjAyLjIyIDE4OjI4LCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMDQuMDIuMjAy
MiAwNzozNCwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+PiBAQCAtMTUwNyw2ICsx
NTExLDggQEAgc3RhdGljIGludCBhc3NpZ25fZGV2aWNlKHN0cnVjdCBkb21haW4gKmQsIHUxNiBz
ZWcsIHU4IGJ1cywgdTggZGV2Zm4sIHUzMiBmbGFnKQ0KPj4gICAgICAgICAgICAgICAgICAgICAg
ICAgICBwY2lfdG9fZGV2KHBkZXYpLCBmbGFnKTsNCj4+ICAgICAgIH0NCj4+ICAgDQo+PiArICAg
IHJjID0gdnBjaV9hc3NpZ25fZGV2aWNlKGQsIHBkZXYpOw0KPj4gKw0KPj4gICAgZG9uZToNCj4+
ICAgICAgIGlmICggcmMgKQ0KPj4gICAgICAgICAgIHByaW50ayhYRU5MT0dfR19XQVJOSU5HICIl
cGQ6IGFzc2lnbiAoJXBwKSBmYWlsZWQgKCVkKVxuIiwNCj4gVGhlcmUncyBubyBhdHRlbXB0IHRv
IHVuZG8gYW55dGhpbmcgaW4gdGhlIGNhc2Ugb2YgZ2V0dGluZyBiYWNrIGFuDQo+IGVycm9yLiBJ
U1RSIHRoaXMgYmVpbmcgZGVlbWVkIG9rYXkgb24gdGhlIGJhc2lzIHRoYXQgdGhlIHRvb2wgc3Rh
Y2sNCj4gd291bGQgdGhlbiB0YWtlIHdoYXRldmVyIGFjdGlvbiwgYnV0IHdoYXRldmVyIGl0IGlz
IHRoYXQgaXMgc3VwcG9zZWQNCj4gdG8gZGVhbCB3aXRoIGVycm9ycyBoZXJlIHdhbnRzIHNwZWxs
aW5nIG91dCBpbiB0aGUgZGVzY3JpcHRpb24uDQpXaHk/IEkgZG9uJ3QgY2hhbmdlIHRoZSBwcmV2
aW91c2x5IGV4cGVjdGVkIGRlY2lzaW9uIGFuZCBpbXBsZW1lbnRhdGlvbg0Kb2YgdGhlIGFzc2ln
bl9kZXZpY2UgZnVuY3Rpb246IEkgdXNlIGVycm9yIHBhdGhzIGFzIHRoZXkgd2VyZSB1c2VkIGJl
Zm9yZQ0KZm9yIHRoZSBleGlzdGluZyBjb2RlLiBTbywgSSBzZWUgbm8gY2xlYXIgcmVhc29uIHRv
IHN0cmVzcyB0aGF0IHRoZSBleGlzdGluZw0KYW5kIG5ldyBjb2RlIHJlbGllcyBvbiB0aGUgdG9v
bHN0YWNrDQo+IFdoYXQncyBpbXBvcnRhbnQgaXMgdGhhdCBubyBjYWxsZXIgdXAgdGhlIGNhbGwg
dHJlZSBtYXkgYmUgbGVmdCB3aXRoDQo+IHRoZSBpbXByZXNzaW9uIHRoYXQgdGhlIGRldmljZSBp
cyBzdGlsbCBvd25lZCBieSB0aGUgb3JpZ2luYWwNCj4gZG9tYWluLiBXaXRoIGhvdyB5b3UgaGF2
ZSBpdCwgdGhlIGRldmljZSBpcyBnb2luZyB0byBiZSBvd25lZCBieSB0aGUNCj4gbmV3IGRvbWFp
biwgYnV0IG5vdCByZWFsbHkgdXNhYmxlLg0KVGhpcyBpcyBub3QgdHJ1ZTogdnBjaV9hc3NpZ25f
ZGV2aWNlIHdpbGwgY2FsbCB2cGNpX2RlYXNzaWduX2RldmljZQ0KaW50ZXJuYWxseSBpZiBpdCBm
YWlscy4gU28sIHRoZSBkZXZpY2Ugd29uJ3QgYmUgYXNzaWduZWQgaW4gdGhpcyBjYXNlDQo+DQo+
PiAtLS0gYS94ZW4vZHJpdmVycy92cGNpL3ZwY2kuYw0KPj4gKysrIGIveGVuL2RyaXZlcnMvdnBj
aS92cGNpLmMNCj4+IEBAIC05OSw2ICs5OSwzMyBAQCBpbnQgdnBjaV9hZGRfaGFuZGxlcnMoc3Ry
dWN0IHBjaV9kZXYgKnBkZXYpDQo+PiAgIA0KPj4gICAgICAgcmV0dXJuIHJjOw0KPj4gICB9DQo+
PiArDQo+PiArI2lmZGVmIENPTkZJR19IQVNfVlBDSV9HVUVTVF9TVVBQT1JUDQo+PiArLyogTm90
aWZ5IHZQQ0kgdGhhdCBkZXZpY2UgaXMgYXNzaWduZWQgdG8gZ3Vlc3QuICovDQo+PiAraW50IHZw
Y2lfYXNzaWduX2RldmljZShzdHJ1Y3QgZG9tYWluICpkLCBzdHJ1Y3QgcGNpX2RldiAqcGRldikN
Cj4+ICt7DQo+PiArICAgIGludCByYzsNCj4+ICsNCj4+ICsgICAgaWYgKCAhaGFzX3ZwY2koZCkg
KQ0KPj4gKyAgICAgICAgcmV0dXJuIDA7DQo+PiArDQo+PiArICAgIHJjID0gdnBjaV9hZGRfaGFu
ZGxlcnMocGRldik7DQo+PiArICAgIGlmICggcmMgKQ0KPj4gKyAgICAgICAgdnBjaV9kZWFzc2ln
bl9kZXZpY2UoZCwgcGRldik7DQo+PiArDQo+PiArICAgIHJldHVybiByYzsNCj4+ICt9DQo+PiAr
DQo+PiArLyogTm90aWZ5IHZQQ0kgdGhhdCBkZXZpY2UgaXMgZGUtYXNzaWduZWQgZnJvbSBndWVz
dC4gKi8NCj4+ICt2b2lkIHZwY2lfZGVhc3NpZ25fZGV2aWNlKHN0cnVjdCBkb21haW4gKmQsIHN0
cnVjdCBwY2lfZGV2ICpwZGV2KQ0KPj4gK3sNCj4+ICsgICAgaWYgKCAhaGFzX3ZwY2koZCkgKQ0K
Pj4gKyAgICAgICAgcmV0dXJuOw0KPj4gKw0KPj4gKyAgICB2cGNpX3JlbW92ZV9kZXZpY2UocGRl
dik7DQo+PiArfQ0KPj4gKyNlbmRpZiAvKiBDT05GSUdfSEFTX1ZQQ0lfR1VFU1RfU1VQUE9SVCAq
Lw0KPiBXaGlsZSBmb3IgdGhlIGxhdHRlciBmdW5jdGlvbiB5b3UgbG9vayB0byBuZWVkIHR3byBw
YXJhbWV0ZXJzLCBkbyB5b3UNCj4gcmVhbGx5IG5lZWQgdGhlbSBhbHNvIGluIHRoZSBmb3JtZXIg
b25lPw0KRG8geW91IG1lYW4gaW5zdGVhZCBvZiBwYXNzaW5nIGQgd2UgY291bGQganVzdCB1c2Ug
cGRldi0+ZG9tYWluPw0KaW50IHZwY2lfYXNzaWduX2RldmljZShzdHJ1Y3QgcGNpX2RldiAqcGRl
dikNCit7DQorwqDCoMKgIGludCByYzsNCisNCivCoMKgwqAgaWYgKCAhaGFzX3ZwY2kocGRldi0+
ZG9tYWluKSApDQorwqDCoMKgwqDCoMKgwqAgcmV0dXJuIDA7DQpZZXMsIHdlIHByb2JhYmx5IGNh
biwgYnV0IHRoZSByZXN0IG9mIGZ1bmN0aW9ucyBjYWxsZWQgZnJvbSBhc3NpZ25fZGV2aWNlDQph
cmUgYWNjZXB0aW5nIGJvdGggZCBhbmQgcGRldiwgc28gbm90IHN1cmUgd2h5IHdvdWxkIHdlIHdh
bnQgdGhlc2UNCnR3byBiZSBhbnkgZGlmZmVyZW50LiBBbnkgZ29vZCByZWFzb24gbm90IHRvIGNo
YW5nZSBvdGhlcnMgYXMgd2VsbCB0aGVuPw0KPiBTeW1tZXRyeSBjb25zaWRlcmF0aW9ucyBtYWtl
IG1lIHdvbmRlciB0aG91Z2ggd2hldGhlciB0aGUgZGUtYXNzaWduDQo+IGhvb2sgc2hvdWxkbid0
IGJlIGNhbGxlZCBlYXJsaWVyLCB3aGVuIHBkZXYtPmRvbWFpbiBzdGlsbCBoYXMgdGhlDQo+IG9y
aWdpbmFsIG93bmVyLiBBdCB3aGljaCBwb2ludCB0aGUgMm5kIHBhcmFtZXRlciBjb3VsZCBkaXNh
cHBlYXIgdGhlcmUNCj4gYXMgd2VsbC4NCnN0YXRpYyBpbnQgYXNzaWduX2RldmljZShzdHJ1Y3Qg
ZG9tYWluICpkLCB1MTYgc2VnLCB1OCBidXMsIHU4IGRldmZuLCB1MzIgZmxhZykNCnsNCltzbmlw
XQ0KIMKgwqDCoCB2cGNpX2RlYXNzaWduX2RldmljZShwZGV2LT5kb21haW4sIHBkZXYpOw0KW3Nu
aXBdDQogwqDCoMKgIHJjID0gdnBjaV9hc3NpZ25fZGV2aWNlKGQsIHBkZXYpOw0KDQpJdCBsb29r
cyBvayB0byBtZQ0KPiBKYW4NCj4NClRoYW5rIHlvdSwNCk9sZWtzYW5kcg==


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 08:33:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 08:33:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267676.461419 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHLvs-0007l6-DB; Tue, 08 Feb 2022 08:33:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267676.461419; Tue, 08 Feb 2022 08:33:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHLvs-0007kz-A0; Tue, 08 Feb 2022 08:33:04 +0000
Received: by outflank-mailman (input) for mailman id 267676;
 Tue, 08 Feb 2022 08:33:02 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nHLvq-0007kn-TZ; Tue, 08 Feb 2022 08:33:02 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nHLvq-0002uX-Oj; Tue, 08 Feb 2022 08:33:02 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nHLvq-0004iW-6g; Tue, 08 Feb 2022 08:33:02 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nHLvq-0004jc-6D; Tue, 08 Feb 2022 08:33:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=QZJwGMkITevcK/4SbFCjgxO27i9y4jJjKA/xOtN8xfU=; b=OAL38D8NoS/iNWzfV/hQ74vKNy
	0GcC5FeMsizErMwNXigt4HHKUx+VF4Ykcg5s+cgQJZobG4l+J9ityJDtCMZhLueXPMfqn649ar44J
	rX11ORIRJ3nqqg8oZVZzOS7rcvY+0efIuuEu8I//Ihuyrz8ih953ELAR1RCnotTK7nk8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168051-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 168051: regressions - FAIL
X-Osstest-Failures:
    xen-unstable:test-arm64-arm64-libvirt-raw:debian-di-install:fail:regression
    xen-unstable:test-arm64-arm64-libvirt-raw:xen-boot:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:allowable
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=10d33220f2363a21a52a394159118ab4ddaed50e
X-Osstest-Versions-That:
    xen=820cc393434097f3b7976acdccbf1d96071d6d23
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 08 Feb 2022 08:33:02 +0000

flight 168051 xen-unstable real [real]
flight 168054 xen-unstable real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/168051/
http://logs.test-lab.xenproject.org/osstest/logs/168054/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-libvirt-raw 12 debian-di-install fail in 168054 REGR. vs. 168037

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-libvirt-raw  8 xen-boot            fail pass in 168054-retest

Regressions which are regarded as allowable (not blocking):
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10   fail REGR. vs. 168037

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168037
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168037
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168037
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168037
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168037
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168037
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168037
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168037
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168037
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168037
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168037
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168037
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 xen                  10d33220f2363a21a52a394159118ab4ddaed50e
baseline version:
 xen                  820cc393434097f3b7976acdccbf1d96071d6d23

Last test of basis   168037  2022-02-07 01:51:51 Z    1 days
Testing same since   168051  2022-02-07 22:08:25 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Roger Pau Monne <roger.pau@citrix.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

------------------------------------------------------------
commit 10d33220f2363a21a52a394159118ab4ddaed50e
Author: Roger Pau Monne <roger.pau@citrix.com>
Date:   Mon Feb 7 12:20:08 2022 +0100

    dom0/pvh: fix processing softirqs during memory map population
    
    Make sure softirqs are processed after every successful call to
    guest_physmap_add_page. Even if only a single page is to be added,
    it's unknown whether the p2m or the IOMMU will require splitting the
    provided page into smaller ones, and thus in case of having to break
    a 1G page into 4K entries the amount of time taken by a single of
    those additions will be non-trivial. Stay on the safe side and check
    for pending softirqs on every successful loop iteration.
    
    Fixes: 5427134eae ('x86: populate PVHv2 Dom0 physical memory map')
    Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
    Reviewed-by: Jan Beulich <jbeulich@suse.com>

commit f97c1abf2934e76fb69fabaf4f5ec04afa813816
Author: Andrew Cooper <andrew.cooper3@citrix.com>
Date:   Fri Feb 4 20:12:04 2022 +0000

    xen/smp: Speed up on_selected_cpus()
    
    cpumask_weight() is an incredibly expensive way to find if no bits are set,
    made worse by the fact that the calculation is performed with the global
    call_lock held.
    
    This appears to be a missing optimisation from c/s 433f14699d48 ("x86: Clean
    up smp_call_function handling.") in 2011 which dropped the logic requiring the
    count of CPUs.
    
    Switch to using cpumask_empty() instead, which will short circuit as soon as
    it finds any set bit in the cpumask.
    
    Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
    Reviewed-by: Julien Grall <jgrall@amazon.com>
    Reviewed-by: Jan Beulich <jbeulich@suse.com>

commit e9b32164142e40a2585543a46530066b58a76f3f
Author: Andrew Cooper <andrew.cooper3@citrix.com>
Date:   Fri Feb 4 17:01:41 2022 +0000

    x86/hvm: Fix boot on systems where HVM isn't available
    
    c/s 27a63cdac388 ("x86/HVM: convert remaining hvm_funcs hook invocations to
    alt-call") went too far with dropping NULL function pointer checks.
    
    smp_callin() and S3 resume call hvm_cpu_up() unconditionally.  When the
    platform doesn't support HVM, hvm_enable() exits without filling in hvm_funcs,
    after which the altcall pass nukes the (now unconditional) indirect call,
    causing:
    
      (XEN) ----[ Xen-4.17.0-10.18-d  x86_64  debug=y  Not tainted ]----
      (XEN) CPU:    1
      (XEN) RIP:    e008:[<ffff82d04034bef5>] start_secondary+0x393/0x3b7
      (XEN) RFLAGS: 0000000000010086   CONTEXT: hypervisor
      ...
      (XEN) Xen code around <ffff82d04034bef5> (start_secondary+0x393/0x3b7):
      (XEN)  ff ff 8b 05 1b 84 17 00 <0f> 0b 0f ff ff 90 89 c3 85 c0 0f 84 db fe ff ff
      ...
      (XEN) Xen call trace:
      (XEN)    [<ffff82d04034bef5>] R start_secondary+0x393/0x3b7
      (XEN)    [<ffff82d0402000e2>] F __high_start+0x42/0x60
    
    To make matters worse, several paths including __stop_this_cpu() call
    hvm_cpu_down() unconditionally too, so what happen next is:
    
      (XEN) ----[ Xen-4.17.0-10.18-d  x86_64  debug=y  Not tainted ]----
      (XEN) CPU:    0
      (XEN) RIP:    e008:[<ffff82d04034ab02>] __stop_this_cpu+0x12/0x3c
      (XEN) RFLAGS: 0000000000010046   CONTEXT: hypervisor
      ...
      (XEN) Xen code around <ffff82d04034ab02> (__stop_this_cpu+0x12/0x3c):
      (XEN)  48 89 e5 e8 8a 1d fd ff <0f> 0b 0f ff ff 90 0f 06 db e3 48 89 e0 48 0d ff
      ...
      (XEN) Xen call trace:
      (XEN)    [<ffff82d04034ab02>] R __stop_this_cpu+0x12/0x3c
      (XEN)    [<ffff82d04034ac15>] F smp_send_stop+0xdd/0xf8
      (XEN)    [<ffff82d04034a229>] F machine_restart+0xa2/0x298
      (XEN)    [<ffff82d04034a42a>] F arch/x86/shutdown.c#__machine_restart+0xb/0x11
      (XEN)    [<ffff82d04022fd15>] F smp_call_function_interrupt+0xbf/0xea
      (XEN)    [<ffff82d04034acc6>] F call_function_interrupt+0x35/0x37
      (XEN)    [<ffff82d040331a70>] F do_IRQ+0xa3/0x6b5
      (XEN)    [<ffff82d04039482a>] F common_interrupt+0x10a/0x120
      (XEN)    [<ffff82d04031f649>] F __udelay+0x3a/0x51
      (XEN)    [<ffff82d04034d5fb>] F __cpu_up+0x48f/0x734
      (XEN)    [<ffff82d040203c2b>] F cpu_up+0x7d/0xde
      (XEN)    [<ffff82d0404543d3>] F __start_xen+0x200b/0x2618
      (XEN)    [<ffff82d0402000ef>] F __high_start+0x4f/0x60
    
    which recurses until hitting a stack overflow.  The #DF handler, which resets
    its stack on each invocation, loops indefinitely.
    
    Reinstate the NULL function pointer checks for hvm_cpu_{up,down}(), along with
    comments explaining how the helpers are used.
    
    Fixes: 27a63cdac388 ("x86/HVM: convert remaining hvm_funcs hook invocations to alt-call")
    Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
    Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
    Reviewed-by: Jan Beulich <jbeulich@suse.com>
(qemu changes not included)


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 08:42:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 08:42:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267692.461434 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHM4q-0000rM-Au; Tue, 08 Feb 2022 08:42:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267692.461434; Tue, 08 Feb 2022 08:42:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHM4q-0000rF-7t; Tue, 08 Feb 2022 08:42:20 +0000
Received: by outflank-mailman (input) for mailman id 267692;
 Tue, 08 Feb 2022 08:42:19 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nHM4p-0000r5-4L; Tue, 08 Feb 2022 08:42:19 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nHM4p-00033z-2h; Tue, 08 Feb 2022 08:42:19 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nHM4o-000551-Qo; Tue, 08 Feb 2022 08:42:18 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nHM4o-0007vV-QJ; Tue, 08 Feb 2022 08:42:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Hhcks440hLZ7wlMax2nDrnJQZPEghGaIbLhh3twrQXM=; b=pwKQyt5Do2RTqeQ+tZLJJTojbo
	rPe/eHhVn3AlOogkxCys0gp+55MYGcZZHaaGBcffeD9jEdtnf3HrkEI5gwgbxgZffi/9njLTbZtMH
	4f6T4z5k9h9VREjaNhhDdxol0OkDSldcigiaFAT7/z1eyiQu+1Gf4DqzgthiD+PlR+AQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168053-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 168053: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=e0241f334d4e8da2e36cda48c225d5a6edcc3a50
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 08 Feb 2022 08:42:18 +0000

flight 168053 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168053/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              e0241f334d4e8da2e36cda48c225d5a6edcc3a50
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  578 days
Failing since        151818  2020-07-11 04:18:52 Z  577 days  559 attempts
Testing same since   168053  2022-02-08 04:20:11 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brad Laue <brad@brad-x.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Christophe Fergeau <cfergeau@redhat.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Divya Garg <divya.garg@nutanix.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Emilio Herrera <ehespinosa57@gmail.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Ivan Teterevkov <ivan.teterevkov@nutanix.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Lubomir Rintel <lkundrak@v3.sk>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nicolas Lécureuil <neoclust@mageia.org>
  Nicolas Lécureuil <nicolas.lecureuil@siveo.net>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Rohit Kumar <rohit.kumar3@nutanix.com>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  shenjiatong <yshxxsjt715@gmail.com>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tuguoyi <tu.guoyi@h3c.com>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Vineeth Pillai <viremana@linux.microsoft.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yasuhiko Kamata <belphegor@belbel.or.jp>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 96583 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 08:53:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 08:53:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267707.461445 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHMG0-0002Ox-IX; Tue, 08 Feb 2022 08:53:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267707.461445; Tue, 08 Feb 2022 08:53:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHMG0-0002Oq-Er; Tue, 08 Feb 2022 08:53:52 +0000
Received: by outflank-mailman (input) for mailman id 267707;
 Tue, 08 Feb 2022 08:53:51 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=v7zX=SX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nHMFz-0002Oj-Mi
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 08:53:51 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a2476ddf-88bc-11ec-8eb8-a37418f5ba1a;
 Tue, 08 Feb 2022 09:53:50 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2059.outbound.protection.outlook.com [104.47.14.59]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-35-eF0rY_uWM2iaQl97FuTyIw-1; Tue, 08 Feb 2022 09:53:47 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM6PR0402MB3783.eurprd04.prod.outlook.com (2603:10a6:209:1b::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Tue, 8 Feb
 2022 08:53:45 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.018; Tue, 8 Feb 2022
 08:53:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a2476ddf-88bc-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644310429;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=xHzFYP58fe1Zc6pevN/mIujNWLFKjLAZvo2b8nQ8yTI=;
	b=UxTbaQcY+i7OQrgrwrzNv7PH6B+5Cpr4wWDbMJx6GnSL2vQq5t44cv9U1/D3rR22cgEH1k
	oowZnJQR+CyI/AK8cJNGuai7Z9qkeWVmIr+7Y0HAJQAL98/AQhxzsGDD1SliuZF4Zagtpm
	m782JURBV2zMQghUEvd6fIzNDc8z5kI=
X-MC-Unique: eF0rY_uWM2iaQl97FuTyIw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=iCQ6jhl4JWXUy/Is1YhyKQNcdD7Br092gYi6ZP56Hbbb4T+gA+HbaFgZXycpf6EWTi0w8+RzYcv5A9Bzq+M1WF5yXpLe5xQ/MEk8IHkt47nZzdHuMakRhymYW/fwPIQpWn3kUba/XIt3Vk60mjDMClk2gT+odlpZEmuLBcVZSqLUk3YNF9ugtNW6MWg+6U7EECvkgof4OfsK+YsHBKPyUiy6HlE9yJfXHq+EpVx8KmXMj+RJdT9N9HDvnXwLEYluH6tv/rCnPJdZkZkf2FBqKNzBnzNmjAOtrWYuntu8DekahTAmVJ1E7NphpHsgZEFzGtZsVljYboQ11YJ+cdQMsQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=g9Y7LnO6rzoo1GXUBfHSExrNotLx1RihnMsF9EkbczU=;
 b=mFBPvPWKjxWD+lKbEAx+c18oudKsz6yrxtRRVLlRZ/RF6ElkrifQO/7HPLKVmHH6R4KZ4DA3nXiJdCKVtTjkZnkfUQ16UTQ1w+l/NgeEUSBTz4mVp7NTnfszTPMOCgwk3BUq+Ju7wXrYsVTRk/Qo4iQA2zVA4YfTMOaYp+Rr7PRukBzwqomg8sXMmmdQzv+OYvkFcK9VNMI9izjfiJQF6UFKG0IEgMxEDI6VgxfmblDjRVqnsYKKInCG+CQLTfJjXMTgUYC5i/UYg9CSQ4I+sTobcnFieL3MiyihsZpBSBd4zy2K9izUaZJ0/qt/1j+LR45INcTH6WAF4OjPvDkfig==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <df369309-3767-632c-912e-e83edcf6a2ad@suse.com>
Date: Tue, 8 Feb 2022 09:53:43 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Content-Language: en-US
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: "julien@xen.org" <julien@xen.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Artem Mygaiev <Artem_Mygaiev@epam.com>,
 "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
 "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
 "paul@xen.org" <paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <7e3562b5-fc67-f213-e872-f211450d9e2e@epam.com>
 <a8fc599c-f620-c4d1-2077-c57068f46a7f@suse.com>
 <deef8468-d607-e49e-f456-6a8013329ca1@epam.com>
 <Yf0k6aoKK5G3iad1@Air-de-Roger>
 <3ad10a99-c706-b95f-1419-2c0c7cf37d58@epam.com>
 <Yf0+3C9nF8+tewLw@Air-de-Roger>
 <c5fea3bb-834b-eeb7-d7a1-1ee609037a9f@epam.com>
 <YgEUwTxhnWVMGMJK@Air-de-Roger>
 <9ce90193-74a0-5642-d22b-6b8c3340c3cf@epam.com>
 <1f65ae7a-898d-2c27-0ada-d71d778b0627@suse.com>
 <YgEsRuckQJIQlkzf@Air-de-Roger>
 <a2a42c1d-d379-00cd-5d55-f443cdb02e97@epam.com>
 <e8fc7872-c7d0-f389-c507-335b809ffcbc@epam.com>
 <21c8125a-2f79-1a4a-494c-db9e4be2a1a6@suse.com>
 <4276fe72-558b-7d95-6430-d4330989dbe8@epam.com>
 <ad985f4a-10f0-4a2d-df02-cde915fea3f1@suse.com>
 <f7669670-8eeb-9966-5ba3-e8f9c03ce3d3@epam.com>
 <73e08285-6bb1-5842-899f-bd6502406e49@suse.com>
 <be3f4222-6580-4c89-a202-c003b6feb9b4@epam.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <be3f4222-6580-4c89-a202-c003b6feb9b4@epam.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6P191CA0108.EURP191.PROD.OUTLOOK.COM
 (2603:10a6:209:8a::49) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4c8373ea-6272-4a55-0ce9-08d9eae083b1
X-MS-TrafficTypeDiagnostic: AM6PR0402MB3783:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR0402MB3783B7483EF4C66A7D19A997B32D9@AM6PR0402MB3783.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	+Og8fIIAmy4PKsgzOlhl2eBATxq71951x4zEWixuCeiPVH7/jPAqTodwVOZaCbUhTFCsPCee748cyESYlrxhLjH03HBW/j9ZBFF0plymr5MgiGT6CEbq6VJ70SoxDiEjM+uSOHkJh8ctGOTnPzuTXt0pXal09GCYGAeG79+bQbURFKs9RrbW10uJbDyJl36WRHjSoYFVohtE6Iw0W1XGg0w9/QGp9fPTqo8PPGCshGgJkc6IXGdFEfeyjAG/rVSgIHRX+WZzLGOHxMKPl+pRi0E7c1R4DQSzMq9rvYO2nAoygQpy/3gPSBCDOZwhPZRbcxN9wvp0qslm/MY/kFih7TbddGi7pzKLMPYb5Wc4qnZnQWUreLvVwZq5/DFbgy9Qu5xfysHggqTIcoX2oNhHr8KsCcj1XTvqotjj21eNK9gfxW4fda79xO5T2rtmaH79bI2wczSCkxebNGHFQgj2ldybVCp+9rujfj8EWayQl0Th2AW3EAS1NAZiZxGUqnr2xKceUKCRpfXEtaiL4HVmf0cCw2tVRYcrnpf1J090jrd+PwEwle3st51QL72bS/l10Wz2FA/Xh5jm8K7PyXX5ielzS5FZ5e8ndfTXwCer6m4wQkuhVd68VVSBd3ooDi28K+RAsUkYOXLqaNjJ25Gy2b86UrDWiLwW5r9vC80LHgmZc5mEuqJaknUniWJRd1+hQGtnR5xN8diknvffM+SB7WG4Xu8T9q89Vxh5vjootvk=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(36756003)(2616005)(83380400001)(6512007)(6506007)(66476007)(6916009)(316002)(54906003)(7416002)(38100700002)(2906002)(31686004)(53546011)(186003)(26005)(8676002)(508600001)(4326008)(66946007)(31696002)(8936002)(86362001)(6486002)(66556008)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?tzbjOWh4D+P6mWP7GeZ7L9B8dDwRBmKnH2SQbFN+kKIHBPvUxv9TZNA+lC4I?=
 =?us-ascii?Q?LJmJK6ysNxxKDqqfsb63dhrOethS6ohLc6Cx1dPFi/kUVNAv62hYcZqh3Uar?=
 =?us-ascii?Q?zt9CJDX1WADde4wsbnEykFItia/8yv1BZpPj3JuhDhqujOqt4qLeOzDe4V7N?=
 =?us-ascii?Q?EDO7PAT63YBwELJCVcAjQhaNk6AJ0bF0sFjVRRH/5E3eQsCutaGiej7atXHN?=
 =?us-ascii?Q?GeE+RwrVhNTA33Wec1lUYe30tDQd+SvaDH5N2yYFM42pLHrQ3rBuOU1BKigZ?=
 =?us-ascii?Q?2LuzDlMKVJvWEMZ3tIgcKtexJNbU/yDJx8q4NAjgaq8minzNYGZkVqVIHS+/?=
 =?us-ascii?Q?EAy6UVd1/0b9hLdL4DCJlhX5+HEYmxv68D6F2RlitNs2SYwVcoaJ+msvRrQW?=
 =?us-ascii?Q?iSQAfjOkFmdSelRI3L6x9KSMEK66hqBZxX/kd50WrOtmkXPheHDpOWYC/MDY?=
 =?us-ascii?Q?mRS8vVv4OUaYZNDbM7GCX7inLfebxmdF81OgxwI8FaoMnrXKYJzaOS3CwNC0?=
 =?us-ascii?Q?GODh3M12EFgcBhw1b/JjzQ2Q1htJrtXhcVPXdbKu4V1IMTxgYp8haSjK4ykw?=
 =?us-ascii?Q?cSclucuhr8FevugZobnF/RNOnS5dI21WkcmstgyLrDuFcqJBd+g4gAlDijnD?=
 =?us-ascii?Q?rNSqTBSLG5bASV5nYkvEko5POTT+kbT5tRv7111KhaA9lL4EVFddzhZdne+e?=
 =?us-ascii?Q?y9zEAfd8U6GoVLulhuPQvV/d7seIhgaIx6NzZn+uRD8Do6WcUkgHzs5xWx7F?=
 =?us-ascii?Q?vColcqw1tmUxKyniu+NMhJYhAym8egzWVcnnNqjFRbrN4SI9wQkVb0k2R0O7?=
 =?us-ascii?Q?MJvChtkiy8XKy+4k2W6u3u/R5KzDWmaEbiFMOs8coaLcrTN00NltQWcNKN0Z?=
 =?us-ascii?Q?8Vll3vK2o8ELMDRgSXuAJV2hnfVHidVm+vkBsfJv9dSXD8+Q892dHYCzZthj?=
 =?us-ascii?Q?onR7j55fzEkPtW64oowkljAAgikapWz+BbKNU37hSIKlchiUar/801Wwljab?=
 =?us-ascii?Q?bYuxiTZFn2ARgQ/cLv50FXYJKV5o0qsx+aCWriGoWrzXb21kexvJuX+hN7di?=
 =?us-ascii?Q?zgvWlhum+pRH3y+TdP2T/GMcUPQfqtaCvwzZ/jqvSEm5m9cZ+8wtw2UasD7Q?=
 =?us-ascii?Q?9fajb2FWmlyMsjm2WJfVWqAXUK1cxXyJyPaOIgsRPYv3b2zLBJjpuROuQAcI?=
 =?us-ascii?Q?uUbKfwODV+dUUZ4MyZrUUn8hBE3Ofuz4X4VHwb1mz0cxv/2B8xLL/hyxCRVj?=
 =?us-ascii?Q?np3fsLCjaqL9ENYYbRfDIC9uaAjVXk49jzmtzaA+w92a+97r+jGOXaofFmln?=
 =?us-ascii?Q?ZCR2h+rbqxsVOdNqxjCtpbXtVS9HkYx+89Vh05Rl5C2u5soiUQYTvDKdmW+K?=
 =?us-ascii?Q?fjaq6xEgLbllWpUHZbhzwcr8FkPvIvDrt3/gOmjTDialwQrk8P4PmeQiXThy?=
 =?us-ascii?Q?Fk6x7Y3n7BVI8zlhD0BU2R6W5GmtaBldBNesBZXDQ75Npx4qTLLHX6pH8z++?=
 =?us-ascii?Q?QY0LahbGYueDzyyEPjQQMbh+kbDIIdDSRER360XFahSYevK8UVi4nNYKEzcP?=
 =?us-ascii?Q?H/Tb6K4ZcVsxFtsT+NSjMsaYiOijTV5IkZ4WCG86B83flO0yBwEBn8VqdIla?=
 =?us-ascii?Q?6edlpGXW7iYaepozbM3MObA=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4c8373ea-6272-4a55-0ce9-08d9eae083b1
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2022 08:53:45.4971
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2r7SipNty4otM7jRpx5hb78mSqToVrVnOQAku2foAOq1CcU04ETxcmwLikUSFDwBFFQZvN5tI4wyCBXf6rcRew==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR0402MB3783

On 07.02.2022 17:44, Oleksandr Andrushchenko wrote:
>=20
>=20
> On 07.02.22 18:37, Jan Beulich wrote:
>> On 07.02.2022 17:21, Oleksandr Andrushchenko wrote:
>>>
>>> On 07.02.22 18:15, Jan Beulich wrote:
>>>> On 07.02.2022 17:07, Oleksandr Andrushchenko wrote:
>>>>> On 07.02.22 17:26, Jan Beulich wrote:
>>>>>> 1b. Make vpci_write use write lock for writes to command register an=
d BARs
>>>>>> only; keep using the read lock for all other writes.
>>>>> I am not quite sure how to do that. Do you mean something like:
>>>>> void vpci_write(pci_sbdf_t sbdf, unsigned int reg, unsigned int size,
>>>>>    =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0 uint32_t data)
>>>>> [snip]
>>>>>    =C2=A0=C2=A0=C2=A0 list_for_each_entry ( r, &pdev->vpci->handlers,=
 node )
>>>>> {
>>>>> [snip]
>>>>>    =C2=A0=C2=A0=C2=A0 if ( r->needs_write_lock)
>>>>>    =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 write_lock(d->vpci_lock)
>>>>>    =C2=A0=C2=A0=C2=A0 else
>>>>>    =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 read_lock(d->vpci_lock)
>>>>> ....
>>>>>
>>>>> And provide rw as an argument to:
>>>>>
>>>>> int vpci_add_register(struct vpci *vpci, vpci_read_t *read_handler,
>>>>>    =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 vpci_write_t *=
write_handler, unsigned int offset,
>>>>>    =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 unsigned int s=
ize, void *data, --->>> bool write_path <<<-----)
>>>>>
>>>>> Is this what you mean?
>>>> This sounds overly complicated. You can derive locally in vpci_write()=
,
>>>> from just its "reg" and "size" parameters, whether the lock needs taki=
ng
>>>> in write mode.
>>> Yes, I started writing a reply with that. So, the summary (ROM
>>> position depends on header type):
>>> if ( (reg =3D=3D PCI_COMMAND) || (reg =3D=3D ROM) )
>>> {
>>>   =C2=A0=C2=A0=C2=A0 read PCI_COMMAND and see if memory or IO decoding =
are enabled.
>>>   =C2=A0=C2=A0=C2=A0 if ( enabled )
>>>   =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 write_lock(d->vpci_lock)
>>>   =C2=A0=C2=A0=C2=A0 else
>>>   =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 read_lock(d->vpci_lock)
>>> }
>> Hmm, yes, you can actually get away without using "size", since both
>> command register and ROM BAR are 32-bit aligned registers, and 64-bit
>> accesses get split in vpci_ecam_write().
> But, OS may want reading a single byte of ROM BAR, so I think
> I'll need to check if reg+size fall into PCI_COMAND and ROM BAR
> ranges
>>
>> For the command register the memory- / IO-decoding-enabled check may
>> end up a little more complicated, as the value to be written also
>> matters. Maybe read the command register only for the ROM BAR write,
>> using the write lock uniformly for all command register writes?
> Sounds good for the start.
> Another concern is that if we go with a read_lock and then in the
> underlying code we disable memory decoding and try doing
> something and calling cmd_write handler for any reason then....
>=20
> I mean that the check in the vpci_write is somewhat we can tolerate,
> but then it is must be considered that no code in the read path
> is allowed to perform write path functions. Which brings a pretty
> valid use-case: say in read mode we detect an unrecoverable error
> and need to remove the device:
> vpci_process_pending -> ERROR -> vpci_remove_device or similar.
>=20
> What do we do then? It is all going to be fragile...

Real hardware won't cause a device to disappear upon a problem with
a read access. There shouldn't be any need to remove a passed-through
device either; such problems (if any) need handling differently imo.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Feb 08 08:55:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 08:55:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267714.461456 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHMHD-0002y2-TU; Tue, 08 Feb 2022 08:55:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267714.461456; Tue, 08 Feb 2022 08:55:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHMHD-0002xv-Q4; Tue, 08 Feb 2022 08:55:07 +0000
Received: by outflank-mailman (input) for mailman id 267714;
 Tue, 08 Feb 2022 08:55:06 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=GmUj=SX=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nHMHC-0002xd-QX
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 08:55:06 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id cd8b85d6-88bc-11ec-8eb8-a37418f5ba1a;
 Tue, 08 Feb 2022 09:55:04 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cd8b85d6-88bc-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644310505;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=ARQgLwdn/KlxqWU+cRg8JmGsc3Wr7wIRnIw2KurRzaw=;
  b=Ee7Q696WpPXL4o57oehWmWuVs5dyNvNaI+038CmLNDfXkHF1u89AL2FM
   /1ZxRiR+TBbDAfM+cC3z01x50Jwp6pvLKbEqtxk6DqAxHaWzQP8Oi9XGR
   BgwYIJFPa25FMbAhizCqKz2Lk/GD1q+79g/VCaFLQGsMZWyMRsql+G5cF
   Q=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: pBnk+nGveZ+fYnxo+mOWkB19EVT5VAdKI09Yg2ZWLy97RzBvZSMVBUqSHWQhIuH8Ftrkdr8ah1
 KC0wlACv0uNg19hsZRVKau4eqSySgmNKMgBKPwn/RWGXuZl7V8NNVxjCuppEitqoQ0JBoJDdBM
 q4ZoOfnRNjnLOR+CcJMC/9dY6JsJZTZdLZu4QXx2cGIdgutqnYbIoT+clhTwHo7kXh84UO3TNL
 i8WlntfcApcTkn8edxjPF/lLyL0phPieDj/DhTuH9t1MzlEgLI8OWzGID1E53UpWV2UJIAmpaA
 hgSlTnFzoOS/YEuHTJUrOPbY
X-SBRS: 5.1
X-MesageID: 63713781
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:1MkFYK9tqgescJbtxXMwDrUDUnmTJUtcMsCJ2f8bNWPcYEJGY0x3m
 zYYWmyFOa2Ia2H3co8lb9iw8BhUu5KGn9ZnTVZpri08E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhFWeIdA970Ug5w7Rh0tYx6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhP5
 /p1mqfsFDwWFfP1g+QZCyJhHXBhaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguw5K8bmJsUHs2xIxjDFF/c2B5vERs0m4PcGh2hp3Z8eRJ4yY
 eIFcRNMTjneZScQHXY6V54shO6NiiPGJmgwRFW9+vNsvjm7IBZK+KfpGMrYfJqNX8o9tlaVo
 CfK8nr0BjkeNceD0nyV/3S0nOjNkCjnHoUIG9WQ9PRnnVmSzWw7EwANWB2wpvzRt6Klc4sBc
 QpOoHNo9PVsshzwJjXgY/GmiECrkSYzYIYNKNIRtjiWyq6M2D+XV3dRG1atd+canMMxQDUr0
 HqAkNXoGSFjvdWpdJ6NyluHhWjsYHZIdAfucQdBFFJYuIe7/OnfmzqSFo4LLUKjsjHi9dgcK
 RiupTN2ubgchNVjO06TrQGe2GLESnQko2cICuTrsoCNs1kRiG2NPdXABb3nARFodtfxc7V5l
 CJY8/VyFchXZX13qASDQf8WAJai7OufPTvXjDZHRsd9q238oif9LNoJu1mSwXuF1e5eKFfUj
 LL741sNtPe/wlP2BUOIX25BI5tzlvWxfTgUfvvVcsBPcvBMmPyvp0lTibqr9zm1yiAEyPhnU
 b/CKJrEJStKWMxPkWvtL89AgOBD7n5lnwv7G8ukpylLJJLDPRZ5v59eawDQBg34hYvZyDjoH
 yF3bZPVkk4CC72nOUE6M+c7dDg3EJTyPrivw+R/fe+fOAt2XmYnDv7a27Q6fIJ52a9Sk4/1E
 ruVAye0EXLz2i/KLxukcHdmZO+9VJpztytjbyctIUypyz4oZoP2tPUTcJ4+fL8G8u1/zKErE
 6lZKpvYWvkfGC7a/zk9bIXmqNAwfhqcmg/TbTGuZyIyfsA8SlWRqMPkZAbm6AIHEjGz6Zklu
 7Sl2w6CGcgDSg1uAdz4cvWqy1/t73ERlPgrBxnDI8VJeVWq+49vcnSjgvgyKsAKCBPC2jrFi
 FrGXUZG/bHA+tZn/sPIiKaIq5aSP9F/RkcKTXPG6buWNDXB+jbxy4F3T+vVLyvWU3n5+fv+a
 LwNne38KvAOgH1Dr5F4T+Rw1as76tbi++1awwBjECmZZlinEOo9cHyP3M0JvaxR3L5J/wCxX
 xvXqNVdPLyIPuLjEUIQe1V5PrjSi6lMl2mA9+kxLWX7+DRzreiOXkhlNhWRjDBQceluO4Q/z
 OZ94MMb5mRTUPbx3gpqWsyMy1mxEw==
IronPort-HdrOrdr: A9a23:qHEn964HqJAQrqbWpwPXwKvXdLJyesId70hD6qkRc3xom6mj/P
 xG88536faZslwssRIb+OxoRpPufZq0z/cc3WB7B9uftWfd1leVEA==
X-IronPort-AV: E=Sophos;i="5.88,352,1635220800"; 
   d="scan'208";a="63713781"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=FH80tHKyRAGIl4iF8m+L3QkMUuEqVi/T0HxzghvsgeU8eUE+E3HaOKk+jr2Xr83NY/6G3t9aP98WgpS40TtjElxNW7Li7J4ourpUAVSTDl8ZD3Q3PEd5MmAlv/CQpnjaqIJWpHTGl82zor94YX6om2nBlmlPg6ugXRgYykWjQvsOrFrqVrF9/Zuag9Fo/Zi8RU6Zhw9RgwT9VI95n7gtPa+BaUQUqlWhXYq/ynbapiU9CnNPRojwedyo25btxX6a23fGOLmLeWz/QVn1jczwGIMnSxuNWqhNMZPo5Wt/S5BvnK/Uq1egwnTyt8US3hhtyLKy3Utzlprzn1IDRXI58g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=JBjmfAf+XbdFvDrsmvH8uWVTnWzbPdjLuuvvrFFZOEM=;
 b=c5Yl+Um1qJPQ81NstBMgILhOdnigqACOeFMOdvrAjOSVzDYdIEQHqvzapyD6/xftulwS5dQFHclpiosHl2a4L0jqqF0BoEi6qsUtTZDMIeZQYWkooJkrerfQ3lnYYuyW7/UahNwsSRcbsyH/eqwEXz1fn3HCBtSl4BSBgWFU857BPItR1ai1jZ0643MeD01o472iCKNQSK4gfQQtMAcKTz+bajos6ttK1WFcsAs/cjsC78tma0+CuYM4g+8+eJ2ZVIm5KClf5Fk/WEmxQ+6/EMZ4PI8SBcnBFb/H8q6BzAXzVbOCB4JTmvitQSxNEErloJ92HAC+95uwZPNAfgPIhw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=JBjmfAf+XbdFvDrsmvH8uWVTnWzbPdjLuuvvrFFZOEM=;
 b=QUBdRpA86xKIaNY3PFaUHc0WCPix659W7985lWdxWuw2AdIm+sVoAlF100WFx73BKcHZkNp6KJLk4o7p5u9HokqQk1y/e0giAvcreZfIe4BCYLD91d5IWZ8mRPAxVZ5AgQsc8mbZOH4wA3qURoHZneeP/QeHB7cup7OhYexvX3c=
Date: Tue, 8 Feb 2022 09:54:52 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH] x86/Intel: don't log bogus frequency range on Core/Core2
 processors
Message-ID: <YgIv3O8ojoDK+wiR@Air-de-Roger>
References: <419db65a-a6f2-f812-d51e-7a23d065d460@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <419db65a-a6f2-f812-d51e-7a23d065d460@suse.com>
X-ClientProxiedBy: MR2P264CA0054.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:500:31::18) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b3a5041d-310f-4f74-6596-08d9eae0af4b
X-MS-TrafficTypeDiagnostic: SN6PR03MB4544:EE_
X-Microsoft-Antispam-PRVS: <SN6PR03MB4544B721410728FDDFA5F05E8F2D9@SN6PR03MB4544.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: kklfVXjs+OwJKebcC+/eqYm8uJzsOGWmF6vNl3sRo0BNbb3OCtqYxZvShHocIJwLLrb1eFrm3lrBpO+EmfwRgR/nSzmu5/2xx4a7yAzZEZzlNuvreUoMott+AV4flyNP+G91Vu1mHr1QJYNnRVSxU8/0QsUfxgCYrR0W9VQ3bigq+TqAkHahkuNMyHgDv3py7B7sAekfD83rxGnnxls7KW3170SBBVfg/+56+4E/TMuOpX03dKaB2GX6ynRbPb9SUq6Aoruj8hjFSMhiJDn2AWvc9tsJJTcjXaVCiLEP6DXcMszgFHEkzEmXE+XxUM9/rOo3yKf+m0ErRMpDU4/zsnVsTOlvqcSlXIxY3bw7JDEfFhBPrD1hl5oznyaltq25WAvOr72El96xhdjldLXV0eBFbk+TbabXxSUazOaC96sSowY3qlmLi73fN9M/JJ6EMD/P0olBteLfEEQOgoeurPb61bm9ecuOiM9HqLKO6CWOoSdWKCgGafIDXArK4lZPE5XxqK3KfqQiQ04/3Sth8MFdo09W4ipzVaWY+d7kJy7SkLWx7fP5+kAavOzqeWbbYsztlwD7ldrtaI5x3+22DrA63EY1WonxBdvPwAx9TYcUD5mDsqr72uJENAmwZ2shvaDUug+xIBGE5sAPHcz9G8Q6Vq9J9R1db8J09cBGTjrSj9saYodh6hLdPc3omT6J33d9jVrCTi4JovCl5PdSZA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(83380400001)(6916009)(316002)(54906003)(26005)(33716001)(186003)(66946007)(86362001)(6506007)(9686003)(6512007)(85182001)(2906002)(6666004)(4326008)(6486002)(38100700002)(8676002)(82960400001)(8936002)(66556008)(66476007)(508600001)(5660300002)(67856001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YWhvdEZkR1BEWWVvZTZtUUZVRm9iR2FDZjBiT2lzMFlFYTJvTlJnWlcwTTJF?=
 =?utf-8?B?ajFseHFuNUl2ZFI4M2hxNWkxMlhrakg1QmQ0Z2ZnMU5saGlRdHNiamhtZXR2?=
 =?utf-8?B?Q1k5NTh2cFUxd3JXRG9YQXB1M2NzMVZzVXpwYjNVb2JuYzFIZXBVa0FzYTA5?=
 =?utf-8?B?ZEEzSnB5WlBrT1VycDVGYWlKVFRpZllrT0xBNmU2UXBVL2JIZ0t5b1hycWRV?=
 =?utf-8?B?Vkl0MzlnSWsvQXJXYloxd2Y4K1R3NzM3VWszN3dLbUF1ZThqaTBQVXZOYTVQ?=
 =?utf-8?B?Zkd3emQ1NDdybWFJVzA0N1pLd043WnVNR012QURTNVl2dFJvR0pSZGh1b2ND?=
 =?utf-8?B?WE42VU1YL3hUNVZuQkpQUG40NDZKOSs5dTVwOFN6ZWd2eGlPckFWQ2NMcWFV?=
 =?utf-8?B?TTkwMWRVWUo5dWlQcVZTMFJ1bU1kczFrbXhCL2crQk1VWVpyWG5LTmswUEdy?=
 =?utf-8?B?bUcwV2J3c1lJY01pTUlJWUEzMWJPckkrNkNodTRnUnBobEdwMlF4dXpSZkxj?=
 =?utf-8?B?cS92MjdqQkdHTWpoaTcxM2pubVpXeW04V1luQ2JZdGlodFlURzhvdEdnRVFu?=
 =?utf-8?B?ZmVHT0RaNVovR3dWRGs5YTZsbko3dnJUbFllUkFITXFKanNsdEM4cVpITW02?=
 =?utf-8?B?SCtVRzRPbHl1SWdNRkRMMXJqaXM5eEFaaGNVZVEyM1ZjenpjVmlHQTQxb3Iv?=
 =?utf-8?B?ZVFPbCtlZmFuNmhvZlBaRDdnT2JkQjNxVU9mQ3RjbzRjMkRNSUtUK3E4ZTZw?=
 =?utf-8?B?U3Zac1F1SmExMHpMSEJhU1lvcW5lOFhCZGt0bGhWZGlvTDVBVGtKdGZNaEpK?=
 =?utf-8?B?Nzk2OHNhUGp1WjdxK2szQXNGWjJqSUZRNHhTc1JEZmZKUVlCMUlSeDduU0VB?=
 =?utf-8?B?NGxFSVp5RTQ1bFdsdnkySGFMOUViTHBYb1BGaGZyb3lKb1hvOURsaG5lNFdp?=
 =?utf-8?B?a1hjdHU3ZDloK3pPdVBsVW56SXQrOHZDMTB1RHVJQWhQZUFHK1hLaE5RdE1t?=
 =?utf-8?B?ODIvbmRleUVYY05QYTFUam1ZaDRwWm9GenRKZklOZFNxMTJlb1Q2ZWh0S1Fo?=
 =?utf-8?B?Y2hKRWdrRGNuOGdBK01FKy9IVXora2poTlZVeUwvdkpYTkkzZGd0S0ljcENX?=
 =?utf-8?B?UWJnRlp4NkRveWFyMnVScDJzZUJCcjFjUENtYURZSEFpVXF5UmhLNEZ3bW8v?=
 =?utf-8?B?cG5hK1pPY2JWNzhEdFE5NmxXYUFKcHFwOWFMQ1BHWE1aWjNMQ1lDWm4ra2Zt?=
 =?utf-8?B?cW03eTBya2kzY1o2Sk5ldmx5Tlp1bFl2bWFnRllmSmFnWnpQRFdpbFZua2xt?=
 =?utf-8?B?TzBoaWgwaGpyWEVxRHRrd2prQlhiampVWnhTSkJRM3dZUlBveHpNZTl3QXdQ?=
 =?utf-8?B?bXZpcUp3eGozalYvV0Z3dHlqOGpCWko4L2g1KzlpRUZlOUR4Y3RlamNuKzRW?=
 =?utf-8?B?cTF6eWVCQkY4bzBuZXVabGp3djh3QlcwYUdTb0R3WEZCMGdZb01jZE5FeW1T?=
 =?utf-8?B?NkM1d3JVSUFGVG8xai96OTlOOStVUzVycTNNTDVRNmU4U1BvWVpoOGpHdFNV?=
 =?utf-8?B?bm8rbXZsaWNIQll1Sm16U1dMaTJrVXNkZjAreXJQQ3d5TXpHVVhveVEwZS83?=
 =?utf-8?B?SFJ0cTNBOTVVdkZwR2treDZML2pNK3MraFZHYnp2UWphTis2UVN0V3RKQWNH?=
 =?utf-8?B?TG1aaEYxNFNIc3NKcEw5QjdnK2xDd3hVbmZyaUl4cENON0JlbGNMV0REQU1q?=
 =?utf-8?B?c0FmVzZwakJMdlFITitoZ3BQTEtMYmNJTGoxWTgrTS85WXowano3V0pHRjRy?=
 =?utf-8?B?WnlaTldydVNRdTkzOThVS1RrTkluU1ZIeS9mbTFMYW5ENG04dE8vTG4vV2lx?=
 =?utf-8?B?cTR4ajN2T1pFZmpDT2x4UFZodTNRYTBSdC9CZVNqTUdwUTRvbFBrTlhqQThV?=
 =?utf-8?B?UkpxMXlzMkJPZmd2V01rRWFWOEJKc2RraFhFWDdoUGh4Rm4vRzZSaWRaZWVY?=
 =?utf-8?B?VjlWSkxEdm96eDdjWkluNFFKVE5DdXVuYm90emErZGQ1aUd0Z1hMV3piMlZl?=
 =?utf-8?B?L0c1Zk1USzdaZEkzQUpBcGZweFFZNVg0Q01jV3BNUTFoeHRGMEZzemEzUS9F?=
 =?utf-8?B?aVNod2F6VmUzV29oaTRkUmZwbnpHRm1rSGxMMmoxUFFGTEhSdnVtL0NmUE5O?=
 =?utf-8?Q?KVCHU5eQwCGpXgTjjjLl0+o=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b3a5041d-310f-4f74-6596-08d9eae0af4b
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2022 08:54:58.5725
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3ikYjgXKNyszsVtrna3Lai7+fb69iuALAu3bpmPUdExXIP+tqqlObxHCcT2nBkK+9NiFAbDSidsBmNdB5P7ZdA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR03MB4544
X-OriginatorOrg: citrix.com

On Fri, Feb 04, 2022 at 02:56:43PM +0100, Jan Beulich wrote:
> Models 0F and 17 don't have PLATFORM_INFO documented. While it exists on
> at least model 0F, the information there doesn't match the scheme used
> on newer models (I'm observing a range of 700 ... 600 MHz reported on a
> Xeon E5345).

Maybe it would be best to limit ourselves to the models that have the
MSR documented in the SDM?

> 
> Sadly the Enhanced Intel Core instance of the table entry is not self-
> consistent: The numeric description of the low 3 bits doesn't match the
> subsequent more textual description in some of the cases; I'm using the
> former here.
> 
> Include the older Core model 0E as well as the two other Core2 models,
> none of which have respective MSR tables in the SDM.
> 
> Fixes: f6b6517cd5db ("x86: retrieve and log CPU frequency information")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> While the SDM table for the two models lists FSB_FREQ, I'm afraid its
> information is of little use here: If anything it could serve as a
> reference for the frequency determined by calibrate_APIC_clock().
> ---
> RFC: I may want to rebase over Roger's addition of intel-family.h, but
>      first of all I wanted to see whether going this route is deemed
>      acceptable at all.
> 
> --- a/xen/arch/x86/cpu/intel.c
> +++ b/xen/arch/x86/cpu/intel.c
> @@ -435,6 +435,26 @@ static void intel_log_freq(const struct
>          if ( c->x86 == 6 )
>              switch ( c->x86_model )
>              {
> +                static const unsigned short core_factors[] =
> +                    { 26667, 13333, 20000, 16667, 33333, 10000, 40000 };
> +
> +            case 0x0e: /* Core */
> +            case 0x0f: case 0x16: case 0x17: case 0x1d: /* Core2 */
> +                /*
> +                 * PLATFORM_INFO, while not documented for these, appears to
> +                 * exist in at least some cases, but what it holds doesn't
> +                 * match the scheme used by newer CPUs.  At a guess, the min
> +                 * and max fields look to be reversed, while the scaling
> +                 * factor is encoded in FSB_FREQ.
> +                 */
> +                if ( min_ratio > max_ratio )
> +                    SWAP(min_ratio, max_ratio);
> +                if ( rdmsr_safe(MSR_FSB_FREQ, msrval) ||
> +                     (msrval &= 7) >= ARRAY_SIZE(core_factors) )
> +                    return;
> +                factor = core_factors[msrval];
> +                break;
> +
>              case 0x1a: case 0x1e: case 0x1f: case 0x2e: /* Nehalem */
>              case 0x25: case 0x2c: case 0x2f: /* Westmere */
>                  factor = 13333;

Seeing that the MSR is present on non documented models and has
unknown behavior we might want to further sanity check that min < max
before printing anything?

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 08:57:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 08:57:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267725.461467 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHMJy-0003dc-AZ; Tue, 08 Feb 2022 08:57:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267725.461467; Tue, 08 Feb 2022 08:57:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHMJy-0003dV-7d; Tue, 08 Feb 2022 08:57:58 +0000
Received: by outflank-mailman (input) for mailman id 267725;
 Tue, 08 Feb 2022 08:57:56 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=v7zX=SX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nHMJw-0003dP-6d
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 08:57:56 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 344b9ab2-88bd-11ec-8eb8-a37418f5ba1a;
 Tue, 08 Feb 2022 09:57:55 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2168.outbound.protection.outlook.com [104.47.17.168]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-2-3_QhDEF2M8-yvaRLQSaHxg-1; Tue, 08 Feb 2022 09:57:52 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AS8PR04MB7910.eurprd04.prod.outlook.com (2603:10a6:20b:288::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Tue, 8 Feb
 2022 08:57:50 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.018; Tue, 8 Feb 2022
 08:57:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 344b9ab2-88bd-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644310674;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=57KXD0Mw/Olurv+X1wKI+uUEAzaWfdQio3M/j+pHrU4=;
	b=F+s4oQ9+MUDog8wa5yxCMvjjfTtNP1m4f9aQSJZMsXWW9dBci5T9uNcXo0+jTlStrkDfua
	d8UVq+vCE1d3QAYsfHTwaFHdoLjvpvEMkxOINNEHBBfdddHHLrT0oT2Rpe+r2OEjLS9oQv
	6ZDEyvcZv+p0TPcHkykjZRYtygh9/ww=
X-MC-Unique: 3_QhDEF2M8-yvaRLQSaHxg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=edp6yAZKeXhGos7Ffh0y2w3rfh132E93j17H5317ad1gM1u8T2MAT/BUjkKE365j02tQaGWFY8tRDKLFl4Hz8MrtrK3oyS5H1I8OU+La60f8fdRQpyAdCG8ojnG2b0RGlBA5SltM7XN0jIcFVqz9okphM3g+Vbp+Cu4VqfcYKKMpeMzRyrlQmcqZqPiWgp2nMDZw6dWLlqVDH9bZ8N9CwhybX36U0l41bc5krpnEIRV4FwFWH+S1SkCHSCwm17+5NfSK+Rtp8jI2w3Tq2xCvk49qwv4E7vgp4SwlarTjN47OqNvLocyiTVKtAioLaJfTl+nJuSqOZayGz0VNGMhpxQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=r6dl6oDcwP6vNPLsSPRdvGWsCVk6qpkkuzkbgkHQM24=;
 b=H/DE5BMdOnzdw9H0L99C26dN9flvC58GB+xwE5SoPwbYNulIQrCyK57JBp0Ka8Da6p9UFAOqwPwzojS01USb5B4LfcL3w4ZhXYkgAJCXTudczmoDRc9+aQiSxapcCPRLbXeWutBVB/QFJqLMBMtA/mcNqtt/AqLR9GOT7nVNcmv9OtkK1/z2HSyoScVOxmQSJ83nQdB9fubT8PGvD52VKoGYs517Lq4Z8mmItw1CWY38fz1MsBQLareR5hSknxuAnLPDFwMW3LLpA4CZgxi72NUl8DFQbmaekue2GwJG0OviQ6RDeFg13oexDtPiMjf9X4fXDgy4C3PbSynq0XWkaQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <72abc2b2-7141-0460-2b5a-e27cfa8457f1@suse.com>
Date: Tue, 8 Feb 2022 09:57:47 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Content-Language: en-US
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: "julien@xen.org" <julien@xen.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Artem Mygaiev <Artem_Mygaiev@epam.com>,
 "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
 "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
 "paul@xen.org" <paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <7e3562b5-fc67-f213-e872-f211450d9e2e@epam.com>
 <a8fc599c-f620-c4d1-2077-c57068f46a7f@suse.com>
 <deef8468-d607-e49e-f456-6a8013329ca1@epam.com>
 <Yf0k6aoKK5G3iad1@Air-de-Roger>
 <3ad10a99-c706-b95f-1419-2c0c7cf37d58@epam.com>
 <Yf0+3C9nF8+tewLw@Air-de-Roger>
 <c5fea3bb-834b-eeb7-d7a1-1ee609037a9f@epam.com>
 <YgEUwTxhnWVMGMJK@Air-de-Roger>
 <9ce90193-74a0-5642-d22b-6b8c3340c3cf@epam.com>
 <1f65ae7a-898d-2c27-0ada-d71d778b0627@suse.com>
 <YgEsRuckQJIQlkzf@Air-de-Roger>
 <a2a42c1d-d379-00cd-5d55-f443cdb02e97@epam.com>
 <e8fc7872-c7d0-f389-c507-335b809ffcbc@epam.com>
 <21c8125a-2f79-1a4a-494c-db9e4be2a1a6@suse.com>
 <4276fe72-558b-7d95-6430-d4330989dbe8@epam.com>
 <ad985f4a-10f0-4a2d-df02-cde915fea3f1@suse.com>
 <f7669670-8eeb-9966-5ba3-e8f9c03ce3d3@epam.com>
 <73e08285-6bb1-5842-899f-bd6502406e49@suse.com>
 <be3f4222-6580-4c89-a202-c003b6feb9b4@epam.com>
 <e91965c5-0802-adf8-0c17-522f86ebf231@epam.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <e91965c5-0802-adf8-0c17-522f86ebf231@epam.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS8P189CA0003.EURP189.PROD.OUTLOOK.COM
 (2603:10a6:20b:31f::17) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 51be837c-ff2e-4687-665c-08d9eae11557
X-MS-TrafficTypeDiagnostic: AS8PR04MB7910:EE_
X-Microsoft-Antispam-PRVS:
	<AS8PR04MB7910878E794C652A4900B5F7B32D9@AS8PR04MB7910.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	TWFES3cz3EtO31PSBCGL7HzWXfNedOv00TA4wUGGMmzSux1wcsCZOJawJy6GkZCEt9aaezSe0IGfC4NBU5wwlkTwjS4Nnc6IitZ9Gt9EEXnApVsOWs+XDwkj9YbdXxiwtzsx9NxN3vyGqLT+SL2fUBMATGucYmsoyqkys5OVBS0vXe+6A7RarqP56DQw1w6t6CwMOGhn3q3wGhX0d2ppXYWp8p7n5eGmGJcQNmovr+gU7LEy6VrB653vkw2FPuVQtXWrlSP5ki1Vgl7osEkOvW+B1jFizNg8ZXotU/fQfexCRBTICpZ5DrpEpvyypCqggW1w+pZncfWDruD+vucd9hBPAq5AQplqZzhcLCYrdaNaPJoRxJY53nnUB9YngPdrM2K10iJoMPSbReFu5KU6g2En3zJnvCrE0Z3CZa1p5vgqt+KW+z/UA30j5fQNcJHibd5OCs5qa/qvHvL31fjJzsnHptsuydrjG9uJEZ2DqeVrcnEd+Fjfr6J4gmBXAjXybTF7FJUGqwzoV//Sjd1pJHYY45B31BhbzDJSw3Kw2uPRTRuVyWZA2cbWqmj8q82voKhYnGWE0oivx2KD4NsOZXpulToErbFCOnXDa28AjDmEz5AkGjd9WKCEKLdqi7/y5uaTYtPErEfM2iyHt5nMU6nuBdNAGYdhPtdjccWP7KnIVwFrvat8KIxIyGB8kaSKvzM7aSGDNdBBiyVQcNbg06VXyGfMITqvegfwzER5yXc=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2616005)(53546011)(6506007)(6512007)(31696002)(31686004)(38100700002)(2906002)(86362001)(508600001)(54906003)(83380400001)(316002)(26005)(6916009)(186003)(36756003)(4744005)(8936002)(5660300002)(66946007)(8676002)(66556008)(66476007)(6486002)(7416002)(4326008)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?NeBCdIjl3Q5mYTxGQepgZTWPsdRtw/ofU/GdcvnnPbYJfgtrqIlW8bBxl52t?=
 =?us-ascii?Q?OLpXzo5fBPdfQXXgNsAHiY5xYFz2VWEbWGuRBZRgdipwdcIvg3QjimLmhY4o?=
 =?us-ascii?Q?Nm0K2Ha0OC76946sOz82Eu3Kdst0bL/wA72Sd//rI/i2nNbGXnhnqkb4jS8H?=
 =?us-ascii?Q?IMDqV3CNRDiAeMFhuLJjjFj/L9d1fwzbTOWwd9yK6YVGIfREy1eFhWzCIShr?=
 =?us-ascii?Q?nVv7hex+id6tWp9w8MBP2BcnlYs93+362kO73J1s4xkv4nAkVQq6gluTz824?=
 =?us-ascii?Q?F3H3GXPfe9JD2KW3n5jdxgFc4ZDTmFloJg9ZkqkijAeHNZe9XOdghCvf3wkO?=
 =?us-ascii?Q?4Ny4Avo3vkTvdBd6IEUS8/BhWPAhLHibt7dbKmBzhEq6NKr+n4hq5wNm+dcg?=
 =?us-ascii?Q?I9H2aM5uF9lsbaKgy3tq2to58KZEdhbHS7DxL0Oz6TF976sI/QzTl8S9cL9y?=
 =?us-ascii?Q?MYLQPFLUq603elDv/DJzoyfvDhi4DWBJDAmlcUUhjoOAg3nV3yiM621InMk0?=
 =?us-ascii?Q?mSKIRrirPNJYhXAq5PeSu4Yu+cmVcMG6NCiSFJd6V1ssBME9W8FBgvlNKhSq?=
 =?us-ascii?Q?wTqyzQwJtpvgS7TXHQ8sfsLENBUZvUXxxTlrHkIJxobPcevsFPPEHjsfStT7?=
 =?us-ascii?Q?s7bWElcxDfB6WiodEdKN75Xv/Lman9MiDGiACQFwHWFUDovlZjwhS4/yOJXB?=
 =?us-ascii?Q?2XMysLi8DUOV7vZ1ehVydBBhourCaRvxu0RM4FfzGYsTbuPGmA/DBwWMr+VY?=
 =?us-ascii?Q?yOCUto8I/FGsOVGc73ES2qnQniSF4uNJq1Q/gHgZr5lzNYq81n+hjvTehZ0U?=
 =?us-ascii?Q?auXZBUBzvx29NqTahpd6ODy3/f0/xkE31c4KwaHPd2GPcljTQpT+PFj09ZK5?=
 =?us-ascii?Q?1jNWFhgXaHQ3jROBDtBAyb5m6ZumsMIbmw90/5QHXZL5quap55wFhAesGhB+?=
 =?us-ascii?Q?f9yZ3fnnCqlIISETec2sPGbTQG5B4d7IdnjE8VWsjKtVsqyuAz4+IedqXGFl?=
 =?us-ascii?Q?HOVSwn8FxSvuZmAzDNu7ltQlhYHeHqoWBuZhttfUq8kggWrlVl7c5g6hC3I+?=
 =?us-ascii?Q?NgtVvNEXzKCDgzySg8pNRNrDS6ynDNvNtfp00/OB4ATx+7TkGG0Tzyc3CzJA?=
 =?us-ascii?Q?IKqkDz6HfKCDnlfOseXtklzriovcfV/Scb0qLQm+qGdk7QqhVY76yWaWE8f6?=
 =?us-ascii?Q?YPdKrAURggaguf0ku7CWe67Ti7Vu7P+Nu7vS3igJ+7+u+hujr7xitFxUOCrO?=
 =?us-ascii?Q?ZqYAvMe5R3D2q0GsOABBQxGTmg4ZWt9EAXM7BOSytlB0jzFLtUTYsA/qPJ6G?=
 =?us-ascii?Q?vEbRVqUSqRrRD0DoYUMSpY13a7g3hnNP6ab8KcsqLlI4fNhUpSlhurcuxpgJ?=
 =?us-ascii?Q?lBjycX08YvDXoLD55TcSx5cEejQLT691zJf01NXNqYa+wE4j4ZViDbkjwzA7?=
 =?us-ascii?Q?+amWgyfonIy7mQ4sEosGUeB14bfWVrj4hm0TJSbzjyzX+DGUm7WWS6kVFjqr?=
 =?us-ascii?Q?e65urQQSneY4A57HoaAF8HpMhFNZs2e+K/CiMAaOBo5Sj5gDOe6dlpIwYadF?=
 =?us-ascii?Q?UhVBKYIn7jEnlDfFKn9IdDOjdqDgSG3Ix6ImKrhcpGJguBxH7aOETqGjDM6X?=
 =?us-ascii?Q?L3zskBeFeOuiZuHIIxOdYX4=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 51be837c-ff2e-4687-665c-08d9eae11557
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2022 08:57:49.7476
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DvQGoQS+qMb4lfWwFW7RV4zRwpZXTjGQK3d50Oc6mzh34s61pJWdWRV43vnv7yJ/ii9IUfKIb5QHm8wHWId5Cw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7910

On 08.02.2022 08:35, Oleksandr Andrushchenko wrote:
> 1.1. Semi read lock upgrade in modify bars
> --------------------------------------------------------------
> In this case both vpci_read and vpci_write take a read lock and when it c=
omes
> to modify_bars:
>=20
> 1. read_unlock(d->vpci_lock)
> 2. write_lock(d->vpci_lock)
> 3. Check that pdev->vpci is still available and is the same object:
> if (pdev->vpci && (pdev->vpci =3D=3D old_vpci) )
> {
>  =C2=A0=C2=A0=C2=A0 /* vpci structure is valid and can be used. */
> }
> else
> {
>  =C2=A0=C2=A0=C2=A0 /* vpci has gone, return an error. */
> }
>=20
> Pros:
> - no per-device vpci lock is needed?
> - solves overlap code ABBA in modify_bars
> - readers and writers are NOT serialized
> - NO need to carefully select read paths, so they are guaranteed not to l=
ead
>  =C2=A0 to lock upgrade use-cases
>=20
> Cons:
> - ???

The "pdev->vpci =3D=3D old_vpci" is fragile: The struct may have got re-
allocated, and it just so happened that the two pointers are identical.

Same then for the subsequent variant 2.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Feb 08 08:59:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 08:59:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267734.461478 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHMKu-0004Gd-OE; Tue, 08 Feb 2022 08:58:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267734.461478; Tue, 08 Feb 2022 08:58:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHMKu-0004GW-LC; Tue, 08 Feb 2022 08:58:56 +0000
Received: by outflank-mailman (input) for mailman id 267734;
 Tue, 08 Feb 2022 08:58:56 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TmAy=SX=citrix.com=christian.lindig@srs-se1.protection.inumbo.net>)
 id 1nHMKt-0003dP-Tt
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 08:58:56 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 56beed16-88bd-11ec-8eb8-a37418f5ba1a;
 Tue, 08 Feb 2022 09:58:54 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 56beed16-88bd-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644310734;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=KPqJWwlmSdJnpx/V+aN+IcuNCswiRiSX4GL66+bs5lU=;
  b=feCm762DA/QeXMtapjPAQK1qTU88KURWY59NjmScDFRCjem1TFKIIKDy
   ynXuiN5EQswvY7ns73ysKxmE3B2A1+DOv7vyl9cimGiHbeOsOFIG2BVIW
   7kKOrYNXH5aa5PAE4U5EDFqPcEA1TJn+/s2dplXexOPJv2j1qHEJY7L44
   o=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: KsfmmoQRs6pvMOzWaltaPrKXYUiUbkqYJ+zrxcqQirnFdwo8zIctL/p91fybv/8yT15OiECrO7
 99k+zTk+M54HD7n9mnk2dcxlW+2oDnVmdysPpR8urubxxbnLAsmQV5rAXMfqrjHEyuHiwiduMj
 vPc3WGm3MnATOFUzijKZto/fhD875+2QbzmziN2UocTOt/k7yyhVzXU447rqNSRDb3XdhbDP3G
 hlNdNbCcA8UPv+rWDgbLCv5l9FDxjNUjhAZg4gIMe6QGssI44FrSRFHlvSapMP3nnMa7ZXZ+pn
 qoHSt4Aka1lbgJ6qEnald6Lt
X-SBRS: 5.1
X-MesageID: 63624584
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:2/rtbq+mRzM2tECfUMq+DrUDwXiTJUtcMsCJ2f8bNWPcYEJGY0x3y
 GodWGzUMqzeNjSgKo13O9+3/R4E78TXxtdjGQZlrig8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhFWeIdA970Ug5w7Rh0tYx6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPh+l
 NJphIHzTz53P4qUu8swXwYIDBhXaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguwoLNPqJ58es3cmyTDfAfcpaZvCX7/L9ZlT2zJYasVmQ62AP
 ZZEOWYHgBLoMhxkIkstLMkFxsyCikH8MCddiAqTjP9ii4TU5FMoi+W8WDbPQfSRXtlclEuco
 mPA/kz6DwscOdjZziCKmlqum+vOkCXTSI8UUrqi+ZZCvlqXwWACDQwMYnGyq/K5l02WVspWL
 gof/S9GhaQ76kGDVNT2WBy85nmesXY0RN54A+A8rgaXxcL88wufQ2QJUDNFQNgnr9MtAywn0
 EeTmNHkDiApt6eaIVqf/LqJqTK5OQAOMHQPIyQDSGMt4db5p5oopgnSVdslG6mw5uAZAhmpn
 WrM9nJnwexO04hbjM1X4GwrnRqj+p/tfxN24DyJX0X9zSxUaJH1eLWBvA2zAel7EK6VSVyIv
 X4hkseY7fwTAZzlqBFhUNnhD5nyua/bbWS0bUpHWsB4qm/zoyLLkZV4vWkmTHqFJProbtMAj
 KX7nQpKrKFeM3KxBUOcS9LgUp96pUQM+DmMaxw1UjasSsUrHONk1Hs3DaJ144wKuBJ9+ZzTw
 b/BLa6R4Y8yUMyLNgaeSeYHyqMMzSsj327VTp2T5035jebHNSfMF+ZfaQDmggUFAESs+lS9z
 jqiH5HSl0U3vBPWPkE7DrL/3XhVdCNmVPgaWuRcd/KZIxoOJY3SI6S5/F/VQKQ8x/49vr6Rp
 hmVAxYEoHKi1SyvAVjbMRhLNeKwNb4h9ihTFXJ3Yj6VN40LPN/HAFE3LMBsI9HKNYVLkJZJc
 hXyU5/YXa0UF2+Xom91gFuUhNUKSSlHTDmmZkKNSDM+Y4RhV0rO/NrldRHo7y4AEmy8ss5Wn
 lFq/lqzrUMrS1swAcDIRuioyl/t73ERlPgrBxnDI8VJeVWq+49vcnSjgvgyKsAKCBPC2jrFi
 FrGXUZG/bHA890v7d3EpaGYtIP1QeFwKVVXQjvA5rGsOCiEomf6md1cUPyFdCz2XX/v/Pnwf
 v1cyvzxaaVVnFtDv4dmPaxsyKYyu4nmq7NAl1w2F3TXdVW7TLhnJyDej8VIs6RMwJ5fuBe3B
 R3TqoULZ+3RNZq8QlALJQcjYuCS7t0um2HfvaYvPUH3xC5r577bA09cCAaB1X5GJ7xvPYJ7n
 ep44JwK6xaygwYBO8qdinwG7HyFK3ENXvl1tpweB4O32AMnxksbPM7ZAy7yppqOd89NIg8hJ
 TrN3PjOgLFVx0zjdXsvFCeSgboB1MpW4B0ankUfI1mpm8begq5l1RJcxj07UwBJw0gVyOl0I
 GVqaxV4KKjmE+2EXySfs7RAwz18OSA=
IronPort-HdrOrdr: A9a23:6gVpIaAnwc9wmg/lHemo55DYdb4zR+YMi2TDsHoBLiC9E/bo8/
 xG+c5x6faaslossR0b9uxoW5PhfZq/z/BICOAqVN/JMTUO01HIEKhSqafk3j38C2nf24dmpM
 JdmnFFeb7N5I5B/KTH3DU=
X-IronPort-AV: E=Sophos;i="5.88,352,1635220800"; 
   d="scan'208";a="63624584"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=RtRZFmzWv7z3dnnNMm6pQt7ACv2fuCftU/oZd6CA4Tygqz9qVBC+C1Me27NO3l3uD480TkVYjDXrMIwD5f9pZdqRqCgfL1M/thNL99YrtAJ2A3KsQ/hv5qLptvKCO8y0B9eDySbdH6z/nJ7RFJtOO2we7/XfQuZld6BiimrJfNWMYaaZNVSnjbvCpDUS3x57PXv3vRrWBLf7AMiCkoAKYWN0nPstSctiRw+RcxHR3kOsN0thOonKdo710fg5Nr5EGjoghDcYh8Le6zs/vKU34s+2jqUB6cb6prs/a3IyiqUoiWvYgmh+lQMhxO9U+QI9jcGOWcTxL+LXiX6LkjtBtg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=KPqJWwlmSdJnpx/V+aN+IcuNCswiRiSX4GL66+bs5lU=;
 b=N2SodKpmzRgC9YuqmDbzqJqEpgqg7nUR0+SLFxXt6wjkki4QmR9KtLYyohqkra8KAOBMN2uWr2azOOyoul6kipIXCsIBgVTOlavTDWDNIfS+Bp87dlkvlWPompDXSSghSeGj+kLJ5H7kl092tuG7TDqBMmrknNse5BW8Xt2oMwSS5ttCNql5NQD4fYDU0W+2ANSa3kZK/3DLkYwApkmSUKeZcON0BGiDvZcx1xjphtW/ujm+ZAVVhsA/k2Se7Zpd1uqOsS0Ecy1XDKtQsLeLSRjlm57q1LriENCHtC42ieKqurx9woXPC7teDt5GApw2LqOP18CjhGVei8mGDqSyJA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=KPqJWwlmSdJnpx/V+aN+IcuNCswiRiSX4GL66+bs5lU=;
 b=uTREwKehxRtkea71P322lXcvt5SWSmV5JNmNf4+072G50tu63h+Gr5KYzaeObH6MdSKgGQ3kv83UDgf9Bu0ct1eYYFGebZZHL1ch6esbb5pvEoKoR8S40MrAC9HKAuYdREonangy6NHbUWZ/l1E51hYCXmXpuZVVJPnhYCgaBbA=
From: Christian Lindig <christian.lindig@citrix.com>
To: Jane Malalane <Jane.Malalane@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>, "Anthony
 Perard" <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, "Andrew
 Cooper" <Andrew.Cooper3@citrix.com>, George Dunlap
	<George.Dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, Julien Grall
	<julien@xen.org>, "Stefano Stabellini" <sstabellini@kernel.org>, David Scott
	<dave@recoil.org>, "Volodymyr Babchuk" <Volodymyr_Babchuk@epam.com>, Roger
 Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH v2 2/2] x86/xen: Allow per-domain usage of hardware
 virtualized APIC
Thread-Topic: [PATCH v2 2/2] x86/xen: Allow per-domain usage of hardware
 virtualized APIC
Thread-Index: AQHYHE+boVbNzdga3UeMIxC2+V/CvKyJW4wA
Date: Tue, 8 Feb 2022 08:58:49 +0000
Message-ID: <4DD3528E-0B3C-47C2-A037-FFE821D448E9@citrix.com>
References: <20220207182101.31941-1-jane.malalane@citrix.com>
 <20220207182101.31941-3-jane.malalane@citrix.com>
In-Reply-To: <20220207182101.31941-3-jane.malalane@citrix.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3608.120.23.2.4)
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: c33cd8de-eea3-4c46-5311-08d9eae138fe
x-ms-traffictypediagnostic: BL0PR03MB4082:EE_
x-microsoft-antispam-prvs: <BL0PR03MB4082ACE6A2958F1891012725F62D9@BL0PR03MB4082.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:6430;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: veGqc6MmOGbRe3gC5+zT8c+l93T/94DQhJxLt7X9zKNc7aXH/RG46E9AXhHjpKrZq11k1/MBgZkpV+gtvFAj+iFb8kvtmePob2IQNNcrnvJqO5gNRcAmMDZ6t4YTezyiq6QfxLEUpYzsfYPG5mlQS+byl3GCXzwmKFnIKJERPAhBVdJ5tDb1j94IxrL3JFtLe0dC6kNpDF8xHwaHAZbGtrbwHP0OI8s5C7PtZRMfAuzj/mBoAptt6qN36OPo9Xldk9f09qOpdHvZFyk2lqkWMH+N8DMVhr8Pb8G0Wusbm+NDWRkdtoyRFYKJh8tS6IkTxgHmRUJbX+6iBQ1B8116a8P7+n5XEh4UOcGUQDrzAFEqFiMaWvdB3b3D3HjgUHQtiGXIoLTCSoogjPLsfhG1bCNulCNrqyrRJOEXsRfakJ1HccCd1hWryQvzENLPUAU0gUzdPKUtkQq4BOKRCb399E3wAoz6OMvIFF0lnSdO74gfbrpfGclD0l+QKSNOW6+VauFIhcQqXiVvR8cA1UG7MBAZzNoJBK5J79IJk3LQ1DsCEMIBG8ARMqdx3yPhrRE/C1YKvm2g++38JuKqZYl9lrTTdcDNp7Y9CjvODCO5RFh6yfa15kKBoPx1bBmh5FZ84MwEbIEJWmueRMQ/s6gZ8eKZ6i80t4NayhiP5bXfuHUaeLkqfdQzg8I9nnKRi+1DPVlzd+fEzYZgMXoety/qeXs4jN0o3IxrsPwTDP2/Pco=
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR03MB6539.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(508600001)(91956017)(53546011)(36756003)(316002)(6512007)(6506007)(33656002)(82960400001)(37006003)(4326008)(6862004)(66446008)(66946007)(66556008)(8936002)(5660300002)(76116006)(44832011)(66476007)(38070700005)(8676002)(6636002)(2906002)(86362001)(64756008)(38100700002)(122000001)(6486002)(186003)(2616005)(107886003)(26005)(83380400001)(54906003)(71200400001)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?T0hYMXJsSmU3bHVXcXVhcmZBTHdHWjJEM3lmckhLTlVTNHFIQjN3Z0M4R2JT?=
 =?utf-8?B?emE1R0RJTURTSGszOXMrZlYwbHdDbDlnSHdFZzNHQktFck04V2ZXQnJpOUJJ?=
 =?utf-8?B?VWRNejQ1K1Q4cDhJWjFZaFFDR0FNVUZGQ2l2d0s1RzlFZ3FMb2ZabFk0cjNV?=
 =?utf-8?B?aGpwS3MrUTE0QmZ0aWNaekh5UUsybzM3ZDdyaGM0cW1aZUV0c1g1Wjd6VGgv?=
 =?utf-8?B?L3I2Vnp3Z0daZElNajhCTW1wOERsa3pHZU5nNUJEeklrU2d2WVRGNkd1Nm5h?=
 =?utf-8?B?RkFBVW80MmpHSmp1c1dqVU9vQWtLanhhVU8wcWt6UmpoWnZJMUNwY0M4dExk?=
 =?utf-8?B?UDBYM2Jlei8rQThnUklES29VTGhXR2NtTjkwSzB5dHZDc3BuYjBnbExDQ3VT?=
 =?utf-8?B?OTBIanZlSXJIRmtVVnZ2a1dPV29TcEJpd1A0Vi82ejNLOGhsTmMwMDRxZnI3?=
 =?utf-8?B?dEd5eUkxVXRtTGVudGVqYzBGQUxHakh4R0x5RFlFeUFPZU4vN2tsTWVUZFdm?=
 =?utf-8?B?WjhtanBHOC9aSHZDSWNJeHJKL1U4MU1TWkZuU0h0UEhPZDFseHhpQ25aRFhR?=
 =?utf-8?B?d3FlZk50Zk9CUFFrcmdIbURBK00zdmNNZEpCNy9WbUxHOVc2czB5ZGhISTlI?=
 =?utf-8?B?TFFRQzVlS3N5TGh3Z2lUNGVnOHZuRkp6Y3JkZjRIaVdhV0VhZ2tGMC9VbGUz?=
 =?utf-8?B?Z0xWV2dPYXBpZUUvRC9QL29IZXJleTlmU0FmYzY2UlZnNHFPZHkyRUxyNnl6?=
 =?utf-8?B?ZVVLQVo5R3hhRXpzMzNuaGQ1amNPS25RZW9FTTR0VVRmejM0cVdSS0p6RHlr?=
 =?utf-8?B?OWt3TzRQYTJEZlN1eXo5U0QwejdWTmE5cDhZT1hYUWI2RTRMVFBhWW0rS2I1?=
 =?utf-8?B?am9jaHcrdW9DaEx3V0tVR0Iyd0VsTVl0bWo1eXBRcEVRMWQwY0Y3T0VIRDFD?=
 =?utf-8?B?OG1zclpmdjlNbmc5S2dwc1paenNXbFlTUHNtWEdQVWExTENud2JrZWErT2Z0?=
 =?utf-8?B?VVBmTUVCMmUrSENYZ2VkOHB0d2M1ZUpFaFJBQ2VtWVcyRDRsM2dsUVhYcmwy?=
 =?utf-8?B?a2ZGTzJ5Vy8rN1VZZVdVbGdIS0tjQWJaMllBakM2ei9KaExpN0t0Q25YNDdw?=
 =?utf-8?B?dW12K2hsS2NOYkJ4UWZmQ2wwSDRHNlZGMUdueXEvWFR5NlBkMzlDdisrakJp?=
 =?utf-8?B?ZnRYcGxzRWpwTHo5WXJOWnhESnZNWUNjZjlCaTNJbU5IYzF0VEUxWEdRVjF6?=
 =?utf-8?B?WDdZN3hyMUM2RlBiRU1INUVlTlVqdGkwRkEzWFMrSmZXazZtaVBZS0JRdFlW?=
 =?utf-8?B?OHdzdnVQY25zMk9Yd1ZMUnlxT2VZSTNQQ21LVVU1cmsxT3RBRnJXZ3JtQyt6?=
 =?utf-8?B?dVRGWU9RUFprekt6Z1NwbTdldk1BTEtGN2cvVlZwK1Z1UVFsWVhRbm1UdTN1?=
 =?utf-8?B?WHNwMnEya2xYVTZSait2a0Z5K091ZzdnWGtZL1NQbHZKZ2kvTXBRSTQ4cHFB?=
 =?utf-8?B?eUl0cXNzaW9tdE5QaDZOVk5lWktQaFVsSnJ6d2lXbW5wWTcwbFoybXduMFhP?=
 =?utf-8?B?cFhWVHRRY2x2NFlXWUhqcjJwdUpKemFLRmpyTEdORDJQRTVpcmJ1anNVbFBw?=
 =?utf-8?B?OFY3UnZ4SmlubW44bElGWnZ4cHA3RWZMTkxRSGg3Qi9YN0VZcVhPS25yejgw?=
 =?utf-8?B?N2JZR0FLV0FwS3F2R0JVOVcvU0dPYmRVV3hSU2pjbUllbm5RdkJKNlE5VDFz?=
 =?utf-8?B?WldURElxTnl2UGVlVWxtUXNMdGg3SHlPRTlGM084OTloSkU4d2pRTlFmVStU?=
 =?utf-8?B?MlZsSGcrS3oyMnpubDNPVGRhNzB3anpoY0FQWFBmcUl4Ym9TUVNraXM0b2RZ?=
 =?utf-8?B?cUY4SitmdCtuQXdMVEtYVEt1UFJWdXBzSTJUOWRYVlVpZGFwTFdPejl1TzNB?=
 =?utf-8?B?citDNVU0Wk5ZMW1VcXg2VjlYZ3h3RUhYdUhKOEFoZ2NKYUhHRWszM0Z5d3Ix?=
 =?utf-8?B?a3N4Ky9zY0lIRnRHUmNrcmdnNUxUMzY1TVZBWkJVWjFoNUNuSjZxeDExQWhh?=
 =?utf-8?B?MEtGMFdlVXV5UzFHQjgxc3l2eGM0N2N0MHc1dm51Q3RZY3lZRFIybXRSWlZw?=
 =?utf-8?B?QlNkTDFBaEZPV1dRUjBRSlMwOHJUL0pjQnpVT0VzQUE1ZU42QTJOS3QrZnpj?=
 =?utf-8?B?aXp1aG5UMThhQlVqd0k3WlBRdlIvZ3ZIUzExUE5PcEZPc1cwbmh5L1hnaHdT?=
 =?utf-8?Q?r6/NWAHUYknGD9cSDx2yTJfqeGEzHjpfdqLOjjZZ88=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <DCD6F1536195A544A141E6BA275C3F1E@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW4PR03MB6539.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c33cd8de-eea3-4c46-5311-08d9eae138fe
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2022 08:58:49.2025
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 23VigYYJkmYoeSsE88mAxz8M1SXqWPYLbm4fpMzsJ4RqZJrR8usnRGaNbGBGKl3/N/uhjXgBYxCJ8MYocrE+aakSEIPW3o5a6nvC6b2ep7E=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR03MB4082
X-OriginatorOrg: citrix.com

DQoNCj4gT24gNyBGZWIgMjAyMiwgYXQgMTg6MjEsIEphbmUgTWFsYWxhbmUgPGphbmUubWFsYWxh
bmVAY2l0cml4LmNvbT4gd3JvdGU6DQo+IA0KPiBJbnRyb2R1Y2UgYSBuZXcgcGVyLWRvbWFpbiBj
cmVhdGlvbiB4ODYgc3BlY2lmaWMgZmxhZyB0bw0KPiBzZWxlY3Qgd2hldGhlciBoYXJkd2FyZSBh
c3Npc3RlZCB2aXJ0dWFsaXphdGlvbiBzaG91bGQgYmUgdXNlZCBmb3INCj4geHsyfUFQSUMuDQo+
IA0KPiAtLS0NCj4gZG9jcy9tYW4veGwuY2ZnLjUucG9kLmluICAgICAgICAgICAgICB8IDEwICsr
KysrKysrKysNCj4gZG9jcy9tYW4veGwuY29uZi41LnBvZC5pbiAgICAgICAgICAgICB8IDEyICsr
KysrKysrKysrKw0KPiB0b29scy9nb2xhbmcveGVubGlnaHQvaGVscGVycy5nZW4uZ28gIHwgMTIg
KysrKysrKysrKysrDQo+IHRvb2xzL2luY2x1ZGUvbGlieGwuaCAgICAgICAgICAgICAgICAgfCAg
NyArKysrKysrDQo+IHRvb2xzL2xpYnMvbGlnaHQvbGlieGxfYXJjaC5oICAgICAgICAgfCAgNSAr
KystLQ0KPiB0b29scy9saWJzL2xpZ2h0L2xpYnhsX2FybS5jICAgICAgICAgIHwgIDcgKysrKyst
LQ0KPiB0b29scy9saWJzL2xpZ2h0L2xpYnhsX2NyZWF0ZS5jICAgICAgIHwgMjMgKysrKysrKysr
KysrKystLS0tLS0tLS0NCj4gdG9vbHMvbGlicy9saWdodC9saWJ4bF90eXBlcy5pZGwgICAgICB8
ICAyICsrDQo+IHRvb2xzL2xpYnMvbGlnaHQvbGlieGxfeDg2LmMgICAgICAgICAgfCAzMSArKysr
KysrKysrKysrKysrKysrKysrKysrKysrKy0tDQo+IHRvb2xzL29jYW1sL2xpYnMveGMveGVuY3Ry
bC5tbCAgICAgICAgfCAgMiArKw0KPiB0b29scy9vY2FtbC9saWJzL3hjL3hlbmN0cmwubWxpICAg
ICAgIHwgIDIgKysNCj4gdG9vbHMvb2NhbWwvbGlicy94Yy94ZW5jdHJsX3N0dWJzLmMgICB8ICAy
ICstDQo+IHRvb2xzL3hsL3hsLmMgICAgICAgICAgICAgICAgICAgICAgICAgfCAgOCArKysrKysr
Kw0KPiB0b29scy94bC94bC5oICAgICAgICAgICAgICAgICAgICAgICAgIHwgIDIgKysNCj4gdG9v
bHMveGwveGxfcGFyc2UuYyAgICAgICAgICAgICAgICAgICB8IDE2ICsrKysrKysrKysrKysrKysN
Cj4geGVuL2FyY2gveDg2L2RvbWFpbi5jICAgICAgICAgICAgICAgICB8IDI4ICsrKysrKysrKysr
KysrKysrKysrKysrKysrKy0NCj4geGVuL2FyY2gveDg2L2h2bS92bXgvdm1jcy5jICAgICAgICAg
ICB8ICA0ICsrKysNCj4geGVuL2FyY2gveDg2L2h2bS92bXgvdm14LmMgICAgICAgICAgICB8IDE0
ICsrKysrLS0tLS0tLS0tDQo+IHhlbi9hcmNoL3g4Ni9pbmNsdWRlL2FzbS9odm0vZG9tYWluLmgg
fCAgNiArKysrKysNCj4geGVuL2FyY2gveDg2L3RyYXBzLmMgICAgICAgICAgICAgICAgICB8ICA4
ICsrKystLS0tDQo+IHhlbi9pbmNsdWRlL3B1YmxpYy9hcmNoLXg4Ni94ZW4uaCAgICAgfCAgMiAr
Kw0KPiAyMSBmaWxlcyBjaGFuZ2VkLCAxNzMgaW5zZXJ0aW9ucygrKSwgMzAgZGVsZXRpb25zKC0p
DQoNClRoZSBjaGFuZ2VzIHRvIHRoZSBPQ2FtbCBwYXJ0IGFyZSBtaW5pbWFsLg0KDQpBY2tlZC1i
eTogQ2hyaXN0aWFuIExpbmRpZyA8Y2hyaXN0aWFuLmxpbmRpZ0BjaXRyaXguY29tPg0KDQrigJQg
Qw==


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 09:00:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 09:00:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267743.461489 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHMMU-0005el-4q; Tue, 08 Feb 2022 09:00:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267743.461489; Tue, 08 Feb 2022 09:00:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHMMU-0005ee-0D; Tue, 08 Feb 2022 09:00:34 +0000
Received: by outflank-mailman (input) for mailman id 267743;
 Tue, 08 Feb 2022 09:00:32 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1FiY=SX=epam.com=prvs=40383cc40e=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nHMMS-0005eS-JI
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 09:00:32 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 900feadc-88bd-11ec-8f75-fffcc8bd4f1a;
 Tue, 08 Feb 2022 10:00:30 +0100 (CET)
Received: from pps.filterd (m0174676.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 2186iL9f013032;
 Tue, 8 Feb 2022 09:00:26 GMT
Received: from eur01-he1-obe.outbound.protection.outlook.com
 (mail-he1eur01lp2052.outbound.protection.outlook.com [104.47.0.52])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e3kgu0hy3-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Tue, 08 Feb 2022 09:00:26 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM4PR0301MB2226.eurprd03.prod.outlook.com (2603:10a6:200:4d::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Tue, 8 Feb
 2022 09:00:21 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77%3]) with mapi id 15.20.4951.019; Tue, 8 Feb 2022
 09:00:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 900feadc-88bd-11ec-8f75-fffcc8bd4f1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=HW4resnCC0tyGVVaV+gquvyZwFQna+5jranohtXzOkdBepPnjd4BpV1ETBH82JofIKVZ+UZOxjwj5ukWPXsakwesEASCsPMyXF9QemfGoSOAKtspNiZxCPpHMjvbEJ0/VCuceiLpdLXCZiDS+HqVSjZ9mRnqr3ThPgYj4uiKtZ9OklGSgFiKH4dbDY47vxfXXGT9v3Icq61+g53l8BPf9eqwBlUPn2fwiVCf96o06LM36Li69Ivbelf+a7o8xVX77E0u/kKV/6gYxoPbhwU+8HT8KIfGw5Mcy8hBNHCmjVIBgtejhyri8GNdHf0egpYqiSCRCQp1EmKWUuTvGvMtXg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=GOvedpwc4BrgJPXSjAHoARgCDT0cQXFsosolrHyQ5hE=;
 b=mm1/Cfbj1o+p6fCBsJE98lRDaKWYdh/zqLPY1yFUbqQvLlrtuHpOuN8joBSx1Izez7B2nx7SZT8bcbxT1O310ejWjvPAYHSlJN1cqzGN16JiiVl27hTUpmESo+jR4HjFfjXyhukL6j/YD1nbHYsBGxwhG1KiTfJyzzZx1aAG8NDAbBK/8nNuUqqjHfVGg4rcS+3CfVmgbhwgbp3VwBufUyANNbDcEHNUKveUsWZ7xcIURoKFD8/QOvlcGUh7H/4mXvLOKFhE4RyA4NlOe4ao+23hcWDQGRm0QSavkwrKboptvgL+oZEOqDNRRDmEEViDvdUHRclUepNFWVSQifHt2w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=GOvedpwc4BrgJPXSjAHoARgCDT0cQXFsosolrHyQ5hE=;
 b=ZtakGRM7uIAK3qXGobLQLyt8C252nBeNJQGXCslDZ7Xma30Mo/0NVa3tvMgRbcRn8wlgQsW2b+e5nHLVOmqU3SgKXMfHDff3m4dfIULUh9vVzC1qprHhG124tpsSZ3LPp9agxHppBAPafLC3F2GMDoFRATRplR7/WfwxOQ5YKe130A63l61EmOYfN5x+gEF6nyZRdzgl5MGYZpPLz6YWqTcz4BriaDOK3xf2LHkzH3pNP7HCwjupqCUfxJpohvb/4/n03x5H0FQfARqEkVxsl4x3Rw/av9wOQfsnOZhKFzCho/97WDVZZL0jPuwMbji9Jfll9HcZpWHJYPePYDSEYw==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?=
	<roger.pau@citrix.com>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Thread-Topic: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Thread-Index: 
 AQHYGZFc/MnzQOjwVEeBBUHLSW0md6yDBUkAgAASSACAAATYAIAAD/WAgAAKNgCAAAbfgIAABnuAgAAQvgCAAAMCAIAAAY4AgAADxICAABrnAIAABAgAgAR3CoCAABt5gIAAEpuAgAAE5ICAAASKAIAAAiiAgAAKNYCAAARNAIAAC1wAgAACRYCAAAGVgIAABJiAgAAB5wCAAQ7DgIAAAdkA
Date: Tue, 8 Feb 2022 09:00:21 +0000
Message-ID: <57060264-8c5e-ae39-5bf8-ca5b6a58639f@epam.com>
References: <7e3562b5-fc67-f213-e872-f211450d9e2e@epam.com>
 <a8fc599c-f620-c4d1-2077-c57068f46a7f@suse.com>
 <deef8468-d607-e49e-f456-6a8013329ca1@epam.com>
 <Yf0k6aoKK5G3iad1@Air-de-Roger>
 <3ad10a99-c706-b95f-1419-2c0c7cf37d58@epam.com>
 <Yf0+3C9nF8+tewLw@Air-de-Roger>
 <c5fea3bb-834b-eeb7-d7a1-1ee609037a9f@epam.com>
 <YgEUwTxhnWVMGMJK@Air-de-Roger>
 <9ce90193-74a0-5642-d22b-6b8c3340c3cf@epam.com>
 <1f65ae7a-898d-2c27-0ada-d71d778b0627@suse.com>
 <YgEsRuckQJIQlkzf@Air-de-Roger>
 <a2a42c1d-d379-00cd-5d55-f443cdb02e97@epam.com>
 <e8fc7872-c7d0-f389-c507-335b809ffcbc@epam.com>
 <21c8125a-2f79-1a4a-494c-db9e4be2a1a6@suse.com>
 <4276fe72-558b-7d95-6430-d4330989dbe8@epam.com>
 <ad985f4a-10f0-4a2d-df02-cde915fea3f1@suse.com>
 <f7669670-8eeb-9966-5ba3-e8f9c03ce3d3@epam.com>
 <73e08285-6bb1-5842-899f-bd6502406e49@suse.com>
 <be3f4222-6580-4c89-a202-c003b6feb9b4@epam.com>
 <df369309-3767-632c-912e-e83edcf6a2ad@suse.com>
In-Reply-To: <df369309-3767-632c-912e-e83edcf6a2ad@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 6da77da4-2f4e-4515-1830-08d9eae1701f
x-ms-traffictypediagnostic: AM4PR0301MB2226:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM4PR0301MB22262C7174222F546615C844E72D9@AM4PR0301MB2226.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 mr5gHkTF7dUViPt1dzrxKxJoU9Prwh1niSnq1656zzLgsQpTXbVP8S8Fpu0eRmWLciyyoJeERW7G+uosp/ppcvn5/CFXilvhNNSvtBaeMs2wvvZ0PCl02zkArhhV89K/zWB/wN8ysHcalGQImbgCKw52LyxrpOuKvifCZSDCMfQRx8Fn49hqf33dvxfOPSI7aDKvumUgko5KrhLhKe2YRXrdmLk05+B7/9UO0IKZ9nKvg8kADmplNihPzqvIkqyNd0QuVH1G4GY/ldSjdKyj9Ut4rPGEeYOLK2qK6naX5yQcCh8XaE4enFnD38M4tgM3wnCxDyVgwiV+YmkQRVSbu8f5xGYUW+gU7mzrxH0PMvUr+JfllPOkLrJp0GpQbjiZb84OLtsZ2m6GaYROaC5UEcrcKtlzje5nV88TZkpBRgZmLtlntKi6cChf3IgsElunwm8Uhwe1XFqb6I1Wqyb+0dYGWC4dP2AwmVFrMDEV6wyoNfZW9bS/mEnfLkFO9dx3ZK2KUcDbT+mAk9M7I00XCL+CfdQ1MqkDJmDbphm9WFtDJJLJ1vZNL1SgWBXhA/EydaS9Q1QxwXYNZ9F8a3zp2gfpEaBdHmNeo0v6WNmANjjEaNF+hGALi2hIVos9wcQekIld3qfFxoUJzZWBvrdUv/W7RjjJkpwsZLLw78y00GcEkHgIOCsY6nmNWiWf6Hakgt0xWZdXZq6Mi3UZ8uckZz5en82rTcXbzqs9+OumePQ=
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66446008)(64756008)(53546011)(71200400001)(8936002)(8676002)(508600001)(4326008)(6506007)(6486002)(91956017)(36756003)(38070700005)(76116006)(66946007)(66476007)(31686004)(83380400001)(86362001)(186003)(66556008)(316002)(2906002)(54906003)(55236004)(26005)(6916009)(7416002)(107886003)(6512007)(5660300002)(122000001)(2616005)(38100700002)(31696002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?TDlXTkZGQjlBN3JSeGNKZFBKOGhkV2JYaFVoWFhmSTBnKy9xSERSenNyaitl?=
 =?utf-8?B?Wmx5OFNpQ0ZURVd0RWFVMlpLY0ZsaFR5aFJGNnVGVjlCUkh5elNWUTlIOVBa?=
 =?utf-8?B?d2JXQmhZdUtGajRmOFJ6MHErdVg0cFZWYytTQjVmVGs0RldTb1l1MWxCMExN?=
 =?utf-8?B?QTlEc0I0dGFVaHk0bHUxUHhlaTFWbVpsaEs5VEUxQkVMbkxWWUFqUGppNXlV?=
 =?utf-8?B?UHQrYXA0V29TQW10SHl0aXc0ZnBodEw3V0tBNDFMWTNvOG1XTTVVOXM4THlU?=
 =?utf-8?B?SWJqc3k5QU1wM0hxa3hXOGNiWmVpaWozMU9qbUtIdlVlT2UvdTNDWGdVRHZF?=
 =?utf-8?B?S29IWG1VZ3NKUHBMaHRBcEFVTHVuWERSZE1Xd0M4cUVpd0VlV3BMR0dZMjJT?=
 =?utf-8?B?THA3WDI2b045R2I2Sm5uVElBSGhTemsrSmZjU3NmNEhRMEpES0R2Mzd0SnpI?=
 =?utf-8?B?SU80UzI3aGsxTk1PVEp0VVZDME9WblJJcXlTem9vZ3pCTmdDZjdKQnFoMXZI?=
 =?utf-8?B?bXRTRVJORU1Mampyb2Z2cG1ESXFvb1dzOU9nLzYreXpzUEhOMW44Sk5OQkNp?=
 =?utf-8?B?bGcrckE2TzJqQW5EakRpcFNhZFYyM0lDRm5MSHBBUWs5aWROanBIdGZTeFdY?=
 =?utf-8?B?MUV1N2szUGxZMWs3dkthYlZxcHU4WUlvaEdkc3k4YlJ4SXh4Z2pwMWQ1T1Np?=
 =?utf-8?B?bERUd2dXaStPU3pucFhnYjBNcW1pcUs1emNlcGhSOXBBSGh0dGJTZFFwY2ZN?=
 =?utf-8?B?UnFSK2Uva3kzQUZxZDFPdUdpcy82QSsxempodGljOVZDVFRXMEY1QTl2ZWda?=
 =?utf-8?B?UEZpTUV1cUpwMWtFZzMvVkg0ZjluQnVyLzFuaTFFV2xBa0xyTDBDTVNJN1hW?=
 =?utf-8?B?VXlkWFJXR2J3Q084aElmVFZOZ1FncThQVVRlRmxsMnJRS3pRalRVWUZYRVhw?=
 =?utf-8?B?WWlqNkIzN0p0NW44aGs1SWZWL1Z5TVN3cS9XY0s0Rm5STndCa0dBU2loZkJH?=
 =?utf-8?B?SDlBbTQvNGRTTVpZaGRZVkRjbzhBQlk0aDErNzAvNEVrcmRZTkFVNTBZeEJp?=
 =?utf-8?B?VFBYd2ZxNm1oRitxVXZvaWE0eE5uQ3VXYUJseWhuQUtuSDdVZ2RuQ2F4M1Br?=
 =?utf-8?B?empoamZiUHZOaWJrb2Vvd1VpTFNMT2RIR1R4SmZZQkVsdkd0OHY3aTdVbU9Y?=
 =?utf-8?B?Wm5FSjluZnVWaysrQnhzTFJWWlZ4NjVpdFo5TnNsYkRFNE8zNFVuV2dSQ0hJ?=
 =?utf-8?B?MkRiRTFzSzZoNTIwcTZuckVPZWVkTU1KTS9MeGdmZ0hRU2YvakZ1WlI1WWxP?=
 =?utf-8?B?bmI2MWxFcXRNVUl2NzROT0sra2N5OFMyR0VGYmhablRzZVNTUUk0NDYwekpQ?=
 =?utf-8?B?bTZMOWREYkJzYm9HMVhDdXBRc1VTVi9ybG9MY1RYaWlEYkt5QmQ3WitGcmVO?=
 =?utf-8?B?clg1d0VWdVFYT1kwSWJNcSsvbW9OZnZQVEoyLy95VnNOMlp3Nlp2dG1ZNWhv?=
 =?utf-8?B?RlBFVWVPRm9UdHIyMXNKVEVUUDNmenB3K1prRUd0ZWQ4ZG53T1RKYlJWRUdt?=
 =?utf-8?B?YTdKWnVoRHAvOUw0b3RUd202THFzMDQvbW1JbkdLUkJVT3lEV01hTnFiMnZl?=
 =?utf-8?B?b1F2RWtqTTNENzJySEdGTWk4ZDFDYVVSVmFFZTlnNXJ1elVvUUw5eGlIVDZj?=
 =?utf-8?B?T2JkSnBxU1dRY25BazFBUXh2ZVo4MXUrS2JyRVpKNm9la3lyelRKL2FRSGls?=
 =?utf-8?B?S3hMRFFOU1RITGZHVjBDRSt4TktMc0VUYkdpVTVMMEdSSFNrTlEwQkUvM1Nz?=
 =?utf-8?B?R3M3Vk5GWkxrczUrTDJrSG1HcDE0aHo5KzVhR0NQdHVoL0RuRXh6NEZhTlUw?=
 =?utf-8?B?NWU3RTByRzl1VWxZcCtQaWhCZ3VFbERsYkdjU0tsYk5PVnd4Mm5LZUpFMHBU?=
 =?utf-8?B?QnlWbXlFOVRHbWtrWDhhNDVaTkdET2JkcXkxbWFNWUtSRHhuYStPcWNoYXcz?=
 =?utf-8?B?Y1QxUTNIRHdXaDdFY3lPVDY2eFNQa1FjU0FpcTIvZlZpdG5NQXkzVVczTnEx?=
 =?utf-8?B?ZVRKZzV5TFJMZWRyN0JkeUZUdGM5WWRDdnYyOHNCMEVmS2plRlZXRnFzcWFC?=
 =?utf-8?B?bUNLVnNGREp3TG1HZWMvdmMzQWZEb2hjU3hwRDcxVDZTb2pJcXNFK0k1Rld4?=
 =?utf-8?B?VnBzWFpHTjdQbTE3bXczZGhaY3NPWlo0dHdCMVBRNW5BcTgyZXByMGZiZUtG?=
 =?utf-8?B?VGM5aGJHWnF0UDZsZlZMMENiWE5hTVpydGZCdWFBcGlUQ2lyYlFSaCtmOVhE?=
 =?utf-8?B?aFZVYStXSTNOVmVQTHJuQ0tNSW82MlNOSWdvTjZMZWxvb3pjd0o4dUNlUnJX?=
 =?utf-8?Q?HttDG0DH4i7n7F9k=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <732C08E913ACE944BB1758C4F685D9DC@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6da77da4-2f4e-4515-1830-08d9eae1701f
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2022 09:00:21.8325
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: NYGF1rKCSYE8rt8ou40P70lfl1GKzgQPygNDN3Ig+73Gkmn2gtS1GatKkhQQhHKUIyIgmKpiPcgPz5QcQnPbMqecC6CFTMnD8KUeQbO5sZBBWMb8ROfG9BM6CHIa6R2V
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0301MB2226
X-Proofpoint-GUID: dRTYrEwttfJamNQ_6QAa4xYQBbo80VS7
X-Proofpoint-ORIG-GUID: dRTYrEwttfJamNQ_6QAa4xYQBbo80VS7
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-08_02,2022-02-07_02,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 adultscore=0
 clxscore=1015 priorityscore=1501 bulkscore=0 phishscore=0 mlxlogscore=999
 malwarescore=0 suspectscore=0 impostorscore=0 spamscore=0
 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202080050

DQoNCk9uIDA4LjAyLjIyIDEwOjUzLCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMDcuMDIuMjAy
MiAxNzo0NCwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+Pg0KPj4gT24gMDcuMDIu
MjIgMTg6MzcsIEphbiBCZXVsaWNoIHdyb3RlOg0KPj4+IE9uIDA3LjAyLjIwMjIgMTc6MjEsIE9s
ZWtzYW5kciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4+PiBPbiAwNy4wMi4yMiAxODoxNSwgSmFu
IEJldWxpY2ggd3JvdGU6DQo+Pj4+PiBPbiAwNy4wMi4yMDIyIDE3OjA3LCBPbGVrc2FuZHIgQW5k
cnVzaGNoZW5rbyB3cm90ZToNCj4+Pj4+PiBPbiAwNy4wMi4yMiAxNzoyNiwgSmFuIEJldWxpY2gg
d3JvdGU6DQo+Pj4+Pj4+IDFiLiBNYWtlIHZwY2lfd3JpdGUgdXNlIHdyaXRlIGxvY2sgZm9yIHdy
aXRlcyB0byBjb21tYW5kIHJlZ2lzdGVyIGFuZCBCQVJzDQo+Pj4+Pj4+IG9ubHk7IGtlZXAgdXNp
bmcgdGhlIHJlYWQgbG9jayBmb3IgYWxsIG90aGVyIHdyaXRlcy4NCj4+Pj4+PiBJIGFtIG5vdCBx
dWl0ZSBzdXJlIGhvdyB0byBkbyB0aGF0LiBEbyB5b3UgbWVhbiBzb21ldGhpbmcgbGlrZToNCj4+
Pj4+PiB2b2lkIHZwY2lfd3JpdGUocGNpX3NiZGZfdCBzYmRmLCB1bnNpZ25lZCBpbnQgcmVnLCB1
bnNpZ25lZCBpbnQgc2l6ZSwNCj4+Pj4+PiAgICAgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgIHVpbnQzMl90IGRhdGEpDQo+Pj4+Pj4gW3NuaXBdDQo+Pj4+Pj4gICAgIMKgwqDCoCBsaXN0
X2Zvcl9lYWNoX2VudHJ5ICggciwgJnBkZXYtPnZwY2ktPmhhbmRsZXJzLCBub2RlICkNCj4+Pj4+
PiB7DQo+Pj4+Pj4gW3NuaXBdDQo+Pj4+Pj4gICAgIMKgwqDCoCBpZiAoIHItPm5lZWRzX3dyaXRl
X2xvY2spDQo+Pj4+Pj4gICAgIMKgwqDCoCDCoMKgwqAgd3JpdGVfbG9jayhkLT52cGNpX2xvY2sp
DQo+Pj4+Pj4gICAgIMKgwqDCoCBlbHNlDQo+Pj4+Pj4gICAgIMKgwqDCoCDCoMKgwqAgcmVhZF9s
b2NrKGQtPnZwY2lfbG9jaykNCj4+Pj4+PiAuLi4uDQo+Pj4+Pj4NCj4+Pj4+PiBBbmQgcHJvdmlk
ZSBydyBhcyBhbiBhcmd1bWVudCB0bzoNCj4+Pj4+Pg0KPj4+Pj4+IGludCB2cGNpX2FkZF9yZWdp
c3RlcihzdHJ1Y3QgdnBjaSAqdnBjaSwgdnBjaV9yZWFkX3QgKnJlYWRfaGFuZGxlciwNCj4+Pj4+
PiAgICAgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHZwY2lfd3Jp
dGVfdCAqd3JpdGVfaGFuZGxlciwgdW5zaWduZWQgaW50IG9mZnNldCwNCj4+Pj4+PiAgICAgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHVuc2lnbmVkIGludCBzaXpl
LCB2b2lkICpkYXRhLCAtLS0+Pj4gYm9vbCB3cml0ZV9wYXRoIDw8PC0tLS0tKQ0KPj4+Pj4+DQo+
Pj4+Pj4gSXMgdGhpcyB3aGF0IHlvdSBtZWFuPw0KPj4+Pj4gVGhpcyBzb3VuZHMgb3Zlcmx5IGNv
bXBsaWNhdGVkLiBZb3UgY2FuIGRlcml2ZSBsb2NhbGx5IGluIHZwY2lfd3JpdGUoKSwNCj4+Pj4+
IGZyb20ganVzdCBpdHMgInJlZyIgYW5kICJzaXplIiBwYXJhbWV0ZXJzLCB3aGV0aGVyIHRoZSBs
b2NrIG5lZWRzIHRha2luZw0KPj4+Pj4gaW4gd3JpdGUgbW9kZS4NCj4+Pj4gWWVzLCBJIHN0YXJ0
ZWQgd3JpdGluZyBhIHJlcGx5IHdpdGggdGhhdC4gU28sIHRoZSBzdW1tYXJ5IChST00NCj4+Pj4g
cG9zaXRpb24gZGVwZW5kcyBvbiBoZWFkZXIgdHlwZSk6DQo+Pj4+IGlmICggKHJlZyA9PSBQQ0lf
Q09NTUFORCkgfHwgKHJlZyA9PSBST00pICkNCj4+Pj4gew0KPj4+PiAgICDCoMKgwqAgcmVhZCBQ
Q0lfQ09NTUFORCBhbmQgc2VlIGlmIG1lbW9yeSBvciBJTyBkZWNvZGluZyBhcmUgZW5hYmxlZC4N
Cj4+Pj4gICAgwqDCoMKgIGlmICggZW5hYmxlZCApDQo+Pj4+ICAgIMKgwqDCoCDCoMKgwqAgd3Jp
dGVfbG9jayhkLT52cGNpX2xvY2spDQo+Pj4+ICAgIMKgwqDCoCBlbHNlDQo+Pj4+ICAgIMKgwqDC
oCDCoMKgwqAgcmVhZF9sb2NrKGQtPnZwY2lfbG9jaykNCj4+Pj4gfQ0KPj4+IEhtbSwgeWVzLCB5
b3UgY2FuIGFjdHVhbGx5IGdldCBhd2F5IHdpdGhvdXQgdXNpbmcgInNpemUiLCBzaW5jZSBib3Ro
DQo+Pj4gY29tbWFuZCByZWdpc3RlciBhbmQgUk9NIEJBUiBhcmUgMzItYml0IGFsaWduZWQgcmVn
aXN0ZXJzLCBhbmQgNjQtYml0DQo+Pj4gYWNjZXNzZXMgZ2V0IHNwbGl0IGluIHZwY2lfZWNhbV93
cml0ZSgpLg0KPj4gQnV0LCBPUyBtYXkgd2FudCByZWFkaW5nIGEgc2luZ2xlIGJ5dGUgb2YgUk9N
IEJBUiwgc28gSSB0aGluaw0KPj4gSSdsbCBuZWVkIHRvIGNoZWNrIGlmIHJlZytzaXplIGZhbGwg
aW50byBQQ0lfQ09NQU5EIGFuZCBST00gQkFSDQo+PiByYW5nZXMNCj4+PiBGb3IgdGhlIGNvbW1h
bmQgcmVnaXN0ZXIgdGhlIG1lbW9yeS0gLyBJTy1kZWNvZGluZy1lbmFibGVkIGNoZWNrIG1heQ0K
Pj4+IGVuZCB1cCBhIGxpdHRsZSBtb3JlIGNvbXBsaWNhdGVkLCBhcyB0aGUgdmFsdWUgdG8gYmUg
d3JpdHRlbiBhbHNvDQo+Pj4gbWF0dGVycy4gTWF5YmUgcmVhZCB0aGUgY29tbWFuZCByZWdpc3Rl
ciBvbmx5IGZvciB0aGUgUk9NIEJBUiB3cml0ZSwNCj4+PiB1c2luZyB0aGUgd3JpdGUgbG9jayB1
bmlmb3JtbHkgZm9yIGFsbCBjb21tYW5kIHJlZ2lzdGVyIHdyaXRlcz8NCj4+IFNvdW5kcyBnb29k
IGZvciB0aGUgc3RhcnQuDQo+PiBBbm90aGVyIGNvbmNlcm4gaXMgdGhhdCBpZiB3ZSBnbyB3aXRo
IGEgcmVhZF9sb2NrIGFuZCB0aGVuIGluIHRoZQ0KPj4gdW5kZXJseWluZyBjb2RlIHdlIGRpc2Fi
bGUgbWVtb3J5IGRlY29kaW5nIGFuZCB0cnkgZG9pbmcNCj4+IHNvbWV0aGluZyBhbmQgY2FsbGlu
ZyBjbWRfd3JpdGUgaGFuZGxlciBmb3IgYW55IHJlYXNvbiB0aGVuLi4uLg0KPj4NCj4+IEkgbWVh
biB0aGF0IHRoZSBjaGVjayBpbiB0aGUgdnBjaV93cml0ZSBpcyBzb21ld2hhdCB3ZSBjYW4gdG9s
ZXJhdGUsDQo+PiBidXQgdGhlbiBpdCBpcyBtdXN0IGJlIGNvbnNpZGVyZWQgdGhhdCBubyBjb2Rl
IGluIHRoZSByZWFkIHBhdGgNCj4+IGlzIGFsbG93ZWQgdG8gcGVyZm9ybSB3cml0ZSBwYXRoIGZ1
bmN0aW9ucy4gV2hpY2ggYnJpbmdzIGEgcHJldHR5DQo+PiB2YWxpZCB1c2UtY2FzZTogc2F5IGlu
IHJlYWQgbW9kZSB3ZSBkZXRlY3QgYW4gdW5yZWNvdmVyYWJsZSBlcnJvcg0KPj4gYW5kIG5lZWQg
dG8gcmVtb3ZlIHRoZSBkZXZpY2U6DQo+PiB2cGNpX3Byb2Nlc3NfcGVuZGluZyAtPiBFUlJPUiAt
PiB2cGNpX3JlbW92ZV9kZXZpY2Ugb3Igc2ltaWxhci4NCj4+DQo+PiBXaGF0IGRvIHdlIGRvIHRo
ZW4/IEl0IGlzIGFsbCBnb2luZyB0byBiZSBmcmFnaWxlLi4uDQo+IFJlYWwgaGFyZHdhcmUgd29u
J3QgY2F1c2UgYSBkZXZpY2UgdG8gZGlzYXBwZWFyIHVwb24gYSBwcm9ibGVtIHdpdGgNCj4gYSBy
ZWFkIGFjY2Vzcy4gVGhlcmUgc2hvdWxkbid0IGJlIGFueSBuZWVkIHRvIHJlbW92ZSBhIHBhc3Nl
ZC10aHJvdWdoDQo+IGRldmljZSBlaXRoZXI7IHN1Y2ggcHJvYmxlbXMgKGlmIGFueSkgbmVlZCBo
YW5kbGluZyBkaWZmZXJlbnRseSBpbW8uDQpZZXMsIGF0IHRoZSBtb21lbnQgdGhlcmUgaXMgYSBz
aW5nbGUgcGxhY2UgaW4gdGhlIGNvZGUgd2hpY2gNCnJlbW92ZXMgdGhlIGRldmljZSAoYmVzaWRl
cyBub3JtYWwgdXNlLWNhc2VzIHN1Y2ggYXMNCnBjaV9hZGRfZGV2aWNlIG9uIGZhaWwgcGF0aCBh
bmQgUEhZU0RFVk9QX21hbmFnZV9wY2lfcmVtb3ZlKToNCg0KYm9vbCB2cGNpX3Byb2Nlc3NfcGVu
ZGluZyhzdHJ1Y3QgdmNwdSAqdikNCnsNCltzbmlwXQ0KIMKgwqDCoMKgwqDCoMKgIGlmICggcmMg
KQ0KIMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgLyoNCiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAg
KiBGSVhNRTogaW4gY2FzZSBvZiBmYWlsdXJlIHJlbW92ZSB0aGUgZGV2aWNlIGZyb20gdGhlIGRv
bWFpbi4NCiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKiBOb3RlIHRoYXQgdGhlcmUgbWlnaHQg
c3RpbGwgYmUgbGVmdG92ZXIgbWFwcGluZ3MuIFdoaWxlIHRoaXMgaXMNCiDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqAgKiBzYWZlIGZvciBEb20wLCBmb3IgRG9tVXMgdGhlIGRvbWFpbiB3aWxsIGxp
a2VseSBuZWVkIHRvIGJlDQogwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgICoga2lsbGVkIGluIG9y
ZGVyIHRvIGF2b2lkIGxlYWtpbmcgc3RhbGUgcDJtIG1hcHBpbmdzIG9uDQogwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgICogZmFpbHVyZS4NCiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKi8NCiDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgIHZwY2lfcmVtb3ZlX2RldmljZSh2LT52cGNpLnBkZXYpOw0K
DQo+DQo+IEphbg0KPg0KPg0K


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 09:03:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 09:03:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267755.461500 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHMPQ-0006ML-Mc; Tue, 08 Feb 2022 09:03:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267755.461500; Tue, 08 Feb 2022 09:03:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHMPQ-0006ME-It; Tue, 08 Feb 2022 09:03:36 +0000
Received: by outflank-mailman (input) for mailman id 267755;
 Tue, 08 Feb 2022 09:03:35 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1FiY=SX=epam.com=prvs=40383cc40e=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nHMPO-0006M8-RT
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 09:03:35 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id fcdae310-88bd-11ec-8f75-fffcc8bd4f1a;
 Tue, 08 Feb 2022 10:03:32 +0100 (CET)
Received: from pps.filterd (m0174681.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 2187rLQo021859;
 Tue, 8 Feb 2022 09:03:23 GMT
Received: from eur02-ve1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2050.outbound.protection.outlook.com [104.47.6.50])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3e3mh7gabj-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Tue, 08 Feb 2022 09:03:23 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM9PR03MB7459.eurprd03.prod.outlook.com (2603:10a6:20b:268::5)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Tue, 8 Feb
 2022 09:03:19 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77%3]) with mapi id 15.20.4951.019; Tue, 8 Feb 2022
 09:03:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fcdae310-88bd-11ec-8f75-fffcc8bd4f1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=YhsKF3nvBlI2whbVx0B45eXpgqMvORdT+vVDUs/Gu23PFEuAOz4s0QxF9BERuL+5uHysxMflJhBKcY74f/cchiLCnLS5a9/IW9z5ju/4yW73l+xu0yg4BzUq9oEpJnPHZTmwRGTt0cAn5aXVc2yelmsVz+KlNrEf7EkRAZmEctPtW8gGL7/5svd4oqaVSlF18PK2xMirCLwvdrtWEsb3aikqS5ZXQj7LccFF7X3YozzmWV16hozP7y+k38SvAKFZXR2Dk+L66OEfKRCnfCdsjxdUEmeDIm4mhwmMsH51uSCS1+BRuYabgueSnFmyYogrX9qcDw1KePnvzZC8ZOhM6g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=O23HV0Tc8xdEJ3ADIkfZrEzuetkkxLNqodA8J1DyP5k=;
 b=TwhK3b9exLnubiJGxZlx1cNgI0nI6lUsNC3rmNpzLmVQcY532qo2c3wPr0XbedJ84IP9VgXk3p9BtP553mhDZHL6Isj1xl7mdZhGi9FbFH0onQaMolo8AsorgSChzYOUpTDJeZ0HN0ljrDrjjIVrn+aNB+PGQzML4OWlOLZrqnUADx3C/0NV6co4ypqlvmCA5cGOAZqT6OBrmuqOlBDYsS9HnbMg1X5K6pUMcztDO9KMPd9od/VuOLGfTi5ojbMCFE18skCmKxTN6Z/ETIGBUR/c5NpwD4ClaOqAz+Wn3O45dVaTV9BdHdDEmXkNSrVBS5vQcayPFFv96M8AJDPP6A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=O23HV0Tc8xdEJ3ADIkfZrEzuetkkxLNqodA8J1DyP5k=;
 b=Ss9FTD3E+0FkR7YoaIr8YzMYLJDzEtY9GWRIGLlwGp9Hcuu/GPD6EnJMTObdGSicjrYjcOaAX+hVdfxeM4H4TEN84cjFvBseb0BL6iYs9acEqwjkdc34Sb8jaTjIJK5eueVNsSaAUbIg070e04MSSG7DSrFL8+vVbWwG7UXPOfEfEnllIvYs0nBWZQ7yhMHdYjGxqbtTm9BgbwZTVngcOZi1Bo8d0pMVlAAoIHHN/yyH9bmKqbuQF3MRtHNMCQlx+B82muwGs8HZXc027P4aBGgDgrNwZaICCkaLuuvSFn0zwP3LpQ4cflgaR8ucAT8qSYuXY1fYCUywQqyBt2GZnw==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?=
	<roger.pau@citrix.com>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Thread-Topic: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Thread-Index: 
 AQHYGZFc/MnzQOjwVEeBBUHLSW0md6yDBUkAgAASSACAAATYAIAAD/WAgAAKNgCAAAbfgIAABnuAgAAQvgCAAAMCAIAAAY4AgAADxICAABrnAIAABAgAgAR3CoCAABt5gIAAEpuAgAAE5ICAAASKAIAAAiiAgAAKNYCAAARNAIAAC1wAgAACRYCAAAGVgIAABJiAgAAB5wCAAPjsgIAAFvmAgAABioA=
Date: Tue, 8 Feb 2022 09:03:17 +0000
Message-ID: <07fcedb1-d063-81ed-9545-7e25e158dfe3@epam.com>
References: <7e3562b5-fc67-f213-e872-f211450d9e2e@epam.com>
 <a8fc599c-f620-c4d1-2077-c57068f46a7f@suse.com>
 <deef8468-d607-e49e-f456-6a8013329ca1@epam.com>
 <Yf0k6aoKK5G3iad1@Air-de-Roger>
 <3ad10a99-c706-b95f-1419-2c0c7cf37d58@epam.com>
 <Yf0+3C9nF8+tewLw@Air-de-Roger>
 <c5fea3bb-834b-eeb7-d7a1-1ee609037a9f@epam.com>
 <YgEUwTxhnWVMGMJK@Air-de-Roger>
 <9ce90193-74a0-5642-d22b-6b8c3340c3cf@epam.com>
 <1f65ae7a-898d-2c27-0ada-d71d778b0627@suse.com>
 <YgEsRuckQJIQlkzf@Air-de-Roger>
 <a2a42c1d-d379-00cd-5d55-f443cdb02e97@epam.com>
 <e8fc7872-c7d0-f389-c507-335b809ffcbc@epam.com>
 <21c8125a-2f79-1a4a-494c-db9e4be2a1a6@suse.com>
 <4276fe72-558b-7d95-6430-d4330989dbe8@epam.com>
 <ad985f4a-10f0-4a2d-df02-cde915fea3f1@suse.com>
 <f7669670-8eeb-9966-5ba3-e8f9c03ce3d3@epam.com>
 <73e08285-6bb1-5842-899f-bd6502406e49@suse.com>
 <be3f4222-6580-4c89-a202-c003b6feb9b4@epam.com>
 <e91965c5-0802-adf8-0c17-522f86ebf231@epam.com>
 <72abc2b2-7141-0460-2b5a-e27cfa8457f1@suse.com>
In-Reply-To: <72abc2b2-7141-0460-2b5a-e27cfa8457f1@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 59480e83-3dc5-4e99-0e83-08d9eae1d921
x-ms-traffictypediagnostic: AM9PR03MB7459:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM9PR03MB74597E4A9E19A9A13FDDAC15E72D9@AM9PR03MB7459.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8273;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 6XzSqDJS91TilZ0kvHyxKXrsNiADY+B3vmMqHFkfmRGQ2132Gzuzd/7GiNsfR0KWnTPeLUim9f1IPWAsCAl2xG6y+QdytsShU79ulK4UgcPsH9zLyvkx2jgxrUNe2S7IHOUpiHaixTkKhQk/S3oWzy/fR+wcGzc/pzHwKn+ur9fLkTS+sEnwzBI0/k+OhhwiCQw523WdXUnXFUCAM2TBjYGQPjG/r0Bxzx8k+YHZg+BvxJAW7eziss2Kcxrs4J++yb2J7LYTflS+UQRrHO4ln452VePraxhM5p+GDOFcbVSijb8pJXosgMqp3FRII03sW+DJEPta1gki2UkT4kftP2TyzJe+c9/f8OstbHPqiTze0cD9gcTS40rlD782J4IPzBCZh8AWDHQye8k4Qygb71SAGIj+t9hjQ9Al6f3MTndJS/SqHF08SVWdz6zXJ61hiL0FSk1nCzbqmlIKz36+CuTUqSfJ4twPwqrtTF30FvsRP5UjCrkWrgYyfBibgFrJfOpY9D7tci4oEFYjZlrNT7IjaquWIqMp63wT4YwKIZt2k2V2N0xCkbKZfRjRI0/musz0zhL1HySQBy1JAVSoFR8Rkpurcm0brmAsgWJAg1XtpQp4mZgvrZEoQzY6zYuk1tFQzOdgTZSaz8wg0qpWr3wpMRPYtZgdwNdn33iBI3jDdacZrI0/vM6f7IUEYEwA7z8DHdsF0jsol25MJ8ajso0OSv3u52ebHOZlClo8oohZJ0oBPA8le4H5sxNvnHqM
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38070700005)(508600001)(31686004)(6486002)(31696002)(2616005)(186003)(107886003)(26005)(5660300002)(38100700002)(7416002)(71200400001)(53546011)(66446008)(66476007)(66556008)(64756008)(55236004)(83380400001)(316002)(36756003)(54906003)(86362001)(2906002)(8676002)(4326008)(8936002)(91956017)(66946007)(122000001)(6916009)(6506007)(6512007)(76116006)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?Y1RaSFFwajI3RlFzQ0pDeTNCcUdJSERsTWcwWlB0K2hLd29pL0psSWFJOCtM?=
 =?utf-8?B?WUhHenlSVnd0U2RhZW02N0djRVM1UHlNc0RwRngvNnVQMEdKcW1ZSDZTV3NX?=
 =?utf-8?B?VU1IK1hSb0Z1K3l6NGo2T0dDWStoRWZIWWNWVWoyMjdaOVVhVUtzQVpFUEpS?=
 =?utf-8?B?VmJWaTVERlQ4bzJDbXBpUHEvMTNZbFM1UUZXdHk4Zk1GcU5kcm5ZdExtVWo5?=
 =?utf-8?B?SW4wNzNTQXRHMVpiczM2NUlBTXRTL29SOWc5SDJVeGZ6MTdodk9nSXF5a2FT?=
 =?utf-8?B?UVFRcGR2Z0tEanlEa0NRTndKN1UwM2lrbWtWemNNN3dyT1RXWXd0Sms2UWl1?=
 =?utf-8?B?T2VISjFmdjNtUkVQc29lQ0tTMVRoUlZPVU8vaEtiVVFjWENKSzRoWG1rYUtt?=
 =?utf-8?B?TGN3bDVmUElLME5XcTNJckU2cWdqZm50NUg4ZHc4djhHc012VGh1YlZoTHpa?=
 =?utf-8?B?Z1JCelNyYlo5bDUvbTU5UkpUdDJ4cWJQeSsyMGtOZ25WRjZtaEd6bkc1VG1W?=
 =?utf-8?B?WWpnNXI0T3VzZnU5S014RldKQkE5Rkc4ckh5QU1OT093cXA5VzJEaVpPUTJG?=
 =?utf-8?B?YWFpd0xVL2RSbUhuV3VEeUl3Znk0dnN6T3VTdzJYc0hNcG0xTGNOSmR4b20z?=
 =?utf-8?B?Y2ZyR3FQWnl0RUZDbzM0eGR2eG9kZDUyUmk3ZDFDdmcyMk5GdGM0Q1F0dmpM?=
 =?utf-8?B?NGNTSlpxRk5TZjUrSzg4UUoyamFxeEZBcUhjQ3R1NjVoOWc4bEtVRldnVGtV?=
 =?utf-8?B?ck9rTDNXei9oTWZJejJlbFpzTEpZMlRoUDJ1TFJlb1IxaGJTSmFILyt6VXNh?=
 =?utf-8?B?OHcwZjkwRGZHZk1HbjFnbXlLMkdjQ3p5RG80TTN6Mnp1cGk4VE9OWDlFSUVY?=
 =?utf-8?B?UlR6ZTR3QUM0RXRyNXRSMy93S2Iya01zb3pWNzZjQ0c0Zmp0WTZLKzlPd0N5?=
 =?utf-8?B?ajFleDhYQW0yOGh2MXJwNlhyNmtMQzExWFU2ZmJqWXF4RHN1S3NuTmtkcUg2?=
 =?utf-8?B?NEJnRVJYZEorQUVOT3ZMOFJzeDdxUDBTQkh1L2xBQ0E2RjIwUU83czUwTkY5?=
 =?utf-8?B?WEtKM1ZRNlV6OHBkZldZMnhpR2xaTjlLVno0MDdjWXQ5akFlTmVvWUlLeFN6?=
 =?utf-8?B?ZUZjRTU1YnY2SWROOW9TVEFlalRFWkNxa2tkdXJlTVVsQlA4M0pRS2dYSEZR?=
 =?utf-8?B?Mkd3d3hzbnFPa0w5MFEvcGJPNTc5ZFZUaUllMGw4MVZ5LzhhNllRWkFaSits?=
 =?utf-8?B?cmVkLzBBaVRYV2FMMHRwcUk2eE9PK1JxQVRhR1ZiMWNucThONEdEajhaUmp6?=
 =?utf-8?B?U3k1QUN4U2FFK005V3k1OTd6Q1MwMGU1KzA2dXZZT2JvNi9ERXpQY0w5aXFz?=
 =?utf-8?B?UmNodG05eTZUclFkckFRczJKQXFscGgvc1AvNWtPSzBIQmN6SWFCcFRRaXl0?=
 =?utf-8?B?R0oySDVEcXM3VXBKUG5kZ0lObG9HOCt6bGxrYlBWdmwxYTRIR0UzMkExZTFk?=
 =?utf-8?B?YTQ0N1Frd25rMFIzMnFxN0owMy8zczdDeW12V2VVRFArQXh0NS9MK2ZLVFg5?=
 =?utf-8?B?akFub0t5L2NiTktsUVMrQkdJT255VG0rcU9LRmoxZHFzVkd5UFhCdUo2TUNP?=
 =?utf-8?B?MXlJenlRc01kWS9mOGw5VlVWdGpkU3lNNElpY01RVGtSQnRkU1hGVjdrb0Na?=
 =?utf-8?B?MnZ6Nm9HSmszWmxUYnplYjJnMHV5MzBoWTJaT21yckhZQmxpcUNrc3hSaHhQ?=
 =?utf-8?B?WjVyU0FCOVNNcytISUtvU1FhZ0wyc01NRUtyZHVGL09pQWxBNUlYWVJieUll?=
 =?utf-8?B?Q0IreFc5M3d4L1Vtb05oWFJrRjllWEkvMlk1Ymo3eXdQeFdjOHZNZytZNGJO?=
 =?utf-8?B?MnlMdzZ6bURmWDVQQmxaNks4MlFteUJtNVRZaTVsb0JMMEN2eVNHSm9tSW5H?=
 =?utf-8?B?R01TQjZLa0lRL1hvcnAwd20yVUJoaDc2a2VTYTR0K0NXMDRPMWlBZXFHNmhu?=
 =?utf-8?B?N2U4cGJFQ0hEa2NHUnlVM2tGUFU1ZXBzandsWFVxdE4zbjBTRllqQlJWSzFm?=
 =?utf-8?B?bXE1cFlaUWdRRTEzMEp5cEJ3ZWZzU2NHN20vem9TemhoT2ZwK3FDNTFEVGxp?=
 =?utf-8?B?a0x5OW85dEhXR3M4QWtucUdHaWNvUXZQUDlNZ2VFMnIzRFFtclZkT1Vxaytn?=
 =?utf-8?B?VE56Z0pDSmhzNWppWVg2ZHhFS2lFZnhjQmhtOEFwclRzZEJaT2x2OW9UNU9l?=
 =?utf-8?B?ZzJkcHBPRWNIMG5CT3psRGc2bEQxeUhWeERabUczSXVSUE5KSEJhTEJOa3Q3?=
 =?utf-8?B?dlErcFhPZXAxd1h0V3BmYktDMlBSODR5V1R1VjFwTGdkaUhwTmZNRU9lcVgx?=
 =?utf-8?Q?9TJ+Hix1xa4fyL1k=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <E0C8120B74FCF34090598FEA6F5E55F4@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 59480e83-3dc5-4e99-0e83-08d9eae1d921
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2022 09:03:17.9580
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: A7X0NRh2f29jULvJN+L8cLJklJ3FoYP5TnvE4ex+EuJghyC7n0IL9eZPThSyF+ncf7GzTLCaimJWAux99HQPd5LhEQ0oySCOZJoG2eicIvwtYFJ4suIvWAv1k8YhiThX
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR03MB7459
X-Proofpoint-GUID: tQKxHlHB0Jsff1st4v47AyOFCvtblthB
X-Proofpoint-ORIG-GUID: tQKxHlHB0Jsff1st4v47AyOFCvtblthB
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-08_02,2022-02-07_02,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0
 lowpriorityscore=0 bulkscore=0 mlxlogscore=830 priorityscore=1501
 impostorscore=0 spamscore=0 adultscore=0 malwarescore=0 mlxscore=0
 phishscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202080051

DQoNCk9uIDA4LjAyLjIyIDEwOjU3LCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMDguMDIuMjAy
MiAwODozNSwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+PiAxLjEuIFNlbWkgcmVh
ZCBsb2NrIHVwZ3JhZGUgaW4gbW9kaWZ5IGJhcnMNCj4+IC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tDQo+PiBJbiB0aGlzIGNhc2Ug
Ym90aCB2cGNpX3JlYWQgYW5kIHZwY2lfd3JpdGUgdGFrZSBhIHJlYWQgbG9jayBhbmQgd2hlbiBp
dCBjb21lcw0KPj4gdG8gbW9kaWZ5X2JhcnM6DQo+Pg0KPj4gMS4gcmVhZF91bmxvY2soZC0+dnBj
aV9sb2NrKQ0KPj4gMi4gd3JpdGVfbG9jayhkLT52cGNpX2xvY2spDQo+PiAzLiBDaGVjayB0aGF0
IHBkZXYtPnZwY2kgaXMgc3RpbGwgYXZhaWxhYmxlIGFuZCBpcyB0aGUgc2FtZSBvYmplY3Q6DQo+
PiBpZiAocGRldi0+dnBjaSAmJiAocGRldi0+dnBjaSA9PSBvbGRfdnBjaSkgKQ0KPj4gew0KPj4g
ICDCoMKgwqAgLyogdnBjaSBzdHJ1Y3R1cmUgaXMgdmFsaWQgYW5kIGNhbiBiZSB1c2VkLiAqLw0K
Pj4gfQ0KPj4gZWxzZQ0KPj4gew0KPj4gICDCoMKgwqAgLyogdnBjaSBoYXMgZ29uZSwgcmV0dXJu
IGFuIGVycm9yLiAqLw0KPj4gfQ0KPj4NCj4+IFByb3M6DQo+PiAtIG5vIHBlci1kZXZpY2UgdnBj
aSBsb2NrIGlzIG5lZWRlZD8NCj4+IC0gc29sdmVzIG92ZXJsYXAgY29kZSBBQkJBIGluIG1vZGlm
eV9iYXJzDQo+PiAtIHJlYWRlcnMgYW5kIHdyaXRlcnMgYXJlIE5PVCBzZXJpYWxpemVkDQo+PiAt
IE5PIG5lZWQgdG8gY2FyZWZ1bGx5IHNlbGVjdCByZWFkIHBhdGhzLCBzbyB0aGV5IGFyZSBndWFy
YW50ZWVkIG5vdCB0byBsZWFkDQo+PiAgIMKgIHRvIGxvY2sgdXBncmFkZSB1c2UtY2FzZXMNCj4+
DQo+PiBDb25zOg0KPj4gLSA/Pz8NCj4gVGhlICJwZGV2LT52cGNpID09IG9sZF92cGNpIiBpcyBm
cmFnaWxlOiBUaGUgc3RydWN0IG1heSBoYXZlIGdvdCByZS0NCj4gYWxsb2NhdGVkLCBhbmQgaXQg
anVzdCBzbyBoYXBwZW5lZCB0aGF0IHRoZSB0d28gcG9pbnRlcnMgYXJlIGlkZW50aWNhbC4NCj4N
Cj4gU2FtZSB0aGVuIGZvciB0aGUgc3Vic2VxdWVudCB2YXJpYW50IDIuDQpZZXMsIGl0IGlzIHBv
c3NpYmxlLiBXZSBjYW4gYWRkIGFuIElEIG51bWJlciB0byBwZGV2LT52cGNpLA0Kc28gZWFjaCBu
ZXcgYWxsb2NhdGVkIHZwY2kgc3RydWN0dXJlIGhhcyBhIHVuaXF1ZSBJRCB3aGljaCBjYW4gYmUg
dXNlZA0KdG8gY29tcGFyZSB2cGNpIHN0cnVjdHVyZXMuIEl0IGNhbiBiZSBzb21ldGhpbmcgbGlr
ZSBwZGV2LT52cGNpLT5pZCA9IGQtPnZwY2lfaWQrKzsNCndpdGggaWQgYmVpbmcgdWludDMyX3Qg
Zm9yIGV4YW1wbGUNCj4NCj4gSmFuDQo+DQo+DQo=


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 09:05:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 09:05:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267763.461511 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHMQw-0006wQ-2i; Tue, 08 Feb 2022 09:05:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267763.461511; Tue, 08 Feb 2022 09:05:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHMQv-0006wJ-U5; Tue, 08 Feb 2022 09:05:09 +0000
Received: by outflank-mailman (input) for mailman id 267763;
 Tue, 08 Feb 2022 09:05:08 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=v7zX=SX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nHMQu-0006wD-Gu
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 09:05:08 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 36008bee-88be-11ec-8f75-fffcc8bd4f1a;
 Tue, 08 Feb 2022 10:05:07 +0100 (CET)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2054.outbound.protection.outlook.com [104.47.13.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-9-RyCGiCk0M2-fyZpP1PLkhw-1; Tue, 08 Feb 2022 10:05:06 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DBAPR04MB7350.eurprd04.prod.outlook.com (2603:10a6:10:1a9::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Tue, 8 Feb
 2022 09:05:03 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.018; Tue, 8 Feb 2022
 09:05:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 36008bee-88be-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644311107;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=k43vZkAdwGt8pNENvjLXehfRnoVM3lI5xkK+S7qsJVg=;
	b=XNjspkk0TqRdZCwa0BCld7Fz6YR8SVNT8lsxnJQ4zrmgktU2LE9BVuD6FJ0/tLul7Y69kC
	8J6Zev+NsuN21wah3SV7MtHAD1r1vB+xsa1su5/K6MSt6V/EdBNJ9qMMNDGc6EZfo9o7hC
	AeEYSrEJzuqyTTfBxQPTY6Ilwu1ynqs=
X-MC-Unique: RyCGiCk0M2-fyZpP1PLkhw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Q204pzltFXIRmeF9/XI+KmN6JQvN26yyLP7O82+D35c6XdXCdeXC3kwvLbGksWJHI0ayGYxgIILWcjSNmcG1Alg0/DLgrI8TUiGwfZh65a+c4Lqz9kJIfZhX1e5HiBAdOribdx0pxh1LtcnH3HNprD7fdu7Ak61BHVhSoAPRnBJZxO8vzQp1LZJ5Qhx6Vv17tOK6sBxld7xCfKwHSB27YAstmn6tUjwmkenPziFLyf3+gmiC+GsdCahT5/e0/rkZD03C4f9ofQF9Jsr+A7WDujNmrYXjdMlZkGOJ3K+sqXpxNXpo7AddAhD/u0htNn2J/7X68aaF5ytNUXwDGBI7nw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=k43vZkAdwGt8pNENvjLXehfRnoVM3lI5xkK+S7qsJVg=;
 b=mgMVT3+ems75nnxjDU7IKvpMbAjm1xDwUJzi0uq4yAgkvqCQ0dK7eMUu7izhfzIk4ZHvhiMwr416JMnM1Gebde1QXvER3Myp02c4eQ+fRV0JDh1zYBgTCppW8mniKVN+11XT97nnrc4eeXkGuNAF0ksz5aAj7pPq6U1RGdKB4Db0K/8TbSR0aKP28TqQAQqkgaRfU4XJo4llAjB7ZFTD3r6BYdmVswsZ40QevdFE1VDPuyaPvcNkNv+7FolKkWCA8YGfX7PGN4Bsv/e3ScLq9ZZwkR8crJR61r35T8UidGmfE1MmKTSahczkuxJD16098gO4gjjw9/L8G9zAJxpWHQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <780dce9f-7d1c-39d9-278c-e89ba0b25ee1@suse.com>
Date: Tue, 8 Feb 2022 10:04:59 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v6 04/13] vpci: restrict unhandled read/write operations
 for guests
Content-Language: en-US
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Cc: "julien@xen.org" <julien@xen.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Artem Mygaiev <Artem_Mygaiev@epam.com>,
 "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
 "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
 "paul@xen.org" <paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "roger.pau@citrix.com" <roger.pau@citrix.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-5-andr2000@gmail.com>
 <b6f091ed-4fa3-e292-9a21-a780ec90ee09@suse.com>
 <f86a43af-1388-6959-3e71-ba796e4a0c63@epam.com>
 <5a87c401-4ebd-1d5c-b98d-1b535f63be65@epam.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <5a87c401-4ebd-1d5c-b98d-1b535f63be65@epam.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR08CA0026.eurprd08.prod.outlook.com
 (2603:10a6:20b:c0::14) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 8a12d677-f5be-4691-e669-08d9eae217d9
X-MS-TrafficTypeDiagnostic: DBAPR04MB7350:EE_
X-Microsoft-Antispam-PRVS:
	<DBAPR04MB7350661386FFD2BA78F5648CB32D9@DBAPR04MB7350.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	SOl90jslKjRlqxeKiMpbXNHxSnBpbplKdAb1XM/Teo4TXLg3AGOrwYxxv7JjBGGSObeu6KcCZWMlszzgJh7F8xuBhCnJyrRm3E8VsR71Q4eWeanjAlWk5FdG/1VEApSolMqsFsZEAVNj8seW/We83kzXbt6UZzKhURq4K7y3/V3Cufj7LzG5+vzXO3eCGXZxGAV8tn8g/ONfsWVStAkTN9/LRarO7a82NayckNKvEt0Lbk4JUkFFSqncMswWEhz/U56tFqtkpHNFDTZPNWYqop6hZmJVy141CFH69B54KeGX8T0h5vMZYx/hTwT/+jxtPNy+5e3r5lUugRPHSP8C6ZPDjRTEa89+JSokUo2K2JQkJP7O4DTktsTIWUfsmYIPE15IRaPcOJN+fhn9Sig8lvT+ckWZXvBXhCx0KGoyq/BjhZLMwtCRF+1TIHgM5a4Vd/AXebiIjFqFZYe3BOdH01vl2bLzeJjFqkbt0Gu1dyimP2uK3k8CCtl2uNl3UqaOGEOqtP524ZZwmupWmm8iXkU+akYz42y7BNnWro/grH73Xf35qkpu3C0T6E1gMV1gyTpvqkg87A+5C1U3O22BJS/qorih4HXy6qDZCkz0cAbR1vDfCw/vwDzfHb09SmSqyZbHm2Tl37Ns/MQJkt3s1WmSK2e47evMiyKNTRkHYc86R8g0gJkA8llQ5tAzOPabF8cKDWRMa261OOl/7U8fLBC5OPgoWEBFbA1oGmXg7Kg=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66476007)(5660300002)(8676002)(6506007)(66556008)(31696002)(4326008)(86362001)(508600001)(66946007)(8936002)(6486002)(6916009)(38100700002)(2616005)(36756003)(54906003)(6666004)(83380400001)(6512007)(186003)(53546011)(26005)(316002)(31686004)(7416002)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NzM5RjdiT1FrZ2luMEVKeVliMlVuTEk3Ryt2Y09Ua2RkSEYvLzN6d21xbFJ1?=
 =?utf-8?B?YUtJcU1XTUZlK3k2U1g1M2oyeTFyM2drN0MwMFRtN2xwUlNQTlJ0WlQ4S3Iv?=
 =?utf-8?B?NTR0NUVCcWxFWmkwWWxWMFJBNkliSzJkWmtGRDg0bWhYeXVxeTBwY1hUV0d2?=
 =?utf-8?B?VXdkdXhRUHA2WGhTK202REMxTjlWUzlMMHdsa09Jc284K1p4RTBBTHRwWUlM?=
 =?utf-8?B?Wmp0QVJmWHZFbWNSY2ZnTEMzZ09jMmdKWWw2K2lEd0RtQ3gyNTBObUpDdnhh?=
 =?utf-8?B?eEEwalJuK2tGbDZHQmh5NWhOZkFBNHVBMVFnS2c4TTlucnVnNWJNSEg3L2Y0?=
 =?utf-8?B?MElVcFNvSE04VjlCSDBuMWlGMG1VOGRLd3FjQXhDUXFHb2U0Y2N5TzJPWDZW?=
 =?utf-8?B?cUI4TE5lNGJQSGtSLzB6UjZuZ1gySFpOcVVaVTNIcXR4WWJtTVhoQmJ2dTJP?=
 =?utf-8?B?b2ZXeFpwR3pKRUpIU1VyRHA4Zy90VFJvUEZjbFlaZTlYWCtmcGMyeWtzK3JX?=
 =?utf-8?B?Z2pqWFgrZlBPa2ZEQzRmNTdPVXhpR09qTklzaTA1dndBc01YMUg1TTEvTngy?=
 =?utf-8?B?UklHaHU4eFVNRHpNQ0x3OGdsbW1YU05VdXNrVFVqWDc5eGxWVVdTaHRaeFlp?=
 =?utf-8?B?azdsTGVScW5JTFJEdFFaVHI4UG1SMVUreVYzOHB3MVc1K0YxMWtVWHV5WmZL?=
 =?utf-8?B?aHA0OERBbW84RnBEZk5aUnBQZTNEWGFvbU9GUkpTb29jNklWbVQ5WkI2ZFVM?=
 =?utf-8?B?UHZUTlQxNVhFOGtTdVdDNnhYTEdpZWNVVTNDcjJFUE1NZFVDdTdFRGlkOEFM?=
 =?utf-8?B?Z040aHJQMjc2YW9BZzRROWlZeG1nOElHYzJSelorL0VsTnJkckJjREs4Vmc3?=
 =?utf-8?B?VldJbDJQZmVhQi9leVRqQVNKdEZ1VFM2Z05QTEhCM2lER2FTSXYzNmg0eThx?=
 =?utf-8?B?RXhUUEI0UjdWUEM0ZytMaUNDZkk2ejdLQzR3NFAyQ0Z2alh2aWRhWTV0YTBw?=
 =?utf-8?B?MUIyZGlRbEpBWklkekI0WktPZm9lSG9qVVBqcFc1M2pQZUtDMjZTbTY3SlY3?=
 =?utf-8?B?ZlhvRitTS3l6YWpkYjNFWG9CQ0JjSS9aK3dHaUNlSU40dmNFUlY0NG5NZnBM?=
 =?utf-8?B?djlrMFJDTjVpeE40dnBUMTkwRmZPSDliNU5zVWd1NDFqck5SSzB0NUZ5OSs4?=
 =?utf-8?B?dXIwdHhsNmtjK2RZZlc2RnpobW13Y3lDRzAralBJTTlKc2lueEJZSUpEV2Vw?=
 =?utf-8?B?TzB4U0lSVmFZNzNHL2M5TmxPcHBGdW9tanJkYVBBUXpsUTNQN0JCWVcwRG1Y?=
 =?utf-8?B?OWFUbjh4TWZ0ODk0RlNFTGRSdW9DOFhEVCsxZmVHeFFSZjJMSW9yeTVDQXU5?=
 =?utf-8?B?TE5SNGlBbWwxZnYvenMvTGlieW1pTFRmME9TalhTS2RTczFwMmRJTUlhNjI5?=
 =?utf-8?B?ejc3ZGJNS0M2ZWVmQXM3Z2VIbDRzK3VWWXBQQWtjOStvQXVma0c5V1JDdERI?=
 =?utf-8?B?a0w5Z25ocUVReStSVnV5RjRoMGRqVXUybVd4c2ZIR3Rwa1lDUDVmY1dYVDZx?=
 =?utf-8?B?M1hhWXoxMldCOUxuY3RRa21zVHc0SzJ4bkxTNDNNSzU5UHVqb1ludU9SNkRV?=
 =?utf-8?B?OVZjNFBBcmJhWmlyS1NqWVNvdjlyS1Uza2JjV3gyR0pQcU95alVVY1hZWU00?=
 =?utf-8?B?d3hhbE1YL200bnhCR3JLVUpNY2FyeFVKVk9RTFV2b0QvNkU0QWNRb1RtR0V1?=
 =?utf-8?B?SW5sc1VqTkZyQkx0c1J0bTFnUkZac0NrYW4xaXJKcmRnaHkxcGYyTmk5K1hl?=
 =?utf-8?B?cEcrcUw1clpEUjBCSXkxY3h2YUJCeEZBNzZWOEsvK3dlRUEwNUpTSTVrNFA5?=
 =?utf-8?B?Yjl6d1RkU2VvWU44NHlmSVdVZTVqLzAzTFpKNTJhVjJwMk5hVjNabVNnckdX?=
 =?utf-8?B?bTdqM1l2WW1CSnJrclk0aXc4VW9kMFdXOTRIbnF2OHJqQUI1Nk41c1NNRFRN?=
 =?utf-8?B?UmVhY2JKcVQ4OU0ybmJxbEpCM2svb2pTN0oyZnV3VzBpYisyYk55K0tEZVd1?=
 =?utf-8?B?RlArMVd2cDZPNnpmbGM1cWNGNkxkWXVwdEYza0Q2OWh4OW1QMm9CR21BS1pN?=
 =?utf-8?B?SUFXZTBFUElSYjU0aURFVVJBOEhURktWTHhHTDRaSTRNSVZ0aFBmS3RhODhV?=
 =?utf-8?Q?2CTO0KbEzxXhZ5WUPfEW0k0=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8a12d677-f5be-4691-e669-08d9eae217d9
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2022 09:05:03.4862
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rxl7MaOWQPSLM8RmDkoRIOSlQQJTms78CRpB1VkBi/YcO4gEQfEEsNujAZ6cBvD3Tukn9hVr9UpYda6SQ5xd2g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7350

On 08.02.2022 09:00, Oleksandr Andrushchenko wrote:
> On 04.02.22 16:24, Oleksandr Andrushchenko wrote:
>> On 04.02.22 16:11, Jan Beulich wrote:
>>> On 04.02.2022 07:34, Oleksandr Andrushchenko wrote:
>>>> A guest can read and write those registers which are not emulated and
>>>> have no respective vPCI handlers, so it can access the HW directly.
>>> I don't think this describes the present situation. Or did I miss where
>>> devices can actually be exposed to guests already, despite much of the
>>> support logic still missing?
>> No, they are not exposed yet and you know that.
>> I will update the commit message
> BTW, all this work is about adding vpci for guests and of course this
> is not going to be enabled right away.
> I would like to hear the common acceptable way of documenting such
> things: either we just say something like "A guest can read and write"
> elsewhere or we need to invent something neutral not directly mentioning
> what the change does. With the later it all seems a bit confusing IMO
> as we do know what we are doing and for what reason: enable vpci for guests

What's the problem with describing things as they are? Code is hwdom-
only right now, and you're trying to enable DomU support. Hence it's
all about "would be able to", not "can".

Jan



From xen-devel-bounces@lists.xenproject.org Tue Feb 08 09:06:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 09:06:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267770.461522 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHMRQ-0007RD-By; Tue, 08 Feb 2022 09:05:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267770.461522; Tue, 08 Feb 2022 09:05:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHMRQ-0007R2-81; Tue, 08 Feb 2022 09:05:40 +0000
Received: by outflank-mailman (input) for mailman id 267770;
 Tue, 08 Feb 2022 09:05:39 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=GmUj=SX=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nHMRP-0007Ga-4G
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 09:05:39 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 475ddd22-88be-11ec-8eb8-a37418f5ba1a;
 Tue, 08 Feb 2022 10:05:38 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 475ddd22-88be-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644311138;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=h4K/w5avGstELh5ky7AVbNK1DqlLQsINCRuvOUCVlKE=;
  b=fiWxexMW9UTJpyd61lnQztHemEc+V3Z6CYXt0iTSgCdYGDwf5NbCV4Za
   URoKUNqTqnr4a4V22vkcgZY3MB8oTi5L0on5774rUk1uykD1JmVz9WVpu
   +5lV6H4PmD7sbZEDoxxtO0Sp2ANQdyX3RrTGec34JEYcn3dIPlqkTdhyQ
   w=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: f0Wsqfws7Zsc9klXGC9pB5J04ov7hxMYPLREhVnfETKvCC2NKH3pmXZYbxMBQi3xuYnJ79TIjQ
 2pb0uLzNBNE+Qz0XqInIm0+1g/A0lEGt4SI6FBsKNAHIeAXkPoDIZ+Lk7Ofomw6yrwk/RbMI+t
 02A2ohWUpW3XStrY0yLoadQmes8FWAVDFeIUZNjrAONahk/9Zw2OhIotRAnbUdV3hcQE5mSgpA
 KV4hSCm6qHawZMjBjN3085DGQnaoKsET/xGf/DzQpXwO82UN2E1WwDvXANFqUStuwnTFGiFFb+
 Y2fNrfg4oN98VSvgRhoB9Nj7
X-SBRS: 5.1
X-MesageID: 63714736
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:pgIGzq6NCh4J28I5q4A0jgxRtBjBchMFZxGqfqrLsTDasY5as4F+v
 mscXmrQOqyCMDDxc4x0O9iz8BlT6sWHmNViTQBs+S83Hi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FV8MpBsJ00o5wbZj2t4w2LBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z6
 9FIlL+oaVgSF7zsqPs0XDsHASVhIvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALNs7kMZlZonh95TrYEewnUdbIRKCiCdpwgmxv35wRRqi2i
 8wxZBNMSTj/eid2PHQLVp9jt/bzvlXuWmgNwL6SjfVuuDWCpOBr65D1OcfRUsyHQ4NShEnwj
 kvc42n8NTQLO9WexCSt/2qlg6nEmiaTcIgfDqGi//hmxlia3HUOCQY+XEG+5/K+jyaWS99Zb
 kAZ5Ccqhawz71CwCMnwWQWip3yJtQJaXMBfe8Ug4QGQzuzP4gCWBkANVDsHY9sj3OcIQjgt2
 k6MjsneLzVlu72ISlqQ7r6R6zi1PEA9L2UPeCsFRgst+MT4rcc4iRenZvFnHa2uh9v5AwbZx
 TyQsTM+jLUei80M/6ij9FWBiDWpzrDLUwo06wP/Tm+jqARja+aNQIil6kPS6/paG7qIVVmKv
 HUCmM+24fgHCNeGkynlaP4WALij6vKBMTvdqV1iBZ8s83Kq4XHLQGxLyGggfgEzaJ9CIGK3J
 h+I0e9M2HNNFFiuaI5Ue6LuMO077Zj/PNvHCeLQccUbN/CdazS71C1pYEeR2UXkn04tjbwzN
 P+nTCq8MZoJIf85lWTrHo/xxZdun3ljnj2LGfgX2jz6ieL2WZKDdVsS3LJihMgd5bjMngja+
 s032yCim0QGC72WjsU6HOcuwbE2wZoTWMqeRy9/LLfrzu9a9IYJUa65/F/ZU9Y595m5b8+Rl
 p1HZmdWyUDkmVrMIhiQZ3ZoZdvHBMgj8StqZHVybAzxgBDPhLpDC49FJvMKkUQPrrQ/nZaYs
 dFZEyl/Phi/YmueoGlMBXUMhIdjaA6qlWqz09mNO1ACk2pbb1WRoLfMJ1K3nAFXV3bfnZZu8
 tWIi1KAKbJeFlsKJJiNMpqHkQju1UXxbcovBiMk1PEIIx6ymGWrQgSs5sIKzzYkc02cn2DHj
 FbPWn/1Z4Dl+ucIzTUAvojdx6+BGOpiBEtKWW7d6Le9Ly7B+WS/h4RHVY61kfr1DQsYIY2uO
 rdYye/SKvoCkAoYuoZwCe8zn6k/+8Hut/lRyQE9RCfHaFGiC7VBJHia3JYQ6v0Rl+EB4QbmC
 FiS/tR6OKmSPJ+3GlAmOwd4PP+I0usZm2eO4K1tcln6/iJ+4JGOTV5WY0uXkCVYIbYsaNElz
 O4ttdQ48Qu6jhZ2YN+KgjoNrzaHL2AaUrVhvZYfWde5hg0uw1BEQJrdFi6pv83fN4QSahEne
 2bGirDDirJQwlv5X0AyTXWdj/BAgZkuuQxRyANQLVq+hdeY1OQ82wdc8GprQ10NnAlHye96J
 kNiK1ZxefeV5z5ticVOAzKsFgVGCEHL80D90QJUxmjQTk3uXW3RNmwtf+2K+RlBoW5bezFa+
 pCeyXrkDmm2LJ2ggHNqVB43seHnQPxw6hbGyZKuEMmyFpUnZSbo3/21bm0Sphq7Wc48iSUrf
 wWxEDqcvUEjCRMtng==
IronPort-HdrOrdr: A9a23:1ub9EK0lxhbJ/dJB82GjmwqjBVByeYIsimQD101hICG9Lfb2qy
 n+ppgmPEHP5Qr5OEtApTiBUJPwJk800aQFm7X5XI3SJzUO3VHHEGgM1/qB/9SNIVyaygcZ79
 YcT0EcMqyPMbEZt7eC3ODQKb9Jq7PmgcOVbKXlvg9QpGlRGt5dBmxCe2Cm+yNNNW177c1TLu
 vh2iMLnUvpRV0nKuCAQlUVVenKoNPG0LrgfB49HhYirC2Dlymh5rLWGwWRmk52aUIE/Z4StU
 z+1yDp7KSqtP+2jjfaym/o9pxT3P/s0MFKCsCggtUcbh/slgGrToJ8XKDqhkF/nMifrHIR1P
 XcqRYpOMp+r1vXY2GOuBPonzLt1T4/gkWSvmOwsD/Gm4jUVTg6A81OicZyaR3C8Xctu9l6ze
 Ziw3+Zn4A/N2KOoA3No/zzEz16nEu9pnQv1cQJiWZEbIcYYLhN6aQC4UJuFosaFi6S0vFqLA
 BXNrCc2B9qSyLbU5iA1VMfg+BEH05DUytue3Jy9PB8iFNt7TJEJ0hx/r1qop5PzuN5d3B+3Z
 W1Dk1frsA6ciYnV9MNOA4/e7rFNoXse2O7DIvAGyWvKEk4U0i92aIfpo9FoN2XRA==
X-IronPort-AV: E=Sophos;i="5.88,352,1635220800"; 
   d="scan'208";a="63714736"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ST3RM8TV2Mj4TiVoSljUlf9J6/EQR789Xx7Jz4WxHwlAB4C5VJkPex3d7GjF+N/ZYcoI2TzQNx+vLBnSruaxD/oXVETazojdqCnMdxQrLT/y1YqvQQ/W57cZpAODW9lKFSmbF+k1uEWAPVkfwxg/mlZ53/s2Kl97sMej8rWJjKkPRCymWxZntLaCk53XAE1ZcQHKqT7I296VnSe4Gep/DkIfCHoWIamGXl0CJUoTvR5fgj+0ae14VS9YKDhMLLN6GIQOU6xGPhHAVC440xbFeNjylT/5FgskzX0CZKc0zbVWXwxrlinkVWTzftbuoP2GtulEAb6roIozyFcvesoXFw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=O8c49+exqzIWGjgj1m09xmEF8LO+OXQwJssQsXtvCzo=;
 b=cSGPswqw8UF9F5jVf/q/KomjvkreAHuMVHP/QuVqIzoad3OZk1puRqYwDJxDGP72mA8SZBrcyWTKN/vgJh1D2Bq2RQ38/Qp9RxCm6Yf3gNMNw4oNhGe5IcygkNZ6Xhf6TFNTV49I5Muv4lDmrSXHTVMRhQ8gJDXST0eWiK2PyZ4ZRiVqlCKx2EBAc/7wlWC/L2YGxJyocDoFFJm2N1gwEAtRC1atyYikxKj3wvJSLzGFZrCJjEMwJlaesT4j4u5iGlskQ/EDclFcGGldh1IOkjwMr0/vnuYVDPeekkVmDNvNnlESnvLVmSb9EXqyfei06pr1uMVdVWUtF8jDm/9lIw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=O8c49+exqzIWGjgj1m09xmEF8LO+OXQwJssQsXtvCzo=;
 b=lkuPgJ2d2NmeKkIzx/V225R1x6H3DCAFxhBUR1a6Df78N73lpPqFfaiwmKlfLY8U3+o+3p8Q7C05Ny298cJ2P5bb+x3XhcOo+Zouz8/BYtwH+gTx2tGvcNLVZEYaU5NJaEVI/JoJN8fLwAU9I7Al+GYr6YyMGNGflwz+hSLFiLo=
Date: Tue, 8 Feb 2022 10:05:27 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: Jan Beulich <jbeulich@suse.com>, "julien@xen.org" <julien@xen.org>,
	"sstabellini@kernel.org" <sstabellini@kernel.org>, Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Artem Mygaiev <Artem_Mygaiev@epam.com>,
	"andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
	"george.dunlap@citrix.com" <george.dunlap@citrix.com>, "paul@xen.org"
	<paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>, Rahul Singh
	<rahul.singh@arm.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v6 04/13] vpci: restrict unhandled read/write operations
 for guests
Message-ID: <YgIyV9iboIxVrCS3@Air-de-Roger>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-5-andr2000@gmail.com>
 <b6f091ed-4fa3-e292-9a21-a780ec90ee09@suse.com>
 <f86a43af-1388-6959-3e71-ba796e4a0c63@epam.com>
 <5a87c401-4ebd-1d5c-b98d-1b535f63be65@epam.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <5a87c401-4ebd-1d5c-b98d-1b535f63be65@epam.com>
X-ClientProxiedBy: MR1P264CA0140.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:501:51::6) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c3b91dc6-cd08-41dd-5a52-08d9eae22976
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6391:EE_
X-Microsoft-Antispam-PRVS: <SJ0PR03MB6391FBBBADB2C90D6DBF230C8F2D9@SJ0PR03MB6391.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: TTrBNmojxesaU+dlGiZk9NTI+E3Q9qQj1Qk7IuhAAFitgMA1t2H6TC5gdzKXm9eKUwIpF37Rtgw8Fb8MIRuAaBe4/6hSgqhFwf/MYeofkDprMCWHKpMYX6xsfpv3yKrgggHqQ2K+X/j1rim1/DBz0QmtaGUZbeyRSK1sRFviH7ffML+zbFU7cEQPt4evA1VDxJBLFaTV94hPDaJ6uILs2nAy7LOUd1DyDtvy0J4k/IV5nYnK3AcIAeLym+kRC2Np/ySLuDZXWpM2VH1KgupZLsenn27Tg0grakcz3at0e4BYZTQV913AakSce92zeWElVWFCUMK1hv5o6HdGayhNfmeHLAHX+0Iwbh5ehQEUvSB75U2G8KWzpjKa/MjpfPvwsPG5iUJJ9oGmHw/4t0Ya8cw6I/q3HRhKVU4Zwljd9u9v9sA2JXK+6DTH8q7JryokWWCbbHztNlnvxyGwyEbnT2aNQXSopQ50B987ao7H0kHDXQp+0Z6ftHxNZOHY5/gRk7/bEFzOu4IemDyK3r41XzgMRMxHhRYw7gv+xNV3a5hxDL10AXVVLVYe4Zn7da1ZaDR2NeFUp2KvTDCiTywIe5xULVpXuuF6UtMzJdszNqXe1QctWI9Tuk/9QMYdMxNIH0uEd+VSESlQEbapQuat8Q==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(5660300002)(508600001)(7416002)(6486002)(6916009)(6506007)(66476007)(53546011)(66556008)(4326008)(186003)(8676002)(2906002)(26005)(8936002)(66946007)(85182001)(9686003)(6666004)(316002)(86362001)(33716001)(82960400001)(6512007)(83380400001)(54906003)(38100700002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WVVLeEd4WlA2eHBVYytIZlY0eS8zaHdHWnV1cEMrNmlYR0pGdTlVWWphdEpi?=
 =?utf-8?B?VzlmUHRjdHNLVzBmRW1FRTYwS1l2QmRUaDQzVm90aHFubUIvZE1uN0dOZzFI?=
 =?utf-8?B?eE5iRE9XTGJTZzRsVVI4blAwem5EVkpTMWIvNklON05DWjd1aXlXeTJHdG1H?=
 =?utf-8?B?OStrZ3d3VXE2Yyt4dmdlWnUyTjBWdXJwa2N2YlZ2cGJDOTZYaGZZR1ZzMWhG?=
 =?utf-8?B?Z0daeGJzN1h2d1o1UWpMNkhrbFJTejk2NFRnWU9ZcDdld1ljdFJqcm9pbjAw?=
 =?utf-8?B?eHNxVEozaXlTUjFiMzQrL0RZQ000NkdLcGRUVHFKUnFxTDZIdm5pVDhwZGlv?=
 =?utf-8?B?SXJxRWt0WmsvWGFWNWxraVZXa0ExdnMwNHArZTBManZISmxuWXBqY0M5eUEw?=
 =?utf-8?B?Nlc4dk13dTRabzcwTmNZTTQ3YURzM3htZkhzTWdkUElidjVaNzdpalV6NnFs?=
 =?utf-8?B?VHplLzMveEVNdjhrVXg3eVlFY1M2MitXaHUzRWFZN0FLOUd0NDZ4VVV0RWlI?=
 =?utf-8?B?bnljYjdnZ2tsRUEzV0JHaEZoZXpoMXQ0ZTNHZ3VjZVB4cFczSHhuVHRuaEVZ?=
 =?utf-8?B?ZlNCRFlrM3k5YWszdEplbFlUY0hJdGZ1WnRaL2cwZ3M5QUxGZmVGSmJxWnVx?=
 =?utf-8?B?OG03Z2tTRitPaGZPRi9EbCsvQWNXNUNTb1ptTDgrU1d3SEQya2g0YTRIbUV2?=
 =?utf-8?B?ekxobU9WVkNNcGthZWFIclk4Sjl5K3ZrSVZ1Tm93MWorZzNjcFJSaXZBNXpz?=
 =?utf-8?B?cEZERWN3V01SaTBubnZjL0FMdXJsb0NKdElTVHcrRUowL0dsdy9MaEJFTWFr?=
 =?utf-8?B?cjZTcFEvbHE1eEVBVzJRTkF3Vm5WSE90ZXY2dG84OXNxUXlpcWlVdnA2dlcv?=
 =?utf-8?B?UW5YUTFWZ1BWUEZyQkpkclJneE1vSnRyVEU4MTVQMHlSZHgwdmVFemZySGZJ?=
 =?utf-8?B?NHhqVGVaTjVZKzNETzd6ek5oRDhDT055eS9qZ0VaZEkyUk9zdkUwOWVoK0NK?=
 =?utf-8?B?dTVvOGtVeVhSaWxIT2ZHcExSOEZqUkczMkNiRitsZTg2bU5KbHVyRS8zNkpj?=
 =?utf-8?B?M2l1TnRjWElhWEY0RzdhUUVjM1hkZENTZUFKR0xKOCtxS0J5QmVSVEJxcktu?=
 =?utf-8?B?bENzbk96ZW04S1hmN1paQit3ejNabWJnWE00ZW5nU1hKUnVaNXhsRHpXbmg5?=
 =?utf-8?B?Q0lFdUZnbFlRRUtvdy9tSXBCeklVWEtPZ1VDbzFiZ09NcWJITGFqZlh2S3hk?=
 =?utf-8?B?Z3dVVGJuVXZ1MnptQjVUTjBWVCtIZlpOVVk4ZDFhdU9jVW1tb1I5elZyWFdz?=
 =?utf-8?B?Vk0yN3dIQSt0emRWcDBJUFVCbHRVSFJrWmZ0dTUydEZZRjBhZllZMVNyanRz?=
 =?utf-8?B?WGJjMVZnUlV6ZVlJT1MxTmwwbEJaNm9TY0VEYUhMdXM5TXBXMDN6cWJqNnZq?=
 =?utf-8?B?cklJZk96eVM1TDJIREF2WUFqVlNTQlhkeCtTZE55VjdGSzdCMVFReGlzSVRq?=
 =?utf-8?B?T3FBb1VYZzF1NWxCWXZxa2hBSEZqWFB0eVRUTTNTTldIT1pWWWxkMmtNc3dE?=
 =?utf-8?B?ZDdNV1huN2JCQlNFL0hzSlhiNnBGaEdjZE5jRDlqU3NqZis0a3Vac3B1aVdS?=
 =?utf-8?B?MmZzMXA5d0NXWTlRVGx5T0oxMnlHcnpDbEdBZFhVUUQxS3VjbnhsVlU4c1Nn?=
 =?utf-8?B?RXFTazdiV013aWRQNXlTN05raHN1aElaMXR0cWN5RlVPVkR6MnpkeFI3Y2VE?=
 =?utf-8?B?UXM0Y1J4dWU1c1NFNlBuUmtXazZvNksxZ0p3Q2c2R2tXcWpvQVhOMGUxMDNN?=
 =?utf-8?B?Y2lvRHBtcjRTY3lrcjlqSmdJNzBVazljQmZ6UU1jalF0TGNzbVRvb2dId0pw?=
 =?utf-8?B?TmMwR2VhbjMyQVhBMG05bi9JKzlDS1dQS1ZibDVvblJmYmFXR09lNmdycGZT?=
 =?utf-8?B?RFVpajMxK0lJdGpYSTBYaTZJOWk3a0dlOXZvSUpjUUZTd3R5dEVOZlAvQWIr?=
 =?utf-8?B?VmpjeDNMMUZjUUZVaDNINWJidkZEZjlkOFQwSzJDalR3Vk1tWGJqK043L29Y?=
 =?utf-8?B?U3VESzNmbE5OcFBGdmRsRlU2cXhVcGhETWpmdnQ5S1VUbElMRHBKNkQyVjE4?=
 =?utf-8?B?RGVoemNUQXc0MEZ3K0VyWTJ2b2ZxNWhhVFcwVEJLbWl5U2VLeHM2UWE1cGkr?=
 =?utf-8?Q?n4FVveWHKaiNGayLtxqs5NQ=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c3b91dc6-cd08-41dd-5a52-08d9eae22976
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2022 09:05:32.9859
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vkEpvu137Nh+vDtk2i0JPbMgx36hzpSylJM1Mjccd5RjdEjaHERZxD1aPwloplsdUK1xZccQRThjjJ+zjfisrg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6391
X-OriginatorOrg: citrix.com

On Tue, Feb 08, 2022 at 08:00:28AM +0000, Oleksandr Andrushchenko wrote:
> 
> On 04.02.22 16:24, Oleksandr Andrushchenko wrote:
> >
> > On 04.02.22 16:11, Jan Beulich wrote:
> >> On 04.02.2022 07:34, Oleksandr Andrushchenko wrote:
> >>> A guest can read and write those registers which are not emulated and
> >>> have no respective vPCI handlers, so it can access the HW directly.
> >> I don't think this describes the present situation. Or did I miss where
> >> devices can actually be exposed to guests already, despite much of the
> >> support logic still missing?
> > No, they are not exposed yet and you know that.
> > I will update the commit message
> BTW, all this work is about adding vpci for guests and of course this
> is not going to be enabled right away.
> I would like to hear the common acceptable way of documenting such
> things: either we just say something like "A guest can read and write"
> elsewhere or we need to invent something neutral not directly mentioning
> what the change does. With the later it all seems a bit confusing IMO
> as we do know what we are doing and for what reason: enable vpci for guests
> >>> In order to prevent a guest from reads and writes from/to the unhandled
> >>> registers make sure only hardware domain can access HW directly and restrict
> >>> guests from doing so.
> >> Tangential question: Going over the titles of the remaining patches I
> >> notice patch 6 is going to deal with BAR accesses. But (going just
> >> from the titles) I can't spot anywhere that vendor and device IDs
> >> would be exposed to guests. Yet that's the first thing guests will need
> >> in order to actually recognize devices. As said before, allowing guests
> >> access to such r/o fields is quite likely going to be fine.
> > Agree, I was thinking about adding such a patch to allow IDs,
> > but finally decided not to add more to this series.
> > Again, the whole thing is not working yet and for the development
> > this patch can/needs to be reverted. So, either we implement IDs
> > or not this doesn't change anything with this respect
> Roger, do you want an additional patch with IDs in v7?

I would expect a lot more work to be required, you need IDs and the
Header type as a minimum I would say. And then in order to have
something functional you will also need to handle the capabilities
pointer.

I'm fine for this to be added in a followup series. I think it's clear
the status after this series is not going to be functional.

> >>> --- a/xen/drivers/vpci/vpci.c
> >>> +++ b/xen/drivers/vpci/vpci.c
> >>> @@ -215,11 +215,15 @@ int vpci_remove_register(struct vpci *vpci, unsigned int offset,
> >>>    }
> >>>    
> >>>    /* Wrappers for performing reads/writes to the underlying hardware. */
> >>> -static uint32_t vpci_read_hw(pci_sbdf_t sbdf, unsigned int reg,
> >>> +static uint32_t vpci_read_hw(bool is_hwdom, pci_sbdf_t sbdf, unsigned int reg,
> >>>                                 unsigned int size)
> >> Was the passing around of a boolean the consensus which was reached?
> > Was this patch committed yet?
> >> Personally I'd fine it more natural if the two functions checked
> >> current->domain themselves.
> > This is also possible, but I would like to hear Roger's view on this as well
> > I am fine either way
> Roger, what's your maintainer's preference here? Additional argument
> to vpci_read_hw of make it use current->domain internally?

My recommendation would be to use current->domain. Handlers will
always be executed in guest context, so there's no need to pass a
parameter around.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 09:09:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 09:09:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267785.461533 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHMUr-0008Fz-20; Tue, 08 Feb 2022 09:09:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267785.461533; Tue, 08 Feb 2022 09:09:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHMUq-0008Fs-Uj; Tue, 08 Feb 2022 09:09:12 +0000
Received: by outflank-mailman (input) for mailman id 267785;
 Tue, 08 Feb 2022 09:09:11 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1FiY=SX=epam.com=prvs=40383cc40e=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nHMUp-0008Fm-B2
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 09:09:11 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c61637cd-88be-11ec-8f75-fffcc8bd4f1a;
 Tue, 08 Feb 2022 10:09:10 +0100 (CET)
Received: from pps.filterd (m0174676.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 2186iuid013526;
 Tue, 8 Feb 2022 09:09:06 GMT
Received: from eur05-am6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2112.outbound.protection.outlook.com [104.47.18.112])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e3kgu0kf9-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Tue, 08 Feb 2022 09:09:06 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by VI1PR0301MB2429.eurprd03.prod.outlook.com (2603:10a6:800:63::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Tue, 8 Feb
 2022 09:09:02 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77%3]) with mapi id 15.20.4951.019; Tue, 8 Feb 2022
 09:09:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c61637cd-88be-11ec-8f75-fffcc8bd4f1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=h6OGuQK6+MlxfamnnsUbjXhkxdpx9n1/eVPs39Oy2/ne3MhURO2ftk4vV7S+azoD8HQfJaZPSbcfdD58ZiSBsOFHLrSqkBhqG6xlm4Aekpx/FVeCIKHEO8nY0ChCZGG11DA8ypjkp6KdY5aMaQVcWikqvEo8kOFekyLT+oNyq03fbXXVbRS3ZS9aEy5K8pVQ3+P7xvrFjEvL+kCmap8GG8ZbpJGIBrDSQ9ukSvSbSgUqD5vXzNTtBAzyOGrmfB4sSGVYpfwSMrK2UYwGX+acDS0FACU7/dj6/hc4deWjYzyP4mkCyW/K/dW8c24VOKRR7j7tVK5XvDW858N9hjm4hg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=G0KkUCduQ6HfasSkTZ2teGTALX11N4n2SWZa1rCA//M=;
 b=bWl9OTlMQZk/kP+BixEWYQqYjxysC7jZKZ9gVfq+Q3ULTCysBvbeg3yhJZNDD5idK/KsgjYppht3GEq/OVtAF8C9rTHhU3B+e0mLQ+JRPSbR98+bd62bdF2wRPBckMX8o2SVaHb9/+VtfnYzf+v0u1VTi3BCKG0/doHjs8CqR9qxAn+cQDs61uuSi4QmaGVmyu/MrSEGJ11W3pKqvQyJB/cYUzAXdOOpv0Sb7slJDVKZOeFZrFUsEU6qNzF/MIyblnslRmqruQjWoe30lQcnlyH9gbnr1/30EX716R7//Nc5OF7O9RiSIsIEMlkj/LPE38+/IustIeB1Thiq4VSPGQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=G0KkUCduQ6HfasSkTZ2teGTALX11N4n2SWZa1rCA//M=;
 b=PDvNIgh9qj8beRSaf8bd+8SFd7oys983byGAhbAda71cpd1QLTBYO5dFRu2v+oICqiWEb1tPr74VKLbbGS1MxO48gf7cS0yb7s1AUW5rs/vOoMFgxSWb7YCrB0E5VbQe4fC25JTlty5NcLZPJ+plqdBRANG0Q/ABHQ7NgBM21UUWZTTGIvVE4yIB2D2QD2ISDMuRQiFE8uQLMd6Vyg3x8PiwUzrDQ/18Hev1EAyhzbkD6kSKrACtZY2ahQyBU14KVNP8kn/oSvP+RODM0q4lr3I7sZNIW9vi1XmAmqyGJlBYAiq5g+ewNJFwi2hkW8XXdbOL/NXXkHrWEjTpLy5vvQ==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>,
        "roger.pau@citrix.com"
	<roger.pau@citrix.com>
Subject: Re: [PATCH v6 04/13] vpci: restrict unhandled read/write operations
 for guests
Thread-Topic: [PATCH v6 04/13] vpci: restrict unhandled read/write operations
 for guests
Thread-Index: AQHYGZFbf8/6pUr0mUKzbmboCx8QkqyDbvWAgAADnYCABd4pgIAAEgeAgAABIYA=
Date: Tue, 8 Feb 2022 09:09:02 +0000
Message-ID: <b51e5a3c-675f-19ed-ba9c-f1cd3da4e36e@epam.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-5-andr2000@gmail.com>
 <b6f091ed-4fa3-e292-9a21-a780ec90ee09@suse.com>
 <f86a43af-1388-6959-3e71-ba796e4a0c63@epam.com>
 <5a87c401-4ebd-1d5c-b98d-1b535f63be65@epam.com>
 <780dce9f-7d1c-39d9-278c-e89ba0b25ee1@suse.com>
In-Reply-To: <780dce9f-7d1c-39d9-278c-e89ba0b25ee1@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 0ad0d9be-ec56-4a6a-aa35-08d9eae2a671
x-ms-traffictypediagnostic: VI1PR0301MB2429:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <VI1PR0301MB24292B93E8D675BC83ACAE96E72D9@VI1PR0301MB2429.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8882;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 Gr225c4wuuXOcHAxvrTQNhatZYU1f5c5W4dVHi2Ic0krWgRQXhFomZesmbfQeiTVQN5FUVIY4fsa24aMACRG6fVfoemIkiX8a3Mp0K5DHSvtX5q8l6AvGkOHGrxf2b+6ajLYOvu17XvDOkkaILYPTMaLyqxma2JFIubY5U6oqGFB9kYk8ONktiGr+Fgvgg0Kd4zEAU+Ad2ah6I/Tob/RSrVUHw7CGkvZj8IWDDj/BXceOEMvBw7f6agGZeMgM1Htr1WW36OoAJ+s9IuQ77VRYcfDccuEKF4p8pRZ/Mj1/T37Vo0BUfmbdq4sd/DJSKGwqcW399DNMcjWETxFvqmMLPQPT/MQqV+XtiK8CPQAcwVAyUrnePFzOqjLcp9zeSZoAilLz8T5cSohymRIYqhdavoJKUkRRq+rgQMT8jNMO+PPj1iem0iLxXrJQfFv6gbPPLt7bgsLOO3ILU3fKj+GNDW1LMnkkVg961bvEfUU0VC3OQl9JXeEACjN4EwThUmnkbJ2Q874tbcFjbVhh22GI98VVrCcSG4pCjQqqrV8rCif+uxFsCXJeOfcmZFTFMZW9UgOzorRFB0iWywv6WAlh17AWCXmXcgCuD9ocPvbHskjdGvXY6C3DS+4P4qEg9UzcAmL/nxDcXvLEfB+05skBf0PypP7wNJZAQNR7nHsaZbs2NzDn3hLvuI4hUvxsgAq9b8wDuWbfP+XcB07KL0qBflRxE8Gfm5+SbXQJi7zbjI=
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(4326008)(6486002)(71200400001)(66476007)(66556008)(508600001)(36756003)(91956017)(5660300002)(38070700005)(31686004)(7416002)(122000001)(8936002)(2616005)(64756008)(38100700002)(66446008)(8676002)(76116006)(54906003)(316002)(83380400001)(6916009)(26005)(6512007)(6506007)(31696002)(86362001)(66946007)(2906002)(53546011)(55236004)(186003)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?OWY2eHVERkZ1Z2ozVVhNbjVaYVE5SXVNcEFGeEs0Z0JxUFlUcnpjUGJXdkJq?=
 =?utf-8?B?UlBObDA4V0ltb3RlV0ZyUTlXYUdlYUVvQkVaSVR3UGNlQlVuUTRkM2tHYjNp?=
 =?utf-8?B?VVpCanZxQmpRMmFOdWh3OGNKWEVuYkNLaTl0VDRXS256QXRMaEtqcGh5Y0F1?=
 =?utf-8?B?RklQMVpDZHhWeTBhYVZZaW53M2xXSG5pM2hkVHNXT3ZUZy9ya2xaNGxSRE1i?=
 =?utf-8?B?US9Eall1MDNKQ3dkYUxXcDR5WnpkK0V1RW84a3RnVE9SOUMwZXBFWWczRUdi?=
 =?utf-8?B?VXU2ZHZseGxZS2ZzUk9KZWpiTmd4dnhKT3JHMW5jcEJtaWQwOW5UVDBSdzdl?=
 =?utf-8?B?NG9BRTQxeU9MLytKVHA4bmx6UEtTY3I5Nk1scW03dTd1WVIrZ1ZhOWVoVXBz?=
 =?utf-8?B?RlNwUGxSTzJPV3dxdGFQaEd6di85dUdnQmllNGJkcS9KV3ZVNmdXQ2d0cXdo?=
 =?utf-8?B?NVhvOGlBYlBwSkVvOVdVTFcvYlZydFN3ajJiVEFMd3VLT0JwYWNySWtHMElB?=
 =?utf-8?B?NjZuZXhiaGIwZ0ZNYmZsL0h0b2pzeERZaFRWejYyZDFMWWNFeTJXNDQ4N3B1?=
 =?utf-8?B?bUF6U05wUFZZbWVrRW0rM0o1bEpyWnN2OXc2b0UrUHB4VEo2b2xBam0yNHFJ?=
 =?utf-8?B?ZGh5ZVhlTGRwdGFxaVRVNTNYS1NYVE1oenN2eWhGL3dSc3YweXNpNHBWQVZC?=
 =?utf-8?B?U2MyWFBRTXV5bmNyaUVNUTFVZEtxTng3Z2hldWhqL2t4RUZyUmJObzgvbmZy?=
 =?utf-8?B?bURKSFJJOGNibDFmN051WDFrMVpQOGdxWXE2ZWNwY2huZ1NRcjJUVkMwVmtq?=
 =?utf-8?B?ektKTnVldnBYOFdSQWZhQUk2cVhUR0JnNjl1MzRHVHBNVHlyZkx4MnpaRElH?=
 =?utf-8?B?S3VUQW5vOG1kdmxPNHV3MEVibE5qc3FtUDRGZERBSVk0RVRWRHZucjJuQ3JF?=
 =?utf-8?B?a1dIbENOYmp1U3lCUzF4NGVzeWg5OThibk1iMGVic2lvL3AyMC8rOEZFUHdq?=
 =?utf-8?B?cWc5Q3NxK1kreEw1UDEwdVZCc29nNlN3bFo1MGJwMlhGY1JhK2wrMjhrTUNI?=
 =?utf-8?B?eGhXcmRVb3JJR1ZzK3A2Y0JhS0VadTZmZDBDMEFPRzYxUnB0Y3JmaisxZ2gw?=
 =?utf-8?B?V3pKclJuTDBucWVFMVV1dG9DMzBWNnB5bjhab0l6QkEveWd5UElxc3dnK0g1?=
 =?utf-8?B?Q1ZVZWZxaUhjaVdSd1cyVVhVbDJlM1NHQ0hsUktIRzRkR2MrNW1DWlVRRCtN?=
 =?utf-8?B?QXdnTXNtMG84Mm9peWprU0d1Z0luUUcvVDRHWGYxR21aNXRNbEZjRE9wR3pr?=
 =?utf-8?B?NTF4YzhaRm8zVFNIaGxZUlVyWVhla2RYNlhjNDMzUUxqeTYwbE52S2tvclNz?=
 =?utf-8?B?c1lwK2JjNHhRelU4S3FFVFVwNWRaQ05BeE4zeUFnZ0E3T1dOMUNGZDAzaXRu?=
 =?utf-8?B?cEFqaktSNWlUNUFRckZXVGUxdXl5ODg4Z3ArWmFUWDFZZk1TcmtQSm9sUG1t?=
 =?utf-8?B?ck9SdGZrdUJHRzE4SUVoaDUvZFI2K0s5TmwxQ0cxQi9WOWFwMU5BMmdpZGM0?=
 =?utf-8?B?amRaNHMwNzBJMEZDWW1kZUx6Y3BMam96VXd5V28zMHN3UHN3RE5XdzcrTDlC?=
 =?utf-8?B?SjU4b3VwTUoxdjJKcWFmMktCK2t6MTBKK2JUU0dIcUE1OTQ1UWRyNDZWMFZG?=
 =?utf-8?B?dmZDSEpDRFdXTDlzVmdWdm1nMGI3NGtHNWsvSzQzekZKSGduVXNQSzFWOGFo?=
 =?utf-8?B?V0xLdXJPMFRuZ1JnbVYySHUvV3QrK1l4dGtCSGhabnBlMlJqektjQjY3b1Rw?=
 =?utf-8?B?NFA0NmtxVVcvYjBERmhjbHB6a3pTODhpOHl4b3VuK2J1V0tiSnYrbnFaemhy?=
 =?utf-8?B?Z2lKM1BMRkVpL0ZJY1pqVGtPeVMvN1pwVDVMZ0FaLytFTU9nVm5pcnVHUDJD?=
 =?utf-8?B?S2c3U1cwUkc0UkhQQ3hjY2k1SS9ZSkZucS9ySTY1ZUtTUDRtLzIwenlmemVT?=
 =?utf-8?B?Y1BQQWpLT29yUGU1Z1N0QVFPejZJMitkUXZ4ZmZydSs5OWo1UTVnVkZvSTYz?=
 =?utf-8?B?WTFIYWRZcnpOSTNPOW11UUlPa1NEa1pZTGxUMUVsak1ieUF6bU9qMHFhbzJS?=
 =?utf-8?B?eVIxSERiNllCQlVzbnQvQkxKandxZFo4WEVSbFJkTkRlc2F5QjhYcjkzU20w?=
 =?utf-8?B?U00wTHJ6WDFGTTlRWE5rbkNSdXh2K0IwU2txRCtLT25ialkwc3RqeUFxc1J6?=
 =?utf-8?B?NU9seVV0ODJjL1VWSGkvK1oyTkV4RHVhYldVbG5iN01KLytmYzB1QTZHUUxm?=
 =?utf-8?B?M3NEWERnZENsYWZiN0tzNHZBYTRaOWNjWEJoSGg3T1FScUZZcVVGNU80dC9k?=
 =?utf-8?Q?efYgEJPgww4edq6M=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <5757C1BCCB98B940924B967D19D2F232@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0ad0d9be-ec56-4a6a-aa35-08d9eae2a671
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2022 09:09:02.4517
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: nsLY7pGoLeHiO8ngDJ0nGFavE6o/Aigh5qeufzFowPe1Hz88NYsgsPiSGCPz9oMnr8gZ0Uq1Rubcv7DZJfHqDfDQTpciwNu1CCiyWE9tLhpD7FDwx5BDdNe8DxXP41k4
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0301MB2429
X-Proofpoint-GUID: ZilNiSm7QClNYiPkQN_GqW-FRLQfmeJ9
X-Proofpoint-ORIG-GUID: ZilNiSm7QClNYiPkQN_GqW-FRLQfmeJ9
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-08_02,2022-02-07_02,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 adultscore=0
 clxscore=1015 priorityscore=1501 bulkscore=0 phishscore=0 mlxlogscore=999
 malwarescore=0 suspectscore=0 impostorscore=0 spamscore=0
 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202080052

DQoNCk9uIDA4LjAyLjIyIDExOjA0LCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMDguMDIuMjAy
MiAwOTowMCwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+PiBPbiAwNC4wMi4yMiAx
NjoyNCwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+Pj4gT24gMDQuMDIuMjIgMTY6
MTEsIEphbiBCZXVsaWNoIHdyb3RlOg0KPj4+PiBPbiAwNC4wMi4yMDIyIDA3OjM0LCBPbGVrc2Fu
ZHIgQW5kcnVzaGNoZW5rbyB3cm90ZToNCj4+Pj4+IEEgZ3Vlc3QgY2FuIHJlYWQgYW5kIHdyaXRl
IHRob3NlIHJlZ2lzdGVycyB3aGljaCBhcmUgbm90IGVtdWxhdGVkIGFuZA0KPj4+Pj4gaGF2ZSBu
byByZXNwZWN0aXZlIHZQQ0kgaGFuZGxlcnMsIHNvIGl0IGNhbiBhY2Nlc3MgdGhlIEhXIGRpcmVj
dGx5Lg0KPj4+PiBJIGRvbid0IHRoaW5rIHRoaXMgZGVzY3JpYmVzIHRoZSBwcmVzZW50IHNpdHVh
dGlvbi4gT3IgZGlkIEkgbWlzcyB3aGVyZQ0KPj4+PiBkZXZpY2VzIGNhbiBhY3R1YWxseSBiZSBl
eHBvc2VkIHRvIGd1ZXN0cyBhbHJlYWR5LCBkZXNwaXRlIG11Y2ggb2YgdGhlDQo+Pj4+IHN1cHBv
cnQgbG9naWMgc3RpbGwgbWlzc2luZz8NCj4+PiBObywgdGhleSBhcmUgbm90IGV4cG9zZWQgeWV0
IGFuZCB5b3Uga25vdyB0aGF0Lg0KPj4+IEkgd2lsbCB1cGRhdGUgdGhlIGNvbW1pdCBtZXNzYWdl
DQo+PiBCVFcsIGFsbCB0aGlzIHdvcmsgaXMgYWJvdXQgYWRkaW5nIHZwY2kgZm9yIGd1ZXN0cyBh
bmQgb2YgY291cnNlIHRoaXMNCj4+IGlzIG5vdCBnb2luZyB0byBiZSBlbmFibGVkIHJpZ2h0IGF3
YXkuDQo+PiBJIHdvdWxkIGxpa2UgdG8gaGVhciB0aGUgY29tbW9uIGFjY2VwdGFibGUgd2F5IG9m
IGRvY3VtZW50aW5nIHN1Y2gNCj4+IHRoaW5nczogZWl0aGVyIHdlIGp1c3Qgc2F5IHNvbWV0aGlu
ZyBsaWtlICJBIGd1ZXN0IGNhbiByZWFkIGFuZCB3cml0ZSINCj4+IGVsc2V3aGVyZSBvciB3ZSBu
ZWVkIHRvIGludmVudCBzb21ldGhpbmcgbmV1dHJhbCBub3QgZGlyZWN0bHkgbWVudGlvbmluZw0K
Pj4gd2hhdCB0aGUgY2hhbmdlIGRvZXMuIFdpdGggdGhlIGxhdGVyIGl0IGFsbCBzZWVtcyBhIGJp
dCBjb25mdXNpbmcgSU1PDQo+PiBhcyB3ZSBkbyBrbm93IHdoYXQgd2UgYXJlIGRvaW5nIGFuZCBm
b3Igd2hhdCByZWFzb246IGVuYWJsZSB2cGNpIGZvciBndWVzdHMNCj4gV2hhdCdzIHRoZSBwcm9i
bGVtIHdpdGggZGVzY3JpYmluZyB0aGluZ3MgYXMgdGhleSBhcmU/IENvZGUgaXMgaHdkb20tDQo+
IG9ubHkgcmlnaHQgbm93LCBhbmQgeW91J3JlIHRyeWluZyB0byBlbmFibGUgRG9tVSBzdXBwb3J0
LiBIZW5jZSBpdCdzDQo+IGFsbCBhYm91dCAid291bGQgYmUgYWJsZSB0byIsIG5vdCAiY2FuIi4N
ClNvdW5kcyBnb29kLCB3aWxsIHVzZSB0aGF0IHdvcmRpbmcgdGhlbg0KPg0KPiBKYW4NCj4NCj4N
ClRoYW5rIHlvdSwNCk9sZWtzYW5kcg==


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 09:10:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 09:10:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267793.461544 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHMWU-00018I-DW; Tue, 08 Feb 2022 09:10:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267793.461544; Tue, 08 Feb 2022 09:10:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHMWU-00018B-AN; Tue, 08 Feb 2022 09:10:54 +0000
Received: by outflank-mailman (input) for mailman id 267793;
 Tue, 08 Feb 2022 09:10:52 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1FiY=SX=epam.com=prvs=40383cc40e=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nHMWS-00017y-Kx
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 09:10:52 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 02af1f08-88bf-11ec-8f75-fffcc8bd4f1a;
 Tue, 08 Feb 2022 10:10:51 +0100 (CET)
Received: from pps.filterd (m0174682.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 2187rWRw012539;
 Tue, 8 Feb 2022 09:10:46 GMT
Received: from eur03-db5-obe.outbound.protection.outlook.com
 (mail-db5eur03lp2058.outbound.protection.outlook.com [104.47.10.58])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3e3mh50bpy-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Tue, 08 Feb 2022 09:10:46 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM0PR03MB3874.eurprd03.prod.outlook.com (2603:10a6:208:6c::25)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Tue, 8 Feb
 2022 09:10:41 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77%3]) with mapi id 15.20.4951.019; Tue, 8 Feb 2022
 09:10:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 02af1f08-88bf-11ec-8f75-fffcc8bd4f1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Dnz2Hv5qhzHyF59BRJkL2iOB6X5q1PkWrr6Tt8JdxNT739CcPz/imTkUwV6g34SovDWdxfPMdi/zIwjeevWllPyTch0Fh7Gx1BNlFXOTuR0BhrG0PpH9YdcTu1Yyp32HXgtTtANCauf20q5IYuejhIpOU8FXveSr3Q1tzb0dQNewEc+/52GAWDYPoHuJW584N6TY/jrxF2w59Mi8xccPIsLbWqkiEs5HlIfLqcT09VzBwAcrX/SCzOxjOwmo0iX/mRDqNWRrv6VdRuJ0gwHmEO5A6xVWliiJzBsaeOlbPyRDmEuqwv+oq2JKp4NOBrx/MLLWoIrGzh5UMgutmQUq/w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=y4XEPiWN+H2PZLedGwfVkcaFefhabpP2eMao3uFr41Q=;
 b=JGl/St+P9oQ050XqwootRZ0pXPVJClrUXrNGlaoFx4TH1zeRfZhCsz4xNB6FFtnCBw/n1wWoQi+vwEYldgPv6IKK/hQYyWh3hsT4IVkvMbuT0Bw6t80H9Sp4LEnKJ+WXATzY3foYYsrXCSIx9zCplJU0O2q4JErrPZSXyml1OTAAexfxp5S9XcPQrdOgxNQFzrJEfyzkazpiBQBM17Xzed9T1KCYOwSlH1YFRExzRe8Ihef0xdr2A/mO15LODgE02xmRqJKDAS0IkZSVnE9yJ1bSam8RwNXzle/tErTHSQBW2X3jRDNykRXLxpmtTDjbT/YCNBL3DFJzKreooxFiGg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=y4XEPiWN+H2PZLedGwfVkcaFefhabpP2eMao3uFr41Q=;
 b=mQVp81ECWe5nlw5FcdMpt7qA4PqUJhp9RnrAhSzwmd4v9AYTTDBBIYu6pPpAMUSp09k/VM8jshPRtZq9fpUJ44djqRHBSox9n79A/KRAToHGsl3V15zBxwooUvsOeoOPlS8Yn06lthsLxwreLcKJMKHpLl7Ol+YL3fp0yx9GY6dhzErGTsehbkT71PQm/0zXw1NzhrnhycIkG0nF71Gqeh/8kWJmnoQ889BfHPbA6N4+jiRdBzPL+23cvxaAuKoNjaTzfLBhZZJPk0Bc4xmlb8MmYXhw03w3a+kuX3+AJ70LSU+MXSsebMqut6lJZgKRX4oQJwLEcwpKRr8JB9aN1Q==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: Jan Beulich <jbeulich@suse.com>, "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org" <sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v6 04/13] vpci: restrict unhandled read/write operations
 for guests
Thread-Topic: [PATCH v6 04/13] vpci: restrict unhandled read/write operations
 for guests
Thread-Index: AQHYGZFbf8/6pUr0mUKzbmboCx8QkqyDbvWAgAADnYCABd4pgIAAEimAgAABdQA=
Date: Tue, 8 Feb 2022 09:10:41 +0000
Message-ID: <8b9c2bf3-f55b-ec94-9581-551c482c5899@epam.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-5-andr2000@gmail.com>
 <b6f091ed-4fa3-e292-9a21-a780ec90ee09@suse.com>
 <f86a43af-1388-6959-3e71-ba796e4a0c63@epam.com>
 <5a87c401-4ebd-1d5c-b98d-1b535f63be65@epam.com>
 <YgIyV9iboIxVrCS3@Air-de-Roger>
In-Reply-To: <YgIyV9iboIxVrCS3@Air-de-Roger>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: f04ee07e-7786-428e-b515-08d9eae2e136
x-ms-traffictypediagnostic: AM0PR03MB3874:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM0PR03MB3874A2DAB238351E31875E6BE72D9@AM0PR03MB3874.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 FAEykMhLU9H9tg6GdfsjKlsZlAJk82+dzBKRbjr4u2LXAwPpF4O7KKq4LfoYmQdmyLALNKnDoyNkHu47ehcdj/FbuIhfH/aBU0ItxuRI4EqJa4VCrtbiu6pX9Zwvz9k3qX3HyhO0jSNLd4UcQumWQlnpKEkBUe115jukuiXLdL+VPvZWCC+4kc7poJtNJE+ZitbQEyHXfnjkUsLkRsalXpnSRem4wypV0l/lRFmahGzm6ke4VPoi6jdbQlqvmdbkzEvsLYeZaww/X9Cknz/44GAq8oeVYcmZ2UxoxsZe55FZfcgw50IAwYR0jxBZu3BlDHD4J+sIip6wceoQqt1CWVx/GYmZxsg2U/JX/w2Q2XdZ1Yw55W8KNQRGxSNUO4+6w+TwT/upFuYAhMeoDhzcMjF9VymEp8P3qeyqRbG0ZNnvwJdjTakPKxArfvtZF+VcfH/BW4Y+QcM7ELetcGTEpgv6r2q1PfQK5cx0oKefD+mbFmbkCOmopxT7IZF0I/VbKjI2IaEHnaj8AANu4Q8qU1Xy6zSnj8sraKHf/YQ5Do8UAZGWWfgBhXRMbFfYVT0mfc4kOsSf1Ic43Xm3I7lYFBnZE9gVaK4BiTWNqdVrBVvZ93W0AaNaHo7Qgl/b2A7rGiups8aDO5Jc6x2bMBXTxlYMymMWEkgRiVFUYRH4N5v2+5kQlOJJzU/xN2x1lYSyf4VFKrdtlssmne/Yu0chH6RXKCMQwJszTRNwNlGw8KpJEl1aN47sqhEoKy2udP01
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(36756003)(53546011)(5660300002)(55236004)(7416002)(6506007)(26005)(2616005)(186003)(6512007)(38070700005)(8936002)(31686004)(2906002)(83380400001)(66946007)(508600001)(71200400001)(91956017)(66446008)(76116006)(31696002)(54906003)(316002)(38100700002)(107886003)(6916009)(4326008)(122000001)(8676002)(66556008)(66476007)(64756008)(6486002)(86362001)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?Sm82OXNPbU9PaEpoMkpBREU4VEtxZU1abjBJWlBWUnpxVXkzODRtajcra0xM?=
 =?utf-8?B?WllXWit0TGhCVkRrUGFLSFk2N2VyNzVvb2RDSVh1dzRxcmlENGhGM0RTb0NK?=
 =?utf-8?B?My96ME5UMlhCNUc2TjlNbkFzSnZpVXAyUldEeWZuNW4rdDVoOFRFWjBkcmVn?=
 =?utf-8?B?RTVVTmY5alNEZ0J3OTdhbngvWkFhTXAvM00xNU01RkVTMldPRk10STFETWtM?=
 =?utf-8?B?N0VCRy81cTF0eDgvRE1wYjNDVjR2aVdnRXRSYTBxVUtoS2FFejdmVTcyekdN?=
 =?utf-8?B?YUo5dzRaQ01hcFFoSXpFTnVEWTFDWTAxSVVjN1R0NWNqM094ZG5KWWcyQ2xa?=
 =?utf-8?B?OGNHSFJxVVBBT29jZkNUTG5ka0xRd0JBUGw1aGZ0M1ZxZDh3ejJoSTdyU3NS?=
 =?utf-8?B?dnZzQUx4WjNxQmhuWGhnMFhnT1o3ODNCd2dDL204aHBtSzBZbVdLelV3WkJm?=
 =?utf-8?B?enFDKzdUd2txbGlDSW53eFhkNm9KWW9SYmZnbGFBdWVjaTY1VXhFb3ZvOHIx?=
 =?utf-8?B?OFpEOWZtWThqU1UweTgrRUFDMHUwZUtHNGhwZW1OSWN3U2ZPZHRRSUZ1eDNT?=
 =?utf-8?B?ZGhwRVdWK3djeXJlMXRLVTZXRXJrbEtXUEk2VWpCQU9YTHFaY25VdHRuU2xN?=
 =?utf-8?B?VHB3QU13UDBrc0dUV08yMlFYS1Z3VytpYytYZDl5Wnl3cGpZOVBNd1NFVXNx?=
 =?utf-8?B?djZaK2FOb2JCQXNQYUNlVVA3ZXFzd0R5WWhNaExETElQY0E5Q3JIQ3E0Y1J4?=
 =?utf-8?B?c2M4eWdQNW95QU1DaWRwakJJdEZCdVJWZ2tVLzc5VnBwSm5KUDJLVVJodEdo?=
 =?utf-8?B?TnNBNjNlVkVJS21BQjVOY3YxdHZnV3dMUTVGRXRXVzJWU2RtcTNjTGFtTWxQ?=
 =?utf-8?B?RVdEbFpuMnJUendMY1NsUHlibmpBVkVWVkJSSm1UR1U0cmxYRkNCRGYrWHRE?=
 =?utf-8?B?T2FwTlg4VkdLeElVQXZOYnV5UTJYQVpqS2x0RnFZVXdvdVNTVS92ZXdDK0xO?=
 =?utf-8?B?bS9YT0xka3pDZkN5K05UNGhER3JtQmVyclRRT1Z6bEVqV3I0OVRBam4wNkg5?=
 =?utf-8?B?eHNGNHdKYXJ2b3kvRUpmQWEwa2RZYnczclFBWlNLT25ENkRSVVE3ekplRW1Q?=
 =?utf-8?B?clJJbVZBdDdocExUM20vU2FLM1FjbTEwNktsYnNmM2tHRGlVOTdGcTI5NGtR?=
 =?utf-8?B?UmpDYURnanBKU0FRVEE0amNrNzkvS3J2YlVKV0pQdiswN25IeUYrUDV0aVVN?=
 =?utf-8?B?emdsNVRXdngvOHFmYWYvVDZGRXBwR0JJQUFGVDY2WDdvNHB4Z0VHRnY4UzFr?=
 =?utf-8?B?eEtIbk1WUkhnS1M4MlRrWW5UYmtMSm14aUp6Tjh5Ty9mWDZXaEl4UzZrclJV?=
 =?utf-8?B?UFNYVW5zQ0pJdWFTREI4ZE85NHJSZStZU2RsaS9YZXE4TlBCTCt0ZXpNQlJG?=
 =?utf-8?B?OUd3d3NxK3hYOUs3UlRjU1ZCbVhBMzdudlZmME5LUG8zekZ4bVJoSWVwYm53?=
 =?utf-8?B?MnphV0tSUUlqazZDTEJOTWE0ak1MWGtndUlSMUwxUUNFckdYTDlsZi9IcWdq?=
 =?utf-8?B?TTNNbkI5eWZUZDZnbVlyS1Uzakp6YldHSys3WE96N1kxYklSdmFBZ2VUVnJj?=
 =?utf-8?B?MGNydVoxMHduTFdnR01URGdwR08wM2RhRWF0cTdkM3NkZkh5alpsOHczUFl3?=
 =?utf-8?B?dkdIYTMwSm45RFBjcVF1Mk01VkZxUkV2YzZrOE1sQ2Nob09CdWt4Q1Z2U0x1?=
 =?utf-8?B?MmJ5WWYzNE9ZQVZXQWx0TytGWk1JSGw2M1g0U0pBeWNEODFzcEYyYWxkWTc2?=
 =?utf-8?B?c1hHQ3VIWnk4a2FoR3h1ZFEzSE1lNjBud1Bxbmo4K2ZyQmkvSnhMZW5GZDR4?=
 =?utf-8?B?dGl3Nnp4WUJLWWpqZjJnQWlIeG9JYWdZYjliNFE0Uit1ZERjN3VhUVR3Mjkw?=
 =?utf-8?B?Q3dUakNZWFFuSjB3R0NWd3ozUllvNTI3V2hrRTZFa0Y2TWlCSmk2Vm83MExm?=
 =?utf-8?B?RFJLcE12SnRtS0pob3lHZ2NZUENQSnQzNDN5V05PSEpJMFVSblFNZDBBTVFh?=
 =?utf-8?B?QjlpOVVuYWFreVMyNHFRaSs2eE1FTDZTMTQzdmxXNmUzaVgrNEVKaTF6by85?=
 =?utf-8?B?WjJoZDk5Q1Z3K1RGODU3U05hSzJrUXZFSlpPaUwyRTJBdm9rak0wQjVHaGQz?=
 =?utf-8?B?TTlDNWZSSmZzYk1pM09BNElnbXRTYjQ1c2hqU1J6NjZrS3IzZC9wakFnTGNn?=
 =?utf-8?B?RmFxeFVBemUybW9UaFZyMm1sNVF0SlR4TkRqY092ZEFCMkxueS9MaVNSQVEz?=
 =?utf-8?B?bnJEUGFPaWdzNWhWSzFwZ3k5d3pldHpnb3pZSHFQaEtXaEhrQU9UMHRTbzVw?=
 =?utf-8?Q?+fzdXc6gzZpMlMRc=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <B04ED0FA3AD60549BADAF9EF7289C838@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f04ee07e-7786-428e-b515-08d9eae2e136
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2022 09:10:41.0665
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: mR+PwMSgSX4VjWW19F6JQbduH09qFNQr4Uy6pHV+pfpFO6NslKvwBEk+oMADKsgAPRVyNEOs6Om0DRK4hWFbMstmyJbAYTqyur5vT6KvC/w6n9C6OBTlwbb0KGDmaS0M
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB3874
X-Proofpoint-ORIG-GUID: t6Bn3eJwRzrOgrjIv8PqmgZryVNnbzHA
X-Proofpoint-GUID: t6Bn3eJwRzrOgrjIv8PqmgZryVNnbzHA
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-08_02,2022-02-07_02,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 lowpriorityscore=0
 suspectscore=0 bulkscore=0 malwarescore=0 clxscore=1015 phishscore=0
 spamscore=0 impostorscore=0 adultscore=0 mlxlogscore=999
 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202080052

DQoNCk9uIDA4LjAyLjIyIDExOjA1LCBSb2dlciBQYXUgTW9ubsOpIHdyb3RlOg0KPiBPbiBUdWUs
IEZlYiAwOCwgMjAyMiBhdCAwODowMDoyOEFNICswMDAwLCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5r
byB3cm90ZToNCj4+IE9uIDA0LjAyLjIyIDE2OjI0LCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyB3
cm90ZToNCj4+PiBPbiAwNC4wMi4yMiAxNjoxMSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+Pj4+IE9u
IDA0LjAyLjIwMjIgMDc6MzQsIE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4+Pj4g
QSBndWVzdCBjYW4gcmVhZCBhbmQgd3JpdGUgdGhvc2UgcmVnaXN0ZXJzIHdoaWNoIGFyZSBub3Qg
ZW11bGF0ZWQgYW5kDQo+Pj4+PiBoYXZlIG5vIHJlc3BlY3RpdmUgdlBDSSBoYW5kbGVycywgc28g
aXQgY2FuIGFjY2VzcyB0aGUgSFcgZGlyZWN0bHkuDQo+Pj4+IEkgZG9uJ3QgdGhpbmsgdGhpcyBk
ZXNjcmliZXMgdGhlIHByZXNlbnQgc2l0dWF0aW9uLiBPciBkaWQgSSBtaXNzIHdoZXJlDQo+Pj4+
IGRldmljZXMgY2FuIGFjdHVhbGx5IGJlIGV4cG9zZWQgdG8gZ3Vlc3RzIGFscmVhZHksIGRlc3Bp
dGUgbXVjaCBvZiB0aGUNCj4+Pj4gc3VwcG9ydCBsb2dpYyBzdGlsbCBtaXNzaW5nPw0KPj4+IE5v
LCB0aGV5IGFyZSBub3QgZXhwb3NlZCB5ZXQgYW5kIHlvdSBrbm93IHRoYXQuDQo+Pj4gSSB3aWxs
IHVwZGF0ZSB0aGUgY29tbWl0IG1lc3NhZ2UNCj4+IEJUVywgYWxsIHRoaXMgd29yayBpcyBhYm91
dCBhZGRpbmcgdnBjaSBmb3IgZ3Vlc3RzIGFuZCBvZiBjb3Vyc2UgdGhpcw0KPj4gaXMgbm90IGdv
aW5nIHRvIGJlIGVuYWJsZWQgcmlnaHQgYXdheS4NCj4+IEkgd291bGQgbGlrZSB0byBoZWFyIHRo
ZSBjb21tb24gYWNjZXB0YWJsZSB3YXkgb2YgZG9jdW1lbnRpbmcgc3VjaA0KPj4gdGhpbmdzOiBl
aXRoZXIgd2UganVzdCBzYXkgc29tZXRoaW5nIGxpa2UgIkEgZ3Vlc3QgY2FuIHJlYWQgYW5kIHdy
aXRlIg0KPj4gZWxzZXdoZXJlIG9yIHdlIG5lZWQgdG8gaW52ZW50IHNvbWV0aGluZyBuZXV0cmFs
IG5vdCBkaXJlY3RseSBtZW50aW9uaW5nDQo+PiB3aGF0IHRoZSBjaGFuZ2UgZG9lcy4gV2l0aCB0
aGUgbGF0ZXIgaXQgYWxsIHNlZW1zIGEgYml0IGNvbmZ1c2luZyBJTU8NCj4+IGFzIHdlIGRvIGtu
b3cgd2hhdCB3ZSBhcmUgZG9pbmcgYW5kIGZvciB3aGF0IHJlYXNvbjogZW5hYmxlIHZwY2kgZm9y
IGd1ZXN0cw0KPj4+Pj4gSW4gb3JkZXIgdG8gcHJldmVudCBhIGd1ZXN0IGZyb20gcmVhZHMgYW5k
IHdyaXRlcyBmcm9tL3RvIHRoZSB1bmhhbmRsZWQNCj4+Pj4+IHJlZ2lzdGVycyBtYWtlIHN1cmUg
b25seSBoYXJkd2FyZSBkb21haW4gY2FuIGFjY2VzcyBIVyBkaXJlY3RseSBhbmQgcmVzdHJpY3QN
Cj4+Pj4+IGd1ZXN0cyBmcm9tIGRvaW5nIHNvLg0KPj4+PiBUYW5nZW50aWFsIHF1ZXN0aW9uOiBH
b2luZyBvdmVyIHRoZSB0aXRsZXMgb2YgdGhlIHJlbWFpbmluZyBwYXRjaGVzIEkNCj4+Pj4gbm90
aWNlIHBhdGNoIDYgaXMgZ29pbmcgdG8gZGVhbCB3aXRoIEJBUiBhY2Nlc3Nlcy4gQnV0IChnb2lu
ZyBqdXN0DQo+Pj4+IGZyb20gdGhlIHRpdGxlcykgSSBjYW4ndCBzcG90IGFueXdoZXJlIHRoYXQg
dmVuZG9yIGFuZCBkZXZpY2UgSURzDQo+Pj4+IHdvdWxkIGJlIGV4cG9zZWQgdG8gZ3Vlc3RzLiBZ
ZXQgdGhhdCdzIHRoZSBmaXJzdCB0aGluZyBndWVzdHMgd2lsbCBuZWVkDQo+Pj4+IGluIG9yZGVy
IHRvIGFjdHVhbGx5IHJlY29nbml6ZSBkZXZpY2VzLiBBcyBzYWlkIGJlZm9yZSwgYWxsb3dpbmcg
Z3Vlc3RzDQo+Pj4+IGFjY2VzcyB0byBzdWNoIHIvbyBmaWVsZHMgaXMgcXVpdGUgbGlrZWx5IGdv
aW5nIHRvIGJlIGZpbmUuDQo+Pj4gQWdyZWUsIEkgd2FzIHRoaW5raW5nIGFib3V0IGFkZGluZyBz
dWNoIGEgcGF0Y2ggdG8gYWxsb3cgSURzLA0KPj4+IGJ1dCBmaW5hbGx5IGRlY2lkZWQgbm90IHRv
IGFkZCBtb3JlIHRvIHRoaXMgc2VyaWVzLg0KPj4+IEFnYWluLCB0aGUgd2hvbGUgdGhpbmcgaXMg
bm90IHdvcmtpbmcgeWV0IGFuZCBmb3IgdGhlIGRldmVsb3BtZW50DQo+Pj4gdGhpcyBwYXRjaCBj
YW4vbmVlZHMgdG8gYmUgcmV2ZXJ0ZWQuIFNvLCBlaXRoZXIgd2UgaW1wbGVtZW50IElEcw0KPj4+
IG9yIG5vdCB0aGlzIGRvZXNuJ3QgY2hhbmdlIGFueXRoaW5nIHdpdGggdGhpcyByZXNwZWN0DQo+
PiBSb2dlciwgZG8geW91IHdhbnQgYW4gYWRkaXRpb25hbCBwYXRjaCB3aXRoIElEcyBpbiB2Nz8N
Cj4gSSB3b3VsZCBleHBlY3QgYSBsb3QgbW9yZSB3b3JrIHRvIGJlIHJlcXVpcmVkLCB5b3UgbmVl
ZCBJRHMgYW5kIHRoZQ0KPiBIZWFkZXIgdHlwZSBhcyBhIG1pbmltdW0gSSB3b3VsZCBzYXkuIEFu
ZCB0aGVuIGluIG9yZGVyIHRvIGhhdmUNCj4gc29tZXRoaW5nIGZ1bmN0aW9uYWwgeW91IHdpbGwg
YWxzbyBuZWVkIHRvIGhhbmRsZSB0aGUgY2FwYWJpbGl0aWVzDQo+IHBvaW50ZXIuDQo+DQo+IEkn
bSBmaW5lIGZvciB0aGlzIHRvIGJlIGFkZGVkIGluIGEgZm9sbG93dXAgc2VyaWVzLiBJIHRoaW5r
IGl0J3MgY2xlYXINCj4gdGhlIHN0YXR1cyBhZnRlciB0aGlzIHNlcmllcyBpcyBub3QgZ29pbmcg
dG8gYmUgZnVuY3Rpb25hbC4NCk9rLCBzbyBsZXQncyBmaXJzdCBoYXZlIHNvbWV0aGluZyBhbmQg
dGhlbiB3ZSBjYW4gZXh0ZW5kIGd1ZXN0J3Mgc3VwcG9ydA0KVGhpcyBjYW4gZ28gaW4gcGFyYWxs
ZWwgd2l0aCBvdGhlciB3b3JrIG9uIEFybSB3aGljaCBzdGlsbCB3YWl0cw0KZm9yIHRoaXMgc2Vy
aWVzIHRvIGJlIGFjY2VwdGVkDQo+DQo+Pj4+PiAtLS0gYS94ZW4vZHJpdmVycy92cGNpL3ZwY2ku
Yw0KPj4+Pj4gKysrIGIveGVuL2RyaXZlcnMvdnBjaS92cGNpLmMNCj4+Pj4+IEBAIC0yMTUsMTEg
KzIxNSwxNSBAQCBpbnQgdnBjaV9yZW1vdmVfcmVnaXN0ZXIoc3RydWN0IHZwY2kgKnZwY2ksIHVu
c2lnbmVkIGludCBvZmZzZXQsDQo+Pj4+PiAgICAgfQ0KPj4+Pj4gICAgIA0KPj4+Pj4gICAgIC8q
IFdyYXBwZXJzIGZvciBwZXJmb3JtaW5nIHJlYWRzL3dyaXRlcyB0byB0aGUgdW5kZXJseWluZyBo
YXJkd2FyZS4gKi8NCj4+Pj4+IC1zdGF0aWMgdWludDMyX3QgdnBjaV9yZWFkX2h3KHBjaV9zYmRm
X3Qgc2JkZiwgdW5zaWduZWQgaW50IHJlZywNCj4+Pj4+ICtzdGF0aWMgdWludDMyX3QgdnBjaV9y
ZWFkX2h3KGJvb2wgaXNfaHdkb20sIHBjaV9zYmRmX3Qgc2JkZiwgdW5zaWduZWQgaW50IHJlZywN
Cj4+Pj4+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGludCBzaXpl
KQ0KPj4+PiBXYXMgdGhlIHBhc3NpbmcgYXJvdW5kIG9mIGEgYm9vbGVhbiB0aGUgY29uc2Vuc3Vz
IHdoaWNoIHdhcyByZWFjaGVkPw0KPj4+IFdhcyB0aGlzIHBhdGNoIGNvbW1pdHRlZCB5ZXQ/DQo+
Pj4+IFBlcnNvbmFsbHkgSSdkIGZpbmUgaXQgbW9yZSBuYXR1cmFsIGlmIHRoZSB0d28gZnVuY3Rp
b25zIGNoZWNrZWQNCj4+Pj4gY3VycmVudC0+ZG9tYWluIHRoZW1zZWx2ZXMuDQo+Pj4gVGhpcyBp
cyBhbHNvIHBvc3NpYmxlLCBidXQgSSB3b3VsZCBsaWtlIHRvIGhlYXIgUm9nZXIncyB2aWV3IG9u
IHRoaXMgYXMgd2VsbA0KPj4+IEkgYW0gZmluZSBlaXRoZXIgd2F5DQo+PiBSb2dlciwgd2hhdCdz
IHlvdXIgbWFpbnRhaW5lcidzIHByZWZlcmVuY2UgaGVyZT8gQWRkaXRpb25hbCBhcmd1bWVudA0K
Pj4gdG8gdnBjaV9yZWFkX2h3IG9mIG1ha2UgaXQgdXNlIGN1cnJlbnQtPmRvbWFpbiBpbnRlcm5h
bGx5Pw0KPiBNeSByZWNvbW1lbmRhdGlvbiB3b3VsZCBiZSB0byB1c2UgY3VycmVudC0+ZG9tYWlu
LiBIYW5kbGVycyB3aWxsDQo+IGFsd2F5cyBiZSBleGVjdXRlZCBpbiBndWVzdCBjb250ZXh0LCBz
byB0aGVyZSdzIG5vIG5lZWQgdG8gcGFzcyBhDQo+IHBhcmFtZXRlciBhcm91bmQuDQpvaywgSSds
bCB1c2UgY3VycmVudC0+ZG9tYWluDQo+DQo+IFRoYW5rcywgUm9nZXIuDQo+DQpUaGFuayB5b3Us
DQpPbGVrc2FuZHI=


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 09:13:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 09:13:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267804.461555 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHMYr-0001qj-Ub; Tue, 08 Feb 2022 09:13:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267804.461555; Tue, 08 Feb 2022 09:13:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHMYr-0001qc-Qk; Tue, 08 Feb 2022 09:13:21 +0000
Received: by outflank-mailman (input) for mailman id 267804;
 Tue, 08 Feb 2022 09:13:21 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=v7zX=SX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nHMYq-0001qV-VR
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 09:13:20 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5b6c7229-88bf-11ec-8eb8-a37418f5ba1a;
 Tue, 08 Feb 2022 10:13:19 +0100 (CET)
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2058.outbound.protection.outlook.com [104.47.2.58]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-27-BjCCoX7BMQWl_RCAg2HGOw-1; Tue, 08 Feb 2022 10:13:18 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by HE1PR0401MB2603.eurprd04.prod.outlook.com (2603:10a6:3:7f::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Tue, 8 Feb
 2022 09:13:15 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.018; Tue, 8 Feb 2022
 09:13:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5b6c7229-88bf-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644311599;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=t8F7/gOjZAQoZtPJPDkVTRgvlJaJU2RInZ/UBusARmo=;
	b=Dq0nleNIz4h+iwbZPSq2IZnyR7CbEl1Erpb5UIouAYudpT9BsuJNULUufYmTLP6ArXnOY7
	HdfG8tkF489EPSyL+jdedlZ+sDUeqkRynJKiASZg0k0fc794ltByzpXWGZ1Oipcv2iuYrX
	w5zTgSX3gNSR6TtCXL5UtN67zhPORpI=
X-MC-Unique: BjCCoX7BMQWl_RCAg2HGOw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=lVDm8f7zE55wNEJq3qXZ5WmOn4/mDBmOLErANAG00zrkGxC2it9Gpcj+XkSuRwQ/+I4yMwjI0jCz/pa9cSjidtbEoTZynxP2ON6VTSKC/CotMF37NhXDztZtUwxCnw4U+AvHmgYkVdlmb+/acPYKtbzWZmKyfir3Q77fDBLFGSsc+ye2meRcm+8057vTBy77T/QpO38D0c8WmK4PeLxhdn+Ppjvj8ZD4fcmjAOQo9aELTLxf2dxxasaoMQ3aTMIDwFnSv6rKZqbF5bRmT7edCdWhBf5DtWDzDTuQfcEr7AZityJXRBB2TLfvLjn5iKiYen1ytBQz1bJbx1JUJChW6Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=YZhkuTvk2s3fwfIlWlZJaCohiqBwMd3YeNsSCtrQL3c=;
 b=Vu8zKc36TgAkfSf2mcYWbxEwpMN0YbtS0LoG0mnsx2MZ7SJQ5rSCDGDOgK6QGavIG+BCIqO7kAifqd/VdrWhs8mT+G4if5zvMMiyvVo/tvy8OUgeYjII2d5CsEwF3sElJ0MpSdN55DJHkwyO5WIL1vIVpBYFVMFNr4DaatMVhsjSN1wt6VBZ7EYmoBX3XIL1wxVy0ohMtgc+lRwMcvB2skQ4OPUalBoYe9ioAbGGSZA396JMky7Q9dQoArDn15D9xd6DUf0lCO8/d1KayCPnreNwthwSJbLlzR90FY36g9xfAXs9B7RxW/KG5qE3sxfJfkVybE+w46wK17F6DAllSg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <582ee8f9-7b01-4adc-6a8a-ce8b1dffd534@suse.com>
Date: Tue, 8 Feb 2022 10:13:12 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v6 05/13] vpci: add hooks for PCI device assign/de-assign
Content-Language: en-US
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: "julien@xen.org" <julien@xen.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Artem Mygaiev <Artem_Mygaiev@epam.com>,
 "roger.pau@citrix.com" <roger.pau@citrix.com>,
 "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
 "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
 "paul@xen.org" <paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-6-andr2000@gmail.com>
 <16cea1df-3d0f-d404-2b88-aab47ad5548b@suse.com>
 <3fe6dbe3-51c6-f87f-23f9-cf2e1a924326@epam.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <3fe6dbe3-51c6-f87f-23f9-cf2e1a924326@epam.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9P194CA0009.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:20b:46d::19) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 8d30bbd8-8cac-4731-6d7c-08d9eae33ca6
X-MS-TrafficTypeDiagnostic: HE1PR0401MB2603:EE_
X-Microsoft-Antispam-PRVS:
	<HE1PR0401MB26039A56CE9642499E956579B32D9@HE1PR0401MB2603.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Z81AxXIi2wJ62/u6BGWAxB52iRu3NUfPVHJATWQQxl5nV/naePAYitQwi7VKskWa5ZWQ+gvk1zS81Yu25fMe/Xi2fL2nTVHRIr4vF9apSGfmeGkxODnjVrR5vpbHAwf7cnliFAdsgMDZSsUAc8tRgubmm2UgzUq+dNeqo6HpcpZ4gF2EX/7TlO/ylYwBkdAeNyo314M/4UJT3sG8h4caqnDmwMRdnlPJ03PqwjUcO/EsaNLjNlDtqevr/oQwKwkwHT4pXMvqKEgiXAARPmQhETruwHGhfdj9e+KkiwtWE6W9n52Do1UnmNDYy4A8mnLUB6n782xXKdzEEpRXsMlKKZzbBEsCmsDaAo57YVHNLsTJNrcbV5dTncnjQ4iqO+M27mJMNlHKNpXG/Ayw63EOI+OI5g0lFa972MbyWNT+YKH61Sq+mIJOn809pvd4A0UYd7aTMCUZ/RvVUo1v4phV/YYss+Xn8oldaq/9oDVOzgxWvXlO2jti6obrYuVdJ9mQV7Y9xOS9De5bBNisa21YIEvJkO7HaieumpjeTIrvbwjuwCMEN6MDoY0vu+5KnJ3JnWhvWqcr52mVhbm0hi4FX9B1FQi7BUOq8ERcWXv/cuBQ3RRhGRf04L6oij+nHU4PwD+Nz0VNK9aNeETs9hlm/oFECHjqtGXu4muInvgvbCWJXe8yfsLLI7+bkVZTDbaICUqGRKO/FHe2OjyxqmXudKkwRk9bMm6Atr0HhwQ9dCw=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2616005)(4326008)(8936002)(66556008)(83380400001)(66476007)(31686004)(36756003)(508600001)(8676002)(6486002)(26005)(66946007)(86362001)(31696002)(53546011)(6512007)(5660300002)(38100700002)(6506007)(186003)(54906003)(6916009)(2906002)(7416002)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?4PAX8/gnif31izUV6TIw7t7bEy7bqw50yjwUOgAuzWq5Cb1PFFIHXUw/XY6N?=
 =?us-ascii?Q?dlBOHXPbkAoA9VQAYSAPq/fVpbuc4fENK5yafdCGGOjDBO3SnrrxwmuqkTP4?=
 =?us-ascii?Q?LjtGsMu92rkx5cZLJ89jGkBECrvZXJ41wFLUw36V1AJtQ1O/A0wKcFW6SEDq?=
 =?us-ascii?Q?nmhcFD69MRgVrdx4jPbE7I4cb27LloSaIMr+ZRo4+RjJyyWMvb/UM+Cb5OpM?=
 =?us-ascii?Q?hlv4mdZ8WpnjvUiCMChYzkfI5X0dbATfi2tTJQSkNY9NT8+d+mP7HkGbPdzg?=
 =?us-ascii?Q?K6ny0dvpOO7UVHajBzzfUZcVrnwJehT2zCoZtrMpV0lupnM2KDK19OiuLSP7?=
 =?us-ascii?Q?iBqMZJOeUPBlCpapDhHpLlZEKbMYaLVGvzQoXsQYAkIkSvAE0NRjDlvw/6EW?=
 =?us-ascii?Q?Reqq4DfkLuWZ+dfaXvlUsfwHIfl2xlhWj75nnlZDtKjOGyKCNDzAPZp2v1xq?=
 =?us-ascii?Q?8lTaO1XO2HI49RFIhlIoWwLhec3ys1ePmwTm2YQsxE4XXhU+SFidCjmwiNCF?=
 =?us-ascii?Q?s468gm02srW+MlajKmUSkp/lFiwhDPHYscaOvggYuJL7WL8KlcsxE2cWZ4ww?=
 =?us-ascii?Q?uSnBJIODRmjfzEjswMEMmHVESRkMaXnWCNUlgrI0Qani6Zf5IFb2Ncb15tgS?=
 =?us-ascii?Q?kZ17IxyNA2DKrNuttbXnTOOLNoqw/PpHFAKkynJb1VU8SfFJS+al0URT24bq?=
 =?us-ascii?Q?U6SaMlzN0HMNsZ1iRY9grX4/Vdadvyzgp34H6PSF7OIfB8y6BEyfgXH1uRgo?=
 =?us-ascii?Q?HUzE2y56RIxShAl0byA4jixqv9CqE3PyG4LgaUm7xPguM0wos/pdB+TpkH0D?=
 =?us-ascii?Q?eGiRbKJyarHlczxRThY+U/22Gfm5BzS6mQwih6pkA2ozSOW5qYpTtBIlEfOU?=
 =?us-ascii?Q?o1OYm1LnVVmfHvrpuVAhFb5VNx95zu7KY93fGuuJio5GHPPOhSVYQimI8Mbp?=
 =?us-ascii?Q?DowL75+1K18sScU9jfpbyF5xcFFfCdHvop1TBIGK4Gf0SVSTs2AZbf+iXFnM?=
 =?us-ascii?Q?S9OyT7EqFG/jvtYDMwC121nlcmsQW4QevjWZL5pZhlAgz69+oNIIpKVmgN9h?=
 =?us-ascii?Q?Awb+Oz85ewJ4B/FyPOY6tWq2r9luQnC2gVS5RYbmLLTB7EW8CaUo8riRBr4q?=
 =?us-ascii?Q?O20CbVQovfFSYZuHIrz2uV73BoonxJR6b/NWvnGJivWyx0tZLa0oLNPeebij?=
 =?us-ascii?Q?Qtssn0PH/4Ke62zkGPY/jYsls6tzU67cW9aeYKicc2snDvYh48U+kSGAynmT?=
 =?us-ascii?Q?L9l7k3nFBakggipEam/7ZSggLm0gV0uB+0n65ZO8Ch89CLyw2/GkFZc6ZgT8?=
 =?us-ascii?Q?pmSV4d5egOez66iY7a9fCGUUHXuZq0w2GFTY2HsYY+bfq4ADKJs+Ec3iOIkO?=
 =?us-ascii?Q?jDOnuqoWBBdm2nNvTgHvW5e44mpBbCc/tftJEljdw7A9Hg4LipU/tdrvgus3?=
 =?us-ascii?Q?2NNknP35235MUaO/yJbIE3XIRQ19j5SBgGQMQIpiS7F3THiQXlRFN5a8w1uJ?=
 =?us-ascii?Q?oEQSsglvxBnz3Ijod6vEWPMvJj6yW+levCPC8xfsYsIXp5ZzrHRbgwtuNdnO?=
 =?us-ascii?Q?7WHwwJsztGRKG0ptL4c3z3tFqITZnKTCbku2/QJJBBSyQDf2ce2PNcYPUYXo?=
 =?us-ascii?Q?CupkC+iRsP6znxLsWuBVfhQ=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8d30bbd8-8cac-4731-6d7c-08d9eae33ca6
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2022 09:13:14.7370
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iNeWbTCF3pGYFEK2FeE0tLSzP3jXqZ6i2xkCwYDKui3RRIsrnVpIRUioMMb6y8VCyVntZugHL2Ww5hgPdbWN+Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0401MB2603

On 08.02.2022 09:32, Oleksandr Andrushchenko wrote:
> On 07.02.22 18:28, Jan Beulich wrote:
>> On 04.02.2022 07:34, Oleksandr Andrushchenko wrote:
>>> @@ -1507,6 +1511,8 @@ static int assign_device(struct domain *d, u16 se=
g, u8 bus, u8 devfn, u32 flag)
>>>                           pci_to_dev(pdev), flag);
>>>       }
>>>  =20
>>> +    rc =3D vpci_assign_device(d, pdev);
>>> +
>>>    done:
>>>       if ( rc )
>>>           printk(XENLOG_G_WARNING "%pd: assign (%pp) failed (%d)\n",
>> There's no attempt to undo anything in the case of getting back an
>> error. ISTR this being deemed okay on the basis that the tool stack
>> would then take whatever action, but whatever it is that is supposed
>> to deal with errors here wants spelling out in the description.
> Why? I don't change the previously expected decision and implementation
> of the assign_device function: I use error paths as they were used before
> for the existing code. So, I see no clear reason to stress that the exist=
ing
> and new code relies on the toolstack

Saying half a sentence on this is helping review.

>> What's important is that no caller up the call tree may be left with
>> the impression that the device is still owned by the original
>> domain. With how you have it, the device is going to be owned by the
>> new domain, but not really usable.
> This is not true: vpci_assign_device will call vpci_deassign_device
> internally if it fails. So, the device won't be assigned in this case

No. The device is assigned to whatever pdev->domain holds. Calling
vpci_deassign_device() there merely makes sure that the device will
have _no_ vPCI data and hooks in place, rather than something
partial.

>>> --- a/xen/drivers/vpci/vpci.c
>>> +++ b/xen/drivers/vpci/vpci.c
>>> @@ -99,6 +99,33 @@ int vpci_add_handlers(struct pci_dev *pdev)
>>>  =20
>>>       return rc;
>>>   }
>>> +
>>> +#ifdef CONFIG_HAS_VPCI_GUEST_SUPPORT
>>> +/* Notify vPCI that device is assigned to guest. */
>>> +int vpci_assign_device(struct domain *d, struct pci_dev *pdev)
>>> +{
>>> +    int rc;
>>> +
>>> +    if ( !has_vpci(d) )
>>> +        return 0;
>>> +
>>> +    rc =3D vpci_add_handlers(pdev);
>>> +    if ( rc )
>>> +        vpci_deassign_device(d, pdev);
>>> +
>>> +    return rc;
>>> +}
>>> +
>>> +/* Notify vPCI that device is de-assigned from guest. */
>>> +void vpci_deassign_device(struct domain *d, struct pci_dev *pdev)
>>> +{
>>> +    if ( !has_vpci(d) )
>>> +        return;
>>> +
>>> +    vpci_remove_device(pdev);
>>> +}
>>> +#endif /* CONFIG_HAS_VPCI_GUEST_SUPPORT */
>> While for the latter function you look to need two parameters, do you
>> really need them also in the former one?
> Do you mean instead of passing d we could just use pdev->domain?
> int vpci_assign_device(struct pci_dev *pdev)
> +{
> +=C2=A0=C2=A0=C2=A0 int rc;
> +
> +=C2=A0=C2=A0=C2=A0 if ( !has_vpci(pdev->domain) )
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return 0;

Yes.

> Yes, we probably can, but the rest of functions called from assign_device
> are accepting both d and pdev, so not sure why would we want these
> two be any different. Any good reason not to change others as well then?

Yes: Prior to the call of the ->assign_device() hook, d !=3D pdev->domain.
It is the _purpose_ of this function to change ownership of the device.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Feb 08 09:17:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 09:17:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267814.461566 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHMcV-0002Uk-FC; Tue, 08 Feb 2022 09:17:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267814.461566; Tue, 08 Feb 2022 09:17:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHMcV-0002Ud-Bg; Tue, 08 Feb 2022 09:17:07 +0000
Received: by outflank-mailman (input) for mailman id 267814;
 Tue, 08 Feb 2022 09:17:06 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=v7zX=SX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nHMcU-0002UX-7e
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 09:17:06 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e1a17862-88bf-11ec-8f75-fffcc8bd4f1a;
 Tue, 08 Feb 2022 10:17:05 +0100 (CET)
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur02lp2052.outbound.protection.outlook.com [104.47.5.52]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-34-qgKohuLWPSKSfDSy0SZ3XQ-1; Tue, 08 Feb 2022 10:17:03 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0401MB2557.eurprd04.prod.outlook.com (2603:10a6:800:56::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Tue, 8 Feb
 2022 09:17:01 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.018; Tue, 8 Feb 2022
 09:17:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e1a17862-88bf-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644311824;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=jO5oujVGxYE8gCO9O1wJxedKAsnpNsZI1EHBIUKEpYU=;
	b=BVMoEN7NdFom2L1rlgx23wrWEGbTlPggeD7S1tky4GgM/4gGsl1dGe9BAel/mmvanFdyHs
	zBL5zNzkacHbPDyl07WeTaDjQwMqO+CVrS7//EnmFNaP9fDujh9LT/Kk5O8F+cuBWwI6p5
	ui3rY7159x7g7Rko10pWg9K55Qt+zVk=
X-MC-Unique: qgKohuLWPSKSfDSy0SZ3XQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=DigtZyC5FzcCRoHB7dsm32+4VIQ6S3nal5l68PpjiCmN44GE3SSLY/sRZ5MjIA1/VXJHX+JzVLAgKvjPSxr/n9U1RYbDenS3QVNKnMjH6km19Vx7caamU86iK5Frhk+iHFzU2XGRwwb8ikKsxa30e1dBqYekAGjbrW7KTNx8saMdYBOUtm+RCeY6mBRQNvAokp5WdRP1VjPjq7ubtcscdZSzHfHxrlJ0QTGTBe6mjhSJdoT1SBv2Dgp+PI6HyhtmoHAtH2hORTfrzFzPPloK/IGbiEvOqigmM4cgUcVFxaZwYnzk6U0EAZ46ILc4quXzsgXBS8YmBjs/y9CYMy90pA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=jO5oujVGxYE8gCO9O1wJxedKAsnpNsZI1EHBIUKEpYU=;
 b=XDSyop4ipRuVzBOk0KvO/3Vv8DFMaVjGAyct66BTyp6K40X2z361HfHKI9Gk2QqqpqyTDCkFq5Eo24bSHLqbqyogwrOoEeI9jFIalct/Z5JhaL31Lo0mR/BFJL2+U7XUEbJnPxLdXl/YsQekPyVG9FGmNZxC3cqjTztV8k24cO+9rD959jQyrxvzJgxJabJ8CorhCRFHc8BI5RNofcPniwwkmf4UoxwHbUXJB8MU7zMEzlMrHr9hG42tYr7d+cTKNA+vTM3N7/4uoYuLFiuHacVP1YE6xNjLSlmfPwp9DmlKiH8QFGirf/m9D+uOMu6rpV7RHHZsq3QCnLO4NtS+0w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <1bc9c545-5af7-8665-4830-e8aa3836101b@suse.com>
Date: Tue, 8 Feb 2022 10:16:59 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v6 06/13] vpci/header: implement guest BAR register
 handlers
Content-Language: en-US
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Cc: "julien@xen.org" <julien@xen.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Artem Mygaiev <Artem_Mygaiev@epam.com>,
 "roger.pau@citrix.com" <roger.pau@citrix.com>,
 "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
 "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
 "paul@xen.org" <paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-7-andr2000@gmail.com>
 <61d85343-9a37-6409-449d-a662ae5258c5@suse.com>
 <66992013-f438-246b-451d-d96f6eea22c0@epam.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <66992013-f438-246b-451d-d96f6eea22c0@epam.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P191CA0052.EURP191.PROD.OUTLOOK.COM
 (2603:10a6:209:7f::29) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5e33fc65-3486-41cd-9523-08d9eae3c3cb
X-MS-TrafficTypeDiagnostic: VI1PR0401MB2557:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0401MB2557BF8275AF82AA1AEF0E42B32D9@VI1PR0401MB2557.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6108;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	CqsWkiqYdNcZON3U9T3EucIg0e09PrePPIG6zC5RucbjqeNIofpCJ7HIsVwZ4ta1mJ0gMaAcP4I04+EWf9QxiqejDC7gPm1twF0kJRLChmpwhl0WM5xO7taoFQERVGg2zgBMDPG7xU12dPWkPAIzirEsHbWpdh0jFC3ZTTQjP+IY7iypktZGvp3iVTCuBW/pwmocvGs0S28N3KabYOy02BXmsOKPkVY/7+gmIMCWbAUE1oV67dQXiys6R8rBNJJoRDntzpvaV1qGeRyvyvttBcdqvLuiteWJB3Rf+55p0zVRdsKRHuYN3COsefQ0zU8PfYYkKga9JnvXA+7cPj+Ip/T4VEHqiuoauzIyHP1/1WPU0cC9WahRbQpAZxa81eYJD3bQSuVksu+ZeHPawFx9LeAMRR1lc5dJLEqK9DB7C377i1ZuayGolz5zUK9hTVLa5OPHLQbb6xOT0NnWW+8LC8yaDGO5KOg1wj5YoMl8kB+ZRT6pX2M8pmcdTQ20Cje95SV7zS0trcYStKHhs762UAdETdrAqUT9z3sCalAsYmamcP7qXm5U3xrIjJ1ranJqI3CPyJL7rLiiUI1saN7TUFb0UMbYPFJgSKzEO8isPCosL/4AaaGYmABeLUXfNdPxXkWvmKZ10mgBOWh4Kkg3CFyZyv3eqff3ov/Inhe1LcrVmgtOvx3u72NXvEIVSmio6lYpKrDca2wcZ5Off1pLvOXmW3rb/e7l7v/kb6Le+1o=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(83380400001)(6916009)(54906003)(2906002)(66946007)(86362001)(53546011)(26005)(186003)(6512007)(6506007)(31696002)(4326008)(316002)(6486002)(2616005)(8676002)(38100700002)(8936002)(66476007)(508600001)(36756003)(66556008)(31686004)(7416002)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?YXQvUk5Ya0g2VThkNUhFT0VRK2Q3azVoY2h1a2FwTDNlcnlmVk1WT2xrV3VZ?=
 =?utf-8?B?M0ZrN2pWTDZ1cUVsWHRsbkljcGE0OHhJenpWVTdwMlU0blU2aDdxZXJUTkVl?=
 =?utf-8?B?SUZxazd3SmZxY3M5dWt5eVpaM0FoSEVuQTF1eGpZYWNndTVEU2k1SUJUTlAv?=
 =?utf-8?B?MTh1MU1NemRMT1U5eXlRTUVBbU4rcm04bmxLUk9CWktPanRneFJqY3B6akN4?=
 =?utf-8?B?UzN1TVJnUGdTWGRHblZaMUZMVkRLdStUcSs2b0hPQmdXVE95MnlLWHlka0Rm?=
 =?utf-8?B?dFZnTmxXRTNmQ1doSEtCU3dTZHA3WGlpQW5INE1pRFo5akV5Ny9TVzlwR1Zy?=
 =?utf-8?B?Z09yYk5hc3VUUVVlVkZRYUovT2kvTk53QlVLYVc0c1hGVXR3VTAwbzdhVnFW?=
 =?utf-8?B?NFVTNHhmS3VPdFJaeWErdFlFNUtBNUVZMU9TNzFockJXeEN3TW4wbFNHSlZH?=
 =?utf-8?B?R1kzOFQ1RlYvaWM0NVk5MDRzRnV4WGx3cGM2bzU0YnJLOUpNbzlxRDU5NzZz?=
 =?utf-8?B?dzFPQ2VoemxxTnNLTjhIcnlaRzl2V1RVNTcwVUUvOWtGaE5QK1BuQXVVQWJy?=
 =?utf-8?B?S05INWhTM0doYmNrTnpTNXh4c0RMUFFweEQxYnlMaDJOeWVuTnA5c1d6cEF1?=
 =?utf-8?B?S25Sc1pnUGZndkZzWlMrallGbzd1TUdqNllNclJ3ci9wT2Q3RmdERHRzTnpB?=
 =?utf-8?B?b0lZd081R2Fwc1VwVTNIbUlOTzlqVjV4UDMzTUNDMGtvOFA2UDE2SkNEWU02?=
 =?utf-8?B?M04waFJrelhvSVN6TjhabnlNRXdVaWx3eC8rYWRFSkdrWk91dmZVQytJL2kz?=
 =?utf-8?B?aThacUZiOWI1ZlVOenA4Y2ZpVXFIWWU1TEhGWCsyM1VybkVHL3EvRVEzb090?=
 =?utf-8?B?QytNaVQyaEc0RXVQeG9ZcytCTHkvQ3NUQWRiWDNpZGFvVXlzZkJhWm10eW41?=
 =?utf-8?B?UlkrcDdXWjJEUHU2Sk45UlFhYnFGV05ROUwzMWpVNWExN2NPUlFJSTN6aXVJ?=
 =?utf-8?B?cWdLcE9Ka2xTMkx6R2JpbUZxQUNTeFFRdWVqdjBxYXRwcnpnT0V4QnBFaFZD?=
 =?utf-8?B?NEZQRmxLaThPa2JoTXc3dU9iZitCMGNuanFXZjhqTm95ZzlYbXdVMFpVQTBN?=
 =?utf-8?B?UnFTcHNVbWxKdFFiTDlXSGZnVDAvV2NLWWs3ZVZpeElFZCtpVlZFOFk1bEVJ?=
 =?utf-8?B?UGJCazZUd1JYZXJWQ0x5WkNzbjN5SWNITjB6U0djd2oxbUU5MS82WDc5a25h?=
 =?utf-8?B?Y0xXS0dUTmFPK1d2Q2ZhWE1jZmFaajJVMklSR2lOcVVBaGVoME1DQ3p6aEVv?=
 =?utf-8?B?WllqZVF1VVpXb01ENkVqOFkvUkdIN3ZWZWgyWWM5a1pWQnpQamszd3k2ay9M?=
 =?utf-8?B?cVVPdFFKdW1QK1N5cmd0b1VrcGpzaVJVTmVaeGlCTllIck12REhkQTRMVHZy?=
 =?utf-8?B?cFVxSHFvVG5yZU5WcFFLZVROS20rRHFxM0l2c0ZRRlpwRFJIRi9CSnlJVVZC?=
 =?utf-8?B?UHRxK3NRNElsczhydVVDcCtvUWNaMG5CYnY5ckFja09hR1Jkam81VXpGa2Ev?=
 =?utf-8?B?UEJIb1J5elRBMGhGL1d3ajZuM0NqQWx3T1BEQVVzTFFkYlVMN2dWMUdSdFl1?=
 =?utf-8?B?Vm9QZXU0dzZOZXNqd20xUEUrUHZRamY5azYyd2hMUllwZGRNYXlIOGdlekE2?=
 =?utf-8?B?cDd6ekRYMHk5Y3NGT2Nxd0tiQlNzbFJveC9zUXA5NEJtdDRGMnVCUnFSSVAw?=
 =?utf-8?B?NmlQdkNsYkJRa2ZhbC9pcjNZVVJSa3pXSUFoU21XYkFYQmx1Z2Z0ZEo3eFNp?=
 =?utf-8?B?SXluV3AyM3lmUEhPRDE3b0t2QWNoeDdHMURhZHorazRvUEFNaW1IS2VNbUlE?=
 =?utf-8?B?YlJmY1lQMzJ1U2pLSk1tcVdheGVST2NKL0xzRVE3djdyTWdGYW5CdnNVdjB6?=
 =?utf-8?B?WHU0TVBXREtvYjZrKzJwVlBEb1pFR0ZJMUZuWDlBdmx3WGcxMy9QNGFsTHIw?=
 =?utf-8?B?bGVETkpBMUNVMFhDUlpETitVVno4eTI0bjNaZVBpbjArWHpLVHFRdkErTGt6?=
 =?utf-8?B?R3RTQ29rcksrNktIb0JIcFJSQjd1cU1GY2o0eUJybTdvQ283WVNZTVJOaVV0?=
 =?utf-8?B?OEMzSzBqSUtERzlmenpHUHhPNVdSV1VYUmlVdUJhV2NmMDdsZktQbEFYZXV1?=
 =?utf-8?Q?oAhAnW5icWAEjTI9mRNSH0U=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5e33fc65-3486-41cd-9523-08d9eae3c3cb
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2022 09:17:01.4729
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xx1KZdjuYMYglvti27ZufMiO+402zdqcpVq9ZBhBRqERkuSTyT22fPEdfAbxF/1RV492hjKfxpZDAc/5SqBFvA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2557

On 08.02.2022 09:06, Oleksandr Andrushchenko wrote:
> 
> 
> On 07.02.22 19:06, Jan Beulich wrote:
>> On 04.02.2022 07:34, Oleksandr Andrushchenko wrote:
>>> +static uint32_t guest_bar_ignore_read(const struct pci_dev *pdev,
>>> +                                      unsigned int reg, void *data)
>>> +{
>>> +    return 0;
>>> +}
>>> +
>>> +static int bar_ignore_access(const struct pci_dev *pdev, unsigned int reg,
>>> +                             struct vpci_bar *bar)
>>> +{
>>> +    if ( is_hardware_domain(pdev->domain) )
>>> +        return 0;
>>> +
>>> +    return vpci_add_register(pdev->vpci, guest_bar_ignore_read, NULL,
>>> +                             reg, 4, bar);
>>> +}
>> For these two functions: I'm not sure "ignore" is an appropriate
>> term here. unused_bar_read() and unused_bar() maybe? Or,
>> considering we already have VPCI_BAR_EMPTY, s/unused/empty/ ? I'm
>> also not sure we really need the is_hardware_domain() check here:
>> Returning 0 for Dom0 is going to be fine as well; there's no need
>> to fetch the value from actual hardware. The one exception might
>> be for devices with buggy BAR behavior ...
> Well, I think this should be ok, so then
> - s/guest_bar_ignore_read/empty_bar_read
> - s/bar_ignore_access/empty_bar

Hmm, seeing it, I don't think empty_bar() is a good function name.
setup_empty_bar() or empty_bar_setup() would make more clear what
the function's purpose is.

> - no is_hardware_domain check

Please wait a little to see whether Roger has any input on this aspect.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Feb 08 09:26:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 09:26:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267825.461577 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHMlA-0003vS-DJ; Tue, 08 Feb 2022 09:26:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267825.461577; Tue, 08 Feb 2022 09:26:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHMlA-0003vL-9U; Tue, 08 Feb 2022 09:26:04 +0000
Received: by outflank-mailman (input) for mailman id 267825;
 Tue, 08 Feb 2022 09:26:03 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=GmUj=SX=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nHMl8-0003vF-Re
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 09:26:02 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2038df5f-88c1-11ec-8eb8-a37418f5ba1a;
 Tue, 08 Feb 2022 10:26:00 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2038df5f-88c1-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644312360;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=+RiC2VHxm8WcM56jmXQhnODmrRPs4MeJjM/Pa0YftA8=;
  b=dqZWFT0dcbWhyylafQf6TuiL3479oK+6fO+5f87elLsJtyqPtvgzIbXe
   LYmkFGlFvmbxRjA3qSgSU4muBnVrLKCSK+gA+fdTdU6jvWQhELpl2zwbz
   1f9SxC1eF3FpGxMaETn136SLddt4KsJJkIqAZlqN0edBf0VGj5GdMxJGP
   g=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: duqTkEAWY6JC39m+fQ2zp6vkPdZA/0V78He+7wYhiHchIX5vbuh7ptFjeq/d+hx15D+opqqphI
 2Fa5J/H4wwpywvUDrMV0q+7WhZgEb6A9CeAeNqKACbZsDKvJ2oD5lgzsMEKU4QC4GfXGzoQZ93
 lCm/B4ILgHGoOsLlobVEMySUaByBilCOsn0+UmtywLo1I+TvrlcFu6WKECMsK5bejThQ3ccGdk
 Qgzp2LZNsfQb9iDFhmgWSEEZf9NvQ00QjbvdP0SBNCGW97/vE3opDIL/pLKqNvZC/esP5r3yLr
 f4oM2y1LR62V3A0qmOrBAYPD
X-SBRS: 5.1
X-MesageID: 63716404
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:5RQB460y969YI9WTOvbD5e93kn2cJEfYwER7XKvMYLTBsI5bpzEEz
 mtLCj/XOfncNjShfdAkPoSyp0MPvJTSz9A1SwNkpC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkS5PE3oHJ9RGQ74nRLlbHILOCanAZqTNMEn9700o5w75h2+aEvPDia++zk
 YKqyyHgEAfNNw5cagr4PIra9XuDFNyr0N8plgRWicJj5TcypFFMZH4rHomjLmOQf2VhNrXSq
 9Avbl2O1jixEx8FUrtJm1tgG6EAaua60QOm0hK6V0U+6/TrS+NbPqsTbZIhhUlrZzqhoo53l
 e1PtpqMWV1zEfPhltoRQxdjDHQrVUFG0OevzXmXtMWSywvNcmf2wuUoB0YzVWEa0r8pWycUr
 6VecW1TKEDY7w616OvTpu1EnMMsIdOtJIoCknph0SvYHbAtRpWrr6Diu4QHhWls3pwm8fD2W
 NsiWzY1QBP6chxma10cAaAVs+avvyyqG9FfgA3M/vdmi4TJ9yRp2aXpGMrYfJqNX8o9tkSSq
 3/C/m/5KgoHL9HZwj2AmlqlnPPCmBT+SY0bFbCm3vNyiVjVzWsWYDURUVa4uvC/hlSJUtRTM
 VEP+iEuoK4x82SmVtD4GRa/pRaspBccRt4WCOw85wGlw7DRpQ2eAwAsRDNbdMYvssNwQDUwz
 0KIhPvgHzkpu7qQIVqf67OVoDWaKSUTa2gYakcsXQYDptXuvow3phbOVcp4Vr64iMXvHjP9y
 CzMqzIx750ai8IRjf3jpXjIhjutot7CSQtdzhvQWmWp/wZofrmvboaj6UXYxftYJYPfRV6E1
 FADn8Wd9+kIAYu6iD2WQO4NEbeq4N6IKDTZx1VoGvEJ7C+x8nSueYRR5jBWJ0pzNMsAPzjzb
 yfuVRh5vcEJeiHwNOkuPtz3W59CIbXc+crNa67SM+JMYZ5NZFXd039Da3Ccz27Wjx15+U0gA
 quzfcGpBHccLK1oyjuqWusQuYMWKjACKXD7Hs6ikUn+uVaKTDvMEOpebgPSBgwsxP7c+G3oH
 8Bj29xmIvm1eMn3eWHp/IEaNjjmxlBrVMmt+6S7mgNuSzeK+V3N6deMm9vNmKQ/xsy5c9skG
 VnnCydlJKLX3yGvFOlzQikLhEnTdZh+t2knGicnIEyl3XMuCa72svtDLspuJOd2rrU4pRKRc
 xXiU5/Rasmjtxydo2hNBXUDhNAKmOuXafKmYHP+PWlXk29ITA3V4N70FjYDBwFVZhdbQfAW+
 uX6viuCGMJrb107UK7+NaL+p3vs7CN1sL8jACPgfIIJEG2yq9cCFsAEpqJuSy36AU6YnWXyO
 sf/KUpwmNQhVKdvqIaQ3v3f/97yewa8d2IDd1TmAX+NHXCy1kKowJNaUfbOejbYVWju/76la
 /kTxPb5WMDrVn4T22alO7o0n684+fX1oLpWklZtEHnRNgz5AbJ8OHiWm8JIs/QVlLNevAK3X
 GOJ+8VbZurVaJ+0TgZJKVp3dPmH2NEVhiLWsaY/LnLl6XIl57GAS0hTYUWB0XQPMLtvPYo56
 u49o8pKuRengx8nP4/e3CBZ/miBNFIaVKAjus1ICYPnkFNzmFpDfYbdGmn955TWM4dANUwjI
 zm1gqvehusDmhqeIiRrTXWUhLhTn5UDvhxO3WQuHVXRl4qXnOIz0T1Q7S8zElZfwCJY3r8hI
 WNsLUB0e/mDpm86mMhZUmmwMAhdHxnFqFfpwl4EmWCFHUmlUmvBcD80NeqXpR1L9mtden5Q/
 a2CyXajWjHvJZmj0iw3UE9jivriUd0uqVGSxJH5R5yIT8sgfD7ooq6yfm5Z+RLoDPQ4iFDDu
 eQ3rv17brf2NHJIrqA2Y2VAOW/8lPxQyLR+fMxc
IronPort-HdrOrdr: A9a23:ueDOzKOF7aEm2MBcTsWjsMiBIKoaSvp037BN7TEXdfU1SL39qy
 nKpp8mPHDP5Ar5NEtOpTniAsm9qBHnm6KdiLN5Vd3OYOCMggqVBbAnwYz+wyDxXw3Sn9QtsJ
 uIqpIOa+EY22IK7/rH3A==
X-IronPort-AV: E=Sophos;i="5.88,352,1635220800"; 
   d="scan'208";a="63716404"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=VtwGoMKlLchC9swiGRV48AfCvSbSKvxFrW7kxONUYeMzKdyRoYoJgdsJVMCOYhM7tDkKOk65GA8DXyBTzrTLGKW75dHU0kdBaAD4j0rXP3HkdM7lWGLZAXMIHx/NMivjHiF7EScXVkBNlbRX+sx5DStdDdgDHQx+aXB6a4KOWg+0TlAmIS4RdEwsVzLlH8UTXto58KfiLDbFSjkKLv8Z8nCAkTT4pu67Pd1aVEnhT42CyjV7L70WGkbbIxM2+KflsuTPuSM1jPkpXJPcctXGsv3KB9x9mcmv1WCOgMDSyp3ArvV4yUHq4JmcfQz2Gkyh0HZ7kCVanQ7L8h1/zwZJAw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=I1uydbG08brsvWdTFBdPcdk9rw5bGcVGZh9iSwCT3n8=;
 b=LxhUBEMEBxivQHRqJXvaiYrmCNTQMX0g6cJGolxu/QqVr2/RXsqm6ve1WCelZwufm5WUYQdib/nypHD+KvCXji/48AOpHxhpRqr129kv65qNhGhHJxEurFDOwRFYws/CjmlOw1igNYUwaUwS32yZaInyYY9oSVrsOVpcWotBW3UHTU5thMmptX/82uplhlm/3p8uyUet+thoZlNUTtZnJ7TPGdGubvz4VVs+eMILvPLjSIC6VxIHMt33o/t73iHQRtokb1OiMz8l1Ga7qzID35hNiNn4VbKMHvWX1vTGFiCwZa6VDMv2U3U47YSIINzC95NwBjNDgBcwbD3lKjHtZQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=I1uydbG08brsvWdTFBdPcdk9rw5bGcVGZh9iSwCT3n8=;
 b=Qu/mbtflgsGGjdkLC0FAfaSe4yQB3eSEvQSKv7OtUvSVcUO6b3/K9tLJz82EfrgiqTq8iiIMtXM5db8T3O0avUgNqStlGlsp7YVVEs54tpuAlCt8dw/u0baJsval0m5bX9FKPZhjuU9YPpgSYNgQ5+JAq42p8QsCInHxqIjLqU0=
Date: Tue, 8 Feb 2022 10:25:50 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Oleksandr Andrushchenko <andr2000@gmail.com>
CC: <xen-devel@lists.xenproject.org>, <julien@xen.org>,
	<sstabellini@kernel.org>, <oleksandr_tyshchenko@epam.com>,
	<volodymyr_babchuk@epam.com>, <artem_mygaiev@epam.com>, <jbeulich@suse.com>,
	<andrew.cooper3@citrix.com>, <george.dunlap@citrix.com>, <paul@xen.org>,
	<bertrand.marquis@arm.com>, <rahul.singh@arm.com>, Oleksandr Andrushchenko
	<oleksandr_andrushchenko@epam.com>
Subject: Re: [PATCH v6 06/13] vpci/header: implement guest BAR register
 handlers
Message-ID: <YgI3HpFffudiEmNN@Air-de-Roger>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-7-andr2000@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20220204063459.680961-7-andr2000@gmail.com>
X-ClientProxiedBy: MRXP264CA0045.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:500:14::33) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 0d4b2a58-e0cd-43dd-7f6a-08d9eae50240
X-MS-TrafficTypeDiagnostic: CH0PR03MB5954:EE_
X-Microsoft-Antispam-PRVS: <CH0PR03MB595482E98239AA5FB6CA9B2B8F2D9@CH0PR03MB5954.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1303;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 0voH+QvbH4CQYRnBMPx7PP2HJ3Sdx4IzrZKuymcHkDGWyU0/+WoUMk5DoOk+D0UvG4pw6yuTCqA8thLofwJNjsGFw5FYNK5OU13gHhzAX7X1AghNeVcmFVHuubJSEPkdZx+Zdlb5eIgMd/pn8GrYB2skMvlH8Ghl2VjSgOYn8vdf+z8AQdRjMI8/CbUjYW3MWaezEEHyb+DmdVgWiHbSsH2/Y5fd0SoSWyXopAzw1lGBA4p4s4eZHa8walUnoT9Owl45xu+7loc0oWJ8eUT9jelG/iMQxVD5i/B+7f8jJPU07qJsX/wTqchV+1/Wp3sUoaJn0Q+tz4TZWMu1c5sb3w67IJVUKkpJIZnS29aAFlRkbEkOP7IgVA0PiejFXEaTnUbr88qb56gxQtyIQXv5HlhN1plXjmSJgiQogcCUsOvIxlkg2uRWIOW4cb67sAhJ0NuXRjkhajB1UZxzN0GvRfZB8CO7MA4rdhC/bYnC/Dzz6ElRxXqBFG3wjMEk8vZ0inMKy9+aEo9m0necxbxPYhxKCu7UJJHfgFBDfoT5848m+1WcOFWrpViZxgpBeoby5zd/nifpGViVLZ973uQgzJL3gkJPF8ZK57UcbSbDBPWbyyAqZN61AcStArOq9dbDv8XkEnGEOekP7+MD3JBF0g==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(8676002)(66556008)(66946007)(66476007)(6506007)(6512007)(6666004)(186003)(26005)(6486002)(33716001)(86362001)(4326008)(9686003)(38100700002)(82960400001)(8936002)(6916009)(316002)(85182001)(508600001)(7416002)(2906002)(5660300002)(83380400001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TisweExFQjUyWnFtQ0t2Qk5JQmREalRnSTlrdldtZWUyMllZQWpYUXFDUXNz?=
 =?utf-8?B?K1FvRUxXZHdObmtIWHc3d0pjbTFNc2JPQmxWUS9SUnFVNi9CRWVmK3ZUTWMx?=
 =?utf-8?B?OFlvODRjTTBwN0phZ29MRHVQS2JPdit4Z3p6SWlWYXp6eUJsT000SHlBc0hK?=
 =?utf-8?B?QStNRzc3c0dqZWxlTmZ5MndnZURyVGdzSFJWdyt1RVBuVkNOZUdWMWpwczVt?=
 =?utf-8?B?Q21BZE9pNWtBMnVFdmU1amxRdnNrRktaM2hsVG90Uk8xV0I3amYxTTk3dkdv?=
 =?utf-8?B?bkVmMGtzV1VPeWNZZjF1RlZvV0kxUHJCdFVHbk9VQjZDODZCUXZjQThVdUFT?=
 =?utf-8?B?Rm9GVVZNZnBSand6dmxheUk5VUFNY0c2dnNUZSt6N2g2d3J2NnR2dWlmRzZx?=
 =?utf-8?B?Z0RJaXFlQ09VandvZER2S1diWjdkb3RhZ09YRng2TnJuZmNmSDlEd2p5L3FX?=
 =?utf-8?B?MWpUb1lobmp1NUhYZVNCUXk4SzdSMVJzeGYyZkJuZmZZenpFQmxYRVJha0Jq?=
 =?utf-8?B?V1YrUWt3bThwWkZmQkNOKy9CdkhHbmZSV3llbFBZNGRYK1JDWnQ1T2RVUGU5?=
 =?utf-8?B?RmFBNFI5WTBhQm9veWpSTGNNaEx1VFI4dG9HeFd4b0c0L3pvSko4VHJVUnBm?=
 =?utf-8?B?bC9nbFJheG5wWm9lKzVXRVVQYVpISEtBSDdBUmx4c2E2ZkxFZDVGWWpqZzBq?=
 =?utf-8?B?SG5yaXJxNlFUdDZhNGRGWm5VRFBRNmxlU29lemJWUy9KOUZ6eFlNZkhvNG5w?=
 =?utf-8?B?aU43STUxMGJoeHkzWmJ0bTByeXpMdXdRbEl1SnNmQTBZZkF5K0t2QkdPVWF6?=
 =?utf-8?B?NXdPWTFDQS9GTkhNOXdtU0wzZVgvZVhxd1VrL2plcDRwcUJyL2tDN3A0aE9N?=
 =?utf-8?B?Q1pURnY2T3pEWU1KSnV4c0tncEVJOXQrNGNoN3M4eDFNS0g4NDhPTkk2Zm5U?=
 =?utf-8?B?R2JSeFl6UjZOUUlwY1JqZWNuUEZvR1ZOS0RrU3QxMHREMlBRcFVQbEF5cHVI?=
 =?utf-8?B?UkZIOSs1YmlFSjRqWVN4WjExQ3NueEJRd3lESkkwWVl5aVpkcy9tcWtidGRr?=
 =?utf-8?B?Z1Rqcmc1dEJtbllsdThkNkkvUDFESVFGUjJDNFpQQmN5Q3RzOGJub29XVmxK?=
 =?utf-8?B?MHZTMmFWR3BsaHlGRE1GNHJaUXJqQzdGaDZqQlp6c2xmQjhtRXF1WUQ1Vlg1?=
 =?utf-8?B?bnpoZHg0RkFHb3VFNzY1UjVuSHZ4QVNsbElEcC84RkpmQUJuaGR3TUI4WEhj?=
 =?utf-8?B?RFhKS0pMa20wWTk1Y0tSdHh2NFkrYWxRZ1pKcmE0V1AyQThMNURYVDZ4R25p?=
 =?utf-8?B?dmlISEdQNlpETnBjWEFQMGFYVzVpSzEwQ2dhY3hkYXhzRE9ZUjVtVTRXcXNL?=
 =?utf-8?B?bVRSZ1dZbVNWbzZwMUwxZ2IxbEpJdlE1TytLTG5aWmlGVGI2MlBrWFdjKzlT?=
 =?utf-8?B?c29ZeXBEdU5kWENma1hjczcyWWpjem0zbElEaUpTdHBQUU9CcjhEV1liRlpy?=
 =?utf-8?B?Y21hY3Ivd3l1TUx3TklkdFB1TnVrSVFvTDZsTElIbjAybTRxYkpKd1UvTzF2?=
 =?utf-8?B?TUQwVGdrandwR1ZZOUxnd1dzVTVzMmJDRHUzK0tvZzlPZUFZVnFka1NPWTVX?=
 =?utf-8?B?Y2tZaTN4SlliYWlkMjFUMUR4WUlOK0lvZXpRY1l6dzhJR2ZHVnFKR2IyYXBn?=
 =?utf-8?B?Q3NHbk1WRFY3RThadW81Z2wrNTRveVJ3MDAvZFV3Z0F4NWhIRkpzWWV5WkRo?=
 =?utf-8?B?Sm51SE9pVzNwaWpaNWVDV3hKS0p6enJWY05UT0d5MVMyUklmRmFHVUdGbWtk?=
 =?utf-8?B?OFU5WVN5dGdUc0ZsWlZMejN6TlFsT0pWbTI5YkNRRzkrYXpYQzFGTHF5bEc4?=
 =?utf-8?B?MUR5RGxvTWMrYTEvQks0OEdBQVhVWUtxR2V5blhUZWxLTVpyVGdUWHhiTTdG?=
 =?utf-8?B?Z1FFSDRib1dCU2JnVUg1WXlqaC96RDYwdmdNcllIbWV3MEY2aGxkMWZrYUhH?=
 =?utf-8?B?T2o3VUFhbHRLYURrUC9FblJsWld6VTFLcU1BYVZ4VEcvektVWks4dE1FYXdH?=
 =?utf-8?B?MWNRdFNRK0x5djVwdDVrUmFzTDh4QkN5NVJDd0tRL25XTW1aOVdjSlpDbmps?=
 =?utf-8?B?VDVreEl3VTNRdEdjZDdXVzBZeVArWUQwS2xEcGR1WFpmSWp3dnlxUG1ncjky?=
 =?utf-8?Q?HK/mEL5/cBoi3tn59fLZjcY=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0d4b2a58-e0cd-43dd-7f6a-08d9eae50240
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2022 09:25:55.7233
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2LIey/VCTZL2iekks3UgphwG4EWmvMhY2GCASZXq8nXqKCi5pgHvrZ+X7rIMBO6V7RxF0HHKmPII33I7lC7HZQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR03MB5954
X-OriginatorOrg: citrix.com

On Fri, Feb 04, 2022 at 08:34:52AM +0200, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> Add relevant vpci register handlers when assigning PCI device to a domain
> and remove those when de-assigning. This allows having different
> handlers for different domains, e.g. hwdom and other guests.
> 
> Emulate guest BAR register values: this allows creating a guest view
> of the registers and emulates size and properties probe as it is done
> during PCI device enumeration by the guest.
> 
> All empty, IO and ROM BARs for guests are emulated by returning 0 on
> reads and ignoring writes: this BARs are special with this respect as
> their lower bits have special meaning, so returning default ~0 on read
> may confuse guest OS.
> 
> Memory decoding is initially disabled when used by guests in order to
> prevent the BAR being placed on top of a RAM region.
> 
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> ---
> Since v5:
> - make sure that the guest set address has the same page offset
>   as the physical address on the host
> - remove guest_rom_{read|write} as those just implement the default
>   behaviour of the registers not being handled
> - adjusted comment for struct vpci.addr field
> - add guest handlers for BARs which are not handled and will otherwise
>   return ~0 on read and ignore writes. The BARs are special with this
>   respect as their lower bits have special meaning, so returning ~0
>   doesn't seem to be right
> Since v4:
> - updated commit message
> - s/guest_addr/guest_reg
> Since v3:
> - squashed two patches: dynamic add/remove handlers and guest BAR
>   handler implementation
> - fix guest BAR read of the high part of a 64bit BAR (Roger)
> - add error handling to vpci_assign_device
> - s/dom%pd/%pd
> - blank line before return
> Since v2:
> - remove unneeded ifdefs for CONFIG_HAS_VPCI_GUEST_SUPPORT as more code
>   has been eliminated from being built on x86
> Since v1:
>  - constify struct pci_dev where possible
>  - do not open code is_system_domain()
>  - simplify some code3. simplify
>  - use gdprintk + error code instead of gprintk
>  - gate vpci_bar_{add|remove}_handlers with CONFIG_HAS_VPCI_GUEST_SUPPORT,
>    so these do not get compiled for x86
>  - removed unneeded is_system_domain check
>  - re-work guest read/write to be much simpler and do more work on write
>    than read which is expected to be called more frequently
>  - removed one too obvious comment
> ---
>  xen/drivers/vpci/header.c | 131 +++++++++++++++++++++++++++++++++-----
>  xen/include/xen/vpci.h    |   3 +
>  2 files changed, 118 insertions(+), 16 deletions(-)
> 
> diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c
> index bd23c0274d48..2620a95ff35b 100644
> --- a/xen/drivers/vpci/header.c
> +++ b/xen/drivers/vpci/header.c
> @@ -406,6 +406,81 @@ static void bar_write(const struct pci_dev *pdev, unsigned int reg,
>      pci_conf_write32(pdev->sbdf, reg, val);
>  }
>  
> +static void guest_bar_write(const struct pci_dev *pdev, unsigned int reg,
> +                            uint32_t val, void *data)
> +{
> +    struct vpci_bar *bar = data;
> +    bool hi = false;
> +    uint64_t guest_reg = bar->guest_reg;
> +
> +    if ( bar->type == VPCI_BAR_MEM64_HI )
> +    {
> +        ASSERT(reg > PCI_BASE_ADDRESS_0);
> +        bar--;
> +        hi = true;
> +    }
> +    else
> +    {
> +        val &= PCI_BASE_ADDRESS_MEM_MASK;
> +        val |= bar->type == VPCI_BAR_MEM32 ? PCI_BASE_ADDRESS_MEM_TYPE_32
> +                                           : PCI_BASE_ADDRESS_MEM_TYPE_64;
> +        val |= bar->prefetchable ? PCI_BASE_ADDRESS_MEM_PREFETCH : 0;
> +    }
> +
> +    guest_reg &= ~(0xffffffffull << (hi ? 32 : 0));
> +    guest_reg |= (uint64_t)val << (hi ? 32 : 0);
> +
> +    guest_reg &= ~(bar->size - 1) | ~PCI_BASE_ADDRESS_MEM_MASK;
> +
> +    /*
> +     * Make sure that the guest set address has the same page offset
> +     * as the physical address on the host or otherwise things won't work as
> +     * expected.
> +     */
> +    if ( (guest_reg & (~PAGE_MASK & PCI_BASE_ADDRESS_MEM_MASK)) !=
> +         (bar->addr & ~PAGE_MASK) )

This is only required when !hi, but I'm fine with doing it
unconditionally as it's clearer.

> +    {
> +        gprintk(XENLOG_WARNING,
> +                "%pp: ignored BAR %zu write with wrong page offset\n",

"%pp: ignored BAR %zu write attempting to change page offset\n"

> +                &pdev->sbdf, bar - pdev->vpci->header.bars + hi);
> +        return;
> +    }
> +
> +    bar->guest_reg = guest_reg;
> +}
> +
> +static uint32_t guest_bar_read(const struct pci_dev *pdev, unsigned int reg,
> +                               void *data)
> +{
> +    const struct vpci_bar *bar = data;
> +    bool hi = false;
> +
> +    if ( bar->type == VPCI_BAR_MEM64_HI )
> +    {
> +        ASSERT(reg > PCI_BASE_ADDRESS_0);
> +        bar--;
> +        hi = true;
> +    }
> +
> +    return bar->guest_reg >> (hi ? 32 : 0);
> +}
> +
> +static uint32_t guest_bar_ignore_read(const struct pci_dev *pdev,
> +                                      unsigned int reg, void *data)
> +{
> +    return 0;
> +}
> +
> +static int bar_ignore_access(const struct pci_dev *pdev, unsigned int reg,
> +                             struct vpci_bar *bar)
> +{
> +    if ( is_hardware_domain(pdev->domain) )
> +        return 0;
> +
> +    return vpci_add_register(pdev->vpci, guest_bar_ignore_read, NULL,
> +                             reg, 4, bar);
> +}
> +
>  static void rom_write(const struct pci_dev *pdev, unsigned int reg,
>                        uint32_t val, void *data)
>  {
> @@ -462,6 +537,7 @@ static int init_bars(struct pci_dev *pdev)
>      struct vpci_header *header = &pdev->vpci->header;
>      struct vpci_bar *bars = header->bars;
>      int rc;
> +    bool is_hwdom = is_hardware_domain(pdev->domain);
>  
>      switch ( pci_conf_read8(pdev->sbdf, PCI_HEADER_TYPE) & 0x7f )
>      {
> @@ -501,8 +577,10 @@ static int init_bars(struct pci_dev *pdev)
>          if ( i && bars[i - 1].type == VPCI_BAR_MEM64_LO )
>          {
>              bars[i].type = VPCI_BAR_MEM64_HI;
> -            rc = vpci_add_register(pdev->vpci, vpci_hw_read32, bar_write, reg,
> -                                   4, &bars[i]);
> +            rc = vpci_add_register(pdev->vpci,
> +                                   is_hwdom ? vpci_hw_read32 : guest_bar_read,
> +                                   is_hwdom ? bar_write : guest_bar_write,
> +                                   reg, 4, &bars[i]);
>              if ( rc )
>              {
>                  pci_conf_write16(pdev->sbdf, PCI_COMMAND, cmd);
> @@ -516,6 +594,11 @@ static int init_bars(struct pci_dev *pdev)
>          if ( (val & PCI_BASE_ADDRESS_SPACE) == PCI_BASE_ADDRESS_SPACE_IO )
>          {
>              bars[i].type = VPCI_BAR_IO;
> +
> +            rc = bar_ignore_access(pdev, reg, &bars[i]);

This is wrong: you only want to ignore access to IO BARs for Arm, for
x86 we should keep the previous behavior. Even more if you go with
Jan's suggestions to make bar_ignore_access also applicable to dom0.

> +            if ( rc )
> +                return rc;
> +
>              continue;
>          }
>          if ( (val & PCI_BASE_ADDRESS_MEM_TYPE_MASK) ==
> @@ -535,6 +618,11 @@ static int init_bars(struct pci_dev *pdev)
>          if ( size == 0 )
>          {
>              bars[i].type = VPCI_BAR_EMPTY;
> +
> +            rc = bar_ignore_access(pdev, reg, &bars[i]);
> +            if ( rc )
> +                return rc;

I would be fine to just call vpci_add_register here, ie;

if ( !is_hwdom )
{
    rc = vpci_add_register(pdev->vpci, guest_bar_ignore_read, NULL,
                           reg, 4, &bars[i]);
     if ( rc )
     {
         ...
     }
}

Feel free to unify the writing of the PCI_COMMAND register on the
error path into a label, as then the error case would simply be a
`goto error;`

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 09:27:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 09:27:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267833.461588 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHMmS-0004au-RD; Tue, 08 Feb 2022 09:27:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267833.461588; Tue, 08 Feb 2022 09:27:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHMmS-0004an-O6; Tue, 08 Feb 2022 09:27:24 +0000
Received: by outflank-mailman (input) for mailman id 267833;
 Tue, 08 Feb 2022 09:27:23 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1FiY=SX=epam.com=prvs=40383cc40e=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nHMmR-0004ad-EZ
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 09:27:23 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 50c38e97-88c1-11ec-8f75-fffcc8bd4f1a;
 Tue, 08 Feb 2022 10:27:21 +0100 (CET)
Received: from pps.filterd (m0174676.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 2186j5tc014738;
 Tue, 8 Feb 2022 09:27:18 GMT
Received: from eur02-am5-obe.outbound.protection.outlook.com
 (mail-am5eur02lp2053.outbound.protection.outlook.com [104.47.4.53])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e3kgu0pye-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Tue, 08 Feb 2022 09:27:18 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by VE1PR03MB5551.eurprd03.prod.outlook.com (2603:10a6:803:11e::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Tue, 8 Feb
 2022 09:27:13 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77%3]) with mapi id 15.20.4951.019; Tue, 8 Feb 2022
 09:27:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 50c38e97-88c1-11ec-8f75-fffcc8bd4f1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=TF+cdFs4akvt4ZY5VLfy5Ug2QvCHpWhD7KRszuNGIP/gIYIbHXnGoLZXjTxYTqAEYWXNMxFWqNyTtZjFMb/8MB3KvpPmvyqDS9PHtYxnue8cR1nywdiJ4tx1x7/Hj9SeNxmXADHqheB1EEiUw5cnxM+uX6FXGbUPVLA1YLwjk0BwwxHQQXu/8eQsv5bmjSiOUFuPq4q8G1jb6Xl8GaMuqMApydPk/9do067Kcdxb4UpvUj03l4QUQb69XilZLh2E8Dx0IJP+A1O7xaUnFZ7I45c9bX100IY9DWFPrzoU1dQ/EtjMtP9paQLd3EyStP0nDTq78XOiYxeb4vz1oHstoA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=FxSDBzBTgfZZtmNTecDwRQeJQiQYVePpn6Ji/7sO4XQ=;
 b=kxl0lDDzdQF4Bl5IEApb+JENK6l7arL/XsL8hkj9okPrRTAzcYAIs3e23auEMQvWr+22tB/q3eOZZACGxzjJdwsAVTAxxGx40Dk09xmlgwTx8+NKpJBjzfjbpAf29tYavElQZ18Tfkx7PsAmbN2zkeBKAZqiovjm5gZRK+5mE2iEAnOJQH7dUFhDl4WBCiZazvZ0qttc7SbU0L721GuLoQ7TH3gtmboXkZExxg89vuEGgmCIFiF1Vs/erUIAHiY3CXIVTB2yf/JmpMC6XiMoGqg/dWp5rdtu6DrkqRgsKpNmGoNKgnNY7KNq6BQflhijZid1XEmj0zVXd6p6iJyt6g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=FxSDBzBTgfZZtmNTecDwRQeJQiQYVePpn6Ji/7sO4XQ=;
 b=irrpnejAsu+ZUkApZz3MX8IAsij9MbPeTH6bl4rL+17LI4r+jpcp6xOwTeh1mUm5QiPDDDm9TXAHDfUKUb1y9RE5xp0MoeD5RVq1mi618zSV4NDxZoSCnyOaT7wBjPihstcsFaXgdCRTdzAH4unEeMxU8v0NWzj/U8zFl1s41Urbe5sMCJ/OXDjG2N30cTRfM7hqoNcQnE+RMZWOQyrV3mFNFbzJwOt0TB79Qltd0FDDIyi1LYDSzFiEHyTkqeS3RkA0NJHzZJCpC9Wk7JZaCNGj/f0D2ND1GvN5+0AExEg4R2mI54w+jAV8eXCutNYl1R2iJV3oU0ahUc1tD0b2Gw==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>,
        "roger.pau@citrix.com"
	<roger.pau@citrix.com>
CC: "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v6 05/13] vpci: add hooks for PCI device assign/de-assign
Thread-Topic: [PATCH v6 05/13] vpci: add hooks for PCI device assign/de-assign
Thread-Index: AQHYGZFdYv4W1RdbQkeQtzN+PyKqmqyITGQAgAENNICAAAt2AIAAA+uA
Date: Tue, 8 Feb 2022 09:27:13 +0000
Message-ID: <e225553b-b29c-0448-fb9f-f8b513d9f77d@epam.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-6-andr2000@gmail.com>
 <16cea1df-3d0f-d404-2b88-aab47ad5548b@suse.com>
 <3fe6dbe3-51c6-f87f-23f9-cf2e1a924326@epam.com>
 <582ee8f9-7b01-4adc-6a8a-ce8b1dffd534@suse.com>
In-Reply-To: <582ee8f9-7b01-4adc-6a8a-ce8b1dffd534@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 3ecb9794-dc91-408d-0988-08d9eae530e1
x-ms-traffictypediagnostic: VE1PR03MB5551:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <VE1PR03MB5551239BDD9EE0C625B9DA00E72D9@VE1PR03MB5551.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 azaOhIKSaklYjJfaU5YlGvwymJI0ogl/2SOlmpO2rvrwPcizSXriHpNNhkNan2BHU6Gv/ZVxLZjGN+Ot95Ozb0TAp7Y5Jg9QQ2gdfI7e06hYg9CoAog/oZpIn52lr7KVe6bna0YkSNLUBR1JWfxi75NLXG/r2pkBMB9Rxlg8Rm8scvxMmTRXxgdUh/cf9ebmnvHq3WAQbGTWf1k85XCCG+J7xEUodAIdUVWaF9QVidAfQrFj2WAxiK6nyMney+Lzw0V4sEXSyPqihNzpNNpggcyLVm0PGTAcNZfKTf4fIowaGQIwpZcvu1avgqrPpXYiRzq20zjAueNPLb7/GHmDcYRbuakNpwxgxvR4+yvlfsHrykJDOMsePiR2E5gttX4oOW2xfdQpGMYr4Dvrr7cvOvi1b8xKHDh1J+pLrjG9TY2H1Oau+PWaVCsfF914283/HC+HOKeIma1yEWzGOCGUmwFVRYEhwEb8sq5/MpNh/MofKBEuBUiGi0Y7OYO511jQwWM7EygUFoXlK1YpG4yPfo7V0S4oI7FmRg1iyAEhQNfOvWyHqOvCnRQhktZlTqE6jlFFxqruyLmyp1nDeTkUkJDJ1u0aYJTe7Vhvxl67OQttbMspEnlHT6yilz9FKazpfyTi0L/2s2PLmxBVGV9eK6Wl6S2UJj7ZJoFEBvKvNYm7EnE5KO/c8AH/N4mFQqFrtu9NC4OUraoy+k5swCOAg6gRFiPIjBToMKifxjZ3q0szNO1zF1mld9OpYxq8km6U
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(4326008)(508600001)(66556008)(66946007)(91956017)(110136005)(64756008)(66446008)(8936002)(8676002)(54906003)(6512007)(83380400001)(38070700005)(186003)(6486002)(26005)(122000001)(2906002)(66476007)(76116006)(316002)(31686004)(36756003)(31696002)(107886003)(55236004)(6506007)(2616005)(53546011)(86362001)(38100700002)(5660300002)(71200400001)(7416002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?Zjd6TWwyWE1wWkQyeXcycnB0dWp6bWpud2wyOVFXbUpuZEJCQUY3WGRxZmQ0?=
 =?utf-8?B?dmNOVWVCVy9ia2h4RUZ2TWZpYUt2cVBKMDcvL21WeEdIbTEzdFovdFVZS3VJ?=
 =?utf-8?B?MU5SWFFaZ3creGhlZVRlYWJPUEVlazdENHFWZmFBRzJxbnVtem1CWHhaTUkz?=
 =?utf-8?B?OHIxeHY1WWh3NndELzc5T3E1cjMwTGpLazB3QkdjZHZ6bHhEd1NuTjBQSEdZ?=
 =?utf-8?B?VFR6SFd6aVhLOXgxenYrOWVkZzlJT1dvOE9aMDlCVXBUWk12WDdwZE93bW9V?=
 =?utf-8?B?UG1ZR09NY1Y5eFZpamtxUkhoQng1WjJPbi82TVl2SUoyQUNMczhUWDZ5VGF3?=
 =?utf-8?B?VVF2KzhjQjgwalc5ZXZXVU5xbWZSTnFCb09qSlA5L1ZIY1lPd3czaFV3YjRT?=
 =?utf-8?B?clBrVXRFN3BUREkyTVAySTZnYnBFN3BiMVRyUHdnTHBuenJvVGszb3NvRWE4?=
 =?utf-8?B?ZExqTjZLUG9DUzI4Sm8rZi9DZVhTZ2VXK0tjdXkzekJBMkptd2QwRk4xaWVP?=
 =?utf-8?B?WForT0VyUVRHNTA3enpmWmJMTmx2dlliMEtUeUthektLZDlVUHVNTjlNakZj?=
 =?utf-8?B?aFRuYlg3SDdYV1ArWVYrazgvYmRMNDhhQWEwdUtFTE9TU01wSWdHWnZvUW1i?=
 =?utf-8?B?eUtPdTNjMHV4TmdsT2Qzc243OURYbU5Ld2FUeXBZOVI4bllNNW9lL0FQakdY?=
 =?utf-8?B?My9pb2g2SVR2R2FqSy9lRmVYN05US08vdjEvNTA3eXZ0K240L3lVbnA5Rm91?=
 =?utf-8?B?Wm01elBZeTY5OUsrMzhRUTVPMVdtTzVjYTR4cktzakUweHZWZnlmY2I4dDFS?=
 =?utf-8?B?MVhBbWI1VjR5bUFhSDJsWlI3S0xzNnFxdVRxdEJKeWNVNzBIVVp3bmdJaUhp?=
 =?utf-8?B?MVI1UVY5YlZnOE1Jb3JFZEQzZi9JenVCSUZURmNrcHAwRFhGZXdIQmNMc0NH?=
 =?utf-8?B?RXR1OXZlcjR0TU0vMnRjcGFWNjRhMy9WeWIyQ28rMG1VRFJYcDFLSzZXUXBT?=
 =?utf-8?B?KzIxcHQxRDZVN1F0WVhEdzhMOHpQbElVVDN5VFVuWjQrSTBuamcxaUJ0UW40?=
 =?utf-8?B?bVpweUFtcDBrYXU1T1BnT3lMcS9FUGo5bjBRWm1sRS8rM2FoTTVNKzhJVXFq?=
 =?utf-8?B?cmx5eVJKeXJ3blJISG5lNnBVSVhIckZCVzh3a01GaWlZa2d4b2ZLNE5HTGlv?=
 =?utf-8?B?YUR0ZTNKNTk3QTJRTjNoSCtnZkNteWd3aEtzV0oyWlh6R01ocUJVUGRVNVlz?=
 =?utf-8?B?N1hSYyttaGtjbjAwRzRqNk1Fam5rKy9WT1QvSS9wQlVjNTZCeEVpOGdlTEVk?=
 =?utf-8?B?ZHZEUkJiMnRPMEFqd2VVKzVwZWEra2RXL0EvRXpJL0xkeEc2L2VkbVdwamhl?=
 =?utf-8?B?MEg2YVVWK2ZFeTdPOVV3RVl5SzBxbHhMWXVIYk10ZzJSOWFaVWxQYzF6MHdp?=
 =?utf-8?B?Q0Q5VFNjNGd5Y25UeUZtMXI0enhpRVRzdHErTWRZL2ZLNVVHeXdyam9kTDJx?=
 =?utf-8?B?YzJpY3czV1ZVTFZEY0ppSGMxSENkM0Qvay9iTU1NTHZUUXA4ZE56NEo0SG9U?=
 =?utf-8?B?SU1QNk9WQzQ4SDlKRVFlbk9KSHE4Mk5jU2FGWWQ2eW5ub3huSGt0bnBvNHdp?=
 =?utf-8?B?N3ZoRXVOM2ZBcXRxWFhaekpqZUl6UXlLaWRMVUd6b0p2M3F0SEllZ1pyWmZw?=
 =?utf-8?B?RXlBVHdiTnlWUjdLY1hQMlh1Mm9VS3ZyQ1V5aGRnbXpheFdvUVEzREQxLy81?=
 =?utf-8?B?ZEg1YVdoQmFqOXNyZWdoTmN1NlI5b3Ftb2dkazljU3lWRkU2VGpkaUhzcEFm?=
 =?utf-8?B?bllQQkxCY2JIVUhtQUNTUUQrT0s1dkdWdVQ4M2FqaUdyTzNEUUtXMFdwQS90?=
 =?utf-8?B?V3RxVk9sTGtZekx2TGc1dnhjMlYyRWNqQU9sb0NWeStDYWdRanV2SUlPNEU4?=
 =?utf-8?B?MjhKS2wzWVd4NzBnMzFmd2JlWXVFSGhUNmdSYmFlVGV6Q1U0dC9mTkdYcWlU?=
 =?utf-8?B?VXZ4L3BkK1dVYlVqZmRRcS8yRHA3alNrMFhFMHpmYWRpOTdvaEVLT3BKdE9K?=
 =?utf-8?B?UG5pamZnU1I5ZFB6UlhDK3VvZkZqRzlVOTNFd013QXdtQVMyakJYYk9vTlly?=
 =?utf-8?B?YlVZY0tqcmsyakwzVE5IR2J3U2dyMm1SWkFLKzRWMDlyU0JTWHVvdWFYdWhS?=
 =?utf-8?B?bjI3dHVOSHZUSEhXWVY4cHJuZnlZWm44VEpLQ1VkdUdBeC9qUnpvVGNoaS9o?=
 =?utf-8?B?L0xxOVdjbDU5NSt3aWhuNWpLOEZ6TGdyWXMxMk1Qb2hmZWNFblcra3Noam9O?=
 =?utf-8?B?UlZOaWh5VEpCZENUT2JLODR6R3RpckVReUpoZmxwVHcxK3JiYWxmTU1CVW0x?=
 =?utf-8?Q?CN/W41RXj9tGzpIg=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <00F47753509D4B4BB5F9BB8991AAD47B@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3ecb9794-dc91-408d-0988-08d9eae530e1
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2022 09:27:13.6682
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: URdZH47c7uZ11NqVJZDZyoAoz4e2/QAl0fiRimcvUyeP4OhuH6HbQTIJBZlX28XZCMZFXbRQt0ZWi1Z2+XGars8EFEbVkM1YJhaYI7pufYpJu/xybHGxpSAFPdR8Uxsb
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR03MB5551
X-Proofpoint-GUID: 22HjuRQ5-HeOE_O-CL8TwFGFHYab1NCL
X-Proofpoint-ORIG-GUID: 22HjuRQ5-HeOE_O-CL8TwFGFHYab1NCL
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-08_02,2022-02-07_02,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 adultscore=0
 clxscore=1015 priorityscore=1501 bulkscore=0 phishscore=0 mlxlogscore=999
 malwarescore=0 suspectscore=0 impostorscore=0 spamscore=0
 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202080053

DQoNCk9uIDA4LjAyLjIyIDExOjEzLCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMDguMDIuMjAy
MiAwOTozMiwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+PiBPbiAwNy4wMi4yMiAx
ODoyOCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+Pj4gT24gMDQuMDIuMjAyMiAwNzozNCwgT2xla3Nh
bmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+Pj4+IEBAIC0xNTA3LDYgKzE1MTEsOCBAQCBzdGF0
aWMgaW50IGFzc2lnbl9kZXZpY2Uoc3RydWN0IGRvbWFpbiAqZCwgdTE2IHNlZywgdTggYnVzLCB1
OCBkZXZmbiwgdTMyIGZsYWcpDQo+Pj4+ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHBjaV90
b19kZXYocGRldiksIGZsYWcpOw0KPj4+PiAgICAgICAgfQ0KPj4+PiAgICANCj4+Pj4gKyAgICBy
YyA9IHZwY2lfYXNzaWduX2RldmljZShkLCBwZGV2KTsNCj4+Pj4gKw0KPj4+PiAgICAgZG9uZToN
Cj4+Pj4gICAgICAgIGlmICggcmMgKQ0KPj4+PiAgICAgICAgICAgIHByaW50ayhYRU5MT0dfR19X
QVJOSU5HICIlcGQ6IGFzc2lnbiAoJXBwKSBmYWlsZWQgKCVkKVxuIiwNCj4+PiBUaGVyZSdzIG5v
IGF0dGVtcHQgdG8gdW5kbyBhbnl0aGluZyBpbiB0aGUgY2FzZSBvZiBnZXR0aW5nIGJhY2sgYW4N
Cj4+PiBlcnJvci4gSVNUUiB0aGlzIGJlaW5nIGRlZW1lZCBva2F5IG9uIHRoZSBiYXNpcyB0aGF0
IHRoZSB0b29sIHN0YWNrDQo+Pj4gd291bGQgdGhlbiB0YWtlIHdoYXRldmVyIGFjdGlvbiwgYnV0
IHdoYXRldmVyIGl0IGlzIHRoYXQgaXMgc3VwcG9zZWQNCj4+PiB0byBkZWFsIHdpdGggZXJyb3Jz
IGhlcmUgd2FudHMgc3BlbGxpbmcgb3V0IGluIHRoZSBkZXNjcmlwdGlvbi4NCj4+IFdoeT8gSSBk
b24ndCBjaGFuZ2UgdGhlIHByZXZpb3VzbHkgZXhwZWN0ZWQgZGVjaXNpb24gYW5kIGltcGxlbWVu
dGF0aW9uDQo+PiBvZiB0aGUgYXNzaWduX2RldmljZSBmdW5jdGlvbjogSSB1c2UgZXJyb3IgcGF0
aHMgYXMgdGhleSB3ZXJlIHVzZWQgYmVmb3JlDQo+PiBmb3IgdGhlIGV4aXN0aW5nIGNvZGUuIFNv
LCBJIHNlZSBubyBjbGVhciByZWFzb24gdG8gc3RyZXNzIHRoYXQgdGhlIGV4aXN0aW5nDQo+PiBh
bmQgbmV3IGNvZGUgcmVsaWVzIG9uIHRoZSB0b29sc3RhY2sNCj4gU2F5aW5nIGhhbGYgYSBzZW50
ZW5jZSBvbiB0aGlzIGlzIGhlbHBpbmcgcmV2aWV3Lg0KT2sNCj4NCj4+PiBXaGF0J3MgaW1wb3J0
YW50IGlzIHRoYXQgbm8gY2FsbGVyIHVwIHRoZSBjYWxsIHRyZWUgbWF5IGJlIGxlZnQgd2l0aA0K
Pj4+IHRoZSBpbXByZXNzaW9uIHRoYXQgdGhlIGRldmljZSBpcyBzdGlsbCBvd25lZCBieSB0aGUg
b3JpZ2luYWwNCj4+PiBkb21haW4uIFdpdGggaG93IHlvdSBoYXZlIGl0LCB0aGUgZGV2aWNlIGlz
IGdvaW5nIHRvIGJlIG93bmVkIGJ5IHRoZQ0KPj4+IG5ldyBkb21haW4sIGJ1dCBub3QgcmVhbGx5
IHVzYWJsZS4NCj4+IFRoaXMgaXMgbm90IHRydWU6IHZwY2lfYXNzaWduX2RldmljZSB3aWxsIGNh
bGwgdnBjaV9kZWFzc2lnbl9kZXZpY2UNCj4+IGludGVybmFsbHkgaWYgaXQgZmFpbHMuIFNvLCB0
aGUgZGV2aWNlIHdvbid0IGJlIGFzc2lnbmVkIGluIHRoaXMgY2FzZQ0KPiBOby4gVGhlIGRldmlj
ZSBpcyBhc3NpZ25lZCB0byB3aGF0ZXZlciBwZGV2LT5kb21haW4gaG9sZHMuIENhbGxpbmcNCj4g
dnBjaV9kZWFzc2lnbl9kZXZpY2UoKSB0aGVyZSBtZXJlbHkgbWFrZXMgc3VyZSB0aGF0IHRoZSBk
ZXZpY2Ugd2lsbA0KPiBoYXZlIF9ub18gdlBDSSBkYXRhIGFuZCBob29rcyBpbiBwbGFjZSwgcmF0
aGVyIHRoYW4gc29tZXRoaW5nDQo+IHBhcnRpYWwuDQpTbywgdGhpcyBwYXRjaCBpcyBvbmx5IGRl
YWxpbmcgd2l0aCB2cGNpIGFzc2lnbi9kZS1hc3NpZ24NCkFuZCBpdCByb2xscyBiYWNrIHdoYXQg
aXQgZGlkIGluIGNhc2Ugb2YgYSBmYWlsdXJlDQpJdCBhbHNvIHJldHVybnMgcmMgaW4gYXNzaWdu
X2RldmljZSB0byBzaWduYWwgaXQgaGFzIGZhaWxlZA0KV2hhdCBlbHNlIGlzIGV4cGVjdGVkIGZy
b20gdGhpcyBwYXRjaD8/DQo+DQo+Pj4+IC0tLSBhL3hlbi9kcml2ZXJzL3ZwY2kvdnBjaS5jDQo+
Pj4+ICsrKyBiL3hlbi9kcml2ZXJzL3ZwY2kvdnBjaS5jDQo+Pj4+IEBAIC05OSw2ICs5OSwzMyBA
QCBpbnQgdnBjaV9hZGRfaGFuZGxlcnMoc3RydWN0IHBjaV9kZXYgKnBkZXYpDQo+Pj4+ICAgIA0K
Pj4+PiAgICAgICAgcmV0dXJuIHJjOw0KPj4+PiAgICB9DQo+Pj4+ICsNCj4+Pj4gKyNpZmRlZiBD
T05GSUdfSEFTX1ZQQ0lfR1VFU1RfU1VQUE9SVA0KPj4+PiArLyogTm90aWZ5IHZQQ0kgdGhhdCBk
ZXZpY2UgaXMgYXNzaWduZWQgdG8gZ3Vlc3QuICovDQo+Pj4+ICtpbnQgdnBjaV9hc3NpZ25fZGV2
aWNlKHN0cnVjdCBkb21haW4gKmQsIHN0cnVjdCBwY2lfZGV2ICpwZGV2KQ0KPj4+PiArew0KPj4+
PiArICAgIGludCByYzsNCj4+Pj4gKw0KPj4+PiArICAgIGlmICggIWhhc192cGNpKGQpICkNCj4+
Pj4gKyAgICAgICAgcmV0dXJuIDA7DQo+Pj4+ICsNCj4+Pj4gKyAgICByYyA9IHZwY2lfYWRkX2hh
bmRsZXJzKHBkZXYpOw0KPj4+PiArICAgIGlmICggcmMgKQ0KPj4+PiArICAgICAgICB2cGNpX2Rl
YXNzaWduX2RldmljZShkLCBwZGV2KTsNCj4+Pj4gKw0KPj4+PiArICAgIHJldHVybiByYzsNCj4+
Pj4gK30NCj4+Pj4gKw0KPj4+PiArLyogTm90aWZ5IHZQQ0kgdGhhdCBkZXZpY2UgaXMgZGUtYXNz
aWduZWQgZnJvbSBndWVzdC4gKi8NCj4+Pj4gK3ZvaWQgdnBjaV9kZWFzc2lnbl9kZXZpY2Uoc3Ry
dWN0IGRvbWFpbiAqZCwgc3RydWN0IHBjaV9kZXYgKnBkZXYpDQo+Pj4+ICt7DQo+Pj4+ICsgICAg
aWYgKCAhaGFzX3ZwY2koZCkgKQ0KPj4+PiArICAgICAgICByZXR1cm47DQo+Pj4+ICsNCj4+Pj4g
KyAgICB2cGNpX3JlbW92ZV9kZXZpY2UocGRldik7DQo+Pj4+ICt9DQo+Pj4+ICsjZW5kaWYgLyog
Q09ORklHX0hBU19WUENJX0dVRVNUX1NVUFBPUlQgKi8NCj4+PiBXaGlsZSBmb3IgdGhlIGxhdHRl
ciBmdW5jdGlvbiB5b3UgbG9vayB0byBuZWVkIHR3byBwYXJhbWV0ZXJzLCBkbyB5b3UNCj4+PiBy
ZWFsbHkgbmVlZCB0aGVtIGFsc28gaW4gdGhlIGZvcm1lciBvbmU/DQo+PiBEbyB5b3UgbWVhbiBp
bnN0ZWFkIG9mIHBhc3NpbmcgZCB3ZSBjb3VsZCBqdXN0IHVzZSBwZGV2LT5kb21haW4/DQo+PiBp
bnQgdnBjaV9hc3NpZ25fZGV2aWNlKHN0cnVjdCBwY2lfZGV2ICpwZGV2KQ0KPj4gK3sNCj4+ICvC
oMKgwqAgaW50IHJjOw0KPj4gKw0KPj4gK8KgwqDCoCBpZiAoICFoYXNfdnBjaShwZGV2LT5kb21h
aW4pICkNCj4+ICvCoMKgwqDCoMKgwqDCoCByZXR1cm4gMDsNCj4gWWVzLg0KPg0KPj4gWWVzLCB3
ZSBwcm9iYWJseSBjYW4sIGJ1dCB0aGUgcmVzdCBvZiBmdW5jdGlvbnMgY2FsbGVkIGZyb20gYXNz
aWduX2RldmljZQ0KPj4gYXJlIGFjY2VwdGluZyBib3RoIGQgYW5kIHBkZXYsIHNvIG5vdCBzdXJl
IHdoeSB3b3VsZCB3ZSB3YW50IHRoZXNlDQo+PiB0d28gYmUgYW55IGRpZmZlcmVudC4gQW55IGdv
b2QgcmVhc29uIG5vdCB0byBjaGFuZ2Ugb3RoZXJzIGFzIHdlbGwgdGhlbj8NCj4gWWVzOiBQcmlv
ciB0byB0aGUgY2FsbCBvZiB0aGUgLT5hc3NpZ25fZGV2aWNlKCkgaG9vaywgZCAhPSBwZGV2LT5k
b21haW4uDQo+IEl0IGlzIHRoZSBfcHVycG9zZV8gb2YgdGhpcyBmdW5jdGlvbiB0byBjaGFuZ2Ug
b3duZXJzaGlwIG9mIHRoZSBkZXZpY2UuDQpUaGlzIGNhbiBiZSBkb25lIGFuZCBtYWtlcyBzZW5z
ZS4NCkBSb2dlciB3aGljaCB3YXkgZG8geW91IHdhbnQgdGhpcz8NCj4NCj4gSmFuDQo+DQpUaGFu
ayB5b3UsDQpPbGVrc2FuZHI=


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 09:29:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 09:29:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267843.461599 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHMoq-0005Dv-93; Tue, 08 Feb 2022 09:29:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267843.461599; Tue, 08 Feb 2022 09:29:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHMoq-0005Do-5j; Tue, 08 Feb 2022 09:29:52 +0000
Received: by outflank-mailman (input) for mailman id 267843;
 Tue, 08 Feb 2022 09:29:50 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=GmUj=SX=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nHMoo-0005Di-Ph
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 09:29:50 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a8847e40-88c1-11ec-8f75-fffcc8bd4f1a;
 Tue, 08 Feb 2022 10:29:49 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a8847e40-88c1-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644312589;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=4jFbx/RHhWlzxgz2kb/wwup8BCw/fbQLYggpgjuPGUQ=;
  b=IFBkEhv3CpexgCAVBXdCMK7/S9MRFpZhbVuwh5x/O8UTpCI54hM8N2ci
   y9m1QN3TFj/bFl/ZJJ11OESCnDtxVBoUY7jYzpE8Za8D69wH8IggbnIYn
   8KZ1DTcoCEwVqNtnEGwdeuK3KBbWJvKka4N3SakXJglFa/ARJYUiRkbnQ
   s=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: ka7va5Z7RricQ7rok5L/fp/uHhwQkaPkQPZRRoV5b5jG5u54bFE8Cvs6ty7Hab2kRj6tQfDxkr
 O0tD4T27qGw5JONdk2iU1oq/XUOMpXVWDwwnbcb0OmVD/hFEyWryCNZUftpwRW6T3YnUQ47eEW
 N2RMjPinsSsrBkxtnflANE9ox4jfDDEML42Tyd5yCNM7SalicYfCXrfP/tmBc5R7zhXa8Gnut1
 zkUtMWS7Dj/bJONfHKQmcIQmyTYpntNlERb9j3t6qcD2xsj9Pcq89WbMt+TmieiHs+mxMBh/fX
 vsa0sjcNRtMudXWLjtfyhH0k
X-SBRS: 5.1
X-MesageID: 64120967
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:MkfzsKhOzCTcoyvrGVR1XK/fX161QBYKZh0ujC45NGQN5FlHY01je
 htvWDrXbv6IYDehe91ya4W28B9S7ZHUxoRhQVFkqSFhHi4b9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oAMKRCQ7InQLlbGILes1htZGEk0GE/NtTo5w7Rj2tQw0YDga++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /1imKOoEjg7NZGcs+kWDhB+DzF4Ar9/reqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHxO4wSoDd4xCzxBvc6W5HTBa7N4Le02R9u2pkURaeAO
 KL1bxJFdhnJY0doAG5HL64nhtjzwVnecjZx/Qf9Sa0fvDGIkV0ZPKLWGMLcZ9iiVchT2EGCq
 Qru1n7lDxQtEc2QwDuI7FqhnubK2yj8Xeo6HrCi6uRjhlHVw2UJEQAXTnOyu/z/gUm7M/pPJ
 kpR9icwoKwa8E2wUsK7TxC+uGSDvBMXR5xXCeJSwBuEyrfQpR2YAGcEZjdbbZots8pebQIt0
 liFjtb4HwtFubeeSW+e3rqMpDb0Mi8QRUclYSIHVgID78PUiYc/lA/UTt1jHai2ifX4ATj1h
 TuNqUAWhb8ekMoK3KWT5k3cjnSnoZ2hZgwo4gTaWEq14wU/Y5SqD6SP7VXY9v9GIJyuckiav
 HMEls6d68gDFZiI0ieKRY0lB6q17vyINDndh19HHJQ78TmpvXm5cuhtDCpWfRkzdJxeIHmwP
 RGV6Vg5CIJv0GWCQoJIe9mOGc8WnYPtHonscOzEaOVcW80kHOOYxx1GaUmV1mHrtUEjl6AjJ
 JuWGfqR4WYm5bdPl2TvGbpEuVM/7mVnnD6IG8inp/iy+efGPBaopaE53ExihwzTxIeNu03r/
 tlWLKNmID0PAbSlMkE7HWP+RG3mzETX57ir8aS7lcbZe2KK/V3N7NeLkNscl3RNxfg9qwsx1
 ijVtrVk4FT+n2bbDg6Bd2pubrjiNb4m8y5nZH11ZAj5gSF4CWpK0Ev4X8FmFYTLCcQ5laIkJ
 xX7U5no7gtzpsTvpG1GMMiVQH1KfxW3nwOeVxdJkxBkF6OMszfho4e+FiO2rXFmJnPu6aMW/
 u3xviuGEMFrb1kzU67+Nqn1p3vv5id1pQ6HdxaRSjWlUB63q9YCxu2YpqJfHvzg3j2ZnmTDj
 FvNUU5DzQQPyqdsmOT0aWm/h97BO8N1H1ZAHnmd6rCzNCLA+XGkz5MGW+GNFQ0xnkutkEl7T
 ekKnfz6LtMdm1NG79h1H7pxlPps7Nrzvb5KiA9jGSyTPVisD7phJFiA3NVO6fIRluMI51PuV
 xLd4MReNJWIJNjhTAwbKj06Y7nRzvoTgDTTs6g4eR2o+C9t8bObekxOJB3Q2jdFJb54Pdp9k
 +csscIb8SKljR8uPorUhyxY7T3UfHcBT78mptcRB4qy0lgnzVRLYJr9DC7q4c7QN4UQYxdye
 jLN3fjMnbVRwEbGYkEfL3mV0LoPn4kKtTBL0EQGewaDlO3ai6JlxxZW6zk2EFhYl00Vz+JpN
 2F3HERpPqHSrSxwjc1OUm3wSQFMABqVph74x1cTzTCLSkCpUirGLXEnOPbL90ccqjoOcj9e9
 bCe6WDkTTe1I52hgnpsARZo+675UNh81gzeg8T2Tc2KEq4zbSfhnqLzN3EDrAHqAJ9piUDKz
 QWwED2ctUEv2fYsnpAG
IronPort-HdrOrdr: A9a23:N8cTYaHmlo/l6rT2pLqEMMeALOsnbusQ8zAXPhhKOHlomszxra
 +TdYcgpHvJYVcqKQodcL+7Scq9qB/nmKKdgrNhR4tKPjOW2ldARbsKheCJ/9SKIUPDH5tmtZ
 uIBJIeNDSfNzRHZI3BkW6F+p4bsb+62bHtj+LX1W1sQgFhY7xh6QARMHfjLqRZfng/OaYE
X-IronPort-AV: E=Sophos;i="5.88,352,1635220800"; 
   d="scan'208";a="64120967"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=M8IU2EC9GLickhKyrTYOQFHbZEoDrgTKngEfAaR3MmBCB5sBw11KyM+CHOWdGmGxe6aMKjqcRwceLXEUXv9tHEUm7jrIUKpyX35oUMnl7mqleMCOYYvCJnnSm/WUCf6QjHOH1NaQaERYNZwk0PDd0CtAqWkd7VLy+HucuSFm480BqB75z+gGSzyGFBYVkBx5QE/76Zck4P7pk9sODgpRFHatVsErsnxr4lXcE23DnYrry9Iv9ygIQFlF+dBd1gVfbwedyMc57RZLNMtN5aMjYytQXzbB/4hdV5snfbu4WFIDuC7u9NLRNrtXYkyHhk9LjYADZyFTaD/YAB0NAKqrmQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=HPHEHagKqtJ19nwbHuNeVG1QMZljMg6SFdCo8Bt4izU=;
 b=HvxbjjVisHhKbHaCuWe2P6CzwQRSM65bDpehDAMXQMl/Yv6j1XoM9hU0WMhAi8xglWnIEg6OFmoj0+aiVcYwzcQNCVDiz5PwHlr1tUpICCoGjI8Xj39UGySTUdGsQH7mMfvHuccLvQOEDpt/dx/fOs/7Atfgec4wAfg5pL2BQwtT0u5L0bZdUuBn0oyJdJ3sHajeMaUp5AtJuBY5IgM6wP0zPjvncrxI0VHZtCa+yRREbatp8ZANdyrmL5YSvDE8AoqnK+pMWvtPXFTATfGgwTVWpMGZxgk06V+2iRUb4hp9wQowIKs4LriyjrpRTtP8aCuyM36YRSyQ+6BkEf1zPg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=HPHEHagKqtJ19nwbHuNeVG1QMZljMg6SFdCo8Bt4izU=;
 b=hhaKHriVtfy9HrR3hSAXsJ9kyEqDit3GPxD5yWl8KWrsF+BAXZjP8KlGsP9nS5bcsOTDG5ChFoa8K1S45IZnor45YWQPjwgEA2gcU19bTD6pJ+esyJhwj5Q+x7bH9hERGKFmpU60bdFIx7QQj010uBo9wOlm1EQvAJursEJeYyk=
Date: Tue, 8 Feb 2022 10:29:37 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>,
	"julien@xen.org" <julien@xen.org>, "sstabellini@kernel.org"
	<sstabellini@kernel.org>, Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Artem Mygaiev <Artem_Mygaiev@epam.com>,
	"andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
	"george.dunlap@citrix.com" <george.dunlap@citrix.com>, "paul@xen.org"
	<paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>, Rahul Singh
	<rahul.singh@arm.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v6 06/13] vpci/header: implement guest BAR register
 handlers
Message-ID: <YgI4AWgVc/zN4THm@Air-de-Roger>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-7-andr2000@gmail.com>
 <61d85343-9a37-6409-449d-a662ae5258c5@suse.com>
 <66992013-f438-246b-451d-d96f6eea22c0@epam.com>
 <1bc9c545-5af7-8665-4830-e8aa3836101b@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1bc9c545-5af7-8665-4830-e8aa3836101b@suse.com>
X-ClientProxiedBy: MR2P264CA0126.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:500:30::18) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 1399548c-92df-47c4-cd0f-08d9eae589e4
X-MS-TrafficTypeDiagnostic: DM5PR03MB3387:EE_
X-Microsoft-Antispam-PRVS: <DM5PR03MB3387519CFD58C7420A0124F28F2D9@DM5PR03MB3387.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5797;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 46aH7D/UI4/ILAYyHCWjluI14cUt00S/Jf7Q4i5SSfGTYk15slP31KeyyfkwsgTrHeTZdOIj+iVGiccqMPWqJat/ZuwYI6Mp6tffzuXtwIKB/d89pniBSfgqakKh5E931Ub2YSYwRUlFjcwwt5kYjCMQ4UO7hSHL1acFZX2gnUE4miAYzMAGlj/H6m5DeOGfvc9jYyvmOTtdB0n+v69a5V2S9oT90eu9wfBm66RGEWzLOyHekizu0xfg3xRWkYYLTIccuLxY6ry7+8iHPwyZ34w3dLgNpnO5OVaEMV5fIw4gg8r2D4T5bwvGSZZMWCuh0Z8aECQu/wt+WjY6qRi7WhvqPYxOcnlsAp2oKwHgCFWf2asLJy38PJNKH2k+3hOU/q9xAe4vW7uVftxdcEfsKHHolNA07OsnHZR/1JddGrHUiueShl9UuvvQ/1n38qzRBOcmsVenG8Rj/09pLaUq9E3lxhQgblVNRa1QY3Fxd/FnejjiIOhrYCUL8fizSFn4hMoNYMRC1D/EPrXQkvuLmu2N73DCHoLXwVgrxnrjQFSUyLiL2s8TuFOA61BG3xXopOrndAteiIkJJRQyKduhkGnw2IcWBeTBjzc1d9iLdgQ5S6EgllrL4Xof2xo+0bsdR1Jbww5NuLyz1yn42ri1xw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(508600001)(186003)(54906003)(26005)(6486002)(83380400001)(6916009)(316002)(7416002)(66476007)(66556008)(86362001)(33716001)(85182001)(4326008)(8676002)(8936002)(66946007)(82960400001)(2906002)(5660300002)(53546011)(6506007)(6512007)(6666004)(9686003)(38100700002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R3hicCtMZHhIMlRpanIyMU5IcDVmOW41Q1lnb0orOXlQcW1USThNcXFFL2k0?=
 =?utf-8?B?QVpBU0xuSW4xS3hHQVlycVJMQ3YvbFRQWU9Pa3gySXZ0SHJYeHg0dklSc1ZW?=
 =?utf-8?B?cnpWb0tpcUtGZkF4RExVNUJkekZ3Ung0SWMwKzVLM1JGM3dXWTRTZnlBQUxI?=
 =?utf-8?B?d0UyMVRWQ0NxR2pEelN6YjJqTHdlRmhNN09aY1VCS1dtR3pFbDhzK0tsMXVw?=
 =?utf-8?B?N2VqcVMyVjMzakdjeDNqUFEyb3RLaEJQYytQdm5pazcxZnlpcUhQRTE0QVJP?=
 =?utf-8?B?SGk0a0pFTVMycUlwd0NzZm8wN0lBOGVNdkwyWE9SR0lLNm5zVVN3cHI0ZmE0?=
 =?utf-8?B?aFpqN3lWTkhCeGJ1STVhSVJybWNRaFBJMHlyUlZTWUlmUjUwb1cvbG1LZ1lY?=
 =?utf-8?B?REpFMlpBZjRPZmk4YW9jR201azVDVHhMRjFFRHBaVXBLZXU3cDlJUDFqbEVZ?=
 =?utf-8?B?RWtwTWkyQ3QrNXRUWTdZTzh5S0lreTBHWFVBbFlLcENDaHZuZmJVYjJoSjR4?=
 =?utf-8?B?OWVreFRZYU5Jc0hiQlk4T2VqeEFNbVRzcjBzdjhFSURjSnl1Z2hpcm5vYzZm?=
 =?utf-8?B?a05CS1JDQi8vWENiSjJaNFNUWWRKbWRlMUNnWkF6RkZwYXNPOHR1WmV6cUdV?=
 =?utf-8?B?ZHNzNEVpa1VkeGtLZGJTbnFYM1ZTZVpuelR5aGc5SjAzL2Q3OEFEclZ5Y3Z2?=
 =?utf-8?B?N0VRU3J3WkxEdlV1R2RPQXN3Z0xPU0lIdmY0cmR1L1N1TmpXUE0vL2RmckNS?=
 =?utf-8?B?bmlhVDhCMXh1bHludE1ZSHphbnpCc2VtOEZRUG9aa3MzWTdYYUNJR2hFRUxt?=
 =?utf-8?B?d2hoNktkN1pFcUJpSStnREFGdnNCVlNKZjFZVThxTzEvZzE1aVk3QlNkclZp?=
 =?utf-8?B?VlpZN09NUENFT05sMkgxTUNOU0F0OGUvYUIveU4xQUJNdzU0b2pVWVBCZGhm?=
 =?utf-8?B?UEVhQVpuaXhwdUVYVDhFYnRjZzRNby9KaCtYekRuaC9tYVVHb3VWV0VmbWRj?=
 =?utf-8?B?dUpib2ZiNWtBeS9Vb0x2N245ZEJEZWZSTjNyaTUxMWVSY3NDWWFsSkZXUUts?=
 =?utf-8?B?bXo4QUtmL2QzUUkrdGpRd3F4ai8vaFcxNXJVYi8reTl6Z3FjK3E2OFJ5SDV3?=
 =?utf-8?B?bTF4YUxFRXpLQit6TGpXYmZPRGJRRFNNS2Y5UzZjWFdIMXU4L2dBdlQ0YTlp?=
 =?utf-8?B?SFN1d0IxdnNYdnpubTVLMGUxR3QxUUNsVnNIa2U0aXlQNG9RMlNjQU1OUysw?=
 =?utf-8?B?QlpyZU0vYVRZTEtod3UrQ0pET2tDbU5jSlRqY3IrbGxUMjlmRk1iRVUwNkhy?=
 =?utf-8?B?VE40ZmdnL3JhV2I4OFNMb2ZLTy9wS1pweGUvaVA0bkhvTmJTQi94WkhONWRw?=
 =?utf-8?B?ZFQ3aFZvaDRpbFQ5R0lpWHg4NzR2TjdBYnhZY2wvK2g1UlFWM1Jvamx2cXlm?=
 =?utf-8?B?S0xUYUZSR1JxNDZ2a0tKU3ZQaUZ5eDVGSFRlQkpjK3RSWXRkdG12amVleEd5?=
 =?utf-8?B?anBrSXFYMkVVRXE4Zy9TK0R3WGZBS3gyRGxlckl5SGJQS3NYbFA0ZVVDUVh1?=
 =?utf-8?B?cjB0T2tFUmc0VkhSbEpBZXBoSVRVQ0tzQmtxcHdWUWhkL01zQ24vRWZ6c0k0?=
 =?utf-8?B?U2JYcXVWYjhnOCtRaUdJV3p5MWl6ZHRQWExudFpaamFUWWV0S29TUzI2ZlBm?=
 =?utf-8?B?VTVhRUhsemx4c2YvWHJDcjlhanBPckczeFB0TWtZVkkra280YnpHL1REQk1S?=
 =?utf-8?B?RjV5THpTSFNGZml3NFpmSk5UcnptTEJzUmpGemNBUlhpeFd6Z0FpZjdId2Zs?=
 =?utf-8?B?VXRmaExBaHN5RkpXcWRhbkc3YmpMR3k5b3dHai9jSFc1YjllWVR1R2E2MTV3?=
 =?utf-8?B?MVhEaXFTSmZ4L1NHMlBaam1CSGR0ajFFaitpRUlGcDVKSUFVR1BkY1lqLzhI?=
 =?utf-8?B?Z1l1d1E3a1VzaWVSdDlYUlhneURZRmFIdTdrbDNVSFF4dlRGY2E3M3lxUHR3?=
 =?utf-8?B?UmNobkthT1c2MENIWWpaQi8wM0NSQ002UFZwVVVrSkdrbmJDMFZ5RTJUSzZi?=
 =?utf-8?B?Sk81SlNuSjJKK3VHV3RpSGFuQUw4bWxnOGFlTll6WHhLMmFQL01uSk8rRXFw?=
 =?utf-8?B?SGNEMFRGUnBHVjJlM1RaNE9aSUxEc05hM0h0akdMR2NXbFFRUE9seDdTbkxQ?=
 =?utf-8?Q?QS5qojYbM/pMfhk0dqRnUcw=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 1399548c-92df-47c4-cd0f-08d9eae589e4
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2022 09:29:43.2300
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OhIybPh7cc7LZ/J2PW3bUpRteCR4RdSDkPo1+YTI8B8BJB8EsNrto/bUsDcx9Rj1JEcTAVUHEkAmNZZhJCsRkQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB3387
X-OriginatorOrg: citrix.com

On Tue, Feb 08, 2022 at 10:16:59AM +0100, Jan Beulich wrote:
> On 08.02.2022 09:06, Oleksandr Andrushchenko wrote:
> > 
> > 
> > On 07.02.22 19:06, Jan Beulich wrote:
> >> On 04.02.2022 07:34, Oleksandr Andrushchenko wrote:
> >>> +static uint32_t guest_bar_ignore_read(const struct pci_dev *pdev,
> >>> +                                      unsigned int reg, void *data)
> >>> +{
> >>> +    return 0;
> >>> +}
> >>> +
> >>> +static int bar_ignore_access(const struct pci_dev *pdev, unsigned int reg,
> >>> +                             struct vpci_bar *bar)
> >>> +{
> >>> +    if ( is_hardware_domain(pdev->domain) )
> >>> +        return 0;
> >>> +
> >>> +    return vpci_add_register(pdev->vpci, guest_bar_ignore_read, NULL,
> >>> +                             reg, 4, bar);
> >>> +}
> >> For these two functions: I'm not sure "ignore" is an appropriate
> >> term here. unused_bar_read() and unused_bar() maybe? Or,
> >> considering we already have VPCI_BAR_EMPTY, s/unused/empty/ ? I'm
> >> also not sure we really need the is_hardware_domain() check here:
> >> Returning 0 for Dom0 is going to be fine as well; there's no need
> >> to fetch the value from actual hardware. The one exception might
> >> be for devices with buggy BAR behavior ...
> > Well, I think this should be ok, so then
> > - s/guest_bar_ignore_read/empty_bar_read
> > - s/bar_ignore_access/empty_bar
> 
> Hmm, seeing it, I don't think empty_bar() is a good function name.
> setup_empty_bar() or empty_bar_setup() would make more clear what
> the function's purpose is.

I don't think you require an empty_bar_setup helper, the code there is
trivial can be open coded in init_bars directly IMO.

> 
> > - no is_hardware_domain check
> 
> Please wait a little to see whether Roger has any input on this aspect.

I think for the hw domain we should allow access to the BAR even if Xen
has found it empty. Adding the ignore handlers for dom0 shouldn't make
any difference, but we never know whether some quirky hardware could
make use of that.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 09:31:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 09:31:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267855.461610 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHMqk-0006da-OI; Tue, 08 Feb 2022 09:31:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267855.461610; Tue, 08 Feb 2022 09:31:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHMqk-0006dT-L5; Tue, 08 Feb 2022 09:31:50 +0000
Received: by outflank-mailman (input) for mailman id 267855;
 Tue, 08 Feb 2022 09:31:50 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1FiY=SX=epam.com=prvs=40383cc40e=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nHMqj-0006dL-S9
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 09:31:49 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id efcb9308-88c1-11ec-8f75-fffcc8bd4f1a;
 Tue, 08 Feb 2022 10:31:48 +0100 (CET)
Received: from pps.filterd (m0174682.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 2187rTod012298;
 Tue, 8 Feb 2022 09:31:43 GMT
Received: from eur04-vi1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2051.outbound.protection.outlook.com [104.47.14.51])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3e3mh50et9-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Tue, 08 Feb 2022 09:31:43 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by DB7PR03MB4331.eurprd03.prod.outlook.com (2603:10a6:10:23::14) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Tue, 8 Feb
 2022 09:31:37 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77%3]) with mapi id 15.20.4951.019; Tue, 8 Feb 2022
 09:31:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: efcb9308-88c1-11ec-8f75-fffcc8bd4f1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=QE6Sf8YRMbCw+/t029QYqzd03pbmTPIXp6wrIBqdnA0v6E0l5UjIMo/MuZ6vvhj0Ocg55vyD5oEUygFag9o2RWnR8y3cAEIQG4Kg6GLEqHMre9MhjDehhNdyt5axPS8yRfl847IdXbC6BWeEEfM9s+ikDipDrzx+kU+sxKy/pcr4EboSXmt7rWfNPOp31Jqh/j6QplIYM/ZpkZhg7DRthqORzPevho4003SoVgpyDb/lzZJozN5toMuTozutCR/atSEOdinjY1lay9F6qxiaEncx0RDXiJnSZB2SlaBtCfdZJp/2aC21+hEUOZbr+aZljYQ+Pxb0T9W3WcTOTIduFw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=UwFh837abhIqJJakuU1HploUDshY7oxKC3GB9UXIqKg=;
 b=MFcnB6Z00g6ej6+qLETiM0ZAZPa0qOkZtypo0yCgpqlnGFKH39/XxkMRfQCTDyMETYHyZt3T0rTSEl0J8twMyP64Gs4JxYcr+51owLfryfBE1lTCtU2Op5g+LlbkBlEWmOEH6oe7dlhHYnrJYC+5eioXztXRi/tV5g7K1r57EhbvN+lOAoGfvsgzmyQP7Vqh3XWurvKLs4Sp0oW/8VRDjcpZSCL20076aOZ9UI8PiwzLF8iH9P48jeqrr9KBzfznTtj3jvJzoseaQjxBJb31DHkRsjPKyVHKTM7XpHe/XtTtu1S1PYdWlqWZYc20eJkTOxZhDucpTSO4QqhqwXeqmw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=UwFh837abhIqJJakuU1HploUDshY7oxKC3GB9UXIqKg=;
 b=KcUjxqdfiK6223FsGelP2jxXA0PQ0Q/OIg6k6rcoGX1qodHgICEQPb87bZM6abDSgK7sgQCmoHPXvAiXBPgf4zYNchT1U35VofBt68vVvdVLRnRZuOkFVkQbIfUv1g+H75YoobxkrpM52k4NV28lI2ysZigD4unN4FRZnX7b6X+fkXPkZ0YC0K+BDvyjwEyXLQD/BLln7xF/SZwaRrldy4PDFXfzuJdrRLP6AW8ob9CosYr/Lao1Edw7bNLMto4r8UjIZV6jkheEr0ih7ZhgryyHBCHPZFEuVRGcMZnxpXSj+eTkaeVe8JLg9f+rdGC8kAvK1/xbQwkcudIo7uUyIQ==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "jbeulich@suse.com" <jbeulich@suse.com>,
        "andrew.cooper3@citrix.com"
	<andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com"
	<george.dunlap@citrix.com>,
        "paul@xen.org" <paul@xen.org>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>,
        Rahul Singh <rahul.singh@arm.com>,
        Oleksandr
 Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v6 06/13] vpci/header: implement guest BAR register
 handlers
Thread-Topic: [PATCH v6 06/13] vpci/header: implement guest BAR register
 handlers
Thread-Index: AQHYGZFd6D+qnME8W0+wTH+v8YZ8DayJaJYAgAABnAA=
Date: Tue, 8 Feb 2022 09:31:37 +0000
Message-ID: <498ca523-2642-e35f-b316-0a089f98ca91@epam.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-7-andr2000@gmail.com> <YgI3HpFffudiEmNN@Air-de-Roger>
In-Reply-To: <YgI3HpFffudiEmNN@Air-de-Roger>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 7e8fe79a-6020-4335-85d3-08d9eae5ce17
x-ms-traffictypediagnostic: DB7PR03MB4331:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <DB7PR03MB433109A89A4DE6ED14E74411E72D9@DB7PR03MB4331.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:4502;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 I5mGTdR9hQxfGWG0QFalaMHTgTvcvS6w8r3273HStFMGTEwtBBg+u8NQgR+sMzwAg+OdesaZVZHcZVvxZ+uBOnGwpRClJu+eR9pHYgk9XSTFSW3MK627m81gZlmh19GxcR+stgEsebDXYY33SdjflTwCN0XrU6tClDzIRYaXNMY+/KkrpduCiST7hcreALMQ4gpT4dyzhiCbw6bxovT2PAT3p0LthY6YLI6TqE0TzkxtmgTVTGJDV6DQvnMPRgt0yxZsh6dosHRUneHk1juAyITt8kHL0SAi9ctDccY8mpXD7TIifnaT+11kiUotVCKbivbf3guWXHA4XUNeXgba7RA9c0+TvjT70Dn3lqGEJJFT9EWDLEoWGz7TuI6jW7sjIAfLVOGzk1xbm7XzL/MwpU6W8WPdjKIl26fyFdgys9MtoSIvfGsMu3mPv+FGvqERFs4p3wWIXeUvXuOWpJO9ImiKzg04uREjEEI+2uqce54zwUr3A1fnWxlYnCfhgeKyxYcdapx6dvMmuG+z57Evx+C9yHMnsJEbwIysRBC2k4eM07vbl+aIWBeCSOJYwmhuTQdIdX1fDX9c/eoN4tF4YoLV5vo4jaGtupeJV2lvdMvA8Kwpf+sViz9NGJ+0smy794TVKfulWTQbbAWTtkl8x/D7PB6FwIrieHsd9a85KD0eQ8MSeGdFEoTbay3Y1wAPC+j5XsnrmcU7WGzr41/cGTA/TB669vWZdDbzEAhFYlaOmF9i4GkNtIPu4k0Z/IFA
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(83380400001)(26005)(122000001)(316002)(53546011)(31686004)(36756003)(6512007)(107886003)(55236004)(2906002)(2616005)(508600001)(4326008)(38070700005)(7416002)(6916009)(8936002)(66446008)(54906003)(6486002)(71200400001)(66946007)(5660300002)(86362001)(66556008)(91956017)(38100700002)(76116006)(66476007)(64756008)(8676002)(186003)(6506007)(31696002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?dGd1RGZxWXluNFpIdUVHMGZJaFk0WHBxeDloaFhMS28yZVFKSFVNUmFxSXps?=
 =?utf-8?B?NjFIOXQ2eWFTcDBkR21JK1N0WElRNXBFSjBBWTRuSW1kOER4NjVwWEFadExE?=
 =?utf-8?B?V1VST1BYdkRadE5yNDhCYU9BTC9FZ3lGcXlSOG8vTHVRaEszakg0QXdyejAw?=
 =?utf-8?B?SkZQOXR4Y2JKQ3plMTM3ZWhubURiZHNnOWcyT295Unp3NTVsdVVHSzg2NWxZ?=
 =?utf-8?B?WTE5TkJRMWl0SXBlMzBKUDBiaEpIODF0ZUIwOFlNd0N4cUxRd3hiaUtxNGZT?=
 =?utf-8?B?Q1hzckFTNGRybkRXeWczK1FFSmpPVXRzUEkzYTFSYnNyUGJwelhQbW8reTlC?=
 =?utf-8?B?ZVpwRnBPSi9adzRyRlFUVlRXNlBZMHArYUJad2M0U1MxejVyaSs1YjR4ZmZJ?=
 =?utf-8?B?Y1N4VUN6YlhyZHpRSWJYY1JNSk5jVXFtd2VaVVMxQlZPcDNUMzlya01jRjNp?=
 =?utf-8?B?Mi9VdDdUTEF4YlRYREh0TFRxZjRMVjdFT0pxNlh3SkNDRS9XMjNybGlGaXJE?=
 =?utf-8?B?ZGxzMUxDYTZma0N5czVEckEwa0ZRNXE4MUFuU053aW9qM2VKd1BDT0psRVlo?=
 =?utf-8?B?SWk2NkxpZUhMSXdNV1JWUFd2SHFReXVwNjVPU0VzSFhiTXFHRnNXQkRxN2Vl?=
 =?utf-8?B?YTdKcWlRMm1ieDF3cUhZK0NIeVpvdDBwN2EyaE9aVmFZVWp1QVVqbSthcWFO?=
 =?utf-8?B?YVhoVDlxaDhnTEt5OCthbGNKVGxaUlg0YkFydmRuU1F6ZkFCQndsTGpoTitY?=
 =?utf-8?B?M0x2YjB4WHE1K1NIZU1CTGxVS1djc2I5Mmw5ZmxiTnZRNHExN1phZ29XMDNO?=
 =?utf-8?B?RFVrS1pwQUYweHd2eW9aLzduVCs2aUE5N3ZkVTlhaXFPcms2UGQ0TzJrMDBm?=
 =?utf-8?B?V09tMkxFMlpORWNSNEd0MkR2MC9aNVNGUUxnaUJJZXNBc1c1bjU0QS9RWmsw?=
 =?utf-8?B?dTk2cmc3cURUaDBHc0dHMGNyVDJob3Y0eElOdVJveWJqK2xUUEM5YnZLRitQ?=
 =?utf-8?B?bzYvWTJ4OGlpOXFyVUZhL05pa254MmRIcUhnbWZ6VGYwVVJ6SGVqTHh0TEtU?=
 =?utf-8?B?b1RnNlZua0UyRVNLN2RLWGkwUFpMVE50R3k1bTFwcVZXVk8zY3h2c0E1b3JX?=
 =?utf-8?B?UjhoYXd5WlE1T012Njk0U25ENlo5NUlqSjNsVzJtTWpaQjhuYndyQ3grMWt1?=
 =?utf-8?B?bXI0LzJmOThweUJBbjMwU0J2YjJNTU5KYy9NUngzQVljMGhTV0lpc0NSWVhG?=
 =?utf-8?B?ZXY5L29XRWxjdXdxSndPT2lrL3NoVlUyM3BZamJGUm5VcmZIRXBmek8rRGlT?=
 =?utf-8?B?MkZqR0V4aFBIeWsyOUlodUdTZ1E3aStvRDhUTndhTWtpbGUwZmgxdHp6WENZ?=
 =?utf-8?B?RTdnSk5DRlBCRW5XZEtDKzRnVFNNZkd1MVdEdlVIRzhCTTlDYy9PR0ZGaUNV?=
 =?utf-8?B?QTZRZUhsTUhoVTI2aEpWemlqa2VONXlhdm9QMTFwRjVkeElGanlXM3BKUnE3?=
 =?utf-8?B?cEprWUtMbzI5MTBybHQ2eVlKc1JoZUdQRzBDK3hSeG1NVlc4SGM3WVZSc2Vk?=
 =?utf-8?B?SXZsZDdWKzIrd2psMHBIYTZlOGo1cGhmS3lCemdWQnFZR3NPUEluUXVsZklE?=
 =?utf-8?B?bWExb0IxeDBGZWVLMjg0SnZHdm9rZk5YbTUrUVVkdjhLdkRpQUlyc1FqZCtK?=
 =?utf-8?B?U0RSQjlmeTNtdzNIMmlFUXNLdEFPdjRUM0ovNmJWZWU4a0xreWxVcW5wejhK?=
 =?utf-8?B?RVNHcDc2dlAvQTdxanF5NkVpZE9aMGNKdXg3NjYvQnk3Z2FoRGN4S2w4czNR?=
 =?utf-8?B?TXlIcWRacWNpVVBvL1hVWW5oVzdvVnNReFVveXVGRkpVbUo2cXlSdTdSN0o5?=
 =?utf-8?B?K3RpVmFFWFRCbEhQaGN4SmtEWHhnOGFtL3JMQWp4OGFnbkJUbWxGdSsxR0Qv?=
 =?utf-8?B?WnY3UmJCRGFJaks2Ukh1eHBEVTc3dVVBb002MUMzSG5HWUxvNDRNdkJYaGlR?=
 =?utf-8?B?eERCRGE2RWtuY2YvNDh3alhxQndOSkZCbThhdTNRNUoxMUQxS1NrTnhwTWxS?=
 =?utf-8?B?ZjNJSlBLbGtwM3IvOTF6Y2M1TXVnd3JRTkpjMFJOanAwaGwyRU9QMmREM0tJ?=
 =?utf-8?B?Y29OU05jWUhPNW03NUZtc0o1dlBESEJFS1lBNUEyVDhWRHFDUGNJV0RQWGpY?=
 =?utf-8?B?SWdhQ0RXMXU2RXFYM0I0bFBlK1A5T3hLTGQza2VPWkorNnZ4WjRtT1JnL1cx?=
 =?utf-8?B?c2t4RVpwTWJaN1lOZHd4enQvaXp4UUJnWDg2K0FkT05RbG4wbFdwTzdFNkVR?=
 =?utf-8?B?emhCaXcrR25laWY4cVhrYTJZZDdQdkpIU3M4ek9uSjNJZWUvanc4dk5VYlhr?=
 =?utf-8?Q?Jg1dEtJP4048JGR8=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <4150A19D8E74364CA9A280894A5DDD3A@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7e8fe79a-6020-4335-85d3-08d9eae5ce17
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2022 09:31:37.3350
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: rmsFCEaxP3JPuyNzAGsiiPA9zq3f1qPuS2SGUqWmZadRUJaeRe1nUqNhw3nDf54AKQrkkGjXxn+4/dl20sEzOIgCnT7Iv2oMMgewI1+iL6fTM7a4Z8J/2PUMMQjAFEY4
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR03MB4331
X-Proofpoint-ORIG-GUID: xRBPKWbAxXTc4lFSAi8SHIq9COKns3h4
X-Proofpoint-GUID: xRBPKWbAxXTc4lFSAi8SHIq9COKns3h4
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-08_02,2022-02-07_02,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 lowpriorityscore=0
 suspectscore=0 bulkscore=0 malwarescore=0 clxscore=1015 phishscore=0
 spamscore=0 impostorscore=0 adultscore=0 mlxlogscore=999
 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202080053

DQoNCk9uIDA4LjAyLjIyIDExOjI1LCBSb2dlciBQYXUgTW9ubsOpIHdyb3RlOg0KPiBPbiBGcmks
IEZlYiAwNCwgMjAyMiBhdCAwODozNDo1MkFNICswMjAwLCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5r
byB3cm90ZToNCj4+IEZyb206IE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIDxvbGVrc2FuZHJfYW5k
cnVzaGNoZW5rb0BlcGFtLmNvbT4NCj4+DQo+PiBBZGQgcmVsZXZhbnQgdnBjaSByZWdpc3RlciBo
YW5kbGVycyB3aGVuIGFzc2lnbmluZyBQQ0kgZGV2aWNlIHRvIGEgZG9tYWluDQo+PiBhbmQgcmVt
b3ZlIHRob3NlIHdoZW4gZGUtYXNzaWduaW5nLiBUaGlzIGFsbG93cyBoYXZpbmcgZGlmZmVyZW50
DQo+PiBoYW5kbGVycyBmb3IgZGlmZmVyZW50IGRvbWFpbnMsIGUuZy4gaHdkb20gYW5kIG90aGVy
IGd1ZXN0cy4NCj4+DQo+PiBFbXVsYXRlIGd1ZXN0IEJBUiByZWdpc3RlciB2YWx1ZXM6IHRoaXMg
YWxsb3dzIGNyZWF0aW5nIGEgZ3Vlc3Qgdmlldw0KPj4gb2YgdGhlIHJlZ2lzdGVycyBhbmQgZW11
bGF0ZXMgc2l6ZSBhbmQgcHJvcGVydGllcyBwcm9iZSBhcyBpdCBpcyBkb25lDQo+PiBkdXJpbmcg
UENJIGRldmljZSBlbnVtZXJhdGlvbiBieSB0aGUgZ3Vlc3QuDQo+Pg0KPj4gQWxsIGVtcHR5LCBJ
TyBhbmQgUk9NIEJBUnMgZm9yIGd1ZXN0cyBhcmUgZW11bGF0ZWQgYnkgcmV0dXJuaW5nIDAgb24N
Cj4+IHJlYWRzIGFuZCBpZ25vcmluZyB3cml0ZXM6IHRoaXMgQkFScyBhcmUgc3BlY2lhbCB3aXRo
IHRoaXMgcmVzcGVjdCBhcw0KPj4gdGhlaXIgbG93ZXIgYml0cyBoYXZlIHNwZWNpYWwgbWVhbmlu
Zywgc28gcmV0dXJuaW5nIGRlZmF1bHQgfjAgb24gcmVhZA0KPj4gbWF5IGNvbmZ1c2UgZ3Vlc3Qg
T1MuDQo+Pg0KPj4gTWVtb3J5IGRlY29kaW5nIGlzIGluaXRpYWxseSBkaXNhYmxlZCB3aGVuIHVz
ZWQgYnkgZ3Vlc3RzIGluIG9yZGVyIHRvDQo+PiBwcmV2ZW50IHRoZSBCQVIgYmVpbmcgcGxhY2Vk
IG9uIHRvcCBvZiBhIFJBTSByZWdpb24uDQo+Pg0KPj4gU2lnbmVkLW9mZi1ieTogT2xla3NhbmRy
IEFuZHJ1c2hjaGVua28gPG9sZWtzYW5kcl9hbmRydXNoY2hlbmtvQGVwYW0uY29tPg0KPj4gLS0t
DQo+PiBTaW5jZSB2NToNCj4+IC0gbWFrZSBzdXJlIHRoYXQgdGhlIGd1ZXN0IHNldCBhZGRyZXNz
IGhhcyB0aGUgc2FtZSBwYWdlIG9mZnNldA0KPj4gICAgYXMgdGhlIHBoeXNpY2FsIGFkZHJlc3Mg
b24gdGhlIGhvc3QNCj4+IC0gcmVtb3ZlIGd1ZXN0X3JvbV97cmVhZHx3cml0ZX0gYXMgdGhvc2Ug
anVzdCBpbXBsZW1lbnQgdGhlIGRlZmF1bHQNCj4+ICAgIGJlaGF2aW91ciBvZiB0aGUgcmVnaXN0
ZXJzIG5vdCBiZWluZyBoYW5kbGVkDQo+PiAtIGFkanVzdGVkIGNvbW1lbnQgZm9yIHN0cnVjdCB2
cGNpLmFkZHIgZmllbGQNCj4+IC0gYWRkIGd1ZXN0IGhhbmRsZXJzIGZvciBCQVJzIHdoaWNoIGFy
ZSBub3QgaGFuZGxlZCBhbmQgd2lsbCBvdGhlcndpc2UNCj4+ICAgIHJldHVybiB+MCBvbiByZWFk
IGFuZCBpZ25vcmUgd3JpdGVzLiBUaGUgQkFScyBhcmUgc3BlY2lhbCB3aXRoIHRoaXMNCj4+ICAg
IHJlc3BlY3QgYXMgdGhlaXIgbG93ZXIgYml0cyBoYXZlIHNwZWNpYWwgbWVhbmluZywgc28gcmV0
dXJuaW5nIH4wDQo+PiAgICBkb2Vzbid0IHNlZW0gdG8gYmUgcmlnaHQNCj4+IFNpbmNlIHY0Og0K
Pj4gLSB1cGRhdGVkIGNvbW1pdCBtZXNzYWdlDQo+PiAtIHMvZ3Vlc3RfYWRkci9ndWVzdF9yZWcN
Cj4+IFNpbmNlIHYzOg0KPj4gLSBzcXVhc2hlZCB0d28gcGF0Y2hlczogZHluYW1pYyBhZGQvcmVt
b3ZlIGhhbmRsZXJzIGFuZCBndWVzdCBCQVINCj4+ICAgIGhhbmRsZXIgaW1wbGVtZW50YXRpb24N
Cj4+IC0gZml4IGd1ZXN0IEJBUiByZWFkIG9mIHRoZSBoaWdoIHBhcnQgb2YgYSA2NGJpdCBCQVIg
KFJvZ2VyKQ0KPj4gLSBhZGQgZXJyb3IgaGFuZGxpbmcgdG8gdnBjaV9hc3NpZ25fZGV2aWNlDQo+
PiAtIHMvZG9tJXBkLyVwZA0KPj4gLSBibGFuayBsaW5lIGJlZm9yZSByZXR1cm4NCj4+IFNpbmNl
IHYyOg0KPj4gLSByZW1vdmUgdW5uZWVkZWQgaWZkZWZzIGZvciBDT05GSUdfSEFTX1ZQQ0lfR1VF
U1RfU1VQUE9SVCBhcyBtb3JlIGNvZGUNCj4+ICAgIGhhcyBiZWVuIGVsaW1pbmF0ZWQgZnJvbSBi
ZWluZyBidWlsdCBvbiB4ODYNCj4+IFNpbmNlIHYxOg0KPj4gICAtIGNvbnN0aWZ5IHN0cnVjdCBw
Y2lfZGV2IHdoZXJlIHBvc3NpYmxlDQo+PiAgIC0gZG8gbm90IG9wZW4gY29kZSBpc19zeXN0ZW1f
ZG9tYWluKCkNCj4+ICAgLSBzaW1wbGlmeSBzb21lIGNvZGUzLiBzaW1wbGlmeQ0KPj4gICAtIHVz
ZSBnZHByaW50ayArIGVycm9yIGNvZGUgaW5zdGVhZCBvZiBncHJpbnRrDQo+PiAgIC0gZ2F0ZSB2
cGNpX2Jhcl97YWRkfHJlbW92ZX1faGFuZGxlcnMgd2l0aCBDT05GSUdfSEFTX1ZQQ0lfR1VFU1Rf
U1VQUE9SVCwNCj4+ICAgICBzbyB0aGVzZSBkbyBub3QgZ2V0IGNvbXBpbGVkIGZvciB4ODYNCj4+
ICAgLSByZW1vdmVkIHVubmVlZGVkIGlzX3N5c3RlbV9kb21haW4gY2hlY2sNCj4+ICAgLSByZS13
b3JrIGd1ZXN0IHJlYWQvd3JpdGUgdG8gYmUgbXVjaCBzaW1wbGVyIGFuZCBkbyBtb3JlIHdvcmsg
b24gd3JpdGUNCj4+ICAgICB0aGFuIHJlYWQgd2hpY2ggaXMgZXhwZWN0ZWQgdG8gYmUgY2FsbGVk
IG1vcmUgZnJlcXVlbnRseQ0KPj4gICAtIHJlbW92ZWQgb25lIHRvbyBvYnZpb3VzIGNvbW1lbnQN
Cj4+IC0tLQ0KPj4gICB4ZW4vZHJpdmVycy92cGNpL2hlYWRlci5jIHwgMTMxICsrKysrKysrKysr
KysrKysrKysrKysrKysrKysrKysrKy0tLS0tDQo+PiAgIHhlbi9pbmNsdWRlL3hlbi92cGNpLmgg
ICAgfCAgIDMgKw0KPj4gICAyIGZpbGVzIGNoYW5nZWQsIDExOCBpbnNlcnRpb25zKCspLCAxNiBk
ZWxldGlvbnMoLSkNCj4+DQo+PiBkaWZmIC0tZ2l0IGEveGVuL2RyaXZlcnMvdnBjaS9oZWFkZXIu
YyBiL3hlbi9kcml2ZXJzL3ZwY2kvaGVhZGVyLmMNCj4+IGluZGV4IGJkMjNjMDI3NGQ0OC4uMjYy
MGE5NWZmMzViIDEwMDY0NA0KPj4gLS0tIGEveGVuL2RyaXZlcnMvdnBjaS9oZWFkZXIuYw0KPj4g
KysrIGIveGVuL2RyaXZlcnMvdnBjaS9oZWFkZXIuYw0KPj4gQEAgLTQwNiw2ICs0MDYsODEgQEAg
c3RhdGljIHZvaWQgYmFyX3dyaXRlKGNvbnN0IHN0cnVjdCBwY2lfZGV2ICpwZGV2LCB1bnNpZ25l
ZCBpbnQgcmVnLA0KPj4gICAgICAgcGNpX2NvbmZfd3JpdGUzMihwZGV2LT5zYmRmLCByZWcsIHZh
bCk7DQo+PiAgIH0NCj4+ICAgDQo+PiArc3RhdGljIHZvaWQgZ3Vlc3RfYmFyX3dyaXRlKGNvbnN0
IHN0cnVjdCBwY2lfZGV2ICpwZGV2LCB1bnNpZ25lZCBpbnQgcmVnLA0KPj4gKyAgICAgICAgICAg
ICAgICAgICAgICAgICAgICB1aW50MzJfdCB2YWwsIHZvaWQgKmRhdGEpDQo+PiArew0KPj4gKyAg
ICBzdHJ1Y3QgdnBjaV9iYXIgKmJhciA9IGRhdGE7DQo+PiArICAgIGJvb2wgaGkgPSBmYWxzZTsN
Cj4+ICsgICAgdWludDY0X3QgZ3Vlc3RfcmVnID0gYmFyLT5ndWVzdF9yZWc7DQo+PiArDQo+PiAr
ICAgIGlmICggYmFyLT50eXBlID09IFZQQ0lfQkFSX01FTTY0X0hJICkNCj4+ICsgICAgew0KPj4g
KyAgICAgICAgQVNTRVJUKHJlZyA+IFBDSV9CQVNFX0FERFJFU1NfMCk7DQo+PiArICAgICAgICBi
YXItLTsNCj4+ICsgICAgICAgIGhpID0gdHJ1ZTsNCj4+ICsgICAgfQ0KPj4gKyAgICBlbHNlDQo+
PiArICAgIHsNCj4+ICsgICAgICAgIHZhbCAmPSBQQ0lfQkFTRV9BRERSRVNTX01FTV9NQVNLOw0K
Pj4gKyAgICAgICAgdmFsIHw9IGJhci0+dHlwZSA9PSBWUENJX0JBUl9NRU0zMiA/IFBDSV9CQVNF
X0FERFJFU1NfTUVNX1RZUEVfMzINCj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgOiBQQ0lfQkFTRV9BRERSRVNTX01FTV9UWVBFXzY0Ow0KPj4gKyAgICAgICAg
dmFsIHw9IGJhci0+cHJlZmV0Y2hhYmxlID8gUENJX0JBU0VfQUREUkVTU19NRU1fUFJFRkVUQ0gg
OiAwOw0KPj4gKyAgICB9DQo+PiArDQo+PiArICAgIGd1ZXN0X3JlZyAmPSB+KDB4ZmZmZmZmZmZ1
bGwgPDwgKGhpID8gMzIgOiAwKSk7DQo+PiArICAgIGd1ZXN0X3JlZyB8PSAodWludDY0X3QpdmFs
IDw8IChoaSA/IDMyIDogMCk7DQo+PiArDQo+PiArICAgIGd1ZXN0X3JlZyAmPSB+KGJhci0+c2l6
ZSAtIDEpIHwgflBDSV9CQVNFX0FERFJFU1NfTUVNX01BU0s7DQo+PiArDQo+PiArICAgIC8qDQo+
PiArICAgICAqIE1ha2Ugc3VyZSB0aGF0IHRoZSBndWVzdCBzZXQgYWRkcmVzcyBoYXMgdGhlIHNh
bWUgcGFnZSBvZmZzZXQNCj4+ICsgICAgICogYXMgdGhlIHBoeXNpY2FsIGFkZHJlc3Mgb24gdGhl
IGhvc3Qgb3Igb3RoZXJ3aXNlIHRoaW5ncyB3b24ndCB3b3JrIGFzDQo+PiArICAgICAqIGV4cGVj
dGVkLg0KPj4gKyAgICAgKi8NCj4+ICsgICAgaWYgKCAoZ3Vlc3RfcmVnICYgKH5QQUdFX01BU0sg
JiBQQ0lfQkFTRV9BRERSRVNTX01FTV9NQVNLKSkgIT0NCj4+ICsgICAgICAgICAoYmFyLT5hZGRy
ICYgflBBR0VfTUFTSykgKQ0KPiBUaGlzIGlzIG9ubHkgcmVxdWlyZWQgd2hlbiAhaGksIGJ1dCBJ
J20gZmluZSB3aXRoIGRvaW5nIGl0DQo+IHVuY29uZGl0aW9uYWxseSBhcyBpdCdzIGNsZWFyZXIu
DQpUaGlzIGlzIGNvcnJlY3Qgd3J0IGhpDQo+DQo+PiArICAgIHsNCj4+ICsgICAgICAgIGdwcmlu
dGsoWEVOTE9HX1dBUk5JTkcsDQo+PiArICAgICAgICAgICAgICAgICIlcHA6IGlnbm9yZWQgQkFS
ICV6dSB3cml0ZSB3aXRoIHdyb25nIHBhZ2Ugb2Zmc2V0XG4iLA0KPiAiJXBwOiBpZ25vcmVkIEJB
UiAlenUgd3JpdGUgYXR0ZW1wdGluZyB0byBjaGFuZ2UgcGFnZSBvZmZzZXRcbiINCk9rDQo+DQo+
PiArICAgICAgICAgICAgICAgICZwZGV2LT5zYmRmLCBiYXIgLSBwZGV2LT52cGNpLT5oZWFkZXIu
YmFycyArIGhpKTsNCj4+ICsgICAgICAgIHJldHVybjsNCj4+ICsgICAgfQ0KPj4gKw0KPj4gKyAg
ICBiYXItPmd1ZXN0X3JlZyA9IGd1ZXN0X3JlZzsNCj4+ICt9DQo+PiArDQo+PiArc3RhdGljIHVp
bnQzMl90IGd1ZXN0X2Jhcl9yZWFkKGNvbnN0IHN0cnVjdCBwY2lfZGV2ICpwZGV2LCB1bnNpZ25l
ZCBpbnQgcmVnLA0KPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB2b2lkICpkYXRh
KQ0KPj4gK3sNCj4+ICsgICAgY29uc3Qgc3RydWN0IHZwY2lfYmFyICpiYXIgPSBkYXRhOw0KPj4g
KyAgICBib29sIGhpID0gZmFsc2U7DQo+PiArDQo+PiArICAgIGlmICggYmFyLT50eXBlID09IFZQ
Q0lfQkFSX01FTTY0X0hJICkNCj4+ICsgICAgew0KPj4gKyAgICAgICAgQVNTRVJUKHJlZyA+IFBD
SV9CQVNFX0FERFJFU1NfMCk7DQo+PiArICAgICAgICBiYXItLTsNCj4+ICsgICAgICAgIGhpID0g
dHJ1ZTsNCj4+ICsgICAgfQ0KPj4gKw0KPj4gKyAgICByZXR1cm4gYmFyLT5ndWVzdF9yZWcgPj4g
KGhpID8gMzIgOiAwKTsNCj4+ICt9DQo+PiArDQo+PiArc3RhdGljIHVpbnQzMl90IGd1ZXN0X2Jh
cl9pZ25vcmVfcmVhZChjb25zdCBzdHJ1Y3QgcGNpX2RldiAqcGRldiwNCj4+ICsgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGludCByZWcsIHZvaWQgKmRhdGEp
DQo+PiArew0KPj4gKyAgICByZXR1cm4gMDsNCj4+ICt9DQo+PiArDQo+PiArc3RhdGljIGludCBi
YXJfaWdub3JlX2FjY2Vzcyhjb25zdCBzdHJ1Y3QgcGNpX2RldiAqcGRldiwgdW5zaWduZWQgaW50
IHJlZywNCj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0cnVjdCB2cGNpX2JhciAq
YmFyKQ0KPj4gK3sNCj4+ICsgICAgaWYgKCBpc19oYXJkd2FyZV9kb21haW4ocGRldi0+ZG9tYWlu
KSApDQo+PiArICAgICAgICByZXR1cm4gMDsNCj4+ICsNCj4+ICsgICAgcmV0dXJuIHZwY2lfYWRk
X3JlZ2lzdGVyKHBkZXYtPnZwY2ksIGd1ZXN0X2Jhcl9pZ25vcmVfcmVhZCwgTlVMTCwNCj4+ICsg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJlZywgNCwgYmFyKTsNCj4+ICt9DQo+PiArDQo+
PiAgIHN0YXRpYyB2b2lkIHJvbV93cml0ZShjb25zdCBzdHJ1Y3QgcGNpX2RldiAqcGRldiwgdW5z
aWduZWQgaW50IHJlZywNCj4+ICAgICAgICAgICAgICAgICAgICAgICAgIHVpbnQzMl90IHZhbCwg
dm9pZCAqZGF0YSkNCj4+ICAgew0KPj4gQEAgLTQ2Miw2ICs1MzcsNyBAQCBzdGF0aWMgaW50IGlu
aXRfYmFycyhzdHJ1Y3QgcGNpX2RldiAqcGRldikNCj4+ICAgICAgIHN0cnVjdCB2cGNpX2hlYWRl
ciAqaGVhZGVyID0gJnBkZXYtPnZwY2ktPmhlYWRlcjsNCj4+ICAgICAgIHN0cnVjdCB2cGNpX2Jh
ciAqYmFycyA9IGhlYWRlci0+YmFyczsNCj4+ICAgICAgIGludCByYzsNCj4+ICsgICAgYm9vbCBp
c19od2RvbSA9IGlzX2hhcmR3YXJlX2RvbWFpbihwZGV2LT5kb21haW4pOw0KPj4gICANCj4+ICAg
ICAgIHN3aXRjaCAoIHBjaV9jb25mX3JlYWQ4KHBkZXYtPnNiZGYsIFBDSV9IRUFERVJfVFlQRSkg
JiAweDdmICkNCj4+ICAgICAgIHsNCj4+IEBAIC01MDEsOCArNTc3LDEwIEBAIHN0YXRpYyBpbnQg
aW5pdF9iYXJzKHN0cnVjdCBwY2lfZGV2ICpwZGV2KQ0KPj4gICAgICAgICAgIGlmICggaSAmJiBi
YXJzW2kgLSAxXS50eXBlID09IFZQQ0lfQkFSX01FTTY0X0xPICkNCj4+ICAgICAgICAgICB7DQo+
PiAgICAgICAgICAgICAgIGJhcnNbaV0udHlwZSA9IFZQQ0lfQkFSX01FTTY0X0hJOw0KPj4gLSAg
ICAgICAgICAgIHJjID0gdnBjaV9hZGRfcmVnaXN0ZXIocGRldi0+dnBjaSwgdnBjaV9od19yZWFk
MzIsIGJhcl93cml0ZSwgcmVnLA0KPj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgNCwgJmJhcnNbaV0pOw0KPj4gKyAgICAgICAgICAgIHJjID0gdnBjaV9hZGRfcmVnaXN0ZXIo
cGRldi0+dnBjaSwNCj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGlzX2h3
ZG9tID8gdnBjaV9od19yZWFkMzIgOiBndWVzdF9iYXJfcmVhZCwNCj4+ICsgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgIGlzX2h3ZG9tID8gYmFyX3dyaXRlIDogZ3Vlc3RfYmFyX3dy
aXRlLA0KPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcmVnLCA0LCAmYmFy
c1tpXSk7DQo+PiAgICAgICAgICAgICAgIGlmICggcmMgKQ0KPj4gICAgICAgICAgICAgICB7DQo+
PiAgICAgICAgICAgICAgICAgICBwY2lfY29uZl93cml0ZTE2KHBkZXYtPnNiZGYsIFBDSV9DT01N
QU5ELCBjbWQpOw0KPj4gQEAgLTUxNiw2ICs1OTQsMTEgQEAgc3RhdGljIGludCBpbml0X2JhcnMo
c3RydWN0IHBjaV9kZXYgKnBkZXYpDQo+PiAgICAgICAgICAgaWYgKCAodmFsICYgUENJX0JBU0Vf
QUREUkVTU19TUEFDRSkgPT0gUENJX0JBU0VfQUREUkVTU19TUEFDRV9JTyApDQo+PiAgICAgICAg
ICAgew0KPj4gICAgICAgICAgICAgICBiYXJzW2ldLnR5cGUgPSBWUENJX0JBUl9JTzsNCj4+ICsN
Cj4+ICsgICAgICAgICAgICByYyA9IGJhcl9pZ25vcmVfYWNjZXNzKHBkZXYsIHJlZywgJmJhcnNb
aV0pOw0KPiBUaGlzIGlzIHdyb25nOiB5b3Ugb25seSB3YW50IHRvIGlnbm9yZSBhY2Nlc3MgdG8g
SU8gQkFScyBmb3IgQXJtLCBmb3INCj4geDg2IHdlIHNob3VsZCBrZWVwIHRoZSBwcmV2aW91cyBi
ZWhhdmlvci4gRXZlbiBtb3JlIGlmIHlvdSBnbyB3aXRoDQo+IEphbidzIHN1Z2dlc3Rpb25zIHRv
IG1ha2UgYmFyX2lnbm9yZV9hY2Nlc3MgYWxzbyBhcHBsaWNhYmxlIHRvIGRvbTAuDQpIb3cgZG8g
d2Ugd2FudCB0aGlzPw0KI2lmZGVmIENPTkZJR19BUk0/DQo+DQo+PiArICAgICAgICAgICAgaWYg
KCByYyApDQo+PiArICAgICAgICAgICAgICAgIHJldHVybiByYzsNCj4+ICsNCj4+ICAgICAgICAg
ICAgICAgY29udGludWU7DQo+PiAgICAgICAgICAgfQ0KPj4gICAgICAgICAgIGlmICggKHZhbCAm
IFBDSV9CQVNFX0FERFJFU1NfTUVNX1RZUEVfTUFTSykgPT0NCj4+IEBAIC01MzUsNiArNjE4LDEx
IEBAIHN0YXRpYyBpbnQgaW5pdF9iYXJzKHN0cnVjdCBwY2lfZGV2ICpwZGV2KQ0KPj4gICAgICAg
ICAgIGlmICggc2l6ZSA9PSAwICkNCj4+ICAgICAgICAgICB7DQo+PiAgICAgICAgICAgICAgIGJh
cnNbaV0udHlwZSA9IFZQQ0lfQkFSX0VNUFRZOw0KPj4gKw0KPj4gKyAgICAgICAgICAgIHJjID0g
YmFyX2lnbm9yZV9hY2Nlc3MocGRldiwgcmVnLCAmYmFyc1tpXSk7DQo+PiArICAgICAgICAgICAg
aWYgKCByYyApDQo+PiArICAgICAgICAgICAgICAgIHJldHVybiByYzsNCj4gSSB3b3VsZCBiZSBm
aW5lIHRvIGp1c3QgY2FsbCB2cGNpX2FkZF9yZWdpc3RlciBoZXJlLCBpZTsNCj4NCj4gaWYgKCAh
aXNfaHdkb20gKQ0KPiB7DQo+ICAgICAgcmMgPSB2cGNpX2FkZF9yZWdpc3RlcihwZGV2LT52cGNp
LCBndWVzdF9iYXJfaWdub3JlX3JlYWQsIE5VTEwsDQo+ICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICByZWcsIDQsICZiYXJzW2ldKTsNCj4gICAgICAgaWYgKCByYyApDQo+ICAgICAgIHsNCj4g
ICAgICAgICAgIC4uLg0KPiAgICAgICB9DQo+IH0NCkJ1dCB3ZSBoYXZlIDMgcGxhY2VzIHdoZXJl
IHdlIGRvIHRoZSBzYW1lIGFuZCBhbHNvIGhhbmRsZSBlcnJvcnMNCnRoZSBzYW1lIHdheS4gSSB3
YXMgdGhpbmtpbmcgaGF2aW5nIGEgaGVscGVyIHdpbGwgbWFrZSB0aGUgY29kZQ0KY2xlYXJlci4g
RG8geW91IHdhbnQgdG8gb3BlbiBjb2RlIGFsbCB0aGUgdXNlcz8NCj4gRmVlbCBmcmVlIHRvIHVu
aWZ5IHRoZSB3cml0aW5nIG9mIHRoZSBQQ0lfQ09NTUFORCByZWdpc3RlciBvbiB0aGUNCj4gZXJy
b3IgcGF0aCBpbnRvIGEgbGFiZWwsIGFzIHRoZW4gdGhlIGVycm9yIGNhc2Ugd291bGQgc2ltcGx5
IGJlIGENCj4gYGdvdG8gZXJyb3I7YA0KSSB3YXMgdGhpbmtpbmcgYWJvdXQgaXQuIFdpbGwgaXQg
YmUgb2sgdG8gbWFrZSB0aGlzIGNoYW5nZSBpbiB0aGlzIHBhdGNoDQpvciB5b3Ugd2FudCBhIGRl
ZGljYXRlZCBvbmUgZm9yIHRoYXQ/DQo+IFRoYW5rcywgUm9nZXIuDQpUaGFuayB5b3UsDQpPbGVr
c2FuZHI=


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 09:33:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 09:33:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267863.461621 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHMs9-0007F4-3P; Tue, 08 Feb 2022 09:33:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267863.461621; Tue, 08 Feb 2022 09:33:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHMs9-0007Ex-0C; Tue, 08 Feb 2022 09:33:17 +0000
Received: by outflank-mailman (input) for mailman id 267863;
 Tue, 08 Feb 2022 09:33:15 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=v7zX=SX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nHMs7-0007Er-LD
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 09:33:15 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 236cf222-88c2-11ec-8eb8-a37418f5ba1a;
 Tue, 08 Feb 2022 10:33:14 +0100 (CET)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2052.outbound.protection.outlook.com [104.47.13.52]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-12-_ijVTOsJNry1IYSqVpu3pw-1; Tue, 08 Feb 2022 10:33:12 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM6PR04MB4789.eurprd04.prod.outlook.com (2603:10a6:20b:7::24) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Tue, 8 Feb
 2022 09:33:10 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.018; Tue, 8 Feb 2022
 09:33:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 236cf222-88c2-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644312794;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=8NtR+x77gWihrNvsqTAgKCPMXj8venlJinlwAnEn3+k=;
	b=Ra7L9HYan+AzkiCYc76I/apJFSGkBLdyLdnslRoztG7Z7pJbVdo5sHPKwXTGQPbce3qFZ4
	KfxFOXUClnrRHhQqaYcupeLJeTMgFM3rg9A22d3nKQRQe1BkNYuSlWtSysLficMOkxiJJV
	wlSUsVHiu/P4KHpyc8enIISNdD8a+ZU=
X-MC-Unique: _ijVTOsJNry1IYSqVpu3pw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=P0JlJIJC/Z+FAPXRKP0fN8XZD3Vnbrm015MsoWmidh1V9nJCjU74DQUvk0oZ9oYiadOfErbdT/hGbdKpYhfUX1tKE/bMga7M+FUNPCajypb6sFk2pXOYbK1aPMpRc6PePDZXEfcBVLjHL6ZX3w7U0A9ew/hkVWmWyGjaAo4hHWxrtJgt2eekz/6n9FMS5NJjMoq2CUcbHHUoCu98nK7ZX+nCPnUvMvue80Z2GLzqLZ4w/bqF8Hkg/5TBjwuj6yZ+vBqIJ+XChGLdPbbAyxoHg1D92HBMcgKLrjW3iJZQigDhCACajVE+mabRHhgKFD36NVkqclztD3dxoCj8ceNEbQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=8NtR+x77gWihrNvsqTAgKCPMXj8venlJinlwAnEn3+k=;
 b=aRrda16VqPRaRdBrmQ057gdsk713fQC4Dp7PgtFe6RUd4q/wAMtSMqpwYHdAhb2FsHHe+vTAdFSQZRZwC6m9HW//va6b4KYNWLpsaR0vb7F4uC7WxBIDYwr0TKqrExQcJ8+XiG/XsppFcccgFvQizS6WPhtukBW1YrmIGQy3/G4TV14UDHJtVhcFCmcCPMAjaAYhK2mSUrIPZ9jOsCs7I9tLcrrfZd3rJCz2g25Gn3BL1TlYvIY/4ihiW6Nzxx5cZxSdFTh27PMCwlwLmsUxXIACHZuZlWHFGL/vw+2HO0I6eBF8ZEvesZxB8DSzOotWIuy7bWwWAwLiR+vbXgLPfw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <140e163c-87d0-2ae8-d57b-7ebc6757de9e@suse.com>
Date: Tue, 8 Feb 2022 10:33:08 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v6 09/13] vpci/header: emulate PCI_COMMAND register for
 guests
Content-Language: en-US
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Cc: "julien@xen.org" <julien@xen.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Artem Mygaiev <Artem_Mygaiev@epam.com>,
 "roger.pau@citrix.com" <roger.pau@citrix.com>,
 "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
 "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
 "paul@xen.org" <paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-10-andr2000@gmail.com>
 <7df2379e-1c30-c362-3106-c7ef23af5c73@suse.com>
 <0ff2a524-9a65-861a-df87-cf3f682862d7@epam.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <0ff2a524-9a65-861a-df87-cf3f682862d7@epam.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR2P281CA0030.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:14::17) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5bc01db8-1a3e-4120-8d44-08d9eae6057c
X-MS-TrafficTypeDiagnostic: AM6PR04MB4789:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB478933E3776F6E8276167623B32D9@AM6PR04MB4789.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	KeaRvMzYSqKB0fCWp2Gh8/N5pVFbwZCYKuGGbNQccoMAePG7juJt7sxfun1AD1dIUXNE/7avDtEXmdqZ1HhW0H3J+wHutOR93xhwYvsVmTWpTVbA8Codhzmp6IfjjLGrEj+7wQ1Ji9EFWphN/3mNPSFhcQH1MUcu6nsJTr5mxXz+O5TP+rbohI0phre1VsbsqU/lk5IpGeKdYrFUkLXznBy029K60fXGPN4YiHgzVRh2PBDX0YA5pokZULzqRa4hmYt1oZA4wdg2/GNCN0Uy+xBGBYPAczWbDeaM4J2UJvaGPPCIckqWPR7nTT8m7ALykWleP8otuL/GYJ49gcdUttBZvo6Pw6jROz8EV40OuHdmyhvIOVe3cDVDT/XhSyjY6XWzmtwSP9Nf11b6A5PcY1p0XfZjpm07VtzGSXF5M+aRlxVYm9+ddcC+mAifpAnMC1qvILq4NxBDwogFA8m7oZ/TWZg258VDSKGbn/rXXvczZSzM3sqQJYxdw6DdFkMQvGoVXiDyOZq6WdbyZNz+ftnyzT0aaFYUjGzE6mdyRh5S40HQgxvOdsRKQ4C/NXYsfHUQGVZflaYOC2fMovz7ctAdqjvrUetbBubNnZL3UeorXmvhDnZLaGt5jVckTXv7vGwvbtQbUM9xTP+imQR9wW/TzNWSZP4SVxhP9+bNEapAMt89EXIi2V2bcl15/VIGY13oIAJGREzDZkOXbm8qD9fUKWJ5nvZn/BnOM1+Q4wI=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66556008)(66946007)(26005)(31696002)(186003)(36756003)(4326008)(66476007)(8936002)(8676002)(2616005)(6486002)(508600001)(83380400001)(31686004)(86362001)(53546011)(5660300002)(316002)(54906003)(6506007)(6512007)(7416002)(38100700002)(2906002)(6916009)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?V3FocCtjWDZLL2I2bEp0V05ubUQ5WFRBTUpBTWJMei9POEtGOXo2OC82TU1Z?=
 =?utf-8?B?SDlyREIwZVJ3bkhCVzRRWGxYWHpjeFZYYjNFeWp2Wk9lUWt0VFNXZDNEQ3Np?=
 =?utf-8?B?dGNYcHRmcmFpOVluYVBSRjJGZHpvakxhU1YxTlAxQlZ4czFXbkNwT0tTU3ZT?=
 =?utf-8?B?eFpvSG9lRnQyaVdpbkN3Y0gxeGZjY204eTd0Z2F1ZVZEL2JBMG1qY1pESzI1?=
 =?utf-8?B?NHZGL01qSmtoTy8zTTBnd3VlcS9yRGlIemk3Ty9YVzhPYjZsVFIxNk5VUk1L?=
 =?utf-8?B?ZmZJbFVJR0RqRDhnaXc0bE50ZENCajJETkx1ZEdTUkZycER4MjR5ZndUamo5?=
 =?utf-8?B?MEt0QlQ0MlhUdWozejM2cy9FdXp1UHlZVkFpWEFuMVJZbzQ5dWthZUVoSGJt?=
 =?utf-8?B?SzB0NVB4RFhUaVlXaTZycWRCRDFZanhjaE1ESGhvVEVYbncxWS80cHVLMzcr?=
 =?utf-8?B?QWhGc1ROTHdIOS9LdXpoWWhudFVhZXFhVW9GNmhUbllkRlhLdDVlNVU0YUlp?=
 =?utf-8?B?WWhqcTZsbGFQbmNsUkRYVEhWYnlYbWdoT3hqa1RJS0d4d21oRTdWL0F2blBY?=
 =?utf-8?B?MExyMEdtM2VtV1NEeEtEaW5xV21VSDJSdi8zazJBam5FTXdsbUdkNDJvRmRv?=
 =?utf-8?B?NWc2WW1PZTFUUHAwbFVORkMyN0ZXUWFCMmo2dEZlVitEZnlyWit6WG1oZXpj?=
 =?utf-8?B?bGxFMjNRMDJ3clpLdFA4cjFLT2xWQ0FGamdlZFZQT0FaVzBBNUtRR3BmRkJ5?=
 =?utf-8?B?K2RzenZlMGZ2Z2p2cjhiU1hPci9wMndrRW9rYjZxaEM3b3YzUUVCME9MQmtJ?=
 =?utf-8?B?TGFsWll5dnBpaDVpNklmTGthaW1IWGtkYkQrMEZqbHlSWE5lemlSL3VxbmdP?=
 =?utf-8?B?a0I0U0UwZ1BVSmluajhmZlduVmE2WDFkWlBmaUtCNENaZFdYZXJSbUdwU3o3?=
 =?utf-8?B?dFJZd2VYYUhxVDZIRzZZRWVzKzN2SHFBOUU3VWZQRmlJVVpLM2NjZEJnTzJC?=
 =?utf-8?B?NzFpRGEwS254TG1tdmxaeUswUzIvdmxjamJaRDN5V1dWMjhSeUxGS1VuMGpN?=
 =?utf-8?B?Q2V5clpYenk1M240dkJNdDgwU3MyY0FYMjJmbXVISnJTSkxiQlVlb0tORnRT?=
 =?utf-8?B?RGd5YlFIamUwS3VvcktsYjRmc0RrU254TGVDRzIzaW05eS9Jd1pueTAvbnY0?=
 =?utf-8?B?SnFYZjZtT3V5a05raGVhVStFQmpMdXZsN21RNkpxYnJ5UFZwbUFpYWlJT0JJ?=
 =?utf-8?B?S3pzb294RnRudUxqMU9uMWt6SE05bk9uZ09DQXBuS0dqQ0Mrc1dRY0VZUnd0?=
 =?utf-8?B?VXR0TGx3NGlxRzlMRGZHZHBqeWJhcFMyS0VXT2xoWWx4YW1pRStyOGpXbzNa?=
 =?utf-8?B?cVN1Y1dGN0l5M1JBeEk2aGFQZjNzT2VTVDlHRXBEU243VVd1SnU1WE9hSm5y?=
 =?utf-8?B?ejg2SjA4OG9UZjFyd3pKaTF5WGRwdjROcWJkeXVZaWtHNDY4a09NSllLQits?=
 =?utf-8?B?NXdMblpTUW9tOG5hN2MxTlFDTUthOG83a2xjQzYvUkVud0N3LzRPNHVDRmZl?=
 =?utf-8?B?Y2FSWkpiaG9Qb0Q0c25XMWo5SmNjVFdhcUNzMTJXa2Y4MTFhRHFOSUVsUEg5?=
 =?utf-8?B?Q0R3ZlpTRHhhUVB5a001dXZUWFN1Ni9RWlhyTUZZcG5SWGVxVDgrVzFTelpH?=
 =?utf-8?B?UG44ZXF5MDB4YU9ScXk5eGYrSjVOZUlSV2JCeVlxM3pybEdpKy9ucy9yV2h6?=
 =?utf-8?B?bHY4Z1hpY1J2OTc4clRZM0FiVHlSZVNWYjlQK21qQ3VZRlcvdU01cXpZRGE0?=
 =?utf-8?B?SmZFa3ZYLzVuZ0J1TGwvaERsN1lQMGVrVEpNSE45dndibU8raEdCZVQ1Qjhh?=
 =?utf-8?B?T3BMSHU3T2d5cExKVkZMNWRMaTNUaldxNFdOazdqNG1ibU5LYUN2cGJ2bkdY?=
 =?utf-8?B?YUsxMjJrNDRacVhDMDlFWDFTNkI4SHF6cFBvdXptUHBJYjI3eU9SK3JBRHNl?=
 =?utf-8?B?TEpKRjcxYll4VkZ1bnBzaklOTHQ4M01idUZOckYrcGErdHU4UXEyWXh5SzU4?=
 =?utf-8?B?UjBmYmcvZmY1c1ZFZmVobGd6bVY3WElwOUkzczRtVmNyZW5LTE90TmFDZStP?=
 =?utf-8?B?ODJJZzltWWIyNjE1YnR4Ym5LK2RQeWlEZWhkMWk3WUFEYzdqOHVEU0J3SVpH?=
 =?utf-8?Q?HC7HUE+WhFQrUoQqcyBYb+M=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5bc01db8-1a3e-4120-8d44-08d9eae6057c
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2022 09:33:10.6624
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UF6zjhwLwbkLbbqdCUmBlQRDRBbZHYAN3A+e6zMazXdvxzuOktYrmRFRCuqj1COGWwqc0rjCsUw9Tk4dbapJ6w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4789

On 08.02.2022 09:13, Oleksandr Andrushchenko wrote:
> On 04.02.22 16:25, Jan Beulich wrote:
>> On 04.02.2022 07:34, Oleksandr Andrushchenko wrote:
>>> --- a/xen/drivers/vpci/header.c
>>> +++ b/xen/drivers/vpci/header.c
>>> @@ -454,6 +454,22 @@ static void cmd_write(const struct pci_dev *pdev, unsigned int reg,
>>>           pci_conf_write16(pdev->sbdf, reg, cmd);
>>>   }
>>>   
>>> +static void guest_cmd_write(const struct pci_dev *pdev, unsigned int reg,
>>> +                            uint32_t cmd, void *data)
>>> +{
>>> +    /* TODO: Add proper emulation for all bits of the command register. */
>>> +
>>> +#ifdef CONFIG_HAS_PCI_MSI
>>> +    if ( pdev->vpci->msi->enabled || pdev->vpci->msix->enabled )
>>> +    {
>>> +        /* Guest wants to enable INTx. It can't be enabled if MSI/MSI-X enabled. */
>>> +        cmd |= PCI_COMMAND_INTX_DISABLE;
>>> +    }
>>> +#endif
>>> +
>>> +    cmd_write(pdev, reg, cmd, data);
>>> +}
>> It's not really clear to me whether the TODO warrants this being a
>> separate function. Personally I'd find it preferable if the logic
>> was folded into cmd_write().
> Not sure cmd_write needs to have guest's logic. And what's the
> profit? Later on, when we decide how PCI_COMMAND can be emulated
> this code will live in guest_cmd_write anyways

Why "will"? There's nothing conceptually wrong with putting all the
emulation logic into cmd_write(), inside an if(!hwdom) conditional.
If and when we gain CET-IBT support on the x86 side (and I'm told
there's an Arm equivalent of this), then to make this as useful as
possible it is going to be desirable to limit the number of functions
called through function pointers. You may have seen Andrew's huge
"x86: Support for CET Indirect Branch Tracking" series. We want to
keep down the number of such annotations; the vast part of the series
is about adding of such.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Feb 08 09:38:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 09:38:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267876.461632 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHMxA-0007zG-RY; Tue, 08 Feb 2022 09:38:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267876.461632; Tue, 08 Feb 2022 09:38:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHMxA-0007z9-Nj; Tue, 08 Feb 2022 09:38:28 +0000
Received: by outflank-mailman (input) for mailman id 267876;
 Tue, 08 Feb 2022 09:38:27 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1FiY=SX=epam.com=prvs=40383cc40e=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nHMx9-0007z2-AW
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 09:38:27 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id dc4b713c-88c2-11ec-8eb8-a37418f5ba1a;
 Tue, 08 Feb 2022 10:38:25 +0100 (CET)
Received: from pps.filterd (m0174677.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 2189EEG1015967;
 Tue, 8 Feb 2022 09:38:22 GMT
Received: from eur05-vi1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2170.outbound.protection.outlook.com [104.47.17.170])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e3nq283p5-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Tue, 08 Feb 2022 09:38:21 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM6PR0302MB3287.eurprd03.prod.outlook.com (2603:10a6:209:17::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Tue, 8 Feb
 2022 09:38:16 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77%3]) with mapi id 15.20.4951.019; Tue, 8 Feb 2022
 09:38:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dc4b713c-88c2-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XhNThd0bLD2kIkQjKTt8PzH1IonmlW6xQDENCmmz77vHf6ov4s5uZinhuFSfp8BHIASij3UNj7P6xSYw1xCcw/q7UlCLSh8EFz4fT68bKCzq1b98BfRTucvSY9CV1OTvpBKYb1vaVARxvsI6qX6ESnl74s6v3+cE9jUoRwZTFbFHk7OShZnHB+6SYXblxolyW9kS8fc7ohN7yxG0lG/qSooGy3FXXkuwMOgNkiSG0i9xEfvM4xSHOExxVH9fa/yQBTmfrhNuQSBiLgRAlldeb+8nlC/icPT7qa7iifeybMa1DI1FgMMcYhVvZkb5o8veXVqgsgi1qSrxJt/Rl3FWCg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=PxszTGn+ayGJwVpBYxTK34sEvqohJFthvg0sL1ZQAeE=;
 b=cZswvwg55lxlyoBDaHamR/beiJ10dP/uxqTEmuw7417dOYYUR7vcUzW1zuT8Q3M/s/eEonsykw4PEZhSIKEoM/+kas70g3mNN470HUJs8WffSonNBW82pi7g7STgv613wdYzSvB6s+4+4Mm+kYnjbJFKBtBD3YdrMmZxSebZX/TQ2hetnZdYt4Q8NFlPc8ult/iI3aTPnyeobNNB2YowbLDKMhfEF2BVF52wk7sCe4JwMtT47cOvq6PhEIXep1kMzdEUZoxILgTylu8vhxD6ZUbSaeXjYP94OZ8q1/gsVw4SPJiB7xMO3Iw4DGD4Btph4lSKFzf2Zbf+khMR6I5XGg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=PxszTGn+ayGJwVpBYxTK34sEvqohJFthvg0sL1ZQAeE=;
 b=FeWzLVzDRA/0mW1sWDdKqVQeNnpUA0l8xvY1t9qClXQtq/zYg0mcAC4herqqowDlP7s6dlzTwWkQPIdTDVOYtmDLueC8TLbCzaY7K0v+Xwos7Ul+2ETRmz0Pqa6KicigDt+SMfLFbQNtcIHCdx+adKxAVJwfOf8jBcVCzQm5zDuGx2uYzAbPm4U2Fxr8+SXYS4YcHIb8+l3oaTLq+TfGlHcyNdPzDfUp/haRU2DPp73hj/aSyg2v0lc2rj+DLuK6rp7eK94LiWCm9813TbWu/szWH+qKh5/0ZtNFmi/ZJ/nE6l3t5QWuk1mrqJ1UkYFkYc9dK2PzBx+bFfKleY+U1w==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>,
        "roger.pau@citrix.com"
	<roger.pau@citrix.com>
CC: "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v6 09/13] vpci/header: emulate PCI_COMMAND register for
 guests
Thread-Topic: [PATCH v6 09/13] vpci/header: emulate PCI_COMMAND register for
 guests
Thread-Index: AQHYGZFfEau2yoVfs02TXHZP7JM5E6yDcw0AgAXhW4CAABY4AIAAAW6A
Date: Tue, 8 Feb 2022 09:38:15 +0000
Message-ID: <08d02313-349d-9ad4-926d-0d1419866363@epam.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-10-andr2000@gmail.com>
 <7df2379e-1c30-c362-3106-c7ef23af5c73@suse.com>
 <0ff2a524-9a65-861a-df87-cf3f682862d7@epam.com>
 <140e163c-87d0-2ae8-d57b-7ebc6757de9e@suse.com>
In-Reply-To: <140e163c-87d0-2ae8-d57b-7ebc6757de9e@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: d9fdc83d-19d4-4fb2-b7bc-08d9eae6bba7
x-ms-traffictypediagnostic: AM6PR0302MB3287:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM6PR0302MB328766AF89B183833BC1E12BE72D9@AM6PR0302MB3287.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 MVYBzcMRmEiaHnS8nl9Uj6+AbUkVsqPLLpzGp5b+9fG0xSOulWapYQv9cB8ME+DZNf/H0eAi/StGC37YfmzbdiEgGMw95OVvf/Wig6/rsPZ+W4yfPePqJBrO1EfteotnV4Wj85IigeaI6uSFoG0ZzlIVZLrzm9NP1f9ALS+F9SO2Z6qzEB0XG+0kx5D83FBvS2k8Oe9qTdO+sh0f1duIVzgU6UU6c0SRZyTw1y6UqL6TVXDA4zjRpIpeJBjbi1uBbwSknASr/RAkpDdLY3+oZqF/5ixV8Lp/UgbvsrcecE7SxBQ8tgRqe4/FirOp6cWmQhDPCLLWDwHacsD0UQ5QNVxP65RqV7GpCV1McRtnw6AEhkbpW+Ii7CX/O1WyP0HDGHRzYc6NZ/73AGUpXxlD0Tkj8gxIfXIVb5ayehYSyNz7XJWAJcqOXfYLN2oJgn+9SPGPzgfQqIYMUZNXsaT19Jx5mtQPU4Gltu8m17KhQoAk3eqFC8AlkdVCn00ImC+RJaJTcTAdTr+bmFInmkIrQ1zd4LIIW7ECLbjOi/IFzBWzKJ+D0RIjVtHBVwV1mm5hNZOoJ9T7GbUXw2/z3WMqFqiV6NlvRTzXA98otcvx78VxqWRdUX3UVgMeKmc4zntiB8qo5uJkZBoMSAlp7aPG/ucNA8GdyQayWrpDRYTLa1IH7hxWh2/eDWet0/f1eFUIku/CIy1GOfgQatieNO3z9vJSoT0kP3GPITOW1lsz9n+G/qLmRksJLumUdrJlocd6
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(107886003)(71200400001)(2616005)(31686004)(36756003)(55236004)(53546011)(66946007)(6512007)(316002)(66556008)(508600001)(6506007)(2906002)(186003)(26005)(38070700005)(5660300002)(66476007)(6486002)(7416002)(64756008)(66446008)(8676002)(86362001)(91956017)(76116006)(4326008)(110136005)(54906003)(31696002)(83380400001)(8936002)(38100700002)(122000001)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?T3paMkxSNk1EVWROZ01ocWlEZ2M5elA4TlIybjdLTXNoQlkwR2luVEc4eHA0?=
 =?utf-8?B?dGRtREJMck11L2x4UlBXek5MVzM3UlJ6cEZ1NE1LQnAzUmtoaVFBRTJ2YnJu?=
 =?utf-8?B?YzZSVVhRL0puQUUwVjBzaTBteWw0ZVY0MDJVWGJzNno5aXVabnBHZ0xWUnBO?=
 =?utf-8?B?cHh5a1ZMMklhYnJrdTVuSHlDSHI4c0psQVpsdUZWbzU2UEYvMHZQYUEreWlG?=
 =?utf-8?B?MktvVTRhaVp6RG9EbGRHNkpXSTVrcis4R1pzQW5hREdIQlUrSVZnbDdEVUcv?=
 =?utf-8?B?MWtIYjhWa0ZLZExnZnA4RXpmNTZ4VmgySkRObHhxcnBkdldJNzl2dlc4cEJY?=
 =?utf-8?B?N3F3cEFKSHpmcnlKRmNYVE4yZHpQRUt6VTZodFpnMlBGS0JoSFVNN2RoYzFZ?=
 =?utf-8?B?V3poaW5weUkveG5STytVbWt3aGs3VWlzZlhSMGRNMEVoWlNZT1NrUmVicWZY?=
 =?utf-8?B?T0JiM3NiQy9MSjVWUlZETmlPUk4ySTNxSVQ5SFpDSkZCNnI4TXZvdXhiaVQ0?=
 =?utf-8?B?c1hJSjNsVkg1ejBueFV1U3doKzVEblAxYlZBM3FNVHlnSHFWS3J2eUJadmx4?=
 =?utf-8?B?MUMzazFuUmRFeWZRclhRVVRHZFFKT0JXd1JQZGhzaW83MXduNS9FeHFiOCtM?=
 =?utf-8?B?R3BTanhyYktGWFVXTEFmMVk5OU94Ty9kWWh3SnlnbTRxanFjNkVlZEptbENs?=
 =?utf-8?B?Q1Z0S3VMeUhpVGFzdjZFYkppSW1PTElLOEhMY1l2L3l5TEdPd1B0WkxlK2xN?=
 =?utf-8?B?MjRpd0VzRG83dmY0NDFuTTdpd1NrT2ZBbXNVREZTUHpIU0tabFQ0MVJQbnkw?=
 =?utf-8?B?NDZySjBiMDBCdXMyVjlOUmdIYlhTZEl1ZTNlekcvd1JzTWxjd29rSm9qcXg4?=
 =?utf-8?B?Y2lLYndqOGlQTnFiRVZnaXJJVzNFN3cwcXRFaVF0SDZJUjVsZ05VQzV5NlJH?=
 =?utf-8?B?akN3eE14UkQwbVdOZ0drY3ZaMjgvaXVKdkhJVXNUTU5ndXhDWGNIc2RwOWxZ?=
 =?utf-8?B?MTZHQ0QyTVFWb0tOSmhlbUtFYmVZQ0tWSDBCajgvQ1JMUHJocjlieDV2cU9H?=
 =?utf-8?B?djFjdmJNZjcydXVJekppU3JiQkd4U1VTSkk4dUFrMnp4YldUWVVWZ0txSisx?=
 =?utf-8?B?TXA0dVFENUo3T0hlb1IzNEd2dmsvMlJHOUdGWWwzTDlmRVRGSkRMOEpmRGZZ?=
 =?utf-8?B?ZmE0OHAzWWFVQWZsS1JBdWVWU2h4ek5xeGpHVFNKRUYreUNSZ1NpNzNtd1Nh?=
 =?utf-8?B?OHpCM3RoQ2ZCOHRaWmxEeEVCRUgzblk5QlVJNmNkcjRERWErTHdHWWJ0MVlL?=
 =?utf-8?B?ZDBWbDJzZjdGMUFqT2VyZ2RUWlp0UjgvTUVhYjhjRmUwRmRrajJjYStyMm9L?=
 =?utf-8?B?c05BdFd6T3BiVWxneUdvUUdzWGZvdVB4TWNjdzNlWURNcW9tZStMVHQwazlM?=
 =?utf-8?B?UCt1QVZkekpuK2JEc1Q5ZnB2Smw3K2xLcXFlTlNGajhiS1ZHa2I4QXVHSDIy?=
 =?utf-8?B?NG9yZGk0NnZPd1UrZnJkN3JYU1NHVkFYWmgydUl6T0xteGxYWU1rUk1OME5j?=
 =?utf-8?B?cE00R0FRS25FZDJoRDJ1VlZYNVFEendGclB5djgwRkFyQ2M4ajdTTEh2d2Ni?=
 =?utf-8?B?OWxxRS9rVTBKaEgxa2tyaXBRaHRKUzdtSVVzZW95bitKYzVYNWlCMGp5QUhC?=
 =?utf-8?B?WlJGUHFxR3NzUWhCdXN4TkR1ZjdtZmpqT0ZCaHpOczBwaCtsZXJuVVJKWkhm?=
 =?utf-8?B?L0JUYjE2VnRvdEwrdkx0NjQvdXBxWHBSYmdqSVJTZE5KSHdtVmdKZ0c1WnA5?=
 =?utf-8?B?RzNxMTJQdU16cVUzY280SHlyRGlTZjdyYUNoRlZhL0R1cVhneFV3VTFLODdl?=
 =?utf-8?B?UzhDVm5DN1RTaG5tZ3dhMlR2UUxXbEpLYk8xWm1oZjJXZ1NFVGFMK3lzUzkr?=
 =?utf-8?B?R284aWJxbUFwdTdTSzIvcHFWd1NmVXI0UmtpV2s2ek45T1duOVhhSjVHcy9N?=
 =?utf-8?B?UlJQdkNQRkp2dGJ5SUZ5dHFXS2VSWkNGclg3VHh4M1oxUHVidWxzbWRFUGhs?=
 =?utf-8?B?bG1wQ29Wbzg2UHFJdXgyaW9SdXprM1k4THBoek1nZWNBaG01bkpFTmhOclBX?=
 =?utf-8?B?YTZScG1KQjU1ZCt4SjhQRmxST25jUnFGQ3dZQWZSTDNtbFYrRGlWU3pteFJp?=
 =?utf-8?B?MjFjYlN2NGEwUFVoellMQXhTejN1TEo3VURCWXlsWGhCeW5LcjRVcWFtTFIz?=
 =?utf-8?B?RFBoQ0RCaXQ3ZlFzREdMRlNlbXpsM3ZVTHFsTng5d3AvWlFDM0dTMGk3UDJo?=
 =?utf-8?B?djB0cko4SVFPa3IzVFJQcUU0d2MxZXNIRXpPMVh0WG9RNlJ2ZDZDVG45YlZN?=
 =?utf-8?Q?5Y/YHkRmbSOOC9Z8=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <B0FAFBBF9BC09540A7282693D4C1F309@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d9fdc83d-19d4-4fb2-b7bc-08d9eae6bba7
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2022 09:38:15.9938
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: z4w74zsFT7KSv5tPY1rYGAD/Emq92+XGSQdno4zVnwiG7aX67Oxjb51+MkLCK+xbC/PA345wnkL4vqCtlYxFrf8emxpldwWmlR6p9QzJPuziff8+87fH5eoQXqRVSSyC
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR0302MB3287
X-Proofpoint-ORIG-GUID: 81y-KQQ3YUtcT_Yd4aMLJsO5EhC5bDCh
X-Proofpoint-GUID: 81y-KQQ3YUtcT_Yd4aMLJsO5EhC5bDCh
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-08_02,2022-02-07_02,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0
 phishscore=0 lowpriorityscore=0 adultscore=0 priorityscore=1501
 malwarescore=0 spamscore=0 impostorscore=0 bulkscore=0 mlxlogscore=862
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202080054

DQoNCk9uIDA4LjAyLjIyIDExOjMzLCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMDguMDIuMjAy
MiAwOToxMywgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+PiBPbiAwNC4wMi4yMiAx
NjoyNSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+Pj4gT24gMDQuMDIuMjAyMiAwNzozNCwgT2xla3Nh
bmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+Pj4+IC0tLSBhL3hlbi9kcml2ZXJzL3ZwY2kvaGVh
ZGVyLmMNCj4+Pj4gKysrIGIveGVuL2RyaXZlcnMvdnBjaS9oZWFkZXIuYw0KPj4+PiBAQCAtNDU0
LDYgKzQ1NCwyMiBAQCBzdGF0aWMgdm9pZCBjbWRfd3JpdGUoY29uc3Qgc3RydWN0IHBjaV9kZXYg
KnBkZXYsIHVuc2lnbmVkIGludCByZWcsDQo+Pj4+ICAgICAgICAgICAgcGNpX2NvbmZfd3JpdGUx
NihwZGV2LT5zYmRmLCByZWcsIGNtZCk7DQo+Pj4+ICAgIH0NCj4+Pj4gICAgDQo+Pj4+ICtzdGF0
aWMgdm9pZCBndWVzdF9jbWRfd3JpdGUoY29uc3Qgc3RydWN0IHBjaV9kZXYgKnBkZXYsIHVuc2ln
bmVkIGludCByZWcsDQo+Pj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgdWludDMyX3Qg
Y21kLCB2b2lkICpkYXRhKQ0KPj4+PiArew0KPj4+PiArICAgIC8qIFRPRE86IEFkZCBwcm9wZXIg
ZW11bGF0aW9uIGZvciBhbGwgYml0cyBvZiB0aGUgY29tbWFuZCByZWdpc3Rlci4gKi8NCj4+Pj4g
Kw0KPj4+PiArI2lmZGVmIENPTkZJR19IQVNfUENJX01TSQ0KPj4+PiArICAgIGlmICggcGRldi0+
dnBjaS0+bXNpLT5lbmFibGVkIHx8IHBkZXYtPnZwY2ktPm1zaXgtPmVuYWJsZWQgKQ0KPj4+PiAr
ICAgIHsNCj4+Pj4gKyAgICAgICAgLyogR3Vlc3Qgd2FudHMgdG8gZW5hYmxlIElOVHguIEl0IGNh
bid0IGJlIGVuYWJsZWQgaWYgTVNJL01TSS1YIGVuYWJsZWQuICovDQo+Pj4+ICsgICAgICAgIGNt
ZCB8PSBQQ0lfQ09NTUFORF9JTlRYX0RJU0FCTEU7DQo+Pj4+ICsgICAgfQ0KPj4+PiArI2VuZGlm
DQo+Pj4+ICsNCj4+Pj4gKyAgICBjbWRfd3JpdGUocGRldiwgcmVnLCBjbWQsIGRhdGEpOw0KPj4+
PiArfQ0KPj4+IEl0J3Mgbm90IHJlYWxseSBjbGVhciB0byBtZSB3aGV0aGVyIHRoZSBUT0RPIHdh
cnJhbnRzIHRoaXMgYmVpbmcgYQ0KPj4+IHNlcGFyYXRlIGZ1bmN0aW9uLiBQZXJzb25hbGx5IEkn
ZCBmaW5kIGl0IHByZWZlcmFibGUgaWYgdGhlIGxvZ2ljDQo+Pj4gd2FzIGZvbGRlZCBpbnRvIGNt
ZF93cml0ZSgpLg0KPj4gTm90IHN1cmUgY21kX3dyaXRlIG5lZWRzIHRvIGhhdmUgZ3Vlc3QncyBs
b2dpYy4gQW5kIHdoYXQncyB0aGUNCj4+IHByb2ZpdD8gTGF0ZXIgb24sIHdoZW4gd2UgZGVjaWRl
IGhvdyBQQ0lfQ09NTUFORCBjYW4gYmUgZW11bGF0ZWQNCj4+IHRoaXMgY29kZSB3aWxsIGxpdmUg
aW4gZ3Vlc3RfY21kX3dyaXRlIGFueXdheXMNCj4gV2h5ICJ3aWxsIj8gVGhlcmUncyBub3RoaW5n
IGNvbmNlcHR1YWxseSB3cm9uZyB3aXRoIHB1dHRpbmcgYWxsIHRoZQ0KPiBlbXVsYXRpb24gbG9n
aWMgaW50byBjbWRfd3JpdGUoKSwgaW5zaWRlIGFuIGlmKCFod2RvbSkgY29uZGl0aW9uYWwuDQo+
IElmIGFuZCB3aGVuIHdlIGdhaW4gQ0VULUlCVCBzdXBwb3J0IG9uIHRoZSB4ODYgc2lkZSAoYW5k
IEknbSB0b2xkDQo+IHRoZXJlJ3MgYW4gQXJtIGVxdWl2YWxlbnQgb2YgdGhpcyksIHRoZW4gdG8g
bWFrZSB0aGlzIGFzIHVzZWZ1bCBhcw0KPiBwb3NzaWJsZSBpdCBpcyBnb2luZyB0byBiZSBkZXNp
cmFibGUgdG8gbGltaXQgdGhlIG51bWJlciBvZiBmdW5jdGlvbnMNCj4gY2FsbGVkIHRocm91Z2gg
ZnVuY3Rpb24gcG9pbnRlcnMuIFlvdSBtYXkgaGF2ZSBzZWVuIEFuZHJldydzIGh1Z2UNCj4gIng4
NjogU3VwcG9ydCBmb3IgQ0VUIEluZGlyZWN0IEJyYW5jaCBUcmFja2luZyIgc2VyaWVzLiBXZSB3
YW50IHRvDQo+IGtlZXAgZG93biB0aGUgbnVtYmVyIG9mIHN1Y2ggYW5ub3RhdGlvbnM7IHRoZSB2
YXN0IHBhcnQgb2YgdGhlIHNlcmllcw0KPiBpcyBhYm91dCBhZGRpbmcgb2Ygc3VjaC4NCldlbGws
IHdoaWxlIEkgc2VlIG5vdGhpbmcgYmFkIHdpdGggdGhhdCwgZnJvbSB0aGUgY29kZSBvcmdhbml6
YXRpb24NCml0IHdvdWxkIGxvb2sgYSBiaXQgc3RyYW5nZTogd2UgZG9uJ3QgZGlmZmVyZW50aWF0
ZSBod2RvbSBpbiB2cGNpDQpoYW5kbGVycywgYnV0IGluc3RlYWQgcHJvdmlkZSBvbmUgZm9yIGh3
ZG9tIGFuZCBvbmUgZm9yIGd1ZXN0cy4NCldoaWxlIEkgdW5kZXJzdGFuZCB5b3VyIGNvbmNlcm4g
SSBzdGlsbCB0aGluayB0aGF0IGF0IHRoZSBtb21lbnQNCml0IHdpbGwgYmUgbW9yZSBpbiBsaW5l
IHdpdGggdGhlIGV4aXN0aW5nIGNvZGUgaWYgd2UgcHJvdmlkZSBhIGRlZGljYXRlZA0KaGFuZGxl
ci4NCg0KT25jZSB3ZSBhcmUgYWxsIHNldCB3aXRoIHRoZSBoYW5kbGVycyB3ZSBtYXkgd2FudCBw
ZXJmb3JtaW5nIGEgcmVmYWN0b3JpbmcNCndpdGggbGltaXRpbmcgdGhlIG51bWJlciBvZiByZWdp
c3RlciBoYW5kbGVycy4NCg0KQFJvZ2VyLCB3aGF0J3MgeW91ciB2aWV3IG9uIHRoaXM/DQo+IEph
bg0KPg0KPg0KVGhhbmsgeW91LA0KT2xla3NhbmRy


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 09:44:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 09:44:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267887.461643 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHN2i-0000x9-Fs; Tue, 08 Feb 2022 09:44:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267887.461643; Tue, 08 Feb 2022 09:44:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHN2i-0000x2-Co; Tue, 08 Feb 2022 09:44:12 +0000
Received: by outflank-mailman (input) for mailman id 267887;
 Tue, 08 Feb 2022 09:44:12 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=v7zX=SX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nHN2h-0000ww-WF
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 09:44:12 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id aab15d2f-88c3-11ec-8eb8-a37418f5ba1a;
 Tue, 08 Feb 2022 10:44:10 +0100 (CET)
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2052.outbound.protection.outlook.com [104.47.2.52]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-19-S5V92VZvNz-etqdOKCtHrQ-1; Tue, 08 Feb 2022 10:44:08 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5248.eurprd04.prod.outlook.com (2603:10a6:803:62::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Tue, 8 Feb
 2022 09:44:03 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.018; Tue, 8 Feb 2022
 09:44:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: aab15d2f-88c3-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644313450;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=x/PlDEaxR5PgelK5Hd/vp2HCNr0PMnCJSrPU49yxrmk=;
	b=UcVVHyeatI+KchZZWwLDQjnmJGMIyAZwysDmFrmHK6IW5Mx6SSfgbSpROVQtjwQKVwG0+t
	npdSdrzsSqoLLroDTGcZnmZVvyymJRLvFGJNTUm/83+8/B158OfcCxT08EurqLdPoyPw2H
	vpVU0G0KGAvkZM2KG7VcWyXzranzIG8=
X-MC-Unique: S5V92VZvNz-etqdOKCtHrQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=naN2hLllGouNeZZv1GAg1sXTbIxtXXxGPrBHs6O9hXamkPVX2d8KVAMhV/SsfmeD+UBH8uWRprHB7mj+roiJXGQKTjL/Tbc9Qmgh5+uJGVLnqQK0CwEEh/ttEy70TAoa8JVyi6NorNUxK9M4EE+SGtVp2AFvfroRgmSHomGCsqr/4lCPDnaP9hwQeHI+cNarWtdYWRhSXnrwi7TCHpZ5v1Gxx6nnDB2vBJeodV77ZFVvPoKSjzv9qSCQzEQ1M0Hs27DPEo8c+ki/SeiLRteNhXFiDQFEsrzzla9hdX9FWKhGfOJDvPEXC9eWYC7SiSwb0tg+Tq0l0ayRev13QGyMGg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=x/PlDEaxR5PgelK5Hd/vp2HCNr0PMnCJSrPU49yxrmk=;
 b=cHpBau9iDK3F79CbtsVwdFnp3trR3CFNJWM7jZEayTdyKD7JD0xwQ3dWECqXWlx//r8CyWvc5p9c0a2SBYG4LIb0vhyS1f/AYwi+UKA5mDRHzQD1HXdqyo0pDxglGUiuLqRFZJMiFUKOzW6cxUTTAO45DADm31fgI2tjvOIa9hbYHGNmOo/jnz1BF47awdeevs6hNTJpYG0M2TJgy746DXQHCr5AUiIzcl27Twi4I9MXccnj09QP4l4YZOey9qfZNlH0dhFaT6eGKffpaOvR8DVkBTxLsBJrddsqClv5M2jrrAsOtmiIkBS2MYOq7yFLBDNs/Z/BR5bgQaFPQzIfZw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <0fd8a0ac-dc91-287e-536e-1684892837ab@suse.com>
Date: Tue, 8 Feb 2022 10:44:00 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v6 05/13] vpci: add hooks for PCI device assign/de-assign
Content-Language: en-US
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Cc: "julien@xen.org" <julien@xen.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Artem Mygaiev <Artem_Mygaiev@epam.com>,
 "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
 "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
 "paul@xen.org" <paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "roger.pau@citrix.com" <roger.pau@citrix.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-6-andr2000@gmail.com>
 <16cea1df-3d0f-d404-2b88-aab47ad5548b@suse.com>
 <3fe6dbe3-51c6-f87f-23f9-cf2e1a924326@epam.com>
 <582ee8f9-7b01-4adc-6a8a-ce8b1dffd534@suse.com>
 <e225553b-b29c-0448-fb9f-f8b513d9f77d@epam.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <e225553b-b29c-0448-fb9f-f8b513d9f77d@epam.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P194CA0033.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:209:90::46) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f0e2c1ee-790d-4851-f1c8-08d9eae78a61
X-MS-TrafficTypeDiagnostic: VI1PR04MB5248:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB5248E7624C98DA8CD6281C0DB32D9@VI1PR04MB5248.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	0ycxx6Qxl9ExWrUl/W0jV7etMAxt7kvAhHNpOIq/KVqvq+x+5SLmJaBafekwVhaQX1uG2KlchNCR/PPcW5y+NMk/5bjcFlaVDkTiB99H1nCBbPyw5f2MzGwW25PDt01XkmSkmvDKuTkepOlHViYnqvp5S9+oxoPEJzOxbSsZ48wWTWlwfTCxt3DCVqJMJbxtBxG7yAYAwHJLS3boTKnj7TpkzZmtJ39jXDZBiVoOVN+K2xOI8pSqtdow5+h4ksRD8hQYQomx19q8WbNjbOVoE9iPiX7NfEGvSljwLPM+Kx3xoiRoW7Vwk9AjsVXFCzahDdQk3d2LRxJ7itcHGgcyUvXQv83TYSIq361kZ6UCMVamUaq2plWCmRtXSWsA6Zat2wytUJmqS5cmXlZF/1AvoGU843/LJpQam45sOwzE1y7FoZF78aRewWH8MCB99hi3RxyjcMmxS9M8G4A4LZd88a4/hQzjKjbtifgDqcDaBcMO6cgjGVsEgzTFHCiSP3u0EnIYCd1e2TWPwR8TaQNBQN05kfsDNjdwmP7AbzafEaqQ/D42f53wcmBfj6N2mjxwLiMZXZBAFGj4I3M/LGm7pZsZhCQNHHoKkM/nogIO/6JTBnr4lOLLbFQ0YdpdmRIiZ7w2qqrDGtI4wVyqrlNWDVdt+CViehARE68gRuUhdItECMNZkYivLGFwP1SVM2oxOBT4HmUkIhJi35CystXgmeD9X7lNEf2n31azmsDMtBg=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8676002)(6512007)(8936002)(4326008)(66556008)(66476007)(38100700002)(66946007)(86362001)(31696002)(316002)(53546011)(508600001)(6486002)(6916009)(54906003)(6506007)(186003)(31686004)(2906002)(36756003)(2616005)(26005)(7416002)(83380400001)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?V0V0VVhxKzc0Mmk2RXV5eW9rcm5hMnNnc3pFeGpWUlZ5WTBrNWhON2NWMEMx?=
 =?utf-8?B?Mm5XUGF4bnRUUlZkTDZySkVLbUU1Q0ZCSC9mc25zTnBOblM2SWN3eXRreTVv?=
 =?utf-8?B?MnU2cUtubk1rM0o1QmZvSHkxeGpXR04xb05WSVAyYXYxa1VvSzhKQkdEdmdZ?=
 =?utf-8?B?U3B0WVZxZFRXSllyUnZOOVZLVFlMMll2MWM2dWpLeS9Sa3BFK2M2dnFXaDJs?=
 =?utf-8?B?NHVDTkVsQUNNMnk2UWJlQ3V5VS9hckkyRjRSTjh5aU1Senh1Sy9QbG5rOW5y?=
 =?utf-8?B?d2ZQSUNTMTBqRlJ3REpDVXovZks3dmx2T1B2NnRVR2s3QWV0bXFVTFRNamtN?=
 =?utf-8?B?RXhNOWo3OXhUVmVna2lITE1nL2c0UElMZ1FSYWRBTDRIcEJ1WVhRK091VGtC?=
 =?utf-8?B?TVVJNXhNY3RJaU5GNFYxOXpKTDdpYkxadGtYcFcweno4Wm5BN2hNaXBLUy9X?=
 =?utf-8?B?ajBNbXNNM3dxRWN1NjA3cjdGaWtpWTFDN2pKSjBFSjk4MWM5VXBMUGlibTlI?=
 =?utf-8?B?RFZvYkdmMnNvK21CQTBQcTVZZVoreUNvNkxUZW1iYzVpMFJwQXgydktRTUx6?=
 =?utf-8?B?QlhubmpJb054bmdHSzB3d0xxZmtJM2Yyd0lVY05KWEF0T0trT0JDRHJIczFN?=
 =?utf-8?B?cmRxcEZUVG01cnZpc3hXR21waUM4K0JRK1FLZW5kdlJNSGt3dzFiVGgzaXpm?=
 =?utf-8?B?dHgxckswam5EaXhKa1BQVFkzTzFQbXQ3bGZ3NlpsVHBkZTNxdjFwNDhLbCtl?=
 =?utf-8?B?dGQ5VjFxcHV0ZHpBcWwzN01pOHd6QjBWN0IranBmWm1NcS9wdFlxSzNXZFQy?=
 =?utf-8?B?MkVFaVFJRjd3SytJcktnMm5IRDEwVExrZkpxZ0hqOVdhL3ZYZU1lN2lCUTEz?=
 =?utf-8?B?WFF4clRRZEdNZCtmU1F3WFpDb0pRdEZVRGI1emIzaG54aktUeVF0MmN4dlIz?=
 =?utf-8?B?bmRid2w3RDFuT2JTa1MwT3NhSjZiTDBpL1poWC84Ymg2TmtGenplclBna3A1?=
 =?utf-8?B?N0ZiL1VUSnJERkN6dEFhMUl3REdOS1FXRGpFRHBTNEQ1YmVpV2V0UWh0dEJT?=
 =?utf-8?B?dXI5b0VBWDBRdm5iMUUzY1NsQXZodHNvWTR2M3JRcDRTa3BBWnFvWnpSUE1D?=
 =?utf-8?B?LytLVUxDaUM2UHdhQTg5REdkRks4clg5eXBOeFVPVWJ5ZDNJd0lRditlS2xW?=
 =?utf-8?B?YktCRW80SzJtUTV5SEc4eHZnVU5STlU5d1o1UHBuSkpOa0JvQ3Y3RFBJQ3Z3?=
 =?utf-8?B?QkR3VTVkWWFvMDFObTBjWlNPNjlaeUlrOXZRZG5EaXdmTnREeHgrZmFHTktY?=
 =?utf-8?B?dkN2TElROUtZcXJNR2VVK2RTYkhBQmhkc3hBa0ZsSEJzd3kyZEoyS0t0bHFN?=
 =?utf-8?B?c1RuT3lpNGhjSFNxTFRsd1BZZmM1QTBDbUlIS2VLdEJEYmVnMXVuMGUvZkxT?=
 =?utf-8?B?YXFsM3RwVlcxSWhEdVNaM2xqaVFvRmF1QTZtK1J5VytrOTJ5U1d3bVRJd05O?=
 =?utf-8?B?ek9naUpIdzU1SVRlditmUkxJV3dIeUZleWFhQVRQUnh2cFloUVlkWkFjVngy?=
 =?utf-8?B?eWhBeWxsTkphSmw1WHZISjh5dWJMYW92aFFjYktnMVJwcGxBcnhjTm5BK2FV?=
 =?utf-8?B?bHdKR0Q1ZnIyTDNaQlZrTS90QkdUZjYrRFBMeXNjY0paajZaVWhtNWVxUjVq?=
 =?utf-8?B?dVJHUUFrdE8wWU9hcUdaOHUxa1dZRkFkbkRnVHpsOXAzTmpvc0tDUjBvZ0hH?=
 =?utf-8?B?SkVSZDdUVkVueXdEeHdudGo5TWlzQUw2VWxVNStkN1ZDdUNnZC9nSStoenJ5?=
 =?utf-8?B?cGlCd2o0L3owRHl2ZGh3Wk9YTlFxNW1aUG1sZ2RxK1ovVkV5cERKUGtLM1Rp?=
 =?utf-8?B?ZVliVXpCSnJaS2QweU01c1hKZXk4Y296bzB0TFJncmlnZWpWTzNoSWlCQ0ho?=
 =?utf-8?B?YU16QUwvNFNPbkEwNFErS3hWTGlTeU5JUVVxTkEwODUxMW0ycnVGWTlzWGtX?=
 =?utf-8?B?UHpVNWtpQWoxQkZ4ZmZtOTNwdklFYWRYU2lZb2ZzQzFqRCtWTEo0SWVVMzRS?=
 =?utf-8?B?TkF0bEd5RVBER25wTytDaE9Zc3pPOG9EaDY0cUhObDdyMVJYNTdNR1BZc1VQ?=
 =?utf-8?B?cm9pdVUrRkNxN3d3VjZMYWg3ekhvd1VLMHppOEowRVF0dTNTNTljeCt2RDVL?=
 =?utf-8?Q?MWOlvCyuH0FAh6GzG0u7kgc=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f0e2c1ee-790d-4851-f1c8-08d9eae78a61
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2022 09:44:03.1530
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: S9hV+h8u7seQpWzAYQmr2UxW1rQBW8H7yPMjJ2odARczMD17vr39BePktL5SZuFUlHdZnI/gXGciikX8wll6KQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5248

On 08.02.2022 10:27, Oleksandr Andrushchenko wrote:
> On 08.02.22 11:13, Jan Beulich wrote:
>> On 08.02.2022 09:32, Oleksandr Andrushchenko wrote:
>>> On 07.02.22 18:28, Jan Beulich wrote:
>>>> On 04.02.2022 07:34, Oleksandr Andrushchenko wrote:
>>>>> @@ -1507,6 +1511,8 @@ static int assign_device(struct domain *d, u16 seg, u8 bus, u8 devfn, u32 flag)
>>>>>                            pci_to_dev(pdev), flag);
>>>>>        }
>>>>>    
>>>>> +    rc = vpci_assign_device(d, pdev);
>>>>> +
>>>>>     done:
>>>>>        if ( rc )
>>>>>            printk(XENLOG_G_WARNING "%pd: assign (%pp) failed (%d)\n",
>>>> There's no attempt to undo anything in the case of getting back an
>>>> error. ISTR this being deemed okay on the basis that the tool stack
>>>> would then take whatever action, but whatever it is that is supposed
>>>> to deal with errors here wants spelling out in the description.
>>> Why? I don't change the previously expected decision and implementation
>>> of the assign_device function: I use error paths as they were used before
>>> for the existing code. So, I see no clear reason to stress that the existing
>>> and new code relies on the toolstack
>> Saying half a sentence on this is helping review.
> Ok
>>
>>>> What's important is that no caller up the call tree may be left with
>>>> the impression that the device is still owned by the original
>>>> domain. With how you have it, the device is going to be owned by the
>>>> new domain, but not really usable.
>>> This is not true: vpci_assign_device will call vpci_deassign_device
>>> internally if it fails. So, the device won't be assigned in this case
>> No. The device is assigned to whatever pdev->domain holds. Calling
>> vpci_deassign_device() there merely makes sure that the device will
>> have _no_ vPCI data and hooks in place, rather than something
>> partial.
> So, this patch is only dealing with vpci assign/de-assign
> And it rolls back what it did in case of a failure
> It also returns rc in assign_device to signal it has failed
> What else is expected from this patch??

Until now if assign_device() returns an error, this tells the caller
that the device did not change ownership; in the worst case it either
only moved to the quarantine domain, or the new owner may have been
crashed. In no case is the device owned by an alive DomU. You're
changing this property, and hence you need to make clear/sure that
this isn't colliding with assumptions made elsewhere.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Feb 08 09:48:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 09:48:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267897.461653 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHN6W-0001bt-1U; Tue, 08 Feb 2022 09:48:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267897.461653; Tue, 08 Feb 2022 09:48:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHN6V-0001bm-Ui; Tue, 08 Feb 2022 09:48:07 +0000
Received: by outflank-mailman (input) for mailman id 267897;
 Tue, 08 Feb 2022 09:48:06 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=v7zX=SX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nHN6U-0001bg-L4
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 09:48:06 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 36b89ef6-88c4-11ec-8f75-fffcc8bd4f1a;
 Tue, 08 Feb 2022 10:48:05 +0100 (CET)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2109.outbound.protection.outlook.com [104.47.18.109]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-26-mQC2Y_7pNEypQJzJRbTaIg-1; Tue, 08 Feb 2022 10:48:04 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VE1PR04MB6558.eurprd04.prod.outlook.com (2603:10a6:803:11b::31)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Tue, 8 Feb
 2022 09:48:02 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.018; Tue, 8 Feb 2022
 09:48:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 36b89ef6-88c4-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644313685;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=A3X14j08nir1L1vwZexD8I0I8pAJdzSR84jrvsZd40Q=;
	b=T3pPr91N6MZHfVWQLn7RPVAqSQGzQYL6XvcrvM7Le4z5/Sth7FDH+jZfaDI6UTZd2mnAmP
	+NFJNHYpBj8Hvtz2j/lwV+X9WOMkTdsO95kxVjjwyEJYCHD0kKyubfXf4eQ2nwktRqIczH
	jg5Mwa4JR4HwWJ4MI8/IwlO4cdNrnag=
X-MC-Unique: mQC2Y_7pNEypQJzJRbTaIg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=CF3iqnVHKWhqTLvU9SJLiga69w8PJ3lBnQ8p1XSJcThZe31T4FQM6sPZS6LHXh4aj+/GldbrpFmCnO1dACv40oFRuA6Eikk2UOv1krl8apqwYsqpdl4DE7ALb7X8dRpP0IQlpBSlUI3v1X4Ky74ScBnV7n7D9m2QPRQBHla0Qs6qnH9XyNYnaf3SdmgGkCZanmmkLPhDRJJnTYn6vnE4/kOiZ2QBbPEqxioTEaT+BPmE2RJtgH8gjgcSQf5D2c8IG6s7LEjnrLGrZzIhMC6mifmiB1eeSOHyODv8XWuYJyHaxPzpvaiQomOqfhQYXIZ0A/bFcwvmGl/P7MMJbEn2Yw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=sMCNwo8UOrbIlwP7L8+4ukTLhfXLpoJj/Xl9xyg0R5w=;
 b=RyL8M9iYFHjI9KDGCvSA1sIMPZiaNMp8yO+fpz0OpnnYviXwvXcjR7qKel8BJrdoxr/UQEy4gpLFhE3ct4ttoBt3E5VlK9uWizQ3roVgvMQOWFCOKfVXlIvGCXV4e3gJchbUfJx5/nuebQkopOzIhS6zeSsCZrhXV1434f85WtEhtD++dnkfW38C4gTwvq3cQzrN/nVJ+YduMQUnJRHUiEe/USkm1jYBvuhtB0t43FIMzcaohAcsvp38flwBNiI5zWZ2S6Mam0mJvUr+Zgb/0j48EVkwVpBGjDjxTW8mKyLD4bRSjAZA8bSdH5AZPBik+BmWGirjk02bBvNGEJ486w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <5bc96dba-e9b8-de2e-f6aa-ae6c604897e8@suse.com>
Date: Tue, 8 Feb 2022 10:48:00 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v6 06/13] vpci/header: implement guest BAR register
 handlers
Content-Language: en-US
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "julien@xen.org" <julien@xen.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Artem Mygaiev <Artem_Mygaiev@epam.com>,
 "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
 "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
 "paul@xen.org" <paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-7-andr2000@gmail.com> <YgI3HpFffudiEmNN@Air-de-Roger>
 <498ca523-2642-e35f-b316-0a089f98ca91@epam.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <498ca523-2642-e35f-b316-0a089f98ca91@epam.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0111.eurprd06.prod.outlook.com
 (2603:10a6:20b:465::17) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d9baba63-fc8c-4ab5-db4d-08d9eae81922
X-MS-TrafficTypeDiagnostic: VE1PR04MB6558:EE_
X-Microsoft-Antispam-PRVS:
	<VE1PR04MB655846884287B72EFAB11DC1B32D9@VE1PR04MB6558.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2803;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	JREW4EYB+N1SiozW9CiApYPeZnu93GBlMHDpBNH2HvySwzD+BgcfcH587kxr80LiQD8kEDUhbw7S+WWpRhYLXeMqkheGkapMlnJVsuLmrX7WHAK3k0kP3bIknZSXrvM/AKfMfUSiba/gShjWEgAvUgkJ1EDCt08bauDrs4Qax32pI+x5SS65mUbDkCpDiZLvp4Jw5Oib8f1YvgXRB06dG2QRaOaRBez+eNGgxpJJak4AVGFVY3t4TPLbNezTjXjTQCDgNFlS1kBdF4Ngs1D5grV5s4XopwUIqfCN1VjBDGWKNYj8ev6f1fX6HWZz7BJ1R/b6hdIv7T3PRZDGb8oEfED3ulG9CLZVApnrvUqWb54owSf+59f5AaD7IADJAeGlgQqipZeoAg7YCGUZUaQzx6+bOPbUCI/WWPb8yzlfqMNJAkGNTrtJTARbPhD2JMzMZNncdWIJ+56OLGd1KsGgb7J/QYxo/OElpMeh20yBwv9LVc36MbKhuzK6O8d+PdDS6PaClceqwLV6HkwCWW2BafAsVY6yn13C217sqne9V0Jy9zDyFWkgwiUnk8sJgar4drpFsbkKJiYSn+zZWoqs3eW2tnTUVuHJgcnweWlZCl3FIY4JO69y/0f9oONHLBF3XcaiDuiIuhB/2GRlYrXLHlv2r6ghX55jWcyuYNXLdCa7gshS6gFVcHpTL6BuWpS7blxeoVkrTAdGk+baDVV54iXijxFEv3qugiohqny3/14=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66476007)(83380400001)(86362001)(66946007)(66556008)(508600001)(38100700002)(8676002)(8936002)(5660300002)(4326008)(54906003)(6486002)(7416002)(316002)(26005)(6916009)(2906002)(4744005)(2616005)(6512007)(31696002)(186003)(6506007)(31686004)(36756003)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?m8jITvi+sJAYrPbbqfciTjwwyLsCOv8O6q0V2jIz5UtiFAKyjytRG8xzU7MW?=
 =?us-ascii?Q?EPmerVFlQn9l3sMc8u6n/ohYlYlzNJitZour00C+EBBJfOW9cbMveR+oka4Q?=
 =?us-ascii?Q?ttnsrnBZs1AXCWg7lqh0XQIftPUfjJ8KbCDpN5Ya6su+mWW2trFranCekCv8?=
 =?us-ascii?Q?xZYNMFcPaepk4W5rz+RoiCLC6iz3o8MsflXUtI77Zn/1CQNMMeedd6qefgMo?=
 =?us-ascii?Q?jm0dYgkmDSD2tMxBPBUFt0gwkdNdgQD+ge5u9BtZtRpfXhnV7xgmFy5gE5Lz?=
 =?us-ascii?Q?Mn8jEpbs28AtjWdpX/rvgkZsX68F4PWFqWn3VVqOkYMPsCBD2TRvhhe61qOe?=
 =?us-ascii?Q?fFJAHE2Q4zKelPwIgmTeDHhw0tW2GbT6xojQ4I1rkh+e5OubvDsjVlID8Fdx?=
 =?us-ascii?Q?4paFhFug0WYBQnKA4oFZhYlUtqGaWCYUaR3P6GSBAIIUQvgwe0ScIix7juMJ?=
 =?us-ascii?Q?GExYYA9TJpTk+q/z13lTejroBsoWxn/uRVpq7Oc8eVYWOyxR/8U43+6DCTNo?=
 =?us-ascii?Q?w2VRGwXqXydNBDtSLqlX8lr7vt3aj2EJ+30Elbl/e7ewr7ItvQ+RxOMGqRB3?=
 =?us-ascii?Q?J9ywQk6uKMY7YuaovRYGR5yndoQbUkQyp08LriE4+8Gy5JmWJ/sCj1eFpORp?=
 =?us-ascii?Q?SDhmEnQpkSNNJ7foz5YtoiOl1hsd9TsGSpPhB4CWKnZAMzCo8qSwalLPuYHc?=
 =?us-ascii?Q?poeM01WOzuxl6PSWzmjlGDtknVFU9Ld/FGd+x6d4dsGLfAngK1Qznd1rojfu?=
 =?us-ascii?Q?dbsbcXLOW9Gr+dhhAef2eaPujOVu69UUy/mMlwV8Aj1FaY8LRsSBji+Gnrwy?=
 =?us-ascii?Q?d+EshnffkgJXJvk9lo07rzX6M5GkcC0oIaz6skvAiRF1kKwUZM8XaOb7TAOF?=
 =?us-ascii?Q?mVjSgvS8RXMPTapWafve5DUfa3dJYYqDkPet4jDUT6dzQi19V8zCdBIkr/Eh?=
 =?us-ascii?Q?Q3f0mEHLAODp90YY1XCA743ATX9tBcw3VNUCu51XqzIzvPpVX5u8dzWTonxb?=
 =?us-ascii?Q?1pTiOeDRZtzlbdT2XgQhyVS4kxB1/KpSxGZ1M6XWFqCGOrtdye+uoKCsLlWI?=
 =?us-ascii?Q?DK0QRTOOxDtZRhFCCtPc3oDFYTHtS9+s22rSHBTq5QLFfZpcS3g8ZAk1CZCi?=
 =?us-ascii?Q?AKEq0BulHtmU2fKXlXbFu1kF+MmPbQ6f6M+mU0ad+jBVlFJxBpm4U179PzOk?=
 =?us-ascii?Q?dI5K+x/5Dq1/a8h0f/oibHTtOdPGyR/Xi0neA3DgnZI4h4nqDmD9Yxb9Rc7M?=
 =?us-ascii?Q?n+6dVtpwVI2EkXZVQIB6oax5iHeOpVAPVrAGPzMe68yYzAvkPvugRD9hc3vz?=
 =?us-ascii?Q?ij4dpONryDJwi/qsj9Z77wZC9EHlQ1RnNCeWtYIMvrSluHLoQCxO6AdkpWzB?=
 =?us-ascii?Q?JGugSyDN5RNojkADzIMcXLwPPV77XvzqkTpx+0XmnrrDA6r6YxMtal5E3sCU?=
 =?us-ascii?Q?gpXrqz0enxCTV23MrFm36IsrfN4cNKJJBuVLfNCAinvmmo0jHfocBOpXityd?=
 =?us-ascii?Q?v9yp/LMKicFRK3BQcw0HBNpAAeVKr1htF/uha/cJevFN+211+iTuMkSj5KTQ?=
 =?us-ascii?Q?rERX9QwS84wppfitkgmZTKI/Oat9ZXv6CdvTBleyqLTisxizD7Zq1bDTfNqB?=
 =?us-ascii?Q?b+DjYB9iWUchYXjZK5U+qj0=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d9baba63-fc8c-4ab5-db4d-08d9eae81922
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2022 09:48:02.6225
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LFDrWDCApF1vtqrawRFgkB2d4HC1k78wmO74O9NvrnC9MhWE7/AEiuZsPHTsYMvH4rirh84Zxpo4PEtoBW/2NQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6558

On 08.02.2022 10:31, Oleksandr Andrushchenko wrote:
> On 08.02.22 11:25, Roger Pau Monn=C3=A9 wrote:
>> On Fri, Feb 04, 2022 at 08:34:52AM +0200, Oleksandr Andrushchenko wrote:
>>> @@ -516,6 +594,11 @@ static int init_bars(struct pci_dev *pdev)
>>>           if ( (val & PCI_BASE_ADDRESS_SPACE) =3D=3D PCI_BASE_ADDRESS_S=
PACE_IO )
>>>           {
>>>               bars[i].type =3D VPCI_BAR_IO;
>>> +
>>> +            rc =3D bar_ignore_access(pdev, reg, &bars[i]);
>> This is wrong: you only want to ignore access to IO BARs for Arm, for
>> x86 we should keep the previous behavior. Even more if you go with
>> Jan's suggestions to make bar_ignore_access also applicable to dom0.
> How do we want this?
> #ifdef CONFIG_ARM?

Afaic better via a new, dedicated CONFIG_HAVE_* setting, which x86 selects
but Arm doesn't. Unless we have one already, of course ...

Jan



From xen-devel-bounces@lists.xenproject.org Tue Feb 08 09:50:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 09:50:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267908.461664 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHN8b-00030m-H9; Tue, 08 Feb 2022 09:50:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267908.461664; Tue, 08 Feb 2022 09:50:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHN8b-00030f-E4; Tue, 08 Feb 2022 09:50:17 +0000
Received: by outflank-mailman (input) for mailman id 267908;
 Tue, 08 Feb 2022 09:50:16 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=GmUj=SX=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nHN8a-00030Z-60
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 09:50:16 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 82ced994-88c4-11ec-8eb8-a37418f5ba1a;
 Tue, 08 Feb 2022 10:50:14 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 82ced994-88c4-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644313814;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=d/eGhLfKHC6NRNkzk5f4cbrP/3jBsGgycwmRjP+GQYo=;
  b=LYqZD+UhPj82ZW/9dfZjzrKuPzia/JBrHFWI6r3tse9SsjPV8MVVSSJW
   +xSzINXXwJpOqvwgMyLA1XNOJaLu9w2zBgL5WiEhRB2s+rE8t7BIy8poc
   vYvPbG7xregodhX7aI0N7Vu5S4V0XfjQ2UWNcgj4Mtu0f4D+XW6ltpOuq
   s=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: oLpms4KMTs7TZaxhpYuAcY1Z/FblO7kuY+2cZtdxtWyrfZ83Mipehif6/pdjBYNitypqEJOggw
 MQFB+z2CsmIOgKthwpeIFcdkeBD5QcVcjITEQn6Da1jE9WhabI9K4OyeS84bZzZY3em0ELrVOd
 U2p9wLhsWK1Ci1TtO82dtq0YBCRa6A7arh78fhP3dExMyc12bLkpCbylKnRb7HgM0nhtihOVLe
 XoVaGMJPsjkddTDWQ/7BEPPY5s/4l8bKupc1TiL9F+DTx43QXrQ+taQvxdwZQFPjEmJzuhf7Lz
 GxwB2doBQ/h0dQi/GbvMsJfD
X-SBRS: 5.1
X-MesageID: 63173378
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:xeuo9qugSp19NO16ZyH6s53B3OfnVAlYMUV32f8akzHdYApBsoF/q
 tZmKWjXbqyNZzGgfo0gb9zgoRkH7MDcn9djSAo+pC8zFnhA+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZQP0VOZigHtIQMsadUsxKbVIiGHdJZS5LwbZj2NYy2YjhWmthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 NplrYyqSUQ3B4f3ku0XeCJhEHpiEIBX5+qSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DJoQQt2sm1TjEJf0nXYrCU+PB4towMDIY2JsXQq2FO
 JpxhTxHdgjJWzhOC3MuJ705x7+Wt0mkMC9pgQfAzUYwyzeKl1EguFT3C/Lfd8aWX8xTkgCdr
 3jf4mXiKhgAMZqUzj/t2kyrgujDjCbqQrU4Hbez9uNpqFCLz2lVAxoTPXOrrP/8hkOgVtZ3L
 00P5jFovaU07FasTNT2Q1u/unHslgEYc8pdFas98g7l4rHP/w+TC2wATzhAQN8rrsk7QXotz
 FDht9HjCCFrsbaVYWmA7brSpjS3UQAXMGsDaCksXQYDpd75r+kbjB3VR9JnOKewh8/yH3f7x
 DXihCU+irBQncMN/6Dm5RbMhDfEm3TSZldrvEONBDvjt14nIt7+D2C11bTFxe5QNobaUGCrh
 3INkeOl1eNVEbyghTPYFY3hA4qVz/qCNTTdh3tmEJ8g6ymh9hafQGxA3N1tDBw3a5hZIFcFd
 GeW4FoMv8ELYBNGeIcqO9rZNig88UT3+T0JvNjwZ8EGXJV+fRTvEMpGNR/JhDCFfKTBfMgC1
 XannSSEUCxy5UdPlmPeqwIhPVgDnHFW+I8rbcqnpylLKJLHDJJvdZ8LMUGVcscy576erQPe/
 r53bpXWl0wOCbSgM3OOqub/yGzmylBhVPjLRzF/LLbfcmKK5kl9YxMu/V/RU9M8xPkE/gs51
 nq8RlVZ2DLCaY7vcm23hoRYQOq3B/5X9CtjVQR1ZArA8yVzMO6HsfZEH7NqLOZP3LI4l5ZcE
 aJaE/hs99wSE1wrDRxGNsKjxGGjHTz27T+z092NOmBgJsU9HFyQobcJvGLHrUEzM8Z+juNny
 5WI3QLHW5sTAQNkCcfdcvW0yF2t+3ManYpPs4Hge7G/oW3gr9pnLTLflPgyL51eIBnP3GLCh
 Q2XHQ0Zta/GpIpsqIvFgqWNroGIFepiHxUFQzmHvOjubSSKrHC+xYJgUfqTeWyPXm3D56j/N
 /5eyOvxMaNbkQ8S4ZZ8Cbti0Yk3+8Dr++1B1g1hEXiSNwarB7psL2Oox85KsqERlLZVtRHvA
 hCE+8VAOKXPM8TgSQZDKA0gZ+WF9PcVhjiNsqhlfBSkvHd6pePVX19TMh+AjD1mAIF0aI51k
 /08vMM26hCkjkZ4ONixkS0JpX+HKWYNUvt7u8hCUpPrkAci1npLfYfYVn3t+JiKZthBbhsqL
 zuTiPaQjrhQ3BOfIX86FHyL1utBn5Ue/htNyQZadViOn9PEgN4x3QFQrmtrHlgEkE0f3rIhI
 HVvOm10Ob6KrmVhi8V0VmyxHx1MWU+C8UvrxlpVzGDUQiFEjIAWwLHR7QpVwH0kzg==
IronPort-HdrOrdr: A9a23:QlZUoK6gFCJyyURtAQPXwVCBI+orL9Y04lQ7vn2ZFiY7TiXIra
 yTdaoguCMc6AxxZJkh8erwX5VoZUmsj6KdhrNhQItKPTOWw1dASbsN0WKM+UyDJ8STzJ856U
 4kSdkDNDSSNykKsS+Z2njALz9I+rDum8rJ9ITjJjVWPHlXgslbnnlE422gYytLrWd9dP4E/M
 323Ls5m9PsQwVdUu2LQl0+G8TTrdzCk5zrJTYAGh4c8QGLyRel8qTzHRS01goXF2on+8ZuzU
 H11yjCoomzufCyzRHRk0fV8pRtgdPkjv9OHtaFhMQ5IijlziyoeINicbufuy1dmpDk1H8a1P
 335zswNcV67H3cOkmzvBvWwgHllA0j7nfzoGXo90fLkIjcfnYXGsBBjYVWfl/y8Ew7puxx16
 pNwiawq4dXJQmoplWy2/H4EzVR0makq3srluAey1ZFV5EFVbNXpYsDuGtIDZY7Gj7g4oxPKp
 ggMCjl3ocXTbqmVQGbgoE2q+bcHEjbXy32DnTqg/blkgS/xxtCvg4lLM92pAZ2yHtycegB2w
 3+CNUaqFh5dL5jUUtMPpZwfSKJMB2+ffvtChPaHb21LtBOB5ryw6SHlYndotvaP6A18A==
X-IronPort-AV: E=Sophos;i="5.88,352,1635220800"; 
   d="scan'208";a="63173378"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ciIZY99JrVWPZLp63BWAxNIG1Ek/cGq3S2vaD4MYo6hqRlVL+yoPzRUlxUFoO0GaYyEiMnrvfAGte3TFjP1MFTChUtXeTKsAcNDntXJauVjRgC+Yt4PH9KVBQEOoyfPciyRxcYK84NIGI6IeUpQlxEFtC/GdndR67Qm4kFfYgx/fz2Y7qYTofO1u8wgPJjsFQK5+iPo+fMRu4/utRAapHNm4JpnpM0MdUSEfOIeeVBD8br/iIwl9hzj3MOllt6JDDBb1BlSNMRGw39bQqsCFlNsmKGAeQmOvlIZ0tO7ZAPktDVG/J8oc2y80TfF7Fq7OBLd3MJDgI8IHbMWFI2VFiA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=VXTrqj0cgvFPzxmdLbPheuVvPwcmsAkPxuo+imp13tw=;
 b=gXGBlE6WP9w8ySpw9UsnPll8Ju0Lwk2vkmhZ71PuFdNf+dKkkaKqmLmYBKbGK1kGOWAmG+vvVcQjhPfP9aJkpcDWJFFFqiHMv425+cxrRa7TqbE3N9Dc9DyRKH9AuuoGaqQ9A554BzgwXop05K7VIuQhOOuC2MGkJoVJTgYiKasNfH0KiS9M5QrLMn6l+wGB7SD1DJsPVjvDZdJ7h8FPDNvJ1QFaf7rL0ZvXzzEenkhXdojRQZqEWjQQ5gl2kGr7hSD953zaBFP/Ar92n9Q3i6iun07lq7BjnMETCSKzMjgMY5GyLAJPBCbmH7P+cINH+q1dnfJDZbZMcUKM1wB39g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=VXTrqj0cgvFPzxmdLbPheuVvPwcmsAkPxuo+imp13tw=;
 b=k1GHvtoMNIeEU+DEXP60488Ma/GAh5BSxHVynpT48KcTq63kGZ6n3M1OK1DKyzsyEJ44JErmQ/xZ++QnKJGIpbYTa8OdSt/MbaU+isRvxDuDLwPwq+5BgsBtZ2DKUNHkrIJy5lTgBluq2ErGkq7hr24IIPSXyljV+U6q5X3rkos=
Date: Tue, 8 Feb 2022 10:50:05 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Julien Grall <julien@xen.org>
CC: Jan Beulich <jbeulich@suse.com>, <ehem+xen@m5p.com>, Julien Grall
	<jgrall@amazon.com>, Stefano Stabellini <sstabellini@kernel.org>, Volodymyr
 Babchuk <Volodymyr_Babchuk@epam.com>, Bertrand Marquis
	<bertrand.marquis@arm.com>, Andrew Cooper <andrew.cooper3@citrix.com>, George
 Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH RFC 3/3] xen: Introduce a platform sub-op to retrieve the
 VGA information
Message-ID: <YgI8zYClaW9Ar3FJ@Air-de-Roger>
References: <20220206192839.75711-1-julien@xen.org>
 <20220206192839.75711-4-julien@xen.org>
 <4da70949-7d6c-65a4-662a-301bb7075bc0@suse.com>
 <YgEJWLF/yp8YkU2M@Air-de-Roger>
 <1bd5cef7-a83b-cd51-2ae1-ae2f6db00385@xen.org>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1bd5cef7-a83b-cd51-2ae1-ae2f6db00385@xen.org>
X-ClientProxiedBy: FR3P281CA0044.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:4a::7) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 24364c45-965c-46a6-6877-08d9eae864f9
X-MS-TrafficTypeDiagnostic: PH0PR03MB5701:EE_
X-Microsoft-Antispam-PRVS: <PH0PR03MB570185A30D976DCFAB4C38438F2D9@PH0PR03MB5701.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: Gz2CLW9JrJ1GBBVU76TvRLlUvQ54T7glDalP3DggtHUP2jMVO7OAdToVTdGgV1Lkttxy6k28L1vy8hUgTDvS6asZ69oOuwdQG/wPxUOYiTXUAgEhhDiEA72lDrx2NJO1sGVLGGSK9qUMExd1d/Jm9j/UcqmZnGDducZa04WjewQxVgqUVxZxTd0qBmPkS39kNITf+lJsLcsOUHZajahLmFS0J7kRLF+WtVyeUzfPFeFj4kCGsytJLpn4HBS6O3mDzMF0NkBQa2fhJBEE/xDEWGFpHsB0pd2Oo3Ce7cgj/1FgL2K9jfC+g0XgopQ8yxkVgkRvTdeYbQQk2ka7iOxNXObrUWlqq9ZRcmB7y8c2l+ftHJ3RZo/7nc8uI16qKQHlMjPkFg5QztN83Q68pEvU1O3HNiiQKHw1/2ARUDo4QQw8g/oSbxuMcmrg79ahnwdcAGytK+jmxI+4uugupEk1x3BhBJEAeUaJDtELteyIxWi+9olIxLuO+pqChdHJK2gdBrLDXASkyocbihxE2OnjUTTGgTXKUHlg0cLyc+hiACfXg8DYJqsvN8Lo+c1gO0/KEf5I4G9fvuCR8zftlZypLtL1GNTKzzx97BJNF+spkK+n/MIwpzIgHS2Fd4HVpuOuogO2OxGGTNTybxjQ+xdMZw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(54906003)(6486002)(186003)(82960400001)(508600001)(6916009)(5660300002)(8936002)(4326008)(6512007)(6666004)(9686003)(2906002)(86362001)(6506007)(38100700002)(26005)(53546011)(66946007)(66556008)(8676002)(66476007)(83380400001)(33716001)(316002)(85182001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dzZXWXQ1ZGNiVGt6cWZkeHU1RUdXbmVwblY3M25BUGpUT2x2R3htZ2IybHR0?=
 =?utf-8?B?S0c3cnpnejF5QVFLZkcxSFNiakYxekNhV3A2OTVNZHJxZzA1Um4xbUZoRXhR?=
 =?utf-8?B?UEwzRHJoWjg2a24vUnBJcmpEYytkZHRvZDBMZ3VYUk05Uk0xUHp1c1JFNGR6?=
 =?utf-8?B?djRRSGhEWGFuTkJIYkUxb1VEdTQrZjNOZ2tONjBsMkdHN3BvNUMwZDM0c3ht?=
 =?utf-8?B?Nm1XNldjQkFSVExzQ1RQMUVlVXIzUmVqejQ1Yi9OUG5kV053cXMvV3ZLNmZ6?=
 =?utf-8?B?ckdnNWtJekhldGErZTE0bmh1QlZrUnJzT3F6M1BBeUVZTGRmWVBDYk1VRFBQ?=
 =?utf-8?B?c21mRDlxNGJCZFlZMWI4Qi9hR0hWSzAvaGZrRFVGNTE4WkZmTjZnY2k1TXJB?=
 =?utf-8?B?aWt0V1lvS1g1bTlLM1NOVWJnaXBXM3UyTFF0ZDdEaENrQjFMci90Mm43TkJ2?=
 =?utf-8?B?bjZIeVE0ampnWmNMNm13WTZGOXFLMmg3QnAybmdJUnVrcEpMQzlJZEcxa1hn?=
 =?utf-8?B?dGpVZ25lYlAzcXBpQkRDZXpybWtoR09ycStLT0RvSlRZTjVheitxR3JHbGd6?=
 =?utf-8?B?ZkMrazUrSzMyN1pCeXZ1Z1B4WVpwNVZSTUxwMzRGL29aR2k2UEtBZi9tT3Ns?=
 =?utf-8?B?Uk1YcFNETjF5NURmY1dnVHBuaTBrRHZsaE82amltVFFpdytXTmdsTEhkZGpB?=
 =?utf-8?B?Ly93c2RQbFh0SjlIMEdvbzF5R2RPT3JtNU9qS1crTFZvdEhwSFdSZjBrZUJ4?=
 =?utf-8?B?NUpGTjVRdHVaS0ExMzBoRUU4VlhKN0V5dnlJU202aW84cTRXbVh5dy9raDg0?=
 =?utf-8?B?Q2h1ZnpldklvVUJNeU9mTEVWeXU0OFEzQnNlU0pUNG5OVXFIcTBTcVJoOEk4?=
 =?utf-8?B?ZGdKaUZuWjN4UjJjdVAxeU5Yc1NCay9mU2lidm9PaThtSUdTc0pOU1h0bTlO?=
 =?utf-8?B?TjZvWnRQTWdpcHNhWkpPS3lScjNqdkp0bVVXRzRwcDIrd1FLeFloSU1KOFkx?=
 =?utf-8?B?TDZmOXFxcGM3NGlUclVYdWlQODNaUkhiS0tqZHVIZW0yUXB6UEgzMWhaWkh0?=
 =?utf-8?B?WVFOWFZsTWNOaVd1Q0ErY0JOYXE2N1Qyd0RaZ2g4VCtLZHh5cURqbWZlOFR5?=
 =?utf-8?B?OTh3VnZkaCttUFVwRjZ3MFpZOUZ0Qnp5Y3JKZXpCV2VzQWhObzhNTnJxa0Qv?=
 =?utf-8?B?S0hRSmc4ZERSbDFWKzhBR3ZrbVlxZW40OTMxNEJIdHBPTm9HZEovR3A4Z0I2?=
 =?utf-8?B?N2NheFIxRStSTjFPN1VsRFhmQkFKNkNxZDI0Q1NHb2hUK3A0ZDk4aGNuQWZI?=
 =?utf-8?B?UFdKSm5EWHN4SHc2ZFA4Mmt0OGVzNFlTT2pVMmVBZnU3WGlXWDJYRkNwcitC?=
 =?utf-8?B?Q09yc29lWlUvSzN1dlRLMkhYdkR5VTlQblFRTlpDUVlWVnR2d1NtU0ZGNHFG?=
 =?utf-8?B?K2FSZFlLdUtoMGV0b2o3eUlHejVlbGdOTFlldkN4ZEtRTjJLQk1tdHhCcXl2?=
 =?utf-8?B?SFB2WVhVSGVHL2VXQy8xRmFULzB3eGFpMlNTR0MrV3pMT0VUc3EvM1ZtSVVr?=
 =?utf-8?B?K05HbWVDdVJlek1LL3NKd1ZnQmhycElJdGRoaHlkdWgvUGxnZUZhdWc2S1hw?=
 =?utf-8?B?cUN1UzhCVlFiUVpydlRZRk5MYzY1TU9Ed2txUDJTN1lZZ2l0bDMyVFk0NGhw?=
 =?utf-8?B?QVB3eFEvZHJFdnN5ZFJwaHRYZ2gwYmpSa2NLU0dZUFlnVmJQQW12QWEwQVJm?=
 =?utf-8?B?YTlvWmpoMVdYUnc2b09yK2xoRVI1L3ZGb3VVYlZrWXBEcXc5SW5QeWFIK2VZ?=
 =?utf-8?B?eFpmMlZLRVdzZzhySzNtc0VaaEhEaDdKbFFRRHl2SmVmcGs4RUZ4dHFHTjFp?=
 =?utf-8?B?R3EvYndnT1VhaVdwTWkycjFDcHU2WU9ZMllSWHo4UlQ2NHZnUlMrOUdqZy9Q?=
 =?utf-8?B?dUYrdDRaN1U2VDBSZFR1L2NBU3M5Z0xSOGVJME5obWRNajkzU0tVR3E4Q0FT?=
 =?utf-8?B?NjhzVS9rOEVLUFNaY2E2c29UY1ZBaEliaDJGQXV3aUZKUWkxNEc4U1NSZUxY?=
 =?utf-8?B?dTNqRUhBL2lackhkUkdHK2wrbncrMlFkdmFReWt5aElabUpTWThpcDFQY3dx?=
 =?utf-8?B?Y2VkTnhxRlBjNVAyQ0d0TVdvRE9KN2h0NFJIbmpuNTRDWjYyQ0pmZVpRcjAy?=
 =?utf-8?Q?P7G473l68Ad/TlHvU1nrryE=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 24364c45-965c-46a6-6877-08d9eae864f9
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2022 09:50:09.8107
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PdQQ9FIrVI6V5SMTPTQ47ebwz4dLAF2yB9UMQKqrJbSRETuQipKnAUVr3opPTIKl+KjWGWfHrpS90Y0OuZ5UtQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB5701
X-OriginatorOrg: citrix.com

On Mon, Feb 07, 2022 at 07:24:12PM +0000, Julien Grall wrote:
> Hi Roger,
> 
> On 07/02/2022 11:58, Roger Pau Monné wrote:
> > On Mon, Feb 07, 2022 at 09:57:55AM +0100, Jan Beulich wrote:
> > > On 06.02.2022 20:28, Julien Grall wrote:
> > > > From: Julien Grall <jgrall@amazon.com>
> > > > 
> > > > When using EFI, the VGA information is fetched using the EFI
> > > > boot services. However, Xen will have exited the boot services.
> > > > Therefore, we need to find a different way to pass the information
> > > > to dom0.
> > > > 
> > > > For PV dom0, they are part of the start_info. But this is not
> > > > something that exists on Arm. So the best way would to be to
> > > > use a hypercall.
> > > > 
> > > > For now the structure layout is based on dom0_vga_console_info
> > > > for convenience. I am open on another proposal.
> > > > 
> > > > Signed-off-by: Julien Grall <jgrall@amazon.com>
> > > 
> > > Cc-ing Roger as this may want using for PVH Dom0 also on x86; my
> > > first attempt to propagate this information was rejected.
> > 
> > I think it's easier to use a Xen specific layout in XENPF, as that's
> > already a Xen specific interface.
> > 
> > I wonder however if passing the information here (instead of doing it
> > in the start info or equivalent) could cause a delay in the
> > initialization of the video console.
> 
> My current plan for Arm is to issue the hypercall as part of an earlyinit
> call. But we can do much earlier (i.e. xen_early_init() which is called from
> setup_arch()) if necessary.
> 
> This should be early enough for Arm. How about x86?

Yes, I think that's fine for x86 also.

> > I guess the same happens when
> > using the Xen consoles (either the hypercall one or the shared ring),
> > so it's fine.
> > 
> > > > --- a/xen/include/public/platform.h
> > > > +++ b/xen/include/public/platform.h
> > > > @@ -244,6 +244,7 @@ DEFINE_XEN_GUEST_HANDLE(xenpf_efi_runtime_call_t);
> > > >   #define  XEN_FW_EFI_PCI_ROM        5
> > > >   #define  XEN_FW_EFI_APPLE_PROPERTIES 6
> > > >   #define XEN_FW_KBD_SHIFT_FLAGS    5
> > > > +#define XEN_FW_VGA_INFO           6
> > > 
> > > Perhaps s/VGA/VIDEO/, despite ...
> > > 
> > > >   struct xenpf_firmware_info {
> > > >       /* IN variables. */
> > > >       uint32_t type;
> > > > @@ -311,6 +312,7 @@ struct xenpf_firmware_info {
> > > >           /* Int16, Fn02: Get keyboard shift flags. */
> > > >           uint8_t kbd_shift_flags; /* XEN_FW_KBD_SHIFT_FLAGS */
> > > > +        struct dom0_vga_console_info vga;
> > > 
> > > ... the structure name including "vga" (but if the #define is adjusted,
> > > the field name would want to become "video" as well).
> > 
> 
> [...]
> 
> (Re-ordered the quote as it makes more sense for my reply)
> 
> > There's no need to propagate XEN_VGATYPE_TEXT_MODE_3 into this
> > interface.
> 
> So for Arm, we are only caring about XEN_VGATYPE_EFI_LFB. I wasn't sure what
> would be your need on x86. Hence, why I keep it.
> 
> If you don't need then, then I am happy to trim the structure for the new
> hypercall.

Oh, so I was slightly confused. You are adding a top level
XEN_FW_VIDEO_INFO, not a EFI sub-op one. In which case, yes, we would
need to keep the MODE_3 as part of the interface.

> > It's my understanding that this will forcefully be
> > XEN_VGATYPE_EFI_LFB, at which point we could consider giving a type
> > name to the vesa_lfb field of dom0_vga_console_info (video_lfb) and
> > use the same struct here?>
> 
> Just to clarify, are you suggesting to only pass video_lfb? IOW, we will
> always assume it is an EFI framebuffer and not pass the video_type.

That would be the case if we add a XEN_FW_EFI_VIDEO sub option, if
instead we add a top level one (XEN_FW_VIDEO_INFO) we need to keep the
mode 3 support.

It might be best for x86 to introduce a global XEN_FW_VIDEO_INFO, as
we can then convey all the video information regardless of the boot
mode.

FWIW, I'm not a huge fan of the struct name (I would rather prefer
video_info or some such), but that ship sailed long time ago.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 09:52:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 09:52:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267917.461676 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHNAQ-0003ck-Sr; Tue, 08 Feb 2022 09:52:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267917.461676; Tue, 08 Feb 2022 09:52:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHNAQ-0003cd-Pj; Tue, 08 Feb 2022 09:52:10 +0000
Received: by outflank-mailman (input) for mailman id 267917;
 Tue, 08 Feb 2022 09:52:09 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=v7zX=SX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nHNAP-0003cV-9R
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 09:52:09 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c754cd59-88c4-11ec-8eb8-a37418f5ba1a;
 Tue, 08 Feb 2022 10:52:08 +0100 (CET)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2112.outbound.protection.outlook.com [104.47.17.112]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-28-sznXnPTYOlmGs7LbJpMj9w-1; Tue, 08 Feb 2022 10:52:06 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM6PR0402MB3606.eurprd04.prod.outlook.com (2603:10a6:209:8::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Tue, 8 Feb
 2022 09:52:05 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.018; Tue, 8 Feb 2022
 09:52:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c754cd59-88c4-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644313928;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=OJQJu6iiSQubJdVRUTTp1qHr67Drvf76PVl7Uxn22lk=;
	b=KqAAfLIGQyZJl3Ogg4U6ZxKLUz/LD0u/vyZZQEFAgNq0spuJoOF0sICVNUa6M37+xZ5Uad
	sDAI3TuOcl0HNH5s3ZWxolxH4fYzNtLE6RpJA4B5fUtMSQo2duB0EoJWcHoM0sdhzkjjSn
	ERZHgT9u82qaes7d4OFeHKapxf3stvU=
X-MC-Unique: sznXnPTYOlmGs7LbJpMj9w-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cUjSEfUeFErEEFXvEtqXo/ioXb8xAC0xP2mF1ihHapwpEm7dgsGRqK7dXLLKh8VnasQwvWBnUlfa2QLuIuOeG9SFAVHnI2Atq80OaFAz5SIT/UDfp8MCul/AEsK+E3VJCYlh+RZs2WEdldd28cmi5hsoiy1jTA2YVFk0CcAqU0E6eLiWRAMk8yN0KD517/vXpqvs9E2ArwU2GXFM8kfl9y6BpchUoY75ntwdAKLzEpg1YrGOGBT+2UbnyHDJGHoS4ei3F/F5QbaAkwk2r7A580tKfPGeXhhRgU4AdKUX6bliU50QyMXPTIFFfBA17TwJQoD1Xdjx8G2yN/mmRCYmqQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=OJQJu6iiSQubJdVRUTTp1qHr67Drvf76PVl7Uxn22lk=;
 b=HDIoHRIcFw7FGFoKKwVqKa0yUzC3mgCPUFJDARnlRfkiHL6qV41JGTf63Ya+g27OQn9fixnYgcg/Lz9OjY5CZ5h+zJi0v5/zk/tVSWItm8sTnomVNRMyW2Qhuy+hyrhX9A2CM4rbspQX9Cdcal/BwnlnbZwqSroMLhlEV+gk7TqGErL5TPzSfaWeeUHvFsWhw+T0UlY6QNrTr2sU77Mcwx3XYd8ztN1sPog1N8p0CaMZa8bQ17kkU7UeCwOWKyp6dpwPd5qGHJ/BmtQsDRyRee8r+59LHu+54TwR2unYlrkIl6ygWC+n54hLE7dRBmsU6mzlYutb39YJQOueDHeqmA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <186b7264-1190-3df2-415d-f1ec73a7c03f@suse.com>
Date: Tue, 8 Feb 2022 10:52:03 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v6 09/13] vpci/header: emulate PCI_COMMAND register for
 guests
Content-Language: en-US
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Cc: "julien@xen.org" <julien@xen.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Artem Mygaiev <Artem_Mygaiev@epam.com>,
 "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
 "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
 "paul@xen.org" <paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "roger.pau@citrix.com" <roger.pau@citrix.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-10-andr2000@gmail.com>
 <7df2379e-1c30-c362-3106-c7ef23af5c73@suse.com>
 <0ff2a524-9a65-861a-df87-cf3f682862d7@epam.com>
 <140e163c-87d0-2ae8-d57b-7ebc6757de9e@suse.com>
 <08d02313-349d-9ad4-926d-0d1419866363@epam.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <08d02313-349d-9ad4-926d-0d1419866363@epam.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0502CA0003.eurprd05.prod.outlook.com
 (2603:10a6:203:91::13) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e51a5a5f-f396-4770-f637-08d9eae8a9c2
X-MS-TrafficTypeDiagnostic: AM6PR0402MB3606:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR0402MB360681FB3E989F2A2E39984FB32D9@AM6PR0402MB3606.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	6S7l8Fwuu00OstwFmEFiq7Ih5wg84BoA7/CB7R3kXmCShqw5EVeDTubA7uwTm8GtjaY6FdIPC8mGR3cibDeZm9qWK6V9Irlyg2BR3zqHExyHVRn5jEddZjh+KoGvyySQ0fz5SFSQq/kUuNYdedqUiTtumYPBXicHjOSG9w0loEUuEBqt/o/MSeSWVWQcSZ1sLbnIItn+pDkV4OeH5vATLTXoEnYHEr8tZEUo0vhcCZkKCaqyOvB+V/n/pjNR0Viqs6NsFGN/njFTaDIpAJWop3KN36lhU0Khr9CDAzD4tscn/dJeSATAC1anB39MMloK+fBP/rDzrNXYnWZxJ8lODs/ncsv6lUyENZ8D/1pmZ2bGe8BybDBH01qGfufeoyvXMkzmVd7gfZzxCNxyFTPoqf5X6UsXZkePJ3vr7AHm+HdeT+hEFhtPapv32P7gE1S+XR60Uvicxd9lI40+Dh9oWlwRrDvn0JF31MChECNrRrD6FS1W4gqEsk0ljlVWGDty+opz50C6Tt4MQCI/joxK7Hb5t2fRew5UnP/VguRWS4UZchHPLv1NHy36i42WIpGpYWLMM/CmfbDMhxA4Kw/s6MyQKPqWpPqkkSEYT09sPnNZO1wCCMtRrHAfoj8dy9wcTKdflPf58Kg18KACTcwGotThRnEJdbT9wYv87vEFu8DGRvZO/4gbl+xH7OLyPbg5r5E66tpP2kfSqjhUuBGTd/yPWIy4RY+C0/Dn2tkR90s=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(83380400001)(38100700002)(5660300002)(6506007)(2616005)(53546011)(6512007)(7416002)(4326008)(66946007)(36756003)(8936002)(54906003)(2906002)(8676002)(26005)(186003)(6486002)(508600001)(6916009)(31696002)(31686004)(86362001)(316002)(66556008)(66476007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aEM5eVp1bVg1T09icFR3TmxMTmE2dzN0YVFBT1pyNDBNd2xrVG90cElodjIx?=
 =?utf-8?B?Sk1LeTJuSmR5SzJ2cmRNTlIzM1A2WVErMXp2RkV6M1Z2REdKSFhFZG9WZFox?=
 =?utf-8?B?OWgrc3pXZmNGOERqNm1CWlA4WURvMDBWTnUyb0pVR0RlYVBUNlRHMDliRjkv?=
 =?utf-8?B?L3c3OHpaTmpQZzh0aUxvQU5haDlWTWp4TXRKd1A0cDRmZ1FTaExmMHpIWjFr?=
 =?utf-8?B?S243N1pIT3ZOSTVJbCsrOFc4TWgvNnNnSDhSVlJwb1pjNW0wT0V4L3FwOGVE?=
 =?utf-8?B?Y1BjWWJSb3l1b2dqbkxNNHgvY092TmRhWklqS3ViYnh5YXJWdnpub3BRTm9Y?=
 =?utf-8?B?Z0wvSTAvSzNma2cvNHkzcy9vbm90ZlkrSC8yeVZnRFFyOGk4TGtKRThHL1lB?=
 =?utf-8?B?VWtLTlJEa0xueW1vd3NaYWM4QWVsVlJ2SG1sRnY4UXd4ejBmR0VxZ3NkdWpH?=
 =?utf-8?B?UFNJMkxnamRlSnhxY2lvaTVGVnpoSk9UQnEzc29BUXZIRm9pdTN2NnUwNVhT?=
 =?utf-8?B?NVJVRFczSVg4QlV4TEo1TTNhTVRxVzBYTlNRT3gydllESUdWNEkxZDR2WDRw?=
 =?utf-8?B?MW5NMkUxOWlDTGxueVpnMUdOQWxPWTVWUTVVVVZDQ29JWWU0VXUwWU1xQzFl?=
 =?utf-8?B?Q0NUYnh1aStlN1U0bW5wR2d1S01NZzFZcTZPN2FUYzFzMVRkN1JOSldoRDU3?=
 =?utf-8?B?QUZkSXkrTTBwS3Vsek5aeTVDN0EydHBSU1duNDNSTHMyMjVLTmFGaG51Q2N0?=
 =?utf-8?B?WnVYWEhGdlVlWFBtNkxWeUI2cC92aEEyUi9oa3FCQ0FKTDVPeU1ZdUozenhK?=
 =?utf-8?B?bHNoZEowbDZyNnFTWURBTTFvZ01ndG5aN2tXb2hSRWpwajY2anUwYmV1UjJC?=
 =?utf-8?B?SjhhT0V0TmtJS001emlCeDJvcFYwUUFZT2k1eDdFMEwrdVhlYW8ydlNNbGEx?=
 =?utf-8?B?OFJaZGU2Ny9XU1ZYMWh0dVVrVFNJMDlPRG1WYmdXZjNlR2c3d3duWVRWL01u?=
 =?utf-8?B?YVZrR2JYRlN3U09tK0JUbGwvMEdzbTNNMW0xVi81NENQVHJMOTh2YjV0NERh?=
 =?utf-8?B?RWs0ZkYzQTdicDFmR2REN3pUTkpQRGh5YktFcEpoaFZ6VGI5aXFuVFhqUkpw?=
 =?utf-8?B?c0V3d2NXUnAzVjgvTGNSRVhuMFlMeGRlTjcwam9QU2N2QU9SWXlHOThtenpl?=
 =?utf-8?B?VGZmc2VHRWFqQjJYV2t4bkJPc1p1bEQ2Q3FRMmVsOGVtaUhQUGczOEREa29E?=
 =?utf-8?B?OG56dFdhZVJoLzdFYjZic0E4cFNyeGxjWXM0eSt5eXM4d0NkUDJpQkZ6Skdj?=
 =?utf-8?B?S2cvZzFoWHU3NDlsRW93ckEydGNINENaVFQvNFRqQi9VUS9MdFQ2OXJiY2VH?=
 =?utf-8?B?dW5lbXJzT2VsRFBDeU9RVkN0SmgwWDFZNTNWUkM0RWhNc2NLZWFyNkxmTlFK?=
 =?utf-8?B?ZmhFYXFkcEZ3ek1pZEloVXdBQ09YeUVSMTZqREZISkY5U2Y3Ty9uaXo3b1Iz?=
 =?utf-8?B?MDFDU2w2TGUwOXNNemVBdDNtWGZGSHczdGt6MmhlU3hlZVVLOEp3empIeWx1?=
 =?utf-8?B?QVhzNndDTW92ZlZKUmRyUUt2dWxKajV2bzhmRXpTRlltN0M4dm9rcnVSYXpO?=
 =?utf-8?B?QkNncW9seVFYVS9nTWo4SDhMVngra3NBOHlYNkdJQittbzlNeVlBdTZxSE1o?=
 =?utf-8?B?dWtMZDdHb1VXb29rWE9Mb2VmNHlFTXFQUCtrRG5QRGE0bE9tN3JBV2M3OCtE?=
 =?utf-8?B?aFZIcmNldEZkTjQwbmIxdElBU2lYNmNrcDZNK2RUc1RqZVNuQWdVVUl5THlV?=
 =?utf-8?B?anJSV0sxdHlqOG11NU5OWXhZWlhjaUxWSERrTSs5M2EzSHNnUGdmai9WMi9N?=
 =?utf-8?B?N0NUclJKZjZKanEwMU9tb09LbmFVVng0cW45VHhrcHJqTE0xbnRCNHEzUnhw?=
 =?utf-8?B?L0t6Mm1EdnB2bVFHcEVBN0tXMGJjRDZYVERaZEZtaGRCQlliWXhLU2pzVHQ3?=
 =?utf-8?B?OVhQaTlHNk93RFBkMWxpUnZIZW5RZTIybHJmcVdhSVZBYzh4SnRBWDc3K2xo?=
 =?utf-8?B?enZVSEdEYnhma2lHK3FtQnp6YUk4bkY2YzNrNHRKUU15WnRxbEx3d3JQMURR?=
 =?utf-8?B?dUtqLzN1ZCtJa2gzVTNqblRLaU9DZWdjRlhONUswRXRyWGNiTm5BMldGdkQy?=
 =?utf-8?Q?MwhmLfjnA9QP9fAwrU9Zoxg=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e51a5a5f-f396-4770-f637-08d9eae8a9c2
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2022 09:52:05.2480
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rnnx2XmNJCOWai2b0V1mWI/YxbUraKDCieaRBr1fi7Lgrm2tgJlEL4Ghep+f9yhNbENT7FAhbEdBmGS2Jvg1Jg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR0402MB3606

On 08.02.2022 10:38, Oleksandr Andrushchenko wrote:
> 
> 
> On 08.02.22 11:33, Jan Beulich wrote:
>> On 08.02.2022 09:13, Oleksandr Andrushchenko wrote:
>>> On 04.02.22 16:25, Jan Beulich wrote:
>>>> On 04.02.2022 07:34, Oleksandr Andrushchenko wrote:
>>>>> --- a/xen/drivers/vpci/header.c
>>>>> +++ b/xen/drivers/vpci/header.c
>>>>> @@ -454,6 +454,22 @@ static void cmd_write(const struct pci_dev *pdev, unsigned int reg,
>>>>>            pci_conf_write16(pdev->sbdf, reg, cmd);
>>>>>    }
>>>>>    
>>>>> +static void guest_cmd_write(const struct pci_dev *pdev, unsigned int reg,
>>>>> +                            uint32_t cmd, void *data)
>>>>> +{
>>>>> +    /* TODO: Add proper emulation for all bits of the command register. */
>>>>> +
>>>>> +#ifdef CONFIG_HAS_PCI_MSI
>>>>> +    if ( pdev->vpci->msi->enabled || pdev->vpci->msix->enabled )
>>>>> +    {
>>>>> +        /* Guest wants to enable INTx. It can't be enabled if MSI/MSI-X enabled. */
>>>>> +        cmd |= PCI_COMMAND_INTX_DISABLE;
>>>>> +    }
>>>>> +#endif
>>>>> +
>>>>> +    cmd_write(pdev, reg, cmd, data);
>>>>> +}
>>>> It's not really clear to me whether the TODO warrants this being a
>>>> separate function. Personally I'd find it preferable if the logic
>>>> was folded into cmd_write().
>>> Not sure cmd_write needs to have guest's logic. And what's the
>>> profit? Later on, when we decide how PCI_COMMAND can be emulated
>>> this code will live in guest_cmd_write anyways
>> Why "will"? There's nothing conceptually wrong with putting all the
>> emulation logic into cmd_write(), inside an if(!hwdom) conditional.
>> If and when we gain CET-IBT support on the x86 side (and I'm told
>> there's an Arm equivalent of this), then to make this as useful as
>> possible it is going to be desirable to limit the number of functions
>> called through function pointers. You may have seen Andrew's huge
>> "x86: Support for CET Indirect Branch Tracking" series. We want to
>> keep down the number of such annotations; the vast part of the series
>> is about adding of such.
> Well, while I see nothing bad with that, from the code organization
> it would look a bit strange: we don't differentiate hwdom in vpci
> handlers, but instead provide one for hwdom and one for guests.
> While I understand your concern I still think that at the moment
> it will be more in line with the existing code if we provide a dedicated
> handler.

The existing code only deals with Dom0, and hence doesn't have any
pairs of handlers. FTAOD what I said above applies equally to other
separate guest read/write handlers you may be introducing. The
exception being when e.g. a hardware access handler is put in place
for Dom0 (for obvious reasons, I think).

Jan



From xen-devel-bounces@lists.xenproject.org Tue Feb 08 09:55:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 09:55:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267928.461687 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHNDl-0004FG-DL; Tue, 08 Feb 2022 09:55:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267928.461687; Tue, 08 Feb 2022 09:55:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHNDl-0004F9-AC; Tue, 08 Feb 2022 09:55:37 +0000
Received: by outflank-mailman (input) for mailman id 267928;
 Tue, 08 Feb 2022 09:55:36 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1FiY=SX=epam.com=prvs=40383cc40e=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nHNDk-0004F3-GA
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 09:55:36 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 41da04cd-88c5-11ec-8eb8-a37418f5ba1a;
 Tue, 08 Feb 2022 10:55:35 +0100 (CET)
Received: from pps.filterd (m0174676.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 2189rkCt002992;
 Tue, 8 Feb 2022 09:55:31 GMT
Received: from eur02-ve1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2056.outbound.protection.outlook.com [104.47.6.56])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e3p9gr06j-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Tue, 08 Feb 2022 09:55:31 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by PR3PR03MB6363.eurprd03.prod.outlook.com (2603:10a6:102:71::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Tue, 8 Feb
 2022 09:55:27 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77%3]) with mapi id 15.20.4951.019; Tue, 8 Feb 2022
 09:55:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 41da04cd-88c5-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=QcY3BnyU0C76RuHptxdHYDJM4MlsbGsuKaW5vhPVy5auXSpC6EQ3ORfdTsyTxyX3VQsAuNcpUzkDffYKZm3K9e5P+I5ghTBfPFPvEZGRZuT8dkVzg1b4GjxGaje4sXtsdAoPkI8Zpz8J8v8XzvkYpoy9hFavQT6TS31kJAJmQoncngnZNKZV5dtUZnPqOjXncQKOSNHy3ctIUKxNbNLXy8sCh+Ld8XFUNyew4LDaNlH5oXBtkcWnvcfamP6EhygPw8yIJoEKcvPupNxheNBpKNvwJSQe7zlwAu2FB6vc7L4sIUPS4bG9CUgIaibLG9B3lFjGJ3CJyzGBgF6viFcQmA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ELE4ept9w7zonXmv40CfvMpz45CqGkgRm7/PIfSpHXs=;
 b=AYAWhKzwDLWLC2CNXD1Ct2k/+43fCxOGEpoUS617sQtF1yzbX8/tSTBX/4hw0Di88vOvZ3Wpnd/hA+2dQQxzFV99sbmU62dlpwMvrPi5qcB6de/FUAILcizTsIDIrjwt562CoxcGg4Dx7jLfZhfps2HvZObmHd6IsI30XrU/rxJ57LhevIw/aq2J82ktilNf97FO2ZtdKjRFiaJ5xTMyQuiimEK8rogRp6GLisfWEX9DffaZcAtDGQK0oh6nW1yTN/HuT8h6xRksRrmHqv1M1mYwCI8dRmkY7H2uuyjoUecL+OGbNm1B3HkItPaBaZO1sp7HAfw6HYj51GLrnlkmiw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ELE4ept9w7zonXmv40CfvMpz45CqGkgRm7/PIfSpHXs=;
 b=Gqph0VkXHhBQMiXbhCnr/8NuFOGWFOVW+4qiHHMKGynWaqWbqogg93Xy+9Hju9yfYr7FMm4zS1hbKrDWWV7+rIYTAbAE28iy6xrNHY9xEkngLRuoGnINzsiWx902UL54HAo2k0SjXti6vJNgh3lfhPGcXh688xirJk7vRTvmq19GjqPoD+WciJb/lsBtVb8urOa6j499d5WJ3OSaV3StcqvtRnpj6i0zX1EMn2ZVxDs3ejfKmF37SHx966w6iSfwgcgmjBcsOcHG5LTbJWKAmNC27+Xg/NIZuO1Usl3IGJQAKaKagDtS+zzcOaNCxUcdWG9bkeFdyhHuwsXo5r1ORw==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        "roger.pau@citrix.com"
	<roger.pau@citrix.com>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v6 05/13] vpci: add hooks for PCI device assign/de-assign
Thread-Topic: [PATCH v6 05/13] vpci: add hooks for PCI device assign/de-assign
Thread-Index: 
 AQHYGZFdYv4W1RdbQkeQtzN+PyKqmqyITGQAgAENNICAAAt2AIAAA+uAgAAEsACAAAMyAA==
Date: Tue, 8 Feb 2022 09:55:27 +0000
Message-ID: <9f58a8ff-44b4-3249-5858-9988644b2d4e@epam.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-6-andr2000@gmail.com>
 <16cea1df-3d0f-d404-2b88-aab47ad5548b@suse.com>
 <3fe6dbe3-51c6-f87f-23f9-cf2e1a924326@epam.com>
 <582ee8f9-7b01-4adc-6a8a-ce8b1dffd534@suse.com>
 <e225553b-b29c-0448-fb9f-f8b513d9f77d@epam.com>
 <0fd8a0ac-dc91-287e-536e-1684892837ab@suse.com>
In-Reply-To: <0fd8a0ac-dc91-287e-536e-1684892837ab@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: e4961d66-d7da-4379-81f6-08d9eae92292
x-ms-traffictypediagnostic: PR3PR03MB6363:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <PR3PR03MB636358141310BD29F6D444EFE72D9@PR3PR03MB6363.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 JQg6gpmmifsgmbcicKoPDgXCegIgSKNubvEyjSr6KKk2WUlg9R3EytkjMawBvwTDdnCZVlBGYKGAeHIGXPWIMItZbsyT7wlMX3ELDiYisdqYlcdj4r+iDuxEHdGeo+iNoRO3qcTs7xAoc+ptIlMWCR+seskD2xzxluda2Uh8QMp8+YQp51KkPf/m+TVG+oyWxO7ro2lGRomCLZNfeofXn5Spbw/eVu6VCBR6E5d6c7JfDsC+hk8SFU6KkJFn2B5wNVlRp9zzODD0nMINDm2xOBZMsFBWPGWAawGZobYzMk5tKuRY0qC8C+dpuw6ugMSb+wHzKhXeUHzjqY6xUhA67y2p6d4+8mCPGmtmgyofLP72RwIPSaeXz6Ss9lvcXHvFXHsX1AAj5lQB/V08DNrWLuO2cFAAKZkYezOJcc+IJBsTKfhJdeTKmw2LKjI8B0/E5gdQ1uqwQTexL6aTe7hxYMRQYf7n5ZpgYNMf4O3bmKmWiZcxWE7q6Jdb0wSsy9WKZ9vYkjYk+DSTgfUx+ojfEyeFuWZJrHfo6eOxI//FuAJufDWffYvLFYWwnMwgzNFAIgXC33vpk9aRJLNzpL3556v+TATS/JOh8nL5mFK8CeTxdA21wVebuaq3XYW2gIXZVeqxmusB1VE/LjG6fdiJmmM8gsOKecXKWekunAmGCGCNFIo5muxOrIN6YPEcCCHbuWa6mMrV9+jClfcFy+5/2Szl42DGDn66hGddFXA2lPhikmzfX08i/nZypYCfzq2e
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(83380400001)(38100700002)(5660300002)(6506007)(2616005)(55236004)(53546011)(6512007)(7416002)(4326008)(76116006)(66946007)(91956017)(66446008)(36756003)(8936002)(107886003)(54906003)(2906002)(8676002)(26005)(186003)(6486002)(71200400001)(508600001)(38070700005)(6916009)(122000001)(31696002)(31686004)(86362001)(316002)(64756008)(66556008)(66476007)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?WC9TNWRqdkN5ZnU0Vk9zS01JUUxWNkZjenc1MmRaSkd4RklkN1Z1QXBBdGRj?=
 =?utf-8?B?MHNhd0xiSGJZNFQvenBGVys3c3gxQzlmcHF2VEY4ejJyTlp5c2JRMTcybXpw?=
 =?utf-8?B?MmRua1oyNjZ6VllNd2JYNmpod0pxZEtxVTZKY0cvcWwzeUFVd1RNSitibXBJ?=
 =?utf-8?B?SmVoQkloRjNkYnArVVluMVkzbGhkVzkrRVNkT2pNUEhnNTZvMXRDRld1Zzlx?=
 =?utf-8?B?Y1JSSTcrbFlSYXA2U0xGSFhTMFJnUTFtSGFsNG9MOFlpbE5pU2kxay9vNUZ3?=
 =?utf-8?B?ODRmL25ONzN2YlY1QmxkZkRhczdMdXVidEJhZVNMQVd5MHpMWEcyeDlaa1RR?=
 =?utf-8?B?NnJsYkgxZ3BuQ280bU5oU3RFeWRzU0FQeDFNM3dQT3E4NmdtOWF0U3V0aUY2?=
 =?utf-8?B?UC9US3lxdjBuSVUraXcwbWNjZzBRRi9hM0UyQ1R1T1hxbEphblUvazJSMVNz?=
 =?utf-8?B?aEl6Mm5ac0NRTGJGWVVBcUtveWZJQ2dSa3Q4WStGNG5adUNGb094Z3dnSU9O?=
 =?utf-8?B?a2xwNWpmaFpwbElsT2EwSXNMVVBNdm5DWWJSeUxCZ2dBbmtFVUgrRWNEZ01p?=
 =?utf-8?B?ZExENFdmN3VTYUFTM0N4KzNkbTNDOXdUcmZKcGQrUlF1R0VQUUhjNnN5dkIr?=
 =?utf-8?B?TDZVV3BxNjBHRlA5VGpLTTVCaUM5RUxhWitHTWVyUlhGVWlZQjREanRTdDlI?=
 =?utf-8?B?U3BCbkZSSFpraVlOdDIvL29HR0RJYzVEZTlvWFgyejlZVHdpbU1yS3hMZ1RS?=
 =?utf-8?B?MlFXam5tYzdCajdGaTdpQ2E4aXJmVFg0RTcrUzFteHA3MEQraHNWNDBMKzdN?=
 =?utf-8?B?ZER0UTFDYTlVb1g1R0tIMFRnTHhlei9zUXRQb0l2QWM5ODlqcUtndmN6bElH?=
 =?utf-8?B?clRjbHJJMXBBZHlVaTBDdGQ1Q0EyRUZLSUd6Q0JzVmgyYTlHYlZzVElUNjJm?=
 =?utf-8?B?RzdLTk4vR2x0ZExtSVAwWlU5TEtXUEhSaTJLMFM4enlaMExadjNLN2pHejNX?=
 =?utf-8?B?RDdETUpqQXFSWDc0ZU42eWpacHJuVWVIc3lhK0NSdUFQNXZlbC96MjJnQi9v?=
 =?utf-8?B?Q2l3RVJxMlBPSFZTWHViZkFWT0EvV3lSVXFCL0pvemNjS3NRZ2lpRjdPbjdI?=
 =?utf-8?B?WWExT00vREkxWE0yczhsWGl4czZlNytaS3lmaGttVmpmczlWSUd0dGVaUnZO?=
 =?utf-8?B?cXRDeWd0ZUVMNXlRV3JhT3F0eHBKUCtpV3lmcVg3Y3duZStNb0VhbGl4eGdB?=
 =?utf-8?B?V1Jpd0w2SGxtbncrZ2oxdkQ5bzhhem45MEF0dUw3c294R1VKS20wQ1FrSVVD?=
 =?utf-8?B?cnRySFdzUTlWeWxXTGJ6dXNiM2c5WUNFajU1WVNKeThDd2dhdWVkUWxuVkhz?=
 =?utf-8?B?M3FBOGZPWEk2UUlEc3o5eW41ZHBGVlgwWGRyZ2c5Vm9KNW5hQTB0d0lzVHkx?=
 =?utf-8?B?cHVVeU1PdEJPWVV5dzlIQTA3MGVXSEY0UHBwKy9QNmtwS2wwTkE3dnFNY0F2?=
 =?utf-8?B?Kzd0M0ozWVdtbWNrT2pPYnEvdWRic2paMThsZ2tvWXhXVDBUVkFNaVBra2pJ?=
 =?utf-8?B?bUtLdUtnWUhlTlZ2SnF3M1hiSHdKTTBpU1FPeG5SeGpicXNpWmd1MXcraUZG?=
 =?utf-8?B?NkVjUkpaRE9kZDFKRkRYN00vbUtoTlBRRG1XTHc2Vnl1U1dmTUllYUFLWDFY?=
 =?utf-8?B?b0tseGdYaWVQNkYrTXVBYUhqWjdjcm5HNTJTQmY4UDdSR1FDNzNWa3p1aTE1?=
 =?utf-8?B?M3FidkpITWpBci9NYWsrd1lmY2xIS0dPM1hWU252SXUvN05sUmpOWm9nY1NO?=
 =?utf-8?B?bHkyUURYdG1IZUVsYitvM0pNaGVxRVhNTWI0dVJXV2xTTk11bzczZW1vZEFZ?=
 =?utf-8?B?S083R0g0bzFSVzdmSlh4d2FsL1dIaWQwSmhYU0kvamFHSDRDdW9MeGVSS2Nv?=
 =?utf-8?B?d0h4ZGNpZG9WVWNyZnpDUndNNW1DTjA4WFFwMlNLeXVGcGMxekt1bHRBU2NX?=
 =?utf-8?B?YW56Uk1mVnE2bW0zMGhrejh4OFdxT1JUcitzRDhvaWtvY1FDT2hDMDBYdU1W?=
 =?utf-8?B?Szk1MWtzcVpVdTlEeFZkR3dudkRHTWkyZ0hRaTFXallFN0EzNm1zSFVxNURL?=
 =?utf-8?B?WTFtcnZ0ck4wZEI4OC8xRldFVGRqNW02ZzEvK3FJcE1WOUxvRnhGRGhrTW9D?=
 =?utf-8?B?TExZb3RpdHdsOU1zUVhBS2FpSURZWEFrb0xvNXE3cW1uNVBRbERab2pPbzc5?=
 =?utf-8?B?RTYyRkdLVFY3L041cTFnMzNXbUVXZmdPWjk0WlMvK1VIZjI5UFVKV2d4SExj?=
 =?utf-8?B?WXdhek83ekhnU0NrcEloZndkYTRPWXhscWsvYm9ZM1VVZTFHZkx4WHl3SFo2?=
 =?utf-8?Q?J4V+cRPsElG1+84Y=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <23893FAA6DC70D4EB49EAA710C9C8F87@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e4961d66-d7da-4379-81f6-08d9eae92292
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2022 09:55:27.6536
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: /A+Lokq3Bh886jzcgIhIkomsx1rSjv6jScOOGMDloq/GhDCfBviv4MngwnXuvNAfwdUx9du0xYgxqm1mn13NSPYw/TvyGsW1cogowuINX1Nz2HA4s7udUBt1ewhx/GeU
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR03MB6363
X-Proofpoint-ORIG-GUID: avZZAkafG9LlT4CPTSVvMc9lokojihXk
X-Proofpoint-GUID: avZZAkafG9LlT4CPTSVvMc9lokojihXk
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-08_02,2022-02-07_02,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0
 lowpriorityscore=0 phishscore=0 adultscore=0 priorityscore=1501
 suspectscore=0 malwarescore=0 mlxlogscore=999 spamscore=0 clxscore=1015
 impostorscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202080056

DQoNCk9uIDA4LjAyLjIyIDExOjQ0LCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMDguMDIuMjAy
MiAxMDoyNywgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+PiBPbiAwOC4wMi4yMiAx
MToxMywgSmFuIEJldWxpY2ggd3JvdGU6DQo+Pj4gT24gMDguMDIuMjAyMiAwOTozMiwgT2xla3Nh
bmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+Pj4+IE9uIDA3LjAyLjIyIDE4OjI4LCBKYW4gQmV1
bGljaCB3cm90ZToNCj4+Pj4+IE9uIDA0LjAyLjIwMjIgMDc6MzQsIE9sZWtzYW5kciBBbmRydXNo
Y2hlbmtvIHdyb3RlOg0KPj4+Pj4+IEBAIC0xNTA3LDYgKzE1MTEsOCBAQCBzdGF0aWMgaW50IGFz
c2lnbl9kZXZpY2Uoc3RydWN0IGRvbWFpbiAqZCwgdTE2IHNlZywgdTggYnVzLCB1OCBkZXZmbiwg
dTMyIGZsYWcpDQo+Pj4+Pj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgIHBjaV90b19kZXYo
cGRldiksIGZsYWcpOw0KPj4+Pj4+ICAgICAgICAgfQ0KPj4+Pj4+ICAgICANCj4+Pj4+PiArICAg
IHJjID0gdnBjaV9hc3NpZ25fZGV2aWNlKGQsIHBkZXYpOw0KPj4+Pj4+ICsNCj4+Pj4+PiAgICAg
IGRvbmU6DQo+Pj4+Pj4gICAgICAgICBpZiAoIHJjICkNCj4+Pj4+PiAgICAgICAgICAgICBwcmlu
dGsoWEVOTE9HX0dfV0FSTklORyAiJXBkOiBhc3NpZ24gKCVwcCkgZmFpbGVkICglZClcbiIsDQo+
Pj4+PiBUaGVyZSdzIG5vIGF0dGVtcHQgdG8gdW5kbyBhbnl0aGluZyBpbiB0aGUgY2FzZSBvZiBn
ZXR0aW5nIGJhY2sgYW4NCj4+Pj4+IGVycm9yLiBJU1RSIHRoaXMgYmVpbmcgZGVlbWVkIG9rYXkg
b24gdGhlIGJhc2lzIHRoYXQgdGhlIHRvb2wgc3RhY2sNCj4+Pj4+IHdvdWxkIHRoZW4gdGFrZSB3
aGF0ZXZlciBhY3Rpb24sIGJ1dCB3aGF0ZXZlciBpdCBpcyB0aGF0IGlzIHN1cHBvc2VkDQo+Pj4+
PiB0byBkZWFsIHdpdGggZXJyb3JzIGhlcmUgd2FudHMgc3BlbGxpbmcgb3V0IGluIHRoZSBkZXNj
cmlwdGlvbi4NCj4+Pj4gV2h5PyBJIGRvbid0IGNoYW5nZSB0aGUgcHJldmlvdXNseSBleHBlY3Rl
ZCBkZWNpc2lvbiBhbmQgaW1wbGVtZW50YXRpb24NCj4+Pj4gb2YgdGhlIGFzc2lnbl9kZXZpY2Ug
ZnVuY3Rpb246IEkgdXNlIGVycm9yIHBhdGhzIGFzIHRoZXkgd2VyZSB1c2VkIGJlZm9yZQ0KPj4+
PiBmb3IgdGhlIGV4aXN0aW5nIGNvZGUuIFNvLCBJIHNlZSBubyBjbGVhciByZWFzb24gdG8gc3Ry
ZXNzIHRoYXQgdGhlIGV4aXN0aW5nDQo+Pj4+IGFuZCBuZXcgY29kZSByZWxpZXMgb24gdGhlIHRv
b2xzdGFjaw0KPj4+IFNheWluZyBoYWxmIGEgc2VudGVuY2Ugb24gdGhpcyBpcyBoZWxwaW5nIHJl
dmlldy4NCj4+IE9rDQo+Pj4+PiBXaGF0J3MgaW1wb3J0YW50IGlzIHRoYXQgbm8gY2FsbGVyIHVw
IHRoZSBjYWxsIHRyZWUgbWF5IGJlIGxlZnQgd2l0aA0KPj4+Pj4gdGhlIGltcHJlc3Npb24gdGhh
dCB0aGUgZGV2aWNlIGlzIHN0aWxsIG93bmVkIGJ5IHRoZSBvcmlnaW5hbA0KPj4+Pj4gZG9tYWlu
LiBXaXRoIGhvdyB5b3UgaGF2ZSBpdCwgdGhlIGRldmljZSBpcyBnb2luZyB0byBiZSBvd25lZCBi
eSB0aGUNCj4+Pj4+IG5ldyBkb21haW4sIGJ1dCBub3QgcmVhbGx5IHVzYWJsZS4NCj4+Pj4gVGhp
cyBpcyBub3QgdHJ1ZTogdnBjaV9hc3NpZ25fZGV2aWNlIHdpbGwgY2FsbCB2cGNpX2RlYXNzaWdu
X2RldmljZQ0KPj4+PiBpbnRlcm5hbGx5IGlmIGl0IGZhaWxzLiBTbywgdGhlIGRldmljZSB3b24n
dCBiZSBhc3NpZ25lZCBpbiB0aGlzIGNhc2UNCj4+PiBOby4gVGhlIGRldmljZSBpcyBhc3NpZ25l
ZCB0byB3aGF0ZXZlciBwZGV2LT5kb21haW4gaG9sZHMuIENhbGxpbmcNCj4+PiB2cGNpX2RlYXNz
aWduX2RldmljZSgpIHRoZXJlIG1lcmVseSBtYWtlcyBzdXJlIHRoYXQgdGhlIGRldmljZSB3aWxs
DQo+Pj4gaGF2ZSBfbm9fIHZQQ0kgZGF0YSBhbmQgaG9va3MgaW4gcGxhY2UsIHJhdGhlciB0aGFu
IHNvbWV0aGluZw0KPj4+IHBhcnRpYWwuDQo+PiBTbywgdGhpcyBwYXRjaCBpcyBvbmx5IGRlYWxp
bmcgd2l0aCB2cGNpIGFzc2lnbi9kZS1hc3NpZ24NCj4+IEFuZCBpdCByb2xscyBiYWNrIHdoYXQg
aXQgZGlkIGluIGNhc2Ugb2YgYSBmYWlsdXJlDQo+PiBJdCBhbHNvIHJldHVybnMgcmMgaW4gYXNz
aWduX2RldmljZSB0byBzaWduYWwgaXQgaGFzIGZhaWxlZA0KPj4gV2hhdCBlbHNlIGlzIGV4cGVj
dGVkIGZyb20gdGhpcyBwYXRjaD8/DQo+IFVudGlsIG5vdyBpZiBhc3NpZ25fZGV2aWNlKCkgcmV0
dXJucyBhbiBlcnJvciwgdGhpcyB0ZWxscyB0aGUgY2FsbGVyDQo+IHRoYXQgdGhlIGRldmljZSBk
aWQgbm90IGNoYW5nZSBvd25lcnNoaXA7DQpOb3Qgc3VyZSB0aGlzIGlzIHRoZSBjYXNlOg0KIMKg
wqDCoCBpZiAoIChyYyA9IGlvbW11X2NhbGwoaGQtPnBsYXRmb3JtX29wcywgYXNzaWduX2Rldmlj
ZSwgZCwgZGV2Zm4sDQogwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqAgcGNpX3RvX2RldihwZGV2KSwgZmxhZykpICkNCmlvbW11X2NhbGwgY2FuIGxlYXZl
IHRoZSBuZXcgb3duZXJzaGlwIGV2ZW4gbm93IHdpdGhvdXQNCnZwY2lfYXNzaWduX2RldmljZS4g
TXkgdW5kZXJzdGFuZGluZyBpcyB0aGF0IHRoZSByb2xsLWJhY2sgaXMNCmV4cGVjdGVkIHRvIGJl
IHBlcmZvcm1lZCBieSB0aGUgdG9vbHN0YWNrIGFuZCB2cGNpX2Fzc2lnbl9kZXZpY2UNCmRvZXNu
J3QgcHJldmVudCB0aGF0IGJ5IHJldHVybmluZyByYy4gRXZlbiBtb3JlLCBiZWZvcmUgd2UgZGlz
Y3Vzc2VkDQp0aGF0IGl0IHdvdWxkIGJlIGdvb2QgZm9yIHZwY2lfYXNzaWduX2RldmljZSB0byB0
cnkgcmVjb3ZlcmluZyBmcm9tDQphIHBvc3NpYmxlIGVycm9yIGVhcmx5IHdoaWNoIGlzIGRvbmUg
YnkgY2FsbGluZyB2cGNpX2RlYXNzaWduX2RldmljZQ0KaW50ZXJuYWxseS4NCg0KU28sIGlmIHlv
dSB3YW50IHRoZSB0aGluZ3MgdG8gYmUgY2xlYXJseSBoYW5kbGVkIHdpdGhvdXQgcmVseWluZyBv
biB0aGUNCnRvb2xzdGFjayB0aGVuIGl0IGlzIG5vdCB2cGNpX2Fzc2lnbl9kZXZpY2UgaW50cm9k
dWNlZCBpc3N1ZSwgYnV0IHRoZQ0KZXhpc3Rpbmcgb25lLCB3aGljaCBuZWVkcyAoaWYgdGhlcmUg
aXMgYSBnb29kIHJlYXNvbikgdG8gYmUgZml4ZWQNCnNlcGFyYXRlbHkuDQpJIHRoaW5rIHRoYXQg
bmV3IGNvZGUgZG9lc24ndCBtYWtlIHRoaW5ncyB3b3JzZS4gQXQgbGVhc3QNCg0KPiAgIGluIHRo
ZSB3b3JzdCBjYXNlIGl0IGVpdGhlcg0KPiBvbmx5IG1vdmVkIHRvIHRoZSBxdWFyYW50aW5lIGRv
bWFpbiwgb3IgdGhlIG5ldyBvd25lciBtYXkgaGF2ZSBiZWVuDQo+IGNyYXNoZWQuIEluIG5vIGNh
c2UgaXMgdGhlIGRldmljZSBvd25lZCBieSBhbiBhbGl2ZSBEb21VLiBZb3UncmUNCj4gY2hhbmdp
bmcgdGhpcyBwcm9wZXJ0eSwgYW5kIGhlbmNlIHlvdSBuZWVkIHRvIG1ha2UgY2xlYXIvc3VyZSB0
aGF0DQo+IHRoaXMgaXNuJ3QgY29sbGlkaW5nIHdpdGggYXNzdW1wdGlvbnMgbWFkZSBlbHNld2hl
cmUuDQo+DQo+IEphbg0KPg0KPg0K


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 09:57:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 09:57:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267938.461698 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHNFR-0004vm-UZ; Tue, 08 Feb 2022 09:57:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267938.461698; Tue, 08 Feb 2022 09:57:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHNFR-0004vf-Qr; Tue, 08 Feb 2022 09:57:21 +0000
Received: by outflank-mailman (input) for mailman id 267938;
 Tue, 08 Feb 2022 09:57:20 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1FiY=SX=epam.com=prvs=40383cc40e=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nHNFQ-0004vX-Eh
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 09:57:20 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8010a5ef-88c5-11ec-8f75-fffcc8bd4f1a;
 Tue, 08 Feb 2022 10:57:19 +0100 (CET)
Received: from pps.filterd (m0174676.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 2189rgaQ002968;
 Tue, 8 Feb 2022 09:57:16 GMT
Received: from eur04-db3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2054.outbound.protection.outlook.com [104.47.12.54])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e3p9gr0c6-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Tue, 08 Feb 2022 09:57:16 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by DB6PR03MB2998.eurprd03.prod.outlook.com (2603:10a6:6:34::21) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Tue, 8 Feb
 2022 09:57:12 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77%3]) with mapi id 15.20.4951.019; Tue, 8 Feb 2022
 09:57:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8010a5ef-88c5-11ec-8f75-fffcc8bd4f1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ADO1FSrAKn/1KfO9V5NsjP9zXze32SfzPFdZdjbbb+kkfkLRd6iHiVTQQ2hzfpQMNKlOqCZp/kf53bo3rNjMaeeqgS/KgqM6fBF6cBQmHG9auZT+7d2sz4GK7V6WEi5ohWBjOR7qSYZ6Cb3ZKlGvj3Q+65z8g9kPOoY4Fg4DItWfeAZ6Msm5RRx0HXD6fEY/GlFW2+FWzvjbwQ+79RJeyV3Qr9PlKcEd4ksB5N0R0EbLC6yF+0T0NH26DKehW5XlKleJq1spyit1lm81afGTstFbuE9e7xlE1qRKsNGasZQQpN5jt9a1qb5M5h1KOxDHl64oryXelGYCQyLi6Rgf6g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=/lbE0Vy9LotVTaHSUinpUIrOA45ndVUqXBaJpAX6ik0=;
 b=He/OM70yrJAB5s4CWbwDZOGsROnhHCkc3K5hjLOWfMrVmvDT99ZhBKkFY8j3lWz+GLKc5wMJp+8Vd8yEXjIop0fzuyKbh9yZVZnuRsxByE6wD+Y/AAY7a16AzfrlQm3Jzqe2IcxEvZaYM+RvwqYbSWex8Yt/Bre66OAbLXEEG5OBcS13zCXIqszwda8XCws2NIfNYVfBtW0EhNWn9nBozM1HDHQ1thOTdBnbjgEnFoDGGpmC1+DgWBJOZO9FZs0jjwXTqjZQW42OyYKPPmpr6VXqGM9h2NfOkdwSZCjiCw3q9Ijw5X7no3msjasKTlxwtCun3kRBOIkFPBdVYjzj+g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=/lbE0Vy9LotVTaHSUinpUIrOA45ndVUqXBaJpAX6ik0=;
 b=EBF1bGB9AMne1xdMTWEor7hcAkDR8YbjHy6PkYvvWeRR2qvPU3eWzH832YGMglIURA7T8ZdctPmpktyzk33cM1ypfkL3nLHz1lwihNiZ70yndkvSiPVZZ/YIR4X4h1Ifw4BdGtWU2gpx5U7uhD8ME8bZQrDHMCbKWLO1bD320DLlnL0JLtkMCpqjmqAeQneRC0vAAFe+pMdO4A4X1qMrLFA65c7alb9LGvaweNII4xLKiq0tpcKnIbrxLySkYaT9oIoEvlniYsttuJTnI2W47zGupqoFbJIQeKxHPBF+4xWKeX1zel/YpOhXBKY1aRYIBp6B/w2F9zMdLzXpqZtTlQ==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?=
	<roger.pau@citrix.com>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v6 06/13] vpci/header: implement guest BAR register
 handlers
Thread-Topic: [PATCH v6 06/13] vpci/header: implement guest BAR register
 handlers
Thread-Index: AQHYGZFd6D+qnME8W0+wTH+v8YZ8DayJaJYAgAABnACAAASVAIAAApGA
Date: Tue, 8 Feb 2022 09:57:12 +0000
Message-ID: <6ac5d7ce-96dd-66e1-c8d1-eff7b0a1349e@epam.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-7-andr2000@gmail.com> <YgI3HpFffudiEmNN@Air-de-Roger>
 <498ca523-2642-e35f-b316-0a089f98ca91@epam.com>
 <5bc96dba-e9b8-de2e-f6aa-ae6c604897e8@suse.com>
In-Reply-To: <5bc96dba-e9b8-de2e-f6aa-ae6c604897e8@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 5443a978-31df-46ae-6447-08d9eae960d7
x-ms-traffictypediagnostic: DB6PR03MB2998:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <DB6PR03MB2998B9D7CA57F5280A6C375AE72D9@DB6PR03MB2998.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8273;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 YuxF1orCu6iUUFPnmMqpX0MVV7wxRIsw/Q6H5RYkJ8RIfEJVeHt6YOMTZM7A0Km4+HF6HX88a4vnGN7E5cmUyKzGDQWDWLzjkIteWEUq0J/bgsZWsUQA7Fir229kKwGS+r3N+za8iCQj3nnSB+FbNPFtMqnSY+X2+hJnQ9I8u+XMe6LvGi76jnW3zkWRbJngKZCAwOBgzi4TH30nMdgpNdhSfrAgt2IaL1WaoN28vjPbyglOIQNi4qR90byLlqBqj/wn8Qah2nsk6eLOFvb+DZbdBrdWaPXkqBedFF50oDVmoKQjfg82dCB1FMu5SKFiA7jnet4VAqjb4kN9RX8r669qUL8HEOAX9JgBRLpTKJbLQXKt9+sraJisoALYJjMtEEeeM5zL2NOo5MlMTOu5Jko4rLZOw+7P7iv8epRVYrwL0PlobJ9JeiZaTqXaMPaUdspw1aA7DHCIkZF2MSr7KAXh6MnlOTlfxXSJYrlbJVkUftFl2JJvFJ7gjbMUVZqeCpjtG+qW3H7/VMe6t2XsbIr7dWgLJj7sT6GYMoZ/1UqB9KNyDl3H+0V/d3E359q8gyhbbWZIJBUrcq9sMs2AZLrUE03OcgmmPGfc4Y6l3mbgM/w2+RC8CGDunPIcSd5Sa8VCB53cQ4r/kPG6I8/0sRCY1bFnGA4XJNPpSDkFuhrCWRma9+vODsbwzJbH9YiAK50M6j7hhpsCujtFQ0BHf0yCclzmN9IFBS+DF9q+2qacVzkOZZqGFNSFjB3tBlxs
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(86362001)(31696002)(54906003)(38100700002)(36756003)(76116006)(91956017)(38070700005)(8936002)(8676002)(122000001)(66476007)(66556008)(66946007)(6916009)(4326008)(64756008)(316002)(66446008)(2906002)(83380400001)(5660300002)(6486002)(7416002)(6512007)(508600001)(55236004)(107886003)(6506007)(71200400001)(2616005)(186003)(26005)(31686004)(53546011)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?N1YybFBldE1IUXlUTjYyeVpTeFl2N1gvUllCNTlXc1B0czFkZlQrQ09VUnI3?=
 =?utf-8?B?VHhSVzg2QzJiejFhSU5SQ0hPRlZ4Nmo3QTlSRGl2MWRmRjVCVWZBN3ZwVUVt?=
 =?utf-8?B?VmJTZE00bi9IUGpqVzNmcml4bUFmMTQrMGJ0dkI2SXVzZ2dIZTJLL1BzUGxD?=
 =?utf-8?B?NGcrZHhBQ082MW4xQ0QwMTg3RDhnQXBTb1FWRitNbXFpWkV0Q0lvTVBMbGk1?=
 =?utf-8?B?SmtjamxTdnJhQWtmOGNhdklIeTdlbUhmZFhUTEtxZU9hOEpmUTVSTEFCdEdY?=
 =?utf-8?B?SmlTUHNkd0svTDhnTDQ1bVJhVWN4NmpsdmlvaERVbmpTODF0MnplWmVxZG4y?=
 =?utf-8?B?U0tFU3diOFh5VjVqeUgrbXo2Tm5GWjAyMHk3anN5SXl2ODIrZCt2TTBoakpt?=
 =?utf-8?B?UGZWU1lqejRPUHgraVB4U3dyVjhWV2ZOMG9WUWtYZ05rb1ZHUU1NUER0Zy9R?=
 =?utf-8?B?alg0cWlrVVNHQjk0b2pSRkowY0RNZkNjUG44RENjQTVRR2lRVTJ2S2wwRk9O?=
 =?utf-8?B?RjhraUI3ME5yanRONVFLMDYxYlJXTEQ1L0p4TWNzcmNFWUQ4ZU96MHBvTTZN?=
 =?utf-8?B?ZmtGUHdCMlZ2UzV1MmROK011aUN6TjVveTlqcEtHUDZnUzdOSWNQV2hSMXg1?=
 =?utf-8?B?WUZKYmY5OUE3R3k4T1dwb2hoYVJUTm1jMGxBVks1QldKRHJLS1FIY0x1clRO?=
 =?utf-8?B?bVNmb0hSZjQ3OFdzVTlma21nbG5hY2NTMWl2SkJYdDgrdXl1TnlUUnZTT0I5?=
 =?utf-8?B?UWhKZGRjWXJudWhJSUJvam81TmNLNmtJQmVCK2I3YlVxVmtZajRMZkZxdm12?=
 =?utf-8?B?SCsveUd3Y2xabnl1a0hwZzVZOUxHQlQ3NDJsZzBiMU1wUnpGc1JpN2RFc29J?=
 =?utf-8?B?MmlYUDBnUVBnL2dVQkV2RDlLcDZ0M20vYW1tdUF3cUo4eHhndElwbjc3bkZI?=
 =?utf-8?B?eDd6WTRRWUtmaGIySlRFR0xXQndpNGZBS1FMcHc3alRyS3dqUUlZOFdnaVVq?=
 =?utf-8?B?enU5SGl1M3BHYU5kVVdxNjFseTlNcUMrdGpCdmVXT2N6N2h4VUhYWW9IYUIr?=
 =?utf-8?B?eGoyNzFidk9RaFFkZ0FId2Fvb1lyakdZWlAxeklkTXNvQWhwZFpUVENMc3By?=
 =?utf-8?B?WEs0SElqMGg4Mk9xRDZNdWk3bEZvNnpxVlQxOUF4Q3lVcUE0U1l4QTVPV2R2?=
 =?utf-8?B?M1F1K3NZSmFNOExVcXlNelkrMlR2VlU3d0hybUlReWMxOFA2UDB0YTJLQktu?=
 =?utf-8?B?c2FKRUpNZ3lVM1FwaG5KWjdMUjgyVTBHV1hHcmRJZVNQTzc2QWZ3V1daYXdV?=
 =?utf-8?B?OTRSZW92NDdyVHY3VjUwS1ZSNVhwKzUxcFhVTVpFTE1ZcVlmNHNqRTFONnU2?=
 =?utf-8?B?VGJKU2dVREZic0ErZEoxRFJZMGcxZFNPcVdIcGxyRG1naTAxdjlCMkZDcmJS?=
 =?utf-8?B?ak5LUEIxVWJ6ODZWbzNkSFZzMEtBTVJ1azBUcGpDd2d0a0o2eGFHRkovVUZS?=
 =?utf-8?B?WkRnVkV0UUVZOFd5ZnJ3R3ljUnQvUStKQ2VsT25qMjdrd1BYWG1sSExNek0w?=
 =?utf-8?B?SXk5NXkvWmNtckIxKy9nbEhHdjVtWWZ0WTdTR3NVK2FoU2NTQVRDQzF2UVhv?=
 =?utf-8?B?eVZIUmFnTzhveGlCYkovcXF3WlpnZE1WSS8wSzQ2NXJRa1RZT3dyMTdpSFZS?=
 =?utf-8?B?bEtzeUtYV08zUkxwMENXOVNpRExCdldjMGdJNWFyUVhrU0xlOE1mZmVJNzRj?=
 =?utf-8?B?Tms2dFVndHlPZ1MrME8yaFFCM0lFQ2pMUVF4OENaMWROb0JRN24yem9mbVNB?=
 =?utf-8?B?UXVQVXZ5YU83VGlxejhUY2dHdEk3ck9iZVFmdEM5eTFaNGQ4L0t3cStka2Jo?=
 =?utf-8?B?U2MxZCs1K3RpaGo1MzBiRjdhaEJ3Sm9wLzQwZ28zc3FJbnBwOEVaS0xpRk51?=
 =?utf-8?B?V3hSN2ZxYkIxY0dBVEFjNXQxTkVtUFBXMitEK2hLL3ZmUFBJOGU1QUJ0MDJ0?=
 =?utf-8?B?bzlYaWgzT3hPV29rTStsTVp1WEdVUTNlWVlEdzhEcDJGc2dQTWorelhpdXBR?=
 =?utf-8?B?WjhjUGN0MjJhMEYzODNiYWhQdWFoRDdOUUM4eFdiejZGRnZ0QnNkb2U0dERJ?=
 =?utf-8?B?K01nWXNvWnlMY29wV0RRSXlIODBkc1hRRHNyZ2FGcWZweThITmdTcFV0M1lj?=
 =?utf-8?B?c0NqTUZJdXFpZ1pjSjBLc0NLR2ZkaktYSTZBUVpLdmFzNHVncTJGZmlOMDUw?=
 =?utf-8?B?bzVTUHJ5QWNJSGFaOEZYR1M0cERkVS9WVUoxdVhWVnp4c2ozb09NODFsd0Ew?=
 =?utf-8?B?bFZRZGNNSnpSM3NPd0hUbVM4UTJyRTVFYWtWLzB0RXVrM3RweDNWUHh4N2hN?=
 =?utf-8?Q?I+LqH4HdjD+H/Ias=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <F3A827095CF4664CB15C0FEEEDC598DC@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5443a978-31df-46ae-6447-08d9eae960d7
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2022 09:57:12.1394
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: uzgysX5w7LIskfB/INBQVPKouasK/gtI0oYOvMdefH6FhQuARiiWcQ7Nt4HoVd+ywbnPVb/2NHm16OiSLETp+WzKzo6fLPD/h0xGzu2R/22mmUJVNehnkzxz5qS+3haC
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR03MB2998
X-Proofpoint-ORIG-GUID: bqbqXxWb9YXNmV3W1gjbU2LR82LlMKPy
X-Proofpoint-GUID: bqbqXxWb9YXNmV3W1gjbU2LR82LlMKPy
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-08_02,2022-02-07_02,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0
 lowpriorityscore=0 phishscore=0 adultscore=0 priorityscore=1501
 suspectscore=0 malwarescore=0 mlxlogscore=999 spamscore=0 clxscore=1015
 impostorscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202080056

DQoNCk9uIDA4LjAyLjIyIDExOjQ4LCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMDguMDIuMjAy
MiAxMDozMSwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+PiBPbiAwOC4wMi4yMiAx
MToyNSwgUm9nZXIgUGF1IE1vbm7DqSB3cm90ZToNCj4+PiBPbiBGcmksIEZlYiAwNCwgMjAyMiBh
dCAwODozNDo1MkFNICswMjAwLCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyB3cm90ZToNCj4+Pj4g
QEAgLTUxNiw2ICs1OTQsMTEgQEAgc3RhdGljIGludCBpbml0X2JhcnMoc3RydWN0IHBjaV9kZXYg
KnBkZXYpDQo+Pj4+ICAgICAgICAgICAgaWYgKCAodmFsICYgUENJX0JBU0VfQUREUkVTU19TUEFD
RSkgPT0gUENJX0JBU0VfQUREUkVTU19TUEFDRV9JTyApDQo+Pj4+ICAgICAgICAgICAgew0KPj4+
PiAgICAgICAgICAgICAgICBiYXJzW2ldLnR5cGUgPSBWUENJX0JBUl9JTzsNCj4+Pj4gKw0KPj4+
PiArICAgICAgICAgICAgcmMgPSBiYXJfaWdub3JlX2FjY2VzcyhwZGV2LCByZWcsICZiYXJzW2ld
KTsNCj4+PiBUaGlzIGlzIHdyb25nOiB5b3Ugb25seSB3YW50IHRvIGlnbm9yZSBhY2Nlc3MgdG8g
SU8gQkFScyBmb3IgQXJtLCBmb3INCj4+PiB4ODYgd2Ugc2hvdWxkIGtlZXAgdGhlIHByZXZpb3Vz
IGJlaGF2aW9yLiBFdmVuIG1vcmUgaWYgeW91IGdvIHdpdGgNCj4+PiBKYW4ncyBzdWdnZXN0aW9u
cyB0byBtYWtlIGJhcl9pZ25vcmVfYWNjZXNzIGFsc28gYXBwbGljYWJsZSB0byBkb20wLg0KPj4g
SG93IGRvIHdlIHdhbnQgdGhpcz8NCj4+ICNpZmRlZiBDT05GSUdfQVJNPw0KPiBBZmFpYyBiZXR0
ZXIgdmlhIGEgbmV3LCBkZWRpY2F0ZWQgQ09ORklHX0hBVkVfKiBzZXR0aW5nLCB3aGljaCB4ODYg
c2VsZWN0cw0KPiBidXQgQXJtIGRvZXNuJ3QuIFVubGVzcyB3ZSBoYXZlIG9uZSBhbHJlYWR5LCBv
ZiBjb3Vyc2UgLi4uDQpDb3VsZCB5b3UgcGxlYXNlIGJlIG1vcmUgc3BlY2lmaWMgb24gdGhlIG5h
bWUgeW91IHNlZSBhcHByb3ByaWF0ZT8NCkFuZCBkbyB5b3UgcmVhbGl6ZSB0aGF0IHRoaXMgaXMg
Z29pbmcgdG8gYmUgYSBzaW5nbGUgdXNlciBvZiBzdWNoIGENCnNldHRpbmc/DQo+IEphbg0KPg0K
VGhhbmsgeW91LA0KT2xla3NhbmRy


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 09:58:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 09:58:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267946.461709 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHNGu-0005XY-8j; Tue, 08 Feb 2022 09:58:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267946.461709; Tue, 08 Feb 2022 09:58:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHNGu-0005XR-5N; Tue, 08 Feb 2022 09:58:52 +0000
Received: by outflank-mailman (input) for mailman id 267946;
 Tue, 08 Feb 2022 09:58:50 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1FiY=SX=epam.com=prvs=40383cc40e=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nHNGs-0005Wt-DF
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 09:58:50 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b5b63244-88c5-11ec-8eb8-a37418f5ba1a;
 Tue, 08 Feb 2022 10:58:49 +0100 (CET)
Received: from pps.filterd (m0174678.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 2189Sh0F000682;
 Tue, 8 Feb 2022 09:58:46 GMT
Received: from eur02-am5-obe.outbound.protection.outlook.com
 (mail-am5eur02lp2057.outbound.protection.outlook.com [104.47.4.57])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e3nx0r3ra-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Tue, 08 Feb 2022 09:58:46 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by DB7PR03MB4617.eurprd03.prod.outlook.com (2603:10a6:10:1b::17) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Tue, 8 Feb
 2022 09:58:40 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77%3]) with mapi id 15.20.4951.019; Tue, 8 Feb 2022
 09:58:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b5b63244-88c5-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=TkrLBcRq71zKSy04XlixwH2xi8hqLIa7bhTwMnG2LVtUGYTdI0AH2vAX/sGtdeX2b4MbGGhDgsBXDURxMkTgSaYYIQgHrJQ4hDa4D3T3zljbi+qRbFx8ju4guc0cQQ4Git8rahNLWGhfkFIIylQfL6YAQJWDMO54u3QblBr7CIVygSDPOXR4CHHkzyB15y0s6YxDPoMO/dpnT28chj0KkkEHeTcu2aWFDzGsy1pf02IL/VmEF1kftN6uOsOD2dNcewqAQBtqQ6NZMlNkZkR3QrBFWlTBmLK5Eep5lNj91T1WWNdJvb70ovndPwBVXxfBysPnhfk/EOnV3BzbZxFRFg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=NybVCRtw95Bx0SzjBpBfR+8lQpTE3AWLwiuDbQxy2kI=;
 b=b28021RMQEAC/xwHpL0DpcXQsDRfh6uvpBaNyvVOaFYTPJEx3soa/7jdKQ4h7wnvbvGNbFN4xSZcaPD2xE7hSbixOVMLc9GDp2a1HG/lrslC3v8xHHPtTuHC6GVb+7fCpBvoa/og2JTeA9u3N/aI1ezWJxW1pOJ/YAxW3cPRc4yEv9Sq6T3TBcVFWwWFF16WoY9v61bPGOgAvKgKDN2nGbQhBS8sR/JC9AwVaapF95fc7qPC6nOw1pBEQ06td61flOFPtdNVmKiL5xKbDftNZhhImRmaoMNmNMfsIWN6qfCy92y9vmhahQx0whC0IXkv1CaIt9l3is+0OQ7uptjyjA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=NybVCRtw95Bx0SzjBpBfR+8lQpTE3AWLwiuDbQxy2kI=;
 b=WZ7eT8FKM4UFgmMrvfiAsOnP9ttFA9fZhlWo8hMoPKKOseS/Xh7MtVf1NavfkOmbT2LEIhehKhUhl+5L86QvJs/K5CIAYAuKwlGdmvZvQuKHDO/wzBNtyJzzrTcGTYyZ1IitGjLs3rs7lrCzrpAtcAI6feDStEwKpOlW5aHjJ95ULOUGywbxyrkT+VjptFE2oV+cdyg6PU3UsvU5/Js84+8UkMZeJ8QISFDGwKhjwB+lp/9HdpotsXBmvBkh0COXNhXV6jrT4XZ8KSaQIuWw/wdAWwBfnT5Ce6gJqHHfoYI18UEJVttyvhJpM+WoDET1SYGSyCOUaPI/r5UQRf1q5Q==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>,
        "roger.pau@citrix.com"
	<roger.pau@citrix.com>
CC: "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v6 09/13] vpci/header: emulate PCI_COMMAND register for
 guests
Thread-Topic: [PATCH v6 09/13] vpci/header: emulate PCI_COMMAND register for
 guests
Thread-Index: 
 AQHYGZFfEau2yoVfs02TXHZP7JM5E6yDcw0AgAXhW4CAABY4AIAAAW6AgAAD24CAAAHYgA==
Date: Tue, 8 Feb 2022 09:58:40 +0000
Message-ID: <ccaaa9b8-8ed9-054e-b724-70ca07401be9@epam.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-10-andr2000@gmail.com>
 <7df2379e-1c30-c362-3106-c7ef23af5c73@suse.com>
 <0ff2a524-9a65-861a-df87-cf3f682862d7@epam.com>
 <140e163c-87d0-2ae8-d57b-7ebc6757de9e@suse.com>
 <08d02313-349d-9ad4-926d-0d1419866363@epam.com>
 <186b7264-1190-3df2-415d-f1ec73a7c03f@suse.com>
In-Reply-To: <186b7264-1190-3df2-415d-f1ec73a7c03f@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: ef879a4d-f4b8-4f56-e3ea-08d9eae99572
x-ms-traffictypediagnostic: DB7PR03MB4617:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <DB7PR03MB461786A2544CE99829C4FDE8E72D9@DB7PR03MB4617.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 uGApG4Ixtr74HLaj12u7XQTBvIuJA++eAVEdF1h/KDCfi6egvKInMd3w6TRDy+0VVh+skfWfsKhlDVv9ASHmff9kso2T6mljZqbNU0rkkvF8lq/CoCS6peiYdrE6RLQ8fDJo+4NtlreoqWEE9nH5u1DVMOCEEEc5D52IAU2J8olvQjNBeu+KUpDvNRYGE4EOXeiKqWm+z0hbwKCWfI/xxER5qmajm+fpbdePFmOxeilZuFgJ3YKbQXBRv6DF3YTtUZBn65bYvYzwsBnzteYMOm9p7trcugZ3gKxqRrJPQgJ3M/AyBa3RbymDBRXxeaKaGBZG9JUDRp3jarqXa3E0w0Lc50qPXMJWE/2ktV/QLC2KyOSBpSmpBfACDe2AYDhdSc9pOVuY0kJH+5LfLqGAxq/LbWTE5lmt6PsDGubdAFYGV66PARhAXEm7DKqRi2Nvzpzl09kXLwIOgQNyiO+1RaAuihz12sY5Lsqs6HemYRQAY3iR1KcT8xkm0PawPauoOt+tnVYBd7z4T5Mz2g/rkB8xY+wv3/EosB2Q1dHyLxLvbBla+YkMrL5QUdTuwdnUMG3FXWX71KU4Lr7tdDI/EkjqHIxguFlgIn/NBTogCpD7LnMdjnSsR8V9Rw1LVuS6GHsEjbtSmQK6JyuK5gwJ0SHrP3KvJQUT516rePsFLTuDkTlryCLizuNDgoZ+qjd4BZYJbbx+s3Gr1CLY35s501/5C00Kg+DzAkyK+UXfRzp/gMfxt6fQsQN7fTNRjtJw
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38070700005)(64756008)(66476007)(66446008)(86362001)(55236004)(53546011)(31696002)(2616005)(66946007)(6512007)(7416002)(6506007)(508600001)(122000001)(6486002)(54906003)(110136005)(8676002)(91956017)(316002)(71200400001)(8936002)(4326008)(38100700002)(107886003)(26005)(36756003)(31686004)(5660300002)(2906002)(186003)(76116006)(83380400001)(66556008)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?bTFYQmZGc25CQ2NXaldscUt5SDlsWHIxRnNHK0VldCtVUmRYRmhPR0FjRHB5?=
 =?utf-8?B?T1RlN2JkeHlMZjUvL1dycDBsd2xtZ0FDK0lhWGZaME4zeWlWcDBONVdGZDhz?=
 =?utf-8?B?T1VkVmUwcjlqN0VsQlNIZTZJVUZaN3E1ajFuSS80YlBGOGxSNW8wdldCR0RI?=
 =?utf-8?B?VTNaYlNYTWR0bmhkQ3JkK25BRUdBTEdjTEk4TjJBUEJTaGQ0Wjc5VEh3N2ZO?=
 =?utf-8?B?dHFiRklCQjNUelY3Z0FCSStHNFBadVhEbEd5QXhHYkU5ZUN3YS8xOURraTlr?=
 =?utf-8?B?V0JPa2hnREpGcnhZTE9LeWt3eCsyVms0d3V6dVJIQjV3TnhZSWZNVnNHT0Jv?=
 =?utf-8?B?bDJ5dm9ma0ZRQkNvT2U2OUUxV2g3bWZkbmJKWFlVczJVanl1YTRMY1dMY1VI?=
 =?utf-8?B?eGlzS2xRNmhkQ0RHL3BLU1VCQmZ4emdzUitCVG5zV3N6M2p0ZVJVTURhR09N?=
 =?utf-8?B?RWZmZnNCc1RsTDB4bnM5eUVHWEIwT0E4MC9IZTIxa2pCUDJXSmhUQUxXYnRO?=
 =?utf-8?B?dTVIenVRK0JHTmhScDdsemVBS3ZGMG0zOE96UVl5a09zUlE5dE5mMmRvWW04?=
 =?utf-8?B?ZENudlI2Rng3N3gwcG50emFxRUpJOUhyRXZ0ZzhOMFBGeldDeDNBejJXeEFL?=
 =?utf-8?B?Rm4zREVkK3lmaEdnRFlqRlMvZTc3QmdUV1NYZmo4TlFjZUlnR3lIWFB6VWJX?=
 =?utf-8?B?a0diaHhTTzhkMmtMbXV2RDhqdkRZMjQvQy82NjFSWTRLeFkzRVZWbUpuWHBo?=
 =?utf-8?B?bXZIdWxBbFNjMTYwVFZuKzZlZkFuUFdkd3VZbWJxZDJmakVjVmZ1VElrUWNj?=
 =?utf-8?B?Qmc0cWh4T1NvbnVDOXdhdkZ3S3pVdXBiUUoyL2NLVzhOZStya1pFc3VZMExD?=
 =?utf-8?B?T3RWeDdxWURtdzc2ZHBES0tidDRSaWprMUdTTW45Mm56NGJnOGw0NFI4M3VI?=
 =?utf-8?B?TUFybktoRElsTjcrdGQ2eE1YVEk5Y05oWnZKN1MwamMrVysySUxhN01xNGpr?=
 =?utf-8?B?c2R1TDhNTXd2UzBlYXFWamJta1NVU3pad29ZTTVhTG1rUFFid0lvbnd5ZUtX?=
 =?utf-8?B?L2VzTWZiRmoydGVjT1VWeVNjWWdXRjdpSW5VTVJtQ0NWOWxFbmQrUUsySnNF?=
 =?utf-8?B?SW1LSktua2JNYStkTTZhQ01HNUJiRWdGbnVzTzhsd0o5S1NoSHRXUHVaaGFU?=
 =?utf-8?B?aHZSZi9ZMDd0eVNoTXN0TTYvQUk3R0kwd1V1T0hIMTlCNTdEUGdDcWNrSldz?=
 =?utf-8?B?cGZjTFFDQ1V0OFpPR0I3SjB3emw2Wm1mR1R0QlVSVnZIaEQ0cFBjZUdYaHlL?=
 =?utf-8?B?eUJ5a05ldFhwNW1zaWJmUHhDbU9NS3llSUtPR1NNNzdKcGRndU13TGk1U1dP?=
 =?utf-8?B?MXM1WVpwQ3FQWTFGeGJlbkdKTHBZVmM0eGlLOEVLVVJ5eE16dWxZcVR1MDlT?=
 =?utf-8?B?ZnVMUUR5aVdrZStySGdvTGhsYTZRbkxvMzg3QkpTTXQrQnVCUFNmdXJqRWpW?=
 =?utf-8?B?YlFkUGtPVHZWUmFTTGdCaHhqbHNpYm5STXdBVlRuQXZKZXl6NmJOWnM1VVg3?=
 =?utf-8?B?TFduaXhDOHhUbkpCVllGMUVrVHZxa0UrdExQTDg2MnlscDRXeVNKZ3k2Rmkw?=
 =?utf-8?B?WlNsYWo3SWdhQ2p5UzFEczBuMkcvOTBURjZ4ZlFGMFViUDNrTGJLWnl5M3lS?=
 =?utf-8?B?K3ZjV24vb0RNTUZoYlV3SFFiNkhBc2IrWVdvUlRVTzdHYjl1QitQcEFGb203?=
 =?utf-8?B?Y0dNaS8vOVJCQXhDamxYV2lZWFBTOWtuSzRvK1RiOUdGN0ZWSWgzcHAwMnFK?=
 =?utf-8?B?REdDRktVQlp0b0Q3TjJxcTQxaGZoVzZlU0FzMjlURXU2WmFmbi9zUWF0bkZt?=
 =?utf-8?B?ZElOS01xRnZkRU1hQ1VsSWpBZGd6bFB2Ym1NZmMzcWpva01wVWtLKzUrYzlW?=
 =?utf-8?B?M3NiUnFqQ3BsTWJ6TlJ1SnlRMWk0b3VrZ0NmTjNxTUJSNkg4bjhFVG9EVkZo?=
 =?utf-8?B?aU9RWmVhYkVLNXlrY1R4bzYvb3RuNVVvckZMakRJVWFFdDZZaDdZdVlPUmVR?=
 =?utf-8?B?SyswcmFIdUZ5YngwQmkrc2ErM0NWUG4zVFFWL2Y2ZHhIMTlVTTR2c1dWL0JG?=
 =?utf-8?B?dHUrU2x2TXl1TW5RcHY4enlnK05YNWhheFUwQWpLZm55WkxOVHFtaTl0Y1F4?=
 =?utf-8?B?U05mYk5nUndhbENYZXQvVHZWS1ppZEV4czExbjJHVnF2NkE4QU1PTE1nVEFr?=
 =?utf-8?B?bTRtVnNuNmlOYmxQaU5xSXIxMHRzTGhkdjFEdlNPUWtNdzR1azl4RFNjRnNr?=
 =?utf-8?B?S29HZ29NcTIyQ0lkd2N4a3p4K01yU0c3NmhVbmJZOG5wb1I5QURacTN4eThk?=
 =?utf-8?Q?S9vgVJ8I6HvoI8oc=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <14196F69D1041944BD6EAB7FF4D73581@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ef879a4d-f4b8-4f56-e3ea-08d9eae99572
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2022 09:58:40.4312
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: SvGZZxmZmwBUWW6RWTho34hChLRsEPQcZGuPhqG8bV065CgC32WD9RkmzX8JOq50rFqfcfnusZcj8IiOxUj2NnbTF6NYkOumh27IrsYf85M3O7qqWXNp1IGkO6vWpUsR
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR03MB4617
X-Proofpoint-GUID: qeIm8qCvB4QmH8YcVuCSvSZ59hMadLqY
X-Proofpoint-ORIG-GUID: qeIm8qCvB4QmH8YcVuCSvSZ59hMadLqY
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-08_02,2022-02-07_02,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 malwarescore=0
 bulkscore=0 priorityscore=1501 impostorscore=0 spamscore=0 mlxlogscore=839
 mlxscore=0 adultscore=0 clxscore=1015 suspectscore=0 lowpriorityscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2202080057

DQoNCk9uIDA4LjAyLjIyIDExOjUyLCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMDguMDIuMjAy
MiAxMDozOCwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+Pg0KPj4gT24gMDguMDIu
MjIgMTE6MzMsIEphbiBCZXVsaWNoIHdyb3RlOg0KPj4+IE9uIDA4LjAyLjIwMjIgMDk6MTMsIE9s
ZWtzYW5kciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4+PiBPbiAwNC4wMi4yMiAxNjoyNSwgSmFu
IEJldWxpY2ggd3JvdGU6DQo+Pj4+PiBPbiAwNC4wMi4yMDIyIDA3OjM0LCBPbGVrc2FuZHIgQW5k
cnVzaGNoZW5rbyB3cm90ZToNCj4+Pj4+PiAtLS0gYS94ZW4vZHJpdmVycy92cGNpL2hlYWRlci5j
DQo+Pj4+Pj4gKysrIGIveGVuL2RyaXZlcnMvdnBjaS9oZWFkZXIuYw0KPj4+Pj4+IEBAIC00NTQs
NiArNDU0LDIyIEBAIHN0YXRpYyB2b2lkIGNtZF93cml0ZShjb25zdCBzdHJ1Y3QgcGNpX2RldiAq
cGRldiwgdW5zaWduZWQgaW50IHJlZywNCj4+Pj4+PiAgICAgICAgICAgICBwY2lfY29uZl93cml0
ZTE2KHBkZXYtPnNiZGYsIHJlZywgY21kKTsNCj4+Pj4+PiAgICAgfQ0KPj4+Pj4+ICAgICANCj4+
Pj4+PiArc3RhdGljIHZvaWQgZ3Vlc3RfY21kX3dyaXRlKGNvbnN0IHN0cnVjdCBwY2lfZGV2ICpw
ZGV2LCB1bnNpZ25lZCBpbnQgcmVnLA0KPj4+Pj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgdWludDMyX3QgY21kLCB2b2lkICpkYXRhKQ0KPj4+Pj4+ICt7DQo+Pj4+Pj4gKyAgICAvKiBU
T0RPOiBBZGQgcHJvcGVyIGVtdWxhdGlvbiBmb3IgYWxsIGJpdHMgb2YgdGhlIGNvbW1hbmQgcmVn
aXN0ZXIuICovDQo+Pj4+Pj4gKw0KPj4+Pj4+ICsjaWZkZWYgQ09ORklHX0hBU19QQ0lfTVNJDQo+
Pj4+Pj4gKyAgICBpZiAoIHBkZXYtPnZwY2ktPm1zaS0+ZW5hYmxlZCB8fCBwZGV2LT52cGNpLT5t
c2l4LT5lbmFibGVkICkNCj4+Pj4+PiArICAgIHsNCj4+Pj4+PiArICAgICAgICAvKiBHdWVzdCB3
YW50cyB0byBlbmFibGUgSU5UeC4gSXQgY2FuJ3QgYmUgZW5hYmxlZCBpZiBNU0kvTVNJLVggZW5h
YmxlZC4gKi8NCj4+Pj4+PiArICAgICAgICBjbWQgfD0gUENJX0NPTU1BTkRfSU5UWF9ESVNBQkxF
Ow0KPj4+Pj4+ICsgICAgfQ0KPj4+Pj4+ICsjZW5kaWYNCj4+Pj4+PiArDQo+Pj4+Pj4gKyAgICBj
bWRfd3JpdGUocGRldiwgcmVnLCBjbWQsIGRhdGEpOw0KPj4+Pj4+ICt9DQo+Pj4+PiBJdCdzIG5v
dCByZWFsbHkgY2xlYXIgdG8gbWUgd2hldGhlciB0aGUgVE9ETyB3YXJyYW50cyB0aGlzIGJlaW5n
IGENCj4+Pj4+IHNlcGFyYXRlIGZ1bmN0aW9uLiBQZXJzb25hbGx5IEknZCBmaW5kIGl0IHByZWZl
cmFibGUgaWYgdGhlIGxvZ2ljDQo+Pj4+PiB3YXMgZm9sZGVkIGludG8gY21kX3dyaXRlKCkuDQo+
Pj4+IE5vdCBzdXJlIGNtZF93cml0ZSBuZWVkcyB0byBoYXZlIGd1ZXN0J3MgbG9naWMuIEFuZCB3
aGF0J3MgdGhlDQo+Pj4+IHByb2ZpdD8gTGF0ZXIgb24sIHdoZW4gd2UgZGVjaWRlIGhvdyBQQ0lf
Q09NTUFORCBjYW4gYmUgZW11bGF0ZWQNCj4+Pj4gdGhpcyBjb2RlIHdpbGwgbGl2ZSBpbiBndWVz
dF9jbWRfd3JpdGUgYW55d2F5cw0KPj4+IFdoeSAid2lsbCI/IFRoZXJlJ3Mgbm90aGluZyBjb25j
ZXB0dWFsbHkgd3Jvbmcgd2l0aCBwdXR0aW5nIGFsbCB0aGUNCj4+PiBlbXVsYXRpb24gbG9naWMg
aW50byBjbWRfd3JpdGUoKSwgaW5zaWRlIGFuIGlmKCFod2RvbSkgY29uZGl0aW9uYWwuDQo+Pj4g
SWYgYW5kIHdoZW4gd2UgZ2FpbiBDRVQtSUJUIHN1cHBvcnQgb24gdGhlIHg4NiBzaWRlIChhbmQg
SSdtIHRvbGQNCj4+PiB0aGVyZSdzIGFuIEFybSBlcXVpdmFsZW50IG9mIHRoaXMpLCB0aGVuIHRv
IG1ha2UgdGhpcyBhcyB1c2VmdWwgYXMNCj4+PiBwb3NzaWJsZSBpdCBpcyBnb2luZyB0byBiZSBk
ZXNpcmFibGUgdG8gbGltaXQgdGhlIG51bWJlciBvZiBmdW5jdGlvbnMNCj4+PiBjYWxsZWQgdGhy
b3VnaCBmdW5jdGlvbiBwb2ludGVycy4gWW91IG1heSBoYXZlIHNlZW4gQW5kcmV3J3MgaHVnZQ0K
Pj4+ICJ4ODY6IFN1cHBvcnQgZm9yIENFVCBJbmRpcmVjdCBCcmFuY2ggVHJhY2tpbmciIHNlcmll
cy4gV2Ugd2FudCB0bw0KPj4+IGtlZXAgZG93biB0aGUgbnVtYmVyIG9mIHN1Y2ggYW5ub3RhdGlv
bnM7IHRoZSB2YXN0IHBhcnQgb2YgdGhlIHNlcmllcw0KPj4+IGlzIGFib3V0IGFkZGluZyBvZiBz
dWNoLg0KPj4gV2VsbCwgd2hpbGUgSSBzZWUgbm90aGluZyBiYWQgd2l0aCB0aGF0LCBmcm9tIHRo
ZSBjb2RlIG9yZ2FuaXphdGlvbg0KPj4gaXQgd291bGQgbG9vayBhIGJpdCBzdHJhbmdlOiB3ZSBk
b24ndCBkaWZmZXJlbnRpYXRlIGh3ZG9tIGluIHZwY2kNCj4+IGhhbmRsZXJzLCBidXQgaW5zdGVh
ZCBwcm92aWRlIG9uZSBmb3IgaHdkb20gYW5kIG9uZSBmb3IgZ3Vlc3RzLg0KPj4gV2hpbGUgSSB1
bmRlcnN0YW5kIHlvdXIgY29uY2VybiBJIHN0aWxsIHRoaW5rIHRoYXQgYXQgdGhlIG1vbWVudA0K
Pj4gaXQgd2lsbCBiZSBtb3JlIGluIGxpbmUgd2l0aCB0aGUgZXhpc3RpbmcgY29kZSBpZiB3ZSBw
cm92aWRlIGEgZGVkaWNhdGVkDQo+PiBoYW5kbGVyLg0KPiBUaGUgZXhpc3RpbmcgY29kZSBvbmx5
IGRlYWxzIHdpdGggRG9tMCwgYW5kIGhlbmNlIGRvZXNuJ3QgaGF2ZSBhbnkNCj4gcGFpcnMgb2Yg
aGFuZGxlcnMuDQpUaGlzIGlzIGZhaXINCj4gICBGVEFPRCB3aGF0IEkgc2FpZCBhYm92ZSBhcHBs
aWVzIGVxdWFsbHkgdG8gb3RoZXINCj4gc2VwYXJhdGUgZ3Vlc3QgcmVhZC93cml0ZSBoYW5kbGVy
cyB5b3UgbWF5IGJlIGludHJvZHVjaW5nLiBUaGUNCj4gZXhjZXB0aW9uIGJlaW5nIHdoZW4gZS5n
LiBhIGhhcmR3YXJlIGFjY2VzcyBoYW5kbGVyIGlzIHB1dCBpbiBwbGFjZQ0KPiBmb3IgRG9tMCAo
Zm9yIG9idmlvdXMgcmVhc29ucywgSSB0aGluaykuDQpAUm9nZXIsIHdoYXQncyB5b3VyIHByZWZl
cmVuY2UgaGVyZT8NCj4NCj4gSmFuDQo+DQpUaGFuayB5b3UsDQpPbGVrc2FuZHI=


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 10:10:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 10:10:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267957.461720 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHNRj-0007SP-CL; Tue, 08 Feb 2022 10:10:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267957.461720; Tue, 08 Feb 2022 10:10:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHNRj-0007Rj-8P; Tue, 08 Feb 2022 10:10:03 +0000
Received: by outflank-mailman (input) for mailman id 267957;
 Tue, 08 Feb 2022 10:10:01 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=v7zX=SX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nHNRh-00078Q-EG
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 10:10:01 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4563d369-88c7-11ec-8f75-fffcc8bd4f1a;
 Tue, 08 Feb 2022 11:09:58 +0100 (CET)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2104.outbound.protection.outlook.com [104.47.17.104]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-34-U343J_WmOr-wpPEEa0YBWA-1; Tue, 08 Feb 2022 11:09:57 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DB9PR04MB8218.eurprd04.prod.outlook.com (2603:10a6:10:24a::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Tue, 8 Feb
 2022 10:09:55 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.018; Tue, 8 Feb 2022
 10:09:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4563d369-88c7-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644314998;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=M4rQrqktJ9qJOU8aq5h0JOM+mOJ+07dcVGkOMEmv3Ck=;
	b=acdGRz8neZEhNMytXdxmv5mpAUOkMe1PqSD8rC88lQcS9R+tA6gBgzJvNkEIDAxPuj+Sjf
	GttCSTHb/URvf3r6bc2PSDahg8sPyH8Hgv0ov4F6b2Z+I6JIoqYCHX3w+p4pve1zsdhbEo
	pQwZcjqENssIKKvSJN2LtwM8xVR4s8A=
X-MC-Unique: U343J_WmOr-wpPEEa0YBWA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=PqVJFj7sNgfZVlz3CqJWIBdFHb/QrIdWunhXsdoL3ActASxI3ADx11SdcQrN1lyDSPWwURui48jvvsFyl/Ph9sGKeVrDABuSEcFUn64/x0bv999ifpSsYQ6K6m43DLJg4TS3bfqexGNObHFpK9Z5Nj6GCNOcGTYkaUUr3f6bdTFZFsaVAz2d3+avG3apidmEQn5kHpGig3BvCSdA0IWaoWw9ZvOCZPDnr7Px1n0kIrso0slvWWVx8XvCxAIOPbUxSgvV0+DsPo9sBir9h0zsrt/fN0BIoodHiiUSBsim/7tVxa4BSvsoMuDoTLWJ7f86D4kELQWCNmvbGM7H2ZPxpg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=vVBiVm4gVmAPZf44A3S0k2OTUtggg9jjCjlGY834ecQ=;
 b=GtnU6GtUf3Dt6RpSWa2FJ7iQ+wQyrO0gCAt7PLfVvuJ2QtEf7j2cOIFTxsDkhAVnghCCLmaK7DPbuGjbtC+M0epbMDVowvFgZul8I9fN7LnmhARkVuz0zty1xBS1oGjF1PB/EfWJT3YI4KMdbng+EOBLHFs/mHJVOzl75Xgz/tzpRhvgFETBgeMWsuU2zccfWEOqBumtK8f2qfd+WSDFTD7EDc9ic0CFlycxo6ufEQEIaXYAhrons6tr7D+rLkKh2aGtkyVS/siNnoGhANciKak4CrsdWvhJMrASBAm6pTFeMOHi+EXDdBLuHbhFEJw9HxYLCCjg0V9PPFK7MUqaxw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <15c16171-f196-38d2-370c-38627935a21b@suse.com>
Date: Tue, 8 Feb 2022 11:09:52 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v6 05/13] vpci: add hooks for PCI device assign/de-assign
Content-Language: en-US
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: "julien@xen.org" <julien@xen.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Artem Mygaiev <Artem_Mygaiev@epam.com>,
 "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
 "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
 "paul@xen.org" <paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "roger.pau@citrix.com" <roger.pau@citrix.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-6-andr2000@gmail.com>
 <16cea1df-3d0f-d404-2b88-aab47ad5548b@suse.com>
 <3fe6dbe3-51c6-f87f-23f9-cf2e1a924326@epam.com>
 <582ee8f9-7b01-4adc-6a8a-ce8b1dffd534@suse.com>
 <e225553b-b29c-0448-fb9f-f8b513d9f77d@epam.com>
 <0fd8a0ac-dc91-287e-536e-1684892837ab@suse.com>
 <9f58a8ff-44b4-3249-5858-9988644b2d4e@epam.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <9f58a8ff-44b4-3249-5858-9988644b2d4e@epam.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS8PR04CA0097.eurprd04.prod.outlook.com
 (2603:10a6:20b:31e::12) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 06402a20-0202-4a9f-b230-08d9eaeb27b4
X-MS-TrafficTypeDiagnostic: DB9PR04MB8218:EE_
X-Microsoft-Antispam-PRVS:
	<DB9PR04MB8218BD96DF7800699E9D0B36B32D9@DB9PR04MB8218.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	V0vURm6mwcW5aCUWICI0+v/w+YwMGgTk0Gyz1RCClS0i0XBSUxGFuETSfCO37VsvNENMhIa0CnskKi+OXEk6i/Oy6Ir4lr7XTYkNkkLRW26buKoPu1h6av4+/o565i2zoeh0YRhfR9URLMTyM5hlSUSY/46GTnz/8zR/38q4HbUiFmrY4eptJ+DBVIwDWSzJuKvHl7LE9ejrM5qjE9CKtIybycfhHiBjjIu/IhrSjZPK5JDLzUi7GB3pPg1rKht9XU8KjbdApnkI9SRZQs2fYPK8JeyHsrxpTHYXLf3DoCnB6YYbVpG/PlVvFGwKBLxyAQf9DtJBVgPxGoHaKroWvxgzwGYK0l/ZBLx+f5olagshdq/V3JKLssDFEtM63+VSqRE363AIq4unQS9pQfKXpQgXVIlKRD7+TuqtE9fYr+5bpZ4Dq/Vr16dlHZA7m7SN9oWPXAhXfEPrqza5WWvL/5r7N2tRn7WaHl0C+/clPwmAzX425NIZIdfjfZ/pVuYAesYT06pFiqDdNB6TsOtpN+6zfCwZaO3P07btl0L+VbGmLgR/C3Smp5k3rLkfv9faSgg5Qiu9iugZWuj4PT5PyjFuoPLnoFjSiR3jgluIc2N+UEyDTXz/k1IntF8WUIhQEsxFo6RMjsRhpPDxOWNgEFsv4rXUGFm4cHqAo0dr/vOkXSh3AIhEdoCCixvF3brHEfrpUnz9XjAn+BeWRhTI3k6QyZhcBfvBTYRIocz3FX8=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6666004)(4326008)(66946007)(508600001)(8676002)(8936002)(86362001)(31696002)(66556008)(6486002)(7416002)(66476007)(5660300002)(6916009)(316002)(54906003)(36756003)(2616005)(6512007)(6506007)(83380400001)(53546011)(186003)(26005)(38100700002)(31686004)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?Kz9O6S7R5Yk+kmkxYlAdBznCcJym/VC0z+fxEBBz6S6sQGn9F0auMvL8OIi/?=
 =?us-ascii?Q?/1IAb+pn4NksHa4Wu3wusVIu+wHyCAVqcKW2+kyp/muprRdsXor2rw7FmU42?=
 =?us-ascii?Q?5bn1UnjAt4b1e+YIgXcMtjE+8OsNgy1VALcvI+qIAFhjb/Ex0WyE1/ePZAbU?=
 =?us-ascii?Q?YehSEbkx1PfDbyxukWumEaEOUQH/gMKLxYKQ5yVBrxJbi/PXJ3Vaz3f4olaj?=
 =?us-ascii?Q?t3I8UTDI4RdTw/N9ur10Wv+u3e5bnY4eaf8K/ariVsgqrYixdnt1A8eoNlsW?=
 =?us-ascii?Q?2e8QxktCgW477CV7jSLAYTbCm2o60K2ytCS9MUPLCUc/I4+Emk/fyRqUWla/?=
 =?us-ascii?Q?Z24Fmufrsah+ZjJ/idXP306NMHtApa7uc3BSVMdmiMTqgnPQQJdO/qoRetYL?=
 =?us-ascii?Q?1WTo4bPRUpzpUPzEZdgfSrEQfJJhLHJ/eMHu4UAzSEup6me3VNFrTA32vFMu?=
 =?us-ascii?Q?BoklSn9lRvSMKAkY3M8xC6jzYH00eIy6e37LeOkG1ITpIo3nKnUfdm2oCBmR?=
 =?us-ascii?Q?oYV7+GW8r2GjDa3/Js3yF+jv4YSKUx4v7Ff51/GG4wJObSvIa62tXOu1ntm+?=
 =?us-ascii?Q?Toz+dZ1d9ejEJ8pMFiEB02sAREg2rPRoLUGkTkN4VXkjjWE1xD6IuY9dSD4N?=
 =?us-ascii?Q?aqrK04T22gDNYED4I2EDoznI66m4ftxNAbEwewd1vwyCDVP8tELqLbGvT9BA?=
 =?us-ascii?Q?ZuG+eGis/DDfz5zbtgM5+B0EVjN/dqoAzmB3fX2jdmS38p3/sqXiYzBLgV3Q?=
 =?us-ascii?Q?qIoclu49P4tzvYFafz6uVaVeQd4i/z7rDmdL0BcwPkutbIzqQjwkvPd3m7Ze?=
 =?us-ascii?Q?sIg6HWqtSPbF+a278jy8YR4yThbadgwunqdyVDnsk1TVlOiySBGBBjKSxKUq?=
 =?us-ascii?Q?zxJr7vj1eeAM9uw89lmCxaMDTCAdWii5Kf1pLD/CcuHgTWL5M9laH+8+eHIP?=
 =?us-ascii?Q?04Xb8oqhfAvbu3t3hSle8wb51FDsBzK7I7YIt1enoKO/dPAsWKG3qqTMQZRY?=
 =?us-ascii?Q?7x6SXiPLFqtoG8knt7hgmVVKVtu7huiNSqPkteN85VN0Hq0BygeC/NXPP+IS?=
 =?us-ascii?Q?+a9MQuiVBZ0+VztBuFNiUNMu1GntX89tpUGu1WNG3+KiPMMUw8uBpg2zVONh?=
 =?us-ascii?Q?TeJvhK2dSH1n0lwrUiTZB5RNRbeBTDLeuRqo5VFjTg4RS1uAuZFEAnKJRZY6?=
 =?us-ascii?Q?7+0BK+UPQYnJLOrk4OFaklvel1M6r+7wnU3PK9Yo+c9mGx936dYhsClMQdIa?=
 =?us-ascii?Q?rRFQwmNvhJb2Ld+RLwXKPj56YV7ab1f7cljfG1YVs3/fND5Hnp+s/R1ycG8z?=
 =?us-ascii?Q?//kqBF9rQQEprtnh8qreI05ILpMKHTINXSRQCUS+73eNBuUJnIXpHIViWlIH?=
 =?us-ascii?Q?ZJg07wdayRAHKP7ZdxeQQmEWmRGyNBU8N9B2Aan6wQnkoy4sDnpuUW+tvTlE?=
 =?us-ascii?Q?lQPeAI2yTBVYSARdrpxnNiCg4Kvdl1mTs4VkJyPC8PREdCf+eTKgghMXfvkc?=
 =?us-ascii?Q?MrRxNnoP1eTjwZjjxBwBSYwRFmTeAiZKPHbPgKL+RwoSpqATk2fMNfspPs1L?=
 =?us-ascii?Q?rUQeYuzsYKr5e/C2w6FD2/1cuY3ftBtFr+h+WBMo+0T4grXddJQskfgK6B4N?=
 =?us-ascii?Q?UNcXBrKxb8eIpkfQrNVUPME=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 06402a20-0202-4a9f-b230-08d9eaeb27b4
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2022 10:09:55.5722
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xhh0cw1qJAwNpCNfIia+QwI8UEV5hWlpAergCwfe36xja5+HPUYzsnB8bNZM1H8LeunXydEQUiCYj0BzB0LMDw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8218

On 08.02.2022 10:55, Oleksandr Andrushchenko wrote:
>=20
>=20
> On 08.02.22 11:44, Jan Beulich wrote:
>> On 08.02.2022 10:27, Oleksandr Andrushchenko wrote:
>>> On 08.02.22 11:13, Jan Beulich wrote:
>>>> On 08.02.2022 09:32, Oleksandr Andrushchenko wrote:
>>>>> On 07.02.22 18:28, Jan Beulich wrote:
>>>>>> On 04.02.2022 07:34, Oleksandr Andrushchenko wrote:
>>>>>>> @@ -1507,6 +1511,8 @@ static int assign_device(struct domain *d, u1=
6 seg, u8 bus, u8 devfn, u32 flag)
>>>>>>>                             pci_to_dev(pdev), flag);
>>>>>>>         }
>>>>>>>    =20
>>>>>>> +    rc =3D vpci_assign_device(d, pdev);
>>>>>>> +
>>>>>>>      done:
>>>>>>>         if ( rc )
>>>>>>>             printk(XENLOG_G_WARNING "%pd: assign (%pp) failed (%d)\=
n",
>>>>>> There's no attempt to undo anything in the case of getting back an
>>>>>> error. ISTR this being deemed okay on the basis that the tool stack
>>>>>> would then take whatever action, but whatever it is that is supposed
>>>>>> to deal with errors here wants spelling out in the description.
>>>>> Why? I don't change the previously expected decision and implementati=
on
>>>>> of the assign_device function: I use error paths as they were used be=
fore
>>>>> for the existing code. So, I see no clear reason to stress that the e=
xisting
>>>>> and new code relies on the toolstack
>>>> Saying half a sentence on this is helping review.
>>> Ok
>>>>>> What's important is that no caller up the call tree may be left with
>>>>>> the impression that the device is still owned by the original
>>>>>> domain. With how you have it, the device is going to be owned by the
>>>>>> new domain, but not really usable.
>>>>> This is not true: vpci_assign_device will call vpci_deassign_device
>>>>> internally if it fails. So, the device won't be assigned in this case
>>>> No. The device is assigned to whatever pdev->domain holds. Calling
>>>> vpci_deassign_device() there merely makes sure that the device will
>>>> have _no_ vPCI data and hooks in place, rather than something
>>>> partial.
>>> So, this patch is only dealing with vpci assign/de-assign
>>> And it rolls back what it did in case of a failure
>>> It also returns rc in assign_device to signal it has failed
>>> What else is expected from this patch??
>> Until now if assign_device() returns an error, this tells the caller
>> that the device did not change ownership;
> Not sure this is the case:
>  =C2=A0=C2=A0=C2=A0 if ( (rc =3D iommu_call(hd->platform_ops, assign_devi=
ce, d, devfn,
>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0 pci_to_dev(pdev), flag)) )
> iommu_call can leave the new ownership even now without
> vpci_assign_device.

Did you check the actual hook functions for when exactly the ownership
change happens. For both VT-d and AMD it is the last thing they do,
when no error can occur anymore.

 My understanding is that the roll-back is
> expected to be performed by the toolstack and vpci_assign_device
> doesn't prevent that by returning rc. Even more, before we discussed
> that it would be good for vpci_assign_device to try recovering from
> a possible error early which is done by calling vpci_deassign_device
> internally.

Yes, but that's only part of it. It at least needs considering what
effects have resulted from operations prior to vpci_assign_device().

Jan



From xen-devel-bounces@lists.xenproject.org Tue Feb 08 10:11:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 10:11:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267967.461731 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHNT4-0008Ux-SO; Tue, 08 Feb 2022 10:11:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267967.461731; Tue, 08 Feb 2022 10:11:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHNT4-0008Uq-Oe; Tue, 08 Feb 2022 10:11:26 +0000
Received: by outflank-mailman (input) for mailman id 267967;
 Tue, 08 Feb 2022 10:11:25 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=GmUj=SX=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nHNT3-0008Uc-E6
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 10:11:25 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 77273060-88c7-11ec-8eb8-a37418f5ba1a;
 Tue, 08 Feb 2022 11:11:23 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 77273060-88c7-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644315083;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=9IlNBvyj4Xt78XJk4IsnQgSM2HKibfLtdl2cxW9hgaI=;
  b=E4FXH3xIpfX4ZoZoLa3+IRtUlZ6IC44sSI2bll01NLfCDm56hvgyTFfI
   +c3E3jt/iUKyGcSk86D6RUd2ODh25nZbXT7BIXdqmf+Lt53rhdnjQ4aE9
   zvmllDAn2A6tGJ4b2e8zJy5cYu70P7a3K/8m3rN0uXFhyQHBMBiL9rV8j
   s=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: pII45nKWVQwacj6Oprq5sU/Q0LsmTMQxRtCIuhj9BcwcGgnpWivAH2fZ1+rybeW0JRqp7vvRa9
 aomSOWRBjz6h5EM+AEhrsDs91cpSFyUE8EiKI3rXQv3H86Dqu9jZhFv7swe4eafN7NpisSjof/
 qBkwolm8UStAPloKzvHyvVpI+ukLrC0skXZMBMP+ckdwmpl5r3NeRvYVcBwSQapMlVbmlJ6Slh
 Llq0Ccq7bjVp7CLBPGdyRqlV057hjmDXsizADRhGETsqNyBfGuDa4/Q3kyk2Koi6WuNd+9OrhP
 1ti5Qu1k+nVKgYqj3QDAJFIP
X-SBRS: 5.1
X-MesageID: 65930190
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:HdaBjq8Y9yk7ZznDHVURDrUDoHiTJUtcMsCJ2f8bNWPcYEJGY0x3n
 zYbCDzUPqncNjPxfNAjaYzn8R5X65XTnYNrQQA+pC48E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhFWeIdA970Ug5w7Rh0tYx6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPgg4
 Yl9mqatWTt4AaPyieo8XDBhPhxHaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguw5K8bmJsUHs2xIxjDFF/c2B5vERs0m4PcGgWZr3pkfRZ4yY
 eIeM2o0XBjhYydNFUYxEpYertaFhHrgJmgwRFW9+vNsvjm7IBZK+KDkLd79atGMA8JPkS6wj
 3ja8mHOJwAVPd2S1xKI6nupwOTImEvTUo8ICKex8PIshVSJ33ESEzUfT179qv684mauVtQaJ
 0EK9y4Gqakp6FftXtT7Rwe/onOPolgbQdU4O/cz6ByJjLHV5QmZLmEeS3hKb9lOnPExQTsmx
 1qYheTDDDZksKCWYX+F/7LSpjS3UQAyKWIBfiYCQREyyt/vupwojhnPQ9BgF4a4ltTwXzr3x
 liiriIzmrEShs4jzLig8BbMhDfEjprUSg844C3HU2Tj6Rl2DKaCY4Gr8lHd4ex3EJeCTlKBs
 X4HnOCT9OkLS5qKkUSlW/4RFbuk4/KENjz0glN1GZQlsTO39BaekZt4uW8kYh0za4BdJGGvM
 BS7VR5tCIF7bVL2XYBNfpKNWvsk87nuNNvMb93pV48bCnRuTzOv8CZrbE+W+mnilkkwjK0yU
 aumndaQ4WUyUvo+kmfvLwsJ+fpyn31lmzuPLXzu50n/idKjiGippaDp2bdkRsQw9+u6rQrc6
 L6z3OPamkwEAIUSjsQ6mLP/zGzmz1BmX/gaSOQNL4ZvxzaK/0l7WpfsLUsJIdANokisvr6gE
 ouBckFZ0kHjonbMNB+HbHtuAJu2A8oj9CNiZHJ9Zw/zs5TGXWpIxP1OH6bbgJF9rLAzpRKKZ
 6Vtlzq87gRnFW2cpmV1gWjVp41+bhW77T9izAL+CAXTi6VIHlSTkve9J1OH3HBXUkKf6Jtvy
 5X9h1izacdSGGxKUp2MANrxlAzZgJTosL8rN6c+CoIIIxuEHUkDA3GZs8Lb1OlWcUqanWbBh
 1/NafrazMGUy7IIHBDyrfnsh6+iEvdkH1ocGG/e7L2sMjLd8HblyohFONtktxiEPI8t0Kn9N
 +hT0d/mN/gLwARDv4ZmSu45xqMi/dr/4bRdy108TnnMal2qDJJmI2WHgpYT5vEcmOcBtFvkQ
 F+L9/lbJa6NZJHvHmkOKVd3de+Ez/wVxGXftKxnPEXg6SZr17ObSkEObQKUgSlQIeItYoMoy
 OssouAM7Am7hkZ4O9qKlHkMpW+NMmYBQ+MssZRDWN3njQ8iy1djZ53AC3CpvMHTOosUakRze
 22anqvPgbhY13HuSXtrGCifx/dZiLQPpAtOkA0IKWOWl4eXnfQwxhBQr2g6F1wH0hVd3utvE
 WF3LEkpd76W9jJlicUfDWChHwZNWE+Q9kDrkgZbkWTYSw+jV3DXLX17MuGIpRhL/2VZdzld3
 beZ1Ge6Dmq6IJCvhnM/CRx/tvjubd1t7QmTysmoEvOME4Q+fTe40LSlYnAFqke/DM487KEdS
 TKGIAqkhXXHCBMt
IronPort-HdrOrdr: A9a23:4n4uMK+yiHC30URk5d9uk+FAdb1zdoMgy1knxilNoENuHfBwxv
 rDoB1E73LJYVYqOU3Jmbi7Sc69qFfnhORICO4qTMqftWjdyRCVxeRZg7cKrAeQeREWmtQtsJ
 uINpIOdOEYbmIK/PoSgjPIaurIqePvmMvD5Za8854ud3ATV0gJ1XYGNu/xKDwReOApP+tcKH
 LKjfA32AZINE5nJfiTNz0gZazuttfLnJXpbVovAAMm0hCHiXeN5KThGxaV8x8CW3cXqI1SvF
 Ttokjc3OGOovu7whjT2yv66IlXosLozp9mCNaXgsYYBz3wgkKDZZhnWZeFoDcpydvfomoCoZ
 3pmVMNLs5z43TeciWcpgbs4RDp1HIU53rr2Taj8A3eiP28YAh/J9tKhIpffBecwVEnpstA3K
 VC2H/cn4ZLDDvb9R6NqeTgZlVPrA6ZsHAimekcgzh0So0FcoJcqoQZ4Qd8DIoAJiTn84oqed
 MeQ/003MwmMW9yUkqp/VWGmLeXLzYO91a9MwQ/U/WuonlrdCsT9Tpc+CQd9k1wg67VBaM0o9
 gsCZ4Y542mePVmGZ6VNN1xMfdfNVa9My4kEFjiaGgPR5t3c04klfbMkcAIDaeRCds18Kc=
X-IronPort-AV: E=Sophos;i="5.88,352,1635220800"; 
   d="scan'208";a="65930190"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gaPNl2pG6u8vNF6wAf54tXfJIlTc4bUMqxBs2YLcCSlDUrxYzweDvbwkQrkCZNAm+clB7jYGsyCklNn8Fl/CQ4zG73DaNVqtRQBxeVmbCa6Q1dbyB/mOMyqAt17exF/Q/XNqgoceRuAdtt9EM3w8UAYHDBJgknJwSCuganpNhTX8CuSnz4T9bj5FlRm167IeYe2a38IbTq5zr5ZSiK8EDdBLUs2lBxD3q7n9933tX69UyigwxI9Cx1dPSaaJCHloxB+Dff5eQqXnTFSrcSuTJy5nvDm76t/01bY6iwaR7B3A0q3CE4w5jYeSC6ZZ0VnDt7hn1cHah3fQR0768VEEdA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=LI9VW8Pk5kJ7LXO2kwg/5AE5zwMQHkvZPn1RbdhVvFY=;
 b=gdb5Fzrf1tr0OW9Wv6BvMJVoL/DiU1hIo5tpkwLaKF0Oq6h28jkZk/VsxMs+ZtOibSTRYc+Nlx/U4vT+QydSRwYAgthc+eDUow+6cGHXIdfbRsuVoCea/OjugYIrT8NlwPbLvkEAQurtiAx5JTwxTBd+mKc0+4wH1E6AqLAy9uipuEv8/8M9qKADrmgdJvhstYNAVXhryhbybz1AsIW5YCOZA302z5nI5/6oUdCOdsyZao1aAwbc7ZqGl7hqarms7y/XsPOqNvjPEr/VUydzNZkivfLu7S7aKfaINredaQT1WxiBTq6NnnK8Zpi4FrMAfb1/jbF54Vi8gZIFSPDvTQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=LI9VW8Pk5kJ7LXO2kwg/5AE5zwMQHkvZPn1RbdhVvFY=;
 b=WPXQ92PfCNSxdtesrU6n4WsAmU6FfF8TBfAPttI4YK7WcSUPPdLQI3Y07JOkDTivaOCGSPp9oq+tWUsX8SYljZn2ItqB6h2Vd7hTChsJ0lvJzti/XbCg5val3ap0/qhm64YqR4QSn/++R9rs9VOhq84KNcUvrm5YdIcKSlG7QFU=
Date: Tue, 8 Feb 2022 11:11:14 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>,
	"julien@xen.org" <julien@xen.org>, "sstabellini@kernel.org"
	<sstabellini@kernel.org>, Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Artem Mygaiev <Artem_Mygaiev@epam.com>,
	"andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
	"george.dunlap@citrix.com" <george.dunlap@citrix.com>, "paul@xen.org"
	<paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>, Rahul Singh
	<rahul.singh@arm.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Message-ID: <YgJBwrB/qDLSNMIu@Air-de-Roger>
References: <9ce90193-74a0-5642-d22b-6b8c3340c3cf@epam.com>
 <1f65ae7a-898d-2c27-0ada-d71d778b0627@suse.com>
 <YgEsRuckQJIQlkzf@Air-de-Roger>
 <a2a42c1d-d379-00cd-5d55-f443cdb02e97@epam.com>
 <e8fc7872-c7d0-f389-c507-335b809ffcbc@epam.com>
 <21c8125a-2f79-1a4a-494c-db9e4be2a1a6@suse.com>
 <4276fe72-558b-7d95-6430-d4330989dbe8@epam.com>
 <ad985f4a-10f0-4a2d-df02-cde915fea3f1@suse.com>
 <f7669670-8eeb-9966-5ba3-e8f9c03ce3d3@epam.com>
 <73e08285-6bb1-5842-899f-bd6502406e49@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <73e08285-6bb1-5842-899f-bd6502406e49@suse.com>
X-ClientProxiedBy: LO2P265CA0477.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:a2::33) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a36abdcc-469d-4f96-d176-08d9eaeb5952
X-MS-TrafficTypeDiagnostic: PH0PR03MB6738:EE_
X-Microsoft-Antispam-PRVS: <PH0PR03MB67389A5834471FF24467D4F38F2D9@PH0PR03MB6738.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: UPzYPuC1MSvejOOurbG6R7cTi71FZkX9npPqLRwZMO4B8GFb7V6Rp43SspfzXjxRSiclUFF+TUsED6uVMxlSDtwtg3LC+LIbdsdERsVi+Ez7s2sBjsh/LO81dFAtVotweu1zOltRz0r3Fi0eBGNxUjldLxdfVvQJ8ntoPybAc3H5I3S+LlA5qfSyqB2FjEEnDfkqLYysgnnFCb4ztdtVdJSO5I59ZPCDaUSGAsZ/8za86aLQIXi7JolJbTVfg9Xj0gQeR4Ni2VCYaXdB3gyAd3T+FQyTuZXFSmGyKZy41+8tg+9shLOvvtsv9sPEtdgKz5DAZnmRndWIEyaoI1vgTzIJRv32RLSlCCfvu7MrzCHz1H8t0Y1gHnbuodwbfl8ADBahITa7m2gfEYO4oTIOuDDhhHmKwLgHIi/sRVcFElRjVGG4Vk/FuZpPwT27RL1ylqZw1c+gahGC4I1kbwOkldAkgPwIIPhhziIi6NpUoG0dGKmVqgWNuobrRI7/dXhyWJeHNIvNWvsvjIFax0R88JKewuGUm+giARULiJHDNLtcHiACyTE5mfW4pwGHpv+b+F7ljunal9/RKncf7F5L2weJsic4HFjEW3bZdGyQqiHvxdgqQZk6i5w7Pvl4DnjseipepxYq1QEOMQMP5tDz6A==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(5660300002)(8936002)(66946007)(66476007)(6666004)(7416002)(4326008)(8676002)(6506007)(66556008)(9686003)(508600001)(6512007)(83380400001)(54906003)(85182001)(53546011)(82960400001)(86362001)(6486002)(26005)(316002)(2906002)(33716001)(38100700002)(186003)(6916009);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NTRvRmI5aytCNFY4OWdjNk1zeGVSM3V5RzUzWis3b1BXSzZLK0o0TisxamRv?=
 =?utf-8?B?NzNldFhpSGYvNmNMREJNVUhodTRWZmxWWlBGM3E5eVVpL0tHK1JVK3dQeUdr?=
 =?utf-8?B?V0cxdlpvZ1dNczkvSC9RS0Y1VFR4M3ZmU0x4SWg5aVJkcHB1Q1cxNC90bFU1?=
 =?utf-8?B?MzYxcU1sS0pSU2VDQ3dreFQ0bGdTKzlibzRpMDFSVzFrNDFxN0hrOFRjVkY4?=
 =?utf-8?B?TFFqY1U3R0k4MmpFM2YrcXNkWEx4dU9GTVN0N3ZORnhxQTBKcEJTYXpyRFpK?=
 =?utf-8?B?YmQ2dUM1RmwzZXFNR09JQVlPYVhjaXcwb25HeHBYMXJWM01iL1JVZnh1cVNr?=
 =?utf-8?B?KzN2ZlRSQ09zQUJjZkNTNDNSZWlVY01DNkcrc0JZMWdXOGxVSjA1MTU1U3dm?=
 =?utf-8?B?V09uMC8vUnlqZWtqMWdZNDc3bmRDL2E1UTRVbFJlQjhydUp3SzUrcnNnS09P?=
 =?utf-8?B?NnpQSlV4V3VLRDd5UjNLMnhFelZudExrRXRORFloandmajNpMGNDaFlhWmt6?=
 =?utf-8?B?M3gwQXd5UXlVUjZLbzQ2c2lRVUVpNFFpZVJKbjB1TFZ1Y21CV1V2SXNoM0Q2?=
 =?utf-8?B?N1djaW9kSHBJMFlqNzk5UHhjb242cHJpeHUxMTB6ZndaZWc4eG04MFFYR09W?=
 =?utf-8?B?TXdMSGhQQklZYXRNOThidUZFK0NjUXMyZytXOXVZZ3l4MXErMmg5c09TazA1?=
 =?utf-8?B?TFZHRENPM09WZ2N0b2pXWGRIYmNNRlM3YkV0QS8vN1RjUkJqbm0wQzNFcjZn?=
 =?utf-8?B?d1lXeGplbmVsVVVwUWN6WUN4Zm9Nd2FJdURGNUh5SHNkazluMHgwenQ0K0NF?=
 =?utf-8?B?aFRDL1MxMG1XbC9qRmFsUXR3YVZBNDFtSmlheC9CQks0b1U5Sms5RGdHR2hW?=
 =?utf-8?B?Mk9pVDYyWndheFMxUFFaSU11Vld2cnUwTlZSdzhiNmhhT1dtRE9LR21ITmFv?=
 =?utf-8?B?QXdXM2lpem9malBOMEJjYVAwU05jcFA0WGNnVnV1b1JqK2wwems4aEdMSXgv?=
 =?utf-8?B?Ymg1bVRQTUN4ancwcUF0QUNNVnJ4SGRGRGV4VStWVGlJTE5VcTBkRWRsYVdt?=
 =?utf-8?B?QnViWGs0Q1BDNHEycnhhaERDczlyUjZPL3hRbThhNk5KM0l1RlhsR29PUlkr?=
 =?utf-8?B?clN3VE1UTmJpd1FGM1UwM2pqVWFNRmNGbWpROE5MVjdiSWowZkpWOHFKUGdR?=
 =?utf-8?B?Ym5RZldMcnMvdE5pdHVkQlR4bG5ubWJJbEkxZFcycEpOQWFIcUpZdHozYldP?=
 =?utf-8?B?WWtHZGREeEtOczZ0d0I4akEwbUhqNDFPYWRQeE9hZnpsVkx0eWVVYmxPVmFO?=
 =?utf-8?B?WUU2SitYZ0NuaUpzaU4vR0NYeTUwZUM5YzhiSGpleTFwNXpPdnBvQ1h5bFBs?=
 =?utf-8?B?TXRRR1FWUXJ5ZVQxS2c2dmJ0L0dYYlBqUGM2aUVoNTY2dmdqWFFNa1NHK2tT?=
 =?utf-8?B?eHlwWjgvdCtUSWo3Q2ZuNCtJMzRReTk2T0pRc2dvcWZnZ3NOZm5oM2NjcG9F?=
 =?utf-8?B?NzBHVnBsV2VhTExxNWV0cHl6Skh3YnFmMHZBSWhQdEJ2Mk1MK1RSUU1aWmFi?=
 =?utf-8?B?U0tIYzNwc3dQMVhyeGI0MDZTazM1VDk5d1RwK2xmK3FEaUZxNUxmM045WDY1?=
 =?utf-8?B?dGFpbndvMkNKL0pPZEl1cURzcTRQM25GVVp5N2UwSmhWQ1VndFhyNjBOQlpX?=
 =?utf-8?B?bkNWZVQ0V1RzVElaRFlwVFh2Z3MybHI2YjlsdG0weHlPeU5pbWdzRG5oMmlJ?=
 =?utf-8?B?UWppNlpYN3dOSUpwTzU1VEJHSTM3Sjk2MTc4T2ZzUDAza3U0cTh2dlBkNmJr?=
 =?utf-8?B?aDh1KzVHY095Q3BPS0ViTGE0b296MEV2VVA1bDEvVjZMc2lHSUZXU2Nod3RR?=
 =?utf-8?B?MTBIL1djT2JSeEpQZHA1V1RYRTRZVEhBamFVQmtibGVIbmJBNEdsU29DSGNo?=
 =?utf-8?B?MEFjYnlGcGI0L3d0OWVKWVdjcWcwZXhPT1djWXlvMFlPTlBYb3FpY2Zrd3Zl?=
 =?utf-8?B?bGFJSHY2TUF5U1lPclJBRE00L2E1ZHo4TmxkN083VUF5OU1LWnpsY0Y1OHJI?=
 =?utf-8?B?N3FLUVRmbXdldGdkcnI1OERVSXE4anZDanc3ZnBVSTRHcmVuRVJQSm9Ldncx?=
 =?utf-8?B?WUdONk9WUXpyQXNuYVluOFFJWTRsMk5veWo1UnhsVDlrUkFITkE3RHJkYTRT?=
 =?utf-8?Q?C7RWJCphwxTiRvBYsfQVbWg=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a36abdcc-469d-4f96-d176-08d9eaeb5952
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2022 10:11:18.7855
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jJ/Zh1ySzUtDIjAzyKTGSfPpB+Hv2HiOBsdETPlurO/GV4pAh/RCAsN2UW5opttMNO1XAm5ycprK91A7gG1ZSQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6738
X-OriginatorOrg: citrix.com

On Mon, Feb 07, 2022 at 05:37:49PM +0100, Jan Beulich wrote:
> On 07.02.2022 17:21, Oleksandr Andrushchenko wrote:
> > 
> > 
> > On 07.02.22 18:15, Jan Beulich wrote:
> >> On 07.02.2022 17:07, Oleksandr Andrushchenko wrote:
> >>> On 07.02.22 17:26, Jan Beulich wrote:
> >>>> 1b. Make vpci_write use write lock for writes to command register and BARs
> >>>> only; keep using the read lock for all other writes.
> >>> I am not quite sure how to do that. Do you mean something like:
> >>> void vpci_write(pci_sbdf_t sbdf, unsigned int reg, unsigned int size,
> >>>                   uint32_t data)
> >>> [snip]
> >>>       list_for_each_entry ( r, &pdev->vpci->handlers, node )
> >>> {
> >>> [snip]
> >>>       if ( r->needs_write_lock)
> >>>           write_lock(d->vpci_lock)
> >>>       else
> >>>           read_lock(d->vpci_lock)
> >>> ....
> >>>
> >>> And provide rw as an argument to:
> >>>
> >>> int vpci_add_register(struct vpci *vpci, vpci_read_t *read_handler,
> >>>                         vpci_write_t *write_handler, unsigned int offset,
> >>>                         unsigned int size, void *data, --->>> bool write_path <<<-----)
> >>>
> >>> Is this what you mean?
> >> This sounds overly complicated. You can derive locally in vpci_write(),
> >> from just its "reg" and "size" parameters, whether the lock needs taking
> >> in write mode.
> > Yes, I started writing a reply with that. So, the summary (ROM
> > position depends on header type):
> > if ( (reg == PCI_COMMAND) || (reg == ROM) )
> > {
> >      read PCI_COMMAND and see if memory or IO decoding are enabled.
> >      if ( enabled )
> >          write_lock(d->vpci_lock)
> >      else
> >          read_lock(d->vpci_lock)
> > }
> 
> Hmm, yes, you can actually get away without using "size", since both
> command register and ROM BAR are 32-bit aligned registers, and 64-bit
> accesses get split in vpci_ecam_write().
> 
> For the command register the memory- / IO-decoding-enabled check may
> end up a little more complicated, as the value to be written also
> matters. Maybe read the command register only for the ROM BAR write,
> using the write lock uniformly for all command register writes?
> 
> > Do you also think we can drop pdev->vpci (or currently pdev->vpci->lock)
> > at all then?
> 
> I haven't looked at this in any detail, sorry. It sounds possible,
> yes.

AFAICT you should avoid taking the per-device vpci lock when you take
the per-domain lock in write mode. Otherwise you still need the
per-device vpci lock in order to keep consistency between concurrent
accesses to the device registers.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 10:16:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 10:16:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267978.461742 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHNXa-0000kZ-Dz; Tue, 08 Feb 2022 10:16:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267978.461742; Tue, 08 Feb 2022 10:16:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHNXa-0000kS-Ap; Tue, 08 Feb 2022 10:16:06 +0000
Received: by outflank-mailman (input) for mailman id 267978;
 Tue, 08 Feb 2022 10:16:05 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=v7zX=SX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nHNXZ-0000kM-JV
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 10:16:05 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1d2a2f23-88c8-11ec-8eb8-a37418f5ba1a;
 Tue, 08 Feb 2022 11:16:00 +0100 (CET)
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur02lp2056.outbound.protection.outlook.com [104.47.4.56]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-40-p8IK3daYM3qOWTIqeXyWVA-1; Tue, 08 Feb 2022 11:15:59 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by HE1PR0402MB2746.eurprd04.prod.outlook.com (2603:10a6:3:e0::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Tue, 8 Feb
 2022 10:15:57 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.018; Tue, 8 Feb 2022
 10:15:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1d2a2f23-88c8-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644315360;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=CtMMP43uEt9rDbzITVASwgIYRvD2R2zLaamXVRrNQ6g=;
	b=QcXVlvov9dEMm84gWBLIjQiYUDHE+FTolONiaQQxqDCaFqr2kosj50iJt31++DB3X5NH/e
	1RWNutKWqg+zjJr/0xleRNba0jmfrNwMmGIxqrNig7PbdmjcgBAggTIYpossduGsFF1C8C
	O6fsfjI9SVJ8rGzHUNho/+zxLaJDjAg=
X-MC-Unique: p8IK3daYM3qOWTIqeXyWVA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=EZE6zwPECNvKRali87PrKL9/ByUjaECuSwLylBMxp3jZK/zeKQkOAYzgD4I7aTvo5KseT1Ppr6ByvoKuWsQr02KdTaO6uG5fMuJPn72zoI/ez4gS9NXEBCAhfq4WZ1XWIwBnWMSWxQNB18qxeyVXCjdaVh0xmFEw8BaE9E85/SSrWuSUy7oxGv7i05I896oLynC9hnGGy26aymJzpqoPcoUAONXhojWM7Gry2RMeCpCFsWkIvNqhHaemWO1P+RFgm4VMkdrHMUQG3JGHndlR8x4QwSFu9lAYC1z99OBq8aRZoaxMjvrnkZPt90WwkziE3L+NK3zgMDQHcE0Gr51A+w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=YG8lBv/XlcZXRu5HQV2VwszfXg+gO50d+nShyxlFAVA=;
 b=gFKAArd8DvB9/A32shsEt1VeX4aDOu4YJkCoKjTjL/dTMhneNX5G1zveQxdT8aUPpWcfA696fh3PNSzP7qW6C4+oB00kitaDFGqftGgD/bkaUtJUkNDVJoMrEX/TTLLK4FofhmLukfX2xmnI/ylbnLWaw1BxnBbK1QrszQKsm898Lsc+75SSgS7Ug/e6tv56MY6HsBL9NspqyNytlm6ysLKb1FmmItaXjM49sgNcjGoV66gBCuz+34XJcpyKLNCDzPDdc4PvAgSCtWfmWj+gwnDOhzIbL2PZezpVB+r1ZbjEpuBW4BORWCEw11+OZHk+hAuW94FcmYl37l91OTZ2OQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <41552c52-5e2e-5108-ab37-d1fb5d9b5edb@suse.com>
Date: Tue, 8 Feb 2022 11:15:55 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v6 06/13] vpci/header: implement guest BAR register
 handlers
Content-Language: en-US
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "julien@xen.org" <julien@xen.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Artem Mygaiev <Artem_Mygaiev@epam.com>,
 "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
 "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
 "paul@xen.org" <paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-7-andr2000@gmail.com> <YgI3HpFffudiEmNN@Air-de-Roger>
 <498ca523-2642-e35f-b316-0a089f98ca91@epam.com>
 <5bc96dba-e9b8-de2e-f6aa-ae6c604897e8@suse.com>
 <6ac5d7ce-96dd-66e1-c8d1-eff7b0a1349e@epam.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <6ac5d7ce-96dd-66e1-c8d1-eff7b0a1349e@epam.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM5PR0201CA0010.eurprd02.prod.outlook.com
 (2603:10a6:203:3d::20) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2dac9786-8191-4829-caf9-08d9eaebff99
X-MS-TrafficTypeDiagnostic: HE1PR0402MB2746:EE_
X-Microsoft-Antispam-PRVS:
	<HE1PR0402MB2746F80FEB26450B02DC8A7FB32D9@HE1PR0402MB2746.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	VuhZBOhQj1ioqsOLm8R2ctTUfkGkWNwVwuL0CdTVepwdgEUoezWtGxm3QgDZPaodzipsluzvgPSyE6Llu0NAvaJT4l1WM4ao68O1aklG2mW92TnZ+zkHjuGMVdaC7wn/i6QiyophiLxiBr3R52dSTuzWpMZeEwHW2dKVJ0EZfmsDsPdBLUfD+MDLtUIk6CVFV533A6YClBvfD1hMa3pHcWKk6I3/4Gsx06WbIKWH+phAKYCVozXgXMQ84EhIrbBirTZ7f/Wt78UIfeK3ntg9Ly2KgKPkRNzbYThVC7TRsonYjB4rdW3z/MiNkLuAhDtVtapE7xtRfdGmmsrIKIcCxN4Ut0pTi8ipoJYQT54czMK1LNEro6ULY88/vI4AyAYpq01yXfEM514pGG/pZq5uv5lkaVbLKSAUE7FbIAcpUNkzUUBxIH76NdHFdulW42Gko3NJM1t+t3jtuUAG9ytJFBuWBabGmA4+eoqJ2trAWM6np6CeNNPHP5V7K86HeWucjfQa8eHDMAz/j6y5bqjJfJgeqruYIUw+VuAtjWqxwcx8VPJEcxR3cw8ZfqEA9hmablxHZI2dzbvnR+4AbgXIpBg8ISkcV1ZltpY/DTvHjweesLj+ICuhBnIRda6hnP/lPq8YGVyPLd+V7bkRe357xpyGHLQ8A/UEu+VxQraDzXsMsw24PMQ6sliI2U6UoGdfQxS2tg4oSybdFmABIsrDe3DtFe6aVMMHphW2rn9gngo=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66476007)(4326008)(53546011)(54906003)(6916009)(316002)(508600001)(6506007)(36756003)(83380400001)(31686004)(8676002)(8936002)(186003)(26005)(2616005)(5660300002)(86362001)(2906002)(31696002)(6486002)(6512007)(7416002)(38100700002)(66946007)(66556008)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?RpFYzSzz30fVvLo5+BPt0Bjtr8dvEXZSW5FHNKlB2vdcm9pYEhmUSm/U6PgY?=
 =?us-ascii?Q?dQQjvrsal2PEr8zUXmkpeJoHykpX0pa+66D8/gsyhO06oLwntkWTkxYuixrY?=
 =?us-ascii?Q?9SMFLkve6rqdx+BOT5v4QrxIyF+SYK00UXtO8pdeJqjMOqCQWWsbZZDMvvqU?=
 =?us-ascii?Q?cx8VLhk/dhuS4ZKzpUrIhifVdZyNRbVb2nqrEDmR7ZWdosavg7GGxlPX4eo8?=
 =?us-ascii?Q?pldD3pnuu0ra8hQ/bv/2n5UbKe9e2ifc1CrQVp+3iHw5A8X0khyoi/NTK7fl?=
 =?us-ascii?Q?vz8vf3A93VABSzeZabPXHZhw73e145ifPnrLX7bc7ZAm7XFszTPbI+gaSTDa?=
 =?us-ascii?Q?dJm87HgKGIgu9Rux3jbTqIfOyxtD68qafavs6+MmPbt8C+mb6pYZ7r5qU8fe?=
 =?us-ascii?Q?N9sjohuCEj79MzQgtKSXRPDFHpOjWfBW6cmcQnm1L0puobSC9a2jdYrM5kDs?=
 =?us-ascii?Q?ykqLSfZ53JhX9yKD+IqfjpbD6HSOp2bwRvva3szU1XjNEHBGfasvH+MpNRiN?=
 =?us-ascii?Q?JB3X3SJtZdP679/72EF1vzd13tpr7j2tu78Wt1KJjXbWJv5RQfT0uwvU/n7x?=
 =?us-ascii?Q?7fRqu+vV43b4iYfg7qj+OQ5/qY0YrhzEIBgin5TDzFvqqJ6YdUVJK44Ogprm?=
 =?us-ascii?Q?WNPGcvfyidPJmaJuX8xZx4E/7CMM7DsW3YDfbPIbhtlwebt/zQ+s6gnHSvyq?=
 =?us-ascii?Q?9GoAKOGbNUtqL/DgUbtY4KzyVAQMEM7JOu++6bjDzSc+JNiyngYvaR+9JSAx?=
 =?us-ascii?Q?gjRxsMZOMzWS5IoHEN3BCDxZ6jy/hdD5QtmnUJYCpILC4daIb+vJTsd+3G0N?=
 =?us-ascii?Q?gUq1WY7aqeVtTw5lCmwrDbLZeO2M7P9cQP6JvBql+nEtXhD2xZYm3o7Plgpq?=
 =?us-ascii?Q?REtRXMej4xmNXpgG1g8Ra10yIESwQu++aCDEJUXK7QDIKzCApGymNDKYrj++?=
 =?us-ascii?Q?Sp3wZTCcEoKQbKlyYZpiJtxpT7KYLALw3C03U/jrHqfAeTX/WxGu+F7Spk7G?=
 =?us-ascii?Q?yp5p7WpXElBFZQqSHPhhBMKPrIO5Ck5ciH9QQubaRFNAS5YqvZsm1dqaPzlj?=
 =?us-ascii?Q?ATUFGhvC5Ia7ioIgsdVoXw1eXMewBoI58eEQUdbXh63V0R8BIoQKnok1HkQe?=
 =?us-ascii?Q?SqxTPN+ITChS2Et0VxaCA0qERpCKSKYwmvzI9ENz3oYEFhPtg6Tue+2rIsBa?=
 =?us-ascii?Q?TbZBVP1Thlaur1P5NGH5UZZpij4z5ZFdQn1MRF/g4VcQWProRWqPs7duPZ/n?=
 =?us-ascii?Q?2N+EWoMCZU1VdZGV0toN3XQXid4aEqbGE6fQkfzb6FQCJCuWft3vvYhXsiXM?=
 =?us-ascii?Q?rMfDT33UbYxk9tuXaNnlZbMSr1hcLHqW9Oy9eDN8otwCkSDYtMkWSa91vPun?=
 =?us-ascii?Q?b0ZI/bsvSOLA20qXpHAPxrw5GigtCT+82qJ2Z4VtCilh4TLzhMIjzkU4xqWj?=
 =?us-ascii?Q?/UP1e/81JkFGEYtzC6s3+3i2/xb1T2tORy3AckZPsR3SplQwFu9XyaUpsQUg?=
 =?us-ascii?Q?TLR3WW3z+F1ry55qFv6Vcdc+HScNN0zVTowqZXpUrwyBYlfBjJjSLgMojA99?=
 =?us-ascii?Q?t5vweDnp6Dd29DUsseboU1yXIATESkuqU1svwgsrip2JmPTFegHMwHOIkoFw?=
 =?us-ascii?Q?SxmGVuvBLRYONHIVoq2NdAw=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2dac9786-8191-4829-caf9-08d9eaebff99
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2022 10:15:57.7681
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ays9u5rVHNKPS5VQIh4x1HsOrl8XqJM5dRo0Osc/8q3/bqKuAhFBEsp+zw/cmYb8Q8njxCMoA/crcPf30vdsrw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0402MB2746

On 08.02.2022 10:57, Oleksandr Andrushchenko wrote:
> On 08.02.22 11:48, Jan Beulich wrote:
>> On 08.02.2022 10:31, Oleksandr Andrushchenko wrote:
>>> On 08.02.22 11:25, Roger Pau Monn=C3=A9 wrote:
>>>> On Fri, Feb 04, 2022 at 08:34:52AM +0200, Oleksandr Andrushchenko wrot=
e:
>>>>> @@ -516,6 +594,11 @@ static int init_bars(struct pci_dev *pdev)
>>>>>            if ( (val & PCI_BASE_ADDRESS_SPACE) =3D=3D PCI_BASE_ADDRES=
S_SPACE_IO )
>>>>>            {
>>>>>                bars[i].type =3D VPCI_BAR_IO;
>>>>> +
>>>>> +            rc =3D bar_ignore_access(pdev, reg, &bars[i]);
>>>> This is wrong: you only want to ignore access to IO BARs for Arm, for
>>>> x86 we should keep the previous behavior. Even more if you go with
>>>> Jan's suggestions to make bar_ignore_access also applicable to dom0.
>>> How do we want this?
>>> #ifdef CONFIG_ARM?
>> Afaic better via a new, dedicated CONFIG_HAVE_* setting, which x86 selec=
ts
>> but Arm doesn't. Unless we have one already, of course ...
> Could you please be more specific on the name you see appropriate?

I'm pretty sure Linux has something similar, so I'd like to ask that
you go look there. I'm sorry to say this a little bluntly, but I'm
really in need of doing something beyond answering your mails (and
in part re-stating the same thing again and again).

> And do you realize that this is going to be a single user of such a
> setting?

Yes, but I'm not sure this is going to remain just a single use.
Furthermore every CONFIG_<arch> is problematic as soon as a new port
is being worked on. If we wanted to go with a CONFIG_<arch> here, imo
it ought to be CONFIG_X86, not CONFIG_ARM, as I/O ports are really an
x86-specific thing (which has propagated into other architectures in
more or less strange ways, but never as truly I/O ports).

Jan



From xen-devel-bounces@lists.xenproject.org Tue Feb 08 10:22:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 10:22:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267987.461753 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHNdv-0002BA-5G; Tue, 08 Feb 2022 10:22:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267987.461753; Tue, 08 Feb 2022 10:22:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHNdv-0002B3-1x; Tue, 08 Feb 2022 10:22:39 +0000
Received: by outflank-mailman (input) for mailman id 267987;
 Tue, 08 Feb 2022 10:22:37 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=v7zX=SX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nHNdt-0002Ax-Oj
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 10:22:37 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 091851cc-88c9-11ec-8eb8-a37418f5ba1a;
 Tue, 08 Feb 2022 11:22:36 +0100 (CET)
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2053.outbound.protection.outlook.com [104.47.8.53]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-9-N9f3hAklNLie3t0S6JToQA-2; Tue, 08 Feb 2022 11:22:35 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DBBPR04MB6236.eurprd04.prod.outlook.com (2603:10a6:10:c3::17) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Tue, 8 Feb
 2022 10:22:33 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.018; Tue, 8 Feb 2022
 10:22:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 091851cc-88c9-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644315756;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=9zMbSiFz8/dLVrBO6IvGWf/x28O2Ku99pcxAmJHLaMY=;
	b=DhCp9huhXlMWWkdLCS8FcWC+I5cj+52TEWQk3Y0CBEHpCs6tbJjydjXAOGlrv/VP8S0j3r
	h739NwS4kuZ1rTgNNk/CthG344AvJiDSDFCpN+Wc76u5pI652RxBTEtN4txtiwvoWVjmLo
	6shUOD42fySnt38xMKIshuxx5DqsGR0=
X-MC-Unique: N9f3hAklNLie3t0S6JToQA-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=oXevsg5vNEJP7l+HBhu0bUzSO1+IEx9Y/0d7X3KrI7gIF2YatvpEWYrK7I2sVDIL1VuWqJ51E2maRYTN2dEKdjQeclPT5tD6lYzev2dHubp8LFkl4u1u92NlPCPPbCoCwqC1F/U562dxtqrbCjTZGhM5rHEeEz9wQzH15ezy3PSsPkfS2ARIRxew50zvttGWPJk7qeel2VO+GDFZKU3Erq+jLK+1bQGKogkQlJulHrEqoj3PbsbmcU0nMiGFzeddKrFs9dRw8u//CjjfGSgrqLHWVmq6uP0RjGyKU5BhdyG+fjN1D+tlTLrPLMkYDTr07YJkhVQPacTfpYiOCMrtDQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=9zMbSiFz8/dLVrBO6IvGWf/x28O2Ku99pcxAmJHLaMY=;
 b=VM+YgIg29C3FmUCvl/UqaWA4fYSwwU9AFw/Uy9LNXYOEZC5GM4/v/n/powX7Noe9bEyw2ojsbFga9AqXAHct/H+SI4nQpVqPKjWDII8MD7Iz6Fz4kUH1EhhuMoz2TRIfXS9dxPtjOBTpKNWWrUpzEZR00a/8VW4HzIXJ8pCmrdUy/LAReC+GrqBCKk7cNcX51clOpg7tR179gRIxLoGQeW5yAKfFL0wLsuSDWp3ZlS6KVcA0+BCVf8AAJ99Dqay2l9bTxHFeqMypCE55DacOYuyI6b28szouXT5vmLEsG5wMv7r5Fg90XGekHJ8Y4ERHc3W4j0CVCs9yhtw7c801Mg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <dc405f74-9101-586c-9a2c-0fd0ef018f96@suse.com>
Date: Tue, 8 Feb 2022 11:22:31 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH RFC 1/3] xen/efi: Always query the console information and
 get GOP
Content-Language: en-US
To: Julien Grall <julien@xen.org>
Cc: ehem+xen@m5p.com, Julien Grall <jgrall@amazon.com>,
 xen-devel@lists.xenproject.org, Daniel Kiper <daniel.kiper@oracle.com>
References: <20220206192839.75711-1-julien@xen.org>
 <20220206192839.75711-2-julien@xen.org>
 <88741681-929f-4cda-e841-023bdbf8f772@suse.com>
 <26cdd9cf-15d6-a463-b1bb-28964005f618@xen.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <26cdd9cf-15d6-a463-b1bb-28964005f618@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR05CA0030.eurprd05.prod.outlook.com
 (2603:10a6:20b:488::24) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 08b18b7d-fbed-46c7-d1c6-08d9eaeceb9e
X-MS-TrafficTypeDiagnostic: DBBPR04MB6236:EE_
X-Microsoft-Antispam-PRVS:
	<DBBPR04MB6236BC2A6D411C99A2518EFBB32D9@DBBPR04MB6236.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3044;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	f53zSk0jqbmfpvCuOXNC0MRr6SMMBICF4n3pbojV0XRcXo/7fJBNHblrn408I3BnNYHUvAYjFUuBs3Y4TUPPPvFSgnqQMXj899Q3j7/r+vpkiOorcMkAjnb2LB4tnG3C0AMSIZ0jWzxlQQePZxpJVryE4UYQmRxFYl4W6zrFl0/dB7863REy+RT2Yk1gJ27gw1JixrKP/3/fnYIVUJc7Kod+K2o6XxxntFoNYchBYBvyyAu8HFAQ/7gcWNZAjEuqcacM6XP4jNQe4ss4UO15IxXQ3xEOkR8ifHaOih0wdDKNo3T5KtxAqaSprzbRGc8ngUv0lYi1wq0IDfcDHoolaY/+CSSNM21M60lo9x+zZqGNnz2hVYdZVSbRKxVaTykDHUVY/Vz9NpAfGfeJj0C2b2N86e0NrkVoIqOwDoPHJaR/FPt9ji4LnQnXlOBFN/KfHriJh9TqhgdL+3+pVmxge4o/52doCBy65Hwhpsa9wHy7vIBm9ymmGc42XkO0lVz/lsettpxnfMNx/xnzb3kD+f3R5iA76YqWVe/x2pDbF5G9sBDeUmAlAXZ+CZdh1HJftQpNSWDhEhZ1T5Ot+JXgVdVXZAKNvGkpVXHvltcQCZdNTOqrT3WE3sey5hK6aa4YAv02+xUoeRvUn25vTEzrTEcbQzK8Rse2hXkLtG6g70urgVGxSJLy+8m6NMXkVBnF8+id++pB9X3fT/ZYvaJVLFSrc9Ks68tZ55gTDR7pDck=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6486002)(31686004)(508600001)(66556008)(66476007)(316002)(31696002)(6916009)(86362001)(2616005)(6506007)(38100700002)(5660300002)(6512007)(53546011)(4326008)(54906003)(2906002)(26005)(186003)(8676002)(36756003)(8936002)(66946007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?eW85bk8yWDBQKzZTN0FEYm1ZdnpYZm1uejdUdUhETlBjS0xsQVVzUUQvcU5z?=
 =?utf-8?B?NEFJRGlKQmt6Z0NmYXBQS0pCbEhCQUtyWCtIYStEOXJEY080M3JYdVEwQTk0?=
 =?utf-8?B?TUlHZWJHWnBkNDFwbmZ4MUNwYnk0SUljWXQxYytzREVQNFkwaDB5K2ptUVhU?=
 =?utf-8?B?dTdSNmkzSytHaTY5SVYzcnZQVEVaYUtlaUJvOVI1dnhMTHNpVTJjYU1kSDdP?=
 =?utf-8?B?dGR6OHFjVElPNjc2bkhNZGd1L1lOSnBUZzY5c05YZElseitJcWZ4dmRvTlFz?=
 =?utf-8?B?RnFUNDBubkhZVU45b2RXSVdFYTUybzRnb0NsK21wM2krQlJ0ajVCd2tkWHl3?=
 =?utf-8?B?cndYcWpCVGVKNW43VVBRc3RBMWU4N0hBSk1TbU1KQ0s3R3l0cENiRDhsWmRi?=
 =?utf-8?B?WHk5VGd4U0lDV0dpVGduZVpDeDhVTldwRjd2dDFxRUwxK0xJNXBjcjY1OEx1?=
 =?utf-8?B?UDloWUd3THFKTTdMK2xvRmQ0aExkS0kreHpCUmUrRndMVHBmbk9UZGdBN3dx?=
 =?utf-8?B?aFlTbERWRGJBbzFMMVFHTkx6M3FJbm1iTnZVWktaWFNpaFlRY1UwR3ArclFt?=
 =?utf-8?B?VFhjTCtZNmR6aHJnRkRhZGZyMlRGZElPMDRDeW9PUWE0WHhFcmQ5ZFFlcUxL?=
 =?utf-8?B?eHJJcDhvNk1RY0xTMFNuUEpJd1liUjIrK0wxdk9DK1ZjRjlDZUFOWWsraXlJ?=
 =?utf-8?B?OXhYSWduR1lDZ0s3eXhZc0hpSlZ5Rk5VcFZqZE9Mb1p1ZDhpRng2WkRIa1Rs?=
 =?utf-8?B?K2Y0SUVCRlhkNnNsK0JkUFFPSS9RNXlQZjY3b2t5WDI4R3ZhM2p0aS91ZSs3?=
 =?utf-8?B?YUdNLzlKdm5CMm9adlBOK05pdmdrZ2FFQjBaWHBzb0d5aElyRWk2alMwTGVo?=
 =?utf-8?B?M0JVakVEOWlWLytnT1kwVHBQSHVEUXNobll0RzFrcDFUNWhJeXlWUjZJckM3?=
 =?utf-8?B?ZHNPYzE0SDJ5a2F2a1hyMXY5RkU5ejJrOWFDNWFmWkVTSzZySkhkVlVtclZH?=
 =?utf-8?B?dUhzTUIvZEFZd2c3Mi8wQTJKVG1NOXcraGFjZGtMdm9XcC9PMm51QnhVTkpS?=
 =?utf-8?B?enB4SER2VkxIUWlGWUJtVVp6WUcvTzI4Nm1MSk9vazRSemcxTWRnRG9mZXNK?=
 =?utf-8?B?NG1yZGdicUE4dVgyR2RFdmhrNWdGcU1qbVNFczlIak5vZ0Rsc3lpV3hydEtR?=
 =?utf-8?B?OVcyTTE5aUZYTzRkbGsrSy83ZjluSEo0aUgxRVNBZmtIcEs1M2VhK0JYQk9u?=
 =?utf-8?B?ZTJSTkM4THJ6M0NKendRSk82WDNXcVVyeGVBVzMxOTN5dkVqdWNKa0VPZkpo?=
 =?utf-8?B?TVJ4eUdPRWV5OGZuMkNkZkdrVFpsOUVNVWJKQkM1UlI0YjNHNk9leklITGV5?=
 =?utf-8?B?dXlmcHI0MmtIdVMzMmUwTm51U2tTaFNDeUE5dS9xbGRYWk93S0lLcTFPb3JD?=
 =?utf-8?B?cFdoRWZYTkhjTjBFRlFqTWtZV1hzRlExWUFyZ2pKRXdjWFNIQUdQNmxyVTI3?=
 =?utf-8?B?UnhLQzBaakc3am1EM1laN0o3SGxpVEE4WkE2RktqT1c2YVM4Q0Vlb28yaGc1?=
 =?utf-8?B?bU9mQndsRnBlY0VsN0lNaHg0QUVtWTFxUzBLR2FLYlUxQUlOdFhxcTRWbFJ0?=
 =?utf-8?B?ZFNhRU9hZTI3eWRLTVppV2U2ZkhpekYrZG56R20wbUZ6YjAybGZXUWJmV2FM?=
 =?utf-8?B?Q1FnbE9tc211V2NiektMNHgyU0VXOWFyUVk2WnVkY3dZVCtXdmpzbmpPZ3FY?=
 =?utf-8?B?N25PRk13aDA2UVE3cVF3M01JSlVGMEJQd01IK3gvSmI5Vy9FUEt4Z1NMd2Vw?=
 =?utf-8?B?UkUxUmJucWZkUGRVTWNWMm1Ob3Z1TnhJUmsvYStwYWtTUVYwanBlaXJkZXM0?=
 =?utf-8?B?c1N2VHREV01tRnlLdGVsY1dCQi9BeWpMallkTnduenNtNXNRdXhTMmQvcUFF?=
 =?utf-8?B?THlybzF1dWtVMDZWTVlHVGVtUmI1ZFVCTVhZR09xQktNZGlJeEFobGVsYmxp?=
 =?utf-8?B?YVNlcTlCUkZBQ1pUTmJ3NVBOenhNOXFPRlp4OGRvWXhZbHlwYyt0K0J6dE16?=
 =?utf-8?B?U0h1Mk5ZZzFVT1pIY082eDV3OEY3ZmhOSG1jbWZwRGdqYjBEYWRpMGg3dE1W?=
 =?utf-8?B?MDF1dHhuOUoyc2d2TmVpcWxDZms3VDkzSEpveFdOOUJhWlJKZHAwUno3MzYr?=
 =?utf-8?Q?1dPdy5LPOswh2+Z+3KVZoJg=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 08b18b7d-fbed-46c7-d1c6-08d9eaeceb9e
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2022 10:22:33.7277
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LO1OSrCbpEpcW7w0nojfbfdzhexhE1QN/djG8A0tOFUgNEb5xK+WMBtdp/wJrHKG4SNh0BluONoC5T0cA/IBaw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB6236

On 07.02.2022 19:52, Julien Grall wrote:
> On 07/02/2022 08:46, Jan Beulich wrote:
>> On 06.02.2022 20:28, Julien Grall wrote:
>>> It is not entirely clear to me why the GOP was only fetched when
>>> the configuration file is used.
>>>
>>> I have tested this on RPI4 and it seems to work. Any chance this
>>> was done to workaround an x86 platform?
>>
>> This was done so in the context of making the code work for Arm. See
>> commit c38cf865ec82 ("EFI: ignore EFI commandline, skip console setup
>> when booted from GRUB"), the description of which explicitly says
>>
>> "Don't do EFI console or video configuration when booted by GRUB.  The EFI boot
>>   code does some console and video initialization to support native EFI boot from
>>   the EFI boot manager or EFI shell.  This initlization should not be done when
>>   booted using GRUB."
> 
> I read that and still couldn't figure out why this was done like that.
> 
>>
>> What you say now is effectively the opposite (and unlike back then
>> x86 is now able to use this code path as well, so needs considering
>> too). Cc-ing Daniel for possibly having a GrUB-side opinion.
> 
> I am quite interested to know the answer. Linux is able to use the EFI 
> framebuffer when booting via GRUB. So I am a bit puzzled why we are 
> preventing this setup on dom0/Xen.

To be honest - same here.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Feb 08 10:22:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 10:22:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.267989.461763 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHNeD-0002dW-HL; Tue, 08 Feb 2022 10:22:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 267989.461763; Tue, 08 Feb 2022 10:22:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHNeD-0002dP-Dt; Tue, 08 Feb 2022 10:22:57 +0000
Received: by outflank-mailman (input) for mailman id 267989;
 Tue, 08 Feb 2022 10:22:55 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1FiY=SX=epam.com=prvs=40383cc40e=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nHNeB-0002Ax-GF
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 10:22:55 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 129dea65-88c9-11ec-8eb8-a37418f5ba1a;
 Tue, 08 Feb 2022 11:22:53 +0100 (CET)
Received: from pps.filterd (m0174676.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 2189rjf0002986;
 Tue, 8 Feb 2022 10:22:49 GMT
Received: from eur01-ve1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2058.outbound.protection.outlook.com [104.47.1.58])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e3p9gr461-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Tue, 08 Feb 2022 10:22:49 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by DB8PR03MB5484.eurprd03.prod.outlook.com (2603:10a6:10:106::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Tue, 8 Feb
 2022 10:22:45 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77%3]) with mapi id 15.20.4951.019; Tue, 8 Feb 2022
 10:22:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 129dea65-88c9-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=FaY6jq5GO9igg0SYniZ6O3K8MEMaz9O656QFbLc0//jNz7wkSkO7Gi7kVzDRMBURx+QE6lXyLvE9QPFdcmgpxqYFhRiBswR4Orc/TrN66nO2ybXmErjFKWpZ6dBDI1TFHtexAzO//4P11ah8SGdCeZAz4kUBk4dLgezc3mvjttlbZXMVyjvyhK+ZYlRRap4urJaA5PiFbSYeJfg16pePfQEmhGT0ju7e25bUrdHz2Ozr2ZizLIVAyztRTRDuH1kCDNGXZCmLXWUI8jpNfkNt2TS43iiv1g5VI/cy5us4Oz2l+uzNTkVNob6hZsplHSxgPcRcs21M2NOtVcAnwSqfZA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=pJUyAo0jW1J0+ga7HlrzqC5OcvxEppGSq93D+3FRDqQ=;
 b=a6MPm1gu/DPV1/HJsOiLUg6edjBvdEE4QsgeMpyVCM2rC+OBbkD8TuZuq206f93Wu0OHUgsyYIhncXeq9rOvEJYr8BynWQFn4U+bci+q9PjLcdZv1dzF+9/rIYUaOWaj3QnMO7kfCgEPdqMQ4Sw8OLxtWZJqOkR4EYw+oaEbjyj1G7mFp14mPqy9JtLm20TnJZvlDofYHtXYJMjRIfnwgpcQb8ZCJAYDG1bJ+FwmL9U5F4x8KfW1UFIkV8aAyv/i/bWduVEpDVtez29nQ2Wg/PEaFntvL3KJ2fo2QtwCPzv7t94pdw7gwKfBOg5SCdIJrUatCVelC7Nur3wbICUpWg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=pJUyAo0jW1J0+ga7HlrzqC5OcvxEppGSq93D+3FRDqQ=;
 b=i7M7hAeRd6EQ7Lhgvc+Yu/q2O+xIodLE6Z3Ai6ALgGoJLidaAKyVDXVivrLiGIkyFCYzNCdyzjl3gbesoGxCmfJdRIACBq6Fl8rGrNq0GIrtsrWo8VtenKKYGo6eA24FVg5yQCMJOaP4t754jK4qEzEnr9bNYxcL8Xs21urDIs+bM4ragNEL5rooO4IfHyzGjUMzmtb5OJwQ5HosN0dr5/RTH0uTPMW/xbTb+NwL5HW3qsXn+XNz6opZ6uBeUnvR4NqEwOexxcryJSb3m8eTIj1/eKyr0crJgtN9+fKMYmTDFKuQZnM0TgqqvFCZxe4wNNhHhKgmR4YqtjK7Ohjs5A==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        "roger.pau@citrix.com"
	<roger.pau@citrix.com>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v6 05/13] vpci: add hooks for PCI device assign/de-assign
Thread-Topic: [PATCH v6 05/13] vpci: add hooks for PCI device assign/de-assign
Thread-Index: 
 AQHYGZFdYv4W1RdbQkeQtzN+PyKqmqyITGQAgAENNICAAAt2AIAAA+uAgAAEsACAAAMyAIAABAgAgAADmAA=
Date: Tue, 8 Feb 2022 10:22:45 +0000
Message-ID: <20762939-6b7e-ff60-7c1a-d47c4767ff4f@epam.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-6-andr2000@gmail.com>
 <16cea1df-3d0f-d404-2b88-aab47ad5548b@suse.com>
 <3fe6dbe3-51c6-f87f-23f9-cf2e1a924326@epam.com>
 <582ee8f9-7b01-4adc-6a8a-ce8b1dffd534@suse.com>
 <e225553b-b29c-0448-fb9f-f8b513d9f77d@epam.com>
 <0fd8a0ac-dc91-287e-536e-1684892837ab@suse.com>
 <9f58a8ff-44b4-3249-5858-9988644b2d4e@epam.com>
 <15c16171-f196-38d2-370c-38627935a21b@suse.com>
In-Reply-To: <15c16171-f196-38d2-370c-38627935a21b@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: c968c3c8-3ce8-44b6-1cc5-08d9eaecf288
x-ms-traffictypediagnostic: DB8PR03MB5484:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <DB8PR03MB5484AA90F45B788596A44AB0E72D9@DB8PR03MB5484.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 xwgF3Mr2fq5ZXWBUahrGRm3sQKIUwWuRU7o+8gpVOL6+VT4OxPS5jFFzBjjAwhitNT5BLPbSXf7DQFDVt+LKATcEp3kmHcQB7EG2G5wCIB6S9ikCalhG1jf17J/J9AM24KEPuIrPkyHme/WR496ZOZGz1t8sEYehuMV6MNnZdLQj2Bb/3YIlj89iQJ0Bny6Omx6pdKjVSjJ2uX7qIaiuTmlawZTWYHLCF3uslVbk9VxvbAQf/ZlMV/ZB/8HOfocP9XxrPnINtEWiJZZatHcUIyWo0WxKEG2gzr+BmfZwiCUCLf+ZozEIuKm7f/Ld4rhOTt8U0tPN2aLpIYYxrd6mCCXU+By0cXeqW9eMi6fw5k3GD4IrU5NL/4b3f3O2x5P0m1qfB5Itu8X06Px6gl9u8dn1H+Na9qSTlhG1Rd6xtkHXvzY3HBdVddTBt3sSr8WSOzToHCKBH6auk1UX4iZwbg3aK6BGVXR27G5Fbpf1+s8R7TduOT7pplPdfkcVbqTiK4ORmg8JUos31yQeqJmm7mForEUypQ7CGDqRXTJb2FYtXCp8wZjzQEGsNl41heqkXF0xZ7v2Kod5GE67MBQsaTk5Gu1Q18mKMIok1xwj4vNJuLj7yltr73yTrK3KCBLPTeDvD2KAeYyaHDf3hvN/FnxL27RNEzYntbeHOnYL/3V8gtQrJj60BtzVDOQmAiG02kaf6mcqN8it7uCsq0sd2cTBQ/GywHVI+SE4cnSD6v84N/SUyJZpT1S/Qc1frjXW
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(64756008)(36756003)(55236004)(53546011)(107886003)(6916009)(8676002)(6512007)(83380400001)(31686004)(76116006)(66946007)(91956017)(8936002)(2616005)(66446008)(508600001)(38100700002)(26005)(186003)(66556008)(71200400001)(6506007)(54906003)(66476007)(316002)(7416002)(2906002)(38070700005)(5660300002)(31696002)(122000001)(4326008)(86362001)(6486002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?bjZzdG9kdWlFZmNrZnFwdUZWQ04xdWhOK3puaXJaUDhWSjJaS2VWbVRLaDZu?=
 =?utf-8?B?SDcvV3Ivb25hbDNkRTBRM0FsTjZOK29PM1FZODZJd01ObWpMTXg0L2tCZFZq?=
 =?utf-8?B?TXFXQWptTittRFplNmV2K0tiNzNxWi9jRmd5c0FxRWdiL2hPcE1ucHkrK3JQ?=
 =?utf-8?B?TC95NVFLcjRTUkpXZkYyRkk5UWxCa3ZRU21SQTd6WGFmdmpqR2pGZ3lJUzhi?=
 =?utf-8?B?Y3hYZ3NCcERrK0ErS1RQWEw1Z2grbSswa2RvNkRqQ0xvNHd0dkMyTC83S3Nx?=
 =?utf-8?B?RE1GSCtOYnFHdUg4ZnEwb2cwb0RkMXZ3b0YvUm5SNFh4djgwb1FsLzNhUVJD?=
 =?utf-8?B?Q0hkVk1HVmVOZGd6SDc2SHRoeXd4VlRWa0lPbmgwYWx3SnR1alk0STJNQUda?=
 =?utf-8?B?UG8vUTdkMWVHNm03NzRzRVhOWkVZS0hHakNoR3Flak5XL2pNZXA4RmpWQ1VD?=
 =?utf-8?B?WCsxcDc1UEY1UUJkT0s2b004T1VUekovNzZzREFUZUM1MDRMdllqaDgwVVhu?=
 =?utf-8?B?YytXZllGajd5RnRuVDhDSW5zN2w3TEtEU1J2YktWV00wVktUNUQvVURCNzV3?=
 =?utf-8?B?YWlwOUQyeDJzRCtDZjNxNGNUakFqMHhLbXVlRGVkRS9FV1QrZjdHRHhYZ0xE?=
 =?utf-8?B?ejFmbjIycHcyeUJnQlNLZk5lNkp6dlQ1YmdaVlE2elBHTEdHNksrWFliYTFE?=
 =?utf-8?B?cnoxcERuU2FaOHYrZ1ZsSjRWZkpUZmE5VGtTV3RLaDMySnV2Rmt4WUJBeWFk?=
 =?utf-8?B?c1N6RXJrUDZYK3IwVmU1eUc5K1B2NmNiYnRIUzM5M3pMWG84NEhBNXhnNU1V?=
 =?utf-8?B?SzNYeE1UdjkvZFhLTXdNamlSSVU5VHA5bWVxSjZxTzVvaVBKU2hZcC9oanUz?=
 =?utf-8?B?M2E0R0hZcE1xaDJLdWd3TFg4ZnhJdi9EdGVNWlB2dXdsWUFQSURRbGVvNHhp?=
 =?utf-8?B?c0IrTE9UOVJ4Q3E4SGxTbjdHUzNpRFh6Y0JhNFBGWDE3d3ZjQU10SUxBbUlU?=
 =?utf-8?B?M0YvM24xTWY5d2RNNkZRRGxIbG8rUnArUzIrODFyU2dmZ3VqTDJDNG5aK004?=
 =?utf-8?B?RlN6cXVsaElXR0tFcHlDRmhrWkFqclVEVUZubVBYZ2sydG1MZExRQTdHSlFM?=
 =?utf-8?B?eU5TbXQxb2NLMFdLN0xWQnZFZW5WaFF6OWdzMkJLMndFbmlSeEJoMzJJbC9x?=
 =?utf-8?B?Zi9TOFZsNklMRGF3VFFiZU9qSFF1dEpndktwelZxNkZwL1NTUzV3REF1TkNy?=
 =?utf-8?B?VnBuYS9DTk03T2JYTDR4ZURGekhwK2haZVJ4eC9HS3RiUEVVK1Q2NWlOQVdo?=
 =?utf-8?B?RmVlMWlieTE5MkdkcmpyUGE3eHVYK3RWeVRwdWUyUm12cmVuRzF0bFBuVGtX?=
 =?utf-8?B?RXBsZFd5UHNHVlpyRVBOdzJjeXRLMEJlSVY2UGxNRlR4U09mSmkxSGdWUnMv?=
 =?utf-8?B?ZzQ1dFFhdkxIcXVkYitQTmdnWC9CV0thQXdDMitCSzVQcDRWVGkxRUx2SEJM?=
 =?utf-8?B?SGpHUUt0TkNoNmdTTXR2RjhQc081WEY0UVpDcE9UdDNsNmNkVmEwaHpqRWQz?=
 =?utf-8?B?aWtCMng2OWJoK1lRRE9aT3Zpc1ZFU3ZZTEsydkYvS0tocysxNmNwbURwcDBl?=
 =?utf-8?B?QXJuRFY0TzZxbGhIdEwzcWc0Z0QwaWRBQzIrcmI3VDJNR0UxRmpyUHMwNldJ?=
 =?utf-8?B?eW1zM3U4NkhiYmFCNThPUm9hQmh1MlZiWkxVME5iZ2tJbWpRS3JQa2F6OEF0?=
 =?utf-8?B?di9sYnNtYlQ5clJwOVQzdnMzb1l4dEN6V3FwVVJhZDgxclFWWnNuS29KNUpI?=
 =?utf-8?B?RDg1REF3bHhaZEdHLzA4R2JSN05FOSt0QXEzbHRRM3BCSU53b3o3ZEVkR2JW?=
 =?utf-8?B?N3E1NmRVQUNENXZOUVo1MHBLVmNJK0kydWpFYjV6WUZuSXRwZk12RkRzOUZO?=
 =?utf-8?B?M0pQdGNyNlFWN3F6UklNckUvdWNoVG0yZm1jdFdsa0luL0tRTHRKY0s4M01Q?=
 =?utf-8?B?R0E3SjFCb21LVnN6WGMraGUvdlJDVC9UVW1rbDhmdnY3WGRYeXJSSzZKN1B6?=
 =?utf-8?B?Zk1VL0JSTjVGSjFiZGV1SWkzcWVFTVBNaGd4TVAxZ1FrUURVMkZRakJTZnly?=
 =?utf-8?B?S3p5Q042aS9WYmxaRkJScktNaFJVR056K1gwWDBybjl6aS9BbVNJNS9SRHF4?=
 =?utf-8?B?SG9zMzYvaElURGVLOWVZOGszOXFsS3UxcndxOGNDcnppMVpWcktiamNVbHh3?=
 =?utf-8?B?NlMvck9YWnhyMi9KT1BQYTRCMEFJUFNjV3BBVDVoL0E3WEEwMDRMK1EwWDdT?=
 =?utf-8?B?dzBaZjJXRHNCWmRKOXhEMXZCTkE0SWpJUGtzdzJzcncxSGNlZjJnVU4yYVBz?=
 =?utf-8?Q?tt46j8Ho8B2Bgc38=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <FEB54DA837D43C4FBCA255A03BB9AEB9@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c968c3c8-3ce8-44b6-1cc5-08d9eaecf288
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2022 10:22:45.0574
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: vynGlPcljLTwr91Mee7qk9iOyRav+QcahtoU5RouxTRID/3hvngEEtqALOt6sNxOTEqnSoYwagAvij9s0hk92Jd1pa524nq5ANlzrz2wmrBjMkQDN3q9H5KahZQ1tZMT
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR03MB5484
X-Proofpoint-ORIG-GUID: 6Card1H_3_3w6X21X8_j6bcwcUqXvOPZ
X-Proofpoint-GUID: 6Card1H_3_3w6X21X8_j6bcwcUqXvOPZ
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-08_02,2022-02-07_02,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0
 lowpriorityscore=0 phishscore=0 adultscore=0 priorityscore=1501
 suspectscore=0 malwarescore=0 mlxlogscore=999 spamscore=0 clxscore=1015
 impostorscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202080059

DQoNCk9uIDA4LjAyLjIyIDEyOjA5LCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMDguMDIuMjAy
MiAxMDo1NSwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+Pg0KPj4gT24gMDguMDIu
MjIgMTE6NDQsIEphbiBCZXVsaWNoIHdyb3RlOg0KPj4+IE9uIDA4LjAyLjIwMjIgMTA6MjcsIE9s
ZWtzYW5kciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4+PiBPbiAwOC4wMi4yMiAxMToxMywgSmFu
IEJldWxpY2ggd3JvdGU6DQo+Pj4+PiBPbiAwOC4wMi4yMDIyIDA5OjMyLCBPbGVrc2FuZHIgQW5k
cnVzaGNoZW5rbyB3cm90ZToNCj4+Pj4+PiBPbiAwNy4wMi4yMiAxODoyOCwgSmFuIEJldWxpY2gg
d3JvdGU6DQo+Pj4+Pj4+IE9uIDA0LjAyLjIwMjIgMDc6MzQsIE9sZWtzYW5kciBBbmRydXNoY2hl
bmtvIHdyb3RlOg0KPj4+Pj4+Pj4gQEAgLTE1MDcsNiArMTUxMSw4IEBAIHN0YXRpYyBpbnQgYXNz
aWduX2RldmljZShzdHJ1Y3QgZG9tYWluICpkLCB1MTYgc2VnLCB1OCBidXMsIHU4IGRldmZuLCB1
MzIgZmxhZykNCj4+Pj4+Pj4+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcGNpX3RvX2Rl
dihwZGV2KSwgZmxhZyk7DQo+Pj4+Pj4+PiAgICAgICAgICB9DQo+Pj4+Pj4+PiAgICAgIA0KPj4+
Pj4+Pj4gKyAgICByYyA9IHZwY2lfYXNzaWduX2RldmljZShkLCBwZGV2KTsNCj4+Pj4+Pj4+ICsN
Cj4+Pj4+Pj4+ICAgICAgIGRvbmU6DQo+Pj4+Pj4+PiAgICAgICAgICBpZiAoIHJjICkNCj4+Pj4+
Pj4+ICAgICAgICAgICAgICBwcmludGsoWEVOTE9HX0dfV0FSTklORyAiJXBkOiBhc3NpZ24gKCVw
cCkgZmFpbGVkICglZClcbiIsDQo+Pj4+Pj4+IFRoZXJlJ3Mgbm8gYXR0ZW1wdCB0byB1bmRvIGFu
eXRoaW5nIGluIHRoZSBjYXNlIG9mIGdldHRpbmcgYmFjayBhbg0KPj4+Pj4+PiBlcnJvci4gSVNU
UiB0aGlzIGJlaW5nIGRlZW1lZCBva2F5IG9uIHRoZSBiYXNpcyB0aGF0IHRoZSB0b29sIHN0YWNr
DQo+Pj4+Pj4+IHdvdWxkIHRoZW4gdGFrZSB3aGF0ZXZlciBhY3Rpb24sIGJ1dCB3aGF0ZXZlciBp
dCBpcyB0aGF0IGlzIHN1cHBvc2VkDQo+Pj4+Pj4+IHRvIGRlYWwgd2l0aCBlcnJvcnMgaGVyZSB3
YW50cyBzcGVsbGluZyBvdXQgaW4gdGhlIGRlc2NyaXB0aW9uLg0KPj4+Pj4+IFdoeT8gSSBkb24n
dCBjaGFuZ2UgdGhlIHByZXZpb3VzbHkgZXhwZWN0ZWQgZGVjaXNpb24gYW5kIGltcGxlbWVudGF0
aW9uDQo+Pj4+Pj4gb2YgdGhlIGFzc2lnbl9kZXZpY2UgZnVuY3Rpb246IEkgdXNlIGVycm9yIHBh
dGhzIGFzIHRoZXkgd2VyZSB1c2VkIGJlZm9yZQ0KPj4+Pj4+IGZvciB0aGUgZXhpc3RpbmcgY29k
ZS4gU28sIEkgc2VlIG5vIGNsZWFyIHJlYXNvbiB0byBzdHJlc3MgdGhhdCB0aGUgZXhpc3RpbmcN
Cj4+Pj4+PiBhbmQgbmV3IGNvZGUgcmVsaWVzIG9uIHRoZSB0b29sc3RhY2sNCj4+Pj4+IFNheWlu
ZyBoYWxmIGEgc2VudGVuY2Ugb24gdGhpcyBpcyBoZWxwaW5nIHJldmlldy4NCj4+Pj4gT2sNCj4+
Pj4+Pj4gV2hhdCdzIGltcG9ydGFudCBpcyB0aGF0IG5vIGNhbGxlciB1cCB0aGUgY2FsbCB0cmVl
IG1heSBiZSBsZWZ0IHdpdGgNCj4+Pj4+Pj4gdGhlIGltcHJlc3Npb24gdGhhdCB0aGUgZGV2aWNl
IGlzIHN0aWxsIG93bmVkIGJ5IHRoZSBvcmlnaW5hbA0KPj4+Pj4+PiBkb21haW4uIFdpdGggaG93
IHlvdSBoYXZlIGl0LCB0aGUgZGV2aWNlIGlzIGdvaW5nIHRvIGJlIG93bmVkIGJ5IHRoZQ0KPj4+
Pj4+PiBuZXcgZG9tYWluLCBidXQgbm90IHJlYWxseSB1c2FibGUuDQo+Pj4+Pj4gVGhpcyBpcyBu
b3QgdHJ1ZTogdnBjaV9hc3NpZ25fZGV2aWNlIHdpbGwgY2FsbCB2cGNpX2RlYXNzaWduX2Rldmlj
ZQ0KPj4+Pj4+IGludGVybmFsbHkgaWYgaXQgZmFpbHMuIFNvLCB0aGUgZGV2aWNlIHdvbid0IGJl
IGFzc2lnbmVkIGluIHRoaXMgY2FzZQ0KPj4+Pj4gTm8uIFRoZSBkZXZpY2UgaXMgYXNzaWduZWQg
dG8gd2hhdGV2ZXIgcGRldi0+ZG9tYWluIGhvbGRzLiBDYWxsaW5nDQo+Pj4+PiB2cGNpX2RlYXNz
aWduX2RldmljZSgpIHRoZXJlIG1lcmVseSBtYWtlcyBzdXJlIHRoYXQgdGhlIGRldmljZSB3aWxs
DQo+Pj4+PiBoYXZlIF9ub18gdlBDSSBkYXRhIGFuZCBob29rcyBpbiBwbGFjZSwgcmF0aGVyIHRo
YW4gc29tZXRoaW5nDQo+Pj4+PiBwYXJ0aWFsLg0KPj4+PiBTbywgdGhpcyBwYXRjaCBpcyBvbmx5
IGRlYWxpbmcgd2l0aCB2cGNpIGFzc2lnbi9kZS1hc3NpZ24NCj4+Pj4gQW5kIGl0IHJvbGxzIGJh
Y2sgd2hhdCBpdCBkaWQgaW4gY2FzZSBvZiBhIGZhaWx1cmUNCj4+Pj4gSXQgYWxzbyByZXR1cm5z
IHJjIGluIGFzc2lnbl9kZXZpY2UgdG8gc2lnbmFsIGl0IGhhcyBmYWlsZWQNCj4+Pj4gV2hhdCBl
bHNlIGlzIGV4cGVjdGVkIGZyb20gdGhpcyBwYXRjaD8/DQo+Pj4gVW50aWwgbm93IGlmIGFzc2ln
bl9kZXZpY2UoKSByZXR1cm5zIGFuIGVycm9yLCB0aGlzIHRlbGxzIHRoZSBjYWxsZXINCj4+PiB0
aGF0IHRoZSBkZXZpY2UgZGlkIG5vdCBjaGFuZ2Ugb3duZXJzaGlwOw0KPj4gTm90IHN1cmUgdGhp
cyBpcyB0aGUgY2FzZToNCj4+ICAgwqDCoMKgIGlmICggKHJjID0gaW9tbXVfY2FsbChoZC0+cGxh
dGZvcm1fb3BzLCBhc3NpZ25fZGV2aWNlLCBkLCBkZXZmbiwNCj4+ICAgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcGNpX3RvX2RldihwZGV2KSwgZmxh
ZykpICkNCj4+IGlvbW11X2NhbGwgY2FuIGxlYXZlIHRoZSBuZXcgb3duZXJzaGlwIGV2ZW4gbm93
IHdpdGhvdXQNCj4+IHZwY2lfYXNzaWduX2RldmljZS4NCj4gRGlkIHlvdSBjaGVjayB0aGUgYWN0
dWFsIGhvb2sgZnVuY3Rpb25zIGZvciB3aGVuIGV4YWN0bHkgdGhlIG93bmVyc2hpcA0KPiBjaGFu
Z2UgaGFwcGVucy4gRm9yIGJvdGggVlQtZCBhbmQgQU1EIGl0IGlzIHRoZSBsYXN0IHRoaW5nIHRo
ZXkgZG8sDQo+IHdoZW4gbm8gZXJyb3IgY2FuIG9jY3VyIGFueW1vcmUuDQpUaGlzIGZ1bmN0aW9u
YWxpdHkgZG9lcyBub3QgZXhpc3QgZm9yIEFybSB5ZXQsIHNvIHRoaXMgaXMgdXAgdG8gdGhlDQpm
dXR1cmUgc2VyaWVzIHRvIGFkZCB0aGF0Lg0KDQpXUlQgdG8gdGhlIGV4aXN0aW5nIGNvZGU6DQoN
CnN0YXRpYyBpbnQgYW1kX2lvbW11X2Fzc2lnbl9kZXZpY2Uoc3RydWN0IGRvbWFpbiAqZCwgdTgg
ZGV2Zm4sDQogwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqAgc3RydWN0IHBjaV9kZXYgKnBkZXYsDQogwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAg
dTMyIGZsYWcpDQp7DQogwqDCoMKgIGlmICggIXJjICkNCiDCoMKgwqDCoMKgwqDCoCByYyA9IHJl
YXNzaWduX2RldmljZShwZGV2LT5kb21haW4sIGQsIGRldmZuLCBwZGV2KTsgPDw8PDwgdGhpcyB3
aWxsIHNldCBwZGV2LT5kb21haW4NCg0KIMKgwqDCoCBpZiAoIHJjICYmICFpc19oYXJkd2FyZV9k
b21haW4oZCkgKQ0KIMKgwqDCoCB7DQogwqDCoMKgwqDCoMKgwqAgaW50IHJldCA9IGFtZF9pb21t
dV9yZXNlcnZlX2RvbWFpbl91bml0eV91bm1hcCgNCiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqAgZCwgaXZyc19tYXBwaW5nc1tyZXFfaWRdLnVuaXR5X21hcCk7DQoN
CiDCoMKgwqDCoMKgwqDCoCBpZiAoIHJldCApDQogwqDCoMKgwqDCoMKgwqAgew0KIMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqAgcHJpbnRrKFhFTkxPR19FUlIgIkFNRC1WaTogIg0KIMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAidW5pdHktdW5tYXAgZm9yICVwZC8lMDR4OiUwMng6
JTAyeC4ldSBmYWlsZWQgKCVkKVxuIiwNCiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqAgZCwgcGRldi0+c2VnLCBwZGV2LT5idXMsDQogwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgIFBDSV9TTE9UKGRldmZuKSwgUENJX0ZVTkMoZGV2Zm4pLCByZXQpOw0KIMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqAgZG9tYWluX2NyYXNoKGQpOw0KIMKgwqDCoMKgwqDCoMKgIH0N
ClNvLi4uLg0KDQpUaGlzIGlzIElNTyB3cm9uZyBpbiB0aGUgZmlyc3QgcGxhY2UgdG8gbGV0IElP
TU1VIGNvZGUgYXNzaWduIHBkZXYtPmRvbWFpbi4NClRoaXMgaXMgc29tZXRoaW5nIHRoYXQgbmVl
ZHMgdG8gYmUgZG9uZSBieSB0aGUgUENJIGNvZGUgaXRzZWxmIGFuZA0Kbm90IHJlbHlpbmcgb24g
ZWFjaCBJT01NVSBjYWxsYmFjayBpbXBsZW1lbnRhdGlvbg0KPg0KPiAgIE15IHVuZGVyc3RhbmRp
bmcgaXMgdGhhdCB0aGUgcm9sbC1iYWNrIGlzDQo+PiBleHBlY3RlZCB0byBiZSBwZXJmb3JtZWQg
YnkgdGhlIHRvb2xzdGFjayBhbmQgdnBjaV9hc3NpZ25fZGV2aWNlDQo+PiBkb2Vzbid0IHByZXZl
bnQgdGhhdCBieSByZXR1cm5pbmcgcmMuIEV2ZW4gbW9yZSwgYmVmb3JlIHdlIGRpc2N1c3NlZA0K
Pj4gdGhhdCBpdCB3b3VsZCBiZSBnb29kIGZvciB2cGNpX2Fzc2lnbl9kZXZpY2UgdG8gdHJ5IHJl
Y292ZXJpbmcgZnJvbQ0KPj4gYSBwb3NzaWJsZSBlcnJvciBlYXJseSB3aGljaCBpcyBkb25lIGJ5
IGNhbGxpbmcgdnBjaV9kZWFzc2lnbl9kZXZpY2UNCj4+IGludGVybmFsbHkuDQo+IFllcywgYnV0
IHRoYXQncyBvbmx5IHBhcnQgb2YgaXQuIEl0IGF0IGxlYXN0IG5lZWRzIGNvbnNpZGVyaW5nIHdo
YXQNCj4gZWZmZWN0cyBoYXZlIHJlc3VsdGVkIGZyb20gb3BlcmF0aW9ucyBwcmlvciB0byB2cGNp
X2Fzc2lnbl9kZXZpY2UoKS4NClRha2luZyBpbnRvIGFjY291bnQgdGhlIGNvZGUgc25pcHBldCBh
Ym92ZTogd2hhdCBpcyB5b3VyIGV4cGVjdGF0aW9uDQpmcm9tIHRoaXMgcGF0Y2ggd2l0aCB0aGlz
IHJlc3BlY3Q/DQoNCj4NCj4gSmFuDQo+DQpUaGFuayB5b3UsDQpPbGVrc2FuZHI=


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 10:29:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 10:29:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268009.461775 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHNkb-0003VP-6o; Tue, 08 Feb 2022 10:29:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268009.461775; Tue, 08 Feb 2022 10:29:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHNkb-0003VI-3X; Tue, 08 Feb 2022 10:29:33 +0000
Received: by outflank-mailman (input) for mailman id 268009;
 Tue, 08 Feb 2022 10:29:32 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1FiY=SX=epam.com=prvs=40383cc40e=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nHNka-0003VC-7a
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 10:29:32 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ff83572d-88c9-11ec-8eb8-a37418f5ba1a;
 Tue, 08 Feb 2022 11:29:30 +0100 (CET)
Received: from pps.filterd (m0174683.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 2188wLw6000773;
 Tue, 8 Feb 2022 10:29:26 GMT
Received: from eur05-db8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2109.outbound.protection.outlook.com [104.47.17.109])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3e3nfprd9r-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Tue, 08 Feb 2022 10:29:25 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM0PR03MB5090.eurprd03.prod.outlook.com (2603:10a6:208:100::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Tue, 8 Feb
 2022 10:29:22 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77%3]) with mapi id 15.20.4951.019; Tue, 8 Feb 2022
 10:29:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ff83572d-88c9-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=hWGhPZKDbW4nGr31q0TJlm/vbbQ0f6OOuTcHRKjIcFhukRJrNWybtqu/AdlQVd6PxuCQ+2vqNG++R/FiGqU3PdKCoSmLRuAA8AQs5cKhDIDC2YF+wjZGSMqQgdVewZOJUCzPNVMyF78WY+puc4imthAt6n1gBgaoEPCmiFA+7lEtHu1rzfCv1prdJ694yLNJ6pHhxI/BZAAmenZxNPIO5L24X+6cG/4RI2WIYpKOSnHKwIi+T+wlq+9bpboavUm2ftptBaLN/vdlKto4PCnp1FW1EGSVGyKKSQ76cxzSu9xVPMMxfdJXyqciqu4Ys7lrSUWjSQT+Wi/J1Kix5vlKeQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=CCntf5lb0JiVEnujz62eG+2dGqOYsNa1FDMRVcPVVpg=;
 b=Aq5YP/aAPa9sSvNxJZRYeeUDXLKjs0KAsixOBYagk5F4unfBlCDObSgA0mSC8sN411m+r43601Slv9fbSj3u3rinj7tvjR4kp9JDLiBue+vVaE0tuzcq+xZIWAPolKfR3KadDo0BB5VAz30e8kn9yAp5k47cnJAnxjbYEIf4IgmxVgrLicmNJORlhA9H5/AJbnLrUuQM30ZSybId/NI69c/9kKTV8ltdL3fsEbwgUFEeE3JqLO2dc2ldZKvf1sWLJ4lo3aueGJcGb4B/Sbvt4LpY/CLZq0W6CoAB3G0Ac6KHxMkmJPtPbL66+oWXmwoXPz/UjlZ9ofZSdEtfb7VlXQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=CCntf5lb0JiVEnujz62eG+2dGqOYsNa1FDMRVcPVVpg=;
 b=MoamOkA52BjjzWQ0WwkqRvPV1dY3pzKlKn/NwRYGhDEarvfwM4bgVH50Y5bruRdzwwn+aZEdNvnrvitwUpyOpmY/p96oW40xBGruR15n9dZ37RVf/L3OZlTzRPIFpaVmz7sCg6N4aLexpKN5WkNZaQS+ilmwJfYX5c5vn7byo2LV2o3oC8aN++2FqpMYp9bgXbGTzb+/ut5nbUAcxnIbm0jx9GUBf26WcWPO0RJJcok6do+SU9iSC8I9brqt7MzE1w1PEqwEqmJU28iejzZ+ANKNfoto0+sakP2uGddX7BWPIitch66SpByCxGcIu/E4vayPkLqrqP7Uu74vGGQWbA==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>,
        =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?=
	<roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v6 06/13] vpci/header: implement guest BAR register
 handlers
Thread-Topic: [PATCH v6 06/13] vpci/header: implement guest BAR register
 handlers
Thread-Index: 
 AQHYGZFd6D+qnME8W0+wTH+v8YZ8DayJaJYAgAABnACAAASVAIAAApGAgAAFPICAAAPBgA==
Date: Tue, 8 Feb 2022 10:29:22 +0000
Message-ID: <a92fb9da-438c-dd59-e7b1-d288a8efa05f@epam.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-7-andr2000@gmail.com> <YgI3HpFffudiEmNN@Air-de-Roger>
 <498ca523-2642-e35f-b316-0a089f98ca91@epam.com>
 <5bc96dba-e9b8-de2e-f6aa-ae6c604897e8@suse.com>
 <6ac5d7ce-96dd-66e1-c8d1-eff7b0a1349e@epam.com>
 <41552c52-5e2e-5108-ab37-d1fb5d9b5edb@suse.com>
In-Reply-To: <41552c52-5e2e-5108-ab37-d1fb5d9b5edb@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 7f3ca224-c58b-4c9c-45f9-08d9eaeddf79
x-ms-traffictypediagnostic: AM0PR03MB5090:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM0PR03MB5090F7990359CAE555C1498BE72D9@AM0PR03MB5090.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 vV0RQ+2L6fLJqUykDc70en4e/pvTkVZiLspKmAqUw4JMao1ETkDHdk2zVrlK+wA2qbMduCFGHf0NX1F9oc/MtYp44TaDXCqual46JEw1iXZ9rLTk7yQtjDi7ddXv54/F93p5pwgnedcevBq88yeVVGvT7PL7cm/ZZEmfN4/F2l1ksH/JYjdd520n9sFuRg40x6RGP/yRNDXn0uJg3/Bqft6emywGaqy4AxDSSo3fVFEi+OC/e/Z1ZJy/2zme70uAI4tVBhjN13FdVK/mdDfp7gv12/epLeXq96zWw8PWlasgjiY8cR4xSiVOZ3vSeCQxgL9YmBsYtyRnlOP+6bnS/CzrijSe2jDLa/dDpMf5tiHHzVd7/lkOal+rpjlZCSdLVz7q+RgbQZckr44cx8sJgR9LIPA04ftH5MlKC4qqQSRSUA3+R9ZrIsUz+smvWnHaI/djVC9/Q2L78cCuOa9Zv2jTiA0CFlyAZeLxk59Drgvy7eWEHRLBBO3tC6u4Xkf7MAexvQ/ZpVL8JTc6oBfylNQCfZ+KxHU72EdeJAEjczczMZxKudfm427COeY+L3Tkn4lqCt1Acjnj8vWI3cbMn+vT678J36Gw5hkreL4M3iR1I+iTWKRiO26IPtDyxd2EVlzmEzr5mc0Az8pnVl4f+jva4BLbbu6rMYTOt+0AfnXx+nV/zWSM1cMpheQPHzfTAgmCE+fGMf1c7sJ9zOJsZjV9IhQEC9Y6/oVB82lvWYWa6V+mAi63kRBjhoZ8cxl/
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6506007)(4326008)(508600001)(66446008)(53546011)(122000001)(38070700005)(2906002)(8936002)(71200400001)(55236004)(66946007)(76116006)(6486002)(66556008)(8676002)(38100700002)(91956017)(86362001)(64756008)(66476007)(36756003)(186003)(2616005)(110136005)(107886003)(54906003)(31686004)(6512007)(7416002)(5660300002)(26005)(31696002)(83380400001)(316002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?dmFPVEl0SGhQNzVZUmNMWEhwSzJ3UjkvMzE4amNURXZSVUJ3Z01uMWxKNFRQ?=
 =?utf-8?B?Mk0xRnRDZGxQVDEzQ1lRTUNJd2tWSWswNW1tdkNidzVDOERWckwwTEh6NS84?=
 =?utf-8?B?YTMvdEJSWUYySkwzVWM0dEN1KzlkNDREeW1XcGRhVlJMcW1uM29EZ2lKMWll?=
 =?utf-8?B?YTVEOGJhU2pRZTMxTm5TMXpmRWtFR2xMS3RVcGljRFJCUFB0cHcybHFsaU1p?=
 =?utf-8?B?OC96d2ZMSmF2L0J1RDNoZUZBV1VBWmxRSmhjM2crUE9xNU40RnNBVXJQTW85?=
 =?utf-8?B?L0s2WTdaZmZXSkN6Tll6WkY1ZFdlYzllN0VlV3o1UzhQOGhMR04zemhzcjQ3?=
 =?utf-8?B?U0gvSEZDNy9sOVQ0MTJIbFdFQWdzV2QzNThDbzJ1Nm9FMnZnQUc1T0diQ3NO?=
 =?utf-8?B?amJ0SlpaU2tlMUZHU1hPL2x1bGJLVnJYZGtXZXR1UHhsRVpVSXdDNm5nNFVs?=
 =?utf-8?B?RzBqSDFtOHZ3cFRldC9Pc3hhdzMyUTJVaHp1UWkzVGJUN0NJN1liblhNK24v?=
 =?utf-8?B?bWc2R2IvTWZNTzhmSUNBYkR4cy9FRGphQ0MzMVZzYko4SjA1SDNhK3BvVzNT?=
 =?utf-8?B?VExMSUFDbGVLTUhaaUVEWWRpdVdROGZFNGN6d0FYRXBjODNrNkFNcFh2V3Qv?=
 =?utf-8?B?c09naFpLSmxrWnc0RlZJNHF3a3NCMk1GcUhyL0NnSFVqNDZFSVVFN1JwNm0x?=
 =?utf-8?B?VTJkU0lxZ281UWI4U2p5endZcjBCNWhLdTZ1WnVTemdHczl0a2FuK3puN0JH?=
 =?utf-8?B?OWN0QnZJS3NYdVF2RHgwemUrYTh1a0hpdjJJSnlmdVlLR2E5cnl5VFhRZjVL?=
 =?utf-8?B?TVJITm5EZUIrWUFYQ1l4VVRQWTVROHM0cVRYbWl3V084WjNVNjEvRFY1RjRy?=
 =?utf-8?B?dGhUZGNSWGlzYy9uK3d4ZXRvY1NNRlg4NDZXZTBYWVVOZjA2OWR1Q2RCSUZN?=
 =?utf-8?B?L2xUaUErTEcxTVdhU1lWZUdwdkZjSUNFdE9WcXJnaWZwYStXTWMyM3duWnBQ?=
 =?utf-8?B?dWJ6VlROZ1JOTFF2TFRtWTkzcnU2cDZvZkhBbGFFQVhXTVpwZmRBR1VLUUVK?=
 =?utf-8?B?ZkJNb2JHSzlwVVNpclVzRGFWVG41aE9UVktDa1d2NFducXlDMXIwTURZbmtJ?=
 =?utf-8?B?d3VhazIwTUhzc2lkL0NPcWlYcjRXU2RQV3grSDJENUlmRFVyMmM0MWJ5bVNX?=
 =?utf-8?B?TU9CN2F0d2hVWksvNUtweG9iQ1pLYVpvUXBXSFBVM1JmcGpDZVlrV1puRGtF?=
 =?utf-8?B?b0FyRVlsVndhK3IxS2NHMXVsVVYwZGZ4c3FTTHFnWlpJdzRuS081M1F4SjRO?=
 =?utf-8?B?cHJSeVVDMklaaWFhdE1MN3g1N25lbFg5WkxsS3NmMDkxWU1mSFlGWkJCU1pi?=
 =?utf-8?B?YndoSnJUT01EN0VFYllHd2pkanQ5NFdpN2hlVVlzNzdDcDV4MG1DbEFoVk1t?=
 =?utf-8?B?U015TUt3VTVhVUpjZ09pWi9sa09DckNXNTd6RjJuQXUrNHlDZVFrRktuNjA1?=
 =?utf-8?B?anBpaU9yWWFvR2RDc1ZvaGpnSTJ6ems1cTZBRkJGYityT2s5UDNocFNGNEVC?=
 =?utf-8?B?empwbThkRXVsV3lwbVVOZTgwVWxveEsrZU1vOFo5bGQwZHVkb2IzcXNJNFll?=
 =?utf-8?B?UDBvU1QrVDV5eDlUU3VNRDNwNjhJZzVINTluMVdLMjd0OWx2MGp1dWVDM3Nq?=
 =?utf-8?B?VWJvSEhzSzArOVg4T2Yyb2hlbm9Ec0tnTU9ueThCMGlyL1FscUlaNDFnOSth?=
 =?utf-8?B?S0hTVjVxeHdJMnZPQjBxdXFZcUVYZFlPV2lXNE9iZVEwVXVXekN4WDUxL2w5?=
 =?utf-8?B?ZlRINGNWTFUra1BrLzE0eDBxZmQvRjQ5SlY0eFE5SjZOSTc5ZUxqRW5vRGl2?=
 =?utf-8?B?RGZlUHVCRFNXR0xaKzRLMGcybFUyaXdjU050RkRybTJVTGtXeldnb050aUEz?=
 =?utf-8?B?Y0c5ZWpLSUZRTEs0Q2ZkdHRtNSttelNiV2ZMclByQVo4WVpyTmlPRkVYZWlL?=
 =?utf-8?B?emcwK0RZeEcwTldQTmwxOTkxR3d4em5YdGkwaWRMakNGSDdVd0xMWWJBNCtP?=
 =?utf-8?B?K2cvYjNoaE1rU3kyUm1FNjVibVQ0Mll4aW5rck5saG5UMFhWMzlyaVhYNlBN?=
 =?utf-8?B?Y0tsWTBBd2FGK2YyVXJRd0tycFlzUWtKNDlkL29uNGYrcUc3Qy80aGtGNStZ?=
 =?utf-8?B?M0FjdmY0bHluamJxcEc5L1M0VkFJaHhrUEoxUXVsZHF1aFYzZ2xvQzhZVk1Z?=
 =?utf-8?B?b1pxc0JTOXpoLzNMWVExbzNIQzhwQmtCQ3Q2OHMyNzYvVW1USnc0aW1EbUM4?=
 =?utf-8?B?L0RWcS9aZVhFTjA4bkJLQWNYcytqTXZ5bjZYM2tmMTFuWTU4N0tHTS8yL0Jt?=
 =?utf-8?Q?5lalA0AaADUP8RNw=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <41B5B3EB66B31E40AA03E0291F2E9D23@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7f3ca224-c58b-4c9c-45f9-08d9eaeddf79
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2022 10:29:22.5489
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: yH+JmudSHGtxtOUSFvM/RWRi9YlDHONZko65C2CPqxFIyDqo3YS91W/N7hi67fUStLOjKsvEwG1EFiK7DwlXhlqblEohfz/gD982hCESPjxI5l6ajSKF0YGOL4Rat6SM
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB5090
X-Proofpoint-GUID: 1Ku-GYXqsvH9o5H1sNAdk-W_PnU9P9r6
X-Proofpoint-ORIG-GUID: 1Ku-GYXqsvH9o5H1sNAdk-W_PnU9P9r6
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-08_02,2022-02-07_02,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 mlxscore=0
 phishscore=0 mlxlogscore=999 impostorscore=0 suspectscore=0 adultscore=0
 priorityscore=1501 lowpriorityscore=0 clxscore=1015 bulkscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202080060

DQoNCk9uIDA4LjAyLjIyIDEyOjE1LCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMDguMDIuMjAy
MiAxMDo1NywgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+PiBPbiAwOC4wMi4yMiAx
MTo0OCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+Pj4gT24gMDguMDIuMjAyMiAxMDozMSwgT2xla3Nh
bmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+Pj4+IE9uIDA4LjAyLjIyIDExOjI1LCBSb2dlciBQ
YXUgTW9ubsOpIHdyb3RlOg0KPj4+Pj4gT24gRnJpLCBGZWIgMDQsIDIwMjIgYXQgMDg6MzQ6NTJB
TSArMDIwMCwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+Pj4+Pj4gQEAgLTUxNiw2
ICs1OTQsMTEgQEAgc3RhdGljIGludCBpbml0X2JhcnMoc3RydWN0IHBjaV9kZXYgKnBkZXYpDQo+
Pj4+Pj4gICAgICAgICAgICAgaWYgKCAodmFsICYgUENJX0JBU0VfQUREUkVTU19TUEFDRSkgPT0g
UENJX0JBU0VfQUREUkVTU19TUEFDRV9JTyApDQo+Pj4+Pj4gICAgICAgICAgICAgew0KPj4+Pj4+
ICAgICAgICAgICAgICAgICBiYXJzW2ldLnR5cGUgPSBWUENJX0JBUl9JTzsNCj4+Pj4+PiArDQo+
Pj4+Pj4gKyAgICAgICAgICAgIHJjID0gYmFyX2lnbm9yZV9hY2Nlc3MocGRldiwgcmVnLCAmYmFy
c1tpXSk7DQo+Pj4+PiBUaGlzIGlzIHdyb25nOiB5b3Ugb25seSB3YW50IHRvIGlnbm9yZSBhY2Nl
c3MgdG8gSU8gQkFScyBmb3IgQXJtLCBmb3INCj4+Pj4+IHg4NiB3ZSBzaG91bGQga2VlcCB0aGUg
cHJldmlvdXMgYmVoYXZpb3IuIEV2ZW4gbW9yZSBpZiB5b3UgZ28gd2l0aA0KPj4+Pj4gSmFuJ3Mg
c3VnZ2VzdGlvbnMgdG8gbWFrZSBiYXJfaWdub3JlX2FjY2VzcyBhbHNvIGFwcGxpY2FibGUgdG8g
ZG9tMC4NCj4+Pj4gSG93IGRvIHdlIHdhbnQgdGhpcz8NCj4+Pj4gI2lmZGVmIENPTkZJR19BUk0/
DQo+Pj4gQWZhaWMgYmV0dGVyIHZpYSBhIG5ldywgZGVkaWNhdGVkIENPTkZJR19IQVZFXyogc2V0
dGluZywgd2hpY2ggeDg2IHNlbGVjdHMNCj4+PiBidXQgQXJtIGRvZXNuJ3QuIFVubGVzcyB3ZSBo
YXZlIG9uZSBhbHJlYWR5LCBvZiBjb3Vyc2UgLi4uDQo+PiBDb3VsZCB5b3UgcGxlYXNlIGJlIG1v
cmUgc3BlY2lmaWMgb24gdGhlIG5hbWUgeW91IHNlZSBhcHByb3ByaWF0ZT8NCj4gSSdtIHByZXR0
eSBzdXJlIExpbnV4IGhhcyBzb21ldGhpbmcgc2ltaWxhciwgc28gSSdkIGxpa2UgdG8gYXNrIHRo
YXQNCj4geW91IGdvIGxvb2sgdGhlcmUuDQpOb3Qgc3VyZSwgYnV0IEkgY2FuIGhhdmUgYSBsb29r
DQo+ICAgSSdtIHNvcnJ5IHRvIHNheSB0aGlzIGEgbGl0dGxlIGJsdW50bHksIGJ1dCBJJ20NCj4g
cmVhbGx5IGluIG5lZWQgb2YgZG9pbmcgc29tZXRoaW5nIGJleW9uZCBhbnN3ZXJpbmcgeW91ciBt
YWlscw0KV2VsbCwgaWYgYW5zd2VycyB3ZXJlIHRvIGJlIGEgYml0IG1vcmUgc3BlY2lmaWMgYW5k
IG5vdCBzbyBnZW5lcmFsDQpzb21lIHRpbWUsIHRoaXMgY291bGQgZGVmaW5pdGVseSBiZSBoZWxw
ZnVsIGFuZCBzYXZlIGEgbG90IG9mIHRpbWUgdHJ5aW5nDQp0byBndWVzcyB3aGF0IG90aGVyIHBh
cnR5IGhhcyBpbiB0aGVpciBtaW5kLg0KPiAgIChhbmQNCj4gaW4gcGFydCByZS1zdGF0aW5nIHRo
ZSBzYW1lIHRoaW5nIGFnYWluIGFuZCBhZ2FpbikuDQpJIGhhdmUgbm8gY29tbWVudHMgb24gdGhp
cy4NCj4NCj4+IEFuZCBkbyB5b3UgcmVhbGl6ZSB0aGF0IHRoaXMgaXMgZ29pbmcgdG8gYmUgYSBz
aW5nbGUgdXNlciBvZiBzdWNoIGENCj4+IHNldHRpbmc/DQo+IFllcywgYnV0IEknbSBub3Qgc3Vy
ZSB0aGlzIGlzIGdvaW5nIHRvIHJlbWFpbiBqdXN0IGEgc2luZ2xlIHVzZS4NCj4gRnVydGhlcm1v
cmUgZXZlcnkgQ09ORklHXzxhcmNoPiBpcyBwcm9ibGVtYXRpYyBhcyBzb29uIGFzIGEgbmV3IHBv
cnQNCj4gaXMgYmVpbmcgd29ya2VkIG9uLiBJZiB3ZSB3YW50ZWQgdG8gZ28gd2l0aCBhIENPTkZJ
R188YXJjaD4gaGVyZSwgaW1vDQo+IGl0IG91Z2h0IHRvIGJlIENPTkZJR19YODYsIG5vdCBDT05G
SUdfQVJNLCBhcyBJL08gcG9ydHMgYXJlIHJlYWxseSBhbg0KPiB4ODYtc3BlY2lmaWMgdGhpbmcg
KHdoaWNoIGhhcyBwcm9wYWdhdGVkIGludG8gb3RoZXIgYXJjaGl0ZWN0dXJlcyBpbg0KPiBtb3Jl
IG9yIGxlc3Mgc3RyYW5nZSB3YXlzLCBidXQgbmV2ZXIgYXMgdHJ1bHkgSS9PIHBvcnRzKS4NCkkg
YW0gZmluZSB1c2luZyBDT05GSUdfWDg2DQpAUm9nZXIsIGFyZSB5b3Ugb2sgd2l0aCB0aGF0Pw0K
Pg0KPiBKYW4NCj4NClRoYW5rIHlvdSwNCk9sZWtzYW5kcg==


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 10:29:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 10:29:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268010.461786 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHNkn-0003qH-Hw; Tue, 08 Feb 2022 10:29:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268010.461786; Tue, 08 Feb 2022 10:29:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHNkn-0003q5-Ei; Tue, 08 Feb 2022 10:29:45 +0000
Received: by outflank-mailman (input) for mailman id 268010;
 Tue, 08 Feb 2022 10:29:44 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=v7zX=SX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nHNkm-0003p4-BH
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 10:29:44 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 07396012-88ca-11ec-8f75-fffcc8bd4f1a;
 Tue, 08 Feb 2022 11:29:43 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2051.outbound.protection.outlook.com [104.47.14.51]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-41-IWvdI5pZOXml_Bnsafl9Iw-1; Tue, 08 Feb 2022 11:29:41 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DB7PR04MB6012.eurprd04.prod.outlook.com (2603:10a6:10:37::14) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Tue, 8 Feb
 2022 10:29:39 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.018; Tue, 8 Feb 2022
 10:29:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 07396012-88ca-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644316182;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=uyDnzHyhr07D9RbqcXikt2svKFChMYHgPtWct1qXp/E=;
	b=H5KqpjEeGbQ58+Z6+fmp07zLY3yOGzSIBNJEuynqOAZXkD5T/POC5sxEFyTHy50jjhHioz
	44pKsoBbx7bch/4bDLt7YL4haqEObyKOwUEITH6JOlgONpZ2qYa8Bp0bS3/LKlUC1tmC+K
	Vrl2Unit2y79WsQhBW9++3CxPciU1TA=
X-MC-Unique: IWvdI5pZOXml_Bnsafl9Iw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=AzRkFy+3/7+xm1Nx5asaeYezOIQhmjdgYvxeGBefsKYcJBFdGuyKz5Jzzg5qto6sfrsUpYgro1tLQ5uDgWpY55/X4LkcxbXTQjQUIuVBc18JhI5+B2npaptYVwrb98Y57OaO45Ty/II6EIo7kwz9xHtMu/iViQSC8TX+Do5YeNlJ9Jc/UDIkZFnbm8AB7xksKrDgWFSgSvl+OIfVqdPjgYH8laCafz283NKOdKLUXUHNVEPDwPqoJCfvmfdbNHDFIOdmA2tGIRGulWhy0yXj2iSTsvY9weOsgTAYJOEd9Hx/LklVuHcRkmyZ8A33k9CL2QnarsG6apDLvjuBUL0vmg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=v64T+BBu1Xx85TwBXHaQS21VYi81iaqZh9f/C2Ok1TM=;
 b=W5C74HnsUlEmqVBUp/Bjks+stvnVXIAMaMuptXClUe9FAehhAYJSjI+AXAKi9a03VuFfAeEXAPH9GbFIfWg1KS3lY0huAMR0cul7e79sJYMiCjXLT+wv6keGSRRs7yw/L39ljrjPfO1IZhohtbcb6ZhxcOnABXYM18ua5mtCIBVKmUT6dAb3NrcU8fK4VeD6H2GyT3UHOjbBHtedMtn+w0TTbfyV2NNKqdlnpttHcxdkdPxhZrXc0NoGz7RdTn3BEDZp7VNOH0gCw7BWtmp60SE/uuNDTwZlKJdla67cjZDTT9m5PisjfDmMHQGKZ18jEdQ+XT1mZ6OS/i/OpvD1Bg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <10cd89b5-a804-3354-26d8-bc271bd9c5e6@suse.com>
Date: Tue, 8 Feb 2022 11:29:35 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v6 05/13] vpci: add hooks for PCI device assign/de-assign
Content-Language: en-US
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: "julien@xen.org" <julien@xen.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Artem Mygaiev <Artem_Mygaiev@epam.com>,
 "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
 "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
 "paul@xen.org" <paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "roger.pau@citrix.com" <roger.pau@citrix.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-6-andr2000@gmail.com>
 <16cea1df-3d0f-d404-2b88-aab47ad5548b@suse.com>
 <3fe6dbe3-51c6-f87f-23f9-cf2e1a924326@epam.com>
 <582ee8f9-7b01-4adc-6a8a-ce8b1dffd534@suse.com>
 <e225553b-b29c-0448-fb9f-f8b513d9f77d@epam.com>
 <0fd8a0ac-dc91-287e-536e-1684892837ab@suse.com>
 <9f58a8ff-44b4-3249-5858-9988644b2d4e@epam.com>
 <15c16171-f196-38d2-370c-38627935a21b@suse.com>
 <20762939-6b7e-ff60-7c1a-d47c4767ff4f@epam.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20762939-6b7e-ff60-7c1a-d47c4767ff4f@epam.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6PR02CA0024.eurprd02.prod.outlook.com
 (2603:10a6:20b:6e::37) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5d42bfc8-7a1c-4c45-16f1-08d9eaede921
X-MS-TrafficTypeDiagnostic: DB7PR04MB6012:EE_
X-Microsoft-Antispam-PRVS:
	<DB7PR04MB6012196787767C6859260C6EB32D9@DB7PR04MB6012.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	eQRF7CxlH2q7TjWk2fZL02e5Y03cn/VIgg7sN3gggd6a65vvbiZmjx2lwl42BToFH0AxCHSn1bmRDjdcgysSwe7wuYw8NYLRFM3i+9z5vz+YPFa8T+hAIsJJzutLkFe57Nvenf3Bq/0v9pWpsV03xhcmDAsHv1pF0gXaXLrLGl0Y6dvw01CGjInWRstSQAvaw/iskj14CV+hZ0tj+BnGQueuvOVUZOGUoxEfNXhdGfgNoUDh2Ie4YiFKMTjRqH+8axASMqwtehnIwv8yufrsTNuGErl/DTQkn1vsq32Cx29THgUeNqGr3QdLS7mrplYp7Ui64CSRvA950HK2UBfTAtT+osOplrQ0yIgw/qCX1+uLSksxNfHNHingjjwTQ97qR73PhDcmZnBuh4cwAqlsCADaW+nChrnPlbBlo4brzmz/8feLhwK8Wshemq/kFLd/5+JTBBhEC/GY4vUetIc16ThutrxM5WxM9PRrHO2ob5AJIOKJyoOOSOt6kWqp1iVwPvKyNTuk0O0UCEx3KmLttRb9+puRgMVuqgNDl9Pp3SDHRUHIFp+orkpl0eswzPAZUuRnNup3FpoV387xu5NIko1rMAPnAJ/SYYNgXEGXwsXKP/a7wb4y5DQ46gV8sDuRCKvllfELavcqg6+06X7leJyBV3wiHFD8ZbqNH/67FOeoc2kCexVKQsj17xZrSAfDNvSgDVYlpZA1UPFKeH2hG09dOheHrUzZuJOEqgAs6Xc=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8676002)(8936002)(66556008)(66946007)(6486002)(6506007)(86362001)(31686004)(4326008)(53546011)(54906003)(7416002)(6916009)(66476007)(316002)(5660300002)(31696002)(6666004)(6512007)(508600001)(83380400001)(186003)(26005)(36756003)(2906002)(38100700002)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?FogYXOUmJxnLRABJ4C+HGXDj0oypa01O8oSoNwB/ZVRdRWglHt3ki65jjgP+?=
 =?us-ascii?Q?6Cb+wxvIkveYXZY4cxh8s1g+hfsybcf7f0aj9Qq1982OQXfaAyBiUMNHQ5Rv?=
 =?us-ascii?Q?2s9RYiV9a4bA/LsVdnTGxa45IXbjJcYmtwhggxwEz8LQZ04GrtWuXfNeT9fb?=
 =?us-ascii?Q?EPnCYO9LZfpxrBIitwWgyxyXUcFP6zcZrb0eNwNYYQJInqqkyw1iAvvEGHfm?=
 =?us-ascii?Q?DCT+E99slm1qIc3Apq5Re5O8ChDeSRo+OCh3gZOEbo+pKbPGCsmQZ+ao0+kk?=
 =?us-ascii?Q?AR4viP0MyMbOgz+Zxc2iUqu1BcsKCQ0gTZL/C7t18H2l3T0RTCcdzW2LKgED?=
 =?us-ascii?Q?GXx3m9gnsRanEzG44Qj2/OwHapWImJrv+r5uek9r8wIRd+XG+QBZazZbpTth?=
 =?us-ascii?Q?JOXV6rntx0JtzEaDFno2mdE88nEPbhKxtFiIXkXNZbSjbQsdb/WxWfYdKNt0?=
 =?us-ascii?Q?c014kOeR87EDnremXtq2QminxnfEfPpME19FT+ksww8iFEAp39uI08aSkPMC?=
 =?us-ascii?Q?IPEqaG/Q8tXQb+jbZpZOLsS5FnVAK0BYk/uZ6ikNuuYPcPrKa+sYXI/LEtaf?=
 =?us-ascii?Q?unY4oIPP0A3YzMhSuRjuuJIXRyksMaC6k4zgf+hNWA85LtyaU18NNREtmAZ/?=
 =?us-ascii?Q?z/0YcSBNUUqa0x7rmtgQMeyNsevN5+2sWpn2Cn/SV/mNXQriujsP0TOBaZdN?=
 =?us-ascii?Q?iRZP8jB8gGUKdnYFpyQTPhZ4Sh04RPVt4XgUgNK4/uMtgAUbqCYl79yN4otC?=
 =?us-ascii?Q?6YfAno/OYYWpreWCq8DEZmDXW4MZjrxvscfOFa4MxzWhUTlyFiVyKXi2Qxq5?=
 =?us-ascii?Q?rq2yT+fiYJrBkkX7T1KBYHv6yB+Gyt8llmhZjRp13/z2QUHUk8f9akOpd5CZ?=
 =?us-ascii?Q?yvYvnXy6mIznm7mIvWC3ztdzKoImcljZqvhdm1rg/EF9EENSPb0x4ozp4fh9?=
 =?us-ascii?Q?S87iOiy8Hvp47IH0LWkx6+edByKIYXBZ6JCPwSeol8joOpljw0Db+Jv/0J+r?=
 =?us-ascii?Q?WyItvjoS9MVL6tT8+7UA5PZ0tciww/5UWveAORCCa0K6H7LV8V+7rVy750tT?=
 =?us-ascii?Q?pwY2Uo1aTJZzyZfN78BBLhC3hSlYwdWvwr9HczDiE2Mh0ius+iOPsuftB9Fk?=
 =?us-ascii?Q?bkyrWDveYvIUrrHTK2SyOda34LD6MLKi06okmeeMMdm73+/JQyOAwhQht29z?=
 =?us-ascii?Q?Od02QS3keZ0F46JqmJwKgNDkx23YJHfYdnXlzaX3b3o/Qqsks6HBg4UDGwsY?=
 =?us-ascii?Q?G9OzVXYb4sm/y4I1LIgEwNl4OHB2m2akBMhbZwblRGKP9OUtmw/4RwO4RDJN?=
 =?us-ascii?Q?1Oy/nJH62CP2eAN/rpQnX4oJ5bqD5Mu9d8PrE+c74uLn2fiDWbCt7ee7Gt+Q?=
 =?us-ascii?Q?sFwSS1AoSeaqHDXM6pKV1ZzxlZpCQVMtODyADIlNn+5dXDrJsV6jD0sXFDwu?=
 =?us-ascii?Q?P920qn/hVtycmTe0s09LAhGWDQQ9xFFLTn9VZFsTc1TTnaXIjB77wBq3NdHK?=
 =?us-ascii?Q?R7niK+LkZRJFWxQsIpcd2wGcXMygDAF99m58i8bi6d2RZPjjpjatreTwpiGl?=
 =?us-ascii?Q?/psJ9MlrLo+5xvJT4TDf9AyhhJp0VT2c8XYrZ53jBgxCJrRU/zWBYZWddg26?=
 =?us-ascii?Q?oybYwos0vzARKT8y8cZ3ft0=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5d42bfc8-7a1c-4c45-16f1-08d9eaede921
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2022 10:29:39.0294
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: l7VpvNMq5TOJquN3f0jpeIURGdyIpHY5LojSpG6WencZUaOW3GmctYQ8Gw5Loc9L6eOmwm1UOu10nfbHRw48og==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB6012

On 08.02.2022 11:22, Oleksandr Andrushchenko wrote:
>=20
>=20
> On 08.02.22 12:09, Jan Beulich wrote:
>> On 08.02.2022 10:55, Oleksandr Andrushchenko wrote:
>>>
>>> On 08.02.22 11:44, Jan Beulich wrote:
>>>> On 08.02.2022 10:27, Oleksandr Andrushchenko wrote:
>>>>> On 08.02.22 11:13, Jan Beulich wrote:
>>>>>> On 08.02.2022 09:32, Oleksandr Andrushchenko wrote:
>>>>>>> On 07.02.22 18:28, Jan Beulich wrote:
>>>>>>>> On 04.02.2022 07:34, Oleksandr Andrushchenko wrote:
>>>>>>>>> @@ -1507,6 +1511,8 @@ static int assign_device(struct domain *d, =
u16 seg, u8 bus, u8 devfn, u32 flag)
>>>>>>>>>                              pci_to_dev(pdev), flag);
>>>>>>>>>          }
>>>>>>>>>     =20
>>>>>>>>> +    rc =3D vpci_assign_device(d, pdev);
>>>>>>>>> +
>>>>>>>>>       done:
>>>>>>>>>          if ( rc )
>>>>>>>>>              printk(XENLOG_G_WARNING "%pd: assign (%pp) failed (%=
d)\n",
>>>>>>>> There's no attempt to undo anything in the case of getting back an
>>>>>>>> error. ISTR this being deemed okay on the basis that the tool stac=
k
>>>>>>>> would then take whatever action, but whatever it is that is suppos=
ed
>>>>>>>> to deal with errors here wants spelling out in the description.
>>>>>>> Why? I don't change the previously expected decision and implementa=
tion
>>>>>>> of the assign_device function: I use error paths as they were used =
before
>>>>>>> for the existing code. So, I see no clear reason to stress that the=
 existing
>>>>>>> and new code relies on the toolstack
>>>>>> Saying half a sentence on this is helping review.
>>>>> Ok
>>>>>>>> What's important is that no caller up the call tree may be left wi=
th
>>>>>>>> the impression that the device is still owned by the original
>>>>>>>> domain. With how you have it, the device is going to be owned by t=
he
>>>>>>>> new domain, but not really usable.
>>>>>>> This is not true: vpci_assign_device will call vpci_deassign_device
>>>>>>> internally if it fails. So, the device won't be assigned in this ca=
se
>>>>>> No. The device is assigned to whatever pdev->domain holds. Calling
>>>>>> vpci_deassign_device() there merely makes sure that the device will
>>>>>> have _no_ vPCI data and hooks in place, rather than something
>>>>>> partial.
>>>>> So, this patch is only dealing with vpci assign/de-assign
>>>>> And it rolls back what it did in case of a failure
>>>>> It also returns rc in assign_device to signal it has failed
>>>>> What else is expected from this patch??
>>>> Until now if assign_device() returns an error, this tells the caller
>>>> that the device did not change ownership;
>>> Not sure this is the case:
>>>   =C2=A0=C2=A0=C2=A0 if ( (rc =3D iommu_call(hd->platform_ops, assign_d=
evice, d, devfn,
>>>   =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0 pci_to_dev(pdev), flag)) )
>>> iommu_call can leave the new ownership even now without
>>> vpci_assign_device.
>> Did you check the actual hook functions for when exactly the ownership
>> change happens. For both VT-d and AMD it is the last thing they do,
>> when no error can occur anymore.
> This functionality does not exist for Arm yet, so this is up to the
> future series to add that.
>=20
> WRT to the existing code:
>=20
> static int amd_iommu_assign_device(struct domain *d, u8 devfn,
>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 struct pci_dev *p=
dev,
>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 u32 flag)
> {
>  =C2=A0=C2=A0=C2=A0 if ( !rc )
>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 rc =3D reassign_device(pdev->=
domain, d, devfn, pdev); <<<<< this will set pdev->domain
>=20
>  =C2=A0=C2=A0=C2=A0 if ( rc && !is_hardware_domain(d) )
>  =C2=A0=C2=A0=C2=A0 {
>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 int ret =3D amd_iommu_reserve=
_domain_unity_unmap(
>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 d, ivrs_mappings[req=
_id].unity_map);
>=20
>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if ( ret )
>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 {
>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 print=
k(XENLOG_ERR "AMD-Vi: "
>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "unity-unmap for %pd/%04x:%02x:%02x.%u=
 failed (%d)\n",
>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 d, pdev->seg, pdev->bus,
>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 PCI_SLOT(devfn), PCI_FUNC(devfn), ret)=
;
>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 domai=
n_crash(d);
>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 }
> So....
>=20
> This is IMO wrong in the first place to let IOMMU code assign pdev->domai=
n.
> This is something that needs to be done by the PCI code itself and
> not relying on each IOMMU callback implementation
>>
>>   My understanding is that the roll-back is
>>> expected to be performed by the toolstack and vpci_assign_device
>>> doesn't prevent that by returning rc. Even more, before we discussed
>>> that it would be good for vpci_assign_device to try recovering from
>>> a possible error early which is done by calling vpci_deassign_device
>>> internally.
>> Yes, but that's only part of it. It at least needs considering what
>> effects have resulted from operations prior to vpci_assign_device().
> Taking into account the code snippet above: what is your expectation
> from this patch with this respect?

You did note the domain_crash() in there, didn't you? The snippet above
still matches the "device not assigned to an alive DomU" criteria (which
can be translated to "no exposure of a device to an untrusted entity in
case of error"). Such domain_crash() uses aren't nice, and I'd prefer to
see them go away, but said property needs to be retained with any
alternative solutions.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Feb 08 10:32:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 10:32:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268027.461797 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHNnV-0005WQ-1W; Tue, 08 Feb 2022 10:32:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268027.461797; Tue, 08 Feb 2022 10:32:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHNnU-0005WH-UO; Tue, 08 Feb 2022 10:32:32 +0000
Received: by outflank-mailman (input) for mailman id 268027;
 Tue, 08 Feb 2022 10:32:32 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1FiY=SX=epam.com=prvs=40383cc40e=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nHNnT-0005W6-UM
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 10:32:32 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6a8b36ed-88ca-11ec-8eb8-a37418f5ba1a;
 Tue, 08 Feb 2022 11:32:30 +0100 (CET)
Received: from pps.filterd (m0174679.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 218A8sDE032547;
 Tue, 8 Feb 2022 10:32:27 GMT
Received: from eur04-vi1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2050.outbound.protection.outlook.com [104.47.14.50])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e3pgk83dn-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Tue, 08 Feb 2022 10:32:27 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by VI1PR0302MB3390.eurprd03.prod.outlook.com (2603:10a6:803:20::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.17; Tue, 8 Feb
 2022 10:32:21 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77%3]) with mapi id 15.20.4951.019; Tue, 8 Feb 2022
 10:32:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6a8b36ed-88ca-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=FQK1aKygvjxnXX6xTW8NjYJtK2e2fTHMDYGKqSTykF7zCmufD6vyjNntV5xVWGlUm0i5v7eIZWu61apSejrJspNp9CWFd+Vxrb9mVqQANl3FISSNwL+uviIjLIiYIhzFsBnJOZfiDjUSpJUfgVt78Uj8qrHIiDY/kD4B1F2ZFuhx42yiiMVpYZyKnovqQ4q3o0u2wC6kGrFkjlBHc/CCGMd3yRtTmSSL2Fdt23k96do+wrhiDN2TwLjQHhNKqJ2FMuZAC4BaOmftxRJ5ZgjblWeav8BdqOwFQnw8TGaDI0Ioi2+3QB18VFhPlW+ac3dA7snJHIJjhnG2mwAo0k4xvg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=uG4b2rQhdAhL/+zIFYHPFUKHkMqS1X24X2vCGEa0rFU=;
 b=Yz7UfPDubc2FZg8gR6IUADuW3xVhN7gieXIMCOuS9/HIkBNCbg/i+FqRctjXWx3Y3AAF7eUSm7R4ZIAdIxbYcDqFql3X6ohLK+m6zqSh1W1bxF6ZJx++kp9UryV1x4uKOEg2D4YoNs1g4INTpDGcBguBpm4o9LZgWZXNAi8k5NUxKsOeNJRZ/lyLMXJHSqquPkYF64ZmMg8CL34a112RyQBnQOwSPvyi+mCf9PFY5pbvsqt0lji7RgP2OTzFdxk7wapnUpko0D8k4nTYZbeZPF078dz1ep98sR76aGSBuoRA9y4ZF8tCMlic3Qm4z2y+WPbJOh3DFDUfliOyqON0nw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=uG4b2rQhdAhL/+zIFYHPFUKHkMqS1X24X2vCGEa0rFU=;
 b=V04dPvepm3K2utIxirD3VtIukaOx8DuUXiCQSwT1bvJxum9DLZ+miHHFuIO/BSoelfBlyfqHIVdNVw/rUDqVmpcOnAGtniFWDW2VizZ4rAf0CGPkWhq4d15Ss/Li8ssr3/IBFO/lkH9bf59fElLFg3El7M7M8VjERIj2ARoje4wJtOQZxKIkKH+J2Vc3OrcnvJunJ2Uu2eo6b7imU5n49IF7bZ3Q+1hMVCWbW+i3W8JV8az+MiMv0sF+qLChshUCdz0U2K57pwoAlYga3vJ+NzvJrOQ/gxAREznInbP9z/ekg8UhKAc0FNxqw/7EijOTcPLuU9k1p/Pc8JhJB0fWsQ==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>,
        Jan Beulich
	<jbeulich@suse.com>
CC: "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Thread-Topic: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Thread-Index: 
 AQHYGZFc/MnzQOjwVEeBBUHLSW0md6yDBUkAgAASSACAAATYAIAAD/WAgAAKNgCAAAbfgIAABnuAgAAQvgCAAAMCAIAAAY4AgAADxICAABrnAIAABAgAgAR3CoCAABt5gIAAEpuAgAAE5ICAAASKAIAAAiiAgAAKNYCAAARNAIAAC1wAgAACRYCAAAGVgIAABJiAgAEmUgCAAAXkgA==
Date: Tue, 8 Feb 2022 10:32:21 +0000
Message-ID: <145d6ab6-dd40-83d5-b8c4-0a995ce25094@epam.com>
References: <9ce90193-74a0-5642-d22b-6b8c3340c3cf@epam.com>
 <1f65ae7a-898d-2c27-0ada-d71d778b0627@suse.com>
 <YgEsRuckQJIQlkzf@Air-de-Roger>
 <a2a42c1d-d379-00cd-5d55-f443cdb02e97@epam.com>
 <e8fc7872-c7d0-f389-c507-335b809ffcbc@epam.com>
 <21c8125a-2f79-1a4a-494c-db9e4be2a1a6@suse.com>
 <4276fe72-558b-7d95-6430-d4330989dbe8@epam.com>
 <ad985f4a-10f0-4a2d-df02-cde915fea3f1@suse.com>
 <f7669670-8eeb-9966-5ba3-e8f9c03ce3d3@epam.com>
 <73e08285-6bb1-5842-899f-bd6502406e49@suse.com>
 <YgJBwrB/qDLSNMIu@Air-de-Roger>
In-Reply-To: <YgJBwrB/qDLSNMIu@Air-de-Roger>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: f7f29d9e-1d9b-4b70-36d4-08d9eaee4a27
x-ms-traffictypediagnostic: VI1PR0302MB3390:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <VI1PR0302MB33905A9372874867DDC7EF29E72D9@VI1PR0302MB3390.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 e/Zno5NHi5gvav423mmSqMjsr9HCDpv1iDgAE12s6H1QZhOvYiMuihHUxTIGahxiJ7qY+/P0VRAED0wKxAVaPv7DWEMXIb80HCEqmYmNtAKy1VuF9nirN8oH09f+fl4JUOmZRYq1l3VKe1Hluv7/UonzNDOH/29jaME9S1/J+Z4rNwq++9Pv09LTYcVwNrSBNlNFf5BDR2pM/uXiLA90zbQLybQgcPjEP+N0flS21X3zlaU6jNOnD4boTH4NwYgH94kmIR405EP/TmoHLDtQht7T5BmgwBwGJULSI2SsiAuwN4eJjO06/Bk9lxk0p6LOm7KjccvqvueIVJ1gVNNziCvkSl2E5NO3F6srCT0j1QwbccW0WMfxN8mTKedGg3SWdmcv2AGkw1waldVyZbQA7JiWZmoKgJf2s1mq8VEtLYOyZwAdMdTm+g9pIns4Rdb4cK+MEIlXbI2LTGyJY3whJfey0/m0SiGSq9ilGVqOixCehEViDlI27udt/cyP39NptB85BufzWY7P92c9VYzUXYrI29XGjakeEwZYAs0XlW/f6y6gvD7rdeghhOLI/5EBTRqG9em0wBPt9O5tyIYD3Osu5nmjJjTIbs5b1wxPP6MK0q05yPq3jRFcmHWL5oPysjSmplpCxRHEQ+9+lsCacmERQwrbSm6Xp7sTjbJrlRs7HDSD/FvNAFXkzU4eNcsyGds/HFfLGItt91+m+IoT+TETkxtV2DLNhsc0mP5LRdkq70xWOl5E3/nceNnOLxjA
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(26005)(38070700005)(53546011)(6506007)(55236004)(316002)(7416002)(31686004)(122000001)(508600001)(38100700002)(6486002)(5660300002)(36756003)(4326008)(31696002)(91956017)(186003)(54906003)(64756008)(8676002)(71200400001)(66946007)(76116006)(66446008)(86362001)(66476007)(2616005)(2906002)(110136005)(107886003)(6512007)(83380400001)(66556008)(8936002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?NzlhTlhtbUJZUXhVaEdJV25yNUEwbE9IbWR5Vm9UTlExRENVL2tWU2d0WCtw?=
 =?utf-8?B?bmVUUHR0d2pEeTJqL203c1kzUFZQSmh3bDZrZzh3ZDU5NEpnUTFsaUZlNnJ1?=
 =?utf-8?B?eFlUMllhQURxNHZQekoyMnBSUFpUNnc1Z255UER5UXVpVjdmUFdNZkVqZ3Zp?=
 =?utf-8?B?OWN4TS92V0E1QVF3b0VETUd2a2hjeGF6MnhuYmVnbzdvbDZwc3ZXWEo1S05D?=
 =?utf-8?B?VmZHeDJSVUplVTlPaHA1eis4SWF6UXpzWlc5SFA4enJUeUUrTzJuS3FnaDlx?=
 =?utf-8?B?UjlBb1BUMW9lcHNFVStNV3UxU1RMeUJnaHZnbXV2Zy8yU2FEU1BwaDdBblNi?=
 =?utf-8?B?eHJUbjR5RUJXbXdMWkpHaGRDT0lZbDFHbUZsbkVUc2p3VE9Ga3hhTHorVEVZ?=
 =?utf-8?B?TGtTZnhDZUhLeS9wcHZYRlNMVXd6NGJPL1MvaDkwRGl0S2JIeWZRNGZ6VnNZ?=
 =?utf-8?B?dG5lNkdWaytJQUxlTTFDTUxRT2paeWo4d2o3c2NEbGEvRTI3Tnhpdkt2VmdH?=
 =?utf-8?B?N1JDUWRIbUUyOHhLSi81NzdwdGRzNW9UOSt2S084Z29IYUlpVjRoYTY3NUYv?=
 =?utf-8?B?WDY5TWtwSHNwYlpSQVRjSTMxMjN6c1ovYUxzNXZidGhEdEVjZlpuTU5kb3g4?=
 =?utf-8?B?aGxBdVI0ZmQxN3FsWUhab3VVWTh0dDhvdGhEK3VLS0ZqeHByT29sd2EweFBy?=
 =?utf-8?B?T2ozNmdaNlJ0ZGtmS29LTndHbm10VTBaNUlNb2txL1J0ajdKYytySkozNzJB?=
 =?utf-8?B?T2g3Mm1HbjRqZVh1QkZiSHBwak9ISjhCZVUyc0VBdTRiN2FFSFg5S0dpeU9I?=
 =?utf-8?B?TnFGZ2tMa203bk04SE1GSmUyait1MGp6Uk5KMG5UbnRPcFdETEtUZGMrSUxH?=
 =?utf-8?B?RjFaYTZZUDdUL09lL3ZHOWZ2WWtOekZwRmk0UldSQWpTZ1FwNWlPSE1FbVpE?=
 =?utf-8?B?REo5N3VnV1UvRi9pTU8vM0dMYjAxMEJtbVNsOVpuRWltZHphTzNXZGlLdkpK?=
 =?utf-8?B?SE5ucmdSYjhGMFM1V3htcnY5RSt6cE02RmNIeERSSGJ2OUkzaVgrYzZFQS9k?=
 =?utf-8?B?dkhHSHZ0c0lCSjhKTlhnc3lVNlVjTWpxeDFvdmxhMzh0V3J1ZnQyOEhBeXA5?=
 =?utf-8?B?U2sybVozUlhEVmVEY1FZWDZoalJpWmo3YllodHp1YUZSSnhVVStXVUh2TjJo?=
 =?utf-8?B?RmNQc2F5Y2lQVzhnZnNSVEgyNkFZQncyYnQ2Z0Y0OUVWU1JTamNFTmU4Nkh6?=
 =?utf-8?B?SGdickJXUXAxUVZmOUlmbUpDUzNoR2hocERWSlhCVWF5R0tER2VINnFvNkFr?=
 =?utf-8?B?SU9jUWpuSXZSdlBHaSsxL0ptRzB1OFdQVWFHeHRLcmtYSkpmV0RPZ0kyZVJJ?=
 =?utf-8?B?UVo4bDBhVkdpZXVPaXJya29YMkFzZnFhVEhxT1BQMU5jdnR2dU1waENnUk00?=
 =?utf-8?B?c2Y0NHVrSHpUKzdHdzR4OTlKRlF6aXNzYTBzTXJQVXRFRW5mOUJkRjdiSitE?=
 =?utf-8?B?a3Q3YmtHTmxIbkpZNmdVdXAzcXRpUzd6eHZ5WHZkbFFrNllDSUlNWmNaZWxv?=
 =?utf-8?B?NlByemN4QU1taThuSER5QzJxbXlOWmFsV3UyUC9nRXdDYms2MkN4cHhoVGVm?=
 =?utf-8?B?Q1RsQW5CL1NYZHV1U1RjY2dlQWFtMGZwdmZkMWpNWmtaTWFEUUtCeC9nYlFT?=
 =?utf-8?B?UGRGeHpKRkR3WjJRNFcxLzRwK0huTmEyeTViSUxhZ3lUVG5Vc0xvdDhHaktq?=
 =?utf-8?B?cXNCdXpCbkt0Q0FmU2NmQi9Bb2doNlBITFRxeU4ycUgyNFdvTUVvYTZTQ0Zr?=
 =?utf-8?B?YXBaWFJ0bXJtbFJ1eHd1RldIQm9JYmxCcitTbjFCaW1lWnVmSUJPV3IwS0tp?=
 =?utf-8?B?NCtFTjErRzNwQVF4eERCTWFSTXUrUXd4UW0zUDhlVXM2YVVaenc3Q0MvUU1x?=
 =?utf-8?B?K3o5WG12cUxnTElKL1c2MWFTTjJ3MS9pZ0h3ZGpTcmllVDBtRnMzT2pURXNZ?=
 =?utf-8?B?V2U2bEJYRnMzSHg1eUVjSlRkUjJOVXhoZVFqRXBWNEVEcTNJbk9ZM0NrdXFw?=
 =?utf-8?B?TEdFZjJ5WWlhdmE1U2xBL3Q4YWxuYmhrUXhpY2Y2bjRFdzJoOFJGR3lmRmxs?=
 =?utf-8?B?cXR4bEFYb1VLbjMvdW4xdmRZQ3Q2WnY2M0RCcGxVYXB2RVFyTlFETjdPU29K?=
 =?utf-8?B?R1VVMXlIalEvYUs2SENoRitDUVVKa1ZyZVEyMkp3cVBaZUl2WUVGM0ZqSEpC?=
 =?utf-8?B?b0pIbVp0TUFGMUJlbytuejhrb2NXeThacmx1eGhWZ3hvNm0za3BiRVEwOUhy?=
 =?utf-8?B?emhHMkVCK0R2Nm9yNXJyNnBvZGtOQ2p3dC8ybHlQOTNyelZ3d0lvbW54WHFU?=
 =?utf-8?Q?xUv3Qe1tbMRFgGCU=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <1C3120A237DC15478708B30622BF91C7@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f7f29d9e-1d9b-4b70-36d4-08d9eaee4a27
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2022 10:32:21.5898
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: pkiQg9OOf3TwbHRmaEOIZZpZ02vx9oA41DGSsFszrTNtkFYELrsDzuGfmo69X8PaYSKOxGXZo7EE4GhgfKJG5BbzIbejtlZMpWUJHseBZkrH40yaN7IPx2Qv6EhFkyZD
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0302MB3390
X-Proofpoint-GUID: Kr75HjdOEk-8g4v-lmDMfsNvMTiac6Uw
X-Proofpoint-ORIG-GUID: Kr75HjdOEk-8g4v-lmDMfsNvMTiac6Uw
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-08_02,2022-02-07_02,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501
 suspectscore=0 spamscore=0 impostorscore=0 lowpriorityscore=0
 clxscore=1015 mlxlogscore=887 adultscore=0 mlxscore=0 phishscore=0
 bulkscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202080060

DQoNCk9uIDA4LjAyLjIyIDEyOjExLCBSb2dlciBQYXUgTW9ubsOpIHdyb3RlOg0KPiBPbiBNb24s
IEZlYiAwNywgMjAyMiBhdCAwNTozNzo0OVBNICswMTAwLCBKYW4gQmV1bGljaCB3cm90ZToNCj4+
IE9uIDA3LjAyLjIwMjIgMTc6MjEsIE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4+
DQo+Pj4gT24gMDcuMDIuMjIgMTg6MTUsIEphbiBCZXVsaWNoIHdyb3RlOg0KPj4+PiBPbiAwNy4w
Mi4yMDIyIDE3OjA3LCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyB3cm90ZToNCj4+Pj4+IE9uIDA3
LjAyLjIyIDE3OjI2LCBKYW4gQmV1bGljaCB3cm90ZToNCj4+Pj4+PiAxYi4gTWFrZSB2cGNpX3dy
aXRlIHVzZSB3cml0ZSBsb2NrIGZvciB3cml0ZXMgdG8gY29tbWFuZCByZWdpc3RlciBhbmQgQkFS
cw0KPj4+Pj4+IG9ubHk7IGtlZXAgdXNpbmcgdGhlIHJlYWQgbG9jayBmb3IgYWxsIG90aGVyIHdy
aXRlcy4NCj4+Pj4+IEkgYW0gbm90IHF1aXRlIHN1cmUgaG93IHRvIGRvIHRoYXQuIERvIHlvdSBt
ZWFuIHNvbWV0aGluZyBsaWtlOg0KPj4+Pj4gdm9pZCB2cGNpX3dyaXRlKHBjaV9zYmRmX3Qgc2Jk
ZiwgdW5zaWduZWQgaW50IHJlZywgdW5zaWduZWQgaW50IHNpemUsDQo+Pj4+PiAgICDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgdWludDMyX3QgZGF0YSkNCj4+Pj4+IFtzbmlwXQ0KPj4+
Pj4gICAgwqDCoMKgIGxpc3RfZm9yX2VhY2hfZW50cnkgKCByLCAmcGRldi0+dnBjaS0+aGFuZGxl
cnMsIG5vZGUgKQ0KPj4+Pj4gew0KPj4+Pj4gW3NuaXBdDQo+Pj4+PiAgICDCoMKgwqAgaWYgKCBy
LT5uZWVkc193cml0ZV9sb2NrKQ0KPj4+Pj4gICAgwqDCoMKgIMKgwqDCoCB3cml0ZV9sb2NrKGQt
PnZwY2lfbG9jaykNCj4+Pj4+ICAgIMKgwqDCoCBlbHNlDQo+Pj4+PiAgICDCoMKgwqAgwqDCoMKg
IHJlYWRfbG9jayhkLT52cGNpX2xvY2spDQo+Pj4+PiAuLi4uDQo+Pj4+Pg0KPj4+Pj4gQW5kIHBy
b3ZpZGUgcncgYXMgYW4gYXJndW1lbnQgdG86DQo+Pj4+Pg0KPj4+Pj4gaW50IHZwY2lfYWRkX3Jl
Z2lzdGVyKHN0cnVjdCB2cGNpICp2cGNpLCB2cGNpX3JlYWRfdCAqcmVhZF9oYW5kbGVyLA0KPj4+
Pj4gICAgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHZwY2lfd3Jp
dGVfdCAqd3JpdGVfaGFuZGxlciwgdW5zaWduZWQgaW50IG9mZnNldCwNCj4+Pj4+ICAgIMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB1bnNpZ25lZCBpbnQgc2l6ZSwg
dm9pZCAqZGF0YSwgLS0tPj4+IGJvb2wgd3JpdGVfcGF0aCA8PDwtLS0tLSkNCj4+Pj4+DQo+Pj4+
PiBJcyB0aGlzIHdoYXQgeW91IG1lYW4/DQo+Pj4+IFRoaXMgc291bmRzIG92ZXJseSBjb21wbGlj
YXRlZC4gWW91IGNhbiBkZXJpdmUgbG9jYWxseSBpbiB2cGNpX3dyaXRlKCksDQo+Pj4+IGZyb20g
anVzdCBpdHMgInJlZyIgYW5kICJzaXplIiBwYXJhbWV0ZXJzLCB3aGV0aGVyIHRoZSBsb2NrIG5l
ZWRzIHRha2luZw0KPj4+PiBpbiB3cml0ZSBtb2RlLg0KPj4+IFllcywgSSBzdGFydGVkIHdyaXRp
bmcgYSByZXBseSB3aXRoIHRoYXQuIFNvLCB0aGUgc3VtbWFyeSAoUk9NDQo+Pj4gcG9zaXRpb24g
ZGVwZW5kcyBvbiBoZWFkZXIgdHlwZSk6DQo+Pj4gaWYgKCAocmVnID09IFBDSV9DT01NQU5EKSB8
fCAocmVnID09IFJPTSkgKQ0KPj4+IHsNCj4+PiAgIMKgwqDCoCByZWFkIFBDSV9DT01NQU5EIGFu
ZCBzZWUgaWYgbWVtb3J5IG9yIElPIGRlY29kaW5nIGFyZSBlbmFibGVkLg0KPj4+ICAgwqDCoMKg
IGlmICggZW5hYmxlZCApDQo+Pj4gICDCoMKgwqAgwqDCoMKgIHdyaXRlX2xvY2soZC0+dnBjaV9s
b2NrKQ0KPj4+ICAgwqDCoMKgIGVsc2UNCj4+PiAgIMKgwqDCoCDCoMKgwqAgcmVhZF9sb2NrKGQt
PnZwY2lfbG9jaykNCj4+PiB9DQo+PiBIbW0sIHllcywgeW91IGNhbiBhY3R1YWxseSBnZXQgYXdh
eSB3aXRob3V0IHVzaW5nICJzaXplIiwgc2luY2UgYm90aA0KPj4gY29tbWFuZCByZWdpc3RlciBh
bmQgUk9NIEJBUiBhcmUgMzItYml0IGFsaWduZWQgcmVnaXN0ZXJzLCBhbmQgNjQtYml0DQo+PiBh
Y2Nlc3NlcyBnZXQgc3BsaXQgaW4gdnBjaV9lY2FtX3dyaXRlKCkuDQo+Pg0KPj4gRm9yIHRoZSBj
b21tYW5kIHJlZ2lzdGVyIHRoZSBtZW1vcnktIC8gSU8tZGVjb2RpbmctZW5hYmxlZCBjaGVjayBt
YXkNCj4+IGVuZCB1cCBhIGxpdHRsZSBtb3JlIGNvbXBsaWNhdGVkLCBhcyB0aGUgdmFsdWUgdG8g
YmUgd3JpdHRlbiBhbHNvDQo+PiBtYXR0ZXJzLiBNYXliZSByZWFkIHRoZSBjb21tYW5kIHJlZ2lz
dGVyIG9ubHkgZm9yIHRoZSBST00gQkFSIHdyaXRlLA0KPj4gdXNpbmcgdGhlIHdyaXRlIGxvY2sg
dW5pZm9ybWx5IGZvciBhbGwgY29tbWFuZCByZWdpc3RlciB3cml0ZXM/DQo+Pg0KPj4+IERvIHlv
dSBhbHNvIHRoaW5rIHdlIGNhbiBkcm9wIHBkZXYtPnZwY2kgKG9yIGN1cnJlbnRseSBwZGV2LT52
cGNpLT5sb2NrKQ0KPj4+IGF0IGFsbCB0aGVuPw0KPj4gSSBoYXZlbid0IGxvb2tlZCBhdCB0aGlz
IGluIGFueSBkZXRhaWwsIHNvcnJ5LiBJdCBzb3VuZHMgcG9zc2libGUsDQo+PiB5ZXMuDQo+IEFG
QUlDVCB5b3Ugc2hvdWxkIGF2b2lkIHRha2luZyB0aGUgcGVyLWRldmljZSB2cGNpIGxvY2sgd2hl
biB5b3UgdGFrZQ0KPiB0aGUgcGVyLWRvbWFpbiBsb2NrIGluIHdyaXRlIG1vZGUuIE90aGVyd2lz
ZSB5b3Ugc3RpbGwgbmVlZCB0aGUNCj4gcGVyLWRldmljZSB2cGNpIGxvY2sgaW4gb3JkZXIgdG8g
a2VlcCBjb25zaXN0ZW5jeSBiZXR3ZWVuIGNvbmN1cnJlbnQNCj4gYWNjZXNzZXMgdG8gdGhlIGRl
dmljZSByZWdpc3RlcnMuDQpJIGhhdmUgc2VudCBhbiBlLW1haWwgdGhpcyBtb3JuaW5nIGRlc2Ny
aWJpbmcgcG9zc2libGUgbG9ja2luZyBzY2hlbWVzLg0KQ291bGQgd2UgcGxlYXNlIG1vdmUgdGhl
cmUgYW5kIGNvbnRpbnVlIGlmIHlvdSBkb24ndCBtaW5kPw0KPg0KPiBUaGFua3MsIFJvZ2VyLg0K
VGhhbmsgeW91IGluIGFkdmFuY2UsDQpPbGVrc2FuZHI=


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 10:40:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 10:40:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268040.461807 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHNui-0006Hb-Ul; Tue, 08 Feb 2022 10:40:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268040.461807; Tue, 08 Feb 2022 10:40:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHNui-0006HU-Rn; Tue, 08 Feb 2022 10:40:00 +0000
Received: by outflank-mailman (input) for mailman id 268040;
 Tue, 08 Feb 2022 10:39:59 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=v7zX=SX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nHNuh-0006HO-6L
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 10:39:59 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 75c50817-88cb-11ec-8f75-fffcc8bd4f1a;
 Tue, 08 Feb 2022 11:39:57 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2176.outbound.protection.outlook.com [104.47.17.176]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-22-bkYSXrkJOm-zpi7vNX0q5A-2; Tue, 08 Feb 2022 11:39:56 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DB8PR04MB5916.eurprd04.prod.outlook.com (2603:10a6:10:ac::28) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Tue, 8 Feb
 2022 10:39:53 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.018; Tue, 8 Feb 2022
 10:39:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 75c50817-88cb-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644316797;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=We+/9PJvRCZvDc34BOX57wPXZ59QeRYsuicLvS49KkU=;
	b=CJcotAq9D4Lsm7lYI4aR6W8L4Rv5tCs2gYF7cJm7nS+ZRWVtYwrQJRD+4+BWSd9ugzQAg+
	4jRlYTKf9wg7qWarkrIEzmkLs+dah3/q9ay23Vh9L7C/MyeH80hmIjsAMvLoPMIphhyfTL
	BINzHjqpdu+Y2oeDTQgkqD2IDj3PDRg=
X-MC-Unique: bkYSXrkJOm-zpi7vNX0q5A-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Al7ztWm55OAJZtndDyuhvKXxB2L8SJGn+M91jN7Sv52IORRyu/l1EqFJ5HTk5l9aPu7XRU2vf4DtK74ZKbaYOZiEVtT5/r6MpNR249pPDm89L5uRRSdroJ50NLMSAIpq+2jsHV47CPLw2zRNRKrASgoFldYahtYHTRWE5y5iIShqwqggDyln+4uyG4f+jXqgAWTUPwdAB6zDgdJbrqt6svax4OT7oAk/7cJF6PcJGgyZXK82x2/HEUL0zkeZ3Y7fJoTMGLq0sYJJ4oOJj5hPuzNLQRBtaDLS2oEe4Flu8nHkOUT1mRGpNxdpthJ0ynoH9RBEw5JhNYFSmTf5zwAvQg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Vd1VaDjpbI2hRQzr5iRCea8XSbAtrqZ6+wGWKwIkp/0=;
 b=kpfl+kYtS+sGnEYTiQHHlkToJCyO8ZUtKIgR3OPBDIuyt0CX8dGUGPOXjAvcahlgO6MixnyiXldN8WEAMrQwGWZKAkCUkgPqBmBdwrH4eI1N6t4MLWQ5pjQwmkGahA8AwJlYIWNu+wCh7C64JZkuD8KfgX2ER9h4jYeCO2E6qMPfD47ejwv7qdcJ6AsYh7MDyjkTeic432FZZ1jKVNVqywIRXBLNEulYunFL1EDTsaOlQ4b9jhzNl78ziuodokiO1NXSOGuXHxIf87AUPQOWlb7e3hp2kt5Zz99DQwCkCpprmy5gXL2XeFlqBtVbnM92JDjt1stoiKgtkiIHvQLYHA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <2b78482c-64fc-e608-b8a3-f906c23420ba@suse.com>
Date: Tue, 8 Feb 2022 11:39:51 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH] xen/smp: Speed up on_selected_cpus()
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
CC: Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>,
 Juergen Gross <jgross@suse.com>, Stefano Stabellini
 <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20220204203115.13290-1-andrew.cooper3@citrix.com>
 <613d2033-47ba-1f67-9d90-322caeaef5dc@suse.com>
 <7805e1a3-e80b-91e9-afd3-aa3b1f93afef@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <7805e1a3-e80b-91e9-afd3-aa3b1f93afef@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM5P194CA0010.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:203:8f::20) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 05b337ae-feb5-46d5-7974-08d9eaef5760
X-MS-TrafficTypeDiagnostic: DB8PR04MB5916:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<DB8PR04MB591653A9BBE85EBC48C0CCC8B32D9@DB8PR04MB5916.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	S0404qK27pkQS8mNP8zFkN/Id0/WarsZWjjyqjw5Ejv15wFIWxxT4PpjxXuELgdvnAezf/ZkJifY/RYLn3k8pHMoFt0x+D+bWWgrsWtG8wKgG5jwl9FWjw643GsK7x4rpbxchUM7/ejyKUrpJn62UcMjQS+Zs6Mrb68zoz/BsVjxjoY4j/VjKQTd+rJ2/OmAWyhWpIW/3ddXLXIrRlU66/a4KUduf1vySNuWB3WMN2NC0WkIKK//1O4EYlpKeYtPg1bNr0OxLWov2kzT8B0eH8Lk/LmJcDxSLVe1XaJwbU767NWtj0VxzDSWmtXG7uczdDwGnUdG4aJ2gOHfcnE/M0HM5cUNwDvApcGyQeTCHudXL2+EFuQ6fIfbMPTtUkXjvCKljFtN91cetlE+Zz3hd36cVSi2FFXVkXyWXjwQV9Vlvayt7QPszJPaCwQ2aUfg7s2Vj9WGJt1ZGAQ4ywy6gowzaOL5u0pYKWDA/R5L1Gn5S4rAzRN7N5gR+hiCFvsaD9e+mCBNJYj4J/nm/xpPXrpoOuvdyHFk7hYpb6m9mzds2/OmuKV3VLo5RGKENf5nUVHyFhpuISLKvA1CHE1XTsFMo0a3xJrG97csKfC5DKIxedb1aS8Bk3804Q8ke07t8i4kMjUbmyqC6wSkuF03AkrPZmW+NXpTjELWF3f6+GvEHQ0kD1Zftcvh9CvppDOHj3pWJ9Wz+DAGM/rLSjzrloWMI+RaOb1LUn4SluKaHcM=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(36756003)(2906002)(26005)(186003)(38100700002)(2616005)(31686004)(6506007)(86362001)(8676002)(8936002)(66556008)(66946007)(6486002)(53546011)(4326008)(54906003)(31696002)(508600001)(6512007)(316002)(6916009)(66476007)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?HzVwPqA+ev8fkugXVngptpt1Z97gyuGWUCbkxvx7aXwraNj1pZdGCCk+WKUN?=
 =?us-ascii?Q?+II/VsE4kdOWBxb4ELmXNzGBAPYqhvsilNWProA6pAV8djontLgd4jy1b6lL?=
 =?us-ascii?Q?aF/7prN29u0AVOK6Ix9aaIwgL73jfo2BdMcVYwpZ7ZYOly/QodZQdlH5gj2w?=
 =?us-ascii?Q?yR+Ugo5qVddFTCbY35ZMT+emDZMldWAxuJmKm06mCh54hoXsmsG4yNPc0Hku?=
 =?us-ascii?Q?kY7zKCW+tNmGKNbVE4UZRSDxhQwhm+tI/WyJH9tO2Sw1GFeLIrWZWhE0h+kI?=
 =?us-ascii?Q?9jUnOQkwsMAOa/DiC7p31a6/INJQuSVEI8Ur7xAJKckyBUT7hXHmqPGYQc8w?=
 =?us-ascii?Q?U45O1rPCV0QgsrtKj81NXMXiVxVVra+BtcSVnnAUPVITFTAHVLkqfmw1wvhs?=
 =?us-ascii?Q?vsiuLy1Rj5ZLgD82AKrKoyKInZy21+OtYkQszJ/8xwTuWjk2agocnozxJoM6?=
 =?us-ascii?Q?Bog+1mFSKjKBpU4GYGBuXVX8UVkS8FGdUSGRT5Ta3134mWO24Hgd9Frn9hZp?=
 =?us-ascii?Q?HSHPqxweW36NjhDPnNFYELc6pBXMUD/EEgXeqy5Z/55+KxBkAstlOXB2hMvw?=
 =?us-ascii?Q?nOD1FuTHN02XspOgh4lL/SVB6tVyNIikh7h0oma5NqYUm95kM2yvRZ+SFGfH?=
 =?us-ascii?Q?id0+4PPY3xwCDHGfeeZYTbs8l0/5hEWh+cPTKRBH2EuNuSAov4pwIrXlEEj0?=
 =?us-ascii?Q?L7hbGs1OYfTqDKoCnyD49TSEzwG/qzL/BJ0/3ayuRPyBvzW6/l7fmVSvoMkz?=
 =?us-ascii?Q?dEdZOwTm5ync8Adq9+FqPzbzLU4wGwgbuT3F0RjY/IKMVnj/q5IthLunbmCl?=
 =?us-ascii?Q?qqvceBfpco7n8hFFIoyk9pDeePm1SInF5uOAXyB0medbUKNKDO63T2ASbiG7?=
 =?us-ascii?Q?HxNURnk+0wlHraaL9cqai7xaEwCfYa8K1jQ7JONGISDYJusqQWieROqxOHXH?=
 =?us-ascii?Q?xkPEljW7h+HKAOdJfKeCct5Z/uu3jrVwmYrvvP2zG1rhxc9j3xsBoQyc80el?=
 =?us-ascii?Q?IuS1wba2C9uiUV4QfCnkoe1toOTpfpOpDLAVWsZOFY72pAPqwK40xXLlfHvL?=
 =?us-ascii?Q?im7VamcaKYgOlhWw8IGa2IGyxlPfcq+vEzEIqZT9Jb1Wb6x6SqI2VTQiEw02?=
 =?us-ascii?Q?/R82XH5OGiPlsrPSccd4+bqY6ekJK5VSaRvYSoFYyKXTRNhkV32M8KszyzTi?=
 =?us-ascii?Q?gLwtzN0WBTe0LzTS2/lWXiUyoOVn98X4lcEMWDnfIOR/BbFJv8EmRVemIGgU?=
 =?us-ascii?Q?rtF9/r3FzPKoDmnNffjk5Q0R6MOGhsWdnM4+3szwumzePfDzFH4ZeQC8vpft?=
 =?us-ascii?Q?5ntFt2PSGgP8ois/dqJImiuF1grRsDGLl+gfeHsyqdkDlW0ceu6kLnIHt49d?=
 =?us-ascii?Q?zWBsCNwnW8ge7a/DhnHdYgObncFmlAdkGDZrzkha7YsceJ9g3rWYSan/TKNK?=
 =?us-ascii?Q?zjF6Ocq01m9Rw54lF4KNDnaKK2UfiGCBBQPDpVku6Y7iN4EMS7MuW14pQWGM?=
 =?us-ascii?Q?xp5D5Jh18z+gjD4o+iCDlEOaC357fxBnIEAVoEZHSF0xKE6Rih5rb3FPdEb6?=
 =?us-ascii?Q?V9gWPd4sZL5ddGU3v9cOoEcnO2qUsib/K9cG1YvK3jkwFC1qlT/jWVPHQ4tc?=
 =?us-ascii?Q?HChV0CmIGrQbINxiQAXfOvA=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 05b337ae-feb5-46d5-7974-08d9eaef5760
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2022 10:39:53.5065
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KOoMhzivXM6/eHIUvNuCnjnGyWf8bA6FRgYnfvc+SbxU12ixqltNSm4XfM2G9cwi3OcbeVE6TqlAfBkL6Ks+BQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB5916

On 07.02.2022 18:06, Andrew Cooper wrote:
> On 07/02/2022 08:11, Jan Beulich wrote:
>>  (And of
>> course I still have that conversion to POPCNT alternatives patching pend=
ing,
>> where Roger did ask for some re-work in reply to v2, but where it has
>> remained unclear whether investing time into that wouldn't be in vein,
>> considering some of your replies on v1. Thus would have further shrunk t=
he
>> difference, without me meaning to say the change here isn't a good one.)
>=20
> There is a perfectly clear and simple way forward.=C2=A0 It's the one whi=
ch
> doesn't fight the optimiser and actively regress the code generation in
> the calling functions, and add an unreasonable quantity technical debt
> into the marginal paths.
>=20
> I will ack a version where you're not adding complexity for negative gain=
s.

Thanks, at least some form of a reply. I'm afraid I can't really translate
this to which parts of the change you'd be okay with and which parts need
changing. I didn't think I would "fight the optimiser and actively regress
the code generation in the calling functions" in v2 (this may have been
different in v1, but I haven't gone back to check; I wonder though whether
you're mixing this with e.g. the BMI patching series I've long given up on)=
.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Feb 08 10:40:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 10:40:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268041.461819 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHNuq-0007JP-7s; Tue, 08 Feb 2022 10:40:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268041.461819; Tue, 08 Feb 2022 10:40:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHNuq-0007JI-4Y; Tue, 08 Feb 2022 10:40:08 +0000
Received: by outflank-mailman (input) for mailman id 268041;
 Tue, 08 Feb 2022 10:40:07 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JWzo=SX=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nHNup-0007HH-IQ
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 10:40:07 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 797fb503-88cb-11ec-8eb8-a37418f5ba1a;
 Tue, 08 Feb 2022 11:40:05 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 797fb503-88cb-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644316805;
  h=from:to:cc:subject:date:message-id:mime-version:
   content-transfer-encoding;
  bh=o6LAi5k9kIMQVtfQ1ANsXvEZoGV9yoKiE2aDjv2j9KU=;
  b=REVs6jniHoOg5KSnNYj/Ntm8pLXLL1XVtsPGiFBEz8snVunDkwO5Rpuk
   HXQUvhldi7/vL4KS4wZpuJbIivt9oczHTYg0jFbA56wNb6Mqdy9rhXzng
   JLrkeontxKtdlU7PtpvdHqBAAZzjMo7gtHnUB5MwyEpH3bvEl+8Qjsi6Y
   U=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: zN4BILz64xqwJE1HWzpP432ysx6wKH1U4VdAuhDrwiWcuC5u88DdhPuJUiYERDBo1o97L+RN7i
 lzI7A6bv0VaPu7WcG5qHiZ9aX+Q3xNclQw9Ti2sDJU0BG6so4t5Sk7wvSyCn4t1qttpMC+gIN9
 wdB8E0c+XuGO8ScpnzDpbkqZhmA3kYqdTN4ZYASwVKfaCWDK9iC/KqbtRyUiY18LpT6gFp9FCq
 MKBO4TbvlylyPcsj5gCZalVuL1B4rVLJ5KFMnxXjBrfeAsE5/9fomIzEJ/hgqu18d4fWuQax7R
 tJSRLYkMRKipXt5ETU1iAkAG
X-SBRS: 5.1
X-MesageID: 63719882
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:dpkNI6wcrHtkYsC1+KR6t+fxwSrEfRIJ4+MujC+fZmUNrF6WrkUAz
 jMWDTuDbv/cZTekKdl+aI6/o0gA65DUmIQwSwA/qiAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAhLeNYYH1500g7wbZp2tcAbeWRWGthh
 /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL
 wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt9pa7
 Y5q5ZaicDUCOYz+qsgzciIANAgraMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr
 6ZBbmlQMFbT3Ipaw5riIgVors0lMMnsOpJZonx6xCvVJf0nXYrCU+PB4towMDIY2JsRRKeON
 5BxhTxHYk3MWgNTBk4sC6k+lre3lkTZXzpztwfAzUYwyzeKl1EguFT3C/LXdcaNXt59hVuDq
 yTN+GGRKg4eHMySz3yC6H3Erv/Cm2b3VZwfEJW89+V2mxuDy2oLEhoUWFCn5/6jhSaDt8l3c
 hJOvHB09O5rqRLtHoKVswCETGCstDU5AP0AGf8D2iqK65jmzyi4PTAjZ2sUADA5j/MeSTsv3
 16PutrmAz1zrbGYIU6gGqeoQSCaYnZMczJbDcMQZU5cuoS4/tlv5v7aZos7SMaIYsvJ9SYcK
 txghAw3nP0tgMECzM1XFniX0mv39vAlouPYjzg7v15JDCskPuZJhKTysDA3CMqsy67DHzG8U
 IAswZT20Qz3JcjleNaxaOsMBqq1wP2OLSfRh1Vid7F4qWjxoi/6JN4BumglTKuMDirjUWW4C
 HI/RCsLvMMDVJdURfMfj32N5zQCkvG7SIWNugH8ZdtSeJlhHDJrDwk1DXN8K1vFyRB2+YlmY
 M/zWZ/1UR4yVPQ2pBLrFrx1+eJ6mUgWmziJLbillEvP7FZrTCPMIVvzGADVNb5RAWLtiFi9z
 uuzwOPQk0oGC7ClMnCMmWPRRHhTRUUG6VnNg5Q/Xoa+zsBOQgnN0tfdnuEsfZJLhaNQmrua9
 32xQBYAmlH+mWfGOUOBbXU6MOHjWpN2rHQaOy0wPAn3hyh/MNj3tKpPJYEqebQH9fB4yaImR
 fcyZMjdUO9ETS7K+mpBYMCl/pBibhmimSmHIzGhPGokZ5dlSgGQoo3kcwLj+TMgFC2yscdi8
 bSs2hmCGcgIRhh4DdaQY/WqlgvjsX8YkeN0fk3JPtgMJxm8rNk0c3T816ZlLdsNJBPPwiqh+
 zyXWRpI9/PQp4IV8cXSgfzWpYmeDOYjTFFRGHPW7OjqOHCCrHaj24JJTM2BYSvZCDHv4Kyna
 OhYk6P8PfkAkAoYuoZwCe82n6c35t+prL5G1AV0Wn7Mag3zWL9nJ3CH2+hJt7FMmeAF6VfnB
 BrX94kII6iNNePkDEUVdVgsYem03P0JniXfsKYuK0Lg6S4rpLeKXC2+5fVXZPCx+FetDL4Y/
 A==
IronPort-HdrOrdr: A9a23:+zRYAaxIAKv2HtVrVGa7KrPwJr1zdoMgy1knxilNoRw8SKOlfq
 eV7ZEmPH7P+VEssR4b+OxoVJPsfZq+z+8W3WByB9eftWDd0QPCRr2KhbGSpwEIcBeRygcy78
 tdmtBFeb7NMWQ=
X-IronPort-AV: E=Sophos;i="5.88,352,1635220800"; 
   d="scan'208";a="63719882"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@citrix.com>, Wei Liu <wl@xen.org>, "Juergen
 Gross" <jgross@suse.com>
Subject: [XEN PATCH] tools/libs: Fix build dependencies
Date: Tue, 8 Feb 2022 10:39:59 +0000
Message-ID: <20220208103959.21102-1-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

Some libs' Makefile aren't loading the dependencies files *.d2.

We can load them from "libs.mk" as none of the Makefile here are
changing $(DEPS) or $(DEPS_INCLUDE) so it is fine to move the
"include" to "libs.mk".

As a little improvement, don't load the dependencies files (and thus
avoid regenerating the *.d2 files) during `make clean`.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 tools/libs/ctrl/Makefile  | 2 --
 tools/libs/guest/Makefile | 2 --
 tools/libs/light/Makefile | 2 --
 tools/libs/stat/Makefile  | 2 --
 tools/libs/store/Makefile | 2 --
 tools/libs/util/Makefile  | 2 --
 tools/libs/vchan/Makefile | 1 -
 tools/libs/libs.mk        | 4 ++++
 8 files changed, 4 insertions(+), 13 deletions(-)

diff --git a/tools/libs/ctrl/Makefile b/tools/libs/ctrl/Makefile
index 5d866b8d04..ef7362327f 100644
--- a/tools/libs/ctrl/Makefile
+++ b/tools/libs/ctrl/Makefile
@@ -54,8 +54,6 @@ NO_HEADERS_CHK := y
 
 include $(XEN_ROOT)/tools/libs/libs.mk
 
--include $(DEPS_INCLUDE)
-
 clean: cleanlocal
 
 .PHONY: cleanlocal
diff --git a/tools/libs/guest/Makefile b/tools/libs/guest/Makefile
index 8f5f3acd21..7f74ac0e7d 100644
--- a/tools/libs/guest/Makefile
+++ b/tools/libs/guest/Makefile
@@ -106,8 +106,6 @@ include $(XEN_ROOT)/tools/libs/libs.mk
 libxenguest.so.$(MAJOR).$(MINOR): COMPRESSION_LIBS = $(filter -l%,$(zlib-options))
 libxenguest.so.$(MAJOR).$(MINOR): APPEND_LDFLAGS += $(COMPRESSION_LIBS) -lz
 
--include $(DEPS_INCLUDE)
-
 .PHONY: cleanlocal
 cleanlocal:
 	rm -f libxenguest.map
diff --git a/tools/libs/light/Makefile b/tools/libs/light/Makefile
index be32d95d39..35685ab7ee 100644
--- a/tools/libs/light/Makefile
+++ b/tools/libs/light/Makefile
@@ -268,5 +268,3 @@ cleanlocal:
 	$(RM) -f libxenlight.map
 	$(RM) -f $(AUTOSRCS) $(AUTOINCS)
 	$(MAKE) -C $(ACPI_PATH) ACPI_BUILD_DIR=$(CURDIR) clean
-
--include $(DEPS_INCLUDE)
diff --git a/tools/libs/stat/Makefile b/tools/libs/stat/Makefile
index 01417b5334..5840213376 100644
--- a/tools/libs/stat/Makefile
+++ b/tools/libs/stat/Makefile
@@ -121,5 +121,3 @@ clean: cleanlocal
 cleanlocal:
 	rm -f $(BINDINGS) $(BINDINGSRC) $(DEPS_RM)
 	rm -f libxenstat.map
-
--include $(DEPS_INCLUDE)
diff --git a/tools/libs/store/Makefile b/tools/libs/store/Makefile
index c208dbb48a..8e33db6a66 100644
--- a/tools/libs/store/Makefile
+++ b/tools/libs/store/Makefile
@@ -29,8 +29,6 @@ ifeq ($(CONFIG_Linux),y)
 xs.opic: CFLAGS += -DUSE_DLSYM
 endif
 
--include $(DEPS_INCLUDE)
-
 .PHONY: install
 install: install-headers
 
diff --git a/tools/libs/util/Makefile b/tools/libs/util/Makefile
index 87425d862a..72fecb4c49 100644
--- a/tools/libs/util/Makefile
+++ b/tools/libs/util/Makefile
@@ -49,8 +49,6 @@ $(LIB_OBJS) $(PIC_OBJS): $(AUTOINCS)
 	@rm -f $*.[ch]
 	$(FLEX) --header-file=$*.h --outfile=$*.c $<
 
--include $(DEPS_INCLUDE)
-
 clean: cleanlocal
 
 .PHONY: cleanlocal
diff --git a/tools/libs/vchan/Makefile b/tools/libs/vchan/Makefile
index df112f1b88..83a45d2817 100644
--- a/tools/libs/vchan/Makefile
+++ b/tools/libs/vchan/Makefile
@@ -11,7 +11,6 @@ SRCS-y += io.c
 NO_HEADERS_CHK := y
 
 include $(XEN_ROOT)/tools/libs/libs.mk
--include $(DEPS_INCLUDE)
 
 clean: cleanlocal
 
diff --git a/tools/libs/libs.mk b/tools/libs/libs.mk
index 847eb4851f..b3d784c57f 100644
--- a/tools/libs/libs.mk
+++ b/tools/libs/libs.mk
@@ -132,3 +132,7 @@ clean:
 
 .PHONY: distclean
 distclean: clean
+
+ifeq ($(filter clean distclean,$(MAKECMDGOALS)),)
+-include $(DEPS_INCLUDE)
+endif
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Tue Feb 08 10:42:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 10:42:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268056.461830 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHNwk-0008Dk-Kv; Tue, 08 Feb 2022 10:42:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268056.461830; Tue, 08 Feb 2022 10:42:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHNwk-0008Dd-HQ; Tue, 08 Feb 2022 10:42:06 +0000
Received: by outflank-mailman (input) for mailman id 268056;
 Tue, 08 Feb 2022 10:42:05 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JWzo=SX=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nHNwj-0008DT-0q
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 10:42:05 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id bf9c1504-88cb-11ec-8f75-fffcc8bd4f1a;
 Tue, 08 Feb 2022 11:42:03 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bf9c1504-88cb-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644316923;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=T+yhHlH9l734PUFCoISLUYy+wVgqoXvgM7mDxOE3xWs=;
  b=Tmsx8LpMxPloqzrUvuu24drKfGebP9mj8jzYv7Tsp2wev0UQnA+ZgAM2
   ZuakEagKCJe2c99Gufwp8aW85IeW4ua6si6qCtVps1BYbi2v9VQBFWRRG
   0gcBdoivQs5ysxf4x6y7DkBTPmWE1gVT8yy48J+cznuUlTfwq1PxNO8H2
   o=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: lXhJmQvMdzhb29Bb5CJgDKGIcT0CcXcDATyzK6SoyCQ4r+tK4VtSNc6dSEELvjnXVCXW2wd+Pm
 JwKwYFL52pBmiWULSGu6QWKnhoVc/tiE66TF+sM1HoSJu6vFVhligDT2HVlstmF9pSOji1E4vk
 xqvyI6Jk4qtFIrnM1FqrKV4iZvpSAJ01ErxPa3fIu57BIz/f+k+na7rJ6LfaJkN1bGvJ4IeISJ
 PX+reJWmP0XaBoGvBPGsF5hAi6dlukVqt2KfZTLFuYJ1xxJHZTHutal7qztgfMQrKgIL6ztVBj
 Qp2HwtefiwNUFWi9VuZoq6Mo
X-SBRS: 5.1
X-MesageID: 63720056
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:+gHE6a6UDaX1smoEhGXzUgxRtMPAchMFZxGqfqrLsTDasY5as4F+v
 jZKD2uPO/reMWTzeI8nboTn9x5Tv5KHzdBnTgQ6/3hgHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FV8MpBsJ00o5wbZj2t4w2LBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zj
 +dShJeLT1gVL7zjtdQfcBNyGHh0IvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALJc/3PIQZqzd4wCvQF/oOSpHfWaTao9Rf2V/cg+gQRqmEP
 5JEN1KDajz8PwFOAWsoC6s4xu2q3l3aVmRxs2mK8P9fD2/7k1UqjemF3MDuUt6ASNhRn02Yj
 nnb5Gm/CRYfXPSd1D6E/3SEluLJ2yThV+o6D6ak//RnhFmSwG07CxAMU1a/5/6jhSaWWd1FL
 FcP0jEztqV0/0uuJvHtUhv9rHOasxo0X9tLD/Z8+AyL0rDT4QuSGi4DVDEpQMMinN87Q3otz
 FDhoj/yLWUx6vvPEyvbr+rK62PpUcQIEYMcTWg2UjoO2N+8nJAioT//TPVpOqXshMKgTFkc3
 Au2hCQ5grwSi+sC2KO64U3LjlqQm3TZcuImzl6JBzz4t2uVcKbgPtX1sgaDsZ6sOa7EFgHpg
 ZQSpySJAAni57mpnTfFfugCFarBCx2tYGyF2g4H83XMGl2QF5+fkWJ4vWsWyKRBaJ9sldrVj
 Kj741I52XOrFCH2BZKbmqroYyjQ8YDuFM7+StffZcdUb556eWevpX8yORfBhjmzwRJ1ysnT3
 Kt3lu72XB4n5VlPlmLqF4/xL5d3rszB+Y8jbc+ilEn2uVZvTHWUVa0EIDOzghMRt8u5TPHu2
 48HbaOikkwHOMWnO3W/2dNDfDgicClgbbir+pM/XrDYeGJORjp+Y8I9NJt8IuSJaYwOzbyWl
 px8M2cFoGfCaYrvc13VMys+M+O2Bv6SbxsTZEQRALph4FB7Ca7H0UvVX8JfkWAP+LMxwPhqY
 eMCfsncUP1DRi6eo2YWbIXnrZwkfxOu3FrcMy2gaTk5XphhWw2WpYO0IlqxrHEDXnitqM8zg
 7y8zQeHE5ANcBtvUZTNY/W1wlLv4XVEwLBuX1HFK8V4cVn39NQ4MDT4i/I6epleKRjKyjaA+
 RyRBBMU+bvEr4MvqYGbjqGYtYa5VeB5GxMCTWXc6L+3Mwjc/3aintAcALrZI2iFWTqtqqu4Z
 OhTw/XtC9E9nQ5H49hmDrJm7aMi/N+z9bVU+RtpQSfQZFOxB7I+fnTfhZtTtrdAz6NysBetX
 h7d4cFTPLiENZ+3EFMVIwZ5PO2P2etNx2vX5PUxZk77+DV27PyMVkALZ0uAjylULb1UNoI5w
 Lh+5J5KulLn0hd6YMybii109niXKi1SWqoqgZgWHYv3h1d50VpFe5HdVnf77Zznhw+g6aX2z
 ut4XJb/uok=
IronPort-HdrOrdr: A9a23:tQVepKDJLNZPH0DlHemo55DYdb4zR+YMi2TDsHoBLiC9E/bo8/
 xG+c5x6faaslossR0b9uxoW5PhfZq/z/BICOAqVN/JMTUO01HIEKhSqafk3j38C2nf24dmpM
 JdmnFFeb7N5I5B/KTH3DU=
X-IronPort-AV: E=Sophos;i="5.88,352,1635220800"; 
   d="scan'208";a="63720056"
Date: Tue, 8 Feb 2022 10:41:57 +0000
From: Anthony PERARD <anthony.perard@citrix.com>
To: Juergen Gross <jgross@suse.com>
CC: <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, "Jan
 Beulich" <jbeulich@suse.com>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>
Subject: Re: [PATCH v2 0/5] tools: remove include/xen-external directory
Message-ID: <YgJI9fqxMd1LwC02@perard.uk.xensource.com>
References: <20220207064147.9585-1-jgross@suse.com>
 <YgFgZADfaoLNor4T@perard.uk.xensource.com>
 <60aa8654-a40f-e5fa-e669-d8fba72a4866@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <60aa8654-a40f-e5fa-e669-d8fba72a4866@suse.com>

On Tue, Feb 08, 2022 at 06:32:10AM +0100, Juergen Gross wrote:
> On 07.02.22 19:09, Anthony PERARD wrote:
> > On Mon, Feb 07, 2022 at 07:41:42AM +0100, Juergen Gross wrote:
> > > The tools/include/xen-external directory contains a header file from
> > > FreeBSD used to generate Xen header files. This series is replacing the
> > > complete directory by a single header with the same semantics.
> > > 
> > > Changes in V2:
> > > - remove stale comment in patch 1
> > 
> > Just need to fix the build now, otherwise, the series looks fine:
> > https://gitlab.com/xen-project/patchew/xen/-/pipelines/464803007
> > ^ xentoolcore conversion seems unfinished.
> 
> Hmm, weird.
> 
> Seems I did only an incremental build, but I think it should have failed
> nevertheless. I suspect something is wrong with the dependencies.

Indeed, the dependencies aren't loaded. I've prepared a patch:

https://lore.kernel.org/xen-devel/20220208103959.21102-1-anthony.perard@citrix.com/

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 10:44:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 10:44:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268066.461841 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHNym-0000Ol-3L; Tue, 08 Feb 2022 10:44:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268066.461841; Tue, 08 Feb 2022 10:44:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHNyl-0000Oe-TX; Tue, 08 Feb 2022 10:44:11 +0000
Received: by outflank-mailman (input) for mailman id 268066;
 Tue, 08 Feb 2022 10:44:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JWzo=SX=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nHNyk-0000OY-Oz
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 10:44:10 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0ae7aff8-88cc-11ec-8f75-fffcc8bd4f1a;
 Tue, 08 Feb 2022 11:44:09 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0ae7aff8-88cc-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644317049;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=RMIK6DJc8n/Bh429K4rk45ExdQCkxUbwU40lVok1ZK0=;
  b=X3t35wiNViU2ytIhXMQXkfIhxZKn6GciCMyD6x1noc/CiqG5V0px1z3H
   tGBUG891uWMNlg6xqpm526YB1kLW1NMYaemYx/HUrA/963zAfMqiFqnn4
   /8RPJtUA4HCHvpXudb/WHgoV82+QZbdfr/vW9m3KRXY4Ix48iFxVsOIZZ
   k=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: VRZVH62rDn8DawEeJCf0yBaE2wGh6pd77mEhgL+Au8CeV9CfVb5eBsSWs9xAnnjXXYplztuC+z
 2AqUTrzZ1v+hgYdWuS7lSMWl3d09Jo/ajrbD8ABIaXKWmYYjyi0GEe3++GMhaX4wgCTiTCXLdY
 yDMuDZKOv7HthmH9Mw0AE9D4mfpS6oe0BS6SilEBiFn8a9TFiGHmP5qPauCVaJQV6epfPmIOrG
 LRkJ2eVir1Wpswy5HXKUNXWieAity8lT3yN6UTFXH+STaK/3LSNeHKaxJjkKMV+LsIgiWyi2tP
 SHOLK8ysp35sjsmYf5G5eMAS
X-SBRS: 5.1
X-MesageID: 64125210
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:TnOEfqK0VHd/zRtkFE+RF5IlxSXFcZb7ZxGr2PjKsXjdYENS12MPx
 zFNXDzQPfnZZTP2L4wjbIvjpEsDupLWm9dkSwNlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokcxIn5BC5C5xZVG/fjgqoHUVaiUakideSc+EH170Ug7y7Zg6mJVqYPR7z2l6
 IuaT/L3YDdJ6xYsWo7Dw/vewP/HlK2aVAIw5jTSV9gS1LPtvyB94KYkDbOwNxPFrrx8RYZWc
 QphIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbrGvaUXe345iXMfwZ3u7hB2nsctfk
 PASmqaUci4nefz3wuBMTUlxRnQW0a1uoNcrIFC6uM2XiUbHb2Ht07NlC0Re0Y8wo7gtRzsUr
 LpBdW5LPkvra+GemdpXTsFlgNgjK8/6epsSoHh6wRnSDOo8QICFSKLPjTNd9Gls35oTR6+GD
 yYfQTdAZTTiaAZ9A0s8GpMYrcz0rSn0XhQN/Tp5ooJoujOOnWSdyoPFL979atGMA8JPkS6wt
 m/Aumj0HBweHNie0iaetGKhgPfVmiH2U55UE6e3ntZoj0eU3Xc7EwANWB2wpvzRt6Klc4sBc
 QpOoHNo9PVsshzwJjXgY/GmiFCqpTBEfoV/KckBwQ/Km5GO51eHVkFRG1atd+canMMxQDUr0
 HqAkNXoGSFjvdWpdJ6NyluHhWjsYHZIdAfucQdBFFJYuIe7/OnfmzqSFo4LLUKjsjHi9dgcK
 RiupTN2ubgchNVjO06TrQGe2GLESnQko2cICuTrsoCNs1kRiG2NPdXABb3nARFodtfxc7V5l
 CJY8/VyFchXZX13qASDQf8WAJai7OufPTvXjDZHRsd9q238oif9LNoJu1mSwXuF1e5eKFfUj
 LL741sNtPe/wlP2BUOIX25BI5tzlvWxfTgUfvvVcsBPcvBMmPyvp0lTibqr9zm1yiAEyPhnU
 b/CKJrEJStKWMxPkWvtL89AgOBD7n5lnwv7G8ukpylLJJLDPRZ5v59eawDQBg34hYvZyDjoH
 yF3bZPVkk4CC72nOUE6M+c7dDg3EJTyPriuw+Q/SwJJClMO9LgJB6CDzLU/VZZimqgJxO7E8
 mvkAh1TyUblhG2BIgKPMygxZLTqVJd5jHQ6IS1zYgr4hyl9Od6ivPUFap86Xbg77+g/n/R6e
 OYIJpebCfNVRzWZpzlENcvhrJZvfQiAjB6VO3b3eyA2epNtHlSb+tLtcgb12jMJCy676Zk3r
 7G6j1uJSpsfXQVySs3Rbav3nV+2uHEcnsN0XlfJfYYPKBm9rtAyJnWo3PEtIswKJRHS/Reg1
 l6bUUUCuO3Ag44p692V16qKmJikTrllFU1AEmiFsbvvbXvG/nCuyJNrWfqTeWyPT3v9/aiva
 LkHz/z4N/Fbzl9Gv5AlTuRuxKM6odDuu6Vb3kJvG3CSNwanDbZpI3+n28hTt/ISmu8F6FXuA
 k/fqMNHPbipOd/+FA9DLQUoWe2PyPUIl2SA9v8yOkj7uHd68bfvvZ++5PVQZPix9IdIDb4=
IronPort-HdrOrdr: A9a23:eeONCq+C/5GoMpiyo/Buk+DcI+orL9Y04lQ7vn2ZLiYlFfBw9v
 re+MjzsCWetN9/Yh0dcLy7V5VoIkm9yXcW2+cs1N6ZNWGN1VdAR7sC0aLShxHmBi3i5qp8+M
 5bAs1D4QTLfDtHZBDBkWuFL+o=
X-IronPort-AV: E=Sophos;i="5.88,352,1635220800"; 
   d="scan'208";a="64125210"
Date: Tue, 8 Feb 2022 10:44:04 +0000
From: Anthony PERARD <anthony.perard@citrix.com>
To: Juergen Gross <jgross@suse.com>
CC: <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v3 1/5] tools/include: generate a _xen_list.h file
Message-ID: <YgJJdBqUkjTTT6fT@perard.uk.xensource.com>
References: <20220208070638.5909-1-jgross@suse.com>
 <20220208070638.5909-2-jgross@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220208070638.5909-2-jgross@suse.com>

On Tue, Feb 08, 2022 at 08:06:34AM +0100, Juergen Gross wrote:
> Today tools/include contains two basically identical header files
> generated from the same source. They just differ by the used name space
> and they are being generated from different Makefiles via a perl
> script.
> 
> Prepare to have only one such header by using a more generic namespace
> "XEN" for _xen_list.h.
> 
> As the original header hasn't been updated in the Xen tree since its
> introduction about 10 years ago, and the updates of FreeBSD side have
> mostly covered BSD internal debugging aids, just don't generate the
> new header during build, especially as using the current FreeBSD
> version of the file would require some updates of the perl script,
> which are potentially more work than just doing the needed editing by
> hand. Additionally this enables to remove the not needed debugging
> extensions of FreeBSD.
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>

Acked-by: Anthony PERARD <anthony.perard@citrix.com>

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 10:46:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 10:46:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268076.461851 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHO1D-00013g-Gy; Tue, 08 Feb 2022 10:46:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268076.461851; Tue, 08 Feb 2022 10:46:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHO1D-00013Z-Du; Tue, 08 Feb 2022 10:46:43 +0000
Received: by outflank-mailman (input) for mailman id 268076;
 Tue, 08 Feb 2022 10:46:41 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JWzo=SX=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nHO1B-00013T-GJ
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 10:46:41 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 64c08d19-88cc-11ec-8f75-fffcc8bd4f1a;
 Tue, 08 Feb 2022 11:46:40 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 64c08d19-88cc-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644317200;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=UYtfxWoyRCUFFiNdmulv1uEuQNX6ueRjc0X4WY+zIbc=;
  b=GOQkgs1l7pJsfJ9Zi/QrqaTXhqn2LNe/by3MHnTffTc/Q8l7F6aYXIkQ
   7fqBdk33Evdrif5HGjHtP8sdbfIrIjFAJHLL3rcLg61UdEcwmpviUTlW1
   tUFn3zaa2rb2gy8mdSkMngyG1U33+tvuFFcLFHwD1/wVpmkqDRSFDwpWW
   g=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: XPRFmlf+0Q5GCVCUoNhSI4vGp2umYEJhy7jhePmiNX71uKrHSc7/DVELObAMRz2qVR3yY1Evdj
 n3XW9+KFtXH6jF5gaXBM1THQNCTrp+fYJZW3lcFd3E7NuRzHbywcTdG04z6d4LbMBuBKdpUgDR
 txvWlJFMqQMdr7/YzsCymLDY3ViBtZTubCnUhPvkorCwSXFe1BX1lux1CmAk0o61IzsNzTsvQ1
 9spsJMj6zDVJ7y7TgYyTw2Kf1JPdEIpOILYxXvFydehpPWNh9inMs8Mtc3soX6ELlVvgoadS8b
 IfrCuW7k8eGSd2nMNPu+OeNY
X-SBRS: 5.1
X-MesageID: 63720280
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Fk1Tga4o7wzR0EW/6lPZvgxRtP7AchMFZxGqfqrLsTDasY5as4F+v
 mtNXG/TP62PYzTxfNl1Poqxp0NV6MOAy4QwTwZurS80Hi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FV8MpBsJ00o5wbZj2t4w2LBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z7
 dBAkpupVAwTE5bmv90bUzBFQiF7BPgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALJc/3PIQZqzd4wCvQF/oOSpHfWaTao9Rf2V/cg+gQRqmEP
 5BJMVKDajzbaTdKagkZVqkHhb6QiSTTcjFghlaK8P9fD2/7k1UqjemF3MDuUsOObdVYmACfv
 G2u13T0BFQWOcKSzRKB82mwnanfkCXjQoUQGbaksPlwjzW7xGMJDwYNfUCmuvT/gUm7M++zM
 GRNpHBo9/JrshX2EJ+tBHVUvUJooDY5Xtd3FPQn4zug8YDz2gCZL3VVTjt4PYlOWNANeRQm0
 VqAntXMDDNpsaGIRX/1yop4vQ9eKgBOczZcOHZsoR8tpoC6/dpt1k6nosNLTfbt5uAZDw0c1
 NxjQMIWo7wIxfAG2Kyglbwsq2L9/8OZJuLZC+i+Y45E0u+bTNP/D2BLwQKChRqlEGp+ZgPQ1
 EXoY+DEsIgz4WilzURhutklErCz/OqiOzbBm1NpFJRJ323zpyL6LNkJvmAkfRwB3iM4ldjBO
 h67hO+szMULYCvCgVFfP+pd9PjGPYC/TI+4B5g4n/JFY4RrdR/vwc2dTRX44owZq2B1yftXE
 c7CKa6EVC9GYYw6nGveb7pMitcDm3FhrUuNHsqT50r8jtKjiIu9FO5t3K2mNbtisstpYWz9r
 r5iCid9408HD7SlP3KHqNV7wJJjBSFTOK0aYvd/LoarSjeK0kl4YxMI6b9+KYFjgYpPkeLEo
 iO0VkNCkQKtjnzbMwSaLHtkbeq3D5p4qHs6Ow0qPEqphCd/Mdr+sv9HestlZ6Qj+cxi0eVwE
 6sPdfKfD6kdUT/A4TkcM8Xw9dQwaBSxiAuSFCO5ezxjLYV4TgnE94a8LAvi/SUDFAStss46r
 +Hy3w/XW8NbFQ9jENzXeLSkyFbo5SoRn+d7Xk3pJNhPeRqzrNg2enKp1vJuepMCMxTOwDeex
 j26OxZAqLmfuZIx/fnImbuA89WjHdxhExcIBGLc97u3a3XXpzLx3Y9aXe+UVjnBT2eoqr66b
 OBYwvygYv0KmFFG79h1H7pxlP9s4tLuo/lRzxh+HWWNZFOuU+syLn6D1MhJl6tM2r4G5lfmB
 hPRooFXaeeTJcfoMF8NPw50PO2M2MYdliTW8flocl7x4zV6/ebfXEhfV/VWZPex8Feh3FsZ/
 Noc
IronPort-HdrOrdr: A9a23:8IW4PKFXYoQSF6oqpLqE6MeALOsnbusQ8zAXP0AYc3Jom+ij5q
 STdZUgpHrJYVkqNU3I9ertBEDEewK6yXcX2/hyAV7BZmnbUQKTRekIh7cKgQeQeBEWntQts5
 uIGJIeNDSfNzdHsfo=
X-IronPort-AV: E=Sophos;i="5.88,352,1635220800"; 
   d="scan'208";a="63720280"
Date: Tue, 8 Feb 2022 10:46:35 +0000
From: Anthony PERARD <anthony.perard@citrix.com>
To: Juergen Gross <jgross@suse.com>
CC: <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v3 2/5] tools/libs/light: replace _libxl_list.h with
 _xen_list.h
Message-ID: <YgJKC79dDFY6gz2V@perard.uk.xensource.com>
References: <20220208070638.5909-1-jgross@suse.com>
 <20220208070638.5909-3-jgross@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220208070638.5909-3-jgross@suse.com>

On Tue, Feb 08, 2022 at 08:06:35AM +0100, Juergen Gross wrote:
> Remove generating _libxl_list.h and use the common _xen_list.h instead.
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>

Acked-by: Anthony PERARD <anthony.perard@citrix.com>

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 10:47:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 10:47:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268084.461862 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHO2F-0001g1-S5; Tue, 08 Feb 2022 10:47:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268084.461862; Tue, 08 Feb 2022 10:47:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHO2F-0001fu-PI; Tue, 08 Feb 2022 10:47:47 +0000
Received: by outflank-mailman (input) for mailman id 268084;
 Tue, 08 Feb 2022 10:47:47 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JWzo=SX=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nHO2F-0001fm-3k
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 10:47:47 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8bea8530-88cc-11ec-8f75-fffcc8bd4f1a;
 Tue, 08 Feb 2022 11:47:45 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8bea8530-88cc-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644317265;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=Uo0NeC6HqA/AJX5NG+TPsnWTZGjHOn5Wquvom1FO+sw=;
  b=TTiIJ0AnTXMviNMLvYW4DCJN3hPh4UCXnh3pLro3MDiO+Lt52COZt3QN
   ifkhG6NqqN7UoJrz7rEFl5DAu4PhA9YLHu30gMjp7Orbj+iQa1qhItN+P
   l7+Fjq7Cyl9KVX9TvmlHMs1c1ZC38ME8p1dFAsLsJmKU1VZB8Fh3Ai5Q0
   o=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: lxS3QB9k4kMpWTaWi0YxuntNWh1AE9WyAK2hScAE5U4aO2Qm75fxG4pINYs1vS1ZAQPs+McBlt
 KJ1t+HEiAdJw2zIpEpeZ1/JJRmuDoF8e7j3mpVPcvInM56VGUQ+T/52PCFABcXv+8CvuuP2qtW
 hAQsxZyXqjvMqiDcCkjEevUA9Xj74+tdZsIwVK3egsEF+sX5V7OKmhTHhTgU9uOGdm3CYn0TLx
 EAHPJVTjd4hRCcezOUqHNdBqnUHP+9qIxP+DoAy5VxnV7kJJ8ZGXQZcUkpyM9VgqkeKfN3hHEn
 +FwEKQ32/eyW2v+i0rd6GbwW
X-SBRS: 5.1
X-MesageID: 65932262
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:b3HeeK89Ep0r+v55HCyiDrUDe3mTJUtcMsCJ2f8bNWPcYEJGY0x3m
 2QZCD+ObqrcMDagLdoiboq39E9VvcOGyN9iHQU9pCs8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhFWeIdA970Ug5w7Rh0tYx6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhh5
 OVCtbyiUD4kAYPCgOAxfjhSCjFXaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguwqKtXrO4UO/Glt1zjDAd4tQIzZQrWM7thdtNs1rp4TTK2EP
 ZRDAdZpRDfOTUJ0AHU0MpY73+HwqEbeaGR2kF3A8MLb5ECMlVcsgdABKuH9eMGORMhTtlaVo
 CTB5WuRKgoBKNWVxD6B83StruzChyX2XMQVDrLQ3uFuqE2ewCoUEhJ+fVm0u/6ikWalRslSb
 UcT/0IGvaU0sUCmUNT5dxm5u2Kf+A4RXcJKFO834x3LzbDbiy6bDGUZSj9KaPQ9qdQ7Azct0
 ze0c8jBXGI19ufPEDTEq+nS/Wja1TUpwXEqdQM0Qgsl8cDarb4dgArLYvtCGrelp4igcd3v+
 AyioC87jrQVqMcE0aSn4FzK6w6RSoj1oh0dvVuOAD/8hu9tTMv8PtHztwCHhRpVBNvBFjG8U
 G44d99yBQzkJbWEj2SzTeoEB9lFDN7VYWSH0TaD83TMnglBGkJPn6gNulmSx28za67onAMFh
 2eJ6GtsCGd7ZifCUEOOS9vZ5z4W5abhD8/5cfvfc8BDZJN8HCfeon0yPB/Jhj68yhF3+U3aB
 Xt8WZz9ZUv29Iw9lGbmLwvj+eNDKt8CKZP7GsmgkkXPPUu2b3+JU7YVWGZinchihJ5oVD79q
 o4FX+PTkk03eLSnPkH/rN5CRXhXfCNTLc2n9KR/KLXZSiI4Qz5JNhMk6e54E2CTt/8OzbmgE
 7DUchIw9WcTclWdcVrTMS04OOq0NXu9xFpiVRER0Z+T8yBLSe6SAG03LvPbpJErq75uy+BaV
 f4Ad5nSC/hDUG2fqT8ccYP8vMppcxHy3VCCOC+sYT4eeZ98RlOWpo+4L1W3rCReXDCqscYeo
 qG70l+JS5Q0WAk/Xt3db+iizg3tsCFFyv5yRUbBPvJaZF7orNpxMyX0g/Jue5MMJBzPyyG0z
 QGTBRtE9+DBr5VsqIvChLyerpfvGOx7RxIIE27e5LewFC/b4mv8ntMQDLfWJWjQDTqm9r+ja
 ONZy+DHHMcGxFsa4ZBhF7tLzL4l44e9rbFt0Qk5Tm7AaE6mC+08LyDej9VPrKBE2pRQpRCyB
 hCU4tBfNLiEZJHlHVoWKFZ3Z+iPz6hJyDzb7PBzK0Tm/i5nurGAVBwKbRWLjSVcKppzMZ8kn
 rh96JJHtVTnh0p4KMuCgwBV63+Ify4JXKgQv50HBJPm11gwwVZYbJ2AUiL77fljsTmX3pXG9
 tNMuJf/ug==
IronPort-HdrOrdr: A9a23:ls0hua+0pkqdSIcBkyJuk+DYI+orL9Y04lQ7vn2YSXRuHPBws/
 re+MjztCWE7Qr5N0tMpTntAsW9qDbnhPlICOoqTNWftWvd2FdARbsKheCJ/9SjIVycygc079
 YHT0EUMrzN5DZB4vrH3A==
X-IronPort-AV: E=Sophos;i="5.88,352,1635220800"; 
   d="scan'208";a="65932262"
Date: Tue, 8 Feb 2022 10:47:40 +0000
From: Anthony PERARD <anthony.perard@citrix.com>
To: Juergen Gross <jgross@suse.com>
CC: <xen-devel@lists.xenproject.org>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, "Jan
 Beulich" <jbeulich@suse.com>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v3 3/5] tools/libs/toolcore: replace _xentoolcore_list.h
 with _xen_list.h
Message-ID: <YgJKTHjEkBMYgQ31@perard.uk.xensource.com>
References: <20220208070638.5909-1-jgross@suse.com>
 <20220208070638.5909-4-jgross@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220208070638.5909-4-jgross@suse.com>

On Tue, Feb 08, 2022 at 08:06:36AM +0100, Juergen Gross wrote:
> Remove generating _xentoolcore_list.h and use the common _xen_list.h
> instead.
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>

Acked-by: Anthony PERARD <anthony.perard@citrix.com>

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 10:49:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 10:49:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268093.461873 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHO3d-0002HM-6S; Tue, 08 Feb 2022 10:49:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268093.461873; Tue, 08 Feb 2022 10:49:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHO3d-0002HF-3P; Tue, 08 Feb 2022 10:49:13 +0000
Received: by outflank-mailman (input) for mailman id 268093;
 Tue, 08 Feb 2022 10:49:12 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nHO3c-0002Gw-9e; Tue, 08 Feb 2022 10:49:12 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nHO3c-0005ZK-5c; Tue, 08 Feb 2022 10:49:12 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nHO3b-0000uU-SQ; Tue, 08 Feb 2022 10:49:11 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nHO3b-0008Cm-Ru; Tue, 08 Feb 2022 10:49:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=q2MXDY+L529CITDLnyzwqzET/RhoDvM7bpARL18BhKY=; b=mtOMyGFTWufdTarkfLkGd9qQit
	iwBTP6qh9o8O1UquzXOuMYDmC3tBBFFo0O1e89lMnM1pKgHlw6O5+xkiB8V9YvX8tH9sOFaHjMXwl
	xUJ5fyEdi3blfiSMrzW9NuRkoTN2zZKFCTxx42R6ZfsENC/qwjOYAhNxI11CX2M/sZZk=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168052-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 168052: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=555f3d7be91a873114c9656069f1a9fa476ec41a
X-Osstest-Versions-That:
    linux=2ade8eef993c37a2a43e51a9b1f6c25509a2acce
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 08 Feb 2022 10:49:11 +0000

flight 168052 linux-linus real [real]
flight 168057 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/168052/
http://logs.test-lab.xenproject.org/osstest/logs/168057/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 168057-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168050
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168050
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168050
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168050
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168050
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168050
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168050
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168050
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                555f3d7be91a873114c9656069f1a9fa476ec41a
baseline version:
 linux                2ade8eef993c37a2a43e51a9b1f6c25509a2acce

Last test of basis   168050  2022-02-07 20:39:51 Z    0 days
Testing same since   168052  2022-02-08 02:04:22 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Hyunchul Lee <hyc.lee@gmail.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Namjae Jeon <linkinjeon@kernel.org>
  Steve French <stfrench@microsoft.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   2ade8eef993c..555f3d7be91a  555f3d7be91a873114c9656069f1a9fa476ec41a -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 10:50:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 10:50:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268106.461885 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHO4g-0003b6-K7; Tue, 08 Feb 2022 10:50:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268106.461885; Tue, 08 Feb 2022 10:50:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHO4g-0003az-FW; Tue, 08 Feb 2022 10:50:18 +0000
Received: by outflank-mailman (input) for mailman id 268106;
 Tue, 08 Feb 2022 10:50:17 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=GmUj=SX=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nHO4f-0003ap-DB
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 10:50:17 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e508c7cd-88cc-11ec-8f75-fffcc8bd4f1a;
 Tue, 08 Feb 2022 11:50:15 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e508c7cd-88cc-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644317415;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=W2sZy2rV6WUG2bZo8PIEkizxWMFoZ9Ura8FR2J5zWrE=;
  b=L1g4hlrBrG9SY3jDYrJqeIdKWFbW40NcVP3Baysnf4zFhWaNLUd72iC9
   O+Y0HeAxfLI+1KLNKM8qPuyIvyEPnD9Te0B0Pyear7MY1c+7uqQggHZbz
   l+TCk5jGLLvT75R/PEcnvbBH30Ali9uXyYmwKgimQD8moq8yUildOzxkY
   s=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: n+8gErvBko1hIKVPkTu4UKa6vrBE1hEN0ZGvmwAmx82pYH14379CWaigwuaXWv1AyPASXdu0/+
 vToor7K6cW82Lpe1c8UVUbHXLwg1dfyl+eG1rB6cZx/Lo3amV+2F3Qm5pvE9SJcDRD/+PKH8u2
 cAdbIpgEOXib1ay1ozTMUINt0rYLWHzgD+pUjYou/pmsi/e+wltw3GxPXegP+0yEXQo3atCwVt
 HFFRGR6OGhEdt+0nL4CZcQ24ulrDeR7XDPMSrLhKQHXk876gbQN3a87TQzlJwkZvKsz7b1pGe3
 otmiqfP/TwaQlllePMb9OLUU
X-SBRS: 5.1
X-MesageID: 64125556
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:EGcqSqxALQEd63SBSjx6t+cXwCrEfRIJ4+MujC+fZmUNrF6WrkVRm
 2ZKW2uPOPvZMWSnfNp+bd/ioR4A6JXRxtM2HVBqqiAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAhLeNYYH1500g7wbZp2tcAbeWRWGthh
 /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL
 wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt/Fbz
 /YWjaaKcBgSMo/FvOE4TDYGHj4raMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr
 6ZBbmlQMFbT3Ipaw5riIgVort4kI8TxepsWp1lrzC3DDOZgSpfGK0nPzYEEhW1t250QdRrYT
 +gmchltTh7aWAdGHlVOV7wHwuOLn2aqJlW0r3rK/PFqsgA/1jdZyLHwNPLFd9rMQt9a9m6xv
 H7L+lPcEx4TNdGB4Ted+3fqjejK9QvxVZgODrS++rhviUeK220IIBQMUB2wpvzRol6zXZdTJ
 lIZ/gIqrLMu7wq7Q9/lRRq6rXWY+BkGVLJ4CeQ69QXL0avS7AaxD3IBCDVGbbQOisgyQjA70
 06TqPngDzdvrb69RGqU8/GfqjbaESofIHIGZCQEZRAY+NSlq4Y25jroSttgC6ezgsfCMDf82
 S2RrCM+irMQiuYGz6y+u1vAhlqEpIXNTwMzzhXaWCSi9AwRTKmhao+z4F7X98F8PZ2ZRVmMu
 nsDs8WG5eVIBpaI/ASWW/kEFryt4/eDMRXfjERpEp1n8C6ik0NPZqgJvms4fh0wdJ9ZJ3m5O
 yc/pD+9+rdyFnyJNpdNWbuuMMgIxIzlMMvKCP3LO48mjodKSCeL+yRnZEi11m/rkVQxnaxXB
 ap3YfpAHl5BV/05kWPeq/M1lOZym3tgnT+7qYXTkkz/uYdyckJ5Xlvs3LGmSukipJ2JrwzOm
 zq0H5vbkk4POAESj8S+zGLyEbzoBSVhbXwVg5YOHgJmHuaBMDtwY8I9OZt7J+RYc119z48kB
 E2VVE5C00bYjnbaMwiMYX0LQOqxAcom/CtiY312ZA3AN50fjWGHtvZ3SnfKVeN/qLwLIQBcE
 5HphPls8twQE2+aqlzxnLH2rZB4dQTDuO59F3HNXdTLRLY5H1ah0oa9JmPHrXBSZgLq5ZpWi
 +DxjWvzHMtcLyw8V5y+QKz0kDuMUY01xbsas73geYIIJi0BMeFCdkTMsxPAC5tUdkyYm2DKj
 l3+7NVxjbClnrLZOeLh3Mish4yoD/F/DgxdGWza5qyxLi7U4iyoxooobQpCVWq1uLrc9Prwa
 ONL4ev7NfFbzl9Gv5AlS+RgzL4k5suprLhfl1w2EHLOZlWtK7VhPnjZgpUf6vwTnudU6VmsR
 0aC2thGIrHVasnrJ0EceVg+ZeOZ2PBKxjSLtaYpIF/37TNc9aacVRkAJAGFjSFQdeMnMI4sz
 eo7ltQR7giz1kgjPtqc13gG/GWQNH0QFa4gs8hCUoPsjwMqzHBEYIDdVXCqsM3eNY0UPxBzc
 DGOhafEi7BN/Wb4ciI+RSrXwO5QpZUSoxQWnlUMEEuEx4jejfgt0RwPrTluFlZJzg9K2v5YM
 3RwMxEnPr2H+jpliZQRX22oHA0dVhSV9laolgkMnWzdCUKpSnbMPCs2PuPUpBIV9GdVfz56+
 rCEyTm6DWa2LZ+phiZiC1R4r/HDTMBq8lyQkc+qKM2JAp0mbGe3maSpf2cJ90PqDM5ZaJcrf
 gW2EDKcsZHGCBM=
IronPort-HdrOrdr: A9a23:5QGIwK9uMSVwTpFRvNtuk+FAdb1zdoMgy1knxilNoENuHfBwxv
 rDoB1E73LJYVYqOU3Jmbi7Sc69qFfnhORICO4qTMqftWjdyRCVxeRZg7cKrAeQeREWmtQtsJ
 uINpIOdOEYbmIK/PoSgjPIaurIqePvmMvD5Za8854ud3ATV0gJ1XYGNu/xKDwReOApP+tcKH
 LKjfA32AZINE5nJfiTNz0gZazuttfLnJXpbVovAAMm0hCHiXeN5KThGxaV8x8CW3cXqI1SvF
 Ttokjc3OGOovu7whjT2yv66IlXosLozp9mCNaXgsYYBz3wgkKDZZhnWZeFoDcpydvfomoCoZ
 3pmVMNLs5z43TeciWcpgbs4RDp1HIU53rr2Taj8A3eiP28YAh/J9tKhIpffBecwVEnpstA3K
 VC2H/cn4ZLDDvb9R6NqeTgZlVPrA6ZsHAimekcgzh0So0FcoJcqoQZ4Qd8DIoAJiTn84oqed
 MeQ/003MwmMW9yUkqp/VWGmLeXLzYO91a9MwQ/U/WuonlrdCsT9Tpc+CQd9k1wg67VBaM0o9
 gsCZ4Y542mePVmGZ6VNN1xMfdfNVa9My4kEFjiaGgPR5t3c04klfbMkcAIDaeRCds18Kc=
X-IronPort-AV: E=Sophos;i="5.88,352,1635220800"; 
   d="scan'208";a="64125556"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=HjM7RrsEK+IjUkw2EMi+KiQhp1dHu8QcHLRVToHZ7XjuIJRrPyZwpRVAdL7GXO1BgHkWqR+TN3QxsLlVmWbFUmxxU41hQTE/GLYNV7o4o2mf5frp3MMvPaRIX0QOdwELr69vArswYk2v87cbZBlalmiyk9GmVfYnIN463McdjN6tN452HL+6q4RwNKadTwY4M2GZ7mikgvDO19xN5TK4i3VTmX4I9pU0/bchkoZ11QBMYt+Np8GGb2MX0GIaaqymB1JHLzJCXPGhCqKzNZIAYRKN8BrB1FfhRFXP8rWbV1uphq2hdE3DqBr9fhZptjNplwmmZDvGaPVTiyLZFNaNaA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=CmVQHcuVkLutcxkbKnI79dJyv/G70MnZrJPD8qAKEYI=;
 b=aTfy2t9Qp2VsS6g6uhYHIZ2HJQzqi/4EKAIhlLzy2XDWH6UHk2T4AhfXt0DnuqDiGgFPvF8aSD4oFl5OPVv3z1BkD3ILtsdhQxVOsDCVjgC3ZLGBjR3xEiYuzztoFOpzi0CW2/d1P1NB20HYW2MZNqmHcHKdlYfNvvwefu2aXTy7OoJv6B0t5KmBi2mGa4a28Q7ITkKardREz6cQB6uJM6OJM9e/naY8zLR4a5Xp0+1twA/+pP+YXB5P2uTWGCaN56LuiITLBlVUJdQueJcE5+9LeVv0Zb1IeiBmOW+cIE6s/gN8BtfaW1jUwII7QLiNAr1HzBQDfTsvekhGO4sMbw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=CmVQHcuVkLutcxkbKnI79dJyv/G70MnZrJPD8qAKEYI=;
 b=fzG4JMDX0mew7IqeiXtvI3UmQpES4+kjvCtj328oCPZ93FfUHcU+0FkZslyn2BudR/2Qmg1nd+9r5dEgf7l9n2V2Z44H8zUEmQWBB06Lx4O8SMYsCJjC4/UV7nGG7/j7QwGitYv5hXt+sMIIDp/OClTT01J0ppnsh7egT7x5jwU=
Date: Tue, 8 Feb 2022 11:50:03 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: Jan Beulich <jbeulich@suse.com>, "julien@xen.org" <julien@xen.org>,
	"sstabellini@kernel.org" <sstabellini@kernel.org>, Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Artem Mygaiev <Artem_Mygaiev@epam.com>,
	"andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
	"george.dunlap@citrix.com" <george.dunlap@citrix.com>, "paul@xen.org"
	<paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>, Rahul Singh
	<rahul.singh@arm.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Message-ID: <YgJK2zPszyTXGxMM@Air-de-Roger>
References: <YgEsRuckQJIQlkzf@Air-de-Roger>
 <a2a42c1d-d379-00cd-5d55-f443cdb02e97@epam.com>
 <e8fc7872-c7d0-f389-c507-335b809ffcbc@epam.com>
 <21c8125a-2f79-1a4a-494c-db9e4be2a1a6@suse.com>
 <4276fe72-558b-7d95-6430-d4330989dbe8@epam.com>
 <ad985f4a-10f0-4a2d-df02-cde915fea3f1@suse.com>
 <f7669670-8eeb-9966-5ba3-e8f9c03ce3d3@epam.com>
 <73e08285-6bb1-5842-899f-bd6502406e49@suse.com>
 <be3f4222-6580-4c89-a202-c003b6feb9b4@epam.com>
 <e91965c5-0802-adf8-0c17-522f86ebf231@epam.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <e91965c5-0802-adf8-0c17-522f86ebf231@epam.com>
X-ClientProxiedBy: LO3P265CA0014.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:bb::19) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4726d038-1b5d-45b1-76f0-08d9eaf0c60d
X-MS-TrafficTypeDiagnostic: CY4PR03MB2965:EE_
X-Microsoft-Antispam-PRVS: <CY4PR03MB296524F13C5CA82FE00811188F2D9@CY4PR03MB2965.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: cNLnqvh5kzCsN4wRIhNcKgAlBK3nQbYwrRwObYJ0i2JLwdv2P0jM2m4BWhHu2zMdKkkjFcdtCcBZUAJew/anLK6HTqo+/FD3C1IglZ1snCr0AHTElAOxyKsaLfz9i0x+25CHTG5M7orpvPH40sXPiklaPWWptOBe2TdRCR3ZXBfoGu9+Q5A8pwyOzAmaWZzWneWI+u1CDDrmpCVQk0kofYHDYx4YYqps6SAnStaxbFbYL3OAahxwa+zrLtzpvG9TvGLxin0m9oHZ6ZkWTs+FAFcr2RH7aMkqvWXfDBEVeeAKBKsKokLR6UMb8D92pCivEFw3WhBsHN/cnngzLbvtWWTa1xOdwXZg0x8NqZ3vvosXej6RkxAXF9eFZgTesfQ9nbJscfzcyA5yl3YOEEfuZA2cDGLiX5Wcqc2nDqQsFklA/kGUIUzSufGRcYoAaalHNyfUlFTDLmydmCKv/0E0LkVEiLwx5lvaE7Y9RlPhuLRtxd38AfFYOQv83cq+eeFCJOtLi0BxUUbrA90VrX2y8Kep+8E6hDiZx1P/u7ZBPssua+TIWiILFKpe3MngaKZam99UGACS/AjHxTaDHSzBIMyxMmESgMN25xCHaB2WM8y4NoazI23j+qk/HYVgfwRPlxO0ADR6HcDaIFjQnDWQ2A==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(26005)(6666004)(6512007)(6506007)(53546011)(9686003)(82960400001)(186003)(5660300002)(33716001)(86362001)(6916009)(316002)(54906003)(7416002)(85182001)(83380400001)(66946007)(66476007)(38100700002)(4326008)(6486002)(66556008)(508600001)(2906002)(8936002)(8676002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cEcyWTV2TEZFcC96Q3RHc05PYmRrYkROQ3o2akh4Q1IyM2lzM2Rlb1lXNWM0?=
 =?utf-8?B?RVhQaVRsVGNVbWRPMk1UbE8vN281YWthdnJJRE5FWXVldlBKazhIQjdhL1FT?=
 =?utf-8?B?V0ZvV2kvaUp2MnFzODkvMks3WmlCVkdjQXUyTjNiQ3AvQ0gvV3R1dXk5UWFh?=
 =?utf-8?B?RnU2OFpONnpPRlovcmR6TUFnNCtXZitKU01XdjZvTFBoNHU0N1E5MG52YWZR?=
 =?utf-8?B?b3ZWODdZWG51QWhUWnYvNkVqUFBiVlc0eXN2MG5KeWt3TklkSy92a0FRVHA1?=
 =?utf-8?B?QUQ5VGxLK3lYRUpEaStVYkRqUmpuOVZYV1dxUjAyd3dpcTZrUm9XQWRWZld5?=
 =?utf-8?B?OVdzUHFqVVoyZzZPNmVISUFEVittK2NaWU10RXlmMUJsZWxGR2NPbUpnV25Y?=
 =?utf-8?B?ZU9IZ1FiQUt3bHZzRTh1L3pSYWU3YnoxWDBSNHNJZVFjYlU3VE91OWRoaHRW?=
 =?utf-8?B?cEVRZzhBdEg3K2IwUmRLT1gzVGczTFV4ZUhzckJBdTlRYVpZU0dmY0hWM0NL?=
 =?utf-8?B?SG9DQ2N6eitTM1ZVcGxnN3l4ZDZjOE5xTUFSOHVQT0lmUGZwbGV0ckQ1YVJL?=
 =?utf-8?B?OGhHV0QyL001cWtjV1JvMTdIK1dRZC9SekZMRGhNcDhMZEFmNjhXc050RkM3?=
 =?utf-8?B?MCtxZWtBckE3cWtZdjF2aTdTc2VQT3pXT04vRTZ1bWpzL2VBMjlsMkxyL0l2?=
 =?utf-8?B?YTNYaDRHbEFIeXdPNVBURnpCdjYySnNUYmcwWG9PT1luRUdyVFpGSytGSDht?=
 =?utf-8?B?czE0ZmdVUG9SeE41eFo1WFZFd3puZXI0QlprdmNNRXJlbXFtdU1HTVN0bWdr?=
 =?utf-8?B?WkllOXFiN3N6bFZoeVJTVWlCcnRmQTJxTHhJU1dPOGZGdUYzWTYxUWRkM0p1?=
 =?utf-8?B?YzFESzF5K0RuMkhqVFFUdFp1eVhUVXBrc1Q1NUhiVXd2T3BjelZEdzI1Rmt1?=
 =?utf-8?B?bGRnUzVld2NsNC9ZQVBmMXdFR0h4Q25Iby9KR0FrVDFOd1FzL2FuZitHRlpl?=
 =?utf-8?B?a0NkS21SZVJQWERiV0ZnVHVpTVFWMmhwalFUMTRIWXQ0NVB6c1F4TUNTbGEr?=
 =?utf-8?B?RHFWaEhtSkR1amNGVmJ3ZW5lMnVzMGxoQXBZQXUxbnh2S283ZHozdTJYTjVV?=
 =?utf-8?B?UWdMelc1QmhQYXUwWUpBY2VUQ1R0UjV3RFpsWlg1amNCcThGUDIwbnJ1Y205?=
 =?utf-8?B?L1NUYWZudXdSMmk2SlVmd3lQQnNiaGVhR2prUC9Vdk52dTVHR210UnlzeVcz?=
 =?utf-8?B?MUVoRkhrMDB4RGxKSFcySTVKK3RlOEk4bHJCQjk3YjVoZ1VsakdjT054Z0py?=
 =?utf-8?B?aFRSRkNpRWIyOGpxMjdJa3M4UHRLZWt0eEphN1BiVEZwMjN2d2dsNzVsVmFF?=
 =?utf-8?B?TXkwaWVyblNDd05ua3gxbDI1NHMwVnRCbmFJczJZVi8wdllseDcxK21jcE1h?=
 =?utf-8?B?ZDVpVlB2OVNFOGUxREJhdHl3OXpSK0NldzNPOHZWS0Z2enZmdFdsb0dadm5z?=
 =?utf-8?B?elgyREFWOFgrSGtpcUQ4Y3Q5Qno5T21vT3c0OVc2T0dNVGJoM3N5bE85Qm5H?=
 =?utf-8?B?MkVKRG5xMjY2ZTZSbzcvYURxblRzZzN6NVNDUHpaeHJRMHNmazNYOXNnNjFS?=
 =?utf-8?B?MmEweXZQaTZHM1JCOWo1SXg4T1BDTnJtTHJxNlcxL0ZrOURsdTlVSGFJMXZT?=
 =?utf-8?B?aWNOTkMyOTRCM3pCMmFvakJWc1dINmsyTVIxV1V4K0Z3ZlBRNkUxbGFhQnpk?=
 =?utf-8?B?TE0xVVZmaWFidjB0Vk05dHpRUmlTT0NHdXBvNThCay9mVzZvOThGeGQxWUw4?=
 =?utf-8?B?azFBdXBvMjBWdHdVaXM0S1I2NkNWdWhSczJNQzlSc2duMkJDUmxwM0I3eHd6?=
 =?utf-8?B?MFNQOEVrQWpVMk5HbFlqTjRURjZVV3RPNDBVclhseGV6SWVyR2lzYkJjUzJC?=
 =?utf-8?B?QjVSOWVaQXROaFBZNDJPcWlORjcyRW53THk0MStaSDRLcXFuKzliSmtvLzdj?=
 =?utf-8?B?SHA4UXU0QXV1dVYxRFJzN0JXYVVsR05BdGZKM2pvdEtSdXFCSEdwS0xhNCtX?=
 =?utf-8?B?MWk2ZWZmVTUrVjBlNk1HVXhERXBXSjV4R0dWVXEyT1IxZjBBR0ZjZkhDR09N?=
 =?utf-8?B?WWl0VzIzREM2UUVrNUxlMCtvcE5ERHNFbUdjRVdlNEl4R3NnK0tnZEhHTExp?=
 =?utf-8?Q?inYq+Qqgu2YkGwlazcszxNU=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4726d038-1b5d-45b1-76f0-08d9eaf0c60d
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2022 10:50:08.7800
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CShlM0uvU1VTTkdgYXrhJ8KXpvZ1dmvokqDnBcyG17trJIicPw2dABq7gqAKrfuP5UsDT0I3XWEmI2qe3Roxew==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR03MB2965
X-OriginatorOrg: citrix.com

On Tue, Feb 08, 2022 at 07:35:34AM +0000, Oleksandr Andrushchenko wrote:
> 
> 
> On 07.02.22 18:44, Oleksandr Andrushchenko wrote:
> >
> > On 07.02.22 18:37, Jan Beulich wrote:
> >> On 07.02.2022 17:21, Oleksandr Andrushchenko wrote:
> >>> On 07.02.22 18:15, Jan Beulich wrote:
> >>>> On 07.02.2022 17:07, Oleksandr Andrushchenko wrote:
> >>>>> On 07.02.22 17:26, Jan Beulich wrote:
> >>>>>> 1b. Make vpci_write use write lock for writes to command register and BARs
> >>>>>> only; keep using the read lock for all other writes.
> >>>>> I am not quite sure how to do that. Do you mean something like:
> >>>>> void vpci_write(pci_sbdf_t sbdf, unsigned int reg, unsigned int size,
> >>>>>                     uint32_t data)
> >>>>> [snip]
> >>>>>         list_for_each_entry ( r, &pdev->vpci->handlers, node )
> >>>>> {
> >>>>> [snip]
> >>>>>         if ( r->needs_write_lock)
> >>>>>             write_lock(d->vpci_lock)
> >>>>>         else
> >>>>>             read_lock(d->vpci_lock)
> >>>>> ....
> >>>>>
> >>>>> And provide rw as an argument to:
> >>>>>
> >>>>> int vpci_add_register(struct vpci *vpci, vpci_read_t *read_handler,
> >>>>>                           vpci_write_t *write_handler, unsigned int offset,
> >>>>>                           unsigned int size, void *data, --->>> bool write_path <<<-----)
> >>>>>
> >>>>> Is this what you mean?
> >>>> This sounds overly complicated. You can derive locally in vpci_write(),
> >>>> from just its "reg" and "size" parameters, whether the lock needs taking
> >>>> in write mode.
> >>> Yes, I started writing a reply with that. So, the summary (ROM
> >>> position depends on header type):
> >>> if ( (reg == PCI_COMMAND) || (reg == ROM) )
> >>> {
> >>>        read PCI_COMMAND and see if memory or IO decoding are enabled.
> >>>        if ( enabled )
> >>>            write_lock(d->vpci_lock)
> >>>        else
> >>>            read_lock(d->vpci_lock)
> >>> }
> >> Hmm, yes, you can actually get away without using "size", since both
> >> command register and ROM BAR are 32-bit aligned registers, and 64-bit
> >> accesses get split in vpci_ecam_write().
> > But, OS may want reading a single byte of ROM BAR, so I think
> > I'll need to check if reg+size fall into PCI_COMAND and ROM BAR
> > ranges
> >> For the command register the memory- / IO-decoding-enabled check may
> >> end up a little more complicated, as the value to be written also
> >> matters. Maybe read the command register only for the ROM BAR write,
> >> using the write lock uniformly for all command register writes?
> > Sounds good for the start.
> > Another concern is that if we go with a read_lock and then in the
> > underlying code we disable memory decoding and try doing
> > something and calling cmd_write handler for any reason then....
> >
> > I mean that the check in the vpci_write is somewhat we can tolerate,
> > but then it is must be considered that no code in the read path
> > is allowed to perform write path functions. Which brings a pretty
> > valid use-case: say in read mode we detect an unrecoverable error
> > and need to remove the device:
> > vpci_process_pending -> ERROR -> vpci_remove_device or similar.
> >
> > What do we do then? It is all going to be fragile...
> I have tried to summarize the options we have wrt locking
> and would love to hear from @Roger and @Jan.
> 
> In every variant there is a task of dealing with the overlap
> detection in modify_bars, so this is the only place as of now
> which needs special treatment.
> 
> Existing limitations: there is no way to upgrade a read lock to a write
> lock, so paths which may require write lock protection need to use
> write lock from the very beginning. Workarounds can be applied.
> 
> 1. Per-domain rw lock, aka d->vpci_lock
> ==============================================================
> Note: with per-domain rw lock it is possible to do without introducing
> per-device locks, so pdev->vpci->lock can be removed and no pdev->vpci_lock
> should be required.

Er, no, I think you still need a per-device lock unless you intent to
take the per-domain rwlock in write mode every time you modify data
in vpci. I still think you need pdev->vpci->lock. It's possible this
approach doesn't require moving the lock outside of the vpci struct.

> This is only going to work in case if vpci_write always takes the write lock
> and vpci_read takes a read lock and no path in vpci_read is allowed to
> perform write path operations.

I think that's likely too strong?

You could get away with both vpci_{read,write} only taking the read
lock and use a per-device vpci lock?

Otherwise you are likely to introduce contention in msix_write if a
guest makes heavy use of the MSI-X entry mask bit.

> vpci_process_pending uses write lock as it have vpci_remove_device in its
> error path.
> 
> Pros:
> - no per-device vpci lock is needed?
> - solves overlap code ABBA in modify_bars
> 
> Cons:
> - all writes are serialized
> - need to carefully select read paths, so they are guaranteed not to lead
>    to lock upgrade use-cases
> 
> 1.1. Semi read lock upgrade in modify bars
> --------------------------------------------------------------
> In this case both vpci_read and vpci_write take a read lock and when it comes
> to modify_bars:
> 
> 1. read_unlock(d->vpci_lock)
> 2. write_lock(d->vpci_lock)
> 3. Check that pdev->vpci is still available and is the same object:
> if (pdev->vpci && (pdev->vpci == old_vpci) )
> {
>      /* vpci structure is valid and can be used. */
> }
> else
> {
>      /* vpci has gone, return an error. */
> }
> 
> Pros:
> - no per-device vpci lock is needed?
> - solves overlap code ABBA in modify_bars
> - readers and writers are NOT serialized
> - NO need to carefully select read paths, so they are guaranteed not to lead
>    to lock upgrade use-cases
> 
> Cons:
> - ???
> 
> 2. per-device lock (pdev->vpci_lock) + d->overlap_chk_lock
> ==============================================================
> In order to solve overlap ABBA, we introduce a per-domain helper
> lock to protect the overlapping code in modify_bars:
> 
>      old_vpci = pdev->vpci;
>      spin_unlock(pdev->vpci_lock);
>      spin_lock(pdev->domain->overlap_chk_lock);

Since you drop the pdev lock you get a window here where either vpci
or even pdev itself could be removed under your feet, so using
pdev->vpci_lock like you do below could dereference a stale pdev.

>      spin_lock(pdev->vpci_lock);
>      if ( pdev->vpci && (pdev->vpci == old_vpci) )
>          for_each_pdev ( pdev->domain, tmp )
>          {
>              if ( tmp != pdev )
>              {
>                  spin_lock(tmp->vpci_lock);
>                  if ( tmp->vpci )
>                      ...
>              }
>          }
> 
> Pros:
> - all accesses are independent, only the same device access is serialized
> - no need to care about readers and writers wrt read lock upgrade issues
> 
> Cons:
> - helper spin lock
> 
> 3. Move overlap detection into process pending
> ==============================================================
> There is a Roger's patch [1] which adds a possibility for vpci_process_pending
> to perform different tasks rather than just map/unmap. With this patch extended
> in a way that it can hold a request queue it is possible to delay execution
> of the overlap code until no pdev->vpci_lock is held, but before returning to
> a guest after vpci_{read|write} or similar.
> 
> Pros:
> - no need to emulate read lock upgrade
> - fully parallel read/write
> - queue in the vpci_process_pending will later on be used by SR-IOV,
>    so this is going to help the future code
> Cons:
> - ???

Maybe? It's hard to devise how that would end up looking like, and
whether it won't still require such kind of double locking. We would
still need to prevent doing a rangeset_remove_range for the device we
are trying to setup the mapping for, at which point we still need to
lock the current device plus the device we are iterating against?

Since the code in vpci_process_pending is always executed in guest
vCPU context requiring all guest vCPUs to be paused when doing a
device addition or removal would prevent devices from going away, but
we could still have issues with concurrent accesses from other vCPUs.

> 
> 4. Re-write overlap detection code
> ==============================================================
> It is possible to re-write overlap detection code, so the information about the
> mapped/unmapped regions is not read from vpci->header->bars[i] of each device,
> but instead there is a per-domain structure which holds the regions and
> implements reference counting.
> 
> Pros:
> - solves ABBA
> 
> Cons:
> - very complex code is expected
> 
> 5. You name it
> ==============================================================
> 
>  From all the above I would recommend we go with option 2 which seems to reliably
> solve ABBA and does not bring cons of the other approaches.

6. per-domain rwlock + per-device vpci lock

Introduce vpci_header_write_lock(start, {end, size}) helper: return
whether a range requires the per-domain lock in write mode. This will
only return true if the range overlaps with the BAR ROM or the command
register.

In vpci_{read,write}:

if ( vpci_header_write_lock(...) )
    /* Gain exclusive access to all of the domain pdevs vpci. */
    write_lock(d->vpci);
else
{
    read_lock(d->vpci);
    spin_lock(vpci->lock);
}
...

The vpci assign/deassign functions would need to be modified to write
lock the per-domain rwlock. The MSI-X table MMIO handler will also
need to read lock the per domain vpci lock.

I think it's either something along the lines of my suggestion above,
or maybe option 3, albeit you would have to investigate how to
implement option 3.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 10:50:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 10:50:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268107.461895 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHO4y-00042W-0c; Tue, 08 Feb 2022 10:50:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268107.461895; Tue, 08 Feb 2022 10:50:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHO4x-00042P-Ts; Tue, 08 Feb 2022 10:50:35 +0000
Received: by outflank-mailman (input) for mailman id 268107;
 Tue, 08 Feb 2022 10:50:34 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JWzo=SX=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nHO4w-0003z3-8u
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 10:50:34 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ef662a64-88cc-11ec-8eb8-a37418f5ba1a;
 Tue, 08 Feb 2022 11:50:32 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ef662a64-88cc-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644317432;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=CcCLrbjqPFDfvnH5TeV6cL6muP0iCqcxn0lV354vxq4=;
  b=RMz4MSnX3vpfBF2OC8eCMYkAsI2YyP0+er7G9AlylIu97Wbp5Bf8Xzby
   t+2cp/B5Zf4NbjNTTM0igRWdl746AJNFMvtQalvTNRmmA45YE6JMFbjSW
   pQsoCWds/olgjbnQWr6BYkxWzE1/cCZgffR5k1YWHBrZDe4oRh2twqA9l
   I=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: xIDufEyvyBCoWa2NlrqxG/NdN69rpHBMTh5X/mYlNCAxEho4iGjXC8nc/azYhHB6ohzmJseMjK
 HJGAkwIJt5UAYw4jFqTRDBViLOADylPIEn2c5vylPh8AXYzvuToRrBqtk0Ot+cb/0hZUKiGW+z
 /bOqeEEUPN1UepfXcbIQu1gBtaiSOss5JIKQKVAC/gGNQc/H/sqXCwEzRurkNHRSFulIXqo5Vs
 fIcK0biT4X3itggL4tJBntIrNOTkT0jn1tjmIPHD5e6ARmlQBtzkjda/Zulc0zExa42KP3A4sd
 YuGFCrn6TYWGuvYkwMGmaF7R
X-SBRS: 5.1
X-MesageID: 63630989
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:xoezDamv8ZkoCI6+3S+dGrjo5gxHIURdPkR7XQ2eYbSJt1+Wr1Gzt
 xIaUDzQPv2IYmf8cot+OYuz9hxXsJbXzNBhGgZs+Xo8QyMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BClVlxJVF/fngqoDUUYYoAQgsA180IMsdoUg7wbRh2NY42YHR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 NFwn9uTTBUtAoTdptw0SCN8OR1MZpQTrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBMDtIIMYvGAm1TzDBOwqaZvCX7/L9ZlT2zJYasVmQ62AP
 JJIOWsHgBLoUgdIYnkaL6kCm+7v2nCmaGRnkWu/jP9ii4TU5FMoi+W8WDbPQfSVQe1Fk0Deo
 XjJl0zpDxdfONGBxD6t9nO3mvSJjS79QJgVFrCz6rhtmlL77m4cEhoNTnOgvOK0zEW5Xrpix
 1c8o3R06/JorQryE4e7D0bQTGO4UgA0X+d6VM4/+gWx47vq2y+CPEwucgwaUYlz3CMpfgAC2
 liMltLvIDVgtryJVH6QnoupQSOO1Ts9djFbO3JdJecRy5y6+dxo0EqTJjp2OPPt1rXI9SfML
 ydmRcTUr5EaloY12qqy5jgraBr898GSHmbZCug6N19JDz+Vhqb4PeRECnCBtJ6sybp1qXHb7
 RA5dzC2trxmMH10vHXlrB8xNL+o/e2ZFzbXnERiGZIsnxz0pSL/JNEJuW8vfh4yWirhRdMOS
 BWC0T69GbcJZCf6BUOJS97Z5zsWIVjISo2+C6G8gitmaZltbg6XlByClmbLt10BZHMEyPllU
 b/CKJ7EJS9DVcxPkWrnL89AgORD7n1vmgv7G8uhpzz5iuX2WZJgYepcWLd4Rrtit/3sTcS82
 4s3CvZmPD0FCLKnOXSModdIRb3IRFBiba3LRwVsXrbrCmJb9KsJUJc9GJstJN5ombp7jODN8
 i3vU0NU0gOn13bGNR+LejZob7a2BcRzqncyPCoNO1e02id8PdbzvflHL5ZnL6M68OFDzOJvS
 6VXccu3HfkSGC/M/C4QbMehodU6Jgirnw+HIwGsfCM7I8x7XwXM99K9Jlnv+SACAzCZr8w7p
 7H8hArXTYBaH1ZpDdrMaeLpxFS05CBPlOV3VkrOA99SZESzr9Q6d32v1qc6epheJw/Cyz2W0
 xetLS0Z/eSd8ZUo9NTphLyfq9v7GeVJAUcHTXLQ6qy7NHeG8zP7k5NASuuBYRvUSHjwpPe5f
 exQwvzxbK8HkVJNv9YuGrpn1/tjtd7mprscxQV4BnTbKV+sD+o4cHWB2MBOsIxLx6NY5lTqC
 h7epIECNOXbIt7hHX4QOBEhP7aK2vwjkzXP6eg4fRfh7yht8bvbCUhfMnFgUsCGwGeZ5G/9/
 dochQ==
IronPort-HdrOrdr: A9a23:V3K/QasSb9Y9EMMosvqfpkRo7skDdtV00zEX/kB9WHVpmszxra
 6TddAgpHvJYVcqKRQdcL+7VZVoLUmxyXcx2/h3AV7AZniFhILLFuFfBOLZqlWKcREWtNQttp
 uIG5IObuEYZmIasS+V2maFL+o=
X-IronPort-AV: E=Sophos;i="5.88,352,1635220800"; 
   d="scan'208";a="63630989"
Date: Tue, 8 Feb 2022 10:50:27 +0000
From: Anthony PERARD <anthony.perard@citrix.com>
To: Juergen Gross <jgross@suse.com>
CC: <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v3 4/5] tools/libs/evtchn: use _xen_list.h
Message-ID: <YgJK87Jr4Lmhu7cr@perard.uk.xensource.com>
References: <20220208070638.5909-1-jgross@suse.com>
 <20220208070638.5909-5-jgross@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220208070638.5909-5-jgross@suse.com>

On Tue, Feb 08, 2022 at 08:06:37AM +0100, Juergen Gross wrote:
> Instead of including xen-external/bsd-sys-queue.h use the header
> _xen_list.h in minios.c.
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>

Acked-by: Anthony PERARD <anthony.perard@citrix.com>

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 10:51:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 10:51:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268122.461907 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHO5W-0004ki-9r; Tue, 08 Feb 2022 10:51:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268122.461907; Tue, 08 Feb 2022 10:51:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHO5W-0004kb-6q; Tue, 08 Feb 2022 10:51:10 +0000
Received: by outflank-mailman (input) for mailman id 268122;
 Tue, 08 Feb 2022 10:51:09 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=v7zX=SX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nHO5V-0003ap-Eo
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 10:51:09 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 05943f13-88cd-11ec-8f75-fffcc8bd4f1a;
 Tue, 08 Feb 2022 11:51:08 +0100 (CET)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2104.outbound.protection.outlook.com [104.47.17.104]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-25-5t8rhl1xMmWVFiYYt5Iraw-1; Tue, 08 Feb 2022 11:51:07 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM0PR04MB4546.eurprd04.prod.outlook.com (2603:10a6:208:75::32)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.14; Tue, 8 Feb
 2022 10:51:05 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.018; Tue, 8 Feb 2022
 10:51:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 05943f13-88cd-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644317468;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=pmVqmvyWgB1BcDZOu2+pvCuRp8JYnwUvy5N26TGMCsY=;
	b=TcsXH1vXcITI94BAJjmeHjaVt+AFyxv53/KfwVGVCRebHLg9gxv4CCFcmRtciK8EeKdXfR
	nNHfab2IALGcyxcVS+WICR1t7jXXTtHBxvLdXpptPYAENpEmBaMk2WtwzgwliOtTLwuFxb
	Mg1F4WAlqLw9g+vaF+8VgDcBVmuY9uk=
X-MC-Unique: 5t8rhl1xMmWVFiYYt5Iraw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=MNZiTbTuTBDIpLD+0VNYgHGSwHId3lp/ZeTt2vSOWLAkektcx/DpmDhzaYm1zhBbvlfB1QNBifi6Ruf0JcMqyAPnZneCY2iUeDg/ZqWb/yMCcwkFSwK1ivswmI72HuvYcipGc25qEL5BB2gW6SpGRvkdsfG2hQcvLjstSxjI6x7CMIdskbxgnZPw6aPmhXeaZvR3HH2raD7yT9eav3ePB8vy8XMh2IIEH4rXYvjPSZeJxMKL2uPVSPp+/iDNFyPQ7gkjXesmDm8BesFVsiBG3r3RsWkzf1Ti508VwhR+cjapILAo4SluEBNGB1aL0/8ooWHWENjYy7vw/Y2Z29rZXQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=cVKN6yO42bbFFeWXodLK+XrYr1FH55QB74wAca7cttc=;
 b=cn7WZzNfZ2qYjpO88qs5ZeboyVzjzNwibaV/dkAxA6JE8argTvNjNRPpx2MLKPT+YLs9F4TkxtWskOP+u/y+6zrSpWlFHsKQze1bDFJaVHvr+JokEDu2CyNBXQLQOBSh1CX5SRMO4OnEeydMlLPglsP/X/Xlkcpk1HIbccaBdzZkhwlPBlbpTz7+sSUftAjNaBiuRIFmzqdFGBUj7DbBc3bGwJlP30qpkxoXHdPqn6cZYqO1jssBcYnhPNGqbofAl4jNiZmUJk7SUf/5I9p83vPP4xY0VFED9QEOAbsk4QE9V2mcmzPlDa5vU9dcAG4p/BoLDGPw3faj4wY/sh/ggg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <1680d537-fb6d-c589-66bd-f845b8280308@suse.com>
Date: Tue, 8 Feb 2022 11:51:03 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH] x86/Intel: don't log bogus frequency range on Core/Core2
 processors
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
References: <419db65a-a6f2-f812-d51e-7a23d065d460@suse.com>
 <YgIv3O8ojoDK+wiR@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YgIv3O8ojoDK+wiR@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6PR04CA0054.eurprd04.prod.outlook.com
 (2603:10a6:20b:f0::31) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e7b14ffa-6075-4eb4-b38f-08d9eaf0e7cf
X-MS-TrafficTypeDiagnostic: AM0PR04MB4546:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB4546B36DE5B4C5F5D55E1F59B32D9@AM0PR04MB4546.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	5W9Z5E67IgSPXM6putslXVe2/UU+hapOD+JvderfAcOp9d2n9jEmKBh3ZdmzjR75Q7jSJnQTYRuqKcrB39q4jNUe4MJbZCB7zD+Z0PuHy9ZgB3nXMGsSQXhDLnKg57Q8n7ytorAGPmlOhu6B4UVcUD/QxMG0tAJXEqEtJQveoNiTJ8Do/A78lFt5lwUGVB1NwD+BRcR44fwQ30IT4El6cb+JBbbgztgh9PvtMMpyj+P0DonmM1rXhl6QcHchfSr+g5zDr0tKVZpfKrd14VhOaPkmpqYQXPFYr9FqV9ZKfenpXSAuPIaw36rygZ2H1u7Mj7RXGw6FQFQK7KysE7DmiN4jg7tRkxOp5RcMXU3a+ZJlqGIXMjK5pKN2i3+SwgnVESUXR9CjHxhMXaDp7HiRM4Ctrx0JJte5FKeOGmOjR4MqAYkARoWK0YJ47JUGKU08+N2mZQXStHzzPdHK0hv1I8W8AzdY35f70u0IX89GSOko3p7VFRWxuCf3Y8Nq9mJD/jMNJBUBM/iwAls8KppHsSeCbxzgZvfUZqdFZ/2doQ9GJGSguPcbQ4K3TCj073Udig+XM4tsuqfOAKEqdicniJGCuLNF0Q68RcQlajNkOKBi4wBCkfAPj6an8iW1Yw90nATAkq5mLMoTOvZNOhh0MnBUGEZB3opHfN5liCykzvvZAhyW1B8pBBar2TMIo2W4Nxm6zueunTWpEf+XcL4mY35x3efN0IP7eUH158xlz6k=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6916009)(508600001)(36756003)(86362001)(54906003)(38100700002)(31696002)(6486002)(316002)(66476007)(186003)(31686004)(66946007)(6512007)(6506007)(66556008)(8676002)(53546011)(8936002)(83380400001)(4326008)(2616005)(2906002)(26005)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?q2KbO2GU2pob4iz3v8L3AV1mE671aFJHDcDr6+A5njG6DMwJ7lkWEmlrP6jo?=
 =?us-ascii?Q?plcCG9+rMmF9jUBtCJqVo8J1JQv4xtuEkNETCAxYEhdfSoT00aM68asIv05O?=
 =?us-ascii?Q?vKQSNUf9gn/2gLUs3r9qzFwRfgTPt/G3sK+fcc1IH9x+DwJGk510Tp1XkNCj?=
 =?us-ascii?Q?ZMPhLmhSoYIpCFwc4JTxHcL6hR9Lt1ihDSiysjE5KIa/wGz+ttx7FBGK4ubL?=
 =?us-ascii?Q?IwrKI8oDdH111sw9+cBzEhxJaWcOHcxk7WKau+ZcEpfoOAGhxUMSpxWZq41R?=
 =?us-ascii?Q?93Nlv6NcEchKBjMSXfDChfz5pbWle69/Fxzw3ILEuHCXIPmXy9qTwyJcabCE?=
 =?us-ascii?Q?alLnC4WIx7TQ2ciZLp7eMDBuIzdLE3OxrPbjffBWGdRWnnPsBBohHZa1YbrH?=
 =?us-ascii?Q?wX4HqmnwXAZGeQ+umA/aGCcz5tP96OWnWeRwQHYXHBqAphrgpsw/K6yAT5b3?=
 =?us-ascii?Q?jlXTBGwn5ULvkNkZE1mw8bYmBdnKf2xQsxsGVixPFkNVKs4NVys835DaIEFX?=
 =?us-ascii?Q?H7n4XyjtY2s9DYFYBNdr2TPToyqbaLLA2Lf2ArT+3AZ8UWHL12n/lxl0N1y6?=
 =?us-ascii?Q?aC5sOsDkY1JxINcJ8HtazpS/yDQn/DhnFsLLbCIUEerimvMGiKGGmv69bWdV?=
 =?us-ascii?Q?cWUaJhNKrs3wSQ/ugNHwBDGwTLQ2jjG4Cugz/6fvmf8E7fLiBk9tGXHLjRTU?=
 =?us-ascii?Q?9oRFxqG6rWuAv/K40ANvZsvRRqVqQDluc2Xw9WFKHMplmrHEgvwLFiOzctOz?=
 =?us-ascii?Q?X/sEb7dwSG7qsMpNWkCynynXdBet1Gdk/rn43snRfFTj1GzPdmZodLksW3pw?=
 =?us-ascii?Q?RAKVfrpYr6zBCTK13pt1OYp5ATnqnhr0+vf4gLdEAgefMCYqcZXwwWK7jyoO?=
 =?us-ascii?Q?9HE64Kdk0czoG+PAR6i2u9pkqBqX81P3BwktT9RZsfKMQQVgU2e6OFLxVxx0?=
 =?us-ascii?Q?itygXjqVQFrbbcz4U4k4CnwfdcorN8ezBmRyhSR8W2K18INYzggppOA1Ehc7?=
 =?us-ascii?Q?T1y9qyy1jVcEnKRUOjVOz6W0S+4qI06esyZzyrdiVS7K6FAKLJefzrB7biyJ?=
 =?us-ascii?Q?AiuepNSjtJMTOyo0qMd5ejcVWoys3u6Z6Nob08Xe6FtqwJc9qLXotbQcbibb?=
 =?us-ascii?Q?3FgJrn61NVfr5Q8AW5lyfXyJcQ6DGW5CNWz9O73pjbQlCTSOFwXvDQ3a9Esq?=
 =?us-ascii?Q?lhNLQ3bWMERTKjSqCc6DX4+91vRIbqbsj/124RwSj43j+WjYnmxRvKXboSHJ?=
 =?us-ascii?Q?JLXb9pdy6vC/fkjxnFxfDtwJI7PH5YZM+B6+d+FUwOaO/qREPWuvrLzbJfM6?=
 =?us-ascii?Q?hQBNxI4r2hqLzTAc6pO3/+wldAP3UxPRrOTd/zUSCN1YXn3FxLDQ75q7wsgr?=
 =?us-ascii?Q?0JR6Stp/LK3ZtfQTQeAvwOmampbAvsOQYPts92AhowRmHxTca7xPe/XtrazC?=
 =?us-ascii?Q?BB55jvCj7G1NmRvUix8oi45ypaRPOGAC+w4nPc/hA20c8BqWeAiUi5VUazw/?=
 =?us-ascii?Q?D5v9+gw2OKfbfp5Dl4wNNFwcd+e56ruGHPv0tB70d0AczLToF4VaxABFKQor?=
 =?us-ascii?Q?tfhWTg7OiIs47uvfp+n/VnWWPYH+BrcRMMVNLLWPFyVyZyTc/An/h6Qtn6X5?=
 =?us-ascii?Q?ZMqZFQvS40+6xI6Tve+QIBw=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e7b14ffa-6075-4eb4-b38f-08d9eaf0e7cf
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2022 10:51:05.3710
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Oz4qG7L9SzCEw1Z/3vI/IwAwtnLuEQMjybglsF3XFLxOBegoxXOKQBe7oqMSOot1FcnJcbT/oMB3TxvbQrHf2g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4546

On 08.02.2022 09:54, Roger Pau Monn=C3=A9 wrote:
> On Fri, Feb 04, 2022 at 02:56:43PM +0100, Jan Beulich wrote:
>> Models 0F and 17 don't have PLATFORM_INFO documented. While it exists on
>> at least model 0F, the information there doesn't match the scheme used
>> on newer models (I'm observing a range of 700 ... 600 MHz reported on a
>> Xeon E5345).
>=20
> Maybe it would be best to limit ourselves to the models that have the
> MSR documented in the SDM?

Well, yes, that's what I wasn't sure about: The information is used only
for logging, so it's not the end of the world if we display something
strange. We'd want to address such anomalies (like the one I did observe
here) of course. But I wonder whether being entirely silent is really
better.

>> --- a/xen/arch/x86/cpu/intel.c
>> +++ b/xen/arch/x86/cpu/intel.c
>> @@ -435,6 +435,26 @@ static void intel_log_freq(const struct
>>          if ( c->x86 =3D=3D 6 )
>>              switch ( c->x86_model )
>>              {
>> +                static const unsigned short core_factors[] =3D
>> +                    { 26667, 13333, 20000, 16667, 33333, 10000, 40000 }=
;
>> +
>> +            case 0x0e: /* Core */
>> +            case 0x0f: case 0x16: case 0x17: case 0x1d: /* Core2 */
>> +                /*
>> +                 * PLATFORM_INFO, while not documented for these, appea=
rs to
>> +                 * exist in at least some cases, but what it holds does=
n't
>> +                 * match the scheme used by newer CPUs.  At a guess, th=
e min
>> +                 * and max fields look to be reversed, while the scalin=
g
>> +                 * factor is encoded in FSB_FREQ.
>> +                 */
>> +                if ( min_ratio > max_ratio )
>> +                    SWAP(min_ratio, max_ratio);
>> +                if ( rdmsr_safe(MSR_FSB_FREQ, msrval) ||
>> +                     (msrval &=3D 7) >=3D ARRAY_SIZE(core_factors) )
>> +                    return;
>> +                factor =3D core_factors[msrval];
>> +                break;
>> +
>>              case 0x1a: case 0x1e: case 0x1f: case 0x2e: /* Nehalem */
>>              case 0x25: case 0x2c: case 0x2f: /* Westmere */
>>                  factor =3D 13333;
>=20
> Seeing that the MSR is present on non documented models and has
> unknown behavior we might want to further sanity check that min < max
> before printing anything?

But I'm already swapping the two in the opposite case?

Jan



From xen-devel-bounces@lists.xenproject.org Tue Feb 08 10:51:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 10:51:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268125.461918 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHO60-0005JS-KY; Tue, 08 Feb 2022 10:51:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268125.461918; Tue, 08 Feb 2022 10:51:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHO60-0005JL-Fd; Tue, 08 Feb 2022 10:51:40 +0000
Received: by outflank-mailman (input) for mailman id 268125;
 Tue, 08 Feb 2022 10:51:39 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JWzo=SX=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nHO5z-0005J1-Mx
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 10:51:39 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 16273b4a-88cd-11ec-8eb8-a37418f5ba1a;
 Tue, 08 Feb 2022 11:51:38 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 16273b4a-88cd-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644317498;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=ox0uNlqHW4ULvVZYBBjZXTM1qA4YfXL7QBaxKxHfwUg=;
  b=MQsGPUACwNZUBwHB92lji5X0aB1CNkgqV4KvXBqOEkLcQE0VkS0d9FbC
   bafKMu0yeIOjRVdjOqFtyiiFrWhnTiQzmwK3jl6njsJolIQJVl0vhAU2P
   G3/SR7sKGCKz/GV1L/geSBcEiM+7UCXKl82boBwQonucinnn/J7gpHzIc
   w=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: xe/G4h5WK2pJSUywLkEIJifiuyN5LNkPvpPaPx6w3QHE5afocw5OCYXMUmm09ZCH9cU4KnJAlz
 zqxr6lateR2+JqUHR5Y2/oF4JR/Ts3ny6No6XT5DZNO3hhVolnM1X6tYjOGn6UHdf2HEgBoAsY
 UDyv9ssRCfGo9it0hU11egemsVkXfr5mf71oBHp/khc7OhStFlhfr4vivSdiNOTPm1LOipfpo5
 U7YGlYrQeVo+iS1UnckdreqnC2ok4afvEDie5HVmlci/63rDDqS0RcUMM0A1T/DQnAwsyQ9AHr
 CeCTLWgHwohtRXRvy2VheOQt
X-SBRS: 5.1
X-MesageID: 64125637
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:MCVtD6wyY2dsL0zzDhp6t+fxwSrEfRIJ4+MujC+fZmUNrF6WrkUFy
 TYaWWCCOqzfYjOkLdsjO46+80sPsJfdxt5hSVFl/iAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAhLeNYYH1500g7wbZp2tcAbeWRWGthh
 /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL
 wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt/826
 vVnqJ6Vcx0oB/LFoPlNT1p+MxgraMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr
 6ZBbmlQMFbT3Ipaw5riIgVors0lMMnsOpJZonx6xCvVJf0nXYrCU+PB4towMDIY2JwXR6uAP
 JVxhTxHMAyYX0FMHVorFr0Os+WsvGGhXGcCkQfAzUYwyzeKl1EguFT3C/LKfvSaSMMTmVyXz
 krW8mK8DhwEOdi3zTue7mnqluLJhTn8Wo8ZCPu/7PECqF+c3GsIEzUNSEC25/K+jyaDt8l3c
 hJOvHB09O5rqRLtHoKVswCETGCskVk+e/BNEcgA8gC0laPs/laFRU4kd2sUADA5j/MeSTsv3
 16PutrmAz1zrbGYIU6gGqeoQSCaYnZMczJbDcMQZU5cuoS4/tlv5v7aZos7SMaIYsvJ9SYcK
 txghAw3nP0tgMECzM1XFniX0mv39vAlouPYjzg7v15JDCskPuZJhKTysDA3CMqsy67DHzG8U
 IAswZT20Qz3JcjleNaxaOsMBqq1wP2OLSfRh1Vid7F4qWjxoi/6JN4BumglTKuMDirjUWW4C
 HI/RCsLvMMDVJdURfMfj32N5zQCkvG7SIWNugH8ZdtSeJlhHDJrDwk1DXN8K1vFyRB2+YlmY
 M/zWZ/1UR4yVPQ2pBLrFrx1+eJ6mUgWmziJLbillEvP7FZrTCPMIVvzGADVNb5RAWLtiFi9z
 uuzwOPQk0oGC7ClMnCMmWPRRHhTRUUG6VnNg5Q/Xoa+zsBOQwnN0tfdnuEsfZJLhaNQmrua9
 32xQBYAmlH+mWfGOUOBbXU6MOHjWpN2rHQaOy0wPAn3hyh/MNj3tKpPJYEqebQH9fB4yaImR
 fcyZMjdUO9ETS7K+mpBYMCl/pBibhmimSmHIzGhPGokZ5dlSgGQoo3kcwLj+TMgFC2yscdi8
 bSs2hmCGcgIRhh4DdaQY/WqlgvjsX8YkeN0fk3JPtgMJxm8rNk0c3T816ZlLdsNJBPPwiqh+
 zyXWRpI9/PQp4IV8cXSgfzWpYmeDOYjTFFRGHPW7OjqOHCCrHaj24JJTM2BYSvZCDHv4Kyna
 OhYk6P8PfkAkAoYuoZwCe82n6c35t+prL5G1AV0Wn7Mag3zWL9nJ3CH2+hJt7FMmeAF6VfnB
 BrX94kII6iNNePkDEUVdVgsYem03P0JniXfsKYuK0Lg6S4rpLeKXC2+5fVXZPCx+FetDL4Y/
 A==
IronPort-HdrOrdr: A9a23:9wssiqq4ZPUXPZ0CcdR9iTkaV5oreYIsimQD101hICG8cqSj+f
 xGuM5rsSMc6QxhPU3I9ursBEDtex/hHNtOkO4s1NSZLWvbUQmTTL2KhLGKq1aLJ8S9zJ8/6U
 4JSdkZNDSaNzlHZKjBjzWFLw==
X-IronPort-AV: E=Sophos;i="5.88,352,1635220800"; 
   d="scan'208";a="64125637"
Date: Tue, 8 Feb 2022 10:51:32 +0000
From: Anthony PERARD <anthony.perard@citrix.com>
To: Juergen Gross <jgross@suse.com>
CC: <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v3 5/5] tools/include: remove xen-external directory
Message-ID: <YgJLNHd9v7+FJIoW@perard.uk.xensource.com>
References: <20220208070638.5909-1-jgross@suse.com>
 <20220208070638.5909-6-jgross@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220208070638.5909-6-jgross@suse.com>

On Tue, Feb 08, 2022 at 08:06:38AM +0100, Juergen Gross wrote:
> There is no user of tools/include/xen-external/* left. Remove it.
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>

Acked-by: Anthony PERARD <anthony.perard@citrix.com>

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 10:52:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 10:52:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268140.461928 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHO6Z-0005yl-Rm; Tue, 08 Feb 2022 10:52:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268140.461928; Tue, 08 Feb 2022 10:52:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHO6Z-0005ye-Og; Tue, 08 Feb 2022 10:52:15 +0000
Received: by outflank-mailman (input) for mailman id 268140;
 Tue, 08 Feb 2022 10:52:14 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nHO6Y-0005yP-LD
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 10:52:14 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nHO6Y-0005e9-IJ; Tue, 08 Feb 2022 10:52:14 +0000
Received: from 54-240-197-232.amazon.com ([54.240.197.232]
 helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com)
 by xenbits.xenproject.org with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nHO6Y-0006a4-A7; Tue, 08 Feb 2022 10:52:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:
	Subject:Cc:To:From; bh=FxGkKIgDk3gxIXLFThwrFZY1HTiAnaiBqRB9nXCxkNc=; b=wETh9V
	e7wINGYZboxUpaRAA7STrxo4K7RjcJoIr5e5hAOuEJ9U+dEII0kq1D7ZHTYNYwlNFCkWuOGbZI+Ub
	2w2YRvuB01Kc+VIc7D63Y/QU6uxwVGVDhb9+nq6OEfBi0uhtqDoul+LHbFSnYfb2c6yTdfvrN7hYw
	rw0oqdc3Vyk=;
From: Julien Grall <julien@xen.org>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	Julien Grall <jgrall@amazon.com>,
	Jan Beulich <jbeulich@suse.com>
Subject: [PATCH] xen/efi: Use PrintErrMsg() rather than printk() in efi_exit_boot()
Date: Tue,  8 Feb 2022 10:52:11 +0000
Message-Id: <20220208105211.96727-1-julien@xen.org>
X-Mailer: git-send-email 2.32.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Julien Grall <jgrall@amazon.com>

The function efi_exit_boot() will be called within the UEFI stub. This
means printk() is not available will actually result to a crash when
called (at least on Arm).

Replace the call to printk() with PrintErrMsg().

Fixes: 49450415d6 ("efi: optionally call SetVirtualAddressMap()")
Signed-off-by: Julien Grall <jgrall@amazon.com>
---
 xen/common/efi/boot.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c
index 2bc38ae40fff..4ef75e472d29 100644
--- a/xen/common/efi/boot.c
+++ b/xen/common/efi/boot.c
@@ -1181,8 +1181,8 @@ static void __init efi_exit_boot(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *Syste
                                           mdesc_ver, efi_memmap);
     if ( status != EFI_SUCCESS )
     {
-        printk(XENLOG_ERR "EFI: SetVirtualAddressMap() failed (%#lx), disabling runtime services\n",
-               status);
+        PrintErrMesg(L"EFI: SetVirtualAddressMap() failed, disabling runtime services",
+                     status);
         __clear_bit(EFI_RS, &efi_flags);
     }
 #endif
-- 
2.32.0



From xen-devel-bounces@lists.xenproject.org Tue Feb 08 10:52:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 10:52:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268145.461940 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHO6v-0006XG-5l; Tue, 08 Feb 2022 10:52:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268145.461940; Tue, 08 Feb 2022 10:52:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHO6v-0006X9-1w; Tue, 08 Feb 2022 10:52:37 +0000
Received: by outflank-mailman (input) for mailman id 268145;
 Tue, 08 Feb 2022 10:52:35 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1FiY=SX=epam.com=prvs=40383cc40e=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nHO6t-0006UC-Md
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 10:52:35 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 37edfa71-88cd-11ec-8f75-fffcc8bd4f1a;
 Tue, 08 Feb 2022 11:52:34 +0100 (CET)
Received: from pps.filterd (m0174677.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 2189EAPR015894;
 Tue, 8 Feb 2022 10:52:30 GMT
Received: from eur01-db5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2056.outbound.protection.outlook.com [104.47.2.56])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e3nq28f5s-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Tue, 08 Feb 2022 10:52:29 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by DB7PR03MB4585.eurprd03.prod.outlook.com (2603:10a6:10:1e::18) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Tue, 8 Feb
 2022 10:52:22 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77%3]) with mapi id 15.20.4951.019; Tue, 8 Feb 2022
 10:52:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 37edfa71-88cd-11ec-8f75-fffcc8bd4f1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=JXOwJ3wKHU0E1wI13LklGynN59Fq6GRxhG5jeHNT8CEKf6xophhfNEnPdzO5z/vbM/jAhEexVTQjU3tey89Yai44d2r4oFOJQgfMjIx7wJ16zqTnbXwTJnkix/ST+Riv9R166BpHi8lm6Ta5NTjcTTn9c5ag/COhzHW6zMYY8kfFlCqVwFW2OnFleJaV04hGn5deSxU3LWWMHArg/9fBFGGwlKuv6UsgVVoG9ye3Hg1EgHpVKZ1P6lstiAFLqxXAa3bxMVaaAxmW7onv/HGIzlevaHnueiSb/LcMd37bq4GvV9YwH9VifL7dX2URMIlj9NqON2vm1pvcE1E+nxR7EQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=+9SZfZxGTTty1EpuGtyOLVp5vR8yWfkL0Fvzux6fbUM=;
 b=npjTR5vgDI8ca6A2AWItVJk2RQtTetiP11797ggJAdZ5WMFHJZ2TkBfTMWYckFbgtTdwRr8QhlixrgHp4rfSk7jNQKYHi4ZMUZvmcTpoheFbasP8N74vTu+TWlizg3zu+vJrVkBiqp6ooz6F+BrINaHft9XzW9QPi9hQn6vEipCnhCjILFWORKNG1cJ/jWa7+QSwwSSl9INLHTlZ9qYtsQK+lGf4KJ/bYfdkaF3pasoQX3MhDmp4ByrtKLwoJbi6/mKdiBuZ5S/L5IZLwFxAhMAAphhLViiU0FugysVGXjCoAXYZTWTxDj+DBD254cuONKfLqPc25h6aBeZjmdGQDQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=+9SZfZxGTTty1EpuGtyOLVp5vR8yWfkL0Fvzux6fbUM=;
 b=FCB1obXX4lEU+xGaapgq9g9Ic2WmNzJfyZZgTtuY7Wul3JQenJitIp4uxGD2q/dkiof2FNoVJ4xz+inkOchH0XZ8EUp24lcBJv7IrrhTcNflSIPDVBTkrO+3uGGHQ7pSkBl2hcQsI1H6MTMlDZHKdjVJIM2XLRHyzSiqQGgp4emmf6zD4UYa7H1371biyxs0jzmUelspZ6a8rzlAXcnpVe9n6zPr4y5S4rB+xZZprLE4+hSnbNxRAizWwC/GzLMGvGkH9S1zp3dqKqf+8lnVY69rh+dDsz6PXV9zodcZa5AbqVoP8rSzrKi49d9oeI3Y6HG2XCgMg+2AWwkphboqPg==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        "roger.pau@citrix.com"
	<roger.pau@citrix.com>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v6 05/13] vpci: add hooks for PCI device assign/de-assign
Thread-Topic: [PATCH v6 05/13] vpci: add hooks for PCI device assign/de-assign
Thread-Index: 
 AQHYGZFdYv4W1RdbQkeQtzN+PyKqmqyITGQAgAENNICAAAt2AIAAA+uAgAAEsACAAAMyAIAABAgAgAADmACAAAHqgIAABl2A
Date: Tue, 8 Feb 2022 10:52:22 +0000
Message-ID: <15022045-bc92-e3df-b005-aeec5e36a078@epam.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-6-andr2000@gmail.com>
 <16cea1df-3d0f-d404-2b88-aab47ad5548b@suse.com>
 <3fe6dbe3-51c6-f87f-23f9-cf2e1a924326@epam.com>
 <582ee8f9-7b01-4adc-6a8a-ce8b1dffd534@suse.com>
 <e225553b-b29c-0448-fb9f-f8b513d9f77d@epam.com>
 <0fd8a0ac-dc91-287e-536e-1684892837ab@suse.com>
 <9f58a8ff-44b4-3249-5858-9988644b2d4e@epam.com>
 <15c16171-f196-38d2-370c-38627935a21b@suse.com>
 <20762939-6b7e-ff60-7c1a-d47c4767ff4f@epam.com>
 <10cd89b5-a804-3354-26d8-bc271bd9c5e6@suse.com>
In-Reply-To: <10cd89b5-a804-3354-26d8-bc271bd9c5e6@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 0456b45d-b442-4ead-fc5e-08d9eaf115d2
x-ms-traffictypediagnostic: DB7PR03MB4585:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <DB7PR03MB4585C35A207D2D7A4F219BFFE72D9@DB7PR03MB4585.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 HjH/zP8uIo3J+lwqb9Cmku4u8Ws3jnbAIdnXnU9rCvzGUL85gHgwP++aoSyv3Ano7WO7Fp3MuOdwe0auIY2S4Vk6m0pW4fm9DamhT5nVKX6rJSnHWEzs49gqpqcdsw3FhhCO/B1cYBpXjORA0tIC/jw0RueGHqPtHBZkuC4NdHiBpRmkdY5HjHe2+f8m5UZvxEhUJJsMbRnmKyiUmB8EXkrLEmvOZPeB7XvINDqWyWhTZ/HK/VAIddM5zZVe7QT9OjB3BoESUwKqMGCPcEbuwHrFYo0wlAdAq6+YayTypePiI3Lz9xNOW7yMeXoepEJ6WfjfUlPh3KUdj/qVU//uuxJYFHdKjI1OvIawuP7dwNmRbsX/XoVo9V6idlHmr2xr56jzIY4betFChVDPYU6o8tL0srs3LR+274W+3IEczV0RlCZ1BV5NMM//NtoSEw4J6/hBSckviwNKBEi5rv0yW7OFwDIV2odHdd8LInHN4FC6w+3O3gYBwFoTpXT6SUkgtxiys4dCEaEsLZYeY4rIumgsihAtcIQyCDjRgYajXPmyrNVU19N2emi+SlZfF6AkSmIitLArPcinvP5FvnwVlwTtc7He9/yHdGIJ+RaC6e2JWjCcUi4ElUKm92ITIU8lZ66R5R7JqBISIqmXb2aAXWaZbBgQZVbhsZnbH2goagAi1ZpBelwYjFo0s8CY+n2wwlwFzu7yA4/12QFk5A5xKUrXQ5VknzwQHjfzxSXZkl36g3kXIRJxecsTbzXataJv
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(2616005)(55236004)(36756003)(26005)(508600001)(38100700002)(38070700005)(6512007)(31686004)(31696002)(6506007)(71200400001)(186003)(86362001)(54906003)(6916009)(83380400001)(316002)(107886003)(53546011)(64756008)(8936002)(66946007)(8676002)(91956017)(66556008)(66476007)(6486002)(122000001)(2906002)(7416002)(5660300002)(76116006)(4326008)(66446008)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?cjQwZzYxRC92ZmpKQnhxUUJ6MEFWaUw4aDFQUzIxUXNEb3Q5ODhTR0thMUIy?=
 =?utf-8?B?YzkrdXltU2llanArdmFocVZWTUdLRUlETFRXK2QrZE9sMy9SdGZxdEZYQVpm?=
 =?utf-8?B?VTdiTEVsbUhlV0RpN0t3QmtaYmFzeXhMT0o3L3puZG1CZWZ6bWZpa2I4RE9W?=
 =?utf-8?B?bFRjSkU3YzU4SE1peXNWWUJUWk54T0FzODdzRm9qNzZSNFJRMjg5U3ZVNGVa?=
 =?utf-8?B?YlZTcDVxRjRoNmZUVFVqaDYya1RGY3BEMmlTZyt1SU9QR2d0K2t4ZnhjenBq?=
 =?utf-8?B?OFQ1eno4MkV4UEVIOUp5aVhEc1ZQNUZoeitBdjJ6b2gvTE54YWwyWEJUTjh2?=
 =?utf-8?B?cy81QlRhbVF3YThXdjVtc2RnS3hqc1JxSWNuVkd5S284Q2tvejRnWk9zdUdO?=
 =?utf-8?B?aTVocEtEdm5OcFZvQ0Qva1FKR0hzNkl3S2dVa0Y4SVZHM2U3VnlZd21qL210?=
 =?utf-8?B?eTlNUVBKRjhVRGU3V25CUWl6RE9Lang0emNKeEZLZ3RoWTFNVE96eTNVQ0Fw?=
 =?utf-8?B?K0tKTzhzZEplZldmVnNVNktmQzN5UGxxL2ljbXVySmRoUGpnWStzdXlXNTJu?=
 =?utf-8?B?SWVGNFhhTGRXODZyMXlKYVJva09nalJUSE9FbGx1L2RHcXRUQ0ZOeFdwaFhz?=
 =?utf-8?B?elowaWIydnZnc3pzRlFNSGx3M0lWT2U3aGRNcnBVQUtUSE9abzlPTkF1UmxW?=
 =?utf-8?B?d2V2cEtudFJJQnNkRUNYb1ViZFRsSm81M1BXSHc4cGJSMGhKR2VTd3AzWWkv?=
 =?utf-8?B?V3hWc2wycFVkbElhc2RORTRSVUpZUW5LZmR6emV5b3JVTDErR1JpTGhQWnBv?=
 =?utf-8?B?T3dWbG1KZXA2aU1iSTQ0MXFhbktDN0M2RnhzZldJTGVVN0dNeFZ2NUwxV2c4?=
 =?utf-8?B?RmYyc0l0M2ZWNy9HaUd0V21KQW1KWTZLenBXUzZZUGpVdGlJVXNaU1RvWDlY?=
 =?utf-8?B?bTNnZGNPWFIwS1gyZzBBVUR5bnNsVDVIb1owbVFWdk1JYTJXdWcxMEZlVXBD?=
 =?utf-8?B?RC9xVEFPMWpxSFE4L01wNHZ1dmhCdFVzc1pwNnFNVEdKeDErRHF2TDNhUU1p?=
 =?utf-8?B?RiswUk5YTlBJK29vRUFUQ0cvUkl3N1pwWXkzNE91VGs5TllodVhZSnZHZVJn?=
 =?utf-8?B?Q01vbk0xeHB6T3FEOWVjbHhsTUVKakQwNXhlRU95VGo3aUUxNndkWHNyeTYv?=
 =?utf-8?B?ZjNrcmZXNTF0TkpReW1SeXZtVHllVjQxMnIrWElXTHpGMThBdFA0SUhhb3BI?=
 =?utf-8?B?Z2JqeFVOalVNVlVuc1MzQ0V2QjMzb0wvREQvdHJPY1B5UERhNkh3MVZhcWla?=
 =?utf-8?B?dm1LYUlmU2dGT3k3WUtyWE5mU3BHZVYwRU5zUW5PNGRhSU5FeFVodGY1NU5l?=
 =?utf-8?B?ZTVFck5Ma3lIQjIyUmtrSlBTeFU1SW1NcVA0UUljbE04TFhNWlFPaG45eGxH?=
 =?utf-8?B?c04rTmtCdVJ5TG55MTNHNjVvb01TamNYZ2IvbkFOVytvNFpTU2g3ZDBjaEV1?=
 =?utf-8?B?MFN5Y0dzMExGZEpnQzgzbk52eDRwbThsNW9Nemp2d0R4TGgya1p6T3dyUVNL?=
 =?utf-8?B?aFcxam5oc1VsZmZBZlh4TkpQU2pZS09BclhaK3NSYk5DVDA5NkhBOEp4b1R4?=
 =?utf-8?B?NFN3N1gySllyTXJ2aXVkR09DL254c3ppN2NvQisrYTdkYnRUV0J2d3c5eEd2?=
 =?utf-8?B?WHliQTB6N2V0K1ozWFUxcmpxbzlRSXRWaXdEYW55aXA0V0UrSHhZSjVsK00w?=
 =?utf-8?B?ODlpSVhtT1NTKzZ5YWllZDhuT2VUSGNvai9XTG1sakI3R1ZTTnYweG5wK0M2?=
 =?utf-8?B?a2g1QnQwNEg3NVJ3eThhSXJXc3RmZlJpMHk3ODgvOXRWZjRkeFY0VktkOGVi?=
 =?utf-8?B?blgzOWg4ejR6OGdyZXFFMC9NSUF4dGpFVTNPMmw0eFJqd1UzL3dtUThxTG85?=
 =?utf-8?B?TzE4Nkwrazd5REo0UHZSczRndUVLenNMV1dxRlVoVWxKaUdzeGc1NGo2eVVR?=
 =?utf-8?B?dGEvV1ZBcVdsbEN6WWtMWjVTNkhVdE16K3U4cndsTC9yemhncFE2cXpUejJk?=
 =?utf-8?B?Nml4ZWUya2VQeUFJd2hoNWJNaDhsN1djNVBhanA5MExscmRObjh6N3M0NjFQ?=
 =?utf-8?B?dlFkWHdIZlI2THl4ZVdxWjJ6Y0IzSzBKNldGVmp0OHlIcHNPVnVvTmRUNjZo?=
 =?utf-8?B?K2R2dWR2S2lGTkR3SkdaTmEzRnc2VDdLakg0T1NQak81L3F5V2sxaXhKU1la?=
 =?utf-8?B?eGE3WkZiT25WN010QnpKOXRxS1M3TWhjaVRxNENXV1A4eHRvM2UvRVJRZURx?=
 =?utf-8?B?R2JZcGx0eHArVytiK3JkcThjdzQ1LzNnVzZHOGFwdFJkU0xZUW5TZU5GczFi?=
 =?utf-8?Q?ySEMQveU4YlceJa0=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <7560D7732A8EBA45A000C84578642DC0@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0456b45d-b442-4ead-fc5e-08d9eaf115d2
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2022 10:52:22.2396
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: HAIVv+t+Q6AYMilkirs1BDLCnDLfgByQVETR1IlRhz+LsgqQ+XJ9RDYeQyy1OWujlJu+9TH7/KeW+qtOFelobl1aaSMfxdYn0EAWMEnaiF7etglc4sVzivnLjpB+74pO
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR03MB4585
X-Proofpoint-ORIG-GUID: dT7P-Lm6FLRc6h2UBmcL98tM6uHxb6fj
X-Proofpoint-GUID: dT7P-Lm6FLRc6h2UBmcL98tM6uHxb6fj
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-08_03,2022-02-07_02,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0
 phishscore=0 lowpriorityscore=0 adultscore=0 priorityscore=1501
 malwarescore=0 spamscore=0 impostorscore=0 bulkscore=0 mlxlogscore=999
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202080064

DQoNCk9uIDA4LjAyLjIyIDEyOjI5LCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMDguMDIuMjAy
MiAxMToyMiwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+Pg0KPj4gT24gMDguMDIu
MjIgMTI6MDksIEphbiBCZXVsaWNoIHdyb3RlOg0KPj4+IE9uIDA4LjAyLjIwMjIgMTA6NTUsIE9s
ZWtzYW5kciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4+PiBPbiAwOC4wMi4yMiAxMTo0NCwgSmFu
IEJldWxpY2ggd3JvdGU6DQo+Pj4+PiBPbiAwOC4wMi4yMDIyIDEwOjI3LCBPbGVrc2FuZHIgQW5k
cnVzaGNoZW5rbyB3cm90ZToNCj4+Pj4+PiBPbiAwOC4wMi4yMiAxMToxMywgSmFuIEJldWxpY2gg
d3JvdGU6DQo+Pj4+Pj4+IE9uIDA4LjAyLjIwMjIgMDk6MzIsIE9sZWtzYW5kciBBbmRydXNoY2hl
bmtvIHdyb3RlOg0KPj4+Pj4+Pj4gT24gMDcuMDIuMjIgMTg6MjgsIEphbiBCZXVsaWNoIHdyb3Rl
Og0KPj4+Pj4+Pj4+IE9uIDA0LjAyLjIwMjIgMDc6MzQsIE9sZWtzYW5kciBBbmRydXNoY2hlbmtv
IHdyb3RlOg0KPj4+Pj4+Pj4+PiBAQCAtMTUwNyw2ICsxNTExLDggQEAgc3RhdGljIGludCBhc3Np
Z25fZGV2aWNlKHN0cnVjdCBkb21haW4gKmQsIHUxNiBzZWcsIHU4IGJ1cywgdTggZGV2Zm4sIHUz
MiBmbGFnKQ0KPj4+Pj4+Pj4+PiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwY2lfdG9f
ZGV2KHBkZXYpLCBmbGFnKTsNCj4+Pj4+Pj4+Pj4gICAgICAgICAgIH0NCj4+Pj4+Pj4+Pj4gICAg
ICAgDQo+Pj4+Pj4+Pj4+ICsgICAgcmMgPSB2cGNpX2Fzc2lnbl9kZXZpY2UoZCwgcGRldik7DQo+
Pj4+Pj4+Pj4+ICsNCj4+Pj4+Pj4+Pj4gICAgICAgIGRvbmU6DQo+Pj4+Pj4+Pj4+ICAgICAgICAg
ICBpZiAoIHJjICkNCj4+Pj4+Pj4+Pj4gICAgICAgICAgICAgICBwcmludGsoWEVOTE9HX0dfV0FS
TklORyAiJXBkOiBhc3NpZ24gKCVwcCkgZmFpbGVkICglZClcbiIsDQo+Pj4+Pj4+Pj4gVGhlcmUn
cyBubyBhdHRlbXB0IHRvIHVuZG8gYW55dGhpbmcgaW4gdGhlIGNhc2Ugb2YgZ2V0dGluZyBiYWNr
IGFuDQo+Pj4+Pj4+Pj4gZXJyb3IuIElTVFIgdGhpcyBiZWluZyBkZWVtZWQgb2theSBvbiB0aGUg
YmFzaXMgdGhhdCB0aGUgdG9vbCBzdGFjaw0KPj4+Pj4+Pj4+IHdvdWxkIHRoZW4gdGFrZSB3aGF0
ZXZlciBhY3Rpb24sIGJ1dCB3aGF0ZXZlciBpdCBpcyB0aGF0IGlzIHN1cHBvc2VkDQo+Pj4+Pj4+
Pj4gdG8gZGVhbCB3aXRoIGVycm9ycyBoZXJlIHdhbnRzIHNwZWxsaW5nIG91dCBpbiB0aGUgZGVz
Y3JpcHRpb24uDQo+Pj4+Pj4+PiBXaHk/IEkgZG9uJ3QgY2hhbmdlIHRoZSBwcmV2aW91c2x5IGV4
cGVjdGVkIGRlY2lzaW9uIGFuZCBpbXBsZW1lbnRhdGlvbg0KPj4+Pj4+Pj4gb2YgdGhlIGFzc2ln
bl9kZXZpY2UgZnVuY3Rpb246IEkgdXNlIGVycm9yIHBhdGhzIGFzIHRoZXkgd2VyZSB1c2VkIGJl
Zm9yZQ0KPj4+Pj4+Pj4gZm9yIHRoZSBleGlzdGluZyBjb2RlLiBTbywgSSBzZWUgbm8gY2xlYXIg
cmVhc29uIHRvIHN0cmVzcyB0aGF0IHRoZSBleGlzdGluZw0KPj4+Pj4+Pj4gYW5kIG5ldyBjb2Rl
IHJlbGllcyBvbiB0aGUgdG9vbHN0YWNrDQo+Pj4+Pj4+IFNheWluZyBoYWxmIGEgc2VudGVuY2Ug
b24gdGhpcyBpcyBoZWxwaW5nIHJldmlldy4NCj4+Pj4+PiBPaw0KPj4+Pj4+Pj4+IFdoYXQncyBp
bXBvcnRhbnQgaXMgdGhhdCBubyBjYWxsZXIgdXAgdGhlIGNhbGwgdHJlZSBtYXkgYmUgbGVmdCB3
aXRoDQo+Pj4+Pj4+Pj4gdGhlIGltcHJlc3Npb24gdGhhdCB0aGUgZGV2aWNlIGlzIHN0aWxsIG93
bmVkIGJ5IHRoZSBvcmlnaW5hbA0KPj4+Pj4+Pj4+IGRvbWFpbi4gV2l0aCBob3cgeW91IGhhdmUg
aXQsIHRoZSBkZXZpY2UgaXMgZ29pbmcgdG8gYmUgb3duZWQgYnkgdGhlDQo+Pj4+Pj4+Pj4gbmV3
IGRvbWFpbiwgYnV0IG5vdCByZWFsbHkgdXNhYmxlLg0KPj4+Pj4+Pj4gVGhpcyBpcyBub3QgdHJ1
ZTogdnBjaV9hc3NpZ25fZGV2aWNlIHdpbGwgY2FsbCB2cGNpX2RlYXNzaWduX2RldmljZQ0KPj4+
Pj4+Pj4gaW50ZXJuYWxseSBpZiBpdCBmYWlscy4gU28sIHRoZSBkZXZpY2Ugd29uJ3QgYmUgYXNz
aWduZWQgaW4gdGhpcyBjYXNlDQo+Pj4+Pj4+IE5vLiBUaGUgZGV2aWNlIGlzIGFzc2lnbmVkIHRv
IHdoYXRldmVyIHBkZXYtPmRvbWFpbiBob2xkcy4gQ2FsbGluZw0KPj4+Pj4+PiB2cGNpX2RlYXNz
aWduX2RldmljZSgpIHRoZXJlIG1lcmVseSBtYWtlcyBzdXJlIHRoYXQgdGhlIGRldmljZSB3aWxs
DQo+Pj4+Pj4+IGhhdmUgX25vXyB2UENJIGRhdGEgYW5kIGhvb2tzIGluIHBsYWNlLCByYXRoZXIg
dGhhbiBzb21ldGhpbmcNCj4+Pj4+Pj4gcGFydGlhbC4NCj4+Pj4+PiBTbywgdGhpcyBwYXRjaCBp
cyBvbmx5IGRlYWxpbmcgd2l0aCB2cGNpIGFzc2lnbi9kZS1hc3NpZ24NCj4+Pj4+PiBBbmQgaXQg
cm9sbHMgYmFjayB3aGF0IGl0IGRpZCBpbiBjYXNlIG9mIGEgZmFpbHVyZQ0KPj4+Pj4+IEl0IGFs
c28gcmV0dXJucyByYyBpbiBhc3NpZ25fZGV2aWNlIHRvIHNpZ25hbCBpdCBoYXMgZmFpbGVkDQo+
Pj4+Pj4gV2hhdCBlbHNlIGlzIGV4cGVjdGVkIGZyb20gdGhpcyBwYXRjaD8/DQo+Pj4+PiBVbnRp
bCBub3cgaWYgYXNzaWduX2RldmljZSgpIHJldHVybnMgYW4gZXJyb3IsIHRoaXMgdGVsbHMgdGhl
IGNhbGxlcg0KPj4+Pj4gdGhhdCB0aGUgZGV2aWNlIGRpZCBub3QgY2hhbmdlIG93bmVyc2hpcDsN
Cj4+Pj4gTm90IHN1cmUgdGhpcyBpcyB0aGUgY2FzZToNCj4+Pj4gICAgwqDCoMKgIGlmICggKHJj
ID0gaW9tbXVfY2FsbChoZC0+cGxhdGZvcm1fb3BzLCBhc3NpZ25fZGV2aWNlLCBkLCBkZXZmbiwN
Cj4+Pj4gICAgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqAgcGNpX3RvX2RldihwZGV2KSwgZmxhZykpICkNCj4+Pj4gaW9tbXVfY2FsbCBjYW4gbGVhdmUg
dGhlIG5ldyBvd25lcnNoaXAgZXZlbiBub3cgd2l0aG91dA0KPj4+PiB2cGNpX2Fzc2lnbl9kZXZp
Y2UuDQo+Pj4gRGlkIHlvdSBjaGVjayB0aGUgYWN0dWFsIGhvb2sgZnVuY3Rpb25zIGZvciB3aGVu
IGV4YWN0bHkgdGhlIG93bmVyc2hpcA0KPj4+IGNoYW5nZSBoYXBwZW5zLiBGb3IgYm90aCBWVC1k
IGFuZCBBTUQgaXQgaXMgdGhlIGxhc3QgdGhpbmcgdGhleSBkbywNCj4+PiB3aGVuIG5vIGVycm9y
IGNhbiBvY2N1ciBhbnltb3JlLg0KPj4gVGhpcyBmdW5jdGlvbmFsaXR5IGRvZXMgbm90IGV4aXN0
IGZvciBBcm0geWV0LCBzbyB0aGlzIGlzIHVwIHRvIHRoZQ0KPj4gZnV0dXJlIHNlcmllcyB0byBh
ZGQgdGhhdC4NCj4+DQo+PiBXUlQgdG8gdGhlIGV4aXN0aW5nIGNvZGU6DQo+Pg0KPj4gc3RhdGlj
IGludCBhbWRfaW9tbXVfYXNzaWduX2RldmljZShzdHJ1Y3QgZG9tYWluICpkLCB1OCBkZXZmbiwN
Cj4+ICAgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqAgc3RydWN0IHBjaV9kZXYgKnBkZXYsDQo+PiAgIMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
IHUzMiBmbGFnKQ0KPj4gew0KPj4gICDCoMKgwqAgaWYgKCAhcmMgKQ0KPj4gICDCoMKgwqDCoMKg
wqDCoCByYyA9IHJlYXNzaWduX2RldmljZShwZGV2LT5kb21haW4sIGQsIGRldmZuLCBwZGV2KTsg
PDw8PDwgdGhpcyB3aWxsIHNldCBwZGV2LT5kb21haW4NCj4+DQo+PiAgIMKgwqDCoCBpZiAoIHJj
ICYmICFpc19oYXJkd2FyZV9kb21haW4oZCkgKQ0KPj4gICDCoMKgwqAgew0KPj4gICDCoMKgwqDC
oMKgwqDCoCBpbnQgcmV0ID0gYW1kX2lvbW11X3Jlc2VydmVfZG9tYWluX3VuaXR5X3VubWFwKA0K
Pj4gICDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgZCwgaXZyc19t
YXBwaW5nc1tyZXFfaWRdLnVuaXR5X21hcCk7DQo+Pg0KPj4gICDCoMKgwqDCoMKgwqDCoCBpZiAo
IHJldCApDQo+PiAgIMKgwqDCoMKgwqDCoMKgIHsNCj4+ICAgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oCBwcmludGsoWEVOTE9HX0VSUiAiQU1ELVZpOiAiDQo+PiAgIMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoCAidW5pdHktdW5tYXAgZm9yICVwZC8lMDR4OiUwMng6JTAyeC4ldSBm
YWlsZWQgKCVkKVxuIiwNCj4+ICAgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
IGQsIHBkZXYtPnNlZywgcGRldi0+YnVzLA0KPj4gICDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqAgUENJX1NMT1QoZGV2Zm4pLCBQQ0lfRlVOQyhkZXZmbiksIHJldCk7DQo+PiAg
IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgZG9tYWluX2NyYXNoKGQpOw0KPj4gICDCoMKgwqDCoMKg
wqDCoCB9DQo+PiBTby4uLi4NCj4+DQo+PiBUaGlzIGlzIElNTyB3cm9uZyBpbiB0aGUgZmlyc3Qg
cGxhY2UgdG8gbGV0IElPTU1VIGNvZGUgYXNzaWduIHBkZXYtPmRvbWFpbi4NCj4+IFRoaXMgaXMg
c29tZXRoaW5nIHRoYXQgbmVlZHMgdG8gYmUgZG9uZSBieSB0aGUgUENJIGNvZGUgaXRzZWxmIGFu
ZA0KPj4gbm90IHJlbHlpbmcgb24gZWFjaCBJT01NVSBjYWxsYmFjayBpbXBsZW1lbnRhdGlvbg0K
Pj4+ICAgIE15IHVuZGVyc3RhbmRpbmcgaXMgdGhhdCB0aGUgcm9sbC1iYWNrIGlzDQo+Pj4+IGV4
cGVjdGVkIHRvIGJlIHBlcmZvcm1lZCBieSB0aGUgdG9vbHN0YWNrIGFuZCB2cGNpX2Fzc2lnbl9k
ZXZpY2UNCj4+Pj4gZG9lc24ndCBwcmV2ZW50IHRoYXQgYnkgcmV0dXJuaW5nIHJjLiBFdmVuIG1v
cmUsIGJlZm9yZSB3ZSBkaXNjdXNzZWQNCj4+Pj4gdGhhdCBpdCB3b3VsZCBiZSBnb29kIGZvciB2
cGNpX2Fzc2lnbl9kZXZpY2UgdG8gdHJ5IHJlY292ZXJpbmcgZnJvbQ0KPj4+PiBhIHBvc3NpYmxl
IGVycm9yIGVhcmx5IHdoaWNoIGlzIGRvbmUgYnkgY2FsbGluZyB2cGNpX2RlYXNzaWduX2Rldmlj
ZQ0KPj4+PiBpbnRlcm5hbGx5Lg0KPj4+IFllcywgYnV0IHRoYXQncyBvbmx5IHBhcnQgb2YgaXQu
IEl0IGF0IGxlYXN0IG5lZWRzIGNvbnNpZGVyaW5nIHdoYXQNCj4+PiBlZmZlY3RzIGhhdmUgcmVz
dWx0ZWQgZnJvbSBvcGVyYXRpb25zIHByaW9yIHRvIHZwY2lfYXNzaWduX2RldmljZSgpLg0KPj4g
VGFraW5nIGludG8gYWNjb3VudCB0aGUgY29kZSBzbmlwcGV0IGFib3ZlOiB3aGF0IGlzIHlvdXIg
ZXhwZWN0YXRpb24NCj4+IGZyb20gdGhpcyBwYXRjaCB3aXRoIHRoaXMgcmVzcGVjdD8NCj4gWW91
IGRpZCBub3RlIHRoZSBkb21haW5fY3Jhc2goKSBpbiB0aGVyZSwgZGlkbid0IHlvdT8NCldoaWNo
IGlzIEFNRCBzcGVjaWZpYyBpbXBsZW1lbnRhdGlvbiB3aGljaCBjYW4gYmUgZGlmZmVyZW50IGZv
cg0Kb3RoZXIgSU9NTVVzLiBZZXMsIEkgZGlkLg0KPiBUaGUgc25pcHBldCBhYm92ZQ0KPiBzdGls
bCBtYXRjaGVzIHRoZSAiZGV2aWNlIG5vdCBhc3NpZ25lZCB0byBhbiBhbGl2ZSBEb21VIiBjcml0
ZXJpYSAod2hpY2gNCj4gY2FuIGJlIHRyYW5zbGF0ZWQgdG8gIm5vIGV4cG9zdXJlIG9mIGEgZGV2
aWNlIHRvIGFuIHVudHJ1c3RlZCBlbnRpdHkgaW4NCj4gY2FzZSBvZiBlcnJvciIpLiBTdWNoIGRv
bWFpbl9jcmFzaCgpIHVzZXMgYXJlbid0IG5pY2UsIGFuZCBJJ2QgcHJlZmVyIHRvDQo+IHNlZSB0
aGVtIGdvIGF3YXksIGJ1dCBzYWlkIHByb3BlcnR5IG5lZWRzIHRvIGJlIHJldGFpbmVkIHdpdGgg
YW55DQo+IGFsdGVybmF0aXZlIHNvbHV0aW9ucy4NClRoaXMgc21lbGxzIGxpa2Ugd2UgZmlyc3Qg
bmVlZCB0byBmaXggdGhlIGV4aXN0aW5nIGNvZGUsIHNvDQpwZGV2LT5kb21haW4gaXMgbm90IGFz
c2lnbmVkIGJ5IHNwZWNpZmljIElPTU1VIGltcGxlbWVudGF0aW9ucywNCmJ1dCBpbnN0ZWFkIGNv
bnRyb2xsZWQgYnkgdGhlIGNvZGUgd2hpY2ggcmVsaWVzIG9uIHRoYXQsIGFzc2lnbl9kZXZpY2Uu
DQoNCkkgY2FuIGhhdmUgc29tZXRoaW5nIGxpa2U6DQoNCmRpZmYgLS1naXQgYS94ZW4vZHJpdmVy
cy9wYXNzdGhyb3VnaC9wY2kuYyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3BjaS5jDQppbmRl
eCA4ODgzNmFhYjZiYWYuLmNjNzc5MDcwOWE1MCAxMDA2NDQNCi0tLSBhL3hlbi9kcml2ZXJzL3Bh
c3N0aHJvdWdoL3BjaS5jDQorKysgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9wY2kuYw0KQEAg
LTE0NzUsNiArMTQ3NSw3IEBAIHN0YXRpYyBpbnQgZGV2aWNlX2Fzc2lnbmVkKHUxNiBzZWcsIHU4
IGJ1cywgdTggZGV2Zm4pDQogwqBzdGF0aWMgaW50IGFzc2lnbl9kZXZpY2Uoc3RydWN0IGRvbWFp
biAqZCwgdTE2IHNlZywgdTggYnVzLCB1OCBkZXZmbiwgdTMyIGZsYWcpDQogwqB7DQogwqDCoMKg
wqAgY29uc3Qgc3RydWN0IGRvbWFpbl9pb21tdSAqaGQgPSBkb21faW9tbXUoZCk7DQorwqDCoMKg
IHN0cnVjdCBkb21haW4gKm9sZF9vd25lcjsNCiDCoMKgwqDCoCBzdHJ1Y3QgcGNpX2RldiAqcGRl
djsNCiDCoMKgwqDCoCBpbnQgcmMgPSAwOw0KDQpAQCAtMTQ5MCw2ICsxNDkxLDkgQEAgc3RhdGlj
IGludCBhc3NpZ25fZGV2aWNlKHN0cnVjdCBkb21haW4gKmQsIHUxNiBzZWcsIHU4IGJ1cywgdTgg
ZGV2Zm4sIHUzMiBmbGFnKQ0KIMKgwqDCoMKgIEFTU0VSVChwZGV2ICYmIChwZGV2LT5kb21haW4g
PT0gaGFyZHdhcmVfZG9tYWluIHx8DQogwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoCBwZGV2LT5kb21haW4gPT0gZG9tX2lvKSk7DQoNCivCoMKgwqAgLyogV2UgbmVlZCB0
byByZXN0b3JlIHRoZSBvbGQgb3duZXIgaW4gY2FzZSBvZiBhbiBlcnJvci4gKi8NCivCoMKgwqAg
b2xkX293bmVyID0gcGRldi0+ZG9tYWluOw0KKw0KIMKgwqDCoMKgIHZwY2lfZGVhc3NpZ25fZGV2
aWNlKHBkZXYtPmRvbWFpbiwgcGRldik7DQoNCiDCoMKgwqDCoCByYyA9IHBkZXZfbXNpeF9hc3Np
Z24oZCwgcGRldik7DQpAQCAtMTUxNSw4ICsxNTE5LDEyIEBAIHN0YXRpYyBpbnQgYXNzaWduX2Rl
dmljZShzdHJ1Y3QgZG9tYWluICpkLCB1MTYgc2VnLCB1OCBidXMsIHU4IGRldmZuLCB1MzIgZmxh
ZykNCg0KIMKgIGRvbmU6DQogwqDCoMKgwqAgaWYgKCByYyApDQorwqDCoMKgIHsNCiDCoMKgwqDC
oMKgwqDCoMKgIHByaW50ayhYRU5MT0dfR19XQVJOSU5HICIlcGQ6IGFzc2lnbiAoJXBwKSBmYWls
ZWQgKCVkKVxuIiwNCiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgZCwgJlBDSV9TQkRG
MyhzZWcsIGJ1cywgZGV2Zm4pLCByYyk7DQorwqDCoMKgwqDCoMKgwqAgLyogV2UgZmFpbGVkIHRv
IGFzc2lnbiwgc28gcmVzdG9yZSB0aGUgcHJldmlvdXMgb3duZXIuICovDQorwqDCoMKgwqDCoMKg
wqAgcGRldi0+ZG9tYWluID0gb2xkX293bmVyOw0KK8KgwqDCoCB9DQogwqDCoMKgwqAgLyogVGhl
IGRldmljZSBpcyBhc3NpZ25lZCB0byBkb21faW8gc28gbWFyayBpdCBhcyBxdWFyYW50aW5lZCAq
Lw0KIMKgwqDCoMKgIGVsc2UgaWYgKCBkID09IGRvbV9pbyApDQogwqDCoMKgwqDCoMKgwqDCoCBw
ZGV2LT5xdWFyYW50aW5lID0gdHJ1ZTsNCg0KQnV0IEkgZG8gbm90IHRoaW5rIHRoaXMgYmVsb25n
cyB0byB0aGlzIHBhdGNoDQo+DQo+IEphbg0KPg0KVGhhbmsgeW91LA0KT2xla3NhbmRy


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 11:00:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 11:00:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268168.461951 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHOEH-0008Cr-0O; Tue, 08 Feb 2022 11:00:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268168.461951; Tue, 08 Feb 2022 11:00:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHOEG-0008Ck-Tc; Tue, 08 Feb 2022 11:00:12 +0000
Received: by outflank-mailman (input) for mailman id 268168;
 Tue, 08 Feb 2022 11:00:12 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=v7zX=SX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nHOEF-0008Ce-Ut
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 11:00:11 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 487c2bc5-88ce-11ec-8eb8-a37418f5ba1a;
 Tue, 08 Feb 2022 12:00:10 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2168.outbound.protection.outlook.com [104.47.17.168]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-11-lxl6MrSWNjGaZ4GbGlfq7w-1; Tue, 08 Feb 2022 12:00:08 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DB7PR04MB4089.eurprd04.prod.outlook.com (2603:10a6:5:1b::29) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Tue, 8 Feb
 2022 11:00:06 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.018; Tue, 8 Feb 2022
 11:00:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 487c2bc5-88ce-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644318010;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=cKaYqyWeGEl4hRwBmsyRI1igQfea0K+13RcnakpviB0=;
	b=X0EQtyPMJ9f4nF8r9qzhTNJqa+TWxYm9VzOmhdtVf/m6GCVh0/vByGej8yz0TwrHM5zU7F
	/TSreGbrp9Oda0omCxm/9J8khejKwDYuzYsXqt/0Ig053oWOguU9e5v5EvpAn0MwxiEPq5
	m91ws8Zbr++3nFbFAIzfxevTtd3lhM0=
X-MC-Unique: lxl6MrSWNjGaZ4GbGlfq7w-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=YkMKdBp1P9xPZ3eGVudrlIMWMtHWIp5qdiKxQcAEgysA39YOgSLE9MjHJZwAdO0PgiZX72ROzmKc7HSv5zIcpaw4M9mQlYQGsPTzUtcQ/IX5hUM3hmZnj/b+5sBgGALexVYuejbanbXRCmr3DxfNjXQRDb4clrYUgX5vNMvw/6VCSLLeXgKiqh25Md0cKa9eo+2zgM0+kwXlNv4S38Sz5WeGftLoUhNxVTySoKZgDCXZ2+PcAMQ/EmS9tm4kg+V/7Ra/7MpPCIdC/C1u4FtGn56L7182DcdiRK05PfKI/e/etKD2lj9wPiM1uZl9E8nrP6gZmxT4agLGyiAzlFLLUQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=CCal8ZReqiUW5PQSJNxA//qqzbD5gjyCZua/UOGerqk=;
 b=QFHWDk2GnEnNdlq6ybM6TcCpifVULWXacCZrSz65nQYSPu4f+K0XfST28nCKTnJ+CoDBbUMMW8DcaERmgrokbM7mq48nKCjRTtbrWny4HuvLH9Kc+KpSGpqQeQD3Cqzjg6YP0J7lgugP1m2qzm4BwrphGBfOERFCENsJAxB+dyHySXeEKjhA45BnxuSRh8mo8q0cDR/pifVQTbQJ5lq94Az9zGPWAUJIWWlt8vSGNaph2+gbll9yt4aIhJrV1A/AIa8pI7XPWgBNI/csk1E33JE3G/0v4z7TQILGxHCrsTFBaFSCXNEaw46Afyck+pb7mrRpJci7Mcyd5m3q/U1Ixw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <cf584e13-f257-9355-50fa-c35e8fc8cf5e@suse.com>
Date: Tue, 8 Feb 2022 12:00:03 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v6 05/13] vpci: add hooks for PCI device assign/de-assign
Content-Language: en-US
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: "julien@xen.org" <julien@xen.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Artem Mygaiev <Artem_Mygaiev@epam.com>,
 "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
 "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
 "paul@xen.org" <paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "roger.pau@citrix.com" <roger.pau@citrix.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-6-andr2000@gmail.com>
 <16cea1df-3d0f-d404-2b88-aab47ad5548b@suse.com>
 <3fe6dbe3-51c6-f87f-23f9-cf2e1a924326@epam.com>
 <582ee8f9-7b01-4adc-6a8a-ce8b1dffd534@suse.com>
 <e225553b-b29c-0448-fb9f-f8b513d9f77d@epam.com>
 <0fd8a0ac-dc91-287e-536e-1684892837ab@suse.com>
 <9f58a8ff-44b4-3249-5858-9988644b2d4e@epam.com>
 <15c16171-f196-38d2-370c-38627935a21b@suse.com>
 <20762939-6b7e-ff60-7c1a-d47c4767ff4f@epam.com>
 <10cd89b5-a804-3354-26d8-bc271bd9c5e6@suse.com>
 <15022045-bc92-e3df-b005-aeec5e36a078@epam.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <15022045-bc92-e3df-b005-aeec5e36a078@epam.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM7PR04CA0005.eurprd04.prod.outlook.com
 (2603:10a6:20b:110::15) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d661f3db-58f3-4240-65d0-08d9eaf22a26
X-MS-TrafficTypeDiagnostic: DB7PR04MB4089:EE_
X-Microsoft-Antispam-PRVS:
	<DB7PR04MB4089244872DB254F476159E4B32D9@DB7PR04MB4089.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	blVI3Mg3ez1doM/HhEvidO1nsWn6kq1MMw13IWM77k0bqlIfOVSpwHg8MkHfmXO0H2dBWuOY+SQ809JCqRLcf05gG/uwNzeKCL3I91/wOW61ukQw4BsmsxbccgnT3oUDf9d26irsvm+QgR3zgRhjCq3s6QKjllIs7iEbK6+UZ3DM01ahf2a7JHfBpm76ZmWzaGE7/KiQgmtSGNyhAM55a+meCfiIlV8qBI04Wi/w73iB9z/KxZ7XXsKXT0cHCsiuNG3306wafMSYeVFYX/Do5aQmE8TwaNJXumbnaXwjKc1DCpdw3om2a3a1J2x4q5gpcPvBfWeHf2IbUwYOBR/SCZ3YkJsijfDk23ggzK+cHoBzYwDF3y/cmYpVNt86td8go3nj6CezClN+Sig4JpbmWxhm0dxQO3aiyIJFVafkFhQg7yBX4qNrSNwfCfSv7Nv/rbvxrkwjCtu2d1QV8qgK8moPoUvvlLONRE9yQNqblVb1yzshpaC9nh/uv99a+PEuWK1n/ApDNFnhnCuF+KysGaiv7NyToKc5k070OvQfVjweH3Weoq4aGZDVKFu8NVmI9h8vjfouElH0JUWM45tA8R/sozyMFHgwuw7axWEuSHMvbZ/zbML9BwwIncUBBIINmiQYc1+0DABydBTkrdSkTIFvo3LSv7+2bpgT8HDHTRJMFH1iL3qkJa1t/iAOv06maYYZ+DP8AbUG6O7ku+a+LZ9V0hevOErK/bDrK6emuaA=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(53546011)(8676002)(4326008)(66556008)(66946007)(66476007)(6506007)(2906002)(508600001)(8936002)(6512007)(31696002)(316002)(6666004)(54906003)(6916009)(7416002)(31686004)(38100700002)(186003)(26005)(6486002)(83380400001)(36756003)(2616005)(86362001)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?JLvTrwrOyfD86Bm+H8rwBKRbXnQObcQVVzwVXRQZPXhUaC7v3aAZw2TzZ1ve?=
 =?us-ascii?Q?nQwsenZF82IMs4GxxGOjtoqvskRQcwK7YPblOQpIepfw4WXwalMobHcAw9Lw?=
 =?us-ascii?Q?4BcT5euL2Ypzc6Gb+IvpFELvc5Lqlb0l7E8UUotiH47NNvv2wUPHDq6N6nJl?=
 =?us-ascii?Q?XRw3j4hPdakxY08QLkdrxTN+s0EkAg9Ywn01bJNYFqr1KkR23Xwb31lXolGu?=
 =?us-ascii?Q?Cvf8C3TCGVeMaA7L/OV7u3i7EMb0i/mmCApRjVc0kW7VnhF+N0iXMYHNNu/k?=
 =?us-ascii?Q?J9AeBEeJOjz9fcaegHYQiZ2gm2LRjReqSt/IBDhCgfJ1o3p9oewNkgBspF/5?=
 =?us-ascii?Q?6I03yJ9XvABoUujvNO7Hu0E9XOjnq9MyIv2AWflJMDBJtXgu5SxjwaR/HhDs?=
 =?us-ascii?Q?bnAdOTZF8fly+5N+a8+MvO5/5Mxxhku5G3RwNJmNhPbwyqLsOuzofcAMvvf4?=
 =?us-ascii?Q?vrYaTH/3jmHQV72YSqa9OTJ6+s6tzpWdLnjYaUP3IQRCRZueHP61zJKCkOwo?=
 =?us-ascii?Q?ZIyzQL5PTpGt2LbFkhoiomApnMBypDhZ1nfESqeCZV0CPiLTWf3+o3ynbOnQ?=
 =?us-ascii?Q?KmrNdNZYy+ETYlipaArDzciPoiqzwK0x9kK6tvBtKYayXoZWExjM50TkywTX?=
 =?us-ascii?Q?lR5W28uxWHJ/f4x6HwI87RN/FNEb1fyS7YBrp9gJe2VO33GLiC2afhMuDiWF?=
 =?us-ascii?Q?fHzzP5XzPP86ilnFkGhMf8P4cQsIACz+TI44QqAJ2rXaOdwIfdotEe83WBfU?=
 =?us-ascii?Q?AiMN+I4sZ+C5Vpy0FcHn+lXEhWKUPO9hqauFuGZYNGxF9O93ID8js5GKis7z?=
 =?us-ascii?Q?OPXHAbbCL/ND8BaDfSh1Us4u2WeHM+eY6KPmcgLBsjbNRfcwyapZYUPS2XHG?=
 =?us-ascii?Q?Qb8mnn141tSCZGtgRuAHA0nGr67MlZ1Vmam7/N3tBTgzO9mLooANIwJQ2VRq?=
 =?us-ascii?Q?AfhD09giIyEJO+TOn0pkUnvCAgigAtw8eyFIXQIdOW06MX0ErmaZrePFf4s4?=
 =?us-ascii?Q?CzNnoMcRK8bi6poc91rMdafSoQ6vwqPnvd07IzzO38YRHfVwsz+DlB+5BoRA?=
 =?us-ascii?Q?/Fls31WTdW7Two7CMTVr+PtpKGWmPgkSrbZWmOyw2RcNCRV3n/BdJ7+a3ORy?=
 =?us-ascii?Q?0CPosXZHD4uh/tJNT2PoGvYgj67MSYhadsEV/K6KGa9D85mtMykq0/PYIcnh?=
 =?us-ascii?Q?5I2SgtQt9WUCo3UbInn4v4uDsJvRzrqbEyfO9sXEKLUODm7gSwOhi0wcFc6E?=
 =?us-ascii?Q?DrazavoyoKTKcnYw9NbNtypIn6MafIFeLDYwR9NuawGiuAOcu6/HIFX1wKEL?=
 =?us-ascii?Q?pK/z0DCi0KhjZE8pHoNWnbc50jqT2bim5K3FbTHt01CVJ07aU/Si7A9YAB1F?=
 =?us-ascii?Q?wakWXe76v+9+Z8yv7VGZEuZdIR5Wk1GGyGdPcrVcIvroOhMcvfJU5oowzAdd?=
 =?us-ascii?Q?75Ix7HBLj149VyVA3pZF34uzMIBNMqGuOgyWlkAiI1GrZhNYnQG5P6Ooo980?=
 =?us-ascii?Q?fIFcwEMYXM+TzANT+44mn6AJupgJNn9uXHl74/EuYbsDHpNlzELL9ot7qNLP?=
 =?us-ascii?Q?ms1756M48Aj5wtKUQZRZ6vDj3ok95WehpsRUFXoeT58k+jxuhuW28trYTW5Q?=
 =?us-ascii?Q?fji+r1vCqabLaMi597iNB4c=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d661f3db-58f3-4240-65d0-08d9eaf22a26
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2022 11:00:06.1342
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MxiSB5wIkRt6udngr0PgeFeEql+mLA3MKgkjRPDBNxM1XrSDDBc063wwqQ2GDcYI5eOvysXzZsahUwBtxZbpTg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4089

On 08.02.2022 11:52, Oleksandr Andrushchenko wrote:
> This smells like we first need to fix the existing code, so
> pdev->domain is not assigned by specific IOMMU implementations,
> but instead controlled by the code which relies on that, assign_device.

Feel free to come up with proposals how to cleanly do so. Moving the
assignment to pdev->domain may even be possible now, but if you go
back you may find that the code was quite different earlier on.

> I can have something like:
>=20
> diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.=
c
> index 88836aab6baf..cc7790709a50 100644
> --- a/xen/drivers/passthrough/pci.c
> +++ b/xen/drivers/passthrough/pci.c
> @@ -1475,6 +1475,7 @@ static int device_assigned(u16 seg, u8 bus, u8 devf=
n)
>  =C2=A0static int assign_device(struct domain *d, u16 seg, u8 bus, u8 dev=
fn, u32 flag)
>  =C2=A0{
>  =C2=A0=C2=A0=C2=A0=C2=A0 const struct domain_iommu *hd =3D dom_iommu(d);
> +=C2=A0=C2=A0=C2=A0 struct domain *old_owner;
>  =C2=A0=C2=A0=C2=A0=C2=A0 struct pci_dev *pdev;
>  =C2=A0=C2=A0=C2=A0=C2=A0 int rc =3D 0;
>=20
> @@ -1490,6 +1491,9 @@ static int assign_device(struct domain *d, u16 seg,=
 u8 bus, u8 devfn, u32 flag)
>  =C2=A0=C2=A0=C2=A0=C2=A0 ASSERT(pdev && (pdev->domain =3D=3D hardware_do=
main ||
>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 pdev->domain =3D=3D dom_io=
));
>=20
> +=C2=A0=C2=A0=C2=A0 /* We need to restore the old owner in case of an err=
or. */
> +=C2=A0=C2=A0=C2=A0 old_owner =3D pdev->domain;
> +
>  =C2=A0=C2=A0=C2=A0=C2=A0 vpci_deassign_device(pdev->domain, pdev);
>=20
>  =C2=A0=C2=A0=C2=A0=C2=A0 rc =3D pdev_msix_assign(d, pdev);
> @@ -1515,8 +1519,12 @@ static int assign_device(struct domain *d, u16 seg=
, u8 bus, u8 devfn, u32 flag)
>=20
>  =C2=A0 done:
>  =C2=A0=C2=A0=C2=A0=C2=A0 if ( rc )
> +=C2=A0=C2=A0=C2=A0 {
>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 printk(XENLOG_G_WARNING=
 "%pd: assign (%pp) failed (%d)\n",
>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0 d, &PCI_SBDF3(seg, bus, devfn), rc);
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 /* We failed to assign, so re=
store the previous owner. */
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 pdev->domain =3D old_owner;
> +=C2=A0=C2=A0=C2=A0 }
>  =C2=A0=C2=A0=C2=A0=C2=A0 /* The device is assigned to dom_io so mark it =
as quarantined */
>  =C2=A0=C2=A0=C2=A0=C2=A0 else if ( d =3D=3D dom_io )
>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 pdev->quarantine =3D tr=
ue;
>=20
> But I do not think this belongs to this patch

Indeed. Plus I'm sure you understand that it's not that simple. Assigning
to pdev->domain is only the last step of assignment. Restoring the original
owner would entail putting in place the original IOMMU table entries as
well, which in turn can fail. Hence why you'll find a number of uses of
domain_crash() in places where rolling back is far from easy.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Feb 08 11:09:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 11:09:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268177.461962 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHON8-0000Ub-Ui; Tue, 08 Feb 2022 11:09:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268177.461962; Tue, 08 Feb 2022 11:09:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHON8-0000UU-RE; Tue, 08 Feb 2022 11:09:22 +0000
Received: by outflank-mailman (input) for mailman id 268177;
 Tue, 08 Feb 2022 11:09:21 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=co3W=SX=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nHON7-0000UO-Ga
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 11:09:21 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 903647ae-88cf-11ec-8f75-fffcc8bd4f1a;
 Tue, 08 Feb 2022 12:09:20 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id CB94F1F387;
 Tue,  8 Feb 2022 11:09:19 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id AD8B613C7E;
 Tue,  8 Feb 2022 11:09:19 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id cK7lKF9PAmJOEgAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 08 Feb 2022 11:09:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 903647ae-88cf-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1644318559; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=HvLweouFIP/Pz8Hb8MwKHzITiDFI+6uL/3ZbiGtSWUk=;
	b=U9YPbLXwrQLDTyTpRQEpyNQeR7w0/wPbg9X7HzyevtuytCwkMlfv6PpVixqzkOwVUNVj7W
	ZAEHjz+xG7tzK0lb7ngWJlnweXOtX6rhaTbxwjH8FVrAs8+7mXGHHAw7SGNtrv/+JLAbG2
	23MbgjAzUNmM9h/F6Yx2bcv7Rbwh2x8=
Message-ID: <4be1dd2c-31b9-1303-ca70-24c58983358c@suse.com>
Date: Tue, 8 Feb 2022 12:09:19 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Subject: Re: [XEN PATCH] tools/libs: Fix build dependencies
Content-Language: en-US
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Wei Liu <wl@xen.org>
References: <20220208103959.21102-1-anthony.perard@citrix.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <20220208103959.21102-1-anthony.perard@citrix.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------R7HWk7vH7hMbzEPZ8PwD2Tfn"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------R7HWk7vH7hMbzEPZ8PwD2Tfn
Content-Type: multipart/mixed; boundary="------------vr84t5KES0ShkGLkSfIjHhZw";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Wei Liu <wl@xen.org>
Message-ID: <4be1dd2c-31b9-1303-ca70-24c58983358c@suse.com>
Subject: Re: [XEN PATCH] tools/libs: Fix build dependencies
References: <20220208103959.21102-1-anthony.perard@citrix.com>
In-Reply-To: <20220208103959.21102-1-anthony.perard@citrix.com>

--------------vr84t5KES0ShkGLkSfIjHhZw
Content-Type: multipart/mixed; boundary="------------vFHgvkDmWqRosCNVgxRyUbin"

--------------vFHgvkDmWqRosCNVgxRyUbin
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMDguMDIuMjIgMTE6MzksIEFudGhvbnkgUEVSQVJEIHdyb3RlOg0KPiBTb21lIGxpYnMn
IE1ha2VmaWxlIGFyZW4ndCBsb2FkaW5nIHRoZSBkZXBlbmRlbmNpZXMgZmlsZXMgKi5kMi4N
Cj4gDQo+IFdlIGNhbiBsb2FkIHRoZW0gZnJvbSAibGlicy5tayIgYXMgbm9uZSBvZiB0aGUg
TWFrZWZpbGUgaGVyZSBhcmUNCj4gY2hhbmdpbmcgJChERVBTKSBvciAkKERFUFNfSU5DTFVE
RSkgc28gaXQgaXMgZmluZSB0byBtb3ZlIHRoZQ0KPiAiaW5jbHVkZSIgdG8gImxpYnMubWsi
Lg0KPiANCj4gQXMgYSBsaXR0bGUgaW1wcm92ZW1lbnQsIGRvbid0IGxvYWQgdGhlIGRlcGVu
ZGVuY2llcyBmaWxlcyAoYW5kIHRodXMNCj4gYXZvaWQgcmVnZW5lcmF0aW5nIHRoZSAqLmQy
IGZpbGVzKSBkdXJpbmcgYG1ha2UgY2xlYW5gLg0KPiANCj4gU2lnbmVkLW9mZi1ieTogQW50
aG9ueSBQRVJBUkQgPGFudGhvbnkucGVyYXJkQGNpdHJpeC5jb20+DQoNClJldmlld2VkLWJ5
OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+DQoNCg0KSnVlcmdlbg0K
--------------vFHgvkDmWqRosCNVgxRyUbin
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------vFHgvkDmWqRosCNVgxRyUbin--

--------------vr84t5KES0ShkGLkSfIjHhZw--

--------------R7HWk7vH7hMbzEPZ8PwD2Tfn
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmICT18FAwAAAAAACgkQsN6d1ii/Ey+c
iwf/Yk27JmHEsqj1aq7/W25KfHC6vZdjlM/S89UYVS4j2uZhIaGUz83K2vIgUheoU0LlzycuWmgY
Qg/GZDa9m4iqMfWwse3TOC5J86GTdMLDkkWuOavws+q5UpJ/Qbo6dC84VmiJD6+XDvAP41T/LBzg
yE9jj6tw+Cc+naXd2F1IG4p4gR9npZtKImpnp30lBbanBcllVTacQbhHFhT8yzfGTmtozywAlzHd
x95YRa82xjqFMJw1kZf5EzgTmuuvkfbcXhClKbRYHwGt4Nj3xgW2BrCXeXX7r1ubqqT6wssW21UV
k9PvgIkVKWBkVq6hFk8G0P7feJxwe8qFJBW70jiZ4A==
=uFvf
-----END PGP SIGNATURE-----

--------------R7HWk7vH7hMbzEPZ8PwD2Tfn--


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 11:10:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 11:10:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268184.461973 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHOO3-0001mB-9v; Tue, 08 Feb 2022 11:10:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268184.461973; Tue, 08 Feb 2022 11:10:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHOO3-0001m4-4l; Tue, 08 Feb 2022 11:10:19 +0000
Received: by outflank-mailman (input) for mailman id 268184;
 Tue, 08 Feb 2022 11:10:18 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=v7zX=SX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nHOO2-0000sB-7B
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 11:10:18 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b23fbe26-88cf-11ec-8eb8-a37418f5ba1a;
 Tue, 08 Feb 2022 12:10:17 +0100 (CET)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2059.outbound.protection.outlook.com [104.47.13.59]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-5-XNIXGx2OO7eWKzfmhRytew-1; Tue, 08 Feb 2022 12:10:15 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB3103.eurprd04.prod.outlook.com (2603:10a6:802:a::13) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Tue, 8 Feb
 2022 11:10:12 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.018; Tue, 8 Feb 2022
 11:10:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b23fbe26-88cf-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644318617;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=hQAWbIZUu8I/Hw982BplPrZjsb5S7+IUbxdTD8OgJ9o=;
	b=D8lYFk+qNYdP/uJD75FF4AtZfCy+obGGv7xngrSVa1LY3MUK8we2hq2sHagbVcCeyKBE1Y
	BEY9FkzxgK69R2nS21WLW5RmgloHdbj84MfzlZotICA99pLjTtyso6dYBJWV/ox+YkQndK
	btRRxRKKNCeElyT7zJTc7lnEzqjxEUI=
X-MC-Unique: XNIXGx2OO7eWKzfmhRytew-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=k3ucAqfwruDyvhQt9vChILajH60PEkpxSvWbCiGj2X4EULUOKSJS/Gad6aGrIby/ywhCSd1XCfKBgW+ssPnCXGwl3wsqNNgZDciWVfVWMxrHudB2JjRnqhHQNZGx++Ob785lbwKE0ucKhUkBt0Q9P8m1Ix4YJPVtbU/Lc0tzFx37lTC8ADn09mOtjvFGoQp4nzBX7DxNWOSoz9/s8nEeGLfdDG+agXEgZlfLXcj1cfigY8ebM6V9qIWVqkxbJtODAuMBUL8lLJmrf/XvMowmtKale8S8Ea09eWjQ4IB4kD3By467NQ+nWssrv77TGgkvjuxJO6UVk0nDYrjqPS797Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=hQAWbIZUu8I/Hw982BplPrZjsb5S7+IUbxdTD8OgJ9o=;
 b=VTmGoz8tf/dxQUb2vOXnrQoM7QgDABGSq8t95Wju0JM9sLv79YE1EJzx6BulBvz80e9Ng0S1Zo2Pb7SQteAFz89cUQwJ1C0UOmWSKS0p3ovPeE2CQ6yOrv5ggastqAiUIsFQT/2P6U/6Pojibl7rSEVVMvt0b/UQLqsG4tdRPD/BJywEUue4yTgxGOcBDshFJW3r5xfkFUuLoZIwpTCxmSg3TrUWy4AsQbQcYAGdYjfvvdEQXwUPUuBV689mN1uD1ikQDXH0v+yWC01YZEELPAp5UpX47KiGZGyzGWlJuii76xeXK9LsZur+8T94Z7EdNvESxEZYeeR+eNePqEfnXw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <87559a9c-d459-e0df-cd89-6371f45870d2@suse.com>
Date: Tue, 8 Feb 2022 12:10:10 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH] xen/efi: Use PrintErrMsg() rather than printk() in
 efi_exit_boot()
Content-Language: en-US
To: Julien Grall <julien@xen.org>
Cc: Julien Grall <jgrall@amazon.com>, xen-devel@lists.xenproject.org
References: <20220208105211.96727-1-julien@xen.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220208105211.96727-1-julien@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9P194CA0003.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:20b:46d::12) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4f61e991-a7eb-4752-834c-08d9eaf393af
X-MS-TrafficTypeDiagnostic: VI1PR04MB3103:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB310395E6605A6BA95EEBD5F3B32D9@VI1PR04MB3103.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	svn7FIvHvwl9YCN5LSoDQmIhpY89vKfDGhukri8OQF+drjgLcW6ygloyKI5aRqJ1yoHtzoPxgfcbF9bsvl+3WjhvblbYrGzp0DRXGknYN3An/2hadEZvKmTBkdEgVcQw8z+BYprxXAcylZvvb7IPlfrCDDmR/s+NR+AMJmGxFMJZpcTaXh9RqVjWAompzIGFSEIkkI6U3XW+YNReH6iWA+jBZ00WcqhIvgH2q1hrEok9+STPWxYpXhNtvJ7IPkoR9e8gTr2oHLs42udMESmkuGmku1kbzUjXPjd44TdxEafhiSr6RWtLgBGjXwToULbt28zWnQDv4DrnmMQffsGwuCoBFBMOEa5ZP1929gOLccfAzCkrxz/GQw2hTpvXaYGjv5bTT9DeC2D2qUjY7WOM0w8v71uq+BDjv1lz9T1UqPJP/QyxakN2yxd2mfqqUfFGmQH/hwegxa9gwarlKxQQcFxVGeIeECn3m3LpfVpeD9iRpA837f8RmKgJhXyFRdpn6HsNOfq2idxf+1QqMaRG/arwsopT4MYK6KNrVYbisMi+0w0K9r3OQMlnGa40/tdGVxyZw9C5ediVm8JCKoi70eBREvIAziaGvXFhqcNNRpoP5Pcr0B0Z8jzf99rYdMCFv8a6XMg83laiGwrKYdwRBirHKUol8FAleo4XWsAPLxgiVFd81KIz4SWqRpeN06F6FPFcMZ6BaQlLcUEKPRP1LpfbCg931Ewv3srA8XuLtGE=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2616005)(31686004)(53546011)(6512007)(316002)(508600001)(66946007)(2906002)(6506007)(186003)(26005)(5660300002)(6486002)(86362001)(66476007)(8676002)(4326008)(31696002)(36756003)(8936002)(6916009)(38100700002)(66556008)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VW5LQVVvTHpRSmQ0N2RNVHdjYUlNZmduZ2VzYVJCaFRpZFMwNkJZYXQ1SlZi?=
 =?utf-8?B?RzhTQ1I4ZnNtN042VS9FazZvekdXMExnYVByWU9VK010WWx5RjZYM2hXbGg2?=
 =?utf-8?B?TnBQMEtKdVlkOHlQSlFIc3ErbUo3VTBXTElrajM2cTFkalFMTVNIa3pBRExy?=
 =?utf-8?B?TXdFY3R0Q0VCR3RpYmVSYmtLM1A1aC80NE9TNkZKcEZ0ajhVcXZFUXZwQ1ZY?=
 =?utf-8?B?T3ZTeTdueWVic2ZLOUtheVhzUENLVkJmc0dCcEt0OGRIRHZYK3U0R1FwR1o0?=
 =?utf-8?B?TUZwOS91U0FEQ3Qrb0QvVk5UZ3kzU2VHWTYvOVZVdlZUM0l3bUpRN00wa1hD?=
 =?utf-8?B?S3dFa0c3Vi96YXJiZmRFQ0FGbklwNHF0cElDcGJmbERQeDhSMFlKdFg0ckFN?=
 =?utf-8?B?ZFpEOC9nVDFYaDNiaVdaRFgyM3pvUllBZWh0MStncTNibHBnVU94N2tCd3Fm?=
 =?utf-8?B?cjFtRmp4ZFBqWDlaeVBGaFBsNEtoTWU2Vm1WS015SGlxZWNKdkIzTEZ5LzJj?=
 =?utf-8?B?bEtXR002cDZ5SkZ4VVhXTEg2eTFCcjVrblRhVFRzN1RJVllKRFduWWpYZHZm?=
 =?utf-8?B?MGJNUXp0aThIYmlUcHhyWXhzM2J6Z2RLNkpMdkNLR2xPRjBpOHM0RHYvMFF1?=
 =?utf-8?B?VXEzZGxxSUtSeUFwNkU4V0tRclIwU1JjTGtIcUtNMVVVd3B1NmVNMEFXMTN5?=
 =?utf-8?B?dnNtb0hEajlCNkk0REtsbE5LbENaUGZ5VVdSRmFJYWxZSGVyaVZLV3o1RDlR?=
 =?utf-8?B?UW1KYzNDUGdPdXhsMEFrZTZtc2I1RUl1eTBpSGNWbVNJSkVQRjljU05YVnZl?=
 =?utf-8?B?OUIzNUhVaDA5WEN3T2pNaVQ3MHBRbk9NN056Y2pDdlhtZWk0WmsyTTV4Slky?=
 =?utf-8?B?anhSR0NWTUtnNUp5TVVYR2lGdXJFR3paMHRacGdYcXFPNnp2c0xlR3l4Nmwx?=
 =?utf-8?B?U3MyODZUK0wzOVM5RUpRR3JBa1ZKTGJTaEVnbjJBbHFZc0EweXcxS28vMk02?=
 =?utf-8?B?elJDUjdBKzcveTJxZjVXS3VZNElIbHVMci9Tcis0Z3JFRlVRN0tTQmFmYXJm?=
 =?utf-8?B?bkRLbjBtcTdkclJ0VXlvK2hVTnA5S2lHb3ZmRG9TSlZDZHJkMll6NmNhb01n?=
 =?utf-8?B?T3ExWTRqWWlBTzMrSmwvKzBkNWRpRXYwSmtCZzVmMW40V052NVp5Mm9JZFRr?=
 =?utf-8?B?bnM1eisramdRR2xzenIwTXROUGlKYVRBTUpPa2Jpa2RnbWxNSTk4R0ZxWkkr?=
 =?utf-8?B?SVcySENXcnY1N01BQ3RsVGNHS1lBR0VTOUJzTVJGOFpQMXl1ZDRpRHkyQXhp?=
 =?utf-8?B?cHpuT1lxMi8yeWdvN1FVaG5WS0RLK0RGTnd1eFY2WTJEb0NkUStjdSs2eHBN?=
 =?utf-8?B?SWRoS0tQSDhBL0s5WkZOL2o5bWNXRXNSVWY1bXIzR0R6TFl0OXlCVEtSci9O?=
 =?utf-8?B?Z21uZ3lsNnRodHNJcUNweXhlSC9VNXRYaGtDMkFkajFTWElEYTVEMTlrT0Y5?=
 =?utf-8?B?Uk1ZeGVwK3JUaFpXN2M5aDdvcWJ1MmhIalN6TWNXZDFtRCtVN0ZVQVd4R25i?=
 =?utf-8?B?Z2s1SkZSSUJJaG96KzN0akY1emZxRm1ScWtGZEdlZ1VidnAwSVdBN2tXa21p?=
 =?utf-8?B?LzAyREJnRWY1K25oQkNFbjBlbHUrRzBKMlRXRkRxTlpNRFIyUlZQbEpxeU1P?=
 =?utf-8?B?ejE1RVFzWGZwc2Ztem4rVmNhUzJQSGVWdE0zczhMT0F5UG9kcXowb3dzYTkz?=
 =?utf-8?B?MVBGVkJLMkNLOHVqQWlLVzF1V09ISjJyL1p3NEZyNUJIY3VKNHVnWUw0RTJG?=
 =?utf-8?B?RVl2cnprSzVOK1dsV0lRanloQWdLeGxqSHBBbStXQkxUTzEvTUw3YkxKdDl6?=
 =?utf-8?B?UHQ5UXdVaEVQZy95ZWh4eGQrdGhmZnlRR2xuc0JmdWoxdlQ0OHQwTkNacWQr?=
 =?utf-8?B?NEhhSVdJMVgyYUQ1RXArbjJ2aU1remRIN1NabTA1QVdlOGMvWWlTdlRBWlVY?=
 =?utf-8?B?dlVNRGxJY0ZRaUxRRXU4UDJCOWx3RW1sUnlqVHh4T1VUdWZDQ0tQTStiMjdI?=
 =?utf-8?B?aGRyU1hrejYzOHFkQno5Z2Y2ZURLWXVmdjlsZVNyaGl4bHdJMVRvZW8rQllK?=
 =?utf-8?B?c1Znd2lyT0ZEaUp0andjUWU5QU1uNGxnVjZDR2Faem00c2J4VmREZWh5aHpq?=
 =?utf-8?Q?H6Ky6nbGtsRbLfY2UDW2QNw=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4f61e991-a7eb-4752-834c-08d9eaf393af
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2022 11:10:12.6278
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fQhuYoMNUXwDlD1ztBbgnfH2Z5GpvU+5RTe7SXYUx1sL6aUvGJeFSGs8wGoeVWHzXfjFUNvMnLOarGpw24nwUA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3103

On 08.02.2022 11:52, Julien Grall wrote:
> From: Julien Grall <jgrall@amazon.com>
> 
> The function efi_exit_boot() will be called within the UEFI stub. This
> means printk() is not available will actually result to a crash when
> called (at least on Arm).
> 
> Replace the call to printk() with PrintErrMsg().
> 
> Fixes: 49450415d6 ("efi: optionally call SetVirtualAddressMap()")
> Signed-off-by: Julien Grall <jgrall@amazon.com>

I think it was intentional to use printk() here, so I'd like to ask
for more details about the observed crash. That's also to try to
figure whether x86 would also be affected. The problem is that
without serial console configured in EFI, the output from
PrintErrMesg() is going to be very unlikely to actually be observable
(on the console), whereas the printk() output would at least be
retrievable by "xl dmesg" after the system is up.

What's worse though:

1) PrintErrMesg() invokes blexit() as the last thing. Yet we don't
   want to prevent Xen from booting; all we want is to disable use of
   runtime services.

2) I'm not convinced you can use StdErr anymore after ExitBootServices()
   was already called.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Feb 08 11:12:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 11:12:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268195.461984 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHOQD-0002VC-Pr; Tue, 08 Feb 2022 11:12:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268195.461984; Tue, 08 Feb 2022 11:12:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHOQD-0002V5-MV; Tue, 08 Feb 2022 11:12:33 +0000
Received: by outflank-mailman (input) for mailman id 268195;
 Tue, 08 Feb 2022 11:12:32 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=GmUj=SX=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nHOQB-0002Ut-Qk
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 11:12:32 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0096ba78-88d0-11ec-8f75-fffcc8bd4f1a;
 Tue, 08 Feb 2022 12:12:30 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0096ba78-88d0-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644318750;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=oe9eTTPd/LwDSOZA3u7TyfBxq5h5/0DZw/vz3uH0X5s=;
  b=eFQEcYD/AE4aktacY88tdVTA0dRA5418giZjrHLm7DWlQzKaqI12NtUP
   RYfD/P0p2JwreTgFUR+T+9TfQyt1MeR0oFa4ENkP1DzTrIO75zlvQaIld
   1epaMACnJkqzr1AwvhC1D7hclPYWcQrkw9dwWfvuI+DrlqE1RUWQhUAZn
   c=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: AFikgXmEOuxZkz7vtxm0Nac16LcuG5TvCMx83JEx42nB2u/S3eEx1arAhcNeYX3xPViH612oEm
 4gB9r9Al7q1zAurvfYBWtI5hpxjDroKm06NbY6wz5TjssCRkkvszDiqJdrwS97XQsbzEZ7nSzu
 eqlqSUW2+eH3lH79VvIPkapAHYvQMmPWgI3dSe2i73tuaBDzENFpFHfL7UR99/M+jCPTLsvlcy
 yp4Jiw/adYvu9akikF6+FwL8IPfZjA4s+NJW6HyVUcL7MrFE+GwpZ1mxMhqsRBDYoU45Sc0eME
 2HS0Cq3uAwGt9deCCpzndZqI
X-SBRS: 5.1
X-MesageID: 64127044
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:p0RnaqB7nF6OtRVW/wrlw5YqxClBgxIJ4kV8jS/XYbTApD8j3jMPn
 TFLUWmDafaCMWOnLYtxO4yypEoEvpaHnYBlQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMo/u1Si6FatANl1ElvU2zbue6WL6s1hxZH1c+En970UI7wobVv6Yz6TSHK1LV0
 T/Ni5W31G+Ng1aY5UpNtspvADs21BjDkGtwUm4WPJinj3eH/5UhN7oNJLnZEpfNatI88thW5
 Qr05OrREmvxp3/BAz4++1rxWhVirrX6ZWBihpfKMkQLb9crSiEai84G2PQghUh/l2SFkfRR8
 sx0up2PSTp1E7fHw/slXEwNe81+FfUuFL7vJHG+tYqYzlHccmuqyPJrZK00FdRGoKAtWzgIr
 KFGbmBWBvyAr7veLLaTUO5ji95lNMD2FIgepmth3XfSCvNOrZXrHfmTv4AAgGtYasZmIvWOR
 tcgY2pWd0rRZhcVamkzAYoXpbL97pX4W2IB8w/EzUYt2EDLxRF1+KjgNpzSYNPibexPgkudk
 UfX8G34Dw8yOcSWzHyO9XfEruXChz/hUYQeUrix7Od3gUa7z3YWThYRUDOTsfS/z0KzRd9bA
 0gV4TY167g/8lSxSdvwVAH+p2SL1jYGUtpNF6sh6QeCyoLd+QPfDW8BJhZ/b9ghuN4zVCYd/
 FaDlNP0BhRiqLSQD3ma89+8rzm/JCwUJm8qfjIfQE0O5NyLiKY3gxHUR9BvCpmciNHvBCrwy
 DCHqis5r7gLhMtN3KK+lXjFnjatq57hXgMzoALNUQqNyQd0Z5WsYYCy3mTK9vZLLIufTV6ps
 WANno6V6+VmJYqWiCWHTeEJHbeoz/WIKjvRhRhoBZZJyti20yf9J8YKumg4fRo3dJZfEdP0X
 KPNkR8A6JF3HEGzVKB2XIKMV+kwxvP/LduwA5g4ceFySpR2cQaG+gRnakiRw33hnSAQrE0vB
 XuIWZ3yVChHUMyL2BLzHr5AiuFzmkjS0EuOHciT8vix7VaJiJd5o58hOUDGUO025bjsTO79o
 4cGbJviJ/myvYTDjsjrHWw7cApiwZsTX8meRylrmgmreFsOJY3ZI6WNqY7NgqQ890ivqs/G/
 2umRmhTw0fliHvMJG2iMy4/NOq+BM8h/ChiZkTA2GpEPFB5MO6SAFo3LcNrLdHLCsQ/pRKLc
 xX1U5rZWakeItg20z8ccYP8vORfmOeD3mqz096eSGFnJfZIHlWRkve9J1eH3HReX0Kf6Jply
 5X9h1yzacRYHWxKUp2JAM9DOnvs5BDxbsopBBCWSjSSEW2xmLVXx9vZ1KdoeppRckWanVN3F
 W++WH8lmAUEmKdsmPHhjqGYtYa5Vex4G0tRBW7A6riqcyLd+wKeLUVoCbbgken1WDym9aO8S
 /9Syv2gYvQLkEwT69h3EqpxzLJ47Nzq/ucIwgNhFXTNTlKqFrI/fSXWgZgR7vVAlu1DpA+7e
 kOT4d0Ga7+HD9zoTQwKLw0/Y+XdifxNwmvO7e44KVnR7TNs+ObVSl1bOhSB0XQPLLZ8PI4/7
 /0mvcoat162hhYwa47UhSFI7WWcaHcHVvx/5J0dBYbqjCsty01DPsOAWnOnvsnXZowVYEcwI
 zKSiK7TvJhmxxLPIygpCHzA/etBnpBS6hpE+0APegaSkd3fi/5pgBAIqWYrTh5Yxwls2v5oP
 jQ5LFV8IKiD8ms6hMVHWGzwSQhNCAfApx70wloN0mbYU1OpRirGK2hkYbSB+0UQ8mR9eDlH/
 e7HlDa5AGiyJMyhjDEvXUNFquD4SY0j/wLPr8mrAsCZEsRoejHimKKvOTIFphaP7RndX6EbS
 T2GJNpNVJA=
IronPort-HdrOrdr: A9a23:Z8947KpcOai/dW4UWpEvVJsaV5vJL9V00zEX/kB9WHVpm5Oj+P
 xGzc526farslsssREb+OxpOMG7MBThHLpOkPMs1NaZLXLbUQ6TQr2KgrGSoQEIdxeOk9K1kJ
 0QDpSWa+eAc2SS7/yKmTVQeuxIqLLskNHKuQ6d9QYUcegDUdAe0+4TMHf8LqQZfngjOXJvf6
 Dsmvav6gDQMUg/X4CePD0oTuLDr9rEmNbPZgMHPQcu7E2rgSmz4LD3PhCE1lNGOgk/i4sKwC
 zgqUjU96+ju/a0xlv10HLS1Y1fnJ/ExsFYDMKBp8AJInHHixquZq5mR7qe1QpF692H2RIPqp
 3hsh0gN8N85zf4eXy0mwLk303a3DMn+xbZuCilqEqmhfa8aCMxCsJHi44cWADe8VAcsNZ117
 8O936FtrJMZCmw0xjV1pztbVVHh0C0qX0tnao4lHpES7YTb7dXsMg24F5VKpEdByj3gbpXXN
 WGNPuspcq+TGnqL0ww5gJUsZ+RtzUIb1q7q3E5y4KoO2M8pgE686MarPZv6kvouqhNDqWs3N
 60QpiAoos+O/P+XZgNddvpfvHHeVAlYSi8Rl56cm6XXZ3uBRr22uzKCfMOlaWXRKA=
X-IronPort-AV: E=Sophos;i="5.88,352,1635220800"; 
   d="scan'208";a="64127044"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=DeioHVBj86kzymeJ5aEiFRjjV/4xan0eg7grZSM9yLkJIh4I4XYigXwCPmEEQ4nTvSpYDC4I/Hr6/h2eMKl8bYnve0XfYWdxa60xhBKYfH4qqf1CUn3w8q9FlrknpdZk55i//GvIrCg3KEsSOFz8ibu6Qzdlm4Tpz34bU78gmgwwbN2L8MtCjwMidcGPZ+idbCKlrIC+QxI5bzGG8AiScpdAY+HfCimLMTbtRlg1MO3Dx5Hmyfb3q/1rMrobkx1Co7YeXXshqLk+FyBpoUfnWO+TN+tNFa9VS3hOojVmQoGgbalsvs5O2zoJq4RnQCtJpq6j6YVuri30WPlccvjicA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=OpHPeFK8/aFvQVhXcdAxvEMAyRgM08EMrbSWDNq0ceU=;
 b=hkHZxGGppCVw9niZQq5EdbiqWSMQv/0c/ZZAEh2Y6vFVNXHFHoFDu3EtQbUCvdT+L9F735DJ5DInDbgCX0RHbytNjqHWNxPM7S8Yes7W9SmfBOPOCcEiRDn+cug8Rt8pDzI2gLitCxkf8zS06k/ckO2ouFX3WbQJpdI4TZTkb1JGqoy1TB5W2xGvJVj5uEEWHZ5tBAURSylUTryuoLV2aEF7MGQzuitK8j9umIaRf2U904xZm/aTDN0rpiXfcWjiYwaSeBF2bNtNOVcTq2kj5pX8cT9YB/f16gX5uxz40wT2zzloR5yLKrQ44ZVL7nxNOyKll9own63elAhV8wDINw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=OpHPeFK8/aFvQVhXcdAxvEMAyRgM08EMrbSWDNq0ceU=;
 b=G756MLZxe8SIX7z7W0C1NGN3hsX/ujt0qr8Q0mZiR+P0HdDh0RVkjObR7B+MHD8RL0u4yoxprLifdKU2EzHQ1R/5V8IU+Vt59HTLhN0ubnHLPuSdaHWC7Ka9I0V4SB8UDWb56M7XAtPRooyULFc10djvdZZL1nHqRPOcPpMRBrE=
Date: Tue, 8 Feb 2022 12:11:58 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: Jan Beulich <jbeulich@suse.com>, "julien@xen.org" <julien@xen.org>,
	"sstabellini@kernel.org" <sstabellini@kernel.org>, Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Artem Mygaiev <Artem_Mygaiev@epam.com>,
	"andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
	"george.dunlap@citrix.com" <george.dunlap@citrix.com>, "paul@xen.org"
	<paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>, Rahul Singh
	<rahul.singh@arm.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v6 09/13] vpci/header: emulate PCI_COMMAND register for
 guests
Message-ID: <YgJP/jMhWBrLOpb2@Air-de-Roger>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-10-andr2000@gmail.com>
 <7df2379e-1c30-c362-3106-c7ef23af5c73@suse.com>
 <0ff2a524-9a65-861a-df87-cf3f682862d7@epam.com>
 <140e163c-87d0-2ae8-d57b-7ebc6757de9e@suse.com>
 <08d02313-349d-9ad4-926d-0d1419866363@epam.com>
 <186b7264-1190-3df2-415d-f1ec73a7c03f@suse.com>
 <ccaaa9b8-8ed9-054e-b724-70ca07401be9@epam.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <ccaaa9b8-8ed9-054e-b724-70ca07401be9@epam.com>
X-ClientProxiedBy: LO4P265CA0062.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:2af::18) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b9e6b1b5-06aa-471d-a58c-08d9eaf3d524
X-MS-TrafficTypeDiagnostic: MN2PR03MB4782:EE_
X-Microsoft-Antispam-PRVS: <MN2PR03MB478249E14497790987CF18A08F2D9@MN2PR03MB4782.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: EmpVPlkhxENOiOP08ZurlBFSjwJDF9Wovl9QbME1wkm6WKN6pVCaDEQN6934QtjTWYWkI9DELvWTTForQeDj913T7dyseZiSMmVKMkzSTkKTZxehHjyiqSb+k8LbBPDc+0dKbjkFFZVOVT7TnNPfsVJTqX8k/RQ6+FAYHfvOYG7jSeQ+76XQ18HvGnzekyU5IaEE+x5lAUDE2nAF8LNlTGNO9HjmNP4/6alMqmwKVmTovaT+McaFqOVBQxSKy7dSOrnRirX/WklgDPODhVs/opaNH0+oYE11zY0HwZaEKNJ3dOqNyTrKgsQ2NfITlPEwz01gZ1xLhRGFSuYehLbol+FOA566rgB7ekUFsJrUOlm6RmKoNz4L63aan6JrY7Bhg9rg29Nm5TME1OGFwdhk7w+4Ibkd40hTjof+7qk1/x10upE1TY0O5kwXzaeVMFAhsu3PhPJvcsgrgfNpXzaIO3V3IAbCmawybQDEQRfjjIAi5xk7oz0KgTY3Gez6DxwbraA2adL1Qk5n1YY+Okv7BnEAMjcw5zk4XfbxHC79CwfG+5A1ML+w8eWtV5yaKrQEF+ewCE3j1nFq/xRjSqqz7YnQMx9cfchxR1r/no5MWNDHH4ynWoQgaFymRwfeqdcdq+vwVlSI84AvbpyKOCP5nQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(186003)(5660300002)(7416002)(85182001)(8676002)(4326008)(66476007)(66556008)(8936002)(6506007)(66946007)(9686003)(6512007)(26005)(53546011)(33716001)(2906002)(6666004)(83380400001)(86362001)(508600001)(82960400001)(38100700002)(6486002)(6916009)(316002)(54906003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aVovMjV5WDJ5eWgwVFN6SWhMRHR3alpTSW1PUHg3NEJWeFZGc0lVTUdFRnRV?=
 =?utf-8?B?UDNWNkhxSkdmdkE5Rzc0N3RvUU1EQXpBVXB4L0xURUNXQXJYbm85THpTemZJ?=
 =?utf-8?B?aWlUK3F6K0xMM3pEMHR3VHdMNW1lVS83UytvaWxaWW1ieEhnOGZTdXVvVTBp?=
 =?utf-8?B?dWxVN09OR2ZweE1sNHBiZ0dJWHdiL2V2bjNYN3M2ayttWjYwRy8zUDdLMDFh?=
 =?utf-8?B?YmR3VEFKWjVyMW9pcDQ1M3hydVZiQVh6eDQzWkhWV3JmSzZEZkJEdlllNVNU?=
 =?utf-8?B?bHFEZ2xNenB4bVFzM2IxWU5KNGUwT21Pek5mTlJEYTV2QkU1dVM3VklkQWZC?=
 =?utf-8?B?SXlkQzdZQ2xYeGEvYm9NVnNTMjBoaXdiZFl3ajI0WXRMSGdtakVuOEhsSzVl?=
 =?utf-8?B?ZUdudnBHYVcrZkdpbFByQndMeE5oMnJBQmtpdlhZajc3amEvN3VCTWpQdnB3?=
 =?utf-8?B?STQxZUtSZmxJYzVNUzJuVGdNWk1vSW9qZGJ0WGxkWmUrVmhxTG4yMktPYnlE?=
 =?utf-8?B?N1lRT0xwaVBORTEvQTZlRE1PdHN5N0ZSKzdja0VXWExjdHRzTzRCNm9NZmYv?=
 =?utf-8?B?ckl1RzVhZGVid3FUa2wxUW40cGt4Y0RFRTNkVWMrYitsRnVNY0VVTzNWQkRG?=
 =?utf-8?B?N2MybTFZb2x1QXlsdFdlK2FSREhvbyt0eTMwNjB4K1ovalhpWmdNVHZnN1Yx?=
 =?utf-8?B?VFYyN0pzSmF2N0hDekdpQVBYZnZrMXZpZklQcmJzQW51THEwT09kUWovUUhr?=
 =?utf-8?B?VzJlZFlMbkFWQ3k5dGRZNGtzRUtiOXY2QlRzRTM0Y0ZhSHc0bDBZa3YzMksx?=
 =?utf-8?B?bTZlM3lGRVFFcUNqQ3dlL2FsUVRHQlRwblFOL0JZR2VBcFNIYXYvWVJpZit2?=
 =?utf-8?B?ZEFZMldIckhEKytqVU9SdGh1VGpPV2RDUEV3dlh3ZmI4MDF1c1phbXNQVmJK?=
 =?utf-8?B?ajNlSVBnVGxQdHV0SHZwWnYzbWd1aW0wMW1IYlZobVZJUXgxOFVIcTNjMWNR?=
 =?utf-8?B?WDhYMWJxckVpVXgrMWVyY0hVdlUzYTkvT0t3cmlaalVJSm9XMEwzK3BQTHQ2?=
 =?utf-8?B?UE9jV1NKTU5tblJObUkyUmRZcWZFS1pidW1pY2RZTW5GU1FOV1JvOTRLSURa?=
 =?utf-8?B?WUtxYTBCdEI2QzlQKzlMTEw1Mml6ODRuM3pNTWZGd2xpcnprKytld2pYczlq?=
 =?utf-8?B?NkJJMFFPZkVJMFdMZGtJakdrL0VtVHhVdXo2MHRVY2dUZjFkZWllYjBaQ044?=
 =?utf-8?B?SjBocnJrZ3F5c3hud0twRkhDdEdEbGdPRzRpVTNhYzdDbkdqUUJsdzNPWmNS?=
 =?utf-8?B?c2twZXZSV2pYRi8vbGtLekdjeEJLVE9nMVA5a2pXNi95bldKSGtqMHh3aTVB?=
 =?utf-8?B?TXEwNFc5Z2lCZUlWRkVOMEwvQlB1VWRPR3psSlZSVm9FSHMxRmQ0M0hOSHh3?=
 =?utf-8?B?K1BIMVpYcWNsa1RpOHFvRlVXVWQ4d1VLTDBqTDExa1lCQ3l6cEpjT29JQ3Vx?=
 =?utf-8?B?bnVXNE1PWG5vVUQwZE1LVmJHdWRycExzcCthS0l3Vm5MejI4aCtZcmNJZ2FR?=
 =?utf-8?B?TzlZQ3NlY2RTbElIVHlsajZvdWY3WG1EdHpSaTkvbWc2OW1aTGdFOGdONEcy?=
 =?utf-8?B?UTc4bXNtNlk0eG82SnZSV09vNjQ0Q0xkWGM0VmpUWlFadnorcDV0YThmVXIz?=
 =?utf-8?B?UkNXcjFJd0VFWm4wQjBnNWk0dWNhaGFYYmhsMUpMWS9taDBQSTFNSlpXOXZY?=
 =?utf-8?B?NXhFZk9mZm41UkNiYklKQWdIMEVtTU1yZEhMa2FuUHdoaXh5aEh1cUhBVVpP?=
 =?utf-8?B?enJnWFNQS21PYkMyNDBkc0l4UEZpMW5kRUVCbmhpSGtJVGJUWm9XYW5rVncr?=
 =?utf-8?B?aW0waVdWM0tSaThrMVBZQnE2a0JuRnh5ck9GeWoxZ3VpYUNDd2VkN0hVWU5R?=
 =?utf-8?B?Sm5pbmM3c0xRTFZpVllrMFp2cFd0bUZmY3doaDVVSnFzTXJjbmlTa0htNHlU?=
 =?utf-8?B?SU9mc3ZuZ2Q2bllQcUdRdWdNQmx4VEdCWE1maHNaSE1SZjREQ3JGWkVsdmpG?=
 =?utf-8?B?WWVmdDFZWEJ0cnQyRWgvVGJYWGl6NHNYalB2SVdMNFlWMlRRak5wMWtMOFkv?=
 =?utf-8?B?c2JkOG0vaE1mUzM0ejZPYXBScHRTaGJFblNNZTFJMGo2WTNyZk5OTmpSV3RD?=
 =?utf-8?Q?5WEU1g7Akd8QKqEixAZfYik=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b9e6b1b5-06aa-471d-a58c-08d9eaf3d524
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2022 11:12:02.4943
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2fxXI1ssAfSORnoIvHbeIjS0TrREKii4psVAIEBEb52Hp8MwVfAnBr8kuCbjG+l0ORh8PeO/Sidyum+zDsYFzg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB4782
X-OriginatorOrg: citrix.com

On Tue, Feb 08, 2022 at 09:58:40AM +0000, Oleksandr Andrushchenko wrote:
> 
> 
> On 08.02.22 11:52, Jan Beulich wrote:
> > On 08.02.2022 10:38, Oleksandr Andrushchenko wrote:
> >>
> >> On 08.02.22 11:33, Jan Beulich wrote:
> >>> On 08.02.2022 09:13, Oleksandr Andrushchenko wrote:
> >>>> On 04.02.22 16:25, Jan Beulich wrote:
> >>>>> On 04.02.2022 07:34, Oleksandr Andrushchenko wrote:
> >>>>>> --- a/xen/drivers/vpci/header.c
> >>>>>> +++ b/xen/drivers/vpci/header.c
> >>>>>> @@ -454,6 +454,22 @@ static void cmd_write(const struct pci_dev *pdev, unsigned int reg,
> >>>>>>             pci_conf_write16(pdev->sbdf, reg, cmd);
> >>>>>>     }
> >>>>>>     
> >>>>>> +static void guest_cmd_write(const struct pci_dev *pdev, unsigned int reg,
> >>>>>> +                            uint32_t cmd, void *data)
> >>>>>> +{
> >>>>>> +    /* TODO: Add proper emulation for all bits of the command register. */
> >>>>>> +
> >>>>>> +#ifdef CONFIG_HAS_PCI_MSI
> >>>>>> +    if ( pdev->vpci->msi->enabled || pdev->vpci->msix->enabled )
> >>>>>> +    {
> >>>>>> +        /* Guest wants to enable INTx. It can't be enabled if MSI/MSI-X enabled. */
> >>>>>> +        cmd |= PCI_COMMAND_INTX_DISABLE;
> >>>>>> +    }
> >>>>>> +#endif
> >>>>>> +
> >>>>>> +    cmd_write(pdev, reg, cmd, data);
> >>>>>> +}
> >>>>> It's not really clear to me whether the TODO warrants this being a
> >>>>> separate function. Personally I'd find it preferable if the logic
> >>>>> was folded into cmd_write().
> >>>> Not sure cmd_write needs to have guest's logic. And what's the
> >>>> profit? Later on, when we decide how PCI_COMMAND can be emulated
> >>>> this code will live in guest_cmd_write anyways
> >>> Why "will"? There's nothing conceptually wrong with putting all the
> >>> emulation logic into cmd_write(), inside an if(!hwdom) conditional.
> >>> If and when we gain CET-IBT support on the x86 side (and I'm told
> >>> there's an Arm equivalent of this), then to make this as useful as
> >>> possible it is going to be desirable to limit the number of functions
> >>> called through function pointers. You may have seen Andrew's huge
> >>> "x86: Support for CET Indirect Branch Tracking" series. We want to
> >>> keep down the number of such annotations; the vast part of the series
> >>> is about adding of such.
> >> Well, while I see nothing bad with that, from the code organization
> >> it would look a bit strange: we don't differentiate hwdom in vpci
> >> handlers, but instead provide one for hwdom and one for guests.
> >> While I understand your concern I still think that at the moment
> >> it will be more in line with the existing code if we provide a dedicated
> >> handler.
> > The existing code only deals with Dom0, and hence doesn't have any
> > pairs of handlers.
> This is fair
> >   FTAOD what I said above applies equally to other
> > separate guest read/write handlers you may be introducing. The
> > exception being when e.g. a hardware access handler is put in place
> > for Dom0 (for obvious reasons, I think).
> @Roger, what's your preference here?
> >

The newly introduced handler ends up calling the existing one, so in
this case it might make sense to expand cmd_write to also cater for
the domU case?

I think we need to be sensible here in that we don't want to end up
with handlers like:

register_read(...)
{
   if ( is_hardware_domain() )
       ....
   else
       ...
}

If there's shared code it's IMO better to not create as guest specific
handler.

It's also more risky to use the same handlers for dom0 and domU, as a
change intended to dom0 only might end up leaking in the domU path and
that could easily become a security issue.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 11:14:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 11:14:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268204.461996 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHORc-00035N-6g; Tue, 08 Feb 2022 11:14:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268204.461996; Tue, 08 Feb 2022 11:14:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHORc-00035G-0h; Tue, 08 Feb 2022 11:14:00 +0000
Received: by outflank-mailman (input) for mailman id 268204;
 Tue, 08 Feb 2022 11:13:58 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1FiY=SX=epam.com=prvs=40383cc40e=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nHORa-000358-CK
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 11:13:58 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 34a59c7e-88d0-11ec-8f75-fffcc8bd4f1a;
 Tue, 08 Feb 2022 12:13:56 +0100 (CET)
Received: from pps.filterd (m0174682.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 218B8ceT018383;
 Tue, 8 Feb 2022 11:13:45 GMT
Received: from eur05-am6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2107.outbound.protection.outlook.com [104.47.18.107])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3e3qcqr0jx-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Tue, 08 Feb 2022 11:13:45 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by DB7PR03MB3740.eurprd03.prod.outlook.com (2603:10a6:5:4::27) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4951.19; Tue, 8 Feb 2022 11:13:42 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77%3]) with mapi id 15.20.4951.019; Tue, 8 Feb 2022
 11:13:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 34a59c7e-88d0-11ec-8f75-fffcc8bd4f1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=dFjULULKJmnTLC1PJCMN5FBtQnMzlJehau3S9ifwGLL0g7pAWzvzik/ZiqabjrYXhZpDM5bef9JYrIWOGCzmtaf4JwkSDqEBaHVOe++jyOzxYPOBKwjokKq5/biyBm8sBTErNC/61W1hiW29IHcuiUxfMK/qcRe/jzYN0WWvaRppKdcgs+unXO6qNlspHR5YdLSIHf/LXv4vbeTxuM78j5NxOPiE9a+IY2ZiGOvL9w0ysNqq1J7XGCzwfleocczTa+pre0NGyiq9EPUQc2tMsmXlXFbuS8KpZaUiiSup6jmXmJcHrHtIToJP6+epobIuBwzQQKs5STurz5QQLH80wA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=x4I8BVsA/QH9ekKYRIH8d+MMQPplkQM20oTyjof8RdQ=;
 b=oTtNXtzXCwtD1cMht0y5+8Ht7h/DyRtukiu+g0FSuWFEFBBoxiT3PpED4qpASdU7Pm0GaAnR2OBjFP6M8pO16EISbHdirahtLqi21DckXOYkYR+SL3ZO0RZ4MtC6GUy69dhxkWpTlutdQMic8rvq25totT10ddGseC3Uz5v3Q43g5GOTHS69v/IZS1IXQoGyYYvnVa7Ws5SkhfDxHrJk75Mq0DHiy57AbUpXWC390VzPolfA6xUd54JDBYd71uA+EWgfV+FKLiLLTuNInI6MXtYltHTllKeSmPvNGYRGpU+U7sICEfvXweLQ4yB3QbbjOjsnkOydNvd1lTbJLOmDIg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=x4I8BVsA/QH9ekKYRIH8d+MMQPplkQM20oTyjof8RdQ=;
 b=Q4FVhMrzdo4I2wMDPvSAsH8TNXr5ZKwHWorm59Gn/wTL0+thqTukn01IPowh2eKq+5TAxLhPtGYa6lguBzq2cyeNhn1Bm06bBZhqKSd2VI8eSiGeB26CpV0/bnbsWlO7HJAu13gE6L71phTIKjaw4S5nHJlr2mxpnVoTrNUlMTNO+fmP5VKr+SKr2z5eR7ZxFy0SJ+frBqsKDBQBPDmAJU/D5Bbi1SjaDgMFQ43rhtmD9FNGOXpOikYz/loDK/NCGbfwjQVvwhLQNsWiuV9RvXuXgDV+iFXu6b4DdHkG5F8BTxj/aLxRpWFOirjru4lKM+cMWf9fVmoQDMnEX5lFdg==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>,
        Jan Beulich
	<jbeulich@suse.com>
CC: "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Thread-Topic: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Thread-Index: 
 AQHYGZFc/MnzQOjwVEeBBUHLSW0md6yDBUkAgAASSACAAATYAIAAD/WAgAAKNgCAAAbfgIAABnuAgAAQvgCAAAMCAIAAAY4AgAADxICAABrnAIAABAgAgAR3CoCAABt5gIAAEpuAgAAE5ICAAASKAIAAAiiAgAAKNYCAAARNAIAAC1wAgAACRYCAAAGVgIAABJiAgAAB5wCAAPjsgIAANleAgAAGm4A=
Date: Tue, 8 Feb 2022 11:13:41 +0000
Message-ID: <0f83fa71-c252-6e6c-47c9-3ef899b45901@epam.com>
References: <YgEsRuckQJIQlkzf@Air-de-Roger>
 <a2a42c1d-d379-00cd-5d55-f443cdb02e97@epam.com>
 <e8fc7872-c7d0-f389-c507-335b809ffcbc@epam.com>
 <21c8125a-2f79-1a4a-494c-db9e4be2a1a6@suse.com>
 <4276fe72-558b-7d95-6430-d4330989dbe8@epam.com>
 <ad985f4a-10f0-4a2d-df02-cde915fea3f1@suse.com>
 <f7669670-8eeb-9966-5ba3-e8f9c03ce3d3@epam.com>
 <73e08285-6bb1-5842-899f-bd6502406e49@suse.com>
 <be3f4222-6580-4c89-a202-c003b6feb9b4@epam.com>
 <e91965c5-0802-adf8-0c17-522f86ebf231@epam.com>
 <YgJK2zPszyTXGxMM@Air-de-Roger>
In-Reply-To: <YgJK2zPszyTXGxMM@Air-de-Roger>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 9ba7570b-c2f1-4da1-b232-08d9eaf41090
x-ms-traffictypediagnostic: DB7PR03MB3740:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <DB7PR03MB3740D5F16362544EE3A8D92DE72D9@DB7PR03MB3740.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 qq4DoVKvnJViBZwh5gKAVhDaDzkAQ8WSgI7E9gfI+riTG2YBD8AlrlbdokE9Dd1ui3b06AVfysFhtxoN5heqn2mANSey6889N71Wt2CNcwQhEqnI8MQ0A7HhMhVdEfHJ422r5QLJp2rV74nVskQnUK82ZQOcXN9NtB++eYtQCsavpSswoy7KuN+WtOlkW1Hu+RIpeTh5qhR6O6hnYJhf/Vd3KuaXum79KJnPQAUZ05M5wY1nqZUJd1tzs0aM1G6qJR0c5DNOGZhyJHdO6cSvzN6Dp/01uo8wIiUU8b+4bvmEu8bxHDoK5IWemDZshKd4LZISL9x9e2Uo6/MAWIJ936aonO8Sro+nQyPV7QkUwiIaVMG7eatcLrjhfgv5wK+r+uCjRWzdXdtRuCNoBpdpe9xhqLpoCjyyPrA6r5j9r7KE8ra+36upJJ6b41r+RBlpgC/uGMK4B90+nPIN6L8Srsm6+EwJUhmkCRf0N+IO6WXuvgPz+q87jdWuws5U+QtPJ9CaP8F1TgGqll6IPiJlEyNoVVax0nnjcimvNI/aHnm8JHPknGh+yXSsDJ78b5mb5xrdOD1BJhOJ5spUgDEN1Pzd4ze/sU1OZsHEL62LPG9OB4iIJ1SnNq4lyc1osP50oklRWDYU2UpxOr/7/2g8vZssECNDsk3j+CKgKi4cDO9zgNJy4kEQmVcgVSbCOe3NxiTKHFAeU9g6+nkSoOjbLgeqLy57p7qWH146UuUUCZo=
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66476007)(76116006)(38070700005)(30864003)(107886003)(66946007)(4326008)(508600001)(8676002)(8936002)(86362001)(31696002)(66556008)(64756008)(66446008)(110136005)(6486002)(91956017)(7416002)(5660300002)(54906003)(316002)(36756003)(6512007)(83380400001)(2616005)(53546011)(186003)(26005)(38100700002)(55236004)(71200400001)(122000001)(2906002)(31686004)(6506007)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?aGdMaVBjYXFsOVdyeHFuN1NwdHZTR2V6VENEQ3hWeVFWdEpBTEFZc3g1UWJC?=
 =?utf-8?B?TnU4UFdoNm5SOEhOaUhhSHQ4V0lsK3hqOGllYWJHNTJ1REtkcmdwSDdxVUdr?=
 =?utf-8?B?U3R6dzBKdk42Z015ZEwva3k2emN1d1VZRnNRNVNIcy9HQWJuVmtUVUV4cE80?=
 =?utf-8?B?SHVCWE5hcTY1c0NVSmVFbVpjYVVVZE5yTWlpMEtPa2FjOVJpL0VZbHpTZGp1?=
 =?utf-8?B?L2xrTUlDa1p3aFZWUmR3U05mdWdMM3hWT0hPWURIckJhMGFjcUgvaE9EaFRG?=
 =?utf-8?B?STVHdEJQQ01NVnhaZGNZVmY2NmZYSHhEU0l3UlhnQWxGOFhiNFVteVE2dzlB?=
 =?utf-8?B?QnAvcVBSUTNqa2pVdUt2Y0tzOGY1U2pvVkxzamptUkNMRE9LZkxOMHZWYllS?=
 =?utf-8?B?ZzBNTmdMUDFTakJQUlVsSFZvT0Y2YjVIRUFNdWdIWit4R2xlNUt1eFl0MXRX?=
 =?utf-8?B?aDFMNjlXRnk4Y3FmbXQ5M3dpSWNjWGZFaU5CMXRvazQ0dnRNeWVqU2J2SG05?=
 =?utf-8?B?cmY5bXd4MjFncEZKTEYrcm1RQUFGY1dMakxwV3dsVDU2RERKcGN1QTc5YUQz?=
 =?utf-8?B?Umt1MGkzZTBQdUNxNS9JSEdnMlZYSEFIR0RScDM1enZMZmpIcHFyaFlIN0ZF?=
 =?utf-8?B?RWtBZWVGZXgrUjljSUVUQWZpcm56WEpJRWNUVlkwNTdJZlNMNXc1S2pzNS92?=
 =?utf-8?B?eE5YNytOTjU1L2lkRGEzQ2FNMXMvNVJXT2lqdjZNdEZuSmpFZWlScVlGczkz?=
 =?utf-8?B?SVVHZ3Y1M29NOUNMWTRPUzVFRlhmOFBxZms4c1lsM0FGRFNSNkxTUlptdWxR?=
 =?utf-8?B?amIxa0E4WUJISEFFcWxjUGFia2UwWTZZNnhRMHRaUi96RXNmQWoyeGNTak84?=
 =?utf-8?B?TVluc1RnMUhYOG1NMEowdnVxNjlkRnB3RjNiT3JteW4xbHNJZkcwUy9Zc2JN?=
 =?utf-8?B?YkFRNlA0UDBYNlFoTkdGejFJTFNPbndOeUZWMXAzbWtVSWxoQkRLc3FGc0JE?=
 =?utf-8?B?eVZmK0hCOTY2MlZMSWp2Z0RmN0lJZ3B6a3AxYS9vNGc3V1dyUDF4Vjh0TDBs?=
 =?utf-8?B?ZEViMkRram9EbTl1TXVqSURWNG52QnU4NXVoN2Y5ZGcwSURpTU5wemI2b1lJ?=
 =?utf-8?B?ZGNkTUVrdU55OHFIdVR0d0RUc2lURTRGdWI1Mm1LZHQ0aW5JQWNwNytnQkRZ?=
 =?utf-8?B?ODdUUWNRL2l0YXZhdlZZNWFscHg1RjBHWW5ZRWhGUlhYOGEwYVg0YnVGQ0I4?=
 =?utf-8?B?dEpzdXlsejc3SzErd0UwaHpQbkNGU0pPa3FBdzc1aHM4TVczUS9CZEVZcTBJ?=
 =?utf-8?B?YmlHdVZXTGdodXVmU0kwU2s3NmdNNTU1U1FuOGdydmJrb0RUdzVkWjNaVWU0?=
 =?utf-8?B?d3RjbFBPK0h2ZEwrT3puY2NqL1lmRGJmK3lEOStHQlFIZ2ZDVnlLNGV4YllK?=
 =?utf-8?B?S3hvVXE0QytPdFFXSk9wbGdsdjJXQ2pqaytNZVRBdm5qRXl6Z3hnZ21YN0Za?=
 =?utf-8?B?dHVBdXBHb2R4Y0pacTNlRy9KT2hQQTFxQzU5dng0MnZTZmVJS0srTnNaaisx?=
 =?utf-8?B?ZzNiZGE1L1BQUGJBbEJmL1F3WUdmT0oyeDlpeGhQOWlraE9TNEhiYlZoSjR1?=
 =?utf-8?B?Q0h2SXBxMTNheHZWcU5UQ1lFb3RjYll2aUJveEdqdXBWZHpRNmQwMUhSUTBK?=
 =?utf-8?B?UTJKUEx1cW9McTlLaVFXN2ZUQy9IMHlmU0JSbFV4M0JDSGZIWFJhekduYUhS?=
 =?utf-8?B?bHp6cGJKd3lHNC9Fa1pEVURXakswN3U0S29RRWFsQXVVc0swMWJWUlJoMnR4?=
 =?utf-8?B?M21OVndodmpWNVpGVHkwa3JBTkFocGdHUGFsRHM1eHNZSklqSmVnNUJSbGlF?=
 =?utf-8?B?RDc1QnJKaXkwUExEWi9lWldROStDK3ZIWVFWNms2L2VEZEZwc3RDYlE4Vm9o?=
 =?utf-8?B?UEpRLzVJTTdUK0dySkQwL0h3djZpb3ZlbEZ5aUVnVG4yZ2VFcGJrdnptYTFB?=
 =?utf-8?B?dnF4MnF4SlQrL0tHNXhvNjRNNHZnSkdmRHpmdkQwUDVVMmhGWVlPQnQwYnhB?=
 =?utf-8?B?SGxGeEhuQ0JSc2lLRmlVUlZubXRsc05JQTU1b1hhTmZWWXgxT2xUTHd2czZM?=
 =?utf-8?B?RnhsQWtrakJlVVVuNS84UVNmcVJkZld0eEJ4cTF5aEUreDhpN0VxTlJPTDE2?=
 =?utf-8?B?N2pqaE4yQnZtMDhoakViOXNnT1ZqN1JhZFA3aUhHVDVPa2FWRGlINS9ORVhG?=
 =?utf-8?B?S2xRTm9WdmVCSERJNFJVcExlWEZsNlFNL29ZS0REUmRIT01kV2xmRFY4dXdi?=
 =?utf-8?B?UTFWYmZnREs3eFB5TFhsSHVJbmg1V3FVME81Y05vNCtNeW5kMVFFdTVkeFFv?=
 =?utf-8?Q?7Vc4jqSgmYsrbgYc=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <3CBA14D88FE99645B1A5D2CA74BD2FB0@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9ba7570b-c2f1-4da1-b232-08d9eaf41090
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2022 11:13:41.9067
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Zp8poiZI63HSkCgD+4QX51zWgudGc7+h3OEbcsu2VOCfoafw7rKI6Yw8EDXPiPyqpQHegPEHlILXRO1+qhh3gXs/eN/UgNtW7R2d5Bk0nED69PCqmZoqBS8OtPZJg/DN
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR03MB3740
X-Proofpoint-ORIG-GUID: M-KuOEgVOvS-s5oOwliLcCWjaluz_sms
X-Proofpoint-GUID: M-KuOEgVOvS-s5oOwliLcCWjaluz_sms
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-08_03,2022-02-07_02,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 malwarescore=0
 priorityscore=1501 suspectscore=0 lowpriorityscore=0 mlxlogscore=999
 phishscore=0 impostorscore=0 mlxscore=0 bulkscore=0 clxscore=1015
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202080067

DQoNCk9uIDA4LjAyLjIyIDEyOjUwLCBSb2dlciBQYXUgTW9ubsOpIHdyb3RlOg0KPiBPbiBUdWUs
IEZlYiAwOCwgMjAyMiBhdCAwNzozNTozNEFNICswMDAwLCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5r
byB3cm90ZToNCj4+DQo+PiBPbiAwNy4wMi4yMiAxODo0NCwgT2xla3NhbmRyIEFuZHJ1c2hjaGVu
a28gd3JvdGU6DQo+Pj4gT24gMDcuMDIuMjIgMTg6MzcsIEphbiBCZXVsaWNoIHdyb3RlOg0KPj4+
PiBPbiAwNy4wMi4yMDIyIDE3OjIxLCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyB3cm90ZToNCj4+
Pj4+IE9uIDA3LjAyLjIyIDE4OjE1LCBKYW4gQmV1bGljaCB3cm90ZToNCj4+Pj4+PiBPbiAwNy4w
Mi4yMDIyIDE3OjA3LCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyB3cm90ZToNCj4+Pj4+Pj4gT24g
MDcuMDIuMjIgMTc6MjYsIEphbiBCZXVsaWNoIHdyb3RlOg0KPj4+Pj4+Pj4gMWIuIE1ha2UgdnBj
aV93cml0ZSB1c2Ugd3JpdGUgbG9jayBmb3Igd3JpdGVzIHRvIGNvbW1hbmQgcmVnaXN0ZXIgYW5k
IEJBUnMNCj4+Pj4+Pj4+IG9ubHk7IGtlZXAgdXNpbmcgdGhlIHJlYWQgbG9jayBmb3IgYWxsIG90
aGVyIHdyaXRlcy4NCj4+Pj4+Pj4gSSBhbSBub3QgcXVpdGUgc3VyZSBob3cgdG8gZG8gdGhhdC4g
RG8geW91IG1lYW4gc29tZXRoaW5nIGxpa2U6DQo+Pj4+Pj4+IHZvaWQgdnBjaV93cml0ZShwY2lf
c2JkZl90IHNiZGYsIHVuc2lnbmVkIGludCByZWcsIHVuc2lnbmVkIGludCBzaXplLA0KPj4+Pj4+
PiAgICAgIMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB1aW50MzJfdCBkYXRhKQ0KPj4+
Pj4+PiBbc25pcF0NCj4+Pj4+Pj4gICAgICDCoMKgwqAgbGlzdF9mb3JfZWFjaF9lbnRyeSAoIHIs
ICZwZGV2LT52cGNpLT5oYW5kbGVycywgbm9kZSApDQo+Pj4+Pj4+IHsNCj4+Pj4+Pj4gW3NuaXBd
DQo+Pj4+Pj4+ICAgICAgwqDCoMKgIGlmICggci0+bmVlZHNfd3JpdGVfbG9jaykNCj4+Pj4+Pj4g
ICAgICDCoMKgwqAgwqDCoMKgIHdyaXRlX2xvY2soZC0+dnBjaV9sb2NrKQ0KPj4+Pj4+PiAgICAg
IMKgwqDCoCBlbHNlDQo+Pj4+Pj4+ICAgICAgwqDCoMKgIMKgwqDCoCByZWFkX2xvY2soZC0+dnBj
aV9sb2NrKQ0KPj4+Pj4+PiAuLi4uDQo+Pj4+Pj4+DQo+Pj4+Pj4+IEFuZCBwcm92aWRlIHJ3IGFz
IGFuIGFyZ3VtZW50IHRvOg0KPj4+Pj4+Pg0KPj4+Pj4+PiBpbnQgdnBjaV9hZGRfcmVnaXN0ZXIo
c3RydWN0IHZwY2kgKnZwY2ksIHZwY2lfcmVhZF90ICpyZWFkX2hhbmRsZXIsDQo+Pj4+Pj4+ICAg
ICAgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHZwY2lfd3JpdGVf
dCAqd3JpdGVfaGFuZGxlciwgdW5zaWduZWQgaW50IG9mZnNldCwNCj4+Pj4+Pj4gICAgICDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgdW5zaWduZWQgaW50IHNpemUs
IHZvaWQgKmRhdGEsIC0tLT4+PiBib29sIHdyaXRlX3BhdGggPDw8LS0tLS0pDQo+Pj4+Pj4+DQo+
Pj4+Pj4+IElzIHRoaXMgd2hhdCB5b3UgbWVhbj8NCj4+Pj4+PiBUaGlzIHNvdW5kcyBvdmVybHkg
Y29tcGxpY2F0ZWQuIFlvdSBjYW4gZGVyaXZlIGxvY2FsbHkgaW4gdnBjaV93cml0ZSgpLA0KPj4+
Pj4+IGZyb20ganVzdCBpdHMgInJlZyIgYW5kICJzaXplIiBwYXJhbWV0ZXJzLCB3aGV0aGVyIHRo
ZSBsb2NrIG5lZWRzIHRha2luZw0KPj4+Pj4+IGluIHdyaXRlIG1vZGUuDQo+Pj4+PiBZZXMsIEkg
c3RhcnRlZCB3cml0aW5nIGEgcmVwbHkgd2l0aCB0aGF0LiBTbywgdGhlIHN1bW1hcnkgKFJPTQ0K
Pj4+Pj4gcG9zaXRpb24gZGVwZW5kcyBvbiBoZWFkZXIgdHlwZSk6DQo+Pj4+PiBpZiAoIChyZWcg
PT0gUENJX0NPTU1BTkQpIHx8IChyZWcgPT0gUk9NKSApDQo+Pj4+PiB7DQo+Pj4+PiAgICAgwqDC
oMKgIHJlYWQgUENJX0NPTU1BTkQgYW5kIHNlZSBpZiBtZW1vcnkgb3IgSU8gZGVjb2RpbmcgYXJl
IGVuYWJsZWQuDQo+Pj4+PiAgICAgwqDCoMKgIGlmICggZW5hYmxlZCApDQo+Pj4+PiAgICAgwqDC
oMKgIMKgwqDCoCB3cml0ZV9sb2NrKGQtPnZwY2lfbG9jaykNCj4+Pj4+ICAgICDCoMKgwqAgZWxz
ZQ0KPj4+Pj4gICAgIMKgwqDCoCDCoMKgwqAgcmVhZF9sb2NrKGQtPnZwY2lfbG9jaykNCj4+Pj4+
IH0NCj4+Pj4gSG1tLCB5ZXMsIHlvdSBjYW4gYWN0dWFsbHkgZ2V0IGF3YXkgd2l0aG91dCB1c2lu
ZyAic2l6ZSIsIHNpbmNlIGJvdGgNCj4+Pj4gY29tbWFuZCByZWdpc3RlciBhbmQgUk9NIEJBUiBh
cmUgMzItYml0IGFsaWduZWQgcmVnaXN0ZXJzLCBhbmQgNjQtYml0DQo+Pj4+IGFjY2Vzc2VzIGdl
dCBzcGxpdCBpbiB2cGNpX2VjYW1fd3JpdGUoKS4NCj4+PiBCdXQsIE9TIG1heSB3YW50IHJlYWRp
bmcgYSBzaW5nbGUgYnl0ZSBvZiBST00gQkFSLCBzbyBJIHRoaW5rDQo+Pj4gSSdsbCBuZWVkIHRv
IGNoZWNrIGlmIHJlZytzaXplIGZhbGwgaW50byBQQ0lfQ09NQU5EIGFuZCBST00gQkFSDQo+Pj4g
cmFuZ2VzDQo+Pj4+IEZvciB0aGUgY29tbWFuZCByZWdpc3RlciB0aGUgbWVtb3J5LSAvIElPLWRl
Y29kaW5nLWVuYWJsZWQgY2hlY2sgbWF5DQo+Pj4+IGVuZCB1cCBhIGxpdHRsZSBtb3JlIGNvbXBs
aWNhdGVkLCBhcyB0aGUgdmFsdWUgdG8gYmUgd3JpdHRlbiBhbHNvDQo+Pj4+IG1hdHRlcnMuIE1h
eWJlIHJlYWQgdGhlIGNvbW1hbmQgcmVnaXN0ZXIgb25seSBmb3IgdGhlIFJPTSBCQVIgd3JpdGUs
DQo+Pj4+IHVzaW5nIHRoZSB3cml0ZSBsb2NrIHVuaWZvcm1seSBmb3IgYWxsIGNvbW1hbmQgcmVn
aXN0ZXIgd3JpdGVzPw0KPj4+IFNvdW5kcyBnb29kIGZvciB0aGUgc3RhcnQuDQo+Pj4gQW5vdGhl
ciBjb25jZXJuIGlzIHRoYXQgaWYgd2UgZ28gd2l0aCBhIHJlYWRfbG9jayBhbmQgdGhlbiBpbiB0
aGUNCj4+PiB1bmRlcmx5aW5nIGNvZGUgd2UgZGlzYWJsZSBtZW1vcnkgZGVjb2RpbmcgYW5kIHRy
eSBkb2luZw0KPj4+IHNvbWV0aGluZyBhbmQgY2FsbGluZyBjbWRfd3JpdGUgaGFuZGxlciBmb3Ig
YW55IHJlYXNvbiB0aGVuLi4uLg0KPj4+DQo+Pj4gSSBtZWFuIHRoYXQgdGhlIGNoZWNrIGluIHRo
ZSB2cGNpX3dyaXRlIGlzIHNvbWV3aGF0IHdlIGNhbiB0b2xlcmF0ZSwNCj4+PiBidXQgdGhlbiBp
dCBpcyBtdXN0IGJlIGNvbnNpZGVyZWQgdGhhdCBubyBjb2RlIGluIHRoZSByZWFkIHBhdGgNCj4+
PiBpcyBhbGxvd2VkIHRvIHBlcmZvcm0gd3JpdGUgcGF0aCBmdW5jdGlvbnMuIFdoaWNoIGJyaW5n
cyBhIHByZXR0eQ0KPj4+IHZhbGlkIHVzZS1jYXNlOiBzYXkgaW4gcmVhZCBtb2RlIHdlIGRldGVj
dCBhbiB1bnJlY292ZXJhYmxlIGVycm9yDQo+Pj4gYW5kIG5lZWQgdG8gcmVtb3ZlIHRoZSBkZXZp
Y2U6DQo+Pj4gdnBjaV9wcm9jZXNzX3BlbmRpbmcgLT4gRVJST1IgLT4gdnBjaV9yZW1vdmVfZGV2
aWNlIG9yIHNpbWlsYXIuDQo+Pj4NCj4+PiBXaGF0IGRvIHdlIGRvIHRoZW4/IEl0IGlzIGFsbCBn
b2luZyB0byBiZSBmcmFnaWxlLi4uDQo+PiBJIGhhdmUgdHJpZWQgdG8gc3VtbWFyaXplIHRoZSBv
cHRpb25zIHdlIGhhdmUgd3J0IGxvY2tpbmcNCj4+IGFuZCB3b3VsZCBsb3ZlIHRvIGhlYXIgZnJv
bSBAUm9nZXIgYW5kIEBKYW4uDQo+Pg0KPj4gSW4gZXZlcnkgdmFyaWFudCB0aGVyZSBpcyBhIHRh
c2sgb2YgZGVhbGluZyB3aXRoIHRoZSBvdmVybGFwDQo+PiBkZXRlY3Rpb24gaW4gbW9kaWZ5X2Jh
cnMsIHNvIHRoaXMgaXMgdGhlIG9ubHkgcGxhY2UgYXMgb2Ygbm93DQo+PiB3aGljaCBuZWVkcyBz
cGVjaWFsIHRyZWF0bWVudC4NCj4+DQo+PiBFeGlzdGluZyBsaW1pdGF0aW9uczogdGhlcmUgaXMg
bm8gd2F5IHRvIHVwZ3JhZGUgYSByZWFkIGxvY2sgdG8gYSB3cml0ZQ0KPj4gbG9jaywgc28gcGF0
aHMgd2hpY2ggbWF5IHJlcXVpcmUgd3JpdGUgbG9jayBwcm90ZWN0aW9uIG5lZWQgdG8gdXNlDQo+
PiB3cml0ZSBsb2NrIGZyb20gdGhlIHZlcnkgYmVnaW5uaW5nLiBXb3JrYXJvdW5kcyBjYW4gYmUg
YXBwbGllZC4NCj4+DQo+PiAxLiBQZXItZG9tYWluIHJ3IGxvY2ssIGFrYSBkLT52cGNpX2xvY2sN
Cj4+ID09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09DQo+PiBOb3RlOiB3aXRoIHBlci1kb21haW4gcncgbG9jayBpdCBpcyBwb3NzaWJs
ZSB0byBkbyB3aXRob3V0IGludHJvZHVjaW5nDQo+PiBwZXItZGV2aWNlIGxvY2tzLCBzbyBwZGV2
LT52cGNpLT5sb2NrIGNhbiBiZSByZW1vdmVkIGFuZCBubyBwZGV2LT52cGNpX2xvY2sNCj4+IHNo
b3VsZCBiZSByZXF1aXJlZC4NCj4gRXIsIG5vLCBJIHRoaW5rIHlvdSBzdGlsbCBuZWVkIGEgcGVy
LWRldmljZSBsb2NrIHVubGVzcyB5b3UgaW50ZW50IHRvDQo+IHRha2UgdGhlIHBlci1kb21haW4g
cndsb2NrIGluIHdyaXRlIG1vZGUgZXZlcnkgdGltZSB5b3UgbW9kaWZ5IGRhdGENCj4gaW4gdnBj
aS4NClRoaXMgaXMgZXhhY3RseSB0aGUgYXNzdW1wdGlvbiBzdGF0ZWQgYmVsb3cuIEkgYW0gdHJ5
aW5nIHRvIGRpc2N1c3MNCmFsbCB0aGUgcG9zc2libGUgb3B0aW9ucywgc28gdGhpcyBvbmUgaXMg
YWxzbyBsaXN0ZWQNCj4gICBJIHN0aWxsIHRoaW5rIHlvdSBuZWVkIHBkZXYtPnZwY2ktPmxvY2su
IEl0J3MgcG9zc2libGUgdGhpcw0KPiBhcHByb2FjaCBkb2Vzbid0IHJlcXVpcmUgbW92aW5nIHRo
ZSBsb2NrIG91dHNpZGUgb2YgdGhlIHZwY2kgc3RydWN0Lg0KPg0KPj4gVGhpcyBpcyBvbmx5IGdv
aW5nIHRvIHdvcmsgaW4gY2FzZSBpZiB2cGNpX3dyaXRlIGFsd2F5cyB0YWtlcyB0aGUgd3JpdGUg
bG9jaw0KPj4gYW5kIHZwY2lfcmVhZCB0YWtlcyBhIHJlYWQgbG9jayBhbmQgbm8gcGF0aCBpbiB2
cGNpX3JlYWQgaXMgYWxsb3dlZCB0bw0KPj4gcGVyZm9ybSB3cml0ZSBwYXRoIG9wZXJhdGlvbnMu
DQo+IEkgdGhpbmsgdGhhdCdzIGxpa2VseSB0b28gc3Ryb25nPw0KPg0KPiBZb3UgY291bGQgZ2V0
IGF3YXkgd2l0aCBib3RoIHZwY2lfe3JlYWQsd3JpdGV9IG9ubHkgdGFraW5nIHRoZSByZWFkDQo+
IGxvY2sgYW5kIHVzZSBhIHBlci1kZXZpY2UgdnBjaSBsb2NrPw0KQnV0IGFzIGRpc2N1c3NlZCBi
ZWZvcmU6DQotIGlmIHBkZXYtPnZwY2lfbG9jayBpcyB1c2VkIHRoaXMgc3RpbGwgbGVhZHMgdG8g
QUJCQQ0KLSB3ZSBzaG91bGQga25vdyBhYm91dCBpZiB0byB0YWtlIHRoZSB3cml0ZSBsb2NrIGJl
Zm9yZWhhbmQNCj4NCj4gT3RoZXJ3aXNlIHlvdSBhcmUgbGlrZWx5IHRvIGludHJvZHVjZSBjb250
ZW50aW9uIGluIG1zaXhfd3JpdGUgaWYgYQ0KPiBndWVzdCBtYWtlcyBoZWF2eSB1c2Ugb2YgdGhl
IE1TSS1YIGVudHJ5IG1hc2sgYml0Lg0KPg0KPj4gdnBjaV9wcm9jZXNzX3BlbmRpbmcgdXNlcyB3
cml0ZSBsb2NrIGFzIGl0IGhhdmUgdnBjaV9yZW1vdmVfZGV2aWNlIGluIGl0cw0KPj4gZXJyb3Ig
cGF0aC4NCj4+DQo+PiBQcm9zOg0KPj4gLSBubyBwZXItZGV2aWNlIHZwY2kgbG9jayBpcyBuZWVk
ZWQ/DQo+PiAtIHNvbHZlcyBvdmVybGFwIGNvZGUgQUJCQSBpbiBtb2RpZnlfYmFycw0KPj4NCj4+
IENvbnM6DQo+PiAtIGFsbCB3cml0ZXMgYXJlIHNlcmlhbGl6ZWQNCj4+IC0gbmVlZCB0byBjYXJl
ZnVsbHkgc2VsZWN0IHJlYWQgcGF0aHMsIHNvIHRoZXkgYXJlIGd1YXJhbnRlZWQgbm90IHRvIGxl
YWQNCj4+ICAgwqAgdG8gbG9jayB1cGdyYWRlIHVzZS1jYXNlcw0KPj4NCj4+IDEuMS4gU2VtaSBy
ZWFkIGxvY2sgdXBncmFkZSBpbiBtb2RpZnkgYmFycw0KPj4gLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0NCj4+IEluIHRoaXMgY2Fz
ZSBib3RoIHZwY2lfcmVhZCBhbmQgdnBjaV93cml0ZSB0YWtlIGEgcmVhZCBsb2NrIGFuZCB3aGVu
IGl0IGNvbWVzDQo+PiB0byBtb2RpZnlfYmFyczoNCj4+DQo+PiAxLiByZWFkX3VubG9jayhkLT52
cGNpX2xvY2spDQo+PiAyLiB3cml0ZV9sb2NrKGQtPnZwY2lfbG9jaykNCj4+IDMuIENoZWNrIHRo
YXQgcGRldi0+dnBjaSBpcyBzdGlsbCBhdmFpbGFibGUgYW5kIGlzIHRoZSBzYW1lIG9iamVjdDoN
Cj4+IGlmIChwZGV2LT52cGNpICYmIChwZGV2LT52cGNpID09IG9sZF92cGNpKSApDQo+PiB7DQo+
PiAgIMKgwqDCoCAvKiB2cGNpIHN0cnVjdHVyZSBpcyB2YWxpZCBhbmQgY2FuIGJlIHVzZWQuICov
DQo+PiB9DQo+PiBlbHNlDQo+PiB7DQo+PiAgIMKgwqDCoCAvKiB2cGNpIGhhcyBnb25lLCByZXR1
cm4gYW4gZXJyb3IuICovDQo+PiB9DQo+Pg0KPj4gUHJvczoNCj4+IC0gbm8gcGVyLWRldmljZSB2
cGNpIGxvY2sgaXMgbmVlZGVkPw0KPj4gLSBzb2x2ZXMgb3ZlcmxhcCBjb2RlIEFCQkEgaW4gbW9k
aWZ5X2JhcnMNCj4+IC0gcmVhZGVycyBhbmQgd3JpdGVycyBhcmUgTk9UIHNlcmlhbGl6ZWQNCj4+
IC0gTk8gbmVlZCB0byBjYXJlZnVsbHkgc2VsZWN0IHJlYWQgcGF0aHMsIHNvIHRoZXkgYXJlIGd1
YXJhbnRlZWQgbm90IHRvIGxlYWQNCj4+ICAgwqAgdG8gbG9jayB1cGdyYWRlIHVzZS1jYXNlcw0K
Pj4NCj4+IENvbnM6DQo+PiAtID8/Pw0KPj4NCj4+IDIuIHBlci1kZXZpY2UgbG9jayAocGRldi0+
dnBjaV9sb2NrKSArIGQtPm92ZXJsYXBfY2hrX2xvY2sNCj4+ID09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQo+PiBJbiBvcmRlciB0
byBzb2x2ZSBvdmVybGFwIEFCQkEsIHdlIGludHJvZHVjZSBhIHBlci1kb21haW4gaGVscGVyDQo+
PiBsb2NrIHRvIHByb3RlY3QgdGhlIG92ZXJsYXBwaW5nIGNvZGUgaW4gbW9kaWZ5X2JhcnM6DQo+
Pg0KPj4gICDCoMKgwqAgb2xkX3ZwY2kgPSBwZGV2LT52cGNpOw0KPj4gICDCoMKgwqAgc3Bpbl91
bmxvY2socGRldi0+dnBjaV9sb2NrKTsNCj4+ICAgwqDCoMKgIHNwaW5fbG9jayhwZGV2LT5kb21h
aW4tPm92ZXJsYXBfY2hrX2xvY2spOw0KPiBTaW5jZSB5b3UgZHJvcCB0aGUgcGRldiBsb2NrIHlv
dSBnZXQgYSB3aW5kb3cgaGVyZSB3aGVyZSBlaXRoZXIgdnBjaQ0KPiBvciBldmVuIHBkZXYgaXRz
ZWxmIGNvdWxkIGJlIHJlbW92ZWQgdW5kZXIgeW91ciBmZWV0LCBzbyB1c2luZw0KPiBwZGV2LT52
cGNpX2xvY2sgbGlrZSB5b3UgZG8gYmVsb3cgY291bGQgZGVyZWZlcmVuY2UgYSBzdGFsZSBwZGV2
Lg0KcGRldiBpcyBhbnl3YXlzIG5vdCBwcm90ZWN0ZWQgd2l0aCBwY2lkZXZzIGxvY2sgaGVyZSwg
c28gZXZlbg0Kbm93IGl0IGlzIHBvc3NpYmxlIHRvIGhhdmUgcGRldiBkaXNhcGVhciBpbiBiZXR3
ZWVuLg0KV2UgZG8gbm90IHVzZSBwY2lkZXZzX2xvY2sgaW4gTU1JTyBoYW5kbGVycy4uLg0KPg0K
Pj4gICDCoMKgwqAgc3Bpbl9sb2NrKHBkZXYtPnZwY2lfbG9jayk7DQo+PiAgIMKgwqDCoCBpZiAo
IHBkZXYtPnZwY2kgJiYgKHBkZXYtPnZwY2kgPT0gb2xkX3ZwY2kpICkNCj4+ICAgwqDCoMKgwqDC
oMKgwqAgZm9yX2VhY2hfcGRldiAoIHBkZXYtPmRvbWFpbiwgdG1wICkNCj4+ICAgwqDCoMKgwqDC
oMKgwqAgew0KPj4gICDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGlmICggdG1wICE9IHBkZXYgKQ0K
Pj4gICDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHsNCj4+ICAgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgIHNwaW5fbG9jayh0bXAtPnZwY2lfbG9jayk7DQo+PiAgIMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoCBpZiAoIHRtcC0+dnBjaSApDQo+PiAgIMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgIC4uLg0KPj4gICDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIH0N
Cj4+ICAgwqDCoMKgwqDCoMKgwqAgfQ0KPj4NCj4+IFByb3M6DQo+PiAtIGFsbCBhY2Nlc3NlcyBh
cmUgaW5kZXBlbmRlbnQsIG9ubHkgdGhlIHNhbWUgZGV2aWNlIGFjY2VzcyBpcyBzZXJpYWxpemVk
DQo+PiAtIG5vIG5lZWQgdG8gY2FyZSBhYm91dCByZWFkZXJzIGFuZCB3cml0ZXJzIHdydCByZWFk
IGxvY2sgdXBncmFkZSBpc3N1ZXMNCj4+DQo+PiBDb25zOg0KPj4gLSBoZWxwZXIgc3BpbiBsb2Nr
DQo+Pg0KPj4gMy4gTW92ZSBvdmVybGFwIGRldGVjdGlvbiBpbnRvIHByb2Nlc3MgcGVuZGluZw0K
Pj4gPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT0NCj4+IFRoZXJlIGlzIGEgUm9nZXIncyBwYXRjaCBbMV0gd2hpY2ggYWRkcyBhIHBv
c3NpYmlsaXR5IGZvciB2cGNpX3Byb2Nlc3NfcGVuZGluZw0KPj4gdG8gcGVyZm9ybSBkaWZmZXJl
bnQgdGFza3MgcmF0aGVyIHRoYW4ganVzdCBtYXAvdW5tYXAuIFdpdGggdGhpcyBwYXRjaCBleHRl
bmRlZA0KPj4gaW4gYSB3YXkgdGhhdCBpdCBjYW4gaG9sZCBhIHJlcXVlc3QgcXVldWUgaXQgaXMg
cG9zc2libGUgdG8gZGVsYXkgZXhlY3V0aW9uDQo+PiBvZiB0aGUgb3ZlcmxhcCBjb2RlIHVudGls
IG5vIHBkZXYtPnZwY2lfbG9jayBpcyBoZWxkLCBidXQgYmVmb3JlIHJldHVybmluZyB0bw0KPj4g
YSBndWVzdCBhZnRlciB2cGNpX3tyZWFkfHdyaXRlfSBvciBzaW1pbGFyLg0KPj4NCj4+IFByb3M6
DQo+PiAtIG5vIG5lZWQgdG8gZW11bGF0ZSByZWFkIGxvY2sgdXBncmFkZQ0KPj4gLSBmdWxseSBw
YXJhbGxlbCByZWFkL3dyaXRlDQo+PiAtIHF1ZXVlIGluIHRoZSB2cGNpX3Byb2Nlc3NfcGVuZGlu
ZyB3aWxsIGxhdGVyIG9uIGJlIHVzZWQgYnkgU1ItSU9WLA0KPj4gICDCoCBzbyB0aGlzIGlzIGdv
aW5nIHRvIGhlbHAgdGhlIGZ1dHVyZSBjb2RlDQo+PiBDb25zOg0KPj4gLSA/Pz8NCj4gTWF5YmU/
IEl0J3MgaGFyZCB0byBkZXZpc2UgaG93IHRoYXQgd291bGQgZW5kIHVwIGxvb2tpbmcgbGlrZSwg
YW5kDQo+IHdoZXRoZXIgaXQgd29uJ3Qgc3RpbGwgcmVxdWlyZSBzdWNoIGtpbmQgb2YgZG91Ymxl
IGxvY2tpbmcuIFdlIHdvdWxkDQo+IHN0aWxsIG5lZWQgdG8gcHJldmVudCBkb2luZyBhIHJhbmdl
c2V0X3JlbW92ZV9yYW5nZSBmb3IgdGhlIGRldmljZSB3ZQ0KPiBhcmUgdHJ5aW5nIHRvIHNldHVw
IHRoZSBtYXBwaW5nIGZvciwgYXQgd2hpY2ggcG9pbnQgd2Ugc3RpbGwgbmVlZCB0bw0KPiBsb2Nr
IHRoZSBjdXJyZW50IGRldmljZSBwbHVzIHRoZSBkZXZpY2Ugd2UgYXJlIGl0ZXJhdGluZyBhZ2Fp
bnN0Pw0KPg0KPiBTaW5jZSB0aGUgY29kZSBpbiB2cGNpX3Byb2Nlc3NfcGVuZGluZyBpcyBhbHdh
eXMgZXhlY3V0ZWQgaW4gZ3Vlc3QNCj4gdkNQVSBjb250ZXh0IHJlcXVpcmluZyBhbGwgZ3Vlc3Qg
dkNQVXMgdG8gYmUgcGF1c2VkIHdoZW4gZG9pbmcgYQ0KPiBkZXZpY2UgYWRkaXRpb24gb3IgcmVt
b3ZhbCB3b3VsZCBwcmV2ZW50IGRldmljZXMgZnJvbSBnb2luZyBhd2F5LCBidXQNCj4gd2UgY291
bGQgc3RpbGwgaGF2ZSBpc3N1ZXMgd2l0aCBjb25jdXJyZW50IGFjY2Vzc2VzIGZyb20gb3RoZXIg
dkNQVXMuDQpZZXMsIEkgdW5kZXJzdGFuZCB0aGF0IHRoaXMgbWF5IG5vdCBiZSBlYXNpbHkgZG9u
ZSwgYnV0IHRoaXMgaXMgc3RpbGwNCmFuIG9wdGlvbiwNCj4NCj4+IDQuIFJlLXdyaXRlIG92ZXJs
YXAgZGV0ZWN0aW9uIGNvZGUNCj4+ID09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09DQo+PiBJdCBpcyBwb3NzaWJsZSB0byByZS13cml0
ZSBvdmVybGFwIGRldGVjdGlvbiBjb2RlLCBzbyB0aGUgaW5mb3JtYXRpb24gYWJvdXQgdGhlDQo+
PiBtYXBwZWQvdW5tYXBwZWQgcmVnaW9ucyBpcyBub3QgcmVhZCBmcm9tIHZwY2ktPmhlYWRlci0+
YmFyc1tpXSBvZiBlYWNoIGRldmljZSwNCj4+IGJ1dCBpbnN0ZWFkIHRoZXJlIGlzIGEgcGVyLWRv
bWFpbiBzdHJ1Y3R1cmUgd2hpY2ggaG9sZHMgdGhlIHJlZ2lvbnMgYW5kDQo+PiBpbXBsZW1lbnRz
IHJlZmVyZW5jZSBjb3VudGluZy4NCj4+DQo+PiBQcm9zOg0KPj4gLSBzb2x2ZXMgQUJCQQ0KPj4N
Cj4+IENvbnM6DQo+PiAtIHZlcnkgY29tcGxleCBjb2RlIGlzIGV4cGVjdGVkDQo+Pg0KPj4gNS4g
WW91IG5hbWUgaXQNCj4+ID09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09DQo+Pg0KPj4gICBGcm9tIGFsbCB0aGUgYWJvdmUgSSB3b3Vs
ZCByZWNvbW1lbmQgd2UgZ28gd2l0aCBvcHRpb24gMiB3aGljaCBzZWVtcyB0byByZWxpYWJseQ0K
Pj4gc29sdmUgQUJCQSBhbmQgZG9lcyBub3QgYnJpbmcgY29ucyBvZiB0aGUgb3RoZXIgYXBwcm9h
Y2hlcy4NCj4gNi4gcGVyLWRvbWFpbiByd2xvY2sgKyBwZXItZGV2aWNlIHZwY2kgbG9jaw0KPg0K
PiBJbnRyb2R1Y2UgdnBjaV9oZWFkZXJfd3JpdGVfbG9jayhzdGFydCwge2VuZCwgc2l6ZX0pIGhl
bHBlcjogcmV0dXJuDQo+IHdoZXRoZXIgYSByYW5nZSByZXF1aXJlcyB0aGUgcGVyLWRvbWFpbiBs
b2NrIGluIHdyaXRlIG1vZGUuIFRoaXMgd2lsbA0KPiBvbmx5IHJldHVybiB0cnVlIGlmIHRoZSBy
YW5nZSBvdmVybGFwcyB3aXRoIHRoZSBCQVIgUk9NIG9yIHRoZSBjb21tYW5kDQo+IHJlZ2lzdGVy
Lg0KPg0KPiBJbiB2cGNpX3tyZWFkLHdyaXRlfToNCj4NCj4gaWYgKCB2cGNpX2hlYWRlcl93cml0
ZV9sb2NrKC4uLikgKQ0KPiAgICAgIC8qIEdhaW4gZXhjbHVzaXZlIGFjY2VzcyB0byBhbGwgb2Yg
dGhlIGRvbWFpbiBwZGV2cyB2cGNpLiAqLw0KPiAgICAgIHdyaXRlX2xvY2soZC0+dnBjaSk7DQo+
IGVsc2UNCj4gew0KPiAgICAgIHJlYWRfbG9jayhkLT52cGNpKTsNCj4gICAgICBzcGluX2xvY2so
dnBjaS0+bG9jayk7DQo+IH0NCj4gLi4uDQo+DQo+IFRoZSB2cGNpIGFzc2lnbi9kZWFzc2lnbiBm
dW5jdGlvbnMgd291bGQgbmVlZCB0byBiZSBtb2RpZmllZCB0byB3cml0ZQ0KPiBsb2NrIHRoZSBw
ZXItZG9tYWluIHJ3bG9jay4gVGhlIE1TSS1YIHRhYmxlIE1NSU8gaGFuZGxlciB3aWxsIGFsc28N
Cj4gbmVlZCB0byByZWFkIGxvY2sgdGhlIHBlciBkb21haW4gdnBjaSBsb2NrLg0KT2ssIHNvIGl0
IHNlZW1zIHlvdSBhcmUgaW4gZmF2b3Igb2YgdGhpcyBpbXBsZW1lbnRhdGlvbiBhbmQgSSBoYXZl
DQpubyBvYmplY3Rpb24gYXMgd2VsbC4gVGhlIG9ubHkgbGltaXRhdGlvbiB3ZSBzaG91bGQgYmUg
YXdhcmUgb2YgaXMNCnRoYXQgb25jZSBhIHBhdGggaGFzIGFjcXVpcmVkIHRoZSByZWFkIGxvY2sg
aXQgaXMgbm90IHBvc3NpYmxlIHRvIGRvDQphbnkgd3JpdGUgcGF0aCBvcGVyYXRpb25zIGluIHRo
ZXJlLg0KdnBjaV9wcm9jZXNzX3BlbmRpbmcgd2lsbCBhY3F1aXJlIHdyaXRlIGxvY2sgdGhvdWdo
IGFzIGl0IGNhbg0KbGVhZCB0byB2cGNpX3JlbW92ZV9kZXZpY2Ugb24gaXRzIGVycm9yIHBhdGgu
DQoNClNvLCBJIGFtIGdvaW5nIHRvIGltcGxlbWVudCBwZGV2LT52cGNpLT5sb2NrICsgZC0+dnBj
aV9sb2NrDQo+DQo+IEkgdGhpbmsgaXQncyBlaXRoZXIgc29tZXRoaW5nIGFsb25nIHRoZSBsaW5l
cyBvZiBteSBzdWdnZXN0aW9uIGFib3ZlLA0KPiBvciBtYXliZSBvcHRpb24gMywgYWxiZWl0IHlv
dSB3b3VsZCBoYXZlIHRvIGludmVzdGlnYXRlIGhvdyB0bw0KPiBpbXBsZW1lbnQgb3B0aW9uIDMu
DQo+DQo+IFRoYW5rcywgUm9nZXIuDQoNCkBSb2dlciwgQEphbiENClRoYW5rIHlvdSEh


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 11:24:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 11:24:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268217.462006 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHObT-0004cn-7l; Tue, 08 Feb 2022 11:24:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268217.462006; Tue, 08 Feb 2022 11:24:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHObT-0004cg-4f; Tue, 08 Feb 2022 11:24:11 +0000
Received: by outflank-mailman (input) for mailman id 268217;
 Tue, 08 Feb 2022 11:24:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=kNDV=SX=epam.com=prvs=4038445554=volodymyr_babchuk@srs-se1.protection.inumbo.net>)
 id 1nHObS-0004ca-7s
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 11:24:10 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a0d4b2f0-88d1-11ec-8f75-fffcc8bd4f1a;
 Tue, 08 Feb 2022 12:24:08 +0100 (CET)
Received: from pps.filterd (m0174678.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 218BNfSe008589;
 Tue, 8 Feb 2022 11:23:59 GMT
Received: from eur05-vi1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2171.outbound.protection.outlook.com [104.47.17.171])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e3qkv801c-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Tue, 08 Feb 2022 11:23:59 +0000
Received: from PAXPR03MB7594.eurprd03.prod.outlook.com (2603:10a6:102:201::14)
 by PR2PR03MB5292.eurprd03.prod.outlook.com (2603:10a6:101:1b::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Tue, 8 Feb
 2022 11:23:55 +0000
Received: from PAXPR03MB7594.eurprd03.prod.outlook.com
 ([fe80::9025:6fcc:a1c:eb26]) by PAXPR03MB7594.eurprd03.prod.outlook.com
 ([fe80::9025:6fcc:a1c:eb26%5]) with mapi id 15.20.4951.019; Tue, 8 Feb 2022
 11:23:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a0d4b2f0-88d1-11ec-8f75-fffcc8bd4f1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=NO1nHYU5Shh3YqrtMThoWiR8p6PVMhfH6IQgW5KzlwAyJeF/3eCkCocXaZoHYzNUGbYshJfLPKK+Fxr48q2i+jQAmSTnAhcKyPPcB6r3lD5IfUh4+4Jd7AEN9USmevdgwzEe+UoS8R9a9Fh1DJJ5QyLiJxddqE0gNgLA+lZwWIpt0bPfv8MKs01sIxGly5/BEXjMRaZDnkJ6xQujtfLenDjbd7FOex+MuZsrDtNVDIFeNFI1pyyrNq5kzx5jsrI95daWvLs8z5hVh3k2yhTxB6f2ZwQ0siG8Ho20JbeGL8pY1/x/Sgvz5bM/ZTRO6RzrTtvcljM6bB1km5Z5bItU6w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=4mry2wGJogdUgfwuOoSU5+mvvtEAqCj4dHvaLR3FDZI=;
 b=EsmD33/PzCP3My/U4QOxJXHuODRC3UBE4Io9qmi+URD/074yieOixiJ9MvPobGhjO4/wQhJ2dZQxfKmFpxWS3TExhOWJuxYQWaFrGLVPbBOGauhMdW/3ScRqzTKdvtUqjcIdrOFSSE6J84JZvWgQfO1MDnsVbIX5g8VuXU7qDpXjNhvc7AQKEeFTYwzG8VEAcvPkdhbGydxur51Uv9sdi6S1sOq08vDzzWBfsuAMZjKCHWwV1mjoqXTIAN2cYkPVSb0KOGxZUmbqn8lLGrVjkZZqjQuxb989MY+kBUxku52qoQ2kPfxnwlJJady7Ki2TbZHeicBSL3Iqgn5nzFsJVA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=4mry2wGJogdUgfwuOoSU5+mvvtEAqCj4dHvaLR3FDZI=;
 b=VwcjpxxuCsf7AREb50M2L5/GYhJrwYNj74iz/00o1dTpQGC0z384HV/9u3YUj7rnZAeaNE+m0JtS4Uy+sK6d05alfZtouyH7NkFKGP81EZZ/c97AWESscTKxkpmhWZNeQ7K1L89qWoIibv+DO++JTPcMn2NPiuDAnoni8cY3YGotuYbacSuWya16Jr6YvYzVCNxQJCdlaS2UTfRkmHQVhCWKfKQ9XryckxkviBIegPQqzaAaPwjsScvxPBHRwgHFyLowG0t87qubh9EDZ6O+zWJ/RvOecI1rWAMQ3qHiI0PWhm7AaOgGah5PcZ0btn5yaqsuU4x3V/kJjQXHX7/ycw==
From: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        Stefano
 Stabellini <sstabellini@kernel.org>,
        Julien Grall <julien@xen.org>,
        Volodymyr
 Babchuk <Volodymyr_Babchuk@epam.com>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>
CC: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>
Subject: [PATCH] xen/serial: scif: add support for HSCIF
Thread-Topic: [PATCH] xen/serial: scif: add support for HSCIF
Thread-Index: AQHYHN5b+zcSsmlMWk6M2sxqYcvKKw==
Date: Tue, 8 Feb 2022 11:23:55 +0000
Message-ID: <20220208112304.1191924-1-volodymyr_babchuk@epam.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-mailer: git-send-email 2.34.1
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 38c9efca-73a4-4778-8806-08d9eaf57e2d
x-ms-traffictypediagnostic: PR2PR03MB5292:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <PR2PR03MB5292F0C8463ED33E15497858E62D9@PR2PR03MB5292.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:3968;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 nPU5XPs7prKj0uouIDqQha+E3pSdGFVJDfR1qUYLznXP0Sf27Fx9Wspw189Cp1Mpd4xtRdGS+9rlsZk7INsZfxlzJDeAOFq9uP6EpM3VAuDQVQMViu2bQwk21Pha9QF40D7WzEJrwnye/hhnTOjEvmcesmcIaGNhg5DEhW1PI4CQ1M8SeDfma1bY0jFH8UZSzKlpjc1U9gx1n97spU3BQSbeXE5LBevMcuXEQfFlxnVwx7GdAr8AHrrQwOrL1hlXi3ytPJkeT3nA/xt9vWjSEz/xkWoghv2IqtcKyH/d9PaZDULFSUcwrYRKOrpbcjlL6FCg898y38bVrerukl5VZnLJE1JQo8Wa4yvC1/c4K4BuWXRDVLTO3D34JRl89fG5UYozpnd/XnAuMiW8TOdPcYS4gcOtFRS6FFAxW257yKqqZoXbQ+tFSsmIFqPJ8Wo4a6AIqKMSmJ9NKv+3134xpR8sEaBCr9YrKiu+9E4obnMU84WThlGATlLnvUjdGU6EniAjFN/6QV+CeCsp69jIS7i7EjVpWSvooiN/iYp/GUCfa51p1Wpx81ozSAa7s+i9D7xyuAy3XJgcHPS8X9YA68UIJ8UQ7ZO5kLiOIwOXay+WWou5ekvuFgxm+6/4EUaVIZcxgwFb2X6EWCcBEpTUEyWHtGtSZvLsbTZC4k4Ce5etlE0UqWFvoJudfJpRWg9b56f1od1PLrYuol8KHfaBaA==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR03MB7594.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66946007)(76116006)(66556008)(186003)(26005)(36756003)(4326008)(64756008)(66446008)(66476007)(8676002)(8936002)(83380400001)(71200400001)(2616005)(6486002)(107886003)(508600001)(38070700005)(1076003)(86362001)(91956017)(55236004)(5660300002)(316002)(122000001)(54906003)(110136005)(6512007)(6506007)(38100700002)(2906002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?iso-8859-1?Q?qTo9A0HUXZCCPjyT/+REYyPuNCDDjn84/11nlGTc24KXxFK+jp3MQqo36p?=
 =?iso-8859-1?Q?Zq0Fy5WmO4dVRajKJD9Yu4hdHdMDfjdYzJRGattE6R4PsTdr4buQja0rkj?=
 =?iso-8859-1?Q?x8Otw6OYAxHd2vDVlJvpui3hosLfjPSKpcJb1SycixxpZ4KeKTAKKV5iiJ?=
 =?iso-8859-1?Q?VH7wA9P3kxcoB60EUzt/+lRSyCHq28jO9PTmGaz4H55JvqPoGMKRIJCiI6?=
 =?iso-8859-1?Q?P8jpmf0GXeyyzMsE8ZUCWY/az0th6os+IMN6n5hEEd/N0KkKHMF3xgLD1Z?=
 =?iso-8859-1?Q?BG/jJwDJaAzKfScSEAvNCZRGpR32zXafMh/speiEi40RYWzH/1vZhbo2Fy?=
 =?iso-8859-1?Q?35qVvzO++viYCxFOgRBP8al/Bk7eyJTI7e/HSE7JZKa8xCwQG0Gmwl2NRT?=
 =?iso-8859-1?Q?xjqO/WcAgfPLHlWGWZbZPQsXvW3GCpzjvhqCmp213qjUtNZ4DnECkUDNUx?=
 =?iso-8859-1?Q?TYRPTjf3MQWZDkRdFTvwkzGyAE9vAFlX8rEx7Txk7ntGzZNl+6mSpuiUnB?=
 =?iso-8859-1?Q?pFOSFK9G69kxzDrsv+a6TqyyhQUfOKf7LFcx0J6p2t4aDNnid7jCkUmVCt?=
 =?iso-8859-1?Q?7A7WY1QS+YSBlWkHDRi0WwVdqZoHBnlZzkTALPl4+0slYOgHYCHNPmBxok?=
 =?iso-8859-1?Q?NvlJPjT9SKSMPek3pITiMH+heqVwWN29IBB/CYOKmZfgJ6wKU0cwQkCo3Z?=
 =?iso-8859-1?Q?WROimmXcxJ7do6oILlwOxYgL+JInR1WV1HKlsCtbcmlsUG0StkhW0lsFYw?=
 =?iso-8859-1?Q?GXgEEjwQRUMkKwK4aEsZH7pEwE1Bg9CiH4QxU4yp+c3bvKKXavhERwZPQi?=
 =?iso-8859-1?Q?DNcpCG+cH1khzp0LNGDKMleoLKQp+OmUzOwrnpg83Vya/x6j9VLGTSNQyz?=
 =?iso-8859-1?Q?2a8xPNz3Jv99Vvrhquef84weqiORLO9d+eOjTeXCuTSOoUtGVdPZNRVJo3?=
 =?iso-8859-1?Q?Q5pqsSN0HhUGMlvgrbIrhm6gbXO8U7T2gE2aZUrXPenmmL41o+YakmNkkv?=
 =?iso-8859-1?Q?ix42AfyxwBMck3E8sITvWlFSA01bkAdnSpJfsBb0G7/MlZ0K63tHvdTfJp?=
 =?iso-8859-1?Q?ZgKb+PlbitH/NiB3GQAj6xwJH0gAR4F54d4z64ujneVI8yeTOIpFPuGXP8?=
 =?iso-8859-1?Q?GnNic1FBpPzrj8lqO9udS7MCB/B/IDXSAO+Em5DNK5uF760SWnORCfYPYT?=
 =?iso-8859-1?Q?NiLh+DWjpp+5Ua2BTcH/N907ho9oCnlQWBDwvjA9/BrlPPM8qN3orovBtB?=
 =?iso-8859-1?Q?yZ9A3AGaYDr++ZOUZnfMuZIMKjJ3Y+iKRPlYwOiu7uqYQI6jaHjuRWUNEU?=
 =?iso-8859-1?Q?KlC3y/MHeBn4mGZbLRLxG/L0PnIyEQvSAAQvjPduLQROlKTizEn2J05g46?=
 =?iso-8859-1?Q?K9+NxMr5TF/pjZ8uR7bbHyyfklYGywvScyoN2gFZPlOZjQHFpYxatNaKZ0?=
 =?iso-8859-1?Q?x8z229+MWOJqt+/Fh9fKVZQX0HWHpKzL2KVudoRYVrdbAl1Sl651qAks6P?=
 =?iso-8859-1?Q?p5cb6L9HqCIKEGSdlNZZf7UfM4o1c4mN8sB0SfOXXjrSj7Caa9PjabV1Y1?=
 =?iso-8859-1?Q?URWxyhJIMiFy2SQsjPTK5dzpua8yDhS2k9pkYDep8RoCdNY6DusG6HQfG8?=
 =?iso-8859-1?Q?m7SswWibRAbGSi8wF2CxwwituHJJwdSvfG5OJFL5JaAoXI1J9zMqjyXsww?=
 =?iso-8859-1?Q?OzeLWAiV7cFpfKkZlyl7HVjvAcqPOthwRWXEbmBO0kFWqnZ31CwCfJ3xsY?=
 =?iso-8859-1?Q?NXFBmeEgQ4hWg6EzatE8AAz5g=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PAXPR03MB7594.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 38c9efca-73a4-4778-8806-08d9eaf57e2d
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2022 11:23:55.3655
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: x7+G65dJQue2RaOPe4AFrB99rz4M0VyWlCHHgRBJALj9Efgr9fEldRicbC2ZIGruwcmjrNHMXRrkv4tAQshJ1xF5COjzBeeKi4UKNpncWlg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR2PR03MB5292
X-Proofpoint-GUID: 3c9aA9IStlOokxtOc4gbybqRWxQh1aU_
X-Proofpoint-ORIG-GUID: 3c9aA9IStlOokxtOc4gbybqRWxQh1aU_
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-08_03,2022-02-07_02,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015
 lowpriorityscore=0 phishscore=0 bulkscore=0 priorityscore=1501
 malwarescore=0 mlxlogscore=999 adultscore=0 impostorscore=0 spamscore=0
 mlxscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202080068

HSCIF is a high-speed variant of Renesas SCIF serial interface. From
Xen point of view, they almost the same, only difference is in FIFO
size.

Signed-off-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com>
Reviewed-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

---

V2:
 - Updated header of the file as per Oleksandr's suggestion
 - Added Oleksandr's R-b tag
---
 xen/drivers/char/scif-uart.c | 17 +++++++++++++++--
 1 file changed, 15 insertions(+), 2 deletions(-)

diff --git a/xen/drivers/char/scif-uart.c b/xen/drivers/char/scif-uart.c
index ee204a11a4..2fccafe340 100644
--- a/xen/drivers/char/scif-uart.c
+++ b/xen/drivers/char/scif-uart.c
@@ -1,8 +1,8 @@
 /*
  * xen/drivers/char/scif-uart.c
  *
- * Driver for SCIF(A) (Serial communication interface with FIFO (A))
- * compatible UART.
+ * Driver for (H)SCIF(A) ((High-speed) Serial communication interface
+ * with FIFO (A)) compatible UART.
  *
  * Oleksandr Tyshchenko <oleksandr.tyshchenko@globallogic.com>
  * Copyright (C) 2014, Globallogic.
@@ -47,6 +47,7 @@ enum port_types
 {
     SCIF_PORT,
     SCIFA_PORT,
+    HSCIF_PORT,
     NR_PORTS,
 };
=20
@@ -88,6 +89,17 @@ static const struct port_params port_params[NR_PORTS] =
=3D
                         SCASCR_BRIE,
         .fifo_size    =3D 64,
     },
+    [HSCIF_PORT] =3D
+    {
+        .status_reg   =3D SCIF_SCFSR,
+        .tx_fifo_reg  =3D SCIF_SCFTDR,
+        .rx_fifo_reg  =3D SCIF_SCFRDR,
+        .overrun_reg  =3D SCIF_SCLSR,
+        .overrun_mask =3D SCLSR_ORER,
+        .error_mask   =3D SCFSR_PER | SCFSR_FER | SCFSR_BRK | SCFSR_ER,
+        .irq_flags    =3D SCSCR_RIE | SCSCR_TIE | SCSCR_REIE,
+        .fifo_size    =3D 128,
+    },
 };
=20
 static void scif_uart_interrupt(int irq, void *data, struct cpu_user_regs =
*regs)
@@ -288,6 +300,7 @@ static const struct dt_device_match scif_uart_dt_match[=
] __initconst =3D
 {
     { .compatible =3D "renesas,scif",  .data =3D &port_params[SCIF_PORT] }=
,
     { .compatible =3D "renesas,scifa", .data =3D &port_params[SCIFA_PORT] =
},
+    { .compatible =3D "renesas,hscif", .data =3D &port_params[HSCIF_PORT] =
},
     { /* sentinel */ },
 };
=20
--=20
2.34.1


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 11:26:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 11:26:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268225.462016 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHOdG-0005D1-Jj; Tue, 08 Feb 2022 11:26:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268225.462016; Tue, 08 Feb 2022 11:26:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHOdG-0005Cu-GR; Tue, 08 Feb 2022 11:26:02 +0000
Received: by outflank-mailman (input) for mailman id 268225;
 Tue, 08 Feb 2022 11:26:01 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1FiY=SX=epam.com=prvs=40383cc40e=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nHOdE-0005Cm-Vn
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 11:26:01 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e33a86f2-88d1-11ec-8eb8-a37418f5ba1a;
 Tue, 08 Feb 2022 12:25:59 +0100 (CET)
Received: from pps.filterd (m0174676.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 218BJqLN004680;
 Tue, 8 Feb 2022 11:25:55 GMT
Received: from eur01-he1-obe.outbound.protection.outlook.com
 (mail-he1eur01lp2056.outbound.protection.outlook.com [104.47.0.56])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e3q5q84gd-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Tue, 08 Feb 2022 11:25:54 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by HE1PR0301MB2234.eurprd03.prod.outlook.com (2603:10a6:3:1e::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Tue, 8 Feb
 2022 11:25:50 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77%3]) with mapi id 15.20.4951.019; Tue, 8 Feb 2022
 11:25:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e33a86f2-88d1-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=bKl/cP20iAKiVm42A8xu0LXkK5fJvBWNheTSkdIFtqOcwIBvBH7rpJFuqQcyYOVoFh97NeaIMXK7wXlka0I5L1r0DLDQWfIaFYkGeNbZvzajSsmyKGgwQU0WsBSW9FYrcxMcvdgGSTKoKjKr4W0JoNWbLwnEuSyMxEBTLB7JLSj6D+cLKDA2u5J01UWer4PrfYtCF6Awy80g1/4oIX4TU6GEO0nY9bWtaoTEimnse51pWnok0sQSWpsoVgTdCV5kRXOVm7KeDeyqtFRkzHI35DgLJnTjYfYAeQw+hKGOy0UMwccDZSTmkL122tzCFs/mgbyzeK+PguYcbv2hGEkiiQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=hCMVOrFUQqXNUOyiXSwWQO5UeehFDIHcUOil6SjR4g0=;
 b=CGgJUK1C3nuh7V5sTLlMsIpenWt6m3GGV2Nj/7mQQIdhLEkPvS/LZNxwUo2LoeTZJa3AgtoxBnxouf24NCKuMwXhgnrLkjABhuEodm20xDbQsRo56E+ivfvp3cHLb1KqVRqMD1xW7X08Q4JMSuk4iSog6xc2dqsef1UHJ6ob8Y7AktRRpW3HnZ/jhfSpU8euSqnhXBbJs2vbPlK1mQrBoNCACJa7u6SOF/oVnXcZAtvfdzvLJhnYJs5j8rUMDa5DcRV+A1IlVgILdJjak2bvWTbPd2wioeeySr763IFkj6Zee8xgEExBmU2F/mURILN0wc+1wpgv/cNTfDEe9OwZCA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=hCMVOrFUQqXNUOyiXSwWQO5UeehFDIHcUOil6SjR4g0=;
 b=MJZ6MR67S4060AxhGNUZDeNeu0bXNB3ZUhm4Q37VnwOGQQ0o+gezV37Qg697kl9quIxSQHt8GpK1EjBlPcxK2SpYaHsqxZDiEEF8Wb/Q3bA0+dtVm/dsxSmSsu6GhBeiM2/h0uD1JGpELXQ9lCUjyrMcCl+7dBDSHa5di38xCkaYpuoPWaiOLRIxW+wBx6ERGe1XITYDRROxmEhWx3czQOic8WBHZXyxGC594y1rRT24Olhg08ta9b0LNlrR8M/9s6uu8GtUXq6KRi9E2rbMM8055X21HpoCs7fcboWjmWBITYr76U8PF3U0q9xwnZfagZ3r2YPPenXt97wPdeWJEA==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        "roger.pau@citrix.com"
	<roger.pau@citrix.com>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v6 05/13] vpci: add hooks for PCI device assign/de-assign
Thread-Topic: [PATCH v6 05/13] vpci: add hooks for PCI device assign/de-assign
Thread-Index: 
 AQHYGZFdYv4W1RdbQkeQtzN+PyKqmqyITGQAgAENNICAAAt2AIAAA+uAgAAEsACAAAMyAIAABAgAgAADmACAAAHqgIAABl2AgAACJ4CAAAczgA==
Date: Tue, 8 Feb 2022 11:25:50 +0000
Message-ID: <a0015951-6eff-38a8-a9f0-bdbc8bd51940@epam.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-6-andr2000@gmail.com>
 <16cea1df-3d0f-d404-2b88-aab47ad5548b@suse.com>
 <3fe6dbe3-51c6-f87f-23f9-cf2e1a924326@epam.com>
 <582ee8f9-7b01-4adc-6a8a-ce8b1dffd534@suse.com>
 <e225553b-b29c-0448-fb9f-f8b513d9f77d@epam.com>
 <0fd8a0ac-dc91-287e-536e-1684892837ab@suse.com>
 <9f58a8ff-44b4-3249-5858-9988644b2d4e@epam.com>
 <15c16171-f196-38d2-370c-38627935a21b@suse.com>
 <20762939-6b7e-ff60-7c1a-d47c4767ff4f@epam.com>
 <10cd89b5-a804-3354-26d8-bc271bd9c5e6@suse.com>
 <15022045-bc92-e3df-b005-aeec5e36a078@epam.com>
 <cf584e13-f257-9355-50fa-c35e8fc8cf5e@suse.com>
In-Reply-To: <cf584e13-f257-9355-50fa-c35e8fc8cf5e@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: d7f34a40-658d-443f-cddd-08d9eaf5c2b9
x-ms-traffictypediagnostic: HE1PR0301MB2234:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <HE1PR0301MB2234C067DE47F6AE9CAA28F3E72D9@HE1PR0301MB2234.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 GKoiuyhGmNUs7R4QghPyUakexakKx8I1YkEZJMhBOuK5nR6YrjVjZ6ov1/BIJM44wq3voP1WW1mfA8GHkoocT66ttyofXwIh6p+JGnMalHp1Wcdx5t8/SvWmB7uSgl2jRjOy9wmpBO9gxX5dl6LxBwLjZkR5my+ifVdV5/fquOe7803SBllKh4Y7gXxQtEtoW+2QVgtPvrq4mxyDDv+LYGWfXFarv2Pgz+BBvBDCx9i2pNSbPOgD6ul7zD0CR8Ckd+xZEzBtkBXcdtrA/++pFdT6A2mzUpZGyA+qv37AepCPvN8j1FVdlrZ1TNqfTdBL8bmg7Znt8r6mPf6opXaZKUFoKhIPZQtJBbuXlwB34VYfrHnRUbc/4cLlJuOANZ9EIBrSpcMagwvBbvdMbGX713REpaIprV80xDpEuci2t2pwQDsBCUzJNpLWH9JKYKcCsU3IL6DSKGTplIdc5c4F2c/XL8etaSXWbI3PjJ79AP8qGAq16v8cNd5ClayfsfArzos5zLSE9wuPJEv5vdK2Y1zuHgIYRBs/8gJ33bmqcDkNpDbmnWvJ066nJRRV1Eolhk3NYmGCfS6hu0kBd1b8oGPNk9VhEZ37g1+e+/sxHjF3szXzj7fi31/nVA3VEHCyA9MJMzzTZVhp6h/RR0YK/FV92IOORE2pPtGFFAsfZhxmGgo/pQEk6ZpcDbvv6rcH9K687PdUbtm6kRXRw+TBEmAjZmUZzkfcTKynL3rtoGFAnTxte5MKv4f3FOcPARcw
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6506007)(107886003)(2616005)(316002)(55236004)(2906002)(31696002)(36756003)(31686004)(122000001)(86362001)(38100700002)(53546011)(7416002)(64756008)(76116006)(6916009)(508600001)(5660300002)(6486002)(4326008)(66556008)(91956017)(66476007)(8936002)(186003)(26005)(38070700005)(83380400001)(71200400001)(66446008)(54906003)(6512007)(66946007)(8676002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?ejRENlhJUkhGSDFVaXNLR3A5YXFEVXlxTzUzc1gydm03NFhrU1EyNlF4UUVu?=
 =?utf-8?B?dDZ3TWRBUXordnFZb1RaWm1Ld2hKL3hDUWhyK1ZTMjQ3SmRTMis3d0N5amda?=
 =?utf-8?B?SnNpMzE5cVJ1Sk91dDdTWWNaL0N0RDZ5ZHV6c2hsQ24wVXpwWFdEOXRKKzNS?=
 =?utf-8?B?Rzc0Zm90WUt4UDkyaWtzdFdSRW5sT3VLZ2hPeFRqT2FJV0ZCVFJESXpBVUkz?=
 =?utf-8?B?Qk0rcjFVYktxM1pNdktSUHlXMERPRC9WTTdtUzZSdi83WmhtZlBjSk5FU0pH?=
 =?utf-8?B?OUk3NTBVT1hGU1RJQ0FZMDdUYyt2U3FHYld5OUowVDFQeHVhTThIZ2NzWVhT?=
 =?utf-8?B?WDF4NUVTakhUUGRuUXRQanZQVndNbnBOUElqdWpJL0EwbUtFN0dyM2lOT2dR?=
 =?utf-8?B?azZtYVErS3FNODNLVXdqbmxJU0U4c1RKV1BMcHFXZStvdEt2QXRGQnJuMkpq?=
 =?utf-8?B?dnZvUTlTNklyRGZqK1QweVZHWFBsOGhuSXRaYjFxVmlJQXJLSk1CdlVpZ3NB?=
 =?utf-8?B?Zk5xckJwSmlxQ2tTVEZjNEZTbmsvVUovaDFxWDEzK1NtSzZWaThMZlNoaHlr?=
 =?utf-8?B?QVhITit2VEJLMThLRWdtL01FV3Q1QUs4MDhJK2hqenZMZzdXVStBMk0wbWF1?=
 =?utf-8?B?a3ZlZG5wZnF0dFV2UjVDQmNMUjNHQ2JyT3g0UDRuajV5QzFscGlFMnZobkVB?=
 =?utf-8?B?NEdNc1RUYjhPVUQ4K0Q3RVlaVjU4ZTlTbEFHU09yODBPTVppaVlUUit1bXBn?=
 =?utf-8?B?aFFVbEgxZmhOSkhpZ2JsNTZESWV2elFqZEthT2VQMDVvNVpJRkpQRDJSRWVv?=
 =?utf-8?B?czhlU2k1NHhlSStRenNGMnc4NGM2c29oZi9EYVZkamhvNzExRWNaZi9tRm5E?=
 =?utf-8?B?RmFiVnFhTFlyMmtjdXFuKzlPL1lYQ2xVS1MxbWxBSzNiSldwLzNJVWorWHJo?=
 =?utf-8?B?TWN1c3VveDBHa0w4cTl6aGVWbnNmc3BNTDAwWFArS1BkN3RVZzBRRUhxY25h?=
 =?utf-8?B?UEd0dW04TEQ3VjFPbjBvTDhaOHo4c25LL2lRMDJ4RnZvNVUzTXBIeCtCeGU1?=
 =?utf-8?B?V3VFRE9nb2cxdS9CTXR2QkxQb0Y2RnNnT3JFMFA4eFJxTVpheXR6UnVCUVFN?=
 =?utf-8?B?TnViTG1vUHVPdWhCZHNuY3pqTlNGcU9sYmZBRUwxUEdaZGN4dmV3bnBYK0VT?=
 =?utf-8?B?dWlTWnpwV2NGc0VOSDk1QzBLd3lycUFUY3FVeHpMRDBwNXlBcHU3ZFVXQzhK?=
 =?utf-8?B?M2JFZzltU0JiR2l3SDRvNGM4ZFo5L2wrOUJkUnJpZFVJN0ZrNjlGazZWWWVP?=
 =?utf-8?B?ZU9MVFFsc1VUMS9NNWNFTE5nTGlJTnhYV0kxc0FjSzF0T21RREwwVm9lWEdu?=
 =?utf-8?B?OFF0UnV3SEZlZkNZdHlTTzc0emhHYW5DVDlWQUhwUjBiamxvWTd4L0JucnQ5?=
 =?utf-8?B?cDBtbE1ERzBnOE1JMHNxenFLNVY2aDFxdkNQc1VQdkJzNlhkb0pMLytkZ2tD?=
 =?utf-8?B?RlBYREw1RXBvc1VBL3g1QnRTYUlOckNuM244Z212aDhySHRkQWdzNHBSTnVL?=
 =?utf-8?B?U2h6cTV2TXFMeVVLNTJYTm1uL1FxNmtaRTZZMjEzLy9sUGlUQ1FuWGczSlN1?=
 =?utf-8?B?aTdxRlV0NWNocXkzWitKajBjYlhrcjhkb2loemxzSnZQbVlEb0NxSHdQRTRm?=
 =?utf-8?B?T0JwWDdrM3MwbXZRVW80RGJ3OWxXVWVkQnRXaEF0ZTdEby9JT0lIandjQmZo?=
 =?utf-8?B?NW5kQmZvNkp6NHBjdW5Mb1V3aHN0Q1Y4bFE2S0ttNnhGbHRDZ1RaS0UzL2RY?=
 =?utf-8?B?MVBqamoyQ1FnRkdtM01sZitqRHJBN1RzVndKUktLcVFMOTRvazdPUmtBbEFj?=
 =?utf-8?B?SWxubjh4bHhIV1pvbHZCYlJtM0k3SkloS3FUTWtNdE1sUGRPcDJRNmJMR3Vx?=
 =?utf-8?B?NkV0OHc0aWpLaVFVc09BRis1ZUlMOXZRaWsrSUFYU3ZleWhUUThMb3RDNnNs?=
 =?utf-8?B?WFpYcHZyN25NU2wrRHZDQzA5dndISERYazR0QjlUVW1FYTRUTFZIRkNXMnZG?=
 =?utf-8?B?U0J3SHExSXdtZWs4ajhNbkNuRzhWckRtUUkwZnJNSGVtc09IWm5VVGF4dWZp?=
 =?utf-8?B?Z0Q3T1BXK0Z5Rk8rV0gzVjZKTzBKOTMxZXI3SDRKa0xjYXN3RE1TVUNhYm5O?=
 =?utf-8?B?enJjNDE3Sm1OTmlnL1RocDJuUVdYcXQycER2azBlcWJoak8ydG5IbzFGa1Ux?=
 =?utf-8?B?ZlVJd1FCVlRCS0RzRXFWbWhPUGZIYi9lLy9VMVhsbDNkWktZZ0w3bmVqNVRY?=
 =?utf-8?B?S3JMeXo3R3BYOVFxaFVIaGQxVUo2Q0hOVTBBUk1MRmlkZlVuaVZMOTR0K1k3?=
 =?utf-8?Q?lwXcIKZDbQSIlw6k=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <E6F31CA4A0898F4B82AF6BE81840C596@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d7f34a40-658d-443f-cddd-08d9eaf5c2b9
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2022 11:25:50.3386
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: GMVqIFEmyF8cRFgTxrGOiAw6Rdf37JN/5WHznw7Mo7tiTRcWrYQXJ17KpzmWIYLZVzUYPcUeenBhrywklaS0Ya/TdwFAdT4Om5s091HXOUs1U172Ib3zHeibSGYM2lLD
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0301MB2234
X-Proofpoint-GUID: BXkYBc2v5-4zl6HnMx27BQSLjy3ZAeTG
X-Proofpoint-ORIG-GUID: BXkYBc2v5-4zl6HnMx27BQSLjy3ZAeTG
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-08_03,2022-02-07_02,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 clxscore=1015
 mlxscore=0 lowpriorityscore=0 suspectscore=0 phishscore=0 bulkscore=0
 priorityscore=1501 spamscore=0 mlxlogscore=999 adultscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2202080068

DQoNCk9uIDA4LjAyLjIyIDEzOjAwLCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMDguMDIuMjAy
MiAxMTo1MiwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+PiBUaGlzIHNtZWxscyBs
aWtlIHdlIGZpcnN0IG5lZWQgdG8gZml4IHRoZSBleGlzdGluZyBjb2RlLCBzbw0KPj4gcGRldi0+
ZG9tYWluIGlzIG5vdCBhc3NpZ25lZCBieSBzcGVjaWZpYyBJT01NVSBpbXBsZW1lbnRhdGlvbnMs
DQo+PiBidXQgaW5zdGVhZCBjb250cm9sbGVkIGJ5IHRoZSBjb2RlIHdoaWNoIHJlbGllcyBvbiB0
aGF0LCBhc3NpZ25fZGV2aWNlLg0KPiBGZWVsIGZyZWUgdG8gY29tZSB1cCB3aXRoIHByb3Bvc2Fs
cyBob3cgdG8gY2xlYW5seSBkbyBzby4gTW92aW5nIHRoZQ0KPiBhc3NpZ25tZW50IHRvIHBkZXYt
PmRvbWFpbiBtYXkgZXZlbiBiZSBwb3NzaWJsZSBub3csIGJ1dCBpZiB5b3UgZ28NCj4gYmFjayB5
b3UgbWF5IGZpbmQgdGhhdCB0aGUgY29kZSB3YXMgcXVpdGUgZGlmZmVyZW50IGVhcmxpZXIgb24u
DQpJIGRvIHVuZGVyc3RhbmQgdGhhdCBhcyB0aGUgY29kZSBldm9sdmVzIG5ldyB1c2UgY2FzZXMg
YnJpbmcNCm5ldyBpc3N1ZXMuDQo+DQo+PiBJIGNhbiBoYXZlIHNvbWV0aGluZyBsaWtlOg0KPj4N
Cj4+IGRpZmYgLS1naXQgYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9wY2kuYyBiL3hlbi9kcml2
ZXJzL3Bhc3N0aHJvdWdoL3BjaS5jDQo+PiBpbmRleCA4ODgzNmFhYjZiYWYuLmNjNzc5MDcwOWE1
MCAxMDA2NDQNCj4+IC0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3BjaS5jDQo+PiArKysg
Yi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9wY2kuYw0KPj4gQEAgLTE0NzUsNiArMTQ3NSw3IEBA
IHN0YXRpYyBpbnQgZGV2aWNlX2Fzc2lnbmVkKHUxNiBzZWcsIHU4IGJ1cywgdTggZGV2Zm4pDQo+
PiAgIMKgc3RhdGljIGludCBhc3NpZ25fZGV2aWNlKHN0cnVjdCBkb21haW4gKmQsIHUxNiBzZWcs
IHU4IGJ1cywgdTggZGV2Zm4sIHUzMiBmbGFnKQ0KPj4gICDCoHsNCj4+ICAgwqDCoMKgwqAgY29u
c3Qgc3RydWN0IGRvbWFpbl9pb21tdSAqaGQgPSBkb21faW9tbXUoZCk7DQo+PiArwqDCoMKgIHN0
cnVjdCBkb21haW4gKm9sZF9vd25lcjsNCj4+ICAgwqDCoMKgwqAgc3RydWN0IHBjaV9kZXYgKnBk
ZXY7DQo+PiAgIMKgwqDCoMKgIGludCByYyA9IDA7DQo+Pg0KPj4gQEAgLTE0OTAsNiArMTQ5MSw5
IEBAIHN0YXRpYyBpbnQgYXNzaWduX2RldmljZShzdHJ1Y3QgZG9tYWluICpkLCB1MTYgc2VnLCB1
OCBidXMsIHU4IGRldmZuLCB1MzIgZmxhZykNCj4+ICAgwqDCoMKgwqAgQVNTRVJUKHBkZXYgJiYg
KHBkZXYtPmRvbWFpbiA9PSBoYXJkd2FyZV9kb21haW4gfHwNCj4+ICAgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBwZGV2LT5kb21haW4gPT0gZG9tX2lvKSk7DQo+Pg0K
Pj4gK8KgwqDCoCAvKiBXZSBuZWVkIHRvIHJlc3RvcmUgdGhlIG9sZCBvd25lciBpbiBjYXNlIG9m
IGFuIGVycm9yLiAqLw0KPj4gK8KgwqDCoCBvbGRfb3duZXIgPSBwZGV2LT5kb21haW47DQo+PiAr
DQo+PiAgIMKgwqDCoMKgIHZwY2lfZGVhc3NpZ25fZGV2aWNlKHBkZXYtPmRvbWFpbiwgcGRldik7
DQo+Pg0KPj4gICDCoMKgwqDCoCByYyA9IHBkZXZfbXNpeF9hc3NpZ24oZCwgcGRldik7DQo+PiBA
QCAtMTUxNSw4ICsxNTE5LDEyIEBAIHN0YXRpYyBpbnQgYXNzaWduX2RldmljZShzdHJ1Y3QgZG9t
YWluICpkLCB1MTYgc2VnLCB1OCBidXMsIHU4IGRldmZuLCB1MzIgZmxhZykNCj4+DQo+PiAgIMKg
IGRvbmU6DQo+PiAgIMKgwqDCoMKgIGlmICggcmMgKQ0KPj4gK8KgwqDCoCB7DQo+PiAgIMKgwqDC
oMKgwqDCoMKgwqAgcHJpbnRrKFhFTkxPR19HX1dBUk5JTkcgIiVwZDogYXNzaWduICglcHApIGZh
aWxlZCAoJWQpXG4iLA0KPj4gICDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgZCwgJlBD
SV9TQkRGMyhzZWcsIGJ1cywgZGV2Zm4pLCByYyk7DQo+PiArwqDCoMKgwqDCoMKgwqAgLyogV2Ug
ZmFpbGVkIHRvIGFzc2lnbiwgc28gcmVzdG9yZSB0aGUgcHJldmlvdXMgb3duZXIuICovDQo+PiAr
wqDCoMKgwqDCoMKgwqAgcGRldi0+ZG9tYWluID0gb2xkX293bmVyOw0KPj4gK8KgwqDCoCB9DQo+
PiAgIMKgwqDCoMKgIC8qIFRoZSBkZXZpY2UgaXMgYXNzaWduZWQgdG8gZG9tX2lvIHNvIG1hcmsg
aXQgYXMgcXVhcmFudGluZWQgKi8NCj4+ICAgwqDCoMKgwqAgZWxzZSBpZiAoIGQgPT0gZG9tX2lv
ICkNCj4+ICAgwqDCoMKgwqDCoMKgwqDCoCBwZGV2LT5xdWFyYW50aW5lID0gdHJ1ZTsNCj4+DQo+
PiBCdXQgSSBkbyBub3QgdGhpbmsgdGhpcyBiZWxvbmdzIHRvIHRoaXMgcGF0Y2gNCj4gSW5kZWVk
LiBQbHVzIEknbSBzdXJlIHlvdSB1bmRlcnN0YW5kIHRoYXQgaXQncyBub3QgdGhhdCBzaW1wbGUu
IEFzc2lnbmluZw0KPiB0byBwZGV2LT5kb21haW4gaXMgb25seSB0aGUgbGFzdCBzdGVwIG9mIGFz
c2lnbm1lbnQuIFJlc3RvcmluZyB0aGUgb3JpZ2luYWwNCj4gb3duZXIgd291bGQgZW50YWlsIHB1
dHRpbmcgaW4gcGxhY2UgdGhlIG9yaWdpbmFsIElPTU1VIHRhYmxlIGVudHJpZXMgYXMNCj4gd2Vs
bCwgd2hpY2ggaW4gdHVybiBjYW4gZmFpbC4gSGVuY2Ugd2h5IHlvdSdsbCBmaW5kIGEgbnVtYmVy
IG9mIHVzZXMgb2YNCj4gZG9tYWluX2NyYXNoKCkgaW4gcGxhY2VzIHdoZXJlIHJvbGxpbmcgYmFj
ayBpcyBmYXIgZnJvbSBlYXN5Lg0KU28sIHdoeSBkb24ndCB3ZSBqdXN0IHJlbHkgb24gdGhlIHRv
b2xzdGFjayB0byBkbyB0aGUgcm9sbCBiYWNrIHRoZW4/DQpUaGlzIHdheSB3ZSB3b24ndCBhZGQg
bmV3IGRvbWFpbl9jcmFzaCgpIGNhbGxzLg0KSSBkbyB1bmRlcnN0YW5kIHRob3VnaCB0aGF0IHdl
IG1heSBsaXZlIFhlbiBpbiBhIHdyb25nIHN0YXRlIHRob3VnaC4NClNvLCBkbyB5b3UgdGhpbmsg
aXQgaXMgcG9zc2libGUgaWYgd2UganVzdCBjYWxsIGRlYXNzaWduX2RldmljZSBmcm9tDQphc3Np
Z25fZGV2aWNlIG9uIHRoZSBlcnJvciBwYXRoPyBUaGlzIGlzIGp1c3QgbGlrZSBJIGRvIGluIHZw
Y2lfYXNzaWduX2RldmljZToNCkkgY2FsbCB2cGNpX2RlYXNzaWduX2RldmljZSBpZiB0aGUgZm9y
bWVyIGZhaWxzLg0KPiBKYW4NCj4NClRoYW5rIHlvdSwNCk9sZWtzYW5kcg==


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 11:29:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 11:29:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268235.462028 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHOgv-0005t4-3j; Tue, 08 Feb 2022 11:29:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268235.462028; Tue, 08 Feb 2022 11:29:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHOgv-0005sx-0h; Tue, 08 Feb 2022 11:29:49 +0000
Received: by outflank-mailman (input) for mailman id 268235;
 Tue, 08 Feb 2022 11:29:47 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1FiY=SX=epam.com=prvs=40383cc40e=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nHOgt-0005sr-05
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 11:29:47 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6a0e9fab-88d2-11ec-8f75-fffcc8bd4f1a;
 Tue, 08 Feb 2022 12:29:45 +0100 (CET)
Received: from pps.filterd (m0174679.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 218BONSj020471;
 Tue, 8 Feb 2022 11:29:42 GMT
Received: from eur01-db5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2055.outbound.protection.outlook.com [104.47.2.55])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e3qkyg0n5-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Tue, 08 Feb 2022 11:29:42 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by VI1PR0301MB2222.eurprd03.prod.outlook.com (2603:10a6:800:27::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Tue, 8 Feb
 2022 11:29:07 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77%3]) with mapi id 15.20.4951.019; Tue, 8 Feb 2022
 11:29:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6a0e9fab-88d2-11ec-8f75-fffcc8bd4f1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=H2E/rEANJ7kUXGNEWzSPsNv8/bKjohbGbWqcHm3NY4hn5m5TQmzpKqM4anWZJN5US7celyB+mRRMOkhA4hHja/MDeq6VGcK2fMQvNR7JwIeOtcqfYWM+9beS1CHkQEAnF0joZAVqfWMO5acYvuMzSifoY+clkB7JTNh988LJDyScPsUshbR95325/j4eAlcC+kSJ2E7iaLQIk9I2250BpsGUTtJgR1FwH7Tmac6XNvHWkkYX49MwaGFBHrEZ2+bEc1fdKMcpqg7LkjtTDHzFuTr9+/Lmhj/8SCE+97+LwF5LrgqKommrIVFhRrbdXNxxlXombFyVVCCHjK2kzOnDVQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=wKh9PX+YySR0kcBGD/nKT8csk9cjqsi0iuqbh6UUB0A=;
 b=Cs6MGLpUonwSP+pG9dQeroBLSWG2BQmL/vooQuXcOKohciZr5nRN0GEsTugtbDLKuY4iCVNjPEVY4AwhQjASxUkXCF9FFqB5IQiCzgV71SXSjbrF128U6AWWF6z+rwTyvtZAGwTBq8xHl1IdhiIpCMXVigzgUV16Chs+VoXoMZb0bi3+dZ5dwXqK7KORbZJhggv02EnygbROu1dTTipIvudlgPiDhiQKq3NxdvPTYIpqKzY6/61QSAzw7+t1PFBZZE4sIq+rPfN/3zIvLcM1tam3M9zkvbEt3Mle5FfbO/4FV1nyKFTqCK7Rbog450aAW5SIMZU9c348dhLE6fdotg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=wKh9PX+YySR0kcBGD/nKT8csk9cjqsi0iuqbh6UUB0A=;
 b=TSBQbbsZ2KQSnMMZpRcy0GR31h6Rbmz55Tgw7bisV/dpWvsFU2EwWszTzX2EV9lkbkoUF7J+cT9shQqVdzEDgTJ1owsJDaV3Aeqrop8M+cOCaNW87A1zK2iOunJcFNKhk7zGcl0kzMR1CsEJT2YuXD740HkmEo0rmsEyJB7cRnqTl8ul71qaWrjJ+U7D/AfKtfjfKjZi1Kr9QdF0jZBRk3IgsLuyNT6a9AFMhMF6+AkLEIL6xVSV14vbxC2M/bODE9iuep5VyQhn8opbyj4rSlPdhkuYdpQpLi2G0oXcy1ndFtuguCeJBiCAk872CSkEHqwDLZw0wwyWe7tvrYfGig==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: Jan Beulich <jbeulich@suse.com>, "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org" <sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v6 09/13] vpci/header: emulate PCI_COMMAND register for
 guests
Thread-Topic: [PATCH v6 09/13] vpci/header: emulate PCI_COMMAND register for
 guests
Thread-Index: 
 AQHYGZFfEau2yoVfs02TXHZP7JM5E6yDcw0AgAXhW4CAABY4AIAAAW6AgAAD24CAAAHYgIAAFHwAgAAEyQA=
Date: Tue, 8 Feb 2022 11:29:07 +0000
Message-ID: <ec27927e-6c05-0e61-c0b8-c28bfd4d3d5e@epam.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-10-andr2000@gmail.com>
 <7df2379e-1c30-c362-3106-c7ef23af5c73@suse.com>
 <0ff2a524-9a65-861a-df87-cf3f682862d7@epam.com>
 <140e163c-87d0-2ae8-d57b-7ebc6757de9e@suse.com>
 <08d02313-349d-9ad4-926d-0d1419866363@epam.com>
 <186b7264-1190-3df2-415d-f1ec73a7c03f@suse.com>
 <ccaaa9b8-8ed9-054e-b724-70ca07401be9@epam.com>
 <YgJP/jMhWBrLOpb2@Air-de-Roger>
In-Reply-To: <YgJP/jMhWBrLOpb2@Air-de-Roger>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 02fc6f77-5abb-44c9-7152-08d9eaf63801
x-ms-traffictypediagnostic: VI1PR0301MB2222:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <VI1PR0301MB2222C6028734E7FA09E4CD77E72D9@VI1PR0301MB2222.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 h4RF+V0dHqKqLu0QsOScmq0vwk7z54nNX0yw7XM8sO2nPBD/11/SwaF8mip6wPL3ZBA1Jv4DX4ybis5lJ5vn6YdUBryDaHuuUvSMQdrmOje+1qpgrqr9VoZo+59ON5Rbc4ZJe6pFYNcgPC8i0NmLpKBFmx0RocG/xkbuC9/usex6PfRMi9GQYYwSlJvHOCGHO4RJwktJwi1M31+xu5FC6PQJHOCSqqldFl9jXuLchjVETPy5RgFnFSEGm75QSMgKkRbqfADUo0NSJISddaE87mHobg7At2Nvjicy3HFkNaGr01ZKd/DB7gqELW8RnBB1rL9mdh7pCNzg9Lpb2Ief/plkrqGJdG39xTKwZo3i4HACrFxXgNLmV85iDyMzLo9wIPPVU9J/WyynkFt4Syl/WPgbjx4yIegrL+UO7CHZjYgmuh5avCVo2fXymxXD+ol+L+QJPdwExDO/3vJP/1e9KmkEEcrww65Q6kOzvD6DcQDXzYfMEKx3g3H+W0y+GQVlSRGO4P2NHsu3fYdqkEUqCwwXQpv44rpffV3J02fYe7UI7lFv9lducOrxXjn9OiBHxXWI0fv/LpSTrANTtOOOMSnKoCzrfeShOCyDZzMCKDuOUpyrADJQYe8/yLfzQcuRl6JIuBqBS0Fz97SIj3otM+r+W93XvJSBUfbHvMFMMz+PeZGigFFuziqGACbydIUa1Wd4lyhzHQ75GgPc38Y65QHcgLahR6wfFaYIi8W/nGu8efbTG3geyfWOZsNnC2VX
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(2616005)(4326008)(8936002)(107886003)(91956017)(66556008)(83380400001)(66446008)(64756008)(66476007)(31686004)(36756003)(8676002)(508600001)(26005)(6486002)(66946007)(38070700005)(86362001)(53546011)(55236004)(31696002)(6512007)(5660300002)(122000001)(38100700002)(76116006)(6506007)(6916009)(186003)(54906003)(7416002)(71200400001)(2906002)(316002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?VlN2Rm9pZ1hSSHM0U29jQmd5YnVLdmpROE5LK3BXaDdYRUNnWTlNazEydXlx?=
 =?utf-8?B?ZEQ1K0l2RHJBQVhzdjNoR3Y5b0w0dXB2UnpkOWxlNG9xa3ZhL2sxZTU2RmVX?=
 =?utf-8?B?QUN3Yi9QMUJqZjdYQXorVi9iVjEvN25namNua09obWw2c25sVEgwRmd5ZHQr?=
 =?utf-8?B?WUtldVkrSE04THpaRWc1ZVdVcU1veG02eWZaMnBIZ1BZWW03OFBIR3J3TW8z?=
 =?utf-8?B?dEtxamtCY01QeU9vS2lORnE0WFJtd0pZN1lTSTFqQmdHNTBTVWJtaUhFNGRQ?=
 =?utf-8?B?NitQRnJnbVBRMDdQS2hEaGJjN2k3WndBUlVTMEhvVWFraC9ZSHB4UXFJeDF6?=
 =?utf-8?B?MkFlVkhlUmQzUW51UHRvM3hRMEk4TS9iL3BOU3BKYTVnbDR6MzhMUThnYXNt?=
 =?utf-8?B?blRjSlk3RnVOUEs1SHBMUDMxdlgrbFhJUkMwTElZTlNVdjZveTNFS2RKdTFk?=
 =?utf-8?B?RDNtVlZJZWozTXo3WTJ4VXc1V1NhVFR5dU14RVdlY3haTlJBUDRDaksrbFkx?=
 =?utf-8?B?NkJSTDdrQkkySlNkNnRNKzdINHcwOFNIRE5LWGs4Z2pld3FScEZwZ2hjbHlW?=
 =?utf-8?B?L0RrSmVnYXNCSlUrbTlOQVlPRGdZTXZoeE9oM3NxRG9wRFc4cVhIU1ZVdGtp?=
 =?utf-8?B?UDI2MWRlbEtWTGI5MEF1SHpjVDJCU0xCZm41NUdQSVZmVFdHaWtsYXdTek9U?=
 =?utf-8?B?NXJuZmN1RnNHd3F3TnlEcWJOc2NZbHlZdFp5QTlkeGRJcUQzL0RUZmNSUmZO?=
 =?utf-8?B?aHMwcmZyK0FwclZRVTg0Y1VzWlduQ1hQZHpzSVpra2RIRDNLTzVJRFo0RjlQ?=
 =?utf-8?B?NHI5S0IrV1VvdmFXOGxwV1FFUkM1Sm56RGxwa0RqQzNEbVRncmtRK0gwWkNY?=
 =?utf-8?B?VzRwSk9vdncwZDBCcEIzMEFjdzhWdUVGSVhtRzBBdW5sbjFmZFQ5cmtBZlY2?=
 =?utf-8?B?VEtwRWJ2bGdVUVRCUmZTemE1YUFVeHJid0VWbnFpQlV5QmEwV3VpM05JRjBT?=
 =?utf-8?B?L1Q3MXNYaUE5US9OQ1dJK3NKc2Fuc3ZqWlZGTVlIM0l5TFc5RGl5UTNNK2tw?=
 =?utf-8?B?eTRSNHNaUWNIdFI3UlpZNU03NjRIYTFqT1R4eFBZRm9BdUFySkpRRFVmeHB1?=
 =?utf-8?B?SjV5SDlhbXRLMzBIV2FadTMzTEFGditxVEpCNmxwRUMvaHpKM0c1Q1RXVTBH?=
 =?utf-8?B?d21CVEMycVZJSHJkRDk0b2Q3alJCK2NvRkpENUpucmVUWlZsVHl3dlpnTVNX?=
 =?utf-8?B?eFJYMCt5YWtmS0g4VkVMWXBFNXVsVWE0QjFqT0RBTmxRcWFvaVduSU95Y0VK?=
 =?utf-8?B?RHVXbHB2M09UdkFRVHhpZDk5czVsOTQyTUYrRGl0cC92ZXVSM0YrQXk4UnIx?=
 =?utf-8?B?ZDl6Y1VUV0FzTmo2UCtHeElEWktpd3FTekFXMVd2K3VhYStBb2VZVEJRVmty?=
 =?utf-8?B?ZEFaQzNFdzIrc25tQ3MxcCtCNFZYMkNMSG0xU09pZnNoMVFKd0VULytnQ0ZB?=
 =?utf-8?B?NTVPajUveU4xRDNhQkdiTEhiN0pSMkZONklOQ2IzRUlLWFQxdnhQSXFTblRo?=
 =?utf-8?B?VjNlaU9rK2phYVlIRkxCVWRkMUFJeStFVzU1dFo2eVdDV1ovcjNlTm9DM0dz?=
 =?utf-8?B?MitZS2hrK0ZIL05IRzhLeUhOSWNhbXk5RmtLOWxwTU1YUC9CTUhQRGw5TnV2?=
 =?utf-8?B?a3dqcGlpUFBneklTL2RtY3hlRURzVHg1NE1RUzBhc3lUV0hKdTN3Z0g3ZDBz?=
 =?utf-8?B?NDI0RTFCaENSZFRPMDY3QTg5SkYxZXg1SEo0NllGWjRYSDNFNkt4VndJaHZn?=
 =?utf-8?B?akhXQlgrZE5VaFk5ckV6K3dQNzY0K0VuOEZHVEFXdUtRa2Y4cjFMNjB5ZVRt?=
 =?utf-8?B?RFhEV3NNT3ZCRVJieVV6QklLbXdBbndMQkZ5VnVld3BQbEs2YnV0Z3NKeGFx?=
 =?utf-8?B?VVlKakxyK2xTNVFzbW9nWW1ZOGhsd2FsZ2VyZDREclVFTytlTTVBay95WXpP?=
 =?utf-8?B?VVk4b3BlRnBWV2hqTEVHNEVONFNXZ2duT3p1Z0Z0a29NZVo5eFNvSDdRM0pW?=
 =?utf-8?B?T0tHZTY1K0RhUFp2czVrRGhQQTN4TDJhbGdkN1lZbDVQZkdzUGdpNGJ4R29M?=
 =?utf-8?B?aTZuNi85NktTMmtRTXlJbytlck5kMWc4UTNaU2FKY1I0RitNd0JOeHkzQW5D?=
 =?utf-8?B?bkpKbGxjUDY1eUE4VzVXU3BQWUFaNzhhOGkwL0pDRjE2clQ2NHh5bTllU3h6?=
 =?utf-8?B?OEErUWdYUjZnRUhiWTJ4QXkyYitXdXEzc1l1NXp6U2tOQ25GSHZVYWdlMlZG?=
 =?utf-8?B?djRxOCtkM1VJM01sdkZ3Z1lrajlEdVVZVCtrVXpEbHBTWmhrb3I3eDgzQWpQ?=
 =?utf-8?Q?kuu9S3O9vT1WFww0=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <A9BF365DC23D7240BE54072F284CD13D@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 02fc6f77-5abb-44c9-7152-08d9eaf63801
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2022 11:29:07.0859
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: q8eWy46Chxc9XFweLVDEKiyierrK+K+/jvNUxi3xOyY/cSZAt4n3WzAoHfgYjRnZILpskiNxegp6fmZxHJy92zA4S5P0xnfKX6duAZ6QZv51sa3kVDsjcL100sju0dxm
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0301MB2222
X-Proofpoint-GUID: Xm5lDoUcKfQaylzmGXnNgfdd19KWLBH0
X-Proofpoint-ORIG-GUID: Xm5lDoUcKfQaylzmGXnNgfdd19KWLBH0
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-08_03,2022-02-07_02,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 mlxscore=0
 malwarescore=0 spamscore=0 adultscore=0 mlxlogscore=872 clxscore=1015
 lowpriorityscore=0 phishscore=0 impostorscore=0 bulkscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2202080069

DQoNCk9uIDA4LjAyLjIyIDEzOjExLCBSb2dlciBQYXUgTW9ubsOpIHdyb3RlOg0KPiBPbiBUdWUs
IEZlYiAwOCwgMjAyMiBhdCAwOTo1ODo0MEFNICswMDAwLCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5r
byB3cm90ZToNCj4+DQo+PiBPbiAwOC4wMi4yMiAxMTo1MiwgSmFuIEJldWxpY2ggd3JvdGU6DQo+
Pj4gT24gMDguMDIuMjAyMiAxMDozOCwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+
Pj4+IE9uIDA4LjAyLjIyIDExOjMzLCBKYW4gQmV1bGljaCB3cm90ZToNCj4+Pj4+IE9uIDA4LjAy
LjIwMjIgMDk6MTMsIE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4+Pj4+IE9uIDA0
LjAyLjIyIDE2OjI1LCBKYW4gQmV1bGljaCB3cm90ZToNCj4+Pj4+Pj4gT24gMDQuMDIuMjAyMiAw
NzozNCwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+Pj4+Pj4+PiAtLS0gYS94ZW4v
ZHJpdmVycy92cGNpL2hlYWRlci5jDQo+Pj4+Pj4+PiArKysgYi94ZW4vZHJpdmVycy92cGNpL2hl
YWRlci5jDQo+Pj4+Pj4+PiBAQCAtNDU0LDYgKzQ1NCwyMiBAQCBzdGF0aWMgdm9pZCBjbWRfd3Jp
dGUoY29uc3Qgc3RydWN0IHBjaV9kZXYgKnBkZXYsIHVuc2lnbmVkIGludCByZWcsDQo+Pj4+Pj4+
PiAgICAgICAgICAgICAgcGNpX2NvbmZfd3JpdGUxNihwZGV2LT5zYmRmLCByZWcsIGNtZCk7DQo+
Pj4+Pj4+PiAgICAgIH0NCj4+Pj4+Pj4+ICAgICAgDQo+Pj4+Pj4+PiArc3RhdGljIHZvaWQgZ3Vl
c3RfY21kX3dyaXRlKGNvbnN0IHN0cnVjdCBwY2lfZGV2ICpwZGV2LCB1bnNpZ25lZCBpbnQgcmVn
LA0KPj4+Pj4+Pj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICB1aW50MzJfdCBjbWQsIHZv
aWQgKmRhdGEpDQo+Pj4+Pj4+PiArew0KPj4+Pj4+Pj4gKyAgICAvKiBUT0RPOiBBZGQgcHJvcGVy
IGVtdWxhdGlvbiBmb3IgYWxsIGJpdHMgb2YgdGhlIGNvbW1hbmQgcmVnaXN0ZXIuICovDQo+Pj4+
Pj4+PiArDQo+Pj4+Pj4+PiArI2lmZGVmIENPTkZJR19IQVNfUENJX01TSQ0KPj4+Pj4+Pj4gKyAg
ICBpZiAoIHBkZXYtPnZwY2ktPm1zaS0+ZW5hYmxlZCB8fCBwZGV2LT52cGNpLT5tc2l4LT5lbmFi
bGVkICkNCj4+Pj4+Pj4+ICsgICAgew0KPj4+Pj4+Pj4gKyAgICAgICAgLyogR3Vlc3Qgd2FudHMg
dG8gZW5hYmxlIElOVHguIEl0IGNhbid0IGJlIGVuYWJsZWQgaWYgTVNJL01TSS1YIGVuYWJsZWQu
ICovDQo+Pj4+Pj4+PiArICAgICAgICBjbWQgfD0gUENJX0NPTU1BTkRfSU5UWF9ESVNBQkxFOw0K
Pj4+Pj4+Pj4gKyAgICB9DQo+Pj4+Pj4+PiArI2VuZGlmDQo+Pj4+Pj4+PiArDQo+Pj4+Pj4+PiAr
ICAgIGNtZF93cml0ZShwZGV2LCByZWcsIGNtZCwgZGF0YSk7DQo+Pj4+Pj4+PiArfQ0KPj4+Pj4+
PiBJdCdzIG5vdCByZWFsbHkgY2xlYXIgdG8gbWUgd2hldGhlciB0aGUgVE9ETyB3YXJyYW50cyB0
aGlzIGJlaW5nIGENCj4+Pj4+Pj4gc2VwYXJhdGUgZnVuY3Rpb24uIFBlcnNvbmFsbHkgSSdkIGZp
bmQgaXQgcHJlZmVyYWJsZSBpZiB0aGUgbG9naWMNCj4+Pj4+Pj4gd2FzIGZvbGRlZCBpbnRvIGNt
ZF93cml0ZSgpLg0KPj4+Pj4+IE5vdCBzdXJlIGNtZF93cml0ZSBuZWVkcyB0byBoYXZlIGd1ZXN0
J3MgbG9naWMuIEFuZCB3aGF0J3MgdGhlDQo+Pj4+Pj4gcHJvZml0PyBMYXRlciBvbiwgd2hlbiB3
ZSBkZWNpZGUgaG93IFBDSV9DT01NQU5EIGNhbiBiZSBlbXVsYXRlZA0KPj4+Pj4+IHRoaXMgY29k
ZSB3aWxsIGxpdmUgaW4gZ3Vlc3RfY21kX3dyaXRlIGFueXdheXMNCj4+Pj4+IFdoeSAid2lsbCI/
IFRoZXJlJ3Mgbm90aGluZyBjb25jZXB0dWFsbHkgd3Jvbmcgd2l0aCBwdXR0aW5nIGFsbCB0aGUN
Cj4+Pj4+IGVtdWxhdGlvbiBsb2dpYyBpbnRvIGNtZF93cml0ZSgpLCBpbnNpZGUgYW4gaWYoIWh3
ZG9tKSBjb25kaXRpb25hbC4NCj4+Pj4+IElmIGFuZCB3aGVuIHdlIGdhaW4gQ0VULUlCVCBzdXBw
b3J0IG9uIHRoZSB4ODYgc2lkZSAoYW5kIEknbSB0b2xkDQo+Pj4+PiB0aGVyZSdzIGFuIEFybSBl
cXVpdmFsZW50IG9mIHRoaXMpLCB0aGVuIHRvIG1ha2UgdGhpcyBhcyB1c2VmdWwgYXMNCj4+Pj4+
IHBvc3NpYmxlIGl0IGlzIGdvaW5nIHRvIGJlIGRlc2lyYWJsZSB0byBsaW1pdCB0aGUgbnVtYmVy
IG9mIGZ1bmN0aW9ucw0KPj4+Pj4gY2FsbGVkIHRocm91Z2ggZnVuY3Rpb24gcG9pbnRlcnMuIFlv
dSBtYXkgaGF2ZSBzZWVuIEFuZHJldydzIGh1Z2UNCj4+Pj4+ICJ4ODY6IFN1cHBvcnQgZm9yIENF
VCBJbmRpcmVjdCBCcmFuY2ggVHJhY2tpbmciIHNlcmllcy4gV2Ugd2FudCB0bw0KPj4+Pj4ga2Vl
cCBkb3duIHRoZSBudW1iZXIgb2Ygc3VjaCBhbm5vdGF0aW9uczsgdGhlIHZhc3QgcGFydCBvZiB0
aGUgc2VyaWVzDQo+Pj4+PiBpcyBhYm91dCBhZGRpbmcgb2Ygc3VjaC4NCj4+Pj4gV2VsbCwgd2hp
bGUgSSBzZWUgbm90aGluZyBiYWQgd2l0aCB0aGF0LCBmcm9tIHRoZSBjb2RlIG9yZ2FuaXphdGlv
bg0KPj4+PiBpdCB3b3VsZCBsb29rIGEgYml0IHN0cmFuZ2U6IHdlIGRvbid0IGRpZmZlcmVudGlh
dGUgaHdkb20gaW4gdnBjaQ0KPj4+PiBoYW5kbGVycywgYnV0IGluc3RlYWQgcHJvdmlkZSBvbmUg
Zm9yIGh3ZG9tIGFuZCBvbmUgZm9yIGd1ZXN0cy4NCj4+Pj4gV2hpbGUgSSB1bmRlcnN0YW5kIHlv
dXIgY29uY2VybiBJIHN0aWxsIHRoaW5rIHRoYXQgYXQgdGhlIG1vbWVudA0KPj4+PiBpdCB3aWxs
IGJlIG1vcmUgaW4gbGluZSB3aXRoIHRoZSBleGlzdGluZyBjb2RlIGlmIHdlIHByb3ZpZGUgYSBk
ZWRpY2F0ZWQNCj4+Pj4gaGFuZGxlci4NCj4+PiBUaGUgZXhpc3RpbmcgY29kZSBvbmx5IGRlYWxz
IHdpdGggRG9tMCwgYW5kIGhlbmNlIGRvZXNuJ3QgaGF2ZSBhbnkNCj4+PiBwYWlycyBvZiBoYW5k
bGVycy4NCj4+IFRoaXMgaXMgZmFpcg0KPj4+ICAgIEZUQU9EIHdoYXQgSSBzYWlkIGFib3ZlIGFw
cGxpZXMgZXF1YWxseSB0byBvdGhlcg0KPj4+IHNlcGFyYXRlIGd1ZXN0IHJlYWQvd3JpdGUgaGFu
ZGxlcnMgeW91IG1heSBiZSBpbnRyb2R1Y2luZy4gVGhlDQo+Pj4gZXhjZXB0aW9uIGJlaW5nIHdo
ZW4gZS5nLiBhIGhhcmR3YXJlIGFjY2VzcyBoYW5kbGVyIGlzIHB1dCBpbiBwbGFjZQ0KPj4+IGZv
ciBEb20wIChmb3Igb2J2aW91cyByZWFzb25zLCBJIHRoaW5rKS4NCj4+IEBSb2dlciwgd2hhdCdz
IHlvdXIgcHJlZmVyZW5jZSBoZXJlPw0KPiBUaGUgbmV3bHkgaW50cm9kdWNlZCBoYW5kbGVyIGVu
ZHMgdXAgY2FsbGluZyB0aGUgZXhpc3Rpbmcgb25lLA0KQnV0IGJlZm9yZSBkb2luZyBzbyBpdCBp
bXBsZW1lbnRzIGd1ZXN0IHNwZWNpZmljIGxvZ2ljIHdoaWNoIHdpbGwgYmUNCmV4dGVuZGVkIGFz
IHdlIGFkZCBtb3JlIGJpdHMgb2YgZW11bGF0aW9uDQo+ICAgc28gaW4NCj4gdGhpcyBjYXNlIGl0
IG1pZ2h0IG1ha2Ugc2Vuc2UgdG8gZXhwYW5kIGNtZF93cml0ZSB0byBhbHNvIGNhdGVyIGZvcg0K
PiB0aGUgZG9tVSBjYXNlPw0KU28sIGZyb20gdGhlIGFib3ZlIEkgdGhvdWdodCBpcyB3YXMgb2sg
dG8gaGF2ZSBhIGRlZGljYXRlZCBoYW5kbGVyDQo+DQo+IEkgdGhpbmsgd2UgbmVlZCB0byBiZSBz
ZW5zaWJsZSBoZXJlIGluIHRoYXQgd2UgZG9uJ3Qgd2FudCB0byBlbmQgdXANCj4gd2l0aCBoYW5k
bGVycyBsaWtlOg0KPg0KPiByZWdpc3Rlcl9yZWFkKC4uLikNCj4gew0KPiAgICAgaWYgKCBpc19o
YXJkd2FyZV9kb21haW4oKSApDQo+ICAgICAgICAgLi4uLg0KPiAgICAgZWxzZQ0KPiAgICAgICAg
IC4uLg0KPiB9DQo+DQo+IElmIHRoZXJlJ3Mgc2hhcmVkIGNvZGUgaXQncyBJTU8gYmV0dGVyIHRv
IG5vdCBjcmVhdGUgYXMgZ3Vlc3Qgc3BlY2lmaWMNCj4gaGFuZGxlci4NCj4NCj4gSXQncyBhbHNv
IG1vcmUgcmlza3kgdG8gdXNlIHRoZSBzYW1lIGhhbmRsZXJzIGZvciBkb20wIGFuZCBkb21VLCBh
cyBhDQo+IGNoYW5nZSBpbnRlbmRlZCB0byBkb20wIG9ubHkgbWlnaHQgZW5kIHVwIGxlYWtpbmcg
aW4gdGhlIGRvbVUgcGF0aCBhbmQNCj4gdGhhdCBjb3VsZCBlYXNpbHkgYmVjb21lIGEgc2VjdXJp
dHkgaXNzdWUuDQpTbywganVzdCBmb3IgeW91ciBqdXN0aWZpY2F0aW9uOiBCQVJzLiBJcyB0aGlz
IHNvbWV0aGluZyB3ZSBhbHNvIHdhbnQNCnRvIGJlIGtlcHQgc2VwYXJhdGUgb3Igd2Ugd2FudCBp
ZiAoaXNfaHdkb20pPw0KSSBndWVzcyB0aGUgZm9ybWVyLg0KPg0KPiBUaGFua3MsIFJvZ2VyLg0K
VGhhbmsgeW91LA0KT2xla3NhbmRy


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 11:37:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 11:37:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268246.462039 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHOo6-0007Ny-0H; Tue, 08 Feb 2022 11:37:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268246.462039; Tue, 08 Feb 2022 11:37:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHOo5-0007Nr-TB; Tue, 08 Feb 2022 11:37:13 +0000
Received: by outflank-mailman (input) for mailman id 268246;
 Tue, 08 Feb 2022 11:37:13 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/0PE=SX=xilinx.com=ayankuma@srs-se1.protection.inumbo.net>)
 id 1nHOo5-0007Nl-EB
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 11:37:13 +0000
Received: from NAM02-SN1-obe.outbound.protection.outlook.com
 (mail-sn1anam02on2062b.outbound.protection.outlook.com
 [2a01:111:f400:7ea9::62b])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 73a7a1f9-88d3-11ec-8eb8-a37418f5ba1a;
 Tue, 08 Feb 2022 12:37:11 +0100 (CET)
Received: from SN6PR08CA0024.namprd08.prod.outlook.com (2603:10b6:805:66::37)
 by BN7PR02MB5218.namprd02.prod.outlook.com (2603:10b6:408:26::30)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Tue, 8 Feb
 2022 11:37:06 +0000
Received: from SN1NAM02FT0017.eop-nam02.prod.protection.outlook.com
 (2603:10b6:805:66:cafe::85) by SN6PR08CA0024.outlook.office365.com
 (2603:10b6:805:66::37) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12 via Frontend
 Transport; Tue, 8 Feb 2022 11:37:05 +0000
Received: from xir-pvapexch02.xlnx.xilinx.com (149.199.80.198) by
 SN1NAM02FT0017.mail.protection.outlook.com (10.97.4.104) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.4951.12 via Frontend Transport; Tue, 8 Feb 2022 11:37:05 +0000
Received: from xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) by
 xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2176.14; Tue, 8 Feb 2022 11:37:04 +0000
Received: from smtp.xilinx.com (172.21.105.197) by
 xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server id
 15.1.2176.14 via Frontend Transport; Tue, 8 Feb 2022 11:37:04 +0000
Received: from [10.71.117.110] (port=30724)
 by smtp.xilinx.com with esmtp (Exim 4.90)
 (envelope-from <ayan.kumar.halder@xilinx.com>)
 id 1nHOnv-0003Cs-7a; Tue, 08 Feb 2022 11:37:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 73a7a1f9-88d3-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XMlzwOk5Io8GUR2VhKIgGi+lPtJMICgQa/Q51xyE/PGiKKEk0CLj5fffvP/N5Ool/sWuqBLSSlXVqtwyohO8j1d/dhqpUC2iPXWQHzs6csN58aHv+3b2eCPlYZeReD+VkETDylAQ0z47nMj8Ia3PJQ4/AXXqi9ICMmAL09Fnze8NM7Xv7hs8lwvmzgHApbTqOy8NrDD9gUDqNsdn4HD6ZKsqnC1ZTPMT0+6O0Gk+mraNf9s6jKsMbWMpnXpbRubXU5kPGaagrM1WYQvIndXL7ZpVwwuf3vOExcRRK06EGdknqBXHrCci/hDH3VIHOxvUQtcD9M6R7Dv6i7uNip43mA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=7T5poAt1Fb2IYZkIgWRYu2olNZzpKQrUJnN4vwfPcIA=;
 b=ZWg85MfV6/g5+8AKvUcvsSR3FA70csuOqxjYPwsX5Q6vmCKMCrETKmvpb7ELiNQrp1R7ECWroqs33V7hJcQ3RZSJTDhicKeP4lj/RFDWIJtK06cDJ/0AkaDqglbXDpjXVSGNGedujBknvLCE4+5++NQ8o94zjx8SvUBh/whscOj8syEjS4Lb/Ics1nwmi0S+zXEZbv6gUAHZ5DRu+m8zXs9JZmDhzkGsM9LHuGV6J/G5YXy2QGkUN8TspqH8yic2iLr5wfO1YU/Eg5BySAyvuuadYns0iU6pD6dmwqtOUZL4pPownhiGJfE3RdZrfFFIOwAQcKLGjD8XkkRwdmdNSw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 149.199.80.198) smtp.rcpttodomain=lists.xenproject.org
 smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none
 header.from=xilinx.com; dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=7T5poAt1Fb2IYZkIgWRYu2olNZzpKQrUJnN4vwfPcIA=;
 b=URTgit3EaFSJQYLfJ5X/OCO55cYW8dt35FeGDQBxlD3E5mHVJg93JF5MkrGgTTFECszuQDr2VPH+FFYckRE5gz6esYeWrp5maCpbPOdfPf8DBH0BBNs/vGq8Ov+Xq7xyz0u4eSOgPpBGeRa8tVcwKqmqWOkC/lUcvPRZp9ETeiw=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198)
 smtp.mailfrom=xilinx.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=xilinx.com;
Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates
 149.199.80.198 as permitted sender) receiver=protection.outlook.com;
 client-ip=149.199.80.198; helo=xir-pvapexch02.xlnx.xilinx.com;
Message-ID: <b3d559c0-15cf-4aff-0cf3-ec575716dc50@xilinx.com>
Date: Tue, 8 Feb 2022 11:37:02 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.1
Subject: Re: [XEN v7 2/2] xen/arm64: io: Support instructions (for which ISS
 is not valid) on emulated MMIO region using MMIO/ioreq handler
To: Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>,
	<xen-devel@lists.xenproject.org>, <julien@xen.org>, <stefanos@xilinx.com>,
	<sstabellini@kernel.org>
CC: <Volodymyr_Babchuk@epam.com>, <bertrand.marquis@arm.com>
References: <20220205225816.5952-1-ayankuma@xilinx.com>
 <20220205225816.5952-3-ayankuma@xilinx.com>
From: Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>
In-Reply-To: <20220205225816.5952-3-ayankuma@xilinx.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7a29b60a-4c7d-4aaa-9e92-08d9eaf75529
X-MS-TrafficTypeDiagnostic: BN7PR02MB5218:EE_
X-Microsoft-Antispam-PRVS:
	<BN7PR02MB5218C2D1A4AF38F3A6D4470AB22D9@BN7PR02MB5218.namprd02.prod.outlook.com>
X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	wcq9urXa0Z1KAb+nyBMUO9Qq3JNYJxZ3e7pZA6m8KCT4wHvo8XHkdjRpW2Bcds9VShXEgHCj0XWM7yDfcyL08IcDolRM4kaMayQ0Uz9b0EwvwejXfOTDAeTudvklacXFhmAnAGiM5+0xTvXpIICEhPeIaB4ukhit8jPzaX2a199gqxX7ZCA3P/OzoRJX/6HSGLmbMcjh+20shmmsk4/hAJbZkM3DYTTPnN84uA/Drtquxo1C8cQV8jFpG5KHV853U09xmQJBEpM8OSud20eRO0Py8HIkbWVKYAa88DL5jMnOjACjjYRQdWlkNWX6QPL/1iFSeNySQnYfQ1xK4fOQNmROpJea00P+8+h1/fUiLzTTlKje7wRRarJejF2Q83MkJj9juCpIxH0d1Qdt71dZ4Ivfc2PZxU0X7tq73H1Q7qh83RaaOQtLjquW2gTkg8cshrR0FHdjn47Amv5L5+bzNJGybmBnHeV3JLpYX4FfljyhoyYSB8VZ3vYPm2CLYz53032gGbXISf2BqS4vUO/8tWTLZQgsqFwbiCI88muxXrjkzSi/J5+ujIAcKya8wD7aZd5iskAxViK2t/AoliK/xLpZ+e7PjjgWmMUa7gAOZmV3VzyZStgBiP+L865VHiDhS7gIFu6DcLi/HygNRaHcblSSH4qhmxqh8k3nb17TETRUQtCTxFwHUM4SUbh4uM+i95seXCFx5bP4/tPx7lPyu9gTPK45t9O8buJl3QGX8F8=
X-Forefront-Antispam-Report:
	CIP:149.199.80.198;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:xir-pvapexch02.xlnx.xilinx.com;PTR:unknown-80-198.xilinx.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(186003)(47076005)(336012)(316002)(53546011)(9786002)(36860700001)(54906003)(426003)(2906002)(82310400004)(31696002)(83380400001)(26005)(2616005)(31686004)(5660300002)(356005)(70206006)(70586007)(110136005)(4326008)(8936002)(508600001)(8676002)(36756003)(7636003)(50156003)(2101003)(43740500002);DIR:OUT;SFP:1101;
X-OriginatorOrg: xilinx.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2022 11:37:05.3592
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 7a29b60a-4c7d-4aaa-9e92-08d9eaf75529
X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.80.198];Helo=[xir-pvapexch02.xlnx.xilinx.com]
X-MS-Exchange-CrossTenant-AuthSource:
	SN1NAM02FT0017.eop-nam02.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR02MB5218

Hi All,

I had a discussion with Julien on IRC and this patch need a correction 
(based on my understanding):-

On 05/02/2022 22:58, Ayan Kumar Halder wrote:
> If the instruction was related to cache maintenance, Xen
> will not decode the instruction or do any MMIO operation. Rather it simply
> increments the PC and returns to the guest.

This is not entirely correct :-

If the instruction is cache maintenance and the address is emulated, 
then Xen needs to ignore the ignore the instruction ie increment the PC 
and return to the guest.

However, if the address is not emulated, then Xen will get invoked only 
if the translation table entry corresponding to the address is set 
invalid. In this case, Xen will need to iterate through the translation 
tables and mark the entry as valid and return to the guest to retry the 
instruction.

As of today, we do not handle cache condition (ie dabt.cache == 1) in 
Xen. Thus, I will drop this logic in my patch and will resend the 
current series (unless there are any objections).

I will send out a separate patch to handle the cache condition.

> If the instruction was trapped due
> to stage1 page translation table walk, Xen will update the page tables and will
> return to the guest so that it can retry the instruction. To handle all these
> different states, we have introduced 'enum instr_decode_state'.
>
> Signed-off-by: Ayan Kumar Halder <ayankuma@xilinx.com>
> ---
<snip>
> diff --git a/xen/arch/arm/include/asm/mmio.h b/xen/arch/arm/include/asm/mmio.h
> index 3354d9c635..fb7ff72cdc 100644
> --- a/xen/arch/arm/include/asm/mmio.h
> +++ b/xen/arch/arm/include/asm/mmio.h
> @@ -26,12 +26,23 @@
>   
>   #define MAX_IO_HANDLER  16
>   
> +enum instr_decode_state
> +{
> +    INSTR_ERROR,                    /* Error encountered while decoding instr */
> +    INSTR_VALID,                    /* ISS is valid, so no need to decode */
> +    INSTR_LDR_STR_POSTINDEXING,     /* Instruction is decoded successfully.
> +                                       It is ldr/str post indexing */
> +    INSTR_IGNORE,                   /* Instruction is to be ignored (ie NOP) */
Drop this entry.
> +    INSTR_RETRY                     /* Instruction is to be retried */
> +};
> +
>   
<snip>
> +    /*
> +     * If the fault occurred due to cache maintenance or address translation
> +     * instructions, then Xen needs to ignore these instructions.
> +     */
> +    if ( info->dabt.cache )
> +    {
> +        info->dabt_instr.state = INSTR_IGNORE;
> +        return;
> +    }

I need to drop this. As stated before, this needs to be done in a 
separate patch.

<snip>

> +
> +            try_decode_instruction(regs, &info);
> +
> +            /*
> +             * If the instruction was to be ignored by Xen, then it should return
> +             * to the caller which will increment the PC, so that the guest can
> +             * execute the next instruction.
> +             */
> +            if ( info.dabt_instr.state == INSTR_IGNORE )
> +            {
> +                advance_pc(regs, hsr);
> +                return;
> +            }

Drop this.

<snip>

- Ayan



From xen-devel-bounces@lists.xenproject.org Tue Feb 08 11:55:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 11:55:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268255.462049 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHP5Q-0001Eg-Dl; Tue, 08 Feb 2022 11:55:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268255.462049; Tue, 08 Feb 2022 11:55:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHP5Q-0001EZ-Ap; Tue, 08 Feb 2022 11:55:08 +0000
Received: by outflank-mailman (input) for mailman id 268255;
 Tue, 08 Feb 2022 11:55:07 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1rHF=SX=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nHP5P-0001ET-LP
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 11:55:07 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f3888e56-88d5-11ec-8f75-fffcc8bd4f1a;
 Tue, 08 Feb 2022 12:55:05 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f3888e56-88d5-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644321305;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=3Bz3jv3JI9q31mHVOdaX+5yHINuphdteRvix91mskbI=;
  b=VvmRR7EiABlsXPD+uc/HRD6uLPtNUvisrMUJt8dEJs/rNlT5Vaws+1RX
   4Ks9cE9V1/c3Nte/FEewDXkmo/D6riaJ+3yOZ/uHgJhNXe+1UQL1fKvHB
   YKz9lJn8qKYjsd2k3JTaxVxCxJY75E0gLaMmNzpLqKnnD+22jWqbFvdvX
   k=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: 8+cFhN1/Ktp1mwHod9npuu9PfsXE7Ok7Rjkj7pgViLFhIHJcOomOAMgyfUTV7xqOyScQ9K6jj2
 VnpkHToJg9wr/15lEvR9Mda7MfF07aVuJwYTNtufaxwmNCHaeI5sLG4kDxpoYCtzaeRPxwTnn2
 0eNOQbIaw53tsP7Qy8F/81dWSrrW1MvePvxfzAppFj8T1dShsvtq2gFXBBS39QueWR97/88XEK
 bOLitF94UvNUYut5pzqd6QO/Z4geIHrjLSsOx1WBZg3jRGzExU/PNj6iigcr43JwUiDnycN9Y3
 8/f0RhE8UIO/dMHkbVpR0NFm
X-SBRS: 5.1
X-MesageID: 63725845
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:+VWywKjXNM2bKV/17pFg9iScX1618BcKZh0ujC45NGQN5FlHY01je
 htvWzqAOKyCZDagKd0nady3oBkGuZKAxtZhSwo9rn9nQX4b9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oAMKRCQ7InQLlbGILes1htZGEk0GE/NtTo5w7Rj2tQw0YDga++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /1mhZC6TSgyIJfuv808dBQBHHgkZalvreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHCOo8Ft24m5jbeFfs8GrjIQrnQ5M8e1zA17ixLNaiFO
 JBEOWYyBPjGSyB2PgYSC8szpcWLxV7/cD0Jg1WznZNitgA/yyQuieOwYbI5YOeiR9hRn0uej
 nLL+SL+GB5yHMeE1TOP/3aoh+nOtSD2QoQfEPu/7PECqEKX7nweDlsRT1TTifu2kEmlQPpEN
 lcZvCEpqMAa5EGtC9XwQRC8iHqFpQIHHcpdFfUg7wOAwbaS5ByWbkAGRDNcbN0ttOctWCcnk
 FSOmrvU6SdH6ePPDyjHr/HN8G30aXN9wXI+iTEsZjsJ6d3Mu58JrDXmb/FuSaHs1IXxMGSlq
 9yVlxQWi7IWhM8N8qy0+1Hbnj6hzqT0oh4JChb/BTz8sF4gDGKxT8nxsAWAs64cRGqMZgTZ5
 BA5d96iAPfi5H1nvAiEW60zEb6g/J5p2xWM0Ac0T/HNG9lAkkNPnLy8Ahkjfi+F0e5eIFcFh
 XM/XisLtfdu0IOCN/MfXm5II51CIVLcPdrkTOvISdFFf4J8cgSKlAk3OxLMhjG0yRZ9y/hkU
 Xt+TSpLJSxLYZmLMRLsH7tNuVPV7nxWKZzvqWDTkE38jOv2iI+9QrYZKlqeBt3VH4vfyDg5B
 +13bpPQoz0GCbWWSnCOreY7cABbRVBmVMueg5EGKYarfFE8cEl/UKC5/F/UU9E890ijvryTp
 S/Vt44x4AeXuEAr3i3QMi86M+60Dc8kxZ/5VAR1VWuVN7EYSd/HxI8UdoctfKlh8+pmzPVuS
 OICddnGCfNKIgkrMRxEBXUkhIA9JhmtmyyUOC+pPGo2c5J6HlSb8d74ZAr/siIJC3Pv58c5p
 rSh0CLdQIYCGFs+XJqHNqr3wgPjp2UZlcJzQ1DMfotZdnLz/dU4MCf2lPI2fZ0BcE2R2juA2
 g+KKh4Evu2R8ZQt+dzEiPnc/YekGudzBGRAGGzf4erkPCXW5DP7k4RBTPyJbXbWU2atoPeuY
 uBczvfdNvwbnQkV79ogQugzla9nvonhvb5XyAhgDU7nVVXzB+MyOGSC0OlOqrZJmu1TtzypV
 x/d4dJdI7iIZp/oSQZDOAo/Y+2f/vgIgT2Ov+8tKUD36SIrrrqKVUJeY0uFhCBHdeYnNYokx
 aEqudIM6hz5gR0va47UgidR/mWKD3oBT6R46c1KXN610lImmgNYfJjRKi7q+5XeOdxDP34jL
 iKQmKef1a9XwVDPciZrGHXAtQaHaU/iZPyeIIc+Gmm0
IronPort-HdrOrdr: A9a23:yBTisqxZhUYjf6h9ASHGKrPxiOskLtp133Aq2lEZdPULSKOlfp
 GV8MjziyWYtN9IYgBcpTiBUJPwJE81bfZOkMcs1MSZLXXbUQyTXcBfBOrZsnLd8kjFmNK1up
 0QCpSWZOeAbmSSyPyKmjVQcOxQgOVvkprY/ds2pk0FJWoBCsFdBkVCe32m+yVNNVN77PECZf
 6hD7981lydkAMsH6OG7xc+Lor+juyOsKijTQ8NBhYh5gXLpyiv8qTGHx+R2Qpbey9TwJ85mF
 K10DDR1+GGibWW2xXc32jc49B9g9360OZOA8SKl4w8NijssAC1f45sMofy/gzd4dvfrWrCou
 O85CvIDP4DrU85uVvF+CcF7jOQlArGLUWSkWNwz0GT+vARDwhKdPapzbgpDCcxrXBQ4e2UmZ
 g7r15w/fBsfGL9tTW46N7SWx5wkE2o5XIkjO4IlnRaFZATcblLsOUkjQlo+bo7bWrHAbocYa
 JT5QDnlYJrWELfa2qcsnhkwdSqUHh2FhCaQlIassjQ1zRNhnh2w0YR2cRaxx47hd4AYogB4/
 6BPrVjlblIQMNTZaVhBP0ZSc/yDmDWWxrDPG+bPFyiHqAaPHDGrYLx/dwOlayXUY1NyIF3lI
 XKUVteu2J3c0XyCdeW1JkO6RzJSHXVZ0Wl9iif3ekOhlTRfsuYDcSzciFYryL7mYRtPiTyYY
 fHBK5r
X-IronPort-AV: E=Sophos;i="5.88,352,1635220800"; 
   d="scan'208";a="63725845"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cqwd6xqhp+v8Qo5u7ephDkybH0VaBVFI3xIZ1aDJH9QRzhxisPXM3tBk4c3o9TXRrnXi0hBnP/EJI/kw2PlCPXB8bS31Pr0BZXi4KeoSzZWq9dDKSVU+lCS1hnskZezbwnuHVbEZrkcj4wNPPM81lMf+CM/XMb4kCykJWfPWMoUMlFEV2DPwF6n232i8/gs+DKq7oRylLw+tEk1S1D99c6ixd+cSSs4V3SccemNhEXzmnFrRWBAAHW4/yfSiymD9r7y+1+t9ImR7H7OVfEzJYwitagetbexR/sOVxu1gMleLVLdAlNg76u1P7AanMVNMPHy60Z/FrqZ3PqYW1tR6BA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=3Bz3jv3JI9q31mHVOdaX+5yHINuphdteRvix91mskbI=;
 b=IC55PLARjWIrxj946tMnIojugT7vT4uwRKRcVMeNQy0/aE8tVglVlU3HU9kybK9t/2X0Q5HjbFZD4jHxzGRg8R9/TLXqfbSex84B/ol11EOmEZ4r9bNbRRFlfyAfpss8A1zhO/G/Ij1hMUQSnW3DIFJpAIbkIdzMCyZeVv8paHWKPeao8H36PkWkwch0e7CuIUyvq0ZGK16AsZAmVpujLa7rxgOkOu1Ps/pWk/rDYBiyU5lJ4fVxbJ8j4TUmNaPtc3iMZzi38ZxzShaIMAZoYuHALssO5rmMpFMJPznoF9i5fcIooZ691WYL3qxq3qlMS0Ep+dwOVv3pS35bQZ3waA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=3Bz3jv3JI9q31mHVOdaX+5yHINuphdteRvix91mskbI=;
 b=CaTlSEXjDPJZqTonazktnpD77qoHceOxN0xoEg4rRc7Ic9RA8muOJQDD7DOU3M8Sj8popclhLrC/e8QXOL/zK3EnhXqdviGYu443wLuZgHXLcKn8+zhcgqWll2uceojv5guei5lVk/i6UUv10CfYtiJeXR2osQyBpiUyocTiYTo=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Juergen Gross <jgross@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: George Dunlap <George.Dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>
Subject: Re: [PATCH v2] xen/public: add comment to struct
 xen_mem_acquire_resource
Thread-Topic: [PATCH v2] xen/public: add comment to struct
 xen_mem_acquire_resource
Thread-Index: AQHYHL+DXP8ckdd1J06xLHRfc3g2d6yJi+WA
Date: Tue, 8 Feb 2022 11:55:00 +0000
Message-ID: <ed7424c3-e54c-4c65-03c6-57f9ddd182bc@citrix.com>
References: <20220208074230.7901-1-jgross@suse.com>
In-Reply-To: <20220208074230.7901-1-jgross@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.1
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: d9a76986-6c3c-4d8e-5f68-08d9eaf9d5bd
x-ms-traffictypediagnostic: SN6PR03MB4285:EE_
x-microsoft-antispam-prvs: <SN6PR03MB428551CD677B95180E58C0F8BA2D9@SN6PR03MB4285.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: VKWmBYBE93rcLrhE0SWYBALDsJyXGwZCD2tcEr2+0xUzNAMBZSKcyMSyEgO1fN1im9ukwk5ZMseUPjEw9OtwXk+xhUgFUUIXLZFIuY221wOv6GRdsvRcb1MEtpPdSsdQWmcmTRHKsMIn2aWTx8uJ0P5mi7rvgRXjMxocWJgH4EDoetIfqbZsgRSVv0gt33efCOfXlIcqiVbMwYnh4JR7j2QnufHOYpBsofIU8Fwq0RkKVnGpVg5AapqWo6EVmtpWeMXY5yxNP2lMNzyoOVJlo9ohK3L8n/CHJrkGLiyzFZmnBEpEkgnXS62Ds1rmNMx8VELUCBJJs9SzQrw0Lvkj/rhcDLmhk3sH5lWs41ZZ+NQ1sYBT2nkQ/GZ5sQmoxEiXF8GD60S1xnXChCqPsEiPIvCyvNyf3pmDxn02cCjYI0pihXLYL5VWezGFor3Y5w5fxPamA+4O7TtuTB8XDkCcvyvo6dOFTx2/aaNqFRkF1gju68Kz/salZ59RCgFdpxAFbvcq49Rz2omqyS9q3Q3kKNP2Osz1SODc3OrMX7MyejbUvQ176PRQR/u2UZwU163zK5MN+axpWiPtonGoVfUeTEMFw82u0aKxfRk3/5lP6J1vQ5oPcJRPwh1ndh6npmk9R6lYgiiPwCX+G5EW6oEzNjyNaZp7XEJkwCVON2I07hAkJNpPjbkgaDNG8+trDHSiLaHMDn7fhX9a1DllTExGflUBum5WTye2GRYQInPfZ+6LH1rxsG5C1aViFn6GS12sqFNdV6TOPjuXFZP6ivVNWQ==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(5660300002)(8936002)(8676002)(76116006)(66946007)(31686004)(36756003)(66476007)(66556008)(2906002)(91956017)(4326008)(64756008)(66446008)(83380400001)(38070700005)(38100700002)(122000001)(82960400001)(6486002)(31696002)(86362001)(508600001)(186003)(110136005)(316002)(54906003)(2616005)(53546011)(6506007)(26005)(71200400001)(6512007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?c00yTVZnTjk5MHF3SGdmY3NBUGFRSjFGRitrL1YvMDM2V3l3SnZXekJ2dVVY?=
 =?utf-8?B?eitXUk1USXNMeDlFR2tqTkhOYUtGang0VGZQREVnMTJIaGUwSm9LQmxmR0pS?=
 =?utf-8?B?cDRtcG80T05tRXhmb0o0akMvSm5uQTU0TFFyekNQVHA2a2toT1RaSHBZWWRH?=
 =?utf-8?B?dzdpb3ZOSi94bTFmcXpOMDlkL2RFSFhmRDhsUmFOa0dHbHh0K0ZuQVIrdzYy?=
 =?utf-8?B?MW9NUDBOdkFsZXM0Z2tEZEhTOFZaM2ZmK05lMXg1YWF0RHZsbGx5MnJldktr?=
 =?utf-8?B?WHBNdmFYNEZWcU1UVmd6Z25BZFR4Si9ZZVRPTjRqSlRDeE9oKzJFUGxvaDBh?=
 =?utf-8?B?UUcwOHVkNk1vRlM0SnNqNllCRDBlb1RhS0xnbmo3NGlVUUwwNDNRQUUxaHB2?=
 =?utf-8?B?TlNPZ2FnWUVaNmdmR3E1RFI3ZWIxQjlUWndmbTBQY0MzWGQ0N2JhenYvVmI4?=
 =?utf-8?B?UGQwQTgxRkt3R09qNzBHNHRmb2NhLzJpQWFweGhXUUVCN3p0NTdFTSt6TFlo?=
 =?utf-8?B?TlFxYjVqZEdIdXlmRGp1ekl2dmdGbEtFeW5WMm16TFhyVzNVV3kzYlRmQmNu?=
 =?utf-8?B?UHdJQ0NGSk8wZXF1M0dEUkswaGRKa0hnVGVCanpMQmZVRXRzVExOamFrTVFr?=
 =?utf-8?B?TnAzY0RmSVBDS0VqOVJPcDdkdW94c3hCdm9LWUVFelFCeFFSdklnTHpJcko2?=
 =?utf-8?B?VHZ3Z2hUendnaGlLbnR5Y0lMeUNDRVZkbDdJckhvY2Eyc2JFb1k1S09VZ21H?=
 =?utf-8?B?Wkh4SXdjZ3B6VEV1WjVEYVpxSFVycjRMTTJaOHpmZkNyc2NQSXZOVWdNbjlH?=
 =?utf-8?B?NGMvS2dRak1GZ0JMTnhpRW9tdjF0UXVqanR3L0dJU01idFQ2dVdDT3ZEQll3?=
 =?utf-8?B?T0p5VGVQenpOU2FsUUo4U0pRUldsWUpWcVRKWUhJN09ZTnVqRGcvekFZQ0Vr?=
 =?utf-8?B?UzVmeDB4TVd5aXB3a2ZvT3RYSUs0KzI0RVdXYkt5ejJwenZMQ21zeWFqcEgx?=
 =?utf-8?B?cCtCQllzOCtxNmpta2tCM1NTT3pOQlIvMWl1VjVtajZMdnRKdTZobUR3cWdv?=
 =?utf-8?B?OXo4R1dOOUs4QWpNQmEvVXJDU0wvakk4V1lXbDdzdWZqK1c3Yjl1Yzh0d05v?=
 =?utf-8?B?OTJmM0w1R0o0WUw0SksyalBvd21jVHdHSGJ6c2RFeGZMbGI5amN3a2Y2bW11?=
 =?utf-8?B?NmFVT2E4RkVkSTFkTnB2VHA2dXVTczByN1V5KzNONlJpc3ZjM1pwRE5YRkQr?=
 =?utf-8?B?T28vUGhERHZpREdWb1VpbFJpa3I0NTNpdzNGcW5kUDVhenJnTmMxQWVzQUZt?=
 =?utf-8?B?TjRFa0IwV1hBRnR0MUNRQ0RaRm44YVVlRkp1dGhxb2dSN3Uvek1rUXZGVWd3?=
 =?utf-8?B?NGwrUGE1NjNKUGowNXY5WWJlb2Z5NU1yMHliTWlUd1EwMGdRUmlkNStkYkVG?=
 =?utf-8?B?MkFNQWcxdDFWMVRCOTBSZVc0bTNDdUtEdjdKQW9jZUZiRDgwR21ibmcrbXpH?=
 =?utf-8?B?RUV4Tjk0VGRMRzJlSnZPaGhzeXZGNStBaGdRQmNjVWtBWmV0Ty9xRmVWNy9T?=
 =?utf-8?B?azV3UDBLYkhYcGxpeHNUVDJNaXlXWCtRRXlWR01idkxLS2R3MlFpdWRQY05N?=
 =?utf-8?B?VWR5YncvQzRZWGtiT21CNDlPNW1qTWhJaklxTXIzL01ON3NpaUZyazdrNEY1?=
 =?utf-8?B?eTFxcDhtR0puQ1g4QW5SQzdnOFEwb0hkUkgvcTcvc3lMeGJJL0VYRHBJMlNC?=
 =?utf-8?B?SHZhN3ZnblE0eTB0eWlxZW1SWlFkeVpzUFhSd0FPbGMvdjdqK1RwemVrSFQr?=
 =?utf-8?B?TWptZlRmWW1UQUg5TUpnZHJ5M2R5L3ZqZ0hmWEJkMHdUZTlxS0ZwNXA3RVAy?=
 =?utf-8?B?a1RHV0ljUndIRmxMbXFadnN3VExXaStRbGRXT3ZoR2lwYmVmeGVnWkllSXg5?=
 =?utf-8?B?bTBYWVZwdVpaaU9iVkxQdVlDdlE0UDYrRUQvTUVheVdPbWlJa3UvWlVWdzha?=
 =?utf-8?B?L2swTFJxM2hsZ084MkY4dkZqNUh4dFgyeGFlcDhvR0RKd0NLdUFOUjNiUlQ0?=
 =?utf-8?B?dzVMcWxxZTFvN08rTWlZazNZNTB3bUljM2Job0ltayszUkVlK3pEWTh6ZzBs?=
 =?utf-8?B?SGNPZnF3NkpIc1lYQ3lNelBRMytrejEwVkxsZktkTFo5ZTV6dGxuK2w0S1Z0?=
 =?utf-8?B?dVd1QkJmZXVtVWt5T3pqaVdzemI3Nm9XNG1uQWZadWJGUWpJTmhBNzlnc1ZY?=
 =?utf-8?B?eUFQNUZDaEw3Q05jbklpM3FaWkp3PT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <5E008DC1C28E034984DCB60E0CF9D092@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d9a76986-6c3c-4d8e-5f68-08d9eaf9d5bd
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2022 11:55:00.2256
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: w6TRNIcUC7D3t9ViRKtuksHYphun3LZdSqveifasmoydC1Ls41Uh59azwnM9OuMr85YYqzWJVDsK6HKyjnjAi3uKYUantAvM8NtRygtGBMk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR03MB4285
X-OriginatorOrg: citrix.com

T24gMDgvMDIvMjAyMiAwNzo0MiwgSnVlcmdlbiBHcm9zcyB3cm90ZToNCj4gQ29tbWl0IDdjN2Y3
ZThmYmEwMSBjaGFuZ2VkIHhlbi9pbmNsdWRlL3B1YmxpYy9tZW1vcnkuaCBpbiBhbiBpbmNvbXBh
dGlibGUNCj4gd2F5LiBVbmZvcnR1bmF0ZWx5IHRoZSBjaGFuZ2VkIHBhcnRzIHdlcmUgYWxyZWFk
eSBpbiB1c2UgaW4gdGhlIExpbnV4DQo+IGtlcm5lbCwgc28gYW4gdXBkYXRlIG9mIHRoZSBoZWFk
ZXIgaW4gdGhlIGtlcm5lbCB3b3VsZCByZXN1bHQgaW4gYSBidWlsZA0KPiBicmVha2FnZS4NCj4N
Cj4gQXMgdGhlIGNoYW5nZSBvZiBhYm92ZSBjb21taXQgd2FzIGluIGEgc2VjdGlvbiBvcmlnaW5h
bGx5IG1lYW50IHRvIGJlIG5vdA0KPiBzdGFibGUsIGl0IHdhcyB0aGUgdXNhZ2UgaW4gdGhlIGtl
cm5lbCB3aGljaCB3YXMgd3JvbmcuDQoNCldoaWxlIEkgaGF0ZSB0byBkcmFnIHRoZSBhcmd1bWVu
dCBvbiwgdGhpcyBpcyB3cm9uZy4NCg0KSW5zdGVhZCBvZiBzcGVjdWxhdGluZywgd2h5IGRvbid0
IHdlIGFjdHVhbGx5IGxvb2sgYXQgdGhlIGNvZGUuwqAgRnJvbSBMaW51eDoNCg0KdW5zaWduZWQg
aW50IGRvbWlkID0NCsKgwqDCoMKgwqDCoMKgICh4ZGF0YS5mbGFncyAmIFhFTk1FTV9yc3JjX2Fj
cV9jYWxsZXJfb3duZWQpID8NCsKgwqDCoMKgwqDCoMKgIERPTUlEX1NFTEYgOiBrZGF0YS5kb207
DQouLi4NCm51bSA9IHhlbl9yZW1hcF9kb21haW5fbWZuX2FycmF5KHZtYSwNCsKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAga2Rh
dGEuYWRkciAmIFBBR0VfTUFTSywNCsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcGZucywga2RhdGEubnVtLCBlcnJzLA0KwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoCB2bWEtPnZtX3BhZ2VfcHJvdCwNCsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgZG9taWQpOw0KDQpVbmRlciB0aGUgb3Jp
Z2luYWwgaW1wbGVtZW50YXRpb24sIGl0IHdhcyBsaXRlcmFsbHkgbm90IHBvc3NpYmxlIGZvciBh
DQprZXJuZWwgdG8gYXZvaWQgdXNpbmcgWEVOTUVNX3JzcmNfYWNxX2NhbGxlcl9vd25lZCwgYmVj
YXVzZSBpdA0KZGV0ZXJtaW5lZCB3aGljaCBkb21pZCBuZWVkZWQgZmVlZGluZyBpbnRvIGEgc3Vi
c2VxdWVudCBmb3JlaWduIG1hcCBjb21tYW5kLg0KDQpUaGUgY29uc3RhbnQgd2FzIHRoZXJlZm9y
ZSBhbHdheXMgcGFydCBvZiB0aGUgZnVsbHkgcHVibGljIEFCSSwgaG93ZXZlcg0KaXQgbWF5IGhh
dmUgYmVlbiBpbnRlbmRlZCwgYW5kIHN1YnNlcXVlbnQgY2xhaW1zIHRvIHRoZSBjb250cmFyeQ0K
KG5vdGFibHksIHRob3NlIHVzZWQgdG8ganVzdGlmeSBpdHMgZGVsZXRpb24pIGFyZSBmYWxzZS4N
Cg0KVGhlIHNlY3VyaXR5IGZpeCBmb3IgWGVuIHdhcyB0byBwcm9oaWJpdCBjcmVhdGluZyBzaXR1
YXRpb25zIHdoZXJlIHdlDQpmZWQgY2FsbGVyX293bmVkIGJhY2sgdG8gdGhlIGtlcm5lbC7CoCBU
aGlzIGlzIEFCSSBjb21wYXRpYmxlLCBtZXJlbHkNCmNyZWF0aW5nIGEgZGVhZCBsb2dpYyBwYXRo
IGluIHRoZSBrZXJuZWwuDQoNCj4gQWRkIGEgY29tbWVudCB0byB0aGUgbW9kaWZpZWQgc3RydWN0
IGZvciBub3QgcmV1c2luZyB0aGUgbm93IHJlbW92ZWQgYml0LA0KPiBpbiBvcmRlciB0byBhdm9p
ZCBrZXJuZWxzIHVzaW5nIGl0IHN0dW1ibGluZyBvdmVyIGEgcG9zc2libGUgbmV3IG1lYW5pbmcN
Cj4gb2YgdGhlIGJpdC4NCj4NCj4gSW4gY2FzZSB0aGUga2VybmVsIGlzIHVwZGF0aW5nIHRvIGEg
bmV3IHZlcnNpb24gb2YgdGhlIGhlYWRlciwgdGhlIHdyb25nDQo+IHVzZSBjYXNlIG11c3QgYmUg
cmVtb3ZlZCBmaXJzdC4NCj4NCj4gU2lnbmVkLW9mZi1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3Nz
QHN1c2UuY29tPg0KPiAtLS0NCj4gVjI6DQo+IC0gb25seSBhZGQgY29tbWVudCBpbnN0ZWFkIG9m
IHJldmVydGluZyBjb21taXQgN2M3ZjdlOGZiYTAxIChKYW4gQmV1bGljaCkNCj4gLS0tDQo+ICB4
ZW4vaW5jbHVkZS9wdWJsaWMvbWVtb3J5LmggfCA1ICsrKysrDQo+ICAxIGZpbGUgY2hhbmdlZCwg
NSBpbnNlcnRpb25zKCspDQo+DQo+IGRpZmYgLS1naXQgYS94ZW4vaW5jbHVkZS9wdWJsaWMvbWVt
b3J5LmggYi94ZW4vaW5jbHVkZS9wdWJsaWMvbWVtb3J5LmgNCj4gaW5kZXggMzgzYTk0NjhjMy4u
ODY1MTMwNTdmNyAxMDA2NDQNCj4gLS0tIGEveGVuL2luY2x1ZGUvcHVibGljL21lbW9yeS5oDQo+
ICsrKyBiL3hlbi9pbmNsdWRlL3B1YmxpYy9tZW1vcnkuaA0KPiBAQCAtNjYyLDYgKzY2MiwxMSBA
QCBzdHJ1Y3QgeGVuX21lbV9hY3F1aXJlX3Jlc291cmNlIHsNCj4gICAgICAgKiB0d28gY2FsbHMu
DQo+ICAgICAgICovDQo+ICAgICAgdWludDMyX3QgbnJfZnJhbWVzOw0KPiArICAgIC8qDQo+ICsg
ICAgICogUGFkZGluZyBmaWVsZCwgbXVzdCBiZSB6ZXJvIG9uIGlucHV0Lg0KPiArICAgICAqIFRo
ZSBsb3dlc3QgYml0IHdhcyBuYW1lZCBYRU5NRU1fcnNyY19hY3FfY2FsbGVyX293bmVkIGluIGEg
cHJldmlvdXMNCj4gKyAgICAgKiB2ZXJzaW9uIGFuZCBzaG91bGQgbm90IGJlIHJldXNlZCBpbiBm
dXR1cmUuDQoNCnMvc2hvdWxkL3dpbGwvLsKgIFRoaXMgaXMgYSBzdGF0ZW1lbnQgb2YgaG93IFhl
biBzaGFsbCBiZWhhdmUuDQoNCkkgdGhpbmsgaXQncyBhbHNvIHdvcnRoIHNvbWVob3cgZml0dGlu
ZyBpbiB0aGF0IGl0J3MgYW4gb3V0cHV0IG9ubHkNCmJpdC7CoCBJdCB3aWxsIGJlIGltcG9ydGFu
dCB3aGVuIGluZXZpdGFibHkgd2UgZW5kIHVwIGNoYW5naW5nIHRoaXMgYmFjaw0KdG8gYmVpbmcg
YSBmbGFncyBmaWVsZCB3aGVuIHdlIG5lZWQgdG8gZXh0ZW5kIHRoZSBoeXBlcmNhbGwuDQoNCn5B
bmRyZXcNCg==


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 11:58:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 11:58:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268263.462061 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHP8a-0001sU-Vu; Tue, 08 Feb 2022 11:58:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268263.462061; Tue, 08 Feb 2022 11:58:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHP8a-0001sN-Qu; Tue, 08 Feb 2022 11:58:24 +0000
Received: by outflank-mailman (input) for mailman id 268263;
 Tue, 08 Feb 2022 11:58:24 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nHP8a-0001sH-5I
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 11:58:24 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nHP8Y-0006qt-VA; Tue, 08 Feb 2022 11:58:22 +0000
Received: from 54-240-197-236.amazon.com ([54.240.197.236]
 helo=[192.168.10.176]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nHP8Y-0004Gf-Oh; Tue, 08 Feb 2022 11:58:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=E/NQz5GIoPzXYpvvWOQ3lpEGqJFYgl+m5l35i2/Tl2E=; b=zH4jJxTFiGYcju064dUQseOOJp
	+DNSzWdn3y7Et2cRfGJJyy0EXphtEbJrfu5PHmji7dlXB91NaYdYgI0zMKcRN6qZCG8R5ELpbufHF
	XYVsP3XsxS1uThgHrZIUCP2UHxSs2m8u27lKU0rToTPFdeWBAT/WtFMe/0TP9QZ3Mygc=;
Message-ID: <82d8bfe0-cb46-d303-6a60-2324dd76a1f7@xen.org>
Date: Tue, 8 Feb 2022 11:58:19 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.1
Subject: Re: [PATCH V5] xen/gnttab: Store frame GFN in struct page_info on Arm
To: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Jan Beulich <jbeulich@suse.com>
Cc: Oleksandr Tyshchenko <olekstysh@gmail.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Bob Eshleman <bobbyeshleman@gmail.com>,
 Alistair Francis <alistair.francis@wdc.com>,
 Connor Davis <connojdavis@gmail.com>
References: <1641424268-12968-1-git-send-email-olekstysh@gmail.com>
 <a54213c4-1c68-694e-c130-d95faeef3953@xen.org>
 <78d94e1e-6db4-25c1-adb8-e4bdbfe42774@epam.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <78d94e1e-6db4-25c1-adb8-e4bdbfe42774@epam.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi,

On 07/02/2022 19:56, Oleksandr Tyshchenko wrote:
> 
> On 07.02.22 19:15, Julien Grall wrote:
>> Hi Oleksandr,
>> On 05/01/2022 23:11, Oleksandr Tyshchenko wrote:
>>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>>
>>> Rework Arm implementation to store grant table frame GFN
>>> in struct page_info directly instead of keeping it in
>>> standalone status/shared arrays. This patch is based on
>>> the assumption that grant table page is the xenheap page.
>>
>> I would write "grant table pages are xenheap pages" or "a grant table
>> page is a xenheap page".
>>
>> [...]
>>
>>> diff --git a/xen/arch/arm/include/asm/grant_table.h
>>> b/xen/arch/arm/include/asm/grant_table.h
>>> index d31a4d6..d6fda31 100644
>>> --- a/xen/arch/arm/include/asm/grant_table.h
>>> +++ b/xen/arch/arm/include/asm/grant_table.h
>>> @@ -11,11 +11,6 @@
>>>    #define INITIAL_NR_GRANT_FRAMES 1U
>>>    #define GNTTAB_MAX_VERSION 1
>>>    -struct grant_table_arch {
>>> -    gfn_t *shared_gfn;
>>> -    gfn_t *status_gfn;
>>> -};
>>> -
>>>    static inline void gnttab_clear_flags(struct domain *d,
>>>                                          unsigned int mask, uint16_t
>>> *addr)
>>>    {
>>> @@ -46,41 +41,12 @@ int replace_grant_host_mapping(unsigned long
>>> gpaddr, mfn_t mfn,
>>>    #define gnttab_dom0_frames() \
>>>        min_t(unsigned int, opt_max_grant_frames, PFN_DOWN(_etext -
>>> _stext))
>>>    -#define gnttab_init_arch(gt) \
>>> -({ \
>>> -    unsigned int ngf_ =
>>> (gt)->max_grant_frames;                          \
>>> -    unsigned int nsf_ =
>>> grant_to_status_frames(ngf_);                    \
>>> - \
>>> -    (gt)->arch.shared_gfn = xmalloc_array(gfn_t,
>>> ngf_);                  \
>>> -    (gt)->arch.status_gfn = xmalloc_array(gfn_t,
>>> nsf_);                  \
>>> -    if ( (gt)->arch.shared_gfn && (gt)->arch.status_gfn
>>> )                \
>>> - { \
>>> -        while ( ngf_--
>>> )                                                 \
>>> -            (gt)->arch.shared_gfn[ngf_] =
>>> INVALID_GFN;                   \
>>> -        while ( nsf_--
>>> )                                                 \
>>> -            (gt)->arch.status_gfn[nsf_] =
>>> INVALID_GFN;                   \
>>> - } \
>>> - else \
>>> - gnttab_destroy_arch(gt); \
>>> -    (gt)->arch.shared_gfn ? 0 :
>>> -ENOMEM;                                 \
>>> -})
>>> -
>>> -#define gnttab_destroy_arch(gt) \
>>> -    do { \
>>> - XFREE((gt)->arch.shared_gfn); \
>>> - XFREE((gt)->arch.status_gfn); \
>>> -    } while ( 0 )
>>> -
>>>    #define gnttab_set_frame_gfn(gt, st, idx, gfn,
>>> mfn)                      \
>>> ({ \
>>> -        int rc_ =
>>> 0;                                                     \
>>>            gfn_t ogfn = gnttab_get_frame_gfn(gt, st,
>>> idx);                  \
>>> -        if ( gfn_eq(ogfn, INVALID_GFN) || gfn_eq(ogfn, gfn)
>>> ||           \
>>> -             (rc_ = guest_physmap_remove_page((gt)->domain, ogfn,
>>> mfn,   \
>>> -                                              0)) == 0
>>> )                 \
>>> -            ((st) ?
>>> (gt)->arch.status_gfn                                \
>>> -                  : (gt)->arch.shared_gfn)[idx] =
>>> (gfn);                 \
>>> - rc_; \
>>> +        (!gfn_eq(ogfn, INVALID_GFN) && !gfn_eq(ogfn,
>>> gfn))               \
>>> +         ? guest_physmap_remove_page((gt)->domain, ogfn, mfn,
>>> 0)         \
>>> +         :
>>> 0;                                                            \
>>
>> Given that we are implementing something similar to an M2P, I was
>> expecting the implementation to be pretty much the same as the x86
>> helper.
>>
>> Would you be able to outline why it is different?
> 
> Being honest, I didn't think about it so far.  But, I agree with the
> question.
> 
> It feels to me that Arm variant can now behave as x86 one (as
> xenmem_add_to_physmap_one() now checks for the prior mapping), I mean to
> use INVALID_GFN as an indication to remove a page.
> 
> What do you think?

I will defer that to Jan.

Jan, IIRC you were the one introducing the call to 
guest_physmap_remove_page(). Do you remember why the difference between 
x86 and Arm were necessary?

[...]

>>
>>
>>> + */
>>> +#define PGT_gfn_width     PG_shift(3)
>>> +#define PGT_gfn_mask      ((1UL<<PGT_gfn_width)-1)
>>> +
>>> +#define PGT_INVALID_XENHEAP_GFN   _gfn(PGT_gfn_mask)
>>> +
>>> +/*
>>> + * An arch-specific initialization pattern is needed for the
>>> type_info field
>>> + * as it's GFN portion can contain the valid GFN if page is xenheap
>>> page.
>>> + */
>>> +#define PGT_TYPE_INFO_INIT_PATTERN gfn_x(PGT_INVALID_XENHEAP_GFN)
>>>       /* Cleared when the owning guest 'frees' this page. */
>>>    #define _PGC_allocated    PG_shift(1)
>>> @@ -358,6 +371,25 @@ void clear_and_clean_page(struct page_info *page);
>>>      unsigned int arch_get_dma_bitsize(void);
>>>    +static inline gfn_t page_get_xenheap_gfn(const struct page_info *p)
>>> +{
>>> +    gfn_t gfn_ = _gfn(p->u.inuse.type_info & PGT_gfn_mask);
>>> +
>>> +    ASSERT(is_xen_heap_page(p));
>>> +
>>> +    return gfn_eq(gfn_, PGT_INVALID_XENHEAP_GFN) ? INVALID_GFN : gfn_;
>>> +}
>>> +
>>> +static inline void page_set_xenheap_gfn(struct page_info *p, gfn_t gfn)
>>> +{
>>> +    gfn_t gfn_ = gfn_eq(gfn, INVALID_GFN) ? PGT_INVALID_XENHEAP_GFN
>>> : gfn;
>>> +
>>> +    ASSERT(is_xen_heap_page(p));
>>> +
>>> +    p->u.inuse.type_info &= ~PGT_gfn_mask;
>>> +    p->u.inuse.type_info |= gfn_x(gfn_);
>>> +}
>>
>> This is not going to be atomic. So can you outline which locking
>> mechanism should be used to protect access (set/get) to the GFN?
> 
> 
> I think, the P2M lock.

Ok. So, looking at the code, most of calls to page_get_xenheap_gfn() are 
not protected with the p2m_lock().

(Jan please confirm) If I am not mistaken, on x86, a read to the M2P is 
not always protected. But they have code within the P2M lock to check 
any difference (see p2m_remove_page()). I think we would need the same, 
so we don't end up to introduce a behavior similar to what XSA-387 has 
fixed on x86.

In addition to that, if p2m_get_xenheap_gfn() is going to be called 
locklessly. Then we need to make sure the update to type_info are 
atomic. This means:
  - p2m_get_xenheap_gfn() should use READ_ONCE().
  - p2m_set_xenheap_gfn() should use WRITE_ONCE(). We might even need to 
use cmpxchg() if there are other update to type_info that are not 
protected. I will let you have a look.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 12:22:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 12:22:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268276.462072 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHPVb-00056x-1R; Tue, 08 Feb 2022 12:22:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268276.462072; Tue, 08 Feb 2022 12:22:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHPVa-00056q-Sk; Tue, 08 Feb 2022 12:22:10 +0000
Received: by outflank-mailman (input) for mailman id 268276;
 Tue, 08 Feb 2022 12:22:09 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=co3W=SX=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nHPVZ-00056k-JE
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 12:22:09 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id bb83b2ef-88d9-11ec-8eb8-a37418f5ba1a;
 Tue, 08 Feb 2022 13:22:08 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 6BB651F383;
 Tue,  8 Feb 2022 12:22:07 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2803B13C08;
 Tue,  8 Feb 2022 12:22:07 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 1bPrB29gAmJOPAAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 08 Feb 2022 12:22:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bb83b2ef-88d9-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1644322927; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=FRt/HHpoFOuupmwUM/HXKHhNCsyMWM/lPwuNhPA+yWo=;
	b=pTi2NYkVy+vCh/pdF4QiHA59+W/hv4MlEARHxOB2o1xITFjl4XOypHmIzFNCH3qK6Pq6j4
	tMIi5hh2ccqmzlElFn/PP2uF9PdioDtcnUCZzAuukN19dPo0bWuY3JLUAfRTPMJyMG/TrW
	wSVinkpHp3BECwSmwr4LePZnoetO2eY=
Message-ID: <bcdb29f3-164c-03ea-1b48-4328f75778b1@suse.com>
Date: Tue, 8 Feb 2022 13:22:06 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: George Dunlap <George.Dunlap@citrix.com>, Jan Beulich
 <jbeulich@suse.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
References: <20220208074230.7901-1-jgross@suse.com>
 <ed7424c3-e54c-4c65-03c6-57f9ddd182bc@citrix.com>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH v2] xen/public: add comment to struct
 xen_mem_acquire_resource
In-Reply-To: <ed7424c3-e54c-4c65-03c6-57f9ddd182bc@citrix.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------0O4yOt4kQ0Fc8crcGqmKcdPL"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------0O4yOt4kQ0Fc8crcGqmKcdPL
Content-Type: multipart/mixed; boundary="------------8FJKmqnbE9x0OqNhCXkN8vuN";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Andrew Cooper <Andrew.Cooper3@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: George Dunlap <George.Dunlap@citrix.com>, Jan Beulich
 <jbeulich@suse.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Message-ID: <bcdb29f3-164c-03ea-1b48-4328f75778b1@suse.com>
Subject: Re: [PATCH v2] xen/public: add comment to struct
 xen_mem_acquire_resource
References: <20220208074230.7901-1-jgross@suse.com>
 <ed7424c3-e54c-4c65-03c6-57f9ddd182bc@citrix.com>
In-Reply-To: <ed7424c3-e54c-4c65-03c6-57f9ddd182bc@citrix.com>

--------------8FJKmqnbE9x0OqNhCXkN8vuN
Content-Type: multipart/mixed; boundary="------------UNl0KKgRcE4lztDKeyCMHbwW"

--------------UNl0KKgRcE4lztDKeyCMHbwW
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMDguMDIuMjIgMTI6NTUsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+IE9uIDA4LzAyLzIw
MjIgMDc6NDIsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+PiBDb21taXQgN2M3ZjdlOGZiYTAx
IGNoYW5nZWQgeGVuL2luY2x1ZGUvcHVibGljL21lbW9yeS5oIGluIGFuIGluY29tcGF0aWJs
ZQ0KPj4gd2F5LiBVbmZvcnR1bmF0ZWx5IHRoZSBjaGFuZ2VkIHBhcnRzIHdlcmUgYWxyZWFk
eSBpbiB1c2UgaW4gdGhlIExpbnV4DQo+PiBrZXJuZWwsIHNvIGFuIHVwZGF0ZSBvZiB0aGUg
aGVhZGVyIGluIHRoZSBrZXJuZWwgd291bGQgcmVzdWx0IGluIGEgYnVpbGQNCj4+IGJyZWFr
YWdlLg0KPj4NCj4+IEFzIHRoZSBjaGFuZ2Ugb2YgYWJvdmUgY29tbWl0IHdhcyBpbiBhIHNl
Y3Rpb24gb3JpZ2luYWxseSBtZWFudCB0byBiZSBub3QNCj4+IHN0YWJsZSwgaXQgd2FzIHRo
ZSB1c2FnZSBpbiB0aGUga2VybmVsIHdoaWNoIHdhcyB3cm9uZy4NCj4gDQo+IFdoaWxlIEkg
aGF0ZSB0byBkcmFnIHRoZSBhcmd1bWVudCBvbiwgdGhpcyBpcyB3cm9uZy4NCj4gDQo+IElu
c3RlYWQgb2Ygc3BlY3VsYXRpbmcsIHdoeSBkb24ndCB3ZSBhY3R1YWxseSBsb29rIGF0IHRo
ZSBjb2RlLsKgIEZyb20gTGludXg6DQo+IA0KPiB1bnNpZ25lZCBpbnQgZG9taWQgPQ0KPiAg
wqDCoMKgwqDCoMKgwqAgKHhkYXRhLmZsYWdzICYgWEVOTUVNX3JzcmNfYWNxX2NhbGxlcl9v
d25lZCkgPw0KPiAgwqDCoMKgwqDCoMKgwqAgRE9NSURfU0VMRiA6IGtkYXRhLmRvbTsNCj4g
Li4uDQo+IG51bSA9IHhlbl9yZW1hcF9kb21haW5fbWZuX2FycmF5KHZtYSwNCj4gIMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqAga2RhdGEuYWRkciAmIFBBR0VfTUFTSywNCj4gIMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcGZucywga2Rh
dGEubnVtLCBlcnJzLA0KPiAgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB2bWEtPnZtX3BhZ2VfcHJvdCwNCj4gIMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqAgZG9taWQpOw0KPiANCj4gVW5kZXIgdGhlIG9yaWdpbmFsIGltcGxlbWVudGF0
aW9uLCBpdCB3YXMgbGl0ZXJhbGx5IG5vdCBwb3NzaWJsZSBmb3IgYQ0KPiBrZXJuZWwgdG8g
YXZvaWQgdXNpbmcgWEVOTUVNX3JzcmNfYWNxX2NhbGxlcl9vd25lZCwgYmVjYXVzZSBpdA0K
PiBkZXRlcm1pbmVkIHdoaWNoIGRvbWlkIG5lZWRlZCBmZWVkaW5nIGludG8gYSBzdWJzZXF1
ZW50IGZvcmVpZ24gbWFwIGNvbW1hbmQuDQoNCldoaWxlIG5hc3R5IEkgdGhpbmsgaXQgd291
bGQgaGF2ZSBiZWVuIHBvc3NpYmxlIHRvIHNwbGl0IHRoZSBvcGVyYXRpb24NCmRvbmUgaW4g
dGhlIGtlcm5lbCdzIHByaXZjbWRfaW9jdGxfbW1hcF9yZXNvdXJjZSgpIGludG8gc2V2ZXJh
bCBwaWVjZXMNCmFuZCBsZXQgdGhlIFhlbiB0b29scyBkZWNpZGUgd2hpY2ggZG9taWQgdG8g
dXNlLg0KDQpUaGUgb3JpZ2luYWwgaW50ZXJmYWNlIGRlZmluaXRpb24gZGlkIG5vdCBtYW5k
YXRlIHRvIGJlIHVzYWJsZSBpbiB0aGUNCmtlcm5lbCBvbmx5LCBpdCB3YXMganVzdCBkb25l
IHRoaXMgd2F5LCBiZWNhdXNlIGl0IHdhcyBlYXNpZXIuDQoNCj4gVGhlIGNvbnN0YW50IHdh
cyB0aGVyZWZvcmUgYWx3YXlzIHBhcnQgb2YgdGhlIGZ1bGx5IHB1YmxpYyBBQkksIGhvd2V2
ZXINCj4gaXQgbWF5IGhhdmUgYmVlbiBpbnRlbmRlZCwgYW5kIHN1YnNlcXVlbnQgY2xhaW1z
IHRvIHRoZSBjb250cmFyeQ0KPiAobm90YWJseSwgdGhvc2UgdXNlZCB0byBqdXN0aWZ5IGl0
cyBkZWxldGlvbikgYXJlIGZhbHNlLg0KPiANCj4gVGhlIHNlY3VyaXR5IGZpeCBmb3IgWGVu
IHdhcyB0byBwcm9oaWJpdCBjcmVhdGluZyBzaXR1YXRpb25zIHdoZXJlIHdlDQo+IGZlZCBj
YWxsZXJfb3duZWQgYmFjayB0byB0aGUga2VybmVsLsKgIFRoaXMgaXMgQUJJIGNvbXBhdGli
bGUsIG1lcmVseQ0KPiBjcmVhdGluZyBhIGRlYWQgbG9naWMgcGF0aCBpbiB0aGUga2VybmVs
Lg0KPiANCj4+IEFkZCBhIGNvbW1lbnQgdG8gdGhlIG1vZGlmaWVkIHN0cnVjdCBmb3Igbm90
IHJldXNpbmcgdGhlIG5vdyByZW1vdmVkIGJpdCwNCj4+IGluIG9yZGVyIHRvIGF2b2lkIGtl
cm5lbHMgdXNpbmcgaXQgc3R1bWJsaW5nIG92ZXIgYSBwb3NzaWJsZSBuZXcgbWVhbmluZw0K
Pj4gb2YgdGhlIGJpdC4NCj4+DQo+PiBJbiBjYXNlIHRoZSBrZXJuZWwgaXMgdXBkYXRpbmcg
dG8gYSBuZXcgdmVyc2lvbiBvZiB0aGUgaGVhZGVyLCB0aGUgd3JvbmcNCj4+IHVzZSBjYXNl
IG11c3QgYmUgcmVtb3ZlZCBmaXJzdC4NCj4+DQo+PiBTaWduZWQtb2ZmLWJ5OiBKdWVyZ2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+DQo+PiAtLS0NCj4+IFYyOg0KPj4gLSBvbmx5IGFk
ZCBjb21tZW50IGluc3RlYWQgb2YgcmV2ZXJ0aW5nIGNvbW1pdCA3YzdmN2U4ZmJhMDEgKEph
biBCZXVsaWNoKQ0KPj4gLS0tDQo+PiAgIHhlbi9pbmNsdWRlL3B1YmxpYy9tZW1vcnkuaCB8
IDUgKysrKysNCj4+ICAgMSBmaWxlIGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygrKQ0KPj4NCj4+
IGRpZmYgLS1naXQgYS94ZW4vaW5jbHVkZS9wdWJsaWMvbWVtb3J5LmggYi94ZW4vaW5jbHVk
ZS9wdWJsaWMvbWVtb3J5LmgNCj4+IGluZGV4IDM4M2E5NDY4YzMuLjg2NTEzMDU3ZjcgMTAw
NjQ0DQo+PiAtLS0gYS94ZW4vaW5jbHVkZS9wdWJsaWMvbWVtb3J5LmgNCj4+ICsrKyBiL3hl
bi9pbmNsdWRlL3B1YmxpYy9tZW1vcnkuaA0KPj4gQEAgLTY2Miw2ICs2NjIsMTEgQEAgc3Ry
dWN0IHhlbl9tZW1fYWNxdWlyZV9yZXNvdXJjZSB7DQo+PiAgICAgICAgKiB0d28gY2FsbHMu
DQo+PiAgICAgICAgKi8NCj4+ICAgICAgIHVpbnQzMl90IG5yX2ZyYW1lczsNCj4+ICsgICAg
LyoNCj4+ICsgICAgICogUGFkZGluZyBmaWVsZCwgbXVzdCBiZSB6ZXJvIG9uIGlucHV0Lg0K
Pj4gKyAgICAgKiBUaGUgbG93ZXN0IGJpdCB3YXMgbmFtZWQgWEVOTUVNX3JzcmNfYWNxX2Nh
bGxlcl9vd25lZCBpbiBhIHByZXZpb3VzDQo+PiArICAgICAqIHZlcnNpb24gYW5kIHNob3Vs
ZCBub3QgYmUgcmV1c2VkIGluIGZ1dHVyZS4NCj4gDQo+IHMvc2hvdWxkL3dpbGwvLsKgIFRo
aXMgaXMgYSBzdGF0ZW1lbnQgb2YgaG93IFhlbiBzaGFsbCBiZWhhdmUuDQoNCk9rYXkuDQoN
Cj4gSSB0aGluayBpdCdzIGFsc28gd29ydGggc29tZWhvdyBmaXR0aW5nIGluIHRoYXQgaXQn
cyBhbiBvdXRwdXQgb25seQ0KPiBiaXQuwqAgSXQgd2lsbCBiZSBpbXBvcnRhbnQgd2hlbiBp
bmV2aXRhYmx5IHdlIGVuZCB1cCBjaGFuZ2luZyB0aGlzIGJhY2sNCj4gdG8gYmVpbmcgYSBm
bGFncyBmaWVsZCB3aGVuIHdlIG5lZWQgdG8gZXh0ZW5kIHRoZSBoeXBlcmNhbGwuDQoNCk9r
YXkuDQoNCkluIHRoZSBlbmQgdGhlIGJpdCBvbmx5IG5lZWRzIHRvIGJlIHJlc2VydmVkLCBp
ZiBwYWQgX2lzXyB6ZXJvIG9uIGlucHV0Lg0KU28gdGhlIGNvcnJlY3Qgd2F5IHRvIHBocmFz
ZSBpdCB3b3VsZCBiZToNCg0KLyoNCiAgKiBQYWRkaW5nIGZpZWxkLCBtdXN0IGJlIHplcm8g
b24gaW5wdXQuDQogICogSW4gYSBwcmV2aW91cyB2ZXJzaW9uIHRoaXMgd2FzIGFuIG91dHB1
dCBmaWVsZCB3aXRoIHRoZSBsb3dlc3QNCiAgKiBiaXQgbmFtZWQgWEVOTUVNX3JzcmNfYWNx
X2NhbGxlcl9vd25lZC4gRnV0dXJlIHZlcnNpb25zIG9mIHRoaXMNCiAgKiBpbnRlcmZhY2Ug
d2lsbCBub3QgcmV1c2UgdGhpcyBiaXQgd2l0aCB0aGUgZmllbGQgYmVpbmcgemVybyBvbg0K
ICAqIGlucHV0Lg0KICAqLw0KDQpJcyB0aGlzIGZpbmUgd2l0aCB5b3U/DQoNCg0KSnVlcmdl
bg0K
--------------UNl0KKgRcE4lztDKeyCMHbwW
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------UNl0KKgRcE4lztDKeyCMHbwW--

--------------8FJKmqnbE9x0OqNhCXkN8vuN--

--------------0O4yOt4kQ0Fc8crcGqmKcdPL
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmICYG4FAwAAAAAACgkQsN6d1ii/Ey/3
yQf/cs1fjDasJ8fpzC+flhwhhTgxu1NP9S0Im+CgxG779z8rLilsoqU7aNCfaAfvF0CxrG6FR7li
tUwp3805c6kBkitXrjyD2F248OV3n1xxr35QAaRVaiTwrsOwOu/4gbuiUZToSs4yKmxhgJMd2EpI
g/wQtXO+xnzrYvyUSRMfO2ZV0eehENTmehy3Qs40kWUnf1evcxI1JSb70AciZtcTsbVwgkabbW4m
KBnmWpyLCVDMM6sboKDntJgx9oDag/ubzqLk/WkRSQk5qNGitzbfVWiS8Q2rPLsSPXDmAg5klik8
bwYBZLM2jr8wT0H8ktbOquQm/W0Um0bfm8jVSZ8Oag==
=htee
-----END PGP SIGNATURE-----

--------------0O4yOt4kQ0Fc8crcGqmKcdPL--


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 12:39:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 12:39:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268285.462083 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHPmb-0006fO-Fr; Tue, 08 Feb 2022 12:39:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268285.462083; Tue, 08 Feb 2022 12:39:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHPmb-0006fH-Cn; Tue, 08 Feb 2022 12:39:45 +0000
Received: by outflank-mailman (input) for mailman id 268285;
 Tue, 08 Feb 2022 12:39:43 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=v7zX=SX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nHPmZ-0006f9-E1
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 12:39:43 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2ff12781-88dc-11ec-8eb8-a37418f5ba1a;
 Tue, 08 Feb 2022 13:39:42 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2057.outbound.protection.outlook.com [104.47.14.57]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-24-_kk5Ur3ePym03TNQ-Kjjqw-1; Tue, 08 Feb 2022 13:39:40 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DB7PR04MB4090.eurprd04.prod.outlook.com (2603:10a6:5:28::24) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Tue, 8 Feb
 2022 12:39:38 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.018; Tue, 8 Feb 2022
 12:39:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2ff12781-88dc-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644323981;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=qUg4Z+18MWNBPyCHUl0bmliqiMHtKhewRrEatLOvplk=;
	b=bGIX17ay69tHPkvciXrWt8jLlrlvv2yGKBTrLILygqHzceereTsUsayb3++HVKEEoNQFd+
	sA83ncyq7ZvCe9Y4T8gsufR3eTO6D7D7rZrllmeBWQ1qMKJ7F78qs20gjqPFFDn9pOki0A
	igrOnaw8RozN0Q4qU2+CJrbrN9mzySQ=
X-MC-Unique: _kk5Ur3ePym03TNQ-Kjjqw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=EI6QCqN9pUvBijcnC54ap1bQ14vc5XyuGPCyqY9M2iC9VPkBKxjWWEgzUWnf2LBUb2Wl54bgCJYI6ZET6IsP04DIAh7KRnUW6m/wk1NIHmYVo9druWGYGNOIaQMH2SNHZhIce5IjhHapiyuvjcjLYgVneB26XPtQDr1ZE4Kkp0gCd8gdBSY/4pEEoHwtgAOgdI8efSNG96UP2cHXM+/epEQzQjXFN0TQDxoNhfW8n5buyd9+62L5swyAiQe4L84SuEFMn6fJDps8ELgaX4QHSKjMNUP94xQR8wz6cc6RXoucZrhGmp0Ef9DFwwTR2yYp7YWBS73k6k+3lsyIfaSOcw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=oCqdjoxFrAnSbptkGHXt0/OVQ7dmwSJ7vwG0LLge2lI=;
 b=FPM8W+TUXLgfKMbfUgEd/Pj/voXgBY9xc77xXzpKAdDFO7nfTWyGms2HVdXedYEPfWbGwQt+k7TfVwVACD2E7StJK2aOZe/7zgpKOlORvXL8rUSgnTuxGZkwQQEao+XVXohKj65npJDSe08b1EYwuFvBdCrCXNGP6ATmk+mtOKaSxTO7uPbpDMGKwhzv+dyXFlUCUmnTBlZBNO0e3olYfBqbz9kwKux9MmYHRGrIOqvwiN1+ElEoPHgmXgmaz9hpSlza0Kmq+1Nb3FjDo8AHxJ9xCK05PQtSw+n6neuumkscIr7DaUki9jvrdQLkHvYwhAAbKx0eLKc7C05234uZxg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <a988a920-ed19-171a-ec60-6b32e8b2f593@suse.com>
Date: Tue, 8 Feb 2022 13:39:35 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v2] xen/public: add comment to struct
 xen_mem_acquire_resource
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>
CC: George Dunlap <George.Dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Andrew Cooper <Andrew.Cooper3@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <20220208074230.7901-1-jgross@suse.com>
 <ed7424c3-e54c-4c65-03c6-57f9ddd182bc@citrix.com>
 <bcdb29f3-164c-03ea-1b48-4328f75778b1@suse.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <bcdb29f3-164c-03ea-1b48-4328f75778b1@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0315.eurprd06.prod.outlook.com
 (2603:10a6:20b:45b::26) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 8d0c9fa9-c68c-48e2-bf0b-08d9eb0011c9
X-MS-TrafficTypeDiagnostic: DB7PR04MB4090:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<DB7PR04MB4090D7C88E5DF334CF91ECACB32D9@DB7PR04MB4090.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	EEKm7vx1ICYA6QyZgf999qKS2yzQ1Mw2Nt6iDvlMEtDnhEtOBOfwdiVIk1HUyu0Lq7kuLIwG10EZUsqlC9Bu/9JttXcRaZB8o6X7WM+IyR8jwRFlPo3hUokHIzm5YnQk0qikaMAhBMliAARkj4fi1O1F0ENGBuB4m1JrU/3km/gs5nFSm990+vOq3uZ3BhmWEi1mKdf3FuMgtyozrJub7fWARfJwdwmO0fUe/GJ9DBFebsFkX/M9D5D/i5zJTcnLUta+HZ6as38noP8lsu01eT8rRqAf01tWxuPhujEkfXiIR3xe14tHe6QXy4waJq1m3GstujWJ7MCrrCLS1/lOzEIHSCWKAOZRJpEpmmsyPYryb+bfsKL2FYvEtctwYL144C6OwdXEYT5xZyCrIDv2jn65GEv5oiLWb2vN3UbePK08uNTePgX7QKiSQGbIqVyGLodCktvEScjnsfttYUNxPMPpppcYsDorJvp4fI9KwPdydTzzM7oS1ZN3tIUq5Y/V2j1jiT4IzmYKoIxWNFvrYbmPVhbdnLmisYxkqZu8UUrIxnTd1yxHa0il3qkVq0omu/93+oGGPpgKny8Wi7CLQtt2ZHMq6bJ7QSRHuK9MrAvY5kRDlQoLsBbX5/5HK5zR8KVSGjH7T1pbQasl/JqmcU4S1DiQQqMk8YuNhNakfOckTwcUsagaTex9TP7iotkBPMPT7BOW+kPLy5uieGuNTI2H+db+9xhkMAWq2ZHThdc=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(31686004)(36756003)(6486002)(26005)(186003)(38100700002)(5660300002)(2616005)(4326008)(6862004)(8676002)(6506007)(508600001)(53546011)(66946007)(66476007)(2906002)(66556008)(37006003)(54906003)(6636002)(86362001)(31696002)(6666004)(8936002)(6512007)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?WgXt1NLtQcDdXz9L4Oj2afdWpMpL77GBL9HNnYD9fSYo2iLgdAlSVotKVc//?=
 =?us-ascii?Q?0ZY0/uw+0QlYbvfU/IdkNKyXxBJM632A0wHZ+RRuFmlCmImSaVFEbgb0/jpH?=
 =?us-ascii?Q?AMcepJAcYG5h7p0nTz8jmI6K9YpvSuwKih16klE+DbzamBEoWpvUNI2U+YOz?=
 =?us-ascii?Q?RlJkcUftqTz7icr9/dbKXiYL2giBXCvPba72jgevP95pVAuUYTiY3h+9kZuS?=
 =?us-ascii?Q?zWyhfMBfffg62eh3lmIxQ42Tx+2ejRDdA98cvzhbPXummMMoOsjmE3SIKSHq?=
 =?us-ascii?Q?h0hx6i9PJUBn/q20K+2QJNNlSGxUMY/NTRr5sjYUbf0d82iI8ksO6HdAyclK?=
 =?us-ascii?Q?6n8BNvMGlYVnwUh61LWF3qJYseyrNf9w0WJ+fv9SbV6S1B9kc089f6hubnVz?=
 =?us-ascii?Q?YEu1Y5swX9MOKXPKLagl/qWldP9ENoihdAG66cnUIgtZnmVvWTZgb+MPEoEW?=
 =?us-ascii?Q?zKjXF6cRjYiDtwI9716YTpJ6SuliwGpX8zXe0aE4ETX5qSYeuDQjfcALSooX?=
 =?us-ascii?Q?Zuob//RU9CZ1gCeGLDi5J8JfcRy6TkzcR+q/cuQagd3Rz07LSOtLEJJYMVYB?=
 =?us-ascii?Q?li3p+xLBQMH52ilE76WrbB5G0J9d4pGPMvE5RCvDIc4GRdBI4Mw1CfceEzdJ?=
 =?us-ascii?Q?F7meOdn8+1K73gm9EPzsoR2aIgnyB+LZJxpmy5T9Eq/WY3WsogNpdxgu1N10?=
 =?us-ascii?Q?HiRVT+kmCM4BDHi1Ukudzzj9dJ72T6ukA+Bst0ZbFhRiTLQBCL2/4f6yoWuJ?=
 =?us-ascii?Q?D/Ryv3DbS6HM7Ce1kPSua8dcisYx8EGHHb/2OMqLXTNCmrtTuixn3dxQ00gC?=
 =?us-ascii?Q?dj0sPB9WIlhW3HKaQoCQ5Cnj5n7TL3epEpxcnzfXoWHFS9bbfSNstEUcqsi9?=
 =?us-ascii?Q?IQ+tljKFwFcsOFDQ0u9y53n/KLNxa3lKyZPRcP3xzXRuR13iEstU55Vb8x7v?=
 =?us-ascii?Q?+1YkvjaHVBBku9X1IrXKV0Q8IxKiQna/AH+Y35cV4CX8wI/dOwBhhBrLPrZf?=
 =?us-ascii?Q?vGJ0qp6nOwEfQSIFLoswi9u5/1ieHXNx5+ckPybXyGCtkRrXV1bxUVCujp/F?=
 =?us-ascii?Q?X+1PS5JcmLeNxMD35nWTCNneD+v4FSpt9L0SH1Qqj/ETy0PgoAaj/+BfIlc6?=
 =?us-ascii?Q?PztBLDxYO49NJqriFW+7YfwM8L3TEx6BjPIBL2VSh73XVoj3+JLeb8IjVAUR?=
 =?us-ascii?Q?jlZXR4Y4EEATCkV9XG1kbF/yZq8JOmhM+TgcBXyFRm5aTRvmNkJFIb2L8FAR?=
 =?us-ascii?Q?S+316FyD9RQMkWawuPdhC4MbvoCD6bc2N6IkjeSHdJzesXMzmRPt4YGLS1k5?=
 =?us-ascii?Q?c1QxGW6m6/y4Wa6LUiioEB8rMXJY5I1z3xSKAHt8nHIiganfT5nddegb9lQ9?=
 =?us-ascii?Q?PN/Xtvuq/9A63w1qj/klmt0wxNVXKH6JjAVARh68YhjlcRkN0fGyuGiSBWDU?=
 =?us-ascii?Q?BDLiyb1ig4Hb/v/ebVriSqfQjIX40m6wPxlJlhOrY7o0YRm257dkEmsXtdxz?=
 =?us-ascii?Q?cjC0/IAFnhCMqQ6BlPMab6dt/aDvurQAJ49BPrbrGnLDENfPnwaOh4SwU0t0?=
 =?us-ascii?Q?o6+yX9sMcpIg4UlwKcTIna3L4jmjeOkmjGI8rWj5WTdyPKERnOyc/LYCZdnn?=
 =?us-ascii?Q?fPNCjtp7gt6GsmNW7LmdKp4=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8d0c9fa9-c68c-48e2-bf0b-08d9eb0011c9
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2022 12:39:38.3097
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jZu+DrflvDFjKQ3J+B0DKlk8hjIkmLz7SOwoguzwHekBws+PQVwoBGvRcyZlHk8BJNNbN8dVor8xUrdJrHNR+A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4090

On 08.02.2022 13:22, Juergen Gross wrote:
> On 08.02.22 12:55, Andrew Cooper wrote:
>> On 08/02/2022 07:42, Juergen Gross wrote:
>>> --- a/xen/include/public/memory.h
>>> +++ b/xen/include/public/memory.h
>>> @@ -662,6 +662,11 @@ struct xen_mem_acquire_resource {
>>>        * two calls.
>>>        */
>>>       uint32_t nr_frames;
>>> +    /*
>>> +     * Padding field, must be zero on input.
>>> +     * The lowest bit was named XENMEM_rsrc_acq_caller_owned in a prev=
ious
>>> +     * version and should not be reused in future.
>>
>> s/should/will/.=C2=A0 This is a statement of how Xen shall behave.
>=20
> Okay.
>=20
>> I think it's also worth somehow fitting in that it's an output only
>> bit.=C2=A0 It will be important when inevitably we end up changing this =
back
>> to being a flags field when we need to extend the hypercall.
>=20
> Okay.
>=20
> In the end the bit only needs to be reserved, if pad _is_ zero on input.
> So the correct way to phrase it would be:
>=20
> /*
>   * Padding field, must be zero on input.
>   * In a previous version this was an output field with the lowest
>   * bit named XENMEM_rsrc_acq_caller_owned. Future versions of this
>   * interface will not reuse this bit with the field being zero on
>   * input.
>   */
>=20
> Is this fine with you?

FWIW it is at least fine with me this way.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Feb 08 12:47:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 12:47:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268294.462094 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHPuQ-00086u-AM; Tue, 08 Feb 2022 12:47:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268294.462094; Tue, 08 Feb 2022 12:47:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHPuQ-00086n-6O; Tue, 08 Feb 2022 12:47:50 +0000
Received: by outflank-mailman (input) for mailman id 268294;
 Tue, 08 Feb 2022 12:47:49 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=v7zX=SX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nHPuP-00086h-IK
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 12:47:49 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 506a496d-88dd-11ec-8f75-fffcc8bd4f1a;
 Tue, 08 Feb 2022 13:47:46 +0100 (CET)
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur02lp2056.outbound.protection.outlook.com [104.47.5.56]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-35-gfVNdIKfPxWu83EWWUzh6g-1; Tue, 08 Feb 2022 13:47:46 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DB9PR04MB9281.eurprd04.prod.outlook.com (2603:10a6:10:36f::7) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Tue, 8 Feb
 2022 12:47:43 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.018; Tue, 8 Feb 2022
 12:47:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 506a496d-88dd-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644324467;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=iCBbFOX3XSv2fXeF6T6uIWsVPJ8VjM+e3i/x67RHhtw=;
	b=HJSJF/GPGRNWiW7+jVx+89ORMJZB1D8ZURc13b1zdGp/zctT3tcXERWTRE9YwAe2CEmjZE
	+YZlw+Wo/CalCHcDK5B3i46c6s0hysdAmHqWwyS2DOh09ZoGgEt49YMuUytmRie3yLVRJ2
	6YIeojETqLdKXizPd7ZnBq3yemSALJg=
X-MC-Unique: gfVNdIKfPxWu83EWWUzh6g-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=lR+FsVxZcpnIIvi3IQF1ROb3S2J0/mPcFuOaYJJCaSHPF0Oe0mT6k08WXjBNpOL21oGPX6KjY9PskbNQPU/GhqMsfCKi6v65IP9iPq7fJpmut6tdvIz2Dq660vqBpTJjvzVX5duSB+lfZJmM6L9oIbhCUudkFubyLb0Bq5LK95vTUMIEzmxQ1xCOo988cMzR/xeN4xRGcW9FD5+HNGmAeb20wpbarTNxk4rISlMs5Fbm2Q2DxxTd9rYySApaXmepA2HjA2Rd6HD/5EjdOc2nBHkZp03bUJgM/mT6OYfnnTzjhAOCQjKDtjjsxdq0WTZFlqpPXaC6ssCcly9l/LB7LQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=8pBqllCtNJpk2e1FOqL61YHvYU+BVKD7E6ETRNjMf/E=;
 b=R/k/dqYEuL1nUy+BZLBfxKDWVe889w4x+gkEcGrr/L1twP8xrHiap0w0M9/QxGkAR6r52ToJbc99DqulMKFsSyPF7rsQicF5VpfWBofVLqvdrV72RW49TB+AbuvH2Z8d6kUgamrLK4HtLU+9oYPHfNP2UykO8xaUWJWVgg0BxTquOGj5G5d+mZ5fMRGvugSWMVmtYDBfZyVE7lS9HSKLrM977ooXYSKWao7fhbZ8ssqBWnTQPEkzr/1u/k+QWa4V9SuXWDol6BMJe+TByY+7alTNJYD992vvKdQVmyG5A27U5SEoMp7dqHb3k6CpvHOaHLTJFCqT7IlE6KrY5S2m9w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <3629d57d-6d89-5ada-1664-cd532342fd0b@suse.com>
Date: Tue, 8 Feb 2022 13:47:40 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH V5] xen/gnttab: Store frame GFN in struct page_info on Arm
Content-Language: en-US
To: Julien Grall <julien@xen.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>
CC: Oleksandr Tyshchenko <olekstysh@gmail.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Bob Eshleman <bobbyeshleman@gmail.com>,
 Alistair Francis <alistair.francis@wdc.com>,
 Connor Davis <connojdavis@gmail.com>
References: <1641424268-12968-1-git-send-email-olekstysh@gmail.com>
 <a54213c4-1c68-694e-c130-d95faeef3953@xen.org>
 <78d94e1e-6db4-25c1-adb8-e4bdbfe42774@epam.com>
 <82d8bfe0-cb46-d303-6a60-2324dd76a1f7@xen.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <82d8bfe0-cb46-d303-6a60-2324dd76a1f7@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM5PR0101CA0013.eurprd01.prod.exchangelabs.com
 (2603:10a6:206:16::26) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7a879a7a-7c6c-4084-81b2-08d9eb0132d5
X-MS-TrafficTypeDiagnostic: DB9PR04MB9281:EE_
X-Microsoft-Antispam-PRVS:
	<DB9PR04MB92812161A04E71579AA21EE6B32D9@DB9PR04MB9281.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5516;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	+9fYObO3uXHuxYEZsu6DT0RlhMp4tcPhRaIFTzZZwOvAFeq6EvX+GVdMrVQh+lQQByxYlqbuf5W/H1rrpT6Lx/HG2ho3jjcgJ+EudPBqMuBpvMsPhxwYxnxw36ROf5OkNoJWq/2LNFmQ8HtPEWjbZjfOUv8DqqS4Jcjt6bhcPSgAhFD2Q9DRflF659rNHWcf8zEO8cKttd1y69Uw/T0U/phNyEZ2D8lEhKNjU2q4xRzh8pn2LbeaupH83LzbFC5ZzB8vDJx60mW3II3SpOLer3wzJGuEK7Xgd3q7zt0Jm4R2WNzvWbK0Aq5zVY1ZRl3EpY/kH5HUZc2ehH3w8nBw7CededNSMK2OelwcQuBo8mS+KG6YAbhPks8m/aB6NBW1wyjlvbifF6ZrKC6nD+CEvgsLgIrxTfP9v2FFmUbUuL4Lo0EcHfIfXogJKBBiHMIRtvE1FtjAg1y8V5mLwRCLbbUITC/0rRkRU8CEqRp5BHw+QQseX/hOKtS2ndDBCHBoVbKJUdS/szLh3wzvgdCrbxNM+mL7TYcAJNqNbm+f8aYDJ1nZZlaHDfmFcptsRcsRQ9jHJNO0zF7L/vOkr8AGG1jDmrx4jKwr2YXGb5j6uf0TdV59S/VICjy6UEzA5bj01R7iW8538c9qCbWludhyXrJKw/y/B2OMZWWs5rWs/oqvFtlhjTIvLndDwq1g8xUW9JjjZpXKNz8SnipOlsqvCyBsKBNlt+VxtGziXnuW37g=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(7416002)(6512007)(66476007)(110136005)(2616005)(31686004)(54906003)(316002)(36756003)(26005)(83380400001)(5660300002)(186003)(4326008)(53546011)(66556008)(66946007)(8936002)(8676002)(6486002)(508600001)(31696002)(2906002)(86362001)(38100700002)(6506007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?UKf2zKe2zUesEy2kNANTqppg0oDJSriv5idiDj2eFwK6jcecOz5atbqsYKSL?=
 =?us-ascii?Q?aQKYlbZwHOPK3KoTLUWuD2W8/VwYDMy3Wx+0dpOvBJKfGpRYjB4V9xhNHPjf?=
 =?us-ascii?Q?SxIBOE5oPXh4+1M/adZiLRf6G/ERzrwncRqN901mmXMI07qlWQTdugGhK2vv?=
 =?us-ascii?Q?WOOTNJy5HtCa46gxMTZlYVWjx0p1G44rD0lwExk9rXOMGwjF3/pZZmBH+gKB?=
 =?us-ascii?Q?MZozwd0EPuwX3cCGEayetnPQkB6bohHU2/iNvVNcLyoOkvogY5NdzPCJDyMP?=
 =?us-ascii?Q?QMf3EV4oCM5an81bxBLTiB918OiQESalj4KwO5kak1AC1cJNNlRMppNME0cq?=
 =?us-ascii?Q?HY04gwh6Ue3Pn9+k+bMnuuCNneHeVkB93wmdM87591oWnp896ZpsD/4dE8yw?=
 =?us-ascii?Q?0B3nZNN3f3maSErr4/fmaJzNS5V2UH4HJVBgK5ZNhJknZE9XMigHRvxGiu6g?=
 =?us-ascii?Q?uXCVLx/kIlb/XtVOJue55nWcx6FG7jQNrGOOvNXQ0FObNAq3/gdeatZ01jb6?=
 =?us-ascii?Q?7kCeF80fpyulCnxXs8y9TajbXINwEr0/fRJnZuOFdDKk65pe30Kthu/Pp7WY?=
 =?us-ascii?Q?1Wu7z37BBSlgcu6wM6Lcf3KXh7AO9G7jF8O2DvWn1QnjnbzxIDpUZXRB7jlb?=
 =?us-ascii?Q?xDQdxra2WK28UH5ygGUvM2EeVSsF0F/kf4XKtmVyZiEb0ArCWwNRvQupmaoz?=
 =?us-ascii?Q?MeRV36ZaIjdWMy7V4sm5DZz3ZliMKtMyqJRi1b2iOPWMTEuPcBHtGHl8OOhL?=
 =?us-ascii?Q?fKpK8MxBDTQE+KrmJBEIb9ePaCcLAwseKdmQNUBlQs+UaNyqh7QwmxCrjtLE?=
 =?us-ascii?Q?YXZ36YRRKtxRoD5KWOJM5PDPlF0oKwPukO9+82cgy6cOfVGEXCpF/AvZtUaP?=
 =?us-ascii?Q?vU/ZJJ1GvQjpynR+NSYQBgpbuJQ7Cnv4zEwKaf3uLYfnZ/fUOIRZILCDRCLq?=
 =?us-ascii?Q?vkAldIcArTE0z5ZSo2toySWFE7bFyCZjA3cbcmNM0gvHXjDjkE1p6x9EWMHY?=
 =?us-ascii?Q?NY2aSfWnn0mbtLdjNGNPmZIkxoyY75MTnI4oPRzRxLbLnejinoNuUjbt58ns?=
 =?us-ascii?Q?HYDh3Q2jyhPKVSj4X6zYtknB5aJxSpsHv+EJkoJdKJ4EydC5ZNYpF3TRQ1tH?=
 =?us-ascii?Q?d5e774WDRfRbHG96GT+DoSn2e2mDbmporUvyCiV7+M/q3uCK3zjT40W9Xs6m?=
 =?us-ascii?Q?pEg4XEwc0oZ99c6B49tdI4REm6AvIYvFq2tb1ivSB+scKTXo0PDLu+XH1J37?=
 =?us-ascii?Q?W9qhtIz0rzGI0GO+htyuvgs6j3kyk18bhyg9SRH/bIvAKHwFs5dp/iFmMoOQ?=
 =?us-ascii?Q?Q7W/aPqddrLK+rM9J81TLVIKtDWOzrKZUOxCAA5XL8lHrcMHO+HYrDrxfkIm?=
 =?us-ascii?Q?sqA8d70EuNOzNO826TLD2jV1eGgN7P/KkedWUcU7VRv4fuN/H3CM7OmWeMO5?=
 =?us-ascii?Q?ggbQJa5ruV2J99UpV++yqMtbj1rVNm4afpAMiUnJYpP+ReO+mGL39KOrXZ2r?=
 =?us-ascii?Q?bTCCG3o4ctDz6dXzrAPy4UDnvhW63Jy/AP+hb9pvyi5JqpvCT7Ayu//56OLQ?=
 =?us-ascii?Q?7g73EFiDmblqqNly1uBrK4uJsoZCF2NsHMIocu4uVtL3GhC9muSYYO2lCoXk?=
 =?us-ascii?Q?D4YG7CklwfHtpTmORJTTSrA=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7a879a7a-7c6c-4084-81b2-08d9eb0132d5
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2022 12:47:43.1702
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: upaw9ZDsAjlVngbTKvuJ5qnh/MnTLWoaQ4cIymb/6tOEU4YUt4UP9vCOTKRP1rMLox8zbqVirePx2EL8ZciJWQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9281

On 08.02.2022 12:58, Julien Grall wrote:
> On 07/02/2022 19:56, Oleksandr Tyshchenko wrote:
>> On 07.02.22 19:15, Julien Grall wrote:
>>> Hi Oleksandr,
>>> On 05/01/2022 23:11, Oleksandr Tyshchenko wrote:
>>>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>>>
>>>> Rework Arm implementation to store grant table frame GFN
>>>> in struct page_info directly instead of keeping it in
>>>> standalone status/shared arrays. This patch is based on
>>>> the assumption that grant table page is the xenheap page.
>>>
>>> I would write "grant table pages are xenheap pages" or "a grant table
>>> page is a xenheap page".
>>>
>>> [...]
>>>
>>>> diff --git a/xen/arch/arm/include/asm/grant_table.h
>>>> b/xen/arch/arm/include/asm/grant_table.h
>>>> index d31a4d6..d6fda31 100644
>>>> --- a/xen/arch/arm/include/asm/grant_table.h
>>>> +++ b/xen/arch/arm/include/asm/grant_table.h
>>>> @@ -11,11 +11,6 @@
>>>>  =C2=A0 #define INITIAL_NR_GRANT_FRAMES 1U
>>>>  =C2=A0 #define GNTTAB_MAX_VERSION 1
>>>>  =C2=A0 -struct grant_table_arch {
>>>> -=C2=A0=C2=A0=C2=A0 gfn_t *shared_gfn;
>>>> -=C2=A0=C2=A0=C2=A0 gfn_t *status_gfn;
>>>> -};
>>>> -
>>>>  =C2=A0 static inline void gnttab_clear_flags(struct domain *d,
>>>>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0 unsigned int mask, uint16_t
>>>> *addr)
>>>>  =C2=A0 {
>>>> @@ -46,41 +41,12 @@ int replace_grant_host_mapping(unsigned long
>>>> gpaddr, mfn_t mfn,
>>>>  =C2=A0 #define gnttab_dom0_frames() \
>>>>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 min_t(unsigned int, opt_max_grant_fram=
es, PFN_DOWN(_etext -
>>>> _stext))
>>>>  =C2=A0 -#define gnttab_init_arch(gt) \
>>>> -({ \
>>>> -=C2=A0=C2=A0=C2=A0 unsigned int ngf_ =3D
>>>> (gt)->max_grant_frames;=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \
>>>> -=C2=A0=C2=A0=C2=A0 unsigned int nsf_ =3D
>>>> grant_to_status_frames(ngf_);=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
 \
>>>> - \
>>>> -=C2=A0=C2=A0=C2=A0 (gt)->arch.shared_gfn =3D xmalloc_array(gfn_t,
>>>> ngf_);=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \
>>>> -=C2=A0=C2=A0=C2=A0 (gt)->arch.status_gfn =3D xmalloc_array(gfn_t,
>>>> nsf_);=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \
>>>> -=C2=A0=C2=A0=C2=A0 if ( (gt)->arch.shared_gfn && (gt)->arch.status_gf=
n
>>>> )=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0 \
>>>> - { \
>>>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 while ( ngf_--
>>>> )=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \
>>>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (g=
t)->arch.shared_gfn[ngf_] =3D
>>>> INVALID_GFN;=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \
>>>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 while ( nsf_--
>>>> )=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \
>>>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (g=
t)->arch.status_gfn[nsf_] =3D
>>>> INVALID_GFN;=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \
>>>> - } \
>>>> - else \
>>>> - gnttab_destroy_arch(gt); \
>>>> -=C2=A0=C2=A0=C2=A0 (gt)->arch.shared_gfn ? 0 :
>>>> -ENOMEM;=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \
>>>> -})
>>>> -
>>>> -#define gnttab_destroy_arch(gt) \
>>>> -=C2=A0=C2=A0=C2=A0 do { \
>>>> - XFREE((gt)->arch.shared_gfn); \
>>>> - XFREE((gt)->arch.status_gfn); \
>>>> -=C2=A0=C2=A0=C2=A0 } while ( 0 )
>>>> -
>>>>  =C2=A0 #define gnttab_set_frame_gfn(gt, st, idx, gfn,
>>>> mfn)=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \
>>>> ({ \
>>>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 int rc_ =3D
>>>> 0;=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0 \
>>>>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 gfn_t ogfn =3D=
 gnttab_get_frame_gfn(gt, st,
>>>> idx);=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \
>>>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if ( gfn_eq(ogfn, INVALID_=
GFN) || gfn_eq(ogfn, gfn)
>>>> ||=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \
>>>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0 (rc_ =3D guest_physmap_remove_page((gt)->domain, ogfn,
>>>> mfn,=C2=A0=C2=A0 \
>>>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 0)) =3D=3D 0
>>>> )=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0 \
>>>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ((=
st) ?
>>>> (gt)->arch.status_gfn=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \
>>>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 : (gt)->arch.shared_gfn)[idx] =3D
>>>> (gfn);=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \
>>>> - rc_; \
>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (!gfn_eq(ogfn, INVALID_GFN=
) && !gfn_eq(ogfn,
>>>> gfn))=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0 \
>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ? guest_physmap_remo=
ve_page((gt)->domain, ogfn, mfn,
>>>> 0)=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \
>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 :
>>>> 0;=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \
>>>
>>> Given that we are implementing something similar to an M2P, I was
>>> expecting the implementation to be pretty much the same as the x86
>>> helper.
>>>
>>> Would you be able to outline why it is different?
>>
>> Being honest, I didn't think about it so far.=C2=A0 But, I agree with th=
e
>> question.
>>
>> It feels to me that Arm variant can now behave as x86 one (as
>> xenmem_add_to_physmap_one() now checks for the prior mapping), I mean to
>> use INVALID_GFN as an indication to remove a page.
>>
>> What do you think?
>=20
> I will defer that to Jan.
>=20
> Jan, IIRC you were the one introducing the call to=20
> guest_physmap_remove_page(). Do you remember why the difference between=20
> x86 and Arm were necessary?

The code was different before, and Arm's behavior was also different.
Hence the two functions couldn't be quite similar. If Arm behavior is
now converging with x86'es, the functions becoming more similar is
not entirely unexpected.

>>>> @@ -358,6 +371,25 @@ void clear_and_clean_page(struct page_info *page)=
;
>>>>  =C2=A0 =C2=A0 unsigned int arch_get_dma_bitsize(void);
>>>>  =C2=A0 +static inline gfn_t page_get_xenheap_gfn(const struct page_in=
fo *p)
>>>> +{
>>>> +=C2=A0=C2=A0=C2=A0 gfn_t gfn_ =3D _gfn(p->u.inuse.type_info & PGT_gfn=
_mask);
>>>> +
>>>> +=C2=A0=C2=A0=C2=A0 ASSERT(is_xen_heap_page(p));
>>>> +
>>>> +=C2=A0=C2=A0=C2=A0 return gfn_eq(gfn_, PGT_INVALID_XENHEAP_GFN) ? INV=
ALID_GFN : gfn_;
>>>> +}
>>>> +
>>>> +static inline void page_set_xenheap_gfn(struct page_info *p, gfn_t gf=
n)
>>>> +{
>>>> +=C2=A0=C2=A0=C2=A0 gfn_t gfn_ =3D gfn_eq(gfn, INVALID_GFN) ? PGT_INVA=
LID_XENHEAP_GFN
>>>> : gfn;
>>>> +
>>>> +=C2=A0=C2=A0=C2=A0 ASSERT(is_xen_heap_page(p));
>>>> +
>>>> +=C2=A0=C2=A0=C2=A0 p->u.inuse.type_info &=3D ~PGT_gfn_mask;
>>>> +=C2=A0=C2=A0=C2=A0 p->u.inuse.type_info |=3D gfn_x(gfn_);
>>>> +}
>>>
>>> This is not going to be atomic. So can you outline which locking
>>> mechanism should be used to protect access (set/get) to the GFN?
>>
>>
>> I think, the P2M lock.
>=20
> Ok. So, looking at the code, most of calls to page_get_xenheap_gfn() are=
=20
> not protected with the p2m_lock().
>=20
> (Jan please confirm) If I am not mistaken, on x86, a read to the M2P is=20
> not always protected. But they have code within the P2M lock to check=20
> any difference (see p2m_remove_page()). I think we would need the same,=20
> so we don't end up to introduce a behavior similar to what XSA-387 has=20
> fixed on x86.

Yes, this matches my understanding.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Feb 08 13:27:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 13:27:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268309.462104 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHQX1-0003rU-Ng; Tue, 08 Feb 2022 13:27:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268309.462104; Tue, 08 Feb 2022 13:27:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHQX1-0003rN-Kb; Tue, 08 Feb 2022 13:27:43 +0000
Received: by outflank-mailman (input) for mailman id 268309;
 Tue, 08 Feb 2022 13:27:41 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mkaY=SX=citrix.com=Jane.Malalane@srs-se1.protection.inumbo.net>)
 id 1nHQWz-0003rH-Jd
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 13:27:41 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e178141e-88e2-11ec-8eb8-a37418f5ba1a;
 Tue, 08 Feb 2022 14:27:39 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e178141e-88e2-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644326858;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=Y3vyjGmOZne3/GeAe6z9lN/7bVMLGOOhguo1PRsgLmA=;
  b=Uz5Bc0lys4/HzAK6WqcRSbH/dTkQrT9rTd5mKeoJ6yUHttqP0Fvj68ub
   vgEP5liaafKDSWgx10TFQzt/TmpSNbI4M8geGG6Uxg+zx0bNgZxYRPCTo
   AGH7cb+RUAostSfEqiBs4T3tttbkToMqpFr1HSmN/w25sh3aZ5hPMblV5
   o=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: 4lE400Ip5bVwgrbuvD9CpygLmbBZWmg1SZ5pveTHLEamln4hSMQPDPzFKw2KzVyLo3i8Fdlpjp
 D9SmfjQL9EuB/6W3kKgpeiWLZYsqpX1onpHQfxM4QQ6O5DUIDvQ+Fw5ufBHnLXvAsTdKdNzWAX
 WjWvpbjmAhL0qDSdyVU9pZJXWEAUdTauI798p8ErgvV9++znpk5SsrItoaLzEDQ8ywANh/Bfun
 N7HH/l5oUdzx3cogriUXNcU6k9+vXPROwgPmxfOU/o3nKgDO9HyzfdddAVS1FcwwdZ68BFpJ9b
 vNl7/OQeqg1o8/XK8n7KjSQK
X-SBRS: 5.1
X-MesageID: 65944017
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:kamsBKBHQasiMRVW/23lw5YqxClBgxIJ4kV8jS/XYbTApDMjgWRWz
 jcaW23TOPiLMTSkc49waYix80IE756DnIcwQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMo/u1Si6FatANl1ElvU2zbue6WL6s1hxZH1c+En970UI7wobVv6Yz6TSHK1LV0
 T/Ni5W31G+Ng1aY5UpNtspvADs21BjDkGtwUm4WPJinj3eH/5UhN7oNJLnZEpfNatI88thW5
 Qr05OrREmvxp3/BAz4++1rxWhVirrX6ZWBihpfKMkQLb9crSiEai84G2PQghUh/tDuisMAr0
 /R3qL/vWwsvHZLPvto7TEwNe81+FfUuFL7vJHG+tYqYzlHccmuqyPJrZK00FdRGoKAtWzgIr
 KFGbmBWBvyAr7veLLaTaOBqi4IGJc3iOIoZt1lrzC3DDOZgSpfGK0nPzYEFjWts3pkRdRrYT
 41ENShWQE7wWBpkOnYMK7Uup+KygXaqJlW0r3rK/PFqsgA/1jdZ3LHzPfLPd9eNRMETmVyXz
 krd5HjwCBweMN2ZyBKG/2iqi+uJmjn0MKoCGbv9+vN0jVm7wm0IFAZQRVa9ueO+iEO1R5RYM
 UN80hQpqa8+5Um6VO7XVhezoGOHlhMEUt8WGOo/gCmSzoLE7gDfAXILJhZDYtE7sM49RRQxy
 0SE2djuAFRHsqCRSH+b3qeZq3W1Iyd9BW0NfygfViMe/sLu5oo0i3ryos1LSfDvyIevQHepn
 m7M/HNWa6gvYdAj6KuQ0kCdmBOWu7uWXAIzxTrUeFyD8VYsDGK6XLCA5V/e5PdGCY+WSFido
 XQJ8/SjAPAy4YKlz3LUHrhUdF29z7PcaWCH3wYzd3U032n1oxaekZZsDCaSzauDGuINYnfXb
 UDaomu9D7cDbSLxPcebj29cYvnGLJQM9/y4DJg4jfIUO/CdkTNrGwk0NCatM5jFyhRErE3GE
 c7znTyQJXgbE7976zG9Wv0Q17Qmrghnmz+PHMGilkr2i+PFDJJwdVviGAHfBt3VEYve+FmFm
 zqhH5fiJ+pjvB3WPXCMrN97waEiJnknH5Hmw/G7hcbYSjeK7FoJUqeLqZt4ItQNt/0Myo/go
 yHsMmcFmQGXrSCWdm2iNCs5AJuxBskXkJ7OFXF1Vbpe8yN4OtjHAWZ2X8ZfQITLA8Q5laEtF
 KReK5zbahmNIxyekwkggVDGhNUKXDyghB6UPjrjZz46fpV6QBfO9MOidQzqnBTixALt3Sfni
 7H/hA7dX7QZQAFuUJTfZP61lgvjtnkBguNiGUDPJ4ALKknr9YFrLQ33j+M2fJ5QeUmSmGPC2
 lbEGwocqMnMv5QxrIvDi5ebotr7COB5BEdbQTXWtO7kKSnA82O/6oZcS+LULyvFXWb59fz6N
 +VYxv3xKtMdm1NOv9YuGrpn1/tmtdDuu6Vb3kJvG3CSNwanDbZpI3+n28hTt/ISmu8F6FXuA
 k/Wo4tUI7SEPs/hAWU9Hgt9Y7TRz+wQlxnT8e8xfBfw6hho8efVSk5VJRSN1nBQdeMnLIM/z
 O49k8cK8Ajj2AEyO9OLgy0IpWSBKnsMD/cuup0AWdK5jwMqzhdJYIDGCz+w65aKMo0ePk4vK
 z6SpazDm7UDmRaSLyttTSDAjbhHmJADmBFW11tTdV2Gl+3MiuIzwBAMoy88SR5Yz0kf3u9+U
 oSx25aZ+UlaE+9UufV+
IronPort-HdrOrdr: A9a23:ipsCPKwmkk6V3KwCBDXfKrPxgeskLtp133Aq2lEZdPULSKOlfp
 GV8MjziyWYtN9IYgBcpTiBUJPwJE81bfZOkMYs1MSZLXXbUQyTXc9fBOrZsnHd8kjFmNK1up
 0QCpSWZOeAbmSSyPyKmjVQcOxQgeVvkprY/ds2pk0FJWoBCsFdBkVCe32m+yVNNVJ77PECZf
 6hD7981lydkAMsH6OG7xc+Lor+juyOsKijTQ8NBhYh5gXLpyiv8qTGHx+R2Qpbey9TwJ85mF
 K10zDR1+GGibWW2xXc32jc49B9g9360OZOA8SKl4w8NijssAC1f45sMofy/wzd4dvfqmrCou
 O85yvIDP4DrE85uVvF5ycF7jOQlQrGLUWSkGNwz0GT+fARDwhKdPapzbgpDCcxrXBQ5u2UmZ
 g7rl6xpt5ZCwjNkz/64MWNXxZ2llCsqX5niuILiWdDOLFuI4O5gLZvtX+9Kq1wVB4SKbpXZd
 VGHYXZ/rJbYFmaZ3fWsi1mx8GtRG06GlODTlIZssKY3jBKlDQhpnFoifA3jzMF7tYwWpNE7+
 PLPuBhk6xPVNYfaeZ4CP0aScW6B2TRSVbHMX6UI17gCKYbUki94aLf8fEw/qWnaZYIxJw9lN
 DIV05Zr3c7fwb0BciHzPRwg2bwqaWGLEPQI+1llutEU4zHNc7W2He4OSATeuOb0ociPvE=
X-IronPort-AV: E=Sophos;i="5.88,352,1635220800"; 
   d="scan'208";a="65944017"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=J9o+HWAsIEbk0hkt8LjJHrOxC0/w5L8oUwiEnN7Uj3TbAeG1Qmwsb56XnlvoTipJUUMaV7b6F7VmASgH+2g38u45z1N9H5x6brIKJ6g0Nzf0+ZF1/YEJhIiuFQXWTHd7coWDk29XWK9JLmsgW0kLXuPNTzku2oc5+q2jsqIt1dh27DfWwdJKaNLvMpxs05LTqLIwZzXmx6jv/hyLUcGhrw2Q+D1x0XcX23vj7K1qCh8CHSUfvrwZPPar/w+EKUqPXMH31d8fPusyeLTVQFLg9ZFCs00m5k5NGLRzq7rUM+9Mh237MbkkHCWt/TNXbLGclH6Rl3eC5ioP9a8RKWn1nA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Y3vyjGmOZne3/GeAe6z9lN/7bVMLGOOhguo1PRsgLmA=;
 b=WQrqUrCFpW/w9Fhy+h+Mvh9sRaN+iDCxsO1+YtOgqaGFRUDDX3+Mr99kWvXXWDmNg7j+Mbu1muK56CbRWsckCRXQ9/8sC+MGej1knyk4X5Bq8yt4rlBAwVTMQKtizqqjRw7HxgaM8Xm0zUMcpKvcQBfWT9SZm942/n9PsMDVvux8S3yO0KhtFdFENMyX7STB1J0GEMBkL6dS72Jm99YUHCllkGJRApY7sWneJHzvA/uOrNwpCLWmn/0zSVRCRymhIP/wL927Hr94iGriYkKDIlZNu4Q8mNnYkKcUbXlAHYdiJxohat7rxJl/YuOX2E0rIIcYuIUMzJrqrWCYZ6448A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Y3vyjGmOZne3/GeAe6z9lN/7bVMLGOOhguo1PRsgLmA=;
 b=e2R2PkLx5/TFbjcsqDoFWSVdWDjW6BO1md6A6PVZ6KTqls/+1kYZjvbhShMpwBpxLSfeBNRuSVTPMb9eoW2BGhg+Bzi40pwYNyk9fnR7gaBktDLgCts4veOw1HRwcmkhAm/qkIbce8uHK80Q1WowlJQUai2DMuXaGRbCJJp9Csc=
From: Jane Malalane <Jane.Malalane@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Wei Liu <wl@xen.org>, Anthony Perard <anthony.perard@citrix.com>, "Juergen
 Gross" <jgross@suse.com>, Andrew Cooper <Andrew.Cooper3@citrix.com>, "George
 Dunlap" <George.Dunlap@citrix.com>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Christian Lindig
	<christian.lindig@citrix.com>, David Scott <dave@recoil.org>, "Volodymyr
 Babchuk" <Volodymyr_Babchuk@epam.com>, Roger Pau Monne
	<roger.pau@citrix.com>, Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 2/2] x86/xen: Allow per-domain usage of hardware
 virtualized APIC
Thread-Topic: [PATCH 2/2] x86/xen: Allow per-domain usage of hardware
 virtualized APIC
Thread-Index: AQHYE5eVWWLwfSz8JEi35sISHqV9YKx9DnUAgAypmgA=
Date: Tue, 8 Feb 2022 13:27:33 +0000
Message-ID: <a4af7c49-99af-b66a-a05f-2907fa6d50f1@citrix.com>
References: <20220127160133.11608-1-jane.malalane@citrix.com>
 <20220127160133.11608-3-jane.malalane@citrix.com>
 <8b59b7d7-2d0a-0b8a-f936-1e537dfc4f9a@suse.com>
In-Reply-To: <8b59b7d7-2d0a-0b8a-f936-1e537dfc4f9a@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: bd06a2f2-c8ed-4147-c015-08d9eb06c3b4
x-ms-traffictypediagnostic: DM5PR03MB2540:EE_
x-microsoft-antispam-prvs: <DM5PR03MB25401559309EF2B9CF2C02CC812D9@DM5PR03MB2540.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:7219;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: GyUhCtKWZY8pWGUuW+kkl6esB7age8Yx80FJXQhWQSFZDx+/iZPL2Nfd/uBW/VPoNq1QukMVkU5gG4rdMHOBk1q7UTt1FupXf/q4rP4CUeZfKMpf6qUzq8mQ1JYK1DtP2+dvcwQqgceo/S8RcF/kKHkGqJ0P8HboRZ4Q8ufC2HqRB78lTwzYLzw2d+ZiUBYBLKcFdudh/IxuH+0wfm7pCaGFWDw+TLVRLr0lFHZh9lh/yzobLTZ+1HcOEstXFFCIAdClHG9Q/P0WyK9jb4e7DU17iQ36cXA7HDnath02Nw2ay71R46KTeHT8SrwAlvuzf6NNDXiihH1W8yZXnqvZJRGtNXDvpN5eSz12ZjMYEuFJ+NmS8Xcc7lOa+kZdCkWqWC+mqC8u88haLSQRseyJ9+PIxm4KiMRfMRscrPpZqTOA2N9QceMnwiJ4SIGoHEmPaqIVGVjayN9cuULF8KS7fXa46EpBXM8fPdEKXDY/LoRWbRtSJKAslDcwAOlyV/d6n8ipjuzJ9wCylkBL0t94ah1B3KyQ236z0wyBHhru+lJwKmdX2fo9Hqs8gceoJq4kzRd86B3StIJMv0w1Gi7eG/notErlpmTfoR+7DwdIXCzN1Ozu6fhxcvPZcIf4o7YmkFncxiSqnjVb18pYLNv2lWgMVUWmZxj6avt18YRsBoJw33gvw9TjBFym09AZ1Dt+7sVFBzislrc7K7X1FFLNOTKUb8R9WqX9l55P5WjyUUo=
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR03MB3386.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(508600001)(86362001)(31696002)(8936002)(6486002)(6512007)(6506007)(31686004)(66556008)(66446008)(66476007)(8676002)(64756008)(83380400001)(4326008)(53546011)(91956017)(5660300002)(316002)(71200400001)(38070700005)(36756003)(6916009)(122000001)(82960400001)(2616005)(186003)(26005)(76116006)(54906003)(66946007)(2906002)(38100700002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?ODBBOW5Hb1VZZUpwc0xKMU5FTmw0cnBHSTNmSndTK0JSeEM3K0VPTzhlVEZU?=
 =?utf-8?B?R2dmaFJNaFVyQTRMMC9UV09vVDVJejdEWVBXcllsYjJlMzIzUXlWdW9Ub0RO?=
 =?utf-8?B?Qy9pQ3hidjdZTGRyRldBMHZndTFFQWVoQlNQQkdDRlVnVWdqdmpONE5BbzRs?=
 =?utf-8?B?WDkvU3gyU1NoYSt2bjQ0bTh1cVBha0lyRkFhdkcrS2JYZmRFMU1CZHFyblZ5?=
 =?utf-8?B?ZHI4bzhoUENEV1d3VytiUktuR1lSTkpZVDh1NGdoSkk3OU9FVHB3SmRjNjk3?=
 =?utf-8?B?ekN3eU1DV1dEbzVYTmpjSjJoWjN1VURYMzYzQWRyQ1NhYVRDZ1FubTlweHg2?=
 =?utf-8?B?QU5mNU9SQTVXakd4bFdocS8zemxxc0phdW9zUWxlODVIT1p0QzA5aFo4bm40?=
 =?utf-8?B?VHU5L052S3ZKYlBDZyt3clp3bHVDQVhSbkhjTkRob0JmRE9CTTAzYWswcmxs?=
 =?utf-8?B?QVFPcUxncEUwZ0p6ZXhaczdmMU1SZVpKQTN0OW1IdkM3bTVqUGVveFdrQnYy?=
 =?utf-8?B?Qy90WFNrWVJPTk8yV0lRdFBkZDE1cHhyNCt1b1F3Y1ptSTliNndjVDZrZmw5?=
 =?utf-8?B?d01HWWtnWTBRaW9FVEV2WG1ua2Z6ZjRDMmplZWtqVmkzRFBheXJkanlhWnRZ?=
 =?utf-8?B?cTZHa0FBRHVBWTVRbG1KSC9VL29meWJQYVErY3N2UGlMOVg3SlRtdU5VeUdv?=
 =?utf-8?B?b2FyYWZqQ1VqdDBHNVZlMEFWZ0JwbzZ4TWhHU3Fxa0FwOFliajdmT2MwdmFv?=
 =?utf-8?B?K3R4VWh0M3gwSElaVURIUkZML0FlOHJXdW1IQkxCVEhickdQYW0waW0xTmZn?=
 =?utf-8?B?Z0VMb3RxcEN1RkkzRHB4elZzMkh0WkRTbFYya1MwdTlqekd6SVJ4OGNpSHZ4?=
 =?utf-8?B?SGZCbWNKSUlZVitBTThXSHdOL0d5NUJsU2tSY1lRNks0TjdPMVlaVkduSk5K?=
 =?utf-8?B?K21TOVY2YThsZGN1dERWMlBMRW9mcWxnUmkwckZNNEFQaCtVTjRsVkhvRm9h?=
 =?utf-8?B?SU95aWtwREJOeDJwL2U3bEJBRlRBMW9WQ0hCVGNpR0ZGb255bXRNd2lxU2dP?=
 =?utf-8?B?VUZ1S2F0Q3NwZ3NUeDloV0MwUmpsNHo0S0tRM0pFQnVlWE1QeU9HbFpUd3hF?=
 =?utf-8?B?TWYyazhQb09XZXhVcDdzWGJXTmY2SXMyaVRIMzIxbWk1S2IzMGpxNndkYlRx?=
 =?utf-8?B?VlA0NXVURkdkODBOV2xqNEZwSnAvSW04Y0VtNDlpc3RiNmlMaFJuTlJjdkhI?=
 =?utf-8?B?NlE4UVd1bUxrT2lVK3lDS0srVjRlWHVvU0U2OTI1Z05mNEc5Qm5mMFBNbEJv?=
 =?utf-8?B?RGE1S00zaEFURDlwWTJ0WndiMzJzR0ZBT2pWNjZlOGRhWDlFSS9XT2RSU0VG?=
 =?utf-8?B?M0JDT3JSejlCQ1lvbTZ6Zkg4cDd5V1o1b2NnUnhzYngwU1Q1amlpL1RRRXlH?=
 =?utf-8?B?UGt2bzNsODhxQkZHMktkNDVJZi9UcEFaNUk2dXJoMXphNzZOR05jek9WZFlo?=
 =?utf-8?B?NFFUWmZHNjd0cUVIaWJRMzd4dExrSDE2SkE4WnVIU3FRVmx2TC83SVVXQWo3?=
 =?utf-8?B?R21lUEtHWVBQOFNoTjRBSHREM2NmREdPNkNxUGw4WVJFQ0RKRlFVK1c4TGJJ?=
 =?utf-8?B?eWw0ZExmcnYrelREUUJQRmdsbWwxajMrcVFTR2hVM3p6c04vYTFvdDdudHdU?=
 =?utf-8?B?alR3SUx6ampZVEdiVWhjTm1lMTNaV1U1VVFjYitaN0hTT3Bka2FwWkdnSHFK?=
 =?utf-8?B?ZWdFWlh4bk1YWFp1aEdQMFcrYklqT2o4TldjMXRmMlJPR2IzSXE4eGVEZDh6?=
 =?utf-8?B?VzROYVEvelc4aDhhczVUcWcrSmRoeGp1NFVoVHB1amFReUY0b081ZWVGdXZr?=
 =?utf-8?B?K0p6ZnEvTVN0b0xlaUJJK3V4bzREQ0pHRjRJTVh6Z2g2dGhVL3pZcXA5czFJ?=
 =?utf-8?B?dUpsRGU3YStib29ZNERZOHpFYURNTXhZaTh5M0RzL1JTbXU0a05RUnUwVDYz?=
 =?utf-8?B?NjBjaHRvSTB6VDhydnlMYU0yVEg0RCsxakcvZzU5RitobmcvUm5HMlRBNkIy?=
 =?utf-8?B?QWF6bFlNYm9PZXVzTzY0L0l0YlZBVS9LUnN0WGlONlphY0gvTFpuM3ZXd2Ry?=
 =?utf-8?B?c0ltalhIc0xYYzJNVktVVlNqZFhoOXJvblE4UU12WG1TVVV2eGRKdEFTVzVj?=
 =?utf-8?B?Ty9qeC9jdDVFWHI5VlF1SHJjUURHNGZtaTZnTDJaZ0g5ZFp3Q0FSMU5Qd0JS?=
 =?utf-8?Q?OlHkssrI2x7WT0A8vuZ4fABMf3mEiOvdh2O2REU7NA=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <D310818BFE2F96489D03751F7FC9D8EE@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM5PR03MB3386.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bd06a2f2-c8ed-4147-c015-08d9eb06c3b4
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2022 13:27:33.4744
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: yY6zdKjWvbC8EGG5J0qgVmfoqszbqfxwfPu9PzjBxemVhUkUw27QIzyCC75QMDjumnUz7z26Rz03B/6GColnKXCwueIAb08XAgoGRrvuKUY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2540
X-OriginatorOrg: citrix.com

T24gMzEvMDEvMjAyMiAxMjowNSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDI3LjAxLjIwMjIg
MTc6MDEsIEphbmUgTWFsYWxhbmUgd3JvdGU6DQo+PiBJbnRyb2R1Y2UgYSBuZXcgcGVyLWRvbWFp
biBjcmVhdGlvbiB4ODYgc3BlY2lmaWMgZmxhZyB0bw0KPj4gc2VsZWN0IHdoZXRoZXIgaGFyZHdh
cmUgYXNzaXN0ZWQgdmlydHVhbGl6YXRpb24gc2hvdWxkIGJlIHVzZWQgZm9yDQo+PiB4ezJ9QVBJ
Qy4NCj4+DQo+PiBBIHBlci1kb21haW4gb3B0aW9uIGlzIGFkZGVkIHRvIHhsIGluIG9yZGVyIHRv
IHNlbGVjdCB0aGUgdXNhZ2Ugb2YNCj4+IHh7Mn1BUElDIGhhcmR3YXJlIGFzc2lzdGVkIHZpdHVh
bGl6YXRpb24sIGFzIHdlbGwgYXMgYSBnbG9iYWwNCj4+IGNvbmZpZ3VyYXRpb24gb3B0aW9uLg0K
Pj4NCj4+IEhhdmluZyBhbGwgQVBJQyBpbnRlcmFjdGlvbiBleGl0IHRvIFhlbiBmb3IgZW11bGF0
aW9uIGlzIHNsb3cgYW5kIGNhbg0KPj4gaW5kdWNlIG11Y2ggb3ZlcmhlYWQuIEhhcmR3YXJlIGNh
biBzcGVlZCB1cCB4ezJ9QVBJQyBieSBydW5uaW5nIEFQSUMNCj4+IHJlYWQvd3JpdGUgYWNjZXNz
ZXMgd2l0aG91dCB0YWtpbmcgYSBWTSBleGl0Lg0KPiANCj4gVGhpcyBpcyBvZGQgdG8gcmVhZCBm
b3IgYSBwYXRjaCB3aGljaCBtYWtlcyBpdCBwb3NzaWJsZSB0byBfdHVybiBvZmZfDQo+IGFjY2Vs
ZXJhdGlvbi4gSW5zdGVhZCBpdCB3b3VsZCBiZSBpbnRlcmVzdGluZyB0byBrbm93IHdoYXQgcHJv
YmxlbXMNCj4geW91IGhhdmUgZW5jb3VudGVyZWQgbWFraW5nIGl0IGRlc2lyYWJsZSB0byBoYXZl
IGEgd2F5IHRvIHR1cm4gdGhpcyBvZmYuDQoNCkhpIEphbiwNCg0KQWZ0ZXIgc3BlYWtpbmcgdG8g
QW5kcmV3IGhlIHRvbGQgbWUgb2YgYSBwZXJmb3JtYW5jZSByZWdyZXNzaW9uIHRoYXQgd2FzIA0K
cmVwb3J0ZWQgc29tZSB0aW1lIGFnbyB3aGVuIGVuYWJsaW5nIGFwaWN2IHJlbGF0ZWQgdG8gdGhl
IHBhc3MtdGhyb3VnaCANCkxBUElDIHRpbWVyIG9mIGEgSFZNIGd1ZXN0IGNhdXNpbmcgWGVuIHRv
IGludGVyY2VwdCB0aGUgTEFQSUMgdGltZXIgTVNSLCANCm1ha2luZyBhbnl0aGluZyB0aGF0IHVz
ZXMgdGhlIExBUElDIHRpbWVyIGVuZCB1cCBzbG93ZXIgdGhhbiBpdCB3YXMgDQpiZWZvcmUuIFNv
LCBhZHJlc3NpbmcgeW91ciBjb21tZW50IGhlcmUsIG90aGVyIHRoYW4gbWVudGlvbmluZyBob3cg
YmVpbmcgDQphYmxlIHRvIGRpc2FibGUgYWNjZWxlcmF0aW9uIGZvciBhcGljdiBjYW4gYmUgdXNl
ZnVsIHdoZW4gdGVzdGluZyBhbmQgDQpkZWJ1Z2dpbmcsIGRvIHlvdSB0aGluayBpdCdzIHdvcnRo
IG1lbnRpb25pbmcgKGluIG1vcmUgZGV0YWlsKSB0aGF0IHRoaXMgDQpwZXJmIHByb2JsZW0gZXhp
c3RzLCBpbiB0aGUgY29tbWl0IG1lc3NhZ2UuDQoNClRoYW5rcywNCg0KSmFuZS4NCg0KPiANCj4+
IC0tLSBhL3hlbi9hcmNoL3g4Ni9odm0vdm14L3ZteC5jDQo+PiArKysgYi94ZW4vYXJjaC94ODYv
aHZtL3ZteC92bXguYw0KPj4gQEAgLTMzNDIsMTYgKzMzNDIsMTkgQEAgc3RhdGljIHZvaWQgdm14
X2luc3RhbGxfdmxhcGljX21hcHBpbmcoc3RydWN0IHZjcHUgKnYpDQo+PiAgIA0KPj4gICB2b2lk
IHZteF92bGFwaWNfbXNyX2NoYW5nZWQoc3RydWN0IHZjcHUgKnYpDQo+PiAgIHsNCj4+IC0gICAg
aW50IHZpcnR1YWxpemVfeDJhcGljX21vZGU7DQo+PiArICAgIGludCB2aXJ0dWFsaXplX3hhcGlj
X21vZGUsIHZpcnR1YWxpemVfeDJhcGljX21vZGU7DQo+IA0KPiBQbGVhc2Ugc3dpdGNoIHRvIGJv
b2wgYXMgeW91IHRvdWNoIGFuZCBleHRlbmQgdGhpcy4NCj4gDQo+PiAgICAgICBzdHJ1Y3Qgdmxh
cGljICp2bGFwaWMgPSB2Y3B1X3ZsYXBpYyh2KTsNCj4+ICAgICAgIHVuc2lnbmVkIGludCBtc3I7
DQo+PiAgIA0KPj4gKyAgICB2aXJ0dWFsaXplX3hhcGljX21vZGUgPSAoIGNwdV9oYXNfdm14X3Zp
cnR1YWxpemVfYXBpY19hY2Nlc3NlcyAmJg0KPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgIHYtPmRvbWFpbi0+YXJjaC5odm0uYXNzaXN0ZWRfeGFwaWMgKTsNCj4gDQo+IFBsZWFzZSBk
b24ndCBjbG9uZSB0aGUgYmFkIHVzZSBvZiBibGFua3MgaW1tZWRpYXRlbHkgaW5zaWRlIHBhcmVu
dGhlc2VzDQo+IGhlcmU7IGluc3RlYWQsIC4uLg0KPiANCj4+ICAgICAgIHZpcnR1YWxpemVfeDJh
cGljX21vZGUgPSAoIChjcHVfaGFzX3ZteF9hcGljX3JlZ192aXJ0IHx8DQo+PiAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgY3B1X2hhc192bXhfdmlydHVhbF9pbnRyX2RlbGl2ZXJ5
KSAmJg0KPj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjcHVfaGFzX3ZteF92aXJ0
dWFsaXplX3gyYXBpY19tb2RlICk7DQo+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
IGNwdV9oYXNfdm14X3ZpcnR1YWxpemVfeDJhcGljX21vZGUgJiYNCj4+ICsgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgdi0+ZG9tYWluLT5hcmNoLmh2bS5hc3Npc3RlZF94MmFwaWMgKTsN
Cj4gDQo+IC4uLiBzaW5jZSB5b3UncmUgdG91Y2hpbmcgdGhpcyBhbnl3YXksIHBsZWFzZSBjb25z
aWRlciBjb3JyZWN0aW5nDQo+IHRoZSBzdHlsZSB2aW9sYXRpb24gaGVyZS4NCj4gDQo+IEhvd2V2
ZXIgLSBkbyB5b3UgbmVlZCB0aGVzZSBleHByZXNzaW9ucyBhbnltb3JlPyBUaGUgcGVyLWRvbWFp
biBmaWVsZHMNCj4gY2FuIG9ubHkgYmUgc2V0IGlmIHRoZSByZXNwZWN0aXZlIENQVSBjYXBhYmls
aXRpZXMgZXhpdC4NCj4gDQo+PiAtLS0gYS94ZW4vYXJjaC94ODYvaW5jbHVkZS9hc20vaHZtL2Rv
bWFpbi5oDQo+PiArKysgYi94ZW4vYXJjaC94ODYvaW5jbHVkZS9hc20vaHZtL2RvbWFpbi5oDQo+
PiBAQCAtMTE3LDYgKzExNywxMiBAQCBzdHJ1Y3QgaHZtX2RvbWFpbiB7DQo+PiAgIA0KPj4gICAg
ICAgYm9vbCAgICAgICAgICAgICAgICAgICBpc19zM19zdXNwZW5kZWQ7DQo+PiAgIA0KPj4gKyAg
ICAvKiB4QVBJQyBoYXJkd2FyZSBhc3Npc3RlZCBlbXVsYXRpb24uICovDQo+PiArICAgIGJvb2wg
YXNzaXN0ZWRfeGFwaWM7DQo+PiArDQo+PiArICAgIC8qIHgyQVBJQyBoYXJkd2FyZSBhc3Npc3Rl
ZCBlbXVsYXRpb24uICovDQo+PiArICAgIGJvb2wgYXNzaXN0ZWRfeDJhcGljOw0KPj4gKw0KPj4g
ICAgICAgLyogaHlwZXJ2aXNvciBpbnRlcmNlcHRlZCBtc2l4IHRhYmxlICovDQo+PiAgICAgICBz
dHJ1Y3QgbGlzdF9oZWFkICAgICAgIG1zaXh0YmxfbGlzdDsNCj4gDQo+IFBsZWFzZSBmb2xsb3cg
aG93IGFkamFjZW50IGNvZGUgcGFkcyB0eXBlcyAvIG5hbWVzIGhlcmUuDQo+IA0KPj4gLS0tIGEv
eGVuL2FyY2gveDg2L3RyYXBzLmMNCj4+ICsrKyBiL3hlbi9hcmNoL3g4Ni90cmFwcy5jDQo+PiBA
QCAtMTExNSw3ICsxMTE1LDggQEAgdm9pZCBjcHVpZF9oeXBlcnZpc29yX2xlYXZlcyhjb25zdCBz
dHJ1Y3QgdmNwdSAqdiwgdWludDMyX3QgbGVhZiwNCj4+ICAgICAgICAgICBpZiAoICFpc19odm1f
ZG9tYWluKGQpIHx8IHN1YmxlYWYgIT0gMCApDQo+PiAgICAgICAgICAgICAgIGJyZWFrOw0KPj4g
ICANCj4+IC0gICAgICAgIGlmICggY3B1X2hhc192bXhfYXBpY19yZWdfdmlydCApDQo+PiArICAg
ICAgICBpZiAoIGNwdV9oYXNfdm14X2FwaWNfcmVnX3ZpcnQgJiYNCj4+ICsgICAgICAgICAgICAg
di0+ZG9tYWluLT5hcmNoLmh2bS5hc3Npc3RlZF94YXBpYyApDQo+PiAgICAgICAgICAgICAgIHJl
cy0+YSB8PSBYRU5fSFZNX0NQVUlEX0FQSUNfQUNDRVNTX1ZJUlQ7DQo+PiAgIA0KPj4gICAgICAg
ICAgIC8qDQo+PiBAQCAtMTEyNiw3ICsxMTI3LDggQEAgdm9pZCBjcHVpZF9oeXBlcnZpc29yX2xl
YXZlcyhjb25zdCBzdHJ1Y3QgdmNwdSAqdiwgdWludDMyX3QgbGVhZiwNCj4+ICAgICAgICAgICAg
Ki8NCj4+ICAgICAgICAgICBpZiAoIGNwdV9oYXNfdm14X3ZpcnR1YWxpemVfeDJhcGljX21vZGUg
JiYNCj4+ICAgICAgICAgICAgICAgIGNwdV9oYXNfdm14X2FwaWNfcmVnX3ZpcnQgJiYNCj4+IC0g
ICAgICAgICAgICAgY3B1X2hhc192bXhfdmlydHVhbF9pbnRyX2RlbGl2ZXJ5ICkNCj4+ICsgICAg
ICAgICAgICAgY3B1X2hhc192bXhfdmlydHVhbF9pbnRyX2RlbGl2ZXJ5ICYmDQo+PiArICAgICAg
ICAgICAgIHYtPmRvbWFpbi0+YXJjaC5odm0uYXNzaXN0ZWRfeDJhcGljICkNCj4+ICAgICAgICAg
ICAgICAgcmVzLT5hIHw9IFhFTl9IVk1fQ1BVSURfWDJBUElDX1ZJUlQ7DQo+IA0KPiBTYW1lIHJl
bWFyayBhcyBhYm92ZSAtIGNhbid0IHlvdSBub3cgdXNlIF9qdXN0XyB0aGUgcGVyLWRvbWFpbiBm
aWVsZD8NCj4gSW4gdGhpcyBsYXR0ZXIgb2YgdGhlIHR3byBjYXNlcyB0aGlzIHdvdWxkIHRoZW4g
YWxzbyBtZWFuIGJyaW5naW5nDQo+IHRoZSBDUFUgZmVhdHVyZSBjaGVja3MgaW4gbGluZSB3aXRo
IHdoYXQgdm14X3ZsYXBpY19tc3JfY2hhbmdlZCgpDQo+IGRvZXMgKGFzIGFsc28gcG9pbnRlZCBv
dXQgZm9yIHBhdGNoIDEpLiBBbGJlaXQgaXQgbWlnaHQgYmUgYmVzdCB0bw0KPiBoYXZlIGEgcHJl
cmVxIHBhdGNoIGZpeGluZyB0aGUgaXNzdWUsIHdoaWNoIGNvdWxkIHRoZW4gYmUgYmFja3BvcnRl
ZC4NCj4gDQo+IEphbg0KPiANCj4gDQo=


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 13:29:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 13:29:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268316.462115 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHQZ4-0004RE-4J; Tue, 08 Feb 2022 13:29:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268316.462115; Tue, 08 Feb 2022 13:29:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHQZ4-0004R7-19; Tue, 08 Feb 2022 13:29:50 +0000
Received: by outflank-mailman (input) for mailman id 268316;
 Tue, 08 Feb 2022 13:29:48 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=4202=SX=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1nHQZ2-0004R0-Kl
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 13:29:48 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id 2ef59a1c-88e3-11ec-8eb8-a37418f5ba1a;
 Tue, 08 Feb 2022 14:29:47 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 64BD02B;
 Tue,  8 Feb 2022 05:29:46 -0800 (PST)
Received: from [10.57.2.83] (unknown [10.57.2.83])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8DB293F70D;
 Tue,  8 Feb 2022 05:29:45 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2ef59a1c-88e3-11ec-8eb8-a37418f5ba1a
Subject: Re: [PATCH] tools/configure.ac: Replace macro AC_HELP_STRING
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: xen-devel@lists.xenproject.org, Wei Liu <wl@xen.org>
References: <20220201170321.32510-1-michal.orzel@arm.com>
 <Yflwk30RLgUWECFF@perard>
From: Michal Orzel <michal.orzel@arm.com>
Message-ID: <15a04228-1355-bf76-eb51-cf7124d7a2f9@arm.com>
Date: Tue, 8 Feb 2022 14:29:32 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <Yflwk30RLgUWECFF@perard>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

Hi Anthony.

On 01.02.2022 18:40, Anthony PERARD wrote:
> On Tue, Feb 01, 2022 at 06:03:21PM +0100, Michal Orzel wrote:
>> ... with AS_HELP_STRING as the former is obsolete according
>> to GNU autoconf 2.67 documentation.
>>
>> Signed-off-by: Michal Orzel <michal.orzel@arm.com>
> 
> Acked-by: Anthony PERARD <anthony.perard@citrix.com>
> 
> Thanks,
> 

I can see that this patch has not been yet merged. Can you do it?

Thanks,
Michal


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 13:32:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 13:32:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268323.462126 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHQbF-0005pk-GU; Tue, 08 Feb 2022 13:32:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268323.462126; Tue, 08 Feb 2022 13:32:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHQbF-0005pd-DW; Tue, 08 Feb 2022 13:32:05 +0000
Received: by outflank-mailman (input) for mailman id 268323;
 Tue, 08 Feb 2022 13:32:04 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nHQbE-0005pX-DH
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 13:32:04 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nHQbD-00009P-4K; Tue, 08 Feb 2022 13:32:03 +0000
Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nHQbC-0003ff-V4; Tue, 08 Feb 2022 13:32:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:
	References:Cc:To:Subject:From:MIME-Version:Date:Message-ID;
	bh=fCOKfLyYB9WvaT8PfEPO7Tfd/B8tF3dECzsUjhfvsvM=; b=A3YeuYYUZgymDgrsnCQ9Knd7yA
	tF81K49pJsgi3etKp2yI/ArYx/oWToJmLgODgkC3G3bFQpqN7RVCcUNgYhAp/AbeOt+D2cwq7BULd
	jwYrqDtKW98ZU7OZUhktoG3OfFAswaN6Ut4jxhPRQOfG37Ov6VwCeLba+J8TTXIBRRbU=;
Message-ID: <f7a83207-2b45-ebab-1d62-2e97b0042670@xen.org>
Date: Tue, 8 Feb 2022 13:32:00 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.1
From: Julien Grall <julien@xen.org>
Subject: Re: [PATCH] xen/efi: Use PrintErrMsg() rather than printk() in
 efi_exit_boot()
To: Jan Beulich <jbeulich@suse.com>
Cc: Julien Grall <jgrall@amazon.com>, xen-devel@lists.xenproject.org,
 Bertrand Marquis <Bertrand.Marquis@arm.com>,
 Stefano Stabellini <sstabellini@kernel.org>
References: <20220208105211.96727-1-julien@xen.org>
 <87559a9c-d459-e0df-cd89-6371f45870d2@suse.com>
In-Reply-To: <87559a9c-d459-e0df-cd89-6371f45870d2@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Jan,

On 08/02/2022 11:10, Jan Beulich wrote:
> On 08.02.2022 11:52, Julien Grall wrote:
>> From: Julien Grall <jgrall@amazon.com>
>>
>> The function efi_exit_boot() will be called within the UEFI stub. This
>> means printk() is not available will actually result to a crash when
>> called (at least on Arm).
>>
>> Replace the call to printk() with PrintErrMsg().
>>
>> Fixes: 49450415d6 ("efi: optionally call SetVirtualAddressMap()")
>> Signed-off-by: Julien Grall <jgrall@amazon.com>
> 
> I think it was intentional to use printk() here, so I'd like to ask
> for more details about the observed crash.
I have reproduced with the following diff:

diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c
index 8d65e9ce16ea..032e5ddf0c67 100644
--- a/xen/common/efi/boot.c
+++ b/xen/common/efi/boot.c
@@ -1089,6 +1089,8 @@ static void __init efi_exit_boot(EFI_HANDLE 
ImageHandle, EFI_SYSTEM_TABLE *Syste
      if ( EFI_ERROR(status) )
          PrintErrMesg(L"Cannot exit boot services", status);

+    printk("Test\n");
+
  #ifdef CONFIG_EFI_SET_VIRTUAL_ADDRESS_MAP
      for ( i = 0; i < efi_memmap_size; i += efi_mdesc_size )
      {


And got:

Using modules provided by bootloader in FDT
Xen 4.17-unstable (c/s Mon Feb 7 21:14:25 2022 +0000 
git:4ecd67a592-dirty) EFI loader


Synchronous Exception at 0x000000000026BAF8

This is pointing to:

42sh> addr2line -e xen-syms 0x000000000026BAF8 
 

/home/julien/works/upstream/xen/xen/arch/arm/early_printk.c:21

If I disable early printk it seems to work. Hmmm... I think this might 
be related to the issue I posted a few years ago [1].

> That's also to try to
> figure whether x86 would also be affected.

It looks like my x86 setup is not boot using xen.efi. I will need to 
configure it for more testing.

> The problem is that
> without serial console configured in EFI, the output from
> PrintErrMesg() is going to be very unlikely to actually be observable
> (on the console), whereas the printk() output would at least be
> retrievable by "xl dmesg" after the system is up.
> 
> What's worse though:
> 
> 1) PrintErrMesg() invokes blexit() as the last thing. Yet we don't
>     want to prevent Xen from booting; all we want is to disable use of
>     runtime services.

Fair point.

> 
> 2) I'm not convinced you can use StdErr anymore after ExitBootServices()
>     was already called.

I think you are right. From "UEFI Specification, Version 2.9" page 226, 
StdErr should be set to NULL after ExitBootServices() succeeded.

Insterestingly, the EFI firmware I had was still happy to print afterwards.

Anyway, my long term plan for UEFI on Arm is to separate the EFI stub 
from Xen itself (similar to what Linux did). One of the main reason is 
to keep to interface between the two clean and it helps to enforce what 
is used by who.

Therefore, I think I would prefer to move the printk() to Xen (maybe 
runtime.c?). I will have a look as part of the work to support runtime 
services on Arm.

So I will park this patch for now.

Cheers,

[1] 
https://patches.linaro.org/project/Xen/patch/20171221145521.29526-1-julien.grall@linaro.org/

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 13:39:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 13:39:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268336.462138 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHQhu-0006VO-7G; Tue, 08 Feb 2022 13:38:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268336.462138; Tue, 08 Feb 2022 13:38:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHQhu-0006VH-49; Tue, 08 Feb 2022 13:38:58 +0000
Received: by outflank-mailman (input) for mailman id 268336;
 Tue, 08 Feb 2022 13:38:56 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=GmUj=SX=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nHQhs-0006VB-Sf
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 13:38:56 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 750fdc00-88e4-11ec-8eb8-a37418f5ba1a;
 Tue, 08 Feb 2022 14:38:55 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 750fdc00-88e4-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644327535;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=BlNxdStduyd1Jk+OXHvoG/zMyC3keL19g/Retcq96xM=;
  b=G3+mndhZDkOQxtrf8FZhpzuAQyv77g0zDA3nyKyfeBv6WJMdaVnnv9oH
   mxQUIedSSE05787NvOHDGguufjPFRmpOy/5nN6wJhzKOgWPRvU27QcwN9
   Qxp1y+evcfV3x5cP8qm9QQIcwsKMJUde3ver+HzUtGk1WsAEeKp0+c33c
   o=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: ZcvmdNvItn8WS3dvwscPkMMlaCZaz2xOdAQo38F5mGcTeR+hE72Yi7irtrAGTuPoGax1PUxPKb
 xZNzZoWEaXProAKGX961NfpJZpDyuubyHr0ybZjrR7vxJCTLcOUu75tnIOQmAyjVfUr+SKBMOr
 2WNVL+av/2zIpzgNzWYd1P+cDDqLS8A/cexSUzgA8B0xGYFxYJWBQJ+h+kpcm9JbwEpCW0YheW
 OcVDWRZEmAHBu8p+AboJL690IfO++/2uBQ7sToEogPYYc4eaEtCkm798aYjcfjYM7CXLtDYH6w
 8QbTyRpAGJpVlLscrVZ5mZD6
X-SBRS: 5.1
X-MesageID: 65944919
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:rF0nQ6LEMOVulcpIFE+R8ZMlxSXFcZb7ZxGr2PjKsXjdYENS1zFVn
 zEXCmzQPayKNjanct9+Od/j9hxT6MTVm9dlQQdlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokcxIn5BC5C5xZVG/fjgqoHUVaiUakideSc+EH170Ug7y7Zg6mJVqYPR7z2l6
 IuaT/L3YDdJ6xYsWo7Dw/vewP/HlK2aVAIw5jTSV9gS1LPtvyB94KYkDbOwNxPFrrx8RYZWc
 QphIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbrGvaUXe345iXMfwZ3u7hB2Gn89fx
 /AU7aWgREAYEPXP38ocQ15XRnQW0a1uoNcrIFC6uM2XiUbHb2Ht07NlC0Re0Y8wo7gtRzsUr
 LpBdW5LPkvra+GemdpXTsF2gcsuNo/zNZ43sXB81zDJS/0hRPgvRo2UuI4EgGZp16iiG97Eb
 Og5QztoQi/jQCxhGk0PCpU+jeS30yyXnzpw9wvO+PtfD3Lo5BR4zbzFINfTPNuQSq19t1yEq
 2fx2nX2CxAXKvSS0TOAtHmrg4fnly7hRJgbErH+8/dwmUCS3UQaEhhQXly+ydGph0j7V99BJ
 kg8/is1sbN05EGtVsP6XRCzvDiDpBF0c8BZE/A+rhqMzKXUyw+DAy4PSTspQOIhsMg6VDk7z
 GijltniBSFsmLCNQHfb/bCRxRuwMyUIKW4JZQcfUBAIpdLkpekbqRbCTc1qFqKvufTzFSvt2
 DCBrCU4hLI7gNYC0uOw+lWvqzCxopnESCYl6wORWXiqhiteYIOmfIWu5ULs0edbLI2ZQ1+Cu
 1AJg8GbqusJCPmljzeRSe8AGLWo4fetMzDGh1NrWZ47+FyQF2WLJN4KpmskfQEwb5hCKWSBj
 FLvVR15659MEnSPNPdOc4/2Oupyzu/OFMSiWaWBBjZRWaRZeAiC9SBoQEef2WHxjUQh+Z0C1
 YenndWEVihDV/k+pNaib6JEiOJwmHhirY/Gbc2jl3yaPayiiGl5oFvvGH+HdagH4ayNu205G
 P4PZpLRm32zvAATCxQ7ELL/z3hXdxDX5ris8qS7k9JvxSI8SQkc5wf5m+9JRmCct/09eh301
 n+8QFRE71H0mGfKLw6HAlg6Nu+zBMcm9CxqZ3V3VbpN55TESdz+hJrzirNtJeV3nACd5aIco
 wY5lzWoXa0UF2WvF8U1Zpjhto1yHClHdirVVxdJlAMXJsY6LySQo4eMVlK2qEEmU3rm3eNj8
 ubI/l6KHvIrGV84ZO6IM63H8r9ElSVE8A6EdxCTeYc7lYSF2NUCFhEdeddte55VckiYlmLBv
 +tUaD9BzdTwT0YO2IChrYiPrpuzEvs4GUxfHmLB6q2xOzWc9W2mqbKsms7TFdwEfG+rqqike
 8tPyPTwbK8OkFpQ6tIuGLd316MuodDoouYCnAhjGXzKaXWtC69hfSbajZUe6PUVy+8LoxayV
 2KO5sJeZeeDNvT6HQNDPwEidOmCi60Zw2GA8fQvLUzmzyZr577bA15KNhyBhXUFfrt4OY8o2
 8k7v8sS51DtgxYmKI/e3CtV636NPjoLVKB+7sMWB4riiwwKzFBeYMODVn+qsc/XM9gVaxskO
 D6ZgqbGlo9w/EuafiphD2XJ0MpcmY8K5EJAwmgdKgnbgdHCnPI2gkFcqGxlUgRPwxxb+OtvI
 Ww3ZVZtLKCD8jo01shOW2egR1NICBGDoxGjzlIIkCvSTlWyV3yLJ2o4YL7f8Ecc+mNaXz5a4
 LDHlzq1DWe0JJn8jnkoREpoi/3/VtggpATNlfeuE9mBA5RnMyHuhbWjZDZQphbqaS/raJYre
 QW+ED5MVJDG
IronPort-HdrOrdr: A9a23:AysADqvSdx8Llp+MU+9wjEpJ7skC7IMji2hC6mlwRA09TyXGra
 6TdaUguiMc1gx8ZJhBo7C90KnpewK7yXdQ2/htAV7EZnibhILIFvAZ0WKG+Vzd8kLFh4tgPM
 tbAsxD4ZjLfCdHZKXBkXmF+rQbsaG6GcmT7I+0pRodLnAJV0gj1XYDNu/yKDwGeOAsP+tBKH
 Pz3Lshm9L2Ek5nEPhTS0N1FdTrlpnurtbLcBQGDxko5E2nii6p0qfzF1y90g0FWz1C7L8++S
 yd+jaJqpmLgrWe8FvxxmXT55NZlJ/IzcZCPtWFjowwJi/3ggilSYx9U/mpvSwzosuo9FE2+e
 O87isIDoBW0Tf8b2u1qRzi103J1ysv0WbrzRuijX7qsaXCNXsHIvsEobgcXgrS6kImst05+r
 lMxXilu51eCg6FtDjh5vDTPisa13ackD4Hq6o+nnZfWYwRZPt6tooE5n5YF58GAWbT9J0nKu
 9zF8vRjcwmP29yV0qp/VWH/ebcHEjaRny9Mw0/U42uondrdUlCvgslLJd1pAZFyHo/I6M0kd
 gsfJ4Y042mdfVmH56VMt1xNvdfOla9Mi4kD1jiVGgPNJt3c04l+KSHq4nc2omRCeg1Jd0J6d
 L8bG8=
X-IronPort-AV: E=Sophos;i="5.88,352,1635220800"; 
   d="scan'208";a="65944919"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=H0e3nBd2PKXPrIsXxh4TKxpi8nN5JnK4cQNkE4wGXi5TKSKJnnWNOAqca9cPA/sn0IvZDqRw5QJLQDq1tHXq8OxQ3g+6ERU/3kA7FAL4utNe15WhqFM04Q3dBwgOfgCK5z660Rad32u6y7qF7sY/XsEaqcfM5/VIEziUu3FAN8vORbOQCphH3L29srvETXvm0SxI1XIduWxWv4pbdC3XIAgC3BnKIpNfePqFBgBNRMgl+T1TDK9KQR/bFx5WsCiETY1DFsEtStXuGePnMyX3doioagXCEFGwwKZYnyxxBL2ZV3nwSudT8kU8o6ye7NwLVbJvAN8RdPindsPm2L5c2A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=MXIVqAJvO8QmSJQwwKXoLxAPzz8IG3cA/GAg6WI+9jA=;
 b=oNHck7LcZnwQYDTiuguejl8ZdhWZ5iX/W8UuZ2sA69kE+cPobk1MlJpwHQnfoJvaaqyScb2LEPWtMjCmuLp+5y+ty53I9Ct9V7+Tcr8I0EieR1J/m522Vtw6hYIT69eb8VouFopzpMVCX0fd7a5Lp1RsEqg4FcYLoouUrDwdD7oesXp/1WQjvbEygqrDfsAJrj272Zp5tofvfC5z2OsZuxEADmxwDAgekPIdNYtFFR1pHbxkntPb1E8K6D1i4ZThL0XYyS8BV4N+a34I+5BtLqh8/wFT5WfEoO8wVPtEbDVbRILlYH0hLPtaSXp204WBTovbr1Es0ha3OOl+odBwvg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=MXIVqAJvO8QmSJQwwKXoLxAPzz8IG3cA/GAg6WI+9jA=;
 b=DwfBDYkO0C22ZRi1p7g6RAyvaSuCxm1BK/UbT26pMBjvWc1iQcRATExP1b7eyounsp3y0B8AuvDtFsb7+UE0280jyYV7hzD7Ant4XY0IzRWQHNnuBxEes49qbGivedSBN7X9DURgMSAr52TWl2Rnjzd644h/2YU9GcRkjR75MX4=
Date: Tue, 8 Feb 2022 14:38:42 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: Jan Beulich <jbeulich@suse.com>, "julien@xen.org" <julien@xen.org>,
	"sstabellini@kernel.org" <sstabellini@kernel.org>, Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Artem Mygaiev <Artem_Mygaiev@epam.com>,
	"andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
	"george.dunlap@citrix.com" <george.dunlap@citrix.com>, "paul@xen.org"
	<paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>, Rahul Singh
	<rahul.singh@arm.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Message-ID: <YgJyYkrEGVduPVLg@Air-de-Roger>
References: <e8fc7872-c7d0-f389-c507-335b809ffcbc@epam.com>
 <21c8125a-2f79-1a4a-494c-db9e4be2a1a6@suse.com>
 <4276fe72-558b-7d95-6430-d4330989dbe8@epam.com>
 <ad985f4a-10f0-4a2d-df02-cde915fea3f1@suse.com>
 <f7669670-8eeb-9966-5ba3-e8f9c03ce3d3@epam.com>
 <73e08285-6bb1-5842-899f-bd6502406e49@suse.com>
 <be3f4222-6580-4c89-a202-c003b6feb9b4@epam.com>
 <e91965c5-0802-adf8-0c17-522f86ebf231@epam.com>
 <YgJK2zPszyTXGxMM@Air-de-Roger>
 <0f83fa71-c252-6e6c-47c9-3ef899b45901@epam.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <0f83fa71-c252-6e6c-47c9-3ef899b45901@epam.com>
X-ClientProxiedBy: LO4P123CA0519.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:272::6) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d224da6a-e154-4ca9-05be-08d9eb085603
X-MS-TrafficTypeDiagnostic: SN6PR03MB4061:EE_
X-Microsoft-Antispam-PRVS: <SN6PR03MB4061F1145B44AC9E14C2D2358F2D9@SN6PR03MB4061.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: JjME+lZVJ4+wfNcM/tZF8bDmWiy2RWEF+w41fg1TGsn0sUytZKhzplK2lqTm/p031sAgHGXXDCMSJDDPP6v9TT1UsosXYjIiy5JRCTYUhqDZkeRcghPP9fDfFb6rm/JlLrgDIG/32j+QLZKF1oS5bj/hm68SRm5XMKZ5J6o6u3gxrWvRMOydAO4HNqXFNG7BpFpfW87aLKRONTOZsNEtj2bmg5oF3hGg3DxPNoKTo6I5ZBdeI7CIRrbkrGO2VjF6OtzaqdMzDDU6vsBcLjvBd2169zjr+R4ntvcXqEBVoWNd8Lg0U8n2104eRSwWJ3aXYPzhhcr3WRjJHvLFMl5uH3AejhcFTKWFktk8oOtdgUC1W9+0xwWO/hg/ZSLtGNP37hiiQ6swFccvlc5t4p/ErjtSIR/uEowJU1e63B+G1R90MMb75R+7/uyQsHhq5wMxAR2pWG62ZZtzdzXwJaxr6D3BDI8jpLl8SunV/12oI7+72EHoGO8tECPlDZ8ksY5ASKHoM/QEcx7MbSIqpfmv+wqJF7iqxkAQPr2QZCY+bQB8TuQPS+KeAonKP90KRVoqWRR5IVRlmWG+VtSqQ7TC1PCpUQmE1B5jC4wE6/Yf4U81I9LxO722RMSXC3/l05Oe4LHjapZpUJvkoVOgRdRobA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(54906003)(6916009)(7416002)(6486002)(2906002)(86362001)(66476007)(508600001)(316002)(8676002)(5660300002)(4326008)(66556008)(33716001)(8936002)(6506007)(66946007)(38100700002)(82960400001)(9686003)(53546011)(26005)(186003)(6512007)(6666004)(85182001)(83380400001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZFN6dkRhWVJvbmd5b1NNWDFpVHVCWW9UbVc4eTBpYVRmMmk2c0dPZ3FHTlJ1?=
 =?utf-8?B?NHZlUkE2YmdEZGFubkwvckFMZWdmR2JDWlVhaVpmTzVhempIOEdvSmlBUUZC?=
 =?utf-8?B?bE42TkpQVHQwNWMvSkV1VitvdmVEUkJMcHVlbkh1QzNGZlo2M0F2aVZJOE5G?=
 =?utf-8?B?MysyVkJYQ1dXV1k4V2xrZ1hPMkxXekpaZmUxdW5FeVBKODhXblZUWkY4cjE2?=
 =?utf-8?B?RERxOHNGZnYyVGxZOWs2dTlTSDNZOFE3TVYxOERYVmVrbjFac3NSNHMyTCtn?=
 =?utf-8?B?ZWdQV0h1TUtXSitHUmd2a1hNbnl5QWJUWHA2YlJkTjdDZzZVK2hzZEJTbEg1?=
 =?utf-8?B?dm5jeHBmR1pyNk1icE5PY0hmYXdGQk9Semp6MzZTNWk1SjNqVzR1V2NmNVZB?=
 =?utf-8?B?a1VINTNISmxheUd1RkY1WjNjMGRONllRRW9zU0dZUm1tTHVhU0k4N0JacldI?=
 =?utf-8?B?blczRy9oR1ZOOG5zS1FqYlYzc3BFTTZOd204dEFCSVh2bWZkRW45NUs0OFFX?=
 =?utf-8?B?WUNWWmp4aXp1bWFmTkg4RzYza1Z2blhGcy9yb1BReFZJMzRoWWpQdTJNaTN1?=
 =?utf-8?B?YU1oVjRjcmNVR0tsZ0RZQm1FZEdOT1VjK3pxZ0VQd2JmcVY2NnNIaDBTZ0Fq?=
 =?utf-8?B?RGZvVDZmRVpsNjhqbEVTclhmVHRGby9hT0VmZi9Dclc2ckFFdVVBOERDcjBG?=
 =?utf-8?B?UTJWVFFkRml1dmlHZkxIMWhWdHdZdHlJVXhjUnY4emRQbm5GWi9tYXJkSmFU?=
 =?utf-8?B?WWxWdUZRK25ZampwL2RrR2pwcDR2UE43OVF0RldyTnVacnlwbFFySzdZRmhO?=
 =?utf-8?B?OVMyVzNkLzdDVld2QndvNndYRHRSMUR0eTlETWQ3ZjBNOTlMMnNjblRSaGgx?=
 =?utf-8?B?UmFRc0dKbmF5RjVZM1JMdTU1aTREQm5aY0NuTDFCOFN1U2JzWkY2Vndqd0E4?=
 =?utf-8?B?ckhQWlFhbXBJRVh4ckRUOU1EeFNGd0tjWExSQ25vdThCN0NrSWQxamhiek11?=
 =?utf-8?B?MDFVd2oyei8wdGp4VnZ4NVd5dkFXbzJ1ajg2OVN4QlZUT1AwSFpuTnhPUG1y?=
 =?utf-8?B?emx0MTR0MXI4NzdxVndzMTZMUzBtRnhVeWQxZlhJTnMwdm1aVi9EOFBLOEta?=
 =?utf-8?B?Y1UwT2VxYXltM1ZxS1g1bCtBczFkVGhrZTdGQlUzZFFzd2pBNDkzcWgvcU1z?=
 =?utf-8?B?RmhjK0N3aUNFVlRJVWxIcUZmcHovRUtla3pBQUVyVmN3dTJMS0dsYTlwWTRO?=
 =?utf-8?B?ZkVEOXJpdFZaOE9pNWVmZXVjeWxoOWxFR2REWUoyUjVDQzZXRlpkY2V6VVcv?=
 =?utf-8?B?c0hKNFMzTHVwcDRRUWp3dDgyLzZENVVSM285UUxHL295QlFBYmN6NTNrSisv?=
 =?utf-8?B?c1U4UGlPZHBZM2k5Z2RJM0hDajBUSG5rMy82Ymx5RTFpRmFRaWZFNWUxZC9K?=
 =?utf-8?B?UWkxNzJWM0Vnb3NyVHFnbk1xbkIrTTNVejVETzJvRkhsK0pYOU9GQW9GOW1m?=
 =?utf-8?B?eCs3a1VJZGxxZHJFbDN1cHZleGJvNnErSkhlbTc3YWt0VG9CY09UL0VkMEth?=
 =?utf-8?B?N2JkWU9ZZEhvNVB5R0pBdlpwV21ZV1dnUVZiS2k5eDJDVXBqV3AwOVV3RnR0?=
 =?utf-8?B?d0hJNTBCVTFkdFZrVUNySTlJUmRMMnlybTRnS21sWVBTa1RCdzZQQmtPcldx?=
 =?utf-8?B?UEdGTlNTblNsN21aRmlaWlpSeEpKZnJ1SndENWhGbkZOa2IySHZKZGhKRGtR?=
 =?utf-8?B?c09jMGVzSTgyOTgrMmFuWXlrZ3k4ZjJzbWVVbEhBWTROR2YyRFNIaDQ0Q2FR?=
 =?utf-8?B?NXV1NldFNFl2YjFPU3FNN0xETTY4bi9kdmFMcFdlOWNIcmJWdUZLVENPSWE0?=
 =?utf-8?B?cVZ1SXZncE02YWIyLyt1ajdPWHg3ek5KaEdjM1dkNkZHSk5XcWdpVDY1S0o3?=
 =?utf-8?B?cnpEMlVHZG42NzJZMGRTWVg0OFNWbFJiblppQVl5RzBEdUg2aTh6dCtMNmR2?=
 =?utf-8?B?aDQ0bXFGZ1RubDNQcExhelBDUGtqQnlLQ0FxQ09qSzV3QlhOeWZXZ3pMQXRv?=
 =?utf-8?B?NStmeDZadjhra1E4bzIyaTZuSHc2ekZGUDU4bGVqSDVBMFJranFFY2paZEtz?=
 =?utf-8?B?djhIVk0xeWFhSWpodU9RamFTSE9jcHcwZHVJSFMxY0dIZjdvSTlHVEFmMDRp?=
 =?utf-8?Q?8WbidepaDQIHoAVk13agKkc=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d224da6a-e154-4ca9-05be-08d9eb085603
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2022 13:38:48.8689
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4QmsmLMlbtzkRahQHoRTmeGuQXQYTZofNAdxFQnXY2O+Cde9CZ8BVp2EKcaw/3gFBo5LuKl8+ekbu+1GYxGLJA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR03MB4061
X-OriginatorOrg: citrix.com

On Tue, Feb 08, 2022 at 11:13:41AM +0000, Oleksandr Andrushchenko wrote:
> 
> 
> On 08.02.22 12:50, Roger Pau Monné wrote:
> > On Tue, Feb 08, 2022 at 07:35:34AM +0000, Oleksandr Andrushchenko wrote:
> >> 5. You name it
> >> ==============================================================
> >>
> >>   From all the above I would recommend we go with option 2 which seems to reliably
> >> solve ABBA and does not bring cons of the other approaches.
> > 6. per-domain rwlock + per-device vpci lock
> >
> > Introduce vpci_header_write_lock(start, {end, size}) helper: return
> > whether a range requires the per-domain lock in write mode. This will
> > only return true if the range overlaps with the BAR ROM or the command
> > register.
> >
> > In vpci_{read,write}:
> >
> > if ( vpci_header_write_lock(...) )
> >      /* Gain exclusive access to all of the domain pdevs vpci. */
> >      write_lock(d->vpci);
> > else
> > {
> >      read_lock(d->vpci);
> >      spin_lock(vpci->lock);
> > }
> > ...
> >
> > The vpci assign/deassign functions would need to be modified to write
> > lock the per-domain rwlock. The MSI-X table MMIO handler will also
> > need to read lock the per domain vpci lock.
> Ok, so it seems you are in favor of this implementation and I have
> no objection as well. The only limitation we should be aware of is
> that once a path has acquired the read lock it is not possible to do
> any write path operations in there.
> vpci_process_pending will acquire write lock though as it can
> lead to vpci_remove_device on its error path.
> 
> So, I am going to implement pdev->vpci->lock + d->vpci_lock

I think it's the less uncertain option.

As said, if you want to investigate whether you can successfully move
the checking into vpci_process_pending that would also be fine with
me, but I cannot assert it's going to be successful. OTOH I think the
per-domain rwlock + per-device spinlock seems quite likely to solve
our issues.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 13:49:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 13:49:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268356.462176 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHQrs-0008O1-NM; Tue, 08 Feb 2022 13:49:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268356.462176; Tue, 08 Feb 2022 13:49:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHQrs-0008Nu-KN; Tue, 08 Feb 2022 13:49:16 +0000
Received: by outflank-mailman (input) for mailman id 268356;
 Tue, 08 Feb 2022 13:49:14 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=v7zX=SX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nHQrq-0008No-R0
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 13:49:14 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9c5501a6-88e5-11ec-8f75-fffcc8bd4f1a;
 Tue, 08 Feb 2022 14:47:09 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2175.outbound.protection.outlook.com [104.47.17.175]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-15-Ej46-f2ROP2TSZiAi-cp7g-1; Tue, 08 Feb 2022 14:49:12 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4544.eurprd04.prod.outlook.com (2603:10a6:803:6f::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Tue, 8 Feb
 2022 13:49:10 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.018; Tue, 8 Feb 2022
 13:49:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9c5501a6-88e5-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644328153;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=K0zDDN4nzaJQe8tSrcHGASi0/1j2RHCcWB5fzveZ5EM=;
	b=CMG3TY7CqLCY0TOJXEXKHxAJFJKE/BeKa44+EyDnoZ5Nno/08m9InNhQs4vvEhghhoce41
	eKEZU0TcFHRp3kTTgLvZ5bkXlhV7lKacnGfa3vTsU1FS3HxOqUtSjAU+OvUtgQJ9rVa2HJ
	a8/gXb0tF6GJe9RoX1CZPRs2OHKV7bM=
X-MC-Unique: Ej46-f2ROP2TSZiAi-cp7g-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=KvUt8YKoqCIOdamB0M04b3ncShmfpxhps4zPF92XOMG5x3QKJWso6txoG6+ellu9m9eaxDWBF2NFWoxm1/jkv2VwSCxgfCCIkBSaxqJmi49P777dCBXPKgAzMuosrjUbHR+46SxLZ1Po32lywpanrTL8aXtcyOQzhh8smoKIcrUfL90cf8xEt0ZW+xoGNMRbOyWB6Rf/hMks4nZYwI3/wa6pYRZ0BSbwoa4atyhWThhKOE02xeUe4B6Wgi30Qoa4v1pVXsqlLN2ZJ9WUvp3ZKK8uWNIEkYI7qIIKm/GzH8w/SthtfB++1xRw/ooUVFzdUVYSHkLISG+wSuWGq8AfrQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=K0zDDN4nzaJQe8tSrcHGASi0/1j2RHCcWB5fzveZ5EM=;
 b=me8Y5jwlmzp8k03QldeMYISU3Jh14cTVqy1mPPnxjsoPQ7Hi9ej23UBg3PTJ1QKuIQ646W4/Q2AjyLu+Z+coZhkC4Ym3Estme7+d6Zg7SHXCKzOdOreOqyRkqri52FflqJi/db3VbvdFrK+tgyGDZHuKyZT8nhQ1wMifgl67SVoVQIpYcnTOFAN/oO0nqGIKAYy0cIPmeOedqf4NY5dpaKD6pY+h5Z0LQjt2gen6FOTlT2rJzoWelWRDGWmlmJgJZTHb/ioYTXKGDb4VmRiAS3C0vXICESWRgq17qJOu+2NCc4z292Sy9tlPo5Em3kCulfvEHgkyByl9OsXojDKbFg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <f234c5ea-6188-922d-6754-36e4aeb52cff@suse.com>
Date: Tue, 8 Feb 2022 14:49:07 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v2 1/4] x86/time: further improve TSC / CPU freq
 calibration accuracy
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <879e5b70-bffd-b240-b2c8-c755b09d41a9@suse.com>
 <2e97dd91-5e43-3312-2e47-534f425c28c4@suse.com>
In-Reply-To: <2e97dd91-5e43-3312-2e47-534f425c28c4@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8P250CA0004.EURP250.PROD.OUTLOOK.COM
 (2603:10a6:20b:330::9) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7db90f1f-f9f7-49c3-719f-08d9eb09c8b1
X-MS-TrafficTypeDiagnostic: VI1PR04MB4544:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB45449B1986CF4EC26BB4E14CB32D9@VI1PR04MB4544.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5797;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	8GaGvVXt9TeVLDdWDtuPvxIlTuQC5SQu5FnV4J33ALZMDXfC+PWHQ3jTNUAjHnWx3yS+DD4AccozA0WJEtrOkX+HtaRdUBIFgtSy3CFYkw8glR4GLguukTAc2u3TP+kukUAdTWs0E3616shWyF9keDvAtifYcn7NMxO0VcCoPzepbeJ/aZEFSoJfXI3hqnRXG/4EOCUDtGjBVzQ8lDjCjV1mZE3wYoaxLt6du1Tj4BqZLYVmyURW3PJaWUpHzoWa9GIckZ+QhWGGERXPFt6U518txe6rJtLd3UaqvZRxmdFnF0+3ksyvMmpAyWK7L6o4DrEstxhxhSvSsW33VPF4ePGnJZYiq/eWoeGryC5hVsUV9FTMsRK8ARY0QImpz3kZnX1tJslvxp/cboMnsV5bYwcTXzJjPCg+85ttoNX4HubY8gNSIDErcED+hC8ejwE+paoFsJGK0qX+TxtjlNbSfkG+h1IYlTTI3w7Wm7gyaCaKXF6z5Kl93Xeh9tWqwwKRkzNgm67YexXYsIpxnmdRRpUWl7XA/WXKMK1xVQCi8Qccf3Ht3Yl8DXJBaDjRf66xj5SgO6tZh1XXFMzzdUuvzoifNurj5+PIdLlvsaAm8Uua+jBlpgRe0AkKfQs0rozMulkcKEly7+iRYIV2cFsRhJ3cjXMxXY9HrbJ3HEe1LUtRlATxXVdGhND6wyX8+gjLCjQePbT/ty1lZUjkzhl4eeFEDRW77IK9IK+6+vEPqiIptqDr4mpDqbGKd4jS387p
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6666004)(4326008)(83380400001)(38100700002)(5660300002)(2616005)(6506007)(53546011)(6512007)(66946007)(36756003)(8936002)(54906003)(2906002)(26005)(186003)(8676002)(31686004)(6486002)(508600001)(6916009)(31696002)(86362001)(316002)(66556008)(66476007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RVV2ck1DeklnMXRTZTBWL2UzbEZDZGFZQWVSMkZnV01oMU1qTWluSU85Nmxz?=
 =?utf-8?B?N1FtU2ZsVWcyMkI1aUlJVUs1MDVaRFg2ZUFVd05lcmYrRVhYN25RaUhnZ1NN?=
 =?utf-8?B?QWk2UnNKWGg4RXNTTjhxZmFLMytPc28wdy9tUTI5a09BVEhJT1RvTFhBYllK?=
 =?utf-8?B?am51ZE5JZVIvcURUbTVGQm5xMEFhV0svZXpWVXhSS1llRnlhOG9teXR0eE14?=
 =?utf-8?B?dmVVeC9tWGZSbWxkNUJRKzFXditqcGRLdXNLUFJWMU9OSlpvZHVVNlVuT1Zn?=
 =?utf-8?B?R3M5d3RZTmN5V0t6ZGtueldTckNWVTc3MnJ1bXJ2cFhIajVTTHpOZFVSWkh2?=
 =?utf-8?B?YzdBdCt1SG5OOUtZci96YXp0ZnJ4WExTVmJxenYwRDFxRWxpY25aRGZPUDhR?=
 =?utf-8?B?cmU0bnRMZWY0M2F0Q2RxRGdTZzRGZktIaE1MMlBTWkk5T0x0aWdtVHdrMWIr?=
 =?utf-8?B?c2tjTDY0dFN6SWhKNm1BaTJGWFNraE04YnpzckRMVDJMU0JDOFVVczdxdUdV?=
 =?utf-8?B?VSs2c1Y4cGhvcDYxVnpUOGhOSTVyRFZUaHRwVnEzUmoxSEIxNzFuUXVURVVT?=
 =?utf-8?B?U09nb0ZycDYzYWlGYVdzclhuWW1GbmVoSUlJM3hDcVZqcnpkR0VkSHdFbWNT?=
 =?utf-8?B?MkdpbFRSdTdpc0YxaDIvSzBHL1ZFZS9MenRLTDIzUzJ3UGxHdDdObGJKeWw4?=
 =?utf-8?B?MkFZRHJuY3J1NlpCQzhNUDMwK200RktFTDV1MTRlRFdlUTRYVnVYZy9FRVhs?=
 =?utf-8?B?eTliUzROL3ppTVlMS3NhaFJ4dEMya3RxY2ZBbEg2Ym5kWnA4REpvKzNVdzhU?=
 =?utf-8?B?emFBUWFEZ0pjZFkwNUdDYkFRWTVDbGZGTldBdFRyS2x2eDd6Q2VsN3ZGcnNx?=
 =?utf-8?B?ZmpxWHYzbEtZbzF5TDdGcEJXSDZINE9raE9ybkFUVTZxSmZPbVJYbzBSK0x6?=
 =?utf-8?B?SGZNWmtrd1lxeERWdmtPczdxYjAxaE5Sa3lXRUVIUWs1ck1rM2dYbGFscFNE?=
 =?utf-8?B?KzNiVFhoeVhMT3NDb3Y4eVVib3BpbDdzRm9ySVZGN0dQVFdjQlJKMTErTDd1?=
 =?utf-8?B?K0tyaXEydjBVYnhmSWovM2ZXeW1ZQVVReVVGdDMxb3ErajZYZ2Q2RGJQSmtt?=
 =?utf-8?B?RW5jVzU0UVQxMlpKKzF5MFBnU04yTnEyYmsrcFpMaGZOOC9xUnBDSnBBNms1?=
 =?utf-8?B?akphdVYyOFpkUEh3UUVzdHZDV3lzOGp6YTU3Sm5kTDVwNXNtM203ZU1hZHFQ?=
 =?utf-8?B?K21MOTY3ckcyRzhuOER3dXFJVkdLbm1ZWGs0dXdhckFjWElPYnArNTF1NmRq?=
 =?utf-8?B?R1JQTmFHallFRjZJa2RyOXhKUUsyMEJsclhwK0UzaHZMbXR5ZEcvRTV0S3Fn?=
 =?utf-8?B?d3piTHNVOGdJRFJMdmFQcGt1SWxhdFlVWUlrL25TcDB2bW92MDFEaVVmSlE4?=
 =?utf-8?B?aW1yRDN2ZnVOdUtsUGJPMnRsdDh3bEpXQ1psSDJGK1lROHFrdDBPdkNWUkdW?=
 =?utf-8?B?ZzNDRmVINWVwMURsbDRqeStjMGFYenp0T29DL0hSK1Nrc1NEZ1ZDS0cvQVVa?=
 =?utf-8?B?ZHBwUldkK3lxOGpGUE5LQnJJcHhCNUFCbnlUcnVseVZLKzEzS0FrdEk0UjY4?=
 =?utf-8?B?Y2VGeTh3a1BLTk93UFh6SGRoM0JxckFlQVhUTElWdFZXOTFKSWdxKzlsRjhO?=
 =?utf-8?B?V3F5NUpzU2x6KzdaYUVkeWNhRnJ4L0tjSXo3Z1RyUDNVSkZjQm5NWnI0MS9M?=
 =?utf-8?B?aGdvRnJRSlptd3cxZ0UzWHQ3bFRUeVQ1dEpydkpMUmpqY0R4UFdWQUxFcDRa?=
 =?utf-8?B?S3JTa0llNVFYbjRkaTdFMkkvMTV3VHJIaU9HOHdFUy9KZkZUY2I1bDVIMDYv?=
 =?utf-8?B?eWNUcXFRZUlrMDJnbGRCTkoyYzBlSEd0dUY2eDhTUktVUzRWYmwxem9wQnUr?=
 =?utf-8?B?Z0g4UFBwMldPNG5pSSs5WGxCbndpbzU5K0RFR1VEVnRIQXNzNzdYTW96V004?=
 =?utf-8?B?RTBqbEVsMlp5MlNOZDl5NzV6S3lVWENqSzJRTkZ1WlRubWViS1VHR25rcnNL?=
 =?utf-8?B?SVVZZ1NYVXUxZEdDTE9hMnk1eE1DNk5EZVlDWmNWdWc5cGs5L2lJWFlZelZm?=
 =?utf-8?B?NU5sNHFzMVVlV2hJcEFTa0tkNVRQTjNxVStiYnU1SXZCNGozYTR1cWFZWkI4?=
 =?utf-8?Q?i5MF3RUsDYIyEefFvLebc6I=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7db90f1f-f9f7-49c3-719f-08d9eb09c8b1
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2022 13:49:10.6440
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: m29JDK0sZky0C8XDif/iRjMO4sgpv+zlTzUjvjBhNRNUTBLmvCeOVoe+mFinvLE0VRBmf5FJ4ucIaFNm8Yl8dA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4544

On 24.01.2022 09:25, Jan Beulich wrote:
> --- a/xen/arch/x86/time.c
> +++ b/xen/arch/x86/time.c
> @@ -287,9 +287,47 @@ static char *freq_string(u64 freq)
>      return s;
>  }
>  
> -static uint64_t adjust_elapsed(uint64_t elapsed, uint32_t actual,
> -                               uint32_t target)
> +static uint32_t __init read_pt_and_tsc(uint64_t *tsc,
> +                                       const struct platform_timesource *pts)
>  {
> +    uint64_t tsc_prev = *tsc = rdtsc_ordered(), tsc_min = ~0;
> +    uint32_t best = best;
> +    unsigned int i;
> +
> +    for ( i = 0; ; ++i )
> +    {
> +        uint32_t pt = pts->read_counter();
> +        uint64_t tsc_cur = rdtsc_ordered();
> +        uint64_t tsc_delta = tsc_cur - tsc_prev;
> +
> +        if ( tsc_delta < tsc_min )
> +        {
> +            tsc_min = tsc_delta;
> +            *tsc = tsc_cur;
> +            best = pt;
> +        }
> +        else if ( i > 2 )
> +            break;
> +
> +        tsc_prev = tsc_cur;
> +    }
> +
> +    return best;
> +}
> +
> +static uint64_t __init calibrate_tsc(const struct platform_timesource *pts)
> +{
> +    uint64_t start, end, elapsed;
> +    uint32_t count = read_pt_and_tsc(&start, pts);
> +    uint32_t target = CALIBRATE_VALUE(pts->frequency), actual;
> +    uint32_t mask = (uint32_t)~0 >> (32 - pts->counter_bits);
> +
> +    while ( ((pts->read_counter() - count) & mask) < target )
> +        continue;
> +
> +    actual = read_pt_and_tsc(&end, pts) - count;

Having run into a case where the resulting CPU freq was 141 kHz (and
boot failing slightly later because of this), I've spotted that this
also needs masking by "mask", to guard against a 24-bit PM timer
wrapping between the earlier read and this one. The original code ...

> @@ -508,22 +539,12 @@ static u64 read_pmtimer_count(void)
>  
>  static s64 __init init_pmtimer(struct platform_timesource *pts)
>  {
> -    uint64_t start;
> -    uint32_t count, target, mask, elapsed;
> -
>      if ( !pmtmr_ioport || (pmtmr_width != 24 && pmtmr_width != 32) )
>          return 0;
>  
>      pts->counter_bits = pmtmr_width;
> -    mask = 0xffffffff >> (32 - pmtmr_width);
> -
> -    count = inl(pmtmr_ioport);
> -    start = rdtsc_ordered();
> -    target = CALIBRATE_VALUE(ACPI_PM_FREQUENCY);
> -    while ( (elapsed = (inl(pmtmr_ioport) - count) & mask) < target )
> -        continue;

... ended up requiring use of "mask" just once.

Jan

> -    return adjust_elapsed(rdtsc_ordered() - start, elapsed, target);
> +    return calibrate_tsc(pts);
>  }
>  
>  static struct platform_timesource __initdata plt_pmtimer =
> 
> 



From xen-devel-bounces@lists.xenproject.org Tue Feb 08 13:52:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 13:52:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268365.462188 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHQuv-0001KJ-6b; Tue, 08 Feb 2022 13:52:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268365.462188; Tue, 08 Feb 2022 13:52:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHQuv-0001KC-3P; Tue, 08 Feb 2022 13:52:25 +0000
Received: by outflank-mailman (input) for mailman id 268365;
 Tue, 08 Feb 2022 13:52:24 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1FiY=SX=epam.com=prvs=40383cc40e=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nHQut-0001K6-MU
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 13:52:24 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5614d920-88e6-11ec-8eb8-a37418f5ba1a;
 Tue, 08 Feb 2022 14:52:22 +0100 (CET)
Received: from pps.filterd (m0174679.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 218Dikqg006860;
 Tue, 8 Feb 2022 13:52:18 GMT
Received: from eur04-he1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2050.outbound.protection.outlook.com [104.47.13.50])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e3snvg18j-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Tue, 08 Feb 2022 13:52:18 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by DB8PR03MB6217.eurprd03.prod.outlook.com (2603:10a6:10:133::9) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Tue, 8 Feb
 2022 13:52:14 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77%3]) with mapi id 15.20.4951.019; Tue, 8 Feb 2022
 13:52:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5614d920-88e6-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Bh+l6lN2NlosGHdikCn2HRTZLKrPQ4DibVuiKO6IPdvLIe13klAibu0oOktOx/vQ5QJ2qFSukrGAqiBz7iQDyf3dUcyHIA/P6cxpyeieK2e5bzUNBQ4hwwIufhTlqT0IBSMpBzJDqpPtfl6eL5+gwdkv86zznI6YcFgHWpUVFf7b6eNNmXTUSIVDrvqdOUHCdnFQe44Rs8ekgKQHu1Ey5M1ygwr/CT2SGeRyTrlt9fNCuo9sjo+DR1CHQK1GoaN/FRkQ/3FjN9R6maZEm3ruOiXDtI5n8+sTOzr9tPc2+x8OBl77501cyFx9vlTXP0Zy3wiShsjWoBWjFRQUG7ILxg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=OV0yQiCeohm3WATHNMvSpLy+lOyiJ3teNWGSWymmVjg=;
 b=PQhC6rFPkU2pttXSQeHSfpEPXPNPzJOq/EfGFtzKR8VkMs9j2sE4MTBxSFPKgUt/Uqvk1RdyL3MMVsmFfYV7+4LOAWjcxNrzvu46PGv3xLbKvd9YXEXqHos9JlYimFAUPNjNCJNs37QPqCENRfCMYg5IbxEZaR2iAMvDSqY5d2yDEXk5NfBRTFn1BNlSgB5WjkIGEV7gQcuufcxLzWuT4F5VvH25695uaA0Q0A+KGDGn7NKcKNVZ7SzGrBdD7vg/V85gZiKf+D6Q6rpPTxeDev/I/Dd4Oof2MiyBpQaV4+Iw70a7EtkljaDbFO7nHaiMRiTsFlCeX/0nUMrTQPdNaQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=OV0yQiCeohm3WATHNMvSpLy+lOyiJ3teNWGSWymmVjg=;
 b=UOlwelikiBZkAxhHyYPX2V9wZLPMg/IELWuwa2p6CqIjXvDpD2sLO3EpWYmH3mB+f9+gyf68NDqYQMYeP4DXL+HfliKK/HrhUyy+sAP7EC/Xi39M08FkPGB51UgqpXy80UMIaJGzUKGStaTD4W7M6lMwrqG9EmLnAtjz1Kvni7H5ADgGD22vSnC4j13c5j+zdHIVVb/iczocZd8dSXGuH+4R8wiH0DoKu2fgKkdZryueliks8d75UDeoECZm9AWpJDpo2nCpD3ToniAA8Arz1Ihe24tzA0fJQoznlwqLJ+06wAjwei61GdLVG668E7K1+6LE0ZZST/rxmiLfIYCsTw==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: Jan Beulich <jbeulich@suse.com>, "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org" <sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Thread-Topic: [PATCH v6 03/13] vpci: move lock outside of struct vpci
Thread-Index: 
 AQHYGZFc/MnzQOjwVEeBBUHLSW0md6yDBUkAgAASSACAAATYAIAAD/WAgAAKNgCAAAbfgIAABnuAgAAQvgCAAAMCAIAAAY4AgAADxICAABrnAIAABAgAgAR3CoCAABt5gIAAEpuAgAAE5ICAAASKAIAAAiiAgAAKNYCAAARNAIAAC1wAgAACRYCAAAGVgIAABJiAgAAB5wCAAPjsgIAANleAgAAGm4CAACiEAIAAA8eA
Date: Tue, 8 Feb 2022 13:52:14 +0000
Message-ID: <8dd91569-ab6b-4424-df08-ad1065cb8690@epam.com>
References: <e8fc7872-c7d0-f389-c507-335b809ffcbc@epam.com>
 <21c8125a-2f79-1a4a-494c-db9e4be2a1a6@suse.com>
 <4276fe72-558b-7d95-6430-d4330989dbe8@epam.com>
 <ad985f4a-10f0-4a2d-df02-cde915fea3f1@suse.com>
 <f7669670-8eeb-9966-5ba3-e8f9c03ce3d3@epam.com>
 <73e08285-6bb1-5842-899f-bd6502406e49@suse.com>
 <be3f4222-6580-4c89-a202-c003b6feb9b4@epam.com>
 <e91965c5-0802-adf8-0c17-522f86ebf231@epam.com>
 <YgJK2zPszyTXGxMM@Air-de-Roger>
 <0f83fa71-c252-6e6c-47c9-3ef899b45901@epam.com>
 <YgJyYkrEGVduPVLg@Air-de-Roger>
In-Reply-To: <YgJyYkrEGVduPVLg@Air-de-Roger>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: df70dc14-4aba-481a-3503-08d9eb0a3661
x-ms-traffictypediagnostic: DB8PR03MB6217:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <DB8PR03MB6217D94E8D040DB3D28A56E6E72D9@DB8PR03MB6217.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 P6ScqA0CoUeI6TYkl4+5SVK8AFAFbogCsnuy79yYMVd2cuMlZNWniUBygSs10ywd9NJnOy+OwdHTvP5ImaXZAxLpcRFNx3FbS0L6JyHK1MywWV0sRCNYVyJjf/gI13jbYBDUC3nnY/Ijll08xe8NkyDtR3IFK2sd1M2wRgg6VtobVeLtts1OFlluzmdo4yOahb3XSGjzrahbwR6A6PmwgLjLjaoHiIQ/gqAfz0CxutZXLb0mGJW32meV/Sblza9/yg80biLO407o7d3ofElq9VObMFYNagVeApPZfv607NZdtHcf8tzaAgRh7lu5/fKgvj2rVxM1uJQ7yAmoc4qI5Mbtc9jOx6xyeS9IM3tv86vhG97ezo4vb493PJVpi1E3MhkEuZJL9ir37J5RQImrEnVSMZcUL1hoqVaEa2AMdXU6hLcYznEaYiUDtftq4JCVkvhmCZlKWkZ7isAqkgBKZEO4CtOHMkukpN+sAGI2xqt8dYEaoP4GBnFnNl9GqZ1tI9X5evJo7WUHmfkiYVwikpiqEXZviKC06uu9hqSvYH84kJDmdYGiMhgDEY/OcDKc6OpoqHr1NGrJbVamoYg6Bew4z2v0Y4A8LEqgYt8nXFo8vZth/e8KqSTU9YVoHOTOpGa10ama0q4UvVO5axH0RrHbWHq4l1BpmbI1RxZ4b53JlSakSBqMaRCb2g8RNIK0gtjgNWUaARStL4MJbkCbB6R2WupEndUEBhnbYTRTqPC3P4AvgBqBBg4Z3Rez+NgK
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6506007)(54906003)(66556008)(6916009)(64756008)(83380400001)(71200400001)(91956017)(86362001)(8676002)(66946007)(76116006)(508600001)(38070700005)(5660300002)(6486002)(7416002)(4326008)(316002)(2906002)(36756003)(2616005)(8936002)(6512007)(107886003)(31686004)(122000001)(66446008)(31696002)(66476007)(38100700002)(53546011)(186003)(26005)(55236004)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?R0JwMW9pTTRpdklMSkFmM2dvMDBjRG5XdWgzemt6Q21VclZIMkJaWmpaSzhr?=
 =?utf-8?B?REduSzFodEVVY1lHZ2tUTDlMZXZBakhzS0MyeFRieEYyOHk5eWtqUkxjWjlT?=
 =?utf-8?B?SnkvMmRjSXprRmZRbVJNVzVSNmVqb2ZBbjBJWnhrbXQvZk54OUpZV3k3UklV?=
 =?utf-8?B?ZVR0UVRRL0hsYXdJRDUyNFpkYVc2UHJXVnNDa0pJdlcvQml1MHNzZFdLeW95?=
 =?utf-8?B?K1NoWGlnM0FhY2QwQnBYR3VLNis0bW9oc0RGbzRTUHpGeEtvMkIzRVIyMEg0?=
 =?utf-8?B?SGgvcjhVSHRNUjc5ODhUbFR6ZGJjU1kydnhONHFpUi9HQmFXbzNIZ2l2NGg4?=
 =?utf-8?B?MVhKdUlxZUM5TnhkUFFKMVpPdU5Scmh2TFNxNkkzS05KZ3FmOHAwUEozWnp4?=
 =?utf-8?B?dE1uWmRVbkdMN0ZuZzBldGFpNmZLS0xhYVduWmtMMUdlL3FyQXVrNXVwSytM?=
 =?utf-8?B?TzUxeUpiWmxCanU2RFRyWXRzWjFNZlpza1NwU2FMYmNGVmQyTUNTT1ZsRjQ4?=
 =?utf-8?B?VlJVWlQzZmthaHNTcFNGYU4rQ1BpL2dCUm11UWtYTTRVTllYS1J1ejRBVXJz?=
 =?utf-8?B?a1c5NWZnYlRtV2M5RWY4cWdjczMxN2JlOFV6ZkJUSUxxblVWMXVGdncrQW03?=
 =?utf-8?B?R1lNSHdZVWVJTWw0SkkzZGpQUVE0eU56b0FYUGsyUjFhcTl1bDJISU5DcVRp?=
 =?utf-8?B?SHRDWmlFTnhaYWwwZ2k0eGN0QVEwcldCSHdueDE0Z0JKRFZZbEV4MlNKU0lV?=
 =?utf-8?B?Nm5ySkpxTy9hY0FyUFdMdVBTWnNSejBVeFZpM1FITWRRVExudzJoNEE5V0VE?=
 =?utf-8?B?V1FBbjkrMEFkV3RQUUJuZ1VJM09tOHo0Z3J5VDljTU5zVWVDRjJONDBZMVJE?=
 =?utf-8?B?bW9HamFqelZ6Q0hNRXE3c3UrMXh4NnowOU9zbEREL05ocHN3aG1rYUlscHdW?=
 =?utf-8?B?S0lOaVdRZEFqUzB5TXovZ1ZtRUw3VUl6M1oyaHZ6VllQSnNyQVBaSjFWRE1m?=
 =?utf-8?B?WmtsazdoR3RPbmdxY2U2UHNOWXVSb3RNT2F4TXZKSTJBWHhnQm5LZmh5bGcz?=
 =?utf-8?B?Q1ZXYnIvUXpOZGFsOVQrTysyd3BzSEp0YkhUcEhyYmt1MDByeHdYZk00NW9p?=
 =?utf-8?B?eTc0cGorQkhXM2NiUXhpeXc4bXlQZC9VTFp2VlE5ZEFFakRxL2hxOWJqZmha?=
 =?utf-8?B?dkVpblh1MjNnWUZ6eFVVUzk2VGtZRncwd0ZScHVIVi9CN3hZdjArNW4rWXdR?=
 =?utf-8?B?MU0yQlY2OUYxSjIrNkw2MkcvSlZWUHBrcHpjdXo5bysrNVZsOGxLSHpIYWQ1?=
 =?utf-8?B?ZkY0U1FyTGpRWTYwTG82eGd1N1NOekh0cDBMZVpjRURxS1ZmTWVCdHB3L281?=
 =?utf-8?B?UnlZMDZPRUxabnZvV0ZOM3dYc1A1WnhYWWhKL0pLV1ZGUFU3cjgzSHI2KzBQ?=
 =?utf-8?B?ajk3ZUpxcFRhd0IvNUxrekxNckFuZFc5NTdqNFZ3aktVYStQdlpxeDMyNHpq?=
 =?utf-8?B?bnR5Yis2dzdFTENyc0wwZWVDVzZvaGNLenNpS3BPbEp5d0YvNlBQaWlYMnlz?=
 =?utf-8?B?NlFMMy9TdUpSZjkrSmt5YVo2V0c1bG5nZ2dvSk5qNDhVTm1rc3V2czRuZ0pT?=
 =?utf-8?B?MXp3cnlmbXdiSmYrcS9HZ2RLRUdLNmpuRStGVHZZZGVEL0E2L3liZzVJS05G?=
 =?utf-8?B?ZVdsd0p2VGJqOGNYV1l0L0dmNy9NYk13amVzZjRpUDBJVzM1MWZQdzFnbE11?=
 =?utf-8?B?ZXVZWkRKNWhORnlqL2ZxakJSbHJXbm5XRG9aNFdTZ2VITGVIWlhmQVRDcUlV?=
 =?utf-8?B?c0JxdjZYdGhCYzJRVVV2cjdMOHV0dWJCTTFDNTUxREZ0YUw4ZktnVjBmT2Ro?=
 =?utf-8?B?bVVjSHRCVU5kRDJBMjhMWHZGVnhEc2I0WFV6TzB5Q29iT1czd05IcXdmNXdw?=
 =?utf-8?B?enI1NTFSUDYvSVdZQWJXUkUxT2tCZmxMRVR4Y0NsY0hrNkdsNFVocHRMa1Ji?=
 =?utf-8?B?S2RKb043Z2hqS3lRVnJTenpobGVVSDVmdHM2WXhlSnd5WGorWWUvS0FtWWhj?=
 =?utf-8?B?QjQ4N3h6RUtJQUh4VjlqN3lXdTkzK1JFeTFmZjQxYUhDTFhsdjEzNjJIbmtK?=
 =?utf-8?B?UmlYczc2a21mclBvTGVPRWRrWHpCbzFCZndNcVhYazlMTEVsNDFrU0NaS2FJ?=
 =?utf-8?B?bElXOVR4c3poTzR3L29TTTRBYUJRZFlUbFp5U1BLem9qYVpaMGtOR0p4QjRZ?=
 =?utf-8?B?VklnZTdhSkVwL3FVY0ZVZnBFSm12QmtmV2dGU2FYUzdIb1JSdElYMy9yYlNP?=
 =?utf-8?B?WC94Um91dkR3NGdvaEQ5VHFPUDg5d1ZaQkZrZm9UcHYyYVl4MUxObE1NVG8r?=
 =?utf-8?Q?qW+QPvM7qu7LSRZk=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <1A44FA972A368949B2B06A19E94EB3A3@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: df70dc14-4aba-481a-3503-08d9eb0a3661
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2022 13:52:14.2926
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: wTJ9h9VJz8K8O46VgaeUeWneJX1OvRLNcKTo9xBW3Rl5paVG3U9HGsK4UZlTkhddXtFSfVjKYZk64YxcYxd2rJ8sOlptEz9mACaDdWIFs6E2ALgmtBbCytkOqJZKLMIE
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR03MB6217
X-Proofpoint-GUID: NTIje2FN8TEbxlRCjoXEDunmbf4FF7YB
X-Proofpoint-ORIG-GUID: NTIje2FN8TEbxlRCjoXEDunmbf4FF7YB
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-08_04,2022-02-07_02,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501
 suspectscore=0 lowpriorityscore=0 impostorscore=0 clxscore=1015
 bulkscore=0 mlxscore=0 phishscore=0 adultscore=0 mlxlogscore=551
 spamscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202080086

DQoNCk9uIDA4LjAyLjIyIDE1OjM4LCBSb2dlciBQYXUgTW9ubsOpIHdyb3RlOg0KPiBPbiBUdWUs
IEZlYiAwOCwgMjAyMiBhdCAxMToxMzo0MUFNICswMDAwLCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5r
byB3cm90ZToNCj4+DQo+PiBPbiAwOC4wMi4yMiAxMjo1MCwgUm9nZXIgUGF1IE1vbm7DqSB3cm90
ZToNCj4+PiBPbiBUdWUsIEZlYiAwOCwgMjAyMiBhdCAwNzozNTozNEFNICswMDAwLCBPbGVrc2Fu
ZHIgQW5kcnVzaGNoZW5rbyB3cm90ZToNCj4+Pj4gNS4gWW91IG5hbWUgaXQNCj4+Pj4gPT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0N
Cj4+Pj4NCj4+Pj4gICAgRnJvbSBhbGwgdGhlIGFib3ZlIEkgd291bGQgcmVjb21tZW5kIHdlIGdv
IHdpdGggb3B0aW9uIDIgd2hpY2ggc2VlbXMgdG8gcmVsaWFibHkNCj4+Pj4gc29sdmUgQUJCQSBh
bmQgZG9lcyBub3QgYnJpbmcgY29ucyBvZiB0aGUgb3RoZXIgYXBwcm9hY2hlcy4NCj4+PiA2LiBw
ZXItZG9tYWluIHJ3bG9jayArIHBlci1kZXZpY2UgdnBjaSBsb2NrDQo+Pj4NCj4+PiBJbnRyb2R1
Y2UgdnBjaV9oZWFkZXJfd3JpdGVfbG9jayhzdGFydCwge2VuZCwgc2l6ZX0pIGhlbHBlcjogcmV0
dXJuDQo+Pj4gd2hldGhlciBhIHJhbmdlIHJlcXVpcmVzIHRoZSBwZXItZG9tYWluIGxvY2sgaW4g
d3JpdGUgbW9kZS4gVGhpcyB3aWxsDQo+Pj4gb25seSByZXR1cm4gdHJ1ZSBpZiB0aGUgcmFuZ2Ug
b3ZlcmxhcHMgd2l0aCB0aGUgQkFSIFJPTSBvciB0aGUgY29tbWFuZA0KPj4+IHJlZ2lzdGVyLg0K
Pj4+DQo+Pj4gSW4gdnBjaV97cmVhZCx3cml0ZX06DQo+Pj4NCj4+PiBpZiAoIHZwY2lfaGVhZGVy
X3dyaXRlX2xvY2soLi4uKSApDQo+Pj4gICAgICAgLyogR2FpbiBleGNsdXNpdmUgYWNjZXNzIHRv
IGFsbCBvZiB0aGUgZG9tYWluIHBkZXZzIHZwY2kuICovDQo+Pj4gICAgICAgd3JpdGVfbG9jayhk
LT52cGNpKTsNCj4+PiBlbHNlDQo+Pj4gew0KPj4+ICAgICAgIHJlYWRfbG9jayhkLT52cGNpKTsN
Cj4+PiAgICAgICBzcGluX2xvY2sodnBjaS0+bG9jayk7DQo+Pj4gfQ0KPj4+IC4uLg0KPj4+DQo+
Pj4gVGhlIHZwY2kgYXNzaWduL2RlYXNzaWduIGZ1bmN0aW9ucyB3b3VsZCBuZWVkIHRvIGJlIG1v
ZGlmaWVkIHRvIHdyaXRlDQo+Pj4gbG9jayB0aGUgcGVyLWRvbWFpbiByd2xvY2suIFRoZSBNU0kt
WCB0YWJsZSBNTUlPIGhhbmRsZXIgd2lsbCBhbHNvDQo+Pj4gbmVlZCB0byByZWFkIGxvY2sgdGhl
IHBlciBkb21haW4gdnBjaSBsb2NrLg0KPj4gT2ssIHNvIGl0IHNlZW1zIHlvdSBhcmUgaW4gZmF2
b3Igb2YgdGhpcyBpbXBsZW1lbnRhdGlvbiBhbmQgSSBoYXZlDQo+PiBubyBvYmplY3Rpb24gYXMg
d2VsbC4gVGhlIG9ubHkgbGltaXRhdGlvbiB3ZSBzaG91bGQgYmUgYXdhcmUgb2YgaXMNCj4+IHRo
YXQgb25jZSBhIHBhdGggaGFzIGFjcXVpcmVkIHRoZSByZWFkIGxvY2sgaXQgaXMgbm90IHBvc3Np
YmxlIHRvIGRvDQo+PiBhbnkgd3JpdGUgcGF0aCBvcGVyYXRpb25zIGluIHRoZXJlLg0KPj4gdnBj
aV9wcm9jZXNzX3BlbmRpbmcgd2lsbCBhY3F1aXJlIHdyaXRlIGxvY2sgdGhvdWdoIGFzIGl0IGNh
bg0KPj4gbGVhZCB0byB2cGNpX3JlbW92ZV9kZXZpY2Ugb24gaXRzIGVycm9yIHBhdGguDQo+Pg0K
Pj4gU28sIEkgYW0gZ29pbmcgdG8gaW1wbGVtZW50IHBkZXYtPnZwY2ktPmxvY2sgKyBkLT52cGNp
X2xvY2sNCj4gSSB0aGluayBpdCdzIHRoZSBsZXNzIHVuY2VydGFpbiBvcHRpb24uDQo+DQo+IEFz
IHNhaWQsIGlmIHlvdSB3YW50IHRvIGludmVzdGlnYXRlIHdoZXRoZXIgeW91IGNhbiBzdWNjZXNz
ZnVsbHkgbW92ZQ0KPiB0aGUgY2hlY2tpbmcgaW50byB2cGNpX3Byb2Nlc3NfcGVuZGluZyB0aGF0
IHdvdWxkIGFsc28gYmUgZmluZSB3aXRoDQo+IG1lLCBidXQgSSBjYW5ub3QgYXNzZXJ0IGl0J3Mg
Z29pbmcgdG8gYmUgc3VjY2Vzc2Z1bC4gT1RPSCBJIHRoaW5rIHRoZQ0KPiBwZXItZG9tYWluIHJ3
bG9jayArIHBlci1kZXZpY2Ugc3BpbmxvY2sgc2VlbXMgcXVpdGUgbGlrZWx5IHRvIHNvbHZlDQo+
IG91ciBpc3N1ZXMuDQpPaywgdGhlbiBJJ2xsIGdvIHdpdGggcGVyLWRvbWFpbiByd2xvY2sgKyBw
ZXItZGV2aWNlIHNwaW5sb2NrDQphbmQgd3JpdGUgbG9jayBpbiB2cGNpX3dyaXRlIGZvciBjbWQg
KyBST00uIE9mIGNvdXJzZSBvdGhlcg0KcGxhY2VzIHN1Y2ggYXMgdnBjaV9yZW1vdmVfZGV2aWNl
IGFuZCB2cGNpX3Byb2Nlc3NfcGVuZGluZw0Kd2lsbCB1c2Ugd3JpdGUgbG9jaw0KPg0KPiBUaGFu
a3MsIFJvZ2VyLg0KPg0KVGhhbmsgeW91LA0KT2xla3NhbmRy


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 13:52:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 13:52:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268370.462199 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHQvQ-0001rI-G8; Tue, 08 Feb 2022 13:52:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268370.462199; Tue, 08 Feb 2022 13:52:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHQvQ-0001rB-Cq; Tue, 08 Feb 2022 13:52:56 +0000
Received: by outflank-mailman (input) for mailman id 268370;
 Tue, 08 Feb 2022 13:52:55 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=v7zX=SX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nHQvP-0001pr-G3
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 13:52:55 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 69d4eb6b-88e6-11ec-8eb8-a37418f5ba1a;
 Tue, 08 Feb 2022 14:52:54 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2053.outbound.protection.outlook.com [104.47.14.53]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-39-3DC1BjnpNmarerkCrVEtuA-1; Tue, 08 Feb 2022 14:52:52 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM0PR04MB6691.eurprd04.prod.outlook.com (2603:10a6:208:17a::24)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Tue, 8 Feb
 2022 13:52:50 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.018; Tue, 8 Feb 2022
 13:52:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 69d4eb6b-88e6-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644328374;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=vzThoDqH63O1U50rIVwI3pPFBPNpdKBHP0mIpM+R/QI=;
	b=T/U28dlKZE+KgbymnbtNmZvluQ1Hto74f9aaC2VURFarxBW4DnUcFbvhS5SWiqE5VZdLy1
	az8cGQuFSiDQwQRVpObDJNPQchgZeJXVY3+VejBN1fWwxK9dV/9AbCLsf5tnvAMmldS8H8
	RBLy/Lz+Yduy3doLlNpgtUDzn/7NCNw=
X-MC-Unique: 3DC1BjnpNmarerkCrVEtuA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Wu8nloiEPtfyHqCXlHdqv8H1Bi1GcSNTOYEnlcZ/Jwk1keUCkfu2ZXUO01XT8IoWQqN6XSaKMZwSakzxcQGnPYibNW8QJ8JDpKq4DPvvSET658h5OZPIWsos+KCa+s+L9mMBs5eSml2FfQe+sr2V/F1tSJkNxCv4U2KnKuikCJBaIs7gActUHYkk4xO8Nm2qv3tSP/s1twdqqPhkJlvU2DYHC3JThcuhz/LpQ409ZYwrPN0Xea9Ebl/esbX4tD2cIAChkI+ojt9nZ/Au8LMnse0qLTfcvxVkjpbTLimThInnGtmC//klSU2pcPA/c2Cy3oksf5JQWPaKTknJhHK0IQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=vzThoDqH63O1U50rIVwI3pPFBPNpdKBHP0mIpM+R/QI=;
 b=jf+2IT93kn2D1FsnljDDFGahC6CgjSgNf1u66MfD/moMQVHNmjZRhyPro7F4HaySwiDgLB9uokKV/0hPpwQPDUVY+hVwo+YJ2tQ0GaHDa15vjhgYQCc0+pPF1pILUkdRJMQmJ5Zck9Ws/7dyYc2Xwen7VoLHs90Xe1N1j0wbVY1Juga4hycOpb3Y08YUJZaPuxq+dQUX6KX90hNThmaYHAdzVE/7o7Dja/0dnHzDwQbPw2mZeZe7qrb9Jaz8xLlcWJHadhzJHXa8PKCFvurS9FRI6cel1jNSDi1ZCpGKEa0V9ytcxcZ3LHTNDIHxB3izb7XS3escp04NhLxwQnOgIw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <f725c58c-1f70-893c-b6a4-649c636263ec@suse.com>
Date: Tue, 8 Feb 2022 14:52:48 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH 2/2] x86/xen: Allow per-domain usage of hardware
 virtualized APIC
Content-Language: en-US
To: Jane Malalane <Jane.Malalane@citrix.com>
Cc: Wei Liu <wl@xen.org>, Anthony Perard <anthony.perard@citrix.com>,
 Juergen Gross <jgross@suse.com>, Andrew Cooper <Andrew.Cooper3@citrix.com>,
 George Dunlap <George.Dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Christian Lindig <christian.lindig@citrix.com>, David Scott
 <dave@recoil.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Roger Pau Monne <roger.pau@citrix.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20220127160133.11608-1-jane.malalane@citrix.com>
 <20220127160133.11608-3-jane.malalane@citrix.com>
 <8b59b7d7-2d0a-0b8a-f936-1e537dfc4f9a@suse.com>
 <a4af7c49-99af-b66a-a05f-2907fa6d50f1@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <a4af7c49-99af-b66a-a05f-2907fa6d50f1@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR05CA0031.eurprd05.prod.outlook.com
 (2603:10a6:20b:489::18) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 0738cbbe-a235-4e26-fddb-08d9eb0a4bfd
X-MS-TrafficTypeDiagnostic: AM0PR04MB6691:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB66915746FC180536F954B1FFB32D9@AM0PR04MB6691.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	0Br3+/roqMWHu/IMvrmwUaCqHTcf5soZgwPSoj7O7sEpPhv8460NRdvJ50QUJQnODQo+oMxf0Fyy27IuS/DWwoQJo51Ot4Q5O6bSiO0pXnyTVrRyLn658/kJOk9gslk3kCggKOPKTyba1HkInbO9RPt+zygM3E9zRrigSVB3fVDhN9Ihd57IfvAAeWbo/lJrQpDHm/rUHJgrTfJzVA7v/9pCbmPKSmRH+7rVm8lYq+/CGBveqEdiRplA/RROg51Qts9CDvrXKrHYmCuIqE/F824HmSJ6LurSL5E9RSqnrxFslWVXd9qcs3aKMWn1zIhpjC/zlW9dfRoTByIJF9wO6rO8Erdt/31cYDZl8LOdPtIWarbpC/wvLnm+8Vb9Te1lwJf+pDD9DaBEXt8fk+C3FwMONihcTGIYuRJGX/aobnLRmk2y08hoW6pgIifsaOcEOB+gXXlpvWZuSdiLg+lvFFtCNsaZHEeQnq7X7JLOvaxGMIEcMGVlKUnnOnEG9uKM3GcKIDNDxvdIttJhCe+/V+F4K0escQn4dBu5UdJ9HnYvZk/USZCe03zvMxE7nD9w3oqJ6HGBPyqFiGTNCj/yJqWL/b5QjAA5anu35p1SqH0b25sULtV6z1o0qOeduqmmSR+TTTnGxrQLj3lbwTAKCzLX29Q9/aoGLh0vT1xCkU2JmaQTk2yLuI2HF/K9x09e/kSegXA1T5dvcSwMJtAV7LoyMUXU50YkAgZXJXo7dMB/ITqeFXZdeu1eHhqEEKXF
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(38100700002)(31686004)(316002)(2616005)(8676002)(66556008)(66476007)(66946007)(6506007)(31696002)(8936002)(4326008)(6512007)(6916009)(53546011)(54906003)(508600001)(7416002)(86362001)(83380400001)(36756003)(5660300002)(186003)(26005)(2906002)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?MldheHVMTU9rUjJ5Nmh1ak1hTEhLdjNVSFowWk5Pb0grbjhMS3VtTzUxMCtn?=
 =?utf-8?B?Rnh2YUR4UlNRNGxEM1NQWkY1TEN6N3ltbFVRQlNoTXFFTjZKLzhkOW5ma1Ry?=
 =?utf-8?B?Q2trSlhuUFo4OHdwMFNJdEtMR0ExU2xlTWtNQkVQZ0YrRjM0Zit3NzZPL0Zv?=
 =?utf-8?B?ZXZnTm15Q290RU5oU1QrMGQ0MDMxV1dwbTlYTFNKN1lHdWRRMjdnRngwWHNO?=
 =?utf-8?B?WEROTWRjNUJNY2hJWGsrRFhvUHdGdEhaRHVSMTBWMDZWb0NheGdJNjRTV2o5?=
 =?utf-8?B?dG5KdWNLVjZWQjhGUWVuc1JWaVljaTRDeVJRZmErMGo1QytpZ2hadlAwcmdV?=
 =?utf-8?B?NDU3QnA1QXl1ZGRlck9paTc2blM0VEpPSy82YWFCbmJyRHcxb1BRY09obGpo?=
 =?utf-8?B?WHEzcDBudzRjZEpHdmJNc3BtTnpIUTlZeDY3djBoU3dPclg2eGRQendhMVRL?=
 =?utf-8?B?bmpZNXZBVGtheGxlaDkzRTREdGFldzJQa01nd0ZiL2JrdmZXMmtZMDdkcEwz?=
 =?utf-8?B?Uk9FWEhBdC9QKzFHeWRsNXoxZlpHUG4zQlFjQXdiUHV0UVBwM2wyWFROOHBK?=
 =?utf-8?B?TGc1K2I2REh0aDRQMGE0Y1JGMzl4QkpiSHYvY1FKdXZlZ1J1UkZ1bWFEWitJ?=
 =?utf-8?B?Ym1XZ256ajUrNHdla0FLOVRETUp4bFVqTWFSM3R4cWY3K2J2L3ZLWUkzTDFy?=
 =?utf-8?B?anlVclZoMDNWcVBORVk0VEhQV0x0alpkRERRSXpmRVNZUi8vSUE2dzRvS0JL?=
 =?utf-8?B?SUpLWEliVE43cFFUOUIwRG1RY3gxV0tJQnB5MUpwLzZ3dG03OWNVaFJ0ZVR1?=
 =?utf-8?B?aXlaRzArS3hPMXdwWE9UYmhVZWtHazRqbjRUdFpwUTRTSG1oN21Nd3FNVkhl?=
 =?utf-8?B?T1dLWEEwaGZEb1FNM3JIaDdxaFh3ZFplaDRJWkZKZUl2ZjFQb1dsZU56RUNh?=
 =?utf-8?B?UW1LSkFHRmJRUjZlZS9KbkFhei9zYUh3Ny9JQU40S05JbHpvVDZWeGNWVDlw?=
 =?utf-8?B?cU9tRW9KMVlYeUQ4OEJXZjRXbVpFZlh1NFhmTFVkWVBiRlppbnhFZDZ2THFr?=
 =?utf-8?B?Vkk4ZnRHdlh6UE1zRUdnM3JDOGFycnlPWDRuUUk0S0oxSDI0L2VYV2FvNlJO?=
 =?utf-8?B?Zyt5YUpKa2VJbkJ3a05iamtwV1JKdjVRY1J0L09DRytnR29ZckQ0T3hrUTVQ?=
 =?utf-8?B?RGxrWXRMTEpzU29yRW9xMXRHb0Jtbm8rTzVmRzQ2OG0vT21qc1RjRzFxYVJI?=
 =?utf-8?B?VWRmc2NrRytVdTUxOGMwL1IzQ01VcXVLSFBiNHl3Nm5Cd0cxbUFaRThYak1o?=
 =?utf-8?B?QzVFZlo1NzJ2TnJlQVFSd0ZYd01QZis3RFFnQ3drRHp2ZFpnTC92Sy9KUUpn?=
 =?utf-8?B?Uks4UEMwcHRWems2TVBERitSTEhqaHNheEZGYlNJaVNyZXJHRXVJaFpNclRJ?=
 =?utf-8?B?R2VpMlA4OHhZTThnYnBMY29sWm82cThkaWFGNC9HQjNmLzZ0WWVJd2xQNnQ0?=
 =?utf-8?B?WEkvTUpkWWplUEdBb29NOG04cGtINWJOejIzY2ZINlQzY2lmczJFWXlONTkv?=
 =?utf-8?B?RXJ2SjFoYU5QTzg3VndRVG1ZdlJac0dhalU3dHRKd05xOE5BOXUvbFdwRml0?=
 =?utf-8?B?azJsK01jUjNYTzBRQ3hEWDIzeDdFMmVPazVBMGNDMEF2dE1sRkZjVU5ZNVRB?=
 =?utf-8?B?TjJFbjVKUHRJRUdqOVQrbW16OEdCZHFXTGd6L0REck5KQlQ4UitvNjAxZmpx?=
 =?utf-8?B?R0Z5YXg2SjlaQUYrbTBKV2p1bW9YTEFUMzRXeUpUclZ6TGlqRElMbU5qSTN6?=
 =?utf-8?B?VjgzWVp1eHBKMEQ3czVPd3hPb1hsaEhwSTVJeDF0N2JUQ0lqQnhxNVk2ZS9h?=
 =?utf-8?B?WTI3NGx1M0pBc1V3YTZsM2pzNllEMTkwVTVPclRhWUdFT1VGdElkTE1XT2xG?=
 =?utf-8?B?UmprUSsyNnl0VlpKNFJoNXlWWEsyajNiZ0V0bW4rbHdLU1Z4b3BGSTUxUjJq?=
 =?utf-8?B?dTR0YVM1Y0Z0MzYwRzE1cklRZzFaeTlVQlFwaVI2aFlVc2xBcjhkSGQxS3Uw?=
 =?utf-8?B?T3pERHV2VTdlaFN1a0tGR1RrdUhDNkZIQ0l6WHppck1SU1FlK0E0RmR5RGd4?=
 =?utf-8?B?bUhGYyttcCt1dGRQQ2lGNGV4U2lMeHpvRXh6SkdBSnJ2SFNrNjNVbms2RFFW?=
 =?utf-8?Q?SzyeT65rZGLJ4GR1mfw+z4g=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0738cbbe-a235-4e26-fddb-08d9eb0a4bfd
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2022 13:52:50.8022
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ISUFoE/hqBUly6zcB6y/+Xx6J4fbqKeV9zvpWBf5qI2ZxMkoC5RuDEae3KUllsQMzhDbODy5PUa//l41+KdpXg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6691

On 08.02.2022 14:27, Jane Malalane wrote:
> On 31/01/2022 12:05, Jan Beulich wrote:
>> On 27.01.2022 17:01, Jane Malalane wrote:
>>> Introduce a new per-domain creation x86 specific flag to
>>> select whether hardware assisted virtualization should be used for
>>> x{2}APIC.
>>>
>>> A per-domain option is added to xl in order to select the usage of
>>> x{2}APIC hardware assisted vitualization, as well as a global
>>> configuration option.
>>>
>>> Having all APIC interaction exit to Xen for emulation is slow and can
>>> induce much overhead. Hardware can speed up x{2}APIC by running APIC
>>> read/write accesses without taking a VM exit.
>>
>> This is odd to read for a patch which makes it possible to _turn off_
>> acceleration. Instead it would be interesting to know what problems
>> you have encountered making it desirable to have a way to turn this off.
> 
> After speaking to Andrew he told me of a performance regression that was 
> reported some time ago when enabling apicv related to the pass-through 
> LAPIC timer of a HVM guest causing Xen to intercept the LAPIC timer MSR, 
> making anything that uses the LAPIC timer end up slower than it was 
> before. So, adressing your comment here, other than mentioning how being 
> able to disable acceleration for apicv can be useful when testing and 
> debugging, do you think it's worth mentioning (in more detail) that this 
> perf problem exists, in the commit message.

Yes, I think it would be worth mentioning, as then the purpose of this
change is also to be a workaround there, not just testing/debugging. In
fact this workaround may then be viewed as the primary purpose.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Feb 08 13:58:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 13:58:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268385.462210 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHR0v-0002dh-8b; Tue, 08 Feb 2022 13:58:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268385.462210; Tue, 08 Feb 2022 13:58:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHR0v-0002da-4H; Tue, 08 Feb 2022 13:58:37 +0000
Received: by outflank-mailman (input) for mailman id 268385;
 Tue, 08 Feb 2022 13:58:35 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=GmUj=SX=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nHR0t-0002dU-Te
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 13:58:35 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e9bc8db7-88e6-11ec-8f75-fffcc8bd4f1a;
 Tue, 08 Feb 2022 14:56:30 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e9bc8db7-88e6-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644328714;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=UAjDz+CA7RX42v8BujD8mln2JVzaqpwAsYZzWBfOkZM=;
  b=eqDvExdHsE1nls3vlW03M0FJFTEIL3KSvelFvHJ4XdWi8k3+KvkCQO6k
   hz1zqjf5ScpWWBa6s42AEtx599IMr7dr7vLWDfz/3NFMTQOauMBqQgIBo
   +LHVr3+XjkW/X7F0klK7ZmmwQ85aUPvbrQru6zXotRY/LeQdAN1B9+jlW
   k=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: +3fEt8S3We6OIAOWRYlfroOLn1jYaczmm9ruuFLT2mAbaOJgDAkA71wxVGqa3TnLFg+UyNLilE
 i/lGlSfCXHWogAT4tvjCfPEXvcBVvMwC0imnEEAvyRDCkQSuBnIvxFYqjwbX+zgVejyh2XHhN8
 LHEIK6H37uRUWFYH+NFZPlDPai6zCmf8lcLahHxBsas77CKX7hvU75NFjCgIThwInJCiNC/wrf
 LtVxtsR4t3zPg99+pmoZM9lNqU4tZji0fFR8d7jHJAS+ZkqZhrQ+U1PUu4c4dJi428aV6zr1Vb
 Ho5t/WuhXNjy0YqDVsTcyZB1
X-SBRS: 5.1
X-MesageID: 63644481
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:qoTwU6tGejGu5yfVmRmw2rKMC+fnVHZYMUV32f8akzHdYApBsoF/q
 tZmKWDUb/uCZGWkfoxxaNnioEMHupLSx9VqSgNupSlmRHgQ+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZQP0VOZigHtIQMsadUsxKbVIiGHdJZS5LwbZj2NYy2YjhWmthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 Npl9qyIWFcWYYv1psNFbylFGDxRG/0W9+qSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DJoQQt2sm1TjEJf0nXYrCU+PB4towMDIY2JsQQaqCN
 5NxhTxHVVPhfRMWEW8tJpN9kLyMxXmmeWFfgQfAzUYwyzeKl1EguFT3C/L8YMCHQPJwj0mRp
 2/Y12nhCxRcP9uaoRK79Xariv7KjDnMcosYH72l9dZnmFSWgGcUDXU+TVKmpdGph0j4XMhQQ
 2QO8yozqe4p9UqkTvH0RRj+q3mB1jYWVsBMCeQ85EeIw7DN/geCLmEeS3hKb9lOnOgySD8x3
 1mFheTVFCdvu72YT3Ga3rqMpDb0Mi8QRUcAbyIZSQoO4/H4vZo+yBnIS75LN6q4jcb8Hz3q9
 BmMoDIjnLUYjcMN1KKT8EjOhnSnoZ2hZh444EDbU3yo6it9ZZW5fMq45F7D9/FCIY2FCF6bs
 xAsgNOC5eoDCZWMki2lQ+gXGrytofGfP1X0g0NrHpQn3ySg/TikZ4843d1lDB43aIBeI2avO
 RKN/1MKjHNOAJe0RexHW5PhNJsM9JbHTejVS/vJQfweMpckIWdr4xpSTUKX2mnslm0lnqc+J
 YqXfK6QMJoKNUh05GHoHrlAiNfH0gh7nDqOHs6jk3xLxJLDPCb9dFsTDLeZggnVBougqR6dz
 dtQPtDiJ/53ALynOXm/HWL+wDk3wZkH6XLe9pY/mg2reFMO9IQd5xj5m+JJRmCdt/4J/tokB
 1nkMqOi9HLxhGfcNSKBYW15ZbXkUP5X9CxnYXV9ZA/2iiJ6Ou5DCZvzkLNtLNEaGBFLl6YoH
 5Hphe3cahiwdtg302tENsSsxGCTXB+qmRiPL0KYjMsXJPZdq/jy0oa8JGPHrXBWZgLu7JdWi
 +Dwh2vzHMtYLyw/XZm+QKz0lTuZ4yNC8N+eqmOVe7G/jm23q9M0Q8Ew59dqS/wxxeLrnGPFj
 l3LWkdB/oEgYeYdqbH0uExNlK/we8NWFUtGBWjLq7GwMCjR5G24xoFcFu2PeFjguKncoc1Ov
 M1ZkKPxNuMphlFPv9YuGrpn1/tmtdDuu6Vb3kJvG3CSNwanDbZpI3+n28hTt/ISmu8F6FXuA
 k/fqMNHPbipOd/+FAJDLgQSceneh+ofnSPf7KppLRyitjN35reOTW5bIwKI1H5GNLJwPY58m
 bUhtcca5haRkB0vNtra3ClY+37Vdi4LUrk9t4FcC4ju01J5xlZHaJ3aKyn3/JDQNIkcbhh0e
 meZ3fOQia5dy0zOd2sIOULMhecN144TvB1qzUMZIwjbkNTymfJqjgZa9i46T1oJw0wfgf5zI
 GViK2Z8Ob6Ko2VznMFGUm2hR1NBCRme9hCjwlcFjjSEHUyhV2iLJ2whI+edukse9jsELDRc+
 biZzkfjUCrrI56tjndjBxY9pqyxV8F1+y3DhNujTpaMEJQNaDb4hrOjODgToBz9DMJt3EDKq
 IGGJgqrhXEX4cLIn5AGNg==
IronPort-HdrOrdr: A9a23:xUo3uKFTdSVPiDrZpLqFCpHXdLJyesId70hD6qkvc3Nom52j+/
 xGws536faVslcssHFJo6HmBEClewKnyXcV2/hrAV7GZmfbUQSTXeNfBOfZsljd8mjFh5NgPM
 RbAtZD4b/LfCFHZK/BiWHSebZQo+VvsprY/ds2p00dMj2CAJsQiTuRZDzrdnGfE2J9dOYE/d
 enl4J6jgvlXU5SQtWwB3EDUeSGj9rXlKj+aRpDIxI88gGBgR6h9ba/SnGjr10jegIK5Y1n3X
 nOkgT/6Knmm/anyiXE32uWy5hNgtPuxvZKGcTJoMkILTfHjBquee1aKva/lQFwhNvqxEchkd
 HKrRtlF8Nv60nJdmXwmhfp0xmI6kdY11bSjXujxVfzq83wQzw3T+Bbg5hCTxff4008+Plhza
 NixQuixtVqJCKFuB64y8nDVhlsmEbxi2Eli/Qvg3tWVpZbQKNNrLYY4FheHP47bW7HAbgcYa
 hT5fznlbZrmQvwVQGbgoAv+q3gYp0LJGbJfqBY0fblkQS/nxhCvj8lLYIk7zI9HakGOul5Dt
 L/Q9FVfYF1P74rhJ1GdZQ8qOuMexrwqEH3QSuvyWqOLtB0B5uKke+y3IkI
X-IronPort-AV: E=Sophos;i="5.88,352,1635220800"; 
   d="scan'208";a="63644481"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=SoaaCyPS5Npe09IGiofsMcRIgbcdrrI0c8SSUosJVC8WsZ3NuEWuwxWuO6kCwP51NWko0KNkdHNOSnKsr10V/1LfsItJQwRFxGRmFK+6Gg2E5CD5EXTSrpZMZ4Y9j5nwMSwVoL3C1sqysfVqea2dB2nmIawL4TasMlqwJy5L02fejMepFg6YYBLV6w8kCIRQxl4sOP3BfNS43UHcfxuQEGTc0Xoej4+zxt2FP9tEU4DsjeL5x3xm65TikZ67hwoNp7fiBBUta/UIJUrJD3P6X5j+UL3N3JAg1wzxOhfVqNpw51QIj2/HqXKa07Tb36WJtZgdgTVpxtSKZX6EliQEIQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=UAjDz+CA7RX42v8BujD8mln2JVzaqpwAsYZzWBfOkZM=;
 b=PHob21JWSH0nXMLTa52+oC7veMa2OiMt29Utrubg1WI/vodxuyEflemicYWBOHu7wj6Y0IvolQyDYbyxYeTL6SSvnMMcg/jhgYc3XB0nz0b0wGUa+sJbAgAIm3av0MAasxw8s+YTrfGm8Njv0NcosS4PCj6SoUWruFWT/sTVchYvkQEk9qQrQVGeNBH4AGVHq+goOtiFlC1gEWOQj3RjQFK/aIpRkEMfLn2n20EONdc0osjFriNRwS3I2blCGaPbdfy2GEta9pwQucYW/zK9i5lh2K20QCKc34Nz0+hzJBnDD/NzsziBOm6Fp8PgFohrD1GOnxhAux8Mb3XVzH4uGg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=UAjDz+CA7RX42v8BujD8mln2JVzaqpwAsYZzWBfOkZM=;
 b=td411PWWDNHJtxsbAS8BipVdbLYwYsX9u9x/fsPOIm/5XUqIrIBLACGoPU8bRG9pxOQGHr+EMBiK1EWSoUHFguvAG20td8XDYAlQZOpE7TZUNvOGR5honfHcrSa95U7o1v21gk5DZ/uNCBZg7JVatvu9oMzJTaFFAcXYWSJRsJs=
Date: Tue, 8 Feb 2022 14:58:24 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "julien@xen.org" <julien@xen.org>,
	"sstabellini@kernel.org" <sstabellini@kernel.org>, Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Artem Mygaiev <Artem_Mygaiev@epam.com>,
	"andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
	"george.dunlap@citrix.com" <george.dunlap@citrix.com>, "paul@xen.org"
	<paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>, Rahul Singh
	<rahul.singh@arm.com>
Subject: Re: [PATCH v6 06/13] vpci/header: implement guest BAR register
 handlers
Message-ID: <YgJ3ACIeq3nn4D8v@Air-de-Roger>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-7-andr2000@gmail.com> <YgI3HpFffudiEmNN@Air-de-Roger>
 <498ca523-2642-e35f-b316-0a089f98ca91@epam.com>
 <5bc96dba-e9b8-de2e-f6aa-ae6c604897e8@suse.com>
 <6ac5d7ce-96dd-66e1-c8d1-eff7b0a1349e@epam.com>
 <41552c52-5e2e-5108-ab37-d1fb5d9b5edb@suse.com>
 <a92fb9da-438c-dd59-e7b1-d288a8efa05f@epam.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <a92fb9da-438c-dd59-e7b1-d288a8efa05f@epam.com>
X-ClientProxiedBy: LO2P265CA0160.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:9::28) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 0992303d-3edf-4c90-8a9a-08d9eb0b1610
X-MS-TrafficTypeDiagnostic: BYAPR03MB4022:EE_
X-Microsoft-Antispam-PRVS: <BYAPR03MB4022E6CC53C015A5C0E266908F2D9@BYAPR03MB4022.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: AE2SKvZSvE6i8DuLHtxvGzoblkGFCnFQu5VTJxs2KfX/Oq3QW9DrK4dU8OEJcnmwxQ6m4prJStmqac6yXLUYeZIQIGMyVEvsDyTypqh0mJ8KctX5BXJ6ZidH2Lbq6QxlyF5PEMTzZCttmb+5LYNgxtquXIrP8U5UQXQG5EJ0jjcZLoqs7gNqqxegtxMEMP6fINX9zx1qDnu7b1PyyuO7FMd0gRuC16MJ6whwTplv6dV8JHPsW1S6ahs/SYuTwepIb20uCSid8veQ0jZDnoF1g/dFdzTrdWF4A+484i97aGUHJWYWtQuSYzKmVo5NIDzeS7MKk9FeSSkyFzD+h66SLXf4BilrDivycQlwRbTTkRrBEMBhXKLQViCJkG9IGs0FCDM9kDXvcFgqXA8nQH906LBar5lTsDNdyCyk6doAkKsRgA/FN/KckjNEKeKmyB8frF53CnVnEAy1i+CKnp776f0hIczs9VAyp8R1ckJkFuz88jkrWBCLSTa1DHmm1rvIzTMDx/4ruYgt65jXBn7FuDHi7nRNdx8p65Mzh5GgEfE3D2U3VlOIcncE+P5kNuqTeZj0xKf6O9u5yXfgJyC2hVXbl41dXHi4H6ynpuDSpY6N/de2m3N/uXBr77lMaFUKLJYBpVeth3O7XjeOsyLRYg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(6916009)(54906003)(6512007)(6666004)(53546011)(9686003)(316002)(6506007)(38100700002)(83380400001)(7416002)(66476007)(8676002)(8936002)(4326008)(66946007)(66556008)(6486002)(508600001)(5660300002)(85182001)(86362001)(33716001)(186003)(26005)(4744005)(2906002)(82960400001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OGZwRDFDU1BLK3NaVis1UGtJaklST3FBcVN4UDJWN2NSdTJtTlh6bWtaRk9h?=
 =?utf-8?B?SWIvWTJmaCtheGF6clhUSzlIMEFiVDRRNUNKVVdNTHFjbkd0Zm5POWdNVUR4?=
 =?utf-8?B?V2s5ZU9jSWxzZmZ0d1ZuQkZ2RGJSaUZsSnZGNDNPaE9Ud1hqdUh2blViendz?=
 =?utf-8?B?cGc3VUdEa3hCcVNCQUw4YnJNY0tlVlRKRWEwV3YyY0k0M3o5UkJVK2lhdjVy?=
 =?utf-8?B?NjhHeGJycXIrQTAyL3h1aEVtRUg0OGRiek9KRlpncDY5K1BteVplZmx6Qjla?=
 =?utf-8?B?UWEvQ3czSm9XR1FPM2ZPVS9HSWJ5WmNCRmdVaVRKeStpcVlVR2xhOGJsMFhO?=
 =?utf-8?B?SjZmN2pJTTBZSkpYMFEwWFJPaUhTWFNqdGtEOEtrZjQxcUV3ZGlORm9uWGxu?=
 =?utf-8?B?L2xNZXVreElzM3p4SG8rRWxFMXBZOG5CM2k5VFk1VHY0Uk9SQXJOZ1U5a2Nx?=
 =?utf-8?B?V3ROeWJTNUNrYThBaVorMFo3WHRLdlR2UjQ2andIellhS1VPWnEwa0Q3eElF?=
 =?utf-8?B?ZlAvT3ZSZ2VLY0FJZTZMckhldWRnQkF4Vlo4a3d4bU1yNytmSlRNL0NudGhj?=
 =?utf-8?B?N21HWUFLOWVIWE1hYk9ZUlc3SlJwZWJhTENlcnVpK1BvQjJwempXVzFvS3Bv?=
 =?utf-8?B?anNHaFlsU2djdlFJUS9HZW52WWo1NmIvZzVGTnBmc2JONkVJV2FLM3ZDQmNm?=
 =?utf-8?B?ZkM3Umtpem9aU3VWd0I1N2tPRUluU3hKcjkwZGlzdnhnVzFFOVBFUUw0WUFG?=
 =?utf-8?B?YWs1QnZzM1V0TnZiOE5NOUxqV2tnLysydkhKTTE1RXRsbnZZN3ZqdGx6bjF5?=
 =?utf-8?B?alRPdFJFUlE0cUQzQnd6eWRSQ2RSdndYTkZ1YlU1R1RHSmtwZlFnTkRJS3JV?=
 =?utf-8?B?R05ETHB6cTBaOWVJYlZoYVpRbDZZUDFzck5CR1dzUmJBZmlOM2YxazNxcm1D?=
 =?utf-8?B?M1VPZWNjUkxyUmJNRGl1aFAxemc4K0dLVE15R0V2WXBvZDJUVGxyOHBIZXI3?=
 =?utf-8?B?ZnVuQW1JZ0pkODdWTi9pTmJwYlVsSEpMRWIwd3B5am5YNlhzOE1JMjZJWDN0?=
 =?utf-8?B?M0JUYkFqU1JqM3VPSVBscTFMYkczVHBQazhsUlhQdEFOelRqY216OUlIZXNP?=
 =?utf-8?B?OHRXaWlkYXREcFVZREdtdWdCNWNmV05Fb0kyb3BidEdSSmxCenVXM2R1bGFr?=
 =?utf-8?B?VjgyV3RXb3FHTTlVMjNRUEZRWFlmK0ZLbGk1NGc5Tm5pWVJQakhabVBCcjll?=
 =?utf-8?B?M3Nwb0dhNXkrYW51QTN4N0l2b2pXTjJFNTZ4SXZpZk9IMk1UZlNqZU92V1VB?=
 =?utf-8?B?VjJYQkc3LzdWUzU0K2VGWDFNZkJwY3VHeW9rb2IvV3ZzYUtpK05Ja29tbXZY?=
 =?utf-8?B?cEx5S0txV1QvNWZkR090TXhJL1BzU2k1SitZVkxVZkZZNVBJZHNFejRVWUVV?=
 =?utf-8?B?emVoWDVKZUJxTHVCN25rem85bVRBMDdzbzIrV0l0MnNlVHhHY1NPZ3B3M1lj?=
 =?utf-8?B?M0xSUjJnam0rOFpSRlE1akNhRy9FenY0dnJ6bFhkd1J4cVN5b21Ud1BiUFR3?=
 =?utf-8?B?aWVrbFV4RE0vWTNmcVlTK1llNHBwMFNwOU5uM2Fta2h4ZExadVo3YVdKNTlB?=
 =?utf-8?B?Ty94bVhGNlhub1hkbWFoZ1ZOVlhuRGNaUmI4OXRoUmI1cFJkYnBsME5vUGcy?=
 =?utf-8?B?YnJLSTdneE1xaG9sTkNaRW40OEtBZjEyUk1iejZMSmlZRnRrOGFnb2JLOGp6?=
 =?utf-8?B?UDRpRmROd3lTV1hKQ3RVOENHTkg5UjB3NGljTFFUNk80c1RCWWVWYXlleEI3?=
 =?utf-8?B?QVBPNWwvMzIwcEF4Znh6MVU0eEh3UU11V1gyZk0vd25MOUxqT0o0Z3FVM1ly?=
 =?utf-8?B?ZFJRUDlTS0dOQWpVd3ExYkF2Uzl3Q01qN0NJbmpCTXI5aWJMK1lEMGRyN09V?=
 =?utf-8?B?QjRaUU9lREcxVU1JTkxHcXVXSFBmdGdKQm5xdjM0U1hqMFRKMEk3Vjc3UzFC?=
 =?utf-8?B?bnAzUmMrMUFrNHJLckZrRGRxaHVEcmFRRmw5QnlMSjNMQlBHUjJQc3ZqRWhX?=
 =?utf-8?B?Q1NRMDlwczg4eXQ0dFdSbmpSZmhOTnlQSG9wQ2lDUEFzSHBVVG1Rc3o4bndk?=
 =?utf-8?B?UlJEd1B4VFMrWklqcWFXbDEyOEx5UFRaTnlYVXRrZlUzV1huOHFRbHpScmE2?=
 =?utf-8?Q?8gt/CCaKLNXnkbBcGAoI46k=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0992303d-3edf-4c90-8a9a-08d9eb0b1610
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2022 13:58:29.9486
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UksN/nLZltbikDAIT1Mitfw1HMXMxKU/dIoeLczaLdJ2QfYteGdACxOA5oZeyq0ga45d8LicUINrTgYPrOeaPQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4022
X-OriginatorOrg: citrix.com

On Tue, Feb 08, 2022 at 10:29:22AM +0000, Oleksandr Andrushchenko wrote:
> On 08.02.22 12:15, Jan Beulich wrote:
> > Yes, but I'm not sure this is going to remain just a single use.
> > Furthermore every CONFIG_<arch> is problematic as soon as a new port
> > is being worked on. If we wanted to go with a CONFIG_<arch> here, imo
> > it ought to be CONFIG_X86, not CONFIG_ARM, as I/O ports are really an
> > x86-specific thing (which has propagated into other architectures in
> > more or less strange ways, but never as truly I/O ports).
> I am fine using CONFIG_X86
> @Roger, are you ok with that?

I guess if that's the only instance of having diverging behavior
because of the lack of IO ports I'm fine with using CONFIG_X86.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 14:09:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 14:09:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268394.462221 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHRBQ-0004DF-9v; Tue, 08 Feb 2022 14:09:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268394.462221; Tue, 08 Feb 2022 14:09:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHRBQ-0004D8-69; Tue, 08 Feb 2022 14:09:28 +0000
Received: by outflank-mailman (input) for mailman id 268394;
 Tue, 08 Feb 2022 14:09:26 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=GmUj=SX=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nHRBO-0004D2-3y
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 14:09:26 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b69cb2ba-88e8-11ec-8eb8-a37418f5ba1a;
 Tue, 08 Feb 2022 15:09:24 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b69cb2ba-88e8-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644329364;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=LwRQ86U9fUeZVSWTl8y9PW4TH6QK6utFIa/sksdtkSg=;
  b=Dk98l7or3ytXokyu+RMqZuOwjU7ygaRhcSvh/1VKqWy55eamv7jzZMFV
   S9i1LCK0IN+jg/rg52JHmtlSuMjUvd2KlVkAYVxgM8Od7jR8maWR1Gy7L
   kjTMj2XMDDGGN+KGZGjctRgNoCYr5NXVsX+3dVl966Lqv4k2zEgTOhEYU
   w=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: 7HrXLG6KJhxHFMDfU2UB89Q0lX5LxUc6l+b6nurzE1pLZr0K1eXmIwB0gEC+CwmYNIDiqggrKm
 aZT7WbllJJ40C6gA5/Z45+fVPyhmQfHg/VeGxVth08aeJQaPijt035+fNBwoQ0jvlPsKQ1Yxye
 siuJPxQIbqwck3IfuuW+LnlH12NmAvIoK3tZgSBeSyxsbtWbaQfP1edKHWGFyFhIKTbWeaubjb
 6LhsHn2nNbh0OZk3tUnB+3fljPI0HXCUTeAMUKkVkX6tHVYPU9Nw9BDKsM52Vg5p0GxPib2L52
 sVOjZlYzQJYcNGvt7UWM0CHR
X-SBRS: 5.1
X-MesageID: 63191596
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:ma5PT6PpPap1IojvrR2FkcFynXyQoLVcMsEvi/4bfWQNrUpxgTdWy
 jZMXDqHPKnbN2f2KNp+b9ix90sPv5/WyoRiSwto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6UUsxNbVU8En1500ozw7dRbrNA2rBVPSvc4
 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq
 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYoxrKtYEg0
 JJkiduLSRsUNYz0kss9cTANRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs
 6VFdnZdNXhvhMrvqF6/YvNrick5atHiIasUu216zCGfBvEjKXzGa/uRvI4BgWZu7ixINceZf
 NciaxR1Vk/RXj5EAVkwJdFvtuj90xETdBUH8QnI9MLb+VP71AVs1JD9PdyTfcaFLe18hFqVo
 1Xj7mvwAxwEHNGHwD/D+XWp7sfFkDnnQosUGPu9/+RznVyI7mUJDVsdUl7Tiem0jAuyVsxSL
 2QQ+zEytu4i+UqzVN7/Uhak5nmesXY0QdNQDul88wCLxar86hycQGMDS1ZpVtsis8MnQC0w4
 XWAldjpGD9HvaWcTDSW8bL8hTG4NDURLGQCTTQZVgZD6N7myKkUih/MVd9lHLSCp9v5Ayzrw
 zuKoS49gJ0elccOka68+DjvgS+op5XPZh444EPQRG3NxiR9aY2+boqk82/n/O1AJ4aUSFqGl
 HUcks3Y5+cLZbmWjzCESugJGLCv5t6GPSfajFopGIMunwlB4Fb6I9oWumsnYh40bIBUIlcFf
 XM/pyt+p7UCbWPtRJMwWIKtNs8L9aLPNfbMA6W8gsV1XrB9cwqO/SdLbEGW3nzwnEVErZzTK
 at3Yu73Uy9EVP0PIC6eAr5EjOR1nnxWKXb7GMijpylLx4Zyc5J8pV0tFFKVJt4046qfyOk+2
 4YObpDao/mzvQCXX8U2zWLxBQ1QRZTYLcqvwyCySgJkClA3cFzN89eLndscl3VNxsy5bNvg8
 HCnQVN/w1Hin3DBIgjiQik9NO+2DM8m8yNhZHdE0bOUN58LO9fH0UviX8FvIelPGBJLkZaYs
 MXpi+3fW68SG1wrChwWbIXnrZwKSfhYrVnmAsZRWxBmJ8QIb1WQorfMJ1KznAFTXnvfnZZv+
 NWIi1KEKbJdHF4KJJiNN5qSI6aZ4CF1dBRaBBCTfLG+uSzEreBXFsAGpqVvfJhXdE6Tn2DyO
 sT/KU5wmNQharQdqbHhrauFs52oA615GE9bFHPc9rG4KW/R+W/L/GOKeL/gken1WDym9aO8S
 /9Syv2gYvQLkEwT69h3EqpxzLJ47Nzq/ucIwgNhFXTNTlKqFrI/fSXWgZgR7vVAlu1DpA+7e
 kOT4d0Ga7+HD9zoTQwKLw0/Y+XdifxNwmvO7e44KVnR7TNs+ObVSl1bOhSB0XQPLLZ8PI4/7
 /0mvcoat162hhYwa47UhSFI7WWcaHcHVvx/5J0dBYbqjCsty01DPsOAWnOnvsnXZowVYEcwI
 zKSiK7TvJhmxxLPIygpCHzA/etBnpBS6hpE+0APegaSkd3fi/5pgBAIqWYrTh5Yxwls2v5oP
 jQ5LFV8IKiD8ms6hMVHWGzwSQhNCAfApx70wloN0mbYU1OpRirGK2hkYbSB+0UQ8mR9eDlH/
 e7HlDa5AGiyJMyhjDEvXUNFquD4SY0j/wLPr8mrAsCZEsRoejHimKKvOTIFphaP7RndX6EbS
 T2GJNpNVJA=
IronPort-HdrOrdr: A9a23:AGkDwqsgiBNcsG5JzF3RUoo67skC7oMji2hC6mlwRA09TyXGra
 +TdaUguSMc1gx9ZJhBo7G90KnpewK6yXdQ2/hqAV7EZniahILIFvAY0WKG+VPd8kLFh4xgPM
 tbAs1D4ZjLfCRHZKXBkXiF+rQbsaC6GcmT7I+0pRcdLj2CKZsQlzuRYjzrbHGeLzM2Y6bReq
 Dsgvau8FGbCAsqh4mAdzI4dtmGg+eOuIPtYBYACRJiwA6SjQmw4Lq/NxSDxB8RXx5G3L9nqA
 H+4kHEz5Tml8v+5g7X1mfV4ZgTsNz9yuFbDMjJrsQOMD3jhiuheYwkcbyfuzIepv2p9T8R4Z
 PxiiZlG/42x2Laf2mzrxeo8w780Aw243un8lOciWuLm72OeBsKT+56wa5JeBrQ7EQt+Ptm1r
 hQ4m6fv51LSTvdgSXU/bHzJl9Xv3vxhUBnvf8YjnRZX4dbQqRWt5Yj8ERcF4pFND7m6bogDP
 JlAKjnlblrmGuhHjDkV1RUsZ+RtixZJGbFfqFCgL3Y79FupgE586NCr/Zv20vp9/oGOu55Dq
 r/Q+BVfYp1P7wrhJRGdZM8qPuMexzwqC33QRCvyHTcZeg60iH22tbKCItc3pDeRHVP9up0pK
 j8
X-IronPort-AV: E=Sophos;i="5.88,352,1635220800"; 
   d="scan'208";a="63191596"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=mQKTWrjoGwpyDeOIfK6eYKizfxfkj/a7X84VfriavomFMgNudNEEaPydAped8yY+PE7yMVTDUVR/5aEVKDwd2BSxY2+lRnYp6ViqfVhWgfHUFUTjf6l4TTIsOTf0yLxGpm0EGSMu2haVgMcLqZ/Mv5uxIgCVZHW+jlcfwNH8UgJD6VfmuYcY1sIv7s7zTBa6OQp0AHli9tF/qANY1TnLWdGx+wb9FV1qFeG5rNfCBV/NQFLY5re0dzyjQ1qZzRZBnDoGkIP74M4a9SW7gVvxSyMxVkBipKVM9en0hExS6wDYrRV2zNcUkYGb5lSPVdw3VsoU9z2BbALVY0s1AWDuWw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Lr8IIs307OvsHETBHZnlWCjQWd8h6fIT9/urLdR1Hrg=;
 b=M6QTND6dFI9iJl0S0py1buiidqrhEUDHmwuYO0l12cWptybjIJv/movd3jJ3ANgwxNtWzywYZg2eYNlWD5BHSx+CV4FtBdK9VY3GmWJmHjxg60Xg/o325raIpn74SET9+Du3ShP+kLpVcF1V8JDoaWyKpqH67YKcgRmLBzluhyClmeMLy4pqI3uSe/1yKr62k3tGhYeXw1+Fmf6b8xVlFH4MG2MvEh1nGzEo8nkbf+gf7HNL7hk0RD+aFO43ZwnFDlKQ5sccYr5z9EK8ysy4+38OyQD7GmyLXM7AmbFCz25FCHr9ME3zUWLbjPwskjsHxp8JEDef0fS9ZhdtfBFNWg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Lr8IIs307OvsHETBHZnlWCjQWd8h6fIT9/urLdR1Hrg=;
 b=ndksjSoTM3GN76u6Y+0O6foNoqDxQwM9v2+AHOwHdqlPu+GT8V756s2PCv64EpvP08ve/+ACypcZQnCZmDsH0mqiFsOE2v56sNMINcMeki7JuQCezvYpzVpyf76LX5U/IvfRaR5YRSCLRaoXNAjOq242VptDZwbzqg9LyiylTbM=
Date: Tue, 8 Feb 2022 15:09:10 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: Jan Beulich <jbeulich@suse.com>, "julien@xen.org" <julien@xen.org>,
	"sstabellini@kernel.org" <sstabellini@kernel.org>, Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Artem Mygaiev <Artem_Mygaiev@epam.com>,
	"andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
	"george.dunlap@citrix.com" <george.dunlap@citrix.com>, "paul@xen.org"
	<paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>, Rahul Singh
	<rahul.singh@arm.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v6 09/13] vpci/header: emulate PCI_COMMAND register for
 guests
Message-ID: <YgJ5hmxtTXz9XDdr@Air-de-Roger>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-10-andr2000@gmail.com>
 <7df2379e-1c30-c362-3106-c7ef23af5c73@suse.com>
 <0ff2a524-9a65-861a-df87-cf3f682862d7@epam.com>
 <140e163c-87d0-2ae8-d57b-7ebc6757de9e@suse.com>
 <08d02313-349d-9ad4-926d-0d1419866363@epam.com>
 <186b7264-1190-3df2-415d-f1ec73a7c03f@suse.com>
 <ccaaa9b8-8ed9-054e-b724-70ca07401be9@epam.com>
 <YgJP/jMhWBrLOpb2@Air-de-Roger>
 <ec27927e-6c05-0e61-c0b8-c28bfd4d3d5e@epam.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <ec27927e-6c05-0e61-c0b8-c28bfd4d3d5e@epam.com>
X-ClientProxiedBy: LO2P265CA0275.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:a1::23) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5bd2c424-fad8-4559-8f59-08d9eb0c972b
X-MS-TrafficTypeDiagnostic: PH0PR03MB6350:EE_
X-Microsoft-Antispam-PRVS: <PH0PR03MB6350DE75716623287419CD4B8F2D9@PH0PR03MB6350.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: wRGsdTyhvgVGfFChMOLXgA2Y6CzmITs9DAl/4TvISEFOzO/rwJYvDTjGp+QVSZHUtxAcWKCUtf40+KoRwiGEdbtb+lstAQYNZhTo7+yMT+Gzysvw+ro3OXYqMA2oGLn/aDNBOv8w8rStINE8jI/J2KakZp8T2+BO2RdjvdS0vSTlcnO6LYUrg1sONsX98V/F4D97Ltqov85C6Vk0Z1SUg+EAXUbUMutD0MADOVqcu1Kr/lbWRgMA8AuWC8z7+CajIFhop/QqBa5RUEO4F6nmyWYQacD3Q1RfEnVd3WSe5VMeFqTqPWKiuvOx1yaRBI9rCsoUSrPVycAlXGzQG+3atle34dlz67vG2MGsuoNPbmB8KIwLaCXw1TQLhk5nYrt7Cy5FtJxyYO/b9ezx0jqeQSbpS0WzglOwHpfpCjfGq5E5fzKTvWyRwrFgpInhXI6qqv4SfSiTk4lrb25K5iDcYjuDdJxW8GtHxpNlQhZWQjZLEX4EUTc2uJ43F7B+XZUiYkB+K9s7b+EmINQuqc7E00whODrYwHwScs1/42nkEEJBB9LFLhSQKnVIu0/GTdqmLLn1naBQjzFNUpliDSlo8oiUbqfVbSc/3fINCWhJtqdn42UrLFDjbsYeWoU7DsNEo6tfBIYbHQjaZmGjFFGtZw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(83380400001)(6486002)(33716001)(2906002)(508600001)(38100700002)(82960400001)(7416002)(186003)(8936002)(53546011)(66556008)(66476007)(54906003)(6916009)(85182001)(6666004)(5660300002)(86362001)(66946007)(9686003)(6512007)(26005)(4326008)(316002)(8676002)(6506007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M2txMU5FZkFnVDdkand1S2VGZ1MzM2V5WHF0ellnK2Y1dFp3M3UxbVVoZERp?=
 =?utf-8?B?V0dBQWc1WTdCNG0wYVFReXBucWlmUHkvUWp5cXdsbzhvWkhoTndYeGNuVnRh?=
 =?utf-8?B?RUpxdmMyL1FlZVkrUDI0Zk5FNUpsSkZSRU9kRTU3NytnbmRpc20zaWdQTkZp?=
 =?utf-8?B?RzJxYVBKRlBlVzY1U0tKUlpBYzJEcXBZWFdDK2M1M3FmU1JNVHhzbVRaaUtn?=
 =?utf-8?B?WWkzQmJMMzZCN21oRWdoVlp5dDRQTnBSZWpUZDhWbkJGaDBGV2gzdmxXWmZT?=
 =?utf-8?B?NlMzcXpDZ3FHZXZOVXNsTE0vWlVSaHU4ZGlCUkRVUjU5dm9mZ1JEdVZOb0t0?=
 =?utf-8?B?RW85SkN0VWZxamlLaE1CTXQ5ektXc0liVFhKbVp3ZXVYZmJxYjI4WVB3M2Jn?=
 =?utf-8?B?clBqaWpnU0x1RDVrVHBnVy9WdkkrRjhGTUtyRXlJZm96ZENEUzQ4b0hyd2Vj?=
 =?utf-8?B?S3BzMDRFSnB6ZC9pVUV1c3RYNEQ3MzFNWWlvczMyZEpIUFlJRkU0eVFQSjBM?=
 =?utf-8?B?SDYrVDBRQVFsK3lBenc2RlBldHdTUzk5MFRQZ0NjTkRTV2dESTRoSUt3eFV6?=
 =?utf-8?B?WVdtOFlheWxKd2JDNDdmZzdZTytyajN0cjJUcUFtTzlPRkZ5TnlKU29kd2w2?=
 =?utf-8?B?eFpEWGJXZGhEWDJka0U4MkVNdHYzTmJOdUFoT3o3QmNHUW9obE9xSk5xL3hH?=
 =?utf-8?B?MkppSkJCTjRXNWRpR2hxNHE3dUo3SjRXMjBNZnlQWTUxdDYvbTJ5Zld6V2lz?=
 =?utf-8?B?V29Wb0k0aytmYWZXNEN4bTVrUzNVWHlaOXFhMmR1YXNYcjJxeXYwUHVXL1BV?=
 =?utf-8?B?N1dGQU1hMXZPODlrcjZLYnd2cG1lQmxHWDhyZ1Ara2hFTTgybUxQNTdYNmxL?=
 =?utf-8?B?NzdhL3lENmVoTDZQN2JpM2Z1OXhvT05Xb2ZhelovYjF2dzNGbU44NnZiaEtE?=
 =?utf-8?B?TUx4eWNYSWtUS3JIYng3NWE1ZzVGYldwaStGdW95NlpKd3FuVVQvV2NEYjJm?=
 =?utf-8?B?c09VRW5mbldBR3pIT29FZE00THdKUG5WUWMrbVVKTFVaZk1wL3o4bi9tblF5?=
 =?utf-8?B?cmhEdVU3dURXbEdSSlNsR00vZkhVK0hwSnFXQ24zVFJPbXBkVDF2U3VWM2NU?=
 =?utf-8?B?NUNhZGdtRWkzL2VVZGxhTCs5SDB0U3R5N1hTTnZXTGVya2NYaGpmWnczZThW?=
 =?utf-8?B?Zm51Q1A2MEtKTU5JTGlGUnZVNUdHTFNCbXd5cEl4VkJySUxBZjVUQWFpc1dK?=
 =?utf-8?B?eWVpQXNPc2paL3lKek1OZjd2ZnBTM2dXZUk5eVNmVW5aOW5hRjRZaWFWZ1BR?=
 =?utf-8?B?S3lmWFlROW5vbW5ydzVOZWJidGNVTnlJeWYvUG5JOHp0NkdjWXBndWFjYUg3?=
 =?utf-8?B?NnEvek5UQnB5aWRQQU5ZK2tVdkxxcUxZcmh3cGJKWmc2OUNJcmlxTzFFSVlU?=
 =?utf-8?B?R053Q1JtK21RV3QrbjZLYUZ0R3pIQVp5U3JwWHl1NnRDcjEvVkptdDJ1RjQ0?=
 =?utf-8?B?SzFDd1JBdXhpcVpjdzNuZE5hbjIxRDJDcnQ2OUhKbVpPdi9zeCtyYWhzOHor?=
 =?utf-8?B?Q3Q1Z29zOG1HdUdFd0NPOHk3S3V0TjFSQjFyNFZybDRONG1UTmhFaDUwazd2?=
 =?utf-8?B?RXEwQy96TVU2RWszdWcrazd2U05zS2E2bnliNkNCVFJLc2VpR2NobDd6QkNr?=
 =?utf-8?B?STh6ekF6QzNOTXorMnBxcFJ5Z3ZQOHhxenZreXBMWE8xZWduMHpNS25CcERa?=
 =?utf-8?B?VGZvM0JyWnU3T2JTeUdzOXBwUlh3TGozOFRuckZMOEp3R0Fhb09KbXowK3NH?=
 =?utf-8?B?ZHJTN2FHemdxZVZwR3JQT3hHelpGeGV0eTFRZFd5alZQdXkvZitPZytKNG5G?=
 =?utf-8?B?TXhKbDYxYjk1dm84eE85bDhjMG1OVXBOTVhhMm5jT0x5eVFjT2F1WFpvN3hj?=
 =?utf-8?B?YzQvWFU0Ujk5c21wSmc3c2hYQmZpc2ZsZTRJY2hZanIyNnptU1pDRDVNZXJ5?=
 =?utf-8?B?TWI1YW5ySU9sak5pZzdjSTFra28vRVNZMkdmdlFSS0dJaWZxK2V6RWdPV3lv?=
 =?utf-8?B?em5DaUJ0YXU3M0xVa1lwUzNJNGpOMkYwQnlGN3JFSGdHZnEvT1R1b05mdkRE?=
 =?utf-8?B?UDZzOEpkVEhXQ3N4TzRUaWFpZ1VHOTlsTVZWSkl4ZG11Y24wUytTL3F4NlRi?=
 =?utf-8?Q?we+DTkIMA2rcVe50jj14ugg=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5bd2c424-fad8-4559-8f59-08d9eb0c972b
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2022 14:09:16.0172
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yCEDKQIq0g7VhwI6E5I5kalsEfjsAX8SZoI0qgxTvffegehsz+mnlmJCW95oPQNWqjJwkwLNkBbm2X3SqyY9tQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6350
X-OriginatorOrg: citrix.com

On Tue, Feb 08, 2022 at 11:29:07AM +0000, Oleksandr Andrushchenko wrote:
> 
> 
> On 08.02.22 13:11, Roger Pau Monné wrote:
> > On Tue, Feb 08, 2022 at 09:58:40AM +0000, Oleksandr Andrushchenko wrote:
> >>
> >> On 08.02.22 11:52, Jan Beulich wrote:
> >>> On 08.02.2022 10:38, Oleksandr Andrushchenko wrote:
> >>>> On 08.02.22 11:33, Jan Beulich wrote:
> >>>>> On 08.02.2022 09:13, Oleksandr Andrushchenko wrote:
> >>>>>> On 04.02.22 16:25, Jan Beulich wrote:
> >>>>>>> On 04.02.2022 07:34, Oleksandr Andrushchenko wrote:
> >>>>>>>> --- a/xen/drivers/vpci/header.c
> >>>>>>>> +++ b/xen/drivers/vpci/header.c
> >>>>>>>> @@ -454,6 +454,22 @@ static void cmd_write(const struct pci_dev *pdev, unsigned int reg,
> >>>>>>>>              pci_conf_write16(pdev->sbdf, reg, cmd);
> >>>>>>>>      }
> >>>>>>>>      
> >>>>>>>> +static void guest_cmd_write(const struct pci_dev *pdev, unsigned int reg,
> >>>>>>>> +                            uint32_t cmd, void *data)
> >>>>>>>> +{
> >>>>>>>> +    /* TODO: Add proper emulation for all bits of the command register. */
> >>>>>>>> +
> >>>>>>>> +#ifdef CONFIG_HAS_PCI_MSI
> >>>>>>>> +    if ( pdev->vpci->msi->enabled || pdev->vpci->msix->enabled )
> >>>>>>>> +    {
> >>>>>>>> +        /* Guest wants to enable INTx. It can't be enabled if MSI/MSI-X enabled. */
> >>>>>>>> +        cmd |= PCI_COMMAND_INTX_DISABLE;
> >>>>>>>> +    }
> >>>>>>>> +#endif
> >>>>>>>> +
> >>>>>>>> +    cmd_write(pdev, reg, cmd, data);
> >>>>>>>> +}
> >>>>>>> It's not really clear to me whether the TODO warrants this being a
> >>>>>>> separate function. Personally I'd find it preferable if the logic
> >>>>>>> was folded into cmd_write().
> >>>>>> Not sure cmd_write needs to have guest's logic. And what's the
> >>>>>> profit? Later on, when we decide how PCI_COMMAND can be emulated
> >>>>>> this code will live in guest_cmd_write anyways
> >>>>> Why "will"? There's nothing conceptually wrong with putting all the
> >>>>> emulation logic into cmd_write(), inside an if(!hwdom) conditional.
> >>>>> If and when we gain CET-IBT support on the x86 side (and I'm told
> >>>>> there's an Arm equivalent of this), then to make this as useful as
> >>>>> possible it is going to be desirable to limit the number of functions
> >>>>> called through function pointers. You may have seen Andrew's huge
> >>>>> "x86: Support for CET Indirect Branch Tracking" series. We want to
> >>>>> keep down the number of such annotations; the vast part of the series
> >>>>> is about adding of such.
> >>>> Well, while I see nothing bad with that, from the code organization
> >>>> it would look a bit strange: we don't differentiate hwdom in vpci
> >>>> handlers, but instead provide one for hwdom and one for guests.
> >>>> While I understand your concern I still think that at the moment
> >>>> it will be more in line with the existing code if we provide a dedicated
> >>>> handler.
> >>> The existing code only deals with Dom0, and hence doesn't have any
> >>> pairs of handlers.
> >> This is fair
> >>>    FTAOD what I said above applies equally to other
> >>> separate guest read/write handlers you may be introducing. The
> >>> exception being when e.g. a hardware access handler is put in place
> >>> for Dom0 (for obvious reasons, I think).
> >> @Roger, what's your preference here?
> > The newly introduced handler ends up calling the existing one,
> But before doing so it implements guest specific logic which will be
> extended as we add more bits of emulation
> >   so in
> > this case it might make sense to expand cmd_write to also cater for
> > the domU case?
> So, from the above I thought is was ok to have a dedicated handler

Given the current proposal where you are only dealing with INTx I don't
think it makes much sense to have a separate handler because you end
up calling cmd_write anyway, so what's added there could very well be
added at the top of cmd_write.

> >
> > I think we need to be sensible here in that we don't want to end up
> > with handlers like:
> >
> > register_read(...)
> > {
> >     if ( is_hardware_domain() )
> >         ....
> >     else
> >         ...
> > }
> >
> > If there's shared code it's IMO better to not create as guest specific
> > handler.
> >
> > It's also more risky to use the same handlers for dom0 and domU, as a
> > change intended to dom0 only might end up leaking in the domU path and
> > that could easily become a security issue.
> So, just for your justification: BARs. Is this something we also want
> to be kept separate or we want if (is_hwdom)?
> I guess the former.

I think BAR access handling is sufficiently different between dom0 and
domU that we want separate handlers.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 14:14:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 14:14:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268404.462232 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHRFt-0005fh-Vi; Tue, 08 Feb 2022 14:14:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268404.462232; Tue, 08 Feb 2022 14:14:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHRFt-0005fa-Sh; Tue, 08 Feb 2022 14:14:05 +0000
Received: by outflank-mailman (input) for mailman id 268404;
 Tue, 08 Feb 2022 14:14:04 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1FiY=SX=epam.com=prvs=40383cc40e=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nHRFs-0005fU-MG
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 14:14:04 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 134bcaf0-88e9-11ec-8f75-fffcc8bd4f1a;
 Tue, 08 Feb 2022 15:11:59 +0100 (CET)
Received: from pps.filterd (m0174677.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 218ChTnD015156;
 Tue, 8 Feb 2022 14:13:59 GMT
Received: from eur05-am6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2110.outbound.protection.outlook.com [104.47.18.110])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e3rqqrx8r-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Tue, 08 Feb 2022 14:13:58 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM6PR03MB5784.eurprd03.prod.outlook.com (2603:10a6:20b:f5::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Tue, 8 Feb
 2022 14:13:54 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77%3]) with mapi id 15.20.4951.019; Tue, 8 Feb 2022
 14:13:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 134bcaf0-88e9-11ec-8f75-fffcc8bd4f1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Gpn4eeNjvCSArVWQ9L34tULGg7C2yLYd9N0xKeWbGXPPviw38dljg2pz0pmozWgvjWGaODG3xIwXmksJ7pkvPqiNnPaHraRjCom99ZPvqO5CvVhDtR9JlBhcOXU66Hs1CaXBEkveEW7aWXFIO2TbvBmie5doMjk3cxAjTFoYgZ4u+fPJRj8YjjMYAwB0DKCmCt8cTH6NV2tjX9z7KXYelvVnAwSI/iouPrwLnzMAGJLiql9Cgq8SWdCEnvoXM/RZERVKySQ7tM5I3M0oQtQkPfIqkbNkh8XBC4FkVZnmPDldBl+Q+/4aaSzJjJPpUTNekwWgJw4pVvyoNh06QiUznQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=7g1OeJIVUcCeiee2FCYq/5GYMQLHwoVPUoeZuPMLXmc=;
 b=eR5rRT25PmK9Ldua3I/RXaKC+xAnXg5bWABqHy7FQD42L4qmwY8wYQ6TGjwl87Xv0ICfzshbUOGPNgrd90htpRAK7KzD+UNGSpHDvVi6t7z/QcmjdnBbYJlKn3Ej223YrOA+PceL0fAbTU9edSmrtePtANGCiM8jAv2PpFWsnYSxR1lGwroo/ed9YtrrUvCbxM2AQ9Ry3fjv5J311BJZBEzKYxDI4vnD8zsfkcxa+BgqK2lXJ9nAl+zmG6xDZbCkGChAI5kYG/+J1mmfS+wvpArxslAPne/SNaaevF4oyXrtARBwAiQRawdoxsgRQ3NyKCfCD4vneIvwckMwecTodA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=7g1OeJIVUcCeiee2FCYq/5GYMQLHwoVPUoeZuPMLXmc=;
 b=KHKi8RUFgXi2hY8PFxK0T7sXSd2b37gRNcj0GrmLTCpHcF4QT9pEL7lmE//RN7owEi155n9Jz3eyKSwzTX14PyEudWpRvYMCoxoHYOEkNzFNMfEhkmg+XsM1nsnfcD4VNU6c1EyPxRf2XFGaH0W6ON63P7y0Z0zftPrYjlIVJPwM28eMcxiwUd++pEHVDCrd3LdDsOd6N/qthu0yB8DnyMnpWZqYVziKxT/GfxT1kDEpDQeCvyL74QyG9dCcgDNCa94vQuj/oHUnnJUUkdaysetijyof2RM+EK0Y0ufpcRciYQNFXZTF7QkqThg/TcDdqjoa3Afa7cL5TPhca4fMIg==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: Jan Beulich <jbeulich@suse.com>, "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org" <sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v6 09/13] vpci/header: emulate PCI_COMMAND register for
 guests
Thread-Topic: [PATCH v6 09/13] vpci/header: emulate PCI_COMMAND register for
 guests
Thread-Index: 
 AQHYGZFfEau2yoVfs02TXHZP7JM5E6yDcw0AgAXhW4CAABY4AIAAAW6AgAAD24CAAAHYgIAAFHwAgAAEyQCAACy5AIAAAVKA
Date: Tue, 8 Feb 2022 14:13:54 +0000
Message-ID: <168356f6-fa7f-6d9f-290d-3eccb1e769a0@epam.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-10-andr2000@gmail.com>
 <7df2379e-1c30-c362-3106-c7ef23af5c73@suse.com>
 <0ff2a524-9a65-861a-df87-cf3f682862d7@epam.com>
 <140e163c-87d0-2ae8-d57b-7ebc6757de9e@suse.com>
 <08d02313-349d-9ad4-926d-0d1419866363@epam.com>
 <186b7264-1190-3df2-415d-f1ec73a7c03f@suse.com>
 <ccaaa9b8-8ed9-054e-b724-70ca07401be9@epam.com>
 <YgJP/jMhWBrLOpb2@Air-de-Roger>
 <ec27927e-6c05-0e61-c0b8-c28bfd4d3d5e@epam.com>
 <YgJ5hmxtTXz9XDdr@Air-de-Roger>
In-Reply-To: <YgJ5hmxtTXz9XDdr@Air-de-Roger>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: ac29e80f-8730-4488-fa89-08d9eb0d3d78
x-ms-traffictypediagnostic: AM6PR03MB5784:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM6PR03MB5784762BD0F29A7976DFBD66E72D9@AM6PR03MB5784.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 sLzig4bB1elRV1diiWEiwC8OgpjJthFUddh/+y13ZPbc4qekHoD5LEJzpS/VC690jqzG4c6Bl+H5FAWSsDUNYFdJj6O1jNNohEVK1Go7TfMo92e6+4OkSZJrRVvvi14Khn2baLj975PJS5aT44H0VFcLIuv74K/aF7wwVxTEYIELKxVPUR5EwUzEuHB5gk7w6yy2entLpHWoXzMsUnFbUMYk9gYOudfxBnn4oK0DZo1fC/Q55PkQgm5rYEzeCDwNrIxhymSET+tGfxCk/7bL1J+uaRGx5vMVseT6mfPSxZYkGWklX8d/6rV/czChyYQIAPrMD+ci0qRbTEaqWz26Afdpp6eYGfA6DVTJyuD5/+KIGs12BeZiQX62IwBSUdWmKeCezTHaYirrXZ9dhqIoFwcdLcF2mqMIDkNqrWhleLpzxydFZi9of7c/qwrZKgW7p1reoyTlmCUoiYrrPMAtI2PjBK5ygZ4fs3Ucoa62zkU/AAqmsfoSY6CktA2sMnOpO+p4WWitejwGXe0avT8gisdJbHNei5SVp+lLzDRA3w/KZ7f1lxEQGet0FoogrQNf/MM4WWM9bGbJeCGtLyKRil9PB+j7isfKQpsPVQdLP6PKEbqlYrwIlMyC1MhGXlUACtq0WnD6XAQME5GLFGth5h7HceXx9thpHnbhwIO9pHk6SKMkXA1wJG0XQJyeMweMeIO8zWtMSjzxpBXSM/qJHE0fENpzDzLcjgkZYimC3SamVmr/2X4LkaiPD3RSFRh8
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66446008)(76116006)(66476007)(83380400001)(55236004)(53546011)(38070700005)(86362001)(122000001)(66556008)(508600001)(8936002)(66946007)(64756008)(38100700002)(8676002)(5660300002)(4326008)(91956017)(54906003)(6486002)(6506007)(7416002)(26005)(6916009)(316002)(2906002)(107886003)(2616005)(6512007)(186003)(31696002)(31686004)(36756003)(71200400001)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?RHBQTzRxamt4T3hqT3RLamY3TERVTzliYjdrWlArRGNFSXZveXBMOGozYUVm?=
 =?utf-8?B?c1JCMmNtKzhLbis4R2NRMDRaMUxXcXQ1Z3BOSHk0WUNEaDE5WnRhKzBjbndy?=
 =?utf-8?B?WEVJK2JxcE15RHJlVmJwOHh2NE5XR2theUtna1lVMlYwYmVBdmkyQ1Vmajlv?=
 =?utf-8?B?SVJrMEZnWGpaKzU1UC9SWU1iV0xndHhKRWpyVDIrT2F4UVJteWd0MWxubStE?=
 =?utf-8?B?OTRKQkR6d20ySDA1Y0tUMzVEamFoNkxwbi8wakRtajlvNlcyNFdMcXcxSVpE?=
 =?utf-8?B?YktOVXFUS3VQWThEZ3RHTGlGdTN3Vmt0Q0FPVWdOUlNVMm1jUE9TYytFSkcw?=
 =?utf-8?B?TlJtVHNmWjJaK1ZqOVFUL0huMk1WbDlFdnVJS3A0bWFYSkNSWVNXL09QSjRP?=
 =?utf-8?B?dUJWNi85ZWkvOFZXMGJNUjk3MGNOZnNTMXpWOXR1OE1uY0pxVHZVeHk1UmdR?=
 =?utf-8?B?dFh4YVgrREF0UFd6OXQ4RnNxK2tzNlA4TmV4OGFHUURoQnEyYmR5QlhabnFZ?=
 =?utf-8?B?R2RJcmdMcFFoTnBVT21RWlpCc1FMVHlaNkJ5elk3ZU1FcXAxL0dtaUYvQzVC?=
 =?utf-8?B?bi9pRVZVYUt4K2xvN2FQZ2RocDBheDlwK1BvZTk0OHFOdTdVYk93UzVETnJO?=
 =?utf-8?B?QlZiSC9Fa2RLdUp4L3pqTjkyWC84UVlHSU8xWDhIbVlGNTRYS0M3YjlveFhQ?=
 =?utf-8?B?VG8yOFNyL3FrRmlScGgxR0xZdGQxdlV4SDVWQjZFUlFSVVpDdnVKSlhuTGJh?=
 =?utf-8?B?a1pubmtGWjYvSEVTQ2MzTnpIZ1YrOXZnS2t0bkplSHVheHhwYTAyNkltb3RK?=
 =?utf-8?B?ckdNRHB5ZDFuc3VwNkZvT29GRk80VlM4UVJSM2FyLzRnUmMrY0xQT3F4M0Yr?=
 =?utf-8?B?K0QwRFRpNC9IMEVJUThBeHR2UnU4M3F2ZEE2RnRDcDQvZkp4RHYyWDBna3pV?=
 =?utf-8?B?dk5zL2gyd2JqWEhCQXhNM01Zb0Q1V3g5MzFXdnNVamRVc1pHdDQyWlBQekkw?=
 =?utf-8?B?V1VjV0JKK3c5UHFmcS8rRDdSSGNMc1R5VndJMCs0YnlYQ3BubGNpZmhPZ0xW?=
 =?utf-8?B?V0hlZGxUQVlqMzlGTWRuUW50VXk4ZWxscnhIY2VXK0V3Q3RGbWxkNEhTcVVy?=
 =?utf-8?B?MzE4ZWpqZXBKazhOaUI0azVlSnUyMzlrME5CQlQrbDhWZk84eFAvYlFxUzZj?=
 =?utf-8?B?RWJDUUJZZW1YdDZMeVc4L1FEUWJ0VEhMU2lWQmhKU2tWM0l6WFVITnhqUWdi?=
 =?utf-8?B?M2d0RXhnbkdXbGgzSjIzR3U0aXZJUW5aWUtNbENRM3hSckcxUUUzQ3BxR0F1?=
 =?utf-8?B?MzZsV3N6bjVpaWlvYWRVVEd4NWhCWEhIS3JtQVNGMWhRT1RpajdaSlM3bVll?=
 =?utf-8?B?TmlyYVVGc3hIZUlZSk4ybVhueXJtVnVueGxXTE5BSE9KeTl6VjNldHVyVTV0?=
 =?utf-8?B?Qlg4LzUwa3ArZWZ3WFBla05sb253OFQyazExUVFCN2w2SE0vR2ZRZ01uNEkr?=
 =?utf-8?B?THhONHplWE5qb3IzQkFOcitKc1dJclpJd1F3VUhTSEtJUWVoVS9SanplbkFr?=
 =?utf-8?B?ZkhpMUJSL29UaTU2bDBIUHdhODNTSHc0ZlRwczNndkE3SUt0WlFJWS9BYzFh?=
 =?utf-8?B?dXlTNlAvcFAyekJKdHhUMWlIQUpXb1JNQXBEUndFNmtXMVdIVmYzanp3WkRL?=
 =?utf-8?B?YlZDZGpRVVl6b2pUUVRTVnE4NEVGb0crZnJpeGdmNVpKOGNQblZXTjVwQjNI?=
 =?utf-8?B?YUdCYXIwc1ZIVEhSWlB0WS81WmVzaU40eFJ1MVR2aURzdjZubWVQdU0wYnlK?=
 =?utf-8?B?ZzdndE1qZ3pPQ2NEREovd0kyYTlGRXVvNWtoZ3lTYjZ1b0JmWmhFc0Ivd2xD?=
 =?utf-8?B?L3BGVEw3K2RaYTNOM3lCVWl6ckRqMDNKVEN3eXQvV2pHdXQwdGd2WU9uTkdV?=
 =?utf-8?B?T3NWVjFDVjNXc1RSdXZYaTJWSlA4dWIwTXlicVJEdmNaY3JaUm1HclNkZzdI?=
 =?utf-8?B?WmJXYk15QzBlUHF2eXZBRGtUVHRuTTYrblB2VEphWVUzM1Rnc09tam5XT21I?=
 =?utf-8?B?STFLblJrU1NNeEJJREZrbWMzTDZXWk5Xd2dQMzNZdWk0VkJGWnRzZUNlOW02?=
 =?utf-8?B?dW5YZDNnTEU3clI0ZjNFbWJ2VHdORkpRNVM5Vjh5OFg0UDBDMlBCbm8wcFRI?=
 =?utf-8?B?UjVIekVwZ3lTVk9HUnZPbFVYbE8wSURWMDM4V2NoaVF5Nm91ck5OQ0xMSUo1?=
 =?utf-8?B?dnY1ejQ5M0dheXBZRXA0WmpmYjIxVzVhZVhBUTZobU5oYngyYmtFZ2RMZGc5?=
 =?utf-8?B?TlB5UmgxcEZSdktFZGM0NXBmREdCZFpZdEo1bVVGK0tlRXl4SWxXU3hUT3ZQ?=
 =?utf-8?Q?2kllhoszxJ9nt9S8=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <3DEAF4A66F6ECD49AE262A3922109F48@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ac29e80f-8730-4488-fa89-08d9eb0d3d78
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2022 14:13:54.6983
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 30iN1ygJbX+fLpL4J0TSMeBBy3AemMjUwlaQXPYyRX02xa3AKNSzTrg1olVVTlduceq7KJ5JsW4gcjeNcMbbrV2sCWsjITkF57Tpf3TfVKrYKVd5VAMKcw8Ie9v7oMRp
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR03MB5784
X-Proofpoint-ORIG-GUID: BhKfJQdL0bmpqinHT2PFr2sCHwPTrHur
X-Proofpoint-GUID: BhKfJQdL0bmpqinHT2PFr2sCHwPTrHur
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-08_04,2022-02-07_02,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 clxscore=1015
 lowpriorityscore=0 malwarescore=0 priorityscore=1501 suspectscore=0
 adultscore=0 impostorscore=0 mlxscore=0 spamscore=0 bulkscore=0
 mlxlogscore=816 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202080089

DQoNCk9uIDA4LjAyLjIyIDE2OjA5LCBSb2dlciBQYXUgTW9ubsOpIHdyb3RlOg0KPiBPbiBUdWUs
IEZlYiAwOCwgMjAyMiBhdCAxMToyOTowN0FNICswMDAwLCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5r
byB3cm90ZToNCj4+DQo+PiBPbiAwOC4wMi4yMiAxMzoxMSwgUm9nZXIgUGF1IE1vbm7DqSB3cm90
ZToNCj4+PiBPbiBUdWUsIEZlYiAwOCwgMjAyMiBhdCAwOTo1ODo0MEFNICswMDAwLCBPbGVrc2Fu
ZHIgQW5kcnVzaGNoZW5rbyB3cm90ZToNCj4+Pj4gT24gMDguMDIuMjIgMTE6NTIsIEphbiBCZXVs
aWNoIHdyb3RlOg0KPj4+Pj4gT24gMDguMDIuMjAyMiAxMDozOCwgT2xla3NhbmRyIEFuZHJ1c2hj
aGVua28gd3JvdGU6DQo+Pj4+Pj4gT24gMDguMDIuMjIgMTE6MzMsIEphbiBCZXVsaWNoIHdyb3Rl
Og0KPj4+Pj4+PiBPbiAwOC4wMi4yMDIyIDA5OjEzLCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyB3
cm90ZToNCj4+Pj4+Pj4+IE9uIDA0LjAyLjIyIDE2OjI1LCBKYW4gQmV1bGljaCB3cm90ZToNCj4+
Pj4+Pj4+PiBPbiAwNC4wMi4yMDIyIDA3OjM0LCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyB3cm90
ZToNCj4+Pj4+Pj4+Pj4gLS0tIGEveGVuL2RyaXZlcnMvdnBjaS9oZWFkZXIuYw0KPj4+Pj4+Pj4+
PiArKysgYi94ZW4vZHJpdmVycy92cGNpL2hlYWRlci5jDQo+Pj4+Pj4+Pj4+IEBAIC00NTQsNiAr
NDU0LDIyIEBAIHN0YXRpYyB2b2lkIGNtZF93cml0ZShjb25zdCBzdHJ1Y3QgcGNpX2RldiAqcGRl
diwgdW5zaWduZWQgaW50IHJlZywNCj4+Pj4+Pj4+Pj4gICAgICAgICAgICAgICBwY2lfY29uZl93
cml0ZTE2KHBkZXYtPnNiZGYsIHJlZywgY21kKTsNCj4+Pj4+Pj4+Pj4gICAgICAgfQ0KPj4+Pj4+
Pj4+PiAgICAgICANCj4+Pj4+Pj4+Pj4gK3N0YXRpYyB2b2lkIGd1ZXN0X2NtZF93cml0ZShjb25z
dCBzdHJ1Y3QgcGNpX2RldiAqcGRldiwgdW5zaWduZWQgaW50IHJlZywNCj4+Pj4+Pj4+Pj4gKyAg
ICAgICAgICAgICAgICAgICAgICAgICAgICB1aW50MzJfdCBjbWQsIHZvaWQgKmRhdGEpDQo+Pj4+
Pj4+Pj4+ICt7DQo+Pj4+Pj4+Pj4+ICsgICAgLyogVE9ETzogQWRkIHByb3BlciBlbXVsYXRpb24g
Zm9yIGFsbCBiaXRzIG9mIHRoZSBjb21tYW5kIHJlZ2lzdGVyLiAqLw0KPj4+Pj4+Pj4+PiArDQo+
Pj4+Pj4+Pj4+ICsjaWZkZWYgQ09ORklHX0hBU19QQ0lfTVNJDQo+Pj4+Pj4+Pj4+ICsgICAgaWYg
KCBwZGV2LT52cGNpLT5tc2ktPmVuYWJsZWQgfHwgcGRldi0+dnBjaS0+bXNpeC0+ZW5hYmxlZCAp
DQo+Pj4+Pj4+Pj4+ICsgICAgew0KPj4+Pj4+Pj4+PiArICAgICAgICAvKiBHdWVzdCB3YW50cyB0
byBlbmFibGUgSU5UeC4gSXQgY2FuJ3QgYmUgZW5hYmxlZCBpZiBNU0kvTVNJLVggZW5hYmxlZC4g
Ki8NCj4+Pj4+Pj4+Pj4gKyAgICAgICAgY21kIHw9IFBDSV9DT01NQU5EX0lOVFhfRElTQUJMRTsN
Cj4+Pj4+Pj4+Pj4gKyAgICB9DQo+Pj4+Pj4+Pj4+ICsjZW5kaWYNCj4+Pj4+Pj4+Pj4gKw0KPj4+
Pj4+Pj4+PiArICAgIGNtZF93cml0ZShwZGV2LCByZWcsIGNtZCwgZGF0YSk7DQo+Pj4+Pj4+Pj4+
ICt9DQo+Pj4+Pj4+Pj4gSXQncyBub3QgcmVhbGx5IGNsZWFyIHRvIG1lIHdoZXRoZXIgdGhlIFRP
RE8gd2FycmFudHMgdGhpcyBiZWluZyBhDQo+Pj4+Pj4+Pj4gc2VwYXJhdGUgZnVuY3Rpb24uIFBl
cnNvbmFsbHkgSSdkIGZpbmQgaXQgcHJlZmVyYWJsZSBpZiB0aGUgbG9naWMNCj4+Pj4+Pj4+PiB3
YXMgZm9sZGVkIGludG8gY21kX3dyaXRlKCkuDQo+Pj4+Pj4+PiBOb3Qgc3VyZSBjbWRfd3JpdGUg
bmVlZHMgdG8gaGF2ZSBndWVzdCdzIGxvZ2ljLiBBbmQgd2hhdCdzIHRoZQ0KPj4+Pj4+Pj4gcHJv
Zml0PyBMYXRlciBvbiwgd2hlbiB3ZSBkZWNpZGUgaG93IFBDSV9DT01NQU5EIGNhbiBiZSBlbXVs
YXRlZA0KPj4+Pj4+Pj4gdGhpcyBjb2RlIHdpbGwgbGl2ZSBpbiBndWVzdF9jbWRfd3JpdGUgYW55
d2F5cw0KPj4+Pj4+PiBXaHkgIndpbGwiPyBUaGVyZSdzIG5vdGhpbmcgY29uY2VwdHVhbGx5IHdy
b25nIHdpdGggcHV0dGluZyBhbGwgdGhlDQo+Pj4+Pj4+IGVtdWxhdGlvbiBsb2dpYyBpbnRvIGNt
ZF93cml0ZSgpLCBpbnNpZGUgYW4gaWYoIWh3ZG9tKSBjb25kaXRpb25hbC4NCj4+Pj4+Pj4gSWYg
YW5kIHdoZW4gd2UgZ2FpbiBDRVQtSUJUIHN1cHBvcnQgb24gdGhlIHg4NiBzaWRlIChhbmQgSSdt
IHRvbGQNCj4+Pj4+Pj4gdGhlcmUncyBhbiBBcm0gZXF1aXZhbGVudCBvZiB0aGlzKSwgdGhlbiB0
byBtYWtlIHRoaXMgYXMgdXNlZnVsIGFzDQo+Pj4+Pj4+IHBvc3NpYmxlIGl0IGlzIGdvaW5nIHRv
IGJlIGRlc2lyYWJsZSB0byBsaW1pdCB0aGUgbnVtYmVyIG9mIGZ1bmN0aW9ucw0KPj4+Pj4+PiBj
YWxsZWQgdGhyb3VnaCBmdW5jdGlvbiBwb2ludGVycy4gWW91IG1heSBoYXZlIHNlZW4gQW5kcmV3
J3MgaHVnZQ0KPj4+Pj4+PiAieDg2OiBTdXBwb3J0IGZvciBDRVQgSW5kaXJlY3QgQnJhbmNoIFRy
YWNraW5nIiBzZXJpZXMuIFdlIHdhbnQgdG8NCj4+Pj4+Pj4ga2VlcCBkb3duIHRoZSBudW1iZXIg
b2Ygc3VjaCBhbm5vdGF0aW9uczsgdGhlIHZhc3QgcGFydCBvZiB0aGUgc2VyaWVzDQo+Pj4+Pj4+
IGlzIGFib3V0IGFkZGluZyBvZiBzdWNoLg0KPj4+Pj4+IFdlbGwsIHdoaWxlIEkgc2VlIG5vdGhp
bmcgYmFkIHdpdGggdGhhdCwgZnJvbSB0aGUgY29kZSBvcmdhbml6YXRpb24NCj4+Pj4+PiBpdCB3
b3VsZCBsb29rIGEgYml0IHN0cmFuZ2U6IHdlIGRvbid0IGRpZmZlcmVudGlhdGUgaHdkb20gaW4g
dnBjaQ0KPj4+Pj4+IGhhbmRsZXJzLCBidXQgaW5zdGVhZCBwcm92aWRlIG9uZSBmb3IgaHdkb20g
YW5kIG9uZSBmb3IgZ3Vlc3RzLg0KPj4+Pj4+IFdoaWxlIEkgdW5kZXJzdGFuZCB5b3VyIGNvbmNl
cm4gSSBzdGlsbCB0aGluayB0aGF0IGF0IHRoZSBtb21lbnQNCj4+Pj4+PiBpdCB3aWxsIGJlIG1v
cmUgaW4gbGluZSB3aXRoIHRoZSBleGlzdGluZyBjb2RlIGlmIHdlIHByb3ZpZGUgYSBkZWRpY2F0
ZWQNCj4+Pj4+PiBoYW5kbGVyLg0KPj4+Pj4gVGhlIGV4aXN0aW5nIGNvZGUgb25seSBkZWFscyB3
aXRoIERvbTAsIGFuZCBoZW5jZSBkb2Vzbid0IGhhdmUgYW55DQo+Pj4+PiBwYWlycyBvZiBoYW5k
bGVycy4NCj4+Pj4gVGhpcyBpcyBmYWlyDQo+Pj4+PiAgICAgRlRBT0Qgd2hhdCBJIHNhaWQgYWJv
dmUgYXBwbGllcyBlcXVhbGx5IHRvIG90aGVyDQo+Pj4+PiBzZXBhcmF0ZSBndWVzdCByZWFkL3dy
aXRlIGhhbmRsZXJzIHlvdSBtYXkgYmUgaW50cm9kdWNpbmcuIFRoZQ0KPj4+Pj4gZXhjZXB0aW9u
IGJlaW5nIHdoZW4gZS5nLiBhIGhhcmR3YXJlIGFjY2VzcyBoYW5kbGVyIGlzIHB1dCBpbiBwbGFj
ZQ0KPj4+Pj4gZm9yIERvbTAgKGZvciBvYnZpb3VzIHJlYXNvbnMsIEkgdGhpbmspLg0KPj4+PiBA
Um9nZXIsIHdoYXQncyB5b3VyIHByZWZlcmVuY2UgaGVyZT8NCj4+PiBUaGUgbmV3bHkgaW50cm9k
dWNlZCBoYW5kbGVyIGVuZHMgdXAgY2FsbGluZyB0aGUgZXhpc3Rpbmcgb25lLA0KPj4gQnV0IGJl
Zm9yZSBkb2luZyBzbyBpdCBpbXBsZW1lbnRzIGd1ZXN0IHNwZWNpZmljIGxvZ2ljIHdoaWNoIHdp
bGwgYmUNCj4+IGV4dGVuZGVkIGFzIHdlIGFkZCBtb3JlIGJpdHMgb2YgZW11bGF0aW9uDQo+Pj4g
ICAgc28gaW4NCj4+PiB0aGlzIGNhc2UgaXQgbWlnaHQgbWFrZSBzZW5zZSB0byBleHBhbmQgY21k
X3dyaXRlIHRvIGFsc28gY2F0ZXIgZm9yDQo+Pj4gdGhlIGRvbVUgY2FzZT8NCj4+IFNvLCBmcm9t
IHRoZSBhYm92ZSBJIHRob3VnaHQgaXMgd2FzIG9rIHRvIGhhdmUgYSBkZWRpY2F0ZWQgaGFuZGxl
cg0KPiBHaXZlbiB0aGUgY3VycmVudCBwcm9wb3NhbCB3aGVyZSB5b3UgYXJlIG9ubHkgZGVhbGlu
ZyB3aXRoIElOVHggSSBkb24ndA0KPiB0aGluayBpdCBtYWtlcyBtdWNoIHNlbnNlIHRvIGhhdmUg
YSBzZXBhcmF0ZSBoYW5kbGVyIGJlY2F1c2UgeW91IGVuZA0KPiB1cCBjYWxsaW5nIGNtZF93cml0
ZSBhbnl3YXksIHNvIHdoYXQncyBhZGRlZCB0aGVyZSBjb3VsZCB2ZXJ5IHdlbGwgYmUNCj4gYWRk
ZWQgYXQgdGhlIHRvcCBvZiBjbWRfd3JpdGUuDQpHb29kDQo+DQo+Pj4gSSB0aGluayB3ZSBuZWVk
IHRvIGJlIHNlbnNpYmxlIGhlcmUgaW4gdGhhdCB3ZSBkb24ndCB3YW50IHRvIGVuZCB1cA0KPj4+
IHdpdGggaGFuZGxlcnMgbGlrZToNCj4+Pg0KPj4+IHJlZ2lzdGVyX3JlYWQoLi4uKQ0KPj4+IHsN
Cj4+PiAgICAgIGlmICggaXNfaGFyZHdhcmVfZG9tYWluKCkgKQ0KPj4+ICAgICAgICAgIC4uLi4N
Cj4+PiAgICAgIGVsc2UNCj4+PiAgICAgICAgICAuLi4NCj4+PiB9DQo+Pj4NCj4+PiBJZiB0aGVy
ZSdzIHNoYXJlZCBjb2RlIGl0J3MgSU1PIGJldHRlciB0byBub3QgY3JlYXRlIGFzIGd1ZXN0IHNw
ZWNpZmljDQo+Pj4gaGFuZGxlci4NCj4+Pg0KPj4+IEl0J3MgYWxzbyBtb3JlIHJpc2t5IHRvIHVz
ZSB0aGUgc2FtZSBoYW5kbGVycyBmb3IgZG9tMCBhbmQgZG9tVSwgYXMgYQ0KPj4+IGNoYW5nZSBp
bnRlbmRlZCB0byBkb20wIG9ubHkgbWlnaHQgZW5kIHVwIGxlYWtpbmcgaW4gdGhlIGRvbVUgcGF0
aCBhbmQNCj4+PiB0aGF0IGNvdWxkIGVhc2lseSBiZWNvbWUgYSBzZWN1cml0eSBpc3N1ZS4NCj4+
IFNvLCBqdXN0IGZvciB5b3VyIGp1c3RpZmljYXRpb246IEJBUnMuIElzIHRoaXMgc29tZXRoaW5n
IHdlIGFsc28gd2FudA0KPj4gdG8gYmUga2VwdCBzZXBhcmF0ZSBvciB3ZSB3YW50IGlmIChpc19o
d2RvbSk/DQo+PiBJIGd1ZXNzIHRoZSBmb3JtZXIuDQo+IEkgdGhpbmsgQkFSIGFjY2VzcyBoYW5k
bGluZyBpcyBzdWZmaWNpZW50bHkgZGlmZmVyZW50IGJldHdlZW4gZG9tMCBhbmQNCj4gZG9tVSB0
aGF0IHdlIHdhbnQgc2VwYXJhdGUgaGFuZGxlcnMuDQpNYWtlcyBzZW5zZQ0KPiBUaGFua3MsIFJv
Z2VyLg0KVGhhbmsgeW91LA0KT2xla3NhbmRy


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 14:21:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 14:21:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268414.462243 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHRMd-00075h-M4; Tue, 08 Feb 2022 14:21:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268414.462243; Tue, 08 Feb 2022 14:21:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHRMd-00075a-IS; Tue, 08 Feb 2022 14:21:03 +0000
Received: by outflank-mailman (input) for mailman id 268414;
 Tue, 08 Feb 2022 14:21:02 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=GmUj=SX=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nHRMc-00075U-Lv
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 14:21:02 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0c81d923-88ea-11ec-8f75-fffcc8bd4f1a;
 Tue, 08 Feb 2022 15:18:56 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0c81d923-88ea-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644330060;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=pIte53h44x5fhUYlY3VTcKRLTA+ctGQktC/DEOz+c6A=;
  b=ZUN9YZy2AinhrN5M2fmSggFaGLkBZgCe0wolBeGb0rLnaDxuewTGLVb3
   gwGI60tNyHoDD93Lh5KuUkInOYIeFLjTKpO3svwR7fzplcrFQu6DqRqeb
   ObjgqXBZgILAqN03aW0oyvlY0UCtbfFnPmB3k9gIsVgpNsffZfRbyk81/
   g=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: +xiYGoC+qsegN+JHcbXLsLRJBdoO+nyMEAIssiK/Pn3YZtdGYrMFUl695Rb8vK3pRUqnKp4mBN
 nPsG7G61p3llZ5uXqKEvovMBTbnSW33HOuJwhRLE5T8AuJQfcFg6X128GBk8YUaVfrmQ0CHpGs
 GrenPpz+N3tti5gNmwuDe6HnWuVfAicqRoDPeL3IwUPbBR2iqUOhD8mJuKYNS3NvFNET12K3Uh
 OrqTVgzaD9s1bzOElx6xJkgifxrFXRKaNmUaSCMyNr6RzLKteFVZc8cz3EGa4HkTgbVU4cKQjm
 IRU8uJ0f37Tk/DNsDQEUBQDj
X-SBRS: 5.1
X-MesageID: 63193085
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:kKQwVayrbMWrbaYjgKN6t+flwSrEfRIJ4+MujC+fZmUNrF6WrkUFm
 zYdWW6AbP+KMTH8eogkO46zpxkHu8PSzYRnSgJq+SAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAhLeNYYH1500g7wbZp2tcAbeWRWGthh
 /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL
 wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt9xXx
 exzvKaicAsgA4flocoabSJzGggraMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr
 6ZBbmlQMFbT3Ipaw5riIgVort4kI8TxepsWp1lrzC3DDOZgSpfGK0nPzYEDhWZr3pATdRrYT
 9oaWzt/RTbbWRlCGG5IJak4hbyKnVCqJlW0r3rK/PFqsgA/1jdZz7zFINfTPNuQSq19jkue4
 27L4Wn9KhUbL8CEjyqI9Gq2ge3Clj+9X5gdfJW6/PN3hFyYxkQIFQYbE1C8pJGEZlWWAowFb
 RZOo2x38PZ0pBfDosTBswOQrFiJhyAVYchpH+QHwii05K3q2C2QLz1RJtJeU+AOuMgzTD0s8
 1aGmdL1GDBi2IGopWKhGqS89m3rZ3VMRYMWTWpdFFZevYG/yG0mpk+XFr5e/LiJYsoZ8N0a6
 xSDt2AAiroalqbnPI3rrAmc01pASnUkJzPZBzk7vEr4tGuVh6b/PuREDGQ3Ct4afe6koqGp5
 iRspiRnxLlm4WuxvCKMWv4RO7qi+uyINjbR6XY2QcV9rmX0oiDyJ9kLiN2bGKuOGpxVEQIFn
 WeJ4V8BjHOtFCfCgVBLj3KZVJ1xkPmI+SXNXfHIdNteCqWdhyfclByCkXW4hji3+GB1yPlXE
 c7CLa6EUCZLYYw6nWHeb7pMjtcDmHtkrUuNHs+T8vhS+efHDJJjYexeawXmgyFQxP7snTg5B
 P4Fb5TTkEgEALSlCsQVmKZKRW03wbEALcmeg+Rcd/KZIxogH2ckCvTLxqgmdZAjlKNQ/tokN
 FnmMqOB4Fag13DBNyuQbXVvNOHmUZpl9CppNi0wJ1e4nXMkZN/3vqsYcpI2e5gh9fBikqEoH
 6VUJZ3YD6QdUCnD9hQccYL58N5oeiO0iF/cJCGiejU+IcJtHlSb5t/+cwLz3yASFS7r59Amq
 rit21qDE5oOTghvFujMb/erww/jtHQRgrsqDUDJPsNSaAPn940zc379ifo+IsctLxTfx2TFi
 1bKUElA/eSU+t076tjEg6yAvryFKeomExoIBXTf4Ja3KTLeojipz7hfXbvaZjvaTm71pvmvP
 L0H0/HmPfQbt19WqI4gQa1zxKcz6taz9b9XygNoQCfCY1ixU+4yJ3CH2Y9Et7FXx68fsgyzA
 xrd9t5fMLSPGcXkDF9Oe1Z1MrXdjakZymvI8PA4AETm/ysmrrOIXHJbMwSIlCEAfqB+N5kow
 Lt5tcMbg+BlZsHG7jpSYvhoylmx
IronPort-HdrOrdr: A9a23:XesoaqNIqtUw+cBcT1v155DYdb4zR+YMi2TDiHoedfUFSKOlfp
 6V8MjztSWVtN4QMEtQ/+xoHJPwPE80kqQFnbX5XI3SJjUO3VHIEGgM1/qG/9SNIVybygcZ79
 YeT0EcMqyBMbEZt7eD3ODQKb9Jq7PrgcPY59s2jU0dNj2CA5sQnjuRYTzra3GeKjM2YqbQQ/
 Gnl7R6TnebCD4qR/X+IkNAc/nIptXNmp6jSRkaByQ/4A3LqT+z8rb1HzWRwx9bClp0sPsf2F
 mAtza8yrSosvm9xBOZ/2jP765OkN+k7tdYHsSDhuUcNz2poAe1Y4ZKXaGEoVkO0aySwWdvtO
 OJjwYrPsx15X+UVmapoSH10w2l6zoq42+K8y7QvVLT5ejCAB4qActIgoxUNjHD7VA7gd162K
 VXm0qEqpt+F3r77WXAzumNcysvulu/oHIkn+JWpWdYS5EiZLhYqpFa1F9JEa0HADnx5OkcYa
 dT5fnnlbVrmG6hHjLkVjEF+q3oYp1zJGbIfqE6gL3U79AM90oJi3fxx6Qk7wE9HdwGOt55Dt
 //Q9ZVfYd1P7grhJJGdZQ8qPSMexnwqDL3QSqvyAfcZeo600ykke+C3Fxy3pDtRKA1
X-IronPort-AV: E=Sophos;i="5.88,352,1635220800"; 
   d="scan'208";a="63193085"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Pbol0T88iJijiMaBr8DtkzSbbt+C6/VXFFFIubn6rJ551rlt0CcmDPn8PmFtHUzvM32ofscfupah62OmiX8T51FThAOPncCWA5cFEHnzSHQKB+81ZlbrO2tlsbNEiGWSPIifh8DzivHI25RohvCNHS7UrPAW1fsqave6pYkjrOuuNxXbRPj4abtVBEIradEEoCUDrA4tWMzEyDC8aLOV02LUS1tfAvXAzfyV6oRgjRENxkgypzfcfnfykIIRtH6B1y/vFnIrKvjV5Oe+tOmFh9v4Li0JrQkL2owpa3AcmOwJ/nMfl6RWPLOAKX04LzOyanYIDj4sXF5At9FyEolWSg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=3gxTzl/mPoCjmNud5hzbeUq0vipQfH+7SjjRAOhJ22k=;
 b=nwns9HNFYzkQGt7kllRS+APKAz27Qs0vwohYA7gknEusqLevxK6M5lKEh8ZckTcMi8+4x2CH6767u37w4x/YLYf1+bNYH5r3gb68lJNy1pOb7pAx46z0n4hqBlMuKrq2HR16GNpmNC6FC6/TC//iKudzQ3nVHr01T2tNxB5ylPkkIRIArUVObbdfvB8Mi6Lt9UK9jx8jszxV2ED7huW8feUHmoASmo24P13Mko9hGke2S6T8Ojim5ecLvZTmZ9DypXX19ONk4VfRv46hY4FeOzD0CrKZV93RHzwIbtSTMWkzGUyzyWkdk8lIOrg3c7jjzDGqt6oeVHiRGHvcoZXiKA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=3gxTzl/mPoCjmNud5hzbeUq0vipQfH+7SjjRAOhJ22k=;
 b=nEMgPPOidvTOgUX3i++x4KkYZ0DH1FYvY4pd9fGSmjBNANb5ArsF6/7B0FVp3i6dX/eYslc4rrpnc2slHEOAJ+5agPajoA025OALxhOd5bXfTuLZuQgNcumDj6nfYTGiLvrE0tnjmL5r6f6OpR/cviIFgpkINN/LCgSomFTzVI4=
Date: Tue, 8 Feb 2022 15:20:52 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Andrew
 Cooper" <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH] x86/Intel: don't log bogus frequency range on Core/Core2
 processors
Message-ID: <YgJ8REZepbp7WKnv@Air-de-Roger>
References: <419db65a-a6f2-f812-d51e-7a23d065d460@suse.com>
 <YgIv3O8ojoDK+wiR@Air-de-Roger>
 <1680d537-fb6d-c589-66bd-f845b8280308@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1680d537-fb6d-c589-66bd-f845b8280308@suse.com>
X-ClientProxiedBy: LO4P123CA0231.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1a6::20) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c71f93d5-fc9a-4fca-4a25-08d9eb0e38c2
X-MS-TrafficTypeDiagnostic: DM5PR03MB2570:EE_
X-Microsoft-Antispam-PRVS: <DM5PR03MB25700BFB6EC3C1FF5E9BBFEB8F2D9@DM5PR03MB2570.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: cU1tJfhbpUjmT3oH6WQ2Dna5YssjMCMEKmMEwmkmqCheAzszzSx/9EpdMUvUenvx6G1wc+tO7A1kI4RRahL1xDdSxqGI8FfOC5BGJJ70CUKwLE7uf6XOMCubQdjCJdhJYPjAMCZBGAGN+kzCkRc3qIqhqLjrhAfjcvBc07gj5AIEGHwBAX9Ocmb9W4aPTFEz1RpfQA5XQXca8tMQFMITslTjJKfRUeyfj626+s0fFEIDdS85cpl4YJ5XcGn7WteZ/EJVdQ4wZ36Wj/NmvU9PQdwoj9O+gk72WNI7DelkcFfg3sO0Pwd1SvWEw4tj9H57JrIaOGBxJsp9EZ88uNCcYbWoW8AAt05m5TkPFArnGXEnqBkaU+EuVlvxqYxmzSsP9PV8U1rFeE2Hy3pF1OtZm5fB4+3z3q7mFsfcDm13dfyJJb7MHVPyEAmqit8C1Gm70t7SV2+S/LlXWmMgFzGSTpXZVKcqsZyCQzOsk7QjhDh+2pwPLbqdSNp3t3AyH8YzvljFEnp/EVlhFgkXWwA9j3j7ndBfjOYObMM/my/VVWmHszewxe9jA9DrP0D7GdSZ8nsFw2loyxZoK3Ojg26P8EFN+1tEl5KksbGTRRSIlU7eUnHUo/hUymB1CHkSEnu79Dzm3bdLd3w27EqIwI7Cig==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(2906002)(5660300002)(6916009)(6486002)(508600001)(33716001)(82960400001)(316002)(85182001)(186003)(54906003)(38100700002)(66476007)(9686003)(6512007)(26005)(8936002)(8676002)(86362001)(4326008)(83380400001)(6666004)(66556008)(66946007)(53546011)(6506007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UHdUNlBZbzA2OFFpOGZTUm1oMUFjMDFJdXlhOHN2d3ZlUFlBUTRqTlJmWTkx?=
 =?utf-8?B?Tkp3OFNhbjBpSmNITHZMM3hIMGdOYWJTYTEvYjcyQmI4eGhFeVovUWRVbFBE?=
 =?utf-8?B?Z1c4R3FhN0xuL1pPU2RaVWVaMmxYcmJhT0pzMi9BaFZjajJ5eG1yOG5ucjB0?=
 =?utf-8?B?cVJ3Q0gvdEpYMkdqUlUvanFYL2RIU2ZQR2ZXb3lYUWtYOTYrQkYvaE9JbkJx?=
 =?utf-8?B?QmVtTlU4V2NRS2lhN0dLN3l1RmpONlNmdkRvM0IxY3FpNUREK3h6Y2tQR2FV?=
 =?utf-8?B?V0EreVJHQUdTLy9IUDNzc3luVzgzUGo4bGVVRFo1QlhFZHJqYWtvaFlVVjQ2?=
 =?utf-8?B?VGdEZVVzSTYvU250K0tsamYvU1JZZU1ac3FnSi8yam5DVVhUSm5PRmlOc0N1?=
 =?utf-8?B?QVZCb05vZFVlWnk0enVVRmFuQjJheDZVZC9CWXJySVN2d00rYmJaMkhmTW1D?=
 =?utf-8?B?UDdqalc4eUxNZ3YyQSthSy9kbjQ5MTVENUVNY21pQTV2YmhUYytJNllXTzZF?=
 =?utf-8?B?VjZIVWk4cGFFZ1FUNDBpeTFBL0VjU09mY1lxYTI2cURCQUs2Y0tjdzlaUEdL?=
 =?utf-8?B?bTR4SytSM0NXMXRTYzZ4eXZnVWQzRUJ5eGF0dzBWY0hJQWlLLzd6VUYvcGlX?=
 =?utf-8?B?eWUzZVRmbFlaY0d3RVQydnZpVlBWTGlEOTd6eG96RHozYUFEZm1wdHp2MVNF?=
 =?utf-8?B?MG1ueStIUnd1YlRSaWJOSHV3RTlzSUtDY3F4TCtodGNqNkJhU0pLVjdnWXlz?=
 =?utf-8?B?dUlGK096VW41Qi95OG1GaHdkVFZITUVIMGdzRVRMbndpVEVSbWtieXRrTVlm?=
 =?utf-8?B?b3RQbTJuM3FFNnkxRTloYzVtbU1qTm8xa0QzbHVaVUdOeUVGZXp1S0R0MHRE?=
 =?utf-8?B?bU9PR0RtZ2FiS09ZeFV2K0VOaGRWZXlMK3Vzd1hKbTlSUXM0VHNvYktIcXRJ?=
 =?utf-8?B?dGMvSldFUG9DNjhhc09obEFpd01vM0FiMzhJYTJRall0MmdkT0ZUMDlCMEFC?=
 =?utf-8?B?L2lkdCsvUEw5WW5oR0RwajlkVjdXMmdzL04vbCtPSGJkeEFyQ3VCT1NLRUxV?=
 =?utf-8?B?M3JWdnYzNE93Sk1NZnAxTENPVlF2eTdDNmd6Z0t5SVpQWWpBOGs1bEMrd0I5?=
 =?utf-8?B?NTJGNE5ncVUyV3FNNlA4R0JsTnd4Qm41UlNnNXlIMmJNYmcvSExWdk9sR3Vh?=
 =?utf-8?B?MldacUE1N0tDVUowajRLZmVsaGN2Zlp1RlNjWnBLN214KzYydmJGdC9RR3hU?=
 =?utf-8?B?Q0w5bnFWaTBRcHJkRnpxRytJM0FmYWpqaVRTNVdkalBkZUtNWnlzUHppaERt?=
 =?utf-8?B?N1RuM0RWMzVncWhvS3N4MUdxakpVY2RHay8yRnVCS0FPVEpiZWUwNXZaRjFz?=
 =?utf-8?B?S2VsbWZqL3R3MC9jRExDWkhHelFwMVhwVmdCanYrYmJ4TDlnYVhoc1BZT210?=
 =?utf-8?B?OWxWdFR1TkhOTk1LTDFTZFVhRmxQYStITUVTQUpYSndyQnNpWDRMNWUydVFm?=
 =?utf-8?B?SUdQb2d6bzd3eTMzeGhBOVZIUEREMnE4d3MxaUh3aGlKNGRmbkFHdVp5dE8y?=
 =?utf-8?B?REZIWkZTTGNaeHVwdDcrUWZpczloSlZFMmtwQVhVdHMweFpDWmd4K0lxeVhm?=
 =?utf-8?B?ZzFvck10enV4YnpiNnRZK1B4dEh5L0NmVVdpRmN5Vi8zT1Biayt4Y2tWWWl3?=
 =?utf-8?B?WjdIQk9WSWUybmt1UEcrMXBZVDlTNnkvcDdpVEJtalJrSXRuOC9TMnJST1RM?=
 =?utf-8?B?OGJIUVg0bUxVMlQrcFZaRzI3bTZKTFFIQVRkZ05ndkhjTFl1L1RhM29pa1E2?=
 =?utf-8?B?OW5oY0NVVkV4QkhZU1QxczRRbzZHbmxHcUdPT1dIbkNsWkdyQmNpL3YyRDRV?=
 =?utf-8?B?RHFsWTJua3gwOTNTZFZmUks0Z1hmZjJGb3VJVU56Y0xoVEJRUlZyOWowb2oy?=
 =?utf-8?B?NzBHWEFsdU80Y1p4WnFQSkJOa3RaUW4vcXZYbDE2TGtZNTV2OFZUajZLMnlh?=
 =?utf-8?B?MTRaQ2tla0VmUWNLRjNpR0tCYWxLM3hoLzI1R1cydmtyYm1lN3BKVXlmOHZ5?=
 =?utf-8?B?OUZEdVFlcVRSTlBhYUExUnZLRnVIajhzdlozSTJWckd5WHkzVnhmU0tKSzNW?=
 =?utf-8?B?eFhKQy85amdrb3UvTGw3ODViVnlEVzBZQ3lkZEhLQzlYR1JzeEh2WlRwZEpp?=
 =?utf-8?Q?DdT8LlxON5r8EUm7d4y36VM=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c71f93d5-fc9a-4fca-4a25-08d9eb0e38c2
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2022 14:20:56.5524
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: r8U/n4qWDvDPaodVgNrKAuzS2PDa+1m7jV5aewCoK2CTPGcj5iVqTxtb7YbWf3Y6JWeeIAUJ6O3SKjXQGxLkeg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2570
X-OriginatorOrg: citrix.com

On Tue, Feb 08, 2022 at 11:51:03AM +0100, Jan Beulich wrote:
> On 08.02.2022 09:54, Roger Pau Monné wrote:
> > On Fri, Feb 04, 2022 at 02:56:43PM +0100, Jan Beulich wrote:
> >> Models 0F and 17 don't have PLATFORM_INFO documented. While it exists on
> >> at least model 0F, the information there doesn't match the scheme used
> >> on newer models (I'm observing a range of 700 ... 600 MHz reported on a
> >> Xeon E5345).
> > 
> > Maybe it would be best to limit ourselves to the models that have the
> > MSR documented in the SDM?
> 
> Well, yes, that's what I wasn't sure about: The information is used only
> for logging, so it's not the end of the world if we display something
> strange. We'd want to address such anomalies (like the one I did observe
> here) of course. But I wonder whether being entirely silent is really
> better.

OK, let's add the quirk for Core/Core2 then.

> >> --- a/xen/arch/x86/cpu/intel.c
> >> +++ b/xen/arch/x86/cpu/intel.c
> >> @@ -435,6 +435,26 @@ static void intel_log_freq(const struct
> >>          if ( c->x86 == 6 )
> >>              switch ( c->x86_model )
> >>              {
> >> +                static const unsigned short core_factors[] =
> >> +                    { 26667, 13333, 20000, 16667, 33333, 10000, 40000 };
> >> +
> >> +            case 0x0e: /* Core */
> >> +            case 0x0f: case 0x16: case 0x17: case 0x1d: /* Core2 */
> >> +                /*
> >> +                 * PLATFORM_INFO, while not documented for these, appears to
> >> +                 * exist in at least some cases, but what it holds doesn't
> >> +                 * match the scheme used by newer CPUs.  At a guess, the min
> >> +                 * and max fields look to be reversed, while the scaling
> >> +                 * factor is encoded in FSB_FREQ.
> >> +                 */
> >> +                if ( min_ratio > max_ratio )
> >> +                    SWAP(min_ratio, max_ratio);
> >> +                if ( rdmsr_safe(MSR_FSB_FREQ, msrval) ||
> >> +                     (msrval &= 7) >= ARRAY_SIZE(core_factors) )
> >> +                    return;
> >> +                factor = core_factors[msrval];
> >> +                break;
> >> +
> >>              case 0x1a: case 0x1e: case 0x1f: case 0x2e: /* Nehalem */
> >>              case 0x25: case 0x2c: case 0x2f: /* Westmere */
> >>                  factor = 13333;
> > 
> > Seeing that the MSR is present on non documented models and has
> > unknown behavior we might want to further sanity check that min < max
> > before printing anything?
> 
> But I'm already swapping the two in the opposite case?

You are only doing the swapping for Core/Core2.

What I mean is that given the possible availability of
MSR_INTEL_PLATFORM_INFO on undocumented platforms and the different
semantics we should unconditionally check that the frequencies we are
going to print are sane, and one easy check would be that min < max
before printing.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 14:28:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 14:28:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268425.462254 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHRTt-0007qt-HH; Tue, 08 Feb 2022 14:28:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268425.462254; Tue, 08 Feb 2022 14:28:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHRTt-0007qm-Dc; Tue, 08 Feb 2022 14:28:33 +0000
Received: by outflank-mailman (input) for mailman id 268425;
 Tue, 08 Feb 2022 14:28:31 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=v7zX=SX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nHRTr-0007qc-Dq
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 14:28:31 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 62c29320-88eb-11ec-8eb8-a37418f5ba1a;
 Tue, 08 Feb 2022 15:28:30 +0100 (CET)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2111.outbound.protection.outlook.com [104.47.17.111]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-13-DiX8Hq2TPyios9Xl34jTWg-1; Tue, 08 Feb 2022 15:28:28 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by HE1PR0402MB3385.eurprd04.prod.outlook.com (2603:10a6:7:8a::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Tue, 8 Feb
 2022 14:28:26 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.018; Tue, 8 Feb 2022
 14:28:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 62c29320-88eb-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644330509;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=RhDj55AlNHV0+UKqZ0MVptSZaX0fauKFRY9W+1xyYPc=;
	b=LluN0xG/F4bG7EbTDB/sUlkmFF1TKlKB7A3DiaBYMHNoXrnE6yT8AofndDRGvVewtFMzQb
	5BGnopMXoIjpaq4i3cWd6d63ji9PCQzqavrf+qP3gubi1NKaGsK0/R2w/1mrgmErxMZb3T
	v6G/wot3/+qX7y7PEYmDpo8CEk4nvCI=
X-MC-Unique: DiX8Hq2TPyios9Xl34jTWg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=mfcInbTUOJjTdsYDgBiqcplGuyalV0iDq8egay90EFSlg85sK+dqvQm3TV4Ph1x5zA8k6KWwHbBZbztnJvznKxVWvydyX4lYM/ta9kt5+np1W/KeRjqzU0nLmeTMX+ZeAGsVDyl7vcL3rsgOG0QAjHRq7BvQqvdO7+KUWDNATRkAdCXcdsA+e7cF1eB/umshUXz/xU7lKkQKcmFQGifbcUdtfesEnUFe093HG8fT+LfKJCv/DLwwQT9PW6EXrcAvF4rL6owPe4pVOeK3Y2Ea2L+1RxUerWEDQ0N3n0SaVO9hBBzjsjCJRil1CnOI/Qo3v4XzkZXgR536BvKB45KQSA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=GqlfddC0LxNgCVanUDmcWyOj30plxW2gUXjwoC4VDbU=;
 b=E9OQXLn8PGWmlSvVZ1oKrpSs2EXKp4+ueqZJSc4bICdd6n3hvhZzJtZk5yvBLwqBcNuoUgucvWpbn6G9JUyryGAUuAiToeo2lNmsGtVkbLjKm/X5LIk7ifkELIIDyH5+WQfNoVCsESEYoS367Q9gC1iY25yM+kmb24J8dWoE0ud5A8wN/XzTG74LAtO6osjNYFo3aiisSgS1SnmUM6AzKJNNx7AGAFVLAxny4hXtKWfbbtgnA3bOCutOkXKK1gJbLpxaERfR3/X29ANPytnTc2ZO4olkaNSxHV/ua1Pa9nMavPZsoBe+h9xkf6x+MVyOxgEC+yFC6IrN2BVleOhArw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <6ff6d1b4-e096-90c9-1329-eb5dfecde94c@suse.com>
Date: Tue, 8 Feb 2022 15:28:23 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH] x86/Intel: don't log bogus frequency range on Core/Core2
 processors
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
References: <419db65a-a6f2-f812-d51e-7a23d065d460@suse.com>
 <YgIv3O8ojoDK+wiR@Air-de-Roger>
 <1680d537-fb6d-c589-66bd-f845b8280308@suse.com>
 <YgJ8REZepbp7WKnv@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YgJ8REZepbp7WKnv@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0404.eurprd06.prod.outlook.com
 (2603:10a6:20b:461::24) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 0618bf8b-ca59-4b03-5b8f-08d9eb0f44a1
X-MS-TrafficTypeDiagnostic: HE1PR0402MB3385:EE_
X-Microsoft-Antispam-PRVS:
	<HE1PR0402MB3385F5EEDF3BC6CA276B4300B32D9@HE1PR0402MB3385.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	9KGnPW5m2lyxtCfxew4NKnAFbUUXokRUuOq782hTBc3OFxJdhR5UgI0C01duURUgk/i+5bJiH82/Ep3I/kFb7Rn06gV1KjQRFxn9EznbB2I3BC3xpbmVAESRk/GkrfLrnXeE1INaSF+1KxNrSN1KwkqR9c163Ur23JdomjZpO/EkIlzVW9E6s5QVRwrL1lUmhAej9KTm1wVR26xd60nz4t0gs38wHi3sdZoJR2x5fHI3dLpq/NWKuvJoKzd3CSvMrYUUWVir8VOfPYJqfcPiYwxKmMQeVJWlmKg5JXORnRh4arThU+S9F0sEdpj8JGZdOYWM4rbvuIZm+JxNFvDpDnAVmkwJxMEo+xq5B/aDWuSnlRmS3eYDYA68je6ss6uUNGbkYVXrQyXAMFGyd2Y0M5PINI9Z/a63G4r5WHdmuKfhG3hhsYSvNRra2bKnAwwgUZOOSqgeufDYd6webIO6yesIa8hIcGbdjEgSLLHuJBP/P5c4M+6JvnqyL4tFm6oWvoge+gYuDDeh9Yzs0Y22+jueHZ8OpFaiI++n9eyjOqhKvAI/1cMcJiFn0Eb7NvwSKX3jeLfPLWUR3L2tRVZPYSYIChxFZqPLMOUsP3JI4ehYHOWIOQ/iORPxYUdmj+h1zTpe6ASq3On+EqVH1VIRNOEkbQxCfN4r5W2E/dcmZ2cjdwh0BFUiARRvyzrCBBlIo5cHXLtCNbCxYbOU70fWVmyApy8PTlyNlJIgHPieWU8=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2616005)(66556008)(4326008)(8936002)(66476007)(6916009)(31686004)(8676002)(36756003)(26005)(6486002)(66946007)(6506007)(86362001)(31696002)(53546011)(5660300002)(6512007)(316002)(38100700002)(6666004)(508600001)(54906003)(186003)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?Q1gRbiKQxLwKqyqpwqOZXskowiSAQ2KCZwulEckmtOltwn4QgH13fFsSbgx8?=
 =?us-ascii?Q?9nKZOWTXom9/MB+DFXUBwOBu++LPwwkwNZtIuSKq93ZsUkRPUe10KzfOvl6l?=
 =?us-ascii?Q?U+SjiR9IZ6buR/D5K3QD30uAj1z0oSnpvPoQEWO/afFbGWQwzpIgONi0Vvv9?=
 =?us-ascii?Q?htiEj9GPetrh+DXWjmChyFXz6VOSpABj/m3b352LPttDbOh+fdtKjTJr7z/g?=
 =?us-ascii?Q?fw4Lg7L+ob+hc+ruPMlHbRhhclZbJVDeGLvsTLlOsQc2mEIbA8XPSbKrb2rO?=
 =?us-ascii?Q?GCqNy7EhT6WImh7/eXURDMN1b/u0X/Dm/XiUyLa7wQgr6oF1D408vf8ITzQ9?=
 =?us-ascii?Q?jYVXrnKhxZW2YuwhuS/t8net1PAk1n9CitP/9SLGCm1ZZXnx8tw2fUKZG1dq?=
 =?us-ascii?Q?EpYKWDRZ2SuSXQ3ilnWI1PcJ7Ut4C8jRH4IYyEID6qi0nkKcpCw9kdcmsaX7?=
 =?us-ascii?Q?f+4+XVI9RqLF5zfFA0hX75TWIltZf0RDCyKlHNAY4cRwxTPOPEicxDFADKHU?=
 =?us-ascii?Q?tRPlFLLzIeikibfj7iItC7xqv3ZUnJNgf+Yky04rX+tzKZc5Z1H02csK2N6U?=
 =?us-ascii?Q?nCnGJfVpXWgSrXKnvfX7UK5uD9gjYquVS/uFyFTT+7oEvLfCN1djuNKRPglF?=
 =?us-ascii?Q?hfv3NzWIWeaxWnvWl9w0a3C8dpEJ2Wyj1W+Uadvv8Qlk1RfOxftr6gvFcTlm?=
 =?us-ascii?Q?JF02r+q3tbUlhmTiIU0JY8a5ygQta/gShoRUBHS5Tm1GxhkiuStboA0k7DHs?=
 =?us-ascii?Q?hu3sNK+RpUO4OSxdMgIFd7CyV0+llzdpNXrlvBP6BP/TGZbuqwok8BBD7s6m?=
 =?us-ascii?Q?+abLVxK8mdWb/VLs+GOqWIs+3IkdnntMJX48lFNwEWRua+gVBo4peuLqyddd?=
 =?us-ascii?Q?VNvj0DkMtWWDgLaJzYs4f4XhOuqwylq9QcSQYhU0atx+m9YBsWkq5zh9q97O?=
 =?us-ascii?Q?VrHBbHm1e7VtpCAu9+e494UxWxPfkgAvbc1cM4bMhnBi9kqB4910pPSaSwc8?=
 =?us-ascii?Q?zkkIq1GOyHXZgAA+4POHT9hj4+Xz/tn34YC98gFetyXNUTVWvhwLOdjLYJbV?=
 =?us-ascii?Q?lpICGhWbrtLOxJIujdJGvWxd4ZtGYxJbBn2xRMAiBXsWdcmThezkoPclQmw3?=
 =?us-ascii?Q?mEwqflFCGYvC+/+fHXAtpFy54kNt3Z5GCD4eXDgL5ApJ8lO0fMyyM94vi8Se?=
 =?us-ascii?Q?AovaYqgVio0L/u7fL6B3Shqb88OXJiNODlh/xCc5jETMqfLuFC285NZuKT6U?=
 =?us-ascii?Q?1bTVKhg0NeCexDIVrQsKy95bjXZHYZ0/sEk9EvAHLanHBD47sliy+lT14AH2?=
 =?us-ascii?Q?uCcDSEV4AVHxRONsL+GDGjxy4Nj6k2H3qf5gA1WotgijMkA+LInTMqaUaE1w?=
 =?us-ascii?Q?d0C3unslRhCp5JPq29useR6T5TVC0DzcrkqoIVc9graEG0x9zjr/CKToebtT?=
 =?us-ascii?Q?G00BYrXzAZu//w7IGJNITVjv3tfRZXD5sZz/G3qnrd0xQc88/W+050XRKrEM?=
 =?us-ascii?Q?ff41B9Pje97OGx902SXvRi7AVPKCbuIhZk3XglK+0alkKNLYZQEVhZMSfokQ?=
 =?us-ascii?Q?GLh7R90UTMYXjVjetNlmhZT9c76EslLGdQXxLXeorB8Kz5xvdwwawmvgsDkz?=
 =?us-ascii?Q?2EW1Njnc1JnF/QeSEDtnxzg=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0618bf8b-ca59-4b03-5b8f-08d9eb0f44a1
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2022 14:28:25.9816
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EZqxKBEneKCAu64KRdEr5QtRQ4EF/HxlmRbRwmfIJE3rY0LVobecUAYrVqBNejYCIsVL74v2YzghSfeVRdo7IQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0402MB3385

On 08.02.2022 15:20, Roger Pau Monn=C3=A9 wrote:
> On Tue, Feb 08, 2022 at 11:51:03AM +0100, Jan Beulich wrote:
>> On 08.02.2022 09:54, Roger Pau Monn=C3=A9 wrote:
>>> On Fri, Feb 04, 2022 at 02:56:43PM +0100, Jan Beulich wrote:
>>>> --- a/xen/arch/x86/cpu/intel.c
>>>> +++ b/xen/arch/x86/cpu/intel.c
>>>> @@ -435,6 +435,26 @@ static void intel_log_freq(const struct
>>>>          if ( c->x86 =3D=3D 6 )
>>>>              switch ( c->x86_model )
>>>>              {
>>>> +                static const unsigned short core_factors[] =3D
>>>> +                    { 26667, 13333, 20000, 16667, 33333, 10000, 40000=
 };
>>>> +
>>>> +            case 0x0e: /* Core */
>>>> +            case 0x0f: case 0x16: case 0x17: case 0x1d: /* Core2 */
>>>> +                /*
>>>> +                 * PLATFORM_INFO, while not documented for these, app=
ears to
>>>> +                 * exist in at least some cases, but what it holds do=
esn't
>>>> +                 * match the scheme used by newer CPUs.  At a guess, =
the min
>>>> +                 * and max fields look to be reversed, while the scal=
ing
>>>> +                 * factor is encoded in FSB_FREQ.
>>>> +                 */
>>>> +                if ( min_ratio > max_ratio )
>>>> +                    SWAP(min_ratio, max_ratio);
>>>> +                if ( rdmsr_safe(MSR_FSB_FREQ, msrval) ||
>>>> +                     (msrval &=3D 7) >=3D ARRAY_SIZE(core_factors) )
>>>> +                    return;
>>>> +                factor =3D core_factors[msrval];
>>>> +                break;
>>>> +
>>>>              case 0x1a: case 0x1e: case 0x1f: case 0x2e: /* Nehalem */
>>>>              case 0x25: case 0x2c: case 0x2f: /* Westmere */
>>>>                  factor =3D 13333;
>>>
>>> Seeing that the MSR is present on non documented models and has
>>> unknown behavior we might want to further sanity check that min < max
>>> before printing anything?
>>
>> But I'm already swapping the two in the opposite case?
>=20
> You are only doing the swapping for Core/Core2.
>=20
> What I mean is that given the possible availability of
> MSR_INTEL_PLATFORM_INFO on undocumented platforms and the different
> semantics we should unconditionally check that the frequencies we are
> going to print are sane, and one easy check would be that min < max
> before printing.

Oh, I see. Yes, I did consider this, but decided against because it
would hide cases where we're not in line with reality. I might not
have spotted the issue here if we would have had such a check in
place already (maybe the too low number would have caught my
attention, but the <high> ... <low> range logged was far more
obviously wrong). (In any event, if such a change was to be made, I
think it should be a separate patch.)

Jan



From xen-devel-bounces@lists.xenproject.org Tue Feb 08 14:47:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 14:47:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268434.462265 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHRmV-0001ke-48; Tue, 08 Feb 2022 14:47:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268434.462265; Tue, 08 Feb 2022 14:47:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHRmV-0001kX-0o; Tue, 08 Feb 2022 14:47:47 +0000
Received: by outflank-mailman (input) for mailman id 268434;
 Tue, 08 Feb 2022 14:47:46 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=GmUj=SX=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nHRmU-0001kR-HL
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 14:47:46 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1187970e-88ee-11ec-8eb8-a37418f5ba1a;
 Tue, 08 Feb 2022 15:47:44 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1187970e-88ee-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644331664;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=OALkXEdYWTGWIyCFj4fCPe8lDTpYxxl38uBD6KW1DfA=;
  b=On5C/WwgvLcE81PMbVfEV23/aGRPdXh4NrZWPOAQM1NiNz78mGKel3Fw
   04CnssI+esXbrEEMifPWlVNxsofXCiprFG+Avg85kGkY7slHNaRksQYOj
   o1nmAApws1rVoTVPAGYCUc1sIQc/6X3yFElHbx9w3lla5SqrjXAyHiwo6
   I=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: UubI2e1Sxg5g6RZLK3rNn4GrBAQQpT5O0UnBFEwrDMkhnZoqjHCwSExknDrGCVcacLAnq98Ds1
 Ghh366Ewt2Cr1E6BboJs08ty6qXpDhft/tLhNJ5tJD8T0zpsOvWzHR3SfuLHh2apuzhoyXC4Tm
 0H8f+Hn4JCbqlIbQ1ILlzZSG7JbxtMjaTusnVZI9wMElwCB4GKFayZcCBlm/gM7Sw5EJDeHP+v
 pqALYZePnKDPJXJN2WgsqV6gnvW20PzkDXeaIqAeSXkpo9hvWGF9exGW4QoI4qRlwttW0e8oiY
 rAaztDU5XS0PRgw6J/AzcZtc
X-SBRS: 5.1
X-MesageID: 63740974
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:aZqOnqLEasA4x6xIFE+RA5IlxSXFcZb7ZxGr2PjKsXjdYENS0mEDy
 WAdX2GCa/3fNjGmL4pxOY+08klXsMeEytFhHgFlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokcxIn5BC5C5xZVG/fjgqoHUVaiUakideSc+EH170Ug7y7Zg6mJVqYPR7z2l6
 IuaT/L3YDdJ6xYsWo7Dw/vewP/HlK2aVAIw5jTSV9gS1LPtvyB94KYkDbOwNxPFrrx8RYZWc
 QphIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbrGvaUXe345iXMfwZ3u7hB2RnPlL2
 NtMuqbhdjsbAKuVu+4hAjxHRnQW0a1uoNcrIFC6uM2XiUbHb2Ht07NlC0Re0Y8wo7gtRzsUr
 LpBdW5LPkvra+GemdpXTsF2gcsuNo/zNZ43sXB81zDJS/0hRPgvRo2UvoAEhGZv2qiiG97nX
 ugSMxl3NiiYWDhTa3oFK4kuzOin0yyXnzpw9wvO+PtfD3Lo5BN1+KjgNpzSYNPibdVYmAOUq
 3zL+0z9AwoGL5qPxDyd6HWui+TT2yThV+o6Fre16/pri1273XEIBVsdUl7TnBWiohfgAZQFc
 RVSo3dw6/hpnKC2cjXjdwW7iUSUsB8TYYtvL98E7liuwJaFxhnMUwDoUQV9QNAhscY3Qxkj2
 VmIg87lCFRTjVGFdZ6O3uzK9G3vYED5OUdHPHZZFlVdv7EPtalu1kqnczp1LEKiYjQZ8xnUy
 ivCkiUxjq57YSUjh/TipgCvb95BS/H0ou8JCuf/AzjNAuBRPtfNi2mUBb/zt6coEWphZgPd1
 EXoYuDHhAz0MbmDlTaWXMIGF6yz6vCOPVX02AAzQ8Bwrm3zqiT6Jui8BQ2Sw28zY645lcLBO
 heP6Wu9GrcPVJdVUUOHS93oUJl7pUQRPd/kSurVfrJzjmtZL2e6ENVVTRfIhQjFyRF0+YlmY
 MvzWZv8XB4yVPU8pBLrFrh1+eFwnEgWmziMLa0XOjz6iNJyklbOEuxbWLZPB8hkhJ65TPL9q
 Y4AbpDXkEUGC4UToED/qOYuELzDFlBibbjeoM1LbO+TZA1gHWAqEfjKxr09PYdimsxoei3gp
 RlRg2dUlwjyg2PpMwKPZiwxYb/jR88n/3k6ITYtLRCj3H16OdSj66IWdp0We7g79bM8ka4oH
 qddI8jQUO5STjnn+igGacWvpoJVaxn21xmFODCoYWZjcsc4FRDJ4NLtYiDm6DIKUnisrcI7r
 rD5jlHbTJMPSh5MFsHTbP7znVq9sWJEwLB5XlfSI8kVc0LpqdA4Jyv0h/4xAscNNRScmWfKi
 1fIWU8V/LCfrZU0/d/FgbG/g72oS+YuTFBHG2T77KqtMXWI9GSU3oIdAv2DeirQVT2o9fz6N
 /lV1fz1LNYOgE1O79hnC79uwK8zu4nvqrtdwlg2FXnHdQ32WLZpI33A1shTrKxdgLRevFLuC
 E6I/9BbP5SPOd/kTwFNdFZ0MLzb2KFGgCTW4NQ0PF7+tX1+87ewWElPOwWB1X5GJ7xvPYJ5m
 eostab6MeBkZsbG5jpesh1pyg==
IronPort-HdrOrdr: A9a23:2c7a4KCyrbO06iTlHeg0sceALOsnbusQ8zAXPh9KJiC9I/b1qy
 nxppkmPH/P6Qr4WBkb6Le90Y27MAnhHPlOkPQs1NaZLXLbUQ6TQr2KgrGSoQEIdxeOk9K1kJ
 0QD5SWa+eAfGSS7/yKmTVQeuxIqLLskNHKuQ6d9QYUcegDUdAf0+4TMHf8LqQZfngjOXJvf6
 Dsmfav6gDQMkg/X4CePD0oTuLDr9rEmNbPZgMHPQcu7E2rgSmz4LD3PhCE1lNGOgk/jIsKwC
 zgqUjU96+ju/a0xlv10HLS1Y1fnJ/ExsFYDMKBp8AJInHHixquZq5mR7qe1QpF6t2H2RIPqp
 3hsh0gN8N85zf4eXy0mwLk303a3DMn+xbZuCmlqEqmhfa8aCMxCsJHi44cWADe8VAcsNZ117
 8O936FtrJMZCmw0hjV1pztbVVHh0C0qX0tnao4lHpES7YTb7dXsMg24F5VKpEdByj3gbpXX9
 WGNPuspMq+TGnqLEww5gJUsZ6RtzUIb1u7q3E5y42oO2M8pgE986MarPZv6UvouqhND6Ws3N
 60QZiAoos+OvP+XZgNdNvpfvHHeFAlYSi8eV56cm6XXJ3uBRr22uvKCfMOlaaXRKA=
X-IronPort-AV: E=Sophos;i="5.88,352,1635220800"; 
   d="scan'208";a="63740974"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gulo/+z5LBZFFC1NKBBxPfCzBgl3pC+1KR7989muIbkXiOFIPZy0B0ByBmeQLwZMGYnzeYaZN9FvWCHAxizlkprSkIVlrF5Huva/lId0RqLUJkJk4E6HzuBYL3Y0cRMtiW/xxSFSzEivSbSIGz0w+Evqem+zplYpLPsUf3K6KKZQNcXSbu/NDCLmbXHI5g3BFLiEzduPh8FlbVFC9SmnzEQYBjwjtWNTsPN94ZSjhYMWnZsEwZp0PR0va3RZ6Mfwcnv/bv6u1UFKCiNGLrqr7bsfZ+oXfw6mu+5FrJ6szd7adCunZsr8/wCu19yfqnyT+dKc8x5odK9vfRuuo0xmew==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=49vaL47Ca0bT3XdWEPgw1MGVyHkyPaeRkies6Pmp0fE=;
 b=aXLSHeLB8yik2yPFQVF/skQOEU58ubQYy5cvm/SX3jP2qumXNrcJPg1SMFj6k+Oo4X1jR/pPWV3kHTY/jtTDJvU2rm4aPAW1WoZQN6XTz4+rHdvqBnIGC1cnf+tVXBLMfNKGCexrQ+aCy6JcD1MCTORhKPhKJ9rlqYQeVhBdU5FNtZjyjfNTXBM9op+0Su7PWrq9vbwkK2sLtlWxVGDCkM6tybBp4/9IF2R9QEKA+LQtY1RZyB6FUYOsK+qCG+OWUZA306tsm8viKDkDBzCs3Spov7qkhx3VPTj3UIaNWV37TsU72munjPorriS0Av/9VB4LqxN51rhLcppxkmCDiA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=49vaL47Ca0bT3XdWEPgw1MGVyHkyPaeRkies6Pmp0fE=;
 b=C+NS5tZnTe9YwNYLP3aWQuozq6W6sntaP54AtuRBCFbtpH9xL3l2PY5V0tCCARyjqI0KFBDxum4mJe8Op2taQEXVUPnQN0YgF9uSbmXKi+buGyKvIhH8ET+1lrzgQnwYuBuh4AZKv4mqATbUn/eclWAU+UUEtH9CkDCzQ1KTuD4=
Date: Tue, 8 Feb 2022 15:47:34 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH] x86/Intel: don't log bogus frequency range on Core/Core2
 processors
Message-ID: <YgKChtaJLAYMsVqG@Air-de-Roger>
References: <419db65a-a6f2-f812-d51e-7a23d065d460@suse.com>
 <YgIv3O8ojoDK+wiR@Air-de-Roger>
 <1680d537-fb6d-c589-66bd-f845b8280308@suse.com>
 <YgJ8REZepbp7WKnv@Air-de-Roger>
 <6ff6d1b4-e096-90c9-1329-eb5dfecde94c@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <6ff6d1b4-e096-90c9-1329-eb5dfecde94c@suse.com>
X-ClientProxiedBy: LO4P123CA0440.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1a9::13) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 91c7752e-2fb4-4bfb-ba75-08d9eb11f371
X-MS-TrafficTypeDiagnostic: SA2PR03MB5705:EE_
X-Microsoft-Antispam-PRVS: <SA2PR03MB57052F2702C616494925BAFB8F2D9@SA2PR03MB5705.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: OZoGFmIcGa57m0jCY7L1Jxq0TQb2rcgNAz890Wn9WaYhYuSnLPm5E7/l0IzAb7v5IqfBn7fbDYXc4Meh4x2mHiTLGP9L0KjHdGUU39H3OJNUuXHTjZBxnOk8tU8o3uw9a5ZFlCJ5AqIOjXxQ1sm9GwO//Olkavulaua7/hCBdcVLi92hZWtJ9l8k8/gRZDQwQY1xmUubl7q2zeDm0GqXA9SGdEEITCx/mPH8tCRA/FYS8WfDNxgQaP8GXrnTZXx6y5MALXLq0uCT27ZowKdUC5cFzVzqmqD9o2BFMSyEPXEVDjZ+3saePXRM+7PT2hLBPAxQC9KlWVlNeQ/4hFUY1FKnEYZS47V79OXuOqPaASlypj3IeytQpDzw2eBYPhcLzXf/ZTUbZpMmM/0WJU4nibFFnL9MB/Cr5WhVp4ZixlWxTp2UAxFW6KXnmPJwnZ2P8UhTw5rGtLsXG2InQZxfEKhQL32s/xfGf98ywKkV+4Oi6Ekk2nLGGk2NC5/YlGgJ167ui8/ct1gpYYr8wyN7Msdt/N5Z08N0tV/YU7KUXnlxDLqAH3GKcHP5eE1b1KIUMfZS7VkqmOB4UehDriMTqj4FBuEFAPfpEAHTWKRMJ2brJhHIAcQI8tkfZ3kKY3uT+KK8eV4QxB0e9A4ZZZOsnQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(5660300002)(66476007)(6512007)(9686003)(6916009)(54906003)(8676002)(4326008)(83380400001)(316002)(26005)(508600001)(86362001)(6666004)(33716001)(82960400001)(53546011)(8936002)(85182001)(6486002)(38100700002)(2906002)(6506007)(66556008)(66946007)(186003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bGQrQzZnYkZvRzc1andBWFJIRi83YnV6bVdUM0V0Z3d2RlFsN3FLQ3VGUmZa?=
 =?utf-8?B?WGFPbnF6QkpKS3kyNHEwdzE1dU1mMEU4VmRlN3RNb2lxNDRHOXZGOTJ1RXBu?=
 =?utf-8?B?SEI5YTgzMUlLV2hUL0NlYkgrbk1VdjYvSWpmT29iTHpZYVFpb0ZIVDYvL1hF?=
 =?utf-8?B?a2xOeVdKN0FmaitWVnJWOE81VVJ5eksyMjYybS9OcllQTC96UnBNTGtDT0hl?=
 =?utf-8?B?NXJzRmozdzVvWG1iS0lJT0IxUU81NFhhS25pL1dhNVRhNktneFIrQnpNb3hi?=
 =?utf-8?B?amJ6MG9udFBsQ1l4NkJ3Znc4dmdqU05La2dmWk95cUw5eVdGNi9GdVZQQjdI?=
 =?utf-8?B?bTVmSnNhc2pBZjJ3VWNHc0hMWlZ3U3dKRTRzRmtKZ2VoSUEyNG5iV3p3eTVE?=
 =?utf-8?B?VUoyRmkwZkxJWit3RXVCTk5zTWt2SE5hUlorcHNKWHRQWkI1ei9yK1BNeDM4?=
 =?utf-8?B?RWhvV2NGYVdHZ29yWGs5OGtCY0NiRVY5NURKVHRRTk1TRlZnUVJPRUwvZW5W?=
 =?utf-8?B?V3hJTGFFeDJoZ1VEMDJUbktZVUJkRS96OXQzY3BobC9XbUhmZFhod3U2RHBM?=
 =?utf-8?B?WXI3WEJrbTRCSnJGak1DMm5DQS93UlAxMHRzdEpkTTNFUnIvS0tEMDVVRGIv?=
 =?utf-8?B?SHFITlJpM0JKQXcxVngzR1ROVlN2QUJkNDlPOFJKRndwNFJDT1ZiU2JMNGZz?=
 =?utf-8?B?Ny81cUJxa1ZudjcreEJsT2N2S3JKajNlNnk1Y1k2LzNlUGI0bkJGRVZXZGJV?=
 =?utf-8?B?SStmQ25LRE53TVVlMVd4d29XUjhJcmJGWWJLNjZVeTloUWUvZ2JGMzFkMkYw?=
 =?utf-8?B?UXQ5MHpkNmFsdWtTTHNzdkQwWTBuL0ppaUt4WnZGL0FIL0pyUi9GdGlqU1JK?=
 =?utf-8?B?S0FQUXNzVmtCcXdkd0R5OTNOV1ZpMUZiR25jM1VVRms3YjE2YjNjUkpMS2t2?=
 =?utf-8?B?SGJlNnExbjZaYnp1T3BZREpmLzBOcEc1aWlNdEpqNndXekhxdnlmYVVuYzZl?=
 =?utf-8?B?anorbWlaUm5IRnFLTnJIV0ZaeHJkV2ZCYVg5NTYzKzFpWTd4anlBR2xKRUJ3?=
 =?utf-8?B?TUZQVUpYaS9KUzRlYmZwbER6dGZYQlF1WDJicFk0akZkVEV0QmxTeTNRTVJp?=
 =?utf-8?B?L243ZzlBcXlwYTA1UFNJWk1qa0k5VVh2d1ZLR0JiVElVZmRtUStWaG1zc2dz?=
 =?utf-8?B?SzI4WkY2S0l6a3loMmtTWE1TVjFsNXhnOURXdHNMUGNuUWs4U0xDbVdUZE5M?=
 =?utf-8?B?THdqQlpkeTBlL3REVE5lRkVVamt6L21LQUgxMkVKSVVkaVJUMjVDOE1Ma05M?=
 =?utf-8?B?enowUnZsZ1NTQWJPdDhwRUxOTE5pZnd0eE9RK0FoSlFycHhoNEYyY2R1RVRu?=
 =?utf-8?B?TmxVemljMk1wUGV5Nm9qb0hFbW96bjV1djdINVFpd3FVaFdMK1lOUXNmMGJ3?=
 =?utf-8?B?cjUzeFE4L1lodW9wekNSNWhjM1E4UGVLVy91ODNnb09jTDBDdUZyaUFiTGEv?=
 =?utf-8?B?UGF4RmNEN3VYMDNrVVFvOStVaG5jSnl0eGIyWERyWm5RN3FBbDRaOFVCTnVC?=
 =?utf-8?B?a2paT3hvNWRNTk53TytLbldIZkJ5cnNqL0p2RFpWSmx6TjN3R0tWNk5pNU53?=
 =?utf-8?B?RWpkMWZHaXkzanppcUw2M1RGK2pES2g4UkttWHNXYk9PNDIxd2JPVks5dkFt?=
 =?utf-8?B?bzUyYjgyOENON3RYYkRvR3B2aklvZkRvN2psZUxraGJINmIvREJrYitlRmN5?=
 =?utf-8?B?ZEw3OXhpWTJWMVRtR3lZeStFVm1hVHRyZFBWd1VVUFJSaGJWRFVqQlJteEFU?=
 =?utf-8?B?UFMyM0ZUYWlRT00rbWVPd3U3SW9jQ2dMVS9mbXE2TDB3a2hoK2EzOFBtUXZO?=
 =?utf-8?B?d1VXTHpwMTdtZUpFNDc1cWsyN3JUTTExN1pIcjNIbmJabUdYNjBPdjN0VjJT?=
 =?utf-8?B?QWlldzIyaUFMM2RibjhCVlpBME1qdHd6bHdaR1JJcVRCOGNwV003bGJNdHZt?=
 =?utf-8?B?TmFzUXBoTkdTRFU5ZVdGZEtqRTJOam42WnB6SlF5b2c2UEV3cEQzcGJ0dGpP?=
 =?utf-8?B?Q1FFWTBvaWdieDZpVVdsMERBZDBjMUNzUGpaNlljNlQwTkUxS2tjdEpBZmht?=
 =?utf-8?B?dFNvQ285SHJORCtJS1lyaDdKT29oZnZKSHozOG56NDRHUENqMUZMS3FiWTIy?=
 =?utf-8?Q?c2MEQIVhYasOOWmyvFDQFd4=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 91c7752e-2fb4-4bfb-ba75-08d9eb11f371
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2022 14:47:38.2642
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oIrRJfHBwNS+dK/9ABwfdebiTx1fUiEUqqKc12VPLVidinzvNNncbQ9Ys56A6lZY7/QEqgu4+A5Zm6uvk+M17g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR03MB5705
X-OriginatorOrg: citrix.com

On Tue, Feb 08, 2022 at 03:28:23PM +0100, Jan Beulich wrote:
> On 08.02.2022 15:20, Roger Pau Monné wrote:
> > On Tue, Feb 08, 2022 at 11:51:03AM +0100, Jan Beulich wrote:
> >> On 08.02.2022 09:54, Roger Pau Monné wrote:
> >>> On Fri, Feb 04, 2022 at 02:56:43PM +0100, Jan Beulich wrote:
> >>>> --- a/xen/arch/x86/cpu/intel.c
> >>>> +++ b/xen/arch/x86/cpu/intel.c
> >>>> @@ -435,6 +435,26 @@ static void intel_log_freq(const struct
> >>>>          if ( c->x86 == 6 )
> >>>>              switch ( c->x86_model )
> >>>>              {
> >>>> +                static const unsigned short core_factors[] =
> >>>> +                    { 26667, 13333, 20000, 16667, 33333, 10000, 40000 };
> >>>> +
> >>>> +            case 0x0e: /* Core */
> >>>> +            case 0x0f: case 0x16: case 0x17: case 0x1d: /* Core2 */
> >>>> +                /*
> >>>> +                 * PLATFORM_INFO, while not documented for these, appears to
> >>>> +                 * exist in at least some cases, but what it holds doesn't
> >>>> +                 * match the scheme used by newer CPUs.  At a guess, the min
> >>>> +                 * and max fields look to be reversed, while the scaling
> >>>> +                 * factor is encoded in FSB_FREQ.
> >>>> +                 */
> >>>> +                if ( min_ratio > max_ratio )
> >>>> +                    SWAP(min_ratio, max_ratio);
> >>>> +                if ( rdmsr_safe(MSR_FSB_FREQ, msrval) ||
> >>>> +                     (msrval &= 7) >= ARRAY_SIZE(core_factors) )
> >>>> +                    return;
> >>>> +                factor = core_factors[msrval];
> >>>> +                break;
> >>>> +
> >>>>              case 0x1a: case 0x1e: case 0x1f: case 0x2e: /* Nehalem */
> >>>>              case 0x25: case 0x2c: case 0x2f: /* Westmere */
> >>>>                  factor = 13333;
> >>>
> >>> Seeing that the MSR is present on non documented models and has
> >>> unknown behavior we might want to further sanity check that min < max
> >>> before printing anything?
> >>
> >> But I'm already swapping the two in the opposite case?
> > 
> > You are only doing the swapping for Core/Core2.
> > 
> > What I mean is that given the possible availability of
> > MSR_INTEL_PLATFORM_INFO on undocumented platforms and the different
> > semantics we should unconditionally check that the frequencies we are
> > going to print are sane, and one easy check would be that min < max
> > before printing.
> 
> Oh, I see. Yes, I did consider this, but decided against because it
> would hide cases where we're not in line with reality. I might not
> have spotted the issue here if we would have had such a check in
> place already (maybe the too low number would have caught my
> attention, but the <high> ... <low> range logged was far more
> obviously wrong). (In any event, if such a change was to be made, I
> think it should be a separate patch.)

My suggestion was to avoid printing both (max and min) if min > max,
as there's obviously something wrong there. Maybe we could print
unconditionally for debug builds, or print an error message otherwise
to note that PLATFORM_INFO is present but the values calculated don't
make sense?

In any case, this is just for informational purposes, so I don't
really want to delay you anymore with this. If you think both options
above are not worth it, feel free to take my Ack for this one:

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 15:26:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 15:26:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268443.462275 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHSOC-0005oU-6P; Tue, 08 Feb 2022 15:26:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268443.462275; Tue, 08 Feb 2022 15:26:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHSOC-0005oN-2s; Tue, 08 Feb 2022 15:26:44 +0000
Received: by outflank-mailman (input) for mailman id 268443;
 Tue, 08 Feb 2022 15:26:43 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=GmUj=SX=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nHSOB-0005oH-BU
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 15:26:43 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 38e6e01a-88f3-11ec-8f75-fffcc8bd4f1a;
 Tue, 08 Feb 2022 16:24:37 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 38e6e01a-88f3-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644334001;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=fyT0vCfAx1ZQqdpw9MwMrq4qkuWzIqACc2UASZ9b1dQ=;
  b=TxElDE02InimppUaryyS/n8bsekaItyhEu+xRBbhJHxjboilTYa9eMA3
   YlyTngqrQgzU3wEG5UazYJo/4jLC0dz0RGNFcxI+4kmKcbBWvzs140iVx
   BJV2CfzmrXj2P1scUVjFJYpCDAiYDqu4KU2HPTMr/xWybTaZ3e9VEJyWI
   A=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: BIwt2bXWhsK5nFDPpnRt+LQapKvWHp5mTf696X1uy5SEz6VzjwHKDfxKwrAe6SvZJiuLowqOAP
 oW6mZRa/eIaK25sJitXPafVUZh/HfDVG0aBU26GbYxmeEZJEyws2Nf0zPgJi4AFr1y4XEqfqc3
 3lw88yeoj2ngNYDNWw3JlRUOKO3mvjY4WLTb6bOIdhm7WQ3zQzMCCVPbR3DaJgQp3/oYM4QeR/
 tsanlBtuOtjgFVFmfCQZcPxUQ8qtvJFoX/oOvjRKJep3wEom/LvjBLW4WE1yEyIVIyatkiFKkZ
 nzyHBlnXXydq6N9UnvMFBFQe
X-SBRS: 5.1
X-MesageID: 63200731
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:XlREjK4lFSvPCWJz6FnLdQxRtEnBchMFZxGqfqrLsTDasY5as4F+v
 jQYD2iPOv/fYzSmeI90bIrk8xgHupXSzd9lGgY//ykyHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FV8MpBsJ00o5wbZj2t4w27BVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z6
 IUSkaT3TA4SY/Pqx9ZFAicDQ31gIvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALNs7kMZlZonh95TrYEewnUdbIRKCiCdpwgmxq3pgRRq+2i
 8wxRQVjTUnNWAJ1GGwwS8wursyj3XDGWmgNwL6SjfVuuDWCpOBr65DTN97Sds2PVN9itE+Sr
 WLb/Ez0GhgfcteYzFKt6Wmwj+XCmSf6XoM6F7Ci8PNuxlqJyQQ7AhAMSUGyp/X/j0ekQs9eM
 GQd4C9opq83nGSoQ8f8WVukoXeClh8aR9dUVeY97WmlyLfSpQCQBWEGTztIQN0gqMIyAzct0
 zehgNfBFTFp9rqPRhq15rqS6D+/JyURBWsDfjMfCxsI5cH5p4M+hQ6JScxseIa3gcfyAirY2
 C2RoW41gLB7pcwW06S2+3jXjjTqoYLGJiY37AjKWmOu7itieZWoIYev7DDmAe1oddjDCAPb5
 T5dxpbYvLtm4YyxeDKlYLVSOInu4v++bWP63mw3Tqd6p2iz5Cv2FWxP2w1WKEBsO8cCXDbmZ
 k7PpA9cjKNu0GuWgbxfONzoVZlzpUT0PZG8D62PMIISCnRkXFLfpElTiVisM3cBeaTGuYU2I
 t+lfMmlFh724ow3nWPtF4/xPVLGrx3SJF8/p7imlXxLMpLEPRZ5rIvp13PUP4gEAFus+lm9z
 jqmH5LiJ+9jeOP/eDLL1oUYMEoHK3M2bbiv9ZALL7/ae1Q3Qjh6YxM0/V/GU9Y095m5a8+Sp
 i3tMqOm4AaXaYL7xfWiNSk4NeKHsWdXpnMnJy08VWtEKFB4CbtDGJw3LsNtFZF+rbQL5actE
 5EtJpXRatwSG2+v02lMMvHV8tc4HDz13l3mAsZQSGVmF3KWb1eSoYGMk8qG3HRmMxdbQuNk+
 +L5jV6AEcNYL+mgZe6PAM+SI5qKlSF1sMp5XlfSI8kVf0Pp8YNwLDf2gONxKMYJQSgvDBPDv
 +pPKRtH9+TLvaEv99zF2fKNo4uzSrMsFUtGBWjLq72xMHCCrGakxIZBVseOfCzcCzyoqPnzO
 70NwqGuKuADkXZLr5F4T+Rhw5Uh6oa9vLRd1AllQinGNgz5FrN6L3Ca9sBTrakRlKRBsA67V
 xvXqNlXMLmEIu3/F1sVKFZ3Z+iPz6hMyDLT8e40MAPx4youpOiLVkBbPh+tji1BLeQqbNN5k
 Ll54MNPsl6xkBsnNNqCnxt4zWXUIyxSSbgju7EbHJTv1lghxGZdbMGOESTx+pyONYlBaxF4P
 j+OiaPerL1A3U6eIWErHH3A0OcB15QDvBdGkA0LK1iTw4eXg/Y22Fta8CgtTxQTxRJCirohN
 m9uPkxzBKOP4zY325QTAzHyQ1lMVE+D50j861oVj2mIHUCnW1vEIHA5JevQrlsS9HhRf2QD8
 byVoIo/ve0GoC0lMvMOZHNY
IronPort-HdrOrdr: A9a23:sRTl7KhwrtwP2oKb0C08lGb1V3BQXiAji2hC6mlwRA09TyX5ra
 2TdTogtSMc6QxhPE3I/OrrBEDuexzhHPJOj7X5Xo3SOTUO2lHYT72KhLGKq1Hd8kXFndK1vp
 0QEZSWZueQMbB75/yKnTVREbwbsaW6GHbDv5ag859vJzsaFZ2J921Ce2Gm+tUdfng8OXI+fq
 DsgPZvln6bVlk8SN+0PXUBV/irnaywqHq3CSR2fiLO8WO1/EuV1II=
X-IronPort-AV: E=Sophos;i="5.88,353,1635220800"; 
   d="scan'208";a="63200731"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=RKcUztD0rQHYioHQm/00q2Yc6rSGd5LN6uOsCFKoEf9lWWyq08O3J1UskFSI68bBnhv0BnQt0Fuhd4Te8rt0B666eoP7EOD+MniMawxUcAZ/LPn34BtQLyF2V0NSWH/qDnULvpQ5tNwpbA5jhXVzNrrhY8i5b8CcOPJnUlnnX2KaZrZZ1adreBSmVOIbYASn0B5GTht+s508XtrQ3ayV9NhlVzGELlkWCcUJ44wfN9SGFK3WPMrfBkrKr+0dbrXkDnoRv0gCqGTDt8nQwId7d++6WVMiIGS1V2+ov77KNx5Sl1p8xFK7LybxTACytl4D6RpulmGuZ0lTNzjLCbyL5g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=L2/1lksse+ybjWY2ukmke7t3TXw+dHDefZ9VtKNrgec=;
 b=LXQs4gFUKjJfzzcyARbkbKX/JynJ9e5GI3I8GllVczjmlTM3Vei4sLGRvEYBfDWV1N2p6t9JeU0h11ndBy5Sig1l4qvZBmakOT4pmrddhLmv6E8v1afhaqkRjGGrRxErlb5xPHKEZ42i9whqXHC42F7uoKle7AFbmAn+g0K6Ayg1KZny45nGS84wixI+oFKQSLQFoVZEbwr3CrmvZOvjCcme8YsKwe1leVKxJzm3p51IOI8PTTxLu7obsZAatexK8wieIv/p8jqwoYXS5RB9cCJ+NHuFT1VNj9eLedWMJg61X4CzkBfdT8XiMqea+nX4KKCVQR8qeOrOR3cxuWizQg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=L2/1lksse+ybjWY2ukmke7t3TXw+dHDefZ9VtKNrgec=;
 b=Q4/4EtzfB9VYcFoQuR9B/YoQhBoOS2j5/jRWKsT1VkYB+kLPKJISFhMdXhItP/LQlnf+KDCaOjjggUB1RLf5fc8Uz5oHhPhxt+hJw9qShseFoehwmRfpP00F9poikRTx6Ane9Vc+N8n6d7JmRs0gHnlRsbYg8EH1bI++ez4sF/A=
Date: Tue, 8 Feb 2022 16:26:28 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jane Malalane <jane.malalane@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>, Anthony
 PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, Andrew
 Cooper <andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>, Stefano
 Stabellini <sstabellini@kernel.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>,
	Jun Nakajima <jun.nakajima@intel.com>, Kevin Tian <kevin.tian@intel.com>
Subject: Re: [PATCH v2 1/2] xen+tools: Report Interrupt Controller
 Virtualization capabilities on x86
Message-ID: <YgKLpCnhjP18c7oo@Air-de-Roger>
References: <20220207182101.31941-1-jane.malalane@citrix.com>
 <20220207182101.31941-2-jane.malalane@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220207182101.31941-2-jane.malalane@citrix.com>
X-ClientProxiedBy: LO2P123CA0088.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:138::21) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f8132a86-9fe6-46bb-05d5-08d9eb17637d
X-MS-TrafficTypeDiagnostic: SA2PR03MB5708:EE_
X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
X-Microsoft-Antispam-PRVS: <SA2PR03MB57083F0EE7BA668CCBF098598F2D9@SA2PR03MB5708.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5516;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: tTbiVkem4CWEZ6xiAAgJuxtIrOpnj/o0ZrN4cXPF+qlt1zfyRMWRhPrj5odWDd//SL6lXg6ipS51D46cTzILLBz6t+Kz0tOfLaXuAP9Y0Hei4v9BYgdR+hfjKeWUaXvHFrxQJnOFQnVtrzRb8si32PWHt+O2mkg1Pn0ozmYEdFIJ9b8A8QE2S0rSG8qwPY7kVwPFW8SMYaTnW6/OUt1JWqxYuSKjUeBhctS4T7LYRpeDdE6R2V2xOFtv47Yv2KfpY6YkZtK6nZPr78z+Gs/lcuRByPDiqji5CO5l38yZ0Sq7DqknVAKXd9ZArSCA9Psh9Esw1llRkSqtIvaJF9Ujud8nxqAvnwci+rONLgdLR1SEtD9PoUujdMSqNqKXFWb1AxwPOjzzaJb5y9ZgXvgVIrbZkbnTv+rx8y7v2acVy3By4yjLU+BX9QXslkAqKk2Uc4CSUMgC9F6rwHyzRCOZ1iebEfe0EodZ0f9PXToAyaew6xRUke+bgKjxqiDdRWpJMdoUz9qhM56CsEW0nsY1IlSCgvi2YI3rricIs4PsCpv5YRUm9iFA+JBBXls7GBTCkAgJPZbSj5g63Buq1IqA8iggboFqgRTxsfvX7rxjI7wicP23c5NsUYq/CrAqK6DwZ38V4a/okIPnv0JSHnu8bT4OfepW2BMbNcyLM7evTJoeS6lhA/VYmW3MRmPUpl4Ghxgarcjn2uO0UKf2Arxy8g==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(2906002)(82960400001)(26005)(186003)(38100700002)(33716001)(83380400001)(316002)(508600001)(54906003)(6636002)(6506007)(6486002)(4326008)(6666004)(66476007)(66946007)(66556008)(85182001)(6862004)(8676002)(8936002)(7416002)(9686003)(86362001)(30864003)(6512007)(5660300002)(21314003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M1pJU2xiQk5JSVYxQzYrWjdEc0E5ZjBvaWtyWGZPN2JiQnRSNG83Zndkbll1?=
 =?utf-8?B?bjRrZGJaWlRBbDA3UkxxVjJuQXd3azZWUExqY29GUGZTaDVLWWgwKzQ2S1U3?=
 =?utf-8?B?WTgzdXlqRUoyVmxnUmExRFJqSnh1cndsODgrd1p3Z0s1eUhJMzVySnBuQmtC?=
 =?utf-8?B?RUEyWHJGRC94VkJXbmV2SUpmczJlZmxoZWViTGYwL3VOOWs4aDROZ0w5Q2VU?=
 =?utf-8?B?V2FndVRQWElReXlnOWQxTlV3dUFnd04xREtwUm03ZlNlWmZBNzVyUEZHVW1L?=
 =?utf-8?B?UVExcHMvYlFXSUQ3VXFKVWZTdEY0NEN4SHJZR0xZRitWTXVUQ1ZZUDJXTHZ3?=
 =?utf-8?B?c0ljVjZVUDRNelptZE1vb1hyZ0ZPaXFMTGIzM3F0SXpDclY3d2M3aEt6eFQw?=
 =?utf-8?B?NDdGclVBa2NteGdLcXlGN2trSzFqQ1lzYlgvS21yb1l0dE1iWndMKy95TnFY?=
 =?utf-8?B?c2tGTy80RXdEQ0Z5TEhkb1d0WHljdnh1MFRkakwvSzFRN284RGUyS0pUMzQz?=
 =?utf-8?B?NnN3cHpwV0dBNGgxTE9uRWFLV0VvK3hvbDIrRHp0b2tuMGRrbjVpVURkSXUv?=
 =?utf-8?B?ZGovV1VYWVlVTlA1aHRISkphY3JyWFRGWnNkcXVFR3BBMEZjVnJIUWRsdkFm?=
 =?utf-8?B?VUE5Z2ZVYWJlb1dzQTQrQTJSeW14L29oVW9HY3FSbEQwWFg1OTRjWjZFcEVQ?=
 =?utf-8?B?c2cxbmZXdHAzK3loK09iNnhuOFM1OG44Wk56OW84QmVxR21CU2FMQU8rZmQy?=
 =?utf-8?B?M1B3SFZIcnhqVzVmOFFQeEc2ejhYS1Fib1ZEejB2dm5hQUgyZFhSM1FxcVEw?=
 =?utf-8?B?LytmQ2NGQ2tOeU92eWdnRVNqZ3plb3B6dy82K0RIbGVmNHU1bE9Od1JhK0t5?=
 =?utf-8?B?cVJZL1hlb2x2cUg3YTQ2QTYzb3hRSFpwdXhvTDZBQ1dMaWpPWHk2ZjI1dzRt?=
 =?utf-8?B?UWpxYi9NRWNCZVduWDdza0FRK0s4YWVDT3Axck52WExBR1VqaVR4L0NjNDhy?=
 =?utf-8?B?Nklpc3dtSjdOU3dod0dzK2l0SGNHYzh1dU9Pa3JaaE0xZHhjbDR1V0RCK25H?=
 =?utf-8?B?R1RuY0pITldETFdBYjUvMG9WTXdsRzhzU3NKdGNneUloVThDeVQrOGh6ZkFE?=
 =?utf-8?B?RE5LN0pSVUtTUElRd0plNkk2VGlnZEpKOW9GVENGNm1QeEhzUE45cU5sZDha?=
 =?utf-8?B?MXhnWXA0V20yYkFydTd1ZWYrVFV0QWp3dFNOVitWSm5ua3hUaXVWL0c4WVdV?=
 =?utf-8?B?ZHJXUlFiWTJ0bXRWNlpzTE9TU3I1UmpyNHU2cHJYQ2RwUXhBTEFiVERDYVNu?=
 =?utf-8?B?OVVnT1hjSlMrYzhUYzdWTnE3dk15bnFpaXBsdWV5eHpqNkdUc3FiVTVkR3M1?=
 =?utf-8?B?T1FsL3dyM091SDJzUHd1QUlUbWpYdXRaVDQ2RTBWU1M2VGdBQ3lMNk9RUHpH?=
 =?utf-8?B?endyTVJINXByakN6MmtGclZCek9hTVFqUFR5RUpBRWJzeWZSUzVadWMyUTA2?=
 =?utf-8?B?RmtnOVl1MThTSkRMNmUrMVBrU3ZNUTZXZlRoNGVuWXFlVll0dFV4Q0RWa2Uw?=
 =?utf-8?B?dnJ6M3lEOFU4eEsySEd4dEF0RTJuV215S0MwMnB5bXZzOHlQeUl4SXJSZnRH?=
 =?utf-8?B?S21wdDRuS1l3b3krenBDSkJxbE53UmtTRDZvMlovWVRLa3RXeG13OGozSGxn?=
 =?utf-8?B?eWM0cFEvc3hQL3VpRjUwMHgxdGU4WFdzM1dUdkpTTnl0YU1OWURYNWRFOWM1?=
 =?utf-8?B?aXYvNUZacFMxRC84aTcrNjIzekNIOC9LNENqRnExYmJIQjdxWTlIMDhWU0V4?=
 =?utf-8?B?Z1AzcU9kRk1wVVNGZmhkdU42Ui9ncE9nUEhRKzRnMFpsWEJYbm04clMyU1pk?=
 =?utf-8?B?c0Fza0hiejJCZWNtcXNqazVnMFYxM1F0S0k2dFpJa1NSMXNKNGlGYllqd0xs?=
 =?utf-8?B?SXV2NWVYWGlOc2NHVGlqd3orSHc4T3BnRVpHRTJWbzZ6R3hJZlYwZkJVbGk5?=
 =?utf-8?B?WWNrU2dxZGgzcXE5UFJCWjBmM3p1aW8zdXZVVjQ0Nk5HdVo4TEI0RFNOMEl1?=
 =?utf-8?B?WEdoTkxwRTd2c0huc0RDQkI3R2QvTFNiSktRMS91N1I2eHN2bTY5TFZDaW5M?=
 =?utf-8?B?VVEwMEpvZUlLdHJkSWU5MkhqbXBIQmc5eVBrYmJVbnExazZQRVFNQVBtVURu?=
 =?utf-8?Q?T0GjVSQumjJg05xS7BONghg=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f8132a86-9fe6-46bb-05d5-08d9eb17637d
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2022 15:26:33.8359
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1IfbTSxBG0y8dcnpHJA/AaubIohJ2NuN7HCROBqvOwtxcYDr8zGuI6KwH71UzX/s7rWhbpp8l7zApTDddie8HA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR03MB5708
X-OriginatorOrg: citrix.com

On Mon, Feb 07, 2022 at 06:21:00PM +0000, Jane Malalane wrote:
> Add XEN_SYSCTL_PHYSCAP_ARCH_ASSISTED_xapic and
> XEN_SYSCTL_PHYSCAP_ARCH_ASSISTED_x2apic to report accelerated xapic
> and x2apic, on x86 hardware.
> No such features are currently implemented on AMD hardware.
> 
> For that purpose, also add an arch-specific "capabilities" parameter
> to struct xen_sysctl_physinfo.
> 
> Signed-off-by: Jane Malalane <jane.malalane@citrix.com>
> Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>

Tag order should be inverted, first Suggested-by, then SoB.

> ---
> CC: Wei Liu <wl@xen.org>
> CC: Anthony PERARD <anthony.perard@citrix.com>
> CC: Juergen Gross <jgross@suse.com>
> CC: Andrew Cooper <andrew.cooper3@citrix.com>
> CC: George Dunlap <george.dunlap@citrix.com>
> CC: Jan Beulich <jbeulich@suse.com>
> CC: Julien Grall <julien@xen.org>
> CC: Stefano Stabellini <sstabellini@kernel.org>
> CC: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
> CC: Bertrand Marquis <bertrand.marquis@arm.com>
> CC: Jun Nakajima <jun.nakajima@intel.com>
> CC: Kevin Tian <kevin.tian@intel.com>
> CC: "Roger Pau Monné" <roger.pau@citrix.com>
> 
> v2:
>  * Use one macro LIBXL_HAVE_PHYSINFO_ASSISTED_APIC instead of two
>  * Pass xcpyshinfo as a pointer in libxl__arch_get_physinfo
>  * Set assisted_x{2}apic_available to be conditional upon "bsp" and
>    annotate it with __ro_after_init
>  * Change XEN_SYSCTL_PHYSCAP_ARCH_ASSISTED_X{2}APIC to
>    .._X86_ASSISTED_X{2}APIC
>  * Keep XEN_SYSCTL_PHYSCAP_X86_ASSISTED_X{2}APIC contained within
>    sysctl.h
>  * Fix padding introduced in struct xen_sysctl_physinfo and bump
>    XEN_SYSCTL_INTERFACE_VERSION
> ---
>  tools/golang/xenlight/helpers.gen.go |  4 ++++
>  tools/golang/xenlight/types.gen.go   |  6 ++++++
>  tools/include/libxl.h                |  7 +++++++
>  tools/libs/light/libxl.c             |  3 +++
>  tools/libs/light/libxl_arch.h        |  4 ++++
>  tools/libs/light/libxl_arm.c         |  5 +++++
>  tools/libs/light/libxl_types.idl     |  2 ++
>  tools/libs/light/libxl_x86.c         | 11 +++++++++++
>  tools/ocaml/libs/xc/xenctrl.ml       |  5 +++++
>  tools/ocaml/libs/xc/xenctrl.mli      |  5 +++++
>  tools/xl/xl_info.c                   |  6 ++++--
>  xen/arch/x86/hvm/vmx/vmcs.c          |  9 +++++++++
>  xen/arch/x86/include/asm/domain.h    |  3 +++
>  xen/arch/x86/sysctl.c                |  7 +++++++
>  xen/include/public/sysctl.h          |  8 +++++++-
>  15 files changed, 82 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/golang/xenlight/helpers.gen.go b/tools/golang/xenlight/helpers.gen.go
> index b746ff1081..dd4e6c9f14 100644
> --- a/tools/golang/xenlight/helpers.gen.go
> +++ b/tools/golang/xenlight/helpers.gen.go
> @@ -3373,6 +3373,8 @@ x.CapVmtrace = bool(xc.cap_vmtrace)
>  x.CapVpmu = bool(xc.cap_vpmu)
>  x.CapGnttabV1 = bool(xc.cap_gnttab_v1)
>  x.CapGnttabV2 = bool(xc.cap_gnttab_v2)
> +x.CapAssistedXapic = bool(xc.cap_assisted_xapic)
> +x.CapAssistedX2Apic = bool(xc.cap_assisted_x2apic)
>  
>   return nil}
>  
> @@ -3407,6 +3409,8 @@ xc.cap_vmtrace = C.bool(x.CapVmtrace)
>  xc.cap_vpmu = C.bool(x.CapVpmu)
>  xc.cap_gnttab_v1 = C.bool(x.CapGnttabV1)
>  xc.cap_gnttab_v2 = C.bool(x.CapGnttabV2)
> +xc.cap_assisted_xapic = C.bool(x.CapAssistedXapic)
> +xc.cap_assisted_x2apic = C.bool(x.CapAssistedX2Apic)
>  
>   return nil
>   }
> diff --git a/tools/golang/xenlight/types.gen.go b/tools/golang/xenlight/types.gen.go
> index b1e84d5258..5f384b767c 100644
> --- a/tools/golang/xenlight/types.gen.go
> +++ b/tools/golang/xenlight/types.gen.go
> @@ -389,6 +389,10 @@ RunHotplugScripts Defbool
>  DriverDomain Defbool
>  Passthrough Passthrough
>  XendSuspendEvtchnCompat Defbool
> +ArchX86 struct {
> +AssistedXapic Defbool
> +AssistedX2Apic Defbool

Don't you need some indentation here?

Also name would better be Assistedx{2}APIC IMO if possible. Having a
capital 'X' and lowercase 'apic' looks really strange.

> +}
>  }
>  
>  type DomainRestoreParams struct {
> @@ -1014,6 +1018,8 @@ CapVmtrace bool
>  CapVpmu bool
>  CapGnttabV1 bool
>  CapGnttabV2 bool
> +CapAssistedXApic bool
> +CapAssistedX2apic bool
>  }
>  
>  type Connectorinfo struct {
> diff --git a/tools/include/libxl.h b/tools/include/libxl.h
> index 2bbbd21f0b..924e142628 100644
> --- a/tools/include/libxl.h
> +++ b/tools/include/libxl.h
> @@ -528,6 +528,13 @@
>  #define LIBXL_HAVE_MAX_GRANT_VERSION 1
>  
>  /*
> + * LIBXL_HAVE_PHYSINFO_ASSISTED_APIC indicates that libxl_physinfo has
> + * cap_assisted_x{2}apic fields, which indicates the availability of x{2}APIC
> + * hardware assisted virtualization.
> + */
> +#define LIBXL_HAVE_PHYSINFO_ASSISTED_APIC 1
> +
> +/*
>   * libxl ABI compatibility
>   *
>   * The only guarantee which libxl makes regarding ABI compatibility
> diff --git a/tools/libs/light/libxl.c b/tools/libs/light/libxl.c
> index 667ae6409b..fabb474221 100644
> --- a/tools/libs/light/libxl.c
> +++ b/tools/libs/light/libxl.c
> @@ -15,6 +15,7 @@
>  #include "libxl_osdeps.h"
>  
>  #include "libxl_internal.h"
> +#include "libxl_arch.h"
>  
>  int libxl_ctx_alloc(libxl_ctx **pctx, int version,
>                      unsigned flags, xentoollog_logger * lg)
> @@ -410,6 +411,8 @@ int libxl_get_physinfo(libxl_ctx *ctx, libxl_physinfo *physinfo)
>      physinfo->cap_gnttab_v2 =
>          !!(xcphysinfo.capabilities & XEN_SYSCTL_PHYSCAP_gnttab_v2);
>  
> +    libxl__arch_get_physinfo(physinfo, &xcphysinfo);
> +
>      GC_FREE;
>      return 0;
>  }
> diff --git a/tools/libs/light/libxl_arch.h b/tools/libs/light/libxl_arch.h
> index 1522ecb97f..207ceac6a1 100644
> --- a/tools/libs/light/libxl_arch.h
> +++ b/tools/libs/light/libxl_arch.h
> @@ -86,6 +86,10 @@ int libxl__arch_extra_memory(libxl__gc *gc,
>                               uint64_t *out);
>  
>  _hidden
> +void libxl__arch_get_physinfo(libxl_physinfo *physinfo,
> +                              const xc_physinfo_t *xcphysinfo);
> +
> +_hidden
>  void libxl__arch_update_domain_config(libxl__gc *gc,
>                                        libxl_domain_config *dst,
>                                        const libxl_domain_config *src);
> diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c
> index eef1de0939..39fdca1b49 100644
> --- a/tools/libs/light/libxl_arm.c
> +++ b/tools/libs/light/libxl_arm.c
> @@ -1431,6 +1431,11 @@ int libxl__arch_passthrough_mode_setdefault(libxl__gc *gc,
>      return rc;
>  }
>  
> +void libxl__arch_get_physinfo(libxl_physinfo *physinfo,
> +                              const xc_physinfo_t *xcphysinfo)
> +{
> +}
> +
>  void libxl__arch_update_domain_config(libxl__gc *gc,
>                                        libxl_domain_config *dst,
>                                        const libxl_domain_config *src)
> diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl
> index 2a42da2f7d..42ac6c357b 100644
> --- a/tools/libs/light/libxl_types.idl
> +++ b/tools/libs/light/libxl_types.idl
> @@ -1068,6 +1068,8 @@ libxl_physinfo = Struct("physinfo", [
>      ("cap_vpmu", bool),
>      ("cap_gnttab_v1", bool),
>      ("cap_gnttab_v2", bool),
> +    ("cap_assisted_xapic", bool),
> +    ("cap_assisted_x2apic", bool),
>      ], dir=DIR_OUT)
>  
>  libxl_connectorinfo = Struct("connectorinfo", [
> diff --git a/tools/libs/light/libxl_x86.c b/tools/libs/light/libxl_x86.c
> index 1feadebb18..e0a06ecfe3 100644
> --- a/tools/libs/light/libxl_x86.c
> +++ b/tools/libs/light/libxl_x86.c
> @@ -866,6 +866,17 @@ int libxl__arch_passthrough_mode_setdefault(libxl__gc *gc,
>      return rc;
>  }
>  
> +void libxl__arch_get_physinfo(libxl_physinfo *physinfo,
> +                              const xc_physinfo_t *xcphysinfo)
> +{
> +    physinfo->cap_assisted_xapic =
> +        !!(xcphysinfo->arch_capabilities &
> +           XEN_SYSCTL_PHYSCAP_X86_ASSISTED_XAPIC);
> +    physinfo->cap_assisted_x2apic =
> +        !!(xcphysinfo->arch_capabilities &
> +           XEN_SYSCTL_PHYSCAP_X86_ASSISTED_X2APIC);
> +}
> +
>  void libxl__arch_update_domain_config(libxl__gc *gc,
>                                        libxl_domain_config *dst,
>                                        const libxl_domain_config *src)
> diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl.ml
> index 7503031d8f..7ce832d605 100644
> --- a/tools/ocaml/libs/xc/xenctrl.ml
> +++ b/tools/ocaml/libs/xc/xenctrl.ml
> @@ -127,6 +127,10 @@ type physinfo_cap_flag =
>  	| CAP_Gnttab_v1
>  	| CAP_Gnttab_v2
>  
> +type physinfo_cap_arch_flag =
> +	| CAP_ARCH_ASSISTED_XAPIC
> +	| CAP_ARCH_ASSISTED_X2APIC
> +
>  type physinfo =
>  {
>  	threads_per_core : int;
> @@ -139,6 +143,7 @@ type physinfo =
>  	scrub_pages      : nativeint;
>  	(* XXX hw_cap *)
>  	capabilities     : physinfo_cap_flag list;
> +	arch_capabilities : physinfo_cap_arch_flag list;

I know very little about Ocaml, but I think you are not setting this
field anywhere? I would expect a call to ocaml_list_to_c_bitmap and
then you will likely need to define XEN_SYSCTL_PHYSCAP_X86_MAX so you
can check the options. See XEN_SYSCTL_PHYSCAP_MAX for example.

>  	max_nr_cpus      : int;
>  }
>  
> diff --git a/tools/ocaml/libs/xc/xenctrl.mli b/tools/ocaml/libs/xc/xenctrl.mli
> index d1d9c9247a..a2b15130ee 100644
> --- a/tools/ocaml/libs/xc/xenctrl.mli
> +++ b/tools/ocaml/libs/xc/xenctrl.mli
> @@ -112,6 +112,10 @@ type physinfo_cap_flag =
>    | CAP_Gnttab_v1
>    | CAP_Gnttab_v2
>  
> +type physinfo_cap_arch_flag =
> +  | CAP_ARCH_ASSISTED_XAPIC
> +  | CAP_ARCH_ASSISTED_X2APIC
> +
>  type physinfo = {
>    threads_per_core : int;
>    cores_per_socket : int;
> @@ -122,6 +126,7 @@ type physinfo = {
>    free_pages       : nativeint;
>    scrub_pages      : nativeint;
>    capabilities     : physinfo_cap_flag list;
> +  arch_capabilities : physinfo_cap_arch_flag list;
>    max_nr_cpus      : int; (** compile-time max possible number of nr_cpus *)
>  }
>  type version = { major : int; minor : int; extra : string; }
> diff --git a/tools/xl/xl_info.c b/tools/xl/xl_info.c
> index 712b7638b0..3205270754 100644
> --- a/tools/xl/xl_info.c
> +++ b/tools/xl/xl_info.c
> @@ -210,7 +210,7 @@ static void output_physinfo(void)
>           info.hw_cap[4], info.hw_cap[5], info.hw_cap[6], info.hw_cap[7]
>          );
>  
> -    maybe_printf("virt_caps              :%s%s%s%s%s%s%s%s%s%s%s\n",
> +    maybe_printf("virt_caps              :%s%s%s%s%s%s%s%s%s%s%s%s%s\n",
>           info.cap_pv ? " pv" : "",
>           info.cap_hvm ? " hvm" : "",
>           info.cap_hvm && info.cap_hvm_directio ? " hvm_directio" : "",
> @@ -221,7 +221,9 @@ static void output_physinfo(void)
>           info.cap_vmtrace ? " vmtrace" : "",
>           info.cap_vpmu ? " vpmu" : "",
>           info.cap_gnttab_v1 ? " gnttab-v1" : "",
> -         info.cap_gnttab_v2 ? " gnttab-v2" : ""
> +         info.cap_gnttab_v2 ? " gnttab-v2" : "",
> +         info.cap_assisted_xapic ? " assisted_xapic" : "",
> +         info.cap_assisted_x2apic ? " assisted_x2apic" : ""
>          );
>  
>      vinfo = libxl_get_version_info(ctx);
> diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c
> index 7ab15e07a0..4060aef1bd 100644
> --- a/xen/arch/x86/hvm/vmx/vmcs.c
> +++ b/xen/arch/x86/hvm/vmx/vmcs.c
> @@ -343,6 +343,15 @@ static int vmx_init_vmcs_config(bool bsp)
>              MSR_IA32_VMX_PROCBASED_CTLS2, &mismatch);
>      }
>  
> +    /* Check whether hardware supports accelerated xapic and x2apic. */
> +    if ( bsp )
> +    {
> +        assisted_xapic_available = cpu_has_vmx_virtualize_apic_accesses;
> +        assisted_x2apic_available = (cpu_has_vmx_apic_reg_virt ||
> +                                     cpu_has_vmx_virtual_intr_delivery) &&
> +                                    cpu_has_vmx_virtualize_x2apic_mode;
> +    }
> +
>      /* The IA32_VMX_EPT_VPID_CAP MSR exists only when EPT or VPID available */
>      if ( _vmx_secondary_exec_control & (SECONDARY_EXEC_ENABLE_EPT |
>                                          SECONDARY_EXEC_ENABLE_VPID) )
> diff --git a/xen/arch/x86/include/asm/domain.h b/xen/arch/x86/include/asm/domain.h
> index e62e109598..72431df26d 100644
> --- a/xen/arch/x86/include/asm/domain.h
> +++ b/xen/arch/x86/include/asm/domain.h
> @@ -756,6 +756,9 @@ static inline void pv_inject_sw_interrupt(unsigned int vector)
>                        : is_pv_32bit_domain(d) ? PV32_VM_ASSIST_MASK \
>                                                : PV64_VM_ASSIST_MASK)
>  
> +extern bool assisted_xapic_available;
> +extern bool assisted_x2apic_available;
> +
>  #endif /* __ASM_DOMAIN_H__ */
>  
>  /*
> diff --git a/xen/arch/x86/sysctl.c b/xen/arch/x86/sysctl.c
> index aff52a13f3..642cc96985 100644
> --- a/xen/arch/x86/sysctl.c
> +++ b/xen/arch/x86/sysctl.c
> @@ -69,6 +69,9 @@ struct l3_cache_info {
>      unsigned long size;
>  };
>  
> +bool __ro_after_init assisted_xapic_available;
> +bool __ro_after_init assisted_x2apic_available;

You could likely shorten this by dropping the _available suffix.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 16:01:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 16:01:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268454.462287 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHSvO-000237-41; Tue, 08 Feb 2022 16:01:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268454.462287; Tue, 08 Feb 2022 16:01:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHSvO-000230-06; Tue, 08 Feb 2022 16:01:02 +0000
Received: by outflank-mailman (input) for mailman id 268454;
 Tue, 08 Feb 2022 16:01:00 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mkaY=SX=citrix.com=Jane.Malalane@srs-se1.protection.inumbo.net>)
 id 1nHSvL-00022s-Tt
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 16:01:00 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4ac61849-88f8-11ec-8f75-fffcc8bd4f1a;
 Tue, 08 Feb 2022 17:00:56 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4ac61849-88f8-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644336056;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=ZNBMT+8cjMEACLKu2VApF6fj8meZ3l30g+HS/RUbY4o=;
  b=OPYLqUD619QxRvfEJBVUQP4nj1n7doW5qa/StA5Murjs857Y8k5sQ/V/
   Xc0sZ0Em1zmYQKPEPG0JIMlK5CQjMecjdU4EIR0xWGCAXR8uU/2RUDXsx
   6kK4aqlqVrx1Ou58kAnFFG0hIoCxanHRqEABDtQppvzCllNp17adkoZyE
   8=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: D9Mcc0Wu470JP6qVflOkUR0eiOCC6uZFWhlgxDhYahmMWJ+vLNdncJ751lCi2rLbHTY2F22xE9
 lCTSapGuu/UFFJPPGr+Lchd45rSbdAImd93pcMIcwhL2pfWCbaOgle2BZT3uD5S7ltek3a9b5i
 7WCdXn1gphJ0lL8nN/5RLRLUBRqA2p7MgFM6VraIV8fH+z3+BpTt2wQ+d8auIfVR4AmBTn/ru2
 FIhWis6NzUGy8uWpzVaRU2JqWkWcm7MaOMxSFE3aiRfWEC3qLoNx9RTso0D+vrKy5zImSgVpvc
 9ReU6y9D2l/d+TkvvwCM8ZSF
X-SBRS: 5.1
X-MesageID: 65962671
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:uCWzG6PlWJ6iSwvvrR3hkcFynXyQoLVcMsEvi/4bfWQNrUp21jZRz
 zAfWmqHOfnZY2qme4x0aYvi9E8OuZTTy4RkQQto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6UUsxNbVU8En1500ozw7RRbrNA2rBVPSvc4
 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq
 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYo2S0nOp46
 /5Dj4SpRQJwMonHwN4vcyANRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs
 6VFdnZdNXhvhMrvqF6/YstlgMllCcDvNYcWvHxIxjDFF/c2B5vERs0m4PcGgWZu3J4RRJ4yY
 eIaMBlUXB7ncyRdeQ8SIpshxsb5j3zGJmgwRFW9+vNsvjm7IBZK+LTkLtf9YNGBQsRR2EGCq
 Qru5H/lCxsXMNiezzut8X+2gOLL2yThV+o6BLC+s/JnnlCX7mgSEwENE0u2p+GjjUyzUM4ZL
 FYbkgIQqqw1+F2uX8PKdRSyq36ZvTYRQ9NVVeY97Wml1a788wufQG8eQVZpatYrqcs3TjwCz
 UKSkpXiAjkHmL+ITXOQ8J+EoDX0PjIaRUcAajUDVhAt+MT4rcc4iRenczp4OPfr1JuvQ2i2m
 m3U6nhl71kOsSIV//SG/mrOoBminIDQQgts6iHcBliXzjosMeZJeLeUwVTc6P9BKqOQQV+Ao
 GUIlqCi0QweMX2evHfTGbtQRdlF897AaWSB2gA3Q/HN4hzwoybLQGxG3N1pyK6F2O4gcCShX
 kLcsBg5CHR7bCrzNv8fj25c5q0XIUnc+TbNC6q8gjlmOMEZmOq7EMZGPx/44owVuBJw+ZzTw
 L/CGSpWMV4UCL580B29TPoH3Lkgy0gWnD2PGcmqlk35gODHPxZ5rIvp13PUP4gEAF6s+l2Jo
 76zyePWo/mgbAEOSnaOqtNCRbz7BXM6GYr3u6Rqmh2reWJb9JUaI6aJm9sJItU994wMz7ug1
 iztCydwlQuk7VWaeFriQi44MtvHA80gxU/XyARxZD5ELVB4Ot3xhEreHrNqFYQaGBtLl6YrF
 qJYIJXZWZyiiF3volwgUHU0l6Q7HDyDjgOSJSu1Jj85ep9rXQvS/dH4OADo8UEz4uCf7KPSe
 pWsiVHWR4QtXQNnAJqEYf6j1Qrp73MchPhzTw3DJdwKIBfg941jKirQiP4rIp5TdUWfl2XCj
 wvGUw0FoeTtopMu9IWbj66zsIr0QfB1GVBXHjeH4O/uZzXa5Geq3aRJTP2MIWLGTGrx9aj7P
 bdVwvjwPecphlFPt4YgQb9nwbhnv4nkpqNAzxQiF3LONgz5BrRlK3iA/M9OqqwSmeMJ5VroA
 hqCo4AIN6+INcXpFE8qCDAkNunTh+sJnjTy7OguJBmo7iFA47faA15ZOAOBiXIBIeItYp8l2
 +oopOUf9xe71kgxKt+Dgy1ZqzaMI3gHX/l1v50WGta22A8iy1UEap3AEC7mppqIbowUYEUtJ
 zaVgovEhqhdmRWeIyZiSyCV0LoPn4kKtTBL0EQGdgaAldfyj/Mq2AFcrGYsRQNPwxQbi+9+N
 wCH7aGuyXliK9uwuPV+Yg==
IronPort-HdrOrdr: A9a23:ssia1KtXOciOhmeWTiZ+hDnA7skC2YMji2hC6mlwRA09TyXGra
 6TdaUguiMc1gx8ZJh5o6H9BEGBKUmskaKceeEqTPmftXrdyRSVxeZZnMrfKlzbamLDH4tmtJ
 uIHJIOcOEYYWIK7/oSpTPIburIo+P3sJxA592utEuFJDsCA8oLgmcJaTpzUHcGPjWubaBJTq
 Z0jfA3wAZIDE5nF/hTcUN1OdQryee78a7OUFojPVoK+QOOhTSn5PrRCB6DxCoTVDtJ3PML7X
 XFuxaR3NThj9iLjjvnk0PD5ZVfn9XsjvFZAtaXt8QTIjLwzi61eYVaXaGYtjxdmpDs1L9qqq
 iIn/4TBbU115rjRBDynfIr4Xi47N8a0Q6n9bZfuwq6nSW2fkNgNyMLv/MmTvKQ0TtQgDg76t
 MX44vRjesmMTrQ2Cv6/NTGTBdsiw69pmcji/caizhFXZIZc6I5l/1UwKp5KuZJIMvB0vFtLA
 CuNrCp2N9GNVeBK3zJtGhmx9KhGnw1AxedW0AH/siYySJfknx1x1YRgJV3pAZNyLstD51fo+
 jUOKVhk79DCscQcKJmHe8EBc+6EHbETx7AOH+bZV7nCKYEMXTQrIOf2sR52Mi6PJgTiJcikp
 XIV11V8WY0ZkL1EMWLmIZG9xjcKV/NFAgFCvsukaSRloeMNoYDABfzP2zGyfHQ0Mn3KverLs
 qOBA==
X-IronPort-AV: E=Sophos;i="5.88,353,1635220800"; 
   d="scan'208";a="65962671"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=EKVY0KHMYNTDDpmWNnJo56lJrpckQpJ6x0e1Pcn2Cuz077vkq7LyWsGajRQ1rKE4Q3A8H2vxL+fDCOEL7q2GBfQMB5AUuAxklJT1KPsS/3vRwudJOO8QWok7hpLUT4go1WgB6wowzZYB07+S2iplgOU8wz5WUqX9dwBWIT52sCNS8EhDVassz+18n0dGcYOGJIIFhMLFrem1mjSC2w4MJR2RIu+kB8Fk6KQynDEQ+YkDpeI3OgbWbxUyhu4pRJmkiBV1aMGsuhmrMOPbh+Z6krSQPvYORkyY/eSHEp3A1nrKMTIDkbXJHbiJduFzP5KtZtu7TCLc3xuhs8RCdLZK3w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ZNBMT+8cjMEACLKu2VApF6fj8meZ3l30g+HS/RUbY4o=;
 b=mYYFi/uNjLOQD3TkPY8UehGaLDrvA+l+EJq6WhbrEcrF6+ZSqhaof2iDBzyO/HcAAxayptl7ZQGWztShCKakdsc3Wx1KIgdsyBZjvEre/h1yCvXZo6eAuzIO9oUXpTbQa3jiaPGGhh2t46Ui+kIRQ3rZMZtC8CApHcfsqpwsM/ZCJDMHkby4b3rmLhHe1yCo2OMyf84/hTeyGdvoMriywoZ4nSmOU+owZKixwsuplaMDjthx8mj1omSQAvBL5rvOfGXl9oss/I/OPse4aOm6jQBu40vjfXHtucYUlgjWIVy5Q9HUxSddB8EWN3I6ylItPPyqdNGkXfldooUJN71c+w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ZNBMT+8cjMEACLKu2VApF6fj8meZ3l30g+HS/RUbY4o=;
 b=BnM7XZ8d4fOjT+09Ww8GDgV+vKgx4pSNVXoo48aAAqUE+qQVh6pSNnpX/4dEDKkFigpJYBkFnsjg7TDbYV8Nt5vBiqGBH6lkI0eCP5+Fti5qzwdVkBZKtmuxZIy+wxeMTwbYEdB1Od/4NeEKiwnjl/oh0jVeFK8Zfmvr6Vgl2WE=
From: Jane Malalane <Jane.Malalane@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Wei Liu <wl@xen.org>, Anthony Perard <anthony.perard@citrix.com>, "Juergen
 Gross" <jgross@suse.com>, Andrew Cooper <Andrew.Cooper3@citrix.com>, "George
 Dunlap" <George.Dunlap@citrix.com>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Christian Lindig
	<christian.lindig@citrix.com>, David Scott <dave@recoil.org>, "Volodymyr
 Babchuk" <Volodymyr_Babchuk@epam.com>, Roger Pau Monne
	<roger.pau@citrix.com>, Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 2/2] x86/xen: Allow per-domain usage of hardware
 virtualized APIC
Thread-Topic: [PATCH 2/2] x86/xen: Allow per-domain usage of hardware
 virtualized APIC
Thread-Index: AQHYE5eVWWLwfSz8JEi35sISHqV9YKx9DnUAgAypmgCAAAcRAIAAI8CA
Date: Tue, 8 Feb 2022 16:00:48 +0000
Message-ID: <016a8399-989b-3f11-3dff-093691690ee1@citrix.com>
References: <20220127160133.11608-1-jane.malalane@citrix.com>
 <20220127160133.11608-3-jane.malalane@citrix.com>
 <8b59b7d7-2d0a-0b8a-f936-1e537dfc4f9a@suse.com>
 <a4af7c49-99af-b66a-a05f-2907fa6d50f1@citrix.com>
 <f725c58c-1f70-893c-b6a4-649c636263ec@suse.com>
In-Reply-To: <f725c58c-1f70-893c-b6a4-649c636263ec@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: fc423add-7623-495a-8db9-08d9eb1c2c8b
x-ms-traffictypediagnostic: BN6PR03MB2481:EE_
x-microsoft-antispam-prvs: <BN6PR03MB248134BF4367CA25A86EEEE0812D9@BN6PR03MB2481.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: +wA5+P3MEM6vrojL7w+zW+uiW5BsoyFN8F0WwKQ4WELox3ga/9L3O+AuGwWdR19nFkbak4oLSmno4LCqyUHBd0gh/C4FxKKjeea3s3OxfMQge+vTG8Gx/PXGsKYTvM+pQHAKEbEHsNKAH41FAVXiMQSQoEjFJ0Mxjb998j4dJJ/V4WAve/lQf/q7wO7xPn7pVZ44x9UrwUWKAH9UbnY/+gjVgR6UI4QVA+4IXQiC+MIa0x6Zgbd5sxZAtp6hX0xPRNb3Llvm4YN4eg9VZL977/4lwRXQGYqtQ4afcnBcHItIoyfKiCvscpYkSIH2bsATfzK2Em5y78In/V6kkoFYInUgPmlWSGr3LYy5U/vCGonG5W6RUj/an140HLVBI44sJuWWkTxphTeq+top6qd+AgL735a6W1CWWt+roLbJaZrG84vZ5GQA3+tX8FCtvPX5q0NdXo5TW7G2iP64kwvmcjzEvldceFGYuGLitwcQP9xz5fcaRVPvgxLHwBxtizrGeiQ8Ot2/ErsZwu+/CtBpASBFq2GzL0siZaNI5gH+Wq2YksUf2NL6Hgvpi92jSyuFcz4HtYyxgqdzpVQqUa+PQ1gbUPsfij6H4GNG8cfM+85K8dXUAUcCzxRccaEZ4tvi7TrHZqD37yactdVbunvpdwJb0JM3H9AT04XpsfbIFcr5FmjV1/y2VHsPq6TrXcgkRXkIDj+lZF80wKDtbzWhU5de50mNfaLrd8+4h+Lz/KGTomeWUtSEjDgR3C/AQ6ke
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR03MB3386.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(5660300002)(83380400001)(71200400001)(6486002)(36756003)(6506007)(31696002)(8936002)(66946007)(66556008)(76116006)(66446008)(8676002)(86362001)(4326008)(91956017)(6512007)(64756008)(66476007)(38070700005)(2906002)(31686004)(186003)(26005)(82960400001)(122000001)(38100700002)(508600001)(54906003)(6916009)(2616005)(316002)(53546011)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?RFJRVE9WNldqMmpDd1FXUkVodlpmYm5iRlBkdXZEWlJnSzVCWG1BVDl3azhM?=
 =?utf-8?B?L1JnRGVsbDRyYi8rRy9kcm1PdWhaaTMydHR2UlhhUndoTUtzT0sxcThReUZj?=
 =?utf-8?B?VGxZRmVFMGtMc2REMVlLL2c0YXNiOUZ6NE9BQ1ZHNGtFY0F6ZUt1eG9MZkFk?=
 =?utf-8?B?VGovRDRUSTAwOFVsSm5RcjQ1clUvaEw5bUxwaVBxQTVteWZUN2NsQnc0cHJI?=
 =?utf-8?B?NjhBTFp6WHVVQ05pc1kraGNFUTVQQWkrdzdHbUdzVmNJOG1ET2RRaUNtR2pu?=
 =?utf-8?B?cVRkVzcvODU5NDBwcHljeWxYNUgrV1dPYk1OUGx2MG42NXNjclhSa28vbndG?=
 =?utf-8?B?RzdLNWVWdER1Z05HMEJ3MlpZMDJkaUlUTGZBRTZLeC9naXpRcDlDZklQd1NJ?=
 =?utf-8?B?dTA0c1g2QTk1RmlrWVBJUEpmR2lnOXVTOHQySVdGOGRWRE5KVW9VSVd3Qlht?=
 =?utf-8?B?ZmZ3dUdBOUo2QlcwenNmbjJwWVdTcG9GSUVkVHVVRndidE5SaS9iVE1mUTR6?=
 =?utf-8?B?T1UrZnFTYitOdS9OYktzSU1UaXpmODdJd1FIaHZ4eWtGSDdXNHRmWG56dGFm?=
 =?utf-8?B?NnYxYkhHZUZQazBicEhyTUp4cnFvSS9Jd2ZDVUROejdmTmE5aHVtb0NjbTZF?=
 =?utf-8?B?cjZEeDQ3Y2gxY3RDNmtzRE4ycW1PWVVhekNEWEEwYkU5VXQ5OU1tYkE3SUlB?=
 =?utf-8?B?YWhDTksxN3BWODVPdmxZYVJGc0p4TlI4Y25YSGdJYmtVc00vcW9CcnRCS205?=
 =?utf-8?B?SEJ3a0VIMCtYYy9VUHBaY2JPTlJhbXdtUzZud3BFelc1bDk2WmdWWjRGVVhK?=
 =?utf-8?B?OFJTMEVWdk9VMzBkaHZmUEJicDdONHVNSWkrN0hYcmJzWlVLbmJ3bUZEaTl5?=
 =?utf-8?B?cVZLMjdYbmpnbzRjazIvdTY4RzRyKzdNRGdIUFhuMVlPOU05U0VVU2ZJd0xh?=
 =?utf-8?B?NzdsMEZkemh5aHVjeW5yVElkNWMvdnVrMlY0NUN3RlRQYVdmdEFKdE5GMEJz?=
 =?utf-8?B?S0paTFpMcTZWQUZ2RkJEY0NsK3FCUW9JMWJMUzI0MGdvSzBaelMvZHZJSzVV?=
 =?utf-8?B?ZUhRSDRqWDBUdDQxNE9Dc2NKK01rR2I1VmRtUUloTDNrTWEwQnBiTnFCSlZQ?=
 =?utf-8?B?dVd4QWNkSGp5QmlsT1hORFZtNEJRaGhsSmxmYzMwTFUxSEdiSkRhL295Y2RF?=
 =?utf-8?B?SVViQjNvQXlpYkU3SDl4QmZiajRSK1pZbHl0UlRGYncvQm9zYUtQSmRWUzFz?=
 =?utf-8?B?V0pGZmd4VVNpMnJEMmE3SzFoVXQwRzMvZ1ZLWERvWHZVOXpMaEg3czlSelpE?=
 =?utf-8?B?bTR3dEwyelczK0ZXTFlsRThLV0RvREErRXVVdGkwbmZWL3hNTXhxRGFZR1N5?=
 =?utf-8?B?UHlGcWlicXBZVEtxa2xpZzhKU0VOQkllVllUVTY3WGt4QVJNM1Jkbk81SmFS?=
 =?utf-8?B?MGpHeDVNTXZGdGF6ZEc5dXkxWkk0M1hrSWJJSzIwNlM2amlPL3FVSitmUVJz?=
 =?utf-8?B?TEZNa3I3N2R2OUtXbW1HMEljZ0pleFF1Z2dYNitjanFQNUdPaGlURTQxdUFa?=
 =?utf-8?B?Lzh0cmxab1R3eEdwVElibEtuSTFka1NoMWxaQldIU0xGN3RYZUhZRzBSVFRY?=
 =?utf-8?B?YlYwcDZpeXE5a2JreEV2N0pDZXZPZVFHUHIzNEE3d293L1FxZEhKVFRXMFF3?=
 =?utf-8?B?bnlDV1hWVXkwT05memsxR2R2ZmxRMUV5c0dJcEFtN04wY2VOTk85ckVxelVR?=
 =?utf-8?B?WVV5KzNZOG5xazZvODNWemNhZFYvRHFVdHZwcVRxckdaOUs1M0MrdU1rY3JU?=
 =?utf-8?B?Uy9KVkZLVGVIeHUrbWh3UW00MG92TDY2ZFRydy9ZZTN0WjE1Q2ZIZlkrQ1Ra?=
 =?utf-8?B?NlRsa0NSWGxPY0tMcE5ZK2NGVG5LUGRNN1h3b2RSUmRXT2w3RmsyRTFsTEZo?=
 =?utf-8?B?d3dRejNPYWJzaE56bytYOVRxUjMvcWRPQ2lvNDFBMit2TmREc0lwREM4Q3V5?=
 =?utf-8?B?eEduK3JrWTZNT1VDTk12SHM0Y09HSXYzdmpyY2lPREZMZ3RHc0d4R0szS011?=
 =?utf-8?B?dWg5S0pxU2Z6eUdQMFpOWjY3ZTRFK3Bhci8rbkJkcDVzTjA0bS9NOXFWTmg5?=
 =?utf-8?B?aDVWUWNLVlEycVgycWR5UzFCbWVyR2M4djkzeUtnQ2krRkpnMU04U3A5aVoz?=
 =?utf-8?B?cnpHemlXNXM4dW9mNmR0OVVLMlNiL1kyRDg3VEt5YWxHVjZkU0ZucXFjamFP?=
 =?utf-8?Q?hqFzCi6+tpshh54ceBmjOPiDeet8cWoLwFdbtPhPa0=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <961D6E61DA38A246B87BA7A602C858E9@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM5PR03MB3386.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fc423add-7623-495a-8db9-08d9eb1c2c8b
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2022 16:00:48.7653
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: okMv1LzLWIw8+e9tigPaf0oQz1UAyxBnu7jSQhGKgkxWoJ+Rek0V290rswJ+/0DowGrGvPrs+dTQayQ5qbC5NSgdqRA0322AmeL9rrQTqJk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2481
X-OriginatorOrg: citrix.com

T24gMDgvMDIvMjAyMiAxMzo1MiwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IFtDQVVUSU9OIC0gRVhU
RVJOQUwgRU1BSUxdIERPIE5PVCByZXBseSwgY2xpY2sgbGlua3MsIG9yIG9wZW4gYXR0YWNobWVu
dHMgdW5sZXNzIHlvdSBoYXZlIHZlcmlmaWVkIHRoZSBzZW5kZXIgYW5kIGtub3cgdGhlIGNvbnRl
bnQgaXMgc2FmZS4NCj4gDQo+IE9uIDA4LjAyLjIwMjIgMTQ6MjcsIEphbmUgTWFsYWxhbmUgd3Jv
dGU6DQo+PiBPbiAzMS8wMS8yMDIyIDEyOjA1LCBKYW4gQmV1bGljaCB3cm90ZToNCj4+PiBPbiAy
Ny4wMS4yMDIyIDE3OjAxLCBKYW5lIE1hbGFsYW5lIHdyb3RlOg0KPj4+PiBJbnRyb2R1Y2UgYSBu
ZXcgcGVyLWRvbWFpbiBjcmVhdGlvbiB4ODYgc3BlY2lmaWMgZmxhZyB0bw0KPj4+PiBzZWxlY3Qg
d2hldGhlciBoYXJkd2FyZSBhc3Npc3RlZCB2aXJ0dWFsaXphdGlvbiBzaG91bGQgYmUgdXNlZCBm
b3INCj4+Pj4geHsyfUFQSUMuDQo+Pj4+DQo+Pj4+IEEgcGVyLWRvbWFpbiBvcHRpb24gaXMgYWRk
ZWQgdG8geGwgaW4gb3JkZXIgdG8gc2VsZWN0IHRoZSB1c2FnZSBvZg0KPj4+PiB4ezJ9QVBJQyBo
YXJkd2FyZSBhc3Npc3RlZCB2aXR1YWxpemF0aW9uLCBhcyB3ZWxsIGFzIGEgZ2xvYmFsDQo+Pj4+
IGNvbmZpZ3VyYXRpb24gb3B0aW9uLg0KPj4+Pg0KPj4+PiBIYXZpbmcgYWxsIEFQSUMgaW50ZXJh
Y3Rpb24gZXhpdCB0byBYZW4gZm9yIGVtdWxhdGlvbiBpcyBzbG93IGFuZCBjYW4NCj4+Pj4gaW5k
dWNlIG11Y2ggb3ZlcmhlYWQuIEhhcmR3YXJlIGNhbiBzcGVlZCB1cCB4ezJ9QVBJQyBieSBydW5u
aW5nIEFQSUMNCj4+Pj4gcmVhZC93cml0ZSBhY2Nlc3NlcyB3aXRob3V0IHRha2luZyBhIFZNIGV4
aXQuDQo+Pj4NCj4+PiBUaGlzIGlzIG9kZCB0byByZWFkIGZvciBhIHBhdGNoIHdoaWNoIG1ha2Vz
IGl0IHBvc3NpYmxlIHRvIF90dXJuIG9mZl8NCj4+PiBhY2NlbGVyYXRpb24uIEluc3RlYWQgaXQg
d291bGQgYmUgaW50ZXJlc3RpbmcgdG8ga25vdyB3aGF0IHByb2JsZW1zDQo+Pj4geW91IGhhdmUg
ZW5jb3VudGVyZWQgbWFraW5nIGl0IGRlc2lyYWJsZSB0byBoYXZlIGEgd2F5IHRvIHR1cm4gdGhp
cyBvZmYuDQo+Pg0KPj4gQWZ0ZXIgc3BlYWtpbmcgdG8gQW5kcmV3IGhlIHRvbGQgbWUgb2YgYSBw
ZXJmb3JtYW5jZSByZWdyZXNzaW9uIHRoYXQgd2FzDQo+PiByZXBvcnRlZCBzb21lIHRpbWUgYWdv
IHdoZW4gZW5hYmxpbmcgYXBpY3YgcmVsYXRlZCB0byB0aGUgcGFzcy10aHJvdWdoDQo+PiBMQVBJ
QyB0aW1lciBvZiBhIEhWTSBndWVzdCBjYXVzaW5nIFhlbiB0byBpbnRlcmNlcHQgdGhlIExBUElD
IHRpbWVyIE1TUiwNCj4+IG1ha2luZyBhbnl0aGluZyB0aGF0IHVzZXMgdGhlIExBUElDIHRpbWVy
IGVuZCB1cCBzbG93ZXIgdGhhbiBpdCB3YXMNCj4+IGJlZm9yZS4gU28sIGFkcmVzc2luZyB5b3Vy
IGNvbW1lbnQgaGVyZSwgb3RoZXIgdGhhbiBtZW50aW9uaW5nIGhvdyBiZWluZw0KPj4gYWJsZSB0
byBkaXNhYmxlIGFjY2VsZXJhdGlvbiBmb3IgYXBpY3YgY2FuIGJlIHVzZWZ1bCB3aGVuIHRlc3Rp
bmcgYW5kDQo+PiBkZWJ1Z2dpbmcsIGRvIHlvdSB0aGluayBpdCdzIHdvcnRoIG1lbnRpb25pbmcg
KGluIG1vcmUgZGV0YWlsKSB0aGF0IHRoaXMNCj4+IHBlcmYgcHJvYmxlbSBleGlzdHMsIGluIHRo
ZSBjb21taXQgbWVzc2FnZS4NCj4gDQo+IFllcywgSSB0aGluayBpdCB3b3VsZCBiZSB3b3J0aCBt
ZW50aW9uaW5nLCBhcyB0aGVuIHRoZSBwdXJwb3NlIG9mIHRoaXMNCj4gY2hhbmdlIGlzIGFsc28g
dG8gYmUgYSB3b3JrYXJvdW5kIHRoZXJlLCBub3QganVzdCB0ZXN0aW5nL2RlYnVnZ2luZy4gSW4N
Cj4gZmFjdCB0aGlzIHdvcmthcm91bmQgbWF5IHRoZW4gYmUgdmlld2VkIGFzIHRoZSBwcmltYXJ5
IHB1cnBvc2UuDQo+IA0KT2theSBJIHdpbGwgYWRkIHRoaXMgaW4gYSB2MyAoYWxvbmdzaWRlIG90
aGVyIGNoYW5nZXMgSSdsbCBoYXZlIHRvIG1ha2UpLg0KVGhhbmsgeW91LA0KDQpKYW5lLg0KDQo=


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 16:18:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 16:18:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268463.462298 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHTBu-0003bw-Iu; Tue, 08 Feb 2022 16:18:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268463.462298; Tue, 08 Feb 2022 16:18:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHTBu-0003bp-Fo; Tue, 08 Feb 2022 16:18:06 +0000
Received: by outflank-mailman (input) for mailman id 268463;
 Tue, 08 Feb 2022 16:18:05 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=GmUj=SX=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nHTBt-0003bi-0p
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 16:18:05 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id af18f7e5-88fa-11ec-8f75-fffcc8bd4f1a;
 Tue, 08 Feb 2022 17:18:02 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: af18f7e5-88fa-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644337082;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=8votztAyVj7o0zTJnE+AxFxCugKE6I2R5I4eZXfz8pc=;
  b=h32Ha76v3DoFE0Mz2gP0Yz3UCpbt3rZq32GCIkA0LU5m6EnrDKyRMFRJ
   z0T5YcHVF2miy73bldBIAKvVsKwNbldAZrtyUoYHDjXb4qfDFkR6As223
   QwqlREAszH4hJu3Z2dw/g7iAyZjmKPFILcGuCGTpjGnakYaQTQ6iCduSv
   w=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: oHZWCyIAX+LhQRofbA9GsPMWsDvQ05lLp/yDZtTX59tO6M0UuLQ0rPX1+DX1YWhoL0p/Pl5Sqb
 b0hcqkKUq+qqb+oUqWFdvTb5Nq0nkCOIOFQ1/YT2mFCeXELLrcAKJuuM0MlKDVI4SgZhBD+HtJ
 giwDnrWVBpGgvdmbxvV61CRnNBrAopYjgP2ul3PmNs33QOPCoYvDTQ+LUgv4Bu2aTzEXnXNi05
 V+/PK3XePhHdCIuBbw6JqXE12UnV+RN8bRpI5d41zH+07YyNGlhB8kCE2eMDYf+RmdpC7gfqnq
 cWjyrFDYl6WrA7UVTO8OnZSM
X-SBRS: 5.1
X-MesageID: 63752021
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:YhTz+q5JoHthxxduzsRN+QxRtIDAchMFZxGqfqrLsTDasY5as4F+v
 mAXDDuFbqqJMDahc9wnb9/jpkNVvceAx9NmHlFk/H8wHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FV8MpBsJ00o5wbZj2t4w27BVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z1
 Y5TsLeoZR0QP7DDndYlcDNpTSZQFPgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALNs7kMZlZonh95TrYEewnUdbIRKCiCdpwgmxv25oWR6+2i
 8wxLiZBZ02dTzJzZFoYMJwVv8fygUnEbGgNwL6SjfVuuDWCpOBr65D2K8bccNGOQcRTn26bq
 3jA8mC/BQsVXPSd1D6E/3SEluLJ2yThV+o6Krq88fJ7hUyJ8UYaAhYWSFiTrOGwjwi1XNc3A
 0Ad5CcGt6U5802vCN7nUHWQv3qsrhMaHd1KHIUS+AyLj6bZ/QudLmwFVSJaLswrstcsQj4n3
 UPPmMnmbRRturCITXOW9p+PsCi/fyMSKAcqZyAeShAey8L+u4x1hRXKJuuPC4bs0IezQ2uph
 WnX8m5u3N3/kPLnyY2mpk7CqCqAvKHIUwEw1D30dFP76S1QMdvNi5OT1XDX6vNJLYC8R1aHv
 WQZl8X20N3iHa1hhwTWHrxTQejBC+KtdWSF3AUxR8VJGyGFpib7Fb289g2SM6uA3iwsXTbyK
 HHetgpKjHO4FCv7NPQnC25d5ilD8EQBKTgHfq2OBjatSsIoHONiwM2JTRTBt10BaGB2zckC1
 W6zKK5A90oyB6V91yaRTOwAy7ItzS1W7TqNGcyink3+j+vEPSX9pVI53LymNLFR0U95iF+Nr
 4Y32zWil32zr9ESkgGIqNVOfDjm3FAwBIzsqtw/SwJwClEOJY3VMNeImelJU9U8x8x9z76Ul
 lngCh4w4Aeu3hXvdFTVAlg9M+mHdcgk8hoG0dkEYA/AN44LOt30ss/ytvIfINEayQCU5aQsE
 KBeJp7QW68np/au0211UKQRZbdKLXyDrQmPIzCkcH44eZthTBbO4djqYk3k8yxmM8Z9nZBWT
 2SI2lyJTJwdaR5lCcqKOvujw0no5SoWmf5oXluOKd5WIR2+/I9vIi33r/k2P8BTdkmTmmrEj
 16bUUUCuO3Ag44p692V16qKmJikTrllFU1AEmiFsbvvbXvG/nCuyJNrWfqTeWyPT3v9/aivP
 L0Hz/z1PPAdskxNto5wT+Riwa4kvoO9rL5G1AV0Wn7Mag3zWL9nJ3CH2+hJt7FMmeAF6VfnB
 BrX94ADa7uTOc7jHFoAHyYfb7yOhaMOhz3fzfUpO0GmtiV5y6WKDBdJNB6WhS0DcLYsaNE5w
 f0ssdI94hCkjkZ4Kc6Piy1Z+jjeLnEEVKl75JgWDJWy11guw1BGJ5fdFjX38NeEbNAVahsmJ
 TqdhazjgbVAxxWdLypvRCaVhecN144TvB1qzUMZIwXbk9XIsfY7wRlN/GllVQ9S1BhGj7p+N
 2UD25eZ/klSE+OEXPR+Yl0=
IronPort-HdrOrdr: A9a23:C6daea3ZvYcLe0Q/bcItAQqjBTRyeYIsimQD101hICG9Lfb0qy
 n+pp4mPEHP4wr5AEtQ4uxpOMG7MBDhHO1OkPMs1NaZLUPbUQ6TQL2KgrGSpAEIdxeeygcZ79
 YZT0EcMqy8MbEZt7ed3ODQKb9Jr7e6GeKT9J7jJhxWPGNXgtRbnmNE43GgYyhLrWd9ZaYRJd
 653I5qtjCgcXMYYoCQHX8eRdXOoNXNidbPfQMGLwRP0njAsRqYrJrBVzSI1BYXVD1ChZ0493
 LergD/7qK/99mm1x7n0XPJ5Zg+oqqu9jIDPr3MtiEmEESutu+aXvUiZ1REhkFxnAib0idrrD
 ALmWZlAy080QKXQoj/m2qR5+Cp6kdT15al8y7VvZKrm72HeBsqT8VGno5XaR3f9g4pu8x9yr
 tC2yaDu4NQFg6oplW12zHkbWAcqqOPmwtVrQfTtQ0tbaIOLLtK6YAP9kJcF5kNWCr89YA8Ce
 FrSMXR/uxff1+WZ23Q+jAH+q3mYl0jWhOdBkQSsM2c1DZb2Hh/0ksD3cQa2nMN7og0RZVI7/
 nNdq5oiLZNRMkLar8VPpZIfeKnTmjWBR7cOmObJlrqUKkBJnLWspbypK444em7EaZ4uKfaWK
 6xJW+wmVRCCn4GOPf+rqGjqCq9PllVdQ6duv1j2w==
X-IronPort-AV: E=Sophos;i="5.88,353,1635220800"; 
   d="scan'208";a="63752021"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=BEpl2kgPMAQ5ODMRr/LUGhgY44kS5merkG2ToZNq8VwY2T8k0WzJN3rOgPix1FR5HiUcICbmPPmPwJ/91wHV8tYIcFJXi28BXjc7DSd6dD/3V3mvMAJGx8lpHwC4eh4heVqqa77Jf7FZjG8Gcq7D8j8uHVSgcbW1Wl6xnjeyFjSpHhuppN/sI0obsvqcWJdHRssNeA6Ym3N18Oa/LyIlwYdp9SVZlkFkrCqlHSFyFytwUabRlIUKQlWa8/JvDctb9dhvxDynv2TeE4hsZHiHb5fDYEUiUbGZiP5yG4rHCNcO6y/ycS8XCcnhZBtfl/LY3+/xWvV328WOk7tfOmbWmw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ZhTbDkT/Te2OmrXv6b10gX9Ad9ETCpHTKSAst5QPMU8=;
 b=EyRARxcBi33bKba0amzI8v0S6wE7kDnA3xgwFy3QDv2o0pbx/DCu8Qbn+yV1JpRzol7be76A/ABB6YNNEk22UHcx2xNP3UnQ6z4vv46mjnNrN+L0J8bEo02UYw6/GRVbwRxpSVc78ivA1EGnKMMkTqXuK/RD8v5BzaMptGpwLVAiAWPXreue+WV0YOWdd2Cpu7XqWZgihDc9ffKrafEKpz6ulITua+ADnh/RdzzVXnpCoYon2ytvKXhS+bnsXeQJCQi3eAM4WcwTXAWn90FdgE1W6QWtxaLOSgDMkHWD3y6H2ch7jcX0FBu1Bm6enjLhPOE8wagBtGJjot0tgFv8Vg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ZhTbDkT/Te2OmrXv6b10gX9Ad9ETCpHTKSAst5QPMU8=;
 b=aGE6wXjCW9ZcpVkWJ7nvcJhgICXu4sXGAkXcRw4uvmcTsc35RXFcNCkC/jm4CQYb5u8QnVOqY+kkTGjMCBqhW+got+7obBgfB642TcfV30lBjFSG40kPVo7QzKA+dcpjaVwmtkawDfyjpC4tOsL+JVH/3Y3DYuCkKerH9RlG6PE=
Date: Tue, 8 Feb 2022 17:17:49 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jane Malalane <jane.malalane@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>, Anthony
 PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, Andrew
 Cooper <andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>, Stefano
 Stabellini <sstabellini@kernel.org>, Christian Lindig
	<christian.lindig@citrix.com>, David Scott <dave@recoil.org>, Volodymyr
 Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v2 2/2] x86/xen: Allow per-domain usage of hardware
 virtualized APIC
Message-ID: <YgKXrZ/U2XuECG3d@Air-de-Roger>
References: <20220207182101.31941-1-jane.malalane@citrix.com>
 <20220207182101.31941-3-jane.malalane@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220207182101.31941-3-jane.malalane@citrix.com>
X-ClientProxiedBy: LO4P123CA0252.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1a7::23) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 82236c18-a600-465d-dcbc-08d9eb1e8f0f
X-MS-TrafficTypeDiagnostic: BN6PR03MB2548:EE_
X-Microsoft-Antispam-PRVS: <BN6PR03MB2548EFE3C029FAFDAC3EC71F8F2D9@BN6PR03MB2548.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: RDMiEoQzRTDyMYCzeDFhqJ3atJj2iOYkdB/ebI1NALWFRVd3Fw7VCqBfKbwRMwE2H+7MAwlg9beY9pXV2P2VCVItqeROnyo4jIDCGwZIdQcMWYeyNWukTBDSaKNGixsJpfaT3K5M8bc/x+Qlb48O1ODQA0CVaJcQTfbpobA2z+OkCHFdWFl1rF0dVsUE2QLbmrJ1/We8VqUkZrZYv15jYi2yry5Szv3bGwSctKLNmF7Z9eNaDJTD6Pu16udguFABTVe0FYN8ingH3N1Zmc827wnqILas9AaIfHQ6RqlMh7uQLHP5krtpvr7th1ppbQplRZiwcGZTerbFWanqg8XSM3FMBYZ92lxYyGQOj4fqWIkGbGGCwhxxPelYMQCpvmOOoqH2EUWNirJCNy6hwPrZV+jrxAvb7SVmK1uX6SREMb8J60y3ceaCy2HJBdHKwoYvNAFbcl1hBVAoTG2lgvxvGNu5LH8Lf7CRy3TqvTyd7gqMy8U5mj/GwUp96bNdX0YDKS+08zvdbGK0WwUFR4gSA0SBKY/3f9vbEAFPnZ6N86NqdiDdYr61tcArp5QJ1sKxnNtVh0dy7vy35/D/p+jf+wCkvwIo09lCkOubWEG15p4ryEsWQw6Xt8vYqZxJDyLCoQJa25Rb9MpVTWE4gWgXdA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(508600001)(38100700002)(6486002)(30864003)(85182001)(33716001)(54906003)(82960400001)(8936002)(9686003)(8676002)(5660300002)(316002)(186003)(6862004)(6512007)(26005)(6506007)(2906002)(66476007)(83380400001)(66946007)(86362001)(66556008)(4326008)(6666004)(6636002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d01rd3Fzc21iWXliZm1kY1FZb3c2cjN6ZmdSZEwraFFoM0I2T1cwbXBiMkIz?=
 =?utf-8?B?aU5JcHJ4V096SjB4WFFxeVpwUHJtMk5sVHg0b0Q1TmtRNFdHTUllSWRndHVM?=
 =?utf-8?B?YUx3UTJwREZQMHZoYkxZZ3FrREpvYzFnR1g4SjhaQkRlQTJqQW9qM3loc25P?=
 =?utf-8?B?THVuS2trRkhIR1M4eXJMek52UTd1VjAvNVA2VUdFcFJQMzZYc3h6SncyaHlt?=
 =?utf-8?B?T0xxVjdFY0ZvQks3My9HQzVKNUVUVDFtcmpybUE0WHE4WHRLTGc0QjFNU2xR?=
 =?utf-8?B?Z1RTbTBRZWpzdXdxNk0zR2ZEZHZHNUpETitUUHJNeWxMSzJWa0xmR25raVU1?=
 =?utf-8?B?T3gwbjRyYXp0a2drOSt5QVpxcHpHNkVqUzdaUGJJWU1OLzF4MGRtZTZ5aUxo?=
 =?utf-8?B?NUFacGZtdXBFUE1SajZ3SE9hQzJiUHdHRkdHQStPR0FjZnhBNXI0bE1FYVND?=
 =?utf-8?B?VWMwK2o1T2IyaXJySW9ab3NvLzRlTUIwVXNqeTNDcTZsVWhoWWhieXlvd0Z3?=
 =?utf-8?B?Z2oxQXFqSWRia1R3SUw5WldrbmRNSkcrZ2ZLRW5SL01CWElJRHU5Ym1sNW9Z?=
 =?utf-8?B?WW04M3AwM2ZBbHoydm41anBKY2NGTmNxR0dRdSs3aU5pZVZYMDZTNWVnSVVG?=
 =?utf-8?B?WHQybkpTVjNpRU9HcjR4d0FFdlFlbUxUb0RWb2gzWmt3V1gzUXpFLyt3T0V5?=
 =?utf-8?B?Wnl5THVDRDBaMU1sbHVIcW5ZRTBCdGl3MDhZaUlFQ1RaVHJRNHphTzAxTUg1?=
 =?utf-8?B?UHVPNFgra3c2YVMyL0tqTlNuOXZuT2lrQ2g2RUx4OEhjakp5cER0RE81YmdF?=
 =?utf-8?B?bExQVnpCZzVJMTRiNi9NU2g3Skk2WkE2cVFuakRHbHNjYlo1aFU0ajFESlR5?=
 =?utf-8?B?TlZKcy9TRlhUTzNxeFk0NGZTYlZRK28yZVlJR2tDbWVVZ1Njc3hja3dNbU5H?=
 =?utf-8?B?QWdiemJQaW8yU1QySVpvOWxicElsY1hwU01SRWhnZ0VRODFFczNFQ1R4T0lk?=
 =?utf-8?B?REVjSjgzNjVZaW5vdmU5ek1xS1F1MEQxK25uNW14OTU2TDRvWlNwWDJ5TVVU?=
 =?utf-8?B?Q1ZDZ01vVzBPSlh0eXY4RDhqNU9mQmQyMHpsbGtteE9wOFdHUWd1UTREVzVT?=
 =?utf-8?B?VEp5UTNpMkt4bnB4L01qdFR3UGtPSi9qNG5JSG1BbDMrdWtXUnhpZmdzNXEv?=
 =?utf-8?B?VzlLVFVYSHhNZVY4UmppaFZtNkphVkgyMEZ2Mjl4SEphRVVsZHdoL25qNUdl?=
 =?utf-8?B?Z3VRdjN5OUlSOEpLc2Fzc2d3cVF4NWhGOGR4OG11Y0xMbUpidWpsRDZkalk5?=
 =?utf-8?B?YkVJYmdRcXRpK1gxYUdqclQ0N3ZiWGFtZjhKTFNJMFpTS29ocC80QXlrcVBG?=
 =?utf-8?B?UTFlYmdBWlI5U0hzTVY2N1lscDhPSTk2US95K3drUTZ4MXNaallFWitpQ0pt?=
 =?utf-8?B?akhlQVVTMkQ3VjdKRExCRllIaTBNRVFsWkFDbFRoMjRwSUhZdW40SDdmKzNl?=
 =?utf-8?B?NWtJcFMrUlpNVUdwZEljcFI3UzRtYVdncnZ2Z3NlT1U3UFFMYm5VVXlTVUI0?=
 =?utf-8?B?VnY4dkpBbU5tbWNEVENkLzR0U3NtTENsT0JXalNzSjhWaXNFdVpFMTBDLzY0?=
 =?utf-8?B?TnpSRGRTb3g2R1pDMEFXczN4U05ISk1WazVyQlFKdHUwWWxnR3FaV1I0bjBy?=
 =?utf-8?B?aFlmWEhuT1VRNVFiUEF0Qkp0UjFFUlRPODJxZFovZnNHeXdxdmFLd2gxTXhJ?=
 =?utf-8?B?Y0tLNFlpK0w4dnVpbkJCZHZERk1TblYvKzhnZzIzR3djYTBHZXpTSmduVGNa?=
 =?utf-8?B?UWNWVWN4L1Q4WGNUVnZQVGhPUWFiUmlYajFOOXdUenpMTjZsWTZBN0RpOTUv?=
 =?utf-8?B?UGZxS0lPaURLdlQrSjFkTTNtaUVJTnMwVDZaMFFvbnUwM2JWNlFmUDJPeWMy?=
 =?utf-8?B?Z1lmVzdNQnhJTjdneDJPZkhOM2gvUDdxR01nSE81aEduek1ZdFJ0dUNsN1lY?=
 =?utf-8?B?RHdTUFg0Mm1SNEhVSWtpeVpVS2Q5U2xURHRhalZJZHNXb29GUVgzMS9TOFUz?=
 =?utf-8?B?K1IyVmZNZWVPcWtPSDJjc21SS0JhOHNoRFZpcFVLWlRSODQreFBUaU54R2dJ?=
 =?utf-8?B?SER4Z3JCRjJJanhwTTczZ21VNGMybEZaK2VnM0I1SjdFOFoxTjltZWFtNWpC?=
 =?utf-8?Q?yxNBAvAL9yMt0NMSrUe9yIM=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 82236c18-a600-465d-dcbc-08d9eb1e8f0f
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2022 16:17:53.4956
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sg8xCkPkqce83ksrfqDJLnumFUBiZJLU8p/RqXeYhaRIwmUgpUXHodKXfJJPq5/3HTmuGaSQWvaKRk0uN36Qzw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2548
X-OriginatorOrg: citrix.com

On Mon, Feb 07, 2022 at 06:21:01PM +0000, Jane Malalane wrote:
> Introduce a new per-domain creation x86 specific flag to
> select whether hardware assisted virtualization should be used for
> x{2}APIC.
> 
> A per-domain option is added to xl in order to select the usage of
> x{2}APIC hardware assisted vitualization, as well as a global
> configuration option.
> 
> Having all APIC interaction exit to Xen for emulation is slow and can
> induce much overhead. Hardware can speed up x{2}APIC by running APIC
> read/write accesses without taking a VM exit.
> 
> Being able to disable x{2}APIC hardware assisted vitualization can be
> useful for testing and debugging purposes.

I think you have agreed with Jan some changes to the description
regarding the purpose of the commit.

> 
> Signed-off-by: Jane Malalane <jane.malalane@citrix.com>
> Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
> ---
> CC: Wei Liu <wl@xen.org>
> CC: Anthony PERARD <anthony.perard@citrix.com>
> CC: Juergen Gross <jgross@suse.com>
> CC: Andrew Cooper <andrew.cooper3@citrix.com>
> CC: George Dunlap <george.dunlap@citrix.com>
> CC: Jan Beulich <jbeulich@suse.com>
> CC: Julien Grall <julien@xen.org>
> CC: Stefano Stabellini <sstabellini@kernel.org>
> CC: Christian Lindig <christian.lindig@citrix.com>
> CC: David Scott <dave@recoil.org>
> CC: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
> CC: "Roger Pau Monné" <roger.pau@citrix.com>
> 
> v2:
>  * Add a LIBXL_HAVE_ASSISTED_APIC macro
>  * Pass xcpyshinfo as a pointer in libxl__arch_get_physinfo
>  * Add a return statement in now "int"
>    libxl__arch_domain_build_info_setdefault
>  * Preserve libxl__arch_domain_build_info_setdefault 's location in
>    libxl_create.c
>  * Correct x{2}apic default setting logic in
>    libxl__arch_domain_prepare_config
>  * Correct logic for parsing assisted_x{2}apic host/guest options in
>    xl_parse.c and initialize them to -1 in xl.c
>  * Use guest options directly in vmx_vlapic_msr_changed
>  * Fix indentation of bool assisted_x{2}apic in struct hvm_domain
>  * Add a change in xenctrl_stubs.c to pass xenctrl ABI checks
> ---
>  docs/man/xl.cfg.5.pod.in              | 10 ++++++++++
>  docs/man/xl.conf.5.pod.in             | 12 ++++++++++++
>  tools/golang/xenlight/helpers.gen.go  | 12 ++++++++++++
>  tools/include/libxl.h                 |  7 +++++++
>  tools/libs/light/libxl_arch.h         |  5 +++--
>  tools/libs/light/libxl_arm.c          |  7 +++++--
>  tools/libs/light/libxl_create.c       | 23 ++++++++++++++---------
>  tools/libs/light/libxl_types.idl      |  2 ++
>  tools/libs/light/libxl_x86.c          | 31 +++++++++++++++++++++++++++++--
>  tools/ocaml/libs/xc/xenctrl.ml        |  2 ++
>  tools/ocaml/libs/xc/xenctrl.mli       |  2 ++
>  tools/ocaml/libs/xc/xenctrl_stubs.c   |  2 +-
>  tools/xl/xl.c                         |  8 ++++++++
>  tools/xl/xl.h                         |  2 ++
>  tools/xl/xl_parse.c                   | 16 ++++++++++++++++
>  xen/arch/x86/domain.c                 | 28 +++++++++++++++++++++++++++-
>  xen/arch/x86/hvm/vmx/vmcs.c           |  4 ++++
>  xen/arch/x86/hvm/vmx/vmx.c            | 14 +++++---------
>  xen/arch/x86/include/asm/hvm/domain.h |  6 ++++++
>  xen/arch/x86/traps.c                  |  8 ++++----
>  xen/include/public/arch-x86/xen.h     |  2 ++
>  21 files changed, 173 insertions(+), 30 deletions(-)
> 
> diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in
> index b98d161398..1d98bbd182 100644
> --- a/docs/man/xl.cfg.5.pod.in
> +++ b/docs/man/xl.cfg.5.pod.in
> @@ -1862,6 +1862,16 @@ firmware tables when using certain older guest Operating
>  Systems. These tables have been superseded by newer constructs within
>  the ACPI tables.
>  
> +=item B<assisted_xAPIC=BOOLEAN>
> +B<(x86 only)> Enables or disables hardware assisted virtualization for xapic.
> +This allows accessing APIC registers without a VM-exit.
> +The default is settable via L<xl.conf(5)>.
> +
> +=item B<assisted_x2APIC=BOOLEAN>
> +B<(x86 only)> Enables or disables hardware assisted virtualization for x2apic.
> +This allows accessing APIC registers without a VM-exit.
> +The default is settable via L<xl.conf(5)>.
> +
>  =item B<nx=BOOLEAN>
>  
>  B<(x86 only)> Hides or exposes the No-eXecute capability. This allows a guest
> diff --git a/docs/man/xl.conf.5.pod.in b/docs/man/xl.conf.5.pod.in
> index df20c08137..30993827e5 100644
> --- a/docs/man/xl.conf.5.pod.in
> +++ b/docs/man/xl.conf.5.pod.in
> @@ -107,6 +107,18 @@ Sets the default value for the C<max_grant_version> domain config value.
>  
>  Default: maximum grant version supported by the hypervisor.
>  
> +=item B<assisted_xAPIC=BOOLEAN>
> +
> +If enabled, domains will use xAPIC hardware assisted virtualization by default.
> +
> +Default: enabled if supported.
> +
> +=item B<assisted_x2APIC=BOOLEAN>
> +
> +If enabled, domains will use x2APIC hardware assisted virtualization by default.
> +
> +Default: enabled if supported.

We don't capitalize xl options, so I would suggest to lowercase APIC
for all the option names.

> +
>  =item B<vif.default.script="PATH">
>  
>  Configures the default hotplug script used by virtual network devices.
> diff --git a/tools/golang/xenlight/helpers.gen.go b/tools/golang/xenlight/helpers.gen.go
> index dd4e6c9f14..90e7b9b205 100644
> --- a/tools/golang/xenlight/helpers.gen.go
> +++ b/tools/golang/xenlight/helpers.gen.go
> @@ -636,6 +636,12 @@ x.Passthrough = Passthrough(xc.passthrough)
>  if err := x.XendSuspendEvtchnCompat.fromC(&xc.xend_suspend_evtchn_compat);err != nil {
>  return fmt.Errorf("converting field XendSuspendEvtchnCompat: %v", err)
>  }
> +if err := x.ArchX86.AssistedXapic.fromC(&xc.arch_x86.assisted_xapic);err != nil {
> +return fmt.Errorf("converting field ArchX86.AssistedXapic: %v", err)
> +}
> +if err := x.ArchX86.AssistedX2Apic.fromC(&xc.arch_x86.assisted_x2apic);err != nil {
> +return fmt.Errorf("converting field ArchX86.AssistedX2Apic: %v", err)
> +}
>  
>   return nil}
>  
> @@ -679,6 +685,12 @@ xc.passthrough = C.libxl_passthrough(x.Passthrough)
>  if err := x.XendSuspendEvtchnCompat.toC(&xc.xend_suspend_evtchn_compat); err != nil {
>  return fmt.Errorf("converting field XendSuspendEvtchnCompat: %v", err)
>  }
> +if err := x.ArchX86.AssistedXapic.toC(&xc.arch_x86.assisted_xapic); err != nil {
> +return fmt.Errorf("converting field ArchX86.AssistedXapic: %v", err)
> +}
> +if err := x.ArchX86.AssistedX2Apic.toC(&xc.arch_x86.assisted_x2apic); err != nil {
> +return fmt.Errorf("converting field ArchX86.AssistedX2Apic: %v", err)
> +}
>  
>   return nil
>   }
> diff --git a/tools/include/libxl.h b/tools/include/libxl.h
> index 924e142628..83944c17ae 100644
> --- a/tools/include/libxl.h
> +++ b/tools/include/libxl.h
> @@ -535,6 +535,13 @@
>  #define LIBXL_HAVE_PHYSINFO_ASSISTED_APIC 1
>  
>  /*
> + * LIBXL_HAVE_ASSISTED_APIC indicates that libxl_domain_build_info has
> + * assisted_x{2}apic fields, for enabling hardware assisted virtualization for
> + * x{2}apic per domain.
> + */
> +#define LIBXL_HAVE_ASSISTED_APIC 1
> +
> +/*
>   * libxl ABI compatibility
>   *
>   * The only guarantee which libxl makes regarding ABI compatibility
> diff --git a/tools/libs/light/libxl_arch.h b/tools/libs/light/libxl_arch.h
> index 207ceac6a1..03b89929e6 100644
> --- a/tools/libs/light/libxl_arch.h
> +++ b/tools/libs/light/libxl_arch.h
> @@ -71,8 +71,9 @@ void libxl__arch_domain_create_info_setdefault(libxl__gc *gc,
>                                                 libxl_domain_create_info *c_info);
>  
>  _hidden
> -void libxl__arch_domain_build_info_setdefault(libxl__gc *gc,
> -                                              libxl_domain_build_info *b_info);
> +int libxl__arch_domain_build_info_setdefault(libxl__gc *gc,
> +                                             libxl_domain_build_info *b_info,
> +                                             const libxl_physinfo *physinfo);
>  
>  _hidden
>  int libxl__arch_passthrough_mode_setdefault(libxl__gc *gc,
> diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c
> index 39fdca1b49..ba5b8f433f 100644
> --- a/tools/libs/light/libxl_arm.c
> +++ b/tools/libs/light/libxl_arm.c
> @@ -1384,8 +1384,9 @@ void libxl__arch_domain_create_info_setdefault(libxl__gc *gc,
>      }
>  }
>  
> -void libxl__arch_domain_build_info_setdefault(libxl__gc *gc,
> -                                              libxl_domain_build_info *b_info)
> +int libxl__arch_domain_build_info_setdefault(libxl__gc *gc,
> +                                             libxl_domain_build_info *b_info,
> +                                             const libxl_physinfo *physinfo)
>  {
>      /* ACPI is disabled by default */
>      libxl_defbool_setdefault(&b_info->acpi, false);
> @@ -1399,6 +1400,8 @@ void libxl__arch_domain_build_info_setdefault(libxl__gc *gc,
>      memset(&b_info->u, '\0', sizeof(b_info->u));
>      b_info->type = LIBXL_DOMAIN_TYPE_INVALID;
>      libxl_domain_build_info_init_type(b_info, LIBXL_DOMAIN_TYPE_PVH);
> +
> +    return 0;
>  }
>  
>  int libxl__arch_passthrough_mode_setdefault(libxl__gc *gc,
> diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_create.c
> index d7a40d7550..843e523df9 100644
> --- a/tools/libs/light/libxl_create.c
> +++ b/tools/libs/light/libxl_create.c
> @@ -264,7 +264,20 @@ int libxl__domain_build_info_setdefault(libxl__gc *gc,
>      if (!b_info->event_channels)
>          b_info->event_channels = 1023;
>  
> -    libxl__arch_domain_build_info_setdefault(gc, b_info);
> +    libxl_physinfo info;

The definition of info needs to be at the top of the function,
together with the rest of the variable definitions.

> +
> +    rc = libxl_get_physinfo(CTX, &info);
> +    if (rc) {
> +        LOG(ERROR, "failed to get hypervisor info");
> +        return rc;
> +    }
> +
> +    rc = libxl__arch_domain_build_info_setdefault(gc, b_info, &info);
> +    if (rc) {
> +        LOG(ERROR, "unable to set domain arch build info defaults");
> +        return rc;
> +    }
> +
>      libxl_defbool_setdefault(&b_info->dm_restrict, false);
>  
>      if (b_info->iommu_memkb == LIBXL_MEMKB_DEFAULT)
> @@ -457,14 +470,6 @@ int libxl__domain_build_info_setdefault(libxl__gc *gc,
>      }
>  
>      if (b_info->max_grant_version == LIBXL_MAX_GRANT_DEFAULT) {
> -        libxl_physinfo info;
> -
> -        rc = libxl_get_physinfo(CTX, &info);
> -        if (rc) {
> -            LOG(ERROR, "failed to get hypervisor info");
> -            return rc;
> -        }
> -
>          if (info.cap_gnttab_v2)
>              b_info->max_grant_version = 2;
>          else if (info.cap_gnttab_v1)
> diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl
> index 42ac6c357b..db5eb0a0b3 100644
> --- a/tools/libs/light/libxl_types.idl
> +++ b/tools/libs/light/libxl_types.idl
> @@ -648,6 +648,8 @@ libxl_domain_build_info = Struct("domain_build_info",[
>                                 ("vuart", libxl_vuart_type),
>                                ])),
>      ("arch_x86", Struct(None, [("msr_relaxed", libxl_defbool),
> +                               ("assisted_xapic", libxl_defbool),
> +                               ("assisted_x2apic", libxl_defbool),
>                                ])),
>      # Alternate p2m is not bound to any architecture or guest type, as it is
>      # supported by x86 HVM and ARM support is planned.
> diff --git a/tools/libs/light/libxl_x86.c b/tools/libs/light/libxl_x86.c
> index e0a06ecfe3..f0fa0ceea2 100644
> --- a/tools/libs/light/libxl_x86.c
> +++ b/tools/libs/light/libxl_x86.c
> @@ -23,6 +23,14 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc,
>      if (libxl_defbool_val(d_config->b_info.arch_x86.msr_relaxed))
>          config->arch.misc_flags |= XEN_X86_MSR_RELAXED;
>  
> +    if (d_config->c_info.type != LIBXL_DOMAIN_TYPE_PV)
> +    {

Coding style for libxl is to place the bracket in the same line as the
if.

> +        if (libxl_defbool_val(d_config->b_info.arch_x86.assisted_xapic))
> +            config->arch.misc_flags |= XEN_X86_ASSISTED_XAPIC;
> +
> +        if (libxl_defbool_val(d_config->b_info.arch_x86.assisted_x2apic))
> +            config->arch.misc_flags |= XEN_X86_ASSISTED_X2APIC;
> +    }
>      return 0;
>  }
>  
> @@ -819,11 +827,30 @@ void libxl__arch_domain_create_info_setdefault(libxl__gc *gc,
>  {
>  }
>  
> -void libxl__arch_domain_build_info_setdefault(libxl__gc *gc,
> -                                              libxl_domain_build_info *b_info)
> +int libxl__arch_domain_build_info_setdefault(libxl__gc *gc,
> +                                             libxl_domain_build_info *b_info,
> +                                             const libxl_physinfo *physinfo)
>  {
>      libxl_defbool_setdefault(&b_info->acpi, true);
>      libxl_defbool_setdefault(&b_info->arch_x86.msr_relaxed, false);
> +
> +    if (b_info->type != LIBXL_DOMAIN_TYPE_PV)
> +    {
> +        libxl_defbool_setdefault(&b_info->arch_x86.assisted_xapic,
> +                             physinfo->cap_assisted_xapic);
> +        libxl_defbool_setdefault(&b_info->arch_x86.assisted_x2apic,
> +                             physinfo->cap_assisted_x2apic);
> +    }
> +
> +    if (b_info->type == LIBXL_DOMAIN_TYPE_PV &&
> +        (!libxl_defbool_is_default(b_info->arch_x86.assisted_xapic) ||
> +         !libxl_defbool_is_default(b_info->arch_x86.assisted_x2apic)))

You could just do:

    if (b_info->type != LIBXL_DOMAIN_TYPE_PV) {
        libxl_defbool_setdefault(&b_info->arch_x86.assisted_xapic,
                             physinfo->cap_assisted_xapic);
        libxl_defbool_setdefault(&b_info->arch_x86.assisted_x2apic,
                             physinfo->cap_assisted_x2apic);
    } else if (!libxl_defbool_is_default(b_info->arch_x86.assisted_xapic) ||
               !libxl_defbool_is_default(b_info->arch_x86.assisted_x2apic))
        /* ERROR */

> +    {
> +        LOG(ERROR, "Interrupt Controller Virtualization not supported for PV");
> +        return ERROR_INVAL;
> +    }
> +
> +    return 0;
>  }
>  
>  int libxl__arch_passthrough_mode_setdefault(libxl__gc *gc,
> diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl.ml
> index 7ce832d605..cce30d8731 100644
> --- a/tools/ocaml/libs/xc/xenctrl.ml
> +++ b/tools/ocaml/libs/xc/xenctrl.ml
> @@ -50,6 +50,8 @@ type x86_arch_emulation_flags =
>  
>  type x86_arch_misc_flags =
>  	| X86_MSR_RELAXED
> +	| X86_ASSISTED_XAPIC
> +	| X86_ASSISTED_X2APIC
>  
>  type xen_x86_arch_domainconfig =
>  {
> diff --git a/tools/ocaml/libs/xc/xenctrl.mli b/tools/ocaml/libs/xc/xenctrl.mli
> index a2b15130ee..67a22ec15c 100644
> --- a/tools/ocaml/libs/xc/xenctrl.mli
> +++ b/tools/ocaml/libs/xc/xenctrl.mli
> @@ -44,6 +44,8 @@ type x86_arch_emulation_flags =
>  
>  type x86_arch_misc_flags =
>    | X86_MSR_RELAXED
> +  | X86_ASSISTED_XAPIC
> +  | X86_ASSISTED_X2APIC
>  
>  type xen_x86_arch_domainconfig = {
>    emulation_flags: x86_arch_emulation_flags list;
> diff --git a/tools/ocaml/libs/xc/xenctrl_stubs.c b/tools/ocaml/libs/xc/xenctrl_stubs.c
> index 5b4fe72c8d..0aa957d379 100644
> --- a/tools/ocaml/libs/xc/xenctrl_stubs.c
> +++ b/tools/ocaml/libs/xc/xenctrl_stubs.c
> @@ -239,7 +239,7 @@ CAMLprim value stub_xc_domain_create(value xch, value wanted_domid, value config
>  
>  		cfg.arch.misc_flags = ocaml_list_to_c_bitmap
>  			/* ! x86_arch_misc_flags X86_ none */
> -			/* ! XEN_X86_ XEN_X86_MSR_RELAXED all */
> +			/* ! XEN_X86_ XEN_X86_ASSISTED_X2APIC max */

We would usually define an XEN_X86_MISC_MAX that would point to
XEN_X86_ASSISTED_X2APIC currently.

>  			(VAL_MISC_FLAGS);
>  
>  #undef VAL_MISC_FLAGS
> diff --git a/tools/xl/xl.c b/tools/xl/xl.c
> index 2d1ec18ea3..31eb223309 100644
> --- a/tools/xl/xl.c
> +++ b/tools/xl/xl.c
> @@ -57,6 +57,8 @@ int max_grant_frames = -1;
>  int max_maptrack_frames = -1;
>  int max_grant_version = LIBXL_MAX_GRANT_DEFAULT;
>  libxl_domid domid_policy = INVALID_DOMID;
> +int assisted_xapic = -1;
> +int assisted_x2apic = -1;
>  
>  xentoollog_level minmsglevel = minmsglevel_default;
>  
> @@ -201,6 +203,12 @@ static void parse_global_config(const char *configfile,
>      if (!xlu_cfg_get_long (config, "claim_mode", &l, 0))
>          claim_mode = l;
>  
> +    if (!xlu_cfg_get_long (config, "assisted_xapic", &l, 0))
> +        assisted_xapic = l;
> +
> +    if (!xlu_cfg_get_long (config, "assisted_x2apic", &l, 0))
> +        assisted_x2apic = l;
> +
>      xlu_cfg_replace_string (config, "remus.default.netbufscript",
>          &default_remus_netbufscript, 0);
>      xlu_cfg_replace_string (config, "colo.default.proxyscript",
> diff --git a/tools/xl/xl.h b/tools/xl/xl.h
> index c5c4bedbdd..528deb3feb 100644
> --- a/tools/xl/xl.h
> +++ b/tools/xl/xl.h
> @@ -286,6 +286,8 @@ extern libxl_bitmap global_vm_affinity_mask;
>  extern libxl_bitmap global_hvm_affinity_mask;
>  extern libxl_bitmap global_pv_affinity_mask;
>  extern libxl_domid domid_policy;
> +extern int assisted_xapic;
> +extern int assisted_x2apic;
>  
>  enum output_format {
>      OUTPUT_FORMAT_JSON,
> diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c
> index 117fcdcb2b..0ab9b145fe 100644
> --- a/tools/xl/xl_parse.c
> +++ b/tools/xl/xl_parse.c
> @@ -1681,6 +1681,22 @@ void parse_config_data(const char *config_source,
>          xlu_cfg_get_defbool(config, "vpt_align", &b_info->u.hvm.vpt_align, 0);
>          xlu_cfg_get_defbool(config, "apic", &b_info->apic, 0);
>  
> +        e = xlu_cfg_get_long(config, "assisted_xapic", &l , 0);
> +        if ((e == ESRCH && assisted_xapic != -1)) /* use global default if present */
               ^ no need for the extra parentheses here and below.

> +            libxl_defbool_set(&b_info->arch_x86.assisted_xapic, assisted_xapic);
> +        else if (!e)
> +            libxl_defbool_set(&b_info->arch_x86.assisted_xapic, l);
> +        else
> +            exit(1);
> +
> +        e = xlu_cfg_get_long(config, "assisted_x2apic", &l, 0);
> +        if ((e == ESRCH && assisted_x2apic != -1)) /* use global default if present */
> +            libxl_defbool_set(&b_info->arch_x86.assisted_x2apic, assisted_x2apic);
> +        else if (!e)
> +            libxl_defbool_set(&b_info->arch_x86.assisted_x2apic, l);
> +        else
> +            exit(1);
> +
>          switch (xlu_cfg_get_list(config, "viridian",
>                                   &viridian, &num_viridian, 1))
>          {
> diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c
> index ef1812dc14..9033a0e181 100644
> --- a/xen/arch/x86/domain.c
> +++ b/xen/arch/x86/domain.c
> @@ -619,6 +619,8 @@ int arch_sanitise_domain_config(struct xen_domctl_createdomain *config)
>      bool hvm = config->flags & XEN_DOMCTL_CDF_hvm;
>      bool hap = config->flags & XEN_DOMCTL_CDF_hap;
>      bool nested_virt = config->flags & XEN_DOMCTL_CDF_nested_virt;
> +    bool assisted_xapic = config->arch.misc_flags & XEN_X86_ASSISTED_XAPIC;
> +    bool assisted_x2apic = config->arch.misc_flags & XEN_X86_ASSISTED_X2APIC;
>      unsigned int max_vcpus;
>  
>      if ( hvm ? !hvm_enabled : !IS_ENABLED(CONFIG_PV) )
> @@ -685,13 +687,31 @@ int arch_sanitise_domain_config(struct xen_domctl_createdomain *config)
>          }
>      }
>  
> -    if ( config->arch.misc_flags & ~XEN_X86_MSR_RELAXED )
> +    if ( config->arch.misc_flags & ~(XEN_X86_MSR_RELAXED |
> +                                     XEN_X86_ASSISTED_XAPIC |
> +                                     XEN_X86_ASSISTED_X2APIC) )
>      {
>          dprintk(XENLOG_INFO, "Invalid arch misc flags %#x\n",
>                  config->arch.misc_flags);
>          return -EINVAL;
>      }
>  
> +    if ( (assisted_xapic || assisted_x2apic) && !hvm )
> +    {
> +        dprintk(XENLOG_INFO,
> +                "Interrupt Controller Virtualization not supported for PV\n");
> +        return -EINVAL;
> +    }
> +
> +    if ( (assisted_xapic && !assisted_xapic_available) ||
> +         (assisted_x2apic && !assisted_x2apic_available) )
> +    {
> +        dprintk(XENLOG_INFO,
> +                "Hardware assisted x%sAPIC requested but not available\n",
> +                assisted_xapic && !assisted_xapic_available ? "" : "2");
> +        return -EINVAL;
> +    }
> +
>      return 0;
>  }
>  
> @@ -863,6 +883,12 @@ int arch_domain_create(struct domain *d,
>  
>      d->arch.msr_relaxed = config->arch.misc_flags & XEN_X86_MSR_RELAXED;
>  
> +    d->arch.hvm.assisted_xapic =
> +        config->arch.misc_flags & XEN_X86_ASSISTED_XAPIC;
> +
> +    d->arch.hvm.assisted_x2apic =
> +        config->arch.misc_flags & XEN_X86_ASSISTED_X2APIC;
> +
>      return 0;
>  
>   fail:
> diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c
> index 4060aef1bd..614db5c4a4 100644
> --- a/xen/arch/x86/hvm/vmx/vmcs.c
> +++ b/xen/arch/x86/hvm/vmx/vmcs.c
> @@ -1157,6 +1157,10 @@ static int construct_vmcs(struct vcpu *v)
>          __vmwrite(PLE_WINDOW, ple_window);
>      }
>  
> +    if ( !v->domain->arch.hvm.assisted_xapic )
> +        v->arch.hvm.vmx.secondary_exec_control &=
> +            ~SECONDARY_EXEC_VIRTUALIZE_APIC_ACCESSES;
> +
>      if ( cpu_has_vmx_secondary_exec_control )
>          __vmwrite(SECONDARY_VM_EXEC_CONTROL,
>                    v->arch.hvm.vmx.secondary_exec_control);
> diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c
> index 36c8a12cfe..3c9ff60154 100644
> --- a/xen/arch/x86/hvm/vmx/vmx.c
> +++ b/xen/arch/x86/hvm/vmx/vmx.c
> @@ -3333,16 +3333,11 @@ static void vmx_install_vlapic_mapping(struct vcpu *v)
>  
>  void vmx_vlapic_msr_changed(struct vcpu *v)
>  {
> -    int virtualize_x2apic_mode;
>      struct vlapic *vlapic = vcpu_vlapic(v);
>      unsigned int msr;
>  
> -    virtualize_x2apic_mode = ( (cpu_has_vmx_apic_reg_virt ||
> -                                cpu_has_vmx_virtual_intr_delivery) &&
> -                               cpu_has_vmx_virtualize_x2apic_mode );
> -
> -    if ( !cpu_has_vmx_virtualize_apic_accesses &&
> -         !virtualize_x2apic_mode )
> +    if ( ! v->domain->arch.hvm.assisted_xapic &&
> +         ! v->domain->arch.hvm.assisted_x2apic )
             ^ extra space.
>          return;
>  
>      vmx_vmcs_enter(v);
> @@ -3352,7 +3347,8 @@ void vmx_vlapic_msr_changed(struct vcpu *v)
>      if ( !vlapic_hw_disabled(vlapic) &&
>           (vlapic_base_address(vlapic) == APIC_DEFAULT_PHYS_BASE) )
>      {
> -        if ( virtualize_x2apic_mode && vlapic_x2apic_mode(vlapic) )
> +        if ( v->domain->arch.hvm.assisted_x2apic
> +             && vlapic_x2apic_mode(vlapic) )
>          {
>              v->arch.hvm.vmx.secondary_exec_control |=
>                  SECONDARY_EXEC_VIRTUALIZE_X2APIC_MODE;
> @@ -3373,7 +3369,7 @@ void vmx_vlapic_msr_changed(struct vcpu *v)
>                  vmx_clear_msr_intercept(v, MSR_X2APIC_SELF, VMX_MSR_W);
>              }
>          }
> -        else
> +        else if ( v->domain->arch.hvm.assisted_xapic )
>              v->arch.hvm.vmx.secondary_exec_control |=
>                  SECONDARY_EXEC_VIRTUALIZE_APIC_ACCESSES;
>      }
> diff --git a/xen/arch/x86/include/asm/hvm/domain.h b/xen/arch/x86/include/asm/hvm/domain.h
> index 698455444e..92bf53483c 100644
> --- a/xen/arch/x86/include/asm/hvm/domain.h
> +++ b/xen/arch/x86/include/asm/hvm/domain.h
> @@ -117,6 +117,12 @@ struct hvm_domain {
>  
>      bool                   is_s3_suspended;
>  
> +    /* xAPIC hardware assisted virtualization. */
> +    bool                   assisted_xapic;
> +
> +    /* x2APIC hardware assisted virtualization. */
> +    bool                   assisted_x2apic;
> +
>      /* hypervisor intercepted msix table */
>      struct list_head       msixtbl_list;
>  
> diff --git a/xen/arch/x86/traps.c b/xen/arch/x86/traps.c
> index 485bd66971..33694acc99 100644
> --- a/xen/arch/x86/traps.c
> +++ b/xen/arch/x86/traps.c
> @@ -1115,7 +1115,8 @@ void cpuid_hypervisor_leaves(const struct vcpu *v, uint32_t leaf,
>          if ( !is_hvm_domain(d) || subleaf != 0 )
>              break;
>  
> -        if ( cpu_has_vmx_apic_reg_virt )
> +        if ( cpu_has_vmx_apic_reg_virt &&

You can drop the cpu_has_vmx_apic_reg_virt check here, if
cpu_has_vmx_apic_reg_virt is false assisted_xapic won't be set to true.

> +             v->domain->arch.hvm.assisted_xapic )
>              res->a |= XEN_HVM_CPUID_APIC_ACCESS_VIRT;
>  
>          /*
> @@ -1124,9 +1125,8 @@ void cpuid_hypervisor_leaves(const struct vcpu *v, uint32_t leaf,
>           * and wrmsr in the guest will run without VMEXITs (see
>           * vmx_vlapic_msr_changed()).
>           */
> -        if ( cpu_has_vmx_virtualize_x2apic_mode &&
> -             cpu_has_vmx_apic_reg_virt &&
> -             cpu_has_vmx_virtual_intr_delivery )
> +        if ( (cpu_has_vmx_apic_reg_virt && cpu_has_vmx_virtual_intr_delivery) &&
                ^ unneeded parentheses

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 16:55:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 16:55:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268477.462320 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHTmI-0007pQ-P9; Tue, 08 Feb 2022 16:55:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268477.462320; Tue, 08 Feb 2022 16:55:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHTmI-0007pJ-Lz; Tue, 08 Feb 2022 16:55:42 +0000
Received: by outflank-mailman (input) for mailman id 268477;
 Tue, 08 Feb 2022 16:55:41 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nHTmH-0007p9-CK; Tue, 08 Feb 2022 16:55:41 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nHTmH-0004Qh-9t; Tue, 08 Feb 2022 16:55:41 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nHTmG-0000Py-Hp; Tue, 08 Feb 2022 16:55:40 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nHTmG-0004KP-Gs; Tue, 08 Feb 2022 16:55:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=03aTtr5duXBxogV7xJi1QXP8HCCDJc9/DGl4NY6ijCg=; b=OdRoRXAeZZChSQhN3lg2wvwohz
	Zt39DSvqdR4mLATJUqWx0jLyK3WDFefxdOUMQ/tSLzZJ2ZbO3TBf/Ymx+fHMPLbt3mliX6i5pbA1j
	XqKpsQpzBUgZCkQ6EtyUehzJab4pBhJ8pRYi6+LcLAPFxXAVjo9IqKDeDUq1b66p/HPA=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168055-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 168055: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=10d33220f2363a21a52a394159118ab4ddaed50e
X-Osstest-Versions-That:
    xen=820cc393434097f3b7976acdccbf1d96071d6d23
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 08 Feb 2022 16:55:40 +0000

flight 168055 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168055/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168037
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168037
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168037
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168037
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168037
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168037
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168037
 test-armhf-armhf-xl-rtds     18 guest-start/debian.repeat    fail  like 168037
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168037
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168037
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168037
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168037
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168037
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 xen                  10d33220f2363a21a52a394159118ab4ddaed50e
baseline version:
 xen                  820cc393434097f3b7976acdccbf1d96071d6d23

Last test of basis   168037  2022-02-07 01:51:51 Z    1 days
Testing same since   168051  2022-02-07 22:08:25 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Roger Pau Monne <roger.pau@citrix.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   820cc39343..10d33220f2  10d33220f2363a21a52a394159118ab4ddaed50e -> master


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 18:00:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 18:00:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268493.462354 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHUmr-0006e9-3z; Tue, 08 Feb 2022 18:00:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268493.462354; Tue, 08 Feb 2022 18:00:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHUmr-0006e0-0W; Tue, 08 Feb 2022 18:00:21 +0000
Received: by outflank-mailman (input) for mailman id 268493;
 Tue, 08 Feb 2022 18:00:19 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TsJg=SX=epam.com=prvs=40387f30b1=oleksii_moisieiev@srs-se1.protection.inumbo.net>)
 id 1nHUmp-00068L-6w
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 18:00:19 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f8c5c876-8908-11ec-8eb8-a37418f5ba1a;
 Tue, 08 Feb 2022 19:00:17 +0100 (CET)
Received: from pps.filterd (m0174678.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 218EgrT5015757;
 Tue, 8 Feb 2022 18:00:14 GMT
Received: from eur02-he1-obe.outbound.protection.outlook.com
 (mail-he1eur02lp2057.outbound.protection.outlook.com [104.47.5.57])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e3t5xrs6q-4
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Tue, 08 Feb 2022 18:00:14 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com (2603:10a6:102:ea::23)
 by VE1PR03MB5613.eurprd03.prod.outlook.com (2603:10a6:803:12a::29)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Tue, 8 Feb
 2022 18:00:08 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::c1c:f98:9dd:86e0]) by PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::c1c:f98:9dd:86e0%6]) with mapi id 15.20.4951.019; Tue, 8 Feb 2022
 18:00:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f8c5c876-8908-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=hJatYUoZ25ZGt2oDLyOR456gPcza8CxVxTUEUiLehTYZbReiV+7+miEDeDULVwEZOAhCkxspH4VHkkyofEon3fFNxoz/JQ+CSM/ltwK7pyFw0XIDv4sX5i+jPZSLPbBFaEfOOZH8MM6cLqm7JS+q8cJT1+a/ZcrhJOYsCmn6V0AmO5cfRrpf0HDDmLcfiGM8oONcmSePFjOd7iA1qLejHjl/CYHEtQ1rj1gcW+XqQM/Uym97m3RMew8wQ7uLoX8e41FtZH157VKtBX+zQStgIQe/yIrgIPfJEjMWGFwyJmH6/uE0u3dItdyuooa1HJ2SQDDt4vaJqQp4b0Mm7heIPQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=GBlPOd7AiAkwGUmUKcL/QkLE6uduuCKGhZ0NfYwPn7M=;
 b=LoKqjkgnR+M19b2SLCE6GoUtfurG989VOjPipe0G4qYNEGAp1D7f+F0OqZnSRVrtBGDHdnmxyzBdrOAzuNr3zLPZyBYDCfmBCqbGMQsddQKZvU5ccfXbbKvfeXSBE+gMmfV6HPVB7OdTCN3DRXmij27QTE01HqTZiWwYnZl6inLSNOAqxL5yx3/1pHHK5sK77brWPX8r28GME9A+QhQxCHX76VhvpcQ1U9VPc3uduczaWLvVD41razb7MMuBH+iNei//h/M/NRW3qegTB3QxqCSONoVuJ3P34CaF9TqVZD5N4gTER+TQB+aDQ7CFy0xwxJOQp0NanwvxQPb5Oufzhg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=GBlPOd7AiAkwGUmUKcL/QkLE6uduuCKGhZ0NfYwPn7M=;
 b=fqDyvnbU2oGQp07LJhzRLyhP8xpdrYoQ3GYBsASMp2ND34jB7f789eSbt68CP6WNWKujVCF6KaNzD/Enl1jCEBpEoxLdZal96rpK5z8ak02wb1HgyTLWeYTtPKhgUJRhKO5nVziaXyCv6Wxq7NCUXDhah7qQrZIs1ylA6rM+dIrwuGi7hy/EdcnE92xuJsuiZXQb7BerK+j13PbUPaYi3h3yKaywLIUkBI+BTd2dR710ICfnJTs0ryqniJrVjUltlEzs2T5v2Lun4SdcZVRBS5PaiRgx8xHX0KQitAi9KRHNd4zb4Tl6m4vbvTAJ2y4SecZRts99IU8W2S6jf+xYng==
From: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>,
        Stefano Stabellini
	<sstabellini@kernel.org>,
        Julien Grall <julien@xen.org>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>
Subject: [RFC v2 3/8] xen/arm: Export host device-tree to hypfs
Thread-Topic: [RFC v2 3/8] xen/arm: Export host device-tree to hypfs
Thread-Index: AQHYHRW1S717SraA0Ui+K6wc2/TNAA==
Date: Tue, 8 Feb 2022 18:00:08 +0000
Message-ID: 
 <e440e4f16a506ecc87078635dbb3fda2ebd45346.1644341635.git.oleksii_moisieiev@epam.com>
References: <cover.1644341635.git.oleksii_moisieiev@epam.com>
In-Reply-To: <cover.1644341635.git.oleksii_moisieiev@epam.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 7fd82e46-c221-4ff7-f460-08d9eb2cd813
x-ms-traffictypediagnostic: VE1PR03MB5613:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <VE1PR03MB561364C1CB63478224FBE92CE32D9@VE1PR03MB5613.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:7691;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 eA0bzCYb7I/TEDiUeMjBIZ9YbX9Gnvap787CBuvVmndKbQC9Jyvjxhig/DUtnLgqoLSEzU0nApyueZUHwfI6UcfVLG3O6AA+g+qGVTg/H+idT0AhoQ6grg0f17Jp3iSS8ACcKnCDJyhrP3fozmJ7EAuxwgR//O9YG+NP1PFNlqQy0asIZYovdA8cEL+5vlszoDQhsXPXXEMqImZ9FB2vVp/4UMshkjNtYQ0vrr7hdN6G03FKCydow88FeptxJbNVLMiKT6JKUeh0tHrWIqSgPKiDktIcbGBD0qLyIYCZXFsM34zHVtvgp0aWK+NdsPEOi5iM9CGmf0XnspS341usE0u5J/Vl+v5qE+3eRh0pvkAa8bHOSAaB+A0ehQrboIRNJoLxOJLChd/t2e7+bxGJYLy/j6CWpQbWLFdhgXwnHUxgeWfEY7fNLe7An9+Xjv30svx8KYMTSFYmgvG9965h9ZIlgybZokx4pEEK4WaCYN0vFnz63XnceZ961H4V78SfnI3LaukL1gQsqjSO+RALABTgUnRjU4Suwv6UMEiz7muQG6J6lB1WK2UUMK8kSQs/cvPgtpqzmfOXd8v8lZWJYnm5gnB6fSQ4WqJYGPoT7CBQs9EkPi7dhowime74eXEyrrcCjjJEnqXioFdROtQa8Ii1G8DvIAF0BbuXSf+g3eNqt5j4Dy4nxpyfPhULh1H3+buGE6PPSwy9iK6PcVVpgkvYln78Gyx/UpbSEo/CSPc=
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR03MB7136.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38070700005)(71200400001)(6486002)(508600001)(66476007)(64756008)(86362001)(66556008)(316002)(122000001)(6916009)(6506007)(2616005)(5660300002)(6512007)(4326008)(83380400001)(54906003)(2906002)(26005)(186003)(8676002)(76116006)(38100700002)(66446008)(66946007)(8936002)(36756003)(91956017)(2004002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?iso-8859-1?Q?MGivsezwHpKlmbUPj+y2rFPN/epMygpIkmEZrDULehdMMH4VSwnZ4UABmx?=
 =?iso-8859-1?Q?B2IHFOGuCkTS4iuBv3yI1QJySnn+PHFJYKlKrClXeMwxSNRl1wOMvmL1/j?=
 =?iso-8859-1?Q?ogUYDk4mZYVQCcs8VeSjo2cB5VZNfjz4YhyDL0ldvn4NNrlUCLHx1ESF5u?=
 =?iso-8859-1?Q?BPDqQw91+qCy5+toRV2Q0/inPJWpPNJuugSyYQa6U/aEMlZS0lFJ64MJMp?=
 =?iso-8859-1?Q?DUBLR1VLYrCaT5mM8mnz1RYMKhci9TYHkcn7+nDGNLi1IbOo2K/AO20zvc?=
 =?iso-8859-1?Q?jADwbz51mtkh/k96TaJGoj2522tcGEcH941IEimuGlLZuehljgQ1OssHdc?=
 =?iso-8859-1?Q?BG3/mORWjVUKF7QXmhRA5th8UddVZH4CjEI/tW8+pcqlfzPZviwxv7HzKS?=
 =?iso-8859-1?Q?pVJ8AK6quBCRRH6xkcy91AKBiNf45sJcd5xp+JKTc2dw3xfpOFCYahFuqw?=
 =?iso-8859-1?Q?hKFgPtft4rKzhiJ/XmSHZgthnZWpNAw6Hz3/pW2Le6rXLaZprkt/eTsCLP?=
 =?iso-8859-1?Q?OFk7xB8ZLZyBkTl/lLLVOVdM1PaxNRxrYtX8mlOH8IkTngdhjWelzpqw/H?=
 =?iso-8859-1?Q?3zDHSht1tAVoevUVvj3BTpwj3pkIKTr0mzK2uOj2BtCrkQ6dYeUDBeCTff?=
 =?iso-8859-1?Q?QQvbp8GrM0FqCIY4IXbo8RfhB0RCq+ZJdivuKVRL5W81AqEXhkycZZVOdc?=
 =?iso-8859-1?Q?fDCW4HkexBFfDOtG55owKsZk/Xs5VrCFxgTaZu7lH4cmDpf09npiCUNtyS?=
 =?iso-8859-1?Q?8kGQX3rsXlEOHh60TG4F5Fl+nfwEvDKKQCRmwMmRoLkuS0H+Oo6af92WEq?=
 =?iso-8859-1?Q?Y34MITOET8U6k4h+wSjnUR+xirhoqwpnpX1FWwC9BeLtqAr7fkASlyOYnj?=
 =?iso-8859-1?Q?rCyns5hHmfiIvOIHvb297yez/VWhDSiV/qnONy+N+1Q2rgRZTdsD4HVUcU?=
 =?iso-8859-1?Q?X/9TzSQFR5zhFNW+MY7f1uKYqbmR12PHxJgSRA2zCBTrEUF54TteWU2/Z5?=
 =?iso-8859-1?Q?5gQB3nPX4RkQ45Crpiu2vyUE09v6t1fOF9Z5ct7FJsJpYuAsQHJlzYTA3Q?=
 =?iso-8859-1?Q?zVqvRtNFIgw7q4vhYMocwVwENKPwNoN0/Mkih2jsulWmieIfAhujwPzJFZ?=
 =?iso-8859-1?Q?dsWyocAcjp26OsJvRMJh0QFbox3xhtrn6RTPxTeggTg7EmAcePXUDI382T?=
 =?iso-8859-1?Q?Mlu8JeG+f6HGE9phQGYJvxBE0EbDpEMWMZ0j7bOIpBfveIUDxQyvsi6J9A?=
 =?iso-8859-1?Q?QmJ4UsFI5L+MfqWpt/jQ0jHvUT3zKqqPFd3NA+gO0RSkHUV01OK5WRayve?=
 =?iso-8859-1?Q?/t324Br0x2ot82AEsUiFskkKAtM2wRJ1c+N1yjpF+E9OTcT7qcML+EzXdE?=
 =?iso-8859-1?Q?HaeJ+wIJxOyF7w6yAX+BwvNEtXOMDCSG+OQGyRBkTfIv39w3m2MgGJQjkd?=
 =?iso-8859-1?Q?zGdyxiAjGGambWEEgtVXl4I7ednBhwD1fGA+MfhtOVfA9kw7108S0nGAUx?=
 =?iso-8859-1?Q?b2zyv1ublqpYrXGUqbnHIVur6uqgFhrfQCiddkrwohphfH4TloA5ey2t1S?=
 =?iso-8859-1?Q?z8O1brDtaLmQe1Lw0xEwuNMgw/5KHr21ZeVYd0KFknm43ROfnHVKDyevCn?=
 =?iso-8859-1?Q?1cyI1yeTJwc+b5VrYUQzeQ7yYirSNF9zZZTdxm2q6/ZiaBogqNtMmOYyY5?=
 =?iso-8859-1?Q?Vruy8MaFcp9Pjh3eq9NaCzcMBapmXlmY1ctRZz5YrYkTThWbVfhJqdFZWv?=
 =?iso-8859-1?Q?shNxhqUd/CRGwp2nHVTK+eBvE=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR03MB7136.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7fd82e46-c221-4ff7-f460-08d9eb2cd813
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2022 18:00:08.4817
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: nR6P7OcxH3Ms+uUSS9wpHiky5/5XPGfj7C+riLQE1Xt0LxMxgbb8RIFIeFrUU4cNJTLV+4s7ng27vBTm3TvAfJiRfuf+dpNRGjgIea+dxTo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR03MB5613
X-Proofpoint-GUID: 9x9RmyYBt--bIgC7LHnu8maOWqKwhB8o
X-Proofpoint-ORIG-GUID: 9x9RmyYBt--bIgC7LHnu8maOWqKwhB8o
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-08_06,2022-02-07_02,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 spamscore=0
 priorityscore=1501 clxscore=1015 impostorscore=0 adultscore=0
 suspectscore=0 malwarescore=0 phishscore=0 lowpriorityscore=0
 mlxlogscore=999 bulkscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2201110000 definitions=main-2202080106

If enabled, host device-tree will be exported to hypfs and can be
accessed through /devicetree path.
Exported device-tree has the same format, as the device-tree
exported to the sysfs by the Linux kernel.
This is useful when XEN toolstack needs an access to the host device-tree.

Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@epam.com>
---
 xen/arch/arm/Kconfig           |   8 +
 xen/arch/arm/Makefile          |   1 +
 xen/arch/arm/host_dtb_export.c | 307 +++++++++++++++++++++++++++++++++
 3 files changed, 316 insertions(+)
 create mode 100644 xen/arch/arm/host_dtb_export.c

diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
index ecfa6822e4..895016b21e 100644
--- a/xen/arch/arm/Kconfig
+++ b/xen/arch/arm/Kconfig
@@ -33,6 +33,14 @@ config ACPI
 	  Advanced Configuration and Power Interface (ACPI) support for Xen is
 	  an alternative to device tree on ARM64.
=20
+config HOST_DTB_EXPORT
+	bool "Export host device tree to hypfs if enabled"
+	depends on ARM && HYPFS && !ACPI
+	---help---
+
+	  Export host device-tree to hypfs so toolstack can have an access for th=
e
+	  host device tree from Dom0. If you unsure say N.
+
 config GICV3
 	bool "GICv3 driver"
 	depends on ARM_64 && !NEW_VGIC
diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile
index 07f634508e..0a41f68f8c 100644
--- a/xen/arch/arm/Makefile
+++ b/xen/arch/arm/Makefile
@@ -8,6 +8,7 @@ obj-y +=3D platforms/
 endif
 obj-$(CONFIG_TEE) +=3D tee/
 obj-$(CONFIG_HAS_VPCI) +=3D vpci.o
+obj-$(CONFIG_HOST_DTB_EXPORT) +=3D host_dtb_export.o
=20
 obj-$(CONFIG_HAS_ALTERNATIVE) +=3D alternative.o
 obj-y +=3D bootfdt.init.o
diff --git a/xen/arch/arm/host_dtb_export.c b/xen/arch/arm/host_dtb_export.=
c
new file mode 100644
index 0000000000..794395683c
--- /dev/null
+++ b/xen/arch/arm/host_dtb_export.c
@@ -0,0 +1,307 @@
+/*
+ * xen/arch/arm/host_dtb_export.c
+ *
+ * Export host device-tree to the hypfs so toolstack can access
+ * host device-tree from Dom0
+ *
+ * Oleksii Moisieiev <oleksii_moisieiev@epam.com>
+ * Copyright (C) 2021, EPAM Systems.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#include <xen/device_tree.h>
+#include <xen/err.h>
+#include <xen/guest_access.h>
+#include <xen/hypfs.h>
+#include <xen/init.h>
+
+#define HOST_DT_DIR "devicetree"
+
+static int host_dt_dir_read(const struct hypfs_entry *entry,
+                            XEN_GUEST_HANDLE_PARAM(void) uaddr);
+static unsigned int host_dt_dir_getsize(const struct hypfs_entry *entry);
+
+static const struct hypfs_entry *host_dt_dir_enter(
+    const struct hypfs_entry *entry);
+static void host_dt_dir_exit(const struct hypfs_entry *entry);
+
+static struct hypfs_entry *host_dt_dir_findentry(
+    const struct hypfs_entry_dir *dir, const char *name, unsigned int name=
_len);
+
+static const struct hypfs_funcs host_dt_dir_funcs =3D {
+    .enter =3D host_dt_dir_enter,
+    .exit =3D host_dt_dir_exit,
+    .read =3D host_dt_dir_read,
+    .write =3D hypfs_write_deny,
+    .getsize =3D host_dt_dir_getsize,
+    .findentry =3D host_dt_dir_findentry,
+};
+
+static int host_dt_prop_read(const struct hypfs_entry *entry,
+                    XEN_GUEST_HANDLE_PARAM(void) uaddr);
+
+static unsigned int host_dt_prop_getsize(const struct hypfs_entry *entry);
+
+const struct hypfs_funcs host_dt_prop_ro_funcs =3D {
+    .enter =3D host_dt_dir_enter,
+    .exit =3D host_dt_dir_exit,
+    .read =3D host_dt_prop_read,
+    .write =3D hypfs_write_deny,
+    .getsize =3D host_dt_prop_getsize,
+    .findentry =3D hypfs_leaf_findentry,
+};
+
+static HYPFS_DIR_INIT_FUNC(dt_dir, "node_template", &host_dt_dir_funcs);
+
+#define HYPFS_PROPERTY_MAX_SIZE 256
+static HYPFS_VARSIZE_INIT(dt_prop, XEN_HYPFS_TYPE_BLOB, "prop_template",
+                            HYPFS_PROPERTY_MAX_SIZE, &host_dt_prop_ro_func=
s);
+
+static const char *get_name_from_path(const char *path)
+{
+    const char *name =3D strrchr(path, '/');
+    if ( !name )
+        name =3D path;
+    else
+    {
+        name++;
+        if ( !*name )
+            name--;
+    }
+
+    return name;
+}
+
+static char *get_root_from_path(const char *path, char *name)
+{
+    const char *nm =3D strchr(path, '/');
+    if ( !nm )
+        nm =3D path + strlen(path);
+    else
+    {
+        if ( !*nm )
+            nm--;
+    }
+
+    return memcpy(name, path, nm - path);
+}
+
+static int host_dt_dir_read(const struct hypfs_entry *entry,
+                            XEN_GUEST_HANDLE_PARAM(void) uaddr)
+{
+    int ret =3D 0;
+    struct dt_device_node *node;
+    struct dt_device_node *child;
+    const struct dt_property *prop;
+    struct hypfs_dyndir_id *data;
+
+    data =3D hypfs_get_dyndata();
+    if ( !data )
+        return -EINVAL;
+
+    node =3D data->data;
+    if ( !node )
+        return -EINVAL;
+
+    dt_for_each_property_node( node, prop )
+    {
+        ret =3D hypfs_read_dyndir_entry(&dt_prop.e, prop->name,
+                                      strlen(prop->name),
+                                      !prop->next && !node->child,
+                                      &uaddr);
+
+        if ( ret )
+            break;
+    }
+
+    for ( child =3D node->child; child !=3D NULL; child =3D child->sibling=
 )
+    {
+        const char *parsed_name =3D get_name_from_path(child->full_name);
+        data->data =3D child;
+
+        ret =3D hypfs_read_dyndir_entry(&dt_dir.e, parsed_name,
+                                         strlen(parsed_name),
+                                         child->sibling =3D=3D NULL,
+                                         &uaddr);
+
+        if ( ret )
+            break;
+    }
+
+    return ret;
+}
+
+static unsigned int host_dt_dir_getsize(const struct hypfs_entry *entry)
+{
+    struct dt_device_node *node;
+    struct dt_device_node *child;
+    struct hypfs_dyndir_id *data;
+    const struct dt_property *prop;
+    unsigned int size =3D 0;
+
+    data =3D hypfs_get_dyndata();
+    if ( !data )
+        return -EINVAL;
+
+    node =3D data->data;
+    if ( !node )
+        return -EINVAL;
+
+    dt_for_each_property_node( node, prop )
+    {
+        size +=3D hypfs_dyndir_entry_size(entry, prop->name);
+    }
+
+    for ( child =3D node->child; child !=3D NULL; child =3D child->sibling=
 )
+    {
+        const char *parsed_name =3D get_name_from_path(child->full_name);
+        size +=3D hypfs_dyndir_entry_size(entry, parsed_name);
+    }
+
+    return size;
+}
+
+static DEFINE_PER_CPU(bool, data_alloc);
+
+static inline bool data_is_alloc(void)
+{
+    unsigned int cpu =3D smp_processor_id();
+    return per_cpu(data_alloc, cpu);
+}
+
+static inline void set_data_alloc(void)
+{
+    unsigned int cpu =3D smp_processor_id();
+    ASSERT(!per_cpu(data_alloc, cpu));
+
+    this_cpu(data_alloc) =3D true;
+}
+
+static inline void unset_data_alloc(void)
+{
+    this_cpu(data_alloc) =3D false;
+}
+
+static const struct hypfs_entry *host_dt_dir_enter(
+    const struct hypfs_entry *entry)
+{
+    struct hypfs_dyndir_id *data;
+
+    if ( !data_is_alloc() )
+    {
+        data =3D hypfs_alloc_dyndata(struct hypfs_dyndir_id);
+        if ( !data )
+            return ERR_PTR(-ENOMEM);
+
+        set_data_alloc();
+    }
+
+    if ( strcmp(entry->name, HOST_DT_DIR) =3D=3D 0 )
+    {
+        data =3D hypfs_get_dyndata();
+        data->data =3D dt_host;
+    }
+
+    return entry;
+}
+
+static void host_dt_dir_exit(const struct hypfs_entry *entry)
+{
+    if ( !data_is_alloc() )
+        return;
+
+    hypfs_free_dyndata();
+    unset_data_alloc();
+}
+
+static struct hypfs_entry *host_dt_dir_findentry(
+    const struct hypfs_entry_dir *dir, const char *name, unsigned int name=
_len)
+{
+    struct dt_device_node *node;
+    char root_name[HYPFS_DYNDIR_ID_NAMELEN];
+    struct dt_device_node *child;
+    struct hypfs_dyndir_id *data;
+    struct dt_property *prop;
+
+    data =3D hypfs_get_dyndata();
+    if ( !data )
+        return ERR_PTR(-EINVAL);
+
+    node =3D data->data;
+    if ( !node )
+        return ERR_PTR(-EINVAL);
+
+    memset(root_name, 0, sizeof(root_name));
+    get_root_from_path(name, root_name);
+
+    for ( child =3D node->child; child !=3D NULL; child =3D child->sibling=
 )
+    {
+        if ( strcmp(get_name_from_path(child->full_name), root_name) =3D=
=3D 0 )
+            return hypfs_gen_dyndir_entry(&dt_dir.e,
+                                  get_name_from_path(child->full_name), ch=
ild);
+    }
+
+    dt_for_each_property_node( node, prop )
+    {
+
+        if ( dt_property_name_is_equal(prop, root_name) )
+            return hypfs_gen_dyndir_entry(&dt_prop.e, prop->name, prop);
+    }
+
+    return ERR_PTR(-ENOENT);
+};
+
+static int host_dt_prop_read(const struct hypfs_entry *entry,
+                    XEN_GUEST_HANDLE_PARAM(void) uaddr)
+{
+    const struct dt_property *prop;
+    struct hypfs_dyndir_id *data;
+
+    data =3D hypfs_get_dyndata();
+    if ( !data )
+        return -EINVAL;
+
+    prop =3D data->data;
+    if ( !prop )
+        return -EINVAL;
+
+    return copy_to_guest(uaddr, prop->value, prop->length) ?  -EFAULT : 0;
+}
+
+static unsigned int host_dt_prop_getsize(const struct hypfs_entry *entry)
+{
+    const struct hypfs_dyndir_id *data;
+    const struct dt_property *prop;
+
+    data =3D hypfs_get_dyndata();
+    if ( !data )
+        return -EINVAL;
+
+    prop =3D data->data;
+    if ( !prop )
+        return -EINVAL;
+
+    return prop->length;
+}
+
+static HYPFS_DIR_INIT_FUNC(host_dt_dir, HOST_DT_DIR, &host_dt_dir_funcs);
+
+static int __init host_dtb_export_init(void)
+{
+    ASSERT(dt_host && (dt_host->sibling =3D=3D NULL));
+    unset_data_alloc();
+
+    hypfs_add_dir(&hypfs_root, &host_dt_dir, true);
+    hypfs_add_dyndir(&hypfs_root, &dt_dir);
+    return 0;
+}
+__initcall(host_dtb_export_init);
--=20
2.27.0


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 18:00:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 18:00:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268497.462393 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHUmv-0007Xz-Uh; Tue, 08 Feb 2022 18:00:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268497.462393; Tue, 08 Feb 2022 18:00:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHUmv-0007Xg-MN; Tue, 08 Feb 2022 18:00:25 +0000
Received: by outflank-mailman (input) for mailman id 268497;
 Tue, 08 Feb 2022 18:00:24 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TsJg=SX=epam.com=prvs=40387f30b1=oleksii_moisieiev@srs-se1.protection.inumbo.net>)
 id 1nHUmt-00068L-Uq
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 18:00:24 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id fb07cd74-8908-11ec-8eb8-a37418f5ba1a;
 Tue, 08 Feb 2022 19:00:21 +0100 (CET)
Received: from pps.filterd (m0174678.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 218EgrT8015757;
 Tue, 8 Feb 2022 18:00:17 GMT
Received: from eur02-he1-obe.outbound.protection.outlook.com
 (mail-he1eur02lp2057.outbound.protection.outlook.com [104.47.5.57])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e3t5xrs6q-7
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Tue, 08 Feb 2022 18:00:16 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com (2603:10a6:102:ea::23)
 by VE1PR03MB5613.eurprd03.prod.outlook.com (2603:10a6:803:12a::29)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Tue, 8 Feb
 2022 18:00:09 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::c1c:f98:9dd:86e0]) by PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::c1c:f98:9dd:86e0%6]) with mapi id 15.20.4951.019; Tue, 8 Feb 2022
 18:00:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fb07cd74-8908-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=mY+RaWVddAkBShMK2W/v2hY4BXTUyA7H5kj+8oORo432vKYFcOFXIA8npCiDdWiKWDXEkkmyEvQTiD+q2DF3rFED0OTA7pQewOKDDy0/kuflsNwMezKsvLhxD9OUwQSwR/nJEgdUDgaB5iMolp4jIWm/VsL9SufaYm91b/kjp3pe8ZgnJTgggHgGO6k2J4ia5DfBqwCnSFHL444BV5Sr/JVT9H6BNVSJ0dalb5pQ2eUwzCofUjKMkFtf0QSOTb/M5q6wgprDYI/hxZcjx0xoEMekKK2bJY89ytjZ2//3uUpg5Z3omI7d+CFayreG1MMuyR72zXFVSUkaVT8t87n3qg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=FDKbwCjLZ0DanLs0acIscY6UBZ+tUS318cgSdULOaTg=;
 b=FhC4vSwd/EHlw2WOgLDGBVWKU+o/GodGP5omeA/sR57/LrY4MbJsKNgcgonyzMGdVBa20hgnGe7hHOg4On01ZVpOQlFKVhkpthzI1LpA4SvvEPqnC8ohTWkeYbOSHNRwXI9K6Y1zorSR0waI2TSMBq5iu2IjPNmvr7KAAbQRVkEjRGhvXfTOKQATec6BH+GT8z72KPwWohfhXSj/EH6tA+s+CITgppFH/Dtt5HqKVmXaTaX2ElNKjlYa8bIsGDjYeZHfVOjgkTN/X3SoxLQStmgefmJj6aGyTTY2BMtnbIZqsrzz7FwFV+qU4HfBDhK7xsdsvLOevd2AS8meXKx7ow==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=FDKbwCjLZ0DanLs0acIscY6UBZ+tUS318cgSdULOaTg=;
 b=rFaqhDGBTGz4gKZ4MhsIX+kLwWEk+26jQSFZU03NjW34KeTzNt8ztxbuA78xADTTnk2MpcvGi2Rk6RIMR8PJ+us8NAtQpYTz7LbqCK0M7XZI5u+wtJJ08GxSaBX4F9F7k2i09jsqrmIBy3pxph1EbC1Z7j539/u25OpzhLjWQgYNhvNfwMsbM2eC8CPFn9vDqeGYTBVTpQZGg94fOvaI3hNIHJndSphh/iY27ePZ93gg8yMUGk+/fv8X8bgPhFnNetf1EfBODF1Ta0V38n/clzxEALZN9zrds1U42aSVN3ZK1mXhV2yMTfHMFSNRh2M+tumXgwBWtlnmW5qaMgX1mA==
From: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>,
        Andrew Cooper
	<andrew.cooper3@citrix.com>,
        George Dunlap <george.dunlap@citrix.com>,
        Jan
 Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>,
        Stefano
 Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>
Subject: [RFC v2 4/8] xen/arm: add generic SCI mediator framework
Thread-Topic: [RFC v2 4/8] xen/arm: add generic SCI mediator framework
Thread-Index: AQHYHRW2uVlYW22dYk+LMpDDmAXomw==
Date: Tue, 8 Feb 2022 18:00:09 +0000
Message-ID: 
 <83ecc9060352952bad547ad42c335ee979bf53c3.1644341635.git.oleksii_moisieiev@epam.com>
References: <cover.1644341635.git.oleksii_moisieiev@epam.com>
In-Reply-To: <cover.1644341635.git.oleksii_moisieiev@epam.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 1001ae67-d63f-437f-d2b7-08d9eb2cd8ba
x-ms-traffictypediagnostic: VE1PR03MB5613:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <VE1PR03MB56137DC792574F9FB79B292EE32D9@VE1PR03MB5613.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 GySFz62y0pVP20BKAldSaWT1FG+Kvk6Yc3QdhUZf7v6cVXTnKJ2cXMq1Nwj7/6Y2XPRorMHhEvDAE1m3iLRmnewtczBxD0vmRtgCZP34hSUm6jXvNLL9SOQQEdbc0mhCfnDHzclXkwnc+WxGuHbtetkZJmqoRTEaqGm9rBGNE2wP1KWgq91AOHbDHocX46rgtSvdyLjbDNX2+REyicV7gKD9q0OEMwyUxQduvNIvrOA2mzGqlRAhCoFU6XTXyvrjXq+oZUQUX70Vmtgf6b+QohRJ6o8XslBWcuehz8NpQeP/1udZ2VXlbKycn1r73bN+NPboJH7UVWp9Zb45nVtJD2ipfa0agtwkwv40R2ejDXZBOxGD6WizbXzOiOn5e+RwW40BixkcbjKYXBRcNj/VXEj1QCXzo9US07CgYvuRHewkNqvlNTGQLmte6nrjbm8hDt6tVZaHzn/W/+Bte89wG2YajlqvZmokrDvEg6NvYbTsvsptRuQKNm1KXUq/Mt6SWbYJFKj2EM/HoqHtiDRDDhBP/IEROlgFiUMEamf9xUoXu96KbO94FTL2BMhgEITTNOw7irpYrP8wpY7PEbZQLuMi0X4DWfcYQuOj8Fe/zePYdxJ849qnvarN/x/Llm9wTYldqH16hz72v0jjB880oXxONhDnjQFtFT1ruDbhSAf9fLGRPLi19Pm+MqywZDEklb4srA6F7GRsUz2OI2hu/OS5T7C3GC2cwk0KdcLq7eOIR8i9jcPRe+levxRtU011uZ6DrLisoEc2e8b3zeiFZa55jsMOxD2Jr2e4fOy4Tqs=
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR03MB7136.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38070700005)(71200400001)(6486002)(508600001)(66476007)(64756008)(86362001)(66556008)(316002)(122000001)(6916009)(6506007)(2616005)(5660300002)(6512007)(4326008)(83380400001)(54906003)(30864003)(2906002)(26005)(186003)(8676002)(76116006)(38100700002)(66446008)(66946007)(8936002)(36756003)(91956017)(41533002)(2004002)(21314003);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?iso-8859-1?Q?L2WYFMsGfGar/YWPAkdWTw/gWc9uUoGI7y+Fs2AeVK3Df9Jc2pHx3MKwSr?=
 =?iso-8859-1?Q?aFIfwrjW/BJUTK+MNMDWcchQ2xP324ATL3+qazqPYLa3W/swfHJ6R3APlN?=
 =?iso-8859-1?Q?LMsRfRtvWme3uzWOCl5ULXVPMMDntaf4MYv3NdLftHJoWzEqfFLIB/KOZX?=
 =?iso-8859-1?Q?D5jKkf5QEXzewOgWvp8X+I44gcgNnAa7tAAlc47Y+FXZb0xQ/3w34QAj6C?=
 =?iso-8859-1?Q?4/R9F4gDPPr7a8L/w5pFvrDm0saMI0JBdQaZkWA+e9CKJysYOaj7SSLXsl?=
 =?iso-8859-1?Q?UvmV6hlHahK8zIsG2o+gzVy9zUDn38hIEZe23cFU5Mg0SFL2jbgKVYtF6t?=
 =?iso-8859-1?Q?6payt0NL3rUjrotra+eNiGR7qK5gJJI8eqg20bsQJMgQGuYEN16fdW9Pan?=
 =?iso-8859-1?Q?404UGUeYeShUyq0tz3ekHfpcongyoPUrlbhnj2n/hyjxtl7C4aCr5nnuU4?=
 =?iso-8859-1?Q?o9f90258Bo9I7C0Apgkff+NeNBdNreRglEPCIxmJB+fZsqa97rbzTSPt2V?=
 =?iso-8859-1?Q?doqqJY3ln1vnenivgeSpbr3QxgMRsSEafTHYUbynfEajVuO0FGHVSNzc+w?=
 =?iso-8859-1?Q?GLMtGJmy6RRb3Rmo/nTf1FsWo7JL4JqM/AS3Tk/o6pOYmlTLc3ColwFts4?=
 =?iso-8859-1?Q?By5k5tQyS599F4Ogs5oXbxgAyMH5ws92Qw7bhBHgTA0V1i/Xz/bVMam2SJ?=
 =?iso-8859-1?Q?wwyAJnoSWiQcztjNjGU9OzZIaKo+z/24rFHfF183T8e27EefKmTPnI9K2H?=
 =?iso-8859-1?Q?gwqvQ2mlx/lm7JJMnz3rA0yNtLxCw+Xqso5mtzgyPkZw1Y0Xf5ZidURayH?=
 =?iso-8859-1?Q?IzKUOpjkYxxESLirCcziv08K/eLBc50Ak8tLRgB4cCeV4JuYIVHi067q3c?=
 =?iso-8859-1?Q?ZJvikyrANj2HGVqtoQtmWAe2QFhy698kh/SKxBOhHSkA9YJ+DtRLMJ0pmM?=
 =?iso-8859-1?Q?+PIUldOIdawwysCZtFogeaaqZx7DO/hJ+Jt+uiQc4gi6Ox8QE93oBKm2Oy?=
 =?iso-8859-1?Q?BXY7ls/iq9dbVNjZgFkU1m3R/P0E+hEWI0oNN3FdJgroCXGelxGvTLm6XX?=
 =?iso-8859-1?Q?BJ+/L1r8ku2WppU86tQqbkmkN0w4DkrO5nrOLLxRM5un5/fR9EtJvQLkg0?=
 =?iso-8859-1?Q?pJS9YtpHVI2AzEhyvBkjX8QWqAnbAxXc6bPNTFUEEOpgPZkjaOcNG35FJ6?=
 =?iso-8859-1?Q?qbMVq4Eon+PoKLppMrxNUsOZ6de/ChvEJ7lH+WG9NQkfJ8Hg+6IsYKuaUg?=
 =?iso-8859-1?Q?iehs7NP8djwNbbdSzr2qWc9s2B/zsW7AYu8Zb6hKsAFR1lkdmY5VsyQdvS?=
 =?iso-8859-1?Q?9BjW01H5kNU31yiTX+FW4ojDtBsykDqmt+rZPrAW0oC8aTL/mGwKkVSva8?=
 =?iso-8859-1?Q?oYkvsPMX5t95nAkKEDp+1/rVV2xfvyU8HCIVKjs5YaW3ZByvk4qntJ8tKu?=
 =?iso-8859-1?Q?va+TDUw3Z8MuhIGjkJBqfTflIItoKo3g8xKCcSm+xoIk6wzWHupP678loE?=
 =?iso-8859-1?Q?0eDi6aMZXkvJRqPw5zhePlt2vmos0Q6Jr7k95SyYOxIaNizIB6udmNl55U?=
 =?iso-8859-1?Q?zF6BtRWP5uzjnlB1mAqoN4rj02ktrjrtICbJtPJcV/2ER+QLzQv6Vdlium?=
 =?iso-8859-1?Q?8luUn18PFV5M4LcfTv5XMJ8Cqak41bVaFaadoBH5/tQSmNnauT+8E32YKF?=
 =?iso-8859-1?Q?DnZeUp9QIMkb0WbIt9yfKIs+fmcLapPmerNe/RU65F1valgnih+OSol4Yj?=
 =?iso-8859-1?Q?AHe29gtmVKWhNhwfPwo2g/cg8=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR03MB7136.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1001ae67-d63f-437f-d2b7-08d9eb2cd8ba
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2022 18:00:09.5908
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Fvz0XaV4ZZ14C1yQBR08IJaqI0CoZ4i2HYY2Zt52ID3ARkWDmS8hUoXsdyY5kj6QjLE/F7n0V0wegxhE6BwhO7QQiLQlxC9sSYElKgUGOtg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR03MB5613
X-Proofpoint-GUID: cA5HE8dSeDrbPlw6Q8YLP4RcCfN2Sp5M
X-Proofpoint-ORIG-GUID: cA5HE8dSeDrbPlw6Q8YLP4RcCfN2Sp5M
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-08_06,2022-02-07_02,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 spamscore=0
 priorityscore=1501 clxscore=1015 impostorscore=0 adultscore=0
 suspectscore=0 malwarescore=0 phishscore=0 lowpriorityscore=0
 mlxlogscore=999 bulkscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2201110000 definitions=main-2202080106

This patch adds the basic framework for SCI mediator.
SCI is System Control Interface, which is designed to redirect
requests from the Domains to Firmware. This will allow the devices,
passed-through to the different Domains, to access to the System Controls
(such as clocks/resets etc) by sending requests to the firmware.
Xen mediates requests between the Domains and the Firmware, also it is
responsible for permission handling during Domain crateion.

SCI mediator register itself with REGISTER_SCI_MEDIATOR() macro.

At run-time, during initialization, framework calls probe for the first
matching device in the device-tree. When no device-tree is present - the
first registered mediator should be probed.

Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@epam.com>
---
 MAINTAINERS                   |   6 ++
 xen/arch/arm/Kconfig          |   9 ++
 xen/arch/arm/Makefile         |   1 +
 xen/arch/arm/domain.c         |  22 +++++
 xen/arch/arm/domain_build.c   |  11 +++
 xen/arch/arm/sci/Makefile     |   2 +
 xen/arch/arm/sci/sci.c        | 152 +++++++++++++++++++++++++++++++
 xen/arch/arm/setup.c          |   1 +
 xen/arch/arm/vsmc.c           |   5 +-
 xen/arch/arm/xen.lds.S        |   7 ++
 xen/include/asm-arm/domain.h  |   4 +
 xen/include/asm-arm/sci/sci.h | 162 ++++++++++++++++++++++++++++++++++
 xen/include/public/arch-arm.h |  15 ++++
 13 files changed, 396 insertions(+), 1 deletion(-)
 create mode 100644 xen/arch/arm/sci/Makefile
 create mode 100644 xen/arch/arm/sci/sci.c
 create mode 100644 xen/include/asm-arm/sci/sci.h

diff --git a/MAINTAINERS b/MAINTAINERS
index e43dc0edce..5f96ea35ba 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -512,6 +512,12 @@ S:	Supported
 F:	xen/arch/arm/tee/
 F:	xen/include/asm-arm/tee
=20
+SCI MEDIATORS
+M:	Oleksii Moisieiev <oleksii_moisieiev@epam.com>
+S:	Supported
+F:	xen/arch/arm/sci
+F:	xen/include/asm-arm/sci
+
 TOOLSTACK
 M:	Wei Liu <wl@xen.org>
 S:	Supported
diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
index 895016b21e..ab07833582 100644
--- a/xen/arch/arm/Kconfig
+++ b/xen/arch/arm/Kconfig
@@ -114,6 +114,15 @@ config TEE
=20
 source "arch/arm/tee/Kconfig"
=20
+config ARM_SCI
+	bool "Enable ARM_SCI mediators support"
+	depends on ARM
+	default n
+	help
+	  This option enables generic ARM_SCI (System Control Interface) mediator=
s
+	  support. It allows guests to control system resourcess via one of
+	  ARM_SCI mediators implemented in XEN.
+
 endmenu
=20
 menu "ARM errata workaround via the alternative framework"
diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile
index 0a41f68f8c..f071d912aa 100644
--- a/xen/arch/arm/Makefile
+++ b/xen/arch/arm/Makefile
@@ -8,6 +8,7 @@ obj-y +=3D platforms/
 endif
 obj-$(CONFIG_TEE) +=3D tee/
 obj-$(CONFIG_HAS_VPCI) +=3D vpci.o
+obj-$(CONFIG_ARM_SCI) +=3D sci/
 obj-$(CONFIG_HOST_DTB_EXPORT) +=3D host_dtb_export.o
=20
 obj-$(CONFIG_HAS_ALTERNATIVE) +=3D alternative.o
diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
index 96e1b23550..607ea8c3a8 100644
--- a/xen/arch/arm/domain.c
+++ b/xen/arch/arm/domain.c
@@ -34,6 +34,7 @@
 #include <asm/platform.h>
 #include <asm/procinfo.h>
 #include <asm/regs.h>
+#include <asm/sci/sci.h>
 #include <asm/tee/tee.h>
 #include <asm/vfp.h>
 #include <asm/vgic.h>
@@ -688,6 +689,13 @@ int arch_sanitise_domain_config(struct xen_domctl_crea=
tedomain *config)
         return -EINVAL;
     }
=20
+    if ( config->arch.arm_sci_type !=3D XEN_DOMCTL_CONFIG_ARM_SCI_NONE &&
+         config->arch.arm_sci_type !=3D sci_get_type() )
+    {
+        dprintk(XENLOG_INFO, "Unsupported ARM_SCI type\n");
+        return -EINVAL;
+    }
+
     return 0;
 }
=20
@@ -764,6 +772,13 @@ int arch_domain_create(struct domain *d,
         /* At this stage vgic_reserve_virq should never fail */
         if ( !vgic_reserve_virq(d, GUEST_EVTCHN_PPI) )
             BUG();
+
+        if ( config->arch.arm_sci_type !=3D XEN_DOMCTL_CONFIG_ARM_SCI_NONE=
 )
+        {
+            if ( (rc =3D sci_domain_init(d, config->arch.arm_sci_type,
+                                       &config->arch)) !=3D 0)
+                goto fail;
+        }
     }
=20
     /*
@@ -796,6 +811,7 @@ void arch_domain_destroy(struct domain *d)
     domain_vgic_free(d);
     domain_vuart_free(d);
     free_xenheap_page(d->shared_info);
+    sci_domain_destroy(d);
 #ifdef CONFIG_ACPI
     free_xenheap_pages(d->arch.efi_acpi_table,
                        get_order_from_bytes(d->arch.efi_acpi_len));
@@ -996,6 +1012,7 @@ enum {
     PROG_xen,
     PROG_page,
     PROG_mapping,
+    PROG_sci,
     PROG_done,
 };
=20
@@ -1056,6 +1073,11 @@ int domain_relinquish_resources(struct domain *d)
         if ( ret )
             return ret;
=20
+    PROGRESS(sci):
+        ret =3D sci_relinquish_resources(d);
+        if ( ret )
+            return ret;
+
     PROGRESS(done):
         break;
=20
diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index d02bacbcd1..05afd3e8e7 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -22,6 +22,7 @@
 #include <asm/kernel.h>
 #include <asm/setup.h>
 #include <asm/tee/tee.h>
+#include <asm/sci/sci.h>
 #include <asm/platform.h>
 #include <asm/psci.h>
 #include <asm/setup.h>
@@ -1894,6 +1895,10 @@ static int __init handle_device(struct domain *d, st=
ruct dt_device_node *dev,
                 return res;
             }
         }
+
+        res =3D sci_add_dt_device(d, dev);
+        if ( res < 0 )
+            return res;
     }
=20
     res =3D handle_device_interrupts(d, dev, need_mapping);
@@ -3075,6 +3080,10 @@ static int __init construct_dom0(struct domain *d)
     if ( rc < 0 )
         return rc;
=20
+    rc =3D sci_domain_init(d, sci_get_type(), NULL);
+    if ( rc < 0 )
+        return rc;
+
     if ( acpi_disabled )
         rc =3D prepare_dtb_hwdom(d, &kinfo);
     else
@@ -3109,6 +3118,8 @@ void __init create_dom0(void)
     dom0_cfg.arch.tee_type =3D tee_get_type();
     dom0_cfg.max_vcpus =3D dom0_max_vcpus();
=20
+    dom0_cfg.arch.arm_sci_type =3D sci_get_type();
+
     if ( iommu_enabled )
         dom0_cfg.flags |=3D XEN_DOMCTL_CDF_iommu;
=20
diff --git a/xen/arch/arm/sci/Makefile b/xen/arch/arm/sci/Makefile
new file mode 100644
index 0000000000..67f2611872
--- /dev/null
+++ b/xen/arch/arm/sci/Makefile
@@ -0,0 +1,2 @@
+obj-y +=3D sci.o
+obj-$(CONFIG_SCMI_SMC) +=3D scmi_smc.o
diff --git a/xen/arch/arm/sci/sci.c b/xen/arch/arm/sci/sci.c
new file mode 100644
index 0000000000..05c948a071
--- /dev/null
+++ b/xen/arch/arm/sci/sci.c
@@ -0,0 +1,152 @@
+/*
+ * xen/arch/arm/sci/sci.c
+ *
+ * Generic part of SCI mediator driver
+ *
+ * Oleksii Moisieiev <oleksii_moisieiev@epam.com>
+ * Copyright (C) 2021, EPAM Systems.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#include <xen/acpi.h>
+#include <xen/errno.h>
+#include <xen/init.h>
+#include <xen/sched.h>
+#include <xen/types.h>
+
+#include <asm/sci/sci.h>
+
+extern const struct sci_mediator_desc _sscimediator[], _escimediator[];
+static const struct sci_mediator_desc __read_mostly *cur_mediator;
+
+bool sci_handle_call(struct domain *d, void *args)
+{
+    if ( unlikely(!cur_mediator) )
+        return false;
+
+    return cur_mediator->ops->handle_call(d, args);
+}
+
+int sci_domain_init(struct domain *d, uint16_t sci_type,
+                    struct xen_arch_domainconfig *config)
+{
+    if ( sci_type =3D=3D XEN_DOMCTL_CONFIG_ARM_SCI_NONE )
+        return 0;
+
+    if ( !cur_mediator )
+        return -ENODEV;
+
+    if ( cur_mediator->sci_type !=3D sci_type )
+        return -EINVAL;
+
+    return cur_mediator->ops->domain_init(d, config);
+}
+
+void sci_domain_destroy(struct domain *d)
+{
+    if ( !cur_mediator )
+        return;
+
+    cur_mediator->ops->domain_destroy(d);
+}
+
+int sci_relinquish_resources(struct domain *d)
+{
+    if ( !cur_mediator )
+        return 0;
+
+    return cur_mediator->ops->relinquish_resources(d);
+}
+
+
+int sci_add_dt_device(struct domain *d, struct dt_device_node *dev)
+{
+    if ( !cur_mediator )
+        return 0;
+
+    return cur_mediator->ops->add_dt_device(d, dev);
+}
+
+uint16_t sci_get_type(void)
+{
+    if ( !cur_mediator )
+        return XEN_DOMCTL_CONFIG_ARM_SCI_NONE;
+
+    return cur_mediator->sci_type;
+}
+
+int sci_do_domctl(
+    struct xen_domctl *domctl, struct domain *d,
+    XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl)
+{
+    int rc =3D -EINVAL;
+    struct dt_device_node *dev;
+
+    switch ( domctl->cmd )
+    {
+    case XEN_DOMCTL_assign_device:
+        if ( domctl->u.assign_device.dev !=3D XEN_DOMCTL_DEV_DT )
+            break;
+
+        rc =3D dt_find_node_by_gpath(domctl->u.assign_device.u.dt.path,
+                               domctl->u.assign_device.u.dt.size,
+                               &dev);
+        if ( rc )
+            return rc;
+
+        rc =3D sci_add_dt_device(d, dev);
+
+        break;
+    default:
+        rc =3D -ENOSYS;
+        break;
+    }
+
+    return rc;
+}
+
+static int __init sci_init(void)
+{
+    const struct sci_mediator_desc *desc;
+    struct dt_device_node *dt =3D NULL;
+
+
+    for ( desc =3D _sscimediator; desc !=3D _escimediator; desc++ )
+    {
+        if ( acpi_disabled )
+        {
+            dt =3D dt_find_matching_node(dt_host, desc->dt_match);
+            if ( !dt )
+                continue;
+        }
+
+        if ( desc->ops->probe(dt) )
+        {
+            printk(XENLOG_INFO "Using SCI mediator for %s\n", desc->name);
+            cur_mediator =3D desc;
+            return 0;
+        }
+    }
+
+    return 0;
+}
+
+__initcall(sci_init);
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
index d5d0792ed4..201de01411 100644
--- a/xen/arch/arm/setup.c
+++ b/xen/arch/arm/setup.c
@@ -50,6 +50,7 @@
 #include <asm/cpufeature.h>
 #include <asm/platform.h>
 #include <asm/procinfo.h>
+#include <asm/sci/sci.h>
 #include <asm/setup.h>
 #include <xsm/xsm.h>
 #include <asm/acpi.h>
diff --git a/xen/arch/arm/vsmc.c b/xen/arch/arm/vsmc.c
index a36db15fff..c68482fbd8 100644
--- a/xen/arch/arm/vsmc.c
+++ b/xen/arch/arm/vsmc.c
@@ -22,6 +22,7 @@
 #include <asm/cpufeature.h>
 #include <asm/monitor.h>
 #include <asm/regs.h>
+#include <asm/sci/sci.h>
 #include <asm/smccc.h>
 #include <asm/tee/tee.h>
 #include <asm/traps.h>
@@ -275,7 +276,9 @@ static bool vsmccc_handle_call(struct cpu_user_regs *re=
gs)
             handled =3D handle_sssc(regs);
             break;
         case ARM_SMCCC_OWNER_SIP:
-            handled =3D platform_smc(regs);
+            handled =3D sci_handle_call(current->domain, regs);
+            if ( !handled )
+                handled =3D platform_smc(regs);
             break;
         case ARM_SMCCC_OWNER_TRUSTED_APP ... ARM_SMCCC_OWNER_TRUSTED_APP_E=
ND:
         case ARM_SMCCC_OWNER_TRUSTED_OS ... ARM_SMCCC_OWNER_TRUSTED_OS_END=
:
diff --git a/xen/arch/arm/xen.lds.S b/xen/arch/arm/xen.lds.S
index 08016948ab..3683f4821f 100644
--- a/xen/arch/arm/xen.lds.S
+++ b/xen/arch/arm/xen.lds.S
@@ -142,6 +142,13 @@ SECTIONS
       _eteemediator =3D .;
   } :text
=20
+  . =3D ALIGN(8);
+  .scimediator.info : {
+      _sscimediator =3D .;
+      *(.scimediator.info)
+      _escimediator =3D .;
+  } :text
+
   . =3D ALIGN(PAGE_SIZE);             /* Init code and data */
   __init_begin =3D .;
   .init.text : {
diff --git a/xen/include/asm-arm/domain.h b/xen/include/asm-arm/domain.h
index 9b3647587a..11c8db8db1 100644
--- a/xen/include/asm-arm/domain.h
+++ b/xen/include/asm-arm/domain.h
@@ -89,6 +89,10 @@ struct arch_domain
 #ifdef CONFIG_TEE
     void *tee;
 #endif
+
+#ifdef CONFIG_ARM_SCI
+    void *sci;
+#endif
 }  __cacheline_aligned;
=20
 struct arch_vcpu
diff --git a/xen/include/asm-arm/sci/sci.h b/xen/include/asm-arm/sci/sci.h
new file mode 100644
index 0000000000..075e11bc16
--- /dev/null
+++ b/xen/include/asm-arm/sci/sci.h
@@ -0,0 +1,162 @@
+/*
+ * xen/include/asm-arm/sci/sci.h
+ *
+ * Generic part of the SCI (System Control Interface) subsystem.
+ *
+ * Oleksii Moisieiev <oleksii_moisieiev@epam.com>
+ * Copyright (C) 2021, EPAM Systems.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#ifndef __ASM_ARM_SCI_H
+#define __ASM_ARM_SCI_H
+
+#include <xen/lib.h>
+#include <xen/types.h>
+#include <xen/device_tree.h>
+#include <public/domctl.h>
+
+#ifdef CONFIG_ARM_SCI
+
+struct sci_mediator_ops {
+
+    /*
+     * Probe for SCI. Should return true if SCI found and
+     * mediator is initialized.
+     */
+    bool (*probe)(struct dt_device_node *scmi_node);
+
+    /*
+     * Called during domain construction if toolstack requests to enable
+     * SCI support so mediator can inform SCP-firmware about new
+     * guest and create own structures for the new domain.
+     */
+    int (*domain_init)(struct domain *d, struct xen_arch_domainconfig *con=
fig);
+
+    /*
+     * Called during domain destruction, releases all resources, that
+     * were allocated by the mediator.
+     */
+    void (*domain_destroy)(struct domain *d);
+
+    /*
+     * Called during parsing partial device-sci for the domain.
+     * Passing device_node so mediator could process the device and
+     * mark the device as related to the domain if needed.
+     */
+    int (*add_dt_device)(struct domain *d, struct dt_device_node *dev);
+
+    /*
+     * Called during domain destruction to relinquish resources used
+     * by mediator itself. This function can return -ERESTART to indicate
+     * that it does not finished work and should be called again.
+     */
+    int (*relinquish_resources)(struct domain *d);
+
+    /* Handle call for current domain */
+    bool (*handle_call)(struct domain *d, void *regs);
+};
+
+struct sci_mediator_desc {
+    /* Printable name of the SCI. */
+    const char *name;
+
+    /* Mediator callbacks as described above. */
+    const struct sci_mediator_ops *ops;
+
+    /*
+     * ID of SCI. Corresponds to xen_arch_domainconfig.sci_type.
+     * Should be one of XEN_DOMCTL_CONFIG_ARM_SCI_xxx
+     */
+    uint16_t sci_type;
+
+    /* Match structure to init mediator */
+    const struct dt_device_match *dt_match;
+
+};
+
+int sci_domain_init(struct domain *d, uint16_t sci_type,
+                    struct xen_arch_domainconfig *config);
+void sci_domain_destroy(struct domain *d);
+int sci_add_dt_device(struct domain *d, struct dt_device_node *dev);
+int sci_relinquish_resources(struct domain *d);
+bool sci_handle_call(struct domain *d, void *args);
+uint16_t sci_get_type(void);
+int sci_do_domctl(
+    struct xen_domctl *domctl, struct domain *d,
+    XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl);
+
+#define REGISTER_SCI_MEDIATOR(_name, _namestr, _type, _match, _ops) \
+static const struct sci_mediator_desc __sci_desc_##_name __used     \
+__section(".scimediator.info") =3D {                                  \
+    .name =3D _namestr,                                               \
+    .ops =3D _ops,                                                    \
+    .sci_type =3D _type,                                              \
+    .dt_match =3D _match                                              \
+}
+
+#else
+
+static inline int sci_domain_init(struct domain *d, uint16_t sci_type,
+                    struct xen_arch_domainconfig *config)
+{
+    if ( likely(sci_type =3D=3D XEN_DOMCTL_CONFIG_ARM_SCI_NONE) )
+        return 0;
+
+    return -ENODEV;
+}
+
+static inline void sci_domain_destroy(struct domain *d)
+{
+}
+
+static inline int sci_add_dt_device(struct domain *d,
+                                    struct dt_device_node *dev)
+{
+    return 0;
+}
+
+static inline int sci_relinquish_resources(struct domain *d)
+{
+    return 0;
+}
+
+static inline bool sci_handle_call(struct domain *d, void *args)
+{
+    return false;
+}
+
+static inline uint16_t sci_get_type(void)
+{
+    return XEN_DOMCTL_CONFIG_ARM_SCI_NONE;
+}
+
+static inline int sci_do_domctl(
+    struct xen_domctl *domctl, struct domain *d,
+    XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl)
+{
+    return -ENOSYS;
+}
+
+
+#endif  /* CONFIG_ARM_SCI */
+
+#endif /* __ASM_ARM_SCI_H */
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
index 94b31511dd..a6131ab1fd 100644
--- a/xen/include/public/arch-arm.h
+++ b/xen/include/public/arch-arm.h
@@ -314,12 +314,17 @@ DEFINE_XEN_GUEST_HANDLE(vcpu_guest_context_t);
 #define XEN_DOMCTL_CONFIG_TEE_NONE      0
 #define XEN_DOMCTL_CONFIG_TEE_OPTEE     1
=20
+#define XEN_DOMCTL_CONFIG_ARM_SCI_NONE      0
+#define XEN_DOMCTL_CONFIG_ARM_SCI_SCMI_SMC  1
+
 struct xen_arch_domainconfig {
     /* IN/OUT */
     uint8_t gic_version;
     /* IN */
     uint16_t tee_type;
     /* IN */
+    uint16_t arm_sci_type;
+    /* IN */
     uint32_t nr_spis;
     /*
      * OUT
@@ -335,6 +340,12 @@ struct xen_arch_domainconfig {
      *
      */
     uint32_t clock_frequency;
+
+    /* Sets shared address to sw domains.
+     * This information is needed to set correct channel in Domain partial
+     * device-tree
+     */
+    uint64_t arm_sci_agent_paddr;
 };
 #endif /* __XEN__ || __XEN_TOOLS__ */
=20
@@ -429,6 +440,10 @@ typedef uint64_t xen_callback_t;
 #define GUEST_ACPI_BASE xen_mk_ullong(0x20000000)
 #define GUEST_ACPI_SIZE xen_mk_ullong(0x02000000)
=20
+/* SCMI shared memory address */
+#define GUEST_SCI_SHMEM_BASE   xen_mk_ullong(0x05ff0000)
+#define GUEST_SCI_SHMEM_SIZE   xen_mk_ullong(0x01000)
+
 /* PL011 mappings */
 #define GUEST_PL011_BASE    xen_mk_ullong(0x22000000)
 #define GUEST_PL011_SIZE    xen_mk_ullong(0x00001000)
--=20
2.27.0


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 18:00:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 18:00:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268491.462331 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHUmo-00068d-Cc; Tue, 08 Feb 2022 18:00:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268491.462331; Tue, 08 Feb 2022 18:00:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHUmo-00068W-9f; Tue, 08 Feb 2022 18:00:18 +0000
Received: by outflank-mailman (input) for mailman id 268491;
 Tue, 08 Feb 2022 18:00:17 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TsJg=SX=epam.com=prvs=40387f30b1=oleksii_moisieiev@srs-se1.protection.inumbo.net>)
 id 1nHUmn-00068K-3w
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 18:00:17 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f67cc8ae-8908-11ec-8f75-fffcc8bd4f1a;
 Tue, 08 Feb 2022 19:00:14 +0100 (CET)
Received: from pps.filterd (m0174678.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 218EgrT2015757;
 Tue, 8 Feb 2022 18:00:12 GMT
Received: from eur02-he1-obe.outbound.protection.outlook.com
 (mail-he1eur02lp2057.outbound.protection.outlook.com [104.47.5.57])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e3t5xrs6q-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Tue, 08 Feb 2022 18:00:11 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com (2603:10a6:102:ea::23)
 by VE1PR03MB5613.eurprd03.prod.outlook.com (2603:10a6:803:12a::29)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Tue, 8 Feb
 2022 18:00:06 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::c1c:f98:9dd:86e0]) by PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::c1c:f98:9dd:86e0%6]) with mapi id 15.20.4951.019; Tue, 8 Feb 2022
 18:00:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f67cc8ae-8908-11ec-8f75-fffcc8bd4f1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=YiwDlP3vRAbBoMjwRE1DEMeNzuy/z4yOtYj+6mxRiCegonEQ01woy2anuIGi+cFAXjJMO4Pg4pF+S4t+6IdDlC3/lSAnJOqa7u9CnlJ61t3dYeNlmCxB8vYc+6kuBb6IsJgMh0QK3yL0moIsm0xypelXrtCZ4nrx0rk/rS1A4a0Uck07r/4VKwXSO398sTnvbTnFOCk4OIP7TGTvkfH70nms7uC8bqTyXhP0D/A6DChg8SETmd4WKiJ/YtyGlDmRKy6CiWRHqpChsceAFjjTuCB+9Ure1ZTkVZQbQjMaykuUralkABpHyWVj7V5qT9/6cx6XA8dEVYHu/wL2Peymaw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Zp886fdenazy8I4uy4JOrrugnDLYw+4E5d77d3IGdYU=;
 b=QUxMC3tOWqSmKH7p+bAsfGvJGbup8DmnObj4KIOwZIF2F+Mtdh0XLM6Zwx0w0RnBgk/1EQAsraDfij8WoGQzkfEH1i7uoNnZPkpWldyfLhcTyYilWdiQEd5c9fgmjP9GGYjpUFEbHiiR3o3jueECbmiLLp3wNorJciPK7AmufAesPXxOwDEiTIs4gSqhihxhCuDkL5cAZWZ7Kmb29WUZCFWrIrGM195PWV1pCu3lw9aLSjNpnG0J99die9vW6XgyoGLNRbFX5iwbN/yg3lY23W4683ctxUQPs5/ReapKsQyTzBtZeU6zsHD7QeuxiDcOW5fh6nlnEukpeFi7KSZkUg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Zp886fdenazy8I4uy4JOrrugnDLYw+4E5d77d3IGdYU=;
 b=eC+n5fSTp8riCSmttv9a7mw1RZaur//zyuhK2meAE9XVyTLuXMkeQGGDBDpszNmcRA3f5M17PVhKNeYdIv1Zasz6TBKbsS9pcWAcNkxZU6Llx2xO39thw2aufY8hq1JB9j24XPvZ1vYqEQR2lHl3ZiSFardLrUImfQvFIoTpHY9LOHm6ZU8F99uX1kugrJqgy54JteK6JOhJyuYU7cW/Sk9x7IxCkCcdWi9Bz8dRkJPFlRR6bP4/ZQgW6do6ErVF1ov9puWknlEQd83cL01bZeBTEiZ1DRBaDtBfa667pcMKygoqfEwd/rLhAqDuZ3H9UwAzITSg5/Yq48sfSwuWjg==
From: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>,
        Juergen Gross
	<jgross@suse.com>
Subject: [RFC v2 1/8] xen/hypfs: support fo nested dynamic hypfs nodes
Thread-Topic: [RFC v2 1/8] xen/hypfs: support fo nested dynamic hypfs nodes
Thread-Index: AQHYHRW07SkrMxyT/k6/hhSCHW7Rmg==
Date: Tue, 8 Feb 2022 18:00:06 +0000
Message-ID: 
 <8ab7e9ffd5f041c2631f754c7c596874cf6a99c1.1644341635.git.oleksii_moisieiev@epam.com>
References: <cover.1644341635.git.oleksii_moisieiev@epam.com>
In-Reply-To: <cover.1644341635.git.oleksii_moisieiev@epam.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: ec53d40c-2a59-49f2-c7b6-08d9eb2cd6e4
x-ms-traffictypediagnostic: VE1PR03MB5613:EE_
x-microsoft-antispam-prvs: 
 <VE1PR03MB56137297DA769971DFD61EAEE32D9@VE1PR03MB5613.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:4941;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 M925godofpc/lzkYZpjCxO5Z3+hNdtDE0Aeme/XmzDf6pgAQe9GTjMproVG2AhJNtKXKbTwUK+92SQ54Xb9DXbpdd6+nkygZncTMbuzsLn8hBxnI2dXKggeIR6p+Oy9RpS8hX7RWFZo/d6zLJQI4mfAczAxRXzQqh/71a17jHCVRyVG6YP8L7ZEFXhMpupR1l4eTAgqDpg9TVeHgVcYU2RO6fhfrZDnVYn5AP0NHQ071H1UouXsxbCNmcuZ2E3JWi+4EL7vVf8CinOFEsqtpMbIDNCHHNWXDS0Ng/KOb4EagJdnzRvVwghATY/sFJAVm9xSBbm4qb+y2QynfQAbSh/TewpcGIXCCUjPc4kVNs+rPQgexC2g6FtExTpl89wfWLNS3hRezjt6sK7N6BottTQOm0MQ5qtbubqfh53lzsX369HQUEYkoH7U98VcP7iMMMdO6ZSkqM+3ebaTdTqIBTSOWTuxQ1WeuTOtgAhacY2kIU4YSMklFm5H2viWCmfXDcsNq6xVpIuJbbNHLCnc3OTzWczBgf7R2BLop+oNVQF+mfg5gBeK2W4qWiBnOFY75v9g6fcZhDFzNNd7G+6UQfWD4IMZI25KKjXUp1cQANZFS5Mf7MOBKz0n01/9Hj5nhAKcu9yFp5ZTgv8rZ9zBoJYAu6kV5gEkWmejTbd7UnO3AalCtplUcZTQiWjYnidUY4v6ei0AOC2OLMzf3QJCkiA==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR03MB7136.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38070700005)(71200400001)(6486002)(508600001)(66476007)(64756008)(86362001)(66556008)(316002)(122000001)(6916009)(6506007)(2616005)(5660300002)(6512007)(4326008)(83380400001)(54906003)(2906002)(26005)(186003)(8676002)(76116006)(38100700002)(66446008)(66946007)(8936002)(36756003)(91956017);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?iso-8859-1?Q?xKkU+ob0B1OPUwigD9emPoDS22D1O39Rrg3DSS1fWHxhAr7Y5bEU8WvzIY?=
 =?iso-8859-1?Q?6JV9Vu9BPWYuTzB58EqKnJdHFFeamOqTMBvHTw4gRaRptlonfOS07/fYBl?=
 =?iso-8859-1?Q?XduE9KQ43rx7C31uy42IlKFTopeIp9W4naazv4wlpMftuZuA1Ugb8nUpFU?=
 =?iso-8859-1?Q?nCgwrt3vWeSY1tGOPw4CoiL7Vxpl4wzT1sjZX0AC7p8P1GxJxRdMIZDgvB?=
 =?iso-8859-1?Q?5nJf1pw9zBlYUArzGRQ70kt4Ol1bUYmD12+hg7GseRojRfiDf3ixylX47e?=
 =?iso-8859-1?Q?96iRC5x1cNVgMI9W1bDovGT9QV4DjCFTmoww5tkAhWsrUTg7i32POmWDGe?=
 =?iso-8859-1?Q?Oy0+wX8WkrSUao6AFrQJZtWXrK+da+PwJckxk5M0rStf70sNoraF4Xiplb?=
 =?iso-8859-1?Q?3RWs8McyG5Pq0O6QWvBs7eUUS4Zg83Mdzs+5or5UXij1BRGg3o5lZi40u2?=
 =?iso-8859-1?Q?BWcDA9eYuyJP/DGb6gXn2zOnoJArqpHZiWmM1CIJP92tj60yncpK5bVh/f?=
 =?iso-8859-1?Q?V4QUzF+8ELuDrXvv0DT+hPW/77GzrTjyK/ox4EfbBhOvYDJil3vY9YSGTz?=
 =?iso-8859-1?Q?OUVHLVb2zb4M+DqlBSJhcotbmFz+F32LcJrGMJdEBL4LbKlAd9/WRnRHqA?=
 =?iso-8859-1?Q?C+h9r1RTqNIKjao8IDhyEfWu/7TVVNxdGFLvTWdcYLUiKrgsNKdXrsXz82?=
 =?iso-8859-1?Q?ZSzuOqXlmi6EMnT8ZHTCOiFA4k2bkHJKB4OTJLnOKw4YIj9LibBLZdjpou?=
 =?iso-8859-1?Q?xe25t8ybXI8AgmCr6Cbcf2KCmwwpDGHwyDHn//wtwXzQRLdQHi6QDASL4Y?=
 =?iso-8859-1?Q?dCY1iap4wGNMNES0hJT6v4f1PHk9qYVGkzBa6NqJRIj5qfahl+tgyzmTSr?=
 =?iso-8859-1?Q?kf7zbEsb9XdrieItx7hTDfnt0qhZz4eyjh3u0CyuqUdfHM3ZoQxZFqi4Pk?=
 =?iso-8859-1?Q?+u719DmVaWS6QDY0wzGZVIqzEVtZEh+xGW9v3Hqk6umg1txClUApWlZV/U?=
 =?iso-8859-1?Q?Jx7rk6oG9V3n9VoQoQ641Qxj4YIkfC2Rbo65s+uBn/BnxHYKunNeW7FQOT?=
 =?iso-8859-1?Q?ddoib8eAB7AQ/30VPf00pZ0Om5oCMPq9PGjKmrUzCxRonNjOUF57tjhxjn?=
 =?iso-8859-1?Q?yXaJumqLFI6b+ztYicmFxwzM5Dt2LvIQSaVqrU2OBDENTSvjin6eLW7K0o?=
 =?iso-8859-1?Q?C04qvWRzPvH0fRkSSQl9+LGsLx9ZzRmJ7B24SVPjVwv/A5NhCz8u4r5jxw?=
 =?iso-8859-1?Q?f4YSK9sO2pskpNvdHC+6hcSlaOvgnTgqMn1Jvz9lxS1CzUJxYLJLgJ/nLe?=
 =?iso-8859-1?Q?AlB1iWB0o5Xzp+2jfXyLVsRosZubEhg53+iC71Yo8rdgpll6+/awQtKsh6?=
 =?iso-8859-1?Q?04r+a4wzZBmTM75QaUl6vgelYYjsBOQ239Ov1I1x0/2dWnt0MgGaBAtaqk?=
 =?iso-8859-1?Q?dhNs4xAfyatIVHetWo/wrzlGMIzHKYvTY/AiKZrw/ilIOnxYpj7NSzGG8m?=
 =?iso-8859-1?Q?9PXtwhvZzLR34GD8ts3edyDzAyW1dUwqu6QDovxltcH0JUYuOr/L2QXUlD?=
 =?iso-8859-1?Q?1wxKCIRVxbs3/+ruDLDy4xHm8WrCpixfqS2G9SLFvtSHTt7kiQmIb+TV7J?=
 =?iso-8859-1?Q?DN7/RppWhHk/wxKQFd9d26T2zKRD3fx8bB/3VNcdFWUlZ3VOJOjziM5iAj?=
 =?iso-8859-1?Q?mZiNaooPznVGIVAPuiyJFZIcOvnHGZC9KGMMNKumBpwl/Q3QuG2oqdXv+s?=
 =?iso-8859-1?Q?8B+aYYPArPFJKrdmBRyJDP3hc=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR03MB7136.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ec53d40c-2a59-49f2-c7b6-08d9eb2cd6e4
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2022 18:00:06.5573
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: gM2gdTx06HrrtJ3eII21MiAK5rjeTo34Opxb3ACRe6fNYG4RBMTkmvsByH5gx1qItsN1kNDrWrxfPX40aUvAKSnxNWBbXhGIA2CfjSSszks=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR03MB5613
X-Proofpoint-GUID: xlpRPLEwV6HuY1SOqqNURSozi-PfZpJB
X-Proofpoint-ORIG-GUID: xlpRPLEwV6HuY1SOqqNURSozi-PfZpJB
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-08_06,2022-02-07_02,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 spamscore=0
 priorityscore=1501 clxscore=1015 impostorscore=0 adultscore=0
 suspectscore=0 malwarescore=0 phishscore=0 lowpriorityscore=0
 mlxlogscore=999 bulkscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2201110000 definitions=main-2202080106

Add new api:
- hypfs_read_dyndir_entry
- hypfs_gen_dyndir_entry
which are the extension of the dynamic hypfs nodes support, presented in
0b3b53be8cf226d947a79c2535a9efbb2dd7bc38.
This allows nested dynamic nodes to be added. Also input parameter is
hypfs_entry, so properties can also be generated dynamically.

Generating mixed list of dirs and properties is also supported.
Same as to the dynamic hypfs nodes, this is anchored in percpu pointer,
which can be retriewed on any level of the dynamic entries.
This handle should be allocated on enter() callback and released on
exit() callback. When using nested dynamic dirs and properties handle
should be allocated on the first enter() call and released on the last
exit() call.

Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@epam.com>
---
 xen/common/hypfs.c      | 83 +++++++++++++++++++++++++++++++++--------
 xen/include/xen/hypfs.h | 14 ++++++-
 2 files changed, 79 insertions(+), 18 deletions(-)

diff --git a/xen/common/hypfs.c b/xen/common/hypfs.c
index e71f7df479..6901f5e311 100644
--- a/xen/common/hypfs.c
+++ b/xen/common/hypfs.c
@@ -367,28 +367,27 @@ unsigned int hypfs_getsize(const struct hypfs_entry *=
entry)
=20
 /*
  * Fill the direntry for a dynamically generated entry. Especially the
- * generated name needs to be kept in sync with hypfs_gen_dyndir_id_entry(=
).
+ * generated name needs to be kept in sync with hypfs_gen_dyndir_entry().
  */
-int hypfs_read_dyndir_id_entry(const struct hypfs_entry_dir *template,
-                               unsigned int id, bool is_last,
+int hypfs_read_dyndir_entry(const struct hypfs_entry *template,
+                               const char *name, unsigned int namelen,
+                               bool is_last,
                                XEN_GUEST_HANDLE_PARAM(void) *uaddr)
 {
     struct xen_hypfs_dirlistentry direntry;
-    char name[HYPFS_DYNDIR_ID_NAMELEN];
-    unsigned int e_namelen, e_len;
+    unsigned int e_len;
=20
-    e_namelen =3D snprintf(name, sizeof(name), template->e.name, id);
-    e_len =3D DIRENTRY_SIZE(e_namelen);
+    e_len =3D DIRENTRY_SIZE(namelen);
     direntry.e.pad =3D 0;
-    direntry.e.type =3D template->e.type;
-    direntry.e.encoding =3D template->e.encoding;
-    direntry.e.content_len =3D template->e.funcs->getsize(&template->e);
-    direntry.e.max_write_len =3D template->e.max_size;
+    direntry.e.type =3D template->type;
+    direntry.e.encoding =3D template->encoding;
+    direntry.e.content_len =3D template->funcs->getsize(template);
+    direntry.e.max_write_len =3D template->max_size;
     direntry.off_next =3D is_last ? 0 : e_len;
     if ( copy_to_guest(*uaddr, &direntry, 1) )
         return -EFAULT;
     if ( copy_to_guest_offset(*uaddr, DIRENTRY_NAME_OFF, name,
-                              e_namelen + 1) )
+                              namelen + 1) )
         return -EFAULT;
=20
     guest_handle_add_offset(*uaddr, e_len);
@@ -396,6 +395,22 @@ int hypfs_read_dyndir_id_entry(const struct hypfs_entr=
y_dir *template,
     return 0;
 }
=20
+/*
+ * Fill the direntry for a dynamically generated entry. Especially the
+ * generated name needs to be kept in sync with hypfs_gen_dyndir_id_entry(=
).
+ */
+int hypfs_read_dyndir_id_entry(const struct hypfs_entry_dir *template,
+                               unsigned int id, bool is_last,
+                               XEN_GUEST_HANDLE_PARAM(void) *uaddr)
+{
+    char name[HYPFS_DYNDIR_ID_NAMELEN];
+    unsigned int e_namelen;
+
+    e_namelen =3D snprintf(name, sizeof(name), template->e.name, id);
+    return hypfs_read_dyndir_entry(&template->e, name, e_namelen, is_last,=
 uaddr);
+}
+
+
 static const struct hypfs_entry *hypfs_dyndir_enter(
     const struct hypfs_entry *entry)
 {
@@ -404,7 +419,7 @@ static const struct hypfs_entry *hypfs_dyndir_enter(
     data =3D hypfs_get_dyndata();
=20
     /* Use template with original enter function. */
-    return data->template->e.funcs->enter(&data->template->e);
+    return data->template->funcs->enter(data->template);
 }
=20
 static struct hypfs_entry *hypfs_dyndir_findentry(
@@ -415,7 +430,7 @@ static struct hypfs_entry *hypfs_dyndir_findentry(
     data =3D hypfs_get_dyndata();
=20
     /* Use template with original findentry function. */
-    return data->template->e.funcs->findentry(data->template, name, name_l=
en);
+    return data->template->funcs->findentry(&data->dir, name, name_len);
 }
=20
 static int hypfs_read_dyndir(const struct hypfs_entry *entry,
@@ -426,7 +441,36 @@ static int hypfs_read_dyndir(const struct hypfs_entry =
*entry,
     data =3D hypfs_get_dyndata();
=20
     /* Use template with original read function. */
-    return data->template->e.funcs->read(&data->template->e, uaddr);
+    return data->template->funcs->read(data->template, uaddr);
+}
+
+/*
+ * Fill dyndata with a dynamically generated entry based on a template
+ * and a name.
+ * Needs to be kept in sync with hypfs_read_dyndir_entry() regarding the
+ * name generated.
+ */
+struct hypfs_entry *hypfs_gen_dyndir_entry(
+    const struct hypfs_entry *template, const char *name,
+    void *data)
+{
+    struct hypfs_dyndir_id *dyndata;
+
+    dyndata =3D hypfs_get_dyndata();
+
+    dyndata->template =3D template;
+    dyndata->data =3D data;
+    memcpy(dyndata->name, name, strlen(name));
+    dyndata->dir.e =3D *template;
+    dyndata->dir.e.name =3D dyndata->name;
+
+    dyndata->dir.e.funcs =3D &dyndata->funcs;
+    dyndata->funcs =3D *template->funcs;
+    dyndata->funcs.enter =3D hypfs_dyndir_enter;
+    dyndata->funcs.findentry =3D hypfs_dyndir_findentry;
+    dyndata->funcs.read =3D hypfs_read_dyndir;
+
+    return &dyndata->dir.e;
 }
=20
 /*
@@ -442,12 +486,13 @@ struct hypfs_entry *hypfs_gen_dyndir_id_entry(
=20
     dyndata =3D hypfs_get_dyndata();
=20
-    dyndata->template =3D template;
+    dyndata->template =3D &template->e;
     dyndata->id =3D id;
     dyndata->data =3D data;
     snprintf(dyndata->name, sizeof(dyndata->name), template->e.name, id);
     dyndata->dir =3D *template;
     dyndata->dir.e.name =3D dyndata->name;
+
     dyndata->dir.e.funcs =3D &dyndata->funcs;
     dyndata->funcs =3D *template->e.funcs;
     dyndata->funcs.enter =3D hypfs_dyndir_enter;
@@ -457,6 +502,12 @@ struct hypfs_entry *hypfs_gen_dyndir_id_entry(
     return &dyndata->dir.e;
 }
=20
+unsigned int hypfs_dyndir_entry_size(const struct hypfs_entry *template,
+                                    const char *name)
+{
+    return DIRENTRY_SIZE(strlen(name));
+}
+
 unsigned int hypfs_dynid_entry_size(const struct hypfs_entry *template,
                                     unsigned int id)
 {
diff --git a/xen/include/xen/hypfs.h b/xen/include/xen/hypfs.h
index e9d4c2555b..5d2728b963 100644
--- a/xen/include/xen/hypfs.h
+++ b/xen/include/xen/hypfs.h
@@ -79,8 +79,8 @@ struct hypfs_entry_dir {
 struct hypfs_dyndir_id {
     struct hypfs_entry_dir dir;             /* Modified copy of template. =
*/
     struct hypfs_funcs funcs;               /* Dynamic functions. */
-    const struct hypfs_entry_dir *template; /* Template used. */
-#define HYPFS_DYNDIR_ID_NAMELEN 12
+    const struct hypfs_entry *template; /* Template used. */
+#define HYPFS_DYNDIR_ID_NAMELEN 32
     char name[HYPFS_DYNDIR_ID_NAMELEN];     /* Name of hypfs entry. */
=20
     unsigned int id;                        /* Numerical id. */
@@ -197,13 +197,23 @@ void *hypfs_alloc_dyndata(unsigned long size);
 #define hypfs_alloc_dyndata(type) ((type *)hypfs_alloc_dyndata(sizeof(type=
)))
 void *hypfs_get_dyndata(void);
 void hypfs_free_dyndata(void);
+int hypfs_read_dyndir_entry(const struct hypfs_entry *template,
+                               const char *name, unsigned int namelen,
+                               bool is_last,
+                               XEN_GUEST_HANDLE_PARAM(void) *uaddr);
 int hypfs_read_dyndir_id_entry(const struct hypfs_entry_dir *template,
                                unsigned int id, bool is_last,
                                XEN_GUEST_HANDLE_PARAM(void) *uaddr);
+struct hypfs_entry *hypfs_gen_dyndir_entry(
+    const struct hypfs_entry *template, const char *name,
+    void *data);
 struct hypfs_entry *hypfs_gen_dyndir_id_entry(
     const struct hypfs_entry_dir *template, unsigned int id, void *data);
 unsigned int hypfs_dynid_entry_size(const struct hypfs_entry *template,
                                     unsigned int id);
+unsigned int hypfs_dyndir_entry_size(const struct hypfs_entry *template,
+                                    const char *name);
+
 #endif
=20
 #endif /* __XEN_HYPFS_H__ */
--=20
2.27.0


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 18:00:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 18:00:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268496.462387 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHUmv-0007T5-FB; Tue, 08 Feb 2022 18:00:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268496.462387; Tue, 08 Feb 2022 18:00:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHUmv-0007SF-94; Tue, 08 Feb 2022 18:00:25 +0000
Received: by outflank-mailman (input) for mailman id 268496;
 Tue, 08 Feb 2022 18:00:23 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TsJg=SX=epam.com=prvs=40387f30b1=oleksii_moisieiev@srs-se1.protection.inumbo.net>)
 id 1nHUms-00068L-Uo
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 18:00:23 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id fa8cc221-8908-11ec-8eb8-a37418f5ba1a;
 Tue, 08 Feb 2022 19:00:20 +0100 (CET)
Received: from pps.filterd (m0174678.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 218EgrT9015757;
 Tue, 8 Feb 2022 18:00:17 GMT
Received: from eur02-he1-obe.outbound.protection.outlook.com
 (mail-he1eur02lp2057.outbound.protection.outlook.com [104.47.5.57])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e3t5xrs6q-8
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Tue, 08 Feb 2022 18:00:17 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com (2603:10a6:102:ea::23)
 by VE1PR03MB5613.eurprd03.prod.outlook.com (2603:10a6:803:12a::29)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Tue, 8 Feb
 2022 18:00:13 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::c1c:f98:9dd:86e0]) by PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::c1c:f98:9dd:86e0%6]) with mapi id 15.20.4951.019; Tue, 8 Feb 2022
 18:00:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fa8cc221-8908-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=n/yYMu60zNdIqp3sIYHiLLxW1iQ/mMJaFpQBJySVIVjKMjBnhzHxjm54TPOJnd3ZPmFVnNT76N4UT0svt+78YJmj+8RBxO9dJ9iRxFP3rKZIWIwr0uBbAjgGbgQEnd37bVP+WaeJBGSSN9NjjqVDdLwIuGkih7cKK3UIb2by1ffvKgOcdcJvosNLDc6WNkrq+d4GU9R8Stp+3T9fXUTk1FhqENNvfHHK11ns2z7p9ubXN08loLkXw/AuTMw2/pAoOEfpoaI+MSxxAv4xfwfYIMKz/cxjhUypAEgPf5hM2vML8ib/kPl7xvuBIqXaCYOCSVW61zA5lte23YDD64CBYw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=oz8ls5jYpEH0zZ1iaWsjgXWp+zE0wyLWSst1sUoOmY8=;
 b=kU5YxXUpypTXS2Y6t5ar77Tg26uMcyuIAgFQfI9W8hC5HFQwNyNJB45Em15meaaelKZrG3uVBzqFrRnaHVFkc6JXsrKtjyxe4HyvmO2p0LxqufrAMbjOidziZb2Aemg78/YvogTJOblW6e4F/5IvSs9Qdb8mac8NBm2CT178kM1PKmIQDG12u2QlZJFFhXMTQ3VZ/96m400SbMQ1ixhtC+qEcO9/EAkYuCGqIlAgOfsmfKOFo1Rg6aIyPKi3VCC+oa1pFfBheefWd4shlxO/o7f4moswcqGqJKx20oc5poYPh9y3z2YnjgP//+3nkUgTMVzThvu+IExB9ucFhXKYQA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=oz8ls5jYpEH0zZ1iaWsjgXWp+zE0wyLWSst1sUoOmY8=;
 b=X+MsHsSczOmM7yw5IvGR0V8nO1anPEWIiCIV7Pk5vJqCuWEb4Paj5n/pSUD9PCEsLr+td6iDfu3/Vqh8STpjLKvrUUuApSGjSkvRxmZNpuFuWJjtiFuTMA+zGwq9vwqzbI1y7epa6PHyxLVrvoNdAYqt5qJ95fFGV2AKfiN9RUdBn1gPojbefyuK+MJr15ZhIzGc6qsBAy0/mK/5CVWMhfOyBR7/jr+Mm+WsdUd+42TZ8UPTkKnmZKv2ZwmtENWrvMkuCGisz2dAn5aCi7+Je62gxalZoamRKuou1qbFqjMF4koZ5eCTJr4Y7PWOlPA28B76lpNYWfF+RWe2ibNHag==
From: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>, Wei Liu <wl@xen.org>,
        George Dunlap <george.dunlap@citrix.com>,
        Nick Rosbrook
	<rosbrookn@ainfosec.com>,
        Anthony PERARD <anthony.perard@citrix.com>,
        Juergen
 Gross <jgross@suse.com>
Subject: [RFC v2 7/8] tools/arm: add "arm_sci" option to xl.cfg
Thread-Topic: [RFC v2 7/8] tools/arm: add "arm_sci" option to xl.cfg
Thread-Index: AQHYHRW421V3hDnhNU+uBIx9/PfKVg==
Date: Tue, 8 Feb 2022 18:00:13 +0000
Message-ID: 
 <e138c3ed5de18e7b2a423254f3b55c1a5f22c572.1644341635.git.oleksii_moisieiev@epam.com>
References: <cover.1644341635.git.oleksii_moisieiev@epam.com>
In-Reply-To: <cover.1644341635.git.oleksii_moisieiev@epam.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 7c86fd87-1051-4555-8660-08d9eb2cdb00
x-ms-traffictypediagnostic: VE1PR03MB5613:EE_
x-microsoft-antispam-prvs: 
 <VE1PR03MB56130BE078F452D001BC0F4BE32D9@VE1PR03MB5613.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:7219;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 CbIDa937LpIp4Ccm27Vusw4GZKDrT1VrjSsF3RQDM2BjY7MwjS+hTBbgbwW427+OIA8V3T0TLGomFsNhBmOE4gMR+fYmdCO97nan4Lvh/eLS8Pgr7vckkrtlq0M7e17Tr9FI4uqXdMmGrQLhTQmSNlKi3LLrQ9A/t/lvSaY8eq/vu5hCldLpPAU1wXFOsS2LnCl/SdZj/l5vHdC/YJc5K4nOeZ1xVJtvlJIqZod+gLKyqlXh6Oa5VTf3sF92rhFyb9eqFouW7tgxvfD3P38DpSvhTTfYfaaZGKfOQaqkm7IX2oPm9DlhZ1DeDtqYcFZQheS8RfZF65bpLt4VzXJlJYCtNZTB+dbVmmhvQ6xmz4hQM0vmx6HJLShJ7rkxmvhVq6NH91L5XuqERMnrfa/WiFBAz1oUqCTUvuDYP2Cno4DK/b6mJTJWJxJcH176vHXO90za7nN7Lo8/QS/Wvy+J4urPlxFASzs6eALbmvZBmdkwz8F7JS0u0hfsL1BLfCQNCti+jJGAYrIQbEUdQYL3HrNkec1LyBfX1H6/iGHzFQr4IXrnnMSfN4enqnLI42kI5mMHK9+ykUx5b5qvhTtAtAIipaxrAJTF6xDutjsoVbdISpGJ4ohGCILMklzzSx0at3Qn6Ln+w36WWSbpvgSXt3Iqd5yDJjrJ/zl0G5dc4tINb49VV3A+V7Bu0gISPrDQCled6fkQ3iRUOyfF5mZvKQ==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR03MB7136.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38070700005)(71200400001)(6486002)(508600001)(66476007)(64756008)(86362001)(66556008)(316002)(122000001)(6916009)(6506007)(2616005)(5660300002)(6512007)(4326008)(83380400001)(54906003)(2906002)(26005)(186003)(8676002)(76116006)(38100700002)(66446008)(66946007)(8936002)(36756003)(91956017);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?iso-8859-1?Q?TjbVxtzLqxZNS/MSNWTT5fjduI0TtmR5B4Yx3MNKLMIiNlZQx/wFlV6Z83?=
 =?iso-8859-1?Q?PgzvMb6SS3dZlqTy8UrYuEh44zw91KPmwV9zn2Rqo+uw09rp3WijSC3jjZ?=
 =?iso-8859-1?Q?uBtMyTs2MQ+/dm0QM+K/+K91vuLP2yNzNxkVNiu6Y9RZwnuqiOORqaVQ88?=
 =?iso-8859-1?Q?MpJ0f8ahMikD5FIhThq9uCDOebXFAHb8DHLp6oiEx8jhHY0Ht8Bpvl0Ape?=
 =?iso-8859-1?Q?5i1tNCWRDsbX+mX5M7gfwEkrCyQQ6sXXoKt12o/5qYZ5SNEv2ctMP/p2Od?=
 =?iso-8859-1?Q?v8sntBB+jrRJkazT3Es3jsYJ56fY9rupKFWvSKSClHf9PiWjd4mjX4kXJk?=
 =?iso-8859-1?Q?2fPECHxu9nm1PIQEHr4ELP6iLzJwJfMv3GC1wp2sMFzKO8hGiMUCKttWId?=
 =?iso-8859-1?Q?BByxnE9NoeX06l3YvQ6HRjtxPzq0iJDnaxav4q97xNN5lU8cpVZymExWcp?=
 =?iso-8859-1?Q?QvjfpJ/dwkWRZyG0i7BRX5v24nR36bHLE63anmvsms2yWGb63lji2HyYB4?=
 =?iso-8859-1?Q?W6kyLBLhoQ1Cw0UEMzPNAvN43N58B7ntSCcAjU5q6qyw3sDCjRRIygCzD2?=
 =?iso-8859-1?Q?yK5vkk3IjYrVWbZX5AJmIhESOD4gxji0BHyQOZRsF8AcTLSITdDOJ18jl/?=
 =?iso-8859-1?Q?VTG6C64eLlzict/mxDPUKwJGEAykwrT9lDNtJhsN9J4UnXMlLW/R+0SaO1?=
 =?iso-8859-1?Q?NiwmYY6ZvkAXh/wLQVOaou0wqwIvf+TRKkmvVaCHrKQfOHabYOUIkcmeol?=
 =?iso-8859-1?Q?EEs4IoKK4ZS8QJ1Qnadoyu3HleJXXoPOCMq7ApxxYBuRzpZNjagX2bIs7C?=
 =?iso-8859-1?Q?Vrtvfgo59AfmKH2vs1ky6p9btOxhdtPqLKKAk4cgQK7mFdmlbPUhjX48pA?=
 =?iso-8859-1?Q?ozvcffU761QdfOrOvWGfIbWIwuTTqbZblxtyFXTshaBrVr1uTMUw5O0v5c?=
 =?iso-8859-1?Q?XBFT0J5mN/0CS/y/qcRXQFg1vfdw2bcuK9eSPzq6TjCIRneZOP//SC03IX?=
 =?iso-8859-1?Q?uq7rPAJkaNJzLIMbklJPb6oJu3BrjgkJFJUg8XATuHnDwvDcpMbEoR+4Bg?=
 =?iso-8859-1?Q?Ft5dQIggHPdOSGUhF7sydjV5V7LluD3EmIKQHFH3ZDmJPCwET5cq0qOSNF?=
 =?iso-8859-1?Q?ZVWsJvfbytXRzFsJPN3xw8RUlY4pS9bWrgD8WnZQVephIT6SZulx6w/69t?=
 =?iso-8859-1?Q?4qXYUVnYB2htQk6z6fl8ZY4J6mZDh0UX8X6zslto/XW3JYMYYf68/Vb6OZ?=
 =?iso-8859-1?Q?o3fBceN6ojjRlTm5ZiSOFwCGEo64V4j/yYLNZQzFzCH/mks+vZG8D3K/IH?=
 =?iso-8859-1?Q?/MUBVdeMJk+29XGB9OWyg7WXIUkgDmVrDWKsCg4sASuvUmdF3FhAMQT3ug?=
 =?iso-8859-1?Q?4qX3GUcJPuydvwPUkpZJMKazypFUFBNbF3qFKYI26jNrkKem2TRpf6eDF/?=
 =?iso-8859-1?Q?/auB+FLWG/kj9TjpmtsHrca7zkCdN+x4xTqPbvDX7S2jSa8JomiiNN7ttd?=
 =?iso-8859-1?Q?UIATiRvjtLkuh5j95uwl5eKQ2nL153st4pW2Jg/9qSh2qeOpbWWinm9S4f?=
 =?iso-8859-1?Q?3E9JiDcqM+CC103SxYkE+d1tvYTzjpgX1NMP5duGqZrLv14qUmvAoyWnIe?=
 =?iso-8859-1?Q?HkT7foWOHVhf9z9aEQnToRAvcRW0a3mQbhWcOnqLKW+apnqJsHCwLQku1b?=
 =?iso-8859-1?Q?fWo/HxjkAfizp2bSNd/elUhdrTj7fUAK1G3Jr0NnjWfua3BcHO6YPKkU+U?=
 =?iso-8859-1?Q?sNdpK9AN/dtmzNGm7kL9Kz4nY=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR03MB7136.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7c86fd87-1051-4555-8660-08d9eb2cdb00
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2022 18:00:13.4188
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: SWz4WbBiq1w8dOgLA0CkLEWHTc2hMe5VjUbHhGRJk/6+7HKr8dyrMXgh+RKMYbbF+gnvpHfKnW+Z2dSYO7WbzvT1x3y2Qt2vdpKI3vjaKzA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR03MB5613
X-Proofpoint-GUID: wz6TY2sipT9sV7lH3pXo29mw_x7eIvka
X-Proofpoint-ORIG-GUID: wz6TY2sipT9sV7lH3pXo29mw_x7eIvka
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-08_06,2022-02-07_02,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 spamscore=0
 priorityscore=1501 clxscore=1015 impostorscore=0 adultscore=0
 suspectscore=0 malwarescore=0 phishscore=0 lowpriorityscore=0
 mlxlogscore=999 bulkscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2201110000 definitions=main-2202080106

This enumeration sets SCI type for the domain. Currently there is
two possible options: either 'none' or 'scmi_smc'.

'none' is the default value and it disables SCI support at all.

'scmi_smc' enables access to the Firmware from the domains using SCMI
protocol and SMC as transport.

Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@epam.com>
---
 docs/man/xl.cfg.5.pod.in             | 20 ++++++++++++++++++++
 tools/golang/xenlight/helpers.gen.go |  2 ++
 tools/golang/xenlight/types.gen.go   |  7 +++++++
 tools/include/libxl.h                |  5 +++++
 tools/libs/light/libxl_types.idl     |  6 ++++++
 tools/xl/xl_parse.c                  |  9 +++++++++
 6 files changed, 49 insertions(+)

diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in
index ddf82cb3bc..f960e367c4 100644
--- a/docs/man/xl.cfg.5.pod.in
+++ b/docs/man/xl.cfg.5.pod.in
@@ -1614,8 +1614,28 @@ This feature is a B<technology preview>.
=20
 =3Dback
=20
+=3Ditem B<arm_sci=3D"STRING">
+
+B<Arm only> Set ARM_SCI type for the guest. ARM_SCI is System Control Prot=
ocol
+allows domain to manage various functions that are provided by HW platform=
.
+
 =3Dover 4
=20
+=3Ditem B<none>
+
+Don't allow guest to use ARM_SCI if present on the platform. This is the
+default value.
+
+=3Ditem B<scmi_smc>
+
+Enables SCMI_SMC support for the guest. SCMI is System Control Management
+Inferface - allows domain to manage various functions that are provided by=
 HW
+platform, such as clocks, resets and power-domains. Xen will mediate acces=
s to
+clocks, power-domains and resets between Domains and ATF. Disabled by defa=
ult.
+SCP is used as transport.
+
+=3Dback
+
 =3Ditem B<force_assign_without_iommu=3DBOOLEAN>
=20
 If set, Xen allows to assign a devices even if it is not behind an IOMMU.
diff --git a/tools/golang/xenlight/helpers.gen.go b/tools/golang/xenlight/h=
elpers.gen.go
index 664933bbb8..6cf7725735 100644
--- a/tools/golang/xenlight/helpers.gen.go
+++ b/tools/golang/xenlight/helpers.gen.go
@@ -1091,6 +1091,7 @@ if err :=3D x.DmRestrict.fromC(&xc.dm_restrict);err !=
=3D nil {
 return fmt.Errorf("converting field DmRestrict: %v", err)
 }
 x.Tee =3D TeeType(xc.tee)
+x.ArmSci =3D ArmSciType(xc.arm_sci)
=20
 if err :=3D x.ForceAssignWithoutIommu.fromC(&xc.force_assign_without_iommu=
);err !=3D nil {
 return fmt.Errorf("converting field ForceAssignWithoutIommu: %v", err)
@@ -1439,6 +1440,7 @@ if err :=3D x.DmRestrict.toC(&xc.dm_restrict); err !=
=3D nil {
 return fmt.Errorf("converting field DmRestrict: %v", err)
 }
 xc.tee =3D C.libxl_tee_type(x.Tee)
+xc.arm_sci =3D C.libxl_arm_sci_type(x.ArmSci)
 xc._type =3D C.libxl_domain_type(x.Type)
 switch x.Type{
 case DomainTypeHvm:
diff --git a/tools/golang/xenlight/types.gen.go b/tools/golang/xenlight/typ=
es.gen.go
index 2f7a088c3b..3b5c959215 100644
--- a/tools/golang/xenlight/types.gen.go
+++ b/tools/golang/xenlight/types.gen.go
@@ -443,6 +443,12 @@ TeeTypeNone TeeType =3D 0
 TeeTypeOptee TeeType =3D 1
 )
=20
+type ArmSciType int
+const(
+ArmSciTypeNone ArmSciType =3D 0
+ArmSciTypeScmi ArmSciType =3D 1
+)
+
 type RdmReserve struct {
 Strategy RdmReserveStrategy
 Policy RdmReservePolicy
@@ -512,6 +518,7 @@ NestedHvm Defbool
 Apic Defbool
 DmRestrict Defbool
 Tee TeeType
+ArmSci ArmSciType
 ForceAssignWithoutIommu Defbool
 Type DomainType
 TypeUnion DomainBuildInfoTypeUnion
diff --git a/tools/include/libxl.h b/tools/include/libxl.h
index 2bbbd21f0b..30e5aee119 100644
--- a/tools/include/libxl.h
+++ b/tools/include/libxl.h
@@ -278,6 +278,11 @@
  */
 #define LIBXL_HAVE_BUILDINFO_ARCH_ARM_TEE 1
=20
+/*
+ * libxl_domain_build_info has the arch_arm.sci field.
+ */
+#define LIBXL_HAVE_BUILDINFO_ARCH_ARM_SCI 1
+
 /*
  * LIBXL_HAVE_SOFT_RESET indicates that libxl supports performing
  * 'soft reset' for domains and there is 'soft_reset' shutdown reason
diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_type=
s.idl
index 1080966c33..1878c115c3 100644
--- a/tools/libs/light/libxl_types.idl
+++ b/tools/libs/light/libxl_types.idl
@@ -480,6 +480,11 @@ libxl_tee_type =3D Enumeration("tee_type", [
     (1, "optee")
     ], init_val =3D "LIBXL_TEE_TYPE_NONE")
=20
+libxl_arm_sci_type =3D Enumeration("arm_sci_type", [
+    (0, "none"),
+    (1, "scmi_smc")
+    ], init_val =3D "LIBXL_ARM_SCI_TYPE_NONE")
+
 libxl_rdm_reserve =3D Struct("rdm_reserve", [
     ("strategy",    libxl_rdm_reserve_strategy),
     ("policy",      libxl_rdm_reserve_policy),
@@ -564,6 +569,7 @@ libxl_domain_build_info =3D Struct("domain_build_info",=
[
     ("apic",             libxl_defbool),
     ("dm_restrict",      libxl_defbool),
     ("tee",              libxl_tee_type),
+    ("arm_sci",          libxl_arm_sci_type),
     ("force_assign_without_iommu", libxl_defbool),
     ("u", KeyedUnion(None, libxl_domain_type, "type",
                 [("hvm", Struct(None, [("firmware",         string),
diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c
index 67fa96d949..d53c9b1271 100644
--- a/tools/xl/xl_parse.c
+++ b/tools/xl/xl_parse.c
@@ -2747,6 +2747,15 @@ skip_usbdev:
         }
     }
=20
+    if (!xlu_cfg_get_string (config, "arm_sci", &buf, 1)) {
+        e =3D libxl_arm_sci_type_from_string(buf, &b_info->arm_sci);
+        if (e) {
+            fprintf(stderr,
+                    "Unknown arm_sci \"%s\" specified\n", buf);
+            exit(-ERROR_FAIL);
+        }
+    }
+
     xlu_cfg_get_defbool(config, "force_assign_without_iommu",
                         &b_info->force_assign_without_iommu, 0);
=20
--=20
2.27.0


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 18:00:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 18:00:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268492.462338 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHUmo-0006CC-OB; Tue, 08 Feb 2022 18:00:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268492.462338; Tue, 08 Feb 2022 18:00:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHUmo-0006B9-Hq; Tue, 08 Feb 2022 18:00:18 +0000
Received: by outflank-mailman (input) for mailman id 268492;
 Tue, 08 Feb 2022 18:00:17 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TsJg=SX=epam.com=prvs=40387f30b1=oleksii_moisieiev@srs-se1.protection.inumbo.net>)
 id 1nHUmn-00068L-ED
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 18:00:17 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f6c000f5-8908-11ec-8eb8-a37418f5ba1a;
 Tue, 08 Feb 2022 19:00:14 +0100 (CET)
Received: from pps.filterd (m0174678.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 218EgrT3015757;
 Tue, 8 Feb 2022 18:00:13 GMT
Received: from eur02-he1-obe.outbound.protection.outlook.com
 (mail-he1eur02lp2057.outbound.protection.outlook.com [104.47.5.57])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e3t5xrs6q-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Tue, 08 Feb 2022 18:00:12 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com (2603:10a6:102:ea::23)
 by VE1PR03MB5613.eurprd03.prod.outlook.com (2603:10a6:803:12a::29)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Tue, 8 Feb
 2022 18:00:07 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::c1c:f98:9dd:86e0]) by PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::c1c:f98:9dd:86e0%6]) with mapi id 15.20.4951.019; Tue, 8 Feb 2022
 18:00:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f6c000f5-8908-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jK2NgxUrslRzWeTpvLeTDGIt5K8UoM/KgoaY35I8p6o4UQlvj1aZ2iKi4bJGbCSRUmwJ3oaHzccn8Lr5GIW+YxcjL68rFVAQ4XwERbQhJcmLmM2jhbgaHqscKLHDdO2MyGu/KjvECTPwqrkIHsOXs6efvi5MqtXHkI2zYDtAMt2Ts0dVAbMA4SmKGwpbmIqCDvAX4ftUsqN5T6BVcGKdd3GOXcOjZAlww+Mw9nPRgVnp8Z4BmM3dZ/5Ho+CAEihm2OxWt6/myc+N8ks103SlvzzVn8G2ZiF6jQo1mswzdtdkQJx6yth2UQbuLe9V07t4y0NE0pSvUcLfaGAdfcnnVQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=s+Pd6wDqIcFv+WQby17OvQO3c7K+c3WVoYLWvGL3Img=;
 b=OaIqooaCQ48+ZcNhTZy3IOTwfIbDqjVskgGKEOAEh6F5zg+WvHi4932WuJDLOuUpsWo9V/ccBodoy6pT7hiIYcVB5YnFZdrI+CPIM+6FO7cIodMZ6ecB50/RqZN2X3geuyy1aIEXxjvJLKo4qnK+eS7Iry3oMt/LD40nLVqDC7ValgN2o5rieTR4IO0tdLyKUgEP2f3Qe4D/37Ea2WHqANz0Kz7c8iVHG6durJ8rzoP9lMjE2BXpzo9b6NHkBSjL3c3Z8PynXqQ9vHc90A2YI7+3BK5HCjdb5TrQ+M8wNNSXTqUAAp/1AsvdcPWkhB3elnr+32TANfllBvP0wgYEZg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=s+Pd6wDqIcFv+WQby17OvQO3c7K+c3WVoYLWvGL3Img=;
 b=NKRI602rr+89pwZBu1o2KxvfP8dZTc3kYH6jB0oXp278uzs677VAHqCv6/SCR772ky+ak+NZ8CQv7jSgErHpMbrSZvWqR7L9Jg+/C5GuVsg9Rl3m+OfF2MxzW87CoMqwEXNgcnh6m6JbTwVOXU5+QCk8crXq3m3yNYdGYsFPUZRx3fmfLGu00FHFKXP7/le2xUK56rrwxtNVtMAWRyuPL0BBF2C5xCWJHMls1KRL3zFmJt/xz73TcubRkUqivD3od3NxBsIofFr52VaCMtJQaUwRFzLdqnG6BpkyXQ8nXlc/28TuPpnMHLsdi7yRWr3PiMjOBuBl+7JLr4e00MbREg==
From: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>,
        Juergen Gross
	<jgross@suse.com>, Wei Liu <wl@xen.org>
Subject: [RFC v2 2/8] libs: libxenhypfs - handle blob properties
Thread-Topic: [RFC v2 2/8] libs: libxenhypfs - handle blob properties
Thread-Index: AQHYHRW0gTNwRxUA1k2bknae2DocAw==
Date: Tue, 8 Feb 2022 18:00:07 +0000
Message-ID: 
 <069eb801bc999ea85c529fa5033121e96b9df06f.1644341635.git.oleksii_moisieiev@epam.com>
References: <cover.1644341635.git.oleksii_moisieiev@epam.com>
In-Reply-To: <cover.1644341635.git.oleksii_moisieiev@epam.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: d5209da9-18ed-42a0-e3ca-08d9eb2cd786
x-ms-traffictypediagnostic: VE1PR03MB5613:EE_
x-microsoft-antispam-prvs: 
 <VE1PR03MB56131C6D949B57ABFDCFB743E32D9@VE1PR03MB5613.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:5236;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 P7TW0UFCVr6XYzH45vY4lkwUMvmuQkNRNnz/bpFB9QYbMTMHuQ7wHnjDEpNF49tF+0YTlP/aKQjYK6W+JjM+Y+aR3bmQ2yY2GWhxAdWWihqmL0mANMKO6zaDCnHpkUNzd4SiZ4e0Y4c7Bmrr42uGU31oNU6VCPsoL5VGez00bUaRxgfofr3tG7JbRgfZaLYqhhqp6it6aSUnGu1DdwgRX0N0j0TOsM+uD+S3pD0mbt7xPc9C56LoerOZgz+vNYlt0ymwgd3zdYPdSb8S9q6wQ/Vc37QnJpD29UILf1NkQ0JIyitWc/tsHq9kkWGV0E3c/gMPwkdlktOxsFSrUCjLssZPkpJuWYEoI6XPwULiE8ZeM1Y8YeeQTTNG3iIWSHAaclUqHKK1z2bmKBE62RQALisvn+16ALWOKybAfa7nX/92LjPnMksNA1GpAzo0PbXWYNgB9SkfkSg1fHkl3b8C6m7xKSK9mJUpzaaDs5YRLMNwgoS9vyqcBijFpS+oPjwtjv/WRmBnRmFkMzrNG8xdk29qryFvYpXSAVQzmlcWizGeknQablPHi4bAn82LypzJg/bNMRy/hvsX0GUDgkkbVmGyuTgYy4tTWKX6dkEOnTMpLAvzMxKke3IQacl7H3NU+8NAIJVLOf2JBaPNrQcOZyEIzNn8ffOw1GLzUC4HGSeqC6hinp2LrnzYz/h4Hi2s0zpNq4e+0UsuiRI1r7/33A==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR03MB7136.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38070700005)(71200400001)(6486002)(508600001)(66476007)(64756008)(86362001)(66556008)(316002)(122000001)(6916009)(6506007)(2616005)(5660300002)(6512007)(4326008)(83380400001)(54906003)(4744005)(2906002)(26005)(186003)(8676002)(76116006)(38100700002)(66446008)(66946007)(8936002)(36756003)(91956017);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?iso-8859-1?Q?LvvhPleD4XcuZ6FqzOy/tU6O3SeYh08wd7gkaw0UYP7HST1DluQeMBwcsd?=
 =?iso-8859-1?Q?VK5XIRVPAojBQo5fJuMzddIDf2li3Y7dN9nJlFuxzPOKZvHlVs5odutLMX?=
 =?iso-8859-1?Q?VAhbIodQwgOh3/iIbCQ4fGYwS41mhdmz2gk1C3NGs3Vr5JstgP3jylxHKD?=
 =?iso-8859-1?Q?1HPNV2eM2lhdV5b43irrof4BQWRcy82U6Ry4MGPuLRCSIFSEfRsRwi2cRB?=
 =?iso-8859-1?Q?qgI9cNNckXWVOPLrlGG2Et5wdNmNHR3h7OjQQ2y5IEAavHQ5vJBVRb+MeR?=
 =?iso-8859-1?Q?CpPbFEHbVgmRy61pzLFjLOtGCnGkyrFKJMIzDLVvKbU8v0RxhEpzcTNAC+?=
 =?iso-8859-1?Q?s4SSL1SiUSdQQ6sljXiEuDvLmjmKuImjxtflTOkgS1H8W4rCVc184ysvJ3?=
 =?iso-8859-1?Q?pfPISH1tEwoY3T1BhOWBseaffH+4vuAiIM1y02IOEXsCRkpueqvUXAwWkR?=
 =?iso-8859-1?Q?AR7fvrwgaCoAfdI4RBkEJUZP5VAsj25kjgneEkAzceebL77aEjLYk8u+33?=
 =?iso-8859-1?Q?qGrGAO+8cTgavvo7/WoIOlo/44ZllNnl6RlzjIe58mCb3cKoZukgMbSxPN?=
 =?iso-8859-1?Q?MKp2VbF3GiUd0BOdbm9146fm68/78zzq5IoX87pw/9EDqz8NY2XkVsCG2J?=
 =?iso-8859-1?Q?pKn5oD3w4e/+yg/mhd+V7c3lMf4NDySkLgIlxc/YLVc2uyG8TdQ4b3tdsi?=
 =?iso-8859-1?Q?fuLAIBYI4DCUOq+RrQQLOkP/0LJZYU3iOW0YMutU04rFZzfgNUsh1ZSQVO?=
 =?iso-8859-1?Q?61/JCrGPpkXD9Re9upLGgW2sNHsf97HiOs+N8f0V8AVQjun06cJdTwnLwt?=
 =?iso-8859-1?Q?yn1H+jnPiED4hgGwbc1XQgYuVNWIn73BmS0E4jx1CtdcaVEBgVvU3a6fVH?=
 =?iso-8859-1?Q?u6Xlsz/EYEtZKP18EMr982kmwWqSDluCAjZVnSBGGeJRisNpJNdKwVZCtm?=
 =?iso-8859-1?Q?EssnlOormJVhdVQTfaVS5sAU8zILb9tCgBYEgT8Wxp5N63+NsIehBP49Ab?=
 =?iso-8859-1?Q?Q4HXNQ8ea6zuR4/BzrL7kZyo7HhOamxa+QVlVsv19TIvbWn7eHUjKgTc7m?=
 =?iso-8859-1?Q?TGoC8vSQIRWFfDvxkhrPt1qnFMTp7UMcPCbah89JzeYyLFahHTsvvcFJsR?=
 =?iso-8859-1?Q?WHHi0xsbCk48O+vvAm/jj9L7saUa9XA+38Pidtx+c1/r0VIROOwL/YAlqL?=
 =?iso-8859-1?Q?SFFhWqU8jx6CUwKx2Ho68Ba5XSWXa8x8LqDAcvVJHop/85yX+huYUJXaLb?=
 =?iso-8859-1?Q?xs7vwTlv6FKnaYvUx2iRt0j5ZCJMCQ2+175UM4fNlsINjPvxPCc0K9FCiS?=
 =?iso-8859-1?Q?qUQ3Ac9rmqTWExg8yAKRyy778GuLcBtVHWi8wddHhgvZrOY7ZdhAIJzdW5?=
 =?iso-8859-1?Q?m1nwCcEMhJMDirU6F8ls1rmEXqhhZPRwsEQgcqM5J4yTgk42HGZH5eQ5zn?=
 =?iso-8859-1?Q?gBoyrXTjPek+d4Uu87JgK03IcziJA0ZhkE06CTK9/Zc9RBNAn43YItIX0C?=
 =?iso-8859-1?Q?pxyrn4iDVCo4loio7LuZWSVQE9l56GtO/t5d36uSV09L3ro3L2zIE3CwGx?=
 =?iso-8859-1?Q?4jjlRPCMko/HFzbzlpm4Nz1qCeVYUC8lf88wtjp17rxFftS1IYx9UJ71fs?=
 =?iso-8859-1?Q?DPtOhVcyCeiMOwiy5Jxe2fADV1Kf0+9RycrOsN0MNYft3T9zw/1YXj7tT+?=
 =?iso-8859-1?Q?mm+YHXBela8wqB1vFXTfNABWcCfozrfij4r+cfkAo+/3LVkxn1o747nKS9?=
 =?iso-8859-1?Q?VqBhyGnDXMPHQ6HBzhE7ynnLg=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR03MB7136.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d5209da9-18ed-42a0-e3ca-08d9eb2cd786
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2022 18:00:07.5727
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: K+t9JbjMlj32GLMoocgkFrLadeNOO/AALJ2g91HJJm7hjH8uS8hwxHO9SUanaIcx2dOn1qmdjaJuzSTy23qeleYPOfAjDSHv0rU+fUQK/Mk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR03MB5613
X-Proofpoint-GUID: Yrdh4-iaXSekn28dL7blLXf5-oqSC9QH
X-Proofpoint-ORIG-GUID: Yrdh4-iaXSekn28dL7blLXf5-oqSC9QH
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-08_06,2022-02-07_02,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 spamscore=0
 priorityscore=1501 clxscore=1015 impostorscore=0 adultscore=0
 suspectscore=0 malwarescore=0 phishscore=0 lowpriorityscore=0
 mlxlogscore=740 bulkscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2201110000 definitions=main-2202080106

libxenhypfs will return blob properties as is. This output can be used
to retrieve information from the hypfs. Caller is responsible for
parsing property value.

Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@epam.com>
---
 tools/libs/hypfs/core.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/tools/libs/hypfs/core.c b/tools/libs/hypfs/core.c
index 52b30db8d7..d09bba7d8c 100644
--- a/tools/libs/hypfs/core.c
+++ b/tools/libs/hypfs/core.c
@@ -307,8 +307,6 @@ char *xenhypfs_read(xenhypfs_handle *fshdl, const char =
*path)
         errno =3D EISDIR;
         break;
     case xenhypfs_type_blob:
-        errno =3D EDOM;
-        break;
     case xenhypfs_type_string:
         ret_buf =3D buf;
         buf =3D NULL;
--=20
2.27.0


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 18:00:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 18:00:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268495.462375 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHUmt-0007BO-Tn; Tue, 08 Feb 2022 18:00:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268495.462375; Tue, 08 Feb 2022 18:00:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHUmt-0007BF-Q6; Tue, 08 Feb 2022 18:00:23 +0000
Received: by outflank-mailman (input) for mailman id 268495;
 Tue, 08 Feb 2022 18:00:22 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TsJg=SX=epam.com=prvs=40387f30b1=oleksii_moisieiev@srs-se1.protection.inumbo.net>)
 id 1nHUmr-00068L-Uj
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 18:00:22 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id fa4697a8-8908-11ec-8eb8-a37418f5ba1a;
 Tue, 08 Feb 2022 19:00:20 +0100 (CET)
Received: from pps.filterd (m0174678.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 218EgrT7015757;
 Tue, 8 Feb 2022 18:00:16 GMT
Received: from eur02-he1-obe.outbound.protection.outlook.com
 (mail-he1eur02lp2057.outbound.protection.outlook.com [104.47.5.57])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e3t5xrs6q-6
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Tue, 08 Feb 2022 18:00:15 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com (2603:10a6:102:ea::23)
 by VE1PR03MB5613.eurprd03.prod.outlook.com (2603:10a6:803:12a::29)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Tue, 8 Feb
 2022 18:00:12 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::c1c:f98:9dd:86e0]) by PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::c1c:f98:9dd:86e0%6]) with mapi id 15.20.4951.019; Tue, 8 Feb 2022
 18:00:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fa4697a8-8908-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=h2KNhFxlgCVQ3hz6aHDPUNPiLYciaW/Wx82wVBnPSTn9Glspe4Pvd752Yhup5TeOWcEarzDyeZ8JH+S9nLgSfODgcCeuXYnE/pm/3TP68wgaXif26CW9PGeHXpil9dBdE+Y+ksydH8sO2MUg07mCqpnQ6ku/kKKkClNX0z8BqQodUK4Ax4HL2+SdIv688PiQkyWkGoR84mg2aYba18FflVp75FCmVzmRFYq3BCXdB9Kk66wM6lNw6JAEq/uNB6AlCKRNvLSgeqKPOIMvcIO4yDtfQcZlKpVsppn5tghhbGNDTdX/8qa62BEzlJubYRqQqnM8m0dcU5Aq5EpxU1BBEg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=HALhPv+64kbkAOfpSs3FqZOqYi5IDheOGLf5PgXphVE=;
 b=ccvM4G7+MTrS7txnx2sAe5VH+pF/x2c/AzFZz1U6sVlCWvmGc+kPWEYtWT5l1h5kD4jEzUPfy9JiyLraxAqIFHOANtGq7UJsUF+551WYEDKsiyBPFW1DdYJAqwUYbTgcHF5zAKYtBzU85KFcYbYD6dnCg+uEsNF8RFk1smy5K8FuO/dmrN3/L6CTV9ofMJz0IXDiINl6MZhXfzkURBUv/2YpgnL9HaUdrHWEcv4WRREwHZrhAKcr3aSqAN+2rKpcRQ9uW0/CyrD9aFwE5ejiSWvKOchkxINP8jKSzpRsBpJnXNOrojeZ3mNiNenxY7sRudlw83bV/IThXVtcsA07Rw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=HALhPv+64kbkAOfpSs3FqZOqYi5IDheOGLf5PgXphVE=;
 b=ieLdGr4y1e7909uSLGz0HjamxFFs996NCd0HBilnPNN3C4vpjB8MWumuTRXf7qf0BAMKkOoDQHabEX9cZWJW7tSqcGXopofHS4nVPtRiEhYFduhpTO6b752KBb7plNHPJAuGp0lW/0RZaqjnrC2zswJtLC30tSZvzqOhU3Ba7W4V1GdmX4ueU2YugSEBX4BJkjHulIifGYOFhZ+se6BshIXAYIzEFDlY1PEdj56z5qKAIOU1jBCfAbBmaoUjr+r/p86XyOhQr+l1L2jnHt+gVPnAYCUX+NBOb/w78rHPxf3mocV8P3vLmTKC+sU4+SWlFUobNpTRbZg0Xz+gt4vOiw==
From: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>, Wei Liu <wl@xen.org>,
        Andrew Cooper <andrew.cooper3@citrix.com>,
        George Dunlap
	<george.dunlap@citrix.com>,
        Jan Beulich <jbeulich@suse.com>, Julien Grall
	<julien@xen.org>,
        Stefano Stabellini <sstabellini@kernel.org>,
        Nick Rosbrook
	<rosbrookn@ainfosec.com>,
        Anthony PERARD <anthony.perard@citrix.com>,
        Juergen
 Gross <jgross@suse.com>, Paul Durrant <paul@xen.org>
Subject: [RFC v2 6/8] tools/arm: Introduce force_assign_without_iommu option
 to xl.cfg
Thread-Topic: [RFC v2 6/8] tools/arm: Introduce force_assign_without_iommu
 option to xl.cfg
Thread-Index: AQHYHRW3O86755dYV0qSgPdVO9oeMQ==
Date: Tue, 8 Feb 2022 18:00:12 +0000
Message-ID: 
 <d333126d12f2281f8df92e66cfba1c9eb2425dca.1644341635.git.oleksii_moisieiev@epam.com>
References: <cover.1644341635.git.oleksii_moisieiev@epam.com>
In-Reply-To: <cover.1644341635.git.oleksii_moisieiev@epam.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 1406799b-d4c3-4d19-7fe5-08d9eb2cda71
x-ms-traffictypediagnostic: VE1PR03MB5613:EE_
x-microsoft-antispam-prvs: 
 <VE1PR03MB5613836C8024C6A467271A41E32D9@VE1PR03MB5613.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:2733;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 593+KpeE3vja2YgkOiTpjRnUJLKsUnuEshoh2Z+V4mqsiSo09+3zRaS1Vrpv8dZ1iF/MqnsrWN/6uJj3IPvFXeyHgMPPFhyLjYLtQdCHGvz3x5MiTEdThKVlcsWcAOBYCm70PN/BkdRouDMixd5PCS6IYkW6v0vjahDLiDE9ZZwKve/jGlk2h7pfJp6pgQ3x5deUnaR+GPL7KbZsW53Jre8is0NkCBSmdLjMjk0FXgej+AILfM8vZFYtTPg23/1ci2UDpCHDNLGlWw/rIPAsYNvNyIXnLKKQDX5LVvQ09PhoGojoAHPRVhrbaCXc/l93tIS1rMB2FEc/lJruP+iKuym+aaruKVbACuzf4dVe98myH+NmviMnY3WtQ7EaDurHQvEz7xd7LZX30lJE9LbMVziWg2Jycy3yyIGOFNrff7HgxmMc4F4OBJFidDNLokEjZyBS3hU/GlkvugonmB/eXwyAouXPctx4J6XtcUnhOls9BBKDwNgun5ZY9DroINfjiWFDy8hq1Xjcm/eKoMVBsFovONlsF88xcVB5UJLSV8Cs2tGeOepWnfYDHEOXzi595m3+Y2qsHkCBbtXSDTK9nEcY7SW/nWEOMdBqzEs7nrThcYj63kObyzkok3T/66q3MddGajmE+q9iww35HLMfC8Aoyfhfrt9HIfGHyg+iOUjaAJXJXp5EHL2oNK11D/wzlvO8BRKM9VsrZijYDtwKSw==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR03MB7136.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38070700005)(71200400001)(6486002)(508600001)(66476007)(64756008)(86362001)(66556008)(316002)(122000001)(6916009)(6506007)(2616005)(5660300002)(6512007)(7416002)(4326008)(83380400001)(54906003)(2906002)(26005)(186003)(8676002)(76116006)(38100700002)(66446008)(66946007)(8936002)(36756003)(91956017);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?iso-8859-1?Q?H5luS7cGOqtky8dqBSfDdIBF46ch9LNqepgA9GrqaX4ojMAXig0k8+s4qo?=
 =?iso-8859-1?Q?f5lKGI9tUPDokXwTEGqrRhc2ZBpIKSOO2/P560SJXgreqWgV27tF0ReiU1?=
 =?iso-8859-1?Q?+qF9up8uSuYejI2F8a0sO9Zv6AxP3ijoB8mrmZ/VsCw68+c/tSmyEeHezX?=
 =?iso-8859-1?Q?ib09zKso5FC5Aa8vibGerdJVaaz9MmIr5TjbxzQJ4llz/Y2GOk5Bx8gyLN?=
 =?iso-8859-1?Q?2cxMhw/FQF2HTsHrtKW8spAgwjJNYhHAotUKsZBNxbgsvqUak67wtc3VFX?=
 =?iso-8859-1?Q?x1TCx+H7WEkSfH5Vs3SoGdOvEVqIWsEgh6O61XSPNO3IC9prDEbqFLKECo?=
 =?iso-8859-1?Q?MaiTb2NvgBgFoK+EcBSvVBr4Q4CEIdUQ3CehkEcW22ruuLu6bADw7Ourfy?=
 =?iso-8859-1?Q?uIaTITO97i8FtNa39qQJ8G/IoxF4nwU03NMfn5z/6tJaelToWW0c06rfkG?=
 =?iso-8859-1?Q?1t2dKwIdKNgulenR6CNB+lMNb6PSW4KeZpcnUVsjtMo7Z1rqihaAxx/D3P?=
 =?iso-8859-1?Q?6mBf5iV/sukO9xCu/VSkSMnUaIhEXphzPaIVHkHc6HHfbJCjZy5xDDcqf9?=
 =?iso-8859-1?Q?ZwADwtD66UiXcZe/oVJtQGyaN5258jhSDzDcDGRnmHl0N0uEOQlHhb/zbl?=
 =?iso-8859-1?Q?sUBQaAGZRlpdvlbuJbN8Myp6UovCN5VctfPlJmbQPAHp+M5BE6RO0EQaCx?=
 =?iso-8859-1?Q?+Im/m1o+VHxofRcAKlbaUZnKb/X4tXjpl5S2kcSrRXddJza2hmXPaZaPmu?=
 =?iso-8859-1?Q?o/douwHmz2iK5LO8aCFNy67JzrnG1UUJB/+9d5dtJfDb9Q5eXAoNuvZKVp?=
 =?iso-8859-1?Q?lEHt2Fq7+w5NRDVZnEbpSLkDBV6AwfYnU0CR6kQrYKut7BIULwCk+D7b+Z?=
 =?iso-8859-1?Q?fuwr77PA62dO+U9UJviqXtYIEX+ROh9Pp87puCa8M0KAHuYuTua/oh7Shr?=
 =?iso-8859-1?Q?2HpC8Z/mUq7gMG2edV07HWNE+AaYGFSSXKo7mycjJwn2w+z6dM+VVbcSFT?=
 =?iso-8859-1?Q?d/auZ/4pDKBctfoO9tkZU2rPN5tjwdnoFWNyKu48bnlvJk6BwNpksZDK+v?=
 =?iso-8859-1?Q?QZaMTgJMoBA4HMLj989wUEK+10FJ2B9R8wfJ6CggN13udtavg7XZq5j9nn?=
 =?iso-8859-1?Q?ab1tKkS7GSn54N9SVnKPMyM6sr2JJQt+wvV115FFS71vchWfq1dE00dBAT?=
 =?iso-8859-1?Q?2s4wbDT3+vRzGM6Ws2BheIoql9OqOdmxbHqCOceS/4XA3PwMun56ytPN0i?=
 =?iso-8859-1?Q?4AOsTvQUcRGCGaCWhoje2F1GeePOgoFVCYQiLIjWCMUljubHbWh5CUHbDa?=
 =?iso-8859-1?Q?NOhuLPmvKiQ13AhvBX/nczL7sJ3KjAgWxVa10NdKwQs2L4sx+COje5FPsz?=
 =?iso-8859-1?Q?hxS5hl61VR8utIanAezbLu/SCv4omYchkh9jU2lVbBxdprOsC0V4C3Elll?=
 =?iso-8859-1?Q?TtaXvbzCZF2VCvgcbk+YYDwZEmI2jLq0jXINdRulSET2eJg9akGcOO4Sgc?=
 =?iso-8859-1?Q?LgK2xh7NUGvKZ9eS8YqFZfGUC8tgVByzxa9iLzfgHmgREV2dSc+s2ic+mP?=
 =?iso-8859-1?Q?BAAzWx9+6ORWxRpX5Wnpc9lJdPlL4A8/s7KWFi/TQb5g53HCJpn+s2ep2v?=
 =?iso-8859-1?Q?56INYeOXeg2/paMEIgURJsTJYfvRkuu3FbZzSibmroOAVcVsPi5CFgtFrc?=
 =?iso-8859-1?Q?XpXJS/MPfRNIino0QqhCITWz8X1Oqe2SOabs/Idumn9HLtJdwiJAqz1tZy?=
 =?iso-8859-1?Q?20zcihE3kJaDurxmiq2s2QCDo=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR03MB7136.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1406799b-d4c3-4d19-7fe5-08d9eb2cda71
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2022 18:00:12.4970
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 5DOSt7gwUuwIgKy6ZRyHgGtHxhKXNGVsOzC7tpi3/KuMPnoQfP0vUyJNjT1bel8QlNHtM6Avhi8jw+8ypNYye3goNyRILoMTWNdhNh7rJAA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR03MB5613
X-Proofpoint-GUID: bzJlSQfioNgt_-ErlNy4ipphN0IvOoPY
X-Proofpoint-ORIG-GUID: bzJlSQfioNgt_-ErlNy4ipphN0IvOoPY
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-08_06,2022-02-07_02,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 spamscore=0
 priorityscore=1501 clxscore=1015 impostorscore=0 adultscore=0
 suspectscore=0 malwarescore=0 phishscore=0 lowpriorityscore=0
 mlxlogscore=999 bulkscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2201110000 definitions=main-2202080106

If set, Xen is allowed to assign the devices even if they are not under
IOMMU.
Can be confugired from dom.cfg in the following format:
force_assign_without_iommu =3D 1

This parameter has the same purpose as xen,force-assign-without-iommu
property in dom0less archtecture.

Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@epam.com>
---
 docs/man/xl.cfg.5.pod.in              |  9 +++++++++
 tools/golang/xenlight/helpers.gen.go  |  5 +++++
 tools/golang/xenlight/types.gen.go    |  1 +
 tools/libs/light/libxl_arm.c          |  3 +++
 tools/libs/light/libxl_types.idl      |  1 +
 tools/xl/xl_parse.c                   |  3 +++
 xen/common/domain.c                   |  2 +-
 xen/drivers/passthrough/device_tree.c | 19 +++++++++++++++++--
 xen/drivers/passthrough/iommu.c       |  5 ++++-
 xen/include/public/domctl.h           |  5 ++++-
 xen/include/xen/iommu.h               |  3 +++
 11 files changed, 51 insertions(+), 5 deletions(-)

diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in
index b98d161398..ddf82cb3bc 100644
--- a/docs/man/xl.cfg.5.pod.in
+++ b/docs/man/xl.cfg.5.pod.in
@@ -1614,6 +1614,15 @@ This feature is a B<technology preview>.
=20
 =3Dback
=20
+=3Dover 4
+
+=3Ditem B<force_assign_without_iommu=3DBOOLEAN>
+
+If set, Xen allows to assign a devices even if it is not behind an IOMMU.
+This renders your platform *unsafe* if the device is DMA-capable.
+
+=3Dback
+
 =3Dback
=20
 =3Dhead2 Paravirtualised (PV) Guest Specific Options
diff --git a/tools/golang/xenlight/helpers.gen.go b/tools/golang/xenlight/h=
elpers.gen.go
index b746ff1081..664933bbb8 100644
--- a/tools/golang/xenlight/helpers.gen.go
+++ b/tools/golang/xenlight/helpers.gen.go
@@ -1091,6 +1091,11 @@ if err :=3D x.DmRestrict.fromC(&xc.dm_restrict);err =
!=3D nil {
 return fmt.Errorf("converting field DmRestrict: %v", err)
 }
 x.Tee =3D TeeType(xc.tee)
+
+if err :=3D x.ForceAssignWithoutIommu.fromC(&xc.force_assign_without_iommu=
);err !=3D nil {
+return fmt.Errorf("converting field ForceAssignWithoutIommu: %v", err)
+}
+
 x.Type =3D DomainType(xc._type)
 switch x.Type{
 case DomainTypeHvm:
diff --git a/tools/golang/xenlight/types.gen.go b/tools/golang/xenlight/typ=
es.gen.go
index b1e84d5258..2f7a088c3b 100644
--- a/tools/golang/xenlight/types.gen.go
+++ b/tools/golang/xenlight/types.gen.go
@@ -512,6 +512,7 @@ NestedHvm Defbool
 Apic Defbool
 DmRestrict Defbool
 Tee TeeType
+ForceAssignWithoutIommu Defbool
 Type DomainType
 TypeUnion DomainBuildInfoTypeUnion
 ArchArm struct {
diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c
index eef1de0939..c5090e2b32 100644
--- a/tools/libs/light/libxl_arm.c
+++ b/tools/libs/light/libxl_arm.c
@@ -101,6 +101,9 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc,
         return ERROR_FAIL;
     }
=20
+    if (libxl_defbool_val(d_config->b_info.force_assign_without_iommu))
+        config->iommu_opts |=3D XEN_DOMCTL_IOMMU_force_iommu;
+
     return 0;
 }
=20
diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_type=
s.idl
index 2a42da2f7d..1080966c33 100644
--- a/tools/libs/light/libxl_types.idl
+++ b/tools/libs/light/libxl_types.idl
@@ -564,6 +564,7 @@ libxl_domain_build_info =3D Struct("domain_build_info",=
[
     ("apic",             libxl_defbool),
     ("dm_restrict",      libxl_defbool),
     ("tee",              libxl_tee_type),
+    ("force_assign_without_iommu", libxl_defbool),
     ("u", KeyedUnion(None, libxl_domain_type, "type",
                 [("hvm", Struct(None, [("firmware",         string),
                                        ("bios",             libxl_bios_typ=
e),
diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c
index 117fcdcb2b..67fa96d949 100644
--- a/tools/xl/xl_parse.c
+++ b/tools/xl/xl_parse.c
@@ -2747,6 +2747,9 @@ skip_usbdev:
         }
     }
=20
+    xlu_cfg_get_defbool(config, "force_assign_without_iommu",
+                        &b_info->force_assign_without_iommu, 0);
+
     parse_vkb_list(config, d_config);
=20
     xlu_cfg_get_defbool(config, "xend_suspend_evtchn_compat",
diff --git a/xen/common/domain.c b/xen/common/domain.c
index 093bb4403f..f1f19bf711 100644
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -512,7 +512,7 @@ static int sanitise_domain_config(struct xen_domctl_cre=
atedomain *config)
=20
     if ( iommu )
     {
-        if ( config->iommu_opts & ~XEN_DOMCTL_IOMMU_no_sharept )
+        if ( config->iommu_opts >> XEN_DOMCTL_IOMMU_MAX )
         {
             dprintk(XENLOG_INFO, "Unknown IOMMU options %#x\n",
                     config->iommu_opts);
diff --git a/xen/drivers/passthrough/device_tree.c b/xen/drivers/passthroug=
h/device_tree.c
index 98f2aa0dad..103608dec1 100644
--- a/xen/drivers/passthrough/device_tree.c
+++ b/xen/drivers/passthrough/device_tree.c
@@ -198,6 +198,7 @@ int iommu_do_dt_domctl(struct xen_domctl *domctl, struc=
t domain *d,
 {
     int ret;
     struct dt_device_node *dev;
+    struct domain_iommu *hd =3D dom_iommu(d);
=20
     switch ( domctl->cmd )
     {
@@ -238,6 +239,16 @@ int iommu_do_dt_domctl(struct xen_domctl *domctl, stru=
ct domain *d,
             return -EINVAL;
=20
         ret =3D iommu_add_dt_device(dev);
+
+        /*
+         * iommu_add_dt_device returns 1 if iommu is disabled or device do=
n't
+         * have iommus property
+         */
+        if ( (ret =3D=3D 1) && (hd->force_assign_iommu) ) {
+            ret =3D -ENOSYS;
+            break;
+        }
+
         if ( ret < 0 )
         {
             printk(XENLOG_G_ERR "Failed to add %s to the IOMMU\n",
@@ -275,10 +286,14 @@ int iommu_do_dt_domctl(struct xen_domctl *domctl, str=
uct domain *d,
=20
         ret =3D iommu_deassign_dt_device(d, dev);
=20
-        if ( ret )
-            printk(XENLOG_G_ERR "XEN_DOMCTL_assign_dt_device: assign \"%s\=
""
+        if ( ret ) {
+            if ( hd->force_assign_iommu )
+                ret =3D -ENOSYS;
+            else
+                printk(XENLOG_G_ERR "XEN_DOMCTL_assign_dt_device: assign \=
"%s\""
                    " to dom%u failed (%d)\n",
                    dt_node_full_name(dev), d->domain_id, ret);
+        }
         break;
=20
     default:
diff --git a/xen/drivers/passthrough/iommu.c b/xen/drivers/passthrough/iomm=
u.c
index 6334370109..216a9058c0 100644
--- a/xen/drivers/passthrough/iommu.c
+++ b/xen/drivers/passthrough/iommu.c
@@ -193,6 +193,8 @@ int iommu_domain_init(struct domain *d, unsigned int op=
ts)
     hd->node =3D NUMA_NO_NODE;
 #endif
=20
+    hd->force_assign_iommu =3D opts & XEN_DOMCTL_IOMMU_force_iommu;
+
     ret =3D arch_iommu_domain_init(d);
     if ( ret )
         return ret;
@@ -534,6 +536,7 @@ int iommu_do_domctl(
 {
     int ret =3D -ENODEV;
=20
+
     if ( !is_iommu_enabled(d) )
         return -EOPNOTSUPP;
=20
@@ -542,7 +545,7 @@ int iommu_do_domctl(
 #endif
=20
 #ifdef CONFIG_HAS_DEVICE_TREE
-    if ( ret =3D=3D -ENODEV )
+    if ( ret =3D=3D -ENOSYS )
         ret =3D iommu_do_dt_domctl(domctl, d, u_domctl);
 #endif
=20
diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
index b85e6170b0..bf5f8c5b6b 100644
--- a/xen/include/public/domctl.h
+++ b/xen/include/public/domctl.h
@@ -81,8 +81,11 @@ struct xen_domctl_createdomain {
 #define _XEN_DOMCTL_IOMMU_no_sharept  0
 #define XEN_DOMCTL_IOMMU_no_sharept   (1U << _XEN_DOMCTL_IOMMU_no_sharept)
=20
+#define _XEN_DOMCTL_IOMMU_force_iommu 1
+#define XEN_DOMCTL_IOMMU_force_iommu  (1U << _XEN_DOMCTL_IOMMU_force_iommu=
)
+
 /* Max XEN_DOMCTL_IOMMU_* constant.  Used for ABI checking. */
-#define XEN_DOMCTL_IOMMU_MAX XEN_DOMCTL_IOMMU_no_sharept
+#define XEN_DOMCTL_IOMMU_MAX XEN_DOMCTL_IOMMU_force_iommu
=20
     uint32_t iommu_opts;
=20
diff --git a/xen/include/xen/iommu.h b/xen/include/xen/iommu.h
index 6b2cdffa4a..a9cf2334af 100644
--- a/xen/include/xen/iommu.h
+++ b/xen/include/xen/iommu.h
@@ -330,6 +330,9 @@ struct domain_iommu {
      * necessarily imply this is true.
      */
     bool need_sync;
+
+    /* Do not return error if the device without iommu is assigned */
+    bool force_assign_iommu;
 };
=20
 #define dom_iommu(d)              (&(d)->iommu)
--=20
2.27.0


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 18:00:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 18:00:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268494.462358 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHUmr-0006in-FW; Tue, 08 Feb 2022 18:00:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268494.462358; Tue, 08 Feb 2022 18:00:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHUmr-0006ga-9Q; Tue, 08 Feb 2022 18:00:21 +0000
Received: by outflank-mailman (input) for mailman id 268494;
 Tue, 08 Feb 2022 18:00:19 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TsJg=SX=epam.com=prvs=40387f30b1=oleksii_moisieiev@srs-se1.protection.inumbo.net>)
 id 1nHUmp-00068K-Mc
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 18:00:19 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f92136b3-8908-11ec-8f75-fffcc8bd4f1a;
 Tue, 08 Feb 2022 19:00:18 +0100 (CET)
Received: from pps.filterd (m0174683.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 218EglcD011879;
 Tue, 8 Feb 2022 18:00:11 GMT
Received: from eur01-he1-obe.outbound.protection.outlook.com
 (mail-he1eur01lp2051.outbound.protection.outlook.com [104.47.0.51])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3e3s7e998g-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Tue, 08 Feb 2022 18:00:10 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com (2603:10a6:102:ea::23)
 by VI1PR0302MB3327.eurprd03.prod.outlook.com (2603:10a6:803:1a::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Tue, 8 Feb
 2022 18:00:04 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::c1c:f98:9dd:86e0]) by PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::c1c:f98:9dd:86e0%6]) with mapi id 15.20.4951.019; Tue, 8 Feb 2022
 18:00:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f92136b3-8908-11ec-8f75-fffcc8bd4f1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=nAv5KCxoc/1kZCawGU4k0QB5b96DvRujLo46YeRZRZ+I1iAxZ5A4MB5mBw1uaNVamq2FyBhs1MaLfe6w4xU1nutw7fO9q6HQjigZwF8NGISQzpkZFzhB/66TkTHFVLt0JtIv3sF3V+nriluGk0NyhWVDL9/EZvVVCbHtKrsq4iDo7pW+0ue9NKNPU9l6Td/OH5OyxXJGr9pb33qKQJcfPtptrzj0Hy/G/x9XDzftAUJjfo6BfroWFEs0qESyU83h2JSH+M1CrJn3L9U5uPB+gVPPOloBAqyqmPfNXNxH2JcbwJr8SdqBrANXvYuPpn0mjXW/iC8o5f0OGwXYg9xbYA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=oQNxKQlk50F/d3RxIUW8GHsZ2EThLBH2CQt8NqqX+8c=;
 b=goMVEES9f5CIlmK2GejrzwQTZV9HqN630Zy8qkxCghDpFqxeVWC3RYOyNwzcu25nQhCVNW6gH7iMXFrj1Ag73zx4fBH3dveIQTaTzghzXHCm/8eLkwsgaXcZS5BbZhSA4eYDa82emza5B3Rx33Z1PI2S7f0UgNjeaxjSeEQFJfXIJg+Q6BPweprlNzU14ku9VM3z1ciaYYcIgvzpOAX3HWuifZFq5UYCj8M5mQV1toRS4XDL2OqHQVfEoygHA0gZtOicKrU10AJ681P1dJR1iqZGlZ+v194NQCFpIimMJRKbSzFdjVpWky7xQ+1HU9Ki6u3TFd62wnEppX1qDUASyg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=oQNxKQlk50F/d3RxIUW8GHsZ2EThLBH2CQt8NqqX+8c=;
 b=LOnJ9i+2Z6QvMTsxWKz2cTs9nnS6fGIuu+Kbv82B7xtYo9YfeCzwdir0fpcZ/h2cYvXJM+XZJNBITb00Iego0tJQ/WC9XRGqyyr4SeaqjdgGb88itpymohz5GFAnQ30x5PLXxW/SAfYhw7R05V8otJ4n2XsE+AfJQO3rqjrAr7CRNxHWFwXmv+F7Z4+XyjhiQP1uz0aZy69f4imd59zBedr5N4Wtr2ZAjwE9IeN8VmzkIszGowATEkGI5jHC385N13zCts5IeMWRHfh654sjdm8Vm12uqW3PItUaHyAQSEYeYh1gU63RMpoSiI/x0yHMHSopoQ2a0px6HrsvhesRxg==
From: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>,
        Juergen Gross
	<jgross@suse.com>, Wei Liu <wl@xen.org>,
        Stefano Stabellini
	<sstabellini@kernel.org>,
        Julien Grall <julien@xen.org>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Andrew Cooper <andrew.cooper3@citrix.com>,
        George Dunlap
	<george.dunlap@citrix.com>,
        Jan Beulich <jbeulich@suse.com>,
        Nick Rosbrook
	<rosbrookn@ainfosec.com>,
        Anthony PERARD <anthony.perard@citrix.com>,
        Paul
 Durrant <paul@xen.org>
Subject: [RFC v2 0/8] Introduce SCI-mediator feature
Thread-Topic: [RFC v2 0/8] Introduce SCI-mediator feature
Thread-Index: AQHYHRWziOt6EkRoYUygGUtf3780OQ==
Date: Tue, 8 Feb 2022 18:00:04 +0000
Message-ID: <cover.1644341635.git.oleksii_moisieiev@epam.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: ec057eaf-010a-45a1-b78f-08d9eb2cd5a7
x-ms-traffictypediagnostic: VI1PR0302MB3327:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <VI1PR0302MB33276ECDB30028D4C8061079E32D9@VI1PR0302MB3327.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 dTxjwLwvtwEZyFXRqj8h9NUTWO0Utv5TM0mzTYUEPs7CvBd+lF2/49de4RKvb97KDEokbbZSekdlNMrckOYzFFQS5Jszg1be+pYqaiVnnPEoF0eC5FAGmmW59iPToTIPGOGNdwhK9k0cfFy9svd66E+MlwEUXrUR9owkzOux+ABVkxp11NSuLE/xPMo54oLbIYYkM6rWXR5rn4NY3ynWdhOIR9u0PAOiAV7drrWPShkaqog+ooLp43r6J2XNAboXCPuwIBHsGNXKmR+osaQA3VbbzuP3itVbMFRzIk6s3mbrMb/pPT8MSn+t97avfrW06dkX8aj2+IRdnLRo3RHLwaEDmeuKuMZoX6ImJ3sQGIPEV9kS9s9apzPcrfNBFwz6caSP31MdUIyfEn7P8bHeaR6YI8NBUj8ldGmZlQgmcb8KaztEdZFB0p7+w82hxoKhMqqlaP4R2Wq0gG2Qyo61AmzLNUFFzKvL6SQEnIYZrq2MKJnIrVIm1XeHx/v0M5425AAHyxllLdEEZRGZ9oIudiAeT4oBrScno+PARghU7GBgMQZtcme8bB1I12prOXMdbP9GwWkVDAJfSxPP/7w90U0NBuuXFd869I0jUmPwqsb9X8UaaqZyegdFVbx1NwEUa6lebbkXo/228IK08SM/ULbDYGOiffhlUoZiXPHjD+QMOHO5KInFQ7DOSdmj4dDmyOqOrGorC/RNuj5ZsOvjFw==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR03MB7136.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38070700005)(71200400001)(6486002)(508600001)(66556008)(66476007)(316002)(86362001)(122000001)(6916009)(6506007)(38100700002)(5660300002)(6512007)(4326008)(83380400001)(54906003)(2906002)(26005)(186003)(8676002)(7416002)(2616005)(76116006)(36756003)(66446008)(8936002)(91956017)(64756008)(66946007);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?iso-8859-1?Q?6xdreY4/6ZoOlhm0F0vs1B6PyJGBOUucIF6Jny9kOXh3V67B1CMuXVXUOF?=
 =?iso-8859-1?Q?9F0owIQjVLJkyDZ9L3e46SLqNDhjb6RCs+YVtH4Eo3OSQXfB+Z5jjQngIc?=
 =?iso-8859-1?Q?xvhfpuSeIPQty8r4sUMx8tjpx5h79IyZuSgob9XhlgSIp1DnQjEpjaap64?=
 =?iso-8859-1?Q?wXqfqPgdsY4KfjICFfAttrhn2up3za5Hz68P+bAavCBy1ynHL1NWaAAWFe?=
 =?iso-8859-1?Q?M8XfDqBOoDDigxRdn25zfxW989LuuwmxbaQUbmrMSVmsfuCNZ1tBQUCkhR?=
 =?iso-8859-1?Q?6K5s8zRPxlh+kBmz9a8DXpcNJe1UhG1G15ZhMsA5UoBGJlOaiRGkaa7Xab?=
 =?iso-8859-1?Q?LPAMVdRxuShXLF6BsfRGuCx7zBAuR1MOyeK/YajOoHgB2HjJgJg+Pzk2gg?=
 =?iso-8859-1?Q?OVL0Cy81ZifVAwy/UbYUwH+YtJndc78xiccZ0jX1AoFSfIEBbKPGuX1I3J?=
 =?iso-8859-1?Q?mEo8ZTDEm5pgoezzeg4w+MFB6u8mv68FB50rrUTe2t6l8qJrKkBlb3TQvc?=
 =?iso-8859-1?Q?ANkgiUgC8kPNTh4/6RWmd6XJtCMP0S0oIzi2aAi7d5aTfNuNeB/tKzDhRL?=
 =?iso-8859-1?Q?xu5Dr81ePTjETrrm1zSV5bxamsQhGfkxoExJKpTL5qX3y++oePv5TE4Dk7?=
 =?iso-8859-1?Q?eLwL0xMdSwKRpv+IBBXwEk+T8DkJmQ4E5C0D3UvPx5JGQAmVV0w5QQ6pbj?=
 =?iso-8859-1?Q?cBJZIyadGfLxDHF0LtlU6GYv46a5z/SjiDk0YOm/36W33FcYQP8A16IXR+?=
 =?iso-8859-1?Q?ragc18zoG5mrMMmJVc7cqHijgk6S4sxrkEdvi8D3iV5MKGAQQqBTKWTveT?=
 =?iso-8859-1?Q?Y20Lu5TKqOSJ6RkxOy0eZk16BwmQJrZx/0/wEGvveQwbYXW8ef0mziwgMx?=
 =?iso-8859-1?Q?CB5AwgPsAiMrF6+GdPFSTFE+UToUJo5Pr+x+/nV43+gGfiLr5r5j74cR98?=
 =?iso-8859-1?Q?qKEbpJ9XQGjVfIErK7lsnD8hCliqP2Neaagx6P0QwTwiI/P00/WZ7iNXDU?=
 =?iso-8859-1?Q?OPcx4nky62oHWM1Dd0/M2WQ+MTpNrahau1EMG8hf4xAK6u34YRdmGuCiZm?=
 =?iso-8859-1?Q?vPytBGM3EJ4bAofAd1NXwIvAQyJhaUqPTbTdIwOQKOBGmGI66Q/xNl9eA4?=
 =?iso-8859-1?Q?4+4CcfcCCL+xVWFMhfcApT3f18xT89IkS5IzWKoaXEb081wLqhY1Gn8IEC?=
 =?iso-8859-1?Q?3CRn/fqOPFL7qKIGT2i6R8dEOTwGdhVNkifndoQjj6BWFvhcyIovgs7dVm?=
 =?iso-8859-1?Q?JFuR/rybSZlWQdRKMb21dpDWmxm+VYwFumJNt4uzITWMEFWZydpLfzuzKv?=
 =?iso-8859-1?Q?ZzGlbaD1SKdcmXgnAD7YgXhlkW5VpGmHLAJufwzMsMOmAMAMJY/0s0UylT?=
 =?iso-8859-1?Q?o2N/xGymwdA7XYbmf3YVBMLkqMf/otSyDAgFaR6K+wffUBmLeoOzGldq7N?=
 =?iso-8859-1?Q?Zspn2aGrdCwhUbyoXFilXuLiYKBhOu7I235LW147kyIlsP4xKo2IDtNM7+?=
 =?iso-8859-1?Q?NEqBqjYzYdXKbrQoF650JgEJEdo/nVcwNBtG5FZqDd3HMaZiRhUAB8X4qT?=
 =?iso-8859-1?Q?gRrF1NaQxWwzrEoAvPeTI4mf+v2j9eC6SXnh56PC7fttqvYZ1PgiFUBwWa?=
 =?iso-8859-1?Q?YitKaDvxuOw0qNhZi6Lbmk0DLU3SUrcrFbBH/NKRpyn1UvhXd1/3Tzm2/h?=
 =?iso-8859-1?Q?/EtLgxJ+w9NbL4nGFmOmBRPLauplZffhD6+WRMkq9t8gHkPNF9waWbFIZG?=
 =?iso-8859-1?Q?uihXlgYt7HfewVxaEZ5ZUGnuA=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR03MB7136.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ec057eaf-010a-45a1-b78f-08d9eb2cd5a7
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2022 18:00:04.4169
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: GnUzD1IYqE7Vw+DSZfDrVIPyOFruObbQMvTK9VMmmBnlUK0aQHck+FSPq9Qy34pN2SDmrbGw49wPfjns4h8Ff7VZ3XS/qb92oDx/yEJlz4Q=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0302MB3327
X-Proofpoint-GUID: Ewj0VzFITWk3pPweORzYM9SHaFNQTaAM
X-Proofpoint-ORIG-GUID: Ewj0VzFITWk3pPweORzYM9SHaFNQTaAM
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-08_06,2022-02-07_02,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 adultscore=0
 priorityscore=1501 malwarescore=0 suspectscore=0 bulkscore=0
 impostorscore=0 clxscore=1011 phishscore=0 mlxscore=0 mlxlogscore=999
 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202080106

Introducing the feature, called SCI mediator.
It's purpose is to redirect SCMI requests from the domains to firmware
(SCP, ATF etc), which controls the power/clock/resets etc.
The idea is to make SCP firmware (or similar, such as AT-F) responsible for
control power/clock/resets and provide SCMI interface so controls can be sh=
ared
between the Domains.
Originally, we've met a problem, that the devices, shared between different
Domains, can't have an access to HW registers to work with clocks/resets/po=
wer
etc. You have to pass cpg to the Domain, so the devices can access HW direc=
tly.
The solution for this is to move HW controls over power/clock/resets to
SCP firmware and use Linux-kernel SCMI drivers to pass requests to SCP.
Xen is responsible for permissions setting, so Domain can access only to
power/clock/resets which are related to this Domain. Also XEN is the mediat=
or
which redirects SCMI requests, adding agentID so firmware should know the
sender.
SMC is currently used as transport, but this should be configurable.

Here is the high level design:

ARM_SCI (System Control Interface) feature can be enabled in xen_config:
> CONFIG_ARM_SCI=3Dy
Mediator can be configured:
> CONFIG_SCMI_SMC=3Dy

Currently, only SCMI_SMC mediator is implemented, which using shared memory
region to communicate with firmware and SMC as transport.

Xen scmi should be configured in the device-tree.
Format is the following:
	cpu_scp_shm: scp-shmem@0x53FF0000 {
		compatible =3D "arm,scmi-shmem";
		reg =3D <0x0 0x53FF0000 0x0 0x1000>;
	};

	firmware {
		scmi {
			compatible =3D "arm,scmi-smc";
			arm,smc-id =3D <0x82000002>;
			shmem =3D <&cpu_scp_shm>;
			#address-cells =3D <1>;
			#size-cells =3D <0>;

			scmi_power: protocol@11 {
				reg =3D <0x11>;
				#power-domain-cells =3D <1>;
			};

			scmi_clock: protocol@14 {
				reg =3D <0x14>;
				#clock-cells =3D <1>;
			};

			scmi_reset: protocol@16 {
				reg =3D <0x16>;
				#reset-cells =3D <1>;
			};
		};
	};

Where:
&cpu_scp_shm is the shared memory for scmi buffers;
0x53FF0000, size 0x1000 is the platform specific free address, which provid=
e
space for the communication.
&scmi node, which should be copied to Dom0 device-tree.

Device configured to use scmi:=20
&avb {
	scmi_devid =3D <0>;
	clocks =3D <&scmi_clock 0>;
	power-domains =3D <&scmi_power 0>;
	resets =3D <&scmi_reset 0>;
};

Where:
scmi_devid - id from the firmware, which is assigned for AVB.

During initialization, XEN scans probes the first SCI-mediator driver which=
 has
matching node in the device-tree. If no device-tree was provided, then the
first registered mediator driver should be probed.

DomX should be configured:
Device-tree should include the same nodes, described above.
&cpu_scp_shm should be altered during domain creation. Xen allocates free p=
age
from the memory region, provided in &cpu_scp_shm in XEN device-tree, so eac=
h
domain should have unique page. Nodes &cpu_scp_shm and /firmware/scmi shoul=
d be
copied from partial device-tree to domain device-tree, so kernel can initia=
lize
scmi driver.

SCI mediator can be enabled in dom.cfg the following way:
>arm_sci =3D "scmi_smc"

which sets scmi_smc to be used for the domain.
--
Changes since v1:

- renamed sci to arm_sci
- updated golang bindings
- reused XEN_DOMCTL_assign_device logic to add arm_sci devices instead of
adding new hypercall
- minor style changes
- fixed arm32 compilation issues
- use ioremap_cache instead of vmap to map shared memory for SCMI
- introduced memcpy_fromio and memcpy_toio fucntions instead of memcpy, mov=
ed
from Linux kernel source code
- use DOMID_XEN for HYP_CHANNEL in channel_list
- export host device-tree to hypfs so toolstack can access host device-tree=
 nodes
- create arm,scmi-shmem node from scratch for the domain device-tree
- create arm,scmi_smc from scratch if it wasn't provided in partial device-=
tree
- removed xc_domain_add_sci_device function=20
- do not use linux,scmi_mem to describe scmi shared memory
- define static address for the SCMI page in the domU
- introduced config parameter force_assign_without_iommu =3D 1 to domain co=
nfig
- require force_assign_without_iommu parameter to assign non-DMA masters
present in dtdev
- unmap memory after sending discover agent on SCMI init stage
--
Oleksii Moisieiev (8):
  xen/hypfs: support fo nested dynamic hypfs nodes
  libs: libxenhypfs - handle blob properties
  xen/arm: Export host device-tree to hypfs
  xen/arm: add generic SCI mediator framework
  xen/arm: introduce SCMI-SMC mediator driver
  tools/arm: Introduce force_assign_without_iommu option to xl.cfg
  tools/arm: add "arm_sci" option to xl.cfg
  xen/arm: add SCI mediator support for DomUs

 MAINTAINERS                           |   6 +
 docs/man/xl.cfg.5.pod.in              |  29 +
 tools/golang/xenlight/helpers.gen.go  |   7 +
 tools/golang/xenlight/types.gen.go    |   8 +
 tools/include/libxl.h                 |   5 +
 tools/include/xenctrl.h               |   3 +
 tools/libs/hypfs/core.c               |   2 -
 tools/libs/light/libxl_arm.c          | 217 +++++-
 tools/libs/light/libxl_create.c       |  44 +-
 tools/libs/light/libxl_internal.h     |   3 +
 tools/libs/light/libxl_types.idl      |   7 +
 tools/xl/xl_parse.c                   |  12 +
 xen/arch/arm/Kconfig                  |  19 +
 xen/arch/arm/Makefile                 |   2 +
 xen/arch/arm/domain.c                 |  22 +
 xen/arch/arm/domain_build.c           |  11 +
 xen/arch/arm/domctl.c                 |   7 +
 xen/arch/arm/host_dtb_export.c        | 307 +++++++++
 xen/arch/arm/sci/Kconfig              |  10 +
 xen/arch/arm/sci/Makefile             |   2 +
 xen/arch/arm/sci/sci.c                | 152 ++++
 xen/arch/arm/sci/scmi_smc.c           | 959 ++++++++++++++++++++++++++
 xen/arch/arm/setup.c                  |   1 +
 xen/arch/arm/vsmc.c                   |   5 +-
 xen/arch/arm/xen.lds.S                |   7 +
 xen/common/domain.c                   |   2 +-
 xen/common/hypfs.c                    |  83 ++-
 xen/drivers/passthrough/device_tree.c |  19 +-
 xen/drivers/passthrough/iommu.c       |   5 +-
 xen/include/asm-arm/domain.h          |   4 +
 xen/include/asm-arm/sci/sci.h         | 162 +++++
 xen/include/public/arch-arm.h         |  15 +
 xen/include/public/device_tree_defs.h |   1 +
 xen/include/public/domctl.h           |   5 +-
 xen/include/xen/hypfs.h               |  14 +-
 xen/include/xen/iommu.h               |   3 +
 36 files changed, 2122 insertions(+), 38 deletions(-)
 create mode 100644 xen/arch/arm/host_dtb_export.c
 create mode 100644 xen/arch/arm/sci/Kconfig
 create mode 100644 xen/arch/arm/sci/Makefile
 create mode 100644 xen/arch/arm/sci/sci.c
 create mode 100644 xen/arch/arm/sci/scmi_smc.c
 create mode 100644 xen/include/asm-arm/sci/sci.h

--=20
2.27.0


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 18:00:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 18:00:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268498.462409 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHUmy-000873-Gj; Tue, 08 Feb 2022 18:00:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268498.462409; Tue, 08 Feb 2022 18:00:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHUmy-00086h-CE; Tue, 08 Feb 2022 18:00:28 +0000
Received: by outflank-mailman (input) for mailman id 268498;
 Tue, 08 Feb 2022 18:00:25 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TsJg=SX=epam.com=prvs=40387f30b1=oleksii_moisieiev@srs-se1.protection.inumbo.net>)
 id 1nHUmv-00068L-Ec
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 18:00:25 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id fc1d3e92-8908-11ec-8eb8-a37418f5ba1a;
 Tue, 08 Feb 2022 19:00:23 +0100 (CET)
Received: from pps.filterd (m0174678.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 218EgrTB015757;
 Tue, 8 Feb 2022 18:00:19 GMT
Received: from eur02-he1-obe.outbound.protection.outlook.com
 (mail-he1eur02lp2057.outbound.protection.outlook.com [104.47.5.57])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e3t5xrs6q-10
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Tue, 08 Feb 2022 18:00:19 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com (2603:10a6:102:ea::23)
 by VE1PR03MB5613.eurprd03.prod.outlook.com (2603:10a6:803:12a::29)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Tue, 8 Feb
 2022 18:00:11 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::c1c:f98:9dd:86e0]) by PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::c1c:f98:9dd:86e0%6]) with mapi id 15.20.4951.019; Tue, 8 Feb 2022
 18:00:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fc1d3e92-8908-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cfCuyyHlgadn8j+UYBWok7zac+2TzkmJ2j4bLiiwMg/1466/pTjVETa0HtAMQgCX6cP9eE38ZogXqstamqH9eMUEjNkVPPyYXYdT1ssz2XUI7SStubRZ6gK6dHtCLNTow3okq52G/65e7l5Nl1pU6kl5gRnNJO7zNoSn5POOb9NSgYuvrFzqTpQ4Hp5WJURa1yhZr7BlfL5IEGlldsB0UzjeuNO8SGZ79S1tvBEhC3dBFW/sGy8rMQVfSui47Y/t3vPrz3cpYqIDPOMaJeqpWoUFIQm3aJmeNi3GuBlNPp8vduMDNWNioSN8rf8An7t/+ad4+URTw87Sx+FsoztLjw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=lwBesdAFpbbKcuHszwtd+zJh3/6ZoEfXGDzAO3r/9m0=;
 b=c9UB4kZlMfSoZTWEqbYQtbmDVnhLxbrEoh7pFvdu3KrQVuIUpifU4fvwgvA4PCOACWI4/E9rJ4YbyYP+Sav2geTt0wo8lwiLdm7s0PWb/XpzM/d3hE1EWlJnl2ky+fTyBpLUKq1+SYUuvpYBsInuxWahFpzdB1CptNIAQAtN9f7m6ZemBaRdL4jVDKxc/sF86xBIYx/npPnQ3/5WJ1RJmCC1LircLrRxBVTDcjb+SrY4dle68TCnGWjNrz4/SEgpzXVGKuEj8kaipWb5uaRFKY3XoHG6CyhaxcThdQiyWw46XcHA2q8A44ccnA03U4eBXcgd3JkbeLAlxBHahS1Wlg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=lwBesdAFpbbKcuHszwtd+zJh3/6ZoEfXGDzAO3r/9m0=;
 b=TpPGHIgG0FILxJtDzG9X/2roEE4dC+yowbSQLihWnwBIa58Vxaox+kKNBXECiiMi0+zHo5/WCHAH7LmHan1uV3rCG7RvJU3XYUlHhQE7Bi1+pMYwFr7BUPrl2a5mCdnjSdswDBqQPBeYqyRa50FA88d88YBTRNk/WFIBXJmLvEnRXNdde0BnLv1UHhZsNTF7Hi5KHc+Q56U6DNxrz3maZGwFEb8hROHs24qqDClriSNR/pYX8V6omfFJWmUGhX0ej0gfamIirroEorjHMu/AOP6/kBpbeqNMnjxPahtiSwElORDQZZWsONJUbyj878Rek0JbTKiungZgMMxVeDWzPA==
From: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>,
        Stefano Stabellini
	<sstabellini@kernel.org>,
        Julien Grall <julien@xen.org>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>
Subject: [RFC v2 5/8] xen/arm: introduce SCMI-SMC mediator driver
Thread-Topic: [RFC v2 5/8] xen/arm: introduce SCMI-SMC mediator driver
Thread-Index: AQHYHRW24Dmb0qV8ZkqAv39Pf6/nVQ==
Date: Tue, 8 Feb 2022 18:00:10 +0000
Message-ID: 
 <cb1493f5d9b5c3437268054b4a8e345cb35c8708.1644341635.git.oleksii_moisieiev@epam.com>
References: <cover.1644341635.git.oleksii_moisieiev@epam.com>
In-Reply-To: <cover.1644341635.git.oleksii_moisieiev@epam.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 51fb966e-0e48-4ba5-d203-08d9eb2cd9cc
x-ms-traffictypediagnostic: VE1PR03MB5613:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <VE1PR03MB56137E640128E908C0E46C46E32D9@VE1PR03MB5613.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:3383;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 UIoCAc8+AFzUwByPeHaDyknesucUZr0veB6PMzgQPBSlzEC/jxCZtvOTDmZgLQS9/plIDRB8EgieFRTqpmk/Cb3hQSllfDvAa0oUTr9XWq7o63zOHA/FUwNjtm7MZrkcOMFumx7go/DPaF8VydGHITziojEhKtzmYPUDPaeTP4n/jXiLglRvATiVs2oxh7ChV1ZT+DYn3S8MA9Iq2gIXNqgaBQeF7A0S8w45Kyi06KMmnATsIT/5zAFihScY7mFTZuQ5iABLKr1NL/kFquWAMGPPTOHR6L4XaBZ+5qJed+c/onnuukx3vtk9xS623MRihgXecUjZgePD9RBq7HY9CGPby3nOoMa9IU35pMDoHVEL5R+bNwLI6bLlpZXfXjDF1CoqFJ3cpJLDhhooHaNry5vdQUwh/cDwZEFAQxHdO6SxMteaa2q11+eslAD47pZ2Ev005FLn159csA1mybXCanmX7OhRdMFfUTUkBZcaGeqod7snfxC+q8Q3Tm/dn+7kK3r/om10s00OIr05elF10KIKae1xafdg8qtMMJD05X34oPzNa/jlssN5HI0Zq9kIe3qMO8nHLdSCHF/xsdgQa3B2fbUTq0zFieEh1I+HNZWzEx07lQrwveRyqFY6z8UQWsUkX1XsMFPcSIF9tYMR7C6ijWv7KgoO8NBpN64F101YR0CD+4Owxt7LpmYwJwzUCOePc+qpzFz+0/JZonijGrJKIQN4FFgrvKtjCT13p+Q=
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR03MB7136.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38070700005)(71200400001)(6486002)(508600001)(66476007)(64756008)(86362001)(66556008)(316002)(122000001)(6916009)(6506007)(2616005)(5660300002)(6512007)(4326008)(83380400001)(54906003)(30864003)(2906002)(26005)(186003)(8676002)(76116006)(38100700002)(66446008)(66946007)(8936002)(36756003)(91956017)(2004002)(579004)(559001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?iso-8859-1?Q?7DKeJTm3R0sBtYj9VngbEwbgcb5SIqliGCV12ylc/tO668jfbZOrRSzw+E?=
 =?iso-8859-1?Q?1Z/neW3FLRW5d+c910kMbSJX4+uLPOWWcytJ5LdYCihdf1/zkEaNqzOJZz?=
 =?iso-8859-1?Q?cfUJGlr0j4+AigdBafZQkytDsDLqVUW85HYqEpKO4muG50nlxedLxe8al5?=
 =?iso-8859-1?Q?rMcJBEvFyS1/jgINlNpjMVgjForVFpjCzNtuUr7iT3NVGSdluu+GS5E+GM?=
 =?iso-8859-1?Q?s/oWSdc6wAl+N0zqkg68GmCzwI9wdG+cpcnZaLNDh+0LJC3bdHnIN3KGDi?=
 =?iso-8859-1?Q?cXkM7eZPNqAGU8sIRZVaknfDt9NY/zpopRYzDSvAvPeEPgjy0XuQxef0ZZ?=
 =?iso-8859-1?Q?G/Zs6tbr3zCk7tqv/1bnbkjxeNrajadymc0GYu+qk0/KOERXj9G6LVWT2v?=
 =?iso-8859-1?Q?FlqJOqYlQUoKC6u9Qjj89sz9rOGdbdZz8H3N390p6J+awqd1zOGxtDJ8Me?=
 =?iso-8859-1?Q?qAtsZZIpSxeOX/QNoxxvUX6b2V+tm6MeQiEUAjXG+aoy0tKUKZdvn/yygt?=
 =?iso-8859-1?Q?Iyd6wk6texgJJ+OKFjQTEbFA3ANG6/QwJgToEhbHm+ogEUuruOpiSRRGRs?=
 =?iso-8859-1?Q?0Njnco3DoEA/JJSFt1tr7TBgtcx+nAODiEbAGhHVMqUvzuMfvITa2GzxBS?=
 =?iso-8859-1?Q?vOo5PxFSIFS87jBCbQnjAm3oJWibkfGnrgH/7UfqSOUU6gXYV5SDkLDBDq?=
 =?iso-8859-1?Q?h9gyj9JiOnFi5vRQ/m/A649vKCaBx3NLFPIBvqSm7wMhhE9mMc2z10pXNB?=
 =?iso-8859-1?Q?808No95b3MCIrUqVZ/h8EMU0X26XyvBFipfNuDlgXkR9YakfW6C+izOs0C?=
 =?iso-8859-1?Q?A8cjx6i75n95CAfOv4uO0zy4lkYsG/f8RQr0nEub+87JMgFvJQ2ViV1e8q?=
 =?iso-8859-1?Q?JgYMO8hv0FNkazdMPfGG5tfJqlWbKeMCLJ+zY4OvBm4mFJauU/wjn5PDxh?=
 =?iso-8859-1?Q?A2EyMyACgtDkC724wE+zDWglZwiBN19h4xY70yP4KZtpjD/bn3nhbVemnr?=
 =?iso-8859-1?Q?VTMaK/ib7IUkGUjefqUEpO9cOL7uZc7AGr0ZZ5jr2TqB1ebrvsRat/HLAB?=
 =?iso-8859-1?Q?T3Edh0d8cyQBm5LjqP0DJj14VTGNGW0LKpLEUhe7JicSJ3nmPnCdsMv4T7?=
 =?iso-8859-1?Q?p+5ThbvWuCje220ZCNvGGkNgjBznAkl+nYhXnzMfSEonlra53xWJFKb1ta?=
 =?iso-8859-1?Q?gKHK2pL1hJnJN9ZHDMi4cgy8jJVZeLrUZI+x37IYWo3jRMqwNmJw7Rw/4m?=
 =?iso-8859-1?Q?swWubhIkf1v9i/dV/PY4s2f+rr26o0GSaA/cVX+3AIP4VAoSSMGIvscR4h?=
 =?iso-8859-1?Q?ODArtzf8fl4A3gMJ3XP67dwkVpPMyJGlUfp1LHE8NJcitE3kgRLEp/vsX4?=
 =?iso-8859-1?Q?tilCyolk/h0mbfdO3LfKrpIA7dMLL49FF8Zq7ioFYPvc9giHMN4UehdWNU?=
 =?iso-8859-1?Q?XuDIsg9vhFj+aA9yPCrBMFkcjNvUpBqVrW5BXeJVOpyPOLr/jSWE7u3iJJ?=
 =?iso-8859-1?Q?3OV5jK6ulnyG7s9+iZkpuf913wckfhoPMIM0umtGUTMBg6jqeHez4Kcs5H?=
 =?iso-8859-1?Q?kx0gzCWDg0VxWRkgT0LMZbso0oFT3XBBHPkSAsQIEMcMt0rg5nkz7HYJOI?=
 =?iso-8859-1?Q?wIKBcuJe0ZVM+qpw8VNpquKMZUbLupwui7rIZiZnmFZR/i9VaEsNCVZ9cV?=
 =?iso-8859-1?Q?yJ/cVyNvwjxxbREyVL0uMCuEIU/9fj6udtcprz7VEX8usMovdyOfkY5/vV?=
 =?iso-8859-1?Q?toQ+yK6uQMTvEHpECIztpiMTM=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR03MB7136.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 51fb966e-0e48-4ba5-d203-08d9eb2cd9cc
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2022 18:00:10.4983
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: yGu9sE7NDwwHGwOdYtqFBcUWXZU6xbwMnEwcDmw6QdQtZf+MQmFrAVyteEg6ZK7w8OPd9EycTMTHfJ3GO25CjPWelkClig20eXRgIZOyTm4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR03MB5613
X-Proofpoint-GUID: Xjku0kQnLWwAjadQoLtDOOfoMLBUmhBS
X-Proofpoint-ORIG-GUID: Xjku0kQnLWwAjadQoLtDOOfoMLBUmhBS
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-08_06,2022-02-07_02,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 spamscore=0
 priorityscore=1501 clxscore=1015 impostorscore=0 adultscore=0
 suspectscore=0 malwarescore=0 phishscore=0 lowpriorityscore=0
 mlxlogscore=999 bulkscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2201110000 definitions=main-2202080106

This is the implementation of SCI interface, called SCMI-SMC driver,
which works as the mediator between XEN Domains and Firmware (SCP, ATF etc)=
.
This allows devices from the Domains to work with clocks, resets and
power-domains without access to CPG.

Originally, cpg should be passed to the domain so it can work with
power-domains/clocks/resets etc. Considering that cpg can't be split betwee=
n
the Domains, we get the limitation that the devices, which are using
power-domains/clocks/resets etc, couldn't be split between the domains.
The solution is to move the power-domain/clock/resets etc to the
Firmware (such as SCP firmware or ATF) and provide interface for the
Domains. XEN should have an entity, caled SCI-Mediator, which is
responsible for messages redirection between Domains and Firmware and
for permission handling.

The following features are implemented:
- request SCMI channels from ATF and pass channels to Domains;
- set device permissions for Domains based on the Domain partial
device-tree. Devices with permissions are able to work with clocks,
resets and power-domains via SCMI;
- redirect scmi messages from Domains to ATF.

Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@epam.com>
---
 xen/arch/arm/Kconfig        |   2 +
 xen/arch/arm/sci/Kconfig    |  10 +
 xen/arch/arm/sci/scmi_smc.c | 959 ++++++++++++++++++++++++++++++++++++
 3 files changed, 971 insertions(+)
 create mode 100644 xen/arch/arm/sci/Kconfig
 create mode 100644 xen/arch/arm/sci/scmi_smc.c

diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
index ab07833582..3b0dfc57b6 100644
--- a/xen/arch/arm/Kconfig
+++ b/xen/arch/arm/Kconfig
@@ -123,6 +123,8 @@ config ARM_SCI
 	  support. It allows guests to control system resourcess via one of
 	  ARM_SCI mediators implemented in XEN.
=20
+	source "arch/arm/sci/Kconfig"
+
 endmenu
=20
 menu "ARM errata workaround via the alternative framework"
diff --git a/xen/arch/arm/sci/Kconfig b/xen/arch/arm/sci/Kconfig
new file mode 100644
index 0000000000..10b634d2ed
--- /dev/null
+++ b/xen/arch/arm/sci/Kconfig
@@ -0,0 +1,10 @@
+config SCMI_SMC
+	bool "Enable SCMI-SMC mediator driver"
+	default n
+	depends on ARM_SCI && HOST_DTB_EXPORT
+	---help---
+
+	Enables mediator in XEN to pass SCMI requests from Domains to ATF.
+	This feature allows drivers from Domains to work with System
+	Controllers (such as power,resets,clock etc.). SCP is used as transport
+	for communication.
diff --git a/xen/arch/arm/sci/scmi_smc.c b/xen/arch/arm/sci/scmi_smc.c
new file mode 100644
index 0000000000..103529dfab
--- /dev/null
+++ b/xen/arch/arm/sci/scmi_smc.c
@@ -0,0 +1,959 @@
+/*
+ * xen/arch/arm/sci/scmi_smc.c
+ *
+ * SCMI mediator driver, using SCP as transport.
+ *
+ * Oleksii Moisieiev <oleksii_moisieiev@epam.com>
+ * Copyright (C) 2021, EPAM Systems.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#include <asm/sci/sci.h>
+#include <asm/smccc.h>
+#include <asm/io.h>
+#include <xen/bitops.h>
+#include <xen/config.h>
+#include <xen/sched.h>
+#include <xen/device_tree.h>
+#include <xen/iocap.h>
+#include <xen/init.h>
+#include <xen/err.h>
+#include <xen/lib.h>
+#include <xen/list.h>
+#include <xen/mm.h>
+#include <xen/string.h>
+#include <xen/time.h>
+#include <xen/vmap.h>
+
+#define SCMI_BASE_PROTOCOL                  0x10
+#define SCMI_BASE_PROTOCOL_ATTIBUTES        0x1
+#define SCMI_BASE_SET_DEVICE_PERMISSIONS    0x9
+#define SCMI_BASE_RESET_AGENT_CONFIGURATION 0xB
+#define SCMI_BASE_DISCOVER_AGENT            0x7
+
+/* SCMI return codes. See section 4.1.4 of SCMI spec (DEN0056C) */
+#define SCMI_SUCCESS              0
+#define SCMI_NOT_SUPPORTED      (-1)
+#define SCMI_INVALID_PARAMETERS (-2)
+#define SCMI_DENIED             (-3)
+#define SCMI_NOT_FOUND          (-4)
+#define SCMI_OUT_OF_RANGE       (-5)
+#define SCMI_BUSY               (-6)
+#define SCMI_COMMS_ERROR        (-7)
+#define SCMI_GENERIC_ERROR      (-8)
+#define SCMI_HARDWARE_ERROR     (-9)
+#define SCMI_PROTOCOL_ERROR     (-10)
+
+#define DT_MATCH_SCMI_SMC DT_MATCH_COMPATIBLE("arm,scmi-smc")
+
+#define SCMI_SMC_ID                        "arm,smc-id"
+#define SCMI_SHARED_MEMORY                 "arm,scmi-shmem"
+#define SCMI_SHMEM                         "shmem"
+#define SCMI_SHMEM_MAPPED_SIZE             PAGE_SIZE
+
+#define HYP_CHANNEL                          0x0
+
+#define HDR_ID                             GENMASK(7,0)
+#define HDR_TYPE                           GENMASK(9, 8)
+#define HDR_PROTO                          GENMASK(17, 10)
+
+/* SCMI protocol, refer to section 4.2.2.2 (DEN0056C) */
+#define MSG_N_AGENTS_MASK                  GENMASK(15, 8)
+
+#define FIELD_GET(_mask, _reg)\
+    ((typeof(_mask))(((_reg) & (_mask)) >> (ffs64(_mask) - 1)))
+#define FIELD_PREP(_mask, _val)\
+    (((typeof(_mask))(_val) << (ffs64(_mask) - 1)) & (_mask))
+
+typedef struct scmi_msg_header {
+    uint8_t id;
+    uint8_t type;
+    uint8_t protocol;
+} scmi_msg_header_t;
+
+#define SCMI_SHMEM_CHAN_STAT_CHANNEL_FREE   BIT(0, UL)
+#define SCMI_SHMEM_CHAN_STAT_CHANNEL_ERROR  BIT(1, UL)
+
+#define SCMI_ALLOW_ACCESS                   BIT(0, UL)
+
+struct scmi_shared_mem {
+    uint32_t reserved;
+    uint32_t channel_status;
+    uint32_t reserved1[2];
+    uint32_t flags;
+    uint32_t length;
+    uint32_t msg_header;
+    uint8_t msg_payload[];
+};
+
+struct dt_channel_addr {
+    u64 addr;
+    u64 size;
+    struct list_head list;
+};
+
+struct scmi_channel {
+    int chan_id;
+    int agent_id;
+    uint32_t func_id;
+    domid_t domain_id;
+    uint64_t paddr;
+    uint64_t len;
+    struct scmi_shared_mem *shmem;
+    spinlock_t lock;
+    struct list_head list;
+};
+
+struct scmi_data {
+    struct list_head channel_list;
+    spinlock_t channel_list_lock;
+    bool initialized;
+};
+
+static struct scmi_data scmi_data;
+
+
+/*
+ * pack_scmi_header() - packs and returns 32-bit header
+ *
+ * @hdr: pointer to header containing all the information on message id,
+ *    protocol id and type id.
+ *
+ * Return: 32-bit packed message header to be sent to the platform.
+ */
+static inline uint32_t pack_scmi_header(scmi_msg_header_t *hdr)
+{
+    return FIELD_PREP(HDR_ID, hdr->id) |
+        FIELD_PREP(HDR_TYPE, hdr->type) |
+        FIELD_PREP(HDR_PROTO, hdr->protocol);
+}
+
+/*
+ * unpack_scmi_header() - unpacks and records message and protocol id
+ *
+ * @msg_hdr: 32-bit packed message header sent from the platform
+ * @hdr: pointer to header to fetch message and protocol id.
+ */
+static inline void unpack_scmi_header(uint32_t msg_hdr, scmi_msg_header_t =
*hdr)
+{
+    hdr->id =3D FIELD_GET(HDR_ID, msg_hdr);
+    hdr->type =3D FIELD_GET(HDR_TYPE, msg_hdr);
+    hdr->protocol =3D FIELD_GET(HDR_PROTO, msg_hdr);
+}
+
+static inline int channel_is_free(struct scmi_channel *chan_info)
+{
+    return ( chan_info->shmem->channel_status
+            & SCMI_SHMEM_CHAN_STAT_CHANNEL_FREE ) ? 0 : -EBUSY;
+}
+
+/*
+ * Copy data from IO memory space to "real" memory space.
+ */
+void __memcpy_fromio(void *to, const volatile void __iomem *from, size_t c=
ount)
+{
+    while (count && !IS_ALIGNED((unsigned long)from, 4)) {
+        *(u8 *)to =3D __raw_readb(from);
+        from++;
+        to++;
+        count--;
+    }
+
+    while (count >=3D 4) {
+        *(u32 *)to =3D __raw_readl(from);
+        from +=3D 4;
+        to +=3D 4;
+        count -=3D 4;
+    }
+
+    while (count) {
+        *(u8 *)to =3D __raw_readb(from);
+        from++;
+        to++;
+        count--;
+    }
+}
+
+/*
+ * Copy data from "real" memory space to IO memory space.
+ */
+void __memcpy_toio(volatile void __iomem *to, const void *from, size_t cou=
nt)
+{
+    while (count && !IS_ALIGNED((unsigned long)to, 4)) {
+        __raw_writeb(*(u8 *)from, to);
+        from++;
+        to++;
+        count--;
+    }
+
+    while (count >=3D 4) {
+        __raw_writel(*(u32 *)from, to);
+        from +=3D 4;
+        to +=3D 4;
+        count -=3D 4;
+    }
+
+    while (count) {
+        __raw_writeb(*(u8 *)from, to);
+        from++;
+        to++;
+        count--;
+    }
+}
+
+static int send_smc_message(struct scmi_channel *chan_info,
+                            scmi_msg_header_t *hdr, void *data, int len)
+{
+    struct arm_smccc_res resp;
+    int ret;
+
+    if ( (len + sizeof(chan_info->shmem->msg_header)) >
+                         SCMI_SHMEM_MAPPED_SIZE )
+    {
+        printk(XENLOG_ERR
+               "scmi: Wrong size of smc message. Data is invalid\n");
+        return -EINVAL;
+    }
+
+    printk(XENLOG_DEBUG "scmi: status =3D%d len=3D%d\n",
+           chan_info->shmem->channel_status, len);
+    printk(XENLOG_DEBUG "scmi: header id =3D %d type =3D %d, proto =3D %d\=
n",
+           hdr->id, hdr->type, hdr->protocol);
+
+    ret =3D channel_is_free(chan_info);
+    if ( IS_ERR_VALUE(ret) )
+        return ret;
+
+    chan_info->shmem->channel_status =3D 0x0;
+    /* Writing 0x0 right now, but SCMI_SHMEM_FLAG_INTR_ENABLED can be set =
*/
+    chan_info->shmem->flags =3D 0x0;
+    chan_info->shmem->length =3D sizeof(chan_info->shmem->msg_header) + le=
n;
+    chan_info->shmem->msg_header =3D pack_scmi_header(hdr);
+
+    printk(XENLOG_DEBUG "scmi: Writing to shmem address %p\n",
+           chan_info->shmem);
+    if ( len > 0 && data )
+        __memcpy_toio((void *)(chan_info->shmem->msg_payload), data, len);
+
+    arm_smccc_smc(chan_info->func_id, 0, 0, 0, 0, 0, 0, chan_info->chan_id=
,
+                  &resp);
+
+    printk(XENLOG_DEBUG "scmi: scmccc_smc response %d\n", (int)(resp.a0));
+
+    if ( resp.a0 )
+        return -EOPNOTSUPP;
+
+    return 0;
+}
+
+static int check_scmi_status(int scmi_status)
+{
+    if ( scmi_status =3D=3D SCMI_SUCCESS )
+        return 0;
+
+    printk(XENLOG_DEBUG "scmi: Error received: %d\n", scmi_status);
+
+    switch ( scmi_status )
+    {
+    case SCMI_NOT_SUPPORTED:
+        return -EOPNOTSUPP;
+    case SCMI_INVALID_PARAMETERS:
+        return -EINVAL;
+    case SCMI_DENIED:
+        return -EACCES;
+    case SCMI_NOT_FOUND:
+        return -ENOENT;
+    case SCMI_OUT_OF_RANGE:
+        return -ERANGE;
+    case SCMI_BUSY:
+        return -EBUSY;
+    case SCMI_COMMS_ERROR:
+        return -ENOTCONN;
+    case SCMI_GENERIC_ERROR:
+        return -EIO;
+    case SCMI_HARDWARE_ERROR:
+        return -ENXIO;
+    case SCMI_PROTOCOL_ERROR:
+        return -EBADMSG;
+    default:
+        return -EINVAL;
+    }
+}
+
+static int get_smc_response(struct scmi_channel *chan_info,
+                            scmi_msg_header_t *hdr, void *data, int len)
+{
+    int recv_len;
+    int ret;
+
+    printk(XENLOG_DEBUG "scmi: get smc responce msgid %d\n", hdr->id);
+
+    if ( len >=3D SCMI_SHMEM_MAPPED_SIZE - sizeof(chan_info->shmem) )
+    {
+        printk(XENLOG_ERR
+               "scmi: Wrong size of input smc message. Data may be invalid=
\n");
+        return -EINVAL;
+    }
+
+    ret =3D channel_is_free(chan_info);
+    if ( IS_ERR_VALUE(ret) )
+        return ret;
+
+    recv_len =3D chan_info->shmem->length - sizeof(chan_info->shmem->msg_h=
eader);
+
+    if ( recv_len < 0 )
+    {
+        printk(XENLOG_ERR
+               "scmi: Wrong size of smc message. Data may be invalid\n");
+        return -EINVAL;
+    }
+
+    if ( recv_len > len )
+    {
+        printk(XENLOG_ERR
+               "scmi: Not enough buffer for message %d, expecting %d\n",
+               recv_len, len);
+        return -EINVAL;
+    }
+
+    unpack_scmi_header(chan_info->shmem->msg_header, hdr);
+
+    if ( recv_len > 0 )
+    {
+        __memcpy_fromio(data, chan_info->shmem->msg_payload, recv_len);
+    }
+
+    return 0;
+}
+
+static int do_smc_xfer(struct scmi_channel *channel, scmi_msg_header_t *hd=
r, void *tx_data, int tx_size,
+                       void *rx_data, int rx_size)
+{
+    int ret =3D 0;
+
+    ASSERT( channel && channel->shmem);
+
+    if ( !hdr )
+        return -EINVAL;
+
+    spin_lock(&channel->lock);
+
+    ret =3D send_smc_message(channel, hdr, tx_data, tx_size);
+    if ( ret )
+        goto clean;
+
+    ret =3D get_smc_response(channel, hdr, rx_data, rx_size);
+clean:
+    spin_unlock(&channel->lock);
+
+    return ret;
+}
+
+static struct scmi_channel *get_channel_by_id(uint8_t chan_id)
+{
+    struct scmi_channel *curr;
+    bool found =3D false;
+
+    spin_lock(&scmi_data.channel_list_lock);
+    list_for_each_entry(curr, &scmi_data.channel_list, list)
+    {
+        if ( curr->chan_id =3D=3D chan_id )
+        {
+            found =3D true;
+            break;
+        }
+    }
+
+    spin_unlock(&scmi_data.channel_list_lock);
+    if ( found )
+        return curr;
+
+    return NULL;
+}
+
+static struct scmi_channel *aquire_scmi_channel(domid_t domain_id)
+{
+    struct scmi_channel *curr;
+    bool found =3D false;
+
+    ASSERT(domain_id !=3D DOMID_INVALID && domain_id >=3D 0);
+
+    spin_lock(&scmi_data.channel_list_lock);
+    list_for_each_entry(curr, &scmi_data.channel_list, list)
+    {
+        if ( curr->domain_id =3D=3D DOMID_INVALID )
+        {
+            curr->domain_id =3D domain_id;
+            found =3D true;
+            break;
+        }
+    }
+
+    spin_unlock(&scmi_data.channel_list_lock);
+    if ( found )
+        return curr;
+
+    return NULL;
+}
+
+static void relinquish_scmi_channel(struct scmi_channel *channel)
+{
+    ASSERT(channel !=3D NULL);
+
+    spin_lock(&scmi_data.channel_list_lock);
+    channel->domain_id =3D DOMID_INVALID;
+    spin_unlock(&scmi_data.channel_list_lock);
+}
+
+static int map_channel_memory(struct scmi_channel *channel)
+{
+    ASSERT( channel && channel->paddr );
+    channel->shmem =3D ioremap_cache(channel->paddr, SCMI_SHMEM_MAPPED_SIZ=
E);
+    if ( !channel->shmem )
+        return -ENOMEM;
+
+    channel->shmem->channel_status =3D SCMI_SHMEM_CHAN_STAT_CHANNEL_FREE;
+    printk(XENLOG_DEBUG "scmi: Got shmem after vmap %p\n", channel->shmem)=
;
+    return 0;
+}
+
+static void unmap_channel_memory(struct scmi_channel *channel)
+{
+    ASSERT( channel && channel->shmem );
+    iounmap(channel->shmem);
+    channel->shmem =3D NULL;
+}
+
+static struct scmi_channel *smc_create_channel(uint8_t chan_id,
+                                               uint32_t func_id, uint64_t =
addr)
+{
+    struct scmi_channel *channel;
+
+    channel =3D get_channel_by_id(chan_id);
+    if ( channel )
+        return ERR_PTR(EEXIST);
+
+    channel =3D xmalloc(struct scmi_channel);
+    if ( !channel )
+        return ERR_PTR(ENOMEM);
+
+    channel->chan_id =3D chan_id;
+    channel->func_id =3D func_id;
+    channel->domain_id =3D DOMID_INVALID;
+    channel->shmem =3D NULL;
+    channel->paddr =3D addr;
+    spin_lock_init(&channel->lock);
+    spin_lock(&scmi_data.channel_list_lock);
+    list_add(&channel->list, &scmi_data.channel_list);
+    spin_unlock(&scmi_data.channel_list_lock);
+    return channel;
+}
+
+static int mem_permit_access(struct domain *d, uint64_t addr, uint64_t len=
)
+{
+    return iomem_permit_access(d, paddr_to_pfn(addr),
+                paddr_to_pfn(PAGE_ALIGN(addr + len -1)));
+}
+
+static int mem_deny_access(struct domain *d, uint64_t addr,
+                                     uint64_t len)
+{
+    return iomem_deny_access(d, paddr_to_pfn(addr),
+                paddr_to_pfn(PAGE_ALIGN(addr + len -1)));
+}
+
+static int dt_update_domain_range(uint64_t addr, uint64_t size)
+{
+    struct dt_device_node *shmem_node;
+    __be32 *hw_reg;
+    const struct dt_property *pp;
+    uint32_t len;
+
+    shmem_node =3D dt_find_compatible_node(NULL, NULL, SCMI_SHARED_MEMORY)=
;
+    if ( !shmem_node )
+    {
+        printk(XENLOG_ERR "scmi: Unable to find %s node in DT\n", SCMI_SHM=
EM);
+        return -EINVAL;
+    }
+
+    pp =3D dt_find_property(shmem_node, "reg", &len);
+    if ( !pp )
+    {
+        printk(XENLOG_ERR "scmi: Unable to find regs entry in shmem node\n=
");
+        return -ENOENT;
+    }
+
+    hw_reg =3D pp->value;
+    dt_set_range(&hw_reg, shmem_node, addr, size);
+
+    return 0;
+}
+
+static void free_channel_list(void)
+{
+    struct scmi_channel *curr, *_curr;
+
+    spin_lock(&scmi_data.channel_list_lock);
+    list_for_each_entry_safe (curr, _curr, &scmi_data.channel_list, list)
+    {
+        list_del(&curr->list);
+        xfree(curr);
+    }
+
+    spin_unlock(&scmi_data.channel_list_lock);
+}
+
+static struct dt_device_node *get_dt_node_from_property(
+                struct dt_device_node *node, const char * p_name)
+{
+    const __be32 *prop;
+
+    ASSERT( node );
+
+    prop =3D dt_get_property(node, p_name, NULL);
+    if ( !prop )
+        return ERR_PTR(-EINVAL);
+
+    return dt_find_node_by_phandle(be32_to_cpup(prop));
+}
+
+static int get_shmem_regions(struct list_head *head, u64 hyp_addr)
+{
+    struct dt_device_node *node;
+    int ret;
+    struct dt_channel_addr *lchan;
+    u64 laddr, lsize;
+
+    node =3D dt_find_compatible_node(NULL, NULL, SCMI_SHARED_MEMORY);
+    if ( !node )
+        return -ENOENT;
+
+    while ( node )
+    {
+        ret =3D dt_device_get_address(node, 0, &laddr, &lsize);
+        if ( ret )
+            return ret;
+
+        if ( laddr !=3D hyp_addr )
+        {
+            lchan =3D xmalloc(struct dt_channel_addr);
+            if ( !lchan )
+                return -ENOMEM;
+            lchan->addr =3D laddr;
+            lchan->size =3D lsize;
+
+            list_add_tail(&lchan->list, head);
+        }
+
+        node =3D dt_find_compatible_node(node, NULL, SCMI_SHARED_MEMORY);
+    }
+
+    return 0;
+}
+
+static int read_hyp_channel_addr(struct dt_device_node *scmi_node,
+                                 u64 *addr, u64 *size)
+{
+    struct dt_device_node *shmem_node;
+    shmem_node =3D get_dt_node_from_property(scmi_node, "shmem");
+    if ( IS_ERR_OR_NULL(shmem_node) )
+    {
+        printk(XENLOG_ERR
+               "scmi: Device tree error, can't parse reserved memory %ld\n=
",
+               PTR_ERR(shmem_node));
+        return PTR_ERR(shmem_node);
+    }
+
+    return dt_device_get_address(shmem_node, 0, addr, size);
+}
+
+static void free_shmem_regions(struct list_head *addr_list)
+{
+    struct dt_channel_addr *curr, *_curr;
+
+    list_for_each_entry_safe (curr, _curr, addr_list, list)
+    {
+        list_del(&curr->list);
+        xfree(curr);
+    }
+}
+
+static __init bool scmi_probe(struct dt_device_node *scmi_node)
+{
+    u64 addr, size;
+    int ret, i;
+    struct scmi_channel *channel, *agent_channel;
+    int n_agents;
+    scmi_msg_header_t hdr;
+    struct rx_t {
+        int32_t status;
+        uint32_t attributes;
+    } rx;
+    struct dt_channel_addr *entry;
+    struct list_head addr_list;
+
+    uint32_t func_id;
+
+    ASSERT(scmi_node !=3D NULL);
+
+    INIT_LIST_HEAD(&scmi_data.channel_list);
+    spin_lock_init(&scmi_data.channel_list_lock);
+
+    if ( !dt_property_read_u32(scmi_node, SCMI_SMC_ID, &func_id) )
+    {
+        printk(XENLOG_ERR "scmi: Unable to read smc-id from DT\n");
+        return false;
+    }
+
+    ret =3D read_hyp_channel_addr(scmi_node, &addr, &size);
+    if ( IS_ERR_VALUE(ret) )
+        return false;
+
+    if ( !IS_ALIGNED(size, SCMI_SHMEM_MAPPED_SIZE) )
+    {
+        printk(XENLOG_ERR "scmi: Reserved memory is not aligned\n");
+        return false;
+    }
+
+    INIT_LIST_HEAD(&addr_list);
+
+    ret =3D get_shmem_regions(&addr_list, addr);
+    if ( IS_ERR_VALUE(ret) )
+        goto out;
+
+    channel =3D smc_create_channel(HYP_CHANNEL, func_id, addr);
+    if ( IS_ERR(channel) )
+        goto out;
+
+    ret =3D map_channel_memory(channel);
+    if ( ret )
+        goto out;
+
+    spin_lock(&scmi_data.channel_list_lock);
+    channel->domain_id =3D DOMID_XEN;
+    spin_unlock(&scmi_data.channel_list_lock);
+
+    hdr.id =3D SCMI_BASE_PROTOCOL_ATTIBUTES;
+    hdr.type =3D 0;
+    hdr.protocol =3D SCMI_BASE_PROTOCOL;
+
+    ret =3D do_smc_xfer(channel, &hdr, NULL, 0, &rx, sizeof(rx));
+    if ( ret )
+        goto error;
+
+    ret =3D check_scmi_status(rx.status);
+    if ( ret )
+        goto error;
+
+    n_agents =3D FIELD_GET(MSG_N_AGENTS_MASK, rx.attributes);
+    printk(XENLOG_DEBUG "scmi: Got agent count %d\n", n_agents);
+
+    i =3D 1;
+    list_for_each_entry(entry, &addr_list, list)
+    {
+        uint32_t tx_agent_id =3D 0xFFFFFFFF;
+        struct {
+            int32_t status;
+            uint32_t agent_id;
+            char name[16];
+        } da_rx;
+
+        agent_channel =3D smc_create_channel(i, func_id,
+                                           entry->addr);
+        if ( IS_ERR(agent_channel) )
+        {
+            ret =3D PTR_ERR(agent_channel);
+            goto error;
+        }
+
+        ret =3D map_channel_memory(agent_channel);
+        if ( ret )
+            goto error;
+
+        hdr.id =3D SCMI_BASE_DISCOVER_AGENT;
+        hdr.type =3D 0;
+        hdr.protocol =3D SCMI_BASE_PROTOCOL;
+
+        ret =3D do_smc_xfer(agent_channel, &hdr, &tx_agent_id,
+                          sizeof(tx_agent_id), &da_rx, sizeof(da_rx));
+        if ( ret )
+        {
+            unmap_channel_memory(agent_channel);
+            goto error;
+        }
+
+        unmap_channel_memory(agent_channel);
+
+        ret =3D check_scmi_status(da_rx.status);
+        if ( ret )
+            goto error;
+
+        printk(XENLOG_DEBUG "scmi: status=3D0x%x id=3D0x%x name=3D%s\n",
+                da_rx.status, da_rx.agent_id, da_rx.name);
+
+        agent_channel->agent_id =3D da_rx.agent_id;
+
+        if ( i =3D=3D n_agents )
+            break;
+
+        i++;
+    }
+
+    scmi_data.initialized =3D true;
+    goto out;
+
+error:
+    unmap_channel_memory(channel);
+    free_channel_list();
+out:
+    free_shmem_regions(&addr_list);
+    return ret =3D=3D 0;
+}
+
+static int scmi_domain_init(struct domain *d,
+                           struct xen_arch_domainconfig *config)
+{
+    struct scmi_channel *channel;
+    int ret;
+
+    if ( !scmi_data.initialized )
+        return 0;
+
+    printk(XENLOG_INFO "scmi: domain_id =3D %d\n", d->domain_id);
+
+    channel =3D aquire_scmi_channel(d->domain_id);
+    if ( IS_ERR_OR_NULL(channel) )
+        return -ENOENT;
+
+#ifdef CONFIG_ARM_32
+    printk(XENLOG_INFO
+           "scmi: Aquire SCMI channel id =3D 0x%x , domain_id =3D %d paddr=
 =3D 0x%llx\n",
+           channel->chan_id, channel->domain_id, channel->paddr);
+#else
+    printk(XENLOG_INFO
+           "scmi: Aquire SCMI channel id =3D 0x%x , domain_id =3D %d paddr=
 =3D 0x%lx\n",
+           channel->chan_id, channel->domain_id, channel->paddr);
+#endif
+
+    if ( is_hardware_domain(d) )
+    {
+        ret =3D mem_permit_access(d, channel->paddr, PAGE_SIZE);
+        if ( IS_ERR_VALUE(ret) )
+            goto error;
+
+        ret =3D dt_update_domain_range(channel->paddr, PAGE_SIZE);
+        if ( IS_ERR_VALUE(ret) )
+        {
+            int rc =3D mem_deny_access(d, channel->paddr, PAGE_SIZE);
+            if ( rc )
+                printk(XENLOG_ERR "Unable to mem_deny_access\n");
+
+            goto error;
+        }
+    }
+
+    d->arch.sci =3D channel;
+    if ( config )
+        config->arm_sci_agent_paddr =3D channel->paddr;
+
+    return 0;
+error:
+    relinquish_scmi_channel(channel);
+
+    return ret;
+}
+
+static int scmi_add_device_by_devid(struct domain *d, uint32_t scmi_devid)
+{
+    struct scmi_channel *channel, *agent_channel;
+    scmi_msg_header_t hdr;
+    struct scmi_perms_tx {
+        uint32_t agent_id;
+        uint32_t device_id;
+        uint32_t flags;
+    } tx;
+    struct rx_t {
+        int32_t status;
+        uint32_t attributes;
+    } rx;
+    int ret;
+
+    if ( !scmi_data.initialized )
+        return 0;
+
+    printk(XENLOG_DEBUG "scmi: scmi_devid =3D %d\n", scmi_devid);
+
+    agent_channel =3D d->arch.sci;
+    if ( IS_ERR_OR_NULL(agent_channel) )
+        return PTR_ERR(agent_channel);
+
+    channel =3D get_channel_by_id(HYP_CHANNEL);
+    if ( IS_ERR_OR_NULL(channel) )
+        return PTR_ERR(channel);
+
+    hdr.id =3D SCMI_BASE_SET_DEVICE_PERMISSIONS;
+    hdr.type =3D 0;
+    hdr.protocol =3D SCMI_BASE_PROTOCOL;
+
+    tx.agent_id =3D agent_channel->agent_id;
+    tx.device_id =3D scmi_devid;
+    tx.flags =3D SCMI_ALLOW_ACCESS;
+
+    ret =3D do_smc_xfer(channel, &hdr, &tx, sizeof(tx), &rx, sizeof(&rx));
+    if ( IS_ERR_VALUE(ret) )
+        return ret;
+
+    ret =3D check_scmi_status(rx.status);
+    if ( IS_ERR_VALUE(ret) )
+        return ret;
+
+    return 0;
+}
+
+static int scmi_add_dt_device(struct domain *d, struct dt_device_node *dev=
)
+{
+    uint32_t scmi_devid;
+
+    if ( (!scmi_data.initialized) || (!d->arch.sci) )
+        return 0;
+
+    if ( !dt_property_read_u32(dev, "scmi_devid", &scmi_devid) )
+        return 0;
+
+    printk(XENLOG_INFO "scmi: dt_node =3D %s\n", dt_node_full_name(dev));
+
+    return scmi_add_device_by_devid(d, scmi_devid);
+}
+
+static int scmi_relinquish_resources(struct domain *d)
+{
+    int ret;
+    struct scmi_channel *channel, *agent_channel;
+    scmi_msg_header_t hdr;
+    struct reset_agent_tx {
+        uint32_t agent_id;
+        uint32_t flags;
+    } tx;
+    uint32_t rx;
+
+    if ( !d->arch.sci )
+        return 0;
+
+    agent_channel =3D d->arch.sci;
+
+    spin_lock(&agent_channel->lock);
+    tx.agent_id =3D agent_channel->agent_id;
+    spin_unlock(&agent_channel->lock);
+
+    channel =3D get_channel_by_id(HYP_CHANNEL);
+    if ( !channel )
+    {
+        printk(XENLOG_ERR
+               "scmi: Unable to get Hypervisor scmi channel for domain %d\=
n",
+               d->domain_id);
+        return -EINVAL;
+    }
+
+    hdr.id =3D SCMI_BASE_RESET_AGENT_CONFIGURATION;
+    hdr.type =3D 0;
+    hdr.protocol =3D SCMI_BASE_PROTOCOL;
+
+    tx.flags =3D 0;
+
+    ret =3D do_smc_xfer(channel, &hdr, &tx, sizeof(tx), &rx, sizeof(rx));
+    if ( ret )
+        return ret;
+
+    ret =3D check_scmi_status(rx);
+
+    return ret;
+}
+
+static void scmi_domain_destroy(struct domain *d)
+{
+    struct scmi_channel *channel;
+
+    if ( !d->arch.sci )
+        return;
+
+    channel =3D d->arch.sci;
+    spin_lock(&channel->lock);
+
+    relinquish_scmi_channel(channel);
+    printk(XENLOG_DEBUG "scmi: Free domain %d\n", d->domain_id);
+
+    d->arch.sci =3D NULL;
+
+    mem_deny_access(d, channel->paddr, PAGE_SIZE);
+    spin_unlock(&channel->lock);
+}
+
+static bool scmi_handle_call(struct domain *d, void *args)
+{
+    bool res =3D false;
+    struct scmi_channel *agent_channel;
+    struct arm_smccc_res resp;
+    struct cpu_user_regs *regs =3D args;
+
+    if ( !d->arch.sci )
+        return false;
+
+    agent_channel =3D d->arch.sci;
+    spin_lock(&agent_channel->lock);
+
+    if ( agent_channel->func_id !=3D regs->r0 )
+    {
+        res =3D false;
+        goto unlock;
+    }
+
+    arm_smccc_smc(agent_channel->func_id, 0, 0, 0, 0, 0, 0,
+                  agent_channel->chan_id, &resp);
+
+    set_user_reg(regs, 0, resp.a0);
+    set_user_reg(regs, 1, resp.a1);
+    set_user_reg(regs, 2, resp.a2);
+    set_user_reg(regs, 3, resp.a3);
+    res =3D true;
+unlock:
+    spin_unlock(&agent_channel->lock);
+
+    return res;
+}
+
+static const struct dt_device_match scmi_smc_match[] __initconst =3D
+{
+    DT_MATCH_SCMI_SMC,
+    { /* sentinel */ },
+};
+
+static const struct sci_mediator_ops scmi_ops =3D
+{
+    .probe =3D scmi_probe,
+    .domain_init =3D scmi_domain_init,
+    .domain_destroy =3D scmi_domain_destroy,
+    .add_dt_device =3D scmi_add_dt_device,
+    .relinquish_resources =3D scmi_relinquish_resources,
+    .handle_call =3D scmi_handle_call,
+};
+
+REGISTER_SCI_MEDIATOR(scmi_smc, "SCMI-SMC", XEN_DOMCTL_CONFIG_ARM_SCI_SCMI=
_SMC,
+                      scmi_smc_match, &scmi_ops);
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
--=20
2.27.0


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 18:00:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 18:00:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268499.462415 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHUmz-0008Aq-5t; Tue, 08 Feb 2022 18:00:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268499.462415; Tue, 08 Feb 2022 18:00:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHUmy-00089X-Ol; Tue, 08 Feb 2022 18:00:28 +0000
Received: by outflank-mailman (input) for mailman id 268499;
 Tue, 08 Feb 2022 18:00:26 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TsJg=SX=epam.com=prvs=40387f30b1=oleksii_moisieiev@srs-se1.protection.inumbo.net>)
 id 1nHUmw-00068L-7U
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 18:00:26 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id fce3a86e-8908-11ec-8eb8-a37418f5ba1a;
 Tue, 08 Feb 2022 19:00:24 +0100 (CET)
Received: from pps.filterd (m0174678.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 218EgrTD015757;
 Tue, 8 Feb 2022 18:00:21 GMT
Received: from eur02-he1-obe.outbound.protection.outlook.com
 (mail-he1eur02lp2057.outbound.protection.outlook.com [104.47.5.57])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e3t5xrs6q-12
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Tue, 08 Feb 2022 18:00:21 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com (2603:10a6:102:ea::23)
 by VE1PR03MB5613.eurprd03.prod.outlook.com (2603:10a6:803:12a::29)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Tue, 8 Feb
 2022 18:00:14 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::c1c:f98:9dd:86e0]) by PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::c1c:f98:9dd:86e0%6]) with mapi id 15.20.4951.019; Tue, 8 Feb 2022
 18:00:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fce3a86e-8908-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=SYO9MKfe3IgWmXp7lo+Bl4ljmMGi1ae0L+UWUR0qgoRpJaNT7rSRNjgXUvM+ryHMd0aUQ5tSg8M+jTHvnwuWWIdO2It7fMXrYmRMIp60U2nJlHsiruGdC70p2Z8E2WvYgA6iRhpk+gzdPuZsLvFZZTtF8nUiSn4cE54I5NCgH5VwzrmBCvca65BsMp+SuU5/j6Au3YrRv0JfynDFvxk/eh/WjsJ2dG/QvyLZIjsqG3YORnYoxNxDQUAFYEJ/t4R7Vu2RCqMdFNwBoRkmF9EyGRL/3/bItFEGhWiAL/zyWdbIG358Jp9ZozEeg/NuwdGVlse5suyRG581NEIC/f7t5A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=jayupWuWbjhOz7yWgZER6E30JTnHsZKWIQYO2oKaWWE=;
 b=bH+qApmhRzaaPMNJqomFxCloTOyKpsTwMCjgekox1CZpv83ogBXgTHBDGWtb0Ld1zZDCaTPZ4AbKW6C87DBxvi9bI84IiwzgZ53o5mit3cjQjYrm7LjQCiQ4Ogg1bp8ZqJi4PMgnEYcOErksjNFQ54I0i1vXbUS07dyxD7bfQBqs7kwOVzKLEj3V6qZq6aWjmBhmiA7YeMe8vkBXb4M4C8wleEWSUR5bi+qQMTHpfT1BZv8ek9fxIsBAWmU6gnwyNYEY50fTOJHS/Shg+Gh0tddW9rClAfJdIeCj1yOuDb5vz18xVIhNrHqXbFvuhrc9bCfBQs4UhBFTBxmPDb25pw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=jayupWuWbjhOz7yWgZER6E30JTnHsZKWIQYO2oKaWWE=;
 b=SQ1KDkkWJX3kuq861ElC+WSGwMK7a6K9OsAr9YIq2ojajYWjVRCCD6OTyt4zpGrBGV3pV1Un14Ui5RS6coscRW4zBBjBABw9ddEE/KDqvnt2l/xOOn8/8gpYAELttIHcDzzN03wRGYZ0pGNK6awLhz9BTgYAfRWA1FvUTlyRZBAbKkUOQ87Nf03QPBgipuokh+EmDJ27TKfnmAOLQEgMRsTAM5mp+VyhmGXixwyCJIXhN31Vk+Buke8qCkrNaf/jykHKkubicVgppXgivFKrBDyoZxuZTu5XIm84x3tss9LPewENFhkJT6e7y6/Ki6OQWsgo+fDbcfHAe1pqsOIveA==
From: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>, Wei Liu <wl@xen.org>,
        Juergen Gross <jgross@suse.com>,
        Andrew Cooper <andrew.cooper3@citrix.com>,
        George Dunlap <george.dunlap@citrix.com>,
        Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>,
        Stefano Stabellini <sstabellini@kernel.org>,
        Anthony PERARD <anthony.perard@citrix.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>
Subject: [RFC v2 8/8] xen/arm: add SCI mediator support for DomUs
Thread-Topic: [RFC v2 8/8] xen/arm: add SCI mediator support for DomUs
Thread-Index: AQHYHRW5DNy0UeL9wEisMLPQvzYWsg==
Date: Tue, 8 Feb 2022 18:00:14 +0000
Message-ID: 
 <8aaab52f54841ebcf31a8f5fc6f1f8fd0b778e49.1644341635.git.oleksii_moisieiev@epam.com>
References: <cover.1644341635.git.oleksii_moisieiev@epam.com>
In-Reply-To: <cover.1644341635.git.oleksii_moisieiev@epam.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 1d8aa3d6-94a8-4c12-78de-08d9eb2cdbd2
x-ms-traffictypediagnostic: VE1PR03MB5613:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <VE1PR03MB561361DA9A2BF06711B1E0FDE32D9@VE1PR03MB5613.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:538;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 rqxqne92tNVg0gXi1RQ1NO7eQOSv0cZvEyQLrHBW9kvSdYIC9sC5usBbMqoaUOMHYXnIChGrP+Z/YOGYqZSnIJTvlhoqtlp8r5QM+af1SG63r5aiCo1xGMTWOmreJsUj/+a/6RaEw8OCAqfhRCNRv2OQSdhrLux3S0K9365kjWktmT8ZbrVLNTfwnU3XGajHMFUV1BEID+Y2pxTRgl9OAmuGOHuBgJqhAJRqogQ7I2gHAmA3ptmhAD+5CgvGh88GWFno+tE7YlImDxEWah1hV0w0Omj3DaDC00JYTYpkDqn6HhzrvokzfwL2t8zrml7yy2DQXGwM3LwxNGe96NIntdifnsdDCCzJ4BERLjjouamm2idzO42yRcx90SPMETs9zFrhGBtMTQKtgoPyMVpCccYuBHPlJxg9ELJqsRcEGsHLG6K25aHXp9BOWDg5QuRzur+E5N5WA329PEpkWwJSo1ZoUJ3xY/uoC4MpCm+oeQDzbuPG3QzDOK0y3s3gdelU8V5tv7gDlptP39BQ4Rz57oQ+Kghg0j6K3q/z3y/5uQ5XPaEkSXz+HxoQz5yjONOt94jkZ3ajIcPAMn4EXfLVjMoSpX6+Sm3xfZRYlhT5QvpLa0Ha8Ag2wf84dDytbT+2DcdENjeTG5I1LZs7V54DDfN6zwY6N5Nq2kOO7cPtWY5kKUjyRZd2iwl5Paj38QmEVzgFliEhzHMHc9poEKV8/Q==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR03MB7136.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38070700005)(71200400001)(6486002)(508600001)(66476007)(64756008)(86362001)(66556008)(316002)(122000001)(6916009)(6506007)(2616005)(5660300002)(6512007)(7416002)(4326008)(83380400001)(54906003)(30864003)(2906002)(26005)(186003)(8676002)(76116006)(38100700002)(66446008)(66946007)(8936002)(36756003)(91956017);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?iso-8859-1?Q?Bb/o0zHOWJ4lAaakLRPPxROrgldRXBN4eTiPjo7EFECHkHlUv7I2bquMf4?=
 =?iso-8859-1?Q?RHIj+oA3bvv7OVD6Z/eKzuHwTdmaOaLGdT+G8moFqV/zHH5SbSMr3oEoGP?=
 =?iso-8859-1?Q?a0qoq+kRYbA+mETGE/MScrGaX3V/KPraHR0cetjYVUQv8t/llDXuUs4hGw?=
 =?iso-8859-1?Q?JQR4J+ybvPDB/ayJkcONjs1sRRerHcxcdHCWoDrdufIAN5gdoqnovhhMFS?=
 =?iso-8859-1?Q?xiIAJ8NBu5U9p+zV3CDH9WZwSkt8uaoyNALUsgVTJ9kafXiSEoIveQV6EQ?=
 =?iso-8859-1?Q?5S3h7UvVC9UsUw1hYOtr71nLQbd1Ri1ZoIXiuxZujZvBDnBTy+z8mtrx7g?=
 =?iso-8859-1?Q?Vtbnqjvj8V2tZ3KWFpH56xuqxvyPqoK7YZQhCAv4uGLhjNWXebO16pEquZ?=
 =?iso-8859-1?Q?a/zhfOpYY5hFC3IQsQd2sYoYyiQ2XGSSMBtqRqUL4FTQ4XQy5yhRVZcWbV?=
 =?iso-8859-1?Q?lrGcaCagkE5GK7R+pDC7LuED6OSXde0xpVAfdKParxIgytJsXpTeL1SQgU?=
 =?iso-8859-1?Q?c67E+MDAPJRol0v2KU2bsH7vt6pjieS/XXVpvOSY2plf+yRi3H1wd983YB?=
 =?iso-8859-1?Q?IR1uAxAnIv/hN/AnIdIn1BauRERwnQYSuLCJU45+/ZYB2jvnca5XB4m7o4?=
 =?iso-8859-1?Q?jfRBTwt/98C14/u0tVZp3nH11fnqdCUZCrHWCfohvPD5NJ9JqDIF535T79?=
 =?iso-8859-1?Q?ycsAdV38Zu2NfmKxTCCWiT7q/EAQU7FeM2QR+QlBebNhdboXObypNi8X7L?=
 =?iso-8859-1?Q?d/GoLGXpgT5mdYxFjaQWRWW5WpnQgeHDmZWWooBZunk+beXWoXoSgoZ4qg?=
 =?iso-8859-1?Q?kwj8U4VKIbA45w5HDU67/v0utBaekfV4W5MkJqik8d7xXMpxw/a9WDxGPR?=
 =?iso-8859-1?Q?fwvt1cM2ETs7GuFIO0A+qyQQ+wdnzSNUtkQpXYY49ji6C9CGxPthTBXb3t?=
 =?iso-8859-1?Q?TEnu7UpMygcbyuXJWGdu9dJL5NZBXWZF5uXcpIJkrTSmnNyWWLFH0u/hBt?=
 =?iso-8859-1?Q?xFg2PFIAM0ftVJSpc2kfbv/y3K2jYZMZJRJitn7FDF8GOD2dWsVm0o9ovJ?=
 =?iso-8859-1?Q?7zUHjcMFbSf2Gc5pl+t+1dShYxUia4Ja84r3LlUljHx7LzAa1E2AiUEKxW?=
 =?iso-8859-1?Q?yfVtLj1etsCcD2YhVEuecIaRt0+Ao3aGt49APiSOyYCh8K5EIKJ+h8KO8y?=
 =?iso-8859-1?Q?tbq3TWy15iKGSO/Swt+z7D0U/ON5t5eCJYHDFkFi4X8BgcIhnYYJXgFNud?=
 =?iso-8859-1?Q?Wq1vnN9mdhdxFAXshIsZ0L7nrlpbiKn+x2iOnf3GgH3QMbdNdvANQtgnKl?=
 =?iso-8859-1?Q?+2BZMhiTiWNHfOcL1lod4Gcey1TUEt8EE41g2ORe+SQCEhB3ywL9+ml61Y?=
 =?iso-8859-1?Q?mfh3O5im86xH+J2DdyXgTMebsxlEyiNDuJYu+64iY9jr6CXVRnHoGeb+KF?=
 =?iso-8859-1?Q?GDdjBJiFSQJkmuxRnnCaWFEtykHY9Cyn2fbXtvih54jJ4wVWHuiELNIDfT?=
 =?iso-8859-1?Q?Yrw+4Jlik2wwZsEWR+13TZysjbbuiqSu+A5n4hTDqZtZdlyG+65WrpEEvR?=
 =?iso-8859-1?Q?GNr+71Rvlvi5m5WWXtDlKZydZip+goQB0EnMGm639cGxRoQJJjqzI0Eexc?=
 =?iso-8859-1?Q?G3yUkVJerzh5Q1m9UXC48/tuOKRq4uKCRMx89J5W95bx/DHy/coIGQ40+l?=
 =?iso-8859-1?Q?PZMnFGc3MEfInrpdP6FtmKRPkwS1wIyy62IGwJTP+KqhOSTm6SQ3vN7VvH?=
 =?iso-8859-1?Q?uLFoSlulh/JzWYEgreF8caZ5k=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR03MB7136.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1d8aa3d6-94a8-4c12-78de-08d9eb2cdbd2
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2022 18:00:14.7791
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: +r2E2QNZzlRK0MqL9DH03hTokkOFLMJtHCnQo2oVW6lsQyVQyOFTMrOHzsqjPm2whFJIbDef/fL2Md+FQIPYWX4VR8MFAYVVVaFZkR3WVyU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR03MB5613
X-Proofpoint-GUID: rMgEuywUpIi_Qn8ShMUDtOToY64rSaIr
X-Proofpoint-ORIG-GUID: rMgEuywUpIi_Qn8ShMUDtOToY64rSaIr
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-08_06,2022-02-07_02,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 spamscore=0
 priorityscore=1501 clxscore=1015 impostorscore=0 adultscore=0
 suspectscore=0 malwarescore=0 phishscore=0 lowpriorityscore=0
 mlxlogscore=999 bulkscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2201110000 definitions=main-2202080106

Integration of the SCMI mediator with xen libs:
- add hypercalls to aquire SCI channel and set device permissions
for DomUs;
- add SCMI_SMC nodes to DomUs device-tree based on partial device-tree;
- SCI requests redirection from DomUs to Firmware.

Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@epam.com>
---
 tools/include/xenctrl.h               |   3 +
 tools/libs/light/libxl_arm.c          | 214 ++++++++++++++++++++++++--
 tools/libs/light/libxl_create.c       |  44 +++++-
 tools/libs/light/libxl_internal.h     |   3 +
 xen/arch/arm/domctl.c                 |   7 +
 xen/include/public/device_tree_defs.h |   1 +
 6 files changed, 260 insertions(+), 12 deletions(-)

diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h
index 07b96e6671..cdd14f465f 100644
--- a/tools/include/xenctrl.h
+++ b/tools/include/xenctrl.h
@@ -1238,6 +1238,9 @@ int xc_domain_getvnuma(xc_interface *xch,
 int xc_domain_soft_reset(xc_interface *xch,
                          uint32_t domid);
=20
+int xc_domain_add_sci_device(xc_interface *xch,
+                              uint32_t domid, char *path);
+
 #if defined(__i386__) || defined(__x86_64__)
 /*
  * PC BIOS standard E820 types and structure.
diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c
index c5090e2b32..106ff33c84 100644
--- a/tools/libs/light/libxl_arm.c
+++ b/tools/libs/light/libxl_arm.c
@@ -7,6 +7,12 @@
 #include <libfdt.h>
 #include <assert.h>
 #include <xen/device_tree_defs.h>
+#include <xenhypfs.h>
+
+#define SCMI_NODE_PATH         "/firmware/scmi"
+#define SCMI_NODE_COMPATIBLE   "arm,scmi-smc"
+#define SCMI_SHMEM_COMPATIBLE  "arm,scmi-shmem"
+#define HYPFS_DEVICETREE_PATH  "/devicetree"
=20
 static const char *gicv_to_string(libxl_gic_version gic_version)
 {
@@ -101,6 +107,19 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc,
         return ERROR_FAIL;
     }
=20
+    switch (d_config->b_info.arm_sci) {
+    case LIBXL_ARM_SCI_TYPE_NONE:
+        config->arch.arm_sci_type =3D XEN_DOMCTL_CONFIG_ARM_SCI_NONE;
+        break;
+    case LIBXL_ARM_SCI_TYPE_SCMI_SMC:
+        config->arch.arm_sci_type =3D XEN_DOMCTL_CONFIG_ARM_SCI_SCMI_SMC;
+        break;
+    default:
+        LOG(ERROR, "Unknown ARM_SCI type %d",
+            d_config->b_info.arm_sci);
+        return ERROR_FAIL;
+    }
+
     if (libxl_defbool_val(d_config->b_info.force_assign_without_iommu))
         config->iommu_opts |=3D XEN_DOMCTL_IOMMU_force_iommu;
=20
@@ -125,6 +144,7 @@ int libxl__arch_domain_save_config(libxl__gc *gc,
     }
=20
     state->clock_frequency =3D config->arch.clock_frequency;
+    state->arm_sci_agent_paddr =3D config->arch.arm_sci_agent_paddr;
=20
     return 0;
 }
@@ -505,9 +525,6 @@ static int make_optee_node(libxl__gc *gc, void *fdt)
     int res;
     LOG(DEBUG, "Creating OP-TEE node in dtb");
=20
-    res =3D fdt_begin_node(fdt, "firmware");
-    if (res) return res;
-
     res =3D fdt_begin_node(fdt, "optee");
     if (res) return res;
=20
@@ -520,9 +537,6 @@ static int make_optee_node(libxl__gc *gc, void *fdt)
     res =3D fdt_end_node(fdt);
     if (res) return res;
=20
-    res =3D fdt_end_node(fdt);
-    if (res) return res;
-
     return 0;
 }
=20
@@ -905,10 +919,9 @@ static int copy_node(libxl__gc *gc, void *fdt, void *p=
fdt,
     return 0;
 }
=20
-static int copy_node_by_path(libxl__gc *gc, const char *path,
-                             void *fdt, void *pfdt)
+static int get_path_nodeoff(const char *path, void *pfdt)
 {
-    int nodeoff, r;
+    int nodeoff;
     const char *name =3D strrchr(path, '/');
=20
     if (!name)
@@ -928,12 +941,189 @@ static int copy_node_by_path(libxl__gc *gc, const ch=
ar *path,
     if (strcmp(fdt_get_name(pfdt, nodeoff, NULL), name))
         return -FDT_ERR_NOTFOUND;
=20
+    return nodeoff;
+}
+
+static int copy_node_by_path(libxl__gc *gc, const char *path,
+                             void *fdt, void *pfdt)
+{
+    int nodeoff, r;
+
+    nodeoff =3D get_path_nodeoff(path, pfdt);
+    if (nodeoff < 0)
+        return nodeoff;
+
     r =3D copy_node(gc, fdt, pfdt, nodeoff, 0);
     if (r) return r;
=20
     return 0;
 }
=20
+static int make_scmi_shmem_node(libxl__gc *gc, void *fdt, void *pfdt)
+{
+    int res;
+    char buf[64];
+
+#ifdef CONFIG_ARM_32
+    snprintf(buf, sizeof(buf), "scp-shmem@%lx",
+             GUEST_SCI_SHMEM_BASE);
+#else
+    snprintf(buf, sizeof(buf), "scp-shmem@%llx",
+             GUEST_SCI_SHMEM_BASE);
+#endif
+
+    res =3D fdt_begin_node(fdt, buf);
+    if (res) return res;
+
+    res =3D fdt_property_compat(gc, fdt, 1, SCMI_SHMEM_COMPATIBLE);
+    if (res) return res;
+
+    res =3D fdt_property_regs(gc, fdt, GUEST_ROOT_ADDRESS_CELLS,
+                    GUEST_ROOT_SIZE_CELLS, 1,
+                    GUEST_SCI_SHMEM_BASE, GUEST_SCI_SHMEM_SIZE);
+    if (res) return res;
+
+    res =3D fdt_property_cell(fdt, "phandle", GUEST_PHANDLE_SCMI);
+    if (res) return res;
+
+    res =3D fdt_end_node(fdt);
+    if (res) return res;
+
+    return 0;
+}
+
+static int create_hypfs_property(struct xenhypfs_handle *hdl, void *fdt,
+                                 char *path, char *name)
+{
+    char *p, *result;
+    int ret =3D 0;
+    struct xenhypfs_dirent *ent;
+
+    if (strcmp(name, "shmem") =3D=3D 0)
+        return fdt_property_cell(fdt, name, GUEST_PHANDLE_SCMI);
+
+    ret =3D asprintf(&p, "%s%s", HYPFS_DEVICETREE_PATH, path);
+    result =3D xenhypfs_read_raw(hdl, p, &ent);
+    free(p);
+    if (!result)
+        return -EINVAL;
+
+    ret =3D fdt_property(fdt, name, result, ent->size);
+    free(result);
+    free(ent);
+
+    return ret;
+}
+static int create_hypfs_subnode(struct xenhypfs_handle *hdl, void *fdt,
+                                const char *path, const char *name)
+{
+    struct xenhypfs_dirent *ent;
+    unsigned int n, i;
+    char *p, *p_sub;
+    int res =3D 0;
+
+    res =3D asprintf(&p, "%s%s", HYPFS_DEVICETREE_PATH, path);
+    if (res < 0)
+        return -ENOMEM;
+
+    ent =3D xenhypfs_readdir(hdl, p, &n);
+    free(p);
+    if (!ent)
+        return -EINVAL;
+
+    res =3D fdt_begin_node(fdt, name);
+    if (res) return res;
+
+    for (i =3D 0; i < n; i++) {
+        res =3D asprintf(&p_sub,"%s/%s", path, ent[i].name);
+        if (res < 0)
+            break;
+
+        if (ent[i].type =3D=3D xenhypfs_type_dir)
+             res =3D create_hypfs_subnode(hdl, fdt, p_sub, ent[i].name);
+        else
+             res =3D create_hypfs_property(hdl, fdt, p_sub, ent[i].name);
+
+        free(p_sub);
+        if (res)
+            break;
+    }
+
+    res =3D fdt_end_node(fdt);
+    free(ent);
+    return res;
+}
+
+static int create_scmi_from_hypfs(void *fdt, const char *path)
+{
+    struct xenhypfs_handle *hdl;
+    int res;
+    hdl =3D xenhypfs_open(NULL, 0);
+    if (!hdl)
+        return -EINVAL;
+
+    res =3D create_hypfs_subnode(hdl, fdt, path, "scmi");
+    xenhypfs_close(hdl);
+
+    return res;
+}
+
+static int set_shmem_phandle(void *fdt, const char *scmi_node_copmat)
+{
+    uint32_t val;
+    int nodeoff =3D fdt_node_offset_by_compatible(fdt, 0, scmi_node_copmat=
);
+    if (nodeoff < 0)
+        return -EINVAL;
+
+    val =3D cpu_to_fdt32(GUEST_PHANDLE_SCMI);
+    return fdt_setprop_inplace(fdt, nodeoff, "shmem", &val, sizeof(val));
+}
+
+static int make_scmi_node(libxl__gc *gc, void *fdt, void *pfdt)
+{
+    int res =3D 0;
+    int nodeoff =3D
+        fdt_node_offset_by_compatible(pfdt, 0, SCMI_NODE_COMPATIBLE);
+    if (nodeoff > 0) {
+        res =3D copy_node(gc, fdt, pfdt, nodeoff, 0);
+        if (res) return res;
+
+        res =3D set_shmem_phandle(fdt, SCMI_NODE_COMPATIBLE);
+        if (res) return res;
+    }
+    else
+        res =3D create_scmi_from_hypfs(fdt, SCMI_NODE_PATH);
+
+    return res;
+}
+
+static int make_firmware_node(libxl__gc *gc, void *fdt, void *pfdt, int te=
e,
+                              int sci)
+{
+    int res;
+
+    if ((tee =3D=3D LIBXL_TEE_TYPE_NONE) && (sci =3D=3D LIBXL_ARM_SCI_TYPE=
_NONE))
+        return 0;
+
+    res =3D fdt_begin_node(fdt, "firmware");
+    if (res) return res;
+
+    if (tee =3D=3D LIBXL_TEE_TYPE_OPTEE) {
+       res =3D make_optee_node(gc, fdt);
+       if (res) return res;
+    }
+
+    if (sci =3D=3D LIBXL_ARM_SCI_TYPE_SCMI_SMC) {
+        res =3D make_scmi_node(gc, fdt, pfdt);
+        if (res) return res;
+    }
+
+    res =3D fdt_end_node(fdt);
+    if (res) return res;
+
+    return 0;
+}
+
 /*
  * The partial device tree is not copied entirely. Only the relevant bits =
are
  * copied to the guest device tree:
@@ -1091,8 +1281,10 @@ next_resize:
         if (info->arch_arm.vuart =3D=3D LIBXL_VUART_TYPE_SBSA_UART)
             FDT( make_vpl011_uart_node(gc, fdt, ainfo, dom) );
=20
-        if (info->tee =3D=3D LIBXL_TEE_TYPE_OPTEE)
-            FDT( make_optee_node(gc, fdt) );
+        if (info->arm_sci =3D=3D LIBXL_ARM_SCI_TYPE_SCMI_SMC)
+            FDT( make_scmi_shmem_node(gc, fdt, pfdt) );
+
+        FDT( make_firmware_node(gc, fdt, pfdt, info->tee, info->arm_sci) )=
;
=20
         if (d_config->num_pcidevs)
             FDT( make_vpci_node(gc, fdt, ainfo, dom) );
diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_creat=
e.c
index dcd09d32ba..f1f1e66275 100644
--- a/tools/libs/light/libxl_create.c
+++ b/tools/libs/light/libxl_create.c
@@ -596,6 +596,38 @@ out:
     return ret;
 }
=20
+static int map_sci_page(libxl__gc *gc, uint32_t domid, uint64_t paddr,
+                         uint64_t guest_addr)
+{
+    int ret;
+    uint64_t _paddr_pfn =3D paddr >> XC_PAGE_SHIFT;
+    uint64_t _guest_pfn =3D guest_addr >> XC_PAGE_SHIFT;
+
+    assert(paddr && guest_addr);
+    LOG(DEBUG, "iomem %"PRIx64, _paddr_pfn);
+
+    ret =3D xc_domain_iomem_permission(CTX->xch, domid, _paddr_pfn, 1, 1);
+    if (ret < 0) {
+        LOG(ERROR,
+              "failed give domain access to iomem page %"PRIx64,
+             _paddr_pfn);
+        return ret;
+    }
+
+    ret =3D xc_domain_memory_mapping(CTX->xch, domid,
+                                   _guest_pfn, _paddr_pfn,
+                                   1, 1);
+    if (ret < 0) {
+        LOG(ERROR,
+              "failed to map to domain iomem page %"PRIx64
+              " to guest address %"PRIx64,
+              _paddr_pfn, _guest_pfn);
+        return ret;
+    }
+
+    return 0;
+}
+
 int libxl__domain_make(libxl__gc *gc, libxl_domain_config *d_config,
                        libxl__domain_build_state *state,
                        uint32_t *domid, bool soft_reset)
@@ -762,6 +794,16 @@ int libxl__domain_make(libxl__gc *gc, libxl_domain_con=
fig *d_config,
         goto out;
     }
=20
+    if (d_config->b_info.arm_sci =3D=3D LIBXL_ARM_SCI_TYPE_SCMI_SMC) {
+        ret =3D map_sci_page(gc, *domid, state->arm_sci_agent_paddr,
+                            GUEST_SCI_SHMEM_BASE);
+        if (ret < 0) {
+            LOGED(ERROR, *domid, "map scmi fail");
+            rc =3D ERROR_FAIL;
+            goto out;
+        }
+    }
+
     dom_path =3D libxl__xs_get_dompath(gc, *domid);
     if (!dom_path) {
         rc =3D ERROR_FAIL;
@@ -1825,7 +1867,7 @@ static void libxl__add_dtdevs(libxl__egc *egc, libxl_=
_ao *ao, uint32_t domid,
         LOGD(DEBUG, domid, "Assign device \"%s\" to domain", dtdev->path);
         rc =3D xc_assign_dt_device(CTX->xch, domid, dtdev->path);
         if (rc < 0) {
-            LOGD(ERROR, domid, "xc_assign_dtdevice failed: %d", rc);
+            LOGD(ERROR, domid, "xc_assign_dt_device failed: %d", rc);
             goto out;
         }
     }
diff --git a/tools/libs/light/libxl_internal.h b/tools/libs/light/libxl_int=
ernal.h
index 0b4671318c..79f38b60d4 100644
--- a/tools/libs/light/libxl_internal.h
+++ b/tools/libs/light/libxl_internal.h
@@ -1407,6 +1407,9 @@ typedef struct {
     /* Whether this domain is being migrated/restored, or booting fresh.  =
Only
      * applicable to the primary domain, not support domains (e.g. stub QE=
MU). */
     bool restore;
+
+    /* arm_sci channel paddr to be set to device-tree node */
+    uint64_t arm_sci_agent_paddr;
 } libxl__domain_build_state;
=20
 _hidden void libxl__domain_build_state_init(libxl__domain_build_state *s);
diff --git a/xen/arch/arm/domctl.c b/xen/arch/arm/domctl.c
index 6245af6d0b..23c44f3a13 100644
--- a/xen/arch/arm/domctl.c
+++ b/xen/arch/arm/domctl.c
@@ -4,6 +4,7 @@
  * Copyright (c) 2012, Citrix Systems
  */
=20
+#include <asm/sci/sci.h>
 #include <xen/errno.h>
 #include <xen/guest_access.h>
 #include <xen/hypercall.h>
@@ -182,7 +183,13 @@ long arch_do_domctl(struct xen_domctl *domctl, struct =
domain *d,
         rc =3D subarch_do_domctl(domctl, d, u_domctl);
=20
         if ( rc =3D=3D -ENOSYS )
+        {
             rc =3D iommu_do_domctl(domctl, d, u_domctl);
+            if ( (rc) && (rc !=3D -ENOSYS) )
+                return rc;
+
+            rc =3D sci_do_domctl(domctl, d, u_domctl);
+        }
=20
         return rc;
     }
diff --git a/xen/include/public/device_tree_defs.h b/xen/include/public/dev=
ice_tree_defs.h
index 209d43de3f..f57684547b 100644
--- a/xen/include/public/device_tree_defs.h
+++ b/xen/include/public/device_tree_defs.h
@@ -7,6 +7,7 @@
  * onwards. Reserve a high value for the GIC phandle.
  */
 #define GUEST_PHANDLE_GIC (65000)
+#define GUEST_PHANDLE_SCMI (67000)
=20
 #define GUEST_ROOT_ADDRESS_CELLS 2
 #define GUEST_ROOT_SIZE_CELLS 2
--=20
2.27.0


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 18:10:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 18:10:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268584.462441 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHUwE-0003fe-Uj; Tue, 08 Feb 2022 18:10:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268584.462441; Tue, 08 Feb 2022 18:10:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHUwE-0003cw-NG; Tue, 08 Feb 2022 18:10:02 +0000
Received: by outflank-mailman (input) for mailman id 268584;
 Tue, 08 Feb 2022 18:10:01 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1rHF=SX=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nHUwD-0003Sy-Nw
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 18:10:01 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 53cc5cab-890a-11ec-8eb8-a37418f5ba1a;
 Tue, 08 Feb 2022 19:09:59 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 53cc5cab-890a-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644343799;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=r/2OFdLFluiUKzfzM+tz9rmzcXaHYU7oLqLx2nL9rWg=;
  b=R8p7jKxvXIXPwaBMIBxL727gZavS34k8oTK4+Keq2MUCWLRbuen/fP7F
   Nw0pN/1pZMPF1hgDyfviJGYGbUZnoKlvn/uEavu/G0KOhxLP6rKpMrM6C
   x2taxj6E9MeKQovUJQQWFOc2NK9XBNkf2PBt4SPmP3eJ4RPJejhf28DCC
   Y=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: dBJplvIeLSk9fTmGkAKUqYmm5dAHSWNBn6Kv+xz3DfUg5DNEpr/DdDX/3qVL8RBYJ1xezUkcW7
 gQe8ZEJv3ZQRqlvAN1i/tL19nMIWD4bnN/yLIvEUehwt4aSKdrSMY+he7sK+4W2+xz7vIthqBk
 fAcWZQDbfBaaex90OQ3qBzmkQgdhI9a1b+6wxtIMdBcETky/yhWoj3DFEaG5ybH1WTfbyGeHbs
 DmqAUFMl0SqgzUmSS76nT2XxzVH3nv2CFtxpqNkESLx46ZrzqWtMk0fQ8knc7Wy1KJbAWfMIC3
 JNwiKLNoXBct83X4iS6n63ZA
X-SBRS: 5.1
X-MesageID: 63762677
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:lXjFbKqpOGFwu020/RowMy017dheBmI7YhIvgKrLsJaIsI4StFCzt
 garIBmGP/aLYmT8fdl0YYu/8h4B6MeDx99rQAM6+Hw3ESNDp5uZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlZT4vE2xbuKU5NTsY0idfic5Dndx4f5fs7Rh2NQw24DpW1nlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCncWZcQVyFZ3Nou86SxV7VHx0ZqB09bCSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFKoZtmtt0nfyCvE+TIqYa67L+cVZzHE7gcUm8fP2O
 ZFGN2AxM0uojxtnCgpUBJAyudeS2VLcbxxzi3/KiJgs2j2GpOB2+Oe0a4eEEjCQfu1Fk0Ddq
 m/Y8mDRBhABKMfZ2TeD6mirhOLEgWX8Qo16KVGj3qc02hvJnDVVUUBIEwvgyRWktqKgc4t2E
 05P0Rovl6MV7ECICYT3BBCKrXHR63bwROFsO+E97QiMzI/d7ACYGnUIQ1Z9VTA2iCMlbWd0j
 wHUxrsFERQq6eTIEizFqt94uBvvYXB9EIMUWcMToeLpCfHHqZp7sB/AR80L/EWd3oysQmGYL
 9xnQUEDa1QvYSwjiv/TEbPv2WvESn31oukdvFS/Y45dxlklDLNJnqTxgbQh0d5OLZyCUn6Kt
 2Uels6V4YgmVM/RyHXcGbxTTevwvJ5p1QEwZnY1TvEcG8mFoSb/Lei8HhkiTKuWDir0UWCwO
 xKC0e+gzJRSIGGrfcdKj3GZUKwXIVzbPY29DJj8N4MWCrAoLVPv1Hw+NCa4gjG2+GBxwP5XE
 cnAK66EUy1FYZmLORLrHo/xJ5dwnXtgrY4SLLimpymaPU22PibKEOxYawvXNYjULsqs+W3oz
 jqWDOPSoz03bQE0SnO/HVc7IQ9YIH4lK4rxrsALJOePLhA/QDMqCuPLwKNncItgxvwHmuDN9
 3C7e0lZ1Fug2iGXdVTUMihuOOH1QJJyjXMnJihwb1ym7GcuPNS056AFepppIbR+rL5/zeR5R
 uUuctmbBqgdUSzO/jkQNMGvrIFreBmxqxiJOi6pPGo2c5J6HlSb8d74ZAr/siIJC3Pv58c5p
 rSh0CLdQIYCGFs+XJqHNqr3wgro73YHme90U0/ZGfVpeR3hoNpwNij8rv4rOMVQex/N8SSXi
 lSNChACqOiT/4JsqIvVhbqJppuCGvdlGhYIBHHS6Lu7OHWI/menxoMcAu+EcSqECTHx8aSmI
 +5U0+v9ILsMm1MT69hwFLNizKQf4drzpuAFklQ4TSuTN1n7WKl9JnSm3NVUsvwfz7BUjgK6R
 0aT94QIIr6OIs7kTAYcKQdNgj5vDh3Idu0+NcgIHXg=
IronPort-HdrOrdr: A9a23:a6ptG6nRYVai5PPNENCW9qc6MvXpDfIu3DAbv31ZSRFFG/Fxl6
 iV8sjztCWE8Qr5N0tBpTntAsW9qDbnhPtICOoqTNGftWvdyQiVxehZhOOIqVDd8m/Fh4pgPM
 9bAs9D4bbLbGSS4/yU3ODBKadD/OW6
X-IronPort-AV: E=Sophos;i="5.88,353,1635220800"; 
   d="scan'208";a="63762677"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH 3/6] x86/tsx: Cope with TSX deprecation on WHL-R/CFL-R
Date: Tue, 8 Feb 2022 18:09:39 +0000
Message-ID: <20220208180942.14871-4-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220208180942.14871-1-andrew.cooper3@citrix.com>
References: <20220208180942.14871-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

The February 2022 microcode is formally de-featuring TSX on the TAA-impacted
client CPUs.  The backup TAA mitigation (VERW regaining its flushing side
effect) is being dropped, meaning that `smt=0 spec-ctrl=md-clear` no longer
protects against TAA on these parts.

The new functionality enumerates itself via the RTM_ALWAYS_ABORT CPUID
bit (the same as June 2021), but has its control in MSR_MCU_OPT_CTRL as
opposed to MSR_TSX_FORCE_ABORT.

TSX now defaults to being disabled on ucode load.  Furthermore, if SGX is
enabled in the BIOS, TSX is locked and cannot be re-enabled.  In this case,
override opt_tsx to 0, so the RTM/HLE CPUID bits get hidden by default.

While updating the command line documentation, take the opportunity to add a
paragraph explaining what TSX being disabled actually means, and how migration
compatibility works.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
---
 docs/misc/xen-command-line.pandoc    | 25 +++++++++---
 xen/arch/x86/include/asm/msr-index.h |  2 +
 xen/arch/x86/spec_ctrl.c             |  7 +++-
 xen/arch/x86/tsx.c                   | 76 ++++++++++++++++++++++++++++++++++++
 4 files changed, 103 insertions(+), 7 deletions(-)

diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc
index 6b3da6ddc16c..8e75e592e70a 100644
--- a/docs/misc/xen-command-line.pandoc
+++ b/docs/misc/xen-command-line.pandoc
@@ -2387,7 +2387,9 @@ Several microcode updates are relevant:
    Introduced MSR_TSX_CTRL on all TSX-enabled MDS_NO parts to date,
    CLX/WHL-R/CFL-R, with the controls becoming architectural moving forward
    and formally retiring HLE from the architecture.  The user can disable TSX
-   to mitigate TAA, and elect to hide the HLE/RTM CPUID bits.
+   to mitigate TAA, and elect to hide the HLE/RTM CPUID bits.  Also causes
+   VERW to once-again flush the microarchiectural buffers in case a TAA
+   mitigation is wanted along with TSX being enabled.
 
  * June 2021, removing the workaround for March 2019 on client CPUs and
    formally de-featured TSX on SKL/KBL/WHL/CFL (Note: SKX still retains the
@@ -2395,19 +2397,32 @@ Several microcode updates are relevant:
    PCR3 works fine, and TSX is disabled by default, but the user can re-enable
    TSX at their own risk, accepting that the memory order erratum is unfixed.
 
+ * February 2022, removing the VERW flushing workaround from November 2019 on
+   client CPUs and formally de-featuring TSX on WHL-R/CFL-R (Note: CLX still
+   retains the VERW flushing workaround).  TSX defaults to disabled, and is
+   locked off when SGX is enabled in the BIOS.  When SGX is not enabled, TSX
+   can be re-enabled at the users own risk, as it reintroduces the TSX Async
+   Abort speculative vulnerability.
+
 On systems with the ability to configure TSX, this boolean offers system wide
 control of whether TSX is enabled or disabled.
 
+When TSX is disabled, transactions unconditionally abort.  This is compatible
+with the TSX spec, which requires software to have a non-transactional path as
+a fallback.  The RTM and HLE CPUID bits are hidden from VMs by default, but
+can be re-enabled if required.  This allows VMs which previously saw RTM/HLE
+to be migrated in, although any TSX-enabled software will run with reduced
+performance.
+
+ * When TSX is locked off by firmware, `tsx=` is ignored and treated as
+   `false`.
+
  * An explicit `tsx=` choice is honoured, even if it is `true` and would
    result in a vulnerable system.
 
  * When no explicit `tsx=` choice is given, parts vulnerable to TAA will be
    mitigated by disabling TSX, as this is the lowest overhead option.
 
-   If the use of TSX is important, the more expensive TAA mitigations can be
-   opted in to with `smt=0 spec-ctrl=md-clear`, at which point TSX will remain
-   active by default.
-
  * When no explicit `tsx=` option is given, parts susceptible to the memory
    ordering errata default to `true` to enable working TSX.  Alternatively,
    selecting `tsx=0` will disable TSX and restore PCR3 to a working state.
diff --git a/xen/arch/x86/include/asm/msr-index.h b/xen/arch/x86/include/asm/msr-index.h
index ab68ef2681a9..9df1959fe5a1 100644
--- a/xen/arch/x86/include/asm/msr-index.h
+++ b/xen/arch/x86/include/asm/msr-index.h
@@ -78,6 +78,8 @@
 
 #define MSR_MCU_OPT_CTRL                    0x00000123
 #define  MCU_OPT_CTRL_RNGDS_MITG_DIS        (_AC(1, ULL) <<  0)
+#define  MCU_OPT_CTRL_RTM_ALLOW             (_AC(1, ULL) <<  1)
+#define  MCU_OPT_CTRL_RTM_LOCKED            (_AC(1, ULL) <<  2)
 
 #define MSR_RTIT_OUTPUT_BASE                0x00000560
 #define MSR_RTIT_OUTPUT_MASK                0x00000561
diff --git a/xen/arch/x86/spec_ctrl.c b/xen/arch/x86/spec_ctrl.c
index 3628b4b4154f..2b93468d396e 100644
--- a/xen/arch/x86/spec_ctrl.c
+++ b/xen/arch/x86/spec_ctrl.c
@@ -1233,11 +1233,14 @@ void __init init_speculation_mitigations(void)
      * the MDS mitigation of disabling HT and using VERW flushing.
      *
      * On CPUs which advertise MDS_NO, VERW has no flushing side effect until
-     * the TSX_CTRL microcode is loaded, despite the MD_CLEAR CPUID bit being
+     * the TSX_CTRL microcode (Nov 2019), despite the MD_CLEAR CPUID bit being
      * advertised, and there isn't a MD_CLEAR_2 flag to use...
      *
+     * Furthermore, the VERW flushing side effect is removed again on client
+     * parts with the Feb 2022 microcode.
+     *
      * If we're on affected hardware, able to do something about it (which
-     * implies that VERW now works), no explicit TSX choice and traditional
+     * implies that VERW might work), no explicit TSX choice and traditional
      * MDS mitigations (no-SMT, VERW) not obviosuly in use (someone might
      * plausibly value TSX higher than Hyperthreading...), disable TSX to
      * mitigate TAA.
diff --git a/xen/arch/x86/tsx.c b/xen/arch/x86/tsx.c
index c3b8a7ec0076..be89741a2f6d 100644
--- a/xen/arch/x86/tsx.c
+++ b/xen/arch/x86/tsx.c
@@ -14,6 +14,9 @@
  * This is arranged such that the bottom bit encodes whether TSX is actually
  * disabled, while identifying various explicit (>=0) and implicit (<0)
  * conditions.
+ *
+ * This option only has any effect on systems presenting a mechanism of
+ * controlling TSX behaviour, and where TSX isn't force-disabled by firmware.
  */
 int8_t __read_mostly opt_tsx = -1;
 int8_t __read_mostly cpu_has_tsx_ctrl = -1;
@@ -54,6 +57,66 @@ void tsx_init(void)
         cpu_has_tsx_ctrl = !!(caps & ARCH_CAPS_TSX_CTRL);
         has_rtm_always_abort = cpu_has_rtm_always_abort;
 
+        if ( cpu_has_tsx_ctrl && cpu_has_srbds_ctrl )
+        {
+            /*
+             * On a TAA-vulnerable or later part with at least the May 2020
+             * microcode mitigating SRBDS.
+             */
+            uint64_t val;
+
+            rdmsrl(MSR_MCU_OPT_CTRL, val);
+
+            /*
+             * Probe for the February 2022 microcode which de-features TSX on
+             * TAA-vulnerable client parts - WHL-R/CFL-R.
+             *
+             * RTM_ALWAYS_ABORT (read above) enumerates the new functionality,
+             * but is read as zero if MCU_OPT_CTRL.RTM_ALLOW has been set
+             * before we run.  Undo this.
+             */
+            if ( val & MCU_OPT_CTRL_RTM_ALLOW )
+                has_rtm_always_abort = true;
+
+            if ( has_rtm_always_abort )
+            {
+                if ( val & MCU_OPT_CTRL_RTM_LOCKED )
+                {
+                    /*
+                     * If RTM_LOCKED is set, TSX is disabled because SGX is
+                     * enabled, and there is nothing we can do.  Override with
+                     * tsx=0 so all other logic takes sensible actions.
+                     */
+                    printk(XENLOG_WARNING "TSX locked by firmware - disabling\n");
+                    opt_tsx = 0;
+                }
+                else
+                {
+                    /*
+                     * Otherwise, set RTM_ALLOW.  Not because we necessarily
+                     * intend to enable RTM, but it prevents
+                     * MSR_TSX_CTRL.RTM_DISABLE from being ignored, thus
+                     * allowing the rest of the TSX selection logic to work as
+                     * before.
+                     */
+                    val |= MCU_OPT_CTRL_RTM_ALLOW;
+                }
+
+                set_in_mcu_opt_ctrl(
+                    MCU_OPT_CTRL_RTM_LOCKED | MCU_OPT_CTRL_RTM_ALLOW, val);
+
+                /*
+                 * If no explicit tsx= option is provided, pick a default.
+                 *
+                 * With RTM_ALWAYS_ABORT, the default ucode behaviour is to
+                 * disable, so match that.  This does not override explicit user
+                 * choices, or implicit choices as a side effect of spec-ctrl=0.
+                 */
+                if ( opt_tsx == -1 )
+                    opt_tsx = 0;
+            }
+        }
+
         if ( cpu_has_tsx_force_abort )
         {
             /*
@@ -142,6 +205,19 @@ void tsx_init(void)
      */
     if ( cpu_has_tsx_ctrl )
     {
+        /*
+         * On a TAA-vulnerable part with at least the November 2019 microcode,
+         * or newer part with TAA fixed.
+         *
+         * Notes:
+         *  - With the February 2022 microcode, if SGX has caused TSX to be
+         *    locked off, opt_tsx is overridden to 0.  TSX_CTRL.RTM_DISABLE is
+         *    an ignored bit, but we write it such that it matches the
+         *    behaviour enforced by microcode.
+         *  - Otherwise, if SGX isn't enabled and TSX is available to be
+         *    controlled, we have or will set MSR_MCU_OPT_CTRL.RTM_ALLOW to
+         *    let TSX_CTRL.RTM_DISABLE be usable.
+         */
         uint32_t hi, lo;
 
         rdmsr(MSR_TSX_CTRL, lo, hi);
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Tue Feb 08 18:10:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 18:10:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268586.462469 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHUwH-0004Ns-1e; Tue, 08 Feb 2022 18:10:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268586.462469; Tue, 08 Feb 2022 18:10:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHUwG-0004MA-M6; Tue, 08 Feb 2022 18:10:04 +0000
Received: by outflank-mailman (input) for mailman id 268586;
 Tue, 08 Feb 2022 18:10:03 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1rHF=SX=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nHUwF-0003Sy-8I
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 18:10:03 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 556eab12-890a-11ec-8eb8-a37418f5ba1a;
 Tue, 08 Feb 2022 19:10:02 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 556eab12-890a-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644343801;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=g1RCjDDHjvfnqi0gWZply1NwpJ3g8mhDOmKHxuxunaU=;
  b=YNigv7NUKC92uoYDVpCcGO1N/GDVbSL7ZU2mb15D4jy1nYYQWSvDdgVz
   jHlgYKu8iBFaxM4e7+CdHbugnwk2DhLm7Dl2wyHir7jnsWnnncR4r0/Nb
   7/zXhAfxVmDu6KLBu3p/MLUhmDR3CZ29PQS13bVJk9Ww1GVmemPoWduMG
   o=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: PeEkcvONsdQdzoHVRVqMhiksONHdZ43648AKJhApLzEufq3XLmeSFgUunjiEofJUQmB0THWPZ4
 SkxE4MFyMQuxaysvW0dyOnrgPVkWWpOhUvSGr9YnfATARq2KWVda1p6IkVrG28grF0o7G37wNk
 +FRNFdmOnxW3Ndz1c3gVfPCPSiyw089wtNwG5S8eFBxy9qBTiG1AUzNBlanfLUKO4KtgOCsUsa
 tUUXKUsiR4BjsbiT0GLpo1i6x9UojawRusiI7CKUoIPWuLzvKmXD00bGMyAzZWFdMrX6VPjj/2
 iw5uIJDUw7vHj0JEoVr71T3b
X-SBRS: 5.1
X-MesageID: 63762636
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:RJxsDaC9O6K1WRVW/wrkw5YqxClBgxIJ4kV8jS/XYbTApGgigzIHn
 2tJUW+Aa/eDYDSgL4pxPIyy8BwO78DczYM3QQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMo/u1Si6FatANl1ElvU2zbue6WL6s1hxZH1c+En970UI7wYbVv6Yz6TSHK1LV0
 T/Ni5W31G+Ng1aY5UpNtspvADs21BjDkGtwUm4WPJinj3eH/5UhN7oNJLnZEpfNatI88thW5
 Qr05OrREmvxp3/BAz4++1rxWhVirrX6ZWBihpfKMkQLb9crSiEai84G2PQghUh/iDm1hO18w
 s9xk6ezFyAtDvzFtvUPekwNe81+FfUuFL7vJHG+tYqYzlHccmuqyPJrZK00FdRGoKAtWzgIr
 KFGbmBWBvyAr7veLLaTY+9gnMk8auLsO5sSoCpIxjDFF/c2B5vERs0m4PcGh2hu3J4VQ54yY
 eJCcAdeRyj9RSdyAQ83WbUYhru21n7wJmgwRFW9+vNsvjm7IBZK+KjgNp/Zd8KHQe1Rn12Ev
 STW8mLhGBYYOdeDjz2f/RqRavTnxH2hHthITfvhq6As0Ab7KnEv5AM+VleHusS0gFSCfelcd
 WsQynsng7kg3Rn+JjXiZCGQrHmBtx8aftNfFewm9Q2AopbpDxal6nssFWAYNoF/3CMibXlzj
 wLSwYu1bdB6mODNERqgGqGoQSRe0MT/BUsLfmc6QAQM+LEPS6lj30uUHr6P/ENY5+AZ+A0cI
 RjX9kDSZJ1J1KbnMplXGnid0lqRSmDhFFJd2+kudjvNAvlFTICkfZe0zlPQ8OxNKo2UJnHY4
 iRYwpnHtb5fV8jW/MBofAnqNOv4j8tpzRWG2QI/d3Xf32jFF4GfkXB4v2gleRYB3jcscj71e
 k7D0T69F7cIVEZGmZRfOtrrY+xzlPCIPY28Cpj8M4ofCrAsJVTv1Hw/Oia4gTu3+GByyv5XB
 HtuWZv1ZZrsIf88l2TeqiZ0+eJD+x3SMkuJHc+ilEn8gePFDJNXIJ9cWGazgikCxPvsiG3oH
 xx3baNmEj1TD7/zZDf564kWIQxYJHQ3H8mu+cdWavSCMkxtH2R4U63dxrYoeopEmaVJl7iXo
 iHhCxEAkFev12faLQiqa2x4bO+9V5hIsn9mbzcnOkyl2iZ/bN/3vrsfbZY+YZIu6PdnkaxvV
 /AAdsjZWqZPRz3L9i4zd574qIA+Jh2niRjXZ3iuYSQlfo4mTAvMo4e2cgzq/SgILyy2qcph/
 OHwilKFGcIOHl0wAtzXZfSjy0KKkUIcwO8iDVHVJtRzeVn39NQ4ISLGkfJqcdoHLg/Ox2XG2
 l/OUwsYv+TEv6Q87MLN2fKft46sHuZzQhhaEm3c4erkPCXW5DP+k4pJUeLOdjHBTmLkvq6lY
 LwNnf37NfQGmndMspZ9TOk3nf5vuYO3qu8I1BlgEVXKc0+vW+FpLXSx1MVSsrFAm+1CsgysV
 0PTotRXNN1l4i8+/IL98Ob9Utm+6A==
IronPort-HdrOrdr: A9a23:B2eSJ6DcKqA/HJvlHemu55DYdb4zR+YMi2TC1yhKJyC9E/bo7v
 xG88566faZslossTQb6LW90cq7MBXhHPxOkOos1N6ZNWGM0gaVxcNZnO/fKlXbakrDH4VmtJ
 uIHZIQNDSJNykZsfrH
X-IronPort-AV: E=Sophos;i="5.88,353,1635220800"; 
   d="scan'208";a="63762636"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH 5/6] x86/cpuid: Infrastructure for cpuid word 7:2.edx
Date: Tue, 8 Feb 2022 18:09:41 +0000
Message-ID: <20220208180942.14871-6-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220208180942.14871-1-andrew.cooper3@citrix.com>
References: <20220208180942.14871-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

While in principle it would be nice to keep leaf 7 in order, that would
involve having an extra 5 words of zeros in a featureset.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
---
 tools/misc/xen-cpuid.c                      |  5 +++++
 xen/arch/x86/cpu/common.c                   |  4 ++++
 xen/include/public/arch-x86/cpufeatureset.h |  2 ++
 xen/include/xen/lib/x86/cpuid.h             | 13 ++++++++++++-
 4 files changed, 23 insertions(+), 1 deletion(-)

diff --git a/tools/misc/xen-cpuid.c b/tools/misc/xen-cpuid.c
index 3c8f3ed1bad1..40626296984b 100644
--- a/tools/misc/xen-cpuid.c
+++ b/tools/misc/xen-cpuid.c
@@ -200,6 +200,10 @@ static const char *const str_7b1[32] =
     [ 0] = "ppin",
 };
 
+static const char *const str_7d2[32] =
+{
+};
+
 static const struct {
     const char *name;
     const char *abbr;
@@ -219,6 +223,7 @@ static const struct {
     { "0x00000007:1.eax", "7a1", str_7a1 },
     { "0x80000021.eax",  "e21a", str_e21a },
     { "0x00000007:1.ebx", "7b1", str_7b1 },
+    { "0x00000007:2.edx", "7d2", str_7d2 },
 };
 
 #define COL_ALIGN "18"
diff --git a/xen/arch/x86/cpu/common.c b/xen/arch/x86/cpu/common.c
index d4f5028fa2ec..c4f07f2d1da4 100644
--- a/xen/arch/x86/cpu/common.c
+++ b/xen/arch/x86/cpu/common.c
@@ -447,6 +447,10 @@ static void generic_identify(struct cpuinfo_x86 *c)
 				    &c->x86_capability[FEATURESET_7a1],
 				    &c->x86_capability[FEATURESET_7b1],
 				    &tmp, &tmp);
+		if (max_subleaf >= 2)
+			cpuid_count(7, 2,
+				    &tmp, &tmp, &tmp,
+				    &c->x86_capability[FEATURESET_7d2]);
 	}
 
 	if (c->cpuid_level >= 0xd)
diff --git a/xen/include/public/arch-x86/cpufeatureset.h b/xen/include/public/arch-x86/cpufeatureset.h
index 957df23b65f2..81b0f5e0aad3 100644
--- a/xen/include/public/arch-x86/cpufeatureset.h
+++ b/xen/include/public/arch-x86/cpufeatureset.h
@@ -302,6 +302,8 @@ XEN_CPUFEATURE(NSCB,               11*32+ 6) /*A  Null Selector Clears Base (and
 /* Intel-defined CPU features, CPUID level 0x00000007:1.ebx, word 12 */
 XEN_CPUFEATURE(INTEL_PPIN,         12*32+ 0) /*   Protected Processor Inventory Number */
 
+/* Intel-defined CPU features, CPUID level 0x00000007:2.edx, word 13 */
+
 #endif /* XEN_CPUFEATURE */
 
 /* Clean up from a default include.  Close the enum (for C). */
diff --git a/xen/include/xen/lib/x86/cpuid.h b/xen/include/xen/lib/x86/cpuid.h
index e87036b30380..50be07c0eba0 100644
--- a/xen/include/xen/lib/x86/cpuid.h
+++ b/xen/include/xen/lib/x86/cpuid.h
@@ -17,6 +17,7 @@
 #define FEATURESET_7a1   10 /* 0x00000007:1.eax    */
 #define FEATURESET_e21a  11 /* 0x80000021.eax      */
 #define FEATURESET_7b1   12 /* 0x00000007:1.ebx    */
+#define FEATURESET_7d2   13 /* 0x80000007:2.edx    */
 
 struct cpuid_leaf
 {
@@ -82,7 +83,7 @@ const char *x86_cpuid_vendor_to_str(unsigned int vendor);
 
 #define CPUID_GUEST_NR_BASIC      (0xdu + 1)
 #define CPUID_GUEST_NR_CACHE      (5u + 1)
-#define CPUID_GUEST_NR_FEAT       (1u + 1)
+#define CPUID_GUEST_NR_FEAT       (2u + 1)
 #define CPUID_GUEST_NR_TOPO       (1u + 1)
 #define CPUID_GUEST_NR_XSTATE     (62u + 1)
 #define CPUID_GUEST_NR_EXTD_INTEL (0x8u + 1)
@@ -193,6 +194,14 @@ struct cpuid_policy
                 uint32_t _7b1;
                 struct { DECL_BITFIELD(7b1); };
             };
+            uint32_t /* c */:32, /* d */:32;
+
+            /* Subleaf 2. */
+            uint32_t /* a */:32, /* b */:32, /* c */:32;
+            union {
+                uint32_t _7d2;
+                struct { DECL_BITFIELD(7d2); };
+            };
         };
     } feat;
 
@@ -333,6 +342,7 @@ static inline void cpuid_policy_to_featureset(
     fs[FEATURESET_7a1] = p->feat._7a1;
     fs[FEATURESET_e21a] = p->extd.e21a;
     fs[FEATURESET_7b1] = p->feat._7b1;
+    fs[FEATURESET_7d2] = p->feat._7d2;
 }
 
 /* Fill in a CPUID policy from a featureset bitmap. */
@@ -352,6 +362,7 @@ static inline void cpuid_featureset_to_policy(
     p->feat._7a1  = fs[FEATURESET_7a1];
     p->extd.e21a  = fs[FEATURESET_e21a];
     p->feat._7b1  = fs[FEATURESET_7b1];
+    p->feat._7d2  = fs[FEATURESET_7d2];
 }
 
 static inline uint64_t cpuid_policy_xcr0_max(const struct cpuid_policy *p)
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Tue Feb 08 18:10:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 18:10:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268585.462461 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHUwG-0004IY-E7; Tue, 08 Feb 2022 18:10:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268585.462461; Tue, 08 Feb 2022 18:10:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHUwG-0004H0-9L; Tue, 08 Feb 2022 18:10:04 +0000
Received: by outflank-mailman (input) for mailman id 268585;
 Tue, 08 Feb 2022 18:10:02 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1rHF=SX=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nHUwE-0003Sy-8I
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 18:10:02 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 536fc97b-890a-11ec-8eb8-a37418f5ba1a;
 Tue, 08 Feb 2022 19:10:00 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 536fc97b-890a-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644343800;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=DN+j1b19UntwqTcT4SnsDIhwfs0fbGijJq0oTfhrAtY=;
  b=bqITvqfJtZPORMHkKN4c7jTZEJ4olXNAtMZR1SguSfiTSx4vIH7rJWhL
   6UdVY+e/5au+Nod4P17HxE17bqfYeGDGYytTif50aXIJmhRFAge7FfEox
   DX304aQxRQhs6icnknSoCb704CYl6V+pYVbGM/LjlZkRumBVEaYtcSMJV
   A=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: xPKKKpj7P7kS3oyR+8rIrgQ1Sc20KcOIGGUP5uirGnRu78F1sR2pzl+MjFtrgil/R+dECnK4rW
 G5kCu4BuCIrPTfCAesYGMEB+nFc/8ZDyrZWROPHHf+aygX5e374xqpc0GqhNyyuctlJoqI8mKY
 O9lkQsEDihH+78M7CNrfm3mgkHgBgQkYOkU0c+/X+cQZr50zmJZz71nYEIp91K9WQA/6ZPkqw8
 Tn1M72/D5iKpOkHeFKqYAKBsiEnhDrD+4/XZXpMMZ7svobc1lhEy5F2n3bitKSas29RIu37Bbq
 cjqr7inWzzDqRphcFpa2GFb6
X-SBRS: 5.1
X-MesageID: 63762631
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:pxkam6CRNaqJCRVW/wPkw5YqxClBgxIJ4kV8jS/XYbTApDon1jwAy
 mEdUWqHPqqDNDCgfox1a4Tno01SvJLUz98wQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMo/u1Si6FatANl1ElvU2zbue6WL6s1hxZH1c+En970UI7wYbVv6Yz6TSHK1LV0
 T/Ni5W31G+Ng1aY5UpNtspvADs21BjDkGtwUm4WPJinj3eH/5UhN7oNJLnZEpfNatI88thW5
 Qr05OrREmvxp3/BAz4++1rxWhVirrX6ZWBihpfKMkQLb9crSiEai84G2PQghUh/oSSEu81D6
 u93r5G1ezgDAqrFt/o5XEwNe81+FfUuFL7vJHG+tYqYzlHccmuqyPJrZK00FdRGoKAtWzgIr
 KFGbmBWBvyAr7veLLaTY+9gnMk8auLsO5sSoCpIxjDFF/c2B5vERs0m4PcGh2hu3J4VRJ4yY
 eIkNQQsTQ2RQCRFBXcyA6ADnbqVtHPWJmgwRFW9+vNsvjm7IBZK+KjgNp/Zd8KHQe1Rn12Ev
 STW8mLhGBYYOdeDjz2f/RqRavTnxH2hHthITfvhq6As0Ab7KnEv5AM+f0q2heSLqHSEQd9aG
 XM+xi0ngrYW+xn+JjXiZCGQrHmBtx8aftNfFewm9Q2AopbpDxal6nssFWAYNoF/3CMibXlzj
 wLSwYu1bdB6mODNERqgGqGoQSRe0MT/BUsLfmc6QAQM+LEPS6lj30uUHr6P/ENY5+AZ+A0cI
 RjX9kDSZJ1J1KbnMplXGnid0lqRSmDhFFJd2+ktYkqr7xlieKmubJGy5F7Q4J5oddjFEgDQ5
 SFaypLHt4ji6K1hcwTXEY0w8EyBva7ZYFUwf3Yzd3Xey9hd0yH6Jt0BiN2PDExoLtwFaVfUj
 Lz74mtsCGtoFCLyN8dfOtvpY+xzlPSIPYm1B5j8M4sVCrAsJVDv1H81Pya4gTuy+HXAZIliY
 P+za9i3N38GBMxPlXzuLwvr+eRwnX5WKKK6bc2T8ilLJpLEPCHMEupeYALVBg37hYvdyDjoH
 x9kH5Pi431ivCfWP0E7KKYfcgIHK2YVH5fzp5AFf+KPOFM+SmogF+XQ0fUqfIk8x/ZZkeLB/
 3ecXE5EyQWg2S2beFvSMn0zOqnyWZtfrG4gOXB+N1ifxHV+M52k670SdsVrcOB/pvBj1/N9U
 9IMZ96EXqZUUj3C9jlENcv9oYVueQ6FnwWLOyb5MjEzc4Q5H17C+8P+fxup/y4LV3Llucw7q
 rym9wXaXZtcGFgyUJeIMKqilgrjs2IcleR+W1rzDuNSIEi8opJ3LyHRj+MsJ51eIxv02TbHh
 R2dBg0VpLeRrtZtosXJn62Ns6ygD/B6QhhBB2De4Lu7aXva826kzdMSWeqEZ2mABmb9+aHkb
 uRJ1fDsdvYAmQ8S4YZ7Fr9qy4M45sfu+OAGnlg1Qi2TYgT5EK5kL1mHwdJL5/9EybJusAerX
 l6Cp4tBMrKTNcK5SFMcKWLJtAhYOS34TtUK0ckIHQ==
IronPort-HdrOrdr: A9a23:Cta2y6/Nu9P6t7CZKUpuk+DaI+orL9Y04lQ7vn2YSXRuHPBw9v
 re5cjzuiWVtN98Yh0dcJW7Scy9qBDnhPhICOsqTNSftWDd0QPCRuxfBMnZslnd8kXFh4lgPM
 xbEpSWZueeMbEDt7eZ3DWF
X-IronPort-AV: E=Sophos;i="5.88,353,1635220800"; 
   d="scan'208";a="63762631"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH 2/6] x86/tsx: Move has_rtm_always_abort to an outer scope
Date: Tue, 8 Feb 2022 18:09:38 +0000
Message-ID: <20220208180942.14871-3-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220208180942.14871-1-andrew.cooper3@citrix.com>
References: <20220208180942.14871-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

We are about to introduce a second path which needs to conditionally force the
presence of RTM_ALWAYS_ABORT.

No functional change.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
---
 xen/arch/x86/tsx.c | 26 ++++++++++++--------------
 1 file changed, 12 insertions(+), 14 deletions(-)

diff --git a/xen/arch/x86/tsx.c b/xen/arch/x86/tsx.c
index 88adf08c4973..c3b8a7ec0076 100644
--- a/xen/arch/x86/tsx.c
+++ b/xen/arch/x86/tsx.c
@@ -42,6 +42,7 @@ void tsx_init(void)
     if ( unlikely(cpu_has_tsx_ctrl < 0) )
     {
         uint64_t caps = 0;
+        bool has_rtm_always_abort;
 
         if ( boot_cpu_data.cpuid_level >= 7 )
             boot_cpu_data.x86_capability[cpufeat_word(X86_FEATURE_ARCH_CAPS)]
@@ -51,6 +52,7 @@ void tsx_init(void)
             rdmsrl(MSR_ARCH_CAPABILITIES, caps);
 
         cpu_has_tsx_ctrl = !!(caps & ARCH_CAPS_TSX_CTRL);
+        has_rtm_always_abort = cpu_has_rtm_always_abort;
 
         if ( cpu_has_tsx_force_abort )
         {
@@ -67,11 +69,7 @@ void tsx_init(void)
              * RTM_ALWAYS_ABORT enumerates the new functionality, but is also
              * read as zero if TSX_FORCE_ABORT.ENABLE_RTM has been set before
              * we run.
-             *
-             * Undo this behaviour in Xen's view of the world.
              */
-            bool has_rtm_always_abort = cpu_has_rtm_always_abort;
-
             if ( !has_rtm_always_abort )
             {
                 uint64_t val;
@@ -83,15 +81,6 @@ void tsx_init(void)
             }
 
             /*
-             * Always force RTM_ALWAYS_ABORT, even if it currently visible.
-             * If the user explicitly opts to enable TSX, we'll set
-             * TSX_FORCE_ABORT.ENABLE_RTM and cause RTM_ALWAYS_ABORT to be
-             * hidden from the general CPUID scan later.
-             */
-            if ( has_rtm_always_abort )
-                setup_force_cpu_cap(X86_FEATURE_RTM_ALWAYS_ABORT);
-
-            /*
              * If no explicit tsx= option is provided, pick a default.
              *
              * This deliberately overrides the implicit opt_tsx=-3 from
@@ -108,10 +97,19 @@ void tsx_init(void)
              * With RTM_ALWAYS_ABORT, disable TSX.
              */
             if ( opt_tsx < 0 )
-                opt_tsx = !cpu_has_rtm_always_abort;
+                opt_tsx = !has_rtm_always_abort;
         }
 
         /*
+         * Always force RTM_ALWAYS_ABORT, even if it currently visible.  If
+         * the user explicitly opts to enable TSX, we'll set the appropriate
+         * RTM_ENABLE bit and cause RTM_ALWAYS_ABORT to be hidden from the
+         * general CPUID scan later.
+         */
+        if ( has_rtm_always_abort )
+            setup_force_cpu_cap(X86_FEATURE_RTM_ALWAYS_ABORT);
+
+        /*
          * The TSX features (HLE/RTM) are handled specially.  They both
          * enumerate features but, on certain parts, have mechanisms to be
          * hidden without disrupting running software.
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Tue Feb 08 18:10:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 18:10:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268582.462430 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHUwE-0003Va-9M; Tue, 08 Feb 2022 18:10:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268582.462430; Tue, 08 Feb 2022 18:10:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHUwE-0003VA-5S; Tue, 08 Feb 2022 18:10:02 +0000
Received: by outflank-mailman (input) for mailman id 268582;
 Tue, 08 Feb 2022 18:10:00 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1rHF=SX=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nHUwC-0003Sy-Kk
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 18:10:00 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5231fbd7-890a-11ec-8eb8-a37418f5ba1a;
 Tue, 08 Feb 2022 19:09:57 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5231fbd7-890a-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644343798;
  h=from:to:cc:subject:date:message-id:mime-version;
  bh=pViVV2hWeibhQaOV7IR6ioT+MotoxNWQ6k6CH/wQXjM=;
  b=RRI8/GZBrwavs3yKjbJ+G0FugcDWpaV3NAL5Uu8s0/e9H4UEV/1Vdhbd
   S5b3Huc5EPUEdduPbGq0icqScuHMks+8GvxNAumhx/7GUiKVMYoChZMi6
   /mwcucRChY+cfW99vXUL3kKvzhJiSSzpfZHOukErQ7t6BA+Q3T9PObg5B
   Q=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: IRLRDnSqC0pCtb6uu4IVpteITDI4nwXYX5AkdbXNQ/wuz82hdM8xq3oUVsAD9BVgslIO8LGutt
 0cClFkIFjNjenMB/YBlKqQeHU1HptXXjj6KlWeBTa1uq5srMh4wAMnv43JSuqTZ6qSjjE9zXNh
 ONdhvTrO/06qLraeHMpZzftQHXXQ6RWm28lCroRqHNBluGlc/LyjxDIZ33jbEP86QDpxeYoaNW
 RFSkYxUHqL09TjyZWucC+rLAYZ/0DthbqV7bsqxNZWBeEnaPJn4HWFfO989qiCoMFmaRjqLbpO
 gGen/8GkEUucBFznZ3O+NORD
X-SBRS: 5.1
X-MesageID: 63762669
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:iy86/K8Epf0eTHqGQ3bUDrUDo3mTJUtcMsCJ2f8bNWPcYEJGY0x3y
 2EfWjrSPa2OMDCkf4p1YNu+9xwEusCHzd4wGgJr+3s8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhFWeIdA970Ug5w7Rh0tYy6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhQk
 tt1kK6+Zjw2L7Xps/UgWBJcQ2JhaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguwKKsXxMZxZkXZn1TzDVt4tQIzZQrWM7thdtNs1rp4VQqiEO
 ZRIAdZpRD7bR0F/Nlk3NJUjuLeXu2TtSzxUkV3A8MLb5ECMlVcsgdABKuH9atGMAMlYgEucj
 mbH5HjiRAEXMsSFzjiI+W7qgfXA9R4XQ6pLSuf+rKQzxgTOmCpDU3X6SGdXv9GY0ECGfuBRB
 HcL6zILhrkP/0evHpriCkjQTGG/gjYQXN9ZEusf4Q6Ly7bJ7wvxOlXoXgKte/R96pZoGGVCO
 kuh2oqwWGcx6OH9pWe1q+/MxQ5eLxT5OoPricUsaQIeq+fur4go5v4kZoYySfXl5jEZ9NyZ/
 txrkMTcr+hJ5SLo///ilbwiv95LjsKYJjPZHi2NAgqYAvpRPeZJnbCA51nB9upnJ42EVFSHt
 3Vss5HAsLxXXMjUyn3XGb5l8FSVCxGtamy0vLKSN8N5q2TFF4CLIei8Hw2S1G82a51ZKFcFk
 WfYuB9L5Y87AZdZRfQfXm5FMOxzlfKIPY28Dpj8N4MSCrAsJF7v1Hw/Pia4gjGy+GByyvtXE
 cnALq6R4YMyVP0PIMyeHLxGj9fGB0kWmAvueHwM507/juPFOSXFEOxt3ZnnRrlR0Z5oaT79q
 753X/ZmAT0GOAEnSiWIo4MVM34QKn03WcL/p8BNL7bRKQt6AmAxTfTWxOp5KYBimq1UkMbO/
 228BRAEmAau2yWfJFXYcG1nZZPuQY178SAxMxszMAv6wHMke4uusvsSLsNlYbk9+eV/5vdoV
 P1ZKd6YC/FCR22fqTQQZJXwtqJ4cxGviV7cNiapemFnLZVhWxbI6pnveQ62rHsCCS++tM0fp
 by811yEHcpfFlo6VMuPMaCh1VK8u3QZidleZUqQL4kBYljo/ahrNzf10q09LfYTJEiR3TCdz
 QuXX0sV/LGfv48v/dDVrqmYtIP1QfBmF09XEmSHv7a7MS7WojiqzYNaCbvaeDncUCX/+bm4Z
 PUTxPb5aaVVkFFPuot6MrBq0aNhuIe/++4EllxpTCfRclCmKrJ8OX3Xj8BAu5pEyqJdpQbrC
 FmE/cNXOOnRNc7oeLLLyNHJsghXOSkopwTv
IronPort-HdrOrdr: A9a23:8s2yjqDe3thWNRDlHem655DYdb4zR+YMi2TC1yhKJyC9E/bo8P
 xG88566faZslossRIb6LS90cu7MBDhHPdOiOF7V9qftWHdyQ6VxepZjLcKrQeOJ8SHzJ8+6Z
 td
X-IronPort-AV: E=Sophos;i="5.88,353,1635220800"; 
   d="scan'208";a="63762669"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH 0/6] x86: Changes for Intel Feb 2022 microcode
Date: Tue, 8 Feb 2022 18:09:36 +0000
Message-ID: <20220208180942.14871-1-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
MIME-Version: 1.0
Content-Type: text/plain

Changes for two software visible changes in the Intel Feb 2022 microcode drop.
1) Deprecation of TSX on more client parts
2) Retrofitting of AMD's MSR_SPEC_CTRL.PSFD to various CPUs

These patches have been committed and backported to 4.14 and later.

Andrew Cooper (6):
  x86/spec-ctrl: Clean up MSR_MCU_OPT_CTRL handling
  x86/tsx: Move has_rtm_always_abort to an outer scope
  x86/tsx: Cope with TSX deprecation on WHL-R/CFL-R
  tests/tsx: Extend test-tsx to check MSR_MCU_OPT_CTRL
  x86/cpuid: Infrastructure for cpuid word 7:2.edx
  x86/spec-ctrl: Support Intel PSFD for guests

 docs/misc/xen-command-line.pandoc           |  25 +++++--
 tools/libs/light/libxl_cpuid.c              |   2 +
 tools/misc/xen-cpuid.c                      |   6 ++
 tools/tests/tsx/test-tsx.c                  |   9 ++-
 xen/arch/x86/acpi/power.c                   |   3 +-
 xen/arch/x86/cpu/common.c                   |   4 ++
 xen/arch/x86/cpu/intel.c                    |  32 +++++++++
 xen/arch/x86/include/asm/cpufeature.h       |   1 +
 xen/arch/x86/include/asm/msr-index.h        |   2 +
 xen/arch/x86/include/asm/processor.h        |   3 +
 xen/arch/x86/include/asm/spec_ctrl.h        |   2 -
 xen/arch/x86/msr.c                          |   2 +-
 xen/arch/x86/platform_hypercall.c           |   3 +
 xen/arch/x86/smpboot.c                      |   3 +-
 xen/arch/x86/spec_ctrl.c                    |  52 +++++++-------
 xen/arch/x86/tsx.c                          | 102 ++++++++++++++++++++++++----
 xen/include/public/arch-x86/cpufeatureset.h |   3 +
 xen/include/xen/lib/x86/cpuid.h             |  13 +++-
 xen/tools/gen-cpuid.py                      |   2 +-
 19 files changed, 211 insertions(+), 58 deletions(-)

-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Tue Feb 08 18:10:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 18:10:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268583.462435 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHUwE-0003YB-Hs; Tue, 08 Feb 2022 18:10:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268583.462435; Tue, 08 Feb 2022 18:10:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHUwE-0003Xf-Dz; Tue, 08 Feb 2022 18:10:02 +0000
Received: by outflank-mailman (input) for mailman id 268583;
 Tue, 08 Feb 2022 18:10:01 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1rHF=SX=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nHUwD-0003Sy-6C
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 18:10:01 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 52deec30-890a-11ec-8eb8-a37418f5ba1a;
 Tue, 08 Feb 2022 19:09:59 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 52deec30-890a-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644343799;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=0oObUQpZAUPYFZpIBW0xewUnMdr0+AaT7RXg0NpNwug=;
  b=BnWdPMNtyl3c4JcNm/zrgdDwQ+CtQmSylqEassSeZeHDeVoNsLM/Cln5
   k2I0HX320JKLM6Y1JwQZie129ruMjwEucZlx9ZTc4n3yv+ilPNjIRytyM
   rQUf1JCQCD4fDmqwfd3f/tjGHUpF+czosKgFWyw6QUWdXhOEoB3qL6vco
   Q=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: vykE8PlYTPcHxHdlWU41j30bG1djZdD9FKl08Kygc/jOWjGP5y4OSQ63ydDpAiOGuDHflUFPQ6
 o3CuappdhSkLGUSNmTnGz4KgrYBQJfTdGA9Lvp/FXgSIxzQkCwLRrwNTSX9Ke6XbwzUJjuO1JT
 p4XBpWFGF6eLm2zct6DNHhEEzD6jDsGsX4PEVZfm0ycePsU0ntbCyw1giNrSbaNWLR4Z3ubmTo
 7syMOeCw0R9Qn6VbYQv1eC8LmXr3dCcswNWq1Ja0qo556ioJxLfgdR1Nq1ZYDI4SGbG6Bcqy+E
 nEWdXbLHWpw+CFaj22nGBD6r
X-SBRS: 5.1
X-MesageID: 64166858
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:rM9HU6NtXoVGVBnvrR2GkMFynXyQoLVcMsEvi/4bfWQNrUp21zcOy
 TBJWjvQbvuPNjTwed10Poy+8xgG7JGGnYA3Hgto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6UUsxNbVU8En1500ozw7RRbrNA2rBVPSvc4
 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq
 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYoxSqgtNYk
 8UQjLGhEgcwFKHFscowAjANRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs
 6VFdnZdNXhvhMrvqF6/YsBqit4uM4/AO4QHt2s75TrYEewnUdbIRKCiCdpwgmtp2J4eQKa2i
 8wxSjNpaS3bPzZ1BQk8Lqozkc2F2HP9SmgNwL6SjfVuuDWCpOBr65D9PdyQdtGUSMF9mkeDu
 nmA72n/GgsdNtGU1XyC6H3EuwPUtXqlAsRITuT+r6M0xg3IroAONPEIfXqYvPqQ0V7jYv9Oc
 EwN0CYnhIYfpWX+G7ERQCaEiHKDuxcdXf9ZHOs79ByBx8Lo3uqJOoQXZmUfMYJ77afaURRvj
 wbUxI2xWVSDpZXIESr1y1uCkd+l1cH5x0cmbDRMcwYK6sKLTGob3kOWFYYL/EJYY7TI9dDML
 9Ki8XJWa1Y715djO0CHEbfv2WPEm3QxZlRpjjg7p0r8hu+DWKarZpaz9X/Q5utaIYCSQzGp5
 SZYx5HPtblQXMvUz0Rhpdnh+5nztp643MD02wYzT/HNCRzxk5JcQWygyG4nfxo4Wir1UTTof
 FXSqWtsCGx7ZxOXgVtMS9vpUawClPG4ffy8D6y8RoceM/BZKV7clAkzNBH49z62yiAEz/pgU
 ap3hO7xVB72/4w8l2HoLwrcuJd2rh0DKZT7H8iklk/6iurHPxZ4i94taTOzUwzw14vcyC29z
 jqVH5LiJ8x3XLKsby/J35QUKFxWf3E3CYqv855cd/KZIxogE2YkUqeDzbQkco1jvqJUiuaXo
 S3tBh4GkALy1S/dNAGHSnF/c7ezD5xxmm02YH43NlGy1nl9PYv2tPUDd4E6dKUM/fB4yaImV
 OEMfsiNW6wdSjnO9zkHQ4P6qYhuKEaiiQ6UZnL3azkjZZ9wAQfO/4a8LAfo8SAPCAuxtNc//
 OL8hl+KH8JbSl07XsjMaf+pw1eghlQnmbp/DxnSP91eWETw64w2eSb/ueA6fpMXIhLZyzrEi
 wvPWUUEpfPAqpMe+cXSgfzWtJ+gFuZzExYIH2Tf6rrqZyDW8nD6nN1FWeeMOzvcSHn16OOpY
 uAMl6PwN/gOnVBrtYtgEuk0kfJitoW3/7IKnB55GHjrbkiwDuIyK3aL6sBDq6lRy+ILogCxQ
 E+OpoFXNLjh1BkJy7LNyN7Jtti+6Mw=
IronPort-HdrOrdr: A9a23:aABuLK9REeYKrKiB8QJuk+DaI+orL9Y04lQ7vn2YSXRuHPBw9v
 re5cjzuiWVtN98Yh0dcJW7Scy9qBDnhPhICOsqTNSftWDd0QPCRuxfBMnZslnd8kXFh4lgPM
 xbEpSWZueeMbEDt7eZ3DWF
X-IronPort-AV: E=Sophos;i="5.88,353,1635220800"; 
   d="scan'208";a="64166858"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH 1/6] x86/spec-ctrl: Clean up MSR_MCU_OPT_CTRL handling
Date: Tue, 8 Feb 2022 18:09:37 +0000
Message-ID: <20220208180942.14871-2-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220208180942.14871-1-andrew.cooper3@citrix.com>
References: <20220208180942.14871-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

Introduce cpu_has_srbds_ctrl as more users are going to appear shortly.

MSR_MCU_OPT_CTRL is gaining extra functionality, meaning that the current
default_xen_mcu_opt_ctrl is no longer a good fit.

Introduce two new helpers, update_mcu_opt_ctrl() which does a full RMW cycle
on the MSR, and set_in_mcu_opt_ctrl() which lets callers configure specific
bits at a time without clobbering each others settings.

No functional change.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
---
 xen/arch/x86/acpi/power.c             |  3 +--
 xen/arch/x86/cpu/intel.c              | 32 +++++++++++++++++++++++++++++
 xen/arch/x86/include/asm/cpufeature.h |  1 +
 xen/arch/x86/include/asm/processor.h  |  3 +++
 xen/arch/x86/include/asm/spec_ctrl.h  |  2 --
 xen/arch/x86/smpboot.c                |  3 +--
 xen/arch/x86/spec_ctrl.c              | 38 ++++++++++++-----------------------
 7 files changed, 51 insertions(+), 31 deletions(-)

diff --git a/xen/arch/x86/acpi/power.c b/xen/arch/x86/acpi/power.c
index d4bdc3e7df42..5eaa77f66a28 100644
--- a/xen/arch/x86/acpi/power.c
+++ b/xen/arch/x86/acpi/power.c
@@ -301,8 +301,7 @@ static int enter_state(u32 state)
         ci->last_spec_ctrl = default_xen_spec_ctrl;
     }
 
-    if ( boot_cpu_has(X86_FEATURE_SRBDS_CTRL) )
-        wrmsrl(MSR_MCU_OPT_CTRL, default_xen_mcu_opt_ctrl);
+    update_mcu_opt_ctrl();
 
     /* (re)initialise SYSCALL/SYSENTER state, amongst other things. */
     percpu_traps_init();
diff --git a/xen/arch/x86/cpu/intel.c b/xen/arch/x86/cpu/intel.c
index 9b011c344636..e7d4dd652f9f 100644
--- a/xen/arch/x86/cpu/intel.c
+++ b/xen/arch/x86/cpu/intel.c
@@ -15,6 +15,38 @@
 #include "cpu.h"
 
 /*
+ * MSR_MCU_OPT_CTRL is a collection of unrelated functionality, with separate
+ * enablement requirements, but which want to be consistent across the system.
+ */
+static uint32_t __read_mostly mcu_opt_ctrl_mask;
+static uint32_t __read_mostly mcu_opt_ctrl_val;
+
+void update_mcu_opt_ctrl(void)
+{
+    uint32_t mask = mcu_opt_ctrl_mask, lo, hi;
+
+    if ( !mask )
+        return;
+
+    rdmsr(MSR_MCU_OPT_CTRL, lo, hi);
+
+    lo &= ~mask;
+    lo |= mcu_opt_ctrl_val;
+
+    wrmsr(MSR_MCU_OPT_CTRL, lo, hi);
+}
+
+void __init set_in_mcu_opt_ctrl(uint32_t mask, uint32_t val)
+{
+    mcu_opt_ctrl_mask |= mask;
+
+    mcu_opt_ctrl_val &= ~mask;
+    mcu_opt_ctrl_val |= (val & mask);
+
+    update_mcu_opt_ctrl();
+}
+
+/*
  * Processors which have self-snooping capability can handle conflicting
  * memory type across CPUs by snooping its own cache. However, there exists
  * CPU models in which having conflicting memory types still leads to
diff --git a/xen/arch/x86/include/asm/cpufeature.h b/xen/arch/x86/include/asm/cpufeature.h
index 4754940e23f3..a0ab6d7d78ea 100644
--- a/xen/arch/x86/include/asm/cpufeature.h
+++ b/xen/arch/x86/include/asm/cpufeature.h
@@ -134,6 +134,7 @@
 #define cpu_has_avx512_4vnniw   boot_cpu_has(X86_FEATURE_AVX512_4VNNIW)
 #define cpu_has_avx512_4fmaps   boot_cpu_has(X86_FEATURE_AVX512_4FMAPS)
 #define cpu_has_avx512_vp2intersect boot_cpu_has(X86_FEATURE_AVX512_VP2INTERSECT)
+#define cpu_has_srbds_ctrl      boot_cpu_has(X86_FEATURE_SRBDS_CTRL)
 #define cpu_has_rtm_always_abort boot_cpu_has(X86_FEATURE_RTM_ALWAYS_ABORT)
 #define cpu_has_tsx_force_abort boot_cpu_has(X86_FEATURE_TSX_FORCE_ABORT)
 #define cpu_has_serialize       boot_cpu_has(X86_FEATURE_SERIALIZE)
diff --git a/xen/arch/x86/include/asm/processor.h b/xen/arch/x86/include/asm/processor.h
index e2e1eaf5bd0d..23639d5479a3 100644
--- a/xen/arch/x86/include/asm/processor.h
+++ b/xen/arch/x86/include/asm/processor.h
@@ -626,6 +626,9 @@ extern int8_t opt_tsx, cpu_has_tsx_ctrl;
 extern bool rtm_disabled;
 void tsx_init(void);
 
+void update_mcu_opt_ctrl(void);
+void set_in_mcu_opt_ctrl(uint32_t mask, uint32_t val);
+
 enum ap_boot_method {
     AP_BOOT_NORMAL,
     AP_BOOT_SKINIT,
diff --git a/xen/arch/x86/include/asm/spec_ctrl.h b/xen/arch/x86/include/asm/spec_ctrl.h
index a803d16f9065..f76029523610 100644
--- a/xen/arch/x86/include/asm/spec_ctrl.h
+++ b/xen/arch/x86/include/asm/spec_ctrl.h
@@ -54,8 +54,6 @@ extern int8_t opt_pv_l1tf_hwdom, opt_pv_l1tf_domu;
  */
 extern paddr_t l1tf_addr_mask, l1tf_safe_maddr;
 
-extern uint64_t default_xen_mcu_opt_ctrl;
-
 static inline void init_shadow_spec_ctrl_state(void)
 {
     struct cpu_info *info = get_cpu_info();
diff --git a/xen/arch/x86/smpboot.c b/xen/arch/x86/smpboot.c
index 22ae4c1b2de9..335129a0104d 100644
--- a/xen/arch/x86/smpboot.c
+++ b/xen/arch/x86/smpboot.c
@@ -385,8 +385,7 @@ void start_secondary(void *unused)
         wrmsrl(MSR_SPEC_CTRL, default_xen_spec_ctrl);
         info->last_spec_ctrl = default_xen_spec_ctrl;
     }
-    if ( boot_cpu_has(X86_FEATURE_SRBDS_CTRL) )
-        wrmsrl(MSR_MCU_OPT_CTRL, default_xen_mcu_opt_ctrl);
+    update_mcu_opt_ctrl();
 
     tsx_init(); /* Needs microcode.  May change HLE/RTM feature bits. */
 
diff --git a/xen/arch/x86/spec_ctrl.c b/xen/arch/x86/spec_ctrl.c
index ee862089b7f6..3628b4b4154f 100644
--- a/xen/arch/x86/spec_ctrl.c
+++ b/xen/arch/x86/spec_ctrl.c
@@ -67,7 +67,6 @@ static bool __initdata cpu_has_bug_msbds_only; /* => minimal HT impact. */
 static bool __initdata cpu_has_bug_mds; /* Any other M{LP,SB,FB}DS combination. */
 
 static int8_t __initdata opt_srb_lock = -1;
-uint64_t __read_mostly default_xen_mcu_opt_ctrl;
 
 static int __init parse_spec_ctrl(const char *s)
 {
@@ -376,7 +375,7 @@ static void __init print_details(enum ind_thunk thunk, uint64_t caps)
            (default_xen_spec_ctrl & SPEC_CTRL_SSBD)  ? " SSBD+" : " SSBD-",
            !(caps & ARCH_CAPS_TSX_CTRL)              ? "" :
            (opt_tsx & 1)                             ? " TSX+" : " TSX-",
-           !boot_cpu_has(X86_FEATURE_SRBDS_CTRL)     ? "" :
+           !cpu_has_srbds_ctrl                       ? "" :
            opt_srb_lock                              ? " SRB_LOCK+" : " SRB_LOCK-",
            opt_ibpb                                  ? " IBPB"  : "",
            opt_l1d_flush                             ? " L1D_FLUSH" : "",
@@ -1251,32 +1250,24 @@ void __init init_speculation_mitigations(void)
         tsx_init();
     }
 
-    /* Calculate suitable defaults for MSR_MCU_OPT_CTRL */
-    if ( boot_cpu_has(X86_FEATURE_SRBDS_CTRL) )
+    /*
+     * On some SRBDS-affected hardware, it may be safe to relax srb-lock by
+     * default.
+     *
+     * On parts which enumerate MDS_NO and not TAA_NO, TSX is the only known
+     * way to access the Fill Buffer.  If TSX isn't available (inc. SKU
+     * reasons on some models), or TSX is explicitly disabled, then there is
+     * no need for the extra overhead to protect RDRAND/RDSEED.
+     */
+    if ( cpu_has_srbds_ctrl )
     {
-        uint64_t val;
-
-        rdmsrl(MSR_MCU_OPT_CTRL, val);
-
-        /*
-         * On some SRBDS-affected hardware, it may be safe to relax srb-lock
-         * by default.
-         *
-         * On parts which enumerate MDS_NO and not TAA_NO, TSX is the only way
-         * to access the Fill Buffer.  If TSX isn't available (inc. SKU
-         * reasons on some models), or TSX is explicitly disabled, then there
-         * is no need for the extra overhead to protect RDRAND/RDSEED.
-         */
         if ( opt_srb_lock == -1 &&
              (caps & (ARCH_CAPS_MDS_NO|ARCH_CAPS_TAA_NO)) == ARCH_CAPS_MDS_NO &&
              (!cpu_has_hle || ((caps & ARCH_CAPS_TSX_CTRL) && rtm_disabled)) )
             opt_srb_lock = 0;
 
-        val &= ~MCU_OPT_CTRL_RNGDS_MITG_DIS;
-        if ( !opt_srb_lock )
-            val |= MCU_OPT_CTRL_RNGDS_MITG_DIS;
-
-        default_xen_mcu_opt_ctrl = val;
+        set_in_mcu_opt_ctrl(MCU_OPT_CTRL_RNGDS_MITG_DIS,
+                            opt_srb_lock ? 0 : MCU_OPT_CTRL_RNGDS_MITG_DIS);
     }
 
     print_details(thunk, caps);
@@ -1314,9 +1305,6 @@ void __init init_speculation_mitigations(void)
         wrmsrl(MSR_SPEC_CTRL, val);
         info->last_spec_ctrl = val;
     }
-
-    if ( boot_cpu_has(X86_FEATURE_SRBDS_CTRL) )
-        wrmsrl(MSR_MCU_OPT_CTRL, default_xen_mcu_opt_ctrl);
 }
 
 static void __init __maybe_unused build_assertions(void)
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Tue Feb 08 18:10:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 18:10:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268587.462483 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHUwI-0004xB-OJ; Tue, 08 Feb 2022 18:10:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268587.462483; Tue, 08 Feb 2022 18:10:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHUwI-0004vQ-IE; Tue, 08 Feb 2022 18:10:06 +0000
Received: by outflank-mailman (input) for mailman id 268587;
 Tue, 08 Feb 2022 18:10:04 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1rHF=SX=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nHUwG-0003Sy-94
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 18:10:04 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5558c99a-890a-11ec-8eb8-a37418f5ba1a;
 Tue, 08 Feb 2022 19:10:03 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5558c99a-890a-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644343802;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=2Tu+0ZH5IK1WnPkeaZM/73l9bKZI3OnKw4WhQyYT/iw=;
  b=edVmEVSq38VzxZihXdBhC4u4BW2aNtdmsnfMMxLxnP0vrfzREo2EX/Qe
   o1Kd3I49lyQ1+pfRb+DtBDOjXWZYI5/f3xLn3xtJsRxI6ljeGzzx3oOWr
   KM0zfwm9lBdiDbLlQQ4qnVW9/JJ6KnFRtD6bTYbq2NvYo6qX14mt//u6R
   4=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: f2B6KjaCFSB7Z04T9jYgUSa845KXeJRfQlW5XJ+OGlfBSnpBcniU+oSFTQt4RAL7WomC+ZvBOG
 bzFZARTO8hGTAf7+9CqtungXvLkbObngdLDWBOiH0RwdEb+WONWKo3R4nsfOuC/GYElp0aqSD5
 pjigXSnHAOxq46GhCRNHw1JOEVOidoAcKyoZeItmxEce/bCrbxPBZmxDlHysVm3eo8JrPC4/tm
 MS3LtNNNEI6B0uMDwn1R3izm6KH3Gy+1frFe56hFCxY3KC2QQRP02XDDbf6LTd9OvybCIUjucK
 PWh3C3jBVeKC00f8CsbXDPCx
X-SBRS: 5.1
X-MesageID: 63217625
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:2t5viKw+GI5e9/tR3Lx6t+cUwSrEfRIJ4+MujC+fZmUNrF6WrkUOz
 DZKUG+CM/6LNjT2c41/b47loB8H75fTn4RgGgVkpCAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAhLeNYYH1500g7wbZp2tQAbeWRWGthh
 /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL
 wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt9826
 NQW6K2tcgd3P6+WpfgxWiRITT4raMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr
 6ZBbmlQMFbT3Ipaw5riIgVoru0lINPmI8U0vXZ4wCuCJf0nXYrCU+PB4towMDIY2JsURKmAP
 ZdxhTxHbk6QbUFUPG4uA7EOwvyTjWGnTX5zkQfAzUYwyzeKl1EguFT3C/LFd9rPSchLk0Kwo
 mPd43+/EhwcLMaYyzeO7jSrnOCnoM/gcNtMTvvirKcs2QDNgDxIYPELabelifb+qk/lBuNCE
 ExK+yh0kLQe/XG7EMaoCnVUv0W4lhIbXtNRFcgz5weM1rfY7m6lO4QUctJSQId47ZFrHFTGw
 nfMxoq0XmI37NV5XFrAru/8kN+kBcQCwYbujwcgRBBN3dTsqZpbYvnnHoc6S/7dYjEY9FjNL
 9G2QMoW2u97YS0jjfzTEbX7b9WE/Mmhc+LNzl+LNl9JFysgDGJfW6Sm6ELA8dFLJ5uDQ1+Ks
 RAswpbCsLlfVMjTxXbUG43h+Y1FAN7fYVXhbaNHRcF9p1xBBVb/FWyv3N2ODBgwaZtVEdMYS
 ETSpRlQ9Pdu0IiCNsdKj3aKI51yl8DITI29PtiNN4YmSsUhJWevoXA1DWbNjj+FuBZ3y8kXZ
 8zEGftA+F5HUMyLOhLtHLxDuVLqrwhjrV7uqWfTlUz4iOHDPy7MEt/o8jKmN4gE0U9Nmy2Nm
 /43CidA40k3vDTWbnaF/IgNA0oNKHRnV5n6p9YOLryIIxZ8GXFnAPjUmOtzd4tglqVTt+HJ4
 nDiBRMIlAuh3SXKeVeQd3RuSLLzRpIj/3g1CjMhYASz0H85bIfxsKpGL8krfaMq/fBIxOJvS
 6VXYN2JB/lCE2yV+zkUYZTngpZlcRCn2VCHMya/OWBtdJ98XQ3ZvNTje1K3piUJCyO2s+o4o
 qGhiVyHEcZSGVw6AZ+POvy1zl63sXwMo85IXhPFcotJZUHh0Il2MCit3PU5FN4BdEfYzTyA2
 gfIXRpB/bvRo5U4+cXijLyfq9v7CPN3G0dXEjWJ7buyMiWGrGOvzZUZDbSNdDHZEmj15L+jd
 aNeyPSlaK8Lm1NDsoxdFbd3zP1hu4uz9uEClgk0Tm/Wa1mLC697JijU1MZCgaRB27tFtFbkQ
 UmI4NRbZe2ENc6N/IT9/+b5gjBvDc0ppwQ=
IronPort-HdrOrdr: A9a23:rtFV0KHYTyU1by84pLqE7MeALOsnbusQ8zAXP0AYc31om62j5r
 iTdZsgpHzJYVoqN03I3OrwXJVoIkmsjKKdg7NhX4tKNTOO0ADDQe1fBMnZslrd8kXFh4hgPM
 xbE5SWZuefMbEDt7ee3DWF
X-IronPort-AV: E=Sophos;i="5.88,353,1635220800"; 
   d="scan'208";a="63217625"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH 6/6] x86/spec-ctrl: Support Intel PSFD for guests
Date: Tue, 8 Feb 2022 18:09:42 +0000
Message-ID: <20220208180942.14871-7-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220208180942.14871-1-andrew.cooper3@citrix.com>
References: <20220208180942.14871-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

The Feb 2022 microcode from Intel retrofits AMD's MSR_SPEC_CTRL.PSFD interface
to Sunny Cove (IceLake) and later cores.

Update the MSR_SPEC_CTRL emulation, and expose it to guests.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
---
 tools/libs/light/libxl_cpuid.c              | 2 ++
 tools/misc/xen-cpuid.c                      | 1 +
 xen/arch/x86/msr.c                          | 2 +-
 xen/arch/x86/spec_ctrl.c                    | 7 +++++--
 xen/include/public/arch-x86/cpufeatureset.h | 1 +
 xen/tools/gen-cpuid.py                      | 2 +-
 6 files changed, 11 insertions(+), 4 deletions(-)

diff --git a/tools/libs/light/libxl_cpuid.c b/tools/libs/light/libxl_cpuid.c
index e1acf6648db4..d462f9e421ed 100644
--- a/tools/libs/light/libxl_cpuid.c
+++ b/tools/libs/light/libxl_cpuid.c
@@ -234,6 +234,8 @@ int libxl_cpuid_parse_config(libxl_cpuid_policy_list *cpuid, const char* str)
         {"fsrs",         0x00000007,  1, CPUID_REG_EAX, 11,  1},
         {"fsrcs",        0x00000007,  1, CPUID_REG_EAX, 12,  1},
 
+        {"intel-psfd",   0x00000007,  2, CPUID_REG_EDX,  0,  1},
+
         {"lahfsahf",     0x80000001, NA, CPUID_REG_ECX,  0,  1},
         {"cmplegacy",    0x80000001, NA, CPUID_REG_ECX,  1,  1},
         {"svm",          0x80000001, NA, CPUID_REG_ECX,  2,  1},
diff --git a/tools/misc/xen-cpuid.c b/tools/misc/xen-cpuid.c
index 40626296984b..0b1b3333fe71 100644
--- a/tools/misc/xen-cpuid.c
+++ b/tools/misc/xen-cpuid.c
@@ -202,6 +202,7 @@ static const char *const str_7b1[32] =
 
 static const char *const str_7d2[32] =
 {
+    [ 0] = "intel-psfd",
 };
 
 static const struct {
diff --git a/xen/arch/x86/msr.c b/xen/arch/x86/msr.c
index 4ac5b5a048eb..01a15857b740 100644
--- a/xen/arch/x86/msr.c
+++ b/xen/arch/x86/msr.c
@@ -443,7 +443,7 @@ int guest_rdmsr(struct vcpu *v, uint32_t msr, uint64_t *val)
 uint64_t msr_spec_ctrl_valid_bits(const struct cpuid_policy *cp)
 {
     bool ssbd = cp->feat.ssbd || cp->extd.amd_ssbd;
-    bool psfd = cp->extd.psfd;
+    bool psfd = cp->feat.intel_psfd || cp->extd.psfd;
 
     /*
      * Note: SPEC_CTRL_STIBP is specified as safe to use (i.e. ignored)
diff --git a/xen/arch/x86/spec_ctrl.c b/xen/arch/x86/spec_ctrl.c
index 2b93468d396e..cbeeb199037e 100644
--- a/xen/arch/x86/spec_ctrl.c
+++ b/xen/arch/x86/spec_ctrl.c
@@ -307,11 +307,13 @@ custom_param("pv-l1tf", parse_pv_l1tf);
 
 static void __init print_details(enum ind_thunk thunk, uint64_t caps)
 {
-    unsigned int _7d0 = 0, e8b = 0, tmp;
+    unsigned int _7d0 = 0, _7d2 = 0, e8b = 0, max = 0, tmp;
 
     /* Collect diagnostics about available mitigations. */
     if ( boot_cpu_data.cpuid_level >= 7 )
-        cpuid_count(7, 0, &tmp, &tmp, &tmp, &_7d0);
+        cpuid_count(7, 0, &max, &tmp, &tmp, &_7d0);
+    if ( max >= 2 )
+        cpuid_count(7, 2, &tmp, &tmp, &tmp, &_7d2);
     if ( boot_cpu_data.extended_cpuid_level >= 0x80000008 )
         cpuid(0x80000008, &tmp, &e8b, &tmp, &tmp);
 
@@ -345,6 +347,7 @@ static void __init print_details(enum ind_thunk thunk, uint64_t caps)
            (_7d0 & cpufeat_mask(X86_FEATURE_STIBP))          ? " STIBP"          : "",
            (e8b  & cpufeat_mask(X86_FEATURE_AMD_SSBD)) ||
            (_7d0 & cpufeat_mask(X86_FEATURE_SSBD))           ? " SSBD"           : "",
+           (_7d2 & cpufeat_mask(X86_FEATURE_INTEL_PSFD)) ||
            (e8b  & cpufeat_mask(X86_FEATURE_PSFD))           ? " PSFD"           : "",
            (_7d0 & cpufeat_mask(X86_FEATURE_L1D_FLUSH))      ? " L1D_FLUSH"      : "",
            (_7d0 & cpufeat_mask(X86_FEATURE_MD_CLEAR))       ? " MD_CLEAR"       : "",
diff --git a/xen/include/public/arch-x86/cpufeatureset.h b/xen/include/public/arch-x86/cpufeatureset.h
index 81b0f5e0aad3..9cee4b439e9f 100644
--- a/xen/include/public/arch-x86/cpufeatureset.h
+++ b/xen/include/public/arch-x86/cpufeatureset.h
@@ -303,6 +303,7 @@ XEN_CPUFEATURE(NSCB,               11*32+ 6) /*A  Null Selector Clears Base (and
 XEN_CPUFEATURE(INTEL_PPIN,         12*32+ 0) /*   Protected Processor Inventory Number */
 
 /* Intel-defined CPU features, CPUID level 0x00000007:2.edx, word 13 */
+XEN_CPUFEATURE(INTEL_PSFD,         13*32+ 0) /*A  MSR_SPEC_CTRL.PSFD */
 
 #endif /* XEN_CPUFEATURE */
 
diff --git a/xen/tools/gen-cpuid.py b/xen/tools/gen-cpuid.py
index 39c8b0c77465..e0e3f2f46386 100755
--- a/xen/tools/gen-cpuid.py
+++ b/xen/tools/gen-cpuid.py
@@ -287,7 +287,7 @@ def crunch_numbers(state):
         # IBRSB/IBRS, and we pass this MSR directly to guests.  Treating them
         # as dependent features simplifies Xen's logic, and prevents the guest
         # from seeing implausible configurations.
-        IBRSB: [STIBP, SSBD],
+        IBRSB: [STIBP, SSBD, INTEL_PSFD],
         IBRS: [AMD_STIBP, AMD_SSBD, PSFD,
                IBRS_ALWAYS, IBRS_FAST, IBRS_SAME_MODE],
         AMD_STIBP: [STIBP_ALWAYS],
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Tue Feb 08 18:10:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 18:10:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268588.462491 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHUwJ-00054U-EH; Tue, 08 Feb 2022 18:10:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268588.462491; Tue, 08 Feb 2022 18:10:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHUwJ-00052h-1z; Tue, 08 Feb 2022 18:10:07 +0000
Received: by outflank-mailman (input) for mailman id 268588;
 Tue, 08 Feb 2022 18:10:05 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1rHF=SX=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nHUwG-0004K6-S5
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 18:10:04 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5517281e-890a-11ec-8f75-fffcc8bd4f1a;
 Tue, 08 Feb 2022 19:10:03 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5517281e-890a-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644343802;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=r07JJ+ieARO/h3VHmKJxMVxJpW20MqnhjuvAZQdZY/U=;
  b=B7gEWGsSsNMDvWw8VTKL0bonmAQpLR/Ec0GRTC7AX6775JrcuM7Iyou1
   I81yf6HWrZdGN+H3V/ksi6tP9MX44ufCcO/UZRn8IdBqJ8ETUM+3mzvq0
   9QiK6TvQAMs9LEPoJD1okAVNLP0S+u0TvupCffPZzRduCLnwblXQy91AP
   U=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: e98P7T2EfM9xyRizm7aIx+aYydt5/N/+qk/Kcxe45UvTVtMEneIMHkXf94hK82WlTXtqq3DObr
 jICYC3tZAViHzEjjUCqCJj46VMtoz55SrKGvRfpIggD2WvF5qeukmpx4lSzDvr+ya8P0hCpBAf
 87gfsQFvWeM64LboY7rZ4D3wSWcEIDoR2AihW30UGRB9Dvokm0n1vj5a9wvKTk8ExOLX8tRmFt
 L/++81aHT950omrtEQKUipCmYiZ49nTlrHobD5EEHISObEwlz3i5rHIkwx8rXJSkgVnbkU0gfk
 E+X1lsz+gpJMRofX+9Z/lblb
X-SBRS: 5.1
X-MesageID: 65977667
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:zdfhNKBDFULg6hVW/wvkw5YqxClBgxIJ4kV8jS/XYbTApGlwgjQCn
 GJJXG3UOqvcZWbwfotxaYi18h8EvpGEmN5jQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMo/u1Si6FatANl1ElvU2zbue6WL6s1hxZH1c+En970UI7wYbVv6Yz6TSHK1LV0
 T/Ni5W31G+Ng1aY5UpNtspvADs21BjDkGtwUm4WPJinj3eH/5UhN7oNJLnZEpfNatI88thW5
 Qr05OrREmvxp3/BAz4++1rxWhVirrX6ZWBihpfKMkQLb9crSiEai84G2PQghUh/iAXUsu8o6
 eV27bOrTCsSIL+Rx+RFekwNe81+FfUuFL7vJHG+tYqYzlHccmuqyPJrZK00FdRGoKAtWzgIr
 KFGbmBWBvyAr7veLLaTY+9gnMk8auLsO5sSoCpIxjDFF/c2B5vERs0m4PcGgWZv2Z4QQp4yY
 eIjchNPRUjiMyFxM08rK6IFseWEimDwJmgwRFW9+vNsvjm7IBZK+KjgNp/Zd8KHQe1Rn12Ev
 STW8mLhGBYYOdeDjz2f/RqRavTnxH2hHthITfvhq6As0Ab7KnEv5AM+VmvmjMbgq36FA/1EL
 mAv5Dhz8qhq3Rn+JjXiZCGQrHmBtx8aftNfFewm9Q2AopbpDxal6nssFWAYNoF/3CMibXlzj
 wLSwYu1bdB6mODNERqgGqGoQSRe0MT/BUsLfmc6QAQM+LEPS6lj30uUHr6P/ENY5+AZ+A0cI
 RjX9kDSZJ1J1KbnMplXGnid0lqRSmDhFFJd2+kudjvNAvlFTICkfZe0zlPQ8OxNKo2UJnHY4
 iRYwpnHtb5fV8jW/MBofAnqNOv4j8tpzRWG2QI/d3Xf32jFF4GfkXB4v2gleRYB3jcscj71e
 k7D0T69F7cIVEZGmZRfOtrrY+xzlPCIPY28Cpj8M4ofCrAsJVTv1Hw/Oia4gTu3+GByyv5XB
 HtuWZv1ZZrsIf88l2TeqiZ0+eJD+x3SMkuJHc+ilEn8gePFDJNXIJ9cWGazgikCxPvsiG3oH
 xx3bpbiJ8x3XLKsby/J35QUKFxWf3E3CYqv855cd/KZIxogE2YkUqeDzbQkco1jvqJUiuaXo
 S3tBh4GkALy1S/dNAGHSnF/c7ezD5xxmm02YH43NlGy1nl9PYv2tPUDd4E6dKUM/fB4yaImV
 OEMfsiNW6wdSjnO9zkHQ4P6qYhuKEaiiQ6UZnL3azkjZZ9wAQfO/4a8LAfo8SAPCAuxtNc//
 OL8hl+KH8JbSl07XsjMaf+pw1eghlQnmbp/DxnSP91eWETw64w2eSb/ueA6fpMXIhLZyzrEi
 wvPWUUEpfPAqpMe+cXSgfzWtJ+gFuZzExYIH2Tf6rrqZyDW8nD6nN1FWeeMOzvcSHn16OOpY
 uAMl6PwN/gOnVBrtYtgEuk0kfJitoW3/7IKnB55GHjrbkiwDuIyK3aL6sBDq6lRy+ILogCxQ
 E+OpoFXNLjh1BkJy7LNyN7Jtti+6Mw=
IronPort-HdrOrdr: A9a23:Hqhdeq26/AmlVD1o0YPFTQqjBLYkLtp133Aq2lEZdPRUGvb4qy
 nOpoVi6faaskdzZJhNo7+90ey7MBfhHP1OkPAs1NWZLWvbUQKTRekIh+aP/9SjIVyYygc079
 YHT0EUMr3N5DZB4/oSmDPIduod/A==
X-IronPort-AV: E=Sophos;i="5.88,353,1635220800"; 
   d="scan'208";a="65977667"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH 4/6] tests/tsx: Extend test-tsx to check MSR_MCU_OPT_CTRL
Date: Tue, 8 Feb 2022 18:09:40 +0000
Message-ID: <20220208180942.14871-5-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220208180942.14871-1-andrew.cooper3@citrix.com>
References: <20220208180942.14871-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

This MSR needs to be identical across the system for TSX to have identical
behaviour everywhere.  Furthermore, its CPUID bit (SRBDS_CTRL) shouldn't be
visible to guests.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
 tools/tests/tsx/test-tsx.c        | 9 ++++++++-
 xen/arch/x86/platform_hypercall.c | 3 +++
 2 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/tools/tests/tsx/test-tsx.c b/tools/tests/tsx/test-tsx.c
index a3d987b6d2ce..f11e8c54e0de 100644
--- a/tools/tests/tsx/test-tsx.c
+++ b/tools/tests/tsx/test-tsx.c
@@ -42,6 +42,7 @@ enum {
 #define  ARCH_CAPS_TSX_CTRL                 (1 <<  7)
 #define MSR_TSX_FORCE_ABORT                 0x0000010f
 #define MSR_TSX_CTRL                        0x00000122
+#define MSR_MCU_OPT_CTRL                    0x00000123
 
 static unsigned int nr_failures;
 #define fail(fmt, ...)                          \
@@ -155,6 +156,10 @@ static void test_tsx_msrs(void)
     printf("Testing MSR_TSX_CTRL consistency\n");
     test_tsx_msr_consistency(
         MSR_TSX_CTRL, host.msr.arch_caps.tsx_ctrl);
+
+    printf("Testing MSR_MCU_OPT_CTRL consistency\n");
+    test_tsx_msr_consistency(
+        MSR_MCU_OPT_CTRL, host.cpuid.feat.srbds_ctrl);
 }
 
 /*
@@ -313,7 +318,8 @@ static void test_guest_policies(const struct xc_cpu_policy *max,
 
     if ( ((cm->feat.raw[0].d | cd->feat.raw[0].d) &
           (bitmaskof(X86_FEATURE_TSX_FORCE_ABORT) |
-           bitmaskof(X86_FEATURE_RTM_ALWAYS_ABORT))) ||
+           bitmaskof(X86_FEATURE_RTM_ALWAYS_ABORT) |
+           bitmaskof(X86_FEATURE_SRBDS_CTRL))) ||
          ((mm->arch_caps.raw | md->arch_caps.raw) & ARCH_CAPS_TSX_CTRL) )
         fail("  Xen-only TSX controls offered to guest\n");
 
@@ -388,6 +394,7 @@ static void test_guest(struct xen_domctl_createdomain *c)
     if ( guest_policy.cpuid.feat.hle ||
          guest_policy.cpuid.feat.tsx_force_abort ||
          guest_policy.cpuid.feat.rtm_always_abort ||
+         guest_policy.cpuid.feat.srbds_ctrl ||
          guest_policy.msr.arch_caps.tsx_ctrl )
         fail("  Unexpected features advertised\n");
 
diff --git a/xen/arch/x86/platform_hypercall.c b/xen/arch/x86/platform_hypercall.c
index 284c2dfb9efe..bf4090c94201 100644
--- a/xen/arch/x86/platform_hypercall.c
+++ b/xen/arch/x86/platform_hypercall.c
@@ -80,6 +80,9 @@ static bool msr_read_allowed(unsigned int msr)
 
     case MSR_TSX_CTRL:
         return cpu_has_tsx_ctrl;
+
+    case MSR_MCU_OPT_CTRL:
+        return cpu_has_srbds_ctrl;
     }
 
     if ( ppin_msr && msr == ppin_msr )
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Tue Feb 08 18:11:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 18:11:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268633.462524 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHUxr-00005W-Tb; Tue, 08 Feb 2022 18:11:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268633.462524; Tue, 08 Feb 2022 18:11:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHUxr-00005P-Q9; Tue, 08 Feb 2022 18:11:43 +0000
Received: by outflank-mailman (input) for mailman id 268633;
 Tue, 08 Feb 2022 18:11:41 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nHUxp-0008WO-NW; Tue, 08 Feb 2022 18:11:41 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nHUxp-0005xa-Mj; Tue, 08 Feb 2022 18:11:41 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nHUxp-0003rg-AX; Tue, 08 Feb 2022 18:11:41 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nHUxp-0006EU-A7; Tue, 08 Feb 2022 18:11:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=N1v68VeyP2hdiIi/J964syPXNrVI0wNxbfuAR4p3uCs=; b=4rmZ+sF99zVzcxur7y/+hUjIBf
	OsW6DnpQtz5rb5B+/DoogL7FmmJDOix84BA2SdbXl69yV/ayZPQ9/e3YHOGXANE13GNc2raExw/Gc
	ZRwvOySsHwfMDg60RK0oawTxkS6paBkuxVhyM3W17C4B4gKZrvndyPKTkLikqBdyotkQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168058-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 168058: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=345746045b49258547d67f456c368f23353575d4
X-Osstest-Versions-That:
    xen=10d33220f2363a21a52a394159118ab4ddaed50e
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 08 Feb 2022 18:11:41 +0000

flight 168058 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168058/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  345746045b49258547d67f456c368f23353575d4
baseline version:
 xen                  10d33220f2363a21a52a394159118ab4ddaed50e

Last test of basis   168049  2022-02-07 18:01:43 Z    1 days
Testing same since   168058  2022-02-08 14:02:51 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Anthony PERARD <anthony.perard@citrix.com>
  Juergen Gross <jgross@suse.com>
  Michal Orzel <michal.orzel@arm.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   10d33220f2..345746045b  345746045b49258547d67f456c368f23353575d4 -> smoke


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 18:27:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 18:27:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268689.462630 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHVCc-0002vp-Fd; Tue, 08 Feb 2022 18:26:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268689.462630; Tue, 08 Feb 2022 18:26:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHVCc-0002vi-CX; Tue, 08 Feb 2022 18:26:58 +0000
Received: by outflank-mailman (input) for mailman id 268689;
 Tue, 08 Feb 2022 18:26:57 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nHVCb-0002vY-NZ
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 18:26:57 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nHVCb-0006Kq-8y; Tue, 08 Feb 2022 18:26:57 +0000
Received: from 54-240-197-236.amazon.com ([54.240.197.236]
 helo=[192.168.10.176]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nHVCb-0005jr-2e; Tue, 08 Feb 2022 18:26:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=C6XQZSSOMsjdvNQ5KEU18a01jSzfi4Uy2XgjLUtW+t8=; b=uQEo+gTU9bTK7am94EDuF+HnKv
	WOAj3tR9BWev+04k9zULhkwX/sEB2deWqXU1PVGLFo1D1BhBqDMPV6cLRpx0odhMh2s6zYr/mku+g
	E+1sByovPbfYmDPHIsDoZ73v0xrfih7vnFlMzitqy5b3cchA5d6swK0Kynhx4PlksxgI=;
Message-ID: <b88f6a50-6e9e-5679-8d25-89e26031e88e@xen.org>
Date: Tue, 8 Feb 2022 18:26:54 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.1
Subject: Re: [RFC v2 3/8] xen/arm: Export host device-tree to hypfs
To: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>, Juergen Gross <jgross@suse.com>
References: <cover.1644341635.git.oleksii_moisieiev@epam.com>
 <e440e4f16a506ecc87078635dbb3fda2ebd45346.1644341635.git.oleksii_moisieiev@epam.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <e440e4f16a506ecc87078635dbb3fda2ebd45346.1644341635.git.oleksii_moisieiev@epam.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Oleksii,

On 08/02/2022 18:00, Oleksii Moisieiev wrote:
> If enabled, host device-tree will be exported to hypfs and can be
> accessed through /devicetree path.
> Exported device-tree has the same format, as the device-tree
> exported to the sysfs by the Linux kernel.
> This is useful when XEN toolstack needs an access to the host device-tree.
> 
> Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@epam.com>
> ---
>   xen/arch/arm/Kconfig           |   8 +
>   xen/arch/arm/Makefile          |   1 +
>   xen/arch/arm/host_dtb_export.c | 307 +++++++++++++++++++++++++++++++++

There is nothing specific in this file. So can this be moved in common/?

>   3 files changed, 316 insertions(+)
>   create mode 100644 xen/arch/arm/host_dtb_export.c
> 
> diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
> index ecfa6822e4..895016b21e 100644
> --- a/xen/arch/arm/Kconfig
> +++ b/xen/arch/arm/Kconfig
> @@ -33,6 +33,14 @@ config ACPI
>   	  Advanced Configuration and Power Interface (ACPI) support for Xen is
>   	  an alternative to device tree on ARM64.
>   
> +config HOST_DTB_EXPORT
> +	bool "Export host device tree to hypfs if enabled"
> +	depends on ARM && HYPFS && !ACPI

A Xen built with ACPI enabled will still be able to boot on a host using 
Device-Tree. So I don't think should depend on ACPI.

Also, I think this should depend on HAS_DEVICE_TREE rather than ARM.

> +	---help---
> +
> +	  Export host device-tree to hypfs so toolstack can have an access for the
> +	  host device tree from Dom0. If you unsure say N.
> +
>   config GICV3
>   	bool "GICv3 driver"
>   	depends on ARM_64 && !NEW_VGIC
> diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile
> index 07f634508e..0a41f68f8c 100644
> --- a/xen/arch/arm/Makefile
> +++ b/xen/arch/arm/Makefile
> @@ -8,6 +8,7 @@ obj-y += platforms/
>   endif
>   obj-$(CONFIG_TEE) += tee/
>   obj-$(CONFIG_HAS_VPCI) += vpci.o
> +obj-$(CONFIG_HOST_DTB_EXPORT) += host_dtb_export.o
>   
>   obj-$(CONFIG_HAS_ALTERNATIVE) += alternative.o
>   obj-y += bootfdt.init.o
> diff --git a/xen/arch/arm/host_dtb_export.c b/xen/arch/arm/host_dtb_export.c
> new file mode 100644
> index 0000000000..794395683c
> --- /dev/null
> +++ b/xen/arch/arm/host_dtb_export.c

This is mostly hypfs related. So CCing Juergen for his input on the code.

> @@ -0,0 +1,307 @@
> +/*
> + * xen/arch/arm/host_dtb_export.c
> + *
> + * Export host device-tree to the hypfs so toolstack can access
> + * host device-tree from Dom0
> + *
> + * Oleksii Moisieiev <oleksii_moisieiev@epam.com>
> + * Copyright (C) 2021, EPAM Systems.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */
> +
> +#include <xen/device_tree.h>
> +#include <xen/err.h>
> +#include <xen/guest_access.h>
> +#include <xen/hypfs.h>
> +#include <xen/init.h>
> +
> +#define HOST_DT_DIR "devicetree"
> +
> +static int host_dt_dir_read(const struct hypfs_entry *entry,
> +                            XEN_GUEST_HANDLE_PARAM(void) uaddr);
> +static unsigned int host_dt_dir_getsize(const struct hypfs_entry *entry);
> +
> +static const struct hypfs_entry *host_dt_dir_enter(
> +    const struct hypfs_entry *entry);
> +static void host_dt_dir_exit(const struct hypfs_entry *entry);
> +
> +static struct hypfs_entry *host_dt_dir_findentry(
> +    const struct hypfs_entry_dir *dir, const char *name, unsigned int name_len);

This is new code. So can you please make sure to avoid forward 
declaration by re-ordering the code.


[...]

> +static char *get_root_from_path(const char *path, char *name)
> +{
> +    const char *nm = strchr(path, '/');
> +    if ( !nm )
> +        nm = path + strlen(path);
> +    else
> +    {
> +        if ( !*nm )
> +            nm--;
> +    }
> +
> +    return memcpy(name, path, nm - path);

What does guaranteee that name will be big enough for the new value?

> +}
> +
> +static int host_dt_dir_read(const struct hypfs_entry *entry,
> +                            XEN_GUEST_HANDLE_PARAM(void) uaddr)
> +{
> +    int ret = 0;
> +    struct dt_device_node *node;
> +    struct dt_device_node *child;

The hypfs should not modify the device-tree. So can this be const?

> +    const struct dt_property *prop;
> +    struct hypfs_dyndir_id *data;
> +
> +    data = hypfs_get_dyndata();
> +    if ( !data )
> +        return -EINVAL;

[...]

> +static struct hypfs_entry *host_dt_dir_findentry(
> +    const struct hypfs_entry_dir *dir, const char *name, unsigned int name_len)
> +{
> +    struct dt_device_node *node;
> +    char root_name[HYPFS_DYNDIR_ID_NAMELEN];
> +    struct dt_device_node *child;
> +    struct hypfs_dyndir_id *data;
> +    struct dt_property *prop;
> +
> +    data = hypfs_get_dyndata();
> +    if ( !data )
> +        return ERR_PTR(-EINVAL);
> +
> +    node = data->data;
> +    if ( !node )
> +        return ERR_PTR(-EINVAL);
> +
> +    memset(root_name, 0, sizeof(root_name));
> +    get_root_from_path(name, root_name);
> +
> +    for ( child = node->child; child != NULL; child = child->sibling )
> +    {
> +        if ( strcmp(get_name_from_path(child->full_name), root_name) == 0 )
> +            return hypfs_gen_dyndir_entry(&dt_dir.e,
> +                                  get_name_from_path(child->full_name), child);
> +    }
> +
> +    dt_for_each_property_node( node, prop )
> +    {
> +
> +        if ( dt_property_name_is_equal(prop, root_name) )
> +            return hypfs_gen_dyndir_entry(&dt_prop.e, prop->name, prop);
> +    }
> +
> +    return ERR_PTR(-ENOENT);

[...]

> +static HYPFS_DIR_INIT_FUNC(host_dt_dir, HOST_DT_DIR, &host_dt_dir_funcs);
> +
> +static int __init host_dtb_export_init(void)
> +{
> +    ASSERT(dt_host && (dt_host->sibling == NULL));

dt_host can be NULL when booting on ACPI platform. So I think this wants 
to be turned to a normal check and return directly.

Also could you explain why you need to check dt_host->sibling?

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 19:50:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 19:50:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268699.462642 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHWVS-00031j-Do; Tue, 08 Feb 2022 19:50:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268699.462642; Tue, 08 Feb 2022 19:50:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHWVS-00031c-A9; Tue, 08 Feb 2022 19:50:30 +0000
Received: by outflank-mailman (input) for mailman id 268699;
 Tue, 08 Feb 2022 19:50:28 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=8slD=SX=epam.com=prvs=4038ec5daa=oleksandr_tyshchenko@srs-se1.protection.inumbo.net>)
 id 1nHWVQ-00031W-Ck
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 19:50:28 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5b492746-8918-11ec-8eb8-a37418f5ba1a;
 Tue, 08 Feb 2022 20:50:25 +0100 (CET)
Received: from pps.filterd (m0174682.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 218EgqdB006896;
 Tue, 8 Feb 2022 19:50:20 GMT
Received: from eur04-db3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2052.outbound.protection.outlook.com [104.47.12.52])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3e3rb5j1hn-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Tue, 08 Feb 2022 19:50:19 +0000
Received: from DB8PR03MB6108.eurprd03.prod.outlook.com (2603:10a6:10:ed::15)
 by AM4PR0302MB2721.eurprd03.prod.outlook.com (2603:10a6:200:91::22) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Tue, 8 Feb
 2022 19:50:15 +0000
Received: from DB8PR03MB6108.eurprd03.prod.outlook.com
 ([fe80::e975:b192:b8cd:4f73]) by DB8PR03MB6108.eurprd03.prod.outlook.com
 ([fe80::e975:b192:b8cd:4f73%5]) with mapi id 15.20.4951.019; Tue, 8 Feb 2022
 19:50:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5b492746-8918-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=iYbe8WxMJPyzPEYc/f5sOkBBhXGUjFXl9A4V267GEn7eecybfngvBxEdPQmv/k6zhkk5Rh9X4v6B0uyMc3+slexZXP8+ywP3EGMvcUAXva6qDp4/KgmxJqCi6V36FlwzTi4+qT1efpsi9x924HkKIs4bubbv9YBPSfIU0WlubQtsy8KYyZr6rnTiMKHqT/AtT4y39cFqOU/78ZB+WsFvz2FPtLMHFmn8ZRcivrtNRsdiKruVeFzTwQmSH/UQgTnrfIGCVMfe3i7dFnCHHORi43DBgauhAikLG31woXvwhkas5AXJaf/hOxEhDjl9fg1w5yEXrshdSYn4ffz6iUx5yA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=zhYginN6pEMc0TMEDgmsA15E9yJUUP6fw06VZIxyqfE=;
 b=UB1TGyV3ytC/ze1ZwlKaDCPGpeFhDTaRO4MuFmytO1Gs5wqZEREwT7970qGay89JFLNBDQqu3JyR8RvyhhDa5q8rw9kal5miqTyqVFHcEAjLZuBd4g4JaIehG9bqBVl1PvtEq4DCf6BGGfgXrsMlV0vkXTlK3wAEJRHjVL/0vGQZoIyqyMzd8JKinC1+l039crBWuqxUyGqdWT4WVb1CLI5/AoU497ybudvHEgUJOziD69Ta76TL6PCeHDZBYxCyKBDlr/dXLoU4dvnTLo3RLWOdAa0PKn7X9rIg9hColMQZL2J3pqCFhXVZUyULbGNdLl0u/bC6zWG5r93lVHXTyw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=zhYginN6pEMc0TMEDgmsA15E9yJUUP6fw06VZIxyqfE=;
 b=IAZEKIaKdBGXEHvrScsnOarqFaTJody9NPIE6flgmY1yx6OHvDeKlR23/FaDKsOJ2B9vh4qXGBR2i3i+YZV7Wp7sJDHx/q8XDtpE89iXAHd9DPRPfBy1XBLS6l/ol702NkFtrp1jfOtcrlumTRtnikBjlpEVyIt3OsJOGffEXCibuDwo8eor7xVKyyOqjTH13OUB6hY+ygOUHRFHfzSH4lsHU24GT3O9wEPChyYxY579qyx6uv6JAhXuwIvTBUaZAl+RrRD5Ivi+zVovp8T1+0YsmuHSd+HYpRWwmLs4purE0in+uBSiqabvPY17WupjitXwYlpOJlrqQxWxWLOgTg==
From: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>
To: Julien Grall <julien@xen.org>
CC: Jan Beulich <jbeulich@suse.com>,
        Oleksandr Tyshchenko
	<olekstysh@gmail.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        Stefano Stabellini
	<sstabellini@kernel.org>,
        Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Andrew Cooper
	<andrew.cooper3@citrix.com>,
        George Dunlap <george.dunlap@citrix.com>, Wei
 Liu <wl@xen.org>,
        =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?=
	<roger.pau@citrix.com>,
        Bob Eshleman <bobbyeshleman@gmail.com>,
        Alistair
 Francis <alistair.francis@wdc.com>,
        Connor Davis <connojdavis@gmail.com>
Subject: Re: [PATCH V5] xen/gnttab: Store frame GFN in struct page_info on Arm
Thread-Topic: [PATCH V5] xen/gnttab: Store frame GFN in struct page_info on
 Arm
Thread-Index: AQHYAomKM/4d8JNsdEqc8nNA4dib2KyIh6IAgAAs1wCAAQzHgIAAg9oA
Date: Tue, 8 Feb 2022 19:50:14 +0000
Message-ID: <79fbf83e-d25e-2634-9769-8e07634bfd63@epam.com>
References: <1641424268-12968-1-git-send-email-olekstysh@gmail.com>
 <a54213c4-1c68-694e-c130-d95faeef3953@xen.org>
 <78d94e1e-6db4-25c1-adb8-e4bdbfe42774@epam.com>
 <82d8bfe0-cb46-d303-6a60-2324dd76a1f7@xen.org>
In-Reply-To: <82d8bfe0-cb46-d303-6a60-2324dd76a1f7@xen.org>
Accept-Language: en-US, ru-RU
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 52590a1e-3d95-41a5-7829-08d9eb3c39d0
x-ms-traffictypediagnostic: AM4PR0302MB2721:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM4PR0302MB2721C104AAE05484DC100F8D862D9@AM4PR0302MB2721.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:7691;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 YpMYTJaOxtq2EPGw3/x9z6Za14uepP19azWFFjf6HyGokhvk3eUONBG0FyAkZJUumSZhwuTyeKdbj44kWwBXl4NIaLlDZeDqtulfhfKicwNB0APHvq+laitorsDZuIULOMedSiisP8MGf6Dc2yhn3zVLcDyhRIZZh1+U/sWhCeHfdyuz/9HeHGWulGJeI7zF9nO06xMW7yAYJid9r5a2p0nlDzSYtx72kDRpD6TsowqafaScdX7tOPRcoDfQYSvc2hYBkXiBYPTZs19oKWe1zBTyanpmqghw03v4gp2gMhI1a99vXVG9qeGARtPgLK17l9wlBlPJyZZ8neo4A6JYTMAzLSySUw9i++WmETqZfBLUsnVWbXko1m9v5CVkhUr2X68cahRbXOSSEhM1MT5AxmgExi5bf5SASMpJTtuwZDzEqnOqvwYeaP0woN+6pPwgT6JdQu2Itg+aQ1LMo5UFH51B7AKGFdkNfs1437Z9oEGmmGoTC8ReHec9+KWrK9h1bEVLoh20RZW1XwAjwu3pTKMV51eWCXrBKtLSGvbIF1QLBxI8QizA0r1+4KVq9ifynN+8/tmypFLFubRD8c+Ht3ww2oCRznum2MUP3V/hBzFtHoNMUhNUSckGroPstZFLxZ2mSoOKpxN3P+8k1eF7k8kSVP8jfEMHla/njaHyqgCiaN/QRlimaq1Ewn9cVXws47SparMW5+b9QITogTZIFeVVDYivloPAy8OGmuELu4w3GMG06TdwiDZcebjt6EYG
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB8PR03MB6108.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(36756003)(71200400001)(2616005)(6506007)(6512007)(5660300002)(6916009)(316002)(54906003)(7416002)(38100700002)(122000001)(31686004)(83380400001)(53546011)(186003)(26005)(55236004)(8676002)(64756008)(2906002)(66946007)(4326008)(31696002)(8936002)(86362001)(508600001)(76116006)(38070700005)(66476007)(6486002)(66556008)(66446008)(91956017)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?ZXdQMkJ6TW1ObURveDRVSHdzT1pjMVhsenYxNnY0cUhmZFhBVjdxRzZBNTN1?=
 =?utf-8?B?aElFcGk0R0JPOEVTYnBmZHdSS3dqTXFkZXgwcExCb2ZPOHJRUU1yQVFDcUhF?=
 =?utf-8?B?WWxkdGJhcEpBR3FsLzZOZmxCUy81Q0YxOFF1MkJFeHFhdzA2azNsck54QUYr?=
 =?utf-8?B?ZnZTRzZEZlA3aGI4dnNKWGVITmRDZVVCMW5zVmlmeUdCYTY4NEJ3ZE1XbUVk?=
 =?utf-8?B?cHl0OTFCam4zc09EQTJFZS92OVliMnJhWHhHNzhXZXM1SXl2YWhBWjdBQ1c3?=
 =?utf-8?B?eHdVWXp6US9WYlRIZ1hIa3BUYnZEbERKZXNobUNWTGM2QVlYM0JkRTV2Rm8v?=
 =?utf-8?B?YW4rUzU5aHVEK2ZOQWNBTEtkY1J2TVBoMTFJSkxPZWNCK09Sc3c2WDJHSFFu?=
 =?utf-8?B?N2lBN0FRMk9SaHBQR3VYZzZKWXR1ZmVGUHpHZ1A3VytwbllJRlBUTGFJbnVI?=
 =?utf-8?B?LytLbFFjNDU4SHVhYkZtVXFPNk03ODEvbG10eFRnT2VuQ3A4T0F4cHhNSEpX?=
 =?utf-8?B?b1RTcGVUREYrQncwREhWMHViNUhjWmNsQmR0OXE3a0NCMWt6SnlObjk3SUM2?=
 =?utf-8?B?bEgwbkxEQTZXTUtrQmJ1QjZUK3A3RHlIcUQ0VUJwS25OTkV6c2pYRkxpUmpr?=
 =?utf-8?B?VGNHSkM4WjFhdEdoNzJpb2ZPMS8zN05xSGdnWmlpbE1ZODhBSTFmSFRYazB0?=
 =?utf-8?B?eExuSnJUM3I0VkVjYnlkck5QV2I5S0gwR3JYS3FXZU9iM3l3aDdmOEx4WGdr?=
 =?utf-8?B?S0h6Mis4c2V3dDdhcTQ4VTJyUldMajNudktKeFdVdXZVTVo1QWR0bUFsZHg5?=
 =?utf-8?B?YkEyb0tiS01FRUErek9NNGN3RGg5eUd1RUNNbXcwRW9Zd2dCNG5GRmdMOFlz?=
 =?utf-8?B?UEViK0hmdGtVdnAzQ1poZkVyWU5PTjJVTzhBU2p3bC9tdzZ0TFZVaVdRYnF3?=
 =?utf-8?B?dGZhbHBQcUVLa29weVBXVW5FSjRBUmM5R1pWRW00RmZCRHJWb3VSakV1bjhs?=
 =?utf-8?B?azhxcGVUTVh2dnZvc2xIYXJJaVEyUG16RUNDQTlwd2MwaWwvWkhxcTIxbFFr?=
 =?utf-8?B?a3JMdStnUG1iZEh4c0w3L0hKZWlOVDNEdFU3TytlS2FMSWNUOFA2U3BNMWdO?=
 =?utf-8?B?andpaTMrV08rVS9xSFRnc0ZiVGJuRVBOZDhTSnJUeFM2ekpTcEFVOE8yd1gv?=
 =?utf-8?B?cTVGdXRxY1lvOHdhZTJNTVExWEJtM0JVMmxoT2ZkYU8xbGRKOTQ2MVg4OVIz?=
 =?utf-8?B?WElKMXdhTG1UekJtM3Z5VjB0dng4cjNoSVpBWnJLaEJLa2ZXaXVwY3RoTUd4?=
 =?utf-8?B?SWZ2aFpZaUVlbHdjZU8rU2pnZWxXODFzSG9ncVNheXdlMlFQQzI2R1dqTDYw?=
 =?utf-8?B?b3l2ZytHaWMrQkd3aU1GZGtuQzJ6ZVFrVnZ3Y0JCZ0JLRDFFOUpGc1pwejF4?=
 =?utf-8?B?MU9Iem9OWmpkTnZDT3lBTlhkMlphL1FrVVp4MTlVNDh4WmhOd1JWc294anRP?=
 =?utf-8?B?bTdOeEZFT0YxVVBPcnlldGVJdlhRVHZWemdINjF1RUtMMHcyb0ZiVm1telpa?=
 =?utf-8?B?TVBtWVlDRnpIS0R1VFNXc0ltdTV3YUV6RUxaVHR4SmJPaFRLMGEwcUJDZnpa?=
 =?utf-8?B?bDAxTWdyM2pENmdpMVVidlRvZ1Nyc1BhUTNWRWxkQ2JjTGw1QWdJais4Y01I?=
 =?utf-8?B?eUkyTENXb1RUbVkvQmFYRVBmMVU5bHNEeDZxd2orbGJTRmdwMUFkWU9xbFdS?=
 =?utf-8?B?ZXNqSkxQMG5sTmYyMzMwUFArL3hVY0RHUHJLTzNtdXQxWVRkUktXQnlmWGpo?=
 =?utf-8?B?NUhjSTdsV2IvUDJVYkd3YWk5TE41dlJmNktDMHkxaDZpb3E3RW56WVNZWUZr?=
 =?utf-8?B?Q0o2RnlQMU5LU0tJUW1nVnlqa3RlWjFuRldDL3BzZEUzeWdHZ1crMCt1enA1?=
 =?utf-8?B?WStLU3hUU3JvcW0yNW5OSlJjRG5hTXQvS3ZSZDVPaE5BTDhDa3RkRjUxVE9m?=
 =?utf-8?B?MUNibXZONU1tRzJ3bGxHYlM0b1U1eTB0T1FUKzFBREpyMTlsOWlCdlp0Wlpj?=
 =?utf-8?B?TldQRVJDOVpkQVFBUFp3MU9KVERvTXRYak9HdDVNU1VuaWhZdG1ZVjNTOW5u?=
 =?utf-8?B?b3VTMEhEU0VQVlpmZmVTZG4vQXBBazJuRE1odjJoUFZuc2NLNGYvV2N2Wm8z?=
 =?utf-8?B?b3JybFB6bThmT1pCa1BtV202c3dWb3RrUG5Hei9wZ1h6UUNXV0RkeEs2Sk1U?=
 =?utf-8?Q?DeTQJ9wkcq3fDGM8ENTpzKTru8iWBFVF1/XqaXpe1s=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <99774AFF4EC6154DAF19CC9BA0C089D3@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DB8PR03MB6108.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 52590a1e-3d95-41a5-7829-08d9eb3c39d0
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2022 19:50:14.9383
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: gsVKxBRHq0mWEHu/SvrHNIVy9YiFJgYW8Sp6hEtYP0KQnU/t+d3lSK/mn6QIXaYKCfLQ4DsO6YohdwR63bD926FbFlPySq+/4QMdbNg9n28=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0302MB2721
X-Proofpoint-GUID: ___JF_xVcPYkoXjSHGS1t1MYPhXP5gyQ
X-Proofpoint-ORIG-GUID: ___JF_xVcPYkoXjSHGS1t1MYPhXP5gyQ
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-08_06,2022-02-07_02,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0
 malwarescore=0 mlxscore=0 clxscore=1015 impostorscore=0 phishscore=0
 bulkscore=0 spamscore=0 adultscore=0 mlxlogscore=999 priorityscore=1501
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202080116

DQpPbiAwOC4wMi4yMiAxMzo1OCwgSnVsaWVuIEdyYWxsIHdyb3RlOg0KPiBIaSwNCg0KSGkgSnVs
aWVuDQoNCg0KPg0KPiBPbiAwNy8wMi8yMDIyIDE5OjU2LCBPbGVrc2FuZHIgVHlzaGNoZW5rbyB3
cm90ZToNCj4+DQo+PiBPbiAwNy4wMi4yMiAxOToxNSwgSnVsaWVuIEdyYWxsIHdyb3RlOg0KPj4+
IEhpIE9sZWtzYW5kciwNCj4+PiBPbiAwNS8wMS8yMDIyIDIzOjExLCBPbGVrc2FuZHIgVHlzaGNo
ZW5rbyB3cm90ZToNCj4+Pj4gRnJvbTogT2xla3NhbmRyIFR5c2hjaGVua28gPG9sZWtzYW5kcl90
eXNoY2hlbmtvQGVwYW0uY29tPg0KPj4+Pg0KPj4+PiBSZXdvcmsgQXJtIGltcGxlbWVudGF0aW9u
IHRvIHN0b3JlIGdyYW50IHRhYmxlIGZyYW1lIEdGTg0KPj4+PiBpbiBzdHJ1Y3QgcGFnZV9pbmZv
IGRpcmVjdGx5IGluc3RlYWQgb2Yga2VlcGluZyBpdCBpbg0KPj4+PiBzdGFuZGFsb25lIHN0YXR1
cy9zaGFyZWQgYXJyYXlzLiBUaGlzIHBhdGNoIGlzIGJhc2VkIG9uDQo+Pj4+IHRoZSBhc3N1bXB0
aW9uIHRoYXQgZ3JhbnQgdGFibGUgcGFnZSBpcyB0aGUgeGVuaGVhcCBwYWdlLg0KPj4+DQo+Pj4g
SSB3b3VsZCB3cml0ZSAiZ3JhbnQgdGFibGUgcGFnZXMgYXJlIHhlbmhlYXAgcGFnZXMiIG9yICJh
IGdyYW50IHRhYmxlDQo+Pj4gcGFnZSBpcyBhIHhlbmhlYXAgcGFnZSIuDQo+Pj4NCj4+PiBbLi4u
XQ0KPj4+DQo+Pj4+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vaW5jbHVkZS9hc20vZ3JhbnRf
dGFibGUuaA0KPj4+PiBiL3hlbi9hcmNoL2FybS9pbmNsdWRlL2FzbS9ncmFudF90YWJsZS5oDQo+
Pj4+IGluZGV4IGQzMWE0ZDYuLmQ2ZmRhMzEgMTAwNjQ0DQo+Pj4+IC0tLSBhL3hlbi9hcmNoL2Fy
bS9pbmNsdWRlL2FzbS9ncmFudF90YWJsZS5oDQo+Pj4+ICsrKyBiL3hlbi9hcmNoL2FybS9pbmNs
dWRlL2FzbS9ncmFudF90YWJsZS5oDQo+Pj4+IEBAIC0xMSwxMSArMTEsNiBAQA0KPj4+PiDCoMKg
ICNkZWZpbmUgSU5JVElBTF9OUl9HUkFOVF9GUkFNRVMgMVUNCj4+Pj4gwqDCoCAjZGVmaW5lIEdO
VFRBQl9NQVhfVkVSU0lPTiAxDQo+Pj4+IMKgwqAgLXN0cnVjdCBncmFudF90YWJsZV9hcmNoIHsN
Cj4+Pj4gLcKgwqDCoCBnZm5fdCAqc2hhcmVkX2dmbjsNCj4+Pj4gLcKgwqDCoCBnZm5fdCAqc3Rh
dHVzX2dmbjsNCj4+Pj4gLX07DQo+Pj4+IC0NCj4+Pj4gwqDCoCBzdGF0aWMgaW5saW5lIHZvaWQg
Z250dGFiX2NsZWFyX2ZsYWdzKHN0cnVjdCBkb21haW4gKmQsDQo+Pj4+IMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgIHVuc2lnbmVkIGludCBtYXNrLCB1aW50MTZfdA0KPj4+PiAqYWRkcikNCj4+Pj4g
wqDCoCB7DQo+Pj4+IEBAIC00Niw0MSArNDEsMTIgQEAgaW50IHJlcGxhY2VfZ3JhbnRfaG9zdF9t
YXBwaW5nKHVuc2lnbmVkIGxvbmcNCj4+Pj4gZ3BhZGRyLCBtZm5fdCBtZm4sDQo+Pj4+IMKgwqAg
I2RlZmluZSBnbnR0YWJfZG9tMF9mcmFtZXMoKSBcDQo+Pj4+IMKgwqDCoMKgwqDCoCBtaW5fdCh1
bnNpZ25lZCBpbnQsIG9wdF9tYXhfZ3JhbnRfZnJhbWVzLCBQRk5fRE9XTihfZXRleHQgLQ0KPj4+
PiBfc3RleHQpKQ0KPj4+PiDCoMKgIC0jZGVmaW5lIGdudHRhYl9pbml0X2FyY2goZ3QpIFwNCj4+
Pj4gLSh7IFwNCj4+Pj4gLcKgwqDCoCB1bnNpZ25lZCBpbnQgbmdmXyA9DQo+Pj4+IChndCktPm1h
eF9ncmFudF9mcmFtZXM7wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqAgXA0KPj4+PiAtwqDCoMKgIHVuc2lnbmVkIGludCBuc2ZfID0NCj4+Pj4gZ3JhbnRf
dG9fc3RhdHVzX2ZyYW1lcyhuZ2ZfKTvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoCBcDQo+Pj4+IC0gXA0KPj4+PiAtwqDCoMKgIChndCktPmFyY2guc2hhcmVkX2dmbiA9IHht
YWxsb2NfYXJyYXkoZ2ZuX3QsDQo+Pj4+IG5nZl8pO8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqAgXA0KPj4+PiAtwqDCoMKgIChndCktPmFyY2guc3RhdHVzX2dmbiA9IHhtYWxsb2Nf
YXJyYXkoZ2ZuX3QsDQo+Pj4+IG5zZl8pO8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqAgXA0KPj4+PiAtwqDCoMKgIGlmICggKGd0KS0+YXJjaC5zaGFyZWRfZ2ZuICYmIChndCktPmFy
Y2guc3RhdHVzX2dmbg0KPj4+PiApwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIFwNCj4+
Pj4gLSB7IFwNCj4+Pj4gLcKgwqDCoMKgwqDCoMKgIHdoaWxlICggbmdmXy0tDQo+Pj4+ICnCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgXA0KPj4+PiAtwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoCAoZ3QpLT5hcmNoLnNoYXJlZF9nZm5bbmdmX10gPQ0KPj4+PiBJTlZBTElEX0dG
TjvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgXA0KPj4+PiAtwqDCoMKgwqDC
oMKgwqAgd2hpbGUgKCBuc2ZfLS0NCj4+Pj4gKcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoCBcDQo+Pj4+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgIChndCktPmFyY2guc3Rh
dHVzX2dmbltuc2ZfXSA9DQo+Pj4+IElOVkFMSURfR0ZOO8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoCBcDQo+Pj4+IC0gfSBcDQo+Pj4+IC0gZWxzZSBcDQo+Pj4+IC0gZ250dGFi
X2Rlc3Ryb3lfYXJjaChndCk7IFwNCj4+Pj4gLcKgwqDCoCAoZ3QpLT5hcmNoLnNoYXJlZF9nZm4g
PyAwIDoNCj4+Pj4gLUVOT01FTTvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIFwNCj4+Pj4gLX0pDQo+Pj4+IC0NCj4+Pj4gLSNk
ZWZpbmUgZ250dGFiX2Rlc3Ryb3lfYXJjaChndCkgXA0KPj4+PiAtwqDCoMKgIGRvIHsgXA0KPj4+
PiAtIFhGUkVFKChndCktPmFyY2guc2hhcmVkX2dmbik7IFwNCj4+Pj4gLSBYRlJFRSgoZ3QpLT5h
cmNoLnN0YXR1c19nZm4pOyBcDQo+Pj4+IC3CoMKgwqAgfSB3aGlsZSAoIDAgKQ0KPj4+PiAtDQo+
Pj4+IMKgwqAgI2RlZmluZSBnbnR0YWJfc2V0X2ZyYW1lX2dmbihndCwgc3QsIGlkeCwgZ2ZuLA0K
Pj4+PiBtZm4pwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIFwNCj4+
Pj4gKHsgXA0KPj4+PiAtwqDCoMKgwqDCoMKgwqAgaW50IHJjXyA9DQo+Pj4+IDA7wqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgXA0KPj4+PiDCoMKgwqDCoMKg
wqDCoMKgwqDCoCBnZm5fdCBvZ2ZuID0gZ250dGFiX2dldF9mcmFtZV9nZm4oZ3QsIHN0LA0KPj4+
PiBpZHgpO8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgXA0KPj4+PiAtwqDCoMKg
wqDCoMKgwqAgaWYgKCBnZm5fZXEob2dmbiwgSU5WQUxJRF9HRk4pIHx8IGdmbl9lcShvZ2ZuLCBn
Zm4pDQo+Pj4+IHx8wqDCoMKgwqDCoMKgwqDCoMKgwqAgXA0KPj4+PiAtwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgIChyY18gPSBndWVzdF9waHlzbWFwX3JlbW92ZV9wYWdlKChndCktPmRvbWFpbiwg
b2dmbiwNCj4+Pj4gbWZuLMKgwqAgXA0KPj4+PiAtwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgIDApKSA9PSAwDQo+Pj4+ICnCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBc
DQo+Pj4+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgICgoc3QpID8NCj4+Pj4gKGd0KS0+YXJjaC5z
dGF0dXNfZ2ZuwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqAgXA0KPj4+PiAtwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oCA6IChndCktPmFyY2guc2hhcmVkX2dmbilbaWR4XSA9DQo+Pj4+IChnZm4pO8KgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgIFwNCj4+Pj4gLSByY187IFwNCj4+Pj4gK8KgwqDCoMKgwqDC
oMKgICghZ2ZuX2VxKG9nZm4sIElOVkFMSURfR0ZOKSAmJiAhZ2ZuX2VxKG9nZm4sDQo+Pj4+IGdm
bikpwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBcDQo+Pj4+ICvCoMKgwqDCoMKgwqDCoMKg
ID8gZ3Vlc3RfcGh5c21hcF9yZW1vdmVfcGFnZSgoZ3QpLT5kb21haW4sIG9nZm4sIG1mbiwNCj4+
Pj4gMCnCoMKgwqDCoMKgwqDCoMKgIFwNCj4+Pj4gK8KgwqDCoMKgwqDCoMKgwqAgOg0KPj4+PiAw
O8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqAgXA0KPj4+DQo+Pj4gR2l2ZW4gdGhhdCB3ZSBhcmUgaW1wbGVtZW50aW5nIHNvbWV0aGlu
ZyBzaW1pbGFyIHRvIGFuIE0yUCwgSSB3YXMNCj4+PiBleHBlY3RpbmcgdGhlIGltcGxlbWVudGF0
aW9uIHRvIGJlIHByZXR0eSBtdWNoIHRoZSBzYW1lIGFzIHRoZSB4ODYNCj4+PiBoZWxwZXIuDQo+
Pj4NCj4+PiBXb3VsZCB5b3UgYmUgYWJsZSB0byBvdXRsaW5lIHdoeSBpdCBpcyBkaWZmZXJlbnQ/
DQo+Pg0KPj4gQmVpbmcgaG9uZXN0LCBJIGRpZG4ndCB0aGluayBhYm91dCBpdCBzbyBmYXIuwqAg
QnV0LCBJIGFncmVlIHdpdGggdGhlDQo+PiBxdWVzdGlvbi4NCj4+DQo+PiBJdCBmZWVscyB0byBt
ZSB0aGF0IEFybSB2YXJpYW50IGNhbiBub3cgYmVoYXZlIGFzIHg4NiBvbmUgKGFzDQo+PiB4ZW5t
ZW1fYWRkX3RvX3BoeXNtYXBfb25lKCkgbm93IGNoZWNrcyBmb3IgdGhlIHByaW9yIG1hcHBpbmcp
LCBJIG1lYW4gdG8NCj4+IHVzZSBJTlZBTElEX0dGTiBhcyBhbiBpbmRpY2F0aW9uIHRvIHJlbW92
ZSBhIHBhZ2UuDQo+Pg0KPj4gV2hhdCBkbyB5b3UgdGhpbms/DQo+DQo+IEkgd2lsbCBkZWZlciB0
aGF0IHRvIEphbi4NCg0KSSB3aWxsIGNvbW1lbnQgb24gdGhpcyBpbiBhIHNlcGFyYXRlIG1haWwg
d2hlcmUgSmFuIGFscmVhZHkgYW5zd2VyZWQuDQoNCg0KPg0KPg0KPiBKYW4sIElJUkMgeW91IHdl
cmUgdGhlIG9uZSBpbnRyb2R1Y2luZyB0aGUgY2FsbCB0byANCj4gZ3Vlc3RfcGh5c21hcF9yZW1v
dmVfcGFnZSgpLiBEbyB5b3UgcmVtZW1iZXIgd2h5IHRoZSBkaWZmZXJlbmNlIA0KPiBiZXR3ZWVu
IHg4NiBhbmQgQXJtIHdlcmUgbmVjZXNzYXJ5Pw0KPg0KPiBbLi4uXQ0KPg0KPj4+DQo+Pj4NCj4+
Pj4gKyAqLw0KPj4+PiArI2RlZmluZSBQR1RfZ2ZuX3dpZHRowqDCoMKgwqAgUEdfc2hpZnQoMykN
Cj4+Pj4gKyNkZWZpbmUgUEdUX2dmbl9tYXNrwqDCoMKgwqDCoCAoKDFVTDw8UEdUX2dmbl93aWR0
aCktMSkNCj4+Pj4gKw0KPj4+PiArI2RlZmluZSBQR1RfSU5WQUxJRF9YRU5IRUFQX0dGTsKgwqAg
X2dmbihQR1RfZ2ZuX21hc2spDQo+Pj4+ICsNCj4+Pj4gKy8qDQo+Pj4+ICsgKiBBbiBhcmNoLXNw
ZWNpZmljIGluaXRpYWxpemF0aW9uIHBhdHRlcm4gaXMgbmVlZGVkIGZvciB0aGUNCj4+Pj4gdHlw
ZV9pbmZvIGZpZWxkDQo+Pj4+ICsgKiBhcyBpdCdzIEdGTiBwb3J0aW9uIGNhbiBjb250YWluIHRo
ZSB2YWxpZCBHRk4gaWYgcGFnZSBpcyB4ZW5oZWFwDQo+Pj4+IHBhZ2UuDQo+Pj4+ICsgKi8NCj4+
Pj4gKyNkZWZpbmUgUEdUX1RZUEVfSU5GT19JTklUX1BBVFRFUk4gZ2ZuX3goUEdUX0lOVkFMSURf
WEVOSEVBUF9HRk4pDQo+Pj4+IMKgwqAgwqDCoCAvKiBDbGVhcmVkIHdoZW4gdGhlIG93bmluZyBn
dWVzdCAnZnJlZXMnIHRoaXMgcGFnZS4gKi8NCj4+Pj4gwqDCoCAjZGVmaW5lIF9QR0NfYWxsb2Nh
dGVkwqDCoMKgIFBHX3NoaWZ0KDEpDQo+Pj4+IEBAIC0zNTgsNiArMzcxLDI1IEBAIHZvaWQgY2xl
YXJfYW5kX2NsZWFuX3BhZ2Uoc3RydWN0IHBhZ2VfaW5mbyANCj4+Pj4gKnBhZ2UpOw0KPj4+PiDC
oMKgIMKgIHVuc2lnbmVkIGludCBhcmNoX2dldF9kbWFfYml0c2l6ZSh2b2lkKTsNCj4+Pj4gwqDC
oCArc3RhdGljIGlubGluZSBnZm5fdCBwYWdlX2dldF94ZW5oZWFwX2dmbihjb25zdCBzdHJ1Y3Qg
cGFnZV9pbmZvIA0KPj4+PiAqcCkNCj4+Pj4gK3sNCj4+Pj4gK8KgwqDCoCBnZm5fdCBnZm5fID0g
X2dmbihwLT51LmludXNlLnR5cGVfaW5mbyAmIFBHVF9nZm5fbWFzayk7DQo+Pj4+ICsNCj4+Pj4g
K8KgwqDCoCBBU1NFUlQoaXNfeGVuX2hlYXBfcGFnZShwKSk7DQo+Pj4+ICsNCj4+Pj4gK8KgwqDC
oCByZXR1cm4gZ2ZuX2VxKGdmbl8sIFBHVF9JTlZBTElEX1hFTkhFQVBfR0ZOKSA/IElOVkFMSURf
R0ZOIDogDQo+Pj4+IGdmbl87DQo+Pj4+ICt9DQo+Pj4+ICsNCj4+Pj4gK3N0YXRpYyBpbmxpbmUg
dm9pZCBwYWdlX3NldF94ZW5oZWFwX2dmbihzdHJ1Y3QgcGFnZV9pbmZvICpwLCBnZm5fdCANCj4+
Pj4gZ2ZuKQ0KPj4+PiArew0KPj4+PiArwqDCoMKgIGdmbl90IGdmbl8gPSBnZm5fZXEoZ2ZuLCBJ
TlZBTElEX0dGTikgPyBQR1RfSU5WQUxJRF9YRU5IRUFQX0dGTg0KPj4+PiA6IGdmbjsNCj4+Pj4g
Kw0KPj4+PiArwqDCoMKgIEFTU0VSVChpc194ZW5faGVhcF9wYWdlKHApKTsNCj4+Pj4gKw0KPj4+
PiArwqDCoMKgIHAtPnUuaW51c2UudHlwZV9pbmZvICY9IH5QR1RfZ2ZuX21hc2s7DQo+Pj4+ICvC
oMKgwqAgcC0+dS5pbnVzZS50eXBlX2luZm8gfD0gZ2ZuX3goZ2ZuXyk7DQo+Pj4+ICt9DQo+Pj4N
Cj4+PiBUaGlzIGlzIG5vdCBnb2luZyB0byBiZSBhdG9taWMuIFNvIGNhbiB5b3Ugb3V0bGluZSB3
aGljaCBsb2NraW5nDQo+Pj4gbWVjaGFuaXNtIHNob3VsZCBiZSB1c2VkIHRvIHByb3RlY3QgYWNj
ZXNzIChzZXQvZ2V0KSB0byB0aGUgR0ZOPw0KPj4NCj4+DQo+PiBJIHRoaW5rLCB0aGUgUDJNIGxv
Y2suDQo+DQo+IE9rLiBTbywgbG9va2luZyBhdCB0aGUgY29kZSwgbW9zdCBvZiBjYWxscyB0byBw
YWdlX2dldF94ZW5oZWFwX2dmbigpIA0KPiBhcmUgbm90IHByb3RlY3RlZCB3aXRoIHRoZSBwMm1f
bG9jaygpLg0KDQpZZXMuDQoNCg0KVGhhbmsgeW91IGZvciB0aGUgc3VnZ2VzdGlvbnMgYmVsb3cs
IEkgZmVlbCBJIG5lZWQgc29tZSBjbGFyaWZpY2F0aW9ucyAuLi4NCg0KDQo+DQo+DQo+IChKYW4g
cGxlYXNlIGNvbmZpcm0pIElmIEkgYW0gbm90IG1pc3Rha2VuLCBvbiB4ODYsIGEgcmVhZCB0byB0
aGUgTTJQIA0KPiBpcyBub3QgYWx3YXlzIHByb3RlY3RlZC4gQnV0IHRoZXkgaGF2ZSBjb2RlIHdp
dGhpbiB0aGUgUDJNIGxvY2sgdG8gDQo+IGNoZWNrIGFueSBkaWZmZXJlbmNlIChzZWUgcDJtX3Jl
bW92ZV9wYWdlKCkpLiBJIHRoaW5rIHdlIHdvdWxkIG5lZWQgDQo+IHRoZSBzYW1lLCBzbyB3ZSBk
b24ndCBlbmQgdXAgdG8gaW50cm9kdWNlIGEgYmVoYXZpb3Igc2ltaWxhciB0byB3aGF0IA0KPiBY
U0EtMzg3IGhhcyBmaXhlZCBvbiB4ODYuDQoNCg0KLi4uIE9LLCBJIGFzc3VtZSB5b3UgYXJlIHNw
ZWFraW5nIGFib3V0IHRoZSBjaGVjayBpbiB0aGUgbG9vcCB0aGF0IHdhcyANCmFkZGVkIGJ5IHRo
ZSBmb2xsb3dpbmcgY29tbWl0Og0KYzY1ZWExNmRiY2FmYmU0ZmUyMTY5M2IxOGY4YzJhM2M1ZDE0
NjAwZSAieDg2L3AybTogZG9uJ3QgYXNzZXJ0IHRoYXQgdGhlIA0KcGFzc2VkIGluIE1GTiBtYXRj
aGVzIGZvciBhIHJlbW92ZSINCkFsc28sIEkgYXNzdW1lIHdlIG5lZWQgdGhhdCBjaGVjayBpbiB0
aGUgc2FtZSBwbGFjZSBvbiBBcm0gKHdpdGggUDJNIA0KbG9jayBoZWxkKSwgd2hpY2gsIEkgdGhp
bmssIGNvdWxkIGJlIHAybV9yZW1vdmVfbWFwcGluZygpLg0KDQpJIHBvcnRlZCB0aGUgY2hlY2sg
ZnJvbSB4ODYgY29kZSwgYnV0IHRoaXMgaXMgbm90IGEgdmVyYmF0aW0gY29weSBkdWUgdG8gDQp0
aGUgZGlmZmVyZW5jZSBpbiBsb2NhbCBQMk0gaGVscGVycy9tYWNybyBiZXR3ZWVuIGFyY2hlcywg
YWxzbyBJIGhhdmUgDQpza2lwcGVkIGEgcGFydCBvZiB0aGF0IGNoZWNrICJ8fCB0ID09IHAybV9t
bWlvX2RpcmVjdCIgd2hpY2ggd2FzIGFkZGVkIA0KYnkgb25lIG9mIHRoZSBmb2xsb3ctdXAgY29t
bWl0Og0KNzUzY2I2OGU2NTMwMDJlODlmZGNkMWM4MGU1MjkwNWZkYmZiNzhjYiAieDg2L3AybTog
Z3VhcmQgKGluIHBhcnRpY3VsYXIpIA0KaWRlbnRpdHkgbWFwcGluZyBlbnRyaWVzIg0Kc2luY2Ug
SSBoYXZlIG5vIGlkZWEgd2hldGhlciB3ZSBuZWVkIHRoZSBzYW1lIG9uIEFybS4NCg0KDQpCZWxv
dyB0aGUgZGlmZiBJIGhhdmUgbG9jYWxseToNCg0KZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9w
Mm0uYyBiL3hlbi9hcmNoL2FybS9wMm0uYw0KaW5kZXggNTY0NjM0My4uOTBkNzU2MyAxMDA2NDQN
Ci0tLSBhL3hlbi9hcmNoL2FybS9wMm0uYw0KKysrIGIveGVuL2FyY2gvYXJtL3AybS5jDQpAQCAt
MTMxNSwxMSArMTMxNSwzMiBAQCBzdGF0aWMgaW5saW5lIGludCBwMm1fcmVtb3ZlX21hcHBpbmco
c3RydWN0IA0KZG9tYWluICpkLA0KIMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIG1mbl90IG1mbikNCiDCoHsN
CiDCoMKgwqDCoCBzdHJ1Y3QgcDJtX2RvbWFpbiAqcDJtID0gcDJtX2dldF9ob3N0cDJtKGQpOw0K
K8KgwqDCoCB1bnNpZ25lZCBsb25nIGk7DQogwqDCoMKgwqAgaW50IHJjOw0KDQogwqDCoMKgwqAg
cDJtX3dyaXRlX2xvY2socDJtKTsNCivCoMKgwqAgZm9yICggaSA9IDA7IGkgPCBucjsgKQ0KK8Kg
wqDCoCB7DQorwqDCoMKgwqDCoMKgwqAgdW5zaWduZWQgaW50IGN1cl9vcmRlcjsNCivCoMKgwqDC
oMKgwqDCoCBib29sIHZhbGlkOw0KK8KgwqDCoMKgwqDCoMKgIG1mbl90IG1mbl9yZXR1cm4gPSBw
Mm1fZ2V0X2VudHJ5KHAybSwgZ2ZuX2FkZChzdGFydF9nZm4sIGkpLCANCk5VTEwsIE5VTEwsDQor
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgJmN1cl9vcmRlciwgJnZhbGlkKTsNCisNCivCoMKgwqDC
oMKgwqDCoCBpZiAoIHZhbGlkICYmDQorwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgICghbWZuX3Zh
bGlkKG1mbikgfHwgIW1mbl9lcShtZm5fYWRkKG1mbiwgaSksIG1mbl9yZXR1cm4pKSApDQorwqDC
oMKgwqDCoMKgwqAgew0KK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcmMgPSAtRUlMU0VROw0KK8Kg
wqDCoMKgwqDCoMKgwqDCoMKgwqAgZ290byBvdXQ7DQorwqDCoMKgwqDCoMKgwqAgfQ0KKw0KK8Kg
wqDCoMKgwqDCoMKgIGkgKz0gKDFVTCA8PCBjdXJfb3JkZXIpIC0NCivCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqAgKChnZm5feChzdGFydF9nZm4pICsgaSkgJiAoKDFVTCA8PCBjdXJfb3JkZXIpIC0g
MSkpOw0KK8KgwqDCoCB9DQorDQogwqDCoMKgwqAgcmMgPSBwMm1fc2V0X2VudHJ5KHAybSwgc3Rh
cnRfZ2ZuLCBuciwgSU5WQUxJRF9NRk4sDQogwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoCBwMm1faW52YWxpZCwgcDJtX2FjY2Vzc19yd3gpOw0KKw0KK291dDoN
CiDCoMKgwqDCoCBwMm1fd3JpdGVfdW5sb2NrKHAybSk7DQoNCiDCoMKgwqDCoCByZXR1cm4gcmM7
DQoNCg0KQ291bGQgeW91IHBsZWFzZSBjbGFyaWZ5LCBpcyBpdCBjbG9zZSB0byB3aGF0IHlvdSBo
YWQgaW4gbWluZD8gSWYgeWVzLCBJIA0KYW0gd29uZGVyaW5nLCBkb24ndCB3ZSBuZWVkIHRoaXMg
Y2hlY2sgdG8gYmUgb25seSBleGVjdXRlZCBmb3IgeGVuaGVhcCANCnBhZ2VzIChhbmQsIHByb2Jh
Ymx5LCB3aGljaCBQMk0ncyBlbnRyeSB0eXBlIGluIFJBTT8pIHJhdGhlciB0aGFuIGZvciANCmFs
bCBwYWdlcz8NCg0KDQo+DQo+DQo+IEluIGFkZGl0aW9uIHRvIHRoYXQsIGlmIHAybV9nZXRfeGVu
aGVhcF9nZm4oKSBpcyBnb2luZyB0byBiZSBjYWxsZWQgDQo+IGxvY2tsZXNzbHkuIFRoZW4gd2Ug
bmVlZCB0byBtYWtlIHN1cmUgdGhlIHVwZGF0ZSB0byB0eXBlX2luZm8gYXJlIA0KPiBhdG9taWMu
IFRoaXMgbWVhbnM6DQo+IMKgLSBwMm1fZ2V0X3hlbmhlYXBfZ2ZuKCkgc2hvdWxkIHVzZSBSRUFE
X09OQ0UoKS4NCj4gwqAtIHAybV9zZXRfeGVuaGVhcF9nZm4oKSBzaG91bGQgdXNlIFdSSVRFX09O
Q0UoKS4gV2UgbWlnaHQgZXZlbiBuZWVkIA0KPiB0byB1c2UgY21weGNoZygpIGlmIHRoZXJlIGFy
ZSBvdGhlciB1cGRhdGUgdG8gdHlwZV9pbmZvIHRoYXQgYXJlIG5vdCANCj4gcHJvdGVjdGVkLiBJ
IHdpbGwgbGV0IHlvdSBoYXZlIGEgbG9vay4NCg0KDQouLi4gT0ssIEkgZGlkbid0IGZpbmQgUkVB
RF9PTkNFL1dSSVRFX09OQ0UgaW4gWGVuLiBJIGFtIHdvbmRlcmluZywgY2FuIA0Kd2UgdXNlIEFD
Q0VTU19PTkNFIGluc3RlYWQ/DQoNCkJlbG93IHRoZSBkaWZmIEkgaGF2ZSBsb2NhbGx5Og0KDQpk
aWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL2luY2x1ZGUvYXNtL21tLmggYi94ZW4vYXJjaC9hcm0v
aW5jbHVkZS9hc20vbW0uaA0KaW5kZXggOWUwOTNhNi4uYjE4YWNiNyAxMDA2NDQNCi0tLSBhL3hl
bi9hcmNoL2FybS9pbmNsdWRlL2FzbS9tbS5oDQorKysgYi94ZW4vYXJjaC9hcm0vaW5jbHVkZS9h
c20vbW0uaA0KQEAgLTM3Myw3ICszNzMsNyBAQCB1bnNpZ25lZCBpbnQgYXJjaF9nZXRfZG1hX2Jp
dHNpemUodm9pZCk7DQoNCiDCoHN0YXRpYyBpbmxpbmUgZ2ZuX3QgcGFnZV9nZXRfeGVuaGVhcF9n
Zm4oY29uc3Qgc3RydWN0IHBhZ2VfaW5mbyAqcCkNCiDCoHsNCi3CoMKgwqAgZ2ZuX3QgZ2ZuXyA9
IF9nZm4ocC0+dS5pbnVzZS50eXBlX2luZm8gJiBQR1RfZ2ZuX21hc2spOw0KK8KgwqDCoCBnZm5f
dCBnZm5fID0gX2dmbihBQ0NFU1NfT05DRShwLT51LmludXNlLnR5cGVfaW5mbykgJiBQR1RfZ2Zu
X21hc2spOw0KDQogwqDCoMKgwqAgQVNTRVJUKGlzX3hlbl9oZWFwX3BhZ2UocCkpOw0KDQpAQCAt
MzgzLDExICszODMsMTQgQEAgc3RhdGljIGlubGluZSBnZm5fdCBwYWdlX2dldF94ZW5oZWFwX2dm
bihjb25zdCANCnN0cnVjdCBwYWdlX2luZm8gKnApDQogwqBzdGF0aWMgaW5saW5lIHZvaWQgcGFn
ZV9zZXRfeGVuaGVhcF9nZm4oc3RydWN0IHBhZ2VfaW5mbyAqcCwgZ2ZuX3QgZ2ZuKQ0KIMKgew0K
IMKgwqDCoMKgIGdmbl90IGdmbl8gPSBnZm5fZXEoZ2ZuLCBJTlZBTElEX0dGTikgPyBQR1RfSU5W
QUxJRF9YRU5IRUFQX0dGTiA6IGdmbjsNCivCoMKgwqAgdW5zaWduZWQgbG9uZyB0eXBlX2luZm87
DQoNCiDCoMKgwqDCoCBBU1NFUlQoaXNfeGVuX2hlYXBfcGFnZShwKSk7DQoNCi3CoMKgwqAgcC0+
dS5pbnVzZS50eXBlX2luZm8gJj0gflBHVF9nZm5fbWFzazsNCi3CoMKgwqAgcC0+dS5pbnVzZS50
eXBlX2luZm8gfD0gZ2ZuX3goZ2ZuXyk7DQorwqDCoMKgIHR5cGVfaW5mbyA9IEFDQ0VTU19PTkNF
KHAtPnUuaW51c2UudHlwZV9pbmZvKTsNCivCoMKgwqAgdHlwZV9pbmZvICY9IH5QR1RfZ2ZuX21h
c2s7DQorwqDCoMKgIHR5cGVfaW5mbyB8PSBnZm5feChnZm5fKTsNCivCoMKgwqAgQUNDRVNTX09O
Q0UocC0+dS5pbnVzZS50eXBlX2luZm8pID0gdHlwZV9pbmZvOw0KIMKgfQ0KDQogwqAjZW5kaWYg
LyrCoCBfX0FSQ0hfQVJNX01NX18gKi8NCg0KDQpJdCBpcyBnb2luZyB0byBiZSBhIG5vbi1wcm90
ZWN0ZWQgd3JpdGUgdG8gR0ZOIHBvcnRpb24gb2YgdHlwZV9pbmZvLiANCkJ1dCwgYXQgdGhhdCB0
aW1lIHRoZSBwYWdlIGlzIG5vdCB1c2VkIHlldCwgc28gSSB0aGluayB0aGlzIGlzIGhhcm1sZXNz
Lg0KDQpkaWZmIC0tZ2l0IGEveGVuL2NvbW1vbi9wYWdlX2FsbG9jLmMgYi94ZW4vY29tbW9uL3Bh
Z2VfYWxsb2MuYw0KaW5kZXggNTAzMzRhMC4uOTdjZjBkOCAxMDA2NDQNCi0tLSBhL3hlbi9jb21t
b24vcGFnZV9hbGxvYy5jDQorKysgYi94ZW4vY29tbW9uL3BhZ2VfYWxsb2MuYw0KQEAgLTEwMjQs
NyArMTAyNCw3IEBAIHN0YXRpYyBzdHJ1Y3QgcGFnZV9pbmZvICphbGxvY19oZWFwX3BhZ2VzKA0K
IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoCAmdGxiZmx1c2hfdGltZXN0YW1wKTsNCg0KIMKgwqDCoMKgwqDCoMKgwqDCoCAv
KiBJbml0aWFsaXNlIGZpZWxkcyB3aGljaCBoYXZlIG90aGVyIHVzZXMgZm9yIGZyZWUgcGFnZXMu
ICovDQotwqDCoMKgwqDCoMKgwqAgcGdbaV0udS5pbnVzZS50eXBlX2luZm8gPSAwOw0KK8KgwqDC
oMKgwqDCoMKgIHBnW2ldLnUuaW51c2UudHlwZV9pbmZvID0gUEdUX1RZUEVfSU5GT19JTklUSUFM
SVpFUjsNCiDCoMKgwqDCoMKgwqDCoMKgwqAgcGFnZV9zZXRfb3duZXIoJnBnW2ldLCBOVUxMKTsN
Cg0KIMKgwqDCoMKgwqAgfQ0KDQoNCj4NCj4NCj4gQ2hlZXJzLA0KPg0KLS0gDQpSZWdhcmRzLA0K
DQpPbGVrc2FuZHIgVHlzaGNoZW5rbw0K


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 21:08:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 21:08:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268707.462653 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHXid-0001V2-0t; Tue, 08 Feb 2022 21:08:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268707.462653; Tue, 08 Feb 2022 21:08:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHXic-0001Uv-TN; Tue, 08 Feb 2022 21:08:10 +0000
Received: by outflank-mailman (input) for mailman id 268707;
 Tue, 08 Feb 2022 21:08:09 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nHXib-0001Up-AS
 for xen-devel@lists.xenproject.org; Tue, 08 Feb 2022 21:08:09 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nHXia-0000nr-Mu; Tue, 08 Feb 2022 21:08:08 +0000
Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nHXia-0000eE-GY; Tue, 08 Feb 2022 21:08:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=ZA0Yumw2p88tKW3QSl0D0zi8Lgr8pGY9euujCfeNgN4=; b=D2OxKqufv7XqzvuN8b8W1B++Mw
	Aaje47CsFOoDVnOXKVG3ZjfqaT5SWrAqhz5KSxKGZ58RG2WOV2gt7KWqKU9GfbgTeht0EFKDjDFMm
	fzyZIDJ5Vi9iQblYwia+kFiDqnkpT428i/e+ztPCQm985nn5ws9A3k6scRUdyen3juL8=;
Message-ID: <fd95273c-d3cd-2b1a-6683-78ade82dd14c@xen.org>
Date: Tue, 8 Feb 2022 21:08:05 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.1
Subject: Re: [XEN PATCH v9 24/30] build: grab common EFI source files in arch
 specific dir
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <20220125110103.3527686-1-anthony.perard@citrix.com>
 <20220125110103.3527686-25-anthony.perard@citrix.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220125110103.3527686-25-anthony.perard@citrix.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 25/01/2022 11:00, Anthony PERARD wrote:
> Rather than preparing the efi source file, we will make the symbolic
> link as needed from the build location.

It is not a request for this series. I have started to look a bit more 
how the EFI code work on Arm and I was wondering why we are using 
symbolic here?

IOW, why wouldn't it be fine to build the "common" and "arch" specific 
bit (if any) separately and then assemble them?

Cheers,


-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 21:49:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 21:49:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268717.462664 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHYMg-0005ef-Cf; Tue, 08 Feb 2022 21:49:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268717.462664; Tue, 08 Feb 2022 21:49:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHYMg-0005eY-9B; Tue, 08 Feb 2022 21:49:34 +0000
Received: by outflank-mailman (input) for mailman id 268717;
 Tue, 08 Feb 2022 21:49:32 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nHYMe-0005eO-OP; Tue, 08 Feb 2022 21:49:32 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nHYMe-0001WR-JX; Tue, 08 Feb 2022 21:49:32 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nHYMe-0004oI-3u; Tue, 08 Feb 2022 21:49:32 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nHYMe-0004FR-2h; Tue, 08 Feb 2022 21:49:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=v4NoYW0oGgCvK8Yq1vFy/Z9aYJ35b56Gs35KcPos3Ts=; b=Gkb+oYgVJ2b25wOgbRDePYYR/C
	ruitXo8a2Ng0qqcplC4OhHAcfXVrysWs5tGfh8MpGpKI3vD+0+yzdw6HWlXv2dxnuT1pkpXsTfppF
	Y3shEZM+zWUlwIGBDeQr7akRL7YF+PIENj4YKqKhN9ImfYaOKFUZrUG8FutN3JodJ/jU=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168059-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 168059: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=0a301624c2f4ced3331ffd5bce85b4274fe132af
X-Osstest-Versions-That:
    qemuu=55ef0b702bc2c90c3c4ed97f97676d8f139e5ca1
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 08 Feb 2022 21:49:32 +0000

flight 168059 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168059/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168047
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168047
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168047
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168047
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168047
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168047
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168047
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168047
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                0a301624c2f4ced3331ffd5bce85b4274fe132af
baseline version:
 qemuu                55ef0b702bc2c90c3c4ed97f97676d8f139e5ca1

Last test of basis   168047  2022-02-07 15:37:04 Z    1 days
Testing same since   168059  2022-02-08 15:36:56 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alex Bennée <alex.bennee@linaro.org>
  Alexander Graf <agraf@csgraf.de>
  Andrew Jones <drjones@redhat.com>
  Cédric Le Goater <clg@kaod.org>
  Edgar E. Iglesias <edgar.iglesias@xilinx.com>
  Eric Auger <eric.auger@redhat.com>
  Francisco Iglesias <francisco.iglesias@xilinx.com>
  Kevin Townsend <kevin.townsend@linaro.org>
  Niek Linnenbank <nieklinnenbank@gmail.com>
  Peter Maydell <peter.maydell@linaro.org>
  Richard Henderson <richard.henderson@linaro.org>
  Richard Petri <git@rpls.de>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   55ef0b702b..0a301624c2  0a301624c2f4ced3331ffd5bce85b4274fe132af -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Tue Feb 08 22:05:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 08 Feb 2022 22:05:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268729.462674 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHYbu-0007x0-Om; Tue, 08 Feb 2022 22:05:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268729.462674; Tue, 08 Feb 2022 22:05:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHYbu-0007wt-Lr; Tue, 08 Feb 2022 22:05:18 +0000
Received: by outflank-mailman (input) for mailman id 268729;
 Tue, 08 Feb 2022 22:05:17 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nHYbt-0007wj-M1; Tue, 08 Feb 2022 22:05:17 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nHYbt-0001nu-J2; Tue, 08 Feb 2022 22:05:17 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nHYbt-0005cO-1j; Tue, 08 Feb 2022 22:05:17 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nHYbt-0000ff-1K; Tue, 08 Feb 2022 22:05:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=mfHbHG9B8/oGpYjC39/DgsJlZBo/EuHIMe327PQs8Bs=; b=cY5tfqT43NQTqHvG/cIrnv6+zQ
	LhymINYKbIANKhJUK7cL+WKACeyH6N1wRrO9b+2oO3yFD8JsGfUJrVxcWjDc+ZCHpY2kKoEIaAlJ+
	YP8zuhJlKNwOaTM+1cd1iEd5KBvVZQ+o9ZsJjzn8ppImoWbmfjq7GY6gOVRxFEDWq22c=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168065-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 168065: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=52ce1c97844db213de01c5300eaaa8cf101a285f
X-Osstest-Versions-That:
    xen=345746045b49258547d67f456c368f23353575d4
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 08 Feb 2022 22:05:17 +0000

flight 168065 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168065/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  52ce1c97844db213de01c5300eaaa8cf101a285f
baseline version:
 xen                  345746045b49258547d67f456c368f23353575d4

Last test of basis   168058  2022-02-08 14:02:51 Z    0 days
Testing same since   168065  2022-02-08 19:00:30 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Jan Beulich <jbeulich@suse.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   345746045b..52ce1c9784  52ce1c97844db213de01c5300eaaa8cf101a285f -> smoke


From xen-devel-bounces@lists.xenproject.org Wed Feb 09 01:29:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 09 Feb 2022 01:29:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268743.462685 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHbnQ-0003SD-Gw; Wed, 09 Feb 2022 01:29:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268743.462685; Wed, 09 Feb 2022 01:29:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHbnQ-0003S6-DZ; Wed, 09 Feb 2022 01:29:24 +0000
Received: by outflank-mailman (input) for mailman id 268743;
 Wed, 09 Feb 2022 01:29:22 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=c0q/=SY=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nHbnO-0003S0-Rr
 for xen-devel@lists.xenproject.org; Wed, 09 Feb 2022 01:29:22 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org
 [2604:1380:4601:e00::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b41905c7-8947-11ec-8eb8-a37418f5ba1a;
 Wed, 09 Feb 2022 02:29:21 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 90BB2B81DFB;
 Wed,  9 Feb 2022 01:29:19 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id D8774C004E1;
 Wed,  9 Feb 2022 01:29:17 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b41905c7-8947-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1644370158;
	bh=AzbPld7VgTSAOJC6/t+aJBT5ygQ1s5ec8szITG8qizQ=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=qe0kzPk1cYxiVDI0dH7Sp0wfBurJQcaPiflkrPQ4JgYICOj1m7t1ochWiELoQJQy8
	 KdpUgCAblHL7CzTwhFxYOd5Qppv9UUCIB8/yMvKQXTWQdofNKeGxdroBETU1JTEMK/
	 tuEDYKpFc5mzZ1rb+kG06UlwTo2kE+TNE/HfXwQUF7vGyDgQds+qwnMO0aIJHm7LJO
	 OOzLfLaXpMvC2aEN7qI9237NPsQ8E/ej7+2PJSqIL1M6xsXO8ux3Fsvx3Wgp5ETJBl
	 3vBFwW2zpIRsZfU4HxyvZ2wxG1PlReMk0eLYIjFglTrDIgx5/CZjRB7ocNPgsMx4i3
	 z4lT/MBVXwvbw==
Date: Tue, 8 Feb 2022 17:29:17 -0800 (PST)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>
cc: xen-devel@lists.xenproject.org, ayankuma@xilinx.com, 
    sstabellini@kernel.org, stefanos@xilinx.com, julien@xen.org, 
    Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com
Subject: Re: [XEN v7 1/2] xen/arm64: Decode ldr/str post increment
 operations
In-Reply-To: <20220205225816.5952-2-ayankuma@xilinx.com>
Message-ID: <alpine.DEB.2.22.394.2202081725170.2091381@ubuntu-linux-20-04-desktop>
References: <20220205225816.5952-1-ayankuma@xilinx.com> <20220205225816.5952-2-ayankuma@xilinx.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Sat, 5 Feb 2022, Ayan Kumar Halder wrote:
> At the moment, Xen does not decode any of the arm64 instructions. This
> means that hsr_dabt.isv = 0, Xen cannot handle those instructions. This
> will lead to Xen abort the guests (from which those instructions
> originated).
> 
> With this patch, Xen is able to decode ldr/str post indexing instructions.
> These are a subset of instructions for which hsr_dabt.isv = 0
> 
> The following instructions are now supported by Xen :-
> 1.      ldr     x2,    [x1],    #8
> 2.      ldr     w2,    [x1],    #-4
> 3.      ldr     x2,    [x1],    #-8
> 4.      ldr     w2,    [x1],    #4
> 5.      ldrh    w2,    [x1],    #2
> 6.      ldrb    w2,    [x1],    #1
> 7.      str     x2,    [x1],    #8
> 8.      str     w2,    [x1],    #-4
> 9.      strh    w2,    [x1],    #2
> 10.     strb    w2,    [x1],    #1
> 
> In the subsequent patches, decode_arm64() will get invoked when
> hsr_dabt.isv=0.
> 
> Signed-off-by: Ayan Kumar Halder <ayankuma@xilinx.com>

This patch looks good to me. Only minor comments below.


> ---
> 
> Changelog :-
> 
> v2..v5 - Mentioned in the cover letter.
> 
> v6 - 1. Fixed the code style issues as mentioned in v5.
> 
> v7 - No change.
> 
>  xen/arch/arm/decode.c           | 80 ++++++++++++++++++++++++++++++++-
>  xen/arch/arm/decode.h           | 49 +++++++++++++++++---
>  xen/arch/arm/include/asm/mmio.h |  4 ++
>  xen/arch/arm/io.c               |  2 +-
>  4 files changed, 125 insertions(+), 10 deletions(-)
> 
> diff --git a/xen/arch/arm/decode.c b/xen/arch/arm/decode.c
> index 792c2e92a7..3f2d2a3f62 100644
> --- a/xen/arch/arm/decode.c
> +++ b/xen/arch/arm/decode.c
> @@ -23,6 +23,7 @@
>  #include <xen/types.h>
>  
>  #include <asm/current.h>
> +#include <asm/mmio.h>

it doesn't look like this is needed


>  #include "decode.h"
>  
> @@ -84,6 +85,78 @@ bad_thumb2:
>      return 1;
>  }
>  
> +static int decode_arm64(register_t pc, mmio_info_t *info)
> +{
> +    union instr opcode = {0};
> +    struct hsr_dabt *dabt = &info->dabt;
> +    struct instr_details *dabt_instr = &info->dabt_instr;
> +
> +    if ( raw_copy_from_guest(&opcode.value, (void * __user)pc, sizeof (opcode)) )
> +    {
> +        gprintk(XENLOG_ERR, "Could not copy the instruction from PC\n");
> +        goto bad_loadstore;

this should just return 1 (no need to print the other error message
after the label bad_loadstore).


> +    }
> +
> +    /*
> +     * Refer Arm v8 ARM DDI 0487G.b, Page - C6-1107
> +     * "Shared decode for all encodings" (under ldr immediate)
> +     * If n == t && n != 31, then the return value is implementation defined
> +     * (can be WBSUPPRESS, UNKNOWN, UNDEFINED or NOP). Thus, we do not support
> +     * this. This holds true for ldrb/ldrh immediate as well.
> +     *
> +     * Also refer, Page - C6-1384, the above described behaviour is same for
> +     * str immediate. This holds true for strb/strh immediate as well
> +     */
> +    if ( (opcode.ldr_str.rn == opcode.ldr_str.rt) && (opcode.ldr_str.rn != 31) )
> +    {
> +        gprintk(XENLOG_ERR, "Rn should not be equal to Rt except for r31\n");
> +        goto bad_loadstore;
> +    }
> +
> +    /* First, let's check for the fixed values */
> +    if ( (opcode.value & POST_INDEX_FIXED_MASK) != POST_INDEX_FIXED_VALUE )
> +    {
> +        gprintk(XENLOG_ERR,
> +                "Decoding instruction 0x%x is not supported", opcode.value);
> +        goto bad_loadstore;
> +    }
> +
> +    if ( opcode.ldr_str.v != 0 )
> +    {
> +        gprintk(XENLOG_ERR,
> +                "ldr/str post indexing for vector types are not supported\n");
> +        goto bad_loadstore;
> +    }
> +
> +    /* Check for STR (immediate) */
> +    if ( opcode.ldr_str.opc == 0 )
> +        dabt->write = 1;
> +    /* Check for LDR (immediate) */
> +    else if ( opcode.ldr_str.opc == 1 )
> +        dabt->write = 0;
> +    else
> +    {
> +        gprintk(XENLOG_ERR,
> +                "Decoding ldr/str post indexing is not supported for this variant\n");
> +        goto bad_loadstore;
> +    }
> +
> +    gprintk(XENLOG_INFO,
> +            "opcode->ldr_str.rt = 0x%x, opcode->ldr_str.size = 0x%x, opcode->ldr_str.imm9 = %d\n",
> +            opcode.ldr_str.rt, opcode.ldr_str.size, opcode.ldr_str.imm9);
> +
> +    update_dabt(dabt, opcode.ldr_str.rt, opcode.ldr_str.size, false);
> +
> +    dabt_instr->rn = opcode.ldr_str.rn;
> +    dabt_instr->imm9 = opcode.ldr_str.imm9;
> +
> +    return 0;
> +
> + bad_loadstore:
> +    gprintk(XENLOG_ERR, "unhandled Arm instruction 0x%x\n", opcode.value);
> +    return 1;
> +}
> +
>  static int decode_thumb(register_t pc, struct hsr_dabt *dabt)
>  {
>      uint16_t instr;
> @@ -150,10 +223,13 @@ bad_thumb:
>      return 1;
>  }
>  
> -int decode_instruction(const struct cpu_user_regs *regs, struct hsr_dabt *dabt)
> +int decode_instruction(const struct cpu_user_regs *regs, mmio_info_t *info)
>  {
>      if ( is_32bit_domain(current->domain) && regs->cpsr & PSR_THUMB )
> -        return decode_thumb(regs->pc, dabt);
> +        return decode_thumb(regs->pc, &info->dabt);
> +
> +    if ( !psr_mode_is_32bit(regs) )
> +        return decode_arm64(regs->pc, info);
>  
>      /* TODO: Handle ARM instruction */
>      gprintk(XENLOG_ERR, "unhandled ARM instruction\n");
> diff --git a/xen/arch/arm/decode.h b/xen/arch/arm/decode.h
> index 4613763bdb..fe7512a053 100644
> --- a/xen/arch/arm/decode.h
> +++ b/xen/arch/arm/decode.h
> @@ -23,19 +23,54 @@
>  #include <asm/regs.h>
>  #include <asm/processor.h>
>  
> -/**
> - * Decode an instruction from pc
> - * /!\ This function is not intended to fully decode an instruction. It
> - * considers that the instruction is valid.
> +/*
> + * Refer to the ARMv8 ARM (DDI 0487G.b), Section C4.1.4 Loads and Stores
> + * Page 318 specifies the following bit pattern for
> + * "load/store register (immediate post-indexed)".
> + *
> + * 31 30 29  27 26 25  23   21 20              11   9         4       0
> + * ___________________________________________________________________
> + * |size|1 1 1 |V |0 0 |opc |0 |      imm9     |0 1 |  Rn     |  Rt   |
> + * |____|______|__|____|____|__|_______________|____|_________|_______|
> + */
> +union instr {
> +    uint32_t value;
> +    struct {
> +        unsigned int rt:5;     /* Rt register */
> +        unsigned int rn:5;     /* Rn register */
> +        unsigned int fixed1:2; /* value == 01b */
> +        signed int imm9:9;            /* imm9 */
> +        unsigned int fixed2:1; /* value == 0b */
> +        unsigned int opc:2;    /* opc */
> +        unsigned int fixed3:2; /* value == 00b */
> +        unsigned int v:1;      /* vector */
> +        unsigned int fixed4:3; /* value == 111b */
> +        unsigned int size:2;   /* size */
> +    } ldr_str;
> +};
> +
> +#define POST_INDEX_FIXED_MASK   0x3B200C00
> +#define POST_INDEX_FIXED_VALUE  0x38000400
> +
> +/* Decode an instruction from pc

code style:

/*
 * Decode an instruction from pc


> + * /!\ This function is intended to decode an instruction. It considers that the
> + * instruction is valid.
>   *
> - * This function will get:
> - *  - The transfer register
> + * In case of thumb mode, this function will get:
> + *  - The transfer register (ie Rt)
>   *  - Sign bit
>   *  - Size
> + *
> + * In case of arm64 mode, this function will get:
> + * - The transfer register (ie Rt)
> + * - The source register (ie Rn)
> + * - Size
> + * - Immediate offset
> + * - Read or write
>   */
>  
>  int decode_instruction(const struct cpu_user_regs *regs,
> -                       struct hsr_dabt *dabt);
> +                       mmio_info_t *info);
>  
>  #endif /* __ARCH_ARM_DECODE_H_ */
>  
> diff --git a/xen/arch/arm/include/asm/mmio.h b/xen/arch/arm/include/asm/mmio.h
> index 7ab873cb8f..3354d9c635 100644
> --- a/xen/arch/arm/include/asm/mmio.h
> +++ b/xen/arch/arm/include/asm/mmio.h
> @@ -29,6 +29,10 @@
>  typedef struct
>  {
>      struct hsr_dabt dabt;
> +    struct instr_details {
> +        unsigned long rn:5;
> +        signed int imm9:9;
> +    } dabt_instr;
>      paddr_t gpa;
>  } mmio_info_t;
>  
> diff --git a/xen/arch/arm/io.c b/xen/arch/arm/io.c
> index 729287e37c..a289d393f9 100644
> --- a/xen/arch/arm/io.c
> +++ b/xen/arch/arm/io.c
> @@ -134,7 +134,7 @@ enum io_state try_handle_mmio(struct cpu_user_regs *regs,
>      {
>          int rc;
>  
> -        rc = decode_instruction(regs, &info.dabt);
> +        rc = decode_instruction(regs, &info);
>          if ( rc )
>          {
>              gprintk(XENLOG_DEBUG, "Unable to decode instruction\n");
> -- 
> 2.17.1
> 


From xen-devel-bounces@lists.xenproject.org Wed Feb 09 01:50:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 09 Feb 2022 01:50:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268755.462697 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHc8E-0006bH-HH; Wed, 09 Feb 2022 01:50:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268755.462697; Wed, 09 Feb 2022 01:50:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHc8E-0006b9-CY; Wed, 09 Feb 2022 01:50:54 +0000
Received: by outflank-mailman (input) for mailman id 268755;
 Wed, 09 Feb 2022 01:50:53 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=c0q/=SY=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nHc8C-0006b3-V3
 for xen-devel@lists.xenproject.org; Wed, 09 Feb 2022 01:50:53 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org
 [2604:1380:4641:c500::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b38db284-894a-11ec-8f75-fffcc8bd4f1a;
 Wed, 09 Feb 2022 02:50:50 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id DC81061870;
 Wed,  9 Feb 2022 01:50:46 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id E1620C004E1;
 Wed,  9 Feb 2022 01:50:45 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b38db284-894a-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1644371446;
	bh=S3CVGNlN7AFl5B6x2W5L4nV3yuYiwegzzJVch0aiuC4=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=GixZTAIarnoe2U4MQShIVHB3xbqHdCCJqLikCpyngP1tkEcfI1QVAb5xRM0fDleNI
	 ixG8yJpbfASXKwXQN8W7NIiYmP9zLe34OF0m/yiMu8z1Y234IcQEBkJkUXKBsc78aR
	 7IQcp2bZ2Q0IeRkzwv4NUQcUQFa2NFhR0ZBLM4OpjgjWbgOvJ/4TVFaoTcyz5KjqLe
	 Kk0QfY6nn13GF1zUipeojXwR0S9t5zI+K1fTTcBmv0wBbueQYgiPtlVZkRD4aGlzD4
	 jNqejUmZboH1ig5N8bpwUDQwf34iWbQCk++PLYjXSo7Xyd6AxyXBO8EUzw57JxsMHR
	 ZhA128rj4KUEQ==
Date: Tue, 8 Feb 2022 17:50:45 -0800 (PST)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>
cc: xen-devel@lists.xenproject.org, ayankuma@xilinx.com, 
    sstabellini@kernel.org, stefanos@xilinx.com, julien@xen.org, 
    Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com
Subject: Re: [XEN v7 2/2] xen/arm64: io: Support instructions (for which ISS
 is not valid) on emulated MMIO region using MMIO/ioreq handler
In-Reply-To: <20220205225816.5952-3-ayankuma@xilinx.com>
Message-ID: <alpine.DEB.2.22.394.2202081730130.2091381@ubuntu-linux-20-04-desktop>
References: <20220205225816.5952-1-ayankuma@xilinx.com> <20220205225816.5952-3-ayankuma@xilinx.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Sat, 5 Feb 2022, Ayan Kumar Halder wrote:
> When an instruction is trapped in Xen due to translation fault, Xen checks if
> the ISS is valid. If not, Xen tries to resolve the translation fault using
> p2m page tables. In case if it is a data abort, Xen will try to map the mmio
> region to the guest (ie tries to emulate the mmio region).
> 
> If the ISS is not valid, then Xen tries to decode the instruction. In case of
> ioreq, Xen  saves the decoding state, rn and imm9 to vcpu_io. Whenever the
> vcpu handles the ioreq successfully, it will read the decoding state to
> determine if the instruction decoded was a ldr/str post indexing (ie
> INSTR_LDR_STR_POSTINDEXING). If so, it uses these details to post increment rn.
> 
> In case of mmio handler, if the mmio operation was successful, then Xen retrives
> the decoding state, rn and imm9. For state == INSTR_LDR_STR_POSTINDEXING, Xen
> will update rn.
> 
> If there is an error encountered while decoding the instruction, Xen will issue
> an abort to the guest. If the instruction was related to cache maintenance, Xen
> will not decode the instruction or do any MMIO operation. Rather it simply
> increments the PC and returns to the guest. If the instruction was trapped due
> to stage1 page translation table walk, Xen will update the page tables and will
> return to the guest so that it can retry the instruction. To handle all these
> different states, we have introduced 'enum instr_decode_state'.
> 
> Signed-off-by: Ayan Kumar Halder <ayankuma@xilinx.com>
> ---
> 
> Changelog :-
> 
> v2..v5 - Mentioned in the cover letter.
> 
> v6 - 1. Mantained the decoding state of the instruction. This is used by the
> caller to either abort the guest or retry or ignore or perform read/write on
> the mmio region.
> 
> 2. try_decode() invokes decoding for both aarch64 and thumb state. (Previously
> it used to invoke decoding only for aarch64 state). Thus, it handles all the
> checking of the registers before invoking any decoding of instruction.
> try_decode_instruction_invalid_iss() has thus been removed.
> 
> 3. Introduced a new field('enum instr_decode_state state') inside
> 'struct instr_details'. This holds the decoding state of the instruction.
> This is later read by the post_increment_register() to determine if rn needs to
> be incremented. Also, this is read by the callers of try_decode_instruction()
> to determine if the instruction was valid or ignored or to be retried or
> error or decoded successfully.
> 
> 4. Also stored 'instr_details' inside 'struct ioreq'. This enables
> arch_ioreq_complete_mmio() to invoke post_increment_register() without decoding
> the instruction again.
> 
> 5. Check hsr.dabt.valid in do_trap_stage2_abort_guest(). If it is not valid,
> then decode the instruction. This ensures that try_handle_mmio() is invoked only
> when the instruction is either valid or decoded successfully.
> 
> 6. Inside do_trap_stage2_abort_guest(), if hsr.dabt.valid is not set, then
> resolve the translation fault before trying to decode the instruction. If
> translation fault is resolved, then return to the guest to execute the instruction
> again.
> 
> 
> v7 - 1. Moved the decoding instruction details ie instr_details from 'struct ioreq'
> to 'struct vcpu_io'.
> 
> 2. The instruction is decoded only when we get a data abort.
> 
> 3. Replaced ASSERT_UNREACHABLE() with domain_crash(). The reason being asserts
> can be disabled in some builds. In this scenario when the guest's cpsr is in an
> erroneous state, Xen should crash the guest.
> 
> 4. Introduced check_p2m() which invokes p2m_resolve_translation_fault() and
> try_map_mmio() to resolve translation fault by configuring the page tables. This
> gets invoked first if ISS is invalid and it is an instruction abort. If it is
> a data abort and hsr.dabt.s1ptw is set or try_handle_mmio() returns IO_UNHANDLED,
> then check_p2m() gets invoked again.
> 
>  xen/arch/arm/arm32/traps.c        |   7 ++
>  xen/arch/arm/arm64/traps.c        |  47 +++++++++++++
>  xen/arch/arm/decode.c             |   1 +
>  xen/arch/arm/decode.h             |   3 +-
>  xen/arch/arm/include/asm/domain.h |   4 ++
>  xen/arch/arm/include/asm/ioreq.h  |   1 +
>  xen/arch/arm/include/asm/mmio.h   |  16 ++++-
>  xen/arch/arm/include/asm/traps.h  |   2 +
>  xen/arch/arm/io.c                 | 108 ++++++++++++++++++++----------
>  xen/arch/arm/ioreq.c              |  12 ++--
>  xen/arch/arm/traps.c              |  85 ++++++++++++++++++++---
>  xen/arch/x86/include/asm/ioreq.h  |   3 +
>  xen/include/xen/sched.h           |   2 +
>  13 files changed, 240 insertions(+), 51 deletions(-)
> 
> diff --git a/xen/arch/arm/arm32/traps.c b/xen/arch/arm/arm32/traps.c
> index 9c9790a6d1..70c6238196 100644
> --- a/xen/arch/arm/arm32/traps.c
> +++ b/xen/arch/arm/arm32/traps.c
> @@ -18,9 +18,11 @@
>  
>  #include <xen/lib.h>
>  #include <xen/kernel.h>
> +#include <xen/sched.h>
>  
>  #include <public/xen.h>
>  
> +#include <asm/mmio.h>
>  #include <asm/processor.h>
>  #include <asm/traps.h>
>  
> @@ -82,6 +84,11 @@ void do_trap_data_abort(struct cpu_user_regs *regs)
>          do_unexpected_trap("Data Abort", regs);
>  }
>  
> +void post_increment_register(const struct instr_details *instr)
> +{
> +    domain_crash(current->domain);
> +}
> +
>  /*
>   * Local variables:
>   * mode: C
> diff --git a/xen/arch/arm/arm64/traps.c b/xen/arch/arm/arm64/traps.c
> index 9113a15c7a..a6766689b3 100644
> --- a/xen/arch/arm/arm64/traps.c
> +++ b/xen/arch/arm/arm64/traps.c
> @@ -23,6 +23,7 @@
>  #include <asm/processor.h>
>  
>  #include <public/xen.h>
> +#include <xen/sched.h>
>  
>  static const char *handler[]= {
>          "Synchronous Abort",
> @@ -44,6 +45,52 @@ void do_bad_mode(struct cpu_user_regs *regs, int reason)
>      panic("bad mode\n");
>  }
>  
> +void post_increment_register(const struct instr_details *instr)
> +{
> +    struct cpu_user_regs *regs = guest_cpu_user_regs();
> +    register_t val = 0;
> +
> +    /* Currently, we handle only ldr/str post indexing instructions */
> +    if ( instr->state != INSTR_LDR_STR_POSTINDEXING )
> +        return;
> +
> +    /*
> +     * Handle when rn = SP
> +     * Refer ArmV8 ARM DDI 0487G.b, Page - D1-2463 "Stack pointer register
> +     * selection"
> +     * t = SP_EL0
> +     * h = SP_ELx
> +     * and M[3:0] (Page - C5-474 "When exception taken from AArch64 state:")
> +     */
> +    if (instr->rn == 31 )
> +    {
> +        if ( (regs->cpsr & PSR_MODE_MASK) == PSR_MODE_EL1h )
> +            val = regs->sp_el1;
> +        else if ( ((regs->cpsr & PSR_MODE_MASK) == PSR_MODE_EL1t) ||
> +                    ((regs->cpsr & PSR_MODE_MASK) == PSR_MODE_EL0t) )
> +            val = regs->sp_el0;
> +        else
> +        {
> +            domain_crash(current->domain);
> +            return;
> +        }
> +    }
> +    else
> +        val = get_user_reg(regs, instr->rn);
> +
> +    val += instr->imm9;
> +
> +    if ( instr->rn == 31 )
> +    {
> +        if ( (regs->cpsr & PSR_MODE_MASK) == PSR_MODE_EL1h )
> +            regs->sp_el1 = val;
> +        else
> +            regs->sp_el0 = val;
> +    }
> +    else
> +        set_user_reg(regs, instr->rn, val);
> +}
> +
>  /*
>   * Local variables:
>   * mode: C
> diff --git a/xen/arch/arm/decode.c b/xen/arch/arm/decode.c
> index 3f2d2a3f62..0a4d9d2772 100644
> --- a/xen/arch/arm/decode.c
> +++ b/xen/arch/arm/decode.c
> @@ -147,6 +147,7 @@ static int decode_arm64(register_t pc, mmio_info_t *info)
>  
>      update_dabt(dabt, opcode.ldr_str.rt, opcode.ldr_str.size, false);
>  
> +    dabt_instr->state = INSTR_LDR_STR_POSTINDEXING;
>      dabt_instr->rn = opcode.ldr_str.rn;
>      dabt_instr->imm9 = opcode.ldr_str.imm9;
>  
> diff --git a/xen/arch/arm/decode.h b/xen/arch/arm/decode.h
> index fe7512a053..6a09b07b46 100644
> --- a/xen/arch/arm/decode.h
> +++ b/xen/arch/arm/decode.h
> @@ -52,7 +52,8 @@ union instr {
>  #define POST_INDEX_FIXED_MASK   0x3B200C00
>  #define POST_INDEX_FIXED_VALUE  0x38000400
>  
> -/* Decode an instruction from pc
> +/*
> + * Decode an instruction from pc
>   * /!\ This function is intended to decode an instruction. It considers that the
>   * instruction is valid.
>   *

Ah! It should have been in the previous patch


> diff --git a/xen/arch/arm/include/asm/domain.h b/xen/arch/arm/include/asm/domain.h
> index 9b3647587a..29efbbd334 100644
> --- a/xen/arch/arm/include/asm/domain.h
> +++ b/xen/arch/arm/include/asm/domain.h
> @@ -266,6 +266,10 @@ static inline void arch_vcpu_block(struct vcpu *v) {}
>  /* vPCI is not available on Arm */
>  #define has_vpci(d)    ({ (void)(d); false; })
>  
> +struct arch_vcpu_io {
> +    struct instr_details *dabt_instr; /* when the instruction is decoded */
> +};
> +
>  #endif /* __ASM_DOMAIN_H__ */
>  
>  /*
> diff --git a/xen/arch/arm/include/asm/ioreq.h b/xen/arch/arm/include/asm/ioreq.h
> index 50185978d5..a2f2cf76c7 100644
> --- a/xen/arch/arm/include/asm/ioreq.h
> +++ b/xen/arch/arm/include/asm/ioreq.h
> @@ -52,6 +52,7 @@ static inline void msix_write_completion(struct vcpu *v)
>  {
>  }
>  
> +

Spurious change


>  /* This correlation must not be altered */
>  #define IOREQ_STATUS_HANDLED     IO_HANDLED
>  #define IOREQ_STATUS_UNHANDLED   IO_UNHANDLED
> diff --git a/xen/arch/arm/include/asm/mmio.h b/xen/arch/arm/include/asm/mmio.h
> index 3354d9c635..fb7ff72cdc 100644
> --- a/xen/arch/arm/include/asm/mmio.h
> +++ b/xen/arch/arm/include/asm/mmio.h
> @@ -26,12 +26,23 @@
>  
>  #define MAX_IO_HANDLER  16
>  
> +enum instr_decode_state
> +{
> +    INSTR_ERROR,                    /* Error encountered while decoding instr */
> +    INSTR_VALID,                    /* ISS is valid, so no need to decode */
> +    INSTR_LDR_STR_POSTINDEXING,     /* Instruction is decoded successfully.
> +                                       It is ldr/str post indexing */
> +    INSTR_IGNORE,                   /* Instruction is to be ignored (ie NOP) */
> +    INSTR_RETRY                     /* Instruction is to be retried */
> +};
> +
>  typedef struct
>  {
>      struct hsr_dabt dabt;
>      struct instr_details {
>          unsigned long rn:5;
>          signed int imm9:9;
> +        enum instr_decode_state state;
>      } dabt_instr;
>      paddr_t gpa;
>  } mmio_info_t;
> @@ -69,14 +80,15 @@ struct vmmio {
>  };
>  
>  enum io_state try_handle_mmio(struct cpu_user_regs *regs,
> -                              const union hsr hsr,
> -                              paddr_t gpa);
> +                              mmio_info_t *info);
>  void register_mmio_handler(struct domain *d,
>                             const struct mmio_handler_ops *ops,
>                             paddr_t addr, paddr_t size, void *priv);
>  int domain_io_init(struct domain *d, int max_count);
>  void domain_io_free(struct domain *d);
>  
> +void try_decode_instruction(const struct cpu_user_regs *regs,
> +                            mmio_info_t *info);
>  
>  #endif  /* __ASM_ARM_MMIO_H__ */
>  
> diff --git a/xen/arch/arm/include/asm/traps.h b/xen/arch/arm/include/asm/traps.h
> index 2ed2b85c6f..95c46ad391 100644
> --- a/xen/arch/arm/include/asm/traps.h
> +++ b/xen/arch/arm/include/asm/traps.h
> @@ -109,6 +109,8 @@ static inline register_t sign_extend(const struct hsr_dabt dabt, register_t r)
>      return r;
>  }
>  
> +void post_increment_register(const struct instr_details *instr);
> +
>  #endif /* __ASM_ARM_TRAPS__ */
>  /*
>   * Local variables:
> diff --git a/xen/arch/arm/io.c b/xen/arch/arm/io.c
> index a289d393f9..25bc7e481a 100644
> --- a/xen/arch/arm/io.c
> +++ b/xen/arch/arm/io.c
> @@ -95,57 +95,97 @@ static const struct mmio_handler *find_mmio_handler(struct domain *d,
>      return handler;
>  }
>  
> +void try_decode_instruction(const struct cpu_user_regs *regs,
> +                            mmio_info_t *info)
> +{
> +    int rc;
> +
> +    /*
> +     * Erratum 766422: Thumb store translation fault to Hypervisor may
> +     * not have correct HSR Rt value.
> +     */
> +    if ( check_workaround_766422() && (regs->cpsr & PSR_THUMB) &&
> +         info->dabt.write )
> +    {
> +        rc = decode_instruction(regs, info);
> +        if ( rc )
> +        {
> +            gprintk(XENLOG_DEBUG, "Unable to decode instruction\n");
> +            info->dabt_instr.state = INSTR_ERROR;
> +            return;
> +        }
> +    }
> +
> +    /* If ISS is valid, then no need to decode the instruction any further */
> +    if ( info->dabt.valid )
> +    {
> +        info->dabt_instr.state = INSTR_VALID;
> +        return;
> +    }
> +
> +    /*
> +     * Xen should not decode the instruction when it was trapped due to
> +     * translation fault.
> +     */
> +    if ( info->dabt.s1ptw )
> +    {
> +        info->dabt_instr.state = INSTR_RETRY;
> +        return;
> +    }
> +
> +    /*
> +     * If the fault occurred due to cache maintenance or address translation
> +     * instructions, then Xen needs to ignore these instructions.
> +     */
> +    if ( info->dabt.cache )
> +    {
> +        info->dabt_instr.state = INSTR_IGNORE;
> +        return;
> +    }
> +
> +    /*
> +     * Armv8 processor does not provide a valid syndrome for decoding some
> +     * instructions. So in order to process these instructions, Xen must
> +     * decode them.
> +     */
> +    rc = decode_instruction(regs, info);
> +    if ( rc )
> +    {
> +        gprintk(XENLOG_ERR, "Unable to decode instruction\n");
> +        info->dabt_instr.state = INSTR_ERROR;
> +    }
> +}
> +
>  enum io_state try_handle_mmio(struct cpu_user_regs *regs,
> -                              const union hsr hsr,
> -                              paddr_t gpa)
> +                              mmio_info_t *info)
>  {
>      struct vcpu *v = current;
>      const struct mmio_handler *handler = NULL;
> -    const struct hsr_dabt dabt = hsr.dabt;
> -    mmio_info_t info = {
> -        .gpa = gpa,
> -        .dabt = dabt
> -    };
> +    int rc;
>  
> -    ASSERT(hsr.ec == HSR_EC_DATA_ABORT_LOWER_EL);
> +    ASSERT(info->dabt.ec == HSR_EC_DATA_ABORT_LOWER_EL);
>  
> -    handler = find_mmio_handler(v->domain, info.gpa);
> +    handler = find_mmio_handler(v->domain, info->gpa);
>      if ( !handler )
>      {
> -        int rc;
> -
> -        rc = try_fwd_ioserv(regs, v, &info);
> +        rc = try_fwd_ioserv(regs, v, info);
>          if ( rc == IO_HANDLED )
>              return handle_ioserv(regs, v);
>  
>          return rc;
>      }
>  
> -    /* All the instructions used on emulated MMIO region should be valid */
> -    if ( !dabt.valid )
> -        return IO_ABORT;
> -
>      /*
> -     * Erratum 766422: Thumb store translation fault to Hypervisor may
> -     * not have correct HSR Rt value.
> +     * At this point, we know that the instruction is either valid or has been
> +     * decoded successfully. Thus, Xen should be allowed to execute the
> +     * instruction on the emulated MMIO region.
>       */
> -    if ( check_workaround_766422() && (regs->cpsr & PSR_THUMB) &&
> -         dabt.write )
> -    {
> -        int rc;
> -
> -        rc = decode_instruction(regs, &info);
> -        if ( rc )
> -        {
> -            gprintk(XENLOG_DEBUG, "Unable to decode instruction\n");
> -            return IO_ABORT;
> -        }
> -    }
> -
> -    if ( info.dabt.write )
> -        return handle_write(handler, v, &info);
> +    if ( info->dabt.write )
> +        rc = handle_write(handler, v, info);
>      else
> -        return handle_read(handler, v, &info);
> +        rc = handle_read(handler, v, info);
> +
> +    return rc;
>  }
>  
>  void register_mmio_handler(struct domain *d,
> diff --git a/xen/arch/arm/ioreq.c b/xen/arch/arm/ioreq.c
> index 308650b400..ec830a7a4a 100644
> --- a/xen/arch/arm/ioreq.c
> +++ b/xen/arch/arm/ioreq.c
> @@ -26,7 +26,8 @@
>  enum io_state handle_ioserv(struct cpu_user_regs *regs, struct vcpu *v)
>  {
>      const union hsr hsr = { .bits = regs->hsr };
> -    const struct hsr_dabt dabt = hsr.dabt;
> +    struct hsr_dabt dabt = hsr.dabt;

This change is not needed, right?


>      /* Code is similar to handle_read */
>      register_t r = v->io.req.data;
>  
> @@ -47,6 +48,7 @@ enum io_state try_fwd_ioserv(struct cpu_user_regs *regs,
>                               struct vcpu *v, mmio_info_t *info)
>  {
>      struct vcpu_io *vio = &v->io;
> +    struct dabt_instr *instr = &info->dabt_instr;
>      ioreq_t p = {
>          .type = IOREQ_TYPE_COPY,
>          .addr = info->gpa,
> @@ -65,6 +67,8 @@ enum io_state try_fwd_ioserv(struct cpu_user_regs *regs,
>      };
>      struct ioreq_server *s = NULL;
>      enum io_state rc;
> +    bool instr_decoded = false;
> +    const union hsr hsr = { .bits = regs->hsr };

It doesn't look like these two local variables are actually used
anywhere


>      if ( vio->req.state != STATE_IOREQ_NONE )
>      {
> @@ -76,10 +80,8 @@ enum io_state try_fwd_ioserv(struct cpu_user_regs *regs,
>      if ( !s )
>          return IO_UNHANDLED;
>  
> -    if ( !info->dabt.valid )
> -        return IO_ABORT;
> -
>      vio->req = p;
> +    vio->info.dabt_instr = instr;
>  
>      rc = ioreq_send(s, &p, 0);
>      if ( rc != IO_RETRY || v->domain->is_shutting_down )
> @@ -95,6 +97,7 @@ enum io_state try_fwd_ioserv(struct cpu_user_regs *regs,
>  bool arch_ioreq_complete_mmio(void)
>  {
>      struct vcpu *v = current;
> +    struct instr_details *dabt_instr = v->io.info.dabt_instr;
>      struct cpu_user_regs *regs = guest_cpu_user_regs();
>      const union hsr hsr = { .bits = regs->hsr };

I don't think that v->io.info.dabt_instr should be a pointer because at
this point the original structure is long gone. The original field was a
local variable mmio_info_t info in do_trap_stage2_abort_guest. So by the
time arch_ioreq_complete_mmio is called, the original variable has been
deallocated.

Instead, v->io.info.dabt_instr should be a "struct instr_details" (no
pointer).


> @@ -106,6 +109,7 @@ bool arch_ioreq_complete_mmio(void)
>  
>      if ( handle_ioserv(regs, v) == IO_HANDLED )
>      {
> +        post_increment_register(dabt_instr);
>          advance_pc(regs, hsr);
>          return true;
>      }
> diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c
> index 9339d12f58..fb5a2f9634 100644
> --- a/xen/arch/arm/traps.c
> +++ b/xen/arch/arm/traps.c
> @@ -1893,6 +1893,21 @@ static bool try_map_mmio(gfn_t gfn)
>      return !map_regions_p2mt(d, gfn, 1, mfn, p2m_mmio_direct_c);
>  }
>  
> +static inline bool check_p2m(bool is_data, paddr_t gpa)
> +{
> +    /*
> +     * First check if the translation fault can be resolved by the P2M subsystem.
> +     * If that's the case nothing else to do.
> +     */
> +    if ( p2m_resolve_translation_fault(current->domain,gaddr_to_gfn(gpa)) )
> +        return true;
> +
> +    if ( is_data && try_map_mmio(gaddr_to_gfn(gpa)) )
> +        return true;
> +
> +    return false;
> +}
> +
>  static void do_trap_stage2_abort_guest(struct cpu_user_regs *regs,
>                                         const union hsr hsr)
>  {
> @@ -1906,6 +1921,7 @@ static void do_trap_stage2_abort_guest(struct cpu_user_regs *regs,
>      paddr_t gpa;
>      uint8_t fsc = xabt.fsc & ~FSC_LL_MASK;
>      bool is_data = (hsr.ec == HSR_EC_DATA_ABORT_LOWER_EL);
> +    mmio_info_t info;
>  
>      /*
>       * If this bit has been set, it means that this stage-2 abort is caused
> @@ -1959,6 +1975,25 @@ static void do_trap_stage2_abort_guest(struct cpu_user_regs *regs,
>          return;
>      }
>      case FSC_FLT_TRANS:
> +    {
> +        info.gpa = gpa;
> +        info.dabt = hsr.dabt;
> +
> +        /* Check that the ISS is invalid and it is not data abort. */
> +        if ( !hsr.dabt.valid && !is_data )
> +        {
> +
> +            /*
> +             * Assumption :- Most of the times when we get a translation fault
> +             * and the ISS is invalid, the underlying cause is that the page
> +             * tables have not been set up correctly.
> +             */
> +            if ( check_p2m(is_data, gpa) )
> +                return;
> +            else
> +                goto inject_abt;
> +        }
> +
>          /*
>           * Attempt first to emulate the MMIO as the data abort will
>           * likely happen in an emulated region.
> @@ -1967,13 +2002,49 @@ static void do_trap_stage2_abort_guest(struct cpu_user_regs *regs,
>           */
>          if ( is_data )
>          {
> -            enum io_state state = try_handle_mmio(regs, hsr, gpa);
> +            enum io_state state;
> +
> +            try_decode_instruction(regs, &info);
> +
> +            /*
> +             * If the instruction was to be ignored by Xen, then it should return
> +             * to the caller which will increment the PC, so that the guest can
> +             * execute the next instruction.
> +             */
> +            if ( info.dabt_instr.state == INSTR_IGNORE )
> +            {
> +                advance_pc(regs, hsr);
> +                return;
> +            }
> +
> +            /*
> +             * If Xen could not decode the instruction for any reason, then it
> +             * should ask the caller to abort the guest.
> +             */
> +            else if ( info.dabt_instr.state == INSTR_ERROR )
> +                goto inject_abt;
> +
> +            /*
> +             * When the instruction needs to be retried by the guest after
> +             * resolving the translation fault.
> +             */
> +            else if ( info.dabt_instr.state == INSTR_RETRY )
> +                goto set_page_tables;
> +
> +            state = try_handle_mmio(regs, &info);
>  
>              switch ( state )
>              {
>              case IO_ABORT:
>                  goto inject_abt;
>              case IO_HANDLED:
> +                /*
> +                 * If the instruction was decoded and has executed successfully
> +                 * on the MMIO region, then Xen should execute the next part of
> +                 * the instruction. (for eg increment the rn if it is a
> +                 * post-indexing instruction.
> +                 */
> +                post_increment_register(&info.dabt_instr);
>                  advance_pc(regs, hsr);
>                  return;
>              case IO_RETRY:
> @@ -1985,18 +2056,12 @@ static void do_trap_stage2_abort_guest(struct cpu_user_regs *regs,
>              }
>          }
>  
> -        /*
> -         * First check if the translation fault can be resolved by the
> -         * P2M subsystem. If that's the case nothing else to do.
> -         */
> -        if ( p2m_resolve_translation_fault(current->domain,
> -                                           gaddr_to_gfn(gpa)) )
> -            return;
> -
> -        if ( is_data && try_map_mmio(gaddr_to_gfn(gpa)) )
> + set_page_tables:
> +        if ( check_p2m(is_data, gpa) )
>              return;
>  
>          break;
> +    }
>      default:
>          gprintk(XENLOG_WARNING,
>                  "Unsupported FSC: HSR=%#"PRIregister" DFSC=%#x\n",
> diff --git a/xen/arch/x86/include/asm/ioreq.h b/xen/arch/x86/include/asm/ioreq.h
> index d06ce9a6ea..ecfe7f9fdb 100644
> --- a/xen/arch/x86/include/asm/ioreq.h
> +++ b/xen/arch/x86/include/asm/ioreq.h
> @@ -26,6 +26,9 @@
>  #include <asm/hvm/ioreq.h>
>  #endif
>  
> +struct arch_vcpu_io {
> +};
> +
>  #endif /* __ASM_X86_IOREQ_H__ */
>  
>  /*
> diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
> index 37f78cc4c4..afe5508be8 100644
> --- a/xen/include/xen/sched.h
> +++ b/xen/include/xen/sched.h
> @@ -160,6 +160,8 @@ struct vcpu_io {
>      /* I/O request in flight to device model. */
>      enum vio_completion  completion;
>      ioreq_t              req;
> +    /* Arch specific info pertaining to the io request */
> +    struct arch_vcpu_io  info;
>  };
>  
>  struct vcpu
> -- 
> 2.17.1
> 


From xen-devel-bounces@lists.xenproject.org Wed Feb 09 02:12:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 09 Feb 2022 02:12:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268763.462708 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHcT9-0000wA-AB; Wed, 09 Feb 2022 02:12:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268763.462708; Wed, 09 Feb 2022 02:12:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHcT9-0000w3-6e; Wed, 09 Feb 2022 02:12:31 +0000
Received: by outflank-mailman (input) for mailman id 268763;
 Wed, 09 Feb 2022 02:12:30 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=c0q/=SY=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nHcT8-0000vv-1X
 for xen-devel@lists.xenproject.org; Wed, 09 Feb 2022 02:12:30 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org
 [2604:1380:4641:c500::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ba5b7558-894d-11ec-8f75-fffcc8bd4f1a;
 Wed, 09 Feb 2022 03:12:28 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id E6FA4615FD;
 Wed,  9 Feb 2022 02:12:26 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id C4A1FC004E1;
 Wed,  9 Feb 2022 02:12:25 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ba5b7558-894d-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1644372746;
	bh=eYTFPHLYqSlkHdFHZPO17fHDtEBhGQow7GlEeliKdUA=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=ot9Z2qZRodzBKbIOIFgVQTieYfDyGPP8hD1e5gnJdtnzuJIUV6J5lTwuoEDmXKdio
	 01IlhbP8UTDOU6Ieq4lBH2m1vJlh2XpAPUUrFBvRMZwK3RfCFOD8Rf5moAZN6UW3F3
	 uShZcbHnVSn0v3gz901nx1RxZNWoQ3goXszU5BqTH46v+JdWUTizq3tYttx2jsqf0V
	 WFZyqnpW9mkbmveah3m+cZdf90Ke9mV+YVLr0EEzXM4GBz8wC5sc0Ne4wY4QETXyBw
	 RbSakZU7hfWMWBH1I+U8exIcNuEf7A0NkxYjlbQX7tDfjxxnbQWgdXZtPkksD2n08x
	 RuKsF1PV8smvw==
Date: Tue, 8 Feb 2022 18:12:25 -0800 (PST)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Julien Grall <julien@xen.org>
cc: xen-devel@lists.xenproject.org, ehem+xen@m5p.com, 
    Julien Grall <jgrall@amazon.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Bertrand Marquis <bertrand.marquis@arm.com>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, 
    Wei Liu <wl@xen.org>, 
    =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>
Subject: Re: [PATCH RFC 2/3] xen/arm: efi: Introduce and fill the
 vga_console_info
In-Reply-To: <20220206192839.75711-3-julien@xen.org>
Message-ID: <alpine.DEB.2.22.394.2202081809060.2091381@ubuntu-linux-20-04-desktop>
References: <20220206192839.75711-1-julien@xen.org> <20220206192839.75711-3-julien@xen.org>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Sun, 6 Feb 2022, Julien Grall wrote:
> From: Julien Grall <jgrall@amazon.com>
> 
> In a follow-up patch will we want to add support for EFI framebuffer
> in dom0. Yet, Xen may not use the framebuffer, so it would be ideal
> to not have to enable CONFIG_VIDEO/CONFIG_VGA.
> 
> Introduce vga_console_info in a hacky way and move the code
> to fill it up from x86 to common.
> 
> Signed-off-by: Julien Grall <jgrall@amazon.com>
> 
> ----
> 
> This is a bit of a hack. Sent early to gather opinion on whether
> we should enable allow Dom0 to use the EFI Framebuffer even
> if Xen is built with CONFIG_VIDEO=n on Arm.

Yes, I think we should enable Dom0 to use the EFI framebuffer even if
Xen is built with CONFIG_VIDEO=n. I think CONFIG_VIDEO should be about
Xen's support for video output, not the guest's support for video
(including dom0's).

If we want to enable a super-minimal build of Xen with EFI support but
without VIDEO support even for Dom0, we could introduce a separate
Kconfig option for it. Probably not worth it.


> ---
>  xen/arch/arm/efi/efi-boot.h |  6 ---
>  xen/arch/arm/setup.c        |  4 ++
>  xen/arch/x86/efi/efi-boot.h | 72 ------------------------------------
>  xen/common/efi/boot.c       | 74 ++++++++++++++++++++++++++++++++++++-
>  xen/include/xen/vga.h       |  2 +-
>  5 files changed, 78 insertions(+), 80 deletions(-)
> 
> diff --git a/xen/arch/arm/efi/efi-boot.h b/xen/arch/arm/efi/efi-boot.h
> index ae8627134e5a..17a3d46c59ae 100644
> --- a/xen/arch/arm/efi/efi-boot.h
> +++ b/xen/arch/arm/efi/efi-boot.h
> @@ -1000,12 +1000,6 @@ static void __init efi_arch_console_init(UINTN cols, UINTN rows)
>  {
>  }
>  
> -static void __init efi_arch_video_init(EFI_GRAPHICS_OUTPUT_PROTOCOL *gop,
> -                                       UINTN info_size,
> -                                       EFI_GRAPHICS_OUTPUT_MODE_INFORMATION *mode_info)
> -{
> -}
> -
>  static void __init efi_arch_flush_dcache_area(const void *vaddr, UINTN size)
>  {
>      __flush_dcache_area(vaddr, size);
> diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
> index d5d0792ed48a..a336ee58179c 100644
> --- a/xen/arch/arm/setup.c
> +++ b/xen/arch/arm/setup.c
> @@ -71,6 +71,10 @@ static unsigned long opt_xenheap_megabytes __initdata;
>  integer_param("xenheap_megabytes", opt_xenheap_megabytes);
>  #endif
>  
> +#ifndef CONFIG_VIDEO
> +struct xen_vga_console_info vga_console_info;
> +#endif
> +
>  domid_t __read_mostly max_init_domid;
>  
>  static __used void init_done(void)
> diff --git a/xen/arch/x86/efi/efi-boot.h b/xen/arch/x86/efi/efi-boot.h
> index f69509a2103a..cba3fa75a475 100644
> --- a/xen/arch/x86/efi/efi-boot.h
> +++ b/xen/arch/x86/efi/efi-boot.h
> @@ -3,7 +3,6 @@
>   * is intended to be included by common/efi/boot.c _only_, and
>   * therefore can define arch specific global variables.
>   */
> -#include <xen/vga.h>
>  #include <asm/e820.h>
>  #include <asm/edd.h>
>  #include <asm/microcode.h>
> @@ -497,77 +496,6 @@ static void __init efi_arch_console_init(UINTN cols, UINTN rows)
>  #endif
>  }
>  
> -static void __init efi_arch_video_init(EFI_GRAPHICS_OUTPUT_PROTOCOL *gop,
> -                                       UINTN info_size,
> -                                       EFI_GRAPHICS_OUTPUT_MODE_INFORMATION *mode_info)
> -{
> -#ifdef CONFIG_VIDEO
> -    int bpp = 0;
> -
> -    switch ( mode_info->PixelFormat )
> -    {
> -    case PixelRedGreenBlueReserved8BitPerColor:
> -        vga_console_info.u.vesa_lfb.red_pos = 0;
> -        vga_console_info.u.vesa_lfb.red_size = 8;
> -        vga_console_info.u.vesa_lfb.green_pos = 8;
> -        vga_console_info.u.vesa_lfb.green_size = 8;
> -        vga_console_info.u.vesa_lfb.blue_pos = 16;
> -        vga_console_info.u.vesa_lfb.blue_size = 8;
> -        vga_console_info.u.vesa_lfb.rsvd_pos = 24;
> -        vga_console_info.u.vesa_lfb.rsvd_size = 8;
> -        bpp = 32;
> -        break;
> -    case PixelBlueGreenRedReserved8BitPerColor:
> -        vga_console_info.u.vesa_lfb.red_pos = 16;
> -        vga_console_info.u.vesa_lfb.red_size = 8;
> -        vga_console_info.u.vesa_lfb.green_pos = 8;
> -        vga_console_info.u.vesa_lfb.green_size = 8;
> -        vga_console_info.u.vesa_lfb.blue_pos = 0;
> -        vga_console_info.u.vesa_lfb.blue_size = 8;
> -        vga_console_info.u.vesa_lfb.rsvd_pos = 24;
> -        vga_console_info.u.vesa_lfb.rsvd_size = 8;
> -        bpp = 32;
> -        break;
> -    case PixelBitMask:
> -        bpp = set_color(mode_info->PixelInformation.RedMask, bpp,
> -                        &vga_console_info.u.vesa_lfb.red_pos,
> -                        &vga_console_info.u.vesa_lfb.red_size);
> -        bpp = set_color(mode_info->PixelInformation.GreenMask, bpp,
> -                        &vga_console_info.u.vesa_lfb.green_pos,
> -                        &vga_console_info.u.vesa_lfb.green_size);
> -        bpp = set_color(mode_info->PixelInformation.BlueMask, bpp,
> -                        &vga_console_info.u.vesa_lfb.blue_pos,
> -                        &vga_console_info.u.vesa_lfb.blue_size);
> -        if ( mode_info->PixelInformation.ReservedMask )
> -            bpp = set_color(mode_info->PixelInformation.ReservedMask, bpp,
> -                            &vga_console_info.u.vesa_lfb.rsvd_pos,
> -                            &vga_console_info.u.vesa_lfb.rsvd_size);
> -        if ( bpp > 0 )
> -            break;
> -        /* fall through */
> -    default:
> -        PrintErr(L"Current graphics mode is unsupported!\r\n");
> -        bpp  = 0;
> -        break;
> -    }
> -    if ( bpp > 0 )
> -    {
> -        vga_console_info.video_type = XEN_VGATYPE_EFI_LFB;
> -        vga_console_info.u.vesa_lfb.gbl_caps = 2; /* possibly non-VGA */
> -        vga_console_info.u.vesa_lfb.width =
> -            mode_info->HorizontalResolution;
> -        vga_console_info.u.vesa_lfb.height = mode_info->VerticalResolution;
> -        vga_console_info.u.vesa_lfb.bits_per_pixel = bpp;
> -        vga_console_info.u.vesa_lfb.bytes_per_line =
> -            (mode_info->PixelsPerScanLine * bpp + 7) >> 3;
> -        vga_console_info.u.vesa_lfb.lfb_base = gop->Mode->FrameBufferBase;
> -        vga_console_info.u.vesa_lfb.ext_lfb_base = gop->Mode->FrameBufferBase >> 32;
> -        vga_console_info.u.vesa_lfb.lfb_size =
> -            (gop->Mode->FrameBufferSize + 0xffff) >> 16;
> -    }
> -#endif
> -}
> -
>  static void __init efi_arch_memory_setup(void)
>  {
>      unsigned int i;
> diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c
> index 80e4e32623c4..2bc38ae40fff 100644
> --- a/xen/common/efi/boot.c
> +++ b/xen/common/efi/boot.c
> @@ -20,6 +20,7 @@
>  #endif
>  #include <xen/string.h>
>  #include <xen/stringify.h>
> +#include <xen/vga.h>
>  #ifdef CONFIG_X86
>  /*
>   * Keep this arch-specific modified include in the common file, as moving
> @@ -1025,6 +1026,77 @@ static void __init efi_get_apple_properties(void)
>      }
>  }
>  
> +static void __init efi_video_init(EFI_GRAPHICS_OUTPUT_PROTOCOL *gop,
> +                                  UINTN info_size,
> +                                  EFI_GRAPHICS_OUTPUT_MODE_INFORMATION *mode_info)
> +{
> +#if defined(CONFIG_VIDEO) || defined(CONFIG_ARM)
> +    int bpp = 0;
> +
> +    switch ( mode_info->PixelFormat )
> +    {
> +    case PixelRedGreenBlueReserved8BitPerColor:
> +        vga_console_info.u.vesa_lfb.red_pos = 0;
> +        vga_console_info.u.vesa_lfb.red_size = 8;
> +        vga_console_info.u.vesa_lfb.green_pos = 8;
> +        vga_console_info.u.vesa_lfb.green_size = 8;
> +        vga_console_info.u.vesa_lfb.blue_pos = 16;
> +        vga_console_info.u.vesa_lfb.blue_size = 8;
> +        vga_console_info.u.vesa_lfb.rsvd_pos = 24;
> +        vga_console_info.u.vesa_lfb.rsvd_size = 8;
> +        bpp = 32;
> +        break;
> +    case PixelBlueGreenRedReserved8BitPerColor:
> +        vga_console_info.u.vesa_lfb.red_pos = 16;
> +        vga_console_info.u.vesa_lfb.red_size = 8;
> +        vga_console_info.u.vesa_lfb.green_pos = 8;
> +        vga_console_info.u.vesa_lfb.green_size = 8;
> +        vga_console_info.u.vesa_lfb.blue_pos = 0;
> +        vga_console_info.u.vesa_lfb.blue_size = 8;
> +        vga_console_info.u.vesa_lfb.rsvd_pos = 24;
> +        vga_console_info.u.vesa_lfb.rsvd_size = 8;
> +        bpp = 32;
> +        break;
> +    case PixelBitMask:
> +        bpp = set_color(mode_info->PixelInformation.RedMask, bpp,
> +                        &vga_console_info.u.vesa_lfb.red_pos,
> +                        &vga_console_info.u.vesa_lfb.red_size);
> +        bpp = set_color(mode_info->PixelInformation.GreenMask, bpp,
> +                        &vga_console_info.u.vesa_lfb.green_pos,
> +                        &vga_console_info.u.vesa_lfb.green_size);
> +        bpp = set_color(mode_info->PixelInformation.BlueMask, bpp,
> +                        &vga_console_info.u.vesa_lfb.blue_pos,
> +                        &vga_console_info.u.vesa_lfb.blue_size);
> +        if ( mode_info->PixelInformation.ReservedMask )
> +            bpp = set_color(mode_info->PixelInformation.ReservedMask, bpp,
> +                            &vga_console_info.u.vesa_lfb.rsvd_pos,
> +                            &vga_console_info.u.vesa_lfb.rsvd_size);
> +        if ( bpp > 0 )
> +            break;
> +        /* fall through */
> +    default:
> +        PrintErr(L"Current graphics mode is unsupported!\r\n");
> +        bpp  = 0;
> +        break;
> +    }
> +    if ( bpp > 0 )
> +    {
> +        vga_console_info.video_type = XEN_VGATYPE_EFI_LFB;
> +        vga_console_info.u.vesa_lfb.gbl_caps = 2; /* possibly non-VGA */
> +        vga_console_info.u.vesa_lfb.width =
> +            mode_info->HorizontalResolution;
> +        vga_console_info.u.vesa_lfb.height = mode_info->VerticalResolution;
> +        vga_console_info.u.vesa_lfb.bits_per_pixel = bpp;
> +        vga_console_info.u.vesa_lfb.bytes_per_line =
> +            (mode_info->PixelsPerScanLine * bpp + 7) >> 3;
> +        vga_console_info.u.vesa_lfb.lfb_base = gop->Mode->FrameBufferBase;
> +        vga_console_info.u.vesa_lfb.ext_lfb_base = gop->Mode->FrameBufferBase >> 32;
> +        vga_console_info.u.vesa_lfb.lfb_size =
> +            (gop->Mode->FrameBufferSize + 0xffff) >> 16;
> +    }
> +#endif
> +}
> +
>  static void __init efi_set_gop_mode(EFI_GRAPHICS_OUTPUT_PROTOCOL *gop, UINTN gop_mode)
>  {
>      EFI_GRAPHICS_OUTPUT_MODE_INFORMATION *mode_info;
> @@ -1042,7 +1114,7 @@ static void __init efi_set_gop_mode(EFI_GRAPHICS_OUTPUT_PROTOCOL *gop, UINTN gop
>      /* Get graphics and frame buffer info. */
>      status = gop->QueryMode(gop, gop->Mode->Mode, &info_size, &mode_info);
>      if ( !EFI_ERROR(status) )
> -        efi_arch_video_init(gop, info_size, mode_info);
> +        efi_video_init(gop, info_size, mode_info);
>  }
>  
>  #define INVALID_VIRTUAL_ADDRESS (0xBAAADUL << \
> diff --git a/xen/include/xen/vga.h b/xen/include/xen/vga.h
> index f72b63d446b1..39b4c2eae198 100644
> --- a/xen/include/xen/vga.h
> +++ b/xen/include/xen/vga.h
> @@ -11,7 +11,7 @@
>  
>  #include <xen/video.h>
>  
> -#ifdef CONFIG_VGA
> +#if defined(CONFIG_VGA) || defined(CONFIG_ARM)
>  extern struct xen_vga_console_info vga_console_info;
>  #endif
>  
> -- 
> 2.32.0
> 


From xen-devel-bounces@lists.xenproject.org Wed Feb 09 05:11:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 09 Feb 2022 05:11:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268774.462719 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHfGQ-00014w-7K; Wed, 09 Feb 2022 05:11:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268774.462719; Wed, 09 Feb 2022 05:11:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHfGQ-00014o-40; Wed, 09 Feb 2022 05:11:34 +0000
Received: by outflank-mailman (input) for mailman id 268774;
 Wed, 09 Feb 2022 03:29:14 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=00vs=SY=linux.dev=cai.huoqing@srs-se1.protection.inumbo.net>)
 id 1nHdfN-0007qJ-JU
 for xen-devel@lists.xenproject.org; Wed, 09 Feb 2022 03:29:14 +0000
Received: from out0.migadu.com (out0.migadu.com [94.23.1.103])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 72929776-8958-11ec-8eb8-a37418f5ba1a;
 Wed, 09 Feb 2022 04:29:11 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 72929776-8958-11ec-8eb8-a37418f5ba1a
X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers.
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1;
	t=1644377349;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding;
	bh=nk/ogVvZ6G5p1cloPOlhe43E5L3x/YQoDgays1J5zEo=;
	b=YTNfyWsWjeJQ7m69DfJep2bexhfoncZFU2rMNsW4qldVIB7maRAB1nHaZFqcNEJzq2/C/1
	ZUnfPMHwcteobZMIJHyRu12rAbk45ppIlMie46CnYKwVBaeDYzogpJvA356JdasE+lqArv
	+Fr5kmRgoqRvn6NvKzY55QorpXznHVY=
From: Cai Huoqing <cai.huoqing@linux.dev>
To: cai.huoqing@linux.dev
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH] xen/pci: Make use of the helper macro LIST_HEAD()
Date: Wed,  9 Feb 2022 11:28:41 +0800
Message-Id: <20220209032842.38818-1-cai.huoqing@linux.dev>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Migadu-Flow: FLOW_OUT
X-Migadu-Auth-User: linux.dev

Replace "struct list_head head = LIST_HEAD_INIT(head)" with
"LIST_HEAD(head)" to simplify the code.

Signed-off-by: Cai Huoqing <cai.huoqing@linux.dev>
---
 drivers/xen/pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/xen/pci.c b/drivers/xen/pci.c
index 2c890f4f2cbc..72d4e3f193af 100644
--- a/drivers/xen/pci.c
+++ b/drivers/xen/pci.c
@@ -264,7 +264,7 @@ struct xen_device_domain_owner {
 };
 
 static DEFINE_SPINLOCK(dev_domain_list_spinlock);
-static struct list_head dev_domain_list = LIST_HEAD_INIT(dev_domain_list);
+static LIST_HEAD(dev_domain_list);
 
 static struct xen_device_domain_owner *find_device(struct pci_dev *dev)
 {
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Feb 09 05:28:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 09 Feb 2022 05:28:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268784.462730 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHfWY-0002f4-Lh; Wed, 09 Feb 2022 05:28:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268784.462730; Wed, 09 Feb 2022 05:28:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHfWY-0002ex-HJ; Wed, 09 Feb 2022 05:28:14 +0000
Received: by outflank-mailman (input) for mailman id 268784;
 Wed, 09 Feb 2022 05:28:12 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nHfWW-0002en-QS; Wed, 09 Feb 2022 05:28:12 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nHfWW-00047v-MI; Wed, 09 Feb 2022 05:28:12 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nHfWW-0002PD-7g; Wed, 09 Feb 2022 05:28:12 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nHfWW-00027z-5S; Wed, 09 Feb 2022 05:28:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=8JoajoOJwJ1qQf5NEm+kO7jS3qQdt9wzOpjMnXHkqXQ=; b=U32o7ZCR4pm92bG3XvKTev4ZAU
	C1Nvp1iEj431ZxGZGPhWoKixmwA5cJ0i4XFS5x0sbaG1qrBVB9I4Ip7MAC7j/06Dyu13YRYcSqHBe
	UMkV5wFymDQUxWpMkFZnQxhVBxRbIR0vJZxF26MAuCKPbdxkQqmxAY7godeT3VQwrX0c=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168060-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-5.4 test] 168060: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=76fd334f07cc11e047c2237a19b2cf8b1f653ba2
X-Osstest-Versions-That:
    linux=b8f53f91712808313bf7b5bd9947d7095968248a
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 09 Feb 2022 05:28:12 +0000

flight 168060 linux-5.4 real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168060/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168024
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168024
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168024
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168024
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168024
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168024
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168024
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168024
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168024
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168024
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168024
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168024
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 linux                76fd334f07cc11e047c2237a19b2cf8b1f653ba2
baseline version:
 linux                b8f53f91712808313bf7b5bd9947d7095968248a

Last test of basis   168024  2022-02-05 11:44:31 Z    3 days
Testing same since   168060  2022-02-08 17:43:16 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Albert Geantă <albertgeanta@gmail.com>
  Alexander Aring <aahringo@redhat.com>
  Alexandre Belloni <alexandre.belloni@bootlin.com>
  Andrew Morton <akpm@linux-foundation.org>
  Benjamin Gaignard <benjamin.gaignard@collabora.com>
  Bernard Metzler <bmt@zurich.ibm.com>
  Borislav Petkov <bp@suse.de>
  Camel Guo <camelg@axis.com>
  Catalin Marinas <catalin.marinas@arm.com>
  Christian Lachner <gladiac@gmail.com>
  Chuck Lever <chuck.lever@oracle.com>
  Dai Ngo <dai.ngo@oracle.com>
  Dan Carpenter <dan.carpenter@oracle.com>
  David Hildenbrand <david@redhat.com>
  David Sterba <dsterba@suse.com>
  Dinh Nguyen <dinguyen@kernel.org>
  Dmitry Ivanov <dmitry.ivanov2@hpe.com>
  Eric Wong <e@80x24.org>
  Florian Fainelli <f.fainelli@gmail.com>
  Gaosheng Cui <cuigaosheng1@huawei.com>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Guangwu Zhang <guazhang@redhat.com>
  Guenter Roeck <linux@roeck-us.net>
  Guoqing Jiang <guoqing.jiang@linux.dev>
  Jakub Kicinski <kuba@kernel.org>
  Jason Gunthorpe <jgg@nvidia.com>
  Jens Axboe <axboe@kernel.dk>
  Jiasheng Jiang <jiasheng@iscas.ac.cn>
  Joerg Roedel <jroedel@suse.de>
  John Meneghini <jmeneghi@redhat.com>
  Jon Hunter <jonathanh@nvidia.com>
  Kamal Dasu <kdasu.kdev@gmail.com>
  Karol Herbst <kherbst@redhat.com>
  Lang Yu <lang.yu@amd.com>
  Leon Romanovsky <leonro@nvidia.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Linus Walleij <linus.walleij@linaro.org>
  Linux Kernel Functional Testing <lkft@linaro.org>
  Lior Nahmanson <liorna@nvidia.com>
  Lu Baolu <baolu.lu@linux.intel.com>
  Mark Brown <broonie@kernel.org>
  Martin K. Petersen <martin.petersen@oracle.com>
  Mateusz Jończyk <mat.jonczyk@o2.pl> # preparation for stable
  Miaoqian Lin <linmq006@gmail.com>
  Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>
  Miquel Raynal <miquel.raynal@bootlin.com>
  Muhammad Usama Anjum <usama.anjum@collabora.com>
  Nick Lopez <github@glowingmonkey.org>
  Paul Moore <paul@paul-moore.com>
  Phil Auld <pauld@redhat.com>
  Raed Salem <raeds@nvidia.com>
  Ritesh Harjani <riteshh@linux.ibm.com>
  Riwen Lu <luriwen@kylinos.cn>
  Robert Hancock <robert.hancock@calian.com>
  Saurav Kashyap <skashyap@marvell.com>
  Sergey Shtylyov <s.shtylyov@omp.ru>
  Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
  Shuah Khan <skhan@linuxfoundation.org>
  Slade Watkins <slade@sladewatkins.com>
  Stefan Schmidt <stefan@datenfreihafen.org>
  Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
  Takashi Iwai <tiwai@suse.de>
  Tejun Heo <tj@kernel.org>
  Theodore Ts'o <tytso@mit.edu>
  Tvrtko Ursulin <tvrtko.ursulin@intel.com>
  Ville Syrjälä <ville.syrjala@linux.intel.com>
  Waiman Long <longman@redhat.com>
  Yannick Vignon <yannick.vignon@nxp.com>
  Yutian Yang <nglaive@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   b8f53f917128..76fd334f07cc  76fd334f07cc11e047c2237a19b2cf8b1f653ba2 -> tested/linux-5.4


From xen-devel-bounces@lists.xenproject.org Wed Feb 09 06:17:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 09 Feb 2022 06:17:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268796.462741 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHgI9-0007il-HI; Wed, 09 Feb 2022 06:17:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268796.462741; Wed, 09 Feb 2022 06:17:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHgI9-0007ie-Cr; Wed, 09 Feb 2022 06:17:25 +0000
Received: by outflank-mailman (input) for mailman id 268796;
 Wed, 09 Feb 2022 06:17:24 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=sex7=SY=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nHgI8-0007iV-Cc
 for xen-devel@lists.xenproject.org; Wed, 09 Feb 2022 06:17:24 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f0e1f8cd-896f-11ec-8f75-fffcc8bd4f1a;
 Wed, 09 Feb 2022 07:17:22 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 6179F1F390;
 Wed,  9 Feb 2022 06:17:21 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2776F13486;
 Wed,  9 Feb 2022 06:17:21 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id LFgxB3FcA2ISbgAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 09 Feb 2022 06:17:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f0e1f8cd-896f-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1644387441; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=8zqt8N0X5y3qkwMq8LYdTdJJ2Zd61U3aplddbbV9Lbg=;
	b=VRhqeV0JQvGq3Qi/qayiL7HbOi6BDVpjT2dRL6p+UpJh6CWMgCd+oO5XvKGQVEqqs0oD1/
	aE5f3qe5RgvTLJjOykGn2GwXDDwoFS4KpyMc7eeI9/7o6wV/hkOTNMnKNzR6w43OliAmPr
	jyC5pvmhEzutPCIjO/Csn0AI1QLj/Uc=
Message-ID: <b0995f72-1772-7c0a-155d-537b0df6569e@suse.com>
Date: Wed, 9 Feb 2022 07:17:20 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Subject: Re: [PATCH] xen/pci: Make use of the helper macro LIST_HEAD()
Content-Language: en-US
To: Cai Huoqing <cai.huoqing@linux.dev>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Stefano Stabellini <sstabellini@kernel.org>, xen-devel@lists.xenproject.org,
 linux-kernel@vger.kernel.org
References: <20220209032842.38818-1-cai.huoqing@linux.dev>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <20220209032842.38818-1-cai.huoqing@linux.dev>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------JZwkKbvpmmzcfNSTYoYJ4OYv"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------JZwkKbvpmmzcfNSTYoYJ4OYv
Content-Type: multipart/mixed; boundary="------------JHAhS3DI07LY0b1HfLdRC3Vq";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Cai Huoqing <cai.huoqing@linux.dev>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Stefano Stabellini <sstabellini@kernel.org>, xen-devel@lists.xenproject.org,
 linux-kernel@vger.kernel.org
Message-ID: <b0995f72-1772-7c0a-155d-537b0df6569e@suse.com>
Subject: Re: [PATCH] xen/pci: Make use of the helper macro LIST_HEAD()
References: <20220209032842.38818-1-cai.huoqing@linux.dev>
In-Reply-To: <20220209032842.38818-1-cai.huoqing@linux.dev>

--------------JHAhS3DI07LY0b1HfLdRC3Vq
Content-Type: multipart/mixed; boundary="------------8130HTxQhVjP7l15QOIqt60g"

--------------8130HTxQhVjP7l15QOIqt60g
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMDkuMDIuMjIgMDQ6MjgsIENhaSBIdW9xaW5nIHdyb3RlOg0KPiBSZXBsYWNlICJzdHJ1
Y3QgbGlzdF9oZWFkIGhlYWQgPSBMSVNUX0hFQURfSU5JVChoZWFkKSIgd2l0aA0KPiAiTElT
VF9IRUFEKGhlYWQpIiB0byBzaW1wbGlmeSB0aGUgY29kZS4NCj4gDQo+IFNpZ25lZC1vZmYt
Ynk6IENhaSBIdW9xaW5nIDxjYWkuaHVvcWluZ0BsaW51eC5kZXY+DQoNClJldmlld2VkLWJ5
OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+DQoNCg0KSnVlcmdlbg0K
--------------8130HTxQhVjP7l15QOIqt60g
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------8130HTxQhVjP7l15QOIqt60g--

--------------JHAhS3DI07LY0b1HfLdRC3Vq--

--------------JZwkKbvpmmzcfNSTYoYJ4OYv
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmIDXHAFAwAAAAAACgkQsN6d1ii/Ey9M
NAgAjzETVMGEGSkZFIPBUtFM8mAY8iN7mu6clpkdWMYf3ei7FIqS+7eFX6SrChH3N4d74yc6rRNl
aejllsTrgVizhAeotojOeztRkP2zP/3nMAEzWJrtNC90KTL4Qs1QIaddwFDsRIpBLklorrl/48LO
UQf7RQ5HGZ9p822qFu3tdx7CAwTv+ZByiQQ1+1XCel2m0gleYFgik/99QI01YFaaR/ZcNoJXP5Uk
hh1xV9SzX0XTM55Dd9vcSUeW/ZZK9nQUpGWBOSAtr3o+OE2SddJK9pcC5M0UukNHvMww08BO4nPQ
lahjDPp5dAco6O2RJianproo/OcKWILNTI4zXf3dRA==
=qGyV
-----END PGP SIGNATURE-----

--------------JZwkKbvpmmzcfNSTYoYJ4OYv--


From xen-devel-bounces@lists.xenproject.org Wed Feb 09 08:02:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 09 Feb 2022 08:02:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268816.462752 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHhvk-0001gP-O6; Wed, 09 Feb 2022 08:02:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268816.462752; Wed, 09 Feb 2022 08:02:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHhvk-0001gI-L4; Wed, 09 Feb 2022 08:02:24 +0000
Received: by outflank-mailman (input) for mailman id 268816;
 Wed, 09 Feb 2022 08:02:24 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1zPP=SY=linutronix.de=bigeasy@srs-se1.protection.inumbo.net>)
 id 1nHhvj-0001gC-Nh
 for xen-devel@lists.xenproject.org; Wed, 09 Feb 2022 08:02:24 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9bde2105-897e-11ec-8f75-fffcc8bd4f1a;
 Wed, 09 Feb 2022 09:02:22 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9bde2105-897e-11ec-8f75-fffcc8bd4f1a
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1644393741;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=FtIrm50qhttDnvw+t6HEGKMbZATCUZOMdzvBi9MSe90=;
	b=M+XiBZLvnS4bNyf917WB109HyC2w29CJUrl4+O3s0DgpsdEx7qd9LvVurUJCNhRS15Nnsu
	cRSfB+3pzT1O13psRd1f1F9RUn9biTeEoiOyQmgimdTbr/vjqZy4deWCmwndr0QD2ufJ+o
	Sqd0tsdtLPAXbSLtB6Ji4LmVP+iCKv0Wi8A/f7QNPsiv7QL9eRdaHboT0vES0Rkm5q3nVj
	SpwQ1re3o986jPQhDh5fxadxCmGBF1Vzc3lThDa3bMhOehonLIvbh9MLuv6ROwY5VULVZR
	2E4X2eG/cFMezVii0GULTAbaf5XfnGRONCEx1DX7F1mYfNUvbSlZMPFwSeGCFA==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1644393741;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=FtIrm50qhttDnvw+t6HEGKMbZATCUZOMdzvBi9MSe90=;
	b=+3CvOrEeIA0hMtHDBMPRo5y999b5GRmR5FqI8tJFmUGxGgnh38jpNfHNPILyt8qyLKUD1R
	20dt3aOcmPlVKbDQ==
To: linux-kernel@vger.kernel.org,
	x86@kernel.org,
	xen-devel@lists.xenproject.org
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Longpeng <longpeng2@huawei.com>,
	Gonglei <arei.gonglei@huawei.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@kernel.org>,
	Valentin Schneider <valentin.schneider@arm.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"H . Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Subject: [PATCH REPOST v2 1/2] x86/xen: Allow to retry if cpu_initialize_context() failed.
Date: Wed,  9 Feb 2022 09:02:13 +0100
Message-Id: <20220209080214.1439408-2-bigeasy@linutronix.de>
In-Reply-To: <20220209080214.1439408-1-bigeasy@linutronix.de>
References: <20220209080214.1439408-1-bigeasy@linutronix.de>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable

From: Boris Ostrovsky <boris.ostrovsky@oracle.com>

If memory allocation in cpu_initialize_context() fails then it will
bring up the VCPU and leave with the corresponding CPU bit set in
xen_cpu_initialized_map.
The following (presumably successful) CPU bring up will BUG in
xen_pv_cpu_up() because nothing for that VCPU would be initialized.

Clear the CPU bits, that were set in cpu_initialize_context() in case
the memory allocation fails.

[ bigeasy: Creating a patch from Boris' email. ]

Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Link: https://lore.kernel.org/r/20211206152034.2150770-2-bigeasy@linutronix=
.de
---
 arch/x86/xen/smp_pv.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/arch/x86/xen/smp_pv.c b/arch/x86/xen/smp_pv.c
index 4a6019238ee7d..57c3f9332ec94 100644
--- a/arch/x86/xen/smp_pv.c
+++ b/arch/x86/xen/smp_pv.c
@@ -260,8 +260,11 @@ cpu_initialize_context(unsigned int cpu, struct task_s=
truct *idle)
 		return 0;
=20
 	ctxt =3D kzalloc(sizeof(*ctxt), GFP_KERNEL);
-	if (ctxt =3D=3D NULL)
+	if (ctxt =3D=3D NULL) {
+		cpumask_clear_cpu(cpu, xen_cpu_initialized_map);
+		cpumask_clear_cpu(cpu, cpu_callout_mask);
 		return -ENOMEM;
+	}
=20
 	gdt =3D get_cpu_gdt_rw(cpu);
=20
--=20
2.34.1



From xen-devel-bounces@lists.xenproject.org Wed Feb 09 08:02:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 09 Feb 2022 08:02:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268818.462774 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHhvo-0002Ce-95; Wed, 09 Feb 2022 08:02:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268818.462774; Wed, 09 Feb 2022 08:02:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHhvo-0002CX-4z; Wed, 09 Feb 2022 08:02:28 +0000
Received: by outflank-mailman (input) for mailman id 268818;
 Wed, 09 Feb 2022 08:02:26 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1zPP=SY=linutronix.de=bigeasy@srs-se1.protection.inumbo.net>)
 id 1nHhvm-0001r0-HO
 for xen-devel@lists.xenproject.org; Wed, 09 Feb 2022 08:02:26 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9c59a9de-897e-11ec-8eb8-a37418f5ba1a;
 Wed, 09 Feb 2022 09:02:24 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9c59a9de-897e-11ec-8eb8-a37418f5ba1a
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1644393742;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=mGICh+XWg4zl0BiLYSOzGN+Dsvh3xZ6pQjRuhNeu4t0=;
	b=ExUJbo84qFWHQkDAcAAStNINkRabfk8iqlakMkfpAmeUEtkbAySRTYSeSJDPzjC8ESDJjs
	swNFfrhhlAGeF0NLs/r64Eyk+1Td6b9zKYMN3ok5zwYOgcaOAP1qkPPo1oL2jV2sNsdI5+
	LiSOvtHlUYOZK+mDwdteqLAhgWjyasTaXK64aUt9UGdT8Z5UiiLBZU6owgmiZqsUOgXuLM
	fEDKOzNGXSw1XwOn+qC53DI8miXoiqN0FrfwxuqRL9vsRDzdbnbAHm6QPh7QLy1Brvz86x
	AowW/70fENFFaxAkvAaZcbDSXsWmL22tSd1WGdhaLdOKNblqDvfFYeWtRQhi+w==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1644393742;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=mGICh+XWg4zl0BiLYSOzGN+Dsvh3xZ6pQjRuhNeu4t0=;
	b=g1B138BAtPqSmJQ3szFTc93wehmOLL8GH6VVKCoGPE7yBHuAp4eaCSW9kuMmWr95Ow20Gr
	zuRl08iV0JPH6NDg==
To: linux-kernel@vger.kernel.org,
	x86@kernel.org,
	xen-devel@lists.xenproject.org
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Longpeng <longpeng2@huawei.com>,
	Gonglei <arei.gonglei@huawei.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@kernel.org>,
	Valentin Schneider <valentin.schneider@arm.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"H . Peter Anvin" <hpa@zytor.com>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Dongli Zhang <dongli.zhang@oracle.com>,
	Henry Wang <Henry.Wang@arm.com>
Subject: [PATCH REPOST v2 2/2] cpu/hotplug: Allow the CPU in CPU_UP_PREPARE state to be brought up again.
Date: Wed,  9 Feb 2022 09:02:14 +0100
Message-Id: <20220209080214.1439408-3-bigeasy@linutronix.de>
In-Reply-To: <20220209080214.1439408-1-bigeasy@linutronix.de>
References: <20220209080214.1439408-1-bigeasy@linutronix.de>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable

From: "Longpeng(Mike)" <longpeng2@huawei.com>

A CPU will not show up in virtualized environment which includes an
Enclave. The VM splits its resources into a primary VM and a Enclave
VM. While the Enclave is active, the hypervisor will ignore all requests
to bring up a CPU and this CPU will remain in CPU_UP_PREPARE state.
The kernel will wait up to ten seconds for CPU to show up
(do_boot_cpu()) and then rollback the hotplug state back to
CPUHP_OFFLINE leaving the CPU state in CPU_UP_PREPARE. The CPU state is
set back to CPUHP_TEARDOWN_CPU during the CPU_POST_DEAD stage.

After the Enclave VM terminates, the primary VM can bring up the CPU
again.

Allow to bring up the CPU if it is in the CPU_UP_PREPARE state.

[bigeasy: Rewrite commit description.]

Signed-off-by: Longpeng(Mike) <longpeng2@huawei.com>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Link: https://lore.kernel.org/r/20210901051143.2752-1-longpeng2@huawei.com
Reviewed-by: Valentin Schneider <valentin.schneider@arm.com>
Tested-by: Dongli Zhang <dongli.zhang@oracle.com>
Reviewed-by: Henry Wang <Henry.Wang@arm.com>
Link: https://lore.kernel.org/r/20211122154714.xaoxok3fpk5bgznz@linutronix.=
de
Link: https://lore.kernel.org/r/20211206152034.2150770-3-bigeasy@linutronix=
.de
---
 kernel/smpboot.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/kernel/smpboot.c b/kernel/smpboot.c
index f6bc0bc8a2aab..b9f54544e7499 100644
--- a/kernel/smpboot.c
+++ b/kernel/smpboot.c
@@ -392,6 +392,13 @@ int cpu_check_up_prepare(int cpu)
 		 */
 		return -EAGAIN;
=20
+	case CPU_UP_PREPARE:
+		/*
+		 * Timeout while waiting for the CPU to show up. Allow to try
+		 * again later.
+		 */
+		return 0;
+
 	default:
=20
 		/* Should not happen.  Famous last words. */
--=20
2.34.1



From xen-devel-bounces@lists.xenproject.org Wed Feb 09 08:02:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 09 Feb 2022 08:02:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268817.462762 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHhvm-0001w5-W2; Wed, 09 Feb 2022 08:02:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268817.462762; Wed, 09 Feb 2022 08:02:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHhvm-0001vy-T0; Wed, 09 Feb 2022 08:02:26 +0000
Received: by outflank-mailman (input) for mailman id 268817;
 Wed, 09 Feb 2022 08:02:26 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1zPP=SY=linutronix.de=bigeasy@srs-se1.protection.inumbo.net>)
 id 1nHhvm-0001r0-2E
 for xen-devel@lists.xenproject.org; Wed, 09 Feb 2022 08:02:26 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9c115e87-897e-11ec-8eb8-a37418f5ba1a;
 Wed, 09 Feb 2022 09:02:24 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9c115e87-897e-11ec-8eb8-a37418f5ba1a
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1644393741;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding;
	bh=Wif2+D8xIFS05ms3vC/tlw/Lp5Jixy0HFVXUKnCOTkc=;
	b=BKSpVDboAbB04c8UKWU3/3FN6+QZwIsMMrXG2MHWEUl44AznK97B3GxtTJQhyLriSbJRES
	OmjG3Pc2XlVgBO0uI/IcBSzYAvZVVOHbyxTWFemF76KKfebfzZfBP93GnSYhbYnFkMj0b9
	Cs7VaOsl9K4VXnpNPvMK3GzHw8v1AW0B4S0pvJumHINH4LV1XsOwPJZq2uM0hd1/WijN8R
	hqiPkTWlB+/DvR+WpOUs6H4NdHSog0phWMhXNKH00NsPQncCAleMEUgSS+TZFlJ2RYiX/o
	1ejwsFGwV2Qh1lbu/ebUTUVy8lyi/c8kKQ/o0PQKL+kQ67eNRBXJraMTr7vPxA==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1644393741;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding;
	bh=Wif2+D8xIFS05ms3vC/tlw/Lp5Jixy0HFVXUKnCOTkc=;
	b=3/KmyOIUIb9YbWeQ0TVKV5GTKlK6SuWXvl1XUdcTswqUY/80O9zfP7saKRH7wenDcSoKpU
	UdIbq3lrpAY/YQAA==
To: linux-kernel@vger.kernel.org,
	x86@kernel.org,
	xen-devel@lists.xenproject.org
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Longpeng <longpeng2@huawei.com>,
	Gonglei <arei.gonglei@huawei.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@kernel.org>,
	Valentin Schneider <valentin.schneider@arm.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"H . Peter Anvin" <hpa@zytor.com>
Subject: [PATCH REPOST v2 0/2 v2] cpu/hotplug: Allow the CPU in CPU_UP_PREPARE state to be brought up again.
Date: Wed,  9 Feb 2022 09:02:12 +0100
Message-Id: <20220209080214.1439408-1-bigeasy@linutronix.de>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable

This is a another repost of the previous patch (#2) and adding Boris
(Ostrovsky)'s suggestion regarding the XEN bits.
The previous posts can be found at
   https://lore.kernel.org/all/20211206152034.2150770-1-bigeasy@linutronix.=
de/
   https://lore.kernel.org/all/20211122154714.xaoxok3fpk5bgznz@linutronix.d=
e/

Sebastian



From xen-devel-bounces@lists.xenproject.org Wed Feb 09 10:03:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 09 Feb 2022 10:03:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268901.462813 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHjod-0007gW-Sk; Wed, 09 Feb 2022 10:03:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268901.462813; Wed, 09 Feb 2022 10:03:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHjod-0007gP-Pc; Wed, 09 Feb 2022 10:03:11 +0000
Received: by outflank-mailman (input) for mailman id 268901;
 Wed, 09 Feb 2022 10:03:09 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nHjob-0007gF-Pl; Wed, 09 Feb 2022 10:03:09 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nHjob-0001FR-OB; Wed, 09 Feb 2022 10:03:09 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nHjob-0002JP-AP; Wed, 09 Feb 2022 10:03:09 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nHjob-0000AP-9y; Wed, 09 Feb 2022 10:03:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=NpsVWUWwvhJfiwkp9fTpxAKPQ0yycifTnAyEu23jCmE=; b=Jg2fOwGbcGRw1hQotQbVgYQD+X
	20CzT+dn7pB303uVniM78zDdBeqrK2X6cccc1hKnUY45Hts4HXNe6Ycv7Vcg6LXo9LFPK6m9JQRTU
	0eU9hq7a9iKjouNr+Ue3LpaRoYwSa3eua440aN/5OQXlJAaNGNypwu7MHJCIjlCxOQHo=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168068-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-coverity test] 168068: all pass - PUSHED
X-Osstest-Versions-This:
    xen=52ce1c97844db213de01c5300eaaa8cf101a285f
X-Osstest-Versions-That:
    xen=820cc393434097f3b7976acdccbf1d96071d6d23
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 09 Feb 2022 10:03:09 +0000

flight 168068 xen-unstable-coverity real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168068/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 xen                  52ce1c97844db213de01c5300eaaa8cf101a285f
baseline version:
 xen                  820cc393434097f3b7976acdccbf1d96071d6d23

Last test of basis   168033  2022-02-06 09:19:52 Z    3 days
Testing same since   168068  2022-02-09 09:21:03 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Michal Orzel <michal.orzel@arm.com>
  Roger Pau Monne <roger.pau@citrix.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 coverity-amd64                                               pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   820cc39343..52ce1c9784  52ce1c97844db213de01c5300eaaa8cf101a285f -> coverity-tested/smoke


From xen-devel-bounces@lists.xenproject.org Wed Feb 09 10:08:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 09 Feb 2022 10:08:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268913.462824 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHjtt-0008MA-Iq; Wed, 09 Feb 2022 10:08:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268913.462824; Wed, 09 Feb 2022 10:08:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHjtt-0008M3-Ff; Wed, 09 Feb 2022 10:08:37 +0000
Received: by outflank-mailman (input) for mailman id 268913;
 Wed, 09 Feb 2022 10:08:35 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=GcOB=SY=epam.com=prvs=403937fcac=oleksandr_tyshchenko@srs-se1.protection.inumbo.net>)
 id 1nHjtr-0008Lv-0w
 for xen-devel@lists.xenproject.org; Wed, 09 Feb 2022 10:08:35 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 3bcb5bb4-8990-11ec-8eb8-a37418f5ba1a;
 Wed, 09 Feb 2022 11:08:32 +0100 (CET)
Received: from pps.filterd (m0174679.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 219A3qql032203;
 Wed, 9 Feb 2022 10:08:28 GMT
Received: from eur02-ve1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2057.outbound.protection.outlook.com [104.47.6.57])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e4bhbr0qm-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 09 Feb 2022 10:08:27 +0000
Received: from DB8PR03MB6108.eurprd03.prod.outlook.com (2603:10a6:10:ed::15)
 by DB6PR0302MB2791.eurprd03.prod.outlook.com (2603:10a6:4:ae::23) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Wed, 9 Feb
 2022 10:08:23 +0000
Received: from DB8PR03MB6108.eurprd03.prod.outlook.com
 ([fe80::e975:b192:b8cd:4f73]) by DB8PR03MB6108.eurprd03.prod.outlook.com
 ([fe80::e975:b192:b8cd:4f73%5]) with mapi id 15.20.4951.019; Wed, 9 Feb 2022
 10:08:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3bcb5bb4-8990-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=U6FD3iUsnzlS4JlTpA+4TjXl4h2uY23PzeyAKZik1XC7J2uBckypTgH896eqYjYFZTvGzgbX10RwgkaYQF3aW0fICTV3h/vDn616r+j6lw4hjZEv44GN8N7o2a9DUbWB1C6b8BGVz0oO9AbgdvcEmTPS0CxixDeU5y/63ngozFLw3UmFOMPsH9uDHCaJShf8NOxKWOxmvcruyPgrw+wSaPAxfptmgddG9Kl9uNAUabt3hJMCQWraQFtGcFQButYEv4Tuo1O6pzZPI3/eFZ53YrLUlcBaxJd0vWJ2x7ojzANFIDix2N3mxJX1ZSE+upP3A4q0y3/ANh7dO9Upxx9cQA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=1wqi903n2MI4PHcd4l6EI4Q7NQWvn2LnDdlKTlj8A1g=;
 b=gKvU1Zt0psL9Tt5zHYRIXKJ47QhLITMxEfJkQYHWTS7bcJGXjGfBGOkjqWtYVvR74HGM0bo8c9kZnmopIighG7SOHLlLBa/kS6TIEu3U6/nR+a6TBz+i0bfWt0XcQyWEJ2iEU6yzeyX7+9NunkrhjjpjNO6MC2Q6UBfZV1hjKNG9k/Mumm1s0k9j552ErlUaB2qtSYKr9xYzplsOBObHLDIA5CqOXGmbxXQSvR3hwHCxpS84G/UWEo6VRCTSimzAl3Cum+y+iw664M2kCM61/0p3IO909EZOs3FqX7JRrVul3iQ28EIssfNqlyMu9pKgoHxysUmzcqsenefeWoTQNQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=1wqi903n2MI4PHcd4l6EI4Q7NQWvn2LnDdlKTlj8A1g=;
 b=VMnerk54QvQwRxcH37UoPHOcrXCVl+qA7OsgGrGBbmsfQvggBPK49h8M8OMm8nPx2HRM/yKcSIV+KIZWE+8MVLOVxz6V81fGdd7cZAgy1sj+bYnC8DRkdICncRp9zVQf443juoMkf/wKXi/d/o62tEmFKQV7i452T2TtqMniYZ6UdPPTqSP/pX5bzLarIhvDrproEiLizY8hoyata3vIx8HYBz/rwSrlF77X9m4sa5Iz0GA+DAcNcgPN+pG+Rky3nJVMgZsylP7AnLhHMf+M2gcZJanIw4zVtUMTsdtSOyhTBC8hV5KCx5lKbIxMvvmsCh1zcM5G2NdHNuvI1oPUpg==
From: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>
CC: Oleksandr Tyshchenko <olekstysh@gmail.com>,
        "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        Stefano
 Stabellini <sstabellini@kernel.org>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Andrew Cooper <andrew.cooper3@citrix.com>,
        George Dunlap
	<george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
        =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>,
        Bob Eshleman
	<bobbyeshleman@gmail.com>,
        Alistair Francis <alistair.francis@wdc.com>,
        Connor Davis <connojdavis@gmail.com>
Subject: Re: [PATCH V5] xen/gnttab: Store frame GFN in struct page_info on Arm
Thread-Topic: [PATCH V5] xen/gnttab: Store frame GFN in struct page_info on
 Arm
Thread-Index: AQHYAomKM/4d8JNsdEqc8nNA4dib2KyIh6IAgAAs1wCAAQzHgIAADcoAgAFl0gA=
Date: Wed, 9 Feb 2022 10:08:22 +0000
Message-ID: <d42f0e9f-d60d-8ec4-7053-9ecd1a069925@epam.com>
References: <1641424268-12968-1-git-send-email-olekstysh@gmail.com>
 <a54213c4-1c68-694e-c130-d95faeef3953@xen.org>
 <78d94e1e-6db4-25c1-adb8-e4bdbfe42774@epam.com>
 <82d8bfe0-cb46-d303-6a60-2324dd76a1f7@xen.org>
 <3629d57d-6d89-5ada-1664-cd532342fd0b@suse.com>
In-Reply-To: <3629d57d-6d89-5ada-1664-cd532342fd0b@suse.com>
Accept-Language: en-US, ru-RU
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 3d772a8e-0a6d-4cf0-0eed-08d9ebb41b28
x-ms-traffictypediagnostic: DB6PR0302MB2791:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <DB6PR0302MB27918D7D107B06ACB27B8450862E9@DB6PR0302MB2791.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:5797;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 mGDSXB6DqZSmxJDQymI/tpjHke2qvnC3zhuG8OHciOjIKOJXq7GfH0cqpd3+yYtPwXv9x7wCWPSGf7zaN9JEkASH9pZF+jhhL2Pyh3ZtAkO3Br9H+86uYD1WG4VpcwtLRgdDBm85MA21tvm8B82uLrENIaHoYNTuD8bzELaKTnbye5YgKeVgtrJH2KAirVv1hKFbvu1OBPDujYBytDpFGwJcVFDHRatxe+qE97/C40X00egwCunz+nh+cBIX3+WP/gBW25GPIs9b2b4fX/O00Sp1y6OgFjffIdoBi7u56Yd7tDuivPft707v+d4WePq/CPtJ1XGEcKGn644SMDEp5cJeM+KffhvLxzzbCWcLgH9K5IhMW9I9x4RuUOmJsF2XwYz7u9um2B2t/M8BOU86etZebrtFxWgk30jQFIiRjm/Kcl5488yCVjhVtXaEMAWOBY6aga8vGppNSMo3NCt0C9BOBfieV2P4FZuQgri6wfH22zga6M/XeHnC/WqYPNBpN4udDRaDb1aYGnRWi0The3jusEUcA4jbsn0CvdTdq3I+TH5naGRFZ62/mdwLkGgPRrt+CSRBYE2M/J1J2bij5be6siWq6oqMod8khR6ezA0xFsvud+jpVwYdGgV9Cfh2EhXWX850P4Zls1k2SKMxmCtFbPfrm5V//i1ioNkVHiyOOFo/4X3FOaji9+mijmnnp0WO2BWhdQ720lzZ6cAJO37Og2jNBwBOVwgPNtM3NvNJEWmYH7l/pjNfHugI5tgM
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB8PR03MB6108.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38070700005)(76116006)(66556008)(508600001)(8936002)(86362001)(31696002)(64756008)(66946007)(4326008)(66446008)(8676002)(6486002)(110136005)(91956017)(38100700002)(6512007)(6506007)(5660300002)(7416002)(55236004)(36756003)(53546011)(186003)(2616005)(71200400001)(26005)(2906002)(66476007)(122000001)(83380400001)(316002)(54906003)(31686004)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?QWd1cnJmVzZZUWNEMTFReS95c0I1dEhDK2NRdFQvNFc3UGYrUUp6eXNFajRm?=
 =?utf-8?B?blI0Vmp0aVlEb1J6RWJ6VXEwNm5uaFhUT0pnTmJ3bWdpTmFLSmNaK2VUNko5?=
 =?utf-8?B?dGpaaXR1aWFxbWxGUGtoTSt1MjVyVGFmY0NXUmZubkFIRjlpNUppVzIxSkc1?=
 =?utf-8?B?MUYxUS8zTkxSUXhQMW9XUVlVaU80ZDF1UnUxYTBRZGY3OEtEQjdxYTBSelFB?=
 =?utf-8?B?R0FPajczbTFkRTQzMTB4eE5YdFJ1SG9WWnVYRXdIWjFJVFZHMC9LTks3b3JV?=
 =?utf-8?B?c3N3bWwxY3k0VC9sdHhya1pVNzRsNHZQRHd2ZDJMVnd0WTNhZUpZRE5XY0tP?=
 =?utf-8?B?ODNyODNFbm1VL3FRUHcyTFc0SUVTVlJKbTNYZG9jbmJORStuYjFMSHEyV0xm?=
 =?utf-8?B?ZmNiaTFiaTF1L2czdFJaZkpNRFhpeTN0bjZlaEtZNGszcVdLU2FFcFRZMktK?=
 =?utf-8?B?ajhFNEVaY3BqQkRPK3NHT3c2SyttWGtHMkRKSjhMSTRRakJQM1ovYklQck9y?=
 =?utf-8?B?ekxKekR6bWd3L2hENERMZTlSQXpRS2RjU1o0YmNodFk0MVc5Sjk3ekppLzVa?=
 =?utf-8?B?SlA4Vm9kL2NIZHFpUHlaUGtqbGhlcVVyb1JLb3ltbmhtVGhZWjFXZjQ3ZUpn?=
 =?utf-8?B?MWxrblhYczFWSmVGYkxUdlZBd1dTdis0bHRkUnQyRkJSanMzbG9aNFlEeDlE?=
 =?utf-8?B?T0F6UkpiTGY0SVJmZXA0NWoyWlNqRk4rN00xREtaeHZhSWJ1ZTdKUHZKblZ1?=
 =?utf-8?B?VGQxM3YrTVFMNW1GWjRSeHEzbWNNVDB1RWZOZTdQRkJ4Um1QS2s2R1JQNzJq?=
 =?utf-8?B?OFI1RGR6RTlPMWNqR3p5VjA0UVBwMlg0QXlhWllJK1hYRlF1MTJnR3hEMUc0?=
 =?utf-8?B?SE1MY1V1dGhqa2lJNDdqVjdqNnRIOUFreDZ4dGFRWG9KRlNsZ2syQ0U5N0VL?=
 =?utf-8?B?YmNHdEFQZ3loRy9SK0FPRm8wZ0lCY01oZzJITG13cFVSeTc1T0dSaWErc3Vz?=
 =?utf-8?B?VFNsYzF1bHVzWmNxYnpNdzJmd2g2N0pEYTJFUk5SYkRKa0JkNlZmSm9laEhM?=
 =?utf-8?B?dzA1UUl4bXNoT1NtZCtFMDd0a3VUVGJIUFk4K1huYVpQeVhkNXhCQ2lsNkFr?=
 =?utf-8?B?Um8yeUxaaDQzMDJzTStaREs1V2gycGRxTkpZZUEvS2RieG55cEpncnFWWmY3?=
 =?utf-8?B?S2dDbnVYQkh3NG5OcjdvVFphbG9XYlluYUlSZkM1QWl4ZWtuNUhrU2x4UXBR?=
 =?utf-8?B?TU5VTWVULys4VGhvTGZ5QnhENVRMT3pmdzdpK3gzWWxQVmhGTmdtOWEwVG5X?=
 =?utf-8?B?TzZBOEp1cUdUQ1VhK1BEZjJmdElkcCtJb1VFcDk0cGhZVEVBSXFrRE5FeUgv?=
 =?utf-8?B?Q1lja0lvZ01leUpjbUFKRFRHc280RlR2Q2xPR25mMDRxNm1xemllWUV6NFgw?=
 =?utf-8?B?YlJWdHNlY3U0eE5EZ1J5Z2VxelRMSHNFTlh5eFUyVWo1bFMwV1lvYThuZU84?=
 =?utf-8?B?SXdQMWdJK2VNMEZBRkN1SWZKQ2IvMDBIL3JzL0VkV09mc1JLa3IzclVGU0lM?=
 =?utf-8?B?UlByWVl2cWV4RkZTcGVkb2NqZkFCTVVxTWI1QmtBTC9EU3N6T3pGQVBUZXB6?=
 =?utf-8?B?U0pMUDlOdCtVQzhMQTFKeVk0V1VGTXR3Z05uY1NCYjl3Q3loVkFBOFcyMk1E?=
 =?utf-8?B?dk1SbEdPZGhlcUtlSGswdUpQZTR5alZXbjRpRXBGNmNqNTlHT0dvR3pGajFq?=
 =?utf-8?B?MGhTUlk3eG9IQURiZk0yQVkrczVHMjZObTVRb1pUSUszRjBCbW1FbS9PNnNJ?=
 =?utf-8?B?bFRFcGMyWU1tVG9pNGplTTVCaVR3RHpEWVFZQUtBTWtRb3dGT0hLaTcwOHA1?=
 =?utf-8?B?anJ6cnpXak5KWTNUcDZndFZQL1gzdmFoMGZWaFY0dHlBV0E5SEUzZVZBY1Ax?=
 =?utf-8?B?UzdJN2YwZnZaTCtZWU1maG1MTzVyYW1rb3pjUldnNWp6aitOWFk2NCt3VVZu?=
 =?utf-8?B?NG91c0lzUm84UzBHcExjL3lKNFJRRWlScm5uaENjRXhSZDZBUXVsOUE0d2dJ?=
 =?utf-8?B?UXJ0WmlETmZaUVZ5eFRkTWhpRWJkeVViWXRaZUtDRmV1dys2RU1NR1pTM1Bt?=
 =?utf-8?B?UUlHQ3owVWs3azlXdmJKbGRRR3A4T0VGbUp0YkFCWEJOUU1GNkMwSnAydUMv?=
 =?utf-8?B?VE5KMEd6TWttZEdtNkV5eDFMTjM2SVdLYlRRTUhWUzJzZXk0QlIrTzhPTTB2?=
 =?utf-8?Q?MtCwlKLML9fV84+nE44lgfR/77fFsDAAPrszSSJcCI=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <DFD425AA89DE3143B63D07FBFB95053A@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DB8PR03MB6108.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3d772a8e-0a6d-4cf0-0eed-08d9ebb41b28
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Feb 2022 10:08:23.1105
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: vNOBqHFXTyB8huxZGavuhFM4wArBC9T0H3p4kkWe2T0cDZnDpfxxyE2tBSHLdBBxWlACrdWQGveT/ghADBHt86o1sD4qAOOJPNxutweMNGc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0302MB2791
X-Proofpoint-ORIG-GUID: c_ulG4EJg9xRD-2SvVfGOunoJ8WuehHx
X-Proofpoint-GUID: c_ulG4EJg9xRD-2SvVfGOunoJ8WuehHx
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-09_05,2022-02-09_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 spamscore=0
 malwarescore=0 bulkscore=0 impostorscore=0 clxscore=1015
 lowpriorityscore=0 adultscore=0 suspectscore=0 priorityscore=1501
 mlxscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202090065

DQpPbiAwOC4wMi4yMiAxNDo0NywgSmFuIEJldWxpY2ggd3JvdGU6DQoNCg0KSGkgSnVsaWVuLCBK
YW4NCg0KDQo+IE9uIDA4LjAyLjIwMjIgMTI6NTgsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4+IE9u
IDA3LzAyLzIwMjIgMTk6NTYsIE9sZWtzYW5kciBUeXNoY2hlbmtvIHdyb3RlOg0KPj4+IE9uIDA3
LjAyLjIyIDE5OjE1LCBKdWxpZW4gR3JhbGwgd3JvdGU6DQo+Pj4+IEhpIE9sZWtzYW5kciwNCj4+
Pj4gT24gMDUvMDEvMjAyMiAyMzoxMSwgT2xla3NhbmRyIFR5c2hjaGVua28gd3JvdGU6DQo+Pj4+
PiBGcm9tOiBPbGVrc2FuZHIgVHlzaGNoZW5rbyA8b2xla3NhbmRyX3R5c2hjaGVua29AZXBhbS5j
b20+DQo+Pj4+Pg0KPj4+Pj4gUmV3b3JrIEFybSBpbXBsZW1lbnRhdGlvbiB0byBzdG9yZSBncmFu
dCB0YWJsZSBmcmFtZSBHRk4NCj4+Pj4+IGluIHN0cnVjdCBwYWdlX2luZm8gZGlyZWN0bHkgaW5z
dGVhZCBvZiBrZWVwaW5nIGl0IGluDQo+Pj4+PiBzdGFuZGFsb25lIHN0YXR1cy9zaGFyZWQgYXJy
YXlzLiBUaGlzIHBhdGNoIGlzIGJhc2VkIG9uDQo+Pj4+PiB0aGUgYXNzdW1wdGlvbiB0aGF0IGdy
YW50IHRhYmxlIHBhZ2UgaXMgdGhlIHhlbmhlYXAgcGFnZS4NCj4+Pj4gSSB3b3VsZCB3cml0ZSAi
Z3JhbnQgdGFibGUgcGFnZXMgYXJlIHhlbmhlYXAgcGFnZXMiIG9yICJhIGdyYW50IHRhYmxlDQo+
Pj4+IHBhZ2UgaXMgYSB4ZW5oZWFwIHBhZ2UiLg0KPj4+Pg0KPj4+PiBbLi4uXQ0KPj4+Pg0KPj4+
Pj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9pbmNsdWRlL2FzbS9ncmFudF90YWJsZS5oDQo+
Pj4+PiBiL3hlbi9hcmNoL2FybS9pbmNsdWRlL2FzbS9ncmFudF90YWJsZS5oDQo+Pj4+PiBpbmRl
eCBkMzFhNGQ2Li5kNmZkYTMxIDEwMDY0NA0KPj4+Pj4gLS0tIGEveGVuL2FyY2gvYXJtL2luY2x1
ZGUvYXNtL2dyYW50X3RhYmxlLmgNCj4+Pj4+ICsrKyBiL3hlbi9hcmNoL2FybS9pbmNsdWRlL2Fz
bS9ncmFudF90YWJsZS5oDQo+Pj4+PiBAQCAtMTEsMTEgKzExLDYgQEANCj4+Pj4+ICAgwqAgI2Rl
ZmluZSBJTklUSUFMX05SX0dSQU5UX0ZSQU1FUyAxVQ0KPj4+Pj4gICDCoCAjZGVmaW5lIEdOVFRB
Ql9NQVhfVkVSU0lPTiAxDQo+Pj4+PiAgIMKgIC1zdHJ1Y3QgZ3JhbnRfdGFibGVfYXJjaCB7DQo+
Pj4+PiAtwqDCoMKgIGdmbl90ICpzaGFyZWRfZ2ZuOw0KPj4+Pj4gLcKgwqDCoCBnZm5fdCAqc3Rh
dHVzX2dmbjsNCj4+Pj4+IC19Ow0KPj4+Pj4gLQ0KPj4+Pj4gICDCoCBzdGF0aWMgaW5saW5lIHZv
aWQgZ250dGFiX2NsZWFyX2ZsYWdzKHN0cnVjdCBkb21haW4gKmQsDQo+Pj4+PiAgIMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoCB1bnNpZ25lZCBpbnQgbWFzaywgdWludDE2X3QNCj4+Pj4+ICphZGRyKQ0K
Pj4+Pj4gICDCoCB7DQo+Pj4+PiBAQCAtNDYsNDEgKzQxLDEyIEBAIGludCByZXBsYWNlX2dyYW50
X2hvc3RfbWFwcGluZyh1bnNpZ25lZCBsb25nDQo+Pj4+PiBncGFkZHIsIG1mbl90IG1mbiwNCj4+
Pj4+ICAgwqAgI2RlZmluZSBnbnR0YWJfZG9tMF9mcmFtZXMoKSBcDQo+Pj4+PiAgIMKgwqDCoMKg
wqAgbWluX3QodW5zaWduZWQgaW50LCBvcHRfbWF4X2dyYW50X2ZyYW1lcywgUEZOX0RPV04oX2V0
ZXh0IC0NCj4+Pj4+IF9zdGV4dCkpDQo+Pj4+PiAgIMKgIC0jZGVmaW5lIGdudHRhYl9pbml0X2Fy
Y2goZ3QpIFwNCj4+Pj4+IC0oeyBcDQo+Pj4+PiAtwqDCoMKgIHVuc2lnbmVkIGludCBuZ2ZfID0N
Cj4+Pj4+IChndCktPm1heF9ncmFudF9mcmFtZXM7wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgXA0KPj4+Pj4gLcKgwqDCoCB1bnNpZ25lZCBpbnQgbnNm
XyA9DQo+Pj4+PiBncmFudF90b19zdGF0dXNfZnJhbWVzKG5nZl8pO8KgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgIFwNCj4+Pj4+IC0gXA0KPj4+Pj4gLcKgwqDCoCAoZ3QpLT5h
cmNoLnNoYXJlZF9nZm4gPSB4bWFsbG9jX2FycmF5KGdmbl90LA0KPj4+Pj4gbmdmXyk7wqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBcDQo+Pj4+PiAtwqDCoMKgIChndCktPmFyY2gu
c3RhdHVzX2dmbiA9IHhtYWxsb2NfYXJyYXkoZ2ZuX3QsDQo+Pj4+PiBuc2ZfKTvCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIFwNCj4+Pj4+IC3CoMKgwqAgaWYgKCAoZ3QpLT5hcmNo
LnNoYXJlZF9nZm4gJiYgKGd0KS0+YXJjaC5zdGF0dXNfZ2ZuDQo+Pj4+PiApwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgIFwNCj4+Pj4+IC0geyBcDQo+Pj4+PiAtwqDCoMKgwqDCoMKgwqAg
d2hpbGUgKCBuZ2ZfLS0NCj4+Pj4+ICnCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqAgXA0KPj4+Pj4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKGd0KS0+YXJjaC5zaGFyZWRf
Z2ZuW25nZl9dID0NCj4+Pj4+IElOVkFMSURfR0ZOO8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoCBcDQo+Pj4+PiAtwqDCoMKgwqDCoMKgwqAgd2hpbGUgKCBuc2ZfLS0NCj4+Pj4+
ICnCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgXA0KPj4+Pj4gLcKgwqDC
oMKgwqDCoMKgwqDCoMKgwqAgKGd0KS0+YXJjaC5zdGF0dXNfZ2ZuW25zZl9dID0NCj4+Pj4+IElO
VkFMSURfR0ZOO8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBcDQo+Pj4+PiAt
IH0gXA0KPj4+Pj4gLSBlbHNlIFwNCj4+Pj4+IC0gZ250dGFiX2Rlc3Ryb3lfYXJjaChndCk7IFwN
Cj4+Pj4+IC3CoMKgwqAgKGd0KS0+YXJjaC5zaGFyZWRfZ2ZuID8gMCA6DQo+Pj4+PiAtRU5PTUVN
O8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqAgXA0KPj4+Pj4gLX0pDQo+Pj4+PiAtDQo+Pj4+PiAtI2RlZmluZSBnbnR0YWJfZGVz
dHJveV9hcmNoKGd0KSBcDQo+Pj4+PiAtwqDCoMKgIGRvIHsgXA0KPj4+Pj4gLSBYRlJFRSgoZ3Qp
LT5hcmNoLnNoYXJlZF9nZm4pOyBcDQo+Pj4+PiAtIFhGUkVFKChndCktPmFyY2guc3RhdHVzX2dm
bik7IFwNCj4+Pj4+IC3CoMKgwqAgfSB3aGlsZSAoIDAgKQ0KPj4+Pj4gLQ0KPj4+Pj4gICDCoCAj
ZGVmaW5lIGdudHRhYl9zZXRfZnJhbWVfZ2ZuKGd0LCBzdCwgaWR4LCBnZm4sDQo+Pj4+PiBtZm4p
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIFwNCj4+Pj4+ICh7IFwN
Cj4+Pj4+IC3CoMKgwqDCoMKgwqDCoCBpbnQgcmNfID0NCj4+Pj4+IDA7wqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgXA0KPj4+Pj4gICDCoMKgwqDCoMKgwqDC
oMKgwqAgZ2ZuX3Qgb2dmbiA9IGdudHRhYl9nZXRfZnJhbWVfZ2ZuKGd0LCBzdCwNCj4+Pj4+IGlk
eCk7wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBcDQo+Pj4+PiAtwqDCoMKgwqDC
oMKgwqAgaWYgKCBnZm5fZXEob2dmbiwgSU5WQUxJRF9HRk4pIHx8IGdmbl9lcShvZ2ZuLCBnZm4p
DQo+Pj4+PiB8fMKgwqDCoMKgwqDCoMKgwqDCoMKgIFwNCj4+Pj4+IC3CoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqAgKHJjXyA9IGd1ZXN0X3BoeXNtYXBfcmVtb3ZlX3BhZ2UoKGd0KS0+ZG9tYWluLCBv
Z2ZuLA0KPj4+Pj4gbWZuLMKgwqAgXA0KPj4+Pj4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoCAwKSkgPT0gMA0KPj4+Pj4gKcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
IFwNCj4+Pj4+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgICgoc3QpID8NCj4+Pj4+IChndCktPmFy
Y2guc3RhdHVzX2dmbsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgIFwNCj4+Pj4+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgIDogKGd0KS0+YXJjaC5zaGFyZWRfZ2ZuKVtpZHhdID0NCj4+Pj4+IChnZm4pO8KgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIFwNCj4+Pj4+IC0gcmNfOyBcDQo+Pj4+PiArwqDC
oMKgwqDCoMKgwqAgKCFnZm5fZXEob2dmbiwgSU5WQUxJRF9HRk4pICYmICFnZm5fZXEob2dmbiwN
Cj4+Pj4+IGdmbikpwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBcDQo+Pj4+PiArwqDCoMKg
wqDCoMKgwqDCoCA/IGd1ZXN0X3BoeXNtYXBfcmVtb3ZlX3BhZ2UoKGd0KS0+ZG9tYWluLCBvZ2Zu
LCBtZm4sDQo+Pj4+PiAwKcKgwqDCoMKgwqDCoMKgwqAgXA0KPj4+Pj4gK8KgwqDCoMKgwqDCoMKg
wqAgOg0KPj4+Pj4gMDvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgIFwNCj4+Pj4gR2l2ZW4gdGhhdCB3ZSBhcmUgaW1wbGVtZW50aW5n
IHNvbWV0aGluZyBzaW1pbGFyIHRvIGFuIE0yUCwgSSB3YXMNCj4+Pj4gZXhwZWN0aW5nIHRoZSBp
bXBsZW1lbnRhdGlvbiB0byBiZSBwcmV0dHkgbXVjaCB0aGUgc2FtZSBhcyB0aGUgeDg2DQo+Pj4+
IGhlbHBlci4NCj4+Pj4NCj4+Pj4gV291bGQgeW91IGJlIGFibGUgdG8gb3V0bGluZSB3aHkgaXQg
aXMgZGlmZmVyZW50Pw0KPj4+IEJlaW5nIGhvbmVzdCwgSSBkaWRuJ3QgdGhpbmsgYWJvdXQgaXQg
c28gZmFyLsKgIEJ1dCwgSSBhZ3JlZSB3aXRoIHRoZQ0KPj4+IHF1ZXN0aW9uLg0KPj4+DQo+Pj4g
SXQgZmVlbHMgdG8gbWUgdGhhdCBBcm0gdmFyaWFudCBjYW4gbm93IGJlaGF2ZSBhcyB4ODYgb25l
IChhcw0KPj4+IHhlbm1lbV9hZGRfdG9fcGh5c21hcF9vbmUoKSBub3cgY2hlY2tzIGZvciB0aGUg
cHJpb3IgbWFwcGluZyksIEkgbWVhbiB0bw0KPj4+IHVzZSBJTlZBTElEX0dGTiBhcyBhbiBpbmRp
Y2F0aW9uIHRvIHJlbW92ZSBhIHBhZ2UuDQo+Pj4NCj4+PiBXaGF0IGRvIHlvdSB0aGluaz8NCj4+
IEkgd2lsbCBkZWZlciB0aGF0IHRvIEphbi4NCj4+DQo+PiBKYW4sIElJUkMgeW91IHdlcmUgdGhl
IG9uZSBpbnRyb2R1Y2luZyB0aGUgY2FsbCB0bw0KPj4gZ3Vlc3RfcGh5c21hcF9yZW1vdmVfcGFn
ZSgpLiBEbyB5b3UgcmVtZW1iZXIgd2h5IHRoZSBkaWZmZXJlbmNlIGJldHdlZW4NCj4+IHg4NiBh
bmQgQXJtIHdlcmUgbmVjZXNzYXJ5Pw0KPiBUaGUgY29kZSB3YXMgZGlmZmVyZW50IGJlZm9yZSwg
YW5kIEFybSdzIGJlaGF2aW9yIHdhcyBhbHNvIGRpZmZlcmVudC4NCj4gSGVuY2UgdGhlIHR3byBm
dW5jdGlvbnMgY291bGRuJ3QgYmUgcXVpdGUgc2ltaWxhci4gSWYgQXJtIGJlaGF2aW9yIGlzDQo+
IG5vdyBjb252ZXJnaW5nIHdpdGggeDg2J2VzLCB0aGUgZnVuY3Rpb25zIGJlY29taW5nIG1vcmUg
c2ltaWxhciBpcw0KPiBub3QgZW50aXJlbHkgdW5leHBlY3RlZC4NCg0KSWYgQXJtJ3MgZ250dGFi
X3NldF9mcmFtZV9nZm4gYXBwZWFycyB0byBiZSB0aGUgc2ltaWxhciB0byB4ODYncyBvbmUsIA0K
d2hhdCB3b3VsZCBiZSB0aGUgbmV4dCBzdGVwPw0KDQpJIHRob3VnaHQgb2YgdGhlIGZvbGxvd2lu
ZyBvcHRpb25zOg0KDQoxLiBMZWF2ZSBwZXItYXJjaCBoZWxwZXJzIGFzIHRoZXkgYXJlDQoyLiBN
b3ZlIGhlbHBlciB0byB0aGUgY29tbW9uIGdyYW50X3RhYmxlLmgNCjMuIFJlbW92ZSB0aGUgaGVs
cGVycywgY2FsbCBndWVzdF9waHlzbWFwX3JlbW92ZV9wYWdlKCkgZGlyZWN0bHkgZnJvbSANCnRo
ZSBjb21tb24gZ3JhbnRfdGFibGUuYw0KDQoNCj4NCj4+Pj4+IEBAIC0zNTgsNiArMzcxLDI1IEBA
IHZvaWQgY2xlYXJfYW5kX2NsZWFuX3BhZ2Uoc3RydWN0IHBhZ2VfaW5mbyAqcGFnZSk7DQo+Pj4+
PiAgIMKgIMKgIHVuc2lnbmVkIGludCBhcmNoX2dldF9kbWFfYml0c2l6ZSh2b2lkKTsNCj4+Pj4+
ICAgwqAgK3N0YXRpYyBpbmxpbmUgZ2ZuX3QgcGFnZV9nZXRfeGVuaGVhcF9nZm4oY29uc3Qgc3Ry
dWN0IHBhZ2VfaW5mbyAqcCkNCj4+Pj4+ICt7DQo+Pj4+PiArwqDCoMKgIGdmbl90IGdmbl8gPSBf
Z2ZuKHAtPnUuaW51c2UudHlwZV9pbmZvICYgUEdUX2dmbl9tYXNrKTsNCj4+Pj4+ICsNCj4+Pj4+
ICvCoMKgwqAgQVNTRVJUKGlzX3hlbl9oZWFwX3BhZ2UocCkpOw0KPj4+Pj4gKw0KPj4+Pj4gK8Kg
wqDCoCByZXR1cm4gZ2ZuX2VxKGdmbl8sIFBHVF9JTlZBTElEX1hFTkhFQVBfR0ZOKSA/IElOVkFM
SURfR0ZOIDogZ2ZuXzsNCj4+Pj4+ICt9DQo+Pj4+PiArDQo+Pj4+PiArc3RhdGljIGlubGluZSB2
b2lkIHBhZ2Vfc2V0X3hlbmhlYXBfZ2ZuKHN0cnVjdCBwYWdlX2luZm8gKnAsIGdmbl90IGdmbikN
Cj4+Pj4+ICt7DQo+Pj4+PiArwqDCoMKgIGdmbl90IGdmbl8gPSBnZm5fZXEoZ2ZuLCBJTlZBTElE
X0dGTikgPyBQR1RfSU5WQUxJRF9YRU5IRUFQX0dGTg0KPj4+Pj4gOiBnZm47DQo+Pj4+PiArDQo+
Pj4+PiArwqDCoMKgIEFTU0VSVChpc194ZW5faGVhcF9wYWdlKHApKTsNCj4+Pj4+ICsNCj4+Pj4+
ICvCoMKgwqAgcC0+dS5pbnVzZS50eXBlX2luZm8gJj0gflBHVF9nZm5fbWFzazsNCj4+Pj4+ICvC
oMKgwqAgcC0+dS5pbnVzZS50eXBlX2luZm8gfD0gZ2ZuX3goZ2ZuXyk7DQo+Pj4+PiArfQ0KPj4+
PiBUaGlzIGlzIG5vdCBnb2luZyB0byBiZSBhdG9taWMuIFNvIGNhbiB5b3Ugb3V0bGluZSB3aGlj
aCBsb2NraW5nDQo+Pj4+IG1lY2hhbmlzbSBzaG91bGQgYmUgdXNlZCB0byBwcm90ZWN0IGFjY2Vz
cyAoc2V0L2dldCkgdG8gdGhlIEdGTj8NCj4+Pg0KPj4+IEkgdGhpbmssIHRoZSBQMk0gbG9jay4N
Cj4+IE9rLiBTbywgbG9va2luZyBhdCB0aGUgY29kZSwgbW9zdCBvZiBjYWxscyB0byBwYWdlX2dl
dF94ZW5oZWFwX2dmbigpIGFyZQ0KPj4gbm90IHByb3RlY3RlZCB3aXRoIHRoZSBwMm1fbG9jaygp
Lg0KPj4NCj4+IChKYW4gcGxlYXNlIGNvbmZpcm0pIElmIEkgYW0gbm90IG1pc3Rha2VuLCBvbiB4
ODYsIGEgcmVhZCB0byB0aGUgTTJQIGlzDQo+PiBub3QgYWx3YXlzIHByb3RlY3RlZC4gQnV0IHRo
ZXkgaGF2ZSBjb2RlIHdpdGhpbiB0aGUgUDJNIGxvY2sgdG8gY2hlY2sNCj4+IGFueSBkaWZmZXJl
bmNlIChzZWUgcDJtX3JlbW92ZV9wYWdlKCkpLiBJIHRoaW5rIHdlIHdvdWxkIG5lZWQgdGhlIHNh
bWUsDQo+PiBzbyB3ZSBkb24ndCBlbmQgdXAgdG8gaW50cm9kdWNlIGEgYmVoYXZpb3Igc2ltaWxh
ciB0byB3aGF0IFhTQS0zODcgaGFzDQo+PiBmaXhlZCBvbiB4ODYuDQo+IFllcywgdGhpcyBtYXRj
aGVzIG15IHVuZGVyc3RhbmRpbmcuDQo+DQo+IEphbg0KPg0KLS0gDQpSZWdhcmRzLA0KDQpPbGVr
c2FuZHIgVHlzaGNoZW5rbw0K


From xen-devel-bounces@lists.xenproject.org Wed Feb 09 10:20:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 09 Feb 2022 10:20:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268923.462834 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHk5h-0002FO-SM; Wed, 09 Feb 2022 10:20:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268923.462834; Wed, 09 Feb 2022 10:20:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHk5h-0002FH-PD; Wed, 09 Feb 2022 10:20:49 +0000
Received: by outflank-mailman (input) for mailman id 268923;
 Wed, 09 Feb 2022 10:20:48 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=4iPq=SY=epam.com=prvs=403937cc0f=oleksii_moisieiev@srs-se1.protection.inumbo.net>)
 id 1nHk5g-0002FB-PT
 for xen-devel@lists.xenproject.org; Wed, 09 Feb 2022 10:20:48 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f17075a5-8991-11ec-8f75-fffcc8bd4f1a;
 Wed, 09 Feb 2022 11:20:46 +0100 (CET)
Received: from pps.filterd (m0174677.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 219AFSlL027144;
 Wed, 9 Feb 2022 10:20:43 GMT
Received: from eur03-ve1-obe.outbound.protection.outlook.com
 (mail-ve1eur03lp2051.outbound.protection.outlook.com [104.47.9.51])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e4bpt00s6-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 09 Feb 2022 10:20:43 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com (2603:10a6:102:ea::23)
 by DB9PR03MB7291.eurprd03.prod.outlook.com (2603:10a6:10:221::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Wed, 9 Feb
 2022 10:20:38 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::c1c:f98:9dd:86e0]) by PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::c1c:f98:9dd:86e0%6]) with mapi id 15.20.4975.011; Wed, 9 Feb 2022
 10:20:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f17075a5-8991-11ec-8f75-fffcc8bd4f1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=WyPVVPfboBBS6PjiiOO4JxbmvtIuUPLonLHglvMtJqCW1U0Hp4kLMpXm1cvok7p258O1GA1gEQc4bLhs2luYVhY4A5UqyyJzMiEurYlRPIgBDgYTQowfLK/csUfR9ZSsKDkZSDrBCZ2xUpeWlycbmFekAB0RVSMTFCHuXHtEG6CK+h3ItCE47Fjpl986yq0Xrv9HflxZJzuBR0R5PI5QXDQ8JhJ/iNkpGqjvwoMZzWcZQjeJIg46KWypP0NGid/zuzv6/0DHJUlHheGN4vWZqm3AznJN7mL6qLtnoezb53l6TYWV9N1noWYTVF9w+GcyQ8h1QF0kO+Q0IOKPCdoYiA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=zgXPjBiGwaJIK/z8yCxnzELuL+zHuRsre0yutMwKAlw=;
 b=Nh/Fv2jUtHu8kCUArV6jWqm6sAdc7gLDfdubKdsquOOeC7L929FjxefjYjyaGJeo/EqnjBClA1IOKhXSIixZrc6XU6ijtKL8fiUwbmj292EoN7bNEzvX9fuezpSwTThPf2PpmuZ8Pza86nxXKC/gwxIjALMVyiAW+LDMh1/hc+r0CnqJ+BxOHI2rvXDH0QC1GOs8Vb9NIrpn9KAtvEGoS1Y7a3vZRs3kcwnG2uBKsUT9Wd+Jpo62XhXR2L4DFCxsMjbWzGonrH57fEca9IuaUM/l5jcUuM0Uje9S64JxdlDDJs6Y4yVTyCrNEfsgtJZxS6MYy/W2TxSoLulMgUZ9mA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=zgXPjBiGwaJIK/z8yCxnzELuL+zHuRsre0yutMwKAlw=;
 b=rSqdyA0iVnTJ+49LQKFog4qGwq4IkfWbYHlyJ8F/ES7yys6Z5W0j5RJqXpWT5/zuMWxmPC8uNI4K0q4F8E276V5skybHf1TDJ/gN7u+GaZTYFkkPtyyIAfPtwWjjqfZ59gNdPR1GGVAyh2nftsUOASj0zQvr3R/kiyCEWYGgzHijokPnH1QN8k2+FkHDr3t17FeTQInBPcomNN6nQ00WeewsC1NGZWfwjVWqGTHnnXeFcHeUtqIKzvMDSJJWF2YVLF0cYLCveDRkqjrrkBobjxc0XQQpDcsbzqN3TQrFGCXorIlpCT7OaetmdKf4ZUQn5K0DdFITUUSXaWyV3TLM7A==
From: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
To: Julien Grall <julien@xen.org>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        Stefano
 Stabellini <sstabellini@kernel.org>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Juergen Gross <jgross@suse.com>
Subject: Re: [RFC v2 3/8] xen/arm: Export host device-tree to hypfs
Thread-Topic: [RFC v2 3/8] xen/arm: Export host device-tree to hypfs
Thread-Index: AQHYHRW1S717SraA0Ui+K6wc2/TNAKyJ+LkAgAEKd4A=
Date: Wed, 9 Feb 2022 10:20:38 +0000
Message-ID: <20220209102037.GA1025795@EPUAKYIW015D>
References: <cover.1644341635.git.oleksii_moisieiev@epam.com>
 <e440e4f16a506ecc87078635dbb3fda2ebd45346.1644341635.git.oleksii_moisieiev@epam.com>
 <b88f6a50-6e9e-5679-8d25-89e26031e88e@xen.org>
In-Reply-To: <b88f6a50-6e9e-5679-8d25-89e26031e88e@xen.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 4eaed1fa-9802-4c6c-cf40-08d9ebb5d19b
x-ms-traffictypediagnostic: DB9PR03MB7291:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <DB9PR03MB729144C9F0984380F7901913E32E9@DB9PR03MB7291.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 X5TR0JoT4kXD5iSuktPwRwvEbxGqqWLX3iuVvvmceIOXjpo09hu5ARCM+hVmuPnLlOh9bHIrInJuw5fusotH1igN7BDPpG0TV/BYQD4XIoscHIvAA3HfJLuako4gH5eHidkHd77HCSm7+9UPNqrKuscbnIRWaXwUhgtzVqwomj4XXnCJpIY5bB+oIFhEzT7Ut0LCvy3LJi/keYaI/DoD9GdLDuLOE6VFh9Le5+nf7oovjQgJlXyaid7wtoaFajYRiBvOLE2eHkuCDY2CmIwn4cSsJHejjIlVOlK9AwOUsX6t4WtG/4JGy7KbA4uS0p6pX/adCNorpsYx6iTdCZ+/SBHBEbBFpVoid9/9XSQjXMnbYPAeSyiiFU8ArwPiUVVcH+S9nh07Eb03KZGPMQUCvugSmVC25qvAotniYjRVVHwaaLiWehAohmjWIOwRwROg1amgh2MDrimV+Rwqcv5FGIuwIbmsSGqhXBiN/w61NMOHfGydIMntTWPpNLodNe/HeYbkpGrUkJEiXo6ovlQZjef5ZMxqE677VM1KwZq9q0YieAH1G+Oz3WU+EVgVVHV+mI1Xepo50YCBTbkiVpcSD/O/IwQvjQFJKmdfxFYsLgwASAFgfhh8feRrC1lA2DtiwXCtetRIdOtS9+79JeR5hM2ErQHqhh0taSc9jWtZJHVQWvJG00UHHDXIKmBDjcjZuxNp1hJXRAl4TsKUb+wSes7Oix1Dy3bwjECdqPleY08=
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR03MB7136.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(508600001)(122000001)(316002)(6916009)(76116006)(38100700002)(9686003)(26005)(33716001)(83380400001)(5660300002)(33656002)(6486002)(86362001)(8936002)(8676002)(54906003)(66946007)(38070700005)(66476007)(66446008)(66556008)(4326008)(2906002)(64756008)(53546011)(186003)(91956017)(1076003)(71200400001)(6506007)(6512007)(2004002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?VNIpnouWfwNrzM6V2SiXBfd0kGofx5lRSem6IpfZIOMXXoRI13lVcNwgZLHp?=
 =?us-ascii?Q?ZXAnexZJmBubNoUG+cdNxIQBCoyVPkFcPRORrRKl77WJtIXrbf8qaIviHabs?=
 =?us-ascii?Q?vdOdYnBrswlpoU+7XCfScVduHXlxXOVC26DCZXcvbV+BG+QGcBhuTh8po12e?=
 =?us-ascii?Q?x+n8ouRuetGvbpWY9SvU1Eh23g6WE9DmvndGkH/Wq9gr3iNN2Ucr2NfXAhzn?=
 =?us-ascii?Q?ytgYMaeRDQs9y8grUCuIRC3LDvL8OjwfILnxzBK/CoWU+7c0RrqyvyA8wiHh?=
 =?us-ascii?Q?niiWd5+rlWmg1V5O+A9wd7P+VN+LGUSV021nHCRNmNKGmHZ1aMrLRE3wee6J?=
 =?us-ascii?Q?J9q87TeuRL1o8amQU/xLMpKHVRV6YHkgGZyO2CjP7JDkAR5kon7gc6pl/aEL?=
 =?us-ascii?Q?Ri3n5Bscq8VaiLzrO8nN6s3QejyP2Y/sMPf3Z2bUCDWQ0oXnF7iJIoVaWH7h?=
 =?us-ascii?Q?3Y7SLj8794NkVB4e6dow8+TVAGbkFYOxb1Bj90F3Xsuo08k/2ifO3bzD5b68?=
 =?us-ascii?Q?tF1MTlN8EeXsqeWlSUKWd9CdMGv/GhXz0k0s/4redCsDJPgnrQUkg9Ktr+pM?=
 =?us-ascii?Q?i1dm27pLfOWRksqJAn0an55BRCiXP6f9JnuhVkY2YvaToGKJmvceFZQnrsr8?=
 =?us-ascii?Q?sNmgrgKuiNZgZ3+1hZuYBWLeUE0IfD1qT8iDksgWXBGazZDxspwlRWfAVLd8?=
 =?us-ascii?Q?mOE89ywyrVXP7Ga4JGdLlgsdJZFgNN9zoJWLWOX0jVAOhF7jw/UbZi3UaF9c?=
 =?us-ascii?Q?dNzCpILWN00AqJFnAgik7i9hZrGveGKzesJQnffcvNzj6Fhn+DY9Xdf7gA8M?=
 =?us-ascii?Q?xaPPepIE3WnvOKO+StfUf1kmcFU/LSxniLDdzRakSfuMecAOiMl9K4B2Jo7M?=
 =?us-ascii?Q?OoVjA+vY1zxdnb229GY/tnQMKYB8fJ8riXaOo6meRuraa26rIpkTAm0+c1Ua?=
 =?us-ascii?Q?NZYQeOfQ77C7iA/uKqWq4rvYhMyuRYYsa82Euc5sfDr7NTpwU9ywLCgMStbS?=
 =?us-ascii?Q?R0rJDe3r5g6uRmSYsPl6LzcJSkouFRtMK20sip1ocK8JSdHdaZRBXKJHiYNZ?=
 =?us-ascii?Q?HAIhseZTK9JI3PAMIYCMdsDumwj01Cw6dwGdmuFNbglX/t0Ow4XOLjWmbOfX?=
 =?us-ascii?Q?qeWj+hZiSuc37khEtYQSDNmW28a3An1p1MUInczhZM6C05vxqtwrvFiL/45P?=
 =?us-ascii?Q?pyn2wkRud9TsrnJguPiEnwKoV0UnAcEMlQIZWfTcmHpOJaXmhAxyLfnGyt/x?=
 =?us-ascii?Q?jEWl9Z4CpWnFZ1JLPj88NzZVWyQa9sUF9t5lqCcqct0qanG22MUHvk5JfblA?=
 =?us-ascii?Q?R8r3J2f+bA2srR0aDVrPIVk9ttcJ1k3NGk3zfusdeWBhF5/K8ySIXoD/Zo3Z?=
 =?us-ascii?Q?KvUBZEDgvQC2rFE2+GyPSf21OicH4fj+d2idqDDMSZ+H2QfXCZ3Jghf3KC+v?=
 =?us-ascii?Q?Fc3F5FmlMTAxOEDmTNdETQ+ESA2rOngxCAsaEhXnRRQ63/5429Z8jPITcgar?=
 =?us-ascii?Q?e0vhVDipTpsYIOwR5EKMcfNG45OOmxOUAH2KG3GAfFa1Ej7/5THXA/TMd96r?=
 =?us-ascii?Q?EyugxK398R2PRQM5Ba9XPKSE/3DN1xJuNgdfQNL1oGEbpT8jhxQX/Fblpv+T?=
 =?us-ascii?Q?lbp/6ejmjJPRX66sMsUxKVaQZ0MkZm2sgMXXTPM/xbhSvPRCxzRvolZtqLEv?=
 =?us-ascii?Q?I22342I0P6EnqGr1LPjpGlDObvE=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <8906586B46A06B4083F14DA312E54ADE@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR03MB7136.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4eaed1fa-9802-4c6c-cf40-08d9ebb5d19b
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Feb 2022 10:20:38.7111
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 6Y1VDkxZUtgpgSz04YagkSZZQUNF9ic5zETg2QXL3C66USD6xKj9O1m3aWoygyLZGP+uqeH62MptOD+ddoTkEnQwPhiBKHmn5jbTNMHLeko=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR03MB7291
X-Proofpoint-GUID: FvRuTa8PDYmRXcljWbsyNsBHCpFDsb0G
X-Proofpoint-ORIG-GUID: FvRuTa8PDYmRXcljWbsyNsBHCpFDsb0G
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-09_05,2022-02-09_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0
 mlxlogscore=999 impostorscore=0 spamscore=0 adultscore=0 clxscore=1015
 mlxscore=0 priorityscore=1501 bulkscore=0 phishscore=0 lowpriorityscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202090066

Hi Julien,

On Tue, Feb 08, 2022 at 06:26:54PM +0000, Julien Grall wrote:
> Hi Oleksii,
>=20
> On 08/02/2022 18:00, Oleksii Moisieiev wrote:
> > If enabled, host device-tree will be exported to hypfs and can be
> > accessed through /devicetree path.
> > Exported device-tree has the same format, as the device-tree
> > exported to the sysfs by the Linux kernel.
> > This is useful when XEN toolstack needs an access to the host device-tr=
ee.
> >=20
> > Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@epam.com>
> > ---
> >   xen/arch/arm/Kconfig           |   8 +
> >   xen/arch/arm/Makefile          |   1 +
> >   xen/arch/arm/host_dtb_export.c | 307 ++++++++++++++++++++++++++++++++=
+
>=20
> There is nothing specific in this file. So can this be moved in common/?

You're right. I will move it to common.

>=20
> >   3 files changed, 316 insertions(+)
> >   create mode 100644 xen/arch/arm/host_dtb_export.c
> >=20
> > diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
> > index ecfa6822e4..895016b21e 100644
> > --- a/xen/arch/arm/Kconfig
> > +++ b/xen/arch/arm/Kconfig
> > @@ -33,6 +33,14 @@ config ACPI
> >   	  Advanced Configuration and Power Interface (ACPI) support for Xen =
is
> >   	  an alternative to device tree on ARM64.
> > +config HOST_DTB_EXPORT
> > +	bool "Export host device tree to hypfs if enabled"
> > +	depends on ARM && HYPFS && !ACPI
>=20
> A Xen built with ACPI enabled will still be able to boot on a host using
> Device-Tree. So I don't think should depend on ACPI.
>=20
> Also, I think this should depend on HAS_DEVICE_TREE rather than ARM.

I agree. Thank you.

>=20
> > +	---help---
> > +
> > +	  Export host device-tree to hypfs so toolstack can have an access fo=
r the
> > +	  host device tree from Dom0. If you unsure say N.
> > +
> >   config GICV3
> >   	bool "GICv3 driver"
> >   	depends on ARM_64 && !NEW_VGIC
> > diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile
> > index 07f634508e..0a41f68f8c 100644
> > --- a/xen/arch/arm/Makefile
> > +++ b/xen/arch/arm/Makefile
> > @@ -8,6 +8,7 @@ obj-y +=3D platforms/
> >   endif
> >   obj-$(CONFIG_TEE) +=3D tee/
> >   obj-$(CONFIG_HAS_VPCI) +=3D vpci.o
> > +obj-$(CONFIG_HOST_DTB_EXPORT) +=3D host_dtb_export.o
> >   obj-$(CONFIG_HAS_ALTERNATIVE) +=3D alternative.o
> >   obj-y +=3D bootfdt.init.o
> > diff --git a/xen/arch/arm/host_dtb_export.c b/xen/arch/arm/host_dtb_exp=
ort.c
> > new file mode 100644
> > index 0000000000..794395683c
> > --- /dev/null
> > +++ b/xen/arch/arm/host_dtb_export.c
>=20
> This is mostly hypfs related. So CCing Juergen for his input on the code.

Thank you.

>=20
> > @@ -0,0 +1,307 @@
> > +/*
> > + * xen/arch/arm/host_dtb_export.c
> > + *
> > + * Export host device-tree to the hypfs so toolstack can access
> > + * host device-tree from Dom0
> > + *
> > + * Oleksii Moisieiev <oleksii_moisieiev@epam.com>
> > + * Copyright (C) 2021, EPAM Systems.
> > + *
> > + * This program is free software; you can redistribute it and/or modif=
y
> > + * it under the terms of the GNU General Public License as published b=
y
> > + * the Free Software Foundation; either version 2 of the License, or
> > + * (at your option) any later version.
> > + *
> > + * This program is distributed in the hope that it will be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > + * GNU General Public License for more details.
> > + */
> > +
> > +#include <xen/device_tree.h>
> > +#include <xen/err.h>
> > +#include <xen/guest_access.h>
> > +#include <xen/hypfs.h>
> > +#include <xen/init.h>
> > +
> > +#define HOST_DT_DIR "devicetree"
> > +
> > +static int host_dt_dir_read(const struct hypfs_entry *entry,
> > +                            XEN_GUEST_HANDLE_PARAM(void) uaddr);
> > +static unsigned int host_dt_dir_getsize(const struct hypfs_entry *entr=
y);
> > +
> > +static const struct hypfs_entry *host_dt_dir_enter(
> > +    const struct hypfs_entry *entry);
> > +static void host_dt_dir_exit(const struct hypfs_entry *entry);
> > +
> > +static struct hypfs_entry *host_dt_dir_findentry(
> > +    const struct hypfs_entry_dir *dir, const char *name, unsigned int =
name_len);
>=20
> This is new code. So can you please make sure to avoid forward declaratio=
n
> by re-ordering the code.
>=20

I can't avoid forward declaration here because all those functions
should be passed as callbacks for node template dt_dir. And dt_dir is
used in read and findentry functions.

>=20
> [...]
>=20
> > +static char *get_root_from_path(const char *path, char *name)
> > +{
> > +    const char *nm =3D strchr(path, '/');
> > +    if ( !nm )
> > +        nm =3D path + strlen(path);
> > +    else
> > +    {
> > +        if ( !*nm )
> > +            nm--;
> > +    }
> > +
> > +    return memcpy(name, path, nm - path);
>=20
> What does guaranteee that name will be big enough for the new value?

I will refactor that.

>=20
> > +}
> > +
> > +static int host_dt_dir_read(const struct hypfs_entry *entry,
> > +                            XEN_GUEST_HANDLE_PARAM(void) uaddr)
> > +{
> > +    int ret =3D 0;
> > +    struct dt_device_node *node;
> > +    struct dt_device_node *child;
>=20
> The hypfs should not modify the device-tree. So can this be const?

That's a good point.
Unfortunatelly child can't be const because it is going to be passed to
data->data pointer, but node can be const I think. In any case I will go
through the file and see where const for the device_node can be set.

>=20
> > +    const struct dt_property *prop;
> > +    struct hypfs_dyndir_id *data;
> > +
> > +    data =3D hypfs_get_dyndata();
> > +    if ( !data )
> > +        return -EINVAL;
>=20
> [...]
>=20
> > +static struct hypfs_entry *host_dt_dir_findentry(
> > +    const struct hypfs_entry_dir *dir, const char *name, unsigned int =
name_len)
> > +{
> > +    struct dt_device_node *node;
> > +    char root_name[HYPFS_DYNDIR_ID_NAMELEN];
> > +    struct dt_device_node *child;
> > +    struct hypfs_dyndir_id *data;
> > +    struct dt_property *prop;
> > +
> > +    data =3D hypfs_get_dyndata();
> > +    if ( !data )
> > +        return ERR_PTR(-EINVAL);
> > +
> > +    node =3D data->data;
> > +    if ( !node )
> > +        return ERR_PTR(-EINVAL);
> > +
> > +    memset(root_name, 0, sizeof(root_name));
> > +    get_root_from_path(name, root_name);
> > +
> > +    for ( child =3D node->child; child !=3D NULL; child =3D child->sib=
ling )
> > +    {
> > +        if ( strcmp(get_name_from_path(child->full_name), root_name) =
=3D=3D 0 )
> > +            return hypfs_gen_dyndir_entry(&dt_dir.e,
> > +                                  get_name_from_path(child->full_name)=
, child);
> > +    }
> > +
> > +    dt_for_each_property_node( node, prop )
> > +    {
> > +
> > +        if ( dt_property_name_is_equal(prop, root_name) )
> > +            return hypfs_gen_dyndir_entry(&dt_prop.e, prop->name, prop=
);
> > +    }
> > +
> > +    return ERR_PTR(-ENOENT);
>=20
> [...]
>=20
> > +static HYPFS_DIR_INIT_FUNC(host_dt_dir, HOST_DT_DIR, &host_dt_dir_func=
s);
> > +
> > +static int __init host_dtb_export_init(void)
> > +{
> > +    ASSERT(dt_host && (dt_host->sibling =3D=3D NULL));
>=20
> dt_host can be NULL when booting on ACPI platform. So I think this wants =
to
> be turned to a normal check and return directly.
>=20

I will replace if with
if ( !acpi_disabled )
    return -ENODEV;

> Also could you explain why you need to check dt_host->sibling?
>=20

This is my way to check if dt_host points to the top of the device-tree.
In any case I will replace it with !acpi_disabled as I mentioned
earlier.

Best regards,
Oleksii=


From xen-devel-bounces@lists.xenproject.org Wed Feb 09 10:32:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 09 Feb 2022 10:32:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268931.462846 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHkGv-0003jx-W7; Wed, 09 Feb 2022 10:32:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268931.462846; Wed, 09 Feb 2022 10:32:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHkGv-0003jq-SZ; Wed, 09 Feb 2022 10:32:25 +0000
Received: by outflank-mailman (input) for mailman id 268931;
 Wed, 09 Feb 2022 10:32:25 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=H3wK=SY=citrix.com=Jane.Malalane@srs-se1.protection.inumbo.net>)
 id 1nHkGu-0003jk-Vx
 for xen-devel@lists.xenproject.org; Wed, 09 Feb 2022 10:32:24 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9031b94a-8993-11ec-8eb8-a37418f5ba1a;
 Wed, 09 Feb 2022 11:32:23 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9031b94a-8993-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644402743;
  h=from:to:cc:subject:date:message-id:mime-version:
   content-transfer-encoding;
  bh=Xe48OLJEzVvDgJU/2gVRWOn4OapFjAORQH921im2/PE=;
  b=LStaC+JelHyd8X7/N9slunKxptV8/q8fWxNXZRyn0ne14K4Fsxl+WIwI
   EOYnz//lsHc3yZPEUGPXnWwdUvL5vPkP8nfIOiCX+ZrV99uMlEfafI5ga
   zTrz9hMGOgmQSFggO9iKrN3exzOuuOluhooHQgdpjO2iJ/fAUTcqkB7wV
   M=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: lBHmDgiVB1Ieyi7rxBI7plIRkJTU8z29Hv+b959uLL5oxsdI8G7bSH0Y5Mowk7aQkcNTERaAs1
 TTqIJSu6zCtyooT+Pq7Z8kpxUiT9lbDdfi6WeZWsJY/W5IYrlznYAaCwAbexOXU/Zk7sOtxZkW
 Q4Oiqg4cJ0b3cdYULYUUpOB4eXKOVQeFzjC2LE84vbKemFJTsLrdAZVthCL93Ahet7xYxzVFDZ
 CxcBHHZx0848ZAJUXUieuPfDHrz1WBtM97DD0aYimNRPooOD7rYeF0iUtVyRKbe/b8CLYJJwA9
 GPjMjivRH7zE8obp+DrRaTO/
X-SBRS: 5.1
X-MesageID: 63817220
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:aQZ1waBnfhMwdRVW//zkw5YqxClBgxIJ4kV8jS/XYbTApG8h1zUFn
 2YaCm/XaaneamH2ft9/b4i/9k8C7JDQy4dmQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMo/u1Si6FatANl1ElvU2zbue6WL6s1hxZH1c+En970UM7wobVv6Yz6TSHK1LV0
 T/Ni5W31G+Ng1aY5UpNtspvADs21BjDkGtwUm4WPJinj3eH/5UhN7oNJLnZEpfNatI88thW5
 Qr05OrREmvxp3/BAz4++1rxWhVirrX6ZWBihpfKMkQLb9crSiEai84G2PQghUh/iCWonfpt7
 8l0tLeycSguN46Rlv0RekwNe81+FfUuFL7vJHG+tYqYzlHccmuqyPJrZK00FdRGoKAtWzgIr
 KFGbmBWBvyAr7veLLaTaOBqi4IGJc3iOIoZt1lrzC3DDOZgSpfGK0nPzYEDjG5v3JoWdRrYT
 8Y8VwowVQTlWUwRYncNDLEQvumUvnaqJlW0r3rK/PFqsgA/1jdZz7zFINfTPNuQSq19nEyVu
 2bH9GTRGQwBOZqUzj/t2mKhgKrDkD32XKoWFaak7bh6jVuL3GsRBRYKE1yhrpGEZlWWAowFb
 RZOo2x38PZ0pBfDosTBswOQo26lvDQAfMZpEsY40C6Kw4mJ7R+VLz1RJtJeU+AOuMgzTD0s8
 1aGmdL1GDBi2IGopWKhGqS89m3rZ3VMRYMWTWpdFFZevYG/yG0mpk+XFr5e/LiJYsoZ8N0a6
 xSDt2AAiroalqbnPI3rrAmc01pASnUkJzPZBzk7vEr4t2uVh6b/PuREDGQ3C94ace51qXHb4
 xA5dzC2trxmMH10vHXlrB8xNL+o/e2ZFzbXnERiGZIsnxz0pSL/JtwNvGAndB40WirhRdMPS
 BWO0e+2zMUMVEZGkIctO97hYyjU5fSI+SvZugD8MYMVP8kZmP6v9yByf0+At10BY2B3+ZzTz
 ayzKJ72ZV5DUPwP5GPvG481jO96rghjlDi7bc2qkHyPj+HEDFbLEuhtDbd7Rr1ghE9yiF6Oq
 Ig32grj40g3bdASlQGNqdFKdg1RfSFgbX00wuQOHtO+zsNdMDlJI5fsLXkJJeSJRoxZybXF+
 G+TQEhdxAatjHHLM1zSOHtidKnuTdB0qndiZX4gOlOh2n4CZ4ez7fhAK8trLOd/rOEzn+RpS
 /QletmbBqgdQDrw5DlAP4L2q5ZvdUr3iFvWbTalejU2Y7VpWxfNpo3/ZgLq+SRXVni3uMIyr
 qeOzATeRZZfFQ1uANyPMKCkzk+rvGhbk+V3BhOaLt5WcUTq0Y5rNy2u0aNnf5BScU3On2LI2
 RyXDBEUofj2j7U0qNSZ17qZq4qJEvdlGhYIFWfs8rvrZzLR+XCuwNEcXb/QLyzdTm795I6re
 f5Rk6PnKPQCkVtH79h8HrJswf5s7tfjveYHnAFtHXGNZFW3ELJwZHKB2JAX5KFKw7ZYvyqwW
 16OpYYGaenYZpu9HQ5DPhchY8SCyeoQy2vb4vkCKUnn4DN6oeicWkJIMhjQ0CFQIdOZ6m/+L
 TvNbCLO1zGCtw==
IronPort-HdrOrdr: A9a23:d4ESZqvxafFHrw3I/VajAIMq7skDetV00zEX/kB9WHVpmszxra
 6TdZMgpHjJYVcqKRUdcL+7WJVoLUmxyXcX2/h1AV7BZniEhILAFugLhuGO/9SJIVyZygc378
 ZdmsZFZ+EYdWIK7/rH3A==
X-IronPort-AV: E=Sophos;i="5.88,355,1635220800"; 
   d="scan'208";a="63817220"
From: Jane Malalane <jane.malalane@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Jane Malalane <jane.malalane@citrix.com>, Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>, Wei Liu
	<wl@xen.org>
Subject: [PATCH] x86/dom0: Add log for dom0_nodes and dom0_max_vcpus_max conflict
Date: Wed, 9 Feb 2022 10:31:53 +0000
Message-ID: <20220209103153.11391-1-jane.malalane@citrix.com>
X-Mailer: git-send-email 2.11.0
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

This is not a bug. The xen cmdline can request both a NUMA restriction
and a vcpu count restriction for Dom0. The node restriction wil always
be respected which might mean either using dom0_max_vcpus <
opt_dom0_max_vcpus_max or using more vCPUs than pCPUs on a node. In
the case where dom0_max_vcpus gets capped at the maximum number of
pCPUs for the number of nodes chosen, it can be useful particularly
for debugging to print a message in the serial log.

Suggested-by: Edwin Torok <edvin.torok@citrix.com>
Signed-off-by: Jane Malalane <jane.malalane@citrix.com>
---
CC: Jan Beulich <jbeulich@suse.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
CC: "Roger Pau Monné" <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>
---
 xen/arch/x86/dom0_build.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/xen/arch/x86/dom0_build.c b/xen/arch/x86/dom0_build.c
index fe24e11b37..e57cc80ef0 100644
--- a/xen/arch/x86/dom0_build.c
+++ b/xen/arch/x86/dom0_build.c
@@ -240,6 +240,11 @@ unsigned int __init dom0_max_vcpus(void)
     if ( max_vcpus > limit )
         max_vcpus = limit;
 
+    if ( max_vcpus < opt_dom0_max_vcpus_max && max_vcpus > opt_dom0_max_vcpus_min )
+        printk(XENLOG_INFO "Dom0 using %d vCPUs conflicts with request to use"
+               " %d node(s), using up to %d vCPUs\n", opt_dom0_max_vcpus_max,
+               dom0_nr_pxms, max_vcpus);
+
     return max_vcpus;
 }
 
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Wed Feb 09 10:40:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 09 Feb 2022 10:40:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268939.462857 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHkOZ-0005AL-Qh; Wed, 09 Feb 2022 10:40:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268939.462857; Wed, 09 Feb 2022 10:40:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHkOZ-0005AE-MI; Wed, 09 Feb 2022 10:40:19 +0000
Received: by outflank-mailman (input) for mailman id 268939;
 Wed, 09 Feb 2022 10:40:17 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=H3wK=SY=citrix.com=Jane.Malalane@srs-se1.protection.inumbo.net>)
 id 1nHkOX-0005A8-OQ
 for xen-devel@lists.xenproject.org; Wed, 09 Feb 2022 10:40:17 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id aa3a5dc9-8994-11ec-8f75-fffcc8bd4f1a;
 Wed, 09 Feb 2022 11:40:16 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: aa3a5dc9-8994-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644403216;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=awSpnk9KzfJE1f7cDS5tVTLb/jHKmp11yzJIZm63+E8=;
  b=KF6qa4AEpAO/1lGNDecwJrFZGcl4g9iAG0xLkeAvtx1ersFkTOc2ged3
   0Uwdt5kvzaj4AO1kWKp5xtZP34TSR3VEE3UhZf4jRdNMaLpp/UL/tvwNn
   P8Zq2TAioWWfgLhluIKCkBBeR/9UTPlNK0ygTpoiaRiWyINt3Hk/5Aiss
   E=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: fkVgD6dN7PfKRx9cNiNxtFaz/vtPZJm0bPfE00Axrx0T+2YcPh3Nh/WQTU6jhS+VIXfWguAGmL
 lCC85XgCpsmgd4fDTCGNeg0fZdmqMc/km/FZw73wbVD840+kRKeo3qO8SBLWlJ8sc7G708BLIY
 +TVdYmIau1LhMVEdmpAVFFIimTOu+bVLGHL7gFDVWR/eZE6kpwXdPmkmf6QR/SMhNB9LAKt259
 DscpE/P4lGYFEFHyj89piceluNEpRqVSqcwws9+xyAdSwCogevkPctxaseJ7fWnuyPYYKc1QlC
 pilGVrV7YVLk3HYJzFZM1rhl
X-SBRS: 5.1
X-MesageID: 63817683
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:VdGiNqhemN/6sGThMaVK0V1UX161ghcKZh0ujC45NGQN5FlHY01je
 htvDz2PO6vbZDD8eIxxO9izpkkGvJHWzoA1TVFupHhnQiwb9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oAMKRCQ7InQLlbGILes1htZGEk0GE/NtTo5w7Rj2tQw0IDga++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /1LqZyWTC0bBJbK2/VaYUNgFzF/N5BJreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHJNYUS/FRpyTjdBPAraZvCX7/L9ZlT2zJYasVmQ62OP
 pVHOWEHgBLoX0RPfX0dF7UEgcChp2n4LCdgpEuxjP9ii4TU5FMoi+W8WDbPQfSVQe1Fk0Deo
 XjJl0z7CBwHMN2UyRKe72mhwOTImEvTSI8UUbG16PNuqFmS3XAITg0bU0Ohpvu0gVL4XMhQQ
 3H44QJ38/J0rhbyCICgAVvo+xZooyLwRfJWD+0c7Su/8JHSoBfeNDI8Si5AYuEp4ZpeqSMR6
 neFmNbgBDpKubKTSG6A+rr8kQ5eKRT5PkdZO3ZaEFJtD83L5dhq00mRFooL/Lud04WtcQwc1
 Qxmu8TXa187qccQn5u28lnc695HjsiYF1Vljuk7s4/M0++YWGJHT9HxgbQ4xawZRGp8crVnl
 CJZ8yR5xLpRZaxhbATXHI0w8EiBvp5pygH0j191BIUG/D+w4XOldo04yGggeBsybptYKGa5O
 RK7VeZtCHl7ZibCgUhfOd3ZNijX5fK4SYSNug78MrKinaSdhCfYpXozNCZ8LkjmkVQ2kLFXB
 HtoWZ3EMJruMow+lGDeb75EidcDn3lirUuOFcGT50n2itK2OS/KIZ9bawHmRr5is8u5TPD9r
 o832z2ikE4EDoUTo0D/rOYuELz9BSJjWsmt9pcHL7Xrz8gPMDhJNsI9CIgJIuRNt69Uiv3J7
 je6XEpZw0D4nnrJNUOBbXULVV8ldc8XQasTMXN+MFC29WIkZIrzvq4Te4FuJess9fB5zO4yR
 P4AIp3SDvNKQzXB2jIccZii89AyKEX13VqDb3i/fTwyX598XAiVqNXqSRTiqXsVBS2tuMpg/
 7D5jlHHQYAOThhJBdrNbK791Eu4uHUQwbogX0bBLtRJVl/r9Yxmd374gvMtepleIhTf3DqKk
 Q2RBE5A9+XKpoY09vjPhLyF8Nj1Q7cvQBICEjCCv7isNCTc8m6y+qN6Ub6FLWLHSWf52KS+f
 uEJnfvyB+IKwQRRuI1mHrc1ka9nv4nzp6VXxxhPFWnQawj5EatpJ3SL0JUdtqBJwbMF6wK6V
 ljWp4tfMLSNfsjkDEQQNEwuaeHajaMYnTzb7PIUJkTm5XAooOrbABsKZxTc2jZAKLZVMZ8+x
 bZzscEb3AWzlx42P4vUlStT7WmNciQNXqhPWkv222M3Zt7HEm1/XKE=
IronPort-HdrOrdr: A9a23:hv5DpKEzK4uWm185pLqFR5HXdLJyesId70hD6qkvc3Jom52j+P
 xGws526fatskdsZJkh8erwXJVp2RvnhNBICPoqTMiftW7dySqVxeBZnMTfKljbehEWmdQtrZ
 uIH5IOauEYSGIK8PoSgzPIU+rIouP3i5xA7N22pxwGIGEaCJ2IrT0JcDpzencGHjWubqBJc6
 Z0k/A33gZIDk5nCPhTaEN1OtTrlpnurtbLcBQGDxko5E2lljWz8oP3FBCew1M3Ty5P6a1Kyx
 mHryXJooGY992rwB7V0GHeq75MnsH699dFDMuQzuAINzTXjBqybogJYczBgNl1mpDr1L8Zqq
 iKn/4SBbU015oXRBDtnfLZ4Xil7N/p0Q679bbXuwq5nSWzfkNFNyMIv/MpTvKe0Tt8gDg06t
 M640uJ85VQFh/OhyL7+pzBUAxrjFO9pT44nfcUlGE3a/pVVFZ9l/1WwKpuKuZKIMs60vFSLM
 B+SMXHoPpGe1KTaH7U+mFp3dy3R3w2WhOLWFILtMCZ2yVf2CkR9TpV+OUP2nMbsJ4tQZhN4O
 rJdqxuibFVV8cTKaZwHv0IT8e7AnHEBRjMLGWRK1L6E7xvAQOBl7fnpLEuoO26cp0By5U/3J
 zHTVNDrGY3P1njDMWftac7uywlgF/NKwgF5vsulaSRi4eMM4YDaxfzO2zGu/HQ1skiPg==
X-IronPort-AV: E=Sophos;i="5.88,355,1635220800"; 
   d="scan'208";a="63817683"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Sq4KV6WYGRp47LC2vH2LezrP/DU/+4A21V7NV+mJw9+nzZw23aNM0/M0icckO17WHG3v9plYa1bWxLSF+p7AJmMAQaHHaw2c9xxRmLqRkjdKjb76m7aK6kbUN1Ie5CBGNSXH5qefeXAtvfFIekER8sYgOP+eJOfiXh8NVvd4tS2jy9oOlXS/jYSyFSk1WlT2FjjjEelIhKngwSeJtYm50njXvsE0MQPUKPLWUkt1cm1ZzOIVkSrkApV90ZuK2r/uytveK/4qV5ZMtiKAaVlRJHNf+IZ75nDKk4XmhltqHaucAbszVaIdZyyi2kIyH+B0c/phZtb6qf90tnEZVKQkQA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=awSpnk9KzfJE1f7cDS5tVTLb/jHKmp11yzJIZm63+E8=;
 b=FxuUsRO394j7g4pYMu0jsjt+ENwYMYvpQAg0fRmMkzvdJgqWmMJAcK1YVRGko+06RmWizsRkpRiPflzhjuTnjDGcyLy0wMO1OmQjfhpz/rQXqoBF1n4jlbuaxD+1UKHF3WY2TcdFO64MrY3/+g3XjMo/vK0vHT9yscN08HaOUPrn8msXEfunJUULT+CbGF8e03MwQG2TMKJzwCLYYbGXgihkTCDlKjAI4DgWQ6acxvygwPECI3qj5yxTk487xi/1kc+1VT/yIexCBD8IEGFZ5uaJdfT6/nkcw0vkyMvsyyu0BCS9jRZDNr2waXb9/AHMYdNsyj+iVkzLLVqmgW+VDw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=awSpnk9KzfJE1f7cDS5tVTLb/jHKmp11yzJIZm63+E8=;
 b=ee2TT8L3fZcm+fYMClbAq6Rg7fLsr7rqEAQPqp4KLp1/BsM+5dSjGVaTkrSfFkjSyP5+NRnJkBkB+Rnj3igmyW7YvpiwzFevGhjRklK+4e47RRltK5etaS281cgMVso5HGZPyQzNQ9mmqW81K+nsizQZvdmVLHfuPd0GmdjmL3k=
From: Jane Malalane <Jane.Malalane@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Jan Beulich <jbeulich@suse.com>, Andrew Cooper
	<Andrew.Cooper3@citrix.com>, Roger Pau Monne <roger.pau@citrix.com>, Wei Liu
	<wl@xen.org>
Subject: Re: [PATCH] x86/dom0: Add log for dom0_nodes and dom0_max_vcpus_max
 conflict
Thread-Topic: [PATCH] x86/dom0: Add log for dom0_nodes and dom0_max_vcpus_max
 conflict
Thread-Index: AQHYHaBVLLQoAjzhjUW/NIePQEslT6yLB48A
Date: Wed, 9 Feb 2022 10:40:10 +0000
Message-ID: <489b4434-aa05-1355-a704-cbec56b73e5b@citrix.com>
References: <20220209103153.11391-1-jane.malalane@citrix.com>
In-Reply-To: <20220209103153.11391-1-jane.malalane@citrix.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: e15b02d6-5f8c-4d61-3223-08d9ebb88bde
x-ms-traffictypediagnostic: MN2PR03MB5133:EE_
x-microsoft-antispam-prvs: <MN2PR03MB51338B33966E595CE9870488812E9@MN2PR03MB5133.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: asuvPH2tLAERX+9tHiqLm6CLmaApHQiJ2R6ueZW3ptjJR965RXtvW+QbScLfUEz5TdGNzdt5sylwuDiiHmskvtQZfxjtVSFd75tgaURhkpxABJiYIv/D1Cs4YfC0i6B+l18YDBGZUy/Z3rapCfqGGdQGx2CjogBMFaPM08dDhdmpaPGE8VGk31FYLgl6QfGDMflhd5MK9ijjwGliaRSKjtZjATyFF3u5V81J4LqMMrpkqBo8IdV87HumGQPhEfkCCnxmnrih7hsoOc4S4r2AVo9ywRZaceM434zFy1zx/Nz8euzB0Po6WT7OYScPVhApKEnLHwsPOh83ORmtjOVex/IqAwxp8ElWvlO7KHQc6HEKM8UBwVCqfQjsB9xno+AsbRrDrC/ng8OfEdNzDVTI212dhsDp5ryFnR+l44AC0H3gR4oG1DE1knKOvqTPJCKS6VSHJzkb3rHSzOGo4XHjdWcNrj4AYeZSyR9q6ZHlAE7MrSrXa0HNDuvDsGPuWOvxlH/isu4AfMmosRb5mx+NCU9dhFu8ufvWc3/DhguNG2+6LX42PEsRUvpHs2Y+Z9xvzttDHhvI+xf+J9E+WZFgMVYS6qU0jIDVMa63Ff9JhGATwmKY45X4NQxxZ0FeXu6l3Yikd0zKFZC4SjPulDsVsxhc8oy76dkPrHCKkQSS+p7P0VIAPHOuEkBpHts8Ba/HFI4VFZNuTb8OF0dHxld2WHbocDEEtz6Yks41vHW82lnKcCPsoFPE7BLLleekBUtz
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR03MB3386.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(8936002)(6512007)(54906003)(36756003)(2616005)(6506007)(71200400001)(316002)(38070700005)(508600001)(91956017)(6486002)(31686004)(6916009)(53546011)(122000001)(8676002)(76116006)(31696002)(83380400001)(86362001)(66446008)(4326008)(26005)(64756008)(66476007)(66556008)(66946007)(186003)(82960400001)(2906002)(38100700002)(5660300002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?NnAzK0pWNGIrYTc2WDRIR3oyK1ovMEgzSThUdE1zZGtZVmZDQTJtZHNxRko0?=
 =?utf-8?B?b25nTVVKQ3IrM1dUQnI1NW1PMThsOS9aVlNTOFQ2WVNCMTRBdzVoUWwwVzRa?=
 =?utf-8?B?MU10bFlyLzB2a3ZDRnZ0U0U0Q3Vpa2liWFFqWUMrR3lNQ1VXVWU3dE44Q1ov?=
 =?utf-8?B?OHpNZmNldE9MT1g3OGJUVldaNTh0em4va1NVRU43RlZYKzIvbWlpT2J5UnNM?=
 =?utf-8?B?WnNqa3NmWS9USkJKblppY25RNHZCdW5NT0pCMDh4SUtMT2Q5amlxQnJtWW81?=
 =?utf-8?B?bXBRb0tnR0ZMUkljRWhRamV0eVZsc3BJYVhYajA1K0YvZTJUVHVGdVdGdS9R?=
 =?utf-8?B?ZXdSUmxVVW5reklGWmZRVGtIQ2tBUDJWaFdjcHRmY0FaRjFNRXBWc2FLbnYw?=
 =?utf-8?B?TXUwRXBIWkdvcC83SFJlK1U1NW1XOW1Ga2IzenRhUVI3SmJiUXRsU2s1c0RB?=
 =?utf-8?B?YUdqTWZsdzYvd0pLd3Rndk8yZ1BySEh4WXVZUUZFVVpnOHRZMkhuS0o1ZGNn?=
 =?utf-8?B?MllaVzFIZDVWWmozVDFVTU1ZNVV1Y0RGWFpEa2J5M1RQSnZIbldUNXNidTd5?=
 =?utf-8?B?OEUxSWc1N01jOElDZlhGc2VucDBvU0pORHBvWjBmK1NUaDFxZGk5M0RpK2t5?=
 =?utf-8?B?eUcyUzNoU2ozTmhaTE9TMFV2ZlJHZ2lrcGZEYTJzckMwNk5OWUxMNjdhUE9B?=
 =?utf-8?B?RXRaZDhkdTIvWWpTRzdUWmhnZXBiLzV0enVGcDQ4NDQ4NzNWQU5wOTUyQk5k?=
 =?utf-8?B?NG9ud2k0dzNUdHU0V0k3STRlNCs3MlpqTytoQ0xIZkNlNWpCem5hM3UyZndJ?=
 =?utf-8?B?cDF6NWhoVnNFZ0VhcGhoOE1LUHErZ2I0ejV5VURQeEFqRzdvZHlmM1BaT1ZY?=
 =?utf-8?B?ZmF0bWNyZmo4WXhaZ3NOcFdBVVM2L0RIRU5JbmxwYldkVFN2aTEra0EyV1FG?=
 =?utf-8?B?eDVwWTNjRkNnWjFheW9nZHZCS1EzTktBc2RSalFPTUxCclRHcHhHc2IzYjZ4?=
 =?utf-8?B?Qm9hYnJXOUEvdVZuZ2l1VUhidHBmbTVSYVhEZ1l1Y0pFWUE1YnFndEtBaStM?=
 =?utf-8?B?Zm8xYlhkRWpObkxtMXo2cXNFM2g4NXF3UUFwc0tLeUR5ZG1TT3FvWnNwbHRo?=
 =?utf-8?B?V0dYZFN5S0c5UThoV1NjeFpiL2NJeFZFM2M2bFljZTRFYWpaSVFtVWVEeHVm?=
 =?utf-8?B?RVE1REZFZ2prUlgyU0xzaWROaUcrM1FFcVJVZHVlVG9EV3pFZEx5cFFsdmxZ?=
 =?utf-8?B?ZG9RcEVLRzJiMU4vbHZQcXpkWHl3Z3RZRGl4ckJJS0dBVEUwdGtPRTJYSEFR?=
 =?utf-8?B?bCtmeHI0Z0xkQXVFbDFudFU5RFBjZEZxVldHbkpoRzV6c1RTR3M3bEpZZHM2?=
 =?utf-8?B?QlJoL0FaL0lBVXprVmdWbjZMS01UZ3VOK1NOamFnTEdSbVY1d2J3QUlSclgy?=
 =?utf-8?B?M0thRWoxQzVtSUZhZXNNTmcwdEkrNkpFR0NDbFpqMUFKYWZ5NDdCcVBOeW0r?=
 =?utf-8?B?ZFJ6anlJSExMcTJrcnFVUFQ5UEplQXdWV1ZFMUJUakhmMmkzYnNJeVZPWkFK?=
 =?utf-8?B?cmhSVlZEQWh5djNWYzlYRTNFTFB5ZzgyQ3hhdS9ZUnRFRkxKV3hhU3JuQUtN?=
 =?utf-8?B?SXZEbVUvSzRiY21Zcm1tR1hlbk9xRFpCR1hYV3lVV3dmeEw2MSsyU1pJYm1K?=
 =?utf-8?B?cjdqVnhwYXVqZHgveHZBN2puN2kyZTU4YVM4bGlqMXNhZ0hGVlJiWFdzemRu?=
 =?utf-8?B?Tk80Wm84djlwa1hUakdDRkNFa2ZEckNnVndhQ296T1hubWRkQVVhSlg5ZUly?=
 =?utf-8?B?MDlZOWNBUUJTQ2Rkb0QzSWFOc21SSHFFaGNONUR1UDlrdkxFeWZuVC94eWxU?=
 =?utf-8?B?VnIxc1ZRTi9vTzRWS3RYWEhyY3VCUVFVREc3Wk5zdGRNckNvemkzRWpNRlJR?=
 =?utf-8?B?dWNrTjJTSlQzOFcwZ09NTDRJajNyQlZ4U0oxME1pbnJqVXROZWZIL1RWR09j?=
 =?utf-8?B?MTdjR01tL0lTdklQTHQ1THBRNmlWdTZzT3BPMkdTbjBxRmxuSDdLTVFIbGtR?=
 =?utf-8?B?WU1EeXFPNW5jWFgwc2JNQ0RFSHR1Qlh3QjZJZW1RSG15b212UXZTVmlyUlQv?=
 =?utf-8?B?Z0pkWm5YTjVvZmpNeFRmR1d4NDFscnlNWFd4c2hMVFhVWVF5Q3QwRHdDc292?=
 =?utf-8?B?cGRsN0Z2c3V4bElHVW1SRWZ0aExCNGNEdGt3RFdJdzdQSVpZSkpzTkNibGkx?=
 =?utf-8?Q?avNopMRbL99xto4lXxwyfD8fG3bGk+mG5xudcv51E0=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <6D6DAA1E2DFC64468EDB92421FF02EEC@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM5PR03MB3386.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e15b02d6-5f8c-4d61-3223-08d9ebb88bde
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Feb 2022 10:40:10.1959
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: WPcUVJyMQ6udYC4+Yv69qNYCL0e3oOLTn5+//ct6P8gLmk+NzFnQAtJfvWkHfC+rMaz2laUHqTqK8d14abMp53CosR4RcG4L8/mEJl7OTHo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB5133
X-OriginatorOrg: citrix.com

T24gMDkvMDIvMjAyMiAxMDozMSwgSmFuZSBNYWxhbGFuZSB3cm90ZToNCj4gVGhpcyBpcyBub3Qg
YSBidWcuIFRoZSB4ZW4gY21kbGluZSBjYW4gcmVxdWVzdCBib3RoIGEgTlVNQSByZXN0cmljdGlv
bg0KPiBhbmQgYSB2Y3B1IGNvdW50IHJlc3RyaWN0aW9uIGZvciBEb20wLiBUaGUgbm9kZSByZXN0
cmljdGlvbiB3aWwgYWx3YXlzDQo+IGJlIHJlc3BlY3RlZCB3aGljaCBtaWdodCBtZWFuIGVpdGhl
ciB1c2luZyBkb20wX21heF92Y3B1cyA8DQo+IG9wdF9kb20wX21heF92Y3B1c19tYXggb3IgdXNp
bmcgbW9yZSB2Q1BVcyB0aGFuIHBDUFVzIG9uIGEgbm9kZS4gSW4NCj4gdGhlIGNhc2Ugd2hlcmUg
ZG9tMF9tYXhfdmNwdXMgZ2V0cyBjYXBwZWQgYXQgdGhlIG1heGltdW0gbnVtYmVyIG9mDQo+IHBD
UFVzIGZvciB0aGUgbnVtYmVyIG9mIG5vZGVzIGNob3NlbiwgaXQgY2FuIGJlIHVzZWZ1bCBwYXJ0
aWN1bGFybHkNCj4gZm9yIGRlYnVnZ2luZyB0byBwcmludCBhIG1lc3NhZ2UgaW4gdGhlIHNlcmlh
bCBsb2cuDQo+IA0KPiBTdWdnZXN0ZWQtYnk6IEVkd2luIFRvcm9rIDxlZHZpbi50b3Jva0BjaXRy
aXguY29tPg0KPiBTaWduZWQtb2ZmLWJ5OiBKYW5lIE1hbGFsYW5lIDxqYW5lLm1hbGFsYW5lQGNp
dHJpeC5jb20+DQo+IC0tLQ0KPiBDQzogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPg0K
PiBDQzogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4NCj4gQ0M6ICJS
b2dlciBQYXUgTW9ubsOpIiA8cm9nZXIucGF1QGNpdHJpeC5jb20+DQo+IENDOiBXZWkgTGl1IDx3
bEB4ZW4ub3JnPg0KPiAtLS0NCj4gICB4ZW4vYXJjaC94ODYvZG9tMF9idWlsZC5jIHwgNSArKysr
Kw0KPiAgIDEgZmlsZSBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKykNCj4gDQo+IGRpZmYgLS1naXQg
YS94ZW4vYXJjaC94ODYvZG9tMF9idWlsZC5jIGIveGVuL2FyY2gveDg2L2RvbTBfYnVpbGQuYw0K
PiBpbmRleCBmZTI0ZTExYjM3Li5lNTdjYzgwZWYwIDEwMDY0NA0KPiAtLS0gYS94ZW4vYXJjaC94
ODYvZG9tMF9idWlsZC5jDQo+ICsrKyBiL3hlbi9hcmNoL3g4Ni9kb20wX2J1aWxkLmMNCj4gQEAg
LTI0MCw2ICsyNDAsMTEgQEAgdW5zaWduZWQgaW50IF9faW5pdCBkb20wX21heF92Y3B1cyh2b2lk
KQ0KPiAgICAgICBpZiAoIG1heF92Y3B1cyA+IGxpbWl0ICkNCj4gICAgICAgICAgIG1heF92Y3B1
cyA9IGxpbWl0Ow0KPiAgIA0KPiArICAgIGlmICggbWF4X3ZjcHVzIDwgb3B0X2RvbTBfbWF4X3Zj
cHVzX21heCAmJiBtYXhfdmNwdXMgPiBvcHRfZG9tMF9tYXhfdmNwdXNfbWluICkNCj4gKyAgICAg
ICAgcHJpbnRrKFhFTkxPR19JTkZPICJEb20wIHVzaW5nICVkIHZDUFVzIGNvbmZsaWN0cyB3aXRo
IHJlcXVlc3QgdG8gdXNlIg0KPiArICAgICAgICAgICAgICAgIiAlZCBub2RlKHMpLCB1c2luZyB1
cCB0byAlZCB2Q1BVc1xuIiwgb3B0X2RvbTBfbWF4X3ZjcHVzX21heCwNCj4gKyAgICAgICAgICAg
ICAgIGRvbTBfbnJfcHhtcywgbWF4X3ZjcHVzKTsNCj4gKw0KPiAgICAgICByZXR1cm4gbWF4X3Zj
cHVzOw0KPiAgIH0NCj4gICANCkhlcmUgSSB3YXMgZGViYXRpbmcgd2hldGhlciB0byB1c2UgYSBw
cmludGsgb3IgYSBkcHJpbnRrLCBhcyBhbHRob3VnaCANCnRoaXMgd291bGQgYmUgdXNlZnVsIGZv
ciBkZWJ1Z2dpbmcsIGl0IGdpdmVzIGdlbmVyYWwgaW5mbyBvbiBkb20wIHZDUFUgDQp0b3BvbG9n
eSwgYXMgZG9lcyBmb3IgZS5nLiAnRG9tMCBoYXMgbWF4aW1pbXVtIC4uLiB2Q1BVUycuIEhvd2V2
ZXIsIEkgDQpkZWZlciB0byB0aGUgbWFpbnRhaW5lcnMsIGFzIEknbSBzdGlsbCBnZXR0aW5nIGFj
cXVhaW50ZWQgd2l0aCBYZW4gKEkgDQphbHNvIHVuZGVyc3RhbmQgdGhpcyBwYXRjaCBpcyBvZiBt
aW5vciBpbXBvcnRhbmNlKS4NCg0KVGhhbmtzLA0KDQpKYW5lLg==


From xen-devel-bounces@lists.xenproject.org Wed Feb 09 10:45:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 09 Feb 2022 10:45:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268956.462896 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHkTv-0006DU-1S; Wed, 09 Feb 2022 10:45:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268956.462896; Wed, 09 Feb 2022 10:45:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHkTu-0006DN-TJ; Wed, 09 Feb 2022 10:45:50 +0000
Received: by outflank-mailman (input) for mailman id 268956;
 Wed, 09 Feb 2022 10:45:49 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nHkTt-0006DB-Js; Wed, 09 Feb 2022 10:45:49 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nHkTt-00020O-Hi; Wed, 09 Feb 2022 10:45:49 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nHkTt-0004BM-2x; Wed, 09 Feb 2022 10:45:49 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nHkTt-0008FK-24; Wed, 09 Feb 2022 10:45:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=HMmCtR+IUTk3zCcD6m2V3CmKknxGqtJcxvdYZ74AcdE=; b=38mXfEWN/AHUqb6X64keQheN2h
	iiUFbreBV5Hyc6Dy6JYM/0DL+jeu7xonY5v4s5Er5RYUeXjmecxT699IGg52jHt3nT9Cftlx7eidN
	e3L5ce0FxpIdXCZcc+hsEh2Glst9/YYqnUEYGnWsvr8SRYoZ3kd2E0639Spfnxx8ursg=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168064-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 168064: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=345746045b49258547d67f456c368f23353575d4
X-Osstest-Versions-That:
    xen=10d33220f2363a21a52a394159118ab4ddaed50e
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 09 Feb 2022 10:45:49 +0000

flight 168064 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168064/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168055
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168055
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168055
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168055
 test-armhf-armhf-xl-rtds     18 guest-start/debian.repeat    fail  like 168055
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168055
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168055
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168055
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168055
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168055
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168055
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168055
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168055
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 xen                  345746045b49258547d67f456c368f23353575d4
baseline version:
 xen                  10d33220f2363a21a52a394159118ab4ddaed50e

Last test of basis   168055  2022-02-08 08:36:22 Z    1 days
Testing same since   168064  2022-02-08 18:37:45 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Anthony PERARD <anthony.perard@citrix.com>
  Juergen Gross <jgross@suse.com>
  Michal Orzel <michal.orzel@arm.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   10d33220f2..345746045b  345746045b49258547d67f456c368f23353575d4 -> master


From xen-devel-bounces@lists.xenproject.org Wed Feb 09 10:56:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 09 Feb 2022 10:56:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268977.462939 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHke8-000863-GY; Wed, 09 Feb 2022 10:56:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268977.462939; Wed, 09 Feb 2022 10:56:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHke8-00085w-CF; Wed, 09 Feb 2022 10:56:24 +0000
Received: by outflank-mailman (input) for mailman id 268977;
 Wed, 09 Feb 2022 10:56:23 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nHke7-00085i-Fn; Wed, 09 Feb 2022 10:56:23 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nHke7-0002Fm-EF; Wed, 09 Feb 2022 10:56:23 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nHke6-0004uv-V7; Wed, 09 Feb 2022 10:56:23 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nHke6-0008Hi-Uc; Wed, 09 Feb 2022 10:56:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=j81el6VyqnXmom0U006thbDE4VPYBSIkEGTddmI9cU4=; b=knlttk/vZKtBR9p2ib1EAxVJ5k
	JahPxdmosnciAAkDs/zIsV1cT31blwul8MYPUYwuXIDiE/yc2NA8/Ownf1FNk5+rthwwaL21G0P3B
	Lc7n3gurTXEcR+ZZJvo8qdCUKwEz5posNFowCdfNov7e2lnzo1y89Ei0/eEXQMxYvCH8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168063-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.16-testing test] 168063: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-4.16-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=2d8eade97343e99c26b004a05868532613007c8d
X-Osstest-Versions-That:
    xen=0da8f3d23f86dafc4781cb75f46722841b87bdbf
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 09 Feb 2022 10:56:22 +0000

flight 168063 xen-4.16-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168063/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168015
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168015
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168015
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168015
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168015
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168015
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168015
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168015
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168015
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168015
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168015
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168015
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  2d8eade97343e99c26b004a05868532613007c8d
baseline version:
 xen                  0da8f3d23f86dafc4781cb75f46722841b87bdbf

Last test of basis   168015  2022-02-04 17:06:48 Z    4 days
Testing same since   168063  2022-02-08 18:37:45 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Jan Beulich <jbeulich@suse.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   0da8f3d23f..2d8eade973  2d8eade97343e99c26b004a05868532613007c8d -> stable-4.16


From xen-devel-bounces@lists.xenproject.org Wed Feb 09 10:57:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 09 Feb 2022 10:57:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.268989.462950 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHkfJ-0000Lx-Va; Wed, 09 Feb 2022 10:57:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 268989.462950; Wed, 09 Feb 2022 10:57:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHkfJ-0000Lq-S3; Wed, 09 Feb 2022 10:57:37 +0000
Received: by outflank-mailman (input) for mailman id 268989;
 Wed, 09 Feb 2022 10:57:37 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=H3wK=SY=citrix.com=Jane.Malalane@srs-se1.protection.inumbo.net>)
 id 1nHkfI-00005t-SE
 for xen-devel@lists.xenproject.org; Wed, 09 Feb 2022 10:57:37 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 155a2393-8997-11ec-8eb8-a37418f5ba1a;
 Wed, 09 Feb 2022 11:57:34 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 155a2393-8997-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644404254;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=dYlHg6wVBRiHNl/BBh6bGk3rCEDLC9R20yXdIbPDzFY=;
  b=g9o8y0k4lM3Ezj9uPPzl2nwfrrcEdoiFiQ/wNGASXipWzA9Kg1o3fYsH
   femgyQReTRsqSEjjv0j9ufcjA/kp1OHFPrDoEyxqwbTzF4CTaEH72cMsy
   U1ZJjXg5JHgv6TUDRZqLTTiit9PK10QqwxnnAjjCuL+7bsk45+9fuL294
   Q=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: XA8VNJCMjb8rFJqmV79f/ojU3K43XgtYL/+NbvYP6IKg0H+FIHiGbvYm6NNZe/CMe6qijFkxzO
 qIS1r9yvicxZfca1/7JLzlKvEvGTAwp7L3BCRG1/Q4RzC04FC9HDfMZe3P6PLnU/Gef78KxAOo
 WlgR5k0waLIH8XHEx9EFefpHi2qk0CdmRc90bb7uBs+JzWl/365LdXbm8zha+uU/e396OegTt2
 cm2WSmMWOdOhyNUxPrChIV4dJDh0cv0fmnwe2tLUSDc1c7NciVGqKsCgGeF9LKOMTs3mspl2xp
 IGXHSSM+NNmKzi0QK9gWQUtC
X-SBRS: 5.1
X-MesageID: 63818475
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Jvocpq87LHhx7zndxKcuDrUDyHiTJUtcMsCJ2f8bNWPcYEJGY0x3y
 zAfUD3SMquPNmf9e4xzPt/l8kIOvp7SydRhGgRq/yE8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhFWeIdA970Ug5w7Rh09Yx6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhq8
 YlG7JqbcT4SffbAh+YFTCJYCXFhaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguwBJc/meqYWvnhkxDfUJf0nXYrCU+PB4towMDIY2JseRKaCO
 JdxhTxHSyr+ZTpFM3ktDJMCn6TyiXC4MGZHgQfAzUYwyzeKl1EguFT3C/LOYcCDT8hRmkeep
 0rF8n7/DxVcM8aQoRKH73ati+nnjS79HoUIG9WQyPluh1GCw30JPzcfX1C7vPqRh1a3XpRUL
 El80iYns6Ua7kGgSdj5GRqirxasoRo0S9dWVeog52ml2qfSpgqUGGUAZjpAc8A98t87QyQw0
 V2ElM+vAiZg2JWXQ3+A8rafrRupJDMYa2QFYEcsTwQf5ML4iJoulR+JRdFmeJNZlfWsR2u2m
 WrT6nFj2fND1qbnyplX43jcum6n/57idjcOpV7bQWC98Th5ft66MtnABUfg0d5MK4OQT1+kt
 XcCmtSD4O1mMaxhhBBhU81WQuj3uq/t3Cn0xAc2QsJ/r2jFF2uLINgIiAySMnuFJSrtldXBR
 EbI8T1c65ZIVJdBRf8mOtnhYyjGIEWJKDgEahw2RocXCnSSXFXelM2LWaJ29zqw+KTLuftgU
 ap3ie72UR4n5V1PlVJavds1374x3TwZzmjOX539xBnP+ePAOCLOFepZYQLeN71RAEa4TOP9q
 Ys32yyikUo3bQEDSnOPrd57wa4icRDX+qwaW+QIL7Xec2KK6UkqCuPLwKNJRmCWt/89qws8x
 VnkAhUw4AOm3RXvcFzWAlg+OOKHdcsu9hoTYH1zVX72gCJLSdj0s88im24fIOBPGBpLlqUvE
 ZHouqyoX5xyd9gw025FMsCm8dcyLU/DaMDnF3PNXQXTtqVIHmTh0tTlYhHu5G8JCC+2vtE5u
 LquykXQRp9reuioJJ++hCuHwwzjsH4Dtvh1WkeUcNBfdF+1qNphKjDrj+9xKMYJcE2Ryjyf3
 geQIBEZueiS/NNlrIiX3fiJ/9WzDu9zPktGBG2Hv7y4AjbXozi4yohaXefWIT2EDDHo+L+vb
 Pl+xu3nNKFVh05DtodxSu45za8369b1iaVdywBoQCfCY1ixU+syKXiax8hf8KZKw+YB6wexX
 0uO/PhcOKmIZ5y5QAJAelJ9Y73ah/8OmzTU4fAkG2nA5Xd6rOidTEFfHxiQkygBfrF7B5won
 LU6s8kM5g3h1hdzaoSajjpZ/ninJ2AbV/l1rYkTBYLmh1Z5ylxGZpCAWCb67IvWNodJO0guZ
 DSVmLDDl/JXwU+bKyg/En3E3Ox8g5USuU8VkA9edgrRwteV1OUq2BBx8CgsSlUHxxpK5Ot/J
 2x3OhAnPq6J5Tpp2JBOUm3E99ut3/FFFpgdE2c0qVA=
IronPort-HdrOrdr: A9a23:k1mYp6jwoDWBhFkDRkvOJV7193BQX3d13DAbv31ZSRFFG/FwyP
 rAoB1L73PJYWgqNU3IwerwRZVpQRvnhPtICRF4B8bsYOCUghrVEGgE1/qt/9SAIVyzygc578
 ldmsdFeaTN5DRB/KXHCUyDYqwdKbq8geGVbIXlvg9QpGhRAskKhWYYNu/YKDwMeOAvP+tjKH
 P23Lsim9PUQwVwUi3NPAhjYwGsnayoqLvWJTo9QzI34giHij2lrJTgFQKD4xsYWzRThZ8/7G
 nsiWXCl+WemsD+7iWZ+37Y7pxQltek4MBEHtawhs8cLSipohq0Zb5mR6aJsFkO0aKSARcR4Z
 vxSiUbToBOAkDqDyaISNzWqk/dOQMVmjrfIJmj8CLeSILCNWoH4oF69P1km1PimjQdVZdHof
 h2NiuixutqJAKFkyLn69fSURZ20kKyvHo5iOYWy2dSSI0EddZq3MciFW5uYd499RjBmcga+S
 hVfbThzecTdUnfY2HSv2FpztDpVnMvHg2eSkxHvsCOyTBZkH1w0kNdnaUk7zo93YN4T4MB6/
 XPM6xumr0LRsgKbbhlDONERcesEGTCTR/FLWrXK1X6E6MMPW7LtvfMkf8IzfDvfIZNwIo5mZ
 zHXl8dvWkue1j2AcnLx5FP+gClehTKYd0s8LAo23FUgMyOeFPbC1z2dLl1qbrRnxw2OLyoZ8
 qO
X-IronPort-AV: E=Sophos;i="5.88,355,1635220800"; 
   d="scan'208";a="63818475"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Z75Tto+UQ4jdSxLX5P70YDw2TD2IGYBKCX76/AzSdxaFheiafm9MduX0NHzFxC+MdKHz9LNoo5gzLNZ9YZ4h3KopNb0yaZjEOqJ5Z3p3B0ouGRXp91lUzQGWAS1GCkJYgyuA5M9+LV3Yp5Xv/YCdK/cyIZWt9i9LJyQTR40WmZ5XrvKC8EqqSu8JiVp10fIpqGmGhpdHiNWT7PNxp/PpkfFb39lFuwTCFmxbrXRvTgHFAfUPBc0vgIPvRiOhppvcoKcjEZVi0kuyNICtkGgPM/Tq/lKH0B+eqOGtd4OnVu2Wc5Gc3tSwJYqxcvQSkb5PWYI7pUW5I3nRvYp90+xvLw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=dYlHg6wVBRiHNl/BBh6bGk3rCEDLC9R20yXdIbPDzFY=;
 b=Ixqh106OZqve0wCSqQpbgXOR5PBVdDb/QKvdvuB49ixK8yJ59xAX2V0VEEMVN8Y6s81SrhRkiMweV/eg0AQz/gKqntaVU/FGgSEEoIyvPpYPywW5frS8Uzsk0k8EqsazEQ7D/PRMp22HD0/rpahvcWPKPK9tJa3gsrFD0hUHTik7/njK42wRQZcLXhGKRKK0k/CDd2xTSXI5Uki+ZWReBQNe3KgOG+iNjF8bUIfJfBOXCgiBX5axTXbWqccvgs78GjL2Qt8dm7Obz8mkUDFK3VaGlgnJ5ieM//2OG2EBKff2xb4tfzNgErfw2QNBSkDzZ1W6VpGdeu3lZbDZmCSQXg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=dYlHg6wVBRiHNl/BBh6bGk3rCEDLC9R20yXdIbPDzFY=;
 b=IXnial0CNWdfEUNZPGQ4hLAKluJb+E26s5Ri7xAjHXmoWympYoLxISzVMiIe+FLTCulhiHI3biyb6bpJQsmhX/CeXrLsEoiYjrY3g0SeukvsKZ15RUkHHmKf2Bv0/yj9X39bIxjPFSsMS8KCBl3kK9J7K+zlsoir6+Ayk9sG2dc=
From: Jane Malalane <Jane.Malalane@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>, "Anthony
 Perard" <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, "Andrew
 Cooper" <Andrew.Cooper3@citrix.com>, George Dunlap
	<George.Dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, Julien Grall
	<julien@xen.org>, "Stefano Stabellini" <sstabellini@kernel.org>, Christian
 Lindig <christian.lindig@citrix.com>, David Scott <dave@recoil.org>,
	"Volodymyr Babchuk" <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v2 2/2] x86/xen: Allow per-domain usage of hardware
 virtualized APIC
Thread-Topic: [PATCH v2 2/2] x86/xen: Allow per-domain usage of hardware
 virtualized APIC
Thread-Index: AQHYHE+bJUKmznundkO+jjEyYTnVA6yJ1jWAgAE4zAA=
Date: Wed, 9 Feb 2022 10:57:28 +0000
Message-ID: <76de6f28-f038-7e8f-ce3c-a3686112b1d4@citrix.com>
References: <20220207182101.31941-1-jane.malalane@citrix.com>
 <20220207182101.31941-3-jane.malalane@citrix.com>
 <YgKXrZ/U2XuECG3d@Air-de-Roger>
In-Reply-To: <YgKXrZ/U2XuECG3d@Air-de-Roger>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: d04a23dc-9b45-4d41-782a-08d9ebbaf701
x-ms-traffictypediagnostic: SJ0PR03MB5789:EE_
x-microsoft-antispam-prvs: <SJ0PR03MB5789A19479E17E9EB1600F30812E9@SJ0PR03MB5789.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: i5NMxjsMe+itpo6vPgAY6UxSvaQzqNkaJho+V5He8mZWaOj9BiGCpasb9RknUv+yqrT1k1w/eNqqpuD1iBd3lNrqt22M6Iv1Lkg4q0uZNit9g08yAQNsM1kPiKK3WiqsEQnoMj7JxdCDeP7Kjk8VXt6fZZziMo52bKxqoSA7fBFzRuIlfKgdE1l4nfUtibwJMsU3BCHMVCuDnVC8SHCvvdJVJ+wRdIwtXXafukmaaL2DfBgQsqkobtFcccirHdp+RRjFXxfBaS6YBuAxaGgDNcQJ0P06ZBTSrxe6hgVXlHWB9pZA0zzs72heixGiITEydQIGegetdvvYrg7rEDF4NuwyCMLpjGF4ox0WStmgPrUH7KjKFGkMroNQ+V7iFS3SyhOQgDPEDG+PUyaqwtN+bKsvTUAfSl7zZWT5HHIfPaNhQCqZ4DS957tddtY6VHjWM8iwwfVE5h5oIwIQlsEUpvqEi/+e6WW9G9Tc46aek4Z6BFgntbS/WiyG9IkqR1xrNcwOPE1H6dF3SsPK6INRtisnzkMoT2aXh4ISyCeFB33d+DqLbFmyNZa/gy6I4aNqj4SxmOu1XupB52Eb1TfsuN5GSaVsuYTAlGFc+WFAp7BAkliQaFMl/SZwUi99gVNei7eq5loXikqnL6UVietx7XDbIjvagIz8Kt+Lu5Z30iKAY6GJMqjShrZ1AmINs7CeONfpjUJo3B0JSiKrr1TIe35ajGD57Ar+puZzMrOtz/UGUSFR17wJQ2VJ1ZkjSTrN
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR03MB3386.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(122000001)(83380400001)(316002)(38100700002)(71200400001)(82960400001)(26005)(54906003)(6636002)(37006003)(2616005)(6506007)(91956017)(38070700005)(31686004)(2906002)(5660300002)(508600001)(76116006)(66946007)(36756003)(66556008)(6512007)(66476007)(6862004)(4326008)(8676002)(53546011)(66446008)(64756008)(186003)(8936002)(31696002)(30864003)(6486002)(86362001)(45980500001)(559001)(579004);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?NTZ4SU42WEVELzF6Q0IzL243YUFMeWJaK0Zza3J0WGNyR2hwUkRqOVJSZTFo?=
 =?utf-8?B?bUczckIvZlZkUE0xbXIvM2pRZFlUZ0ZMSUpJTlNRdXZtRSt5dUlZdHkvV1h2?=
 =?utf-8?B?bytpRjJ3cEgrSDlrU1RsV053OWpMS0N4WjBFMUZ4ZlM1QitUT1lqdFFoZ1Z5?=
 =?utf-8?B?c0E0UGs1VldPZkpydWNZdDNGYTBuNmVMSngrbWhoc1BKK0dEbW9kRG9FRnRF?=
 =?utf-8?B?alluSTY5VDk4OHRudE9PL3FlK0lJeWFxNW9ySDRqOHRYdHpkVVB6SHk3T0Ew?=
 =?utf-8?B?eVRxVFlJNVBkUWdYOXRNQTcyQ04zUi9KMVZtM1dQYlRLc3ZoeHA4ZGJSQXRJ?=
 =?utf-8?B?L1hXdmZLWW56TW5nWXJwWE5DVVN2cTlFZ0hZRzlNTjd0QUluSEI1dngvU29C?=
 =?utf-8?B?UjBBcVFYejgyTVFZVGRONU9Od2Zjd3cyRzVoUzVHMWpab0ZCd2c0SWFOOEpn?=
 =?utf-8?B?VXMvTzJKajhXNTNYMElRaGhJWkYvVjVGbXk4ajFjSWJJeStZN2Q4TWxkSDhH?=
 =?utf-8?B?RE5BTVI2azdkS2ZzUjBXNVhsWitGdGZHYlpva0dMbmpiK0R1ZEpXSFRIOWhF?=
 =?utf-8?B?VmhsMmdBYVc1c0ZNSzcwZFBFSjNndE9LMHJYNVFoNjBKQ1c1Y25lSDJaR09C?=
 =?utf-8?B?TkhJNzE0SlNmL1MrZk11a2VTOEp0WFFEbzl3MzA0U09GZ3I0b2x1SzdWM0NG?=
 =?utf-8?B?ZVNUNzdLTFh1WTE1Nzd6QmNMZEVzVC9RODljZ01MdTQ3dURJQytxWjgyTTYr?=
 =?utf-8?B?Qy9BSkdSZkNocVAwa0NmWjdqdEZZN1l0aFRzeUZVbEV2cHliamdmVzRFQ0NE?=
 =?utf-8?B?ZUVLQTVaMHJaSS9UMnpDVExoNDdlcjRHSXRXMHNESFZmYWpjQ2VOcjdKSkp0?=
 =?utf-8?B?TWk5OTBZNGswNDZ3SzZWN0JvbjZVQndqTGY5OUFLU2pMUVlQbndsS1BFUEhr?=
 =?utf-8?B?U29oVG1PWVByZHhPelQvVi85NUtJWE1VYTFOVnhBeVQ1bStPSzFEWmRaUlVX?=
 =?utf-8?B?NnJ5TTYwUnA1UHpBMkkyQW5xdGFDUXM3aVcxbis5RzltNlB6T0ZyQW9jUWhw?=
 =?utf-8?B?aXU0OElnUHBpSVJVUjZldmM4OXplN05Kek1JZjFMSFg3SjNsU1RHRWxkUkNp?=
 =?utf-8?B?NE5pMkd1Y0xWcGZqOVpSb3BEYzRZWTVudHNlWWlndWZLZkw3MkhsMWtSanVP?=
 =?utf-8?B?SEQ2WldxLzI5ZytLWTUwMTlleXJWUnJTVWVXRXYxeXpNSS9HcENJdDIwK1Zx?=
 =?utf-8?B?TDl5VFFHRTZZZU4vTFp1R205cXpndzlsc3RwcUtLS0ptL09UT1dKNkJEMkM0?=
 =?utf-8?B?bmNDci9FdC8zWFRlYzI5bllVWUE0cHBvM3NtZGZVWUkwdDNCSTJrZ1BrZzY2?=
 =?utf-8?B?cjVuZHZjcmZ6VW5Wd0VqZVRicGZXeG1rbHNCelZJdkV6MkNFMW8ya1N5eDdK?=
 =?utf-8?B?a2M1ekcwWk5Wd0dLY1lvNmNpUU9aK0IweWpWWWswSkk0dk54azMxL1ZHTHdK?=
 =?utf-8?B?UjRvbmhWSlR5OWRKbWdNNno4Qmp1SDhXZTZEYkljWUN3b0dab1dKeU02V2lO?=
 =?utf-8?B?TlhPbG52M1huejF6OTAvak5JZGN4UnljckYxeFV0c3RTZmpOb29ZY3ZpTGRv?=
 =?utf-8?B?YXJDV2F5YjNoUUtFQmlKeUI3STdHazkybjIxUFkxaTZSRFpvUWNrYmpQYko4?=
 =?utf-8?B?aXBTOE5sb25sc296SE0vV2ZUSWRFem1kS3VETXl0NVowOEFVcEtVbStiaEl6?=
 =?utf-8?B?RFJpOEtZTHIzT2JrL0lna2JiQnVuUkRzeVFvakRIQ3E3cUtpMFFhcXh0MkQ5?=
 =?utf-8?B?dXBkdXpPVUltd3FwcGJFaE9yNGl6OGZ0RkZUSHU2eFNWS005a0draWI4b29V?=
 =?utf-8?B?VEFUUm1xaG53a2NweTBsTFdWclRCcEkrV00zZUEvU3cyWG4vK2xSdmRXdW8v?=
 =?utf-8?B?R2Y1Vytoc1lsN0VLbFZ5OWVtZkhoL0w0Zk91ZzdDNVpZeE1VQlVOSXV1dlFo?=
 =?utf-8?B?TXMrQkpXQmVsM3BrMmdFMDZGbHhpR0lWUW9zanpaZEhvQ1pmK1V2UTJ5M3Bw?=
 =?utf-8?B?Wkd2T3NCNTJFbklTR0lyTUNYZVNaVUpOaklsbFI2VVhtNSt6RlVNN0piUVdx?=
 =?utf-8?B?dEJLSkpLU1l6NEU1Uk9OUHJTd3ByMU92czRMK1Y3c2IwUEhacmYzem81eDQw?=
 =?utf-8?B?bE42UXc0M0JYL25DMGg2WTFrYmxzd1NuSTdkbDAxc2pPQVJTTFJFZkc3MFRF?=
 =?utf-8?Q?inimb2lGQnQ028M8msR1nOuerzNYj18U5V+Xs7oINM=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <AD6FA04A19E9ED42B95F5807F00D68B7@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM5PR03MB3386.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d04a23dc-9b45-4d41-782a-08d9ebbaf701
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Feb 2022 10:57:28.8430
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: AtyXMeoqWcaRKIKyxhF9hAA65bHUKBF7CTFtdK2F/someRs+DiSZc52tBJoALEswz3GUZVLYdUj5RRqR4l64Is5INYQTkeit4TNQbO83AdI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5789
X-OriginatorOrg: citrix.com

T24gMDgvMDIvMjAyMiAxNjoxNywgUm9nZXIgUGF1IE1vbm7DqSB3cm90ZToNCj4gT24gTW9uLCBG
ZWIgMDcsIDIwMjIgYXQgMDY6MjE6MDFQTSArMDAwMCwgSmFuZSBNYWxhbGFuZSB3cm90ZToNCj4+
IEludHJvZHVjZSBhIG5ldyBwZXItZG9tYWluIGNyZWF0aW9uIHg4NiBzcGVjaWZpYyBmbGFnIHRv
DQo+PiBzZWxlY3Qgd2hldGhlciBoYXJkd2FyZSBhc3Npc3RlZCB2aXJ0dWFsaXphdGlvbiBzaG91
bGQgYmUgdXNlZCBmb3INCj4+IHh7Mn1BUElDLg0KPj4NCj4+IEEgcGVyLWRvbWFpbiBvcHRpb24g
aXMgYWRkZWQgdG8geGwgaW4gb3JkZXIgdG8gc2VsZWN0IHRoZSB1c2FnZSBvZg0KPj4geHsyfUFQ
SUMgaGFyZHdhcmUgYXNzaXN0ZWQgdml0dWFsaXphdGlvbiwgYXMgd2VsbCBhcyBhIGdsb2JhbA0K
Pj4gY29uZmlndXJhdGlvbiBvcHRpb24uDQo+Pg0KPj4gSGF2aW5nIGFsbCBBUElDIGludGVyYWN0
aW9uIGV4aXQgdG8gWGVuIGZvciBlbXVsYXRpb24gaXMgc2xvdyBhbmQgY2FuDQo+PiBpbmR1Y2Ug
bXVjaCBvdmVyaGVhZC4gSGFyZHdhcmUgY2FuIHNwZWVkIHVwIHh7Mn1BUElDIGJ5IHJ1bm5pbmcg
QVBJQw0KPj4gcmVhZC93cml0ZSBhY2Nlc3NlcyB3aXRob3V0IHRha2luZyBhIFZNIGV4aXQuDQo+
Pg0KPj4gQmVpbmcgYWJsZSB0byBkaXNhYmxlIHh7Mn1BUElDIGhhcmR3YXJlIGFzc2lzdGVkIHZp
dHVhbGl6YXRpb24gY2FuIGJlDQo+PiB1c2VmdWwgZm9yIHRlc3RpbmcgYW5kIGRlYnVnZ2luZyBw
dXJwb3Nlcy4NCj4gDQo+IEkgdGhpbmsgeW91IGhhdmUgYWdyZWVkIHdpdGggSmFuIHNvbWUgY2hh
bmdlcyB0byB0aGUgZGVzY3JpcHRpb24NCj4gcmVnYXJkaW5nIHRoZSBwdXJwb3NlIG9mIHRoZSBj
b21taXQuDQpZZXMuDQo+IA0KPj4NCj4+IFNpZ25lZC1vZmYtYnk6IEphbmUgTWFsYWxhbmUgPGph
bmUubWFsYWxhbmVAY2l0cml4LmNvbT4NCj4+IFN1Z2dlc3RlZC1ieTogQW5kcmV3IENvb3BlciA8
YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4NCldpbGwgc3dhcCB0aGUgb3JkZXJpbmcsIGZvcmdv
dCB0byBkbyB0aGlzIHByZXZpb3VzbHksIGFwb2xvZ2llcy4NCj4+IC0tLQ0KPj4gQ0M6IFdlaSBM
aXUgPHdsQHhlbi5vcmc+DQo+PiBDQzogQW50aG9ueSBQRVJBUkQgPGFudGhvbnkucGVyYXJkQGNp
dHJpeC5jb20+DQo+PiBDQzogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPg0KPj4gQ0M6
IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+DQo+PiBDQzogR2Vvcmdl
IER1bmxhcCA8Z2VvcmdlLmR1bmxhcEBjaXRyaXguY29tPg0KPj4gQ0M6IEphbiBCZXVsaWNoIDxq
YmV1bGljaEBzdXNlLmNvbT4NCj4+IENDOiBKdWxpZW4gR3JhbGwgPGp1bGllbkB4ZW4ub3JnPg0K
Pj4gQ0M6IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz4NCj4+IEND
OiBDaHJpc3RpYW4gTGluZGlnIDxjaHJpc3RpYW4ubGluZGlnQGNpdHJpeC5jb20+DQo+PiBDQzog
RGF2aWQgU2NvdHQgPGRhdmVAcmVjb2lsLm9yZz4NCj4+IENDOiBWb2xvZHlteXIgQmFiY2h1ayA8
Vm9sb2R5bXlyX0JhYmNodWtAZXBhbS5jb20+DQo+PiBDQzogIlJvZ2VyIFBhdSBNb25uw6kiIDxy
b2dlci5wYXVAY2l0cml4LmNvbT4NCj4+DQo+PiB2MjoNCj4+ICAgKiBBZGQgYSBMSUJYTF9IQVZF
X0FTU0lTVEVEX0FQSUMgbWFjcm8NCj4+ICAgKiBQYXNzIHhjcHlzaGluZm8gYXMgYSBwb2ludGVy
IGluIGxpYnhsX19hcmNoX2dldF9waHlzaW5mbw0KPj4gICAqIEFkZCBhIHJldHVybiBzdGF0ZW1l
bnQgaW4gbm93ICJpbnQiDQo+PiAgICAgbGlieGxfX2FyY2hfZG9tYWluX2J1aWxkX2luZm9fc2V0
ZGVmYXVsdA0KPj4gICAqIFByZXNlcnZlIGxpYnhsX19hcmNoX2RvbWFpbl9idWlsZF9pbmZvX3Nl
dGRlZmF1bHQgJ3MgbG9jYXRpb24gaW4NCj4+ICAgICBsaWJ4bF9jcmVhdGUuYw0KPj4gICAqIENv
cnJlY3QgeHsyfWFwaWMgZGVmYXVsdCBzZXR0aW5nIGxvZ2ljIGluDQo+PiAgICAgbGlieGxfX2Fy
Y2hfZG9tYWluX3ByZXBhcmVfY29uZmlnDQo+PiAgICogQ29ycmVjdCBsb2dpYyBmb3IgcGFyc2lu
ZyBhc3Npc3RlZF94ezJ9YXBpYyBob3N0L2d1ZXN0IG9wdGlvbnMgaW4NCj4+ICAgICB4bF9wYXJz
ZS5jIGFuZCBpbml0aWFsaXplIHRoZW0gdG8gLTEgaW4geGwuYw0KPj4gICAqIFVzZSBndWVzdCBv
cHRpb25zIGRpcmVjdGx5IGluIHZteF92bGFwaWNfbXNyX2NoYW5nZWQNCj4+ICAgKiBGaXggaW5k
ZW50YXRpb24gb2YgYm9vbCBhc3Npc3RlZF94ezJ9YXBpYyBpbiBzdHJ1Y3QgaHZtX2RvbWFpbg0K
Pj4gICAqIEFkZCBhIGNoYW5nZSBpbiB4ZW5jdHJsX3N0dWJzLmMgdG8gcGFzcyB4ZW5jdHJsIEFC
SSBjaGVja3MNCj4+IC0tLQ0KPj4gICBkb2NzL21hbi94bC5jZmcuNS5wb2QuaW4gICAgICAgICAg
ICAgIHwgMTAgKysrKysrKysrKw0KPj4gICBkb2NzL21hbi94bC5jb25mLjUucG9kLmluICAgICAg
ICAgICAgIHwgMTIgKysrKysrKysrKysrDQo+PiAgIHRvb2xzL2dvbGFuZy94ZW5saWdodC9oZWxw
ZXJzLmdlbi5nbyAgfCAxMiArKysrKysrKysrKysNCj4+ICAgdG9vbHMvaW5jbHVkZS9saWJ4bC5o
ICAgICAgICAgICAgICAgICB8ICA3ICsrKysrKysNCj4+ICAgdG9vbHMvbGlicy9saWdodC9saWJ4
bF9hcmNoLmggICAgICAgICB8ICA1ICsrKy0tDQo+PiAgIHRvb2xzL2xpYnMvbGlnaHQvbGlieGxf
YXJtLmMgICAgICAgICAgfCAgNyArKysrKy0tDQo+PiAgIHRvb2xzL2xpYnMvbGlnaHQvbGlieGxf
Y3JlYXRlLmMgICAgICAgfCAyMyArKysrKysrKysrKysrKy0tLS0tLS0tLQ0KPj4gICB0b29scy9s
aWJzL2xpZ2h0L2xpYnhsX3R5cGVzLmlkbCAgICAgIHwgIDIgKysNCj4+ICAgdG9vbHMvbGlicy9s
aWdodC9saWJ4bF94ODYuYyAgICAgICAgICB8IDMxICsrKysrKysrKysrKysrKysrKysrKysrKysr
KysrLS0NCj4+ICAgdG9vbHMvb2NhbWwvbGlicy94Yy94ZW5jdHJsLm1sICAgICAgICB8ICAyICsr
DQo+PiAgIHRvb2xzL29jYW1sL2xpYnMveGMveGVuY3RybC5tbGkgICAgICAgfCAgMiArKw0KPj4g
ICB0b29scy9vY2FtbC9saWJzL3hjL3hlbmN0cmxfc3R1YnMuYyAgIHwgIDIgKy0NCj4+ICAgdG9v
bHMveGwveGwuYyAgICAgICAgICAgICAgICAgICAgICAgICB8ICA4ICsrKysrKysrDQo+PiAgIHRv
b2xzL3hsL3hsLmggICAgICAgICAgICAgICAgICAgICAgICAgfCAgMiArKw0KPj4gICB0b29scy94
bC94bF9wYXJzZS5jICAgICAgICAgICAgICAgICAgIHwgMTYgKysrKysrKysrKysrKysrKw0KPj4g
ICB4ZW4vYXJjaC94ODYvZG9tYWluLmMgICAgICAgICAgICAgICAgIHwgMjggKysrKysrKysrKysr
KysrKysrKysrKysrKysrLQ0KPj4gICB4ZW4vYXJjaC94ODYvaHZtL3ZteC92bWNzLmMgICAgICAg
ICAgIHwgIDQgKysrKw0KPj4gICB4ZW4vYXJjaC94ODYvaHZtL3ZteC92bXguYyAgICAgICAgICAg
IHwgMTQgKysrKystLS0tLS0tLS0NCj4+ICAgeGVuL2FyY2gveDg2L2luY2x1ZGUvYXNtL2h2bS9k
b21haW4uaCB8ICA2ICsrKysrKw0KPj4gICB4ZW4vYXJjaC94ODYvdHJhcHMuYyAgICAgICAgICAg
ICAgICAgIHwgIDggKysrKy0tLS0NCj4+ICAgeGVuL2luY2x1ZGUvcHVibGljL2FyY2gteDg2L3hl
bi5oICAgICB8ICAyICsrDQo+PiAgIDIxIGZpbGVzIGNoYW5nZWQsIDE3MyBpbnNlcnRpb25zKCsp
LCAzMCBkZWxldGlvbnMoLSkNCj4+DQo+PiBkaWZmIC0tZ2l0IGEvZG9jcy9tYW4veGwuY2ZnLjUu
cG9kLmluIGIvZG9jcy9tYW4veGwuY2ZnLjUucG9kLmluDQo+PiBpbmRleCBiOThkMTYxMzk4Li4x
ZDk4YmJkMTgyIDEwMDY0NA0KPj4gLS0tIGEvZG9jcy9tYW4veGwuY2ZnLjUucG9kLmluDQo+PiAr
KysgYi9kb2NzL21hbi94bC5jZmcuNS5wb2QuaW4NCj4+IEBAIC0xODYyLDYgKzE4NjIsMTYgQEAg
ZmlybXdhcmUgdGFibGVzIHdoZW4gdXNpbmcgY2VydGFpbiBvbGRlciBndWVzdCBPcGVyYXRpbmcN
Cj4+ICAgU3lzdGVtcy4gVGhlc2UgdGFibGVzIGhhdmUgYmVlbiBzdXBlcnNlZGVkIGJ5IG5ld2Vy
IGNvbnN0cnVjdHMgd2l0aGluDQo+PiAgIHRoZSBBQ1BJIHRhYmxlcy4NCj4+ICAgDQo+PiArPWl0
ZW0gQjxhc3Npc3RlZF94QVBJQz1CT09MRUFOPg0KPj4gK0I8KHg4NiBvbmx5KT4gRW5hYmxlcyBv
ciBkaXNhYmxlcyBoYXJkd2FyZSBhc3Npc3RlZCB2aXJ0dWFsaXphdGlvbiBmb3IgeGFwaWMuDQo+
PiArVGhpcyBhbGxvd3MgYWNjZXNzaW5nIEFQSUMgcmVnaXN0ZXJzIHdpdGhvdXQgYSBWTS1leGl0
Lg0KPj4gK1RoZSBkZWZhdWx0IGlzIHNldHRhYmxlIHZpYSBMPHhsLmNvbmYoNSk+Lg0KPj4gKw0K
Pj4gKz1pdGVtIEI8YXNzaXN0ZWRfeDJBUElDPUJPT0xFQU4+DQo+PiArQjwoeDg2IG9ubHkpPiBF
bmFibGVzIG9yIGRpc2FibGVzIGhhcmR3YXJlIGFzc2lzdGVkIHZpcnR1YWxpemF0aW9uIGZvciB4
MmFwaWMuDQo+PiArVGhpcyBhbGxvd3MgYWNjZXNzaW5nIEFQSUMgcmVnaXN0ZXJzIHdpdGhvdXQg
YSBWTS1leGl0Lg0KPj4gK1RoZSBkZWZhdWx0IGlzIHNldHRhYmxlIHZpYSBMPHhsLmNvbmYoNSk+
Lg0KPj4gKw0KPj4gICA9aXRlbSBCPG54PUJPT0xFQU4+DQo+PiAgIA0KPj4gICBCPCh4ODYgb25s
eSk+IEhpZGVzIG9yIGV4cG9zZXMgdGhlIE5vLWVYZWN1dGUgY2FwYWJpbGl0eS4gVGhpcyBhbGxv
d3MgYSBndWVzdA0KPj4gZGlmZiAtLWdpdCBhL2RvY3MvbWFuL3hsLmNvbmYuNS5wb2QuaW4gYi9k
b2NzL21hbi94bC5jb25mLjUucG9kLmluDQo+PiBpbmRleCBkZjIwYzA4MTM3Li4zMDk5MzgyN2U1
IDEwMDY0NA0KPj4gLS0tIGEvZG9jcy9tYW4veGwuY29uZi41LnBvZC5pbg0KPj4gKysrIGIvZG9j
cy9tYW4veGwuY29uZi41LnBvZC5pbg0KPj4gQEAgLTEwNyw2ICsxMDcsMTggQEAgU2V0cyB0aGUg
ZGVmYXVsdCB2YWx1ZSBmb3IgdGhlIEM8bWF4X2dyYW50X3ZlcnNpb24+IGRvbWFpbiBjb25maWcg
dmFsdWUuDQo+PiAgIA0KPj4gICBEZWZhdWx0OiBtYXhpbXVtIGdyYW50IHZlcnNpb24gc3VwcG9y
dGVkIGJ5IHRoZSBoeXBlcnZpc29yLg0KPj4gICANCj4+ICs9aXRlbSBCPGFzc2lzdGVkX3hBUElD
PUJPT0xFQU4+DQo+PiArDQo+PiArSWYgZW5hYmxlZCwgZG9tYWlucyB3aWxsIHVzZSB4QVBJQyBo
YXJkd2FyZSBhc3Npc3RlZCB2aXJ0dWFsaXphdGlvbiBieSBkZWZhdWx0Lg0KPj4gKw0KPj4gK0Rl
ZmF1bHQ6IGVuYWJsZWQgaWYgc3VwcG9ydGVkLg0KPj4gKw0KPj4gKz1pdGVtIEI8YXNzaXN0ZWRf
eDJBUElDPUJPT0xFQU4+DQo+PiArDQo+PiArSWYgZW5hYmxlZCwgZG9tYWlucyB3aWxsIHVzZSB4
MkFQSUMgaGFyZHdhcmUgYXNzaXN0ZWQgdmlydHVhbGl6YXRpb24gYnkgZGVmYXVsdC4NCj4+ICsN
Cj4+ICtEZWZhdWx0OiBlbmFibGVkIGlmIHN1cHBvcnRlZC4NCj4gDQo+IFdlIGRvbid0IGNhcGl0
YWxpemUgeGwgb3B0aW9ucywgc28gSSB3b3VsZCBzdWdnZXN0IHRvIGxvd2VyY2FzZSBBUElDDQo+
IGZvciBhbGwgdGhlIG9wdGlvbiBuYW1lcy4NCk9rYXkuDQo+IA0KPj4gKw0KPj4gICA9aXRlbSBC
PHZpZi5kZWZhdWx0LnNjcmlwdD0iUEFUSCI+DQo+PiAgIA0KPj4gICBDb25maWd1cmVzIHRoZSBk
ZWZhdWx0IGhvdHBsdWcgc2NyaXB0IHVzZWQgYnkgdmlydHVhbCBuZXR3b3JrIGRldmljZXMuDQo+
PiBkaWZmIC0tZ2l0IGEvdG9vbHMvZ29sYW5nL3hlbmxpZ2h0L2hlbHBlcnMuZ2VuLmdvIGIvdG9v
bHMvZ29sYW5nL3hlbmxpZ2h0L2hlbHBlcnMuZ2VuLmdvDQo+PiBpbmRleCBkZDRlNmM5ZjE0Li45
MGU3YjliMjA1IDEwMDY0NA0KPj4gLS0tIGEvdG9vbHMvZ29sYW5nL3hlbmxpZ2h0L2hlbHBlcnMu
Z2VuLmdvDQo+PiArKysgYi90b29scy9nb2xhbmcveGVubGlnaHQvaGVscGVycy5nZW4uZ28NCj4+
IEBAIC02MzYsNiArNjM2LDEyIEBAIHguUGFzc3Rocm91Z2ggPSBQYXNzdGhyb3VnaCh4Yy5wYXNz
dGhyb3VnaCkNCj4+ICAgaWYgZXJyIDo9IHguWGVuZFN1c3BlbmRFdnRjaG5Db21wYXQuZnJvbUMo
JnhjLnhlbmRfc3VzcGVuZF9ldnRjaG5fY29tcGF0KTtlcnIgIT0gbmlsIHsNCj4+ICAgcmV0dXJu
IGZtdC5FcnJvcmYoImNvbnZlcnRpbmcgZmllbGQgWGVuZFN1c3BlbmRFdnRjaG5Db21wYXQ6ICV2
IiwgZXJyKQ0KPj4gICB9DQo+PiAraWYgZXJyIDo9IHguQXJjaFg4Ni5Bc3Npc3RlZFhhcGljLmZy
b21DKCZ4Yy5hcmNoX3g4Ni5hc3Npc3RlZF94YXBpYyk7ZXJyICE9IG5pbCB7DQo+PiArcmV0dXJu
IGZtdC5FcnJvcmYoImNvbnZlcnRpbmcgZmllbGQgQXJjaFg4Ni5Bc3Npc3RlZFhhcGljOiAldiIs
IGVycikNCj4+ICt9DQo+PiAraWYgZXJyIDo9IHguQXJjaFg4Ni5Bc3Npc3RlZFgyQXBpYy5mcm9t
QygmeGMuYXJjaF94ODYuYXNzaXN0ZWRfeDJhcGljKTtlcnIgIT0gbmlsIHsNCj4+ICtyZXR1cm4g
Zm10LkVycm9yZigiY29udmVydGluZyBmaWVsZCBBcmNoWDg2LkFzc2lzdGVkWDJBcGljOiAldiIs
IGVycikNCj4+ICt9DQo+PiAgIA0KPj4gICAgcmV0dXJuIG5pbH0NCj4+ICAgDQo+PiBAQCAtNjc5
LDYgKzY4NSwxMiBAQCB4Yy5wYXNzdGhyb3VnaCA9IEMubGlieGxfcGFzc3Rocm91Z2goeC5QYXNz
dGhyb3VnaCkNCj4+ICAgaWYgZXJyIDo9IHguWGVuZFN1c3BlbmRFdnRjaG5Db21wYXQudG9DKCZ4
Yy54ZW5kX3N1c3BlbmRfZXZ0Y2huX2NvbXBhdCk7IGVyciAhPSBuaWwgew0KPj4gICByZXR1cm4g
Zm10LkVycm9yZigiY29udmVydGluZyBmaWVsZCBYZW5kU3VzcGVuZEV2dGNobkNvbXBhdDogJXYi
LCBlcnIpDQo+PiAgIH0NCj4+ICtpZiBlcnIgOj0geC5BcmNoWDg2LkFzc2lzdGVkWGFwaWMudG9D
KCZ4Yy5hcmNoX3g4Ni5hc3Npc3RlZF94YXBpYyk7IGVyciAhPSBuaWwgew0KPj4gK3JldHVybiBm
bXQuRXJyb3JmKCJjb252ZXJ0aW5nIGZpZWxkIEFyY2hYODYuQXNzaXN0ZWRYYXBpYzogJXYiLCBl
cnIpDQo+PiArfQ0KPj4gK2lmIGVyciA6PSB4LkFyY2hYODYuQXNzaXN0ZWRYMkFwaWMudG9DKCZ4
Yy5hcmNoX3g4Ni5hc3Npc3RlZF94MmFwaWMpOyBlcnIgIT0gbmlsIHsNCj4+ICtyZXR1cm4gZm10
LkVycm9yZigiY29udmVydGluZyBmaWVsZCBBcmNoWDg2LkFzc2lzdGVkWDJBcGljOiAldiIsIGVy
cikNCj4+ICt9DQo+PiAgIA0KPj4gICAgcmV0dXJuIG5pbA0KPj4gICAgfQ0KPj4gZGlmZiAtLWdp
dCBhL3Rvb2xzL2luY2x1ZGUvbGlieGwuaCBiL3Rvb2xzL2luY2x1ZGUvbGlieGwuaA0KPj4gaW5k
ZXggOTI0ZTE0MjYyOC4uODM5NDRjMTdhZSAxMDA2NDQNCj4+IC0tLSBhL3Rvb2xzL2luY2x1ZGUv
bGlieGwuaA0KPj4gKysrIGIvdG9vbHMvaW5jbHVkZS9saWJ4bC5oDQo+PiBAQCAtNTM1LDYgKzUz
NSwxMyBAQA0KPj4gICAjZGVmaW5lIExJQlhMX0hBVkVfUEhZU0lORk9fQVNTSVNURURfQVBJQyAx
DQo+PiAgIA0KPj4gICAvKg0KPj4gKyAqIExJQlhMX0hBVkVfQVNTSVNURURfQVBJQyBpbmRpY2F0
ZXMgdGhhdCBsaWJ4bF9kb21haW5fYnVpbGRfaW5mbyBoYXMNCj4+ICsgKiBhc3Npc3RlZF94ezJ9
YXBpYyBmaWVsZHMsIGZvciBlbmFibGluZyBoYXJkd2FyZSBhc3Npc3RlZCB2aXJ0dWFsaXphdGlv
biBmb3INCj4+ICsgKiB4ezJ9YXBpYyBwZXIgZG9tYWluLg0KPj4gKyAqLw0KPj4gKyNkZWZpbmUg
TElCWExfSEFWRV9BU1NJU1RFRF9BUElDIDENCj4+ICsNCj4+ICsvKg0KPj4gICAgKiBsaWJ4bCBB
QkkgY29tcGF0aWJpbGl0eQ0KPj4gICAgKg0KPj4gICAgKiBUaGUgb25seSBndWFyYW50ZWUgd2hp
Y2ggbGlieGwgbWFrZXMgcmVnYXJkaW5nIEFCSSBjb21wYXRpYmlsaXR5DQo+PiBkaWZmIC0tZ2l0
IGEvdG9vbHMvbGlicy9saWdodC9saWJ4bF9hcmNoLmggYi90b29scy9saWJzL2xpZ2h0L2xpYnhs
X2FyY2guaA0KPj4gaW5kZXggMjA3Y2VhYzZhMS4uMDNiODk5MjllNiAxMDA2NDQNCj4+IC0tLSBh
L3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfYXJjaC5oDQo+PiArKysgYi90b29scy9saWJzL2xpZ2h0
L2xpYnhsX2FyY2guaA0KPj4gQEAgLTcxLDggKzcxLDkgQEAgdm9pZCBsaWJ4bF9fYXJjaF9kb21h
aW5fY3JlYXRlX2luZm9fc2V0ZGVmYXVsdChsaWJ4bF9fZ2MgKmdjLA0KPj4gICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGxpYnhsX2RvbWFpbl9jcmVhdGVf
aW5mbyAqY19pbmZvKTsNCj4+ICAgDQo+PiAgIF9oaWRkZW4NCj4+IC12b2lkIGxpYnhsX19hcmNo
X2RvbWFpbl9idWlsZF9pbmZvX3NldGRlZmF1bHQobGlieGxfX2djICpnYywNCj4+IC0gICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbGlieGxfZG9tYWluX2J1aWxk
X2luZm8gKmJfaW5mbyk7DQo+PiAraW50IGxpYnhsX19hcmNoX2RvbWFpbl9idWlsZF9pbmZvX3Nl
dGRlZmF1bHQobGlieGxfX2djICpnYywNCj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICBsaWJ4bF9kb21haW5fYnVpbGRfaW5mbyAqYl9pbmZvLA0KPj4gKyAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IGxpYnhsX3Bo
eXNpbmZvICpwaHlzaW5mbyk7DQo+PiAgIA0KPj4gICBfaGlkZGVuDQo+PiAgIGludCBsaWJ4bF9f
YXJjaF9wYXNzdGhyb3VnaF9tb2RlX3NldGRlZmF1bHQobGlieGxfX2djICpnYywNCj4+IGRpZmYg
LS1naXQgYS90b29scy9saWJzL2xpZ2h0L2xpYnhsX2FybS5jIGIvdG9vbHMvbGlicy9saWdodC9s
aWJ4bF9hcm0uYw0KPj4gaW5kZXggMzlmZGNhMWI0OS4uYmE1YjhmNDMzZiAxMDA2NDQNCj4+IC0t
LSBhL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfYXJtLmMNCj4+ICsrKyBiL3Rvb2xzL2xpYnMvbGln
aHQvbGlieGxfYXJtLmMNCj4+IEBAIC0xMzg0LDggKzEzODQsOSBAQCB2b2lkIGxpYnhsX19hcmNo
X2RvbWFpbl9jcmVhdGVfaW5mb19zZXRkZWZhdWx0KGxpYnhsX19nYyAqZ2MsDQo+PiAgICAgICB9
DQo+PiAgIH0NCj4+ICAgDQo+PiAtdm9pZCBsaWJ4bF9fYXJjaF9kb21haW5fYnVpbGRfaW5mb19z
ZXRkZWZhdWx0KGxpYnhsX19nYyAqZ2MsDQo+PiAtICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgIGxpYnhsX2RvbWFpbl9idWlsZF9pbmZvICpiX2luZm8pDQo+PiAr
aW50IGxpYnhsX19hcmNoX2RvbWFpbl9idWlsZF9pbmZvX3NldGRlZmF1bHQobGlieGxfX2djICpn
YywNCj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBsaWJ4
bF9kb21haW5fYnVpbGRfaW5mbyAqYl9pbmZvLA0KPj4gKyAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IGxpYnhsX3BoeXNpbmZvICpwaHlzaW5mbykNCj4+
ICAgew0KPj4gICAgICAgLyogQUNQSSBpcyBkaXNhYmxlZCBieSBkZWZhdWx0ICovDQo+PiAgICAg
ICBsaWJ4bF9kZWZib29sX3NldGRlZmF1bHQoJmJfaW5mby0+YWNwaSwgZmFsc2UpOw0KPj4gQEAg
LTEzOTksNiArMTQwMCw4IEBAIHZvaWQgbGlieGxfX2FyY2hfZG9tYWluX2J1aWxkX2luZm9fc2V0
ZGVmYXVsdChsaWJ4bF9fZ2MgKmdjLA0KPj4gICAgICAgbWVtc2V0KCZiX2luZm8tPnUsICdcMCcs
IHNpemVvZihiX2luZm8tPnUpKTsNCj4+ICAgICAgIGJfaW5mby0+dHlwZSA9IExJQlhMX0RPTUFJ
Tl9UWVBFX0lOVkFMSUQ7DQo+PiAgICAgICBsaWJ4bF9kb21haW5fYnVpbGRfaW5mb19pbml0X3R5
cGUoYl9pbmZvLCBMSUJYTF9ET01BSU5fVFlQRV9QVkgpOw0KPj4gKw0KPj4gKyAgICByZXR1cm4g
MDsNCj4+ICAgfQ0KPj4gICANCj4+ICAgaW50IGxpYnhsX19hcmNoX3Bhc3N0aHJvdWdoX21vZGVf
c2V0ZGVmYXVsdChsaWJ4bF9fZ2MgKmdjLA0KPj4gZGlmZiAtLWdpdCBhL3Rvb2xzL2xpYnMvbGln
aHQvbGlieGxfY3JlYXRlLmMgYi90b29scy9saWJzL2xpZ2h0L2xpYnhsX2NyZWF0ZS5jDQo+PiBp
bmRleCBkN2E0MGQ3NTUwLi44NDNlNTIzZGY5IDEwMDY0NA0KPj4gLS0tIGEvdG9vbHMvbGlicy9s
aWdodC9saWJ4bF9jcmVhdGUuYw0KPj4gKysrIGIvdG9vbHMvbGlicy9saWdodC9saWJ4bF9jcmVh
dGUuYw0KPj4gQEAgLTI2NCw3ICsyNjQsMjAgQEAgaW50IGxpYnhsX19kb21haW5fYnVpbGRfaW5m
b19zZXRkZWZhdWx0KGxpYnhsX19nYyAqZ2MsDQo+PiAgICAgICBpZiAoIWJfaW5mby0+ZXZlbnRf
Y2hhbm5lbHMpDQo+PiAgICAgICAgICAgYl9pbmZvLT5ldmVudF9jaGFubmVscyA9IDEwMjM7DQo+
PiAgIA0KPj4gLSAgICBsaWJ4bF9fYXJjaF9kb21haW5fYnVpbGRfaW5mb19zZXRkZWZhdWx0KGdj
LCBiX2luZm8pOw0KPj4gKyAgICBsaWJ4bF9waHlzaW5mbyBpbmZvOw0KPiANCj4gVGhlIGRlZmlu
aXRpb24gb2YgaW5mbyBuZWVkcyB0byBiZSBhdCB0aGUgdG9wIG9mIHRoZSBmdW5jdGlvbiwNCj4g
dG9nZXRoZXIgd2l0aCB0aGUgcmVzdCBvZiB0aGUgdmFyaWFibGUgZGVmaW5pdGlvbnMuDQpPa2F5
Lg0KPiANCj4+ICsNCj4+ICsgICAgcmMgPSBsaWJ4bF9nZXRfcGh5c2luZm8oQ1RYLCAmaW5mbyk7
DQo+PiArICAgIGlmIChyYykgew0KPj4gKyAgICAgICAgTE9HKEVSUk9SLCAiZmFpbGVkIHRvIGdl
dCBoeXBlcnZpc29yIGluZm8iKTsNCj4+ICsgICAgICAgIHJldHVybiByYzsNCj4+ICsgICAgfQ0K
Pj4gKw0KPj4gKyAgICByYyA9IGxpYnhsX19hcmNoX2RvbWFpbl9idWlsZF9pbmZvX3NldGRlZmF1
bHQoZ2MsIGJfaW5mbywgJmluZm8pOw0KPj4gKyAgICBpZiAocmMpIHsNCj4+ICsgICAgICAgIExP
RyhFUlJPUiwgInVuYWJsZSB0byBzZXQgZG9tYWluIGFyY2ggYnVpbGQgaW5mbyBkZWZhdWx0cyIp
Ow0KPj4gKyAgICAgICAgcmV0dXJuIHJjOw0KPj4gKyAgICB9DQo+PiArDQo+PiAgICAgICBsaWJ4
bF9kZWZib29sX3NldGRlZmF1bHQoJmJfaW5mby0+ZG1fcmVzdHJpY3QsIGZhbHNlKTsNCj4+ICAg
DQo+PiAgICAgICBpZiAoYl9pbmZvLT5pb21tdV9tZW1rYiA9PSBMSUJYTF9NRU1LQl9ERUZBVUxU
KQ0KPj4gQEAgLTQ1NywxNCArNDcwLDYgQEAgaW50IGxpYnhsX19kb21haW5fYnVpbGRfaW5mb19z
ZXRkZWZhdWx0KGxpYnhsX19nYyAqZ2MsDQo+PiAgICAgICB9DQo+PiAgIA0KPj4gICAgICAgaWYg
KGJfaW5mby0+bWF4X2dyYW50X3ZlcnNpb24gPT0gTElCWExfTUFYX0dSQU5UX0RFRkFVTFQpIHsN
Cj4+IC0gICAgICAgIGxpYnhsX3BoeXNpbmZvIGluZm87DQo+PiAtDQo+PiAtICAgICAgICByYyA9
IGxpYnhsX2dldF9waHlzaW5mbyhDVFgsICZpbmZvKTsNCj4+IC0gICAgICAgIGlmIChyYykgew0K
Pj4gLSAgICAgICAgICAgIExPRyhFUlJPUiwgImZhaWxlZCB0byBnZXQgaHlwZXJ2aXNvciBpbmZv
Iik7DQo+PiAtICAgICAgICAgICAgcmV0dXJuIHJjOw0KPj4gLSAgICAgICAgfQ0KPj4gLQ0KPj4g
ICAgICAgICAgIGlmIChpbmZvLmNhcF9nbnR0YWJfdjIpDQo+PiAgICAgICAgICAgICAgIGJfaW5m
by0+bWF4X2dyYW50X3ZlcnNpb24gPSAyOw0KPj4gICAgICAgICAgIGVsc2UgaWYgKGluZm8uY2Fw
X2dudHRhYl92MSkNCj4+IGRpZmYgLS1naXQgYS90b29scy9saWJzL2xpZ2h0L2xpYnhsX3R5cGVz
LmlkbCBiL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfdHlwZXMuaWRsDQo+PiBpbmRleCA0MmFjNmMz
NTdiLi5kYjVlYjBhMGIzIDEwMDY0NA0KPj4gLS0tIGEvdG9vbHMvbGlicy9saWdodC9saWJ4bF90
eXBlcy5pZGwNCj4+ICsrKyBiL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfdHlwZXMuaWRsDQo+PiBA
QCAtNjQ4LDYgKzY0OCw4IEBAIGxpYnhsX2RvbWFpbl9idWlsZF9pbmZvID0gU3RydWN0KCJkb21h
aW5fYnVpbGRfaW5mbyIsWw0KPj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKCJ2
dWFydCIsIGxpYnhsX3Z1YXJ0X3R5cGUpLA0KPj4gICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICBdKSksDQo+PiAgICAgICAoImFyY2hfeDg2IiwgU3RydWN0KE5vbmUsIFsoIm1zcl9yZWxh
eGVkIiwgbGlieGxfZGVmYm9vbCksDQo+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICgiYXNzaXN0ZWRfeGFwaWMiLCBsaWJ4bF9kZWZib29sKSwNCj4+ICsgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgKCJhc3Npc3RlZF94MmFwaWMiLCBsaWJ4bF9kZWZib29sKSwNCj4+ICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXSkpLA0KPj4gICAgICAgIyBBbHRlcm5hdGUg
cDJtIGlzIG5vdCBib3VuZCB0byBhbnkgYXJjaGl0ZWN0dXJlIG9yIGd1ZXN0IHR5cGUsIGFzIGl0
IGlzDQo+PiAgICAgICAjIHN1cHBvcnRlZCBieSB4ODYgSFZNIGFuZCBBUk0gc3VwcG9ydCBpcyBw
bGFubmVkLg0KPj4gZGlmZiAtLWdpdCBhL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfeDg2LmMgYi90
b29scy9saWJzL2xpZ2h0L2xpYnhsX3g4Ni5jDQo+PiBpbmRleCBlMGEwNmVjZmUzLi5mMGZhMGNl
ZWEyIDEwMDY0NA0KPj4gLS0tIGEvdG9vbHMvbGlicy9saWdodC9saWJ4bF94ODYuYw0KPj4gKysr
IGIvdG9vbHMvbGlicy9saWdodC9saWJ4bF94ODYuYw0KPj4gQEAgLTIzLDYgKzIzLDE0IEBAIGlu
dCBsaWJ4bF9fYXJjaF9kb21haW5fcHJlcGFyZV9jb25maWcobGlieGxfX2djICpnYywNCj4+ICAg
ICAgIGlmIChsaWJ4bF9kZWZib29sX3ZhbChkX2NvbmZpZy0+Yl9pbmZvLmFyY2hfeDg2Lm1zcl9y
ZWxheGVkKSkNCj4+ICAgICAgICAgICBjb25maWctPmFyY2gubWlzY19mbGFncyB8PSBYRU5fWDg2
X01TUl9SRUxBWEVEOw0KPj4gICANCj4+ICsgICAgaWYgKGRfY29uZmlnLT5jX2luZm8udHlwZSAh
PSBMSUJYTF9ET01BSU5fVFlQRV9QVikNCj4+ICsgICAgew0KPiANCj4gQ29kaW5nIHN0eWxlIGZv
ciBsaWJ4bCBpcyB0byBwbGFjZSB0aGUgYnJhY2tldCBpbiB0aGUgc2FtZSBsaW5lIGFzIHRoZQ0K
PiBpZi4NCk9rYXkuDQo+IA0KPj4gKyAgICAgICAgaWYgKGxpYnhsX2RlZmJvb2xfdmFsKGRfY29u
ZmlnLT5iX2luZm8uYXJjaF94ODYuYXNzaXN0ZWRfeGFwaWMpKQ0KPj4gKyAgICAgICAgICAgIGNv
bmZpZy0+YXJjaC5taXNjX2ZsYWdzIHw9IFhFTl9YODZfQVNTSVNURURfWEFQSUM7DQo+PiArDQo+
PiArICAgICAgICBpZiAobGlieGxfZGVmYm9vbF92YWwoZF9jb25maWctPmJfaW5mby5hcmNoX3g4
Ni5hc3Npc3RlZF94MmFwaWMpKQ0KPj4gKyAgICAgICAgICAgIGNvbmZpZy0+YXJjaC5taXNjX2Zs
YWdzIHw9IFhFTl9YODZfQVNTSVNURURfWDJBUElDOw0KPj4gKyAgICB9DQo+PiAgICAgICByZXR1
cm4gMDsNCj4+ICAgfQ0KPj4gICANCj4+IEBAIC04MTksMTEgKzgyNywzMCBAQCB2b2lkIGxpYnhs
X19hcmNoX2RvbWFpbl9jcmVhdGVfaW5mb19zZXRkZWZhdWx0KGxpYnhsX19nYyAqZ2MsDQo+PiAg
IHsNCj4+ICAgfQ0KPj4gICANCj4+IC12b2lkIGxpYnhsX19hcmNoX2RvbWFpbl9idWlsZF9pbmZv
X3NldGRlZmF1bHQobGlieGxfX2djICpnYywNCj4+IC0gICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgbGlieGxfZG9tYWluX2J1aWxkX2luZm8gKmJfaW5mbykNCj4+
ICtpbnQgbGlieGxfX2FyY2hfZG9tYWluX2J1aWxkX2luZm9fc2V0ZGVmYXVsdChsaWJ4bF9fZ2Mg
KmdjLA0KPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGxp
YnhsX2RvbWFpbl9idWlsZF9pbmZvICpiX2luZm8sDQo+PiArICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgY29uc3QgbGlieGxfcGh5c2luZm8gKnBoeXNpbmZvKQ0K
Pj4gICB7DQo+PiAgICAgICBsaWJ4bF9kZWZib29sX3NldGRlZmF1bHQoJmJfaW5mby0+YWNwaSwg
dHJ1ZSk7DQo+PiAgICAgICBsaWJ4bF9kZWZib29sX3NldGRlZmF1bHQoJmJfaW5mby0+YXJjaF94
ODYubXNyX3JlbGF4ZWQsIGZhbHNlKTsNCj4+ICsNCj4+ICsgICAgaWYgKGJfaW5mby0+dHlwZSAh
PSBMSUJYTF9ET01BSU5fVFlQRV9QVikNCj4+ICsgICAgew0KPj4gKyAgICAgICAgbGlieGxfZGVm
Ym9vbF9zZXRkZWZhdWx0KCZiX2luZm8tPmFyY2hfeDg2LmFzc2lzdGVkX3hhcGljLA0KPj4gKyAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgcGh5c2luZm8tPmNhcF9hc3Npc3RlZF94YXBpYyk7
DQo+PiArICAgICAgICBsaWJ4bF9kZWZib29sX3NldGRlZmF1bHQoJmJfaW5mby0+YXJjaF94ODYu
YXNzaXN0ZWRfeDJhcGljLA0KPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcGh5c2lu
Zm8tPmNhcF9hc3Npc3RlZF94MmFwaWMpOw0KPj4gKyAgICB9DQo+PiArDQo+PiArICAgIGlmIChi
X2luZm8tPnR5cGUgPT0gTElCWExfRE9NQUlOX1RZUEVfUFYgJiYNCj4+ICsgICAgICAgICghbGli
eGxfZGVmYm9vbF9pc19kZWZhdWx0KGJfaW5mby0+YXJjaF94ODYuYXNzaXN0ZWRfeGFwaWMpIHx8
DQo+PiArICAgICAgICAgIWxpYnhsX2RlZmJvb2xfaXNfZGVmYXVsdChiX2luZm8tPmFyY2hfeDg2
LmFzc2lzdGVkX3gyYXBpYykpKQ0KPiANCj4gWW91IGNvdWxkIGp1c3QgZG86DQo+IA0KPiAgICAg
IGlmIChiX2luZm8tPnR5cGUgIT0gTElCWExfRE9NQUlOX1RZUEVfUFYpIHsNCj4gICAgICAgICAg
bGlieGxfZGVmYm9vbF9zZXRkZWZhdWx0KCZiX2luZm8tPmFyY2hfeDg2LmFzc2lzdGVkX3hhcGlj
LA0KPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwaHlzaW5mby0+Y2FwX2Fzc2lzdGVk
X3hhcGljKTsNCj4gICAgICAgICAgbGlieGxfZGVmYm9vbF9zZXRkZWZhdWx0KCZiX2luZm8tPmFy
Y2hfeDg2LmFzc2lzdGVkX3gyYXBpYywNCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
cGh5c2luZm8tPmNhcF9hc3Npc3RlZF94MmFwaWMpOw0KPiAgICAgIH0gZWxzZSBpZiAoIWxpYnhs
X2RlZmJvb2xfaXNfZGVmYXVsdChiX2luZm8tPmFyY2hfeDg2LmFzc2lzdGVkX3hhcGljKSB8fA0K
PiAgICAgICAgICAgICAgICAgIWxpYnhsX2RlZmJvb2xfaXNfZGVmYXVsdChiX2luZm8tPmFyY2hf
eDg2LmFzc2lzdGVkX3gyYXBpYykpDQo+ICAgICAgICAgIC8qIEVSUk9SICovDQo+IA0KPj4gKyAg
ICB7DQo+PiArICAgICAgICBMT0coRVJST1IsICJJbnRlcnJ1cHQgQ29udHJvbGxlciBWaXJ0dWFs
aXphdGlvbiBub3Qgc3VwcG9ydGVkIGZvciBQViIpOw0KPj4gKyAgICAgICAgcmV0dXJuIEVSUk9S
X0lOVkFMOw0KPj4gKyAgICB9DQo+PiArDQo+PiArICAgIHJldHVybiAwOw0KVHJ1ZS4NCj4+ICAg
fQ0KPj4gICANCj4+ICAgaW50IGxpYnhsX19hcmNoX3Bhc3N0aHJvdWdoX21vZGVfc2V0ZGVmYXVs
dChsaWJ4bF9fZ2MgKmdjLA0KPj4gZGlmZiAtLWdpdCBhL3Rvb2xzL29jYW1sL2xpYnMveGMveGVu
Y3RybC5tbCBiL3Rvb2xzL29jYW1sL2xpYnMveGMveGVuY3RybC5tbA0KPj4gaW5kZXggN2NlODMy
ZDYwNS4uY2NlMzBkODczMSAxMDA2NDQNCj4+IC0tLSBhL3Rvb2xzL29jYW1sL2xpYnMveGMveGVu
Y3RybC5tbA0KPj4gKysrIGIvdG9vbHMvb2NhbWwvbGlicy94Yy94ZW5jdHJsLm1sDQo+PiBAQCAt
NTAsNiArNTAsOCBAQCB0eXBlIHg4Nl9hcmNoX2VtdWxhdGlvbl9mbGFncyA9DQo+PiAgIA0KPj4g
ICB0eXBlIHg4Nl9hcmNoX21pc2NfZmxhZ3MgPQ0KPj4gICAJfCBYODZfTVNSX1JFTEFYRUQNCj4+
ICsJfCBYODZfQVNTSVNURURfWEFQSUMNCj4+ICsJfCBYODZfQVNTSVNURURfWDJBUElDDQo+PiAg
IA0KPj4gICB0eXBlIHhlbl94ODZfYXJjaF9kb21haW5jb25maWcgPQ0KPj4gICB7DQo+PiBkaWZm
IC0tZ2l0IGEvdG9vbHMvb2NhbWwvbGlicy94Yy94ZW5jdHJsLm1saSBiL3Rvb2xzL29jYW1sL2xp
YnMveGMveGVuY3RybC5tbGkNCj4+IGluZGV4IGEyYjE1MTMwZWUuLjY3YTIyZWMxNWMgMTAwNjQ0
DQo+PiAtLS0gYS90b29scy9vY2FtbC9saWJzL3hjL3hlbmN0cmwubWxpDQo+PiArKysgYi90b29s
cy9vY2FtbC9saWJzL3hjL3hlbmN0cmwubWxpDQo+PiBAQCAtNDQsNiArNDQsOCBAQCB0eXBlIHg4
Nl9hcmNoX2VtdWxhdGlvbl9mbGFncyA9DQo+PiAgIA0KPj4gICB0eXBlIHg4Nl9hcmNoX21pc2Nf
ZmxhZ3MgPQ0KPj4gICAgIHwgWDg2X01TUl9SRUxBWEVEDQo+PiArICB8IFg4Nl9BU1NJU1RFRF9Y
QVBJQw0KPj4gKyAgfCBYODZfQVNTSVNURURfWDJBUElDDQo+PiAgIA0KPj4gICB0eXBlIHhlbl94
ODZfYXJjaF9kb21haW5jb25maWcgPSB7DQo+PiAgICAgZW11bGF0aW9uX2ZsYWdzOiB4ODZfYXJj
aF9lbXVsYXRpb25fZmxhZ3MgbGlzdDsNCj4+IGRpZmYgLS1naXQgYS90b29scy9vY2FtbC9saWJz
L3hjL3hlbmN0cmxfc3R1YnMuYyBiL3Rvb2xzL29jYW1sL2xpYnMveGMveGVuY3RybF9zdHVicy5j
DQo+PiBpbmRleCA1YjRmZTcyYzhkLi4wYWE5NTdkMzc5IDEwMDY0NA0KPj4gLS0tIGEvdG9vbHMv
b2NhbWwvbGlicy94Yy94ZW5jdHJsX3N0dWJzLmMNCj4+ICsrKyBiL3Rvb2xzL29jYW1sL2xpYnMv
eGMveGVuY3RybF9zdHVicy5jDQo+PiBAQCAtMjM5LDcgKzIzOSw3IEBAIENBTUxwcmltIHZhbHVl
IHN0dWJfeGNfZG9tYWluX2NyZWF0ZSh2YWx1ZSB4Y2gsIHZhbHVlIHdhbnRlZF9kb21pZCwgdmFs
dWUgY29uZmlnDQo+PiAgIA0KPj4gICAJCWNmZy5hcmNoLm1pc2NfZmxhZ3MgPSBvY2FtbF9saXN0
X3RvX2NfYml0bWFwDQo+PiAgIAkJCS8qICEgeDg2X2FyY2hfbWlzY19mbGFncyBYODZfIG5vbmUg
Ki8NCj4+IC0JCQkvKiAhIFhFTl9YODZfIFhFTl9YODZfTVNSX1JFTEFYRUQgYWxsICovDQo+PiAr
CQkJLyogISBYRU5fWDg2XyBYRU5fWDg2X0FTU0lTVEVEX1gyQVBJQyBtYXggKi8NCj4gDQo+IFdl
IHdvdWxkIHVzdWFsbHkgZGVmaW5lIGFuIFhFTl9YODZfTUlTQ19NQVggdGhhdCB3b3VsZCBwb2lu
dCB0bw0KPiBYRU5fWDg2X0FTU0lTVEVEX1gyQVBJQyBjdXJyZW50bHkuDQo+IA0KPj4gICAJCQko
VkFMX01JU0NfRkxBR1MpOw0KPj4gICANCj4+ICAgI3VuZGVmIFZBTF9NSVNDX0ZMQUdTDQo+PiBk
aWZmIC0tZ2l0IGEvdG9vbHMveGwveGwuYyBiL3Rvb2xzL3hsL3hsLmMNCj4+IGluZGV4IDJkMWVj
MThlYTMuLjMxZWIyMjMzMDkgMTAwNjQ0DQo+PiAtLS0gYS90b29scy94bC94bC5jDQo+PiArKysg
Yi90b29scy94bC94bC5jDQo+PiBAQCAtNTcsNiArNTcsOCBAQCBpbnQgbWF4X2dyYW50X2ZyYW1l
cyA9IC0xOw0KPj4gICBpbnQgbWF4X21hcHRyYWNrX2ZyYW1lcyA9IC0xOw0KPj4gICBpbnQgbWF4
X2dyYW50X3ZlcnNpb24gPSBMSUJYTF9NQVhfR1JBTlRfREVGQVVMVDsNCj4+ICAgbGlieGxfZG9t
aWQgZG9taWRfcG9saWN5ID0gSU5WQUxJRF9ET01JRDsNCj4+ICtpbnQgYXNzaXN0ZWRfeGFwaWMg
PSAtMTsNCj4+ICtpbnQgYXNzaXN0ZWRfeDJhcGljID0gLTE7DQo+PiAgIA0KPj4gICB4ZW50b29s
bG9nX2xldmVsIG1pbm1zZ2xldmVsID0gbWlubXNnbGV2ZWxfZGVmYXVsdDsNCj4+ICAgDQo+PiBA
QCAtMjAxLDYgKzIwMywxMiBAQCBzdGF0aWMgdm9pZCBwYXJzZV9nbG9iYWxfY29uZmlnKGNvbnN0
IGNoYXIgKmNvbmZpZ2ZpbGUsDQo+PiAgICAgICBpZiAoIXhsdV9jZmdfZ2V0X2xvbmcgKGNvbmZp
ZywgImNsYWltX21vZGUiLCAmbCwgMCkpDQo+PiAgICAgICAgICAgY2xhaW1fbW9kZSA9IGw7DQo+
PiAgIA0KPj4gKyAgICBpZiAoIXhsdV9jZmdfZ2V0X2xvbmcgKGNvbmZpZywgImFzc2lzdGVkX3hh
cGljIiwgJmwsIDApKQ0KPj4gKyAgICAgICAgYXNzaXN0ZWRfeGFwaWMgPSBsOw0KPj4gKw0KPj4g
KyAgICBpZiAoIXhsdV9jZmdfZ2V0X2xvbmcgKGNvbmZpZywgImFzc2lzdGVkX3gyYXBpYyIsICZs
LCAwKSkNCj4+ICsgICAgICAgIGFzc2lzdGVkX3gyYXBpYyA9IGw7DQo+PiArDQo+PiAgICAgICB4
bHVfY2ZnX3JlcGxhY2Vfc3RyaW5nIChjb25maWcsICJyZW11cy5kZWZhdWx0Lm5ldGJ1ZnNjcmlw
dCIsDQo+PiAgICAgICAgICAgJmRlZmF1bHRfcmVtdXNfbmV0YnVmc2NyaXB0LCAwKTsNCj4+ICAg
ICAgIHhsdV9jZmdfcmVwbGFjZV9zdHJpbmcgKGNvbmZpZywgImNvbG8uZGVmYXVsdC5wcm94eXNj
cmlwdCIsDQo+PiBkaWZmIC0tZ2l0IGEvdG9vbHMveGwveGwuaCBiL3Rvb2xzL3hsL3hsLmgNCj4+
IGluZGV4IGM1YzRiZWRiZGQuLjUyOGRlYjNmZWIgMTAwNjQ0DQo+PiAtLS0gYS90b29scy94bC94
bC5oDQo+PiArKysgYi90b29scy94bC94bC5oDQo+PiBAQCAtMjg2LDYgKzI4Niw4IEBAIGV4dGVy
biBsaWJ4bF9iaXRtYXAgZ2xvYmFsX3ZtX2FmZmluaXR5X21hc2s7DQo+PiAgIGV4dGVybiBsaWJ4
bF9iaXRtYXAgZ2xvYmFsX2h2bV9hZmZpbml0eV9tYXNrOw0KPj4gICBleHRlcm4gbGlieGxfYml0
bWFwIGdsb2JhbF9wdl9hZmZpbml0eV9tYXNrOw0KPj4gICBleHRlcm4gbGlieGxfZG9taWQgZG9t
aWRfcG9saWN5Ow0KPj4gK2V4dGVybiBpbnQgYXNzaXN0ZWRfeGFwaWM7DQo+PiArZXh0ZXJuIGlu
dCBhc3Npc3RlZF94MmFwaWM7DQo+PiAgIA0KPj4gICBlbnVtIG91dHB1dF9mb3JtYXQgew0KPj4g
ICAgICAgT1VUUFVUX0ZPUk1BVF9KU09OLA0KPj4gZGlmZiAtLWdpdCBhL3Rvb2xzL3hsL3hsX3Bh
cnNlLmMgYi90b29scy94bC94bF9wYXJzZS5jDQo+PiBpbmRleCAxMTdmY2RjYjJiLi4wYWI5YjE0
NWZlIDEwMDY0NA0KPj4gLS0tIGEvdG9vbHMveGwveGxfcGFyc2UuYw0KPj4gKysrIGIvdG9vbHMv
eGwveGxfcGFyc2UuYw0KPj4gQEAgLTE2ODEsNiArMTY4MSwyMiBAQCB2b2lkIHBhcnNlX2NvbmZp
Z19kYXRhKGNvbnN0IGNoYXIgKmNvbmZpZ19zb3VyY2UsDQo+PiAgICAgICAgICAgeGx1X2NmZ19n
ZXRfZGVmYm9vbChjb25maWcsICJ2cHRfYWxpZ24iLCAmYl9pbmZvLT51Lmh2bS52cHRfYWxpZ24s
IDApOw0KPj4gICAgICAgICAgIHhsdV9jZmdfZ2V0X2RlZmJvb2woY29uZmlnLCAiYXBpYyIsICZi
X2luZm8tPmFwaWMsIDApOw0KPj4gICANCj4+ICsgICAgICAgIGUgPSB4bHVfY2ZnX2dldF9sb25n
KGNvbmZpZywgImFzc2lzdGVkX3hhcGljIiwgJmwgLCAwKTsNCj4+ICsgICAgICAgIGlmICgoZSA9
PSBFU1JDSCAmJiBhc3Npc3RlZF94YXBpYyAhPSAtMSkpIC8qIHVzZSBnbG9iYWwgZGVmYXVsdCBp
ZiBwcmVzZW50ICovDQo+ICAgICAgICAgICAgICAgICBeIG5vIG5lZWQgZm9yIHRoZSBleHRyYSBw
YXJlbnRoZXNlcyBoZXJlIGFuZCBiZWxvdy4NCj4gDQo+PiArICAgICAgICAgICAgbGlieGxfZGVm
Ym9vbF9zZXQoJmJfaW5mby0+YXJjaF94ODYuYXNzaXN0ZWRfeGFwaWMsIGFzc2lzdGVkX3hhcGlj
KTsNCj4+ICsgICAgICAgIGVsc2UgaWYgKCFlKQ0KPj4gKyAgICAgICAgICAgIGxpYnhsX2RlZmJv
b2xfc2V0KCZiX2luZm8tPmFyY2hfeDg2LmFzc2lzdGVkX3hhcGljLCBsKTsNCj4+ICsgICAgICAg
IGVsc2UNCj4+ICsgICAgICAgICAgICBleGl0KDEpOw0KPj4gKw0KPj4gKyAgICAgICAgZSA9IHhs
dV9jZmdfZ2V0X2xvbmcoY29uZmlnLCAiYXNzaXN0ZWRfeDJhcGljIiwgJmwsIDApOw0KPj4gKyAg
ICAgICAgaWYgKChlID09IEVTUkNIICYmIGFzc2lzdGVkX3gyYXBpYyAhPSAtMSkpIC8qIHVzZSBn
bG9iYWwgZGVmYXVsdCBpZiBwcmVzZW50ICovDQo+PiArICAgICAgICAgICAgbGlieGxfZGVmYm9v
bF9zZXQoJmJfaW5mby0+YXJjaF94ODYuYXNzaXN0ZWRfeDJhcGljLCBhc3Npc3RlZF94MmFwaWMp
Ow0KPj4gKyAgICAgICAgZWxzZSBpZiAoIWUpDQo+PiArICAgICAgICAgICAgbGlieGxfZGVmYm9v
bF9zZXQoJmJfaW5mby0+YXJjaF94ODYuYXNzaXN0ZWRfeDJhcGljLCBsKTsNCj4+ICsgICAgICAg
IGVsc2UNCj4+ICsgICAgICAgICAgICBleGl0KDEpOw0KPj4gKw0KPj4gICAgICAgICAgIHN3aXRj
aCAoeGx1X2NmZ19nZXRfbGlzdChjb25maWcsICJ2aXJpZGlhbiIsDQo+PiAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICZ2aXJpZGlhbiwgJm51bV92aXJpZGlhbiwgMSkpDQo+PiAg
ICAgICAgICAgew0KPj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9kb21haW4uYyBiL3hlbi9h
cmNoL3g4Ni9kb21haW4uYw0KPj4gaW5kZXggZWYxODEyZGMxNC4uOTAzM2EwZTE4MSAxMDA2NDQN
Cj4+IC0tLSBhL3hlbi9hcmNoL3g4Ni9kb21haW4uYw0KPj4gKysrIGIveGVuL2FyY2gveDg2L2Rv
bWFpbi5jDQo+PiBAQCAtNjE5LDYgKzYxOSw4IEBAIGludCBhcmNoX3Nhbml0aXNlX2RvbWFpbl9j
b25maWcoc3RydWN0IHhlbl9kb21jdGxfY3JlYXRlZG9tYWluICpjb25maWcpDQo+PiAgICAgICBi
b29sIGh2bSA9IGNvbmZpZy0+ZmxhZ3MgJiBYRU5fRE9NQ1RMX0NERl9odm07DQo+PiAgICAgICBi
b29sIGhhcCA9IGNvbmZpZy0+ZmxhZ3MgJiBYRU5fRE9NQ1RMX0NERl9oYXA7DQo+PiAgICAgICBi
b29sIG5lc3RlZF92aXJ0ID0gY29uZmlnLT5mbGFncyAmIFhFTl9ET01DVExfQ0RGX25lc3RlZF92
aXJ0Ow0KPj4gKyAgICBib29sIGFzc2lzdGVkX3hhcGljID0gY29uZmlnLT5hcmNoLm1pc2NfZmxh
Z3MgJiBYRU5fWDg2X0FTU0lTVEVEX1hBUElDOw0KPj4gKyAgICBib29sIGFzc2lzdGVkX3gyYXBp
YyA9IGNvbmZpZy0+YXJjaC5taXNjX2ZsYWdzICYgWEVOX1g4Nl9BU1NJU1RFRF9YMkFQSUM7DQo+
PiAgICAgICB1bnNpZ25lZCBpbnQgbWF4X3ZjcHVzOw0KPj4gICANCj4+ICAgICAgIGlmICggaHZt
ID8gIWh2bV9lbmFibGVkIDogIUlTX0VOQUJMRUQoQ09ORklHX1BWKSApDQo+PiBAQCAtNjg1LDEz
ICs2ODcsMzEgQEAgaW50IGFyY2hfc2FuaXRpc2VfZG9tYWluX2NvbmZpZyhzdHJ1Y3QgeGVuX2Rv
bWN0bF9jcmVhdGVkb21haW4gKmNvbmZpZykNCj4+ICAgICAgICAgICB9DQo+PiAgICAgICB9DQo+
PiAgIA0KPj4gLSAgICBpZiAoIGNvbmZpZy0+YXJjaC5taXNjX2ZsYWdzICYgflhFTl9YODZfTVNS
X1JFTEFYRUQgKQ0KPj4gKyAgICBpZiAoIGNvbmZpZy0+YXJjaC5taXNjX2ZsYWdzICYgfihYRU5f
WDg2X01TUl9SRUxBWEVEIHwNCj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgWEVOX1g4Nl9BU1NJU1RFRF9YQVBJQyB8DQo+PiArICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgIFhFTl9YODZfQVNTSVNURURfWDJBUElDKSApDQo+PiAgICAgICB7DQo+PiAg
ICAgICAgICAgZHByaW50ayhYRU5MT0dfSU5GTywgIkludmFsaWQgYXJjaCBtaXNjIGZsYWdzICUj
eFxuIiwNCj4+ICAgICAgICAgICAgICAgICAgIGNvbmZpZy0+YXJjaC5taXNjX2ZsYWdzKTsNCj4+
ICAgICAgICAgICByZXR1cm4gLUVJTlZBTDsNCj4+ICAgICAgIH0NCj4+ICAgDQo+PiArICAgIGlm
ICggKGFzc2lzdGVkX3hhcGljIHx8IGFzc2lzdGVkX3gyYXBpYykgJiYgIWh2bSApDQo+PiArICAg
IHsNCj4+ICsgICAgICAgIGRwcmludGsoWEVOTE9HX0lORk8sDQo+PiArICAgICAgICAgICAgICAg
ICJJbnRlcnJ1cHQgQ29udHJvbGxlciBWaXJ0dWFsaXphdGlvbiBub3Qgc3VwcG9ydGVkIGZvciBQ
VlxuIik7DQo+PiArICAgICAgICByZXR1cm4gLUVJTlZBTDsNCj4+ICsgICAgfQ0KPj4gKw0KPj4g
KyAgICBpZiAoIChhc3Npc3RlZF94YXBpYyAmJiAhYXNzaXN0ZWRfeGFwaWNfYXZhaWxhYmxlKSB8
fA0KPj4gKyAgICAgICAgIChhc3Npc3RlZF94MmFwaWMgJiYgIWFzc2lzdGVkX3gyYXBpY19hdmFp
bGFibGUpICkNCj4+ICsgICAgew0KPj4gKyAgICAgICAgZHByaW50ayhYRU5MT0dfSU5GTywNCj4+
ICsgICAgICAgICAgICAgICAgIkhhcmR3YXJlIGFzc2lzdGVkIHglc0FQSUMgcmVxdWVzdGVkIGJ1
dCBub3QgYXZhaWxhYmxlXG4iLA0KPj4gKyAgICAgICAgICAgICAgICBhc3Npc3RlZF94YXBpYyAm
JiAhYXNzaXN0ZWRfeGFwaWNfYXZhaWxhYmxlID8gIiIgOiAiMiIpOw0KPj4gKyAgICAgICAgcmV0
dXJuIC1FSU5WQUw7DQo+PiArICAgIH0NCj4+ICsNCj4+ICAgICAgIHJldHVybiAwOw0KPj4gICB9
DQo+PiAgIA0KPj4gQEAgLTg2Myw2ICs4ODMsMTIgQEAgaW50IGFyY2hfZG9tYWluX2NyZWF0ZShz
dHJ1Y3QgZG9tYWluICpkLA0KPj4gICANCj4+ICAgICAgIGQtPmFyY2gubXNyX3JlbGF4ZWQgPSBj
b25maWctPmFyY2gubWlzY19mbGFncyAmIFhFTl9YODZfTVNSX1JFTEFYRUQ7DQo+PiAgIA0KPj4g
KyAgICBkLT5hcmNoLmh2bS5hc3Npc3RlZF94YXBpYyA9DQo+PiArICAgICAgICBjb25maWctPmFy
Y2gubWlzY19mbGFncyAmIFhFTl9YODZfQVNTSVNURURfWEFQSUM7DQo+PiArDQo+PiArICAgIGQt
PmFyY2guaHZtLmFzc2lzdGVkX3gyYXBpYyA9DQo+PiArICAgICAgICBjb25maWctPmFyY2gubWlz
Y19mbGFncyAmIFhFTl9YODZfQVNTSVNURURfWDJBUElDOw0KPj4gKw0KPj4gICAgICAgcmV0dXJu
IDA7DQo+PiAgIA0KPj4gICAgZmFpbDoNCj4+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC94ODYvaHZt
L3ZteC92bWNzLmMgYi94ZW4vYXJjaC94ODYvaHZtL3ZteC92bWNzLmMNCj4+IGluZGV4IDQwNjBh
ZWYxYmQuLjYxNGRiNWM0YTQgMTAwNjQ0DQo+PiAtLS0gYS94ZW4vYXJjaC94ODYvaHZtL3ZteC92
bWNzLmMNCj4+ICsrKyBiL3hlbi9hcmNoL3g4Ni9odm0vdm14L3ZtY3MuYw0KPj4gQEAgLTExNTcs
NiArMTE1NywxMCBAQCBzdGF0aWMgaW50IGNvbnN0cnVjdF92bWNzKHN0cnVjdCB2Y3B1ICp2KQ0K
Pj4gICAgICAgICAgIF9fdm13cml0ZShQTEVfV0lORE9XLCBwbGVfd2luZG93KTsNCj4+ICAgICAg
IH0NCj4+ICAgDQo+PiArICAgIGlmICggIXYtPmRvbWFpbi0+YXJjaC5odm0uYXNzaXN0ZWRfeGFw
aWMgKQ0KPj4gKyAgICAgICAgdi0+YXJjaC5odm0udm14LnNlY29uZGFyeV9leGVjX2NvbnRyb2wg
Jj0NCj4+ICsgICAgICAgICAgICB+U0VDT05EQVJZX0VYRUNfVklSVFVBTElaRV9BUElDX0FDQ0VT
U0VTOw0KPj4gKw0KPj4gICAgICAgaWYgKCBjcHVfaGFzX3ZteF9zZWNvbmRhcnlfZXhlY19jb250
cm9sICkNCj4+ICAgICAgICAgICBfX3Ztd3JpdGUoU0VDT05EQVJZX1ZNX0VYRUNfQ09OVFJPTCwN
Cj4+ICAgICAgICAgICAgICAgICAgICAgdi0+YXJjaC5odm0udm14LnNlY29uZGFyeV9leGVjX2Nv
bnRyb2wpOw0KPj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9odm0vdm14L3ZteC5jIGIveGVu
L2FyY2gveDg2L2h2bS92bXgvdm14LmMNCj4+IGluZGV4IDM2YzhhMTJjZmUuLjNjOWZmNjAxNTQg
MTAwNjQ0DQo+PiAtLS0gYS94ZW4vYXJjaC94ODYvaHZtL3ZteC92bXguYw0KPj4gKysrIGIveGVu
L2FyY2gveDg2L2h2bS92bXgvdm14LmMNCj4+IEBAIC0zMzMzLDE2ICszMzMzLDExIEBAIHN0YXRp
YyB2b2lkIHZteF9pbnN0YWxsX3ZsYXBpY19tYXBwaW5nKHN0cnVjdCB2Y3B1ICp2KQ0KPj4gICAN
Cj4+ICAgdm9pZCB2bXhfdmxhcGljX21zcl9jaGFuZ2VkKHN0cnVjdCB2Y3B1ICp2KQ0KPj4gICB7
DQo+PiAtICAgIGludCB2aXJ0dWFsaXplX3gyYXBpY19tb2RlOw0KPj4gICAgICAgc3RydWN0IHZs
YXBpYyAqdmxhcGljID0gdmNwdV92bGFwaWModik7DQo+PiAgICAgICB1bnNpZ25lZCBpbnQgbXNy
Ow0KPj4gICANCj4+IC0gICAgdmlydHVhbGl6ZV94MmFwaWNfbW9kZSA9ICggKGNwdV9oYXNfdm14
X2FwaWNfcmVnX3ZpcnQgfHwNCj4+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNw
dV9oYXNfdm14X3ZpcnR1YWxfaW50cl9kZWxpdmVyeSkgJiYNCj4+IC0gICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgY3B1X2hhc192bXhfdmlydHVhbGl6ZV94MmFwaWNfbW9kZSApOw0KPj4g
LQ0KPj4gLSAgICBpZiAoICFjcHVfaGFzX3ZteF92aXJ0dWFsaXplX2FwaWNfYWNjZXNzZXMgJiYN
Cj4+IC0gICAgICAgICAhdmlydHVhbGl6ZV94MmFwaWNfbW9kZSApDQo+PiArICAgIGlmICggISB2
LT5kb21haW4tPmFyY2guaHZtLmFzc2lzdGVkX3hhcGljICYmDQo+PiArICAgICAgICAgISB2LT5k
b21haW4tPmFyY2guaHZtLmFzc2lzdGVkX3gyYXBpYyApDQo+ICAgICAgICAgICAgICAgXiBleHRy
YSBzcGFjZS4NCj4+ICAgICAgICAgICByZXR1cm47DQo+PiAgIA0KPj4gICAgICAgdm14X3ZtY3Nf
ZW50ZXIodik7DQo+PiBAQCAtMzM1Miw3ICszMzQ3LDggQEAgdm9pZCB2bXhfdmxhcGljX21zcl9j
aGFuZ2VkKHN0cnVjdCB2Y3B1ICp2KQ0KPj4gICAgICAgaWYgKCAhdmxhcGljX2h3X2Rpc2FibGVk
KHZsYXBpYykgJiYNCj4+ICAgICAgICAgICAgKHZsYXBpY19iYXNlX2FkZHJlc3ModmxhcGljKSA9
PSBBUElDX0RFRkFVTFRfUEhZU19CQVNFKSApDQo+PiAgICAgICB7DQo+PiAtICAgICAgICBpZiAo
IHZpcnR1YWxpemVfeDJhcGljX21vZGUgJiYgdmxhcGljX3gyYXBpY19tb2RlKHZsYXBpYykgKQ0K
Pj4gKyAgICAgICAgaWYgKCB2LT5kb21haW4tPmFyY2guaHZtLmFzc2lzdGVkX3gyYXBpYw0KPj4g
KyAgICAgICAgICAgICAmJiB2bGFwaWNfeDJhcGljX21vZGUodmxhcGljKSApDQo+PiAgICAgICAg
ICAgew0KPj4gICAgICAgICAgICAgICB2LT5hcmNoLmh2bS52bXguc2Vjb25kYXJ5X2V4ZWNfY29u
dHJvbCB8PQ0KPj4gICAgICAgICAgICAgICAgICAgU0VDT05EQVJZX0VYRUNfVklSVFVBTElaRV9Y
MkFQSUNfTU9ERTsNCj4+IEBAIC0zMzczLDcgKzMzNjksNyBAQCB2b2lkIHZteF92bGFwaWNfbXNy
X2NoYW5nZWQoc3RydWN0IHZjcHUgKnYpDQo+PiAgICAgICAgICAgICAgICAgICB2bXhfY2xlYXJf
bXNyX2ludGVyY2VwdCh2LCBNU1JfWDJBUElDX1NFTEYsIFZNWF9NU1JfVyk7DQo+PiAgICAgICAg
ICAgICAgIH0NCj4+ICAgICAgICAgICB9DQo+PiAtICAgICAgICBlbHNlDQo+PiArICAgICAgICBl
bHNlIGlmICggdi0+ZG9tYWluLT5hcmNoLmh2bS5hc3Npc3RlZF94YXBpYyApDQo+PiAgICAgICAg
ICAgICAgIHYtPmFyY2guaHZtLnZteC5zZWNvbmRhcnlfZXhlY19jb250cm9sIHw9DQo+PiAgICAg
ICAgICAgICAgICAgICBTRUNPTkRBUllfRVhFQ19WSVJUVUFMSVpFX0FQSUNfQUNDRVNTRVM7DQo+
PiAgICAgICB9DQo+PiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gveDg2L2luY2x1ZGUvYXNtL2h2bS9k
b21haW4uaCBiL3hlbi9hcmNoL3g4Ni9pbmNsdWRlL2FzbS9odm0vZG9tYWluLmgNCj4+IGluZGV4
IDY5ODQ1NTQ0NGUuLjkyYmY1MzQ4M2MgMTAwNjQ0DQo+PiAtLS0gYS94ZW4vYXJjaC94ODYvaW5j
bHVkZS9hc20vaHZtL2RvbWFpbi5oDQo+PiArKysgYi94ZW4vYXJjaC94ODYvaW5jbHVkZS9hc20v
aHZtL2RvbWFpbi5oDQo+PiBAQCAtMTE3LDYgKzExNywxMiBAQCBzdHJ1Y3QgaHZtX2RvbWFpbiB7
DQo+PiAgIA0KPj4gICAgICAgYm9vbCAgICAgICAgICAgICAgICAgICBpc19zM19zdXNwZW5kZWQ7
DQo+PiAgIA0KPj4gKyAgICAvKiB4QVBJQyBoYXJkd2FyZSBhc3Npc3RlZCB2aXJ0dWFsaXphdGlv
bi4gKi8NCj4+ICsgICAgYm9vbCAgICAgICAgICAgICAgICAgICBhc3Npc3RlZF94YXBpYzsNCj4+
ICsNCj4+ICsgICAgLyogeDJBUElDIGhhcmR3YXJlIGFzc2lzdGVkIHZpcnR1YWxpemF0aW9uLiAq
Lw0KPj4gKyAgICBib29sICAgICAgICAgICAgICAgICAgIGFzc2lzdGVkX3gyYXBpYzsNCj4+ICsN
Cj4+ICAgICAgIC8qIGh5cGVydmlzb3IgaW50ZXJjZXB0ZWQgbXNpeCB0YWJsZSAqLw0KPj4gICAg
ICAgc3RydWN0IGxpc3RfaGVhZCAgICAgICBtc2l4dGJsX2xpc3Q7DQo+PiAgIA0KPj4gZGlmZiAt
LWdpdCBhL3hlbi9hcmNoL3g4Ni90cmFwcy5jIGIveGVuL2FyY2gveDg2L3RyYXBzLmMNCj4+IGlu
ZGV4IDQ4NWJkNjY5NzEuLjMzNjk0YWNjOTkgMTAwNjQ0DQo+PiAtLS0gYS94ZW4vYXJjaC94ODYv
dHJhcHMuYw0KPj4gKysrIGIveGVuL2FyY2gveDg2L3RyYXBzLmMNCj4+IEBAIC0xMTE1LDcgKzEx
MTUsOCBAQCB2b2lkIGNwdWlkX2h5cGVydmlzb3JfbGVhdmVzKGNvbnN0IHN0cnVjdCB2Y3B1ICp2
LCB1aW50MzJfdCBsZWFmLA0KPj4gICAgICAgICAgIGlmICggIWlzX2h2bV9kb21haW4oZCkgfHwg
c3VibGVhZiAhPSAwICkNCj4+ICAgICAgICAgICAgICAgYnJlYWs7DQo+PiAgIA0KPj4gLSAgICAg
ICAgaWYgKCBjcHVfaGFzX3ZteF9hcGljX3JlZ192aXJ0ICkNCj4+ICsgICAgICAgIGlmICggY3B1
X2hhc192bXhfYXBpY19yZWdfdmlydCAmJg0KPiANCj4gWW91IGNhbiBkcm9wIHRoZSBjcHVfaGFz
X3ZteF9hcGljX3JlZ192aXJ0IGNoZWNrIGhlcmUsIGlmDQo+IGNwdV9oYXNfdm14X2FwaWNfcmVn
X3ZpcnQgaXMgZmFsc2UgYXNzaXN0ZWRfeGFwaWMgd29uJ3QgYmUgc2V0IHRvIHRydWUuDQpPaCwg
YnV0IGFzc2lzdGVkX3hhcGljX2F2YWlsYWJsZSBpcyBvbmx5IHNldCB0byBkZXBlbmQgb24gDQpj
cHVfaGFzX3ZteF92aXJ0dWFsaXplX2FwaWNfYWNjZXNzZXMsIHVubGVzcyBJIHNob3VsZCBjb3Jy
ZWN0IHRoaXMsIGJ1dCANCiAgSSBtaWdodCBiZSBtaXNzaW5nIHNvbWV0aGluZy4uLg0KPiANCj4+
ICsgICAgICAgICAgICAgdi0+ZG9tYWluLT5hcmNoLmh2bS5hc3Npc3RlZF94YXBpYyApDQo+PiAg
ICAgICAgICAgICAgIHJlcy0+YSB8PSBYRU5fSFZNX0NQVUlEX0FQSUNfQUNDRVNTX1ZJUlQ7DQo+
PiAgIA0KPj4gICAgICAgICAgIC8qDQo+PiBAQCAtMTEyNCw5ICsxMTI1LDggQEAgdm9pZCBjcHVp
ZF9oeXBlcnZpc29yX2xlYXZlcyhjb25zdCBzdHJ1Y3QgdmNwdSAqdiwgdWludDMyX3QgbGVhZiwN
Cj4+ICAgICAgICAgICAgKiBhbmQgd3Jtc3IgaW4gdGhlIGd1ZXN0IHdpbGwgcnVuIHdpdGhvdXQg
Vk1FWElUcyAoc2VlDQo+PiAgICAgICAgICAgICogdm14X3ZsYXBpY19tc3JfY2hhbmdlZCgpKS4N
Cj4+ICAgICAgICAgICAgKi8NCj4+IC0gICAgICAgIGlmICggY3B1X2hhc192bXhfdmlydHVhbGl6
ZV94MmFwaWNfbW9kZSAmJg0KPj4gLSAgICAgICAgICAgICBjcHVfaGFzX3ZteF9hcGljX3JlZ192
aXJ0ICYmDQo+PiAtICAgICAgICAgICAgIGNwdV9oYXNfdm14X3ZpcnR1YWxfaW50cl9kZWxpdmVy
eSApDQo+PiArICAgICAgICBpZiAoIChjcHVfaGFzX3ZteF9hcGljX3JlZ192aXJ0ICYmIGNwdV9o
YXNfdm14X3ZpcnR1YWxfaW50cl9kZWxpdmVyeSkgJiYNCj4gICAgICAgICAgICAgICAgICBeIHVu
bmVlZGVkIHBhcmVudGhlc2VzDQo+DQpPa2F5Lg0KPiBUaGFua3MsIFJvZ2VyLg0KDQpUaGFuayB5
b3UsDQoNCkphbmUu


From xen-devel-bounces@lists.xenproject.org Wed Feb 09 11:04:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 09 Feb 2022 11:04:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269003.462961 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHkm6-0001t6-TY; Wed, 09 Feb 2022 11:04:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269003.462961; Wed, 09 Feb 2022 11:04:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHkm6-0001sz-QA; Wed, 09 Feb 2022 11:04:38 +0000
Received: by outflank-mailman (input) for mailman id 269003;
 Wed, 09 Feb 2022 11:04:37 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=XFrC=SY=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nHkm5-0001st-AS
 for xen-devel@lists.xenproject.org; Wed, 09 Feb 2022 11:04:37 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 10edb001-8998-11ec-8eb8-a37418f5ba1a;
 Wed, 09 Feb 2022 12:04:35 +0100 (CET)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2109.outbound.protection.outlook.com [104.47.18.109]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-22-WwssaUJ9N1WW4d4pYVUvGA-1; Wed, 09 Feb 2022 12:04:34 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB2703.eurprd04.prod.outlook.com (2603:10a6:800:ae::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Wed, 9 Feb
 2022 11:04:32 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.018; Wed, 9 Feb 2022
 11:04:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 10edb001-8998-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644404675;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=ai9zrnbU99mJWZZx21K3PnZyz+f8Vwmvshux+xp5ncU=;
	b=jTrI+dbN9ahlpkYqQQlSw4XMnEocV9rnuFwai122ojCgIYvvi8LOnQMOULVSi/2x6af2pK
	eEkLn/kfimVjR4jw1MtTnZIzbwg0XWS7QY9p7S0cLbfkZayeDBwIbgIh0XuOZLywYqctNW
	jX0rDstAepmLOC6NSwtp33/OTDpJyoY=
X-MC-Unique: WwssaUJ9N1WW4d4pYVUvGA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=fmFHiYnJkJYzfU43waRzJTu9EUXQmEew85X3/PeA5OBhiuUXqXbhpWmWApkgwbnCcWG9KbCtbe+2MszClBdobt4l532X0pbYBiELr6Ll+LZr4GjQgLR8uMWscXaKvnUJNzAG0f8Um+4p8T8z2KfdhwwBNmXWyXRUQ6Zg0moTCX8TN69kS0rkNhlGwMO3OtlqWHwKzX3y0keMfcpKRNQ3WPm1hWWnngZPLnCCKuOMnGzqhe2tUv+Fsm6VG4On5es/hnbv6cui1odgAxZuK7dGVBuhInIbPvwNahsosR1RjTpa+6Q/D13rA473qtOpM2C/todcfruYG3zhdwFO0QSEeg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=9pn1dFbHAgujrZNDuCGd4SWDATTThjNWKJBsmA/6J4Q=;
 b=hJXfkHo8oa1kk5lSdNsHQDXK36xbwtYTlv3lB+0nV6o2u5D6BXN7vDAAapeH9q2BNL/ZINE7GJesR1MAycppOc8vWwg0xiJ8Qi+U4JlVcMqQ7PmsmEZjXNXbzjggXEVr9ZfKsLPb4nWzYSmUN8fAIvaouQ/5kGEM/MogAvJd2E5QmgY0sOYMofOgRkXia5BXxwWcpb1qYysfU0ochlsmewjLCA5jlnf4z5m2seaW6kgAWLDSSwGPmfJuW3lWxuiyrpB9MYVjJyB0xWMuh/JdE+1DlVq04ICnHrAf5hJaP3E2QZhwTg51fQhd8f/7atEl72Kr0xKzkmUTy4kSmxr5pg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <7f81a991-b66c-41cd-5f0c-1f121446ee1b@suse.com>
Date: Wed, 9 Feb 2022 12:04:29 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH V5] xen/gnttab: Store frame GFN in struct page_info on Arm
Content-Language: en-US
To: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>
CC: Oleksandr Tyshchenko <olekstysh@gmail.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Bob Eshleman <bobbyeshleman@gmail.com>,
 Alistair Francis <alistair.francis@wdc.com>,
 Connor Davis <connojdavis@gmail.com>, Julien Grall <julien@xen.org>
References: <1641424268-12968-1-git-send-email-olekstysh@gmail.com>
 <a54213c4-1c68-694e-c130-d95faeef3953@xen.org>
 <78d94e1e-6db4-25c1-adb8-e4bdbfe42774@epam.com>
 <82d8bfe0-cb46-d303-6a60-2324dd76a1f7@xen.org>
 <3629d57d-6d89-5ada-1664-cd532342fd0b@suse.com>
 <d42f0e9f-d60d-8ec4-7053-9ecd1a069925@epam.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <d42f0e9f-d60d-8ec4-7053-9ecd1a069925@epam.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6P194CA0092.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:209:8f::33) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: cdcfc61f-37cb-46e9-b191-08d9ebbbf2f7
X-MS-TrafficTypeDiagnostic: VI1PR0402MB2703:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB27030AB3D33D4124BD8F57BEB32E9@VI1PR0402MB2703.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6790;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	QHe0hkr8HUrTZULaDgOMMIAPuOi6A2VaUiZgyc/MWAzh/HQRSYWFZ3gcKHXP2mbRKacq73OJHfvaDHvoBslf9U+tYuU15vMS3H67FRIbzXQuFd+DJ170vZR6uGwmZ63OcT7zT/WK9MXPpwGhkoSZzuLoAztxK9r76yHm1tCqBGwPvyohNnQ/0mUqf+T1q3nHlJ3i7BrX2zu6nVbFCnSg6eyKGjlTNQ6SP2PAe2PQePtt7jkAH6jXkDKdwCvxzWty2oezwOxtebGjBaX1hHzqAF61H8Fe+0JTYDQZXNFl6KadALlLYjespodH3dHY8C5Uh7j/8pm44j3gP0wK5CIkgp6JlMEcq/iyVv0O/0uWH7F8wWX/MrMdKGAbS3ALtexK+Er/8iuIOKI/cxux4KLXxVejBKh/xWzwJ3CY75L8jl+ctD4aGU+GAvGKngdQyrDOpZBR92rmybqTw2dgQ/JJbLG9otdqRQn0O7vHJ/QtfmfkYeUZ629pWgEcKbTuUb2+Azu6FI8cwEUL3lLzNaWwIpISBQB5PEKjhK/2DQ63TCYVtSPviwLsvX1PPkQv29QoFOdkDn0TCM41IGKpRMHs1V8fmS4fHcQFVw/f0Opuvbbp3yfcb6lcvmQSsbiQpGMx3SQH6nyDwUyj3+waN0X4KIFbgFl+seZT5OwiqMMrgwl6zAuU1FV+hGlgyOhuDOUOe9HXMajhILPc63O5wijVqxaFvWwpyQi/1BoEkVh15AY=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(31696002)(66476007)(66556008)(66946007)(4326008)(186003)(26005)(8676002)(86362001)(7416002)(2906002)(38100700002)(5660300002)(316002)(6506007)(53546011)(2616005)(8936002)(54906003)(36756003)(6512007)(6486002)(31686004)(6916009)(508600001)(6666004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?5MiCdNRkb4UAyxw2PVCbwIrPM3v+69XOP0A0IpAUrRQ/69/FFJCBvcy1Ln7g?=
 =?us-ascii?Q?oIyFsBw2iKx8g38D0l8g+M1mG77Cy3VQSyMiH2cmYZ6Kos+PvYMzlL9dmK4H?=
 =?us-ascii?Q?vaOlN1zm2t03m0DO6/3rNn3PFRo5HVJG3PDJHAW/6fiMCMMkQXZJJiH/HOsD?=
 =?us-ascii?Q?PB14/x0dc8TOqDrAOfpbhNIKF6BWEUZN1A9D2ffBudJEvICHvu+f4xv1AsYM?=
 =?us-ascii?Q?mHPfzaT1sZnOL2iaAUClhAZvtc/j4uAWMMtc/TMnVd9SAdZtMHzhBkaRNUfP?=
 =?us-ascii?Q?tfWoZrK5kNQdnKD/GzdBkVdEqGc9bOe+3rcuVNSN/5m+asXgsDzChnM+pvpv?=
 =?us-ascii?Q?S0+DtU/w53+jfSEeLtVFsLntyNcXJbToreKpu+imrOFh5qDob5KDUgcrv14R?=
 =?us-ascii?Q?WKuH1KHffOXEhsSP5tJ4455tidr9SRPKMlLBPJrStL0pwwX5HJ4GSzVQGGAI?=
 =?us-ascii?Q?W6FM4ejCmSGHKq/CyBSpVxk9S4pgRANGKZV5ZtGsZQnvfMea4PKxwNwNr8dJ?=
 =?us-ascii?Q?5ZGt5Pa9GM6ZwUPupQsQZMsdNGtGfx4iF8e4V0GTp6XAgCb1AGqXbPe5CHfW?=
 =?us-ascii?Q?H165Mc/WBi3blseL2sinB+COFccUj+q8t4gZeopbo5JM7uJR8oVSgiRm9W3V?=
 =?us-ascii?Q?TJO3Sf5RjFy9lwJGLjrNWvPnyHcFlMNEgMrldzfRYtEgxWDXuGwgEBp2F1l0?=
 =?us-ascii?Q?xIndbA3guXHXDGSn0QnIxIztgh3QkQchSHJSDC40nAvw84tmz5uRJxftKZN3?=
 =?us-ascii?Q?fyVtim6ZYoaSGSin7s4YKWAf3JJ2kqXFKNxD9HRjx4ubH9TSO6ETNPJELTb9?=
 =?us-ascii?Q?GYDB+0R4t7azZoRT3dL/COUNC+yEvzTowO7hZjE5aYOKl/5b1KzzED8aUhdp?=
 =?us-ascii?Q?H9bcwIE71XuAMjtLU/aqqzICk3nLT/jZizkPMwPeN39MgEneV+wL5UmoxyWf?=
 =?us-ascii?Q?E2W6JZynctH+4h8jkdVt02Eg6E0iCZf2++i0IY4jfF40HFzNHQeSxsQXWJDw?=
 =?us-ascii?Q?6Ap1geVaKUoMFzY517eqek/lCQ5OG7AMcI/AV1cQ8+kUgBhUJ039EZ7pUKR/?=
 =?us-ascii?Q?MsA0GUNOjk+OEiHY9KdfWQJmBGZHDx1Iag/cuW51of+8lfw62qbK0Kntacoz?=
 =?us-ascii?Q?nduGcccahvDOXP4xfWZko1ta+ACM6r5i9FPmMQKE7Kq3JZE7JTurUNFZpTt0?=
 =?us-ascii?Q?aJe8VVhcO0IztnS2gwPFySmgbSeHGwl3dJkx8FbfiYF+eyYs4EaOVwe9z5Ho?=
 =?us-ascii?Q?fedvSbs96MOdDIgFyY/D7SS0uZVX65AUknrF3syLk1vOWMrSTxtT1PqmyBLw?=
 =?us-ascii?Q?ibwei64FljJH5yNwsLue2MuUeZiooaZ5IzQlZrMD68nfpKlBJUnRG1Uz47C2?=
 =?us-ascii?Q?NVsKBDpB6LGHUYyZwr6kdu5Jxx8kVK5HPvvYcthLbwL3taUPNgSsTvOIR37r?=
 =?us-ascii?Q?BH5gN62XhC8u/IS84wAnhZ0HyE5yPJfmO12rVH+TnaQVGkpuMMn6E+ggUyGs?=
 =?us-ascii?Q?E3gpQ2OIEf7logLctg/WQLif6BQDd3DhbQItMKWhS/ygV7L16T8/3IskofzZ?=
 =?us-ascii?Q?5kNFXeazGJTO01jbG1cHGS5Uf4emKwKCnY/0o2DLJfaUwl43VR6uyv9Ceklf?=
 =?us-ascii?Q?MM0ybmTx1TQWnjFJJgggqMc=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cdcfc61f-37cb-46e9-b191-08d9ebbbf2f7
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2022 11:04:32.0022
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lcs+rc2/y1uGGCYt/qTD2yFzq5yTIM/LdFkNETbEiGhR/nRVz9yjlBKcig0lPJpVebINRMLFUqaPAtCDE+N7PQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB2703

On 09.02.2022 11:08, Oleksandr Tyshchenko wrote:
>=20
> On 08.02.22 14:47, Jan Beulich wrote:
>=20
>=20
> Hi Julien, Jan
>=20
>=20
>> On 08.02.2022 12:58, Julien Grall wrote:
>>> On 07/02/2022 19:56, Oleksandr Tyshchenko wrote:
>>>> On 07.02.22 19:15, Julien Grall wrote:
>>>>> Hi Oleksandr,
>>>>> On 05/01/2022 23:11, Oleksandr Tyshchenko wrote:
>>>>>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>>>>>
>>>>>> Rework Arm implementation to store grant table frame GFN
>>>>>> in struct page_info directly instead of keeping it in
>>>>>> standalone status/shared arrays. This patch is based on
>>>>>> the assumption that grant table page is the xenheap page.
>>>>> I would write "grant table pages are xenheap pages" or "a grant table
>>>>> page is a xenheap page".
>>>>>
>>>>> [...]
>>>>>
>>>>>> diff --git a/xen/arch/arm/include/asm/grant_table.h
>>>>>> b/xen/arch/arm/include/asm/grant_table.h
>>>>>> index d31a4d6..d6fda31 100644
>>>>>> --- a/xen/arch/arm/include/asm/grant_table.h
>>>>>> +++ b/xen/arch/arm/include/asm/grant_table.h
>>>>>> @@ -11,11 +11,6 @@
>>>>>>   =C2=A0 #define INITIAL_NR_GRANT_FRAMES 1U
>>>>>>   =C2=A0 #define GNTTAB_MAX_VERSION 1
>>>>>>   =C2=A0 -struct grant_table_arch {
>>>>>> -=C2=A0=C2=A0=C2=A0 gfn_t *shared_gfn;
>>>>>> -=C2=A0=C2=A0=C2=A0 gfn_t *status_gfn;
>>>>>> -};
>>>>>> -
>>>>>>   =C2=A0 static inline void gnttab_clear_flags(struct domain *d,
>>>>>>   =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0 unsigned int mask, uint16_t
>>>>>> *addr)
>>>>>>   =C2=A0 {
>>>>>> @@ -46,41 +41,12 @@ int replace_grant_host_mapping(unsigned long
>>>>>> gpaddr, mfn_t mfn,
>>>>>>   =C2=A0 #define gnttab_dom0_frames() \
>>>>>>   =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 min_t(unsigned int, opt_max_grant_f=
rames, PFN_DOWN(_etext -
>>>>>> _stext))
>>>>>>   =C2=A0 -#define gnttab_init_arch(gt) \
>>>>>> -({ \
>>>>>> -=C2=A0=C2=A0=C2=A0 unsigned int ngf_ =3D
>>>>>> (gt)->max_grant_frames;=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \
>>>>>> -=C2=A0=C2=A0=C2=A0 unsigned int nsf_ =3D
>>>>>> grant_to_status_frames(ngf_);=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
 \
>>>>>> - \
>>>>>> -=C2=A0=C2=A0=C2=A0 (gt)->arch.shared_gfn =3D xmalloc_array(gfn_t,
>>>>>> ngf_);=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \
>>>>>> -=C2=A0=C2=A0=C2=A0 (gt)->arch.status_gfn =3D xmalloc_array(gfn_t,
>>>>>> nsf_);=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \
>>>>>> -=C2=A0=C2=A0=C2=A0 if ( (gt)->arch.shared_gfn && (gt)->arch.status_=
gfn
>>>>>> )=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0 \
>>>>>> - { \
>>>>>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 while ( ngf_--
>>>>>> )=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \
>>>>>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 =
(gt)->arch.shared_gfn[ngf_] =3D
>>>>>> INVALID_GFN;=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \
>>>>>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 while ( nsf_--
>>>>>> )=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \
>>>>>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 =
(gt)->arch.status_gfn[nsf_] =3D
>>>>>> INVALID_GFN;=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \
>>>>>> - } \
>>>>>> - else \
>>>>>> - gnttab_destroy_arch(gt); \
>>>>>> -=C2=A0=C2=A0=C2=A0 (gt)->arch.shared_gfn ? 0 :
>>>>>> -ENOMEM;=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \
>>>>>> -})
>>>>>> -
>>>>>> -#define gnttab_destroy_arch(gt) \
>>>>>> -=C2=A0=C2=A0=C2=A0 do { \
>>>>>> - XFREE((gt)->arch.shared_gfn); \
>>>>>> - XFREE((gt)->arch.status_gfn); \
>>>>>> -=C2=A0=C2=A0=C2=A0 } while ( 0 )
>>>>>> -
>>>>>>   =C2=A0 #define gnttab_set_frame_gfn(gt, st, idx, gfn,
>>>>>> mfn)=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \
>>>>>> ({ \
>>>>>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 int rc_ =3D
>>>>>> 0;=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0 \
>>>>>>   =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 gfn_t ogfn =
=3D gnttab_get_frame_gfn(gt, st,
>>>>>> idx);=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \
>>>>>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if ( gfn_eq(ogfn, INVALI=
D_GFN) || gfn_eq(ogfn, gfn)
>>>>>> ||=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \
>>>>>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0 (rc_ =3D guest_physmap_remove_page((gt)->domain, ogfn,
>>>>>> mfn,=C2=A0=C2=A0 \
>>>>>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 0)) =3D=3D 0
>>>>>> )=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \
>>>>>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 =
((st) ?
>>>>>> (gt)->arch.status_gfn=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \
>>>>>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 : (gt)->arch.shared_gfn)[idx] =3D
>>>>>> (gfn);=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \
>>>>>> - rc_; \
>>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (!gfn_eq(ogfn, INVALID_G=
FN) && !gfn_eq(ogfn,
>>>>>> gfn))=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0 \
>>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ? guest_physmap_re=
move_page((gt)->domain, ogfn, mfn,
>>>>>> 0)=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \
>>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 :
>>>>>> 0;=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \
>>>>> Given that we are implementing something similar to an M2P, I was
>>>>> expecting the implementation to be pretty much the same as the x86
>>>>> helper.
>>>>>
>>>>> Would you be able to outline why it is different?
>>>> Being honest, I didn't think about it so far.=C2=A0 But, I agree with =
the
>>>> question.
>>>>
>>>> It feels to me that Arm variant can now behave as x86 one (as
>>>> xenmem_add_to_physmap_one() now checks for the prior mapping), I mean =
to
>>>> use INVALID_GFN as an indication to remove a page.
>>>>
>>>> What do you think?
>>> I will defer that to Jan.
>>>
>>> Jan, IIRC you were the one introducing the call to
>>> guest_physmap_remove_page(). Do you remember why the difference between
>>> x86 and Arm were necessary?
>> The code was different before, and Arm's behavior was also different.
>> Hence the two functions couldn't be quite similar. If Arm behavior is
>> now converging with x86'es, the functions becoming more similar is
>> not entirely unexpected.
>=20
> If Arm's gnttab_set_frame_gfn appears to be the similar to x86's one,=20
> what would be the next step?
>=20
> I thought of the following options:
>=20
> 1. Leave per-arch helpers as they are
> 2. Move helper to the common grant_table.h
> 3. Remove the helpers, call guest_physmap_remove_page() directly from=20
> the common grant_table.c

Well, "similar" is not enough for 2 or 3, but if they end up identical,
then I guess 3 is the way to go unless we foresee e.g. RISC-V wanting
something different. But this would be a separate change, so the
similarity level of the two implementations can actually be easily
seen during review (or later when doing archaeology).

Jan



From xen-devel-bounces@lists.xenproject.org Wed Feb 09 11:15:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 09 Feb 2022 11:15:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269001.462971 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHkwb-0003Mz-Ti; Wed, 09 Feb 2022 11:15:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269001.462971; Wed, 09 Feb 2022 11:15:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHkwb-0003Ms-Qj; Wed, 09 Feb 2022 11:15:29 +0000
Received: by outflank-mailman (input) for mailman id 269001;
 Wed, 09 Feb 2022 11:00:53 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=50R8=SY=irit.fr=dinhngoc.tu@srs-se1.protection.inumbo.net>)
 id 1nHkiT-0001on-PO
 for xen-devel@lists.xenproject.org; Wed, 09 Feb 2022 11:00:53 +0000
Received: from smtp1.irit.fr (smtp1.irit.fr [141.115.24.2])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8b930552-8997-11ec-8eb8-a37418f5ba1a;
 Wed, 09 Feb 2022 12:00:52 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8b930552-8997-11ec-8eb8-a37418f5ba1a
From: <dinhngoc.tu@irit.fr>
To: <xen-devel@lists.xenproject.org>
Subject: [PATCH] x86: Use low memory size directly from Multiboot
Date: Wed, 9 Feb 2022 12:00:50 +0100
Message-ID: <001301d81da4$4c993260$e5cb9720$@irit.fr>
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit
Thread-Index: Adgdo3qWvijfwbqMRuiJMpwfi+U51A==
Content-Language: en

Previously, Xen used information from the BDA to detect the amount of
available low memory. This does not work on some scenarios such as
Coreboot, or when booting from Kexec on a UEFI system without CSM.

Use the information directly supplied by Multiboot boot information
instead.
---
 xen/arch/x86/boot/head.S | 30 ++++++------------------------
 1 file changed, 6 insertions(+), 24 deletions(-)

diff --git a/xen/arch/x86/boot/head.S b/xen/arch/x86/boot/head.S
index dd1bea0d10..31a0663e6d 100644
--- a/xen/arch/x86/boot/head.S
+++ b/xen/arch/x86/boot/head.S
@@ -524,33 +524,15 @@ trampoline_bios_setup:
         mov     %ecx,%fs
         mov     %ecx,%gs
 
-        /* Set up trampoline segment 64k below EBDA */
-        movzwl  0x40e,%ecx          /* EBDA segment */
-        cmp     $0xa000,%ecx        /* sanity check (high) */
-        jae     0f
-        cmp     $0x4000,%ecx        /* sanity check (low) */
-        jae     1f
-0:
-        movzwl  0x413,%ecx          /* use base memory size on failure */
-        shl     $10-4,%ecx
-1:
-        /*
-         * Compare the value in the BDA with the information from the
-         * multiboot structure (if available) and use the smallest.
-         */
-        cmp     $0x100,%edx         /* is the multiboot value too small? */
-        jb      2f                  /* if so, do not use it */
-        shl     $10-4,%edx
-        cmp     %ecx,%edx           /* compare with BDA value */
-        cmovb   %edx,%ecx           /* and use the smaller */
+        /* Use lower memory size directly from Multiboot */
+        mov     %edx,%ecx
+        /* From arch/x86/smpboot.c: start_eip had better be page-aligned!
*/
+        shr     $2,%ecx
 
-2:
         /* Reserve memory for the trampoline and the low-memory stack. */
-        sub     $((TRAMPOLINE_SPACE+TRAMPOLINE_STACK_SPACE)>>4),%ecx
+        sub     $((TRAMPOLINE_SPACE+TRAMPOLINE_STACK_SPACE)>>12),%ecx
 
-        /* From arch/x86/smpboot.c: start_eip had better be page-aligned!
*/
-        xor     %cl, %cl
-        shl     $4, %ecx
+        shl     $12,%ecx
         mov     %ecx,sym_esi(trampoline_phys)
 
 trampoline_setup:
-- 
2.25.1




From xen-devel-bounces@lists.xenproject.org Wed Feb 09 11:24:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 09 Feb 2022 11:24:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269018.462983 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHl50-0004ov-Qj; Wed, 09 Feb 2022 11:24:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269018.462983; Wed, 09 Feb 2022 11:24:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHl50-0004oo-MP; Wed, 09 Feb 2022 11:24:10 +0000
Received: by outflank-mailman (input) for mailman id 269018;
 Wed, 09 Feb 2022 11:24:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=lRaV=SY=xilinx.com=ayankuma@srs-se1.protection.inumbo.net>)
 id 1nHl4z-0004oi-S6
 for xen-devel@lists.xenproject.org; Wed, 09 Feb 2022 11:24:10 +0000
Received: from NAM11-CO1-obe.outbound.protection.outlook.com
 (mail-co1nam11on2062e.outbound.protection.outlook.com
 [2a01:111:f400:7eab::62e])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id cacab247-899a-11ec-8f75-fffcc8bd4f1a;
 Wed, 09 Feb 2022 12:24:07 +0100 (CET)
Received: from BN9PR03CA0381.namprd03.prod.outlook.com (2603:10b6:408:f7::26)
 by SN4PR0201MB8758.namprd02.prod.outlook.com (2603:10b6:806:1ea::5)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Wed, 9 Feb
 2022 11:24:04 +0000
Received: from BN1NAM02FT007.eop-nam02.prod.protection.outlook.com
 (2603:10b6:408:f7:cafe::f2) by BN9PR03CA0381.outlook.office365.com
 (2603:10b6:408:f7::26) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11 via Frontend
 Transport; Wed, 9 Feb 2022 11:24:03 +0000
Received: from xir-pvapexch02.xlnx.xilinx.com (149.199.80.198) by
 BN1NAM02FT007.mail.protection.outlook.com (10.13.3.155) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.4975.11 via Frontend Transport; Wed, 9 Feb 2022 11:24:03 +0000
Received: from xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) by
 xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2176.14; Wed, 9 Feb 2022 11:24:02 +0000
Received: from smtp.xilinx.com (172.21.105.198) by
 xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server id
 15.1.2176.14 via Frontend Transport; Wed, 9 Feb 2022 11:24:02 +0000
Received: from [10.71.116.78] (port=63252)
 by smtp.xilinx.com with esmtp (Exim 4.90)
 (envelope-from <ayan.kumar.halder@xilinx.com>)
 id 1nHl4r-0007lR-ET; Wed, 09 Feb 2022 11:24:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cacab247-899a-11ec-8f75-fffcc8bd4f1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ff8ctjCDdTaYR98K7h0qmGjkuzYcL9h3WebP0OrH+jk9xa6UPtbOmTzECDcAjVdVTTwGCjfD9vj0BoEftzgCHOTtkXifOhZn6ihw/Md0cyUTdujCSdrcy65DXh806Fb/GDvpCyhHG0BjM6dvloPrgWDAgl5yk9orRFvhLMt8vuSizbieWkQPcd8BDF7PJ40WjKMY7UJNkKzg9Ugo+xKyur0u/7CLwhQw+TWv6zmMzLJ6KcAmEa1UTm1fbiWoac7yDezwMfyQnTh3k3JRv4R8qgk/Sz/urvvMii0AGBoNp1V7qzzbVIoD2VMRzMLOoct7/vCZilBd32aCTKBpC9iQPA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=gV0sztLsJSsewBo1bwZz08pjI3DAGGuXRR5j3EmG92Q=;
 b=gTtyg5y+owm/44iloM/8VoVd3cSLPC4DsWHFyPAv7jhyO7ahO/6ekVnLtJhy1bGO8B/x+9fQuhELUZx0ddtERvX07qFszWiKbICrUtdyB1lWfbJt0wl7dnhCfTVWuT7f4xuDKxRBCjAXN20izKj//95kiKvO1aAJbSSozwy6RIg7cNo62xbiQIzZ0mukygdX828jmKNtsNT6kuhtgcZNLq5rEaccuKgAi1HKNZmajLIEBYeR9a4IVSBzq+BWFzmg8JyZZQmdVmp656wq4o1O9nGXILEvzv/NbG6wnb3zs5c1P72l4+mpp1dXc/CVgOytxyCIRmpbgOydmS6WlM68jQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 149.199.80.198) smtp.rcpttodomain=kernel.org smtp.mailfrom=xilinx.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=gV0sztLsJSsewBo1bwZz08pjI3DAGGuXRR5j3EmG92Q=;
 b=hX6fdTXDc7xRItaIm9kMLDWKmwTjQKG8DrEDCMZcYfNNxDUoRD1samYgICK1ssF00YFJTARzDatz1SfuFEPzoue0MZVvDVLqm1KtGldE0JZARGwMiNyY5yD4Uim9FZ8qqHugSKY2OYm8spVodf94wbfx4kmamVheDv7y9ARC1L0=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198)
 smtp.mailfrom=xilinx.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=xilinx.com;
Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates
 149.199.80.198 as permitted sender) receiver=protection.outlook.com;
 client-ip=149.199.80.198; helo=xir-pvapexch02.xlnx.xilinx.com;
Message-ID: <016444fc-6e7c-9cce-b4a7-70326b64dfff@xilinx.com>
Date: Wed, 9 Feb 2022 11:24:01 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.1
Subject: Re: [XEN v7 2/2] xen/arm64: io: Support instructions (for which ISS
 is not valid) on emulated MMIO region using MMIO/ioreq handler
To: Stefano Stabellini <sstabellini@kernel.org>, Ayan Kumar Halder
	<ayan.kumar.halder@xilinx.com>, <julien@xen.org>
CC: <xen-devel@lists.xenproject.org>, <stefanos@xilinx.com>,
	<Volodymyr_Babchuk@epam.com>, <bertrand.marquis@arm.com>
References: <20220205225816.5952-1-ayankuma@xilinx.com>
 <20220205225816.5952-3-ayankuma@xilinx.com>
 <alpine.DEB.2.22.394.2202081730130.2091381@ubuntu-linux-20-04-desktop>
From: Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>
In-Reply-To: <alpine.DEB.2.22.394.2202081730130.2091381@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 34171964-2125-4f1e-7384-08d9ebbead51
X-MS-TrafficTypeDiagnostic: SN4PR0201MB8758:EE_
X-Microsoft-Antispam-PRVS:
	<SN4PR0201MB8758AD001E89936FF71A964CB22E9@SN4PR0201MB8758.namprd02.prod.outlook.com>
X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	NzHhknKLWgdCQX6Ni+mJgPFm55C4MICgBnIXiudbmKV3DEfgm1vxamDyEu15kmccvBsl5W2XxP1/0c7K5B+xgbWq5+c6g9dGZrh4tnBoXZyxTnLw2HeCxjzTlD+2BgEP5B0nQ0F+JgYkR8UNPPGUDa1X/ApXIDyIYEseh8tBCP2Ia181rmipF1eJyNmU4CQTW0LSnf+22pCJXgmcdBLQ811jxpAhJoG2Yw4ReFOlZWqP8H6dwSEdoOusM3fdlsnqPvRlVEviMbOGVvGG1B1NIPegElUCDZdNSnPBIEyIjCEsZK241adPNi4p5RP4Ej7keR8lk0njXrJCUjzBdQdfZ1dyTnD/yu3zDd1oduUZf3Bf7TxlfRYxcZwlB2shwk/qpjjft5B8dJ6p5Rvv7QDDAmMvZ0IQLHJhZBHFemc/9dS4j5/+cn/ZyGLP446MiBdBudRKuuOv/CzstnC774f7x9cTwx9YyWngizbDb/2g/HSaBk4bzw1O6DsdM3zwDIF0MwaeSIaWR2y+pItc4ZOJRjWz+0l4S3a3cDuAKDhRaBX0wRAUHV5dWoSc2Pp+tL/VnGmdgveCpPyLOuNkfSaRyr3jIZgSofBgNCkKLQwxRmpEyfLxUOaHvf20m1CjDxbZ/VqJV4OtLakf+s7DBm5nAe3hbWdJMHHAMGGJeTbJS7mb8a+y9PoPtfW8YPzz2nk5B+B9erbhm5WwBIJ9LFL2wuavPkf4aPnryjwWlpMT7YPm9Z2G8i0EyI6VHZDh3x8ciSMN5roKryfE8QDzBRPiWQ==
X-Forefront-Antispam-Report:
	CIP:149.199.80.198;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:xir-pvapexch02.xlnx.xilinx.com;PTR:unknown-80-198.xilinx.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(8676002)(36756003)(26005)(40460700003)(8936002)(186003)(82310400004)(70586007)(70206006)(4326008)(508600001)(54906003)(53546011)(47076005)(316002)(9786002)(31686004)(31696002)(36860700001)(7636003)(336012)(426003)(83380400001)(356005)(2906002)(2616005)(5660300002)(110136005)(50156003)(43740500002)(473944003);DIR:OUT;SFP:1101;
X-OriginatorOrg: xilinx.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2022 11:24:03.2027
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 34171964-2125-4f1e-7384-08d9ebbead51
X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.80.198];Helo=[xir-pvapexch02.xlnx.xilinx.com]
X-MS-Exchange-CrossTenant-AuthSource:
	BN1NAM02FT007.eop-nam02.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR0201MB8758

Hi Stefano,

Thanks for your feedback.

On 09/02/2022 01:50, Stefano Stabellini wrote:
> On Sat, 5 Feb 2022, Ayan Kumar Halder wrote:
<snip>
>> @@ -95,6 +97,7 @@ enum io_state try_fwd_ioserv(struct cpu_user_regs *regs,
>>   bool arch_ioreq_complete_mmio(void)
>>   {
>>       struct vcpu *v = current;
>> +    struct instr_details *dabt_instr = v->io.info.dabt_instr;
>>       struct cpu_user_regs *regs = guest_cpu_user_regs();
>>       const union hsr hsr = { .bits = regs->hsr };
> I don't think that v->io.info.dabt_instr should be a pointer because at
> this point the original structure is long gone. The original field was a
> local variable mmio_info_t info in do_trap_stage2_abort_guest. So by the
> time arch_ioreq_complete_mmio is called, the original variable has been
> deallocated.
>
> Instead, v->io.info.dabt_instr should be a "struct instr_details" (no
> pointer).
I see what you mean.

arch_ioreq_complete_mmio() is called from leave_hypervisor_to_guest(). 
That is after do_trap_stage2_abort_guest

()  has been invoked. So the original variable is no longer valid.

<snip>

> +
> +            /*
> +             * When the instruction needs to be retried by the guest after
> +             * resolving the translation fault.
> +             */
> +            else if ( info.dabt_instr.state == INSTR_RETRY )
> +                goto set_page_tables;

As discussed with Julien on IRC, when hsr_dabt.s1ptw == 1, Xen should 
only invoke p2m_resolve_translation_fault(). If it returns an error, it 
should send an abort to the guest. The reason being there is no need to 
invoke try_map_mmio() as the gpa is not a mmio address. Also, Xen does 
not support the use case when the guest places the page tables in the 
MMIO region.

I will wait for Julien's comments before sending out a v8 patch.

- Ayan

> +
> +            state = try_handle_mmio(regs, &info);
>   
>               switch ( state )
>               {
>               case IO_ABORT:
>                   goto inject_abt;
>               case IO_HANDLED:
> +                /*
> +                 * If the instruction was decoded and has executed successfully
> +                 * on the MMIO region, then Xen should execute the next part of
> +                 * the instruction. (for eg increment the rn if it is a
> +                 * post-indexing instruction.
> +                 */
> +                post_increment_register(&info.dabt_instr);
>                   advance_pc(regs, hsr);
>                   return;
>               case IO_RETRY:
> @@ -1985,18 +2056,12 @@ static void do_trap_stage2_abort_guest(struct cpu_user_regs *regs,
>               }
>           }
>   
> -        /*
> -         * First check if the translation fault can be resolved by the
> -         * P2M subsystem. If that's the case nothing else to do.
> -         */
> -        if ( p2m_resolve_translation_fault(current->domain,
> -                                           gaddr_to_gfn(gpa)) )
> -            return;
> -
> -        if ( is_data && try_map_mmio(gaddr_to_gfn(gpa)) )
> + set_page_tables:
> +        if ( check_p2m(is_data, gpa) )
>               return;
>   
>           break;
> +    }
>       default:
>           gprintk(XENLOG_WARNING,
>                   "Unsupported FSC: HSR=%#"PRIregister" DFSC=%#x\n",
> diff --git a/xen/arch/x86/include/asm/ioreq.h b/xen/arch/x86/include/asm/ioreq.h
> index d06ce9a6ea..ecfe7f9fdb 100644
> --- a/xen/arch/x86/include/asm/ioreq.h
> +++ b/xen/arch/x86/include/asm/ioreq.h
> @@ -26,6 +26,9 @@
>   #include <asm/hvm/ioreq.h>
>   #endif
>   
> +struct arch_vcpu_io {
> +};
> +
>   #endif /* __ASM_X86_IOREQ_H__ */
>   
>   /*
> diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
> index 37f78cc4c4..afe5508be8 100644
> --- a/xen/include/xen/sched.h
> +++ b/xen/include/xen/sched.h
> @@ -160,6 +160,8 @@ struct vcpu_io {
>       /* I/O request in flight to device model. */
>       enum vio_completion  completion;
>       ioreq_t              req;
> +    /* Arch specific info pertaining to the io request */
> +    struct arch_vcpu_io  info;
>   };
>   
>   struct vcpu
> -- 
> 2.17.1
>


From xen-devel-bounces@lists.xenproject.org Wed Feb 09 11:25:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 09 Feb 2022 11:25:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269026.462994 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHl63-0005RC-AW; Wed, 09 Feb 2022 11:25:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269026.462994; Wed, 09 Feb 2022 11:25:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHl63-0005R5-5f; Wed, 09 Feb 2022 11:25:15 +0000
Received: by outflank-mailman (input) for mailman id 269026;
 Wed, 09 Feb 2022 11:25:14 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=XFrC=SY=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nHl62-0004oi-03
 for xen-devel@lists.xenproject.org; Wed, 09 Feb 2022 11:25:14 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f288c6f1-899a-11ec-8f75-fffcc8bd4f1a;
 Wed, 09 Feb 2022 12:25:13 +0100 (CET)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2056.outbound.protection.outlook.com [104.47.13.56]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-3-U4BJNrIxNJKXeqGy4vLthw-1; Wed, 09 Feb 2022 12:25:11 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DB3PR0402MB3740.eurprd04.prod.outlook.com (2603:10a6:8:e::11) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Wed, 9 Feb
 2022 11:25:10 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.018; Wed, 9 Feb 2022
 11:25:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f288c6f1-899a-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644405912;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=LUPm9P7Soho4UbNgVOVbXKJ0UODsyWCejIETI+XeZvQ=;
	b=lOfWPlhRKmwiJ1YeazJ7vlen5DxkVfcSrJHYozQgN9HdRjwJZdh5wqYfrZBGgIIG9oiDXw
	phqEEJbMZ8E2puIEp3fUeCn2CmkZ3YJ/FjNhm8qFoWf/isqiuRBe535J+MxSnZ4YbYVUq4
	nAV5hgm5Rs5HkK9LojY9k0qAA5gRkqY=
X-MC-Unique: U4BJNrIxNJKXeqGy4vLthw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=kb5B3CTNnDc0ClWFkSKaEJz+chOdK2F7KzPFi/FVahsNAa7ItL+AxicKtdvhYfo0IA74y/LoLgLuQswI2EBwdEHM7vMNH1YJwR9DMCOZ1HEOLaCzSEqyOAmbIy+M3Q5WP9cgOoWBUBqYEAVF7pDaIFb33z0bEunluqH3Pfhe8ERcP+0b12CRfTr+HyZgnrwhsFt/EJ6FFBufIPPhMbLHCK0bfuOqc0JsVB8GUe7TUlQrNrh613mW5nyoRz67fnsHTqbHZXTaXggt8lhwN92julxpSSvONVy2haj32beyeWK6otyam9kboZ6UIUdzzm0uBgFG5huETzjpNuh14jK2kw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=LUPm9P7Soho4UbNgVOVbXKJ0UODsyWCejIETI+XeZvQ=;
 b=TwXU3UIxK/BB3qakySqbdnnDFvYz2ZUKnX+sjI5OsKLONktZQYLHj1MIPQFA5HXcZI+FUNOHBJuEb72/sJ27COP0nfOTV+dvDZqjCB/PACRCVkV/KZJCnL9JIwtLezilioRwethAOvpAw8hKoPADiemItnAcqUdZW+u8UgofGlox56VWqnwIif762ZC/uUtpGJBycL1/6HLV9sO89PDmar2c1KYqw13H80kYUwBKuv0JLuDnMQPV73OoTqj/JKosWDJvD6Dyduf6NcoyknUWx8jH0jNRicwVGzngv1XcAZSXpYdM7A5hi7uLc0scGGn4oXi/lnzY+y9UdttxF5gL3g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <fe2e94e8-9e46-82be-6e83-391f4709ef75@suse.com>
Date: Wed, 9 Feb 2022 12:25:07 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH] x86: Use low memory size directly from Multiboot
Content-Language: en-US
To: dinhngoc.tu@irit.fr
References: <001301d81da4$4c993260$e5cb9720$@irit.fr>
Cc: xen-devel@lists.xenproject.org
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <001301d81da4$4c993260$e5cb9720$@irit.fr>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR08CA0001.eurprd08.prod.outlook.com
 (2603:10a6:20b:b2::13) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f17d6134-683a-4883-fef3-08d9ebbed4ed
X-MS-TrafficTypeDiagnostic: DB3PR0402MB3740:EE_
X-Microsoft-Antispam-PRVS:
	<DB3PR0402MB3740E5C737A306D8F723DADFB32E9@DB3PR0402MB3740.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	rAPhpV3W2iTCSiO8nFC39DvkcyKFF+zPaBHq/04O+Ej8QOOsE7PNZyX9rEThuRGcaFftjWlGrKHTc5csQI6DBefTMhCdntXgZa2+1rASZ6RYeJAS4kPGIxIeIj/3JDaFcxvjaSbp585RvscPmt9+k6rHtcRcIomji1ZpHp1t6Qy/MTUp3bpwP9ScG8JRRtuFxZiFmiy+0JyQOUD9GmJATglaS/FdG1U83DMZE6fzCkI8MSGg9xvaWf3qonjpzB6zM4RvQQ/cbf0FGSMPRpDdqMMLO8CNaVXh+bS/nI9yivlIy5YlI5cd8jk1VSFc5vEqUG3rasX92EBfYOg5hiLqTW+zegOgDZ5zLhxT1vyCLBmd+zZjYHGmELLE1Fzl67JBFENWuvG1WPVN4MmgszC4BMrzi4zTO4P2rNFGHZT5l10rH7urWRrvlGG+tW5XYT1vWeg5FxIYcoPCCmhYGqQLayb0qkWESCD3RCUKiAWBHYnO5p+OQTWDHZOmdh21cJmZcECy2uCIx7D8JlMFCoyeEcUFM7xsSUa7rN2LfbhrhGVoMmC4URlfSqXEN+LYNcuthPuyEtImrpdo41CH4MS1+IFxPw2dJbvn7hJuypQeCdeN2uOo1kItwAy5Px4PskSuJlzjeK/BP8vci9s1ZW+UezqXpsQldkRrc1+yNl4+pcxmbT8M8BLRnFSBHniatjimrNt14myVAzHXVlRrXbuaQQmX1KLONvhRE3eo082iKCFbt0pjSnPOKN0MZ2O8IwwD
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(31686004)(31696002)(86362001)(53546011)(316002)(2616005)(6512007)(2906002)(6666004)(6916009)(6506007)(26005)(186003)(83380400001)(66556008)(5660300002)(66946007)(66476007)(6486002)(36756003)(8936002)(38100700002)(4326008)(8676002)(508600001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UFlLQ1F2MWpyeXJ2eVNtNlNrTnRUSHFqYUhscUxNYUVhVnZVam9xOWZ0T2J3?=
 =?utf-8?B?WDdvR1NYbCtPZUtDMXpOSW5hTktHQkVBdDVZZ0pFM1BKOHRNSXBZUS8vTlI5?=
 =?utf-8?B?d1h5dFMvdytwVjNPOEZSaFhKVnhiNkY3cHROYzZkNktqYWlJUVh2TzRtd0Nj?=
 =?utf-8?B?K3ZIbFUyOVFQK25LM2R6c2NPK251bkFjUVdDTVh0YW51RTJkVGJMaFRlVlVH?=
 =?utf-8?B?R1VVSHhnZWxabzZRMFkxZFBKd0FtL1cra3JnUDY4ZWRKenVLbEk2eFBudk1q?=
 =?utf-8?B?R004b0FQVGtWSjZ3UjMrNUlOdk5SSEs2Tk5CK3hseWtjMUFKTk9mTlhROU5H?=
 =?utf-8?B?Y2trb29FZ0Ruai9HbWhaSnM0UkVFM0tOOVE1bGJvcDhyMHdSQ1F4bC8rM0JP?=
 =?utf-8?B?OUVXOTRiQWIwZ2tBNk1VbzU4WXkvbGZpSWtpb3lhVXYrelBZdnJ5Y3IxVUJi?=
 =?utf-8?B?NVd2RGJhcVYzR1pPTFpVMUY5VFk4eWtKYjFkd05lOEFWVjVmaVNneHNBTjU0?=
 =?utf-8?B?SXNiYmhsYTlNNEVpWXFvdDdVZGNjQm1TRUtRdVlJVElVRjQxZnMxVjV0aGdK?=
 =?utf-8?B?VTZJZ09KaFZoK1JSb0NWR0dsZ3h1dXA0UEVGcXBzNlVlR0dRd0Jkb2E5RHRB?=
 =?utf-8?B?MUlxTmxGQjNWSHpEL0lBQm5hdU1HZWhiYkVtN3FjMmJsbklpRTcrR0FqbzRp?=
 =?utf-8?B?NlU1MXJXZTNtam1qWHJJalJLN0xDZHl1d2VQNVZyVmIza1FFaThxNHBIOFZy?=
 =?utf-8?B?UEs1YVJVMzE2RHJLaXpaVTc1MFl0UURTNEppVU1PbUtYM0N0UUpsTDZ3Qng5?=
 =?utf-8?B?ZlAraHRyK2xlMFlVKzV1WnFhRnZLR2c0R1hYNDZ6amkvYitTT21YSFhwYjZC?=
 =?utf-8?B?ZVFYUmNSR3QybWFydFZIU3M1ZC81aXU3QnZCL0dCeDhHejI1MHkzMnBBcUlI?=
 =?utf-8?B?aUVmS3M5L3o0TVo3R3NoTmVsd0d2WjR6VTRiS3dQaFRlaTNmWm0zRHNteGFv?=
 =?utf-8?B?d0lQdGdMVExTRVQxcG4zdHRWNGhLcVJLdEZoc2l6U1F2NGZUcDN0b3F5Smcz?=
 =?utf-8?B?dmYzZy9IN3BQUXp2NHU1Qzk0d0pheWdsNjRGbWFXMFdvMzA5dEFmc3BxUEdk?=
 =?utf-8?B?OStkZXdyWU5KZ1lqM1RUZGY2VTlBaVVvckRuemRZSWJiU2s1UnRkbG84Snhk?=
 =?utf-8?B?TzN5Q2t5NEJMS2ZNeW9PVnYwUjJZWmdLZWRNN2NqcjY0c0JCTHowb2NhQTMy?=
 =?utf-8?B?Nm9odjVCZktEcWNPcWRodjYzOENxOUE0UmhEUnREV0J3WHZpNktkcjAxZVZV?=
 =?utf-8?B?WXIxZTNianJ4ayszRWJNaUxHNW9wbVN1M0U0SUlML2lTOHFDOU1zc0xhUFlj?=
 =?utf-8?B?YlVEdVNsYXZ1d3pKZG01d2IwanIzTlB4WWEvWHBLbi9hTlQvb21BblZRajZ6?=
 =?utf-8?B?MFVjN2tUV1BpK2xUNmkvV2lNRmNDc0J6Ull2NlV4REZIK1ppMStkVkNTSHNu?=
 =?utf-8?B?bStwWHhmMnF3UW1sRnJsYitWZTRCYkVWVEhGOUgrc0tLM3hvWXdXU0xTbkgx?=
 =?utf-8?B?ejZ5eHhYODhQODhYUXgxKzdPYlFUS0k2T3pLQXVaaDl6QkRwZm1HSVp2bEYy?=
 =?utf-8?B?YS92ZGQ5U0FyNnR6V3RYZ2F2NVNmTGZUakl6aC83b1JQZXkzYU9pcGw0WWNs?=
 =?utf-8?B?OGovWXF5aDhQN3A4dVpTeWduZm9yMlk0RnNtOHIxaHZzQmFhaW9wTTlHbTNk?=
 =?utf-8?B?VmFOa2owako0QXpxZkRDeUdONHhIMmZwUmVjMTZXRmJuNHp4V21BMnJ2SGJP?=
 =?utf-8?B?Zm1TeVJNdFdpNEhvTUdBQTd3VFdJNnc1OUU3MHAzU2dndm9nNHZyWUdaRFNa?=
 =?utf-8?B?dFNLNHprenN5SGU4WkplSWpPeEErRHU0VE9aTjlyOUpLRjBMRmUwQ0pmWk1w?=
 =?utf-8?B?N3pTeGhSOGtxL2IwVElsVEZGakI4WjZUQmY4K290OEFMRW9pdHZzek9uQVhN?=
 =?utf-8?B?djJnM2l4clVWTWgzNzdTamVsVWlUOFY5TU1RWTFqOHZGM05jMnJpb0FVMVUx?=
 =?utf-8?B?MlNVQ0tPRWVNeHQyWnlwemxBVlN0L2REMWl6bEdxcjNHMzdROVo4NDBpdVBD?=
 =?utf-8?B?MnB4S3h5cTJsalBmSFM1VmdFVWRJRVI4VzNPQ253aGM0aXF0Yjg1RXhGRnZM?=
 =?utf-8?Q?bZU56qkM3IV8oCDTg5g7nWw=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f17d6134-683a-4883-fef3-08d9ebbed4ed
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2022 11:25:10.1128
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gT5WHVpTLhzhJOwgtxSEAcRMXvN1mDuwDJADuDx37FDLQkFLs2I+QbifV0atoXUiu/EEBo/uJPR1mmPenR7qIA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0402MB3740

On 09.02.2022 12:00, dinhngoc.tu@irit.fr wrote:
> Previously, Xen used information from the BDA to detect the amount of
> available low memory. This does not work on some scenarios such as
> Coreboot, or when booting from Kexec on a UEFI system without CSM.
> 
> Use the information directly supplied by Multiboot boot information
> instead.
> ---
>  xen/arch/x86/boot/head.S | 30 ++++++------------------------
>  1 file changed, 6 insertions(+), 24 deletions(-)
> 
> diff --git a/xen/arch/x86/boot/head.S b/xen/arch/x86/boot/head.S
> index dd1bea0d10..31a0663e6d 100644
> --- a/xen/arch/x86/boot/head.S
> +++ b/xen/arch/x86/boot/head.S
> @@ -524,33 +524,15 @@ trampoline_bios_setup:
>          mov     %ecx,%fs
>          mov     %ecx,%gs
>  
> -        /* Set up trampoline segment 64k below EBDA */
> -        movzwl  0x40e,%ecx          /* EBDA segment */
> -        cmp     $0xa000,%ecx        /* sanity check (high) */
> -        jae     0f
> -        cmp     $0x4000,%ecx        /* sanity check (low) */
> -        jae     1f
> -0:
> -        movzwl  0x413,%ecx          /* use base memory size on failure */
> -        shl     $10-4,%ecx
> -1:
> -        /*
> -         * Compare the value in the BDA with the information from the
> -         * multiboot structure (if available) and use the smallest.
> -         */
> -        cmp     $0x100,%edx         /* is the multiboot value too small? */
> -        jb      2f                  /* if so, do not use it */

The comment here is a pretty clear indication that bad values may have
been observed, even if this was only in the distant past. But we have
to not regress even on very old boot loaders.

Is the kexec case recognizable by any means (including to distinguish
kexec properly communicating the value vs it not doing so, as iirc it
was said on irc that this didn't always work correctly there), such
that we could skip using the BDA value in that case?

Jan

> -        shl     $10-4,%edx
> -        cmp     %ecx,%edx           /* compare with BDA value */
> -        cmovb   %edx,%ecx           /* and use the smaller */
> +        /* Use lower memory size directly from Multiboot */
> +        mov     %edx,%ecx
> +        /* From arch/x86/smpboot.c: start_eip had better be page-aligned!
> */
> +        shr     $2,%ecx
>  
> -2:
>          /* Reserve memory for the trampoline and the low-memory stack. */
> -        sub     $((TRAMPOLINE_SPACE+TRAMPOLINE_STACK_SPACE)>>4),%ecx
> +        sub     $((TRAMPOLINE_SPACE+TRAMPOLINE_STACK_SPACE)>>12),%ecx
>  
> -        /* From arch/x86/smpboot.c: start_eip had better be page-aligned!
> */
> -        xor     %cl, %cl
> -        shl     $4, %ecx
> +        shl     $12,%ecx
>          mov     %ecx,sym_esi(trampoline_phys)
>  
>  trampoline_setup:



From xen-devel-bounces@lists.xenproject.org Wed Feb 09 11:37:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 09 Feb 2022 11:37:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269037.463005 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHlHx-0006ze-DZ; Wed, 09 Feb 2022 11:37:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269037.463005; Wed, 09 Feb 2022 11:37:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHlHx-0006zW-AL; Wed, 09 Feb 2022 11:37:33 +0000
Received: by outflank-mailman (input) for mailman id 269037;
 Wed, 09 Feb 2022 11:37:31 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=XFrC=SY=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nHlHv-0006zN-P4
 for xen-devel@lists.xenproject.org; Wed, 09 Feb 2022 11:37:31 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id aa1a2245-899c-11ec-8eb8-a37418f5ba1a;
 Wed, 09 Feb 2022 12:37:30 +0100 (CET)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2051.outbound.protection.outlook.com [104.47.12.51]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-28-tRhVkFbIPz6XOhgnVyTPJg-1; Wed, 09 Feb 2022 12:37:29 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0401MB2350.eurprd04.prod.outlook.com (2603:10a6:800:2a::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Wed, 9 Feb
 2022 11:37:28 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.018; Wed, 9 Feb 2022
 11:37:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: aa1a2245-899c-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644406650;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=SWMMrLLJn3NpHnUd6OT41d2b9nG86WZvF59IBkaEkIA=;
	b=Dv9dWdwyZBnu4J6svUF+OE6231nN4uIoklNnmynVrN0lLB5jcljKGJXym03ilt6CLI7JaJ
	t6blwdtyxLYwdfbgDKYO3uOm4BiVtvOcVUZ9jY/+dL3/DSv3tVQZ6ABNMfKw8CM+a8AT2F
	9W67KeR5nMgU88QO5Xq6h6UIrA8ANx0=
X-MC-Unique: tRhVkFbIPz6XOhgnVyTPJg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=D9MhEkw4QZba/tgr75vqjItPAQYCLOSEKrCoUBZSvDn50mQ7grvJ+smyw3wR/KlBV8YJT0PrPL5mBYvybCYOW0flDgcN+KXt7MBt9UafEr35lg/GtLuWQw6//6zanU+ORve+GkwfFe3AxiVJ1oSFrWItWrjck7h9JhrVpQfeuXprsYodosEpJCkbDrQyaTvzLCM77ddctci0g1n6e+5hDFlZaScIin0hKp9pf6fFupIlOe5KVfxvmaVZ/8Ex1Hj67FP1EqHxPnQ2T5BpiNXSs4s0muNkSGaY6uOlvDFeGN9kPtSRWI+Z1rWDMPSEfya+BJq7X/5FpnYzwnAt4nfZeA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=SWMMrLLJn3NpHnUd6OT41d2b9nG86WZvF59IBkaEkIA=;
 b=l3cBu1Z+tbjIg1b6oAjdbXADEvREHBRcCpkcQnrycEGCDgDxiwuSWd4LQPCUfCL8PVGbnl3j6j97+Q4PNpWja2pdgkZkYVDMfqiKALNHFdeHCcmqlMsCmJ0uVHx8EQaDI9Zd0DU6pxhE1Mkl1hDvbNmWqLN1xrQwqdESaVSyHp8dWKDUTR9FsckkD5tGJCe4fAxvhKy1Z3oUzICGVZG7RRQyAK++2OzpIfCXDQ1OQqhABoGulqSSNZrRPFLBDl883EvrHJsilK5spTL4nG0B5mkjHaI+ATQv9MyCoRqwulhGlc9QiPEkFPrwv5Eo4kPdAxQvDtXu3jjnTOQyBknFaw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <4c44dea8-920b-6169-0853-01e18e89db94@suse.com>
Date: Wed, 9 Feb 2022 12:37:25 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH] x86/dom0: Add log for dom0_nodes and dom0_max_vcpus_max
 conflict
Content-Language: en-US
To: Jane Malalane <jane.malalane@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20220209103153.11391-1-jane.malalane@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220209103153.11391-1-jane.malalane@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0159.eurprd04.prod.outlook.com
 (2603:10a6:20b:331::14) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 988392d5-b5a2-4eb6-7965-08d9ebc08ca7
X-MS-TrafficTypeDiagnostic: VI1PR0401MB2350:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0401MB2350EA3AFD66C058039D7749B32E9@VI1PR0401MB2350.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	kpnS0mPNrLo7DjY7jnf30j2mZvitvhxCx1qAvJaGPO9PFfl76DwKWNwZyGhlN0eJn9zYxwgo0GYdgtvzKtyxGDptognDenbQIxHWE8zZSrYh95m4rNXiA5vHPXWEotI5yUxKGpjCn4tFna7FEsAPoNb6aZqyYPh2dxjtAE/B6nnUSGAYESwO0EmILSGR1xDUM5bLzZvm8jBry/MmYhBP4rjGVQAxYMk6JH++WvzxrjOGflSqOtjfk7I+1D5Ks/hXLS1ueKnY3fyyjjoG8xqMoKRu2Sa0G+qUiTPyZBbMyWR0hkqCeFPKL1tJf2mQen+zAVwFFDiNSHU6/SYs+l2NXDkE2T20HK4dIoLxy2Bsfv/dDU7I6Y9hmYCY3lPVw/6BtZSMy47bVrHmEgqSuOfX0xvHT2fdDaKWnnfh5GAepnbkRHjejoU3DK8h7UXoMPBwXvM5pAFUY23JnbjRwfodZEgv+AL4mb4f9pJ6/6BKO1/B6bxKCkV5e2Gm9PZY2XJk4DJ+Z3wgdZ5KmVD1l0oLa88O24+K7YInJjsz6CCmQVa/NpXZAG3l18p9rRJjPeC5p6yMqQXsJ/0Z7lU3bxQWUUNLSsyanjc1YpzhH4St1tFeJkr+0zrvXlh5JOYhDMaRt/6kL0L3x0OSQvjYYGiu7a0K3ewTF9eiCvdfj7hMH5irSd4EWJs6Ev3hUsbZyMBX/+825TNOHfag48FSRPMpQA32+YcJqMIPsJGYYRvBXNF2hWzh33su/pkdCl64m018
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(83380400001)(53546011)(36756003)(8936002)(66946007)(66556008)(508600001)(66476007)(38100700002)(8676002)(86362001)(54906003)(6486002)(316002)(6916009)(5660300002)(26005)(2906002)(6506007)(186003)(6512007)(2616005)(4326008)(31686004)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?YUZWdURuN08ySzhYcHFqTzI3MmFjZ3dsbXRVUkJNVlJqZFR0cEJWejV0UnhX?=
 =?utf-8?B?aFZmZW5EUkl5TFl5aTdQa2dMZXU3TFRGOVlPTWo4cjB1emZJeEpJbk90MUtw?=
 =?utf-8?B?ZStybHRBbTk2YjV0aGxQT1VyY2FKS01jTWVGRzFkbzRJTXJyRFhSS1ZqWHVp?=
 =?utf-8?B?N0N6dXpaUXA0b0NOZGRXZ0Z4OVBzNmVLdEhqOUdsOERTMzFMa291Z3B6dnQv?=
 =?utf-8?B?RVl1ZHd0eHBsR3VVNVZFRVdFdERLRU45TWQ5bmRzNVRWRTRKUUNiemJpdVNn?=
 =?utf-8?B?ZU5oMWlTSXZuSXBvM2dvQnJWNFZXNFlJb29WRTlzOVZDLzc1UC9neG10U3Bl?=
 =?utf-8?B?dFNtenBZcFBVc3crSVM1aXBaY0NZckVXZmFPcEpTSWd6Smk0STBvZCsrbTV0?=
 =?utf-8?B?OStGY0FMNThsQUlydGx0Q2hIZ3NvT083TzRSRzYrNUpNbG5wL0xKN1JON25x?=
 =?utf-8?B?VFJ3cmo3T2hOZFVKbU1hUk9TK0YvOC8zVEltcTh6OGEwNU9zRU1lOUFyN2xr?=
 =?utf-8?B?czNJTWJOdjJmUGZOK3crYTNJRUlwUFlvMmczL3Y5VDdkVW9ZRnlBM0V0QmtH?=
 =?utf-8?B?UzFJSGF1SmtTQXM3Mys2OWpLeU1OQ1EzK3p2b0dwLzZmQlJFMjlhSEEwbHVP?=
 =?utf-8?B?TjJOZm9Yc3lWdmRIaE1jVHk4ZE0yV3g2KzFlU0Z0elpHeEdCTjBNQVExN3Rq?=
 =?utf-8?B?YlRLbzBkVWZ3SXpLSkFWckczbWI4ZDc0cTlmNExjRitYTmlxRDRqQ3E4ODlu?=
 =?utf-8?B?cXdZQXFXUmI5Nm5uTG1jb21zaHJ4T2o4YmNzK21GbkVaaDZJK0VpazBnMnE2?=
 =?utf-8?B?eGFQdnV3MkdYZkdxV09DaUg5Y1ljd2cvdzNhU1lHR2tOYjYyZ3VrcHJqRWdC?=
 =?utf-8?B?TE1jc2lBWTM5TklKTUlqeGQydW9Ya1RnbVczSUsxVENKbUNhdXVmM1l3ZlFS?=
 =?utf-8?B?SWYxblppYzFrcFRzeHZlMVNrMWNmUThHZ2Q5YWZJUHlpMXYzNmN2eDdYRXJD?=
 =?utf-8?B?RXVQSHVEM0s0N24vSGVaeUs3OHpYOXhKVGMxQTZzc2hXVkVXOGY3T1dtUXFD?=
 =?utf-8?B?d2owZkJ4Z1hueW1lN0duQjBJaU1idFdlbXBkb1ZRaEpSeXIvWFl0RGhrMnBI?=
 =?utf-8?B?NXQ1TmZFTUpQMEZtdGNVMmtJcGZwUkM3cXh6UDFRQlA5RUtCc2NLM0RDWDFU?=
 =?utf-8?B?NTBPc1I0Ri9qS1V6L2dxMFdhU3czaERaTDN2N3ljUkJzQk5OaEtlVzc2b3VD?=
 =?utf-8?B?U3Ryc3hVWEFybjU5dGVqWFVXZzh6U29VV0txOHlDRmlvc0gzNWFqMVJ3bWxJ?=
 =?utf-8?B?TG9WZlkvRlJsZERWZEVMa2V5d0Evd3BOMC9VVTZRcTFBSUk0M0tySHJaZzZj?=
 =?utf-8?B?MFRLMDhUYTFxdXR4Zk5NRXUzNGswK0pGemtiektydkZHZkRLbHJUM3JVWXlE?=
 =?utf-8?B?dFpKQkx0T2xCb2pHWUZlSjBwZmJSMkdacU83Y05adTkyU3g4VmZrVFIzV0Ry?=
 =?utf-8?B?U2JEWnJVaU5HaFV6dVNzUTB3cnpReVQvVjRPcXY2YTBES1RnOUw5eFdkTWEr?=
 =?utf-8?B?OHI5eS9LR3laODhsMTdzbVp2d2JvN2FBTjJNdnFSVExSSEM1ZG5JU0JwMkhk?=
 =?utf-8?B?R2JyYU81YXN1QU5HRU40U29NMnA4WEVCWXpDU1dvTlAyWXdRVi9IK09BUW5r?=
 =?utf-8?B?azRmanoyemtuWEVSTjRHUzEwblRHUzZ2Z0o1NWZiUDlRRnZad1hqK1RZVk01?=
 =?utf-8?B?UTBZUFJaQlhVcHlGSlVnaGVLblBOUFZYUEFQK0hLaEt1bXoraDlySithS2dU?=
 =?utf-8?B?Nlc5WFF4NnFrZjBPR0xWMXlZdjZxTG5MRkhzOHlNTU1VdTdNZDhaOFlnem5w?=
 =?utf-8?B?Y2hNTkdmeTB2OXJDWWxoNVZyNnpRYUhaVVcxRml4NldwZSswUlJMVXlmaVcv?=
 =?utf-8?B?akxqYWpxTzZMOUluSGFtTjI1QmM5dE00M2NzSmtxR1JWV01HTDBOV2pYajF3?=
 =?utf-8?B?SG0yRWRENjN5ZENqNmJxM3daU3I2SUFhUG83MWZOZUJlZzZKT25rUTh3RHJJ?=
 =?utf-8?B?ZmVrV1BuejNURUVwMllocmp1MjcwdHlYbDJvbFdzV21aejJ4VjVxdW1ZMUw2?=
 =?utf-8?B?cDYwREJKWjQ1ZjlGVVp0UVUwWVdWeHp5S0YyaWRhVDYxZzAzNThJQkNHWnNx?=
 =?utf-8?Q?sr2PVuZq4Ox662PwpHudWbM=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 988392d5-b5a2-4eb6-7965-08d9ebc08ca7
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2022 11:37:27.7076
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2FkijuDn1Jdzc5F4R1z/kVAD9wv3+yVtlzgfeHpP20Wx80DAnMfLt7Ku/VBQsxmITCRHWtkC9tXqKNa3TDQWWA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2350

On 09.02.2022 11:31, Jane Malalane wrote:
> This is not a bug. The xen cmdline can request both a NUMA restriction
> and a vcpu count restriction for Dom0. The node restriction wil always
> be respected which might mean either using dom0_max_vcpus <
> opt_dom0_max_vcpus_max

This is quite normal a case if a range was specified, or did you mean
opt_dom0_max_vcpus_min? But min and max get applied last anyway, so
those always override what was derived from dom0_nr_pxms.

> or using more vCPUs than pCPUs on a node. In
> the case where dom0_max_vcpus gets capped at the maximum number of
> pCPUs for the number of nodes chosen, it can be useful particularly
> for debugging to print a message in the serial log.

The number of vCPU-s Dom0 gets is logged in all cases. And the
reasons why a certain value is uses depends on more than just
the number-of-nodes restriction. I therefor wonder whether the
wording as you've chosen it is potentially misleading, and
properly expressing everything in a single message is going to
be quite a bit too noisy. Furthermore ...

> --- a/xen/arch/x86/dom0_build.c
> +++ b/xen/arch/x86/dom0_build.c
> @@ -240,6 +240,11 @@ unsigned int __init dom0_max_vcpus(void)
>      if ( max_vcpus > limit )
>          max_vcpus = limit;
>  
> +    if ( max_vcpus < opt_dom0_max_vcpus_max && max_vcpus > opt_dom0_max_vcpus_min )
> +        printk(XENLOG_INFO "Dom0 using %d vCPUs conflicts with request to use"
> +               " %d node(s), using up to %d vCPUs\n", opt_dom0_max_vcpus_max,
> +               dom0_nr_pxms, max_vcpus);

... the function can be called more than once, whereas such a
message (if we really want it) would better be issued just once.

To answer your later reply to yourself: I think printk() is fine
here (again assuming we want such a message in the first place);
it's a boot-time-only message after all.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Feb 09 11:46:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 09 Feb 2022 11:46:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269045.463016 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHlQK-0008PJ-9I; Wed, 09 Feb 2022 11:46:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269045.463016; Wed, 09 Feb 2022 11:46:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHlQK-0008PC-62; Wed, 09 Feb 2022 11:46:12 +0000
Received: by outflank-mailman (input) for mailman id 269045;
 Wed, 09 Feb 2022 11:46:11 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=50R8=SY=irit.fr=dinhngoc.tu@srs-se1.protection.inumbo.net>)
 id 1nHlQJ-0008P6-9D
 for xen-devel@lists.xenproject.org; Wed, 09 Feb 2022 11:46:11 +0000
Received: from smtp1.irit.fr (smtp1.irit.fr [141.115.24.2])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id df713ade-899d-11ec-8eb8-a37418f5ba1a;
 Wed, 09 Feb 2022 12:46:09 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: df713ade-899d-11ec-8eb8-a37418f5ba1a
From: <dinhngoc.tu@irit.fr>
To: "'Jan Beulich'" <jbeulich@suse.com>
Cc: <xen-devel@lists.xenproject.org>
References: <001301d81da4$4c993260$e5cb9720$@irit.fr> <fe2e94e8-9e46-82be-6e83-391f4709ef75@suse.com>
In-Reply-To: <fe2e94e8-9e46-82be-6e83-391f4709ef75@suse.com>
Subject: RE: [PATCH] x86: Use low memory size directly from Multiboot
Date: Wed, 9 Feb 2022 12:46:07 +0100
Message-ID: <000001d81daa$a0790080$e16b0180$@irit.fr>
Content-Type: text/plain;
	charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQJrcJfgWzm7vtgGx61EYtSg2KG0pwIgBme2q1NzIkA=
Content-Language: en

> The comment here is a pretty clear indication that bad values may have =
been
> observed, even if this was only in the distant past. But we have to =
not
> regress even on very old boot loaders.
>=20
> Is the kexec case recognizable by any means (including to distinguish =
kexec
> properly communicating the value vs it not doing so, as iirc it was =
said on irc
> that this didn't always work correctly there), such that we could skip =
using
> the BDA value in that case?

Old Kexec used to report the value in bytes instead of kilobytes like =
it's supposed to. I can make a special case for that so that we won't =
have to rely on the BDA.



From xen-devel-bounces@lists.xenproject.org Wed Feb 09 12:17:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 09 Feb 2022 12:17:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269072.463046 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHluT-0003k3-2C; Wed, 09 Feb 2022 12:17:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269072.463046; Wed, 09 Feb 2022 12:17:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHluS-0003jw-VO; Wed, 09 Feb 2022 12:17:20 +0000
Received: by outflank-mailman (input) for mailman id 269072;
 Wed, 09 Feb 2022 12:17:19 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nHluR-0003jq-NO
 for xen-devel@lists.xenproject.org; Wed, 09 Feb 2022 12:17:19 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nHluR-0003kJ-CL; Wed, 09 Feb 2022 12:17:19 +0000
Received: from 54-240-197-228.amazon.com ([54.240.197.228]
 helo=[192.168.1.215]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nHluR-0002BV-66; Wed, 09 Feb 2022 12:17:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=xwC83qprue0+vCj/j23rpgpvrwFpknweT159heWGT3g=; b=CdqLeVdsvei902+cnR798WrQqd
	3N2Hfb/tfcp7G/eXzUjzmGtsDbsUKLwA8czTP2T/I5YiAZZdGFQFogTF9ug7b3M6ZJX2xSfA6GTfa
	TXkMjgxzE7MLWr70f6aymXGjit4mr23BXk62WrYmn+6ypBuYEDI3fN6e//IU2j5Ud+a4=;
Message-ID: <316bd101-af8b-d2f0-1db5-ea6c583acd59@xen.org>
Date: Wed, 9 Feb 2022 12:17:17 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.1
Subject: Re: [RFC v2 3/8] xen/arm: Export host device-tree to hypfs
To: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>, Juergen Gross <jgross@suse.com>
References: <cover.1644341635.git.oleksii_moisieiev@epam.com>
 <e440e4f16a506ecc87078635dbb3fda2ebd45346.1644341635.git.oleksii_moisieiev@epam.com>
 <b88f6a50-6e9e-5679-8d25-89e26031e88e@xen.org>
 <20220209102037.GA1025795@EPUAKYIW015D>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220209102037.GA1025795@EPUAKYIW015D>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit



On 09/02/2022 10:20, Oleksii Moisieiev wrote:
> Hi Julien,

Hi,

> 
> On Tue, Feb 08, 2022 at 06:26:54PM +0000, Julien Grall wrote:
>> Hi Oleksii,
>>
>> On 08/02/2022 18:00, Oleksii Moisieiev wrote:
>>> If enabled, host device-tree will be exported to hypfs and can be
>>> accessed through /devicetree path.
>>> Exported device-tree has the same format, as the device-tree
>>> exported to the sysfs by the Linux kernel.
>>> This is useful when XEN toolstack needs an access to the host device-tree.
>>>
>>> Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@epam.com>
>>> ---
>>>    xen/arch/arm/Kconfig           |   8 +
>>>    xen/arch/arm/Makefile          |   1 +
>>>    xen/arch/arm/host_dtb_export.c | 307 +++++++++++++++++++++++++++++++++
>>
>> There is nothing specific in this file. So can this be moved in common/?
> 
> You're right. I will move it to common.
> 
>>
>>>    3 files changed, 316 insertions(+)
>>>    create mode 100644 xen/arch/arm/host_dtb_export.c
>>>
>>> diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
>>> index ecfa6822e4..895016b21e 100644
>>> --- a/xen/arch/arm/Kconfig
>>> +++ b/xen/arch/arm/Kconfig
>>> @@ -33,6 +33,14 @@ config ACPI
>>>    	  Advanced Configuration and Power Interface (ACPI) support for Xen is
>>>    	  an alternative to device tree on ARM64.
>>> +config HOST_DTB_EXPORT
>>> +	bool "Export host device tree to hypfs if enabled"
>>> +	depends on ARM && HYPFS && !ACPI
>>
>> A Xen built with ACPI enabled will still be able to boot on a host using
>> Device-Tree. So I don't think should depend on ACPI.
>>
>> Also, I think this should depend on HAS_DEVICE_TREE rather than ARM.
> 
> I agree. Thank you.
> 
>>
>>> +	---help---
>>> +
>>> +	  Export host device-tree to hypfs so toolstack can have an access for the
>>> +	  host device tree from Dom0. If you unsure say N.
>>> +
>>>    config GICV3
>>>    	bool "GICv3 driver"
>>>    	depends on ARM_64 && !NEW_VGIC
>>> diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile
>>> index 07f634508e..0a41f68f8c 100644
>>> --- a/xen/arch/arm/Makefile
>>> +++ b/xen/arch/arm/Makefile
>>> @@ -8,6 +8,7 @@ obj-y += platforms/
>>>    endif
>>>    obj-$(CONFIG_TEE) += tee/
>>>    obj-$(CONFIG_HAS_VPCI) += vpci.o
>>> +obj-$(CONFIG_HOST_DTB_EXPORT) += host_dtb_export.o
>>>    obj-$(CONFIG_HAS_ALTERNATIVE) += alternative.o
>>>    obj-y += bootfdt.init.o
>>> diff --git a/xen/arch/arm/host_dtb_export.c b/xen/arch/arm/host_dtb_export.c
>>> new file mode 100644
>>> index 0000000000..794395683c
>>> --- /dev/null
>>> +++ b/xen/arch/arm/host_dtb_export.c
>>
>> This is mostly hypfs related. So CCing Juergen for his input on the code.
> 
> Thank you.
> 
>>
>>> @@ -0,0 +1,307 @@
>>> +/*
>>> + * xen/arch/arm/host_dtb_export.c
>>> + *
>>> + * Export host device-tree to the hypfs so toolstack can access
>>> + * host device-tree from Dom0
>>> + *
>>> + * Oleksii Moisieiev <oleksii_moisieiev@epam.com>
>>> + * Copyright (C) 2021, EPAM Systems.
>>> + *
>>> + * This program is free software; you can redistribute it and/or modify
>>> + * it under the terms of the GNU General Public License as published by
>>> + * the Free Software Foundation; either version 2 of the License, or
>>> + * (at your option) any later version.
>>> + *
>>> + * This program is distributed in the hope that it will be useful,
>>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>>> + * GNU General Public License for more details.
>>> + */
>>> +
>>> +#include <xen/device_tree.h>
>>> +#include <xen/err.h>
>>> +#include <xen/guest_access.h>
>>> +#include <xen/hypfs.h>
>>> +#include <xen/init.h>
>>> +
>>> +#define HOST_DT_DIR "devicetree"
>>> +
>>> +static int host_dt_dir_read(const struct hypfs_entry *entry,
>>> +                            XEN_GUEST_HANDLE_PARAM(void) uaddr);
>>> +static unsigned int host_dt_dir_getsize(const struct hypfs_entry *entry);
>>> +
>>> +static const struct hypfs_entry *host_dt_dir_enter(
>>> +    const struct hypfs_entry *entry);
>>> +static void host_dt_dir_exit(const struct hypfs_entry *entry);
>>> +
>>> +static struct hypfs_entry *host_dt_dir_findentry(
>>> +    const struct hypfs_entry_dir *dir, const char *name, unsigned int name_len);
>>
>> This is new code. So can you please make sure to avoid forward declaration
>> by re-ordering the code.
>>
> 
> I can't avoid forward declaration here because all those functions
> should be passed as callbacks for node template dt_dir. And dt_dir is
> used in read and findentry functions.

You can avoid most of those forward declarations if you define the 
static variable now but fill them up after (see [1]). I don't think we 
can avoid the static variable forward declaration without reworking the API.

BTW, I could not fully apply the series on the staging tree:

Applying: xen/hypfs: support fo nested dynamic hypfs nodes
Applying: libs: libxenhypfs - handle blob properties
Applying: xen/arm: Export host device-tree to hypfs
Applying: xen/arm: add generic SCI mediator framework
error: patch failed: MAINTAINERS:512
error: MAINTAINERS: patch does not apply
error: patch failed: xen/arch/arm/domain_build.c:1894
error: xen/arch/arm/domain_build.c: patch does not apply
error: xen/include/asm-arm/domain.h: does not exist in index
Patch failed at 0004 xen/arm: add generic SCI mediator framework
hint: Use 'git am --show-current-patch=diff' to see the failed patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

 From the errors, it sounds like your baseline is from a couple of 
months ago. Please make sure to send your series based on the latest 
staging (at the time you send it).

>>> +static int host_dt_dir_read(const struct hypfs_entry *entry,
>>> +                            XEN_GUEST_HANDLE_PARAM(void) uaddr)
>>> +{
>>> +    int ret = 0;
>>> +    struct dt_device_node *node;
>>> +    struct dt_device_node *child;
>>
>> The hypfs should not modify the device-tree. So can this be const?
> 
> That's a good point.
> Unfortunatelly child can't be const because it is going to be passed to
> data->data pointer, but node can be const I think. In any case I will go
> through the file and see where const for the device_node can be set.

Can you explain why that data->data is not const?
>>> +static HYPFS_DIR_INIT_FUNC(host_dt_dir, HOST_DT_DIR, &host_dt_dir_funcs);
>>> +
>>> +static int __init host_dtb_export_init(void)
>>> +{
>>> +    ASSERT(dt_host && (dt_host->sibling == NULL));
>>
>> dt_host can be NULL when booting on ACPI platform. So I think this wants to
>> be turned to a normal check and return directly.
>>
> 
> I will replace if with
> if ( !acpi_disabled )
>      return -ENODEV;
> 
>> Also could you explain why you need to check dt_host->sibling?
>>
> 
> This is my way to check if dt_host points to the top of the device-tree.
> In any case I will replace it with !acpi_disabled as I mentioned
> earlier.

dt_host will always points to the root of the host device-tree. I don't 
think it is the job of hypfs to enforce it unless you expect the code to 
be buggy if this happens. But then I would argue the code should be 
hardened.

Cheers,

[1]

diff --git a/xen/arch/arm/host_dtb_export.c b/xen/arch/arm/host_dtb_export.c
index 794395683cd1..5f242b2cb683 100644
--- a/xen/arch/arm/host_dtb_export.c
+++ b/xen/arch/arm/host_dtb_export.c
@@ -26,39 +26,9 @@

  #define HOST_DT_DIR "devicetree"

-static int host_dt_dir_read(const struct hypfs_entry *entry,
-                            XEN_GUEST_HANDLE_PARAM(void) uaddr);
-static unsigned int host_dt_dir_getsize(const struct hypfs_entry *entry);
-
-static const struct hypfs_entry *host_dt_dir_enter(
-    const struct hypfs_entry *entry);
-static void host_dt_dir_exit(const struct hypfs_entry *entry);
-
-static struct hypfs_entry *host_dt_dir_findentry(
-    const struct hypfs_entry_dir *dir, const char *name, unsigned int 
name_len);
-
-static const struct hypfs_funcs host_dt_dir_funcs = {
-    .enter = host_dt_dir_enter,
-    .exit = host_dt_dir_exit,
-    .read = host_dt_dir_read,
-    .write = hypfs_write_deny,
-    .getsize = host_dt_dir_getsize,
-    .findentry = host_dt_dir_findentry,
-};
-
-static int host_dt_prop_read(const struct hypfs_entry *entry,
-                    XEN_GUEST_HANDLE_PARAM(void) uaddr);
-
-static unsigned int host_dt_prop_getsize(const struct hypfs_entry *entry);
-
-const struct hypfs_funcs host_dt_prop_ro_funcs = {
-    .enter = host_dt_dir_enter,
-    .exit = host_dt_dir_exit,
-    .read = host_dt_prop_read,
-    .write = hypfs_write_deny,
-    .getsize = host_dt_prop_getsize,
-    .findentry = hypfs_leaf_findentry,
-};
+/* Forward declare it */
+static const struct hypfs_funcs host_dt_dir_funcs;
+static const struct hypfs_funcs host_dt_prop_ro_funcs;

  static HYPFS_DIR_INIT_FUNC(dt_dir, "node_template", &host_dt_dir_funcs);

@@ -260,6 +230,15 @@ static struct hypfs_entry *host_dt_dir_findentry(
      return ERR_PTR(-ENOENT);
  };

+static const struct hypfs_funcs host_dt_dir_funcs = {
+    .enter = host_dt_dir_enter,
+    .exit = host_dt_dir_exit,
+    .read = host_dt_dir_read,
+    .write = hypfs_write_deny,
+    .getsize = host_dt_dir_getsize,
+    .findentry = host_dt_dir_findentry,
+};
+
  static int host_dt_prop_read(const struct hypfs_entry *entry,
                      XEN_GUEST_HANDLE_PARAM(void) uaddr)
  {
@@ -293,6 +272,15 @@ static unsigned int host_dt_prop_getsize(const 
struct hypfs_entry *entry)
      return prop->length;
  }

+static const struct hypfs_funcs host_dt_prop_ro_funcs = {
+    .enter = host_dt_dir_enter,
+    .exit = host_dt_dir_exit,
+    .read = host_dt_prop_read,
+    .write = hypfs_write_deny,
+    .getsize = host_dt_prop_getsize,
+    .findentry = hypfs_leaf_findentry,
+};
+
  static HYPFS_DIR_INIT_FUNC(host_dt_dir, HOST_DT_DIR, &host_dt_dir_funcs);

  static int __init host_dtb_export_init(void)

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Feb 09 12:25:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 09 Feb 2022 12:25:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269080.463058 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHm2b-000596-U2; Wed, 09 Feb 2022 12:25:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269080.463058; Wed, 09 Feb 2022 12:25:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHm2b-00058z-R5; Wed, 09 Feb 2022 12:25:45 +0000
Received: by outflank-mailman (input) for mailman id 269080;
 Wed, 09 Feb 2022 12:25:44 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nHm2a-00058t-26
 for xen-devel@lists.xenproject.org; Wed, 09 Feb 2022 12:25:44 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nHm2Z-0003uI-OZ; Wed, 09 Feb 2022 12:25:43 +0000
Received: from 54-240-197-228.amazon.com ([54.240.197.228]
 helo=[192.168.1.215]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nHm2Z-0002u1-IP; Wed, 09 Feb 2022 12:25:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=FeDTmST/BZCLc8vAuRGE/Mr+ZecXD0gyrMAdgah6y1U=; b=TNo+5BVtC69lirtJQsF3Ucsjch
	sI1ZS+LwLdhXXkoj3AVxbWW2J/KBoGBV4i0LQc+DlGK9fFinTQ+hYQNd6Bg9pqwu3nnCliyp967hP
	AuWetOqQeYTULT1ciRtqXk8mFKGwxaXx96n5TP/TWSs8sebB+9KZwt8hJd4AWqSl8EK8=;
Message-ID: <6e04e9e8-a5e5-1350-a21e-4fa2aed877a1@xen.org>
Date: Wed, 9 Feb 2022 12:25:41 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.1
Subject: Re: [PATCH] xen/serial: scif: add support for HSCIF
To: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>
Cc: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>
References: <20220208112304.1191924-1-volodymyr_babchuk@epam.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220208112304.1191924-1-volodymyr_babchuk@epam.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 08/02/2022 11:23, Volodymyr Babchuk wrote:
> HSCIF is a high-speed variant of Renesas SCIF serial interface. From
> Xen point of view, they almost the same, only difference is in FIFO
> size.
> 
> Signed-off-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com>
> Reviewed-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

Acked-by: Julien Grall <jgrall@amazon.com>

And committed.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Feb 09 12:26:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 09 Feb 2022 12:26:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269085.463070 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHm35-0005eI-9S; Wed, 09 Feb 2022 12:26:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269085.463070; Wed, 09 Feb 2022 12:26:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHm35-0005eB-3S; Wed, 09 Feb 2022 12:26:15 +0000
Received: by outflank-mailman (input) for mailman id 269085;
 Wed, 09 Feb 2022 12:26:14 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=H3wK=SY=citrix.com=Jane.Malalane@srs-se1.protection.inumbo.net>)
 id 1nHm34-0005Ue-6q
 for xen-devel@lists.xenproject.org; Wed, 09 Feb 2022 12:26:14 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7700fd8f-89a3-11ec-8eb8-a37418f5ba1a;
 Wed, 09 Feb 2022 13:26:12 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7700fd8f-89a3-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644409572;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=8IgwpvT+emX02vmGV+AElY3J/pHmY7Tr+kKYXsbarag=;
  b=JjA+92duNkeDcWq/+xTtzyDwxNu/UjUu958psLT7C5LhJK2J8YY5YFsI
   go+rECkjONl2hrxmo+Z9vbIEq65ZiwQtpmkPayGoMDLO6CE/ciB7yaMWG
   f45ZBr1QBGc5jiZk6ca7zRLcEPTlvVDLKsPanjOtIngIh4d995Z3k3i80
   M=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: eL6If/LB6MPPV7RciavpV8e3xjUb1YBqXkFeqz+6UEgBq/U+eAnecGXNKSzK0sDWGv/DCSzDfI
 Lkw971OMoQYSY0b4t42CHKG1gfKtkfMJQ3mAD46D8tePde9FtaIS4DMj1vLrvRHkCj1cE9GNLj
 EVRRfzgQUMvmxbX8LcVzAMJmR3QGRckkQ3d/KUBoE6fwjLoKHTcumeMpC/0pKDd200C8xIousH
 rHNqQSpzv+Tsk58HSXSxuToi3H2ogEzdFcv7FniMV1VYubQ0LeXDlr+d27YXxu5LR1WZ7eZ2l6
 mdhQkcdMSMF2LOa+7CObMCuh
X-SBRS: 5.1
X-MesageID: 66038168
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:o+1Ly6MxS95IuVnvrR2kkcFynXyQoLVcMsEvi/4bfWQNrUongzYPy
 jEcCzqGMviOamOkL9t0Po7i/BgEuJ7UmtU3HAto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6UUsxNbVU8En1500oyw7dRbrNA2rBVPSvc4
 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq
 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYoz+0ldJdz
 NNSj669eyJ0H5/8yf8vSxYNRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs
 6VFdnZdNXhvhMrvqF6/YstlgMllCcDvNYcWvHxIxjDFF/c2B5vERs0m4PcGgm9r1pkQTZ4yY
 eISTjR1QivOOyZoYGtQN7EMlu7w2GDWJmgwRFW9+vNsvjm7IBZK+IbqNN3Za9mbX/J/l0yTp
 n/F12nhCxRcP9uaoRKe6W6ljOLLmSL9WaoRGae++/osh0ecrkQZBQcKT1K9rb+8g1SnRtNEA
 0UO/2wlqq1a3E+mUNj7GQG5qXisvxgAVt4WGOo/gCmP16yS5Q+aD2oFSzdpado6uctwTjsvv
 neWm/v5CDopt6eaIVqN+7HRoT6sNCw9KW4ZeTRCXQYD+8Pkoow4klTIVNkLOKy6lNruAhnr3
 iuH6iM5gt07j9MP1qi91UDKhXSrvJehZgw/6xjTX2mlxhhkf4PjbIutgWU39t4ZctzfFAPY+
 iFZxY7Ot4jiEK1higSHfe8PMLWv+My3PQ/53H9dL8g6xSyirivLkZ9r3BlyI0JgM8AhcDDvY
 VPOtQ452KK/LEdGfocsPdvvVp1CIbzIUI28C6uKNoYmjo1ZKVfflByCc3J8yIwEfKIEtagkc
 amWfs+3ZZrxIfQ2lWHmLwvxPFJC+8zf+Y8xbc2ip/hE+eDHDJJwdVvjGAHTBgzexPnbyDg5C
 /4Fa6O3J+x3CYUSmBX//48JNkwtJnMmH53woME/XrfdflY9RDx9WqaBmO5Jl2lZc0J9zLqgE
 paVABAw9bYCrSefdVXiho5LNNsDoqqTXVpkZHdxbD5EKlAoYJq17bd3SnfEVeJPyQCX9tYtF
 6NtU5zZWpxnE22bkxxAPciVhNEzL3yD2FPRVwL7O2JXV8A7GGT0FirMI1KHGN8mVXHs66PTY
 tSIi2vmfHb0b146U5+NNan/lgjZULp0sLsaYnYk6+J7IS3E2INrNzbwnrkwJcQNIg/E3TyUy
 0CdBhJwmAUHi9VdHADhif/WooG3PfF5G0YGTWDX4azvbXvR/3a5wJ8GW+GNJGiPWGTx8aSkR
 ONU0/Cjb6FXwAcU69JxQ+Rx0KYzx9rzvLsGnA5qK2rGMgawAbR6L3jYgcQW7v9RxqVUsBedU
 16U/oUIIq2APc7oSQZDJAcsYumZ++sTnz3esaY8LEngvXcl97ubS0RCeRKLjXUFfrdyNYokx
 8YnudIXtFPj2kZ7bI7eg3kNpWqWL3EGX6E2jb0gAdfm2lgx11VPQZ3AESuqspuBXMpBbxsxK
 TiOiauc27kFnhjec2A+HGTm1PZGgchcowhDyVIPKgjbmtfBgfNrjhRd/S5uE1ZQxxRDlelyJ
 nJqJwt+IqDXp2Vkg81KXmaNHQBdBULGphytmgVRzGCJHVO1UmHtLXEmPbff9U8UxGtQYzxH8
 ezK023iSzvrIJn80yZatZSJcBA/oQidLjH/pf0=
IronPort-HdrOrdr: A9a23:SzM2MqqifKfM1+Q39s/ToawaV5uOL9V00zEX/kB9WHVpm5Oj+f
 xGzc516farslossSkb6Ky90KnpewK5yXbsibNhfItKLzOWx1dAS7sSrbcKogeQVREWk9Q96U
 4OSdkHNDSdNykZsS++2njELz9C+qjFzEnLv5ak854Fd2gDAMsMj3YbNu/YKDwNeOAvP+tlKH
 P23Lshm9PUQwVvUi3NPAhiYwGsnayvqLvWJTo9QzI34giHij2lrJTgFQKD4xsYWzRThZ8/7G
 nsiWXCl+eemsD+7iWZ+37Y7pxQltek4MBEHtawhs8cLSipohq0Zb5mR6aJsFkO0aSSARcR4Z
 3xSiUbToJOAkDqDziISNzWqlHdOQMVmjjfIJmj8CDeSILCNWgH4oF69Pxkm1PimjsdVZdHof
 52NiuixupqJAKFkyLn69fSURZ20kKyvHo5iOYWy2dSSI0EddZq3MEiFexuYeM99Q/Bmcsa+d
 NVfYvhDTdtACSnRmGcunMqzM2nX3w1EBvDSk8eutaN2zwTmHxi1UMXyMEWg39FrfsGOtZ5zv
 WBNr4tmKBFT8cQY644DOAdQdGvAmiIRR7XKmqdLVnuCalCMXPQrJz85qkz+YiRCdA15Yp3nI
 6EXEJTtGY0dU6rAcqS3IdT+hSIW2m5VSSF8LAX23G4gMy0eFPGC1zwdLkeqbrXnxxEOLypZx
 +aAuMiP8Pe
X-IronPort-AV: E=Sophos;i="5.88,355,1635220800"; 
   d="scan'208";a="66038168"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=PaKXrg4/Hw84gMJfkGuAB4q80iCazinjp3ZjElkSxeHpbchA5Ejfpvww0m9MRdR5njwtGkn/sXJ4q3BuAJ33G3KYRlPk4DWAPprAwJi5mXZCyDSu4TY6L4ym7e1co2YxA+yxSSyRPRuOc14+DdqO70KB2htWxmsSyOK3ll+du1h5BxU+2pWmtEAj7jhRZXzqXYdjABQhfPfuw/bc2PGHe957XbrfzqdqB3LyL+kXXxTrh1CowP8eQ8bAkAiRWxXBeynNX1WRtMeVT3+OUMrK1vyMXgDUcXg3zCL7nDHKMenX4vJBalb8vnbwEKyXyz+0BAVRsAQMMwkCvLRHPTfiig==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=8IgwpvT+emX02vmGV+AElY3J/pHmY7Tr+kKYXsbarag=;
 b=gn1c7qxJBWGAaAADGxSRQ4Cd4P7sUesU6RZw4xvJt4Z95Gp/ndT22AkrsLKnp8mm2ZJw+CAM4x571/JojbYhTn/cM8CkqmdqhD95s0LsCaIeKUBW3tJMLKDfODEEOspgUbDsa1wGXJLYaxmY6ASLvo6WKQty14k1f3mOa8zt0YBdAPCLX4ozTE9/7qGwrmBTnvKnwcqfRLVZFtSPu68L+ueqjSoQk1GXF17oAgSxpBJcjfVpIU0fZZ4HfWPmuremFz74HPeSCUo1RMvE2RUhbmCPrH1s08PSqixD2ejlcwAngabCj+DWw9/s21DwlBdFCJ02AtPZmTjUsCtNS0/aiw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=8IgwpvT+emX02vmGV+AElY3J/pHmY7Tr+kKYXsbarag=;
 b=GJq9bwOOihqp8nFoN1JxIuy+IvBla48M5IcPP87Gg4DMNWVPorNmJuC1qbTEb6n6gQy8fAtTUS3ONE4ZMRqwOWgkdYSmYb+Q65Qem+okeQUsO8UJzhgzxWFjF5Zwyq/ub8QY3nO1znfmd/18lKHPuer9niFcKHN8rC1GereUp+4=
From: Jane Malalane <Jane.Malalane@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>, "Anthony
 Perard" <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, "Andrew
 Cooper" <Andrew.Cooper3@citrix.com>, George Dunlap
	<George.Dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, Julien Grall
	<julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, "Volodymyr
 Babchuk" <Volodymyr_Babchuk@epam.com>, Bertrand Marquis
	<bertrand.marquis@arm.com>, Jun Nakajima <jun.nakajima@intel.com>, Kevin Tian
	<kevin.tian@intel.com>
Subject: Re: [PATCH v2 1/2] xen+tools: Report Interrupt Controller
 Virtualization capabilities on x86
Thread-Topic: [PATCH v2 1/2] xen+tools: Report Interrupt Controller
 Virtualization capabilities on x86
Thread-Index: AQHYHE+TdJl64aH33EedeR0PZ4zblKyJx9wAgAFf6oA=
Date: Wed, 9 Feb 2022 12:26:05 +0000
Message-ID: <2567d4cd-b27b-df0b-d449-c486ab13c672@citrix.com>
References: <20220207182101.31941-1-jane.malalane@citrix.com>
 <20220207182101.31941-2-jane.malalane@citrix.com>
 <YgKLpCnhjP18c7oo@Air-de-Roger>
In-Reply-To: <YgKLpCnhjP18c7oo@Air-de-Roger>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: e4950585-bf12-4c03-67b9-08d9ebc75856
x-ms-traffictypediagnostic: MWHPR03MB2976:EE_
x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
x-microsoft-antispam-prvs: <MWHPR03MB2976212BAD0F4B3B0B934829812E9@MWHPR03MB2976.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:4125;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: GZWPqjekwTow4vo2FtkIV25+RvGbhp+b3PSt+zJFFO+LDQSLvNsicAuCfk8ZMvqjwG5ySn/a+Q0Rx6mKNWoQqhEWVYQGYYe18+RKNcVvs4G3liomdRAmpttXfujHDNnxu5RL+Fqi9olcsDEN1JRNg5GnNR24Bcu5UNaGBkLWqQIX8oCaDQXJVVq4kkiZOitDgmKhd6vhcT3xl3kLdxfrJ68s28zyWq15XdeZ8VARveLuUltqKKFAvyXYtebW7DhmmHhi+FHwnnNAItxldlMZhHRRG4Xw0kRWTYHcjEmtPGGEdLg7pLpdyYd6ADhA6iZtrParP7TIu0pI4I9zbnXOLgDorTenphN7m7gLago8QtbThwz+47M2MrEY9wGL2b6xD8EXOQPZ/AtDcIo0GW5mVl6Q1AZfSHhp7W14B6/YBOW/X3YFegQKUkxSblOBQA3Iw7fVdr8+6HkgUXMNm/ebo6/YjOCa0gUfvclyli/TevehAK+jhgimTPhoXSlqVOQDKDQYDDOOh2HHY4XRj0ZdW8xukuqqmJ19nw3rJl3IarBcFC2PCC5fm81yCvfQ0v3dm1lNK/grHRaCIADVhjkEymNvd+mTC+MRS5yXgXgovY9P77e6+PP1dqmiUSjFh3P5tXpq34pSCvHXl0NBotoIZriZ0kykw+8umHw011W6IJNU4+RXOx6nteEyUgTnfdqm6sRQxgch+bJ9Vu5u3tz/X0uqhytl0VTWWWVEhobr/1bdQMwH21mTTzZboOgjjoJizLd3Ucd0TRtrI4G4p3yUBA==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR03MB3386.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(8936002)(82960400001)(54906003)(66556008)(38100700002)(4326008)(8676002)(5660300002)(66446008)(64756008)(76116006)(66946007)(6862004)(316002)(37006003)(91956017)(2616005)(31696002)(31686004)(186003)(26005)(53546011)(6486002)(71200400001)(66476007)(508600001)(2906002)(36756003)(122000001)(30864003)(6636002)(6512007)(86362001)(7416002)(83380400001)(6506007)(38070700005)(21314003)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?NzRKcGRzZ3V5eGluM3dUNUp4Uy9sY3FvbUl1WFFuUGF6REp2eVl6RWtIQ1U2?=
 =?utf-8?B?TTlHSHhnOUF6WmFVNnRnRDdRN21yZkN1WlA2Q3JEc0dCdnQrOTgxckkwQWMv?=
 =?utf-8?B?TFJ6bkF0VW0wU0Foa3puY29GeGx1eEFHZkRtblo4TGZIWFZ6NTFrZDVwQ09n?=
 =?utf-8?B?aWpoTmxGV3FONDJKL1BLZVZ4bW9TaDJzRVVZelV3S1ppWnZDTklpOVU4cXY0?=
 =?utf-8?B?OU9lMWQxdGY0Kyt2ME1sV3p6aG5XS3B0L0dORk5hWVJvQXBEb29SUGF4aWNx?=
 =?utf-8?B?NVUrMXUyeC9tZklHU2xpZm1BdGJVdnIrZnJGZmhKUkp1TXRMSVU0eVMxMWJi?=
 =?utf-8?B?bGQwcHdtd3RQdHpIaHBNL0ptNGRkUWZqVk1LeWJGSVQ3WU9lcXZRMXRvQWI4?=
 =?utf-8?B?Tjdpd25wYlZTTlFCWElPM0VsSDNYdlJxMUtkcEt6OE1GcUM2S3BtZlVaaXov?=
 =?utf-8?B?Yk0yanBHWW5mODB5ODBhaGNaYmZmcSs5YUdzd2QyQW9naXd3bnI0cnpucmx2?=
 =?utf-8?B?cjcybUIveXdPRnlYOFZwMHU2NEhjaGRCZ2FNNDFQRGtKQU55TEZ5ejVTZExi?=
 =?utf-8?B?MytsejJUWVdrdjB3WnM4dEl0VG5qWmdJTWhVZVlIb05aUzY4WkxPa3p0TGtm?=
 =?utf-8?B?bSsxVGx4SThXaS9PZ3JYZ2oxalNtRkRMa1dWeGNsMnUyUEsxQ3J5K1BvNFc1?=
 =?utf-8?B?bWoyNUtBMGFkZ2NFYng2QVhqSFM5akc0Sk9yOTVIdDdaYi9VRXYzRTR4Tm1S?=
 =?utf-8?B?NVNPS0ZQNG84QS9wSVB2anhFTVdBS3V6ZVFwVWgrdDVjVzBMbk1uODhaUiti?=
 =?utf-8?B?K3dVMEI4Q3BCMkhScjI4dWViSVk3UlhEclVhdS90bkZtQ0ZTWG1WbTJaRno0?=
 =?utf-8?B?ckZSdmFQVDd4Z1JPVmd6UitHdWx1RzB4TUE0d1BoT0ttODJsSWt1VndWTUR5?=
 =?utf-8?B?eXJzL29VT25CaUtsanVORVFIcXpDazlLcGtCTlQ2TC91MlhmSnp1cTFYdjFV?=
 =?utf-8?B?UllOdFQ5WUgwMDR3dnNwVXYzdGhtOHBka2RmRVFoMXRnSHo1NWIwcTJ2VkZ1?=
 =?utf-8?B?YWZEeEVrTzFEOFJzcFNVS2NhM1NEdFkxb2M5ZXJLcXRKRXlRT0x0SHNxUjVG?=
 =?utf-8?B?Y2tWWGpEZHZGVXBjQk94Sjk5SFFpWTZPRlI2MzNYcEF1NFJHb0JqcURqVDhK?=
 =?utf-8?B?TytDZ2V2QVFyN3llTHgxdlVUYWdyZWZWd3pxQlVRY0pBTkxRbVpFTHcxcFJQ?=
 =?utf-8?B?L0Z6QThSc2NaQ0IwYlZxaDAwU2k1STNUUGxwUHhaRmx4Nll1a3A5VzJWMWxF?=
 =?utf-8?B?NnAydW14azN0SUgxWmJwK1Jwc2hJa0d3TWRFV0JEeWd3Y1JqZnRqTTVyYUVN?=
 =?utf-8?B?dlZQVnR4cHdhSXJiRENWTkZ1c1dkV1FFV293a2kzd0E3SHVSbnM3aGM1WFBK?=
 =?utf-8?B?WXZmNWx5SWhXNkR3SUJlYktYc0JqNW1PTEl4MGNPSjVCUFlyVXp6MGpUdDRG?=
 =?utf-8?B?VUtwbzVqdStZSWE4UXlTSFFWQ21xb1Y3aEVzQ09UeHE5RkwrRDB6cC9iT3RO?=
 =?utf-8?B?VWYyWGV1amlhR1hmSjh1NFMyaUdkWXRVRzk1WWZGdlQ5T0lBK3B4VmxVVjZa?=
 =?utf-8?B?NHhRbzF3UFhUUS9OcEtLTG1mcDJxbjYvSFFmb0wwNG1TRmVrSGRGZFJydEU3?=
 =?utf-8?B?OWtmWTF3dlVMK0F2RUxqQU9OcktDbnFHRHN3TXlJSlVxODVmMVFJN0duNFlR?=
 =?utf-8?B?bzQxNEQrVGxpbVBBbHZ5U1BPUUhnekN0ZVF3ZlVPeWRpVjZJZjZhdGhVNWtm?=
 =?utf-8?B?VjVwRExTRFZCY0pHSGpYQ1hxVGR0VkE0aTRnTkZoUVJ6UGE3dHNmeUJJeEdx?=
 =?utf-8?B?enM2dTBYNTZkOFNxNjF3L0VvNjhuK3NBcjZnYXJackRRenBMNTUzUWhYYVZr?=
 =?utf-8?B?aE9UODdUSjlnZzZvZ3pXdnhLVVVYZkJiTyt0N05CcDQ1OWp2elVOck1pblNV?=
 =?utf-8?B?TDhELzdBWWdzYlJLa0QwRVFkdVIybDZ2SWRFb3Y5TWxoZUNjSzJDNnFjbE85?=
 =?utf-8?B?MWhTTmR2bTBHTGpGMHJlNnJLTmNnYVp4K2xhM2dSd3ljRWZnNTdGMC9MTXJC?=
 =?utf-8?B?NXkraDBmUTVtcU50LzdabU90aVJWYWh4VlFrM2UzcHk1R2R6eVgyZHVpS20v?=
 =?utf-8?B?Vk45TW42Z2FCbnlCK2NUNmFlVElxa0lBeStzbEJWS0JsRGhPbmNVU3pmTGk1?=
 =?utf-8?Q?3yS0xsuNVa7o6RWU+9ghmM4wxNlYWZsgsDnC7y+Ieo=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <C64958BC555EF245A40D122D2AD8FB5D@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM5PR03MB3386.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e4950585-bf12-4c03-67b9-08d9ebc75856
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Feb 2022 12:26:05.7713
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: /crNtetDbMW7/4tgcyNqOPLUxH2srOUD1eGBVFdgu+JQF2CBcZre0I88xP4KwDmY7/tf4KIkO75ZT0rmQN5Tz8UtaJ4HxVbnJnkOnNwjURg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2976
X-OriginatorOrg: citrix.com

T24gMDgvMDIvMjAyMiAxNToyNiwgUm9nZXIgUGF1IE1vbm7DqSB3cm90ZToNCj4gT24gTW9uLCBG
ZWIgMDcsIDIwMjIgYXQgMDY6MjE6MDBQTSArMDAwMCwgSmFuZSBNYWxhbGFuZSB3cm90ZToNCj4+
IEFkZCBYRU5fU1lTQ1RMX1BIWVNDQVBfQVJDSF9BU1NJU1RFRF94YXBpYyBhbmQNCj4+IFhFTl9T
WVNDVExfUEhZU0NBUF9BUkNIX0FTU0lTVEVEX3gyYXBpYyB0byByZXBvcnQgYWNjZWxlcmF0ZWQg
eGFwaWMNCj4+IGFuZCB4MmFwaWMsIG9uIHg4NiBoYXJkd2FyZS4NCj4+IE5vIHN1Y2ggZmVhdHVy
ZXMgYXJlIGN1cnJlbnRseSBpbXBsZW1lbnRlZCBvbiBBTUQgaGFyZHdhcmUuDQo+Pg0KPj4gRm9y
IHRoYXQgcHVycG9zZSwgYWxzbyBhZGQgYW4gYXJjaC1zcGVjaWZpYyAiY2FwYWJpbGl0aWVzIiBw
YXJhbWV0ZXINCj4+IHRvIHN0cnVjdCB4ZW5fc3lzY3RsX3BoeXNpbmZvLg0KPj4NCj4+IFNpZ25l
ZC1vZmYtYnk6IEphbmUgTWFsYWxhbmUgPGphbmUubWFsYWxhbmVAY2l0cml4LmNvbT4NCj4+IFN1
Z2dlc3RlZC1ieTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4NCj4g
DQo+IFRhZyBvcmRlciBzaG91bGQgYmUgaW52ZXJ0ZWQsIGZpcnN0IFN1Z2dlc3RlZC1ieSwgdGhl
biBTb0IuDQo+IA0KPj4gLS0tDQo+PiBDQzogV2VpIExpdSA8d2xAeGVuLm9yZz4NCj4+IENDOiBB
bnRob255IFBFUkFSRCA8YW50aG9ueS5wZXJhcmRAY2l0cml4LmNvbT4NCj4+IENDOiBKdWVyZ2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+DQo+PiBDQzogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNv
b3BlcjNAY2l0cml4LmNvbT4NCj4+IENDOiBHZW9yZ2UgRHVubGFwIDxnZW9yZ2UuZHVubGFwQGNp
dHJpeC5jb20+DQo+PiBDQzogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KPj4gQ0M6
IEp1bGllbiBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+PiBDQzogU3RlZmFubyBTdGFiZWxsaW5p
IDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPg0KPj4gQ0M6IFZvbG9keW15ciBCYWJjaHVrIDxWb2xv
ZHlteXJfQmFiY2h1a0BlcGFtLmNvbT4NCj4+IENDOiBCZXJ0cmFuZCBNYXJxdWlzIDxiZXJ0cmFu
ZC5tYXJxdWlzQGFybS5jb20+DQo+PiBDQzogSnVuIE5ha2FqaW1hIDxqdW4ubmFrYWppbWFAaW50
ZWwuY29tPg0KPj4gQ0M6IEtldmluIFRpYW4gPGtldmluLnRpYW5AaW50ZWwuY29tPg0KPj4gQ0M6
ICJSb2dlciBQYXUgTW9ubsOpIiA8cm9nZXIucGF1QGNpdHJpeC5jb20+DQo+Pg0KPj4gdjI6DQo+
PiAgICogVXNlIG9uZSBtYWNybyBMSUJYTF9IQVZFX1BIWVNJTkZPX0FTU0lTVEVEX0FQSUMgaW5z
dGVhZCBvZiB0d28NCj4+ICAgKiBQYXNzIHhjcHlzaGluZm8gYXMgYSBwb2ludGVyIGluIGxpYnhs
X19hcmNoX2dldF9waHlzaW5mbw0KPj4gICAqIFNldCBhc3Npc3RlZF94ezJ9YXBpY19hdmFpbGFi
bGUgdG8gYmUgY29uZGl0aW9uYWwgdXBvbiAiYnNwIiBhbmQNCj4+ICAgICBhbm5vdGF0ZSBpdCB3
aXRoIF9fcm9fYWZ0ZXJfaW5pdA0KPj4gICAqIENoYW5nZSBYRU5fU1lTQ1RMX1BIWVNDQVBfQVJD
SF9BU1NJU1RFRF9YezJ9QVBJQyB0bw0KPj4gICAgIC4uX1g4Nl9BU1NJU1RFRF9YezJ9QVBJQw0K
Pj4gICAqIEtlZXAgWEVOX1NZU0NUTF9QSFlTQ0FQX1g4Nl9BU1NJU1RFRF9YezJ9QVBJQyBjb250
YWluZWQgd2l0aGluDQo+PiAgICAgc3lzY3RsLmgNCj4+ICAgKiBGaXggcGFkZGluZyBpbnRyb2R1
Y2VkIGluIHN0cnVjdCB4ZW5fc3lzY3RsX3BoeXNpbmZvIGFuZCBidW1wDQo+PiAgICAgWEVOX1NZ
U0NUTF9JTlRFUkZBQ0VfVkVSU0lPTg0KPj4gLS0tDQo+PiAgIHRvb2xzL2dvbGFuZy94ZW5saWdo
dC9oZWxwZXJzLmdlbi5nbyB8ICA0ICsrKysNCj4+ICAgdG9vbHMvZ29sYW5nL3hlbmxpZ2h0L3R5
cGVzLmdlbi5nbyAgIHwgIDYgKysrKysrDQo+PiAgIHRvb2xzL2luY2x1ZGUvbGlieGwuaCAgICAg
ICAgICAgICAgICB8ICA3ICsrKysrKysNCj4+ICAgdG9vbHMvbGlicy9saWdodC9saWJ4bC5jICAg
ICAgICAgICAgIHwgIDMgKysrDQo+PiAgIHRvb2xzL2xpYnMvbGlnaHQvbGlieGxfYXJjaC5oICAg
ICAgICB8ICA0ICsrKysNCj4+ICAgdG9vbHMvbGlicy9saWdodC9saWJ4bF9hcm0uYyAgICAgICAg
IHwgIDUgKysrKysNCj4+ICAgdG9vbHMvbGlicy9saWdodC9saWJ4bF90eXBlcy5pZGwgICAgIHwg
IDIgKysNCj4+ICAgdG9vbHMvbGlicy9saWdodC9saWJ4bF94ODYuYyAgICAgICAgIHwgMTEgKysr
KysrKysrKysNCj4+ICAgdG9vbHMvb2NhbWwvbGlicy94Yy94ZW5jdHJsLm1sICAgICAgIHwgIDUg
KysrKysNCj4+ICAgdG9vbHMvb2NhbWwvbGlicy94Yy94ZW5jdHJsLm1saSAgICAgIHwgIDUgKysr
KysNCj4+ICAgdG9vbHMveGwveGxfaW5mby5jICAgICAgICAgICAgICAgICAgIHwgIDYgKysrKy0t
DQo+PiAgIHhlbi9hcmNoL3g4Ni9odm0vdm14L3ZtY3MuYyAgICAgICAgICB8ICA5ICsrKysrKysr
Kw0KPj4gICB4ZW4vYXJjaC94ODYvaW5jbHVkZS9hc20vZG9tYWluLmggICAgfCAgMyArKysNCj4+
ICAgeGVuL2FyY2gveDg2L3N5c2N0bC5jICAgICAgICAgICAgICAgIHwgIDcgKysrKysrKw0KPj4g
ICB4ZW4vaW5jbHVkZS9wdWJsaWMvc3lzY3RsLmggICAgICAgICAgfCAgOCArKysrKysrLQ0KPj4g
ICAxNSBmaWxlcyBjaGFuZ2VkLCA4MiBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQ0KPj4N
Cj4+IGRpZmYgLS1naXQgYS90b29scy9nb2xhbmcveGVubGlnaHQvaGVscGVycy5nZW4uZ28gYi90
b29scy9nb2xhbmcveGVubGlnaHQvaGVscGVycy5nZW4uZ28NCj4+IGluZGV4IGI3NDZmZjEwODEu
LmRkNGU2YzlmMTQgMTAwNjQ0DQo+PiAtLS0gYS90b29scy9nb2xhbmcveGVubGlnaHQvaGVscGVy
cy5nZW4uZ28NCj4+ICsrKyBiL3Rvb2xzL2dvbGFuZy94ZW5saWdodC9oZWxwZXJzLmdlbi5nbw0K
Pj4gQEAgLTMzNzMsNiArMzM3Myw4IEBAIHguQ2FwVm10cmFjZSA9IGJvb2woeGMuY2FwX3ZtdHJh
Y2UpDQo+PiAgIHguQ2FwVnBtdSA9IGJvb2woeGMuY2FwX3ZwbXUpDQo+PiAgIHguQ2FwR250dGFi
VjEgPSBib29sKHhjLmNhcF9nbnR0YWJfdjEpDQo+PiAgIHguQ2FwR250dGFiVjIgPSBib29sKHhj
LmNhcF9nbnR0YWJfdjIpDQo+PiAreC5DYXBBc3Npc3RlZFhhcGljID0gYm9vbCh4Yy5jYXBfYXNz
aXN0ZWRfeGFwaWMpDQo+PiAreC5DYXBBc3Npc3RlZFgyQXBpYyA9IGJvb2woeGMuY2FwX2Fzc2lz
dGVkX3gyYXBpYykNCj4+ICAgDQo+PiAgICByZXR1cm4gbmlsfQ0KPj4gICANCj4+IEBAIC0zNDA3
LDYgKzM0MDksOCBAQCB4Yy5jYXBfdm10cmFjZSA9IEMuYm9vbCh4LkNhcFZtdHJhY2UpDQo+PiAg
IHhjLmNhcF92cG11ID0gQy5ib29sKHguQ2FwVnBtdSkNCj4+ICAgeGMuY2FwX2dudHRhYl92MSA9
IEMuYm9vbCh4LkNhcEdudHRhYlYxKQ0KPj4gICB4Yy5jYXBfZ250dGFiX3YyID0gQy5ib29sKHgu
Q2FwR250dGFiVjIpDQo+PiAreGMuY2FwX2Fzc2lzdGVkX3hhcGljID0gQy5ib29sKHguQ2FwQXNz
aXN0ZWRYYXBpYykNCj4+ICt4Yy5jYXBfYXNzaXN0ZWRfeDJhcGljID0gQy5ib29sKHguQ2FwQXNz
aXN0ZWRYMkFwaWMpDQo+PiAgIA0KPj4gICAgcmV0dXJuIG5pbA0KPj4gICAgfQ0KPj4gZGlmZiAt
LWdpdCBhL3Rvb2xzL2dvbGFuZy94ZW5saWdodC90eXBlcy5nZW4uZ28gYi90b29scy9nb2xhbmcv
eGVubGlnaHQvdHlwZXMuZ2VuLmdvDQo+PiBpbmRleCBiMWU4NGQ1MjU4Li41ZjM4NGI3NjdjIDEw
MDY0NA0KPj4gLS0tIGEvdG9vbHMvZ29sYW5nL3hlbmxpZ2h0L3R5cGVzLmdlbi5nbw0KPj4gKysr
IGIvdG9vbHMvZ29sYW5nL3hlbmxpZ2h0L3R5cGVzLmdlbi5nbw0KPj4gQEAgLTM4OSw2ICszODks
MTAgQEAgUnVuSG90cGx1Z1NjcmlwdHMgRGVmYm9vbA0KPj4gICBEcml2ZXJEb21haW4gRGVmYm9v
bA0KPj4gICBQYXNzdGhyb3VnaCBQYXNzdGhyb3VnaA0KPj4gICBYZW5kU3VzcGVuZEV2dGNobkNv
bXBhdCBEZWZib29sDQo+PiArQXJjaFg4NiBzdHJ1Y3Qgew0KPj4gK0Fzc2lzdGVkWGFwaWMgRGVm
Ym9vbA0KPj4gK0Fzc2lzdGVkWDJBcGljIERlZmJvb2wNCj4gDQo+IERvbid0IHlvdSBuZWVkIHNv
bWUgaW5kZW50YXRpb24gaGVyZT8NCkkgaGFkbid0IHJlYWxpemVkIGl0IGFwcGVhcmVkIGxpa2Ug
dGhpcyBoZXJlIChhbmQgdGhlIHNhbWUgaGFwcGVucyBmb3IgDQpvdGhlciBwYXJ0cyBvZiBteSBj
b2RlIGFzIEknbSBzZWVpbmcgbm93KSBiZWNhdXNlIHRoZSBnaXQgb3V0cHV0IGlzIA0KY29ycmVj
dC4gSSB3aWxsIGZpeCBpdC4NCj4gDQo+IEFsc28gbmFtZSB3b3VsZCBiZXR0ZXIgYmUgQXNzaXN0
ZWR4ezJ9QVBJQyBJTU8gaWYgcG9zc2libGUuIEhhdmluZyBhDQo+IGNhcGl0YWwgJ1gnIGFuZCBs
b3dlcmNhc2UgJ2FwaWMnIGxvb2tzIHJlYWxseSBzdHJhbmdlLg0KT2theS4NCj4gDQo+PiArfQ0K
Pj4gICB9DQo+PiAgIA0KPj4gICB0eXBlIERvbWFpblJlc3RvcmVQYXJhbXMgc3RydWN0IHsNCj4+
IEBAIC0xMDE0LDYgKzEwMTgsOCBAQCBDYXBWbXRyYWNlIGJvb2wNCj4+ICAgQ2FwVnBtdSBib29s
DQo+PiAgIENhcEdudHRhYlYxIGJvb2wNCj4+ICAgQ2FwR250dGFiVjIgYm9vbA0KPj4gK0NhcEFz
c2lzdGVkWEFwaWMgYm9vbA0KPj4gK0NhcEFzc2lzdGVkWDJhcGljIGJvb2wNCj4+ICAgfQ0KPj4g
ICANCj4+ICAgdHlwZSBDb25uZWN0b3JpbmZvIHN0cnVjdCB7DQo+PiBkaWZmIC0tZ2l0IGEvdG9v
bHMvaW5jbHVkZS9saWJ4bC5oIGIvdG9vbHMvaW5jbHVkZS9saWJ4bC5oDQo+PiBpbmRleCAyYmJi
ZDIxZjBiLi45MjRlMTQyNjI4IDEwMDY0NA0KPj4gLS0tIGEvdG9vbHMvaW5jbHVkZS9saWJ4bC5o
DQo+PiArKysgYi90b29scy9pbmNsdWRlL2xpYnhsLmgNCj4+IEBAIC01MjgsNiArNTI4LDEzIEBA
DQo+PiAgICNkZWZpbmUgTElCWExfSEFWRV9NQVhfR1JBTlRfVkVSU0lPTiAxDQo+PiAgIA0KPj4g
ICAvKg0KPj4gKyAqIExJQlhMX0hBVkVfUEhZU0lORk9fQVNTSVNURURfQVBJQyBpbmRpY2F0ZXMg
dGhhdCBsaWJ4bF9waHlzaW5mbyBoYXMNCj4+ICsgKiBjYXBfYXNzaXN0ZWRfeHsyfWFwaWMgZmll
bGRzLCB3aGljaCBpbmRpY2F0ZXMgdGhlIGF2YWlsYWJpbGl0eSBvZiB4ezJ9QVBJQw0KPj4gKyAq
IGhhcmR3YXJlIGFzc2lzdGVkIHZpcnR1YWxpemF0aW9uLg0KPj4gKyAqLw0KPj4gKyNkZWZpbmUg
TElCWExfSEFWRV9QSFlTSU5GT19BU1NJU1RFRF9BUElDIDENCj4+ICsNCj4+ICsvKg0KPj4gICAg
KiBsaWJ4bCBBQkkgY29tcGF0aWJpbGl0eQ0KPj4gICAgKg0KPj4gICAgKiBUaGUgb25seSBndWFy
YW50ZWUgd2hpY2ggbGlieGwgbWFrZXMgcmVnYXJkaW5nIEFCSSBjb21wYXRpYmlsaXR5DQo+PiBk
aWZmIC0tZ2l0IGEvdG9vbHMvbGlicy9saWdodC9saWJ4bC5jIGIvdG9vbHMvbGlicy9saWdodC9s
aWJ4bC5jDQo+PiBpbmRleCA2NjdhZTY0MDliLi5mYWJiNDc0MjIxIDEwMDY0NA0KPj4gLS0tIGEv
dG9vbHMvbGlicy9saWdodC9saWJ4bC5jDQo+PiArKysgYi90b29scy9saWJzL2xpZ2h0L2xpYnhs
LmMNCj4+IEBAIC0xNSw2ICsxNSw3IEBADQo+PiAgICNpbmNsdWRlICJsaWJ4bF9vc2RlcHMuaCIN
Cj4+ICAgDQo+PiAgICNpbmNsdWRlICJsaWJ4bF9pbnRlcm5hbC5oIg0KPj4gKyNpbmNsdWRlICJs
aWJ4bF9hcmNoLmgiDQo+PiAgIA0KPj4gICBpbnQgbGlieGxfY3R4X2FsbG9jKGxpYnhsX2N0eCAq
KnBjdHgsIGludCB2ZXJzaW9uLA0KPj4gICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGZs
YWdzLCB4ZW50b29sbG9nX2xvZ2dlciAqIGxnKQ0KPj4gQEAgLTQxMCw2ICs0MTEsOCBAQCBpbnQg
bGlieGxfZ2V0X3BoeXNpbmZvKGxpYnhsX2N0eCAqY3R4LCBsaWJ4bF9waHlzaW5mbyAqcGh5c2lu
Zm8pDQo+PiAgICAgICBwaHlzaW5mby0+Y2FwX2dudHRhYl92MiA9DQo+PiAgICAgICAgICAgISEo
eGNwaHlzaW5mby5jYXBhYmlsaXRpZXMgJiBYRU5fU1lTQ1RMX1BIWVNDQVBfZ250dGFiX3YyKTsN
Cj4+ICAgDQo+PiArICAgIGxpYnhsX19hcmNoX2dldF9waHlzaW5mbyhwaHlzaW5mbywgJnhjcGh5
c2luZm8pOw0KPj4gKw0KPj4gICAgICAgR0NfRlJFRTsNCj4+ICAgICAgIHJldHVybiAwOw0KPj4g
ICB9DQo+PiBkaWZmIC0tZ2l0IGEvdG9vbHMvbGlicy9saWdodC9saWJ4bF9hcmNoLmggYi90b29s
cy9saWJzL2xpZ2h0L2xpYnhsX2FyY2guaA0KPj4gaW5kZXggMTUyMmVjYjk3Zi4uMjA3Y2VhYzZh
MSAxMDA2NDQNCj4+IC0tLSBhL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfYXJjaC5oDQo+PiArKysg
Yi90b29scy9saWJzL2xpZ2h0L2xpYnhsX2FyY2guaA0KPj4gQEAgLTg2LDYgKzg2LDEwIEBAIGlu
dCBsaWJ4bF9fYXJjaF9leHRyYV9tZW1vcnkobGlieGxfX2djICpnYywNCj4+ICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICB1aW50NjRfdCAqb3V0KTsNCj4+ICAgDQo+PiAgIF9oaWRkZW4N
Cj4+ICt2b2lkIGxpYnhsX19hcmNoX2dldF9waHlzaW5mbyhsaWJ4bF9waHlzaW5mbyAqcGh5c2lu
Zm8sDQo+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3QgeGNfcGh5c2luZm9f
dCAqeGNwaHlzaW5mbyk7DQo+PiArDQo+PiArX2hpZGRlbg0KPj4gICB2b2lkIGxpYnhsX19hcmNo
X3VwZGF0ZV9kb21haW5fY29uZmlnKGxpYnhsX19nYyAqZ2MsDQo+PiAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgbGlieGxfZG9tYWluX2NvbmZpZyAqZHN0LA0KPj4gICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IGxpYnhsX2RvbWFpbl9j
b25maWcgKnNyYyk7DQo+PiBkaWZmIC0tZ2l0IGEvdG9vbHMvbGlicy9saWdodC9saWJ4bF9hcm0u
YyBiL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfYXJtLmMNCj4+IGluZGV4IGVlZjFkZTA5MzkuLjM5
ZmRjYTFiNDkgMTAwNjQ0DQo+PiAtLS0gYS90b29scy9saWJzL2xpZ2h0L2xpYnhsX2FybS5jDQo+
PiArKysgYi90b29scy9saWJzL2xpZ2h0L2xpYnhsX2FybS5jDQo+PiBAQCAtMTQzMSw2ICsxNDMx
LDExIEBAIGludCBsaWJ4bF9fYXJjaF9wYXNzdGhyb3VnaF9tb2RlX3NldGRlZmF1bHQobGlieGxf
X2djICpnYywNCj4+ICAgICAgIHJldHVybiByYzsNCj4+ICAgfQ0KPj4gICANCj4+ICt2b2lkIGxp
YnhsX19hcmNoX2dldF9waHlzaW5mbyhsaWJ4bF9waHlzaW5mbyAqcGh5c2luZm8sDQo+PiArICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3QgeGNfcGh5c2luZm9fdCAqeGNwaHlzaW5m
bykNCj4+ICt7DQo+PiArfQ0KPj4gKw0KPj4gICB2b2lkIGxpYnhsX19hcmNoX3VwZGF0ZV9kb21h
aW5fY29uZmlnKGxpYnhsX19nYyAqZ2MsDQo+PiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgbGlieGxfZG9tYWluX2NvbmZpZyAqZHN0LA0KPj4gICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IGxpYnhsX2RvbWFpbl9jb25maWcgKnNyYykN
Cj4+IGRpZmYgLS1naXQgYS90b29scy9saWJzL2xpZ2h0L2xpYnhsX3R5cGVzLmlkbCBiL3Rvb2xz
L2xpYnMvbGlnaHQvbGlieGxfdHlwZXMuaWRsDQo+PiBpbmRleCAyYTQyZGEyZjdkLi40MmFjNmMz
NTdiIDEwMDY0NA0KPj4gLS0tIGEvdG9vbHMvbGlicy9saWdodC9saWJ4bF90eXBlcy5pZGwNCj4+
ICsrKyBiL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfdHlwZXMuaWRsDQo+PiBAQCAtMTA2OCw2ICsx
MDY4LDggQEAgbGlieGxfcGh5c2luZm8gPSBTdHJ1Y3QoInBoeXNpbmZvIiwgWw0KPj4gICAgICAg
KCJjYXBfdnBtdSIsIGJvb2wpLA0KPj4gICAgICAgKCJjYXBfZ250dGFiX3YxIiwgYm9vbCksDQo+
PiAgICAgICAoImNhcF9nbnR0YWJfdjIiLCBib29sKSwNCj4+ICsgICAgKCJjYXBfYXNzaXN0ZWRf
eGFwaWMiLCBib29sKSwNCj4+ICsgICAgKCJjYXBfYXNzaXN0ZWRfeDJhcGljIiwgYm9vbCksDQo+
PiAgICAgICBdLCBkaXI9RElSX09VVCkNCj4+ICAgDQo+PiAgIGxpYnhsX2Nvbm5lY3RvcmluZm8g
PSBTdHJ1Y3QoImNvbm5lY3RvcmluZm8iLCBbDQo+PiBkaWZmIC0tZ2l0IGEvdG9vbHMvbGlicy9s
aWdodC9saWJ4bF94ODYuYyBiL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfeDg2LmMNCj4+IGluZGV4
IDFmZWFkZWJiMTguLmUwYTA2ZWNmZTMgMTAwNjQ0DQo+PiAtLS0gYS90b29scy9saWJzL2xpZ2h0
L2xpYnhsX3g4Ni5jDQo+PiArKysgYi90b29scy9saWJzL2xpZ2h0L2xpYnhsX3g4Ni5jDQo+PiBA
QCAtODY2LDYgKzg2NiwxNyBAQCBpbnQgbGlieGxfX2FyY2hfcGFzc3Rocm91Z2hfbW9kZV9zZXRk
ZWZhdWx0KGxpYnhsX19nYyAqZ2MsDQo+PiAgICAgICByZXR1cm4gcmM7DQo+PiAgIH0NCj4+ICAg
DQo+PiArdm9pZCBsaWJ4bF9fYXJjaF9nZXRfcGh5c2luZm8obGlieGxfcGh5c2luZm8gKnBoeXNp
bmZvLA0KPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IHhjX3BoeXNpbmZv
X3QgKnhjcGh5c2luZm8pDQo+PiArew0KPj4gKyAgICBwaHlzaW5mby0+Y2FwX2Fzc2lzdGVkX3hh
cGljID0NCj4+ICsgICAgICAgICEhKHhjcGh5c2luZm8tPmFyY2hfY2FwYWJpbGl0aWVzICYNCj4+
ICsgICAgICAgICAgIFhFTl9TWVNDVExfUEhZU0NBUF9YODZfQVNTSVNURURfWEFQSUMpOw0KPj4g
KyAgICBwaHlzaW5mby0+Y2FwX2Fzc2lzdGVkX3gyYXBpYyA9DQo+PiArICAgICAgICAhISh4Y3Bo
eXNpbmZvLT5hcmNoX2NhcGFiaWxpdGllcyAmDQo+PiArICAgICAgICAgICBYRU5fU1lTQ1RMX1BI
WVNDQVBfWDg2X0FTU0lTVEVEX1gyQVBJQyk7DQo+PiArfQ0KPj4gKw0KPj4gICB2b2lkIGxpYnhs
X19hcmNoX3VwZGF0ZV9kb21haW5fY29uZmlnKGxpYnhsX19nYyAqZ2MsDQo+PiAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbGlieGxfZG9tYWluX2NvbmZpZyAqZHN0LA0K
Pj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IGxpYnhsX2Rv
bWFpbl9jb25maWcgKnNyYykNCj4+IGRpZmYgLS1naXQgYS90b29scy9vY2FtbC9saWJzL3hjL3hl
bmN0cmwubWwgYi90b29scy9vY2FtbC9saWJzL3hjL3hlbmN0cmwubWwNCj4+IGluZGV4IDc1MDMw
MzFkOGYuLjdjZTgzMmQ2MDUgMTAwNjQ0DQo+PiAtLS0gYS90b29scy9vY2FtbC9saWJzL3hjL3hl
bmN0cmwubWwNCj4+ICsrKyBiL3Rvb2xzL29jYW1sL2xpYnMveGMveGVuY3RybC5tbA0KPj4gQEAg
LTEyNyw2ICsxMjcsMTAgQEAgdHlwZSBwaHlzaW5mb19jYXBfZmxhZyA9DQo+PiAgIAl8IENBUF9H
bnR0YWJfdjENCj4+ICAgCXwgQ0FQX0dudHRhYl92Mg0KPj4gICANCj4+ICt0eXBlIHBoeXNpbmZv
X2NhcF9hcmNoX2ZsYWcgPQ0KPj4gKwl8IENBUF9BUkNIX0FTU0lTVEVEX1hBUElDDQo+PiArCXwg
Q0FQX0FSQ0hfQVNTSVNURURfWDJBUElDDQo+PiArDQo+PiAgIHR5cGUgcGh5c2luZm8gPQ0KPj4g
ICB7DQo+PiAgIAl0aHJlYWRzX3Blcl9jb3JlIDogaW50Ow0KPj4gQEAgLTEzOSw2ICsxNDMsNyBA
QCB0eXBlIHBoeXNpbmZvID0NCj4+ICAgCXNjcnViX3BhZ2VzICAgICAgOiBuYXRpdmVpbnQ7DQo+
PiAgIAkoKiBYWFggaHdfY2FwICopDQo+PiAgIAljYXBhYmlsaXRpZXMgICAgIDogcGh5c2luZm9f
Y2FwX2ZsYWcgbGlzdDsNCj4+ICsJYXJjaF9jYXBhYmlsaXRpZXMgOiBwaHlzaW5mb19jYXBfYXJj
aF9mbGFnIGxpc3Q7DQo+IA0KPiBJIGtub3cgdmVyeSBsaXR0bGUgYWJvdXQgT2NhbWwsIGJ1dCBJ
IHRoaW5rIHlvdSBhcmUgbm90IHNldHRpbmcgdGhpcw0KPiBmaWVsZCBhbnl3aGVyZT8gSSB3b3Vs
ZCBleHBlY3QgYSBjYWxsIHRvIG9jYW1sX2xpc3RfdG9fY19iaXRtYXAgYW5kDQo+IHRoZW4geW91
IHdpbGwgbGlrZWx5IG5lZWQgdG8gZGVmaW5lIFhFTl9TWVNDVExfUEhZU0NBUF9YODZfTUFYIHNv
IHlvdQ0KPiBjYW4gY2hlY2sgdGhlIG9wdGlvbnMuIFNlZSBYRU5fU1lTQ1RMX1BIWVNDQVBfTUFY
IGZvciBleGFtcGxlLg0KWWVzLCB5b3UncmUgcmlnaHQsIEkgd2lsbCBhZGQgdGhhdCBpbiB0aGUg
djMuDQo+IA0KPj4gICAJbWF4X25yX2NwdXMgICAgICA6IGludDsNCj4+ICAgfQ0KPj4gICANCj4+
IGRpZmYgLS1naXQgYS90b29scy9vY2FtbC9saWJzL3hjL3hlbmN0cmwubWxpIGIvdG9vbHMvb2Nh
bWwvbGlicy94Yy94ZW5jdHJsLm1saQ0KPj4gaW5kZXggZDFkOWM5MjQ3YS4uYTJiMTUxMzBlZSAx
MDA2NDQNCj4+IC0tLSBhL3Rvb2xzL29jYW1sL2xpYnMveGMveGVuY3RybC5tbGkNCj4+ICsrKyBi
L3Rvb2xzL29jYW1sL2xpYnMveGMveGVuY3RybC5tbGkNCj4+IEBAIC0xMTIsNiArMTEyLDEwIEBA
IHR5cGUgcGh5c2luZm9fY2FwX2ZsYWcgPQ0KPj4gICAgIHwgQ0FQX0dudHRhYl92MQ0KPj4gICAg
IHwgQ0FQX0dudHRhYl92Mg0KPj4gICANCj4+ICt0eXBlIHBoeXNpbmZvX2NhcF9hcmNoX2ZsYWcg
PQ0KPj4gKyAgfCBDQVBfQVJDSF9BU1NJU1RFRF9YQVBJQw0KPj4gKyAgfCBDQVBfQVJDSF9BU1NJ
U1RFRF9YMkFQSUMNCj4+ICsNCj4+ICAgdHlwZSBwaHlzaW5mbyA9IHsNCj4+ICAgICB0aHJlYWRz
X3Blcl9jb3JlIDogaW50Ow0KPj4gICAgIGNvcmVzX3Blcl9zb2NrZXQgOiBpbnQ7DQo+PiBAQCAt
MTIyLDYgKzEyNiw3IEBAIHR5cGUgcGh5c2luZm8gPSB7DQo+PiAgICAgZnJlZV9wYWdlcyAgICAg
ICA6IG5hdGl2ZWludDsNCj4+ICAgICBzY3J1Yl9wYWdlcyAgICAgIDogbmF0aXZlaW50Ow0KPj4g
ICAgIGNhcGFiaWxpdGllcyAgICAgOiBwaHlzaW5mb19jYXBfZmxhZyBsaXN0Ow0KPj4gKyAgYXJj
aF9jYXBhYmlsaXRpZXMgOiBwaHlzaW5mb19jYXBfYXJjaF9mbGFnIGxpc3Q7DQo+PiAgICAgbWF4
X25yX2NwdXMgICAgICA6IGludDsgKCoqIGNvbXBpbGUtdGltZSBtYXggcG9zc2libGUgbnVtYmVy
IG9mIG5yX2NwdXMgKikNCj4+ICAgfQ0KPj4gICB0eXBlIHZlcnNpb24gPSB7IG1ham9yIDogaW50
OyBtaW5vciA6IGludDsgZXh0cmEgOiBzdHJpbmc7IH0NCj4+IGRpZmYgLS1naXQgYS90b29scy94
bC94bF9pbmZvLmMgYi90b29scy94bC94bF9pbmZvLmMNCj4+IGluZGV4IDcxMmI3NjM4YjAuLjMy
MDUyNzA3NTQgMTAwNjQ0DQo+PiAtLS0gYS90b29scy94bC94bF9pbmZvLmMNCj4+ICsrKyBiL3Rv
b2xzL3hsL3hsX2luZm8uYw0KPj4gQEAgLTIxMCw3ICsyMTAsNyBAQCBzdGF0aWMgdm9pZCBvdXRw
dXRfcGh5c2luZm8odm9pZCkNCj4+ICAgICAgICAgICAgaW5mby5od19jYXBbNF0sIGluZm8uaHdf
Y2FwWzVdLCBpbmZvLmh3X2NhcFs2XSwgaW5mby5od19jYXBbN10NCj4+ICAgICAgICAgICApOw0K
Pj4gICANCj4+IC0gICAgbWF5YmVfcHJpbnRmKCJ2aXJ0X2NhcHMgICAgICAgICAgICAgIDolcyVz
JXMlcyVzJXMlcyVzJXMlcyVzXG4iLA0KPj4gKyAgICBtYXliZV9wcmludGYoInZpcnRfY2FwcyAg
ICAgICAgICAgICAgOiVzJXMlcyVzJXMlcyVzJXMlcyVzJXMlcyVzXG4iLA0KPj4gICAgICAgICAg
ICBpbmZvLmNhcF9wdiA/ICIgcHYiIDogIiIsDQo+PiAgICAgICAgICAgIGluZm8uY2FwX2h2bSA/
ICIgaHZtIiA6ICIiLA0KPj4gICAgICAgICAgICBpbmZvLmNhcF9odm0gJiYgaW5mby5jYXBfaHZt
X2RpcmVjdGlvID8gIiBodm1fZGlyZWN0aW8iIDogIiIsDQo+PiBAQCAtMjIxLDcgKzIyMSw5IEBA
IHN0YXRpYyB2b2lkIG91dHB1dF9waHlzaW5mbyh2b2lkKQ0KPj4gICAgICAgICAgICBpbmZvLmNh
cF92bXRyYWNlID8gIiB2bXRyYWNlIiA6ICIiLA0KPj4gICAgICAgICAgICBpbmZvLmNhcF92cG11
ID8gIiB2cG11IiA6ICIiLA0KPj4gICAgICAgICAgICBpbmZvLmNhcF9nbnR0YWJfdjEgPyAiIGdu
dHRhYi12MSIgOiAiIiwNCj4+IC0gICAgICAgICBpbmZvLmNhcF9nbnR0YWJfdjIgPyAiIGdudHRh
Yi12MiIgOiAiIg0KPj4gKyAgICAgICAgIGluZm8uY2FwX2dudHRhYl92MiA/ICIgZ250dGFiLXYy
IiA6ICIiLA0KPj4gKyAgICAgICAgIGluZm8uY2FwX2Fzc2lzdGVkX3hhcGljID8gIiBhc3Npc3Rl
ZF94YXBpYyIgOiAiIiwNCj4+ICsgICAgICAgICBpbmZvLmNhcF9hc3Npc3RlZF94MmFwaWMgPyAi
IGFzc2lzdGVkX3gyYXBpYyIgOiAiIg0KPj4gICAgICAgICAgICk7DQo+PiAgIA0KPj4gICAgICAg
dmluZm8gPSBsaWJ4bF9nZXRfdmVyc2lvbl9pbmZvKGN0eCk7DQo+PiBkaWZmIC0tZ2l0IGEveGVu
L2FyY2gveDg2L2h2bS92bXgvdm1jcy5jIGIveGVuL2FyY2gveDg2L2h2bS92bXgvdm1jcy5jDQo+
PiBpbmRleCA3YWIxNWUwN2EwLi40MDYwYWVmMWJkIDEwMDY0NA0KPj4gLS0tIGEveGVuL2FyY2gv
eDg2L2h2bS92bXgvdm1jcy5jDQo+PiArKysgYi94ZW4vYXJjaC94ODYvaHZtL3ZteC92bWNzLmMN
Cj4+IEBAIC0zNDMsNiArMzQzLDE1IEBAIHN0YXRpYyBpbnQgdm14X2luaXRfdm1jc19jb25maWco
Ym9vbCBic3ApDQo+PiAgICAgICAgICAgICAgIE1TUl9JQTMyX1ZNWF9QUk9DQkFTRURfQ1RMUzIs
ICZtaXNtYXRjaCk7DQo+PiAgICAgICB9DQo+PiAgIA0KPj4gKyAgICAvKiBDaGVjayB3aGV0aGVy
IGhhcmR3YXJlIHN1cHBvcnRzIGFjY2VsZXJhdGVkIHhhcGljIGFuZCB4MmFwaWMuICovDQo+PiAr
ICAgIGlmICggYnNwICkNCj4+ICsgICAgew0KPj4gKyAgICAgICAgYXNzaXN0ZWRfeGFwaWNfYXZh
aWxhYmxlID0gY3B1X2hhc192bXhfdmlydHVhbGl6ZV9hcGljX2FjY2Vzc2VzOw0KPj4gKyAgICAg
ICAgYXNzaXN0ZWRfeDJhcGljX2F2YWlsYWJsZSA9IChjcHVfaGFzX3ZteF9hcGljX3JlZ192aXJ0
IHx8DQo+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNwdV9oYXNfdm14
X3ZpcnR1YWxfaW50cl9kZWxpdmVyeSkgJiYNCj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICBjcHVfaGFzX3ZteF92aXJ0dWFsaXplX3gyYXBpY19tb2RlOw0KPj4gKyAgICB9
DQo+PiArDQo+PiAgICAgICAvKiBUaGUgSUEzMl9WTVhfRVBUX1ZQSURfQ0FQIE1TUiBleGlzdHMg
b25seSB3aGVuIEVQVCBvciBWUElEIGF2YWlsYWJsZSAqLw0KPj4gICAgICAgaWYgKCBfdm14X3Nl
Y29uZGFyeV9leGVjX2NvbnRyb2wgJiAoU0VDT05EQVJZX0VYRUNfRU5BQkxFX0VQVCB8DQo+PiAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBTRUNPTkRBUllfRVhFQ19F
TkFCTEVfVlBJRCkgKQ0KPj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9pbmNsdWRlL2FzbS9k
b21haW4uaCBiL3hlbi9hcmNoL3g4Ni9pbmNsdWRlL2FzbS9kb21haW4uaA0KPj4gaW5kZXggZTYy
ZTEwOTU5OC4uNzI0MzFkZjI2ZCAxMDA2NDQNCj4+IC0tLSBhL3hlbi9hcmNoL3g4Ni9pbmNsdWRl
L2FzbS9kb21haW4uaA0KPj4gKysrIGIveGVuL2FyY2gveDg2L2luY2x1ZGUvYXNtL2RvbWFpbi5o
DQo+PiBAQCAtNzU2LDYgKzc1Niw5IEBAIHN0YXRpYyBpbmxpbmUgdm9pZCBwdl9pbmplY3Rfc3df
aW50ZXJydXB0KHVuc2lnbmVkIGludCB2ZWN0b3IpDQo+PiAgICAgICAgICAgICAgICAgICAgICAg
ICA6IGlzX3B2XzMyYml0X2RvbWFpbihkKSA/IFBWMzJfVk1fQVNTSVNUX01BU0sgXA0KPj4gICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgOiBQVjY0X1ZNX0FT
U0lTVF9NQVNLKQ0KPj4gICANCj4+ICtleHRlcm4gYm9vbCBhc3Npc3RlZF94YXBpY19hdmFpbGFi
bGU7DQo+PiArZXh0ZXJuIGJvb2wgYXNzaXN0ZWRfeDJhcGljX2F2YWlsYWJsZTsNCj4+ICsNCj4+
ICAgI2VuZGlmIC8qIF9fQVNNX0RPTUFJTl9IX18gKi8NCj4+ICAgDQo+PiAgIC8qDQo+PiBkaWZm
IC0tZ2l0IGEveGVuL2FyY2gveDg2L3N5c2N0bC5jIGIveGVuL2FyY2gveDg2L3N5c2N0bC5jDQo+
PiBpbmRleCBhZmY1MmExM2YzLi42NDJjYzk2OTg1IDEwMDY0NA0KPj4gLS0tIGEveGVuL2FyY2gv
eDg2L3N5c2N0bC5jDQo+PiArKysgYi94ZW4vYXJjaC94ODYvc3lzY3RsLmMNCj4+IEBAIC02OSw2
ICs2OSw5IEBAIHN0cnVjdCBsM19jYWNoZV9pbmZvIHsNCj4+ICAgICAgIHVuc2lnbmVkIGxvbmcg
c2l6ZTsNCj4+ICAgfTsNCj4+ICAgDQo+PiArYm9vbCBfX3JvX2FmdGVyX2luaXQgYXNzaXN0ZWRf
eGFwaWNfYXZhaWxhYmxlOw0KPj4gK2Jvb2wgX19yb19hZnRlcl9pbml0IGFzc2lzdGVkX3gyYXBp
Y19hdmFpbGFibGU7DQo+IA0KPiBZb3UgY291bGQgbGlrZWx5IHNob3J0ZW4gdGhpcyBieSBkcm9w
cGluZyB0aGUgX2F2YWlsYWJsZSBzdWZmaXguDQpPa2F5Lg0KDQpUaGFua3MsDQoNCkphbmUu


From xen-devel-bounces@lists.xenproject.org Wed Feb 09 12:27:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 09 Feb 2022 12:27:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269096.463080 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHm4f-0006PR-Mq; Wed, 09 Feb 2022 12:27:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269096.463080; Wed, 09 Feb 2022 12:27:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHm4f-0006PK-Ja; Wed, 09 Feb 2022 12:27:53 +0000
Received: by outflank-mailman (input) for mailman id 269096;
 Wed, 09 Feb 2022 12:27:53 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nHm4e-0006PC-V4
 for xen-devel@lists.xenproject.org; Wed, 09 Feb 2022 12:27:52 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nHm4e-0003z6-Qi; Wed, 09 Feb 2022 12:27:52 +0000
Received: from 54-240-197-228.amazon.com ([54.240.197.228]
 helo=[192.168.1.215]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nHm4e-00030w-Ks; Wed, 09 Feb 2022 12:27:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=OH+QeOw3J4hYf7G+rTy6RFRbg1QJc4aR/2tkVQ9Snho=; b=eHAk0JIlurEX0t4N9nvzQZwpUb
	Hs51ratpKkiPTnEGwbgI8cSWm0ArC/tPnA8bmYPVdCnre+x+GxgdgvOdMfXtwcFELq8LvEE4kaDmx
	ux4QseezokKNqlsJZai5BnxZyfzPEyx4A3C0fsvY9up2AuMfXjyNlLMlCPUGVmIfwILI=;
Message-ID: <355b5383-6710-0a50-9c60-3abbf46970d2@xen.org>
Date: Wed, 9 Feb 2022 12:27:51 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.1
Subject: Re: [PATCH v5 01/11] xen: introduce internal CDF_xxx flags for domain
 creation
To: Penny Zheng <penny.zheng@arm.com>, xen-devel@lists.xenproject.org,
 sstabellini@kernel.org
Cc: Bertrand.Marquis@arm.com, Wei.Chen@arm.com
References: <20220127074929.502885-1-penny.zheng@arm.com>
 <20220127074929.502885-2-penny.zheng@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220127074929.502885-2-penny.zheng@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 27/01/2022 07:49, Penny Zheng wrote:
> From: Stefano Stabellini <sstabellini@kernel.org>
> 
> We are passing an internal-only boolean flag at domain creation to
> specify whether we want the domain to be privileged (i.e. dom0) or
> not. Another flag will be introduced later in this series.
> 
> This commit extends original "boolean" to an "unsigned int" covering both
> the existing "is_priv" and our new "directmap", which will be introduced later.
> 
> To make visible the relationship, we name the respective constants CDF_xxx
> (with no XEN_DOMCTL_ prefix) to represent the difference with the public
> constants XEN_DOMCTL_CDF_xxx.
> 
> Allocate bit 0 as CDF_privileged: whether a domain is privileged or not.
> 
> Signed-off-by: Stefano Stabellini <sstabellini@kernel.org>
> Signed-off-by: Penny Zheng <penny.zheng@arm.com>
> Reviewed-by: Jan Beulich <jbeulich@suse.com>
> Tested-by: Stefano Stabellini <sstabellini@kernel.org>

Reviewed-by: Julien Grall <jgrall@amazon.com>

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Feb 09 12:42:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 09 Feb 2022 12:42:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269107.463095 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHmIY-0000JR-0G; Wed, 09 Feb 2022 12:42:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269107.463095; Wed, 09 Feb 2022 12:42:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHmIX-0000JK-TR; Wed, 09 Feb 2022 12:42:13 +0000
Received: by outflank-mailman (input) for mailman id 269107;
 Wed, 09 Feb 2022 12:42:12 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nHmIW-0000JE-Mg
 for xen-devel@lists.xenproject.org; Wed, 09 Feb 2022 12:42:12 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nHmIW-0004EU-Ha; Wed, 09 Feb 2022 12:42:12 +0000
Received: from 54-240-197-228.amazon.com ([54.240.197.228]
 helo=[192.168.1.215]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nHmIW-00047g-Bo; Wed, 09 Feb 2022 12:42:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=NdjtchxeUtxUw2W7E0QA144yGg9uqmJLRANmaF4d+4I=; b=sPpFrtIPWXlw/IgK29ydwCAl6C
	jq4iUZI5PepZrKRhDj8iRxf9HqTXwQkoWuGVeQm8PuAaDzMa98n5GAX8fXOfKCt5IRQ32dnQEg2lN
	2vU69yszY1P/LtvnYWURSgSi5AQbt5RQyy9dRZvg1JRvBoC5dRUXySYpGn4tyNeHrB10=;
Message-ID: <6d73e9cd-1293-d2cf-5b61-d78246509a03@xen.org>
Date: Wed, 9 Feb 2022 12:42:10 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.1
Subject: Re: [PATCH v5 02/11] xen: introduce CDF_directmap
To: Penny Zheng <penny.zheng@arm.com>, xen-devel@lists.xenproject.org,
 sstabellini@kernel.org
Cc: Bertrand.Marquis@arm.com, Wei.Chen@arm.com
References: <20220127074929.502885-1-penny.zheng@arm.com>
 <20220127074929.502885-3-penny.zheng@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220127074929.502885-3-penny.zheng@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 27/01/2022 07:49, Penny Zheng wrote:
> +- direct-map
> +
> +    Only available when statically allocated memory is used for the domain.
> +    An empty property to request the memory of the domain to be
> +    direct-map (guest physical address == physical address).

NIT: I would add "host" just after == so it is more explicit that we are 
talking about host physical address.

> +
>   Under the "xen,domain" compatible node, one or more sub-nodes are present
>   for the DomU kernel and ramdisk.
>   
> diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
> index 92a6c509e5..8110c1df86 100644
> --- a/xen/arch/arm/domain.c
> +++ b/xen/arch/arm/domain.c
> @@ -692,7 +692,8 @@ int arch_sanitise_domain_config(struct xen_domctl_createdomain *config)
>   }
>   
>   int arch_domain_create(struct domain *d,
> -                       struct xen_domctl_createdomain *config)
> +                       struct xen_domctl_createdomain *config,
> +                       unsigned int flags)
>   {
>       int rc, count = 0;
>   
> @@ -708,6 +709,8 @@ int arch_domain_create(struct domain *d,
>       ioreq_domain_init(d);
>   #endif
>   
> +    d->arch.directmap = flags & CDF_directmap;
> +
>       /* p2m_init relies on some value initialized by the IOMMU subsystem */
>       if ( (rc = iommu_domain_init(d, config->iommu_opts)) != 0 )
>           goto fail;

[...]

> diff --git a/xen/arch/arm/include/asm/domain.h b/xen/arch/arm/include/asm/domain.h
> index 9b3647587a..cb37ce89ec 100644
> --- a/xen/arch/arm/include/asm/domain.h
> +++ b/xen/arch/arm/include/asm/domain.h
> @@ -29,8 +29,7 @@ enum domain_type {
>   #define is_64bit_domain(d) (0)
>   #endif
>   
> -/* The hardware domain has always its memory direct mapped. */
> -#define is_domain_direct_mapped(d) is_hardware_domain(d)
> +#define is_domain_direct_mapped(d) (d->arch.directmap)

The outter parentheses are not necessary. However, you want to surround 
d with parentheses to avoid any surprise.

>   
>   struct vtimer {
>       struct vcpu *v;
> @@ -89,6 +88,8 @@ struct arch_domain
>   #ifdef CONFIG_TEE
>       void *tee;
>   #endif
> +
> +    bool directmap;

I am OK with creating a boolean for now. But long term, I think we 
should switch to storing the flags directly as this is more space 
efficient and make easier to add new flags (see d->options for instance).

>   }  __cacheline_aligned;
>   
>   struct arch_vcpu
> diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c
> index ef1812dc14..9835f90ea0 100644
> --- a/xen/arch/x86/domain.c
> +++ b/xen/arch/x86/domain.c
> @@ -722,7 +722,8 @@ static bool emulation_flags_ok(const struct domain *d, uint32_t emflags)
>   }
>   
>   int arch_domain_create(struct domain *d,
> -                       struct xen_domctl_createdomain *config)
> +                       struct xen_domctl_createdomain *config,
> +                       unsigned int flags)

Shouldn't we return an error if the flag CDF_directmap is on x86? The 
other alternative is to...

>   {
>       bool paging_initialised = false;
>       uint32_t emflags;
> diff --git a/xen/common/domain.c b/xen/common/domain.c
> index a79103e04a..3742322d22 100644
> --- a/xen/common/domain.c
> +++ b/xen/common/domain.c
> @@ -659,7 +659,7 @@ struct domain *domain_create(domid_t domid,
>           radix_tree_init(&d->pirq_tree);
>       }
>   
> -    if ( (err = arch_domain_create(d, config)) != 0 )
> +    if ( (err = arch_domain_create(d, config, flags)) != 0 )
>           goto fail;
>       init_status |= INIT_arch;
>   
> diff --git a/xen/include/xen/domain.h b/xen/include/xen/domain.h
> index cfb0b47f13..3a2371d715 100644
> --- a/xen/include/xen/domain.h
> +++ b/xen/include/xen/domain.h
> @@ -31,6 +31,8 @@ void arch_get_domain_info(const struct domain *d,
>   /* CDF_* constant. Internal flags for domain creation. */
>   /* Is this a privileged domain? */
>   #define CDF_privileged           (1U << 0)
> +/* Should domain memory be directly mapped? */
> +#define CDF_directmap            (1U << 1)

... protect this with #ifdef CONFIG_ARM.

Jan, what do you think?

>   
>   /*
>    * Arch-specifics.
> @@ -65,7 +67,8 @@ int map_vcpu_info(struct vcpu *v, unsigned long gfn, unsigned offset);
>   void unmap_vcpu_info(struct vcpu *v);
>   
>   int arch_domain_create(struct domain *d,
> -                       struct xen_domctl_createdomain *config);
> +                       struct xen_domctl_createdomain *config,
> +                       unsigned int flags);
>   
>   void arch_domain_destroy(struct domain *d);
>   

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Feb 09 13:10:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 09 Feb 2022 13:10:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269117.463116 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHmji-0003oN-Gi; Wed, 09 Feb 2022 13:10:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269117.463116; Wed, 09 Feb 2022 13:10:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHmji-0003oG-DR; Wed, 09 Feb 2022 13:10:18 +0000
Received: by outflank-mailman (input) for mailman id 269117;
 Wed, 09 Feb 2022 13:10:17 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=50R8=SY=irit.fr=dinhngoc.tu@srs-se1.protection.inumbo.net>)
 id 1nHmjh-0003YU-Ot
 for xen-devel@lists.xenproject.org; Wed, 09 Feb 2022 13:10:17 +0000
Received: from smtp1.irit.fr (smtp1.irit.fr [141.115.24.2])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9fd58bef-89a9-11ec-8f75-fffcc8bd4f1a;
 Wed, 09 Feb 2022 14:10:16 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9fd58bef-89a9-11ec-8f75-fffcc8bd4f1a
From: Tu Dinh Ngoc <dinhngoc.tu@irit.fr>
To: xen-devel@lists.xenproject.org
Cc: Tu Dinh Ngoc <dinhngoc.tu@irit.fr>
Subject: [PATCH 1/2] x86: Parse Multiboot2 framebuffer information
Date: Wed,  9 Feb 2022 14:09:06 +0100
Message-Id: <20220209130907.252-2-dinhngoc.tu@irit.fr>
In-Reply-To: <20220209130907.252-1-dinhngoc.tu@irit.fr>
References: <20220209130907.252-1-dinhngoc.tu@irit.fr>
Content-Transfer-Encoding: 8bit

Multiboot2 exposes framebuffer data in its boot information tags. Xen
requests this information from the bootloader, but does not make use of
it.

Parse this information for later use.
---
 xen/arch/x86/boot/reloc.c    | 22 ++++++++++++++++++++++
 xen/include/xen/multiboot.h  | 17 +++++++++++++++++
 xen/include/xen/multiboot2.h | 33 +++++++++++++++++++++++++++++++++
 3 files changed, 72 insertions(+)

diff --git a/xen/arch/x86/boot/reloc.c b/xen/arch/x86/boot/reloc.c
index 4f4039bb7c..01a53d3ae5 100644
--- a/xen/arch/x86/boot/reloc.c
+++ b/xen/arch/x86/boot/reloc.c
@@ -156,6 +156,8 @@ static multiboot_info_t *mbi2_reloc(u32 mbi_in)
     multiboot_info_t *mbi_out;
     u32 ptr;
     unsigned int i, mod_idx = 0;
+    u64 fbaddr;
+    u8 fbtype;
 
     ptr = alloc_mem(sizeof(*mbi_out));
     mbi_out = _p(ptr);
@@ -254,6 +256,26 @@ static multiboot_info_t *mbi2_reloc(u32 mbi_in)
             ++mod_idx;
             break;
 
+        case MULTIBOOT2_TAG_TYPE_FRAMEBUFFER:
+            fbaddr = get_mb2_data(tag, framebuffer, framebuffer_addr);
+            fbtype = get_mb2_data(tag, framebuffer, framebuffer_type);
+            if (fbaddr == 0 || fbtype != MULTIBOOT2_FRAMEBUFFER_TYPE_RGB)
+                break;
+            mbi_out->flags |= MBI_FB;
+            mbi_out->fb.addr = fbaddr;
+            mbi_out->fb.pitch = get_mb2_data(tag, framebuffer, framebuffer_pitch);
+            mbi_out->fb.width = get_mb2_data(tag, framebuffer, framebuffer_width);
+            mbi_out->fb.height = get_mb2_data(tag, framebuffer, framebuffer_height);
+            mbi_out->fb.bpp = get_mb2_data(tag, framebuffer, framebuffer_bpp);
+            mbi_out->fb.type = fbtype;
+            mbi_out->fb.red_pos = get_mb2_data(tag, framebuffer, framebuffer_red_field_position);
+            mbi_out->fb.red_size = get_mb2_data(tag, framebuffer, framebuffer_red_mask_size);
+            mbi_out->fb.green_pos = get_mb2_data(tag, framebuffer, framebuffer_green_field_position);
+            mbi_out->fb.green_size = get_mb2_data(tag, framebuffer, framebuffer_green_mask_size);
+            mbi_out->fb.blue_pos = get_mb2_data(tag, framebuffer, framebuffer_blue_field_position);
+            mbi_out->fb.blue_size = get_mb2_data(tag, framebuffer, framebuffer_blue_mask_size);
+            break;
+
         case MULTIBOOT2_TAG_TYPE_END:
             return mbi_out;
 
diff --git a/xen/include/xen/multiboot.h b/xen/include/xen/multiboot.h
index d1b43e1183..2d829b5fa7 100644
--- a/xen/include/xen/multiboot.h
+++ b/xen/include/xen/multiboot.h
@@ -42,6 +42,7 @@
 #define MBI_BIOSCONFIG (_AC(1,u) << 8)
 #define MBI_LOADERNAME (_AC(1,u) << 9)
 #define MBI_APM        (_AC(1,u) << 10)
+#define MBI_FB         (_AC(1,u) << 11)
 
 #ifndef __ASSEMBLY__
 
@@ -101,6 +102,22 @@ typedef struct {
 
     /* Valid if flags sets MBI_APM */
     u32 apm_table;
+
+    /* Valid if flags sets MBI_FB */
+    struct {
+        u64 addr;
+        u32 pitch;
+        u32 width;
+        u32 height;
+        u8 bpp;
+        u8 type;
+        u8 red_pos;
+        u8 red_size;
+        u8 green_pos;
+        u8 green_size;
+        u8 blue_pos;
+        u8 blue_size;
+    } fb;
 } multiboot_info_t;
 
 /* The module structure.  */
diff --git a/xen/include/xen/multiboot2.h b/xen/include/xen/multiboot2.h
index 5acd225044..a86a080038 100644
--- a/xen/include/xen/multiboot2.h
+++ b/xen/include/xen/multiboot2.h
@@ -177,6 +177,39 @@ typedef struct {
     u32 mod_end;
     char cmdline[];
 } multiboot2_tag_module_t;
+
+typedef struct {
+    u8 red;
+    u8 green;
+    u8 blue;
+} multiboot2_framebuffer_color_t;
+
+typedef struct {
+    u32 type;
+    u32 size;
+    u64 framebuffer_addr;
+    u32 framebuffer_pitch;
+    u32 framebuffer_width;
+    u32 framebuffer_height;
+    u8 framebuffer_bpp;
+    u8 framebuffer_type;
+    u16 reserved;
+
+    union {
+        struct {
+            u16 framebuffer_palette_num_colors;
+            multiboot2_framebuffer_color_t framebuffer_palette[0];
+        };
+        struct {
+            u8 framebuffer_red_field_position;
+            u8 framebuffer_red_mask_size;
+            u8 framebuffer_green_field_position;
+            u8 framebuffer_green_mask_size;
+            u8 framebuffer_blue_field_position;
+            u8 framebuffer_blue_mask_size;
+        };
+    };
+} multiboot2_tag_framebuffer_t;
 #endif /* __ASSEMBLY__ */
 
 #endif /* __MULTIBOOT2_H__ */
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Feb 09 13:10:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 09 Feb 2022 13:10:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269116.463106 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHmjf-0003Yh-8x; Wed, 09 Feb 2022 13:10:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269116.463106; Wed, 09 Feb 2022 13:10:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHmjf-0003Ya-5l; Wed, 09 Feb 2022 13:10:15 +0000
Received: by outflank-mailman (input) for mailman id 269116;
 Wed, 09 Feb 2022 13:10:13 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=50R8=SY=irit.fr=dinhngoc.tu@srs-se1.protection.inumbo.net>)
 id 1nHmjd-0003YU-87
 for xen-devel@lists.xenproject.org; Wed, 09 Feb 2022 13:10:13 +0000
Received: from smtp1.irit.fr (smtp1.irit.fr [141.115.24.2])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9c76d170-89a9-11ec-8f75-fffcc8bd4f1a;
 Wed, 09 Feb 2022 14:10:11 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9c76d170-89a9-11ec-8f75-fffcc8bd4f1a
From: Tu Dinh Ngoc <dinhngoc.tu@irit.fr>
To: xen-devel@lists.xenproject.org
Cc: Tu Dinh Ngoc <dinhngoc.tu@irit.fr>
Subject: [PATCH 0/2] x86: Use Multiboot framebuffer
Date: Wed,  9 Feb 2022 14:09:05 +0100
Message-Id: <20220209130907.252-1-dinhngoc.tu@irit.fr>
Content-Transfer-Encoding: 8bit

Xen does not currently use the Multiboot framebuffer. This means there
is no graphics when booting Xen with Kexec.

This patchset parses and uses the Multiboot framebuffer information
during boot.

Tu Dinh Ngoc (2):
  x86: Parse Multiboot2 framebuffer information
  x86: Set up framebuffer given by Multiboot2

 xen/arch/x86/boot/reloc.c    | 22 ++++++++++++++++++
 xen/arch/x86/setup.c         | 45 +++++++++++++++++++++++++++++++++---
 xen/include/xen/multiboot.h  | 17 ++++++++++++++
 xen/include/xen/multiboot2.h | 33 ++++++++++++++++++++++++++
 4 files changed, 114 insertions(+), 3 deletions(-)

-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Feb 09 13:10:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 09 Feb 2022 13:10:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269118.463128 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHmjl-00046L-Pu; Wed, 09 Feb 2022 13:10:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269118.463128; Wed, 09 Feb 2022 13:10:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHmjl-00046A-LG; Wed, 09 Feb 2022 13:10:21 +0000
Received: by outflank-mailman (input) for mailman id 269118;
 Wed, 09 Feb 2022 13:10:20 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=50R8=SY=irit.fr=dinhngoc.tu@srs-se1.protection.inumbo.net>)
 id 1nHmjk-0003YU-He
 for xen-devel@lists.xenproject.org; Wed, 09 Feb 2022 13:10:20 +0000
Received: from smtp1.irit.fr (smtp1.irit.fr [141.115.24.2])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a18889dd-89a9-11ec-8f75-fffcc8bd4f1a;
 Wed, 09 Feb 2022 14:10:19 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a18889dd-89a9-11ec-8f75-fffcc8bd4f1a
From: Tu Dinh Ngoc <dinhngoc.tu@irit.fr>
To: xen-devel@lists.xenproject.org
Cc: Tu Dinh Ngoc <dinhngoc.tu@irit.fr>
Subject: [PATCH 2/2] x86: Set up framebuffer given by Multiboot2
Date: Wed,  9 Feb 2022 14:09:07 +0100
Message-Id: <20220209130907.252-3-dinhngoc.tu@irit.fr>
In-Reply-To: <20220209130907.252-1-dinhngoc.tu@irit.fr>
References: <20220209130907.252-1-dinhngoc.tu@irit.fr>
Content-Transfer-Encoding: 8bit

Previously, we do not make use of the framebuffer given by Multiboot.
This means graphics will not work in some scenarios such as booting from
Kexec.

Enable the Multiboot framebuffer if it exists and not overridden by EFI
probe.
---
 xen/arch/x86/setup.c | 45 +++++++++++++++++++++++++++++++++++++++++---
 1 file changed, 42 insertions(+), 3 deletions(-)

diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c
index 115f8f6517..04d8be407e 100644
--- a/xen/arch/x86/setup.c
+++ b/xen/arch/x86/setup.c
@@ -551,16 +551,55 @@ struct boot_video_info {
 extern struct boot_video_info boot_vid_info;
 #endif
 
-static void __init parse_video_info(void)
+static void __init parse_video_info(multiboot_info_t *mbi)
 {
 #ifdef CONFIG_VIDEO
     struct boot_video_info *bvi = &bootsym(boot_vid_info);
 
+    /*
+     * fb detection will be in this order:
+     *  - efifb (as efifb probe sets a new GOP mode before parse_video_info is called,
+     *    we must use this mode instead of the one given by mbifb)
+     *  - mbifb
+     *  - vesafb
+     */
+
     /* vga_console_info is filled directly on EFI platform. */
     if ( efi_enabled(EFI_BOOT) )
         return;
 
-    if ( (bvi->orig_video_isVGA == 1) && (bvi->orig_video_mode == 3) )
+    if ( mbi->flags & MBI_FB )
+    {
+        uint64_t lfb_rgb_bitmap = 0;
+
+        vga_console_info.video_type = XEN_VGATYPE_VESA_LFB;
+        vga_console_info.u.vesa_lfb.width = mbi->fb.width;
+        vga_console_info.u.vesa_lfb.height = mbi->fb.height;
+        vga_console_info.u.vesa_lfb.bytes_per_line = mbi->fb.pitch;
+        vga_console_info.u.vesa_lfb.bits_per_pixel = mbi->fb.bpp;
+        vga_console_info.u.vesa_lfb.lfb_base = mbi->fb.addr;
+        vga_console_info.u.vesa_lfb.lfb_size = (mbi->fb.pitch * mbi->fb.height + 0xffff) >> 16;
+
+        vga_console_info.u.vesa_lfb.red_pos = mbi->fb.red_pos;
+        vga_console_info.u.vesa_lfb.red_size = mbi->fb.red_size;
+        lfb_rgb_bitmap |= (((uint64_t)1 << mbi->fb.red_size) - 1) << mbi->fb.red_pos;
+        vga_console_info.u.vesa_lfb.green_pos = mbi->fb.green_pos;
+        vga_console_info.u.vesa_lfb.green_size = mbi->fb.green_size;
+        lfb_rgb_bitmap |= (((uint64_t)1 << mbi->fb.green_size) - 1) << mbi->fb.green_pos;
+        vga_console_info.u.vesa_lfb.blue_pos = mbi->fb.blue_pos;
+        vga_console_info.u.vesa_lfb.blue_size = mbi->fb.blue_size;
+        lfb_rgb_bitmap |= (((uint64_t)1 << mbi->fb.blue_size) - 1) << mbi->fb.blue_pos;
+
+        /* assume non-weird bit format */
+        vga_console_info.u.vesa_lfb.rsvd_pos = find_first_zero_bit(&lfb_rgb_bitmap, sizeof(lfb_rgb_bitmap) * __CHAR_BIT__);
+        vga_console_info.u.vesa_lfb.rsvd_size = mbi->fb.bpp - mbi->fb.red_size - mbi->fb.green_size - mbi->fb.blue_size;
+        if (vga_console_info.u.vesa_lfb.rsvd_pos >= mbi->fb.bpp || vga_console_info.u.vesa_lfb.rsvd_size < 0) {
+            vga_console_info.u.vesa_lfb.rsvd_pos = 0;
+            vga_console_info.u.vesa_lfb.rsvd_size = 0;
+        }
+        vga_console_info.u.vesa_lfb.gbl_caps = 2; /* possibly non-VGA */
+    }
+    else if ( (bvi->orig_video_isVGA == 1) && (bvi->orig_video_mode == 3) )
     {
         vga_console_info.video_type = XEN_VGATYPE_TEXT_MODE_3;
         vga_console_info.u.text_mode_3.font_height = bvi->orig_video_points;
@@ -933,7 +972,7 @@ void __init noreturn __start_xen(unsigned long mbi_p)
      */
     hypervisor_name = hypervisor_probe();
 
-    parse_video_info();
+    parse_video_info(mbi);
 
     rdmsrl(MSR_EFER, this_cpu(efer));
     asm volatile ( "mov %%cr4,%0" : "=r" (get_cpu_info()->cr4) );
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Feb 09 13:13:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 09 Feb 2022 13:13:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269137.463139 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHmmY-0005LU-88; Wed, 09 Feb 2022 13:13:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269137.463139; Wed, 09 Feb 2022 13:13:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHmmY-0005LN-3z; Wed, 09 Feb 2022 13:13:14 +0000
Received: by outflank-mailman (input) for mailman id 269137;
 Wed, 09 Feb 2022 13:13:12 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=50R8=SY=irit.fr=dinhngoc.tu@srs-se1.protection.inumbo.net>)
 id 1nHmmV-0005LH-LQ
 for xen-devel@lists.xenproject.org; Wed, 09 Feb 2022 13:13:12 +0000
Received: from smtp1.irit.fr (smtp1.irit.fr [141.115.24.2])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 06be1a6b-89aa-11ec-8f75-fffcc8bd4f1a;
 Wed, 09 Feb 2022 14:13:09 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 06be1a6b-89aa-11ec-8f75-fffcc8bd4f1a
From: Tu Dinh Ngoc <dinhngoc.tu@irit.fr>
To: xen-devel@lists.xenproject.org
Cc: Tu Dinh Ngoc <dinhngoc.tu@irit.fr>
Subject: [PATCH v2] x86: Use low memory size directly from Multiboot
Date: Wed,  9 Feb 2022 14:12:51 +0100
Message-Id: <20220209131251.387-1-dinhngoc.tu@irit.fr>
In-Reply-To: <fe2e94e8-9e46-82be-6e83-391f4709ef75@suse.com>
References: <fe2e94e8-9e46-82be-6e83-391f4709ef75@suse.com>
Content-Transfer-Encoding: 8bit

Previously, Xen used information from the BDA to detect the amount of
available low memory. This does not work on some scenarios such as
Coreboot, or when booting from Kexec on a UEFI system without CSM.

Use the information directly supplied by Multiboot boot information
instead.
---
 xen/arch/x86/boot/head.S | 34 ++++++++++++----------------------
 1 file changed, 12 insertions(+), 22 deletions(-)

diff --git a/xen/arch/x86/boot/head.S b/xen/arch/x86/boot/head.S
index dd1bea0d10..62fe3fe55b 100644
--- a/xen/arch/x86/boot/head.S
+++ b/xen/arch/x86/boot/head.S
@@ -524,33 +524,23 @@ trampoline_bios_setup:
         mov     %ecx,%fs
         mov     %ecx,%gs
 
-        /* Set up trampoline segment 64k below EBDA */
-        movzwl  0x40e,%ecx          /* EBDA segment */
-        cmp     $0xa000,%ecx        /* sanity check (high) */
-        jae     0f
-        cmp     $0x4000,%ecx        /* sanity check (low) */
-        jae     1f
-0:
-        movzwl  0x413,%ecx          /* use base memory size on failure */
-        shl     $10-4,%ecx
-1:
+        /* Use lower memory size directly from Multiboot */
+        mov     %edx,%ecx
         /*
-         * Compare the value in the BDA with the information from the
-         * multiboot structure (if available) and use the smallest.
+         * Old Kexec used to report the value in bytes instead of kilobytes
+         * like it's supposed to, so fix that if detected.
          */
-        cmp     $0x100,%edx         /* is the multiboot value too small? */
-        jb      2f                  /* if so, do not use it */
-        shl     $10-4,%edx
-        cmp     %ecx,%edx           /* compare with BDA value */
-        cmovb   %edx,%ecx           /* and use the smaller */
+        cmpl    $640,%ecx
+        jbe     1f
+        shr     $10,%ecx
+1:
+        /* From arch/x86/smpboot.c: start_eip had better be page-aligned! */
+        shr     $2,%ecx
 
-2:
         /* Reserve memory for the trampoline and the low-memory stack. */
-        sub     $((TRAMPOLINE_SPACE+TRAMPOLINE_STACK_SPACE)>>4),%ecx
+        sub     $((TRAMPOLINE_SPACE+TRAMPOLINE_STACK_SPACE)>>12),%ecx
 
-        /* From arch/x86/smpboot.c: start_eip had better be page-aligned! */
-        xor     %cl, %cl
-        shl     $4, %ecx
+        shl     $12,%ecx
         mov     %ecx,sym_esi(trampoline_phys)
 
 trampoline_setup:
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Feb 09 13:21:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 09 Feb 2022 13:21:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269148.463150 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHmuJ-0006ly-Ug; Wed, 09 Feb 2022 13:21:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269148.463150; Wed, 09 Feb 2022 13:21:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHmuJ-0006lr-Rb; Wed, 09 Feb 2022 13:21:15 +0000
Received: by outflank-mailman (input) for mailman id 269148;
 Wed, 09 Feb 2022 13:21:14 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=XFrC=SY=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nHmuH-0006ll-U4
 for xen-devel@lists.xenproject.org; Wed, 09 Feb 2022 13:21:14 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 23a59e5b-89ab-11ec-8f75-fffcc8bd4f1a;
 Wed, 09 Feb 2022 14:21:07 +0100 (CET)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2105.outbound.protection.outlook.com [104.47.17.105]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-28-ctLprG98OjSMGQh0dsGcQg-1; Wed, 09 Feb 2022 14:21:06 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DBBPR04MB7690.eurprd04.prod.outlook.com (2603:10a6:10:200::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Wed, 9 Feb
 2022 13:21:05 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.018; Wed, 9 Feb 2022
 13:21:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 23a59e5b-89ab-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644412867;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=IrQIcCnh+uqnDNwC2NvysJnfMKDvli7VUYxc9MRsG/4=;
	b=ckxbaGc/QU68/G6vaMLq9hMBO4LalUasQOv7L8jegirxJoJz1E4Rul3Xc1sRYUXMMJt5mJ
	OT5PFjrE32TIEgtSdUp+yhQs8w9Z14TFZxpqOGbyMAqjux8mj9CQTgnxkHLy74pc4+jtHE
	vvrvEe5Keq58JJ+X+1lawUeymclk+u0=
X-MC-Unique: ctLprG98OjSMGQh0dsGcQg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=iFPKg1HOLZ2u+q9BdEdhfr+j2Z/vZfEp9Jh9eGp8QuTB/DuhvqN5js9z/TjQYbsaOoYAJhrUBnqYtsAcFRdF+OMF/jAOJkKgStCmJiSKZr3SgvUETiJt9DpvMqlnw/jYS0ZZWO0uu1hVPbjErTN0apvdEeJ2vqQRVsL3lTXxAWLgQD/5dXegwAJl3291zP9DgQLhtUdGqOCUFhT/YvsGgU5qmohP+1x1S0ItN0ZiKM8nBNUD/hkqWloh7XlW9sIqaV1fmacl4I+sd0GEfpxdpCnvtief1lWYuz6rNOcbfb6K4XDF2RoTZc3fuIkLVvG4KdjxuhFx2S2v3Bv4CWzkgg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=IrQIcCnh+uqnDNwC2NvysJnfMKDvli7VUYxc9MRsG/4=;
 b=DAFzG5f+e1Eiw2A2IBdHcogMby7Y/PgzanLFsOtrOMLXr1JZVRi+YgmczS6KZrPOA6wxNpEZVliiJ/5TbkjNfkLzbkSycifXF6fnlwdWmp1edtb2pp4E30wzQS6RMpwvUZa5hh3HCElUaWsrHNEcdGTTraQtjE9v4mHMLv2lfZFPrCsJNpHKX+hGuzmQEoTjN41o7izpmDNJ5TNTms62dLMTRvtYLKC5lDklPtDuKUUTftSNk4bmqP95kWRSGHE9BIeOyneZXNdRqP5HzCsJ5C7krHR3UaRJGsRgapcsOWw738m/1BKIut0eEQ1UiyjCPl9LpP/S4D5MOJsekJD4Bg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <b9f41055-c7f6-ccdb-5283-53191d025a8c@suse.com>
Date: Wed, 9 Feb 2022 14:21:02 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH v5 02/11] xen: introduce CDF_directmap
Content-Language: en-US
To: Julien Grall <julien@xen.org>
Cc: Bertrand.Marquis@arm.com, Wei.Chen@arm.com,
 Penny Zheng <penny.zheng@arm.com>, xen-devel@lists.xenproject.org,
 sstabellini@kernel.org
References: <20220127074929.502885-1-penny.zheng@arm.com>
 <20220127074929.502885-3-penny.zheng@arm.com>
 <6d73e9cd-1293-d2cf-5b61-d78246509a03@xen.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <6d73e9cd-1293-d2cf-5b61-d78246509a03@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0280.eurprd06.prod.outlook.com
 (2603:10a6:20b:45a::17) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 0e1a08d6-44b4-439d-98c4-08d9ebcf0682
X-MS-TrafficTypeDiagnostic: DBBPR04MB7690:EE_
X-Microsoft-Antispam-PRVS:
	<DBBPR04MB7690DFC5C565514C488A7FA9B32E9@DBBPR04MB7690.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	5Lrf/LdxHBAyYdPVN06VY4gmsnFwG7P2gma0kwv/sqj5L5KAjsfG/h1PWikTqAnF7AzZj+kWmpC5swU8as1ka1EmJ5bYh20m/hDSmlt5E8mmq5yYbSoxsmeb5WMGa66o9QvsaoXCK1skLvsL2InsjAkKTcVgMs3FtWqfc03ixPKYh+SqwsWp6a5MEK+JxCNO7Ohk6LByCA/g+9Q046a/JczibMSmDXs4/psSGvHo1/ZViIXa1Z98ulG5yb6PTv+QfGVqRQj3xgpdg0eKDzInVgpcyZLj9i/FzGwV3qBiDjyXL0cuiJ0FNc2TMj4501CTX11dVRrgWciDKiUHRumaBp8QAr8MFpnz94s5SCfL1LUqKurdaGR2q4jJwAnqzMkLSw4Ao6IOyNdrxn+xwGyGwPqw/R8GbuTCrxAIFHEfUci/VrTNVqyFRiI0zBtntsD3kPqmLxNpZ7vmujeNV2MMQ2SF3rOuirEm7I43hNc4gO4I2EYkNBwgH1HMVHOW4+spzrW41zCan1zjWWyYytcezwkiuujtenpVca/wEKAm5FuOWMzaDSWyUfNT7wgAUEExaFTmxqyq7Vl1+F+4i1wGJBAFfdbMSDR/kklOjUosoVIn11sSQRRA7dGIgN8H6y58kBu2f07e0mgC5lKXRIsq53jyfiQoWBKl7tgpkk7Gu7nKDokmVRyqk0eyDZcMxKCSWEsWs1jYRJzW4v1euAMf6JRFuKr/LktPsVIAl7EBpw9HbdG2kLS4e7YHJ/S4yvAm
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(36756003)(6666004)(2616005)(6506007)(5660300002)(6512007)(38100700002)(2906002)(31686004)(6916009)(316002)(53546011)(186003)(26005)(31696002)(8936002)(86362001)(66556008)(508600001)(66476007)(6486002)(4326008)(8676002)(66946007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NTRvcEliWDdMTHNWUC85OFJTZnpNelVYZEZqMDIyK2E0K0RYZWJJdEU1cmlF?=
 =?utf-8?B?R2c0TnNYeitKcnNOa0Z0WXdmNVdmK1FTS3dqeUgvbkpPS1hyeTV6ZFEwakZ1?=
 =?utf-8?B?aDdHM0lKblNlbFlqSTJaTEozSEhGUVJ2MVJtbmVsZHA3UjUyRTZyUlVLWFU0?=
 =?utf-8?B?MHUyR1RTTWNEQ1c0TzUrQ1VEVUxTTWxHelJUR2lsWXdRdlZRZittakRKRkNi?=
 =?utf-8?B?TWUxblcweFBzS1NidElpVDNoKzJYcHIzT2RQZ1Q5VzVaV1ZkZnZOTXVjOW55?=
 =?utf-8?B?UGQrb2Nlc0dsdC9QN1dJWTJoWnVCREZTRUVpMWVBTGNVYkNQU2F2ajNuVGEx?=
 =?utf-8?B?Y0hodmZsYnc3TzllUmhqck1xU05JejJwc2ZlNForNUhMVUhyOU9rak81aFc0?=
 =?utf-8?B?SklhcEpqSlhKd3ZHU0ZvZFh3dEJzc015M3JxVVdrYk81M2htdFlveS9LUUtG?=
 =?utf-8?B?VTQ5aTd0T0MzMW5FU2ZwOGFrVWhyK3ZWMW51QWRtbURld2phem1kTm1xWmtL?=
 =?utf-8?B?YU5JZVZicVMweVJqUEVuYVJQUUpTZy9RUTU3bkdLVVllWG9FTzVvTmR0U0l0?=
 =?utf-8?B?KzYvOVhzTTgyWDJBZk5DNXJ2NUltYkM0Q0VqdW02SStDMjc2NjJQZWkwRkM3?=
 =?utf-8?B?V3hYZ2pQSXdqaTdaRmdaYWtXaGdKSXhjM3hZTzVCUStSS0VLNldpUVlDNm45?=
 =?utf-8?B?VjUyTklvREFwY1ZzU3pLUG1xSmlqUkxTUENmZ1JzdkZwQzZXNnlYSkk3QUE2?=
 =?utf-8?B?YzhpRkYyc0FTTm1wODBvSzdZK24zRG1lVHV4V0lUWHNseUt1UnVCaDUzeVBp?=
 =?utf-8?B?eGpWbjV0c0oyN3EwSENBUDBkU3ptUVdhZ2NHQUF6OWhONzEycFNEcnhCenRx?=
 =?utf-8?B?aUtHdGdoZlM4cHhHaVhsQi9jbXlGTXFzWEZQbkZKRzFLZi8wcGhmUExqd3g5?=
 =?utf-8?B?a0t6OFRZaFB6bzhPc0ova0ZxenR6NDVJS0lrbVVqSlU2WjA2NFNEUHpiTzIv?=
 =?utf-8?B?UTllM1d3bjgzNkZXdktEamZ6QW9KNU10dGpJNjJzQmNsTnVtekJVZmJ5eXhh?=
 =?utf-8?B?UTJiR3JEdHhySjhyUGhCbm05dStyRGtUOGdsWjdSaEIreDFuVnZSaHV2SmNO?=
 =?utf-8?B?TUNPNHM5OThNTncyK0toeHdUT2RKSE5LQlBWWGoxdE1CM2Z5YVpWYzZ5TUlT?=
 =?utf-8?B?R0dZdGRpcGFQUUtkZmlpcS9oRVhhMjhFVXAyZ0s3SzhYYTBKZmw2L01ocjYy?=
 =?utf-8?B?ZWU0WjRZSjVDb2t4T1Y3Wk42dU8rMzN0a3kvNHAwUndhejQ3U0VvUU1PRStF?=
 =?utf-8?B?bDU4aHozeUZFZXNTalp4Q2FpVUtoYnRZT1BVSFVCQ3VHQ2R0U1h0aHY3QXJ3?=
 =?utf-8?B?VFdpTng2Q3IrOHpDWHhCb1VaMmFEemNUemZ0TU9uMXRYVGphUVRPTTVMT3pn?=
 =?utf-8?B?eTVxdldGTy9FNTQ1dzRVUDJjK1VuekJzOGZQWmhRa2Rxb2lvN0o5em5CU3NX?=
 =?utf-8?B?SUlxelcwa3Rza1pidDFTSGtHT3B3akdNRURXcHNIeTFzak8vL2FDS1JrbjZI?=
 =?utf-8?B?Tmk1dGFhVXhPR2IveGpraHJwMWZBMCtZMVRBRjZ5aFhFeklXbWpYeE5HSXE3?=
 =?utf-8?B?cU5LcW5uYzNIcGt5ZFkyZjhIaTRVKzEvWC9iR25NOUV6eE9UUW0rYUE4WUl5?=
 =?utf-8?B?TTlKZnBQWkk4OVpRRjdzVHJTT2Z5bDkybFN3Q1o4bU1ValNnY1R1dHpiL243?=
 =?utf-8?B?ZFFOS0lQM1BJN3cwZWFtSWZXbkZ6VXAyZkJWcjdONTU2aGxzM1lETjBEbXA2?=
 =?utf-8?B?azEzRDhQVE1BTHVUNy80RGlFeGNWRE1HL3UyZGtaN3JUV1JaZXEyMkNNeHlN?=
 =?utf-8?B?dzU3YWhYU1pxaHk0UEt3dWV3dmFRaTdwR3JCUWFDNEFrOHVNZms3aE1HQTFu?=
 =?utf-8?B?Rzh6MFpMNzFOY0x3aDVCMGx3SUY3T2tXNkk2SGoxMU5lZGIwb2NuQXdVVldB?=
 =?utf-8?B?OFR2M0E3N1QzcitvN0pGZzYrZ3VpZFk4SHdoMzFrUUl6NE9WQlBXNk9PcGlx?=
 =?utf-8?B?KzBWaGZGb2YyNzVXb2R5QkNFOWxLMXhwVVU5MlZ3YTRPbXJwMmM2SVhLZTF3?=
 =?utf-8?B?TUM3bzZ1MDNQQUNHcW1MYzNKalM2T2dPSTczak15N1lzdUpOWkhNS3dkVjFm?=
 =?utf-8?Q?P7EEfOG7c7n2f/lc5bjkA60=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0e1a08d6-44b4-439d-98c4-08d9ebcf0682
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2022 13:21:05.1177
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jy31YiSsLFqivopbnfXd5/RyEdUFDJUUIZTD+/5XHfOdP88go+AcgqSFgCRbiZWkVW7fuloka/lOkGQrOrfKhQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7690

On 09.02.2022 13:42, Julien Grall wrote:
> On 27/01/2022 07:49, Penny Zheng wrote:
>> --- a/xen/arch/x86/domain.c
>> +++ b/xen/arch/x86/domain.c
>> @@ -722,7 +722,8 @@ static bool emulation_flags_ok(const struct domain *d, uint32_t emflags)
>>   }
>>   
>>   int arch_domain_create(struct domain *d,
>> -                       struct xen_domctl_createdomain *config)
>> +                       struct xen_domctl_createdomain *config,
>> +                       unsigned int flags)
> 
> Shouldn't we return an error if the flag CDF_directmap is on x86? The 
> other alternative is to...

Hmm, maybe rather assert that the flag is not set? But ...

>> --- a/xen/include/xen/domain.h
>> +++ b/xen/include/xen/domain.h
>> @@ -31,6 +31,8 @@ void arch_get_domain_info(const struct domain *d,
>>   /* CDF_* constant. Internal flags for domain creation. */
>>   /* Is this a privileged domain? */
>>   #define CDF_privileged           (1U << 0)
>> +/* Should domain memory be directly mapped? */
>> +#define CDF_directmap            (1U << 1)
> 
> ... protect this with #ifdef CONFIG_ARM.

... I don't mind an #ifdef here, apart from the general concern over
CONFIG_<arch> uses in common code.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Feb 09 13:36:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 09 Feb 2022 13:36:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269158.463161 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHn99-0008MT-D0; Wed, 09 Feb 2022 13:36:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269158.463161; Wed, 09 Feb 2022 13:36:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHn99-0008MM-9w; Wed, 09 Feb 2022 13:36:35 +0000
Received: by outflank-mailman (input) for mailman id 269158;
 Wed, 09 Feb 2022 13:36:33 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=yTKH=SY=gmail.com=andr2000@srs-se1.protection.inumbo.net>)
 id 1nHn97-0008MG-53
 for xen-devel@lists.xenproject.org; Wed, 09 Feb 2022 13:36:33 +0000
Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com
 [2a00:1450:4864:20::135])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4a4ead9e-89ad-11ec-8f75-fffcc8bd4f1a;
 Wed, 09 Feb 2022 14:36:31 +0100 (CET)
Received: by mail-lf1-x135.google.com with SMTP id z19so4156167lfq.13
 for <xen-devel@lists.xenproject.org>; Wed, 09 Feb 2022 05:36:31 -0800 (PST)
Received: from localhost.localdomain (host-176-36-245-220.b024.la.net.ua.
 [176.36.245.220])
 by smtp.gmail.com with ESMTPSA id y17sm851199lfk.57.2022.02.09.05.36.28
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 09 Feb 2022 05:36:29 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4a4ead9e-89ad-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=sSYB8Uua8dhBxMUDXPZLmZ3DA/dC79AYBt3A+4Vje6E=;
        b=VvgUt7QFPqt9j5DuBvdUjQn0gYlQbP1BwfJMzJeO9qCSneZlnKVETmo/w7cwsmuHji
         h5Mofnkg2ChwR1fa6oX+87DoQovK5MKczJD2+fWSZ4QEfQAABAF+tIBwSRSdrx8gfXK3
         sb2nH1kdXijBQgn1lQCZPRzZ0qrYObuKLZDAZ+dbFiSMTeiQJ3tyj/MPsphDNb2uJLA0
         h9oq84+zNOGdRG4nq1YWSYqvWQx6qndZnIXRqXUJ3muCzftHNr9qctKMiajSvSzX4cLE
         FnA+xAZjTbpbxayhLHnPgR1AmFiWaKv5uwHF2zaR0nRqktsLePGEs9LonLbej8rcxz2+
         xnOw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=sSYB8Uua8dhBxMUDXPZLmZ3DA/dC79AYBt3A+4Vje6E=;
        b=fWriBGb4/+q5M8CDpYIYEfRn2YBy0PWm0tZqyxv0j39rNDkNZG4R8M+oE/8tZ4hBYO
         LKJ5YKhhac0QeZIfhERZueyPWfl5+iq+1vS9qxCl5rn42H5LsX3/cbDHMLMGheTRv7z4
         rlAEU3napxW6aVBEUi9qLDyN8KVCm2mLQ2jFXuuGZGvo+/IWrNVcyx3mi7YBsZUe/Ker
         d6vfb0Izy8Yx5Lf2NJMJd+v2nMPi7Nk3/ZOArnHfAbrsGrWAaAH0dsfO4eYy6EbmltOI
         ZUajE6bCygBPRyS7LP/0HpfEChymbipMxbXHXvKTFdI239jdAKPkVj+nSuFp4MKcF0n5
         wRdA==
X-Gm-Message-State: AOAM531ZqUPoc2yI5J33WMJPSE+XCFt4Ou+si6bgeafcencp1cXsftbb
	7+XAmBTt3NNw3IFRwO37N0Bmpo5dRkI=
X-Google-Smtp-Source: ABdhPJzznhZpNNYmrX6FU9ODrsiWwhlNfBlA9abbfZy5PxTohxWJhwieB5LzSGlwOsez5hE49Dxl1Q==
X-Received: by 2002:a05:6512:3f0f:: with SMTP id y15mr1615416lfa.543.1644413790088;
        Wed, 09 Feb 2022 05:36:30 -0800 (PST)
From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: roger.pau@citrix.com,
	jbeulich@suse.com,
	julien@xen.org,
	sstabellini@kernel.org,
	oleksandr_tyshchenko@epam.com,
	volodymyr_babchuk@epam.com,
	artem_mygaiev@epam.com,
	bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: [PATCH] vpci: introduce per-domain lock to protect vpci structure
Date: Wed,  9 Feb 2022 15:36:27 +0200
Message-Id: <20220209133627.959649-1-andr2000@gmail.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

Introduce a per-domain read/write lock to check whether vpci is present,
so we are sure there are no accesses to the contents of the vpci struct
if not. This lock can be used (and in a few cases is used right away)
so that vpci removal can be performed while holding the lock in write
mode. Previously such removal could race with vpci_read for example.

1. Per-domain's vpci_rwlock is used to protect pdev->vpci structure
from being removed.

2. Writing the command register and ROM BAR register may trigger
modify_bars to run, which in turn may access multiple pdevs while
checking for the existing BAR's overlap. The overlapping check, if done
under the read lock, requires vpci->lock to be acquired on both devices
being compared, which may produce a deadlock. It is not possible to
upgrade read lock to write lock in such a case. So, in order to prevent
the deadlock, check which registers are going to be written and acquire
the lock in the appropriate mode from the beginning.

All other code, which doesn't lead to pdev->vpci destruction and does not
access multiple pdevs at the same time, can still use a combination of the
read lock and pdev->vpci->lock.

3. Optimize if ROM BAR write lock required detection by caching offset
of the ROM BAR register in vpci->header->rom_reg which depends on
header's type.

4. Reduce locked region in vpci_remove_device as it is now possible
to set pdev->vpci to NULL early right after the write lock is acquired.

5. Reduce locked region in vpci_add_handlers as it is possible to
initialize many more fields of the struct vpci before assigning it to
pdev->vpci.

6. vpci_{add|remove}_register are required to be called with the write lock
held, but it is not feasible to add an assert there as it requires
struct domain to be passed for that. So, add a comment about this requirement
to these and other functions with the equivalent constraints.

7. Drop const qualifier where the new rwlock is used and this is appropriate.

8. This is based on the discussion at [1].

[1] https://lore.kernel.org/all/20220204063459.680961-4-andr2000@gmail.com/

Suggested-by: Roger Pau Monné <roger.pau@citrix.com>
Suggested-by: Jan Beulich <jbeulich@suse.com>
Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

---
This was checked on x86: with and without PVH Dom0.
---
 xen/arch/x86/hvm/vmsi.c   |   2 +
 xen/common/domain.c       |   3 +
 xen/drivers/vpci/header.c |   8 +++
 xen/drivers/vpci/msi.c    |   8 ++-
 xen/drivers/vpci/msix.c   |  40 +++++++++++--
 xen/drivers/vpci/vpci.c   | 114 ++++++++++++++++++++++++++++----------
 xen/include/xen/sched.h   |   3 +
 xen/include/xen/vpci.h    |   2 +
 8 files changed, 146 insertions(+), 34 deletions(-)

diff --git a/xen/arch/x86/hvm/vmsi.c b/xen/arch/x86/hvm/vmsi.c
index 13e2a190b439..351cb968a423 100644
--- a/xen/arch/x86/hvm/vmsi.c
+++ b/xen/arch/x86/hvm/vmsi.c
@@ -893,6 +893,8 @@ int vpci_msix_arch_print(const struct vpci_msix *msix)
 {
     unsigned int i;
 
+    ASSERT(!!rw_is_locked(&msix->pdev->domain->vpci_rwlock));
+
     for ( i = 0; i < msix->max_entries; i++ )
     {
         const struct vpci_msix_entry *entry = &msix->entries[i];
diff --git a/xen/common/domain.c b/xen/common/domain.c
index 2048ebad86ff..10558c22285d 100644
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -616,6 +616,9 @@ struct domain *domain_create(domid_t domid,
 
 #ifdef CONFIG_HAS_PCI
     INIT_LIST_HEAD(&d->pdev_list);
+#ifdef CONFIG_HAS_VPCI
+    rwlock_init(&d->vpci_rwlock);
+#endif
 #endif
 
     /* All error paths can depend on the above setup. */
diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c
index 40ff79c33f8f..9e2aeb2055c9 100644
--- a/xen/drivers/vpci/header.c
+++ b/xen/drivers/vpci/header.c
@@ -142,12 +142,14 @@ bool vpci_process_pending(struct vcpu *v)
         if ( rc == -ERESTART )
             return true;
 
+        read_lock(&v->domain->vpci_rwlock);
         spin_lock(&v->vpci.pdev->vpci->lock);
         /* Disable memory decoding unconditionally on failure. */
         modify_decoding(v->vpci.pdev,
                         rc ? v->vpci.cmd & ~PCI_COMMAND_MEMORY : v->vpci.cmd,
                         !rc && v->vpci.rom_only);
         spin_unlock(&v->vpci.pdev->vpci->lock);
+        read_unlock(&v->domain->vpci_rwlock);
 
         rangeset_destroy(v->vpci.mem);
         v->vpci.mem = NULL;
@@ -203,6 +205,7 @@ static void defer_map(struct domain *d, struct pci_dev *pdev,
     raise_softirq(SCHEDULE_SOFTIRQ);
 }
 
+/* This must hold domain's vpci_rwlock in write mode. */
 static int modify_bars(const struct pci_dev *pdev, uint16_t cmd, bool rom_only)
 {
     struct vpci_header *header = &pdev->vpci->header;
@@ -454,6 +457,8 @@ static int init_bars(struct pci_dev *pdev)
     struct vpci_bar *bars = header->bars;
     int rc;
 
+    ASSERT(!!rw_is_write_locked(&pdev->domain->vpci_rwlock));
+
     switch ( pci_conf_read8(pdev->sbdf, PCI_HEADER_TYPE) & 0x7f )
     {
     case PCI_HEADER_TYPE_NORMAL:
@@ -548,6 +553,7 @@ static int init_bars(struct pci_dev *pdev)
     {
         struct vpci_bar *rom = &header->bars[num_bars];
 
+        header->rom_reg = rom_reg;
         rom->type = VPCI_BAR_ROM;
         rom->size = size;
         rom->addr = addr;
@@ -559,6 +565,8 @@ static int init_bars(struct pci_dev *pdev)
         if ( rc )
             rom->type = VPCI_BAR_EMPTY;
     }
+    else
+        header->rom_reg = ~(unsigned int)0;
 
     return (cmd & PCI_COMMAND_MEMORY) ? modify_bars(pdev, cmd, false) : 0;
 }
diff --git a/xen/drivers/vpci/msi.c b/xen/drivers/vpci/msi.c
index 5757a7aed20f..5df3dfa8243c 100644
--- a/xen/drivers/vpci/msi.c
+++ b/xen/drivers/vpci/msi.c
@@ -190,6 +190,8 @@ static int init_msi(struct pci_dev *pdev)
     uint16_t control;
     int ret;
 
+    ASSERT(!!rw_is_write_locked(&pdev->domain->vpci_rwlock));
+
     if ( !pos )
         return 0;
 
@@ -265,7 +267,7 @@ REGISTER_VPCI_INIT(init_msi, VPCI_PRIORITY_LOW);
 
 void vpci_dump_msi(void)
 {
-    const struct domain *d;
+    struct domain *d;
 
     rcu_read_lock(&domlist_read_lock);
     for_each_domain ( d )
@@ -277,6 +279,9 @@ void vpci_dump_msi(void)
 
         printk("vPCI MSI/MSI-X d%d\n", d->domain_id);
 
+        if ( !read_trylock(&d->vpci_rwlock) )
+            continue;
+
         for_each_pdev ( d, pdev )
         {
             const struct vpci_msi *msi;
@@ -326,6 +331,7 @@ void vpci_dump_msi(void)
             spin_unlock(&pdev->vpci->lock);
             process_pending_softirqs();
         }
+        read_unlock(&d->vpci_rwlock);
     }
     rcu_read_unlock(&domlist_read_lock);
 }
diff --git a/xen/drivers/vpci/msix.c b/xen/drivers/vpci/msix.c
index 846f1b8d7038..5296d6025d8e 100644
--- a/xen/drivers/vpci/msix.c
+++ b/xen/drivers/vpci/msix.c
@@ -138,6 +138,7 @@ static void control_write(const struct pci_dev *pdev, unsigned int reg,
         pci_conf_write16(pdev->sbdf, reg, val);
 }
 
+/* This must hold domain's vpci_rwlock in write mode. */
 static struct vpci_msix *msix_find(const struct domain *d, unsigned long addr)
 {
     struct vpci_msix *msix;
@@ -158,7 +159,12 @@ static struct vpci_msix *msix_find(const struct domain *d, unsigned long addr)
 
 static int msix_accept(struct vcpu *v, unsigned long addr)
 {
-    return !!msix_find(v->domain, addr);
+    int rc;
+
+    read_lock(&v->domain->vpci_rwlock);
+    rc = !!msix_find(v->domain, addr);
+    read_unlock(&v->domain->vpci_rwlock);
+    return rc;
 }
 
 static bool access_allowed(const struct pci_dev *pdev, unsigned long addr,
@@ -185,18 +191,27 @@ static struct vpci_msix_entry *get_entry(struct vpci_msix *msix,
 static int msix_read(struct vcpu *v, unsigned long addr, unsigned int len,
                      unsigned long *data)
 {
-    const struct domain *d = v->domain;
-    struct vpci_msix *msix = msix_find(d, addr);
+    struct domain *d = v->domain;
+    struct vpci_msix *msix;
     const struct vpci_msix_entry *entry;
     unsigned int offset;
 
     *data = ~0ul;
 
+    read_lock(&d->vpci_rwlock);
+
+    msix = msix_find(d, addr);
     if ( !msix )
+    {
+        read_unlock(&d->vpci_rwlock);
         return X86EMUL_RETRY;
+    }
 
     if ( !access_allowed(msix->pdev, addr, len) )
+    {
+        read_unlock(&d->vpci_rwlock);
         return X86EMUL_OKAY;
+    }
 
     if ( VMSIX_ADDR_IN_RANGE(addr, msix->pdev->vpci, VPCI_MSIX_PBA) )
     {
@@ -222,6 +237,7 @@ static int msix_read(struct vcpu *v, unsigned long addr, unsigned int len,
             break;
         }
 
+        read_unlock(&d->vpci_rwlock);
         return X86EMUL_OKAY;
     }
 
@@ -255,6 +271,7 @@ static int msix_read(struct vcpu *v, unsigned long addr, unsigned int len,
         break;
     }
     spin_unlock(&msix->pdev->vpci->lock);
+    read_unlock(&d->vpci_rwlock);
 
     return X86EMUL_OKAY;
 }
@@ -262,16 +279,25 @@ static int msix_read(struct vcpu *v, unsigned long addr, unsigned int len,
 static int msix_write(struct vcpu *v, unsigned long addr, unsigned int len,
                       unsigned long data)
 {
-    const struct domain *d = v->domain;
-    struct vpci_msix *msix = msix_find(d, addr);
+    struct domain *d = v->domain;
+    struct vpci_msix *msix;
     struct vpci_msix_entry *entry;
     unsigned int offset;
 
+    read_lock(&d->vpci_rwlock);
+
+    msix = msix_find(d, addr);
     if ( !msix )
+    {
+        read_unlock(&d->vpci_rwlock);
         return X86EMUL_RETRY;
+    }
 
     if ( !access_allowed(msix->pdev, addr, len) )
+    {
+        read_unlock(&d->vpci_rwlock);
         return X86EMUL_OKAY;
+    }
 
     if ( VMSIX_ADDR_IN_RANGE(addr, msix->pdev->vpci, VPCI_MSIX_PBA) )
     {
@@ -294,6 +320,7 @@ static int msix_write(struct vcpu *v, unsigned long addr, unsigned int len,
             }
         }
 
+        read_unlock(&d->vpci_rwlock);
         return X86EMUL_OKAY;
     }
 
@@ -371,6 +398,7 @@ static int msix_write(struct vcpu *v, unsigned long addr, unsigned int len,
         break;
     }
     spin_unlock(&msix->pdev->vpci->lock);
+    read_unlock(&d->vpci_rwlock);
 
     return X86EMUL_OKAY;
 }
@@ -437,6 +465,8 @@ static int init_msix(struct pci_dev *pdev)
     struct vpci_msix *msix;
     int rc;
 
+    ASSERT(!!rw_is_write_locked(&pdev->domain->vpci_rwlock));
+
     msix_offset = pci_find_cap_offset(pdev->seg, pdev->bus, slot, func,
                                       PCI_CAP_ID_MSIX);
     if ( !msix_offset )
diff --git a/xen/drivers/vpci/vpci.c b/xen/drivers/vpci/vpci.c
index fb0947179b79..16bb3b832e6a 100644
--- a/xen/drivers/vpci/vpci.c
+++ b/xen/drivers/vpci/vpci.c
@@ -37,28 +37,39 @@ extern vpci_register_init_t *const __end_vpci_array[];
 
 void vpci_remove_device(struct pci_dev *pdev)
 {
+    struct vpci *vpci;
+
     if ( !has_vpci(pdev->domain) )
         return;
 
-    spin_lock(&pdev->vpci->lock);
+    write_lock(&pdev->domain->vpci_rwlock);
+    if ( !pdev->vpci )
+    {
+        write_unlock(&pdev->domain->vpci_rwlock);
+        return;
+    }
+
+    vpci = pdev->vpci;
+    pdev->vpci = NULL;
+    write_unlock(&pdev->domain->vpci_rwlock);
+
     while ( !list_empty(&pdev->vpci->handlers) )
     {
-        struct vpci_register *r = list_first_entry(&pdev->vpci->handlers,
+        struct vpci_register *r = list_first_entry(&vpci->handlers,
                                                    struct vpci_register,
                                                    node);
 
         list_del(&r->node);
         xfree(r);
     }
-    spin_unlock(&pdev->vpci->lock);
-    xfree(pdev->vpci->msix);
-    xfree(pdev->vpci->msi);
-    xfree(pdev->vpci);
-    pdev->vpci = NULL;
+    xfree(vpci->msix);
+    xfree(vpci->msi);
+    xfree(vpci);
 }
 
 int vpci_add_handlers(struct pci_dev *pdev)
 {
+    struct vpci *vpci;
     unsigned int i;
     int rc = 0;
 
@@ -68,12 +79,15 @@ int vpci_add_handlers(struct pci_dev *pdev)
     /* We should not get here twice for the same device. */
     ASSERT(!pdev->vpci);
 
-    pdev->vpci = xzalloc(struct vpci);
-    if ( !pdev->vpci )
+    vpci = xzalloc(struct vpci);
+    if ( !vpci )
         return -ENOMEM;
 
-    INIT_LIST_HEAD(&pdev->vpci->handlers);
-    spin_lock_init(&pdev->vpci->lock);
+    INIT_LIST_HEAD(&vpci->handlers);
+    spin_lock_init(&vpci->lock);
+
+    write_lock(&pdev->domain->vpci_rwlock);
+    pdev->vpci = vpci;
 
     for ( i = 0; i < NUM_VPCI_INIT; i++ )
     {
@@ -81,6 +95,7 @@ int vpci_add_handlers(struct pci_dev *pdev)
         if ( rc )
             break;
     }
+    write_unlock(&pdev->domain->vpci_rwlock);
 
     if ( rc )
         vpci_remove_device(pdev);
@@ -89,22 +104,28 @@ int vpci_add_handlers(struct pci_dev *pdev)
 }
 #endif /* __XEN__ */
 
-static int vpci_register_cmp(const struct vpci_register *r1,
-                             const struct vpci_register *r2)
+static int vpci_offset_cmp(unsigned int r1_offset, unsigned int r1_size,
+                           unsigned int r2_offset, unsigned int r2_size)
 {
     /* Return 0 if registers overlap. */
-    if ( r1->offset < r2->offset + r2->size &&
-         r2->offset < r1->offset + r1->size )
+    if ( r1_offset < r2_offset + r2_size &&
+         r2_offset < r1_offset + r1_size )
         return 0;
-    if ( r1->offset < r2->offset )
+    if ( r1_offset < r2_offset )
         return -1;
-    if ( r1->offset > r2->offset )
+    if ( r1_offset > r2_offset )
         return 1;
 
     ASSERT_UNREACHABLE();
     return 0;
 }
 
+static int vpci_register_cmp(const struct vpci_register *r1,
+                             const struct vpci_register *r2)
+{
+    return vpci_offset_cmp(r1->offset, r1->size, r2->offset, r2->size);
+}
+
 /* Dummy hooks, writes are ignored, reads return 1's */
 static uint32_t vpci_ignored_read(const struct pci_dev *pdev, unsigned int reg,
                                   void *data)
@@ -129,6 +150,7 @@ uint32_t vpci_hw_read32(const struct pci_dev *pdev, unsigned int reg,
     return pci_conf_read32(pdev->sbdf, reg);
 }
 
+/* This must hold domain's vpci_rwlock in write mode. */
 int vpci_add_register(struct vpci *vpci, vpci_read_t *read_handler,
                       vpci_write_t *write_handler, unsigned int offset,
                       unsigned int size, void *data)
@@ -152,8 +174,6 @@ int vpci_add_register(struct vpci *vpci, vpci_read_t *read_handler,
     r->offset = offset;
     r->private = data;
 
-    spin_lock(&vpci->lock);
-
     /* The list of handlers must be kept sorted at all times. */
     list_for_each ( prev, &vpci->handlers )
     {
@@ -165,25 +185,23 @@ int vpci_add_register(struct vpci *vpci, vpci_read_t *read_handler,
             break;
         if ( cmp == 0 )
         {
-            spin_unlock(&vpci->lock);
             xfree(r);
             return -EEXIST;
         }
     }
 
     list_add_tail(&r->node, prev);
-    spin_unlock(&vpci->lock);
 
     return 0;
 }
 
+/* This must hold domain's vpci_rwlock in write mode. */
 int vpci_remove_register(struct vpci *vpci, unsigned int offset,
                          unsigned int size)
 {
     const struct vpci_register r = { .offset = offset, .size = size };
     struct vpci_register *rm;
 
-    spin_lock(&vpci->lock);
     list_for_each_entry ( rm, &vpci->handlers, node )
     {
         int cmp = vpci_register_cmp(&r, rm);
@@ -195,14 +213,12 @@ int vpci_remove_register(struct vpci *vpci, unsigned int offset,
         if ( !cmp && rm->offset == offset && rm->size == size )
         {
             list_del(&rm->node);
-            spin_unlock(&vpci->lock);
             xfree(rm);
             return 0;
         }
         if ( cmp <= 0 )
             break;
     }
-    spin_unlock(&vpci->lock);
 
     return -ENOENT;
 }
@@ -310,7 +326,7 @@ static uint32_t merge_result(uint32_t data, uint32_t new, unsigned int size,
 
 uint32_t vpci_read(pci_sbdf_t sbdf, unsigned int reg, unsigned int size)
 {
-    const struct domain *d = current->domain;
+    struct domain *d = current->domain;
     const struct pci_dev *pdev;
     const struct vpci_register *r;
     unsigned int data_offset = 0;
@@ -327,6 +343,7 @@ uint32_t vpci_read(pci_sbdf_t sbdf, unsigned int reg, unsigned int size)
     if ( !pdev )
         return vpci_read_hw(sbdf, reg, size);
 
+    read_lock(&d->vpci_rwlock);
     spin_lock(&pdev->vpci->lock);
 
     /* Read from the hardware or the emulated register handlers. */
@@ -371,6 +388,7 @@ uint32_t vpci_read(pci_sbdf_t sbdf, unsigned int reg, unsigned int size)
         ASSERT(data_offset < size);
     }
     spin_unlock(&pdev->vpci->lock);
+    read_unlock(&d->vpci_rwlock);
 
     if ( data_offset < size )
     {
@@ -410,14 +428,37 @@ static void vpci_write_helper(const struct pci_dev *pdev,
              r->private);
 }
 
+static bool vpci_header_write_lock(const struct pci_dev *pdev,
+                                   unsigned int start, unsigned int size)
+{
+    /*
+     * Writing the command register and ROM BAR register may trigger
+     * modify_bars to run which in turn may access multiple pdevs while
+     * checking for the existing BAR's overlap. The overlapping check, if done
+     * under the read lock, requires vpci->lock to be acquired on both devices
+     * being compared, which may produce a deadlock. It is not possible to
+     * upgrade read lock to write lock in such a case. So, in order to prevent
+     * the deadlock, check which registers are going to be written and acquire
+     * the lock in the appropriate mode from the beginning.
+     */
+    if ( !vpci_offset_cmp(start, size, PCI_COMMAND, 2) )
+        return true;
+
+    if ( !vpci_offset_cmp(start, size, pdev->vpci->header.rom_reg, 4) )
+        return true;
+
+    return false;
+}
+
 void vpci_write(pci_sbdf_t sbdf, unsigned int reg, unsigned int size,
                 uint32_t data)
 {
-    const struct domain *d = current->domain;
+    struct domain *d = current->domain;
     const struct pci_dev *pdev;
     const struct vpci_register *r;
     unsigned int data_offset = 0;
     const unsigned long *ro_map = pci_get_ro_map(sbdf.seg);
+    bool write_locked = false;
 
     if ( !size )
     {
@@ -440,7 +481,17 @@ void vpci_write(pci_sbdf_t sbdf, unsigned int reg, unsigned int size,
         return;
     }
 
-    spin_lock(&pdev->vpci->lock);
+    if ( vpci_header_write_lock(pdev, reg, size) )
+    {
+        /* Gain exclusive access to all of the domain pdevs vpci. */
+        write_lock(&d->vpci_rwlock);
+        write_locked = true;
+    }
+    else
+    {
+        read_lock(&d->vpci_rwlock);
+        spin_lock(&pdev->vpci->lock);
+    }
 
     /* Write the value to the hardware or emulated registers. */
     list_for_each_entry ( r, &pdev->vpci->handlers, node )
@@ -475,7 +526,14 @@ void vpci_write(pci_sbdf_t sbdf, unsigned int reg, unsigned int size,
             break;
         ASSERT(data_offset < size);
     }
-    spin_unlock(&pdev->vpci->lock);
+
+    if ( write_locked )
+        write_unlock(&d->vpci_rwlock);
+    else
+    {
+        spin_unlock(&pdev->vpci->lock);
+        read_unlock(&d->vpci_rwlock);
+    }
 
     if ( data_offset < size )
         /* Tailing gap, write the remaining. */
diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
index 37f78cc4c4c9..ecd34481a7af 100644
--- a/xen/include/xen/sched.h
+++ b/xen/include/xen/sched.h
@@ -444,6 +444,9 @@ struct domain
 
 #ifdef CONFIG_HAS_PCI
     struct list_head pdev_list;
+#ifdef CONFIG_HAS_VPCI
+    rwlock_t vpci_rwlock;
+#endif
 #endif
 
 #ifdef CONFIG_HAS_PASSTHROUGH
diff --git a/xen/include/xen/vpci.h b/xen/include/xen/vpci.h
index e8ac1eb39513..e19e462ee5cb 100644
--- a/xen/include/xen/vpci.h
+++ b/xen/include/xen/vpci.h
@@ -88,6 +88,8 @@ struct vpci {
          * is mapped into guest p2m) if there's a ROM BAR on the device.
          */
         bool rom_enabled      : 1;
+        /* Offset to the ROM BAR register if any. */
+        unsigned int rom_reg;
         /* FIXME: currently there's no support for SR-IOV. */
     } header;
 
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Feb 09 13:38:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 09 Feb 2022 13:38:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269165.463172 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHnBA-0000Z4-Pj; Wed, 09 Feb 2022 13:38:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269165.463172; Wed, 09 Feb 2022 13:38:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHnBA-0000Yx-MU; Wed, 09 Feb 2022 13:38:40 +0000
Received: by outflank-mailman (input) for mailman id 269165;
 Wed, 09 Feb 2022 13:38:40 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=XFrC=SY=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nHnBA-0000Yr-4C
 for xen-devel@lists.xenproject.org; Wed, 09 Feb 2022 13:38:40 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 96906289-89ad-11ec-8f75-fffcc8bd4f1a;
 Wed, 09 Feb 2022 14:38:39 +0100 (CET)
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur02lp2054.outbound.protection.outlook.com [104.47.4.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-17-hgNoHuLFNY-iIQPZ5IV_uw-1; Wed, 09 Feb 2022 14:38:38 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM8PR04MB7202.eurprd04.prod.outlook.com (2603:10a6:20b:1da::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Wed, 9 Feb
 2022 13:38:37 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.018; Wed, 9 Feb 2022
 13:38:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 96906289-89ad-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644413918;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=cdxoP0qrEd4fbAQscg9PUIZpavjxZTYZp9nObyNZY1A=;
	b=BVZ8a70hUwaO+8fm3zy5vZo9eCXr4xXL1+8UO+8NdYZKpC4UbEU0PjQ6PRGvj4v1Q5vJy7
	3n+wcPqa7GBJza2xlyr2AsDMKwYEZuI/gQ9qQqi0y9UjAbQnXuLP6DgOUQzxc8VDHjNNw/
	b5vjfdCjWtKYKtSM+vXUHu6p9oL2B6U=
X-MC-Unique: hgNoHuLFNY-iIQPZ5IV_uw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=P0vx5vM3GauyzPE/qsM+N7ufpud/UzLzlUxVVjyHjhAIBqPQ1iMt14IehazJQphmoEENVw73xjBgiWVMJa0QSnb46paV9Gh/Jlrl9yuiECFRwyAqiRnD081FBkXNBm3P9jUWY1lTtg9hZKBpXIjLamwS2HhJZ8AuJ6u1TMAD0CZ9Pn8qY4mmP9zkbI25moUX46ONIkbjQOBwpBWy/HnmbzJ0f2mryxtBQBaRuQSX9g3ipiNcudsS4E9rVXVBXa3g6CHvR94eJKlYKRER2eRpqILedLdoRzIMiy5icyf6Ywxsg5hl83zGcNKDGZtA9H9tcL8Orieg1tbjYbKHxrMgYg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=cdxoP0qrEd4fbAQscg9PUIZpavjxZTYZp9nObyNZY1A=;
 b=ha+cKjhlO9J0TbKsS0diOlAtaQRJJ9seNu8wzNgtxPtXjEjFFIy1HR73fe+uf68qCGP1599ybJmOXPyM5cu/2IqHxsQkAq06/nyyXPD1y9j5Ahv0g4l3JSv6KHd4KFZSSGl5jKwH2AZ2z3EQXYvrNzn1YAgmSkrshS8WiKro00QXmP3ufxE1n84Us0SArFQwK3OhBmvyhFSWy/l+xUjR62zj1WORSc/MzNbi9ImoxGXJpFjM9iokO9JuYbGsyokdVnkXU8weEGRPZlkXYb+YTs6rNYmQ1e9OFp8ZHwRrPf97oJay0QmnFnww99QksFKCM5PJeNNsQdYHF5MU1wKtRg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <9e1d13d6-1001-2757-b626-e8f578fac656@suse.com>
Date: Wed, 9 Feb 2022 14:38:31 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH 1/2] x86: Parse Multiboot2 framebuffer information
Content-Language: en-US
To: Tu Dinh Ngoc <dinhngoc.tu@irit.fr>
References: <20220209130907.252-1-dinhngoc.tu@irit.fr>
 <20220209130907.252-2-dinhngoc.tu@irit.fr>
From: Jan Beulich <jbeulich@suse.com>
Cc: xen-devel@lists.xenproject.org
In-Reply-To: <20220209130907.252-2-dinhngoc.tu@irit.fr>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR0P281CA0012.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:15::17) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 073fae14-9581-46fa-7657-08d9ebd17985
X-MS-TrafficTypeDiagnostic: AM8PR04MB7202:EE_
X-Microsoft-Antispam-PRVS:
	<AM8PR04MB7202CE41ED8358898B2186D8B32E9@AM8PR04MB7202.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	4W4O7XSY2HkNaNGfGhFQD/zxg7UeInz3r2NNv9TQLMIuzufYPEzGclBkLP6gaC+/pACKa5PDCYWrenyDtZE5N/3aTcPAknh5Pkbr5qw3Q+CeVuT0J2tHG2dJKJOcHzXOCrr0XaOxSZ/e+BHmJHlHW2d866+ae8iL7GY+KrNZOf/Q7PNXSrX/W0qbPV2sTEPm3/0kmnx+3KujQbwMX/IHqijh3RHoeiH61i6rxPlGcyTPrq1rskZJGofr5jX/WwQOHAhBdwdcbYxnY2UrIDWKQ+qbzNvoE1GNOaNrHVNPEck4U7isl538ymj0TUc98GAx16wbss344oqSwrPgkruSS8JlQoeWX4NAFnF7dZ5NtBeaP0yoF3MOOhAYZK1OLBtE70Gc6r92IUBo/YnmbqapInHJug29Od/GePOOxb01NBDAd8zS8XYpJ1VyRRQygrc71yP/V6ulA7+a8aRdyJ1wrmuwJ+64CSoF4l08wJbfidnWueIitd5iFTGQLBOC4+Ahmuf/WdLik6s7G2PdemvT5n3NliRsm5DCf0wRGMf0nbhQmn1YZKY5lsmBCYRYSOdoUCF32cxaMaqfi7HmPFg58XwC0kiHEOm82IreSOaMgcREjT3jdVpcRPgTeGHxE27A+LX6E4bTffk59QOcwHubssEUuZRsJLK7EJXWW4AgcqNM4TQHXf83K1egamDjtz58th3HcMsbHv8OJQDvTU5evfu+t0zf3Dwml4m51lqJQCs=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(186003)(26005)(508600001)(2616005)(6486002)(53546011)(6512007)(31696002)(6506007)(86362001)(6666004)(83380400001)(66476007)(66556008)(38100700002)(4326008)(8676002)(66946007)(316002)(6916009)(36756003)(2906002)(31686004)(5660300002)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?SEZsdEQ1dlFxQS95K2tDZE1IQlR4MENlVmp2cXE5Q3VrVDdhWVlNQmhocWQy?=
 =?utf-8?B?L0oybGdzWllEOEVlUmFVekpVY1BERzNRMXV4d0pIUjlSQytsOFdLbEFTWUZZ?=
 =?utf-8?B?MWU0SzFUeFZOYjlxTVhqRlNiUDFsdlZmeVZ2Y0dXeUdxMDlZTERicFBPZXlU?=
 =?utf-8?B?ZEdvSXZpek9VNlRXRzBMYXZyVDM4R0dCVnNNVVBhOGNLUGhrT29kUGVPNmNN?=
 =?utf-8?B?QmN3d0RWenFsM2pNM3pNMGRLcXZjSnUySEZhZFU4MDZFTVR6QTB0R0RJRi9q?=
 =?utf-8?B?NWFNaGtDN1NId1kvZ3VvS1hRb0d4SlpLT1dGYnFmR3NuS0w2VnhTbEd3Z3k3?=
 =?utf-8?B?eEZOTEVMd1VTQzYwOFMrdUdHU0ZRRjdTR0wvdDU1cDRESnRVUGRDa09xSFJt?=
 =?utf-8?B?QWIyc0hHYWtIb2tnRnBoYUFhbzV5QTdEeUEzUCtHQXhQRHAxSlhaK29IdldB?=
 =?utf-8?B?RnA5cUlYcXh0cURsNVM2czhkQUE4eStiOWNqaFk0R2VCZUtnbmVvNy9Pcnhp?=
 =?utf-8?B?L01rYlVzSkx5YUhmZDJ1L1hOWVhrSVI5dWpmVWNieks4Zkc0N2orai8wQXJ1?=
 =?utf-8?B?TDA4UWtYS29aRHZXSS9hOFZ1T3VsbVl4RjE4TUxTUVZIK1R4RFFqek15M3Nh?=
 =?utf-8?B?a3lTT0EzZWxNQ3lKUE1BdFFTMzV5bUhERm43blYwb0ZqNmk3OE9WaEc4NnhZ?=
 =?utf-8?B?Y3AxMzRiRExtTG1TVGxrMTBxc3V6NStrajJWUVAyR25kSDdSZTlsN3dlNUNj?=
 =?utf-8?B?MmpnUW5yYTFyeDA3ZFFpdm16bmt3QWo2L2E3MXMvcDN4ZjZJTDBsUUV0ZG9h?=
 =?utf-8?B?Z3FaaURCdWFhZ1BXWFg3N0tMWTNLQStjR2JyeTBUdnFDZmlBZ25zZGxMdlBR?=
 =?utf-8?B?LzJiUGIxNEdJb0l2ZEhTTUN5OXd2S01wbFpBZnVjK2pRYUpxZVQ1SW1HMTM0?=
 =?utf-8?B?cjRBZjk5MUpvSU9zOTNKTWtyZXNkdEROZ05qcnB4YlFLazBoQzdPWXVGNDYw?=
 =?utf-8?B?WWM5Y3EvdHpBVGNpTGhxTXlTdHdySjFvcVlUQVdza2x4K1hZNFV5SGhqb1hD?=
 =?utf-8?B?bWJLRGFFTWREdElPRlZBcjNHOTZXVmJPZ0JqSFFHSWZoc2tKdjJFckRyWGRh?=
 =?utf-8?B?RUw4bE0yeUZNam1CRmkvZlFoeElVbXpDRlF1UkFjWGJ5UC9PVU1sR09Hc2R6?=
 =?utf-8?B?YU8wYTVLNkVoZTZuUk1zZXMvMjdpeUkzSjIyc2NHM3R5QlhaZlM2RG95SktM?=
 =?utf-8?B?SWxLWjlZelpOTXJRYnZUVFBJa2dRczNYNStodUZpN21lWjZGYTBjcE9Ha25x?=
 =?utf-8?B?SEFsS29MVWJ5a2x2bEk0OEZDTnNRKzcxYllJRUtPREZWRUhQeGFsMTRCU2NS?=
 =?utf-8?B?eitjZERvN21zWk5UWFBaS2ZiNmxtc2lOV2Qvcm9RdDFCQkRvcndQTjg0MzQ2?=
 =?utf-8?B?L3Q3Y1J5S0FmWHppaFA1ZFByRElRUDg3bUN4LzIrMlZrUE0zK0dYRUFhRXZJ?=
 =?utf-8?B?Mnl6dW1XbWVTOW9VbkUvRlg3OGszOWpreWdNQSt6V2MweW9mWVAzWnRrZWl6?=
 =?utf-8?B?SHQzbVNmK1BwY295Ynl1dTdJQ2p5b3AzSjlGVDU3azhmMDFUU1lRUndyWVlq?=
 =?utf-8?B?NDlnKy9LSVloYzExZHRSNUo0bmMxRDNjZ3h2d2VtVXl0R2cwTkJmODhmcjlF?=
 =?utf-8?B?akh6K3duZnJ1MS9XVWhibnp6RGt4L1dXbUZmL0dNWUlOdm9ITDYrbDQ1S21Z?=
 =?utf-8?B?SFc3OSttVmpGM0gzQTYveEVJMmRnRXd0Ukdqc0ViMWZ5U3JIOUNXSVJHNHhy?=
 =?utf-8?B?THhCdlk2dVBINEFYTnpMVEh6SHpsQ1lzaVpCZlY3TGRDUzZkeDM2M3QxMENi?=
 =?utf-8?B?ZTBOeG9CY2NNWnlDVmJKd0RtMEJEd3c3TExBOHp3SXpYSlVnVXE1TnFhVFU3?=
 =?utf-8?B?SkdVS0llSGlOUUkrL0ZXTk1ZbzJZSVZadzh5WmtIVHRBZG82TXlVYWRpMlRS?=
 =?utf-8?B?VWV1VkVRV1hIQzJWTDRNSUZ0SG43Z0M4SklMb0dVRlFQZ0ZEWnN1UmRDOGpF?=
 =?utf-8?B?SS9BeFBIVTBySXNKeW1tVkFwYXJGeFVoUmpQM0JWMDYvMjR6N3piSXdDa05O?=
 =?utf-8?B?TTFhVWh5bmpCWjRYZVB1SVVKTjBmbm4vTy9KdVgvZTVFMFl3b2wzcXFUSmF4?=
 =?utf-8?Q?FOb/B+J792W0LG8dpbjlNFg=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 073fae14-9581-46fa-7657-08d9ebd17985
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2022 13:38:37.0523
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 29piD8hByLglMdERFWVyhJn3Jwq6I7INUVLJMEfI2BUmDdqv0Rdnf31iCC9J7Vm77H2WUrwwAh6GEMVcyUgqnw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7202

On 09.02.2022 14:09, Tu Dinh Ngoc wrote:
> --- a/xen/arch/x86/boot/reloc.c
> +++ b/xen/arch/x86/boot/reloc.c
> @@ -156,6 +156,8 @@ static multiboot_info_t *mbi2_reloc(u32 mbi_in)
>      multiboot_info_t *mbi_out;
>      u32 ptr;
>      unsigned int i, mod_idx = 0;
> +    u64 fbaddr;
> +    u8 fbtype;

Style: Despite adjacent pre-existing code doing so, new code should
not be using u<N> anymore, but use uint<N>_t instead.

> @@ -254,6 +256,26 @@ static multiboot_info_t *mbi2_reloc(u32 mbi_in)
>              ++mod_idx;
>              break;
>  
> +        case MULTIBOOT2_TAG_TYPE_FRAMEBUFFER:
> +            fbaddr = get_mb2_data(tag, framebuffer, framebuffer_addr);
> +            fbtype = get_mb2_data(tag, framebuffer, framebuffer_type);
> +            if (fbaddr == 0 || fbtype != MULTIBOOT2_FRAMEBUFFER_TYPE_RGB)

Style: Blanks needed immediately inside the parentheses.

> +                break;
> +            mbi_out->flags |= MBI_FB;
> +            mbi_out->fb.addr = fbaddr;
> +            mbi_out->fb.pitch = get_mb2_data(tag, framebuffer, framebuffer_pitch);
> +            mbi_out->fb.width = get_mb2_data(tag, framebuffer, framebuffer_width);
> +            mbi_out->fb.height = get_mb2_data(tag, framebuffer, framebuffer_height);
> +            mbi_out->fb.bpp = get_mb2_data(tag, framebuffer, framebuffer_bpp);
> +            mbi_out->fb.type = fbtype;
> +            mbi_out->fb.red_pos = get_mb2_data(tag, framebuffer, framebuffer_red_field_position);
> +            mbi_out->fb.red_size = get_mb2_data(tag, framebuffer, framebuffer_red_mask_size);
> +            mbi_out->fb.green_pos = get_mb2_data(tag, framebuffer, framebuffer_green_field_position);
> +            mbi_out->fb.green_size = get_mb2_data(tag, framebuffer, framebuffer_green_mask_size);
> +            mbi_out->fb.blue_pos = get_mb2_data(tag, framebuffer, framebuffer_blue_field_position);
> +            mbi_out->fb.blue_size = get_mb2_data(tag, framebuffer, framebuffer_blue_mask_size);
> +            break;

Some of these lines are overly long. Much like you don't have
frambuffer_ prefixes on multiboot_info_t field names, you could
omit them on multiboot2_tag_framebuffer_t, which would reduce line
length some already. You're likely still not going to get around
wrapping some of the lines.

> --- a/xen/include/xen/multiboot.h
> +++ b/xen/include/xen/multiboot.h
> @@ -42,6 +42,7 @@
>  #define MBI_BIOSCONFIG (_AC(1,u) << 8)
>  #define MBI_LOADERNAME (_AC(1,u) << 9)
>  #define MBI_APM        (_AC(1,u) << 10)
> +#define MBI_FB         (_AC(1,u) << 11)

>From what I can see in grub's multiboot.h bit 11 is VBE_INFO, while
bit 12 is FRAMEBUFFER_INFO.

> @@ -101,6 +102,22 @@ typedef struct {
>  
>      /* Valid if flags sets MBI_APM */
>      u32 apm_table;
> +
> +    /* Valid if flags sets MBI_FB */
> +    struct {
> +        u64 addr;
> +        u32 pitch;
> +        u32 width;
> +        u32 height;
> +        u8 bpp;
> +        u8 type;
> +        u8 red_pos;
> +        u8 red_size;
> +        u8 green_pos;
> +        u8 green_size;
> +        u8 blue_pos;
> +        u8 blue_size;
> +    } fb;
>  } multiboot_info_t;

What you add is not MB1-compatible (VBE fields come first). Furthermore
the addition means mbi_reloc() will suddenly copy more data, which I
don't think can be assumed to be fully compatible.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Feb 09 13:48:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 09 Feb 2022 13:48:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269176.463182 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHnK7-00026J-Rr; Wed, 09 Feb 2022 13:47:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269176.463182; Wed, 09 Feb 2022 13:47:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHnK7-00026C-Ow; Wed, 09 Feb 2022 13:47:55 +0000
Received: by outflank-mailman (input) for mailman id 269176;
 Wed, 09 Feb 2022 13:47:54 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=lRsY=SY=epam.com=prvs=4039ed7fca=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nHnK6-000266-EK
 for xen-devel@lists.xenproject.org; Wed, 09 Feb 2022 13:47:54 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id dfa0e4c9-89ae-11ec-8f75-fffcc8bd4f1a;
 Wed, 09 Feb 2022 14:47:52 +0100 (CET)
Received: from pps.filterd (m0174679.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 219D5oFc023106;
 Wed, 9 Feb 2022 13:47:50 GMT
Received: from eur04-vi1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2055.outbound.protection.outlook.com [104.47.14.55])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e4e6s06a6-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 09 Feb 2022 13:47:50 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM0PR03MB4180.eurprd03.prod.outlook.com (2603:10a6:208:cc::32)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Wed, 9 Feb
 2022 13:47:45 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77%3]) with mapi id 15.20.4951.019; Wed, 9 Feb 2022
 13:47:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dfa0e4c9-89ae-11ec-8f75-fffcc8bd4f1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=hqSKa9QTQm9xOEL7YyOhXX8pDPAF3PL7msdaUlxev9XzY/AoMi9DojhqdhdACx66FkgOcSTajos6+cvYYPVahu6bviMHi0XaLv83eCvCQ5r2Sp9BUTXAU/o1zbBgqRUOAc2Ix4HSa0ZySTQtgdBrflLYEKf75T17uQxPJJUiD/a1QI3qdTsuzfX3mRY2HwSPEEcOtEUlGbzxiuZjz7fB2tgddhSBvjczUdHc+HucnO2XQKhQhlLz/gv/LFcjmOKl5zzc3PbuM75bsOxxkrqoz2+VqDZ7ie9ZpNYAokcDznYKfoj4q5yczBWkGKurOyKsV243EHV2ZgFayiZZlNBBbA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=vjtRBZchUgkI311NrWgALTqmBaiGDVLnajzaK/LJct4=;
 b=GoSD/OkR5mpB/wAGGx9FRhp1rS1lezk2Nu1F/6WG5HHVZ43mP2+j9sXI/ty+JoCLTy40rrn1NqACNmS6AWqtZDbcPNwXIn9sDSkz+W/lkFf7o1nwjXXKBOwplDupBGywmMG+aIsJa4GUuzQQnq1tcb2QjmDtkWHW/OFwXbRH1A6CFi56zgh4lvaru5lGGZK2RhtaALVbgZ+YW1fcMVo9Mzxjx3ZRPwbqmeAEP5xU2zryDWtMRCYjAL8DtBdmFkfA8N6Fikj/v486ZqAEdwTc3q3w0rnta1tVIf70sRT5X8ZAny4bb3e3hPWzGaKAiXz3GFZBGMjASNAynueN19hs5g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=vjtRBZchUgkI311NrWgALTqmBaiGDVLnajzaK/LJct4=;
 b=qLJfb1s5hRSzyIfVZv5rFF4rD7O2qBaBft91EKJINd09/WdToR2udORP+z/nzObphs3FPrpYr/le8OIOlJzq0cIlQOFjgYYyxcgqLQr+wVTIR/css+zS1Eb74Jmsn51C0+K5YSWAIdFRRGT5suiK0u3TmTtefJvilSIy1p0xA3W2HDeLv3npDmOU1DVMzMxb8kwWLtYV21xXuffA2RyDv5LWJjvCldREU0gKA4OdB3Z4J+HX2+z1xhsrifm9m/6JnoxNxqyBX2seHjhXIk2v5L5rWCDsxKgrj6vFJ89NmsJuSQAKgZqPL1TFhNZAisJKimqam+itCfjwVxC/hMJ/Zg==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>,
        "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Juergen Gross <jgross@suse.com>, Wei Liu <wl@xen.org>
Subject: Re: [RFC v2 2/8] libs: libxenhypfs - handle blob properties
Thread-Topic: [RFC v2 2/8] libs: libxenhypfs - handle blob properties
Thread-Index: AQHYHbudSLxWMD9F30i+VGpqKP0vfg==
Date: Wed, 9 Feb 2022 13:47:44 +0000
Message-ID: <0b3068fd-d06f-1135-7b84-5400cca0d3de@epam.com>
References: <cover.1644341635.git.oleksii_moisieiev@epam.com>
 <069eb801bc999ea85c529fa5033121e96b9df06f.1644341635.git.oleksii_moisieiev@epam.com>
In-Reply-To: 
 <069eb801bc999ea85c529fa5033121e96b9df06f.1644341635.git.oleksii_moisieiev@epam.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: b508dd58-bf6a-41e9-b3f7-08d9ebd2c034
x-ms-traffictypediagnostic: AM0PR03MB4180:EE_
x-microsoft-antispam-prvs: 
 <AM0PR03MB418070FEC105FBE9CB00E490E72E9@AM0PR03MB4180.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:7691;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 lNMY+RFkW/HnqFM4pwSoxMZojao6bVyjSdyEu4PbIcYI++3EYGaRq4+IlFg+dwPGIrTR+0x4o2iVat7SNR+6lPlsYvz0VujrX9qjOj4nBVJl8wyFfJzBNOZdzUYi5Rf8x5S0cL9/fgjDbPrrFurwXv7Gubt0xa7swE2uVrbjbsRf6qJL/NM9C4b2GLOfr1Zrc15VEaEZBCurBHuYI5PAQbK9N/Eo0Cdg9IeCRK73bNFzkncL2C5bWkwPrGezBa/n3xDaVNsaGBMTEENk/aHxewSAftLnfYMutQx6kPQYXX6QO7t3o5lsHW6Ppk7/TtBmE7vG7JsRmsKDctGzb98v3tNEabA/7pMgjKumH4ZK3mCmwLqyG/ioNJTS8jeyTW3pgTjQePFfjzMG+KMWBjtdhIARqaACsUUGpJbujSbbm6ovAoRAxtjhArSXMynXTl/prJjzeDqBFDxB/3rtRv949xMpWEj9DRmlmULsVCSZa+dn+cfmjIzNygd7VoRy76tzdeyTgxNVSQ9xueV1gbFDyTNn6URvSR4aFQ0OfPMehTq0RLnvTpHDMFa85bwDVygc4shcvpJH6DsSUzOg5gK3NdmUPumTaMF+qNpB8QfsQKwoejxmv4/GXsebp32N1sEC0qO/fITEATNRDgAQJUixvjTqH1voZ2E1pdoSLUGGQMGOU9FnY67usV5L/1kc77iPjv2U9zYpuMyI+LKIn5jeyy9w0JkFAFeciqykEM2tzpKeyJLEiapI8fEwJMPvieMb
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(5660300002)(64756008)(66446008)(66476007)(66556008)(66946007)(186003)(26005)(4326008)(86362001)(122000001)(31696002)(8676002)(76116006)(83380400001)(2906002)(4744005)(38100700002)(55236004)(71200400001)(6512007)(316002)(6506007)(53546011)(38070700005)(8936002)(36756003)(2616005)(110136005)(54906003)(6486002)(31686004)(508600001)(91956017)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?WFJwc1RiQlFiQy9wNjlqeE9sdHdObTRqT2RPUkZSbFluV0hMVER3c3JIMmFV?=
 =?utf-8?B?dkhzZFAwYVJMVUw5Nk1BZ3dKeFNEcDZ6eEFLbzRoQXBmZE5jaG5JZVI5TDdn?=
 =?utf-8?B?NXRTSkU5ZXN0Z3RLdTdWQTZtUVN1dmVTTEVIQkRkdWM0TTJHWlF6dFVuOHBz?=
 =?utf-8?B?WHNuMEJsdW1vYkNjTFNhcEtVRGh2TG01VGNNdWNUMHN2K0FNT2gxL0ZTeGtk?=
 =?utf-8?B?RTdGaVFsNzluNE1WajM5ZU4yemhZbTFmV1hrRjdKTUVBQ0NmUUh4Ty9qL25F?=
 =?utf-8?B?R2RnNytNUlNOd25uTzJXeXNPRjlBV3UyN1V6RGwxdDc3b0JMaFh5QjhoT2xz?=
 =?utf-8?B?Vm5neFVPSGxRNkp0OG5lZmo3SnFGSHFod3hYaWpOdG1ibkpHcWpQalVlYWIy?=
 =?utf-8?B?VG5oTWhKVkNvVzRaQm1XdDBFcysyMjBhbURhTGw2Y1VOcE1RS1AwdlNNYm1P?=
 =?utf-8?B?WDA0OU5CRCswMWRPeDZBYjZxeXV3RXQycjltUURxRE9MTDVtSkZMR3pFa0kv?=
 =?utf-8?B?MG5hY0F2VWtwbmR2K0wyQUFMc2ljblh5bzRlbnQ4dHlxQ3dvTW94WGVldGxX?=
 =?utf-8?B?NmZzdzZmM2NwNlZ5SzgwQjJKVTk5UzZEV0NNdmQ3c1BYVmhKZitLYndBYWJF?=
 =?utf-8?B?bU5PbWFWZS8rUCs4dHltcTRLbHV3dFE1elVsQ1g3Z0JTODNtSU9qSWg1Y29l?=
 =?utf-8?B?OWQxYTI0bTJUTUg5a3R1WGM1ZkduenlnTDlKWU5sUEF1MnlRV0R2emoyZnB5?=
 =?utf-8?B?UndGTE00RWVMeDQvNHMzYzQwdnpZTWowRGVXTTNueHM0Ykwzem8rM3RoQS9r?=
 =?utf-8?B?MW1kd2R1cHd1WGMxWG1lU3Eva01WeUlCdDZ1M1ZiVzhkdXkxNlhPU0NiVW9n?=
 =?utf-8?B?Y0p1WWF1MmtjZVMxdnFZZ1JzWnRjaVJvUUhHcTkxdXVyc2FWalFLSUhQck9r?=
 =?utf-8?B?Y0NyZjJzZXJMemljUTdWcDhRdjhYTmtZcnZNTE04a1dyaVhhd3RqNWl0K1hp?=
 =?utf-8?B?U2YxN3pCeE95cG9IZDl1UGhKQ1BlRDdsZldaWWxjR3laWld4MzBua0RxdDJS?=
 =?utf-8?B?RjlmRXBZbE1HWTJjaVpFNFZQU1VySGpWMFBIRGJUQnBPd2hydytqbmhZMU9k?=
 =?utf-8?B?eEJ6ZS9leUp1Vzl4Vk12eXQ1ZFc3QmhCbTAxa2Vyemh3L2tUc1dRYy9NbWVs?=
 =?utf-8?B?dnpMdVBKTnlmNm83ZFRualB0K0pqZWc4Njg1ZlBmTGZWN3d6OHVXL0tCZkV1?=
 =?utf-8?B?U2M0ckRvYm1XRVVHREg3ZzBjUkRxM3R3L0poUmxtQTZQZFVpRkpFVnFYSWRU?=
 =?utf-8?B?ZmkyVFFOUFMxbHEzMEdudzlSTXB6MUt5YjFXaDJDUnJvMzZkdm5kanIzakhN?=
 =?utf-8?B?R3dXWm0xRW5HbHZpWS9pOEQwTVpCaTFUdG5qT0I5eXRVWlVEWWN4TFdwQlhM?=
 =?utf-8?B?S25OWE9ZL2ZDWnAydm1rVlUzNCtQblIwK09oRmRMY1NNSnJhdEgyY29DZHk5?=
 =?utf-8?B?M3YvZldpN0RKenJhWG1FMSt6MTF1YXdSR2lmWGg2UTRxb3dZSk04eCtkb0JP?=
 =?utf-8?B?N3Jnb1Z0TFF4K3lQRzgzR2QrZk1tdzRrdFpmODgwcDhiREZNaTBLeElXRTMz?=
 =?utf-8?B?K3VIVlV1em9OeUJsdXB5RlFnbjU1WHRUYXEzelJXTWltRzhvWlNHblJucG81?=
 =?utf-8?B?ZjRhSnBFRFpMZ29FamRJbytuOVI3V3lpTUVWYys2YXZGREY1T3g4T2s4aTVm?=
 =?utf-8?B?bjB5bnJHdjV2blhaK1lrd2tkNGF0ZTB4QWhYcERoaEtXK3hsV0w3Znlmck03?=
 =?utf-8?B?OUcrS0J4ZHVkWG8rRUk2cVhOd0duMGU2YXdUdmxkVTM4R2dzNnV0YUhOUjA3?=
 =?utf-8?B?Z3hpWEVPNUZ4NTBOazJEWHJsY1J2UXQ4Q0pjRDk3UCs2U1g3TVhlZEZNL2VX?=
 =?utf-8?B?Uk40dUhXSXN1SUxlN05tZDZoOE5lQ2pTWUtnYVgvOUYvSVNodW9DSmREVEFa?=
 =?utf-8?B?UndyQ2RkSDhGOStEVU00bGxDTnlsd1FRWGRIUU9SUWUzb3VyanNUdmlRUXUw?=
 =?utf-8?B?Q09DaXYyQ09hVlovaTBRUTNNVkorQkJ6cG9vc0ZNeUVjVGpSQzlGWkV0SHJk?=
 =?utf-8?B?WWpOcjJlRGZxSWVkU3V2a3VBNDRRRGljbG9LaWE5aUJaTVBJSzJXNTYzTGth?=
 =?utf-8?B?Rms0TGpQNjVWa083L3V5MDdRUGZqSkZlVkhLNTlpT1J6VUREZW5OdDNkelJv?=
 =?utf-8?B?RTYwdzZhSy9EREFNYnNRWkZsa1pUdXFZVFk5bmVQZ2dlYStMZTQ4eklySWti?=
 =?utf-8?B?Mlo1T0ZtdEorTmVGaUZMNEVYZ0FuWnEydFVPRlZNMUtrbENkc2xXdz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <2EB3528D62BB2C479C05F926E8321D52@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b508dd58-bf6a-41e9-b3f7-08d9ebd2c034
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Feb 2022 13:47:44.8725
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 1bj4j8+YF7F+2kpbgSquKPve4Euwd8IUtiR4MJe7yuSG6Fxu/6eGZXASkjRwT00Rw8ZztdpEitaoZACtIBgVasXCccLryubCHDjT7z0qWQvs+5+7BT1iYMyj1/tU57z6
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB4180
X-Proofpoint-GUID: zv1CSuP3Z5eOtezvio1fy1DOCTeieTED
X-Proofpoint-ORIG-GUID: zv1CSuP3Z5eOtezvio1fy1DOCTeieTED
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-09_07,2022-02-09_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0
 phishscore=0 priorityscore=1501 malwarescore=0 suspectscore=0 mlxscore=0
 spamscore=0 clxscore=1011 mlxlogscore=974 lowpriorityscore=0
 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202090079

SGksIE9sZWtzaWkhDQoNCk9uIDA4LjAyLjIyIDIwOjAwLCBPbGVrc2lpIE1vaXNpZWlldiB3cm90
ZToNCj4gbGlieGVuaHlwZnMgd2lsbCByZXR1cm4gYmxvYiBwcm9wZXJ0aWVzIGFzIGlzLiBUaGlz
IG91dHB1dCBjYW4gYmUgdXNlZA0KPiB0byByZXRyaWV2ZSBpbmZvcm1hdGlvbiBmcm9tIHRoZSBo
eXBmcy4gQ2FsbGVyIGlzIHJlc3BvbnNpYmxlIGZvcg0KPiBwYXJzaW5nIHByb3BlcnR5IHZhbHVl
Lg0KPg0KPiBTaWduZWQtb2ZmLWJ5OiBPbGVrc2lpIE1vaXNpZWlldiA8b2xla3NpaV9tb2lzaWVp
ZXZAZXBhbS5jb20+DQo+IC0tLQ0KPiAgIHRvb2xzL2xpYnMvaHlwZnMvY29yZS5jIHwgMiAtLQ0K
PiAgIDEgZmlsZSBjaGFuZ2VkLCAyIGRlbGV0aW9ucygtKQ0KPg0KPiBkaWZmIC0tZ2l0IGEvdG9v
bHMvbGlicy9oeXBmcy9jb3JlLmMgYi90b29scy9saWJzL2h5cGZzL2NvcmUuYw0KPiBpbmRleCA1
MmIzMGRiOGQ3Li5kMDliYmE3ZDhjIDEwMDY0NA0KPiAtLS0gYS90b29scy9saWJzL2h5cGZzL2Nv
cmUuYw0KPiArKysgYi90b29scy9saWJzL2h5cGZzL2NvcmUuYw0KPiBAQCAtMzA3LDggKzMwNyw2
IEBAIGNoYXIgKnhlbmh5cGZzX3JlYWQoeGVuaHlwZnNfaGFuZGxlICpmc2hkbCwgY29uc3QgY2hh
ciAqcGF0aCkNCj4gICAgICAgICAgIGVycm5vID0gRUlTRElSOw0KPiAgICAgICAgICAgYnJlYWs7
DQo+ICAgICAgIGNhc2UgeGVuaHlwZnNfdHlwZV9ibG9iOg0KPiAtICAgICAgICBlcnJubyA9IEVE
T007DQo+IC0gICAgICAgIGJyZWFrOw0KVGhpcyB3aWxsIG5lZWQgYSAvKiBmYWxsdGhyb3VnaCAq
LyBJIGd1ZXNzDQo+ICAgICAgIGNhc2UgeGVuaHlwZnNfdHlwZV9zdHJpbmc6DQo+ICAgICAgICAg
ICByZXRfYnVmID0gYnVmOw0KPiAgICAgICAgICAgYnVmID0gTlVMTDsNClRoYW5rIHlvdSwNCk9s
ZWtzYW5kcg==


From xen-devel-bounces@lists.xenproject.org Wed Feb 09 13:48:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 09 Feb 2022 13:48:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269181.463194 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHnKb-0002cG-4K; Wed, 09 Feb 2022 13:48:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269181.463194; Wed, 09 Feb 2022 13:48:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHnKb-0002c9-1A; Wed, 09 Feb 2022 13:48:25 +0000
Received: by outflank-mailman (input) for mailman id 269181;
 Wed, 09 Feb 2022 13:48:23 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=LzQm=SY=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nHnKZ-0002U6-Eg
 for xen-devel@lists.xenproject.org; Wed, 09 Feb 2022 13:48:23 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f11bcfa2-89ae-11ec-8eb8-a37418f5ba1a;
 Wed, 09 Feb 2022 14:48:22 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f11bcfa2-89ae-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644414501;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:content-transfer-encoding:in-reply-to;
  bh=VXe4FgHjvT2H2NZbLzYU2jjX6cUZ6npniyOwTN0LRSM=;
  b=OwBLQlCHnv6YzijFZI+Hxk3IyuUFMwuBijZeOjgepFbas6CSINfh2Wri
   GaxrWt7ysGP+A7VQxVfzqfldGYGe0Tml7vTfAoDp3Dpa6I9JSGUd5Zxh+
   gLJrgQwxUbBdDBEFyVGxGPXb5WbV/64rm5ruGOa1oAl+BA54ks6tDD40a
   k=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: 0A+Yp/EI8uBoiohQfBm7wDMOKI+3DuCQfl/w1uj32dptmN+gWWMrpVNKkF5hElkLxNVyDhnFgp
 kxSosmP8JFiNL0h0Tg/5kpqJPpUdHeIaxppGICqHacHad1kFqIyMc5QWuW7ovwYQJ1BUpPzQRT
 MTbeTtvXAAsYYnwsjS8jWu9PJoymFymerXOiMhF25TWRbvCooA9sn8Pn47mNh6JUUBQGPIiHiU
 VigF4YJusWwr5BtMfRYSAs1FpObOYNtUkF4dfdxO1WD2g61K8+qsHhTKymKUTTnfgZH8f0eS7R
 vyeQZYovY5Y9vxdKcum7NOey
X-SBRS: 5.1
X-MesageID: 63828537
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:+pTSpq02e1nPlpvxHvbD5bh3kn2cJEfYwER7XKvMYLTBsI5bp2ZTy
 TMfCjvTM/7famb2Koglbdm2oEIGsZWEnNI1TlQ4pC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkS5PE3oHJ9RGQ74nRLlbHILOCanAZqTNMEn9700o5w79h2+aEvPDia++zk
 YKqyyHgEAfNNw5cagr4PIra9XuDFNyr0N8plgRWicJj5TcypFFMZH4rHomjLmOQf2VhNrXSq
 9Avbl2O1jixEx8FUrtJm1tgG6EAaua60QOm0hK6V0U+6/TrS+NbPqsTbZIhhUlrZzqhrtZIz
 dVpuYSMGTwlHYrrssBGTiF2HHQrVUFG0OevzXmXtMWSywvNcmf2wuUoB0YzVWEa0r8pWycUr
 6VecW1TKEDY7w616OvTpu1Ej8I/LM7tLcUHt2tp1z3xBvc6W5HTBa7N4Le02R9u3ZAUTauFO
 KL1bxJ/XjvOW0VsCG0uDcsFvteP3SX2UxpX/Qf9Sa0fvDGIkV0ZPKLWGOTSftuGVMBEhHGyr
 2jN/3n6KhwCPdnZwj2Amlq3nfPGly7/XIMUFZW7++RsjVnVwXYcYDUcWEGnu/C/hgi7UshGN
 k0P0iM0qO4580nDZtrwQRy+5mKFtxg0WtxMHul84waIooLW/gDfAGEHRzxAbdUOtckqSDhs3
 ViM9/v2ARR/vbvTTmiSnp+EoDX3NSULIGsqYS4fURBD89TluJs0jB/EUpBkCqHdpt/6Azbr2
 BiRsTMzwb4UiKYj1bi//F3BqyKhoN7OVAFdzgfdU3+h7wh5TJW4fIHu4l/ehcusN67AEAPH5
 iJd3ZHDsqZeVvlhiRBhXs08Gois59KJKAGMulJMOL4L02+ww1CsKNU4DC5FGG9lNcMNeDnMa
 UDVuB9M6JI7AEZGfZObcKrqVZ10kPGI+cDNE6mNM4EQOsQZmBqvoXk2DXN8yVwBh6TFfUsXH
 Z6AOfihAn8BYUiM5GrnHrxNuVPHK81X+I8yeXwZ50n+uVZ9TCTMIVvgDLdoRrpkhE9jiF+Km
 +uzz+PQl31ivBTWO0E7C7I7I1EQNmQcDpvrscFRfePrClM4RD16V6KNkOpxItENc0FpegHgp
 CzVtqhwkgWXuJE6AV/SNiALhE3HAf6TUk7XzQRzZA31ihDPkK6k7bsFdotfQFXU3LcL8BKAd
 NFcI5/oKq0WElzvom1BBbGg/N0KXEn63mqmYnv6CBBhJMQIb1KSpbfZkv7HqXBm4tyf7pBl/
 dVNF2rzHPI+euiVJJyON6v0kgjh5CN1dSAbdxKgH+S/sX7EqOBCQxEdRNdtSy3VARmclDacy
 SiMBhIU+bvEr4MvqYGbjqGYtYa5VeB5GxMCTWXc6L+3Mwjc/3aintAcALrZI2iFWTOm4rima
 MVU0+r4bK8NkmFVvtcuCL1s168/uYfi/ucI0gR+EXzXRF23Ebc8cGKe1MxCu/QVlL9UsAe7Q
 GyV/dxeNenbMc/pCgdJdgEkcv6CxbcfnTyLtaY5J0Dz5SlW+rubUBoNY0nQ2XIFdLYsadEr2
 +YsvsIS+jeTsBtyP4bUlD1Q+kSNMmcED/ctuKYFDdK5kQEs0FxDP8DRU3ek/JGVZtxQGUA2O
 TvI1rHajrFRy0eeIXo+EX/BgbhUiZgU4U0YyVYDIxKCm8bfh+9x1xpUqGxlQgNQxxRB8uRyJ
 mk0aBElefTQp29l1JpZQmShOwBdHxnIqEX+xmwAmHDdU0T1BHfGK3cwOLrV8U0Um46GkuO3I
 F1MJL7ZbAvX
IronPort-HdrOrdr: A9a23:bir5UKHMTh6RukS3pLqE7seALOsnbusQ8zAXP0AYc3Jom+ij5q
 STdZMgpHjJYVcqKRQdcL+7VZVoLUmxyXcx2/h2AV7AZniFhILLFuFfBOLZqlWKcREWtNQttp
 uIG5IOceEYZmIasS+V2maFL+o=
X-IronPort-AV: E=Sophos;i="5.88,355,1635220800"; 
   d="scan'208";a="63828537"
Date: Wed, 9 Feb 2022 13:48:15 +0000
From: Anthony PERARD <anthony.perard@citrix.com>
To: Jane Malalane <Jane.Malalane@citrix.com>
CC: Roger Pau Monne <roger.pau@citrix.com>, Xen-devel
	<xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>, Juergen Gross
	<jgross@suse.com>, Andrew Cooper <Andrew.Cooper3@citrix.com>, George Dunlap
	<George.Dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, Julien Grall
	<julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, "Volodymyr
 Babchuk" <Volodymyr_Babchuk@epam.com>, Bertrand Marquis
	<bertrand.marquis@arm.com>, Jun Nakajima <jun.nakajima@intel.com>, Kevin Tian
	<kevin.tian@intel.com>
Subject: Re: [PATCH v2 1/2] xen+tools: Report Interrupt Controller
 Virtualization capabilities on x86
Message-ID: <YgPGHyVdSWrPwcWD@perard.uk.xensource.com>
References: <20220207182101.31941-1-jane.malalane@citrix.com>
 <20220207182101.31941-2-jane.malalane@citrix.com>
 <YgKLpCnhjP18c7oo@Air-de-Roger>
 <2567d4cd-b27b-df0b-d449-c486ab13c672@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <2567d4cd-b27b-df0b-d449-c486ab13c672@citrix.com>

On Wed, Feb 09, 2022 at 12:26:05PM +0000, Jane Malalane wrote:
> On 08/02/2022 15:26, Roger Pau Monn� wrote:
> > On Mon, Feb 07, 2022 at 06:21:00PM +0000, Jane Malalane wrote:
> >> diff --git a/tools/golang/xenlight/types.gen.go b/tools/golang/xenlight/types.gen.go
> >> index b1e84d5258..5f384b767c 100644
> >> --- a/tools/golang/xenlight/types.gen.go
> >> +++ b/tools/golang/xenlight/types.gen.go
> >> @@ -389,6 +389,10 @@ RunHotplugScripts Defbool
> >>   DriverDomain Defbool
> >>   Passthrough Passthrough
> >>   XendSuspendEvtchnCompat Defbool
> >> +ArchX86 struct {
> >> +AssistedXapic Defbool
> >> +AssistedX2Apic Defbool
> > 
> > Don't you need some indentation here?
> I hadn't realized it appeared like this here (and the same happens for 
> other parts of my code as I'm seeing now) because the git output is 
> correct. I will fix it.
> > 
> > Also name would better be Assistedx{2}APIC IMO if possible. Having a
> > capital 'X' and lowercase 'apic' looks really strange.
> Okay.


This is a generated file, you can't change indentation or fields names.
It would be rebuilt automatically if you had golang installed and where
rebuilding all the tools.

There's two ways to generate it, you could install golang and build all
the tools. Or without golang: just
`cd tools/golang/xenlight; make types.gen.go`. Both should regenerate
both "helpers.gen.go" "types.gen.go" files.

There's an even easier way, tell the committer to regen the files when
committing :-).

Cheers,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Wed Feb 09 13:59:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 09 Feb 2022 13:59:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269192.463204 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHnV2-0004AR-66; Wed, 09 Feb 2022 13:59:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269192.463204; Wed, 09 Feb 2022 13:59:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHnV2-0004AK-37; Wed, 09 Feb 2022 13:59:12 +0000
Received: by outflank-mailman (input) for mailman id 269192;
 Wed, 09 Feb 2022 13:59:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=XFrC=SY=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nHnV0-0004AE-6X
 for xen-devel@lists.xenproject.org; Wed, 09 Feb 2022 13:59:10 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7396e073-89b0-11ec-8f75-fffcc8bd4f1a;
 Wed, 09 Feb 2022 14:59:09 +0100 (CET)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2051.outbound.protection.outlook.com [104.47.13.51]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-3-TQrOqEf8OtqYhzgNPzM8xA-1; Wed, 09 Feb 2022 14:59:07 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM0PR04MB5267.eurprd04.prod.outlook.com (2603:10a6:208:d0::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Wed, 9 Feb
 2022 13:59:06 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.018; Wed, 9 Feb 2022
 13:59:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7396e073-89b0-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644415148;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=9qB6/WtUFvr+uLx+DyCj+rZCpVGdD22v4qDzNr7lmQA=;
	b=ZmrEt4WAfA0L63USHsO5L/dyDNDPAkNxcjgpOb5qR/gAd9LKg1BXOo878BfVGU0HFa+YE5
	0fwygliLi+71eWg9H5XXLuzNKLwbcpWdhpAOPSoObpXgZlU+1zROchW0+bToIHw5a1I5my
	tpzjLTZ7WPlMRzf5GCxWaTcwf4pM10A=
X-MC-Unique: TQrOqEf8OtqYhzgNPzM8xA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=hrSw0WADfu7316Xr4EESHLgU4gPOorocAoEz44aAoWlztrROU24Rz8SAo16uMDlUrZ35TUxE7Esb0zpqWCusCfIYyD7GewdpzGTMLAwAZBNuTFe6B2uq7cwbubRw73/bZCSjw+yRgzkPcWZ5+m/yBwmaX8IO0kijJBu7qg7oJ9jiE4Q+mwsIXZx6lMlAHVQ47lF9X1O6SoR1Sj8cXlwZWbwZb8c+eKvimiQZUsCDjRujbaIrLrleJAt4KAM7J3OpvYHSIIgG6/IjpJZX0otnClTJ0h2PZF7f3rWf5n5uEwa+bXy6fRkB0Q12Ge33tPmanbHzMMZzdvG42AQiHMx+jw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=9qB6/WtUFvr+uLx+DyCj+rZCpVGdD22v4qDzNr7lmQA=;
 b=IV9K9usU7YM0vbB0nNa11g6SnW8brtWHXnb2nGb8s51sqr1v/br+0eskUO+v8xq97U+NTvxMQB96pIAXP2eSEhmpoby/aWfStlUmpolYxFGiiT12BsLer6dQTf7UU0Q2KcRIixbr8ZmJnUB32KVwhBMduYwPbN0+ZTjkOq0bR1mWt/Rj+vPkcC+1wELe53T8bj6KHl0dwGuv3Zo4uKlg1BItkoAvw9QoJyHwknq5mWgaD8v4Z0thpfI7AgYFkznpjI06d4zW4mtjdGJFtUSC8AaOJlbnuqgDQ2DaXvkUBHShxaqv2bVIRiHWlSVqiSoCIaMW1rxumYUJ+wnActq4xw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <d299da87-7abd-6899-27dc-4cae4634d227@suse.com>
Date: Wed, 9 Feb 2022 14:59:04 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH 2/2] x86: Set up framebuffer given by Multiboot2
Content-Language: en-US
To: Tu Dinh Ngoc <dinhngoc.tu@irit.fr>
References: <20220209130907.252-1-dinhngoc.tu@irit.fr>
 <20220209130907.252-3-dinhngoc.tu@irit.fr>
Cc: xen-devel@lists.xenproject.org
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220209130907.252-3-dinhngoc.tu@irit.fr>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0036.eurprd06.prod.outlook.com
 (2603:10a6:20b:463::17) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4cc131d3-5373-45ec-51cc-08d9ebd45623
X-MS-TrafficTypeDiagnostic: AM0PR04MB5267:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB52679008AE5EA679159730A3B32E9@AM0PR04MB5267.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	QX1aAbQeTPdyQXopKWr9YvSlBVQ537iY+cLqGkI4DdXRv1Ih8YzWJELJWyO7AyHY2nTBHeRxGDDw86Rn3h0wypAc/J4XgNrLWDUCqlcPFSDNeZk3fQ0ztf6pi62Gohh2RE5LArDj1js3YDPpj4RprpRMN6WIIDRzViJ9gc7G8re2/AlQkVd9jU27Z6saq+1M13ogSDdAMbn9QZMB08iXCNaTOIYWtKOHJRtSqJx2TZ+i1A8U8XC/yM8cTmD4m1Gs6zHL0gX2zop1vFpiojBcdXGth/45lJT1BNm079d/mLS0CPbuFzkk5YuJmTDaXsDTLy/dB/wui/YvAHG3wbDP1bOb2AcrHwtpRUdwLJipYxBWVM5B59JGfj3k8pAv30h15zG/jgmtI9wKijL8cA+UD70h7/WxgIWQJff0DVr09Ee/64l/5IwC8g8N8u2s7ePYR8TLZTct7z6Eid7LVar7wFOnclqBaJ3pUbXzqc2zTjKHLSe6cCtpvkr3MoA98WUYvQmYA7sTP2b5e53PWSU8TnjbVcHuoKoZl030Nmwxhf4X0eW0/Rxi86JSzDsvMSFej4PYfNtAjnDoYHnpMEqUuLlZg47T/s8YllzKPzHcMq0Z9yiya8AUxOdlsP33OUDucbtnlSI/E+L033216fAdKXlimR/kBjUm+piVKKQTFJWMBX351xKzOL6TXbK10psFzFDWyTMU14HcDuhbDalGckAPXwmJ8PBSDaIR6HhxQOU=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66556008)(86362001)(316002)(31696002)(6916009)(6512007)(6486002)(508600001)(53546011)(2616005)(6506007)(4326008)(66946007)(2906002)(66476007)(8936002)(8676002)(36756003)(31686004)(83380400001)(186003)(5660300002)(26005)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bkR3andiZnRqQkdXUlVqU25TZDZscEFRNFgzVDF1YzdzVjlHT2tVUWhreHB0?=
 =?utf-8?B?RDdaVmNFa0c5VlBtMjB4YkFqazJFcFBFODcxY2JyRmR4Si9GWTNHOVBWNldv?=
 =?utf-8?B?ZlFhL01ha1VPUGovQm5jZEt5QTVSUFpDR29hMGV3Yjdnd05DR1VpVUgyREt5?=
 =?utf-8?B?Mm5CL1gwNWx0U2dPTVU4MDUvcWxrYTJxbjdHSTR2OFQ1SGJBNkovbC9Eclgz?=
 =?utf-8?B?OXZRQnlEa1c1bko0bkZEYnJVUDhiQnJaeVh3bG5GY1NFNFU4NGY5eGJtK3ND?=
 =?utf-8?B?aGlvUGZpVDNJamlxd2dJeWpyWVJRZWhuZHk1bzJrTDJTQnhoODFIa3Yxa25k?=
 =?utf-8?B?Y0tmTGZQSW1pRzc4Nm9kWGovazdvNTFUQzRuTmVLczZsT043czlkSEtQUlBK?=
 =?utf-8?B?WmpJTkZqemE2SCt5L2MwOU9IT3ZZRU83djg2OHNSQjdXdGMvUDF5RHJSZVlK?=
 =?utf-8?B?NUZrQk9jazlZeGpTTGFMUVBPcTBuMWlZUFBON3psWWdvTlBWNmlVelEyV0Za?=
 =?utf-8?B?YlFKU0FnWlU4Rm9WbDAwUHl1RlhNOUpTNnJHZ0Vza0t4RnlXaFE1STRTbWp6?=
 =?utf-8?B?bS9NeHhiZE55M2EzR0xtVnphTXBNTlRlQTlvUi9jcEw4MUtjMXJCSWs3dllJ?=
 =?utf-8?B?QkdXSTFMVkFvM3drY3hXbkhkRFNFZGZOVnE4ZTlNaDVhRDVabzYvM0tzVk5Y?=
 =?utf-8?B?ZHN5OGVJTjZRYllIQjZNQWpwRDBnUzdPQUhpZTVZRnJCbXRsem91THl1Vnls?=
 =?utf-8?B?Y2d6emZxYUVLeVV4UnRxbC9MTWJESHFETXBCQ3NXWXlScUlPWnlzdHNoWHgy?=
 =?utf-8?B?NlVHd1I3SzdHN252QUVOTlc2bFE2NG5SZnhFOE9nSWplTi84MVFvNjFYQWR5?=
 =?utf-8?B?ZWZDbTR3SjlzV2wvMit0TU9YalFBcm5xa3dTelFETnk2YkwvTExxOWdOT1Qv?=
 =?utf-8?B?bFVxUjk2WGtsSzNMUms0WCtsMXdLaGJPNWljRGVaM3Y4ZndnUVY5SU8weWla?=
 =?utf-8?B?amNEMnJzYXZPSVpqTFFHSElXWS8wQ0FDbGYzVXZLWHJ0czFqNUt0eWltd2l3?=
 =?utf-8?B?RTBpYm94TkZnQUQwVTkzZWJQd3l4MGtmZmxLb1hvN3lrZE5aazF4V0dVUnZC?=
 =?utf-8?B?UG9xUHR6QUxFb2hjc0JUN0NUQk10MnU0d2c2dElCMlVPSlJwRytzUEt0Nnlh?=
 =?utf-8?B?c2Q3WTV4R2M0T3ZyWGhWTnRCWHdtc3dHVVczbkVVZElRNnRVUVJ3V0E5OHJY?=
 =?utf-8?B?dkF5ZnBScU83MnV3S3crWVE0RldWTmIzNFpsZDl2UXRhSStRdkZPUjN2WUJG?=
 =?utf-8?B?WHQ2R25rQkMvVHgxbitnQ2l3Q2RIYVdQaVRHRDNTUU9pM2cwNWE4ZjBGVG5T?=
 =?utf-8?B?Rzd5TTY5bG81ajVPWWxtbk53R0RtNHVLQ055OFJCU2h4OXEvK1pydzB1RGdO?=
 =?utf-8?B?SVhNQ1dTZ3BCdlhSVE9zUytlenRpekJJMU1JOTI1c2VENURaY3BTYjhlbFRS?=
 =?utf-8?B?QjhaamxBNm9qNkhxQy9ZdFBxZEtXR2hCR3Budi91NER1SzFOSVRKUUtPbXM5?=
 =?utf-8?B?QW1NZlhoVFM3aC9ISlBPQmRmNXY4aGJUZHd3VWM3enNUQndNaGlyN0ROR243?=
 =?utf-8?B?dW4reHE2QWpZRW1Oek5OOC9WWUs3ZGpkYkZNK1FkdlFSUnR3TWZqL3hZYWhL?=
 =?utf-8?B?YzlBR2R6b2NjWmlEUXdndkxjbmY0RVIrb00xOWs1blpLS1k0YmYwL04wOEwz?=
 =?utf-8?B?NGxpNmJuQ01CS21xWk5LQUxjRnJDbzFPeFd6SklYVmtiUHBuUTVTRjdLZDJC?=
 =?utf-8?B?R3IwQjNLZ1VQNVFQbXdERDdIbkF5M1dUMGZ5NzNjQ2FEZFhwUWI5TlRwZXA4?=
 =?utf-8?B?cUp6ZHFIRmpUbzZ0TjkrM2ptKy9WYzk2a3JFZTFYUUM2cGY4QnJrQzF6dHZx?=
 =?utf-8?B?VkxTZ0pXYU9Ra000ZExxYnArdHJRY0hyVWFqeDJWZHlHaUVkU25sczYzcjdS?=
 =?utf-8?B?Y0svd1pOZkoxNmRRMjRBdHptT0lFWTU2M3c2UnhOaHErM1g3TlMyWEZSZTJP?=
 =?utf-8?B?aGdTSTlubmV4ZWFqazIxaUMvYWRHQ3VaajRyL2Uzdm16cCtyTTgrZCs1MEpq?=
 =?utf-8?B?MzFZa0FYUnNYQlZ1QVVkSi9WTmhJU1FzTWU2RFhwTm9LK1JGU0JFTCtWMnhK?=
 =?utf-8?Q?amdqZRtgQPizb98WZplojkY=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4cc131d3-5373-45ec-51cc-08d9ebd45623
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2022 13:59:06.1947
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kHA1nH+PQIhI3Tz+DK0U/YhDOdNmiIvAENhLE5PYRrFlgMR+WGlo8yhMC9klFTbvE9hyIXDfXFiRKhxySPqo7g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5267

On 09.02.2022 14:09, Tu Dinh Ngoc wrote:
> --- a/xen/arch/x86/setup.c
> +++ b/xen/arch/x86/setup.c
> @@ -551,16 +551,55 @@ struct boot_video_info {
>  extern struct boot_video_info boot_vid_info;
>  #endif
>  
> -static void __init parse_video_info(void)
> +static void __init parse_video_info(multiboot_info_t *mbi)

The parameter can be pointer-to-const afaict.

>  {
>  #ifdef CONFIG_VIDEO
>      struct boot_video_info *bvi = &bootsym(boot_vid_info);
>  
> +    /*
> +     * fb detection will be in this order:
> +     *  - efifb (as efifb probe sets a new GOP mode before parse_video_info is called,
> +     *    we must use this mode instead of the one given by mbifb)
> +     *  - mbifb
> +     *  - vesafb
> +     */

This ordering needs justification, first and foremost because this way
you risk regressions when VESAFB data is also available. There would be
no such risk if you made mbifb lowest priority.

Style: Comments should start with an upper case letter. There are very
few exceptions to this (e.g. when a comment starts with an
identifier referring elsewhere), but here there's no problem with
starting the comment "FB detection ...".

>      /* vga_console_info is filled directly on EFI platform. */
>      if ( efi_enabled(EFI_BOOT) )
>          return;
>  
> -    if ( (bvi->orig_video_isVGA == 1) && (bvi->orig_video_mode == 3) )
> +    if ( mbi->flags & MBI_FB )

Even with MBI_FB's value corrected in patch 1 - what about the flag
being set from an MB1 bootloader? I'd be hesitant to trust that the
data is dependable upon everywhere.

> +    {
> +        uint64_t lfb_rgb_bitmap = 0;

I don't think you really need this initializer.

> +        vga_console_info.video_type = XEN_VGATYPE_VESA_LFB;
> +        vga_console_info.u.vesa_lfb.width = mbi->fb.width;
> +        vga_console_info.u.vesa_lfb.height = mbi->fb.height;
> +        vga_console_info.u.vesa_lfb.bytes_per_line = mbi->fb.pitch;
> +        vga_console_info.u.vesa_lfb.bits_per_pixel = mbi->fb.bpp;
> +        vga_console_info.u.vesa_lfb.lfb_base = mbi->fb.addr;
> +        vga_console_info.u.vesa_lfb.lfb_size = (mbi->fb.pitch * mbi->fb.height + 0xffff) >> 16;
> +
> +        vga_console_info.u.vesa_lfb.red_pos = mbi->fb.red_pos;
> +        vga_console_info.u.vesa_lfb.red_size = mbi->fb.red_size;
> +        lfb_rgb_bitmap |= (((uint64_t)1 << mbi->fb.red_size) - 1) << mbi->fb.red_pos;

1ull is both shorter and avoids using a cast.

> +        vga_console_info.u.vesa_lfb.green_pos = mbi->fb.green_pos;
> +        vga_console_info.u.vesa_lfb.green_size = mbi->fb.green_size;
> +        lfb_rgb_bitmap |= (((uint64_t)1 << mbi->fb.green_size) - 1) << mbi->fb.green_pos;
> +        vga_console_info.u.vesa_lfb.blue_pos = mbi->fb.blue_pos;
> +        vga_console_info.u.vesa_lfb.blue_size = mbi->fb.blue_size;
> +        lfb_rgb_bitmap |= (((uint64_t)1 << mbi->fb.blue_size) - 1) << mbi->fb.blue_pos;
> +
> +        /* assume non-weird bit format */
> +        vga_console_info.u.vesa_lfb.rsvd_pos = find_first_zero_bit(&lfb_rgb_bitmap, sizeof(lfb_rgb_bitmap) * __CHAR_BIT__);
> +        vga_console_info.u.vesa_lfb.rsvd_size = mbi->fb.bpp - mbi->fb.red_size - mbi->fb.green_size - mbi->fb.blue_size;

The comment really is about this 2nd assignment afaict, so it would better
move down. I'm not convinced "assume" is enough, though. I think the data
should simply not be used if the color placement doesn't match our
expectations.

Also these are overly long lines again.

Finally if lfb_rgb_bitmap was "unsigned long" (and hence still at least
64 bits, as we're on a 64-bit architecture) you could use the simpler
(because not requiring the address to be taken)
find_first_set_bit(~lfb_rgb_bitmap), provided of course lfb_rgb_bitmap
doesn't have all bits set.

> +        if (vga_console_info.u.vesa_lfb.rsvd_pos >= mbi->fb.bpp || vga_console_info.u.vesa_lfb.rsvd_size < 0) {

Style: Missing blanks, line length, and brace placement.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Feb 09 14:01:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 09 Feb 2022 14:01:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269201.463215 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHnX2-0005dD-OM; Wed, 09 Feb 2022 14:01:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269201.463215; Wed, 09 Feb 2022 14:01:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHnX2-0005d6-L0; Wed, 09 Feb 2022 14:01:16 +0000
Received: by outflank-mailman (input) for mailman id 269201;
 Wed, 09 Feb 2022 14:01:15 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=XFrC=SY=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nHnX1-0005d0-Oj
 for xen-devel@lists.xenproject.org; Wed, 09 Feb 2022 14:01:15 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id be6c84db-89b0-11ec-8eb8-a37418f5ba1a;
 Wed, 09 Feb 2022 15:01:14 +0100 (CET)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2050.outbound.protection.outlook.com [104.47.13.50]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-2-SdOogXoENNWW2jztnP04HQ-1; Wed, 09 Feb 2022 15:01:13 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM0PR04MB5267.eurprd04.prod.outlook.com (2603:10a6:208:d0::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Wed, 9 Feb
 2022 14:01:11 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.018; Wed, 9 Feb 2022
 14:01:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: be6c84db-89b0-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644415274;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=a5amoCfjhU59nhUznhyRPozLp59hxbfkFQLxJuIYR8Q=;
	b=DJ9zVl/KfFg3SCxP9sdstJgSP6NKmW8CW98wd8VT8x1ArBwN/9wmmI2powGHxztrZHHWus
	59O0hzu2XO8tRlCJ3ypjZwHA8AODuhgAm1wNSOpwC2/Amroe1EuFKoBUS2SZXhl3fL9BYn
	0oUe3rrf2jURi3yXNpzzikdkaasOU6g=
X-MC-Unique: SdOogXoENNWW2jztnP04HQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=SCFSVGMnSqScD08/HkdoSI1QYEScnliFD05fGJCkX20NGvH2Es/Qva4YEKeFmAwmllt1Ew8p9twNytI3s3b3YyaruwBCqRsMj9Lv84YxoyqtR7rmLZQ4EJyFMS78jgZ1ydPY13cIHu6iyj7h1P5BgK4rMh6sMp6nxSyhd5zXA1aZeWMQtapiqN2KT35LF7rXcupYQlt42S5QVE5jLqjALMpdRxD/+AwIER1S514kdiqV8k1XTL/GEkcQGncj6ou++CGPepPFINhbPkriUn6EYHSJZMyJWof3fMs3z5uLc5e9UBJ0N9e5xpttyAAdwHqCFfElxMr6Iy+HqKob2ThAGw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=a5amoCfjhU59nhUznhyRPozLp59hxbfkFQLxJuIYR8Q=;
 b=XykOymlZ9sYw7DNxM7a0uN3wjuA8dMb7hDfFcRpEuTun6dxCDljFJEVlx82KDzd0wLLM4pz95cqxCFRdF3LKUM0ZL7eUNy299A/1c1FkMxu51cdBEA+bBxQTWGKobd0j9RaCKe/FgJMGMqxCDMrYDtJtg4P6LRwLPijI+RoeFtuq9gK2Sdjw8tH08onoO7jPUbW5AwbPtACozToExVGsbKAcFkgIafkgg1srofGU45G7KChhDkxeGqsR+PdavGznu5jHDy+LWU67Re4wQrzL1UrspScLoESLFHaozDZjX/KeeTo+Fh0nBIMC6T871W8T/cKGKs7Lr5zUhxkM+lFgVA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <9319cca0-d437-fe55-9b13-967bcd3ef4ac@suse.com>
Date: Wed, 9 Feb 2022 15:01:09 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [RFC v2 2/8] libs: libxenhypfs - handle blob properties
Content-Language: en-US
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Cc: Juergen Gross <jgross@suse.com>, Wei Liu <wl@xen.org>,
 Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <cover.1644341635.git.oleksii_moisieiev@epam.com>
 <069eb801bc999ea85c529fa5033121e96b9df06f.1644341635.git.oleksii_moisieiev@epam.com>
 <0b3068fd-d06f-1135-7b84-5400cca0d3de@epam.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <0b3068fd-d06f-1135-7b84-5400cca0d3de@epam.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR0301CA0021.eurprd03.prod.outlook.com
 (2603:10a6:20b:468::11) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: cfbdf4da-d9f3-4a7d-c7e0-08d9ebd4a08b
X-MS-TrafficTypeDiagnostic: AM0PR04MB5267:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB5267FA83453797EF1B197A56B32E9@AM0PR04MB5267.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6430;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	hxvuDtaIh2cUHuAYkf8BYkG7CPS6B7QWByeArIXfR3BuF+hrzJF+mjXbkQTAi9cjz09achHpUKhMgtuLf3jFi2buQXOypEuX5XRF8wwMiErejgQOuim4YYJaUdPAeaou2pKFCHEnwwbivJcQohoQabLLwHBtEicF5ItwcOj94F2xb9SbqJux/G+VZNVg7vlwVUvCWLvYQFDDicdspnZ9mNwaoxlIHSTCbJRqKp3e8of0z/wd231f/3DHep0sfhFSehfGbe32kcZLxjv/NsTSsecjAt7GRnWo4hR2J/pFLKnLNR+zIcAg+i3sp118jxcImi6UXC2q69TRRwzjlGkh/j9lE7x1rN6eWALie4D+t0xjoJovTGfiet5Wvh8J0IghQn5M/8xvv+aemWZsHh4TjEcD8h1jO78Q1+5wLRXnCqlQ0rk+45DJWGdRyrqq+syz1HF0mZcMYdXqSHsSBYMNGfy2tY9ZEzDl6Z7t78Fmc+etXIOfNSZqxCW/5Q5ibUq4c1AOI0qlu/m9bm7RqCBLRdnSffg3ZSijkLIDjl25Zxl3VPuEKsC60uaBkcToQ3foRLVUY2iAVBTDfxc+cLxZtfO1fZPZVX1QHzPRi0fOPabX339HKI3iVOM4v23EGMEmfeemmuqqRFp1+jmtCD9jXD5LCZmSx/SFwc+K25Gu2eJYtUtNetwr9juky3JOdVHkrP0dDlzrCnFZiJ9YfDRpGJVQ2mXoiRWPqAjhISpEnYkk4f+vcixKEhNUFZ4/ulyp
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(54906003)(66556008)(86362001)(316002)(31696002)(6916009)(6512007)(6486002)(508600001)(53546011)(2616005)(6506007)(4326008)(66946007)(2906002)(66476007)(8936002)(8676002)(36756003)(31686004)(83380400001)(186003)(5660300002)(26005)(4744005)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?MElCNHF3UVF0dXZaQ203SDBETEZGek1PajBncFh6V2M2THp4ZFBKT0E3NmxZ?=
 =?utf-8?B?WkRaOTIzMFVvUXBZWWdXMEN0WXR4a3A4Z1QrMSsxT3RrRnVvbjdvdVBzTG54?=
 =?utf-8?B?MTVtZzZ6Y3c3Qi9HTFY0cjEzTjRIS0hRdm5kM1o1OVhrbXZ6T1M0cHdJTnk1?=
 =?utf-8?B?N2N6NC9YV1NSbXdva0k4T2M5OXVVakVQcFR3N2V0YTlLVjhidlFhOVpYWUkz?=
 =?utf-8?B?UjQ3M3A4V1A3ZG5JeDVzOVNTVHdURnBxaVQ4L3NWallQMC9QL251NHFDLzMx?=
 =?utf-8?B?YWhMRWtHcGd6L0JzV3lRTFd6UTZrUURsQmFOb2lqVllFSlNib1lraGJFWTJ0?=
 =?utf-8?B?YndFWTFvSjB5SjcrNjc3bmxBaVFYUDJOaWNCNlFSeGlQdDRrVERBZTVtRCtj?=
 =?utf-8?B?WGIrMUsxYmRGY1JnMm1WNWRMWnFqek5yNDFpb2tPMUFPaUhmNlVjTHJXS0cw?=
 =?utf-8?B?OUEralMrMW05QUFYTG5OeHgxcnFFUHJvUkZ6UFFVcHhvRlplRHNWUFFkeThF?=
 =?utf-8?B?NHJRZHo0cVFUc3pqWDdIcW04cjgvVS9NN3hsSEs1NHRNNjMrV2RXOUpRTHpu?=
 =?utf-8?B?Z1JCNklXNG80bFZsTG9ZVHZ3cTJ1SjVGck1nbVF1R0ZSQmdnd1lUTGoyN2lI?=
 =?utf-8?B?NEkrRDBVTG5rQnNDbFZyaXE2Nko0MVhhdWVCUWZWWTBIajFTd1hMMFVidk9L?=
 =?utf-8?B?RzdrSWF5MCtGVnpsZmVhUFRET1BmRzQvWnE5UHlFemNpdDZoOTBMcCsxSUM4?=
 =?utf-8?B?ZmNveURtdkplUVo3NVdOSWlBL1gxcU1zdm5jMG1PMHZodTBNNlhOSjM1N1Mr?=
 =?utf-8?B?OTgrQ1hyU2Fvc3VrUjJsRDRTSHNPOTdZUlc2WHVtR1g0WmhUMHNDUm13cExz?=
 =?utf-8?B?OUVNeTRKR09DR1BGNFQzajJNSkE0Snl6VUF6Y3ZXcWFWVDdpeXB0WEgyQ0Ri?=
 =?utf-8?B?WUI1dGNOWkFNSXdGZHRKRUt0TW9xT2wvQjV3dDd6YWR0em5EeTBlNTZrQWhG?=
 =?utf-8?B?M1o2MCtqQnQydzR0WlVncGpiV3o2a01tTTVzUVV5SmhyM0w1QzFzb2FtM0h4?=
 =?utf-8?B?TnprUnVuZlBBWEZTRXhrRWtyM1pqN3hHVjVzK2NVRlVPRjJXcjREQWtBMVVG?=
 =?utf-8?B?UFFFWitGUDE4WElBRDFzekFXQUpsak5QK1p4eE12SXg2MHNteGpNZ2VHMk1J?=
 =?utf-8?B?bS82V21pOGtZb2c0QXQ0a2lSSFR6V1doQWRNK2xxdDIrWUdsdVFkKzRPWHM1?=
 =?utf-8?B?bW44VGVJMzYzN0hMQ0F3dDJDR2I0emRvK3ZuZGNhRkxVeUo4RVJNK3FXaHBR?=
 =?utf-8?B?UkFwOXQvQVNldURObEJ5anpsU09hL2pKZFNzY2tnRmVrbW90UzBRbFhsdE1G?=
 =?utf-8?B?QVBJcEN6Y1R3Yjh4UnNtM0xMWUt0UElFSzRSREk4M0o5VzQ2a2VxVWp3NmFE?=
 =?utf-8?B?YnFCcXJqODMrZGRXc3FucnNFSjBGd3QvUmwxVm9YSjcwZjQ5OEY5aGNQUkdU?=
 =?utf-8?B?YVI0ZW1mR0k2NnRKMDQ4Wm4rNzB4UWtpdm9ramtPb3psWU1pVm43Sk9pWnhL?=
 =?utf-8?B?L2VyZUhQNWRaTm5IUFNMeWVGSHN0NEhINm8vWGJNOXdtazQrMWJMRWptbFBS?=
 =?utf-8?B?NnBlL0FJQWk0ZWwxcE9rMlFSZDhWT3pQWkFlVVJYc2JSSUhLVUxBd0pqOXll?=
 =?utf-8?B?N3pranhVZG5tWGJ0SHl5NU9nSEpVSGxmUlRKU2ZRMnFPcHVVRkdEeThnRWZy?=
 =?utf-8?B?VEFQSUpjWGRWQkROaTJzOEJDOUlWMFV2MDZGMHhpcjdKR2RXOU9QZXhIK3A3?=
 =?utf-8?B?aUJYN0l1ZUJ3UVJocER5TXBWQURQTHNxd25iZDRlV09rRGswZXF6ekRUT1N1?=
 =?utf-8?B?QzRhSmJYUElrK0laN1VaWmFrRklQTDRHSUN2RmcrRTZzWFd4aUdmbDBOY3Js?=
 =?utf-8?B?K0VIN3A0RmtXd3l6TlJhbGlYVStLd1FHbEhXa3ZndWd0M2ErbjJ4QTRrU2Rs?=
 =?utf-8?B?NU5za1Rsei80WTIyamVaeUlwU1BJZVI5L3ZRb0MwZFJkWExxcnFYa0tpdjVD?=
 =?utf-8?B?REMvOGNFZjF5aTFvWmNtbENjY0FtNmlGaVpXTHpXaURWejlPUFJZQ0FaUE1N?=
 =?utf-8?B?MGppTU9kcXA2NVhubVU5UFdaVGpIcUFHaWRXT2gwUEVnRG91TkozbkVrRHlx?=
 =?utf-8?Q?cgmgQBFkUt274sbNjLdV4O8=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cfbdf4da-d9f3-4a7d-c7e0-08d9ebd4a08b
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2022 14:01:11.1088
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VgJjLAnDRIa1xsDOzOOlx167YXUMlJtV6bqHNmF1z8wZ1cU6pF8UcH0ccpKh3HAwjFiZKofG58HnYN22PmyuQQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5267

On 09.02.2022 14:47, Oleksandr Andrushchenko wrote:
> Hi, Oleksii!
> 
> On 08.02.22 20:00, Oleksii Moisieiev wrote:
>> libxenhypfs will return blob properties as is. This output can be used
>> to retrieve information from the hypfs. Caller is responsible for
>> parsing property value.
>>
>> Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@epam.com>
>> ---
>>   tools/libs/hypfs/core.c | 2 --
>>   1 file changed, 2 deletions(-)
>>
>> diff --git a/tools/libs/hypfs/core.c b/tools/libs/hypfs/core.c
>> index 52b30db8d7..d09bba7d8c 100644
>> --- a/tools/libs/hypfs/core.c
>> +++ b/tools/libs/hypfs/core.c
>> @@ -307,8 +307,6 @@ char *xenhypfs_read(xenhypfs_handle *fshdl, const char *path)
>>           errno = EISDIR;
>>           break;
>>       case xenhypfs_type_blob:
>> -        errno = EDOM;
>> -        break;
> This will need a /* fallthrough */ I guess

Why? There's no statement left before the next case label.

Jan

>>       case xenhypfs_type_string:
>>           ret_buf = buf;
>>           buf = NULL;



From xen-devel-bounces@lists.xenproject.org Wed Feb 09 14:03:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 09 Feb 2022 14:03:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269209.463227 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHnZK-0006GX-5j; Wed, 09 Feb 2022 14:03:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269209.463227; Wed, 09 Feb 2022 14:03:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHnZK-0006GQ-2M; Wed, 09 Feb 2022 14:03:38 +0000
Received: by outflank-mailman (input) for mailman id 269209;
 Wed, 09 Feb 2022 14:03:36 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=sex7=SY=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nHnZI-0006GI-Oc
 for xen-devel@lists.xenproject.org; Wed, 09 Feb 2022 14:03:36 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 122a3e89-89b1-11ec-8f75-fffcc8bd4f1a;
 Wed, 09 Feb 2022 15:03:35 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 35C3B1F38E;
 Wed,  9 Feb 2022 14:03:35 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id F2E0813D45;
 Wed,  9 Feb 2022 14:03:34 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id Vw3rObbJA2KAWwAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 09 Feb 2022 14:03:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 122a3e89-89b1-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1644415415; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=qQeVxDW58I1Wm5a5sQ17XHIIiFpw1Le/dQzkrt7htxY=;
	b=At3eME/p67IiWkO0cFeLu28el1quzDhPwb6NwG/a0ZEv/Xm7QiAnoeZ0RMdX0GrjdicKLY
	oWvM+LgGkdMrlXBhSmuMkNh+v4bdOMzRrtM07pOoDIorSL8jb1wM/jKtN8BrveAew6gOhb
	yGR+Gn1pNDZSoa1bacLCAsc2qi7k/VU=
Message-ID: <e2963fd7-f72b-2d30-12cf-863b7360c5e5@suse.com>
Date: Wed, 9 Feb 2022 15:03:34 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Content-Language: en-US
To: Julien Grall <julien@xen.org>,
 Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <cover.1644341635.git.oleksii_moisieiev@epam.com>
 <e440e4f16a506ecc87078635dbb3fda2ebd45346.1644341635.git.oleksii_moisieiev@epam.com>
 <b88f6a50-6e9e-5679-8d25-89e26031e88e@xen.org>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [RFC v2 3/8] xen/arm: Export host device-tree to hypfs
In-Reply-To: <b88f6a50-6e9e-5679-8d25-89e26031e88e@xen.org>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------6ED4muG9qsy8Q4jg7GNzLCEU"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------6ED4muG9qsy8Q4jg7GNzLCEU
Content-Type: multipart/mixed; boundary="------------1TeGN6qRLquh01mBhc2Qm2JU";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Julien Grall <julien@xen.org>,
 Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
Message-ID: <e2963fd7-f72b-2d30-12cf-863b7360c5e5@suse.com>
Subject: Re: [RFC v2 3/8] xen/arm: Export host device-tree to hypfs
References: <cover.1644341635.git.oleksii_moisieiev@epam.com>
 <e440e4f16a506ecc87078635dbb3fda2ebd45346.1644341635.git.oleksii_moisieiev@epam.com>
 <b88f6a50-6e9e-5679-8d25-89e26031e88e@xen.org>
In-Reply-To: <b88f6a50-6e9e-5679-8d25-89e26031e88e@xen.org>

--------------1TeGN6qRLquh01mBhc2Qm2JU
Content-Type: multipart/mixed; boundary="------------L6xQ8qcnbg8OAMFmXm0n1YTi"

--------------L6xQ8qcnbg8OAMFmXm0n1YTi
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMDguMDIuMjIgMTk6MjYsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gSGkgT2xla3NpaSwN
Cj4gDQo+IE9uIDA4LzAyLzIwMjIgMTg6MDAsIE9sZWtzaWkgTW9pc2llaWV2IHdyb3RlOg0K
Pj4gSWYgZW5hYmxlZCwgaG9zdCBkZXZpY2UtdHJlZSB3aWxsIGJlIGV4cG9ydGVkIHRvIGh5
cGZzIGFuZCBjYW4gYmUNCj4+IGFjY2Vzc2VkIHRocm91Z2ggL2RldmljZXRyZWUgcGF0aC4N
Cj4+IEV4cG9ydGVkIGRldmljZS10cmVlIGhhcyB0aGUgc2FtZSBmb3JtYXQsIGFzIHRoZSBk
ZXZpY2UtdHJlZQ0KPj4gZXhwb3J0ZWQgdG8gdGhlIHN5c2ZzIGJ5IHRoZSBMaW51eCBrZXJu
ZWwuDQo+PiBUaGlzIGlzIHVzZWZ1bCB3aGVuIFhFTiB0b29sc3RhY2sgbmVlZHMgYW4gYWNj
ZXNzIHRvIHRoZSBob3N0IA0KPj4gZGV2aWNlLXRyZWUuDQo+Pg0KPj4gU2lnbmVkLW9mZi1i
eTogT2xla3NpaSBNb2lzaWVpZXYgPG9sZWtzaWlfbW9pc2llaWV2QGVwYW0uY29tPg0KPj4g
LS0tDQo+PiDCoCB4ZW4vYXJjaC9hcm0vS2NvbmZpZ8KgwqDCoMKgwqDCoMKgwqDCoMKgIHzC
oMKgIDggKw0KPj4gwqAgeGVuL2FyY2gvYXJtL01ha2VmaWxlwqDCoMKgwqDCoMKgwqDCoMKg
IHzCoMKgIDEgKw0KPj4gwqAgeGVuL2FyY2gvYXJtL2hvc3RfZHRiX2V4cG9ydC5jIHwgMzA3
ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKw0KDQpUaGUgcmVsYXRlZCBkb2Mg
Y2hhbmdlcyBpbiBkb2NzL21pc2MvaHlwZnMtcGF0aHMucGFuZG9jIGFyZSBtaXNzaW5nLg0K
DQpXaXRob3V0IHRob3NlIGl0cyByYXRoZXIgaGFyZCB0byB2ZXJpZnkgdGhlIGNvZGUgaXMg
Y29ycmVjdC4NCg0KDQpKdWVyZ2VuDQo=
--------------L6xQ8qcnbg8OAMFmXm0n1YTi
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------L6xQ8qcnbg8OAMFmXm0n1YTi--

--------------1TeGN6qRLquh01mBhc2Qm2JU--

--------------6ED4muG9qsy8Q4jg7GNzLCEU
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmIDybYFAwAAAAAACgkQsN6d1ii/Ey/s
AAf+KBzThgoTOSs8tNeh9F/pmQQeHUccTgsle3S+BwwU/BRhpbC07osxvH16dMGBYWI+RofScGNM
mmBps/dIgOTEze+psKOy0ZzkV04iPr91Q8+2vNx/SVVPaeBo1Euspu49ZxFCak60pd/V2F072T1N
17vruOAv2PJJOTfu8E0pU0kqwfCNG/DoDHA4Jl1hStVewa8A+mL9WwzgxgWZNjBjToNMvp4Hlyzk
AShvDCZLvpzmLVRfAHQjqpS1iMH2WT7uQNcuTE2vMmTiwVp9px083NMdgHihj/enTQlD22yKL3Ov
S/KIobfK9xoL3gXfVK0aMLB6xrdYJUazkslMgHUogA==
=bdTB
-----END PGP SIGNATURE-----

--------------6ED4muG9qsy8Q4jg7GNzLCEU--


From xen-devel-bounces@lists.xenproject.org Wed Feb 09 14:04:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 09 Feb 2022 14:04:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269216.463238 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHna7-0006oc-Ep; Wed, 09 Feb 2022 14:04:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269216.463238; Wed, 09 Feb 2022 14:04:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHna7-0006oV-BS; Wed, 09 Feb 2022 14:04:27 +0000
Received: by outflank-mailman (input) for mailman id 269216;
 Wed, 09 Feb 2022 14:04:26 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=sex7=SY=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nHna6-0006bN-6Y
 for xen-devel@lists.xenproject.org; Wed, 09 Feb 2022 14:04:26 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 3043c36a-89b1-11ec-8eb8-a37418f5ba1a;
 Wed, 09 Feb 2022 15:04:25 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 49597210F8;
 Wed,  9 Feb 2022 14:04:25 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1E51E13D45;
 Wed,  9 Feb 2022 14:04:25 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id IaZZBenJA2L8WwAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 09 Feb 2022 14:04:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3043c36a-89b1-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1644415465; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=j1bKE5dMkAJMBwnrWS3L5NoHlJMXSAuoiOf9LQQXicA=;
	b=EydqzokNzevOVkl/1kf+RvZUJhY3PvtT/hh89bedEbRep+ZfdxvUMjjCCqce0DziS4qyOX
	trnlg6Ix1tZZuL0mijd8akBcPd51Neur70iRT8HSkl5CLifycz+6l1qxy59XWR1KE3Zmrc
	wWlNnXIgEIhPImohm7p8Ru4qkbB1Dy8=
Message-ID: <676bf729-897f-4bba-a339-4981149d32f1@suse.com>
Date: Wed, 9 Feb 2022 15:04:24 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Subject: Re: [RFC v2 2/8] libs: libxenhypfs - handle blob properties
Content-Language: en-US
To: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Wei Liu <wl@xen.org>
References: <cover.1644341635.git.oleksii_moisieiev@epam.com>
 <069eb801bc999ea85c529fa5033121e96b9df06f.1644341635.git.oleksii_moisieiev@epam.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <069eb801bc999ea85c529fa5033121e96b9df06f.1644341635.git.oleksii_moisieiev@epam.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------JT3PkbcluT08qvNSXm0sUr2Q"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------JT3PkbcluT08qvNSXm0sUr2Q
Content-Type: multipart/mixed; boundary="------------rPxkqgwVVE25pb3siSSUq0pP";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Wei Liu <wl@xen.org>
Message-ID: <676bf729-897f-4bba-a339-4981149d32f1@suse.com>
Subject: Re: [RFC v2 2/8] libs: libxenhypfs - handle blob properties
References: <cover.1644341635.git.oleksii_moisieiev@epam.com>
 <069eb801bc999ea85c529fa5033121e96b9df06f.1644341635.git.oleksii_moisieiev@epam.com>
In-Reply-To: <069eb801bc999ea85c529fa5033121e96b9df06f.1644341635.git.oleksii_moisieiev@epam.com>

--------------rPxkqgwVVE25pb3siSSUq0pP
Content-Type: multipart/mixed; boundary="------------bzaSrICMokbEUZkCM8XKk3Cm"

--------------bzaSrICMokbEUZkCM8XKk3Cm
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMDguMDIuMjIgMTk6MDAsIE9sZWtzaWkgTW9pc2llaWV2IHdyb3RlOg0KPiBsaWJ4ZW5o
eXBmcyB3aWxsIHJldHVybiBibG9iIHByb3BlcnRpZXMgYXMgaXMuIFRoaXMgb3V0cHV0IGNh
biBiZSB1c2VkDQo+IHRvIHJldHJpZXZlIGluZm9ybWF0aW9uIGZyb20gdGhlIGh5cGZzLiBD
YWxsZXIgaXMgcmVzcG9uc2libGUgZm9yDQo+IHBhcnNpbmcgcHJvcGVydHkgdmFsdWUuDQo+
IA0KPiBTaWduZWQtb2ZmLWJ5OiBPbGVrc2lpIE1vaXNpZWlldiA8b2xla3NpaV9tb2lzaWVp
ZXZAZXBhbS5jb20+DQoNClJldmlld2VkLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3Vz
ZS5jb20+DQoNCg0KSnVlcmdlbg0K
--------------bzaSrICMokbEUZkCM8XKk3Cm
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------bzaSrICMokbEUZkCM8XKk3Cm--

--------------rPxkqgwVVE25pb3siSSUq0pP--

--------------JT3PkbcluT08qvNSXm0sUr2Q
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmIDyegFAwAAAAAACgkQsN6d1ii/Ey9x
fgf+IITqSowb+5YzF9DA3f5Tv5hZ1kbFHLVcF/6BzzI7z/QvMbhEnu5zsgZe4BoQrv5QacfJdMzB
U9jo4VHNV19nX8XCosx4J3CTXJFVnEFJkPknK54eAcPzJyY5X+C1Npa+rvBM2aVT73WU0YH9wXus
DmCrSyG3EZsbT4Z/VzudSMQCY9Bb21gDonMT9HlYLll+sJE+AYT+A1zTnP5yNuo/iHS5HUHNnRfr
3DJr0QE3iLqwQz9BLZhE+OMdLpeweB5ItFL5JjTOGMwpPigd1/mvAchKpsYFGlflirfjTeBKdFgy
9kO6Vi2boOtkIO9Eo1mtIELP3GKCA40U3px2FvHqwA==
=UM5v
-----END PGP SIGNATURE-----

--------------JT3PkbcluT08qvNSXm0sUr2Q--


From xen-devel-bounces@lists.xenproject.org Wed Feb 09 14:04:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 09 Feb 2022 14:04:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269217.463249 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHnaE-00078F-Pk; Wed, 09 Feb 2022 14:04:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269217.463249; Wed, 09 Feb 2022 14:04:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHnaE-000788-MW; Wed, 09 Feb 2022 14:04:34 +0000
Received: by outflank-mailman (input) for mailman id 269217;
 Wed, 09 Feb 2022 14:04:33 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=lRsY=SY=epam.com=prvs=4039ed7fca=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nHnaD-00076u-Au
 for xen-devel@lists.xenproject.org; Wed, 09 Feb 2022 14:04:33 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3333e4e1-89b1-11ec-8f75-fffcc8bd4f1a;
 Wed, 09 Feb 2022 15:04:31 +0100 (CET)
Received: from pps.filterd (m0174682.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 219DxfKl016067;
 Wed, 9 Feb 2022 14:04:30 GMT
Received: from eur04-vi1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2056.outbound.protection.outlook.com [104.47.14.56])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3e4dtg09n4-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 09 Feb 2022 14:04:30 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by DB7PR03MB4523.eurprd03.prod.outlook.com (2603:10a6:10:19::27) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Wed, 9 Feb
 2022 14:04:25 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77%3]) with mapi id 15.20.4951.019; Wed, 9 Feb 2022
 14:04:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3333e4e1-89b1-11ec-8f75-fffcc8bd4f1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=YY8YcwTxwWOryLgY89NigYJuhWN2eUvFlozRY3ZcxiZnvoVpTy2ZAluiIXsdQBQpLiTBypvjRM6y951G9urOg0BU1UciQWZ0TZyBsjEUo+ADK1llDkI/Gy2GK/PRYePIT5SyO+5YR306Y3gmJzbdVoSrSSiZ2O/GKL1z0N1tVUEMFm5PvJUw1GZqEFtcYURmbyVxCxiXCya0hIK0v6u8EIXLgHynfieHsVwV8W3GMRlNm1co96h1pxvJdEgJ6LdFjXGMjvLVqh2ZHIkYYsUMiTST0skkEqXWYcqUhZvnGf8ZBtCsQ8zw9ZBtPwvp7x1IWHTrOA5cZ0Cej8dcwaWLbA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=fcucRsHBZMhsJaoRK7TEghykSWrfqtMf4Qvq3TJUhfk=;
 b=BKrgvD2f58z3zC0etRvui9/QtxYArIsVi/svz1JJcJO2fFQ1TlS+fFQ/g/+xHzJRuzfDpDsheZbPk71+EcKgQms+IH445AfuUifUXgVDgXShlTrAar5zLGkV2nHtUWJXVU7Q3BQ982nHuXOpupzk9aiy9Yoe8ydMS2nWLRChuLSLAQZhPaA5Ch54zKIc4FdAMzmRKIvSAyfNgSjb9ymCMTAVJzJaLavwTTx0JRN/oImIstBFHrwos857r/1C8rpLykHHhtBLmOLoQu2Y9kHQsvCcJlVPEur/aTcviLPYQaQt/dxKDsOMkNuGN4cGwlIFfz1GRHp4DEOMPssFSzLUnw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=fcucRsHBZMhsJaoRK7TEghykSWrfqtMf4Qvq3TJUhfk=;
 b=RWIuFWDTLR7xstRYgcO3HSvhhq9pgguRMDRcUfJ6Bu8D45UzHIkCknsnmFedGR2rNWheENO8XlaO0oAsHrYqqRyY0O6OwZyAnrU8lbxazFTwTGoubi0XRYTbxaiIVw8OtZGtJKzkVmSbA4AkvEK/JCkKfgmgKIBdPntZ8OOHwZmIKE44JikvJ/VDdrl7fpQtX9DskmqNpTZ11A3mXp664dkbvhpikWjf33iPsphcr1FsTtIK1BambdthY9grAlPV0gZJOzTN4NMdbsAwYufzC0HBS//J0vl/OGnLIalUepYJ1FDVVozStFQ9G4ROOgddOqePe9+48PDDw2DJm4+N/A==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Juergen Gross <jgross@suse.com>, Wei Liu <wl@xen.org>,
        Oleksii Moisieiev
	<Oleksii_Moisieiev@epam.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: Re: [RFC v2 2/8] libs: libxenhypfs - handle blob properties
Thread-Topic: [RFC v2 2/8] libs: libxenhypfs - handle blob properties
Thread-Index: AQHYHbudSLxWMD9F30i+VGpqKP0vfqyLP4KAgAAA6oA=
Date: Wed, 9 Feb 2022 14:04:25 +0000
Message-ID: <6cc391f2-44a7-76bf-83c2-152155f39880@epam.com>
References: <cover.1644341635.git.oleksii_moisieiev@epam.com>
 <069eb801bc999ea85c529fa5033121e96b9df06f.1644341635.git.oleksii_moisieiev@epam.com>
 <0b3068fd-d06f-1135-7b84-5400cca0d3de@epam.com>
 <9319cca0-d437-fe55-9b13-967bcd3ef4ac@suse.com>
In-Reply-To: <9319cca0-d437-fe55-9b13-967bcd3ef4ac@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: c609dd1c-3bfd-465a-499f-08d9ebd514d6
x-ms-traffictypediagnostic: DB7PR03MB4523:EE_
x-microsoft-antispam-prvs: 
 <DB7PR03MB45238FBBD487439C94252CF7E72E9@DB7PR03MB4523.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:6108;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 o7hdA2pS9BOVr7F8USNvOk32cP0ASyOkxxEPMVOUsb0rC7D8PtAbRwXWND0nyQ2Wq6GgqO5hueBDguNAB2VEZbKhwj3/Thz3qd1tGbNYSwqIWYDfIVa5RPUD2ese8fLAFqAG1jbra/MoIYC0TAde7xLnr3mTKUnWkC2C+AvWIRMSFXhKrWq1mh4J19DLhzx/n7Q2yTLC0MEAr7sgpC9OV0+vncMFodHHEA5/ugkBfoaG88S/VxgMmlcfLn3+bBoEItrUJDichJFEoRP6ooQAQzLfUa6Fbwe6S7BiOyW06tcicMWLiYARD8FnSMNqd5mdWM6pm4BybblXlS7VYj4POrbSKVSag3o8O9pOoiGJL1jJJdy7TrB+PmK0zUBTyScS14urQaOo9/U3p7ad5nJPLc+3Vu7P1qbGjoPkTv8ZU1UsdOPkMxz8rZ0RbY7YyroEl8HyWs2wrdFPpTBNo6ctL1JkabKJTPNxjGMwNCcfupSpe0g1FUGegSPSvipgglnEj4IHLpXqhqH+uMR8LdujBskE3XIrXRxksALzzTteAMVorvFEs52Z9IhEQekSJIMu1SeGTzD6KSJ9nOqOAqg1ZBYShC8Ld6rnEo78pony4aqBASPKa6IYe76GZN1+Zb3nE+Inaiupl0Ht3QNQhEwRh+p0p2RNW4GHdTTqfHpcfNxPlzIUF0SchBMfz+Qdi5J2/tgsVvV98SftVjqscY87fPbrI+ZUhX3Qb2qeduoV5bmYFowDGbtZzfGvXI1LzPM4
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(54906003)(66476007)(8676002)(4326008)(66556008)(64756008)(66446008)(6486002)(76116006)(91956017)(66946007)(316002)(508600001)(31696002)(6916009)(36756003)(122000001)(31686004)(86362001)(38100700002)(38070700005)(83380400001)(55236004)(6506007)(26005)(71200400001)(6512007)(2616005)(53546011)(186003)(5660300002)(8936002)(2906002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?QWlOY0NnbVJZS2IxcmFETGNtNjJFdGdBWGRYOVZkRXRrc09hTis2SmJvd1pO?=
 =?utf-8?B?WWhONWZXMmhudktrMkk3Q01kQlorckRueExxczJWVG0wM2VGbnJLaFlocWNp?=
 =?utf-8?B?RU94VmRxM2xBQUQzMWVmUnhVRXVSNG9QYkhlcmxISkxuSFRMeC9MRVhhamtC?=
 =?utf-8?B?N3NGMUc5Q1BLdU8zZDJDN2hsVmhKd3RDWVJtMkFEY1JwaFhtc0tVaFpYQVFE?=
 =?utf-8?B?SnZ6bXZjYkt0VERqVVRFMkFUUUVoRWhqbzlkMU84TEZNOFJ4YklieXl6eTJn?=
 =?utf-8?B?K3ZCT29PQkIzalBwYXl2UkFCV282cmxIellZN3NGVFgrbmwrNlF4M0hNb2tx?=
 =?utf-8?B?RCszT1U4b0toL3grQTFxOWh4Vnh3OWtIeFhrRGhtNnltMm9IUmRyR1dubHJv?=
 =?utf-8?B?R0ZjUHBoQ29CVHpNWlRmaSsySmI2andmU1N0R29LelJaNksxTnVTYTNyVytl?=
 =?utf-8?B?MHA1YzFuQ3RKY3VPbDJKNExPaWx6VmFZSXU4YU9JVkprYTR1LzQ3T3Y4QkdM?=
 =?utf-8?B?S2xDYjVoY01VMmxwZlBsRUlnQTI4ZWxNMDhoMmZmdWxhN2hIQlVvMmtRbEJa?=
 =?utf-8?B?YjNxZnhnQzM2Qzcxa2h1M2pXdENvQUFxWGx0ZE5NeUprdlJFTC9Gb0JwR0JJ?=
 =?utf-8?B?YlV5QWUxNEl0TE1XYnhtdDUzVVoxNGp3N3lZNVVMN1czZTFIOThIYW9BYUJu?=
 =?utf-8?B?bmZzQWNYRWNvZHRyQ0g3TnBxYnJSZ1orcWRQSDRCekl0NkVMT0Fuc2lOYXpM?=
 =?utf-8?B?dCtnTjJtcmVOWjB2N1NlV1ZBNkN4aWxlQXozV2diVUtYNGxhSitiRFh3bTBi?=
 =?utf-8?B?TWJ3aVdScjRDbit1SGc4TjI4TXpianMyNlFKTjVUTE5IczhVaHZ0dGJmamNB?=
 =?utf-8?B?cnFvMkNFUTNVNUYyZDFiNFZ2QUtjNUFNTjFyb2pNZmtWb0VZZ2hrNHV1SkJq?=
 =?utf-8?B?NHhDOG9xZHpIVGlsOS9vd0dqYm5OcURDc01YdzROcFN3RGNjVXQ0WUFJVlZS?=
 =?utf-8?B?WWcxTUh2SDY0SWszVS9PWDJJMm53WVpGQmJPaFZEd1g0VjBORVNhb1lZK1dO?=
 =?utf-8?B?Tk9zRk5zK2FTVE5mNGtJcThMYmRkZmhRamI2VlBMNG53cnNtR09TeXpRbnBI?=
 =?utf-8?B?dkVLSnBVNEE2VmJFSXVqTmtIV0hkYm5zSVRrWS9lZitMcTdsYUtFRExYa3pk?=
 =?utf-8?B?aCtwWUkrRU9CdFYrUzliMldpOWJSU0k1NEpuc3U0cHNNZjgyb0svQmFhMGx5?=
 =?utf-8?B?Tk5DMDlpY0lJQklsWXQ4YkRaWjRIc04zRjhoemtqeCtnbHlIMjJXV2U2UXk1?=
 =?utf-8?B?eHI4UDhnSFlPOHVNNXVzVjREWmlJR0grSUxOM3g3dGtIVGhvSUNGbUFGTXNH?=
 =?utf-8?B?em96OFpxUDdGb0hHVHlSRVpIdWlEa3JQenpDcFR1aXBXYjZqZDg5MXBsUHhw?=
 =?utf-8?B?MDEyZExlNHFnV1ZJeDhhQis5SjhEQ0FKR1NneTlBUEpmY29RRHVBeHU4WXVE?=
 =?utf-8?B?S1hKUjFHaFR4ZVk5YTV1US8xa1BDaVU3ZmdTS3lkdXNnbmF3MTg5eXZFQTZT?=
 =?utf-8?B?Njd6MDBkaldiRHpqSHpYKzJaMmRKUVBMTjVzR0RidU03TTJ5bm5ITTZhU1FC?=
 =?utf-8?B?UTlMZkZWRlpFWERLSy96Yjhic3puZXpuVFFUM0lObVh0YjVXRUJwS0VWQ0xR?=
 =?utf-8?B?ZWFQWHUzcGs0MUxLN1VybWhPUS9VeWxlejZkUEg1eTdMOW1EaEtZK05LdFRw?=
 =?utf-8?B?Mkk1UEh3b2lIOTNmejJ6UFFuSFJ3Z0tUSHAyc05RdHBTMldhODBJZGZqVWVi?=
 =?utf-8?B?T3lmR3Q3ZzVZaGhYYzV5VkZXS2ZUTnM0dGE5UTJrSEJPZEozdWtnTFVtK1RV?=
 =?utf-8?B?QlNBdjhRVStJd2pVdThIclpkNWxyeUEyQy9maHYrZ1dVT3orOWNHYXhJNTdU?=
 =?utf-8?B?YldPMWdCV0ZPRXloMmw4aU8xS05jZUVpeW41NndSaTlCdGVUQlh0RExmS0F5?=
 =?utf-8?B?TnNQaU03OW4yMVdmL3p6Q2NqbHFBbjlsS1pkSFVJZlRwYTRhRXFqWkYwZzZO?=
 =?utf-8?B?aTBmL1lKakZzMlZEMVlhdzdKekIzamtCT0FJRUJvMm9OZkhwYmVwaTBnc1ow?=
 =?utf-8?B?WWFCMWh6UE10QVJ6RytYNGVoUU9KUFNteFArQnFGclZtNTdtUlZvR21zTzVJ?=
 =?utf-8?B?S2JvN3RuTVhHRXFITzVqRDJiZWYwZFR4eWtVMTJpY3B3WVVjejRJdXdqRWpj?=
 =?utf-8?B?eldjbGhQQ0NpaFpTT3FUSGNySEE2V2VQUnhGaTloRzdZZnVHVk1OaUVDYmw5?=
 =?utf-8?B?VjJIRmp5TGZZN2lsSGVOK05LeDNQaE93WEVqeG9NWTRvcEhqVC9yZz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <404EF3CDE763BF409F6D818B023A357C@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c609dd1c-3bfd-465a-499f-08d9ebd514d6
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Feb 2022 14:04:25.9002
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Pjm1FEkPC4Xcocbma9vy+s22u7gKSW547MoxiggEINX1hOH7/2SBFtuMITp/nRoAOQ2nEiBJHFDCiEizz23lBGDSvdklfWTY35qYyUHktRdq20KdWVTUHW8HiO0Mh0ML
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR03MB4523
X-Proofpoint-GUID: 4YlQzc36hNDMwLUyrAMFUcvZwgsyFnIK
X-Proofpoint-ORIG-GUID: 4YlQzc36hNDMwLUyrAMFUcvZwgsyFnIK
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-09_07,2022-02-09_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 clxscore=1015
 lowpriorityscore=0 suspectscore=0 priorityscore=1501 mlxlogscore=765
 bulkscore=0 impostorscore=0 adultscore=0 malwarescore=0 spamscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202090080

DQoNCk9uIDA5LjAyLjIyIDE2OjAxLCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMDkuMDIuMjAy
MiAxNDo0NywgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+PiBIaSwgT2xla3NpaSEN
Cj4+DQo+PiBPbiAwOC4wMi4yMiAyMDowMCwgT2xla3NpaSBNb2lzaWVpZXYgd3JvdGU6DQo+Pj4g
bGlieGVuaHlwZnMgd2lsbCByZXR1cm4gYmxvYiBwcm9wZXJ0aWVzIGFzIGlzLiBUaGlzIG91dHB1
dCBjYW4gYmUgdXNlZA0KPj4+IHRvIHJldHJpZXZlIGluZm9ybWF0aW9uIGZyb20gdGhlIGh5cGZz
LiBDYWxsZXIgaXMgcmVzcG9uc2libGUgZm9yDQo+Pj4gcGFyc2luZyBwcm9wZXJ0eSB2YWx1ZS4N
Cj4+Pg0KPj4+IFNpZ25lZC1vZmYtYnk6IE9sZWtzaWkgTW9pc2llaWV2IDxvbGVrc2lpX21vaXNp
ZWlldkBlcGFtLmNvbT4NCj4+PiAtLS0NCj4+PiAgICB0b29scy9saWJzL2h5cGZzL2NvcmUuYyB8
IDIgLS0NCj4+PiAgICAxIGZpbGUgY2hhbmdlZCwgMiBkZWxldGlvbnMoLSkNCj4+Pg0KPj4+IGRp
ZmYgLS1naXQgYS90b29scy9saWJzL2h5cGZzL2NvcmUuYyBiL3Rvb2xzL2xpYnMvaHlwZnMvY29y
ZS5jDQo+Pj4gaW5kZXggNTJiMzBkYjhkNy4uZDA5YmJhN2Q4YyAxMDA2NDQNCj4+PiAtLS0gYS90
b29scy9saWJzL2h5cGZzL2NvcmUuYw0KPj4+ICsrKyBiL3Rvb2xzL2xpYnMvaHlwZnMvY29yZS5j
DQo+Pj4gQEAgLTMwNyw4ICszMDcsNiBAQCBjaGFyICp4ZW5oeXBmc19yZWFkKHhlbmh5cGZzX2hh
bmRsZSAqZnNoZGwsIGNvbnN0IGNoYXIgKnBhdGgpDQo+Pj4gICAgICAgICAgICBlcnJubyA9IEVJ
U0RJUjsNCj4+PiAgICAgICAgICAgIGJyZWFrOw0KPj4+ICAgICAgICBjYXNlIHhlbmh5cGZzX3R5
cGVfYmxvYjoNCj4+PiAtICAgICAgICBlcnJubyA9IEVET007DQo+Pj4gLSAgICAgICAgYnJlYWs7
DQo+PiBUaGlzIHdpbGwgbmVlZCBhIC8qIGZhbGx0aHJvdWdoICovIEkgZ3Vlc3MNCj4gV2h5PyBU
aGVyZSdzIG5vIHN0YXRlbWVudCBsZWZ0IGJlZm9yZSB0aGUgbmV4dCBjYXNlIGxhYmVsLg0KWW91
IGFyZSByaWdodCwgbm8gbmVlZA0KU29ycnkNCj4NCj4gSmFuDQo+DQo+Pj4gICAgICAgIGNhc2Ug
eGVuaHlwZnNfdHlwZV9zdHJpbmc6DQo+Pj4gICAgICAgICAgICByZXRfYnVmID0gYnVmOw0KPj4+
ICAgICAgICAgICAgYnVmID0gTlVMTDsNCj4NCg==


From xen-devel-bounces@lists.xenproject.org Wed Feb 09 14:16:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 09 Feb 2022 14:16:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269237.463260 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHnlr-0000YT-TV; Wed, 09 Feb 2022 14:16:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269237.463260; Wed, 09 Feb 2022 14:16:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHnlr-0000YM-QB; Wed, 09 Feb 2022 14:16:35 +0000
Received: by outflank-mailman (input) for mailman id 269237;
 Wed, 09 Feb 2022 14:16:35 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nHnlr-0000YG-02
 for xen-devel@lists.xenproject.org; Wed, 09 Feb 2022 14:16:35 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nHnlq-000648-Rv; Wed, 09 Feb 2022 14:16:34 +0000
Received: from 54-240-197-228.amazon.com ([54.240.197.228]
 helo=[192.168.1.215]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nHnlq-00035r-J8; Wed, 09 Feb 2022 14:16:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=DfyDGre4l2hO+MXmqtYTAZ7Wr3qqX1OXsphpzwHcwXc=; b=RZVw8iuCvUHTp0wKJSabD2AfCs
	NEHGGs1YHE1VW28M8kOHH62PYwXlYPmHRzuOTQSMnwTQEaH2HTPAKGGxGH0xRiPNwIYwg3tt0JfDf
	6e4RY47tAv6W/odP8ZtHPAnzXowcixQ9+hJnMZContCLSP83Sz16mARXxexeKYNqHyW4=;
Message-ID: <c0f76e2a-fb5a-169f-c6d9-f9f5391eb049@xen.org>
Date: Wed, 9 Feb 2022 14:16:32 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.1
Subject: Re: [PATCH v5 03/11] xen/arm: avoid setting XEN_DOMCTL_CDF_iommu when
 IOMMU off
To: Penny Zheng <penny.zheng@arm.com>, xen-devel@lists.xenproject.org,
 sstabellini@kernel.org
Cc: Bertrand.Marquis@arm.com, Wei.Chen@arm.com
References: <20220127074929.502885-1-penny.zheng@arm.com>
 <20220127074929.502885-4-penny.zheng@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220127074929.502885-4-penny.zheng@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit



On 27/01/2022 07:49, Penny Zheng wrote:
> From: Stefano Stabellini <sstabellini@kernel.org>
> 
> When IOMMU is absent or shall not be used (trusted domain, performance,
> hardware limitation, ..., etc), in which cases this commit avoids setting
> XEN_DOMCTL_CDF_iommu to make those user cases possible and prevent failure
> later during device assignment.
How about:

xen/arm: Allow device-passthrough even the IOMMU is off

At the moment, we are only supporting device-passthrough when Xen has 
enabled the IOMMU. There are some uses cases where it is not possible to 
use the IOMMU (e.g. doesn't exist, hardware limitation, performance) yet
it would be OK to assign a device to trusted domain so long they are are 
direct-mapped or the device doesn't do DMA.

Note that when the IOMMU is disabled, it will be necessary to add 
xen,force-assign-without-iommu for every device that needs to be assigned.

> 
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
> Signed-off-by: Penny Zheng <penny.zheng@arm.com>
> Tested-by: Stefano Stabellini <sstabellini@kernel.org>
> ---
> v3 changes:
> - new commit, split from the original "[PATCH v2 2/6] xen/arm: introduce
> direct-map for domUs"
> ---
> v4 changes:
> - explain briefly in the commit message why we want to do device assignment
> without IOMMU.
> ---
> v5 changes:
> - nothing changed
> ---
>   xen/arch/arm/domain_build.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index 6467e8ee32..c1e8c99f64 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -3047,7 +3047,8 @@ void __init create_domUs(void)
>               panic("Missing property 'cpus' for domain %s\n",
>                     dt_node_name(node));
>   
> -        if ( dt_find_compatible_node(node, NULL, "multiboot,device-tree") )
> +        if ( dt_find_compatible_node(node, NULL, "multiboot,device-tree") &&
> +             iommu_enabled )
>               d_cfg.flags |= XEN_DOMCTL_CDF_iommu;
>   
>           if ( !dt_property_read_u32(node, "nr_spis", &d_cfg.arch.nr_spis) )

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Feb 09 14:18:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 09 Feb 2022 14:18:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269244.463271 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHnnC-0001AV-7Y; Wed, 09 Feb 2022 14:17:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269244.463271; Wed, 09 Feb 2022 14:17:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHnnC-0001AO-48; Wed, 09 Feb 2022 14:17:58 +0000
Received: by outflank-mailman (input) for mailman id 269244;
 Wed, 09 Feb 2022 14:17:56 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=4iPq=SY=epam.com=prvs=403937cc0f=oleksii_moisieiev@srs-se1.protection.inumbo.net>)
 id 1nHnnA-0001A4-G5
 for xen-devel@lists.xenproject.org; Wed, 09 Feb 2022 14:17:56 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 11d35474-89b3-11ec-8f75-fffcc8bd4f1a;
 Wed, 09 Feb 2022 15:17:54 +0100 (CET)
Received: from pps.filterd (m0174681.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 219E5jMV008185;
 Wed, 9 Feb 2022 14:17:44 GMT
Received: from eur04-vi1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2053.outbound.protection.outlook.com [104.47.14.53])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3e4dpf8bm0-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 09 Feb 2022 14:17:44 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com (2603:10a6:102:ea::23)
 by VE1PR03MB5406.eurprd03.prod.outlook.com (2603:10a6:802:a7::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Wed, 9 Feb
 2022 14:17:29 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::c1c:f98:9dd:86e0]) by PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::c1c:f98:9dd:86e0%6]) with mapi id 15.20.4975.011; Wed, 9 Feb 2022
 14:17:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 11d35474-89b3-11ec-8f75-fffcc8bd4f1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jJ9xJJeT28t0SR6GHjHaj7/TbzoO+oMtZfiGOkApN3JbRapnsqXHnaSlRXaTO3TzFbveWeoWirvNI8QfwJMaWMw3vBjgY/wnEteCp5JkCr/kO4TCwVg/4qM2vvLRpgCBz+Zp/Ho0Ds8X7pevPq/n72Wya3cGTz5jWwYNQWvmg+xP88RlXCjYhtj0d8D5xq2pJBzpOj6Zlfa2wYM7tyiEzoijZJ4B1nJFvUeV1Xub4SfagPSJxhmKrqf87UVmtIiwBmgBBoqZH1lvRo3DZahZ4+CyjTyZKoIjlVfXWoMdeGdchtl4ZpbWlb+rlXKwkSyZwvZE2lu0K7Ka6boidYZ4eA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=LgZUCRpIP9tL0Us1M2E5QPOox4BZ1YK2v+q+up6biUU=;
 b=F2SB2WoqXSCIqxlvawIoPpfEBy7hVf/Qu+/RG1TG5xe6FH60GYatmhoR6/gEgH9PplyIfbeZYco71Rqvo6lMR8Ap4jNGNfjYMWeyEpB/STwiGgiTWxMjAuE07QxHmayTog5jKdAa3Uq1dpWBWwmTLX+rgVsPRzQmIllgmpLkuDPUGZOed3CDy+Gi59xfJs+45Ehn7g8E4wF6Jn1vh+mAMMsd6OCq8pRvqRaiL2tNM2pUifDwXJ4RDKt39Lxqe/8EIXG5+aiuvkf3S2iMdCTToNhYVlVmK+ahSAHllGiDg8o2n4k4qDmvMcRt6EyRDfYR58XWJdzA/5baAMi/zgfpJA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=LgZUCRpIP9tL0Us1M2E5QPOox4BZ1YK2v+q+up6biUU=;
 b=gU8vgK9VYgbIrN3hRNZCfGTQnHz95bZUYVy8SXsywkb71ymsGRMwjCs7RksDJYVPYp6WwCNZMsdkENXGd+pKdQgWAu8wAnyai1eXEfnI0y1pIwnRco++CiuZGA/FIVnHvmUCd/kachxcylKSrY+WjP/hO07HVxSjghSm3wnjDs85tjJLIOS4pn1pel3JXhHsffyqEncxatjc9/rOoI5I2pnQ3edBJc3bkLbrwZb90UaOKDKr72VnSAii14WK3JYXuSNBBA+gKsxHfXunUgSdnaFn8Yw0b1ZyT1eWRAeX3/xsLP7uCi/Ai08I25K/fww8RfyNePQexNUkvDHFPnod1g==
From: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
To: Julien Grall <julien@xen.org>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        Stefano
 Stabellini <sstabellini@kernel.org>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Juergen Gross <jgross@suse.com>
Subject: Re: [RFC v2 3/8] xen/arm: Export host device-tree to hypfs
Thread-Topic: [RFC v2 3/8] xen/arm: Export host device-tree to hypfs
Thread-Index: AQHYHRW1S717SraA0Ui+K6wc2/TNAKyJ+LkAgAEKd4CAACCZgIAAIZQA
Date: Wed, 9 Feb 2022 14:17:29 +0000
Message-ID: <20220209141728.GA1258996@EPUAKYIW015D>
References: <cover.1644341635.git.oleksii_moisieiev@epam.com>
 <e440e4f16a506ecc87078635dbb3fda2ebd45346.1644341635.git.oleksii_moisieiev@epam.com>
 <b88f6a50-6e9e-5679-8d25-89e26031e88e@xen.org>
 <20220209102037.GA1025795@EPUAKYIW015D>
 <316bd101-af8b-d2f0-1db5-ea6c583acd59@xen.org>
In-Reply-To: <316bd101-af8b-d2f0-1db5-ea6c583acd59@xen.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 3731e1d3-de41-4d3a-5514-08d9ebd6e812
x-ms-traffictypediagnostic: VE1PR03MB5406:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <VE1PR03MB5406DDA66D5DF64EE39E8848E32E9@VE1PR03MB5406.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 AAc+7RcjoJbsnyxbXt2PiBySaJut7jq8mEUxp9KAb7z4bgcjdiC+KK/l939Cl+iUXbyCFTVmOMb9fOXEr67fjcv+nXTtRzKxG/mDTNT97E0NvMSb6iWtD0y6/eRewjDIyO+0YOkKW9r4QAaJEvK8RLR+Zr+Mh31W3RnS4f2za5CGXxdCCi0dFkOlmi4s+1x7JPWF1JZxfpnuMI1Zwhgk2lhZx2Uxcd+LySuskJzCjPdX239mLxfkGiCuXBQvrIi1XiBnFLJUH4WJ5GTYK8rXNVutWOcRrgAnDSKQ7KZxkRplFaslknEVGowOwYMkUTOTWoQSKsUsMjVv3AKrxI4DF3kaJNOxBKlJjD9lMaMlux+M/c+CngrN+r2NskXwI0M1ONQm6Gsv9dnW7YokrJd/kHjTMhm0151mNnxTmJh7NbQ19B7sZDftuBKq8PSccb82vd6gwskyERNUizynVaKhZzJyF7mcOuhvMvmd2wEmBkiX07EhBp44t2rP6vaTxFRzeR2pF1O5tlC5gIpPLkgQWQafOpcV2Hc+Azu6uftK+BSslhWxK48aStG3Lu6LvQrtwviMSJxg0xX9WVCoIfO2cEYqas6itTT35hRParrYda5dG/ooerdT1MpxfkJDn2uCgmQ7Kv9IcQ7Udq3q5J8fuRI3cVTPi3xsVkDmSHwKkeqktcqFJHRxnGKYzWs6kgd4igjHhOS5RM7OrxzAj76LPL/8i06IzkczGN8jBkOYNn0=
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR03MB7136.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(38070700005)(71200400001)(316002)(6486002)(86362001)(508600001)(66476007)(64756008)(66556008)(122000001)(6916009)(33716001)(76116006)(6512007)(53546011)(9686003)(1076003)(4326008)(83380400001)(54906003)(8676002)(2906002)(26005)(186003)(33656002)(6506007)(38100700002)(91956017)(66446008)(5660300002)(66946007)(8936002)(2004002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?JcKP4JyCXKxzQoBwMSfgP/9SHoJJG1Ha3WoqcgMsTXoO9bbdhv1pxZz++bp1?=
 =?us-ascii?Q?PMT123ve4+Xm0mnt6JJ7oR/E2/FSUMCza5SHeg3G3QpvXZpTlRXRPUM5j4io?=
 =?us-ascii?Q?vfMspw29Mcufaz8fRl6OexWk/yMPvFGFK5YGkriCa+IKDsVhZuJx0vOJCTHp?=
 =?us-ascii?Q?0tdllxJ/aV8RHNAYdzE07FPYunXESF7afRNqNWRHONdd+RPUhyIGCwGVKE57?=
 =?us-ascii?Q?PnqCqVp2TW2J+1DSOlHhofSgX271tO4NgoLcm8hCprHDVNYOc7x6mtS03inC?=
 =?us-ascii?Q?KC7mk8F9wNLc2tjrnzkpTXvYigcvPxfWFzdvyCQEePMDMpsekibRv8QFUJ7O?=
 =?us-ascii?Q?vf7/bHGRYFbEpeHd9MtSPzJAFMHiTR1VY33z3u0ZrhL7xWPK/nec1itoLFfb?=
 =?us-ascii?Q?8zh5sFfhn5wx0vd8Kego0KKIPPYp9ezCufRpY7bGCQLYzXsj45bp463+3RU/?=
 =?us-ascii?Q?ismVLDz0QDkMK1laIJmovMDvUP5PJSrZXFSVqHAz5iiqr2AMEvDbNaVbAK+4?=
 =?us-ascii?Q?z0gsVJNv8my9x1cZtwib2AMdlmcF7iuTm9a2u1mVRIUnCi2k6k1UjoGS6W4Z?=
 =?us-ascii?Q?Nn6zbna6stTnL4yb+Nbny9vHLt1g3AaYyZyhuEGtnfwwSUGjRdpi1w5R+FeR?=
 =?us-ascii?Q?2/wNpCALRlmHFy2/ZQ2/SyB2I52uoAEF1XAtKBqFAwSeTS399qBIedq9vrcT?=
 =?us-ascii?Q?njO/7zJyzyGfR92ASiAuXpC463lgDM5JHNhN6aewB2gHpnbVSTuhA/E388Kj?=
 =?us-ascii?Q?TT/H1AWbWDPm3Rml34hyG15JbMGJP4QkBLOgW9ihQKXiSmqHPn24Q0YNW+8H?=
 =?us-ascii?Q?gAuqsuweVx4U9mQKSic9ARMbNDLo+CXvtsKrp4YOkFfZ8W2dtofQmUSo65xd?=
 =?us-ascii?Q?r9sCsEpIUaCS/UeFcukEMTfs7PXhxHzBU3Yh7+XI84nmPQmFTnRWTpYCuA/d?=
 =?us-ascii?Q?u4XCkgrzGcVc2DfrRb41dE59zZhXezXOWbcn0eQxOo9guBc+5XtWJnzgznNP?=
 =?us-ascii?Q?if7Ag3aZ/FFF0cc4I8PiD1DVXUWUE2M7/oxsPQlFC4ZTkKHSXqFvrnsOFq1w?=
 =?us-ascii?Q?EmhyFd/lPWdqx+A0DfEPWhKeMchtLi4Vb1vHpetgXTU/v33WAGRZ3wuVoXKa?=
 =?us-ascii?Q?UdeqdyX+OXPqkpmfrKDp7gA8VByQXcbn0zxZoh5dIi3L3pPoL2aj5G401hFF?=
 =?us-ascii?Q?oKDJdRlnk2EO1zZ6bWzIjnSGH/cDfAVPNcVQ02EyOALMdE2P+fQRJuMfY+lT?=
 =?us-ascii?Q?oT7atZdxQWR9Z/gM9BqlSQIimYZZhvbBMFz62nGToiFbCmETExhWku22I3iu?=
 =?us-ascii?Q?xom7LxXV2fb65orN2uyIUIo9qvNfHAW+JiUGA963I17nINZwuksodFOvFYO3?=
 =?us-ascii?Q?kKW2xNDxANeAU7fX3YitPTFABBcmhAc6D8ci6mZqLohZMDTpePD9NEIW92Mf?=
 =?us-ascii?Q?5zC8iWu4Ge7/eBN+ehtBAJgsrGG0uciTV82dTgZorEhtXqwyDXqmYUJIx38G?=
 =?us-ascii?Q?b2ticELWgKLBuQ5d1TiYarQBBT8s7NZB+G/kmWBkJb48lqiaRMkmXPQxt8Mm?=
 =?us-ascii?Q?nBJlMtjULLDyT7IyscGOukGc62jyfzrTnG7xFq5PnmgLdvOcqI8ALiZP5BH+?=
 =?us-ascii?Q?cGdH3rSC+2gj4xCQ50LyarS4zXxZQZHtWaWoutP+BGYi9lsmSWzUXBj33Vqx?=
 =?us-ascii?Q?KqBI+SgFCW3xtPtQFQHkSwDxrZ4=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <EC359AE40092794BBE1C95934133846D@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR03MB7136.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3731e1d3-de41-4d3a-5514-08d9ebd6e812
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Feb 2022 14:17:29.7573
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Zjx/I6jzRVLbpW4hWlZ2aeJkCtJ2hOY5yRQGYNYS7j7ko2Q9OHDjAe7lbh3+ek0YCj4zkJN34A/mfHLU228pCGlCciQLFD1BwgQXhHlqMOs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR03MB5406
X-Proofpoint-GUID: _QqoDDcb-wD_-MxAw1EFijW5Ir7TpH8s
X-Proofpoint-ORIG-GUID: _QqoDDcb-wD_-MxAw1EFijW5Ir7TpH8s
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-09_07,2022-02-09_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0
 mlxlogscore=999 suspectscore=0 impostorscore=0 lowpriorityscore=0
 priorityscore=1501 spamscore=0 clxscore=1015 adultscore=0 mlxscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202090082

Hi Julien,

On Wed, Feb 09, 2022 at 12:17:17PM +0000, Julien Grall wrote:
>=20
>=20
> On 09/02/2022 10:20, Oleksii Moisieiev wrote:
> > Hi Julien,
>=20
> Hi,
>=20
> >=20
> > On Tue, Feb 08, 2022 at 06:26:54PM +0000, Julien Grall wrote:
> > > Hi Oleksii,
> > >=20
> > > On 08/02/2022 18:00, Oleksii Moisieiev wrote:
> > > > If enabled, host device-tree will be exported to hypfs and can be
> > > > accessed through /devicetree path.
> > > > Exported device-tree has the same format, as the device-tree
> > > > exported to the sysfs by the Linux kernel.
> > > > This is useful when XEN toolstack needs an access to the host devic=
e-tree.
> > > >=20
> > > > Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@epam.com>
> > > > ---
> > > >    xen/arch/arm/Kconfig           |   8 +
> > > >    xen/arch/arm/Makefile          |   1 +
> > > >    xen/arch/arm/host_dtb_export.c | 307 +++++++++++++++++++++++++++=
++++++
> > >=20
> > > There is nothing specific in this file. So can this be moved in commo=
n/?
> >=20
> > You're right. I will move it to common.
> >=20
> > >=20
> > > >    3 files changed, 316 insertions(+)
> > > >    create mode 100644 xen/arch/arm/host_dtb_export.c
> > > >=20
> > > > diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
> > > > index ecfa6822e4..895016b21e 100644
> > > > --- a/xen/arch/arm/Kconfig
> > > > +++ b/xen/arch/arm/Kconfig
> > > > @@ -33,6 +33,14 @@ config ACPI
> > > >    	  Advanced Configuration and Power Interface (ACPI) support for=
 Xen is
> > > >    	  an alternative to device tree on ARM64.
> > > > +config HOST_DTB_EXPORT
> > > > +	bool "Export host device tree to hypfs if enabled"
> > > > +	depends on ARM && HYPFS && !ACPI
> > >=20
> > > A Xen built with ACPI enabled will still be able to boot on a host us=
ing
> > > Device-Tree. So I don't think should depend on ACPI.
> > >=20
> > > Also, I think this should depend on HAS_DEVICE_TREE rather than ARM.
> >=20
> > I agree. Thank you.
> >=20
> > >=20
> > > > +	---help---
> > > > +
> > > > +	  Export host device-tree to hypfs so toolstack can have an acces=
s for the
> > > > +	  host device tree from Dom0. If you unsure say N.
> > > > +
> > > >    config GICV3
> > > >    	bool "GICv3 driver"
> > > >    	depends on ARM_64 && !NEW_VGIC
> > > > diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile
> > > > index 07f634508e..0a41f68f8c 100644
> > > > --- a/xen/arch/arm/Makefile
> > > > +++ b/xen/arch/arm/Makefile
> > > > @@ -8,6 +8,7 @@ obj-y +=3D platforms/
> > > >    endif
> > > >    obj-$(CONFIG_TEE) +=3D tee/
> > > >    obj-$(CONFIG_HAS_VPCI) +=3D vpci.o
> > > > +obj-$(CONFIG_HOST_DTB_EXPORT) +=3D host_dtb_export.o
> > > >    obj-$(CONFIG_HAS_ALTERNATIVE) +=3D alternative.o
> > > >    obj-y +=3D bootfdt.init.o
> > > > diff --git a/xen/arch/arm/host_dtb_export.c b/xen/arch/arm/host_dtb=
_export.c
> > > > new file mode 100644
> > > > index 0000000000..794395683c
> > > > --- /dev/null
> > > > +++ b/xen/arch/arm/host_dtb_export.c
> > >=20
> > > This is mostly hypfs related. So CCing Juergen for his input on the c=
ode.
> >=20
> > Thank you.
> >=20
> > >=20
> > > > @@ -0,0 +1,307 @@
> > > > +/*
> > > > + * xen/arch/arm/host_dtb_export.c
> > > > + *
> > > > + * Export host device-tree to the hypfs so toolstack can access
> > > > + * host device-tree from Dom0
> > > > + *
> > > > + * Oleksii Moisieiev <oleksii_moisieiev@epam.com>
> > > > + * Copyright (C) 2021, EPAM Systems.
> > > > + *
> > > > + * This program is free software; you can redistribute it and/or m=
odify
> > > > + * it under the terms of the GNU General Public License as publish=
ed by
> > > > + * the Free Software Foundation; either version 2 of the License, =
or
> > > > + * (at your option) any later version.
> > > > + *
> > > > + * This program is distributed in the hope that it will be useful,
> > > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > > > + * GNU General Public License for more details.
> > > > + */
> > > > +
> > > > +#include <xen/device_tree.h>
> > > > +#include <xen/err.h>
> > > > +#include <xen/guest_access.h>
> > > > +#include <xen/hypfs.h>
> > > > +#include <xen/init.h>
> > > > +
> > > > +#define HOST_DT_DIR "devicetree"
> > > > +
> > > > +static int host_dt_dir_read(const struct hypfs_entry *entry,
> > > > +                            XEN_GUEST_HANDLE_PARAM(void) uaddr);
> > > > +static unsigned int host_dt_dir_getsize(const struct hypfs_entry *=
entry);
> > > > +
> > > > +static const struct hypfs_entry *host_dt_dir_enter(
> > > > +    const struct hypfs_entry *entry);
> > > > +static void host_dt_dir_exit(const struct hypfs_entry *entry);
> > > > +
> > > > +static struct hypfs_entry *host_dt_dir_findentry(
> > > > +    const struct hypfs_entry_dir *dir, const char *name, unsigned =
int name_len);
> > >=20
> > > This is new code. So can you please make sure to avoid forward declar=
ation
> > > by re-ordering the code.
> > >=20
> >=20
> > I can't avoid forward declaration here because all those functions
> > should be passed as callbacks for node template dt_dir. And dt_dir is
> > used in read and findentry functions.
>=20
> You can avoid most of those forward declarations if you define the static
> variable now but fill them up after (see [1]). I don't think we can avoid
> the static variable forward declaration without reworking the API.
>=20
> BTW, I could not fully apply the series on the staging tree:
>=20
> Applying: xen/hypfs: support fo nested dynamic hypfs nodes
> Applying: libs: libxenhypfs - handle blob properties
> Applying: xen/arm: Export host device-tree to hypfs
> Applying: xen/arm: add generic SCI mediator framework
> error: patch failed: MAINTAINERS:512
> error: MAINTAINERS: patch does not apply
> error: patch failed: xen/arch/arm/domain_build.c:1894
> error: xen/arch/arm/domain_build.c: patch does not apply
> error: xen/include/asm-arm/domain.h: does not exist in index
> Patch failed at 0004 xen/arm: add generic SCI mediator framework
> hint: Use 'git am --show-current-patch=3Ddiff' to see the failed patch
> When you have resolved this problem, run "git am --continue".
> If you prefer to skip this patch, run "git am --skip" instead.
> To restore the original branch and stop patching, run "git am --abort".
>=20
> From the errors, it sounds like your baseline is from a couple of months
> ago. Please make sure to send your series based on the latest staging (at
> the time you send it).
>=20

I'm sorry for that. I will fix all comments, mentioned above, make a
rebase and post v3 shortly.

> > > > +static int host_dt_dir_read(const struct hypfs_entry *entry,
> > > > +                            XEN_GUEST_HANDLE_PARAM(void) uaddr)
> > > > +{
> > > > +    int ret =3D 0;
> > > > +    struct dt_device_node *node;
> > > > +    struct dt_device_node *child;
> > >=20
> > > The hypfs should not modify the device-tree. So can this be const?
> >=20
> > That's a good point.
> > Unfortunatelly child can't be const because it is going to be passed to
> > data->data pointer, but node can be const I think. In any case I will g=
o
> > through the file and see where const for the device_node can be set.
>=20
> Can you explain why that data->data is not const?

I reused struct hypfs_dyndir_id, added by @Juergen Gross in
4f1e5ed49c2292d3dd18160b7e728b1aa9453206 hope he will help to answer
this question.

> > > > +static HYPFS_DIR_INIT_FUNC(host_dt_dir, HOST_DT_DIR, &host_dt_dir_=
funcs);
> > > > +
> > > > +static int __init host_dtb_export_init(void)
> > > > +{
> > > > +    ASSERT(dt_host && (dt_host->sibling =3D=3D NULL));
> > >=20
> > > dt_host can be NULL when booting on ACPI platform. So I think this wa=
nts to
> > > be turned to a normal check and return directly.
> > >=20
> >=20
> > I will replace if with
> > if ( !acpi_disabled )
> >      return -ENODEV;
> >=20
> > > Also could you explain why you need to check dt_host->sibling?
> > >=20
> >=20
> > This is my way to check if dt_host points to the top of the device-tree=
.
> > In any case I will replace it with !acpi_disabled as I mentioned
> > earlier.
>=20
> dt_host will always points to the root of the host device-tree. I don't
> think it is the job of hypfs to enforce it unless you expect the code to =
be
> buggy if this happens. But then I would argue the code should be hardened=
.
>=20

I will refactor this check.

Best regards,
Oleksii.=


From xen-devel-bounces@lists.xenproject.org Wed Feb 09 14:26:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 09 Feb 2022 14:26:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269256.463282 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHnv1-0002g2-5y; Wed, 09 Feb 2022 14:26:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269256.463282; Wed, 09 Feb 2022 14:26:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHnv1-0002fv-2y; Wed, 09 Feb 2022 14:26:03 +0000
Received: by outflank-mailman (input) for mailman id 269256;
 Wed, 09 Feb 2022 14:26:01 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=XFrC=SY=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nHnuz-0002fp-LK
 for xen-devel@lists.xenproject.org; Wed, 09 Feb 2022 14:26:01 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 3403c0ac-89b4-11ec-8eb8-a37418f5ba1a;
 Wed, 09 Feb 2022 15:26:00 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2059.outbound.protection.outlook.com [104.47.14.59]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-9-u_rbBuElPuSgoZku5A9Swg-1; Wed, 09 Feb 2022 15:25:59 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM0PR04MB6161.eurprd04.prod.outlook.com (2603:10a6:208:148::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Wed, 9 Feb
 2022 14:25:57 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.018; Wed, 9 Feb 2022
 14:25:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3403c0ac-89b4-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644416760;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=0qGQSia3V8LStIAG9F4GxWF7jFSPXXwvssOpyBRHn4s=;
	b=T1QiM+SBz+U1FuGORqDNT60tv906YhKy/ebQAoeeRHNylGT8iPNT4jJUvhWMiTFBIS08KD
	rrQAI/dMc1ibRsnMarfJtVLpb2aqX5Ez2CoVsG7efY2uvfDKkXzYtnvd/LznrqSTuzNZcd
	7/YwuDZswPTwZC5cwfr8Se8w3X9y1vE=
X-MC-Unique: u_rbBuElPuSgoZku5A9Swg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ENVJtSxifBiqMbh7AABGqG8O8Sef2OWKc9uyQPfW73ubENcf/Q8OwHsW3X9FI9J4ooTuO7MKHmTj+GBNz1vVC+Sj0bQJ1Rar2apg2ohFEJX0mzvptN2yp0oGdJzsFKsA8vvyxBi3OiJWo3Q4bnHAi5UdpNDxleoXRyUbwvLG2xW7eHqJv55skN8jF5noPWuc/BnOT102CMpgKmIq9BXkIySCjOULkoTx09P3+S+aNY5hApm2jgqzJeJrF1uxE7TD6lVxArxmHCDjemKEqk58lyXgVhTN0WnXMk7jaLXXCfHetF3OXq88hJQWIl34hJch4v7ZOTi0YKfwvEVzGX5Isw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=0qGQSia3V8LStIAG9F4GxWF7jFSPXXwvssOpyBRHn4s=;
 b=QiqzzMhzFYyboc1ikmXxGOKUF+csJrLEv/HSSOTClEydgbvoDMsZVgYmewHouqVBRhIPnvdLaWuy5ihCRKZF/uu8kwKe0RaiJHdkglnEpdDGtpoBCa5rnFAXo4wEeKkdBMa09eMeKmNC8n5TToYp5n85KVamz6pwobQVQVrVKJ4F+YRlu5fPR+OTh7hebpFyhE+ncdEKn3d6Nrw11638JowNHTYQ2kvl/O18G7uulE0kZWbjxHLBLDzJ3viHjh1anPHFSNVqJVEY76updgvWXoIUC0fhxEVRyVZhXkiHifyjknCbLnAvvgPSEDShSt7vUIOfq3qXM19Sv7XLFrRNNg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <ad339015-c5e7-d776-17a3-2dbd337fcd4a@suse.com>
Date: Wed, 9 Feb 2022 15:25:55 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH v2] x86: Use low memory size directly from Multiboot
Content-Language: en-US
To: Tu Dinh Ngoc <dinhngoc.tu@irit.fr>
References: <fe2e94e8-9e46-82be-6e83-391f4709ef75@suse.com>
 <20220209131251.387-1-dinhngoc.tu@irit.fr>
Cc: xen-devel@lists.xenproject.org
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220209131251.387-1-dinhngoc.tu@irit.fr>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR10CA0053.EURPRD10.PROD.OUTLOOK.COM
 (2603:10a6:209:80::30) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: dde889a3-99c7-4d84-bc69-08d9ebd8166b
X-MS-TrafficTypeDiagnostic: AM0PR04MB6161:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB6161178B78F17A569453251FB32E9@AM0PR04MB6161.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	bHNGEaUP2t6piLBsPxpXMMhzknMRl4addGNbFR0PBkH8MvGAHdamDzi8hfSPfIS1K515w0ECzz7dF64piFed1bO2gupsaZCz5gyVjxYbOsfdIMVJGDSazRPBFsEFH7bbkvOaXyJW/qKLJQ0FBtC5A+nggavKV67zkK8cJedH4wRL4xqZS/2ePPlQmalxGdf3tTBIvh7sOM9d3N1LqFvoh5Mk5dKhNO+R4doIych7T/r2VL0NyODaBrE9Hctw/DjjdVPMiXaUIN8XrfUg9htLvrZjVggaJ4+o0r4CD8bIjHahL1ct8Bh2bAWTjkABZGSpCC+JuOmzUAxv9JXHsCyXtYs9vx5Fqi36zOoBHZLz3T8lXSz6YaTz5tdQ43WuTE5oI4GRh+V4w/jhWGnh+2AU7KlyHkDEDbP00uoiSt2VqD51uW6J0nBoz4u9qwz95t7dTuBJuZg/heS13jXnPncQGshR3yYH5m3D+kirjqONkYgdWLVOQ9cYRsuNvKAjgyQauOgimVWLebDxCJt2nfrJwy2u8MyFpp/9bTQFDGfTgTRi5FGKXVVNorJnOsH11072/Zc2P5gmIOLPOSXsqVVfWUm1Yju1Zshoovy19XLjrycAu29eV7muc7thTq7d63IZ1G7jU8u9yJwhgn1bkJuqxk6uOXp7IDEwNDhiVd19kM5i2VxKGt9cytqJ+WMIZse1E25IACjksXBS9UHcRPF63fzUWruJP0mqVhwMseE/vKYurV1mgJiJPUaYCiOCFa8H
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(83380400001)(38100700002)(86362001)(186003)(8936002)(66946007)(26005)(66556008)(66476007)(2616005)(36756003)(316002)(6916009)(2906002)(4326008)(8676002)(31686004)(5660300002)(508600001)(31696002)(6512007)(6486002)(53546011)(6506007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?WG1nRFRsUWdpN1o3TnZKdmRZWjNKZWFneURwQ2tDQzAzQnFGTHg3SFB1Q3dh?=
 =?utf-8?B?Mlp2QzY4L0pwMVNRdzZRSjhzSzJyTGUwVGFrdlYwUUJSUkJZVytLdzRNMUNV?=
 =?utf-8?B?N1gyTW1tb3N1UHR1MVdiVVVTOWVtWGdaTlNTYThiUC9lWndXSHczSjdWN1V3?=
 =?utf-8?B?cFdaRTdENUREMkc0REJZM3FpKzE3SHRwYzlXcFVoS3Fmcm9lM3l5UzJ1cXBh?=
 =?utf-8?B?SUVOazVIbXF1aGhRMks2TlRpeDBEMlVVOVVsV0xaOHpNOEFDM1p2a2Vxa3Jv?=
 =?utf-8?B?TkNic2hhcTRBK1l5bmRqbTFMdmhqT1RBVFRyTjY3UWtRU21MQnhOZEY3SXBR?=
 =?utf-8?B?NVZwamJ0L3lkS0Yrc0VjamZWWXVJNDlvYjZVS1NTTXF6T0JiS3VrWFBVYitp?=
 =?utf-8?B?OUV5T01hZlMxTUtQR05PZkRGNUhnT1FZZHRDanVEWUFkSnZMa1lQeDQ4SmRZ?=
 =?utf-8?B?Z0RMU0NkQmZydlpYQ0V3aWZ3U1d6Yk1mSjVkWUlTR2FjT0p1aXBkbVNsdGZT?=
 =?utf-8?B?RVh0TVY0SFh0VjBhckNERExqQ1k2cE5sZWlNMzdZN0R0Rld3dXNMOUovbE4x?=
 =?utf-8?B?c1BPRmRuWWNPclI2U3JGcTdKL1hBWkxxSmtkUDhPaEdZMmVvQUpPZnJ2TFZK?=
 =?utf-8?B?UHZna2dCV2xLMHNybEMwQlhSRXQyOTNxOFArM2ZSaDQ1UXpKNFhYVVhmMmlk?=
 =?utf-8?B?VW9qUUZXMkpRcXlPd1I5a1lyUjljUmh5UXoydUtzeUJWUm5RYWVQeG9ZcXZk?=
 =?utf-8?B?L1dUTUpHNm9GZnphUUtJTzdKeDkrdWNpZWM1bGs1WnV4WDJtY2pGMjVhM1ov?=
 =?utf-8?B?cURiZ3IzaXpINmg5TEFxUnlYQnVCZVpMVThIV1lrQW5SdDN6R0dwQUVqejRU?=
 =?utf-8?B?VGxRNTVyMWZBYm10d2hsYWlNeHVpTm1XT3owb01ab1NoeHZkN1Q3cVkvdW43?=
 =?utf-8?B?Uy9EQ1c0MWFnNkk3cVJXUjE4WFp2bGRyWnh2UVRWcVArMHJ2cHhWSVl2QmNo?=
 =?utf-8?B?UTlrVk1CdnN3NzExRXpOWU9FRVZKKzlaclFwQVZDTEhRQ21xWCtSeHhHR0Fv?=
 =?utf-8?B?OWZLa3JpU1dvMTd3eHBENEEzbjZJZGxKWDUvM2dFREppTENNZXhtZE0yb1kr?=
 =?utf-8?B?N2RUUlZkTDFkdDl6N0NCK2pPaTlXQ2laVVZuZDF4b1Flb3FXNEVFMFU4RWNw?=
 =?utf-8?B?ZHpEZDVob3N6SUZUb0Y5OHFwM2NDejcwNHZZb3NzcHQyRmZmZmMra3FKblpp?=
 =?utf-8?B?ZjI2RUl3Umh1N1ZTR1dNTUFnTVZ5Q24xVkV3QWZFMFROS09qaDRoYVFWYUZP?=
 =?utf-8?B?RTBWZldGVTdVSlJVOUpWZG5UOFFUeHY1S0F5WXpHNGl2QTAxR1FhdE1qN2V4?=
 =?utf-8?B?bUJLdlFCSm4wK2cxL29OeThDNzFmN0lPYTgzeGJxN2Z1RmdLM05Sa0NOWm1P?=
 =?utf-8?B?ZGhrQzlSU0pJWnlpdEE5R0VqbUF4K21NZ1FUR1FCZUZCNDNxMzdOUjZWN0Vs?=
 =?utf-8?B?NjN5UHpnbUc4WFNxVVUydVE1SXhEUi9IWk16N1FOZ1RDamJ6NU5GMURyWXBy?=
 =?utf-8?B?SG91Qm9CeTFOTE1jQkZqVzExV1BYZjZMNkxPMldXWFNMZ2FlZDllbjkzTHJW?=
 =?utf-8?B?L3lxdTFDOVlBY1FNV1F5OHlBOWlGZ3B6a1ZEMW5MbDJOMWxTWXVVSjNIQy9p?=
 =?utf-8?B?NFNKckJzd1VaaUl4bzBRMkpCcVo3VnVCa2xHcFRsYStSUkNIUTVoSytLN20x?=
 =?utf-8?B?YllRZWp6dE9jNWh4Zy9LWEFMTEhqTXJrNXlCUEFGNDVwNlI5VEgxWEljeWdK?=
 =?utf-8?B?WktjenVZQU9PUUxxa0N0d1hwbCtrU3FvbDk2ODVKZ1JTNkgrTmRiRXJ4SVUy?=
 =?utf-8?B?NVVSclZEaThXRVpwUkZRWDBOa3dHNUpUR1NoVmRCMTZjRWdPRk9NUlVEVEhY?=
 =?utf-8?B?NFI4NkEvOG40TFNvYVRvUk1QZjBjbENVOHBiUjNpcFlLQjg3RGVlOTJXc2ww?=
 =?utf-8?B?MHFvQkJuenIxRkljWkFXVzIyVk5obW5JZ2tTM1E4RVZueUc3M3VPVWhNRU5o?=
 =?utf-8?B?TENGK2pHamJvYmFPUER5Z3BUL0VUU0xHRGZIdDNJTXcrYk5URlBZaFBHT3Ix?=
 =?utf-8?B?Qmw0LzVSbzNVR3lLTHFuRE1UK3Q1Zysva2dxZlo4VUZYOVZOMlh3MkNpTVow?=
 =?utf-8?Q?b1duQ5GR5WXcefmy9/+KPQ0=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dde889a3-99c7-4d84-bc69-08d9ebd8166b
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2022 14:25:57.2820
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: M6z076wAF90kp8K8IbIlbolXapzPgP6/Pw6lTYyYnIqVM71khL5NOEIW+tuwzoubVkQi/hV9V2B0BJDJyJynBA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6161

On 09.02.2022 14:12, Tu Dinh Ngoc wrote:
> Previously, Xen used information from the BDA to detect the amount of
> available low memory. This does not work on some scenarios such as
> Coreboot, or when booting from Kexec on a UEFI system without CSM.
> 
> Use the information directly supplied by Multiboot boot information
> instead.
> ---

Btw - please summarize here briefly what has changed from the earlier
version. As it stands your adjustment looks to take care of one third
of what I did say in reply to your v1. That's not enough for a v2, or
else you should have taken care of the remaining aspects verbally.

Jan

> --- a/xen/arch/x86/boot/head.S
> +++ b/xen/arch/x86/boot/head.S
> @@ -524,33 +524,23 @@ trampoline_bios_setup:
>          mov     %ecx,%fs
>          mov     %ecx,%gs
>  
> -        /* Set up trampoline segment 64k below EBDA */
> -        movzwl  0x40e,%ecx          /* EBDA segment */
> -        cmp     $0xa000,%ecx        /* sanity check (high) */
> -        jae     0f
> -        cmp     $0x4000,%ecx        /* sanity check (low) */
> -        jae     1f
> -0:
> -        movzwl  0x413,%ecx          /* use base memory size on failure */
> -        shl     $10-4,%ecx
> -1:
> +        /* Use lower memory size directly from Multiboot */
> +        mov     %edx,%ecx
>          /*
> -         * Compare the value in the BDA with the information from the
> -         * multiboot structure (if available) and use the smallest.
> +         * Old Kexec used to report the value in bytes instead of kilobytes
> +         * like it's supposed to, so fix that if detected.
>           */
> -        cmp     $0x100,%edx         /* is the multiboot value too small? */
> -        jb      2f                  /* if so, do not use it */
> -        shl     $10-4,%edx
> -        cmp     %ecx,%edx           /* compare with BDA value */
> -        cmovb   %edx,%ecx           /* and use the smaller */
> +        cmpl    $640,%ecx
> +        jbe     1f
> +        shr     $10,%ecx
> +1:
> +        /* From arch/x86/smpboot.c: start_eip had better be page-aligned! */
> +        shr     $2,%ecx
>  
> -2:
>          /* Reserve memory for the trampoline and the low-memory stack. */
> -        sub     $((TRAMPOLINE_SPACE+TRAMPOLINE_STACK_SPACE)>>4),%ecx
> +        sub     $((TRAMPOLINE_SPACE+TRAMPOLINE_STACK_SPACE)>>12),%ecx
>  
> -        /* From arch/x86/smpboot.c: start_eip had better be page-aligned! */
> -        xor     %cl, %cl
> -        shl     $4, %ecx
> +        shl     $12,%ecx
>          mov     %ecx,sym_esi(trampoline_phys)
>  
>  trampoline_setup:



From xen-devel-bounces@lists.xenproject.org Wed Feb 09 15:03:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 09 Feb 2022 15:03:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269264.463292 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHoV8-0006nA-2x; Wed, 09 Feb 2022 15:03:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269264.463292; Wed, 09 Feb 2022 15:03:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHoV7-0006n3-Vs; Wed, 09 Feb 2022 15:03:21 +0000
Received: by outflank-mailman (input) for mailman id 269264;
 Wed, 09 Feb 2022 15:03:21 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=lRsY=SY=epam.com=prvs=4039ed7fca=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nHoV6-0006mw-QR
 for xen-devel@lists.xenproject.org; Wed, 09 Feb 2022 15:03:21 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 68bb732e-89b9-11ec-8eb8-a37418f5ba1a;
 Wed, 09 Feb 2022 16:03:17 +0100 (CET)
Received: from pps.filterd (m0174677.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 219F12gr025011;
 Wed, 9 Feb 2022 15:03:06 GMT
Received: from eur02-he1-obe.outbound.protection.outlook.com
 (mail-he1eur02lp2059.outbound.protection.outlook.com [104.47.5.59])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e4fvn00ch-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 09 Feb 2022 15:03:05 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM0PR0302MB3283.eurprd03.prod.outlook.com (2603:10a6:208:12::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Wed, 9 Feb
 2022 15:02:27 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::dd31:2fad:89d:fa77%3]) with mapi id 15.20.4951.019; Wed, 9 Feb 2022
 15:02:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 68bb732e-89b9-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=WMvTXRBoTviS4EtcQ3DUr/r5F3UxZxoPApXnJcwP10etbyjrcgCN72hIfIlzOv2Xgp6WolVscx+kBpMS14EGV9PPQ74aKgSKW+a6MNZVx3xZE1s9Wo7wxU+AfW7g3x/8flg4cAe/kCdgUpF3MZodJzbZJO8p7hhiDdqbRLMUtK659sPU6rA/0VuamfB34h0/fV1VuAQsHGjocgswI5zFniDDshDsPq3oevTEYgZihZR3hiXqH7aEfvz8sCdt++lPn71hHyr0f0uBbFy4EJYVi3p5kcrsVnvWsFVLjfDcBPvGtAqQGnCRJ83shRkXId2Bu0f00e/zuTexIwMnzNoIBQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=k3bh9Hha+oszVmQjVq3j+Hpq0dedugKudceNOYwisVk=;
 b=Z4UaYHeYcXwIYvr7QdSN9h1yCHT+sTFLE+mON9N2ug3LgJ2xbswSmH8+VCQn4Ks0nLGpOMB5XfwLjffI2MuFxtXALb4z/75u58urCere65uEd1mJ/UKiqLSP61XoY6jF7/vmoV8EAwHQ49wvMbGz4oSBCmPhMpS/30StNJPQJqXwp7p9a97KxX+Sr27UUmqg8ZebZ+Uvu+o9nnI7VF9MVaG0Urj8k7ZGu0vBho476qJKNOvkXEOUCF6t6kFK7VA0z4MdjkQsQC4q798KAY3LXompE/nGjoCegUQD2qCpVEzfBH9E5DOWxJvBHyM+3jSWc2OZ8sA0Vm+affDBuZHE3Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=k3bh9Hha+oszVmQjVq3j+Hpq0dedugKudceNOYwisVk=;
 b=DQzCLRrkVAaJp72qExnz9kSppudfX9rCIJPVuuKqvI/OCqwOoDrKgPrZXci9gk4/UTsJPIEM+Af9bwopGhQhhTUnWY3S2LSHt1Cb9SJLEkKRzc6xAnT8ruDPIlHCdOMiKMEJ2GslIyPiB27vqri1s+0M5AYu8bTqhYhZE2tXhYaqJ1AoLk4OhQFT+rJVdX6QtOtzxkRxrZAPeLd4v1Ls74b5zdnDCKh1Hpxj+iNl5n3es+G2dUgRaqT97M2HQdJ9t+02tvj0pqjbzXMbtunN9IvA3QS7TY5EUyEEH5oTGf8obgrAVTMBd1q89CDqqsE+8GowMAZ7260la1fZfUSWYw==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>,
        "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Stefano Stabellini <sstabellini@kernel.org>,
        Julien Grall
	<julien@xen.org>,
        Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
        Bertrand
 Marquis <bertrand.marquis@arm.com>
Subject: Re: [RFC v2 5/8] xen/arm: introduce SCMI-SMC mediator driver
Thread-Topic: [RFC v2 5/8] xen/arm: introduce SCMI-SMC mediator driver
Thread-Index: AQHYHcYMJMe3TiqDv0yTLVzDKoRN9A==
Date: Wed, 9 Feb 2022 15:02:27 +0000
Message-ID: <1bfc6aa8-6252-e22a-4e10-6a5efdd15229@epam.com>
References: <cover.1644341635.git.oleksii_moisieiev@epam.com>
 <cb1493f5d9b5c3437268054b4a8e345cb35c8708.1644341635.git.oleksii_moisieiev@epam.com>
In-Reply-To: 
 <cb1493f5d9b5c3437268054b4a8e345cb35c8708.1644341635.git.oleksii_moisieiev@epam.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 735d5b04-64e2-4721-fb1a-08d9ebdd2fe6
x-ms-traffictypediagnostic: AM0PR0302MB3283:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM0PR0302MB3283464311BD139E5BB44B9AE72E9@AM0PR0302MB3283.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8882;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 hVqPMgPlGAQFqP+Z8zYC55x79XzRJ0MEpuCjYf5MWgiMSTYiS+GQtJX10ldUuDfr76Gap8k82b1T2t89O3nCAOJ+1wf8IgEF7dPwCgRV/Llq0dyBGmiY42AcEXpo28GuVuj56ULjQw+d2qMfldfqKGefevj8V7u184PyReeU+1GFPBOj1kOeJo+T4s7aTR8B0mvrvFHe3Tlfc6gnEw4hwxSKqXXKHciVSGZVQjV9RD2gaJ08Q7nDLR2SC7nYJEnebfSxN3NEQJfm304F9ebRt7Zg8ySkzp1aUy5ZnoFpTqa6R0UzyKHD6LUYpB3rv5BPT5KbNzzfWdiWydkBpMK8jPRT/jIvNapKozT5nWGvosJ3L0h6tYw+GN+WnLj0RrYw9fo6oc2iKMXVxcJo1yft4Rdkq7SNF6bUVIYIW7ZvK/Or+I9IejBvj0p/CbAj/v4qJE8WWYntSqLMw7C/NolGZFv8MgWNuHH77E0C7BrZ2EeMoHqKDrapWev0aiNAc3zvKBaWIPwl9RbJVU7i5f8QZvgZsPGEpmdPxzDLBPg0zbW7oECYqAVZOam5Ii1VJfUMWsStaJeP82/8iGTtCq3uITqEsAhu6NXIe6aBEddxxsei7bSMzhdoYuA6sC0Qwc8edlPX++eF7vM6hh9FgASdgpjPUuH3vUjoGoVMLj3QDxFHrjUvzGzXawl3c5bASf7BKkrLn4ePPnDQQDTG96vf8tZ6NFpjk6RTFn7bEt3bkCUCwIbsfvDaoVQpq/7PDwMtAfP8lrf4p+dWzTyO/m/jZ2rOGzjqS0nv4ANRIPnpKLAdKtM5Ocm2IygGMARXzQgS9FbJi6n5oT0E9h4uo2izCQ==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(110136005)(2906002)(86362001)(186003)(30864003)(31686004)(38100700002)(5660300002)(508600001)(54906003)(6486002)(26005)(122000001)(2616005)(36756003)(66476007)(38070700005)(53546011)(55236004)(8676002)(6512007)(6506007)(966005)(31696002)(76116006)(91956017)(4326008)(64756008)(66446008)(8936002)(66556008)(66946007)(83380400001)(71200400001)(316002)(2004002)(45980500001)(559001)(579004);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?eW8yVFpRSXVyalR0MjY1YmhlMnA5ZFBjc3VMMGFCM081dTZSSlowYkFUOG1l?=
 =?utf-8?B?YXJpWXY1MVhUSXJPOW1NbGxQeXI3OThPcWYzZC9xN0oya012Nnl3ZWNpTzVh?=
 =?utf-8?B?c2pkMDVTbW9OQVQ1V2xrdTNmME5rY1dlcGd0Y0hPdGhidXRnMmdJRUNneVpD?=
 =?utf-8?B?NFhib3l4aGY1SzhIaG5hMjd0MzZxbzFZWElYbXI5eFJnaDh5WW5zN3BSbEZP?=
 =?utf-8?B?aUk1L0dzVjFiYXdxakwxRnRrZTVSVHZ0Tzk1RW9LZXpMLzZFcTBlbHZJdkEx?=
 =?utf-8?B?Tk9WdUVLWEtjK0l1MFhpUVR6RGZlUWxyM1AxWkluZGM0L0wzSkUwNWhHRTR1?=
 =?utf-8?B?YmRHQi9zdGd5VndWSEUzd20xajAwWkd5bVlzaUVvbGJyZlA3aERHTTN4U2lL?=
 =?utf-8?B?SWg1WUpxZFJxUGsrSHBEV2RmcjhkRUJIdEoxWklMS253SFdFOGM3R0xIM0NC?=
 =?utf-8?B?YXo5dFM4NlMxMWhISzdpWEZoWlhpcGFPSXY5YTZDK1JwNlNpUWdXcjByZ2JT?=
 =?utf-8?B?VkN5aUVCUHM4WnpZREJBS1BObm9ZV05RZjl3bEJnY3NMZitmU1JPMnBoOXRR?=
 =?utf-8?B?TnlQanVIcExyWjJ1VlJDa01SK3huZGg3cXpIdzl5dlBWTDdqclhrUmpDUFRl?=
 =?utf-8?B?NkR1OEZpVnVPcUtkbE8wUkRyVm93Q3dCSXE1UElqSXAyNEdmakdWcnNBaTFS?=
 =?utf-8?B?YlN0dU10a3BBazZqSExIZ1lTYTRocTBHZ3FxWndYOGtCbjdCa3ZGUE1NYWlS?=
 =?utf-8?B?dU5ZcHJIVS9pcnRxbjNRUEhCc294bWdnVWtsdDhJVCtmY29xTEY5cDlpOEx2?=
 =?utf-8?B?K0ZNcGVCeFdDUGhURkpkelp5UzRZdU5xd1I1eDkrZE90cWE2M3ZOc25WTHhE?=
 =?utf-8?B?SGJWMDFISTZoWUZsdk5TbU9WUzU5RUxiUm82aDMwN1BCZWc1SS9yQk5Wdi9G?=
 =?utf-8?B?ZTRCMzk0b2dVVS9GeFduK2lrNTlMalF3Q1BCU0JjMDhsa216alZGU0tKQnll?=
 =?utf-8?B?U3pjd1JPeWdld1NJYmhGUjBieWE4WHBhQWc5aUxhWnpoQ3N0YU1NbUFRQzhU?=
 =?utf-8?B?RFpTKzd6K0JxR1QxdTJHLzVkUGVlZEJwSERwTnZ2UjFOWU5EdGVTbmVwQnhH?=
 =?utf-8?B?bmJxL3ZRSW5hR1Y4dkV0QTA1MjljNkhOQkdoQUg5RTlSUGdNNURxOFNiQWo5?=
 =?utf-8?B?OWJHd2FGQTgwV0E1N3MxM0d4RGQwVDJBNUl5SThud01hNGNubzhLaFBoUGxY?=
 =?utf-8?B?aEp3SUJyc0hkQkNoS1JibXRpVEphclcyNndwc1RhN3I4WEVmR3NhTzhDa3NY?=
 =?utf-8?B?aTJZZ1ltVGM3QWxjWGlHRmRHTGdER2VFd3V0ajJhVHVOYzN0ZTJzY2thdXJp?=
 =?utf-8?B?T2VBa1JucTdxMUNKR1FyWUZQSzI3TWMvT3B0eWtuZGQrWC9LaHIvUStjOXBt?=
 =?utf-8?B?V2hLcHJUUnllaE9kcTlOS0tERTdhWW9WZ0N0WUdEQ2grVk9uYytUMlN1MENE?=
 =?utf-8?B?STcycFR2ajFhYisxVTJuNFA2YUNTSnBubldaVHRZQ2NWWUU3aWt3RU4rc1pv?=
 =?utf-8?B?TFlPdzhwMTJPTXU3S3ZNL2oyQk91RHZYbjlFUmNHUld1Vms0MTFuWkF4NEJ6?=
 =?utf-8?B?dEdkTjNyaHF2cWpqckZZY1djOFhDcGJVc1dDZ0FSYkdUUDhRa0pnSThJZTBr?=
 =?utf-8?B?K1lsQVp3ckhkN3lJQ3FnMytvU25BNzZRaVdzY1dTamRjUVhMaXBPUllGTVIw?=
 =?utf-8?B?Q25SbC9VTUd1NjJvR3JuaHJYbHl5NFFyaWszdWVnZ0VqV2ovY29Cb0JlaDVi?=
 =?utf-8?B?ZE5IczhoZ2xSK1pBb1JwVWNQOHVzRERrL1BnRjB3NnF4YnFROHYrQ1BHS25Y?=
 =?utf-8?B?ZmdqRWZDa2JQZWUyZ3p0SWhwWDRrU0FOWDhNWmlvcnhxSm5BVytVVEhacW5D?=
 =?utf-8?B?cC9xTDIvWXhTNVphWTByOFZ0Y3RpY1lIdkpuOXhzRm05S0F2b3NOdWt3N1R4?=
 =?utf-8?B?TnhzbUtDU2F2aGdEWmN4bXdTTE9neW5kUXd2dURqV1Q3bGxQa0lGODRDWVA4?=
 =?utf-8?B?dFUveVY0Um0vYVFWYzRiQXczakkyS2MrVHdiUzVxWXhnN0NuZHk0eEw4anR2?=
 =?utf-8?B?SlV0TjR2aDNFVHQwenZnTmM5UDRwSkRGMGFFQ2NjTVlsREppRmluOVdTcnds?=
 =?utf-8?B?MGxKLyt5bGNvS1BCYys4Mm1BSmpHT2N1MVUrM2d5ZmROSnplamdLYkF0NGVD?=
 =?utf-8?B?ZkR5MTVzUzFkLzc2VzdhbFFJZ2VjVDNac09mdlEyeG9oY3FrYVZWUWtBSk4x?=
 =?utf-8?B?VDR4VXZ4ZHVBbUEzMkN4UFM0NTllZUFWQ3dpbjJmMFhqNERoazVYZz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <70E9EFD781FDC64A84F2A235E0209DE3@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 735d5b04-64e2-4721-fb1a-08d9ebdd2fe6
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Feb 2022 15:02:27.2664
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: +f13suiUnZzWLZs8Eo/B4ug50C+QSfjtzJCxZ3UYkjjS39k60z4Lpym7XAfIcfk3l4i7r7ZUapt2Mf2gDdETgm8NtvEoDJ0/Idsc3Dz6O5LwGHRDbXlHcbzFEm1PNRG/
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0302MB3283
X-Proofpoint-ORIG-GUID: 9v1amBdOHEysg96HfctxxFpm_5gPmX5K
X-Proofpoint-GUID: 9v1amBdOHEysg96HfctxxFpm_5gPmX5K
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-09_08,2022-02-09_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 suspectscore=0
 mlxlogscore=999 spamscore=0 adultscore=0 clxscore=1015 impostorscore=0
 priorityscore=1501 phishscore=0 bulkscore=0 malwarescore=0
 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202090085

SGksIE9sZWtzaWkhDQoNCk9uIDA4LjAyLjIyIDIwOjAwLCBPbGVrc2lpIE1vaXNpZWlldiB3cm90
ZToNCj4gVGhpcyBpcyB0aGUgaW1wbGVtZW50YXRpb24gb2YgU0NJIGludGVyZmFjZSwgY2FsbGVk
IFNDTUktU01DIGRyaXZlciwNCj4gd2hpY2ggd29ya3MgYXMgdGhlIG1lZGlhdG9yIGJldHdlZW4g
WEVOIERvbWFpbnMgYW5kIEZpcm13YXJlIChTQ1AsIEFURiBldGMpLg0KPiBUaGlzIGFsbG93cyBk
ZXZpY2VzIGZyb20gdGhlIERvbWFpbnMgdG8gd29yayB3aXRoIGNsb2NrcywgcmVzZXRzIGFuZA0K
PiBwb3dlci1kb21haW5zIHdpdGhvdXQgYWNjZXNzIHRvIENQRy4NCj4NCj4gT3JpZ2luYWxseSwg
Y3BnIHNob3VsZCBiZSBwYXNzZWQgdG8gdGhlIGRvbWFpbiBzbyBpdCBjYW4gd29yayB3aXRoDQo+
IHBvd2VyLWRvbWFpbnMvY2xvY2tzL3Jlc2V0cyBldGMuIENvbnNpZGVyaW5nIHRoYXQgY3BnIGNh
bid0IGJlIHNwbGl0IGJldHdlZW4NCj4gdGhlIERvbWFpbnMsIHdlIGdldCB0aGUgbGltaXRhdGlv
biB0aGF0IHRoZSBkZXZpY2VzLCB3aGljaCBhcmUgdXNpbmcNCj4gcG93ZXItZG9tYWlucy9jbG9j
a3MvcmVzZXRzIGV0YywgY291bGRuJ3QgYmUgc3BsaXQgYmV0d2VlbiB0aGUgZG9tYWlucy4NCj4g
VGhlIHNvbHV0aW9uIGlzIHRvIG1vdmUgdGhlIHBvd2VyLWRvbWFpbi9jbG9jay9yZXNldHMgZXRj
IHRvIHRoZQ0KPiBGaXJtd2FyZSAoc3VjaCBhcyBTQ1AgZmlybXdhcmUgb3IgQVRGKSBhbmQgcHJv
dmlkZSBpbnRlcmZhY2UgZm9yIHRoZQ0KPiBEb21haW5zLiBYRU4gc2hvdWxkIGhhdmUgYW4gZW50
aXR5LCBjYWxlZCBTQ0ktTWVkaWF0b3IsIHdoaWNoIGlzDQo+IHJlc3BvbnNpYmxlIGZvciBtZXNz
YWdlcyByZWRpcmVjdGlvbiBiZXR3ZWVuIERvbWFpbnMgYW5kIEZpcm13YXJlIGFuZA0KPiBmb3Ig
cGVybWlzc2lvbiBoYW5kbGluZy4NCj4NCj4gVGhlIGZvbGxvd2luZyBmZWF0dXJlcyBhcmUgaW1w
bGVtZW50ZWQ6DQo+IC0gcmVxdWVzdCBTQ01JIGNoYW5uZWxzIGZyb20gQVRGIGFuZCBwYXNzIGNo
YW5uZWxzIHRvIERvbWFpbnM7DQo+IC0gc2V0IGRldmljZSBwZXJtaXNzaW9ucyBmb3IgRG9tYWlu
cyBiYXNlZCBvbiB0aGUgRG9tYWluIHBhcnRpYWwNCj4gZGV2aWNlLXRyZWUuIERldmljZXMgd2l0
aCBwZXJtaXNzaW9ucyBhcmUgYWJsZSB0byB3b3JrIHdpdGggY2xvY2tzLA0KPiByZXNldHMgYW5k
IHBvd2VyLWRvbWFpbnMgdmlhIFNDTUk7DQo+IC0gcmVkaXJlY3Qgc2NtaSBtZXNzYWdlcyBmcm9t
IERvbWFpbnMgdG8gQVRGLg0KPg0KPiBTaWduZWQtb2ZmLWJ5OiBPbGVrc2lpIE1vaXNpZWlldiA8
b2xla3NpaV9tb2lzaWVpZXZAZXBhbS5jb20+DQo+IC0tLQ0KPiAgIHhlbi9hcmNoL2FybS9LY29u
ZmlnICAgICAgICB8ICAgMiArDQo+ICAgeGVuL2FyY2gvYXJtL3NjaS9LY29uZmlnICAgIHwgIDEw
ICsNCj4gICB4ZW4vYXJjaC9hcm0vc2NpL3NjbWlfc21jLmMgfCA5NTkgKysrKysrKysrKysrKysr
KysrKysrKysrKysrKysrKysrKysrDQo+ICAgMyBmaWxlcyBjaGFuZ2VkLCA5NzEgaW5zZXJ0aW9u
cygrKQ0KPiAgIGNyZWF0ZSBtb2RlIDEwMDY0NCB4ZW4vYXJjaC9hcm0vc2NpL0tjb25maWcNCj4g
ICBjcmVhdGUgbW9kZSAxMDA2NDQgeGVuL2FyY2gvYXJtL3NjaS9zY21pX3NtYy5jDQo+DQo+IGRp
ZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vS2NvbmZpZyBiL3hlbi9hcmNoL2FybS9LY29uZmlnDQo+
IGluZGV4IGFiMDc4MzM1ODIuLjNiMGRmYzU3YjYgMTAwNjQ0DQo+IC0tLSBhL3hlbi9hcmNoL2Fy
bS9LY29uZmlnDQo+ICsrKyBiL3hlbi9hcmNoL2FybS9LY29uZmlnDQo+IEBAIC0xMjMsNiArMTIz
LDggQEAgY29uZmlnIEFSTV9TQ0kNCj4gICAJICBzdXBwb3J0LiBJdCBhbGxvd3MgZ3Vlc3RzIHRv
IGNvbnRyb2wgc3lzdGVtIHJlc291cmNlc3MgdmlhIG9uZSBvZg0KPiAgIAkgIEFSTV9TQ0kgbWVk
aWF0b3JzIGltcGxlbWVudGVkIGluIFhFTi4NCj4gICANCj4gKwlzb3VyY2UgImFyY2gvYXJtL3Nj
aS9LY29uZmlnIg0KPiArDQo+ICAgZW5kbWVudQ0KPiAgIA0KPiAgIG1lbnUgIkFSTSBlcnJhdGEg
d29ya2Fyb3VuZCB2aWEgdGhlIGFsdGVybmF0aXZlIGZyYW1ld29yayINCj4gZGlmZiAtLWdpdCBh
L3hlbi9hcmNoL2FybS9zY2kvS2NvbmZpZyBiL3hlbi9hcmNoL2FybS9zY2kvS2NvbmZpZw0KPiBu
ZXcgZmlsZSBtb2RlIDEwMDY0NA0KPiBpbmRleCAwMDAwMDAwMDAwLi4xMGI2MzRkMmVkDQo+IC0t
LSAvZGV2L251bGwNCj4gKysrIGIveGVuL2FyY2gvYXJtL3NjaS9LY29uZmlnDQo+IEBAIC0wLDAg
KzEsMTAgQEANCj4gK2NvbmZpZyBTQ01JX1NNQw0KPiArCWJvb2wgIkVuYWJsZSBTQ01JLVNNQyBt
ZWRpYXRvciBkcml2ZXIiDQo+ICsJZGVmYXVsdCBuDQo+ICsJZGVwZW5kcyBvbiBBUk1fU0NJICYm
IEhPU1RfRFRCX0VYUE9SVA0KPiArCS0tLWhlbHAtLS0NCj4gKw0KPiArCUVuYWJsZXMgbWVkaWF0
b3IgaW4gWEVOIHRvIHBhc3MgU0NNSSByZXF1ZXN0cyBmcm9tIERvbWFpbnMgdG8gQVRGLg0KPiAr
CVRoaXMgZmVhdHVyZSBhbGxvd3MgZHJpdmVycyBmcm9tIERvbWFpbnMgdG8gd29yayB3aXRoIFN5
c3RlbQ0KPiArCUNvbnRyb2xsZXJzIChzdWNoIGFzIHBvd2VyLHJlc2V0cyxjbG9jayBldGMuKS4g
U0NQIGlzIHVzZWQgYXMgdHJhbnNwb3J0DQo+ICsJZm9yIGNvbW11bmljYXRpb24uDQo+IGRpZmYg
LS1naXQgYS94ZW4vYXJjaC9hcm0vc2NpL3NjbWlfc21jLmMgYi94ZW4vYXJjaC9hcm0vc2NpL3Nj
bWlfc21jLmMNCj4gbmV3IGZpbGUgbW9kZSAxMDA2NDQNCj4gaW5kZXggMDAwMDAwMDAwMC4uMTAz
NTI5ZGZhYg0KPiAtLS0gL2Rldi9udWxsDQo+ICsrKyBiL3hlbi9hcmNoL2FybS9zY2kvc2NtaV9z
bWMuYw0KPiBAQCAtMCwwICsxLDk1OSBAQA0KPiArLyoNCj4gKyAqIHhlbi9hcmNoL2FybS9zY2kv
c2NtaV9zbWMuYw0KPiArICoNCj4gKyAqIFNDTUkgbWVkaWF0b3IgZHJpdmVyLCB1c2luZyBTQ1Ag
YXMgdHJhbnNwb3J0Lg0KPiArICoNCj4gKyAqIE9sZWtzaWkgTW9pc2llaWV2IDxvbGVrc2lpX21v
aXNpZWlldkBlcGFtLmNvbT4NCj4gKyAqIENvcHlyaWdodCAoQykgMjAyMSwgRVBBTSBTeXN0ZW1z
Lg0KPiArICoNCj4gKyAqIFRoaXMgcHJvZ3JhbSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJl
ZGlzdHJpYnV0ZSBpdCBhbmQvb3IgbW9kaWZ5DQo+ICsgKiBpdCB1bmRlciB0aGUgdGVybXMgb2Yg
dGhlIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGFzIHB1Ymxpc2hlZCBieQ0KPiArICogdGhl
IEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbjsgZWl0aGVyIHZlcnNpb24gMiBvZiB0aGUgTGljZW5z
ZSwgb3INCj4gKyAqIChhdCB5b3VyIG9wdGlvbikgYW55IGxhdGVyIHZlcnNpb24uDQo+ICsgKg0K
PiArICogVGhpcyBwcm9ncmFtIGlzIGRpc3RyaWJ1dGVkIGluIHRoZSBob3BlIHRoYXQgaXQgd2ls
bCBiZSB1c2VmdWwsDQo+ICsgKiBidXQgV0lUSE9VVCBBTlkgV0FSUkFOVFk7IHdpdGhvdXQgZXZl
biB0aGUgaW1wbGllZCB3YXJyYW50eSBvZg0KPiArICogTUVSQ0hBTlRBQklMSVRZIG9yIEZJVE5F
U1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQT1NFLiAgU2VlIHRoZQ0KPiArICogR05VIEdlbmVyYWwg
UHVibGljIExpY2Vuc2UgZm9yIG1vcmUgZGV0YWlscy4NCj4gKyAqLw0KPiArDQo+ICsjaW5jbHVk
ZSA8YXNtL3NjaS9zY2kuaD4NCj4gKyNpbmNsdWRlIDxhc20vc21jY2MuaD4NCj4gKyNpbmNsdWRl
IDxhc20vaW8uaD4NCj4gKyNpbmNsdWRlIDx4ZW4vYml0b3BzLmg+DQo+ICsjaW5jbHVkZSA8eGVu
L2NvbmZpZy5oPg0KPiArI2luY2x1ZGUgPHhlbi9zY2hlZC5oPg0KPiArI2luY2x1ZGUgPHhlbi9k
ZXZpY2VfdHJlZS5oPg0KPiArI2luY2x1ZGUgPHhlbi9pb2NhcC5oPg0KPiArI2luY2x1ZGUgPHhl
bi9pbml0Lmg+DQo+ICsjaW5jbHVkZSA8eGVuL2Vyci5oPg0KPiArI2luY2x1ZGUgPHhlbi9saWIu
aD4NCj4gKyNpbmNsdWRlIDx4ZW4vbGlzdC5oPg0KPiArI2luY2x1ZGUgPHhlbi9tbS5oPg0KPiAr
I2luY2x1ZGUgPHhlbi9zdHJpbmcuaD4NCj4gKyNpbmNsdWRlIDx4ZW4vdGltZS5oPg0KPiArI2lu
Y2x1ZGUgPHhlbi92bWFwLmg+DQo+ICsNCj4gKyNkZWZpbmUgU0NNSV9CQVNFX1BST1RPQ09MICAg
ICAgICAgICAgICAgICAgMHgxMA0KPiArI2RlZmluZSBTQ01JX0JBU0VfUFJPVE9DT0xfQVRUSUJV
VEVTICAgICAgICAweDENCj4gKyNkZWZpbmUgU0NNSV9CQVNFX1NFVF9ERVZJQ0VfUEVSTUlTU0lP
TlMgICAgMHg5DQo+ICsjZGVmaW5lIFNDTUlfQkFTRV9SRVNFVF9BR0VOVF9DT05GSUdVUkFUSU9O
IDB4Qg0KPiArI2RlZmluZSBTQ01JX0JBU0VfRElTQ09WRVJfQUdFTlQgICAgICAgICAgICAweDcN
CkNhbiB0aGUgYWJvdmUgYmUgc29ydGVkPw0KPiArDQo+ICsvKiBTQ01JIHJldHVybiBjb2Rlcy4g
U2VlIHNlY3Rpb24gNC4xLjQgb2YgU0NNSSBzcGVjIChERU4wMDU2QykgKi8NCj4gKyNkZWZpbmUg
U0NNSV9TVUNDRVNTICAgICAgICAgICAgICAwDQo+ICsjZGVmaW5lIFNDTUlfTk9UX1NVUFBPUlRF
RCAgICAgICgtMSkNCj4gKyNkZWZpbmUgU0NNSV9JTlZBTElEX1BBUkFNRVRFUlMgKC0yKQ0KPiAr
I2RlZmluZSBTQ01JX0RFTklFRCAgICAgICAgICAgICAoLTMpDQo+ICsjZGVmaW5lIFNDTUlfTk9U
X0ZPVU5EICAgICAgICAgICgtNCkNCj4gKyNkZWZpbmUgU0NNSV9PVVRfT0ZfUkFOR0UgICAgICAg
KC01KQ0KPiArI2RlZmluZSBTQ01JX0JVU1kgICAgICAgICAgICAgICAoLTYpDQo+ICsjZGVmaW5l
IFNDTUlfQ09NTVNfRVJST1IgICAgICAgICgtNykNCj4gKyNkZWZpbmUgU0NNSV9HRU5FUklDX0VS
Uk9SICAgICAgKC04KQ0KPiArI2RlZmluZSBTQ01JX0hBUkRXQVJFX0VSUk9SICAgICAoLTkpDQo+
ICsjZGVmaW5lIFNDTUlfUFJPVE9DT0xfRVJST1IgICAgICgtMTApDQo+ICsNCj4gKyNkZWZpbmUg
RFRfTUFUQ0hfU0NNSV9TTUMgRFRfTUFUQ0hfQ09NUEFUSUJMRSgiYXJtLHNjbWktc21jIikNCj4g
Kw0KPiArI2RlZmluZSBTQ01JX1NNQ19JRCAgICAgICAgICAgICAgICAgICAgICAgICJhcm0sc21j
LWlkIg0KPiArI2RlZmluZSBTQ01JX1NIQVJFRF9NRU1PUlkgICAgICAgICAgICAgICAgICJhcm0s
c2NtaS1zaG1lbSINCj4gKyNkZWZpbmUgU0NNSV9TSE1FTSAgICAgICAgICAgICAgICAgICAgICAg
ICAic2htZW0iDQo+ICsjZGVmaW5lIFNDTUlfU0hNRU1fTUFQUEVEX1NJWkUgICAgICAgICAgICAg
UEFHRV9TSVpFDQo+ICsNCj4gKyNkZWZpbmUgSFlQX0NIQU5ORUwgICAgICAgICAgICAgICAgICAg
ICAgICAgIDB4MA0KQWxpZ25tZW50DQo+ICsNCj4gKyNkZWZpbmUgSERSX0lEICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICBHRU5NQVNLKDcsMCkNCj4gKyNkZWZpbmUgSERSX1RZUEUgICAgICAg
ICAgICAgICAgICAgICAgICAgICBHRU5NQVNLKDksIDgpDQo+ICsjZGVmaW5lIEhEUl9QUk9UTyAg
ICAgICAgICAgICAgICAgICAgICAgICAgR0VOTUFTSygxNywgMTApDQo+ICsNCj4gKy8qIFNDTUkg
cHJvdG9jb2wsIHJlZmVyIHRvIHNlY3Rpb24gNC4yLjIuMiAoREVOMDA1NkMpICovDQo+ICsjZGVm
aW5lIE1TR19OX0FHRU5UU19NQVNLICAgICAgICAgICAgICAgICAgR0VOTUFTSygxNSwgOCkNCj4g
Kw0KPiArI2RlZmluZSBGSUVMRF9HRVQoX21hc2ssIF9yZWcpXA0KPiArICAgICgodHlwZW9mKF9t
YXNrKSkoKChfcmVnKSAmIChfbWFzaykpID4+IChmZnM2NChfbWFzaykgLSAxKSkpDQo+ICsjZGVm
aW5lIEZJRUxEX1BSRVAoX21hc2ssIF92YWwpXA0KPiArICAgICgoKHR5cGVvZihfbWFzaykpKF92
YWwpIDw8IChmZnM2NChfbWFzaykgLSAxKSkgJiAoX21hc2spKQ0KPiArDQo+ICt0eXBlZGVmIHN0
cnVjdCBzY21pX21zZ19oZWFkZXIgew0KPiArICAgIHVpbnQ4X3QgaWQ7DQo+ICsgICAgdWludDhf
dCB0eXBlOw0KPiArICAgIHVpbnQ4X3QgcHJvdG9jb2w7DQo+ICt9IHNjbWlfbXNnX2hlYWRlcl90
Ow0KPiArDQo+ICsjZGVmaW5lIFNDTUlfU0hNRU1fQ0hBTl9TVEFUX0NIQU5ORUxfRlJFRSAgIEJJ
VCgwLCBVTCkNCj4gKyNkZWZpbmUgU0NNSV9TSE1FTV9DSEFOX1NUQVRfQ0hBTk5FTF9FUlJPUiAg
QklUKDEsIFVMKQ0KPiArDQo+ICsjZGVmaW5lIFNDTUlfQUxMT1dfQUNDRVNTICAgICAgICAgICAg
ICAgICAgIEJJVCgwLCBVTCkNCj4gKw0KPiArc3RydWN0IHNjbWlfc2hhcmVkX21lbSB7DQo+ICsg
ICAgdWludDMyX3QgcmVzZXJ2ZWQ7DQo+ICsgICAgdWludDMyX3QgY2hhbm5lbF9zdGF0dXM7DQo+
ICsgICAgdWludDMyX3QgcmVzZXJ2ZWQxWzJdOw0KPiArICAgIHVpbnQzMl90IGZsYWdzOw0KPiAr
ICAgIHVpbnQzMl90IGxlbmd0aDsNCj4gKyAgICB1aW50MzJfdCBtc2dfaGVhZGVyOw0KPiArICAg
IHVpbnQ4X3QgbXNnX3BheWxvYWRbXTsNCj4gK307DQo+ICsNCj4gK3N0cnVjdCBkdF9jaGFubmVs
X2FkZHIgew0KPiArICAgIHU2NCBhZGRyOw0KPiArICAgIHU2NCBzaXplOw0KSGVyZSBhbmQgZWxz
ZXdoZXJlOiBkbyBub3QgdXNlIHVYWCBpbiBuZXcgY29kZQ0KYW5kIHVzZSB1aW50WFhfdCBpbnN0
ZWFkDQo+ICsgICAgc3RydWN0IGxpc3RfaGVhZCBsaXN0Ow0KPiArfTsNCj4gKw0KPiArc3RydWN0
IHNjbWlfY2hhbm5lbCB7DQo+ICsgICAgaW50IGNoYW5faWQ7DQo+ICsgICAgaW50IGFnZW50X2lk
Ow0KQ2FuIHRoZXNlIGJlIHVuc2lnbmVkIGludD8NCkJlbG93IGluIGdldF9jaGFubmVsX2J5X2lk
IHlvdSBoYXZlIGl0IGFzIHVpbnQ4X3QgY2hhbl9pZC4uLg0KPiArICAgIHVpbnQzMl90IGZ1bmNf
aWQ7DQo+ICsgICAgZG9taWRfdCBkb21haW5faWQ7DQo+ICsgICAgdWludDY0X3QgcGFkZHI7DQo+
ICsgICAgdWludDY0X3QgbGVuOw0KPiArICAgIHN0cnVjdCBzY21pX3NoYXJlZF9tZW0gKnNobWVt
Ow0KPiArICAgIHNwaW5sb2NrX3QgbG9jazsNCj4gKyAgICBzdHJ1Y3QgbGlzdF9oZWFkIGxpc3Q7
DQo+ICt9Ow0KPiArDQo+ICtzdHJ1Y3Qgc2NtaV9kYXRhIHsNCj4gKyAgICBzdHJ1Y3QgbGlzdF9o
ZWFkIGNoYW5uZWxfbGlzdDsNCj4gKyAgICBzcGlubG9ja190IGNoYW5uZWxfbGlzdF9sb2NrOw0K
PiArICAgIGJvb2wgaW5pdGlhbGl6ZWQ7DQo+ICt9Ow0KPiArDQo+ICtzdGF0aWMgc3RydWN0IHNj
bWlfZGF0YSBzY21pX2RhdGE7DQo+ICsNCj4gKw0KPiArLyoNCj4gKyAqIHBhY2tfc2NtaV9oZWFk
ZXIoKSAtIHBhY2tzIGFuZCByZXR1cm5zIDMyLWJpdCBoZWFkZXINCj4gKyAqDQo+ICsgKiBAaGRy
OiBwb2ludGVyIHRvIGhlYWRlciBjb250YWluaW5nIGFsbCB0aGUgaW5mb3JtYXRpb24gb24gbWVz
c2FnZSBpZCwNCj4gKyAqICAgIHByb3RvY29sIGlkIGFuZCB0eXBlIGlkLg0KPiArICoNCj4gKyAq
IFJldHVybjogMzItYml0IHBhY2tlZCBtZXNzYWdlIGhlYWRlciB0byBiZSBzZW50IHRvIHRoZSBw
bGF0Zm9ybS4NCj4gKyAqLw0KPiArc3RhdGljIGlubGluZSB1aW50MzJfdCBwYWNrX3NjbWlfaGVh
ZGVyKHNjbWlfbXNnX2hlYWRlcl90ICpoZHIpDQpVc2Ugb2YgaW5saW5lIGlzIGRvdWJ0ZnVsLCBw
bGVhc2Ugc2VlIFsxXQ0KPiArew0KPiArICAgIHJldHVybiBGSUVMRF9QUkVQKEhEUl9JRCwgaGRy
LT5pZCkgfA0KPiArICAgICAgICBGSUVMRF9QUkVQKEhEUl9UWVBFLCBoZHItPnR5cGUpIHwNCj4g
KyAgICAgICAgRklFTERfUFJFUChIRFJfUFJPVE8sIGhkci0+cHJvdG9jb2wpOw0KPiArfQ0KPiAr
DQo+ICsvKg0KPiArICogdW5wYWNrX3NjbWlfaGVhZGVyKCkgLSB1bnBhY2tzIGFuZCByZWNvcmRz
IG1lc3NhZ2UgYW5kIHByb3RvY29sIGlkDQo+ICsgKg0KPiArICogQG1zZ19oZHI6IDMyLWJpdCBw
YWNrZWQgbWVzc2FnZSBoZWFkZXIgc2VudCBmcm9tIHRoZSBwbGF0Zm9ybQ0KPiArICogQGhkcjog
cG9pbnRlciB0byBoZWFkZXIgdG8gZmV0Y2ggbWVzc2FnZSBhbmQgcHJvdG9jb2wgaWQuDQo+ICsg
Ki8NCj4gK3N0YXRpYyBpbmxpbmUgdm9pZCB1bnBhY2tfc2NtaV9oZWFkZXIodWludDMyX3QgbXNn
X2hkciwgc2NtaV9tc2dfaGVhZGVyX3QgKmhkcikNCj4gK3sNCj4gKyAgICBoZHItPmlkID0gRklF
TERfR0VUKEhEUl9JRCwgbXNnX2hkcik7DQo+ICsgICAgaGRyLT50eXBlID0gRklFTERfR0VUKEhE
Ul9UWVBFLCBtc2dfaGRyKTsNCj4gKyAgICBoZHItPnByb3RvY29sID0gRklFTERfR0VUKEhEUl9Q
Uk9UTywgbXNnX2hkcik7DQo+ICt9DQo+ICsNCj4gK3N0YXRpYyBpbmxpbmUgaW50IGNoYW5uZWxf
aXNfZnJlZShzdHJ1Y3Qgc2NtaV9jaGFubmVsICpjaGFuX2luZm8pDQo+ICt7DQo+ICsgICAgcmV0
dXJuICggY2hhbl9pbmZvLT5zaG1lbS0+Y2hhbm5lbF9zdGF0dXMNCj4gKyAgICAgICAgICAgICYg
U0NNSV9TSE1FTV9DSEFOX1NUQVRfQ0hBTk5FTF9GUkVFICkgPyAwIDogLUVCVVNZOw0KPiArfQ0K
PiArDQo+ICsvKg0KPiArICogQ29weSBkYXRhIGZyb20gSU8gbWVtb3J5IHNwYWNlIHRvICJyZWFs
IiBtZW1vcnkgc3BhY2UuDQo+ICsgKi8NCj4gK3ZvaWQgX19tZW1jcHlfZnJvbWlvKHZvaWQgKnRv
LCBjb25zdCB2b2xhdGlsZSB2b2lkIF9faW9tZW0gKmZyb20sIHNpemVfdCBjb3VudCkNClRoaXMg
c2VlbXMgdG8gYmUgYSBjb3B5IG9mIFsyXS4NCldlIHNob3VsZCB0aGluayBhYm91dCBtb3Zpbmcg
dGhpcyBpbnRvIGEgZGVkaWNhdGVkIGZpbGUgbGlrZSBpbiBMaW51eCwNCnByZXNlcnZpbmcgdGhl
IGF1dGhvcnNoaXArDQo+ICt7DQo+ICsgICAgd2hpbGUgKGNvdW50ICYmICFJU19BTElHTkVEKCh1
bnNpZ25lZCBsb25nKWZyb20sIDQpKSB7DQo+ICsgICAgICAgICoodTggKil0byA9IF9fcmF3X3Jl
YWRiKGZyb20pOw0KPiArICAgICAgICBmcm9tKys7DQo+ICsgICAgICAgIHRvKys7DQo+ICsgICAg
ICAgIGNvdW50LS07DQo+ICsgICAgfQ0KPiArDQo+ICsgICAgd2hpbGUgKGNvdW50ID49IDQpIHsN
Cj4gKyAgICAgICAgKih1MzIgKil0byA9IF9fcmF3X3JlYWRsKGZyb20pOw0KPiArICAgICAgICBm
cm9tICs9IDQ7DQo+ICsgICAgICAgIHRvICs9IDQ7DQo+ICsgICAgICAgIGNvdW50IC09IDQ7DQo+
ICsgICAgfQ0KPiArDQo+ICsgICAgd2hpbGUgKGNvdW50KSB7DQo+ICsgICAgICAgICoodTggKil0
byA9IF9fcmF3X3JlYWRiKGZyb20pOw0KPiArICAgICAgICBmcm9tKys7DQo+ICsgICAgICAgIHRv
Kys7DQo+ICsgICAgICAgIGNvdW50LS07DQo+ICsgICAgfQ0KPiArfQ0KPiArDQo+ICsvKg0KPiAr
ICogQ29weSBkYXRhIGZyb20gInJlYWwiIG1lbW9yeSBzcGFjZSB0byBJTyBtZW1vcnkgc3BhY2Uu
DQo+ICsgKi8NCj4gK3ZvaWQgX19tZW1jcHlfdG9pbyh2b2xhdGlsZSB2b2lkIF9faW9tZW0gKnRv
LCBjb25zdCB2b2lkICpmcm9tLCBzaXplX3QgY291bnQpDQo+ICt7DQo+ICsgICAgd2hpbGUgKGNv
dW50ICYmICFJU19BTElHTkVEKCh1bnNpZ25lZCBsb25nKXRvLCA0KSkgew0KPiArICAgICAgICBf
X3Jhd193cml0ZWIoKih1OCAqKWZyb20sIHRvKTsNCj4gKyAgICAgICAgZnJvbSsrOw0KPiArICAg
ICAgICB0bysrOw0KPiArICAgICAgICBjb3VudC0tOw0KPiArICAgIH0NCj4gKw0KPiArICAgIHdo
aWxlIChjb3VudCA+PSA0KSB7DQo+ICsgICAgICAgIF9fcmF3X3dyaXRlbCgqKHUzMiAqKWZyb20s
IHRvKTsNCj4gKyAgICAgICAgZnJvbSArPSA0Ow0KPiArICAgICAgICB0byArPSA0Ow0KPiArICAg
ICAgICBjb3VudCAtPSA0Ow0KPiArICAgIH0NCj4gKw0KPiArICAgIHdoaWxlIChjb3VudCkgew0K
PiArICAgICAgICBfX3Jhd193cml0ZWIoKih1OCAqKWZyb20sIHRvKTsNCj4gKyAgICAgICAgZnJv
bSsrOw0KPiArICAgICAgICB0bysrOw0KPiArICAgICAgICBjb3VudC0tOw0KPiArICAgIH0NCj4g
K30NCj4gKw0KPiArc3RhdGljIGludCBzZW5kX3NtY19tZXNzYWdlKHN0cnVjdCBzY21pX2NoYW5u
ZWwgKmNoYW5faW5mbywNCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICBzY21pX21zZ19o
ZWFkZXJfdCAqaGRyLCB2b2lkICpkYXRhLCBpbnQgbGVuKQ0KPiArew0KPiArICAgIHN0cnVjdCBh
cm1fc21jY2NfcmVzIHJlc3A7DQo+ICsgICAgaW50IHJldDsNCj4gKw0KPiArICAgIGlmICggKGxl
biArIHNpemVvZihjaGFuX2luZm8tPnNobWVtLT5tc2dfaGVhZGVyKSkgPg0KPiArICAgICAgICAg
ICAgICAgICAgICAgICAgIFNDTUlfU0hNRU1fTUFQUEVEX1NJWkUgKQ0KPiArICAgIHsNCj4gKyAg
ICAgICAgcHJpbnRrKFhFTkxPR19FUlINCj4gKyAgICAgICAgICAgICAgICJzY21pOiBXcm9uZyBz
aXplIG9mIHNtYyBtZXNzYWdlLiBEYXRhIGlzIGludmFsaWRcbiIpOw0KPiArICAgICAgICByZXR1
cm4gLUVJTlZBTDsNCj4gKyAgICB9DQo+ICsNCj4gKyAgICBwcmludGsoWEVOTE9HX0RFQlVHICJz
Y21pOiBzdGF0dXMgPSVkIGxlbj0lZFxuIiwNCj4gKyAgICAgICAgICAgY2hhbl9pbmZvLT5zaG1l
bS0+Y2hhbm5lbF9zdGF0dXMsIGxlbik7DQo+ICsgICAgcHJpbnRrKFhFTkxPR19ERUJVRyAic2Nt
aTogaGVhZGVyIGlkID0gJWQgdHlwZSA9ICVkLCBwcm90byA9ICVkXG4iLA0KPiArICAgICAgICAg
ICBoZHItPmlkLCBoZHItPnR5cGUsIGhkci0+cHJvdG9jb2wpOw0KPiArDQo+ICsgICAgcmV0ID0g
Y2hhbm5lbF9pc19mcmVlKGNoYW5faW5mbyk7DQo+ICsgICAgaWYgKCBJU19FUlJfVkFMVUUocmV0
KSApDQo+ICsgICAgICAgIHJldHVybiByZXQ7DQo+ICsNCj4gKyAgICBjaGFuX2luZm8tPnNobWVt
LT5jaGFubmVsX3N0YXR1cyA9IDB4MDsNCkNvdWxkIGl0IGJlIGp1c3QgMD8NCj4gKyAgICAvKiBX
cml0aW5nIDB4MCByaWdodCBub3csIGJ1dCBTQ01JX1NITUVNX0ZMQUdfSU5UUl9FTkFCTEVEIGNh
biBiZSBzZXQgKi8NCj4gKyAgICBjaGFuX2luZm8tPnNobWVtLT5mbGFncyA9IDB4MDsNCj4gKyAg
ICBjaGFuX2luZm8tPnNobWVtLT5sZW5ndGggPSBzaXplb2YoY2hhbl9pbmZvLT5zaG1lbS0+bXNn
X2hlYWRlcikgKyBsZW47DQo+ICsgICAgY2hhbl9pbmZvLT5zaG1lbS0+bXNnX2hlYWRlciA9IHBh
Y2tfc2NtaV9oZWFkZXIoaGRyKTsNCj4gKw0KPiArICAgIHByaW50ayhYRU5MT0dfREVCVUcgInNj
bWk6IFdyaXRpbmcgdG8gc2htZW0gYWRkcmVzcyAlcFxuIiwNCj4gKyAgICAgICAgICAgY2hhbl9p
bmZvLT5zaG1lbSk7DQo+ICsgICAgaWYgKCBsZW4gPiAwICYmIGRhdGEgKQ0KSGVyZSBhbmQgZWxz
ZXdoZXJlOiBwbGVhc2UgY29uc2lkZXIgdXNpbmcgcGFyZW50aGVzZXMNCj4gKyAgICAgICAgX19t
ZW1jcHlfdG9pbygodm9pZCAqKShjaGFuX2luZm8tPnNobWVtLT5tc2dfcGF5bG9hZCksIGRhdGEs
IGxlbik7DQo+ICsNCj4gKyAgICBhcm1fc21jY2Nfc21jKGNoYW5faW5mby0+ZnVuY19pZCwgMCwg
MCwgMCwgMCwgMCwgMCwgY2hhbl9pbmZvLT5jaGFuX2lkLA0KPiArICAgICAgICAgICAgICAgICAg
JnJlc3ApOw0KPiArDQo+ICsgICAgcHJpbnRrKFhFTkxPR19ERUJVRyAic2NtaTogc2NtY2NjX3Nt
YyByZXNwb25zZSAlZFxuIiwgKGludCkocmVzcC5hMCkpOw0KPiArDQo+ICsgICAgaWYgKCByZXNw
LmEwICkNCj4gKyAgICAgICAgcmV0dXJuIC1FT1BOT1RTVVBQOw0KPiArDQo+ICsgICAgcmV0dXJu
IDA7DQo+ICt9DQo+ICsNCj4gK3N0YXRpYyBpbnQgY2hlY2tfc2NtaV9zdGF0dXMoaW50IHNjbWlf
c3RhdHVzKQ0KPiArew0KPiArICAgIGlmICggc2NtaV9zdGF0dXMgPT0gU0NNSV9TVUNDRVNTICkN
Cj4gKyAgICAgICAgcmV0dXJuIDA7DQo+ICsNCj4gKyAgICBwcmludGsoWEVOTE9HX0RFQlVHICJz
Y21pOiBFcnJvciByZWNlaXZlZDogJWRcbiIsIHNjbWlfc3RhdHVzKTsNCj4gKw0KPiArICAgIHN3
aXRjaCAoIHNjbWlfc3RhdHVzICkNCj4gKyAgICB7DQo+ICsgICAgY2FzZSBTQ01JX05PVF9TVVBQ
T1JURUQ6DQo+ICsgICAgICAgIHJldHVybiAtRU9QTk9UU1VQUDsNCj4gKyAgICBjYXNlIFNDTUlf
SU5WQUxJRF9QQVJBTUVURVJTOg0KPiArICAgICAgICByZXR1cm4gLUVJTlZBTDsNCj4gKyAgICBj
YXNlIFNDTUlfREVOSUVEOg0KPiArICAgICAgICByZXR1cm4gLUVBQ0NFUzsNCj4gKyAgICBjYXNl
IFNDTUlfTk9UX0ZPVU5EOg0KPiArICAgICAgICByZXR1cm4gLUVOT0VOVDsNCj4gKyAgICBjYXNl
IFNDTUlfT1VUX09GX1JBTkdFOg0KPiArICAgICAgICByZXR1cm4gLUVSQU5HRTsNCj4gKyAgICBj
YXNlIFNDTUlfQlVTWToNCj4gKyAgICAgICAgcmV0dXJuIC1FQlVTWTsNCj4gKyAgICBjYXNlIFND
TUlfQ09NTVNfRVJST1I6DQo+ICsgICAgICAgIHJldHVybiAtRU5PVENPTk47DQo+ICsgICAgY2Fz
ZSBTQ01JX0dFTkVSSUNfRVJST1I6DQo+ICsgICAgICAgIHJldHVybiAtRUlPOw0KPiArICAgIGNh
c2UgU0NNSV9IQVJEV0FSRV9FUlJPUjoNCj4gKyAgICAgICAgcmV0dXJuIC1FTlhJTzsNCj4gKyAg
ICBjYXNlIFNDTUlfUFJPVE9DT0xfRVJST1I6DQo+ICsgICAgICAgIHJldHVybiAtRUJBRE1TRzsN
Cj4gKyAgICBkZWZhdWx0Og0KPiArICAgICAgICByZXR1cm4gLUVJTlZBTDsNCj4gKyAgICB9DQo+
ICt9DQo+ICsNCj4gK3N0YXRpYyBpbnQgZ2V0X3NtY19yZXNwb25zZShzdHJ1Y3Qgc2NtaV9jaGFu
bmVsICpjaGFuX2luZm8sDQo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgc2NtaV9tc2df
aGVhZGVyX3QgKmhkciwgdm9pZCAqZGF0YSwgaW50IGxlbikNCj4gK3sNCj4gKyAgICBpbnQgcmVj
dl9sZW47DQo+ICsgICAgaW50IHJldDsNCj4gKw0KPiArICAgIHByaW50ayhYRU5MT0dfREVCVUcg
InNjbWk6IGdldCBzbWMgcmVzcG9uY2UgbXNnaWQgJWRcbiIsIGhkci0+aWQpOw0KPiArDQo+ICsg
ICAgaWYgKCBsZW4gPj0gU0NNSV9TSE1FTV9NQVBQRURfU0laRSAtIHNpemVvZihjaGFuX2luZm8t
PnNobWVtKSApDQpQYXJlbnRoZXNlcywgYXMgbWVudGlvbmVkIGFib3ZlLCBtYXkgaW1wcm92ZSBj
b2RlIHJlYWRhYmlsaXR5DQo+ICsgICAgew0KPiArICAgICAgICBwcmludGsoWEVOTE9HX0VSUg0K
PiArICAgICAgICAgICAgICAgInNjbWk6IFdyb25nIHNpemUgb2YgaW5wdXQgc21jIG1lc3NhZ2Uu
IERhdGEgbWF5IGJlIGludmFsaWRcbiIpOw0KPiArICAgICAgICByZXR1cm4gLUVJTlZBTDsNCj4g
KyAgICB9DQo+ICsNCj4gKyAgICByZXQgPSBjaGFubmVsX2lzX2ZyZWUoY2hhbl9pbmZvKTsNCj4g
KyAgICBpZiAoIElTX0VSUl9WQUxVRShyZXQpICkNCj4gKyAgICAgICAgcmV0dXJuIHJldDsNCj4g
Kw0KPiArICAgIHJlY3ZfbGVuID0gY2hhbl9pbmZvLT5zaG1lbS0+bGVuZ3RoIC0gc2l6ZW9mKGNo
YW5faW5mby0+c2htZW0tPm1zZ19oZWFkZXIpOw0KPiArDQo+ICsgICAgaWYgKCByZWN2X2xlbiA8
IDAgKQ0KPiArICAgIHsNCj4gKyAgICAgICAgcHJpbnRrKFhFTkxPR19FUlINCj4gKyAgICAgICAg
ICAgICAgICJzY21pOiBXcm9uZyBzaXplIG9mIHNtYyBtZXNzYWdlLiBEYXRhIG1heSBiZSBpbnZh
bGlkXG4iKTsNCj4gKyAgICAgICAgcmV0dXJuIC1FSU5WQUw7DQo+ICsgICAgfQ0KPiArDQo+ICsg
ICAgaWYgKCByZWN2X2xlbiA+IGxlbiApDQo+ICsgICAgew0KPiArICAgICAgICBwcmludGsoWEVO
TE9HX0VSUg0KPiArICAgICAgICAgICAgICAgInNjbWk6IE5vdCBlbm91Z2ggYnVmZmVyIGZvciBt
ZXNzYWdlICVkLCBleHBlY3RpbmcgJWRcbiIsDQo+ICsgICAgICAgICAgICAgICByZWN2X2xlbiwg
bGVuKTsNCj4gKyAgICAgICAgcmV0dXJuIC1FSU5WQUw7DQo+ICsgICAgfQ0KPiArDQo+ICsgICAg
dW5wYWNrX3NjbWlfaGVhZGVyKGNoYW5faW5mby0+c2htZW0tPm1zZ19oZWFkZXIsIGhkcik7DQo+
ICsNCj4gKyAgICBpZiAoIHJlY3ZfbGVuID4gMCApDQo+ICsgICAgew0KPiArICAgICAgICBfX21l
bWNweV9mcm9taW8oZGF0YSwgY2hhbl9pbmZvLT5zaG1lbS0+bXNnX3BheWxvYWQsIHJlY3ZfbGVu
KTsNCj4gKyAgICB9DQpObyBuZWVkIGZvciBwYXJlbnRoZXNlcyBmb3IgYSBzaW5nbGUgc3RhdGVt
ZW50DQo+ICsNCj4gKyAgICByZXR1cm4gMDsNCj4gK30NCj4gKw0KPiArc3RhdGljIGludCBkb19z
bWNfeGZlcihzdHJ1Y3Qgc2NtaV9jaGFubmVsICpjaGFubmVsLCBzY21pX21zZ19oZWFkZXJfdCAq
aGRyLCB2b2lkICp0eF9kYXRhLCBpbnQgdHhfc2l6ZSwNCj4gKyAgICAgICAgICAgICAgICAgICAg
ICAgdm9pZCAqcnhfZGF0YSwgaW50IHJ4X3NpemUpDQo+ICt7DQo+ICsgICAgaW50IHJldCA9IDA7
DQo+ICsNCj4gKyAgICBBU1NFUlQoIGNoYW5uZWwgJiYgY2hhbm5lbC0+c2htZW0pOw0KPiArDQo+
ICsgICAgaWYgKCAhaGRyICkNCj4gKyAgICAgICAgcmV0dXJuIC1FSU5WQUw7DQo+ICsNCj4gKyAg
ICBzcGluX2xvY2soJmNoYW5uZWwtPmxvY2spOw0KPiArDQo+ICsgICAgcmV0ID0gc2VuZF9zbWNf
bWVzc2FnZShjaGFubmVsLCBoZHIsIHR4X2RhdGEsIHR4X3NpemUpOw0KPiArICAgIGlmICggcmV0
ICkNCj4gKyAgICAgICAgZ290byBjbGVhbjsNCj4gKw0KPiArICAgIHJldCA9IGdldF9zbWNfcmVz
cG9uc2UoY2hhbm5lbCwgaGRyLCByeF9kYXRhLCByeF9zaXplKTsNCkJsYW5rIGxpbmUNCj4gK2Ns
ZWFuOg0KPiArICAgIHNwaW5fdW5sb2NrKCZjaGFubmVsLT5sb2NrKTsNCj4gKw0KPiArICAgIHJl
dHVybiByZXQ7DQo+ICt9DQo+ICsNCj4gK3N0YXRpYyBzdHJ1Y3Qgc2NtaV9jaGFubmVsICpnZXRf
Y2hhbm5lbF9ieV9pZCh1aW50OF90IGNoYW5faWQpDQo+ICt7DQo+ICsgICAgc3RydWN0IHNjbWlf
Y2hhbm5lbCAqY3VycjsNCj4gKyAgICBib29sIGZvdW5kID0gZmFsc2U7DQo+ICsNCj4gKyAgICBz
cGluX2xvY2soJnNjbWlfZGF0YS5jaGFubmVsX2xpc3RfbG9jayk7DQo+ICsgICAgbGlzdF9mb3Jf
ZWFjaF9lbnRyeShjdXJyLCAmc2NtaV9kYXRhLmNoYW5uZWxfbGlzdCwgbGlzdCkNCj4gKyAgICB7
DQo+ICsgICAgICAgIGlmICggY3Vyci0+Y2hhbl9pZCA9PSBjaGFuX2lkICkNCj4gKyAgICAgICAg
ew0KPiArICAgICAgICAgICAgZm91bmQgPSB0cnVlOw0KPiArICAgICAgICAgICAgYnJlYWs7DQo+
ICsgICAgICAgIH0NCj4gKyAgICB9DQo+ICsNCkV4dHJhIGxpbmUgYW5kIGluIHRoZSBjb2RlIGJl
bG93DQo+ICsgICAgc3Bpbl91bmxvY2soJnNjbWlfZGF0YS5jaGFubmVsX2xpc3RfbG9jayk7DQo+
ICsgICAgaWYgKCBmb3VuZCApDQo+ICsgICAgICAgIHJldHVybiBjdXJyOw0KPiArDQo+ICsgICAg
cmV0dXJuIE5VTEw7DQo+ICt9DQo+ICsNCj4gK3N0YXRpYyBzdHJ1Y3Qgc2NtaV9jaGFubmVsICph
cXVpcmVfc2NtaV9jaGFubmVsKGRvbWlkX3QgZG9tYWluX2lkKQ0KPiArew0KPiArICAgIHN0cnVj
dCBzY21pX2NoYW5uZWwgKmN1cnI7DQo+ICsgICAgYm9vbCBmb3VuZCA9IGZhbHNlOw0KPiArDQo+
ICsgICAgQVNTRVJUKGRvbWFpbl9pZCAhPSBET01JRF9JTlZBTElEICYmIGRvbWFpbl9pZCA+PSAw
KTsNCj4gKw0KPiArICAgIHNwaW5fbG9jaygmc2NtaV9kYXRhLmNoYW5uZWxfbGlzdF9sb2NrKTsN
Cj4gKyAgICBsaXN0X2Zvcl9lYWNoX2VudHJ5KGN1cnIsICZzY21pX2RhdGEuY2hhbm5lbF9saXN0
LCBsaXN0KQ0KPiArICAgIHsNCj4gKyAgICAgICAgaWYgKCBjdXJyLT5kb21haW5faWQgPT0gRE9N
SURfSU5WQUxJRCApDQo+ICsgICAgICAgIHsNCj4gKyAgICAgICAgICAgIGN1cnItPmRvbWFpbl9p
ZCA9IGRvbWFpbl9pZDsNCj4gKyAgICAgICAgICAgIGZvdW5kID0gdHJ1ZTsNCj4gKyAgICAgICAg
ICAgIGJyZWFrOw0KPiArICAgICAgICB9DQo+ICsgICAgfQ0KPiArDQo+ICsgICAgc3Bpbl91bmxv
Y2soJnNjbWlfZGF0YS5jaGFubmVsX2xpc3RfbG9jayk7DQo+ICsgICAgaWYgKCBmb3VuZCApDQo+
ICsgICAgICAgIHJldHVybiBjdXJyOw0KPiArDQo+ICsgICAgcmV0dXJuIE5VTEw7DQo+ICt9DQo+
ICsNCj4gK3N0YXRpYyB2b2lkIHJlbGlucXVpc2hfc2NtaV9jaGFubmVsKHN0cnVjdCBzY21pX2No
YW5uZWwgKmNoYW5uZWwpDQo+ICt7DQo+ICsgICAgQVNTRVJUKGNoYW5uZWwgIT0gTlVMTCk7DQo+
ICsNCj4gKyAgICBzcGluX2xvY2soJnNjbWlfZGF0YS5jaGFubmVsX2xpc3RfbG9jayk7DQo+ICsg
ICAgY2hhbm5lbC0+ZG9tYWluX2lkID0gRE9NSURfSU5WQUxJRDsNCj4gKyAgICBzcGluX3VubG9j
aygmc2NtaV9kYXRhLmNoYW5uZWxfbGlzdF9sb2NrKTsNCj4gK30NCj4gKw0KPiArc3RhdGljIGlu
dCBtYXBfY2hhbm5lbF9tZW1vcnkoc3RydWN0IHNjbWlfY2hhbm5lbCAqY2hhbm5lbCkNCj4gK3sN
Cj4gKyAgICBBU1NFUlQoIGNoYW5uZWwgJiYgY2hhbm5lbC0+cGFkZHIgKTsNCj4gKyAgICBjaGFu
bmVsLT5zaG1lbSA9IGlvcmVtYXBfY2FjaGUoY2hhbm5lbC0+cGFkZHIsIFNDTUlfU0hNRU1fTUFQ
UEVEX1NJWkUpOw0KPiArICAgIGlmICggIWNoYW5uZWwtPnNobWVtICkNCj4gKyAgICAgICAgcmV0
dXJuIC1FTk9NRU07DQo+ICsNCj4gKyAgICBjaGFubmVsLT5zaG1lbS0+Y2hhbm5lbF9zdGF0dXMg
PSBTQ01JX1NITUVNX0NIQU5fU1RBVF9DSEFOTkVMX0ZSRUU7DQo+ICsgICAgcHJpbnRrKFhFTkxP
R19ERUJVRyAic2NtaTogR290IHNobWVtIGFmdGVyIHZtYXAgJXBcbiIsIGNoYW5uZWwtPnNobWVt
KTsNCj4gKyAgICByZXR1cm4gMDsNCj4gK30NCj4gKw0KPiArc3RhdGljIHZvaWQgdW5tYXBfY2hh
bm5lbF9tZW1vcnkoc3RydWN0IHNjbWlfY2hhbm5lbCAqY2hhbm5lbCkNCj4gK3sNCj4gKyAgICBB
U1NFUlQoIGNoYW5uZWwgJiYgY2hhbm5lbC0+c2htZW0gKTsNCj4gKyAgICBpb3VubWFwKGNoYW5u
ZWwtPnNobWVtKTsNCj4gKyAgICBjaGFubmVsLT5zaG1lbSA9IE5VTEw7DQo+ICt9DQo+ICsNCj4g
K3N0YXRpYyBzdHJ1Y3Qgc2NtaV9jaGFubmVsICpzbWNfY3JlYXRlX2NoYW5uZWwodWludDhfdCBj
aGFuX2lkLA0KPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICB1aW50MzJfdCBmdW5jX2lkLCB1aW50NjRfdCBhZGRyKQ0KPiArew0KPiArICAgIHN0cnVjdCBz
Y21pX2NoYW5uZWwgKmNoYW5uZWw7DQo+ICsNCj4gKyAgICBjaGFubmVsID0gZ2V0X2NoYW5uZWxf
YnlfaWQoY2hhbl9pZCk7DQo+ICsgICAgaWYgKCBjaGFubmVsICkNCj4gKyAgICAgICAgcmV0dXJu
IEVSUl9QVFIoRUVYSVNUKTsNCj4gKw0KPiArICAgIGNoYW5uZWwgPSB4bWFsbG9jKHN0cnVjdCBz
Y21pX2NoYW5uZWwpOw0KPiArICAgIGlmICggIWNoYW5uZWwgKQ0KPiArICAgICAgICByZXR1cm4g
RVJSX1BUUihFTk9NRU0pOw0KPiArDQo+ICsgICAgY2hhbm5lbC0+Y2hhbl9pZCA9IGNoYW5faWQ7
DQo+ICsgICAgY2hhbm5lbC0+ZnVuY19pZCA9IGZ1bmNfaWQ7DQo+ICsgICAgY2hhbm5lbC0+ZG9t
YWluX2lkID0gRE9NSURfSU5WQUxJRDsNCj4gKyAgICBjaGFubmVsLT5zaG1lbSA9IE5VTEw7DQo+
ICsgICAgY2hhbm5lbC0+cGFkZHIgPSBhZGRyOw0KPiArICAgIHNwaW5fbG9ja19pbml0KCZjaGFu
bmVsLT5sb2NrKTsNCj4gKyAgICBzcGluX2xvY2soJnNjbWlfZGF0YS5jaGFubmVsX2xpc3RfbG9j
ayk7DQo+ICsgICAgbGlzdF9hZGQoJmNoYW5uZWwtPmxpc3QsICZzY21pX2RhdGEuY2hhbm5lbF9s
aXN0KTsNCj4gKyAgICBzcGluX3VubG9jaygmc2NtaV9kYXRhLmNoYW5uZWxfbGlzdF9sb2NrKTsN
Cj4gKyAgICByZXR1cm4gY2hhbm5lbDsNCj4gK30NCj4gKw0KPiArc3RhdGljIGludCBtZW1fcGVy
bWl0X2FjY2VzcyhzdHJ1Y3QgZG9tYWluICpkLCB1aW50NjRfdCBhZGRyLCB1aW50NjRfdCBsZW4p
DQo+ICt7DQo+ICsgICAgcmV0dXJuIGlvbWVtX3Blcm1pdF9hY2Nlc3MoZCwgcGFkZHJfdG9fcGZu
KGFkZHIpLA0KPiArICAgICAgICAgICAgICAgIHBhZGRyX3RvX3BmbihQQUdFX0FMSUdOKGFkZHIg
KyBsZW4gLTEpKSk7DQo+ICt9DQo+ICsNCj4gK3N0YXRpYyBpbnQgbWVtX2RlbnlfYWNjZXNzKHN0
cnVjdCBkb21haW4gKmQsIHVpbnQ2NF90IGFkZHIsDQo+ICsgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgdWludDY0X3QgbGVuKQ0KPiArew0KPiArICAgIHJldHVybiBpb21lbV9k
ZW55X2FjY2VzcyhkLCBwYWRkcl90b19wZm4oYWRkciksDQo+ICsgICAgICAgICAgICAgICAgcGFk
ZHJfdG9fcGZuKFBBR0VfQUxJR04oYWRkciArIGxlbiAtMSkpKTsNCj4gK30NCj4gKw0KPiArc3Rh
dGljIGludCBkdF91cGRhdGVfZG9tYWluX3JhbmdlKHVpbnQ2NF90IGFkZHIsIHVpbnQ2NF90IHNp
emUpDQo+ICt7DQo+ICsgICAgc3RydWN0IGR0X2RldmljZV9ub2RlICpzaG1lbV9ub2RlOw0KPiAr
ICAgIF9fYmUzMiAqaHdfcmVnOw0KPiArICAgIGNvbnN0IHN0cnVjdCBkdF9wcm9wZXJ0eSAqcHA7
DQo+ICsgICAgdWludDMyX3QgbGVuOw0KPiArDQo+ICsgICAgc2htZW1fbm9kZSA9IGR0X2ZpbmRf
Y29tcGF0aWJsZV9ub2RlKE5VTEwsIE5VTEwsIFNDTUlfU0hBUkVEX01FTU9SWSk7DQo+ICsgICAg
aWYgKCAhc2htZW1fbm9kZSApDQo+ICsgICAgew0KPiArICAgICAgICBwcmludGsoWEVOTE9HX0VS
UiAic2NtaTogVW5hYmxlIHRvIGZpbmQgJXMgbm9kZSBpbiBEVFxuIiwgU0NNSV9TSE1FTSk7DQo+
ICsgICAgICAgIHJldHVybiAtRUlOVkFMOw0KPiArICAgIH0NCj4gKw0KPiArICAgIHBwID0gZHRf
ZmluZF9wcm9wZXJ0eShzaG1lbV9ub2RlLCAicmVnIiwgJmxlbik7DQo+ICsgICAgaWYgKCAhcHAg
KQ0KPiArICAgIHsNCj4gKyAgICAgICAgcHJpbnRrKFhFTkxPR19FUlIgInNjbWk6IFVuYWJsZSB0
byBmaW5kIHJlZ3MgZW50cnkgaW4gc2htZW0gbm9kZVxuIik7DQo+ICsgICAgICAgIHJldHVybiAt
RU5PRU5UOw0KPiArICAgIH0NCj4gKw0KPiArICAgIGh3X3JlZyA9IHBwLT52YWx1ZTsNCj4gKyAg
ICBkdF9zZXRfcmFuZ2UoJmh3X3JlZywgc2htZW1fbm9kZSwgYWRkciwgc2l6ZSk7DQo+ICsNCj4g
KyAgICByZXR1cm4gMDsNCj4gK30NCj4gKw0KPiArc3RhdGljIHZvaWQgZnJlZV9jaGFubmVsX2xp
c3Qodm9pZCkNCj4gK3sNCj4gKyAgICBzdHJ1Y3Qgc2NtaV9jaGFubmVsICpjdXJyLCAqX2N1cnI7
DQo+ICsNCj4gKyAgICBzcGluX2xvY2soJnNjbWlfZGF0YS5jaGFubmVsX2xpc3RfbG9jayk7DQo+
ICsgICAgbGlzdF9mb3JfZWFjaF9lbnRyeV9zYWZlIChjdXJyLCBfY3VyciwgJnNjbWlfZGF0YS5j
aGFubmVsX2xpc3QsIGxpc3QpDQo+ICsgICAgew0KPiArICAgICAgICBsaXN0X2RlbCgmY3Vyci0+
bGlzdCk7DQo+ICsgICAgICAgIHhmcmVlKGN1cnIpOw0KPiArICAgIH0NCj4gKw0KVGhpcyBsb29r
cyBsaWtlIGEgcGF0dGVybiB5b3UgdXNlIHdpdGggYSBibGFuayBsaW5lIGFmdGVyIGxpc3RfZm9y
X2VhY2gNCj4gKyAgICBzcGluX3VubG9jaygmc2NtaV9kYXRhLmNoYW5uZWxfbGlzdF9sb2NrKTsN
Cj4gK30NCj4gKw0KPiArc3RhdGljIHN0cnVjdCBkdF9kZXZpY2Vfbm9kZSAqZ2V0X2R0X25vZGVf
ZnJvbV9wcm9wZXJ0eSgNCj4gKyAgICAgICAgICAgICAgICBzdHJ1Y3QgZHRfZGV2aWNlX25vZGUg
Km5vZGUsIGNvbnN0IGNoYXIgKiBwX25hbWUpDQo+ICt7DQo+ICsgICAgY29uc3QgX19iZTMyICpw
cm9wOw0KPiArDQo+ICsgICAgQVNTRVJUKCBub2RlICk7DQo+ICsNCj4gKyAgICBwcm9wID0gZHRf
Z2V0X3Byb3BlcnR5KG5vZGUsIHBfbmFtZSwgTlVMTCk7DQo+ICsgICAgaWYgKCAhcHJvcCApDQo+
ICsgICAgICAgIHJldHVybiBFUlJfUFRSKC1FSU5WQUwpOw0KPiArDQo+ICsgICAgcmV0dXJuIGR0
X2ZpbmRfbm9kZV9ieV9waGFuZGxlKGJlMzJfdG9fY3B1cChwcm9wKSk7DQo+ICt9DQo+ICsNCj4g
K3N0YXRpYyBpbnQgZ2V0X3NobWVtX3JlZ2lvbnMoc3RydWN0IGxpc3RfaGVhZCAqaGVhZCwgdTY0
IGh5cF9hZGRyKQ0KPiArew0KPiArICAgIHN0cnVjdCBkdF9kZXZpY2Vfbm9kZSAqbm9kZTsNCj4g
KyAgICBpbnQgcmV0Ow0KPiArICAgIHN0cnVjdCBkdF9jaGFubmVsX2FkZHIgKmxjaGFuOw0KPiAr
ICAgIHU2NCBsYWRkciwgbHNpemU7DQo+ICsNCj4gKyAgICBub2RlID0gZHRfZmluZF9jb21wYXRp
YmxlX25vZGUoTlVMTCwgTlVMTCwgU0NNSV9TSEFSRURfTUVNT1JZKTsNCj4gKyAgICBpZiAoICFu
b2RlICkNCj4gKyAgICAgICAgcmV0dXJuIC1FTk9FTlQ7DQo+ICsNCj4gKyAgICB3aGlsZSAoIG5v
ZGUgKQ0KPiArICAgIHsNCj4gKyAgICAgICAgcmV0ID0gZHRfZGV2aWNlX2dldF9hZGRyZXNzKG5v
ZGUsIDAsICZsYWRkciwgJmxzaXplKTsNCj4gKyAgICAgICAgaWYgKCByZXQgKQ0KPiArICAgICAg
ICAgICAgcmV0dXJuIHJldDsNCj4gKw0KPiArICAgICAgICBpZiAoIGxhZGRyICE9IGh5cF9hZGRy
ICkNCj4gKyAgICAgICAgew0KPiArICAgICAgICAgICAgbGNoYW4gPSB4bWFsbG9jKHN0cnVjdCBk
dF9jaGFubmVsX2FkZHIpOw0KPiArICAgICAgICAgICAgaWYgKCAhbGNoYW4gKQ0KPiArICAgICAg
ICAgICAgICAgIHJldHVybiAtRU5PTUVNOw0KPiArICAgICAgICAgICAgbGNoYW4tPmFkZHIgPSBs
YWRkcjsNCj4gKyAgICAgICAgICAgIGxjaGFuLT5zaXplID0gbHNpemU7DQo+ICsNCj4gKyAgICAg
ICAgICAgIGxpc3RfYWRkX3RhaWwoJmxjaGFuLT5saXN0LCBoZWFkKTsNCj4gKyAgICAgICAgfQ0K
PiArDQo+ICsgICAgICAgIG5vZGUgPSBkdF9maW5kX2NvbXBhdGlibGVfbm9kZShub2RlLCBOVUxM
LCBTQ01JX1NIQVJFRF9NRU1PUlkpOw0KPiArICAgIH0NCj4gKw0KPiArICAgIHJldHVybiAwOw0K
PiArfQ0KPiArDQo+ICtzdGF0aWMgaW50IHJlYWRfaHlwX2NoYW5uZWxfYWRkcihzdHJ1Y3QgZHRf
ZGV2aWNlX25vZGUgKnNjbWlfbm9kZSwNCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgIHU2NCAqYWRkciwgdTY0ICpzaXplKQ0KPiArew0KPiArICAgIHN0cnVjdCBkdF9kZXZpY2Vf
bm9kZSAqc2htZW1fbm9kZTsNCj4gKyAgICBzaG1lbV9ub2RlID0gZ2V0X2R0X25vZGVfZnJvbV9w
cm9wZXJ0eShzY21pX25vZGUsICJzaG1lbSIpOw0KPiArICAgIGlmICggSVNfRVJSX09SX05VTEwo
c2htZW1fbm9kZSkgKQ0KPiArICAgIHsNCj4gKyAgICAgICAgcHJpbnRrKFhFTkxPR19FUlINCj4g
KyAgICAgICAgICAgICAgICJzY21pOiBEZXZpY2UgdHJlZSBlcnJvciwgY2FuJ3QgcGFyc2UgcmVz
ZXJ2ZWQgbWVtb3J5ICVsZFxuIiwNCj4gKyAgICAgICAgICAgICAgIFBUUl9FUlIoc2htZW1fbm9k
ZSkpOw0KPiArICAgICAgICByZXR1cm4gUFRSX0VSUihzaG1lbV9ub2RlKTsNCj4gKyAgICB9DQo+
ICsNCj4gKyAgICByZXR1cm4gZHRfZGV2aWNlX2dldF9hZGRyZXNzKHNobWVtX25vZGUsIDAsIGFk
ZHIsIHNpemUpOw0KPiArfQ0KPiArDQo+ICtzdGF0aWMgdm9pZCBmcmVlX3NobWVtX3JlZ2lvbnMo
c3RydWN0IGxpc3RfaGVhZCAqYWRkcl9saXN0KQ0KPiArew0KPiArICAgIHN0cnVjdCBkdF9jaGFu
bmVsX2FkZHIgKmN1cnIsICpfY3VycjsNCj4gKw0KPiArICAgIGxpc3RfZm9yX2VhY2hfZW50cnlf
c2FmZSAoY3VyciwgX2N1cnIsIGFkZHJfbGlzdCwgbGlzdCkNCj4gKyAgICB7DQo+ICsgICAgICAg
IGxpc3RfZGVsKCZjdXJyLT5saXN0KTsNCj4gKyAgICAgICAgeGZyZWUoY3Vycik7DQo+ICsgICAg
fQ0KPiArfQ0KPiArDQo+ICtzdGF0aWMgX19pbml0IGJvb2wgc2NtaV9wcm9iZShzdHJ1Y3QgZHRf
ZGV2aWNlX25vZGUgKnNjbWlfbm9kZSkNCj4gK3sNCj4gKyAgICB1NjQgYWRkciwgc2l6ZTsNCj4g
KyAgICBpbnQgcmV0LCBpOw0KPiArICAgIHN0cnVjdCBzY21pX2NoYW5uZWwgKmNoYW5uZWwsICph
Z2VudF9jaGFubmVsOw0KPiArICAgIGludCBuX2FnZW50czsNCj4gKyAgICBzY21pX21zZ19oZWFk
ZXJfdCBoZHI7DQo+ICsgICAgc3RydWN0IHJ4X3Qgew0KPiArICAgICAgICBpbnQzMl90IHN0YXR1
czsNCj4gKyAgICAgICAgdWludDMyX3QgYXR0cmlidXRlczsNCj4gKyAgICB9IHJ4Ow0KPiArICAg
IHN0cnVjdCBkdF9jaGFubmVsX2FkZHIgKmVudHJ5Ow0KPiArICAgIHN0cnVjdCBsaXN0X2hlYWQg
YWRkcl9saXN0Ow0KPiArDQo+ICsgICAgdWludDMyX3QgZnVuY19pZDsNCj4gKw0KPiArICAgIEFT
U0VSVChzY21pX25vZGUgIT0gTlVMTCk7DQo+ICsNCj4gKyAgICBJTklUX0xJU1RfSEVBRCgmc2Nt
aV9kYXRhLmNoYW5uZWxfbGlzdCk7DQo+ICsgICAgc3Bpbl9sb2NrX2luaXQoJnNjbWlfZGF0YS5j
aGFubmVsX2xpc3RfbG9jayk7DQo+ICsNCj4gKyAgICBpZiAoICFkdF9wcm9wZXJ0eV9yZWFkX3Uz
MihzY21pX25vZGUsIFNDTUlfU01DX0lELCAmZnVuY19pZCkgKQ0KPiArICAgIHsNCj4gKyAgICAg
ICAgcHJpbnRrKFhFTkxPR19FUlIgInNjbWk6IFVuYWJsZSB0byByZWFkIHNtYy1pZCBmcm9tIERU
XG4iKTsNCj4gKyAgICAgICAgcmV0dXJuIGZhbHNlOw0KPiArICAgIH0NCj4gKw0KPiArICAgIHJl
dCA9IHJlYWRfaHlwX2NoYW5uZWxfYWRkcihzY21pX25vZGUsICZhZGRyLCAmc2l6ZSk7DQo+ICsg
ICAgaWYgKCBJU19FUlJfVkFMVUUocmV0KSApDQo+ICsgICAgICAgIHJldHVybiBmYWxzZTsNCj4g
Kw0KPiArICAgIGlmICggIUlTX0FMSUdORUQoc2l6ZSwgU0NNSV9TSE1FTV9NQVBQRURfU0laRSkg
KQ0KPiArICAgIHsNCj4gKyAgICAgICAgcHJpbnRrKFhFTkxPR19FUlIgInNjbWk6IFJlc2VydmVk
IG1lbW9yeSBpcyBub3QgYWxpZ25lZFxuIik7DQo+ICsgICAgICAgIHJldHVybiBmYWxzZTsNCj4g
KyAgICB9DQo+ICsNCj4gKyAgICBJTklUX0xJU1RfSEVBRCgmYWRkcl9saXN0KTsNCj4gKw0KPiAr
ICAgIHJldCA9IGdldF9zaG1lbV9yZWdpb25zKCZhZGRyX2xpc3QsIGFkZHIpOw0KPiArICAgIGlm
ICggSVNfRVJSX1ZBTFVFKHJldCkgKQ0KPiArICAgICAgICBnb3RvIG91dDsNCj4gKw0KPiArICAg
IGNoYW5uZWwgPSBzbWNfY3JlYXRlX2NoYW5uZWwoSFlQX0NIQU5ORUwsIGZ1bmNfaWQsIGFkZHIp
Ow0KPiArICAgIGlmICggSVNfRVJSKGNoYW5uZWwpICkNCj4gKyAgICAgICAgZ290byBvdXQ7DQo+
ICsNCj4gKyAgICByZXQgPSBtYXBfY2hhbm5lbF9tZW1vcnkoY2hhbm5lbCk7DQo+ICsgICAgaWYg
KCByZXQgKQ0KPiArICAgICAgICBnb3RvIG91dDsNCj4gKw0KPiArICAgIHNwaW5fbG9jaygmc2Nt
aV9kYXRhLmNoYW5uZWxfbGlzdF9sb2NrKTsNCj4gKyAgICBjaGFubmVsLT5kb21haW5faWQgPSBE
T01JRF9YRU47DQo+ICsgICAgc3Bpbl91bmxvY2soJnNjbWlfZGF0YS5jaGFubmVsX2xpc3RfbG9j
ayk7DQo+ICsNCj4gKyAgICBoZHIuaWQgPSBTQ01JX0JBU0VfUFJPVE9DT0xfQVRUSUJVVEVTOw0K
PiArICAgIGhkci50eXBlID0gMDsNCj4gKyAgICBoZHIucHJvdG9jb2wgPSBTQ01JX0JBU0VfUFJP
VE9DT0w7DQo+ICsNCj4gKyAgICByZXQgPSBkb19zbWNfeGZlcihjaGFubmVsLCAmaGRyLCBOVUxM
LCAwLCAmcngsIHNpemVvZihyeCkpOw0KPiArICAgIGlmICggcmV0ICkNCj4gKyAgICAgICAgZ290
byBlcnJvcjsNCj4gKw0KPiArICAgIHJldCA9IGNoZWNrX3NjbWlfc3RhdHVzKHJ4LnN0YXR1cyk7
DQo+ICsgICAgaWYgKCByZXQgKQ0KWW91IHNob3VsZCBjb25zaWRlciBlaXRoZXIgdXNpbmcgSVNf
RVJSX1ZBTFVFIGluIGV2ZXJ5d2hlcmUgb3INCmRvbid0IHVzZSBpdCBhdCBhbGwNCj4gKyAgICAg
ICAgZ290byBlcnJvcjsNCj4gKw0KPiArICAgIG5fYWdlbnRzID0gRklFTERfR0VUKE1TR19OX0FH
RU5UU19NQVNLLCByeC5hdHRyaWJ1dGVzKTsNCj4gKyAgICBwcmludGsoWEVOTE9HX0RFQlVHICJz
Y21pOiBHb3QgYWdlbnQgY291bnQgJWRcbiIsIG5fYWdlbnRzKTsNCj4gKw0KPiArICAgIGkgPSAx
Ow0KPiArICAgIGxpc3RfZm9yX2VhY2hfZW50cnkoZW50cnksICZhZGRyX2xpc3QsIGxpc3QpDQo+
ICsgICAgew0KPiArICAgICAgICB1aW50MzJfdCB0eF9hZ2VudF9pZCA9IDB4RkZGRkZGRkY7DQo+
ICsgICAgICAgIHN0cnVjdCB7DQo+ICsgICAgICAgICAgICBpbnQzMl90IHN0YXR1czsNCj4gKyAg
ICAgICAgICAgIHVpbnQzMl90IGFnZW50X2lkOw0KPiArICAgICAgICAgICAgY2hhciBuYW1lWzE2
XTsNCj4gKyAgICAgICAgfSBkYV9yeDsNCj4gKw0KPiArICAgICAgICBhZ2VudF9jaGFubmVsID0g
c21jX2NyZWF0ZV9jaGFubmVsKGksIGZ1bmNfaWQsDQo+ICsgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgZW50cnktPmFkZHIpOw0KVGhpcyBzaG91bGQgZml0IGluIGEg
c2luZ2xlIGxpbmUNCj4gKyAgICAgICAgaWYgKCBJU19FUlIoYWdlbnRfY2hhbm5lbCkgKQ0KPiAr
ICAgICAgICB7DQo+ICsgICAgICAgICAgICByZXQgPSBQVFJfRVJSKGFnZW50X2NoYW5uZWwpOw0K
PiArICAgICAgICAgICAgZ290byBlcnJvcjsNCj4gKyAgICAgICAgfQ0KPiArDQo+ICsgICAgICAg
IHJldCA9IG1hcF9jaGFubmVsX21lbW9yeShhZ2VudF9jaGFubmVsKTsNCj4gKyAgICAgICAgaWYg
KCByZXQgKQ0KPiArICAgICAgICAgICAgZ290byBlcnJvcjsNCj4gKw0KPiArICAgICAgICBoZHIu
aWQgPSBTQ01JX0JBU0VfRElTQ09WRVJfQUdFTlQ7DQo+ICsgICAgICAgIGhkci50eXBlID0gMDsN
Cj4gKyAgICAgICAgaGRyLnByb3RvY29sID0gU0NNSV9CQVNFX1BST1RPQ09MOw0KPiArDQo+ICsg
ICAgICAgIHJldCA9IGRvX3NtY194ZmVyKGFnZW50X2NoYW5uZWwsICZoZHIsICZ0eF9hZ2VudF9p
ZCwNCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgc2l6ZW9mKHR4X2FnZW50X2lkKSwgJmRh
X3J4LCBzaXplb2YoZGFfcngpKTsNCj4gKyAgICAgICAgaWYgKCByZXQgKQ0KPiArICAgICAgICB7
DQo+ICsgICAgICAgICAgICB1bm1hcF9jaGFubmVsX21lbW9yeShhZ2VudF9jaGFubmVsKTsNCj4g
KyAgICAgICAgICAgIGdvdG8gZXJyb3I7DQo+ICsgICAgICAgIH0NCj4gKw0KPiArICAgICAgICB1
bm1hcF9jaGFubmVsX21lbW9yeShhZ2VudF9jaGFubmVsKTsNClRoaXMgY291bGQgYmUgbW92ZWQg
YmVmb3JlIGNoZWNraW5nIHJldCB2YWx1ZQ0KPiArDQo+ICsgICAgICAgIHJldCA9IGNoZWNrX3Nj
bWlfc3RhdHVzKGRhX3J4LnN0YXR1cyk7DQo+ICsgICAgICAgIGlmICggcmV0ICkNCj4gKyAgICAg
ICAgICAgIGdvdG8gZXJyb3I7DQo+ICsNCj4gKyAgICAgICAgcHJpbnRrKFhFTkxPR19ERUJVRyAi
c2NtaTogc3RhdHVzPTB4JXggaWQ9MHgleCBuYW1lPSVzXG4iLA0KPiArICAgICAgICAgICAgICAg
IGRhX3J4LnN0YXR1cywgZGFfcnguYWdlbnRfaWQsIGRhX3J4Lm5hbWUpOw0KPiArDQo+ICsgICAg
ICAgIGFnZW50X2NoYW5uZWwtPmFnZW50X2lkID0gZGFfcnguYWdlbnRfaWQ7DQo+ICsNCj4gKyAg
ICAgICAgaWYgKCBpID09IG5fYWdlbnRzICkNCj4gKyAgICAgICAgICAgIGJyZWFrOw0KPiArDQo+
ICsgICAgICAgIGkrKzsNCj4gKyAgICB9DQo+ICsNCj4gKyAgICBzY21pX2RhdGEuaW5pdGlhbGl6
ZWQgPSB0cnVlOw0KPiArICAgIGdvdG8gb3V0Ow0KPiArDQo+ICtlcnJvcjoNClRoaXMgbGFiZWwg
c291bmRzIHN0cmFuZ2Ugd2hpbGUgcmV0dXJuaW5nIHdpdGhvdXQgZXJyb3IsDQpjb3VsZCBpdCBi
ZSBsaWtlICJ1bm1hcF9jaGFubmVsIiBvciBzb21ldGhpbmc/DQo+ICsgICAgdW5tYXBfY2hhbm5l
bF9tZW1vcnkoY2hhbm5lbCk7DQo+ICsgICAgZnJlZV9jaGFubmVsX2xpc3QoKTsNCj4gK291dDoN
Cj4gKyAgICBmcmVlX3NobWVtX3JlZ2lvbnMoJmFkZHJfbGlzdCk7DQo+ICsgICAgcmV0dXJuIHJl
dCA9PSAwOw0KPiArfQ0KPiArDQo+ICtzdGF0aWMgaW50IHNjbWlfZG9tYWluX2luaXQoc3RydWN0
IGRvbWFpbiAqZCwNCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0cnVjdCB4ZW5fYXJj
aF9kb21haW5jb25maWcgKmNvbmZpZykNCj4gK3sNCj4gKyAgICBzdHJ1Y3Qgc2NtaV9jaGFubmVs
ICpjaGFubmVsOw0KPiArICAgIGludCByZXQ7DQo+ICsNCj4gKyAgICBpZiAoICFzY21pX2RhdGEu
aW5pdGlhbGl6ZWQgKQ0KPiArICAgICAgICByZXR1cm4gMDsNCj4gKw0KPiArICAgIHByaW50ayhY
RU5MT0dfSU5GTyAic2NtaTogZG9tYWluX2lkID0gJWRcbiIsIGQtPmRvbWFpbl9pZCk7DQo+ICsN
Cj4gKyAgICBjaGFubmVsID0gYXF1aXJlX3NjbWlfY2hhbm5lbChkLT5kb21haW5faWQpOw0KPiAr
ICAgIGlmICggSVNfRVJSX09SX05VTEwoY2hhbm5lbCkgKQ0KPiArICAgICAgICByZXR1cm4gLUVO
T0VOVDsNCj4gKw0KPiArI2lmZGVmIENPTkZJR19BUk1fMzINCj4gKyAgICBwcmludGsoWEVOTE9H
X0lORk8NCj4gKyAgICAgICAgICAgInNjbWk6IEFxdWlyZSBTQ01JIGNoYW5uZWwgaWQgPSAweCV4
ICwgZG9tYWluX2lkID0gJWQgcGFkZHIgPSAweCVsbHhcbiIsDQo+ICsgICAgICAgICAgIGNoYW5u
ZWwtPmNoYW5faWQsIGNoYW5uZWwtPmRvbWFpbl9pZCwgY2hhbm5lbC0+cGFkZHIpOw0KPiArI2Vs
c2UNCj4gKyAgICBwcmludGsoWEVOTE9HX0lORk8NCj4gKyAgICAgICAgICAgInNjbWk6IEFxdWly
ZSBTQ01JIGNoYW5uZWwgaWQgPSAweCV4ICwgZG9tYWluX2lkID0gJWQgcGFkZHIgPSAweCVseFxu
IiwNCj4gKyAgICAgICAgICAgY2hhbm5lbC0+Y2hhbl9pZCwgY2hhbm5lbC0+ZG9tYWluX2lkLCBj
aGFubmVsLT5wYWRkcik7DQo+ICsjZW5kaWYNCj4gKw0KPiArICAgIGlmICggaXNfaGFyZHdhcmVf
ZG9tYWluKGQpICkNCj4gKyAgICB7DQo+ICsgICAgICAgIHJldCA9IG1lbV9wZXJtaXRfYWNjZXNz
KGQsIGNoYW5uZWwtPnBhZGRyLCBQQUdFX1NJWkUpOw0KWW91IGFscmVhZHkgaGF2ZSBTQ01JX1NI
TUVNX01BUFBFRF9TSVpFDQpXZSBzaG91bGQgYWxzbyBhc3NlcnQgaWYgU0NNSV9TSE1FTV9NQVBQ
RURfU0laRSAhLSBQQUdFX1NJWkUNCkkgZ3Vlc3MgYXMgY3VycmVudGx5IGFsbCB0aGUgY29kZSBp
cyBidWlsdCB3aXRoIHRoaXMgYXNzdW1wdGlvbg0KPiArICAgICAgICBpZiAoIElTX0VSUl9WQUxV
RShyZXQpICkNCj4gKyAgICAgICAgICAgIGdvdG8gZXJyb3I7DQo+ICsNCj4gKyAgICAgICAgcmV0
ID0gZHRfdXBkYXRlX2RvbWFpbl9yYW5nZShjaGFubmVsLT5wYWRkciwgUEFHRV9TSVpFKTsNCj4g
KyAgICAgICAgaWYgKCBJU19FUlJfVkFMVUUocmV0KSApDQo+ICsgICAgICAgIHsNCj4gKyAgICAg
ICAgICAgIGludCByYyA9IG1lbV9kZW55X2FjY2VzcyhkLCBjaGFubmVsLT5wYWRkciwgUEFHRV9T
SVpFKTsNCj4gKyAgICAgICAgICAgIGlmICggcmMgKQ0KPiArICAgICAgICAgICAgICAgIHByaW50
ayhYRU5MT0dfRVJSICJVbmFibGUgdG8gbWVtX2RlbnlfYWNjZXNzXG4iKTsNCj4gKw0KPiArICAg
ICAgICAgICAgZ290byBlcnJvcjsNCj4gKyAgICAgICAgfQ0KPiArICAgIH0NCj4gKw0KPiArICAg
IGQtPmFyY2guc2NpID0gY2hhbm5lbDsNCj4gKyAgICBpZiAoIGNvbmZpZyApDQo+ICsgICAgICAg
IGNvbmZpZy0+YXJtX3NjaV9hZ2VudF9wYWRkciA9IGNoYW5uZWwtPnBhZGRyOw0KPiArDQo+ICsg
ICAgcmV0dXJuIDA7DQpCbGFuayBsaW5lDQo+ICtlcnJvcjoNCj4gKyAgICByZWxpbnF1aXNoX3Nj
bWlfY2hhbm5lbChjaGFubmVsKTsNCj4gKw0KPiArICAgIHJldHVybiByZXQ7DQo+ICt9DQo+ICsN
Cj4gK3N0YXRpYyBpbnQgc2NtaV9hZGRfZGV2aWNlX2J5X2RldmlkKHN0cnVjdCBkb21haW4gKmQs
IHVpbnQzMl90IHNjbWlfZGV2aWQpDQo+ICt7DQo+ICsgICAgc3RydWN0IHNjbWlfY2hhbm5lbCAq
Y2hhbm5lbCwgKmFnZW50X2NoYW5uZWw7DQo+ICsgICAgc2NtaV9tc2dfaGVhZGVyX3QgaGRyOw0K
PiArICAgIHN0cnVjdCBzY21pX3Blcm1zX3R4IHsNCj4gKyAgICAgICAgdWludDMyX3QgYWdlbnRf
aWQ7DQo+ICsgICAgICAgIHVpbnQzMl90IGRldmljZV9pZDsNCj4gKyAgICAgICAgdWludDMyX3Qg
ZmxhZ3M7DQo+ICsgICAgfSB0eDsNCj4gKyAgICBzdHJ1Y3QgcnhfdCB7DQo+ICsgICAgICAgIGlu
dDMyX3Qgc3RhdHVzOw0KPiArICAgICAgICB1aW50MzJfdCBhdHRyaWJ1dGVzOw0KPiArICAgIH0g
cng7DQo+ICsgICAgaW50IHJldDsNCj4gKw0KPiArICAgIGlmICggIXNjbWlfZGF0YS5pbml0aWFs
aXplZCApDQo+ICsgICAgICAgIHJldHVybiAwOw0KPiArDQo+ICsgICAgcHJpbnRrKFhFTkxPR19E
RUJVRyAic2NtaTogc2NtaV9kZXZpZCA9ICVkXG4iLCBzY21pX2RldmlkKTsNCj4gKw0KPiArICAg
IGFnZW50X2NoYW5uZWwgPSBkLT5hcmNoLnNjaTsNCj4gKyAgICBpZiAoIElTX0VSUl9PUl9OVUxM
KGFnZW50X2NoYW5uZWwpICkNCj4gKyAgICAgICAgcmV0dXJuIFBUUl9FUlIoYWdlbnRfY2hhbm5l
bCk7DQo+ICsNCj4gKyAgICBjaGFubmVsID0gZ2V0X2NoYW5uZWxfYnlfaWQoSFlQX0NIQU5ORUwp
Ow0KPiArICAgIGlmICggSVNfRVJSX09SX05VTEwoY2hhbm5lbCkgKQ0KPiArICAgICAgICByZXR1
cm4gUFRSX0VSUihjaGFubmVsKTsNCj4gKw0KPiArICAgIGhkci5pZCA9IFNDTUlfQkFTRV9TRVRf
REVWSUNFX1BFUk1JU1NJT05TOw0KPiArICAgIGhkci50eXBlID0gMDsNCj4gKyAgICBoZHIucHJv
dG9jb2wgPSBTQ01JX0JBU0VfUFJPVE9DT0w7DQo+ICsNCj4gKyAgICB0eC5hZ2VudF9pZCA9IGFn
ZW50X2NoYW5uZWwtPmFnZW50X2lkOw0KPiArICAgIHR4LmRldmljZV9pZCA9IHNjbWlfZGV2aWQ7
DQo+ICsgICAgdHguZmxhZ3MgPSBTQ01JX0FMTE9XX0FDQ0VTUzsNCj4gKw0KPiArICAgIHJldCA9
IGRvX3NtY194ZmVyKGNoYW5uZWwsICZoZHIsICZ0eCwgc2l6ZW9mKHR4KSwgJnJ4LCBzaXplb2Yo
JnJ4KSk7DQo+ICsgICAgaWYgKCBJU19FUlJfVkFMVUUocmV0KSApDQo+ICsgICAgICAgIHJldHVy
biByZXQ7DQo+ICsNCj4gKyAgICByZXQgPSBjaGVja19zY21pX3N0YXR1cyhyeC5zdGF0dXMpOw0K
PiArICAgIGlmICggSVNfRVJSX1ZBTFVFKHJldCkgKQ0KPiArICAgICAgICByZXR1cm4gcmV0Ow0K
PiArDQo+ICsgICAgcmV0dXJuIDA7DQo+ICt9DQo+ICsNCj4gK3N0YXRpYyBpbnQgc2NtaV9hZGRf
ZHRfZGV2aWNlKHN0cnVjdCBkb21haW4gKmQsIHN0cnVjdCBkdF9kZXZpY2Vfbm9kZSAqZGV2KQ0K
PiArew0KPiArICAgIHVpbnQzMl90IHNjbWlfZGV2aWQ7DQo+ICsNCj4gKyAgICBpZiAoICghc2Nt
aV9kYXRhLmluaXRpYWxpemVkKSB8fCAoIWQtPmFyY2guc2NpKSApDQo+ICsgICAgICAgIHJldHVy
biAwOw0KPiArDQo+ICsgICAgaWYgKCAhZHRfcHJvcGVydHlfcmVhZF91MzIoZGV2LCAic2NtaV9k
ZXZpZCIsICZzY21pX2RldmlkKSApDQo+ICsgICAgICAgIHJldHVybiAwOw0KPiArDQo+ICsgICAg
cHJpbnRrKFhFTkxPR19JTkZPICJzY21pOiBkdF9ub2RlID0gJXNcbiIsIGR0X25vZGVfZnVsbF9u
YW1lKGRldikpOw0KVGhpcyBjb3VsZCBiZSBERUJVRyBwcmludA0KPiArDQo+ICsgICAgcmV0dXJu
IHNjbWlfYWRkX2RldmljZV9ieV9kZXZpZChkLCBzY21pX2RldmlkKTsNCj4gK30NCj4gKw0KPiAr
c3RhdGljIGludCBzY21pX3JlbGlucXVpc2hfcmVzb3VyY2VzKHN0cnVjdCBkb21haW4gKmQpDQo+
ICt7DQo+ICsgICAgaW50IHJldDsNCj4gKyAgICBzdHJ1Y3Qgc2NtaV9jaGFubmVsICpjaGFubmVs
LCAqYWdlbnRfY2hhbm5lbDsNCj4gKyAgICBzY21pX21zZ19oZWFkZXJfdCBoZHI7DQo+ICsgICAg
c3RydWN0IHJlc2V0X2FnZW50X3R4IHsNCj4gKyAgICAgICAgdWludDMyX3QgYWdlbnRfaWQ7DQo+
ICsgICAgICAgIHVpbnQzMl90IGZsYWdzOw0KPiArICAgIH0gdHg7DQo+ICsgICAgdWludDMyX3Qg
cng7DQo+ICsNCj4gKyAgICBpZiAoICFkLT5hcmNoLnNjaSApDQo+ICsgICAgICAgIHJldHVybiAw
Ow0KPiArDQo+ICsgICAgYWdlbnRfY2hhbm5lbCA9IGQtPmFyY2guc2NpOw0KPiArDQo+ICsgICAg
c3Bpbl9sb2NrKCZhZ2VudF9jaGFubmVsLT5sb2NrKTsNCj4gKyAgICB0eC5hZ2VudF9pZCA9IGFn
ZW50X2NoYW5uZWwtPmFnZW50X2lkOw0KPiArICAgIHNwaW5fdW5sb2NrKCZhZ2VudF9jaGFubmVs
LT5sb2NrKTsNCj4gKw0KPiArICAgIGNoYW5uZWwgPSBnZXRfY2hhbm5lbF9ieV9pZChIWVBfQ0hB
Tk5FTCk7DQo+ICsgICAgaWYgKCAhY2hhbm5lbCApDQo+ICsgICAgew0KPiArICAgICAgICBwcmlu
dGsoWEVOTE9HX0VSUg0KPiArICAgICAgICAgICAgICAgInNjbWk6IFVuYWJsZSB0byBnZXQgSHlw
ZXJ2aXNvciBzY21pIGNoYW5uZWwgZm9yIGRvbWFpbiAlZFxuIiwNCj4gKyAgICAgICAgICAgICAg
IGQtPmRvbWFpbl9pZCk7DQo+ICsgICAgICAgIHJldHVybiAtRUlOVkFMOw0KPiArICAgIH0NCj4g
Kw0KPiArICAgIGhkci5pZCA9IFNDTUlfQkFTRV9SRVNFVF9BR0VOVF9DT05GSUdVUkFUSU9OOw0K
PiArICAgIGhkci50eXBlID0gMDsNCj4gKyAgICBoZHIucHJvdG9jb2wgPSBTQ01JX0JBU0VfUFJP
VE9DT0w7DQo+ICsNCj4gKyAgICB0eC5mbGFncyA9IDA7DQo+ICsNCj4gKyAgICByZXQgPSBkb19z
bWNfeGZlcihjaGFubmVsLCAmaGRyLCAmdHgsIHNpemVvZih0eCksICZyeCwgc2l6ZW9mKHJ4KSk7
DQo+ICsgICAgaWYgKCByZXQgKQ0KPiArICAgICAgICByZXR1cm4gcmV0Ow0KPiArDQo+ICsgICAg
cmV0ID0gY2hlY2tfc2NtaV9zdGF0dXMocngpOw0KPiArDQo+ICsgICAgcmV0dXJuIHJldDsNCj4g
K30NCj4gKw0KPiArc3RhdGljIHZvaWQgc2NtaV9kb21haW5fZGVzdHJveShzdHJ1Y3QgZG9tYWlu
ICpkKQ0KPiArew0KPiArICAgIHN0cnVjdCBzY21pX2NoYW5uZWwgKmNoYW5uZWw7DQo+ICsNCj4g
KyAgICBpZiAoICFkLT5hcmNoLnNjaSApDQo+ICsgICAgICAgIHJldHVybjsNCj4gKw0KPiArICAg
IGNoYW5uZWwgPSBkLT5hcmNoLnNjaTsNCj4gKyAgICBzcGluX2xvY2soJmNoYW5uZWwtPmxvY2sp
Ow0KPiArDQo+ICsgICAgcmVsaW5xdWlzaF9zY21pX2NoYW5uZWwoY2hhbm5lbCk7DQo+ICsgICAg
cHJpbnRrKFhFTkxPR19ERUJVRyAic2NtaTogRnJlZSBkb21haW4gJWRcbiIsIGQtPmRvbWFpbl9p
ZCk7DQo+ICsNCj4gKyAgICBkLT5hcmNoLnNjaSA9IE5VTEw7DQo+ICsNCj4gKyAgICBtZW1fZGVu
eV9hY2Nlc3MoZCwgY2hhbm5lbC0+cGFkZHIsIFBBR0VfU0laRSk7DQo+ICsgICAgc3Bpbl91bmxv
Y2soJmNoYW5uZWwtPmxvY2spOw0KPiArfQ0KPiArDQo+ICtzdGF0aWMgYm9vbCBzY21pX2hhbmRs
ZV9jYWxsKHN0cnVjdCBkb21haW4gKmQsIHZvaWQgKmFyZ3MpDQo+ICt7DQo+ICsgICAgYm9vbCBy
ZXMgPSBmYWxzZTsNCj4gKyAgICBzdHJ1Y3Qgc2NtaV9jaGFubmVsICphZ2VudF9jaGFubmVsOw0K
PiArICAgIHN0cnVjdCBhcm1fc21jY2NfcmVzIHJlc3A7DQo+ICsgICAgc3RydWN0IGNwdV91c2Vy
X3JlZ3MgKnJlZ3MgPSBhcmdzOw0KPiArDQo+ICsgICAgaWYgKCAhZC0+YXJjaC5zY2kgKQ0KPiAr
ICAgICAgICByZXR1cm4gZmFsc2U7DQo+ICsNCj4gKyAgICBhZ2VudF9jaGFubmVsID0gZC0+YXJj
aC5zY2k7DQo+ICsgICAgc3Bpbl9sb2NrKCZhZ2VudF9jaGFubmVsLT5sb2NrKTsNCj4gKw0KPiAr
ICAgIGlmICggYWdlbnRfY2hhbm5lbC0+ZnVuY19pZCAhPSByZWdzLT5yMCApDQo+ICsgICAgew0K
PiArICAgICAgICByZXMgPSBmYWxzZTsNCj4gKyAgICAgICAgZ290byB1bmxvY2s7DQo+ICsgICAg
fQ0KPiArDQo+ICsgICAgYXJtX3NtY2NjX3NtYyhhZ2VudF9jaGFubmVsLT5mdW5jX2lkLCAwLCAw
LCAwLCAwLCAwLCAwLA0KPiArICAgICAgICAgICAgICAgICAgYWdlbnRfY2hhbm5lbC0+Y2hhbl9p
ZCwgJnJlc3ApOw0KPiArDQo+ICsgICAgc2V0X3VzZXJfcmVnKHJlZ3MsIDAsIHJlc3AuYTApOw0K
PiArICAgIHNldF91c2VyX3JlZyhyZWdzLCAxLCByZXNwLmExKTsNCj4gKyAgICBzZXRfdXNlcl9y
ZWcocmVncywgMiwgcmVzcC5hMik7DQo+ICsgICAgc2V0X3VzZXJfcmVnKHJlZ3MsIDMsIHJlc3Au
YTMpOw0KPiArICAgIHJlcyA9IHRydWU7DQo+ICt1bmxvY2s6DQo+ICsgICAgc3Bpbl91bmxvY2so
JmFnZW50X2NoYW5uZWwtPmxvY2spOw0KPiArDQo+ICsgICAgcmV0dXJuIHJlczsNCj4gK30NCj4g
Kw0KPiArc3RhdGljIGNvbnN0IHN0cnVjdCBkdF9kZXZpY2VfbWF0Y2ggc2NtaV9zbWNfbWF0Y2hb
XSBfX2luaXRjb25zdCA9DQo+ICt7DQo+ICsgICAgRFRfTUFUQ0hfU0NNSV9TTUMsDQo+ICsgICAg
eyAvKiBzZW50aW5lbCAqLyB9LA0KPiArfTsNCj4gKw0KPiArc3RhdGljIGNvbnN0IHN0cnVjdCBz
Y2lfbWVkaWF0b3Jfb3BzIHNjbWlfb3BzID0NCj4gK3sNCj4gKyAgICAucHJvYmUgPSBzY21pX3By
b2JlLA0KPiArICAgIC5kb21haW5faW5pdCA9IHNjbWlfZG9tYWluX2luaXQsDQo+ICsgICAgLmRv
bWFpbl9kZXN0cm95ID0gc2NtaV9kb21haW5fZGVzdHJveSwNCj4gKyAgICAuYWRkX2R0X2Rldmlj
ZSA9IHNjbWlfYWRkX2R0X2RldmljZSwNCj4gKyAgICAucmVsaW5xdWlzaF9yZXNvdXJjZXMgPSBz
Y21pX3JlbGlucXVpc2hfcmVzb3VyY2VzLA0KPiArICAgIC5oYW5kbGVfY2FsbCA9IHNjbWlfaGFu
ZGxlX2NhbGwsDQo+ICt9Ow0KPiArDQo+ICtSRUdJU1RFUl9TQ0lfTUVESUFUT1Ioc2NtaV9zbWMs
ICJTQ01JLVNNQyIsIFhFTl9ET01DVExfQ09ORklHX0FSTV9TQ0lfU0NNSV9TTUMsDQo+ICsgICAg
ICAgICAgICAgICAgICAgICAgc2NtaV9zbWNfbWF0Y2gsICZzY21pX29wcyk7DQo+ICsNCj4gKy8q
DQo+ICsgKiBMb2NhbCB2YXJpYWJsZXM6DQo+ICsgKiBtb2RlOiBDDQo+ICsgKiBjLWZpbGUtc3R5
bGU6ICJCU0QiDQo+ICsgKiBjLWJhc2ljLW9mZnNldDogNA0KPiArICogaW5kZW50LXRhYnMtbW9k
ZTogbmlsDQo+ICsgKiBFbmQ6DQo+ICsgKi8NCg0KWzFdIGh0dHBzOi8vd3d3Lmtlcm5lbC5vcmcv
ZG9jL2xvY2FsL2lubGluZS5odG1sDQpbMl0gaHR0cHM6Ly9lbGl4aXIuYm9vdGxpbi5jb20vbGlu
dXgvdjUuMTctcmMzL3NvdXJjZS9hcmNoL2FybTY0L2tlcm5lbC9pby5j


From xen-devel-bounces@lists.xenproject.org Wed Feb 09 15:04:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 09 Feb 2022 15:04:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269271.463304 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHoWN-0007N7-Jd; Wed, 09 Feb 2022 15:04:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269271.463304; Wed, 09 Feb 2022 15:04:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHoWN-0007My-Fc; Wed, 09 Feb 2022 15:04:39 +0000
Received: by outflank-mailman (input) for mailman id 269271;
 Wed, 09 Feb 2022 15:04:38 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=XFrC=SY=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nHoWM-0007Bo-AA
 for xen-devel@lists.xenproject.org; Wed, 09 Feb 2022 15:04:38 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 98d2a195-89b9-11ec-8f75-fffcc8bd4f1a;
 Wed, 09 Feb 2022 16:04:37 +0100 (CET)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2054.outbound.protection.outlook.com [104.47.6.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-29-o-4APSYZNMqEboLW9ddFcw-1; Wed, 09 Feb 2022 16:04:36 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DBBPR04MB7771.eurprd04.prod.outlook.com (2603:10a6:10:1e6::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Wed, 9 Feb
 2022 15:04:35 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.018; Wed, 9 Feb 2022
 15:04:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 98d2a195-89b9-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644419077;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=6ywwb/AXK6RvMZfa8QkYY8DYs+Xp/vFTpRFaCIs90yk=;
	b=EhKzzw9+ztjMDXfF/DjyrUMeiS0TSUKzazwjj8HoQOa6PcgFR7lNgRtj72qOz+cwalRviq
	8UHHf8vqJaj1gzImZ17glNEnONpI7lyso6NHGtJrUs1GazHsXPjQnVMePzN3u3E7fH/8gL
	C3GOHh3ugz83H6/4KZJ+cvcTK4bTrMw=
X-MC-Unique: o-4APSYZNMqEboLW9ddFcw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=akdygVXl7UaJL2zVVRFXSWIV54bGT/GQmrRD292tC/noUptcDTzpvQpay/dsfF/b9Yxa89zbT2bw6C793KSMsnh0wfVlolM6frMsL8KCh6f+jbL2PLvlD+f74p8iDv+/OybjchrKlj5bLXWNv5APKWytdlg5jHTPxB7yjVBVlyn54VYFZl2QgsdzUHXhtp2CktagwjecaWWHxPO+FiKVrXsV8ryT4I17vTQD1PYP5V24zoaDweTvX1hPpfXGNUBcd3AxymU1viwU+vdMozMscChgLgV8RMUL5B2f6U5LnfLXCNTJzG+fDVHXOihFqtPulg89THpEVj7hoSbpWJC1dg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=6ywwb/AXK6RvMZfa8QkYY8DYs+Xp/vFTpRFaCIs90yk=;
 b=DbdI6Pn9sylQ762qeDXarSCwZhu4n1o1PjIAtjCfyqLaZaWkqQfXB3CIZ8bjNfHEGgMyIl++zBiEOXqopusyojHyqFeefyiXWIocQhxitPJ8Lp4IHBK2OEOUOw5PkpzfZ6BtlAgqZFTgOePK5xgRPqSYYbVjuAhwSEpIFJrk1okCN1btZAsUhheJMF6Sh4bD7hFqsgktRBRxbo0QtlUHr//+rCR7ochZIA8By0oxdfNsy6dO7fw/F4f2hwplSSYqSnIOx/DKn7t/pTfaZNHIJ8UvwplTQNUJOJT7ujhJ+XDb2km8NPCANpT9ccScFJDyx3mxzFxORBhCNzVHrsZOTw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <909eb105-c91b-aea1-c0da-c8ec59c5721d@suse.com>
Date: Wed, 9 Feb 2022 16:04:33 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH 0/2] x86: Use Multiboot framebuffer
Content-Language: en-US
To: Tu Dinh Ngoc <dinhngoc.tu@irit.fr>
References: <20220209130907.252-1-dinhngoc.tu@irit.fr>
Cc: xen-devel@lists.xenproject.org
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220209130907.252-1-dinhngoc.tu@irit.fr>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR0P281CA0061.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:49::16) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9a3ba027-4ea0-43b5-1fe1-08d9ebdd7bac
X-MS-TrafficTypeDiagnostic: DBBPR04MB7771:EE_
X-Microsoft-Antispam-PRVS:
	<DBBPR04MB7771EAB1531F30CD241F4E7DB32E9@DBBPR04MB7771.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6108;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	+xAasQtWsVwv4XQzO4Ob2NfOeVP2jTnnyt3lJD1HLTBkmKsJO7/mghRU6LTKui008iQ3wOrXgxuXo0fa92040wvR+6Jf3oYywz74NMpH5M6gpEm1Qxvbe0c2obu7cZTSBgYiAYb4vuGe0g2+eS+3h2ZR+KtvuYp2F71+sQc6zvwlIGmzoXPKu2q1rwMVMt/rqkLZLm1YrfEGq5ocg2cL9K0B06OLDYYOl5v1Bk85E7mE7koQW3M8nOLl66DtwW6EuvIs+dIaDsRo3/VRXyYrRLZEZaZ7k0hyi+kFBtp9UEkPN2lQfUr5ChL1iG2BvSrbbDG0Kp8uSA3Wnl2hXIT9f3W0Aw+iSvajOflu4lwS+wEeuEHyn5FK9XrIiHuBApw+p/jArBn8WElAFFBvFo+Pk8Su/hIFO5Rim5qVM6fxna7cnVwXS8a8yoOFquzhnVxB3wMHTRsbwiGIcKKZna2c2PKZabXQ+sLQpnfv2L0niJjgJmNeWVGB4PDpVMGtPNptUEaU5Fm6TYVJ5VtVxZygmDUf0gJksmFp9abdhPRNjaJ02WWZw8Sf2O77ZICMzvkuEFN0v0oYEL+yNKDHPShlH3KJL4WU8hIxoI8U9PCtfzo4+lc8gqJjdo/iQ2KSKWe6GaazIqh2kPpSO5yzdhWYJMzGhPjoCcWaVpNKsrWp5GYpOYPveBcsT1rnzMqfDJOiBJYjwN6h/Ekq5wUbaDFDEf4qlKn41DxpXdUd4s2OJXcWirhxEj2uYTTVaCMaXCNdEIf++tdLESNYANqI2dqew/ETmvUb+28Flz/zJpMMyP/xPodzyJBu6tQNwAg6HNQe
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66946007)(8676002)(4326008)(66476007)(66556008)(38100700002)(31686004)(5660300002)(8936002)(6916009)(316002)(36756003)(2906002)(4744005)(6512007)(31696002)(6506007)(53546011)(26005)(508600001)(186003)(966005)(2616005)(6486002)(83380400001)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Qkpjc0U2YXp1a0V3K3pxWmQrTUEvcTVVYmJrMy9mcUN3dUs2THVvbmZNMGtV?=
 =?utf-8?B?c29YejJFeFNJYXZqVXRCMkRTNURnbERvRS8reTRWRW41MmhnZFgyYUM0aUJo?=
 =?utf-8?B?NitKeUI0L0dEdVlqc0wydjZWSHo2d2RnQnFHQldSazR4NjlUVENkdzd6MkZK?=
 =?utf-8?B?RFp1eGpNU1J6TUlBbUxWK0RRNG5yS3lFL3BOTk92T3dGUzdlYnRVYkhwb3dJ?=
 =?utf-8?B?K2s3bEtPdjlqeGVqVW1tZ2Q5MXVIaHJkRldTMHRlWHp5TTJQc0ZRQ1RqM1ov?=
 =?utf-8?B?VTBVVmdWSnhsZ2FDNldwanhnWHRkcjB6Z1BvN0pONENMckY0UmdmK2tGSjhN?=
 =?utf-8?B?dGk3OTZOVTVpU0VJbG1ueFBWZkNZRHJ6VVlDRkJTQUdNZ2JBekVyQXZrMU1y?=
 =?utf-8?B?UVZlNHpSazdCb0NVbTNhOElWQitMMy9kazQzM1JUZXRCTk9LdTJpdXZGNjdJ?=
 =?utf-8?B?VTJndDRWdHRoVTFJT05yYkY0UWNtRnQwZXR2K1hHZ3ZwaFNXTEprRDI1TENV?=
 =?utf-8?B?WHFYSVZRdUdKdHNjSklWR01EU3NDMGtIbTJMSFRrMHhiOWtrZXM1cGFJZ3By?=
 =?utf-8?B?MVN3bHNVb3Z0QjFqNnNkamJ2TG1QRGZ6MzZHWHFwZG5zdVlZSUE2aTZ1c00x?=
 =?utf-8?B?RE96R1JWVjN5Smc0eEFWbEVLdmNVNlhMOG1MK1RCTjdGSElnVjE4Ym91VFly?=
 =?utf-8?B?ajJERUZqNG5SdWVXYTlOZmREUWJzL1c3aU94VEFPSHhLRGxHenQvbno2Nytu?=
 =?utf-8?B?LzcrN3dhd3NEZ2xjV2E0VmlqZUJybDNPUG9xNkloYVppMWgwVGFackRIeFhP?=
 =?utf-8?B?bGExWTIzZEs2S0drVmd6VEpyMFRDc01ZeW1MSWtGUStuZk5wUVl4WnpUdGxW?=
 =?utf-8?B?R0QvZnZVcmZzc1FYUDFEK3ZRbGJnM296Z3FZRXYxdmxJcWZXTTR5aUNHbjZo?=
 =?utf-8?B?R0VRRE5NYllpREhkRXFodTBiUjEzSjQrQmxEbWZ2WGNHNkpPcVg4ekZqaUJm?=
 =?utf-8?B?VzEyMGZGblZzdW5xSGg4aG9GajVBakprT0xqck12bm1DUkJDbnNSZ1BxVU9E?=
 =?utf-8?B?cWhmeVI0SWU4Y0k0REF1RXBVeUVPczVSZDZhc0w0UzdvWUFQbW1ZdEFnRVF1?=
 =?utf-8?B?ZXJxZUdicEZGalc3OUQ0S2RNMy82YnBKRW9pY2QxWXhUM1dBdzRua2lCVkRt?=
 =?utf-8?B?S2UxdVpHL2d1ZG5IVXcxZEVGSlAxbG9vSTA5Q2xlQWcyQ1RFVSsrOHFhSGlB?=
 =?utf-8?B?Rml1VU8rRW8wWHVTV1Q5Q3I5QndyWkp3b3JONGRTUG05TUxxTWdnc0xhY3Uz?=
 =?utf-8?B?RmQxTTQrTWhWMXlzZ01DVzREQlV6RFlWVUpzcXNjTXhYTUMzOTZSNjZ2VnNL?=
 =?utf-8?B?M0VNbytkZWRZTkpVWGpnb0ZtVERnYVVxVlVqbUlFVTE0Yzg5MjBtMlVnR0FJ?=
 =?utf-8?B?b2tLbXYvYXdnZW5rRHplSExnQnRGa0ZnWE93eDJwVVZGb3pGV1lhMEYzbGRz?=
 =?utf-8?B?ZFh2ZUVWZ2IrZVhKakIwR25xUlhlbU55MUdFNE1RZ2ZKR2EyOVJZNFF0SVgx?=
 =?utf-8?B?aTdteGRwZWliVGpsMENpYVZ4Q3Erb3JCakpZZnhuMkRucnltODd0WWJHNFVu?=
 =?utf-8?B?R1dOVE9Xc21qUGFXZDZVYzNiQmhEM3lxV0lqNXdKaGIzc1MvQ1B4SmVVd0da?=
 =?utf-8?B?MTBpYndGNXYrdGxkd2ZnYXI4cGJmNWJBVWllS0R1QVI4dFgxTDhtOWNTdVpX?=
 =?utf-8?B?bGlJY09sWFpzeVQxeVRWSFFGU1FMYWRsUWZTWlVUUmFaS1NJbUM0TWs0c1RO?=
 =?utf-8?B?SjFVSUc5SXJhMnV2UXg3NXZ1SVBJVmRiblVhVVh4NmFWWWp4bGNWTFVzYVZN?=
 =?utf-8?B?REQ0K29kQm84QjF1djJjT2dzRFpwMEkwdTR4d0pqYVRGUDZVdXFXalhwNGpV?=
 =?utf-8?B?Y2c2VkxoYVRNOC8rTFZYS3ZLTitlQTdMb0NGQk5MbXNkYm1CN0J3ZzUvZ0Z0?=
 =?utf-8?B?ZkVCN3htU2RydkxGQmJ0eDV2cjBneUNLT3VkejEwbVIwUHBDSS9MdTUwNHdN?=
 =?utf-8?B?L245K2Z2REQzeUR6WHRiZi9NV25sNWcyRnFoV1E4QkhudnZjWFlYMG85eWVY?=
 =?utf-8?B?eDkxMndkTitaTnhvV2J3cm9aeHJOQmpLbWE1NmphUW5oT1ZDT043Ymw2MUNM?=
 =?utf-8?Q?3roGFMcq8wWCn53S0MPPbY4=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9a3ba027-4ea0-43b5-1fe1-08d9ebdd7bac
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2022 15:04:34.7625
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EknlouhHwJ90DIB6ja/ZwVMngxBTsU1fRALh+4tWKe885dfftBIzZjqdeTmUo8LvmY6qt5MJa9aFAGUHnO/KIQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7771

On 09.02.2022 14:09, Tu Dinh Ngoc wrote:
> Xen does not currently use the Multiboot framebuffer. This means there
> is no graphics when booting Xen with Kexec.
> 
> This patchset parses and uses the Multiboot framebuffer information
> during boot.
> 
> Tu Dinh Ngoc (2):
>   x86: Parse Multiboot2 framebuffer information
>   x86: Set up framebuffer given by Multiboot2
> 
>  xen/arch/x86/boot/reloc.c    | 22 ++++++++++++++++++
>  xen/arch/x86/setup.c         | 45 +++++++++++++++++++++++++++++++++---
>  xen/include/xen/multiboot.h  | 17 ++++++++++++++
>  xen/include/xen/multiboot2.h | 33 ++++++++++++++++++++++++++
>  4 files changed, 114 insertions(+), 3 deletions(-)

Btw, please see also
https://lists.xen.org/archives/html/xen-devel/2021-12/msg00379.html

Jan



From xen-devel-bounces@lists.xenproject.org Wed Feb 09 15:06:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 09 Feb 2022 15:06:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269280.463315 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHoYX-000845-1J; Wed, 09 Feb 2022 15:06:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269280.463315; Wed, 09 Feb 2022 15:06:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHoYW-00083y-Sd; Wed, 09 Feb 2022 15:06:52 +0000
Received: by outflank-mailman (input) for mailman id 269280;
 Wed, 09 Feb 2022 15:06:51 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nHoYV-000831-TO
 for xen-devel@lists.xenproject.org; Wed, 09 Feb 2022 15:06:51 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nHoYV-00070B-Mv; Wed, 09 Feb 2022 15:06:51 +0000
Received: from 54-240-197-228.amazon.com ([54.240.197.228]
 helo=[192.168.1.215]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nHoYV-0007EO-HI; Wed, 09 Feb 2022 15:06:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=zHYMQ86MlMfcRuUbB+OHuiPjXxRPxV7eopqvTa0WZ0U=; b=xDMv5H2WjHq8hu45OhdEldZt4p
	skHRm1XzeRnNMmOMa9ywxT97OJNHWFP/l1xOXcAjK1Ehx7H9P4fp2HcYNquM8VO+buBlyQ9eONKZk
	OXkKvPNq+IGesjkEv+tEdetorreRNoQdLvtW0ZTVwUw6GDyIrT+O1W3HgsT+2yrQ+JFE=;
Message-ID: <d61d1368-9cdb-de19-079a-da41213c2659@xen.org>
Date: Wed, 9 Feb 2022 15:06:49 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.1
Subject: Re: [PATCH v5 07/11] xen/arm: if direct-map domain use native
 addresses for GICv2
To: Penny Zheng <penny.zheng@arm.com>, xen-devel@lists.xenproject.org,
 sstabellini@kernel.org
Cc: Bertrand.Marquis@arm.com, Wei.Chen@arm.com
References: <20220127074929.502885-1-penny.zheng@arm.com>
 <20220127074929.502885-8-penny.zheng@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220127074929.502885-8-penny.zheng@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Penny,

On 27/01/2022 07:49, Penny Zheng wrote:
> From: Stefano Stabellini <sstabellini@kernel.org>
> 
> Today we use native addresses to map the GICv2 for Dom0 and fixed
> addresses for DomUs.
> 
> This patch changes the behavior so that native addresses are used for
> all domains that are direct-mapped.
> 
> NEW VGIC has different naming schemes, like referring distributor base
> address as vgic_dist_base, other than the dbase. So this patch also introduces
> vgic_dist_base/vgic_cpu_base accessor to access correct distributor base
> address/cpu interface base address on varied scenarios,
> 
> Signed-off-by: Stefano Stabellini <sstabellini@kernel.org>
> Signed-off-by: Penny Zheng <penny.zheng@arm.com>
> Tested-by: Stefano Stabellini <sstabellini@kernel.org>

Reviewed-by: Julien Grall <jgrall@amazon.com>

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Feb 09 15:16:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 09 Feb 2022 15:16:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269290.463326 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHohm-000158-TP; Wed, 09 Feb 2022 15:16:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269290.463326; Wed, 09 Feb 2022 15:16:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHohm-000151-P0; Wed, 09 Feb 2022 15:16:26 +0000
Received: by outflank-mailman (input) for mailman id 269290;
 Wed, 09 Feb 2022 15:16:25 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nHohl-00014v-8N
 for xen-devel@lists.xenproject.org; Wed, 09 Feb 2022 15:16:25 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nHohl-0007Ag-1v; Wed, 09 Feb 2022 15:16:25 +0000
Received: from 54-240-197-228.amazon.com ([54.240.197.228]
 helo=[192.168.1.215]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nHohk-0007uM-Sd; Wed, 09 Feb 2022 15:16:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=tnIKeUJpoZVtK4wLOax0GOcNxahhhcrSZ65cOS5nri4=; b=aRQ5UBMiPFth0wOi9riG7LnAp3
	+sWKH2jFpVx7hPdGAsVVnuXpA22rekkquKXq57LmeID7fNK+zWrLNEjKtDIndEeMiZLXsxHnwwxSv
	etiOkHNY4E8RVdFq1rcdgu7eAHVEZbNPmpfRUmHKoyj3n2586T454i/WpqAgX4G+YXik=;
Message-ID: <62b97822-6609-7556-962c-8684b187030b@xen.org>
Date: Wed, 9 Feb 2022 15:16:23 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.1
Subject: Re: [PATCH v5 09/11] xen/arm: if direct-map domain use native
 addresses for GICv3
To: Penny Zheng <penny.zheng@arm.com>, xen-devel@lists.xenproject.org,
 sstabellini@kernel.org
Cc: Bertrand.Marquis@arm.com, Wei.Chen@arm.com
References: <20220127074929.502885-1-penny.zheng@arm.com>
 <20220127074929.502885-10-penny.zheng@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220127074929.502885-10-penny.zheng@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Penny,

On 27/01/2022 07:49, Penny Zheng wrote:
> diff --git a/xen/arch/arm/include/asm/domain.h b/xen/arch/arm/include/asm/domain.h
> index cb37ce89ec..848fec8a0f 100644
> --- a/xen/arch/arm/include/asm/domain.h
> +++ b/xen/arch/arm/include/asm/domain.h
> @@ -31,6 +31,20 @@ enum domain_type {
>   
>   #define is_domain_direct_mapped(d) (d->arch.directmap)
>   
> +/*
> + * Is the domain using the host memory layout?
> + *
> + * Direct-mapped domain will always have the RAM mapped with GFN == MFN.
> + * To avoid any trouble finding space, it is easier to force using the
> + * host memory layout.
> + *
> + * The hardware domain will use the host layout regardless of
> + * direct-mapped because some OS may rely on a specific address ranges
> + * for the devices.
> + */
> +#define domain_use_host_layout(d) (is_domain_direct_mapped(d) || \
> +                                   is_hardware_domain(d))
> +
>   struct vtimer {
>       struct vcpu *v;
>       int irq;
> diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c
> index 65bb7991a6..144089a7b6 100644
> --- a/xen/arch/arm/vgic-v3.c
> +++ b/xen/arch/arm/vgic-v3.c
> @@ -1640,14 +1640,15 @@ static inline unsigned int vgic_v3_max_rdist_count(struct domain *d)
>        * Normally there is only one GICv3 redistributor region.
>        * The GICv3 DT binding provisions for multiple regions, since there are
>        * platforms out there which need those (multi-socket systems).
> -     * For Dom0 we have to live with the MMIO layout the hardware provides,
> -     * so we have to copy the multiple regions - as the first region may not
> -     * provide enough space to hold all redistributors we need.
> +     * For domain using the host memory layout, we have to live with the MMIO
> +     * layout the hardware provides, so we have to copy the multiple regions
> +     * - as the first region may not provide enough space to hold all
> +     * redistributors we need.
>        * However DomU get a constructed memory map, so we can go with

This sentence imply all domUs will use a constructed memory map. I would 
replace "However DomU" with "All the other domains will get a ...".

With that updated:

Reviewed-by: Julien Grall <jgrall@amazon.com>

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Feb 09 15:19:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 09 Feb 2022 15:19:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269296.463336 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHokJ-0001ih-9F; Wed, 09 Feb 2022 15:19:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269296.463336; Wed, 09 Feb 2022 15:19:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHokJ-0001ia-6K; Wed, 09 Feb 2022 15:19:03 +0000
Received: by outflank-mailman (input) for mailman id 269296;
 Wed, 09 Feb 2022 15:19:02 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nHokI-0001iU-OK
 for xen-devel@lists.xenproject.org; Wed, 09 Feb 2022 15:19:02 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nHokI-0007FU-FP; Wed, 09 Feb 2022 15:19:02 +0000
Received: from 54-240-197-228.amazon.com ([54.240.197.228]
 helo=[192.168.1.215]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nHokI-00081n-9t; Wed, 09 Feb 2022 15:19:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=dDyJRDojRyImTcR8brNKqsf72ejG1zg7dCu3fTd6OWs=; b=ElK8mK1pevgWEhKrdGlLBGHp2O
	UmBh7OqWwukgXyPmYd7ZTYbVWuTKUtRhM7rOHE++q6zTdtywdL4uSKJ9dQop0vTJL6HlTh5gYiqWB
	5M7tzctbQzjhpb+j2nVjPj3AP96dC7x/oTk2eCE2KOgYhIMuIgTW4vBcRnU2ib9QC270=;
Message-ID: <a6d0b96b-7776-660b-4e06-e1c5649cd328@xen.org>
Date: Wed, 9 Feb 2022 15:19:00 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.1
Subject: Re: [PATCH v5 10/11] xen/arm: if direct-map domain use native UART
 address and IRQ number for vPL011
To: Penny Zheng <penny.zheng@arm.com>, xen-devel@lists.xenproject.org,
 sstabellini@kernel.org
Cc: Bertrand.Marquis@arm.com, Wei.Chen@arm.com
References: <20220127074929.502885-1-penny.zheng@arm.com>
 <20220127074929.502885-11-penny.zheng@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220127074929.502885-11-penny.zheng@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Penny,

On 27/01/2022 07:49, Penny Zheng wrote:
> From: Stefano Stabellini <sstabellini@kernel.org>
> 
> We always use a fix address to map the vPL011 to domains. The address
> could be a problem for direct-map domains.
> 
> So, for domains that are directly mapped, reuse the address of the
> physical UART on the platform to avoid potential clashes.
> 
> Do the same for the virtual IRQ number: instead of always using
> GUEST_VPL011_SPI, try to reuse the physical SPI number if possible.
> 
> Signed-off-by: Stefano Stabellini <sstabellini@kernel.org>
> Signed-off-by: Penny Zheng <penny.zheng@arm.com>
> Tested-by: Stefano Stabellini <sstabellini@kernel.org>

Reviewed-by: Julien Grall <jgrall@amazon.com>

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Feb 09 15:20:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 09 Feb 2022 15:20:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269303.463348 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHolK-00032o-Kb; Wed, 09 Feb 2022 15:20:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269303.463348; Wed, 09 Feb 2022 15:20:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHolK-00032f-HN; Wed, 09 Feb 2022 15:20:06 +0000
Received: by outflank-mailman (input) for mailman id 269303;
 Wed, 09 Feb 2022 15:20:05 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nHolJ-0002yH-O9
 for xen-devel@lists.xenproject.org; Wed, 09 Feb 2022 15:20:05 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nHolJ-0007GT-GT; Wed, 09 Feb 2022 15:20:05 +0000
Received: from 54-240-197-236.amazon.com ([54.240.197.236]
 helo=[192.168.1.215]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nHolJ-00084D-BD; Wed, 09 Feb 2022 15:20:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=aSOTKEIpqQULaosjZSw9GG7ELsBiN1+EpQQffKj5jfA=; b=KcgO4XPuliRoq4bpzTi/IBBaLN
	k9yNp5tTgatFO3RvAane2m9X/ul0Xe7NJkf778cNhkYf17Y6fmaxe/TKwB3I0VQfory0SNlCnZsXY
	y2wh848O8q9RXJENQLHX0u5gorq052h54YU5l5q6vArSo497yadYm1tM2hgDp1XA4SIs=;
Message-ID: <c488e56f-054c-9c46-ea8b-77d326ebed81@xen.org>
Date: Wed, 9 Feb 2022 15:20:03 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.1
Subject: Re: [PATCH v5 11/11] xen/docs: Document how to do passthrough without
 IOMMU
To: Penny Zheng <penny.zheng@arm.com>, xen-devel@lists.xenproject.org,
 sstabellini@kernel.org
Cc: Bertrand.Marquis@arm.com, Wei.Chen@arm.com
References: <20220127074929.502885-1-penny.zheng@arm.com>
 <20220127074929.502885-12-penny.zheng@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220127074929.502885-12-penny.zheng@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Penny,

On 27/01/2022 07:49, Penny Zheng wrote:
> From: Stefano Stabellini <sstabellini@kernel.org>
> 
> This commit creates a new doc to document how to do passthrough without IOMMU.
> 
> Signed-off-by: Stefano Stabellini <sstabellini@kernel.org>
> Signed-off-by: Penny Zheng <penny.zheng@arm.com>
> Tested-by: Stefano Stabellini <sstabellini@kernel.org>

Acked-by: Julien Grall <jgrall@amazon.com>

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Feb 09 15:20:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 09 Feb 2022 15:20:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269307.463358 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHolf-0003WV-SA; Wed, 09 Feb 2022 15:20:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269307.463358; Wed, 09 Feb 2022 15:20:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHolf-0003WO-PA; Wed, 09 Feb 2022 15:20:27 +0000
Received: by outflank-mailman (input) for mailman id 269307;
 Wed, 09 Feb 2022 15:20:26 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=50R8=SY=irit.fr=dinhngoc.tu@srs-se1.protection.inumbo.net>)
 id 1nHole-0003QJ-R9
 for xen-devel@lists.xenproject.org; Wed, 09 Feb 2022 15:20:26 +0000
Received: from smtp1.irit.fr (smtp1.irit.fr [141.115.24.2])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ce0110a5-89bb-11ec-8eb8-a37418f5ba1a;
 Wed, 09 Feb 2022 16:20:25 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ce0110a5-89bb-11ec-8eb8-a37418f5ba1a
From: <dinhngoc.tu@irit.fr>
To: "'Jan Beulich'" <jbeulich@suse.com>
Cc: <xen-devel@lists.xenproject.org>
References: <fe2e94e8-9e46-82be-6e83-391f4709ef75@suse.com> <20220209131251.387-1-dinhngoc.tu@irit.fr> <ad339015-c5e7-d776-17a3-2dbd337fcd4a@suse.com>
In-Reply-To: <ad339015-c5e7-d776-17a3-2dbd337fcd4a@suse.com>
Subject: RE: [PATCH v2] x86: Use low memory size directly from Multiboot
Date: Wed, 9 Feb 2022 16:20:23 +0100
Message-ID: <000801d81dc8$8f15b9a0$ad412ce0$@irit.fr>
Content-Type: text/plain;
	charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQIgBme26ChWP5n2WBO9OQe2xD3DKQHRtGxLAKyTMs2r54lCAA==
Content-Language: en

> -----Original Message-----
> From: Jan Beulich <jbeulich@suse.com>
> Sent: Wednesday, 9 February 2022 15:26
> To: Tu Dinh Ngoc <dinhngoc.tu@irit.fr>
> Cc: xen-devel@lists.xenproject.org
> Subject: Re: [PATCH v2] x86: Use low memory size directly from =
Multiboot
>=20
> On 09.02.2022 14:12, Tu Dinh Ngoc wrote:
> > Previously, Xen used information from the BDA to detect the amount =
of
> > available low memory. This does not work on some scenarios such as
> > Coreboot, or when booting from Kexec on a UEFI system without CSM.
> >
> > Use the information directly supplied by Multiboot boot information
> > instead.
> > ---
>=20
> Btw - please summarize here briefly what has changed from the earlier
> version. As it stands your adjustment looks to take care of one third =
of what I
> did say in reply to your v1. That's not enough for a v2, or else you =
should have
> taken care of the remaining aspects verbally.
>=20
> Jan

Hi,

> The comment here is a pretty clear indication that bad values may have =
been observed, even if this was only in the distant past. But we have to =
not regress even on very old boot loaders.

> Is the kexec case recognizable by any means (including to distinguish =
kexec properly communicating the value vs it not doing so, as iirc it =
was said on irc that this didn't always work correctly there), such that =
we could skip using the BDA value in that case?

As written in the comments, old versions of kexec (before 2.0.23) =
presented the amount of lower and upper memory in the BASIC_MEMINFO =
Multiboot2 tag in bytes instead of kilobytes. The v2 patch tries to =
detect this condition by checking if there's more than 640 KB of low =
memory and corrects the low memory size in that case.

This change should only affect the particular case of booting with =
Multiboot2 without EFI (e.g. legacy BIOS or Kexec). Other cases like =
Multiboot 0.x, EFI booting (with or without MB2), or bootloaders that =
generate the BASIC_MEMINFO tag correctly shouldn't be affected.



From xen-devel-bounces@lists.xenproject.org Wed Feb 09 15:23:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 09 Feb 2022 15:23:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269322.463373 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHooE-0004IV-BN; Wed, 09 Feb 2022 15:23:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269322.463373; Wed, 09 Feb 2022 15:23:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHooE-0004IO-7k; Wed, 09 Feb 2022 15:23:06 +0000
Received: by outflank-mailman (input) for mailman id 269322;
 Wed, 09 Feb 2022 15:23:04 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=XFrC=SY=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nHooC-0004Gg-CS
 for xen-devel@lists.xenproject.org; Wed, 09 Feb 2022 15:23:04 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2c35f87c-89bc-11ec-8eb8-a37418f5ba1a;
 Wed, 09 Feb 2022 16:23:03 +0100 (CET)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2113.outbound.protection.outlook.com [104.47.18.113]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-32-iO71Va-pPna6Eb4Z1hgLYg-1; Wed, 09 Feb 2022 16:23:02 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM8PR04MB7300.eurprd04.prod.outlook.com (2603:10a6:20b:1c7::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Wed, 9 Feb
 2022 15:23:01 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.018; Wed, 9 Feb 2022
 15:23:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2c35f87c-89bc-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644420182;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=i1Md3ZIRNSaIM1GYErnLqwUeDHWNbqRXGvWGdrEokmw=;
	b=mdgcmVgqZdGn+GM4vPIXzVwwHjDca+5Kl5pO7yTkltnZACuXuj9nWCqqaPL8TXpowo0ASM
	LA01jSbDXlMG4fTf3E5L0gfQF3y7LAFBaxT0M3qzSkBOr8ZjAirwVladjgbLKjyFJ6Anvz
	ax758PD7+nmTlbB6NtUsp/dLelIOScg=
X-MC-Unique: iO71Va-pPna6Eb4Z1hgLYg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cIasw6VSSM97SLoNXL2i0ZcUNuDbnBpw3veghtln8eQIYD1LTySjrdI6RECzWyYciS1mPy4EFeJng93ypySTshtE9a5xmf1r73Aizzq/sWw1Et+cYpNfAueGn10rR+9MBL9J16w9LjP3T6+ap/ArIB7XZIAIiJ7SxcrNyFEupjjiKiG+hPaTKl4ssvwLldW1lE+ELfmtZjVUzC5wVrkRkLnbogDEbG1dYm4PXfQ0WVVAfLN4PrtIwl3++eHsL7CiLw9AJ11IrJ33t5cuqk7vfVeikK06K6ES90FPe2F6xUsmZxZ8R6e4laWNzzh4pxUlRMWXvvJWIrUbqy8zL2Ci2Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=i1Md3ZIRNSaIM1GYErnLqwUeDHWNbqRXGvWGdrEokmw=;
 b=WzJ7u+Dr88SrGH7hXIaFOO6sQxksR1PAGD4TuNq8NvodIIzX1BLQtBpEcpTPA38bErnuPQa+XIMyEi9xNvN0VcLctFHAz9yi3CZzf57XHyuZaKJV6tNpm9wZf2U5mIntbBB6Kay0F62+YvPcVZTN1jmjiKVMKRyZSsmuRz65lAnmIfi/mfg01YsaVEkWYUmbdlgfiBt2fmaZW/CyFhq9uaKM//bvBV5WG1fntXkGfDuYRyBmKC//wBQpIUHVBhm8+3P7/Mn9WXPnFmKwtVVmR2O4s6IRzTxUuvcmJ+XhbSRsqEKFu5VIpO8FV+uKrxHfLgQj97gRUcEcO8LPQ+rsEg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <2bdd699a-9644-ee6c-c75d-c5577c836f62@suse.com>
Date: Wed, 9 Feb 2022 16:22:59 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH v2] x86: Use low memory size directly from Multiboot
Content-Language: en-US
To: dinhngoc.tu@irit.fr
Cc: xen-devel@lists.xenproject.org
References: <fe2e94e8-9e46-82be-6e83-391f4709ef75@suse.com>
 <20220209131251.387-1-dinhngoc.tu@irit.fr>
 <ad339015-c5e7-d776-17a3-2dbd337fcd4a@suse.com>
 <000801d81dc8$8f15b9a0$ad412ce0$@irit.fr>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <000801d81dc8$8f15b9a0$ad412ce0$@irit.fr>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0301CA0025.eurprd03.prod.outlook.com
 (2603:10a6:206:14::38) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4c4ae8de-4f00-4b53-2252-08d9ebe00f47
X-MS-TrafficTypeDiagnostic: AM8PR04MB7300:EE_
X-Microsoft-Antispam-PRVS:
	<AM8PR04MB730020661ACCE956383E891CB32E9@AM8PR04MB7300.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	TH5csufaEhytgkD0aGHs0cwVyxqKnZfy6svRrJEj4VuV8TlC1wg+RggtdPnN2cgz8wQddYDFHo6fZOtnscxd+DMcz9yA3Rz16EwvPAW+1jMOesRKJV3M4HsJhmzmodRzIiccnfvVUc7vmDp3CuM22yKm07tDG+DfvAHkRHbDupMXiTXpGvy+4/wEg4Lcu5ghf5EE2ggVhVoKD2oxlb7wUg1NTpTue1ifV4/mhVa+FcVSDDKFDf2ZcHtdiWUvCLeJmBVoTiOY/JP/gcXXpgJXXPXBghub1J7EBZmoERIpWzCoKqcBwdJWG5fGaqBCCbensVuc5l/jioD2Exh/TFuF2FLxOB+JCOAYU9fd4Gn2mf4Df48WixLf/SB8AWkM9/k5n63ayePCmi5ap3/EqBhdLg3gtPpn6BfqVe8c3S9Z1RroXobF6i9tRdWqV2+Oq9vgj0Ok+bcLm2VULCO1ptRlrksQLqsnXaqKwjnzIj+tdDe3PJe4SLcD4davU5QW3v646RQgPWaog6xm6DGRtcg/N5gGSidlrDMKZR3kq3Jza4W5dpZy8VfqEMt8IwwrjnUyJFPFIRK9Bie49bweSoYD57Pmf6m4p6hBOcuN2AzLBr7leQDrw+yw026X1jjdOIgn2YI60sRye7zBmoWJAIfNs0f/WKJJsvMD4fH7+ULFhDiGBrzvLoio30udAnWpCViQEmd1L9bzRSOdjKfNLxJKRDWwHJ7jXpXfg843czpHtGU=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8936002)(31686004)(53546011)(38100700002)(2906002)(2616005)(5660300002)(6506007)(6512007)(36756003)(186003)(316002)(31696002)(4744005)(86362001)(66946007)(66556008)(508600001)(6916009)(8676002)(4326008)(66476007)(26005)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NTlzYzQ4VDlsaGdkZE9mMlluRENBbnBYMk04NlN0YmNrRS9ZdWsvM2M5OXF5?=
 =?utf-8?B?em9FSmlJOVVhaU1tME9JbnV6dGZYT2Z4ZC9oOGE1TWRscG1DOE5lWVpiREZ0?=
 =?utf-8?B?YXpTSXlYeVdlZFNHNEZEdlduZnlhVi9oSFpNUGU1T0s5c2k5TmF0RHZseURl?=
 =?utf-8?B?RmsyYjlzS1pHU2V5S2FoR3l0R0RCVjhJNmREZVlGZmorYlJITTlrZlFXalU3?=
 =?utf-8?B?WHBFVldCRFVqZElxVGdnUTJOUFFvM0tIY1h0citNcW1nVDRxS3ZPYVRadTJM?=
 =?utf-8?B?WWdBL2ZMTGVZZjdKRjVSVkk4UmN5YmVsdzc0RWUvb25FYmY1YWZUQ0w5bGND?=
 =?utf-8?B?SUdJaFlSQlViVjJRU1Nydi9Nb1p1OFBxbUo0ZHBxZ3hZU29JMXR4MWV1YzFo?=
 =?utf-8?B?bGNpdFpvV0NJWGVRWEtRdi9IK1FDdFZEVVB6bC94MEhuZ1RGRVc2akc2U09K?=
 =?utf-8?B?OVVLR1BqaFg5NjhhRy9oQjJXbUtqU1hXYklzWk1zVkZ4NlBMT2xBUVdPbVcv?=
 =?utf-8?B?Ym82Q0FrWEZscmc3ME54Y1NOaXEwb3lNTFM0ZXVXTEJ2UnRUWmI2alY5YWN6?=
 =?utf-8?B?cXRjVFpkczY0ZjFXa09qbitrVkRYKzJDOUFhRlVuQ3VncjN3cERyWHdhcmt2?=
 =?utf-8?B?VkUvQjdKbUlKekVKL05aYW5Ic2hlc3o5ZDR4blVmUkUvenVXYTUzblVrdDFO?=
 =?utf-8?B?MEFpeE8vRHdKQ3p1d1ZqOFZ0aFZhTWpXZXNsUDRpZzRST21RL3FpU3JuTjRy?=
 =?utf-8?B?a0xFNlN0ckU0UkxTN3VlanZkZHB1QkQxU3dSU1lsYjJTTzVGaURZN0hjMmVT?=
 =?utf-8?B?YjRFb2FkYWdDWThFNk9PY0czUFIvK3RTSkVWQTE0ZVFQU0JVdStHamFDU3Zj?=
 =?utf-8?B?Ym9FajN1SDhJdTBiNlhFaCtuSFhrWlpWMVNDN0tUZXUxR1hIaHpyTzI4WHBr?=
 =?utf-8?B?UCtBb2pHK2ZDNTBvMHh4TFpnbDNOYW4ybE9IQTkrQ3BmWGJYazNuNzJDcGZY?=
 =?utf-8?B?MU1lYjYvcjRVeG5yZVp6T0k2U2M3Q05tZFlISW5IY20zWmlHUHpDQnVLWXVI?=
 =?utf-8?B?dzN3M3BuRW9NbU54NDEzSS8xUk5MMkovRHNZN3VSb3o0aHViNlh2ZFBsNitE?=
 =?utf-8?B?SjB3Z042VXRyNEo0ZEI5SWV2RTE5TDlqRlk4a3FEVS9UR2kxR0hEUXpRb1NE?=
 =?utf-8?B?MGdCY1I2aXR2NWJDUDRDWVJLbHZEMGs5cFB1VXdia0dnbU16d0R3RDY1RXZv?=
 =?utf-8?B?Sno3dzBlNzIwSGNTTk50QkptV1AvYXVtOTJ2VncrOWp3TDFYYjF1cTU3clBq?=
 =?utf-8?B?L1MyRUtNRTJwTTZPVGt0ejR1cG01b1JOUy8xVEdHZ21FelMyczF4WUtqaEty?=
 =?utf-8?B?WDkvWjdDYmpCbk15RGpUY05TWlRkNDdhTE9nSzZuek9JZnBlZ0xtelpjS25J?=
 =?utf-8?B?UDBTdmxJRmMyOWowbEYzcjQwQTg5dlpHRGFqcWhJS2VTOFhFNzd2Ly83Z1RM?=
 =?utf-8?B?ZWdxSmJucUxkc3krVDl1RXI3Q25qRXBnOW9LNjlPQzNkcCtBVGtYWDZlb0p4?=
 =?utf-8?B?blp1OFgwZmJXeUl2eWRySFpNN2h5RWdTWUIxQjlqQlR2blRWQ0h0SlNvMVJ1?=
 =?utf-8?B?N1hoN2htSlNyM3lRTFd1OU5GV1p2RDFFbG9uN3ZhNmR2NnJCMCtMNGhiOXFo?=
 =?utf-8?B?dldXSHE2WEtIL1BRSUZ2a09NR1lFWjhTWm5lSEdmRktpN2EzVnVDbndGL0Ja?=
 =?utf-8?B?M3VockxWNFNSL1Vkd0lxeWs5MTB1Nk5WbHVkclhUcHJCR2dLSFRyZHIyZ1BP?=
 =?utf-8?B?MzdiUFIyRmRjbHJTNm4yZXZjWlAwQi9nekFJSmV2YzdzTUlnaldma3N3Y0R4?=
 =?utf-8?B?a2hLNzhkS3N4WXQ0eDBEVHUwMHc0M1l1bWk2bGdaQU5iMFQ0WDJsMDBQRVFw?=
 =?utf-8?B?MFhXb0hZZzBiYkdpR29KSkIvK1NkTmdZVElaMjVQZjErT2l0dW53MWpFUUM5?=
 =?utf-8?B?V2NML2pGbndZb1QxNW03TWE1VkttYmNuK29MNXJJRm41ckZkNXMvcDlPaW5i?=
 =?utf-8?B?VlArNzFKQUZUK1dvNTJWMnliTzBacHRRVnJzTHhBMFhsRlBsZy9HWnJYWTJy?=
 =?utf-8?B?dU9HL1BKcUQ4R0pkQmZHamFmQ3hqODM4SmF1MkszamZlUS9YemJ0SUYwMUVU?=
 =?utf-8?Q?N9edkqosUwQ04bkrUWaTUhQ=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4c4ae8de-4f00-4b53-2252-08d9ebe00f47
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2022 15:23:01.3032
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: P/1strGiM5n2zhk3k4ynY5eQMpjBj06oQXnnCLtmBF0Aj7YvdiKL1ZvryqueoXyZD3BAavH9jox6Iwoeqy5Jqw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7300

On 09.02.2022 16:20, dinhngoc.tu@irit.fr wrote:
> This change should only affect the particular case of booting with Multiboot2 without EFI (e.g. legacy BIOS or Kexec). Other cases like Multiboot 0.x, EFI booting (with or without MB2), or bootloaders that generate the BASIC_MEMINFO tag correctly shouldn't be affected.

How that? You're taking out the reading of the BDA value altogether,
aren't you? This is certainly a change affecting other environments
as well.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Feb 09 15:23:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 09 Feb 2022 15:23:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269329.463384 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHoon-0004tD-OG; Wed, 09 Feb 2022 15:23:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269329.463384; Wed, 09 Feb 2022 15:23:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHoon-0004t6-Kq; Wed, 09 Feb 2022 15:23:41 +0000
Received: by outflank-mailman (input) for mailman id 269329;
 Wed, 09 Feb 2022 15:23:41 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nHoon-0004t0-6x
 for xen-devel@lists.xenproject.org; Wed, 09 Feb 2022 15:23:41 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nHoom-0007L3-RR; Wed, 09 Feb 2022 15:23:40 +0000
Received: from 54-240-197-228.amazon.com ([54.240.197.228]
 helo=[192.168.1.215]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nHoom-0008RR-Li; Wed, 09 Feb 2022 15:23:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=R6qOKoOoOjM4J0QUUpq0oWvOJZyhpCwg4brMxSJh6W8=; b=F0Td/WSSvFdD6x0i6w4vZcfU6I
	zNvQjSxo1zNf4FMZ012pVswkX439vYtpE8eRmSjm/YhwPMmfPTrlAA2oRQ5+AXXE/aHF+87VW5Amy
	7h+VmaqclatmxV5fCvGA7cSPRF44Th6Mj00BkdyHOVaAO3XckKnDlh5H6LghBxQeHq/Y=;
Message-ID: <9e31e46c-f516-46df-4f82-f7c11b444747@xen.org>
Date: Wed, 9 Feb 2022 15:23:38 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.1
Subject: Re: [RFC v2 5/8] xen/arm: introduce SCMI-SMC mediator driver
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>,
 Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <cover.1644341635.git.oleksii_moisieiev@epam.com>
 <cb1493f5d9b5c3437268054b4a8e345cb35c8708.1644341635.git.oleksii_moisieiev@epam.com>
 <1bfc6aa8-6252-e22a-4e10-6a5efdd15229@epam.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <1bfc6aa8-6252-e22a-4e10-6a5efdd15229@epam.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit



On 09/02/2022 15:02, Oleksandr Andrushchenko wrote:
>> +{
>> +    return FIELD_PREP(HDR_ID, hdr->id) |
>> +        FIELD_PREP(HDR_TYPE, hdr->type) |
>> +        FIELD_PREP(HDR_PROTO, hdr->protocol);
>> +}
>> +
>> +/*
>> + * unpack_scmi_header() - unpacks and records message and protocol id
>> + *
>> + * @msg_hdr: 32-bit packed message header sent from the platform
>> + * @hdr: pointer to header to fetch message and protocol id.
>> + */
>> +static inline void unpack_scmi_header(uint32_t msg_hdr, scmi_msg_header_t *hdr)
>> +{
>> +    hdr->id = FIELD_GET(HDR_ID, msg_hdr);
>> +    hdr->type = FIELD_GET(HDR_TYPE, msg_hdr);
>> +    hdr->protocol = FIELD_GET(HDR_PROTO, msg_hdr);
>> +}
>> +
>> +static inline int channel_is_free(struct scmi_channel *chan_info)
>> +{
>> +    return ( chan_info->shmem->channel_status
>> +            & SCMI_SHMEM_CHAN_STAT_CHANNEL_FREE ) ? 0 : -EBUSY;
>> +}
>> +
>> +/*
>> + * Copy data from IO memory space to "real" memory space.
>> + */
>> +void __memcpy_fromio(void *to, const volatile void __iomem *from, size_t count)
> This seems to be a copy of [2].
> We should think about moving this into a dedicated file like in Linux,
> preserving the authorship+

+1. Also this should be in a separate patch.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Feb 09 15:28:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 09 Feb 2022 15:28:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269340.463395 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHotd-0005bO-Ac; Wed, 09 Feb 2022 15:28:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269340.463395; Wed, 09 Feb 2022 15:28:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHotd-0005bH-7T; Wed, 09 Feb 2022 15:28:41 +0000
Received: by outflank-mailman (input) for mailman id 269340;
 Wed, 09 Feb 2022 15:28:40 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=H3wK=SY=citrix.com=Jane.Malalane@srs-se1.protection.inumbo.net>)
 id 1nHotc-0005bB-8s
 for xen-devel@lists.xenproject.org; Wed, 09 Feb 2022 15:28:40 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ee5f01d1-89bc-11ec-8f75-fffcc8bd4f1a;
 Wed, 09 Feb 2022 16:28:30 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ee5f01d1-89bc-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644420516;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=bpg2I5WKFBKETW7gLBy9FPk34HZxeoYvF70yHK+WfW0=;
  b=HWBbsNALz8atCFCX/4B9DL2D/tJc3Q34B8sXNrjdI4r5P15NRsLrN2US
   R6Nc5tGgmlyDwRQHWUlE1M2g8h+TXF6+pXmCzVfvLEOOheQ9k5+sFQ1zr
   bMwpruoMMtm5UdW3v4zSThTrk71KjnfRJXDwWoeRn7mIxyBbdfQr90bHV
   g=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: KBMBpYGSxZBT2Ttm762+7Skl+dxS+BZ0i+8nzukQ1Gr2pPYFI2/7vna5/cqH4Y1+3NdCjazZGK
 Ax6fxKM8Z+oViuZkwd53/CQ5C2KIr3d1rPZd1H8q68HWSYy/7naPoFSVcHsX4Ns1baBB7r4SZO
 8fb+hQAsFtrD5xt3F76i4g8n0lIHCODm6cbfsYW5XwdUG7zLSzevgv1+KHLpKJVKoPyauRMFED
 CY6YVMxFGHaVdF/0KswfRBKTM2UolqhBjY37krII6PWAZt8Sh6+Dvhb81hf0BGhZTrjkSX5gMI
 r4rQM+UHH9V0S4MjrNTakpmk
X-SBRS: 5.1
X-MesageID: 63748491
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Ll/hQq6xqCcCvJT+VqcK8AxRtDnBchMFZxGqfqrLsTDasY5as4F+v
 moXDGzUPPreN2TycopybIvgoxwO757Wx99iSQdopH00Hi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FV8MpBsJ00o5wbZj2t8w27BVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zw
 d9f7ZWBCiASJqTPuNsiXkdfGhhaMvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALDsDtMcU6s3VpyTjfAN4tQIzZQrWM7thdtNs1rp4VQqqOO
 5tAAdZpRBjyeEFUPX4NMZ0BreiUh1faLWNgjmvA8MLb5ECMlVcsgdABKuH9RNuOQslEm1eCk
 UjP9W/5HxIyOcSWzHyO9XfErvTUgSrxVYYWFbu53v1nmluewioUEhJ+fVG2u+Wjg0iyHddWM
 VUJ+zEGpLI3skesS7HVXBCmoXjCoh8VXfJRFfE37EeGza+8ywSEAC4CRz1Iat0jvec3QyAn0
 hmCmNaBLSNrmK2YTzSa7Lj8hSO/P20ZIHEPYQcATBAZ+J/zrYcrlBXNQ91/VqmvgbXdGz7qx
 CuRhDMjnLhVhskOv4254FTGjjSEtpXPCAkv6W3/XGio8wd4b46NfJGz5B7Q6vMoEWqCZgDf5
 j5ewZHYtb1QS8HW/MCQfAkTNLij9a6MAX77ukZmHLkeyDnz/HeaWY8FtVmSO3xVGsoDfDboZ
 mratgVQ+IJfMROWUENnX26iI590lPa9TLwJQtiRN4MTOcYpKGdr6QkzPRb44oz7rKQ7fUjT0
 7+/eN3kM3sVAL8PINGeF7ZEiu9DKszTKAruqXHHI/aPjOP2iJ29E+5t3L6yggYRtv7sTOL9q
 Yk3Cidy408DONASmwGOmWLpEXgELGIgGbf9oNFNe+iIL2JOQT99V6SNnO9wItw8wsy5c9skG
 FnnBye0L3Kl2hX6xfiiMCg/ONsDo74jxZ7EAcDcFQnxgCVyCWpexKwea4E2bdEaGB9LlpZJo
 w0+U5zYWJxnE22fkxxENMWVhNEyJXyD2FPVVwL4MWdXV8A7HWThpIS7FjYDAQFTV0JbQ+Nl+
 Ob+vu4aKLJeLzlf4DH+Mqrwlgjs5ihEw4qfnSLge7FuRakly6AzQwTZhf4rOcAcbxLFwzqRz
 QGNBhkE4+LKpucIHBPh3Mhodq+lTLlzGFR0BW7e4erkPCXW5DP7k4RBTPyJbXbWU2atoPeuY
 uBczvfdNvwbnQkV79ogQugzla9utcHyo7J6zxh/GCmZZVqcFb49cGKN2tNCt/MRy+YB6xe2Q
 E+G5vJTJa6NZJH+CFcUKQd8NraD2PgYlyP89/MwJEmmtiZ78KDeCRdZPgWWiTwbJ7xwadt3z
 eAksc8Qygq+lht1bYrW0nEKrzyBdyVSXb8mu5cWBJ7QpjAqklwSM4bBDiLW4Y2Ub4keOEcdP
 TLJ1rHJgK5RxxSefiNrR2TNx+dUmb8HpAtOkA0ZP12Ml9fI2q030RlW/WhlRwhZ1Ewaged6O
 2wtPExpP6SeuTxvgZEbDWyrHghAAjyf+1DwlARVxDGIERHwWzyfNnA5NMaM4FsdojBVcTVs9
 b2FzHroDGTxd8br0ypuAUNoppQPlzCqGtEuTCx/I/m4Ig==
IronPort-HdrOrdr: A9a23:7oP7i69FJ5eiVGA80ltuk+F7db1zdoMgy1knxilNoENuHfBwxv
 rDoB1E73LJYW4qKQwdcdDpAtjkfZtFnaQFr7X5To3SIDUO31HYbb2KjLGSjAEIfheRygcz79
 YYT0ETMqySMbE+t7eB3ODaKadh/DDkytHRuQ629R4EJmsKC52IrT0JcTpzencGHjWubqBJcK
 Z0k/A3wQZIDk5nCfhTaEN1PdTrlpnurtbLcBQGDxko5E2lljWz8oP3FBCew1M3Ty5P6a1Kyx
 mHryXJooGY992rwB7V0GHeq75MnsH699dFDMuQzuAINzTXjBqybogJYczBgNl1mpDr1L8Zqq
 iKn/4SBbU015oXRBDtnfLZ4Xil7N/p0Q679bbXuwq5nSWzfkNENyMIv/MmTvKe0Tt8gDg06t
 M740uJ85VQFh/OhyL7+pzBUAxrjFO9pT44nfcUlGE3a/pVVFb/l/1rwKp5KuZJIMvB0vFtLA
 CuNrCp2N9GNVeBK3zJtGhmx9KhGnw1AxedW0AH/siYySJfknx1x1YRgJV3pAZNyLstD51fo+
 jUOKVhk79DCscQcKJmHe8EBc+6EHbETx7AOH+bZV7nCKYEMXTQrIOf2sR52Mi6PJgTiJcikp
 XIV11V8WY0ZkL1EMWLmIZG9xjcKV/NFAgFCvsukaSRloeMN4YDABfzP2zGyfHQ08n3KverKc
 qOBA==
X-IronPort-AV: E=Sophos;i="5.88,356,1635220800"; 
   d="scan'208";a="63748491"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=hQ1v+TfY2S8Co6pk/Dz5MVVO8G9BB3io3eWcipubPLqjCgP4LXrfWy2ykxuH8YHwS0X6FYluLOBB1BZUZkoChCm9QKlR/k/S86JbnYtwYZsnBzA4rD/ZkTkWKIXDv7rgMVJPHqt+VOaUlI14ntf/JNVvtxdus37Vi1vx3nItBCUexVtd4ZkAWU7DJKnDlX1o8dLJcgtZ/ibREf3DdYfCVW8Z/fDA1fHKMITH9Hro+YROSrBtaBB9GdrrxXWvMNrwrVWX183xPhIb2yvqEUxcc8/fc09sedV5fZoRKAA0s1oE0IvX2CrNZlTPG/t5msNJvax74iBJ6VaHM0eULke1DA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=bpg2I5WKFBKETW7gLBy9FPk34HZxeoYvF70yHK+WfW0=;
 b=hOrETNs0oUmDxmT5WBD/2CLihrZxgRkoXCJUvnFr+iz5hWnAE8kDCM2dAl+8MyT5CQ7IEIKZmgK4A8J11GKBKjRwq7AdlKjbeF85kVempTJ1D1WRkmT2RiQxkDiREnqAF0jcrvz26J0lIsLW62B1iaPKfu6F6poGULfhyuysTa4IkbFSmX3t6D+i4hhQymdV0qFwiSweWaHtIfKBoj5tlUqjzYCXliy/+fU9V8o8UGWyu4+cAL2TqgBqBwSP9QOz5galjHRzetM208da7HSQLm3c2eaAuuc9i/ITxIyBNWM+CLmPwdbs5OdkF4pBmDUZt3rGaNrxVVu+U6ruDf5cDg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=bpg2I5WKFBKETW7gLBy9FPk34HZxeoYvF70yHK+WfW0=;
 b=GLKYVnwQ6s/akRygmceWQMpz7B8UfZo8FM4Av4HLRSCv7bR5mkJ9P0DNx8NoJIf7geDR4ITvbx3H4jfMsSWeHrPzHxcQjQ9Z0bXyR2i3olc+5ezmiBe52PQABHhIAigXloDG0L7+0HdDfh73u5jrDi0z87u8be3YbI8/kNdMk5w=
From: Jane Malalane <Jane.Malalane@citrix.com>
To: Anthony Perard <anthony.perard@citrix.com>
CC: Roger Pau Monne <roger.pau@citrix.com>, Xen-devel
	<xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>, Juergen Gross
	<jgross@suse.com>, Andrew Cooper <Andrew.Cooper3@citrix.com>, George Dunlap
	<George.Dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, Julien Grall
	<julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, "Volodymyr
 Babchuk" <Volodymyr_Babchuk@epam.com>, Bertrand Marquis
	<bertrand.marquis@arm.com>, Jun Nakajima <jun.nakajima@intel.com>, Kevin Tian
	<kevin.tian@intel.com>
Subject: Re: [PATCH v2 1/2] xen+tools: Report Interrupt Controller
 Virtualization capabilities on x86
Thread-Topic: [PATCH v2 1/2] xen+tools: Report Interrupt Controller
 Virtualization capabilities on x86
Thread-Index: AQHYHE+TdJl64aH33EedeR0PZ4zblKyJx9wAgAFf6oCAABb6gIAAHAAA
Date: Wed, 9 Feb 2022 15:28:31 +0000
Message-ID: <b4521aed-56dc-0049-5535-447621fd112d@citrix.com>
References: <20220207182101.31941-1-jane.malalane@citrix.com>
 <20220207182101.31941-2-jane.malalane@citrix.com>
 <YgKLpCnhjP18c7oo@Air-de-Roger>
 <2567d4cd-b27b-df0b-d449-c486ab13c672@citrix.com>
 <YgPGHyVdSWrPwcWD@perard.uk.xensource.com>
In-Reply-To: <YgPGHyVdSWrPwcWD@perard.uk.xensource.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 880e1969-5bfa-45da-24df-08d9ebe0d41b
x-ms-traffictypediagnostic: SJ0PR03MB6952:EE_
x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
x-microsoft-antispam-prvs: <SJ0PR03MB6952E662CB58C69F536BC5A3812E9@SJ0PR03MB6952.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8273;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 1K15j+8o42Y50K8JX7/P7E8WoG7lmJz0AbYHebj5eqsIWcOqEynOVLwDOmd4DeLzlggCeRnlP+Za6c7h+VqLt67AO4hzpr5DuE3Hxke+PCkfv1rd9tSzGjJ8E5OOTN0N6KbJtkqRkDrUbIHVAL6+6EyD2sFkSvW8EYNORwoPcf4d81AbZ0FUXh47qFsI6qBY65cjzleIqznHAYJmajIcZhtrwGwj4J4U1WyHxYyh0hYrDh88Wa5Rz5E5NbApTCH5GB0DhwnYzyP/GCtF4qFGG+ITzXddSGEkvatlyLCh2lc9wSnXWtOnBab5Kri+zXFXCwxjJfHMGMOJiQsStvwgHr3DFBDLkh7Ka0+UJmFoe4qgdB1kg7P0mVreMH5OVzAmVfEvwHT3/D/SFkIV7bDM41N7JdV1Qik08Vceg/l/Q1pjH1lpxKhCYCnYmuiqjbVkdmZXLo5OrjWmMoBM8r7GniEskDl6eVtKVE+6a4CX62TmR+b52DWdm8Cx1tJTl9E5KGvkwlm0omgWowtZMj1f6WTjm/AxfEEGqGWTNiq/G0KOwkhkdqx1Ub+H1hyaEbdOPEOJbYa+enzdIDjb4CeRRlqps7/an8Gu1cYPUDpi6nT5DkkAZXDaWrM5XEnc2OOfiJZS/SmEdsgFcafmKPILexPKRbT4VG0bDAerQaymja9Lov8g3F4Jw8W9Z/63u9pco2kumMRc+xX6ZKs5IKkUNDYOzOcEdXIaygCazHC9DHtwlJ3i5lukJ8dFLbNXwyhP
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR03MB3386.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(8936002)(6862004)(4326008)(66946007)(122000001)(91956017)(38070700005)(86362001)(8676002)(66446008)(7416002)(66556008)(31696002)(5660300002)(66476007)(54906003)(53546011)(316002)(6486002)(64756008)(508600001)(6512007)(36756003)(76116006)(6506007)(6636002)(37006003)(186003)(2616005)(31686004)(38100700002)(71200400001)(2906002)(82960400001)(26005)(83380400001)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?dlM1YzFGaktub1daeGNjWEl5WmZCZXpoTjlIY0FLYjNDeURKRlBWQ1JKQjdp?=
 =?utf-8?B?a3ZHRGRoSC9TQWl6dDZkWHV6aFVENWlwaGljZjhLZmNOdDBHck5Da1JsVkd2?=
 =?utf-8?B?RG9jVVkwdTBad3BlY1A0Mk1DZjJqcDErbWJ0ako5bDcvTEg0U29aNkhTd055?=
 =?utf-8?B?eit2enlFYjVXeUpNSk5EN1pSSjA3TERxUXlXYzF1dzR5NDkwSmNyWE5GVmR4?=
 =?utf-8?B?WHhObTZnQmRnbDJEbm1OVVpQYkNRVVVLWHdYNjBETUhLeXJaRllBYk1EcEhK?=
 =?utf-8?B?VFlmdGl2VGJDbUZaRUVHRG5HbitUa1RFV1lvcWFpeFVCb2dJc3pYdnNyOVZU?=
 =?utf-8?B?SDBaTnRGQXpkcE5NcXFyemxWaktHMnVLSTRCaG8xRlNlSktrQzV4UkdDeTFK?=
 =?utf-8?B?QW16T3hvVi9qNkR4L2NEcTFRUis4R1NIOCszNUJNckptUUszUW1hdnNFVFU0?=
 =?utf-8?B?SFB4ckFMM3EyOEFGUDJaaERIeXZDZUk4VWtwSkNIRkptZnJtVjcvWXZsZ1Nh?=
 =?utf-8?B?ZzZPelBMZE4xc2JIZDFTODRGcEZuTFl0VlhYVE1MYnFzdGVoVnM0ejQyUStB?=
 =?utf-8?B?M25pQ3p5WFN4SmFuMjdUZnFBSUE2M1dHNXNyVzE1RmYxSlpYUzNXOVBMbjZ0?=
 =?utf-8?B?RU1oSFhjQndlb1BpS3l3MlBBUVZvUGtRckV0Ny94V24vbStIdS91TWtwNjJr?=
 =?utf-8?B?Z3BPREpwc2l0MnJpRjhwZmlqUE9FVDhkbVFyck4yREp0TGY0VWZpNXFpb3Ns?=
 =?utf-8?B?U3hiOUNCaTJBcjcvVWJHOUJoV1JFNnJKa0V4Q2lTWmtZTTNQaUV4elpNbEdG?=
 =?utf-8?B?am1OUkdMa01uVDMxTzg3WFJWRTVseDl5SFJtcmlzOHE4TFkxakpYUlcrTGVE?=
 =?utf-8?B?LytNeUJLVTMvdkRRSW9ibUI2ek9TVkgzQ3hVRDZRSDI4WnVwUTBuQlJYci8r?=
 =?utf-8?B?SjU3QUpDc3ByeitSYlFuZmZ1bk82RE9ZbEozaFZidnN3TXFGNGRKWWk0OTQv?=
 =?utf-8?B?c1VsTnhEVVh2aGdBV2Jod3NIdmtndFMwbEt2WThJR29COERUY05VbkhpMVBQ?=
 =?utf-8?B?dEtpUEt4c3YvWm40SFhMdW44dTJBWUNoVTNSdU9aN1lNTTJ4ZHhsZ0NBS0ls?=
 =?utf-8?B?TW84STc3N1dCNWxUb21Pck1PYUsydlJTZllhZWN5STYzMExaQnRpNTdqTHhi?=
 =?utf-8?B?bGZzYURzRzV6MC9pclQzN3Q5YmNMdVRjTjkvWS9wRmJxLzNXZ2dxMmdRRWYr?=
 =?utf-8?B?SlUwQkpWUFdCa2MrYkR1RDJzYmVjeWZVSitVZ2QxZjR0TlJhRDYxalpVWXFi?=
 =?utf-8?B?Y0wwTG5uN3M1SHBnSUdTcmF5cllTTlhyYzRmS212eFVUbFYvQlFScDE1TXZR?=
 =?utf-8?B?UVFDaTd6VXo5ZHBZVVo5VEVuL0dZczZKcktMdEVlbDhoNDV0LzJoNVJkSGZn?=
 =?utf-8?B?ZjdnYWpPZVRHa2lTczlscXNOb2twb1JNN1NRQmU4VEJIdDBnREM0SURiN2tV?=
 =?utf-8?B?d1UrQ0RNQlp5VHFCU0ZMYVdMY3JsTWk2RHNXSGFRc0V6b1BILzNzTlMvdy95?=
 =?utf-8?B?cHVjZ01iajBEN1pHeXl2NTZQZEthamNzN2tUbXdNVlNub2VSQTBCc09PTjcr?=
 =?utf-8?B?QmVYSXdrbk52Vm8zMnZ0djdKY0h5RklYdVlKd2tKVkhHRVNFVTV2ZFB3emlZ?=
 =?utf-8?B?YmpzN2QraGJzdERNV3p1c0FGenZEbngzcU1kQ2U3MEpaY05adS9vLzgvZ0di?=
 =?utf-8?B?N2ZVWkpHWDAvNHhBTHUyRzRrSG40bkR5UDNkU1VldHFtM0dBNENNSS9VQlVi?=
 =?utf-8?B?V1ZqNCs2YUJxN05BaTAyNVZQaGRUK2FESXZHdExrTmdwMlo2WER4MDVXZDRm?=
 =?utf-8?B?NStQWHcrN01oT1R2YmJmcTgycXlEejErK00yaitJNnRkeEdmMjJKTWcvZDNh?=
 =?utf-8?B?NGhjcHJyc0IySjdRQ1BhanVZMjV4RC9TYUNuMkNTN3ZDcnBOcHZhOHBnSDVC?=
 =?utf-8?B?WTV6Y3ZidGxGTTBOSC9FbVFtaDRSSXZtMUVhYlc5N0JOdEZWaWcrWG1kTWhk?=
 =?utf-8?B?c1l1TDJWaGhFa1N2Z09xQ3lvcXYzaVBFY1J0R0duWGJoV0FsRnRSTlBOVjRq?=
 =?utf-8?B?ZTVIUG9jQ2pHQ252UC83U0M1eWNnKzNiMW8zUFArYWc5UEgyZHYzbFU1cUpS?=
 =?utf-8?B?b1ZRTlBUVnpXdEVyR3k3cTdQYUpyZEY5VWZFek85VjF3NVJLbnZRREw2dlVG?=
 =?utf-8?Q?tWMT3bWUJozqXEp5Oly4xIjWeNWLXwETz+9wg+iR0s=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <A27FFF9458A7AA4286546DA8210A8A60@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM5PR03MB3386.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 880e1969-5bfa-45da-24df-08d9ebe0d41b
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Feb 2022 15:28:31.1980
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 0iQLHy5n60Ixc3B01RnOlbFk1nWYn+g94l5OJ5LNgzJh841m0u3LrIn5QGoOdumgvipYmV8LdXw/naPgNOtM+QNLTRu1f9/qziHjFFD/YkQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6952
X-OriginatorOrg: citrix.com

T24gMDkvMDIvMjAyMiAxMzo0OCwgQW50aG9ueSBQRVJBUkQgd3JvdGU6DQo+IE9uIFdlZCwgRmVi
IDA5LCAyMDIyIGF0IDEyOjI2OjA1UE0gKzAwMDAsIEphbmUgTWFsYWxhbmUgd3JvdGU6DQo+PiBP
biAwOC8wMi8yMDIyIDE1OjI2LCBSb2dlciBQYXUgTW9ubsOpIHdyb3RlOg0KPj4+IE9uIE1vbiwg
RmViIDA3LCAyMDIyIGF0IDA2OjIxOjAwUE0gKzAwMDAsIEphbmUgTWFsYWxhbmUgd3JvdGU6DQo+
Pj4+IGRpZmYgLS1naXQgYS90b29scy9nb2xhbmcveGVubGlnaHQvdHlwZXMuZ2VuLmdvIGIvdG9v
bHMvZ29sYW5nL3hlbmxpZ2h0L3R5cGVzLmdlbi5nbw0KPj4+PiBpbmRleCBiMWU4NGQ1MjU4Li41
ZjM4NGI3NjdjIDEwMDY0NA0KPj4+PiAtLS0gYS90b29scy9nb2xhbmcveGVubGlnaHQvdHlwZXMu
Z2VuLmdvDQo+Pj4+ICsrKyBiL3Rvb2xzL2dvbGFuZy94ZW5saWdodC90eXBlcy5nZW4uZ28NCj4+
Pj4gQEAgLTM4OSw2ICszODksMTAgQEAgUnVuSG90cGx1Z1NjcmlwdHMgRGVmYm9vbA0KPj4+PiAg
ICBEcml2ZXJEb21haW4gRGVmYm9vbA0KPj4+PiAgICBQYXNzdGhyb3VnaCBQYXNzdGhyb3VnaA0K
Pj4+PiAgICBYZW5kU3VzcGVuZEV2dGNobkNvbXBhdCBEZWZib29sDQo+Pj4+ICtBcmNoWDg2IHN0
cnVjdCB7DQo+Pj4+ICtBc3Npc3RlZFhhcGljIERlZmJvb2wNCj4+Pj4gK0Fzc2lzdGVkWDJBcGlj
IERlZmJvb2wNCj4+Pg0KPj4+IERvbid0IHlvdSBuZWVkIHNvbWUgaW5kZW50YXRpb24gaGVyZT8N
Cj4+IEkgaGFkbid0IHJlYWxpemVkIGl0IGFwcGVhcmVkIGxpa2UgdGhpcyBoZXJlIChhbmQgdGhl
IHNhbWUgaGFwcGVucyBmb3INCj4+IG90aGVyIHBhcnRzIG9mIG15IGNvZGUgYXMgSSdtIHNlZWlu
ZyBub3cpIGJlY2F1c2UgdGhlIGdpdCBvdXRwdXQgaXMNCj4+IGNvcnJlY3QuIEkgd2lsbCBmaXgg
aXQuDQo+Pj4NCj4+PiBBbHNvIG5hbWUgd291bGQgYmV0dGVyIGJlIEFzc2lzdGVkeHsyfUFQSUMg
SU1PIGlmIHBvc3NpYmxlLiBIYXZpbmcgYQ0KPj4+IGNhcGl0YWwgJ1gnIGFuZCBsb3dlcmNhc2Ug
J2FwaWMnIGxvb2tzIHJlYWxseSBzdHJhbmdlLg0KPj4gT2theS4NCj4gDQo+IA0KPiBUaGlzIGlz
IGEgZ2VuZXJhdGVkIGZpbGUsIHlvdSBjYW4ndCBjaGFuZ2UgaW5kZW50YXRpb24gb3IgZmllbGRz
IG5hbWVzLg0KPiBJdCB3b3VsZCBiZSByZWJ1aWx0IGF1dG9tYXRpY2FsbHkgaWYgeW91IGhhZCBn
b2xhbmcgaW5zdGFsbGVkIGFuZCB3aGVyZQ0KPiByZWJ1aWxkaW5nIGFsbCB0aGUgdG9vbHMuDQo+
IA0KPiBUaGVyZSdzIHR3byB3YXlzIHRvIGdlbmVyYXRlIGl0LCB5b3UgY291bGQgaW5zdGFsbCBn
b2xhbmcgYW5kIGJ1aWxkIGFsbA0KPiB0aGUgdG9vbHMuIE9yIHdpdGhvdXQgZ29sYW5nOiBqdXN0
DQo+IGBjZCB0b29scy9nb2xhbmcveGVubGlnaHQ7IG1ha2UgdHlwZXMuZ2VuLmdvYC4gQm90aCBz
aG91bGQgcmVnZW5lcmF0ZQ0KPiBib3RoICJoZWxwZXJzLmdlbi5nbyIgInR5cGVzLmdlbi5nbyIg
ZmlsZXMuDQo+IA0KPiBUaGVyZSdzIGFuIGV2ZW4gZWFzaWVyIHdheSwgdGVsbCB0aGUgY29tbWl0
dGVyIHRvIHJlZ2VuIHRoZSBmaWxlcyB3aGVuDQo+IGNvbW1pdHRpbmcgOi0pLg0KDQpPaCwgeWVh
aCBJIGZvcmdvdCB0aGV5IHdlcmUgYXV0b21hdGljYWxseSBnZW5lcmF0ZWQuIFJpZ2h0LCB0aGFu
ayB5b3UuDQoNCkphbmUu


From xen-devel-bounces@lists.xenproject.org Wed Feb 09 15:37:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 09 Feb 2022 15:37:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269349.463405 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHp1X-00070R-5D; Wed, 09 Feb 2022 15:36:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269349.463405; Wed, 09 Feb 2022 15:36:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHp1X-00070K-1q; Wed, 09 Feb 2022 15:36:51 +0000
Received: by outflank-mailman (input) for mailman id 269349;
 Wed, 09 Feb 2022 15:36:50 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=50R8=SY=irit.fr=dinhngoc.tu@srs-se1.protection.inumbo.net>)
 id 1nHp1W-00070E-6D
 for xen-devel@lists.xenproject.org; Wed, 09 Feb 2022 15:36:50 +0000
Received: from smtp1.irit.fr (smtp1.irit.fr [141.115.24.2])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 13eed863-89be-11ec-8f75-fffcc8bd4f1a;
 Wed, 09 Feb 2022 16:36:41 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 13eed863-89be-11ec-8f75-fffcc8bd4f1a
From: <dinhngoc.tu@irit.fr>
To: "'Jan Beulich'" <jbeulich@suse.com>
Cc: <xen-devel@lists.xenproject.org>
References: <fe2e94e8-9e46-82be-6e83-391f4709ef75@suse.com> <20220209131251.387-1-dinhngoc.tu@irit.fr> <ad339015-c5e7-d776-17a3-2dbd337fcd4a@suse.com> <000801d81dc8$8f15b9a0$ad412ce0$@irit.fr> <2bdd699a-9644-ee6c-c75d-c5577c836f62@suse.com>
In-Reply-To: <2bdd699a-9644-ee6c-c75d-c5577c836f62@suse.com>
Subject: RE: [PATCH v2] x86: Use low memory size directly from Multiboot
Date: Wed, 9 Feb 2022 16:36:47 +0100
Message-ID: <000b01d81dca$d932e420$8b98ac60$@irit.fr>
Content-Type: text/plain;
	charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQIgBme26ChWP5n2WBO9OQe2xD3DKQHRtGxLAKyTMs0BFUqAwwHPzDknq9BsZPA=
Content-Language: en

> -----Original Message-----
> From: Jan Beulich <jbeulich@suse.com>
> Sent: Wednesday, 9 February 2022 16:23
> To: dinhngoc.tu@irit.fr
> Cc: xen-devel@lists.xenproject.org
> Subject: Re: [PATCH v2] x86: Use low memory size directly from =
Multiboot
>=20
> On 09.02.2022 16:20, dinhngoc.tu@irit.fr wrote:
> > This change should only affect the particular case of booting with
> Multiboot2 without EFI (e.g. legacy BIOS or Kexec). Other cases like
> Multiboot 0.x, EFI booting (with or without MB2), or bootloaders that
> generate the BASIC_MEMINFO tag correctly shouldn't be affected.
>=20
> How that? You're taking out the reading of the BDA value altogether, =
aren't
> you? This is certainly a change affecting other environments as well.
>=20
> Jan

I missed that the BDA was used when booting on Multiboot 0.x as well. I =
can add a fallback to use the BDA when the bootloader doesn't provide =
low memory size in the MBI.



From xen-devel-bounces@lists.xenproject.org Wed Feb 09 15:56:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 09 Feb 2022 15:56:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269357.463417 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHpKh-0000va-SU; Wed, 09 Feb 2022 15:56:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269357.463417; Wed, 09 Feb 2022 15:56:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHpKh-0000vT-OK; Wed, 09 Feb 2022 15:56:39 +0000
Received: by outflank-mailman (input) for mailman id 269357;
 Wed, 09 Feb 2022 15:56:38 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=8/P6=SY=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nHpKg-0000vN-53
 for xen-devel@lists.xenproject.org; Wed, 09 Feb 2022 15:56:38 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id db482beb-89c0-11ec-8eb8-a37418f5ba1a;
 Wed, 09 Feb 2022 16:56:36 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: db482beb-89c0-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644422196;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=oApr4AAO9tH9pjl+EhZ07NUVuyn8e71fAYojDm3f+0U=;
  b=Bj69LQV0HYAJviuOUUgtF/ChJfh/hMRNj20LBqzagRhP462Giqi+jydP
   aN41/sVpHJDpmmF7fSoA1SIAugwZpNZXTLgPCpXR4uQs2HDscRWTUxNCe
   dJzw/hdMISVfQRyPAP7oJf4c9Y3CUCLDezOOdlYAI8IPwHNJLL57PNTqu
   Q=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: 6x8+wNC5vQ+f/eOAdS11W40BjAAMnPBR/YWMpvMtsCo2OmcplRWVr0lEmYfJkjHbeTbkNBlar1
 nJwM1QBe4WQ6wx7FEKHk4VJFD1JviWgMYxGO2ICQ8g5oNdt5yijiztdEizvpApQYHycjTjZLx6
 RJc4rUZnb/B3Vxt5dXx7XfGS3quKuQrb9nPiyf6hxxl5BJMhvVNX5vsibwO+W0VBszNBTOfBuR
 Yf8uVw4pAH2jRk1q/oxm/EVmxKksENNtfvwRKbI3B5htB28BJBykpySroKkAFk1Rz4uohq0UL8
 BNh3ZB8VT9wHbFzkHIywh9I7
X-SBRS: 5.1
X-MesageID: 64246028
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:yqol16l8cgYAD1Pi7e5QGEDo5gxeIURdPkR7XQ2eYbSJt1+Wr1Gzt
 xIdUW+OO63fYWvxLtl3bY3joxgGup7Szt9jHAprqiszEyMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BClVlxJVF/fngqoDUUYYoAQgsA180IMsdoUg7wbRh2NY52YLR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 Pprp7ieSTwIB7KWguYGciQIDxlGZ5QTrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBNPsM44F/Glp0BnSDOo8QICFSKLPjTNd9Gls3JwQRayOD
 yYfQWJhMCjjYRZkAVg0KKIRufeXpySkLiIN/Tp5ooJoujOOnWSdyoPFINfTP9CHW8hRtkKZv
 X7duXT0BAkAM96SwibD9Wij7sfDnCX7Xo0VH/uk69ZrmlyPgGIJYCD6TnPi/6P/0BTnHYsCd
 QpEoULCsJTe6mSEaMvZcR2DgUeb5AQeQPttQ/EC0Fu0n/+8DxmiOkAISTtIadoDvcAwRCA32
 lLho+4FFQCDo5XOFyvDq+78QSeafHFMcDRcPXNsoR4tvoG7yLzfmC4jWTqK/ESdqtTuUQ/9z
 DmRxMTVr+VC1JVbv0lXEL2uvt5NmnQrZlNsjuk0djj8hu+cWGJDT9b1gbQ8xawfRLt1tnHb4
 BA5dzG2tYji962lmi2XW/kqF7q0/fuDOzC0qQcxQ8V6q2nxqifzJN04DNRCyKFBaJtsldjBO
 hC7hO+szMULYCvCgVFfP+pd9PjGPYC/TI+4B5g4n/JFY4RrdR/vwc2dTRX44owZq2B1yftXE
 c7CKa6EVC9GYYw6nGveb7pMitcDm3FhrUuNHsqT50r8jtKjiIu9FO5t3K2mNbtisstpYWz9r
 r5iCid9408HD7SlP3KHqNV7wJJjBSFTOK0aYvd/L4arCgFnBHsgG7nWx7YgcJZihKNbiqHD+
 XTVZ6OS4ACl7ZEeAQnVOH1ldp31WpNz8SAyMSA2ZA760Hk/e4e/qqwYcsJvL7Ug8eViy99yT
 uUEJJrcUqgeFGyf9mRPd4T5oaxjaA+v2VCEMR26bWVtZJVnXQHIpIPpJ1O96CkUAyOrnsIiu
 Ln8hBjDSJ8OSl06XsbbYf6i1X2run0ZlL4gVkfEOIALKk7t7JJrO2r6ifpue5MALhDKxz270
 QeKAEhH+bmR8tFtqNSQ3PKKtYakFed6D3F2JWiD4ObkLzTe80qi3ZREDLSCcwfCWT6m466lf
 +hUka3xaaVVgFZQvoNgOL931qZitcD3rrpXwwk4TnXGa1OnVuFpLnWchJQds6RMwvlSuBesW
 1LJ8d5fYO3bNMTgGV8XBQwkcuXciq1ExmiMtaw4cBfg+St63LubSkEDbRCDhRtUIKZxLI54k
 /wqv9Qb6lDnhxcnWjpcYvu4K4hYwqQ8bpga
IronPort-HdrOrdr: A9a23:YqhjeqnS1IEbHNut+XvYIcXvib7pDfPOimdD5ihNYBxZY6Wkfp
 +V88jzhCWZtN9OYhwdcLC7WZVpQRvnhPlICK0qTM2ftWjdyRCVxeRZg7cKrAeQeREWmtQtsJ
 uINpIOdeEYbmIK8/oSgjPIaurIqePvmMvD5Za8854ud3ATV0gJ1XYHNu/xKDwReOApP+tcKH
 LKjfA32wZINE5nJviTNz0gZazuttfLnJXpbVovAAMm0hCHiXeN5KThGxaV8x8CW3cXqI1Su1
 Ttokjc3OGOovu7whjT2yv66IlXosLozp9mCNaXgsYYBz3wgkKDZZhnWZeFoDcpydvfo2oCoZ
 3pmVMNLs5z43TeciWcpgbs4RDp1HIU53rr2Taj8AzeiP28YAh/J9tKhIpffBecwVEnpstA3K
 VC2H/cn4ZLDDvb9R6NqOTgZlVPrA6ZsHAimekcgzh0So0FcoJcqoQZ4Qd8DIoAJiTn84oqed
 MeQP003MwmMG9yUkqp/lWGmLeXLzcO91a9MwU/U/WuonZrdCsT9Tpb+CQd9k1wgK7VBaM0ot
 gsCZ4Y5I2mePVmGJ6VNN1xMPdfNVa9Mi4kEFjiV2gPR5t3ck4klfbMkccIDaeRCdg18Kc=
X-IronPort-AV: E=Sophos;i="5.88,356,1635220800"; 
   d="scan'208";a="64246028"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=c8UylR1qoGW7d67DNapky+3i9LkTDDtPxPrC8XSvQKSSGmZZXtia45AixiuuqkJj1SibB1lIARetKrg0uIZSGnKK36Oj68hZJz9qNIRD6kDA/XqfVt3P/l5K9gWLP0igyFTIqOWMWb6PlMvlQ8eaJCuGLnzw22zDZ1SccspVXCJJAu0upAXZ7GbcAr+UavPMprB4HfK+ZxQQe3dBz5mFGR1MSMwgdhxg9VQN96rKVayUNY8dlojWfvZu+mfiO6hdFqTWtqxRh7UkJN3tYNTEC72VdkH4qlQCSpR4ZLDw8oxKd/M/cUwvK5iuh+72IeZKNuJmgCrY1lbQ/nWZNK4mMA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=AcrIWe5kGyPvapn39UImlpfu4qEuHx+mmBhUcAMUlq4=;
 b=bLhXK/iydQOW88M6Dx7HZs4dbC/ibflX0Qq2ksJ7fqbWq0dRY02CNZMOj/HIkzunfqQsZVFjhUYC/jxOiFXm1HvH2wdATjhaQNYxIkeGqkexq04gbFnCqf3JmWGEEAK4fEknP9qMXxSRSODkyTJ1hNV4xcyye2zMmovSYTDjKdTVJyexF8Dm5HxUeUKWmX5Qe1HiZ2jg/YyeBVa0OQL1Asz60Vyeh0V/jzTA+D8xC4zRxsyCz392vySE8irS0h6OKC6OiZ81csRSxNTcHJNd9PndNhZgwW/LjiLe1qYXDkRlE+nkan8qbTCz+FL9Fam9Kn39zivaQ09Ss1TWPuarKg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=AcrIWe5kGyPvapn39UImlpfu4qEuHx+mmBhUcAMUlq4=;
 b=ucpmkzPGXc0mw+7im9X2IyUI9OdF6IE+jdgHdJPGg14I0xb+XZ6P3AFZ+xJlhnGM8/ZUaWTRJ6gtW6dN5rwb4G854UEfWEqlqK5M5L3bpZ74ttc7dSQIkUu0KWCKCS6PJGWnVQwulhx08MU7i78u6pFENakslLw20Ma69GIXcD4=
Date: Wed, 9 Feb 2022 16:56:22 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Tu Dinh Ngoc <dinhngoc.tu@irit.fr>
CC: <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2] x86: Use low memory size directly from Multiboot
Message-ID: <YgPkJkNz6JMoubti@Air-de-Roger>
References: <fe2e94e8-9e46-82be-6e83-391f4709ef75@suse.com>
 <20220209131251.387-1-dinhngoc.tu@irit.fr>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20220209131251.387-1-dinhngoc.tu@irit.fr>
X-ClientProxiedBy: LNXP265CA0006.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:5e::18) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 74f491bc-f0c2-46c5-3281-08d9ebe4bae6
X-MS-TrafficTypeDiagnostic: BYAPR03MB3959:EE_
X-Microsoft-Antispam-PRVS: <BYAPR03MB3959F31EC570A528EA7E7A3D8F2E9@BYAPR03MB3959.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4714;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: tTCtsfWjdlJJVlLA/gaFxBZDqoHXWklxeJbqeCH9tajLZz8EC2R2EJImaV3fXQkfUULWd6nwFt8s30GTG/lAgVuXAW3h06weIa0ORwyaEoTGt+G096CrkPL6AzPmNBwokIlEMQr4a+/pCZS/P5PXjXfuCcDIJrEIvP53HLxSMo1NnTp+MDDCRFmyTWo5C6nqM+efl7dwi/j1PjrLTFqPG4p3BgADA0yX134bVBoVFSTz2N1vowIr/yofvcaiGJu9THcihNp8fV+I+o3UkZxSYqHksXsTDQJkUFWPWKAYPDaH5s+ZIpoQAerbftHiMEyIWCYn4MiqazsDix1ScRutGJ32OSpPUbY2xEa4ySd7m8brJiFP5BsN2eUj8UomHkE9E4GYQgYXuQ53mmdWTcLx37pZyTrzkmIkIZ3bFtPxQxDvSa6M7ry1BuWj+zmMPvU1ynYjKZIewMIJbnuzHRqF41UK4V0ffiR070IVtdm0jLlSCFWgGSSCxjhTO9WuNuqGoOZAiEVWXgrdo0RcoaHeAqjGRv03wvv55ctC18xZfgB7MHVfttEX79JmwTD77VpisYq9e90J+SYhS6Q0iEpAKOQy7BscTqK7wv5e4ygOUt7FllrVNnma6uPrn1rN7JLeziWAnCLdYM3O0g8uTs0clTBtM7ZWNfGJrUFOj9oLTNaWi0NZp/O87+kYKgUj06bF0wA4yuRDjsHVk+3tWpDY8rpUYVUscnXDP/km6ozApn4=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(82960400001)(186003)(2906002)(33716001)(38100700002)(26005)(508600001)(9686003)(6486002)(6512007)(966005)(85182001)(83380400001)(66556008)(6506007)(6916009)(8676002)(4744005)(6666004)(66946007)(66476007)(86362001)(4326008)(5660300002)(316002)(8936002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N2hpODJvTGV3RTR6UXR0UWdmd2NzMDdSUHg3dlVIemJKS091V290Rk5Hc2xx?=
 =?utf-8?B?eEpXYjdZemQvdElxOG1pSnVRMFh5SzBrRDVxdlpsZXJHdzZlRXl2cldCVmNF?=
 =?utf-8?B?aU5sTUZ0SFA0b0srZ0xTU21MOFBBVjBHU3lualJSdEJDRzM2eHNaZjFwL0ho?=
 =?utf-8?B?d1dld1A1Q1lmck5EZlBEMm5wUm5SZXNubWpOU2g5TkU2U1kvVFlIOFJQV01X?=
 =?utf-8?B?MVN2S05PQlVlRTFZS0VxSXZybWZUQnFXWTJTS01MVWpBTGEyVm5iSG5nNUpt?=
 =?utf-8?B?cUlFM1Ewd3VQTnhoZEU5bXRwSkF2U3Y2UytQQld1aDVwZEM3QkkzZTJsL1ZU?=
 =?utf-8?B?akZSeVpSSk9oMktmb0ZKajJFTU9ZdGRpeExHOUtxa0RPdUZjRTN0T09hb0hr?=
 =?utf-8?B?a0JhMHFZbUQ4Sk5BNFpGV1lnem0wUzhWamt3TTIrSzY4R3BHWTREN3RRTlZ5?=
 =?utf-8?B?MW9TMGRIb3Z6OENabjlDK3doYjFkN3JMclY4ZjhNbUVKc3hkTGUyN2VFMGx0?=
 =?utf-8?B?YjhpekRuMWRGSFo0VFN6TXJPZXBmWXhJS0lhd0dnV0pyS1hha2hjYjdMNElZ?=
 =?utf-8?B?b3p3THBwNjI5Y2hwN1ZtZnUyZ0JuWEg2amZPVk1HeDlCbE5ENkQxWVRmeGI3?=
 =?utf-8?B?RnhYdjdBV1pIbnRJL2RrdmFkZXd0SWxYSWFkeWEyNWhQc1A3UENrYjFZTkNj?=
 =?utf-8?B?ZjZRejcrSHdJdEllckRvMmVSbzJKZkpqTXRueTk3aUZuL2VWcmRFaDJvYmdL?=
 =?utf-8?B?WmYwRmtLdWVXdlhUYWs3eGNBZUEzUTZvb2tMRGRIWGgxTTdqV29QeTRLZkxD?=
 =?utf-8?B?L3ZFRERLY2xtOEQxR2x3VmZna1R2NTZrU096TFpLbjUxZ3libDVaMlBSRXB1?=
 =?utf-8?B?ZzY2RFVWd2J4czMzTkdodE5HSklGZk9zTTBtUTZyd254WVpzVStXeWhweW5L?=
 =?utf-8?B?NlcwMTViM3dYWWxxOTN6Sjk4anVNbjAyWXZmaFMvMWd0THFBVjRjeXM1aVU1?=
 =?utf-8?B?T1J5U2pSRitsekU2MVVSR1VjbEpmZjIwQit3a3BybnAwMTZKNmhkY2w0Y0wv?=
 =?utf-8?B?VW5pd2E3d0RaZ1JxSXFXbE9yRE0wbXA1ekJNU0lwSDlmVFl6R3BHbnRweWpI?=
 =?utf-8?B?MTlzZjYzMmpncmE1dXloLy9xZUxoWDVVWGdpZGJFeGs0Y1E2UkNzVG1oRDNw?=
 =?utf-8?B?V2NabnR0bEczeXMrUnMwTDVtV3AwUW8ybDFWN1ErQ1FndzlJeHVWMVlTbzRu?=
 =?utf-8?B?bllRT0RrMk9aSm9YUytBSCt6UXM4dlR4dFpjaWQ1dStWZ1owZzl2b000b0FL?=
 =?utf-8?B?c3ZuZkkwWGdsNzJkRWM3WkoyRm9nMTU5M25UbmVGalAvM3drZnhNQ21vVjBS?=
 =?utf-8?B?ZHNsblFJNFBQSnFDNHc0VEh5bnh3bXUydjVPdjZZWEZOT3YwVzhaa1VVajJE?=
 =?utf-8?B?ZWxZaDRvMnl1VW44TklFayt6MzU4WDhjMys4T2NSUDg1WFVUQTIvSTU3WW9T?=
 =?utf-8?B?ZmorZitmWHhmY3RSbUVNTTNERUxYYllkSEoxcnZ5a2FZdUhOcExrZElkQ3ln?=
 =?utf-8?B?VGl4eXhtRzdFS04xd0xuYmpqVnh3TXJwWGRINUZNNlZHNUI0YmpSd1phTmpG?=
 =?utf-8?B?VkZxREpUZEcvMjFCUmNid09ROVcwdTZFSHU0cEsyMGswSnlncTlObW53dVlE?=
 =?utf-8?B?VVN1bFNJZU1iR21LRzRDaFArazhYQVdGR2thLzVHR3ZVd1FuMzd4aGlSTEVZ?=
 =?utf-8?B?akdzbkczTWhFaThLcWZIVDQycXZmQUgyL1lrbjcvbHRRZEtVMzhuOXdKVzNl?=
 =?utf-8?B?L0pRRllJZWg0dnhjMmg4ZURpdkE0U2RUbkJlNElVN0d1WE1CdmhxVmN0eFhv?=
 =?utf-8?B?bStHdSs2dFhXUFI1ZDE2SUhlSnVkSnBoMWRLcnpOVGc0dlVGb0VZNDRhOEs1?=
 =?utf-8?B?QThTdEdoSjdjSWUxaWVZc1BPT2FFWDZpdUMzdElZMi9YYWZ0cTdrdTZmNlo0?=
 =?utf-8?B?Nzl5VUp5dUlxb1ZVYXErMjlNdnExRFc0R0duYldPcUxoQmhBQjlDVlEvVzR6?=
 =?utf-8?B?VEk1N3R2b3lDcnNGOFJ6TjhGQ2NmNlRMWHhZSUtMYyt6QkpDZVh1ZzRXaEhV?=
 =?utf-8?B?S2ZJLytjYkIrbjlRVUJ1cW9GYnhVaHlIWVlMTC9JZ2pXRXFwS2gvV1RJTzNi?=
 =?utf-8?Q?C/N3qTtb+qX/3FoKa3p+u1Y=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 74f491bc-f0c2-46c5-3281-08d9ebe4bae6
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2022 15:56:27.2712
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: llYmSu99lN3T64wA1IIHsgr6wIvIpIcNSd41zbmUGuG87SlH4vKQEzdSFGIqGBu50YOSFMaOvjDoqp2EcLHp+Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB3959
X-OriginatorOrg: citrix.com

On Wed, Feb 09, 2022 at 02:12:51PM +0100, Tu Dinh Ngoc wrote:
> Previously, Xen used information from the BDA to detect the amount of
> available low memory. This does not work on some scenarios such as
> Coreboot, or when booting from Kexec on a UEFI system without CSM.
> 
> Use the information directly supplied by Multiboot boot information
> instead.

This is missing a SoB, see:

https://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches#Signed-off-by

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Feb 09 16:39:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 09 Feb 2022 16:39:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269368.463428 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHpzZ-0005gF-0G; Wed, 09 Feb 2022 16:38:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269368.463428; Wed, 09 Feb 2022 16:38:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHpzY-0005g8-TE; Wed, 09 Feb 2022 16:38:52 +0000
Received: by outflank-mailman (input) for mailman id 269368;
 Wed, 09 Feb 2022 16:38:51 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=GcOB=SY=epam.com=prvs=403937fcac=oleksandr_tyshchenko@srs-se1.protection.inumbo.net>)
 id 1nHpzW-0005fy-GI
 for xen-devel@lists.xenproject.org; Wed, 09 Feb 2022 16:38:50 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id bfcb37b3-89c6-11ec-8f75-fffcc8bd4f1a;
 Wed, 09 Feb 2022 17:38:46 +0100 (CET)
Received: from pps.filterd (m0174682.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 219GNSKf014823;
 Wed, 9 Feb 2022 16:38:40 GMT
Received: from eur03-am5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2050.outbound.protection.outlook.com [104.47.8.50])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3e4gqk85vv-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 09 Feb 2022 16:38:39 +0000
Received: from DB8PR03MB6108.eurprd03.prod.outlook.com (2603:10a6:10:ed::15)
 by AM6PR03MB5847.eurprd03.prod.outlook.com (2603:10a6:20b:e6::33) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Wed, 9 Feb
 2022 16:38:35 +0000
Received: from DB8PR03MB6108.eurprd03.prod.outlook.com
 ([fe80::e975:b192:b8cd:4f73]) by DB8PR03MB6108.eurprd03.prod.outlook.com
 ([fe80::e975:b192:b8cd:4f73%5]) with mapi id 15.20.4951.019; Wed, 9 Feb 2022
 16:38:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bfcb37b3-89c6-11ec-8f75-fffcc8bd4f1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=frAVRGxF4aA4A+s6t3Qr4VS74twH8ZC4Pli36C+eMowVZ3SpkAQ03yFqeEZLhwkTq+pFqpLAgOdt4+UnIArnvytGU0j6xGWj0SekYLUDX42x3hz+V9A2+R7D4aUxHjWBb2UDAHDhf2m+H6CaDjCCm5rrGOxPaWwLegUcXoxe8z0DdjjdueRuIeh+e7Hh/EP3WLdJW5gW65/Nhe6xAZXKWnJwZTLMPTSXq9mZy0Co0xqOhJrB6Lz/qpCePnscZ+PI+nj1UP2B8m4HHVuTYQGOzjjYe/6KXyhLYGsK4acAVzEPT9iZ5frQv966nU0ZdXLnE8AeDi2fdr6l8o1VGY2eUg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Gtlfx1xBURgUuVIVo8bhW2XNcBjeQcIWS44T0Hq2N+w=;
 b=aN1y21XBcBZMds5siinQDlSaUQKJG6U4JWOzvUi4NT4qaf0dq80ieg3owguKJsQfZp2cMCB3YNv4oq+2flngAaV/EFPrTyUV5zrW/a7qbnoGzXzb4rvdrsuj9fpurRgrRWo9FKndZd4GK8AXIjt3bSemj8+3YWY5vH7nqieI0gQpB2OPWnaQmBiJBgt2eScq2FyIUvYk6HtysJ7y0sWTnwbCJ5Mks5kLabuhtZ7HHHUH2H9awN+HazBgZ4Xpm2SNrkBoBWtv31fcihqJTJAUWbZLvG5Q4PFa6sIs9jOJIgnTI323u6edhXfllYc3aH2cFarxxEuwEkIVRlxKozigdw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Gtlfx1xBURgUuVIVo8bhW2XNcBjeQcIWS44T0Hq2N+w=;
 b=mo02eEcReWqCJnu8LWsCeeugfwZgtPdW1lGhstWsuOkXApzr00FxH1/KKHci8tXAwF3mtsidLKFNUDzXpiiP96M+PjJCkqyR6UbUMcOwhg/dWWx3CYrDMwOwikBJn75IURXtS7i41UVbP4AHZnkcJTN6W3K+GUXwz7yHGIAScs9AKJm1ZM0m4TTD5CDOslOl7fv+hH6KoXT2f5sMocovw/BlGlmgK15Zth9VHxNF7d0RbDdR+qbaB2u/jHCNjNeFkfw8y0CJF5rWhySPrKzBNPpuppxAgbClRieLpY8HyymjpEKO8Fce1YQF6FVUeczK73546YPljTlNjDNnfeoTaQ==
From: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Oleksandr Tyshchenko <olekstysh@gmail.com>,
        "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        Stefano
 Stabellini <sstabellini@kernel.org>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Andrew Cooper <andrew.cooper3@citrix.com>,
        George Dunlap
	<george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
        =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>,
        Bob Eshleman
	<bobbyeshleman@gmail.com>,
        Alistair Francis <alistair.francis@wdc.com>,
        Connor Davis <connojdavis@gmail.com>, Julien Grall <julien@xen.org>
Subject: Re: [PATCH V5] xen/gnttab: Store frame GFN in struct page_info on Arm
Thread-Topic: [PATCH V5] xen/gnttab: Store frame GFN in struct page_info on
 Arm
Thread-Index: 
 AQHYAomKM/4d8JNsdEqc8nNA4dib2KyIh6IAgAAs1wCAAQzHgIAADcoAgAFl0gCAAA+ugIAAXVgA
Date: Wed, 9 Feb 2022 16:38:35 +0000
Message-ID: <4a928360-b901-09c0-7a65-72abaa506706@epam.com>
References: <1641424268-12968-1-git-send-email-olekstysh@gmail.com>
 <a54213c4-1c68-694e-c130-d95faeef3953@xen.org>
 <78d94e1e-6db4-25c1-adb8-e4bdbfe42774@epam.com>
 <82d8bfe0-cb46-d303-6a60-2324dd76a1f7@xen.org>
 <3629d57d-6d89-5ada-1664-cd532342fd0b@suse.com>
 <d42f0e9f-d60d-8ec4-7053-9ecd1a069925@epam.com>
 <7f81a991-b66c-41cd-5f0c-1f121446ee1b@suse.com>
In-Reply-To: <7f81a991-b66c-41cd-5f0c-1f121446ee1b@suse.com>
Accept-Language: en-US, ru-RU
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: f5075fbd-4a9d-46c7-1d07-08d9ebea9ddd
x-ms-traffictypediagnostic: AM6PR03MB5847:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM6PR03MB5847C7319686E935B5856FAF862E9@AM6PR03MB5847.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8273;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 iygKAaOzF6cds29dTRchoizfvGmpEA9PLFOZ1yoxIaG7zT7jNS6OODCHpaegKrXun0Xeo/8D5ooTc4aRmJ1wVZMoWQfyaT9rH4r+hrraY/SAwcEP7MTfVTNaGZKoXQKBL5b9fB+73Xs1AuE04HErK37jEZgN7yNn0ya/QL1LLCg7bfQrXlivIjrEzKKY4rtNtz4BmRFd9aDyFnqnyQmV0pQQj0KUFyU0Ci02M5pJTy0+J3FKSMUhjGQ18j3bbOgpW/CLKraCTR85COrin85+ZklqEdADprviYE69fy00m6ZZSh55NDh3yhR9EemoDHg++u9AD5vS6AkfURh/8fzWLNr9pvYSSpuWEXNMSmGDBLQ8stHFz30oi2y3A9YtRtGgu8Y00vxpIB9T5jGoEsnTM/19bJ+11mpglByo3V+IoSYVC6GRaEhR9+lwv1HDnYIrHxmi6n4pXn2zD9Hz7onl9Px/c21SZIW+MvA/0Dj+vp85unSl1uVFPxel9TYGO5xO9SF2gLgPlYyVJr0PPGJxLMAurM4HpYf++CMebPF7DEoKfb+W9N0oC7nj63dn1ju3Q54F0vqnwleBzbXFKvsmX40RuxohSmRW5xGCXFhZgys30z/bGWg9Xcuo9Yzc4JRTsDuy9xzfe3SNji+GUdrcXiZcam6ogG/dZNDo2riUkL/0abz20dYAYqsxOXntbn7aMTHCfMDO8XG5Eu2WbGw5bDAzPzyvoi9A1weQLosHEqkD7GlFe8LjLCW1D26HjUyR
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB8PR03MB6108.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(31696002)(26005)(54906003)(71200400001)(186003)(6486002)(91956017)(316002)(508600001)(86362001)(66556008)(8676002)(4326008)(66476007)(66946007)(76116006)(6916009)(66446008)(64756008)(7416002)(38070700005)(5660300002)(2616005)(8936002)(2906002)(31686004)(122000001)(6512007)(55236004)(36756003)(6506007)(53546011)(38100700002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?enhkeXZSK0ZGTXFPS3p4Zyt4RngrTit3SXQwQ0lubXo5OEg5WHhjbVBGTUpF?=
 =?utf-8?B?Mkl3b0VoSldpUm01VjQ2MUJNQ2xEUjdOV3JHQzZObVJyNjR1VitKbnBDWE82?=
 =?utf-8?B?bE5VOTJSejU5MDQxeWd5TW9VR0pQQ045U0NHWmNvQ1A0MkRaZGFPOTZOaU5Q?=
 =?utf-8?B?WDZSbEpGdVlHYkU3YnFMN3EvcFI0SU03VVZ5NmFORXg0MWMxSCtZcy9UL1Q2?=
 =?utf-8?B?OWFjS1ZFWTdEZlE0V1c2MU5DVG1aRkVLbWkzUzYxcjJSR3h0d2poMFdxbksy?=
 =?utf-8?B?S0YwbFMrR0MxVWhueW9wSzRaSTZ0a0swN0hxcDFodjNBOWdwKzdhNnlGYjlO?=
 =?utf-8?B?ZmhtYWxGVkFXY0c1Q0dyZ0YycVRtVlRvWW04QytLMElzNHd6YnFTNUovMXJ0?=
 =?utf-8?B?VHU1TEJtKzkxY250dksrZkZ3ejR3UEI0T21WYkUwVUV5c1podVltUllCWEpY?=
 =?utf-8?B?UTFPdVkwREFMYnI0dlFpYWhOTDQwc2JRekN0c0xVQk9iQWdab3lUckdrTjZQ?=
 =?utf-8?B?OWIybUR5eTdCQ0greU10U3hoRXV1eWx5THQ0WFNab2NqK2hNZ1NJSGg5MDBu?=
 =?utf-8?B?Q1BLRk1iYU1BRFVyOG9IWGJlMzdobVBwMTRYZnFWM0doTlgrZzI3TFZMNUxJ?=
 =?utf-8?B?WW1CR2kveVR1bjBUS0VPQStFSXlRaHNSL2pmMW0wZ2RoQVIwOWN0TmVqNmJo?=
 =?utf-8?B?T0N1ZmxtNldVVTc3dTk5S3lsa2l0T3ZPM2p6MnQ1VmhoY0Z0YkFBdDZhNDZQ?=
 =?utf-8?B?eStoZHEwZnJoK0FpSUZxZ2FZTVV5b3ZOSjdvZHB0Q3VLR1lJMVdKMGtjNE5a?=
 =?utf-8?B?S3JoYit0RkNKSXUvSXd5Q2lFeHBOaGxISHlnanRaRVBUQlIxendRSUpVZ3Ey?=
 =?utf-8?B?dER0RlR0U0dFdkZsMVdwdWtjV3FJdUozczI2eE1EMGI1UTAyY2lPVmVaczlh?=
 =?utf-8?B?VXFKQXN1WTFXZEtTQTZBMlI2R3pPWnVqdDBvcnZhRVFhb2pkSG5UaDJpbFpO?=
 =?utf-8?B?WkhacVpsTWNNNHVMWWZuOHZKVURPMlp3Q0NJSUNYU2ZybFJMaVpDcTN4NTZD?=
 =?utf-8?B?VGpFZjc0b3FYUTh2Z0hpVmdMd25IMnN6N1VyWlNBT0VkRjZCa3hEN3dWN01j?=
 =?utf-8?B?UVBsdEJZYyt4WTJPRGY4bFNJNThxdDZ6OGFJYVF3RHRFYU5pSHllMDNsdGpp?=
 =?utf-8?B?Ky9jVW82ZDh1NExFK2hsTUlDbnpzTmlqZXdhcWc1bE9qTFlSN2pHUHR5S09r?=
 =?utf-8?B?c0JQc0NvUlN5QXRBd20vOHBwbm1tZWhRWHpPLzlHMmE2NFJlRDRQL2NxWU9O?=
 =?utf-8?B?czdrdGdrRjlJanRabzBMbDQvOHRSTzZsS1NxQ1BYOUduUHlZalhWVlI1NGcv?=
 =?utf-8?B?bW5kZDlTTGFRZDdraFNZZDZBNG9jWlJSbzZXbTREYlI4eG93dVk0dHVJcU5i?=
 =?utf-8?B?Rm9od001bnNxeG9UVXR6YmkyOHJhQVhFRUdFYWkzMXRQdnczc25xU245eE5N?=
 =?utf-8?B?eVlLb3o1L3FaaHZoeUhjL3ZNY1RiVWJSOTNLZHJPaVdNRXRVMVdxZ0JDT21N?=
 =?utf-8?B?UVNlblpMREpRTTJWa1NLZjlTUHhoMlBQVVpQSk5lVXdYRXI3YnR5MENOWWFv?=
 =?utf-8?B?VXpFN1NHU1BaSk1tWFZVdklYSjhERm1PM0x6OEFud0dQU0xOWTU5SHRFekdv?=
 =?utf-8?B?NmdsbjFuNCtSYzR1aUJLMjY3d21wSzQza1BqelV4aHQwanlLcnVyaFFCajVp?=
 =?utf-8?B?aTNvM1lveFRYLytoQm5pTnRPM015dzNCNHVqSDBKNmlwd2YrNmF3OHZaUTlD?=
 =?utf-8?B?clVwV2loVGU2Ym85WW0xVllLa3dTbll1ZTN2TzU1RWtBNDcvV2pRUTBmdHVX?=
 =?utf-8?B?V21pSStjYytLNHJZSmRZSzRyY1NwME1hUUxiUFdQdk9TbVcvVmdYaENnUHFF?=
 =?utf-8?B?bkdqdEpHT3EzNFBQTzFHV3czeVpvdjZjUFlWNW5VZHBGUnFpNkxDL0J4WjRt?=
 =?utf-8?B?V1k3a29OMXNmTEp2bHljcEhIYU9mSXhFU0xKYkZaUTBEeldVTEU1YWFSV2tP?=
 =?utf-8?B?WEJrT0UwVUF1cXVrTEwrWlFwOHJOU0p1YzNSb0pkNnpydWdCSEVpVHhtMC9I?=
 =?utf-8?B?b0lvaWpZMExHb2REQkJ6MjhlcGQrV1IyL1lodDJtVEJtemRuQ0ZLUmt1dXJ6?=
 =?utf-8?B?UlpRbC9qUi96a1RXUWYvNmIraTlXQmRCQUY1ZGovNXFwNjZPWE9qYk4wZkJz?=
 =?utf-8?Q?8x1NDqHV+4zfYZeVIboD8czfh7zvO5NAuXaxVYgaPk=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <1B8E5887C911C44085812081179BE23E@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DB8PR03MB6108.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f5075fbd-4a9d-46c7-1d07-08d9ebea9ddd
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Feb 2022 16:38:35.2399
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: XSS6FmUq615qvp7thBl1BYWJcfNIG2hCHBN0tXr+AUgp2/TqPyq2nF1ZjhMyNYwEYd659IZHuY56wfQUpvHlq2p2OQhi6GnnB6tF4rW70dc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR03MB5847
X-Proofpoint-GUID: kSD05whxu_afVBlbMnEH-NlsbZAS9mtN
X-Proofpoint-ORIG-GUID: kSD05whxu_afVBlbMnEH-NlsbZAS9mtN
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-09_08,2022-02-09_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 phishscore=0
 mlxlogscore=999 clxscore=1015 lowpriorityscore=0 impostorscore=0
 spamscore=0 suspectscore=0 adultscore=0 mlxscore=0 malwarescore=0
 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202090091

DQpPbiAwOS4wMi4yMiAxMzowNCwgSmFuIEJldWxpY2ggd3JvdGU6DQoNCg0KSGkgSmFuDQoNCj4g
T24gMDkuMDIuMjAyMiAxMTowOCwgT2xla3NhbmRyIFR5c2hjaGVua28gd3JvdGU6DQo+PiBPbiAw
OC4wMi4yMiAxNDo0NywgSmFuIEJldWxpY2ggd3JvdGU6DQo+Pg0KPj4NCj4+IEhpIEp1bGllbiwg
SmFuDQo+Pg0KPj4NCj4+PiBPbiAwOC4wMi4yMDIyIDEyOjU4LCBKdWxpZW4gR3JhbGwgd3JvdGU6
DQo+Pj4+IE9uIDA3LzAyLzIwMjIgMTk6NTYsIE9sZWtzYW5kciBUeXNoY2hlbmtvIHdyb3RlOg0K
Pj4+Pj4gT24gMDcuMDIuMjIgMTk6MTUsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4+Pj4+PiBIaSBP
bGVrc2FuZHIsDQo+Pj4+Pj4gT24gMDUvMDEvMjAyMiAyMzoxMSwgT2xla3NhbmRyIFR5c2hjaGVu
a28gd3JvdGU6DQo+Pj4+Pj4+IEZyb206IE9sZWtzYW5kciBUeXNoY2hlbmtvIDxvbGVrc2FuZHJf
dHlzaGNoZW5rb0BlcGFtLmNvbT4NCj4+Pj4+Pj4NCj4+Pj4+Pj4gUmV3b3JrIEFybSBpbXBsZW1l
bnRhdGlvbiB0byBzdG9yZSBncmFudCB0YWJsZSBmcmFtZSBHRk4NCj4+Pj4+Pj4gaW4gc3RydWN0
IHBhZ2VfaW5mbyBkaXJlY3RseSBpbnN0ZWFkIG9mIGtlZXBpbmcgaXQgaW4NCj4+Pj4+Pj4gc3Rh
bmRhbG9uZSBzdGF0dXMvc2hhcmVkIGFycmF5cy4gVGhpcyBwYXRjaCBpcyBiYXNlZCBvbg0KPj4+
Pj4+PiB0aGUgYXNzdW1wdGlvbiB0aGF0IGdyYW50IHRhYmxlIHBhZ2UgaXMgdGhlIHhlbmhlYXAg
cGFnZS4NCj4+Pj4+PiBJIHdvdWxkIHdyaXRlICJncmFudCB0YWJsZSBwYWdlcyBhcmUgeGVuaGVh
cCBwYWdlcyIgb3IgImEgZ3JhbnQgdGFibGUNCj4+Pj4+PiBwYWdlIGlzIGEgeGVuaGVhcCBwYWdl
Ii4NCj4+Pj4+Pg0KPj4+Pj4+IFsuLi5dDQo+Pj4+Pj4NCj4+Pj4+Pj4gZGlmZiAtLWdpdCBhL3hl
bi9hcmNoL2FybS9pbmNsdWRlL2FzbS9ncmFudF90YWJsZS5oDQo+Pj4+Pj4+IGIveGVuL2FyY2gv
YXJtL2luY2x1ZGUvYXNtL2dyYW50X3RhYmxlLmgNCj4+Pj4+Pj4gaW5kZXggZDMxYTRkNi4uZDZm
ZGEzMSAxMDA2NDQNCj4+Pj4+Pj4gLS0tIGEveGVuL2FyY2gvYXJtL2luY2x1ZGUvYXNtL2dyYW50
X3RhYmxlLmgNCj4+Pj4+Pj4gKysrIGIveGVuL2FyY2gvYXJtL2luY2x1ZGUvYXNtL2dyYW50X3Rh
YmxlLmgNCj4+Pj4+Pj4gQEAgLTExLDExICsxMSw2IEBADQo+Pj4+Pj4+ICAgIMKgICNkZWZpbmUg
SU5JVElBTF9OUl9HUkFOVF9GUkFNRVMgMVUNCj4+Pj4+Pj4gICAgwqAgI2RlZmluZSBHTlRUQUJf
TUFYX1ZFUlNJT04gMQ0KPj4+Pj4+PiAgICDCoCAtc3RydWN0IGdyYW50X3RhYmxlX2FyY2ggew0K
Pj4+Pj4+PiAtwqDCoMKgIGdmbl90ICpzaGFyZWRfZ2ZuOw0KPj4+Pj4+PiAtwqDCoMKgIGdmbl90
ICpzdGF0dXNfZ2ZuOw0KPj4+Pj4+PiAtfTsNCj4+Pj4+Pj4gLQ0KPj4+Pj4+PiAgICDCoCBzdGF0
aWMgaW5saW5lIHZvaWQgZ250dGFiX2NsZWFyX2ZsYWdzKHN0cnVjdCBkb21haW4gKmQsDQo+Pj4+
Pj4+ICAgIMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB1bnNpZ25lZCBpbnQgbWFzaywgdWludDE2X3QN
Cj4+Pj4+Pj4gKmFkZHIpDQo+Pj4+Pj4+ICAgIMKgIHsNCj4+Pj4+Pj4gQEAgLTQ2LDQxICs0MSwx
MiBAQCBpbnQgcmVwbGFjZV9ncmFudF9ob3N0X21hcHBpbmcodW5zaWduZWQgbG9uZw0KPj4+Pj4+
PiBncGFkZHIsIG1mbl90IG1mbiwNCj4+Pj4+Pj4gICAgwqAgI2RlZmluZSBnbnR0YWJfZG9tMF9m
cmFtZXMoKSBcDQo+Pj4+Pj4+ICAgIMKgwqDCoMKgwqAgbWluX3QodW5zaWduZWQgaW50LCBvcHRf
bWF4X2dyYW50X2ZyYW1lcywgUEZOX0RPV04oX2V0ZXh0IC0NCj4+Pj4+Pj4gX3N0ZXh0KSkNCj4+
Pj4+Pj4gICAgwqAgLSNkZWZpbmUgZ250dGFiX2luaXRfYXJjaChndCkgXA0KPj4+Pj4+PiAtKHsg
XA0KPj4+Pj4+PiAtwqDCoMKgIHVuc2lnbmVkIGludCBuZ2ZfID0NCj4+Pj4+Pj4gKGd0KS0+bWF4
X2dyYW50X2ZyYW1lczvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoCBcDQo+Pj4+Pj4+IC3CoMKgwqAgdW5zaWduZWQgaW50IG5zZl8gPQ0KPj4+Pj4+PiBn
cmFudF90b19zdGF0dXNfZnJhbWVzKG5nZl8pO8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgIFwNCj4+Pj4+Pj4gLSBcDQo+Pj4+Pj4+IC3CoMKgwqAgKGd0KS0+YXJjaC5zaGFy
ZWRfZ2ZuID0geG1hbGxvY19hcnJheShnZm5fdCwNCj4+Pj4+Pj4gbmdmXyk7wqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBcDQo+Pj4+Pj4+IC3CoMKgwqAgKGd0KS0+YXJjaC5zdGF0
dXNfZ2ZuID0geG1hbGxvY19hcnJheShnZm5fdCwNCj4+Pj4+Pj4gbnNmXyk7wqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBcDQo+Pj4+Pj4+IC3CoMKgwqAgaWYgKCAoZ3QpLT5hcmNo
LnNoYXJlZF9nZm4gJiYgKGd0KS0+YXJjaC5zdGF0dXNfZ2ZuDQo+Pj4+Pj4+ICnCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqAgXA0KPj4+Pj4+PiAtIHsgXA0KPj4+Pj4+PiAtwqDCoMKgwqDC
oMKgwqAgd2hpbGUgKCBuZ2ZfLS0NCj4+Pj4+Pj4gKcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoCBcDQo+Pj4+Pj4+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgIChndCktPmFy
Y2guc2hhcmVkX2dmbltuZ2ZfXSA9DQo+Pj4+Pj4+IElOVkFMSURfR0ZOO8KgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBcDQo+Pj4+Pj4+IC3CoMKgwqDCoMKgwqDCoCB3aGlsZSAo
IG5zZl8tLQ0KPj4+Pj4+PiApwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
IFwNCj4+Pj4+Pj4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKGd0KS0+YXJjaC5zdGF0dXNfZ2Zu
W25zZl9dID0NCj4+Pj4+Pj4gSU5WQUxJRF9HRk47wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgIFwNCj4+Pj4+Pj4gLSB9IFwNCj4+Pj4+Pj4gLSBlbHNlIFwNCj4+Pj4+Pj4gLSBn
bnR0YWJfZGVzdHJveV9hcmNoKGd0KTsgXA0KPj4+Pj4+PiAtwqDCoMKgIChndCktPmFyY2guc2hh
cmVkX2dmbiA/IDAgOg0KPj4+Pj4+PiAtRU5PTUVNO8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgXA0KPj4+Pj4+PiAtfSkNCj4+
Pj4+Pj4gLQ0KPj4+Pj4+PiAtI2RlZmluZSBnbnR0YWJfZGVzdHJveV9hcmNoKGd0KSBcDQo+Pj4+
Pj4+IC3CoMKgwqAgZG8geyBcDQo+Pj4+Pj4+IC0gWEZSRUUoKGd0KS0+YXJjaC5zaGFyZWRfZ2Zu
KTsgXA0KPj4+Pj4+PiAtIFhGUkVFKChndCktPmFyY2guc3RhdHVzX2dmbik7IFwNCj4+Pj4+Pj4g
LcKgwqDCoCB9IHdoaWxlICggMCApDQo+Pj4+Pj4+IC0NCj4+Pj4+Pj4gICAgwqAgI2RlZmluZSBn
bnR0YWJfc2V0X2ZyYW1lX2dmbihndCwgc3QsIGlkeCwgZ2ZuLA0KPj4+Pj4+PiBtZm4pwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIFwNCj4+Pj4+Pj4gKHsgXA0KPj4+
Pj4+PiAtwqDCoMKgwqDCoMKgwqAgaW50IHJjXyA9DQo+Pj4+Pj4+IDA7wqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgXA0KPj4+Pj4+PiAgICDCoMKgwqDCoMKg
wqDCoMKgwqAgZ2ZuX3Qgb2dmbiA9IGdudHRhYl9nZXRfZnJhbWVfZ2ZuKGd0LCBzdCwNCj4+Pj4+
Pj4gaWR4KTvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIFwNCj4+Pj4+Pj4gLcKg
wqDCoMKgwqDCoMKgIGlmICggZ2ZuX2VxKG9nZm4sIElOVkFMSURfR0ZOKSB8fCBnZm5fZXEob2dm
biwgZ2ZuKQ0KPj4+Pj4+PiB8fMKgwqDCoMKgwqDCoMKgwqDCoMKgIFwNCj4+Pj4+Pj4gLcKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoCAocmNfID0gZ3Vlc3RfcGh5c21hcF9yZW1vdmVfcGFnZSgoZ3Qp
LT5kb21haW4sIG9nZm4sDQo+Pj4+Pj4+IG1mbizCoMKgIFwNCj4+Pj4+Pj4gLcKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAwKSkgPT0gMA0KPj4+Pj4+PiApwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqAgXA0KPj4+Pj4+PiAtwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAoKHN0
KSA/DQo+Pj4+Pj4+IChndCktPmFyY2guc3RhdHVzX2dmbsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIFwNCj4+Pj4+Pj4gLcKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgOiAoZ3QpLT5hcmNoLnNoYXJlZF9nZm4pW2lk
eF0gPQ0KPj4+Pj4+PiAoZ2ZuKTvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBcDQo+
Pj4+Pj4+IC0gcmNfOyBcDQo+Pj4+Pj4+ICvCoMKgwqDCoMKgwqDCoCAoIWdmbl9lcShvZ2ZuLCBJ
TlZBTElEX0dGTikgJiYgIWdmbl9lcShvZ2ZuLA0KPj4+Pj4+PiBnZm4pKcKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqAgXA0KPj4+Pj4+PiArwqDCoMKgwqDCoMKgwqDCoCA/IGd1ZXN0X3BoeXNt
YXBfcmVtb3ZlX3BhZ2UoKGd0KS0+ZG9tYWluLCBvZ2ZuLCBtZm4sDQo+Pj4+Pj4+IDApwqDCoMKg
wqDCoMKgwqDCoCBcDQo+Pj4+Pj4+ICvCoMKgwqDCoMKgwqDCoMKgIDoNCj4+Pj4+Pj4gMDvCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
IFwNCj4+Pj4+PiBHaXZlbiB0aGF0IHdlIGFyZSBpbXBsZW1lbnRpbmcgc29tZXRoaW5nIHNpbWls
YXIgdG8gYW4gTTJQLCBJIHdhcw0KPj4+Pj4+IGV4cGVjdGluZyB0aGUgaW1wbGVtZW50YXRpb24g
dG8gYmUgcHJldHR5IG11Y2ggdGhlIHNhbWUgYXMgdGhlIHg4Ng0KPj4+Pj4+IGhlbHBlci4NCj4+
Pj4+Pg0KPj4+Pj4+IFdvdWxkIHlvdSBiZSBhYmxlIHRvIG91dGxpbmUgd2h5IGl0IGlzIGRpZmZl
cmVudD8NCj4+Pj4+IEJlaW5nIGhvbmVzdCwgSSBkaWRuJ3QgdGhpbmsgYWJvdXQgaXQgc28gZmFy
LsKgIEJ1dCwgSSBhZ3JlZSB3aXRoIHRoZQ0KPj4+Pj4gcXVlc3Rpb24uDQo+Pj4+Pg0KPj4+Pj4g
SXQgZmVlbHMgdG8gbWUgdGhhdCBBcm0gdmFyaWFudCBjYW4gbm93IGJlaGF2ZSBhcyB4ODYgb25l
IChhcw0KPj4+Pj4geGVubWVtX2FkZF90b19waHlzbWFwX29uZSgpIG5vdyBjaGVja3MgZm9yIHRo
ZSBwcmlvciBtYXBwaW5nKSwgSSBtZWFuIHRvDQo+Pj4+PiB1c2UgSU5WQUxJRF9HRk4gYXMgYW4g
aW5kaWNhdGlvbiB0byByZW1vdmUgYSBwYWdlLg0KPj4+Pj4NCj4+Pj4+IFdoYXQgZG8geW91IHRo
aW5rPw0KPj4+PiBJIHdpbGwgZGVmZXIgdGhhdCB0byBKYW4uDQo+Pj4+DQo+Pj4+IEphbiwgSUlS
QyB5b3Ugd2VyZSB0aGUgb25lIGludHJvZHVjaW5nIHRoZSBjYWxsIHRvDQo+Pj4+IGd1ZXN0X3Bo
eXNtYXBfcmVtb3ZlX3BhZ2UoKS4gRG8geW91IHJlbWVtYmVyIHdoeSB0aGUgZGlmZmVyZW5jZSBi
ZXR3ZWVuDQo+Pj4+IHg4NiBhbmQgQXJtIHdlcmUgbmVjZXNzYXJ5Pw0KPj4+IFRoZSBjb2RlIHdh
cyBkaWZmZXJlbnQgYmVmb3JlLCBhbmQgQXJtJ3MgYmVoYXZpb3Igd2FzIGFsc28gZGlmZmVyZW50
Lg0KPj4+IEhlbmNlIHRoZSB0d28gZnVuY3Rpb25zIGNvdWxkbid0IGJlIHF1aXRlIHNpbWlsYXIu
IElmIEFybSBiZWhhdmlvciBpcw0KPj4+IG5vdyBjb252ZXJnaW5nIHdpdGggeDg2J2VzLCB0aGUg
ZnVuY3Rpb25zIGJlY29taW5nIG1vcmUgc2ltaWxhciBpcw0KPj4+IG5vdCBlbnRpcmVseSB1bmV4
cGVjdGVkLg0KPj4gSWYgQXJtJ3MgZ250dGFiX3NldF9mcmFtZV9nZm4gYXBwZWFycyB0byBiZSB0
aGUgc2ltaWxhciB0byB4ODYncyBvbmUsDQo+PiB3aGF0IHdvdWxkIGJlIHRoZSBuZXh0IHN0ZXA/
DQo+Pg0KPj4gSSB0aG91Z2h0IG9mIHRoZSBmb2xsb3dpbmcgb3B0aW9uczoNCj4+DQo+PiAxLiBM
ZWF2ZSBwZXItYXJjaCBoZWxwZXJzIGFzIHRoZXkgYXJlDQo+PiAyLiBNb3ZlIGhlbHBlciB0byB0
aGUgY29tbW9uIGdyYW50X3RhYmxlLmgNCj4+IDMuIFJlbW92ZSB0aGUgaGVscGVycywgY2FsbCBn
dWVzdF9waHlzbWFwX3JlbW92ZV9wYWdlKCkgZGlyZWN0bHkgZnJvbQ0KPj4gdGhlIGNvbW1vbiBn
cmFudF90YWJsZS5jDQo+IFdlbGwsICJzaW1pbGFyIiBpcyBub3QgZW5vdWdoIGZvciAyIG9yIDMs
IGJ1dCBpZiB0aGV5IGVuZCB1cCBpZGVudGljYWwsDQo+IHRoZW4gSSBndWVzcyAzIGlzIHRoZSB3
YXkgdG8gZ28gdW5sZXNzIHdlIGZvcmVzZWUgZS5nLiBSSVNDLVYgd2FudGluZw0KPiBzb21ldGhp
bmcgZGlmZmVyZW50LiBCdXQgdGhpcyB3b3VsZCBiZSBhIHNlcGFyYXRlIGNoYW5nZSwgc28gdGhl
DQo+IHNpbWlsYXJpdHkgbGV2ZWwgb2YgdGhlIHR3byBpbXBsZW1lbnRhdGlvbnMgY2FuIGFjdHVh
bGx5IGJlIGVhc2lseQ0KPiBzZWVuIGR1cmluZyByZXZpZXcgKG9yIGxhdGVyIHdoZW4gZG9pbmcg
YXJjaGFlb2xvZ3kpLg0KDQpUaGFuayB5b3UgZm9yIHRoZSBjbGFyaWZpY2F0aW9uLiBJIHdpbGwg
Z28gd2l0aCAxLg0KDQoNCg0KPg0KPiBKYW4NCj4NCi0tIA0KUmVnYXJkcywNCg0KT2xla3NhbmRy
IFR5c2hjaGVua28NCg==


From xen-devel-bounces@lists.xenproject.org Wed Feb 09 16:42:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 09 Feb 2022 16:42:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269375.463439 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHq2v-00073A-G1; Wed, 09 Feb 2022 16:42:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269375.463439; Wed, 09 Feb 2022 16:42:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHq2v-000733-Cf; Wed, 09 Feb 2022 16:42:21 +0000
Received: by outflank-mailman (input) for mailman id 269375;
 Wed, 09 Feb 2022 16:42:21 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nHq2v-00072t-18; Wed, 09 Feb 2022 16:42:21 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nHq2u-0000sZ-Q4; Wed, 09 Feb 2022 16:42:20 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nHq2u-0007lG-AA; Wed, 09 Feb 2022 16:42:20 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nHq2u-0006Se-9f; Wed, 09 Feb 2022 16:42:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=wqnhPzPkgRcKyfj4ARTf5iufka3YFP36OzkFP91LuLg=; b=pqqmpt1HDO7TcaVKkP53gyIoU3
	c805zLLtiiqYq4hntOZtvPL8smxlf0JXfp4Ci4iJCEa7REIhLJC2HVR2FARVTv+lKd3XlL1SmMaFj
	GvUwaUiJEe826XOIynu8U79i4nw+qsr9eXKAdlyX6yogVtFMk7hrV7Yx548Sa3l5AeS4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168070-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 168070: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=da4c512b05ed94e41c91bd8ed6d45895cf97cf51
X-Osstest-Versions-That:
    xen=52ce1c97844db213de01c5300eaaa8cf101a285f
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 09 Feb 2022 16:42:20 +0000

flight 168070 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168070/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  da4c512b05ed94e41c91bd8ed6d45895cf97cf51
baseline version:
 xen                  52ce1c97844db213de01c5300eaaa8cf101a285f

Last test of basis   168065  2022-02-08 19:00:30 Z    0 days
Testing same since   168070  2022-02-09 12:05:58 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   52ce1c9784..da4c512b05  da4c512b05ed94e41c91bd8ed6d45895cf97cf51 -> smoke


From xen-devel-bounces@lists.xenproject.org Wed Feb 09 17:13:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 09 Feb 2022 17:13:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269388.463450 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHqXH-0001tN-2c; Wed, 09 Feb 2022 17:13:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269388.463450; Wed, 09 Feb 2022 17:13:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHqXG-0001tG-Us; Wed, 09 Feb 2022 17:13:42 +0000
Received: by outflank-mailman (input) for mailman id 269388;
 Wed, 09 Feb 2022 17:13:42 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=H3wK=SY=citrix.com=Jane.Malalane@srs-se1.protection.inumbo.net>)
 id 1nHqXF-0001tA-UO
 for xen-devel@lists.xenproject.org; Wed, 09 Feb 2022 17:13:42 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9f9d48a1-89cb-11ec-8f75-fffcc8bd4f1a;
 Wed, 09 Feb 2022 18:13:40 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9f9d48a1-89cb-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644426820;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=0sYTaWKFTYZC4KzZ6woE5VPngvVRj0Uj5X8Zm8fqvVs=;
  b=P3lfXsykPQ2f9ODVAOevf35LoyvSN6laSs574GuKg6/CQkzI09xe219v
   Y5hvrutVVybMWKgApSw7m9TQ+G8rQQSy49Y1x/TfP4CSawJGT/FBHMkxJ
   EyJYfcJchrd2Ert6+/DCi3ZskMTgztjtgO5P0YuF0tN8H5skw15+0xKaI
   U=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: 6FrHb4xFTDlZygUUy8I3k5Ww5sryw0wSKwBoK9yLdxgTqodww/8mSsuaECrcblWvSbh7WvLL4+
 PchM1obGrY5BFY9omhSXI78IRKBS1iOTbfnJE4wJEMFGxZq2LNrKJZBqMVneKp/D+lPGzvbgzd
 R1XkCGScPoYBAnDEvQsuy4DLXY0bGULu8FXt0p782KU+QRtcOG/wNsXpwogmLKsVWQl7RY9NR6
 0SUlKYoAcX9L5XWeGAXa87PtN7x3eTweYGDyOksMv3CRwxqPKu7P9sFj4458mssMFXG/QiZ1Ub
 a3XKIB/OBDXrUE9ODRhhloiq
X-SBRS: 5.1
X-MesageID: 64255030
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:4EdaCqxpUV4CkzCrE116t+fVwSrEfRIJ4+MujC+fZmUNrF6WrkUCz
 2dOXTyFPPmLZ2PyeNl1aNi18BlX75XXzd8yQAA4+CAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAhLeNYYH1500g7wbZo2tQAbeWRWGthh
 /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL
 wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt95Bw
 +9InqW0cgF3GJf+uu4fCEYHFAgraMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr
 6ZBbmlQMFbT3Ipaw5riIgVoruYqKsStGYobs3VpyzzxBvc6W5HTBa7N4Le02R9u2poTQK6FP
 6L1bxJoSCiQaTYUAm0cFY5mkcm2v0i4dhdh/Qf9Sa0fvDGIkV0ZPKLWGMrYfJmGSNtYmm6cp
 3na5CLpDxcCLtudxDGZtHW2iYfngifTSI8UUrqi+ZZCglee22gSAx0+TkagrL+yjUvWZj5EA
 xVKoGx09/F0rRH1CImmN/GlnJKalhAsUOBVONQ+0wfT7JDmwQybXTdbSRcUPbTKq/QKbTAt0
 1aImfbgCjpurKCZRBqhy1uEkd+hEXNLdDFfPEfoWSNAuoC++99r0nojW/4+SPbdszHjJd3nL
 9lmRgAajq5bs8ME3r7TEbvv02P1/cihouLYC2zqsoOZAuFROdfNi2+AswGzARN8wGCxFATpU
 J8swZf20Qz2JcvR/BFhuc1UdF1T296LMSfHnXlkFIQ7+jKm9haLJN4MvGoieRs4a5ZdJFcFh
 XM/XysLufe/21PwMsdKj3+ZUZx2ncAM6/y5PhwrUja+SscoL1LWlM2fTUWRw3rsgCARfVIXY
 v+mnTKXJS9CU8xPlWPuL89EiOND7n1ulAv7GMGgpzz6gOX2TCDOE98tbgDRBt3VGYvZ+W05B
 f4EbJDUo/ieOcWjChTqHXk7dwhVdCNmXsCv8KS6tIere2JbJY3oMNeIqZsJcI15haVF0ODO+
 3C2QEhDz1Tjw3bALG23hrpLMdsDhL5z8iA2OzICJ1Gt1yRxaIqj9v5HJZA2YaMm5KpoyvstF
 6sJfMCJA/JuTDXb+mtCMcmh/dI6LBn71xiTOyeFYSQke8IyTQL+5dK5LBDk8zMDD3TruJJm8
 aGgzA7SXbEKWx9mUJTNcPuqwl7o5Sodlet+UlHmON5WfEmwooFmJzao1q08It0WKAWFzTyfj
 l7EDRAdrOjLgok07NiW2vzU89b3S7NzRxMIEXPa4LC6MTjh0lCimYIQAvyVeT39VX/v/Pnwb
 +ti0PyhYuYMm0xHstQgHu8zn74+/dbmu5RT0h9gQCfQd12uB75tfiuG0M1IuvEfz7NVo1LrC
 EeG+90cMrSVIsL1VlUWIVN9POiE0PgVnBjU7Og0fxqmtHMmouLfXBUAJQSIhQxcMKBxYdEsz
 uoWscIL7xCy10gxOdGcgyEIr2mBIxTsiUn8Wk321GMztjcW9w==
IronPort-HdrOrdr: A9a23:1J39e67z3gqvv68nKAPXwWWBI+orL9Y04lQ7vn2ZFiY7TiXIra
 yTdaoguCMc0AxhJU3Jmbi7Scy9qeu1z+873WBjB8bfYOCAghrnEGgC1/qv/9SEIUPDH4FmpN
 5dmsRFeb7N5B1B/LzHCWqDYpcdKbu8gdiVbI7lph8HJ2ALV0gj1XYDNu/yKDwseOAsP+tcKH
 Po3Lsgm9PWQwVxUi3UPAhmY8Hz4/nw0L72ax8PABAqrCOUiymz1bL8Gx+Emj8DTjJm294ZgC
 j4uj28wp/mn+Cwyxfa2WOWxY9RgsHdxtxKA9HJotQJKw/rlh2jaO1aKv6/VXEO0aOSAWQR4Z
 3xSiQbToNOArTqDyeISC7WqkzdOfAVmibfIBGj8CPeSIfCNU0H4oJ69Pxkm13imhAdVZhHod
 N29nPcuJxNARzamiPho9DOShFxj0Kx5WEviOgJkhVkIMAjgZJq3MUiFXluYd899ePBmfUaOf
 grCNuZ6OddcFucYXyctm5zwMa0VnB2GhudWEANtsGczjATxRlCvgYl7d1amm1F+IM2SpFC6e
 iBOqN0lKtWRstTaa5mHu8OTca+F2SISxPRN2CZJ0jhCcg8Sjjwgo+y5K9w6PCheZQOwpd3kJ
 PdUElAvWp3YE7qAd3m5uw8zvkMehTLYd3A8LAs23FJgMyJeFOwC1zydLkHqbrTn8ki
X-IronPort-AV: E=Sophos;i="5.88,356,1635220800"; 
   d="scan'208";a="64255030"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=VpsAC2lFIzilvZgjzt4i4n05QsacgYPx2EX1yzBCr6Qi5ETKp/cwF5QRB+GKOTGvClAawHH7x8tmbJusTK804pLoxai48u0hQdneiCje+ZUi3HvQeEqXB+Knd821ZzNrjwOL+/4/lqFnlaU/nw4eLGqInBqWChOLSOLbQnuSlj6SNrW0d0T0rlvTDXmmkjj8e9BVZFxvmD1UgR78WRy/JzPKy3v0F9TwnWVTYNw+5KW3dgIBAr3XqFU98HZOvjEWjvxBiDmAJT4RBDgTA7M0LMYNVFHERCQfjSfykdwrndMmg+7kYev3pg9OHQ+z4Xqrpq4VwUck2tjins2QZcqhIg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=0sYTaWKFTYZC4KzZ6woE5VPngvVRj0Uj5X8Zm8fqvVs=;
 b=aldYNWFbiY+NpHDWWLwrFIFHUxDoIw0fO+s5NxAtyMYps+DplefCn/whkY0nxzJJhJ74u9NiaobfJtZB8lCbmGmkMKCMGDq7O2mYzQ2FiH9jqk1TOIytMHvVz04Ck8tZKNUVV7BmrZe1ffxDKEA7TozEbZA24eOk0GvtYJyQxX0EArNrdWrVnozww5e9xoW69LX6UwpyM+xPs711MTXUErCSxmzC3T0YnQs+XHB7UTq2hQmS9Vv0EY73aZuCGDT/e0swHXEUp+xeRKNF7WN69JEofUCCIv6VtaIGjTowtEY1T5rwj9BFfHIbB6L7gddCAi0N/s8DcYCurQIjfdIuRQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=0sYTaWKFTYZC4KzZ6woE5VPngvVRj0Uj5X8Zm8fqvVs=;
 b=SfyVzLSs5piWkzX39goAnEtOPVyxW1z6qSviGWRYmdh4L9/Ka+WIQOWhErGq5l0bGbxsgUUgsujPUhXggIG/9XiuuCUlUIzR1JjazqaXMAhpL616cwOiUMVFZnDJDZu+ooAvf4Wp37ZVygtieMxju1/wS37ibzIVxOsK597b4nw=
From: Jane Malalane <Jane.Malalane@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Andrew Cooper <Andrew.Cooper3@citrix.com>, Roger Pau Monne
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>, Xen-devel
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] x86/dom0: Add log for dom0_nodes and dom0_max_vcpus_max
 conflict
Thread-Topic: [PATCH] x86/dom0: Add log for dom0_nodes and dom0_max_vcpus_max
 conflict
Thread-Index: AQHYHaBVLLQoAjzhjUW/NIePQEslT6yLF5CAgABd44A=
Date: Wed, 9 Feb 2022 17:13:30 +0000
Message-ID: <8b4febfe-38dc-f156-5a06-0ea5f14edc50@citrix.com>
References: <20220209103153.11391-1-jane.malalane@citrix.com>
 <4c44dea8-920b-6169-0853-01e18e89db94@suse.com>
In-Reply-To: <4c44dea8-920b-6169-0853-01e18e89db94@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 975f290b-f28a-45be-52c6-08d9ebef7ec8
x-ms-traffictypediagnostic: DM6PR03MB5212:EE_
x-microsoft-antispam-prvs: <DM6PR03MB521271D87E9068B9F1FA673F812E9@DM6PR03MB5212.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 8fvGeL0Iy4KlBjU5ERP7Fwm7xrdXs7GB0goitlFPGAqlGy+UbJo66PFMUh93bSUjRViS5zWZwHTsZgOe7p7iYotxGFwfwPtfAAcuxAeFJODGIhnRSEViShCcFWf4tW/4jqQo1w3BCRPnojptUuGJ8dACa7RVuqnXkUa4omZNJG85TfiyeiYfAoxTOKhfc+e2ILZmJqcwMWpn1yOxEuatTmSce+i0Pr/QMiz5LMNc/56X+4L8U1B+Zaa9HXpS7qYsRIjHvP/ayL81X9n/SpKHSGoegXZmF541KBkrhDaPioHP/9HQ54FAlrEZqoV7BVRdPLu+YwRBdPpzkCTXzDPRWuXwvyDWAFKnm2pucWZdhFbXyLmlkBcm/Rb7XLjwTyZe2Xp1xd2QxhCl6mi1lQkP6FIYWTnkwXi7u899VYonryoSWPkR40l5qefofqdSUQZlUQ2MAR5xyt/OEFCij+NDsQ/wt/65xdTsK8nYSObQ5EIpEPUs9stPnEq07PLqOQjxASMVTMF49k8GlLTrTDPezSZXLTHkmk4S/5AqXZiItbjnA7QyTFXK5IORkXYwuj9Mr2ADYbcCgaGJAXUwi1W73pdykBjLUnqYUfnkKff8vts+4SG7FNOBos0jfixhlRy33MpIVBA+JefBqax9OeWIzUfq6ZkxrjbcpGexSJPppv3EFI7dbxbc/Kv3g9T+uyx/yT564QgeJ1mXp9D8tF8z+lYcI6LUzinKLwn/TYaAe7APVGTQ3Dv/LZj/LrD7nlf/
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR03MB3386.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(36756003)(54906003)(53546011)(6512007)(6506007)(26005)(83380400001)(2616005)(186003)(122000001)(71200400001)(6916009)(316002)(4326008)(8676002)(8936002)(5660300002)(91956017)(66946007)(76116006)(66446008)(66476007)(66556008)(2906002)(508600001)(64756008)(82960400001)(6486002)(38100700002)(31686004)(86362001)(38070700005)(31696002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?bXlodWxuUlJOMGFieTNFMjBrdWNNd0JuRVFaUGhjTnFCWmNJN3dyZ2xSbzI3?=
 =?utf-8?B?UFozTENCa2VPUU5MWXdRbU5HdEI5Smo4VXY4SlF5cmRLamd4SlZNM1VYNnFN?=
 =?utf-8?B?Wlc1Sjg0bVVQTFlzU1U1OG1hOEJDUWZQYlcvanRXZzQzalVCWkdPRzI5amJQ?=
 =?utf-8?B?bnVwNHVvNkVSNlpWMStuY0dFWklBTC8wMnN0V1hIQ2JOcklabUxiSzdoMzZU?=
 =?utf-8?B?MUFSRXA5YU52aXcydlpsU2Ntdm9lbmdZOU1XcUczYVZqRnByT2hwb2luMnJl?=
 =?utf-8?B?Z1VaTjhRSi9rSUNkaFFiREFoWXEvWVNmdnR0bGNjVjVOajQ4bEdrLzVYQVc1?=
 =?utf-8?B?R09PaUlzMWVzMkN1aW95RDBjU3g5N2dxTGtNMHdpZmxJOHJlbk1uYS9LeWl5?=
 =?utf-8?B?ZE1nUVJTYkZoYU5GSjBMMGZKNXpKcEt5bDZ1R1o5WFhyOG53REtJU3ZrUmY1?=
 =?utf-8?B?aUIrN2lBRzhScXlFYVFubTB4UWJiZXN0UHI2ZFhzZW1mU3AzQ3pKeGVSOGlL?=
 =?utf-8?B?cW9pYmdYYitja0ljSVdNWVdJcEpCMEpPTWJ0cFFqd2lKQ0lrT0ZENHRmM2dN?=
 =?utf-8?B?NzhGOHV3ZXRPRThDK2pZWkhaaEY3Q2dkeEVJbmdjK21xOWNwajgwSExHYUpw?=
 =?utf-8?B?NVZTRGhnU2ZjS1dtNWVCT0FzZ2FhQzN4ZEJDOXdCUXhEVzAza0ZTaDVQZmJC?=
 =?utf-8?B?SmNYeGsrMkVoR0prUkNsV2FvY0hpSjdVVjNrU0YyZUo4dEZRRDlKaC9sTWtY?=
 =?utf-8?B?Sml0cU9iZTU1NFk4QmZ1SFpjWUxGeG1ENmQxK0xEVlBtVEdLZm9HaXVRNytZ?=
 =?utf-8?B?dVJHdi9KRER0d0Y4aHFSVzMzbFpKQnVRZzBhV2xuVm1Bb244S1ArVXJJM3p3?=
 =?utf-8?B?NzBIM0FwaVZVSFJ4enV4R2J4aVdoT2MrVkFVMFg1NkZqang1blhwdTkrY0U4?=
 =?utf-8?B?ajNza0JZdnhtQU5UR2pJYVNCY241R3pVTlFIWEI0WE4wMkxndHVmSjE2N0ly?=
 =?utf-8?B?RjRrdUtlVlV5Z04rN2Z2Nk5MMXhWTkNROU9Sdml1OVg5Q3A5WVUydE1Sb05s?=
 =?utf-8?B?UWhZdjJWMk8yajIrQ2U2UGx6YVQ3b2ZmUnRmMTZBeDhLMWVJTytrNGxUUVVa?=
 =?utf-8?B?ZWl1V1E2QWN4VitxS0s2aVBhdW1YZUtXMk91bUM3ZjUwY0tIbnlsbU52MHBP?=
 =?utf-8?B?ZmtCQ0VPUEU1OTNpa0pFMDlTeHZMeThjeUw2TCtOb1lMZ0RGaTIvOE9qWHEy?=
 =?utf-8?B?VWNhYlE4VDZEalM1QmNJR3E4Ri81YSs5VUhISXVJUzFmVXBaamlZT2ZZeHZq?=
 =?utf-8?B?YTlVeEloazNUMDVKOGVVSEg3QWhtdkY4cVJPT2JzcEVqMmxiNXNOSTJlb3Fi?=
 =?utf-8?B?SElQRXpwdENZemUyS05CdThyYmtFakNQVlhZUEhmb1BLZTFMU29mN29NVnNO?=
 =?utf-8?B?SlpuL0w0MkdCODNRYlR3cElIcFFpSURZMTVNT2sxdzkrNVNuQUliSHB4L3JF?=
 =?utf-8?B?aWRWL1RpdElWQlBTcTkxV0dHWjduZWF1N2RVbmtkeVBUQmFYd3AxTXd4OUNE?=
 =?utf-8?B?MWpYWW1rN1BHczQ4dVZlUHMwckxJVVU3UTAvU2xlY1QzS1VZSVpsNGxMbTdy?=
 =?utf-8?B?WVp5MnFUWlI0K3JucVZtZEZ4ckN2d0ptWWQ4ODcyUVgrNlNzY0g0U3RFSVBw?=
 =?utf-8?B?aUZvRmg5TXdyWDJRa1BseVFlNVlzWlZ3WlRjQm5HR0JEWWdJMHRsdENHcGI2?=
 =?utf-8?B?dkRHS010K0tqcU5uY3FsSEdBU1dROHhhMGlIZFlDS0FGNWp4QlZmalIzZm1J?=
 =?utf-8?B?dGtwRmkzd01veVhaZFBnb2Q4NkdSc2F6USt2WVVzZXp1K3M1Vm5KV2h2Sk4y?=
 =?utf-8?B?UTREdkFEdDg2NVprdzk3YmRaZUYwNDFZbVhOTnVBZFFPUVdGQVJNdFB3QVB2?=
 =?utf-8?B?d2pMdTNEUVZTQmd3cWIvOCtjU1Z5N2ttWjJqQ0Z5VDU3bjhCQ3dtcnlQbGFl?=
 =?utf-8?B?aE9iNzJFZVdGQU9Za3RwMU1ZNlhQSEJYUDl1cjcvRSsvaEJRb0FQUTYxOVNW?=
 =?utf-8?B?TXo3V00zdHFNdzhCb0tnYmxCaDRuRS9KOWpiY081eFg2MFZkSStKWm9uVzBk?=
 =?utf-8?B?MmpmN1ROVzAvVjB2UlowVmE4ZWNsQUVXUUMzWmhsTGpSYy9VUFB3M1NlWWR1?=
 =?utf-8?B?aHBMck94QkxXZHJ2S1RobFVBY2d4eG9DcW5RYVFBWVZIOGdsMkdaWTNycEVL?=
 =?utf-8?Q?fxZOi24rtNzvLjJSUKZDGLtEiMQIvzqsTRrJhO7cvI=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <1822837138CD334EA18BDA3793A1EF97@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM5PR03MB3386.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 975f290b-f28a-45be-52c6-08d9ebef7ec8
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Feb 2022 17:13:30.5310
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 3vJ4S4m8bOk8VuNgknBdSYS3d9RbxSfTiNQgg7OH9fUVEqi0nMalBJiNG4k3EAV8BBbKGtSznrBiWDRM2LDw3mNg05ZDpNPr4Dm8qgYg30E=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5212
X-OriginatorOrg: citrix.com

T24gMDkvMDIvMjAyMiAxMTozNywgSmFuIEJldWxpY2ggd3JvdGU6DQo+IFtDQVVUSU9OIC0gRVhU
RVJOQUwgRU1BSUxdIERPIE5PVCByZXBseSwgY2xpY2sgbGlua3MsIG9yIG9wZW4gYXR0YWNobWVu
dHMgdW5sZXNzIHlvdSBoYXZlIHZlcmlmaWVkIHRoZSBzZW5kZXIgYW5kIGtub3cgdGhlIGNvbnRl
bnQgaXMgc2FmZS4NCj4gDQo+IE9uIDA5LjAyLjIwMjIgMTE6MzEsIEphbmUgTWFsYWxhbmUgd3Jv
dGU6DQo+PiBUaGlzIGlzIG5vdCBhIGJ1Zy4gVGhlIHhlbiBjbWRsaW5lIGNhbiByZXF1ZXN0IGJv
dGggYSBOVU1BIHJlc3RyaWN0aW9uDQo+PiBhbmQgYSB2Y3B1IGNvdW50IHJlc3RyaWN0aW9uIGZv
ciBEb20wLiBUaGUgbm9kZSByZXN0cmljdGlvbiB3aWwgYWx3YXlzDQo+PiBiZSByZXNwZWN0ZWQg
d2hpY2ggbWlnaHQgbWVhbiBlaXRoZXIgdXNpbmcgZG9tMF9tYXhfdmNwdXMgPA0KPj4gb3B0X2Rv
bTBfbWF4X3ZjcHVzX21heA0KPiANCj4gVGhpcyBpcyBxdWl0ZSBub3JtYWwgYSBjYXNlIGlmIGEg
cmFuZ2Ugd2FzIHNwZWNpZmllZCwgb3IgZGlkIHlvdSBtZWFuDQo+IG9wdF9kb20wX21heF92Y3B1
c19taW4/IEJ1dCBtaW4gYW5kIG1heCBnZXQgYXBwbGllZCBsYXN0IGFueXdheSwgc28NCj4gdGhv
c2UgYWx3YXlzIG92ZXJyaWRlIHdoYXQgd2FzIGRlcml2ZWQgZnJvbSBkb20wX25yX3B4bXMuDQpZ
ZXMsIEkgd2FzIGp1c3QgZ2l2aW5nIGNvbnRleHQgaGVyZSBmb3Igd2hhdCBJIHNheSBpbiB0aGUg
Zm9sbG93aW5nIA0Kc2VudGVuY2UuIE1heWJlIHRoaXMgYmVjYW1lIG1vcmUgY29uZnVzaW5nIHRo
YW4gaGVscGZ1bC4NCj4gDQo+PiBvciB1c2luZyBtb3JlIHZDUFVzIHRoYW4gcENQVXMgb24gYSBu
b2RlLiBJbg0KPj4gdGhlIGNhc2Ugd2hlcmUgZG9tMF9tYXhfdmNwdXMgZ2V0cyBjYXBwZWQgYXQg
dGhlIG1heGltdW0gbnVtYmVyIG9mDQo+PiBwQ1BVcyBmb3IgdGhlIG51bWJlciBvZiBub2RlcyBj
aG9zZW4sIGl0IGNhbiBiZSB1c2VmdWwgcGFydGljdWxhcmx5DQo+PiBmb3IgZGVidWdnaW5nIHRv
IHByaW50IGEgbWVzc2FnZSBpbiB0aGUgc2VyaWFsIGxvZy4NCj4gPiBUaGUgbnVtYmVyIG9mIHZD
UFUtcyBEb20wIGdldHMgaXMgbG9nZ2VkIGluIGFsbCBjYXNlcy4gQW5kIHRoZQ0KPiByZWFzb25z
IHdoeSBhIGNlcnRhaW4gdmFsdWUgaXMgdXNlcyBkZXBlbmRzIG9uIG1vcmUgdGhhbiBqdXN0DQo+
IHRoZSBudW1iZXItb2Ytbm9kZXMgcmVzdHJpY3Rpb24uIA0KTWF5YmUgSSBzaG91bGQgaGF2ZSBz
YWlkICdEb20wICJyZWNlaXZpbmciICVkIHZDUFVTJyBpbnN0ZWFkIG9mICJ1c2luZyIgDQppbiB0
aGUgc2VyaWFsIGxvZywgaW4gd2hpY2ggY2FzZSBJIGNhbiBhbWVuZCB0aGF0IHRvIG1ha2UgaXQg
Y2xlYXJlciANCih0aGF0IG9mYyBpZiB3ZSBzdGlsbCB3YW50IHRoaXMgY2hhbmdlKT8NCkkgdGhl
cmVmb3Igd29uZGVyIHdoZXRoZXIgdGhlDQo+IHdvcmRpbmcgYXMgeW91J3ZlIGNob3NlbiBpdCBp
cyBwb3RlbnRpYWxseSBtaXNsZWFkaW5nLCBhbmQNCj4gcHJvcGVybHkgZXhwcmVzc2luZyBldmVy
eXRoaW5nIGluIGEgc2luZ2xlIG1lc3NhZ2UgaXMgZ29pbmcgdG8NCj4gYmUgcXVpdGUgYSBiaXQg
dG9vIG5vaXN5LiBGdXJ0aGVybW9yZSAuLi4NCj4gDQo+PiAtLS0gYS94ZW4vYXJjaC94ODYvZG9t
MF9idWlsZC5jDQo+PiArKysgYi94ZW4vYXJjaC94ODYvZG9tMF9idWlsZC5jDQo+PiBAQCAtMjQw
LDYgKzI0MCwxMSBAQCB1bnNpZ25lZCBpbnQgX19pbml0IGRvbTBfbWF4X3ZjcHVzKHZvaWQpDQo+
PiAgICAgICBpZiAoIG1heF92Y3B1cyA+IGxpbWl0ICkNCj4+ICAgICAgICAgICBtYXhfdmNwdXMg
PSBsaW1pdDsNCj4+ICAgDQo+PiArICAgIGlmICggbWF4X3ZjcHVzIDwgb3B0X2RvbTBfbWF4X3Zj
cHVzX21heCAmJiBtYXhfdmNwdXMgPiBvcHRfZG9tMF9tYXhfdmNwdXNfbWluICkNCj4+ICsgICAg
ICAgIHByaW50ayhYRU5MT0dfSU5GTyAiRG9tMCB1c2luZyAlZCB2Q1BVcyBjb25mbGljdHMgd2l0
aCByZXF1ZXN0IHRvIHVzZSINCj4+ICsgICAgICAgICAgICAgICAiICVkIG5vZGUocyksIHVzaW5n
IHVwIHRvICVkIHZDUFVzXG4iLCBvcHRfZG9tMF9tYXhfdmNwdXNfbWF4LA0KPj4gKyAgICAgICAg
ICAgICAgIGRvbTBfbnJfcHhtcywgbWF4X3ZjcHVzKTsNCj4gDQo+IC4uLiB0aGUgZnVuY3Rpb24g
Y2FuIGJlIGNhbGxlZCBtb3JlIHRoYW4gb25jZSwgd2hlcmVhcyBzdWNoIGENCj4gbWVzc2FnZSAo
aWYgd2UgcmVhbGx5IHdhbnQgaXQpIHdvdWxkIGJldHRlciBiZSBpc3N1ZWQganVzdCBvbmNlLg0K
WWVzLCB0aGF0IGlzIHRydWUgYW5kIHRoaXMgY29kZSB3b3VsZCBoYXZlIHRvIGxpdmUgb3V0c2lk
ZSBvZiBkb20wX2J1aWxkLmMuDQo+IA0KPiBUbyBhbnN3ZXIgeW91ciBsYXRlciByZXBseSB0byB5
b3Vyc2VsZjogSSB0aGluayBwcmludGsoKSBpcyBmaW5lDQo+IGhlcmUgKGFnYWluIGFzc3VtaW5n
IHdlIHdhbnQgc3VjaCBhIG1lc3NhZ2UgaW4gdGhlIGZpcnN0IHBsYWNlKTsNCj4gaXQncyBhIGJv
b3QtdGltZS1vbmx5IG1lc3NhZ2UgYWZ0ZXIgYWxsLg0KPiANCk9rYXkuDQoNClRoYW5rIHlvdSwN
Cg0KSmFuZS4=


From xen-devel-bounces@lists.xenproject.org Wed Feb 09 17:38:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 09 Feb 2022 17:38:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269405.463489 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHqvV-0004hA-HO; Wed, 09 Feb 2022 17:38:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269405.463489; Wed, 09 Feb 2022 17:38:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHqvV-0004h3-Dg; Wed, 09 Feb 2022 17:38:45 +0000
Received: by outflank-mailman (input) for mailman id 269405;
 Wed, 09 Feb 2022 17:38:43 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nHqvT-0004gt-Lq; Wed, 09 Feb 2022 17:38:43 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nHqvT-0001xT-JB; Wed, 09 Feb 2022 17:38:43 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nHqvT-0002Ci-4B; Wed, 09 Feb 2022 17:38:43 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nHqvT-00049z-3f; Wed, 09 Feb 2022 17:38:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=uUgY2D9VqkHSLw7fY2MctKBNcfBUHTDTLae2oST6sKY=; b=YEBrGVTQeQ8It5zGi4aRB1y4NT
	r6hFBZUV+rQ5HqNsy7b1qkYsqG7ZcGRoKJy3cLqH9XQGP72d1qtC8b7bZ02wSbXqdvor+zn9LDgea
	EgbRRCnK8E/1UTbvemgutPhfPgFpGlIRFLghKPOs5YX0w9tnwOA7yks/n9X/nL4iNkS0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168062-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.15-testing test] 168062: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-4.15-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=1ec097c35c4f402d7a3fbb05c2b9797afdc3f59c
X-Osstest-Versions-That:
    xen=7f3b726c6a73ed82d6825f52763bf8943aea5316
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 09 Feb 2022 17:38:43 +0000

flight 168062 xen-4.15-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168062/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168014
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168014
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168014
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168014
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168014
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168014
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168014
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168014
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168014
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168014
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168014
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168014
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  1ec097c35c4f402d7a3fbb05c2b9797afdc3f59c
baseline version:
 xen                  7f3b726c6a73ed82d6825f52763bf8943aea5316

Last test of basis   168014  2022-02-04 17:06:37 Z    5 days
Testing same since   168062  2022-02-08 18:37:46 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Jan Beulich <jbeulich@suse.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   7f3b726c6a..1ec097c35c  1ec097c35c4f402d7a3fbb05c2b9797afdc3f59c -> stable-4.15


From xen-devel-bounces@lists.xenproject.org Wed Feb 09 18:38:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 09 Feb 2022 18:38:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269417.463499 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHrqc-0002Dx-Os; Wed, 09 Feb 2022 18:37:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269417.463499; Wed, 09 Feb 2022 18:37:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHrqc-0002Dq-Lu; Wed, 09 Feb 2022 18:37:46 +0000
Received: by outflank-mailman (input) for mailman id 269417;
 Wed, 09 Feb 2022 18:37:44 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=mP6M=SY=kernel.org=sashal@srs-se1.protection.inumbo.net>)
 id 1nHrqa-0002Dk-GZ
 for xen-devel@lists.xenproject.org; Wed, 09 Feb 2022 18:37:44 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org
 [2604:1380:4641:c500::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5d4246bd-89d7-11ec-8f75-fffcc8bd4f1a;
 Wed, 09 Feb 2022 19:37:42 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 2FC4E61C5E;
 Wed,  9 Feb 2022 18:37:41 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id C12E8C340E7;
 Wed,  9 Feb 2022 18:37:39 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5d4246bd-89d7-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1644431861;
	bh=fFDyHU/EXMCfwe3bvn0ogCYcjkIKtHPdA+SKnAQmZxs=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=PG46NJNizB03j1SVHFfd32IGvlmhYYe9htV4wzVbBvZRV2oy7uILhBGQRJVHlWGMT
	 ETb37TcaqhYm1PFm+p/I0L6k/UNCqqznRQgi8AIFMe2HmMvL5IWvi61uHnRB38rHwD
	 vAkVOh2sIMsAxwA57fKNsUwcd/aviK4LkHaL/T8+0ZUEi4elrU3JL+42vkeiRS1as5
	 /guSYWltp4Zr3Yeb0mJQgP8EwUOhrLBhcPEwAfK6xU4t+F3FMCoV1aZzFmeIMp3uq/
	 6nBlhtWcKZg1pydECUvOfGMNAvveMEY7cY5TsIhvqNLW8SFCJ3RzDyZCdRkUbMb7Ce
	 a7oht9H+ya71A==
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Cc: Jan Beulich <jbeulich@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Sasha Levin <sashal@kernel.org>,
	tglx@linutronix.de,
	mingo@redhat.com,
	bp@alien8.de,
	dave.hansen@linux.intel.com,
	x86@kernel.org,
	xen-devel@lists.xenproject.org
Subject: [PATCH AUTOSEL 5.16 39/42] x86/Xen: streamline (and fix) PV CPU enumeration
Date: Wed,  9 Feb 2022 13:33:11 -0500
Message-Id: <20220209183335.46545-39-sashal@kernel.org>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220209183335.46545-1-sashal@kernel.org>
References: <20220209183335.46545-1-sashal@kernel.org>
MIME-Version: 1.0
X-stable: review
X-Patchwork-Hint: Ignore
Content-Transfer-Encoding: 8bit

From: Jan Beulich <jbeulich@suse.com>

[ Upstream commit e25a8d959992f61b64a58fc62fb7951dc6f31d1f ]

This started out with me noticing that "dom0_max_vcpus=<N>" with <N>
larger than the number of physical CPUs reported through ACPI tables
would not bring up the "excess" vCPU-s. Addressing this is the primary
purpose of the change; CPU maps handling is being tidied only as far as
is necessary for the change here (with the effect of also avoiding the
setting up of too much per-CPU infrastructure, i.e. for CPUs which can
never come online).

Noticing that xen_fill_possible_map() is called way too early, whereas
xen_filter_cpu_maps() is called too late (after per-CPU areas were
already set up), and further observing that each of the functions serves
only one of Dom0 or DomU, it looked like it was better to simplify this.
Use the .get_smp_config hook instead, uniformly for Dom0 and DomU.
xen_fill_possible_map() can be dropped altogether, while
xen_filter_cpu_maps() is re-purposed but not otherwise changed.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Link: https://lore.kernel.org/r/2dbd5f0a-9859-ca2d-085e-a02f7166c610@suse.com
Signed-off-by: Juergen Gross <jgross@suse.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 arch/x86/xen/enlighten_pv.c |  4 ----
 arch/x86/xen/smp_pv.c       | 26 ++++++--------------------
 2 files changed, 6 insertions(+), 24 deletions(-)

diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c
index 5004feb16783d..d47c3d176ae4b 100644
--- a/arch/x86/xen/enlighten_pv.c
+++ b/arch/x86/xen/enlighten_pv.c
@@ -1341,10 +1341,6 @@ asmlinkage __visible void __init xen_start_kernel(void)
 
 		xen_acpi_sleep_register();
 
-		/* Avoid searching for BIOS MP tables */
-		x86_init.mpparse.find_smp_config = x86_init_noop;
-		x86_init.mpparse.get_smp_config = x86_init_uint_noop;
-
 		xen_boot_params_init_edd();
 
 #ifdef CONFIG_ACPI
diff --git a/arch/x86/xen/smp_pv.c b/arch/x86/xen/smp_pv.c
index 6a8f3b53ab834..4a6019238ee7d 100644
--- a/arch/x86/xen/smp_pv.c
+++ b/arch/x86/xen/smp_pv.c
@@ -148,28 +148,12 @@ int xen_smp_intr_init_pv(unsigned int cpu)
 	return rc;
 }
 
-static void __init xen_fill_possible_map(void)
-{
-	int i, rc;
-
-	if (xen_initial_domain())
-		return;
-
-	for (i = 0; i < nr_cpu_ids; i++) {
-		rc = HYPERVISOR_vcpu_op(VCPUOP_is_up, i, NULL);
-		if (rc >= 0) {
-			num_processors++;
-			set_cpu_possible(i, true);
-		}
-	}
-}
-
-static void __init xen_filter_cpu_maps(void)
+static void __init _get_smp_config(unsigned int early)
 {
 	int i, rc;
 	unsigned int subtract = 0;
 
-	if (!xen_initial_domain())
+	if (early)
 		return;
 
 	num_processors = 0;
@@ -210,7 +194,6 @@ static void __init xen_pv_smp_prepare_boot_cpu(void)
 		 * sure the old memory can be recycled. */
 		make_lowmem_page_readwrite(xen_initial_gdt);
 
-	xen_filter_cpu_maps();
 	xen_setup_vcpu_info_placement();
 
 	/*
@@ -476,5 +459,8 @@ static const struct smp_ops xen_smp_ops __initconst = {
 void __init xen_smp_init(void)
 {
 	smp_ops = xen_smp_ops;
-	xen_fill_possible_map();
+
+	/* Avoid searching for BIOS MP tables */
+	x86_init.mpparse.find_smp_config = x86_init_noop;
+	x86_init.mpparse.get_smp_config = _get_smp_config;
 }
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Wed Feb 09 18:40:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 09 Feb 2022 18:40:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269424.463511 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHrtX-0003Z5-7h; Wed, 09 Feb 2022 18:40:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269424.463511; Wed, 09 Feb 2022 18:40:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHrtX-0003Yy-43; Wed, 09 Feb 2022 18:40:47 +0000
Received: by outflank-mailman (input) for mailman id 269424;
 Wed, 09 Feb 2022 18:40:46 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=mP6M=SY=kernel.org=sashal@srs-se1.protection.inumbo.net>)
 id 1nHrtW-0003Ys-3r
 for xen-devel@lists.xenproject.org; Wed, 09 Feb 2022 18:40:46 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c9cf3c8a-89d7-11ec-8eb8-a37418f5ba1a;
 Wed, 09 Feb 2022 19:40:44 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 876F660AD9;
 Wed,  9 Feb 2022 18:40:43 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1E7FCC36AE3;
 Wed,  9 Feb 2022 18:40:42 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c9cf3c8a-89d7-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1644432043;
	bh=bVSySelnyAeahJMSw/l2RKJiTmriqOVNBjS17DZ/XGc=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=Uqb5F9T5/+Mdnmya0HZdE0DTuPPReuGGKa6ateqjZpQ6NTmCVtlBdJ/+BqAUNq6cJ
	 6cZq/A9xn9POOo+CtOfgxn3wwJasBqxepc/OqQInVFceBTpLZOypYx93KpJC21uKMt
	 Q7M+DBPX61VXS+aSIGSlXZuK0wLb1TRBPgSkz8C11S6YyR16cLLSU/dB88PW54xs9k
	 UsLYPMoMR+wjHIohsTdLdAMDtXKwStUvGFT8+UcN2XPDiCJWybipFZ+3QiHMKNb73U
	 ICswZiknQ5ryNNZeuXGIwf4Wvk8VWL4ac+F1W9oWR0m/2JSCgM36HA8VqLMBg9ctMh
	 WzhpfdDepJiPw==
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Cc: Jan Beulich <jbeulich@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Sasha Levin <sashal@kernel.org>,
	tglx@linutronix.de,
	mingo@redhat.com,
	bp@alien8.de,
	dave.hansen@linux.intel.com,
	x86@kernel.org,
	xen-devel@lists.xenproject.org
Subject: [PATCH AUTOSEL 5.15 33/36] x86/Xen: streamline (and fix) PV CPU enumeration
Date: Wed,  9 Feb 2022 13:37:56 -0500
Message-Id: <20220209183759.47134-33-sashal@kernel.org>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220209183759.47134-1-sashal@kernel.org>
References: <20220209183759.47134-1-sashal@kernel.org>
MIME-Version: 1.0
X-stable: review
X-Patchwork-Hint: Ignore
Content-Transfer-Encoding: 8bit

From: Jan Beulich <jbeulich@suse.com>

[ Upstream commit e25a8d959992f61b64a58fc62fb7951dc6f31d1f ]

This started out with me noticing that "dom0_max_vcpus=<N>" with <N>
larger than the number of physical CPUs reported through ACPI tables
would not bring up the "excess" vCPU-s. Addressing this is the primary
purpose of the change; CPU maps handling is being tidied only as far as
is necessary for the change here (with the effect of also avoiding the
setting up of too much per-CPU infrastructure, i.e. for CPUs which can
never come online).

Noticing that xen_fill_possible_map() is called way too early, whereas
xen_filter_cpu_maps() is called too late (after per-CPU areas were
already set up), and further observing that each of the functions serves
only one of Dom0 or DomU, it looked like it was better to simplify this.
Use the .get_smp_config hook instead, uniformly for Dom0 and DomU.
xen_fill_possible_map() can be dropped altogether, while
xen_filter_cpu_maps() is re-purposed but not otherwise changed.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Link: https://lore.kernel.org/r/2dbd5f0a-9859-ca2d-085e-a02f7166c610@suse.com
Signed-off-by: Juergen Gross <jgross@suse.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 arch/x86/xen/enlighten_pv.c |  4 ----
 arch/x86/xen/smp_pv.c       | 26 ++++++--------------------
 2 files changed, 6 insertions(+), 24 deletions(-)

diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c
index a7b7d674f5005..133ef31639df1 100644
--- a/arch/x86/xen/enlighten_pv.c
+++ b/arch/x86/xen/enlighten_pv.c
@@ -1364,10 +1364,6 @@ asmlinkage __visible void __init xen_start_kernel(void)
 
 		xen_acpi_sleep_register();
 
-		/* Avoid searching for BIOS MP tables */
-		x86_init.mpparse.find_smp_config = x86_init_noop;
-		x86_init.mpparse.get_smp_config = x86_init_uint_noop;
-
 		xen_boot_params_init_edd();
 
 #ifdef CONFIG_ACPI
diff --git a/arch/x86/xen/smp_pv.c b/arch/x86/xen/smp_pv.c
index 7ed56c6075b0c..477c484eb202c 100644
--- a/arch/x86/xen/smp_pv.c
+++ b/arch/x86/xen/smp_pv.c
@@ -148,28 +148,12 @@ int xen_smp_intr_init_pv(unsigned int cpu)
 	return rc;
 }
 
-static void __init xen_fill_possible_map(void)
-{
-	int i, rc;
-
-	if (xen_initial_domain())
-		return;
-
-	for (i = 0; i < nr_cpu_ids; i++) {
-		rc = HYPERVISOR_vcpu_op(VCPUOP_is_up, i, NULL);
-		if (rc >= 0) {
-			num_processors++;
-			set_cpu_possible(i, true);
-		}
-	}
-}
-
-static void __init xen_filter_cpu_maps(void)
+static void __init _get_smp_config(unsigned int early)
 {
 	int i, rc;
 	unsigned int subtract = 0;
 
-	if (!xen_initial_domain())
+	if (early)
 		return;
 
 	num_processors = 0;
@@ -210,7 +194,6 @@ static void __init xen_pv_smp_prepare_boot_cpu(void)
 		 * sure the old memory can be recycled. */
 		make_lowmem_page_readwrite(xen_initial_gdt);
 
-	xen_filter_cpu_maps();
 	xen_setup_vcpu_info_placement();
 
 	/*
@@ -486,5 +469,8 @@ static const struct smp_ops xen_smp_ops __initconst = {
 void __init xen_smp_init(void)
 {
 	smp_ops = xen_smp_ops;
-	xen_fill_possible_map();
+
+	/* Avoid searching for BIOS MP tables */
+	x86_init.mpparse.find_smp_config = x86_init_noop;
+	x86_init.mpparse.get_smp_config = _get_smp_config;
 }
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Wed Feb 09 18:42:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 09 Feb 2022 18:42:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269434.463522 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHrvY-0004FV-OL; Wed, 09 Feb 2022 18:42:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269434.463522; Wed, 09 Feb 2022 18:42:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHrvY-0004FO-LD; Wed, 09 Feb 2022 18:42:52 +0000
Received: by outflank-mailman (input) for mailman id 269434;
 Wed, 09 Feb 2022 18:42:51 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=mP6M=SY=kernel.org=sashal@srs-se1.protection.inumbo.net>)
 id 1nHrvX-0004FI-8B
 for xen-devel@lists.xenproject.org; Wed, 09 Feb 2022 18:42:51 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 145a0da3-89d8-11ec-8eb8-a37418f5ba1a;
 Wed, 09 Feb 2022 19:42:50 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 84A9960AF2;
 Wed,  9 Feb 2022 18:42:48 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id AF6FAC340E9;
 Wed,  9 Feb 2022 18:42:46 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 145a0da3-89d8-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1644432167;
	bh=Y8q/J0Iry0Dpi9EHXI2yalvcbthB960zMJ7G+0SH+Rw=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=tdeNjUE2TUiCpsgUfWk/D0BVQEPxdQKE89FUdKdPXy+TVGn2RoRYSpZvp4Uf7GR+e
	 aFW8WhJdmAlUUhn8tIrjMJaQM42fBdsb8k9a49vEhXxBlOOzJEX87fw7gnUtOdvy7V
	 8oNzE+gANByflZ5s5BL5Z916VBWGj3Tj1G6UL9jPRMQT7OkIXnJHujhxfEUwmZ7D1m
	 9NsEiL1SEWlGORijICWXAAEqYL+S1uFKfz+TFmmtYu6M0CYntVT+2HPk8el2Nexw6u
	 U8PGhoRbaPzqqZ2xQLgm2gRvnkJCUsxQjZCFLip10gyeQ+okkACE0L5JPmTyvLReDa
	 wucamD467uj2w==
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Cc: Jan Beulich <jbeulich@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Sasha Levin <sashal@kernel.org>,
	tglx@linutronix.de,
	mingo@redhat.com,
	bp@alien8.de,
	dave.hansen@linux.intel.com,
	x86@kernel.org,
	xen-devel@lists.xenproject.org
Subject: [PATCH AUTOSEL 5.10 24/27] x86/Xen: streamline (and fix) PV CPU enumeration
Date: Wed,  9 Feb 2022 13:41:00 -0500
Message-Id: <20220209184103.47635-24-sashal@kernel.org>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220209184103.47635-1-sashal@kernel.org>
References: <20220209184103.47635-1-sashal@kernel.org>
MIME-Version: 1.0
X-stable: review
X-Patchwork-Hint: Ignore
Content-Transfer-Encoding: 8bit

From: Jan Beulich <jbeulich@suse.com>

[ Upstream commit e25a8d959992f61b64a58fc62fb7951dc6f31d1f ]

This started out with me noticing that "dom0_max_vcpus=<N>" with <N>
larger than the number of physical CPUs reported through ACPI tables
would not bring up the "excess" vCPU-s. Addressing this is the primary
purpose of the change; CPU maps handling is being tidied only as far as
is necessary for the change here (with the effect of also avoiding the
setting up of too much per-CPU infrastructure, i.e. for CPUs which can
never come online).

Noticing that xen_fill_possible_map() is called way too early, whereas
xen_filter_cpu_maps() is called too late (after per-CPU areas were
already set up), and further observing that each of the functions serves
only one of Dom0 or DomU, it looked like it was better to simplify this.
Use the .get_smp_config hook instead, uniformly for Dom0 and DomU.
xen_fill_possible_map() can be dropped altogether, while
xen_filter_cpu_maps() is re-purposed but not otherwise changed.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Link: https://lore.kernel.org/r/2dbd5f0a-9859-ca2d-085e-a02f7166c610@suse.com
Signed-off-by: Juergen Gross <jgross@suse.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 arch/x86/xen/enlighten_pv.c |  4 ----
 arch/x86/xen/smp_pv.c       | 26 ++++++--------------------
 2 files changed, 6 insertions(+), 24 deletions(-)

diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c
index 16ff25d6935e7..804c65d2b95f3 100644
--- a/arch/x86/xen/enlighten_pv.c
+++ b/arch/x86/xen/enlighten_pv.c
@@ -1387,10 +1387,6 @@ asmlinkage __visible void __init xen_start_kernel(void)
 
 		xen_acpi_sleep_register();
 
-		/* Avoid searching for BIOS MP tables */
-		x86_init.mpparse.find_smp_config = x86_init_noop;
-		x86_init.mpparse.get_smp_config = x86_init_uint_noop;
-
 		xen_boot_params_init_edd();
 
 #ifdef CONFIG_ACPI
diff --git a/arch/x86/xen/smp_pv.c b/arch/x86/xen/smp_pv.c
index c2ac319f11a4b..8f9e7e2407c87 100644
--- a/arch/x86/xen/smp_pv.c
+++ b/arch/x86/xen/smp_pv.c
@@ -149,28 +149,12 @@ int xen_smp_intr_init_pv(unsigned int cpu)
 	return rc;
 }
 
-static void __init xen_fill_possible_map(void)
-{
-	int i, rc;
-
-	if (xen_initial_domain())
-		return;
-
-	for (i = 0; i < nr_cpu_ids; i++) {
-		rc = HYPERVISOR_vcpu_op(VCPUOP_is_up, i, NULL);
-		if (rc >= 0) {
-			num_processors++;
-			set_cpu_possible(i, true);
-		}
-	}
-}
-
-static void __init xen_filter_cpu_maps(void)
+static void __init _get_smp_config(unsigned int early)
 {
 	int i, rc;
 	unsigned int subtract = 0;
 
-	if (!xen_initial_domain())
+	if (early)
 		return;
 
 	num_processors = 0;
@@ -211,7 +195,6 @@ static void __init xen_pv_smp_prepare_boot_cpu(void)
 		 * sure the old memory can be recycled. */
 		make_lowmem_page_readwrite(xen_initial_gdt);
 
-	xen_filter_cpu_maps();
 	xen_setup_vcpu_info_placement();
 
 	/*
@@ -491,5 +474,8 @@ static const struct smp_ops xen_smp_ops __initconst = {
 void __init xen_smp_init(void)
 {
 	smp_ops = xen_smp_ops;
-	xen_fill_possible_map();
+
+	/* Avoid searching for BIOS MP tables */
+	x86_init.mpparse.find_smp_config = x86_init_noop;
+	x86_init.mpparse.get_smp_config = _get_smp_config;
 }
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Wed Feb 09 18:53:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 09 Feb 2022 18:53:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269446.463532 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHs5Y-0005ju-Ol; Wed, 09 Feb 2022 18:53:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269446.463532; Wed, 09 Feb 2022 18:53:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHs5Y-0005jn-Lr; Wed, 09 Feb 2022 18:53:12 +0000
Received: by outflank-mailman (input) for mailman id 269446;
 Wed, 09 Feb 2022 18:53:11 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=4iPq=SY=epam.com=prvs=403937cc0f=oleksii_moisieiev@srs-se1.protection.inumbo.net>)
 id 1nHs5X-0005jh-3p
 for xen-devel@lists.xenproject.org; Wed, 09 Feb 2022 18:53:11 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 85195811-89d9-11ec-8f75-fffcc8bd4f1a;
 Wed, 09 Feb 2022 19:53:09 +0100 (CET)
Received: from pps.filterd (m0174679.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 219IYVlO007604;
 Wed, 9 Feb 2022 18:53:05 GMT
Received: from eur05-db8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2104.outbound.protection.outlook.com [104.47.17.104])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e4k0mg1vy-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 09 Feb 2022 18:53:04 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com (2603:10a6:102:ea::23)
 by DBAPR03MB6517.eurprd03.prod.outlook.com (2603:10a6:10:19a::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Wed, 9 Feb
 2022 18:51:57 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::c1c:f98:9dd:86e0]) by PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::c1c:f98:9dd:86e0%6]) with mapi id 15.20.4975.011; Wed, 9 Feb 2022
 18:51:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 85195811-89d9-11ec-8f75-fffcc8bd4f1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=bxbKk3E6/9yB4MDJXhkm+UwXSy3vneND51tz02liEvV9CUyPuGGexkTlKsD9To1tUUoT0JYt3ltd36EPfSFq/MWxiTSCy88fcKN/NXPwuXgu7by/+F2BF9txucNZadbiigSbJTKdThhjfaV19BjWF3xfXilwIEAgIEogmuVvSYT9SautxHPbpilima+XvWBR47cRnJwxULrUICoN8Wl9d8igW2JDJ4yPRkY2C1GhNhkgijcCfoROlP2FqomxxZSMjj8h1OTwbH3d2WyJGRxKxaJ2+Q07OhHtxwjQzI2ceH33cDfazQI0PZpR7XQoFpzIPHvPoDn6T5v+7z4EisR4Kg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=5Fz0jYHNqsq+CFUOHWsmDaJYjSHjqInO4tNdjh3ABGA=;
 b=YjxhNhdSY/P3hLwSEGKhHKFIl9FGvBapxRgMkk44RQeMpI9QhA4BiKitc0SGmTtInggaXyL4g20QZHP8tE+pj7r6fBiRb/sqGCIckrB/uYi4vksJ0b0tO40NpRrjUyILsgqowGenk6BLsZIMVR9hpg445QRicdKygGAhohCQuOE2C/yLVMcg9t7Mis35MAFIH7RP8lsm29ybq80S+Qf3RrTBB4bk0JwPLp72AQR9ZkCUKEOvkoXRl8/v+QVo7m4xQjV4RJtquCMge6TXmaXH7P10a8oJuU5XUb5NbdAab/pBzW/JbtXnGGWX8DjOYHQIXH9euV0wG0yK04oN4rJyUg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=5Fz0jYHNqsq+CFUOHWsmDaJYjSHjqInO4tNdjh3ABGA=;
 b=Ho/7rzDWON6dISG+Eo+DZgrz7fLK5xBUJDCIo2zVioiCPCrb0HvPxp2+dpwp3oxLohKmBA0NFpW0sqSHDSQPOWOkKE/X1dqPnVqPNBmNHhu7yfKmvBSiGJpL6TP6VtcbHTG0VLGWvkidvaz5IkOeNg0FklkJBkS4jImNyoyBzdVCE/X7Gu9SP+hPpTpjJFTiHq3JsjR9idL/2F8RnCspCQERIVtWWI/FnyXSX+odutP5Bg2TXrpdwOD+U1zbgyeBVx0wV4ECDXv/UjIYFKXK4BvbPkGS2z0Ca0VEzhv415eHm1pFrocdw9bLpxDZhck/aReV6kW2Es667pNLgt1bgA==
From: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
To: Julien Grall <julien@xen.org>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        Stefano
 Stabellini <sstabellini@kernel.org>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Juergen Gross <jgross@suse.com>
Subject: Re: [RFC v2 3/8] xen/arm: Export host device-tree to hypfs
Thread-Topic: [RFC v2 3/8] xen/arm: Export host device-tree to hypfs
Thread-Index: AQHYHRW1S717SraA0Ui+K6wc2/TNAKyJ+LkAgAEKd4CAACCZgIAAbkMA
Date: Wed, 9 Feb 2022 18:51:57 +0000
Message-ID: <20220209185156.GA1475048@EPUAKYIW015D>
References: <cover.1644341635.git.oleksii_moisieiev@epam.com>
 <e440e4f16a506ecc87078635dbb3fda2ebd45346.1644341635.git.oleksii_moisieiev@epam.com>
 <b88f6a50-6e9e-5679-8d25-89e26031e88e@xen.org>
 <20220209102037.GA1025795@EPUAKYIW015D>
 <316bd101-af8b-d2f0-1db5-ea6c583acd59@xen.org>
In-Reply-To: <316bd101-af8b-d2f0-1db5-ea6c583acd59@xen.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: cb3f11e3-9526-420e-09f4-08d9ebfd3f88
x-ms-traffictypediagnostic: DBAPR03MB6517:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <DBAPR03MB6517702AA019BE0DB0345852E32E9@DBAPR03MB6517.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 ZyvazkJANtfEVow93RhzJ+v9sCFj2M+u8kJ9en4NV7HqfORFXamdSJN+ylNaGLsmA60+CtgiAUgvnokizt+CHdZROBp9fFYshjWyPNTZ7rBnQ8bYYclKVsZsuiqWnvsgBRULDdxvTRpO+jjaceqbdtee3zaT+TrLClBdL/zkvl4y8i+52PTHz8zFzAk6qeLC0RvMOxbH4U1CpWmPeEJHyW6s4kjPCvvKMRbjCWN7A0XqzWqn4FPGZTtA37uTmx4ZMiWzutdd3iRmFiWgByLUR5/JtL799mrDQNrqgnM/CrFscoN2c+kU4Z9/SWc6CL4MvRL6jOEONwG0ONfmAs3/gioyYNJjMBsx7j00hio1vQKoqnJjhezFon5fIUCsdsCqWvK1QpNF70fnjrvHTJbmIV/BKENJKdi9fgSHAAam3t2CmfXwCKSq5qveKJ/EUZyzaxxW/qF8qiV2YUIL/uCuxpioxkj93AskLrtqcFwdZzkgjqjpbYQr3SqnuCUux6zFhdlglfLKk/+njekFHAO9oycWm97fLxW0ldNHyalc/ot/8BuKysNtP103rJDJ9+mFoIUri/elpazHpN9C0dTkAAHJsqYXZQpW0pRrmQaXc/CRm6sBZE2Hx44JYOJgFX+hzXSo77DzusE5iOIx/cGylBQJ3uU7hTHYG79vMZ51JmianALNaPPdKXBqR0nOJOpzNFiuaxyohJLlMRRT7MlZ/A==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR03MB7136.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(1076003)(316002)(91956017)(71200400001)(33656002)(186003)(6486002)(508600001)(86362001)(66946007)(66556008)(4326008)(66476007)(76116006)(8676002)(26005)(6916009)(66446008)(64756008)(54906003)(5660300002)(38100700002)(8936002)(2906002)(33716001)(122000001)(6512007)(9686003)(38070700005)(83380400001)(6506007);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?db8EQYTfH4QtjWdeNJan2cCOmEg87r8qrMcH5cniDG1IW6MtqWZrbLaZMKwE?=
 =?us-ascii?Q?YNTl43q1QH1MM9MKaGGr/KJuecjm5AYDecFeYBiEU8P15b0a/DBEYYs0mhok?=
 =?us-ascii?Q?xFRvud34QuTNxPaGbtnMnzABIriwz//rJlbo/Xj+lJZ48ooC9p43GdZbM8SQ?=
 =?us-ascii?Q?vaWABSYzQbhuRmUAOTUnm7+Tp0PLKlmM2IMxXYK5RyMZKGYbJbm+1KcPa16j?=
 =?us-ascii?Q?gGae8H+g5OqBO3P+soZ86Q1YX0ct+OsWG0TPcslPOFabEdVltcWlvu8r+MlS?=
 =?us-ascii?Q?oTNSPXoaJGPZRdNc6whqU3HN0P2r6ZTUZea/GQvxpjxuNpSPri84sNF5PpZs?=
 =?us-ascii?Q?9tHMUFCYCGJPyX06k9yNwZivzAYa7KniSCOMxTuFA+8sxkEkHmDFfsde7qLh?=
 =?us-ascii?Q?06LQax7D+8Tj8C9BKaZJ3VvO1EfzMIajpzESRFwPa5Bkb5PJWu4RA2GbffPD?=
 =?us-ascii?Q?/CqgpFNIYp0nUgoVlFK66b+SErMu7qVk5+K5hohsilw/d8rrKuOiYI3UIcH8?=
 =?us-ascii?Q?ynBaLOdCKmWo1KDsdfbITgrT+T/2n/28T09PDr8Do1knmpcvIrWRzqRo6V/2?=
 =?us-ascii?Q?Z2y2o50NFxakagKZVrWBhJ3mYDQyUxV2tkKEGqu2ApIaKX/o9Lvq4AFBgeOZ?=
 =?us-ascii?Q?oD8nQN8HtjjzZszNKDyDuGHGVU+ajMgyIfX5unLlaiX4kqg0r9QkdiWneErT?=
 =?us-ascii?Q?dJIInAO24aNwozCotu5Qt6f7y6qb7IQM1uCNLYKM0ALD9XAOyH2EQRzD3VtY?=
 =?us-ascii?Q?4RoU2miMZIYvBOsBnXtGRH3wZykUz3KkHAYxyTl+iyoT3+kriBL8EdrxACyK?=
 =?us-ascii?Q?25V0aeI0457b+D16b23GmjLwKIsXUZdnlCLXjqe4hb3JD/BUcxjGn1iCPYST?=
 =?us-ascii?Q?YBZA4Kc8S9/ivlM/vT5iPKnfCdPKF8jkPbPC15LKlCTP4vCjbnWvsH9+58Zy?=
 =?us-ascii?Q?IEY7xOdZd75uOKklorTr+Cyo54DUAiWO07sw31pr9i7Y8oOX1t2NviRsxUlb?=
 =?us-ascii?Q?rYSAvKFrdotNXQng71H75xlN2W7O1AKgiFtei/tDpYx0sx9nbzHTdkTvRCa5?=
 =?us-ascii?Q?W/OV5BHRJ8Rn+E3hvPn+80i2aBr2cNoY1RFfORcyHtKbExMATPlKfOi1V7y6?=
 =?us-ascii?Q?XPJOZu3TeOVWQFu3+j5+/E0y2yKhrg2F1r5XYLzTBDMwLoTenpJkJUihW1WT?=
 =?us-ascii?Q?ctVlS5Y/t5LVkmg8JZGenKiilZC/6ya8AoZvTp7oh5ASkSazzYgfGPcnoZbo?=
 =?us-ascii?Q?KafpFok0iQtXoa9QdRSBtLEApk2Jp+QFUpqcEd4UXQhhjX8X8t0f0lQBPysM?=
 =?us-ascii?Q?YReSRuasAoFS28V7DDSjtqODmMBLhoBxb08rnTbUlbyLjmygarBP5Fomw6Wl?=
 =?us-ascii?Q?iKssYpjBpA53Eg/NfzOuN8s2LbyyclssFkjtkfUxhqDt91HfWrYFfza3OSvD?=
 =?us-ascii?Q?nE/DnGFL4NAPogJeiY+G83Q7oofOtU9dsjU9i+RHMejVE1KYCb+HNmHuLzvM?=
 =?us-ascii?Q?C7vCo5bPqUzVfoQhPMIxRVSopHZQS7quCCtctJafysRTW7JZ8dFOjtkn62W1?=
 =?us-ascii?Q?knGC8N9hjEClYS6BOXoIj3XZxt/gmrBiLeY5jatCUY+HliHHsT08HZEh/IWF?=
 =?us-ascii?Q?OQLxAriR2mqN/z24R3wRXSv5U8uv9L8QLXEWtJ1y/1Fu96zDwWCUpfXn++a7?=
 =?us-ascii?Q?JGZ0iSWZ0hq1z9+E+bdkLkos1n8=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <FD78674FB54BFB4D994F5DEAE90EF6AB@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR03MB7136.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cb3f11e3-9526-420e-09f4-08d9ebfd3f88
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Feb 2022 18:51:57.3682
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 5qWDuKn7Gpwnkrb4aNdZw7Ag8kIByk0KTSd4u/RR9nYwuogL3JAkMz7Yc47vdh1cB2xx3q/ozPIvpl2Gz3ZxhdyHRMD2f6U86QOPIj71bqU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR03MB6517
X-Proofpoint-GUID: 2K68kOZvUBJWDG2DM7XfAFTSpV7eV_gA
X-Proofpoint-ORIG-GUID: 2K68kOZvUBJWDG2DM7XfAFTSpV7eV_gA
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-09_09,2022-02-09_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 adultscore=0
 clxscore=1015 lowpriorityscore=0 malwarescore=0 mlxlogscore=999
 suspectscore=0 mlxscore=0 bulkscore=0 spamscore=0 priorityscore=1501
 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202090099

On Wed, Feb 09, 2022 at 12:17:17PM +0000, Julien Grall wrote:
> > > > +static HYPFS_DIR_INIT_FUNC(host_dt_dir, HOST_DT_DIR, &host_dt_dir_=
funcs);
> > > > +
> > > > +static int __init host_dtb_export_init(void)
> > > > +{
> > > > +    ASSERT(dt_host && (dt_host->sibling =3D=3D NULL));
> > >=20
> > > dt_host can be NULL when booting on ACPI platform. So I think this wa=
nts to
> > > be turned to a normal check and return directly.
> > >=20
> >=20
> > I will replace if with
> > if ( !acpi_disabled )
> >      return -ENODEV;
> >=20
> > > Also could you explain why you need to check dt_host->sibling?
> > >=20
> >=20
> > This is my way to check if dt_host points to the top of the device-tree=
.
> > In any case I will replace it with !acpi_disabled as I mentioned
> > earlier.
>=20
> dt_host will always points to the root of the host device-tree. I don't
> think it is the job of hypfs to enforce it unless you expect the code to =
be
> buggy if this happens. But then I would argue the code should be hardened=
.
>=20

Hi Julien,

Unfortunatelly I can't use acpi_disabled in host_dtb_export_init because
I've already moved host_dtb_export.c to the common folder.

As for the host->sibling - I took the whole assert:
ASSERT(dt_host && (dt_host->sibling =3D=3D NULL));
from the prepare_dtb_hwdom function. And this assertion was added by the
commit b8f1c5e7039efbe1103ed3fe4caedf8c34affe13 authored by you.

What do you think if I omit dt_host->sibling check and make it:

if ( !dt_host )
    return -ENODEV;

Best regards,
Olkesii.=


From xen-devel-bounces@lists.xenproject.org Wed Feb 09 18:54:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 09 Feb 2022 18:54:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269452.463544 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHs6c-0006IM-4K; Wed, 09 Feb 2022 18:54:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269452.463544; Wed, 09 Feb 2022 18:54:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHs6c-0006IF-0x; Wed, 09 Feb 2022 18:54:18 +0000
Received: by outflank-mailman (input) for mailman id 269452;
 Wed, 09 Feb 2022 18:54:16 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nHs6a-0006Hv-2a; Wed, 09 Feb 2022 18:54:16 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nHs6a-0003Tl-0l; Wed, 09 Feb 2022 18:54:16 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nHs6Z-000516-GF; Wed, 09 Feb 2022 18:54:15 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nHs6Z-000889-Fm; Wed, 09 Feb 2022 18:54:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=t5cdnGERbjhWXyY+JEScjH2vAlCRLjC9aLZee1OCpbQ=; b=LUFwSV2tiuggltGGzSncZrQ/sS
	awx/j6aIPb5rCKWAJXX1evEVMASEOPSFVkYjJdriR8Cq+SiEaUn8Cg1LZ6/qYBebU/M/rLv9VD9JB
	kDyirpyArLVFf/2LmoXHT8Yb8qLMcfOTQjvQ5mXj0gFpfscs2r42q88kyWAJcjemgiUI=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168061-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.14-testing test] 168061: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-4.14-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=496fb0be938a30971af05ffe0e58bb65643a0971
X-Osstest-Versions-That:
    xen=f2eaa786062970eee41df1ffba1475f4ab36c234
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 09 Feb 2022 18:54:15 +0000

flight 168061 xen-4.14-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168061/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168013
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168013
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168013
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168013
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168013
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168013
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168013
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168013
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168013
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168013
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168013
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168013
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  496fb0be938a30971af05ffe0e58bb65643a0971
baseline version:
 xen                  f2eaa786062970eee41df1ffba1475f4ab36c234

Last test of basis   168013  2022-02-04 17:06:25 Z    5 days
Testing same since   168061  2022-02-08 18:37:46 Z    1 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Jan Beulich <jbeulich@suse.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   f2eaa78606..496fb0be93  496fb0be938a30971af05ffe0e58bb65643a0971 -> stable-4.14


From xen-devel-bounces@lists.xenproject.org Wed Feb 09 19:33:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 09 Feb 2022 19:33:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269475.463582 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHsiJ-0002R5-MZ; Wed, 09 Feb 2022 19:33:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269475.463582; Wed, 09 Feb 2022 19:33:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHsiJ-0002Qy-JW; Wed, 09 Feb 2022 19:33:15 +0000
Received: by outflank-mailman (input) for mailman id 269475;
 Wed, 09 Feb 2022 19:33:14 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nHsiI-0002Qo-I1; Wed, 09 Feb 2022 19:33:14 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nHsiI-0004Fj-Co; Wed, 09 Feb 2022 19:33:14 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nHsiH-0006oe-Vg; Wed, 09 Feb 2022 19:33:14 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nHsiH-0001QD-VE; Wed, 09 Feb 2022 19:33:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=S9d0wapHCK78iAH7K1edS9cNpBpPHxEdfQ5xdtBcGAY=; b=5EuGGsPZtvU4dwzwzQHpDPLGK2
	Sx/mvJEUrVNA0UAnZ+R/8JpffLNKBXqpwcehbG/jyUr6vFcZzmQNqRgGuZ5xM/u0h5K/l+LC82FnE
	0XBB4jIrvPZyjHwsKCAYBcImReOzoiTarJG/u1R9JERyEvFP1xaTDs+T4Drqveqa2Fxg=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168067-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 168067: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=18ec405a36e24c86abe1104699c0bffdc91d5169
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 09 Feb 2022 19:33:13 +0000

flight 168067 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168067/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              18ec405a36e24c86abe1104699c0bffdc91d5169
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  579 days
Failing since        151818  2020-07-11 04:18:52 Z  578 days  560 attempts
Testing same since   168067  2022-02-09 04:21:45 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brad Laue <brad@brad-x.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Christophe Fergeau <cfergeau@redhat.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Divya Garg <divya.garg@nutanix.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Emilio Herrera <ehespinosa57@gmail.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Ivan Teterevkov <ivan.teterevkov@nutanix.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Lubomir Rintel <lkundrak@v3.sk>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nicolas Lécureuil <neoclust@mageia.org>
  Nicolas Lécureuil <nicolas.lecureuil@siveo.net>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Rohit Kumar <rohit.kumar3@nutanix.com>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  shenjiatong <yshxxsjt715@gmail.com>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tuguoyi <tu.guoyi@h3c.com>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Vineeth Pillai <viremana@linux.microsoft.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yasuhiko Kamata <belphegor@belbel.or.jp>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 96768 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Feb 09 19:35:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 09 Feb 2022 19:35:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269485.463594 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHsk2-00030z-3c; Wed, 09 Feb 2022 19:35:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269485.463594; Wed, 09 Feb 2022 19:35:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHsk2-00030s-0B; Wed, 09 Feb 2022 19:35:02 +0000
Received: by outflank-mailman (input) for mailman id 269485;
 Wed, 09 Feb 2022 19:35:00 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nHsk0-00030a-4x
 for xen-devel@lists.xenproject.org; Wed, 09 Feb 2022 19:35:00 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nHsjz-0004Gi-On; Wed, 09 Feb 2022 19:34:59 +0000
Received: from 54-240-197-228.amazon.com ([54.240.197.228]
 helo=[192.168.1.215]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nHsjz-0006HT-If; Wed, 09 Feb 2022 19:34:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=JUppj0n6Sa3l9uCdr5NqN6JBku4hehc1JdipUhPj4+c=; b=pLn59oVhxrS65sCCx9a1eiJB49
	0tKy85A7b9GCICTIPUXT+fpI/2vUmdLmgJCO5b6Lz5BcDBoHwIWmRD5l8U3K7w6pmQYTiy5aOZxYU
	rMhJW87+xPoW6L/dgWe9bfGBOdPFQaJHAatJjzyPKawm4Z6ljUcq0kmBscQ7Md/cvZ3M=;
Message-ID: <6fcf1e16-0c9d-c871-76b7-59d9311e9db4@xen.org>
Date: Wed, 9 Feb 2022 19:34:57 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.1
Subject: Re: [RFC v2 3/8] xen/arm: Export host device-tree to hypfs
To: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>, Juergen Gross <jgross@suse.com>
References: <cover.1644341635.git.oleksii_moisieiev@epam.com>
 <e440e4f16a506ecc87078635dbb3fda2ebd45346.1644341635.git.oleksii_moisieiev@epam.com>
 <b88f6a50-6e9e-5679-8d25-89e26031e88e@xen.org>
 <20220209102037.GA1025795@EPUAKYIW015D>
 <316bd101-af8b-d2f0-1db5-ea6c583acd59@xen.org>
 <20220209185156.GA1475048@EPUAKYIW015D>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220209185156.GA1475048@EPUAKYIW015D>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 09/02/2022 18:51, Oleksii Moisieiev wrote:
> On Wed, Feb 09, 2022 at 12:17:17PM +0000, Julien Grall wrote:
>>>>> +static HYPFS_DIR_INIT_FUNC(host_dt_dir, HOST_DT_DIR, &host_dt_dir_funcs);
>>>>> +
>>>>> +static int __init host_dtb_export_init(void)
>>>>> +{
>>>>> +    ASSERT(dt_host && (dt_host->sibling == NULL));
>>>>
>>>> dt_host can be NULL when booting on ACPI platform. So I think this wants to
>>>> be turned to a normal check and return directly.
>>>>
>>>
>>> I will replace if with
>>> if ( !acpi_disabled )
>>>       return -ENODEV;
>>>
>>>> Also could you explain why you need to check dt_host->sibling?
>>>>
>>>
>>> This is my way to check if dt_host points to the top of the device-tree.
>>> In any case I will replace it with !acpi_disabled as I mentioned
>>> earlier.
>>
>> dt_host will always points to the root of the host device-tree. I don't
>> think it is the job of hypfs to enforce it unless you expect the code to be
>> buggy if this happens. But then I would argue the code should be hardened.
>>
> 
> Hi Julien,
> 
> Unfortunatelly I can't use acpi_disabled in host_dtb_export_init because
> I've already moved host_dtb_export.c to the common folder.

I am sorry, but I don't understand why moving the code to common code 
prevents you to use !acpi_disabled. Can you clarify?

> 
> As for the host->sibling - I took the whole assert:
> ASSERT(dt_host && (dt_host->sibling == NULL));
> from the prepare_dtb_hwdom function. And this assertion was added by the
> commit b8f1c5e7039efbe1103ed3fe4caedf8c34affe13 authored by you.

I am not sure what's your point... Yes I wrote the same ASSERT() 9 years 
time. But people view evolves over the time.

There are some code I wished I had written differently (How about you? 
;)). However, I don't have the time to rewrite everything I ever wrote. 
That said, I can at least make sure they are not spread.

> 
> What do you think if I omit dt_host->sibling check and make it:
> 
> if ( !dt_host )
>      return -ENODEV;

We used to set dt_host even when booting with ACPI but that shouldn't be 
the case anymore. So I think this check should be fine.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Feb 09 20:24:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 09 Feb 2022 20:24:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269496.463604 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHtV2-000844-P7; Wed, 09 Feb 2022 20:23:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269496.463604; Wed, 09 Feb 2022 20:23:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHtV2-00083x-M9; Wed, 09 Feb 2022 20:23:36 +0000
Received: by outflank-mailman (input) for mailman id 269496;
 Wed, 09 Feb 2022 20:23:35 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nHtV0-00083n-Vb; Wed, 09 Feb 2022 20:23:34 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nHtV0-0005GE-To; Wed, 09 Feb 2022 20:23:34 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nHtV0-00007W-JR; Wed, 09 Feb 2022 20:23:34 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nHtV0-00075Z-Gw; Wed, 09 Feb 2022 20:23:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=iaOwvVeB5xtSayddnNAypjDGLKzYEz5vVc0RjY3Gl4I=; b=Mf6A92N5aQ0KFE8MQ6tt0Uz8Ts
	ooZTw0o2MNThylDwp1x0bz5ANDj6LykRtRsrmjRXvw7zAigKrYGZg0HV8sXu4qmS3GhT4o6byw4/q
	oFKP3wKytH7JanfUzgKIJm1Ito/tbIBfAC1do8ZLWVm3aVNcnkjabYcmY8knUB9TFGJw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168071-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 168071: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=87319afb96973213ec0a76270d93696f3b8d6743
X-Osstest-Versions-That:
    xen=da4c512b05ed94e41c91bd8ed6d45895cf97cf51
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 09 Feb 2022 20:23:34 +0000

flight 168071 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168071/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  87319afb96973213ec0a76270d93696f3b8d6743
baseline version:
 xen                  da4c512b05ed94e41c91bd8ed6d45895cf97cf51

Last test of basis   168070  2022-02-09 12:05:58 Z    0 days
Testing same since   168071  2022-02-09 17:02:46 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Julien Grall <jgrall@amazon.com>
  Volodymyr Babchuk <volodymyr_babchuk@epam.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   da4c512b05..87319afb96  87319afb96973213ec0a76270d93696f3b8d6743 -> smoke


From xen-devel-bounces@lists.xenproject.org Wed Feb 09 20:46:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 09 Feb 2022 20:46:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269508.463616 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHtrG-00021B-OZ; Wed, 09 Feb 2022 20:46:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269508.463616; Wed, 09 Feb 2022 20:46:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHtrG-000214-Kr; Wed, 09 Feb 2022 20:46:34 +0000
Received: by outflank-mailman (input) for mailman id 269508;
 Wed, 09 Feb 2022 20:46:33 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nHtrF-00020u-Jk; Wed, 09 Feb 2022 20:46:33 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nHtrF-0005fM-GW; Wed, 09 Feb 2022 20:46:33 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nHtrF-0001on-3H; Wed, 09 Feb 2022 20:46:33 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nHtrF-0007mI-2q; Wed, 09 Feb 2022 20:46:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=9ZzqJvdc0mh7BRb2Z2yF2VQbFThQa8yZ/580bRsWJJo=; b=tts65b+A5qHn4yHq78lhtjEWq4
	wMFIcDaqMJtWZ0Xkec2792jQ08RlHNzCPjtW2oIJAjUgFMoZhZvWdr1TqIHkF/k8tU/zoBkUF5v56
	a1iurXEDNBZrF9ADGMAWFfTlVxWFNMPWSbkhFHsSGIxNCX8oQoB1zglObJFZ7t5Jq/14=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168066-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 168066: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=e6251ab4551f51fa4cee03523e08051898c3ce82
X-Osstest-Versions-That:
    linux=555f3d7be91a873114c9656069f1a9fa476ec41a
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 09 Feb 2022 20:46:33 +0000

flight 168066 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168066/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168052
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168052
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168052
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168052
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168052
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail like 168052
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168052
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168052
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168052
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                e6251ab4551f51fa4cee03523e08051898c3ce82
baseline version:
 linux                555f3d7be91a873114c9656069f1a9fa476ec41a

Last test of basis   168052  2022-02-08 02:04:22 Z    1 days
Testing same since   168066  2022-02-08 20:41:22 Z    1 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Anna Schumaker <Anna.Schumaker@Netapp.com>
  Chuck Lever <chuck.lever@oracle.com>
  Dan Aloni <dan.aloni@vastdata.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  NeilBrown <neilb@suse.de>
  Trond Myklebust <trond.myklebust@hammerspace.com>
  trondmy@kernel.org <trondmy@kernel.org>
  Yang Li <yang.lee@linux.alibaba.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   555f3d7be91a..e6251ab4551f  e6251ab4551f51fa4cee03523e08051898c3ce82 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Thu Feb 10 02:42:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 10 Feb 2022 02:42:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269553.463627 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHzPN-0003oR-56; Thu, 10 Feb 2022 02:42:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269553.463627; Thu, 10 Feb 2022 02:42:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nHzPM-0003oJ-Uo; Thu, 10 Feb 2022 02:42:08 +0000
Received: by outflank-mailman (input) for mailman id 269553;
 Thu, 10 Feb 2022 02:42:07 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nHzPL-0003o9-Gw; Thu, 10 Feb 2022 02:42:07 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nHzPL-0006N0-CP; Thu, 10 Feb 2022 02:42:07 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nHzPK-0001YJ-ME; Thu, 10 Feb 2022 02:42:06 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nHzPK-0006Lo-Ku; Thu, 10 Feb 2022 02:42:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=X3IGnLZwsGLgZ3NqAuO/u+TN5hg9x68fJnfzIpiOGUg=; b=t7dnF3+yjWYnGnICU95uTzRq0I
	5b4tHbwBdb3HLx6VONrZ6KQNqN/pahxHHHxO/RArnKUtGqyXK3Zt/7UBC07qvrfPFS6niya+o1maQ
	YGFIvb72zU8ByfFE0R62XL1HjJ71mdI0+D7Uv6AeySs+SqKmXMRv+peFiniAmfPmcTnc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168069-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 168069: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=52ce1c97844db213de01c5300eaaa8cf101a285f
X-Osstest-Versions-That:
    xen=345746045b49258547d67f456c368f23353575d4
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 10 Feb 2022 02:42:06 +0000

flight 168069 xen-unstable real [real]
flight 168073 xen-unstable real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/168069/
http://logs.test-lab.xenproject.org/osstest/logs/168073/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 168073-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168064
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168064
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168064
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168064
 test-armhf-armhf-xl-rtds     18 guest-start/debian.repeat    fail  like 168064
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168064
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168064
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168064
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168064
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168064
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168064
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168064
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168064
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 xen                  52ce1c97844db213de01c5300eaaa8cf101a285f
baseline version:
 xen                  345746045b49258547d67f456c368f23353575d4

Last test of basis   168064  2022-02-08 18:37:45 Z    1 days
Testing same since   168069  2022-02-09 10:47:48 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Jan Beulich <jbeulich@suse.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   345746045b..52ce1c9784  52ce1c97844db213de01c5300eaaa8cf101a285f -> master


From xen-devel-bounces@lists.xenproject.org Thu Feb 10 04:08:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 10 Feb 2022 04:08:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269574.463662 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nI0kI-0003h1-Lf; Thu, 10 Feb 2022 04:07:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269574.463662; Thu, 10 Feb 2022 04:07:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nI0kI-0003gu-I9; Thu, 10 Feb 2022 04:07:50 +0000
Received: by outflank-mailman (input) for mailman id 269574;
 Thu, 10 Feb 2022 04:07:49 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nI0kH-0003gk-GD; Thu, 10 Feb 2022 04:07:49 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nI0kH-00082o-Ds; Thu, 10 Feb 2022 04:07:49 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nI0kG-0004Sh-Vo; Thu, 10 Feb 2022 04:07:49 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nI0kG-0005el-VN; Thu, 10 Feb 2022 04:07:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=fFTzMD1bsqIuDEGyJ9OFqFDZ4WjvX1J9sFRCQdWRf+I=; b=5lW2P3xffJr2RPymqkBbgxFVFn
	RwmvKKO2WWgKlVPxQmgGfdiIWs38zyUnCYk+V4R0s/H+OwhuQk81iasCIGghNzcHpkveJAmZdrBjq
	nErPGYCb8DRsYkUNbOj5mP08M0iRhws0VpJmNdYru/v26Z8rIllYY/N9+xHXF2rQtpv4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168074-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 168074: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=c9b7c6e0cc7da76b74bcdd8c90cef956d5ae971c
X-Osstest-Versions-That:
    ovmf=b360b0b589697da267f5d3a553e65635b91ebae2
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 10 Feb 2022 04:07:48 +0000

flight 168074 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168074/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 c9b7c6e0cc7da76b74bcdd8c90cef956d5ae971c
baseline version:
 ovmf                 b360b0b589697da267f5d3a553e65635b91ebae2

Last test of basis   168048  2022-02-07 17:10:21 Z    2 days
Testing same since   168074  2022-02-10 02:10:25 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Rebecca Cran <quic_rcran@quicinc.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   b360b0b589..c9b7c6e0cc  c9b7c6e0cc7da76b74bcdd8c90cef956d5ae971c -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Thu Feb 10 07:15:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 10 Feb 2022 07:15:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269589.463673 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nI3fN-0004Yj-UD; Thu, 10 Feb 2022 07:14:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269589.463673; Thu, 10 Feb 2022 07:14:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nI3fN-0004Yc-QV; Thu, 10 Feb 2022 07:14:57 +0000
Received: by outflank-mailman (input) for mailman id 269589;
 Thu, 10 Feb 2022 07:14:56 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nI3fM-0004YS-70; Thu, 10 Feb 2022 07:14:56 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nI3fM-0003Y7-3N; Thu, 10 Feb 2022 07:14:56 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nI3fL-00061A-NS; Thu, 10 Feb 2022 07:14:55 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nI3fL-0006oU-My; Thu, 10 Feb 2022 07:14:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=G5uiEB7ObcLdzlSkKJ1Q0x9iq2E1CKeKPzMdeIhT9rE=; b=BdfAATPycSDoFp9fLIkwnUCcAE
	yKhE9/TR4B4T34LHVYL8ShxjvJHOxrlq6fZWF9s4LuTjTT38xG9BpY3EXWo/5PpzytwcJmVVAcI3e
	zbLWhiYT6Zh77+pmLp/AdbJw0FfUtHzr7y/7246MOSCGjv5xzmj+KDuRgSI5VSOjPEyg=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168072-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 168072: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-xsm:guest-start/debian.repeat:fail:heisenbug
    linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:heisenbug
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=f4bc5bbb5fef3cf421ba3485d6d383c27ec473ed
X-Osstest-Versions-That:
    linux=e6251ab4551f51fa4cee03523e08051898c3ce82
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 10 Feb 2022 07:14:55 +0000

flight 168072 linux-linus real [real]
flight 168077 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/168072/
http://logs.test-lab.xenproject.org/osstest/logs/168077/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-xl-vhd       8 xen-boot            fail pass in 168077-retest
 test-amd64-amd64-xl-xsm 22 guest-start/debian.repeat fail pass in 168077-retest
 test-armhf-armhf-libvirt      8 xen-boot            fail pass in 168077-retest

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt 16 saverestore-support-check fail in 168077 like 168066
 test-arm64-arm64-xl-vhd     14 migrate-support-check fail in 168077 never pass
 test-arm64-arm64-xl-vhd 15 saverestore-support-check fail in 168077 never pass
 test-armhf-armhf-libvirt    15 migrate-support-check fail in 168077 never pass
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168066
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168066
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168066
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168066
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168066
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail like 168066
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168066
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168066
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                f4bc5bbb5fef3cf421ba3485d6d383c27ec473ed
baseline version:
 linux                e6251ab4551f51fa4cee03523e08051898c3ce82

Last test of basis   168066  2022-02-08 20:41:22 Z    1 days
Testing same since   168072  2022-02-09 20:50:38 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Ard Biesheuvel <ardb@kernel.org>
  Christian Borntraeger <borntraeger@linux.ibm.com>
  Chuck Lever <chuck.lever@oracle.com>
  Domenico Andreoli <domenico.andreoli@linux.com>
  Herbert Xu <herbert@gondor.apana.org.au>
  Jan Beulich <jbeulich@suse.com>
  Janis Schoetterl-Glausch <scgl@linux.ibm.com>
  Kees Cook <keescook@chromium.org>
  Linus Torvalds <torvalds@linux-foundation.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      fail    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   e6251ab4551f..f4bc5bbb5fef  f4bc5bbb5fef3cf421ba3485d6d383c27ec473ed -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Thu Feb 10 07:22:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 10 Feb 2022 07:22:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269604.463683 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nI3mw-00064t-Ru; Thu, 10 Feb 2022 07:22:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269604.463683; Thu, 10 Feb 2022 07:22:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nI3mw-00064m-P2; Thu, 10 Feb 2022 07:22:46 +0000
Received: by outflank-mailman (input) for mailman id 269604;
 Thu, 10 Feb 2022 07:22:45 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=sWaC=SZ=yahoo.com=akm2tosher@srs-se1.protection.inumbo.net>)
 id 1nI3mv-00064g-5A
 for xen-devel@lists.xenproject.org; Thu, 10 Feb 2022 07:22:45 +0000
Received: from sonic304-20.consmr.mail.ne1.yahoo.com
 (sonic304-20.consmr.mail.ne1.yahoo.com [66.163.191.146])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 3c213fbe-8a42-11ec-8eb8-a37418f5ba1a;
 Thu, 10 Feb 2022 08:22:43 +0100 (CET)
Received: from sonic.gate.mail.ne1.yahoo.com by
 sonic304.consmr.mail.ne1.yahoo.com with HTTP; Thu, 10 Feb 2022 07:22:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3c213fbe-8a42-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1644477761; bh=ZZvgsyCTeXRtOZQ4sm+l1YfOSFuNPEZ1SjzTGrBqYEA=; h=Date:From:To:Cc:In-Reply-To:References:Subject:From:Subject:Reply-To; b=F3yslocUaGBRpdDh+ktnCyagxKKx0CsxvHZMSnP1uIjmQcMKQwCn/2UJrN/NHBo/8I8KWoQ8P2fTfZ7eMFzYNv3o6QAI8QMv72y1r4XXI+m+eAY0aICHUUp5KPMmPvincdOdLk1D6sM/iKuZv1vUGcQsqnX9ROimHgIW2nk9tqRscgEedxx/IRTJcWbYWFpVdaUZHd/OZ5nupN6LVgo6l/yJg/RBL9jvtk7froNoy42dkRvhEKdbImNePJzwoLGfkrNxlNE4ZXRlLklWRwCzNZTNGUa+momhNlUEEL9Uh7qjwBjNTJH1NHRl4aLeJ9bgtw6UCk4UpuRENPL/2d89Kg==
X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1644477761; bh=26KO92rtqrsbK4XOLuVx/PfFStUx8PVTd6b4W1sw/89=; h=X-Sonic-MF:Date:From:To:Subject:From:Subject; b=Z9krgNefy3Fa2eJOTphp9RE8V7gA/6GtJEDKaHON/8kdFoSs2Ts6EVQP4KXveyWvgZYqRYxURWeaACrpEuKKCvfjRk8/2oUNqc8f80Mky4uoS2eNGFwRpUiA6kCRLLcnpO0OweYnfHujBCerCVlhw0oSQE+M6KW74i8W+BPINcVmP5BBS3aQmpqufLD2JTVD2BzJ8dk2BcMuV7KGXA+uLtI4SVkquHuNGEhDVlTV04tW28cvFCwLz2Dc8NE0aIZfqqs+Rtgy/EiBuHaBMuZsLJLnCS/drL056kdWR72004o5ebnXc2L7iLtVPYu0McDTlgTYFmYeL/JtUq7AVOJw6Q==
X-YMail-OSG: 60k44.QVM1n6wI5z_gjJ9F8MpArsaaYqPKOA5qFY.uEJvXj7hvZ1DUXNQhaWnf8
 oZ9Rophda97btyivQxnFul9pEgvCfVBvYY64B.Qb4mFzzBZ1rEH3iZBTH2Kr3WMe48teK4AW6Kqd
 b3CGD.uDeHb9U9Ry8kR2RGQ8m5s3Pn5alHIAOjCgCmpBvELY.7ZVyRnxIuyEHbW.aL.HOu7UhEnv
 OICLkONchXMd.owl0Uw20z3L8bnT8U6Io21sZrR8u9QARdEAXu7cgsUlfyoppZzloeanWk68inDk
 .TbHhexwfLlUQBZ2zaliqF6Lr141EVDN0YfI7DwqfQfr3yo0cHMl3zrdmrfDYRZXPNmxNkRKvBPD
 H10YRaaePUq_GNoNorhLPMAg2ovHj7pg9K.s2iDFRHXgsV5PRFCPPMiN4NbLNL28IebuKY3Iaa4q
 fXgXn3CLveizesYBpwwWr_h4m9kiop_U2VS6oGX_GDSc8X4uZjWOFGAl4PGAvl8iCy6D1zMZDp47
 IYsbRCTLcsztxrJSXEF0D1o7QpgdcZxjPAeXYTQ7pJUH9bbt2FRpIb9U6_I3adDPRW1t58FIyUn5
 5K76XNv1t6eL9cbE1q1jypyypzBnqqbPVfib5Ho9f.4eNb9itSdZU3uqoKd08H4QZhThOKQULSe5
 IhiXFx1CXWhyo6x2EgCDaOu9.3R9v9R2NNSw0rFt3Tf0XzveamfRhrh2LecPvU24oOTT9tnwWDi6
 Bcf8TEeWPZwwRCO3JMYNkvom3z_wd9O2y3un13q8dzCUeFXJ5A_7lNOOZmtX2MQ5ambNtPx3VdAf
 TnTRjFlVcNNGvOSEMBVJ_p0sq_mjsv5c.05yDPZsGUm5EXdo6RDi1QN96Ew.gkLH0V5Wt0anH9bl
 IufLdTb1QAAOIcsuemaljOjS3EVkgKDLxe3x2_araRq6Baoyi.Rrx07SuynVrm_eOUOHb0QTb.Pl
 FeYcm9Fj5Ym8omOlthCTzwTAe9ZD_AUEDsD3iIHUY3wOvNUPT0_kHkPUVu8UY.KklaVRruv7tgOY
 Yz5De1hNTeg0W7QeKnlBSF7Oy3TaKQP.DF1D5qUkrHVpKaPnyGrEPVqWw9p5vtDkx6za7qMcI7kq
 o_4bTejg0sRgdCPoQr6onVryq_dPzeszwc7FZR2WNrVGdiMPAWld52VF_JOURlyOu8n0i5oTCVUz
 AUE3AzVW6Qmv9QwhLv9PoUwewVsz3xvBH9n7bCgBFCRWKTNxQOvk8vgGYOWeDeBJOsbPM.DxuauJ
 F8jZne2a.E60_EUOt_I48yVGG.ONFJVg89f0nrp1AP45xw1HxG0VsSIVdavGjz8qJLLO9Lv77gVJ
 p6l78OfWdyBzf4OmSdHgEI2XM6.qOR6CQ1U18qGWlOOmYlY.t7eu0CRxOwGlDnNSe.FJoGvknOpg
 IavsQ7AjxtOrHHh0diPXRBpu1XCa271OhbFGTD5CIeQKkNI7VBoA_TwlY__VnvKYqOgbKpFBgRVQ
 oNsO5w.f70Ag6QLtAFGNJmHRe5xxhLvzUO8XMMHdBlYcWE1PuKtp1i2etqqWnjRcXm3mdysRTysQ
 YCxhRlsXHv8gSCz7EqBJ3VVv03Q52Y8xkx4Y4dXdZcpqYV6dYpmFZRdhUo9MLlek.ara3FiR.7iS
 NME2AXSPM.vwyQaYxiBhzTPg8Yzt6IkavdwfsD8Y59KnEnFwfSI9CRXHs2jMp5LYzPj.R0CBjqFn
 nYeppYGXVFcgw0G1QrY4.Qf3eTNDyMkO0WrerZoHHka4S7M5MJm1b9bUsJQURsA._qGk5Tg2jTeE
 1.io8fMi9eRGVlgKrtMc1sllSsoq8Gpt1evw.ytlQ3O.4ZvS9sTBLAAn2o.d5omPy0eTQZkdN0Li
 E8jdx40D2yuK5WStGStRhrXPEDEV_.SKljQXywr6GIbd3TrD33pS.CnVuIAIAwN8IhMzQVUdxQN.
 bQzj03y7kpwVNyXos.GPfKVjBUtBW4Fz_zE31pusuzYQ0sloY1IT0szDJonfPz7CqczyOg9PPjQi
 RrHSvFN2hAsODZvrOSTRy.EHW_scHO.aAC2WqOVctgSY5acR53gmLRO0jtwrqcwyRhtxVjTpluZ2
 5DOq1pWNdnghYlA2k5nGd5fXje05GUo1R4sUSfCaIlwVxbavcaomdUTCyv629Y0B4EaaApQNL7AN
 z8RbUwDylAIqpUshKrBnJNu5faBQoxJ4fOQZWMY1WiQ313OnbpSDfJs4hQXnW.DaA96Nbjwbc6Gv
 2TjBNlOULNjv7oxFM07xpihyw6ICZJ5NJGNBkpVEbjU73KuZ.AFvQoMU-
X-Sonic-MF: <akm2tosher@yahoo.com>
Date: Thu, 10 Feb 2022 07:22:38 +0000 (UTC)
From: tosher 1 <akm2tosher@yahoo.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "roger.pau@citrix.com" <roger.pau@citrix.com>, 
	"xadimgnik@gmail.com" <xadimgnik@gmail.com>, 
	"oleksandr_andrushchenko@epam.com" <oleksandr_andrushchenko@epam.com>, 
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Message-ID: <303292590.682317.1644477758255@mail.yahoo.com>
In-Reply-To: <0e64c52c-1e9c-e89b-abb8-50171d885926@suse.com>
References: <709142925.628001.1644127197288.ref@mail.yahoo.com> <709142925.628001.1644127197288@mail.yahoo.com> <0e64c52c-1e9c-e89b-abb8-50171d885926@suse.com>
Subject: Re: PCI passthrough support for PVH mode
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Mailer: WebService/1.1.19724 YMailNorrin
Content-Length: 1021

Hi Jan,

Thanks for letting me know this status.

I am wondering if PCI passthrough is at least available in Arm for other virtualization modes like PV, HVM, or PVHVM. For example, is it possible for someone to attach a PCI device to a guest domain on an Arm machine and use that domain as a driver domain, like we can do with the Xen on x86?

Please let me know.

Regards,
Mehrab




On Monday, February 7, 2022, 02:57:45 AM EST, Jan Beulich <jbeulich@suse.com> wrote: 





On 06.02.2022 06:59, tosher 1 wrote:

> Back in the year 2020, I was inquiring into the status of PCI passthrough support for PVH guests. At that time, Arm people were working on using vPCI for guest VMs. The expectation was to port that implementation to x86 once ready.
> 
> I was wondering if there is any update on this. Does Xen support PCI passthrough for PVH mode yet? Please let me know.


The Arm work is still WIP, and in how far it's going to be straightforward to
re-use that code for x86 is still unclear (afaict at least).

Jan




From xen-devel-bounces@lists.xenproject.org Thu Feb 10 07:29:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 10 Feb 2022 07:29:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269613.463695 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nI3t8-0006kJ-Jq; Thu, 10 Feb 2022 07:29:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269613.463695; Thu, 10 Feb 2022 07:29:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nI3t8-0006kC-Gd; Thu, 10 Feb 2022 07:29:10 +0000
Received: by outflank-mailman (input) for mailman id 269613;
 Thu, 10 Feb 2022 07:29:09 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=4tMu=SZ=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nI3t7-0006k6-Le
 for xen-devel@lists.xenproject.org; Thu, 10 Feb 2022 07:29:09 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 220715f4-8a43-11ec-8f75-fffcc8bd4f1a;
 Thu, 10 Feb 2022 08:29:08 +0100 (CET)
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur03lp2054.outbound.protection.outlook.com [104.47.10.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-27-mbAvmjiiPOOtNYV-VZgIXw-1; Thu, 10 Feb 2022 08:29:06 +0100
Received: from AM0PR04MB5587.eurprd04.prod.outlook.com (2603:10a6:208:125::12)
 by AM6PR04MB5157.eurprd04.prod.outlook.com (2603:10a6:20b:a::33) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Thu, 10 Feb
 2022 07:29:04 +0000
Received: from AM0PR04MB5587.eurprd04.prod.outlook.com
 ([fe80::54e:e7d:545a:da84]) by AM0PR04MB5587.eurprd04.prod.outlook.com
 ([fe80::54e:e7d:545a:da84%3]) with mapi id 15.20.4951.019; Thu, 10 Feb 2022
 07:29:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 220715f4-8a43-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644478147;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=735dO+IVphNuxewaC5SXcwM89VI6D2wWgL4lGv3ogfU=;
	b=b9v8WnkvATB1v0T/mHDgxNGP8O2edSFU07ZDLM6ZXw/H4vnMW6cMu4UDyaF73dAmP0QGXs
	rZKXZwtKEbkV370tJRgCw1ZzW04NAzO5FB/gVHzYjYk8QRBujs4W9bBSzyO/UlFEk6s8mh
	drBVOL0LsOUyXHXWgVDazP2FSXX5kDE=
X-MC-Unique: mbAvmjiiPOOtNYV-VZgIXw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=l/T53s0K2hNvcWhKM0toZ/e326V628HyIjA+ikpLnEa18KPkkZ4a15aI58OhUVlFM14oqJdif3YwDODDEl1nRhYjRrToyL2950lLdoRrTMH/A0r/4AVp/nb++jsEhjPvCBiQy+trQjuMjnQ5iDzPx242WyHi2YU5WdBJigk2HPm58WD+IYAy+KlLM/GeSrZZKHMhdpUjDTLT1PzVCPLc0OhBDx68HOl4xK6l3+Y72oKUuqSWKZ3Qq364lnOK35D7uBQhO5gy9E14ud3jts5jGqv5iJHzw3Q0eOEmZIIdIptBpQFhZNte3gCQhpdCAn2wc3LWUYDmEq5gpddtzxVRmQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=735dO+IVphNuxewaC5SXcwM89VI6D2wWgL4lGv3ogfU=;
 b=T4HJ4+C7cpKt8H44aToiOpzq7/yB1e7eeLfgRLFXfLfJw1zJaxf/51C18z1lYmGq3FLhQS0bZQwKD3u70q0NelqDtG4fY87swwzbMPmAhukmfLKu+Z7mxC+Cf/zVB3nY2w0tqdhIW/aQP2Pbx8s5Knd5nDX8smzWyTnMqTO5f2IEEPLy9vhr+5lmWD2AhQxTvmapROcB7Tb7FDomBBppQG6CuoXV1AOpHlT166joXGn1hvF/wBOf8YCGqRI+pu9m0pcTcATDj29NKHnfBPgSkRX86Mq48f7sffzXoExBpzteMg26PhIbqCTYZU4x0rehMqu5TBa3F8OLWv9y5NQCYg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <97b2156c-d523-90d4-58b2-d18781490233@suse.com>
Date: Thu, 10 Feb 2022 08:29:01 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: PCI passthrough support for PVH mode
Content-Language: en-US
To: tosher 1 <akm2tosher@yahoo.com>
Cc: "roger.pau@citrix.com" <roger.pau@citrix.com>,
 "xadimgnik@gmail.com" <xadimgnik@gmail.com>,
 "oleksandr_andrushchenko@epam.com" <oleksandr_andrushchenko@epam.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <709142925.628001.1644127197288.ref@mail.yahoo.com>
 <709142925.628001.1644127197288@mail.yahoo.com>
 <0e64c52c-1e9c-e89b-abb8-50171d885926@suse.com>
 <303292590.682317.1644477758255@mail.yahoo.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <303292590.682317.1644477758255@mail.yahoo.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P194CA0108.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:209:8f::49) To AM0PR04MB5587.eurprd04.prod.outlook.com
 (2603:10a6:208:125::12)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 6571efbe-09c6-4b2f-a5fb-08d9ec6703bc
X-MS-TrafficTypeDiagnostic: AM6PR04MB5157:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB51572F040D8E6BF92EA1E070B32F9@AM6PR04MB5157.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	3sm1e9ICldT7/2Mt65HFpBdGNdgAuHugtCU56EKIuPtJVAxXowssAo2B2roQI5Baoe4pSp/48NsbrugijMeNVkrXwM41XlAKqcoM5J2wJ3obku6BQqBkqlcpO5L9M3+17jtRMHjl+EWGvzYOjNQ1G2OWmBnlkaeYpJWiu56LDqv4gIf3rsA4Jd12mW96TogdLwBeeQTzDCz1aw/J8QN63pA0Tve9sEsJFI7rIB5ZkCMQsBzUkibEBbmqdlD92AL1Th6eMCuION4DEZIBm+zdbZnQYrjqLIqsj2JAp7GbnlrC99vjHh+MKutFUskK/y9wBLsCIY0ZKzqvD2AFi1+nOLbUAzTs7nq4Ck2ijY424qspkC00wDRR66jRJf9p2zAa+5CdHxOOvMzaqxGTLCk5mlKRZxmeyRLVFzM/f0c2A7eWQAdcFS8/IC1Kqb7XdadpdKoI+yQuO2k6TY5JivS4TuhjDHUD1Xp8HU+ltEd72qrPeWVfg9ubIVckcTxAUP/vV5XI6ctTbF+Ibhv6iRDQ1/31TeWmupaj058FL5IHgbW8lkpFfHebdytd9woYV47QzrKw7oYE6LS2OmGExJK5t1bV9RhJhI2k07E60MnZHddMCGJ4MxYRN/C4vjkOuGmpV40sq/Ud9NkN5qY6mh+ilYkvNSxn6WnZqUMXwciOgtg0nIu+pYGmaL2jcZjIUsHNiuW0bxaKyVhhesJyk4BQdWSn1VH09HPfM9AnYJ5VKxM=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR04MB5587.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6666004)(4744005)(2616005)(6506007)(53546011)(6512007)(5660300002)(316002)(508600001)(6916009)(54906003)(2906002)(36756003)(6486002)(66476007)(66556008)(38100700002)(4326008)(8676002)(8936002)(26005)(66946007)(186003)(31686004)(86362001)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Y2lXYXR1aHVlMG1heVpuV1RsMVJFc0tEQWhDVXVvUHhPY1E2R01aU013SEpT?=
 =?utf-8?B?eWJ2dTRLcXlvOHR3RkZaL0wzaHV6TTM1RFViYjFta1YyZzUrZzREeWdwTGN1?=
 =?utf-8?B?VW1NZnFJdlVHb2d1Q3BORjVJWUg1eDRzeG5UaDlKY01hYk5ONGdLZVllT3dG?=
 =?utf-8?B?bXozRDUyU1prSEZTNGMxOGxHOTM5dlhCSVZLYzdIS0d6eWlBV0ZSTUlocFh2?=
 =?utf-8?B?Z244STBhQ1lPay9OaEJ5NExtV1F5eHRPa3IrRVVrUmVMcGZrSXFscmZXcC82?=
 =?utf-8?B?cERMa2hJMXJDbjBnMGlXY3Yzb3FEZkRPNndBMGk4UENuZDJRU1RKTkhFOEU5?=
 =?utf-8?B?bmZpYU5EZmZGWkw2VGF0SEIrdEQwcWtmTlEwakFwLzlXb0FzYTd0OXhjT3hr?=
 =?utf-8?B?d2MxUDlIK3hLY1NUOWJCRGNXazQ4ajU3WFg1Z1RtYmppSUdNTUtVbGIvMkxQ?=
 =?utf-8?B?d1liM3JXRlNjOThrOGh4c25zZFVWY3dWcTVCWVJWdjJHL1ZDZkNFTWswQkRC?=
 =?utf-8?B?T0ZpRFNnMmdNTXZjVWRSVWdpaEtFdDNIRWZoRWZVNHN1TWJGSDluRDBOTVBW?=
 =?utf-8?B?TUNKRDlFQ1hzaG51c1dUUzV3YVBuMWszNGMwUUR5L2ZuZXJkRGlrNGduWWNn?=
 =?utf-8?B?RGc3K3FENkFvVVQxb0crOVhmbGJSN3h0bnJNcVRCaGhiVytXNUljcDFhQThj?=
 =?utf-8?B?QWREV0hYa0tlWHM3ZkJFUlUzdWpCWWhFdXNBeE1YaUVNZUVNUlhSMTgvU3NS?=
 =?utf-8?B?RVNjYno4KzA1UStqRitYZXVDalpYMDVOS054bDZtaTlMd1dRME1YQ3hoMDVE?=
 =?utf-8?B?Y2RNL0lPS1VOcEJhYlJ0WTFPbjk0SVRqZ0Z2TVE4MGkyeGI5ZjU1TzdGaXV5?=
 =?utf-8?B?dmRFYnRzbzRKUHBPd2MxcUcvSWxmQWRIUE1lUGE1VjJYTFRxQ3ptSkFIRVFT?=
 =?utf-8?B?ZWoxVlVvNWxiQVdqRmlydHFRbXgzMVEzd2VOcE9JWEErT1hyU25GWklINHcv?=
 =?utf-8?B?UlVnMDZwWTJmZXJQRzA3b1FxRzVhY3o3RVZTUmhtNGNzN2oyRUV3Q1o2NEsy?=
 =?utf-8?B?RGVkVWJKLzJ0ZHRKL0NxMDBpMmI0RjdLcDJpNWkvNm1FTWRSOGtYTHZIQ3d3?=
 =?utf-8?B?TUJJR3VLV2sxbVhUQnRkQ3FDM1dQNk5aL0FBZUV5S2ZvbnJUcDNoUU1NS0VZ?=
 =?utf-8?B?TzJWVE5oWWN3T0JoVnE4aGRoSEZlSDYvK1pJZmhpVGYwL3ByeHh0UldHamlk?=
 =?utf-8?B?eDYwRkR2Z0RPNVpvTVZuR2FMK0djOUMwRkE3KzVBMGtaSDllcDVFRzZDNGtx?=
 =?utf-8?B?UGpic3lJRjZhbDN1b2pyR0FqVGhsa2xWMWlhTDdFeEJ1blQ5UjhFWGVRb1FK?=
 =?utf-8?B?endkNTJCR1ZuM1ZDa1E1M0lqNGROcXZQZmQyZ2laOXRVTW1DMzU3U1M5bkpk?=
 =?utf-8?B?S2lndklwNHprVk5zUlZBR0xhT2k0c2pObDRXRnFMeVIwcEVjVUJiMEpWMDZU?=
 =?utf-8?B?b2NJOTdoV3hwZzMvdUplM2I0eFZ4WXdzU1B2L2RnWXBKS1I3TDAvTVdZSm55?=
 =?utf-8?B?YUNEeW12UStyTEo5cW4wUGpaa3NmWXAxaDlac1lXL1NmaTZ0NTdmY3BYaDZ5?=
 =?utf-8?B?MWhBM1F4aEJFUFA4TlRWQ29YSXJFWTM5cHF2NTd6SmRka1Y4aFh5TDVmS3Z2?=
 =?utf-8?B?RE1aMmI1b0M3TnpHWTAxK1RxTWIxTk52N243bitaWTNxeS9SQlhEVnZMS3pO?=
 =?utf-8?B?Qm1ZYW10K05zb3dTdHk5c3VESEg1aDcyeEpsVFhIK1ZsZHc1M1pmUHFKQlNt?=
 =?utf-8?B?U1VQWURucHdCT1d3TjBLUmJLS1BjZXpBNXpUR3gzYkNTamNMRlZ2SjBHbXdJ?=
 =?utf-8?B?YStSZ0FyV0dzc3hUeXd4OTZaTEdoMmZpVmwvSWJlQXJubzBYZHRXam50UTRI?=
 =?utf-8?B?NmZkLzhTS2w3aDNpRTdibTg2Q2J6N0E0d1R2ZTRBYnJDbzdZTDFTOGxkR1Bp?=
 =?utf-8?B?c0RwMkZlZmNONUo3VW9yL1Vha2hyOGFnMFpkdjBKcTVvNU5yY1luWmhiV0lD?=
 =?utf-8?B?aktvS043aXBBVGU3cUtoY215MkFJanVCMXRjcnBWc2xwRWQybm5TeFJQdTR6?=
 =?utf-8?B?MUF3UGJWMldNVDdkNTl5TlFzd0J4NVI1K1hjbzdSZmxFYTgxTlp0MWNZaE5G?=
 =?utf-8?Q?4ZD+wO492pev5EPI9EzkJM8=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6571efbe-09c6-4b2f-a5fb-08d9ec6703bc
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB5587.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2022 07:29:04.0148
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cOGbrIm7MiZMkTa4AZnTNfnoL1YQtizDIASHpvDb/W3B459RByXK+sNMjmFW6L+AzYVusqVQLDFPnzeQwtGnYA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5157

On 10.02.2022 08:22, tosher 1 wrote:
> I am wondering if PCI passthrough is at least available in Arm for other virtualization modes like PV, HVM, or PVHVM. For example, is it possible for someone to attach a PCI device to a guest domain on an Arm machine and use that domain as a driver domain, like we can do with the Xen on x86?

Which "other virtualization modes" are you aware of on Arm? (PVHVM is not
really a "mode" anyway, but more like a badly named marketing thing.)

Jan



From xen-devel-bounces@lists.xenproject.org Thu Feb 10 07:34:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 10 Feb 2022 07:34:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269621.463706 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nI3y0-00088E-8e; Thu, 10 Feb 2022 07:34:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269621.463706; Thu, 10 Feb 2022 07:34:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nI3y0-000887-43; Thu, 10 Feb 2022 07:34:12 +0000
Received: by outflank-mailman (input) for mailman id 269621;
 Thu, 10 Feb 2022 07:34:11 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Jhle=SZ=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nI3xz-000881-0z
 for xen-devel@lists.xenproject.org; Thu, 10 Feb 2022 07:34:11 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d57f1a01-8a43-11ec-8eb8-a37418f5ba1a;
 Thu, 10 Feb 2022 08:34:09 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 0BA8B1F391;
 Thu, 10 Feb 2022 07:34:09 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E3A6013B2D;
 Thu, 10 Feb 2022 07:34:08 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id R68NNvC/BGI/GwAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 10 Feb 2022 07:34:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d57f1a01-8a43-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1644478449; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=3O1j1bpbW/ch6tFkCMvCgFn9JEAOW3qfWe8An8WIC0w=;
	b=NsYY4lTnIRiVcPd9Ja2AdCWUigNsrlO+efnd8zTWRBbIh7xwlIJqG3kriOp3GdJZTA3reU
	ug+E/UP9QMC6f1Lxp3Z7qrRmnyC5Zc4w9o8lGTujVQLL73Lq8DsqfVcZiufmR8DkYEvy0K
	ga8Yv0UtsoMmG2ePe+kpwikzqcv+zKo=
Message-ID: <74e4635d-10ad-86c4-71b1-6e46bc76a89a@suse.com>
Date: Thu, 10 Feb 2022 08:34:08 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Content-Language: en-US
To: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <cover.1644341635.git.oleksii_moisieiev@epam.com>
 <8ab7e9ffd5f041c2631f754c7c596874cf6a99c1.1644341635.git.oleksii_moisieiev@epam.com>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [RFC v2 1/8] xen/hypfs: support fo nested dynamic hypfs nodes
In-Reply-To: <8ab7e9ffd5f041c2631f754c7c596874cf6a99c1.1644341635.git.oleksii_moisieiev@epam.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------f8OXvFovN4moNlKuZVwM0Cm0"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------f8OXvFovN4moNlKuZVwM0Cm0
Content-Type: multipart/mixed; boundary="------------WlfFqxl8UMPKExntlB9qi20y";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Message-ID: <74e4635d-10ad-86c4-71b1-6e46bc76a89a@suse.com>
Subject: Re: [RFC v2 1/8] xen/hypfs: support fo nested dynamic hypfs nodes
References: <cover.1644341635.git.oleksii_moisieiev@epam.com>
 <8ab7e9ffd5f041c2631f754c7c596874cf6a99c1.1644341635.git.oleksii_moisieiev@epam.com>
In-Reply-To: <8ab7e9ffd5f041c2631f754c7c596874cf6a99c1.1644341635.git.oleksii_moisieiev@epam.com>

--------------WlfFqxl8UMPKExntlB9qi20y
Content-Type: multipart/mixed; boundary="------------czV0kY5beTBUHUDDwJnrraeZ"

--------------czV0kY5beTBUHUDDwJnrraeZ
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMDguMDIuMjIgMTk6MDAsIE9sZWtzaWkgTW9pc2llaWV2IHdyb3RlOg0KDQpOaXQ6IGlu
IHRoZSBwYXRjaCB0aXRsZSBzL2ZvL2Zvci8NCg0KPiBBZGQgbmV3IGFwaToNCj4gLSBoeXBm
c19yZWFkX2R5bmRpcl9lbnRyeQ0KPiAtIGh5cGZzX2dlbl9keW5kaXJfZW50cnkNCj4gd2hp
Y2ggYXJlIHRoZSBleHRlbnNpb24gb2YgdGhlIGR5bmFtaWMgaHlwZnMgbm9kZXMgc3VwcG9y
dCwgcHJlc2VudGVkIGluDQo+IDBiM2I1M2JlOGNmMjI2ZDk0N2E3OWMyNTM1YTllZmJiMmRk
N2JjMzguDQo+IFRoaXMgYWxsb3dzIG5lc3RlZCBkeW5hbWljIG5vZGVzIHRvIGJlIGFkZGVk
LiBBbHNvIGlucHV0IHBhcmFtZXRlciBpcw0KPiBoeXBmc19lbnRyeSwgc28gcHJvcGVydGll
cyBjYW4gYWxzbyBiZSBnZW5lcmF0ZWQgZHluYW1pY2FsbHkuDQo+IA0KPiBHZW5lcmF0aW5n
IG1peGVkIGxpc3Qgb2YgZGlycyBhbmQgcHJvcGVydGllcyBpcyBhbHNvIHN1cHBvcnRlZC4N
Cj4gU2FtZSBhcyB0byB0aGUgZHluYW1pYyBoeXBmcyBub2RlcywgdGhpcyBpcyBhbmNob3Jl
ZCBpbiBwZXJjcHUgcG9pbnRlciwNCj4gd2hpY2ggY2FuIGJlIHJldHJpZXdlZCBvbiBhbnkg
bGV2ZWwgb2YgdGhlIGR5bmFtaWMgZW50cmllcy4NCj4gVGhpcyBoYW5kbGUgc2hvdWxkIGJl
IGFsbG9jYXRlZCBvbiBlbnRlcigpIGNhbGxiYWNrIGFuZCByZWxlYXNlZCBvbg0KPiBleGl0
KCkgY2FsbGJhY2suIFdoZW4gdXNpbmcgbmVzdGVkIGR5bmFtaWMgZGlycyBhbmQgcHJvcGVy
dGllcyBoYW5kbGUNCj4gc2hvdWxkIGJlIGFsbG9jYXRlZCBvbiB0aGUgZmlyc3QgZW50ZXIo
KSBjYWxsIGFuZCByZWxlYXNlZCBvbiB0aGUgbGFzdA0KPiBleGl0KCkgY2FsbC4NCj4gDQo+
IFNpZ25lZC1vZmYtYnk6IE9sZWtzaWkgTW9pc2llaWV2IDxvbGVrc2lpX21vaXNpZWlldkBl
cGFtLmNvbT4NCj4gLS0tDQo+ICAgeGVuL2NvbW1vbi9oeXBmcy5jICAgICAgfCA4MyArKysr
KysrKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLQ0KPiAgIHhlbi9pbmNsdWRl
L3hlbi9oeXBmcy5oIHwgMTQgKysrKysrLQ0KPiAgIDIgZmlsZXMgY2hhbmdlZCwgNzkgaW5z
ZXJ0aW9ucygrKSwgMTggZGVsZXRpb25zKC0pDQo+IA0KPiBkaWZmIC0tZ2l0IGEveGVuL2Nv
bW1vbi9oeXBmcy5jIGIveGVuL2NvbW1vbi9oeXBmcy5jDQo+IGluZGV4IGU3MWY3ZGY0Nzku
LjY5MDFmNWUzMTEgMTAwNjQ0DQo+IC0tLSBhL3hlbi9jb21tb24vaHlwZnMuYw0KPiArKysg
Yi94ZW4vY29tbW9uL2h5cGZzLmMNCj4gQEAgLTM2NywyOCArMzY3LDI3IEBAIHVuc2lnbmVk
IGludCBoeXBmc19nZXRzaXplKGNvbnN0IHN0cnVjdCBoeXBmc19lbnRyeSAqZW50cnkpDQo+
ICAgDQo+ICAgLyoNCj4gICAgKiBGaWxsIHRoZSBkaXJlbnRyeSBmb3IgYSBkeW5hbWljYWxs
eSBnZW5lcmF0ZWQgZW50cnkuIEVzcGVjaWFsbHkgdGhlDQo+IC0gKiBnZW5lcmF0ZWQgbmFt
ZSBuZWVkcyB0byBiZSBrZXB0IGluIHN5bmMgd2l0aCBoeXBmc19nZW5fZHluZGlyX2lkX2Vu
dHJ5KCkuDQo+ICsgKiBnZW5lcmF0ZWQgbmFtZSBuZWVkcyB0byBiZSBrZXB0IGluIHN5bmMg
d2l0aCBoeXBmc19nZW5fZHluZGlyX2VudHJ5KCkuDQo+ICAgICovDQo+IC1pbnQgaHlwZnNf
cmVhZF9keW5kaXJfaWRfZW50cnkoY29uc3Qgc3RydWN0IGh5cGZzX2VudHJ5X2RpciAqdGVt
cGxhdGUsDQo+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgaW50
IGlkLCBib29sIGlzX2xhc3QsDQo+ICtpbnQgaHlwZnNfcmVhZF9keW5kaXJfZW50cnkoY29u
c3Qgc3RydWN0IGh5cGZzX2VudHJ5ICp0ZW1wbGF0ZSwNCj4gKyAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICBjb25zdCBjaGFyICpuYW1lLCB1bnNpZ25lZCBpbnQgbmFtZWxlbiwN
Cj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBib29sIGlzX2xhc3QsDQo+ICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFhFTl9HVUVTVF9IQU5ETEVfUEFSQU0o
dm9pZCkgKnVhZGRyKQ0KDQpQbGVhc2UgZml4IHRoZSBpbmRlbnRhdGlvbiBvZiB0aGUgcGFy
YW1ldGVycy4NCg0KPiAgIHsNCj4gICAgICAgc3RydWN0IHhlbl9oeXBmc19kaXJsaXN0ZW50
cnkgZGlyZW50cnk7DQo+IC0gICAgY2hhciBuYW1lW0hZUEZTX0RZTkRJUl9JRF9OQU1FTEVO
XTsNCj4gLSAgICB1bnNpZ25lZCBpbnQgZV9uYW1lbGVuLCBlX2xlbjsNCj4gKyAgICB1bnNp
Z25lZCBpbnQgZV9sZW47DQo+ICAgDQo+IC0gICAgZV9uYW1lbGVuID0gc25wcmludGYobmFt
ZSwgc2l6ZW9mKG5hbWUpLCB0ZW1wbGF0ZS0+ZS5uYW1lLCBpZCk7DQo+IC0gICAgZV9sZW4g
PSBESVJFTlRSWV9TSVpFKGVfbmFtZWxlbik7DQo+ICsgICAgZV9sZW4gPSBESVJFTlRSWV9T
SVpFKG5hbWVsZW4pOw0KPiAgICAgICBkaXJlbnRyeS5lLnBhZCA9IDA7DQo+IC0gICAgZGly
ZW50cnkuZS50eXBlID0gdGVtcGxhdGUtPmUudHlwZTsNCj4gLSAgICBkaXJlbnRyeS5lLmVu
Y29kaW5nID0gdGVtcGxhdGUtPmUuZW5jb2Rpbmc7DQo+IC0gICAgZGlyZW50cnkuZS5jb250
ZW50X2xlbiA9IHRlbXBsYXRlLT5lLmZ1bmNzLT5nZXRzaXplKCZ0ZW1wbGF0ZS0+ZSk7DQo+
IC0gICAgZGlyZW50cnkuZS5tYXhfd3JpdGVfbGVuID0gdGVtcGxhdGUtPmUubWF4X3NpemU7
DQo+ICsgICAgZGlyZW50cnkuZS50eXBlID0gdGVtcGxhdGUtPnR5cGU7DQo+ICsgICAgZGly
ZW50cnkuZS5lbmNvZGluZyA9IHRlbXBsYXRlLT5lbmNvZGluZzsNCj4gKyAgICBkaXJlbnRy
eS5lLmNvbnRlbnRfbGVuID0gdGVtcGxhdGUtPmZ1bmNzLT5nZXRzaXplKHRlbXBsYXRlKTsN
Cj4gKyAgICBkaXJlbnRyeS5lLm1heF93cml0ZV9sZW4gPSB0ZW1wbGF0ZS0+bWF4X3NpemU7
DQo+ICAgICAgIGRpcmVudHJ5Lm9mZl9uZXh0ID0gaXNfbGFzdCA/IDAgOiBlX2xlbjsNCj4g
ICAgICAgaWYgKCBjb3B5X3RvX2d1ZXN0KCp1YWRkciwgJmRpcmVudHJ5LCAxKSApDQo+ICAg
ICAgICAgICByZXR1cm4gLUVGQVVMVDsNCj4gICAgICAgaWYgKCBjb3B5X3RvX2d1ZXN0X29m
ZnNldCgqdWFkZHIsIERJUkVOVFJZX05BTUVfT0ZGLCBuYW1lLA0KPiAtICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgZV9uYW1lbGVuICsgMSkgKQ0KPiArICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgbmFtZWxlbiArIDEpICkNCj4gICAgICAgICAgIHJldHVybiAtRUZB
VUxUOw0KPiAgIA0KPiAgICAgICBndWVzdF9oYW5kbGVfYWRkX29mZnNldCgqdWFkZHIsIGVf
bGVuKTsNCj4gQEAgLTM5Niw2ICszOTUsMjIgQEAgaW50IGh5cGZzX3JlYWRfZHluZGlyX2lk
X2VudHJ5KGNvbnN0IHN0cnVjdCBoeXBmc19lbnRyeV9kaXIgKnRlbXBsYXRlLA0KPiAgICAg
ICByZXR1cm4gMDsNCj4gICB9DQo+ICAgDQo+ICsvKg0KPiArICogRmlsbCB0aGUgZGlyZW50
cnkgZm9yIGEgZHluYW1pY2FsbHkgZ2VuZXJhdGVkIGVudHJ5LiBFc3BlY2lhbGx5IHRoZQ0K
PiArICogZ2VuZXJhdGVkIG5hbWUgbmVlZHMgdG8gYmUga2VwdCBpbiBzeW5jIHdpdGggaHlw
ZnNfZ2VuX2R5bmRpcl9pZF9lbnRyeSgpLg0KPiArICovDQo+ICtpbnQgaHlwZnNfcmVhZF9k
eW5kaXJfaWRfZW50cnkoY29uc3Qgc3RydWN0IGh5cGZzX2VudHJ5X2RpciAqdGVtcGxhdGUs
DQo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgaW50IGlkLCBi
b29sIGlzX2xhc3QsDQo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgWEVOX0dV
RVNUX0hBTkRMRV9QQVJBTSh2b2lkKSAqdWFkZHIpDQo+ICt7DQo+ICsgICAgY2hhciBuYW1l
W0hZUEZTX0RZTkRJUl9JRF9OQU1FTEVOXTsNCj4gKyAgICB1bnNpZ25lZCBpbnQgZV9uYW1l
bGVuOw0KPiArDQo+ICsgICAgZV9uYW1lbGVuID0gc25wcmludGYobmFtZSwgc2l6ZW9mKG5h
bWUpLCB0ZW1wbGF0ZS0+ZS5uYW1lLCBpZCk7DQo+ICsgICAgcmV0dXJuIGh5cGZzX3JlYWRf
ZHluZGlyX2VudHJ5KCZ0ZW1wbGF0ZS0+ZSwgbmFtZSwgZV9uYW1lbGVuLCBpc19sYXN0LCB1
YWRkcik7DQo+ICt9DQo+ICsNCj4gKw0KPiAgIHN0YXRpYyBjb25zdCBzdHJ1Y3QgaHlwZnNf
ZW50cnkgKmh5cGZzX2R5bmRpcl9lbnRlcigNCj4gICAgICAgY29uc3Qgc3RydWN0IGh5cGZz
X2VudHJ5ICplbnRyeSkNCj4gICB7DQo+IEBAIC00MDQsNyArNDE5LDcgQEAgc3RhdGljIGNv
bnN0IHN0cnVjdCBoeXBmc19lbnRyeSAqaHlwZnNfZHluZGlyX2VudGVyKA0KPiAgICAgICBk
YXRhID0gaHlwZnNfZ2V0X2R5bmRhdGEoKTsNCj4gICANCj4gICAgICAgLyogVXNlIHRlbXBs
YXRlIHdpdGggb3JpZ2luYWwgZW50ZXIgZnVuY3Rpb24uICovDQo+IC0gICAgcmV0dXJuIGRh
dGEtPnRlbXBsYXRlLT5lLmZ1bmNzLT5lbnRlcigmZGF0YS0+dGVtcGxhdGUtPmUpOw0KPiAr
ICAgIHJldHVybiBkYXRhLT50ZW1wbGF0ZS0+ZnVuY3MtPmVudGVyKGRhdGEtPnRlbXBsYXRl
KTsNCj4gICB9DQo+ICAgDQo+ICAgc3RhdGljIHN0cnVjdCBoeXBmc19lbnRyeSAqaHlwZnNf
ZHluZGlyX2ZpbmRlbnRyeSgNCj4gQEAgLTQxNSw3ICs0MzAsNyBAQCBzdGF0aWMgc3RydWN0
IGh5cGZzX2VudHJ5ICpoeXBmc19keW5kaXJfZmluZGVudHJ5KA0KPiAgICAgICBkYXRhID0g
aHlwZnNfZ2V0X2R5bmRhdGEoKTsNCj4gICANCj4gICAgICAgLyogVXNlIHRlbXBsYXRlIHdp
dGggb3JpZ2luYWwgZmluZGVudHJ5IGZ1bmN0aW9uLiAqLw0KPiAtICAgIHJldHVybiBkYXRh
LT50ZW1wbGF0ZS0+ZS5mdW5jcy0+ZmluZGVudHJ5KGRhdGEtPnRlbXBsYXRlLCBuYW1lLCBu
YW1lX2xlbik7DQo+ICsgICAgcmV0dXJuIGRhdGEtPnRlbXBsYXRlLT5mdW5jcy0+ZmluZGVu
dHJ5KCZkYXRhLT5kaXIsIG5hbWUsIG5hbWVfbGVuKTsNCj4gICB9DQo+ICAgDQo+ICAgc3Rh
dGljIGludCBoeXBmc19yZWFkX2R5bmRpcihjb25zdCBzdHJ1Y3QgaHlwZnNfZW50cnkgKmVu
dHJ5LA0KPiBAQCAtNDI2LDcgKzQ0MSwzNiBAQCBzdGF0aWMgaW50IGh5cGZzX3JlYWRfZHlu
ZGlyKGNvbnN0IHN0cnVjdCBoeXBmc19lbnRyeSAqZW50cnksDQo+ICAgICAgIGRhdGEgPSBo
eXBmc19nZXRfZHluZGF0YSgpOw0KPiAgIA0KPiAgICAgICAvKiBVc2UgdGVtcGxhdGUgd2l0
aCBvcmlnaW5hbCByZWFkIGZ1bmN0aW9uLiAqLw0KPiAtICAgIHJldHVybiBkYXRhLT50ZW1w
bGF0ZS0+ZS5mdW5jcy0+cmVhZCgmZGF0YS0+dGVtcGxhdGUtPmUsIHVhZGRyKTsNCj4gKyAg
ICByZXR1cm4gZGF0YS0+dGVtcGxhdGUtPmZ1bmNzLT5yZWFkKGRhdGEtPnRlbXBsYXRlLCB1
YWRkcik7DQo+ICt9DQo+ICsNCj4gKy8qDQo+ICsgKiBGaWxsIGR5bmRhdGEgd2l0aCBhIGR5
bmFtaWNhbGx5IGdlbmVyYXRlZCBlbnRyeSBiYXNlZCBvbiBhIHRlbXBsYXRlDQo+ICsgKiBh
bmQgYSBuYW1lLg0KPiArICogTmVlZHMgdG8gYmUga2VwdCBpbiBzeW5jIHdpdGggaHlwZnNf
cmVhZF9keW5kaXJfZW50cnkoKSByZWdhcmRpbmcgdGhlDQo+ICsgKiBuYW1lIGdlbmVyYXRl
ZC4NCj4gKyAqLw0KPiArc3RydWN0IGh5cGZzX2VudHJ5ICpoeXBmc19nZW5fZHluZGlyX2Vu
dHJ5KA0KPiArICAgIGNvbnN0IHN0cnVjdCBoeXBmc19lbnRyeSAqdGVtcGxhdGUsIGNvbnN0
IGNoYXIgKm5hbWUsDQo+ICsgICAgdm9pZCAqZGF0YSkNCj4gK3sNCj4gKyAgICBzdHJ1Y3Qg
aHlwZnNfZHluZGlyX2lkICpkeW5kYXRhOw0KPiArDQo+ICsgICAgZHluZGF0YSA9IGh5cGZz
X2dldF9keW5kYXRhKCk7DQo+ICsNCj4gKyAgICBkeW5kYXRhLT50ZW1wbGF0ZSA9IHRlbXBs
YXRlOw0KPiArICAgIGR5bmRhdGEtPmRhdGEgPSBkYXRhOw0KPiArICAgIG1lbWNweShkeW5k
YXRhLT5uYW1lLCBuYW1lLCBzdHJsZW4obmFtZSkpOw0KPiArICAgIGR5bmRhdGEtPmRpci5l
ID0gKnRlbXBsYXRlOw0KPiArICAgIGR5bmRhdGEtPmRpci5lLm5hbWUgPSBkeW5kYXRhLT5u
YW1lOw0KPiArDQo+ICsgICAgZHluZGF0YS0+ZGlyLmUuZnVuY3MgPSAmZHluZGF0YS0+ZnVu
Y3M7DQo+ICsgICAgZHluZGF0YS0+ZnVuY3MgPSAqdGVtcGxhdGUtPmZ1bmNzOw0KPiArICAg
IGR5bmRhdGEtPmZ1bmNzLmVudGVyID0gaHlwZnNfZHluZGlyX2VudGVyOw0KPiArICAgIGR5
bmRhdGEtPmZ1bmNzLmZpbmRlbnRyeSA9IGh5cGZzX2R5bmRpcl9maW5kZW50cnk7DQo+ICsg
ICAgZHluZGF0YS0+ZnVuY3MucmVhZCA9IGh5cGZzX3JlYWRfZHluZGlyOw0KPiArDQo+ICsg
ICAgcmV0dXJuICZkeW5kYXRhLT5kaXIuZTsNCj4gICB9DQo+ICAgDQo+ICAgLyoNCj4gQEAg
LTQ0MiwxMiArNDg2LDEzIEBAIHN0cnVjdCBoeXBmc19lbnRyeSAqaHlwZnNfZ2VuX2R5bmRp
cl9pZF9lbnRyeSgNCj4gICANCj4gICAgICAgZHluZGF0YSA9IGh5cGZzX2dldF9keW5kYXRh
KCk7DQo+ICAgDQo+IC0gICAgZHluZGF0YS0+dGVtcGxhdGUgPSB0ZW1wbGF0ZTsNCj4gKyAg
ICBkeW5kYXRhLT50ZW1wbGF0ZSA9ICZ0ZW1wbGF0ZS0+ZTsNCj4gICAgICAgZHluZGF0YS0+
aWQgPSBpZDsNCj4gICAgICAgZHluZGF0YS0+ZGF0YSA9IGRhdGE7DQo+ICAgICAgIHNucHJp
bnRmKGR5bmRhdGEtPm5hbWUsIHNpemVvZihkeW5kYXRhLT5uYW1lKSwgdGVtcGxhdGUtPmUu
bmFtZSwgaWQpOw0KPiAgICAgICBkeW5kYXRhLT5kaXIgPSAqdGVtcGxhdGU7DQo+ICAgICAg
IGR5bmRhdGEtPmRpci5lLm5hbWUgPSBkeW5kYXRhLT5uYW1lOw0KPiArDQoNClVucmVsYXRl
ZCBjaGFuZ2U/DQoNCj4gICAgICAgZHluZGF0YS0+ZGlyLmUuZnVuY3MgPSAmZHluZGF0YS0+
ZnVuY3M7DQo+ICAgICAgIGR5bmRhdGEtPmZ1bmNzID0gKnRlbXBsYXRlLT5lLmZ1bmNzOw0K
PiAgICAgICBkeW5kYXRhLT5mdW5jcy5lbnRlciA9IGh5cGZzX2R5bmRpcl9lbnRlcjsNCj4g
QEAgLTQ1Nyw2ICs1MDIsMTIgQEAgc3RydWN0IGh5cGZzX2VudHJ5ICpoeXBmc19nZW5fZHlu
ZGlyX2lkX2VudHJ5KA0KPiAgICAgICByZXR1cm4gJmR5bmRhdGEtPmRpci5lOw0KPiAgIH0N
Cj4gICANCj4gK3Vuc2lnbmVkIGludCBoeXBmc19keW5kaXJfZW50cnlfc2l6ZShjb25zdCBz
dHJ1Y3QgaHlwZnNfZW50cnkgKnRlbXBsYXRlLA0KPiArICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgY29uc3QgY2hhciAqbmFtZSkNCg0KUGxlYXNlIGZpeCBpbmRlbnRh
dGlvbi4NCg0KPiArew0KPiArICAgIHJldHVybiBESVJFTlRSWV9TSVpFKHN0cmxlbihuYW1l
KSk7DQo+ICt9DQo+ICsNCj4gICB1bnNpZ25lZCBpbnQgaHlwZnNfZHluaWRfZW50cnlfc2l6
ZShjb25zdCBzdHJ1Y3QgaHlwZnNfZW50cnkgKnRlbXBsYXRlLA0KPiAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGludCBpZCkNCj4gICB7DQo+IGRp
ZmYgLS1naXQgYS94ZW4vaW5jbHVkZS94ZW4vaHlwZnMuaCBiL3hlbi9pbmNsdWRlL3hlbi9o
eXBmcy5oDQo+IGluZGV4IGU5ZDRjMjU1NWIuLjVkMjcyOGI5NjMgMTAwNjQ0DQo+IC0tLSBh
L3hlbi9pbmNsdWRlL3hlbi9oeXBmcy5oDQo+ICsrKyBiL3hlbi9pbmNsdWRlL3hlbi9oeXBm
cy5oDQo+IEBAIC03OSw4ICs3OSw4IEBAIHN0cnVjdCBoeXBmc19lbnRyeV9kaXIgew0KPiAg
IHN0cnVjdCBoeXBmc19keW5kaXJfaWQgew0KDQpQbGVhc2UgcmVuYW1lIHRvIHN0cnVjdCBo
eXBmc19keW5kaXIuDQoNCj4gICAgICAgc3RydWN0IGh5cGZzX2VudHJ5X2RpciBkaXI7ICAg
ICAgICAgICAgIC8qIE1vZGlmaWVkIGNvcHkgb2YgdGVtcGxhdGUuICovDQo+ICAgICAgIHN0
cnVjdCBoeXBmc19mdW5jcyBmdW5jczsgICAgICAgICAgICAgICAvKiBEeW5hbWljIGZ1bmN0
aW9ucy4gKi8NCj4gLSAgICBjb25zdCBzdHJ1Y3QgaHlwZnNfZW50cnlfZGlyICp0ZW1wbGF0
ZTsgLyogVGVtcGxhdGUgdXNlZC4gKi8NCj4gLSNkZWZpbmUgSFlQRlNfRFlORElSX0lEX05B
TUVMRU4gMTINCj4gKyAgICBjb25zdCBzdHJ1Y3QgaHlwZnNfZW50cnkgKnRlbXBsYXRlOyAv
KiBUZW1wbGF0ZSB1c2VkLiAqLw0KPiArI2RlZmluZSBIWVBGU19EWU5ESVJfSURfTkFNRUxF
TiAzMg0KPiAgICAgICBjaGFyIG5hbWVbSFlQRlNfRFlORElSX0lEX05BTUVMRU5dOyAgICAg
LyogTmFtZSBvZiBoeXBmcyBlbnRyeS4gKi8NCj4gICANCj4gICAgICAgdW5zaWduZWQgaW50
IGlkOyAgICAgICAgICAgICAgICAgICAgICAgIC8qIE51bWVyaWNhbCBpZC4gKi8NCg0KV2hh
dCBhYm91dCB0aGUgZm9sbG93aW5nIGNoYW5nZSBpbnN0ZWFkOg0KDQotICAgIGNvbnN0IHN0
cnVjdCBoeXBmc19lbnRyeV9kaXIgKnRlbXBsYXRlOyAvKiBUZW1wbGF0ZSB1c2VkLiAqLw0K
LSNkZWZpbmUgSFlQRlNfRFlORElSX0lEX05BTUVMRU4gMTINCi0gICAgY2hhciBuYW1lW0hZ
UEZTX0RZTkRJUl9JRF9OQU1FTEVOXTsgICAgIC8qIE5hbWUgb2YgaHlwZnMgZW50cnkuICov
DQotDQotICAgIHVuc2lnbmVkIGludCBpZDsgICAgICAgICAgICAgICAgICAgICAgICAvKiBO
dW1lcmljYWwgaWQuICovDQotICAgIHZvaWQgKmRhdGE7ICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAvKiBEYXRhIGFzc29jaWF0ZWQgd2l0aCBpZC4gKi8NCisgICAgY29uc3Qgc3Ry
dWN0IGh5cGZzX2VudHJ5ICp0ZW1wbGF0ZTsgIC8qIFRlbXBsYXRlIHVzZWQuICovDQorICAg
IHVuaW9uIHsNCisjZGVmaW5lIEhZUEZTX0RZTkRJUl9OQU1FTEVOICAgIDMyDQorICAgICAg
ICBjaGFyIG5hbWVbSFlQRlNfRFlORElSX05BTUVMRU5dOyAvKiBOYW1lIG9mIGh5cGZzIGVu
dHJ5LiAqLw0KKyAgICAgICAgc3RydWN0IHsNCisjZGVmaW5lIEhZUEZTX0RZTkRJUl9JRF9O
QU1FTEVOIDEyDQorICAgICAgICAgICAgY2hhciBuYW1lW0hZUEZTX0RZTkRJUl9JRF9OQU1F
TEVOXTsgLyogTmFtZSBvZiBpZCBlbnRyeS4gKi8NCisgICAgICAgICAgICB1bnNpZ25lZCBp
bnQgaWQ7ICAgICAgICAgICAgICAgICAgICAvKiBOdW1lcmljYWwgaWQuICovDQorICAgICAg
ICB9IGlkOw0KKyAgICB9Ow0KKyAgICB2b2lkICpkYXRhOyAgICAgICAgICAgICAgICAgICAg
ICAgICAgLyogRGF0YSBhc3NvY2lhdGVkIHdpdGggZW50cnkuICovDQoNCj4gQEAgLTE5Nywx
MyArMTk3LDIzIEBAIHZvaWQgKmh5cGZzX2FsbG9jX2R5bmRhdGEodW5zaWduZWQgbG9uZyBz
aXplKTsNCj4gICAjZGVmaW5lIGh5cGZzX2FsbG9jX2R5bmRhdGEodHlwZSkgKCh0eXBlICop
aHlwZnNfYWxsb2NfZHluZGF0YShzaXplb2YodHlwZSkpKQ0KPiAgIHZvaWQgKmh5cGZzX2dl
dF9keW5kYXRhKHZvaWQpOw0KPiAgIHZvaWQgaHlwZnNfZnJlZV9keW5kYXRhKHZvaWQpOw0K
PiAraW50IGh5cGZzX3JlYWRfZHluZGlyX2VudHJ5KGNvbnN0IHN0cnVjdCBoeXBmc19lbnRy
eSAqdGVtcGxhdGUsDQo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3Qg
Y2hhciAqbmFtZSwgdW5zaWduZWQgaW50IG5hbWVsZW4sDQo+ICsgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgYm9vbCBpc19sYXN0LA0KPiArICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgIFhFTl9HVUVTVF9IQU5ETEVfUEFSQU0odm9pZCkgKnVhZGRyKTsNCg0KQWdh
aW46IGluZGVudGF0aW9uLg0KDQo+ICAgaW50IGh5cGZzX3JlYWRfZHluZGlyX2lkX2VudHJ5
KGNvbnN0IHN0cnVjdCBoeXBmc19lbnRyeV9kaXIgKnRlbXBsYXRlLA0KPiAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBpbnQgaWQsIGJvb2wgaXNfbGFzdCwN
Cj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgWEVOX0dVRVNUX0hBTkRMRV9Q
QVJBTSh2b2lkKSAqdWFkZHIpOw0KPiArc3RydWN0IGh5cGZzX2VudHJ5ICpoeXBmc19nZW5f
ZHluZGlyX2VudHJ5KA0KPiArICAgIGNvbnN0IHN0cnVjdCBoeXBmc19lbnRyeSAqdGVtcGxh
dGUsIGNvbnN0IGNoYXIgKm5hbWUsDQo+ICsgICAgdm9pZCAqZGF0YSk7DQo+ICAgc3RydWN0
IGh5cGZzX2VudHJ5ICpoeXBmc19nZW5fZHluZGlyX2lkX2VudHJ5KA0KPiAgICAgICBjb25z
dCBzdHJ1Y3QgaHlwZnNfZW50cnlfZGlyICp0ZW1wbGF0ZSwgdW5zaWduZWQgaW50IGlkLCB2
b2lkICpkYXRhKTsNCj4gICB1bnNpZ25lZCBpbnQgaHlwZnNfZHluaWRfZW50cnlfc2l6ZShj
b25zdCBzdHJ1Y3QgaHlwZnNfZW50cnkgKnRlbXBsYXRlLA0KPiAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGludCBpZCk7DQo+ICt1bnNpZ25lZCBp
bnQgaHlwZnNfZHluZGlyX2VudHJ5X3NpemUoY29uc3Qgc3RydWN0IGh5cGZzX2VudHJ5ICp0
ZW1wbGF0ZSwNCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0
IGNoYXIgKm5hbWUpOw0KDQpJbmRlbnRhdGlvbi4NCg0KPiArDQo+ICAgI2VuZGlmDQo+ICAg
DQo+ICAgI2VuZGlmIC8qIF9fWEVOX0hZUEZTX0hfXyAqLw0KDQoNCkp1ZXJnZW4NCg==
--------------czV0kY5beTBUHUDDwJnrraeZ
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------czV0kY5beTBUHUDDwJnrraeZ--

--------------WlfFqxl8UMPKExntlB9qi20y--

--------------f8OXvFovN4moNlKuZVwM0Cm0
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmIEv/AFAwAAAAAACgkQsN6d1ii/Ey9i
dAf/YPNrtAXye8ykXJvu3fxxba+vpJU1wdEXVLLASf+tiB6oMTsAwxOPDCnWUl446anUQ4M55WZL
qCdX76l6NHN/9PT8/RzLNSzoBtq0KwUoKVygdS1mJalDLn7XrGNbYTppzHq61N8tN/tVAyyyxAY5
aooMgJHNcKn19ZGmG4deVbJWgBJDGuD8OogSdz1DZ48Vr9twMRBMPVInPdhNj2dITQguJFkXqSgc
+qPfKqcXWyPXZRj1QxZYzpO7Igy8pFgwI3DgG/6yxEtG04aQWBg8i+0J+etlxz6WQrrsySjCDZWk
nfaDcukaItqpOYFd2egfzmy7DexhyJBK0tOd59q1fw==
=0Sv4
-----END PGP SIGNATURE-----

--------------f8OXvFovN4moNlKuZVwM0Cm0--


From xen-devel-bounces@lists.xenproject.org Thu Feb 10 08:22:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 10 Feb 2022 08:22:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269642.463717 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nI4iW-0005JS-Fr; Thu, 10 Feb 2022 08:22:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269642.463717; Thu, 10 Feb 2022 08:22:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nI4iW-0005JL-Cg; Thu, 10 Feb 2022 08:22:16 +0000
Received: by outflank-mailman (input) for mailman id 269642;
 Thu, 10 Feb 2022 08:22:15 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=06a2=SZ=epam.com=prvs=40400e4a88=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nI4iV-0005Iz-8O
 for xen-devel@lists.xenproject.org; Thu, 10 Feb 2022 08:22:15 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8ac70af9-8a4a-11ec-8f75-fffcc8bd4f1a;
 Thu, 10 Feb 2022 09:22:11 +0100 (CET)
Received: from pps.filterd (m0174679.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 21A7hkKV010201;
 Thu, 10 Feb 2022 08:22:07 GMT
Received: from eur05-vi1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2170.outbound.protection.outlook.com [104.47.17.170])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e4xjqg4xd-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Thu, 10 Feb 2022 08:22:07 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by HE1PR03MB2985.eurprd03.prod.outlook.com (2603:10a6:7:59::10) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Thu, 10 Feb
 2022 08:21:29 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::fc4d:4749:5d1:eb73]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::fc4d:4749:5d1:eb73%4]) with mapi id 15.20.4975.012; Thu, 10 Feb 2022
 08:21:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8ac70af9-8a4a-11ec-8f75-fffcc8bd4f1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cpxxBtNcSlCFx3NjNZ3IEVKuGxiLQcPCDyBdevXQZyJHiGI+gZ6wdG8xamdqOR4dt7mWssSUMinbFzr4WNa5ROCIOm2DvwTcE2FhzZ8Tjk7XjefYR7Joe3+5i3a0DW5I7Ar8hyJMwXDGuuQjWyn5QJZzRbtXT1d5dc0lCt+xUymk4Dg32daF/jFXM2asP7WAAJUXbIP52KSHIASRHO1Ip9NFGvggWgivP/PmrW/jmji5TlWSjql4+mW6QheykJvQF1MJN/qO49kX/Y9fmJm8uhhsOY3Vc700LZxfCiyL3Krs6Xnz7eh2Ggo8Fqsn5wOYZmTlIFP9QReGmNtiXDpcog==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=JLLJyxgLH1tRu7PIvaaR6gIN3imHOL5X4e7qgeNT5oM=;
 b=gEvqovrRgL3wawBGROdT9CtgZnb99xckvbCyve6mP0L+2NRlPHWTdpdDX+1NJvo2seigUlCzJTs0ZGAWyM5fveSllYUU7j5mnK0FuFDSIjcUsnLngd7pb3rt9lfO4rarYJ3PznTtqO8jly0k7vcTcHz8bR8qd2BkC/8TXoUJxso3cc1g7FL3g9FLJCHCK2jieoUtlAgsTfXVPcSzOkJ3zHICI1HBZJ1mgka4/N7uY8WXFzMWv+7yRsuv7rQkuK/zeh0i6de1s1IgbkCEFlZ6++aNW1lD0WHeEkB6k7D5mYvVaHM9HT1vYJxtDT0MzL+v8yJNxZQj9FjA8XwJ8oQxbw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=JLLJyxgLH1tRu7PIvaaR6gIN3imHOL5X4e7qgeNT5oM=;
 b=HGND7bdOEj4SEvibUTUEQIqs6sO9jZpzuNAPx6+OpNjVG7iN0nEPRCkmdcKR3rU4EBL63mLsOUeOroxDpHFDjQ8SVrkl4xeXvYENjmg7nqeDBgppBjSnmDkGbc7ouAXbN44y4RIMSzJmROGyvAXPZBrWI5uu+AO3IrjAyrEtjR6sl3WPGMaI53W/Isq91SktQnhDOuZTeoePIbFiIuMNeiKQWIISTk1Elm/WpqM7fyZwai4p7dgNrUjF7vlNk9m7SBtWnvmF/5mZAIfQOoFr20QYHYbhiVGBed6vJA2DOtx6KF4S/FMin3F8iP4U2//6MQwdox15Fqn49geY2gcX7w==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        "roger.pau@citrix.com"
	<roger.pau@citrix.com>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v6 05/13] vpci: add hooks for PCI device assign/de-assign
Thread-Topic: [PATCH v6 05/13] vpci: add hooks for PCI device assign/de-assign
Thread-Index: 
 AQHYGZFdYv4W1RdbQkeQtzN+PyKqmqyITGQAgAENNICAAAt2AIAAA+uAgAAEsACAAAMyAIAABAgAgAADmACAAAHqgIAABl2AgAACJ4CAAAczgIAC8ScA
Date: Thu, 10 Feb 2022 08:21:28 +0000
Message-ID: <51865693-1b5e-7ab5-f942-d244029c260b@epam.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-6-andr2000@gmail.com>
 <16cea1df-3d0f-d404-2b88-aab47ad5548b@suse.com>
 <3fe6dbe3-51c6-f87f-23f9-cf2e1a924326@epam.com>
 <582ee8f9-7b01-4adc-6a8a-ce8b1dffd534@suse.com>
 <e225553b-b29c-0448-fb9f-f8b513d9f77d@epam.com>
 <0fd8a0ac-dc91-287e-536e-1684892837ab@suse.com>
 <9f58a8ff-44b4-3249-5858-9988644b2d4e@epam.com>
 <15c16171-f196-38d2-370c-38627935a21b@suse.com>
 <20762939-6b7e-ff60-7c1a-d47c4767ff4f@epam.com>
 <10cd89b5-a804-3354-26d8-bc271bd9c5e6@suse.com>
 <15022045-bc92-e3df-b005-aeec5e36a078@epam.com>
 <cf584e13-f257-9355-50fa-c35e8fc8cf5e@suse.com>
 <a0015951-6eff-38a8-a9f0-bdbc8bd51940@epam.com>
In-Reply-To: <a0015951-6eff-38a8-a9f0-bdbc8bd51940@epam.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 0d2627e7-16db-4536-3bb0-08d9ec6e567a
x-ms-traffictypediagnostic: HE1PR03MB2985:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <HE1PR03MB298500FBBB3FE2E1D6FAD31BE72F9@HE1PR03MB2985.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 oeA4O72cPsr9s4xQ8kvk2ApomNC8KdDDvzr1x9S93+Jrfh16bo86Jcv69/Ap+0quguhEVoJ9+fgaIPNO2tuNtn20OK33gHTlwd9+mXxEX8ysOw3zaZgREMFExd4SANFZyn/Jau4UinkTbbP4vcumsTd8fD2k1H1FdRSvB+q6QTkZhVyaO8doa251YHlLtsRZeJWFNbJVm8tGvwnlAHv+HPu/DeThoQN+k8MZClnSxGlJjZIdwzu6Z9+WfRJ18fa8z0M3PCrCx446cTTW8II1zRbhDdliConHGDAnnCMrBSjTXlhoGpUfny9Ln99MX3eczp4UGHAsM4WjyBsn64gQ+1eGxDp297C9PPW34TfW3LSUQrvYk78RzKcnDXiUTc9lAzR1NAb+PTLwLUuSqM53ZBYCFMhOPFfhThd2hD8jRTEpc7zIywPo42pVCKk2LjNIrlb8Eogx1drxKvUjQY2wAoGbF0Or/myZX58Tz/woBacCK5amBj4WxqmjrV+bwYTeiQbN2KW3Bfoyg5DEqgy7THSNslzZzLLfOJTEbYZaR0mBGCuIpfI17fliOykaDnxGuJNGsTN3LMIhlsnUDhuUUbsyd1/HoJU1a32zmrtS4LVWMMu2b8WnzVJRRJY7esUNh3yQ4YgcJBgBgH7LkP5amgul/Txk16GF8Vaai0RvhE4LHWBFix7JkLfPtbOA6TQzUizSV5fKhJ490IrCv3fwtDbFaVGnLxbWDxuKWxvzFTU4g8wE8daBYfF0KnNRVpZi
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(2616005)(36756003)(83380400001)(26005)(2906002)(107886003)(122000001)(186003)(38100700002)(38070700005)(4326008)(66556008)(71200400001)(53546011)(7416002)(66476007)(8676002)(8936002)(64756008)(66446008)(66946007)(6486002)(6506007)(76116006)(91956017)(86362001)(31686004)(31696002)(508600001)(6916009)(6512007)(54906003)(316002)(5660300002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?OTQrRy9nUE1yUDIxNGp1eWxwZHk3Wm44S0hlcDhaTUl6NEZDSGdVRUxkL202?=
 =?utf-8?B?ZnlkWmtROTNiMTUvU2hyamhrMWVRUXhpSGtHdGpKdU5QaDlMK3J2T0Q4UzNU?=
 =?utf-8?B?VUR3cno1M0QvZmNIbmdveFV6QmtSSnpnT1FTcURpbmdIMlhNbkFlWHVDbDZV?=
 =?utf-8?B?MU9CcnU1WmdIVU5lYW5UWEdhV0RpYkF3L2tZY1kyR1RnenVwSHgyN01yYjc0?=
 =?utf-8?B?V1pwRmMvVWVNQ1dmMEx3cjFoZ0lrTEZKdnBxaVg0NnNyRVorREIrbHZOWllY?=
 =?utf-8?B?SHY1MFI0bE5lYkxQOS9ZckdRd0dqN1VnbEI4ZVBBaHVwalh4SmxiSXBWM0dz?=
 =?utf-8?B?czNYM08vTmxyYy9yT3AvbWh6Z1d1cFVNYXhPeW9Md0llNU5VL0hGczl5Tlpa?=
 =?utf-8?B?QW45UStXNmZlUUNCVjJHc0N4ZXh3bzRNSWNQZktZTnUvK3dMSTRQazhpY0t2?=
 =?utf-8?B?aDU5QVhqZGhwT0I1a2FSbGRNU25QNWJpNjNVTWZ4TmlJRnFVN3RLZDZFUEVz?=
 =?utf-8?B?NFdpTklYalEvYVlOQjhBUzVrdE9JcWw4T2w3blVCRkhVejQ0OWJLR3lvQXFo?=
 =?utf-8?B?RUR4WlhEcFMvRGNYbVM0b2U3VkhDWFB0aGJiS3ZHRWcwRU8zbW5TYjZFVDQz?=
 =?utf-8?B?R3dHdnJ2UUV0MU1NR3pyVjN6YXBqdkZYbTVFVFppNlFTTFQ4UmtlbkFVbTFT?=
 =?utf-8?B?NGUzdGNiL2FHOE51c08wN0k1eXRkcXM1YmRLaVpBd2FldnJJdi9JTExRVzBJ?=
 =?utf-8?B?d1gzanFXVVJ2MVNUS0RzZnU5NkRqclpOemNlVTNzdCtBbFVIVHM3RVNKa280?=
 =?utf-8?B?aEdOVWdSUStjMW5IUHlCTkUwK3gyUlF1eGtKL2NWNW1CSEE4TS9UNW53ZWJT?=
 =?utf-8?B?c1Bnck1INTlSQlBuNDNaMGtvcmd5aE50NWVxR1E0NDg3bXIvTEN0a2RreXI1?=
 =?utf-8?B?TDRsWERLWFlzTCtOZW5OSmdPTWlRcVBpR2JMTjFNcXBGN09NeWNBd1lVbmNG?=
 =?utf-8?B?Zkxsc3J5c2RhamNjd3RZbjJTLzBaZDEvRWNmeUtpMTViYUF2NVZPSXpjYmxQ?=
 =?utf-8?B?UG16UHo0a2FTK0R1U0NuZUcyZ1BzOEZBT053azFlRGV6Y3NqaDc0OWlhZ0lt?=
 =?utf-8?B?T2tEeStWbkVWT1J2a3RRSWhyVW9CNC9CL0xhLzBwWHpkSWlkTWlNaU5JWE9m?=
 =?utf-8?B?dE4rZDBwZjJ2Uk1PSWVEMmU5VTFDQ1MrVmhXeHF6eGU0S1U1RUd6cnJPVFQz?=
 =?utf-8?B?aFpDSHlzK0MvSmRRWmFYYlBxNmMrVUV0RkdZeHpHWEZZRUtEQjhZNHNkWURS?=
 =?utf-8?B?TTY3VTZwSGV4RXloSURKTS90WjhJWmxxek9XZUxLeG9DdFJKYkliS3UzRE4r?=
 =?utf-8?B?VUdlaXJIOXcraytlbnU3cU81WHduUzhXZlNQUE9oZTYyOFFjSWZCRXltdFNW?=
 =?utf-8?B?L1NzeXdscGN5Q3F0czFnQUkyNkNCR0xWd2YwUVU2MVZ5M1AzK3VFVzgweFJX?=
 =?utf-8?B?OGdrU0lRQWxPaFIyVTNUaDVoNHg0cTROc1lqSXpmUW5oazE5SUlVT2dOZFdt?=
 =?utf-8?B?QmZkUXc1aGdoeDdFMlhzbjgvRUF0YmF3cUtKNTRraHRoVG1RVzdnaG9KNEk3?=
 =?utf-8?B?ZUwxWFZvcm4waDg2dmVDZXR4YzVGYi81OWZpWVY5OSt5UEx6Uy9jL3hpTUNR?=
 =?utf-8?B?cE5SamV6NThtMEZzVTdTYitrNW5VeDc4Q3dnODZtcGs0YnRnMXhKKzBlQUdq?=
 =?utf-8?B?QWVpZ3h1UnRnMjIzcUZZTHNoZE1JNmFDVUtBbys2WnpSbm5yd0pSR3pEYzFB?=
 =?utf-8?B?MncrS3pUZDlUZTVoYnB4R3FqN1dTUFBia1hSOGFLeTJtMUZBdXQ5SnMwL2Y2?=
 =?utf-8?B?SjM4L1NvSmJDUEoyenJPUVFVc3E4M2xjTzFOcitRMU1HcGY2WVk1ejZ6MFlh?=
 =?utf-8?B?bFJzZU16WWMyV01QdlpCTXNDb3h1ODVPSkdONFhUSU5uTUtjVXRYaC93Nk9W?=
 =?utf-8?B?Q1lQKzFtaWlybWJHQTdRaVFoS0JmUkV3R09iSFQ1MGJwVkRETmc4YXA1NXdP?=
 =?utf-8?B?akxnK2xJSng1R1VHSUNHSVVyUFovYUlaTkZmdEpPZmQxZVRnNDkxdldPeXMy?=
 =?utf-8?B?NHFONkQ1ZkFWZlo5UC9aV3pYY3Q2a0F5OWsyVW1CTDJnSUNnZzJJOHhuOUQ5?=
 =?utf-8?B?YkFHVzE4R2pxblR3amk0elYvVTduRmxZdVRtNVBaL2MvU3Jad2trekZPdlZ2?=
 =?utf-8?B?MmgrZHZEeGtobWl0cDhhbjFNNVlQcnNhZ0JkNkhhbTcwWUo5YUxWSW5rVWpv?=
 =?utf-8?B?eXJrejcvT0tGQnQ4dzNGaUlUcmliZ3IrN0FWSmdjT3IveTFHTlRRQT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <751D5D8887568840BAA239DFF952F473@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0d2627e7-16db-4536-3bb0-08d9ec6e567a
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Feb 2022 08:21:29.0419
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: quLq77uO0aFPE/+7RMSygm/X/I4/Rq16VTq+lm/QMGnUZO3Tkamu/TY7y/rHG01R8R0jgbUS4Y9/K5h33sXxGTwbEdM0B5hNHhrJgI2Jh1Qdqc9uxqY9Rz3pti3jpQ5o
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR03MB2985
X-Proofpoint-ORIG-GUID: CzrJ63mIHrE0l4EQS7owVJdBQP29EqLs
X-Proofpoint-GUID: CzrJ63mIHrE0l4EQS7owVJdBQP29EqLs
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-10_02,2022-02-09_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 mlxlogscore=999
 clxscore=1015 lowpriorityscore=0 spamscore=0 impostorscore=0 adultscore=0
 bulkscore=0 mlxscore=0 suspectscore=0 malwarescore=0 priorityscore=1501
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2202100044

DQoNCk9uIDA4LjAyLjIyIDEzOjI1LCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyB3cm90ZToNCj4N
Cj4gT24gMDguMDIuMjIgMTM6MDAsIEphbiBCZXVsaWNoIHdyb3RlOg0KPj4gT24gMDguMDIuMjAy
MiAxMTo1MiwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+Pj4gVGhpcyBzbWVsbHMg
bGlrZSB3ZSBmaXJzdCBuZWVkIHRvIGZpeCB0aGUgZXhpc3RpbmcgY29kZSwgc28NCj4+PiBwZGV2
LT5kb21haW4gaXMgbm90IGFzc2lnbmVkIGJ5IHNwZWNpZmljIElPTU1VIGltcGxlbWVudGF0aW9u
cywNCj4+PiBidXQgaW5zdGVhZCBjb250cm9sbGVkIGJ5IHRoZSBjb2RlIHdoaWNoIHJlbGllcyBv
biB0aGF0LCBhc3NpZ25fZGV2aWNlLg0KPj4gRmVlbCBmcmVlIHRvIGNvbWUgdXAgd2l0aCBwcm9w
b3NhbHMgaG93IHRvIGNsZWFubHkgZG8gc28uIE1vdmluZyB0aGUNCj4+IGFzc2lnbm1lbnQgdG8g
cGRldi0+ZG9tYWluIG1heSBldmVuIGJlIHBvc3NpYmxlIG5vdywgYnV0IGlmIHlvdSBnbw0KPj4g
YmFjayB5b3UgbWF5IGZpbmQgdGhhdCB0aGUgY29kZSB3YXMgcXVpdGUgZGlmZmVyZW50IGVhcmxp
ZXIgb24uDQo+IEkgZG8gdW5kZXJzdGFuZCB0aGF0IGFzIHRoZSBjb2RlIGV2b2x2ZXMgbmV3IHVz
ZSBjYXNlcyBicmluZw0KPiBuZXcgaXNzdWVzLg0KPj4+IEkgY2FuIGhhdmUgc29tZXRoaW5nIGxp
a2U6DQo+Pj4NCj4+PiBkaWZmIC0tZ2l0IGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvcGNpLmMg
Yi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9wY2kuYw0KPj4+IGluZGV4IDg4ODM2YWFiNmJhZi4u
Y2M3NzkwNzA5YTUwIDEwMDY0NA0KPj4+IC0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3Bj
aS5jDQo+Pj4gKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvcGNpLmMNCj4+PiBAQCAtMTQ3
NSw2ICsxNDc1LDcgQEAgc3RhdGljIGludCBkZXZpY2VfYXNzaWduZWQodTE2IHNlZywgdTggYnVz
LCB1OCBkZXZmbikNCj4+PiAgICDCoHN0YXRpYyBpbnQgYXNzaWduX2RldmljZShzdHJ1Y3QgZG9t
YWluICpkLCB1MTYgc2VnLCB1OCBidXMsIHU4IGRldmZuLCB1MzIgZmxhZykNCj4+PiAgICDCoHsN
Cj4+PiAgICDCoMKgwqDCoCBjb25zdCBzdHJ1Y3QgZG9tYWluX2lvbW11ICpoZCA9IGRvbV9pb21t
dShkKTsNCj4+PiArwqDCoMKgIHN0cnVjdCBkb21haW4gKm9sZF9vd25lcjsNCj4+PiAgICDCoMKg
wqDCoCBzdHJ1Y3QgcGNpX2RldiAqcGRldjsNCj4+PiAgICDCoMKgwqDCoCBpbnQgcmMgPSAwOw0K
Pj4+DQo+Pj4gQEAgLTE0OTAsNiArMTQ5MSw5IEBAIHN0YXRpYyBpbnQgYXNzaWduX2RldmljZShz
dHJ1Y3QgZG9tYWluICpkLCB1MTYgc2VnLCB1OCBidXMsIHU4IGRldmZuLCB1MzIgZmxhZykNCj4+
PiAgICDCoMKgwqDCoCBBU1NFUlQocGRldiAmJiAocGRldi0+ZG9tYWluID09IGhhcmR3YXJlX2Rv
bWFpbiB8fA0KPj4+ICAgIMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAg
cGRldi0+ZG9tYWluID09IGRvbV9pbykpOw0KPj4+DQo+Pj4gK8KgwqDCoCAvKiBXZSBuZWVkIHRv
IHJlc3RvcmUgdGhlIG9sZCBvd25lciBpbiBjYXNlIG9mIGFuIGVycm9yLiAqLw0KPj4+ICvCoMKg
wqAgb2xkX293bmVyID0gcGRldi0+ZG9tYWluOw0KPj4+ICsNCj4+PiAgICDCoMKgwqDCoCB2cGNp
X2RlYXNzaWduX2RldmljZShwZGV2LT5kb21haW4sIHBkZXYpOw0KPj4+DQo+Pj4gICAgwqDCoMKg
wqAgcmMgPSBwZGV2X21zaXhfYXNzaWduKGQsIHBkZXYpOw0KPj4+IEBAIC0xNTE1LDggKzE1MTks
MTIgQEAgc3RhdGljIGludCBhc3NpZ25fZGV2aWNlKHN0cnVjdCBkb21haW4gKmQsIHUxNiBzZWcs
IHU4IGJ1cywgdTggZGV2Zm4sIHUzMiBmbGFnKQ0KPj4+DQo+Pj4gICAgwqAgZG9uZToNCj4+PiAg
ICDCoMKgwqDCoCBpZiAoIHJjICkNCj4+PiArwqDCoMKgIHsNCj4+PiAgICDCoMKgwqDCoMKgwqDC
oMKgIHByaW50ayhYRU5MT0dfR19XQVJOSU5HICIlcGQ6IGFzc2lnbiAoJXBwKSBmYWlsZWQgKCVk
KVxuIiwNCj4+PiAgICDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgZCwgJlBDSV9TQkRG
MyhzZWcsIGJ1cywgZGV2Zm4pLCByYyk7DQo+Pj4gK8KgwqDCoMKgwqDCoMKgIC8qIFdlIGZhaWxl
ZCB0byBhc3NpZ24sIHNvIHJlc3RvcmUgdGhlIHByZXZpb3VzIG93bmVyLiAqLw0KPj4+ICvCoMKg
wqDCoMKgwqDCoCBwZGV2LT5kb21haW4gPSBvbGRfb3duZXI7DQo+Pj4gK8KgwqDCoCB9DQo+Pj4g
ICAgwqDCoMKgwqAgLyogVGhlIGRldmljZSBpcyBhc3NpZ25lZCB0byBkb21faW8gc28gbWFyayBp
dCBhcyBxdWFyYW50aW5lZCAqLw0KPj4+ICAgIMKgwqDCoMKgIGVsc2UgaWYgKCBkID09IGRvbV9p
byApDQo+Pj4gICAgwqDCoMKgwqDCoMKgwqDCoCBwZGV2LT5xdWFyYW50aW5lID0gdHJ1ZTsNCj4+
Pg0KPj4+IEJ1dCBJIGRvIG5vdCB0aGluayB0aGlzIGJlbG9uZ3MgdG8gdGhpcyBwYXRjaA0KPj4g
SW5kZWVkLiBQbHVzIEknbSBzdXJlIHlvdSB1bmRlcnN0YW5kIHRoYXQgaXQncyBub3QgdGhhdCBz
aW1wbGUuIEFzc2lnbmluZw0KPj4gdG8gcGRldi0+ZG9tYWluIGlzIG9ubHkgdGhlIGxhc3Qgc3Rl
cCBvZiBhc3NpZ25tZW50LiBSZXN0b3JpbmcgdGhlIG9yaWdpbmFsDQo+PiBvd25lciB3b3VsZCBl
bnRhaWwgcHV0dGluZyBpbiBwbGFjZSB0aGUgb3JpZ2luYWwgSU9NTVUgdGFibGUgZW50cmllcyBh
cw0KPj4gd2VsbCwgd2hpY2ggaW4gdHVybiBjYW4gZmFpbC4gSGVuY2Ugd2h5IHlvdSdsbCBmaW5k
IGEgbnVtYmVyIG9mIHVzZXMgb2YNCj4+IGRvbWFpbl9jcmFzaCgpIGluIHBsYWNlcyB3aGVyZSBy
b2xsaW5nIGJhY2sgaXMgZmFyIGZyb20gZWFzeS4NCj4gU28sIHdoeSBkb24ndCB3ZSBqdXN0IHJl
bHkgb24gdGhlIHRvb2xzdGFjayB0byBkbyB0aGUgcm9sbCBiYWNrIHRoZW4/DQo+IFRoaXMgd2F5
IHdlIHdvbid0IGFkZCBuZXcgZG9tYWluX2NyYXNoKCkgY2FsbHMuDQo+IEkgZG8gdW5kZXJzdGFu
ZCB0aG91Z2ggdGhhdCB3ZSBtYXkgbGl2ZSBYZW4gaW4gYSB3cm9uZyBzdGF0ZSB0aG91Z2guDQo+
IFNvLCBkbyB5b3UgdGhpbmsgaXQgaXMgcG9zc2libGUgaWYgd2UganVzdCBjYWxsIGRlYXNzaWdu
X2RldmljZSBmcm9tDQo+IGFzc2lnbl9kZXZpY2Ugb24gdGhlIGVycm9yIHBhdGg/IFRoaXMgaXMg
anVzdCBsaWtlIEkgZG8gaW4gdnBjaV9hc3NpZ25fZGV2aWNlOg0KPiBJIGNhbGwgdnBjaV9kZWFz
c2lnbl9kZXZpY2UgaWYgdGhlIGZvcm1lciBmYWlscy4NCldpdGggdGhlIGZvbGxvd2luZyBhZGRp
dGlvbjoNCg0KZGlmZiAtLWdpdCBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3BjaS5jIGIveGVu
L2RyaXZlcnMvcGFzc3Rocm91Z2gvcGNpLmMNCmluZGV4IGM0YWUyMmFlZWZjZC4uZDZjMDA0NDkx
OTNjIDEwMDY0NA0KLS0tIGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvcGNpLmMNCisrKyBiL3hl
bi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3BjaS5jDQpAQCAtMTUxMSw2ICsxNTExLDEyIEBAIHN0YXRp
YyBpbnQgYXNzaWduX2RldmljZShzdHJ1Y3QgZG9tYWluICpkLCB1MTYgc2VnLCB1OCBidXMsIHU4
IGRldmZuLCB1MzIgZmxhZykNCiDCoMKgwqDCoCB9DQoNCiDCoMKgwqDCoCByYyA9IHZwY2lfYXNz
aWduX2RldmljZShwZGV2KTsNCivCoMKgwqAgaWYgKCByYyApDQorwqDCoMKgwqDCoMKgwqAgLyoN
CivCoMKgwqDCoMKgwqDCoMKgICogSWdub3JlIHRoZSByZXR1cm4gY29kZSBhcyB3ZSB3YW50IHRv
IHByZXNlcnZlIHRoZSBvbmUgZnJvbSB0aGUNCivCoMKgwqDCoMKgwqDCoMKgICogZmFpbGVkIGFz
c2lnbiBvcGVyYXRpb24uDQorwqDCoMKgwqDCoMKgwqDCoCAqLw0KK8KgwqDCoMKgwqDCoMKgIGRl
YXNzaWduX2RldmljZShkLCBzZWcsIGJ1cywgZGV2Zm4pOw0KDQogwqAgZG9uZToNCiDCoMKgwqDC
oCBpZiAoIHJjICkNCg0KSSBzZWUgdGhlIGZvbGxvd2luZyBsb2dzIChQViBEb20wKToNCg0KKFhF
TikgYXNzaWduX2RldmljZSBzZWcgMCBidXMgMyBkZXZmbiAwDQooWEVOKSBbVlQtRF1kW0lPXTpQ
Q0llOiB1bm1hcCAwMDAwOjAzOjAwLjANCihYRU4pIFtWVC1EXWQ0OlBDSWU6IG1hcCAwMDAwOjAz
OjAwLjANCihYRU4pIGFzc2lnbl9kZXZpY2UgdnBjaV9hc3NpZ24gcmMgLTIyIGZyb20gZFtJT10g
dG8gZDQNCihYRU4pIGRlYXNzaWduX2RldmljZSBjdXJyZW50IGQ0IHRvIGRbSU9dDQooWEVOKSBb
VlQtRF1kNDpQQ0llOiB1bm1hcCAwMDAwOjAzOjAwLjANCihYRU4pIFtWVC1EXWRbSU9dOlBDSWU6
IG1hcCAwMDAwOjAzOjAwLjANCihYRU4pIGRlYXNzaWduX2RldmljZSByZXQgMA0KKFhFTikgZDQ6
IGFzc2lnbiAoMDAwMDowMzowMC4wKSBmYWlsZWQgKC0yMikNCmxpYnhsOiBlcnJvcjogbGlieGxf
cGNpLmM6MTQ5ODpwY2lfYWRkX2RtX2RvbmU6IERvbWFpbiA0OnhjX2Fzc2lnbl9kZXZpY2UgZmFp
bGVkOiBJbnZhbGlkIGFyZ3VtZW50DQpsaWJ4bDogZXJyb3I6IGxpYnhsX3BjaS5jOjE3ODE6ZGV2
aWNlX3BjaV9hZGRfZG9uZTogRG9tYWluIDQ6bGlieGxfX2RldmljZV9wY2lfYWRkIGZhaWxlZCBm
b3IgUENJIGRldmljZSAwOjM6MC4wIChyYyAtMykNCmxpYnhsOiBlcnJvcjogbGlieGxfY3JlYXRl
LmM6MTg5NTpkb21jcmVhdGVfYXR0YWNoX2RldmljZXM6IERvbWFpbiA0OnVuYWJsZSB0byBhZGQg
cGNpIGRldmljZXMNCmxpYnhsOiBlcnJvcjogbGlieGxfZG9tYWluLmM6MTE4MzpsaWJ4bF9fZGVz
dHJveV9kb21pZDogRG9tYWluIDQ6Tm9uLWV4aXN0YW50IGRvbWFpbg0KbGlieGw6IGVycm9yOiBs
aWJ4bF9kb21haW4uYzoxMTM3OmRvbWFpbl9kZXN0cm95X2NhbGxiYWNrOiBEb21haW4gNDpVbmFi
bGUgdG8gZGVzdHJveSBndWVzdA0KbGlieGw6IGVycm9yOiBsaWJ4bF9kb21haW4uYzoxMDY0OmRv
bWFpbl9kZXN0cm95X2NiOiBEb21haW4gNDpEZXN0cnVjdGlvbiBvZiBkb21haW4gZmFpbGVkDQoN
ClNvLCBpdCBzZWVtcyB0byBwcm9wZXJseSBzb2x2ZSB0aGUgaXNzdWUgd2l0aCBwZGV2LT5kb21h
aW4gbGVmdA0Kc2V0IHRvIHRoZSBkb21haW4gd2UgY291bGRuJ3QgY3JlYXRlLg0KDQpASmFuLCB3
aWxsIHRoaXMgYWRkcmVzcyB5b3VyIGNvbmNlcm4/DQoNClRoYW5rIHlvdSwNCk9sZWtzYW5kcg==


From xen-devel-bounces@lists.xenproject.org Thu Feb 10 08:32:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 10 Feb 2022 08:32:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269651.463728 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nI4s6-0006mQ-IE; Thu, 10 Feb 2022 08:32:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269651.463728; Thu, 10 Feb 2022 08:32:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nI4s6-0006mJ-DI; Thu, 10 Feb 2022 08:32:10 +0000
Received: by outflank-mailman (input) for mailman id 269651;
 Thu, 10 Feb 2022 08:29:40 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=zl0S=SZ=vivo.com=wangqing@srs-se1.protection.inumbo.net>)
 id 1nI4pg-0005zC-JK
 for xen-devel@lists.xenproject.org; Thu, 10 Feb 2022 08:29:40 +0000
Received: from APC01-PSA-obe.outbound.protection.outlook.com
 (mail-psaapc01on2072b.outbound.protection.outlook.com
 [2a01:111:f400:feae::72b])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 943bdc77-8a4b-11ec-8eb8-a37418f5ba1a;
 Thu, 10 Feb 2022 09:29:38 +0100 (CET)
Received: from SL2PR06MB3082.apcprd06.prod.outlook.com (2603:1096:100:37::17)
 by PSAPR06MB4005.apcprd06.prod.outlook.com (2603:1096:301:3a::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Thu, 10 Feb
 2022 08:29:32 +0000
Received: from SL2PR06MB3082.apcprd06.prod.outlook.com
 ([fe80::80b4:e787:47a9:41bb]) by SL2PR06MB3082.apcprd06.prod.outlook.com
 ([fe80::80b4:e787:47a9:41bb%4]) with mapi id 15.20.4975.011; Thu, 10 Feb 2022
 08:29:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 943bdc77-8a4b-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=OV3YHnXHBZ9UtqzcjCgQCWg70dU95Am2kfUYz8vBlifcarW/JGeyye7wFCcW6Z2nZvlhJ3Qc0np/5tty68+yUdIDrwGtwiKi07C+yqqHzyY+mM/0pVjNQjFe+O3KRpTFmtHR6p/pFHfqMHnuesFaMnHIGYxKsM+AnsoTLXahMT92uCtKXtqZxFIJRBbjO9Hi8k481IkFSHaOsTaINiZ6Pp5rF43z9+zxfBGxC+OqxOh8keG0AjNJphTDpNZmBJ0hQU554QgK50VyCos3nXyasACKLJELUgun/o77Qvxs+Cq6zr38h1MM9gjAhIWPooWFOfPeKOlD3/0+I2P3wPo6wA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=vMLJbdOpfHG63MP8VB14fg4rzHqLyuvfrpbIjSDncH8=;
 b=h4tyTpJGmQ1eRcdcSb/RDwf8pOBkEiJfkOJqYc9k2VlNltjtugwx4JbFm3uaLOMubCrYwKdCm+wv9Yt8uyIXcjoa9mgD9iPwGT+uIRF45PBW0loPz769CcfQQYnrz2RXa2wW/j6/xq2Wxio3Nwy4KweOwzFqabF68SsIjVzVWTrAXX+HbkWSXt+jpyWFuGHkZXMTl56q/FwCAVGmwSy0n/cNZF75gwx99CkJwF2NiNtu8ZvLeXuDr+obIg3zMDC40wjcaYBZNvVYliPxUByBZ0XF39C4iEhXLkxEiBL+ZtIZkxV7lrJ5TDHV07tWIkzMplHJmN/qSLX228kv4Tg0/g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo0.onmicrosoft.com;
 s=selector2-vivo0-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=vMLJbdOpfHG63MP8VB14fg4rzHqLyuvfrpbIjSDncH8=;
 b=p1/MvgAiU4KAzA0ncIy8ojKqA4u+apylv4nLDAXNobKZAhTWwTsJVzSZfWmb1Jm5VW1UUu5W3E9VwvhGG5+RtNQaqUtxhwygRC6eZ1cHjGAk98h+dlI/SZkPc9bANhLGMsDFzwNHKGhtt8cavLM6f8weLQnr8j/HfrXYbfpo55w=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=vivo.com;
From: Qing Wang <wangqing@vivo.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Jens Axboe <axboe@kernel.dk>,
	xen-devel@lists.xenproject.org,
	linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: Wang Qing <wangqing@vivo.com>
Subject: [PATCH] block: xen: use time_after_eq() instead of jiffies judgment
Date: Thu, 10 Feb 2022 00:29:23 -0800
Message-Id: <1644481765-14435-1-git-send-email-wangqing@vivo.com>
X-Mailer: git-send-email 2.7.4
Content-Type: text/plain
X-ClientProxiedBy: HKAPR04CA0006.apcprd04.prod.outlook.com
 (2603:1096:203:d0::16) To SL2PR06MB3082.apcprd06.prod.outlook.com
 (2603:1096:100:37::17)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 3e07e6ef-8ee4-4f1b-b504-08d9ec6f7608
X-MS-TrafficTypeDiagnostic: PSAPR06MB4005:EE_
X-Microsoft-Antispam-PRVS:
	<PSAPR06MB4005B79F3FE0EA98362C655ABD2F9@PSAPR06MB4005.apcprd06.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1284;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	gYhCSwONbXwpQvV/K83FwTHKx+g4rBUrJPxa5k3v456D9+YorC2ygNjsvfuwUp0Rbr73l6YVVL9jKflkeznbd7i8nZdINUEa7p+W7I/WwO5NCSUz4QrNFm3SkFGONJh4VB7bLKUzxUGE9xA71wR4L85dwB3NMi1r7KkxlanIP1m1PFEksB8fus21ypBFM0M086e2uZTbdrsX+cp2/BeT5MrGyIVMYAfO4UBmu8uwAmjv/7yiRlPQkSICXVxDA2GknhoExdTYZUvWFXM9c7rcCxdcIEWDkgPAyGbSdah1H2tWazftelDr/Alyp8Mxd3WNwGGD8VM9ScMA1T9+rFc0bKAtH6YUhN9VbIYzfIHOWuNDExs5E5WqlVeBqBO4RfgJNlVx81GrgTb6qW0WD0G2M+l7NgNZbSZFXaIiAVWWBQegMcxAI1EvmhqvK1ci7Xw/BvtF1axSA4lHD92MJuWkgC6/VNt9xUd4ZesYSQh0RN9jSWXpSlDHO3Rzf07Nco/E9VtkAa5jtc2lDQLddFNUQyVO0JzcawX4krreOnyvLFJ7bGg9x+jkDcngAbHtQlc4o5QlWnR3f6Ip80PJM4W3JETq47yKNhr9wnD1UEUrwrGDdXuQJSoQa1mdJr2OQD1citrkoHwHctsNKwUuGot5dA==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SL2PR06MB3082.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(2906002)(8676002)(66946007)(5660300002)(52116002)(8936002)(38100700002)(38350700002)(66556008)(6666004)(6512007)(6506007)(4326008)(6486002)(316002)(186003)(2616005)(110136005)(36756003)(86362001)(508600001)(83380400001)(107886003)(26005)(66476007)(21314003);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	9jjklfMSt33jCOQuhnw1XSRiFo390ZAaUqzq3NvQWiQNv13AgOh7D58PvSHic3hJ8QLXqCp3M3AmeihmWLthw/acdeunEDbl+F450jJs1QwcBvQtpdIvzD5r/7M8c8CjVMNwkF9YYQVuQJm5r46KLC08Z76GwOQ/0gl1flc9ekvEvUqCOsgLI2MTWM2pCCtIkaDaz9x8+IK0f9mMoIGzrSIW55sDQfWLkYixqGE9GDhmptuKKznWY2NtjkGCdHUHWbu98EM/NAhW0DyOcxZuh2iV3dWkh35hGPAxPVfVAgJNgiCNU91UuwKbO9GePWlyvJw9CxcefG3LbYokLYInfF/NDrGDeYoZehsXCowy3VlF8wKR5nc3/sMIwEMampa3xeZ7kEi0mFL0M9GkPRqX8lczoIy90v2JSbpLKGuo18BfN91hub3Op75Ghg/f7JLz
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3e07e6ef-8ee4-4f1b-b504-08d9ec6f7608
X-MS-Exchange-CrossTenant-AuthSource: SL2PR06MB3082.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2022 08:29:31.9973
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VXKod2lep4QackxmebRQK8TyNiTGqztyAvapjB/v4wF39WAdlGcvtmbbZKuMARgnlCBPpwZtI4YFjkwZSxUvsg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PSAPR06MB4005

From: Wang Qing <wangqing@vivo.com>

It is better to use time_xxx() directly instead of jiffies judgment
for understanding.

Signed-off-by: Wang Qing <wangqing@vivo.com>
---
 drivers/block/xen-blkback/blkback.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/block/xen-blkback/blkback.c b/drivers/block/xen-blkback/blkback.c
index d1e2646..aecc1f4
--- a/drivers/block/xen-blkback/blkback.c
+++ b/drivers/block/xen-blkback/blkback.c
@@ -42,6 +42,7 @@
 #include <linux/delay.h>
 #include <linux/freezer.h>
 #include <linux/bitmap.h>
+#include <linux/jiffies.h>
 
 #include <xen/events.h>
 #include <xen/page.h>
@@ -134,8 +135,8 @@ module_param(log_stats, int, 0644);
 
 static inline bool persistent_gnt_timeout(struct persistent_gnt *persistent_gnt)
 {
-	return pgrant_timeout && (jiffies - persistent_gnt->last_used >=
-			HZ * pgrant_timeout);
+	return pgrant_timeout &&
+			time_after_eq(jiffies, persistent_gnt->last_used + HZ * pgrant_timeout);
 }
 
 #define vaddr(page) ((unsigned long)pfn_to_kaddr(page_to_pfn(page)))
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Thu Feb 10 08:32:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 10 Feb 2022 08:32:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269653.463738 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nI4sI-00076b-Oz; Thu, 10 Feb 2022 08:32:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269653.463738; Thu, 10 Feb 2022 08:32:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nI4sI-00076U-Lr; Thu, 10 Feb 2022 08:32:22 +0000
Received: by outflank-mailman (input) for mailman id 269653;
 Thu, 10 Feb 2022 08:32:21 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Layc=SZ=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1nI4sH-00075Y-Cf
 for xen-devel@lists.xenproject.org; Thu, 10 Feb 2022 08:32:21 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05on2061d.outbound.protection.outlook.com
 [2a01:111:f400:7e1b::61d])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f5f9fdfa-8a4b-11ec-8eb8-a37418f5ba1a;
 Thu, 10 Feb 2022 09:32:19 +0100 (CET)
Received: from AS8PR07CA0050.eurprd07.prod.outlook.com (2603:10a6:20b:459::7)
 by AM0PR08MB5124.eurprd08.prod.outlook.com (2603:10a6:208:161::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Thu, 10 Feb
 2022 08:32:16 +0000
Received: from VE1EUR03FT027.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:459:cafe::a9) by AS8PR07CA0050.outlook.office365.com
 (2603:10a6:20b:459::7) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.6 via Frontend
 Transport; Thu, 10 Feb 2022 08:32:16 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT027.mail.protection.outlook.com (10.152.18.154) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4975.11 via Frontend Transport; Thu, 10 Feb 2022 08:32:15 +0000
Received: ("Tessian outbound 1f399c739551:v113");
 Thu, 10 Feb 2022 08:32:15 +0000
Received: from 8fc8ec649c53.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 AC366E21-794B-4B5F-98D6-439D088971D5.1; 
 Thu, 10 Feb 2022 08:32:08 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8fc8ec649c53.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 10 Feb 2022 08:32:08 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by VI1PR08MB3614.eurprd08.prod.outlook.com (2603:10a6:803:85::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Thu, 10 Feb
 2022 08:32:06 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::aca7:79c4:fa65:dac6]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::aca7:79c4:fa65:dac6%4]) with mapi id 15.20.4951.019; Thu, 10 Feb 2022
 08:32:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f5f9fdfa-8a4b-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=k1YE3qSfKzpjZtg4+cS5OtlFt5WFA204Qbe0ARjTYVA=;
 b=4y7fVrqA4M5xl8gR9Bm2t6GSqhMWJVsjETLgoRX9KYiI/1RmaNt/4zKBn9ACBXxf/n8Dm3qQ1/idFQWLHx9uvQ3qBT3A+40V9EdxGoEFSubenCxgSf5FGLUeLj71rPjlS4SHlZfDnRm+6nlf0NzsLBCID8QZT7y0I18kqggTnn8=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: bf0dedbfaf104519
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Hn7WUnMN4MvfXoY0SbSY12+pnT8kax/ouFwaPK+r8Psfv6S4Q4HmJtjpd/0LtDEJpTScXWyhKi6Vyg8EKF5f3DjA0X7wkPRzhDoPVpjAmg+MuknrsF/0M9mDDL30a6A0j+jrW7TJFBWcP6qceIC5QzaQeDIUDfM7C0ufkj485Sz3k1I9w03+H3vY8ho6bML9OjEVq7BFmMe7Y0BrDyu18AcBnDZj4cVVI3ySo86gNuETOHhjO6O4gQCNTTPjhI6+l1ALwXQnGW+g+bNO9OgfKdPyWgMEdZ8tmawJr1Z2w2/eh1OnDtxUV/frvZbYKcDq8BBuKb6hpxmnSPE7I3mhdA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=k1YE3qSfKzpjZtg4+cS5OtlFt5WFA204Qbe0ARjTYVA=;
 b=CxTxXw1XhGK/8XjX9uvfGp5jp+7XgN+68DdYUrzVhnGgKDnQUk6ByzOEb1LBmOGHJzYivoK1t0a/v+03a+8J+BhAB9JwWulGzoLEN26FpG5b3MFy+Qzagqt3IlWhnTyy66Bj2zgC8hgrKgMn1K9ZPaeNxfmf+Sleaaa7I+jHUXKzT5GqswqMaZvJmqNz4JgVqOofiH/Yl7fTsPcu8nS6lWuCyxWmqLnb4pjqVKruAukbV1MWMfgXumrVaqn1dkyXNVZOR6T8VVezHdYuGEskSCLfM7AS7Duu3g/+peKnGAy87sfukNeE5wCFvEAoMjP0b0ZeFFKM8HqbKKRiSXPRSA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=k1YE3qSfKzpjZtg4+cS5OtlFt5WFA204Qbe0ARjTYVA=;
 b=4y7fVrqA4M5xl8gR9Bm2t6GSqhMWJVsjETLgoRX9KYiI/1RmaNt/4zKBn9ACBXxf/n8Dm3qQ1/idFQWLHx9uvQ3qBT3A+40V9EdxGoEFSubenCxgSf5FGLUeLj71rPjlS4SHlZfDnRm+6nlf0NzsLBCID8QZT7y0I18kqggTnn8=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: tosher 1 <akm2tosher@yahoo.com>
CC: Jan Beulich <jbeulich@suse.com>, "roger.pau@citrix.com"
	<roger.pau@citrix.com>, "xadimgnik@gmail.com" <xadimgnik@gmail.com>,
	"oleksandr_andrushchenko@epam.com" <oleksandr_andrushchenko@epam.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: PCI passthrough support for PVH mode
Thread-Topic: PCI passthrough support for PVH mode
Thread-Index: AQHYGx832+ucoEGI2UqojmxHytIiMKyHuoSAgAStNACAABNoAA==
Date: Thu, 10 Feb 2022 08:32:06 +0000
Message-ID: <2CDAD7A1-A628-4491-9DE0-1F4D5D9FF1A7@arm.com>
References: <709142925.628001.1644127197288.ref@mail.yahoo.com>
 <709142925.628001.1644127197288@mail.yahoo.com>
 <0e64c52c-1e9c-e89b-abb8-50171d885926@suse.com>
 <303292590.682317.1644477758255@mail.yahoo.com>
In-Reply-To: <303292590.682317.1644477758255@mail.yahoo.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3693.60.0.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 8d91019b-69bd-4901-c7e6-08d9ec6fd818
x-ms-traffictypediagnostic:
	VI1PR08MB3614:EE_|VE1EUR03FT027:EE_|AM0PR08MB5124:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR08MB51245FA1C4BDEF8766EB1EF19D2F9@AM0PR08MB5124.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 bY+cFZOWNcBDr8391QvBdYdFp7tYRqUYOgXr8O7VGmDW6Jd04YSvhZrJlp72QBJfXQlEB7/TV66Yk2rpgmSToeHhR1bGYiXRHXN7q1ftMdqLK3fCiMUa5PK2xTWO7x40SGdumTkQTpiaIoEi7itwCExaqk2W/1VwVrvjuoMqOC21AaogiWAf/ne+MFVA2EAJ5C4vFN8HV5McXUT69KS5I4MSsulCY/9Xb1MDpyx9UauwEXVrG+ao3R/LdgVynXNJUcMvROZdEoc5VXUIRkxrLnSfvj6BLgX3Irwr32PSj+WwoWQnfaTkbsQYefChS5Mq0zJEnmbvQACGb44eNR0vPlYZbWCqIB3Jw+EJlSCuGH3qK3SYGe60D4vAQhJ6Igdhi2KD59WY/INep53rjvDBvBde8h8lNn0HH5ihRIEnAx6ioK6Jf5tEDJCKyFrX9L8CBPwM9APqWfI8WrZ2r3xQImXMg+II7J1QYbnnU894rYTuS7ebmt9Gqrjw4n6JXI1a4KYxd8Lvku4dmTq0KQQB9Cf8/lJ+F5hLScMFYbnQ2Ieiotgl06AmChgNGvIr8YocVuAxpoqQSMUJjV1KBZiu06EcclI6zYiftBge1i/5Bf/9svAgV0lrpzrIXUtAjhtn8gbzScF+V0SZiqaNAWNnkAyurW7R78htCVJFg4GhyJ7E4WuMJzhkA5xrN4K8pjO8m1d7pQVqjk23yq5P/UMoMR/JsbaH9XRSI3GW5IAnrX4=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66556008)(64756008)(5660300002)(53546011)(66476007)(86362001)(38100700002)(66446008)(8936002)(6486002)(6506007)(8676002)(6512007)(4326008)(91956017)(83380400001)(316002)(76116006)(2616005)(2906002)(38070700005)(36756003)(54906003)(6916009)(66946007)(508600001)(122000001)(33656002)(186003)(71200400001)(26005)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <5560930DB568634F81CEA828114A007F@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3614
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT027.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	25a669aa-4209-46d5-b471-08d9ec6fd27e
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	2A6cKTn9M2GDTJC4gv1dJr+8O41YPdPt/LEVQ3zTtOSpRmoeUcVGFFSAm5NSFE2m1bN4w+x15PCCOzOrHaytmQl3L3RVcfZ1ih7IGCZajnAtU6dR8lZYXULMABZUDiNxJ09y9ID7Bf+jReAk2nXKc9oI8nRBy0jF3JOIoZm6U7JeXbtI5I4WKs3oDkLRgKjsJpb5KmFM6U+2Tc6csGRest57JTshF39C/bCbYpkjp1Yg7Qaht15T8vp4/sEHOBOQg5o2O+cgLRxyE0ctTQgdx2vLPPUe84Fr6APD3oOcYpez27xMXqCR2TuyHBqxbBB+pzWS9gjk72YQZdeWNtzZ58KV4o4q9cvBGvu/nQxGCvKOqNBLLQNIMZGZhXyy9WreFBi2NcwSpzuym+oXlGzAYoxmu7e6iB4ysSlY7Pt72g3mNG4dHVP5uol1iQZufjQQJHpaFCb4AFowkE039tBdZdogm3qHGA56InmPb0GKb2bOgQvLZzXHVxAfT+su1kGRBBe7bQRCUekmbqNZqfX6YYDF9JabLCkgBO1dwCKnKFDS68GIWnm+Azb+xS/+gtzhfqYjYfjm/wl5azXKSu3q3/v97pMzyS5q0nXzZV0DEnhy6t9IQfEOxKmbC/CzPZb4ZocbWC3HYe5cviMxwB5frqOFRIPt6GpUevwNfj6Qrtk=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(6862004)(508600001)(5660300002)(2616005)(6486002)(2906002)(54906003)(70586007)(316002)(356005)(36756003)(33656002)(8676002)(8936002)(70206006)(4326008)(26005)(6512007)(53546011)(6506007)(81166007)(86362001)(47076005)(83380400001)(40460700003)(336012)(82310400004)(186003)(36860700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2022 08:32:15.9569
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 8d91019b-69bd-4901-c7e6-08d9ec6fd818
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT027.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5124

SGkgTWlocmFiLA0KDQo+IE9uIDEwIEZlYiAyMDIyLCBhdCAwNzoyMiwgdG9zaGVyIDEgPGFrbTJ0
b3NoZXJAeWFob28uY29tPiB3cm90ZToNCj4gDQo+IEhpIEphbiwNCj4gDQo+IFRoYW5rcyBmb3Ig
bGV0dGluZyBtZSBrbm93IHRoaXMgc3RhdHVzLg0KPiANCj4gSSBhbSB3b25kZXJpbmcgaWYgUENJ
IHBhc3N0aHJvdWdoIGlzIGF0IGxlYXN0IGF2YWlsYWJsZSBpbiBBcm0gZm9yIG90aGVyIHZpcnR1
YWxpemF0aW9uIG1vZGVzIGxpa2UgUFYsIEhWTSwgb3IgUFZIVk0uIEZvciBleGFtcGxlLCBpcyBp
dCBwb3NzaWJsZSBmb3Igc29tZW9uZSB0byBhdHRhY2ggYSBQQ0kgZGV2aWNlIHRvIGEgZ3Vlc3Qg
ZG9tYWluIG9uIGFuIEFybSBtYWNoaW5lIGFuZCB1c2UgdGhhdCBkb21haW4gYXMgYSBkcml2ZXIg
ZG9tYWluLCBsaWtlIHdlIGNhbiBkbyB3aXRoIHRoZSBYZW4gb24geDg2Pw0KDQpPbiBhcm0gdGhl
cmUgaXMgb25seSBvbmUgdmlydHVhbGl6YXRpb24gbW9kZSB3aGljaCBpcyBlcXVpdmFsZW50IHRv
IHg4NiBIVk0uDQoNClJlZ2FyZGluZyBQQ0kgcGFzc3Rocm91Z2ggb24gYXJtLCB0aGlzIGlzIGN1
cnJlbnRseSBhIHdvcmsgaW4gcHJvZ3Jlc3MgdGhhdCBpcyBiZWluZyB1cHN0cmVhbSBzbyBpdCBp
cyBub3QgYXZhaWxhYmxlIGZvciBub3cuDQpPbmNlIGl0IHdpbGwgYmUgbWVyZ2VkIGluIFhlbiwg
aXQgd2lsbCBiZSBwb3NzaWJsZSB0byBhc3NpZ24gYSBQQ0kgZGV2aWNlIHRvIGEgZ3Vlc3Qgc28g
eW91IGNvdWxkIHRoZW4gbWFrZSBhIOKAnGRyaXZlciBkb21haW7igJ0gdXNpbmcgdGhlIGZ1bmN0
aW9uYWxpdHkuDQoNClJlZ2FyZHMNCkJlcnRyYW5kDQoNCj4gDQo+IFBsZWFzZSBsZXQgbWUga25v
dy4NCj4gDQo+IFJlZ2FyZHMsDQo+IE1laHJhYg0KPiANCj4gDQo+IA0KPiANCj4gT24gTW9uZGF5
LCBGZWJydWFyeSA3LCAyMDIyLCAwMjo1Nzo0NSBBTSBFU1QsIEphbiBCZXVsaWNoIDxqYmV1bGlj
aEBzdXNlLmNvbT4gd3JvdGU6IA0KPiANCj4gDQo+IA0KPiANCj4gDQo+IE9uIDA2LjAyLjIwMjIg
MDY6NTksIHRvc2hlciAxIHdyb3RlOg0KPiANCj4+IEJhY2sgaW4gdGhlIHllYXIgMjAyMCwgSSB3
YXMgaW5xdWlyaW5nIGludG8gdGhlIHN0YXR1cyBvZiBQQ0kgcGFzc3Rocm91Z2ggc3VwcG9ydCBm
b3IgUFZIIGd1ZXN0cy4gQXQgdGhhdCB0aW1lLCBBcm0gcGVvcGxlIHdlcmUgd29ya2luZyBvbiB1
c2luZyB2UENJIGZvciBndWVzdCBWTXMuIFRoZSBleHBlY3RhdGlvbiB3YXMgdG8gcG9ydCB0aGF0
IGltcGxlbWVudGF0aW9uIHRvIHg4NiBvbmNlIHJlYWR5Lg0KPj4gDQo+PiBJIHdhcyB3b25kZXJp
bmcgaWYgdGhlcmUgaXMgYW55IHVwZGF0ZSBvbiB0aGlzLiBEb2VzIFhlbiBzdXBwb3J0IFBDSSBw
YXNzdGhyb3VnaCBmb3IgUFZIIG1vZGUgeWV0PyBQbGVhc2UgbGV0IG1lIGtub3cuDQo+IA0KPiAN
Cj4gVGhlIEFybSB3b3JrIGlzIHN0aWxsIFdJUCwgYW5kIGluIGhvdyBmYXIgaXQncyBnb2luZyB0
byBiZSBzdHJhaWdodGZvcndhcmQgdG8NCj4gcmUtdXNlIHRoYXQgY29kZSBmb3IgeDg2IGlzIHN0
aWxsIHVuY2xlYXIgKGFmYWljdCBhdCBsZWFzdCkuDQo+IA0KPiBKYW4NCj4gDQo+IA0KPiANCg0K


From xen-devel-bounces@lists.xenproject.org Thu Feb 10 08:45:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 10 Feb 2022 08:45:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269673.463750 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nI54f-0000Tu-VW; Thu, 10 Feb 2022 08:45:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269673.463750; Thu, 10 Feb 2022 08:45:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nI54f-0000Tn-SN; Thu, 10 Feb 2022 08:45:09 +0000
Received: by outflank-mailman (input) for mailman id 269673;
 Thu, 10 Feb 2022 08:45:08 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=peag=SZ=irit.fr=dinhngoc.tu@srs-se1.protection.inumbo.net>)
 id 1nI54e-0000Th-EK
 for xen-devel@lists.xenproject.org; Thu, 10 Feb 2022 08:45:08 +0000
Received: from smtp1.irit.fr (smtp1.irit.fr [141.115.24.2])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id bea422aa-8a4d-11ec-8f75-fffcc8bd4f1a;
 Thu, 10 Feb 2022 09:45:06 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bea422aa-8a4d-11ec-8f75-fffcc8bd4f1a
From: Tu Dinh Ngoc <dinhngoc.tu@irit.fr>
To: xen-devel@lists.xenproject.org
Cc: Tu Dinh Ngoc <dinhngoc.tu@irit.fr>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Wei Liu <wl@xen.org>
Subject: [PATCH v3] x86: Prioritize low memory size from Multiboot
Date: Thu, 10 Feb 2022 09:44:36 +0100
Message-Id: <20220210084436.84-1-dinhngoc.tu@irit.fr>
In-Reply-To: <000c01d81dcae25e6f0irit.fr>
References: <000c01d81dcae25e6f0irit.fr>
Content-Transfer-Encoding: 8bit

Previously, Xen used information from the BDA to detect the amount of
available low memory. This does not work on some scenarios such as
Coreboot, or when booting from Kexec on a UEFI system without CSM.

Prioritize the information supplied by Multiboot instead. If this is not
available, fall back to the old BDA method.

Signed-off-by: Tu Dinh Ngoc <dinhngoc.tu@irit.fr>
---
Changes in v3:
- Prioritize using Multiboot's memory information.. Fall back to using
  BDA in case MBI does not supply memory info.

Changes in v2:
- Detect if Multiboot claims there's more than 640 KB of low memory
  (happens with old Kexec versions), and correct the memory unit in such
  cases.
---
 xen/arch/x86/boot/head.S | 44 ++++++++++++++++++++++++++--------------
 1 file changed, 29 insertions(+), 15 deletions(-)

diff --git a/xen/arch/x86/boot/head.S b/xen/arch/x86/boot/head.S
index dd1bea0d10..da7810060e 100644
--- a/xen/arch/x86/boot/head.S
+++ b/xen/arch/x86/boot/head.S
@@ -524,27 +524,41 @@ trampoline_bios_setup:
         mov     %ecx,%fs
         mov     %ecx,%gs
 
-        /* Set up trampoline segment 64k below EBDA */
-        movzwl  0x40e,%ecx          /* EBDA segment */
-        cmp     $0xa000,%ecx        /* sanity check (high) */
-        jae     0f
-        cmp     $0x4000,%ecx        /* sanity check (low) */
-        jae     1f
+        /* Check if Multiboot provides us with low memory size. */
+        mov     %edx,%ecx
+        test    %ecx,%ecx
+        jz      1f
+
+        /*
+         * Old Kexec used to report memory sizes in bytes instead of kilobytes
+         * like it's supposed to.
+         *
+         * If Multiboot reports more than 640 KB of low memory, assume we have
+         * this problem.
+         */
+        cmp     $640,%ecx
+        jbe     0f
+        shr     $10,%ecx
 0:
-        movzwl  0x413,%ecx          /* use base memory size on failure */
+        /* %ecx now contains the low memory size in kilobytes. */
         shl     $10-4,%ecx
+        jmp     3f
+
 1:
         /*
-         * Compare the value in the BDA with the information from the
-         * multiboot structure (if available) and use the smallest.
+         * Multiboot doesn't provide us with memory info. Set up trampoline
+         * segment 64k below EBDA as fallback.
          */
-        cmp     $0x100,%edx         /* is the multiboot value too small? */
-        jb      2f                  /* if so, do not use it */
-        shl     $10-4,%edx
-        cmp     %ecx,%edx           /* compare with BDA value */
-        cmovb   %edx,%ecx           /* and use the smaller */
-
+        movzwl  0x40e,%ecx          /* EBDA segment */
+        cmp     $0xa000,%ecx        /* sanity check (high) */
+        jae     2f
+        cmp     $0x4000,%ecx        /* sanity check (low) */
+        jae     3f
 2:
+        movzwl  0x413,%ecx          /* use base memory size on failure */
+        shl     $10-4,%ecx
+
+3:
         /* Reserve memory for the trampoline and the low-memory stack. */
         sub     $((TRAMPOLINE_SPACE+TRAMPOLINE_STACK_SPACE)>>4),%ecx
 
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Thu Feb 10 09:22:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 10 Feb 2022 09:22:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269684.463760 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nI5eb-0004bW-Qs; Thu, 10 Feb 2022 09:22:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269684.463760; Thu, 10 Feb 2022 09:22:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nI5eb-0004bP-Nb; Thu, 10 Feb 2022 09:22:17 +0000
Received: by outflank-mailman (input) for mailman id 269684;
 Thu, 10 Feb 2022 09:22:17 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=4tMu=SZ=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nI5eb-0004b3-4K
 for xen-devel@lists.xenproject.org; Thu, 10 Feb 2022 09:22:17 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ef20a77d-8a52-11ec-8f75-fffcc8bd4f1a;
 Thu, 10 Feb 2022 10:22:14 +0100 (CET)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2058.outbound.protection.outlook.com [104.47.12.58]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-2-AEaLfFvpM4KbpJYQSY00UA-1; Thu, 10 Feb 2022 10:22:13 +0100
Received: from AM0PR04MB5587.eurprd04.prod.outlook.com (2603:10a6:208:125::12)
 by VI1PR04MB7039.eurprd04.prod.outlook.com (2603:10a6:800:12b::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Thu, 10 Feb
 2022 09:22:10 +0000
Received: from AM0PR04MB5587.eurprd04.prod.outlook.com
 ([fe80::54e:e7d:545a:da84]) by AM0PR04MB5587.eurprd04.prod.outlook.com
 ([fe80::54e:e7d:545a:da84%3]) with mapi id 15.20.4951.019; Thu, 10 Feb 2022
 09:22:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ef20a77d-8a52-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644484934;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=bnm/H72y2MrYyAYP53FxMjHgDhZhSxl7/SLWaEHAAMc=;
	b=XCJMR+ZlSWpy+naqmzWL2VsTr8l52mXdEdMGZ2tvnbt/WXK5vQ+qB0LeCY6krm3q/CnORc
	CHsHc78GpRThyzngfCw7aLBrpsNtMzlBIdEBzlnxLSETzLNTNNu8fFjs97FcGV4dBkUgEI
	+OCuxr9UHOIthPvwW3e7OTGv1vhFeOY=
X-MC-Unique: AEaLfFvpM4KbpJYQSY00UA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=hUvEpCuXNqLb1JqllniEUmZMhJgXtJ9bzMBRNbbzhlA4DwGGKL4trNx+tfep0ccOQleuqIY+wQlTXU0ArW3IO5pnTqVXpA/KDs59OV0ie/ZU2qN5UD3QiG8AoeSof0XR5sLDqTtPG75aWIk8u2zo2AZXi8Np3oIAQtIk3GnOss+/oRMiodXZyDysZ7iFGaZQfUKxmauU3Tc4dAKFTbMsLH021+H2THfMohmijsbSnb+VxDIEZxmlXEGwNfJ3Gi51cvlEq5D6pRuRI3GhJkXUUZGoGpQU/zeEUGZiqFL0NKGHe1bb/tKhyFAMGFPKEQ5C22W0st38kHgEdXn9PToppA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=NGUbTCtYXX2wJ78MKsSyg0YaBcUJxx3LayTDYosPHH8=;
 b=iZXpP2MhrGCLcyCQH3xEwdwupWdaJAJPBOaK7sphzokvFwdiI2tHX1Rujpcz9uwzPe+nFDmxHKnsJcDcrgiDKGtYG0E7WLzHw8TE0QbUiE+G+N2pkCfXqkgYAsdUXbDbeusykDMaEuIUz/dDrI3aCs/1yl8wQhHvgjMvfpaeUKTrTAdzEQAUciFlf0c2c9PxhcZOX01Ow1stIhLwg7t83VBIpaGLTAqUa5uePq8GSmVKuZk7PkiImBO8Edkbwp0/FqVtLBH7n94VhwWaRX8dEDCJfQxhMgx1VgRrmrXUQpE5qe3Tvl8ZQc7kM/T4A+kAjecYw1Khyj/sZCd522UppQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <874bdf01-3131-8ded-3c09-7a9d71d87e19@suse.com>
Date: Thu, 10 Feb 2022 10:22:08 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH v6 05/13] vpci: add hooks for PCI device assign/de-assign
Content-Language: en-US
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: "julien@xen.org" <julien@xen.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Artem Mygaiev <Artem_Mygaiev@epam.com>,
 "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
 "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
 "paul@xen.org" <paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "roger.pau@citrix.com" <roger.pau@citrix.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-6-andr2000@gmail.com>
 <16cea1df-3d0f-d404-2b88-aab47ad5548b@suse.com>
 <3fe6dbe3-51c6-f87f-23f9-cf2e1a924326@epam.com>
 <582ee8f9-7b01-4adc-6a8a-ce8b1dffd534@suse.com>
 <e225553b-b29c-0448-fb9f-f8b513d9f77d@epam.com>
 <0fd8a0ac-dc91-287e-536e-1684892837ab@suse.com>
 <9f58a8ff-44b4-3249-5858-9988644b2d4e@epam.com>
 <15c16171-f196-38d2-370c-38627935a21b@suse.com>
 <20762939-6b7e-ff60-7c1a-d47c4767ff4f@epam.com>
 <10cd89b5-a804-3354-26d8-bc271bd9c5e6@suse.com>
 <15022045-bc92-e3df-b005-aeec5e36a078@epam.com>
 <cf584e13-f257-9355-50fa-c35e8fc8cf5e@suse.com>
 <a0015951-6eff-38a8-a9f0-bdbc8bd51940@epam.com>
 <51865693-1b5e-7ab5-f942-d244029c260b@epam.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <51865693-1b5e-7ab5-f942-d244029c260b@epam.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6P194CA0086.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:209:8f::27) To AM0PR04MB5587.eurprd04.prod.outlook.com
 (2603:10a6:208:125::12)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 8cba592e-88cb-45de-af88-08d9ec76d0e4
X-MS-TrafficTypeDiagnostic: VI1PR04MB7039:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB7039EFCC2BB65EDC149EF1A2B32F9@VI1PR04MB7039.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	yWxD5mHOKdsfuTKurJkmOy6I8B7NIuJYLqLqhgoBJs/11cvZWyRwAWyuRw0tKVjHK99vvY2R8XNAHy4Sfxx1KpNmQEYYOsaX4ECI/fPwhaNIBxHDUFDRyfdppgCWERtxfhhMnDDlcOLX0UDoCZe4KGmt+qOdrMsi2YeXSTSnMuoDBQiFg/bcjyARjW30+hHi0E0ufpQho6cCU+qHZO+9BW8JBfq7jHxikaWwTgM7L5L+orMRaFdQMSslgT2gXW5+PQQkpqPAQf/9pXFO1GgPlHvLrwvPFDtNv0Wei+f5fYflNE8AhrzS4xdWktZsHA9JI3Vyc5dvEZwcavt4ZXU1eC0kl3lFoQuCVsFdVck915RWxH0pxJ69gx3mGqsunV4S1SrgVX2u3tiMCY6u8BTmnmmI0PtmL0Czvuw/XqLdONMz6rFNH7bPLAqaJi4WXKM/Zsudg9TazfRF0ZTNo85XCUPTbnyqM1S1p2DXQl+ZYjAHXngHfANX5yjCvgVIKLEzBvjQhzvhvlt/XqzYTghleDX4xff7vHYmTKVHHsks9lOOdipRhbS4AE2ikDtmTbf7yqFIi0cTkRCSSqBU98yXVpRVs/cpa3zkvVMvfexaSDnMQQN/0VYJB44iyBhYFaDk92H7A/UFexz/AqSS8uRzlI11snRnruqviEEb7w2gwvv8q24yvAXCFd+q/9XWxFbDcnVISt+BimppzwWKseC0baeCntAbQEiX8SxWC622e0E=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR04MB5587.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66476007)(66556008)(6916009)(8676002)(66946007)(5660300002)(4326008)(38100700002)(316002)(31686004)(8936002)(54906003)(7416002)(36756003)(2906002)(6486002)(6506007)(6512007)(31696002)(53546011)(508600001)(186003)(26005)(2616005)(83380400001)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?htesSu6fS/Qy27LmvJVfT03kCIcZAE7UfBXbbOCdSYWWIByEgHP4RwV00y2U?=
 =?us-ascii?Q?oZlZunszt/DtxicV+ovqnNZ688TFPd4nMXm/ILYA0sOINaDUasbNCjC1R8Qj?=
 =?us-ascii?Q?4ZNu9ST1KtIjWs0pBFjuHLgvebvZRCFP49p0TVWPcQtCY+47CjK2bjM6YzkZ?=
 =?us-ascii?Q?+tP3JsvX0COYVmOMuRWKFh7QU8L3g3sE94EQRzGHx75zTbYElcZoc2rkWRev?=
 =?us-ascii?Q?DCIWp0fq1PEM+hmO+/+tdx97JbSsFBMwhWx/2p2PZt6u/Xr0Z3ilHThUu2az?=
 =?us-ascii?Q?N4UywUPmmtatP3Qr9p48rWtcbmKmO4jGV51YmSQPTnGXkcS32OC1yX5mCnzv?=
 =?us-ascii?Q?RLJ+4ilcsjAL8KG3ZbrR95CGHJBYgNAf+dIrquHAbT8Qtg3oIyyZy+sxVa2m?=
 =?us-ascii?Q?Tus+yQgsCuQRTFym01b+oLFWMJysblCdPmxIKdyDocKcsgikL7YYv4w6m2N0?=
 =?us-ascii?Q?Hy9j4MYbdaW8m2gcl6gL4UsZtpTbYsK8U4XUbMpnoSVYGZ39j19yRS4KCAEw?=
 =?us-ascii?Q?mqyr6QMv6zXte85nz3KlVKyEbkSvUSOhqsm9mG2QLZD2EOKyxu45QMuicnm/?=
 =?us-ascii?Q?+aGfRVwVV7hhxDufHlnX7Q7ysYnK9Q7p0IABDaOtytMqWN9lvwRTa7CZoARf?=
 =?us-ascii?Q?eRIYw3VHHmXxeTSZJ6APqDLarThjzo+/guBTIg13rMWLvbWh6LY3/cOgEd1Y?=
 =?us-ascii?Q?JkpFXH1ME1dWEaNjkiHWd+Xt+exAQho5Aw0ItBCF2y7RizyRSQdAPfurISq+?=
 =?us-ascii?Q?gShYcBNskj4vg76/ykMkWpc2uyMQ/hONf8Y+IeSk8+ZeBVOIs6jjNlwSkgNI?=
 =?us-ascii?Q?JY0YAS+4qRxYHZDw8taprHFTAIrjsSQCwQyfdYDpLhK1WFtwxAEsx4MwqHiB?=
 =?us-ascii?Q?1DiPauZwbueDp3AYe1AOhYSGBBeDaZErE7y/wxgZGfimkmiXJpjN8EGPliuY?=
 =?us-ascii?Q?8Eo1Rdcc3saoK33tn/Kwv5aYSroFIDgvBUtPQdWqkisXhl7IXzv28q87OPON?=
 =?us-ascii?Q?cqYJP+K9ZUnTzYLrr8mc3/JWtXXMJkMytAV6sZBTGZKc0h6xjhCP2qNbFywL?=
 =?us-ascii?Q?vjkX8KO/doX+XZkWR+ESw7D3izg4HUExXPJN1zsvmWM0pkSc+4YT4oD9Mf8X?=
 =?us-ascii?Q?ri4FTyEkheV5eo8hGxBcPOhAtCz6DLtyI4RU8Es9qrid54Qo7q5FBvec/K0m?=
 =?us-ascii?Q?pSbFmlUp3l+Mw6ZbHrfAzcV7IzJmvN8FbiGsCh7+4DONp/mb9GdeqWZUTNAJ?=
 =?us-ascii?Q?NcTcWHhzuc7aqzc8DOMRH3iXjbeYGN8KmoN/ThLlG7NL91McOQq1ZIreKXwQ?=
 =?us-ascii?Q?P1xn8aSWbXNn8CpyzhkhQjW+rlMYkj7sHh+mPCAZJwqJnM8QT4bQSZUIjdYm?=
 =?us-ascii?Q?Zvs2M0YV8IEIp4bdINrODA/pzQ9CpVMSfiBUI1MsypqbH2VfzVnp3NoLDGft?=
 =?us-ascii?Q?BqnP7WsWomcXu/BsmS8CY9EnxVq9lFtiIcR07SIqZGXGCOmk8z8FapIgc1RL?=
 =?us-ascii?Q?1cZumr+uEM/PTW5V2cziGDcMewXZkCvk1Vr+j3E2f00to1uXSKL26QXGsxus?=
 =?us-ascii?Q?DQKBsM9cRnKl4VHjBPecIkRVjrxlAAyJZxRtjm8pej+tF3DUXTea626WTNXO?=
 =?us-ascii?Q?dpGTa8cBUn61WypvS6jR0C8=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8cba592e-88cb-45de-af88-08d9ec76d0e4
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB5587.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2022 09:22:10.5829
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JGkFY8jm9LEve6GV3k9fFPs3Wvo5R8D7UV+lczmjbpEE2+rFUyxo0V4mC+9w2ykXTT6ybIVrs9NUw8u0GVoDCQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7039

On 10.02.2022 09:21, Oleksandr Andrushchenko wrote:
>=20
>=20
> On 08.02.22 13:25, Oleksandr Andrushchenko wrote:
>>
>> On 08.02.22 13:00, Jan Beulich wrote:
>>> On 08.02.2022 11:52, Oleksandr Andrushchenko wrote:
>>>> This smells like we first need to fix the existing code, so
>>>> pdev->domain is not assigned by specific IOMMU implementations,
>>>> but instead controlled by the code which relies on that, assign_device=
.
>>> Feel free to come up with proposals how to cleanly do so. Moving the
>>> assignment to pdev->domain may even be possible now, but if you go
>>> back you may find that the code was quite different earlier on.
>> I do understand that as the code evolves new use cases bring
>> new issues.
>>>> I can have something like:
>>>>
>>>> diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/p=
ci.c
>>>> index 88836aab6baf..cc7790709a50 100644
>>>> --- a/xen/drivers/passthrough/pci.c
>>>> +++ b/xen/drivers/passthrough/pci.c
>>>> @@ -1475,6 +1475,7 @@ static int device_assigned(u16 seg, u8 bus, u8 d=
evfn)
>>>>    =C2=A0static int assign_device(struct domain *d, u16 seg, u8 bus, u=
8 devfn, u32 flag)
>>>>    =C2=A0{
>>>>    =C2=A0=C2=A0=C2=A0=C2=A0 const struct domain_iommu *hd =3D dom_iomm=
u(d);
>>>> +=C2=A0=C2=A0=C2=A0 struct domain *old_owner;
>>>>    =C2=A0=C2=A0=C2=A0=C2=A0 struct pci_dev *pdev;
>>>>    =C2=A0=C2=A0=C2=A0=C2=A0 int rc =3D 0;
>>>>
>>>> @@ -1490,6 +1491,9 @@ static int assign_device(struct domain *d, u16 s=
eg, u8 bus, u8 devfn, u32 flag)
>>>>    =C2=A0=C2=A0=C2=A0=C2=A0 ASSERT(pdev && (pdev->domain =3D=3D hardwa=
re_domain ||
>>>>    =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 pdev->domain =3D=3D =
dom_io));
>>>>
>>>> +=C2=A0=C2=A0=C2=A0 /* We need to restore the old owner in case of an =
error. */
>>>> +=C2=A0=C2=A0=C2=A0 old_owner =3D pdev->domain;
>>>> +
>>>>    =C2=A0=C2=A0=C2=A0=C2=A0 vpci_deassign_device(pdev->domain, pdev);
>>>>
>>>>    =C2=A0=C2=A0=C2=A0=C2=A0 rc =3D pdev_msix_assign(d, pdev);
>>>> @@ -1515,8 +1519,12 @@ static int assign_device(struct domain *d, u16 =
seg, u8 bus, u8 devfn, u32 flag)
>>>>
>>>>    =C2=A0 done:
>>>>    =C2=A0=C2=A0=C2=A0=C2=A0 if ( rc )
>>>> +=C2=A0=C2=A0=C2=A0 {
>>>>    =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 printk(XENLOG_G_WA=
RNING "%pd: assign (%pp) failed (%d)\n",
>>>>    =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0 d, &PCI_SBDF3(seg, bus, devfn), rc);
>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 /* We failed to assign, so=
 restore the previous owner. */
>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 pdev->domain =3D old_owner=
;
>>>> +=C2=A0=C2=A0=C2=A0 }
>>>>    =C2=A0=C2=A0=C2=A0=C2=A0 /* The device is assigned to dom_io so mar=
k it as quarantined */
>>>>    =C2=A0=C2=A0=C2=A0=C2=A0 else if ( d =3D=3D dom_io )
>>>>    =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 pdev->quarantine =
=3D true;
>>>>
>>>> But I do not think this belongs to this patch
>>> Indeed. Plus I'm sure you understand that it's not that simple. Assigni=
ng
>>> to pdev->domain is only the last step of assignment. Restoring the orig=
inal
>>> owner would entail putting in place the original IOMMU table entries as
>>> well, which in turn can fail. Hence why you'll find a number of uses of
>>> domain_crash() in places where rolling back is far from easy.
>> So, why don't we just rely on the toolstack to do the roll back then?
>> This way we won't add new domain_crash() calls.
>> I do understand though that we may live Xen in a wrong state though.
>> So, do you think it is possible if we just call deassign_device from
>> assign_device on the error path? This is just like I do in vpci_assign_d=
evice:
>> I call vpci_deassign_device if the former fails.
> With the following addition:
>=20
> diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.=
c
> index c4ae22aeefcd..d6c00449193c 100644
> --- a/xen/drivers/passthrough/pci.c
> +++ b/xen/drivers/passthrough/pci.c
> @@ -1511,6 +1511,12 @@ static int assign_device(struct domain *d, u16 seg=
, u8 bus, u8 devfn, u32 flag)
>  =C2=A0=C2=A0=C2=A0=C2=A0 }
>=20
>  =C2=A0=C2=A0=C2=A0=C2=A0 rc =3D vpci_assign_device(pdev);
> +=C2=A0=C2=A0=C2=A0 if ( rc )
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 /*
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * Ignore the return cod=
e as we want to preserve the one from the
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * failed assign operati=
on.
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 */
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 deassign_device(d, seg, bus, =
devfn);
>=20
>  =C2=A0 done:
>  =C2=A0=C2=A0=C2=A0=C2=A0 if ( rc )
>=20
> I see the following logs (PV Dom0):
>=20
> (XEN) assign_device seg 0 bus 3 devfn 0
> (XEN) [VT-D]d[IO]:PCIe: unmap 0000:03:00.0
> (XEN) [VT-D]d4:PCIe: map 0000:03:00.0
> (XEN) assign_device vpci_assign rc -22 from d[IO] to d4
> (XEN) deassign_device current d4 to d[IO]
> (XEN) [VT-D]d4:PCIe: unmap 0000:03:00.0
> (XEN) [VT-D]d[IO]:PCIe: map 0000:03:00.0
> (XEN) deassign_device ret 0
> (XEN) d4: assign (0000:03:00.0) failed (-22)
> libxl: error: libxl_pci.c:1498:pci_add_dm_done: Domain 4:xc_assign_device=
 failed: Invalid argument
> libxl: error: libxl_pci.c:1781:device_pci_add_done: Domain 4:libxl__devic=
e_pci_add failed for PCI device 0:3:0.0 (rc -3)
> libxl: error: libxl_create.c:1895:domcreate_attach_devices: Domain 4:unab=
le to add pci devices
> libxl: error: libxl_domain.c:1183:libxl__destroy_domid: Domain 4:Non-exis=
tant domain
> libxl: error: libxl_domain.c:1137:domain_destroy_callback: Domain 4:Unabl=
e to destroy guest
> libxl: error: libxl_domain.c:1064:domain_destroy_cb: Domain 4:Destruction=
 of domain failed
>=20
> So, it seems to properly solve the issue with pdev->domain left
> set to the domain we couldn't create.
>=20
> @Jan, will this address your concern?

Partly: For one I'd have to think through what further implications there
are from going this route. And then completely ignoring the return value
is unlikely to be correct: You certainly want to retain the original
error code for returning to the caller, but you can't leave the error
unhandled. That's likely another case where the "best" choice is to crash
the guest.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Feb 10 09:33:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 10 Feb 2022 09:33:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269693.463772 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nI5pM-000653-Sx; Thu, 10 Feb 2022 09:33:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269693.463772; Thu, 10 Feb 2022 09:33:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nI5pM-00064w-Pd; Thu, 10 Feb 2022 09:33:24 +0000
Received: by outflank-mailman (input) for mailman id 269693;
 Thu, 10 Feb 2022 09:33:23 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=06a2=SZ=epam.com=prvs=40400e4a88=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nI5pL-00064l-Aw
 for xen-devel@lists.xenproject.org; Thu, 10 Feb 2022 09:33:23 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7ba1909d-8a54-11ec-8eb8-a37418f5ba1a;
 Thu, 10 Feb 2022 10:33:21 +0100 (CET)
Received: from pps.filterd (m0174678.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 21A9Wppa027255;
 Thu, 10 Feb 2022 09:33:17 GMT
Received: from eur03-ve1-obe.outbound.protection.outlook.com
 (mail-ve1eur03lp2053.outbound.protection.outlook.com [104.47.9.53])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e505wg02y-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Thu, 10 Feb 2022 09:33:16 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM4PR0302MB2737.eurprd03.prod.outlook.com (2603:10a6:200:95::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Thu, 10 Feb
 2022 09:33:11 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::fc4d:4749:5d1:eb73]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::fc4d:4749:5d1:eb73%4]) with mapi id 15.20.4975.012; Thu, 10 Feb 2022
 09:33:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7ba1909d-8a54-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=JDYhr0/lwaCl8L4bf0Fy0/OfZ38GhUgRCm4SjOkn9CCjfUW44KC8JwoFZvhrh+Rr0i97OkctQbblHtIOKxmuoJVjoj30MdKtNbMfjjFQQmn+/kJXegnU8AAQEVKcSPTPYEuuXJ3SrY2vRF8iRn06O2DAt/83Qhaq5uhue2or5mE3fBuPXi6HdgxY0W4+gcMctotVnGAFlbbSGX5h8ZrAf/McxsJXn5I/Jp4OVtPJFe+H+hg2sLjpE2ZwO2cR8xp9bu5b/exANHAHWEoqP+df0LN2NRknPFtCrTCgxKhMhd49TuIDuZ7VEzMqbJgfItfn0qmucNE7pDb3Ht1C/wNJSQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=5AWZklPvT+Oqt/1kAYGCWPTsjapzXc4sYaWKVMNRhbk=;
 b=IXVpobNoyUiELRWjXiefDHo1vcTH39lpumucYATfwEU0lbeVIerdBC9pxZCG+Z/AGDYy5tp38J3OQcONLmIAahJkxtfzyPF3FEsMNHr7ZI0cMAJpnjpYY7vR92JGDKYgI1q9UL4KKF4/1aap5gRqJUHElc4DkDa+dW6MfZYAYuMXD/F2gf8nvvYJBqaMHQehbefkmU51MoXpcQc5VXcKGmgrezTIIOZYFgZfaIQIuBm8bbRPiIY/675mQCX8vDcmnlwPKPN2A0F4tmLwMtrCxB/CjGfXgcc/ePL9O8jbT07opyVOHkTOilnpCc6aixotkV5jjsE1UNSVpvyXkqKMiQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=5AWZklPvT+Oqt/1kAYGCWPTsjapzXc4sYaWKVMNRhbk=;
 b=Bea0z9a1RvlMaIs9Z1izgeBqPf3C448UOYhnYoxTdN9CYEEShp2RZa/6mjc6LS7xMBHE05qDAGF3dcKDUO1BP9UKPGaHvML8PAZsiVGxgKsuKb7xTQlYKbPqhvyzyzZnuq2ePtxY1V1Wa1XfaOnvS/pNiYMG2lDXP7vHh5Drwq0H54yfE9lLUGvEG1rX0nYM7IvNzBP8L4cqDedQCVI6nEdeen7FuLaFSwHxXL6qqwoYz/FEDA79jg4Ux1tx5WoNLamGcWyUi5usmL1KzK6Bz+fl4SE8GFSvnI4KXimbRqKh2pE7kt/aJQhLFOq8q0ITkdpWF+9ThOclWt4jv/nwZw==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        "roger.pau@citrix.com"
	<roger.pau@citrix.com>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v6 05/13] vpci: add hooks for PCI device assign/de-assign
Thread-Topic: [PATCH v6 05/13] vpci: add hooks for PCI device assign/de-assign
Thread-Index: 
 AQHYGZFdYv4W1RdbQkeQtzN+PyKqmqyITGQAgAENNICAAAt2AIAAA+uAgAAEsACAAAMyAIAABAgAgAADmACAAAHqgIAABl2AgAACJ4CAAAczgIAC8ScAgAAQ9ACAAAMVAA==
Date: Thu, 10 Feb 2022 09:33:11 +0000
Message-ID: <78229417-c648-4cd6-90a4-8701cc5243e1@epam.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-6-andr2000@gmail.com>
 <16cea1df-3d0f-d404-2b88-aab47ad5548b@suse.com>
 <3fe6dbe3-51c6-f87f-23f9-cf2e1a924326@epam.com>
 <582ee8f9-7b01-4adc-6a8a-ce8b1dffd534@suse.com>
 <e225553b-b29c-0448-fb9f-f8b513d9f77d@epam.com>
 <0fd8a0ac-dc91-287e-536e-1684892837ab@suse.com>
 <9f58a8ff-44b4-3249-5858-9988644b2d4e@epam.com>
 <15c16171-f196-38d2-370c-38627935a21b@suse.com>
 <20762939-6b7e-ff60-7c1a-d47c4767ff4f@epam.com>
 <10cd89b5-a804-3354-26d8-bc271bd9c5e6@suse.com>
 <15022045-bc92-e3df-b005-aeec5e36a078@epam.com>
 <cf584e13-f257-9355-50fa-c35e8fc8cf5e@suse.com>
 <a0015951-6eff-38a8-a9f0-bdbc8bd51940@epam.com>
 <51865693-1b5e-7ab5-f942-d244029c260b@epam.com>
 <874bdf01-3131-8ded-3c09-7a9d71d87e19@suse.com>
In-Reply-To: <874bdf01-3131-8ded-3c09-7a9d71d87e19@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: b0378eec-5755-4d98-43df-08d9ec785aeb
x-ms-traffictypediagnostic: AM4PR0302MB2737:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM4PR0302MB27376F557993B2E2B1D04D47E72F9@AM4PR0302MB2737.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 3GnhveVSzCtswdEFMHcsx0ad/mElI+LGHaWRj/gg1n77PfSrqWD0vJjEvZjjYwmOAXNxLef+8jAU7mtQXH8YoRIAgFuTMDHnkaYEEfzQfzKWtJOE6CAJ6ZjjDxAJqZQQnsd0iUeUijJ0wGwEI1wg411QA4yAA+2ZGjRZ5cRx7FH+1TWsCO9+Wq4Ac9R+SIxDmeaWNTMDl8T8BqiQIvnUh0wHd7Ps23TAlszpHFN4kc90ZXg68vEeDQtwVcTv8Eb6x8Pv6Bmt+Oz2O839dxQoN1/cWjqa48JD3S01ARBBFYWir5JZduxAxPIMncd164b+2bMGcIzdjnidfOs1WSSAOkr1PMa4cdr7sC39s45/TIUQwNJyfxCk2WAk7SvVCSCxO2f5/gpCdQp2lbZ+wj5JIUEnwlQ+KYDkSjb5u2eJAobPhiKaZyk9UyZy2YLgoFdSEqFIE/EK/0ul/N9gpDmrMlVlSroWNX18veU81tXBFCZnnfP9kgRh1qt30Z+A20ZqSLrcizFtRcl3f/A1mMKmH66yzyUt7lCUuL6WyX2bhWwWvkUMJ1+Z39ICYgBAGt83EzTqABNNmTM6dWmAqArTFDjZKShPhEovawRFAwRuS5Ornh5lvcitYajEU6m7nrdSnvxBylSYseGh+QRfGPFv31J0yBgpoYfWzx7mWzoLgMvScaZcCCicV5UH5f0GXxWgNw6Zy3LfG0RM6U75/VoDzQz7kBeWVWZPy1XqWxNYTWKDSupa6idT+lWG01S0qTi4
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(64756008)(8676002)(8936002)(66946007)(91956017)(6916009)(66446008)(316002)(54906003)(4326008)(122000001)(76116006)(66556008)(5660300002)(31696002)(38100700002)(38070700005)(66476007)(7416002)(6512007)(2906002)(6506007)(6486002)(186003)(107886003)(26005)(83380400001)(71200400001)(508600001)(2616005)(36756003)(53546011)(86362001)(31686004)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?SjdhMDg4amRWeVZIM202djE2M2pGOVdiRG8yaEFzTzR0cGp6QlRROWpsRWZH?=
 =?utf-8?B?MjFUT1IwSFpycHhQa2RRYXBNeHFidTlTTWJDU29RSkljS1JhZmhjRWowQ0Zr?=
 =?utf-8?B?WUt6Z285WC8wMjhRUHpjMHF3N3NRQW1VR3lOUVlVa1hEcnpwb1JTTVZtbkVS?=
 =?utf-8?B?VVNYR1hoUE1pVVZ4Ulpza3Fib2dQbmlpR3E0VU4yUU5Cc3hTeXRUV3BtT3Iw?=
 =?utf-8?B?WHQzZ2xjcmNVMnNZdExGRXg5c3A5djV4S1JuYkNFK3lDMzFLZ0l3T3RtY2pa?=
 =?utf-8?B?NXUvdDV2UnFiSzlZa2JVQ0tFWlpJeGY0SHZmZFVmYmpOV1h0MnZIRnl0WHpj?=
 =?utf-8?B?Q3IrMzI1cDI2S2dEWGZFKytUWklsaVB4bmJLT3RCaWRGV21XdzFqdGg2V3Bj?=
 =?utf-8?B?M2UvTVpUdkFObmtqOWFCM3JRU3g2WnFqb1pYVnFDbVZhY05wQ3FnRGsveG1O?=
 =?utf-8?B?Y3k3UGZnTUVKTHBXd0pmYTR4OHM4N3o1cm5obHp5d0JWT1lUZUNVS3l2SmY1?=
 =?utf-8?B?SFNxNHhOdG5NVEJudnRCQ0RiNE1nNDNsS00xd2wyQ1ZYa2J2T3FMN09tWG84?=
 =?utf-8?B?U0V6U0tvY3hrNHFsN3ZqZGNOeEF6QTVmc1ZKQUpSMU1qNFUvN0ZsZ3VDRmI0?=
 =?utf-8?B?K3J3bjcxbEF1c2pPTFR6S29ra0lqMTV2VDM4MGMvQUNlWTJEVHE0akgwLzV4?=
 =?utf-8?B?MGs3UWdqZFJGL3RPd3ErbjcydW02MUZLek90NVdySUZjSzRrV3ZLZGxMUHYv?=
 =?utf-8?B?WkJnZUVXd3JsekZCRDJrTDdzWVRkWGs5TngwRzFsdWJoUXlRZjU5Q0p6QnJ2?=
 =?utf-8?B?MmtrVDlJdFMrZUhJSlFYNFlETFFwTFJTaUdqU0M1UlRVSjlhMm1uaFlTY1FB?=
 =?utf-8?B?cDZhYzRUUGs2RFA5cFJuUjk2MGltUmw4OGM0bnZ6VGlobWFCZ2liV1dSSm83?=
 =?utf-8?B?S0daR3hEOXQ5ZWF4U2hLb290YTlmWkJLVjJEOCtHT2oxVThpMUhQbC9YRk5a?=
 =?utf-8?B?MFNTcDFzNGc1VHFPaENTdjBkR1d5bU5YNStndHJXVllNd1pQVVQ5Q1FJa29W?=
 =?utf-8?B?QnZyUmlGMVRNc1FjejBQOFdNU3BDWStTc0g2MFpIbm9ucDFRNzBsNXM3MTNm?=
 =?utf-8?B?SVhDSGZmWVVPQy95VVQwckVVc2Z3cUNEWmpRVEZid1FoUkJYblhIT3c0bDg1?=
 =?utf-8?B?YUpaV3U4S2oxK2lobmtoOHA3bzB4QXZuYU1paVNkempzMURlT1ExL0NyYlg1?=
 =?utf-8?B?YytyTHdkdG9UNkR0TVZrUnhCNFY1bmpVbVpTdmZPWHEwejdPbTNHZjZGYUdx?=
 =?utf-8?B?TGJMZ1VJazFobHcyVVFSbCtxMENwMndiYUcydkdDYmdjZGVkOTRNeHBDa3Fa?=
 =?utf-8?B?eWY0QzNkK2FUQjFXK284ZEg0ZTY5UWwvelBmT0ZrWnRpaURCR3JKcFB2NGxU?=
 =?utf-8?B?UldhRTRaRFRoSzA1L1Ywb2lnTTZPR3VNTXNUT283VUxubnRTdDRTZGRoelpP?=
 =?utf-8?B?dXBDenZhbzhkOW9IUXdwQXVtU1A2R2UvNUxPQ2xyN0dlcTFMcnRsb0VFQmhE?=
 =?utf-8?B?NVFKOGsxSnlKdG50UkRIMXV6R2lwVERzZ2VmQlpnRkFuZU00ZmhRWGZaWm1m?=
 =?utf-8?B?V2FveVlXRWpaSkJmejUzWEd3ZDI5S1FKdmMwMW5kY0llUWt6R3FZdm5va1lP?=
 =?utf-8?B?aGs2Qi82d3A3elBNUFBvVUt5UmhrM2t0b2Z4aS9uWiswdXRZZDRjaHdmb3Jy?=
 =?utf-8?B?endmNi92UCs1cG1QSXNjK2dTbE9Ya1Z1SUZ0cXB5Q2s2UmtjMklMTTU0alcz?=
 =?utf-8?B?cGlKUUFDZzFBdFlaMitDWEZZY1pQT0hhZGY4UVJjNlpTMnpVU2RxK0VPUito?=
 =?utf-8?B?VHdtbVdpV0ZQOGZQMG42cmxOTUdyQTYzSUNZWG5naHFsZnYySWI2b2pHT3RC?=
 =?utf-8?B?MWVXNlYrSzZsUlpjU3YweU5FT094b2lKb2s5TnY1Ykh3S3VERHo3RVZZM1lO?=
 =?utf-8?B?WWxMbC9ienNNeVBaZDZCcGR1bm5aWHN6UGpKam4vcExLaC93bVZleHRKMmhT?=
 =?utf-8?B?Z1FZTk1TZzVPL1JNWHVrcGpuQWllM1RtN1ZYUXZCb3NwajkvR0R3aUFOR1dZ?=
 =?utf-8?B?WUFjTGZ4Vi9XbVJ5WHlScEc0ZE1lTnp6N3FNM0pncWlnSVVFK1cwUjVXTU5C?=
 =?utf-8?B?RFpzYUtxelI5b2dMeTU4UDB5U1UwTURrRjAzTi91eE5vTlFjK2dXMWFic25q?=
 =?utf-8?B?WS9GclF0d0ZEaTJKZ25qMG1vTldhQ2hxdUVLOXo2SmRqMzQyQnZOODRGV2lL?=
 =?utf-8?B?TTJEaEQvWE45Q2VER1hITSt6Umh4L1E1aTFOK3NwdDY2RVErMDF3Zz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <6CC59EFA266A844FAC1CE62461F8AC0A@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b0378eec-5755-4d98-43df-08d9ec785aeb
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Feb 2022 09:33:11.4140
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: RRIUkLIKE8fevgs2lTxQZyBfg2ut6zu09M/pW30v4HaKZ41/7QkMWxtkgcUHyT3KUDGJM/zXsRRX3SGMM9IR9yPE4eUPD75nngV8P6YASyfAzbUTcWPBOvyLOkmlVpkP
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0302MB2737
X-Proofpoint-ORIG-GUID: kgpaNgPqu_PisF6EgsWoC9Mk0Jw7eRGO
X-Proofpoint-GUID: kgpaNgPqu_PisF6EgsWoC9Mk0Jw7eRGO
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-10_03,2022-02-09_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 mlxscore=0
 adultscore=0 clxscore=1015 impostorscore=0 malwarescore=0 phishscore=0
 mlxlogscore=999 suspectscore=0 lowpriorityscore=0 priorityscore=1501
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202100051

DQoNCk9uIDEwLjAyLjIyIDExOjIyLCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMTAuMDIuMjAy
MiAwOToyMSwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+Pg0KPj4gT24gMDguMDIu
MjIgMTM6MjUsIE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4+IE9uIDA4LjAyLjIy
IDEzOjAwLCBKYW4gQmV1bGljaCB3cm90ZToNCj4+Pj4gT24gMDguMDIuMjAyMiAxMTo1MiwgT2xl
a3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+Pj4+PiBUaGlzIHNtZWxscyBsaWtlIHdlIGZp
cnN0IG5lZWQgdG8gZml4IHRoZSBleGlzdGluZyBjb2RlLCBzbw0KPj4+Pj4gcGRldi0+ZG9tYWlu
IGlzIG5vdCBhc3NpZ25lZCBieSBzcGVjaWZpYyBJT01NVSBpbXBsZW1lbnRhdGlvbnMsDQo+Pj4+
PiBidXQgaW5zdGVhZCBjb250cm9sbGVkIGJ5IHRoZSBjb2RlIHdoaWNoIHJlbGllcyBvbiB0aGF0
LCBhc3NpZ25fZGV2aWNlLg0KPj4+PiBGZWVsIGZyZWUgdG8gY29tZSB1cCB3aXRoIHByb3Bvc2Fs
cyBob3cgdG8gY2xlYW5seSBkbyBzby4gTW92aW5nIHRoZQ0KPj4+PiBhc3NpZ25tZW50IHRvIHBk
ZXYtPmRvbWFpbiBtYXkgZXZlbiBiZSBwb3NzaWJsZSBub3csIGJ1dCBpZiB5b3UgZ28NCj4+Pj4g
YmFjayB5b3UgbWF5IGZpbmQgdGhhdCB0aGUgY29kZSB3YXMgcXVpdGUgZGlmZmVyZW50IGVhcmxp
ZXIgb24uDQo+Pj4gSSBkbyB1bmRlcnN0YW5kIHRoYXQgYXMgdGhlIGNvZGUgZXZvbHZlcyBuZXcg
dXNlIGNhc2VzIGJyaW5nDQo+Pj4gbmV3IGlzc3Vlcy4NCj4+Pj4+IEkgY2FuIGhhdmUgc29tZXRo
aW5nIGxpa2U6DQo+Pj4+Pg0KPj4+Pj4gZGlmZiAtLWdpdCBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJv
dWdoL3BjaS5jIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvcGNpLmMNCj4+Pj4+IGluZGV4IDg4
ODM2YWFiNmJhZi4uY2M3NzkwNzA5YTUwIDEwMDY0NA0KPj4+Pj4gLS0tIGEveGVuL2RyaXZlcnMv
cGFzc3Rocm91Z2gvcGNpLmMNCj4+Pj4+ICsrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3Bj
aS5jDQo+Pj4+PiBAQCAtMTQ3NSw2ICsxNDc1LDcgQEAgc3RhdGljIGludCBkZXZpY2VfYXNzaWdu
ZWQodTE2IHNlZywgdTggYnVzLCB1OCBkZXZmbikNCj4+Pj4+ICAgICDCoHN0YXRpYyBpbnQgYXNz
aWduX2RldmljZShzdHJ1Y3QgZG9tYWluICpkLCB1MTYgc2VnLCB1OCBidXMsIHU4IGRldmZuLCB1
MzIgZmxhZykNCj4+Pj4+ICAgICDCoHsNCj4+Pj4+ICAgICDCoMKgwqDCoCBjb25zdCBzdHJ1Y3Qg
ZG9tYWluX2lvbW11ICpoZCA9IGRvbV9pb21tdShkKTsNCj4+Pj4+ICvCoMKgwqAgc3RydWN0IGRv
bWFpbiAqb2xkX293bmVyOw0KPj4+Pj4gICAgIMKgwqDCoMKgIHN0cnVjdCBwY2lfZGV2ICpwZGV2
Ow0KPj4+Pj4gICAgIMKgwqDCoMKgIGludCByYyA9IDA7DQo+Pj4+Pg0KPj4+Pj4gQEAgLTE0OTAs
NiArMTQ5MSw5IEBAIHN0YXRpYyBpbnQgYXNzaWduX2RldmljZShzdHJ1Y3QgZG9tYWluICpkLCB1
MTYgc2VnLCB1OCBidXMsIHU4IGRldmZuLCB1MzIgZmxhZykNCj4+Pj4+ICAgICDCoMKgwqDCoCBB
U1NFUlQocGRldiAmJiAocGRldi0+ZG9tYWluID09IGhhcmR3YXJlX2RvbWFpbiB8fA0KPj4+Pj4g
ICAgIMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcGRldi0+ZG9tYWlu
ID09IGRvbV9pbykpOw0KPj4+Pj4NCj4+Pj4+ICvCoMKgwqAgLyogV2UgbmVlZCB0byByZXN0b3Jl
IHRoZSBvbGQgb3duZXIgaW4gY2FzZSBvZiBhbiBlcnJvci4gKi8NCj4+Pj4+ICvCoMKgwqAgb2xk
X293bmVyID0gcGRldi0+ZG9tYWluOw0KPj4+Pj4gKw0KPj4+Pj4gICAgIMKgwqDCoMKgIHZwY2lf
ZGVhc3NpZ25fZGV2aWNlKHBkZXYtPmRvbWFpbiwgcGRldik7DQo+Pj4+Pg0KPj4+Pj4gICAgIMKg
wqDCoMKgIHJjID0gcGRldl9tc2l4X2Fzc2lnbihkLCBwZGV2KTsNCj4+Pj4+IEBAIC0xNTE1LDgg
KzE1MTksMTIgQEAgc3RhdGljIGludCBhc3NpZ25fZGV2aWNlKHN0cnVjdCBkb21haW4gKmQsIHUx
NiBzZWcsIHU4IGJ1cywgdTggZGV2Zm4sIHUzMiBmbGFnKQ0KPj4+Pj4NCj4+Pj4+ICAgICDCoCBk
b25lOg0KPj4+Pj4gICAgIMKgwqDCoMKgIGlmICggcmMgKQ0KPj4+Pj4gK8KgwqDCoCB7DQo+Pj4+
PiAgICAgwqDCoMKgwqDCoMKgwqDCoCBwcmludGsoWEVOTE9HX0dfV0FSTklORyAiJXBkOiBhc3Np
Z24gKCVwcCkgZmFpbGVkICglZClcbiIsDQo+Pj4+PiAgICAgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgIGQsICZQQ0lfU0JERjMoc2VnLCBidXMsIGRldmZuKSwgcmMpOw0KPj4+Pj4gK8Kg
wqDCoMKgwqDCoMKgIC8qIFdlIGZhaWxlZCB0byBhc3NpZ24sIHNvIHJlc3RvcmUgdGhlIHByZXZp
b3VzIG93bmVyLiAqLw0KPj4+Pj4gK8KgwqDCoMKgwqDCoMKgIHBkZXYtPmRvbWFpbiA9IG9sZF9v
d25lcjsNCj4+Pj4+ICvCoMKgwqAgfQ0KPj4+Pj4gICAgIMKgwqDCoMKgIC8qIFRoZSBkZXZpY2Ug
aXMgYXNzaWduZWQgdG8gZG9tX2lvIHNvIG1hcmsgaXQgYXMgcXVhcmFudGluZWQgKi8NCj4+Pj4+
ICAgICDCoMKgwqDCoCBlbHNlIGlmICggZCA9PSBkb21faW8gKQ0KPj4+Pj4gICAgIMKgwqDCoMKg
wqDCoMKgwqAgcGRldi0+cXVhcmFudGluZSA9IHRydWU7DQo+Pj4+Pg0KPj4+Pj4gQnV0IEkgZG8g
bm90IHRoaW5rIHRoaXMgYmVsb25ncyB0byB0aGlzIHBhdGNoDQo+Pj4+IEluZGVlZC4gUGx1cyBJ
J20gc3VyZSB5b3UgdW5kZXJzdGFuZCB0aGF0IGl0J3Mgbm90IHRoYXQgc2ltcGxlLiBBc3NpZ25p
bmcNCj4+Pj4gdG8gcGRldi0+ZG9tYWluIGlzIG9ubHkgdGhlIGxhc3Qgc3RlcCBvZiBhc3NpZ25t
ZW50LiBSZXN0b3JpbmcgdGhlIG9yaWdpbmFsDQo+Pj4+IG93bmVyIHdvdWxkIGVudGFpbCBwdXR0
aW5nIGluIHBsYWNlIHRoZSBvcmlnaW5hbCBJT01NVSB0YWJsZSBlbnRyaWVzIGFzDQo+Pj4+IHdl
bGwsIHdoaWNoIGluIHR1cm4gY2FuIGZhaWwuIEhlbmNlIHdoeSB5b3UnbGwgZmluZCBhIG51bWJl
ciBvZiB1c2VzIG9mDQo+Pj4+IGRvbWFpbl9jcmFzaCgpIGluIHBsYWNlcyB3aGVyZSByb2xsaW5n
IGJhY2sgaXMgZmFyIGZyb20gZWFzeS4NCj4+PiBTbywgd2h5IGRvbid0IHdlIGp1c3QgcmVseSBv
biB0aGUgdG9vbHN0YWNrIHRvIGRvIHRoZSByb2xsIGJhY2sgdGhlbj8NCj4+PiBUaGlzIHdheSB3
ZSB3b24ndCBhZGQgbmV3IGRvbWFpbl9jcmFzaCgpIGNhbGxzLg0KPj4+IEkgZG8gdW5kZXJzdGFu
ZCB0aG91Z2ggdGhhdCB3ZSBtYXkgbGl2ZSBYZW4gaW4gYSB3cm9uZyBzdGF0ZSB0aG91Z2guDQo+
Pj4gU28sIGRvIHlvdSB0aGluayBpdCBpcyBwb3NzaWJsZSBpZiB3ZSBqdXN0IGNhbGwgZGVhc3Np
Z25fZGV2aWNlIGZyb20NCj4+PiBhc3NpZ25fZGV2aWNlIG9uIHRoZSBlcnJvciBwYXRoPyBUaGlz
IGlzIGp1c3QgbGlrZSBJIGRvIGluIHZwY2lfYXNzaWduX2RldmljZToNCj4+PiBJIGNhbGwgdnBj
aV9kZWFzc2lnbl9kZXZpY2UgaWYgdGhlIGZvcm1lciBmYWlscy4NCj4+IFdpdGggdGhlIGZvbGxv
d2luZyBhZGRpdGlvbjoNCj4+DQo+PiBkaWZmIC0tZ2l0IGEveGVuL2RyaXZlcnMvcGFzc3Rocm91
Z2gvcGNpLmMgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9wY2kuYw0KPj4gaW5kZXggYzRhZTIy
YWVlZmNkLi5kNmMwMDQ0OTE5M2MgMTAwNjQ0DQo+PiAtLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhy
b3VnaC9wY2kuYw0KPj4gKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvcGNpLmMNCj4+IEBA
IC0xNTExLDYgKzE1MTEsMTIgQEAgc3RhdGljIGludCBhc3NpZ25fZGV2aWNlKHN0cnVjdCBkb21h
aW4gKmQsIHUxNiBzZWcsIHU4IGJ1cywgdTggZGV2Zm4sIHUzMiBmbGFnKQ0KPj4gICDCoMKgwqDC
oCB9DQo+Pg0KPj4gICDCoMKgwqDCoCByYyA9IHZwY2lfYXNzaWduX2RldmljZShwZGV2KTsNCj4+
ICvCoMKgwqAgaWYgKCByYyApDQo+PiArwqDCoMKgwqDCoMKgwqAgLyoNCj4+ICvCoMKgwqDCoMKg
wqDCoMKgICogSWdub3JlIHRoZSByZXR1cm4gY29kZSBhcyB3ZSB3YW50IHRvIHByZXNlcnZlIHRo
ZSBvbmUgZnJvbSB0aGUNCj4+ICvCoMKgwqDCoMKgwqDCoMKgICogZmFpbGVkIGFzc2lnbiBvcGVy
YXRpb24uDQo+PiArwqDCoMKgwqDCoMKgwqDCoCAqLw0KPj4gK8KgwqDCoMKgwqDCoMKgIGRlYXNz
aWduX2RldmljZShkLCBzZWcsIGJ1cywgZGV2Zm4pOw0KVGhpcyBuZWVkcyBkZXZmbiB0byBiZSBw
cmVzZXJ2ZWQgYXMgaXQgY2FuIGJlIG1vZGlmaWVkIGJ5IHRoZSBsb29wIGFib3ZlOg0KIMKgwqDC
oCBmb3IgKCA7IHBkZXYtPnBoYW50b21fc3RyaWRlOyByYyA9IDAgKQ0KIMKgwqDCoCB7DQogwqDC
oMKgwqDCoMKgwqAgZGV2Zm4gKz0gcGRldi0+cGhhbnRvbV9zdHJpZGU7DQoNCj4+DQo+PiAgIMKg
IGRvbmU6DQo+PiAgIMKgwqDCoMKgIGlmICggcmMgKQ0KPj4NCj4+IEkgc2VlIHRoZSBmb2xsb3dp
bmcgbG9ncyAoUFYgRG9tMCk6DQo+Pg0KPj4gKFhFTikgYXNzaWduX2RldmljZSBzZWcgMCBidXMg
MyBkZXZmbiAwDQo+PiAoWEVOKSBbVlQtRF1kW0lPXTpQQ0llOiB1bm1hcCAwMDAwOjAzOjAwLjAN
Cj4+IChYRU4pIFtWVC1EXWQ0OlBDSWU6IG1hcCAwMDAwOjAzOjAwLjANCj4+IChYRU4pIGFzc2ln
bl9kZXZpY2UgdnBjaV9hc3NpZ24gcmMgLTIyIGZyb20gZFtJT10gdG8gZDQNCj4+IChYRU4pIGRl
YXNzaWduX2RldmljZSBjdXJyZW50IGQ0IHRvIGRbSU9dDQo+PiAoWEVOKSBbVlQtRF1kNDpQQ0ll
OiB1bm1hcCAwMDAwOjAzOjAwLjANCj4+IChYRU4pIFtWVC1EXWRbSU9dOlBDSWU6IG1hcCAwMDAw
OjAzOjAwLjANCj4+IChYRU4pIGRlYXNzaWduX2RldmljZSByZXQgMA0KPj4gKFhFTikgZDQ6IGFz
c2lnbiAoMDAwMDowMzowMC4wKSBmYWlsZWQgKC0yMikNCj4+IGxpYnhsOiBlcnJvcjogbGlieGxf
cGNpLmM6MTQ5ODpwY2lfYWRkX2RtX2RvbmU6IERvbWFpbiA0OnhjX2Fzc2lnbl9kZXZpY2UgZmFp
bGVkOiBJbnZhbGlkIGFyZ3VtZW50DQo+PiBsaWJ4bDogZXJyb3I6IGxpYnhsX3BjaS5jOjE3ODE6
ZGV2aWNlX3BjaV9hZGRfZG9uZTogRG9tYWluIDQ6bGlieGxfX2RldmljZV9wY2lfYWRkIGZhaWxl
ZCBmb3IgUENJIGRldmljZSAwOjM6MC4wIChyYyAtMykNCj4+IGxpYnhsOiBlcnJvcjogbGlieGxf
Y3JlYXRlLmM6MTg5NTpkb21jcmVhdGVfYXR0YWNoX2RldmljZXM6IERvbWFpbiA0OnVuYWJsZSB0
byBhZGQgcGNpIGRldmljZXMNCj4+IGxpYnhsOiBlcnJvcjogbGlieGxfZG9tYWluLmM6MTE4Mzps
aWJ4bF9fZGVzdHJveV9kb21pZDogRG9tYWluIDQ6Tm9uLWV4aXN0YW50IGRvbWFpbg0KPj4gbGli
eGw6IGVycm9yOiBsaWJ4bF9kb21haW4uYzoxMTM3OmRvbWFpbl9kZXN0cm95X2NhbGxiYWNrOiBE
b21haW4gNDpVbmFibGUgdG8gZGVzdHJveSBndWVzdA0KPj4gbGlieGw6IGVycm9yOiBsaWJ4bF9k
b21haW4uYzoxMDY0OmRvbWFpbl9kZXN0cm95X2NiOiBEb21haW4gNDpEZXN0cnVjdGlvbiBvZiBk
b21haW4gZmFpbGVkDQo+Pg0KPj4gU28sIGl0IHNlZW1zIHRvIHByb3Blcmx5IHNvbHZlIHRoZSBp
c3N1ZSB3aXRoIHBkZXYtPmRvbWFpbiBsZWZ0DQo+PiBzZXQgdG8gdGhlIGRvbWFpbiB3ZSBjb3Vs
ZG4ndCBjcmVhdGUuDQo+Pg0KPj4gQEphbiwgd2lsbCB0aGlzIGFkZHJlc3MgeW91ciBjb25jZXJu
Pw0KPiBQYXJ0bHk6IEZvciBvbmUgSSdkIGhhdmUgdG8gdGhpbmsgdGhyb3VnaCB3aGF0IGZ1cnRo
ZXIgaW1wbGljYXRpb25zIHRoZXJlDQo+IGFyZSBmcm9tIGdvaW5nIHRoaXMgcm91dGUuIEFuZCB0
aGVuIGNvbXBsZXRlbHkgaWdub3JpbmcgdGhlIHJldHVybiB2YWx1ZQ0KPiBpcyB1bmxpa2VseSB0
byBiZSBjb3JyZWN0OiBZb3UgY2VydGFpbmx5IHdhbnQgdG8gcmV0YWluIHRoZSBvcmlnaW5hbA0K
PiBlcnJvciBjb2RlIGZvciByZXR1cm5pbmcgdG8gdGhlIGNhbGxlciwgYnV0IHlvdSBjYW4ndCBs
ZWF2ZSB0aGUgZXJyb3INCj4gdW5oYW5kbGVkLiBUaGF0J3MgbGlrZWx5IGFub3RoZXIgY2FzZSB3
aGVyZSB0aGUgImJlc3QiIGNob2ljZSBpcyB0byBjcmFzaA0KPiB0aGUgZ3Vlc3QuDQpPaywgdGhl
biBJJ2xsIGNyYXNoIHRoZSBkb21haW4uLi4NCj4NCj4gSmFuDQo+DQo+DQpUaGFuayB5b3UsDQpP
bGVrc2FuZHI=


From xen-devel-bounces@lists.xenproject.org Thu Feb 10 09:35:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 10 Feb 2022 09:35:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269702.463783 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nI5rU-0006j7-CR; Thu, 10 Feb 2022 09:35:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269702.463783; Thu, 10 Feb 2022 09:35:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nI5rU-0006j0-9I; Thu, 10 Feb 2022 09:35:36 +0000
Received: by outflank-mailman (input) for mailman id 269702;
 Thu, 10 Feb 2022 09:35:35 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nI5rT-0006il-2y; Thu, 10 Feb 2022 09:35:35 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nI5rT-0006oA-03; Thu, 10 Feb 2022 09:35:35 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nI5rS-0002U9-Is; Thu, 10 Feb 2022 09:35:34 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nI5rS-00053m-IQ; Thu, 10 Feb 2022 09:35:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=WFb6ghU1ZzLNeF4x/pLfrUlM6gt/DKZMJfYJc1dQgnY=; b=0O4FQ+nPMAQwrNRxYjbRjZFmqr
	vsUz25wrq5OvmuhjBH6gLIF6EogaIHXtgE8gSIgUjxAKi+/O15r/W4RjJzfd0+JG3aHfdDzYtURZ1
	0GRlylMwCoLZDqV/xYaD0TbICgrybzdDYJqDsgbI3pXzvxuzKF7aYjk6DcXVbFVwSSV4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168076-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 168076: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=558f00397a0d46ad22bf53a22a40ed6fc4fdb5eb
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 10 Feb 2022 09:35:34 +0000

flight 168076 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168076/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              558f00397a0d46ad22bf53a22a40ed6fc4fdb5eb
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  580 days
Failing since        151818  2020-07-11 04:18:52 Z  579 days  561 attempts
Testing same since   168076  2022-02-10 04:21:49 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brad Laue <brad@brad-x.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Christophe Fergeau <cfergeau@redhat.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Divya Garg <divya.garg@nutanix.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Emilio Herrera <ehespinosa57@gmail.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Ivan Teterevkov <ivan.teterevkov@nutanix.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Lubomir Rintel <lkundrak@v3.sk>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nicolas Lécureuil <neoclust@mageia.org>
  Nicolas Lécureuil <nicolas.lecureuil@siveo.net>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Rohit Kumar <rohit.kumar3@nutanix.com>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  shenjiatong <yshxxsjt715@gmail.com>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tuguoyi <tu.guoyi@h3c.com>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Vineeth Pillai <viremana@linux.microsoft.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yasuhiko Kamata <belphegor@belbel.or.jp>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 96811 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Feb 10 09:37:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 10 Feb 2022 09:37:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269715.463794 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nI5tP-0007Ns-QE; Thu, 10 Feb 2022 09:37:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269715.463794; Thu, 10 Feb 2022 09:37:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nI5tP-0007Nl-Mq; Thu, 10 Feb 2022 09:37:35 +0000
Received: by outflank-mailman (input) for mailman id 269715;
 Thu, 10 Feb 2022 09:37:34 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=T9Dk=SZ=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nI5tO-0007MQ-9k
 for xen-devel@lists.xenproject.org; Thu, 10 Feb 2022 09:37:34 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 113e9614-8a55-11ec-8eb8-a37418f5ba1a;
 Thu, 10 Feb 2022 10:37:32 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 113e9614-8a55-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644485853;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=ts+jAeum077I+4x1/FA3ddloa98U+NxDwblYOZUOJD4=;
  b=cMw1QabvDX8nIBrY9b8u2DLm8Lrf2zr/Bbe9hb1h/QC3mjo9deLVW7nC
   Rs0basCTlP7QAmZcbHddefVJnsbHicYrDAtMAd8QTZgezniMokstnF+vz
   keqGd+IYBI8pvlyVxPZbO97p+YcSEqkRQhahJpEoCcXzpPuPXJcF3Z7+M
   0=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: YTp7Djafs6VAQeyqOo0EYxeN6NHtVMMDPMMnOTMKELJyQozdM9gmczyF3boSFQOaNb3RAl14Wv
 nsfhSKN67L0hpmYM8wVNmOOSA/PG6vOfT44iH/CnYj+HaWD7H36sGO3lz3N59rbuYuP65RAjBM
 awyAWMA3lTkQirs3Y0Z3p+qYDxqv6WvwdV9dCpNllxCWep+tE8Umz7zBHH0aXTiQ4E7TedIT8B
 JV1sKjp8gUhYqUwGmcVI33r22KZn2720nhUuD67eZD/hJGDcZpQZppgPT4BB0RPbnWbHpEWYm2
 cNuDP1AYtPxl1kLEkNVZjt9W
X-SBRS: 5.1
X-MesageID: 66128953
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:1iEftqIZhHLMtsJwFE+RaZIlxSXFcZb7ZxGr2PjKsXjdYENS3zBVn
 GodCGqPM/uPajb3fo1wbI/n9xwFv8XWz9NkTAdlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokcxIn5BC5C5xZVG/fjgqoHUVaiUakideSc+EH170Ug6w7Zg6mJVqYPR7z2l6
 IuaT/L3YDdJ6xYsWo7Dw/vewP/HlK2aVAIw5jTSV9gS1LPtvyB94KYkDbOwNxPFrrx8RYZWc
 QphIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbrGvaUXe345iXMfwZ3u7hB2Mz9df6
 9tcr6afUAgObqGSg8AcCTtXRnQW0a1uoNcrIFC6uM2XiUbHb2Ht07NlC0Re0Y8wo7gtRzsUr
 LpBdW5LPkvra+GemdpXTsF2gcsuNo/zNZ43sXB81zDJS/0hRPgvRo2Uu4YCjGZt3aiiG97nb
 sEZYjdeMy/iQDlXakoWT4oMvLu30yyXnzpw9wvO+PtfD3Lo5BdqzLHnPd7Re9qLbcZYhECVo
 iTB5WuRKhMHMN2SzxKV/3TqgfXA9QvFX4YVGKy95+RdqlSZzWwOCzUbTVK+5/K+jyaWV9tBJ
 mQO9yEprKx081akJvHiWzWorXjCuQQTM/JAHut/5AyTx6785weCGnNCXjNHcMYhtsI9WXotz
 FDht9HjCCFrsbaVYWmA7brSpjS3UQAXInUFfjQsVhYe7p/op4Rbs/7UZo89Sujv1ISzQGyuh
 WDRxMQju1kNpctb0IuY80HduR21qb+ZQlAuwgSNfG3wu2uVe7WZT4Cv7FHa69NJI4CYUkSNs
 RA4piSO0AwdJcrTzXLQGY3hCJnsvq/Ya2OE3TaDCrF8r2zFxpK1QWxHDNiSzm9NO91MRzLma
 VS7Veh5tM4KZyvCgUOajuuM5yUWIUrISIyNuhP8NIMmjn1NmOmvp3gGiam4hT6FraTUuftjU
 ap3iO71ZZrgNYxpzSCtW8AW2qIxyyY1yAv7HM6nk0j8i+LGPy7KGN/p1WdiiMhitctoRy2Pr
 b5i2zaikU0DAIUSnAGLmWLsEbz6BSdiXs2nwyCmXuWCPhBnCAkc5wz5mtscl3het/0NzI/gp
 yjlMmcBkQaXrSCXeG2iNyE4AJuyDMkXkJ7OFXF1Vbpe8yN4OtjHAWZ2X8ZfQITLA8Q9kaAqH
 6NYJ61twJ1nE1z6xtjUVrGkxKRKfxW3nwOeeS2jZTk0ZZl7QALVvNTje2PSGOMmV0JbbOMy/
 O+t0B31W50GS1gwBcracqv3nViwoWIciKR5WE6Reotff0Dl8Y5LLS3tj6Bof5FQeEubnjbKh
 RyLBRo4pPXWp9Nn+tf+mq3Z/ZyiFPFzHxQGEjCDv6q2LyTT4kGq3ZREDLSTZTnYWW6toPeia
 OxZwuvSKvoCmFoW4YNwH6wylfA15sf1pq8cxQNhRS2ZY1OuA7JmA3+HwcgQ6fEdmu4H4VO7A
 xvd9MNbNLOFPNLePGQQfAd1PP6e0fw0myXJ6ahnKkvN+yIqrqGMVl9fPkfQhXUFfqd1Ko4s3
 cwopNUSt16kkhMvP9uL0nJU+mCLIiBSWqkrrMhHUoriiw5twVBee53MTCTx5cjXOdlLN0ArJ
 B6ShbbD2OsAlhaTLSJrGCifx/dZiLQPpAtOnQ0LKFm+k9bYguM6gU9K+jMtQwUJlhhK3oqf4
 ISw25GZ8UlWwwpVuQ==
IronPort-HdrOrdr: A9a23:e8lpsqlPJ+HGMwzPhG6EXaXUvXzpDfO0imdD5ihNYBxZY6Wkfp
 +V88jzhCWZtN9OYhwdcLC7WZVpQRvnhPlICK0qTM2ftW7dyRaVxeBZnPDfKljbdREWmdQtt5
 uIH5IObeEYSGIK8foSgzPIYurIouP3iZxA7N22pxwGLXAIV0gj1XYANu/yKDwJeOAsP+teKH
 Pz3Lsim9L2Ek5nEfhTS0N1FNTrlpnurtbLcBQGDxko5E2nii6p0qfzF1y90g0FWz1C7L8++S
 yd+jaJq5mLgrWe8FvxxmXT55NZlJ/IzcZCPtWFjowwJi/3ggilSYx9U/mpvSwzosuo9FE2+e
 O86SsIDoBW0Tf8b2u1qRzi103J1ysv0WbrzRuijX7qsaXCNUQHIvsEobgcXgrS6kImst05+r
 lMxXilu51eCg6FtDjh5vDTPisa2HackD4Hq6o+nnZfWYwRZPt6tooE5n5YF58GAWbT9J0nKu
 9zF8vRjcwmPm9yV0qp/lWH/ebcHUjaRny9Mwo/U42uonRrdUlCvgolLJd1pAZEyHo/I6M0kN
 gsfJ4Y0I2mdfVmHp6VMt1xNfdfOla9MS4kD1jiU2gPNJt3ck4l+KSHqInc2omRCek1Jd0J6d
 P8bG8=
X-IronPort-AV: E=Sophos;i="5.88,358,1635220800"; 
   d="scan'208";a="66128953"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=F5o1kfBUyv3Lmhvfr0dS0hgNSPU0PFI188nmbjDFB3T+TzRxiXzpSmJFy5HHLt07sfew1gFBtO6NE7/tLnZz3pBLQG8W93qq24ML/vbPJSer55X8MHquBNS4gXkonQxqcv0O/kASlUp/Ql5qxv5TH9QU11vTXtL8DVMmpg6rHfR/QcKsvf8HZabDMnkXsHS73mr+b6fAXr7Hdb3ypW7pvZuhCNv+ieVpvY5X3+qaoavp9qPVlf2vbfYdh/a2Ya1CAxFPldgj6ApDnnkuge5o1iXgqnVzvdgLN5yK0zL7QKk4SN1S9LzxCGnyFBOWSryuJdWS0jIdndoXL1t9Kwah3g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ZtpCU4yWwOywKrjRHV4KNx2PomzcJILfNog390sO84I=;
 b=P6V3wNSF6Br7UgTz8ya1et+TvaQCm5GcmUmQMCLEPF5RSrHs004unLrifNe0wYA1wLGglZBVkySkLIn9iGaeYkMFmTec8efwevV9A/D9GekGrLeIZxJHrYyj3oieBRvjIz42AQ9nnkkCwtBd3N0OqRfZwCt5XAoX2PFll8X01wtjfjfQfYf1CYGQY9KraDyzqPhkCVX0pg3DuyDfIxyhsQPkFkhp8y2If4w+V4ZWPob22N5lN35O358sxInWrZ+IL5KWeEATJZuE3GFdQoJcJc3G4ciMCQuxwBwgcS4fzEAFsm6LVP76qhHTpPrWBXOdwcNgFBlk5ze9Mm4qqAeEIA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ZtpCU4yWwOywKrjRHV4KNx2PomzcJILfNog390sO84I=;
 b=dE/FMrq3hdtNPMZN2tfAb5K1nyOFMVsSItNTdJpgiUvLd7XTV63zyvjwWfJkpmnhxNg3oI4/wH+NLQFbZhQFhUKjD+8i+Vp7J/AQE/faHctmqHRkBmuSLwh11fFZ4u9nvhDzPCoGWZmpxmOIdi3h8c6iA8IPOx/xiWuCxHBW2SY=
Date: Thu, 10 Feb 2022 10:37:22 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jane Malalane <Jane.Malalane@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>, Anthony
 Perard <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, Andrew
 Cooper <Andrew.Cooper3@citrix.com>, George Dunlap <George.Dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>, Stefano
 Stabellini <sstabellini@kernel.org>, Christian Lindig
	<christian.lindig@citrix.com>, David Scott <dave@recoil.org>, Volodymyr
 Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v2 2/2] x86/xen: Allow per-domain usage of hardware
 virtualized APIC
Message-ID: <YgTc0sgui8f80LTS@Air-de-Roger>
References: <20220207182101.31941-1-jane.malalane@citrix.com>
 <20220207182101.31941-3-jane.malalane@citrix.com>
 <YgKXrZ/U2XuECG3d@Air-de-Roger>
 <76de6f28-f038-7e8f-ce3c-a3686112b1d4@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <76de6f28-f038-7e8f-ce3c-a3686112b1d4@citrix.com>
X-ClientProxiedBy: LO2P265CA0015.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:62::27) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4299ae34-7d04-453d-baeb-08d9ec78f33a
X-MS-TrafficTypeDiagnostic: BN6PR03MB2722:EE_
X-Microsoft-Antispam-PRVS: <BN6PR03MB2722BAC944A70F98A5D804C88F2F9@BN6PR03MB2722.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3173;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: LJJCHcgbfEIPHeA8lQH9UeEsQKCFdLmvq2gbv5l3jrhuQD4shNEbPFncaQl8rqx3+tyfPz5u4J8wg8xTT/I8zbqHxE2PlQf9TYxLTeAVHGf+fw+o4DQVYGW/pt/kKmSgdkOF3yOnKcPtJJHw/nA9EhAgg81KckpjD/f9yZ9Ae3rL4uGBrPM65ceaxLzyQwUf1iu1Pfz7ClywK2NBlYdd3Igg5xY707ZBwY1bYAVGISj7BhZ8C4O4ViJeqZZRjTFp/qAfApV0vwUIG7Qvmxb4bISjSomLj00g3gco+5NMJ8406NB4e1R+FjGJl/p5NwzNYVmCscn1sxWMvj/C8Qbx0DWFeKNYzdOFmwTnbskZZxfN72QL6X/R+B3Cf7j/IWJkoAbpKd2ri5QWGd3wVabgnJ7GB+52WKYSgXidNGhHtHy6zs7ITHHo0fTClyxBrpsu1aliT/YoVSEBBMft3ReIRolH21BhzE6hGIlihu//fzB9jXOUvD74yWlOsFRLwZiNsr/8Ox8Q6+Xy4n4v2TWw5h9lipl3SnlblWEFwxyk+QM2lEG21GUJsHmW5yb+y0QbDecAXVXxiFjphcUKQpIxD+Rxsf0ay3ztULQm8+mQ6n+Wt7RTzSqyn13f2zfR2/3Eci82TPbUWXVc1PdZLBG2ag==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(8676002)(6862004)(4326008)(53546011)(6486002)(8936002)(66946007)(508600001)(5660300002)(66476007)(66556008)(6666004)(38100700002)(6506007)(82960400001)(186003)(26005)(83380400001)(6636002)(316002)(54906003)(9686003)(33716001)(2906002)(6512007)(86362001)(85182001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OTVUeXVPUC80ajd0SHluVXpVbmthVXQ1Q3JqUnVFeTRNcy9iOGJsb2pFaVZD?=
 =?utf-8?B?NlorWlE5YThiT3dMRnNncG96eGRldCt1ZWZZUlVKN2dLYkhuakd4M0c0L2dF?=
 =?utf-8?B?eXJVQUVVK3FNVmF3c3JPL0JnNEIyN1dxeXhzQ0grTmV6UTBsQ3hRZ3JvSkZi?=
 =?utf-8?B?MmFYRm5zRzZCV1daOFNQNkdoUkViTU0vVjZXWm8vMFc1bWkyUjkrVXcrZXhK?=
 =?utf-8?B?ZzBCVkFvT0dnUG8yU0lQTUxmWUttV2QyZUh4Ui8zVm1pZVh6c2Y5NzZ1YWRs?=
 =?utf-8?B?Q1BvRjZkcUV6YkVDbER6OXlZd1lKU2U4WThOUlRYbkZXaU9lYjZZbHJacUUy?=
 =?utf-8?B?R0l2M2ExZmErQjNUSm5wMmZaNkRiL0ZBeWlTS0RIZnF4S2E0dHFwWUpXSHRj?=
 =?utf-8?B?aHFPa2VqZmg2RnludEU4eFNoaG1yR1JRdllzM2J1UENXN080Z3hIV3FVeU9t?=
 =?utf-8?B?Y2ZJck9XUTJWM1c0WWlVOEpocGRCMWczQllvKzVZWXVuc2kwMWFQeHNURVpu?=
 =?utf-8?B?OFE3QXpJSDZHNUlzVFh2Vk8vOTRTVEZuS0luZk5VZElhNUVwMEFxd3hLeElY?=
 =?utf-8?B?NjgyYmZRZ1YrTGtzbFpkRVZ0SVUxQ0wwVGFHVG9ERDRZUEwxdDJTczM5WG0v?=
 =?utf-8?B?Q2RaTGg1a3NNMmRJbGo3dUdOWUhpSzBSVnJRSkl4dE5WU3ByVVNsaUVDWDMz?=
 =?utf-8?B?WCtwemthZ3hPbC9YTUhUSmF4ZkhjOUQrdXVKdG02L3ZCTnB0eHI4TkhkOGhY?=
 =?utf-8?B?ek0wRUxCVjVyN3pMZkJBdFZ0ZjIycElMU1pjeTl1Z1hsTm5PRmhVUGpvM2JG?=
 =?utf-8?B?VkNNWkYxYVNjcnU3MWd6UUhaSmZkUTRQaHB0WlRPOTQzdWdWUjIzK1JEU1VW?=
 =?utf-8?B?OW9ZRjJxRW1VVGdLRkFOOVhNMUJIempnRzVZb1RxRjZMamlCdHp2ZVVEbjZ0?=
 =?utf-8?B?bEhDbnNpVTBncWJ0WG4xd2ttenRzMGplQ3NkSzhSUGpQREFsTVpwWEJxYTla?=
 =?utf-8?B?ekIxVHErc1ZqTEovb2xzUUtkZXA2dG9TbW52dWtQSzA2Mis0Qm9PNnZSZzhJ?=
 =?utf-8?B?NWNUZWY5N3c1YTZsZytWMFh1cEtZMGMraUpjU1ZRVWJsWGRxRjlHQnYySlJP?=
 =?utf-8?B?dDhVWjZXS0NJRU5wdXB2cTNwMjc5aUlvOWNhbnNBWlhnME5vVzhMT3JZSUh5?=
 =?utf-8?B?RDZVWHZQaDFBODNzRk8xYWlZTklMUzhFY3ZMZFNKSzIvRDJrSjdBdi9PNGJK?=
 =?utf-8?B?cW5EZTRvaiswOFAzRUlVeWU2Y2FtbjM1ZVNQUVNWellpWXJVbXRNY0ZOdmtJ?=
 =?utf-8?B?ZHFaa011ZmdpSmhqYmhMWjJPcUwzOTFoRlBWUFBQUlluT0o0aGIyZGZzbXBR?=
 =?utf-8?B?NCtUNlVjNThPTmxydmhHYUx0bkFuRThIQnIxdVdMNzZYL3FnN1k0U3hZMk9T?=
 =?utf-8?B?WUlsT1B1aEJ1MHJjYWpnMEhaT3E1ZE9QV05oZHFYQ1dHT3pPRTV5SWxueW54?=
 =?utf-8?B?ZVhsOUpmYnBVWGxpT1NWcEhZYSsyWXRnWWcvVjl0VlJubXk1cUlKYnhmSUVT?=
 =?utf-8?B?dU5PUVlQM2FFNUN5LytYYk42VmZ4K2hSRE9kdzhyV3Z3a2k4MklnelhtdGFD?=
 =?utf-8?B?SEt1bnV1cUIrZzh6RExLVzd2MjF4Y2E4TFVheUJoaERrQ0EvczJhRnBUaEVV?=
 =?utf-8?B?b3FVcGduSlljWTJhdzBPL2xvckpQQUtaWkFUNnVnRCswN29TZE15YVdBMmZ4?=
 =?utf-8?B?TzlPSFc2cmdKelR6THFPTjFkZkdWd29jdk9saS9kWktHTk5VaXltTmdnR1dY?=
 =?utf-8?B?T3llWm5HMnBPRjAxTjgrZkE1Vkt6RW9mYVVTbWFQYStadmxGSHhTd1dicTFv?=
 =?utf-8?B?SEVZbVBVZ0dsS2dkVmovRnM3ZDRLS0VJcWdvRklDbTFIeVRWRVpBbFlIeG96?=
 =?utf-8?B?eDZleGs1TzRyNzdIZlg3K096TEFaOVNuTVliYkVMRnZFUFY1ZENRaSsvL1Bk?=
 =?utf-8?B?MGtmMzY2dFQySi9qR3lFcjQ0eXBFeVphVUhORzFkL3ZoWktZdUdtTEtGQkJ3?=
 =?utf-8?B?bVo0MGVHRUhxY0FKZE9OcjRhbDhWbWF5bHNVZUhaOGVZT2YxdjQ5aGRiOU9k?=
 =?utf-8?B?TWpKTzd0T1haR2VyNU1oL050N0RhWnQ3eTNWZ0w2NzBGSHNkclNxUzRoV2c5?=
 =?utf-8?Q?eaq7fK8J9ifozqsrPf82RDQ=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4299ae34-7d04-453d-baeb-08d9ec78f33a
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2022 09:37:27.3234
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wpuZLR6nLANXoFMUic+Ec7f0rCq3meTqedZzFXV1REHOOsPk441c0N8U4ArPT9xLzD54IOGakXoG0MBjMFXI5A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2722
X-OriginatorOrg: citrix.com

On Wed, Feb 09, 2022 at 10:57:28AM +0000, Jane Malalane wrote:
> On 08/02/2022 16:17, Roger Pau Monné wrote:
> > On Mon, Feb 07, 2022 at 06:21:01PM +0000, Jane Malalane wrote:
> >> diff --git a/xen/arch/x86/traps.c b/xen/arch/x86/traps.c
> >> index 485bd66971..33694acc99 100644
> >> --- a/xen/arch/x86/traps.c
> >> +++ b/xen/arch/x86/traps.c
> >> @@ -1115,7 +1115,8 @@ void cpuid_hypervisor_leaves(const struct vcpu *v, uint32_t leaf,
> >>           if ( !is_hvm_domain(d) || subleaf != 0 )
> >>               break;
> >>   
> >> -        if ( cpu_has_vmx_apic_reg_virt )
> >> +        if ( cpu_has_vmx_apic_reg_virt &&
> > 
> > You can drop the cpu_has_vmx_apic_reg_virt check here, if
> > cpu_has_vmx_apic_reg_virt is false assisted_xapic won't be set to true.
> Oh, but assisted_xapic_available is only set to depend on 
> cpu_has_vmx_virtualize_apic_accesses, unless I should correct this, but 
>   I might be missing something...

No, you are right. We only report hw virtualized xAPIC to guests if
both apic_reg_virt and virtualize_apic_accesses are available.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Thu Feb 10 09:38:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 10 Feb 2022 09:38:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269723.463805 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nI5tw-0007z5-7Q; Thu, 10 Feb 2022 09:38:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269723.463805; Thu, 10 Feb 2022 09:38:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nI5tw-0007yy-3z; Thu, 10 Feb 2022 09:38:08 +0000
Received: by outflank-mailman (input) for mailman id 269723;
 Thu, 10 Feb 2022 09:38:07 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=4tMu=SZ=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nI5tu-0007MQ-WC
 for xen-devel@lists.xenproject.org; Thu, 10 Feb 2022 09:38:07 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2625d32f-8a55-11ec-8eb8-a37418f5ba1a;
 Thu, 10 Feb 2022 10:38:06 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2168.outbound.protection.outlook.com [104.47.17.168]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-32-UqynWL_zOJyxg0VGlgjb0A-1; Thu, 10 Feb 2022 10:38:04 +0100
Received: from AM0PR04MB5587.eurprd04.prod.outlook.com (2603:10a6:208:125::12)
 by AM9PR04MB8226.eurprd04.prod.outlook.com (2603:10a6:20b:3ea::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Thu, 10 Feb
 2022 09:38:03 +0000
Received: from AM0PR04MB5587.eurprd04.prod.outlook.com
 ([fe80::54e:e7d:545a:da84]) by AM0PR04MB5587.eurprd04.prod.outlook.com
 ([fe80::54e:e7d:545a:da84%3]) with mapi id 15.20.4951.019; Thu, 10 Feb 2022
 09:38:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2625d32f-8a55-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644485885;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=m5q6dxP/k7rShSl19FkBcKcwKdpKKn40N5IXShciDLY=;
	b=OaBB7SGRrWeJbCn94GUJ1+eQLLayG0Prwbhelx6lgXFZhDm07qvAOOUGPHNwYa+HPJ9KHQ
	4mZeiB5JM7KDSk+g3Np4dACgOpIEfwGOINkMQdaET8v+VyWPR1AxvmMq7jd7COaSBf0FnH
	l8dAvT48GvZ2ByxuafzmTsoQ2S40tgw=
X-MC-Unique: UqynWL_zOJyxg0VGlgjb0A-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=G7pVBWX9mXBzlqpTeBGTHWjikGptsKKgsJjVWa/zSRwgGiEOzmZScAGXpQruA/lmQv2u2tV9gkYmarkuOO0AY++9OTJwKLrRqIVfmBVrsiFrPAYCVHkqlOyWI7I2qKN0Hqdjhaf2QOqA8UgdStQhCg+fnKeJHy8SrnTXF6w3LW4P1Gjb1PXkySlfMNT0GIWdnMLxJFyXtWaRznWYCPi96EpU9bwhnZ2GF3rJGaKa98DZ5H8BsGVmivDjBJfK6NCFPkCoUPBzSO7YGhf8yYMdHgEyC3t1Y2l76Zs7XfcGEP3/rmCvKgjOlDfXB3nkpdMoEpneswJlMnqXTGxodjLnbA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=m5q6dxP/k7rShSl19FkBcKcwKdpKKn40N5IXShciDLY=;
 b=EnGshvLDUeTX2UY2Dv8rt60HESmQI7MyY1uqYWOo2LoKDpp+hWq0ifq+oqaSB5dl4vojEm2d/dETMmJQKOxtjEE/QeXVwRjxfGVUlSZ1njydib6ls28U4nsCRu8+rb3wASGiMEm61qE3sv3rJZRyk/IArFa76AZ1FU3gO/vDku635Y4c0JH/XsV5OrIol48SMOBUZ8b8VMYWjFIVqAVww/BSyk0WrOqCCV0k3tcS/hXOBUYQ3uXbQ/PhRlhFMu5KIm0IhyOQKUW+SapP323hppp83mqGcsGbhl8Ri+1M0iI7DR5QwqbHe8DPyZb3MAVTTPF4BTMK924iW2p+lU+mpw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <a88f2f3a-5a6e-5f4f-dfa9-ce1f7121868e@suse.com>
Date: Thu, 10 Feb 2022 10:38:01 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH v3] x86: Prioritize low memory size from Multiboot
Content-Language: en-US
To: Tu Dinh Ngoc <dinhngoc.tu@irit.fr>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, xen-devel@lists.xenproject.org
References: <000c01d81dcae25e6f0irit.fr>
 <20220210084436.84-1-dinhngoc.tu@irit.fr>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220210084436.84-1-dinhngoc.tu@irit.fr>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR3P281CA0041.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:4a::17) To AM0PR04MB5587.eurprd04.prod.outlook.com
 (2603:10a6:208:125::12)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: bd3dc8bf-39e4-49e0-b965-08d9ec790886
X-MS-TrafficTypeDiagnostic: AM9PR04MB8226:EE_
X-Microsoft-Antispam-PRVS:
	<AM9PR04MB82269F09A836F14628A58B23B32F9@AM9PR04MB8226.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	3BEYmEL1AXumc9CIeC5kV8L0hqlguNC1UWW/+eniXpC9xo9DUpaeWTUoA8nKcxQzD8AvZMLb7jfus2aTKCSVGqrAUb9cSsq2n7Mgdaae/ooa7WjQc6YJsIPM+ygCrRDOBgYku6AxAtExNBxILh3SXKwYo8L0oKETbS2koSeJo14kExNTTvktWRkgPK9sg3Ye3oB4Ao1k7iEDOn6QBZtsfINusV2ib/wj3OFhbSIFwDurXRKGHpjB5erw0+Ka06riCa/E+9RbsDOHC00Lv5PmK9W6p1SwQsjY6BTzIgwfB0KtzfO6WQJkFlrWLYkYAbhkqnCJY4yhp1q8UMOrX6iBcTqse2JHbBCO3k2TZO5RoTGtP/vpb8iLaJse4Jm6ujGmNh/f2F+H8n9Qct790vT6uO/+rgvfemwJ63alL6by7vF9tpTTF1nlDRz6LQF/u05vir/Xx41gWS3q+FPDTkx4LLbCYjDAXzSuU1A61vUPqokXD2Vrok9gtYHDAal+2Pzuxp6L6Acy2ZtEaPvDe8FBoZvI9rZTPQXQMhR665VP7+bxs5aobqXrQ0Q01m5GITQTiR5cUwlsxZWlt3tffkWBu/b3vycXaJByQ1TULm1T+Iy5Ckn4+9Hh4sf4BmtAAO//txSSXlYwfs3I9ECi/wNPHzHBouT1z91cawAkzeo1T5svsO/FDKHwgJZzcjFSKQ7pdmMAHJQppxhIfZ38+RUzUyJ4h+clj2q3do1+o2AphbU=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR04MB5587.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6512007)(2906002)(54906003)(6916009)(6486002)(38100700002)(36756003)(186003)(26005)(5660300002)(316002)(2616005)(66476007)(8676002)(31686004)(86362001)(508600001)(66556008)(4326008)(66946007)(83380400001)(8936002)(31696002)(53546011)(6506007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ME1tb0VLS3ZvYjdQK1lybDFjSnBxenpHTndicFR6Z093NVZoUlIxdktQRUl6?=
 =?utf-8?B?RHROa0NqaUVaa09IMUE2MGNOWGFrekRtVFF3WGpudW5oeEV5Q3RXVXAzZ1ZQ?=
 =?utf-8?B?TGk2eE1JMVpmUS9VTHBoa1gzbFF3SXF0ejhEOVE5QndjOVB4S0tlNmtidDlk?=
 =?utf-8?B?MHYwNzVhcXVOOVgrbU1HM0pCRVhad1JwTnExc2RnWk9WdSs4RXYxWFhWSkp5?=
 =?utf-8?B?MHBud0RYdkF4NlNnRE9OWUVPbWdNRDlEaTZiOVVmK3RpeDRDczZZdGFLdEI1?=
 =?utf-8?B?dzE0d2MyZ3ZGZkRaYzlvbWo3V0lOcE5KNmFsRSs2VFlmZWFYU2I1aDBZT3FB?=
 =?utf-8?B?ZlN5cllteG5YeThoMnY2YmZoSmpWNmk1ekw0RFE5N2w4MlB5YWJJQmwySU1D?=
 =?utf-8?B?azkzNUFBL2F1ekRPS21nZ21jMnVKMnVKK0RYemduaitiWDlOSFNTZ2NQamlI?=
 =?utf-8?B?ejZQVkNVaEZ4RzVsV1o5d0ZPNmFuLzVwdll1NURjQzhEanp1Rm5WeTRUTlpD?=
 =?utf-8?B?MjUzZTE1bmZoNGg5RzREMDZTQ2VTcmRta2NaUENxRHM5L29kcENWWGVJU2lI?=
 =?utf-8?B?dlE5NGxMQU5VSnlJcXhNRDV1eTA1WDZ0Ty80TVRLZU9JOGxiT0FjNHpRS0Yy?=
 =?utf-8?B?NXZaTzQ5NWFIbXZNR3FvTkRmcndqWGR5cWtpckxmbjQweVJiRjVob2tDUlgr?=
 =?utf-8?B?d3ZMcTZpWnlYR2tsYVBlV1NDNVBtVEFRNnVXVVJuTXdaZE03dyt2Q1Q1N2p0?=
 =?utf-8?B?NGxJY0pLU1VwdnRjeCt6RTNENEtidE1mQmNUZG44MHVFemNNU0F5YjdOb2ZF?=
 =?utf-8?B?QW9GVDFmZXNROXIyZ1dvNVo2SjVqK041QXZTVTZiY2V5a1Zwb2RZbW40L29U?=
 =?utf-8?B?MVoxdGVNYkN6OHB4MXVXa0c3UEtmKzdDWmdHWm5rU3dXR09qUFZnWHJDYUc0?=
 =?utf-8?B?bWpCenFON3E0Z21DNm1INmYvMC8zbzZxeER0b3g0T1NWNmRRZzhraGpycDlE?=
 =?utf-8?B?K1ZLNWMzamFVQVdYN25vSEJNOWFwbkxsVXN3UzByYmlxVFFzMVcweVM3dWxi?=
 =?utf-8?B?RlF5TU5vclZPbEVLRk5zdmpuTElORTVIL3pXV1FIcTVXMlRqME5udXZEcGNo?=
 =?utf-8?B?akhhUE9DRVpTL0lING9zZEtXb21PMGtYa0xGRUZIajVaUGwzdHp1aUp5VWxn?=
 =?utf-8?B?aVRVZ2ZjNlVlaklBUzR6azJBVmdCOVFMTlBrS0pqZUlkRjIxWXR5RDhaS0FR?=
 =?utf-8?B?N2NQQ3U1d1NUUnRqU3hiTElZeEsrVU1WaTQwN2Y1NDVINVNHdWkxSGlzM0FL?=
 =?utf-8?B?a1owaEdJL0ZWc2xSM2QwbUV5bzQ5MTM2VlZYajBIQjlZR1JCRlBuejdBQlZE?=
 =?utf-8?B?YXQxU2l4TkUzNWVTS3o5bndGaTdqZW1KbE5oSnVGbkVscFNoOW5YdG8vejN4?=
 =?utf-8?B?Kzd0QUJvZGdDMXk2K3UySU93SWxQc2MzTU16S1V3TFkySHQ5d1VUMjkzR2dY?=
 =?utf-8?B?TUZ4RmZ4R2FsMmJkSzBnMFdKNGdYcGVMYzhxYm0zYTBZMm1jcHpzRUNuQlJ4?=
 =?utf-8?B?dDRGb0paSHRsWTZtVzNYdnAzZTNoVzJjRURSYWhGNGVXSldJbGJBZ0pFVFRN?=
 =?utf-8?B?RjJOb09aL014Y1Voc3FCMTBrZXBCY1hwZU9WODhiZkU0ai9lRXVsZ0dXcjJL?=
 =?utf-8?B?c0U0SWxZUmd4SzdvZ2o5bSs4OEI0cEt0SFc2ZWNQVzIyZ1hKY3ZRV1J4NzZs?=
 =?utf-8?B?QUVjMWt1ZWZxUFVzUzZTcDZaZ2ZwWXl4OHp3cDIyUXpmY0Fqak9VUVpmTVI4?=
 =?utf-8?B?Y3VIRnFVV2cwZ2JjV0lLUEFhV2p3N1N4MjcveWJyU0FyNXRqTHp0SW1ZUGxq?=
 =?utf-8?B?Qk1QVzV2YmZGV1JVNnl1Z0FUUmc3VG9QQXFGZHRSNk5HK21NWXNuWVAxNUx4?=
 =?utf-8?B?TncvaXkxekRTNEtyRWw3S1N3SGFtcEJNaVYrdktFbzFyVndUS1JldEtkeUZG?=
 =?utf-8?B?UkJyZDU3bVhkM1VGSDIrNmR5eCtrZE9BWjZCRTFOZERHL1RHbWVPQ1dNQ3RL?=
 =?utf-8?B?Q20xY0lUaUtvSE5MVmtqQ1N5L09zSlorUjBOYXRmQnM3Y0lFVnYwQTVNSHhy?=
 =?utf-8?B?eUZYMzdtZklDTGN4eHZYb1A4MXlLY0krUkwxU0NrQU5pbTRueTNhQ1BENzBj?=
 =?utf-8?Q?M+Ua77naaeQg4NmNrMvLBhg=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bd3dc8bf-39e4-49e0-b965-08d9ec790886
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB5587.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2022 09:38:02.8505
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IKl8FqXye+HnENXCwLxLaJwHudYTI7C2pUttFcgvdJnOr/15nn/d4UEngtdIUvGIanLfIxiG20m90hxoW9oFxQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8226

On 10.02.2022 09:44, Tu Dinh Ngoc wrote:
> Previously, Xen used information from the BDA to detect the amount of
> available low memory. This does not work on some scenarios such as
> Coreboot, or when booting from Kexec on a UEFI system without CSM.
> 
> Prioritize the information supplied by Multiboot instead. If this is not
> available, fall back to the old BDA method.

You're still failing to provide information on why this would be a safe
thing to do. In the absence of such, prior behavior has to be retained,
and only the special case you're after wants adjusting for. This is
first and foremost (but not limited to) you moving to ...

> --- a/xen/arch/x86/boot/head.S
> +++ b/xen/arch/x86/boot/head.S
> @@ -524,27 +524,41 @@ trampoline_bios_setup:
>          mov     %ecx,%fs
>          mov     %ecx,%gs
>  
> -        /* Set up trampoline segment 64k below EBDA */
> -        movzwl  0x40e,%ecx          /* EBDA segment */
> -        cmp     $0xa000,%ecx        /* sanity check (high) */
> -        jae     0f
> -        cmp     $0x4000,%ecx        /* sanity check (low) */
> -        jae     1f
> +        /* Check if Multiboot provides us with low memory size. */
> +        mov     %edx,%ecx
> +        test    %ecx,%ecx
> +        jz      1f

... checking for just zero, when originally ...

> +        /*
> +         * Old Kexec used to report memory sizes in bytes instead of kilobytes
> +         * like it's supposed to.
> +         *
> +         * If Multiboot reports more than 640 KB of low memory, assume we have
> +         * this problem.
> +         */
> +        cmp     $640,%ecx
> +        jbe     0f
> +        shr     $10,%ecx
>  0:
> -        movzwl  0x413,%ecx          /* use base memory size on failure */
> +        /* %ecx now contains the low memory size in kilobytes. */
>          shl     $10-4,%ecx
> +        jmp     3f
> +
>  1:
>          /*
> -         * Compare the value in the BDA with the information from the
> -         * multiboot structure (if available) and use the smallest.
> +         * Multiboot doesn't provide us with memory info. Set up trampoline
> +         * segment 64k below EBDA as fallback.
>           */
> -        cmp     $0x100,%edx         /* is the multiboot value too small? */
> -        jb      2f                  /* if so, do not use it */

... the boundary was 0x100.

It was for this reason why in reply to v1 I did ask "Is the kexec case
recognizable by any means (including [...]), such that we could skip
using the BDA value in that case?" If it wasn't clear, I did mean
_just_ in this case.

> -        shl     $10-4,%edx
> -        cmp     %ecx,%edx           /* compare with BDA value */
> -        cmovb   %edx,%ecx           /* and use the smaller */
> -
> +        movzwl  0x40e,%ecx          /* EBDA segment */
> +        cmp     $0xa000,%ecx        /* sanity check (high) */
> +        jae     2f
> +        cmp     $0x4000,%ecx        /* sanity check (low) */
> +        jae     3f
>  2:
> +        movzwl  0x413,%ecx          /* use base memory size on failure */
> +        shl     $10-4,%ecx

I don't see why this shift can't be folded with the other one, by
moving it ...

> +
> +3:

... below here (and removing the one further up).

Jan

>          /* Reserve memory for the trampoline and the low-memory stack. */
>          sub     $((TRAMPOLINE_SPACE+TRAMPOLINE_STACK_SPACE)>>4),%ecx
>  



From xen-devel-bounces@lists.xenproject.org Thu Feb 10 09:44:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 10 Feb 2022 09:44:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269737.463815 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nI60I-000111-UI; Thu, 10 Feb 2022 09:44:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269737.463815; Thu, 10 Feb 2022 09:44:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nI60I-00010u-RD; Thu, 10 Feb 2022 09:44:42 +0000
Received: by outflank-mailman (input) for mailman id 269737;
 Thu, 10 Feb 2022 09:44:41 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=227Y=SZ=epam.com=prvs=404006422a=oleksii_moisieiev@srs-se1.protection.inumbo.net>)
 id 1nI60H-00010o-U6
 for xen-devel@lists.xenproject.org; Thu, 10 Feb 2022 09:44:41 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 10962d61-8a56-11ec-8f75-fffcc8bd4f1a;
 Thu, 10 Feb 2022 10:44:40 +0100 (CET)
Received: from pps.filterd (m0174680.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 21A9gnBb024521;
 Thu, 10 Feb 2022 09:44:35 GMT
Received: from eur01-ve1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2059.outbound.protection.outlook.com [104.47.1.59])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3e4yy882r3-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Thu, 10 Feb 2022 09:44:35 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com (2603:10a6:102:ea::23)
 by AM0PR0302MB3393.eurprd03.prod.outlook.com (2603:10a6:208:11::26)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Thu, 10 Feb
 2022 09:38:55 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::c1c:f98:9dd:86e0]) by PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::c1c:f98:9dd:86e0%6]) with mapi id 15.20.4975.011; Thu, 10 Feb 2022
 09:38:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 10962d61-8a56-11ec-8f75-fffcc8bd4f1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=dEnuQopIOWEqKnp1FruWnO14TdNe8VjX49wOO4x+6MbDnmHGEGjuFAyPQzfyKaZj2IBAwpv8S59HlyqSNbWtoChYIVCYZdI0mZZsjqfsdRyJOSz/oFRhri6iwPaaL9+5ZqS7hUKvPpl4uw7JkvVa96v/NVCVCfa16kxtrcku2EbuLPZJjNebY9RIDjHum5uKH5Fq5dxutZ7GMKRpmfL9lrLDS+GurcaorNK7ITQnUP071TAFp72cBzd+7VmgSQYl9R2LaWuWs8QHkusG6g6ZvzbLcgPGDHeif2gqACkeF/Hlf3RsiX+vfA0Ag+5lJaCJwRM4VZiMU88w3tBBDBWrpA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=uEqkvuJ5/4V8NnvZAKxYIs6jlIia3JW/ziM1jfYuOUA=;
 b=lCPaHpjzIWUk75jGCHgrX1UPegRKr4Y2HIlDRmXC83px35SYjt7LInSWs5XEnXUeLYhmZl5ZcY3lC3HlVdJeFpWxJCyv8jKC0yZBFyJc4r1Y+s9uc7BnXLfIwzgVFAlVz0TRTtKXbwEztA4A0dsf+jKf4GZAo+21KORRbrqSggCXtg/DCU1Obai8tzNx3b6z/8j8GiBo1L4De1V9HPdsCxqHsyP/RkhYZwMmswxyYYO2kJOjXLr9r79ARFGYn9H20LgEH/WG3lwtrvuEpamrrfbjpiiHdLfboUfTF3NW7V8nf3Ui2h8+YCJBIgf550iHKv5Y+sHFRz6bNEhf/JXxVA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=uEqkvuJ5/4V8NnvZAKxYIs6jlIia3JW/ziM1jfYuOUA=;
 b=XcLDnHpuxCZFdc+s2oIfmdOizqNlhPTzjP+ZGyb11V+f36URjSc9WhCi3vldd52c+V/CqjwJ2hnMhDOTZx1c3dPSezsqC2m78MVF5vDwtY4If3UzYW9HjCGRIFTe56DQr6Agb6eECDuRpoxjLLFDWSi8go5mFZZl1A/RN3lF3E8Qtv8lB26DoMYkv4TLKX++TCqwGnrt2Bhur/7CS65fJihCpKpg/sOWE4AIcmvaeSRPf51nmWF1wjNihddztOi1hm3VF8kIMynKx3dZ2HDo9zGB/2RcptMThfkKD3LC7O1NZXV1UfIPDFwBsG7aefRrVNJshSW4+NMdTlgxblSF7w==
From: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
To: Julien Grall <julien@xen.org>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        Stefano
 Stabellini <sstabellini@kernel.org>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Juergen Gross <jgross@suse.com>
Subject: Re: [RFC v2 3/8] xen/arm: Export host device-tree to hypfs
Thread-Topic: [RFC v2 3/8] xen/arm: Export host device-tree to hypfs
Thread-Index: 
 AQHYHRW1S717SraA0Ui+K6wc2/TNAKyJ+LkAgAEKd4CAACCZgIAAbkMAgAAMBYCAAOvKAA==
Date: Thu, 10 Feb 2022 09:38:53 +0000
Message-ID: <20220210093852.GA1700852@EPUAKYIW015D>
References: <cover.1644341635.git.oleksii_moisieiev@epam.com>
 <e440e4f16a506ecc87078635dbb3fda2ebd45346.1644341635.git.oleksii_moisieiev@epam.com>
 <b88f6a50-6e9e-5679-8d25-89e26031e88e@xen.org>
 <20220209102037.GA1025795@EPUAKYIW015D>
 <316bd101-af8b-d2f0-1db5-ea6c583acd59@xen.org>
 <20220209185156.GA1475048@EPUAKYIW015D>
 <6fcf1e16-0c9d-c871-76b7-59d9311e9db4@xen.org>
In-Reply-To: <6fcf1e16-0c9d-c871-76b7-59d9311e9db4@xen.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 2fbd6a43-28b2-4621-5436-08d9ec7926b9
x-ms-traffictypediagnostic: AM0PR0302MB3393:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM0PR0302MB3393E840FD5D04DB28DB1873E32F9@AM0PR0302MB3393.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 FQikJ/3zTqfAmH0LrwPp3ZlXHtYGUidujtZ+4sDuqYmlN8Pss8wWSKlt3ZXTUGt0KDeOSZJQZkoCBpjroKsWOYCNMLrya1as1PX8Z21noTIu8YXZ/NWGDuXKWomsdOe0FC4Ufvm0w9yRNzxsFox+N7lVVz+m0aRrfneEJKG3AHTIqjcgzwRdjospzyYxBBKtAJt98RQxYpQz3hkG2tZotEpPk+mWDnS75p+O8xzeKbkCHN4pO1o9ia7Eanpb8GuqyLZhQR0Zp/54q+PoqhRxu/Rv2MU6lBmYdPj1wyFelQpYniuBGDF0zzt9WaotP/Gw9cRP6RMIHHLqvuCB3cYRnnD4tnhUO2Qhwd5VY25KT0vHnALmQEnrtxRIMvfarrqVPRQ5JZAjQUWZ3mfqXAoEllnSTtjxP3bH0riBXXMQERWBI71IiJEipn5P+yDyT2kbSLrWgbnb8b3BvNWrFto5zzDc0qdPgFd+OHkS5jpxu5fn4AFb1ahNpJNX0CipzEqB8zltoe0eDcOgEnnC3lhrKC6IlgwI02EAsvw02kNp3at0ao1k12Avu75dDfY/nUL9Y73IVmFAqdSiy7xxyevwqaRaD55xo608JfDGU2pXh2kRtigmD5kaA+OADPxjMfrakRKNnd8Clc/qMLsQhjy9UlueOmlhKJAl0sU+64rAOK9P2A2kz7eqZaGT/1NUJlKOHKR+BlhIER2htPMpiDuPJQ==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR03MB7136.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(5660300002)(33656002)(8936002)(71200400001)(53546011)(186003)(83380400001)(2906002)(38070700005)(66446008)(54906003)(38100700002)(26005)(86362001)(508600001)(66476007)(6486002)(6512007)(91956017)(122000001)(9686003)(66946007)(76116006)(6916009)(64756008)(8676002)(6506007)(316002)(1076003)(33716001)(66556008)(4326008);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?gO+PdyjdI4r0FMMjljk6FvwzLYP3RB4/ntn3YzMIwCHg6Rr9QyMctJlocTw4?=
 =?us-ascii?Q?55xmAiQ9jzp52LiMC7UOUcEL452SHHra7EYW6MStg7LUbuEGkTjvrdAOV/E5?=
 =?us-ascii?Q?tPV5rE9Rgob9lkWgeSYX8F3kdrJbnOzzn3pKs161mKMDeuDJ16feTadVBb6Z?=
 =?us-ascii?Q?V1D89eFCcjtPosPFMjEEE/pkusmS/iFNJY1XkF/XGVl8l2Xpfja6b2PqdIRw?=
 =?us-ascii?Q?mgtlmnEK185YTiPDG5uBnHh+OnE1fo8sVH9gOg4wF6PkVysE/qDamwgdeK90?=
 =?us-ascii?Q?HEZUr8O9tk9e6tgAlQZmUAxCO0dLGS9t879J9FJymqphKtBuFtsejNW5iF30?=
 =?us-ascii?Q?7KPrVGeyBHjwqzjVxvpGA/CnIXKmdPATbfKVHLsEZxdkkuSK7f20vrGY9XPt?=
 =?us-ascii?Q?BzYgV4WD5WIbRDmLpXweexFzMFNzjOFsrDcIBrvZKwXbLc7RkNLh/koP83gZ?=
 =?us-ascii?Q?f/zfaNJemm49EHpZGBi+NwgFLZA7m7hhhAL/Ae2uEKOpSe/jqv4QFS99Hzq1?=
 =?us-ascii?Q?mmTBaIw34bzC9C1sMTHM74APjETFSVG0t1pb8wPWBEfIpwCcOTlwTWw8p+25?=
 =?us-ascii?Q?8JeqLKsjbFPlVwdfzU2AJI9hErG8r4znfZdOmNP5qR5zu5bOBD30A9DiKchg?=
 =?us-ascii?Q?vpKcLuvElUa4eLCKcEs7AgKvBz74/R7zfVE+3RydVKX0TXybm1afyolIkdKf?=
 =?us-ascii?Q?VepPm0PyNcU03tUDtZmrncqI2PI217AzSA+0rUsrL7mzFN8n+sHKf7lck6El?=
 =?us-ascii?Q?mEaEI9yQVhceveEjZJ1zw5fYv5tDc7trHKqFthpZG71erpPczRIxIPRvxoX4?=
 =?us-ascii?Q?9+lta71oNAMxmT5eU39oEWuBRb+YFFy6L/N1LB6F2ba56Nx/5Y1IYSGrFQ9h?=
 =?us-ascii?Q?goj5F1/LT/e3aACU5JIsTLMJud96jf32UU5aBfHlRspaxzHtwmZVIwq8hQsJ?=
 =?us-ascii?Q?Ej8rWtKhPHTKo3g97dFnInyQYksnZpN4fJc7MeR+TQCpMep1VDETczL8we5a?=
 =?us-ascii?Q?BIPz/nJvPEoaxnCnx4YgDDIA8/eOw+Vi3Nhfdy4PUcClvJSRp2+0g8rueNPF?=
 =?us-ascii?Q?uhxuMeGMnu2jgWZpg7MqVa3ELjW78hC00eXtNQ2NDF5cGx1PUvaVHbgjlOB1?=
 =?us-ascii?Q?dI6QOxHvXkwOSvNst5JHp+batT9ZNmk8a9K/vvfUcMJV8+nv8zkmayaPrhKy?=
 =?us-ascii?Q?I1zHly7iRtASB3kvQOq3i4i5Gxl9CxrVBLlUkkxMPptf6QQPO7ELdevSBxkh?=
 =?us-ascii?Q?dOqcXyADXTOkCnbJo1ANwIBorSyBk8sPKNOLOO8TcYGDmvioyWgOMHQkt1fy?=
 =?us-ascii?Q?oCu/NIaXqouvQ6gSxOpPGOVxy5dNDIu43ztL8ukXWCaV7U1q/pPhscmJioh+?=
 =?us-ascii?Q?oIXDKq9wxfuK7BnYGqFTFiK4AHA3WRowTxqs2PL69XK+WgiDlzAftWjaOTg0?=
 =?us-ascii?Q?iG+2mlalVeq0APyDBtldGmAhV72bVOZurd64/32yR940ZVIZ5cZBiLqmGFGX?=
 =?us-ascii?Q?uPUZ2NTUzElYtkuoz8aJS7viUOS0Uz42jV0dz7GO6ivkpbvkVkB2wCuqt0JW?=
 =?us-ascii?Q?p6EmhBovqpz/9Mbs6A+aQTBZPpP92OiDPsxLtZZkZ32HVrtP/ytr5qgf2V86?=
 =?us-ascii?Q?XqeSVm33OO7LAM5N8yMEqqnavW4mhWuUyLCnVjN2G5oli5HN4Tt8okFVxNvi?=
 =?us-ascii?Q?6l9k7m0IfqSURanhcMORnHlWJFU=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <66310011DCA2F742B83C58314735CEB3@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR03MB7136.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2fbd6a43-28b2-4621-5436-08d9ec7926b9
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Feb 2022 09:38:53.3419
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: bHO3FIyX9lJI9F2GnU9SctvhoPJJxrNh097Wb8Jt4TydsT/lNuSEWNoU1UFTjZZxgYxLk9Jz9KUelncAPgYeEe/Zc9Y49+CyaBVek0cgN6A=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0302MB3393
X-Proofpoint-ORIG-GUID: MppZuS-fdiCYsI5JUgNhKk4toNc11nF9
X-Proofpoint-GUID: MppZuS-fdiCYsI5JUgNhKk4toNc11nF9
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-10_03,2022-02-09_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 adultscore=0
 lowpriorityscore=0 clxscore=1015 mlxscore=0 mlxlogscore=999
 priorityscore=1501 suspectscore=0 bulkscore=0 impostorscore=0 spamscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202100053

On Wed, Feb 09, 2022 at 07:34:57PM +0000, Julien Grall wrote:
> Hi,
>=20
> On 09/02/2022 18:51, Oleksii Moisieiev wrote:
> > On Wed, Feb 09, 2022 at 12:17:17PM +0000, Julien Grall wrote:
> > > > > > +static HYPFS_DIR_INIT_FUNC(host_dt_dir, HOST_DT_DIR, &host_dt_=
dir_funcs);
> > > > > > +
> > > > > > +static int __init host_dtb_export_init(void)
> > > > > > +{
> > > > > > +    ASSERT(dt_host && (dt_host->sibling =3D=3D NULL));
> > > > >=20
> > > > > dt_host can be NULL when booting on ACPI platform. So I think thi=
s wants to
> > > > > be turned to a normal check and return directly.
> > > > >=20
> > > >=20
> > > > I will replace if with
> > > > if ( !acpi_disabled )
> > > >       return -ENODEV;
> > > >=20
> > > > > Also could you explain why you need to check dt_host->sibling?
> > > > >=20
> > > >=20
> > > > This is my way to check if dt_host points to the top of the device-=
tree.
> > > > In any case I will replace it with !acpi_disabled as I mentioned
> > > > earlier.
> > >=20
> > > dt_host will always points to the root of the host device-tree. I don=
't
> > > think it is the job of hypfs to enforce it unless you expect the code=
 to be
> > > buggy if this happens. But then I would argue the code should be hard=
ened.
> > >=20
> >=20
> > Hi Julien,
> >=20
> > Unfortunatelly I can't use acpi_disabled in host_dtb_export_init becaus=
e
> > I've already moved host_dtb_export.c to the common folder.
>=20
> I am sorry, but I don't understand why moving the code to common code
> prevents you to use !acpi_disabled. Can you clarify?
>=20
Sorry, my bad. I thought that acpi_disabled is defined only for arm. Now
I've rechecked and see I was wrong.

> >=20
> > As for the host->sibling - I took the whole assert:
> > ASSERT(dt_host && (dt_host->sibling =3D=3D NULL));
> > from the prepare_dtb_hwdom function. And this assertion was added by th=
e
> > commit b8f1c5e7039efbe1103ed3fe4caedf8c34affe13 authored by you.
>=20
> I am not sure what's your point... Yes I wrote the same ASSERT() 9 years
> time. But people view evolves over the time.
>=20
> There are some code I wished I had written differently (How about you? ;)=
).
> However, I don't have the time to rewrite everything I ever wrote. That
> said, I can at least make sure they are not spread.
>=20

I'm sorry, I didn't mean to be rude. I've just tried to tell where I
took this assertion from.

> >=20
> > What do you think if I omit dt_host->sibling check and make it:
> >=20
> > if ( !dt_host )
> >      return -ENODEV;
>=20
> We used to set dt_host even when booting with ACPI but that shouldn't be =
the
> case anymore. So I think this check should be fine.
>=20

Ok, thank you. I'll do the change.

Best regards,
Oleksii.=


From xen-devel-bounces@lists.xenproject.org Thu Feb 10 09:46:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 10 Feb 2022 09:46:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269744.463827 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nI62G-0001bC-AB; Thu, 10 Feb 2022 09:46:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269744.463827; Thu, 10 Feb 2022 09:46:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nI62G-0001b5-6w; Thu, 10 Feb 2022 09:46:44 +0000
Received: by outflank-mailman (input) for mailman id 269744;
 Thu, 10 Feb 2022 09:46:43 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nI62F-0001ax-0u
 for xen-devel@lists.xenproject.org; Thu, 10 Feb 2022 09:46:43 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nI62D-000737-NJ; Thu, 10 Feb 2022 09:46:41 +0000
Received: from 54-240-197-226.amazon.com ([54.240.197.226] helo=[10.7.236.14])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nI62D-0006dK-Gr; Thu, 10 Feb 2022 09:46:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=dYhjtJhu5wn3T+7sDZVqBgNk8j7dobj8Z28WoXChp2E=; b=DiBjlfeVx9x7AMsWMUalXJU69T
	wvXG0r6UYGIi7ouQ8EbF8Hm+cmKM3HSZrJGr9y8rJwNY8Zi0kMehbmIPElqA7S4cVDQgoudNmRiDa
	aKEscZ9/k6lTvm+HQ5ouuq6GkKVcYVwKFmiBSFn9DH1F+UAOMRm7Avn0k9X5IuRRoIAE=;
Message-ID: <a104d3ea-170e-8175-ac04-abfcebb4ae29@xen.org>
Date: Thu, 10 Feb 2022 09:46:38 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.1
Subject: Re: [PATCH V5] xen/gnttab: Store frame GFN in struct page_info on Arm
To: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>
Cc: Jan Beulich <jbeulich@suse.com>,
 Oleksandr Tyshchenko <olekstysh@gmail.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Bob Eshleman <bobbyeshleman@gmail.com>,
 Alistair Francis <alistair.francis@wdc.com>,
 Connor Davis <connojdavis@gmail.com>
References: <1641424268-12968-1-git-send-email-olekstysh@gmail.com>
 <a54213c4-1c68-694e-c130-d95faeef3953@xen.org>
 <78d94e1e-6db4-25c1-adb8-e4bdbfe42774@epam.com>
 <82d8bfe0-cb46-d303-6a60-2324dd76a1f7@xen.org>
 <79fbf83e-d25e-2634-9769-8e07634bfd63@epam.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <79fbf83e-d25e-2634-9769-8e07634bfd63@epam.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit



On 08/02/2022 19:50, Oleksandr Tyshchenko wrote:
> 
> On 08.02.22 13:58, Julien Grall wrote:
>> Hi,
> 
> Hi Julien

Hi,

>>
>>
>> (Jan please confirm) If I am not mistaken, on x86, a read to the M2P
>> is not always protected. But they have code within the P2M lock to
>> check any difference (see p2m_remove_page()). I think we would need
>> the same, so we don't end up to introduce a behavior similar to what
>> XSA-387 has fixed on x86.
> 
> 
> ... OK, I assume you are speaking about the check in the loop that was
> added by the following commit:
> c65ea16dbcafbe4fe21693b18f8c2a3c5d14600e "x86/p2m: don't assert that the
> passed in MFN matches for a remove"

Yes, this is the one I Have in mind.

> Also, I assume we need that check in the same place on Arm (with P2M
> lock held), which, I think, could be p2m_remove_mapping().

I believe so. Can you do some testing to check this would not break 
other types of mapping? (Booting a guest and using PV device should be 
enough).

> 
> I ported the check from x86 code, but this is not a verbatim copy due to
> the difference in local P2M helpers/macro between arches, also I have
> skipped a part of that check "|| t == p2m_mmio_direct" which was added
> by one of the follow-up commit:
> 753cb68e653002e89fdcd1c80e52905fdbfb78cb "x86/p2m: guard (in particular)
> identity mapping entries"
> since I have no idea whether we need the same on Arm.

I am not entirely sure. For now, I would drop it so long the behavior 
stay the same (i.e. it will go ahead with removing the mappings).t.

> Below the diff I have locally:
> 
> diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
> index 5646343..90d7563 100644
> --- a/xen/arch/arm/p2m.c
> +++ b/xen/arch/arm/p2m.c
> @@ -1315,11 +1315,32 @@ static inline int p2m_remove_mapping(struct
> domain *d,
>                                         mfn_t mfn)
>    {
>        struct p2m_domain *p2m = p2m_get_hostp2m(d);
> +    unsigned long i;
>        int rc;
> 
>        p2m_write_lock(p2m);
> +    for ( i = 0; i < nr; )
> +    {
> +        unsigned int cur_order;
> +        bool valid;
> +        mfn_t mfn_return = p2m_get_entry(p2m, gfn_add(start_gfn, i),
> NULL, NULL,
> +                                         &cur_order, &valid); > +
> +        if ( valid &&

valid is a copy of the LPAE bit valid. This may be 0 if Xen decided to 
clear it (i.e when emulating set/way). Yet the mapping itself is 
considered valid from Xen PoV.

So you want to replace with a different check (see below).

> +             (!mfn_valid(mfn) || !mfn_eq(mfn_add(mfn, i), mfn_return)) )
> +        {
> +            rc = -EILSEQ;
> +            goto out;
> +        }
> +
> +        i += (1UL << cur_order) -
> +             ((gfn_x(start_gfn) + i) & ((1UL << cur_order) - 1));
> +    }
> +
>        rc = p2m_set_entry(p2m, start_gfn, nr, INVALID_MFN,
>                           p2m_invalid, p2m_access_rwx);
> +
> +out:
>        p2m_write_unlock(p2m);
> 
>        return rc;
> 
> 
> Could you please clarify, is it close to what you had in mind? If yes, I
> am wondering, don't we need this check to be only executed for xenheap
> pages (and, probably, which P2M's entry type in RAM?) rather than for
> all pages?

 From my understanding, for the purpose of this work, we only strictly 
need to check that for xenheap pages.

But I think it would be a good opportunity to harden the P2M code. At 
the moment, on Arm, you can remove any mappings you want (even with the 
wrong helpers). This lead us to a few issues when mapping were overriden 
silently (in particular when building dom0).

So I would say we should enforce it for every RAM mapping. Stefano, 
Bertrand, what do you think?

Note that, I would like to see this change in a separate commit. It will 
be easier to review.

> 
> 
>>
>>
>> In addition to that, if p2m_get_xenheap_gfn() is going to be called
>> locklessly. Then we need to make sure the update to type_info are
>> atomic. This means:
>>   - p2m_get_xenheap_gfn() should use READ_ONCE().
>>   - p2m_set_xenheap_gfn() should use WRITE_ONCE(). We might even need
>> to use cmpxchg() if there are other update to type_info that are not
>> protected. I will let you have a look.
> 
> 
> ... OK, I didn't find READ_ONCE/WRITE_ONCE in Xen. I am wondering, can
> we use ACCESS_ONCE instead?

Yes. Sorry, I keep forgetting we don't have READ_ONCE/WRITE_ONCE in Xen.

> 
> Below the diff I have locally:
> 
> diff --git a/xen/arch/arm/include/asm/mm.h b/xen/arch/arm/include/asm/mm.h
> index 9e093a6..b18acb7 100644
> --- a/xen/arch/arm/include/asm/mm.h
> +++ b/xen/arch/arm/include/asm/mm.h
> @@ -373,7 +373,7 @@ unsigned int arch_get_dma_bitsize(void);
> 
>    static inline gfn_t page_get_xenheap_gfn(const struct page_info *p)
>    {
> -    gfn_t gfn_ = _gfn(p->u.inuse.type_info & PGT_gfn_mask);
> +    gfn_t gfn_ = _gfn(ACCESS_ONCE(p->u.inuse.type_info) & PGT_gfn_mask);
> 
>        ASSERT(is_xen_heap_page(p));
> 
> @@ -383,11 +383,14 @@ static inline gfn_t page_get_xenheap_gfn(const
> struct page_info *p)
>    static inline void page_set_xenheap_gfn(struct page_info *p, gfn_t gfn)
>    {
>        gfn_t gfn_ = gfn_eq(gfn, INVALID_GFN) ? PGT_INVALID_XENHEAP_GFN : gfn;
> +    unsigned long type_info;
> 
>        ASSERT(is_xen_heap_page(p));
> 
> -    p->u.inuse.type_info &= ~PGT_gfn_mask;
> -    p->u.inuse.type_info |= gfn_x(gfn_);
> +    type_info = ACCESS_ONCE(p->u.inuse.type_info);
> +    type_info &= ~PGT_gfn_mask;
> +    type_info |= gfn_x(gfn_);
> +    ACCESS_ONCE(p->u.inuse.type_info) = type_info;
>    }
> 
>    #endif /*  __ARCH_ARM_MM__ */
> 
> 
> It is going to be a non-protected write to GFN portion of type_info.

Well no. You are using a Read-Modify-Write operation on type_info. This 
is not atomic and will overwrite any change (if any) done on other part 
of the type_info.

If I am mistaken, there are two other places where type_info is 
modified. One is...


> But, at that time the page is not used yet, so I think this is harmless.
> 
> diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c
> index 50334a0..97cf0d8 100644
> --- a/xen/common/page_alloc.c
> +++ b/xen/common/page_alloc.c
> @@ -1024,7 +1024,7 @@ static struct page_info *alloc_heap_pages(
>                                     &tlbflush_timestamp);
> 
>             /* Initialise fields which have other uses for free pages. */
> -        pg[i].u.inuse.type_info = 0;
> +        pg[i].u.inuse.type_info = PGT_TYPE_INFO_INITIALIZER;
>             page_set_owner(&pg[i], NULL);
> 
>         }

... this one. I agree the page is not accessible at this time. So 
page_set_xenheap_gfn() should not be used.

The other one is in share_xen_page_with_guest() which I think is still 
fine because the caller page_set_xenheap_gfn() would need to acquire a 
reference on the page. This is only possible after the count_info is 
updated in share_xen_page_with_guest() *and* there a barrier between the 
type_info and count_info.

I think this behavior should be documented on top of type_info (along 
with the locking). This would be helpful if type_info gain more use in 
the future.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Feb 10 10:03:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 10 Feb 2022 10:03:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269756.463837 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nI6IZ-00046p-SS; Thu, 10 Feb 2022 10:03:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269756.463837; Thu, 10 Feb 2022 10:03:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nI6IZ-00046i-PT; Thu, 10 Feb 2022 10:03:35 +0000
Received: by outflank-mailman (input) for mailman id 269756;
 Thu, 10 Feb 2022 10:03:34 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=T9Dk=SZ=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nI6IY-00046c-6K
 for xen-devel@lists.xenproject.org; Thu, 10 Feb 2022 10:03:34 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b2e28578-8a58-11ec-8f75-fffcc8bd4f1a;
 Thu, 10 Feb 2022 11:03:32 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b2e28578-8a58-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644487412;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=LnAdlFNKLDAF450e79nH567TbE1Tcc1vsbzVT7HTvhE=;
  b=FQWyMNBrRk3g4DDOOalcarIuPn0rI08JlXer/hI9DUfKsK+vuS3PhJMC
   Jus71xPnnic/Pa+p2jWwW5+swkmkAYoaabafAWP8eHxMWPXFPH7tYIlTy
   t/OkjgbW10UvegeL2nG3+twLr9JV/jsNydFm+i9a9pIULUKovr9O8gF2h
   M=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: hrRUobbaazwqW8DbfFa0lawlILxQVgc/DwSF4Pr1wjmljuYURszjZPtthWUkUAP4uuoP1aRfIA
 hGYZJQoVO8AewsilUPeBO2P33gxDkuSn0upUYk1AsfhaAXFV6PPY9FgfAEEOPE86TA/9AcmVIw
 BCrTzVwJeVc+FYB1O7G+NtSbmatuYweE0VpXjfGo8oi+NWuUB4pOj67vyGkM+EZfzvcPBk1agU
 fk1/UOnXcAlma6pMUoe1a7APg2A66HPxQPrKqStFihAg3ffV/5QGHDpH9GjQH4zGU9ZaFCxr6n
 kt3Fks6Dhpfi5LmPYTAfHIiR
X-SBRS: 5.1
X-MesageID: 66130309
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:kxfS8q6bDrTbxtDFQTGuPgxRtEnBchMFZxGqfqrLsTDasY5as4F+v
 jYZUWjQPqmJYWr8KYogPYiypxsCvZTUmtQ2QQpt+SwzHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FV8MpBsJ00o5wbZj29Yw2LBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z4
 tlk7LCNayoVY4aPgqM8fRNEIxNmMvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALNs7kMZlZonh95TrYEewnUdbIRKCiCdpwgmlp3ZgVRae2i
 8wxZhxTNRLNUy92O2gwMLYxhdWlqVv4WmgNwL6SjfVuuDWCpOBr65DTN97Sds2PVN9itE+Sr
 WLb/Ez0GhgfcteYzFKt6Wmwj+XCmSf6XoM6F7Ci8PNuxlqJyQQ7AhAMSUGyp/X/j0ekQs9eM
 GQd4C9opq83nGSoQ8f8WVukoXeClh8aR9dUVeY97WmlyLfSpQCQBWEGTztIQN0gqMIyAzct0
 zehgNfBFTFp9rqPRhq15rqS6D+/JyURBWsDfjMfCxsI5cH5p4M+hQ6JScxseIa3gcfyAirY2
 C2RoW41gLB7pcwW06S2+3jXjjTqoYLGJiY37AjKWmOu7itieZWoIYev7DDmAe1oddjDCAPb5
 T5dxpbYvLtm4YyxeDKlaukkRZ2Uxdu5bRafmxlOMZM9xwa19Cv2FWxP2w1WKEBsO8cCXDbmZ
 k7PpA9cjKNu0GuWgbxfONzoVZlzpUT0PZG8D62PMIISCnRkXFLfpElTiVisM3cBeaTGuYU2I
 t+lfMmlFh724ow3nWPtF4/xPVLGrx3SJF8/p7iml3xLMpLEPRZ5rIvp1nPVN4jVC4ve/m3oH
 y53bZfi9vmmeLSWjtPr2YASN0sWCnMwGIr7rcdaHsbafFY6RDp7U6eKkexwE2CAo0izvryRl
 p1achUGoGcTeFWdcVnaApydQO+HsWlDQYITYnV3YAfAN4kLaoez9qYPH6bbjpF8nNGPOcVcF
 qFfE+3ZW6wnYm2ep1w1MMmsxKQ/JU/DrV/fYEKYjM0XIscIq/rhoYS/IGMCNUAmU0KKiCfJi
 +P8iF2LG8dfL+mgZe6PAM+SI5qKlSF1sMp5XlfSI8kVf0Pp8YNwLDf2gONxKMYJQSgvDBPAv
 +pPKRtH9+TLvaEv99zF2fKNo4uzSrMsFUtGBWjLq72xMHCCrGakxIZBVseOfCzcCzyoqPnzO
 70NwqGuKuADkXZLr5F4T+Rhw5Uh6oa9vLRd1AllQinGNgz5FrN6L3Ca9sBTrakRlKRBsA67V
 xvXqNlXMLmEIu3/F1sVKFZ3Z+iPz6hMyDLT8e40MAPx4youpOiLVkBbPh+tji1BLeQqbNN5k
 Ll54MNPsl6xkBsnNNqCnxt4zWXUIyxSSbgju7EbHJTv1lghxGZdbMGOESTx+pyONYlBaxF4P
 j+OiaPerL1A3U6eIWErHH3A0OcB15QDvBdGkA0LK1iTw4eXg/Y22Fta8CgtTxQTxRJCirohN
 m9uPkxzBKOP4zY325QTAzHyQ1lMVE+D50j861oVj2mIHUCnW1vEIHA5JevQrlsS9HhRf2QD8
 byVoIo/ve0GoC0lMvMOZHNY
IronPort-HdrOrdr: A9a23:4jWPMam4wQ8xDj8y5H2Xw7G3pn/pDfO1imdD5ihNYBxZY6Wkfp
 +V88jzhCWZtN9OYhwdcLC7WZVpQRvnhPlICK0qTM2ftWjdyRCVxeRZg7cKrAeQeREWmtQtsJ
 uINpIOdeEYbmIK8/oSgjPIaurIqePvmMvD5Za8854ud3ATV0gJ1XYHNu/xKDwReOApP+tcKH
 LKjfA32wZINE5nJfhSQRI+Lpr+juyOsKijTQ8NBhYh5gXLpTS06ITiGxzd+hsFSTtAzZor7G
 CAymXCl+iemsD+7iWZ+37Y7pxQltek4txfBPaUgsxQDjn3kA6naKloRrXHljEop+OE7kosjb
 D30l0dFvU2z0mUUnC+oBPr1QWl+DEy60X6wVvdunfnqdyRfkNNN+NxwaZiNjfJ4Uspu99xlI
 hR2XiCipZRBRTc2Azg+tnhTXhR5wSJiEtntdRWo21UUIMYZrMUh5cY5llpHJAJGz+/wJw7Ed
 NpENrX6J9tABynhkjizylSKeGXLzcO9k/seDlBhiXV6UkboJlB9TpY+CRF9U1wsa7USPF/lp
 P52+pT5fVzp/QtHNJA7dE6ML+K41z2MGPx2V2pUCfa/YE8SjvwQs3Mkf0IDN/DQu188HJ1ou
 WHbG9l
X-IronPort-AV: E=Sophos;i="5.88,358,1635220800"; 
   d="scan'208";a="66130309"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=BpbE+pjOXBr6uI8fT7vSLh+sOVipxklR4k1k4p2Fc7VnD4A7wfPEA+BQuikoqg6DopsTlAWxE57+o+LJMnO8aCNyMHXTILkklTVEz1OOrGquawCK8xwluquxI3nsQzEZFaGSP2MeAAj8E0UOuGDn2RJdKt/fmb6xNX0LEjnvovgQ+6bvVwuRfb9c1g2nIYvubkCjDrzFbw2DMuFU+h7zWye0I7QjlXyXI2LpZlzRnyX9yy9sbS7OksxIk2szblDY8JlkJKnxfAEGzX7VP8reyzvwF/xl2/MsGhqGWT8VeHZWW/uqyktuFHQBLWhW3CXzEaaNZQpQoFTkiz5bME1aHg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=NJb1qmxhgZ53HJ1YejXoqaBY8B52fDDlokKmhnzGshU=;
 b=bHaQQO6vNwX7AT9wmuMXD9HOynJoWlCf9mIBM1xf6wNF/gB8C3YvNW3DuxzrH0RUEM9o6y0Rm6+1iXr8xoRg7ewhx/+FqUp/KjhGJNSOxsg68LXTlEngXE4xDhqD08AA6SAt/0ZZqpSQYFNPEFDG4Xw9JAYCx/gDWpDP/p10Khg0lAL8a/Fvo2TGwb4yveYPs7Tx6r46kDuSCUzzTMYrpfKVfHjcjnm/b2aQaAt2k7A21RnlPunRApcvemdY1RY1J2LhgRTexB6xlviFJQb1vLFD7ePmHU54teQo3VYVQtsYBnwZyjwDQZQZ0+nYl48ySPEYcftLf4HeHpWwJFGc7Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=NJb1qmxhgZ53HJ1YejXoqaBY8B52fDDlokKmhnzGshU=;
 b=WMHxyZ8B6EjcVI1+4xaruYBQ2zCLn0p91VSQc9m48CTegvScM/L99PU3sBgADE3FWSSxxfahpSasunjueVp1+NOIFc8k8A5ZcY5XVHLWzMOGHqsuodJ64B/3Ct9c7W7bJFC6ZjfwUi8HDFg7yhXp6XF6rqzlbvWFr+qXv7vLh/0=
Date: Thu, 10 Feb 2022 11:03:21 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jane Malalane <jane.malalane@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>, Anthony
 PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, Andrew
 Cooper <andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>, Stefano
 Stabellini <sstabellini@kernel.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>,
	Jun Nakajima <jun.nakajima@intel.com>, Kevin Tian <kevin.tian@intel.com>
Subject: Re: [PATCH v2 1/2] xen+tools: Report Interrupt Controller
 Virtualization capabilities on x86
Message-ID: <YgTi6bzeojtcu0xL@Air-de-Roger>
References: <20220207182101.31941-1-jane.malalane@citrix.com>
 <20220207182101.31941-2-jane.malalane@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20220207182101.31941-2-jane.malalane@citrix.com>
X-ClientProxiedBy: LO2P265CA0509.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:13b::16) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2a441809-f4dc-436b-7624-08d9ec7c9490
X-MS-TrafficTypeDiagnostic: CY4PR03MB2709:EE_
X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
X-Microsoft-Antispam-PRVS: <CY4PR03MB2709F7B1BFD4DFB2940116CE8F2F9@CY4PR03MB2709.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: /P4/fmcVmvIk9E/pJVbPTb8DPWbntl+TV2jgsI+sM1oHuo+cf+unCzc6KXdR5sCGOR1h3Ew0+9+xO5m5Kczhg09iwrs0pAoVyJ3K6xq3DR+jr5UvyJSI8tQ3tDruFtcN34pXytRIsejhEQuw3lq6jjaNlH+yVHyRVO1ORQR0+1iWGW8rpuoAoMsbVyFIZu0FvgEFFVm7yVyfmsNPQojagoMBq2Lc/fYC3j5OiOgxyAt1ECd+RR+Bb6nsH+aZjG9I6orC3HPqim20dN/GVAUIvV1hqHtfyfwX+IBtTNV0n1RbdzVqUdJ6sPhlIF/d2rDCf1iYF8H2WscxPSlwuTb+gj5QSEeRUzIsUtNDE41MlbbZC36aywUmeDB4tvcRM1ur82lzouXpUNsRuspki05ozYdSAsn6cXajVXHvqvYmMbqBPXgrp/Jat+Csw/20h+7eOj+cMrdAOrTQ85rNfPeOdfjFFOotG+pjR/7XpD5HVQhPl1cN92P+z9mWovMcNCnDBdsNPYga77k7DXS3mxJjIujajKngADHw9zwbkPl40V24Wvq48paL2kTW8e37pFu9PlJkOhUZOMg0L7utTigV4vsEm0jHDd5PNaCrK5vYDD9b0L24qTaEBXznol4sldHNjEXvgYI34nUS2F9GL80uHQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(6486002)(508600001)(6506007)(66946007)(66556008)(8676002)(4326008)(6862004)(316002)(82960400001)(54906003)(66476007)(86362001)(38100700002)(9686003)(5660300002)(6512007)(6666004)(6636002)(26005)(33716001)(83380400001)(85182001)(8936002)(2906002)(186003)(7416002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QU92TGVqeWVHZElkbGpSUzQwM0pmMEg5RmttemY5c25CcjJTQWVNR0o4TUxz?=
 =?utf-8?B?WUkxVjB5cDR3bVYvczVua1ZBUEcwci83a1FYMnE1Y3NYS2drTTBVNWgwRUdl?=
 =?utf-8?B?MEZKZ0x1WU9JdXlVd2lvVWtvMTBMc1NZYkVYUjZwSXJKVTB5ZTUzSG0rU1NV?=
 =?utf-8?B?OXNEUW5aQStaajF0OUw1Z2JTNXh3Rk1ZMFNyL08xYko4Q095eFgwYVlXbkVG?=
 =?utf-8?B?UGZ6VSt3a1ZPZ3d4M2F4YURSTkwxV2p0V1d0ZVZObnVJOHVqSGhGcVJ6S2pj?=
 =?utf-8?B?KzhHQ1NDaGhhWVh3aStyZ2xPV05Ha3A2eUhVdVVYUFd4MndocVlqL2x5a3BW?=
 =?utf-8?B?V05QZm00eGNCNlN2djZIRW1FN1RHa3NVSFNpZ3lTZ0liZzdWS3Y2cVY2cjZx?=
 =?utf-8?B?U2doQ2ZEdFFHOHQwZkU3TzBqMWRXRUZZRmhRTUtaRXdRQTBHczBWWTVwN3Vn?=
 =?utf-8?B?T1RsQXBNdjVvRWNLT3o4NlhlMnREaDRkK3ptZHM5b2FUU0c3YU9DZWZGQ2xI?=
 =?utf-8?B?SEIwTEx4V2Yyd1h2VFhqQVVMRWZ3ZU1jNUE4REtjUnVyc3NlT0NHQzByVEhj?=
 =?utf-8?B?c3pQQ2RpdnQxY3QrSGo2NkZwaHFqR1MveW90TXVLcFF3bVloRm1QM0k3ZE15?=
 =?utf-8?B?YzVTQUpnUWw4VWFDZU9hNVQ5eEZCbk5zQ1hIeW9uUFNCOEFjLzdkbkpTOTlK?=
 =?utf-8?B?Y3RMaHk1TEF2c0c5ZGtVWjFlQ1RoM29PZnUrMFpwTEhhR3BXQ0xTUlJ5MEpC?=
 =?utf-8?B?VmFsUkhhamlnWUp6bVZITlppQURiQnBHeHEwTDhtU3ppRmVnQmRyN0R5M1cw?=
 =?utf-8?B?UVhQVjJLdnYyekFGc2VTc0ZVWVQ5RlJ4NTZXZndEM2VPby9QQ0xDNktzT0NO?=
 =?utf-8?B?SkovMnN0VVlpNGthNFVvTXpFME55eHg2VjR5WktKU0NrYjc3K2RxRm1YVVVK?=
 =?utf-8?B?cEhNNFFEYXZxUUxSdTQ5aVVuNGhIZGkyS3ZpbFJVRzBrc2V5d2lvQnZCVFFS?=
 =?utf-8?B?VjkrR0VGYWlONkR5cWdYak9wV0luOUVScXBHZmY4OVVCaVpkakwvZGk3RDVu?=
 =?utf-8?B?dVZOSngxVGFRZk9YSkduYTFYc0NteXY2d3RKOUgvTnNuckdWMDJLWDE0WFo4?=
 =?utf-8?B?YjdmanV4Z0UvYUtNZi9hMmwyTVFsMlJnOTZrWlkxRmQ5ekNxd0x0amVqVEc5?=
 =?utf-8?B?bzVZTk5XM2E2aDdlVmg0RHJzMEZDQngvUFZDM29QR3Y2SlFOMUkzQWdNWTBQ?=
 =?utf-8?B?WHduT2pSOHBXTUZSdVVMeDY1YUJTVFcyNnk2SUlGRUtGcjhsWnlEelBJQ2hm?=
 =?utf-8?B?YWJuL2toOG5OdnE1RlhTNVNiZVR6YWNlVzV4V1l1QmVTVkYwancwRE1IL0xy?=
 =?utf-8?B?YVQrM3lWR3BZZHZpL3ByYUY3dklHcVVDQkZKcHNyRnIrNUlhNTZBMHB5UmRL?=
 =?utf-8?B?bFRveGlxK1AzWGp6RmxMWlMwZFRPQmFSQmo4T3lNWkR1Y09qYk13V3FBVmd2?=
 =?utf-8?B?ZVRvNW5ZMWM3VnVsbEx3TDJJeEN0T0hPK0F5VDNZajNKQXJwS0Z2YnJ1eXhT?=
 =?utf-8?B?STNJOVBKVDdvUS9rSElOWXdFd09MNlkvZWR3Qks2NmkvTG51cWl3UG9YbHdW?=
 =?utf-8?B?a0tkNFc0VGUrb29oQTY4eTRMZk9BNEFmbUk2ZFo0Nkd3YmtsMDZrNHJwSmZQ?=
 =?utf-8?B?VkFLaGJEODN0SENEd3pPL0x5Y1J3RkNUYXJmTjJmdmtrUVpwam1NNlFocmhu?=
 =?utf-8?B?WXhjWkJqY2RTcmVUY2JJSTVYM05aa2hPMG16NC91M045dWg3RVVrZG5uN1A0?=
 =?utf-8?B?WURVeTIyYWF3aU1NcURUU3NsazM4UGo4R0t5OERKd2hpSXF5NWsybG9HbE5I?=
 =?utf-8?B?ZksxVDhCc0F4a3JnQW9GdmpLY3pueHVpSldNbytKd3lWRTExejBoelV1Zldn?=
 =?utf-8?B?clppODNTcUdsM0xic3MzdjZCRUdaUktUcjVFcUZjT1RGdFJ4SmM1RlZKMUg0?=
 =?utf-8?B?bFNXOHh5NFlkK1lUUHhER0xTaHF2czlrMGlMekhINnBRUVdVY0k0WlB5YWpk?=
 =?utf-8?B?T3FDbHJQcTdURE5sUkNiVmFhTFI1S1lBYzNnT2xXR1NUeVJKQmNGMUJsT3pk?=
 =?utf-8?B?NHM2U25xSlB5MHo4RWNKNVREVlFXbEJQd1ZYMURIWXNtNVROOTRMRVZXUFFw?=
 =?utf-8?Q?Gouprbt2bPSaupFV1TMcuWs=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 2a441809-f4dc-436b-7624-08d9ec7c9490
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2022 10:03:26.4105
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: N8mB0Xe2vjTeue+G6v0/sdCKdrozS8KfGFDI3UlKEwZZ08YNYHtXLYRKBNSw5daRpibBLc22K6/EoZurYi4KrQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR03MB2709
X-OriginatorOrg: citrix.com

On Mon, Feb 07, 2022 at 06:21:00PM +0000, Jane Malalane wrote:
> diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c
> index 7ab15e07a0..4060aef1bd 100644
> --- a/xen/arch/x86/hvm/vmx/vmcs.c
> +++ b/xen/arch/x86/hvm/vmx/vmcs.c
> @@ -343,6 +343,15 @@ static int vmx_init_vmcs_config(bool bsp)
>              MSR_IA32_VMX_PROCBASED_CTLS2, &mismatch);
>      }
>  
> +    /* Check whether hardware supports accelerated xapic and x2apic. */
> +    if ( bsp )
> +    {
> +        assisted_xapic_available = cpu_has_vmx_virtualize_apic_accesses;
> +        assisted_x2apic_available = (cpu_has_vmx_apic_reg_virt ||
> +                                     cpu_has_vmx_virtual_intr_delivery) &&
> +                                    cpu_has_vmx_virtualize_x2apic_mode;

I've been think about this, and it seems kind of asymmetric that for
xAPIC mode we report hw assisted support only with
virtualize_apic_accesses available, while for x2APIC we require
virtualize_x2apic_mode plus either apic_reg_virt or
virtual_intr_delivery.

I think we likely need to be more consistent here, and report hw
assisted x2APIC support as long as virtualize_x2apic_mode is
available.

This will likely have some effect on patch 2 also, as you will have to
adjust vmx_vlapic_msr_changed.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Thu Feb 10 10:09:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 10 Feb 2022 10:09:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269763.463849 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nI6OB-0004mI-J5; Thu, 10 Feb 2022 10:09:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269763.463849; Thu, 10 Feb 2022 10:09:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nI6OB-0004mB-FY; Thu, 10 Feb 2022 10:09:23 +0000
Received: by outflank-mailman (input) for mailman id 269763;
 Thu, 10 Feb 2022 10:09:22 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=T9Dk=SZ=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nI6OA-0004m5-SA
 for xen-devel@lists.xenproject.org; Thu, 10 Feb 2022 10:09:22 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 82c0cf23-8a59-11ec-8eb8-a37418f5ba1a;
 Thu, 10 Feb 2022 11:09:21 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 82c0cf23-8a59-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644487761;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=2q1VyKhEWKz+23WNZsO8UA5PZFr5O1P1tFK/WSf4kVg=;
  b=Lym3JRKu7ZZajyH+6kTBWGv5VUro3DP+C5SOkU9zEAbo3OcipBZ6wbyS
   6Xp/d2V0kKQWYrNwhFq45Pvinh8do2DoYqcQWjUPF5hXdIquGSRqKXURM
   +sIjJeOyB4vuZqs0Kmgs9T0Knzh1IzIZ+vOKTaKPoXtSOqjIit59+jZFM
   E=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: MCwoY3U2H6aIsKoO+Jk3Ma2epybaU3uyWg/yh5HQTw8zNcSDMrsHAkgri5oQAO4K5j03Jf85/o
 bQ5KVTQZQ5NCvNnEPu9ft3YnFOC1xQa8hR/w4e48J2LEZr6OFVPXKXWMi1DlakR0qWm++3cKcy
 EiutqKznkbU8BZe6KlrdEUhiEMgNV0ORCf0yB9mpB7Jd3F4N0kaJzRG1sghpwDXIIVwa1XO3uD
 8gg6IBRLzCarmv5K7NsN4VEP0Il/2shDIOCC0NgmNiN1+NimXzb//ySBv74m9iGC671Uk4rRZI
 n0Dxy2buc4IZBeNfTXwiea39
X-SBRS: 5.1
X-MesageID: 63911985
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:PjUQcajl8VDOh9YXmCPWEGMhX1612BcKZh0ujC45NGQN5FlHY01je
 htvW2rVP6yNNzD9edh+OYni9UNQ75LVnYM2GwZkqStnRS4b9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oAMKRCQ7InQLlbGILes1htZGEk0GE/NtTo5w7Rj2tQx2YDga++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /108qahRh14NZHHmedebUBVTxkiFqhZreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHxO4wSoDd4xCzxBvc6W5HTBa7N4Le02R9u3ZEXRKeOO
 qL1bxJiVC6bMxxAEW06AaAyvM6yq1PtTyVH/Qf9Sa0fvDGIkV0ZPKLWGMHOZtWASMFRn0CZj
 mHL5WL0BlcdLtP34TiY9nOhgMffkCW9X5gdfJWG8fptjEyW13YkIhQcXlumotG0kke7HdlYL
 iQ89iMwoIAo+UesT927WAe3yFabujYMVtwWFPc1gCmdx6yR7wuHC2wsSj9adMdgpMIwXSYt1
 FKCg5XuHzMHmL+fRG+Z97yUhSivIiVTJmgHDQcGQhEC+MLLu5wog1TESdMLLUKupoSrQ3eqm
 WnM9XVgweVI5SIW60ml1WmAuSOjvMnCcgU05UbpB2/51l9SYZHwMuRE9mPnxfpHKY+YSHyIs
 34Fh9WS4YgyMH2dqMCeaL5TRe/0vp5pJBWZ2AcyRMd5q1xB7lb+Jdg43d1oGKt+3i/okxfNa
 VSbhw5e7YQ70JCCPf4uONLZ5yjHIMHd+TXZuhL8M4ImjntZLlbvEMRSiai4hDmFfK8Ey/9XB
 HtjWZzwZUv28Iw+pNZMe88T0KUw2gc1zn7JSJbwwnyPiOTCOCLOE+9dawvRP4jVCZ9oRi2Oq
 r6z0OPQlX1ivBDWOHGLoeb/03hWRZTEOXwGg5MOLbPSSuaXMGogF+XQ0dscl39NxMxoehPz1
 ijlACdwkQOn7VWecFniQi0zOdvHAMckxVpmbHNEALpd8yV6CWpZxPxELMVfkHhO3LEL8MOYu
 NFbJ5veUq4SFlwqOV01NPHAkWCrTzzy7SqmNCu5ejkvOZlmQg3C4Nj/eQXzsiIJC0KKWQEW+
 dVMDyvXHsgOQRpMFsHTZK79xl+9pyFFyulzQ1HJMp9Yf0C1qNpmLCn4j/kWJcAQKEqcmmvGh
 ljOWRpI9/PQp4IV8cXSgfzWpYmeDOYjTFFRGHPW7OjqOHCCrHaj24JJTM2BYSvZCDHv4Kyna
 OgMl6P8PfQLkUxkqY15F7o3n6sy68G2/+1Rzxh+HWWNZFOuU+syLn6D1MhJl6tM2r4G5lfmB
 hPRooFXYOzbNtnkHVgdIBseQt6CjfxEyCPP6fkVIVnh4HMl9rSwTkgPbQKHjzZQLeUpPdp9k
 /shosMf9ye2lgEuboSdlilR+mmBci4AXqEgus1ICYPnkFN2mFRLYJiaAS7q+pCfLd5LNxByc
 DOTgaPDgZVax1bDLCVvRSScg7IFiMRcog1OwX8DO0+Ny4jMifIA1RFM9Sg6E1ZOxRJd3uMvY
 mVmOiWZ/0lVE+uEUCSbY12RJg==
IronPort-HdrOrdr: A9a23:iezya65s90zzu3cHLQPXwSqBI+orL9Y04lQ7vn2ZFiY7TiXIra
 yTdaoguCMc6AxxZJkh8erwX5VoZUmsj6KdgLNhRotKOTOJhILGFvAB0WKP+UyEJ8S6zJ8h6U
 4CSdkBNDSTNykCsS+S2mDReLxBsbq6GeKT9J/jJh9WPH5XgspbnmFE42igYylLrF4sP+tEKH
 PQ3LsOmxOQPVAsKuirDHgMWObO4/XNiZLdeBYDQzoq8hOHgz+E4KPzV0Hw5GZVbxp/hZMZtU
 TVmQ3w4auu99m91x/nzmfWq7BbgsHoxNdvDNGFzuIVNjLvoAC1Y5kJYczIgBkF5MWUrHo6mt
 jFpBkte+x19nPqZ2mw5SDg3gHxuQxenEPK+Bu9uz/OsMb5TDU1B45qnoRCaCbU7EImoZVVzL
 9L93jxjesZMTrw2ADGo/TYXRBjkUS55VA4l/QIsnBZWYwCLJdMsI0k+l9PGptoJlO31GkeKp
 guMCjg3ocXTbvDBEqp/VWHgebcE0jbJy32DHTr4aeuonprdHMQ9Tpt+CVQpAZEyHsHceg12w
 3zCNUcqFh/dL5mUUtDPpZzfSKWMB26ffueChPaHbzYfJt3SU4l7aSHpIkI2A==
X-IronPort-AV: E=Sophos;i="5.88,358,1635220800"; 
   d="scan'208";a="63911985"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=kUG2DGMTvqhCtpbSSkHtF19OhUQI01r7T7oeNLIEttsF+XJxCoZJ2sFaEqd1HSTOnkbm7FoyFROUi+Hlfw7WVnE6HsX0MahogYHyFeXyEfqPO9pn1CVB8Tkkjae/LrO0C7lI+qqYw0BZT502t4UOHiWdBISTixNYImBfAe0xThtYGHfkTrKkwHU9jUclE24CtqXN7Nily2I73S+aIhsiiinI3PE2jV2z/2ePnvjTSF0g9K4d7EFjbjelYsqOit5QlscrOM7cN6GD874QLkQP+dpZlrGpHN3tNLiohdxEgG2e+wtY/upWiqsdJfoJvKcTlpvJ0RB4IPEmxcWH2pUmOw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=7RjCmAc7agmyzI0yWa//DZ3lhJzsYLLGRDvR+wra0yo=;
 b=jhgmlX26EEAujTJgi6I1A2jxAoGlPS00oU+4SbyzbO2cQYvgiLtPeZfhHN21qUpayTu2WJYxmvB18VT5dK6g3SrnvNfQIjYfGkbnj4fvROgmqXxfE7Pby4AmosGuQGMl7laKczU2gWUGlbv1m4IR5ON7WHyxuaN1fnXaYixuy+blGN239wUTu6q/8cLF6SnMqFBYO/zcuAgp8CAr23KEFcm0FNbuqFyhkh8nf+34rGWfj0rjWA/roDa/ASs3d628lfY6eDcnpSLxtj2R/hT2/E2vdT9HgaV+XzBddq2aAoweSuDFcRnaPK+S5QAXxDJ/EbX7UrmrV6u1Xu6nDTqa1w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=7RjCmAc7agmyzI0yWa//DZ3lhJzsYLLGRDvR+wra0yo=;
 b=Sj02Up+WvtDTQuKlhnXdDkmo4paRdJtc39njtWQa/hAvkMqk8/un2X1se1NCSEnYcIh4MLEQx9+e3b6OF7DyqSsP2WaMo4sFFTAXOTfzSHjfoRTwhqIjmvmfaOHpJJ9Isuhow8eMYzM34e22+scKKSr2hdrYJBum3icdxTBh8l4=
Date: Thu, 10 Feb 2022 11:09:10 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jane Malalane <jane.malalane@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>, Anthony
 PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, Andrew
 Cooper <andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>, Stefano
 Stabellini <sstabellini@kernel.org>, Christian Lindig
	<christian.lindig@citrix.com>, David Scott <dave@recoil.org>, Volodymyr
 Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v2 2/2] x86/xen: Allow per-domain usage of hardware
 virtualized APIC
Message-ID: <YgTkRtwqmZsLZIXo@Air-de-Roger>
References: <20220207182101.31941-1-jane.malalane@citrix.com>
 <20220207182101.31941-3-jane.malalane@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20220207182101.31941-3-jane.malalane@citrix.com>
X-ClientProxiedBy: LO4P123CA0308.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:197::7) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e86ad10f-dd20-4ea0-141c-08d9ec7d64c6
X-MS-TrafficTypeDiagnostic: BL0PR03MB4129:EE_
X-Microsoft-Antispam-PRVS: <BL0PR03MB4129EE41EF7B12F28433BAA38F2F9@BL0PR03MB4129.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3826;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: xv/d6zYQcoGdU8AQ+JEfH2ii+SA0SNL9/7sNDbF9V75AHRr0odWGqL4HKRnKEZlmMNS+otLRU2TiN2ZajWkyds1g/OFkaT9jWGfn+fbCNbHFH9bdCYXIEtT59Lwv7j3SNeEwAccVkYQEdFbZ4SB0YBNWzq8V2xepWzD9amKcPYOfMv4mMB/a5zEuA/Xdon3m9/0AZd1OZBOrBZ35Bc6dmfm8nKh7Wb6j2uB8nNL2uS7fvugFLHPPLpB4M8beKuoF7k1cwXJxIqmMiOzL156GdHr2cioqJJfPXihRikPBAHdGS2XDGriXDUkBO+ULUQ5VoCGWLpy0RAEyq6ebbAsleEkH4/y5OsYc/m5rwIwTTn9ABE8U+FBLsh7U0A4i2qUr5WEh5gaBB7zJpyVFkMFCvwz6nMr9dCbBhUhMDdeSDXvlmI8IQsTo8jHyACiKFzqabTtDXzg/sRhd95EJVBeKiWIqNY9IqIi44svoTuZ+fLEFNmAvZNNVPWEE6aDGFwqwwE/r9Le9SuSjTmZhb+2U/ALwL8bOy9ksmMMrGf13mhmyGlred1a/Pxm4A1hEN+uO0pMDh+kj7+2iLLNXt4XQiXE7jfVDBwTkMONnDs0LgWLPJFTl+pUuOomDbOtU8QteBdQ1aQdnZNUr/xBWx4RB/w==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(4326008)(6862004)(66476007)(66556008)(8676002)(316002)(6486002)(66946007)(6636002)(54906003)(6512007)(508600001)(9686003)(6506007)(2906002)(85182001)(83380400001)(186003)(26005)(33716001)(86362001)(38100700002)(8936002)(6666004)(5660300002)(82960400001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TzJydGVmdG1FVkdEUFpNV1BWbHFSajdNTXQvc09CcVl5UlRscUtOOW1NVWpj?=
 =?utf-8?B?bHJXQjRMZzQxTjAzdTRJY3FlSko2RHdLVnRHeFBoZTZBZFU1TFRPWkRpbGl2?=
 =?utf-8?B?N2wwbHgxb1FlRTFMaVQ0UWpCUFpNT2Q5a0JSQXVMOVg1QzB1SXg2Uys5MlY0?=
 =?utf-8?B?ZFBhYXU1NGQ1QWtQTDlJek5yTnNiaG5PTXA1YjVwS3M5SnVrVmJtd1ZhWGI1?=
 =?utf-8?B?Q1dnUFcwU20yNnZjSzJrV201N3l1bEJVelAvWWg5a204SE5udHpXZVhKODBx?=
 =?utf-8?B?NnlpazRRdmxXczhjT05paXIrZkJEUENldkErWEIxZk42UVJqaU84MUtzRHVi?=
 =?utf-8?B?UmVPTkt0SHVOM0VLZ3p4NUR4ZWhTL0YzMFA5bzZjVkZLdUNXTElGT3M1djBy?=
 =?utf-8?B?aUNKamdNRkl6cER3d2NYdEdLSGR4dmxhM0VJakxFd2Q1VFJneHZSMHhKeWNs?=
 =?utf-8?B?OFdGNzRYSG10M2lIQ2paNnlIVnc3REpPSkxnZXhYbVZUL2xjRmF0YVlwWm5a?=
 =?utf-8?B?bUFLd0dZS2xUU0lGRUVRYzNKMS9uenIxMTdjS08vZlp4K200ME5XeDZmYUZR?=
 =?utf-8?B?RzlTNmJzalBPN1hETWxkdHoyYmJZVDN5UCtRSEZYRnJNMm50YWhIb2VQakVH?=
 =?utf-8?B?dktaNm9KU0hkQWEwNWVVbVRxdEV0SGwwT05sVjBBL1ZnSzk1bmxSbk5pMDZy?=
 =?utf-8?B?eldtTFE0UUFBcU9CYkpzamRYOXhVcWljL2U5bnNNc05GNExCWVJRZ0NWcmZI?=
 =?utf-8?B?K00zc3lYSFlxZkMrUUEyT2IrWDY0S0FWVkpyblFUNFlUeWJHUXJCcTlZUEI5?=
 =?utf-8?B?cm4wbk5xWEp6N2hDcFI1c29TVEFVRDVMazJPckVBYnhZSjZYZWpQYUU3azc3?=
 =?utf-8?B?RmMydHg5V25nK3d1cEQydjFwc3N5bHBSV2o0MmNqSkFhamVLVmN2K05wK1pk?=
 =?utf-8?B?eWVKYVhZUmRUQWFRV09iKzNuTUFYbjlzcWVFZkxwYitxakcrcE5IK09pd0hr?=
 =?utf-8?B?SHNBSENJUDVGS0QrRG1vZE40QVZFd2M1MXBVM3FVR0R3ZXdaaGNlZmwwMGgy?=
 =?utf-8?B?STlETmZSUG1VaHFkV2o5dVhpOUxINnIyZDR2M21nZG4wV2JHWFlFV3VUcE1z?=
 =?utf-8?B?elI4YU93M2Z6RWwwelc4SnJ0RFd3Mk1vQnhNTkk0NXFIQlZ1aG1ZRnNKdEZW?=
 =?utf-8?B?UEhEYVkyWC9mdThiWFlNK1hkTGpicXZBMHpXb2hwMklpQ3d3MUd5dkpRY2ZT?=
 =?utf-8?B?TjRMcW1iMzVib3MwR3R2QkhYZHJOempkd1hYODR1S3V3S0k0ZDZXb2MzQWht?=
 =?utf-8?B?V0VwZmZHaytPVk5hVjl5LzdsSENhdXlwVnAyd0VGT3hBMUd6VXlVRXBreFhI?=
 =?utf-8?B?enBsb3hNenFqNXZFRzA5SXo1VHd1REtEeHRoTlQ2dUk2WGdTdTlFTnJaWUF6?=
 =?utf-8?B?cHEzL3JwS2dNY0t3SkhaUVdvMlNCSnIzam93SHF0eGQwcUlyc2FzRTAxU0Jw?=
 =?utf-8?B?VHN5bXhRMUlmbkl2SlFPWTlpR01QaWFTb3RuZDg4eE85TWdiZUQ2c1dKZ1ha?=
 =?utf-8?B?dVRrM0J4c3U4NmF6aTFMNHdJVXI0Mi9oRlJVcWszMzZQK29NZmhUcjVqY3lB?=
 =?utf-8?B?ajhJd01SeC93T3NiWFNVRjFGZDhPU08zcVdhZzF2VDdMTm9yT2NyTDBLNnlJ?=
 =?utf-8?B?R0NWSDcwa1FsZzNKdHl6emsyc0hPRGlpclRCeHhQWGNmazQxek1GRUY1aHk1?=
 =?utf-8?B?RG5DY25EZXFldE1QcHNPMVhkTzQvdDFWRjgzVTUrclBEOU9nZzJJY2VjVnkr?=
 =?utf-8?B?Rmk5WXdyV3U2bzE3R2kyVTk2RVRCUTd4bWhTUENDdk1sbXdsaFN2UlBOa3lM?=
 =?utf-8?B?eklFTW9LRE15NGd4S1BTTnE2aVpQLzhCTXlMeUtRdG1mYmhhOUJ6OU94MmNv?=
 =?utf-8?B?ZUkyU0tHNjZDV0YwNGk5RE43WGZpZjJ5VkhmK0NjR2lENU10NUZlaWFKY01H?=
 =?utf-8?B?Z1Q4RXVnS01kUUFadXZIT0dlTjV5czNtb2ZKM0FtdW1oa1NoQTlXcWFHSFVO?=
 =?utf-8?B?ajExT3NJRDI0UnAydVVaNzhvS01INkxmYWRLZklONTVCWUE3ZGVmWE5tS2E1?=
 =?utf-8?B?aGVRYmZzRTB4K05TWklQQmJUYnY2Y1FoRHY0MnlXWFJ3RlptNzFzUzNaY2U5?=
 =?utf-8?Q?94oDvjxbetUb+atKtOhOJsc=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e86ad10f-dd20-4ea0-141c-08d9ec7d64c6
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2022 10:09:15.8061
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qyw5tfsAmV6ISw5G72bjj7Gi/j9ntx5Y8RAqElCkiO/AlS0ivwKIKjz4/IsT/+0ThR8dh6WvcOhJAlhcF/xpsg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR03MB4129
X-OriginatorOrg: citrix.com

On Mon, Feb 07, 2022 at 06:21:01PM +0000, Jane Malalane wrote:
> Introduce a new per-domain creation x86 specific flag to
> select whether hardware assisted virtualization should be used for
> x{2}APIC.
> 
> A per-domain option is added to xl in order to select the usage of
> x{2}APIC hardware assisted vitualization, as well as a global
> configuration option.
> 
> Having all APIC interaction exit to Xen for emulation is slow and can
> induce much overhead. Hardware can speed up x{2}APIC by running APIC
> read/write accesses without taking a VM exit.
> 
> Being able to disable x{2}APIC hardware assisted vitualization can be
> useful for testing and debugging purposes.

Might be worth adding a note to the commit log in order to note that
vmx_install_vlapic_mapping doesn't require modifications regardless of
whether the guest has virtualize_apic_accesses enabled or not.

Setting the APIC_ACCESS_ADDR VMCS field is fine even if
virtualize_apic_accesses is not enabled for the guest: as long as the
feature is supported by the CPU the field will exist.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Thu Feb 10 10:19:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 10 Feb 2022 10:19:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269772.463859 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nI6Xh-0006Fp-HU; Thu, 10 Feb 2022 10:19:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269772.463859; Thu, 10 Feb 2022 10:19:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nI6Xh-0006Fi-EV; Thu, 10 Feb 2022 10:19:13 +0000
Received: by outflank-mailman (input) for mailman id 269772;
 Thu, 10 Feb 2022 10:19:12 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=T9Dk=SZ=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nI6Xg-0006Fc-0z
 for xen-devel@lists.xenproject.org; Thu, 10 Feb 2022 10:19:12 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e13f970c-8a5a-11ec-8f75-fffcc8bd4f1a;
 Thu, 10 Feb 2022 11:19:09 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e13f970c-8a5a-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644488349;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=/GeQuziQB206cLzZHKpMdbkssAbKN0TVQ12wh4KuzaA=;
  b=ZQCFk1klATCrtsReOFCbr7wKstI2MWamZR+4I0cR/MkKDRY+E7xWeTJE
   Dlb5rcZr6qtxFSv7pQNUPeCJXs8+4Wc/IoaRBskm4IQKr6Dj2nRG99K5l
   5/OP+rAD5epXxIYa/2KYEQZUj9jaBOOZseVM5evNm1wjmRb1AFrdHrf01
   s=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: 1fQE89PZh/+93ylIoxoh1muDEpZcglxB8hTGWPSoKcldJYHBMpKVDBbfgra37rNUDTxnQxnCDb
 PuYDAHpo6Bsx0H8+ubbbPf8H32pJxb3O4CRNLSx09BBVBXq0rGtnnhhE7AAsOiiuNiA4ppVWb0
 3SzC8dmZCzVNTucDQvBL5zkyJzkL11LUjKXQZwxI+PwrmS2MrGKuOsnYb25I4L3RxijWi6q8x/
 Hh7xhixaEaFCuo75VE+yRxIDd/IZCRYJ0bj+GLIQMSS0NASkN8/c0TWPjIVSuApslnUKCcKdRM
 fOBn6hbBdmZ0D9SwgaxNVNsj
X-SBRS: 5.1
X-MesageID: 63912501
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:LkVDYazPZiyEWMwUSY96t+fewSrEfRIJ4+MujC+fZmUNrF6WrkVUm
 GAdXDqAb/bYa2D1KdAkb9iz9ENTu5/cnIVqSAs5riAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAhLeNYYH1500g7wbdh2tcAbeWRWGthh
 /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL
 wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt5NS2
 YlitJC+chY0OImTuuRebSRpEAgraMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr
 6ZBbmlQMFbT3Ipaw5riIgVort4kI8TxepsWp1lrzC3DDOZgSpfGK0nPzYEDjW5q25gXdRrYT
 5YpYhs1ZRWeWEwVYU0+VKsuvrf3j0CqJlW0r3rK/PFqsgA/1jdZ0rLgLd7UcdyiXthOkwCTo
 Weu13v9KgEXMpqY0zXt2n6tgO/JkiTwHp4PPLyi9+Isjkf77nweDlgaWEW2pdG9i1WiQJRPJ
 koM4C0soKMuskuxQbHAswaQ+SDe+ERGApwJTrN8uFrlJrfoDxixRUsVEhFAZNIdpdIwYWMI1
 hy3ouLqLGk62FGKck61+rCRpDK0HCEaK24eeCMJJTc4D8nfTJIb1UyWEIs6eEKhppisQGyrn
 WjWxMQrr+hL1aY2O7OHEUcrat5GjrzAVUYL6wreRQpJBSspNdf+N+REBbU2hMuszbp1rHHc5
 BDoeODEtYji6K1hcgTWGY3h+5nzuZ643MX02wIHInXY323FF4SfVY5R+ipiA0xiL9wJfzTkC
 GeK518NuMQJZCPxPfAmC25UNyjM5fO5fTgCfqqKBuein7ArLFPXlM2QTRL4M5/RfLgEzvhkZ
 MbznTeEBncGE6V3pAdatM9GuYLHMhsWnDuJLbiilkzP+ePHOBa9FOdUWHPTP7tRxP7V/23oH
 yN3apLiJ+N3C7alPEE6MOc7cDg3EJTMLc6q9ZIHLLPfSuekcUl4Y8LsLXoaU9UNt4xel/vS/
 2H7XUldyVHlgmbAJxnMYXdmAI4Dl74mxZ7iFSBzb1uuxVY5ZoOjsPUWe5ctJOF1/+1/1/9kC
 fICfpzYUPhITz3G/RUbbIX889M+JEj621rWMnr3eiU7cr5hWxfNpo3ucDzw+XRcFSGwr8Y//
 eGtj1uJXZoZSg1+J8/Kc/bznUiptH0QlbsqDUvFK9VeYmv2941uJ3Cjh/M7OZhUex7C2iGbx
 0CdBhJB/bvBpIo88d/og6GYrtj2T7siTxQCR2SCtOS4LyjX+Gan0LRsaufQcGCPTn7w9YWje
 f5Rk6P2PsoYkQsYqIF7Cbtqk/4zvoO9u79Aww14N3zXdFD3WKh4K3yL0MQT5K1AwrhV5Vm/V
 k6Vo4QIPLyIPIXuEUILJRpjZeOGjKlGlj7X5PUzAUP7+C4oo+bXDRQMZ0GB2H5HMb94EII52
 uNw6scZ5ju2hgcuLtvb3Dtf8H6BLyBYXqgq3n3A7FQHVub/Jol+XKHh
IronPort-HdrOrdr: A9a23:K6Z9W6rQe+3a23/xcVOkD38aV5vJL9V00zEX/kB9WHVpm5Oj+P
 xGzc526farslsssREb+OxpOMG7MBThHLpOkPMs1NaZLXLbUQ6TQr2KgrGSoQEIdxeOk9K1kJ
 0QDpSWa+eAc2SS7/yKmTVQeuxIqLLskNHKuQ6d9QYUcegDUdAe0+4TMHf8LqQZfngjOXJvf6
 Dsmvav6gDQMUg/X4CePD0oTuLDr9rEmNbPZgMHPQcu7E2rgSmz4LD3PhCE1lNGOgk/i4sKwC
 zgqUjU96+ju/a0xlv10HLS1Y1fnJ/ExsFYDMKBp8AJInHHixquZq5mR7qe1QpF692H2RIPqp
 3hsh0gN8N85zf4eXy0mwLk303a3DMn+xbZuCilqEqmhfa8aCMxCsJHi44cWADe8VAcsNZ117
 8O936FtrJMZCmw0xjV1pztbVVHh0C0qX0tnao4lHpES7YTb7dXsMg24F5VKpEdByj3gbpXXN
 WGNPuspcq+TGnqL0ww5gJUsZ+RtzUIb1q7q3E5y4KoO2M8pgE686MarPZv6kvouqhNDqWs3N
 60QpiAoos+O/P+XZgNddvpfvHHeVAlYSi8Rl56cm6XXZ3uBRr22uzKCfMOlaWXRKA=
X-IronPort-AV: E=Sophos;i="5.88,358,1635220800"; 
   d="scan'208";a="63912501"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Jl49r/W5HuVJ/vNOKJC6Lxa1TRKJOG/knfAHgAuTmp0tJKohWFfJvwFMZJozwteh1xU/zJcYyzUvSK93xveuXbNg+O60lqdvwaY0iUaumXfT7uOa6gJpTOLWdB9QbjBeNzo65ia2REXbEEHa3JrV4jA1qeDfgan55tS3Mcd+lSJYmRS6l7YWeSdsN2AZsnTEDePil/Zm7faMJofUztCO0CZ4WtMHeh0jLxmwlhFSzWzH8/b7MF165fJWq2dJp1I3IfXvPy+QP+9PXPjkxT13+dF8HHDxRKsLMzGKJMmwPHnlSVteJbagzQ7WY4PMcmAr+gQsNOxMEU1LdyGvufQAWg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=GvA6aYddxr3wvbK3Zkc+A3oqbUfpExSTOOEMkQLjD08=;
 b=WTE6cR4mUWpiQDP00z/8MEEamk49/ZJEqc8FYeZraGwZqjdvYqhk3RYPesrjzMfJvIlEEClAiTGXMTQuKE5nh8k57IhoUVjYtPpYXmN6cZwSQkSVFNi5XAPNCwcPteE5fJHi4d3TeXLkiMvlq9wCH882lh04l64ggzvGLQ3eHcIjkRrkAFG6djF9JmGrploz1dJq7q3RgGtn/wG6CvPdiuYDbuBT4xRhXUmIONfncx8IBJ9n2zHitbIjhH0HNNELVsWw3N3x28KwiL0ClQNVkukIy4S+wPZS7hE52vzSPGRB+8euxg46m1MaAfeRHK5zs1HVVM8mZ/OEZeu6qXmJXQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=GvA6aYddxr3wvbK3Zkc+A3oqbUfpExSTOOEMkQLjD08=;
 b=LW0rAVdPzEZyPcXXLmR6xoQBKT6pVqzF7KNmH/UW+Bi/9y44oQb/9U50MXZdvFTEg44LMmUw6bRAY3uPTmkZL+snjaWv38IwjukPEjFIKu0DKuELeSftzddOYdL+qEYdwGnRqItr127EL9Iaz337y72FrX/w4F0Y9lmI9lQT9H8=
Date: Thu, 10 Feb 2022 11:18:58 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Tu Dinh Ngoc <dinhngoc.tu@irit.fr>
CC: <xen-devel@lists.xenproject.org>, Jan Beulich <jbeulich@suse.com>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v3] x86: Prioritize low memory size from Multiboot
Message-ID: <YgTmksnAoHRSAdF7@Air-de-Roger>
References: <000c01d81dcae25e6f0irit.fr>
 <20220210084436.84-1-dinhngoc.tu@irit.fr>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20220210084436.84-1-dinhngoc.tu@irit.fr>
X-ClientProxiedBy: LO2P265CA0156.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:9::24) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 370315db-5860-4da4-aa0c-08d9ec7ec2d8
X-MS-TrafficTypeDiagnostic: SN6PR03MB3741:EE_
X-Microsoft-Antispam-PRVS: <SN6PR03MB3741509F9519548F9F439FF98F2F9@SN6PR03MB3741.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5797;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: eAMG5NeMHfIDffTeITYdwOqsL81uVRFyw1ZflI6c9geu0xSA9hcv7MOEuXtbyHQnGd4eqDdHiVF8Meu+GaCzo4xy+shx7UYmS4Jp+ILpmUf7CVN2b/KFf1lfv+kobv6Rd945Ve6H6UVfSH/z4Q62nCrPoZnLHEyAsIPkYFDhLTgDKbyDgN9vsFWF6veq2IurGMzSkwaPEplqLixwrCQA6iJFFdB/oszb54hORWI4mRfcwynivbQO/pGymoK1LD7Ms3LLmhMNo0sCiamd+yQqZJKPwG1ue7G5D1fjM5Ox9NFC5GYdzND7+ojziCvn0Ch3Q7rEWrhEJ12jpRn3FI8aWzuSV76qhhuxxgoCRPeikbM97lKUOJFXdlK9y5f++K+OtVnmaU5kQ5rBCqp5dUh/P03nb9sazbvUV+fYzxDbRrXZAaVOtGQzbiZGNkrHS8TFPVRy7b9E2yGmDlV0MAi91JacyWNle+mjeseKxCzkPBxe8fW4mHuyhtPtzp7bRb2mKIHUP79ipQATwPOauDSMOPPPYcTB8X/49lrpjNuO+Xmzy7/JDj+pM9sPmMCFQzfCTkF5Fb7Ih7cFY0+fLV53dthhkD3wpdn3DMfskPtKTYFC1ak+6npGHCQh5kljbIrIYj893PCOgLiEE2p3w6hz1w==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(83380400001)(33716001)(6666004)(508600001)(6486002)(5660300002)(85182001)(2906002)(66556008)(4326008)(66476007)(186003)(8676002)(66946007)(54906003)(26005)(6916009)(8936002)(316002)(9686003)(6512007)(82960400001)(38100700002)(86362001)(6506007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dzdYa0cvbmVQZjN1SUpnemlvYmU1c2ZkSGhXU1lNeVFTUWtnMzk1a2ZoK1Fo?=
 =?utf-8?B?U3lZd1REOEYyQ1d6T0VwZXo3bnc1YnpwYUhsQ1IyUDU4ODVtRzg3Zm9RQ0xE?=
 =?utf-8?B?Vzd4Q3IzZVU0MkprSUlHWmlRRkQ0VE92UTlxNHZsR29NZFpSbUs5ZlFVRDdL?=
 =?utf-8?B?YTRzdlBhbCt0OVM3U0hnRElEQ05DeFgvZDl5VFdDVzUxMHFTQWk1UTNxU1VK?=
 =?utf-8?B?aFVXcjNVYWRyRHcxV095ZDhOQmNva1dKVkh6OGJzVUc1VlVTQTJ2YmNnL01u?=
 =?utf-8?B?S2s3TTM3alNFbS9Rb0pneE94d0U0UG9UMGtqZjhQTXplVEhieENGU21YMHZa?=
 =?utf-8?B?QkUzUGlFTzRNWE5BUStWV3pwWXJoS1dUYnFKVDZLeWprSmNkK1ZMKzNSY2VK?=
 =?utf-8?B?Qy9tQ1g1eFY0MldiWnR1WDVpZjRRVXZRWmJXVU5LZm1mVXlxNVZPWTlDbjhs?=
 =?utf-8?B?S09vT1AxMHpFaGZJYlYyM3J4RS9YeGQzWmY1QkN1aEsxeVkvSk5DdzVoaGts?=
 =?utf-8?B?bm9LT3RHaDE3VkFhZjJjVmQxRUN0NTNpU2RRUGdtQkxzek5mdEFkTzhLR09j?=
 =?utf-8?B?VmRzcFllZ2JKM3hUR0JPa2oxRVNVaVJuK0h5Z3psZWVUakNDZFY5bzhDWWFZ?=
 =?utf-8?B?RmJ4UWxFVkdEeGI0TTFBQ29SNGhWRXp4T2Jlc3AzWnQ2OXdPaUZ4WkdVQVgr?=
 =?utf-8?B?K3Y0QjJQRHJoWTgxMEJBZzMzZlU3MWd0aWtRSnNHbGltZFp3NjcrNTd3SHVL?=
 =?utf-8?B?Z3BuSm0vUXMraW95cU5vL2NkU2NvbGVwcWRzMHNJRUVZN2hTeGNKNkhacjBP?=
 =?utf-8?B?Mnp4ZERrVjMwNktXdzlGVFBKcmdUSCtKaWlNWHZYeDE0Y3d4VDlEWGQ1d25m?=
 =?utf-8?B?VENHYjlrbzhORU1qVEFlOVZqRUdhZDY4cC9mZ1U2bkxTTzMwcWFmWjZ1eGVX?=
 =?utf-8?B?MWY0dmRFZU1xTlFmeG9YZGl2MkIxd0RGWCs4ZDM1Mnh4cm1pY3ZDc1B6anJS?=
 =?utf-8?B?ejd3MThuRjgyRHRGS0lOa3ZPbjNsZjNKUjU5aUkrV0tON29NbWhaWjIwS1ZR?=
 =?utf-8?B?Uk5odVM4Z3RXcERoa2JvTTZ3MHV1N254aDFqTmFNeXdJTXEwcG0vd21LQjZi?=
 =?utf-8?B?MWdGZHRHeFFFVHF0ZUpOckRsakM3dG5SUklic2Z2VHNZSWlWNHlFdWVtVG82?=
 =?utf-8?B?QUFKUzJiYXYwRy9FVVhRMGFBRW8vUGlFbmtzNmJoN3QvTGdEMDc0UzdyU1pM?=
 =?utf-8?B?MFE2VnMxTTdOUXJnY0tsZWdjMTE0QTYvbncrWHdDN3FYck9EeEJIRHdBMkRN?=
 =?utf-8?B?eFQ2TVlhcnNqb0tFWTVhWkUwNnpXektjVXdxbVZha0J0U2ZqVFhqNWNUanpT?=
 =?utf-8?B?U1hIU2EwY1k1dlV2MjZMMlRIR1RwMzdHQUUxdG5vcUJnc2xhK01WZXUzaWVP?=
 =?utf-8?B?MElyOTF1N3NwMTFieVl0RDk1REEwWDdsYVV6a3luYUcwVm9QMzlLcld6cndL?=
 =?utf-8?B?SVpPaWFhczFsdHBJeEd0Nm9icU1iS2J4TjZSY24rdnV1bmFVK3BERTNUMk9o?=
 =?utf-8?B?dnMzWFh3QUtRczBxaGxLeDBIZk1YNXFPekd1ZkpPRE5vZXdjSXlNdzBEWmIx?=
 =?utf-8?B?ait2ZDhJSUpvcklFTUdLcXdPRWliMm51RS9Rb25SRUxidE12OVdCdzNXcDg0?=
 =?utf-8?B?QmtCTE1rQUZsbVhvU2tHL0ovanV2cVF4NFhkWnNqK24vR3ZabHFzRlBQUXFE?=
 =?utf-8?B?dmpaQ3RVdXVJN3g1SDNrdHNKQzNRRWloUEpSekR2T0x6NDN5a1loUGUzSmEv?=
 =?utf-8?B?N2RrUlpJTHdROE9EZVNlellUOXJCcGRtYTBxenQwTUZNWFhCR1E0aEV2ZjVS?=
 =?utf-8?B?MUZnQVF6b3A5U1lMNVpnYlkwR3ZxaEQ0N0M0aVFTYzFVY1BKSXZqRHFUdzdv?=
 =?utf-8?B?WnlubWYyNGZoOUhheWdSMzBZbWh6UEFHa2xiaEFjZ0RTWHBrWDF4eDRwOUt3?=
 =?utf-8?B?cWF5NENSUTVONnIzbXJyMlVGYzdDTGg3TnIxNGp1ZFpyNFBscVdKUmZGMTI5?=
 =?utf-8?B?NlUwRUh6SVV6YTV4c3U4cDRwSnpYQ0c5NFNLZjROUFJXcEVCeU5iUFcrSTZF?=
 =?utf-8?B?T000ZW4yTE5iYm9JWDdJZmR2SHp6QTRkL2hRZktodU5pOXJwcWZ4cEVrSU81?=
 =?utf-8?Q?SOEBw+5ZshkW9CnFRKiIdfY=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 370315db-5860-4da4-aa0c-08d9ec7ec2d8
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2022 10:19:03.0524
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IWglbpNojadgIBJc9WJdsezkfiiUSwPG3UxSILzVgl6+TazV9oJ/A+LQ0W2yVYFtis/5w4zgywV2U3Rluy6BaQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR03MB3741
X-OriginatorOrg: citrix.com

On Thu, Feb 10, 2022 at 09:44:36AM +0100, Tu Dinh Ngoc wrote:
> Previously, Xen used information from the BDA to detect the amount of
> available low memory. This does not work on some scenarios such as
> Coreboot, or when booting from Kexec on a UEFI system without CSM.
> 
> Prioritize the information supplied by Multiboot instead. If this is not
> available, fall back to the old BDA method.
> 
> Signed-off-by: Tu Dinh Ngoc <dinhngoc.tu@irit.fr>
> ---
> Changes in v3:
> - Prioritize using Multiboot's memory information.. Fall back to using
>   BDA in case MBI does not supply memory info.
> 
> Changes in v2:
> - Detect if Multiboot claims there's more than 640 KB of low memory
>   (happens with old Kexec versions), and correct the memory unit in such
>   cases.
> ---
>  xen/arch/x86/boot/head.S | 44 ++++++++++++++++++++++++++--------------
>  1 file changed, 29 insertions(+), 15 deletions(-)
> 
> diff --git a/xen/arch/x86/boot/head.S b/xen/arch/x86/boot/head.S
> index dd1bea0d10..da7810060e 100644
> --- a/xen/arch/x86/boot/head.S
> +++ b/xen/arch/x86/boot/head.S
> @@ -524,27 +524,41 @@ trampoline_bios_setup:
>          mov     %ecx,%fs
>          mov     %ecx,%gs
>  
> -        /* Set up trampoline segment 64k below EBDA */
> -        movzwl  0x40e,%ecx          /* EBDA segment */
> -        cmp     $0xa000,%ecx        /* sanity check (high) */
> -        jae     0f
> -        cmp     $0x4000,%ecx        /* sanity check (low) */
> -        jae     1f
> +        /* Check if Multiboot provides us with low memory size. */
> +        mov     %edx,%ecx
> +        test    %ecx,%ecx
> +        jz      1f
> +
> +        /*
> +         * Old Kexec used to report memory sizes in bytes instead of kilobytes
> +         * like it's supposed to.
> +         *
> +         * If Multiboot reports more than 640 KB of low memory, assume we have
> +         * this problem.

Is 640KB the absolute maximum of low memory that can be reported?

It would seem to me that reporting 1000KB or more is obviously wrong,
and would satisfy the check for old kexec reporting in bytes instead of
KB?

Do you need to also check that the adjusted value is between a sane
range also?

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Thu Feb 10 10:44:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 10 Feb 2022 10:44:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269782.463871 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nI6vf-00013e-O2; Thu, 10 Feb 2022 10:43:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269782.463871; Thu, 10 Feb 2022 10:43:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nI6vf-00013X-KC; Thu, 10 Feb 2022 10:43:59 +0000
Received: by outflank-mailman (input) for mailman id 269782;
 Thu, 10 Feb 2022 10:43:58 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nI6ve-00013N-Gw; Thu, 10 Feb 2022 10:43:58 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nI6ve-0008Ac-Dw; Thu, 10 Feb 2022 10:43:58 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nI6vd-00046Q-Mp; Thu, 10 Feb 2022 10:43:57 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nI6vd-0002RR-MN; Thu, 10 Feb 2022 10:43:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=HKho2ss1z78tEnXy1kk1LTuld4kXUzlwr1rmc8TijyE=; b=JeuRXKS1fX1egTFksTwSy3Vkb/
	rz6YW0WPtGq9cZB+47VYnIJ0j6ZI/feT0eoWv0+p7LLqMKkAYqboUUwd0TrjZF53p6ORqPoIrZsyn
	G+wRl4quQ3qYI5ynymzZPzbZge6B/FWw1xuCsCGTXmlfJf1VSW54g1J5fRjSGqEq+fUI=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168075-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 168075: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=87319afb96973213ec0a76270d93696f3b8d6743
X-Osstest-Versions-That:
    xen=52ce1c97844db213de01c5300eaaa8cf101a285f
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 10 Feb 2022 10:43:57 +0000

flight 168075 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168075/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168069
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168069
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168069
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168069
 test-armhf-armhf-xl-rtds     18 guest-start/debian.repeat    fail  like 168069
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail like 168069
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168069
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168069
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168069
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168069
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168069
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168069
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168069
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168069
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 xen                  87319afb96973213ec0a76270d93696f3b8d6743
baseline version:
 xen                  52ce1c97844db213de01c5300eaaa8cf101a285f

Last test of basis   168069  2022-02-09 10:47:48 Z    0 days
Testing same since   168075  2022-02-10 02:45:22 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Volodymyr Babchuk <volodymyr_babchuk@epam.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   52ce1c9784..87319afb96  87319afb96973213ec0a76270d93696f3b8d6743 -> master


From xen-devel-bounces@lists.xenproject.org Thu Feb 10 11:01:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 10 Feb 2022 11:01:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269805.463918 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nI7CB-0003nF-IT; Thu, 10 Feb 2022 11:01:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269805.463918; Thu, 10 Feb 2022 11:01:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nI7CB-0003n8-Dw; Thu, 10 Feb 2022 11:01:03 +0000
Received: by outflank-mailman (input) for mailman id 269805;
 Thu, 10 Feb 2022 11:01:02 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=kYjf=SZ=citrix.com=George.Dunlap@srs-se1.protection.inumbo.net>)
 id 1nI7CA-0003n2-1Y
 for xen-devel@lists.xenproject.org; Thu, 10 Feb 2022 11:01:02 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ba168e9a-8a60-11ec-8eb8-a37418f5ba1a;
 Thu, 10 Feb 2022 12:01:00 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ba168e9a-8a60-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644490859;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:mime-version;
  bh=n4xeR7tAFcfdWbssu15YuhOldLDpjVTCyhfyOKvN0ts=;
  b=FzrgohJ7rcxPIjL2rMtV/5RF9Z4iawgPaAVYrrMkMVCcIiuoSoZ8Vwr3
   MSQcdja47HrjwHKXNgk3P6UGazbCJTThgpAU5Md1xeo/6ilMGTyOiLjud
   yZUK+cLxiJ2neK5vgW/fH3VmgNFpXNwyBiXjJtKwqIbFv4B+04g7c6NLd
   Q=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=hardfail (body hash did not verify [final]) header.i=@citrix.onmicrosoft.com
IronPort-SDR: Q6sS9MAcxheU43qvdxrbNoUeUV03Ebj5pJZSwvq6i4WYrkRP1XrQBkvgGsdqatyv1QLKVCChLs
 J1QGRxZNGsPJ1jPp3uJsaFajB8AV9omWY2B6tVMC+zJedz2r/6mCgPWrjaQBIUb2Z8K7SdHyHx
 AIwB5cHEORXjBdD289lUHYWW9rzrpf0Zs50bs/zODJ5n2mS3zFOYPUlCdhLVTaN+BDOnoXzjb0
 9cpOEK9EtPpO6rVatdgXM5rsT25Tl1RNGHpimBBvyYG281hdqpo0fITuWq+RqKAVuPOsv/waQ6
 ppyS80k6dTA2PlT6/wZJWnAo
X-SBRS: 5.1
X-MesageID: 63917725
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Lybz/6ldkPnaYe7s0RL3aVLo5gzvIERdPkR7XQ2eYbSJt16W5oA//
 9YtKSrfbaHbJie3LscnK96GQXl2sZCGzdcyTAE5/i1nFHgToJPLCYXAJxqsNCicfsbJQB4/5
 c5PNojNd5k5Qy/X+0fzPum7pHNwiPvQG7StBrTNa0idKeMcpAIJ0HqPzMZl0t4AbaGFPj6wV
 fPOT+z3MQX0i2AtYmtJsPyO9E1i5qis6GJG5gYwbPlGsAGFzidEUJ5HKa+PdHapGYM88sxW5
 grgIBNV2kuDon/B3/v8yu6TnnXnxtc+BCDW4pZsc/HKbiNq+2pigs7XCNJGMR0N02/Qx4goo
 DlwncfYpTkBb/WkdNs1C3G0IwkmVUGR0OaaSZQXmZX7I3zuKxMA8d03ZK0FFdRwFtJMKXNP7
 ZQlxAUlNXhvsQ4ULIWTEYGAjux7RCXi0Rh2VntIlVk1Bt5+KXzPrjmjCXa1E17ci+gXdcsya
 fb1ZhJPQxXuTy9oYGsQI5c3s+Kkmkn2IzZx/Qf9SaofuwA/zSR02bnpdtHUZsaLVYNemUPwS
 mDupjqjREtAbZrGlGTDoinEauznxEsXXKo9Gbqi+fMsrECVwmULIBYXSUG6sb+yjUvWt9d3d
 RdFo3Vx9/VaGEqDZPjQUz+0kVe/5CEsAOsTGeAgySau8/+Bi+qeLjddFWMQADA8j+cmSDpv2
 lKXktfBAT10rKbTWX+b7q2Trz65JW4SN2BqTSQDSA4Y5dj/scc2hxTGQdt5OL64iMXvHjP9y
 CzMqzIx750QgM8X1+Ow+lTKhjuqjp6TVQMv+AjNRSSu6QYRWWK+T9X2sx6Bt68GddvHCAna1
 JQZpySAxMAhDL+hpgvXfOImGbiG4vqZADSMinc6SvHN6A+R03KkeIlR5hR3K0FoLtsIdFfVX
 aPDhe9CzMQNZSX3NMebd6r0Up13lva4SbwJQ9iJNoImX3RnSOOQEMiCj2a01nulrkUjmLpX1
 XyzIZf1ViZy5UiKIVOLqwYhPV0Dm3hWKYD7H8mTI/GbPVy2Pyf9pVAtagXmUwzBxPnYyDg5C
 v4GXydw9z1RUfflfg7c+pMJIFYBIBATXM6q95AMLLbbeVo5SQnN7sM9J5t6IuSJeIwPyI/1E
 oyVABcEmDITe1WbQel1VpyTQOy2BssuxZ7KFSctIUypyxAejXWHt88im28MVeB/roRLlKcsJ
 9FcIpnoKqkfG1zvpmVGBbGg/dMKSfherV/XV8ZTSGNkJMAIqs2g0oKMQzYDAwFQUnTp5ZFj/
 9VNFGrzGPI+euirN+6LANqHxFKtp3kN3uV0WkrDON5If0vwtoNtLkTMYjUfeKng8D3PmWmX0
 Ri4GxAdqbWfqoM56oCR16uFs52oA611GU8DRzvX6rO/NC/7+Gu/wNAfDLbULG6FDG6kqr+/Y
 eh1zu3nNKFVllh9rIchQa1gyrgz5oWzquYCnBhkBnjCc3+iFqhkfiudxcBKu6AUnu1ZtAK6V
 1ih4N5fPbnVasrpHERIfFgub/iZ1OFSkT7XtKxnLEL/7S5x3byGTUQNYEXc1H0DdON4adp3z
 /0gtcga7x2EpiAratvW3DpJ82msL2AbV/l1vJ8tH4K22BEgzUtPYMKAB3auso2PcdhFLmIjP
 iSQ2PjZn71Zy0fPLygzGHzK0bYPjJgCokkXnloLJlDPkdvZnP4nmhZW9G1vHAhSyxxG1cN1O
 3RqaBIpdfnfoW8wiZgRRX2oFiFAGAadqx74xFY+nWHES1WlCz7WJ2onNOfRpE0U/gqwpNSAE
 G10HIo9bQvXQQ==
IronPort-HdrOrdr: A9a23:b5khYqgSU1AHt19YJk4DSuQOknBQX3N13DAbv31ZSRFFG/FwyP
 rBoB1L73DJYWgqNE3IwerwRJVpQRvnhPpICPoqTMiftWjdySWVxeRZjLcKrAeQYxEWmtQtt5
 uINpIOdeEYbmIKzPoSgjPIaOrIqePvmMvD6IeurEuFDzsaEZ2Ihz0JUTpzeXcGIzWucKBJba
 Z0kfA3wQZIF05nC/iTNz0gZazuttfLnJXpbVotHBg88jSDijuu9frTDwWY9g12aUIO/Z4StU
 z+1yDp7KSqtP+2jjXG0XXI0phQkNz9jvNeGc23jNQPIDmEsHfqWG0hYczBgNkGmpDq1L8Yqq
 iKn/7mBbU015rlRBDxnfIq4Xi47N9h0Q679bbSuwqcnSWwfkNKNyMGv/MCTvKR0TtSgPhslK
 1MxG6XrJxREFfJmzn8/cHBU1VwmlOzumdKq59fs5TOObFuGIO5gLZvt3+9Kq1wVh4SKbpXZ9
 VGHYXZ/rJbYFmaZ3fWsi1mx8GtRG06GlODTlIZssKY3jBKlDQhpnFoi/A3jzMF7tYwWpNE7+
 PLPuBhk6xPVNYfaeZ4CP0aScW6B2TRSVbHMX6UI17gCKYbUki956Lf8fEw/qWnaZYIxJw9lN
 DIV05Zr3c7fwb0BciHzPRwg1jwqaWGLH3QI+1llu1EU4zHNczW2He4OSITeuOb0oEiPvE=
X-IronPort-AV: E=Sophos;i="5.88,358,1635220800"; 
   d="asc'?scan'208";a="63917725"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=GwPDOq3qUu8EApSoOBwf/uAnon96dHZu3rtf7CToVg9L8ACbfbPMJqBtjZbRLgX4SadV+Ic4tWaZTyF/pp+bSxrWMDKVJa2A3hoz72EtwaAD2VLRz7YrPA/Crqdi6cuBM53TofniJdbndiTOOSOoNkMW2SDIGMl9xm1wmJGIsms1hpahhN2Ex9HaHjlnR/yR7/HOIfrnKlpCnBjtxOVIjMZBnZJLp/EK/WHpAhJRWS0Zs3F+sSGXLajoMpXyQFkj6WuTmCq8N4G4Oo2PrkkLRNw1pRm/5ewdEWTdLnwEkfQOfww7JuGJeWB4nRVZxdFdGmv3vDGR+hQobjVVY3tjVw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=n0SZZuHVIs0mXRGlZzfg7rQMmwRldZDftMPSxOOHAP4=;
 b=FyuHikSMj8C1QLnp2x+VdSktf/aHpPRTMX6k39UCe0cM7Y/oZMlvRMiFFPufmRYFMgZYX4AfPhVFQ5s6I/WCuCnGlBmDwgj3y1kNYSTC1SsoHPP8Q9m8N3JpGv1i0xPkCnzVyVdSxTAjRw8BpESOdUv25asMmir4J8XXaQ09D1EO3G5oL+IMPJ/8ZT0N9dnj2KJujchW7/0BnYg987iJnCwwp7VlLsVodTiGNmkl2qmgOW5MacjHPzIVb1iqM9VACZvmZQUm81lttPgcs3ha4ltLUkl7goRjM3my0cBdboObjKmeV34ZkdAbwNvZ9FfODR8NZ+Wu721YotLKJM8mfw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=n0SZZuHVIs0mXRGlZzfg7rQMmwRldZDftMPSxOOHAP4=;
 b=uiQo4tQql1LZR0LwwroHgTZnHMiGfwhTyhgrSTGovMjUUQqXtI5YJj2vyPAD0hV7mSipOM8KNkDu8PqN5cdwtXUphW0fuOENCquP+wrsG+wjxqs5wnvgbUEJvwJlCpOKJD863YAtVKEerBD+MMgDdC2YGMG2muQZK90dk2i9NFA=
From: George Dunlap <George.Dunlap@citrix.com>
To: Keith Coleman <keith.coleman@n2servers.com>
CC: communitymanager <community.manager@xenproject.org>, xen-devel
	<xen-devel@lists.xenproject.org>
Subject: Re: Retirement of XenProject 3.4 Code Signing Key
Thread-Topic: Retirement of XenProject 3.4 Code Signing Key
Thread-Index: AQHYDepUQes3TC97DEaMLNp7jJQYl6yMvxsA
Date: Thu, 10 Feb 2022 11:00:53 +0000
Message-ID: <B282E34C-0897-4E7F-9E67-E36C3F45F807@citrix.com>
References: <F388AF1F-1E62-48F5-9CB6-A4197BD6F9D4@citrix.com>
In-Reply-To: <F388AF1F-1E62-48F5-9CB6-A4197BD6F9D4@citrix.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3693.60.0.1.1)
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 35549681-8984-4781-2e26-08d9ec849b23
x-ms-traffictypediagnostic: SA0PR03MB5594:EE_
x-microsoft-antispam-prvs: <SA0PR03MB55946C2C5B03428F79178EDA992F9@SA0PR03MB5594.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:6790;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 4sDVDnyxAyFf2XnxDfPHGuWWOm7QolhxdrqDir+E/MmKJzpucNpVlApODjHY7QUmFLNjd3CIJgtRpX1IfSgm6M4kcW5SZbAMxfpU4A4P3u2AYPRWqNLYM1XGq6NuKOEsG8O1pZeHkIh+Viw0+vSJOGzKgUkAuBcmGPmfkFckuehjR3MEYPh5cAIPoO1ioReogrgs1ttcSKIm8sIVNZjTjUc1bd4Ph6DTtvvDNpqMV2hwSKRNklJ7AsikahS3dR9uOGjMIAGpYr9vzWJFFjoD47j9FBOWEXRMojzsuOcNHYoU1+SIm0eqWFfw432KVWuLYKqCnFQ90tLeWan2WXEQkqzqnn11G7ZLFs7RS0C3n/H/9xahX+sbaC0gG/HJM0wsT2TY4mpgBTxzt3/EUBU391ZuIqsiWaOWvOTTRJh1eHNemBhm4l/UO/E3AM+LbLx5lkXtSI9S8BT3EGhqyeEYux9vntFyLbhPgV93x+hKIs81ntBp5TR6StFePv/NSL6dnoqf61+58VOpZ7rxKGOwvHCS6B8C6Ky7atJXDvFliW9xCcTJmnbrMONC5R+fLqJvDb8L5XIyx4GNEfOlB+qgRaIWTPikha5GWuaF6OL8WNciJSZBVfZm3h912AlN6qzIiY51yUMoCFw5R4Yh/lcuu6Kh0FUzcr/3bURHYUG+UCV3On/XZjvuvSiz9H7u8Gz66zt/jwdnMd1vfQ3rhp90X1Xu6uHsP5DgRXgXl/rlVaCIrachfKYT6oJjq7ULoYX2
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6486002)(6512007)(508600001)(2906002)(6506007)(53546011)(33656002)(86362001)(5660300002)(4744005)(71200400001)(8936002)(83380400001)(316002)(38070700005)(91956017)(76116006)(122000001)(82960400001)(186003)(26005)(99936003)(54906003)(6916009)(66946007)(36756003)(8676002)(2616005)(66556008)(64756008)(38100700002)(66476007)(66446008)(4326008)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Q21yTlVMYnpnalNkL284a1dqM2pVUldLRG9lbWMwc2h6RFROeUNHWnMrMGJr?=
 =?utf-8?B?aW5FanVFamd4djQxWEtHaS9Fc014bnNHR1ZVUlo0R3RYcHUzQkN5eTBIVUt5?=
 =?utf-8?B?TXR2TjFJZjlPZU5QU0tMMldURHFzR2FHazBLM0h3Y29kNENGTXBEM090V0Fx?=
 =?utf-8?B?WlhtTUpNT3FITmJGT0lvTDlxUVBwTWFkR1Zha3FEY0Y5Y1BuaGtEd0ZZYTJ6?=
 =?utf-8?B?TDM3ZTVGaldHSmZxS01EWCtEbWk5bXR0cVprOW84aWQyRk9hK0YrY0ZpbFBL?=
 =?utf-8?B?anpUMW5OeHFyaTF1WVVncURuSzc0SStWeTJ4RG15Sm5BMWdnYlhLRjVDVktv?=
 =?utf-8?B?OU5RSFBCV0RycGV0eXZocFYrdzdva2JTM0dpOWVCRnJQSXpTZzBDNEdJaVJk?=
 =?utf-8?B?OVY2NFpmb0J0cXU2Vm1mYVZpeElpanFkWjlmKzVCUlhTc21yQSt0SSs5alAx?=
 =?utf-8?B?aDIxZnJOZk1oY1VnNWJ0SHMxTi92alFHTUhrWlY5QU5zT2p6cHV1aXdyeXZG?=
 =?utf-8?B?bE81UEt1QkNDRFQ1V1daaUtmQ3FHT0FEMmI0S3hyWmxjL3VJNnJRYi9RTEZQ?=
 =?utf-8?B?NmVqak1ESUNQS1RQZlhTSkt1Wkgra0tTQ0RFSll4dkV2UXFLWW1lZ1lpK1p6?=
 =?utf-8?B?QVBtTURndTZhZUUyellFQnlwckF3MnUwcnpYb2ljMmtNUUI2aDZqNmVVODNE?=
 =?utf-8?B?U24vWjB2RlNzR3ZBeDkzb2NqekhydllEQldRQ0phUnNXaDFKRUoyU21kTmN1?=
 =?utf-8?B?dHhlMTl6bUtRTGdPN0pRbmRxYnNKM09JdDFSOXNqek04RWpOem0xTXNjbW9F?=
 =?utf-8?B?Mkd2ZHZmMGd2UytLdWJuTVlIOGt0dWV6ZFh1d3Q2b0V0K3NXU2lxRVNnWjls?=
 =?utf-8?B?dmtsYTBiaDZMTlQzNzcvNzVlaHBSUXE2SDRXMEh4NUVpMmFTbUtOdVBqOHJs?=
 =?utf-8?B?SnFxVXdacVI2VEt4Q2tDM2xyQk9YRUpzcitJeGpuMS8zdTJIR2ZacDhUQ25s?=
 =?utf-8?B?bkRYdURTYXNrcU43c2ZSenhrTVdPR3dKeVpWWjJNeWZ1dnErTWRSSCthTXBm?=
 =?utf-8?B?amF6Tk92dDNqaFMxdUtyNjhvd0xVOGpoNjNuRFpzNUV5bmdkZGJIT2Z6SHRo?=
 =?utf-8?B?SGZyY0RYdGJTT3VtU1hxV2xyTndZRUVpbnQvbWZFcUs1c2d4YWNqZ2RlSW5G?=
 =?utf-8?B?cjZoQW9WdE9kdm1qbUhaaXY4NDZWOTlEaFJsV3N5OFFyZUVoRGM2NHV4QklM?=
 =?utf-8?B?RXhKS29rSjlUdytZN3J0b2hoUlhkVkQrVUZ1ZWZ5ZTduYzhkSHZRNzFPQVhk?=
 =?utf-8?B?KzF0dVpLck44TkFTOTN5VUhGbjRNMWptVWVDTVRmQ21VMHpZaDZZTGtROVNp?=
 =?utf-8?B?NlJYdWIvbEcrQU9aZ0lJRHNkVVBVa3VneXVXcXdsbmQ3K0ZmdDErWCtZak9L?=
 =?utf-8?B?MUF4L01LQ2pva1ZEb042SW1waURaV29YSytHbldkblFlZzdocjkvNkNsMit2?=
 =?utf-8?B?SkRtaE54SWlNOHFaa3Z5bGhCOGlPRXdmOGZvd2NmME92dTY2T0c0WnBrRmpo?=
 =?utf-8?B?NVhJeis2THRPb2JDdEZGNHNvWm1KK0dpZVlXYlV4ZlptbXNSL25hMjhqanAv?=
 =?utf-8?B?R3kyNGo2cmhHbEZoVjFSbG5YK0F3b3BFVkxDQXIwNlBySkRTZVRLS3Z6ejVU?=
 =?utf-8?B?dFJkQktwNkVDZzJqZmdNQmZXOGpXYlJDWThEbjR2RkVadzJZSnFmeDVPN25V?=
 =?utf-8?B?SlJYZzdydVc4ZFhPaFMxdktxSWM3bWtUeXgyNGhFUkpNZUpYbkNZOEg2VWpa?=
 =?utf-8?B?V1AvSk15OFNtcmo1QXM3UWl5WlNMcmdHOGl0ekFUZFFjNkFmQXJpamdqVHNR?=
 =?utf-8?B?bUkwdHRDMDZJcDk1cnlzN0lvSzl1TDBzRFRncTJJejZkOGdxaDN2UVl6SHo0?=
 =?utf-8?B?alVuY0ZkVCtVSjZBeTRwV2c0SXFKbE5mS3dTOWRFNVZPQzVWeDV3eXV4Wkx6?=
 =?utf-8?B?TG5jNVlWayswQlRXaVd6a05UdlhyQjJ0WlJia1ZmT0Jyd2J5bzNwM2VSb0Ri?=
 =?utf-8?B?bGEwS09SQkVab1NudzhZVVlMaW4xeFJ4aUlCbEJ1aGVwY051bGJsaFJNT0gv?=
 =?utf-8?B?Z0VjdzFDNy82RG50bXJOSUJJa01jdG1LbUhIUllvK0NDV3V6MHk3TE8xaldr?=
 =?utf-8?B?aXEzNmxTclRQYmtiS3dmSGtoYUhkb2R0LzgwS1MwZ0J2eGh0dHNwSFJqalR4?=
 =?utf-8?Q?eJLXYw7oa097UG25yW2T3Z57BOTwPqLLMjZFO+VSRY=3D?=
Content-Type: multipart/signed;
	boundary="Apple-Mail=_FA717697-F817-4285-A14A-4231EF57D389";
	protocol="application/pgp-signature";
	micalg=pgp-sha512
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 35549681-8984-4781-2e26-08d9ec849b23
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Feb 2022 11:00:53.0998
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: qwrpW5tYUnBIOuLvZdrn5PQjCBgdR9OWdvu1pKxDJyi/bIA4mIDe4YgWtmrVoa3UOUY6xXfhKgajuniUdwhh5xnwluVZrB/UiIUeOoVoJFM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR03MB5594
X-OriginatorOrg: citrix.com

--Apple-Mail=_FA717697-F817-4285-A14A-4231EF57D389
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8



> On Jan 20, 2022, at 10:41 AM, George Dunlap <george.dunlap@citrix.com> =
wrote:
>=20
> Hello Keith,
>=20
> I=E2=80=99m currently the community manager for the XenProject.  While =
going through the list of XenProject keys [1] I noted that we still list =
a code signing key for 3.4.  Since there appear to have been no commits =
on this branch since November 2012 [2], I plan to remove the public key =
from the web page unless I hear any objections by 10 February.

This has now been removed.

 -George Dunlap


--Apple-Mail=_FA717697-F817-4285-A14A-4231EF57D389
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="signature.asc"
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEj3+7SZ4EDefWZFyCshXHp8eEG+0FAmIE8GQACgkQshXHp8eE
G+27hgf/aoD3IsvEfYy953TF/fDkx3abXgItSZw0gRU4t+Me2FsUcw9IwlQCuXZ7
n8N9BhoJOJnH6BX4ewGXMSxQYq6ReVYgKfCsB5GozAT5PoHXtm9y8wQ+ng1jeVpE
79bJ2J0N1UqpduWxHfCvK5vIrqICXgboifvgEkltiJPEI0NyH6AEZZLpfsxDsMFm
8IZdL6cByI1XZyuioGeC2jEze+KlidBXI9Prv33Hy9S4L6ebnZOFCqkaEuFq87co
L/iTVW1hyo2waAlTRjP6xXfSZMsIgiPRybGbX8/BVMeApBQw/8/dyspQDbxrPuE5
a7xGvLiWuMwiYsyWq76i3rwPzVvvWA==
=aRnG
-----END PGP SIGNATURE-----

--Apple-Mail=_FA717697-F817-4285-A14A-4231EF57D389--


From xen-devel-bounces@lists.xenproject.org Thu Feb 10 11:16:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 10 Feb 2022 11:16:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269817.463935 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nI7R4-0005X1-2x; Thu, 10 Feb 2022 11:16:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269817.463935; Thu, 10 Feb 2022 11:16:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nI7R3-0005Wu-Vu; Thu, 10 Feb 2022 11:16:25 +0000
Received: by outflank-mailman (input) for mailman id 269817;
 Thu, 10 Feb 2022 11:16:25 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Jhle=SZ=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nI7R3-0005Wo-68
 for xen-devel@lists.xenproject.org; Thu, 10 Feb 2022 11:16:25 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e1495abc-8a62-11ec-8eb8-a37418f5ba1a;
 Thu, 10 Feb 2022 12:16:23 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 0F98D21117;
 Thu, 10 Feb 2022 11:16:23 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B962B13B43;
 Thu, 10 Feb 2022 11:16:22 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 71oQLAb0BGIACAAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 10 Feb 2022 11:16:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e1495abc-8a62-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1644491783; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=vDMRqo0fy2QD6qLWKCmj2A2+bsGQr6Rovexh7Zkq0L8=;
	b=AoXamwc+0lfeLMq+EA5D6MHKTPSgdD0vkSIoDCVlrtumM0BK0LJnd2c8z1u5ejSTs3jPc1
	Yxo1bhBIV8R6wEHrBsV2zZNmZbIsdaVc19xEfmpdGLdsU1G+t+O074rJcFzdIQGX0yARSF
	TgbLz+SK3MAjxgJRgyZBhwIqxpOUQcM=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>
Subject: [PATCH] tools/xenstore: add error indicator to ring page
Date: Thu, 10 Feb 2022 12:16:20 +0100
Message-Id: <20220210111620.5256-1-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

In case Xenstore is detecting a malicious ring page modification (e.g.
an invalid producer or consumer index set by a guest) it will ignore
the connection of that guest in future.

Add a new error field to the ring page indicating that case. Add a new
feature bit in order to signal the presence of that error field.

Move the ignore_connection() function to xenstored_domain.c in order
to be able to access the ring page for setting the error indicator.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 docs/misc/xenstore-ring.txt       | 29 +++++++++++++++++++++
 tools/xenstore/xenstored_core.c   | 43 +++++++------------------------
 tools/xenstore/xenstored_core.h   |  1 -
 tools/xenstore/xenstored_domain.c | 34 +++++++++++++++++++++++-
 tools/xenstore/xenstored_domain.h |  1 +
 xen/include/public/io/xs_wire.h   |  9 +++++++
 6 files changed, 82 insertions(+), 35 deletions(-)

diff --git a/docs/misc/xenstore-ring.txt b/docs/misc/xenstore-ring.txt
index 16b4d0f5ac..ec5b8eb4b9 100644
--- a/docs/misc/xenstore-ring.txt
+++ b/docs/misc/xenstore-ring.txt
@@ -22,6 +22,7 @@ Offset  Length  Description
 2060    4       Output producer offset
 2064    4       Server feature bitmap
 2068    4       Connection state
+2072    4       Connection error indicator
 
 The Input data and Output data are circular buffers. Each buffer is
 associated with a pair of free-running offsets labelled "consumer" and
@@ -66,6 +67,7 @@ The following features are defined:
 Mask    Description
 -----------------------------------------------------------------
 1       Ring reconnection (see the ring reconnection feature below)
+2       Connection error indicator (see connection error feature below)
 
 The "Connection state" field is used to request a ring close and reconnect.
 The "Connection state" field only contains valid data if the server has
@@ -78,6 +80,18 @@ Value   Description
 1       Ring close and reconnect is in progress (see the "ring
         reconnection feature" described below)
 
+The "Connection error indicator" is used to let the server indicate it has
+detected some error that led to deactivation of the connection by the server.
+If the feature has been advertised then the "Connection error indicator" may
+take the following values:
+
+Value   Description
+-----------------------------------------------------------------
+0       No error, connection is valid
+1       Communication problems (event channel not functional)
+2       Inconsistent producer or consumer offset
+3       Protocol violation (client data package too long)
+
 The ring reconnection feature
 =============================
 
@@ -114,3 +128,18 @@ packet boundary.
 
 Note that only the guest may set the Connection state to 1 and only the
 server may set it back to 0.
+
+The connection error feature
+============================
+
+The connection error feature allows the server to signal error conditions
+leading to a stop of the communication with the client. In case such an error
+condition has occurred, the server will set the appropriate error condition in
+the Connection error indicator and will stop communication with the client.
+
+The server will discard any already read or written packets, in-flight
+requests, watches and transactions associated with the connection.
+
+Depending on the error cause it might be possible that a reconnect via the
+ring reconnection feature (if present) can be performed. There is no guarantee
+this will succeed.
diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c
index 91d3adccb1..6e4022e5da 100644
--- a/tools/xenstore/xenstored_core.c
+++ b/tools/xenstore/xenstored_core.c
@@ -1455,35 +1455,6 @@ static struct {
 	[XS_DIRECTORY_PART]    = { "DIRECTORY_PART",    send_directory_part },
 };
 
-/*
- * Keep the connection alive but stop processing any new request or sending
- * reponse. This is to allow sending @releaseDomain watch event at the correct
- * moment and/or to allow the connection to restart (not yet implemented).
- *
- * All watches, transactions, buffers will be freed.
- */
-void ignore_connection(struct connection *conn)
-{
-	struct buffered_data *out, *tmp;
-
-	trace("CONN %p ignored\n", conn);
-
-	conn->is_ignored = true;
-	conn_delete_all_watches(conn);
-	conn_delete_all_transactions(conn);
-
-	list_for_each_entry_safe(out, tmp, &conn->out_list, list) {
-		list_del(&out->list);
-		talloc_free(out);
-	}
-
-	talloc_free(conn->in);
-	conn->in = NULL;
-	/* if this is a socket connection, drop it now */
-	if (conn->fd >= 0)
-		talloc_free(conn);
-}
-
 static const char *sockmsg_string(enum xsd_sockmsg_type type)
 {
 	if ((unsigned int)type < ARRAY_SIZE(wire_funcs) && wire_funcs[type].str)
@@ -1598,6 +1569,7 @@ static void handle_input(struct connection *conn)
 {
 	int bytes;
 	struct buffered_data *in;
+	unsigned int err;
 
 	if (!conn->in) {
 		conn->in = new_buffer(conn);
@@ -1612,8 +1584,10 @@ static void handle_input(struct connection *conn)
 		if (in->used != sizeof(in->hdr)) {
 			bytes = conn->funcs->read(conn, in->hdr.raw + in->used,
 						  sizeof(in->hdr) - in->used);
-			if (bytes < 0)
+			if (bytes < 0) {
+				err = XENSTORE_ERROR_RINGIDX;
 				goto bad_client;
+			}
 			in->used += bytes;
 			if (in->used != sizeof(in->hdr))
 				return;
@@ -1621,6 +1595,7 @@ static void handle_input(struct connection *conn)
 			if (in->hdr.msg.len > XENSTORE_PAYLOAD_MAX) {
 				syslog(LOG_ERR, "Client tried to feed us %i",
 				       in->hdr.msg.len);
+				err = XENSTORE_ERROR_PROTO;
 				goto bad_client;
 			}
 		}
@@ -1638,8 +1613,10 @@ static void handle_input(struct connection *conn)
 
 	bytes = conn->funcs->read(conn, in->buffer + in->used,
 				  in->hdr.msg.len - in->used);
-	if (bytes < 0)
+	if (bytes < 0) {
+		err = XENSTORE_ERROR_RINGIDX;
 		goto bad_client;
+	}
 
 	in->used += bytes;
 	if (in->used != in->hdr.msg.len)
@@ -1649,14 +1626,14 @@ static void handle_input(struct connection *conn)
 	return;
 
 bad_client:
-	ignore_connection(conn);
+	ignore_connection(conn, err);
 }
 
 static void handle_output(struct connection *conn)
 {
 	/* Ignore the connection if an error occured */
 	if (!write_messages(conn))
-		ignore_connection(conn);
+		ignore_connection(conn, XENSTORE_ERROR_RINGIDX);
 }
 
 struct connection *new_connection(const struct interface_funcs *funcs)
diff --git a/tools/xenstore/xenstored_core.h b/tools/xenstore/xenstored_core.h
index 190d2447cd..742812a974 100644
--- a/tools/xenstore/xenstored_core.h
+++ b/tools/xenstore/xenstored_core.h
@@ -206,7 +206,6 @@ struct node *read_node(struct connection *conn, const void *ctx,
 
 struct connection *new_connection(const struct interface_funcs *funcs);
 struct connection *get_connection_by_id(unsigned int conn_id);
-void ignore_connection(struct connection *conn);
 void check_store(void);
 void corrupt(struct connection *conn, const char *fmt, ...);
 
diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c
index d03c7d93a9..ae065fcbee 100644
--- a/tools/xenstore/xenstored_domain.c
+++ b/tools/xenstore/xenstored_domain.c
@@ -427,6 +427,38 @@ static void domain_conn_reset(struct domain *domain)
 	domain->interface->rsp_cons = domain->interface->rsp_prod = 0;
 }
 
+/*
+ * Keep the connection alive but stop processing any new request or sending
+ * reponse. This is to allow sending @releaseDomain watch event at the correct
+ * moment and/or to allow the connection to restart (not yet implemented).
+ *
+ * All watches, transactions, buffers will be freed.
+ */
+void ignore_connection(struct connection *conn, unsigned int err)
+{
+	struct buffered_data *out, *tmp;
+
+	trace("CONN %p ignored, reason %u\n", conn, err);
+
+	if (conn->domain && conn->domain->interface)
+		conn->domain->interface->error = err;
+
+	conn->is_ignored = true;
+	conn_delete_all_watches(conn);
+	conn_delete_all_transactions(conn);
+
+	list_for_each_entry_safe(out, tmp, &conn->out_list, list) {
+		list_del(&out->list);
+		talloc_free(out);
+	}
+
+	talloc_free(conn->in);
+	conn->in = NULL;
+	/* if this is a socket connection, drop it now */
+	if (conn->fd >= 0)
+		talloc_free(conn);
+}
+
 static struct domain *introduce_domain(const void *ctx,
 				       unsigned int domid,
 				       evtchn_port_t port, bool restore)
@@ -1305,7 +1337,7 @@ void read_state_connection(const void *ctx, const void *state)
 		 * dead. So mark it as ignored.
 		 */
 		if (!domain->port || !domain->interface)
-			ignore_connection(conn);
+			ignore_connection(conn, XENSTORE_ERROR_COMM);
 
 		if (sc->spec.ring.tdomid != DOMID_INVALID) {
 			tdomain = find_or_alloc_domain(ctx,
diff --git a/tools/xenstore/xenstored_domain.h b/tools/xenstore/xenstored_domain.h
index 1e929b8f8c..4a37de67a0 100644
--- a/tools/xenstore/xenstored_domain.h
+++ b/tools/xenstore/xenstored_domain.h
@@ -47,6 +47,7 @@ int do_reset_watches(struct connection *conn, struct buffered_data *in);
 void domain_init(int evtfd);
 void dom0_init(void);
 void domain_deinit(void);
+void ignore_connection(struct connection *conn, unsigned int err);
 
 /* Returns the implicit path of a connection (only domains have this) */
 const char *get_implicit_path(const struct connection *conn);
diff --git a/xen/include/public/io/xs_wire.h b/xen/include/public/io/xs_wire.h
index 4dd6632669..953a0050a3 100644
--- a/xen/include/public/io/xs_wire.h
+++ b/xen/include/public/io/xs_wire.h
@@ -124,6 +124,7 @@ struct xenstore_domain_interface {
     XENSTORE_RING_IDX rsp_cons, rsp_prod;
     uint32_t server_features; /* Bitmap of features supported by the server */
     uint32_t connection;
+    uint32_t error;
 };
 
 /* Violating this is very bad.  See docs/misc/xenstore.txt. */
@@ -135,11 +136,19 @@ struct xenstore_domain_interface {
 
 /* The ability to reconnect a ring */
 #define XENSTORE_SERVER_FEATURE_RECONNECTION 1
+/* The presence of the "error" field in the ring page */
+#define XENSTORE_SERVER_FEATURE_ERROR        2
 
 /* Valid values for the connection field */
 #define XENSTORE_CONNECTED 0 /* the steady-state */
 #define XENSTORE_RECONNECT 1 /* guest has initiated a reconnect */
 
+/* Valid values for the error field */
+#define XENSTORE_ERROR_NONE    0 /* No error */
+#define XENSTORE_ERROR_COMM    1 /* Communication problem */
+#define XENSTORE_ERROR_RINGIDX 2 /* Invalid ring index */
+#define XENSTORE_ERROR_PROTO   3 /* Protocol violation (payload too long) */
+
 #endif /* _XS_WIRE_H */
 
 /*
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Thu Feb 10 11:27:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 10 Feb 2022 11:27:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269825.463946 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nI7bG-00072I-0n; Thu, 10 Feb 2022 11:26:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269825.463946; Thu, 10 Feb 2022 11:26:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nI7bF-00071r-Tc; Thu, 10 Feb 2022 11:26:57 +0000
Received: by outflank-mailman (input) for mailman id 269825;
 Thu, 10 Feb 2022 11:26:56 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Jhle=SZ=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nI7bE-00071l-4g
 for xen-devel@lists.xenproject.org; Thu, 10 Feb 2022 11:26:56 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 59bd282a-8a64-11ec-8f75-fffcc8bd4f1a;
 Thu, 10 Feb 2022 12:26:55 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id A9D5621128;
 Thu, 10 Feb 2022 11:26:54 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 71A4513B6A;
 Thu, 10 Feb 2022 11:26:54 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id qJKgGn72BGKYDQAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 10 Feb 2022 11:26:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 59bd282a-8a64-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1644492414; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=jms15zoEbHPC0BQjeoHvItuq/ifuJoTS71Sh7OrlEG0=;
	b=Yha58CSvzPlABX9u4HFJaywX3z+JZDsTaUkw0Tmbu3smcR0GaGVPWlec/GjDtHKUo7xs3U
	Z33IFysHGXu3oGMK+xvDH314/jg+uZ22SYB4TOx847rFjYtnCiyRWhOhrT1MnZzHdcpIwQ
	rZ305fFqbK2nLZ8wak+C6CMguVAPcZw=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>
Subject: [PATCH] docs: add some clarification to xenstore-migration.md
Date: Thu, 10 Feb 2022 12:26:52 +0100
Message-Id: <20220210112652.6237-1-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

The Xenstore migration document is missing the specification that a
node record must be preceded by the record of its parent node in case
of live update.

Add that missing part.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 docs/designs/xenstore-migration.md | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/docs/designs/xenstore-migration.md b/docs/designs/xenstore-migration.md
index 5f1155273e..39e31c984b 100644
--- a/docs/designs/xenstore-migration.md
+++ b/docs/designs/xenstore-migration.md
@@ -316,6 +316,10 @@ a _committed_ node (globally visible in xenstored) or a _pending_ node (created
 or modified by a transaction for which there is also a `TRANSACTION_DATA`
 record previously present).
 
+In the live update case the _committed_ nodes must be in a top-down sequence,
+i.e. the first node needs to be `/`, and each other node in the stream must
+come _after_ its parent node.
+
 
 ```
     0       1       2       3    octet
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Thu Feb 10 12:55:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 10 Feb 2022 12:55:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269835.463956 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nI8yG-0007HL-LA; Thu, 10 Feb 2022 12:54:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269835.463956; Thu, 10 Feb 2022 12:54:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nI8yG-0007HE-IA; Thu, 10 Feb 2022 12:54:48 +0000
Received: by outflank-mailman (input) for mailman id 269835;
 Thu, 10 Feb 2022 12:54:47 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=06a2=SZ=epam.com=prvs=40400e4a88=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nI8yF-0007H8-Gi
 for xen-devel@lists.xenproject.org; Thu, 10 Feb 2022 12:54:47 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9e8d6ee8-8a70-11ec-8eb8-a37418f5ba1a;
 Thu, 10 Feb 2022 13:54:45 +0100 (CET)
Received: from pps.filterd (m0174676.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 21ACi2CY012339;
 Thu, 10 Feb 2022 12:54:40 GMT
Received: from eur03-ve1-obe.outbound.protection.outlook.com
 (mail-ve1eur03lp2054.outbound.protection.outlook.com [104.47.9.54])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e51tnr97t-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Thu, 10 Feb 2022 12:54:40 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by PA4PR03MB7200.eurprd03.prod.outlook.com (2603:10a6:102:100::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Thu, 10 Feb
 2022 12:54:36 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::fc4d:4749:5d1:eb73]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::fc4d:4749:5d1:eb73%4]) with mapi id 15.20.4975.012; Thu, 10 Feb 2022
 12:54:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9e8d6ee8-8a70-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=RgCwno5PLDIVXp5vwERR/x6fiRxNkZZ1/SKD6VZzDSAv9DI8oDsoO6pv3P4Hn8wEVGMDiBTNcLiAhv2W9/WzhaE4TBdNjUZJx5VhqhrS91CQIMeigucKjf+r7uU4/GEkMzv2OkLPev0/gebntVQnym1QpAQVdtGVUNYpXLJNR48V6LGlPcXwSUckDwuB7vop1nqnrGgxzqxaYifK78Gwy2rpOfJEmcun+acLCJoMqlDFvbZf38FiV4+HBeknsSKTkhYN5CaQIW5CfQlVRO5N3e+v8nQHTo5PlzgqK5sQT7+w9M7bVCZVJjlfE6LEFKm4deWVeTDuW4u4RLgrebxzhQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=OF319WDOBOLg7iDQ5tD/virkZ9tfy3+tlKy89nAktm0=;
 b=Xhbj+VCMCnwNJBId50idA53olbj+20gf6rxmx/DKLu92GwBp3+xqCJd5JyPXIV6sOxWD6Cbu0q8/w8sPVT2wyzCHyt5zb3xZ8xybO2+TPeLSPrx5OsaK1dYplsY/pZh57OClcsAt0RtX9z6hUYG8WmbMNWTcFj3hzq7a7IZ6CHcsNC1o84dOXnQgpgUpv8B1sIuHSvzderlgT16+PyphxeActQTqLe85KSc2xaNpJ67Fn+snsA/aN7ywje3p3MBD7jvnPbMLCGs6itJbGV2BQ/JdACA57nz2wIAHcgkNT7Mde0FP5N/Vz5vSL5ait7Dml/YTfKF9UEd546l0VJ7u0Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=OF319WDOBOLg7iDQ5tD/virkZ9tfy3+tlKy89nAktm0=;
 b=llI/2L8BKCqsgir6ShRWGtzWo8/txyr5s5/tcBf/PRY9G6SiwybrYBWdQBdClQkdD4H7RhzU511NtYC3npNCM8KhhRKq5I89/ovlN2bZ73TKfQe3vyWxYCIu43x3OnXP9bwvnt0n75/pBl0Y07L7mSKZ6hEEZxnD17HcKW1aQuH+GSNq3wWcSm98X1dd6tRmYmSoUQp2D1E0p/wBWq4kMMB6fq1NsknBIfuCxi9u4328gH9AJvk+YXfUO/Uhc3KJOqHLIdGZxAgP1BciuXKingnIWHh2FK2lquyJrrTI0BH9EFWiQ/+u9s0UBgnuTMiI6y17z4YPv6olttStTslJYg==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "roger.pau@citrix.com" <roger.pau@citrix.com>,
        "andrew.cooper3@citrix.com"
	<andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com"
	<george.dunlap@citrix.com>,
        "paul@xen.org" <paul@xen.org>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>,
        Rahul Singh <rahul.singh@arm.com>,
        "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        Oleksandr
 Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v6 10/13] vpci/header: reset the command register when
 adding devices
Thread-Topic: [PATCH v6 10/13] vpci/header: reset the command register when
 adding devices
Thread-Index: 
 AQHYGZFg3nazYSvfA0G+yHTbxcxX2ayDdFgAgAAB6wCABD+NgIAAQmgAgAAT4YCAAAOjAIAAAPCAgAAXGICAAAPHAIAEnAeA
Date: Thu, 10 Feb 2022 12:54:35 +0000
Message-ID: <22084dc5-ba16-3e63-8be6-a8c5c79c9cb0@epam.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-11-andr2000@gmail.com>
 <96381d7e-dafc-acee-3abf-f9815deb207c@suse.com>
 <ef76faac-f9d3-1cb8-06b5-189ccd299542@epam.com>
 <6f0a015b-c48f-76ed-9a51-39c045ff5927@suse.com>
 <2ad372d4-a181-9307-ef50-a5adb61dae66@epam.com>
 <49380584-0577-96f2-ef1c-a96eabf0d227@suse.com>
 <fbd410d1-84ad-2309-ca05-b9ac7f95f1f9@epam.com>
 <dbef1c95-818c-427c-1963-75d584843cff@suse.com>
 <f34cc940-7f5f-aebd-60d9-d1a3d85d1283@epam.com>
 <8f35e7c5-3193-4b10-ae25-df838e2262c7@suse.com>
In-Reply-To: <8f35e7c5-3193-4b10-ae25-df838e2262c7@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 1d086633-1856-4c37-b049-08d9ec947de5
x-ms-traffictypediagnostic: PA4PR03MB7200:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <PA4PR03MB720029303B1E8C73A97CD05AE72F9@PA4PR03MB7200.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:7219;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 qb5Tyiy5GZb8pt5we25sh54W1qNLROs1a3kiBtsqZ5trtd7yPPDIGEVcuO3SrX/WX3FGeLWvCWcw/U45yYDRPBadyHk0DVykl7OijtAwtri+NdlbpnfNWfQG/HbeVeGBTl6P//xOMb20i/9ftbVZ1++qMZgY2cF3QGe6jTllLbAr9BuSvAwo0oC5bf3lyjFQLsHmMTWrRofkJeeZrWoL2NRGmKXmg5nnOSesqpVfqtZTSurF4y8foSR32PbX+XVk3UCeDWLC1lfsBJ9tYz12K25FhfxHRUv3mZIEAhxrtp03Y8TcrLf41mz43ecKBUp3/KYm02WH1XmDa/s7GhKfMrvkDeEq5eiUD1VTZnuzeh4uyRqMlsjU1bf1GjQJiELqp1kfTuY1dPkGe9RBfHmDBPTrGsO1P39lY4fpwundGy5Au/hNdi232YMe6QItUl0pAL2gtQVrQLNkcl4J3iVXIyHqCQCOISijCaOw18/1bqCGxbL5k4wM8+n6z72NAeLinAq9PYqmLGLaL7oVFswdPW5nhgnQWzoH5mtzTSQ1lG/5JVwUmUy5Vbc1vRE7H5OP8wxenffA8RamddHCGM/4vpYMPkzP08d70Py43eiad/WPP5fo7SysYR889nOVZb+BmJKAND5ldQhusERCw+cNDX+vsr++g2aw7im3iSIUcyg6MLT9Qn08Pd8MVq/7vBuBe7bz+6Yqom2rWMTt5JxX/FUlrpiRq00/y+ZEwlfY8CnUsIUXWIjCa3fLwa9duM7h
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(508600001)(76116006)(54906003)(107886003)(53546011)(6506007)(66946007)(316002)(2616005)(6916009)(38070700005)(4744005)(71200400001)(8676002)(31696002)(86362001)(64756008)(91956017)(66476007)(66556008)(66446008)(6512007)(8936002)(186003)(5660300002)(38100700002)(26005)(36756003)(31686004)(122000001)(4326008)(6486002)(7416002)(2906002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?MnhHcC9HQ081YVJ0aXdWL1NuNFF2ZDJrR1IvaUdlbGdoQ1hKUjY3dVJHK01Q?=
 =?utf-8?B?cFJWUld4T3pBTUN4YTVtZ2tteTVNaEo3bHcxWGFkNS91MUIrTUxXN1RPeThD?=
 =?utf-8?B?NFZYLzloM21yVDZHMzA3d1FuNjVvdG4wNjE3bGphNTdaaFpOVHoxY3lRME0w?=
 =?utf-8?B?U0dqT0dEejRwYWV2WTdzSHBSUkZEUXg2N2czSjBGWXB6YllISUMwOGpqN1Br?=
 =?utf-8?B?UUJHbmxZb2Era0oxb0E2N2dqZlcwM1J6dlpiRFY2RmJzZUwwek1GcnIvOWFZ?=
 =?utf-8?B?bGdNVWVxQWdnUTlwVER6UmJlMkZqZFRLWkRkcUFSd1EwNlBBaHlKU1g0S3RV?=
 =?utf-8?B?eDR5WnV5K3Zad1VaZ0xBRndpZVFvU2xsWndPVHBoTlNLeEQxUkI2bFdJOHdl?=
 =?utf-8?B?cmV4OVNuU2d1d2lHeXN5WGVFdUZtVURLTmpxeDZjdTc2VU5RdEFnK2JoaWYy?=
 =?utf-8?B?Ukg4YWhJK1l2ZjZWdmU3b3puU2QvWjhVSW5qSS9jdWRpRnpid09Vamh6WkNE?=
 =?utf-8?B?eCtXVzU3WmJ0NFhkVTZMM0xuYjFlci9yV2Q4b2dYUjlwMWd3R2pHcUpUMDEz?=
 =?utf-8?B?cG5qRHR2OXgzZTZ3Y0paczJmcGdha2VBT1pBbElFSDRIeWxPNGp3eU5JVkxG?=
 =?utf-8?B?VTcyb09CTUdISXU1WGc0Y1Irc0pTTWtxemJnalhzY0h5bmFMWW5HUmdUaFRl?=
 =?utf-8?B?MzByNHJwUUZ3UDhhL0VkUW9qL3JuWWoyc1VFWnpobm1aeTJoSWsyTGh6MG00?=
 =?utf-8?B?b0tFbE11VlV5WDRid3JsK0NrYkpPRExYSk84Z0N2TnhNVUdvQ0hrZ1BadTNx?=
 =?utf-8?B?ZUY5bXpySFpXMVRzU094Y2R3cURhVXBJK1dWNHhXMEpaVFdtWHliQjhEU2dz?=
 =?utf-8?B?TVcwYmxiak9oMkdWVWRBT25BNUw4YlVzTnNUVEliUWloVk1aLzBPd1FqVXlD?=
 =?utf-8?B?VFpLQUt1MWFtT3BTMzBXcVpuNmw4cUEzcngrOVlyQnpRZ2F6ZWlaY2dEYzU1?=
 =?utf-8?B?OXBFN2RlYkJlajcvT2tlK2N6RjFJbE5PT2RrMDBDNjFoUk5lMXBTSW1OMEF1?=
 =?utf-8?B?cGNZdmJlbmFoMU14R1RxRXBqL2pYUjVRMzhxTnpRRWxZWEoyaXhNTDFqQWFM?=
 =?utf-8?B?amdTZzJoNFpHRnZlRmY0bkhxOXN6NEkyanIrTVprMDNDY0t4NnRnYWJQNGFP?=
 =?utf-8?B?d2RvYVI2THc3VkM2Q0swc1MrOFB3UUlieWdCbWVMSDFKTk9JRFgxVXJRZEp4?=
 =?utf-8?B?TmxFaTR6RTBCL1hzc2tjeFhXOTgwTjQwWk5tdzJLblJ0N3RmK1liLzY4R3RW?=
 =?utf-8?B?eVpTb3YyQ3I4eWhSWWo0bDZWMndkaHlKZlRxZGtxMGcwRndjVzM5Q2dzL3Yz?=
 =?utf-8?B?NVpaZ3ZXU1VDWlRiVlVNekpxekhGOWtpZU5McDl5dTQyNDFCUG5XMzB3MnNt?=
 =?utf-8?B?RFdJZ21kaWRXUlBSTWh0RitJcU5nWEpCSnUya2pMK09xNjdWWmp3bWwyQnNj?=
 =?utf-8?B?aGh1RFBGbXh4MmVHbkYzamFJR1ZMRzBuWjdXd1ZibXE3WTl6UHk3YlphaHkw?=
 =?utf-8?B?UEU3ajlNRGpWTkVEV2xyeGRNNGJIdTR0OURUeHVnZ3BLYThzbkxhVkUvcXpX?=
 =?utf-8?B?NXpsRzI2T0lHajV0S1QzZWNJU01pdUlzSkhlQU5kWHllaDlGbGIxcHpIZWpE?=
 =?utf-8?B?NTBPOUxRRDBUbi91SlptaUNOajEvMmpGM1J0UGVLeE9uNE9rTm92QWN5aUdr?=
 =?utf-8?B?ZlJxMy9oRmV1SzF3WlVXMHhZbFhoeFN6c0d3Nm5RVUhRR1E2OWNhT2RwSWFO?=
 =?utf-8?B?dHY0LzBDQnlqaWYvNC9SK0dyWXV5SHBBaTZnZm11UmhoTVh3bWxSSHE0OTh3?=
 =?utf-8?B?enIxRDg4WFBLUitMNDV3NVNNV01hNmkrc1I1T3BEVTYzVURaRGRDNXg0RTFK?=
 =?utf-8?B?VnNLL015WWNwU2pQZkMwaG0yUzVvWi9IUHFQdlEweGI5VkNlWGI1MmhDM0Iv?=
 =?utf-8?B?WnRHSVdKbEdTN2MvN2Y0dlJqMmV1bHorMktGdWlRSno3NGEyUGZYVUtGT2My?=
 =?utf-8?B?M01BY0hLT3dwRzZYRDBnRXpaMitmTFlOTjJ1UWI1eHI2TGtWK0ZvSFFKbVRm?=
 =?utf-8?B?dkpsYlkzMVp5dmNERzloaFhJYlRJMjJuZFRNcmJTTk5YTmZ1VjluanFxblhz?=
 =?utf-8?B?WUwxN3JjdzZMNmNGSHhlem9ydk1HZWdtRHZsZnNJRjJTMmlwQkxqV2JVVHlw?=
 =?utf-8?B?SUNsYW03OXEzeHlmaEZaRFgzeXZXV0dZTEQ2UzBFMFlGRTRHcFRMa3JZeUFj?=
 =?utf-8?B?aWdvb2hJRkFHbTFzMGNlaG1uTE5OVEcyZDE4aTkzcGlxdm1RQzdyZz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <909259C3ACAF6748B0E79071BA3A4C40@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1d086633-1856-4c37-b049-08d9ec947de5
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Feb 2022 12:54:36.0218
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 80jbWvdRpJ1wkO2jhmBw7rbDymr7V2DxdxVAaZnXY4E4QC6gn1nFCBVusoJRYK0KM5Ca6Y7DKJ3i+z4mhVad36IWqp+eK6I/eEhjL8biYNDFrnChroVFU9nvUvH0WdmO
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR03MB7200
X-Proofpoint-ORIG-GUID: 23GV0yyQDUxt1CTz6I2LNiJQOnBnDxQh
X-Proofpoint-GUID: 23GV0yyQDUxt1CTz6I2LNiJQOnBnDxQh
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-10_05,2022-02-09_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=846
 malwarescore=0 phishscore=0 clxscore=1015 impostorscore=0
 lowpriorityscore=0 bulkscore=0 adultscore=0 suspectscore=0
 priorityscore=1501 spamscore=0 mlxscore=0 classifier=spam adjust=0
 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2202100070

DQoNCk9uIDA3LjAyLjIyIDE2OjMxLCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMDcuMDIuMjAy
MiAxNToxNywgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+IEJ1dDogV2hhdCdzIHN0
aWxsIG1pc3NpbmcgaGVyZSB0aGVuIGlzIHRoZSBzZXBhcmF0aW9uIG9mIGd1ZXN0IGFuZCBob3N0
DQo+IHZpZXdzLiBXaGVuIHdlIHNldCBJTlR4IGJlaGluZCB0aGUgZ3Vlc3QncyBiYWNrLCBpdCBz
aG91bGRuJ3Qgb2JzZXJ2ZSB0aGUNCj4gYml0IHNldC4gT3IgaXMgdGhpcyBtZWFudCB0byBiZSBh
bm90aGVyIChiaWcpIFRPRE8/DQpXaHkgbm90PyBUaGlzIHNlZW1zIHRvIGJlIHdoZW4gYSBndWVz
dCB0cmllcyB0byBib3RoIGVuYWJsZSBNU0kvTVNJLVgNCmFuZCBJTlR4IHdoaWNoIGlzIGEgd3Jv
bmcgY29tYmluYXRpb24uIExldCdzIHByZXRlbmQgdG8gYmUgYSByZWFsbHkNCnNtYXJ0IFBDSSBk
ZXZpY2Ugd2hpY2ggcGFydGlhbGx5IHJlamVjdHMgc3VjaCBQQ0lfQ09NTUFORCB3cml0ZSwNCnNv
IGd1ZXN0IHN0aWxsIHNlZXMgdGhlIHJlZ2lzdGVyIGNvbnNpc3RlbnQgd3J0IElOVHggYml0LiBO
YW1lbHkgaXQgcmVtYWlucw0Kc2V0Lg0KPg0KPiBKYW4NCj4NCj4NCg==


From xen-devel-bounces@lists.xenproject.org Thu Feb 10 12:59:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 10 Feb 2022 12:59:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269843.463968 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nI93C-0007wT-8x; Thu, 10 Feb 2022 12:59:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269843.463968; Thu, 10 Feb 2022 12:59:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nI93C-0007wM-5e; Thu, 10 Feb 2022 12:59:54 +0000
Received: by outflank-mailman (input) for mailman id 269843;
 Thu, 10 Feb 2022 12:59:53 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=06a2=SZ=epam.com=prvs=40400e4a88=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nI93B-0007wE-6H
 for xen-devel@lists.xenproject.org; Thu, 10 Feb 2022 12:59:53 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 551319e7-8a71-11ec-8eb8-a37418f5ba1a;
 Thu, 10 Feb 2022 13:59:51 +0100 (CET)
Received: from pps.filterd (m0174676.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 21ACxSGN021845;
 Thu, 10 Feb 2022 12:59:48 GMT
Received: from eur03-am5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2055.outbound.protection.outlook.com [104.47.8.55])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e51tnr9fx-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Thu, 10 Feb 2022 12:59:47 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM6PR03MB3718.eurprd03.prod.outlook.com (2603:10a6:209:30::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4909.13; Thu, 10 Feb
 2022 12:59:44 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::fc4d:4749:5d1:eb73]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::fc4d:4749:5d1:eb73%4]) with mapi id 15.20.4975.012; Thu, 10 Feb 2022
 12:59:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 551319e7-8a71-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=CZtWKUS//MwzmvIqmRxkIHShBvOehNNfjG4rzF0EWgCrdeow7wzPEG5S5NESj4fk1xkjTigDysxu4UNNkaFDCsdULBZ7DyNBvm5D3a/e0SNScS00/X5in2cR60HjWYqMfX4Z9oi5JB48uFmxf6LN4VUMTynIZRJWH1NKpGUcQMzLVKm4naDbuWrouwexxrUqy8GSAnTFd6DHg9IxpKgJpbmaUlzfzIWlyo833vKy4GIRMNoeGe3/D2A0gGq80oHFHwaNq1FIKR1OlkKN9vEqNqZzodKJEgsdp8+xuwSqTzgfnSN2FQ3/QwC+B/QSec4KT7o5dID/rWWrfA/iUYyDvA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=swY1Ix3iZMo5/0ZSEOQp8FRaPBVH//4V5vHtgReeJk4=;
 b=ChhBohv80v9FpgIjbxa7FTUgVThega7yVnUfg1c6HCOsndZHeSuHYDZeSH3cXZPvWPA1tFDCs1VnLO84VIZxokFzAx9KSZbopMgx7QXzz+/HPJ2tLeUKOa24EpSrtSY/EZCgnDPEODdblidFsDw78HZp9QiXBz6owba2HOT2RDs8jii5fQzB5zWrBL5BiGjwZ26bo7BNeM/Z0idQMR/flr/fzl3D0KAWyh1jeZNWplksI4P0of5qaGU3Uq9+QerQvvUKA3+W1S8BSOD/vcha5DNI/KFG6PGQxckWPn7vgQZnMKAOCfse3OWEcYgCrvBaUArITFEx7Ky9TYvFK/tOYg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=swY1Ix3iZMo5/0ZSEOQp8FRaPBVH//4V5vHtgReeJk4=;
 b=PVPZC6Qvdkdk2Kp3IGAJu1AOcew0Or7IkqoG7VGlXeljEhJTntXy1RG3Rk0mcsfimZKqOJ551b8IcPINeI/b9VR4h0TOwgsx7fqpFzPcBBTZFmc3MTV7xIXahoy5SPhxU1g0JsWkJn1AbwI7UxR8IalyUxnpfeBu7z6+SVSndGRQpBv9jBgQH7t4rLgSfdIAleXM8+HdqTJAsj07lL56bpFhZ3UYWBzfjfruWLW0rxAZKj/nISIcY0by6cnHrjl9PwIgLr4rfvzXkC+9dVXN4DCOrkSY9ivi3qq/qwfwLtg7mAICETZGk5k3ClZPLmj+gLjSOAnQDjBH6CdEjl0/1Q==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "roger.pau@citrix.com" <roger.pau@citrix.com>,
        "andrew.cooper3@citrix.com"
	<andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com"
	<george.dunlap@citrix.com>,
        "paul@xen.org" <paul@xen.org>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>,
        Rahul Singh <rahul.singh@arm.com>,
        "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        Oleksandr
 Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v6 10/13] vpci/header: reset the command register when
 adding devices
Thread-Topic: [PATCH v6 10/13] vpci/header: reset the command register when
 adding devices
Thread-Index: 
 AQHYGZFg3nazYSvfA0G+yHTbxcxX2ayDdFgAgAAB6wCABD+NgIAAQmgAgAAT4YCAAAOjAIAAAPCAgAAXGICAAAPHAIAEnXaA
Date: Thu, 10 Feb 2022 12:59:44 +0000
Message-ID: <6b88e547-5e8c-1f03-1ca7-ac364fb9bb46@epam.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-11-andr2000@gmail.com>
 <96381d7e-dafc-acee-3abf-f9815deb207c@suse.com>
 <ef76faac-f9d3-1cb8-06b5-189ccd299542@epam.com>
 <6f0a015b-c48f-76ed-9a51-39c045ff5927@suse.com>
 <2ad372d4-a181-9307-ef50-a5adb61dae66@epam.com>
 <49380584-0577-96f2-ef1c-a96eabf0d227@suse.com>
 <fbd410d1-84ad-2309-ca05-b9ac7f95f1f9@epam.com>
 <dbef1c95-818c-427c-1963-75d584843cff@suse.com>
 <f34cc940-7f5f-aebd-60d9-d1a3d85d1283@epam.com>
 <8f35e7c5-3193-4b10-ae25-df838e2262c7@suse.com>
In-Reply-To: <8f35e7c5-3193-4b10-ae25-df838e2262c7@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 8a31ed90-af07-4e07-c080-08d9ec9535b5
x-ms-traffictypediagnostic: AM6PR03MB3718:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM6PR03MB37186DED3EF763E79B2F8374E72F9@AM6PR03MB3718.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:7691;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 BRtTlKN0+nD5I4XlBqM3rb7QlspIe6yz9ARdNuc1TV+fjBjcsk69nD7mHxqVg+78ot0ubibIwKgIZdKHnPw8wvSjaf76Vj4tXbd5R/X5U+mP0B7S7V1nANL73kKpS8GUHtcqTsqrFvr+JM76yX43wF4B4ugcQF9/Y6CclZo/ZKsdHnjvQRadBGRCJRAKdZy2Sn7kF+bjORKEhISGDiYFUj8lIMfHT3rNsSY6+Ziymomb/3YC8tfZAP5bcEfM6exG7vEC0JTKw/KKeBXFYG0cthIIQnigefZibmtXjfBNINUnfS3ClEpVqYWbPU1jDK9JniF5G07eKeHLJwZeRdQeU9Vzk+IG5DnRmMVk0gwCRIZXqhzil8p+9lHNgbHd3LXXqPR/VgjWnbMQp2wyUK1LB/6xzu7sGmNOWQzW4UNuRgvOsnteZGyUsVYuJ8GueAxRZVfokd2KyFqzAWAmVOh7qw7O5smPO/m3SpLFEoabddypB4ogkBCq4eaaPADSe7x7RAx8zSpXRnR750rFWpG7MPow34Iz3jKTD1MuDgnRCmCA+/bvFWvudjePJKJT4YqvxKe8WsNO6c52zlMqLl9iYMOQV3WRZnFpkOrygP+7eim82fi928M7DhiIUMCvDpl6YDCv1i4d8ZkGWcR0wNaM4kTZeHPrjrFSi/Zd37oBvYRNETRFW5cRTHVo1d02oX/KRz6b5bR62JRydNBxx5ywc/SIyiipXVDTslu5/CJSaKTy1bOlzFCwU8BAmFkAMh7+
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(86362001)(31686004)(186003)(66556008)(508600001)(64756008)(2616005)(83380400001)(8676002)(6486002)(2906002)(26005)(4326008)(36756003)(53546011)(122000001)(6916009)(5660300002)(76116006)(54906003)(66946007)(316002)(31696002)(38070700005)(66476007)(6512007)(91956017)(66446008)(7416002)(71200400001)(6506007)(107886003)(8936002)(38100700002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?NTZDK0tiREZhOUhOWllTUkNmbmk2bFVqai94TXF4RUhyWkxUZ3VYRjBqTEky?=
 =?utf-8?B?enRiSFJyUldXSE00cm1jYVVYQ0psakNGVFloTDBacGJlRGdCeUpqUlBpWnV3?=
 =?utf-8?B?WjlzNUZyNzFKRCtOTFI2YmNNSDJLUW1KMnpNRjdWai9nSHQvTXBwOHBkRUls?=
 =?utf-8?B?TzlRbXdwRWM4STNpSHhjMzdsMmZyUGRYTlFqa3ljVDR1cy84dFhrcndrYkZB?=
 =?utf-8?B?eWdQdjdnOFFWWHVIUTJLSmZHK1MrSWRralhtVTYrVlRLZXMxZjBjVHF0U29t?=
 =?utf-8?B?anZlNEtXRG1LbkkyMXBoT2ZmcVlKalFNRUNVWExVWkRqUWIzTDNkbFhWLzE1?=
 =?utf-8?B?VGdXM0YxbVpaWUVnb2ZGVDR0dGRVMElQekVqa2dhL1pIMzk1djcra0d3bHN6?=
 =?utf-8?B?dnRsdm9UOGw2L3B2UENnbTllclRjTmNaZCtpTDV3SkxlYlVLWE9tOVl2STR2?=
 =?utf-8?B?UVE1ZTY2SGQvQWJFVDI1SURsSjJqNTc4WUM3cHp5UXNKWjRwTUZNV3Z3RDlE?=
 =?utf-8?B?WVFXMUZNU0NORFdaYmYzSGp1ZUc1czFiMGxoZFlDcVphdHNTNXltSEtFWUxC?=
 =?utf-8?B?cVVDOFlreUZuSHNBRVl2L2F4RlhLL3ArK0JOdjg4cnkxUTRpSkhBQ1V1Nkll?=
 =?utf-8?B?eVYvbU5vTkF4NUVnMHlkYmpXYkowRU1jVWVzdVV1OWdEZHF4UzV4QThpVlcx?=
 =?utf-8?B?K2xNbzVDT2txUVBMZ3BuZHB1eDFjYitUMXQ1NzFxR2lZRXRQMXN2TUx2dkRo?=
 =?utf-8?B?S0Y2RUtHbnUzdC9lSDJ2RWpsbXdLckttVFdPUkJBU2JkZWMzTFdGNmQzMm90?=
 =?utf-8?B?VVBpTDgrekFoRmtxV0tQcDlzWGJoaEJ5MjVxaFlVVFZoSW9iOVoxb1h2NHBF?=
 =?utf-8?B?TmVkTDcyRlo2b2w2U1MwandGTWRRa1pTT1RJTzdSVHJLeXRTR3JGZ3pDbWN5?=
 =?utf-8?B?NEoxL1F1WFV5bm9vMFVFdDd2OVVzNnlzTGdJRVlSVHZrT0twaFduL2doMjBX?=
 =?utf-8?B?WS9kblFQWUZKbDhnZ21Ga3EyRVVjMG0xR01VcEZscW0xL2tWa2xKVVZmcFA2?=
 =?utf-8?B?cVZ0TTduYU5EWUhLd050dnJkcUF1ZG5kOWNxQ3J2MjlQOEtmUDQzVjM4Rld5?=
 =?utf-8?B?Q3lPeDNRT2Znc2RmdXRVSGFOM3l4NnRpeitqN2pLb1FWeFhOdkxQUDh2L29r?=
 =?utf-8?B?YSsxK0xMeDdnNDJLZGw3UHlJdnQwVUxjazRrWGxJVGEvOWtDVyt4UlZaREpJ?=
 =?utf-8?B?ZWg0OHJpdGRBcHMraWtucnI4MVlmQkM3NzBTZVRlelBBVHZBTmd4SW82WE5R?=
 =?utf-8?B?WXJ6OS9uM0Y3d1BZOWlwekNac0pnbnRVbExjMGNlcngrMXJWQ2pCdWRuRWdU?=
 =?utf-8?B?K05aS1pPaWN0QzFkckVmQ3Blb1lSOFhGNVIvZkVYbmhiYnNhUHAwb09nTzBq?=
 =?utf-8?B?YjBCRHEzZGRJcjZVamZuLy9XSW82VlhrREgwZVphNzFWQ2JCL2FweUphVXQ4?=
 =?utf-8?B?VlhLNnlRYkN4dFQyTU9hMVdwRjM4MU0ydXJLRnR3TU9uTjNnQWFlVmZYUGhF?=
 =?utf-8?B?YlNIU3dvL0Q4RGZUeVJyMzNRQUsrc1V3R3lIZTNwT21Oc1BPMmtTbW8vdWhF?=
 =?utf-8?B?TnBWUXhjTnZVSTA2bCsrdGRLcGxwc1ZackdJSVBNLzNlZXoxU21wMnRoME5U?=
 =?utf-8?B?d1ljTk13WjhMazh6c1lJUW02VFRJNFMzOXFidGFBT0lWY1Y0Q1JIZUZCU2Ez?=
 =?utf-8?B?bm1GMytseDE2bURXQkxSYXNRTXgyQzJqbVhHTm1NOVZSQ3IwSnJOaUNsUGRD?=
 =?utf-8?B?Tzgwa3dZVm05Skp3Yk5NL2FYV2dYZTEvWWRJUHdhMUc1THk0UWJ3MUVleVFU?=
 =?utf-8?B?eDgvOVpBRUs2L1o2aDFGMmFUbXViRVdWMithbWY4TTN5TmtKcWhrRXpiamc4?=
 =?utf-8?B?U0pWdHExMmtCVFRCWjhOOFhEMm8wZWh5ZVFOSlBuRVFyRnp6cU9ZSGYxeU1z?=
 =?utf-8?B?d254VWg4aGwzREw1bW16VkxMVFBwZDBjWHpPcGl4R3FWU1ovZmY5NTl2R0R3?=
 =?utf-8?B?VGpWWEhad0EvRDZSVVJKbm5rNDJaV3dobGprVmhGLzJQUG4rNU5uTkxZRUJD?=
 =?utf-8?B?NXhEdEJZUnF5aHBnNGpRYjAwV0RWcXpIbDd0R3Z5dW5Rb001Mi9UM21tSW9J?=
 =?utf-8?B?Y2plZlo4VitKbjkweXc4VEFQMXFMbHFXRWhjejBvY25oVlQ1QVV2NFAvaXFl?=
 =?utf-8?B?bEtuMCtMcjNKMDNQQjBlWWlOZXdpUVE4RXI5YTF0MDhwLzRDRHV6akk3UzMw?=
 =?utf-8?B?by9GTXBBQmZyZmtqdlFSU2ViZVJHaFN0MUNjbHdpaUV1Njdzb0pHdz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <A79802229F4A454AB4B47016682667FE@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8a31ed90-af07-4e07-c080-08d9ec9535b5
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Feb 2022 12:59:44.4553
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: qjuLyjrjoUU1LrQ3ZYt9zYxAxerHpnCbvgZP72R2riHFn4mryP8zxWqy1NGbcUpFU1R4MZfhiESl/b9BAixeX7Eo1ekjm+9gwB575Oa80i/BGv/VNz5k3lHgJCXtKVOC
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR03MB3718
X-Proofpoint-ORIG-GUID: LZfsspuWv2q9TfYkUCj44JcAv2yTFx3K
X-Proofpoint-GUID: LZfsspuWv2q9TfYkUCj44JcAv2yTFx3K
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-10_05,2022-02-09_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999
 malwarescore=0 phishscore=0 clxscore=1015 impostorscore=0
 lowpriorityscore=0 bulkscore=0 adultscore=0 suspectscore=0
 priorityscore=1501 spamscore=0 mlxscore=0 classifier=spam adjust=0
 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2202100071

DQoNCk9uIDA3LjAyLjIyIDE2OjMxLCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMDcuMDIuMjAy
MiAxNToxNywgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+Pg0KPj4gT24gMDcuMDIu
MjIgMTQ6NTQsIEphbiBCZXVsaWNoIHdyb3RlOg0KPj4+IE9uIDA3LjAyLjIwMjIgMTM6NTEsIE9s
ZWtzYW5kciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4+PiBPbiAwNy4wMi4yMiAxNDozOCwgSmFu
IEJldWxpY2ggd3JvdGU6DQo+Pj4+PiBPbiAwNy4wMi4yMDIyIDEyOjI3LCBPbGVrc2FuZHIgQW5k
cnVzaGNoZW5rbyB3cm90ZToNCj4+Pj4+PiBPbiAwNy4wMi4yMiAwOToyOSwgSmFuIEJldWxpY2gg
d3JvdGU6DQo+Pj4+Pj4+IE9uIDA0LjAyLjIwMjIgMTU6MzcsIE9sZWtzYW5kciBBbmRydXNoY2hl
bmtvIHdyb3RlOg0KPj4+Pj4+Pj4gT24gMDQuMDIuMjIgMTY6MzAsIEphbiBCZXVsaWNoIHdyb3Rl
Og0KPj4+Pj4+Pj4+IE9uIDA0LjAyLjIwMjIgMDc6MzQsIE9sZWtzYW5kciBBbmRydXNoY2hlbmtv
IHdyb3RlOg0KPj4+Pj4+Pj4+PiBSZXNldCB0aGUgY29tbWFuZCByZWdpc3RlciB3aGVuIGFzc2ln
bmluZyBhIFBDSSBkZXZpY2UgdG8gYSBndWVzdDoNCj4+Pj4+Pj4+Pj4gYWNjb3JkaW5nIHRvIHRo
ZSBQQ0kgc3BlYyB0aGUgUENJX0NPTU1BTkQgcmVnaXN0ZXIgaXMgdHlwaWNhbGx5IGFsbCAwJ3MN
Cj4+Pj4+Pj4+Pj4gYWZ0ZXIgcmVzZXQuDQo+Pj4+Pj4+Pj4gSXQncyBub3QgZW50aXJlbHkgY2xl
YXIgdG8gbWUgd2hldGhlciBzZXR0aW5nIHRoZSBoYXJkd2FyZSByZWdpc3RlciB0bw0KPj4+Pj4+
Pj4+IHplcm8gaXMgb2theS4gV2hhdCB3YW50cyB0byBiZSB6ZXJvIGlzIHRoZSB2YWx1ZSB0aGUg
Z3Vlc3Qgb2JzZXJ2ZXMNCj4+Pj4+Pj4+PiBpbml0aWFsbHkuDQo+Pj4+Pj4+PiAidGhlIFBDSSBz
cGVjIHNheXMgdGhlIFBDSV9DT01NQU5EIHJlZ2lzdGVyIGlzIHR5cGljYWxseSBhbGwgMCdzIGFm
dGVyIHJlc2V0LiINCj4+Pj4+Pj4+IFdoeSB3b3VsZG4ndCBpdCBiZSBvaz8gV2hhdCBpcyB0aGUg
ZXhhY3QgY29uY2VybiBoZXJlPw0KPj4+Pj4+PiBUaGUgY29uY2VybiBpcyAtIGFzIHZvaWNlZCBp
cyBzaW1pbGFyIHdheXMgYmVmb3JlLCBwZXJoYXBzIGluIG90aGVyDQo+Pj4+Pj4+IGNvbnRleHRz
IC0gdGhhdCB5b3UgbmVlZCB0byBjb25zaWRlciBiaXQtYnktYml0IHdoZXRoZXIgb3ZlcndyaXRp
bmcNCj4+Pj4+Pj4gd2l0aCAwIHdoYXQgaXMgY3VycmVudGx5IHRoZXJlIGlzIG9rYXkuIFhlbiBh
bmQvb3IgRG9tMCBtYXkgaGF2ZSBwdXQNCj4+Pj4+Pj4gdmFsdWVzIHRoZXJlIHdoaWNoIHRoZXkg
ZXhwZWN0IHRvIHJlbWFpbiB1bmFsdGVyZWQuIEkgZ3Vlc3MNCj4+Pj4+Pj4gUENJX0NPTU1BTkRf
U0VSUiBpcyBhIGdvb2QgZXhhbXBsZTogV2hpbGUgdGhlIGd1ZXN0J3MgdmlldyBvZiB0aGlzDQo+
Pj4+Pj4+IHdpbGwgd2FudCB0byBiZSB6ZXJvIGluaXRpYWxseSwgdGhlIGhvc3QgaGF2aW5nIHNl
dCBpdCB0byAxIG1heSBub3QNCj4+Pj4+Pj4gZWFzaWx5IGJlIG92ZXJ3cml0dGVuIHdpdGggMCwg
b3IgZWxzZSB5b3UnZCBlZmZlY3RpdmVseSBpbXBseSBnaXZpbmcNCj4+Pj4+Pj4gdGhlIGd1ZXN0
IGNvbnRyb2wgb2YgdGhlIGJpdC4NCj4+Pj4+PiBXZSBoYXZlIGFscmVhZHkgZGlzY3Vzc2VkIGlu
IGdyZWF0IGRldGFpbCBQQ0lfQ09NTUFORCBlbXVsYXRpb24gWzFdLg0KPj4+Pj4+IEF0IHRoZSBl
bmQgeW91IHdyb3RlIFsxXToNCj4+Pj4+PiAiV2VsbCwgaW4gb3JkZXIgZm9yIHRoZSB3aG9sZSB0
aGluZyB0byBiZSBzZWN1cml0eSBzdXBwb3J0ZWQgaXQgbmVlZHMgdG8NCj4+Pj4+PiBiZSBleHBs
YWluZWQgZm9yIGV2ZXJ5IGJpdCB3aHkgaXQgaXMgc2FmZSB0byBhbGxvdyB0aGUgZ3Vlc3QgdG8g
ZHJpdmUgaXQuDQo+Pj4+Pj4gVW50aWwgeW91IG1lYW4gdlBDSSB0byByZWFjaCB0aGF0IHN0YXRl
LCBsZWF2aW5nIFRPRE8gbm90ZXMgaW4gdGhlIGNvZGUNCj4+Pj4+PiBmb3IgYW55dGhpbmcgbm90
IGludmVzdGlnYXRlZCBtYXkgaW5kZWVkIGJlIGdvb2QgZW5vdWdoLg0KPj4+Pj4+DQo+Pj4+Pj4g
SmFuIg0KPj4+Pj4+DQo+Pj4+Pj4gU28sIHRoaXMgaXMgd2h5IEkgbGVmdCBhIFRPRE8gaW4gdGhl
IFBDSV9DT01NQU5EIGVtdWxhdGlvbiBmb3Igbm93IGFuZCBvbmx5DQo+Pj4+Pj4gY2FyZSBhYm91
dCBJTlR4IHdoaWNoIGlzIGhvbm9yZWQgd2l0aCB0aGUgY29kZSBpbiB0aGlzIHBhdGNoLg0KPj4+
Pj4gUmlnaHQuIFRoZSBpc3N1ZSBJIHNlZSBpcyB0aGF0IHRoZSBkZXNjcmlwdGlvbiBkb2VzIG5v
dCBoYXZlIGFueQ0KPj4+Pj4gbWVudGlvbiBvZiB0aGlzLCBidXQgaW5zdGVhZCB0YWxrcyBhYm91
dCBzaW1wbHkgd3JpdGluZyB6ZXJvLg0KPj4+PiBIb3cgZG8geW91IHdhbnQgdGhhdCBtZW50aW9u
ZWQ/IEV4dGVuZGVkIGNvbW1pdCBtZXNzYWdlIG9yDQo+Pj4+IGp1c3QgYSBsaW5rIHRvIHRoZSB0
aHJlYWQgWzFdPw0KPj4+IFdoYXQgSSdkIGxpa2UgeW91IHRvIGRlc2NyaWJlIGlzIHdoYXQgdGhl
IGNoYW5nZSBkb2VzIHdpdGhvdXQNCj4+PiBmdW5kYW1lbnRhbGx5IGltcGx5aW5nIGl0J2xsIGVu
ZCB1cCBiZWluZyB6ZXJvIHdoaWNoIGdldHMgd3JpdHRlbg0KPj4+IHRvIHRoZSByZWdpc3Rlci4g
U3RhdGluZyBhcyBhIGNvbmNsdXNpb24gdGhhdCBmb3IgdGhlIHRpbWUgYmVpbmcNCj4+PiB0aGlz
IG1lYW5zIHdyaXRpbmcgemVybyBpcyBjZXJ0YWlubHkgZmluZSAoYW5kIGxpa2VseSBoZWxwZnVs
IGlmDQo+Pj4gbWFkZSBleHBsaWNpdCkuDQo+PiBYZW4gYW5kL29yIERvbTAgbWF5IGhhdmUgcHV0
IHZhbHVlcyBpbiBQQ0lfQ09NTUFORCB3aGljaCB0aGV5IGV4cGVjdA0KPj4gdG8gcmVtYWluIHVu
YWx0ZXJlZC4gUENJX0NPTU1BTkRfU0VSUiBiaXQgaXMgYSBnb29kIGV4YW1wbGU6IHdoaWxlIHRo
ZQ0KPj4gZ3Vlc3QncyB2aWV3IG9mIHRoaXMgd2lsbCB3YW50IHRvIGJlIHplcm8gaW5pdGlhbGx5
LCB0aGUgaG9zdCBoYXZpbmcgc2V0DQo+PiBpdCB0byAxIG1heSBub3QgZWFzaWx5IGJlIG92ZXJ3
cml0dGVuIHdpdGggMCwgb3IgZWxzZSB3ZSdkIGVmZmVjdGl2ZWx5DQo+PiBpbXBseSBnaXZpbmcg
dGhlIGd1ZXN0IGNvbnRyb2wgb2YgdGhlIGJpdC4gVGh1cywgUENJX0NPTU1BTkQgcmVnaXN0ZXIg
bmVlZHMNCj4+IHByb3BlciBlbXVsYXRpb24gaW4gb3JkZXIgdG8gaG9ub3IgaG9zdCdzIHNldHRp
bmdzLg0KPj4NCj4+IFRoZXJlIGFyZSBleGFtcGxlcyBvZiBlbXVsYXRvcnMgWzFdLCBbMl0gd2hp
Y2ggYWxyZWFkeSBkZWFsIHdpdGggUENJX0NPTU1BTkQNCj4+IHJlZ2lzdGVyIGVtdWxhdGlvbiBh
bmQgaXQgc2VlbXMgdGhhdCBhdCBtb3N0IHRoZXkgY2FyZSBhYm91dCB0aGUgb25seSBJTlRYDQo+
PiBiaXQgKGJlc2lkZXMgSU8vbWVtb3J5IGVuYWJsZSBhbmQgYnVzIG11c3RlciB3aGljaCBhcmUg
d3JpdGUgdGhyb3VnaCkuDQo+PiBJdCBjb3VsZCBiZSBiZWNhdXNlIGluIG9yZGVyIHRvIHByb3Bl
cmx5IGVtdWxhdGUgdGhlIFBDSV9DT01NQU5EIHJlZ2lzdGVyDQo+PiB3ZSBuZWVkIHRvIGtub3cg
YWJvdXQgdGhlIHdob2xlIFBDSSB0b3BvbG9neSwgZS5nLiBpZiBhbnkgc2V0dGluZyBpbiBkZXZp
Y2Uncw0KPj4gY29tbWFuZCByZWdpc3RlciBpcyBhbGlnbmVkIHdpdGggdGhlIHVwc3RyZWFtIHBv
cnQgZXRjLg0KPj4gVGhpcyBtYWtlcyBtZSB0aGluayB0aGF0IGJlY2F1c2Ugb2YgdGhpcyBjb21w
bGV4aXR5IG90aGVycyBqdXN0IGlnbm9yZSB0aGF0Lg0KPj4gTmVpdGhlciBJIHRoaW5rIHRoaXMg
Y2FuIGJlIGVhc2lseSBkb25lIGluIFhlbiBjYXNlLg0KPj4NCj4+IEFjY29yZGluZyB0byAiUENJ
IExPQ0FMIEJVUyBTUEVDSUZJQ0FUSU9OLCBSRVYuIDMuMCIsIHNlY3Rpb24gIjYuMi4yDQo+PiBE
ZXZpY2UgQ29udHJvbCIgc2F5cyB0aGF0IHRoZSByZXNldCBzdGF0ZSBvZiB0aGUgY29tbWFuZCBy
ZWdpc3RlciBpcw0KPj4gdHlwaWNhbGx5IDAsIHNvIHJlc2V0IHRoZSBjb21tYW5kIHJlZ2lzdGVy
IHdoZW4gYXNzaWduaW5nIGEgUENJIGRldmljZQ0KPj4gdG8gYSBndWVzdCB0IGFsbCAwJ3MgYW5k
IGZvciBub3cgb25seSBtYWtlIHN1cmUgSU5UeCBiaXQgaXMgc2V0IGFjY29yZGluZw0KPj4gdG8g
aWYgTVNJL01TSS1YIGVuYWJsZWQuDQo+ICIuLi4gaXMgdHlwaWNhbGx5IDAsIHNvIHdoZW4gYXNz
aWduaW5nIGEgUENJIGRldmljZSByZXNldCB0aGUgZ3Vlc3QgdmlldyBvZg0KPiAgIHRoZSBjb21t
YW5kIHJlZ2lzdGVyIHRvIGFsbCAwJ3MuIEZvciBub3cgb3VyIGVtdWxhdGlvbiBvbmx5IG1ha2Vz
IHN1cmUgSU5UeA0KPiAgIGlzIHNldCBhY2NvcmRpbmcgdG8gaG9zdCByZXF1aXJlbWVudHMsIGku
ZS4gZGVwZW5kaW5nIG9uIE1TSS9NU0ktWCBlbmFibGVkDQo+ICAgc3RhdGUuIg0KSSdsbCBwdXQg
dGhpcyBkZXNjcmlwdGlvbiBpbnRvIFBDSV9DT01NQU5EIGVtdWxhdGlvbiBwYXRjaA0KPg0KPiBN
YXliZT8gKE9idmlvdXNseSBhIGZyZXNoIGRldmljZSBnaXZlbiB0byBhIGd1ZXN0IHdpbGwgaGF2
ZSBNU0kvTVNJLVgNCj4gZGlzYWJsZWQsIHNvIEknbSBub3Qgc3VyZSB0aGF0IGFzcGVjdCByZWFs
bHkgbmVlZHMgbWVudGlvbmluZy4pDQo+DQo+IEJ1dDogV2hhdCdzIHN0aWxsIG1pc3NpbmcgaGVy
ZSB0aGVuIGlzIHRoZSBzZXBhcmF0aW9uIG9mIGd1ZXN0IGFuZCBob3N0DQo+IHZpZXdzLiBXaGVu
IHdlIHNldCBJTlR4IGJlaGluZCB0aGUgZ3Vlc3QncyBiYWNrLCBpdCBzaG91bGRuJ3Qgb2JzZXJ2
ZSB0aGUNCj4gYml0IHNldC4gT3IgaXMgdGhpcyBtZWFudCB0byBiZSBhbm90aGVyIChiaWcpIFRP
RE8/DQo+DQo+IEphbg0KPg0KVGhhbmsgeW91LA0KT2xla3NhbmRy


From xen-devel-bounces@lists.xenproject.org Thu Feb 10 13:36:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 10 Feb 2022 13:36:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269853.463979 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nI9cc-0003fL-74; Thu, 10 Feb 2022 13:36:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269853.463979; Thu, 10 Feb 2022 13:36:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nI9cc-0003fE-48; Thu, 10 Feb 2022 13:36:30 +0000
Received: by outflank-mailman (input) for mailman id 269853;
 Thu, 10 Feb 2022 13:36:28 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=4tMu=SZ=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nI9cZ-0003f8-Ut
 for xen-devel@lists.xenproject.org; Thu, 10 Feb 2022 13:36:27 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 72081182-8a76-11ec-8eb8-a37418f5ba1a;
 Thu, 10 Feb 2022 14:36:26 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2177.outbound.protection.outlook.com [104.47.17.177]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-22-5jbB1LiMOSCcdehwqa4hUA-1; Thu, 10 Feb 2022 14:36:25 +0100
Received: from AM0PR04MB5587.eurprd04.prod.outlook.com (2603:10a6:208:125::12)
 by AM0PR04MB5457.eurprd04.prod.outlook.com (2603:10a6:208:115::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Thu, 10 Feb
 2022 13:36:23 +0000
Received: from AM0PR04MB5587.eurprd04.prod.outlook.com
 ([fe80::54e:e7d:545a:da84]) by AM0PR04MB5587.eurprd04.prod.outlook.com
 ([fe80::54e:e7d:545a:da84%3]) with mapi id 15.20.4951.019; Thu, 10 Feb 2022
 13:36:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 72081182-8a76-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644500186;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=h+tznKeogrT57KmWNOatTCYgVS8pizllRRCBa+7DxEI=;
	b=dLEBA31mcWnJU5+6voTKt3uYv5C9dQ57z+Vk99dG/oDl6AY+c5hAHBz+s/KLSrWdHQ2i5r
	N/BzZtvoZQBNxKyUbGa4MwHH+55NlSc/phYN45c7B5psQ/BhFPhSzAHfcii3BFEDii5DeF
	ysLH37pmGtkh0TljPYnNQIbk8g9s96w=
X-MC-Unique: 5jbB1LiMOSCcdehwqa4hUA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=MHXCKcXJp4JR1MhHPd9U5mUH9St8MCv7tWm4CaGfSNpmqmGwL2oG8BmCWK3giCFsGEQmGhoBoyQSQLiK7VF9EyAFnvu+duaWi9gnhPLmxO6sNaO4BQe2e6SDd3j5qUU0hRZI4NqWcp2HKNqNLrZZp9XVjLzHA88dWI1v6h9HHuFkCFRAG8M/YKA3pHfPHhgipiD97VJJIliPEuQFZB2PPkGobcF8OGrQLtppY1/U/BkDP4LHZm9OC3w/WPYw+KuyQf6WH4LbhxSrOsve0V3Qv6UPaJrdAvigQNiW7AkCVvsh4mFu1SyqxdZ48zjjjRb+dnF+a22+6YkLNTF+RekaNg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=h+tznKeogrT57KmWNOatTCYgVS8pizllRRCBa+7DxEI=;
 b=cNe0gmuqt341w3AymaJpU6gbA9A0pCQ/jqlSpmUeGTMA4BnK6V2o83veXryDzl/voFW+vG5eUPz/JpwAQNtnPCV44ajk2GNlg0fRCCuKx9LbF1wPHLX1VQoup9wraLUyqYQDcpj/UMG4DpLB5sr3JgLzC8RUbkpWznmV/EOG0E+8+LF+OsGA+fl3Db5cTEjN0ugVmIZMfFSM3VvXKdvGLHuWIu/C5w6dwbU/mKtZQvf4tngzNHyrOmysPWrTArqFRuBou7Ec6kz9TQIpCAZM1XSoXsQt5zdfgpbZmPi4AktM/iTuQmUInze9mFuYn2jwlI30fwQz3tLrVIMyExOsjQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <33d77918-aee6-77ac-6999-2277f5db8850@suse.com>
Date: Thu, 10 Feb 2022 14:36:21 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH v6 10/13] vpci/header: reset the command register when
 adding devices
Content-Language: en-US
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Cc: "julien@xen.org" <julien@xen.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Artem Mygaiev <Artem_Mygaiev@epam.com>,
 "roger.pau@citrix.com" <roger.pau@citrix.com>,
 "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
 "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
 "paul@xen.org" <paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-11-andr2000@gmail.com>
 <96381d7e-dafc-acee-3abf-f9815deb207c@suse.com>
 <ef76faac-f9d3-1cb8-06b5-189ccd299542@epam.com>
 <6f0a015b-c48f-76ed-9a51-39c045ff5927@suse.com>
 <2ad372d4-a181-9307-ef50-a5adb61dae66@epam.com>
 <49380584-0577-96f2-ef1c-a96eabf0d227@suse.com>
 <fbd410d1-84ad-2309-ca05-b9ac7f95f1f9@epam.com>
 <dbef1c95-818c-427c-1963-75d584843cff@suse.com>
 <f34cc940-7f5f-aebd-60d9-d1a3d85d1283@epam.com>
 <8f35e7c5-3193-4b10-ae25-df838e2262c7@suse.com>
 <22084dc5-ba16-3e63-8be6-a8c5c79c9cb0@epam.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <22084dc5-ba16-3e63-8be6-a8c5c79c9cb0@epam.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P193CA0141.EURP193.PROD.OUTLOOK.COM
 (2603:10a6:209:85::46) To AM0PR04MB5587.eurprd04.prod.outlook.com
 (2603:10a6:208:125::12)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e0e1824b-8fc0-46fd-6f70-08d9ec9a5446
X-MS-TrafficTypeDiagnostic: AM0PR04MB5457:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB5457F60542784ADF6F8FDC04B32F9@AM0PR04MB5457.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	1Dqo81rLkF8baI0Shc3SZvUuDrC4/VmEFOKsWVTFRi4jD8ayBm37kkXD4zCqGWKnM/wL1ReSUpArWf4VwwjySkKlZDSJTlMLNfJTC/M+Gs2WfdEYmhfKraRFlVVzXfNmzxPT+BBdWcVowETO7UozqUol6ChLOX3Qj/4LQVtSXkRGSat8mhFLHDbiTxNlvpGRAY9OQstOuXLpsTShVZe0kX96z8JMmzrgGmVDTM4MAVAhyywdgFZ89PNO0W+5fAzsesczaDMDVOvT1a78IgkYuE8imGALiz+atgG83fXpqm6ic2MggpPq5MgxyAIKPVNCflLhNzZAOjnbgtU5gb/CSdcWg9tFD2skjAGj0vJ+EAjlCOD27p3ufYtL/j5/bJmhVRQJfXP66kcDwmNO43AuhcBbwwYOEuceJkbMDyM2gnXzWtPM5chlTa05yNpOU3dE26Msn/V4y4h9HWVcLr6EfQGZfEKtCaiNNzmCRW9VYHgGWckFL6SYI6DH8i4uy4DeeXxznlj87DRB8hX0W1in/nXpCsws/cBkuPFGKSqDxdn35n0C0FA32aMQfzTdWeQF3XC19ggrEc3ESLfssDmUwfGswUXQ3T216NNJMg/yg5iHXtHbrxNIgN9dVNVaRcMuGFu5reAnukPUGxEPLhf2sKGRgHwfuKv3/FUJTXobh5DgY9TxAVbg09YOXhRyaWamsV1u7FdhhqSNgGspqpxbLAkwOapgd/kEvPk7OjKkQM3QkIHMz5auT10N6k/kau3k
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR04MB5587.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(31696002)(38100700002)(86362001)(186003)(26005)(6486002)(508600001)(31686004)(316002)(54906003)(36756003)(2616005)(2906002)(66476007)(7416002)(5660300002)(6512007)(4326008)(6916009)(66946007)(66556008)(8936002)(4744005)(6506007)(53546011)(8676002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UzdEdGhyQzlkRUVzWGwyY2F5MGlvVDZxQTA1T2t3QThUYktZRHk5aUVxVENF?=
 =?utf-8?B?a0FkRFhVNUVaTkNid2xKTzlQYVk0TUR5UUxEYVZSRTNycFJxZ21sMjdJVU4v?=
 =?utf-8?B?S0pUUzVqTDk0ZVdrYlNUbWFnb3E2N093SkUwU21TOE9NTzVqbTJhaUNMR3ho?=
 =?utf-8?B?b0ZnZE1YQXJlQ0dZS0ZGdFdzUzQrZlg2TnNMMkRaRjZ5TUlaZWNobFhFOUpP?=
 =?utf-8?B?WkFhUmpIRG5RKzZESjFkLzU2Y0I1am1OdXRoZkVlL29FSXlVNXRUV2svN2Jj?=
 =?utf-8?B?VUtib2pXaDJrRkY2VEcwMDhadGsySGFneWMxS2tUUnAySGw4SC9BSCt3aWky?=
 =?utf-8?B?bmI2NU5yZTBvdlI5Zy9pWElKNFo1c1AydnBQekNwdmlaWkl1UVRpSnZnYW1X?=
 =?utf-8?B?N09vWi9CbTJzRU1wV3YwK0J5VURlSERnN3F1TkZnYi8rVUhKOFhFblZ5d2dz?=
 =?utf-8?B?anFscUJ1RU5mbjdYMndjSjRpNGJjQkh0MmZaZGc2ZDJUbHN0bGFkelA2cGQr?=
 =?utf-8?B?aUg1dFpzMXBsWE1KVk91MlRxK1c5STFsYnZrT2QwZXB2SlN6OTFsQlZPZHZQ?=
 =?utf-8?B?WWtMbUlwQ3I2OWdaNlVJQXhtQ0hqK1g0VWV1TWxOc0VJM29DL2craWpyVUJJ?=
 =?utf-8?B?VEZnZEZkTFZVcU1ZVEVFWHEzT1p5dG9lYzAwNGd2bkdIc05pQjhpcTh6ZnhV?=
 =?utf-8?B?c2FQb0g2SEVkOVFHYTZLK1BHQ0tRQ0c2NzBxZDNlZkUycjFlOS9SRDNiNDNF?=
 =?utf-8?B?UmM0cUtZOTk1eUlHRE80MTdCZ2pZa0hQMDhmbWlSTW9IQmdoaXJLZnkvQ0FH?=
 =?utf-8?B?Qyt2THZjR3IzQ3h0RXpXWWRLOVBaQTExc2M4VGE0cWxQVEZ1cUtLbHYxdXAv?=
 =?utf-8?B?bzR1alFQZEM4emlnQmE4Uk5HR3VGQ3Yyd0dMZ1UyUXFLQ3NHTTJRMHFpMXdM?=
 =?utf-8?B?Sk1vU0tJOERjVUhhUnBKaWpMT0lTYlJFVTF0NmlOYzQ2YlduWHRPbmNSTGV5?=
 =?utf-8?B?VWNjU2xrakNwblkvclJrMDI2WjBsNWxFa0ZwNVd0aFZYQyt0V2Ztb3pkc25j?=
 =?utf-8?B?cHR2dmJMcGJFS2xpU1lwMzVQVmlwUGVzY3ZLMjdQNis5elBpL21VcDJJNXdC?=
 =?utf-8?B?VzExb1dOZEJtTHZBK3QrMHlBZktIemNQRnRENVV0MTRUenp5UVRhTWZhVVU0?=
 =?utf-8?B?djFvN0xjRXhtRWNKMVZvZWpnWmRUeG9tc1lzRWFGeDFBS0RXa1NUcmtXY3hl?=
 =?utf-8?B?Y3RZOG1kK3BQcDliOVNNbG1waWVxUGxyNkNIZ1YxMWEzU0tTcXJIYUF2SFR3?=
 =?utf-8?B?UEhsVUpMQU1ya0k0UW1JSFdoZEJuYU1JbGE3YnUzT1kxdk1odXNCYkY0bW0z?=
 =?utf-8?B?elljZ3ZkTkhhQTJKdjBOZlFjeDcwSldWVXRxaXpYK3p2MFp0NmR4RHQzaVY3?=
 =?utf-8?B?NUgwZ09BUkRhVnl0QzdlQ3NEL0VwYWxCUUg2eXhRRUU5Slltayt4WitCenpC?=
 =?utf-8?B?R093cjBTengxVElNNmhjSlF0MWpQRjl3VUM0QjNPN2I5REJJV3JudkJmUUV4?=
 =?utf-8?B?VkdZeWk1RlphL21mK0dVTUM1UTljU0hKRmZEaFoxOEVQUFN1SnBNUE9WSCth?=
 =?utf-8?B?SkdJUk01NDBkMmlBQnlYeHo0aU9uSmRxR0tGenNENC9HSW5RZEoxVlUxUXpm?=
 =?utf-8?B?dEpjTXpOVVVCN25YSWczU1N2N25TemRuYXp0eER4TEZzMnZXYkYvVmcybXZu?=
 =?utf-8?B?bWlBUitna3hvZDVCdGFoaUdEdzN3UWg3V1dveHhiSTFqZUhuU0VrN1ZSUFhO?=
 =?utf-8?B?Sy9QTDl0eGZmbno5dW1iY1J1NlhMQ0Rxa2gvOVpuT2k2a2ZwQkl2Uk1HWDhI?=
 =?utf-8?B?VXE0VEU4eXo1TGhkRGNwdksvMGlVNzdoeGZjbVBkTXlZTlNtR3RtbWV5aG9w?=
 =?utf-8?B?Zk41TDdRckpXb1JEYUlSU2QxYnNXMkdzdmgyOUtyektUVmtMbzdxdlMwMktY?=
 =?utf-8?B?T0NzajlFdzA3NkRKLzVxMTgyZUV6SEJ4UDRUMkpTQ0FZVWdqQVVLMExtQkV1?=
 =?utf-8?B?ZGs5dHBxb1FuWHZPbE9BY0xtRGNKMitHbFg5cXRGdU1OTEUyaFRLcGhyZ2Fm?=
 =?utf-8?B?QkJUWXZTcEh0d0FNMDZydittWTVLR3Jaa0F1eDJmbTA4dmNJamE4T29KR0ZF?=
 =?utf-8?Q?EtQApqgGx1e5b+2JDgGZrAw=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e0e1824b-8fc0-46fd-6f70-08d9ec9a5446
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB5587.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2022 13:36:23.3750
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tY5dBUZjcjZN6WL8gcWZTwH4yU3lSNB7M08XRFYSUPKQ5quMAm3Fbj1mW2F0l8rcsMEFboayV5ybOj+hVIE8qQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5457

On 10.02.2022 13:54, Oleksandr Andrushchenko wrote:
> On 07.02.22 16:31, Jan Beulich wrote:
>> On 07.02.2022 15:17, Oleksandr Andrushchenko wrote:
>> But: What's still missing here then is the separation of guest and host
>> views. When we set INTx behind the guest's back, it shouldn't observe the
>> bit set. Or is this meant to be another (big) TODO?
> Why not? This seems to be when a guest tries to both enable MSI/MSI-X
> and INTx which is a wrong combination. Let's pretend to be a really
> smart PCI device which partially rejects such PCI_COMMAND write,
> so guest still sees the register consistent wrt INTx bit. Namely it remains
> set.

I'm afraid this wouldn't be "smart", but "buggy". I'm not aware of
the spec leaving room for such behavior. And our emulation should
give the guest a spec-compliant view of the device.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Feb 10 13:57:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 10 Feb 2022 13:57:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269862.463993 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nI9wO-00065I-SB; Thu, 10 Feb 2022 13:56:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269862.463993; Thu, 10 Feb 2022 13:56:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nI9wO-00065B-P3; Thu, 10 Feb 2022 13:56:56 +0000
Received: by outflank-mailman (input) for mailman id 269862;
 Thu, 10 Feb 2022 13:56:56 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=06a2=SZ=epam.com=prvs=40400e4a88=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nI9wN-000655-Sr
 for xen-devel@lists.xenproject.org; Thu, 10 Feb 2022 13:56:56 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4d24482e-8a79-11ec-8f75-fffcc8bd4f1a;
 Thu, 10 Feb 2022 14:56:54 +0100 (CET)
Received: from pps.filterd (m0174676.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 21ADsnnc005870;
 Thu, 10 Feb 2022 13:56:50 GMT
Received: from eur02-he1-obe.outbound.protection.outlook.com
 (mail-he1eur02lp2059.outbound.protection.outlook.com [104.47.5.59])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e540pr0kp-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Thu, 10 Feb 2022 13:56:50 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM9PR03MB7316.eurprd03.prod.outlook.com (2603:10a6:20b:261::8)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Thu, 10 Feb
 2022 13:56:46 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::fc4d:4749:5d1:eb73]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::fc4d:4749:5d1:eb73%4]) with mapi id 15.20.4975.012; Thu, 10 Feb 2022
 13:56:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4d24482e-8a79-11ec-8f75-fffcc8bd4f1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=LsRibKuBw4NG5htbv2bVsLhf/kuYGy+yeOqieJhqrmOCcWoaXZacsjl3bz6zJSF+2jd1p4vZCi1B3DuUvTjKb/QwIpOiK+XlmPgkqZaMACmZITun5OAsIOd2DLrqqkTeJ/fyRlKFh7vGsTn6lhneXSXIWEVetOb6SyIiYpt3aNwzXi1NuX4Jujq/hbGgpmw/dXI0SD/VWqA3IEs3pxMQLy2ulk0MDPMBHU0f552k2hCtrzVZ3rjM9ZWGrQiJj3mzbPC+XO3uekSnDMAy9P1ZLzJ8jIJgV/9V7XL+9NrT5mRfKRQpAc+POxvVzQMw10jKVhS4EJosrCuRnNJu86GZRg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=EoexHjlOaY9F7iVbP1Pg9SayF11zkzAFwoN8Gzo86KI=;
 b=hsLT7puvPs2ypzNko+fgJ46oIViPNYtQ993hlPigjpkO+uqG7n15XUYRAaLhmn3n2x/RYQlob1SMBRauCdYxNlOnS2iE2I9mNpgRWyYvYUngt8wOvVEIMpGVnp3fIAwFOiTJWTcgi3tNjdVYplTzPNefA/OLQKX3KTzST1VmPgZX8WX7GJ2cdj5O3EC8JVOmELCn6opYdwgmAfxDorGuzCm9xntA4BIEoOcKR7Os8/UnzmdLcTCpCHnEuJyyJ4IRanhLrJ5YtHwEXvi0TOIXyAfi0gTkKEKuk0fWqh3Fng+Dg4t02YbwzpWCtZ97AARfBDnjSVCgudKclVU3h0P2ag==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=EoexHjlOaY9F7iVbP1Pg9SayF11zkzAFwoN8Gzo86KI=;
 b=GBwi4G/++PPaHlUTnhxMgMXe57G0FLmf+5Wg7MxE9K/22qKw3eqT2NM0v0XVdvymNC4JMugmmi9nMKmRI9yvnJvMwgMtpgE17a8AZLXKxHi7kE/bctQcVvt3pPyKca87MlbbeAvlA5nlErXfWm5zuIWCHqWlUPczxV0gE6Nd6hSeIWEir5FCZXXpLrMqoXy3UTY5zf+GRXHxsPW7Tuzb2iRJoitzhmYfrxcKxo9Mo/XixAMdrMXN5VObOpK7HDSl4fBrS00bgu7MIBv84WFPQ8+WXeoOhUtOGakoDosIrSx7cz+/Rk3y9XfKWk4JCqLSu66VJTT6AflIfdL34slNMw==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "roger.pau@citrix.com" <roger.pau@citrix.com>,
        "andrew.cooper3@citrix.com"
	<andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com"
	<george.dunlap@citrix.com>,
        "paul@xen.org" <paul@xen.org>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>,
        Rahul Singh <rahul.singh@arm.com>,
        "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        Oleksandr
 Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v6 10/13] vpci/header: reset the command register when
 adding devices
Thread-Topic: [PATCH v6 10/13] vpci/header: reset the command register when
 adding devices
Thread-Index: 
 AQHYGZFg3nazYSvfA0G+yHTbxcxX2ayDdFgAgAAB6wCABD+NgIAAQmgAgAAT4YCAAAOjAIAAAPCAgAAXGICAAAPHAIAEnAeAgAALrICAAAWzgA==
Date: Thu, 10 Feb 2022 13:56:46 +0000
Message-ID: <56623ff4-e7a2-abc3-f4ed-51ff0db4ebd7@epam.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-11-andr2000@gmail.com>
 <96381d7e-dafc-acee-3abf-f9815deb207c@suse.com>
 <ef76faac-f9d3-1cb8-06b5-189ccd299542@epam.com>
 <6f0a015b-c48f-76ed-9a51-39c045ff5927@suse.com>
 <2ad372d4-a181-9307-ef50-a5adb61dae66@epam.com>
 <49380584-0577-96f2-ef1c-a96eabf0d227@suse.com>
 <fbd410d1-84ad-2309-ca05-b9ac7f95f1f9@epam.com>
 <dbef1c95-818c-427c-1963-75d584843cff@suse.com>
 <f34cc940-7f5f-aebd-60d9-d1a3d85d1283@epam.com>
 <8f35e7c5-3193-4b10-ae25-df838e2262c7@suse.com>
 <22084dc5-ba16-3e63-8be6-a8c5c79c9cb0@epam.com>
 <33d77918-aee6-77ac-6999-2277f5db8850@suse.com>
In-Reply-To: <33d77918-aee6-77ac-6999-2277f5db8850@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 2222a1c3-fe09-4775-f41f-08d9ec9d2d86
x-ms-traffictypediagnostic: AM9PR03MB7316:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM9PR03MB731646AC355922505143F387E72F9@AM9PR03MB7316.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8882;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 WU7iUmyhmzfc8OE7A5pia2QTZ2DCgO0t2KCb2RE5q/ktQO77jperbRFnIwtaLmMl7KxWBIrLXkI9BDDK8YncWLlc/XEqIXeQQ9kWxPXosIlhVCFp8xPVeTt1o3mQsWnvzFSeaq5utWOoe2Gbmht4Unx7M56dKB6qsnb1mjo3sTLx9wqhUUAJVOHaUt8qvKGFSWJ/FvGWZKF2W54G9FsbVb1H4R44p3Kgd18WtmCgHuOlcweTkLMtVLMxtmdnupE/9MNiX+sujRlfLvRin+NujJc+H7ClpXQ5ljtBOm41ktavm2wgS3/3cXAeijznFk9Vout8QTvp94hRhKNw77eXnE2+3czFCRP6VQ1gI4RKojSION2k6N0Yin5s4kukWo7jsQV6EuC+o3TCNqOh3K9CR/BtWvLxJN4NovTaWBYZMj01lQqhlbXnGgR0NmLMa4sjFYLzrH21iXrZyflUgX7PtwY6L6LPjQGPYbmrhWkRDChgoyh6L+4aOVPlvyGvEZo5lvoDR7M8pBvj9VTEL4g+cZwDroZxcZLf2YgumWAkJiQIxLFoP6N0bESjHGRwVNAIS4M53rOQMFGc9QcQa/D01GM5cvRlhwrXURI9wDOY7TfRv9H5jVKOH9jUMr8/i1LmNBFY96Y4bnzqRHWapk8xLYAiqK+TxxCvndLOR6AyvjlXOoYuzvD/4TVvRLJ5k7utWVGWlpOeX+PFG9wKj80cLO2JqxG7KiEVXLg4tJRTuvgoqcZHEQ0LOaeJijHUfF/O
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66476007)(2906002)(66946007)(76116006)(6916009)(86362001)(54906003)(31696002)(66556008)(6506007)(6512007)(6486002)(5660300002)(38070700005)(31686004)(91956017)(36756003)(38100700002)(508600001)(122000001)(2616005)(107886003)(53546011)(71200400001)(4326008)(66446008)(8936002)(8676002)(64756008)(26005)(316002)(186003)(7416002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?bUZtSUU4WXlPYllSTkMrQ0FQK29tQ0RxWjNzZmVDUWlLbXZiZHA3VVBnQ01L?=
 =?utf-8?B?NDV2RzFjSzBUeGsvWGMvajJxY1hrNzgxOFI0V2FkV25ITWlVRlJZdGZTMktG?=
 =?utf-8?B?aGxGV0N3dytKa1F3ak9nM3h4Ny96MzhETW9RcXNmVFVsNzRzbWRtaEhLSHFX?=
 =?utf-8?B?SW4zTzA0R3cxYXRkNWtwaGtTSVJ0VmZrMDVvR0RRZlNJQkczbGhyK1Q1REdp?=
 =?utf-8?B?VGlxckYrc3daNlZaa2FOU1JmcEo3SE0zaGhMckZPM3BIc0psNWZjMGNZZExq?=
 =?utf-8?B?emJtUk1rZGdzUXJZOTRIVE1uNnJ5NHNxanQ3aVQ1a1BMNWxOTDlCM2NFZUlF?=
 =?utf-8?B?VlVjdHVLQTNyc1VEcm55MWswTXkvNkdTZVJZWFBNbm9NT09IaUQ3YjhhY21i?=
 =?utf-8?B?dzA0VzRtK2RSVGhLcWU0ZDJURGxYMU1pL2ZmMkc0aUJqNDE2UXl0UDhYWk1R?=
 =?utf-8?B?U0hLbm84Tkh0TTFnR0lFTVB1T05WTCtnQVcvbUpUQUhSNVRhWExDa0hLYWpW?=
 =?utf-8?B?L2cwTnBRMlVLdTVaY0RuV1hDWEswUUFWSHVZWjE0SENMaldtQllaM1hHR3pu?=
 =?utf-8?B?eXFxUlMxL2h6SnFSemo5VkdpQ1N5TmNTbDlpckVPVjVQaEF6amx4TG1JSFp2?=
 =?utf-8?B?OU1YZWZWTUVoN0JNRHphRlBKMWh4M3E5RzB6TzZCUGVpTkQ3MDdmTXNjWUIw?=
 =?utf-8?B?cXc4UlJDUEUvbno2SnpmakgweWgybXF1ZWVXU0kySS96OXQ5SDR0VzBBUXpW?=
 =?utf-8?B?bEp1dTFpdnh3M2hueTlFZnpyampHS3J2NE82dW4wSVloVTdVTmpzNjgycWNU?=
 =?utf-8?B?aTFmUi9QZzJoRGtiYXgyOFQ3eUhBejBIVmx6eTFmTWNoSzRZN09tTEc4L0Iv?=
 =?utf-8?B?cmNjb3EzVmFYMG9YOVRIMk5HU2RscWxjdHA1MjFoLzNuNWw1aHFBenZZcTR5?=
 =?utf-8?B?K0JYMnF0SHdrMi9VK3c4NGJySUpWb211TEFXWWpwM20yWEtycm5LVHNRSGpR?=
 =?utf-8?B?RWNySzc0dHh4QjlEN3EyT3hVZTZQcUtJUTlEYkRxaGNyYTVpZFlvRjJacGh5?=
 =?utf-8?B?Q0IvL3hvUmk2dzBiaU50WmppWmFyamdRUVl4YUFpcDRUb3BEVmV1S1ZBZHdF?=
 =?utf-8?B?Wlk3NzVmRFM0ZG5jWHFhZkZKUXczajNNZkh3b2tQclBpdmhuaUZWdGt3VnV5?=
 =?utf-8?B?VEtoT2puRXpPdmIxZHJVdVV5aUg2K25jSlYvUGMwZVM5SUxCZHpUZVorUVZs?=
 =?utf-8?B?Z2lnR3R0WUhta0d1SzQ2VDVIUXBwR0YvMGlGWFRQR0x4TWRBTEhCK2JGd2Ro?=
 =?utf-8?B?b2g5NkpoVng2MXhZREcrUmhEa3dmb0d3QjdFSGJwZ2UxTkx0QStEUnNwV1JN?=
 =?utf-8?B?dlpTdExjVE12WkVVT01XTEg5bzlLZUwzUnpGSVZISXlacEx3bkh1Y2l5VjBQ?=
 =?utf-8?B?M1orbTFtOVFMYWNTc2w0cmR3NS8ycXdFOXliRGFNZVBCa3ViOVB1SVhMNkJ0?=
 =?utf-8?B?K0tPeHh1WFZ3em9JN1pwazJKNnh6eXAvamRPcFVvQkRnUGpMVnNtNzl4ajA0?=
 =?utf-8?B?a0dHcVZ2MWJrZzhLUGtQdmVRNDl3K2dKZHA4eklxaDBQdkFkYVRpNENPQWhB?=
 =?utf-8?B?b1czKzNiaXN3VUFzbVlIU0pxcWpjNzh0Qm9ZZE5rY3lXeUNrRVl1Z0drNkdn?=
 =?utf-8?B?Nms3NGlYcms1cld2YVhrRFM0TTRwclFiZXhQSUJHTWRRWk9qRldMSkswd2ZP?=
 =?utf-8?B?SThTT0hCM3RMS2pJUDFtQmxiSTF5OXpzSW53dFdwRk9ONk1JbHhuV3J1aXVU?=
 =?utf-8?B?cEhWUDkraHVSV2FJQjBqVGpaOFk0cjJHcWY2MkNFMUhTdkJxczZ3SXZOK3hM?=
 =?utf-8?B?Qm5OQ2VLekN2eU1pdVZucTZFNVRTMzNUcTRDcUEwME5KVkZFM3BMRFpHZ1FD?=
 =?utf-8?B?aWRpaFFWb0xYdTVuOEYvbHJYQm5YWUdoNkhSOXY5aGd2Mk1qWnBSMGxyU3ZB?=
 =?utf-8?B?SG9PcU55V2lLRitRcHY0Y0FodHlxajA0TDRTMUl2dWFZZmhSS0FGbmFzZS9h?=
 =?utf-8?B?WlQ4RWRVUnpLSFFkbWlUMEJhTHloZU0vYnNQbTNpd3Vsck82RFBLSHcwb3Rp?=
 =?utf-8?B?bS9TVUp4eHRyTXA2bGRqeVZrdEpSQU55RUQ0R1lMY0pNT0R3b2dDL2NkSWhJ?=
 =?utf-8?B?RWFMK3BVaDdMVm5Fd2dEaW1IbzgwZy9KSzJ4WnQ4TTc5Zi9aZ3JseU5YSisv?=
 =?utf-8?B?SGRUZEp2S2pwM1dQdFY1Qkdvb05jU3JvUE40QmVXRXhSalJaRG9GcEZvczZt?=
 =?utf-8?B?SFNTVnZKY1hCaWFXZXJ3bStzaUVzZTdFWVNjSDhMOGlWRFBuTzB1Zz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <74C9ABFD181D0D44874B12BB84DB7313@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2222a1c3-fe09-4775-f41f-08d9ec9d2d86
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Feb 2022 13:56:46.6850
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: zvbt7CPk+oSCi2Zk2idTSOCEDxHPX1HcxaQ/oAG/jYkcEDds9gboUZwA4tVfHZFqBqMV5JlR1N/7yXLp+Ae2ONAhnGXDfN81qsNXWzR+j/dQqcMzOwWgLH5gXTdOcEZT
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR03MB7316
X-Proofpoint-ORIG-GUID: WbXlWepGic_-tzIi8XVStgpFoPQizZnp
X-Proofpoint-GUID: WbXlWepGic_-tzIi8XVStgpFoPQizZnp
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-10_06,2022-02-09_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0
 mlxlogscore=844 mlxscore=0 adultscore=0 lowpriorityscore=0 spamscore=0
 priorityscore=1501 impostorscore=0 phishscore=0 bulkscore=0 malwarescore=0
 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202100076

DQoNCk9uIDEwLjAyLjIyIDE1OjM2LCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMTAuMDIuMjAy
MiAxMzo1NCwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+PiBPbiAwNy4wMi4yMiAx
NjozMSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+Pj4gT24gMDcuMDIuMjAyMiAxNToxNywgT2xla3Nh
bmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+Pj4gQnV0OiBXaGF0J3Mgc3RpbGwgbWlzc2luZyBo
ZXJlIHRoZW4gaXMgdGhlIHNlcGFyYXRpb24gb2YgZ3Vlc3QgYW5kIGhvc3QNCj4+PiB2aWV3cy4g
V2hlbiB3ZSBzZXQgSU5UeCBiZWhpbmQgdGhlIGd1ZXN0J3MgYmFjaywgaXQgc2hvdWxkbid0IG9i
c2VydmUgdGhlDQo+Pj4gYml0IHNldC4gT3IgaXMgdGhpcyBtZWFudCB0byBiZSBhbm90aGVyIChi
aWcpIFRPRE8/DQo+PiBXaHkgbm90PyBUaGlzIHNlZW1zIHRvIGJlIHdoZW4gYSBndWVzdCB0cmll
cyB0byBib3RoIGVuYWJsZSBNU0kvTVNJLVgNCj4+IGFuZCBJTlR4IHdoaWNoIGlzIGEgd3Jvbmcg
Y29tYmluYXRpb24uIExldCdzIHByZXRlbmQgdG8gYmUgYSByZWFsbHkNCj4+IHNtYXJ0IFBDSSBk
ZXZpY2Ugd2hpY2ggcGFydGlhbGx5IHJlamVjdHMgc3VjaCBQQ0lfQ09NTUFORCB3cml0ZSwNCj4+
IHNvIGd1ZXN0IHN0aWxsIHNlZXMgdGhlIHJlZ2lzdGVyIGNvbnNpc3RlbnQgd3J0IElOVHggYml0
LiBOYW1lbHkgaXQgcmVtYWlucw0KPj4gc2V0Lg0KPiBJJ20gYWZyYWlkIHRoaXMgd291bGRuJ3Qg
YmUgInNtYXJ0IiwgYnV0ICJidWdneSIuIEknbSBub3QgYXdhcmUgb2YNCj4gdGhlIHNwZWMgbGVh
dmluZyByb29tIGZvciBzdWNoIGJlaGF2aW9yLiBBbmQgb3VyIGVtdWxhdGlvbiBzaG91bGQNCj4g
Z2l2ZSB0aGUgZ3Vlc3QgYSBzcGVjLWNvbXBsaWFudCB2aWV3IG9mIHRoZSBkZXZpY2UuDQpUaGlz
IG1lYW5zIHdlIG5lZWQgdG8gZW11bGF0ZSBQQ0lfQ09NTUFORCBmb3IgZ3Vlc3RzIGluIHRlcm1z
DQp3ZSBuZWVkIHRvIG1haW50YWluIHRoZWlyIHN0YXRlIGp1c3QgbGlrZSB3ZSBkbyBmb3IgQkFS
cyAoaGVhZGVyLT5ndWVzdF9yZWcpDQpTbywgd2Ugd2lsbCBuZWVkIGhlYWRlci0+Z3Vlc3RfY21k
IHRvIGhvbGQgdGhlIHN0YXRlDQo+DQo+IEphbg0KPg0KPg0KVGhhbmsgeW91LA0KT2xla3NhbmRy


From xen-devel-bounces@lists.xenproject.org Thu Feb 10 14:55:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 10 Feb 2022 14:55:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269869.464004 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIAqf-0003bg-To; Thu, 10 Feb 2022 14:55:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269869.464004; Thu, 10 Feb 2022 14:55:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIAqf-0003bZ-Qj; Thu, 10 Feb 2022 14:55:05 +0000
Received: by outflank-mailman (input) for mailman id 269869;
 Thu, 10 Feb 2022 14:55:05 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=4tMu=SZ=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nIAqf-0003bT-0d
 for xen-devel@lists.xenproject.org; Thu, 10 Feb 2022 14:55:05 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6d79c91d-8a81-11ec-8eb8-a37418f5ba1a;
 Thu, 10 Feb 2022 15:55:03 +0100 (CET)
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2059.outbound.protection.outlook.com [104.47.2.59]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-16-2csi-2ygNsunlKZXV4y8KQ-1; Thu, 10 Feb 2022 15:55:01 +0100
Received: from AM0PR04MB5587.eurprd04.prod.outlook.com (2603:10a6:208:125::12)
 by VI1PR0401MB2240.eurprd04.prod.outlook.com (2603:10a6:800:29::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Thu, 10 Feb
 2022 14:55:00 +0000
Received: from AM0PR04MB5587.eurprd04.prod.outlook.com
 ([fe80::54e:e7d:545a:da84]) by AM0PR04MB5587.eurprd04.prod.outlook.com
 ([fe80::54e:e7d:545a:da84%3]) with mapi id 15.20.4951.019; Thu, 10 Feb 2022
 14:55:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6d79c91d-8a81-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644504903;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=ILYp4bDlGe9i0LjIfqEZ5PDhCzdc1cmW3BbGyzH4ehU=;
	b=aT6IddcK1PYVwMkpABfZPxyUUw75AkYWbebjFLa+snp+LdJBsfmtdf0vU+g3cQSRalAaQC
	Et0ZEXvCjJJxBHryWv5IMGtfvo1puZn431jTcgEFNCZoSXfxyrrXQbwLWoGR/tvv2rHs/d
	D40fHUG+aGC7sIUq5/0B2bRnFa/EY5E=
X-MC-Unique: 2csi-2ygNsunlKZXV4y8KQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gNga6g8je6WbHAjgtgA+T1FfSifrZrB8F7plZhbd21vA9lW9pJChuRO8feHGDXpK4oy8YSFHknHklRYhO4RRDD/I2ccq18OOvqr1/L9NafM9cS0mNkRoX9e4CqhlBJQbo8GhUhONGo3Zo0yTxRjUbLdYOcAaJnH0YVrFf8vnFb1TlradjoVrPgvmpdjmxzWQACbCnmGOHa/XB7RqiY7xLyw6CbEAmjedvZeU3nrTrpegW1SVIof3CpIgVZw8TCavxfxjRRa0IxbkqfjCMx2VDBVNDwx4x2UPeiIQxvIP15TK57oWQV6uZywM12H8CPH6mmCD7z+YWd8w8zY4X4nx0g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ILYp4bDlGe9i0LjIfqEZ5PDhCzdc1cmW3BbGyzH4ehU=;
 b=Unh4kLl11DgxJOvDITls8rObDd+jzZMLgf3J7T141CGMea02WtHLFwG94XNcMKNsidZ45qm9D1wTZK5PqFUXgxd+q85CNKI791qoMavj9LVOBdj0xkNPGX1JvWbIDxLcApAsf1m0fVOZb8l9s0j2ehHvYpMm/vsP5IE3Ieec2tnF8L5p2VOci51kxGEhY/sUrIuBBqBBzgXKVNQVw+vm92xDVA3e4h0037n65B5E+ei/YFRyeGmUxwOHhU/EqAhyl6UU3ZNNvzGZc8WX2ahdvw1xduR5FvFoBuuq+Hcy2N0VHk7kVGWNIn3UI1/7xExJ0qH8JiQD8QAgitEebcYcDQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <5d275d7a-7751-af19-db4f-d91e3592d30f@suse.com>
Date: Thu, 10 Feb 2022 15:54:59 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Content-Language: en-US
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH 0/3] x86/Intel: family 0xF tidying
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR05CA0013.eurprd05.prod.outlook.com
 (2603:10a6:20b:2e::26) To AM0PR04MB5587.eurprd04.prod.outlook.com
 (2603:10a6:208:125::12)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 3f7855a0-07ca-44f8-e57b-08d9eca54fd2
X-MS-TrafficTypeDiagnostic: VI1PR0401MB2240:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0401MB2240BC54178FB338FC6D2737B32F9@VI1PR0401MB2240.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	5WgSHjDXu5yJOgKhCRbjoQlj92wwSbxaSDYawUUaRYlZNQ4YUwM0j6GdAdUT+vYHm1cTO/ILmuxfqAG3OUcMwT6/KG5tIpeWj4nZs4iiZwmx3WAt1kqHwOoYLkXMmKwUU0wxL4TAI2FpEIf9CSooB20/KZcy2CiHT4ii+fs/evLckFDiADXjGYes7N5jeX9hTPYxKq8PezVvghVbkqQmoWk4C//iKzu29IHJHla0Hdh2+1qFZTuHXEKPT/SRe+5ZUhwaw7MSUSlgDGrL5+t19FQ5epk+W1PFPxuM8NAry7hrrw/WKfCVs87sS4wkGLAJLwGYmHg0miUDT6YoHqVV9mrjIvh7xaKFYCGrhujkqX9x08DhN+olZ8vUUxRT4V62AZHDw1sajJJfmz6ObqPBq4qXOj6wNR6HKgNDD+WjFtgizaF6Mdx+FT7S/vU0q72WH5n5sYmpsgMbGS2byOW9WE6wxezuGhHgwb53C180mE9+q2iI6fQ5UlZz1h3xF2sg+PY8JR4AFT/g6zuWcU+uiWnNnEAIWDSUBvQfpqQk+b0LVuHt/7vZJgXkN/Xs5BwWTZTe/o1/GAf5DUZrmhAEkEtWoF348LIxZoK3t6qn1Ulzvg7Eos2QTp0nJ7jJ4Tkm7LDkyf0/04bIRK7FLncGcsqIt4dIvu+qOU3A8ErdT5o3I9vlrVqndvayKhtX7tAKcvcRIEsX0gP6uZo8wwmP49M9GsUyBe8/fgS843D4XicQbVoZUCiQHjpfAfaPWrcm
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR04MB5587.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(4326008)(86362001)(31696002)(316002)(6486002)(66556008)(6512007)(66476007)(2906002)(54906003)(8676002)(6506007)(508600001)(66946007)(31686004)(6916009)(36756003)(38100700002)(2616005)(5660300002)(26005)(186003)(8936002)(4744005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UTRHZ2w4b2QxVUtlYjk3aytaVnNxbHZGZUxvaDh0NTNsY1VtR3YxUzJ0SWNR?=
 =?utf-8?B?blFTTVJBVVhuZ0FsSVVVaktRMFJlUzkwTEtDNTNibjFmRWFvUms4NU5mTnFT?=
 =?utf-8?B?andTZXhORVgyc2lnRzFOVGlSSHY1aGFUSFFqMDk0NmJIVjU3WHkvVFhtNEJC?=
 =?utf-8?B?ZU1JSzNsb29XU2ZFRGFaL2JhZWJUVi94dWN6dDQxbGZNeWtKckVBYTk5Wkc0?=
 =?utf-8?B?YTQrdjcvWExyTjYrSGlvSVJBeVYwVFlPTWg4YVlXaWtGWmtieWswVWJjUDFj?=
 =?utf-8?B?SEx3bTJHVk9qMnI5dmR5cnhacFhoYUVHeURSZEVZTlYxUnVyRzNjRWs2dkFI?=
 =?utf-8?B?cXU2TVBIMFVHRjVJQW9teTNqempWUCtqWjNuOVJKcDdNTDVOUWQ1WEdXNjRK?=
 =?utf-8?B?dzRzd1VwdVNwTmk1cVJYTDhXTWRvOGRMS2J3RGR5OXFWdC9wTXRuY25raWRJ?=
 =?utf-8?B?amYrY0Q3bVEwYkcyS2dvZHlVaHZIbHJ0WnZuT21BbThFbW91SFpFWUQySTdB?=
 =?utf-8?B?T2dJcEJUZFd4RnJtUG5EQ3FSNnRLWUlUM0N0ZVAveGt3SnlNOTJUUVZLTmpK?=
 =?utf-8?B?bnZqcGRSSm9zZElzeGJyUno3Z3dEeGp6ZWltbktCNDY3TTQ3bFFVRTJQWE5x?=
 =?utf-8?B?Y1p5ZFpZTmpiZzBkYWdqNWhva3ZzMnEzWTBiV2c4c0dpTmIwaXd5elQrRE1a?=
 =?utf-8?B?UDdxUm55UFRGQ2k4a0hwdEtlNCtTaXRuQTRoTXdnWlNndEpiOWpvcDB1aWFW?=
 =?utf-8?B?WkpOV2R1aUVkWGx1M0hXTWdxMVlYK0dYeVBpVVhVV1M2RG1JejRwMStXNTk5?=
 =?utf-8?B?WXdIazdhR3REVENCU3YyV2RRTDRQUGtUK1NDU01xeFR4cDBpY3JiYVhTZzE2?=
 =?utf-8?B?SG5ZK0d1dmhPcDQ2S2EwOUF1ZUQ0NVFGcmhWU3RRRTcrc2JLNERRd1BpL0Zl?=
 =?utf-8?B?YnZXWWFpOEU2QzVFTXNzY3RJSHVkeWJVNTFNVE91Sy9ERllEMnlZSDdDTlJU?=
 =?utf-8?B?RzIwTWJRclVlcWlrZFlnVWx3ZW9QanZOKzZkMDBpQ3R3QWEvdE8yZjN2blRp?=
 =?utf-8?B?ZWwzbEFpa2FOYkc5bnZCaHNCMlVyNVNnM2lsM3p0R3BSemFOMDBXR3ZvVVhy?=
 =?utf-8?B?eUgvVVBMT1pnZFJvQXl3NlRQaEhtNnhsUUJqZjRTeVRSdnpqbnVOUmlIazZv?=
 =?utf-8?B?WjVXOGpwMkUzc1RESm1PdFhobnBKVmVBeFhscVczWk5OWGtPTmpkNURnYXJ6?=
 =?utf-8?B?Uk9hK2hDLzNqRC81a1V4QjJIVDdKdE9wK1QxYzQ0VFh4M1BTMVR1K3I1VEs3?=
 =?utf-8?B?ZFYzb2RteU5PQjk4NnJjS2FaYXYzY0x2bDVBSVlJdFhJTHF5SHpBT095SGhW?=
 =?utf-8?B?NkxOM2xPdmhLc3Q4dUN4RHNIQW9kcjVRaE9xTEV6RGk5ejlJMGxvZSsxd1RK?=
 =?utf-8?B?LzRrU2FPZmw0MGtrTGk4ZVhwNW11NUVDSDdwbnFtdE9PVUd3OWg5eFVEMVdV?=
 =?utf-8?B?UFF6YlcvYWxOd0kwcDhyY1R1Q2lmU0RQRmVhaUUvQVhOZVRGNFhlaXRhOFJu?=
 =?utf-8?B?Y2ZWR05rN25JK3ZHWjV2TnlXWk9pMldqR1hCQ2E3WEJBNTNUUWVYVXQ4ZWVF?=
 =?utf-8?B?Q1NoVmZIYUZwa0lWeFE5M2o4eTNMZVU4QSszbXBYcjRxRThuQkZ6dEpJdXBQ?=
 =?utf-8?B?RnN4NGhYVGdaRUhGeHp3UzJmWWp6Yks3RVI0SFdwZHF6R3FYWGhha05IMnVB?=
 =?utf-8?B?a3JqTjluMDFTSlB1dFhwQ0J3eWdWRDdnYitIN2tVb1lraEQyLzZENndrazB2?=
 =?utf-8?B?QWpLNXpDaTdjM3pjLzd2RkV3ditPbDB4WWFwOWpXTmFaMUt5RHN1aHIzZzFE?=
 =?utf-8?B?alhXM0F3K2Vidm9IUGx4VE9vQVdhbm93Tm11c0dZTnAzZTBTRkdTb1RyYUUr?=
 =?utf-8?B?bC9pYmM0bmVyZWw3MUYraVZReWNza25rUnQyaTllMXY1TjVUSEZ2UHV0aHdS?=
 =?utf-8?B?dnBsb0kycHJIdjRLZWZNK3R0ckVsNXJ6NzNPQkRORzFKUzlJYVl1cEoxck1y?=
 =?utf-8?B?R2xPa2dLUlRLSUhtS2s2NnFzbHNNelFSU01uZzZSZlZzaUc1eDNXS3d3SnM1?=
 =?utf-8?B?Y2hkdlBHa0toNE9xSUN2R2hoTExaYVRaNDZvTHN1OFgrZDZlL09jREJEbFJ0?=
 =?utf-8?Q?XPCwFNFUj0aey6WeCEPBdHI=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3f7855a0-07ca-44f8-e57b-08d9eca54fd2
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB5587.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2022 14:55:00.3553
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qLswmzQgrSLREnoh3ANEIhhBNAeRMYNnKvD3Z/6PzH+a6zMnO0fMoQgSyilAbpxpFX40SKI0iZSB3sTvgBtMhA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2240

While the first two patches deal with a long standing annoyance,
the last one covers yet another bit of information we can retrieve
and log, for reference with / comparison to other logged data.

1: skip PLATFORM_INFO reads on family 0xf
2: skip CORE_THREAD_COUNT read on family 0xf
3: also display CPU freq for family 0xf

Jan



From xen-devel-bounces@lists.xenproject.org Thu Feb 10 14:55:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 10 Feb 2022 14:55:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269871.464015 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIAr0-00041v-9q; Thu, 10 Feb 2022 14:55:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269871.464015; Thu, 10 Feb 2022 14:55:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIAr0-00041n-6K; Thu, 10 Feb 2022 14:55:26 +0000
Received: by outflank-mailman (input) for mailman id 269871;
 Thu, 10 Feb 2022 14:55:24 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=T9Dk=SZ=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nIAqy-0003wV-C1
 for xen-devel@lists.xenproject.org; Thu, 10 Feb 2022 14:55:24 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 77f861ee-8a81-11ec-8f75-fffcc8bd4f1a;
 Thu, 10 Feb 2022 15:55:22 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 77f861ee-8a81-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644504922;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=OIrI4v45rhf+U0BJx3jgsFmjum3Aw3c90TdrRj6IJow=;
  b=BcxsJYr2SSZJHYzSsaVQlgQuXvuWQ284XcgBGRnrALU1tvvwAGyD/dJa
   jhxYDmtFHI3VS84ZpIZw2kFqC6QzCaa097VXFnlMWEqvmjdUM76eRZX44
   4t+Zt378GS4G9mdmHPvOH605MCAkdvZu8lxsaK+IDvgQ2QwAtQkNzxJr9
   4=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: /advrcgPOSW1eDgZPudefTPu78u3s+9WmbaR8HtTaNoCRq/AYkvTUdqMyrlIyWXGljzmSs9gUD
 j/jvzAS5cfcygAIW2Yrx8Ss+0QCV+pjMJSw03VPw1Oan56GtANYgZ+HroYc0HisQcgq6Q2hQ+4
 j0eH6Xln55pQWFopf7pTJ+tnRxgIzGjUyVxacxYZAga1XAR3OWBJXmXI+yCJV5pt9cGGKHgP8b
 zZG7fs9eJf1B/HMZPAklh9btAN5+Ma2CnNWLhXEDRPFcEkdvT8aCPhHdMyRwJeFufvNTfegfw6
 FyZwIx44W8VLhMKiCTGi3yUc
X-SBRS: 5.1
X-MesageID: 63932629
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:iaHsDa75UX3Q1slixJoORAxRtI3AchMFZxGqfqrLsTDasY5as4F+v
 moaX2DSOayPazanft51aIuzpE0Bu8PUmNNjQQQ6qXhhHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FV8MpBsJ00o5wbZj29Yw27BVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z1
 9pVrp2QTlkVP6zL3906VBVcGSFvFPgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALNs7kMZlZonh95TrYEewnUdbIRKCiCdpwgmxh3ZoQR6e2i
 8wxSScxdx7sSUBzK2g9IY0ThsKzu1/gSmgNwL6SjfVuuDWCpOBr65D9PdyQdtGUSMF9mkeDu
 nmA72n/GgsdNtGU1XyC6H3EruvOmz7rHYgWE7a73uBljUfVxWEJDhASE1yhrpGRjk+4RsIaK
 EEO/CcqhbY9+VbtTdTnWRC85nmesXY0RNNWHPQ77g6l1KvK5ECSAW1sZj1GbsYvuIkpRDgp/
 liTltjtCHpkt7j9YXuN/LCZhTC/Iy4YKSkOZkc5oRAtuoe55ttp11SWE4glQPXdYsDJ9S/Y3
 D+StykegOsvjM8MkJyc+lzDiTK9j82cJuIq3Tn/UmWg5wJ/QYeqYY209FTWhcp9wJalokqp5
 yZdxZXHhAwaJdTUzXHWHr1RdF28z6vdaFXhbUhT847NHthH01qqZshu7T53Py+F2e5UKGayM
 Cc/Ve68jaK/3UdGj4cqO+pd6OxwlMAM8OgJsNiPN7KihbArKme6ENlGPxL44owUuBFEfVsDE
 Zmaa92wKn0RFL5qyjG7L89Ej+N3mntknTuIFc+qp/hC7VZ4TCXMIVviGAHQBt3VEYve+FmFm
 zqhH5fiJ+pjvB3WPXCMrN97waEiJnknH5Hmw/G7hcbYSjeK7FoJUqeLqZt4ItQNt/0Myo/go
 yHsMmcFmQGXrSCWdm23hoVLNeqHsWBX9ilgY0TB/D+AhhAeXGpYxPlDKcVnJ+R7nAGhpNYtJ
 8Q4lwy7Kq0nYhzM+igHbIm7q4pndR+xghmJMTbjaz86F6OMjSSQp7cIpyPjq3sDCDSZr8w7r
 +Hy3w/XW8NbFQ9jENzXeLSkyFbo5SoRn+d7Xk3pJNhPeRqzrNg2enKp1vJncdsRLRjjxyeB0
 1rECxkvuuSQ8ZQ+98PEhP7Yot7xQfd+BEdTA0LS8a2yaXvB5mOmzIIZCLSIcDnRWXna4qKnY
 ekJnfjwPOdexARBspZmEqYtxqU7voO9q7hfxwViPXPKc1X0Ve8wfijYhZFC7/QfyKVYtA26X
 lO01uNbYbjZatn4FFMxJRY+arjR3/8jhTSPv+8+J1/35XEr8ePfA1lSJRSFlAdUMKBxbNE+2
 e4ktcMbt16/hx4tPorUhyxY7T3RfHkJUqFhvZAGGo77zAEszwgaM5DbDyb35rCJaslNbRZ2c
 mPF2vKaiuQO3FfGfloyCWPJjLhUipk5sRxXyEMPegaSkd3fi/5rhBBc/FzblOiOIsmrBw6rB
 lVWCg==
IronPort-HdrOrdr: A9a23:9sm/w6syedNuE6wE+h1VWyBK7skC7IMji2hC6mlwRA09TyXGra
 6TdaUguiMc1gx8ZJhBo7C90KnpewK7yXdQ2/htAV7EZnibhILIFvAZ0WKG+Vzd8kLFh4tgPM
 tbAsxD4ZjLfCdHZKXBkXmF+rQbsaG6GcmT7I+0pRodLnAJV0gj1XYDNu/yKDwGeOAsP+tBKH
 Pz3Lshm9L2Ek5nEPhTS0N1FdTrlpnurtbLcBQGDxko5E2nii6p0qfzF1y90g0FWz1C7L8++S
 yd+jaJqpmLgrWe8FvxxmXT55NZlJ/IzcZCPtWFjowwJi/3ggilSYx9U/mpvSwzosuo9FE2+e
 O87isIDoBW0Tf8b2u1qRzi103J1ysv0WbrzRuijX7qsaXCNXsHIvsEobgcXgrS6kImst05+r
 lMxXilu51eCg6FtDjh5vDTPisa13ackD4Hq6o+nnZfWYwRZPt6tooE5n5YF58GAWbT9J0nKu
 9zF8vRjcwmP29yV0qp/VWH/ebcHEjaRny9Mw0/U42uondrdUlCvgslLJd1pAZFyHo/I6M0kd
 gsfJ4Y042mdfVmH56VMt1xNvdfOla9Mi4kD1jiVGgPNJt3c04l+KSHq4nc2omRCeg1Jd0J6d
 L8bG8=
X-IronPort-AV: E=Sophos;i="5.88,359,1635220800"; 
   d="scan'208";a="63932629"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Yo/TcMP8AO0Op2oH8zIfCxcPCAdf/HKD6nGIohPxDdnxuNM7N6D+oOPwisa9+/EbfsCfRWyVHCZtTWkdcyWjfdMhEGS6wVLe2w2FCRKG+pQYD47vRy9Ozala1ubIF7iqyPemQod59kCbbHTBnmzYc448szAWjNY0mY/Gg6Zvg18C1A3RgPssMyq6OS8bA+iKYsXbBhwvBXwVSLI/4SHJ7T1mcGKvRAW9F92D4Sghbfnekt3h7AcA7IFqFoz5TfEKlBLdanppCDGiAsarS/xs4G065J+LuTFeAe0yBM4hEuTZc8i75Yt9QnWMbl2wcxyUraNPA3mYKutaXlIClZT+cA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=wqsJ0cvW4V2TbQ6w9+9ypQm/1w7jmuGw0wivrIQlrSE=;
 b=USsFlN56TTlP6U7Qg0F2tiSktvcFCNRA1QjBq0OLl0s6yCIoSkvXJNGD8VQoOoCTFktSW8ik5s5nDeO70n9OfvoNGARZnm2QwlLzVHCQIpIgEyOtRfjA8CCatW2Y/iZJEcS6cfGYli1sO3SgSXvJxbGXw0VvnXupB+1yHqzjni+Aa2EyU6ZwaMQ2nCRaMp/+7oErfXqQU0dVNblkQKRPEBuHTSXrf+GieB1cmUfe3R3tU6A5O4jwXvyhz5sAwnJjee3oEts+s9a9D2DAzDvpufOf4z2vhVeYKhie59bdcK+/rBPenuZAqCdSBY7mqTGp2QLPF73ZCwSl7NygROjDPg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=wqsJ0cvW4V2TbQ6w9+9ypQm/1w7jmuGw0wivrIQlrSE=;
 b=YEbzre9A77A21mzRk6qP7Rb0jND7pingxCztS/QpdV+20xmYJqTrlpDXDSuBrKaoQp1qzUfEsAgeD0Ww+lSkBna5UlU0VDDP3YZhv6RLOSDDjx4qjRDnnvt0W8QJa305jD4N2NlNWW5rz05ZnSzrhbwWAtz0ge75W3p/muvsPuA=
Date: Thu, 10 Feb 2022 15:55:04 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Qing Wang <wangqing@vivo.com>
CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>, Jens Axboe
	<axboe@kernel.dk>, <xen-devel@lists.xenproject.org>,
	<linux-block@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] block: xen: use time_after_eq() instead of jiffies
 judgment
Message-ID: <YgUnSKJD9vs3qrTC@Air-de-Roger>
References: <1644481765-14435-1-git-send-email-wangqing@vivo.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1644481765-14435-1-git-send-email-wangqing@vivo.com>
X-ClientProxiedBy: LO4P123CA0174.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:18a::17) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 539fb04f-738b-4ab0-b29e-08d9eca55543
X-MS-TrafficTypeDiagnostic: DM6PR03MB4779:EE_
X-Microsoft-Antispam-PRVS: <DM6PR03MB4779FEE68F99C9F817E595648F2F9@DM6PR03MB4779.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3826;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: cuhtI+hoTNyNK9pNBlfEJBHVaH8DqCSpDl6awezMBj1tsawWAODyEoNksghIW8qLiUct5nZ/KA7O+CTabCMK1fTmU3HyVlhjKr9ac1R2dPt+n3F3+YrXUrV2rgCPMTm0nHRjguSbsaIjVkdm2xOgkkktdq9TAqScA/DGZsr9CNeO/JlN0UGeR8Zcpy3FkEoH866Tf7Z7fTDOYA3jwiyJtU1wklrEqqj9E58OjOY4Re0+iuPoIufu3tqHwmy5xJQWv1ziN6aLo/n7k4oZa86xbsl+vSH5tDjtlWlkj/zlQW87SbFKKW399N4zTGxNNuaOlscboEYX7s68LYN7N9gAkKP2fkVkLL+lmlAXOXGlZRDElzt8gsmXivUfWlb7uXUvN4Z4gg/tOE2IEzyNa2oByNc0lgCcQaacchXPPUXACkeKMhkCgEjiCOwOUvHJUCb0lbCQugP2rxTi7yhJVLJH3iKYKpIGDa1ejjALPUXAjFIP70MMmwALX+yzzzehLksEEUkeLW+0Hc7aUNa2Xt7ncsG3H2nJsMDZVJLkhvTzUsSEOXABy5CqDJQ4aYH06xuvcB7kscYciY7yP1IWG0dIqzij9zj2meo4Mu6dt6ABExNM76tkM2cQ7IOzVJ1K15qN2eTSTSdkk08MHMVSXMv0S0ka6ceVkcFswSih5LYiDhhDssQHJ6uOHVr/tkCXHCz9Pm6rvJTSi3cJbfX1wtytXQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(6666004)(54906003)(6512007)(5660300002)(9686003)(4744005)(6506007)(33716001)(6486002)(86362001)(85182001)(316002)(66946007)(6916009)(66556008)(82960400001)(38100700002)(4326008)(8676002)(508600001)(26005)(186003)(8936002)(2906002)(66476007)(21314003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TmRtR1Irb1cvYUlEaXJ3ZVVzcGJlZ0hWbmsxRGRDSHBnZEcyQVZnVlZJT29S?=
 =?utf-8?B?NjJLY2VmK0NncTdmb1hSSXJXQ2Z1VlhjN0NsQmhoWVVGTFd1VXpaa2VtL3Iy?=
 =?utf-8?B?VFhheGZIaHhxYzAyTVZ1c0U5N3Z2ZTBnc0l5bFlKUkxmRVo3TWRhU2xIbFBh?=
 =?utf-8?B?bDc2alkzNmN3SnU4L3B3QjQ4bkJZSVgwMTV1WUxKc1hEZVErT09NenVTZWdz?=
 =?utf-8?B?cXlmdTd2d1p1NXNGZmVVZzFRckZXd25oeUYvVyt0OEFFOVZTc0EzVm1OWGRt?=
 =?utf-8?B?TlpNcDV0S2YwcnFIWm1meGRuM0VlaTNuT0pDcXA5K2pKdEhmbEtRYXRZVGFX?=
 =?utf-8?B?NWw5dlhXUEFvRWRwRFZhcVdYZXFnSEZOb3paUUprVEhhMmV2MW9Bd0hJVnVS?=
 =?utf-8?B?bFhsODVNZ1ZON1A3K3FyUndyajlQcmdYcE5FTCtpbjZ1YUlLK0M0b3c0MndJ?=
 =?utf-8?B?L2d1Q0gySmNpZ2VhazdYT21zcW1sMkhKY0RrZGZEV3JYa1kzNThXRDNRQzZ5?=
 =?utf-8?B?V3d6UkhncDMyMzBJci8rSzgwR2hiVGNJM29UN0xKZ2Z5N3pGQWg1MVVZWGRU?=
 =?utf-8?B?aGtVUHJPOEp3VU9HWVBxY3gzQTFoRkZhaWdBS0RsNGVRV0YrRGxZcVd6a2dR?=
 =?utf-8?B?S1BNQndLNyswRnlmWWdzSXZZNHYwNk5DdDBJMnFNVy9LUW1sUmhiL0FZclpl?=
 =?utf-8?B?UU96N24vQXk2Nk5zdEhBMVFIVEo1clZaeVFZaE0vc0RGY0FGM3dIcWRoNi9D?=
 =?utf-8?B?bXc0bUJ5NVA1eUFVYnNuaTdoU0R5dnYweVdxWnE4dWVEeitJUEwrN1liZlFv?=
 =?utf-8?B?MW43Y0FlTDNRK1pYTkZDczdGbVh5WnBXZDA3dFlCRkVqZWV6dDBnZHVCZExF?=
 =?utf-8?B?R05rVDVkbGtWckpGZDNuTElxYWwrdGdFeHRGMlVQNHQ5SEQvK2lIM0F5YW9P?=
 =?utf-8?B?dUVmbDNiVTZFdkI5L2x3NEdDVlRQYnlDQmo1QVFUd3RMWEZIOVpsWHd0UDU5?=
 =?utf-8?B?WkVSSm91Yjg4Ui8zYURZdTFDeGpRUGhBR2wrMGU3ZWhnVm1MYjNpVFc0cEp5?=
 =?utf-8?B?Rm5yR1RLSHY2SDEzUUN3bi9yVk93SFNnSHpOc0dVOS8wR1dZTTcxTzE5Nytl?=
 =?utf-8?B?UENtZmIzT1J1OEcxUFR3djN6N0xMVUlwTnlQQnpEU2JEVzBpTjVrdDRpUmUr?=
 =?utf-8?B?MytYbFBzdHJKUHRqOGpFSjdTVDhvR0R1S0U2UE5hNWVuZzBiQzJFK3dEbHla?=
 =?utf-8?B?bGNEcjhHSlU1ZGxZc3d3SmQ2eHg4cCt5eGMyNTVaVG1TZWZXYWZiWXpGd1Zm?=
 =?utf-8?B?K2xpNzBpN1BHWFJwY2FWNitiNGlHVjFSWHhod1ZYTUVHT1o0MkRSS2sxc2tO?=
 =?utf-8?B?NlVQQjUzdVkvZk1WTndJbUFqbVNGdTZaakRKNTcxUDNlMXJTR29sUXgyUVVw?=
 =?utf-8?B?UHRUTFliTWxsVVBpVEMzeWtyN3IzMHlidjRNeS8vcnhuZDdXYXJYbnJQVGcv?=
 =?utf-8?B?NkdZdVRMdTloRUg0NVFOSWs1R1BkK3M2NTdyKzBuOGxuYm5nQlhsVFdZMmxa?=
 =?utf-8?B?aTJaYTBhOW9Da2lzTFFIYUw1MU0zckxtTitsRHdEYnAzNFZ0dDVhWlJPemo2?=
 =?utf-8?B?RkVxVHpoMzN4bCswdmt2UVI5OVh2bm9KbjVrTUh5bmtSSThYTGZHVTNOdjcv?=
 =?utf-8?B?UnlVRDV1ZzFIQ2tjREhQTlhrQzlaMTNWejZHai9ueEJYdHc3bm1lZ0RzcWZy?=
 =?utf-8?B?WlBPRHM0QjlmeTNUcWlXN2JqdjJlbmhSWUEycHVYUHdUWVFEQmVvMkkzKzZx?=
 =?utf-8?B?Q0wrUkNrN3JXTmhRaXlNMzFCZTlIazl1QVVuRDBUb3lsbk8rc1VobWVYd3pU?=
 =?utf-8?B?cjZybm15eXdad0FjU2VubTMzemlJdHJrRXBCNnNpc0FGSWdyZk5YR2pYano0?=
 =?utf-8?B?MVAwOEV1b3RxMHovWCt0Z0FLZmIyNHp3VlgyUUQ4ck9Hd1ZKZUpnMUthRkxv?=
 =?utf-8?B?TDBVcWtubDkvU05URy9JN2IzMWkxOFIvYTNuUHFxN3FJUEF6WmlCdzQ0V3Q4?=
 =?utf-8?B?TFdXbFBwK3plbUhGWDArSXlMN3NFemd0enROa1dnOHF6SlhwNTlQSFN6cjVo?=
 =?utf-8?B?TTd6K1VVanlYRXYxVmRUUHpoSkhxQXNnZjhYampaTHV0b3lRQzlKT0E0NWYy?=
 =?utf-8?Q?21ftG8iLhe/Bc0vJO20d1QQ=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 539fb04f-738b-4ab0-b29e-08d9eca55543
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2022 14:55:09.5456
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: r7RR91h20gMn3I72PieFiHLExwxnIkHj+HKRbzA2xqtztUOf92uCDt4aVXtPLEqJBpL1rrhdUmaxjbYPHR9Cog==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4779
X-OriginatorOrg: citrix.com

On Thu, Feb 10, 2022 at 12:29:23AM -0800, Qing Wang wrote:
> From: Wang Qing <wangqing@vivo.com>
> 
> It is better to use time_xxx() directly instead of jiffies judgment
> for understanding.
> 
> Signed-off-by: Wang Qing <wangqing@vivo.com>

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

Doesn't look that different to me TBH, but if people find it easier.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Thu Feb 10 14:55:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 10 Feb 2022 14:55:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269882.464026 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIArW-0004jJ-I6; Thu, 10 Feb 2022 14:55:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269882.464026; Thu, 10 Feb 2022 14:55:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIArW-0004jC-F0; Thu, 10 Feb 2022 14:55:58 +0000
Received: by outflank-mailman (input) for mailman id 269882;
 Thu, 10 Feb 2022 14:55:56 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=4tMu=SZ=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nIArU-0003wV-IS
 for xen-devel@lists.xenproject.org; Thu, 10 Feb 2022 14:55:56 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8ca15171-8a81-11ec-8f75-fffcc8bd4f1a;
 Thu, 10 Feb 2022 15:55:55 +0100 (CET)
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2056.outbound.protection.outlook.com [104.47.2.56]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-26-tmHgBpWCOYuVdGtyZDh-cA-1; Thu, 10 Feb 2022 15:55:54 +0100
Received: from AM0PR04MB5587.eurprd04.prod.outlook.com (2603:10a6:208:125::12)
 by AM8PR04MB7443.eurprd04.prod.outlook.com (2603:10a6:20b:1d6::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Thu, 10 Feb
 2022 14:55:53 +0000
Received: from AM0PR04MB5587.eurprd04.prod.outlook.com
 ([fe80::54e:e7d:545a:da84]) by AM0PR04MB5587.eurprd04.prod.outlook.com
 ([fe80::54e:e7d:545a:da84%3]) with mapi id 15.20.4951.019; Thu, 10 Feb 2022
 14:55:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8ca15171-8a81-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644504955;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=eUtuGMPyAObdf0J2/GPNj4BgwRzlxjTEV6wyVRInaNs=;
	b=JtUHnqR6JqKfYBMPMmtGYMPmwLDPa/y5rXL02be2GHxliIXct8U2AMq3XVddxY89es4uhw
	/NPwiPfrYoAElydDL0Q/misPZ23k8cp9NYHjEVC8Wa0vY/tDgSoRycVp0RdmS0kWibm7Ai
	SYNOOmP4WcJere0zVOgBXtkXjJhRoDk=
X-MC-Unique: tmHgBpWCOYuVdGtyZDh-cA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=BJAKDzwgRvv8cJ7D4aRFUNlUpbWv1FTaINtIVn7BHLbTIBK0wixv4c8huL8watjjoIZ3BPXh82v5a5r2/JnQoLthu6Y7o+yfy2leRJOXUAZ8D+FDuje/BEij0L5RbW0eM7nWgfA2t5G/fxrlIXOGI3yIX1eFsiIetDsYjdSrNalun5Q2Gmux3xw4LacQRc4Ve7SCVPbPqhqsr5qqXvpR6Q/AVK5zFzNDijUAHDF1E/zYrxvjUWd6BYjFcvKQCHSs1oXg+/ugLDV4mBiAXgFDfu/ZwB+yBagCj0VWl6mFeI/NXYHWK3x5pkHQ/BX5YpNaHX8887M/a09LOnAwLVzUaA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=eUtuGMPyAObdf0J2/GPNj4BgwRzlxjTEV6wyVRInaNs=;
 b=HlRoy07vaIM5qMBm2TSWgpFCYJ1ewdZGeQjIBzPQk+xnLWUovYCndKjMoukVX+JSVa9zkAkgzFn9299gyKAsEju+zo2VBVP+HDvMt1WBIHd5HjoRunjGL85EWp66lwsJl/ZLh1F1ir+hLJhuF4QeuuJmplLMnpAvEORyrGXneYbKbxDPixhkJGqkzI5zvfhbzc1BQTWffFIZHYWIFrj4Zmq/XHwDSEaH0kSK6t5xDAj18FSPWu1FYHRPRL2q7gZjIZ3dhre55Ce/R2AKggcg/G+QdLRQTpDdEFuCemlax1XPxB5JJY2VzbzVL+sWcs8l3FHSbKX6wkzuoLT2IuOWPg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <6f56a75c-cd68-0dad-b1ef-a3421271ee47@suse.com>
Date: Thu, 10 Feb 2022 15:55:52 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: [PATCH 1/3] x86/Intel: skip PLATFORM_INFO reads on family 0xf
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <5d275d7a-7751-af19-db4f-d91e3592d30f@suse.com>
In-Reply-To: <5d275d7a-7751-af19-db4f-d91e3592d30f@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR05CA0025.eurprd05.prod.outlook.com
 (2603:10a6:20b:2e::38) To AM0PR04MB5587.eurprd04.prod.outlook.com
 (2603:10a6:208:125::12)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2b8a3236-040a-4120-7573-08d9eca56f75
X-MS-TrafficTypeDiagnostic: AM8PR04MB7443:EE_
X-Microsoft-Antispam-PRVS:
	<AM8PR04MB7443831F1EE3468EDF20D709B32F9@AM8PR04MB7443.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	MsRv84qwoEk3Ic6kSsJbxS13Vx4wTSJD8vkIHaiSRGP+8Hl4sBX2/Ffyp7A4WpTxXJaVqUySFNeiA40X3HAKfMdL5agKGetsahbUhvW9xOpeyjdSCSJu6DP/fq+wibw3pSmDBFP0OtWio5LyrBgeeV8LKnzzM2lXa3b2nE5sneecOi3f94YMAMDsq0LNbPags9VW3M4qALCcwir0mI8a8Nb6HzSQOGREJmlRdL88rwS43n2Dr73N1Qd2kXQjRnGBrGTO8OOWyeKFgW5BxUShbN6jtvpzqlWCIswwa9QdWimncdOl1BowbAjSqBmXXeTlgJUMV131iH5kaWJ1WLRFhUA0aAZGk7OF3TNPFlMC7ag0QL42OTfcH+/RNR7SvH6eKrpBnumiUmkrTONrqia2gXF3LRCUu5PQQ8VK12IgpVoGPXmu22nN/T10P4xPWiLds1qY0vgnpMA3iF7APRO/O1gxce243cxOs7qW/F3bF0Fc0zPJC0aucaha7GDdpjavjOtFfI1WA0GNeq9upNQ5rceFM6v++BTp9EJ602PvQ+NEpb8piH8DzLwaDF87T1GsWPVqWGeyT5W5z4Zxttmck64HfpZCNLoaUMlZpwRR/kVvoe6tbc1it5kbnS2IeuB+RszlWrSZDcOGHK6GGuatiAWvr+vT/C3h1BTpHOUPIXAPJeXWO5a/nONyv6Skd+7jfPSnzSBVRMUKo5fMakFG4YBv6Ue0CwrVEVTxNh6jo9YdlgC1w3qR7qb+mGULRr5P
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR04MB5587.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(83380400001)(6486002)(186003)(2616005)(31686004)(26005)(6512007)(508600001)(5660300002)(6506007)(8676002)(31696002)(36756003)(8936002)(66556008)(6916009)(66476007)(66946007)(54906003)(316002)(86362001)(38100700002)(2906002)(4326008)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RXV4VzFmck9lcnZzZ0Y0c0ErYWFxWFZFTTZJV0xxTTF2QkFROWZQYmVybkNY?=
 =?utf-8?B?N0RBd2xTVVpNWksvSCtZaUVCUUVkQWRhUGJ4Wk9DM1pGakF0aVJ1eEpuS0dJ?=
 =?utf-8?B?bm1zSXRNeWEybDM5eWw3K2o5WGdlV1p6Vmx4ZFArQituckdCZ1pZTi8ya1d1?=
 =?utf-8?B?dW5wemZMKytubThWU01TTTAyYnZSOFJPcHJ4b1dBMTAzZThWeUlVOEdWMWc1?=
 =?utf-8?B?MmdvcWZqRlYzaHI2N25rN2RGWHVzL0U3SUdrOGFNcUcwY3RjeWNib25vaWMr?=
 =?utf-8?B?V1RHb3FhY05GejVHRldvY2lGc20vQ1JpcG1YZE1UWGU3TlZTZGdtTVgyMGdK?=
 =?utf-8?B?K1IzME85Z2VmR3h6UmhRSU5hWENFbmt1RHptWitMYnFxY2U5SDZHNmdVTDlK?=
 =?utf-8?B?Q1FDMncxRkdBaXF0Y1dBR0M2RFB4cWhBN3AxM2VFbGNJQ21NY1JUL1lnWnZZ?=
 =?utf-8?B?VTZaN2lyaU02V1BXcWMvV2FuZW9tajlpMG90RG0rL25sUFBmV0xRQ3VoN1Mw?=
 =?utf-8?B?YkNMZG5Ickh1aHA4ZlFBR2xaTnUyNFJPYlRoWFVnbHFDeTNnY0Z1eTczRDZW?=
 =?utf-8?B?aWlVRkovaTRtV080TzJhdnArbk5OdEpEdE92R0p5OU9nUU1NM3lkaTdpamxW?=
 =?utf-8?B?OUVsUlJkRVN3eWtEak5RV2xZZEIydVVOeXd5TVpRdm1XNlFQVUprVXNOMlRt?=
 =?utf-8?B?UVVaQllpdHRuM0lHTGlndmViTVFEYmk0citWVjlHL2pscmVrZVVvNmZROWYv?=
 =?utf-8?B?Q1J2WjgvZ2V2SGMrWlVXM2RiMXJISFN0NVBLdThvT1U3Y1R0WkF2QWZFL1di?=
 =?utf-8?B?bmhMSmI4ajZ5b1F0c2ZlWnpGTkFJQWVRekNESkVyU0VGd1lRZ1dGc2wyc2lr?=
 =?utf-8?B?eXYwTXoxMWRQUkptRjVTWGZodzNSaDVXODEyVzNLRVVDUzlyaGQ2TTRHaU10?=
 =?utf-8?B?T2c4VThGbTVZK25vTXJQd2NLOXMyYW9keU9PR21qV1Y3RHVQNEY5N2E5MFRL?=
 =?utf-8?B?bEI5OFdVUERxUFNNOFpOYkdFZHJwd1NFQ0FvUkhRYm9YcktPb256bmNPOG90?=
 =?utf-8?B?Qkp3MU02dE1jNHJTS2NycmMyNjFhRzhpVHNNRFdrbHlMWk9uelhZYTFVbENN?=
 =?utf-8?B?UUlDT2lWeDRKWjlDbWwrazhudDF5R29YNENvZ0hydDZUSnFRdWpyek9Cczk0?=
 =?utf-8?B?NW5rMW5HNmE1ZEhYY2FZbHAzcXdKbS83YlBRZUdxN0Z5Z25mV1lkVWUrQTll?=
 =?utf-8?B?UUFQbjgwdTFkaUZML2tCVHdvdkVJN3Nsdm1BZVpISTUrNXg1K0hoVnFFS3JE?=
 =?utf-8?B?RC9kWWcvWWoyK29QSmUrWnNuWFQ2ZUw4RlArcFlURGFkWHp5MGx0MllDSUxR?=
 =?utf-8?B?V25ocHk1UTdPK1RXTWNndXBZMTM1R1gwSnQvK0ZSMnJscDJRbTgzV2pJTHBU?=
 =?utf-8?B?SGJyanpCdXNiTzJBQ0xKN1FnVVJiUjVnYVJOMnpjY3NZTzIyZFpNWlptSDhy?=
 =?utf-8?B?QitUbm5UeGVxdkxEbU5DaE1CYmdsZlYvR0U2VDh5QStURkR2Zm9vMlpWT2wv?=
 =?utf-8?B?cW1TQWtTV1V5am1CcklPOTdocEl2VVR5SnFXWHptS2VyZDZUNnNkTzJtM1NG?=
 =?utf-8?B?bytSS3JhTlRYcG5XVkVTUTFYeTlUU2g3SlhBTEFGVUVXS3ZtUFhuRlNIKzE1?=
 =?utf-8?B?ZHJTMHFIejZJZUQvTHhTSEFlOXJWTjZrQVhwLzlPaEN6K1kvTW1VZnp3YlNt?=
 =?utf-8?B?MUwyZlF2MzhLZUFzdXF1YzNueDZ3S2RtOFVkVUxkb092OFovVTV0NnE5OW53?=
 =?utf-8?B?amVEUTBSdXgvRFpQa2lZNmtGd2loMG5IMk5vTFhRaUhhN2VNbjdqQ0lUK2FQ?=
 =?utf-8?B?T0xPQ0NMNm9KZk9tblU5K2VNTUc2RXBob3h2Y3hJc1A1em0zblQwOEVSb3R3?=
 =?utf-8?B?aVcxRjEyR3N6a0NnVitLMnpIdDcwaWUvVXFYcnVZK3BoNXFvdGQ1RUdLemRt?=
 =?utf-8?B?cUVkZGl1c0xKakpwSC8rcEFCRWZsTkc3NjBTNnZCVUVMd0o3M0t0MHlBWm9a?=
 =?utf-8?B?WDhUdzRTZVE3SmxRWlRpeDRZTmtRUllWUGo3S01mclJhVlpDaWlpQXRKaG1H?=
 =?utf-8?B?YkJ4TmF0cm1qMWNiaWV3TGM4QjRGWXc2VVdwazI1VFJ0bjc3KzU1RUFlcjM3?=
 =?utf-8?Q?ZgzLEBztrA+uKBY/f7uBA40=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2b8a3236-040a-4120-7573-08d9eca56f75
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB5587.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2022 14:55:53.4144
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JF4i5uevj3Us2pG66yQINEkt9v1FCfNkl0nI3kJuoeVoo0WXvy6cNtr2qo2qsk5TQxFBv1nvx3CWjvXceglD1w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7443

This avoids unnecessary (and always somewhat scary) log messages for the
recovered from #GP(0).

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
Perhaps even use "!= 6" in at least the CPUID-faulting family check?

--- a/xen/arch/x86/cpu/common.c
+++ b/xen/arch/x86/cpu/common.c
@@ -127,9 +127,12 @@ bool __init probe_cpuid_faulting(void)
 
 	/*
 	 * Don't bother looking for CPUID faulting if we aren't virtualised on
-	 * AMD or Hygon hardware - it won't be present.
+	 * AMD or Hygon hardware - it won't be present.  Likewise for Fam0F
+	 * Intel hardware.
 	 */
-	if ((boot_cpu_data.x86_vendor & (X86_VENDOR_AMD | X86_VENDOR_HYGON)) &&
+	if (((boot_cpu_data.x86_vendor & (X86_VENDOR_AMD | X86_VENDOR_HYGON)) ||
+	     ((boot_cpu_data.x86_vendor == X86_VENDOR_INTEL) &&
+	      boot_cpu_data.x86 == 0xf)) &&
 	    !cpu_has_hypervisor)
 		return false;
 
--- a/xen/arch/x86/cpu/intel.c
+++ b/xen/arch/x86/cpu/intel.c
@@ -455,7 +455,7 @@ static void intel_log_freq(const struct
         }
     }
 
-    if ( rdmsr_safe(MSR_INTEL_PLATFORM_INFO, msrval) )
+    if ( c->x86 == 0xf || rdmsr_safe(MSR_INTEL_PLATFORM_INFO, msrval) )
         return;
     max_ratio = msrval >> 8;
 



From xen-devel-bounces@lists.xenproject.org Thu Feb 10 14:56:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 10 Feb 2022 14:56:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269887.464037 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIArq-0005EH-Qr; Thu, 10 Feb 2022 14:56:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269887.464037; Thu, 10 Feb 2022 14:56:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIArq-0005EA-Nb; Thu, 10 Feb 2022 14:56:18 +0000
Received: by outflank-mailman (input) for mailman id 269887;
 Thu, 10 Feb 2022 14:56:16 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=4tMu=SZ=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nIAro-0003wV-JZ
 for xen-devel@lists.xenproject.org; Thu, 10 Feb 2022 14:56:16 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 989d30bc-8a81-11ec-8f75-fffcc8bd4f1a;
 Thu, 10 Feb 2022 15:56:15 +0100 (CET)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2050.outbound.protection.outlook.com [104.47.12.50]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-37-5VJ5TEBbOs2s_-h9RH1w1w-1; Thu, 10 Feb 2022 15:56:14 +0100
Received: from AM0PR04MB5587.eurprd04.prod.outlook.com (2603:10a6:208:125::12)
 by AM8PR04MB7443.eurprd04.prod.outlook.com (2603:10a6:20b:1d6::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Thu, 10 Feb
 2022 14:56:13 +0000
Received: from AM0PR04MB5587.eurprd04.prod.outlook.com
 ([fe80::54e:e7d:545a:da84]) by AM0PR04MB5587.eurprd04.prod.outlook.com
 ([fe80::54e:e7d:545a:da84%3]) with mapi id 15.20.4951.019; Thu, 10 Feb 2022
 14:56:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 989d30bc-8a81-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644504975;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=j5zMM3qKdb6oVy6iS2IeBm7vTPi70YImKG2OphmjMjY=;
	b=gwrQP7MHythQtvnvIzAB4mt2BSeUmbB8BVoyWbSkcMN7OfpM6C+kJw1/MAAIV3Z726T/7c
	NXm+gFLuInPnBCRUh0nJUhjFJSw3etN4LkuUJJNHMaGv5IcnlptBkbmJvLKTEb/9C67EXp
	DLfW3ExJv+N3Dw8/OKu52kCba7F7H6Y=
X-MC-Unique: 5VJ5TEBbOs2s_-h9RH1w1w-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=OOL2RxalxbJXiqJO7LoesobC6ldSk3kT9B1nHUf2BB23g+/DpFtvbELlTB3bFHzv4cTX5lyN61Jmy+GHwyLS8ATpeL4qbtLRwWQn38cICDi42wxdWckjCTiSSFN94POmkiS2vRcGr0gSxmme3H3y5fy82Xu+d3WIecyVzHNOtEpd+njef19U2NS+fg2dLu7kjU+scjrRo65gv1diZCnm3E4rhtwVXfzwds5K2uuO46a+a8yEV/Ggo+TQAB3zB6HYAmXzZ60noqc1OZSA9AIbS1v101RXiRl4CTR19jdU1ELgSxn6Vyn6CyTpdwLHrdhw1IsE9vA6UIXvC+RH206iKQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=j5zMM3qKdb6oVy6iS2IeBm7vTPi70YImKG2OphmjMjY=;
 b=nCujtQU5viKNhfguBQQYW87CQHSO150Qk8NkY26zLEm1fny41yDBMJOFcoU3YsjD4/ma6jo72JV1cPVQ+mJTMt3BB0QwGJsnijhNssKK8RVVYJQ1UXfgbiqQgcHQdVDIxeucNjBXkz/lc3wFdqbxuLtdc9VhCW436RUumkXx0KkU/isGTwHXVu4ZiOut46+CW3jt0e/EgzfPlMu2+MPHQ6IDxbwL1/xJ8fIuxs+PDTBv3gqhivZD2SvudA7ebzbLAseQN24rrzhG/3be/FSAfK1MSNR/NjuZ/NdvN6ySbRzRb7aTKW9YI2gwkMwupFfMZnryGdD9Fdzh+Ko8owzaHQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <1c16c2c4-0943-1db5-e22d-a6e1ffe5d00e@suse.com>
Date: Thu, 10 Feb 2022 15:56:12 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: [PATCH 2/3] x86/Intel: skip CORE_THREAD_COUNT read on family 0xf
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <5d275d7a-7751-af19-db4f-d91e3592d30f@suse.com>
In-Reply-To: <5d275d7a-7751-af19-db4f-d91e3592d30f@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P191CA0015.EURP191.PROD.OUTLOOK.COM
 (2603:10a6:209:8b::28) To AM0PR04MB5587.eurprd04.prod.outlook.com
 (2603:10a6:208:125::12)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 8bb6a289-30dc-4b35-f13d-08d9eca57b6c
X-MS-TrafficTypeDiagnostic: AM8PR04MB7443:EE_
X-Microsoft-Antispam-PRVS:
	<AM8PR04MB7443E64E94EF7D011FC7FDEDB32F9@AM8PR04MB7443.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4502;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	C4SyDc+UKdaSHwy8HYua6yKeMfH97RwbRB8cOjqhH0XReA/KcMi+OyScGOmzQpk2Hnx4fSPSR+rj8a3DcQUh125XFTG5MCtja5ow0FTemE4/nlQi1zkruGpZwYNLEWKaaECACHhAayt6brxY2nrLgAccVUP2eOBz5nHT4cXMvzbcnMxOfY3ZfLS8Gti5TP38kQ44UZNU2/DHgLlG5u6Wy7Mwwl8Ys1xr/H6pGMOiHAnXAGDl0OttdRTH34/I2v20BxHYhzp3Z0prBZiUpf655wPVKti1MIMBKIm2+bw+wcAkQSt6nkxP62Si+jG9g8lIyozkVyTxU7UJbedg+FyJ6mprBH1S2QRUIdU4lPRsDy3siTzB5BXYf+GH9iDFh1sQM8neVQy6d5KETzXE1/EuKJhbUFR2B0PBemmzLAraUpozkZRAg/bEwzwnncP/m2Up9YPPOKooot0zkQYHJyVxXz5ukHK+ZMvOkjwsLhbZNPeGHsqLkk7KEd5MOWPbBCer0BSkqZz9y1Uy5EbJY00uZh4HE+aaQF+60QnhhFZge4vnreERjQbQMOGnI1mItyaii6mL/Gf2zj07sbnQFr4u+qR+Xv4mcS+FJAkmeY2Ja1pjBPCNEPqH82988Q69AC5vnDGtcrA9BcwZ7z3T59OdGg4Z7j2dZul3EuSOIEdKysZiA3sm4tLh8qeO0cVQfWTr5V9sCI0GH5beqWNdxXs4rK7GWYQE6Yxaug7dZ3ouJb4=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR04MB5587.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(83380400001)(4744005)(6486002)(186003)(2616005)(31686004)(26005)(6512007)(508600001)(5660300002)(6506007)(8676002)(31696002)(36756003)(8936002)(66556008)(6916009)(66476007)(66946007)(54906003)(316002)(86362001)(38100700002)(2906002)(4326008)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VndrRXN5TVRKNExGdTdzYjRDWFllc1FCcnlGRWU2dXBSSXZxQWJ2VS9ka2Ri?=
 =?utf-8?B?d3owV1JZWEVrYmRsMWxiME0wUEUyTXljY2FEZzkvV2p3VXR2TFdSNlNEdmFB?=
 =?utf-8?B?K3U2Q2t6c09RYXkxSkQ5Z3RpSnMrYk1zOXlPcXBkL0pNSWgvSm1uOXI0N1Ba?=
 =?utf-8?B?ckY1QVRxejNuNEErU2RXallIZVJZTzJjV0JrWlJLN3lOMFZJWU1Qck5vQzhi?=
 =?utf-8?B?NU9mZHpBTDAxWFNOenhWTW1GazlzZDVmd1FRcUZHdDBuUXJITWI4Z1NUc1Bx?=
 =?utf-8?B?dEJtYmxMZkgxeWkwUmtCZTc0MVZIT2QrL2JqTWYzOTAwQ2NYSmpYOS9BSjJ3?=
 =?utf-8?B?elZJR1l2aDBPQmVNeUJNSDVOcy96OW5wNzBiZ2JJV1M2dm9NbWMyaHJCazE0?=
 =?utf-8?B?cTVBc0xXYWJlcWxGcHVVUWFRRVFTUytOd2o4MkRLMkZmRFlLTmYzMk81YVM5?=
 =?utf-8?B?ZWhsYnQ2Z2tVQ1A1VHhET0RNTnA1em5neFFwNE1weGNPbUhJM1Rja29JOE1t?=
 =?utf-8?B?aTVhRWpVSktaUDV3TitmSkdZa2pEdkNGRTF5czBLdGx6UEJ0dEZIU2dXTmc0?=
 =?utf-8?B?OVRoQlNWTmNjSnV1T2QzVDNoQ2Y3NUpiYkRiSW51azNkNGpnUEo0U1p3ZXY1?=
 =?utf-8?B?dmZpRitHdjJyR3BEL2ZuSCtLSUJWZzlVT2lpdjJQVUJFWEhqT3BtcSt1NXB3?=
 =?utf-8?B?cTR4Y3VFUmRQTTQ3MUZPUGo1UGxwb0pQRnlKNnQ5S3drOXA2UVkvRHhtZGRF?=
 =?utf-8?B?Y2VRMDhVQ3AzeEg5dmhxcTcvUzZOSTJad1Rxdzd1WnRwUVVXenk1WW5ZdzYw?=
 =?utf-8?B?Snh4REhZbG50K3MzWC83VTc5bTNWRmFtdmNKclI1MUtwVEVnNWk0djlRREpx?=
 =?utf-8?B?MjVneFlaM3R3dXlLSTJsR1hOQmd0Q296dFkyYnBMckxUTGM5dURMQlFwYWhr?=
 =?utf-8?B?eURONHd3MThuanpuTks2MHE3alhMaUhleHJ4SGlsd3FwK3pXOVFoWisycnRJ?=
 =?utf-8?B?UUZEejVOZzI5NzdNK1c4WnhaenZ4RkRROXZtNWlPOUUvcGJNTnJWSUloNlhz?=
 =?utf-8?B?T3FBS05lYk1ERWZnOG02bEtOZFh3T2JtdlFReTlMaWpMMGp3SWlYY1hOYVNY?=
 =?utf-8?B?Z0ZOSXZ3NVphSEtQd1JncnpyaFlmOEpHdWpHRHNBNEVMRmljZzNWc0FaWHJa?=
 =?utf-8?B?U3I5VDAxdDlYaUYvdzkyT1ZnbVgxODZpa2RWcmRNNnNPSHNaTm5OOFJxWVQ3?=
 =?utf-8?B?UEpqUERtdHRyQk9GRW1tNW9qSTJDWFVITktvQXV5OW5UYlZRb1lSRTZWMFZQ?=
 =?utf-8?B?YjFHTFhwb3RIaENnMDlWYms1b3g0MVZYZ29LcUtVNlFmNnJLQUlydnNtYXlm?=
 =?utf-8?B?dFBRUDArY1hGL0pZWk0wRGZ2cWEvR1FFbGNYa1QvblJjTWFWNGZEMkNlMTFS?=
 =?utf-8?B?c1QxUktBU21WQlFpSStzdEpmem9uaEEyTVp5ak5GOVM2NzJkc08wUDFnYkNP?=
 =?utf-8?B?TDMwbzhhQldtbkFyQ0RlNjQyNGN1ODUyYTEraGZIbUw1UEpRR1dMTC8wZ3Q1?=
 =?utf-8?B?RXJOU3kyU3dUT29WRndEM0ZXL1pMR0ttOHdiZ1Q3ZkFrMTlsUGNFaHU0WGJa?=
 =?utf-8?B?NXJHd0g0bGRlVjJpaXM0RnlzYWNiWE1venBkUi90eHVDRGgwTnZQeHE0UEJ0?=
 =?utf-8?B?KzlQVlFrL3dCc2tSWmVISWRUcjd1ejRpUzRwbzdsRVlFYytraW1mcGlsZ1dP?=
 =?utf-8?B?c0RxM011aTgyVUxsVHNxOTM0WExCT1o1RXZoN2czQkVZa3RpdmhLNm1Ndm15?=
 =?utf-8?B?Umx6YTJQM2tzeHgreFRkelJUd3d3OXZoNWp3eWtDcTBocEJ4SWROUVpDQVQr?=
 =?utf-8?B?VHJKYmdsZ2xORkhoTlZZOTZadW8rblhjZnYzL1l4TW5yL04rekd4SGcwdEgy?=
 =?utf-8?B?dkYxZ3UvS3RmU2dnK2V0aVorY1gvZXk0Q1pIYnVFQmsvbHNNYU95dkRMNFlV?=
 =?utf-8?B?YUl0MG5id1FNc0RMMHhmTzRaYmE2TzJNNVpKRXBzWURXczZkQ3YxSzBCQzRB?=
 =?utf-8?B?WVZiSEVIb1kzRTVNRElyYWgrZDNIVDRYU0lMNjB0TEp3U1ZBK01YODluOFVs?=
 =?utf-8?B?MEJWWXdQbjI1cnFnV09NNmx6T2dDK2RGM2pmbHNZQnp5Wm5WaVdCRmkwYW9H?=
 =?utf-8?Q?Y9fmBgjnn+U72BF2YtGW4bw=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8bb6a289-30dc-4b35-f13d-08d9eca57b6c
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB5587.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2022 14:56:13.4756
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: s50CwxQrHxCE3aNif6wOaBG9n+aq/DeuSq0wwXbcH5f4Rpda1q0RaL0ZEbtw7EE+ujDrpzM3CJusIMuXC0pjmg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7443

This avoids an unnecessary (and always somewhat scary) log message for
the recovered from #GP(0).

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
Perhaps even use "== 6" in the family check?

--- a/xen/arch/x86/spec_ctrl.c
+++ b/xen/arch/x86/spec_ctrl.c
@@ -453,7 +453,8 @@ static bool __init check_smt_enabled(voi
      * At the time of writing, it is almost completely undocumented, so isn't
      * virtualised reliably.
      */
-    if ( boot_cpu_data.x86_vendor == X86_VENDOR_INTEL && !cpu_has_hypervisor &&
+    if ( boot_cpu_data.x86_vendor == X86_VENDOR_INTEL &&
+         boot_cpu_data.x86 != 0xf && !cpu_has_hypervisor &&
          !rdmsr_safe(MSR_INTEL_CORE_THREAD_COUNT, val) )
         return (MASK_EXTR(val, MSR_CTC_CORE_MASK) !=
                 MASK_EXTR(val, MSR_CTC_THREAD_MASK));



From xen-devel-bounces@lists.xenproject.org Thu Feb 10 14:56:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 10 Feb 2022 14:56:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269897.464048 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIAsQ-0005zs-Ap; Thu, 10 Feb 2022 14:56:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269897.464048; Thu, 10 Feb 2022 14:56:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIAsQ-0005zl-7D; Thu, 10 Feb 2022 14:56:54 +0000
Received: by outflank-mailman (input) for mailman id 269897;
 Thu, 10 Feb 2022 14:56:53 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=4tMu=SZ=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nIAsP-00056E-0y
 for xen-devel@lists.xenproject.org; Thu, 10 Feb 2022 14:56:53 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ae355fb3-8a81-11ec-8eb8-a37418f5ba1a;
 Thu, 10 Feb 2022 15:56:52 +0100 (CET)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2058.outbound.protection.outlook.com [104.47.12.58]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-36-BSB99X3_NP-Sbok7g9Ki-A-1; Thu, 10 Feb 2022 15:56:50 +0100
Received: from AM0PR04MB5587.eurprd04.prod.outlook.com (2603:10a6:208:125::12)
 by AM8PR04MB7443.eurprd04.prod.outlook.com (2603:10a6:20b:1d6::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Thu, 10 Feb
 2022 14:56:49 +0000
Received: from AM0PR04MB5587.eurprd04.prod.outlook.com
 ([fe80::54e:e7d:545a:da84]) by AM0PR04MB5587.eurprd04.prod.outlook.com
 ([fe80::54e:e7d:545a:da84%3]) with mapi id 15.20.4951.019; Thu, 10 Feb 2022
 14:56:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ae355fb3-8a81-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644505011;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=YE7MboGMkLZsy6AR5le9057gKgoWX82z397TyOpBdFU=;
	b=Yov7ixtt7IeInxiL3TTvftE02KhjVYLUYGIn1kcWGxlXiOJUfMrzPVfnbQof/jtY8OZS2R
	XUGOQsz2zBsdk7ynfv11OH9/+//fjH9VhQZB82Md1kvpGe8B+ScMlpbT+gx9S9TWxDej5M
	mfrR7eNyqFNaSA+1z1mtjBDgmbFoyYE=
X-MC-Unique: BSB99X3_NP-Sbok7g9Ki-A-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Tx37mHSH6rJjrFrs4JidzYTpQr2mgPykYDtZvIVsOBz8xtZbfyKO1ovmbocif8StD1haRO2pEpK/PznN/uuSn0f+C19aWOsVreQoCG73nM+bdO4UwZwbjy66stLylc01XYZS8ZZHE2SuWjlfA7uQtUpS8Nc8p8KaOMBcup4IDCcIqX/u5iC08dknKpsCGPv/aNexTWmb0wYU9JeFXtZsYkZ7tA3qELx2hixTCGqitys91FQxrwY7E1keOS2TWW6FIdQG4K6V5vmI+6aGswP80A8o/NoFj3Bt5Qgn428o9zKOEFYH3vdzKjuhPqfAwJ7rcuEUTAvRT91gbI3HJ2WQVQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=YE7MboGMkLZsy6AR5le9057gKgoWX82z397TyOpBdFU=;
 b=nyOJBSC9YcMJTzdZP3F6zKw11GrbvNW4ou1j7Ac1gKjSJNbrx7z/0u52utyq/RGjSr/YLhAMB3A/B+ziDTdqWNIZidJMg5+eSMrbvfQ5Uu9uMnMqT+8bSAUyHy5h5c9vlH8UaFrXY47q2JfvhmHRDztvbHuyUj3X/pox1JmhD3ziCMUfoiINaWAGro/IlPd9Lx7NhodUSEc94c5Xqu+2IxEmSmwsb1KvuQv2tuAHK/oWjZmC1AV6XmpuEwwbrfFoOlF99NTQV1aOwl1DueH1yQUYPUAWFu1oZPMxcXjydFiM87f7Wvj5AjVcoXS9NwEa8KzCA1wuEBXHRhruuvauog==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <58f81931-cb7d-1710-4f52-380c8f880156@suse.com>
Date: Thu, 10 Feb 2022 15:56:48 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: [PATCH 3/3] x86/Intel: also display CPU freq for family 0xf
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <5d275d7a-7751-af19-db4f-d91e3592d30f@suse.com>
In-Reply-To: <5d275d7a-7751-af19-db4f-d91e3592d30f@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P193CA0111.EURP193.PROD.OUTLOOK.COM
 (2603:10a6:209:85::16) To AM0PR04MB5587.eurprd04.prod.outlook.com
 (2603:10a6:208:125::12)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 664c832b-1a7d-414c-e86d-08d9eca590e8
X-MS-TrafficTypeDiagnostic: AM8PR04MB7443:EE_
X-Microsoft-Antispam-PRVS:
	<AM8PR04MB7443D1EA1FE6E922CC7C9EEFB32F9@AM8PR04MB7443.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	iv9j8AQpWROW4F5d3J0s56Mjd+r1qrI6MP1pHdceWzS8tUyGXtxkPXu+gWC6OzTJ4LrZFk38TVYxjgp03YjCqo1EFvb4dDTUjI7DwQPZqpxgT6cLE/08GksVv40k8KEvxGY8j8DKyphuIqug9d1Zt0qxfKEv985b2RRmh7U8+p+QFkKcM4IF7NM9l1tCRcEeg0FGM3+j+Nv76HdHh+UPekEmx2I8Kw25dkQ6N+ty5/FUFtllFWqdR+LNY12v5CVjHLq3RCocVCeyov8wBVIXRrTKIKH0AqkkRGyAEcrbhp8xV5SKWr00HT0390N0HlgAfHGNg2qOeDYEfCkUGfCHpOruGscPrNl/VAMHeA1QpoOxDjxdk02xWKWjNJywHytJ9px3KWVXo1L3VkJWhC2aIVTPKKXdC6krHeBGhn3vVjVrnPrcbuPfxl1Z4zlO6elgKOqZ2bKZWqL4wZUcVzC3vzAUl012d7z8MYscr6sVuuazC6FEwIrbasUoG0pEvIoR47TBNm46KdLpoUZXjlwD0wAD1CYf63EygeiBRynh46iVR8W9BvMnCC/JruLV1blGtLhcm3O0eTWnqRKmNhToh0LPIOr4gsgCSoMP923qbRtthYb2svdna7NLP3cjyHdsEdgvsQWDO7ulj9iTfFkxSnTjrw2bAsZnupHasNv0dGEFfR8EMIQ/Zh2ZfthM8YFNqZQKLsVbm3XS3aGx6hAyqP+5kYXDZe5Gvho9TYz13dM=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR04MB5587.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(83380400001)(6486002)(186003)(2616005)(31686004)(26005)(6512007)(508600001)(5660300002)(6506007)(8676002)(31696002)(36756003)(8936002)(66556008)(6916009)(66476007)(66946007)(54906003)(316002)(86362001)(38100700002)(2906002)(4326008)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aFFTVGt0QmdFU0N1eGxqRVg5dnhSaHpqeFp0eEZkbUltWFdKRS9CSm1kNTUw?=
 =?utf-8?B?ZHphTTRRTzRDMjZINGQ3b0FBVFhKT0txeG5pRkV6UXBHR3V6ZVdON2xYQmxo?=
 =?utf-8?B?SldmMldxSzFjcmQ1RGY4RXV3VTlHOXNFZGRzWjhEbGo0cjdqRzNUQjVPcVNY?=
 =?utf-8?B?WnVPd210TVIxMWZ4T3FFOHJlbFZ3UDRIdXV2R3A0OWwyTGJPNlg4SUNOaU1I?=
 =?utf-8?B?OExzMVVlTnI4TW9QRXR2Z3ZWMDJDa3VHVmxzbGw1N1BPUHdlM2FUZlJSS2VO?=
 =?utf-8?B?dFNVR1JJbUZsbFBReEROTG5yWGYvUEF2bTFIS1pveTI3Z2FUYm9WbmRheWlX?=
 =?utf-8?B?Q25xeit2SjNDRVhWVEkyeEJPeVdtT0ZjSHQyUCtBTmYvbXl3RGd0YXhFd0NW?=
 =?utf-8?B?d3ZmMXQ2WDhvNjhPQUE2T1o4K1FGbjJ1RWNBU1Z3bVQybkFXRU8vSmlibEZN?=
 =?utf-8?B?RXJhcHAyQXFQODNtdiswUE1ERHpwelMyUG9sRXdBeXVoTEUzUFU3Vm5US1hL?=
 =?utf-8?B?VG56cWpOaUZrbVpyRU4wRHFBRWh5US9pZStRSWkvMTcwN0pKK25JMm9Vclcz?=
 =?utf-8?B?Vk83MDFQazhjN3daS3hGbXFIaGtNOG5vSjZjVjIyd05zckFRL0EySy9DZHhX?=
 =?utf-8?B?MmcvSXArZHduUHRlbXdIWGxrVW03M08vY0ZCbis2Mmo5YmhzWTFYV0k5Uk1k?=
 =?utf-8?B?cWx2cTV5Z1F2SWZPOFZmaEg4K2JZVVFiWU5zTDZVUFJUSnZwbEI1dDdlL2RR?=
 =?utf-8?B?Y0FXbThFdFV1WW9nS2lLOEVHenJVVkpnSDdWbE5EanpqM0pUUnVmekUxdnhi?=
 =?utf-8?B?T1NPdmc4R1ZoOHVXSm9SRXJTcGRlT21Ud1lzNFN0ZWxMU29qcTNUQjVxV3Vx?=
 =?utf-8?B?RTR0cEVrOEtjSis1V3ZqM0N3Zm9lUUdRbFVFemVyOWlhR3ExcDdaelZkOTBs?=
 =?utf-8?B?WEFnS2o3TVIyWUo2MzRmVm1CcXpIRWRWckZFZ2NvWTFqbFFiLzFkdDU3MWxI?=
 =?utf-8?B?WnlaYXNsSjlmOCtUQndSVkJ6ck5yeVZzYjlNR1dDRkw3RE9XWkRPRXdKT2tO?=
 =?utf-8?B?Ym9iS2ZEdU9qenM3RjhQeEx1d0VPSDVFS3JPL1h6VzlUZjFMNmZ6bTN1WWFs?=
 =?utf-8?B?Y3JRSHJORElKN3NtT3Jjcm1sL2c2VURtSHlnMlJMK3RVNlZGemcxbkY5T0xz?=
 =?utf-8?B?L1FaczNEY3BmTjRVTG9TZEorZFUvLytRbDdNWFJEc2wwYU9FeUowYzJpbitD?=
 =?utf-8?B?V1hlb0w0VlVWeG5XVFlxMklCb2NoTm81OStTVjY4RHVVbkJTWGNLcUc4Z0kw?=
 =?utf-8?B?NXZ1ZkU0TlI4aUtSVVVFSkRnRXN5Z05HU2Vmb1NmS1pwNFRRR3BmcU5rN2hN?=
 =?utf-8?B?QUprek9hZGZ2NURab2Znb1czZlhrczdkMUt4VUR1ZGp5RUdvbGY2c3lZQkg4?=
 =?utf-8?B?N0xSZ0tDNEl1TS9uZ3p2N3lmNWowdG9VRXdLZmtFaXdNdTV0bUszUjFVeGVT?=
 =?utf-8?B?d09EYk9jMGpRYTJmZDZHVXROR2VjUnYwcDZNUlh1RHl1QmN3VkhHT1dWNm5W?=
 =?utf-8?B?b3p3TVFTM251Um55SnhsaE1hOHdIM3ViNFFxYndtOG52dmhTTmQ1RHlZOVFH?=
 =?utf-8?B?c2sxYzZaakFhcnVLYjMrekE3TjF6YmtxM2FHTmVhOTFTUFFvT3VRRGtraGI2?=
 =?utf-8?B?YzBoYU5tQWRraW56U1ppb1VXY204ZjlWU2dIMEcvdjEvU044a1V2cUhVN3FV?=
 =?utf-8?B?dTZFOUVySUVKZit0T3VLdUJsaG1vQzJnRzFXdWF0VUovNjl4VEdzVWd6dmR1?=
 =?utf-8?B?REdkaXo5bTY4V0xpV1VZbndzem1QcHBmM3JwQmRBREhNc3BrSmc1bE9mNkhM?=
 =?utf-8?B?ejZmRkdzR2xuLzhpNFlyaDdJOTNOSFVYTWd2M0h1WEllVEpaTTUvbnFVeDZ6?=
 =?utf-8?B?d3hBU0pWYnhpR0VaWHE5V243RkFTSHV0WjFkKzUzdkpPWlM2cmVZY2x2KzAz?=
 =?utf-8?B?Q0h5RE5mdGpEL2Z2SWQyeVVDODNGRmhpcFlrWmxsb2pqd2FPeUZFWE9XRGdz?=
 =?utf-8?B?bXlSNS9xdHozdzl6MDJRODFoRE9hUVBIR0RsbXRYR2tPK2pLdzFOL1NGZmJq?=
 =?utf-8?B?a1FlVVdLQ0xocDFCeWF3Z0VCVXpHY3ZDTkNMZ05JdnRMMnVxZHE2eUU1MUNJ?=
 =?utf-8?Q?CaqY7FbtW2oswzXngqTZ84c=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 664c832b-1a7d-414c-e86d-08d9eca590e8
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB5587.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2022 14:56:49.5827
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6QPH8e2BnbSa4y9aeIPY3FNnb2/h4I7tNmUYA38ltNL/DJzNjd91bIZwRMwBJcmA7+qwsh7753kY95qbVhuy0g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7443

Actually we can do better than simply bailing for there not being any
PLATFORM_INFO MSR on these. The "max" part of the information is
available in another MSR, alongside the scaling factor (which is
encoded in similar ways to Core/Core2, and hence the decoding table can
be shared).

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
The inner switch() is left indented one level too much (and with an
extra pair of braces) to limit the diff. I'd prefer to make a follow-up
patch reducing the indentation, unless I'm told to do so right here.

--- a/xen/arch/x86/cpu/intel.c
+++ b/xen/arch/x86/cpu/intel.c
@@ -412,9 +412,9 @@ static int num_cpu_cores(struct cpuinfo_
 
 static void intel_log_freq(const struct cpuinfo_x86 *c)
 {
-    unsigned int eax, ebx, ecx, edx;
+    unsigned int eax, ebx, ecx, edx, factor;
     uint64_t msrval;
-    uint8_t max_ratio;
+    uint8_t max_ratio, min_ratio;
 
     if ( c->cpuid_level >= 0x15 )
     {
@@ -455,21 +455,22 @@ static void intel_log_freq(const struct
         }
     }
 
-    if ( c->x86 == 0xf || rdmsr_safe(MSR_INTEL_PLATFORM_INFO, msrval) )
-        return;
-    max_ratio = msrval >> 8;
-
-    if ( max_ratio )
+    switch ( c->x86 )
     {
-        unsigned int factor = 10000;
-        uint8_t min_ratio = msrval >> 40;
+        static const unsigned short core_factors[] =
+            { 26667, 13333, 20000, 16667, 33333, 10000, 40000 };
+
+    case 6:
+        if ( rdmsr_safe(MSR_INTEL_PLATFORM_INFO, msrval) )
+            return;
+        max_ratio = msrval >> 8;
+        min_ratio = msrval >> 40;
+        if ( !max_ratio )
+            return;
 
-        if ( c->x86 == 6 )
+        {
             switch ( c->x86_model )
             {
-                static const unsigned short core_factors[] =
-                    { 26667, 13333, 20000, 16667, 33333, 10000, 40000 };
-
             case 0x0e: /* Core */
             case 0x0f: case 0x16: case 0x17: case 0x1d: /* Core2 */
                 /*
@@ -491,13 +492,33 @@ static void intel_log_freq(const struct
             case 0x25: case 0x2c: case 0x2f: /* Westmere */
                 factor = 13333;
                 break;
+
+            default:
+                factor = 10000;
+                break;
             }
+        }
+        break;
+
+    case 0xf:
+        if ( rdmsr_safe(MSR_IA32_EBC_FREQUENCY_ID, msrval) )
+            return;
+        max_ratio = msrval >> 24;
+        min_ratio = 0;
+        msrval >>= 16;
+        if ( (msrval &= 7) > 4 )
+            return;
+        factor = core_factors[msrval];
+        break;
 
-        printk("CPU%u: ", smp_processor_id());
-        if ( min_ratio )
-            printk("%u ... ", (factor * min_ratio + 50) / 100);
-        printk("%u MHz\n", (factor * max_ratio + 50) / 100);
+    default:
+        return;
     }
+
+    printk("CPU%u: ", smp_processor_id());
+    if ( min_ratio )
+        printk("%u ... ", (factor * min_ratio + 50) / 100);
+    printk("%u MHz\n", (factor * max_ratio + 50) / 100);
 }
 
 static void init_intel(struct cpuinfo_x86 *c)



From xen-devel-bounces@lists.xenproject.org Thu Feb 10 16:16:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 10 Feb 2022 16:16:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269917.464059 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIC7R-0005yo-Hb; Thu, 10 Feb 2022 16:16:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269917.464059; Thu, 10 Feb 2022 16:16:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIC7R-0005yh-Ce; Thu, 10 Feb 2022 16:16:29 +0000
Received: by outflank-mailman (input) for mailman id 269917;
 Thu, 10 Feb 2022 16:16:27 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=T9Dk=SZ=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nIC7P-0005yb-DV
 for xen-devel@lists.xenproject.org; Thu, 10 Feb 2022 16:16:27 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c98a5bd4-8a8c-11ec-8f75-fffcc8bd4f1a;
 Thu, 10 Feb 2022 17:16:23 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c98a5bd4-8a8c-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644509783;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=HpgrniM/GR9flc47TLdhA0mQkK9wxxlQYC2qAjHjRGY=;
  b=YDU41omWVc9fX6CvsVmAFn+ZZmMAuEUQsxP1vzrv9HbhzdUhxmaHdHWd
   rwJOYa1kfXdLBGTwimHnmlRMlSO+W8ZPk/Aiy/aeQbDLC7uzR/vSsz17j
   /KZGE20da3B32yHemB3/KosBlf08bhiICxoAj0WGbSjKzhJGn7DIXehRU
   4=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: WpS0jnluU8ig2mjyDh1xJ+0dSMHPG3GBLgP7BsBxZ3uqYJXzLU0DbniAy0qK9QthtJOMHKbxvp
 UqD3l3t6JS2Y/PLHVWSjFJt1I9HQS72ysm1a4l1TSwhRi7aTisqVv8v9TxsMypoZGqsYv8sa4g
 nOWlKnOKV882v1t5sHMRtZrOFUc9tF5Mh3jWVUHuIkynwxu5DqG7JKM74CE3M3T4WLa7MtHRSt
 p3KcLv6Ni0qpJx7cVADZLEsOtiJX1McptKIXjxbCZcDljZSoHmOxXEG1un3muAywN+PcUc2XAs
 5S0Z5hy0WY4jyUFcODWpPzRu
X-SBRS: 5.1
X-MesageID: 63389810
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:vxPFeq5+80Xh7uLy+2aAVAxRtBbBchMFZxGqfqrLsTDasY5as4F+v
 jAZUD2CPamKZmP9f4x+bNnkpkhV6MSDzt81Sgdpryk0Hi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FV8MpBsJ00o5wbZj29Yw27BVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zk
 4xR7ITrbyESDoaTpNUNbjpaLAVwMvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALNs7kMZlZonh95TrYEewnUdbIRKCiCdpwgmxr1pEeRK62i
 8wxYz9UdBT7W0J1E15NOJcGnMuE3XL1WmgNwL6SjfVuuDWCpOBr65DkKsbYf+uPVMpcn0uGj
 m/e9mG/CRYfXPSBzj6C/mOpl/X4lyrxU4IPF5W17vdvxlaUwwQ7AhAMSUGyp/X/j0ekQs9eM
 GQd4C9opq83nGSsStT+RBS+rGSztxgQQcdLE+Y65QeOzYLZ+w+cQGMDS1ZpctUmqctwXj0s2
 V+hlsnsQzdotdW9TnaQ9aydqz+oDjQENm8JZSICTgwt7sHqpcc4iRenZsZuFuu5g8P4HRn0w
 iuWt24uirMLl8kJ2q6nu1fdjFqEr57FVFRtvl3/UWes7wc/b4mgD6Sq41XG6fdLLK6CU0KM+
 nMDnqC29/sSBJuAkCiMRuQlH7yz4fuBdjrGjjZHHYQl9jmr026ue8ZX+j4WGatyGp9aI3mzO
 haV4F4Pos8IVJe3UUNpS9noF50ylo7GLuTOCczlfudtYKdVegDSqUmCenWs92zqlUEtl4Q2N
 pGabdugAB4mNEh38Nalb7xDiOF2n0jS0UuWHMmmlEr/jdJycVbIEe9tDbeYUgwuAEpoSi3x+
 s0XCcaFwg43vAbWMniOqt57wbznwBEG6XHKRy5/K7brzulOQjhJ5xrtLVUJINUNc0N9zLmgw
 51FchUEoGcTfFWeQelwVlhtaan0QbF0pm8hMConMD6AgiZ/Pdr0tv9HLMtoLNHLEdCPK9YvF
 pHpnO3aXJxypsnvoWxBPfERUqQ+HPhUue5+F3X8O2VuF3KRbwfI5sXlbmPSGNomVUKKWT8Fi
 +T4jGvzGMNbLyw7VZq+QK//njuZ4ClG8MovDhSgHzWmUBi1mGScA3eq1aFfzgBlAUir+wZ2I
 C7IXUlG9bOQ/+fYMrDh3Mi5kmtgKMMndmJyFGjH97emcy7c+2uo24hbV+iUOzvaUQvJFG+KP
 I25Ftnwb68KmkhkqY15H+o5xK4y/YK39bRb0h5lDDPAaFHyUuFsJXyP3M9usKxRx+AG5VvqC
 xzXotQKa6+UPM7FEUIKIFZ3ZOq0yvxJyCLZ6u44IRum6XYvrqaHS0hbIzKFlDdZcOluKIogz
 Op44JwW5gWzhwAEKNGDiiwIpW2AImZZC/cst40AAZ+tgQ0ukwkQbZvZAy7wwZeOd9QTbRV6f
 m7K3PLP3u0OyFDDfnw/EWn28dBc3Zle6gpXyFIiJkiSnoaXjPEAwxAMoy88SR5Yz0sb3rsra
 HRrLUB8OY6H4yxs2JpYR2mpFgxMWE+Z90j2xwdbnWHVVRD1BGnELWl7MueR5kEJtWlbe2EDr
 r2fzW/kVxfsfd3wgXRuCRI09aS7QIwj7BDGleCmA9+BTsszbjfSi6OzYXYF9kn8CsQriUyb/
 eRn8Y6cs0Eg2fL8d0HjN7Sn6A==
IronPort-HdrOrdr: A9a23:kbITY68QTIXOZRnVs1huk+FAdb1zdoMgy1knxilNoENuHfBwxv
 rDoB1E73LJYVYqOU3Jmbi7Sc69qFfnhORICO4qTMqftWjdyRCVxeRZg7cKrAeQeREWmtQtsJ
 uINpIOdOEYbmIK/PoSgjPIaurIqePvmMvD5Za8854ud3ATV0gJ1XYGNu/xKDwReOApP+tcKH
 LKjfA32AZINE5nJfiTNz0gZazuttfLnJXpbVovAAMm0hCHiXeN5KThGxaV8x8CW3cXqI1SvF
 Ttokjc3OGOovu7whjT2yv66IlXosLozp9mCNaXgsYYBz3wgkKDZZhnWZeFoDcpydvfomoCoZ
 3pmVMNLs5z43TeciWcpgbs4RDp1HIU53rr2Taj8A3eiP28YAh/J9tKhIpffBecwVEnpstA3K
 VC2H/cn4ZLDDvb9R6NqeTgZlVPrA6ZsHAimekcgzh0So0FcoJcqoQZ4Qd8DIoAJiTn84oqed
 MeQ/003MwmMW9yUkqp/VWGmLeXLzYO91a9MwQ/U/WuonlrdCsT9Tpc+CQd9k1wg67VBaM0o9
 gsCZ4Y542mePVmGZ6VNN1xMfdfNVa9My4kEFjiaGgPR5t3c04klfbMkcAIDaeRCds18Kc=
X-IronPort-AV: E=Sophos;i="5.88,359,1635220800"; 
   d="scan'208";a="63389810"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=l25MdkKBl+IF0x1CXeVuLIFa4eHS9qhoT1xEev9L0+qv+K8TyxI8CcW9P2E9l3aiN1wf2Z9sJW/Bik1l+WlEjdmoVI5kByrHjeLuhusawIIfIZV5InpmpR8EqNLsUxS1NcyRiQvzZjbkmOXQGlkX0LieVfp/ldo+Q/EVHaobKMGIZARlCStP4Naq1TzniycDaKfW08bC4JutUszE25dgJ/oz4xuX0WRLaE1ZxIDYyhHwXiyfqoNTWhxXqMdZ15GG5hd99HP5JBd/uf0xxVWmX4tzmKkF6rSGKYGkraCLso5fL8fJwbF9RuNsJGW0mbYr2p9gf1VVfr4Sp/6V7+TU1Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=9sJ+hCBcfx7fBWMzoFN1Gqj03lwJkNNyShDXtGng+tU=;
 b=IZsV0wqSaZcp9BeShQ6B36MQh3LKT8c1vzZf2pDRv1/o4/+JuEF+AvogdTfyN8EbpIje2Nf+LGOdbGM9q6Mw3qTu2JRuFaoJmN3Utco1lRj+GvcJGIJXXHQRGZTHsFcVQ7IWpvJLwtovd4VvbOlYmUgWNxRvAEXGBbN1KhZ+fdgTQ8vxLL054iHq+Z4puDElNbWFdAVnyX+jHOvR7ZwvgnRN2RylPt5HxdN5qVswLOhee1N3j2CwaUUC9lV5ildTNOMpB+JMjCAoO9cAUWn+Xn2gjH1v7GJHQZdKqzTv2ZCPb2l8nGYpLgYTgwSD/sI2MGedF/uxu1pBfnb1na1HLA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=9sJ+hCBcfx7fBWMzoFN1Gqj03lwJkNNyShDXtGng+tU=;
 b=aLQNhpU/51Z3JWkrt91onywaLvQsoOBER6bJIHaiexdK0qC9yTK2kfk/wFMTsCJgQc9TUKtoImqAAcHnLjEnIO3w5iqhX3aXTsD1sXq6eRrnfzx3e+4NgV3Lr/rbuSr3aP+gXDZrQ0SS0Hf4d7SplyqVMnrkn0NmCR5PNnwItSg=
Date: Thu, 10 Feb 2022 17:16:10 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Oleksandr Andrushchenko <andr2000@gmail.com>
CC: <xen-devel@lists.xenproject.org>, <jbeulich@suse.com>, <julien@xen.org>,
	<sstabellini@kernel.org>, <oleksandr_tyshchenko@epam.com>,
	<volodymyr_babchuk@epam.com>, <artem_mygaiev@epam.com>,
	<bertrand.marquis@arm.com>, <rahul.singh@arm.com>, Oleksandr Andrushchenko
	<oleksandr_andrushchenko@epam.com>
Subject: Re: [PATCH] vpci: introduce per-domain lock to protect vpci structure
Message-ID: <YgU6Snk8GTytJXZp@Air-de-Roger>
References: <20220209133627.959649-1-andr2000@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220209133627.959649-1-andr2000@gmail.com>
X-ClientProxiedBy: LO2P123CA0091.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:139::6) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a6f76b0a-0e7e-4711-f30e-08d9ecb0a965
X-MS-TrafficTypeDiagnostic: MWHPR03MB2957:EE_
X-Microsoft-Antispam-PRVS: <MWHPR03MB2957F56BA94B2CB481D3BF868F2F9@MWHPR03MB2957.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: JDIe1OO7hQ40Yb0IJOdvWkWQbX4Mzf6aO9AVLVVNexy9JytBA/c3YMxgrOuWzAwKzi4uH5sgBY/33tarPSjUBNzxcihWa/R0PioJysxBsuB3cfDyLp00giCJkBlBdD61gR+5F1eNKmc0KEaQX+bwxHwIfH+ZnNC9x6BLflryskpajuFpZrttu3RKuyen7V5DK1s0JDpBtjQBkEfts1FpXhLzgszZQLYAJNgxXPm7kWJY5CoUiQm4n7oiTYHHwZ6CX4Zm1+nZesmn5kF/1njkMsi2WECvtOOx5tIIvb5IuamfytqwVmUhZdyKyNiIqZnX9HBd2muTbkcFhICfqwApKHgMSV6PJTOIVKtZZXK/Uu3+dD3k9lVgbrGjANnDZ7QT+9znXtof1dZUb484InP/Ez+PM2N5OeqXySM6yO8cr8rdom6cu1NHaq8WXSjNVf4L4nqsAsrmuioBNAxhlAIlaDjCGFObVroSd48YnQxEr9TCqnJpyFK6KL1hHXx9MSWI6CNWJ8rPOOj4iPbOSR+IXF1+eSnX7RkXih8Gb8/DJ/Xd3lDKOtEOC/huK23WfoP+Rwe+YSxvrwS7DcxtKtEoad8FeNBhqqVmjX5hfP76vP+baEBhzSRCFlKGJ/zkxtv/zUFA/NzGXcL0WotAjoasYrsAky0hIrn/M5A2NyyfeiY/0/vc8yTQZn7RfysGV4U1cVRNxz0ae96Zaute2hcWlyH2lS13zfLHQ3c01NsEsMBZMgrmKSrxHfUejxHgLnyIt9QA/qsV/EeZIR1Jmvv0l0PMkL9FOAH4wbCr5QxFnuE=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(6666004)(9686003)(966005)(6486002)(86362001)(85182001)(6916009)(33716001)(316002)(508600001)(38100700002)(6512007)(66946007)(6506007)(2906002)(66476007)(66556008)(4326008)(30864003)(8936002)(7416002)(83380400001)(8676002)(82960400001)(5660300002)(186003)(26005)(309714004);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bm9LVmpUYURxN3pkcEdzaFBuSUVhaGtseEYzcXR4MDd4NzVyRkZIT1kwb2x4?=
 =?utf-8?B?bDZqOSsxK2RyYitvWGRhdWs4MEJ1ZDRsUDAwNDR5a2hINGoyK2hEa1hQUXBz?=
 =?utf-8?B?NFNpNDg0NmNxSnBPSmJMS1lkTmwrdnlhenR1UW9qNzZlWFRlZTJwbFlIKzVN?=
 =?utf-8?B?TDMrNXd5NWY1OVp1em9aeUVhZUZ4TTRXSlo5dlZnWDViNjZSM2FEU1p3ZUwz?=
 =?utf-8?B?RURkUHJvRlN0ZXp3a3BKUVFQbXNtQXRQRXNQNU9yYW9DS0lNYkY3VytiaVpP?=
 =?utf-8?B?NE5vRHJUU2Zpcjl2Zkt5c1FuTkpEN0YxVDhrbVZRNG5qSlBaZUNvNURjSlhz?=
 =?utf-8?B?TVhCYTE4VDlBNWFMb0dmbjhNbklOdmJieTRCMDh5MURRT1pCQkVQeTZweFVs?=
 =?utf-8?B?dzJCNy84bHdqQXVxU2hoc1UwRFA1UlpMWFRYQ0Z5cy8yRVErdGh3RVlseWdH?=
 =?utf-8?B?ZkZJUC96bTJReWlkSUxKR2wyM3lvSTNjMklXai85SDBWc3hjdlprVUd5ODZx?=
 =?utf-8?B?SDJRRFJLMElxTlJ1UUlWaklkdlVoYThZM1R1U29kTTVHRnBMMGhhaXdINmFq?=
 =?utf-8?B?VHNzNUUydFpaMGk2OWZZQVpldHhjUTV0WDljbFNoa201K1BManBXanA1dVh5?=
 =?utf-8?B?ZlpNampVa0RTdmY4SVBhS3pHS3c1ZVljNHl0Nlo1dUp4b21EZS9jYUI2R1pv?=
 =?utf-8?B?dEFmaUZwckYwTUhSUDU3QjZnVmVrUHh3YzRVZGF1Lzk3eEtjN1cwWmFjNER3?=
 =?utf-8?B?RWxJTldOUXpTOUtlUDJramI0RklUWlgvVHR0MVVabWlnUzhpTU1MdUdDUXFw?=
 =?utf-8?B?NFVsNm1Ba0M5V0t1ajkxQitpc1lQOGVDRFFLMWo1dU1ERjJ1eFRqcnJIc2hn?=
 =?utf-8?B?enJOU01Zc2xBNUlDVTE0bDBUaGg1cGYvL3RTM3VQT1Q3a05nNTFIMGZLSyta?=
 =?utf-8?B?bHJIcWM1U1VIZWN2b2E0aHZYV2thU2x1Z1RkamRhbmFtWjJwdytNTmwyeGhu?=
 =?utf-8?B?cFFRdnowTTFraDhtRDdTV0VTSGgvK3FvdmtManF2U3ZFTG16MnlDa2phTXAw?=
 =?utf-8?B?K2RSOVJRTGdmQkdSamxQRVJwRXJYMVQzQSsrSzVwR1hIczc3VGNpeWVlYzhJ?=
 =?utf-8?B?MzZxSEpwYXBHbFQyejRCR3VSQ2o1K2l0Z3RHazlHUDJpSzJYWVlUaDlpN2pF?=
 =?utf-8?B?b09vUmZwcW04WVpadld6R0NuMmZpckpOVGJpTVZnUXBveTZYSWdxdkRwa01I?=
 =?utf-8?B?UWNjZ3c1VEN4N2dGeEJraWtBbmxNVTF3Mkd4VWV0d1Q3TXoyTjVXRkVVWmFs?=
 =?utf-8?B?ajNPdnN6Y3BpNHpiM3doeTMzNmI3M2prOWdiRFdQRGo3eUtLdTFBaXA2dHpD?=
 =?utf-8?B?SDZITUNvS2I2YzIyTFdieUVEVDNPU1hjYUJYOE1SMWI5a2NUTkFUSVpZa1po?=
 =?utf-8?B?Q3dQQjJPNTRFb1RZa0lVYWVRUkZsc0pFekU4dDBxazcxWmpzbHVwQTN4SGF4?=
 =?utf-8?B?Wi8weGl3N3JFOTNJZWE2YVFRMmFVejZ3bjFZc0QvYkZyQWdIMlNzSXEwWUUz?=
 =?utf-8?B?azVEM09ZUkx4dFlJeWsxUVV2akNwSFFSWmxpWkRxaDl3Ym9CQnNoTXZHVVZE?=
 =?utf-8?B?bGhBM0RXSVI4eVlKREJmY0kwQ04wQ0ZaTHQ5TEpZOEcwSTlld0wvM3RnT0lh?=
 =?utf-8?B?anlDb21KUHZNQkhOL0ZUbmRRT2FGMnFWaHRYRW5hcThmWDFJcm9HOVhhR25r?=
 =?utf-8?B?ZVZCRCtucDJRWTlNeWtEODg2NUc3VkpYODV4b1hTWUYvMlRNeDdseE9MaXlL?=
 =?utf-8?B?RHh0RlBBR0FSQzZqa2EzcDB3RlV3emovTDRoSzRERjlqSnpRMUFYc2tDSzAy?=
 =?utf-8?B?dGVybDNCZnNDeFJ1dGprRlhnNlI3TlJPMENjVzNmdjVlb25JMVNkN3ZySzRT?=
 =?utf-8?B?WGxWNmh2M3Vma0xEcmxiYXFtT2V3WURzTHBadENFbk5qR2ZpOHVBTjhaY3RQ?=
 =?utf-8?B?aE15N3pWSHNEVytReHNJQ0p5ZW03eEdsaHMrRWJsTklzUFU4em8wZU9VWGpS?=
 =?utf-8?B?b2dlRU5CYlVOdi9TUEFqemJlbTZyR0ZUUWRKOVV4WnBGRjRGUjZCSW1MdXEw?=
 =?utf-8?B?blc4eTZNUFAzWG9JcXMzTVRIeVN4L213aEwwRndDYUthMnFNWVlhN1lmbFNN?=
 =?utf-8?Q?ey1qTQlOYLPPciCk6HlJxXo=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a6f76b0a-0e7e-4711-f30e-08d9ecb0a965
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2022 16:16:15.3335
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8+/J3xYy5NiWNyflu8OxMG3wyjyEzRt998NIdvMFWMzjKhYi3adBn8xQmCS4JDg6+vkTcYhFtPdOhNmt+xU6FA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2957
X-OriginatorOrg: citrix.com

On Wed, Feb 09, 2022 at 03:36:27PM +0200, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> Introduce a per-domain read/write lock to check whether vpci is present,
> so we are sure there are no accesses to the contents of the vpci struct
> if not. This lock can be used (and in a few cases is used right away)
> so that vpci removal can be performed while holding the lock in write
> mode. Previously such removal could race with vpci_read for example.

Sadly there's still a race in the usage of pci_get_pdev_by_domain wrt
pci_remove_device, and likely when vPCI gets also used in
{de}assign_device I think.

> 1. Per-domain's vpci_rwlock is used to protect pdev->vpci structure
> from being removed.
> 
> 2. Writing the command register and ROM BAR register may trigger
> modify_bars to run, which in turn may access multiple pdevs while
> checking for the existing BAR's overlap. The overlapping check, if done
> under the read lock, requires vpci->lock to be acquired on both devices
> being compared, which may produce a deadlock. It is not possible to
> upgrade read lock to write lock in such a case. So, in order to prevent
> the deadlock, check which registers are going to be written and acquire
> the lock in the appropriate mode from the beginning.
> 
> All other code, which doesn't lead to pdev->vpci destruction and does not
> access multiple pdevs at the same time, can still use a combination of the
> read lock and pdev->vpci->lock.
> 
> 3. Optimize if ROM BAR write lock required detection by caching offset
> of the ROM BAR register in vpci->header->rom_reg which depends on
> header's type.
> 
> 4. Reduce locked region in vpci_remove_device as it is now possible
> to set pdev->vpci to NULL early right after the write lock is acquired.
> 
> 5. Reduce locked region in vpci_add_handlers as it is possible to
> initialize many more fields of the struct vpci before assigning it to
> pdev->vpci.
> 
> 6. vpci_{add|remove}_register are required to be called with the write lock
> held, but it is not feasible to add an assert there as it requires
> struct domain to be passed for that. So, add a comment about this requirement
> to these and other functions with the equivalent constraints.
> 
> 7. Drop const qualifier where the new rwlock is used and this is appropriate.
> 
> 8. This is based on the discussion at [1].
> 
> [1] https://lore.kernel.org/all/20220204063459.680961-4-andr2000@gmail.com/
> 
> Suggested-by: Roger Pau Monné <roger.pau@citrix.com>
> Suggested-by: Jan Beulich <jbeulich@suse.com>
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> ---
> This was checked on x86: with and without PVH Dom0.
> ---
>  xen/arch/x86/hvm/vmsi.c   |   2 +
>  xen/common/domain.c       |   3 +
>  xen/drivers/vpci/header.c |   8 +++
>  xen/drivers/vpci/msi.c    |   8 ++-
>  xen/drivers/vpci/msix.c   |  40 +++++++++++--
>  xen/drivers/vpci/vpci.c   | 114 ++++++++++++++++++++++++++++----------
>  xen/include/xen/sched.h   |   3 +
>  xen/include/xen/vpci.h    |   2 +
>  8 files changed, 146 insertions(+), 34 deletions(-)
> 
> diff --git a/xen/arch/x86/hvm/vmsi.c b/xen/arch/x86/hvm/vmsi.c
> index 13e2a190b439..351cb968a423 100644
> --- a/xen/arch/x86/hvm/vmsi.c
> +++ b/xen/arch/x86/hvm/vmsi.c
> @@ -893,6 +893,8 @@ int vpci_msix_arch_print(const struct vpci_msix *msix)
>  {
>      unsigned int i;
>  
> +    ASSERT(!!rw_is_locked(&msix->pdev->domain->vpci_rwlock));
              ^ no need for the double negation.

Also this asserts that the lock is taken, but could be by a different
pCPU.  I guess it's better than nothing.

> +
>      for ( i = 0; i < msix->max_entries; i++ )
>      {
>          const struct vpci_msix_entry *entry = &msix->entries[i];

Since this function is now called with the per-domain rwlock read
locked it's likely not appropriate to call process_pending_softirqs
while holding such lock (check below).

We will likely need to re-iterate over the list of pdevs assigned to
the domain and assert that the pdev is still assigned to the same
domain.

> diff --git a/xen/common/domain.c b/xen/common/domain.c
> index 2048ebad86ff..10558c22285d 100644
> --- a/xen/common/domain.c
> +++ b/xen/common/domain.c
> @@ -616,6 +616,9 @@ struct domain *domain_create(domid_t domid,
>  
>  #ifdef CONFIG_HAS_PCI
>      INIT_LIST_HEAD(&d->pdev_list);
> +#ifdef CONFIG_HAS_VPCI
> +    rwlock_init(&d->vpci_rwlock);
> +#endif
>  #endif
>  
>      /* All error paths can depend on the above setup. */
> diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c
> index 40ff79c33f8f..9e2aeb2055c9 100644
> --- a/xen/drivers/vpci/header.c
> +++ b/xen/drivers/vpci/header.c
> @@ -142,12 +142,14 @@ bool vpci_process_pending(struct vcpu *v)
>          if ( rc == -ERESTART )
>              return true;
>  
> +        read_lock(&v->domain->vpci_rwlock);
>          spin_lock(&v->vpci.pdev->vpci->lock);
>          /* Disable memory decoding unconditionally on failure. */
>          modify_decoding(v->vpci.pdev,
>                          rc ? v->vpci.cmd & ~PCI_COMMAND_MEMORY : v->vpci.cmd,
>                          !rc && v->vpci.rom_only);
>          spin_unlock(&v->vpci.pdev->vpci->lock);
> +        read_unlock(&v->domain->vpci_rwlock);
>  
>          rangeset_destroy(v->vpci.mem);
>          v->vpci.mem = NULL;
> @@ -203,6 +205,7 @@ static void defer_map(struct domain *d, struct pci_dev *pdev,
>      raise_softirq(SCHEDULE_SOFTIRQ);
>  }
>  
> +/* This must hold domain's vpci_rwlock in write mode. */
>  static int modify_bars(const struct pci_dev *pdev, uint16_t cmd, bool rom_only)
>  {
>      struct vpci_header *header = &pdev->vpci->header;
> @@ -454,6 +457,8 @@ static int init_bars(struct pci_dev *pdev)
>      struct vpci_bar *bars = header->bars;
>      int rc;
>  
> +    ASSERT(!!rw_is_write_locked(&pdev->domain->vpci_rwlock));
> +
>      switch ( pci_conf_read8(pdev->sbdf, PCI_HEADER_TYPE) & 0x7f )
>      {
>      case PCI_HEADER_TYPE_NORMAL:
> @@ -548,6 +553,7 @@ static int init_bars(struct pci_dev *pdev)
>      {
>          struct vpci_bar *rom = &header->bars[num_bars];
>  
> +        header->rom_reg = rom_reg;
>          rom->type = VPCI_BAR_ROM;
>          rom->size = size;
>          rom->addr = addr;
> @@ -559,6 +565,8 @@ static int init_bars(struct pci_dev *pdev)
>          if ( rc )
>              rom->type = VPCI_BAR_EMPTY;

You can also set 'rom_reg = ~0' here. Or move the setting of rom_reg
after the handler has been successfully installed.

I think it would be easier to just signal no ROM BAR with rom_reg ==
0.  There's no header where the ROM BAR is at offset 0.  That way you
will only have to set rom_reg on the successful path, but you don't
need to care about the case where there's no ROM BAR.

>      }
> +    else
> +        header->rom_reg = ~(unsigned int)0;

No need for the cast.

>  
>      return (cmd & PCI_COMMAND_MEMORY) ? modify_bars(pdev, cmd, false) : 0;
>  }
> diff --git a/xen/drivers/vpci/msi.c b/xen/drivers/vpci/msi.c
> index 5757a7aed20f..5df3dfa8243c 100644
> --- a/xen/drivers/vpci/msi.c
> +++ b/xen/drivers/vpci/msi.c
> @@ -190,6 +190,8 @@ static int init_msi(struct pci_dev *pdev)
>      uint16_t control;
>      int ret;
>  
> +    ASSERT(!!rw_is_write_locked(&pdev->domain->vpci_rwlock));
> +
>      if ( !pos )
>          return 0;
>  
> @@ -265,7 +267,7 @@ REGISTER_VPCI_INIT(init_msi, VPCI_PRIORITY_LOW);
>  
>  void vpci_dump_msi(void)
>  {
> -    const struct domain *d;
> +    struct domain *d;
>  
>      rcu_read_lock(&domlist_read_lock);
>      for_each_domain ( d )
> @@ -277,6 +279,9 @@ void vpci_dump_msi(void)
>  
>          printk("vPCI MSI/MSI-X d%d\n", d->domain_id);
>  
> +        if ( !read_trylock(&d->vpci_rwlock) )
> +            continue;
> +
>          for_each_pdev ( d, pdev )
>          {
>              const struct vpci_msi *msi;
> @@ -326,6 +331,7 @@ void vpci_dump_msi(void)
>              spin_unlock(&pdev->vpci->lock);
>              process_pending_softirqs();
>          }
> +        read_unlock(&d->vpci_rwlock);

Same here, you are calling process_pending_softirqs while holding
vpci_rwlock.

>      }
>      rcu_read_unlock(&domlist_read_lock);
>  }
> diff --git a/xen/drivers/vpci/msix.c b/xen/drivers/vpci/msix.c
> index 846f1b8d7038..5296d6025d8e 100644
> --- a/xen/drivers/vpci/msix.c
> +++ b/xen/drivers/vpci/msix.c
> @@ -138,6 +138,7 @@ static void control_write(const struct pci_dev *pdev, unsigned int reg,
>          pci_conf_write16(pdev->sbdf, reg, val);
>  }
>  
> +/* This must hold domain's vpci_rwlock in write mode. */
>  static struct vpci_msix *msix_find(const struct domain *d, unsigned long addr)
>  {
>      struct vpci_msix *msix;
> @@ -158,7 +159,12 @@ static struct vpci_msix *msix_find(const struct domain *d, unsigned long addr)
>  
>  static int msix_accept(struct vcpu *v, unsigned long addr)
>  {
> -    return !!msix_find(v->domain, addr);
> +    int rc;
> +
> +    read_lock(&v->domain->vpci_rwlock);
> +    rc = !!msix_find(v->domain, addr);
> +    read_unlock(&v->domain->vpci_rwlock);

Newline before return.

> +    return rc;
>  }
>  
>  static bool access_allowed(const struct pci_dev *pdev, unsigned long addr,
> index fb0947179b79..16bb3b832e6a 100644
> --- a/xen/drivers/vpci/vpci.c
> +++ b/xen/drivers/vpci/vpci.c
> @@ -89,22 +104,28 @@ int vpci_add_handlers(struct pci_dev *pdev)
>  }
>  #endif /* __XEN__ */
>  
> -static int vpci_register_cmp(const struct vpci_register *r1,
> -                             const struct vpci_register *r2)
> +static int vpci_offset_cmp(unsigned int r1_offset, unsigned int r1_size,
> +                           unsigned int r2_offset, unsigned int r2_size)
>  {
>      /* Return 0 if registers overlap. */
> -    if ( r1->offset < r2->offset + r2->size &&
> -         r2->offset < r1->offset + r1->size )
> +    if ( r1_offset < r2_offset + r2_size &&
> +         r2_offset < r1_offset + r1_size )
>          return 0;
> -    if ( r1->offset < r2->offset )
> +    if ( r1_offset < r2_offset )
>          return -1;
> -    if ( r1->offset > r2->offset )
> +    if ( r1_offset > r2_offset )
>          return 1;
>  
>      ASSERT_UNREACHABLE();
>      return 0;
>  }
>  
> +static int vpci_register_cmp(const struct vpci_register *r1,
> +                             const struct vpci_register *r2)
> +{
> +    return vpci_offset_cmp(r1->offset, r1->size, r2->offset, r2->size);
> +}

Seeing how this gets used below I'm not sure it's very helpful to
reuse vpci_register_cmp, see my comment below.

> +
>  /* Dummy hooks, writes are ignored, reads return 1's */
>  static uint32_t vpci_ignored_read(const struct pci_dev *pdev, unsigned int reg,
>                                    void *data)
> @@ -129,6 +150,7 @@ uint32_t vpci_hw_read32(const struct pci_dev *pdev, unsigned int reg,
>      return pci_conf_read32(pdev->sbdf, reg);
>  }
>  
> +/* This must hold domain's vpci_rwlock in write mode. */
>  int vpci_add_register(struct vpci *vpci, vpci_read_t *read_handler,
>                        vpci_write_t *write_handler, unsigned int offset,
>                        unsigned int size, void *data)
> @@ -152,8 +174,6 @@ int vpci_add_register(struct vpci *vpci, vpci_read_t *read_handler,
>      r->offset = offset;
>      r->private = data;
>  
> -    spin_lock(&vpci->lock);
> -
>      /* The list of handlers must be kept sorted at all times. */
>      list_for_each ( prev, &vpci->handlers )
>      {
> @@ -165,25 +185,23 @@ int vpci_add_register(struct vpci *vpci, vpci_read_t *read_handler,
>              break;
>          if ( cmp == 0 )
>          {
> -            spin_unlock(&vpci->lock);
>              xfree(r);
>              return -EEXIST;
>          }
>      }
>  
>      list_add_tail(&r->node, prev);
> -    spin_unlock(&vpci->lock);
>  
>      return 0;
>  }
>  
> +/* This must hold domain's vpci_rwlock in write mode. */
>  int vpci_remove_register(struct vpci *vpci, unsigned int offset,
>                           unsigned int size)
>  {
>      const struct vpci_register r = { .offset = offset, .size = size };
>      struct vpci_register *rm;
>  
> -    spin_lock(&vpci->lock);
>      list_for_each_entry ( rm, &vpci->handlers, node )
>      {
>          int cmp = vpci_register_cmp(&r, rm);
> @@ -195,14 +213,12 @@ int vpci_remove_register(struct vpci *vpci, unsigned int offset,
>          if ( !cmp && rm->offset == offset && rm->size == size )
>          {
>              list_del(&rm->node);
> -            spin_unlock(&vpci->lock);
>              xfree(rm);
>              return 0;
>          }
>          if ( cmp <= 0 )
>              break;
>      }
> -    spin_unlock(&vpci->lock);
>  
>      return -ENOENT;
>  }
> @@ -310,7 +326,7 @@ static uint32_t merge_result(uint32_t data, uint32_t new, unsigned int size,
>  
>  uint32_t vpci_read(pci_sbdf_t sbdf, unsigned int reg, unsigned int size)
>  {
> -    const struct domain *d = current->domain;
> +    struct domain *d = current->domain;
>      const struct pci_dev *pdev;
>      const struct vpci_register *r;
>      unsigned int data_offset = 0;
> @@ -327,6 +343,7 @@ uint32_t vpci_read(pci_sbdf_t sbdf, unsigned int reg, unsigned int size)
>      if ( !pdev )
>          return vpci_read_hw(sbdf, reg, size);
>  
> +    read_lock(&d->vpci_rwlock);

After taking the domain lock you need to check that pdev->vpci !=
NULL, as vpci_remove_device will set pdev->vpci == NULL before
removing the device from the domain. Same applies to vpci_add_handlers
which will be called with the device already added to the domain, but
with pdev->vpci == NULL.

We would also need some kind of protection arround
pci_get_pdev_by_domain so that devices are not removed (from the
domain) while we are iterating over it.

>      spin_lock(&pdev->vpci->lock);
>  
>      /* Read from the hardware or the emulated register handlers. */
> @@ -371,6 +388,7 @@ uint32_t vpci_read(pci_sbdf_t sbdf, unsigned int reg, unsigned int size)
>          ASSERT(data_offset < size);
>      }
>      spin_unlock(&pdev->vpci->lock);
> +    read_unlock(&d->vpci_rwlock);
>  
>      if ( data_offset < size )
>      {
> @@ -410,14 +428,37 @@ static void vpci_write_helper(const struct pci_dev *pdev,
>               r->private);
>  }
>  
> +static bool vpci_header_write_lock(const struct pci_dev *pdev,
> +                                   unsigned int start, unsigned int size)

I think this should live in header.c, for consistency.

I'm also not sure it's worth adding vpci_offset_cmp: you just need to
do a range overlap check, and that can be easily open coded. It's just
the first 'if' in vpci_register_cmp that you want, the rest of the
code is just adding overhead.

> +{
> +    /*
> +     * Writing the command register and ROM BAR register may trigger
> +     * modify_bars to run which in turn may access multiple pdevs while
> +     * checking for the existing BAR's overlap. The overlapping check, if done
> +     * under the read lock, requires vpci->lock to be acquired on both devices
> +     * being compared, which may produce a deadlock. It is not possible to
> +     * upgrade read lock to write lock in such a case. So, in order to prevent
> +     * the deadlock, check which registers are going to be written and acquire
> +     * the lock in the appropriate mode from the beginning.
> +     */
> +    if ( !vpci_offset_cmp(start, size, PCI_COMMAND, 2) )
> +        return true;
> +
> +    if ( !vpci_offset_cmp(start, size, pdev->vpci->header.rom_reg, 4) )

No need for the comparison if rom_reg is unset. Also you can OR both
conditions into a single if.

> +        return true;
> +
> +    return false;
> +}
> +
>  void vpci_write(pci_sbdf_t sbdf, unsigned int reg, unsigned int size,
>                  uint32_t data)
>  {
> -    const struct domain *d = current->domain;
> +    struct domain *d = current->domain;
>      const struct pci_dev *pdev;
>      const struct vpci_register *r;
>      unsigned int data_offset = 0;
>      const unsigned long *ro_map = pci_get_ro_map(sbdf.seg);
> +    bool write_locked = false;
>  
>      if ( !size )
>      {
> @@ -440,7 +481,17 @@ void vpci_write(pci_sbdf_t sbdf, unsigned int reg, unsigned int size,
>          return;
>      }
>  
> -    spin_lock(&pdev->vpci->lock);
> +    if ( vpci_header_write_lock(pdev, reg, size) )
> +    {
> +        /* Gain exclusive access to all of the domain pdevs vpci. */
> +        write_lock(&d->vpci_rwlock);
> +        write_locked = true;

Here you need to check that pdev->vpci != NULL...

> +    }
> +    else
> +    {
> +        read_lock(&d->vpci_rwlock);

...and also here.

> +        spin_lock(&pdev->vpci->lock);
> +    }
>  
>      /* Write the value to the hardware or emulated registers. */
>      list_for_each_entry ( r, &pdev->vpci->handlers, node )
> @@ -475,7 +526,14 @@ void vpci_write(pci_sbdf_t sbdf, unsigned int reg, unsigned int size,
>              break;
>          ASSERT(data_offset < size);
>      }
> -    spin_unlock(&pdev->vpci->lock);
> +
> +    if ( write_locked )
> +        write_unlock(&d->vpci_rwlock);
> +    else
> +    {
> +        spin_unlock(&pdev->vpci->lock);
> +        read_unlock(&d->vpci_rwlock);
> +    }
>  
>      if ( data_offset < size )
>          /* Tailing gap, write the remaining. */
> diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
> index 37f78cc4c4c9..ecd34481a7af 100644
> --- a/xen/include/xen/sched.h
> +++ b/xen/include/xen/sched.h
> @@ -444,6 +444,9 @@ struct domain
>  
>  #ifdef CONFIG_HAS_PCI
>      struct list_head pdev_list;
> +#ifdef CONFIG_HAS_VPCI
> +    rwlock_t vpci_rwlock;
> +#endif
>  #endif
>  
>  #ifdef CONFIG_HAS_PASSTHROUGH
> diff --git a/xen/include/xen/vpci.h b/xen/include/xen/vpci.h
> index e8ac1eb39513..e19e462ee5cb 100644
> --- a/xen/include/xen/vpci.h
> +++ b/xen/include/xen/vpci.h
> @@ -88,6 +88,8 @@ struct vpci {
>           * is mapped into guest p2m) if there's a ROM BAR on the device.
>           */
>          bool rom_enabled      : 1;
> +        /* Offset to the ROM BAR register if any. */
> +        unsigned int rom_reg;

Could you please place this field after 'type'? That will avoid some
padding in the structure.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Thu Feb 10 16:44:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 10 Feb 2022 16:44:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269926.464070 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nICYP-0000q6-S1; Thu, 10 Feb 2022 16:44:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269926.464070; Thu, 10 Feb 2022 16:44:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nICYP-0000pz-Ob; Thu, 10 Feb 2022 16:44:21 +0000
Received: by outflank-mailman (input) for mailman id 269926;
 Thu, 10 Feb 2022 16:44:21 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=0WSD=SZ=citrix.com=Jane.Malalane@srs-se1.protection.inumbo.net>)
 id 1nICYP-0000pt-1F
 for xen-devel@lists.xenproject.org; Thu, 10 Feb 2022 16:44:21 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b037ec67-8a90-11ec-8f75-fffcc8bd4f1a;
 Thu, 10 Feb 2022 17:44:19 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b037ec67-8a90-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644511459;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=jnAPNwQQMyD9COZq7rihczUEKGyFhk3h5JAkxSS0Za4=;
  b=cpcf2xj8PMTEbCT1FgLXR2HLg63Jav/oNLjt7KVG5rzwmpwu3B3ZTeMO
   Kmspd9B9VE4uZKpe7KmiX3xVT8a7VCcMYFpaHrawCkC583oJd7lSHowaH
   vmOL8QLAVInRaRhqTCia3DxwahAjOunbB+6agfrAgaZgyjWTIClGJMZSS
   4=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: Tyvxnc8Bq5saz9L51uqLhndi0e9jT8Ll3euU3pa6NKQ4xjQw9vx1rIRJWCa0wc1ZuNKAKq3wuo
 MhypfAJrz2LfDM+tr6iK9r3IhvQgVUNZ0Tr/60AXsOgml+vTWv6EuLpaSy3obQCblFTv2/aPSl
 GzHKdKeC0hy3JNeB9wzJ7b9lYZOa5sGZKGHlYzbICDC+tm69UZT5Ptz1c7X9a6ME4y6EIGE8Yy
 J6hUdPk0diDBnuFfJRh1zGKCFzHjlU6Ea8H76aRD7gfW4Tc0UwLxXBRiMhpz6qflPfJd/5u/FE
 tMeccYntJoaaZS9KMNjYrscS
X-SBRS: 5.1
X-MesageID: 63852661
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:kOiid6pgx+yaYXPGnVa6ciQKESVeBmJcYxIvgKrLsJaIsI4StFCzt
 garIBnSP/7fNjH9e48lYNyy8U5T6p/dmoVlTAE6qysyFiIW85uZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlZT4vE2xbuKU5NTsY0idfic5Dndx4f5fs7Rh2NQw24HhW1nlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCnbKMQyI1eaDoouE6XhxBFHBTZ4lK27CSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFKEWvHwm6DjdBPIvR53rSKTW/95Imjw3g6iiGN6AP
 JpEM2QxNXwsZTVBHGcXCLUbnt2Yg1rcdyNirVbNmq8otj27IAtZj+G2bYu9lsaxbd5Ogk+Sq
 2bC/mL4KhIXLtqSzXyC6H3Eru3SmSL2XqoCGbv+8eRl6HWtwWgUBAwTREGMi/CzgU6jWPpSM
 0URvCEpqMAa+EW1Q/HnUha/oXrCuQQTM/JPF8Uq5QfLzbDbiy6JC25BQjNfZdgOsM4tWSdsx
 lKPh8nuBzFkrPuSU3313rWeoC62OCMVBXQffiJCRgwAi/Hhr5s0lQnnVct4Hei+ididJN3r6
 2nU9m5k3exV1JNVkfXglbzav96yjrb1RCspoQjzZGeC4wZgY9+IPaikyleOuJ6sM72lZlWGu
 XEFne2X4+YPEYyBmUSxfQkdIF26z63baWOB2DaDC7Fkrm3woCD7Iei89RkjfB8BDyoSRdP+j
 KY/Uyt17YQbAnalZLQfj2mZW5VzlviI+TgIu5npgjtyjnpZKVfvEMJGPxf4M4XRfK4EyvhX1
 XCzK5jEMJriIf47pAdavs9EuVPR+ggwxHnIWbfwxAm93LyVaRa9EOlZbAfVNLhht/Pb8W05F
 uqz0ePRkn2zt8WkPEHqHXM7dwhWfRDX+7iqwyCoSgJzClU/QzxwYxMg6bggZ5Zkj8xoehTgp
 RmAtrtj4AOn3xXvcFzSAlg6Me+Hdcsv/BoTYH13VX71iidLXGpaxPpGH3fBVeJ8r7ILID8dZ
 6RtRvhs9dwRFmqZq25AMfEQbuVKLXyWuO5HBAL8CBAXdJ98XQ3ZvNjiewrk7i4VCSSr88A5p
 tWdOsnzG/LvnixuU5TbbuyB1VS0sSRPke5+RRKQcNJSZF/t4M5hLCmo1q07JMQFKBPiwDqG1
 lnJXUdE9LeV+4JlosPUga2krpuyF7csFERtAGSGv629MjPX/zT/zNYYAvqIZz3USEj95L6mO
 bdO1/j5PfBexARKvoNwHqxF16U749ez9bZWwh49RCfAbkixC6MmKX6DhJEduqpIz75fmA23R
 kPQpYUKZeTXYJvoSQdDKhAkY+KP0eAvtgPTtfllcl/n4CJX/aacVRkANRe7lyEAfqB+N5kow
 Ll9tZdOuRC/kBcjLv2PkjtQqzaXNnUFXqgq6sMaDYvshlZ5w11Oe8WBWCr/4ZXJYNRQKEg6Z
 DSTgfOa1bhbw0PDdVs1FGTMgrUB1chf5kgSwQ9QPUmNl/rEmuQzjU9Y/jkARwhIyglKjrBoM
 W9xOkwpfaiD8l+EXiSYs7xAz+2ZOCCkxw==
IronPort-HdrOrdr: A9a23:A3HMX6m+NAvlpqcq3i4RoEEn1/TpDfODimdD5ihNYBxZY6Wkfp
 +V8sjzhCWatN9OYh0dcIi7SdW9qXO1z+8Q3WGIVY3SEjUOy1HYU72KirGSggEIeheOudK1sJ
 0AT0EQMqyJMbEXt7eZ3OD8Kadc/DDlytHpuQ699QYXcegCUcgJhG0Vanf5LqQ1fng9OXNQLu
 vH2iMtnUvGRZ1jVLXDOpBzZZmkmzSkruOCXTc2QzocrCWehzKh77D3VzKC2A0Fbj9JybA+tU
 DYjg3Q/MyYwrKG4y6Z81WWw4VdmdPnxNcGLteLkNIpJjLljRvtTJh9WoeFoCs+rIiUmRQXeZ
 j30lId1vZImjTsl1KO0F3QMs7boW8TAkrZuBulaL3Y0JTErXwBepF8bMliA2XkAgIbzaBBOe
 Rwrj+kXtNsfGP9tTW46N7SWx5wkE2o5XIkjO4IlnRaFZATcblLsOUkjQlo+bo7bWrHAbocYa
 JT5QDnlYJrWELfa2qcsnhkwdSqUHh2FhCaQlIassjQ1zRNhnh2w0YR2cRaxx47hd4AYogB4/
 6BPrVjlblIQMNTZaVhBP0ZSc/yDmDWWxrDPG+bPFyiHqAaPHDGrYLx/dwOlayXUY1NyIF3lI
 XKUVteu2J3c0XyCdeW1JkO6RzJSHXVZ0Wl9iif3ekOhlTRfsuYDcSzciFYryL7mYRtPiTyYY
 fHBK5r
X-IronPort-AV: E=Sophos;i="5.88,359,1635220800"; 
   d="scan'208";a="63852661"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=RK6wEUzNKPwO7/AD10QqV7BPeS6CbwGF1bV0GOfL1mWNlnXKa9BvqNJiPT4mmrKA0FabfBdu1VZAkCuWCXWFSeGZxOoE4MtwB+OxtzctkHY6AAlARNRr6+vbyget9DPTeg5AoTeJsE5Uw430EDqV8a7jfrik6jsnTBhmtYoM3gRbWsbtQkUtPz9KKPpsXhb+R2A883PnndwFSyijDuKvQv+7vDYJKZ7hhur+8WNqFPswUmIAT1LoW3kEc7xbgLkZUoXIxZPQMObefOxI2zEGzspqnCq2oy1zHvrbm+3mihRk0ZYc1GCUQQfninyLxPk0S1L8Udq5jcVY1FSwxFi4RA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=jnAPNwQQMyD9COZq7rihczUEKGyFhk3h5JAkxSS0Za4=;
 b=RT1rHm+1IuoGroVDwObZkBv4vMf1zIVwCWFNXnr185j9Z/3E7dKMyKVdpKWWKgjbaLL/nrLtpKQoqjWsIKfFp0R0B3K8CvFA3dO2yfpu9Vhwv1cHlPVX4affM5Gl5k5xFC2LrJYx4fetWjRF48aLU9gsYZrNCCOJxI1d7/+z0SYmZriq7Ad7gwmXoPN1PYZbyFQqoWHyOZLK0swS0MkV6d0d1+V+M9upKoX3n0jruySC9yzS0Ljo2y2quZijifB17ariTL2LG1XeCgrtrJhoszCzIhHLgwtuTmJYZLnZfAicc9rxyXoZ+GP+NGA7WQVV9NdnHXOSHahiolvmWcHIfg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=jnAPNwQQMyD9COZq7rihczUEKGyFhk3h5JAkxSS0Za4=;
 b=Eq9fP9fcqc2CDm6isPH/hG4xmCSyDkQMnpa4Rii7cSrG631pGpXsj5FA1fxdo4zpPq9ymlNul9vOr7RPGeNny0dwJSs6nSS9mnj2fpGwrLgFS8grm9UlpyIKA/MJMuhrChi3WW22jXZ9CRcuEmfd4SEyJotIomAUjigi15KXvD0=
From: Jane Malalane <Jane.Malalane@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>, "Anthony
 Perard" <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, "Andrew
 Cooper" <Andrew.Cooper3@citrix.com>, George Dunlap
	<George.Dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, Julien Grall
	<julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, "Christian
 Lindig" <christian.lindig@citrix.com>, David Scott <dave@recoil.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v2 2/2] x86/xen: Allow per-domain usage of hardware
 virtualized APIC
Thread-Topic: [PATCH v2 2/2] x86/xen: Allow per-domain usage of hardware
 virtualized APIC
Thread-Index: AQHYHE+bJUKmznundkO+jjEyYTnVA6yMk94AgABuRQA=
Date: Thu, 10 Feb 2022 16:44:13 +0000
Message-ID: <be53fdb6-aa5d-ef6c-aedf-64a8fc1c3d11@citrix.com>
References: <20220207182101.31941-1-jane.malalane@citrix.com>
 <20220207182101.31941-3-jane.malalane@citrix.com>
 <YgTkRtwqmZsLZIXo@Air-de-Roger>
In-Reply-To: <YgTkRtwqmZsLZIXo@Air-de-Roger>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: b22dce0d-316e-4078-d58b-08d9ecb491f8
x-ms-traffictypediagnostic: MWHPR03MB2782:EE_
x-microsoft-antispam-prvs: <MWHPR03MB2782029C669A5ED60BA6DF3A812F9@MWHPR03MB2782.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:2733;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 2aYaHtRSVF8nzxYX98IqffVK3hyLcb9MdX5hLyKCW14x5oE4N12bvuB/jZTlquPVQbxS2jr+EWvVgbTf7UhBmi5woj/Uwkq0wa+QqQOUYAWkYYPR+Ta9yFq7IpLSc/StOdqCarQcnC3cmMNzeC3yeplto43+vfMv38BWPoFmuCoUXTkWu5qzHJQSsGpIHemMMFhi/CmqyHWXwAZEoJoiikRrHGdPRM5JMrPq5lmP0Wkk7ZMijY/gwpTmDOieaDTm1WGrv9ntDFZ6d1rvR5dt8stfx1yRBhDRFjJOeTtXnZn0LZJUHvkL0NpRiBLy0QGp1cJXYKn26smv8US2nMjKURljhSzOC2XoWfuiibdJOVsdlQ2hGezuCQhKUxEeg8nxLWN+jsUDAVuvDLv+IQGz404kH51E8riFiEVJKarBVT8SbGzyiB1JRYMaTHWaoG86+bGi+wAIuM9D+hfBBVMaiiLysN7nnEdpREFsVSemooooxzTJgUFwF2FMX8fd0eXflheUUp7DT4dwKh7wywSJInNRJUVbFGOFoqApnve3peEVUah2rMRbBfCPRgMbaoTDp8d+agyyR02PE8djrQ7MmFaH6YO0Qp5U4JhZ5yx+oIxKTFj34TiUg2vrRVm2xmAZOUvKPgBk7k96r8q7VuRqxiBEAkrpX4/yKe1YsU7Orutn4OZ/tAIFRqZXHRMBYbxN/J+ZPq+/Z9LrA6D2gaFr3pdjD3TmdqecL1E5FEh0yT4+D7i8SuUNYPGPdVNNQl6E
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR03MB3386.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6486002)(2906002)(37006003)(54906003)(71200400001)(316002)(26005)(186003)(2616005)(5660300002)(31696002)(6636002)(8936002)(66556008)(66476007)(64756008)(66446008)(66946007)(8676002)(6862004)(91956017)(4326008)(86362001)(76116006)(36756003)(6506007)(122000001)(6512007)(508600001)(82960400001)(38070700005)(31686004)(38100700002)(53546011)(83380400001)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?emY5MG5Rd1hoQUYrWDBQWmJ1KzVVOFBoUjJLUlY1TjQxb0xsT3JHWURkZ1hC?=
 =?utf-8?B?bDVRd1laQXNRb2grdHh5M2RJV0YxVFhkR1QweG9TcTl0Z1lvSVRZVkU1UDJN?=
 =?utf-8?B?YjdjZ3NURFdoR2NORGJkdUNybWVxVXM4VmNjQVBZZXVEL3pndWhMaFhBandY?=
 =?utf-8?B?dzZCblR0dGlCeWlJVnh4ZlpmdExZVkFsNExqazZGTTNEWExlSVgzc1ZFSExU?=
 =?utf-8?B?NE5GazFURmdVQldGTFA2Mk50UjJXbnhGODFhTExNc0NzaHJnaHFMbWlGT3Rr?=
 =?utf-8?B?Qkg4cVRINEJ1M2wxbnNzdzA3eXNPYkQ5WHJFb1pkUnFBR1hmcFhFN3FGWEtD?=
 =?utf-8?B?WDcvWE5MREh6STl6MGpPUHlONnA4YWpiT2c2R25BSGsrOFhkRVFkT3dLck13?=
 =?utf-8?B?RHFTd3FxS084Q29kWnMyUUZuNUxrdFFOOWN4V3IzRXE0RlhCcGxUU2FHa0k1?=
 =?utf-8?B?Z2szRHAvVTl4MnpaeWlHRXUxaWRobEtVNGFMQmkvL3pNaG9IUnQwTXo4bHRJ?=
 =?utf-8?B?dTBmVVJWd3lpeGlVdEJyUjN4UUJveEE5SUx3TCtBNkpaNmQveENWWVhwREI2?=
 =?utf-8?B?NFZJcFpjN3hWdys0UHNIMFdpL3JwVGpHVWcrTjBjWG00SjdaR0NrdWhnNC9R?=
 =?utf-8?B?YnFkWkdtdlpPaGs4NjZadDJlb0lad1l6dVlRMHhMTWNHd3hqYU1WblZxdERw?=
 =?utf-8?B?M0NveGUrMUQ3MVh0K2NmdjJLTnBQZldaSHhLVEl5cXpmOVUvSFJmOGlEL1hz?=
 =?utf-8?B?eWp5MkdSK3l0K3EzUXYrU2RVY215ZTR3N2gwRTkzR05mMjVHaWlvaUFLRll3?=
 =?utf-8?B?UHdJQ0dMQ1d2UTNQZzZBSUxiSHhPQnMxMS92OWJ6RWdONHdQaTlUSWp5Uitq?=
 =?utf-8?B?eGE5VnlCVTJSeTh1R05McDYrZ3M1VkR2Z0Y3QU9ZeEVUQlZ6NzFuWUxMMWNo?=
 =?utf-8?B?RTVUeFZiSjY3bVBrZVAyUUo0THdKSnN4b1dySEE1QkVvMXE4R0pkcnlRSGRu?=
 =?utf-8?B?MytCZXU0ekNRdkIyM3NJTXdYcEYzWFZJT2pyZ09kMjZEQWorYUx6WkQrakRO?=
 =?utf-8?B?KzkrYXZ5dTJrV1VIWHVSNk9pR25Ja0dHZ3pjUzZtV0NOUFNtTEJGeG9EWFd6?=
 =?utf-8?B?UjhiMW5BcGVBUzVOMEliRGlBejd3MDB3RXQyR3dlVGxtT2xEa3NMdDhhd05M?=
 =?utf-8?B?d3pmMm5jalZaMm1hV1NCcVRJUjVKV0VnQndWbWd4MXZ2cFl6RjhQdE9MZ0xn?=
 =?utf-8?B?K2hsN0NkaXlHOGR1b2xSd3B4aDk4bERxR3RCbmVTWGMxQm9pUWFSTisra29T?=
 =?utf-8?B?cm8zanI2L2t6N0hYNnVqOTNhZy95WWExNzQvOGoxRjltcm1HNEhjSExnLzg3?=
 =?utf-8?B?U2FRUUtZMUZJdjZPZHo1WmM2czNCcXQ4czlaZ3F6MHlLc2YrZnNkL1U5OHhU?=
 =?utf-8?B?a04rUTZzbmpNMmNHYXJiUmdJQTBTVFdWeWFFZVJJRlFlcnJ4M2tqbmc3UFpV?=
 =?utf-8?B?d1U5QXZWVk01R202eWdhaEp6TFd1NFpka013dUt6K2xoVVpnSks3WVVCSnJW?=
 =?utf-8?B?S3MxWmd6V0RUZk8rZlRsR3ZHVkxiRUxnSVdRc0tjTmkwTWFvTlMyTGwrOFBq?=
 =?utf-8?B?LzhjeityTWx5V29ubUV3d1hmWGQ5QkR0VmVHOFFJcGJmVGlNcEFnNVZqNTI2?=
 =?utf-8?B?aUdsVXJnS0V6OHV0bko2N1lZLzA4ajR2MW5BbmkraW9GdEVuUTlXMmdZd0lD?=
 =?utf-8?B?c3BndnkyZ3FON0FxOVdVREtsR0RLbFdlM0owYVpYZkk2ZkVvVjRPZXRmb3pj?=
 =?utf-8?B?eWpiOXk1TzRva01HUWl2S0pGaW85NlAwWXNvUXlHdU1zNjFWUGZLUWtaNWlM?=
 =?utf-8?B?eGh6UVd5VFFqT3RDTWc2ZlgvOVlVWHZ4RENSVFhGdFNNcm9UcGE0VEZUQnlR?=
 =?utf-8?B?NFI2QllNMHg2dWIwdW1vOVhBcG1FT29Zc1ljSVVQQ3lKR1RzSGlFTCtHOVNp?=
 =?utf-8?B?TkZSQmdrWUJsYkJ5SjJHbzdBUWtkRUpUdGwySFl2cEM2elRVa2JkVGVZdmVY?=
 =?utf-8?B?ODgveVY0M3UyZ0orM0hnNjhtNFZBZWdEbGxVK2RxcGl2c2tVdlh5N2FZQ280?=
 =?utf-8?B?cnhkUUZSSy82T2xVUGg2WGNGSmNSUTBjdnBJb2Z6YlNGWThxMDBjc0kvWmJ5?=
 =?utf-8?B?MGkyc09DODlpaDA2Y1NvSE1NbEtnbFhkbk55cUdJWmxaYzVnVDhyenBWVWlv?=
 =?utf-8?Q?+B8lVnOW+PzLFRcXB86ZxFPzm0srx+qRGuieT7oz+8=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <2FA8776A79097B4F9C5BAB149B0163E9@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM5PR03MB3386.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b22dce0d-316e-4078-d58b-08d9ecb491f8
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Feb 2022 16:44:13.5970
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ZeVPCpp42OPXI0ByYw/xdOx/lPo8MwLfL7biQO7+6BS1qBzkrmkATPSkdswthbmB1QsyiJ0+zwdhNP70g1PKO1z5QyB3TtGgZ+UrfLpgeuM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2782
X-OriginatorOrg: citrix.com

T24gMTAvMDIvMjAyMiAxMDowOSwgUm9nZXIgUGF1IE1vbm7DqSB3cm90ZToNCj4gT24gTW9uLCBG
ZWIgMDcsIDIwMjIgYXQgMDY6MjE6MDFQTSArMDAwMCwgSmFuZSBNYWxhbGFuZSB3cm90ZToNCj4+
IEludHJvZHVjZSBhIG5ldyBwZXItZG9tYWluIGNyZWF0aW9uIHg4NiBzcGVjaWZpYyBmbGFnIHRv
DQo+PiBzZWxlY3Qgd2hldGhlciBoYXJkd2FyZSBhc3Npc3RlZCB2aXJ0dWFsaXphdGlvbiBzaG91
bGQgYmUgdXNlZCBmb3INCj4+IHh7Mn1BUElDLg0KPj4NCj4+IEEgcGVyLWRvbWFpbiBvcHRpb24g
aXMgYWRkZWQgdG8geGwgaW4gb3JkZXIgdG8gc2VsZWN0IHRoZSB1c2FnZSBvZg0KPj4geHsyfUFQ
SUMgaGFyZHdhcmUgYXNzaXN0ZWQgdml0dWFsaXphdGlvbiwgYXMgd2VsbCBhcyBhIGdsb2JhbA0K
Pj4gY29uZmlndXJhdGlvbiBvcHRpb24uDQo+Pg0KPj4gSGF2aW5nIGFsbCBBUElDIGludGVyYWN0
aW9uIGV4aXQgdG8gWGVuIGZvciBlbXVsYXRpb24gaXMgc2xvdyBhbmQgY2FuDQo+PiBpbmR1Y2Ug
bXVjaCBvdmVyaGVhZC4gSGFyZHdhcmUgY2FuIHNwZWVkIHVwIHh7Mn1BUElDIGJ5IHJ1bm5pbmcg
QVBJQw0KPj4gcmVhZC93cml0ZSBhY2Nlc3NlcyB3aXRob3V0IHRha2luZyBhIFZNIGV4aXQuDQo+
Pg0KPj4gQmVpbmcgYWJsZSB0byBkaXNhYmxlIHh7Mn1BUElDIGhhcmR3YXJlIGFzc2lzdGVkIHZp
dHVhbGl6YXRpb24gY2FuIGJlDQo+PiB1c2VmdWwgZm9yIHRlc3RpbmcgYW5kIGRlYnVnZ2luZyBw
dXJwb3Nlcy4NCj4gDQo+IE1pZ2h0IGJlIHdvcnRoIGFkZGluZyBhIG5vdGUgdG8gdGhlIGNvbW1p
dCBsb2cgaW4gb3JkZXIgdG8gbm90ZSB0aGF0DQo+IHZteF9pbnN0YWxsX3ZsYXBpY19tYXBwaW5n
IGRvZXNuJ3QgcmVxdWlyZSBtb2RpZmljYXRpb25zIHJlZ2FyZGxlc3Mgb2YNCj4gd2hldGhlciB0
aGUgZ3Vlc3QgaGFzIHZpcnR1YWxpemVfYXBpY19hY2Nlc3NlcyBlbmFibGVkIG9yIG5vdC4NCj4g
DQo+IFNldHRpbmcgdGhlIEFQSUNfQUNDRVNTX0FERFIgVk1DUyBmaWVsZCBpcyBmaW5lIGV2ZW4g
aWYNCj4gdmlydHVhbGl6ZV9hcGljX2FjY2Vzc2VzIGlzIG5vdCBlbmFibGVkIGZvciB0aGUgZ3Vl
c3Q6IGFzIGxvbmcgYXMgdGhlDQo+IGZlYXR1cmUgaXMgc3VwcG9ydGVkIGJ5IHRoZSBDUFUgdGhl
IGZpZWxkIHdpbGwgZXhpc3QuDQpPaCByaWdodC4gV2lsbCBhZGQgdGhlc2UgdHdvIHBvaW50cy4N
Cg0KVGhhbmtzLA0KDQpKYW5lLg==


From xen-devel-bounces@lists.xenproject.org Thu Feb 10 16:55:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 10 Feb 2022 16:55:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269933.464081 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nICj2-0002JZ-TG; Thu, 10 Feb 2022 16:55:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269933.464081; Thu, 10 Feb 2022 16:55:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nICj2-0002JS-Q4; Thu, 10 Feb 2022 16:55:20 +0000
Received: by outflank-mailman (input) for mailman id 269933;
 Thu, 10 Feb 2022 16:55:19 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2FaY=SZ=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1nICj1-0002JM-4W
 for xen-devel@lists.xenproject.org; Thu, 10 Feb 2022 16:55:19 +0000
Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com
 [2a00:1450:4864:20::62e])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 395415bc-8a92-11ec-8f75-fffcc8bd4f1a;
 Thu, 10 Feb 2022 17:55:17 +0100 (CET)
Received: by mail-ej1-x62e.google.com with SMTP id d10so16776552eje.10
 for <xen-devel@lists.xenproject.org>; Thu, 10 Feb 2022 08:55:17 -0800 (PST)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id n2sm7514910ejl.55.2022.02.10.08.55.15
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Thu, 10 Feb 2022 08:55:16 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 395415bc-8a92-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=gx+i6h+BQnSF83taSuIXVZ+Cb8cmjT7BXaMcWANcbbA=;
        b=D+ZbobNgWusV+Fgklq5mj/FI/NOTCpt0FCeQGZ5fwHg0M70UpSuTDfutOJQAjt5MET
         yutAtkdUpK1d1IypOR6UyGwBcJLrlSRdOUS0vdYJ1CanWZwhHCrV5eLUxtsVHvT4NUFh
         F1FosPEXMhXnyd69wPNz4ToE/e4Mo11ZhY+vZf1olGP2qSdL1sU/x2Jn8dQvUMkxXZ5B
         8l0rQMacnFkDjyHGKsKyuGbVkjo1eMKQdXbIW3BH17kdHjaTIj+BXg/VVKX/t4bzj2vH
         c+UK6Mkiuic+xgRFZgrFpqBsg7anKgynjAVZA/fL1nqpILD+9IgE7ad4rYtC+sNiIkXT
         DgXg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=gx+i6h+BQnSF83taSuIXVZ+Cb8cmjT7BXaMcWANcbbA=;
        b=h+yPfTahIvMlerfV16dtpjAsbS2Ck/N2tbosRwlW6NY9dVA7zF+HJTZSww3hcrpSr0
         tDf6s+ekAcIzxG8uyDK/lEEYV+rQ+fcd75Cj0C85j2tEHT9NCplVkXi6EqpjLW5+K7nL
         jBnFtAY19v2CTs8Xvdnokcet0bQ7ggs+FyREv7KHCqww/P8qmJxeySmf0vAbstvpRuV0
         Fo/psrviDz9t0+QeSX1ddXOv+dwBW4Hif8wRyk5wz24qkLUDztNZXvlRmMpdut7MAE9Z
         ic/39tdLtLHpq5spSQ9snS2J2KLALmkm6Ivjh73sPfSfTzriWuYVEIyUWyQ4xxjloJRG
         3mbQ==
X-Gm-Message-State: AOAM530Tn2wflh5ZFFfkft0Ikdby1OaLBnyMAP7uFto8FQEcEl/rbBn4
	++qPXp8bYzngO4z8OfpRvIw=
X-Google-Smtp-Source: ABdhPJxtN4V54vnuNXJUZ2lZubYusRvFRS+Xj1kPnIUSUHgzOi2Raj8E36WMrdMwPrkT3sueyU4EGA==
X-Received: by 2002:a17:906:72db:: with SMTP id m27mr7273218ejl.105.1644512116810;
        Thu, 10 Feb 2022 08:55:16 -0800 (PST)
Subject: Re: [PATCH V5] xen/gnttab: Store frame GFN in struct page_info on Arm
To: Julien Grall <julien@xen.org>
Cc: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Jan Beulich <jbeulich@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Bob Eshleman <bobbyeshleman@gmail.com>,
 Alistair Francis <alistair.francis@wdc.com>,
 Connor Davis <connojdavis@gmail.com>
References: <1641424268-12968-1-git-send-email-olekstysh@gmail.com>
 <a54213c4-1c68-694e-c130-d95faeef3953@xen.org>
 <78d94e1e-6db4-25c1-adb8-e4bdbfe42774@epam.com>
 <82d8bfe0-cb46-d303-6a60-2324dd76a1f7@xen.org>
 <79fbf83e-d25e-2634-9769-8e07634bfd63@epam.com>
 <a104d3ea-170e-8175-ac04-abfcebb4ae29@xen.org>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <f9e3ee5b-0811-8317-42c2-61c8cdbfe254@gmail.com>
Date: Thu, 10 Feb 2022 18:55:14 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <a104d3ea-170e-8175-ac04-abfcebb4ae29@xen.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US


On 10.02.22 11:46, Julien Grall wrote:
>
>
> On 08/02/2022 19:50, Oleksandr Tyshchenko wrote:
>>
>> On 08.02.22 13:58, Julien Grall wrote:
>>> Hi,
>>
>> Hi Julien
>
> Hi,


Hi Julien


Thank you for the clarifications!


>
>>>
>>>
>>> (Jan please confirm) If I am not mistaken, on x86, a read to the M2P
>>> is not always protected. But they have code within the P2M lock to
>>> check any difference (see p2m_remove_page()). I think we would need
>>> the same, so we don't end up to introduce a behavior similar to what
>>> XSA-387 has fixed on x86.
>>
>>
>> ... OK, I assume you are speaking about the check in the loop that was
>> added by the following commit:
>> c65ea16dbcafbe4fe21693b18f8c2a3c5d14600e "x86/p2m: don't assert that the
>> passed in MFN matches for a remove"
>
> Yes, this is the one I Have in mind.


good


>
>> Also, I assume we need that check in the same place on Arm (with P2M
>> lock held), which, I think, could be p2m_remove_mapping().
>
> I believe so. 


good


> Can you do some testing to check this would not break other types of 
> mapping? (Booting a guest and using PV device should be enough).


Sure, already checked and will check more thoroughly before submitting.


>
>
>>
>> I ported the check from x86 code, but this is not a verbatim copy due to
>> the difference in local P2M helpers/macro between arches, also I have
>> skipped a part of that check "|| t == p2m_mmio_direct" which was added
>> by one of the follow-up commit:
>> 753cb68e653002e89fdcd1c80e52905fdbfb78cb "x86/p2m: guard (in particular)
>> identity mapping entries"
>> since I have no idea whether we need the same on Arm.
>
> I am not entirely sure. For now, I would drop it so long the behavior 
> stay the same (i.e. it will go ahead with removing the mappings).t.


ok, will drop.


>
>
>> Below the diff I have locally:
>>
>> diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
>> index 5646343..90d7563 100644
>> --- a/xen/arch/arm/p2m.c
>> +++ b/xen/arch/arm/p2m.c
>> @@ -1315,11 +1315,32 @@ static inline int p2m_remove_mapping(struct
>> domain *d,
>>                                         mfn_t mfn)
>>    {
>>        struct p2m_domain *p2m = p2m_get_hostp2m(d);
>> +    unsigned long i;
>>        int rc;
>>
>>        p2m_write_lock(p2m);
>> +    for ( i = 0; i < nr; )
>> +    {
>> +        unsigned int cur_order;
>> +        bool valid;
>> +        mfn_t mfn_return = p2m_get_entry(p2m, gfn_add(start_gfn, i),
>> NULL, NULL,
>> +                                         &cur_order, &valid); > +
>> +        if ( valid &&
>
> valid is a copy of the LPAE bit valid. This may be 0 if Xen decided to 
> clear it (i.e when emulating set/way). Yet the mapping itself is 
> considered valid from Xen PoV.
>
> So you want to replace with a different check (see below).


Hmm, I got it, so ...


>
>
>> +             (!mfn_valid(mfn) || !mfn_eq(mfn_add(mfn, i), 
>> mfn_return)) )
>> +        {
>> +            rc = -EILSEQ;
>> +            goto out;
>> +        }
>> +
>> +        i += (1UL << cur_order) -
>> +             ((gfn_x(start_gfn) + i) & ((1UL << cur_order) - 1));
>> +    }
>> +
>>        rc = p2m_set_entry(p2m, start_gfn, nr, INVALID_MFN,
>>                           p2m_invalid, p2m_access_rwx);
>> +
>> +out:
>>        p2m_write_unlock(p2m);
>>
>>        return rc;
>>
>>
>> Could you please clarify, is it close to what you had in mind? If yes, I
>> am wondering, don't we need this check to be only executed for xenheap
>> pages (and, probably, which P2M's entry type in RAM?) rather than for
>> all pages?
>
> From my understanding, for the purpose of this work, we only strictly 
> need to check that for xenheap pages.


  ... yes, but ...


>
>
> But I think it would be a good opportunity to harden the P2M code. At 
> the moment, on Arm, you can remove any mappings you want (even with 
> the wrong helpers). This lead us to a few issues when mapping were 
> overriden silently (in particular when building dom0).
> So I would say we should enforce it for every RAM mapping. 


... I think this makes sense, so the proper check in that case, I 
assume, should contain p2m_is_any_ram() macro:


diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
index 5646343..2b82c49 100644
--- a/xen/arch/arm/p2m.c
+++ b/xen/arch/arm/p2m.c
@@ -1315,11 +1315,32 @@ static inline int p2m_remove_mapping(struct 
domain *d,
                                       mfn_t mfn)
  {
      struct p2m_domain *p2m = p2m_get_hostp2m(d);
+    unsigned long i;
      int rc;

      p2m_write_lock(p2m);
+    for ( i = 0; i < nr; )
+    {
+        unsigned int cur_order;
+        p2m_type_t t;
+        mfn_t mfn_return = p2m_get_entry(p2m, gfn_add(start_gfn, i), 
&t, NULL,
+                                         &cur_order, NULL);
+
+        if ( p2m_is_any_ram(t) &&
+             (!mfn_valid(mfn) || !mfn_eq(mfn_add(mfn, i), mfn_return)) )
+        {
+            rc = -EILSEQ;
+            goto out;
+        }
+
+        i += (1UL << cur_order) -
+             ((gfn_x(start_gfn) + i) & ((1UL << cur_order) - 1));
+    }
+
      rc = p2m_set_entry(p2m, start_gfn, nr, INVALID_MFN,
                         p2m_invalid, p2m_access_rwx);
+
+out:
      p2m_write_unlock(p2m);

      return rc;
(END)


> Stefano, Bertrand, what do you think?
>
> Note that, I would like to see this change in a separate commit. It 
> will be easier to review.


ok, I will introduce this check by a separate patch.


>
>
>>
>>
>>>
>>>
>>> In addition to that, if p2m_get_xenheap_gfn() is going to be called
>>> locklessly. Then we need to make sure the update to type_info are
>>> atomic. This means:
>>>   - p2m_get_xenheap_gfn() should use READ_ONCE().
>>>   - p2m_set_xenheap_gfn() should use WRITE_ONCE(). We might even need
>>> to use cmpxchg() if there are other update to type_info that are not
>>> protected. I will let you have a look.
>>
>>
>> ... OK, I didn't find READ_ONCE/WRITE_ONCE in Xen. I am wondering, can
>> we use ACCESS_ONCE instead?
>
> Yes. Sorry, I keep forgetting we don't have READ_ONCE/WRITE_ONCE in Xen.


ok


>
>>
>> Below the diff I have locally:
>>
>> diff --git a/xen/arch/arm/include/asm/mm.h 
>> b/xen/arch/arm/include/asm/mm.h
>> index 9e093a6..b18acb7 100644
>> --- a/xen/arch/arm/include/asm/mm.h
>> +++ b/xen/arch/arm/include/asm/mm.h
>> @@ -373,7 +373,7 @@ unsigned int arch_get_dma_bitsize(void);
>>
>>    static inline gfn_t page_get_xenheap_gfn(const struct page_info *p)
>>    {
>> -    gfn_t gfn_ = _gfn(p->u.inuse.type_info & PGT_gfn_mask);
>> +    gfn_t gfn_ = _gfn(ACCESS_ONCE(p->u.inuse.type_info) & 
>> PGT_gfn_mask);
>>
>>        ASSERT(is_xen_heap_page(p));
>>
>> @@ -383,11 +383,14 @@ static inline gfn_t page_get_xenheap_gfn(const
>> struct page_info *p)
>>    static inline void page_set_xenheap_gfn(struct page_info *p, gfn_t 
>> gfn)
>>    {
>>        gfn_t gfn_ = gfn_eq(gfn, INVALID_GFN) ? 
>> PGT_INVALID_XENHEAP_GFN : gfn;
>> +    unsigned long type_info;
>>
>>        ASSERT(is_xen_heap_page(p));
>>
>> -    p->u.inuse.type_info &= ~PGT_gfn_mask;
>> -    p->u.inuse.type_info |= gfn_x(gfn_);
>> +    type_info = ACCESS_ONCE(p->u.inuse.type_info);
>> +    type_info &= ~PGT_gfn_mask;
>> +    type_info |= gfn_x(gfn_);
>> +    ACCESS_ONCE(p->u.inuse.type_info) = type_info;
>>    }
>>
>>    #endif /*  __ARCH_ARM_MM__ */
>>
>>
>> It is going to be a non-protected write to GFN portion of type_info.
>
> Well no. You are using a Read-Modify-Write operation on type_info. 
> This is not atomic and will overwrite any change (if any) done on 
> other part of the type_info.


I am confused a bit, to which my comment your comment above belongs (to 
the diff for page_set_xenheap_gfn() above or to sentence right after it)?
The "It is going to be a non-protected write to GFN portion of 
type_info." sentence is related to the diff for alloc_heap_pages() 
below. Sorry if I didn't separate the comments properly.


>
>
> If I am mistaken, there are two other places where type_info is 
> modified. One is...
>
>
>> But, at that time the page is not used yet, so I think this is harmless.
>>
>> diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c
>> index 50334a0..97cf0d8 100644
>> --- a/xen/common/page_alloc.c
>> +++ b/xen/common/page_alloc.c
>> @@ -1024,7 +1024,7 @@ static struct page_info *alloc_heap_pages(
>>                                     &tlbflush_timestamp);
>>
>>             /* Initialise fields which have other uses for free 
>> pages. */
>> -        pg[i].u.inuse.type_info = 0;
>> +        pg[i].u.inuse.type_info = PGT_TYPE_INFO_INITIALIZER;
>>             page_set_owner(&pg[i], NULL);
>>
>>         }
>
> ... this one. I agree the page is not accessible at this time. So 
> page_set_xenheap_gfn() should not be used.


yes


>
>
> The other one is in share_xen_page_with_guest() which I think is still 
> fine because the caller page_set_xenheap_gfn() would need to acquire a 
> reference on the page. This is only possible after the count_info is 
> updated in share_xen_page_with_guest() *and* there a barrier between 
> the type_info and count_info.
>
> I think this behavior should be documented on top of type_info (along 
> with the locking). This would be helpful if type_info gain more use in 
> the future.


agree, will do.


>
>
> Cheers,
>
-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Thu Feb 10 17:27:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 10 Feb 2022 17:27:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269941.464091 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIDE2-0005ez-Cr; Thu, 10 Feb 2022 17:27:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269941.464091; Thu, 10 Feb 2022 17:27:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIDE2-0005es-9p; Thu, 10 Feb 2022 17:27:22 +0000
Received: by outflank-mailman (input) for mailman id 269941;
 Thu, 10 Feb 2022 17:27:20 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=kk9V=SZ=gmail.com=this.is.a0lson@srs-se1.protection.inumbo.net>)
 id 1nIDE0-0005em-GW
 for xen-devel@lists.xenproject.org; Thu, 10 Feb 2022 17:27:20 +0000
Received: from mail-qt1-x82c.google.com (mail-qt1-x82c.google.com
 [2607:f8b0:4864:20::82c])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b1e030d6-8a96-11ec-8f75-fffcc8bd4f1a;
 Thu, 10 Feb 2022 18:27:18 +0100 (CET)
Received: by mail-qt1-x82c.google.com with SMTP id k25so6064689qtp.4
 for <xen-devel@lists.xenproject.org>; Thu, 10 Feb 2022 09:27:18 -0800 (PST)
Received: from development (c-73-166-253-254.hsd1.tx.comcast.net.
 [73.166.253.254])
 by smtp.gmail.com with ESMTPSA id de43sm9781703qkb.4.2022.02.10.09.27.16
 for <xen-devel@lists.xenproject.org>
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 10 Feb 2022 09:27:16 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b1e030d6-8a96-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=message-id:subject:from:to:date:user-agent:mime-version
         :content-transfer-encoding;
        bh=Px77cD0FejDu6XuNndK0FPvrCK+eDUGXBcpEO5pgJPI=;
        b=DlrBbAIeZ0CUD+nbjiaqZ6oYHEee3N47hOmnqKvGv1PkCECOfVqo6KoMAhluN24VbK
         Fb5scT5xHBDhffaBfpKF16Pgx/7bJuqPfjfF/ehhPsBxZhepelOpTcOFDqYT3dPycT6q
         exUXOLtiLfg3rA8CmGZIWMZjiXwvmq2YnZs93UmupZfdV3MQBamgzGYdJ7Md3Ihcj7gJ
         Rpm0prpXjiQXas8iRQ5U5LYSzRb68iFR6QtMKfobyLGK5AXHreMLLhBQD9bKbb/D0TMV
         SLqpQPvWGL7B9kjRtCGMqCdO5RPTiwnO1WqA+jXqniYJPo1bB7tW+9NduDPil0YexZBN
         3f8g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:message-id:subject:from:to:date:user-agent
         :mime-version:content-transfer-encoding;
        bh=Px77cD0FejDu6XuNndK0FPvrCK+eDUGXBcpEO5pgJPI=;
        b=mL6GmtK3zcmfhGt/6pmVH6sBGD1/lqIpzuJWHhjIM84u+0lI1qnYCz7QjGdRqP932/
         iUyoNd2uxhqPpz9oAKeLlJPryswafU0DQAKSQTx7PVEonaZfmi99FLWKT5AAO/ljdGKs
         5qbvx/AZC4JJ3OJefV913MgYZXYZcCOFweQ03/QnKdJhl2brr1Rl3TY0rjyUjtNajkzW
         cy2AlqpOaDRLKbi84CcP+XKpgAEz2EX7Q7O8PytcPgwmoG4DWEMcGIeSZ6dB0Kij0vAO
         HwZ6e39BomEWDCl1JEpj1MmAg656kF9PkrpRLwOYCcz1m6HxCKAIz9vqNuOfeR8FqKS9
         Vadw==
X-Gm-Message-State: AOAM531t1eJWElXbeypBhWP+vp5Z244/fREYDWS+5G8ZSbyvdW5BH6yN
	cMzEK3Ol4vYEidgv+X3vh04znUf754gMcQ==
X-Google-Smtp-Source: ABdhPJzcHqnBlz+AlHEqOuJWO+6b4zYfnmMaNfsuC9MoBxFlNJwGBuKKjsksUSa00VKuK6Vq3/1gDg==
X-Received: by 2002:a05:622a:349:: with SMTP id r9mr5683472qtw.37.1644514036893;
        Thu, 10 Feb 2022 09:27:16 -0800 (PST)
Message-ID: <949b4776e23e4607776685a7e2705b9e77f5b717.camel@gmail.com>
Subject: [RFC] Avoid dom0/HVM performance penalty from MSR access tightening
From: Alex Olson <this.is.a0lson@gmail.com>
To: xen-devel@lists.xenproject.org
Date: Thu, 10 Feb 2022 11:27:15 -0600
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.36.5-0ubuntu1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit

I'm seeing strange performance issues under Xen on a Supermicro server with a Xeon D-1541 CPU caused by an MSR-related commit.

Commit 322ec7c89f6640ee2a99d1040b6f786cf04872cf 'x86/pv: disallow access to unknown MSRs'
surprisingly introduces a severe performance penality where dom0 has about 1/8th
the normal CPU performance. Even even when 'xenpm' is used to select the
performance governor and operate the CPU at maximum frequency, actual CPU
performance is still 1/2 of normal (as well as using "cpufreq=xen,performance").

The patch below fixes it but I don't fully understand why.

Basically, when *reads* of MSR_IA32_THERM_CONTROL are blocked, dom0 and
guests (pinned to other CPUs) see the performance issues.

For benchmarking purposes, I built a small C program that runs a "for
loop" 
4Billion iterations and timed its execution. In dom0, the
performance issues
also cause HVM guest startup time to go from 9-10
seconds to almost 80 seconds.

I assumed Xen was managing CPU frequency and thus blocking related MSR
access by dom0 (or any other domain). However,  clearly something else
is happening and I don't understand why.

I initially attempted to copy the same logic as the write MSR case. This
was effective at fixing the dom0 performance issue, but still left other
domains running at 1/2 speed. Hence, the change below has no access control.


If anyone has any insight as to what is really happening, I would be all ears
as I am unsure if the change below is a proper solution.

Thanks

-Alex

---
---
 xen/arch/x86/pv/emul-priv-op.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/xen/arch/x86/pv/emul-priv-op.c b/xen/arch/x86/pv/emul-priv-op.c
index 7f4279a051..f254479bda 100644
--- a/xen/arch/x86/pv/emul-priv-op.c
+++ b/xen/arch/x86/pv/emul-priv-op.c
@@ -970,6 +970,18 @@ static int read_msr(unsigned int reg, uint64_t *val,
         *val = 0;
         return X86EMUL_OKAY;
 
+    /* being unable to read MSR_IA32_THERM_CONTROL seems to significantly affect
+     * dom0 and thus HVM guest startup performance, as well as PVH VMs.
+     */
+    case MSR_IA32_THERM_CONTROL:
+    case MSR_IA32_ENERGY_PERF_BIAS:
+        *val = 0;
+        if ( boot_cpu_data.x86_vendor != X86_VENDOR_INTEL )
+            break;
+        if ( rdmsr_safe(reg, *val) == 0)
+            return X86EMUL_OKAY;
+        break;
+
     case MSR_P6_PERFCTR(0) ... MSR_P6_PERFCTR(7):
     case MSR_P6_EVNTSEL(0) ... MSR_P6_EVNTSEL(3):
     case MSR_CORE_PERF_FIXED_CTR0 ... MSR_CORE_PERF_FIXED_CTR2:
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Thu Feb 10 18:04:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 10 Feb 2022 18:04:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269952.464102 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIDoA-0001UL-Dw; Thu, 10 Feb 2022 18:04:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269952.464102; Thu, 10 Feb 2022 18:04:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIDoA-0001UE-At; Thu, 10 Feb 2022 18:04:42 +0000
Received: by outflank-mailman (input) for mailman id 269952;
 Thu, 10 Feb 2022 18:04:41 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=sWaC=SZ=yahoo.com=akm2tosher@srs-se1.protection.inumbo.net>)
 id 1nIDo9-0001U8-2I
 for xen-devel@lists.xenproject.org; Thu, 10 Feb 2022 18:04:41 +0000
Received: from sonic308-36.consmr.mail.ne1.yahoo.com
 (sonic308-36.consmr.mail.ne1.yahoo.com [66.163.187.59])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e90ec4ea-8a9b-11ec-8eb8-a37418f5ba1a;
 Thu, 10 Feb 2022 19:04:39 +0100 (CET)
Received: from sonic.gate.mail.ne1.yahoo.com by
 sonic308.consmr.mail.ne1.yahoo.com with HTTP; Thu, 10 Feb 2022 18:04:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e90ec4ea-8a9b-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1644516276; bh=iXa1Cd+VaT41h3q4J0/wJjNJWQrzjtgamcihiKFWOEY=; h=Date:From:To:Cc:In-Reply-To:References:Subject:From:Subject:Reply-To; b=Wo8XP2YZ4kpxlQf75qACX/IRdxEsXk2mqwml9cAg9pPRE+DvVRu3nI5MSxlXyml12JkP5zqNwp1MJZHGMA21XyBHaZ0SmdhSg5c4whXAScrMd+IodcGmvFRt9hGvHr7qb5zhOb9DRPgx7MUVkSTm+nUkdiYQnpkRQic5MNq+78/7ZlT/nLRw6Pi34BpFExlNfr2x5a7Czhv6dx44Rj/ZO9ytRuHgD7woi+OGONhLKv9TloDlQKTaSTUvv6PycNEg28cwQhm9pTMAOMUlsDWt1LYod7qRnM+BkUSKMzdIdTkGXR5Ofkco0shSXuWkaWkVeR3khFNIBIw/h1CA7xPpDw==
X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1644516276; bh=lXu/O/9TKTtevBpBNF168Z5erX2WgYok7etbnWuiKd3=; h=X-Sonic-MF:Date:From:To:Subject:From:Subject; b=YOc+TTKvM6c6PpuoBCy/X6y1cSNgJe/kdP+ezgw3l8IE674OzYy93OSodPX0DhX+jv4onqY4aFHqQVtXuQ5l9J8CDTQMJ1oIbsKtGPIYc0myG1JC9OFY6dQylrMtbp+lmwpalkBhUJMr5xKpZgb3OQ19K0+lYlRAioq/llARDaWrWqmu2yceOSu38POM9UnSx1F8JT5SpzX1EOUFhbeU0xI11Lh6mFseSt0Ed+ke1wWfbtTELlNpoO+AlHd6R2JVohAHjt4U4PvM7zbzdgQ8xb0Qkr3r1TepSrCMNrve/c4SLa2hCYGTKbIunuhbFubaKErpOHOmIyciVba9Gv9BNw==
X-YMail-OSG: Syfh58UVM1nods1vOzQMVlgF99MQczZm7A1eCEJgfduY8PmoNYcGDGvomwNDtO1
 o192pnMizfDrwONRrx_xe9VnK.baCbfFQKG189JfYRtt_oVePF_pqTCRuhjZjfrGFal55SycMrXB
 CDWj5an.Ih6xiAa0kjl4XRhI.YG342_df74d1r4NHwfLCbhreXk9kDB8530c88BB4Cq9Mf6iVkA1
 HDGokzkmcUS8HQRAAv2Bh9r0iFVEYetjbocYYLsbRYnsd7Ka85xOUC8VT3UJzUEO7C815ilIoBwu
 35ll487bgazw.5x1mOiHDw444T_kOf2cc7SAOUNpRe7TaFNa1wQQedqWEgQfiNJD4UChjnci.uPb
 TGfvgzntKMoVpYouVs_L8tm3E2zo_n.ZrvoD1OMnQM0dlsfCAZeuzYWyG8QHcBp0sXq5SnabwWIz
 ..CgngLkxaVGtKLFnYQ.IaQazCKFgkPziiUX9AEGkDj0yNEdWnR46L8EJa5gazp9tMuP2ng8uQkE
 x_02pewDx4iL552DutJj3fs5ZBWjQKAD.ksevIOtjfqd.uSYUWvL50Flk5hjDyOEQ2hBmwVOWBD3
 _oG8cbWm.PAsf25hHyelGMAT9FmXC30UFVNY1LtMTl3RT.8OEBEhInb9SxkSdbfn4ILBynk80q9g
 EEB7vwZAryihfUKvmHt0zJmmGk_naKDYXA7YjarywpJ4mGNwVU.lb7Y510g7CEYeZPiC3eXdt8e6
 HgZiXJQ1VkYc.UuDVicfT3X4qINFYylCaTNUHfvalJ5RIiBNgnZCVFZrjQMLMAWDRAQAPsyZhDm7
 7Ygq3_U7weerLP5sCP1RbiwqCJhDHkIDZK.GsQvHfVHg8KYYrOyFAIby97UqXrzfBmEZ6Kqw_Mco
 IQowxa_iPh2cp7SiSiz1l1g49Dpo4U1oyVh.H1PtuG2DeDXDBRKdfBLclHQHWb5u4lk9f.Lm2NPn
 njscmk6_9Zq_rQiDDgUJDAns.28fFAXrag4iA5crohRu44mMN5_0bsSydKB9h4IbfxbHwUJ0OLGE
 LMxt2sdC9jZInfvHFYp5lNVkWvJUzDQzj2Ss2lC2iyQoW4JFR0ICKi23KhA9tQYMLD9jwRz6DX0u
 plFgI.M2lnl7Jy.RUo1d07iKGDIRcC7oBInfDNF6A2jfrhlJy33r8SpQMPAdYofzZ_z9gQBlosPW
 t4M6hV4vK.6N3_0VZA5oxDExURc6jY0WxPx85UvSEx9Ia9UUu1l9jMlazAIuU4k6IqPWN6_ZgE5J
 YiaST1Ox87xX0LgDHitaOVKbkC34P3PonulWPS91RRQ59WSBfrEbFAB54K5hbz04QCFdegA843ea
 8dddYeOskb8mvhcdxr_enKs9rU_aas6ZQwRP18FBsUcAsx4FvnpeFm..VEuQbgokz9lDlVkN3r7J
 Gk_VxQ9dpF7YVKI2mlWtu8n3AW1GYyN3u2nN54TCdCsEBA_lS9Ta02D7je8KN9ZLwPteNjLn9ysU
 nbgGs1o5iWXhzDeADJNmcLlnUuKsXgCc3pnVKS7euNxIjtC8Fex6zhmtgI0V69kIkQpm7b6y9m9W
 7OZndKfCWBLJqRjxyHFcErsC2fPrm87StbFVsyzil6OIEBjGBp8IgtCr6.EKoARj16eWOFf3hKbb
 l0SNJazE4ppnajIPfk.9dG80Es9O20ZaiAxWv313xGRVRhe_1i43Y5P5DAEjsiX53eF12atlY.VU
 a_LykEUT7f4_eazK4B.ETn_t0TUa4MAX1rkteG.jywVECbi7ZNR8KdSd1SF2imfkuYDpBoZwV_qf
 2oSn4KPhSlVv3iX_7ULzL1buwENmSHiZ_UpYjfm6nTNt9qb4A3OIjhV1l.GJ6lZUsirYbYOhnilB
 COTf.vnRoPsktUSCIbjRfuehVVXbnRNgWwv2C4drrj1LW88dUyyCGlFO6e1sSUTd2LYcJs3iEk.2
 h3v1GT9gg6ELoJMD_58WcT6E9wraYKrOYD77HCOJbpRSVTYYJLmaRBJ4GZZ6PHLhbx1Z9oJyyjyl
 yRnCTIvKIGf3Ph8Z59L4_hDqgWCBQhn2REH5QRLUmjEYCfXvyvFXFywVkIOPIr1jltmzNqkd30ep
 j5y5apW8m27M9DOT4d7PjaWnqs8TXZ7aiouvBm2JQ_ZYymA7AN7VhxF1FGBUzJx2efxnaU4nRR0E
 _uZmQEnh5ey2xHNefl3.njov6.KaX9Z8ar1aFlug7XgjRRtAJ3WoUgYY2i2ur4vD9DInNYFEXuC6
 It6HRhVB_eUZ.lmDWoJpNxPZNfLQbdo0oJFMTfTyBPA--
X-Sonic-MF: <akm2tosher@yahoo.com>
Date: Thu, 10 Feb 2022 18:02:31 +0000 (UTC)
From: tosher 1 <akm2tosher@yahoo.com>
To: Bertrand Marquis <Bertrand.Marquis@arm.com>, 
	Jan Beulich <jbeulich@suse.com>
Cc: "roger.pau@citrix.com" <roger.pau@citrix.com>, 
	"xadimgnik@gmail.com" <xadimgnik@gmail.com>, 
	"oleksandr_andrushchenko@epam.com" <oleksandr_andrushchenko@epam.com>, 
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Message-ID: <1240968518.881344.1644516151890@mail.yahoo.com>
In-Reply-To: <2CDAD7A1-A628-4491-9DE0-1F4D5D9FF1A7@arm.com>
References: <709142925.628001.1644127197288.ref@mail.yahoo.com> <709142925.628001.1644127197288@mail.yahoo.com> <0e64c52c-1e9c-e89b-abb8-50171d885926@suse.com> <303292590.682317.1644477758255@mail.yahoo.com> <2CDAD7A1-A628-4491-9DE0-1F4D5D9FF1A7@arm.com>
Subject: Re: PCI passthrough support for PVH mode
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-Mailer: WebService/1.1.19724 YMailNorrin
Content-Length: 1938

Hi Bertrand and Jan,

I thought PCI passthrough was a WIP only for PVH mode on Arm and x86. Howev=
er, it seems there are some differences. Thanks for the clarifications.

Regards,
Mehrab






On Thursday, February 10, 2022, 03:32:19 AM EST, Bertrand Marquis <bertrand=
.marquis@arm.com> wrote:=20





Hi Mihrab,

> On 10 Feb 2022, at 07:22, tosher 1 <akm2tosher@yahoo.com> wrote:
>=20
> Hi Jan,
>=20
> Thanks for letting me know this status.
>=20
> I am wondering if PCI passthrough is at least available in Arm for other =
virtualization modes like PV, HVM, or PVHVM. For example, is it possible fo=
r someone to attach a PCI device to a guest domain on an Arm machine and us=
e that domain as a driver domain, like we can do with the Xen on x86?

On arm there is only one virtualization mode which is equivalent to x86 HVM=
.

Regarding PCI passthrough on arm, this is currently a work in progress that=
 is being upstream so it is not available for now.
Once it will be merged in Xen, it will be possible to assign a PCI device t=
o a guest so you could then make a =E2=80=9Cdriver domain=E2=80=9D using th=
e functionality.

Regards
Bertrand


>=20
> Please let me know.
>=20
> Regards,
> Mehrab
>=20
>=20
>=20
>=20
> On Monday, February 7, 2022, 02:57:45 AM EST, Jan Beulich <jbeulich@suse.=
com> wrote:=20
>=20
>=20
>=20
>=20
>=20
> On 06.02.2022 06:59, tosher 1 wrote:
>=20
>> Back in the year 2020, I was inquiring into the status of PCI passthroug=
h support for PVH guests. At that time, Arm people were working on using vP=
CI for guest VMs. The expectation was to port that implementation to x86 on=
ce ready.
>>=20
>> I was wondering if there is any update on this. Does Xen support PCI pas=
sthrough for PVH mode yet? Please let me know.
>=20
>=20
> The Arm work is still WIP, and in how far it's going to be straightforwar=
d to
> re-use that code for x86 is still unclear (afaict at least).
>=20
> Jan
>=20
>=20
>=20



From xen-devel-bounces@lists.xenproject.org Thu Feb 10 18:27:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 10 Feb 2022 18:27:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269960.464114 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIEAN-0003uZ-AW; Thu, 10 Feb 2022 18:27:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269960.464114; Thu, 10 Feb 2022 18:27:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIEAN-0003uS-7S; Thu, 10 Feb 2022 18:27:39 +0000
Received: by outflank-mailman (input) for mailman id 269960;
 Thu, 10 Feb 2022 18:27:37 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=OlIW=SZ=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nIEAL-0003uK-G3
 for xen-devel@lists.xenproject.org; Thu, 10 Feb 2022 18:27:37 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1c803517-8a9f-11ec-8eb8-a37418f5ba1a;
 Thu, 10 Feb 2022 19:27:34 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1c803517-8a9f-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644517654;
  h=from:to:subject:date:message-id:references:in-reply-to:
   content-id:content-transfer-encoding:mime-version;
  bh=WLQ6zFOpuCFiRHzGec/l2mWyFi+kYiC1GN7h3D2ppJo=;
  b=fWfbjfV2CjjuLdSr+CdigVNg0j8ldjSGcbVTfhhSoT/pBN3NL3WSnog9
   ALJJE0qpO7xIKHoB5g6jy8olKTSFIjMypexuv3rzNLca7Wa+XrD5HnCGp
   RcD7ceiD2GTtjLBuWE+KV2mTkbz8j4jzE53FCxNnyAgp3mTRqn3QOoJ2i
   E=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: lavaRb6hJsXdrEZ6spBfVVbtqOP+KVGIB06E4ecrA+klwzHaCjHavCgU5rr1vavIFsErIE6lLe
 w82Jk9nLSIni2a24xfTR1qdviyvFipzU6rDWF/ny+UJMouceS53fKH2wq9/McY1MJ0pge+eLTj
 DW9oPLHIbxzcA1duTpJzCOo0sdYI+BbsEJGRHgWhQrxtO6T6x4YLoml/+rzMtp89Puup2qQNbC
 qXSWyswSE4KhC1iE2UoAFg3Lz9LtAp6/8WsFQCzC9qVQfYAd5MElmWw38dZvYkOVeJINpfE27E
 20/bVn3QfR3hgI5i9crOgXdZ
X-SBRS: 5.1
X-MesageID: 63403588
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:bmRQUaI+yKvLUCV9FE+RA5IlxSXFcZb7ZxGr2PjKsXjdYENS0DADy
 zcYDWmPPqmLYWP1LdBwaY3g8E9VuMSHx99mGwtlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokcxIn5BC5C5xZVG/fjgqoHUVaiUakideSc+EH170Ug6w7Zj6mJVqYPR7z2l6
 IuaT/L3YDdJ6xYsWo7Dw/vewP/HlK2aVAIw5jTSV9gS1LPtvyB94KYkDbOwNxPFrrx8RYZWc
 QphIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbrGvaUXe345iXMfwZ3u7hB27mfpdi
 /sRnqCgVBZ3JvXdm7w5cwRHRnQW0a1uoNcrIFC6uM2XiUbHb2Ht07NlC0Re0Y8wo7gtRzsUr
 LpBdW5LPkvra+GemdpXTsFFgMg5IdatF4QYonx6lhnSDOo8QICFSKLPjTNd9Glr2pgVQKaOD
 yYfQQZlPSmdbjdVAFIKWYkVgLirmHD5UgQN/Tp5ooJoujOOnWSdyoPFINfTP9CHW8hRtkKZv
 X7duXT0BAkAM96SwibD9Wij7sfTnSLgHoMJUrTg8uVthnWcw2USDFsdUl7TnBWiohfgAZQFc
 RVSo3dw6/hpnKC2cjXjdy++ilLHkEI3Z8pNArMisBCOko70/hnMUwDoUQV9QNAhscY3Qxkj2
 VmIg87lCFRTjVGFdZ6O3uzK9G3vYED5OUdHPHZZFlVdv7EPtalu1kqnczp1LEKiYjQZ8xnUy
 ivCkiUxjq57YSUjh/TipgCvb95BS/H0ou8JCuf/AzrNAuBRPtfNi2mUBb7ztq8owGGxFAfpg
 ZT8s5LChN3i9LnU/MB3fM0DHauy+9GOOyDGjFhkEvEJrmrxpyL4J9gIu2EhdS+F1/ronxeyO
 Sc/XisLuvdu0IaCN/crM+pd9ex2pUQfKTgVfq+NNYcfCnSAXASG4DtvdSatM5PFyyARfVUEE
 c7DK66EVC9CYYw+lWbeb7pNgNcDm3FlrUuOFM+T8vhS+efHDJJjYexeawXmgyFQxP7snTg5B
 P4Ba5XUm08CDIUToED/qOYuELzDFlBibbjeoM1LbO+TZA1gHWAqEfjKxr09PYdimsxoei3go
 xlRg2dUlwjyg2PpMwKPZiwxYb/jR88n/3k6ITYtLRCj3H16OdSj66IWdp0We7g79bM8ka4oH
 qddI8jQUO5STjnn+igGacWvpoJVaxn21xmFODCoYWZjcsc4FRDJ4NLtYiDm6DIKUnisrcI7r
 rD5jlHbTJMPSh5MFsHTbP7znVq9sWJEwLB5XlfSI8kVc0LpqdA4Jyv0h/4xAscNNRScmWfKi
 1fIWU8V/LCfrZU0/d/FgbG/g72oS+YuTFBHG2T77KqtMXWI9GSU3oIdAv2DeirQVT2o9fz6N
 /lV1fz1LNYOgE1O79hnC79uwK8zu4nvqrtdwlg2FXnHdQ32WLZpI33A1shTrKxdgLRevFLuC
 E6I/9BbP5SPOd/kTwFNdFZ0MLzb2KFGgCTW4NQ0PF7+tX1+87ewWElPOwWB1X5GJ7xvPYJ5m
 eostab6MeBkZsbG5jpesh1pyg==
IronPort-HdrOrdr: A9a23:Y/YM66qljkS8GOVQ51tdW9IaV5uEL9V00zEX/kB9WHVpm5Oj+f
 xGzc516farslossSkb6K290DHpewKTyXcH2/hsAV7EZnimhILIFvAs0WKG+Vzd8kLFh5dgPM
 tbAspD4ZjLfCJHZKXBkUmF+rQbsaG6GcmT7I+0pRoMPGJXguNbnnxE426gYxdLrWJ9dP4E/e
 +nl6x6Tk2bCBMqh6qAdxw4dtmGg+eOuIPtYBYACRJiwhKJlymU5LnzFAXd9gsCUhtUqI1Ssl
 Ttokjc3OGOovu7whjT2yv49JJNgubszdNFGYilltUVEDPxkQylDb4RGYFq/QpF5d1H2mxa1+
 UkkC1QefibLEmhJ11dlCGdnzUIFgxes0MKh2Xo2kcL6vaJOw7SQ/Ax+76xNCGptnbI9esMoJ
 6ilQiixutqJAKFkyLn69fSURZ20kKyvHo5iOYWy2dSSI0EddZq3MYiFW5uYd899RjBmcsa+S
 hVfbXhzecTdUnfY2HSv2FpztDpVnMvHg2eSkxHvsCOyTBZkH1w0kNdnaUk7zs93YN4T4MB6/
 XPM6xumr0LRsgKbbhlDONERcesEGTCTR/FLWrXK1X6E6MMPW7LtvfMkfgIzfDvfIZNwIo5mZ
 zHXl8dvWkue1j2AcnLx5FP+gClehT1Yd0s8LAp23FUgMyPeFPbC1z1dLl1qbrSnxw2OLyvZ8
 qO
X-IronPort-AV: E=Sophos;i="5.88,359,1635220800"; 
   d="scan'208";a="63403588"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=R9CA2YjMNGKSCWZGmAJK8DK7mdxzgA4/SvDj24/sUykWNcB0KP61IcA0dBG+uWvqG976ZquaB1FWjcwchQ+k1fKHHdJuUu1bE3J0oPoouyUc1xZgRvLRFOUFTGB1+SrMKFXlMM+/v4iCUjjmPlQJtkrW3UTvp5GVu75PmaCO8PhG1z0SFWNDTVA4sGdWCRnj28zXJLLonJeiHsWSNOUSBmgECwCc/DOq1GbcCs+zXdzA7vGhiz0HH2cJbBsk5ag65benq2yvSWR0Nuhem9EmjyvUisi19pf8QhopGO3ADa6AbB5IB+/UezSUps6hPDxYJ6l2MJ3oVbzphVxJOyHWXA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=WLQ6zFOpuCFiRHzGec/l2mWyFi+kYiC1GN7h3D2ppJo=;
 b=n4OtHhWxYX8QE/jNqooTpiAAGrustjxDxxObYGXeBrgT5MEyQedl5Vsw36bpBHcVMqBCZsX0hruiUsjWZTBUNKD7xdJj+KvxkQaouEkZqkmGbSubpdYYCLmQwZzqm3K8ufmk5VJWLhHjbtgjftZwGdAMmExx4pHu/PPRld6d7OjKpEYHw5rJizTdNrc30xFVXBQ3eScJbQIAgENdCAcyqCZ6cXv7q3NzGvCLPs5IagZ3DpRvZOjfp+jQL/ESKyzk+9kuLbJ/RU1P/tKOG6fNrD0CEDzQvAq5i7S98n3cko5RM1ewZoNZurSHk/8a37lk/wJ7vXC4k6kqRSSqHtrsLg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=WLQ6zFOpuCFiRHzGec/l2mWyFi+kYiC1GN7h3D2ppJo=;
 b=ALepYvjxDRNCFEGssr/P80YUztFYNHbnnMCCk32ZwXZesJTB3SfVEwB+FlXTMbLNCumi/ZMJKPnW4BrahAnfYx1PTEMfVnJbvRgksrnnRBDikF9eDk68NDf8pxdOWOL9P4nEpaYqR9ZIMjdpjtHrovv/H4S9gv5+poNKCoXSFLE=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Alex Olson <this.is.a0lson@gmail.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: Re: [RFC] Avoid dom0/HVM performance penalty from MSR access
 tightening
Thread-Topic: [RFC] Avoid dom0/HVM performance penalty from MSR access
 tightening
Thread-Index: AQHYHqOPCVLXb6vjgEiHGtmfOQDTpayNGm6A
Date: Thu, 10 Feb 2022 18:27:27 +0000
Message-ID: <a1099ae9-9e0d-cf54-e786-835c13f2ba40@citrix.com>
References: <949b4776e23e4607776685a7e2705b9e77f5b717.camel@gmail.com>
In-Reply-To: <949b4776e23e4607776685a7e2705b9e77f5b717.camel@gmail.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 976c182b-0e72-4b9b-ea59-08d9ecc2fe10
x-ms-traffictypediagnostic: SA1PR03MB6530:EE_
x-microsoft-antispam-prvs: <SA1PR03MB65306ADB82F36C7C5B740A0DBA2F9@SA1PR03MB6530.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:6430;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 4oLVdvWZbvgm5F+++pmuPj92gLyMa5UnK3xK/OFNROz2dp+lVQoHdBOf8tuQwWZmNAb1c+RKlzZER8d3fotq4LqMVK1HJNylmRpx9gxHd1dLxMQO8gUV7ywhBOYM7kwNjmqIZxiIGYw8/uhPrVbOFC1UmPOEFlHVtXyrVlxWzOcaGOxUJmXe5j2ssRPxUlG1T8MU1a36m+Gvb9UBsNmCPRRuLCTKGvEvw3pNR1jzYl1BzZWxR8ctYiuSssJHyEEXDxGerat+9nFNnR+x/Z59a0QwIlYI7g1zgv5RRoDlGJO/z/BG07Ajgv+BGRnmOIskyjoJDMCDlvTiNHTEfXCP/mzzrC+/vYmBnZcN+dajI/3Zj0OsU1QdowSV6Zsuo1sMHwJiW6Q+pTpeqvx/ZKccz6BS1sYNWbyIhu/HRu3dp8P7wuIXDTRL2n1Oi/PF3X6GU8TmBBRbDTr/93Q6fgEp8ixBZQAnG+wU75ddx3q8OGh1eCmLjhnSaQMwkpAeGwwZCk0Pcn4S2CEt+F96hlexR2pgVdX2SWWkPcEHCzaqzisGpfynwIFaTQVXRY9edAciv9iJr04yF8ru8zcniZu6r/KYHEQG5cZDfXOJMbRR4vEnM9gy9U8RfnBegQIzaWwX1Qpen3R6hisBN6acTc0XymlTLGQeCeteaTKDwV1UNh5566JzAAMjtdigsKxYVWFgwONdqeTULZetOSI9vm3sBk/Bpa6Qbx4mWpfEeTejlPotDy72+boM3wnYKtSvYqSPFDBSBMXR0aQqZivRoxtkNQ==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(53546011)(2616005)(91956017)(6486002)(110136005)(86362001)(316002)(31686004)(36756003)(31696002)(508600001)(38100700002)(64756008)(122000001)(6512007)(66446008)(38070700005)(2906002)(76116006)(66946007)(6506007)(66476007)(66556008)(71200400001)(8936002)(83380400001)(8676002)(82960400001)(5660300002)(186003)(26005)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?eGkwdW1PTng1aTNTc0FUc0ZDdWtnMFJsRTdhejZuZytPelE1bTNyelllZm5O?=
 =?utf-8?B?OThBcGVBZU9WNGNNZS9lTUY5eHpPY1J3dFg1L2NUKytjd1BRV25Jak9wUGlq?=
 =?utf-8?B?b041R2psZ0dnS2tmK1N5dlAxRWFpTWdiTllnNEFCYlBCSXoveXZrL2YzanBz?=
 =?utf-8?B?MXlXbXhxbWg3UER4Y3V3aWtwdFgvNnRmRm9qMis1WTV2dmUvTFJDZExzUHZl?=
 =?utf-8?B?bS9PWFB2Nlppd2RkYm00a3BqQUZoMlFHSlpqSHBuZmludTVqMktLVkhMRHc5?=
 =?utf-8?B?N3N0dGtOU2NLNENVMjZrOVRoa3RZKzRvdnhrTnJmdC9zOHlQcExaVmtSMnA2?=
 =?utf-8?B?dHRBOW15ZndFb1R6Ri9mTGtTT2NXMGFMOTJnaEVpM1ozNEZzWklxMlJIQTdi?=
 =?utf-8?B?bjNPQ05FdTFUVnJGa1JSemZZU210VjR6MTJ0TDZpVTlrNHpzdVZ2dzA1dEFa?=
 =?utf-8?B?Y0xYRXM1K2ZvSnlCVnA1cjZYd2ZFMURnVVlmYXB5VVRBSGlRUTFob3h5RXlD?=
 =?utf-8?B?QkJLMVg0R0pMYzBtREtZMHpCSU45M243R3llVHFNZWVyU09tbjlVemdJdXJ0?=
 =?utf-8?B?RlY0N2gySVJJOHhJUWtyWmtydm8yNHFKcHdkb093Mmx4eWdOZEljaXJ1RXZK?=
 =?utf-8?B?S1M5Q1hUZG8yWms1VjJQbzZBWVIwVi8zUjVHTEt5UExsYjczOVY2WXErWHd1?=
 =?utf-8?B?K0FGYjNPV1FFSlprQ01HV0pGVU81L2dKNnFha2d3amJ5b0FKd09CT3Ryblhj?=
 =?utf-8?B?MjludDdGbStKTW52REdKZWhLMWowZFpYTHRrV3BMS1VJRmxBbS9vVUs4STA1?=
 =?utf-8?B?SDNhNEg0L0RNVlhRblduem44K0ZvOXZ5SUpSZjlNRGlBdDFjdVRrTStTd2hS?=
 =?utf-8?B?NHJHYlVIWWFzMmRXdDU4WnMwN3N1SFA1bTY4QTFmejZPQWhmZ2FxSU5hR2hu?=
 =?utf-8?B?WCs4bVAwSlZKZmFxKy90Q0U1ODFDYWNpQkFJa2pZUXBTeWVYZmxrRmZQc2Q3?=
 =?utf-8?B?c3MvVXFremRyYURSS3FCM21KSkRoVmhsVDlBUjFTK0tKZUZlWmhLUkpFbHJ2?=
 =?utf-8?B?byszN2lCek44c3ZKWUc1NGM2anZJQnZveCs3UzlkSUd0bWpEUXZDcUFBUFJH?=
 =?utf-8?B?RkZCMUNWaWxWN2FHdldVZ3lCbG8yTTRZclN6V3JCaDFhZmJrMVB4anRHUnFR?=
 =?utf-8?B?WlZCL09aNEJUOTRQVFkwVzVJNVZvTGVqNUtWY0QwVmhWbWZpYjFRYlJMU1h2?=
 =?utf-8?B?Rmd2MEdzZVJGS0syM0FSN2ZLT0JTSUVjM2k5d05lUThmN1QvWldFdDlzTktV?=
 =?utf-8?B?cHo3WWVjQUtHUTNrajVmWGdNNGhiWUJuVXNvRGEyejBNeEhIa0NJeEI1bGI1?=
 =?utf-8?B?c001UWhmOFhTcGlMaysyTy9pVjN3NytFdjBJZTJEVFdCZ003OE9ST2gxcGI4?=
 =?utf-8?B?WS8wTEZTTnJEL2RnR1d6ZW5GcXJxSXpjcGJNQnRTSjYyRitySjlTd3EwSnFr?=
 =?utf-8?B?a3B0VitTOTZkQkw4WjhDeS9EbnZSTXhLbjFCRDRzUmNpbDNhSXZ5d0s5cEgv?=
 =?utf-8?B?czgxTTh0RURvYTBSTXQ1eEpKL1RHTVpDZTB5TXpRUTF1NEwwTWhOc29PYVVa?=
 =?utf-8?B?THNGWDNIK3J6ZU4wSnd0c3FjMlE4a2xtdzZNTXVnSFFWd1R2MnY0K1JDd1lT?=
 =?utf-8?B?b01XckJwRk42OGxxY3d1SDVQZm5UdkpNSGs5RUk5RG1MYVpBdThRK2VsclV1?=
 =?utf-8?B?K1RPajA3aENPNzVmSW9DVUIvUjNMWEFhaUFiYS90cFFYdis2ZUVJQXYrWVFz?=
 =?utf-8?B?cFdOUk1KY3ViaFd5eUtacGc1Y1V0eUNkVHo4TjFXeUltZjdEeExBREtqTmp4?=
 =?utf-8?B?ek9JTEJQYWQ1Z0pyREFjUyt0Y3hwaGFSVTVJaXZpWHlPUkZuQVc0TGorUUxO?=
 =?utf-8?B?bElRVnoyOHVHQWY3SDhCemZzQ3UwbmYweHZqZDcxVjhLNHlTd1dleStkT2xP?=
 =?utf-8?B?VXAvUG0zYUZ1V0h5MExqZWhFa2NwcXZnU0RWeG56OVIvQUFjZFdtc2hVaWla?=
 =?utf-8?B?YWVPOUEvNGpjTE4yRWo5WTF5aHBkZlBSUkpFUG5xUE14QjJ6Y0xMUXNLVWtt?=
 =?utf-8?B?K1lESGNYRnhkMVh2bHZFWTc3RGZ6bVRQMFlLN2pSMzVUSkY0Zk1tOFlCL1hM?=
 =?utf-8?B?NFRkZmkxYk1kdHBxcCt0ekVGR1JpYUhJd2RBU1JNWnFIUUQwN1lkM1JYV2hQ?=
 =?utf-8?B?T0dqb3pWaUVwaW9HL0M1L0t1bEFBPT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <C06ACA860687274E9AD20EC58815E10F@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 976c182b-0e72-4b9b-ea59-08d9ecc2fe10
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Feb 2022 18:27:27.8874
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: KlCH25kwvJJvT5RC5w4OvBwW1FZe8qZrLzT0Nw6rSxoOfITolczYv3+VFWIUVTDxCs167vcI/i/Ovsqb24jNwLWVECvVZOpOHPoUkocvNn4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR03MB6530
X-OriginatorOrg: citrix.com

T24gMTAvMDIvMjAyMiAxNzoyNywgQWxleCBPbHNvbiB3cm90ZToNCj4gSSdtIHNlZWluZyBzdHJh
bmdlIHBlcmZvcm1hbmNlIGlzc3VlcyB1bmRlciBYZW4gb24gYSBTdXBlcm1pY3JvIHNlcnZlciB3
aXRoIGEgWGVvbiBELTE1NDEgQ1BVIGNhdXNlZCBieSBhbiBNU1ItcmVsYXRlZCBjb21taXQuDQo+
DQo+IENvbW1pdCAzMjJlYzdjODlmNjY0MGVlMmE5OWQxMDQwYjZmNzg2Y2YwNDg3MmNmICd4ODYv
cHY6IGRpc2FsbG93IGFjY2VzcyB0byB1bmtub3duIE1TUnMnDQo+IHN1cnByaXNpbmdseSBpbnRy
b2R1Y2VzIGEgc2V2ZXJlIHBlcmZvcm1hbmNlIHBlbmFsaXR5IHdoZXJlIGRvbTAgaGFzIGFib3V0
IDEvOHRoDQo+IHRoZSBub3JtYWwgQ1BVIHBlcmZvcm1hbmNlLiBFdmVuIGV2ZW4gd2hlbiAneGVu
cG0nIGlzIHVzZWQgdG8gc2VsZWN0IHRoZQ0KPiBwZXJmb3JtYW5jZSBnb3Zlcm5vciBhbmQgb3Bl
cmF0ZSB0aGUgQ1BVIGF0IG1heGltdW0gZnJlcXVlbmN5LCBhY3R1YWwgQ1BVDQo+IHBlcmZvcm1h
bmNlIGlzIHN0aWxsIDEvMiBvZiBub3JtYWwgKGFzIHdlbGwgYXMgdXNpbmcgImNwdWZyZXE9eGVu
LHBlcmZvcm1hbmNlIikuDQo+DQo+IFRoZSBwYXRjaCBiZWxvdyBmaXhlcyBpdCBidXQgSSBkb24n
dCBmdWxseSB1bmRlcnN0YW5kIHdoeS4NCj4NCj4gQmFzaWNhbGx5LCB3aGVuICpyZWFkcyogb2Yg
TVNSX0lBMzJfVEhFUk1fQ09OVFJPTCBhcmUgYmxvY2tlZCwgZG9tMCBhbmQNCj4gZ3Vlc3RzIChw
aW5uZWQgdG8gb3RoZXIgQ1BVcykgc2VlIHRoZSBwZXJmb3JtYW5jZSBpc3N1ZXMuDQo+DQo+IEZv
ciBiZW5jaG1hcmtpbmcgcHVycG9zZXMsIEkgYnVpbHQgYSBzbWFsbCBDIHByb2dyYW0gdGhhdCBy
dW5zIGEgImZvcg0KPiBsb29wIiANCj4gNEJpbGxpb24gaXRlcmF0aW9ucyBhbmQgdGltZWQgaXRz
IGV4ZWN1dGlvbi4gSW4gZG9tMCwgdGhlDQo+IHBlcmZvcm1hbmNlIGlzc3Vlcw0KPiBhbHNvIGNh
dXNlIEhWTSBndWVzdCBzdGFydHVwIHRpbWUgdG8gZ28gZnJvbSA5LTEwDQo+IHNlY29uZHMgdG8g
YWxtb3N0IDgwIHNlY29uZHMuDQo+DQo+IEkgYXNzdW1lZCBYZW4gd2FzIG1hbmFnaW5nIENQVSBm
cmVxdWVuY3kgYW5kIHRodXMgYmxvY2tpbmcgcmVsYXRlZCBNU1INCj4gYWNjZXNzIGJ5IGRvbTAg
KG9yIGFueSBvdGhlciBkb21haW4pLiBIb3dldmVyLCAgY2xlYXJseSBzb21ldGhpbmcgZWxzZQ0K
PiBpcyBoYXBwZW5pbmcgYW5kIEkgZG9uJ3QgdW5kZXJzdGFuZCB3aHkuDQo+DQo+IEkgaW5pdGlh
bGx5IGF0dGVtcHRlZCB0byBjb3B5IHRoZSBzYW1lIGxvZ2ljIGFzIHRoZSB3cml0ZSBNU1IgY2Fz
ZS4gVGhpcw0KPiB3YXMgZWZmZWN0aXZlIGF0IGZpeGluZyB0aGUgZG9tMCBwZXJmb3JtYW5jZSBp
c3N1ZSwgYnV0IHN0aWxsIGxlZnQgb3RoZXINCj4gZG9tYWlucyBydW5uaW5nIGF0IDEvMiBzcGVl
ZC4gSGVuY2UsIHRoZSBjaGFuZ2UgYmVsb3cgaGFzIG5vIGFjY2VzcyBjb250cm9sLg0KPg0KPg0K
PiBJZiBhbnlvbmUgaGFzIGFueSBpbnNpZ2h0IGFzIHRvIHdoYXQgaXMgcmVhbGx5IGhhcHBlbmlu
ZywgSSB3b3VsZCBiZSBhbGwgZWFycw0KPiBhcyBJIGFtIHVuc3VyZSBpZiB0aGUgY2hhbmdlIGJl
bG93IGlzIGEgcHJvcGVyIHNvbHV0aW9uLg0KDQpXZWxsIHRoYXQncyBlc3BlY2lhbGx5IGVudGVy
dGFpbmluZy4uLg0KDQpTbyB5b3VyIHBhdGNoIGVkaXRzIHB2L2VtdWwtcHJpdi1vcC5jI3JlYWRf
bXNyKCksIHNvIGlzIG9ubHkgY2hhbmdpbmcNCnRoZSBiZWhhdmlvdXIgZm9yIFBWIGRvbTAuDQoN
CldoYXQgZXhhY3RseSBpcyB5b3VyIHNtYWxsIEMgcHJvZ3JhbSBkb2luZz8NCg0KDQpUaGUgY2hh
bmdlIHRoYXQgdGhhdCBwYXRjaCBtYWRlIHdhcyB0byB0dXJuIGEgcmVhZCB3aGljaCBwcmV2aW91
c2x5DQpzdWNjZWVkZWQgaW50byBhICNHUCBmYXVsdC4NCg0KVGhlIHJlYWQgaGFzIGFscmVhZHkg
YmVlbiBib2d1cywgZXZlbiBpZiB0aGV5IGFwcGVhcmVkIHRvIHdvcmsgYmVmb3JlLsKgDQpXaGVu
IGRvbTAgaXMgc2NoZWR1bGVkIGFyb3VuZCwgaXQgbm8gbG9uZ2VyIGtub3dzIHdoaWNoIE1TUiBp
dCBpcw0KYWN0dWFsbHkgcmVhZGluZywgc28gYXQgdGhlIGJlc3QsIHRoZSBkYXRhIGJlaW5nIHJl
YWQgaXMgcmFjeSBhcyB0bw0Kd2hpY2ggQ1BVIHlvdSdyZSBpbnN0YW50YW5lb3VzbHkgc2NoZWR1
bGVkIG9uLg0KDQoNCkF0IGEgZ3Vlc3MsIHNvbWV0aGluZyBpbiBMaW51eCBpcyBkb2luZyBzb21l
dGhpbmcgZXNwZWNpYWxseSBkdW1iIHdoZW4NCmdpdmVuICNHUCBhbmQgaXMgZmFsbGluZyBpbnRv
IGEgdGlnaHQgbG9vcCBvZiB0cnlpbmcgdG8gcmVhZCB0aGUgTVNSLsKgDQpEbyB5b3UgaGFwcGVu
IHRvIGtub3cgd2hpY2ggb2YgdGhvc2UgdHdvIGlzIHRoZSBtb3JlIGRvbWluYXRpbmcgZmFjdG9y
Pw0KDQp+QW5kcmV3DQo=


From xen-devel-bounces@lists.xenproject.org Thu Feb 10 19:09:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 10 Feb 2022 19:09:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269967.464124 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIEoH-000863-IT; Thu, 10 Feb 2022 19:08:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269967.464124; Thu, 10 Feb 2022 19:08:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIEoH-00085w-FN; Thu, 10 Feb 2022 19:08:53 +0000
Received: by outflank-mailman (input) for mailman id 269967;
 Thu, 10 Feb 2022 19:08:52 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=DWbD=SZ=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nIEoG-00085o-2m
 for xen-devel@lists.xenproject.org; Thu, 10 Feb 2022 19:08:52 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e0f8ea96-8aa4-11ec-8eb8-a37418f5ba1a;
 Thu, 10 Feb 2022 20:08:50 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 1394F611AA;
 Thu, 10 Feb 2022 19:08:49 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3A048C004E1;
 Thu, 10 Feb 2022 19:08:48 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e0f8ea96-8aa4-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1644520128;
	bh=vvyQcAA0GQuumxKGjBeJxeBCn9zZvuPWsPTX2tTmyEs=;
	h=Date:From:To:cc:Subject:From;
	b=mPJ3ZG0QX/i0AulhBWdwKYDn4dFg8lO7KXxscxybsAG3QvYLDbxjVXWaaW5TsaZ17
	 lFeWhHWfsuASYFToqnYu1AL1YlfmxJ/k7uqhSWYNsrvtO81fDrS2EoGS840dbO+Udr
	 +1TbzvIGUsl9a1z9IRg8sVX3iKgcM/M819qQ6w6XAkyxRqySgBnGv0RE6w4Gk+gh8S
	 ydXg8/mllSaOq6WrJG+8VKQ57QxraiWqbGXhWR78jZmo4+v1IXeWcw5mAXsFI8PocG
	 Eo5leSmY+VLIEAMMpvuqNUqPbVZrJPmJePWCEuSAewNcVKBPeAELmIN15GKl4IX/1u
	 tKEKOk6tLkzzg==
Date: Thu, 10 Feb 2022 11:08:47 -0800 (PST)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: bertrand.marquis@arm.com
cc: sstabellini@kernel.org, xen-devel@lists.xenproject.org, julien@xen.org, 
    Volodymyr_Babchuk@epam.com
Subject: [PATCH] MAINTAINERS: make Bertrand ARM maintainer
Message-ID: <alpine.DEB.2.22.394.2202101026360.2091381@ubuntu-linux-20-04-desktop>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>

diff --git a/MAINTAINERS b/MAINTAINERS
index 64934cc070..d41572128b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -230,8 +230,8 @@ F:	tools/libs/ctrl/xc_arinc653.c
 ARM (W/ VIRTUALISATION EXTENSIONS) ARCHITECTURE
 M:	Stefano Stabellini <sstabellini@kernel.org>
 M:	Julien Grall <julien@xen.org>
+M:	Bertrand Marquis <bertrand.marquis@arm.com>
 R:	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
-R:	Bertrand Marquis <bertrand.marquis@arm.com>
 S:	Supported
 L:	xen-devel@lists.xenproject.org
 F:	docs/misc/arm/


From xen-devel-bounces@lists.xenproject.org Thu Feb 10 20:54:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 10 Feb 2022 20:54:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269974.464136 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIGSL-0001aG-9A; Thu, 10 Feb 2022 20:54:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269974.464136; Thu, 10 Feb 2022 20:54:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIGSL-0001a9-5p; Thu, 10 Feb 2022 20:54:21 +0000
Received: by outflank-mailman (input) for mailman id 269974;
 Thu, 10 Feb 2022 20:54:20 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nIGSK-0001Zz-AV; Thu, 10 Feb 2022 20:54:20 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nIGSK-0003R2-31; Thu, 10 Feb 2022 20:54:20 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nIGSJ-0004TV-Gi; Thu, 10 Feb 2022 20:54:19 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nIGSJ-0003wo-GE; Thu, 10 Feb 2022 20:54:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=kT14/ZoH/j3ARsPqssLxiAVUVSRqgu1B44XPcesnTog=; b=y5kA0bEag+8ansnF/sFWw3izPA
	cJbGeStz2N/trC6EVl3qkuNoo1tgdPnO4Ptt2ZCLmYfLxOeJ889jrIqkXvQg5BXsfku9JkqtjdIld
	0wU1zlevlymFoYqfAOGe8QQ1Pwm7IZVJdvgoVjeGLtjYximiPV59uAgJLfXn0LPWD9wQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168078-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 168078: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-shadow:guest-start/debian.repeat:fail:heisenbug
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=e3c85076d7a6f986445b9008be7e7f83d1b0780a
X-Osstest-Versions-That:
    linux=f4bc5bbb5fef3cf421ba3485d6d383c27ec473ed
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 10 Feb 2022 20:54:19 +0000

flight 168078 linux-linus real [real]
flight 168079 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/168078/
http://logs.test-lab.xenproject.org/osstest/logs/168079/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-shadow 22 guest-start/debian.repeat fail pass in 168079-retest

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt   16 saverestore-support-check fail blocked in 168072
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168072
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168072
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168072
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168072
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168072
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail like 168072
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168072
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168072
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                e3c85076d7a6f986445b9008be7e7f83d1b0780a
baseline version:
 linux                f4bc5bbb5fef3cf421ba3485d6d383c27ec473ed

Last test of basis   168072  2022-02-09 20:50:38 Z    1 days
Testing same since   168078  2022-02-10 14:12:17 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  H. Nikolaus Schaller <hns@goldelico.com>
  Jon Maloy <jmaloy@redhat.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Paul Moore <paul@paul-moore.com>
  Thomas Bogendoerfer <tsbogend@alpha.franken.de>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   fail    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   f4bc5bbb5fef..e3c85076d7a6  e3c85076d7a6f986445b9008be7e7f83d1b0780a -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Thu Feb 10 23:13:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 10 Feb 2022 23:13:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269989.464146 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIIcR-0006Kp-KQ; Thu, 10 Feb 2022 23:12:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269989.464146; Thu, 10 Feb 2022 23:12:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIIcR-0006Ki-HO; Thu, 10 Feb 2022 23:12:55 +0000
Received: by outflank-mailman (input) for mailman id 269989;
 Thu, 10 Feb 2022 23:12:54 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nIIcQ-0006Kc-Kw
 for xen-devel@lists.xenproject.org; Thu, 10 Feb 2022 23:12:54 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nIIcL-0005wI-SV; Thu, 10 Feb 2022 23:12:49 +0000
Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nIIcL-0006wk-Ml; Thu, 10 Feb 2022 23:12:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=kQqTnLFxFmKrCvWR9XjNNihl5HPUUt9G/cRtNMEYEuA=; b=noJNi8LiOl0gux67Z3K2pPOZr7
	bC8/C8XarxUr5aN3MuIeS25w4mvvC8nUM3z3Eca9PDBqOJwUDnWE7u0AhqNLjE97MA7owEwqn2PbX
	ffMZLgO7SciLoX6Pg2eQb9FYgVd+9cmaYSWKSWh0L//nR4SL1KI9EGt0xgEM0x9G/hdE=;
Message-ID: <8706c283-80c0-5fea-2834-1bf574e75470@xen.org>
Date: Thu, 10 Feb 2022 23:12:47 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.1
Subject: Re: PCI passthrough support for PVH mode
To: Bertrand Marquis <Bertrand.Marquis@arm.com>,
 tosher 1 <akm2tosher@yahoo.com>
Cc: Jan Beulich <jbeulich@suse.com>,
 "roger.pau@citrix.com" <roger.pau@citrix.com>,
 "xadimgnik@gmail.com" <xadimgnik@gmail.com>,
 "oleksandr_andrushchenko@epam.com" <oleksandr_andrushchenko@epam.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <709142925.628001.1644127197288.ref@mail.yahoo.com>
 <709142925.628001.1644127197288@mail.yahoo.com>
 <0e64c52c-1e9c-e89b-abb8-50171d885926@suse.com>
 <303292590.682317.1644477758255@mail.yahoo.com>
 <2CDAD7A1-A628-4491-9DE0-1F4D5D9FF1A7@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <2CDAD7A1-A628-4491-9DE0-1F4D5D9FF1A7@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Bertrand,

On 10/02/2022 08:32, Bertrand Marquis wrote:
>> On 10 Feb 2022, at 07:22, tosher 1 <akm2tosher@yahoo.com> wrote:
>>
>> Hi Jan,
>>
>> Thanks for letting me know this status.
>>
>> I am wondering if PCI passthrough is at least available in Arm for other virtualization modes like PV, HVM, or PVHVM. For example, is it possible for someone to attach a PCI device to a guest domain on an Arm machine and use that domain as a driver domain, like we can do with the Xen on x86?
> 
> On arm there is only one virtualization mode which is equivalent to x86 HVM.

I would like to correct this. Arm guests are more equivalent to x86 PVH 
than HVM. For more details, see:

https://wiki.xenproject.org/wiki/Understanding_the_Virtualization_Spectrum#PVH:

This is also why we need a brand new solution for PCI passthrough rather 
than piggying back on what was done on HVM in QEMU :).

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Feb 10 23:57:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 10 Feb 2022 23:57:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.269995.464157 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIJJH-00027l-3I; Thu, 10 Feb 2022 23:57:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 269995.464157; Thu, 10 Feb 2022 23:57:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIJJH-00027e-0N; Thu, 10 Feb 2022 23:57:11 +0000
Received: by outflank-mailman (input) for mailman id 269995;
 Thu, 10 Feb 2022 23:57:09 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=j1Ip=SZ=kernel.org=helgaas@srs-se1.protection.inumbo.net>)
 id 1nIJJF-00027Y-5m
 for xen-devel@lists.xenproject.org; Thu, 10 Feb 2022 23:57:09 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 27118a48-8acd-11ec-8eb8-a37418f5ba1a;
 Fri, 11 Feb 2022 00:57:08 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 94E6A61DAD;
 Thu, 10 Feb 2022 23:57:06 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id A71C8C004E1;
 Thu, 10 Feb 2022 23:57:05 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 27118a48-8acd-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1644537426;
	bh=r005aX85VIhDDr1Vqtro622BMgk7L0dZNprygCBXBaw=;
	h=Date:From:To:Cc:Subject:In-Reply-To:From;
	b=ieJwcqB/SocXJkHqDl6ii25zQfJdPS1CH6V0MJRmm5a7EtPbpR/iwICaNqH7yoB5J
	 kjxIfWDDzZ3526HKJV/BztmIQYGRVJf05AbLJA0YNR9o5Swxth8bsRNlGFkBHNTAOB
	 et653UQpCnGnmAHvGDVnSkaujlx/ickOWgmtVKJlC6i4VUp1SNJtPlyEKIboPy1Kan
	 ro3nuRE4zTWHDfvDY9yntUt5hmY3TWk66+grZkOsgCJJVNyzT4XEn+HICXpoyqtuMo
	 eoEJrI0OicU/PeSMGEvp+9IOBVFICoVyGtxfhgiraKyc1W2Rv0ydHEsvab04RO7t9H
	 C90CwbjvFzNug==
Date: Thu, 10 Feb 2022 17:55:32 -0600
From: Bjorn Helgaas <helgaas@kernel.org>
To: Josef Johansson <josef@oderland.se>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Bjorn Helgaas <bhelgaas@google.com>, linux-pci@vger.kernel.org,
	xen-devel <xen-devel@lists.xenproject.org>,
	Jason Gunthorpe <jgg@nvidia.com>
Subject: Re: [PATCH] PCI/MSI: msix_setup_msi_descs: Restore logic for
 msi_attrib.can_mask
Message-ID: <20220210235532.GA663996@bhelgaas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f5a224ee-b72f-7053-6030-b6c4d8a29be9@oderland.se>

[+cc Jason, since you reviewed the original commit]

On Sat, Jan 22, 2022 at 02:10:01AM +0100, Josef Johansson wrote:
> From: Josef Johansson <josef@oderland.se>
> 
> PCI/MSI: msix_setup_msi_descs: Restore logic for msi_attrib.can_mask

Please match the form and style of previous subject lines (in
particular, omit "msix_setup_msi_descs:").

> Commit 71020a3c0dff4 ("PCI/MSI: Use msi_add_msi_desc()") modifies
> the logic of checking msi_attrib.can_mask, without any reason.
>     
> This commits restores that logic.

I agree, this looks like a typo in 71020a3c0dff4, but I might be
missing something, so Thomas should take a look, and I added Jason
since he reviewed it.

Since it was merged by Thomas, I'll let him take care of this, too.
If it *is* a typo, the fix looks like v5.17 material.

Before: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/pci/msi/msi.c?id=71020a3c0dff4%5E#n522
After:  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/pci/msi/msi.c?id=71020a3c0dff4#n520

> Fixes: 71020a3c0dff4 ("PCI/MSI: Use msi_add_msi_desc()")
> Signed-off-by: Josef Johansson <josef@oderland.se>
> 
> ---
> Trying to fix a NULL BUG in the NVMe MSIX implementation I stumbled upon this code,
> which ironically was what my last MSI patch resulted into.
> 
> I don't see any reason why this logic was change, nor do I have the possibility
> to see if anything works with my patch or without, since the kernel crashes
> in other places.
> 
> As such this is still untested, but as far as I can tell it should restore
> functionality.
> 
> Re-sending since it was rejected by linux-pci@vger.kernel.org due to HTML contents.
> Sorry about that.
> 
> CC xen-devel since it very much relates to Xen kernel (via pci_msi_ignore_mask).
> ---
> 
> diff --git a/drivers/pci/msi/msi.c b/drivers/pci/msi/msi.c
> index c19c7ca58186..146e7b9a01cc 100644
> --- a/drivers/pci/msi/msi.c
> +++ b/drivers/pci/msi/msi.c
> @@ -526,7 +526,7 @@ static int msix_setup_msi_descs(struct pci_dev *dev, void __iomem *base,
>  		desc.pci.msi_attrib.can_mask = !pci_msi_ignore_mask &&
>  					       !desc.pci.msi_attrib.is_virtual;
>  
> -		if (!desc.pci.msi_attrib.can_mask) {
> +		if (desc.pci.msi_attrib.can_mask) {
>  			addr = pci_msix_desc_addr(&desc);
>  			desc.pci.msix_ctrl = readl(addr + PCI_MSIX_ENTRY_VECTOR_CTRL);
>  		}
> 
> --
> 2.31.1
> 


From xen-devel-bounces@lists.xenproject.org Fri Feb 11 00:10:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 00:10:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270001.464169 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIJW8-0004zE-4W; Fri, 11 Feb 2022 00:10:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270001.464169; Fri, 11 Feb 2022 00:10:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIJW8-0004z7-0r; Fri, 11 Feb 2022 00:10:28 +0000
Received: by outflank-mailman (input) for mailman id 270001;
 Fri, 11 Feb 2022 00:10:26 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=0PRg=S2=oderland.se=josef@srs-se1.protection.inumbo.net>)
 id 1nIJW6-0004yl-8L
 for xen-devel@lists.xenproject.org; Fri, 11 Feb 2022 00:10:26 +0000
Received: from office.oderland.com (office.oderland.com [91.201.60.5])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 025ac081-8acf-11ec-8f75-fffcc8bd4f1a;
 Fri, 11 Feb 2022 01:10:24 +0100 (CET)
Received: from 160.193-180-18.r.oderland.com ([193.180.18.160]:39782
 helo=[10.137.0.14]) by office.oderland.com with esmtpsa (TLS1.2) tls
 TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2)
 (envelope-from <josef@oderland.se>)
 id 1nIJW3-0033hn-2Z; Fri, 11 Feb 2022 01:10:23 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 025ac081-8acf-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=oderland.se
	; s=default; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject:
	From:References:Cc:To:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID
	:Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:
	Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe
	:List-Post:List-Owner:List-Archive;
	bh=f5LwesLno9aK7qaWhl94ikSb/XMOItWC7LJzHBJ85RI=; b=kMrycBObjs8zLOaSOz4WPSqREL
	nD+2kVkDr3gtM5k6vthe9TCjv16X7XN4BH/yUbAUhJwkOLYvHXJBPmbsNWocxP0dLUcJvAxCHj92g
	rTBAaXyzDIBZ6cviZH0T1r07G9E2zZZ29aDYxg9FpCBsDqPG0HvtbFH/CHe6mMeXGbTU+eXi5Pf1g
	Rfe6efgYsW2Z+vdKkw5ZeLQP8s8Shp/mVXA27x5u23nodMSxOKXB2Ypca0wj8UukuLMrn4T8BMRhV
	xfV4H7TY4FytruN2GNNrXvBn6o0aua/fheNKXm53dQVMLKp6AIyHS5veXfR+TLucxEcg/x0fJKA5n
	ptnPo9eg==;
Message-ID: <69d705f3-8e0d-31b7-9a80-4413b8dbe7a3@oderland.se>
Date: Fri, 11 Feb 2022 01:10:22 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:97.0) Gecko/20100101
 Thunderbird/97.0
Content-Language: en-US
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>, Bjorn Helgaas
 <bhelgaas@google.com>, linux-pci@vger.kernel.org,
 xen-devel <xen-devel@lists.xenproject.org>, Jason Gunthorpe <jgg@nvidia.com>
References: <20220210235532.GA663996@bhelgaas>
From: Josef Johansson <josef@oderland.se>
Subject: Re: [PATCH] PCI/MSI: msix_setup_msi_descs: Restore logic for
 msi_attrib.can_mask
In-Reply-To: <20220210235532.GA663996@bhelgaas>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-AntiAbuse: This header was added to track abuse, please include it with any abuse report
X-AntiAbuse: Primary Hostname - office.oderland.com
X-AntiAbuse: Original Domain - lists.xenproject.org
X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-AntiAbuse: Sender Address Domain - oderland.se
X-Get-Message-Sender-Via: office.oderland.com: authenticated_id: josjoh@oderland.se
X-Authenticated-Sender: office.oderland.com: josjoh@oderland.se

On 2/11/22 00:55, Bjorn Helgaas wrote:
> [+cc Jason, since you reviewed the original commit]
>
> On Sat, Jan 22, 2022 at 02:10:01AM +0100, Josef Johansson wrote:
>> From: Josef Johansson <josef@oderland.se>
>>
>> PCI/MSI: msix_setup_msi_descs: Restore logic for msi_attrib.can_mask
> Please match the form and style of previous subject lines (in
> particular, omit "msix_setup_msi_descs:").
Would this subject suffice?
PCI/MSI: Correct use of can_mask in msi_add_msi_desc()
>> Commit 71020a3c0dff4 ("PCI/MSI: Use msi_add_msi_desc()") modifies
>> the logic of checking msi_attrib.can_mask, without any reason.
>>     
>> This commits restores that logic.
> I agree, this looks like a typo in 71020a3c0dff4, but I might be
> missing something, so Thomas should take a look, and I added Jason
> since he reviewed it.
>
> Since it was merged by Thomas, I'll let him take care of this, too.
> If it *is* a typo, the fix looks like v5.17 material.
>
> Before: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/pci/msi/msi.c?id=71020a3c0dff4%5E#n522
> After:  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/pci/msi/msi.c?id=71020a3c0dff4#n520
It should be noted that I successfully ran the kernel with this patch.
>> Fixes: 71020a3c0dff4 ("PCI/MSI: Use msi_add_msi_desc()")
>> Signed-off-by: Josef Johansson <josef@oderland.se>
>>
>> ---
>> Trying to fix a NULL BUG in the NVMe MSIX implementation I stumbled upon this code,
>> which ironically was what my last MSI patch resulted into.
>>
>> I don't see any reason why this logic was change, nor do I have the possibility
>> to see if anything works with my patch or without, since the kernel crashes
>> in other places.
>>
>> As such this is still untested, but as far as I can tell it should restore
>> functionality.
>>
>> Re-sending since it was rejected by linux-pci@vger.kernel.org due to HTML contents.
>> Sorry about that.
>>
>> CC xen-devel since it very much relates to Xen kernel (via pci_msi_ignore_mask).
>> ---
>>
>> diff --git a/drivers/pci/msi/msi.c b/drivers/pci/msi/msi.c
>> index c19c7ca58186..146e7b9a01cc 100644
>> --- a/drivers/pci/msi/msi.c
>> +++ b/drivers/pci/msi/msi.c
>> @@ -526,7 +526,7 @@ static int msix_setup_msi_descs(struct pci_dev *dev, void __iomem *base,
>>  		desc.pci.msi_attrib.can_mask = !pci_msi_ignore_mask &&
>>  					       !desc.pci.msi_attrib.is_virtual;
>>  
>> -		if (!desc.pci.msi_attrib.can_mask) {
>> +		if (desc.pci.msi_attrib.can_mask) {
>>  			addr = pci_msix_desc_addr(&desc);
>>  			desc.pci.msix_ctrl = readl(addr + PCI_MSIX_ENTRY_VECTOR_CTRL);
>>  		}
>>
>> --
>> 2.31.1
>>



From xen-devel-bounces@lists.xenproject.org Fri Feb 11 00:42:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 00:42:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270014.464180 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIK0Z-0008GO-LD; Fri, 11 Feb 2022 00:41:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270014.464180; Fri, 11 Feb 2022 00:41:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIK0Z-0008GH-HX; Fri, 11 Feb 2022 00:41:55 +0000
Received: by outflank-mailman (input) for mailman id 270014;
 Fri, 11 Feb 2022 00:41:54 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=fLkE=S2=nvidia.com=jgg@srs-se1.protection.inumbo.net>)
 id 1nIK0Y-0008G9-80
 for xen-devel@lists.xenproject.org; Fri, 11 Feb 2022 00:41:54 +0000
Received: from NAM11-DM6-obe.outbound.protection.outlook.com
 (mail-dm6nam11on2060b.outbound.protection.outlook.com
 [2a01:111:f400:7eaa::60b])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 66525fb9-8ad3-11ec-8eb8-a37418f5ba1a;
 Fri, 11 Feb 2022 01:41:52 +0100 (CET)
Received: from MN2PR12MB4192.namprd12.prod.outlook.com (2603:10b6:208:1d5::15)
 by DM6PR12MB3338.namprd12.prod.outlook.com (2603:10b6:5:11f::16) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Fri, 11 Feb
 2022 00:41:48 +0000
Received: from MN2PR12MB4192.namprd12.prod.outlook.com
 ([fe80::e8f4:9793:da37:1bd3]) by MN2PR12MB4192.namprd12.prod.outlook.com
 ([fe80::e8f4:9793:da37:1bd3%4]) with mapi id 15.20.4975.011; Fri, 11 Feb 2022
 00:41:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 66525fb9-8ad3-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=OmkwmLyXVipfiQ2fdogbvUpunvzf0kd8Cugk9toSJy5flXxFT+VUZF9R7/Jiz6dxWRCdOOg2abC+wFVSKgGaOWiEv7FK2MEYWYP2lKKhlzLXqvDPaoCYaU+xu85uZveYEko+9LuwMGRVQvcBwqDZicXwPFaJR2s3J3jAhbVpPFoEGxyRBQxJtDSHKpvZOhFSyUmt6UrnB9ydn6kLkYDwB6y0+HqrAuAseOU+5Dg6yA+8qTHh+UKs7jFEiPfF7ekFWBo+EsLoEuVtS7LkUW3YRJdppkfMCjMuXOObjHrfLUrUe/HgZ8T4ZYslUfL2vEN0hojI6O0sPvLFBSVeY5myCw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=4geiNE5wNKEzx7ODRCekobfzQJ2m4y0X8LjNiizgO3o=;
 b=X4ksOC1frQYNuqRvM/7/GG+8BxXHuR6FNre+5Ufpzi/UcjD+Bj56SEllB7bEIxhyQT5HOYUvdyzAsFB99AAUTL9vu21PWbB6RMn/s/5DBc6+vstv9TaKyhkvbsxPYvi8bC5KwqIqHczbUhX98qzs+pKiPHVmj/X0usQgtlgsQAMqteQPeRk+EKaqiRCm7YcdC4Icq4pZSH0ekriREZNjHfkC6Os7THhy+GFC8/evD4knfiqxUUGjMwFA8BxTyLigQfKRLUbHgjwD3sDaoFUxGcHC9nuKSzTsXkeuoO4t3ntn7RofR+xHRJPJ8ZjeP6L91vd68PC+IWkooUCIkk0/cQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;
 s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=4geiNE5wNKEzx7ODRCekobfzQJ2m4y0X8LjNiizgO3o=;
 b=LbT7WVZniek0/tBPyRiLAxfjO6t0R3SfQaT14DNLK3O1dHA9SdUvgYdxylUyOw7fzKT9Xhlx+W7lPm4/2mVvvEF4sKgdSpn8b5pPUd4zhyuj7tTHGw1OE0xAjuwnIKx7weGcD4XaQJ14mQKNS4fBQrIju7X8JbiZhc6EdtT0kv8RtjDcXbwzCWOxl7qQpPhkzYluH4GonvxWq6N0iBSghhVxWAP0esfzJWpFrayzfEiIFa1ABKyrX44nNKqx6DoHbIGkGU8MN8k9xZFNf66Mg8csJXhl64y+qUtXmY8mfo8tBVeKYp8XBktP7hfNU1ckGPv/hhkfph/l9L9xNf0omA==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=nvidia.com;
Date: Thu, 10 Feb 2022 20:41:47 -0400
From: Jason Gunthorpe <jgg@nvidia.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Josef Johansson <josef@oderland.se>,
	Thomas Gleixner <tglx@linutronix.de>,
	Bjorn Helgaas <bhelgaas@google.com>, linux-pci@vger.kernel.org,
	xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] PCI/MSI: msix_setup_msi_descs: Restore logic for
 msi_attrib.can_mask
Message-ID: <20220211004147.GK4160@nvidia.com>
References: <f5a224ee-b72f-7053-6030-b6c4d8a29be9@oderland.se>
 <20220210235532.GA663996@bhelgaas>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220210235532.GA663996@bhelgaas>
X-ClientProxiedBy: BLAPR03CA0135.namprd03.prod.outlook.com
 (2603:10b6:208:32e::20) To MN2PR12MB4192.namprd12.prod.outlook.com
 (2603:10b6:208:1d5::15)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 8b59569d-a826-40bb-b133-08d9ecf74953
X-MS-TrafficTypeDiagnostic: DM6PR12MB3338:EE_
X-Microsoft-Antispam-PRVS:
	<DM6PR12MB3338736ED55F7F7980C0C638C2309@DM6PR12MB3338.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7219;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	TxI1r/6O2L9O7S+aCRA0wUyu3usLIPURkmDze5brCj+NJzvOeDoDrkY/dmAI3KYEdmg9/DqsYCHzCkVQ/L3I3ni1N5+6M/RdvrHphGE8DZuFt2JIh4u5tpTOsBDZk1tNHxxSjA2pOmwa6Fl1P3fmsPediLPEGhVrgVYf4v0mbQjgeXtF0aUTSLymjRbfaKjMyShm3PBavOdahYrY9sJevHFqMW8OoFlb/yWj3ZbAhwWECxiTL6gDPBesmVPNandwU7Ry03Vx+kedUaeULjWSz/L7Ifcp6lgGjvzP/J56PHzYhgyu2meXifETKVsgSVZPdQRr84zlF8OO7pzjhGghP/Am0HBL3FoWg1OzUMLOmCboA4o8O5i50roFrgd1yvufYbVCRfmzwsKYSfeJb049d+wqpAG+LieEWSdTIVXHDD1/7Vb7zpKTCGQPufcjYOSoiI9gfxRPE/kQyhAmKY7DxHaSjtHQ6uD3MHCjnzmB49nuz29gQFoUMWce2GWGAjDhceUiUPH87741jHZ3bCqij59KbhpO8VwzhXvbVQ/y9ZZ+rETEsqLTG9apZXqIGJx9DpmfCxptgUZL3WTIiakFM4XgLQQAAm3DtTmNZednr5Sgq+s0nWCR5pbsM0IbkpakW4k9iU+PM9klPJuErDPAYg==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB4192.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38100700002)(83380400001)(1076003)(6512007)(2616005)(186003)(4326008)(8936002)(6506007)(36756003)(316002)(6916009)(26005)(66556008)(54906003)(4744005)(33656002)(5660300002)(66946007)(66476007)(6486002)(2906002)(508600001)(86362001)(8676002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?9SgokovyEVYA1rXtvfv0nqsW7nm1joc2RW4N6nJ9+g0lOMHtK3LSfvBMKfbp?=
 =?us-ascii?Q?JSgz1Fm0bWIgWVM69giROrIxsEe4Ph5X5303FYlzN/N8nua21V8htXcg7nxX?=
 =?us-ascii?Q?IkByPQDA4MZZx5+I/z9UqklAGVV1+kBXJed5866M35r1gcxWnuGsb2Fm+hYD?=
 =?us-ascii?Q?WYY84fePKxIbay8zqJ/o/glW05WW4xNp9kM4J8F9Ygmt6rYW0ucSNvoIlQnv?=
 =?us-ascii?Q?lRrauFbhR99e4lNhlB3yvQv6L691TAJtMJhUpJwGJYciPovo71z2mPP9znsh?=
 =?us-ascii?Q?zmyL1brvxm2kpM7axRhO8GHBjevX2+Ay07MEwmc7mO6gxqRmKnOcPkP1RVnL?=
 =?us-ascii?Q?Sp1SIWDMRTMGsFHGiR78tT0JPfFI4lP9PXwXGQIbPrKi8um+j5pDjouVJiU3?=
 =?us-ascii?Q?AUXWvyinml2lwPbPMjmith1Nt7A98BCuGpimLmWzMfy3LHtVpUucXINkF3E9?=
 =?us-ascii?Q?22ACR5slyWokOp5Sea3TmOE3JxmU502P4XiK8JgsAB21A/w7CxBpgxv9PmJq?=
 =?us-ascii?Q?EUcatnto0+3YaSC5c2UQ/QPNckMY8FGKWdggL/hnZKR0h2yfyHoaYXqHSy7D?=
 =?us-ascii?Q?C/Y+iRnb1OeoCg01h5nlk3AWbkhLn+reQu1pXO/DL+uNaL3ZAVJjojkdUILC?=
 =?us-ascii?Q?go1m6QfWh9GeCPmFTbnpsyIRKNxguPdsj20h8BuCJUr/6Fh+MM4aiqQlfqh1?=
 =?us-ascii?Q?VRvT1UvaKmM7nVmvs7TY0w7zRq/0tQ37QzqKBUHQc2KRUwxMBWzpJKXtT/Cl?=
 =?us-ascii?Q?tQuWMIrKxWPaT8k0OEvIxvljZI7mWhMqKl1W6GVL0VCVJc/kdnYFkTN6aJV6?=
 =?us-ascii?Q?B/UKn8DelFZS13FCUS7Z84KumY4tLQaojnIOP9xmNuDSNCm0r9Rbb6k54uKb?=
 =?us-ascii?Q?NcMG2tBJyQSdXkhyTfXP1uhdjSuXNzTuNNxqCibLW4L7p0BK7FoAKWQxfvZf?=
 =?us-ascii?Q?Z+Cy27uH52t9wajG7oB5PyP+UA038UYj04Xl+1oOCPGo8vz2D3d0Q65qXphs?=
 =?us-ascii?Q?hZR/pXfS7QafiMDK3TzQsmpZUFsMYyJpWk/ilmRSTWOuNRMZgllHMRtQFHQ4?=
 =?us-ascii?Q?IzBiC2byAavFCEKhkTBglaeJUHKVoRWNmthblTKsu+0vsIQ7u1Y0J2/m1qKd?=
 =?us-ascii?Q?Q5q1YYuST04fdFVJ2npQ9aMOu+QsKAhpuAU8Mk3A3XoiFyAzesBijuwbdrgW?=
 =?us-ascii?Q?I9SrjKP9F9mWqwucGKIfA4kGZWWzUqr02eetz2YEZdwvId1MAX1SlqJ+AEFF?=
 =?us-ascii?Q?I+le1h1sRbPoDipJYOTYAoXNWvq0YbhGIyL6uzZcsF8SThHIrirQXEfJI1BE?=
 =?us-ascii?Q?IDoHfo/dWqI+kr0KD50iUN1LnpSjTYL7Qn3f1Zo6uVhpdrVrB8RxsWvgbpbO?=
 =?us-ascii?Q?vPUQylk2deg7kbTocOK5IVzwaYImB/G6a5l4su/fZ0yoEg6qxgXn1aTi2DTY?=
 =?us-ascii?Q?zxjfRMbBPy0eFu/Kck+tbe+bP3tqxXR0OqFn4cpT7KPjSi0nhwkiTVd0+ryq?=
 =?us-ascii?Q?omhX12r0PyU/FRXp9h2mbk2DSIQ0+xaFQKuJ+5A//Ks2Z61NevxnCUocxx2R?=
 =?us-ascii?Q?Ei/wae9jtMGBR/xlPnA=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8b59569d-a826-40bb-b133-08d9ecf74953
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2022 00:41:48.5777
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mfOvg6sBsUmf36ncZbEg0cKDKM6Y81pd25RJUdGM8+TIcZq6S3yX2DVOjBWP4A4j
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3338

On Thu, Feb 10, 2022 at 05:55:32PM -0600, Bjorn Helgaas wrote:
> > Commit 71020a3c0dff4 ("PCI/MSI: Use msi_add_msi_desc()") modifies
> > the logic of checking msi_attrib.can_mask, without any reason.
> >     
> > This commits restores that logic.
> 
> I agree, this looks like a typo in 71020a3c0dff4, but I might be
> missing something, so Thomas should take a look, and I added Jason
> since he reviewed it.

I concur

Jason


From xen-devel-bounces@lists.xenproject.org Fri Feb 11 02:31:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 02:31:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270023.464191 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nILiO-000472-UG; Fri, 11 Feb 2022 02:31:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270023.464191; Fri, 11 Feb 2022 02:31:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nILiO-00046r-Mr; Fri, 11 Feb 2022 02:31:16 +0000
Received: by outflank-mailman (input) for mailman id 270023;
 Fri, 11 Feb 2022 02:31:16 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=+l4G=S2=vivo.com=wangqing@srs-se1.protection.inumbo.net>)
 id 1nILiN-00046f-QP
 for xen-devel@lists.xenproject.org; Fri, 11 Feb 2022 02:31:16 +0000
Received: from APC01-PSA-obe.outbound.protection.outlook.com
 (mail-psaapc01on20702.outbound.protection.outlook.com
 [2a01:111:f400:feae::702])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ab988dfa-8ae2-11ec-8f75-fffcc8bd4f1a;
 Fri, 11 Feb 2022 03:31:11 +0100 (CET)
Received: from SL2PR06MB3082.apcprd06.prod.outlook.com (2603:1096:100:37::17)
 by PU1PR06MB2326.apcprd06.prod.outlook.com (2603:1096:803:39::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.17; Fri, 11 Feb
 2022 02:31:04 +0000
Received: from SL2PR06MB3082.apcprd06.prod.outlook.com
 ([fe80::80b4:e787:47a9:41bb]) by SL2PR06MB3082.apcprd06.prod.outlook.com
 ([fe80::80b4:e787:47a9:41bb%4]) with mapi id 15.20.4975.014; Fri, 11 Feb 2022
 02:31:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ab988dfa-8ae2-11ec-8f75-fffcc8bd4f1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=YSefw3STERiZDcIboyeDQ7hVKDchAQmNiB+4Me7dl6Hcb1z+0Oqgm3aM66s8SqkKw38i3oUKOdMWmLBQ3EW6hUKtInvyxfUXoPQW2KeWtlzOMhhzAy7nDQG8sddzIb04S03hIY6Om3cJLu5guOXRzofHTz0ccs5VuhOr09JQBAuDhUgzHS2WKhn2uLtXvz4yMGQrgJPA604slMMBrKewjLqgbCCE2wTUUoEKHgQZOcbrT31PTpFulYDvt1F6rVEznJM9Z5I67SlEbkAqx0HfXUP+rJBlF4qdJBOjhPdEHLUIDClE40/lXXWZqW3S9o2YFjM8cVuqgdBWoY04SjJnXw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=DtHTZjVp3/VIpdOr4maT4KogzTfiuLSuNCTpXn0uCe4=;
 b=aYLnns54XD6A1mh0Fd4udT7fqmyk3ABsFlEGZbjf+LqY9YJQR26MALJwChpve2qmcfB/KsD4Lk94RF3a/W/XaAo9Y2cr8KJj6jc3UXT6jBT5antCKsZuQC1FQ+Xdk8eCKG88S1wpVpJsFNVSVEV5VjrpSYD3AfI7kiawi2Lx1I5OKP4/yMcQ65C4cM2MkzppacEkHdxu+wpJ6sxI57Omhx3eYwFA0pCKSehmuEiIXNXTa0GSobNJJ2eB9Bvkn16OyctIegIiza18y0lIhHo2yYTk/uHKTpZV/bMXefKpFv5OvKBNbnsHFYBgdo/ULcCEo0QvUiEECEmpxvhycddWeQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo0.onmicrosoft.com;
 s=selector2-vivo0-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=DtHTZjVp3/VIpdOr4maT4KogzTfiuLSuNCTpXn0uCe4=;
 b=LtxIKR8TwaCfMLahGSAsLm7wTDmx0MjTNDXNrrSZ6pyJ36HWN8QlKb17cwCgl7tU4/RMTQVTsWxQ5rWVcFCaqEiAqBHVhmHiiqH0BFi58/3TrufPzB5h27wsA9RsEGdMHy0EmpOW+yg2IlAzfyVN+1QHoCOG16i9iZQydnUQ8y0=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=vivo.com;
From: Qing Wang <wangqing@vivo.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Jens Axboe <axboe@kernel.dk>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel@ffwll.ch>,
	Alex Deucher <alexander.deucher@amd.com>,
	=?UTF-8?q?Christian=20K=C3=B6nig?= <christian.koenig@amd.com>,
	"Pan, Xinhui" <Xinhui.Pan@amd.com>,
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Alasdair Kergon <agk@redhat.com>,
	Mike Snitzer <snitzer@redhat.com>,
	dm-devel@redhat.com,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Hans Verkuil <hverkuil@xs4all.nl>,
	xen-devel@lists.xenproject.org,
	linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-clk@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-input@vger.kernel.org,
	linux-media@vger.kernel.org
Cc: Wang Qing <wangqing@vivo.com>
Subject: [PATCH V2 00/13] use time_is_xxx() instead of jiffies judgment
Date: Thu, 10 Feb 2022 18:30:23 -0800
Message-Id: <1644546640-23283-1-git-send-email-wangqing@vivo.com>
X-Mailer: git-send-email 2.7.4
Content-Type: text/plain
X-ClientProxiedBy: HK2PR02CA0178.apcprd02.prod.outlook.com
 (2603:1096:201:21::14) To SL2PR06MB3082.apcprd06.prod.outlook.com
 (2603:1096:100:37::17)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 12f0423d-5bf0-4afb-3a90-08d9ed068cee
X-MS-TrafficTypeDiagnostic: PU1PR06MB2326:EE_
X-Microsoft-Antispam-PRVS:
	<PU1PR06MB232661841B6B806EA7C2DEF6BD309@PU1PR06MB2326.apcprd06.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1775;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	N9trxlbl85cMDnsQkkH1NC4DB2oryjBfFLQsUgCCNeCl2CbbcZ+YgilLN/AZN1ENXpGHAyeZWvYBY2Pp6xozkOCR20owugnbsLfd+E2CQIFeAex9C3b6SJhLHKl7yHDgY7ioaRc1rpaxu08s5gCp19GzwYLa0hYKpKcvrOQ+WNPcqadNFPok4GVOX4weMXak7W5S1X59H1nHLhKH/JT1m0uWtvsSAU710Fe6bGuF8UM32wCVRwfR4dIcZQRv1atzBaJ2A82pL9d+3XC86vlz922G2Is9bo1Q1ZTHal3UPjNomRICshdnz8bqjq1DaGxelYaJ1U/qz7LLVOoPkncOR8ULs/KpaMTSG47KK9JeRgJHh3FxhVbMu7M+xolm/ydM0NrYyFaQ6YJSOaNB8WSeKT+XLaflRJPLbQGPicklK1imKq8VhAlmtcfqwglnAu0ZxAPCPjzseThQTOXaKDxLaZeySNXMCpSetaf1f2e4oTMwy9GaJXNmZA1hNUZGiH7uM3zh9hWtqO1wHNCaWlVrUroSwkec+dVbBcczRH1gyemvigWjajwJU1E3IlxzC2z7WMpRbWndl/IPRcHD9MIasgUeEk+LW3qEdZzVN6waxEyfdoDuGinvaR3tQ5BzVrrgAARnpufnW41cCi/s+9hcwUTI7GlJJVhKYPmH6RjUeewlo6HVdtYyFW+6BJyW80SGhzAoPARdBSiu1hHPGrEq2f2Aajq/rwSppDoyF8F6D8Dbq1qlo/WeUdpMeXNL4cOE
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SL2PR06MB3082.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6486002)(316002)(508600001)(110136005)(2616005)(52116002)(86362001)(6506007)(6666004)(6512007)(186003)(26005)(2906002)(36756003)(66476007)(66556008)(66946007)(921005)(8936002)(7416002)(5660300002)(7406005)(4326008)(83380400001)(38350700002)(38100700002)(8676002)(107886003)(21314003);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?pwcb38pbAiZgks5vknGSpVoACVQdz2OjZOtgR8g30cFJLya5iYzxuEwxWSD8?=
 =?us-ascii?Q?F2zFdn1HzCeesLJ/LhSOMcQIZ17yIC+zD93PCoHIvsn81zd5PJmkKaMZjgh8?=
 =?us-ascii?Q?dOwkC8xO887eTtXweQ6x1rPlSCJ2K0eh1RUa7M9qDK+ONK2Nabjs10CDvBpm?=
 =?us-ascii?Q?a4/rHJl+9lAxDfyZIrkPsQENijzWitWsY4CBkwnccgNnLWV1xHM1AV/5BtOn?=
 =?us-ascii?Q?y69ZOvUr92hx7X2ThF1+D8q6UKBOJaWOYy/mwmCFUAuGBHcMdB+DXe5X83K9?=
 =?us-ascii?Q?IqJ/QK/25ZTOEWgK9NpUpg4MK7sOK4ul7jAAbHBXylQob7W8UQ6iFwGJAD4z?=
 =?us-ascii?Q?H4ay9UHnBZIIMU/U6Z0l355D3d02LK6lHmaHu1quCS/ao2g0ZYekI5CN6UoF?=
 =?us-ascii?Q?iY4akDiecD5ZC/J/xnj6KgT565iXLwVfxk+L7jMQZbrnwrtu9vRvxuHtIB8P?=
 =?us-ascii?Q?c3kcz83uk+bVzdA6x6KGwYxyep/6ykGUlNLXxpGWDibTagxnJhNkhzviXzAp?=
 =?us-ascii?Q?/iLu/UzvaLz9VOLV/ajxzEbJe4DwUlyW4mCXAM57XwtSRnT7CpGqbss95PY2?=
 =?us-ascii?Q?AKElaZrIkxbZ2kIQWkEdPKGfhovLHcJ3NNxxcg7YfIvv/0m8a0JaHVdFiibR?=
 =?us-ascii?Q?PxY9J5lMs3jKNL4Ecjjyv1H1LodRQSYNbuXC9qJQMQzI0sX108tXnQAVnjB8?=
 =?us-ascii?Q?LlQoarEoKY9XutBBEVACRAPUd89OWnqDKLaKIgaVI9LlyiYP+gMTXNsd4pF4?=
 =?us-ascii?Q?CXbrpVFZ8o0YgXZMdbWb9KBFagBwMjBJurbJeegqTED46CLq+pYYo8pV79S1?=
 =?us-ascii?Q?l0a02iNvxOu37QLIBSFRvGQpcVAyzxDADzSz75zyFAzBT1udwZCaxt2dOepR?=
 =?us-ascii?Q?tPt0WO4nyAVY9QpeGejxVnT/NGp7ymGh1Gu4hjKf5+fayS9k/CFnT1NIb3MS?=
 =?us-ascii?Q?EPXieryJ0lsEmfAYhvudv44/JA7wVa1iee16Esh+sGR/bJQpTgrzQEydXbOb?=
 =?us-ascii?Q?tHrD7jG7a3bToFEkaIxuWT6ejn1UiyTniSMPa814qUgdJJ6O3X9p33MNtwlO?=
 =?us-ascii?Q?/gJTYCEXvHaJIEfSL0Tc7rapuQBb0/rO9TijUJXuOkuldx1t3ldWEwDkl8bp?=
 =?us-ascii?Q?u3wDnytYUOm4b4ZSBPYi5Xs4w/URs8oRwmORk5S4BrU2BjhDiZTTLximGuSd?=
 =?us-ascii?Q?Wa6YWglK87NtFlGApVn007Nh2gEJ83Sw6Q0gt99dJAc8eUPhVMcdu++aM1v7?=
 =?us-ascii?Q?BWNsKpCog8jk4Y86Cxb3WJ7IiPEEWDMP9+1EMxqzstlEgaEUR/7xWsGfLTdw?=
 =?us-ascii?Q?mIYg74qMN3YJgYMQdSuTMbiO3MUJqF+HDB8Wd7fxvLdHwCUP6qLib1i9gBFY?=
 =?us-ascii?Q?FuVXf5KDGjeCXlHNLXSrTi2Mo8tAUcdnC+X91Jh8Jsm084DQtr6dNh1hG4Ek?=
 =?us-ascii?Q?e1MgOtr35Qwjq3nCRicTbpKAwvtP3nQDOmFhvGQOqRT9a6mWyOcLdSY1LxUL?=
 =?us-ascii?Q?W04bpI7dZNMA5pfEe4jlBMTu4w+Qv06LEYS1ykxLBno3f64iIgsaWSGJxUFc?=
 =?us-ascii?Q?K/WclKYZWok7B08WPCUgb+I17WauS0ctVHGawxfjxm/h0AG8W+f4tdIlIDFZ?=
 =?us-ascii?Q?Qt8ji3YjhRcJvw8oe6IMwoc=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 12f0423d-5bf0-4afb-3a90-08d9ed068cee
X-MS-Exchange-CrossTenant-AuthSource: SL2PR06MB3082.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2022 02:31:04.3863
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 83te74sRfLTcPmKrUYJgY5E4cshmgUH/XLr/pshbIFi5WC+b08UVDDt+dUyLCUoWRfeN1LzfFiWdT0c833J0Hw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PU1PR06MB2326

From: Wang Qing <wangqing@vivo.com>

It is better to use time_is_xxx() directly instead of jiffies judgment
for understanding.

Batch them in a series suggested by Joe.

Wang Qing (14):
  block: xen: use time_is_before_eq_jiffies() instead of jiffies judgment
  clk: mvebu: use time_is_before_eq_jiffies() instead of jiffies judgment
  gpu: drm: i915: use time_is_after_jiffies() instead of jiffies judgment
  gpu: drm: radeon: use time_is_before_jiffies() instead of jiffies judgment
  hid: use time_is_after_jiffies() instead of jiffies judgment
  input: serio: use time_is_before_jiffies() instead of jiffies judgment
  md: use time_is_before_jiffies(() instead of jiffies judgment
  md: use time_is_before_eq_jiffies() instead of jiffies judgment
  media: si21xx: use time_is_before_jiffies() instead of jiffies judgment
  media: stv0299: use time_is_before_jiffies() instead of jiffies judgment
  media: tda8083: use time_is_after_jiffies() instead of jiffies judgment
  media: wl128x: use time_is_before_jiffies() instead of jiffies judgment
  media: vivid: use time_is_after_jiffies() instead of jiffies judgment

 drivers/block/xen-blkback/blkback.c                    | 5 +++--
 drivers/clk/mvebu/armada-37xx-periph.c                 | 3 ++-
 drivers/gpu/drm/i915/gt/intel_gt_buffer_pool.c         | 2 +-
 drivers/gpu/drm/radeon/radeon_pm.c                     | 3 ++-
 drivers/hid/intel-ish-hid/ipc/ipc.c                    | 2 +-
 drivers/input/serio/ps2-gpio.c                         | 4 ++--
 drivers/md/dm-thin.c                                   | 2 +-
 drivers/md/dm-writecache.c                             | 5 +++--
 drivers/media/dvb-frontends/si21xx.c                   | 2 +-
 drivers/media/dvb-frontends/stv0299.c                  | 4 ++--
 drivers/media/dvb-frontends/tda8083.c                  | 2 +-
 drivers/media/radio/wl128x/fmdrv_common.c              | 3 ++-
 drivers/media/test-drivers/vivid/vivid-kthread-cap.c   | 3 ++-
 drivers/media/test-drivers/vivid/vivid-kthread-out.c   | 3 ++-
 drivers/media/test-drivers/vivid/vivid-kthread-touch.c | 3 ++-
 drivers/media/test-drivers/vivid/vivid-sdr-cap.c       | 3 ++-
 17 files changed, 31 insertions(+), 22 deletions(-)

-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Fri Feb 11 02:31:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 02:31:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270024.464202 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nILiQ-0004Mh-6E; Fri, 11 Feb 2022 02:31:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270024.464202; Fri, 11 Feb 2022 02:31:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nILiQ-0004Ma-2m; Fri, 11 Feb 2022 02:31:18 +0000
Received: by outflank-mailman (input) for mailman id 270024;
 Fri, 11 Feb 2022 02:31:16 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=+l4G=S2=vivo.com=wangqing@srs-se1.protection.inumbo.net>)
 id 1nILiO-00046f-Gk
 for xen-devel@lists.xenproject.org; Fri, 11 Feb 2022 02:31:16 +0000
Received: from APC01-PSA-obe.outbound.protection.outlook.com
 (mail-psaapc01on20702.outbound.protection.outlook.com
 [2a01:111:f400:feae::702])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id af2e3b17-8ae2-11ec-8f75-fffcc8bd4f1a;
 Fri, 11 Feb 2022 03:31:15 +0100 (CET)
Received: from SL2PR06MB3082.apcprd06.prod.outlook.com (2603:1096:100:37::17)
 by PU1PR06MB2326.apcprd06.prod.outlook.com (2603:1096:803:39::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.17; Fri, 11 Feb
 2022 02:31:12 +0000
Received: from SL2PR06MB3082.apcprd06.prod.outlook.com
 ([fe80::80b4:e787:47a9:41bb]) by SL2PR06MB3082.apcprd06.prod.outlook.com
 ([fe80::80b4:e787:47a9:41bb%4]) with mapi id 15.20.4975.014; Fri, 11 Feb 2022
 02:31:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: af2e3b17-8ae2-11ec-8f75-fffcc8bd4f1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=npH1iPy/cK2EfovjDDJ0g29/nvaBE85BtC0SCeJi8J5FXnq1JoPf3PNTYZLFlsfZyI4fw9w9+8IaUCg0QaGXRvDKRzfylathGXdfBJv8apiCyrU7Cru9sXOqq11hXbhNJXaUSBchllWj2ZX4WAXkVXC1DPtdGjIxKIuqTGL1ApaoG/4orO4TAgzlxYmMMsHgjKxOGlDKeFAhg30ESkSkM6xZYv7NwZUZqn7sFhVvhltmGwjOY99V+yIJaASXFJ8zzdpNgq8XBFHmWCl8at/EpTFdJAlA/6XuGhyCUL2Xe7+1f3VghJ0uxxoD9qw1hzwrl1K095OLWU3tUshRY6m9mw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=IYuRSWgY6HaeljgNbxaZaf003O9SNKziTfmoexXwmbA=;
 b=Ff/TaPCh2f00LsjtWP+09mBSTE0lytvDFZ3xbkS4jw+/a5T3odWlRplg3MUYR5thE/TuBAOi29OWXNPdvEFfhhAxm5GjVBYCw+E00LFfpNrHK+QpZ56c2liJJ349UpZNQZ1saGtI7uB8GpZ/koSlMrOh4FXOglVIRfkxMXXaxiWIzF0bBtXGkv4CY6e/J+4T7GbpJGQHMblgAnW9aItBuwk5QMqEvmc/EDATSyaCNXO2E9e0rjDqba+fZJpeuWv0IcxHKnzWBywITvYK0Cfcn0GvZwZgml9a2e9M9ahEC9PAvNMPdp+Zncb+AI9kWnA0wLdmPUOpl6zNQVipOEM6ww==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo0.onmicrosoft.com;
 s=selector2-vivo0-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=IYuRSWgY6HaeljgNbxaZaf003O9SNKziTfmoexXwmbA=;
 b=DahaCz8LcBl4s4N93+t6hpH9V0D76QtWgLDSv/Ttcuazd59HNa8GR4q9vUL78daNMYKu3C9NuRFOCOANhI9z9aGVHZjLH+FxTNt8gvf7YM8+wsEiP/4KT9ZK6Dtn9VlMWYOWEZd1xJEHTtwkYou9gsfNcZsP0LmmireP0VMWUZ4=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=vivo.com;
From: Qing Wang <wangqing@vivo.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Jens Axboe <axboe@kernel.dk>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel@ffwll.ch>,
	Alex Deucher <alexander.deucher@amd.com>,
	=?UTF-8?q?Christian=20K=C3=B6nig?= <christian.koenig@amd.com>,
	"Pan, Xinhui" <Xinhui.Pan@amd.com>,
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Alasdair Kergon <agk@redhat.com>,
	Mike Snitzer <snitzer@redhat.com>,
	dm-devel@redhat.com,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Hans Verkuil <hverkuil@xs4all.nl>,
	xen-devel@lists.xenproject.org,
	linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-clk@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-input@vger.kernel.org,
	linux-media@vger.kernel.org
Cc: Wang Qing <wangqing@vivo.com>
Subject: [PATCH V2 1/13] block: xen: use time_is_before_eq_jiffies() instead of jiffies judgment
Date: Thu, 10 Feb 2022 18:30:24 -0800
Message-Id: <1644546640-23283-2-git-send-email-wangqing@vivo.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1644546640-23283-1-git-send-email-wangqing@vivo.com>
References: <1644546640-23283-1-git-send-email-wangqing@vivo.com>
Content-Type: text/plain
X-ClientProxiedBy: HK2PR02CA0178.apcprd02.prod.outlook.com
 (2603:1096:201:21::14) To SL2PR06MB3082.apcprd06.prod.outlook.com
 (2603:1096:100:37::17)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4453172d-1062-40a4-51ed-08d9ed0691c8
X-MS-TrafficTypeDiagnostic: PU1PR06MB2326:EE_
X-Microsoft-Antispam-PRVS:
	<PU1PR06MB2326541D928E240EFB1B6D23BD309@PU1PR06MB2326.apcprd06.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1284;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	eP6YOw4R3jawIEQSMCI45OGmHyly8vyYqkhdazwPrzt/6mtGuIm71LmjFaxy3UVdqYDII6o/y/paR4ORUrg8wMyGV160gfTUQz9n5XwUATSstX5nu22RuE2sZxAZB23/YiAyCv1OX+HuegZUDD5lOEVEc6CekrE4Mal29dnB95X5fbrQGJzYk+XIKdNtt96nwEhHDxQjy4pj7d3pE5VaX9eMSCBhCBEC9iCFkRuzLfGtk9gZnwXMRJlKor3LLtrfA7CBwianCeTo+bpELFXyvu9LJCw03dF7F50eEcA3DuXkoWw9dTLPwjG7mJqa+r9u5D9eBQZBUce22QKwLgyhPcuGXa2kshtC5V81ojRl8eyt0yUNosYZ42KOeUp6toEG3uLD+4nhVSuloqdJKU1VCcpABn0f+LE8zMftaja2FIfzdD27fEwVQxdpD24upmy6rqVLvEi1/2cnacV7YSVU3Igmo40bsXSHClkLZTCPsdZ962221FDY+1pc9yTSlYoahyWqjc/mm81tDPEWnMhlXTZ2KNVr/4IjVUkk4ij26KtXBJmtGzwp4zB4wl2rxr/xyLgmDzs2mW/16icoCVHomtTT7manT7c5fGBM35UA3KKs6k/BugqXbMBiBWWGdWFybPoeG3iZNsOqhVoWWxweotu2czABYRfNcH9FwTUX/zuSKqjfnbW7lQXTJZET+ole3DBOvRqdwg90WVQaBtLlGExMPrX6cUf7lH669g2bGWAQP1QdDWoZoiSLsJ379vAG
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SL2PR06MB3082.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6486002)(316002)(508600001)(110136005)(2616005)(52116002)(86362001)(6506007)(6666004)(6512007)(186003)(26005)(2906002)(36756003)(66476007)(66556008)(66946007)(921005)(8936002)(7416002)(5660300002)(7406005)(4326008)(83380400001)(38350700002)(38100700002)(8676002)(107886003)(21314003);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?MPOxFWmB5E2Pt/1C2XrNteRXkmz8Srv8O1WeQjdRIJU6rqpIOUQ5pVdAGRBz?=
 =?us-ascii?Q?ikiVLOKIG/bsksxsxLXa93yDiSqxXJ2QAMm2lSXohTG0XKgY/DT/HRrbdMgo?=
 =?us-ascii?Q?3eW5tUsoS9yKaWiHtelJ11se6jPYZyL4GXtGZ/ugyMCK1H6QXVu2q0n2VqSO?=
 =?us-ascii?Q?mOZudoKGdD8HPLpn+yYFL9B0KRLO9T1629z1rr1KDv7WgxJ6KwKZwzwjOwON?=
 =?us-ascii?Q?hz7QhC9lX8MBPJT+NuaMNgfnykBSYwV8efbX/Bq35XKgjEF1NVac34OxTqiX?=
 =?us-ascii?Q?Et2rMv4di+3kp4C7gIfqwRyqUNPWmQY/F2Qf+GG0d9b+4nLSI3F5YDGaxm38?=
 =?us-ascii?Q?SoZ9PQPJVtzh4lfpYCmtW4asY08kGCWIfiycxT84k09lt66SDqSkN3qFXLDo?=
 =?us-ascii?Q?OLlE5VAMR/cUTOiaIBxkyDiB04apQLL2J+bs6nSHqSs3E+hE8/hnt6oQy9GF?=
 =?us-ascii?Q?vrq2/c8fCDGdiqhQ8tODcW7iAdemra8ZS8E8p30MBjxIgVyr69Yx3pXWnZ7e?=
 =?us-ascii?Q?fDBd/whApX0RA2ofv7R6KVppKQgAImbyWTvoxOmKWDJzp1faafR1ZSyg+FQV?=
 =?us-ascii?Q?aI14/F/RcFzsXxwReGbuabevcgnUx7A7870drwtY0Qowhe3N1+6nXXW4PJOI?=
 =?us-ascii?Q?3iV4TXCAxYKQMy8ypCBgG/8iIsrrsc4qmyUOwo/fVu7dWfEcZ5DwizXeUPbg?=
 =?us-ascii?Q?hpBgQhVBphZVFQP28m5PyvpOpMuYXHs4XSfHi/t+iOQGs/7TdHpP8HYqHZc9?=
 =?us-ascii?Q?kiXAni7iCPY1MLg10Ha4GiSPKGdXL2p7ZOaX6l80MS1XPfOgYK4ApWhaWeZi?=
 =?us-ascii?Q?GJQ4GVKoB4uqy6J1VWsms/N3WIkvggzBvltoJbr+Xebdd70O3qtnsPlv9ENg?=
 =?us-ascii?Q?2/yQmwATPR/bh0wZsQAU11hDUXMgp5LRSoywVb/BDS8nia7h8QO3eYdsSbjW?=
 =?us-ascii?Q?JbBYtM8noZ1Q5XN1v9RnqTrwpAFnU2XAUijG9nx/8azvOmvwa2BtPXSK7Q1/?=
 =?us-ascii?Q?ZKuZHK6JcKwyiniw2OJEui2JJY0Wu4zPKIiqAiKMIQC3moJ4Ok1Xr4jjWRG3?=
 =?us-ascii?Q?G7EXbtrYmuGeGEzqwuGJ6Nej6cVYhZ8dvWsZOXE868HGx8RsYhoWqrbJ+1zy?=
 =?us-ascii?Q?qLz196fvBbkdQVFRWhndvp0Kg1VSNyw4gVhiu4yxQpSitvzq52E/s/KMwVCu?=
 =?us-ascii?Q?NOKVo79n30LFTdpH2eJ805D0pTTozL0F9+Rt4+//vJ44EYaYM1zZ+nQ2e30H?=
 =?us-ascii?Q?a86+v45oyfeLMHTk7eSjCo/tqN8/8QgzuA4j+xs6n6M7174uNYKy5WsyX3P0?=
 =?us-ascii?Q?FpzTXFrtjB4U6n7igbXkB9xRWwUHrAq81srR2wg2cijXRnOvILrhmauYP5Y8?=
 =?us-ascii?Q?qG9jdZlfh2SnIjEt7MJMugDhvCYFQNG+lHWY7a3RgCI3MOvEb4NVujgMkG1U?=
 =?us-ascii?Q?jCLwOGiDKQqodG5FlLPNgrh5De+m5iJ28Qmzop2+kX5ID2mg7VNVs8sBvz22?=
 =?us-ascii?Q?9JrioWKIYj6I3fLCdLGvXugW6XB8fYTeviA+/f3V30Gu+/IsVQP83eIvKFHY?=
 =?us-ascii?Q?M5YoGHYg60uf5f8oGOUHibrx427WqgVH/KWJehbpv/NF2OxBzaHu2DUpQ8Cu?=
 =?us-ascii?Q?Trvr9xfXwhLiC3Xf0CZXHIM=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4453172d-1062-40a4-51ed-08d9ed0691c8
X-MS-Exchange-CrossTenant-AuthSource: SL2PR06MB3082.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2022 02:31:12.3078
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: R/uacg7VVuyGzwc6yT/Jpc+2vpb5IQkWzzzmvRWJ3i/mySH8q4yB1L+ZwI8D+kW90tZHy4eG/bm1/t4R1NkkIA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PU1PR06MB2326

From: Wang Qing <wangqing@vivo.com>

It is better to use time_xxx() directly instead of jiffies judgment
for understanding.

Signed-off-by: Wang Qing <wangqing@vivo.com>
---
 drivers/block/xen-blkback/blkback.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/block/xen-blkback/blkback.c b/drivers/block/xen-blkback/blkback.c
index d1e2646..aecc1f4
--- a/drivers/block/xen-blkback/blkback.c
+++ b/drivers/block/xen-blkback/blkback.c
@@ -42,6 +42,7 @@
 #include <linux/delay.h>
 #include <linux/freezer.h>
 #include <linux/bitmap.h>
+#include <linux/jiffies.h>
 
 #include <xen/events.h>
 #include <xen/page.h>
@@ -134,8 +135,8 @@ module_param(log_stats, int, 0644);
 
 static inline bool persistent_gnt_timeout(struct persistent_gnt *persistent_gnt)
 {
-	return pgrant_timeout && (jiffies - persistent_gnt->last_used >=
-			HZ * pgrant_timeout);
+	return pgrant_timeout && time_is_before_eq_jiffies(
+			persistent_gnt->last_used + HZ * pgrant_timeout);
 }
 
 #define vaddr(page) ((unsigned long)pfn_to_kaddr(page_to_pfn(page)))
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Fri Feb 11 02:31:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 02:31:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270025.464213 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nILib-0004kP-Fh; Fri, 11 Feb 2022 02:31:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270025.464213; Fri, 11 Feb 2022 02:31:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nILib-0004kI-Bs; Fri, 11 Feb 2022 02:31:29 +0000
Received: by outflank-mailman (input) for mailman id 270025;
 Fri, 11 Feb 2022 02:31:28 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=+l4G=S2=vivo.com=wangqing@srs-se1.protection.inumbo.net>)
 id 1nILia-00046f-4L
 for xen-devel@lists.xenproject.org; Fri, 11 Feb 2022 02:31:28 +0000
Received: from APC01-PSA-obe.outbound.protection.outlook.com
 (mail-psaapc01on20707.outbound.protection.outlook.com
 [2a01:111:f400:feae::707])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b4e31387-8ae2-11ec-8f75-fffcc8bd4f1a;
 Fri, 11 Feb 2022 03:31:27 +0100 (CET)
Received: from SL2PR06MB3082.apcprd06.prod.outlook.com (2603:1096:100:37::17)
 by PU1PR06MB2326.apcprd06.prod.outlook.com (2603:1096:803:39::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.17; Fri, 11 Feb
 2022 02:31:21 +0000
Received: from SL2PR06MB3082.apcprd06.prod.outlook.com
 ([fe80::80b4:e787:47a9:41bb]) by SL2PR06MB3082.apcprd06.prod.outlook.com
 ([fe80::80b4:e787:47a9:41bb%4]) with mapi id 15.20.4975.014; Fri, 11 Feb 2022
 02:31:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b4e31387-8ae2-11ec-8f75-fffcc8bd4f1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=hYaNSdFot0WjQEFauAxaxF7LZMAqV0LJMaBNOTZvAgVThCx3V3tVVkxNQ3QAoV8ylW8bJhqipq105DNTzkZEL3bJIYgyoXPyX41UvylIzSl3jPdF4HjC17l1R8XL0nJvybMkKAcgIeUW0EhbbG/zXYQmRiEGj+V8HYnXuZMmuspZ43HrnTD/jrCmlf1Pbp22VtIb6bnnm4s9wqsb2yXXfQnMK0fxgGRLlmfgsidCl29ECxoyiFzTGE6AdgJN7QY5LT34kcer0KAbG1bK6agXSoFiZC1Ma1F+IKW9BBajDbDs7akIwZSTi4ecxXB22kJszWuh7mFvpSKlwdLFE2D9pA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Tu5+LN5qA0ySjgXs2NbBDr3TFxqioxt/13v16/cZ4jU=;
 b=P+WSgNNqf6CMi9G4UmRd12mMtvjq5KTDtvpzNqq7l4GbBJCMoUlPmDL6o2NIf5zBd9PkkYQXdapyivKOR3tVhDQGqpeajeZt2v2/Qu0B0B0hDX0PxpEdu7P9Mb7PltkS4aZy3s5LNmIz7P2cVnpKH0xwcH8KOt/O3PYrYIb0ZOh1alZ6h97RTYMZPzdZvdN/zF/+x6oHmDrmnidcf1DjZuVhobjxnubw6kCRvVADdvT+hqqLsKdJR33XUVwy/qyAOkIiIZtZGrrXYEQQHaGm8w0c2LodYDreTEf780oOtq3gNjksapLtSILa+hFA0D0RW2okVqMeyL2AkSBvcZ39/w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo0.onmicrosoft.com;
 s=selector2-vivo0-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Tu5+LN5qA0ySjgXs2NbBDr3TFxqioxt/13v16/cZ4jU=;
 b=SP+54FHc3BzIEa1Lk/wWwAoPfasJWtOsVsJmIkX4CENsCVeXHnSsYk6rE5XlwXGj8ajYAPx3PCMkk8exhtDNePt0xBEaa0WCACvRZwy9WjWOecox30jG0IkJV6OeHH2GfBRAYnK/+XRgttWj8Eyj/RQX6CSVc6MxtMO+KW9tV+0=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=vivo.com;
From: Qing Wang <wangqing@vivo.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Jens Axboe <axboe@kernel.dk>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel@ffwll.ch>,
	Alex Deucher <alexander.deucher@amd.com>,
	=?UTF-8?q?Christian=20K=C3=B6nig?= <christian.koenig@amd.com>,
	"Pan, Xinhui" <Xinhui.Pan@amd.com>,
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Alasdair Kergon <agk@redhat.com>,
	Mike Snitzer <snitzer@redhat.com>,
	dm-devel@redhat.com,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Hans Verkuil <hverkuil@xs4all.nl>,
	xen-devel@lists.xenproject.org,
	linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-clk@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-input@vger.kernel.org,
	linux-media@vger.kernel.org
Cc: Wang Qing <wangqing@vivo.com>
Subject: [PATCH V2 2/13] clk: mvebu: use time_is_before_eq_jiffies() instead of jiffies judgment
Date: Thu, 10 Feb 2022 18:30:25 -0800
Message-Id: <1644546640-23283-3-git-send-email-wangqing@vivo.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1644546640-23283-1-git-send-email-wangqing@vivo.com>
References: <1644546640-23283-1-git-send-email-wangqing@vivo.com>
Content-Type: text/plain
X-ClientProxiedBy: HK2PR02CA0178.apcprd02.prod.outlook.com
 (2603:1096:201:21::14) To SL2PR06MB3082.apcprd06.prod.outlook.com
 (2603:1096:100:37::17)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 54f17a6e-fe93-4639-c032-08d9ed06975e
X-MS-TrafficTypeDiagnostic: PU1PR06MB2326:EE_
X-Microsoft-Antispam-PRVS:
	<PU1PR06MB2326C71B3F3396DFE0CCDDF3BD309@PU1PR06MB2326.apcprd06.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6790;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Yqxj2iWIIuzZawtwdzqczDFvGCSFSic0MRN2Sf1CAFjg9Tkt8fxgnGTFe2HJnFX4Kar1GtowNhQRjpm9IFr+M5umWukIXzV2k/j6QtDDF7kU7lJUv8//Cpt/c2yjdw4yf/vh+Re/22Ux4aPtLuI+xsbDPxpx28E7ARpvvqcAxjc9VitMYrYAo2FVa5Y/eUOxzdeTEX+S1AndOk8GsUp06siDV9HGqWYtrnfP8VMQw7WWGV9hrG2U2RybmaDP4i2XZHImaMKzeJtQjqQLkJo4Qyykh9Jly5Lqi5BTSxSkVTSoOy2eBSTWnUnFJdKX3HcsqrsqhEPsZR4Lv3KW6OSUYCe0rl4jeUXzBVO3Gl1zbo7QieZEHMRBZvUu/xbcmuk4ouGKiwzDHumQ6zlSA3VEefE6trY+JiaxCcbwnizpgC1axElAFEldePYE1u2fPqawiNDlT/DZCJENGsUovimfHdB3ywzX5lF8qz1S7MWTEz1xleNSAsvzWvcNJXehKZnHMW+DBJrOg+friLegy1el0p0vXIxJvCIwam4AS5ye5G8DnAccCyhqKoT0XbQdEzw8YHZBslBXHHOltVgW6B1vd4E0ZqusU0FqcS6MbV0MhvCD9ehMRqUDzjKdS5Cjuaajj9rY2zNqgb/VV3dVFYwxqEKy/R0YJOtJcbUV1ffvQ7e7xmpYoIftASyuoTo4JrsDKkISBVnfWP3fVQ4aO0fsr2aBpJwvQZn7SjJWpSzlRhLa07VmpmWgVOa9XKLTlA4z
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SL2PR06MB3082.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6486002)(316002)(508600001)(110136005)(2616005)(52116002)(86362001)(6506007)(6512007)(186003)(26005)(2906002)(36756003)(66476007)(66556008)(66946007)(921005)(8936002)(7416002)(5660300002)(7406005)(4326008)(83380400001)(38350700002)(38100700002)(8676002)(107886003)(21314003);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?EPj7tTLWJhAnjd+8vEpnCLOQzaZHf/ldw+3lsmz1AF3Fva5OW0s7lere35Sn?=
 =?us-ascii?Q?ZMOgw1FMLE5Lmxu3jCbRZbbJWvm6bA49IC0Ovbb1OnlJemmQEr+bFacWNMWD?=
 =?us-ascii?Q?Va3OFIhZQIgjVgjJP/xRUdJLicQN0Mad9GjQRURhZGer5+ZPJXczWo+GeZ3s?=
 =?us-ascii?Q?iUaxQ1lmWlVIMDwGXFWEJfTQvI5ZRZP6ksty6+l0ydTzHE/Zr5Ggfo6H4TeU?=
 =?us-ascii?Q?RudUrJWvaoWYorQ71h6GZyx4YhM3NkBcnGwNhOKSgLI54p5j8EnWgzwV29OB?=
 =?us-ascii?Q?5JDjTsKgqajNKzAYLL8/WaYNLa85oINkIIbbdSChUrisTDXbSbeeGzqd9AMb?=
 =?us-ascii?Q?AxIigRA4CGawimMxNgmX76GCDoIOu1GLX6cyyjPI0kCEc8H7yISe/3mB9U0T?=
 =?us-ascii?Q?AGIJOi3KDOTYR8F7XeXALtdUF+1Pwv4+buqIsQC0L1LvEJfXA3q3ephs6As/?=
 =?us-ascii?Q?nmXP0Vm4ioAiBdQN/Nm73ROW0FPNtqepqzKVMb+db8UlRdNXm6Mv8q5znjAB?=
 =?us-ascii?Q?3cL+r40iGl+q35H3ZrpAveydnySB8bAV7ZWijgDP3qKEdyXP+OxQfR2a++B9?=
 =?us-ascii?Q?80W27Fr7BNRt0ZrPuXFUU3uOBvUXbCtWndZFS2auUVeyzXgiv65vmQ7d+Hol?=
 =?us-ascii?Q?4aU8Qq69SojHQ7meBT7o9JgGPb9Du9A3WIjUYVyMhwaIAl4KWabe2yyon2mY?=
 =?us-ascii?Q?tNBAX3SOVeXENRyJQv+006yfnkyPYgLVdxuNhZFNnM97/wgjvnsKX6kBDitc?=
 =?us-ascii?Q?HiqMec+w/FWSAn5K9llVLbM5m0rTS8l3GfeBDr4x0/1setC8ZVVOkqYWWrAl?=
 =?us-ascii?Q?/BINkH+wfO55iawUDQRJqglD7czL79mfImS6Dxd8jdxVr9C3iHWnLwo3JQVC?=
 =?us-ascii?Q?bxloKb3tUGsTv8YG92ci7pOF9FaFcpBfmC9OniqngUtf4/dKwrO5Bt7jOevh?=
 =?us-ascii?Q?hrVGmcpemlNks4EyFVo2HPxZLSnDi+7BekXwLQRIEvOVKvSXmuR1KWMi1FLs?=
 =?us-ascii?Q?+yOy7bZe+a9oNsOrw55+F86vlxipIoWUUdjoFQ+RhY1Rg7uGyRKhCe4aOXLz?=
 =?us-ascii?Q?8+G0wWvrjLvjMbapL/Y4CqNqmo2S1R+3UegGhAfetpqpNYEbqtlhrvGSGOY+?=
 =?us-ascii?Q?v7gLGmLIcMHVuGouCr7Ti8nFTx71A9QYDVqSWVgUI0y6t4Qmg9cH1k3IZRpt?=
 =?us-ascii?Q?SNFo857/WQHjaYBzjshbRuYnioTsySGjBF3jSlet1fKrE+gTvQ5KdEyGjwd5?=
 =?us-ascii?Q?AwA9+rvBBNQwBoRWAb68ln7pXoBTzaLU/YkFW+me5Claj0MDAwaHGZMd5Pcf?=
 =?us-ascii?Q?XVY6X195ZHQQWfVCME+ehx7djb890wXfiQstqNpRKrhztkgupPjeda0N1V/A?=
 =?us-ascii?Q?/hT/Ga8c1dx0hOS865ftnA4dYvKEGZodAB+z90jH/LCPw9yXfgqZswjRJs3t?=
 =?us-ascii?Q?4NHPpjm/8i69Y16vaOdhED4xQVLHhQkMDAS2C0V3pW5no3mjneytO8Fz4IR/?=
 =?us-ascii?Q?rR3jLp9AwYZe863eMYhzZfpgbi3Qqb/r/shW1JWWhLcC1huJq4bFD53+8BYb?=
 =?us-ascii?Q?0v34Aukej253CX40zwnXz6PJO7EXeWVIBJJxNvFrZZt0u0mguAxCR6uSdjGT?=
 =?us-ascii?Q?LktZppNmqcNY60VH/nfFwUA=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 54f17a6e-fe93-4639-c032-08d9ed06975e
X-MS-Exchange-CrossTenant-AuthSource: SL2PR06MB3082.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2022 02:31:21.7447
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: o5ShcZbiCtmLryyUEfbOWjk1acGLL5W9vqCQ+h3lPfIcXbBklSckOaIfy/WuPiY3vyh30C7ya9v6MlU7BMzfeQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PU1PR06MB2326

From: Wang Qing <wangqing@vivo.com>

It is better use time_xxx() directly instead of jiffies judgment
for understanding.

Signed-off-by: Wang Qing <wangqing@vivo.com>
---
 drivers/clk/mvebu/armada-37xx-periph.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/clk/mvebu/armada-37xx-periph.c b/drivers/clk/mvebu/armada-37xx-periph.c
index 32ac6b6..14d73f8
--- a/drivers/clk/mvebu/armada-37xx-periph.c
+++ b/drivers/clk/mvebu/armada-37xx-periph.c
@@ -25,6 +25,7 @@
 #include <linux/platform_device.h>
 #include <linux/regmap.h>
 #include <linux/slab.h>
+#include <linux/jiffies.h>
 
 #define TBG_SEL		0x0
 #define DIV_SEL0	0x4
@@ -541,7 +542,7 @@ static void clk_pm_cpu_set_rate_wa(struct clk_pm_cpu *pm_cpu,
 	 * We are going to L0 with rate >= 1GHz. Check whether we have been at
 	 * L1 for long enough time. If not, go to L1 for 20ms.
 	 */
-	if (pm_cpu->l1_expiration && jiffies >= pm_cpu->l1_expiration)
+	if (pm_cpu->l1_expiration && time_is_before_eq_jiffies(pm_cpu->l1_expiration))
 		goto invalidate_l1_exp;
 
 	regmap_update_bits(base, ARMADA_37XX_NB_CPU_LOAD,
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Fri Feb 11 02:31:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 02:31:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270031.464224 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nILin-0005Rr-QS; Fri, 11 Feb 2022 02:31:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270031.464224; Fri, 11 Feb 2022 02:31:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nILin-0005Rc-Ld; Fri, 11 Feb 2022 02:31:41 +0000
Received: by outflank-mailman (input) for mailman id 270031;
 Fri, 11 Feb 2022 02:31:39 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=+l4G=S2=vivo.com=wangqing@srs-se1.protection.inumbo.net>)
 id 1nILil-0005DN-Fn
 for xen-devel@lists.xenproject.org; Fri, 11 Feb 2022 02:31:39 +0000
Received: from APC01-PSA-obe.outbound.protection.outlook.com
 (mail-psaapc01on20704.outbound.protection.outlook.com
 [2a01:111:f400:feae::704])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id bb462c6d-8ae2-11ec-8eb8-a37418f5ba1a;
 Fri, 11 Feb 2022 03:31:37 +0100 (CET)
Received: from SL2PR06MB3082.apcprd06.prod.outlook.com (2603:1096:100:37::17)
 by TY2PR06MB2895.apcprd06.prod.outlook.com (2603:1096:404:31::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.17; Fri, 11 Feb
 2022 02:31:32 +0000
Received: from SL2PR06MB3082.apcprd06.prod.outlook.com
 ([fe80::80b4:e787:47a9:41bb]) by SL2PR06MB3082.apcprd06.prod.outlook.com
 ([fe80::80b4:e787:47a9:41bb%4]) with mapi id 15.20.4975.014; Fri, 11 Feb 2022
 02:31:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bb462c6d-8ae2-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=JjoDUp+6IAt3TmNvWmEvU5i5dq1hw55MnOdxjOoGxLeSsL21K9GC+RjIAYuDogD9hyCMSmAXDXIBuUTgiY6APGygabA4afG2YAeGiydwOrOjePujemxSlrOibEzMhOSgzzHS5Re+fNfW25ev7KW8zLgGAiWP/g+IqJQFb4bErNAYMXAyeph6PP8/0kbBdSQDJmm/Ssrx3IX27mgvrMQexYQ/cs+dbLdy8mkBfldy17bKRkYbCf7gjz2IulcKS3ibjB6qdW15u6FQURLToSTT623qO3hw/SxxCMfN9uojGyu0UitKm/Eepm77bNJrzZa9opUBd+7tSWgGE80RSHDrtw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=qXuFDjruBaKh8CiDorxYd0K6ecHc6UY3H0229Ft1TgU=;
 b=J7gi71L1mH/Ktf3wkuLBFxRRtLhg+rl2PfYhyKGblXrUKQYtBmlG/M6bHM0/+Ec4uYNgeyvuDF6NgtCfYwiB0H5sKRtJubcYcDFCTt3fvSzRaZ3JirK15OnKvnaYiAUulBSav0mF9Akg6mnl9g0OKIwu0VzZ7whvEUVnT01JtsHfdDExhAcqLiwMyqGrWcWo0x9ocnTk2zUldBx8iudIcvrBc9wkuowq52zHt7mmhjLK4ksMOVV2tVtehtsEIXfKI1Z6Ib5/Yc2hOXRxBVJ6cvod9w2JHXwhol8qO5NwnuPLqc45CBlDBiOC3ujRLT+FO0TPzujJcYhlMhO9bSWfQg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo0.onmicrosoft.com;
 s=selector2-vivo0-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=qXuFDjruBaKh8CiDorxYd0K6ecHc6UY3H0229Ft1TgU=;
 b=Rc6ZjedPMda0v0UqZ5HITet1gmi5Ih1I8cJCwPlCg0Bo+7IxJ5ygEf9U/IO8koI7VFPRltOPrRIFigZJPp0n6gbeHfbCaWxsJplrUnXqFE+GM1QAvjilZQkT835M92uSEP94vMr1GCHeRRC6vyzNJeUAryGfjIKaLFlA6TSkuWk=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=vivo.com;
From: Qing Wang <wangqing@vivo.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Jens Axboe <axboe@kernel.dk>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel@ffwll.ch>,
	Alex Deucher <alexander.deucher@amd.com>,
	=?UTF-8?q?Christian=20K=C3=B6nig?= <christian.koenig@amd.com>,
	"Pan, Xinhui" <Xinhui.Pan@amd.com>,
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Alasdair Kergon <agk@redhat.com>,
	Mike Snitzer <snitzer@redhat.com>,
	dm-devel@redhat.com,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Hans Verkuil <hverkuil@xs4all.nl>,
	xen-devel@lists.xenproject.org,
	linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-clk@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-input@vger.kernel.org,
	linux-media@vger.kernel.org
Cc: Wang Qing <wangqing@vivo.com>
Subject: [PATCH V2 3/13] gpu: drm: i915: use time_is_after_jiffies() instead of jiffies judgment
Date: Thu, 10 Feb 2022 18:30:26 -0800
Message-Id: <1644546640-23283-4-git-send-email-wangqing@vivo.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1644546640-23283-1-git-send-email-wangqing@vivo.com>
References: <1644546640-23283-1-git-send-email-wangqing@vivo.com>
Content-Type: text/plain
X-ClientProxiedBy: HK2PR02CA0178.apcprd02.prod.outlook.com
 (2603:1096:201:21::14) To SL2PR06MB3082.apcprd06.prod.outlook.com
 (2603:1096:100:37::17)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: fe8ac258-883d-4bb5-0ed5-08d9ed069dbb
X-MS-TrafficTypeDiagnostic: TY2PR06MB2895:EE_
X-Microsoft-Antispam-PRVS:
	<TY2PR06MB2895D78B3ED8D2EFC148E95FBD309@TY2PR06MB2895.apcprd06.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3826;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	zo/R/bhk4YPH5LccKiv+TX+wqX7W7/D25syY6RvkcP1xlIoeF4bHvdEVY7ZVn5LEZhd6FFobafjLvqiGAlNDktxB9/L8f6gQJMQFWwlhH9VXNBZQ7s2DIBDExQkvb7SUY5X8oqPNGlH85qRmigyEWfKVGchpeoKXRGww4S4OyxcTAZwwgRnO+JA7xLmQFWA2HqA2SDtwO39P1InflK0McUXYyFFDjZ7RdjgOvNkMfsqdQZ8Da/Bd8CJDtH+xS09saVOq2GB1R0mtTJ0Y/0JHhZkYgLCpRhPyZXVE7zhPT66CBo0xJrkWHwQCVqsgqnKnDMATM7pBHAedgfouT073upYp8bgoH7dUhk+QfSQKnKmgOTuiPY93JBWZXfSUIDr0p/+Lk28y5Lai+DpaHk7nLhGaJywUbTOC+zsLVOfbZXiYhqNnMvlON1uxhYNAYTGvPLlsf5PSNx018TCNjmhjzMCLC2VBLlzcVN/rKseRQ4ATIoICfFWkrI06dywiFPOiBQ9v12so6RcQZyKiKcGalse59lXl6sdjDKc+NHaQhDeNlnRfxXa4xcj5x+v0Z0MZ1fO7Ao07sQHLiZcvUSomnUnxhSb5ibkcDZmkLgZ1n39ySrpzCVjAmA0ni1wEH3AN+Vy8mo6uL89U4TU/84HGXZ0SwiTX1vE67/TCM/eROcUAiEpTzApJLqfXFwXmQNzd4fw4z3U0jlxiMNC186Zd69djOYJZZmpv7dBNR3sz3SWI1aBpyvqRsWawxpL0wVuA
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SL2PR06MB3082.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38100700002)(2906002)(316002)(110136005)(86362001)(6486002)(38350700002)(6506007)(6666004)(26005)(186003)(2616005)(6512007)(5660300002)(8676002)(4744005)(7406005)(508600001)(36756003)(4326008)(8936002)(83380400001)(107886003)(921005)(52116002)(66556008)(66476007)(7416002)(66946007)(21314003);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?e/bIM8AuiT9udRoKnStelhbmCbuYE+e2WZTAJGisC5tRuT29x7b+a0DWP4bv?=
 =?us-ascii?Q?YNwl3iAlOCwnfti139KrGxzw4sreNnnL0mT5q+1lDX2HmmzHaW2wGv/K8ldU?=
 =?us-ascii?Q?eNic8Z55b/irrrUobHNcyFrEqMAPskhq+YJgx9PUkvBlM/r/RlYzjYaRDZQE?=
 =?us-ascii?Q?WwM5j/75QHJTu/UfSfn61Erq2ymiyAl7DAxUjNASs96TpUVjGynmM3POjclA?=
 =?us-ascii?Q?fDZDIMm6ueczPiQlBuUXaxDenwladTdwRKQsDEHe0Uhm5Rp+DPDDmbqxPuO2?=
 =?us-ascii?Q?UUqkBOvBEXqmjdRcAcezDkOYB55xcDFEENEPy2v+zCuJGPf2EIjZLl175ie+?=
 =?us-ascii?Q?uRQdzaBCP3tHfXAE3hjcF9F2rAFoX+alnmmliArjm/C62U/IEVPzsmN40ziV?=
 =?us-ascii?Q?ZAFuLbYqLuS6iNRMoVfztTpkysd8eUBNRwjKvAuznPytDtyIzZvfiRD4pceY?=
 =?us-ascii?Q?tnPH4rTEggnH/OwJJjHhUcOl+Sot3nw881tNEGuP4E08cDYbDdaJ1aj2xMHI?=
 =?us-ascii?Q?6sx1/3DiBInsR68NAI4DSE8LYLeKZ1sorcpBqH9jyF4+8nGhBA0sE7cluNDd?=
 =?us-ascii?Q?Wto8qMDdkJ5KScuN50r+aSJbob75H4wz3S6IJP7oEERyLHWYNygaS3PFKF6F?=
 =?us-ascii?Q?S9RJAGy5/n6GO56G7jpUXdX8NdTOoCTjsfH7IAXfFSXvxgACjDNByF8aPCyU?=
 =?us-ascii?Q?Q+9xFJzYpIS7tiQohPQId38tFWr3FShtbVfp06axt1Q2lp8r38fCeOt5pkO+?=
 =?us-ascii?Q?TFxs/Foyd8C7kIdi9xbgkzoc9Wo4mxrCyPDf03iCDgtpUPPg5wf/9t7UlHXH?=
 =?us-ascii?Q?aNwVb3RSaZqvpvMmfrA+giyGVTTDbREgcKjSQCoNoDtme1o1mbOfuaqV4veO?=
 =?us-ascii?Q?2P1QPYLOfunhfg+F7HfcWQHVL5Py7CVMmFIvoe0iVFKScI6BMLbcJbKza/qb?=
 =?us-ascii?Q?RWQz7tIE1DpTnxoIB+CaMEQJNgWuJNYpW/mbkYSxY1L8UqwUsBkptqQz3m0o?=
 =?us-ascii?Q?NdLh8YrzS1H4onbN8Pc+HZSwLjBns2vblomcw2Ux+7kDf24jtvn238CWythc?=
 =?us-ascii?Q?mJgTNh+VRF2J3C7Rk+Oiwu12rMuIH6bZUJOL0lmKs0n3vvRMmSbH+jMwIFUN?=
 =?us-ascii?Q?MMsNrZOr3SZIPyRry3k4xtIlFQsqHVg3hGtnM3vitS2J3mEDDvniGut+4Hm+?=
 =?us-ascii?Q?nDVaUOUmUGMo4/Ut7uYjooWHXyy3VlAO/xqEj+DJ3UNv3WIMwFKFiux9MteB?=
 =?us-ascii?Q?UNvMvc+0ylsVT5bJ9cIU8vL7JdQni3fU5T3dNNMaR0DWizPZ7uXoC8MG/dE4?=
 =?us-ascii?Q?pad+RnUI8StFM3uftnhqN+WzD0cFnMcIPmCQNH1YhcP15+Y9BiPAuaqDhsDm?=
 =?us-ascii?Q?aibuilsasq3xsDmuQMyfvdqnAyx1D0e8jw3p9/dP0ht4dovmlxCd5Xr6xYPW?=
 =?us-ascii?Q?W/8s/DQwX1Xhr5Dk7yncPNsEOPhOgAsh+FcTOV8RsfipLe8I5/hVQk18+Lks?=
 =?us-ascii?Q?jIkuAsZ9XOa9IlO1oLqnY5WTPZr3kRSQWaIDT2lp/paOfP/Bu/q5NE/qyfrj?=
 =?us-ascii?Q?s+uu34nWNAT5cxP7I2SPtkDtrj592myGYuA12vkr/x6NrrLK0+WH4ip9tSJk?=
 =?us-ascii?Q?ggSi3sULiaAT6wd4HiO7Uvw=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fe8ac258-883d-4bb5-0ed5-08d9ed069dbb
X-MS-Exchange-CrossTenant-AuthSource: SL2PR06MB3082.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2022 02:31:32.4316
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: v/oH9WScPdLif6Pl7r7BCJBGenT1qn0YKCRUYBNcVPrn3O6oBRxTzJbBkRtJgninQGAvI9WToS7m73nvAX5qyw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY2PR06MB2895

From: Wang Qing <wangqing@vivo.com>

It is better use time_xxx() directly instead of jiffies judgment
for understanding.

Signed-off-by: Wang Qing <wangqing@vivo.com>
---
 drivers/gpu/drm/i915/gt/intel_gt_buffer_pool.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/gt/intel_gt_buffer_pool.c b/drivers/gpu/drm/i915/gt/intel_gt_buffer_pool.c
index 9db3dcb..b289abb
--- a/drivers/gpu/drm/i915/gt/intel_gt_buffer_pool.c
+++ b/drivers/gpu/drm/i915/gt/intel_gt_buffer_pool.c
@@ -56,7 +56,7 @@ static bool pool_free_older_than(struct intel_gt_buffer_pool *pool, long keep)
 				node = list_entry(pos, typeof(*node), link);
 
 				age = READ_ONCE(node->age);
-				if (!age || jiffies - age < keep)
+				if (!age || time_is_after_jiffies(age + keep))
 					break;
 
 				/* Check we are the first to claim this node */
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Fri Feb 11 02:31:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 02:31:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270037.464235 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nILiv-0005wQ-8J; Fri, 11 Feb 2022 02:31:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270037.464235; Fri, 11 Feb 2022 02:31:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nILiv-0005wJ-51; Fri, 11 Feb 2022 02:31:49 +0000
Received: by outflank-mailman (input) for mailman id 270037;
 Fri, 11 Feb 2022 02:31:47 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=+l4G=S2=vivo.com=wangqing@srs-se1.protection.inumbo.net>)
 id 1nILit-00046f-KD
 for xen-devel@lists.xenproject.org; Fri, 11 Feb 2022 02:31:47 +0000
Received: from APC01-PSA-obe.outbound.protection.outlook.com
 (mail-psaapc01on20710.outbound.protection.outlook.com
 [2a01:111:f400:feae::710])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c0d8adb4-8ae2-11ec-8f75-fffcc8bd4f1a;
 Fri, 11 Feb 2022 03:31:46 +0100 (CET)
Received: from SL2PR06MB3082.apcprd06.prod.outlook.com (2603:1096:100:37::17)
 by TY2PR06MB2895.apcprd06.prod.outlook.com (2603:1096:404:31::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.17; Fri, 11 Feb
 2022 02:31:42 +0000
Received: from SL2PR06MB3082.apcprd06.prod.outlook.com
 ([fe80::80b4:e787:47a9:41bb]) by SL2PR06MB3082.apcprd06.prod.outlook.com
 ([fe80::80b4:e787:47a9:41bb%4]) with mapi id 15.20.4975.014; Fri, 11 Feb 2022
 02:31:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c0d8adb4-8ae2-11ec-8f75-fffcc8bd4f1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cZn5jB8bpXWYIu8Ys0YSq++phxSSzePZasN22zQCRicPCEJXkLPPO9qO9X6Dqp1voFq0Iy8pvBqEHqDrG1j9rC4YFoXn67LhkYdIBfONDYklFnS0hHU76kL2mv1POSwUr3jluubkwyKedjGuwFgpGJoczSHaz7ZDlruryJKV+HxcBo/3+aIFQRR7tRtEwITfsZQ1qf9/KNM3lfdiqC9HG66WqaaczkbVlEvxUXI31ftco08wBi4bEHiMXoYijCPV/Oami1TtVcWAK0qHALCNd6m8vHReSsf+W8eETLPGWEfUY+N6SSK5RdKAePjporPeoEmXZIevCcS2u9RiifPtgA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=HkZqYD9sR0gZg/Wdul/591yVuUFVaaLLrwE9a3DsPzk=;
 b=DeZgu8a+tv54Mi7GPTecdWummtTqDOIKtarcnZmMCuyWvcl1Im/IaJmVrSXYLeQzkkuxVFIpLrp8D1BmJUP7r/LFLIp/D8jNp+v9kLLhDwRMiEwJQiQidkwZAe9kssGosxtpi+G7oj2/ZMgGdLiFKaodYkfwBMt+6L1x8jQ8GouqA6OyIZVmOPgToVAh0Pp4fMw+WWKUzGjY7MwYypGv6BvmB8bGxjJueb0dP3i/BIubJjAODcU+m/UfB2vNs7DNhmRk+tOPEv7rw3df2BixcLdEnS6LVF9OkLucm2CxtQSqq2awChST/hU31OS5bEAerMvkg7QcO0o5PmOkP3CQZQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo0.onmicrosoft.com;
 s=selector2-vivo0-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=HkZqYD9sR0gZg/Wdul/591yVuUFVaaLLrwE9a3DsPzk=;
 b=ZKU6sMxlURdH9BQ9eGwejG3xOCDZkJmdXjoCJdVnpStpqQ4WwWrNZtlRSfFBYwVkynpX3/jBk4kKVq9+rl+6teciIynIrYxfio7d0mfeYP6WPVFeBFCgVpywlnF/F3o+uzTeDzxi03q+wBl8qCLQYWLPNpydjDJ4WJx9vsxr0a8=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=vivo.com;
From: Qing Wang <wangqing@vivo.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Jens Axboe <axboe@kernel.dk>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel@ffwll.ch>,
	Alex Deucher <alexander.deucher@amd.com>,
	=?UTF-8?q?Christian=20K=C3=B6nig?= <christian.koenig@amd.com>,
	"Pan, Xinhui" <Xinhui.Pan@amd.com>,
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Alasdair Kergon <agk@redhat.com>,
	Mike Snitzer <snitzer@redhat.com>,
	dm-devel@redhat.com,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Hans Verkuil <hverkuil@xs4all.nl>,
	xen-devel@lists.xenproject.org,
	linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-clk@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-input@vger.kernel.org,
	linux-media@vger.kernel.org
Cc: Wang Qing <wangqing@vivo.com>
Subject: [PATCH V2 4/13] gpu: drm: radeon: use time_is_before_jiffies() instead of jiffies judgment
Date: Thu, 10 Feb 2022 18:30:27 -0800
Message-Id: <1644546640-23283-5-git-send-email-wangqing@vivo.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1644546640-23283-1-git-send-email-wangqing@vivo.com>
References: <1644546640-23283-1-git-send-email-wangqing@vivo.com>
Content-Type: text/plain
X-ClientProxiedBy: HK2PR02CA0178.apcprd02.prod.outlook.com
 (2603:1096:201:21::14) To SL2PR06MB3082.apcprd06.prod.outlook.com
 (2603:1096:100:37::17)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f244d204-a61e-47eb-dbbd-08d9ed06a391
X-MS-TrafficTypeDiagnostic: TY2PR06MB2895:EE_
X-Microsoft-Antispam-PRVS:
	<TY2PR06MB28958EDF79CB6C851B84A11DBD309@TY2PR06MB2895.apcprd06.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3044;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	0AL7Nm1Aur2OluoZbKm2LgMFQkifIuWuiUxXHFoWhejTbJvi6k7rj8KTS/+UKcv9CR6iUPtxusMwWQ9VDYT1DK7PR15v0FTc1SVkI95C09hB9SFuLjb6M1S4UkgsmpySIdvKTlLUZfrPXpfQEi+d3Zi5HImFeARlfxaw6ZbtP8r1S4ryYMT+9wxtRxyB3w9j4YBLNqF2fo+aN+8NjXnpc9f60FUBx7zHJkcg02yubgKZCNOPqb7a0Rt25ypMDhMnFft7mcoYiIsOCzkUobY1ArSYfCpYilOKauip3fpaWUA71XoEWLRfLYYDK9w8LPfJYH+wMjxKL49AYDijdiRUngiDwAeQHm4U/Mk2nm4C3W+45Jwya/+ODpDL2mdkm085UafGmml6CyzhHSUW+dpQbpdaCYtkMBb06Ws2Z7LlLEINqP0XAPmYOCESh1lNhK4aRYFtpxUnn9m87isSoEfbCdzlHYe31FB8IqXBIE8RA8H+yVj9LucjeROOGOtBEDInDsVVXBBpZGz7Ba7ky3CYT7+ZbyGl03P+Rnhihf3+QV1YAFrDt7itankMwg0CHqNksbCxov3/OCLvsa5eihosLTJxa46ddrgOFcqpWev1hqrkuSTdgxviMiQgZC8dXgNEsBEHsNbtaGRWamKKPRwK0CNRRioz1Os2q/GjsjeviqNSjV1K20Q+oxNsIvH5PZW6SOXVXjjadIvIuB8bPiLjHcT1iVxOQa0247dBZYoLHzEnbsGTUoQ31frUFkkjJ+9+
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SL2PR06MB3082.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38100700002)(2906002)(316002)(110136005)(86362001)(6486002)(38350700002)(6506007)(6666004)(26005)(186003)(2616005)(6512007)(5660300002)(8676002)(4744005)(7406005)(508600001)(36756003)(4326008)(8936002)(83380400001)(107886003)(921005)(52116002)(66556008)(66476007)(7416002)(66946007)(21314003);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?alyDAJC7lf3gI2MqaeNi7+CcCL2EWScLzyYu2wnwKVvQo03qe7/EUwYM17en?=
 =?us-ascii?Q?Gc6z682h5HDKYPbkSlQODtYI44Vgi5YWHz67E4l+dZmsBtDaGOhnIjIRXXun?=
 =?us-ascii?Q?hVPDtUpo9203hsGVhRgo5YOCAeNEZvrOjHKiFgGIt2MGuu0W33nYCv6pnIo3?=
 =?us-ascii?Q?j5jXpI1ug2i2n3PASlMneavxryupDcy5HpZfut0zMN6+vOuNqv9X29zVWeuR?=
 =?us-ascii?Q?rU2vG9iLr9EmN4BH3IpYIRM44mVB8KXJK/jCUmndt9DWqJeRQHeTRXoD36Rp?=
 =?us-ascii?Q?NpJ3xoP4OgJ8hyRoPwbDowpsvBrmXiSX1onQ9zAoJpEfxlRTRxoXzatGCkul?=
 =?us-ascii?Q?2fe+S/8BQZSB4JcTiVEhp8qMlgWQTwhJZ2zrvh5Ty355V1g7bQ2udQGSg1d4?=
 =?us-ascii?Q?Mno7oqAaARd7PmTW1FelAX3ZX/5ip3smlhfkvH1rITbND1zU0b6xIASbEMtd?=
 =?us-ascii?Q?m8pQ65+w5w7QpLZIQcnYT7htSgd8uh279+io8vrlfDq0yHikPv50LFGdsOzz?=
 =?us-ascii?Q?7ViID/4szux+Im/ZAauAi3Pide47ITa3lLDHyqNR4kTS/mH4xJZnyocbMLnP?=
 =?us-ascii?Q?kqkl7+kSNp4h/qGuN2ORtX9Bb94TT5vgtXNFS7ZhennKMFby7mAcPFBgkOEi?=
 =?us-ascii?Q?pPYbzLyR5TeIDUJiISn0TjxofHxf8zlIWEHP4EGFp0W5hVZhL3x6YIiGOupG?=
 =?us-ascii?Q?+K/mFHYO45n00Ba272yTXaoHyApJZu+OCezgm1v65MH2Krw8zsHchyaMEOgs?=
 =?us-ascii?Q?UoB1YJJ+OqSB0iLx9sD2z3mJIWvMNO1FDkzfBKrQzA2Rt/f1loLDO6HG/dGF?=
 =?us-ascii?Q?JT/i2de4NxFmDrosyeRN+0zlHUAvxT7zEcYeRvu3FwHD9pXUGvpyRALwy9tT?=
 =?us-ascii?Q?tv0dzyqMc3ULthWpjjmtYc8/LDnt5w5kbiPhpZuKHNbyN+Z8KtCXuiPPFDBW?=
 =?us-ascii?Q?FKjdcnPjhhP+nEySXZ3NGLakJ18xKdzkucdUpY5AlwISoQPHG/d8KDp5tSrc?=
 =?us-ascii?Q?kqVpjEg6+Jqu45NnMbNIrcZ19P/LfPXUst9GaHdG5BAnMbHQ/SRtnuYszKXJ?=
 =?us-ascii?Q?zDxZi9i5RIEQe5bu5oJK9IFabkHZdr5Q3rLOnOoS6yQyxNqmFdU0ucMLvoDK?=
 =?us-ascii?Q?gUZ8qQKtJ+bmSmHdUPnzf9yhZNCaHLwS4jv3y74QdB7xZOf3m95Ti9gZp7r4?=
 =?us-ascii?Q?tfpEv3v9tj6rDEJAhvYtZT6ch2SEWH5ywjsp3S3s50eHyt7ALvNmv6gPDesI?=
 =?us-ascii?Q?j+vWPdjIWsk7aJvLbtUNIYWgI2ffdIxqQbrcbO6XghZ7OCHOKN+FTSpUcGfl?=
 =?us-ascii?Q?gUkyze/iS6Df3gZ2eS+0SWv743Uc9TfuqRziT2HrT+p0O30pO/fh9ycpW46f?=
 =?us-ascii?Q?rN4YLck5HIPACTDc+gu4YceTaR2joqFh4bbiYZb44Gw4/pt0kpSRXkivGYDD?=
 =?us-ascii?Q?5h8WC1zXoYlim8ffIkaFIxR7/skdHIz9zMn2CWZjLGmnmyeOlcg9MzMi/dPO?=
 =?us-ascii?Q?jCVNrsthg69WhCkulWrHInks2951S9CEZkLN9M3wfd4hMrsEtvnU5drFK3Jf?=
 =?us-ascii?Q?ks7OIB5TD4/96E5EHhRR3pZPcv3JgR1/qPnVCFGCZRXLoLY7cnDX7gj/vRYf?=
 =?us-ascii?Q?ThFnBoM0acFG/fWtfEHAgMk=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f244d204-a61e-47eb-dbbd-08d9ed06a391
X-MS-Exchange-CrossTenant-AuthSource: SL2PR06MB3082.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2022 02:31:42.2436
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: v+F6t0V4YzUrv/nbwcDfsGjFMf655h7dYH5QSRElM6mIVKFZKFoCJy+K4setluG0VnHQH0/whpKc8KVA7RVo2g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY2PR06MB2895

From: Wang Qing <wangqing@vivo.com>

It is better to use time_xxx() directly instead of jiffies judgment
for understanding.

Signed-off-by: Wang Qing <wangqing@vivo.com>
---
 drivers/gpu/drm/radeon/radeon_pm.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/radeon/radeon_pm.c b/drivers/gpu/drm/radeon/radeon_pm.c
index c67b6dd..53d536a
--- a/drivers/gpu/drm/radeon/radeon_pm.c
+++ b/drivers/gpu/drm/radeon/radeon_pm.c
@@ -25,6 +25,7 @@
 #include <linux/hwmon.h>
 #include <linux/pci.h>
 #include <linux/power_supply.h>
+#include <linux/jiffies.h>
 
 #include <drm/drm_vblank.h>
 
@@ -1899,7 +1900,7 @@ static void radeon_dynpm_idle_work_handler(struct work_struct *work)
 		 * to false since we want to wait for vbl to avoid flicker.
 		 */
 		if (rdev->pm.dynpm_planned_action != DYNPM_ACTION_NONE &&
-		    jiffies > rdev->pm.dynpm_action_timeout) {
+		    time_is_before_jiffies(rdev->pm.dynpm_action_timeout)) {
 			radeon_pm_get_dynpm_state(rdev);
 			radeon_pm_set_clocks(rdev);
 		}
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Fri Feb 11 02:32:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 02:32:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270043.464246 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nILj6-0006ea-Gr; Fri, 11 Feb 2022 02:32:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270043.464246; Fri, 11 Feb 2022 02:32:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nILj6-0006eR-DU; Fri, 11 Feb 2022 02:32:00 +0000
Received: by outflank-mailman (input) for mailman id 270043;
 Fri, 11 Feb 2022 02:31:59 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=+l4G=S2=vivo.com=wangqing@srs-se1.protection.inumbo.net>)
 id 1nILj4-00046f-U4
 for xen-devel@lists.xenproject.org; Fri, 11 Feb 2022 02:31:59 +0000
Received: from APC01-SG2-obe.outbound.protection.outlook.com
 (mail-sgaapc01on2070b.outbound.protection.outlook.com
 [2a01:111:f400:feab::70b])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c7ddfa73-8ae2-11ec-8f75-fffcc8bd4f1a;
 Fri, 11 Feb 2022 03:31:58 +0100 (CET)
Received: from SL2PR06MB3082.apcprd06.prod.outlook.com (2603:1096:100:37::17)
 by PS1PR0601MB3705.apcprd06.prod.outlook.com (2603:1096:300:80::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Fri, 11 Feb
 2022 02:31:53 +0000
Received: from SL2PR06MB3082.apcprd06.prod.outlook.com
 ([fe80::80b4:e787:47a9:41bb]) by SL2PR06MB3082.apcprd06.prod.outlook.com
 ([fe80::80b4:e787:47a9:41bb%4]) with mapi id 15.20.4975.014; Fri, 11 Feb 2022
 02:31:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c7ddfa73-8ae2-11ec-8f75-fffcc8bd4f1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=kyskZmsLwwe3yXU0vUC+lHOfL0dRzpC4TyCbqMmckF5KhF3EP9mS3F2ipzOMQBtTLghBbIV8oaluK7TmoKLAbNYvCvoyDDujMMeIrqnA5B1QKicPMk2FGOKWS1MuUgo2zR3buvo9L7tO7NAG0BZlnIcuOBWk0kPmJIDiQSBLumQJdnd/0Zfr0sdlm37SaVNwpqvB1xc3kWyrJn0EAiP7qeRODdykqTY5SNjrExCJcJn/x5Wc7lGiof8Il5pjS8U0HdgSfOt4xgiQkZ0EYhDDn9uxFzMdY9UD963ik114Zy/QIeNr+1yBvV+EFiQAAe+ebLJTIxzEl0aa4Bflw6ckgw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=1AyKPt1GvYb2+QH9UAVuYC9O8m2sX8En2sKfKVIJO08=;
 b=bsVLxekEN5UYBzvk9SC5nxWJ+NA4k+xfyOHMIlDov3O5kd3zgwdvAlvUrR3CDVuLC6mZC1YDeGjwy9S2SbCoxGXKzxmiCffG0toK1ZMcqUC18i+BGVKoEZc8T19lN91GKgErWSbr+LgArhNk3XKLzGcz6wggUYCr/TXH3DlXCPuHiiif1joa5kLwHWABVw6D8K6PIKgXVnqT4MdjDUvi9fHZdmNNMMiNtLaI7fFTKR+/hf+EZ0QuFJYHQ8ZUoMVepSqMS2VXXqkaEO7Y+kAQKTDHLWHN4VgZFo4DD1P7gBhM0GM2W0vi9Eg3c18Im1wAGH86Ie39LM/2Sx7ZVZBMQw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo0.onmicrosoft.com;
 s=selector2-vivo0-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=1AyKPt1GvYb2+QH9UAVuYC9O8m2sX8En2sKfKVIJO08=;
 b=W8VxLlpcr6wKuJKowz6iapKBV/3h1SHoUp52BqZsBv1yvnuoCuiJ2ic3GDtH7E7IcniT/PXsd9IWCVoGIiBBE5M7cKIfU07EkAdhuNLJhNRWBBFyozjwhXr4+SJ4sHL3GKDW4aRnx/sXHlRe6Y99eEH4l8vFiWclTqYBJ06TI9g=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=vivo.com;
From: Qing Wang <wangqing@vivo.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Jens Axboe <axboe@kernel.dk>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel@ffwll.ch>,
	Alex Deucher <alexander.deucher@amd.com>,
	=?UTF-8?q?Christian=20K=C3=B6nig?= <christian.koenig@amd.com>,
	"Pan, Xinhui" <Xinhui.Pan@amd.com>,
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Alasdair Kergon <agk@redhat.com>,
	Mike Snitzer <snitzer@redhat.com>,
	dm-devel@redhat.com,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Hans Verkuil <hverkuil@xs4all.nl>,
	xen-devel@lists.xenproject.org,
	linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-clk@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-input@vger.kernel.org,
	linux-media@vger.kernel.org
Cc: Wang Qing <wangqing@vivo.com>
Subject: [PATCH V2 5/13] hid: use time_is_after_jiffies() instead of jiffies judgment
Date: Thu, 10 Feb 2022 18:30:28 -0800
Message-Id: <1644546640-23283-6-git-send-email-wangqing@vivo.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1644546640-23283-1-git-send-email-wangqing@vivo.com>
References: <1644546640-23283-1-git-send-email-wangqing@vivo.com>
Content-Type: text/plain
X-ClientProxiedBy: HK2PR02CA0178.apcprd02.prod.outlook.com
 (2603:1096:201:21::14) To SL2PR06MB3082.apcprd06.prod.outlook.com
 (2603:1096:100:37::17)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 1d70cf59-bb08-44c9-d8b4-08d9ed06aa1d
X-MS-TrafficTypeDiagnostic: PS1PR0601MB3705:EE_
X-Microsoft-Antispam-PRVS:
	<PS1PR0601MB3705F1BCDE9A160C732742B7BD309@PS1PR0601MB3705.apcprd06.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2201;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	kfbibTSneam9oWVKH3DJ3QOmFnh1mxRPRDBXU5LWmu2QQPbyKOmkjNUUjHmIAV9oT+FH5R7EvNcx+TizTs0YPsdXg96FAf+MOM0q0XWfBFTqb0zMhLoqf+zH0Ulk7GqEFfxbhmPxPy06oS5nPVqv1VFFSrZ3TXJDYb/sMLZ94ev8c0c+G2/Bn7r8pzjjHr5LbeCTw21M8+fnytSNLajBvg7BpsMj/GMhL/MTyrqmtQ+H9+Om58JtZchdluGQ8PveT99QYc8D2BE5HnapXVgo7BUQYxDAm7tcmTe9M+1AassFREhfHKVOL5zi12RksfC29ozoSPf/hgFBDhiM7a/CMyB05W/U8tV+F+JnK9GBFHXvOImkabeBzWgZpVwm+P7AwTjPM24J/8Cdtfg4c4UBWbylIMjqzMJREciO8BV73AoM8folGHGIIXDe5CzWAbu0rhouhlltDpbkbezfUECpu7nQG5XGVu570OuqBGRlADPLib2pzOKzGJmH42lBSyPSqEcz8tpWDmg8pzXZNkLETWMR4dOj2aedfY6/LOT2IQr+knBwX26/Z7P2jyYHB3WqSpAfl8kXuw1cplmxseQRgj4Usv+EuKEY32jinmrVtUryMXjj/aiMeLu2DN5MgJwqCP6qhoIiKYR6R3hygd5Qe0NSTahaRaiqQT5DsEvMfBebkML+ADjUYtGKj5w7U6Zu5Jo+Eb7J/KzsLiZt/RESM0GoeKyXO5nOSYX7VgTCTg1l5eBX2YAyZkrE1XLl286L
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SL2PR06MB3082.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(186003)(2906002)(7416002)(66946007)(4744005)(316002)(36756003)(2616005)(107886003)(26005)(921005)(7406005)(110136005)(5660300002)(83380400001)(6486002)(6512007)(6506007)(66556008)(86362001)(6666004)(508600001)(4326008)(52116002)(8676002)(8936002)(66476007)(38100700002)(38350700002)(21314003);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?BBfZ+O1Kxqh21loJeQRlANfu0QekBm26HVPA7GyNiNYfAo4+Um03Vc3uJq2w?=
 =?us-ascii?Q?JJgjUFV/xR3uMWvKcFI3tTiNy/upkQ090Zy8abBi0tIs7V6ScpzGgv2UR8sj?=
 =?us-ascii?Q?YCtDKIX8nXAeGQBI191G5ARvLsxC4+Elfr3w19dfnnSZru82GZUeH3ySaveh?=
 =?us-ascii?Q?g4ZpeeVonCgHFm84185SCy+4C5pIAI7s8kLNZ4+4d/1E7ZxLt1dWtMqUu9AZ?=
 =?us-ascii?Q?fUvHd0nbVuQx3wG5XbxbFuDvtB5Uyp3riuzT29pfWHj9o++CxNUHtQj8wGnm?=
 =?us-ascii?Q?fN7vgffFbifDbWNICqUrIYx2RRljjKB6aVtnpcsvUSFdk36xOeFDjcFkX4Hg?=
 =?us-ascii?Q?W0Tfa7wAKMkt37by333t3+cq9urgxkK3Z1yqgd0f8Oii/Q8C4NhE32rcA/o+?=
 =?us-ascii?Q?IwspIUdC7W8RhDigWSnjrbbH1p7KwTVk1EZiuuB/k02l6WJI2+x6ZLYhLF+v?=
 =?us-ascii?Q?xqwFg1ZSdvdTDGQnH7XnR3Ufati+nzTrp+SNgnJdrzK5DGjOQr1INoiSkiHF?=
 =?us-ascii?Q?9qWVnKBwo3E7tOU4b5n42g2nOOzzeBJ/qapVobWALiWPzsmK9hnxzb2wq8vk?=
 =?us-ascii?Q?+53gw83z0/2QGglEllV5UBWnP77rKVB8XnAORTGcwWAhr/9jdUw33WslorzQ?=
 =?us-ascii?Q?BNL/U5+2amc2hNL0V/4MhgGDrFcQzoCZSqB871xZFrSueByvP/15adpou0MW?=
 =?us-ascii?Q?iuL+xx9xoYVHxW0CJdna2gsC8qSn+MrCQSTiV8wnDiyw379AS5u80+tnNDdc?=
 =?us-ascii?Q?wUaz0xElVWdafxDXoBduBj9f2P1RQ5cb2EmrGYZeLP8x0DYsgbc/9EH+/sPo?=
 =?us-ascii?Q?tmyFrpjAQy2O8eQskqnOFdVmIvjmfzBiFa1tO6XTX5u49+NRItYisUu88z4e?=
 =?us-ascii?Q?mUMvimxuXxD8VgL9ZaI7xnwSXrk4eaHDai0h7BXG9wJaMZ5LhgFsjjYJqm+n?=
 =?us-ascii?Q?11e6sxy0tWvxw0LYwm7xJx3lgh2jqishlwaklTMkt2EbWgn5jVgA8Qjok8SV?=
 =?us-ascii?Q?GPmEIkLb3LEHnaAqhpzz0uwH88qCk8TUnU40rz0/pC0kagWiMGGUbEHZ5pm2?=
 =?us-ascii?Q?2RIniCO1iKMlmnilOuJE+8eRhLCZaJQl26sMTUikZdcbxovBOoohFbQV/MlO?=
 =?us-ascii?Q?BJBV4mPOvBQnKyDE8kZ1t3GQ4dkohKclpgk7VlQKWnRwxV5jED6bdzjSfM5v?=
 =?us-ascii?Q?ZEX8A1xMZbbXIF/TrnoonkmQ+kfOvRUJue0PMCFoo9gCaSXN1USoaxgYPjmM?=
 =?us-ascii?Q?TLYYB3UBE1ICle3hk9qB8IkDWyhrKdws7iw2yk7wjB9rLGjxTi4igzlad+b+?=
 =?us-ascii?Q?2n4Q7ZW0d0VJ2Ztq+vQHKZCaCsxr7jEm0OiDBIxe0eqTt3Bv7m4FyMVmKWrt?=
 =?us-ascii?Q?HsORE7URlTNn6yx/R8E/yaB97QPwS9Cvmmx6f7LYEqxh8dzkgSCy8O18+xXN?=
 =?us-ascii?Q?nbdOHAhQK2vqtoTuzghVXMHztLsmHN+jvKq4WOyl0Qu9bcMYMsHmOvNNSpmf?=
 =?us-ascii?Q?T0tMrhGgQVavp6BU3RU+VZQZou95lS3L6bPIrFLiG43CbdvDLQbMm5DtN+8x?=
 =?us-ascii?Q?HCOzkPZyJsZYhuWU1gq/VtpU874+C3AAzhEvMUxqHQU0HFNNj9ksI3ISeftA?=
 =?us-ascii?Q?OrZU3fHBQYef6Wd3ZzS7Srg=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1d70cf59-bb08-44c9-d8b4-08d9ed06aa1d
X-MS-Exchange-CrossTenant-AuthSource: SL2PR06MB3082.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2022 02:31:53.2742
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7TylgQ8NLxtwkXjCtK6xwJY9XXGkueBEZNf2tBbnWictxmcg+fs+mPezSy7kFaW8Y6nxMhs/TlXtqAL4sUD76g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PS1PR0601MB3705

From: Wang Qing <wangqing@vivo.com>

It is better to use time_xxx() directly instead of jiffies judgment
for understanding.

Signed-off-by: Wang Qing <wangqing@vivo.com>
---
 drivers/hid/intel-ish-hid/ipc/ipc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hid/intel-ish-hid/ipc/ipc.c b/drivers/hid/intel-ish-hid/ipc/ipc.c
index 8ccb246..15e1423
--- a/drivers/hid/intel-ish-hid/ipc/ipc.c
+++ b/drivers/hid/intel-ish-hid/ipc/ipc.c
@@ -578,7 +578,7 @@ static void _ish_sync_fw_clock(struct ishtp_device *dev)
 	static unsigned long	prev_sync;
 	uint64_t	usec;
 
-	if (prev_sync && jiffies - prev_sync < 20 * HZ)
+	if (prev_sync && time_is_after_jiffies(prev_sync + 20 * HZ))
 		return;
 
 	prev_sync = jiffies;
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Fri Feb 11 02:32:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 02:32:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270057.464256 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nILjI-0007EM-Py; Fri, 11 Feb 2022 02:32:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270057.464256; Fri, 11 Feb 2022 02:32:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nILjI-0007ED-Mi; Fri, 11 Feb 2022 02:32:12 +0000
Received: by outflank-mailman (input) for mailman id 270057;
 Fri, 11 Feb 2022 02:32:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=+l4G=S2=vivo.com=wangqing@srs-se1.protection.inumbo.net>)
 id 1nILjG-00046f-Pd
 for xen-devel@lists.xenproject.org; Fri, 11 Feb 2022 02:32:10 +0000
Received: from APC01-PSA-obe.outbound.protection.outlook.com
 (mail-psaapc01on20705.outbound.protection.outlook.com
 [2a01:111:f400:feae::705])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ce5552cc-8ae2-11ec-8f75-fffcc8bd4f1a;
 Fri, 11 Feb 2022 03:32:10 +0100 (CET)
Received: from SL2PR06MB3082.apcprd06.prod.outlook.com (2603:1096:100:37::17)
 by TY2PR06MB2895.apcprd06.prod.outlook.com (2603:1096:404:31::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.17; Fri, 11 Feb
 2022 02:32:05 +0000
Received: from SL2PR06MB3082.apcprd06.prod.outlook.com
 ([fe80::80b4:e787:47a9:41bb]) by SL2PR06MB3082.apcprd06.prod.outlook.com
 ([fe80::80b4:e787:47a9:41bb%4]) with mapi id 15.20.4975.014; Fri, 11 Feb 2022
 02:32:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ce5552cc-8ae2-11ec-8f75-fffcc8bd4f1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=hIfy3zPFMEbsGtSoSPPqbkeOZ/dLOYRhHpUAR5suGf0g13wWkXMBPST8Fhr6n/7cQw5DqX2AdL7hqO2geNXWARmpnRgvAaRXQ/b9VHLTMT8tFEIbPQnJ+qjBY0dhfBHqH/WEA3Jujet6Vqxhxo4ASGgUua+3W2YMZgdME8yLHeHNXszr8EkJZCsegRjL4m4Rrf2hzfQJXoKAzUn2Nziou+RKBQTUIjeWmLStwmtLIoriEyWVYLjFFz+JtfaJE6Yb1fvTU3haZeC0UzG/kJdWGiXtFbCnLk34hPB/ZaevsLKWne/VXoBsxKEaF19bgjwJNc1QD8CB/XAu1TEuuXdT8Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=AJmrL/wszRwZlM8YVbrQxGpNSgXK6M6vSTblQPIFMZk=;
 b=fZLtPnmelz9hHT+SBLwremtvuxlBf/i97duKgdlLicJMapgsGYxkM7ekYio7Pqs2xqalvaWb4a4PPyY6ePuE46T+6ECgZEg7AQPNZeiW410j8/dtomsvKjD3vfQIBxHdIFYI6CvJ0HDNZHApXCu+E8yxgvBJg4q5sNHXPw8HaXSTcCff7VQA/oPNpMgyeU0YW9nTl9KFgXwKNJOKiQU98yjlcsPcKdnafBe/Q+9lGFt45RQVyvI7yLjBrl3xGWLMxNeFahRxuyFQDtpEzF4Z/lTa4P0ARmevDbfyt9Wn2JwOJ0Ncn93UcBRzHU2abDTvZSvgJCmVDFnPL8kOP+Y64A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo0.onmicrosoft.com;
 s=selector2-vivo0-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=AJmrL/wszRwZlM8YVbrQxGpNSgXK6M6vSTblQPIFMZk=;
 b=LDllR3IILBHFO0J/aZBfYXz5fNvlV220gcDU3SWKf+HU7oHuWzU/dB0FR2LJfl/dYcSy8cqB31wWUe2Mb6FEIUq7uzbzVVCpg+g3myBOJgzqZwDq2/jtLrEXi7JxOgHSh2NqwPFlxkIDBzHxIi0wn+xWvRizEAh0w+V3IgMIFtU=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=vivo.com;
From: Qing Wang <wangqing@vivo.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Jens Axboe <axboe@kernel.dk>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel@ffwll.ch>,
	Alex Deucher <alexander.deucher@amd.com>,
	=?UTF-8?q?Christian=20K=C3=B6nig?= <christian.koenig@amd.com>,
	"Pan, Xinhui" <Xinhui.Pan@amd.com>,
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Alasdair Kergon <agk@redhat.com>,
	Mike Snitzer <snitzer@redhat.com>,
	dm-devel@redhat.com,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Hans Verkuil <hverkuil@xs4all.nl>,
	xen-devel@lists.xenproject.org,
	linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-clk@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-input@vger.kernel.org,
	linux-media@vger.kernel.org
Cc: Wang Qing <wangqing@vivo.com>
Subject: [PATCH V2 6/13] input: serio: use time_is_before_jiffies() instead of jiffies judgment
Date: Thu, 10 Feb 2022 18:30:29 -0800
Message-Id: <1644546640-23283-7-git-send-email-wangqing@vivo.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1644546640-23283-1-git-send-email-wangqing@vivo.com>
References: <1644546640-23283-1-git-send-email-wangqing@vivo.com>
Content-Type: text/plain
X-ClientProxiedBy: HK2PR02CA0178.apcprd02.prod.outlook.com
 (2603:1096:201:21::14) To SL2PR06MB3082.apcprd06.prod.outlook.com
 (2603:1096:100:37::17)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d708849d-f73a-4f4d-cc35-08d9ed06b144
X-MS-TrafficTypeDiagnostic: TY2PR06MB2895:EE_
X-Microsoft-Antispam-PRVS:
	<TY2PR06MB289554482BFAB287A31191B5BD309@TY2PR06MB2895.apcprd06.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3044;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Knvn+ZoyuwtwWjb9mcX7NX4jSd5sdfPjHKvVg0RXnl4B0HLfdv7nMLFc7oEB4uoAC7nhPliMSDWanEG6pMpbUMVchrTfRPtCpo+Y9i2hsRrc25VPJsQIlYgbOHynMgwohX+gOCxM98x/hcUkKTKy6Ryyhot4nSM/0df5459+EPX+x8NZu34ETQArWLJOO3DJoFyzdyDDJijXFnKF8StSK8SDk/KX6pxA24EhE4BsT7pE8nNubWPzCoKTJZ7vOov0foDGTTu6krh/sLcMo6L6nZ6nydKlrooia830KyO7n+KfO43/q8wgsu0A+JODt2HzqOlnx941h+brnfgGknRGrExAUXDCl8qIKFU0jeXg2oIM3raNNQXDgmZPJOmeMV9EhhTFBr5mgg1YOlGcDkX2Rx3CZfKwql7KkyvR7akXzIHPo3pC+7d2N4rU1kFHPBOq+rv1FrY2/QtW3a0t65ZNCOQDeECkSq5ewxwXJiYpN0ZKgFH1KLjT7ocJcx1ye2Mjkzh1io96S0XXVoxVwnFgltmxzN3tbxnfFLn3kP0Jnh9Sv4sKlzKr13KfQgEjlD66Y8FsDfp3Xp3FqQnn+hJ4WkYB0fL0fxaXSwDlsdL/R1zm5erAtH3JjL2OMueHjzOjBFj1hDM2oTVUQ3HXfriBYbSf4BBfNyfwfOv7LhlhMppZxHs0XurFN1SuOtP7wCSnfPcNMxU25l/4naC+SDZhkRhEnwSvc6XBS+HkJgo+XK7hZZGCTdgfdd8zaO/cYRS9
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SL2PR06MB3082.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38100700002)(2906002)(316002)(110136005)(86362001)(6486002)(38350700002)(6506007)(6666004)(26005)(186003)(2616005)(6512007)(5660300002)(8676002)(7406005)(508600001)(36756003)(4326008)(8936002)(83380400001)(107886003)(921005)(52116002)(66556008)(66476007)(7416002)(66946007)(21314003);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?j1JTYbUZFwE57rs9P/bZPsIXhEWUhUwZYslxJXmoBcB0DzYfbRs71yby+bz/?=
 =?us-ascii?Q?vz75e/QAd9pa2P700yMpBDdgLxzW6+5gs4C2NReUwTJLVy/jkasgGvEJEAMo?=
 =?us-ascii?Q?ANyh3VAVxDLRWeKzNgfmUh59OQ0gG7J78o38VzqvB2TASGOVv9JmA04H3jiz?=
 =?us-ascii?Q?VATIIQjKFAWUEX2zZraRVTaLYF/Kn/KwzMw+jry1qtD4Pk3NcNq3a9h8UVqa?=
 =?us-ascii?Q?zDvMEWaV6dI+Ps0UjvurBJ0po1LIa12Dn1BruvzU4WmY8X/Q2Sur9NeUloSc?=
 =?us-ascii?Q?8ccM0l5hQfo0YztFRCut2eaB6mWaG1NKEJ3KjWSsLKJU1ksTHAptEVL+jpRp?=
 =?us-ascii?Q?Qj7+D6zg0cYdt8RfQzBKDr/sxGlyKyCaHs1vK6+Z70aP5NdTA0vFxnluiB8C?=
 =?us-ascii?Q?p3N6bDN7BqbEpAAAMj+WVfPHTtIByNjhVb+oDGgc/O4OLFVaYNrrrVHz5Zi3?=
 =?us-ascii?Q?tt5ZMkj7zIUURoHN7vpQHb3Y99X2LhgNrHZ8kbkuhPnXNZAU0Ysfw/jsRKos?=
 =?us-ascii?Q?MzLH/vn9iS3+9Jk5h0q75TeX8s/kGubhwUfMgV/S2lLcpf0UpUsYHxxtYzon?=
 =?us-ascii?Q?K0oCVegi+YetZ4v7+g+GSVsGmb+KPqjx4Mr695Kr/ltQ8+JgB8Ia+dmkVLpm?=
 =?us-ascii?Q?dq1udpl1z/U8BjmWMAcnjNrypYQrJkBH0UESuwbjcCN/nGRl+164MP1mXYSC?=
 =?us-ascii?Q?fsVevoaKz+vMKE14aCjXvtA03yJ/PZTteqsLnw66sOptNlHnVKIL9l0Fdcj+?=
 =?us-ascii?Q?jDebUhmOIBpfoOIcioevcPPSiH9jWL1swvSekt6owINn4xveOlxIl0GOQ3j3?=
 =?us-ascii?Q?Yo71yZzslNQDV5uF5+Ur/j7819SU+IkaojzQ1dJJ1+bO7f2XBNBmRiFtCytM?=
 =?us-ascii?Q?viKz23TLEqe5WYTk+T5zePcV84QL1bJ2C+xqdrSkr8Yf6OoaeZBupFAwVm4x?=
 =?us-ascii?Q?cTVHHVYUMWx2PPwExu9WPAKIM7Uh190sthnfabctRky2InIzIZAhV4Mku/Kh?=
 =?us-ascii?Q?SzHGHOKpVYOThcYCUVE8Hmk0yhWYjAf4LcHs9rDTRBw7GqMQh0dP3IL9OLY7?=
 =?us-ascii?Q?BQ6HfAy+tZk9yltgjheKpwqhga1YZWgZQPYAlpDINa27srj1yAPpMJDC8MYd?=
 =?us-ascii?Q?Uo8qF+DflfHJJQHU/+hRlXiymTJBgXWKu12JEX7xCeknq1Hm2kyhmScKRHlU?=
 =?us-ascii?Q?1vQpaDbZgMU04tH6zjPWq4ENhOO27Qv/3PHBcZXW7HhJQ7IlfO7QKTINUY8e?=
 =?us-ascii?Q?dr/J825MBIGDIxE1ZIW2/lJoP+5aYqcAj4Mn9uwCazYon5CmGekCEjPpKYzI?=
 =?us-ascii?Q?/4U+1h5LnacScpbVRhSDZOhzC/nvAredJ67lub0o0a36TEg5zvNi9tugM5q0?=
 =?us-ascii?Q?F30Zr1Xo/YHair/UowF6j/fWerUeIUQhadUX7HZz3tJuCFj3rjerGRWG6qPW?=
 =?us-ascii?Q?q2OOJcB7iltVZ9HQI5GAo4/MsgPPdvQXOtXIVeT2fLFQeQwtp9m5ixLahLkT?=
 =?us-ascii?Q?IevJsLNjsAxF07GN1agDblRVNjIofefahuoICwB6CS/Vxns6d/Yqw/ibLnrt?=
 =?us-ascii?Q?Ve0p0IZq4Hz8+TRwiysYCTaru+5OfIlnMukaKBQz5hUy12PLehFXl8E6uVFv?=
 =?us-ascii?Q?uTbGOTOaM/sLAUWkpuhcXA0=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d708849d-f73a-4f4d-cc35-08d9ed06b144
X-MS-Exchange-CrossTenant-AuthSource: SL2PR06MB3082.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2022 02:32:05.1954
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AKip6f9iqiS3IpgYMeOPaufHSDL7O8bFVrZCqIKCGXNHOnl1Y+SvZVBj97LT3qYik6/RGDYwW2+DwZ8sR60wNw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY2PR06MB2895

From: Wang Qing <wangqing@vivo.com>

It is better to use time_xxx() directly instead of jiffies judgment
for understanding.

Signed-off-by: Wang Qing <wangqing@vivo.com>
---
 drivers/input/serio/ps2-gpio.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/input/serio/ps2-gpio.c b/drivers/input/serio/ps2-gpio.c
index 8970b49..7834296
--- a/drivers/input/serio/ps2-gpio.c
+++ b/drivers/input/serio/ps2-gpio.c
@@ -136,7 +136,7 @@ static irqreturn_t ps2_gpio_irq_rx(struct ps2_gpio_data *drvdata)
 	if (old_jiffies == 0)
 		old_jiffies = jiffies;
 
-	if ((jiffies - old_jiffies) > usecs_to_jiffies(100)) {
+	if (time_is_before_jiffies(old_jiffies + usecs_to_jiffies(100))) {
 		dev_err(drvdata->dev,
 			"RX: timeout, probably we missed an interrupt\n");
 		goto err;
@@ -237,7 +237,7 @@ static irqreturn_t ps2_gpio_irq_tx(struct ps2_gpio_data *drvdata)
 	if (old_jiffies == 0)
 		old_jiffies = jiffies;
 
-	if ((jiffies - old_jiffies) > usecs_to_jiffies(100)) {
+	if (time_is_before_jiffies(old_jiffies + usecs_to_jiffies(100))) {
 		dev_err(drvdata->dev,
 			"TX: timeout, probably we missed an interrupt\n");
 		goto err;
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Fri Feb 11 02:37:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 02:37:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270075.464268 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nILnx-0008TE-LN; Fri, 11 Feb 2022 02:37:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270075.464268; Fri, 11 Feb 2022 02:37:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nILnx-0008T7-FZ; Fri, 11 Feb 2022 02:37:01 +0000
Received: by outflank-mailman (input) for mailman id 270075;
 Fri, 11 Feb 2022 02:37:00 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=+l4G=S2=vivo.com=wangqing@srs-se1.protection.inumbo.net>)
 id 1nILjh-00046f-KO
 for xen-devel@lists.xenproject.org; Fri, 11 Feb 2022 02:32:37 +0000
Received: from APC01-PSA-obe.outbound.protection.outlook.com
 (mail-psaapc01on2071b.outbound.protection.outlook.com
 [2a01:111:f400:feae::71b])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id def0af5e-8ae2-11ec-8f75-fffcc8bd4f1a;
 Fri, 11 Feb 2022 03:32:36 +0100 (CET)
Received: from SL2PR06MB3082.apcprd06.prod.outlook.com (2603:1096:100:37::17)
 by TY2PR06MB2895.apcprd06.prod.outlook.com (2603:1096:404:31::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.17; Fri, 11 Feb
 2022 02:32:33 +0000
Received: from SL2PR06MB3082.apcprd06.prod.outlook.com
 ([fe80::80b4:e787:47a9:41bb]) by SL2PR06MB3082.apcprd06.prod.outlook.com
 ([fe80::80b4:e787:47a9:41bb%4]) with mapi id 15.20.4975.014; Fri, 11 Feb 2022
 02:32:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: def0af5e-8ae2-11ec-8f75-fffcc8bd4f1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=KMY85Oezy39t4/iipe61T3TiK9LC97hCT6SulGzMiNhdI1xnMCb8giG/3xYFXvzz0xviCnVmOHs2AasWvWXuOpoBp56LyJdGlJv8LUTuDKjcQ+vXJD07SbKoNRaI+ixoamBnHSPC/nrcRgO5nKq+wL5zAJEOuZB+ocrbW2WVpGRYd3KWmhC851a0jOBxGbJj7vBjtZ1o463I3VwCZtVv+45GG3bxwyRElcLmjywZadja8L3tO5oHmAmyjoEJpKl7/nUMt0SvojuqoNXT/TvKuUbAJg0yuO/iSkF/SUmxFmUSPFPtpyoGtDUtF1TgIkqgS4c+rJ+K+nhRyIsa936KkQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=t7/9rdhQphdB3bx+s6LccgI1BFHodYWqZAZuQWlnsMM=;
 b=aI3PMlZO2JTzDQS2h/nbkoY6k2NAGLwnWrDxAG7YKHkxmMwj8l1VKbSWnpV+55dToGn8okRz2iEYJzaYzDT309yaFzBMwn2v/MCyQ7q2JK+NNPso5ocExEkI8Rh6DELzSJ3yJzmQxkMOhm0lM2k9AOqq+kSFxfygQKbm4jwAP1wZevt98v5SYAX2bwhP42t+llMqC2TJ3WMUykrcL3U6yfOq5gZrSvOh3Y0HCaSE68bj1+qi5nIwDOiWlN0H2BZNn6wsaIqkiD8t6eY3EF5/SRg0boR/O/Z7yelLQ6krmaWZCr5BWLjf+xgJyFrMTv3TQgJ8MwCMD2W65bVewMGW2g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo0.onmicrosoft.com;
 s=selector2-vivo0-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=t7/9rdhQphdB3bx+s6LccgI1BFHodYWqZAZuQWlnsMM=;
 b=IX4h9oioCVX3TIXpAL1XitiNuweRJMuWvRcukNNzPA8mrPCDoVEmi6VRkDjxG3Sk3a5zsOZnTOOMnxROEzj/cvKdjvBM39+/c8gxKXP7ncqKD2XCFoHEDnS1X4KZbIg5tuATlyxs7PyyHMhPiX0VaXYFI87ew3dXgrmhOD5ZxLY=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=vivo.com;
From: Qing Wang <wangqing@vivo.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Jens Axboe <axboe@kernel.dk>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel@ffwll.ch>,
	Alex Deucher <alexander.deucher@amd.com>,
	=?UTF-8?q?Christian=20K=C3=B6nig?= <christian.koenig@amd.com>,
	"Pan, Xinhui" <Xinhui.Pan@amd.com>,
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Alasdair Kergon <agk@redhat.com>,
	Mike Snitzer <snitzer@redhat.com>,
	dm-devel@redhat.com,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Hans Verkuil <hverkuil@xs4all.nl>,
	xen-devel@lists.xenproject.org,
	linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-clk@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-input@vger.kernel.org,
	linux-media@vger.kernel.org
Cc: Wang Qing <wangqing@vivo.com>
Subject: [PATCH V2 9/13] media: si21xx: use time_is_before_jiffies() instead of jiffies judgment
Date: Thu, 10 Feb 2022 18:30:32 -0800
Message-Id: <1644546640-23283-10-git-send-email-wangqing@vivo.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1644546640-23283-1-git-send-email-wangqing@vivo.com>
References: <1644546640-23283-1-git-send-email-wangqing@vivo.com>
Content-Type: text/plain
X-ClientProxiedBy: HK2PR02CA0178.apcprd02.prod.outlook.com
 (2603:1096:201:21::14) To SL2PR06MB3082.apcprd06.prod.outlook.com
 (2603:1096:100:37::17)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 35545403-9cfb-4fdc-3fc0-08d9ed06c1f0
X-MS-TrafficTypeDiagnostic: TY2PR06MB2895:EE_
X-Microsoft-Antispam-PRVS:
	<TY2PR06MB2895E2E05F1120726288BFDCBD309@TY2PR06MB2895.apcprd06.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:231;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	/syyc21+a3wCMBduHjjEZXphPVqYJ5p1/XojM3IKXP2n2wOF88FCk+axsSaSjzQu5euDJ/910sMON3XxFgzdvGNFSzJmvVNaVyxCFH87g2Zx3g7fZzKolbIa2Qf4v+NnaAhstPPGxNeKx+oCcqDLr1EmEWVZHSjAZxDn2j+zYE2VThN45BuJ11BOD3SI5DfavEJ8mO/wqzSIHeONhxZsXwKT5N2EeKjejdLpqmH39b+4msBOxJRWmpWQfmj168630vLfpPwWl1IcP87OWfhJlOJ9nF/2WjiZ9useg6hjRoXnDuFXY2QJHx5W/hnJnkBo1KR/YoLspn8ycO3L6E07598prptEnsZGU2J4ROEhdfJlRCNqNNrHwZCPu3+msPYi78QGIn/qroKsB9v2ZGSZipgjR2u2lVNyL9jpKVYH/h81s1OJWYtzwJQt078AZy+KG81QnwPqQKZzpJ2X/lNWtMklGIRCIvmjkW1cI1N3lADH2FByTsZBYssmEFJhIRPuNcFrOkSypFVC/srlQvi9q4o/n8aieWP4CdrHkGLroz37ZL0/2NQbkMm0wZQA3s7NoJcCElfSQg5NdmyQ/O/Nz5rwba8gjUJhjnMaa0/UI4sWTzp4RckpqFQiodDUVD/QM87bMwJvwFvlh2WyXdPq2b3a+tDN0IGXBAed0+tal1a5ypZxjJX0/84wP7kdj2KCQk1apHZyVnLcBSIzOcp6h1eJJshDQTLeOyjWQAS8Wa7gy/+g8F9f7ifgNPQ3kCte
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SL2PR06MB3082.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38100700002)(2906002)(316002)(110136005)(86362001)(6486002)(38350700002)(6506007)(26005)(186003)(2616005)(6512007)(5660300002)(8676002)(4744005)(7406005)(508600001)(36756003)(4326008)(8936002)(83380400001)(107886003)(921005)(52116002)(66556008)(66476007)(7416002)(66946007)(21314003);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?6LZ5k4ZdbVAaRXz3OQZIHKFg/WeYI3JTBc0emq7qjkfMJK3D7aE3ya+Z6tnf?=
 =?us-ascii?Q?hYyHNf9imAKQBo6+yaVfZ6vGQdMqT5dVB15ayZ0IqGbO+/D9CfPG5Z0lQotT?=
 =?us-ascii?Q?z/58+OXEhhohl4bzdo5zlTGFltOUGGhHnx86p+T773hnHW/arhP5m6U4GDbZ?=
 =?us-ascii?Q?ltsUkIBFjP1yAVYrDokULtmdaQEiuQ1F+okHG4dtENf+9uCwhm/o0uipxBb4?=
 =?us-ascii?Q?bHpoWgfpNI1GyCa527LuxoVruNTtT6739CTA0Z7++GpyqN+E/B3aL+WXZrGh?=
 =?us-ascii?Q?Cp7ViC/18kuakFZdAZfF3RFg/EOwWkQZjJtBRGYqkbZtIeJJwqEjivQWX3Zp?=
 =?us-ascii?Q?CLmmC9upyaiU9MaLBfPjAZOKsqW92iTKX7cWvPBxwcLrtlPw0GAjV8ZBvqAm?=
 =?us-ascii?Q?AzYMu275Aig7wWaPUKSi4pgOiebj+w2ac/K2CGS1oqTEd++3EX1BeuXkLsHt?=
 =?us-ascii?Q?/UQeoRRZuMSqNl8DikxVGmnG2hdC9oWj18rAiPKWt/UYT1BM6b5ptEKCf9Ne?=
 =?us-ascii?Q?4vIwru9a4iofqsCvtbJmaQw2fF30mlABfCNCOq29ZN2CFnm2a5qcCSG0FBeq?=
 =?us-ascii?Q?tPPdUhDG/MGdmUboYhnZjWNf2rHypUcnmdRIZ35nz23IUvzEecgz2rrDC/V0?=
 =?us-ascii?Q?rAY+UFIqIlzB23gFCgj43CoW/91w8PZmb6D8AC+qd2pMfi1mYU4yLyoV3KGL?=
 =?us-ascii?Q?3AwlTgXplrTrOIfrhbSreBuZY2/TAGJ478mTbEQQ0ybzgQi/eJUc2xuOjmzM?=
 =?us-ascii?Q?OsOSGGvDuilFoJwrG8/tJgPOGIW2ebAGYgG+0+1X5I0sOTDdy+2QMYUu+uGC?=
 =?us-ascii?Q?TYFQCoHZAuBQB68Q6eCqHX4KIPWy+loVQFlVOaxaV3naJv3XcLy/OY+m92Lk?=
 =?us-ascii?Q?DzxSUwz6EEtcUYIMn35KeqA4uOnppXxzGVj9Cdci/bl8T0fAJHC8XFfecI04?=
 =?us-ascii?Q?pX+L3YGSMA2w0cdw8CShirsHbc+fGGs0/0KwACjfa0HrZlaIeziGqPUV74mi?=
 =?us-ascii?Q?WJlnXtsM4EFYMiVELBl17c/xm1aPuOrG/pvNyQvcAcG9V8vINCwe8S/ePjzi?=
 =?us-ascii?Q?KzicIiC4AYdS9eliedPxsb9io9V4SFETUL9nR/M93iEVGawZ7aezA+MmrUnM?=
 =?us-ascii?Q?uMWM4eEDMijHvfEKEuL32NCMz7qAm8+1m5LHLIDwALA35S5Yy+jRQo/YEY7o?=
 =?us-ascii?Q?sc/1RTRz0CDjs8D78RfJCqq0Ah+9xHfGfW70IwOJrEBWJHkQojskFc+NAc9r?=
 =?us-ascii?Q?wvr4bETYhnjjd2kpVA0jy+4t66TbQlAetCv8pDrljjwxAEDDBdjJgOHM7x/r?=
 =?us-ascii?Q?jvhwYJ43P/MVkCQ7jokjV+cvcuQDZcYnMCCx9qt9SP+Q/jXL7IJzFvLS0MLX?=
 =?us-ascii?Q?nusiAg+AuGVTP5PtL9SYJOriYFv2AAs/rEJnCtiyxWJUdnaCvU4kCAS2jgDq?=
 =?us-ascii?Q?AWZX2sGc75lZ9Y+l1nmCANRMQrSg6X7dBlBC+5id80Yf/UQIGjd+LkKHiwEQ?=
 =?us-ascii?Q?qpacT7w77TjoL4//eT3Nkkk8lXX7yRt5a0JgN1LOnp1hrayYfP9sCRn0OvCJ?=
 =?us-ascii?Q?/gRVV3aK+lrqRcgJwW2hFhSQucmLGX47pW2IahbtLp8oDQ5C0DY/GY1nGl2w?=
 =?us-ascii?Q?qlheW/aQz1YbuqyBGwCHDZE=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 35545403-9cfb-4fdc-3fc0-08d9ed06c1f0
X-MS-Exchange-CrossTenant-AuthSource: SL2PR06MB3082.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2022 02:32:33.1470
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MVEDRXjkHcVBveXA8LcBcEgx0EK2+lRNap1RgZbICtzB7qCPM4wfM0+HMyKZlgP2NMC4+l4/JaD/4qaIh19kOg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY2PR06MB2895

From: Wang Qing <wangqing@vivo.com>

It is better to use time_xxx() directly instead of jiffies judgment
for understanding.

Signed-off-by: Wang Qing <wangqing@vivo.com>
---
 drivers/media/dvb-frontends/si21xx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/dvb-frontends/si21xx.c b/drivers/media/dvb-frontends/si21xx.c
index 001b235..1c6cf76
--- a/drivers/media/dvb-frontends/si21xx.c
+++ b/drivers/media/dvb-frontends/si21xx.c
@@ -336,7 +336,7 @@ static int si21xx_wait_diseqc_idle(struct si21xx_state *state, int timeout)
 	dprintk("%s\n", __func__);
 
 	while ((si21_readreg(state, LNB_CTRL_REG_1) & 0x8) == 8) {
-		if (jiffies - start > timeout) {
+		if (time_is_before_jiffies(start + timeout)) {
 			dprintk("%s: timeout!!\n", __func__);
 			return -ETIMEDOUT;
 		}
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Fri Feb 11 02:37:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 02:37:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270078.464278 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nILo1-0000Kn-Tb; Fri, 11 Feb 2022 02:37:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270078.464278; Fri, 11 Feb 2022 02:37:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nILo1-0000KW-OC; Fri, 11 Feb 2022 02:37:05 +0000
Received: by outflank-mailman (input) for mailman id 270078;
 Fri, 11 Feb 2022 02:37:04 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=+l4G=S2=vivo.com=wangqing@srs-se1.protection.inumbo.net>)
 id 1nILjq-0005DN-3P
 for xen-devel@lists.xenproject.org; Fri, 11 Feb 2022 02:32:46 +0000
Received: from APC01-SG2-obe.outbound.protection.outlook.com
 (mail-sgaapc01on20720.outbound.protection.outlook.com
 [2a01:111:f400:feab::720])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e4337974-8ae2-11ec-8eb8-a37418f5ba1a;
 Fri, 11 Feb 2022 03:32:45 +0100 (CET)
Received: from SL2PR06MB3082.apcprd06.prod.outlook.com (2603:1096:100:37::17)
 by PS1PR0601MB3705.apcprd06.prod.outlook.com (2603:1096:300:80::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Fri, 11 Feb
 2022 02:32:42 +0000
Received: from SL2PR06MB3082.apcprd06.prod.outlook.com
 ([fe80::80b4:e787:47a9:41bb]) by SL2PR06MB3082.apcprd06.prod.outlook.com
 ([fe80::80b4:e787:47a9:41bb%4]) with mapi id 15.20.4975.014; Fri, 11 Feb 2022
 02:32:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e4337974-8ae2-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=VQbjczXdhaoVW1RrNxUAwUh0RBhMZ07rt6JXYUyE0OqfkutGE7c5UULLs7U+W+3dBnMZtpjkRiZMpNGm3kGAENQSQyppc4WOgd/wqJK3LaXOVEbZ0j62bLNT3uLYoB1isDh275y+rv2xVIABa0vyiS1DmLAQImu8lFEST52INyA5JjgH3UHaOevUiqawfPPGJ2I7Uiq/WIQ3WcOhOTcl4HwQ/P1i1Z04wXE+eABpIwmocyD/aJXGcrYEYsUOxEzVf9z5mQLFtoMQowFdYrrMcrC29uB2vK9zWRUIelEamPc3akRlZXn57FQ8QbXEfY5KJsK88UQ682fzN11s0VciPQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=9X2g4kpYY8KJuotznJ81Z41K5vV88bf/Mlcbscv2oJM=;
 b=AQpOit8RV0dmM4IrGOhQ2YuSs9HQocL14th0vYjUA7DOX0Hg3nm0W2ClzAen1Kz8Q93bS9McBIsz7r/ZM7cq6BH50K2ysnTsjovANmNoJhP6qyJ3DA1Eoy5Q8HRLZN3dsYYB/N5Kd3Az7jZO5aBYgVfmYXvg+mbbccm5+EdAxTMoqXbN5vMMq2SrAvtiN5AWQleyP8rFavs84MhhG43Nr16Wrur2Ia/YM+dkPrIolDJjt139a1kcWMNYEgRXfpCJvhilxa3UAOrYDfNFiCicRRZzYvdBzXT9IDrhZPg9lFB9NerHalLOGoek7l3glUWfN7f/05kCzdh+t0Hm6MnggQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo0.onmicrosoft.com;
 s=selector2-vivo0-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=9X2g4kpYY8KJuotznJ81Z41K5vV88bf/Mlcbscv2oJM=;
 b=ddtX6aYJs8VtO41HYv/sLTHRTEi8M6HIr4B2zlmqPBa2cfxRDL3R1lGxaH3F/m0cDV07bOzXkOfdbJqYV/PHeHy70KeilD5aqV7HqGizuYAk3TNJ4vHV1I4De597ZzVvholVj/lF90opapMiei7IVocxYq9Qj+6vqXf9lqFZkao=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=vivo.com;
From: Qing Wang <wangqing@vivo.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Jens Axboe <axboe@kernel.dk>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel@ffwll.ch>,
	Alex Deucher <alexander.deucher@amd.com>,
	=?UTF-8?q?Christian=20K=C3=B6nig?= <christian.koenig@amd.com>,
	"Pan, Xinhui" <Xinhui.Pan@amd.com>,
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Alasdair Kergon <agk@redhat.com>,
	Mike Snitzer <snitzer@redhat.com>,
	dm-devel@redhat.com,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Hans Verkuil <hverkuil@xs4all.nl>,
	xen-devel@lists.xenproject.org,
	linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-clk@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-input@vger.kernel.org,
	linux-media@vger.kernel.org
Cc: Wang Qing <wangqing@vivo.com>
Subject: [PATCH V2 10/13] media: stv0299: use time_is_before_jiffies() instead of jiffies judgment
Date: Thu, 10 Feb 2022 18:30:33 -0800
Message-Id: <1644546640-23283-11-git-send-email-wangqing@vivo.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1644546640-23283-1-git-send-email-wangqing@vivo.com>
References: <1644546640-23283-1-git-send-email-wangqing@vivo.com>
Content-Type: text/plain
X-ClientProxiedBy: HK2PR02CA0178.apcprd02.prod.outlook.com
 (2603:1096:201:21::14) To SL2PR06MB3082.apcprd06.prod.outlook.com
 (2603:1096:100:37::17)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 22c30a67-df4e-474b-1402-08d9ed06c74b
X-MS-TrafficTypeDiagnostic: PS1PR0601MB3705:EE_
X-Microsoft-Antispam-PRVS:
	<PS1PR0601MB37052B4353CB4B49C0147A56BD309@PS1PR0601MB3705.apcprd06.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:231;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	xtNha4o4kxbbrNfFe7wfuqRCh3dUaMbzGNVcM1pOyR1Ba9j+igCFK5RNDPEDQhqmeAZHtUncJLkvOilM4zuyfKw2ygJ8Rk+7F/6WWneaoX33RAZUOTmBEoN7gU/psJapDQYaFEFUx4TIr/Sb8MiEaEA/1c+5DEj2VrK9Yq6epeFoKRUTzo/IxRDPW7jq1l4TFO6W3xaWOzrhpfRhtfv9zz09Ps1m6mo09DtHvTGkJVuLaNRFVfact1zdKKyiTlaHHKaIuxKxTxKYOzwwjGfRwSxSq9LbnuFWQlHzY++fQH0/3A9Jp//T1l47+BFpD4BHolz4kbmuZQ0fUvlXn8r0TrfIWK8XNFBJq35R/4MIfVpW3UFsVaQSo3pLNu0A22hjoUKuCKrP+URcqtkXw/dX4MynAtOk1Ux4B/FE6tfoqd7st7rneCelFFtx3oIUH8GViSicF5K7Gjw2N31QU3LSzgHguH1re+wL4BL8UQdYXn7x/Ep3Svd+NeRbZJ6GGOVnLnG4GmxQfaaVRS0rwFfQEoFLQYGTHyRNR9LiSpMNKYdjTP5GOVT3FCdRTGnus1p8evxG49bMC/BxOX4i2vLZsil1atJq5iUGUULcUBGhBe++jVw+7l6ni6yRdUKMLGiC623zIMxI1Iatqj2WjYDm9OSX/zyqep8uXe0H9nNLR3vuHT3cVrOk3d36dJYsPiuiO8BfFOQqJwMcaYlsDIfzOPAR9NtUPkiWgkRsIiFD7m036gHipCO6xrm80rDK/ZT/
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SL2PR06MB3082.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(186003)(2906002)(7416002)(66946007)(316002)(36756003)(2616005)(107886003)(26005)(921005)(7406005)(110136005)(5660300002)(83380400001)(6486002)(6512007)(6506007)(66556008)(86362001)(6666004)(508600001)(4326008)(52116002)(8676002)(8936002)(66476007)(38100700002)(38350700002)(21314003);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?pjaWTw4CSxN8GS9UnFX7sA3l+GWwXMpUq/KEesRwKL/GoHXIOjBizWdywU2i?=
 =?us-ascii?Q?g5ozpuQuAfq6Ma2m3azzfAG4n+rBWIHHUCrMNlgbBIi4cFezPOuMlMm7StBT?=
 =?us-ascii?Q?vGbQ4xDR9W04WLXbdFu65s179EveD5um6ffW6Tw11e+MosB1LLEadPsLcaA4?=
 =?us-ascii?Q?1NkxRLkA6HDxqNYEgFzn8Hy3t16Fkx8Es6y1hLk4+l+CQHERU5eAkpaFqvRp?=
 =?us-ascii?Q?Ptupdmt5qsjoxg11zvP2048fHPqvG7EngtIO/8I2xC3DU4shQY7HmjbO1beV?=
 =?us-ascii?Q?bG/9A+eGma864Q4br1ZKC3w7FUWXtWH3hBs82f3Sbu28B/0efjlgYJkNxaeV?=
 =?us-ascii?Q?idYJIKox+0dtnNtTNIjPh8a4Wo7SqnosOZbb1unI5kJfUpg+oNvOv4lLEGqE?=
 =?us-ascii?Q?jQMUuvz+IdztIGFoRaju5Rjo4IIZfYKdZ7bSAulf95n7dWjhA/zoWTaQ2wVp?=
 =?us-ascii?Q?jdjrZ354MmURz8ySDEzgYlCwg1OPGNPRsPLXsei4+k2PX2ToU+QtL2rTg5w0?=
 =?us-ascii?Q?gfnEls+wcSnkVFeJjYP3FZWFev4wrIn/jP31cLj1FIC5htyPJwnst0oSKc9D?=
 =?us-ascii?Q?ZZSixxWF3QhYpWMKsdIGQYnRpGLRS8BUnibB7OQ4KCv6cjFXOgugR4gao31M?=
 =?us-ascii?Q?PGZpn3w5jTexCHxvguyzc68rsdEw2lxURxIctGHR7We5LkSwXSWU9bgznzfV?=
 =?us-ascii?Q?/VO174WxxGYr/C/oLhzcCuh3MX2we2SV+KgkCq8nXo16jIAavT38z1icxBOB?=
 =?us-ascii?Q?fBpAq3FmfF9wz0Y+Sw/E7aAPWokjeCTQcvFaOy8TCEuwgiRJh8XLLv7ootST?=
 =?us-ascii?Q?u2hicKODZZTxC6h+9pEW+7NkKSe4QRWjJeTqWteAF6zHzpcufum9aeKxbtUg?=
 =?us-ascii?Q?H2s5jPbPqlzwdgrLezCzbdgHs5h+o2bFe17M+v4CdZyof1T6TpbzQruW5L7Q?=
 =?us-ascii?Q?9r0AggtqIuU/NBivDidqK+TKNyql33WcIga/TvBA57x2Ia2JWTTQtnMzJmvg?=
 =?us-ascii?Q?23gIhw2wu2TJTYzFvShjKIQPXENdwKlxM4u3HHnttdjU+bIySaSYsYaCRAXb?=
 =?us-ascii?Q?GX06/LNA4dCPL0A+01JT2RuBwR77V6uCGygcRPC00s2ooTcV7xXWN6TwbwpI?=
 =?us-ascii?Q?d9HMd8eKYq/3eQWMefDxsb9sNuOC4JSL6WvQY7cmsbivRpHpYSUweDhDr+FQ?=
 =?us-ascii?Q?K5aOBgZtPwwttP08+muDswpOB8Wdkb8/7/pe7ZT6dKilYvZWaLGwjCpF8nxZ?=
 =?us-ascii?Q?uObl0XpQgrVGl8pV2t0W7vjR9xL2EZLWSBiKoHL8tgPoduCvizuWxxPxxeMn?=
 =?us-ascii?Q?eYFAgul1/wweR7scvTUBRR4UkeKhaFphYXcXwjRPvByGSmDKqfiOB9SVluuK?=
 =?us-ascii?Q?RWDbKliEzkTr4W7a6Ke3qTYjrLhsrrdcBC5OKjFpI6LzwrVyqijvc8DHe5HV?=
 =?us-ascii?Q?X6zWze1fyFnfk0k8Vx4I/acFDIuFPt31QFIs5dzefZgYi07IU9BRFyXG+7fJ?=
 =?us-ascii?Q?bM2MiNKB//O0FSLkEsgQDKv1Oh+Tt4rin8XGjcXMoBnoZViFFUsO/qEDB7YC?=
 =?us-ascii?Q?LBYDqMoWLXcCNaF4G7r649xf471DAe95bx9OHdmo3Zs0dYqqq4KaWyDCXI4l?=
 =?us-ascii?Q?m3bcmxIaxaonDqM3EvgVrjY=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 22c30a67-df4e-474b-1402-08d9ed06c74b
X-MS-Exchange-CrossTenant-AuthSource: SL2PR06MB3082.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2022 02:32:42.1464
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Xdyf1Z3lDKOyxrOoZ86n1eQZmt4qPNjV9K2+wx3x+3JYTq7UQ2ub4KQHKR/GkbvOQn9kNhZLzU4kryauyQi1QQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PS1PR0601MB3705

From: Wang Qing <wangqing@vivo.com>

It is better to use time_xxx() directly instead of jiffies judgment
for understanding.

Signed-off-by: Wang Qing <wangqing@vivo.com>
---
 drivers/media/dvb-frontends/stv0299.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/media/dvb-frontends/stv0299.c b/drivers/media/dvb-frontends/stv0299.c
index 421395e..867ae04
--- a/drivers/media/dvb-frontends/stv0299.c
+++ b/drivers/media/dvb-frontends/stv0299.c
@@ -183,7 +183,7 @@ static int stv0299_wait_diseqc_fifo (struct stv0299_state* state, int timeout)
 	dprintk ("%s\n", __func__);
 
 	while (stv0299_readreg(state, 0x0a) & 1) {
-		if (jiffies - start > timeout) {
+		if (time_is_before_jiffies(start + timeout)) {
 			dprintk ("%s: timeout!!\n", __func__);
 			return -ETIMEDOUT;
 		}
@@ -200,7 +200,7 @@ static int stv0299_wait_diseqc_idle (struct stv0299_state* state, int timeout)
 	dprintk ("%s\n", __func__);
 
 	while ((stv0299_readreg(state, 0x0a) & 3) != 2 ) {
-		if (jiffies - start > timeout) {
+		if (time_is_before_jiffies(start + timeout)) {
 			dprintk ("%s: timeout!!\n", __func__);
 			return -ETIMEDOUT;
 		}
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Fri Feb 11 02:37:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 02:37:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270080.464284 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nILo2-0000N4-B3; Fri, 11 Feb 2022 02:37:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270080.464284; Fri, 11 Feb 2022 02:37:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nILo2-0000Lr-1G; Fri, 11 Feb 2022 02:37:06 +0000
Received: by outflank-mailman (input) for mailman id 270080;
 Fri, 11 Feb 2022 02:37:04 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=+l4G=S2=vivo.com=wangqing@srs-se1.protection.inumbo.net>)
 id 1nILkB-00046f-6v
 for xen-devel@lists.xenproject.org; Fri, 11 Feb 2022 02:33:07 +0000
Received: from APC01-SG2-obe.outbound.protection.outlook.com
 (mail-sgaapc01on20709.outbound.protection.outlook.com
 [2a01:111:f400:feab::709])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f0ba3666-8ae2-11ec-8f75-fffcc8bd4f1a;
 Fri, 11 Feb 2022 03:33:06 +0100 (CET)
Received: from SL2PR06MB3082.apcprd06.prod.outlook.com (2603:1096:100:37::17)
 by PS1PR0601MB3705.apcprd06.prod.outlook.com (2603:1096:300:80::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Fri, 11 Feb
 2022 02:33:02 +0000
Received: from SL2PR06MB3082.apcprd06.prod.outlook.com
 ([fe80::80b4:e787:47a9:41bb]) by SL2PR06MB3082.apcprd06.prod.outlook.com
 ([fe80::80b4:e787:47a9:41bb%4]) with mapi id 15.20.4975.014; Fri, 11 Feb 2022
 02:33:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f0ba3666-8ae2-11ec-8f75-fffcc8bd4f1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=mYcls2hYgTRkgRmLNYq+PpwVIWJryFOwxZNyueE26a3tnCn6NO7ctkIsPPwe6D00MxSJ4nBypq+NL9zLZs70r5i+aC86rlvau8xIqaopkvfC0KFZJCBWOSpylLCt3MiVBK4WPNMARQKjWtphsSwPWpa+Tf2nmtyfsu/aykmtjvefwPJdYbFF2gZ/u8mCC5xLeTirYR4HCMqt57p0+OpLShvt13urdeGBmVeiERdpZ0XETvdNFvXEjeKHKu4R7kmIPDamA6ueWCEkCoBHE85FmXn/Ek7O0wM8uCNrxMCQ/ydjPr1AKH9by6o/rJInotFRSWSwSFh6m1Rf+lBvL8uJ9Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=pTRNaeTNqvizWhskx53RuBoI6rnoc/OaONHjRSZtZb4=;
 b=laobJddwq3euwBKa5idoNzIY/7GQA2ReT4wkGY1t/IuwriDfjUWCgXneQBVKvJZbjQMEwoL2XoSepmVxUvm4oj1eS9W8kwTplcbQ7ZfYQeKDkfl/90x+zYYhHCzrezi38qdD5Kb+x8JVTSIVEnsmq9+mFydaSulJhUpxWb6V5qKXJ4v6wiDcfL8r0LLKE5vFifVM8+rF1YNx5K6Oqjdovwz+jjX98zHg4fce6+ybX38hCoKnuRd7OKqXeDzEx9iqtpZsD4TPa7KFOVPb5igkNIUlycp2VdASGx3oQvKqFTns31bbtEIwZ0BCH9ZmgJGUelczm8McgpQKhDvgDzp8QA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo0.onmicrosoft.com;
 s=selector2-vivo0-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=pTRNaeTNqvizWhskx53RuBoI6rnoc/OaONHjRSZtZb4=;
 b=LuaQiHhLoMWk0Q6lAgXzFEOIF6E/Tvssv1qtqGP5p02RQG8Mvb2Dz7NV+nXvvOaHeq3gxceKD6D9jOypqntrMeIhxRWvSnVV77vTNmiVa20z3dTY4XqQWxjMbfgk3YwlPk3stSSsFVrkIniZKlundxfpguDw8QV/1s6+Co3ewWA=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=vivo.com;
From: Qing Wang <wangqing@vivo.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Jens Axboe <axboe@kernel.dk>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel@ffwll.ch>,
	Alex Deucher <alexander.deucher@amd.com>,
	=?UTF-8?q?Christian=20K=C3=B6nig?= <christian.koenig@amd.com>,
	"Pan, Xinhui" <Xinhui.Pan@amd.com>,
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Alasdair Kergon <agk@redhat.com>,
	Mike Snitzer <snitzer@redhat.com>,
	dm-devel@redhat.com,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Hans Verkuil <hverkuil@xs4all.nl>,
	xen-devel@lists.xenproject.org,
	linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-clk@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-input@vger.kernel.org,
	linux-media@vger.kernel.org
Cc: Wang Qing <wangqing@vivo.com>
Subject: [PATCH V2 12/13] media: wl128x: use time_is_before_jiffies() instead of jiffies judgment
Date: Thu, 10 Feb 2022 18:30:35 -0800
Message-Id: <1644546640-23283-13-git-send-email-wangqing@vivo.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1644546640-23283-1-git-send-email-wangqing@vivo.com>
References: <1644546640-23283-1-git-send-email-wangqing@vivo.com>
Content-Type: text/plain
X-ClientProxiedBy: HK2PR02CA0178.apcprd02.prod.outlook.com
 (2603:1096:201:21::14) To SL2PR06MB3082.apcprd06.prod.outlook.com
 (2603:1096:100:37::17)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a0c82371-8017-4197-5f91-08d9ed06d2ea
X-MS-TrafficTypeDiagnostic: PS1PR0601MB3705:EE_
X-Microsoft-Antispam-PRVS:
	<PS1PR0601MB3705AF49C75AC16BA5099910BD309@PS1PR0601MB3705.apcprd06.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3631;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	11djht2qCnSHMekgjn3yfBRNtKoR0UKGRdDeekosS2A4AcFGfSf+QKEcjVSnzr3ieJMEzCCnbyUD7zK7fd2IcVdw0r4yjmIqyF2yGbTm+2HU4IlFNRVNlCKKDzRlZ/6cCVK37j2tZ0Mw55gBsf2CFgFEpdmKeIS+UijpaMSkOLATA7oqL0OIuuQVDg+p4PfEZaN8rqN1A2VQH7ttB9uBIX1QuI7bQLdAdVou+oIweYykJdmldP2YkkYJJxj8P9cFqoqSruo+mu2cJaEx0HEeAHnMIiO2tAhoUJQM5465VSFPX8O0eoMKKQuNpCyjC5sIljeXf0enq7aKAT6lbhSVB1nreAIimblP2EiIuFzqnnsURNqftyYJxzUPDBLAM5kenQUdKj5zUvGSpqhgiqLrHx0MtWB28l6sbzxD52d6iHp3EM1j3KM6T98sYHvMbFX0oOZRroNIYvYKkVQ41UTrURd+fIF69cftcJiBCa2U4TxXtre2edAL7Xf3Dmr5zRlq2lbuFtffgfkBkv4YbzE+Nqlwg36WM7ihe6PospLDzLIrL25Z3iXeEQz10a3Ko6R89PJzcS7JGG0eOGV1u+wijPYeha6073Gp7Mecq2MK1wX4vfIblPMSue9oHRzEojZpvmBbZx2B/+DhzfB+rH1xuC5F63LNPO4aD5udzwWf2fz6s/XwP8QuzB/cxV7XJrrd/BRaTaXaCA5ozq8eLq5y1gtQUD2ZTAdcWp005htUYf8JtG4kn7FB4qp40LfQrBdB
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SL2PR06MB3082.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(186003)(2906002)(7416002)(66946007)(316002)(36756003)(2616005)(107886003)(26005)(921005)(7406005)(110136005)(5660300002)(83380400001)(6486002)(6512007)(6506007)(66556008)(86362001)(6666004)(508600001)(4326008)(52116002)(8676002)(8936002)(66476007)(38100700002)(38350700002)(21314003);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?j9fyLt2pN3iVlwuQgYSDuidhHBuXIqGYNxxdAxZxiLqMohOtaeQ4vcG95cj4?=
 =?us-ascii?Q?8tk23Bxd/fSNFy190paiTPbZL3vhMrekLNGVOImi/gPBk1Nmv9rA5EhMuCUP?=
 =?us-ascii?Q?je1dnQHm49etj4mp/Q/gankTIjbTVaB62MwksFHWLaiLP/pNgQUEJYyr5WoC?=
 =?us-ascii?Q?OMjBLuNNTc/mwvq11hwxOagLktLUfBsWIWzyh5eGr+/IobCHbnsPjJejsNRY?=
 =?us-ascii?Q?xZbJUywMZtmYConMfnjZ+w0HCd+Uft3dek8DObgX88vbFk1wnhyvfwk1AQ0x?=
 =?us-ascii?Q?uYuIbot6Bkxx33EGOf8p83qlCg8m0YznvJsThw3o3CGJHmiM7vv+uNLaMtlw?=
 =?us-ascii?Q?usupnjPdxbrdZXbzikVs312ML/TVP6s8qMU8b7DtjE4EqVhixvtN+ZGxIVJK?=
 =?us-ascii?Q?0KzoC8C8bktQol0RNWc818k8cAcO6wruT8ZEgZ5R8Zk+qy7bmpcdGi2FCbsW?=
 =?us-ascii?Q?s9je5QH/Yn6UCHJ1c5oG9uCwsy+NTWu5Iw/UyZUrFlveovYFyzZXsXIA3K0a?=
 =?us-ascii?Q?lxExdE3NfIXWcMgetjHAtg6j5PT2NZFgeIC/RUQaNnV4o6HVpSewEuPC0pwr?=
 =?us-ascii?Q?VgHexVgfvMw/FLOaoG/R+lKAproLn+ODDh3D1pBjq0e/gCJuBSWILxeHKahW?=
 =?us-ascii?Q?q5Jna0NBrGCp5GZ3+qrGLpGy0UCXiQUqxoi+EHYPhuY3AxYxPhR2nUlPIuXb?=
 =?us-ascii?Q?5yFuSIUekF7EchRUNEHzaK1T0eBkIkvdkOvtJRFx2/1YcA2uasFAjbzVvBHV?=
 =?us-ascii?Q?MSxF+3SACPq6sNMNgm0Cu/UH7JxUz0TCBh/SZUBT49E+7Yes8YWgFBDj205N?=
 =?us-ascii?Q?Mp+TOTxnEq/Sf/nEQPhey2gV08XSH5+37sUQo71qI16kkeOSHoUiZxZ92IR9?=
 =?us-ascii?Q?glj+z7pMxkcYjul7sFNTksL8yoKrvPERGBvpUgaRElg5qmlK2bUKO5diNCLj?=
 =?us-ascii?Q?HaewpMmmXkY5Xf7TmEQOZhAwT9/T8KrKjxzBmUpDkyo6N8Z1iijvF6S1rU5X?=
 =?us-ascii?Q?6doyYzqhqNcMQnhkv2bK27LTFrUXktrhC0ABsnJ2xZiRnWgbrFzsoblnlebD?=
 =?us-ascii?Q?rKoVD9/mufSXio0kFwHGCy8kihdYplrZdv8XCNgYMdqVkTbSILPM7+QT3feE?=
 =?us-ascii?Q?lAeO4y6o3g4K8R1jUgNrg7f0pe8o2xN5oqw+wTJXj75JdqPzbeufTeyw0YPi?=
 =?us-ascii?Q?kDFmcPQZ1YQ7aAOv9e8x37tsOHwwDeqz/N9s/rpyqto+GyGqVjh3w1KMwrgK?=
 =?us-ascii?Q?NEt2SLFP5Eb6KdYskenPL0wzNkd0yLDMz0yCNIPoDpJ44z4P2APDeA5Xzgh4?=
 =?us-ascii?Q?s7Db7ETALugxj5MA9fTSin7gcOkwlJDzxeravTfwq7laIXqNF+Mt4IEi94Rs?=
 =?us-ascii?Q?RGtman4w0dQhnGfzetD8P4kt0GstkLSxXwmeezCGkmK2tBRHEqN5Olrimr/P?=
 =?us-ascii?Q?jb5MSFNcL+dHhWKg0Cibf6vl5j1o3ZmE4CzOI6/xz2kBgG/W9YnAIg4sBXRE?=
 =?us-ascii?Q?jmYw42Kp2ugl7V2ivgeqwjtyl43EwCq3BBYSKg9FL55TxqFMyCAs/U+7bVtm?=
 =?us-ascii?Q?/7PCgwOqunni2VGWvO06JdDBSksstiVDmNMy9W3uYmtPM6SGbTApPcjW+bem?=
 =?us-ascii?Q?Uq3uRUmeM0yZNeBmyxrTv8k=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a0c82371-8017-4197-5f91-08d9ed06d2ea
X-MS-Exchange-CrossTenant-AuthSource: SL2PR06MB3082.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2022 02:33:01.6141
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HDxsZ8OVzzcn3EziFmxkt3V6wB/ovplKbr+7kX4+3TE38TD3TwdWdWogUoybm0UyyF1ke3SnrbndMi04Mm7HgQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PS1PR0601MB3705

From: Wang Qing <wangqing@vivo.com>

It is better to use time_xxx() directly instead of jiffies judgment
for understanding.

Signed-off-by: Wang Qing <wangqing@vivo.com>
---
 drivers/media/radio/wl128x/fmdrv_common.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/media/radio/wl128x/fmdrv_common.c b/drivers/media/radio/wl128x/fmdrv_common.c
index 6142484d..a599d08
--- a/drivers/media/radio/wl128x/fmdrv_common.c
+++ b/drivers/media/radio/wl128x/fmdrv_common.c
@@ -23,6 +23,7 @@
 #include <linux/firmware.h>
 #include <linux/module.h>
 #include <linux/nospec.h>
+#include <linux/jiffies.h>
 
 #include "fmdrv.h"
 #include "fmdrv_v4l2.h"
@@ -342,7 +343,7 @@ static void send_tasklet(struct tasklet_struct *t)
 		return;
 
 	/* Check, is there any timeout happened to last transmitted packet */
-	if ((jiffies - fmdev->last_tx_jiffies) > FM_DRV_TX_TIMEOUT) {
+	if (time_is_before_jiffies(fmdev->last_tx_jiffies + FM_DRV_TX_TIMEOUT)) {
 		fmerr("TX timeout occurred\n");
 		atomic_set(&fmdev->tx_cnt, 1);
 	}
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Fri Feb 11 02:37:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 02:37:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270081.464286 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nILo2-0000Qc-H9; Fri, 11 Feb 2022 02:37:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270081.464286; Fri, 11 Feb 2022 02:37:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nILo2-0000PJ-B2; Fri, 11 Feb 2022 02:37:06 +0000
Received: by outflank-mailman (input) for mailman id 270081;
 Fri, 11 Feb 2022 02:37:04 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=+l4G=S2=vivo.com=wangqing@srs-se1.protection.inumbo.net>)
 id 1nILjS-0005DN-00
 for xen-devel@lists.xenproject.org; Fri, 11 Feb 2022 02:32:22 +0000
Received: from APC01-PSA-obe.outbound.protection.outlook.com
 (mail-psaapc01on20715.outbound.protection.outlook.com
 [2a01:111:f400:feae::715])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d559148a-8ae2-11ec-8eb8-a37418f5ba1a;
 Fri, 11 Feb 2022 03:32:21 +0100 (CET)
Received: from SL2PR06MB3082.apcprd06.prod.outlook.com (2603:1096:100:37::17)
 by TY2PR06MB2895.apcprd06.prod.outlook.com (2603:1096:404:31::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.17; Fri, 11 Feb
 2022 02:32:16 +0000
Received: from SL2PR06MB3082.apcprd06.prod.outlook.com
 ([fe80::80b4:e787:47a9:41bb]) by SL2PR06MB3082.apcprd06.prod.outlook.com
 ([fe80::80b4:e787:47a9:41bb%4]) with mapi id 15.20.4975.014; Fri, 11 Feb 2022
 02:32:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d559148a-8ae2-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=WNn5PFnUlQRZMroeUdNK6hMvhNg013ALNzHFF4aCA6tIQjuE/IGUwNtsc9o9ocX0gBwgK2zyNWLXbng9z2RHrgCw4E6Ay5ptBCwA+b+G+DElYxUxSp9P7KssRuYYHiIcY771B3LYduPicahMc4sd42w7/INIFVh9tYpCH5nt6HzYGa0VTHorekxnKLfyr6BkeU08PknMDQU/SvWmhQW1VFhNR6Qt8z+oW+nach0t6fV1rn6Qc6olB/SPz5KH17u2xzb5Zb4m0S5bylzkiIgJra1Hiq3rPa/ekftDUhqRYOVlzFQpXfPmDBJ7fLQUzQDS0i+cvGH/lEm1lSxHMohQvg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=g0n+5Y+UWhVVFn6fogkZFTZZCvYdUAj53FrLFaVjD6g=;
 b=di86ua/aim/Sa3gK6CBDkLJN+pJ0toIN9C3muFlOIThSpMmZIXe9/TRzGplUAvXdPO+awMomroG9nPL14bCyOmW/2tCpQO2edu8PO/mZJTI01FUz+b7AVFiEYwh5sp+LnEtbAeK5DwoON1y7/UkDGGo0d6k5TrmYr4DvY2hbHXdUNw/MMzPLF9vTo92NIvaleCtf34etFOtBgVlSgmToS9xL24VKexxA/hB6LDB9bcY2myWr90Ql33PbRZc6dNW4bSx2BFMPK0cTjl2dNQMsCbJLWMhAmw/pcF3w48R+//uzM/M7IBk0tViked0RujsCuMtM/l+cCmF4sF9d454SBQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo0.onmicrosoft.com;
 s=selector2-vivo0-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=g0n+5Y+UWhVVFn6fogkZFTZZCvYdUAj53FrLFaVjD6g=;
 b=G8TvP9jD7K7K7nFUHLOqGimeJOBLUx0xSN+gIQI4a17bqYB4kRNr2zygEnh6Iy9iSoSjoN4iphrLW0xJFhZbU30GXgXS9U5xorHCWsJsI4RjN6Ce45Cy1iVsvH5UbHBUqvW/e9udYvd5/UM1dESjpPmDEU3rzmYGRFkF2xhdM3o=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=vivo.com;
From: Qing Wang <wangqing@vivo.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Jens Axboe <axboe@kernel.dk>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel@ffwll.ch>,
	Alex Deucher <alexander.deucher@amd.com>,
	=?UTF-8?q?Christian=20K=C3=B6nig?= <christian.koenig@amd.com>,
	"Pan, Xinhui" <Xinhui.Pan@amd.com>,
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Alasdair Kergon <agk@redhat.com>,
	Mike Snitzer <snitzer@redhat.com>,
	dm-devel@redhat.com,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Hans Verkuil <hverkuil@xs4all.nl>,
	xen-devel@lists.xenproject.org,
	linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-clk@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-input@vger.kernel.org,
	linux-media@vger.kernel.org
Cc: Wang Qing <wangqing@vivo.com>
Subject: [PATCH V2 7/13] md: use time_is_before_jiffies(() instead of jiffies judgment
Date: Thu, 10 Feb 2022 18:30:30 -0800
Message-Id: <1644546640-23283-8-git-send-email-wangqing@vivo.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1644546640-23283-1-git-send-email-wangqing@vivo.com>
References: <1644546640-23283-1-git-send-email-wangqing@vivo.com>
Content-Type: text/plain
X-ClientProxiedBy: HK2PR02CA0178.apcprd02.prod.outlook.com
 (2603:1096:201:21::14) To SL2PR06MB3082.apcprd06.prod.outlook.com
 (2603:1096:100:37::17)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c225f979-e148-4ff3-3fd8-08d9ed06b7c7
X-MS-TrafficTypeDiagnostic: TY2PR06MB2895:EE_
X-Microsoft-Antispam-PRVS:
	<TY2PR06MB2895C5F8FAFF3D4794E09867BD309@TY2PR06MB2895.apcprd06.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2201;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	m+gLbLKDEUYtgg6JicjuPldNAEFxgWIHOT7l4DraoaJD6b+FautiuJXjyJSIJnH9mYKXvyu+2+URwZPVEfb6vN8+fn9tAy71Bc6uiykTfGDuBzTJ0l31SRC+FVmdiStKMGJYItgGxPmMwTWHdRigJlEQoVRSLJuD30YI6EKeosSlg41s5Kt5+03KD7jrPgSU3x7wAPsWx2YEd/ZdeGmDJ/OLPQLtxL8uga4F9oRJ7n3tpd//z6MSNbn23dygd7SK7z3LlOncANQB6BnnEUVhGionjOcYHC4Nhn8HHB+W6tbkLI4Q05+WXhY50Y0g7T5HuZXT1fyRKJntJX/D4xljmO/35XkBLb/WJBBPbxv7L3EZnoRv9+8E35V8fYjSclLpy6GSkmLgJ8ir76dIcz/sUwNkaMN9tpYehhuArKCh4gVArqP3Smg1izn6tNo5NTlWUYi/qAzjzgIFvMjPsJ3e7ZSGINZTq0N6+lCasmPqxtkC0vRYksTQ2uEcMAnIbZXmw7yYZN4HBTUF0uEnL0gsxQ4Tzd8JyQJ4FIbFYPxcMvQmyl2FuO1ptziccMi6fHR60ceVv0K8ymdF//fb6QGhDiy8jTmgesQpIpqHc4JTHlU/akv9pM+JhtXT19Z0WXfOZw9WpkAiVYMrdpno3VHXamMW1f69DbuTOQPcSiZ/3PgeoMJJMLuXbfdTShntVbvmMMa+xpVviUqPZhaWNt1eJEZBS0PqcJgxpQCriKRPTUI16z8JpnXpHbscDnhs/j+X
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SL2PR06MB3082.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38100700002)(2906002)(316002)(110136005)(86362001)(6486002)(38350700002)(6506007)(6666004)(26005)(186003)(2616005)(6512007)(5660300002)(8676002)(4744005)(7406005)(508600001)(36756003)(4326008)(8936002)(83380400001)(107886003)(921005)(52116002)(66556008)(66476007)(7416002)(66946007)(21314003);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?9wJunXdafueXwS1HARm+UcDn9TyGyU9g1s76Lc6rMQJXbcwOgVcd4d8/HcxT?=
 =?us-ascii?Q?/JVc9sR2wmCQDk7kOA/mKbLUkeUOddf5rVUcUlE81Fv0wxXIT/Foo0drXfj+?=
 =?us-ascii?Q?okhp/LpdHRtg8IoqR4a+utA8A2LjYTwIuv7AbnnWNUrU8otcHM7DGUU9VSun?=
 =?us-ascii?Q?OSybiJa3wl1QmPNWxBCuY2vE2cmkGuA0Q4Zf5+zvew3XxpH70pcN8epb8+0u?=
 =?us-ascii?Q?ImsWg9Oqzv2/l08hbRK/SmE7K1E24tWVo5yhjebtkN21zBsxvKLlMmB+C4ov?=
 =?us-ascii?Q?9nUrCkwx9PIFlhzkbupJowU/DIOD8DxWCKA0/KETzZwpjNbyEjM6wg+YM7pT?=
 =?us-ascii?Q?rdWeH00wh1eGD1QCe7DP62Zc/DJtjFbqK3ju6fnUqwQ1BnOxn1NkonkH6g+k?=
 =?us-ascii?Q?KniDGW8HavDExlKV8oAaYwtrAw46pWP7CvGHKyYBpWTT5gJ9/RE29rHNGOd6?=
 =?us-ascii?Q?B9AQ8MQjkKQERY/XYUlyh3yqxjkbRufTz7z91kZP0q86H8EWsTSsh4R+ZTuq?=
 =?us-ascii?Q?+yHiaVNfLspSHxhR0EWCFKLGIYl4M2JplniPFyvSPEi3QTirWUWSqYYREEQE?=
 =?us-ascii?Q?LjiqcDoiNITz3jlQwQlmSPydYl7ccGl83oE6Z0Eirrz6B/ATOyWW94XFPNsV?=
 =?us-ascii?Q?VgWX4dJGhPeO/JQk6pnp555xDOGPQrD0uY08eAhh6Ju5Z8WqooBsJjgT4oqN?=
 =?us-ascii?Q?5RZhZSvX25ug7mnGiUxQL2KyoqbhaQebsti/5bLobYl+OcTL9sqiwDjw6iuy?=
 =?us-ascii?Q?P6BUxvccPC0iGVdT3jw3PE9gRhPTa6KnGY6yfOlxsxxe9PygYsDF9e6rtm49?=
 =?us-ascii?Q?so87P6FdbsNze0VvxckqfXEWA+Km1EVuau5FEM8VKuYSVLQTAaM5SqcT1+d7?=
 =?us-ascii?Q?rFt94cSWAzina+8dneb4FTT0XXac6ZRpPNt0U0TiYMmFOKXHj/qK5WaajsgW?=
 =?us-ascii?Q?9HEdcqH3ohQuClPT9k3pyKXFclQKUl+agejOMUufnLU/JTyZSEwqu6GZE4xM?=
 =?us-ascii?Q?jV9Xwi0mzMxE638PMfIjXZ4G+e1ppd+XgjsE+xFzydGg0/izIekIrmw/3lkg?=
 =?us-ascii?Q?2f2wddwU+aNCmewhKVuem5MZXhJ58qlw/+/KSHUkYxX+hcbndPj8RwjEpCxH?=
 =?us-ascii?Q?3zNGYha5VItjAxNc3GpULxjllMJGsUBTwU09b5y3Cp7XMo5yLQLGGhEQaIvv?=
 =?us-ascii?Q?USJjyQwZpKIAdJJvMHTd2bIqXVXmZM0YCWI7QDNXmoUmkKLGAedlMXGRFXvj?=
 =?us-ascii?Q?6k0uhycKg8Jw7bFZIaSdmnspMP7eNc4aicCu5clLStuHtyXzADfNCCWPEG3b?=
 =?us-ascii?Q?RtKH3AlvaqAQ8s7IWGl3GBBNbWJZlS5hWSi4S/biIU6SmytICG0QmyNIMJSW?=
 =?us-ascii?Q?s7bwcIpGqdyqvqgPOsbMxYzIBO1nLzXz1p02X9262Ika9zVbdLuvjsMNM5K3?=
 =?us-ascii?Q?jVEuF1JfIpMDN+gtBk236EAU4YWC4VY7bSUXWp2CElVRoET4QKsQhYhZn7jn?=
 =?us-ascii?Q?D5YjklnY7XuekOlL9KeVHQz41Mmjvry8JHCbPYuu4iovExU+MBp07l6cqIgc?=
 =?us-ascii?Q?dSvYJ/x6mvC111Frfk+SyjIJWYQpkZbOABnMpwjOyNUN+M5/hW3N1tvWHEGO?=
 =?us-ascii?Q?ejej4/MAyunSQ9wmcy2LGEE=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c225f979-e148-4ff3-3fd8-08d9ed06b7c7
X-MS-Exchange-CrossTenant-AuthSource: SL2PR06MB3082.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2022 02:32:16.0854
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: I4YxRg1ecI7HlnxWT425FXY4UjVoKm196uJwuFAtIX1YYiOd8+uoj7+n6d7o5Qgax39lGdeRzbAoVI+SjmIuNQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY2PR06MB2895

From: Wang Qing <wangqing@vivo.com>

It is better to use time_xxx() directly instead of jiffies judgment
for understanding.

Signed-off-by: Wang Qing <wangqing@vivo.com>
---
 drivers/md/dm-thin.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/md/dm-thin.c b/drivers/md/dm-thin.c
index f4234d6..dced764
--- a/drivers/md/dm-thin.c
+++ b/drivers/md/dm-thin.c
@@ -161,7 +161,7 @@ static void throttle_work_start(struct throttle *t)
 
 static void throttle_work_update(struct throttle *t)
 {
-	if (!t->throttle_applied && jiffies > t->threshold) {
+	if (!t->throttle_applied && time_is_before_jiffies(t->threshold)) {
 		down_write(&t->lock);
 		t->throttle_applied = true;
 	}
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Fri Feb 11 02:37:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 02:37:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270085.464299 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nILo3-0000ht-Jm; Fri, 11 Feb 2022 02:37:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270085.464299; Fri, 11 Feb 2022 02:37:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nILo3-0000fE-6P; Fri, 11 Feb 2022 02:37:07 +0000
Received: by outflank-mailman (input) for mailman id 270085;
 Fri, 11 Feb 2022 02:37:05 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=+l4G=S2=vivo.com=wangqing@srs-se1.protection.inumbo.net>)
 id 1nILjz-0005DN-GR
 for xen-devel@lists.xenproject.org; Fri, 11 Feb 2022 02:32:55 +0000
Received: from APC01-SG2-obe.outbound.protection.outlook.com
 (mail-sgaapc01on20713.outbound.protection.outlook.com
 [2a01:111:f400:feab::713])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e98dc67c-8ae2-11ec-8eb8-a37418f5ba1a;
 Fri, 11 Feb 2022 03:32:54 +0100 (CET)
Received: from SL2PR06MB3082.apcprd06.prod.outlook.com (2603:1096:100:37::17)
 by PS1PR0601MB3705.apcprd06.prod.outlook.com (2603:1096:300:80::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Fri, 11 Feb
 2022 02:32:51 +0000
Received: from SL2PR06MB3082.apcprd06.prod.outlook.com
 ([fe80::80b4:e787:47a9:41bb]) by SL2PR06MB3082.apcprd06.prod.outlook.com
 ([fe80::80b4:e787:47a9:41bb%4]) with mapi id 15.20.4975.014; Fri, 11 Feb 2022
 02:32:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e98dc67c-8ae2-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=UiQJFTEih73bBALf1QoZYNGQZxJYPwuTMlBHnrxtrv5yt/xNU/2LFRfWOEKHWfXCwiyw5P+O9U2JHHxSJQMc9sisSnt9BdwOiKiv/0SMZOJDHWK8YKEg+WD8TrMt9Hi/RlKL2RlOx8cpoLimvxH0vJe3JLHIOkWpUl6AuIRdr0fsT9brcay5C5xKS7Bdfrx3YJ/ZwUwQW1F6hwWUefkMjwshlri4k3gLtohnKsDmdfPh8+Jf6bMtCB/rJ+wqnyWwchKhAuQrll7eKxc624ohexL53U7JYIVY0dYhY7bNL2VJb96zKYgcIB1LSWoZBu+9jwTEl+tN+Gu0in66AqRDmA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=+UreqemZWhtM2swqJ+H17H399YlhMiGbGC0zkfmGrrc=;
 b=FbK5GvEtTCAJ0klEeE5j/lafBCC7jMN2X5OA+3J+kP1lyJgJTyxyBkgOA5aLBZT0yjqxB146ibxH4ZZuqQf7zpzsc4FvwUUdQFgbZuIBrh7tg4bTfUiVmW5XYXiAluqAn9/Zg5ThGk0VHs9m7U/5RMaZi1beDPXN1l4mAgThREW9DOWDqGAnPM6+Y88mM67NpIrXvaFiOWpLGfxXBJyPSW6T0f9t/2ROGNwK3tvTA3L5+N25Ha4qV1vbaeRYKkMF+Ij0lR4nmMDSNq4WVFsEobnN2t1gf/IE1dUlU60xq7zfB5+JAVYSmdoHtj3lklt/8+SfrHgHMgmcxa5uYog+Tw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo0.onmicrosoft.com;
 s=selector2-vivo0-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=+UreqemZWhtM2swqJ+H17H399YlhMiGbGC0zkfmGrrc=;
 b=ep4/6Byvp6rmc1SWOOXXbvra047BBmWb/rK+CWh3V2GHkhNJsRqncB0kn8KolGU/VweyBYhtXm4596m6gxVgWzs2RByboAqmk8aLsgFS0EVqxOOTwxUESvCFN8laKFmkruLPA0SYcZdU1a/gGSUXxnC7spA63ob1ujffM8wsRdc=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=vivo.com;
From: Qing Wang <wangqing@vivo.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Jens Axboe <axboe@kernel.dk>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel@ffwll.ch>,
	Alex Deucher <alexander.deucher@amd.com>,
	=?UTF-8?q?Christian=20K=C3=B6nig?= <christian.koenig@amd.com>,
	"Pan, Xinhui" <Xinhui.Pan@amd.com>,
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Alasdair Kergon <agk@redhat.com>,
	Mike Snitzer <snitzer@redhat.com>,
	dm-devel@redhat.com,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Hans Verkuil <hverkuil@xs4all.nl>,
	xen-devel@lists.xenproject.org,
	linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-clk@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-input@vger.kernel.org,
	linux-media@vger.kernel.org
Cc: Wang Qing <wangqing@vivo.com>
Subject: [PATCH V2 11/13] media: tda8083: use time_is_after_jiffies() instead of jiffies judgment
Date: Thu, 10 Feb 2022 18:30:34 -0800
Message-Id: <1644546640-23283-12-git-send-email-wangqing@vivo.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1644546640-23283-1-git-send-email-wangqing@vivo.com>
References: <1644546640-23283-1-git-send-email-wangqing@vivo.com>
Content-Type: text/plain
X-ClientProxiedBy: HK2PR02CA0178.apcprd02.prod.outlook.com
 (2603:1096:201:21::14) To SL2PR06MB3082.apcprd06.prod.outlook.com
 (2603:1096:100:37::17)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: cd8769e6-d363-4ee5-4a94-08d9ed06cca8
X-MS-TrafficTypeDiagnostic: PS1PR0601MB3705:EE_
X-Microsoft-Antispam-PRVS:
	<PS1PR0601MB370540B185341396776FBE22BD309@PS1PR0601MB3705.apcprd06.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1751;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ap7cwPaUAtNcN60g89R7HvJFIlY8DkMtY273D4LMkoqQfd0JkwOfeTniOqvhhDmdcgQDoqcPA+4JIUnqYVEvpMY3Dxu5BQDVnVr29loaChOH8HquGgiN1QPnQIDczyyXWE+CPfDW7TkI7i128MAOkSuUSSqTCXm+nek7xImLdHJ1WlMuRK3ZPGskZkhIPdWvW7rIj9hRhyc/4ogsBY02mA7uayw9Ze1gS0Y0YGohY6F56oj7+4rht1taKTFtkFIlyhMFvkPYKUBiSRTveuXc5oIkoDQb38aVSRX1xcLekMs/78YNm2G4OjKFBSOjIlxtBzWkFMELHPNddvn6u65fz/cIsOFhAbPX/QXrBV2KkyczwiR/nvSOLhN+DdFDO1iW7QndGPyE3OMKrRgz6QwvRo3hjL68myq0ILZl3t2QfovI7mikeVch4tNe+YdyuwxuwA/aJTmB+UpBrZVSVjUCQutrMZZP9ZXNBd+57npHdia7GeKv55Yc9y1mTjgeOSnfTd+Ep9SIGtS+Q7Y5Pi1CtTMuTHmF0RL6vIOC9Qm5jY8Gexnsm0e1N4feg9BhxixDxt5E4F1FNiZdlTVA/giIVU8zoBYOM0XTQ+1b8p3CYvzx2wD3W48B3GiuMjwoD6kWJgwYyLgkfqIKArNTlIYdxQRbS9ctwuFMRoxVoyPee0ztOPefN5M1kF/IBa4pwCrMKtlEmRs2DhWxgQQhI0obSfd/E2yhZVh++W0NA9LKTgUqz2Fpe/rDcgwfQDzGpg6j
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SL2PR06MB3082.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(186003)(2906002)(7416002)(66946007)(4744005)(316002)(36756003)(2616005)(107886003)(26005)(921005)(7406005)(110136005)(5660300002)(83380400001)(6486002)(6512007)(6506007)(66556008)(86362001)(6666004)(508600001)(4326008)(52116002)(8676002)(8936002)(66476007)(38100700002)(38350700002)(21314003);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?XvPcCmrYkA7Du7Opc3xsGLAaIokoQ7W1OShKVIydnA+J7YAcXUPMplhB79ad?=
 =?us-ascii?Q?BS1jV2QoRFBmYSqZQgElNmIAUjkiAxOKdm/qa4lVPqW2DdOZvKVWQ0cGw9xY?=
 =?us-ascii?Q?0CAMD2rtEg4e9h8GgWiOH02JP69rahWcYtbq/ikqxOtMql0i1T7GazuXXFjK?=
 =?us-ascii?Q?HABeZfp4WEdy6FhduNh60ZJMfd3ynm2QnV7BJSBWsyeriCUJZ7ZLwAZFn89I?=
 =?us-ascii?Q?ny1flmH1D0EUlGAXmDdIdFcf+okHQKWXY70+Kfkw5n1d9uE0pYXcNSalyEYJ?=
 =?us-ascii?Q?KY4ZxjEaWZANn9DfPu07IcKp+x/ycvKGA5WkYsr6G3zeE4yT8gCyusBQXEmY?=
 =?us-ascii?Q?kR2HnTHczSgnWg5GV+NOToEuJ/x2HkqvWNn6PLjRprHjacRyGHVWPQ+1UClM?=
 =?us-ascii?Q?6ADzqlB0gLDiaedxuLYKler9/eozVLtqOBDW48G2Usp1ZDAmCCl8RUjsSnv6?=
 =?us-ascii?Q?Pq8PapRcBTAuRnGEQVBKmV+8V3yyl25Obo9lT/q044qh+5DrS1HZEq5PNPb5?=
 =?us-ascii?Q?i4sfY5LZGhvDZoGyJTmvPssqm4JzfBsdZGgrYunCMdi1oPCnQ7mJuaAl9FWI?=
 =?us-ascii?Q?pPkn/3DqYYVt+MQ4Z1ZkNXMJreHXOHpxILcCKOjfiBUKsr2QWyQPGd6lafpV?=
 =?us-ascii?Q?YpAPACIvar7lNhGei3TkMwYX8nIfonqCyU++KJVxYnBiavQgpB82cqpPEGID?=
 =?us-ascii?Q?10fzmPpFAXyw0/o+sYDe6Hd7vhNpGaBQ35pyWyprLZoE4gDfCOHX2S3SF9/r?=
 =?us-ascii?Q?/jYsy0Wz4r4p89rH2aliKggG5OzOyBb3JEKB9JkJTJDMZYzfQM5ffQ9tJkbC?=
 =?us-ascii?Q?1YrB7xfaf5QO2LDsra6rhgkfPvUJ8+YYf3FadrvifDHGZ2ChrAUUckkWTqgb?=
 =?us-ascii?Q?d1yPZayI6nq2LTy70KM7y0II7Ah/f+sF/MpfD7KOonHNKT7HDuYSD/TMI77C?=
 =?us-ascii?Q?x1uftmRAxkEZ/S7oKeZh6kUeYA/Enw/exb4hFxz/9PNrBpL+DcYgLFTSIXwn?=
 =?us-ascii?Q?cCG8oj+0rv87jJsNnjdGzx8neujGdRtM+WPFdWsYcQfRYBzBzLjxu/jsLEIB?=
 =?us-ascii?Q?mmdyfXhh79+bLkmtL/suJKl7O6by4z6r/yGen3lxMxX2rhneaeX9SFdAh8aS?=
 =?us-ascii?Q?pAxvQJW3zTGlEAXkSnZJWy5tzgWb4gEiCtJR59EMPl1GjZVlwX061IKIDjew?=
 =?us-ascii?Q?dpXoTnIZncRRuZjeuNoga5f/8bVBcOJuYckD33D5dYsky8erptryBYosZcjf?=
 =?us-ascii?Q?4DzxdHpPOxqErz8MILaTs4zqqjAM1YSrq+5lIKktfVOaEOmH9o0D9GohmtWr?=
 =?us-ascii?Q?HUK9REILIRNJlnIRS0X/VNO8hO4fn88pnY5DQKLCr/L11xTyhxLot/gGGWqP?=
 =?us-ascii?Q?75R/t9t6s6bqCxdyCdzGoJJaxs+qOY9pc4KF7YbKAoj67h0XLyO4NLQThd66?=
 =?us-ascii?Q?hq2NWJVXU7senmUKbKsKi68dyNG2oh1+XuKBYSE77hdLG27BFnWSEVAI4PmZ?=
 =?us-ascii?Q?DASJsafXRxMJrG/rEXeTS8s23Y5aMjwrvGfgwz1EgAXNGxzdmc3BI26eI8FT?=
 =?us-ascii?Q?IEjVHGUQQVrlePgOMkzaCSDEcT0x17+/68J6deTXkvrOUs5rmIao4MTx5mBr?=
 =?us-ascii?Q?NOr2LJNZoFcItflcG2P7krg=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cd8769e6-d363-4ee5-4a94-08d9ed06cca8
X-MS-Exchange-CrossTenant-AuthSource: SL2PR06MB3082.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2022 02:32:51.1459
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FIOV+VJxkJuy36z1KAD455OyGjtcPWPNha6WYplMGJurR2u+NV8i5/TONQWOZGXQcVf1YatOzY/HvVtoXP9poQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PS1PR0601MB3705

From: Wang Qing <wangqing@vivo.com>

It is better to use time_xxx() directly instead of jiffies judgment
for understanding.

Signed-off-by: Wang Qing <wangqing@vivo.com>
---
 drivers/media/dvb-frontends/tda8083.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/dvb-frontends/tda8083.c b/drivers/media/dvb-frontends/tda8083.c
index 5be11fd..49c4fe1
--- a/drivers/media/dvb-frontends/tda8083.c
+++ b/drivers/media/dvb-frontends/tda8083.c
@@ -162,7 +162,7 @@ static void tda8083_wait_diseqc_fifo (struct tda8083_state* state, int timeout)
 {
 	unsigned long start = jiffies;
 
-	while (jiffies - start < timeout &&
+	while (time_is_after_jiffies(start + timeout) &&
 	       !(tda8083_readreg(state, 0x02) & 0x80))
 	{
 		msleep(50);
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Fri Feb 11 02:37:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 02:37:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270089.464314 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nILo4-00017v-TT; Fri, 11 Feb 2022 02:37:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270089.464314; Fri, 11 Feb 2022 02:37:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nILo4-00016l-Ka; Fri, 11 Feb 2022 02:37:08 +0000
Received: by outflank-mailman (input) for mailman id 270089;
 Fri, 11 Feb 2022 02:37:06 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=+l4G=S2=vivo.com=wangqing@srs-se1.protection.inumbo.net>)
 id 1nILkJ-00046f-6T
 for xen-devel@lists.xenproject.org; Fri, 11 Feb 2022 02:33:15 +0000
Received: from APC01-SG2-obe.outbound.protection.outlook.com
 (mail-sgaapc01on2072b.outbound.protection.outlook.com
 [2a01:111:f400:feab::72b])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f57e3d0c-8ae2-11ec-8f75-fffcc8bd4f1a;
 Fri, 11 Feb 2022 03:33:14 +0100 (CET)
Received: from SL2PR06MB3082.apcprd06.prod.outlook.com (2603:1096:100:37::17)
 by PS1PR0601MB3705.apcprd06.prod.outlook.com (2603:1096:300:80::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Fri, 11 Feb
 2022 02:33:11 +0000
Received: from SL2PR06MB3082.apcprd06.prod.outlook.com
 ([fe80::80b4:e787:47a9:41bb]) by SL2PR06MB3082.apcprd06.prod.outlook.com
 ([fe80::80b4:e787:47a9:41bb%4]) with mapi id 15.20.4975.014; Fri, 11 Feb 2022
 02:33:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f57e3d0c-8ae2-11ec-8f75-fffcc8bd4f1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=EzfWLT+EzT+znwPSOPxqYdnBY7QKPKT6xxh7031m/bF047AkYSygyMImdSlJl7Xk1sxpnvkh6zhz7seT2CW96QhxMJVhCqD5LV9WGERMvsE0Gna7L5M2WzS0yXlAPR7duJYN4jTiwVUSsJRlWarXn6MDRZvsxk+C9MBlJdH7vBkECxUkfAgU9ypBlSnYDUa2Swk62MZLXf1oK9+yXkxAJTP2LzqepyjlwULEKvvJFTItqrGP8TVa3Bycl+1ArBaczrzGr2vNhVM+ku2hIYZJFZ/Vg65twefXMjvVUo+OErYjB24sIvIjv4GlqtmlF5scHx/AhB1fV43+Mgfe4EMbsw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ZCGsYVl1Rk2DP391pMDtEyG1sAbTFMqpUMsjQddFGaQ=;
 b=OqMFox67bITNfWyykhjVy4MY+GlnCKsJQHprufDn+2ft5A0WfXVSxd0miXUo+2hqaWTv1OyjH3Yc9wCeTS4evaUftK7N1P2ytElqJHNqBPMzjo/rs9FcBL7XUFpvQoAPYytVsBHlBY/YzqtAX3j3Zfexkin7PIHh+bx4yV0dqfywBE8bBNTZVjcbSl0eIauXfGeP06P6Cj6oyySWn1iiHMbsBLngH5GdjevH+7ZUiF4qfx19fHmbNom3z0efZ5JtUHudRakEKABRCXelIUpeBbU6g48AjqhrrqreAMPceSd9/BsmryGKiH/bGcUJJ8jE5rmT67dyAoq6OeIqzoQ3mQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo0.onmicrosoft.com;
 s=selector2-vivo0-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ZCGsYVl1Rk2DP391pMDtEyG1sAbTFMqpUMsjQddFGaQ=;
 b=DqJJpqg7B6IBOs5Ucw6n44AN6YSysS3ZJS7oPEefh9yBrmUMJsgFMHhtxGGK/+tJRaE4cZBJVBz+RnUZf9pyt39no9qp39jdOhQXTJHvLEwh/SUQt/bMDEIcTE1zmQOFE0fVDdaTF7YddltOn0vCidp4vW/EEAeXfvTrSAEwJsk=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=vivo.com;
From: Qing Wang <wangqing@vivo.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Jens Axboe <axboe@kernel.dk>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel@ffwll.ch>,
	Alex Deucher <alexander.deucher@amd.com>,
	=?UTF-8?q?Christian=20K=C3=B6nig?= <christian.koenig@amd.com>,
	"Pan, Xinhui" <Xinhui.Pan@amd.com>,
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Alasdair Kergon <agk@redhat.com>,
	Mike Snitzer <snitzer@redhat.com>,
	dm-devel@redhat.com,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Hans Verkuil <hverkuil@xs4all.nl>,
	xen-devel@lists.xenproject.org,
	linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-clk@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-input@vger.kernel.org,
	linux-media@vger.kernel.org
Cc: Wang Qing <wangqing@vivo.com>
Subject: [PATCH V2 13/13] media: vivid: use time_is_after_jiffies() instead of jiffies judgment
Date: Thu, 10 Feb 2022 18:30:36 -0800
Message-Id: <1644546640-23283-14-git-send-email-wangqing@vivo.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1644546640-23283-1-git-send-email-wangqing@vivo.com>
References: <1644546640-23283-1-git-send-email-wangqing@vivo.com>
Content-Type: text/plain
X-ClientProxiedBy: HK2PR02CA0178.apcprd02.prod.outlook.com
 (2603:1096:201:21::14) To SL2PR06MB3082.apcprd06.prod.outlook.com
 (2603:1096:100:37::17)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 6ecfda2a-ef55-44e3-464c-08d9ed06d858
X-MS-TrafficTypeDiagnostic: PS1PR0601MB3705:EE_
X-Microsoft-Antispam-PRVS:
	<PS1PR0601MB37053AFD614E2C1FEAFBD6BABD309@PS1PR0601MB3705.apcprd06.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1107;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	gET8Awy8O3rfEJ2KEFZxWC/slmqXyDgtNj99XlkJW1GWzk84hR/TRK5gKO+GMjL72JwFI6j44TQUDhyT7fJawFzngVXOjZNW+FCCe3vSeBoo9xJOKgQxhSWjwsNyPnsN5QtAphPEQowiinJNUfJGXO4YlIGTyoyPK47tqB7e1ELN/au+VZg2KiVmmdlujxOKh/svgY0Btkt3E1EU9XAaEB/fDl1iFeRBWsyOehLabAOAzB+QTpaJiwz7tTdFl1zm2hEOus6Fm0fQfZvqk7e0K3FB0ES4SOOasvK/MidWtWFzOusgZm2g8OODEW2qChgbIg2e82TJhCANYnYxOzi8e9bEKklSRDc45QifSPZODJHCPBiccXPEwJBMtlg27FzB4C/7N9kSCGDwpu8iJx+Azt+wOrawMWlEco+uFtBmgGZCXWpereILX4Rc2jc7V2AGuLNNTs+gOjMB0zGeJEI9X4q4Qq2u181f0/uja1Bfc4bWCt2sagAz/YMuFQU0PyrnOEIrjC+Dip5zndrETRa7qjBq9QY0yRNQrCZX/j8PyOMfxzDS+WLZNHCFxbFearaLwLx0F0UZUycs9wkTmVmTzZPKD3zwVN6eFYLH3eo+zHNWxp5IEa8sxVkNxTP5j1EaArvagxtVMxLVnAleAObs8ibPNXRtibSSfBbfbrNrXK+43VI5q+1mUQsllCh8Oyviqwm46moiYKGuo49/PM7F2RgyY1Echn1GhCN32kJi9/4=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SL2PR06MB3082.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(186003)(2906002)(7416002)(66946007)(316002)(36756003)(2616005)(107886003)(26005)(921005)(7406005)(110136005)(5660300002)(83380400001)(6486002)(6512007)(6506007)(66556008)(86362001)(6666004)(508600001)(4326008)(52116002)(8676002)(8936002)(66476007)(38100700002)(38350700002)(21314003);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?anxVmQzQteJnVybznqZkGfIiz7nVC4C/C1I0BoUPZOiTIogrlkXJQfPjamKT?=
 =?us-ascii?Q?oJ/GBiaYBt42qmKppqJRYlI6K8e8oDSseJKFoNBR04iv6/fm+Lx7GWQvRPd2?=
 =?us-ascii?Q?oa1twpXDMI4qvuvmPwZAkhoKDxF0B174B/eCGvcrZb7MuG3t4wRSryhy++4e?=
 =?us-ascii?Q?x1neH6Wqoj90ulCVvy5lZyrMXkQgTs3QUhg3tOd5nh+d/+3M0Ry0g23wvfNp?=
 =?us-ascii?Q?XjL+GSbFdHDYkdh8FY8WD+0jdtn5kt+zr6DoklFBlihTRmOPDsmAV5lF7ysL?=
 =?us-ascii?Q?7Ot3qkCxkgN6pm8DFreYAQqEpBVcHa9nG/CgeRF7kuwCG4Qp5zSCWpkvAilj?=
 =?us-ascii?Q?+BRyPmamsXHVBCD8KgKSCNvrjxsPNqNfqIOuYlhdCcma00ieIvNk0ZZrkVhg?=
 =?us-ascii?Q?1i6VM7n+qZA599hn/GshE8jQdY3SQ476lJakG6ATJeBo8ph1RCyYfr5vtgx+?=
 =?us-ascii?Q?DuYyutc5Cl7ZbdkYiK0/YjkgOrS6Q91fRSA9ffUTob6enZ3DAwORawFIBL5t?=
 =?us-ascii?Q?CEOPBiHPL4rCujB6wstavCGEUdUniEda70+r8aqtK5YaTkpMa3f/VGGjqYhO?=
 =?us-ascii?Q?RqXiFumiP4zSdqZJULVM5uUUXbVs3ezbCsUaJioSKn0ebUP3bUDyGqPscVKs?=
 =?us-ascii?Q?6SPTJAgp3JhddiZzHFnHbyYlEKO+tPqeIOtQpu/N+JJP+mSJK2CfocrN5A9C?=
 =?us-ascii?Q?H7W35Ydlo5Y7iBCSUa+YM5eGX2PovUV/g5+TJbrVyS1O1VS11FZgsI1ooqiN?=
 =?us-ascii?Q?eY5fqBMZ3IgzHqvBoueLUSCZpUWkoulRF40IN9THC9O2FL4yTz7kJmH6u8DB?=
 =?us-ascii?Q?p4ueZ8ZPfFfUfaser2NE4V2AvtLieom2/4HHb/esIgPzqSNcHy1SMH6Yqu9T?=
 =?us-ascii?Q?ij/kDCVsMQa5ahFGZJicU5qFtwtSDpUMyNkPvUbdMMZkzihwrke1FXD0O1CL?=
 =?us-ascii?Q?LYKOaHRAOc6DGdNZYRTpoNLq047VAMxzRkOHIUUoE5Jq3J9kmtbV+Kk4CVcR?=
 =?us-ascii?Q?/3gPFKfERJ7n2uREHPAqYxq3sjDcxmdPW44xPZKbTq3uE4N4/Z49lO1lzrOE?=
 =?us-ascii?Q?v2a8odAA5+otNk+qAlk0ccQsoMkk3BcwFDNFk7QlIT1UoIrbNhOG3VtEm7hl?=
 =?us-ascii?Q?zI39hCe8/Ebnw4vX6HLRt3KMgLqyCGknQn29QpQgZ/ARx6BCJ19zTEqGeH1F?=
 =?us-ascii?Q?5ocRmCkZMyI8Ke+F6qMylorIcRz6b7721btXextPwLRRMozloFGWmLc5aIb+?=
 =?us-ascii?Q?tMEY/1vMG+D9DmH+eZtYThlQbHn4BQKkZma7/miULWcqc63kQT+hLwhUnj7j?=
 =?us-ascii?Q?v6zcGFy4bbaInAjgb6eoy+3rBMdrA2zJ4VFYdL0zd3z3WxD2sJLfKF35kjEq?=
 =?us-ascii?Q?7wHXFUNq+jRihuVEe2vuTsqTtBwuCDKQW7XklkcaKQ9CZSWh9mt3h7a/jtOu?=
 =?us-ascii?Q?Kg3nYMr0455m7f3VUWVteWlS9A0gtaublibFTjEYc3sGv+xoITeJoQ7Uw+Kw?=
 =?us-ascii?Q?2lWQAREqiQ9wixIO7ywDetYMx7LpB1JoZnJb4gGVHx2QqQPp3bPkXezFKtUq?=
 =?us-ascii?Q?x8GzjbGPH9PpYHBeIIpgbkb8mAtjfKBVfNE8KrxHotMy2YXr+er6qy9SCFw8?=
 =?us-ascii?Q?zXNvEoji+nBbytiph8ID4VM=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6ecfda2a-ef55-44e3-464c-08d9ed06d858
X-MS-Exchange-CrossTenant-AuthSource: SL2PR06MB3082.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2022 02:33:10.8323
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +8mJtO29nBoysTeez6egaCcwz1EVAAOfzUIKKBW62z5C2FaTL3wFUrZi2JsNpYWrBJ5be6JEHEfDI/DMXA3DLw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PS1PR0601MB3705

From: Wang Qing <wangqing@vivo.com>

It is better to use time_xxx() directly instead of jiffies judgment
for understanding.

Signed-off-by: Wang Qing <wangqing@vivo.com>
---
 drivers/media/test-drivers/vivid/vivid-kthread-cap.c   | 3 ++-
 drivers/media/test-drivers/vivid/vivid-kthread-out.c   | 3 ++-
 drivers/media/test-drivers/vivid/vivid-kthread-touch.c | 3 ++-
 drivers/media/test-drivers/vivid/vivid-sdr-cap.c       | 3 ++-
 4 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/drivers/media/test-drivers/vivid/vivid-kthread-cap.c b/drivers/media/test-drivers/vivid/vivid-kthread-cap.c
index 6baa046..295f4a3
--- a/drivers/media/test-drivers/vivid/vivid-kthread-cap.c
+++ b/drivers/media/test-drivers/vivid/vivid-kthread-cap.c
@@ -18,6 +18,7 @@
 #include <linux/freezer.h>
 #include <linux/random.h>
 #include <linux/v4l2-dv-timings.h>
+#include <linux/jiffies.h>
 #include <asm/div64.h>
 #include <media/videobuf2-vmalloc.h>
 #include <media/v4l2-dv-timings.h>
@@ -893,7 +894,7 @@ static int vivid_thread_vid_cap(void *data)
 			next_jiffies_since_start = jiffies_since_start;
 
 		wait_jiffies = next_jiffies_since_start - jiffies_since_start;
-		while (jiffies - cur_jiffies < wait_jiffies &&
+		while (time_is_after_jiffies(cur_jiffies + wait_jiffies) &&
 		       !kthread_should_stop())
 			schedule();
 	}
diff --git a/drivers/media/test-drivers/vivid/vivid-kthread-out.c b/drivers/media/test-drivers/vivid/vivid-kthread-out.c
index b6d4316..13f737e
--- a/drivers/media/test-drivers/vivid/vivid-kthread-out.c
+++ b/drivers/media/test-drivers/vivid/vivid-kthread-out.c
@@ -18,6 +18,7 @@
 #include <linux/freezer.h>
 #include <linux/random.h>
 #include <linux/v4l2-dv-timings.h>
+#include <linux/jiffies.h>
 #include <asm/div64.h>
 #include <media/videobuf2-vmalloc.h>
 #include <media/v4l2-dv-timings.h>
@@ -234,7 +235,7 @@ static int vivid_thread_vid_out(void *data)
 			next_jiffies_since_start = jiffies_since_start;
 
 		wait_jiffies = next_jiffies_since_start - jiffies_since_start;
-		while (jiffies - cur_jiffies < wait_jiffies &&
+		while (time_is_after_jiffies(cur_jiffies + wait_jiffies) &&
 		       !kthread_should_stop())
 			schedule();
 	}
diff --git a/drivers/media/test-drivers/vivid/vivid-kthread-touch.c b/drivers/media/test-drivers/vivid/vivid-kthread-touch.c
index f065faae..8828243
--- a/drivers/media/test-drivers/vivid/vivid-kthread-touch.c
+++ b/drivers/media/test-drivers/vivid/vivid-kthread-touch.c
@@ -5,6 +5,7 @@
  */
 
 #include <linux/freezer.h>
+#include <linux/jiffies.h>
 #include "vivid-core.h"
 #include "vivid-kthread-touch.h"
 #include "vivid-touch-cap.h"
@@ -134,7 +135,7 @@ static int vivid_thread_touch_cap(void *data)
 			next_jiffies_since_start = jiffies_since_start;
 
 		wait_jiffies = next_jiffies_since_start - jiffies_since_start;
-		while (jiffies - cur_jiffies < wait_jiffies &&
+		while (time_is_after_jiffies(cur_jiffies + wait_jiffies) &&
 		       !kthread_should_stop())
 			schedule();
 	}
diff --git a/drivers/media/test-drivers/vivid/vivid-sdr-cap.c b/drivers/media/test-drivers/vivid/vivid-sdr-cap.c
index 59fd508..f82856b
--- a/drivers/media/test-drivers/vivid/vivid-sdr-cap.c
+++ b/drivers/media/test-drivers/vivid/vivid-sdr-cap.c
@@ -17,6 +17,7 @@
 #include <media/v4l2-event.h>
 #include <media/v4l2-dv-timings.h>
 #include <linux/fixp-arith.h>
+#include <linux/jiffies.h>
 
 #include "vivid-core.h"
 #include "vivid-ctrls.h"
@@ -205,7 +206,7 @@ static int vivid_thread_sdr_cap(void *data)
 			next_jiffies_since_start = jiffies_since_start;
 
 		wait_jiffies = next_jiffies_since_start - jiffies_since_start;
-		while (jiffies - cur_jiffies < wait_jiffies &&
+		while (time_is_after_jiffies(cur_jiffies + wait_jiffies) &&
 		       !kthread_should_stop())
 			schedule();
 	}
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Fri Feb 11 02:37:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 02:37:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270090.464321 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nILo5-0001G0-Gl; Fri, 11 Feb 2022 02:37:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270090.464321; Fri, 11 Feb 2022 02:37:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nILo5-0001DN-70; Fri, 11 Feb 2022 02:37:09 +0000
Received: by outflank-mailman (input) for mailman id 270090;
 Fri, 11 Feb 2022 02:37:07 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=+l4G=S2=vivo.com=wangqing@srs-se1.protection.inumbo.net>)
 id 1nILjX-0005DN-Ix
 for xen-devel@lists.xenproject.org; Fri, 11 Feb 2022 02:32:27 +0000
Received: from APC01-PSA-obe.outbound.protection.outlook.com
 (mail-psaapc01on2072d.outbound.protection.outlook.com
 [2a01:111:f400:feae::72d])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d91027d2-8ae2-11ec-8eb8-a37418f5ba1a;
 Fri, 11 Feb 2022 03:32:26 +0100 (CET)
Received: from SL2PR06MB3082.apcprd06.prod.outlook.com (2603:1096:100:37::17)
 by TY2PR06MB2895.apcprd06.prod.outlook.com (2603:1096:404:31::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.17; Fri, 11 Feb
 2022 02:32:23 +0000
Received: from SL2PR06MB3082.apcprd06.prod.outlook.com
 ([fe80::80b4:e787:47a9:41bb]) by SL2PR06MB3082.apcprd06.prod.outlook.com
 ([fe80::80b4:e787:47a9:41bb%4]) with mapi id 15.20.4975.014; Fri, 11 Feb 2022
 02:32:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d91027d2-8ae2-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=GUyznWgZuzDBHHk8bhhKsOaQrI8+HfR4UD2AeWIqP2UBi6gGUTmvgzXGONB8c5xm+tpHE+cvnpdD5M2er7CDpItRSPpKtXanQfJghe8kqXP5MRG5vlOFjp7CgxXC3EWV0OYnO0hE6IWCkZbUWbm2NWtBIXL1GAvqWH3/h5iCdH8m1N+WeZU6db27z3w+F3RqSis2QE4e6Xg4c4DtXDNGzRJRKrpeTDL/eJ6hPWYJvpkJO0r5YnBbLqniNUFesFtWIwCqoCzmMrN6Cr32xYeCcEpJFeyfeuouH9nkgiSVfyk/07crTNlmH59H/qvq54YO70Kb9sDRYhyYyyFTTTeTyA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=GX+nOYxisljzrKTgPKcHNVXPHiBaBNm1rCGL/Hfu0io=;
 b=kSAropA30K0hq1WglqOOhRRxLrcNu9TsVIIDwPM1SPWUWsM7XKAAnoPyM4z0PjBSf6LxY/fCMmSUY6uGr1/QGD8lawlpdCk6PrY00mHlzx+ZP7Vsyo9XDr1vGwnXYlQqoGvmyaSyj3L/3PjZ5bI942KRpbcf+4D2VoLGCGGTEQ0g2yUtvglFFA1bk9P139RDTBLzydNY7G2VXkfQlQQeSszHEb/C735n/y5ntIia360JC7f8hNTrpDYhrichejbGtbFAz2zcdnMwRGpyczic0tNlWAuM41W6rGCskmzpg0jgyMY5/FIj32R6bN1G4VhQIvZAzTyL72t+VYsQHgJK6g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo0.onmicrosoft.com;
 s=selector2-vivo0-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=GX+nOYxisljzrKTgPKcHNVXPHiBaBNm1rCGL/Hfu0io=;
 b=MrEOAevPxCNjl2YjyKrIEp32HF6lZG543aFtZHJQVfoFKWs9D6p7tBil8ZzyVbssPfuQJLGGK8NV9jAATBffofMh6jBu/zNdbevav+z1S9iTHGUYlp96wSRQYu9vyKzjohjU8VHV0FuZ1NaUIaI2Yf7Ix6SGdHqwnLwhrZK4rx0=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=vivo.com;
From: Qing Wang <wangqing@vivo.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Jens Axboe <axboe@kernel.dk>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel@ffwll.ch>,
	Alex Deucher <alexander.deucher@amd.com>,
	=?UTF-8?q?Christian=20K=C3=B6nig?= <christian.koenig@amd.com>,
	"Pan, Xinhui" <Xinhui.Pan@amd.com>,
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Alasdair Kergon <agk@redhat.com>,
	Mike Snitzer <snitzer@redhat.com>,
	dm-devel@redhat.com,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Hans Verkuil <hverkuil@xs4all.nl>,
	xen-devel@lists.xenproject.org,
	linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-clk@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-input@vger.kernel.org,
	linux-media@vger.kernel.org
Cc: Wang Qing <wangqing@vivo.com>
Subject: [PATCH V2 10/13] md: use time_is_before_eq_jiffies() instead of jiffies judgment
Date: Thu, 10 Feb 2022 18:30:31 -0800
Message-Id: <1644546640-23283-9-git-send-email-wangqing@vivo.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1644546640-23283-1-git-send-email-wangqing@vivo.com>
References: <1644546640-23283-1-git-send-email-wangqing@vivo.com>
Content-Type: text/plain
X-ClientProxiedBy: HK2PR02CA0178.apcprd02.prod.outlook.com
 (2603:1096:201:21::14) To SL2PR06MB3082.apcprd06.prod.outlook.com
 (2603:1096:100:37::17)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5fda17dd-7627-4ed7-980b-08d9ed06bc3f
X-MS-TrafficTypeDiagnostic: TY2PR06MB2895:EE_
X-Microsoft-Antispam-PRVS:
	<TY2PR06MB2895B4FB384B056A69641E17BD309@TY2PR06MB2895.apcprd06.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2201;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	vCcORnvvTaCSGSUv6FaIVzz5fCHZQ39cob3rnZpeEfCgUnbOK6Ew3NujI4eQj4E6oemaWr6sQuTR4A+q1KW18wwDu5rbt7uw9pJToWNslEEhlHV0id4DO7YP3t3NBlDMWwk0M2ZXpl8F4Th41pQMyhoDztMo8QFRjQraRlRMbOV0EPCsMIo/NkoKXXpupiBsTyN/P7/T0ytRY5MFfRGEqx0BtqPZP8o9TEXlYDrOkScovmHB85LxDA++EuFd/41ONgLFun5G1fnn9C5CoUVs44dSu3qtyWKjQklGYWE+OM0pZAmru4SjPLBGbCGsnGKWasxK5bUhg1IwDDnOjwEjjUcN1ofLzSbxO1vgAYLb44uYy/nD9V8RwXdNYJdmpIhtPbdXidXC8VFSS+EUh4OnqcOhL+uFVXQml/bWG/IZhOXmFXXbo/qb1EWeE7wfL9yJgXCpiCYqEwBEXPf9GwLRkT6zUQ6pgNH361lC3KflPMABa9Pg5UUyRBNuHEzGTmY7kuDxMFHuSZhHVoOSGeV7o8YpxAoBgYyONdV6B9DroPET5JQ0OqUXM8tmof2wrr4F7B1/x4fg14kMobLWHPQlmjzX0CkpYGPrBQm+PkFHBlWxbjBmoo+vo9NVX5+IiIoUXRtmXTuDXAK0YcRLfElMlyiLA2SUTBIYe736SE2WmKAUzPs3tr+6xT8M9z99sFbvox3OimyVqhj5XsGnb8qfSKKUuyD0aj35hxDZW5fM4bnizguaPFCSoJ7trriVtW0w
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SL2PR06MB3082.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38100700002)(2906002)(316002)(110136005)(86362001)(6486002)(38350700002)(6506007)(6666004)(26005)(186003)(2616005)(6512007)(5660300002)(8676002)(7406005)(508600001)(36756003)(4326008)(8936002)(83380400001)(107886003)(921005)(52116002)(66556008)(66476007)(7416002)(66946007)(21314003);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?5RLiO7j5eiRGWiybTSbw3O5WAF60yB9HB5/fjAxP4Yq0I6DWM/DVOs4m4+yO?=
 =?us-ascii?Q?oWTzpWXkZsIMleQXe1Q9OQbxEO2c3Yk8DzMvc8J78zY0HlCy35rlHbHQCgpx?=
 =?us-ascii?Q?9XQnRLIWXblEAAvckGpikNanBded8bjlA3FDpRX+jShHcFT2cRyDy8P1Flp+?=
 =?us-ascii?Q?hNnhCvVNvDN8ootk4WKUe276uSIBohcDJK/nwsUtBFP87fodZC5XYPdEOMZz?=
 =?us-ascii?Q?5GbV5WZbinCC0i5eDvxowd5t+5fdnjAvfTr+HMu7HH16JPwQDJsryJy/jRLM?=
 =?us-ascii?Q?D2aoFtXuE2CyURZ9sV2yoo672NKu0B8+C7YldGKfWJptMf2SAVV5a0+D8BvC?=
 =?us-ascii?Q?8zMypXSeoGxjnvw8Qel/DE2ctYSeeXvY8iNpeTIBZQSuC5zOHmYYBAfJjle4?=
 =?us-ascii?Q?EBWqsIrT+SJxIh7Tsri34OvuvQ+qo42aALsuCkx3FQbMJf8ZofESmYR6fPI+?=
 =?us-ascii?Q?ASrPeAuZOebLFsOZL4+OhUUiWlLQPpotil8EWtY+57/kqrhdO0KMq8HRI8Ru?=
 =?us-ascii?Q?4mZvt92T966UjrKkFRb0/5AZHuF8wa1spXxT+DEUnGVqz8UM21idUGhfY07H?=
 =?us-ascii?Q?7z9LZ2IhHWWcf6dvU/v0gnYkOg/prTqwapL3ARZtlvbEX7V+0n1oJm8mJDzH?=
 =?us-ascii?Q?j9oXju/0ax9vMtQFLmT3/vqK3JF1IDXTFWwC1BhaI/EvwubO9Skp4fBZXZVu?=
 =?us-ascii?Q?EhWhnaWxg03WWv0kg8DW8DU0MhQvhdGDYZA/SqaAvcTOnQGlQD8ajN2sT7Iw?=
 =?us-ascii?Q?bFPomPh7eWZDHy8IZlxT6/Usc6oYJoWW9Se2V9Btk9ldiDIvmndUjBBdq/v4?=
 =?us-ascii?Q?v7/BAOqakLZmxMsb3bMDsshP99xGAe4xa4seGrhkwDgGH+ehbVhC4Axu3xqY?=
 =?us-ascii?Q?2mOSUDJCeIj5248dR3xklP5CDZodjieTaUN7cBZOCJP2AeWsdYgepP0hX4JW?=
 =?us-ascii?Q?+YaV5iYqo0LOfHhqY3pDFafu1PQZmXj3y7jRb6n3QpNmEKdN6dSc9aUQwNUV?=
 =?us-ascii?Q?LwY46BcW1X65EfU2TxyPvuinkSSdxZRn49DGM4FwtsS1bhccE3ILMlKT6Vnm?=
 =?us-ascii?Q?VtM1T4QrGP+KxkJvZ1UnUGUKWu+rkKtVdlmMiHkwLID2K0kMTKOXwh4b5zph?=
 =?us-ascii?Q?o+XrjKZqC//xVTnH7MCjPV0do1fQEH0BPIdEcNn7hm+ptLW6+JI3bAHfWVSZ?=
 =?us-ascii?Q?qeGKZLSgJDVo9QwYz4wNMQ5+u8E4xzUrbwzkad4qLwROApJrECCD43rqvS6q?=
 =?us-ascii?Q?NgzpT3cteNQkYfBMUVidlx3QHcb9Cs6BVbMuzf6hweS0JbJ00jzYXXnRCy8e?=
 =?us-ascii?Q?msLla6q7vSVTR4FXZ84UHO7RnMrQw4J4jGhtMTBU667TDFJqKa7PxsxYtvhy?=
 =?us-ascii?Q?B2c163F/H93oCjmCS5ufoL4YMrsn3Ts8KeQ6w1nCbDsiuQ+8H8fKZEr+e9g2?=
 =?us-ascii?Q?uZ9gWcL4DEEsQz5KJ2QLYKRAj7znDtEeZL9Rhig787sK8XEdTsAZHJxKBwGk?=
 =?us-ascii?Q?SiNSg03r32GCvAvE8kPmkYxPW7UrgWb/tmXIZaIMPM6yMughmIgO1OQSjVi2?=
 =?us-ascii?Q?Cr3E+iz+S+VxQ7S18KV68uAywtwOyTpreCAAusTYEIt+N2oOcW2qNL8L0X5j?=
 =?us-ascii?Q?1gX9kV7UWJmmNJH5WaVJGeI=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5fda17dd-7627-4ed7-980b-08d9ed06bc3f
X-MS-Exchange-CrossTenant-AuthSource: SL2PR06MB3082.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2022 02:32:23.5381
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Vi3vLXcRyS7gacphLwGgMPrALLyerptZ8f1fPbKHYXREiSfPa/Gb70a2fmKlyVurJ2uQiP6vzh+L4l9Bsyj0ew==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY2PR06MB2895

From: Wang Qing <wangqing@vivo.com>

It is better to use time_xxx() directly instead of jiffies judgment
for understanding.

Signed-off-by: Wang Qing <wangqing@vivo.com>
---
 drivers/md/dm-writecache.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/md/dm-writecache.c b/drivers/md/dm-writecache.c
index 5630b47..125bb5d
--- a/drivers/md/dm-writecache.c
+++ b/drivers/md/dm-writecache.c
@@ -16,6 +16,7 @@
 #include <linux/pfn_t.h>
 #include <linux/libnvdimm.h>
 #include <linux/delay.h>
+#include <linux/jiffies.h>
 #include "dm-io-tracker.h"
 
 #define DM_MSG_PREFIX "writecache"
@@ -1971,8 +1972,8 @@ static void writecache_writeback(struct work_struct *work)
 	while (!list_empty(&wc->lru) &&
 	       (wc->writeback_all ||
 		wc->freelist_size + wc->writeback_size <= wc->freelist_low_watermark ||
-		(jiffies - container_of(wc->lru.prev, struct wc_entry, lru)->age >=
-		 wc->max_age - wc->max_age / MAX_AGE_DIV))) {
+		time_is_before_eq_jiffies(container_of(wc->lru.prev, struct wc_entry, lru)->age
+		  + wc->max_age - wc->max_age / MAX_AGE_DIV)) {
 
 		n_walked++;
 		if (unlikely(n_walked > WRITEBACK_LATENCY) &&
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Fri Feb 11 05:48:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 05:48:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270146.464344 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIOmn-0004wv-IO; Fri, 11 Feb 2022 05:48:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270146.464344; Fri, 11 Feb 2022 05:48:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIOmn-0004wo-FT; Fri, 11 Feb 2022 05:48:01 +0000
Received: by outflank-mailman (input) for mailman id 270146;
 Fri, 11 Feb 2022 05:48:00 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=r224=S2=yahoo.com=akm2tosher@srs-se1.protection.inumbo.net>)
 id 1nIOmm-0004wi-3S
 for xen-devel@lists.xenproject.org; Fri, 11 Feb 2022 05:48:00 +0000
Received: from sonic301-57.consmr.mail.ne1.yahoo.com
 (sonic301-57.consmr.mail.ne1.yahoo.com [66.163.184.226])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 29e8efed-8afe-11ec-8eb8-a37418f5ba1a;
 Fri, 11 Feb 2022 06:47:58 +0100 (CET)
Received: from sonic.gate.mail.ne1.yahoo.com by
 sonic301.consmr.mail.ne1.yahoo.com with HTTP; Fri, 11 Feb 2022 05:47:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 29e8efed-8afe-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1644558476; bh=NJUsUfy1KsoFeXHdLDpt06Pj9Ne6C/vdf87oFv7YGys=; h=Date:From:To:Cc:In-Reply-To:References:Subject:From:Subject:Reply-To; b=gOP2E5nqruk3uVj2VwEtnJt3KygDm/SJgt1ZiwAUMTrDT/4r1Ar9qIuTy5fum6elW9amPycYKfT58V6Zax0jIA14cag4Gv8+udDU2U0760sZnNFRHuw7tmCH141kjtWMReuZ/EBDw2SWB98NP62BUxBemfr8rlw/EGEyeRJ8WuxuFZrDpWaEqg3csi/qFJ3GzMnTwGJGCqsdeIKm+HDe+j5UZdlLW6dSRRnb00qSMI7jjpRTvPHMKGDfgmdpB1Zy40Mr/Pyr/J37xxgKFCyWA0XmBl8NreqMJ12oOoPQBwVBS7neg/5LZ2zGfmuYnvC3Fzy7yzUl0T/940ue7gkRGg==
X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1644558476; bh=DKo1hy9Kzmup31vQEJ8THfXnIQUNSLLt07GgSVPRMxO=; h=X-Sonic-MF:Date:From:To:Subject:From:Subject; b=HR+t9pgFCzrY/VaAJALzNzBPIA8VTSp43MHLTdyA9+BzWCEQxwIe+GWNctIXUPt9/AlGzu9A62ts+4pXKsjjy3I6SgbZDNoybdNy9UOW2qgxZOTj52Y8qrVY7B3WcvVUaiOsFQAmVkpOwNVvgbyhbyK1VqtYa0BdEqZ00oNAZry0HgS0H0saOGY1BuluCpZoP/ng/Rs4WVdT9Z8vTlv87ANFPbvOVRhEV3dBWlXajlrUI3YgAUue8QOIYdE+b+YGM2Ke7YRdd+piN/xnfcFJhCi4daALomb/yndZBMj0ICH7BSDii6tFp4CvbGdAMCBG0hrkG4IHAXJqKkdlVuwQBg==
X-YMail-OSG: XZwBRokVM1mz1CW9dEJH5.UZsx2gipk3lw9Nd_KfBiexxJk9NN7GtUsdIgeblS3
 LKgTTQISh7RKFmM20y.cddZUtSCgTS0MopU7IizU_WuyfeKN2xELwXnvI7ubcNKMvUGdy1yWbhtp
 NoPfxLrNFJayvXPYAGDNQXz95zkDcrIYyMbD8fsFGaBSHeLsifC30kO4c5qrDL9Jk5z9A8UxKqNM
 FcZbFGmuXvsGmjU.q1NtPWPWhrqVGUwOpWWqt3I.x30TEZJzBVjkvPo95Ac61faCqDGqRtaE9CFe
 Tl0_px5SHhdamH4pPOoxpR2Op_SwIg5t_CIUYi5EkGTDTxAaAX8Iz6DQF1heWeKjfAVXBqOBsrvN
 I8W4Z5hrteUwQLX1C3j9F44dGW44aCsKblKAPW9QLMeZkdad1g11_3IFWDHLCbgwDAaq2BWH2rO_
 YGvkn0LFTKkxhbEFdgG9981rg_eB91TQr4u27rf.hpM5SH86vEJe7XPWrVgEtkxTWW3r7.b9oW6Y
 Zz8Ema.Uz_rMV8aCl7O0CEL15WXm6OPgWST2JjXIEIKJOQdoQf3x6dZRVP1rfjnOfWoGhNcOkJwD
 iWBfPON9UD1BWohbMCuCXHP052Kdhf4_p.gXSLlRHXjfpdkeDIfi1nxtM4whqYDIHVWLBmL9SjKu
 2eJyy.afrzlheUE2yBs7PSPq_o5goF3QbaSx5beiurpG59gEGYnd1LTC22ch32SAjJ0Gb3kOrDaH
 sDTMuAy2cZ6gbp5CSNACn0vPHi6BOyV5LbOKrFtZ1qxXebq40Jx15LA.Dmi.8uN4Ur5DFfWW.YZO
 B0gn9MUJaDcO4L.N5g98YGUXfZ.Z9nEufFNbG0N0eODSL2HE3wo8wJ_nixTzLYWh66najArnm7DG
 WH323maAJXk2wR10STP960FmOcMiFIQnl99pabtYDpFcVyCq1khKP2bUnXG4RqjaII_7MKlVrNdv
 PQRbK_wkeIYHCB6VLdWDROhf0258BWbaJUvuAnm5MamqkSbI.d6cQqmh3Mh4IAYcdevbTj3Ghyeh
 rTfQSYtwR2LKHZo1WJ8PewbVIOCSZA5fBxtDeqMm3qXKfFKnu.gaAMbpyyv7brR9L7olDIt19Fg2
 MMWJFMTuwobd3QoOniknxkvKLcR7v9QFQ_VUk8aq.5a1rCtdPJZW0OBntNkRHblDcaksRuEXEhFo
 ZE09Pz4Iv_lMx_aZzNR68sdcJpASZT_Bg4RXDq8XPgL7ywS4nj0sSP0bLhMpWedMjQd.sClcYlK0
 RrwMOY7QNBICmZLMr9yDIen9VBHjsu_CnXrWLXRVXvIvDYQV8q1PVWOByhn6jxmHDxmQQbGQKPxv
 GHuvgE8IKCVAzRyLW.tOm90R52DenGctJvnR1FmgRuIYWRnOVUT21sY0HHxhFqRIKdnMEJS9.l3x
 6snsuEH7yfOwQCT4e6HzShrANmQGpn3_eBXxTaJmAkUu8Yeb_6dmgE.tK_eDzPeodjj_3Z3WJH1M
 6IlM7k9GA2.i3ZTzldxNUr3ELHAuoqV8PYeO7clC.Ju_6eKuOJVwmu14HqK6lf0GlH.sQBdxkmHh
 ZAYUP.0ivpJb1XaQZfwjp9zK6aCzd63jU.vyjOhlDhylFWt_i91.sOlicfNJcKkdhL3j_MTdknm8
 LbQjUES6nPWy1SzdQR74Sn28VFBVuIhvhiIyeIdkWp2k1swe1kpcCYGfUC4SNHHNqvFZuS3FiPRi
 Jq7SD6d7GBR5n92X_JbuXHwI.UwtpQiuvvC1U6yZA6wvmHkuqv1x.Eb9UCHOyGE0OOu0uVDgs5Ng
 1YqpeUu1A29UXbNbJSp_Bc_bTSzREULPUckUlqz1pGTbNkfU4E07Pd_uAODCcP2qoTjeCfR8Kq1F
 Vv5mZGbXeDGPJUAyp7ms54gdu9Hxz7wkCyy47vmwcH1WEMnWiAsGg.1TK6qQgL02c4NEwQOKXTc9
 8KbJC.Nm06UAobbQSEPoMjKhoSOfBIAJ0uenQwrbK_4RmVyC9UH_Au8X0PITHeo7FGCiTn54UuTY
 ICYE5yu7Ai_0m3gCgo5g_sT4B2.MSiXs.1hqiEfSOJO4g_zDCzGWJjAelUiDH073TJI9t8eTURgg
 3G7TbZkYM68Ctq9I6kgvNVc2FTYav5hhVJVv7VjPTK.8y0EQ1umPdN3b17PimGr7Eu2nHSAhgcV7
 USEmhsivHFbrbt83hNHDYO1T9enZwybRvl3DuHeDi3mZxUS8ELWfAnb4AA1EnIuDymVzeXosDRpf
 kNDoero_x6hp_9LrTioRmaX33gok7vjyrQYvPVa0HYQeg
X-Sonic-MF: <akm2tosher@yahoo.com>
Date: Fri, 11 Feb 2022 05:45:55 +0000 (UTC)
From: tosher 1 <akm2tosher@yahoo.com>
To: Bertrand Marquis <bertrand.marquis@arm.com>, 
	Julien Grall <julien@xen.org>
Cc: Jan Beulich <jbeulich@suse.com>, 
	"roger.pau@citrix.com" <roger.pau@citrix.com>, 
	"xadimgnik@gmail.com" <xadimgnik@gmail.com>, 
	"oleksandr_andrushchenko@epam.com" <oleksandr_andrushchenko@epam.com>, 
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Message-ID: <181735623.1079390.1644558355560@mail.yahoo.com>
In-Reply-To: <8706c283-80c0-5fea-2834-1bf574e75470@xen.org>
References: <709142925.628001.1644127197288.ref@mail.yahoo.com> <709142925.628001.1644127197288@mail.yahoo.com> <0e64c52c-1e9c-e89b-abb8-50171d885926@suse.com> <303292590.682317.1644477758255@mail.yahoo.com> <2CDAD7A1-A628-4491-9DE0-1F4D5D9FF1A7@arm.com> <8706c283-80c0-5fea-2834-1bf574e75470@xen.org>
Subject: Re: PCI passthrough support for PVH mode
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Mailer: WebService/1.1.19724 YMailNorrin
Content-Length: 1073

Hi Julien,

Thanks for the clarification!

Regrads,
Mehrab






On Thursday, February 10, 2022, 06:12:53 PM EST, Julien Grall <julien@xen.org> wrote: 





Hi Bertrand,

On 10/02/2022 08:32, Bertrand Marquis wrote:
>> On 10 Feb 2022, at 07:22, tosher 1 <akm2tosher@yahoo.com> wrote:
>>
>> Hi Jan,
>>
>> Thanks for letting me know this status.
>>
>> I am wondering if PCI passthrough is at least available in Arm for other virtualization modes like PV, HVM, or PVHVM. For example, is it possible for someone to attach a PCI device to a guest domain on an Arm machine and use that domain as a driver domain, like we can do with the Xen on x86?
> 
> On arm there is only one virtualization mode which is equivalent to x86 HVM.


I would like to correct this. Arm guests are more equivalent to x86 PVH 
than HVM. For more details, see:

https://wiki.xenproject.org/wiki/Understanding_the_Virtualization_Spectrum#PVH:

This is also why we need a brand new solution for PCI passthrough rather 
than piggying back on what was done on HVM in QEMU :).

Cheers,

-- 
Julien Grall



From xen-devel-bounces@lists.xenproject.org Fri Feb 11 07:24:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 07:24:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270153.464356 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIQHf-0006Fj-JU; Fri, 11 Feb 2022 07:23:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270153.464356; Fri, 11 Feb 2022 07:23:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIQHf-0006Fc-G4; Fri, 11 Feb 2022 07:23:59 +0000
Received: by outflank-mailman (input) for mailman id 270153;
 Fri, 11 Feb 2022 07:23:58 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=WJSo=S2=amazon.de=prvs=034f27e45=nmanthey@srs-se1.protection.inumbo.net>)
 id 1nIQHe-0006FW-64
 for xen-devel@lists.xenproject.org; Fri, 11 Feb 2022 07:23:58 +0000
Received: from smtp-fw-33001.amazon.com (smtp-fw-33001.amazon.com
 [207.171.190.10]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 90f0f512-8b0b-11ec-8f75-fffcc8bd4f1a;
 Fri, 11 Feb 2022 08:23:56 +0100 (CET)
Received: from iad12-co-svc-p1-lb1-vlan2.amazon.com (HELO
 email-inbound-relay-iad-1d-28e6dbd8.us-east-1.amazon.com) ([10.43.8.2])
 by smtp-border-fw-33001.sea14.amazon.com with ESMTP; 11 Feb 2022 07:23:38 +0000
Received: from EX13D02EUC001.ant.amazon.com
 (iad12-ws-svc-p26-lb9-vlan3.iad.amazon.com [10.40.163.38])
 by email-inbound-relay-iad-1d-28e6dbd8.us-east-1.amazon.com (Postfix) with
 ESMTPS id 8CA8C85CF3; Fri, 11 Feb 2022 07:23:36 +0000 (UTC)
Received: from EX13MTAUWB001.ant.amazon.com (10.43.161.207) by
 EX13D02EUC001.ant.amazon.com (10.43.164.92) with Microsoft SMTP Server (TLS)
 id 15.0.1497.28; Fri, 11 Feb 2022 07:23:35 +0000
Received: from u6fc700a6f3c650.ant.amazon.com (10.1.212.14) by
 mail-relay.amazon.com (10.43.161.249) with Microsoft SMTP Server id
 15.0.1497.28 via Frontend Transport; Fri, 11 Feb 2022 07:23:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 90f0f512-8b0b-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
  d=amazon.de; i=@amazon.de; q=dns/txt; s=amazon201209;
  t=1644564237; x=1676100237;
  h=from:to:cc:subject:date:message-id:mime-version;
  bh=zl2hAijnvF/MJAtZnQoIh1zN4LcKIlxC/r+GBagwz5g=;
  b=kjGB1t6gJSb4sF0WTJbT3IxbhOHmhXPVGKliaREZHDNamIAmHWehpHvg
   YevS1aYWA54UBPra+k4FhvUTcnC2/xCun+2+tAfrX74iDGiAxAK+OaWX1
   +pfTpJDW4Nl0E+MeoaBFtUggWRUTYPkW/JUNavJ7Hni/M8WaK1PvzzxKY
   M=;
X-IronPort-AV: E=Sophos;i="5.88,359,1635206400"; 
   d="scan'208";a="175404920"
From: Norbert Manthey <nmanthey@amazon.de>
To: <xen-devel@lists.xenproject.org>
CC: Norbert Manthey <nmanthey@amazon.de>, Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>, Wei Liu
	<wl@xen.org>
Subject: [PATCH CPU v1] cpuid: initialize cpuinfo with boot_cpu_data
Date: Fri, 11 Feb 2022 08:23:27 +0100
Message-ID: <20220211072327.1213-1-nmanthey@amazon.de>
X-Mailer: git-send-email 2.17.1
MIME-Version: 1.0
Content-Type: text/plain
Precedence: Bulk

When re-identifying CPU data, we might use uninitialized data when
checking for the cache line property to adapt the cache
alignment. The data that depends on this uninitialized read is
currently not forwarded.

To avoid problems in the future, initialize the data cpuinfo
structure before re-identifying the CPU again.

The trace to hit the uninitialized read reported by Coverity is:

bool recheck_cpu_features(unsigned int cpu)
...
    struct cpuinfo_x86 c;
    ...
    identify_cpu(&c);

void identify_cpu(struct cpuinfo_x86 *c)
...
    generic_identify(c)

static void generic_identify(struct cpuinfo_x86 *c)
...
        if (this_cpu->c_early_init)
                this_cpu->c_early_init(c); // which is early_init_intel

static void early_init_intel(struct cpuinfo_x86 *c)
...
    if (c->x86 == 15 && c->x86_cache_alignment == 64)
        c->x86_cache_alignment = 128;

This bug was discovered and resolved using Coverity Static Analysis
Security Testing (SAST) by Synopsys, Inc.

Signed-off-by: Norbert Manthey <nmanthey@amazon.de>

---
 xen/arch/x86/cpuid.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/arch/x86/cpuid.c b/xen/arch/x86/cpuid.c
--- a/xen/arch/x86/cpuid.c
+++ b/xen/arch/x86/cpuid.c
@@ -609,7 +609,7 @@ void __init init_guest_cpuid(void)
 bool recheck_cpu_features(unsigned int cpu)
 {
     bool okay = true;
-    struct cpuinfo_x86 c;
+    struct cpuinfo_x86 c = boot_cpu_data;
     const struct cpuinfo_x86 *bsp = &boot_cpu_data;
     unsigned int i;
 
-- 
2.17.1




Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879





From xen-devel-bounces@lists.xenproject.org Fri Feb 11 07:28:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 07:28:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270160.464367 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIQLY-0006uB-4K; Fri, 11 Feb 2022 07:28:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270160.464367; Fri, 11 Feb 2022 07:28:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIQLY-0006u4-1I; Fri, 11 Feb 2022 07:28:00 +0000
Received: by outflank-mailman (input) for mailman id 270160;
 Fri, 11 Feb 2022 07:27:58 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=XOdK=S2=epam.com=prvs=4041dc41fc=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nIQLW-0006ty-09
 for xen-devel@lists.xenproject.org; Fri, 11 Feb 2022 07:27:58 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 20e4782d-8b0c-11ec-8eb8-a37418f5ba1a;
 Fri, 11 Feb 2022 08:27:55 +0100 (CET)
Received: from pps.filterd (m0174680.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 21B71tI5023747;
 Fri, 11 Feb 2022 07:27:43 GMT
Received: from eur05-db8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2113.outbound.protection.outlook.com [104.47.17.113])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3e5k28836y-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 11 Feb 2022 07:27:43 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by VI1PR03MB6240.eurprd03.prod.outlook.com (2603:10a6:800:13d::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Fri, 11 Feb
 2022 07:27:39 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::fc4d:4749:5d1:eb73]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::fc4d:4749:5d1:eb73%4]) with mapi id 15.20.4975.015; Fri, 11 Feb 2022
 07:27:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 20e4782d-8b0c-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=D74AKi+Ndk9NuworDKYwWYTCpMAjWBZ25ZG8rFJdncPI+JbY3tivRFrk9gLmuwfc9ThS3svFE0bYXkeJ41qTczpqw8IB+2cAsx7Y3bURpbzS1aMA4aDeq62RMIAjB85lXJFt1RHpiPoIBRDLPoILQayQa9swRP+DwTq+A+QBWNuePWwx9C4nPMITrcdUMu4e5dYjnOr5LkpN06FDszd27rAUWA+XcveoZdcp9gePj8BHNw2AdiaU5SyI5s8sB8k8a5xUeAvYZthuN+yVMHX8+Arz1/t67dsOsuA6dbKd2wIMcujRiNjj6cwbXtq40JZC9Du9AAPE3uM91d7G5YQinA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=RH2YM0lxfPWVymnBpZdpVYUeUf/4XqOhapA7DcU6Hvc=;
 b=VP7fnlf6hKJYogx2EUWHEiDLgr/sGXCzrCro4HO34Tkj3YtmGJvuFMOedBW0KB+A93b5X5BQZlpljSylorzigQma+5dahelv8a0F9YHaKw2qN6/q3hfrmpzPxEKEyNzso884/b2XiH+oVU+UAVPlhy+P809pDJtS1KZ+36U4MzAh1iDZoPR4slEeT7f8xi67Th0HDqonA+SIUjTlwWp+3nLYhJiu1SA96bmvskBvX/D1YnmUB1BhqLXav2zzrEH2cRcT+koKL7skY6YooG4hrBpnm73lRGbeqLhFiR1RumFQE3KQDembUAacH0GruIkzsU1hRmAyWPPQqtc6qYVnZA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=RH2YM0lxfPWVymnBpZdpVYUeUf/4XqOhapA7DcU6Hvc=;
 b=Sy/VgrgSXoqJGOw9jqot+BAgd1KQgy83WT6umEOybmCznQw6CWA3j/NcJatg477gNiMBvC3XVoDzy3TKuIwXskNks6lZ3EU34IjhdBbO+1ZtUHb8YuI6WwGf8ilDHq30687gXD4Bhd5XlPNWMt2EG0biz9ORAmfSq6G9r0lp4MwxLBro7rS3IJ1Ce68CEZtlaWGU5+IoMPvAN0VCpqsgJ2PuHMecP5HnTTUCtEaUUlvgqsJ1Ohzo6YDnqHZ4+M7Ykjc4ZPEpHMCAwziLcwIij5gsimH1t4FaAJ7XjfYoxB/aehcnEEaBSIYTU8Y5uISCsgLuoz9IUES6nbrKYefDCQ==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "jbeulich@suse.com" <jbeulich@suse.com>,
        "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org" <sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH] vpci: introduce per-domain lock to protect vpci structure
Thread-Topic: [PATCH] vpci: introduce per-domain lock to protect vpci
 structure
Thread-Index: AQHYHboQT3cBWYI1/EGunE7hOwop6ayM95MAgAD+qQA=
Date: Fri, 11 Feb 2022 07:27:39 +0000
Message-ID: <c4666570-666e-6680-5ec2-adf1da51ad06@epam.com>
References: <20220209133627.959649-1-andr2000@gmail.com>
 <YgU6Snk8GTytJXZp@Air-de-Roger>
In-Reply-To: <YgU6Snk8GTytJXZp@Air-de-Roger>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: c9053abd-c5a2-461a-69c8-08d9ed2ffc09
x-ms-traffictypediagnostic: VI1PR03MB6240:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <VI1PR03MB624007195BB075609EB0D266E7309@VI1PR03MB6240.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 nJTc/ORGGg9QKY92k42qJK3sE+fZd6gbacszJKX1s8cg6W+pLm8spApzckiQF7xa21EBdzblIoJYpKmaFrNHTlpG5VLytwvdKqi/hIQ2reh3nXy3ni9q6+l1Uhd3lOZsQLdg1pGzNyU2XCUw6r6sULg+xiA5ANGm6WiSQ3BtFIM4rgq6IjIJYVNSx57wNECz5Lhkrmy9+J4DDlGCeDHI/ZsfnsqC+7H+H7HGPuVWWUzv1PynW5ioPruPYfkSiXg66CU2stJZ4FWDIaoEHJ5hrQRK89vtG5bAxi5dzwlJsfDHO8w+e80tpa71b2djBMC1zWR/Msf1xMDsAouFbJMA7VUEvHOIINvikG4Y9W66hg+UwZKcbr1dpa+rvdh/i4zuBsAgtvZc2+P+2Nt5L4YqfOhQnjlNbTFZEf6esCQ3BfCeisLFiYseo7U2GuFSNMGIUXg8LnyOWc8fErB6ICkL/CDev6UrXboklRV9QEQS44Ax8a8bbKLrnnFaWhQw92GzYQon9Bq1c8NTT+ThoZ/u9RzXXPrROl+Y1JJAkUJ8gAO0nH9L6r5/AiqqA7MtoKBORTeF3YagB77tEFSvSw5rqs/WR4lVYKP05phIZFybIt5ZfP6KrpYrqFWhUASaVLr0wor+q149yfydivasQ8JjWQidAfhTNDPBZxNn415WRY72HWmWy1o/y5gvl1HsgI/DVPeTMLaV02/UMsXSQ4EZqKp6q4fjTRAtEahQxOSHyyo+2ZqyujJrYt8L8HY/2Fw5uiQyI9JyRJ6mgZJQ2sZWOeL0UxxR+0Fz9ByszpQn0j8yktVV/cQKsyzFojAxWVCBDjViIqVFyOBTF6W9jaLONus1wgGbFLIR2vo6TEAIscE=
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(26005)(30864003)(91956017)(8676002)(186003)(8936002)(76116006)(55236004)(53546011)(6512007)(36756003)(6506007)(2616005)(5660300002)(66446008)(66946007)(4326008)(54906003)(2906002)(107886003)(31696002)(966005)(38100700002)(508600001)(64756008)(38070700005)(316002)(6916009)(66476007)(71200400001)(66556008)(86362001)(6486002)(31686004)(83380400001)(122000001)(45980500001)(579004)(309714004);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?V2xPb2xvVWdmTXdQRC9NK3liQzlwWkdzWHRsTmNZVnBGU0Myb1E4eC9OeFVU?=
 =?utf-8?B?TUxXQkFFQktmUXV3Z1lrZDVsZkxKbmFxRDlSRWE1SmZXZUNObExMNjVicGFJ?=
 =?utf-8?B?dmpVaStxUEF1bmRPT2t4a3NqMDJySUo3SzFTbWxXZ2d6NkhXUG9Dekdhb1ZF?=
 =?utf-8?B?TjNBTnE3ZGc0azZMOE5kTXpXOE9sZnUveEo3REV2SCtTSFNva3dDYWVlZzBw?=
 =?utf-8?B?UXF5TWFMcFBoQkM0akdZbHdpYkI3VnpVU1JsOVVMQy8yUWwzUEIzbDF1UVFX?=
 =?utf-8?B?dWJxWTRHS1RMWHBLcEl2bFFlMFpsRFFUL2dGZUxudzh6YkkvaEpiU0ZwRkla?=
 =?utf-8?B?TTlpbFJnam1nYlRiaTU1K2dOcnc3aFFWREhYWU5vTHd1ZTFJemo1TkF3WEdU?=
 =?utf-8?B?T2ZIWUZxbHUzdytsdXQ4UkE4MVBoTUorc24yZ2dCbVY5ZFNqdXcrMG1DYWpt?=
 =?utf-8?B?YUV1c2cvL05DT3YrOWRSSXkyVkJFNlA2NGRFend4Vk5UTXM4U2JyaUw1d3lj?=
 =?utf-8?B?TEtJQ0Zza3V1VFFDRUVEazdYOWpwYkZWMnFYZjJ4UEEvTmNQeStxQ2Y2emdh?=
 =?utf-8?B?M1AyQnV0NjBUbHZlWnJIbUdWemZpUnJEU0xIK1R3blBEQUZsNUlyeUV1M2pj?=
 =?utf-8?B?SmtHQ1N3ZUg5eXJPbHRnL1piN0ZWVnhBeWg2bWw0ckJ6OS8rZ29JbG54Q2R5?=
 =?utf-8?B?YlViUldIQTdMR1V6NHVUWVNaRWNNb3BXa0llNmo1R0RqMTYvV216Q2dNWkVj?=
 =?utf-8?B?Q1VvYk1lV0hXZzBFR1NoSEhzVUFrVC9laTlkc0ZSOVZmVCsxU3BmNnJ3SnUz?=
 =?utf-8?B?M292WXp1NDZYaVFaTFE0UGREcVhJMVI4SW5yV08ySjR3emw2bTJOWTNJdkph?=
 =?utf-8?B?d21ueU9ySU8zQ20xUnNNNUJ5Vm5NNTNjSXFGWjV0NHlZT1pFODdrUXdUV2Fo?=
 =?utf-8?B?bVlOUElGbUJhVldVS3ZhM0s4aDd5ZytmMWxLaWlSNWFycWw3alpWYitvTjRy?=
 =?utf-8?B?aUszcFZOMWV3UUcvMTZQRnROQVBQeEdFUWExSWdydmhLMDBEUFFQb1RybU56?=
 =?utf-8?B?QnpLaUNkNnN6SkxKWUJ0MGJXZnFyTHUwMVF5N2tDWmFQbHk2R281cnhkSUxu?=
 =?utf-8?B?ck56UHRESGtwZENWdkhvQzlZUndOTGt4U2ZqRXRPTnRwUEVpYWl5NFNuWlF4?=
 =?utf-8?B?cGRJZ2hDUEVkWGZ2VDREQ3piY2dyY2Z3a0dzVVNaT2ZxQWtBQjA3aFAvMERV?=
 =?utf-8?B?Y2hGQzYrRFV6YTIyTmE5R3NXMHdXK2NicjQ2Y2tqV0RkWHExZmg3TTErSFov?=
 =?utf-8?B?cHdqdS9tM2FXSjdXQkY4RGx4cFY1Ni9KNVA2MzIzaTdSWHdCbGltakxFNlRp?=
 =?utf-8?B?OXYzQ3BYR1h4SnpYc0JsRTFnY1BBbmJrdFNJbU1Rem5oU01CSXBXM3pQc0Fh?=
 =?utf-8?B?Z0NtT1IwVE94dkJtYnBsT2FxMXJhUkxiaGFJcm5FcXN4TmloV2ZyZEh4aURJ?=
 =?utf-8?B?eVhkZWJ5aWhKMExKWGVmem1IYzN2dlR2QzlZZzB0a2FLeU1KSjk4Z3VOT3pB?=
 =?utf-8?B?Z1NoeTN4VG5PZmI2aEZtVUpiS0wvMnN6SkQ0cEVZUFBSS01pY0E5U3ZzS0gy?=
 =?utf-8?B?KzZscS9FbXI4M2NUeHVxVjNuRFROaGNxYUFMdktoVnNUSVVUS2x6M2lrQWI1?=
 =?utf-8?B?QWJzVE1sMlM0VmJFajJTTkVoL3VvNjIxM1o4T3V5UUExZWJrdEs1elRUVDI4?=
 =?utf-8?B?ZDRha1dPd2ZKcnBVUXZuUDVNbVQwSS83MEVGRDlmZHJzcVBTNTF1cnpaMnVX?=
 =?utf-8?B?eUd0MCt5dXcyYnFCcWZOd1pMMDRRK0FVNE96Z1lKK2JFZDdrY1A2OWxENDVM?=
 =?utf-8?B?R2VlMUxIT2dZU0hiWmNPQ29XWHJQMGJCME9saUhRL1FmUWw3WHdoMExVdWE2?=
 =?utf-8?B?K0lldENCZER1NTRrUko0WEJrdHZHdVVNSFl1ZnZBTW1BZG1haTdjYUhpSzYr?=
 =?utf-8?B?c2gveW55bkl0c2FyZG5MUDR0Q3Q4RVZ1UmljY1lYYnM1Y0lPb1Z1NkJXWHRz?=
 =?utf-8?B?UlRTMlQwaHArMlJzTmxzRkNPWm4yayt1cEFGUTEvd2h6b3JzbTcrSkFzZVlT?=
 =?utf-8?B?MjJQMEd2ZW1PaGlIUXdRSnVZV2R5Vi9kWHJGd1RjTm1HQkY0VjQ3YVV5NnVR?=
 =?utf-8?B?OHN4OFVJcFZodVpWaGdaaEdjUUhpWWVnZ1ZBYS8vZldEaEEyTUV2TTlmZ0ZT?=
 =?utf-8?B?NzlPQ09SSGNqSEFVejBTZEhIM05vOEdna0VwNGlyVjFkQXBDd1Z5SURJYUJm?=
 =?utf-8?B?NmV6WlMzSXZielR2MmZxN3dRSTIvdW5DSW9TU3dMWGFqenN5S2h2dz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <C696208835322D4AA764C9175617E825@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c9053abd-c5a2-461a-69c8-08d9ed2ffc09
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Feb 2022 07:27:39.6263
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 7ihR1meUOFLTEe/dBArLgYSsr7RBcPBzjhm14Ifl1YCKMa1uz8Y83dOQVCI5QOPa29W34EVD4xTqN8FlFhHmK8gSTK+eyewqdFWDfLfkkngXi4uTFQwQZwZULl0yjke1
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR03MB6240
X-Proofpoint-ORIG-GUID: Fxwa5TqnwyQZlWxWtaT43zSnEbgroG8d
X-Proofpoint-GUID: Fxwa5TqnwyQZlWxWtaT43zSnEbgroG8d
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-11_02,2022-02-09_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0
 adultscore=0 bulkscore=0 spamscore=0 phishscore=0 priorityscore=1501
 clxscore=1015 impostorscore=0 suspectscore=0 malwarescore=0 mlxscore=0
 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202110041

SGksIFJvZ2VyIQ0KDQpPbiAxMC4wMi4yMiAxODoxNiwgUm9nZXIgUGF1IE1vbm7DqSB3cm90ZToN
Cj4gT24gV2VkLCBGZWIgMDksIDIwMjIgYXQgMDM6MzY6MjdQTSArMDIwMCwgT2xla3NhbmRyIEFu
ZHJ1c2hjaGVua28gd3JvdGU6DQo+PiBGcm9tOiBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyA8b2xl
a3NhbmRyX2FuZHJ1c2hjaGVua29AZXBhbS5jb20+DQo+Pg0KPj4gSW50cm9kdWNlIGEgcGVyLWRv
bWFpbiByZWFkL3dyaXRlIGxvY2sgdG8gY2hlY2sgd2hldGhlciB2cGNpIGlzIHByZXNlbnQsDQo+
PiBzbyB3ZSBhcmUgc3VyZSB0aGVyZSBhcmUgbm8gYWNjZXNzZXMgdG8gdGhlIGNvbnRlbnRzIG9m
IHRoZSB2cGNpIHN0cnVjdA0KPj4gaWYgbm90LiBUaGlzIGxvY2sgY2FuIGJlIHVzZWQgKGFuZCBp
biBhIGZldyBjYXNlcyBpcyB1c2VkIHJpZ2h0IGF3YXkpDQo+PiBzbyB0aGF0IHZwY2kgcmVtb3Zh
bCBjYW4gYmUgcGVyZm9ybWVkIHdoaWxlIGhvbGRpbmcgdGhlIGxvY2sgaW4gd3JpdGUNCj4+IG1v
ZGUuIFByZXZpb3VzbHkgc3VjaCByZW1vdmFsIGNvdWxkIHJhY2Ugd2l0aCB2cGNpX3JlYWQgZm9y
IGV4YW1wbGUuDQo+IFNhZGx5IHRoZXJlJ3Mgc3RpbGwgYSByYWNlIGluIHRoZSB1c2FnZSBvZiBw
Y2lfZ2V0X3BkZXZfYnlfZG9tYWluIHdydA0KPiBwY2lfcmVtb3ZlX2RldmljZSwgYW5kIGxpa2Vs
eSB3aGVuIHZQQ0kgZ2V0cyBhbHNvIHVzZWQgaW4NCj4ge2RlfWFzc2lnbl9kZXZpY2UgSSB0aGlu
ay4NClllcywgdGhpcyBpcyBpbmRlZWQgYW4gaXNzdWUsIGJ1dCBJIHdhcyBub3QgdHJ5aW5nIHRv
IHNvbHZlIGl0IGluDQpjb250ZXh0IG9mIHZQQ0kgbG9ja2luZyB5ZXQuIEkgdGhpbmsgd2Ugc2hv
dWxkIGRpc2N1c3MgaG93IGRvDQp3ZSBhcHByb2FjaCBwZGV2IGxvY2tpbmcsIHNvIEkgY2FuIGNy
ZWF0ZSBhIHBhdGNoIGZvciB0aGF0Lg0KdGhhdCBiZWluZyBzYWlkLCBJIHdvdWxkIGxpa2Ugbm90
IHRvIHNvbHZlIHBkZXYgaW7CoCB0aGlzIHBhdGNoIHlldA0KDQouLi5JIGRvIHVuZGVyc3RhbmQg
d2UgZG8gd2FudCB0byBhdm9pZCB0aGF0LCBidXQgYXQgdGhlIG1vbWVudA0KYSBzaW5nbGUgcmVs
aWFibGUgd2F5IGZvciBtYWtpbmcgc3VyZSBwZGV2IGlzIGFsaXZlIHNlZW1zIHRvDQpiZSBwY2lk
ZXZzX2xvY2suLi4uDQo+DQo+PiAxLiBQZXItZG9tYWluJ3MgdnBjaV9yd2xvY2sgaXMgdXNlZCB0
byBwcm90ZWN0IHBkZXYtPnZwY2kgc3RydWN0dXJlDQo+PiBmcm9tIGJlaW5nIHJlbW92ZWQuDQo+
Pg0KPj4gMi4gV3JpdGluZyB0aGUgY29tbWFuZCByZWdpc3RlciBhbmQgUk9NIEJBUiByZWdpc3Rl
ciBtYXkgdHJpZ2dlcg0KPj4gbW9kaWZ5X2JhcnMgdG8gcnVuLCB3aGljaCBpbiB0dXJuIG1heSBh
Y2Nlc3MgbXVsdGlwbGUgcGRldnMgd2hpbGUNCj4+IGNoZWNraW5nIGZvciB0aGUgZXhpc3Rpbmcg
QkFSJ3Mgb3ZlcmxhcC4gVGhlIG92ZXJsYXBwaW5nIGNoZWNrLCBpZiBkb25lDQo+PiB1bmRlciB0
aGUgcmVhZCBsb2NrLCByZXF1aXJlcyB2cGNpLT5sb2NrIHRvIGJlIGFjcXVpcmVkIG9uIGJvdGgg
ZGV2aWNlcw0KPj4gYmVpbmcgY29tcGFyZWQsIHdoaWNoIG1heSBwcm9kdWNlIGEgZGVhZGxvY2su
IEl0IGlzIG5vdCBwb3NzaWJsZSB0bw0KPj4gdXBncmFkZSByZWFkIGxvY2sgdG8gd3JpdGUgbG9j
ayBpbiBzdWNoIGEgY2FzZS4gU28sIGluIG9yZGVyIHRvIHByZXZlbnQNCj4+IHRoZSBkZWFkbG9j
aywgY2hlY2sgd2hpY2ggcmVnaXN0ZXJzIGFyZSBnb2luZyB0byBiZSB3cml0dGVuIGFuZCBhY3F1
aXJlDQo+PiB0aGUgbG9jayBpbiB0aGUgYXBwcm9wcmlhdGUgbW9kZSBmcm9tIHRoZSBiZWdpbm5p
bmcuDQo+Pg0KPj4gQWxsIG90aGVyIGNvZGUsIHdoaWNoIGRvZXNuJ3QgbGVhZCB0byBwZGV2LT52
cGNpIGRlc3RydWN0aW9uIGFuZCBkb2VzIG5vdA0KPj4gYWNjZXNzIG11bHRpcGxlIHBkZXZzIGF0
IHRoZSBzYW1lIHRpbWUsIGNhbiBzdGlsbCB1c2UgYSBjb21iaW5hdGlvbiBvZiB0aGUNCj4+IHJl
YWQgbG9jayBhbmQgcGRldi0+dnBjaS0+bG9jay4NCj4+DQo+PiAzLiBPcHRpbWl6ZSBpZiBST00g
QkFSIHdyaXRlIGxvY2sgcmVxdWlyZWQgZGV0ZWN0aW9uIGJ5IGNhY2hpbmcgb2Zmc2V0DQo+PiBv
ZiB0aGUgUk9NIEJBUiByZWdpc3RlciBpbiB2cGNpLT5oZWFkZXItPnJvbV9yZWcgd2hpY2ggZGVw
ZW5kcyBvbg0KPj4gaGVhZGVyJ3MgdHlwZS4NCj4+DQo+PiA0LiBSZWR1Y2UgbG9ja2VkIHJlZ2lv
biBpbiB2cGNpX3JlbW92ZV9kZXZpY2UgYXMgaXQgaXMgbm93IHBvc3NpYmxlDQo+PiB0byBzZXQg
cGRldi0+dnBjaSB0byBOVUxMIGVhcmx5IHJpZ2h0IGFmdGVyIHRoZSB3cml0ZSBsb2NrIGlzIGFj
cXVpcmVkLg0KPj4NCj4+IDUuIFJlZHVjZSBsb2NrZWQgcmVnaW9uIGluIHZwY2lfYWRkX2hhbmRs
ZXJzIGFzIGl0IGlzIHBvc3NpYmxlIHRvDQo+PiBpbml0aWFsaXplIG1hbnkgbW9yZSBmaWVsZHMg
b2YgdGhlIHN0cnVjdCB2cGNpIGJlZm9yZSBhc3NpZ25pbmcgaXQgdG8NCj4+IHBkZXYtPnZwY2ku
DQo+Pg0KPj4gNi4gdnBjaV97YWRkfHJlbW92ZX1fcmVnaXN0ZXIgYXJlIHJlcXVpcmVkIHRvIGJl
IGNhbGxlZCB3aXRoIHRoZSB3cml0ZSBsb2NrDQo+PiBoZWxkLCBidXQgaXQgaXMgbm90IGZlYXNp
YmxlIHRvIGFkZCBhbiBhc3NlcnQgdGhlcmUgYXMgaXQgcmVxdWlyZXMNCj4+IHN0cnVjdCBkb21h
aW4gdG8gYmUgcGFzc2VkIGZvciB0aGF0LiBTbywgYWRkIGEgY29tbWVudCBhYm91dCB0aGlzIHJl
cXVpcmVtZW50DQo+PiB0byB0aGVzZSBhbmQgb3RoZXIgZnVuY3Rpb25zIHdpdGggdGhlIGVxdWl2
YWxlbnQgY29uc3RyYWludHMuDQo+Pg0KPj4gNy4gRHJvcCBjb25zdCBxdWFsaWZpZXIgd2hlcmUg
dGhlIG5ldyByd2xvY2sgaXMgdXNlZCBhbmQgdGhpcyBpcyBhcHByb3ByaWF0ZS4NCj4+DQo+PiA4
LiBUaGlzIGlzIGJhc2VkIG9uIHRoZSBkaXNjdXNzaW9uIGF0IFsxXS4NCj4+DQo+PiBbMV0gaHR0
cHM6Ly91cmxkZWZlbnNlLmNvbS92My9fX2h0dHBzOi8vbG9yZS5rZXJuZWwub3JnL2FsbC8yMDIy
MDIwNDA2MzQ1OS42ODA5NjEtNC1hbmRyMjAwMEBnbWFpbC5jb20vX187ISFHRl8yOWRiY1FJVUJQ
QSFnT2JTeVN6TjdzNnpTS3JjcFNFaTZ2dzE4ZlJQbHMxNTdjdVJvcXE0S0RkN0ljX052aF9jRmx5
VlhQUnBFV0JrSTM4cGdzdnZmZyQgW2xvcmVbLl1rZXJuZWxbLl1vcmddDQo+Pg0KPj4gU3VnZ2Vz
dGVkLWJ5OiBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT4NCj4+IFN1Z2dl
c3RlZC1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KPj4gU2lnbmVkLW9mZi1i
eTogT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gPG9sZWtzYW5kcl9hbmRydXNoY2hlbmtvQGVwYW0u
Y29tPg0KPj4NCj4+IC0tLQ0KPj4gVGhpcyB3YXMgY2hlY2tlZCBvbiB4ODY6IHdpdGggYW5kIHdp
dGhvdXQgUFZIIERvbTAuDQo+PiAtLS0NCj4+ICAgeGVuL2FyY2gveDg2L2h2bS92bXNpLmMgICB8
ICAgMiArDQo+PiAgIHhlbi9jb21tb24vZG9tYWluLmMgICAgICAgfCAgIDMgKw0KPj4gICB4ZW4v
ZHJpdmVycy92cGNpL2hlYWRlci5jIHwgICA4ICsrKw0KPj4gICB4ZW4vZHJpdmVycy92cGNpL21z
aS5jICAgIHwgICA4ICsrLQ0KPj4gICB4ZW4vZHJpdmVycy92cGNpL21zaXguYyAgIHwgIDQwICsr
KysrKysrKysrLS0NCj4+ICAgeGVuL2RyaXZlcnMvdnBjaS92cGNpLmMgICB8IDExNCArKysrKysr
KysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLQ0KPj4gICB4ZW4vaW5jbHVkZS94ZW4vc2No
ZWQuaCAgIHwgICAzICsNCj4+ICAgeGVuL2luY2x1ZGUveGVuL3ZwY2kuaCAgICB8ICAgMiArDQo+
PiAgIDggZmlsZXMgY2hhbmdlZCwgMTQ2IGluc2VydGlvbnMoKyksIDM0IGRlbGV0aW9ucygtKQ0K
Pj4NCj4+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC94ODYvaHZtL3Ztc2kuYyBiL3hlbi9hcmNoL3g4
Ni9odm0vdm1zaS5jDQo+PiBpbmRleCAxM2UyYTE5MGI0MzkuLjM1MWNiOTY4YTQyMyAxMDA2NDQN
Cj4+IC0tLSBhL3hlbi9hcmNoL3g4Ni9odm0vdm1zaS5jDQo+PiArKysgYi94ZW4vYXJjaC94ODYv
aHZtL3Ztc2kuYw0KPj4gQEAgLTg5Myw2ICs4OTMsOCBAQCBpbnQgdnBjaV9tc2l4X2FyY2hfcHJp
bnQoY29uc3Qgc3RydWN0IHZwY2lfbXNpeCAqbXNpeCkNCj4+ICAgew0KPj4gICAgICAgdW5zaWdu
ZWQgaW50IGk7DQo+PiAgIA0KPj4gKyAgICBBU1NFUlQoISFyd19pc19sb2NrZWQoJm1zaXgtPnBk
ZXYtPmRvbWFpbi0+dnBjaV9yd2xvY2spKTsNCj4gICAgICAgICAgICAgICAgXiBubyBuZWVkIGZv
ciB0aGUgZG91YmxlIG5lZ2F0aW9uLg0KT2ssIHdpbGwgdXBkYXRlIGFsbCBhc3NlcnRzIHdoaWNo
IHVzZSAhIQ0KPg0KPiBBbHNvIHRoaXMgYXNzZXJ0cyB0aGF0IHRoZSBsb2NrIGlzIHRha2VuLCBi
dXQgY291bGQgYmUgYnkgYSBkaWZmZXJlbnQNCj4gcENQVS4gIEkgZ3Vlc3MgaXQncyBiZXR0ZXIg
dGhhbiBub3RoaW5nLg0KRmFpciBlbm91Z2guIERvIHlvdSBzdGlsbCB3YW50IHRoZSBhc3NlcnRz
IG9yIHNob3VsZCBJIHJlbW92ZSB0aGVtPw0KPg0KPj4gKw0KPj4gICAgICAgZm9yICggaSA9IDA7
IGkgPCBtc2l4LT5tYXhfZW50cmllczsgaSsrICkNCj4+ICAgICAgIHsNCj4+ICAgICAgICAgICBj
b25zdCBzdHJ1Y3QgdnBjaV9tc2l4X2VudHJ5ICplbnRyeSA9ICZtc2l4LT5lbnRyaWVzW2ldOw0K
PiBTaW5jZSB0aGlzIGZ1bmN0aW9uIGlzIG5vdyBjYWxsZWQgd2l0aCB0aGUgcGVyLWRvbWFpbiBy
d2xvY2sgcmVhZA0KPiBsb2NrZWQgaXQncyBsaWtlbHkgbm90IGFwcHJvcHJpYXRlIHRvIGNhbGwg
cHJvY2Vzc19wZW5kaW5nX3NvZnRpcnFzDQo+IHdoaWxlIGhvbGRpbmcgc3VjaCBsb2NrIChjaGVj
ayBiZWxvdykuDQpZb3UgYXJlIHJpZ2h0LCBhcyBpdCBpcyBwb3NzaWJsZSB0aGF0Og0KDQpwcm9j
ZXNzX3BlbmRpbmdfc29mdGlycXMgLT4gdnBjaV9wcm9jZXNzX3BlbmRpbmcgLT4gcmVhZF9sb2Nr
DQoNCkV2ZW4gbW9yZSwgdnBjaV9wcm9jZXNzX3BlbmRpbmcgbWF5IGFsc28NCg0KcmVhZF91bmxv
Y2sgLT4gdnBjaV9yZW1vdmVfZGV2aWNlIC0+IHdyaXRlX2xvY2sNCg0KaW4gaXRzIGVycm9yIHBh
dGguIFNvLCBhbnkgaW52b2NhdGlvbiBvZiBwcm9jZXNzX3BlbmRpbmdfc29mdGlycXMNCm11c3Qg
bm90IGhvbGQgZC0+dnBjaV9yd2xvY2sgYXQgbGVhc3QuDQoNCkFuZCBhbHNvIHdlIG5lZWQgdG8g
Y2hlY2sgdGhhdCBwZGV2LT52cGNpIHdhcyBub3QgcmVtb3ZlZA0KaW4gYmV0d2VlbiBvciAqcmUt
Y3JlYXRlZCoNCj4NCj4gV2Ugd2lsbCBsaWtlbHkgbmVlZCB0byByZS1pdGVyYXRlIG92ZXIgdGhl
IGxpc3Qgb2YgcGRldnMgYXNzaWduZWQgdG8NCj4gdGhlIGRvbWFpbiBhbmQgYXNzZXJ0IHRoYXQg
dGhlIHBkZXYgaXMgc3RpbGwgYXNzaWduZWQgdG8gdGhlIHNhbWUNCj4gZG9tYWluLg0KU28sIGRv
IHlvdSBtZWFuIGEgcGF0dGVybiBsaWtlIHRoZSBiZWxvdyBzaG91bGQgYmUgdXNlZCBhdCBhbGwN
CnBsYWNlcyB3aGVyZSB3ZSBuZWVkIHRvIGNhbGwgcHJvY2Vzc19wZW5kaW5nX3NvZnRpcnFzPw0K
DQpyZWFkX3VubG9jaw0KcHJvY2Vzc19wZW5kaW5nX3NvZnRpcnFzDQpyZWFkX2xvY2sNCnBkZXYg
PSBwY2lfZ2V0X3BkZXZfYnlfZG9tYWluKGQsIHNiZGYuc2VnLCBzYmRmLmJ1cywgc2JkZi5kZXZm
bik7DQppZiAoIHBkZXYgJiYgcGRldi0+dnBjaSAmJiBpc190aGVfc2FtZV92cGNpKHBkZXYtPnZw
Y2kpICkNCjxjb250aW51ZSBwcm9jZXNzaW5nPg0KDQo+DQo+PiBkaWZmIC0tZ2l0IGEveGVuL2Nv
bW1vbi9kb21haW4uYyBiL3hlbi9jb21tb24vZG9tYWluLmMNCj4+IGluZGV4IDIwNDhlYmFkODZm
Zi4uMTA1NThjMjIyODVkIDEwMDY0NA0KPj4gLS0tIGEveGVuL2NvbW1vbi9kb21haW4uYw0KPj4g
KysrIGIveGVuL2NvbW1vbi9kb21haW4uYw0KPj4gQEAgLTYxNiw2ICs2MTYsOSBAQCBzdHJ1Y3Qg
ZG9tYWluICpkb21haW5fY3JlYXRlKGRvbWlkX3QgZG9taWQsDQo+PiAgIA0KPj4gICAjaWZkZWYg
Q09ORklHX0hBU19QQ0kNCj4+ICAgICAgIElOSVRfTElTVF9IRUFEKCZkLT5wZGV2X2xpc3QpOw0K
Pj4gKyNpZmRlZiBDT05GSUdfSEFTX1ZQQ0kNCj4+ICsgICAgcndsb2NrX2luaXQoJmQtPnZwY2lf
cndsb2NrKTsNCj4+ICsjZW5kaWYNCj4+ICAgI2VuZGlmDQo+PiAgIA0KPj4gICAgICAgLyogQWxs
IGVycm9yIHBhdGhzIGNhbiBkZXBlbmQgb24gdGhlIGFib3ZlIHNldHVwLiAqLw0KPj4gZGlmZiAt
LWdpdCBhL3hlbi9kcml2ZXJzL3ZwY2kvaGVhZGVyLmMgYi94ZW4vZHJpdmVycy92cGNpL2hlYWRl
ci5jDQo+PiBpbmRleCA0MGZmNzljMzNmOGYuLjllMmFlYjIwNTVjOSAxMDA2NDQNCj4+IC0tLSBh
L3hlbi9kcml2ZXJzL3ZwY2kvaGVhZGVyLmMNCj4+ICsrKyBiL3hlbi9kcml2ZXJzL3ZwY2kvaGVh
ZGVyLmMNCj4+IEBAIC0xNDIsMTIgKzE0MiwxNCBAQCBib29sIHZwY2lfcHJvY2Vzc19wZW5kaW5n
KHN0cnVjdCB2Y3B1ICp2KQ0KPj4gICAgICAgICAgIGlmICggcmMgPT0gLUVSRVNUQVJUICkNCj4+
ICAgICAgICAgICAgICAgcmV0dXJuIHRydWU7DQo+PiAgIA0KPj4gKyAgICAgICAgcmVhZF9sb2Nr
KCZ2LT5kb21haW4tPnZwY2lfcndsb2NrKTsNCj4+ICAgICAgICAgICBzcGluX2xvY2soJnYtPnZw
Y2kucGRldi0+dnBjaS0+bG9jayk7DQo+PiAgICAgICAgICAgLyogRGlzYWJsZSBtZW1vcnkgZGVj
b2RpbmcgdW5jb25kaXRpb25hbGx5IG9uIGZhaWx1cmUuICovDQo+PiAgICAgICAgICAgbW9kaWZ5
X2RlY29kaW5nKHYtPnZwY2kucGRldiwNCj4+ICAgICAgICAgICAgICAgICAgICAgICAgICAgcmMg
PyB2LT52cGNpLmNtZCAmIH5QQ0lfQ09NTUFORF9NRU1PUlkgOiB2LT52cGNpLmNtZCwNCj4+ICAg
ICAgICAgICAgICAgICAgICAgICAgICAgIXJjICYmIHYtPnZwY2kucm9tX29ubHkpOw0KPj4gICAg
ICAgICAgIHNwaW5fdW5sb2NrKCZ2LT52cGNpLnBkZXYtPnZwY2ktPmxvY2spOw0KPj4gKyAgICAg
ICAgcmVhZF91bmxvY2soJnYtPmRvbWFpbi0+dnBjaV9yd2xvY2spOw0KPj4gICANCj4+ICAgICAg
ICAgICByYW5nZXNldF9kZXN0cm95KHYtPnZwY2kubWVtKTsNCj4+ICAgICAgICAgICB2LT52cGNp
Lm1lbSA9IE5VTEw7DQo+PiBAQCAtMjAzLDYgKzIwNSw3IEBAIHN0YXRpYyB2b2lkIGRlZmVyX21h
cChzdHJ1Y3QgZG9tYWluICpkLCBzdHJ1Y3QgcGNpX2RldiAqcGRldiwNCj4+ICAgICAgIHJhaXNl
X3NvZnRpcnEoU0NIRURVTEVfU09GVElSUSk7DQo+PiAgIH0NCj4+ICAgDQo+PiArLyogVGhpcyBt
dXN0IGhvbGQgZG9tYWluJ3MgdnBjaV9yd2xvY2sgaW4gd3JpdGUgbW9kZS4gKi8NCj4+ICAgc3Rh
dGljIGludCBtb2RpZnlfYmFycyhjb25zdCBzdHJ1Y3QgcGNpX2RldiAqcGRldiwgdWludDE2X3Qg
Y21kLCBib29sIHJvbV9vbmx5KQ0KPj4gICB7DQo+PiAgICAgICBzdHJ1Y3QgdnBjaV9oZWFkZXIg
KmhlYWRlciA9ICZwZGV2LT52cGNpLT5oZWFkZXI7DQo+PiBAQCAtNDU0LDYgKzQ1Nyw4IEBAIHN0
YXRpYyBpbnQgaW5pdF9iYXJzKHN0cnVjdCBwY2lfZGV2ICpwZGV2KQ0KPj4gICAgICAgc3RydWN0
IHZwY2lfYmFyICpiYXJzID0gaGVhZGVyLT5iYXJzOw0KPj4gICAgICAgaW50IHJjOw0KPj4gICAN
Cj4+ICsgICAgQVNTRVJUKCEhcndfaXNfd3JpdGVfbG9ja2VkKCZwZGV2LT5kb21haW4tPnZwY2lf
cndsb2NrKSk7DQo+PiArDQo+PiAgICAgICBzd2l0Y2ggKCBwY2lfY29uZl9yZWFkOChwZGV2LT5z
YmRmLCBQQ0lfSEVBREVSX1RZUEUpICYgMHg3ZiApDQo+PiAgICAgICB7DQo+PiAgICAgICBjYXNl
IFBDSV9IRUFERVJfVFlQRV9OT1JNQUw6DQo+PiBAQCAtNTQ4LDYgKzU1Myw3IEBAIHN0YXRpYyBp
bnQgaW5pdF9iYXJzKHN0cnVjdCBwY2lfZGV2ICpwZGV2KQ0KPj4gICAgICAgew0KPj4gICAgICAg
ICAgIHN0cnVjdCB2cGNpX2JhciAqcm9tID0gJmhlYWRlci0+YmFyc1tudW1fYmFyc107DQo+PiAg
IA0KPj4gKyAgICAgICAgaGVhZGVyLT5yb21fcmVnID0gcm9tX3JlZzsNCj4+ICAgICAgICAgICBy
b20tPnR5cGUgPSBWUENJX0JBUl9ST007DQo+PiAgICAgICAgICAgcm9tLT5zaXplID0gc2l6ZTsN
Cj4+ICAgICAgICAgICByb20tPmFkZHIgPSBhZGRyOw0KPj4gQEAgLTU1OSw2ICs1NjUsOCBAQCBz
dGF0aWMgaW50IGluaXRfYmFycyhzdHJ1Y3QgcGNpX2RldiAqcGRldikNCj4+ICAgICAgICAgICBp
ZiAoIHJjICkNCj4+ICAgICAgICAgICAgICAgcm9tLT50eXBlID0gVlBDSV9CQVJfRU1QVFk7DQo+
IFlvdSBjYW4gYWxzbyBzZXQgJ3JvbV9yZWcgPSB+MCcgaGVyZS4gT3IgbW92ZSB0aGUgc2V0dGlu
ZyBvZiByb21fcmVnDQo+IGFmdGVyIHRoZSBoYW5kbGVyIGhhcyBiZWVuIHN1Y2Nlc3NmdWxseSBp
bnN0YWxsZWQuDQo+DQo+IEkgdGhpbmsgaXQgd291bGQgYmUgZWFzaWVyIHRvIGp1c3Qgc2lnbmFs
IG5vIFJPTSBCQVIgd2l0aCByb21fcmVnID09DQo+IDAuICBUaGVyZSdzIG5vIGhlYWRlciB3aGVy
ZSB0aGUgUk9NIEJBUiBpcyBhdCBvZmZzZXQgMC4gIFRoYXQgd2F5IHlvdQ0KPiB3aWxsIG9ubHkg
aGF2ZSB0byBzZXQgcm9tX3JlZyBvbiB0aGUgc3VjY2Vzc2Z1bCBwYXRoLCBidXQgeW91IGRvbid0
DQo+IG5lZWQgdG8gY2FyZSBhYm91dCB0aGUgY2FzZSB3aGVyZSB0aGVyZSdzIG5vIFJPTSBCQVIu
DQpZZXMsIGl0IGlzIHBvc3NpYmxlDQo+DQo+PiAgICAgICB9DQo+PiArICAgIGVsc2UNCj4+ICsg
ICAgICAgIGhlYWRlci0+cm9tX3JlZyA9IH4odW5zaWduZWQgaW50KTA7DQo+IE5vIG5lZWQgZm9y
IHRoZSBjYXN0Lg0KT2sNCj4NCj4+ICAgDQo+PiAgICAgICByZXR1cm4gKGNtZCAmIFBDSV9DT01N
QU5EX01FTU9SWSkgPyBtb2RpZnlfYmFycyhwZGV2LCBjbWQsIGZhbHNlKSA6IDA7DQo+PiAgIH0N
Cj4+IGRpZmYgLS1naXQgYS94ZW4vZHJpdmVycy92cGNpL21zaS5jIGIveGVuL2RyaXZlcnMvdnBj
aS9tc2kuYw0KPj4gaW5kZXggNTc1N2E3YWVkMjBmLi41ZGYzZGZhODI0M2MgMTAwNjQ0DQo+PiAt
LS0gYS94ZW4vZHJpdmVycy92cGNpL21zaS5jDQo+PiArKysgYi94ZW4vZHJpdmVycy92cGNpL21z
aS5jDQo+PiBAQCAtMTkwLDYgKzE5MCw4IEBAIHN0YXRpYyBpbnQgaW5pdF9tc2koc3RydWN0IHBj
aV9kZXYgKnBkZXYpDQo+PiAgICAgICB1aW50MTZfdCBjb250cm9sOw0KPj4gICAgICAgaW50IHJl
dDsNCj4+ICAgDQo+PiArICAgIEFTU0VSVCghIXJ3X2lzX3dyaXRlX2xvY2tlZCgmcGRldi0+ZG9t
YWluLT52cGNpX3J3bG9jaykpOw0KPj4gKw0KPj4gICAgICAgaWYgKCAhcG9zICkNCj4+ICAgICAg
ICAgICByZXR1cm4gMDsNCj4+ICAgDQo+PiBAQCAtMjY1LDcgKzI2Nyw3IEBAIFJFR0lTVEVSX1ZQ
Q0lfSU5JVChpbml0X21zaSwgVlBDSV9QUklPUklUWV9MT1cpOw0KPj4gICANCj4+ICAgdm9pZCB2
cGNpX2R1bXBfbXNpKHZvaWQpDQo+PiAgIHsNCj4+IC0gICAgY29uc3Qgc3RydWN0IGRvbWFpbiAq
ZDsNCj4+ICsgICAgc3RydWN0IGRvbWFpbiAqZDsNCj4+ICAgDQo+PiAgICAgICByY3VfcmVhZF9s
b2NrKCZkb21saXN0X3JlYWRfbG9jayk7DQo+PiAgICAgICBmb3JfZWFjaF9kb21haW4gKCBkICkN
Cj4+IEBAIC0yNzcsNiArMjc5LDkgQEAgdm9pZCB2cGNpX2R1bXBfbXNpKHZvaWQpDQo+PiAgIA0K
Pj4gICAgICAgICAgIHByaW50aygidlBDSSBNU0kvTVNJLVggZCVkXG4iLCBkLT5kb21haW5faWQp
Ow0KPj4gICANCj4+ICsgICAgICAgIGlmICggIXJlYWRfdHJ5bG9jaygmZC0+dnBjaV9yd2xvY2sp
ICkNCj4+ICsgICAgICAgICAgICBjb250aW51ZTsNCj4+ICsNCj4+ICAgICAgICAgICBmb3JfZWFj
aF9wZGV2ICggZCwgcGRldiApDQo+PiAgICAgICAgICAgew0KPj4gICAgICAgICAgICAgICBjb25z
dCBzdHJ1Y3QgdnBjaV9tc2kgKm1zaTsNCj4+IEBAIC0zMjYsNiArMzMxLDcgQEAgdm9pZCB2cGNp
X2R1bXBfbXNpKHZvaWQpDQo+PiAgICAgICAgICAgICAgIHNwaW5fdW5sb2NrKCZwZGV2LT52cGNp
LT5sb2NrKTsNCj4+ICAgICAgICAgICAgICAgcHJvY2Vzc19wZW5kaW5nX3NvZnRpcnFzKCk7DQo+
PiAgICAgICAgICAgfQ0KPj4gKyAgICAgICAgcmVhZF91bmxvY2soJmQtPnZwY2lfcndsb2NrKTsN
Cj4gU2FtZSBoZXJlLCB5b3UgYXJlIGNhbGxpbmcgcHJvY2Vzc19wZW5kaW5nX3NvZnRpcnFzIHdo
aWxlIGhvbGRpbmcNCj4gdnBjaV9yd2xvY2suDQpTYW1lIGFzIGFib3ZlDQo+DQo+PiAgICAgICB9
DQo+PiAgICAgICByY3VfcmVhZF91bmxvY2soJmRvbWxpc3RfcmVhZF9sb2NrKTsNCj4+ICAgfQ0K
Pj4gZGlmZiAtLWdpdCBhL3hlbi9kcml2ZXJzL3ZwY2kvbXNpeC5jIGIveGVuL2RyaXZlcnMvdnBj
aS9tc2l4LmMNCj4+IGluZGV4IDg0NmYxYjhkNzAzOC4uNTI5NmQ2MDI1ZDhlIDEwMDY0NA0KPj4g
LS0tIGEveGVuL2RyaXZlcnMvdnBjaS9tc2l4LmMNCj4+ICsrKyBiL3hlbi9kcml2ZXJzL3ZwY2kv
bXNpeC5jDQo+PiBAQCAtMTM4LDYgKzEzOCw3IEBAIHN0YXRpYyB2b2lkIGNvbnRyb2xfd3JpdGUo
Y29uc3Qgc3RydWN0IHBjaV9kZXYgKnBkZXYsIHVuc2lnbmVkIGludCByZWcsDQo+PiAgICAgICAg
ICAgcGNpX2NvbmZfd3JpdGUxNihwZGV2LT5zYmRmLCByZWcsIHZhbCk7DQo+PiAgIH0NCj4+ICAg
DQo+PiArLyogVGhpcyBtdXN0IGhvbGQgZG9tYWluJ3MgdnBjaV9yd2xvY2sgaW4gd3JpdGUgbW9k
ZS4gKi8NCj4+ICAgc3RhdGljIHN0cnVjdCB2cGNpX21zaXggKm1zaXhfZmluZChjb25zdCBzdHJ1
Y3QgZG9tYWluICpkLCB1bnNpZ25lZCBsb25nIGFkZHIpDQo+PiAgIHsNCj4+ICAgICAgIHN0cnVj
dCB2cGNpX21zaXggKm1zaXg7DQo+PiBAQCAtMTU4LDcgKzE1OSwxMiBAQCBzdGF0aWMgc3RydWN0
IHZwY2lfbXNpeCAqbXNpeF9maW5kKGNvbnN0IHN0cnVjdCBkb21haW4gKmQsIHVuc2lnbmVkIGxv
bmcgYWRkcikNCj4+ICAgDQo+PiAgIHN0YXRpYyBpbnQgbXNpeF9hY2NlcHQoc3RydWN0IHZjcHUg
KnYsIHVuc2lnbmVkIGxvbmcgYWRkcikNCj4+ICAgew0KPj4gLSAgICByZXR1cm4gISFtc2l4X2Zp
bmQodi0+ZG9tYWluLCBhZGRyKTsNCj4+ICsgICAgaW50IHJjOw0KPj4gKw0KPj4gKyAgICByZWFk
X2xvY2soJnYtPmRvbWFpbi0+dnBjaV9yd2xvY2spOw0KPj4gKyAgICByYyA9ICEhbXNpeF9maW5k
KHYtPmRvbWFpbiwgYWRkcik7DQo+PiArICAgIHJlYWRfdW5sb2NrKCZ2LT5kb21haW4tPnZwY2lf
cndsb2NrKTsNCj4gTmV3bGluZSBiZWZvcmUgcmV0dXJuLg0KT2sNCj4NCj4+ICsgICAgcmV0dXJu
IHJjOw0KPj4gICB9DQo+PiAgIA0KPj4gICBzdGF0aWMgYm9vbCBhY2Nlc3NfYWxsb3dlZChjb25z
dCBzdHJ1Y3QgcGNpX2RldiAqcGRldiwgdW5zaWduZWQgbG9uZyBhZGRyLA0KPj4gaW5kZXggZmIw
OTQ3MTc5Yjc5Li4xNmJiM2I4MzJlNmEgMTAwNjQ0DQo+PiAtLS0gYS94ZW4vZHJpdmVycy92cGNp
L3ZwY2kuYw0KPj4gKysrIGIveGVuL2RyaXZlcnMvdnBjaS92cGNpLmMNCj4+IEBAIC04OSwyMiAr
MTA0LDI4IEBAIGludCB2cGNpX2FkZF9oYW5kbGVycyhzdHJ1Y3QgcGNpX2RldiAqcGRldikNCj4+
ICAgfQ0KPj4gICAjZW5kaWYgLyogX19YRU5fXyAqLw0KPj4gICANCj4+IC1zdGF0aWMgaW50IHZw
Y2lfcmVnaXN0ZXJfY21wKGNvbnN0IHN0cnVjdCB2cGNpX3JlZ2lzdGVyICpyMSwNCj4+IC0gICAg
ICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IHN0cnVjdCB2cGNpX3JlZ2lzdGVyICpyMikN
Cj4+ICtzdGF0aWMgaW50IHZwY2lfb2Zmc2V0X2NtcCh1bnNpZ25lZCBpbnQgcjFfb2Zmc2V0LCB1
bnNpZ25lZCBpbnQgcjFfc2l6ZSwNCj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICB1bnNp
Z25lZCBpbnQgcjJfb2Zmc2V0LCB1bnNpZ25lZCBpbnQgcjJfc2l6ZSkNCj4+ICAgew0KPj4gICAg
ICAgLyogUmV0dXJuIDAgaWYgcmVnaXN0ZXJzIG92ZXJsYXAuICovDQo+PiAtICAgIGlmICggcjEt
Pm9mZnNldCA8IHIyLT5vZmZzZXQgKyByMi0+c2l6ZSAmJg0KPj4gLSAgICAgICAgIHIyLT5vZmZz
ZXQgPCByMS0+b2Zmc2V0ICsgcjEtPnNpemUgKQ0KPj4gKyAgICBpZiAoIHIxX29mZnNldCA8IHIy
X29mZnNldCArIHIyX3NpemUgJiYNCj4+ICsgICAgICAgICByMl9vZmZzZXQgPCByMV9vZmZzZXQg
KyByMV9zaXplICkNCj4+ICAgICAgICAgICByZXR1cm4gMDsNCj4+IC0gICAgaWYgKCByMS0+b2Zm
c2V0IDwgcjItPm9mZnNldCApDQo+PiArICAgIGlmICggcjFfb2Zmc2V0IDwgcjJfb2Zmc2V0ICkN
Cj4+ICAgICAgICAgICByZXR1cm4gLTE7DQo+PiAtICAgIGlmICggcjEtPm9mZnNldCA+IHIyLT5v
ZmZzZXQgKQ0KPj4gKyAgICBpZiAoIHIxX29mZnNldCA+IHIyX29mZnNldCApDQo+PiAgICAgICAg
ICAgcmV0dXJuIDE7DQo+PiAgIA0KPj4gICAgICAgQVNTRVJUX1VOUkVBQ0hBQkxFKCk7DQo+PiAg
ICAgICByZXR1cm4gMDsNCj4+ICAgfQ0KPj4gICANCj4+ICtzdGF0aWMgaW50IHZwY2lfcmVnaXN0
ZXJfY21wKGNvbnN0IHN0cnVjdCB2cGNpX3JlZ2lzdGVyICpyMSwNCj4+ICsgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgIGNvbnN0IHN0cnVjdCB2cGNpX3JlZ2lzdGVyICpyMikNCj4+ICt7DQo+
PiArICAgIHJldHVybiB2cGNpX29mZnNldF9jbXAocjEtPm9mZnNldCwgcjEtPnNpemUsIHIyLT5v
ZmZzZXQsIHIyLT5zaXplKTsNCj4+ICt9DQo+IFNlZWluZyBob3cgdGhpcyBnZXRzIHVzZWQgYmVs
b3cgSSdtIG5vdCBzdXJlIGl0J3MgdmVyeSBoZWxwZnVsIHRvDQo+IHJldXNlIHZwY2lfcmVnaXN0
ZXJfY21wLCBzZWUgbXkgY29tbWVudCBiZWxvdy4NClllcywgdGhlIG9ubHkgdGhpbmcgd2hpY2gg
aXMgdXNlZCBpcyB0aGUgZmlyc3QgY2hlY2sgZm9yIHRoZSBvdmVybGFwDQo+DQo+PiArDQo+PiAg
IC8qIER1bW15IGhvb2tzLCB3cml0ZXMgYXJlIGlnbm9yZWQsIHJlYWRzIHJldHVybiAxJ3MgKi8N
Cj4+ICAgc3RhdGljIHVpbnQzMl90IHZwY2lfaWdub3JlZF9yZWFkKGNvbnN0IHN0cnVjdCBwY2lf
ZGV2ICpwZGV2LCB1bnNpZ25lZCBpbnQgcmVnLA0KPj4gICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgdm9pZCAqZGF0YSkNCj4+IEBAIC0xMjksNiArMTUwLDcgQEAgdWludDMyX3Qg
dnBjaV9od19yZWFkMzIoY29uc3Qgc3RydWN0IHBjaV9kZXYgKnBkZXYsIHVuc2lnbmVkIGludCBy
ZWcsDQo+PiAgICAgICByZXR1cm4gcGNpX2NvbmZfcmVhZDMyKHBkZXYtPnNiZGYsIHJlZyk7DQo+
PiAgIH0NCj4+ICAgDQo+PiArLyogVGhpcyBtdXN0IGhvbGQgZG9tYWluJ3MgdnBjaV9yd2xvY2sg
aW4gd3JpdGUgbW9kZS4gKi8NCj4+ICAgaW50IHZwY2lfYWRkX3JlZ2lzdGVyKHN0cnVjdCB2cGNp
ICp2cGNpLCB2cGNpX3JlYWRfdCAqcmVhZF9oYW5kbGVyLA0KPj4gICAgICAgICAgICAgICAgICAg
ICAgICAgdnBjaV93cml0ZV90ICp3cml0ZV9oYW5kbGVyLCB1bnNpZ25lZCBpbnQgb2Zmc2V0LA0K
Pj4gICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgaW50IHNpemUsIHZvaWQgKmRhdGEp
DQo+PiBAQCAtMTUyLDggKzE3NCw2IEBAIGludCB2cGNpX2FkZF9yZWdpc3RlcihzdHJ1Y3QgdnBj
aSAqdnBjaSwgdnBjaV9yZWFkX3QgKnJlYWRfaGFuZGxlciwNCj4+ICAgICAgIHItPm9mZnNldCA9
IG9mZnNldDsNCj4+ICAgICAgIHItPnByaXZhdGUgPSBkYXRhOw0KPj4gICANCj4+IC0gICAgc3Bp
bl9sb2NrKCZ2cGNpLT5sb2NrKTsNCj4+IC0NCj4+ICAgICAgIC8qIFRoZSBsaXN0IG9mIGhhbmRs
ZXJzIG11c3QgYmUga2VwdCBzb3J0ZWQgYXQgYWxsIHRpbWVzLiAqLw0KPj4gICAgICAgbGlzdF9m
b3JfZWFjaCAoIHByZXYsICZ2cGNpLT5oYW5kbGVycyApDQo+PiAgICAgICB7DQo+PiBAQCAtMTY1
LDI1ICsxODUsMjMgQEAgaW50IHZwY2lfYWRkX3JlZ2lzdGVyKHN0cnVjdCB2cGNpICp2cGNpLCB2
cGNpX3JlYWRfdCAqcmVhZF9oYW5kbGVyLA0KPj4gICAgICAgICAgICAgICBicmVhazsNCj4+ICAg
ICAgICAgICBpZiAoIGNtcCA9PSAwICkNCj4+ICAgICAgICAgICB7DQo+PiAtICAgICAgICAgICAg
c3Bpbl91bmxvY2soJnZwY2ktPmxvY2spOw0KPj4gICAgICAgICAgICAgICB4ZnJlZShyKTsNCj4+
ICAgICAgICAgICAgICAgcmV0dXJuIC1FRVhJU1Q7DQo+PiAgICAgICAgICAgfQ0KPj4gICAgICAg
fQ0KPj4gICANCj4+ICAgICAgIGxpc3RfYWRkX3RhaWwoJnItPm5vZGUsIHByZXYpOw0KPj4gLSAg
ICBzcGluX3VubG9jaygmdnBjaS0+bG9jayk7DQo+PiAgIA0KPj4gICAgICAgcmV0dXJuIDA7DQo+
PiAgIH0NCj4+ICAgDQo+PiArLyogVGhpcyBtdXN0IGhvbGQgZG9tYWluJ3MgdnBjaV9yd2xvY2sg
aW4gd3JpdGUgbW9kZS4gKi8NCj4+ICAgaW50IHZwY2lfcmVtb3ZlX3JlZ2lzdGVyKHN0cnVjdCB2
cGNpICp2cGNpLCB1bnNpZ25lZCBpbnQgb2Zmc2V0LA0KPj4gICAgICAgICAgICAgICAgICAgICAg
ICAgICAgdW5zaWduZWQgaW50IHNpemUpDQo+PiAgIHsNCj4+ICAgICAgIGNvbnN0IHN0cnVjdCB2
cGNpX3JlZ2lzdGVyIHIgPSB7IC5vZmZzZXQgPSBvZmZzZXQsIC5zaXplID0gc2l6ZSB9Ow0KPj4g
ICAgICAgc3RydWN0IHZwY2lfcmVnaXN0ZXIgKnJtOw0KPj4gICANCj4+IC0gICAgc3Bpbl9sb2Nr
KCZ2cGNpLT5sb2NrKTsNCj4+ICAgICAgIGxpc3RfZm9yX2VhY2hfZW50cnkgKCBybSwgJnZwY2kt
PmhhbmRsZXJzLCBub2RlICkNCj4+ICAgICAgIHsNCj4+ICAgICAgICAgICBpbnQgY21wID0gdnBj
aV9yZWdpc3Rlcl9jbXAoJnIsIHJtKTsNCj4+IEBAIC0xOTUsMTQgKzIxMywxMiBAQCBpbnQgdnBj
aV9yZW1vdmVfcmVnaXN0ZXIoc3RydWN0IHZwY2kgKnZwY2ksIHVuc2lnbmVkIGludCBvZmZzZXQs
DQo+PiAgICAgICAgICAgaWYgKCAhY21wICYmIHJtLT5vZmZzZXQgPT0gb2Zmc2V0ICYmIHJtLT5z
aXplID09IHNpemUgKQ0KPj4gICAgICAgICAgIHsNCj4+ICAgICAgICAgICAgICAgbGlzdF9kZWwo
JnJtLT5ub2RlKTsNCj4+IC0gICAgICAgICAgICBzcGluX3VubG9jaygmdnBjaS0+bG9jayk7DQo+
PiAgICAgICAgICAgICAgIHhmcmVlKHJtKTsNCj4+ICAgICAgICAgICAgICAgcmV0dXJuIDA7DQo+
PiAgICAgICAgICAgfQ0KPj4gICAgICAgICAgIGlmICggY21wIDw9IDAgKQ0KPj4gICAgICAgICAg
ICAgICBicmVhazsNCj4+ICAgICAgIH0NCj4+IC0gICAgc3Bpbl91bmxvY2soJnZwY2ktPmxvY2sp
Ow0KPj4gICANCj4+ICAgICAgIHJldHVybiAtRU5PRU5UOw0KPj4gICB9DQo+PiBAQCAtMzEwLDcg
KzMyNiw3IEBAIHN0YXRpYyB1aW50MzJfdCBtZXJnZV9yZXN1bHQodWludDMyX3QgZGF0YSwgdWlu
dDMyX3QgbmV3LCB1bnNpZ25lZCBpbnQgc2l6ZSwNCj4+ICAgDQo+PiAgIHVpbnQzMl90IHZwY2lf
cmVhZChwY2lfc2JkZl90IHNiZGYsIHVuc2lnbmVkIGludCByZWcsIHVuc2lnbmVkIGludCBzaXpl
KQ0KPj4gICB7DQo+PiAtICAgIGNvbnN0IHN0cnVjdCBkb21haW4gKmQgPSBjdXJyZW50LT5kb21h
aW47DQo+PiArICAgIHN0cnVjdCBkb21haW4gKmQgPSBjdXJyZW50LT5kb21haW47DQo+PiAgICAg
ICBjb25zdCBzdHJ1Y3QgcGNpX2RldiAqcGRldjsNCj4+ICAgICAgIGNvbnN0IHN0cnVjdCB2cGNp
X3JlZ2lzdGVyICpyOw0KPj4gICAgICAgdW5zaWduZWQgaW50IGRhdGFfb2Zmc2V0ID0gMDsNCj4+
IEBAIC0zMjcsNiArMzQzLDcgQEAgdWludDMyX3QgdnBjaV9yZWFkKHBjaV9zYmRmX3Qgc2JkZiwg
dW5zaWduZWQgaW50IHJlZywgdW5zaWduZWQgaW50IHNpemUpDQo+PiAgICAgICBpZiAoICFwZGV2
ICkNCj4+ICAgICAgICAgICByZXR1cm4gdnBjaV9yZWFkX2h3KHNiZGYsIHJlZywgc2l6ZSk7DQo+
PiAgIA0KPj4gKyAgICByZWFkX2xvY2soJmQtPnZwY2lfcndsb2NrKTsNCj4gQWZ0ZXIgdGFraW5n
IHRoZSBkb21haW4gbG9jayB5b3UgbmVlZCB0byBjaGVjayB0aGF0IHBkZXYtPnZwY2kgIT0NCj4g
TlVMTCwgYXMgdnBjaV9yZW1vdmVfZGV2aWNlIHdpbGwgc2V0IHBkZXYtPnZwY2kgPT0gTlVMTCBi
ZWZvcmUNCj4gcmVtb3ZpbmcgdGhlIGRldmljZSBmcm9tIHRoZSBkb21haW4uIFNhbWUgYXBwbGll
cyB0byB2cGNpX2FkZF9oYW5kbGVycw0KPiB3aGljaCB3aWxsIGJlIGNhbGxlZCB3aXRoIHRoZSBk
ZXZpY2UgYWxyZWFkeSBhZGRlZCB0byB0aGUgZG9tYWluLCBidXQNCj4gd2l0aCBwZGV2LT52cGNp
ID09IE5VTEwuDQpTdXJlLCB3aWxsIGFkZA0KPg0KPiBXZSB3b3VsZCBhbHNvIG5lZWQgc29tZSBr
aW5kIG9mIHByb3RlY3Rpb24gYXJyb3VuZA0KPiBwY2lfZ2V0X3BkZXZfYnlfZG9tYWluIHNvIHRo
YXQgZGV2aWNlcyBhcmUgbm90IHJlbW92ZWQgKGZyb20gdGhlDQo+IGRvbWFpbikgd2hpbGUgd2Ug
YXJlIGl0ZXJhdGluZyBvdmVyIGl0Lg0KQWdhaW4sIHRoaXMgaXMgYSBwcm9ibGVtLiBBbmQgd2Ug
bmVlZCB0byBmaW5kIGEgd2F5IHRvIHNvbHZlIHRoYXQNCj4NCj4+ICAgICAgIHNwaW5fbG9jaygm
cGRldi0+dnBjaS0+bG9jayk7DQo+PiAgIA0KPj4gICAgICAgLyogUmVhZCBmcm9tIHRoZSBoYXJk
d2FyZSBvciB0aGUgZW11bGF0ZWQgcmVnaXN0ZXIgaGFuZGxlcnMuICovDQo+PiBAQCAtMzcxLDYg
KzM4OCw3IEBAIHVpbnQzMl90IHZwY2lfcmVhZChwY2lfc2JkZl90IHNiZGYsIHVuc2lnbmVkIGlu
dCByZWcsIHVuc2lnbmVkIGludCBzaXplKQ0KPj4gICAgICAgICAgIEFTU0VSVChkYXRhX29mZnNl
dCA8IHNpemUpOw0KPj4gICAgICAgfQ0KPj4gICAgICAgc3Bpbl91bmxvY2soJnBkZXYtPnZwY2kt
PmxvY2spOw0KPj4gKyAgICByZWFkX3VubG9jaygmZC0+dnBjaV9yd2xvY2spOw0KPj4gICANCj4+
ICAgICAgIGlmICggZGF0YV9vZmZzZXQgPCBzaXplICkNCj4+ICAgICAgIHsNCj4+IEBAIC00MTAs
MTQgKzQyOCwzNyBAQCBzdGF0aWMgdm9pZCB2cGNpX3dyaXRlX2hlbHBlcihjb25zdCBzdHJ1Y3Qg
cGNpX2RldiAqcGRldiwNCj4+ICAgICAgICAgICAgICAgIHItPnByaXZhdGUpOw0KPj4gICB9DQo+
PiAgIA0KPj4gK3N0YXRpYyBib29sIHZwY2lfaGVhZGVyX3dyaXRlX2xvY2soY29uc3Qgc3RydWN0
IHBjaV9kZXYgKnBkZXYsDQo+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1
bnNpZ25lZCBpbnQgc3RhcnQsIHVuc2lnbmVkIGludCBzaXplKQ0KPiBJIHRoaW5rIHRoaXMgc2hv
dWxkIGxpdmUgaW4gaGVhZGVyLmMsIGZvciBjb25zaXN0ZW5jeS4NCk9rLCB3aWxsIG1vdmUNCj4N
Cj4gSSdtIGFsc28gbm90IHN1cmUgaXQncyB3b3J0aCBhZGRpbmcgdnBjaV9vZmZzZXRfY21wOiB5
b3UganVzdCBuZWVkIHRvDQo+IGRvIGEgcmFuZ2Ugb3ZlcmxhcCBjaGVjaywgYW5kIHRoYXQgY2Fu
IGJlIGVhc2lseSBvcGVuIGNvZGVkLiBJdCdzIGp1c3QNCj4gdGhlIGZpcnN0ICdpZicgaW4gdnBj
aV9yZWdpc3Rlcl9jbXAgdGhhdCB5b3Ugd2FudCwgdGhlIHJlc3Qgb2YgdGhlDQo+IGNvZGUgaXMg
anVzdCBhZGRpbmcgb3ZlcmhlYWQuDQpBZ3JlZQ0KPg0KPj4gK3sNCj4+ICsgICAgLyoNCj4+ICsg
ICAgICogV3JpdGluZyB0aGUgY29tbWFuZCByZWdpc3RlciBhbmQgUk9NIEJBUiByZWdpc3RlciBt
YXkgdHJpZ2dlcg0KPj4gKyAgICAgKiBtb2RpZnlfYmFycyB0byBydW4gd2hpY2ggaW4gdHVybiBt
YXkgYWNjZXNzIG11bHRpcGxlIHBkZXZzIHdoaWxlDQo+PiArICAgICAqIGNoZWNraW5nIGZvciB0
aGUgZXhpc3RpbmcgQkFSJ3Mgb3ZlcmxhcC4gVGhlIG92ZXJsYXBwaW5nIGNoZWNrLCBpZiBkb25l
DQo+PiArICAgICAqIHVuZGVyIHRoZSByZWFkIGxvY2ssIHJlcXVpcmVzIHZwY2ktPmxvY2sgdG8g
YmUgYWNxdWlyZWQgb24gYm90aCBkZXZpY2VzDQo+PiArICAgICAqIGJlaW5nIGNvbXBhcmVkLCB3
aGljaCBtYXkgcHJvZHVjZSBhIGRlYWRsb2NrLiBJdCBpcyBub3QgcG9zc2libGUgdG8NCj4+ICsg
ICAgICogdXBncmFkZSByZWFkIGxvY2sgdG8gd3JpdGUgbG9jayBpbiBzdWNoIGEgY2FzZS4gU28s
IGluIG9yZGVyIHRvIHByZXZlbnQNCj4+ICsgICAgICogdGhlIGRlYWRsb2NrLCBjaGVjayB3aGlj
aCByZWdpc3RlcnMgYXJlIGdvaW5nIHRvIGJlIHdyaXR0ZW4gYW5kIGFjcXVpcmUNCj4+ICsgICAg
ICogdGhlIGxvY2sgaW4gdGhlIGFwcHJvcHJpYXRlIG1vZGUgZnJvbSB0aGUgYmVnaW5uaW5nLg0K
Pj4gKyAgICAgKi8NCj4+ICsgICAgaWYgKCAhdnBjaV9vZmZzZXRfY21wKHN0YXJ0LCBzaXplLCBQ
Q0lfQ09NTUFORCwgMikgKQ0KPj4gKyAgICAgICAgcmV0dXJuIHRydWU7DQo+PiArDQo+PiArICAg
IGlmICggIXZwY2lfb2Zmc2V0X2NtcChzdGFydCwgc2l6ZSwgcGRldi0+dnBjaS0+aGVhZGVyLnJv
bV9yZWcsIDQpICkNCj4gTm8gbmVlZCBmb3IgdGhlIGNvbXBhcmlzb24gaWYgcm9tX3JlZyBpcyB1
bnNldC4gQWxzbyB5b3UgY2FuIE9SIGJvdGgNCj4gY29uZGl0aW9ucyBpbnRvIGEgc2luZ2xlIGlm
Lg0KSWYgd2Ugb3BlbiBjb2RlIHZwY2lfb2Zmc2V0X2NtcCB3aXRoIGEgc2luZ2xlIGlmIGFsbCB0
aGlzIGlzIGdvaW5nDQp0byBiZSBhIGJpdCBjbHVtc3k6DQoNCiDCoMKgwqAgaWYgKCByMV9vZmZz
ZXQgPCByMl9vZmZzZXQgKyByMl9zaXplICYmDQogwqDCoMKgwqDCoMKgwqDCoCByMl9vZmZzZXQg
PCByMV9vZmZzZXQgKyByMV9zaXplICkNCiDCoMKgwqDCoMKgwqDCoCByZXR1cm4gMDsNClRoaXMg
aXMgYSBzaW5nbGUgY2hlY2suDQpOb3cgd2UgbmVlZCB0byBjaGVjayB0d28gcmVnaXN0ZXJzIHdp
dGggdGhlIGNvZGUgYWJvdmUgYW5kDQphbHNvIGNoZWNrIHRoYXQgcGRldi0+dnBjaS0+aGVhZGVy
LnJvbV9yZWcgIT0gMA0KDQpJIHRoaW5rIGl0IHdvdWxkIGJlIG1vcmUgcmVhZGFibGUgaWYgd2Ug
aGF2ZSBhIHRpbnkgaGVscGVyIGZ1bmN0aW9uDQoNCnN0YXRpYyBib29sIHZwY2lfb2Zmc2V0X2Nt
cCh1bnNpZ25lZCBpbnQgcjFfb2Zmc2V0LCB1bnNpZ25lZCBpbnQgcjFfc2l6ZSwNCiDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHVuc2lnbmVkIGlu
dCByMl9vZmZzZXQsIHVuc2lnbmVkIGludCByMl9zaXplKQ0Kew0KIMKgwqDCoCAvKiBSZXR1cm4g
MCBpZiByZWdpc3RlcnMgb3ZlcmxhcC4gKi8NCiDCoMKgwqAgaWYgKCByMV9vZmZzZXQgPCByMl9v
ZmZzZXQgKyByMl9zaXplICYmDQogwqDCoMKgwqDCoMKgwqDCoCByMl9vZmZzZXQgPCByMV9vZmZz
ZXQgKyByMV9zaXplICkNCiDCoMKgwqDCoMKgwqDCoCByZXR1cm4gZmFsc2U7DQogwqDCoMKgIHJl
dHVybiB0cnVlOw0KfQ0KDQpTbywgdGhlbiB3ZSBjYW4gaGF2ZSBzb21ldGhpbmcgbGlrZQ0KDQpz
dGF0aWMgYm9vbCB2cGNpX2hlYWRlcl93cml0ZV9sb2NrKGNvbnN0IHN0cnVjdCBwY2lfZGV2ICpw
ZGV2LA0KIMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgIHVuc2lnbmVkIGludCBzdGFydCwgdW5zaWduZWQgaW50IHNpemUp
DQp7DQogwqDCoMKgIGlmICggIXZwY2lfb2Zmc2V0X2NtcChzdGFydCwgc2l6ZSwgUENJX0NPTU1B
TkQsIDIpIHx8DQogwqDCoMKgwqDCoMKgwqDCoCAocGRldi0+dnBjaS0+aGVhZGVyLnJvbV9yZWcg
JiYNCiDCoMKgwqDCoMKgwqDCoMKgwqAgIXZwY2lfb2Zmc2V0X2NtcChzdGFydCwgc2l6ZSwgcGRl
di0+dnBjaS0+aGVhZGVyLnJvbV9yZWcsIDQpKSApDQogwqDCoMKgwqDCoMKgwqAgcmV0dXJuIHRy
dWU7DQoNCiDCoMKgwqAgcmV0dXJuIGZhbHNlOw0KfQ0KDQo+DQo+PiArICAgICAgICByZXR1cm4g
dHJ1ZTsNCj4+ICsNCj4+ICsgICAgcmV0dXJuIGZhbHNlOw0KPj4gK30NCj4+ICsNCj4+ICAgdm9p
ZCB2cGNpX3dyaXRlKHBjaV9zYmRmX3Qgc2JkZiwgdW5zaWduZWQgaW50IHJlZywgdW5zaWduZWQg
aW50IHNpemUsDQo+PiAgICAgICAgICAgICAgICAgICB1aW50MzJfdCBkYXRhKQ0KPj4gICB7DQo+
PiAtICAgIGNvbnN0IHN0cnVjdCBkb21haW4gKmQgPSBjdXJyZW50LT5kb21haW47DQo+PiArICAg
IHN0cnVjdCBkb21haW4gKmQgPSBjdXJyZW50LT5kb21haW47DQo+PiAgICAgICBjb25zdCBzdHJ1
Y3QgcGNpX2RldiAqcGRldjsNCj4+ICAgICAgIGNvbnN0IHN0cnVjdCB2cGNpX3JlZ2lzdGVyICpy
Ow0KPj4gICAgICAgdW5zaWduZWQgaW50IGRhdGFfb2Zmc2V0ID0gMDsNCj4+ICAgICAgIGNvbnN0
IHVuc2lnbmVkIGxvbmcgKnJvX21hcCA9IHBjaV9nZXRfcm9fbWFwKHNiZGYuc2VnKTsNCj4+ICsg
ICAgYm9vbCB3cml0ZV9sb2NrZWQgPSBmYWxzZTsNCj4+ICAgDQo+PiAgICAgICBpZiAoICFzaXpl
ICkNCj4+ICAgICAgIHsNCj4+IEBAIC00NDAsNyArNDgxLDE3IEBAIHZvaWQgdnBjaV93cml0ZShw
Y2lfc2JkZl90IHNiZGYsIHVuc2lnbmVkIGludCByZWcsIHVuc2lnbmVkIGludCBzaXplLA0KPj4g
ICAgICAgICAgIHJldHVybjsNCj4+ICAgICAgIH0NCj4+ICAgDQo+PiAtICAgIHNwaW5fbG9jaygm
cGRldi0+dnBjaS0+bG9jayk7DQo+PiArICAgIGlmICggdnBjaV9oZWFkZXJfd3JpdGVfbG9jayhw
ZGV2LCByZWcsIHNpemUpICkNCj4+ICsgICAgew0KPj4gKyAgICAgICAgLyogR2FpbiBleGNsdXNp
dmUgYWNjZXNzIHRvIGFsbCBvZiB0aGUgZG9tYWluIHBkZXZzIHZwY2kuICovDQo+PiArICAgICAg
ICB3cml0ZV9sb2NrKCZkLT52cGNpX3J3bG9jayk7DQo+PiArICAgICAgICB3cml0ZV9sb2NrZWQg
PSB0cnVlOw0KPiBIZXJlIHlvdSBuZWVkIHRvIGNoZWNrIHRoYXQgcGRldi0+dnBjaSAhPSBOVUxM
Li4uDQpXaWxsIGRvDQo+DQo+PiArICAgIH0NCj4+ICsgICAgZWxzZQ0KPj4gKyAgICB7DQo+PiAr
ICAgICAgICByZWFkX2xvY2soJmQtPnZwY2lfcndsb2NrKTsNCj4gLi4uYW5kIGFsc28gaGVyZS4N
CldpbGwgZG8NCj4NCj4+ICsgICAgICAgIHNwaW5fbG9jaygmcGRldi0+dnBjaS0+bG9jayk7DQo+
PiArICAgIH0NCj4+ICAgDQo+PiAgICAgICAvKiBXcml0ZSB0aGUgdmFsdWUgdG8gdGhlIGhhcmR3
YXJlIG9yIGVtdWxhdGVkIHJlZ2lzdGVycy4gKi8NCj4+ICAgICAgIGxpc3RfZm9yX2VhY2hfZW50
cnkgKCByLCAmcGRldi0+dnBjaS0+aGFuZGxlcnMsIG5vZGUgKQ0KPj4gQEAgLTQ3NSw3ICs1MjYs
MTQgQEAgdm9pZCB2cGNpX3dyaXRlKHBjaV9zYmRmX3Qgc2JkZiwgdW5zaWduZWQgaW50IHJlZywg
dW5zaWduZWQgaW50IHNpemUsDQo+PiAgICAgICAgICAgICAgIGJyZWFrOw0KPj4gICAgICAgICAg
IEFTU0VSVChkYXRhX29mZnNldCA8IHNpemUpOw0KPj4gICAgICAgfQ0KPj4gLSAgICBzcGluX3Vu
bG9jaygmcGRldi0+dnBjaS0+bG9jayk7DQo+PiArDQo+PiArICAgIGlmICggd3JpdGVfbG9ja2Vk
ICkNCj4+ICsgICAgICAgIHdyaXRlX3VubG9jaygmZC0+dnBjaV9yd2xvY2spOw0KPj4gKyAgICBl
bHNlDQo+PiArICAgIHsNCj4+ICsgICAgICAgIHNwaW5fdW5sb2NrKCZwZGV2LT52cGNpLT5sb2Nr
KTsNCj4+ICsgICAgICAgIHJlYWRfdW5sb2NrKCZkLT52cGNpX3J3bG9jayk7DQo+PiArICAgIH0N
Cj4+ICAgDQo+PiAgICAgICBpZiAoIGRhdGFfb2Zmc2V0IDwgc2l6ZSApDQo+PiAgICAgICAgICAg
LyogVGFpbGluZyBnYXAsIHdyaXRlIHRoZSByZW1haW5pbmcuICovDQo+PiBkaWZmIC0tZ2l0IGEv
eGVuL2luY2x1ZGUveGVuL3NjaGVkLmggYi94ZW4vaW5jbHVkZS94ZW4vc2NoZWQuaA0KPj4gaW5k
ZXggMzdmNzhjYzRjNGM5Li5lY2QzNDQ4MWE3YWYgMTAwNjQ0DQo+PiAtLS0gYS94ZW4vaW5jbHVk
ZS94ZW4vc2NoZWQuaA0KPj4gKysrIGIveGVuL2luY2x1ZGUveGVuL3NjaGVkLmgNCj4+IEBAIC00
NDQsNiArNDQ0LDkgQEAgc3RydWN0IGRvbWFpbg0KPj4gICANCj4+ICAgI2lmZGVmIENPTkZJR19I
QVNfUENJDQo+PiAgICAgICBzdHJ1Y3QgbGlzdF9oZWFkIHBkZXZfbGlzdDsNCj4+ICsjaWZkZWYg
Q09ORklHX0hBU19WUENJDQo+PiArICAgIHJ3bG9ja190IHZwY2lfcndsb2NrOw0KPj4gKyNlbmRp
Zg0KPj4gICAjZW5kaWYNCj4+ICAgDQo+PiAgICNpZmRlZiBDT05GSUdfSEFTX1BBU1NUSFJPVUdI
DQo+PiBkaWZmIC0tZ2l0IGEveGVuL2luY2x1ZGUveGVuL3ZwY2kuaCBiL3hlbi9pbmNsdWRlL3hl
bi92cGNpLmgNCj4+IGluZGV4IGU4YWMxZWIzOTUxMy4uZTE5ZTQ2MmVlNWNiIDEwMDY0NA0KPj4g
LS0tIGEveGVuL2luY2x1ZGUveGVuL3ZwY2kuaA0KPj4gKysrIGIveGVuL2luY2x1ZGUveGVuL3Zw
Y2kuaA0KPj4gQEAgLTg4LDYgKzg4LDggQEAgc3RydWN0IHZwY2kgew0KPj4gICAgICAgICAgICAq
IGlzIG1hcHBlZCBpbnRvIGd1ZXN0IHAybSkgaWYgdGhlcmUncyBhIFJPTSBCQVIgb24gdGhlIGRl
dmljZS4NCj4+ICAgICAgICAgICAgKi8NCj4+ICAgICAgICAgICBib29sIHJvbV9lbmFibGVkICAg
ICAgOiAxOw0KPj4gKyAgICAgICAgLyogT2Zmc2V0IHRvIHRoZSBST00gQkFSIHJlZ2lzdGVyIGlm
IGFueS4gKi8NCj4+ICsgICAgICAgIHVuc2lnbmVkIGludCByb21fcmVnOw0KPiBDb3VsZCB5b3Ug
cGxlYXNlIHBsYWNlIHRoaXMgZmllbGQgYWZ0ZXIgJ3R5cGUnPyBUaGF0IHdpbGwgYXZvaWQgc29t
ZQ0KPiBwYWRkaW5nIGluIHRoZSBzdHJ1Y3R1cmUuDQpTdXJlDQo+DQo+IFRoYW5rcywgUm9nZXIu
DQpUaGFuayB5b3UsDQpPbGVrc2FuZHI=


From xen-devel-bounces@lists.xenproject.org Fri Feb 11 07:33:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 07:33:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270169.464378 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIQQJ-0008Mw-Qf; Fri, 11 Feb 2022 07:32:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270169.464378; Fri, 11 Feb 2022 07:32:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIQQJ-0008Mp-NG; Fri, 11 Feb 2022 07:32:55 +0000
Received: by outflank-mailman (input) for mailman id 270169;
 Fri, 11 Feb 2022 07:32:53 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nIQQH-0008Mf-Te; Fri, 11 Feb 2022 07:32:53 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nIQQH-0001La-Qc; Fri, 11 Feb 2022 07:32:53 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nIQQH-0002bN-7Z; Fri, 11 Feb 2022 07:32:53 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nIQQH-0004dR-7A; Fri, 11 Feb 2022 07:32:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ROyeeLbZ+Xoa2PRso3pAELfJISFGnuTVMPSjv81496k=; b=PWqa8QJpg4RiVCH5we3R2j2Ngy
	W9KP/Km89U2I1WYLfuwpSFL1T821FGwVz9BR54i6Q+BJxWyF9PGI6jA+SINT9ABxWX/HjGz+TIAPV
	jkT2pEMAo2Mjahh4BmzQtrZiQcKEpATX095uIMy9hCWwtPFfwwmMYEhtDNYV/LDrPyaA=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168080-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 168080: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-arm64-arm64-libvirt-raw:guest-start/debian.repeat:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=f1baf68e1383f6ed93eb9cff2866d46562607a43
X-Osstest-Versions-That:
    linux=e3c85076d7a6f986445b9008be7e7f83d1b0780a
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 11 Feb 2022 07:32:53 +0000

flight 168080 linux-linus real [real]
flight 168083 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/168080/
http://logs.test-lab.xenproject.org/osstest/logs/168083/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-libvirt-raw 17 guest-start/debian.repeat fail pass in 168083-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168078
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168078
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168078
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168078
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168078
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail like 168078
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168078
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168078
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168078
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                f1baf68e1383f6ed93eb9cff2866d46562607a43
baseline version:
 linux                e3c85076d7a6f986445b9008be7e7f83d1b0780a

Last test of basis   168078  2022-02-10 14:12:17 Z    0 days
Testing same since   168080  2022-02-11 00:09:22 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Akira Kawata <akirakawata1@gmail.com>
  Andrew Jeffery <andrew@aj.id.au>
  Antoine Tenart <atenart@kernel.org>
  Axel Rasmussen <axelrasmussen@google.com>
  Bjørn Mork <bjorn@mork.no>
  Cai Huoqing <cai.huoqing@linux.dev>
  Christian Brauner <brauner@kernel.org>
  Colin Foster <colin.foster@in-advantage.com>
  Conor Dooley <conor.dooley@microchip.com>
  Dan Carpenter <dan.carpenter@oracle.com>
  Daniel Klauer <daniel.klauer@gin.de>
  Daniel Latypov <dlatypov@google.com>
  Dave Ertman <david.m.ertman@intel.com>
  David S. Miller <davem@davemloft.net>
  Duoming Zhou <duoming@zju.edu.cn>
  Eric Dumazet <edumazet@google.com>
  Florian Westphal <fw@strlen.de>
  Geliang Tang <geliang.tang@suse.com>
  Gurucharan G <gurucharanx.g@intel.com>
  Harini Katakam <harini.katakam@xilinx.com>
  Ioana Ciornei <ioana.ciornei@nxp.com>
  Jakub Kicinski <kuba@kernel.org>
  Jay Vosburgh <jay.vosburgh@canonical.com>
  Jesse Brandeburg <jesse.brandeburg@intel.com>
  Joel Stanley <joel@jms.id.au>
  Jon Maloy <jmaloy@redhat.com>
  Jonathan Toppins <jtoppins@redhat.com>
  Jozsef Kadlecsik <kadlec@netfilter.org>
  Kishen Maloor <kishen.maloor@intel.com>
  Konrad Jankowski <konrad0.jankowski@intel.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Louis Peens <louis.peens@corigine.com>
  Mahesh Bandewar <maheshb@google.com>
  Marc Kleine-Budde <mkl@pengutronix.de>
  Marc St-Amand <mstamand@ciena.com>
  Mat Martineau <mathew.j.martineau@linux.intel.com>
  Matthieu Baerts <matthieu.baerts@tessares.net>
  Nicolas Ferre <nicolas.ferre@microchip.com>
  Oleksij Rempel <o.rempel@pengutronix.de>
  Oliver Hartkopp <socketcan@hartkopp.net>
  Pablo Neira Ayuso <pablo@netfilter.org>
  Paolo Abeni <pabeni@redhat.com>
  Pavel Parkhomenko <Pavel.Parkhomenko@baikalelectronics.ru>
  Raju Rangoju <Raju.Rangoju@amd.com>
  Robert-Ionut Alexa <robert-ionut.alexa@nxp.com>
  Samuel Mendoza-Jonas <samjonas@amazon.com>
  Sean Young <sean@mess.org>
  Shuah Khan <skhan@linuxfoundation.org>
  Simon Horman <simon.horman@corigine.com>
  Slark Xiao <slark_xiao@163.com>
  Soheil Hassas Yeganeh <soheil@google.com>
  Steen Hegelund <steen.hegelund@microchip.com>
  Sukadev Bhattiprolu <sukadev@linux.ibm.com>
  Sunitha Mekala <sunithax.d.mekala@intel.com>
  Tao Liu <xliutaox@google.com>
  Tom Rix <trix@redhat.com>
  Tony Nguyen <anthony.l.nguyen@intel.com>
  Victor Erminpour <victor.erminpour@oracle.com>
  Vlad Buslov <vladbu@nvidia.com>
  Vladimir Oltean <vladimir.oltean@nxp.com>
  Xin Long <lucien.xin@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   e3c85076d7a6..f1baf68e1383  f1baf68e1383f6ed93eb9cff2866d46562607a43 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Fri Feb 11 08:16:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 08:16:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270189.464388 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIR6N-0004hB-I9; Fri, 11 Feb 2022 08:16:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270189.464388; Fri, 11 Feb 2022 08:16:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIR6N-0004h4-F8; Fri, 11 Feb 2022 08:16:23 +0000
Received: by outflank-mailman (input) for mailman id 270189;
 Fri, 11 Feb 2022 08:16:22 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=17AN=S2=epam.com=prvs=4041139d62=oleksii_moisieiev@srs-se1.protection.inumbo.net>)
 id 1nIR6L-0004gy-W5
 for xen-devel@lists.xenproject.org; Fri, 11 Feb 2022 08:16:22 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e3e07288-8b12-11ec-8f75-fffcc8bd4f1a;
 Fri, 11 Feb 2022 09:16:20 +0100 (CET)
Received: from pps.filterd (m0174683.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 21B7vp4a013412;
 Fri, 11 Feb 2022 08:16:18 GMT
Received: from eur02-he1-obe.outbound.protection.outlook.com
 (mail-he1eur02lp2051.outbound.protection.outlook.com [104.47.5.51])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3e5krx83j9-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 11 Feb 2022 08:16:18 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com (2603:10a6:102:ea::23)
 by AM6PR03MB3704.eurprd03.prod.outlook.com (2603:10a6:209:30::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Fri, 11 Feb
 2022 08:16:14 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::c1c:f98:9dd:86e0]) by PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::c1c:f98:9dd:86e0%6]) with mapi id 15.20.4975.015; Fri, 11 Feb 2022
 08:16:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e3e07288-8b12-11ec-8f75-fffcc8bd4f1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Ba//JwY5geq8hygiHmRlMtIVGB3j3SlcjmRKyMVCqdD8FWltj4MC82FeTootjO38NiBaYEbzXMbAHS/4mKxn/ts/UExe195sUWJmsF9CL/PdBM6MdQoSyEzOtB1YsuOw9eVS98Hde+C18W9r79VLU8q+6sPNOC2dzqp522r54eQ/EoE/QcXcvI/IBEpQDPJg+HY1ZbgIR4SzW6HPw2rHzO+Ra+WGdgKgyJKs+6DgZJ69PivoBqf1+O54QODjqwnuXk117i9xAm1/ODam+u6Cyn1L8ddaRDUONSp+d0QyPM4UBy6DDVy+a2+aBiqxZO+tvEzmwaelEo0CMeos+X9KLg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=dqJeLMR7PPDVVxu2lAVtDPG0X6ZSZGr7+keXc3LyO4A=;
 b=GLprB86sLZfYoYqDquVDgiYFV+XGjK1vpXbjm4fgj6UL+Ge7TeXsIvU4cg93P6J7vYqxDi8G0m6WReG3N89HP9LONtFojkL5s0Hu/a50GtgK4PwngrBbUBKPvqntfsd3W8NH5Cmn3k6WauR2RZ6JNhssTyFn4R0k67VFq7YFgL0kXuaSJPR7XmzU1IP4PUKfaP4lvTOYhmK6t6EYHlDzbf7jTn/YWsFRAJSgh0nQFpgWAVWBWOcFZvzMv8TUXeLfTk/r/5qDSp32Jk+bFs16WYvNHzez/NH1E02oemKsLW4X9QTUOSP0SsctbrNrDkU63lfc1W3tXhwItkOzu0bGFg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=dqJeLMR7PPDVVxu2lAVtDPG0X6ZSZGr7+keXc3LyO4A=;
 b=OwVAjKtQtjwzWIySsLIoDuk5VMxRnzvFRPkMDP0CcYtrc91hqKFQ+smqdcMtnzCxUxnqItEJkJ7r/DOJ1kS9sPJb1ayJFv7tFhsDEklOR3caTpp5iTCBewzs+nky6xn2M2qdk7taIUYbDUJTaUi178yIaEzqv+mRZ69d02d1WPgH4F43qKE8Wd3FOGG9bA3UzmcazHegPYOwZuJ/n7fNObWfc08HFX9g8plHKfmZ/1MU30btyKMvihCg6jJiDXTet3nJKmIDE5lbT4Fvqi5XHvUprO5ncTaCDYEDYzl9V5vJ8ymcLwYJyKPU4PSA/jAfb/nSzIU1zTfDjetKeEFzxQ==
From: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
To: Juergen Gross <jgross@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [RFC v2 1/8] xen/hypfs: support fo nested dynamic hypfs nodes
Thread-Topic: [RFC v2 1/8] xen/hypfs: support fo nested dynamic hypfs nodes
Thread-Index: AQHYHRW07SkrMxyT/k6/hhSCHW7RmqyMZwEAgAGeF4A=
Date: Fri, 11 Feb 2022 08:16:14 +0000
Message-ID: <20220211081613.GA2274024@EPUAKYIW015D>
References: <cover.1644341635.git.oleksii_moisieiev@epam.com>
 <8ab7e9ffd5f041c2631f754c7c596874cf6a99c1.1644341635.git.oleksii_moisieiev@epam.com>
 <74e4635d-10ad-86c4-71b1-6e46bc76a89a@suse.com>
In-Reply-To: <74e4635d-10ad-86c4-71b1-6e46bc76a89a@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 3d054d62-de34-4e26-3a16-08d9ed36c543
x-ms-traffictypediagnostic: AM6PR03MB3704:EE_
x-microsoft-antispam-prvs: 
 <AM6PR03MB37045B589A7F9B16B2B4195FE3309@AM6PR03MB3704.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:6108;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 CHn8xwBTVx7DybkdAVyh+4EXyQqkoTqydX6lMOcbHJLhY6EJt0ila5ZrB63FKL2N6HkiJVUPkcsx/qlNZ34IOn3Z7ouETkxirQAg1LnzOISdFQGFa46i5TDAztJQjqlQqIPGsiVLUfh/AcZzeUPtFhIo8R3W0o/Uhg3X/AJxaaSHA/JZNCGY6Kc/YfdnvxOjqNw62m/wlJOqE2834YmviK5wzznLDEiN6367tS+jyeKoJIV4FSlpt//e4WOQj17CZ8TRwau6Wdq4S64f6CCYe1AfXt94H9QD/yLLlq5oXzP20f7OSWCPG4w66YfKyAqeF5K6rbKOXi0Jsv+xV+LifOOugTM8GV3NnLmKuxKl+9NpWziC9xqQKTsslzZXhHjKO2B4vAJbO4iq3DLR6g04V0eRrgey4ZRJL+656JMDafY1azWirJfw1BkWuJ2kOPf4julI/ARVJhks4FCW3HR/rt96RATbEKlCSqfjqExQwH++Jdl63QMD/vxufHdXjyYv4wjtDZlh2IjWzme4HaG3DenmRjlCXXrrD67fBJl/SzqfjYrAhnEsii9M9C3AsxEWZdffmMq+ENmxWrhPP2rCYwSYi5Ix+udoFRtLHhk7jO2hJXRbuV3mO5YPkvMJsKdn1g/UAAwJ6BR1IhjJcxeXGhHaHGbUiy4tuRdw+ysIfSyw78q/QZkSXCbDR75T480ouQoWCHxENLfmPmVrCZEwiw==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR03MB7136.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(38100700002)(1076003)(33656002)(71200400001)(186003)(6506007)(508600001)(30864003)(26005)(5660300002)(38070700005)(2906002)(6486002)(6512007)(86362001)(9686003)(83380400001)(66556008)(316002)(6916009)(91956017)(66476007)(33716001)(53546011)(8676002)(4326008)(66446008)(8936002)(76116006)(66946007)(64756008)(122000001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?QvAiY3Pz6lABR178ZEh+Hz8Oc1+QuFCEV+ksUp+r8KaDYOJJpFFF/cQURGOZ?=
 =?us-ascii?Q?yxSJzJ3kLerqUYyESb7QwqnEam5U/2JbShARarYeLLir2FBdwo9g3j6g7k0d?=
 =?us-ascii?Q?YS5/MTPNZVS8q/LuQNk6FwpK+y2luHaNPbMobY1/EeKUoibzk7FjLw0oEVtS?=
 =?us-ascii?Q?BPMACcpLIJ/cdWRv+YytIzymn/sfogspdM75k5feLYnKE/7rZ4QF2yya1dmA?=
 =?us-ascii?Q?dH4M3yzaUYG77pH19ZPTMZHPD4acq0B0zwEdC60sdHycE1IdkIugF+J32Nka?=
 =?us-ascii?Q?lpv/F+6v+vt2MPW0289R69ujlptLPMukj4jBGpHXV815IZ1yzcIYqYoucQW7?=
 =?us-ascii?Q?V60s564qBEX7KYFheuRofU1TuZOIb0s7C2rNzCBwSEljvvbYwRN6EarEJaSy?=
 =?us-ascii?Q?md/rc28t95MdWW47HMlOYCMwxvDi0mucoj6VITouXF2uOG/pM0g5/8VNgP4u?=
 =?us-ascii?Q?2/pb+PYFwOGrYCpfi4pa9rfm7s0w0zheP/jJS9r36TIwXqdQea0J+tynuQSx?=
 =?us-ascii?Q?fqdTzHt7XMJdAgcc4f0HzCmrNsGwy/UwPiZiBUAgEEl9UqSxDTpVgltvxGzb?=
 =?us-ascii?Q?TTO16vu6wJ3GkE7KlhbLLBHnD8BAnQ3Sfo3pivw+Qe5vn0aT0AzW9utNczAQ?=
 =?us-ascii?Q?TFhIcfOjE3Ar2dPuurRROj3SC8AuIjADkYlj0EID/uSKNZHojWgP2uVPGMJc?=
 =?us-ascii?Q?rbVFZJ7r37Qfwd/hIATkM981Qa/vKaBeOUdE9PB4cXwiWf6Jh4q+TXcmIOhw?=
 =?us-ascii?Q?fD8H0dnd+Qb3kbjQvYGwsoWni3TAw3A0FkgynlVNo1H2G+DvlUBzRNrwwPHv?=
 =?us-ascii?Q?NiJqdyXLuYpfqBizuUzKTmcXeHHil8iFnm2ttPcGBXn5ZjuQfyb2LHvS70ZS?=
 =?us-ascii?Q?zTezGCVC4EBs6Wc0UA6qlP0nG7D4HsurwLJa/O/jgTOAJAgQunN1obdhVYdi?=
 =?us-ascii?Q?2KnN7hTiIuTUxUqCDwyr1Cl7V5fXhZ5DUVrbpY1ZG0kSusYpjVTUeKmyCm8I?=
 =?us-ascii?Q?YyPVX9XlMYHF7x3GJGReTpvgc08RSe7M0x7EqE9ZlUWiLe1ozloQuKVdafWx?=
 =?us-ascii?Q?PLKIxaIfu5RKL7ZOizQXqezE/Z8WnVkZbTJxQqmkB8hx9seZFgVHG8ou2Ry6?=
 =?us-ascii?Q?xex0hvaNzcDaaKa4J9xcvS1tj5zJ78GdRa9zZ0KjKvhh7VQCviVyN4Ar3rpd?=
 =?us-ascii?Q?xml3GhD/BeD0dwLqVykyZGZ85vJWcYWYbV+qE/8/r6j3LLp2rrf0jkJr6fmf?=
 =?us-ascii?Q?rpT45evrJ81T//7Vyobdt4qb/JUpDwJaCe+3MRjU26Uw3B+ffs6q3KCoUtOO?=
 =?us-ascii?Q?mlxUpL47gCdSxW0vQA3pKu1uW7RO9HJgVj+IRx+1a0VeS3TWe+O8uE6ATVYC?=
 =?us-ascii?Q?TfopKEV4guk6vH88caslgpouX2WxveKya+5ZyJ6OG6w0Gj3KlBuMsk7RR8Hq?=
 =?us-ascii?Q?veAOXkOPyjd3ZonUt8UlgBSqPi4i53jlvHF3b4/DponMarXgZaFryaP2qKci?=
 =?us-ascii?Q?JRI1HSgQINxCnQvUgD/awkABsBFEol/S+DlfXffvjJ66OPto9R++QtDOEaj1?=
 =?us-ascii?Q?soaNZrl4QEyKQRzbW3K+ala6ukCUEw+497/11VL3yVU9IhVFHUj/f6FjqsLK?=
 =?us-ascii?Q?Vpqv3hpvRP2r9E+KVyvZi7DuEyoiIQeDnRGi6K/K5XagdGiVwVewdYsjmA7C?=
 =?us-ascii?Q?5qfl30mfypWOoHWY29P9vrc2MNk=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <8308B27B4F1FC74E967494808B2C6117@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR03MB7136.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3d054d62-de34-4e26-3a16-08d9ed36c543
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Feb 2022 08:16:14.1920
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: NcewH7+kekkj7ltcrZUvvv4riTeR+TiO44ATaJYUN2SXn6KrmESouEImi3WAcmQjLcFAuF0v+EE5qwBvigZfBcjjF5uoZTBGAbwm7Zi7Inw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR03MB3704
X-Proofpoint-ORIG-GUID: T4loW9st5Up3rf1nTAdyK2YTQBe3x5R6
X-Proofpoint-GUID: T4loW9st5Up3rf1nTAdyK2YTQBe3x5R6
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-11_03,2022-02-09_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0
 mlxlogscore=999 priorityscore=1501 adultscore=0 malwarescore=0
 lowpriorityscore=0 spamscore=0 phishscore=0 bulkscore=0 impostorscore=0
 clxscore=1015 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202110046

Hi Juergen,

On Thu, Feb 10, 2022 at 08:34:08AM +0100, Juergen Gross wrote:
> On 08.02.22 19:00, Oleksii Moisieiev wrote:
>=20

> > Add new api:
> > - hypfs_read_dyndir_entry
> > - hypfs_gen_dyndir_entry
> > which are the extension of the dynamic hypfs nodes support, presented i=
n
> > 0b3b53be8cf226d947a79c2535a9efbb2dd7bc38.
> > This allows nested dynamic nodes to be added. Also input parameter is
> > hypfs_entry, so properties can also be generated dynamically.
> >=20
> > Generating mixed list of dirs and properties is also supported.
> > Same as to the dynamic hypfs nodes, this is anchored in percpu pointer,
> > which can be retriewed on any level of the dynamic entries.
> > This handle should be allocated on enter() callback and released on
> > exit() callback. When using nested dynamic dirs and properties handle
> > should be allocated on the first enter() call and released on the last
> > exit() call.
> >=20
> > Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@epam.com>
> > ---
> >   xen/common/hypfs.c      | 83 +++++++++++++++++++++++++++++++++-------=
-
> >   xen/include/xen/hypfs.h | 14 ++++++-
> >   2 files changed, 79 insertions(+), 18 deletions(-)
> >=20
> > diff --git a/xen/common/hypfs.c b/xen/common/hypfs.c
> > index e71f7df479..6901f5e311 100644
> > --- a/xen/common/hypfs.c
> > +++ b/xen/common/hypfs.c
> > @@ -367,28 +367,27 @@ unsigned int hypfs_getsize(const struct hypfs_ent=
ry *entry)
> >   /*
> >    * Fill the direntry for a dynamically generated entry. Especially th=
e
> > - * generated name needs to be kept in sync with hypfs_gen_dyndir_id_en=
try().
> > + * generated name needs to be kept in sync with hypfs_gen_dyndir_entry=
().
> >    */
> > -int hypfs_read_dyndir_id_entry(const struct hypfs_entry_dir *template,
> > -                               unsigned int id, bool is_last,
> > +int hypfs_read_dyndir_entry(const struct hypfs_entry *template,
> > +                               const char *name, unsigned int namelen,
> > +                               bool is_last,
> >                                  XEN_GUEST_HANDLE_PARAM(void) *uaddr)
>=20
> Please fix the indentation of the parameters.
>=20
> >   {
> >       struct xen_hypfs_dirlistentry direntry;
> > -    char name[HYPFS_DYNDIR_ID_NAMELEN];
> > -    unsigned int e_namelen, e_len;
> > +    unsigned int e_len;
> > -    e_namelen =3D snprintf(name, sizeof(name), template->e.name, id);
> > -    e_len =3D DIRENTRY_SIZE(e_namelen);
> > +    e_len =3D DIRENTRY_SIZE(namelen);
> >       direntry.e.pad =3D 0;
> > -    direntry.e.type =3D template->e.type;
> > -    direntry.e.encoding =3D template->e.encoding;
> > -    direntry.e.content_len =3D template->e.funcs->getsize(&template->e=
);
> > -    direntry.e.max_write_len =3D template->e.max_size;
> > +    direntry.e.type =3D template->type;
> > +    direntry.e.encoding =3D template->encoding;
> > +    direntry.e.content_len =3D template->funcs->getsize(template);
> > +    direntry.e.max_write_len =3D template->max_size;
> >       direntry.off_next =3D is_last ? 0 : e_len;
> >       if ( copy_to_guest(*uaddr, &direntry, 1) )
> >           return -EFAULT;
> >       if ( copy_to_guest_offset(*uaddr, DIRENTRY_NAME_OFF, name,
> > -                              e_namelen + 1) )
> > +                              namelen + 1) )
> >           return -EFAULT;
> >       guest_handle_add_offset(*uaddr, e_len);
> > @@ -396,6 +395,22 @@ int hypfs_read_dyndir_id_entry(const struct hypfs_=
entry_dir *template,
> >       return 0;
> >   }
> > +/*
> > + * Fill the direntry for a dynamically generated entry. Especially the
> > + * generated name needs to be kept in sync with hypfs_gen_dyndir_id_en=
try().
> > + */
> > +int hypfs_read_dyndir_id_entry(const struct hypfs_entry_dir *template,
> > +                               unsigned int id, bool is_last,
> > +                               XEN_GUEST_HANDLE_PARAM(void) *uaddr)
> > +{
> > +    char name[HYPFS_DYNDIR_ID_NAMELEN];
> > +    unsigned int e_namelen;
> > +
> > +    e_namelen =3D snprintf(name, sizeof(name), template->e.name, id);
> > +    return hypfs_read_dyndir_entry(&template->e, name, e_namelen, is_l=
ast, uaddr);
> > +}
> > +
> > +
> >   static const struct hypfs_entry *hypfs_dyndir_enter(
> >       const struct hypfs_entry *entry)
> >   {
> > @@ -404,7 +419,7 @@ static const struct hypfs_entry *hypfs_dyndir_enter=
(
> >       data =3D hypfs_get_dyndata();
> >       /* Use template with original enter function. */
> > -    return data->template->e.funcs->enter(&data->template->e);
> > +    return data->template->funcs->enter(data->template);
> >   }
> >   static struct hypfs_entry *hypfs_dyndir_findentry(
> > @@ -415,7 +430,7 @@ static struct hypfs_entry *hypfs_dyndir_findentry(
> >       data =3D hypfs_get_dyndata();
> >       /* Use template with original findentry function. */
> > -    return data->template->e.funcs->findentry(data->template, name, na=
me_len);
> > +    return data->template->funcs->findentry(&data->dir, name, name_len=
);
> >   }
> >   static int hypfs_read_dyndir(const struct hypfs_entry *entry,
> > @@ -426,7 +441,36 @@ static int hypfs_read_dyndir(const struct hypfs_en=
try *entry,
> >       data =3D hypfs_get_dyndata();
> >       /* Use template with original read function. */
> > -    return data->template->e.funcs->read(&data->template->e, uaddr);
> > +    return data->template->funcs->read(data->template, uaddr);
> > +}
> > +
> > +/*
> > + * Fill dyndata with a dynamically generated entry based on a template
> > + * and a name.
> > + * Needs to be kept in sync with hypfs_read_dyndir_entry() regarding t=
he
> > + * name generated.
> > + */
> > +struct hypfs_entry *hypfs_gen_dyndir_entry(
> > +    const struct hypfs_entry *template, const char *name,
> > +    void *data)
> > +{
> > +    struct hypfs_dyndir_id *dyndata;
> > +
> > +    dyndata =3D hypfs_get_dyndata();
> > +
> > +    dyndata->template =3D template;
> > +    dyndata->data =3D data;
> > +    memcpy(dyndata->name, name, strlen(name));
> > +    dyndata->dir.e =3D *template;
> > +    dyndata->dir.e.name =3D dyndata->name;
> > +
> > +    dyndata->dir.e.funcs =3D &dyndata->funcs;
> > +    dyndata->funcs =3D *template->funcs;
> > +    dyndata->funcs.enter =3D hypfs_dyndir_enter;
> > +    dyndata->funcs.findentry =3D hypfs_dyndir_findentry;
> > +    dyndata->funcs.read =3D hypfs_read_dyndir;
> > +
> > +    return &dyndata->dir.e;
> >   }
> >   /*
> > @@ -442,12 +486,13 @@ struct hypfs_entry *hypfs_gen_dyndir_id_entry(
> >       dyndata =3D hypfs_get_dyndata();
> > -    dyndata->template =3D template;
> > +    dyndata->template =3D &template->e;
> >       dyndata->id =3D id;
> >       dyndata->data =3D data;
> >       snprintf(dyndata->name, sizeof(dyndata->name), template->e.name, =
id);
> >       dyndata->dir =3D *template;
> >       dyndata->dir.e.name =3D dyndata->name;
> > +
>=20
> Unrelated change?
>=20
> >       dyndata->dir.e.funcs =3D &dyndata->funcs;
> >       dyndata->funcs =3D *template->e.funcs;
> >       dyndata->funcs.enter =3D hypfs_dyndir_enter;
> > @@ -457,6 +502,12 @@ struct hypfs_entry *hypfs_gen_dyndir_id_entry(
> >       return &dyndata->dir.e;
> >   }
> > +unsigned int hypfs_dyndir_entry_size(const struct hypfs_entry *templat=
e,
> > +                                    const char *name)
>=20
> Please fix indentation.
>=20
> > +{
> > +    return DIRENTRY_SIZE(strlen(name));
> > +}
> > +
> >   unsigned int hypfs_dynid_entry_size(const struct hypfs_entry *templat=
e,
> >                                       unsigned int id)
> >   {
> > diff --git a/xen/include/xen/hypfs.h b/xen/include/xen/hypfs.h
> > index e9d4c2555b..5d2728b963 100644
> > --- a/xen/include/xen/hypfs.h
> > +++ b/xen/include/xen/hypfs.h
> > @@ -79,8 +79,8 @@ struct hypfs_entry_dir {
> >   struct hypfs_dyndir_id {
>=20
> Please rename to struct hypfs_dyndir.

Ok, thanks.

>=20
> >       struct hypfs_entry_dir dir;             /* Modified copy of templ=
ate. */
> >       struct hypfs_funcs funcs;               /* Dynamic functions. */
> > -    const struct hypfs_entry_dir *template; /* Template used. */
> > -#define HYPFS_DYNDIR_ID_NAMELEN 12
> > +    const struct hypfs_entry *template; /* Template used. */
> > +#define HYPFS_DYNDIR_ID_NAMELEN 32
> >       char name[HYPFS_DYNDIR_ID_NAMELEN];     /* Name of hypfs entry. *=
/
> >       unsigned int id;                        /* Numerical id. */
>=20
> What about the following change instead:
>=20
> -    const struct hypfs_entry_dir *template; /* Template used. */
> -#define HYPFS_DYNDIR_ID_NAMELEN 12
> -    char name[HYPFS_DYNDIR_ID_NAMELEN];     /* Name of hypfs entry. */
> -
> -    unsigned int id;                        /* Numerical id. */
> -    void *data;                             /* Data associated with id. =
*/
> +    const struct hypfs_entry *template;  /* Template used. */
> +    union {
> +#define HYPFS_DYNDIR_NAMELEN    32
> +        char name[HYPFS_DYNDIR_NAMELEN]; /* Name of hypfs entry. */
> +        struct {
> +#define HYPFS_DYNDIR_ID_NAMELEN 12
> +            char name[HYPFS_DYNDIR_ID_NAMELEN]; /* Name of id entry. */
> +            unsigned int id;                    /* Numerical id. */
> +        } id;
> +    };
> +    void*data;                          /* Data associated with entry. *=
/
>=20

I'm not sure I see the benefit from this union. The only one I see is
that struct hypds_dyndir will be smaller by sizeof(unsigned int).
Could you explain please?

Also what do you think about the following change:
-    char name[HYPFS_DYNDIR_ID_NAMELEN];     /* Name of hypfs entry. */
-
-    unsigned int id;                        /* Numerical id. */
-    void *data;                             /* Data associated with id. */
+    char name[HYPFS_DYNDIR_ID_NAMELEN];     /* Name of hypfs entry. */
+
+    unsigned int id;                        /* Numerical id. */
+    union {
+       const void *content;
+       void *data;                             /* Data associated with id.=
 */
+    }
This change is similar to the hypfs_entry_leaf. In this case we can
store const pointer for read-only entries and use data when write access
is needed?

PS: I will address all your comments in v3.

Best regards,
Oleksii.

> > @@ -197,13 +197,23 @@ void *hypfs_alloc_dyndata(unsigned long size);
> >   #define hypfs_alloc_dyndata(type) ((type *)hypfs_alloc_dyndata(sizeof=
(type)))
> >   void *hypfs_get_dyndata(void);
> >   void hypfs_free_dyndata(void);
> > +int hypfs_read_dyndir_entry(const struct hypfs_entry *template,
> > +                               const char *name, unsigned int namelen,
> > +                               bool is_last,
> > +                               XEN_GUEST_HANDLE_PARAM(void) *uaddr);
>=20
> Again: indentation.
>=20
> >   int hypfs_read_dyndir_id_entry(const struct hypfs_entry_dir *template=
,
> >                                  unsigned int id, bool is_last,
> >                                  XEN_GUEST_HANDLE_PARAM(void) *uaddr);
> > +struct hypfs_entry *hypfs_gen_dyndir_entry(
> > +    const struct hypfs_entry *template, const char *name,
> > +    void *data);
> >   struct hypfs_entry *hypfs_gen_dyndir_id_entry(
> >       const struct hypfs_entry_dir *template, unsigned int id, void *da=
ta);
> >   unsigned int hypfs_dynid_entry_size(const struct hypfs_entry *templat=
e,
> >                                       unsigned int id);
> > +unsigned int hypfs_dyndir_entry_size(const struct hypfs_entry *templat=
e,
> > +                                    const char *name);
>=20
> Indentation.
>=20
> > +
> >   #endif
> >   #endif /* __XEN_HYPFS_H__ */
>=20
>=20
> Juergen






From xen-devel-bounces@lists.xenproject.org Fri Feb 11 08:22:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 08:22:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270198.464399 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIRC9-0006Bf-CD; Fri, 11 Feb 2022 08:22:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270198.464399; Fri, 11 Feb 2022 08:22:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIRC9-0006BY-96; Fri, 11 Feb 2022 08:22:21 +0000
Received: by outflank-mailman (input) for mailman id 270198;
 Fri, 11 Feb 2022 08:22:19 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9nq0=S2=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1nIRC7-0006BS-BU
 for xen-devel@lists.xenproject.org; Fri, 11 Feb 2022 08:22:19 +0000
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur03on0603.outbound.protection.outlook.com
 [2a01:111:f400:fe08::603])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b9792579-8b13-11ec-8eb8-a37418f5ba1a;
 Fri, 11 Feb 2022 09:22:17 +0100 (CET)
Received: from DB6P195CA0014.EURP195.PROD.OUTLOOK.COM (2603:10a6:4:cb::24) by
 AM0PR08MB3492.eurprd08.prod.outlook.com (2603:10a6:208:da::31) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4951.17; Fri, 11 Feb 2022 08:22:15 +0000
Received: from DB5EUR03FT011.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:4:cb:cafe::7) by DB6P195CA0014.outlook.office365.com
 (2603:10a6:4:cb::24) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11 via Frontend
 Transport; Fri, 11 Feb 2022 08:22:15 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT011.mail.protection.outlook.com (10.152.20.95) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4975.11 via Frontend Transport; Fri, 11 Feb 2022 08:22:15 +0000
Received: ("Tessian outbound 31aeb3346a45:v113");
 Fri, 11 Feb 2022 08:22:15 +0000
Received: from 2fff6e63634f.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 E592DE96-D3A4-49C9-AF2D-2E138C9E0FD8.1; 
 Fri, 11 Feb 2022 08:22:08 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 2fff6e63634f.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 11 Feb 2022 08:22:08 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by AM4PR08MB2884.eurprd08.prod.outlook.com (2603:10a6:205:e::21) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Fri, 11 Feb
 2022 08:22:05 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::aca7:79c4:fa65:dac6]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::aca7:79c4:fa65:dac6%4]) with mapi id 15.20.4951.019; Fri, 11 Feb 2022
 08:22:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b9792579-8b13-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=NwUW1WWO/9TRhAGRLI00rX5A1L7bwEs9SmpAZ/pAHNQ=;
 b=9ISlnCjWqo0yDMjVgkCFszQ+Bd/7Saf86RF6nYuleXYeAz8kZ5d/mTMpVTP3xgG688Bd/jGEfSfVZ39z8oJhM8msjc01WdIjNgm2M/5+vQJWOHvDQhE695wPmzka0tHT9XZ1lCy3qO0aoApc+jDub497PI+mMAqfdWnw+MLnmGg=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: a200308a4bdaf289
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=CqmE+cCjgP/1hd9B83JH6BP1T3Y+sNNQis17qVPUGnKVvbg2pyw32x4i9YI110iOsq3vFMQT2upsQ6o3tWI1vtQybuK6Fj0EelcSXw9UF2eWInFcDyxbUXHFN5EdGQh4Iph9DFYB+284LunS1m0vBSL4G4nyAqzzAbke19wGrvUUL9Cz3QMeO0yT/QzjyNN4fLkL2ZCcw7qrVoCkD6sTin0+EXZCI0+Ugof8PaH9v8NHtNgjB2BCi2KN54WosTBt99eOCxTDiKRKMNCl0g6YGdG4SdX75oa6DpO9mGXNw+qo2rriXYQ/lGefArGzuW546I3Mnx3L66GmIfKV9g4xJw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=NwUW1WWO/9TRhAGRLI00rX5A1L7bwEs9SmpAZ/pAHNQ=;
 b=LtXDWwOGqBPhsJivFXKPr7+DOxQdB/2u6j/ouVoJZBDLEnKwS3Yq/y9bQE7FdyjetQqih942qOSNNei0kNlBN5MAK2RgFEBQ1KAM1vn48XvmehYrzDmhwkAkpSle0MNGdIvkTBOq0L0nV1mqysv42VVh12PsUJ0tHSw7Nzx8oVCZ3cnqfxNDPBChMgRt9LvOjsmqo50xTtzQyFMNaG7ss6OK1DEtevCDmFkOog+X8ac0HCBZnausLWdi1G/xqCiHLG1B3PXYjLihfSkmBasTzaho7e9EulPQp9BeL3emzYKSzsBd7NdEVWtYWGySN52JERoc+WxJYeE9/Mjmf3AN9w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=NwUW1WWO/9TRhAGRLI00rX5A1L7bwEs9SmpAZ/pAHNQ=;
 b=9ISlnCjWqo0yDMjVgkCFszQ+Bd/7Saf86RF6nYuleXYeAz8kZ5d/mTMpVTP3xgG688Bd/jGEfSfVZ39z8oJhM8msjc01WdIjNgm2M/5+vQJWOHvDQhE695wPmzka0tHT9XZ1lCy3qO0aoApc+jDub497PI+mMAqfdWnw+MLnmGg=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"julien@xen.org" <julien@xen.org>, "Volodymyr_Babchuk@epam.com"
	<Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH] MAINTAINERS: make Bertrand ARM maintainer
Thread-Topic: [PATCH] MAINTAINERS: make Bertrand ARM maintainer
Thread-Index: AQHYHrGorW8uOCkvJkWS+UW+UYW3L6yOA4GA
Date: Fri, 11 Feb 2022 08:22:05 +0000
Message-ID: <6847D807-EDF0-43C4-B09B-C79EFE99639F@arm.com>
References:
 <alpine.DEB.2.22.394.2202101026360.2091381@ubuntu-linux-20-04-desktop>
In-Reply-To:
 <alpine.DEB.2.22.394.2202101026360.2091381@ubuntu-linux-20-04-desktop>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3693.60.0.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 60bac160-dd5d-497d-b77f-08d9ed379c50
x-ms-traffictypediagnostic:
	AM4PR08MB2884:EE_|DB5EUR03FT011:EE_|AM0PR08MB3492:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR08MB34923A016C821FAD578D208F9D309@AM0PR08MB3492.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:549;OLM:549;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 G0lxOdVv978PPyjv+rut/9vQxLHq3rSgym5hWydA5+RetzdCys5Qe6eWxVU4+r4c8sjVKK6LsxHrhf8gfubliPH7zjEhQ8+8yAC6q/NCSBvERP0YAC1hDp85giPcamJNftstar0mHKmF7z8B1v0waFqY4clZabPPfwi9GmcA2fBJF/zOUb1N5r3NYr3wivHfXFXyi9tmKrn3Wudl7YJ2oY8NGUNahvyXHSSbtbGhYfzWwTdlhVxDdvKbbwbgxlmCP9OTISK0gcaWki4ufHaipG6Lfnx40eXHalu9eyGL8ZknzrGy7h7i6BsTfttzt8bvA3nT2lBvX5MstcY8sG9ScaaBPUXfXRaU/U+vQP0Iczf2tYLj3lIBI4Ta2h67R6eRWd9qXuxux7NY5Bl6bS/dH2WOxP00rdaA9Dqls96DRLhvjfhO7TCJyNMXlQHDDnuxaHnxVH7DtrlNGZv+OQ5WXbhVaEM5h0IMeMyOwXIQysfYaHOEjDGT2PK6cz3cZ7b4WbR1lL5HdIs7xajjijq7jMFOZUIr7y5Pf0wlTgAYN/gE2a6qTzM7WyGMzRMr/maDqCmhuYDTFbOiY47MNe0OXf6i/Jz0OxHJ9DKjqe8UdF+Xtbh2UmUXhudTVnJh8uhMn7+6xA6ZYWaPvI05/jttZvq5F5p0dT4nwpFihQsOsaxcQW8UF0uyiyih7+Dp1nSCloD36MA8t0acJg+LgqoANhaIFCjrut98AXazwwmEnHxzdy4cq4krY6q6vWDwGa5E
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(64756008)(66446008)(316002)(4326008)(91956017)(6506007)(8936002)(122000001)(38070700005)(6512007)(71200400001)(8676002)(66476007)(54906003)(66946007)(2906002)(53546011)(66556008)(86362001)(6916009)(508600001)(33656002)(76116006)(38100700002)(26005)(186003)(4744005)(36756003)(6486002)(2616005)(5660300002)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <262A513260206843B0210D4176DD5762@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR08MB2884
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT011.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	8c16e8b6-ee39-4473-397e-08d9ed3796c4
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Tg/rWLrCvhsQxTDHkNEIYoN9mpAg6XccqsRy5G0/OsZU4lmPeMHegWzZf9Zn3subjtKVr+rSpaS9iCzHg/QTjtCixZ6Ys1N9i50p7iMsRsrll511GxRYWVr54gBUNh2Wt3CiCfV/6jo3hhcXeCWbDuxbDFdw1ZBJk9eBp023QAUCxPu55kvxzNkReLzCNi9a28g7pVmt5KmZj2Tbxr6TU9He5ad4HsykNSSKzVW5/P6tgv9HqBRKzm8KxfXuegCzDxvuHMTz+2o1PFIZMgAYKTTxEQNrCMRiMW5KvLtbtJWRF6gsjUDIv1l/oi60DpYVoXs+tjPMN3OGVR5SnC6UAC+6QkppttStMWyUVqihJJs7vSGDy3rDrLK0X9YTszwdAj0adwkCs5djTY70yCQnPM+70DMpTQDy+vIaZbFEqq/0OS7HSwWF54f9mHrJQb/ywddfNaFbiq7UCAHonpv0HK+mwvVv2cY5f/2fLcWatb8FCbO2F/CrZMUWDpCfcOl7cVooR1GTfacyu8gVispc9RbGpj/w2HNJcmuxODmTsLFw6aB7AY4MvT+0que6lY6c7i3trJSqyOitmuco3/ZJnj8EstKbPFYEwN+1R9Xw4B0e9hrzASwMRsxdUrb9yb9+EdRpRTdtZhxN+vV0NUOk8IM1cYCEihPYhiuMhxzzan9frZTEhQdpgKZC29kOfnRm
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(54906003)(8936002)(36860700001)(107886003)(6506007)(4326008)(6862004)(33656002)(8676002)(26005)(6512007)(2906002)(53546011)(47076005)(508600001)(316002)(36756003)(40460700003)(5660300002)(86362001)(6486002)(336012)(70206006)(70586007)(2616005)(4744005)(81166007)(82310400004)(186003)(356005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2022 08:22:15.1075
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 60bac160-dd5d-497d-b77f-08d9ed379c50
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT011.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3492

Hi Stefano,

Thanks a lot :-)

> On 10 Feb 2022, at 19:08, Stefano Stabellini <sstabellini@kernel.org> wro=
te:
>=20
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>

Asked-by: Bertrand Marquis <bertrand.marquis@arm.com>

Cheers
Bertrand

>=20
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 64934cc070..d41572128b 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -230,8 +230,8 @@ F:	tools/libs/ctrl/xc_arinc653.c
> ARM (W/ VIRTUALISATION EXTENSIONS) ARCHITECTURE
> M:	Stefano Stabellini <sstabellini@kernel.org>
> M:	Julien Grall <julien@xen.org>
> +M:	Bertrand Marquis <bertrand.marquis@arm.com>
> R:	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
> -R:	Bertrand Marquis <bertrand.marquis@arm.com>
> S:	Supported
> L:	xen-devel@lists.xenproject.org
> F:	docs/misc/arm/



From xen-devel-bounces@lists.xenproject.org Fri Feb 11 08:28:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 08:28:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270205.464411 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIRI5-0006qj-2s; Fri, 11 Feb 2022 08:28:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270205.464411; Fri, 11 Feb 2022 08:28:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIRI4-0006qc-VH; Fri, 11 Feb 2022 08:28:28 +0000
Received: by outflank-mailman (input) for mailman id 270205;
 Fri, 11 Feb 2022 08:28:27 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=dFbI=S2=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nIRI3-0006qW-HA
 for xen-devel@lists.xenproject.org; Fri, 11 Feb 2022 08:28:27 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 93551dfd-8b14-11ec-8eb8-a37418f5ba1a;
 Fri, 11 Feb 2022 09:28:24 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 93551dfd-8b14-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644568104;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=Vhj8SGZE811stmy2pNaUJ07OaNJtdj5vIuyQ5ReJE8Q=;
  b=KG78mBsvwDPJAyeqzOxgLhq+unkUAwyGmICvQHOe52hpyHRpQ0GzOHqw
   VWMRFzcq+1MutGMSYl22O1XkUHORg1EAbjCl3v8KmEriOcvMOaQOGL2mJ
   dGlPpdGgG3OoftABRKSGQPeofa/YUjVThcXeFM7SZ8WnkB2Dqe9JEiPkc
   s=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: 6xMvbttvqKLb9I+rpKZo2zJqYdzfS4jZ5kU9gCyO6/9OW2Rd0lXuyaa2DfyAuX9A5GcfUloY61
 WFzZvQftHv/BXY0UapCGxGMsTo9GOfdCBLxmyoYqKaZBK+ETOHZvbEtbCEIPcHUOuQJLVpgGgn
 JIDYL7BHaAQYZ8kX1iuYOv/kM3MNm+V7VN9IC0WEH10yU+sAP8ZplXKHXSMB5Han5VP6OlAt7o
 45Wwb+diRky4o5tE4YPb8uLB9Ipxkaya58yeve/6VQpRUaBOZObYhuAfJJRQe8wTC40c475/yR
 qD92Dxko7luNMxUvC32XEUNc
X-SBRS: 5.1
X-MesageID: 63999212
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:4nem9KmLjOu16kLMUCMJTALo5gxWIURdPkR7XQ2eYbSJt1+Wr1Gzt
 xJODW/QaPaCMGT1eN13PY/n904H7cKEz9BiSgc9rXg2QSMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BClVlxJVF/fngqoDUUYYoAQgsA180IMsdoUg7wbRh2Ncx2YHR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 Nxtt4PralopB4vNvsAACkZ5EwtAEqITrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBNPsM44F/Glp0BnSDOo8QICFSKLPjTNd9Glr15EfR6+ED
 yYfQR5lVT/lZT1EA3A0KZgE3+DxqyX6VxQN/Tp5ooJoujOOnWSdyoPFINfTP9CHW8hRtkKZv
 X7duXT0BAkAM96SwibD9Wij7sfTnSLgHoMJUrTg8uVthnWcw2USDFsdUl7TnBWiohfgAZQFc
 RVSo3dw6/hpnKC2cjXjdxSYomHfnUMcYvxRNcknsV6syoDqzAnMUwDoUQV9QNAhscY3Qxkj2
 VmIg87lCFRTjVGFdZ6O3uzK9G3vYED5OUdHPHZZFlVdv7EPtalu1kqnczp1LEKiYjQZ8xnUy
 ivCkiUxjq57YSUjh/TipgCvb95BS/H0ou8JCuf/AzrNAuBRPtfNi2mUBb7zt6cowGGxFAfpg
 ZT8s5LChN3i9LnU/MB3fM0DHauy+9GOOyDGjFhkEvEJrmrxpyP5IN8PumwnfC+F1/ronxezM
 Sc/XisLuvdu0IaCN/crM+pd9ex2pUQfKTgVfq+NNYcfCnSAXASG4DtvdSatM5PFyyARfVUEE
 c7DK66EVC9CYYw+lWbeb7pNgNcDm3FlrUuOFM+T8vhS+efHDJJjYexeawXmgyFQxP7snTg5B
 P4Ba5XUm08CDIUToED/qOYuELzDFlBibbjeoM1LbO+TZA1gHWAqEfjKxr09PYdimsxoei3gp
 xlRg2dUlwjyg2PpMwKPZiwxYb/jR88n/3k6ITYtLRCj3H16OdSj66IWdp0We7g79bM8ka4oH
 qddI8jQUO5STjnn+igGacWvpoJVaxn21xmFODCoYWZjcsc4FRDJ4NLtYiDm6DIKUnisrcI7r
 rD5jlHbTJMPSh5MFsHTbP7znVq9sWJEwLB5XlfSI8kVc0LpqdA4Jyv0h/4xAscNNRScmWfKi
 1fIWU8V/LCfrZU0/d/FgbG/g72oS+YuTFBHG2T77KqtMXWI9GSU3oIdAv2DeirQVT2o9fz6N
 /lV1fz1LNYOgE1O79hnC79uwK8zu4nvqrtdwlg2FXnHdQ32WLZpI33A1shTrKxdgLRevFLuC
 E6I/9BbP5SPOd/kTwFNdFZ0MLzb2KFGgCTW4NQ0PF7+tX1+87ewWElPOwWB1X5GJ7xvPYJ5m
 eostab6MeBkZsbG5jpesh1pyg==
IronPort-HdrOrdr: A9a23:udo8d6ipj81/BeW7cgd+OacScXBQXzh13DAbv31ZSRFFG/FwyP
 rAoB1L73PJYWgqNU3I+ergBEGBKUmskqKdxbNhR4tKPTOWw1dASbsN0WKM+UyDJ8STzJ856U
 4kSdkCNDSSNykFsS+Z2njALz9I+rDum8rJ9ITjJjVWPHlXgslbnnhE422gYytLrWd9dP4E/M
 323Ls6m9PsQwVeUu2LQl0+G8TTrdzCk5zrJTYAGh4c8QGLyRel8qTzHRS01goXF2on+8ZpzU
 H11yjCoomzufCyzRHRk0fV8pRtgdPkjv9OHtaFhMQ5IijlziyoeINicbufuy1dmpDl1H8a1P
 335zswNcV67H3cOkmzvBvWwgHllA0j7nfzoGXo9kfLkIjcfnYXGsBBjYVWfl/y8Ew7puxx16
 pNwiawq4dXJQmoplWz2/H4EzVR0makq3srluAey1ZFV5EFVbNXpYsDuGtIDZY7Gj7g4oxPKp
 gjMCjl3ocWTbqmVQGYgoE2q+bcHUjbXy32D3Tqg/blnQS/xxtCvgklLM92pAZ1yHtycegA2w
 3+CNUZqFh5dL5iUUtMPpZxfSKJMB2/ffvtChPlHb21LtBPB5ryw6SHkondotvaPKA18A==
X-IronPort-AV: E=Sophos;i="5.88,360,1635220800"; 
   d="scan'208";a="63999212"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Q+ak/mGk77ZtzO66o8bW2plIlyxQLPHuxL+zwFFb7BjPCbzwtq3m7/ZcAeOXchrP1jhWx3qlbOa5BFO2Mro3GDj6JQpcWBplBu05tB4UqtxW8MroRlzS3CR/cas8r8pj0OVMeVg3DR1HTSbW+Qv3zn72DkuZ+f1H7j6B9abVgVIL1/wiyoVPD8UukBOU4DKwO4zWyQWwYvFw1Y/6Lkk9C9H2ABICh8drivDdZ/j/ASEZBY9fYezGkvRV1FyfNX8cOdyy9ZoM4Mz2xN9KzibsLx5FI9oGbveXiP0e+IEFdvsJlBP4knedIP7XvxTTQ2S+FvBRgGbxTEVVJ4wO4dxV6w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=b3xRSDw9VHcQZ0WCaVPEyvGTc+1tW1q+fKCin7xhoH0=;
 b=Hx2Q6GPoyIkFnMbEZeHLQVubDaC4pJm3Du/E7B/3QxPdO8wbl7uhYLNlJI/tfeGf6pbgnH6fnyvd0hrsPhfJhLnBA5GkLsh2nearYjSNuPs6r2J84wY5nz34BRSVvxRmJEDcgRJENeza6fpHjAagB2GaJi1Mr7sML289tWNb+cN+aEkq/iQgHQG1KhSLgj48LcMh3JzTaCPz7M1ubMyAt3gjhtFMnZpt1WVQrGFgcdt6ey5kFBZro0H8Jmk21kVZK7cp5TvlJzb9qKLmC8NmytTKkRoCCKen8MHqZBd2Mi17SIp0wE5ohJcpHsam2mTPFORH7lwAxlptH6N2exVLtA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=b3xRSDw9VHcQZ0WCaVPEyvGTc+1tW1q+fKCin7xhoH0=;
 b=OUi/d32kqgHrrFi3rSVR6YOmhWuk/joiKJwhMv7OAw54M6d52pOcIqJendeKOqzyCaX3rDOjYzlRlkzMOxp4PRN+bFw0y/zKVLA5WKEPkuzap8KjQ3+umjUGSX0tapaRVR+g7Tbst3kbKkq7kkr0GRVayfQqka0CopQZ2nNu738=
Date: Fri, 11 Feb 2022 09:28:13 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Alex Olson <this.is.a0lson@gmail.com>
CC: <xen-devel@lists.xenproject.org>
Subject: Re: [RFC] Avoid dom0/HVM performance penalty from MSR access
 tightening
Message-ID: <YgYeHSm1RO03yy/t@Air-de-Roger>
References: <949b4776e23e4607776685a7e2705b9e77f5b717.camel@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <949b4776e23e4607776685a7e2705b9e77f5b717.camel@gmail.com>
X-ClientProxiedBy: MRXP264CA0031.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:500:14::19) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c5e299c6-7f2a-44ac-2a29-08d9ed3874b5
X-MS-TrafficTypeDiagnostic: DM6PR03MB4057:EE_
X-Microsoft-Antispam-PRVS: <DM6PR03MB4057C1FEF377C04795920AFB8F309@DM6PR03MB4057.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: LnEpPQrZsTMnlg9dLQL2FhmdJAKmOIjeBOMDUGmPZ9R01O+lKcafeytD/PfXyRLQLGH8k3qDVaaNxQ8lqDhLRkbLTA4SYsYe+Xbp1egKJLVj9mYVVEvewTo62eyJbzWbSVqebm6Pa5P5pKZ5Yo85XXL6iqOwJhsbqsi1A68f9BBnT+BJrKlozjEcbWfhxWxWXCoOW5JgPqPCM5KIFKNiG+qPHQmBOT03DrgBwrSjkB3pfdr3G7f3ADkbd3M0uFTw//YJq0dRy+OoyDwHVj80Ss0OR6+Dzwn/7eTjls8tDRkc+B4WLTWc3GOtt0HWO/LmmM+6X7EXjq+OL4znzLYqAR/og77AzQIQdZ1olgd02OvYUGhONVyMZKZSImfrXKpUuz8y34qY2MTu9u7j1sR9KhdEllwTJ3Vmvo8qefZL9/2XsLubHUDR/Vu7zEtx6LQI6h1jCwRMIvLs/oWbCLGcPySpaPFcqgErcGrz1O33eDGo5XWSikdg2xJAoysV8TJZ1w7awfUl8XYp7GjcK2MbTRBgjUjUfLRw9iaGVcgANxgkz0mKVowE5RElvVOiJdSZflZ81jwRQk/A+Pw8Df+nYQHQ6SWLeOHV6+zZ1UbKANtHvqBQxg6xoybpewVPBsI1ayLlukUMFr+Vbf4cZFB/RA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(6666004)(66476007)(66946007)(82960400001)(4326008)(8936002)(6916009)(8676002)(85182001)(316002)(2906002)(66556008)(6506007)(86362001)(9686003)(6512007)(508600001)(6486002)(186003)(26005)(38100700002)(83380400001)(5660300002)(33716001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UUJtbXRjOVBaN3B1Z2lHanl1WFUySDVVQXZiS2pNbDFNbVF0eVRqd2xPeUVi?=
 =?utf-8?B?NlZhaDlyL09qby9Sbzl3dlY1ZjJqLy9jVlZBS3gwNWpqblZ3aXRHbVFpU1lO?=
 =?utf-8?B?RVE0SEIwMm5WdEtmeHBWVnF5RFprbTN0ZXNPRSsvQ3NUV3dnZ1hwTXE0RWxh?=
 =?utf-8?B?N3NjQnR6OWpzRDdmMkxGSE1DTG1MK0k4SFZ1aU43TGVWSHV6UXl4elNCYjI1?=
 =?utf-8?B?QUE3a2JDZzdTd3crdWRwR2tkak9hQXIyaWxyRXR4TzlxeVZHd2hYRlBZQmR0?=
 =?utf-8?B?REw3WU1UejFsMWNoUWZCQXdQSEM1VUxSa0xNOCtUMitEQWMvK05DNjgvUUxo?=
 =?utf-8?B?SEt0TmVyYzlqcHM0UDdkTm9xaEQ4YXVBWk1rZmZuZG9aT2craDV0MHFIOEkz?=
 =?utf-8?B?SGJuVlNYVHRwSU1DcXJxS0VxQXNJN09RVTlYVmRYVjZlUklIK1FNZzluN2Nq?=
 =?utf-8?B?elNrM3Y2TWEzN0J0TXBoWm9VNFhJYk1UcytRa1hSZXBQKzVQVEpsVGJOUTFx?=
 =?utf-8?B?UXkvRXpNYlUvdzFWU09TMDZmanF2dWdpN05QdmRYWmVuMmExVmhoUlhLOW52?=
 =?utf-8?B?N1dpSnhlWkk5Mk9wNEhzbk1keHRxa25aN0lweFNOM283NUE2eFlXVU1Fb2dP?=
 =?utf-8?B?dHl3WDlyRGE1ZXlwaGpEa1BqZ1I3RFVUZzJVSGZYRVhOWGQxSHVYeXUvM2Jv?=
 =?utf-8?B?RTZkWjlqMWdBZnBnc3gwL3RReE1zcFZLQ3pDY0hMbHJxMjhIQVN3RXhVOWdN?=
 =?utf-8?B?a2VyUUFMTm1PaUIyeUFYVElDMHk3QW5lRTVZZ0c4SkJZb0ZkMDZKRldBQk1s?=
 =?utf-8?B?S0lTbzJKdjZXVm5hb0ZQNEhIUFlFdEFoTlV0K05VczRiTnVDRkdHUUtJcmJr?=
 =?utf-8?B?K01tL1lYYkhzd3IwSFNBeUlLaVFiVm9IeWorMVMvNUdDWU9WaWU2cTMyb0xz?=
 =?utf-8?B?dnd5SHQrYTN6Wlc2bVQrWjlCV2YzVWw0WkpObDFvdGNKeGVWVGtJQjlEQ05o?=
 =?utf-8?B?c2gzN0ZDT3hEalQ4MlhnUTlYS0tsbFllQmZtcktaVlQwSUdoUXpXSElIbFda?=
 =?utf-8?B?YWFKVVgxRnVEbXoxVlFhMUg4bzRtR1l0THVRN2ZmaytvL2cwdDFmUjZYTTYr?=
 =?utf-8?B?WXhZTHdxSjBkOHpJMmRYTUFsdHY3c21pa01lZWJVYys4ZHVsMnBEMjVOdTNH?=
 =?utf-8?B?ZCtSK1V5cEJCeDd6NXZnQllVY0NweWlNV21seHFZekgrV3RNMml3VEhUVi80?=
 =?utf-8?B?QjhLRlFKMXIzaVVDTDlBM1FtcVdwdmNtbTVwUDdGNFlNT3dPU002WHdjQW1M?=
 =?utf-8?B?c3lPcUxTNXRWSEx0Q3JmbDFkY3VTM3ErRnd6ckxucUxKVmduNGlUMVVpOWda?=
 =?utf-8?B?NlZSblJkK3MyQVpMZjJvNWZXdGpHVHZRMStxN1Vqakx2ZTJiejRkQkdKWFNP?=
 =?utf-8?B?endwaHc4UWpEVjdqYmxRTERrL3IxTHgxSlhXWmR0M1NrQmtwYVdaMnJYaTFN?=
 =?utf-8?B?Q1Bsc3hIQVFaQlJXbm56OGVYS3Jjd2xJa3NxQUdKNmQwTkZpTXNjWHMxL1px?=
 =?utf-8?B?a2g4T2hadE9ScWsyYWUzUmRIWlhldkM2VENrenJnQWRvSXE0YktBc0JxVzZ5?=
 =?utf-8?B?dSt6UEtjMTI0a05aZU10MzdjQ1YrSlJ1WmVNUEF6aloyTEdPZm5uUEdMN0o5?=
 =?utf-8?B?bzJzZ09abE1UNFg1T2VidGdDNnZHZFRCVENWa2dXQWVOWkcxVlZuMW9IcmtV?=
 =?utf-8?B?MURQZ0xqQnhQeFhKdXZNSkl5eDFuVDBiMFcwUDhNVzR0U0VhNDI3dnc2cXkv?=
 =?utf-8?B?cFlMN2tUeS9TLzZIY0JvNnI2NE9Gb3NiSUUvWi9lWDRjUUhiMllPU1FMTWI2?=
 =?utf-8?B?NzZLaGlkbGlVeFZHZGJHVU9Ob3lpcjZvbThMV2VBV1BWZGNvYlZDUFlMUzdN?=
 =?utf-8?B?aWNEeFF0QTFNK20ycFJEdnZWMlBqWG9XTTNDYkZwWDhpeHkzclR5Yk9Ydmk5?=
 =?utf-8?B?NGtldklhU0ZBSXlZeFluZnJSM2VYWGFUT1VnaVhldjU5UGYvTGVPVWhtOEEz?=
 =?utf-8?B?QkczaDZpR3pYZTJJY0FMdXBndG5RUFZtOHdLcGFaTjBZR0VqeWFudGhaQXU3?=
 =?utf-8?B?di91RzFEc2g5MG1iMUlqbVZkMCsvRU5GZXhXMDI0ZDF0UzUwMDU1QTlxQ2NX?=
 =?utf-8?Q?XCvqcedPCst905zbYz29ShU=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c5e299c6-7f2a-44ac-2a29-08d9ed3874b5
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2022 08:28:18.3804
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0bM+DNpBRQgNtvGOYQ7raym1Uh6qT5BN12xU2bTr8RLgxEwIhE8Y5FjfYGYMRMkTCJZ2Hrog7ANCd9nEWlplaw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4057
X-OriginatorOrg: citrix.com

On Thu, Feb 10, 2022 at 11:27:15AM -0600, Alex Olson wrote:
> I'm seeing strange performance issues under Xen on a Supermicro server with a Xeon D-1541 CPU caused by an MSR-related commit.
> 
> Commit 322ec7c89f6640ee2a99d1040b6f786cf04872cf 'x86/pv: disallow access to unknown MSRs'
> surprisingly introduces a severe performance penality where dom0 has about 1/8th
> the normal CPU performance. Even even when 'xenpm' is used to select the
> performance governor and operate the CPU at maximum frequency, actual CPU
> performance is still 1/2 of normal (as well as using "cpufreq=xen,performance").
> 
> The patch below fixes it but I don't fully understand why.
> 
> Basically, when *reads* of MSR_IA32_THERM_CONTROL are blocked, dom0 and
> guests (pinned to other CPUs) see the performance issues.

You only mention MSR_IA32_THERM_CONTROL here...

> For benchmarking purposes, I built a small C program that runs a "for
> loop" 
> 4Billion iterations and timed its execution. In dom0, the
> performance issues
> also cause HVM guest startup time to go from 9-10
> seconds to almost 80 seconds.
> 
> I assumed Xen was managing CPU frequency and thus blocking related MSR
> access by dom0 (or any other domain). However,  clearly something else
> is happening and I don't understand why.
> 
> I initially attempted to copy the same logic as the write MSR case. This
> was effective at fixing the dom0 performance issue, but still left other
> domains running at 1/2 speed. Hence, the change below has no access control.
> 
> 
> If anyone has any insight as to what is really happening, I would be all ears
> as I am unsure if the change below is a proper solution.
> 
> Thanks
> 
> -Alex
> 
> ---
> ---
>  xen/arch/x86/pv/emul-priv-op.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/xen/arch/x86/pv/emul-priv-op.c b/xen/arch/x86/pv/emul-priv-op.c
> index 7f4279a051..f254479bda 100644
> --- a/xen/arch/x86/pv/emul-priv-op.c
> +++ b/xen/arch/x86/pv/emul-priv-op.c
> @@ -970,6 +970,18 @@ static int read_msr(unsigned int reg, uint64_t *val,
>          *val = 0;
>          return X86EMUL_OKAY;
>  
> +    /* being unable to read MSR_IA32_THERM_CONTROL seems to significantly affect
> +     * dom0 and thus HVM guest startup performance, as well as PVH VMs.
> +     */
> +    case MSR_IA32_THERM_CONTROL:
> +    case MSR_IA32_ENERGY_PERF_BIAS:

...yet in the patch you also allow access to
MSR_IA32_ENERGY_PERF_BIAS, which makes me wonder whether
MSR_IA32_THERM_CONTROL is the only required one.

It could help to post full logs Xen + Linux dmesgs.

Is this reproducible with different Linux versions?

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Feb 11 08:31:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 08:31:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270211.464422 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIRKz-0008Be-IC; Fri, 11 Feb 2022 08:31:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270211.464422; Fri, 11 Feb 2022 08:31:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIRKz-0008BX-Dv; Fri, 11 Feb 2022 08:31:29 +0000
Received: by outflank-mailman (input) for mailman id 270211;
 Fri, 11 Feb 2022 08:31:28 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9nq0=S2=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1nIRKy-0008BR-TB
 for xen-devel@lists.xenproject.org; Fri, 11 Feb 2022 08:31:28 +0000
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01on0604.outbound.protection.outlook.com
 [2a01:111:f400:fe1f::604])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 00a1c9bb-8b15-11ec-8eb8-a37418f5ba1a;
 Fri, 11 Feb 2022 09:31:28 +0100 (CET)
Received: from DU2PR04CA0008.eurprd04.prod.outlook.com (2603:10a6:10:3b::13)
 by AM8PR08MB6369.eurprd08.prod.outlook.com (2603:10a6:20b:354::19) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Fri, 11 Feb
 2022 08:31:24 +0000
Received: from DB5EUR03FT003.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:3b:cafe::9e) by DU2PR04CA0008.outlook.office365.com
 (2603:10a6:10:3b::13) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.15 via Frontend
 Transport; Fri, 11 Feb 2022 08:31:24 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT003.mail.protection.outlook.com (10.152.20.157) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4975.11 via Frontend Transport; Fri, 11 Feb 2022 08:31:24 +0000
Received: ("Tessian outbound 31aeb3346a45:v113");
 Fri, 11 Feb 2022 08:31:24 +0000
Received: from 08d1fddbc887.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 16011179-B952-429D-A708-92DC074269EF.1; 
 Fri, 11 Feb 2022 08:31:18 +0000
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 08d1fddbc887.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 11 Feb 2022 08:31:18 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by AM5PR0802MB2562.eurprd08.prod.outlook.com (2603:10a6:203:a1::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.12; Fri, 11 Feb
 2022 08:31:16 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::aca7:79c4:fa65:dac6]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::aca7:79c4:fa65:dac6%4]) with mapi id 15.20.4951.019; Fri, 11 Feb 2022
 08:31:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 00a1c9bb-8b15-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=DmSgnt8LcDWe+DqzF3SmTmB0YXY947EaLgrHv9CCljs=;
 b=hM/wUwhcTiaOOsk2kdqsh4nnpbMM7jcU9qGDnuVq4QmDg2AzO2Sz2m0XVr7oMTIlj34tfH1LFwoCQr37VE3+olqcMBI52Oa/fibFOE6Bs6Mgsxi/vC8MWVCxtfZPqPPBei6Ue7w97gkN9Neo9PqIsXCG7SVN4IDJTesXXvLLugU=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 53ea50f208976187
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=lAqBIBP68NA11wQgcMVBwB4wF0niOfEWlJAYcJDjuXeslEhvS5eDVx923apLiKJ1uZCUe2HGkMTEufRKy11qcA18LWyvj7PZrI3l/Th3nKFdK4i8pl/JJ1yJcCtHQ0qc5+0kGZLm7exuJRBpOkB0UojS7HnGaIUSG6aUvETwib0GE4nYlNIQJz7Kj5GWMRKw2CLnZ+leu+xLx2JGjbgDBGN03cZ60ingmqlADlZ/u2GyXYAyYSf++Hj+XuLcPzMOvxAbpjal6gUTulxfwyhIae8GWkY/duPSyAXC0jtE9CELrlfzQarspLudPwpFMN9zGqS8HEbINgaallRyWGZJIw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=DmSgnt8LcDWe+DqzF3SmTmB0YXY947EaLgrHv9CCljs=;
 b=deqrWcoHtdiYjCmIG8RBiKqjXt1fvaHWAyA6py9mbitF//6pw57QxFy/or+9+By+CWXsfOOyNTLry/+IlsPublN/Pgsejny29PTKo/vpH1tI0SaTZsTE4aouDLIvl9pBPv3QnB713z2kHYj7Y06e+GSVzDikU5W5gpCUjMC9VaFM9EvpMOONKhtmFa/qy3O5i79TyjX5SDxRKhKuPOX3+giMl85WqThFefVD3ConACV+WIJGFGtV/cC81Dm+hm96uYmQekBMg69I7zPg9Sk5g+G52y3UgQIFUKQ5VpnPUpVrD8QjXSZbPswSgmtV7kMb/ptToEgE2s296kX5bAoq2A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=DmSgnt8LcDWe+DqzF3SmTmB0YXY947EaLgrHv9CCljs=;
 b=hM/wUwhcTiaOOsk2kdqsh4nnpbMM7jcU9qGDnuVq4QmDg2AzO2Sz2m0XVr7oMTIlj34tfH1LFwoCQr37VE3+olqcMBI52Oa/fibFOE6Bs6Mgsxi/vC8MWVCxtfZPqPPBei6Ue7w97gkN9Neo9PqIsXCG7SVN4IDJTesXXvLLugU=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"julien@xen.org" <julien@xen.org>, "Volodymyr_Babchuk@epam.com"
	<Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH] MAINTAINERS: make Bertrand ARM maintainer
Thread-Topic: [PATCH] MAINTAINERS: make Bertrand ARM maintainer
Thread-Index: AQHYHrGorW8uOCkvJkWS+UW+UYW3L6yOA4GAgAACkIA=
Date: Fri, 11 Feb 2022 08:31:16 +0000
Message-ID: <62B74E6A-3EF0-454B-8B05-5D6AC30322AE@arm.com>
References:
 <alpine.DEB.2.22.394.2202101026360.2091381@ubuntu-linux-20-04-desktop>
 <6847D807-EDF0-43C4-B09B-C79EFE99639F@arm.com>
In-Reply-To: <6847D807-EDF0-43C4-B09B-C79EFE99639F@arm.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3693.60.0.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 03b4b83a-dd38-43d8-d75c-08d9ed38e381
x-ms-traffictypediagnostic:
	AM5PR0802MB2562:EE_|DB5EUR03FT003:EE_|AM8PR08MB6369:EE_
X-Microsoft-Antispam-PRVS:
	<AM8PR08MB63697533DEE57F58E1387E589D309@AM8PR08MB6369.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:549;OLM:549;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 I+uoOkxb6MN1igsxkIYaDCqco56A4em/hjv2T6xWDxO1Y06jF/no32ABTH6qWSlXCq72Jc13OLyFrO0H7VlSDei6TwKg56EtbxFQFNc33WRKvsLRzwCYxdvJeqogkXEl7gjBpQ2nxuxS4nh43WfHKbR8yBVRFrNX1xNUX1qCumzdlrassWzbfDbPxKl8/7eNcQPDEnYT5/38rwG4vn0jydPQDCngQ0aNng4S26iFWoYzoRKf3iUo8cL2H48vbLDCkhlo9eDPwYm3dWsYq1/cP2xRD0FR8JfiqSL9hgFJ23Xyv9qbB8h8N6xTxVRQ0vdFI0sPMfOxyyzltn2KJwfTtDYa/sgaGvBdzmHLqoGcVV+Xp/B25pC9bPjxNNpNoYz91b9CQCxUoadCjkL1JaimNNshvsdaAkCl3iEfmo4GCEzRaJtkzd6hd568QnO2RQCxZkmfLKJpg3SikZ0YotmklE+WxSLKdL93TWZFP6PouZww4dU0W3NgT54tdNQaUYbI1RJP58afb1ZLtKuVET79kD/fXZzE9BnfKjLkAALHO0zTlQMiETCzL/JBEUnHrzPqkp+oc0wp29KAGXVKIoAoif/02oxjormyz4xllBFH1q6HSQZ3X7mHqe39YE3PrUP/tcn0p6uz+IgGAy1hhf72Yx8mmY+5e2OhZ7MFO9Rtk8fawMj5W4baDaRtGmzVOmvEoZvYS5hoS4R/COqBECicpPUUbrZmXmljL23cj+bEZHo=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(36756003)(2616005)(186003)(26005)(508600001)(53546011)(6512007)(6506007)(54906003)(4744005)(6486002)(66556008)(71200400001)(316002)(122000001)(38070700005)(91956017)(33656002)(86362001)(66476007)(76116006)(66946007)(5660300002)(6916009)(2906002)(8936002)(66446008)(38100700002)(4326008)(8676002)(64756008)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <9A96C60F602F9E44A6F6AC8BED63AB08@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0802MB2562
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT003.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	823eafb0-3ec2-45cc-6068-08d9ed38decf
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	sseUungji8S8AR7o8yiU/KVCq7/z5fRzl58QQNHcIOvyoBUWkZhd2gTQl0v7aPdSmh1iIf6IIgdTVis9s3QDuxoUb/Q1G8bTIwXUGiJfYiy0lM8Fx35R5Cs6+Vl6HDgwFChtYzttZ0+dUdH+wl14PHLe7TcKkGDs6ta5+FfnGy7vKuBQk+r8E+wIS24Jn0YRam0laGJqMiLncips+GxTbmNAfqC6bKSC/gypPHkDrY1XX/YYQ77YH6dVzvyymtMj2IvqCEpoSBk42fCs0dUBpWpxUznBRWPl21z3YxaUTunG9VL7cYbLxgzenLQDwAdJRamUNj3zbrBPS9LccIux3XYo+usWHymv2SNQttp58kUf1JjkQnJYeN+LbIDWB5a9SvHIoP1SArWDevNiHdKDD+m14hmomQKlGrPa5ebcLk2tJypRc7bdcdKdqOIWP8nk5PT6Ydsuk2TjgmPQvBJS4WqjzsCmRUc8FomvtPgsccrRCXvt9BxPqZgf59D5G/yswyyVLF4FpnlSLffp2/Z3ibLI/jBDC4CF5nGPBDhM+1Wd2xL2SrEuX5oM65DRfnK/oN4ZZGnjbQ3vBd28EI5LurST4CFEi6kb/ATYLiV4Ws2ZvN8LkcYqc9pbvVnt2glViXLdT0qy/MSiHBOjryN6ES2rSR4XsKmD07uC30lyk/ttMR1gDBd8bdEDgdFDz4I/
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(5660300002)(6486002)(53546011)(508600001)(186003)(336012)(26005)(107886003)(70206006)(33656002)(36860700001)(2616005)(4326008)(6862004)(40460700003)(2906002)(8676002)(70586007)(36756003)(81166007)(47076005)(54906003)(316002)(82310400004)(6512007)(356005)(8936002)(86362001)(6506007);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2022 08:31:24.0524
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 03b4b83a-dd38-43d8-d75c-08d9ed38e381
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT003.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6369

Hi,


> On 11 Feb 2022, at 08:22, Bertrand Marquis <bertrand.marquis@arm.com> wro=
te:
>=20
> Hi Stefano,
>=20
> Thanks a lot :-)
>=20
>> On 10 Feb 2022, at 19:08, Stefano Stabellini <sstabellini@kernel.org> wr=
ote:
>>=20
>> Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>


Fixing typo introduced by spell checker:

>=20
> Asked-by: Bertrand Marquis <bertrand.marquis@arm.com>

Acked-by : Bertrand Marquis <bertrand.marquis@arm.com>

Bertrand

>=20
> Cheers
> Bertrand
>=20
>>=20
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 64934cc070..d41572128b 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -230,8 +230,8 @@ F:	tools/libs/ctrl/xc_arinc653.c
>> ARM (W/ VIRTUALISATION EXTENSIONS) ARCHITECTURE
>> M:	Stefano Stabellini <sstabellini@kernel.org>
>> M:	Julien Grall <julien@xen.org>
>> +M:	Bertrand Marquis <bertrand.marquis@arm.com>
>> R:	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
>> -R:	Bertrand Marquis <bertrand.marquis@arm.com>
>> S:	Supported
>> L:	xen-devel@lists.xenproject.org
>> F:	docs/misc/arm/
>=20
>=20



From xen-devel-bounces@lists.xenproject.org Fri Feb 11 08:41:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 08:41:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270221.464433 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIRUL-0001Hq-Jp; Fri, 11 Feb 2022 08:41:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270221.464433; Fri, 11 Feb 2022 08:41:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIRUL-0001Hj-FA; Fri, 11 Feb 2022 08:41:09 +0000
Received: by outflank-mailman (input) for mailman id 270221;
 Fri, 11 Feb 2022 08:41:07 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nIRUJ-0001HZ-RY; Fri, 11 Feb 2022 08:41:07 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nIRUJ-00035b-Ny; Fri, 11 Feb 2022 08:41:07 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nIRUJ-0005AX-1E; Fri, 11 Feb 2022 08:41:07 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nIRUJ-0002TI-0m; Fri, 11 Feb 2022 08:41:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=TRR6uig8zCbRV+su/2obZYNQ8gQG+UaOnbph7Kyj/aE=; b=FsoqgXcknwM6SEtFSAKPWpbfjM
	HK1CLSCqwM3YMQvQV8vqKZoFuPp/hEBB3hj+mE+Nnp3IrwZkOzaUeQT/ZN1kUJ1o2I+TCm0laT6GV
	xzIqxnF3N4ZXt4o+3R1iMuXkrEVCtcJK76McwZxpYHNNkj9sBCB79aO/JS5BSgVXAZ74=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168082-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 168082: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=2ac78307af099a2af934d5499f262458f3ce0ea4
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 11 Feb 2022 08:41:07 +0000

flight 168082 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168082/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              2ac78307af099a2af934d5499f262458f3ce0ea4
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  581 days
Failing since        151818  2020-07-11 04:18:52 Z  580 days  562 attempts
Testing same since   168082  2022-02-11 04:20:14 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brad Laue <brad@brad-x.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Christophe Fergeau <cfergeau@redhat.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Divya Garg <divya.garg@nutanix.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Emilio Herrera <ehespinosa57@gmail.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Ivan Teterevkov <ivan.teterevkov@nutanix.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jing Qi <jinqi@redhat.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Lubomir Rintel <lkundrak@v3.sk>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nicolas Lécureuil <neoclust@mageia.org>
  Nicolas Lécureuil <nicolas.lecureuil@siveo.net>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Rohit Kumar <rohit.kumar3@nutanix.com>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  shenjiatong <yshxxsjt715@gmail.com>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tu Qiang <tu.qiang35@zte.com.cn>
  Tuguoyi <tu.guoyi@h3c.com>
  tuqiang <tu.qiang35@zte.com.cn>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Vineeth Pillai <viremana@linux.microsoft.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yasuhiko Kamata <belphegor@belbel.or.jp>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 96921 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Feb 11 08:46:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 08:46:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270232.464444 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIRZO-0001wE-9u; Fri, 11 Feb 2022 08:46:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270232.464444; Fri, 11 Feb 2022 08:46:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIRZO-0001w7-5R; Fri, 11 Feb 2022 08:46:22 +0000
Received: by outflank-mailman (input) for mailman id 270232;
 Fri, 11 Feb 2022 08:46:20 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9nq0=S2=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1nIRZM-0001w1-7S
 for xen-devel@lists.xenproject.org; Fri, 11 Feb 2022 08:46:20 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05on2061f.outbound.protection.outlook.com
 [2a01:111:f400:7e1b::61f])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 14c9741b-8b17-11ec-8f75-fffcc8bd4f1a;
 Fri, 11 Feb 2022 09:46:19 +0100 (CET)
Received: from AM6PR08CA0021.eurprd08.prod.outlook.com (2603:10a6:20b:b2::33)
 by AM6PR08MB3525.eurprd08.prod.outlook.com (2603:10a6:20b:4d::28)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Fri, 11 Feb
 2022 08:46:16 +0000
Received: from VE1EUR03FT044.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:b2:cafe::2f) by AM6PR08CA0021.outlook.office365.com
 (2603:10a6:20b:b2::33) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11 via Frontend
 Transport; Fri, 11 Feb 2022 08:46:15 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT044.mail.protection.outlook.com (10.152.19.106) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4975.11 via Frontend Transport; Fri, 11 Feb 2022 08:46:15 +0000
Received: ("Tessian outbound 2877e54fe176:v113");
 Fri, 11 Feb 2022 08:46:14 +0000
Received: from d3b29303cae0.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 D6CD6C9E-CB42-4C04-AA91-5D16378ADA22.1; 
 Fri, 11 Feb 2022 08:46:08 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d3b29303cae0.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 11 Feb 2022 08:46:08 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by AM4PR0802MB2323.eurprd08.prod.outlook.com (2603:10a6:200:61::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Fri, 11 Feb
 2022 08:46:05 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::aca7:79c4:fa65:dac6]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::aca7:79c4:fa65:dac6%4]) with mapi id 15.20.4951.019; Fri, 11 Feb 2022
 08:46:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 14c9741b-8b17-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=vQMkkzMJA6SnUvGrsy9DtU15zMV4oB7w9OZDon2iNcA=;
 b=oxaHyuz8ROohnjflJ/x8psnfawexNB6VYmi+fvrzlZtDMdzvEkCa12TOWQucYfIhokftFLlWsQZH9VbMFA4o5pI+IPHubOZ9Ge9xKaGyrbrBAEIY5ppbAwxgUBZ3iTpfeTdSysAaPj2juO7/Kur8uCay6iKJUv7UDT40pf2CUqM=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 3c103dba79b62796
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=H+yAWV0uw+7JEW9sGsI7ch/G7ZTLuU1yNV0dvWKbo9izciswzRzni+9aI8Yp9wZnlELKtsEfXYrQ4gMzTPkHL3GjkEzWuc+sFQxZ4YWrLhUJ89CAHHZ1ujMRyGfu+fSFViRXmMpw66JVNBtC5l7reR5j2FquNFdTbp3lxFIp3xlgW6N/SX5bE2RJD4dEvcTzvJgHxhd2ovR93RVzuSm4szNSnEuULI6dz5MD9B4GcPS6N10EVOqq3XsqGHT1vbmYTfJYmktTsl3eRoxDQlEMmb0KQsE1YerqCEK8MvlfJ4h9ipsI8CJDBczmX+AkjjgqON8gn46FVIZupoat8QPiBA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=vQMkkzMJA6SnUvGrsy9DtU15zMV4oB7w9OZDon2iNcA=;
 b=YilHCxCrJ/b/tKLwnNahT5XaUWyOmLV+Qvo2fkq/7BOZ0M4TiD4hcvf2bYRBHeUVzmIOp9UG89rAW8eiUYdjjxRW6PnuafY8nkeK9qUFlTDmkCnUp+jl+wOt31jDEwEy0zq7xlownElaa141nfYXKLSqIOplZbkODynrzoz7Ji48JbmxucxGxFFgyVOc2fo06smZTYpIrQBz2h9C947Ioc0jpWk8+KIaqYnJJmzo/e0VJPCwuc+k1vctjbe1mRBdqr5mSDSfVEENKMhu4R9Ts7StyU0aI7UBdoHz31t4SPvOirsQqplg8VQedau5OrOxPqp/IE2d76UNZ9TtFpwnNQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=vQMkkzMJA6SnUvGrsy9DtU15zMV4oB7w9OZDon2iNcA=;
 b=oxaHyuz8ROohnjflJ/x8psnfawexNB6VYmi+fvrzlZtDMdzvEkCa12TOWQucYfIhokftFLlWsQZH9VbMFA4o5pI+IPHubOZ9Ge9xKaGyrbrBAEIY5ppbAwxgUBZ3iTpfeTdSysAaPj2juO7/Kur8uCay6iKJUv7UDT40pf2CUqM=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Stefano
 Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Volodymyr
 Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [RFC v2 5/8] xen/arm: introduce SCMI-SMC mediator driver
Thread-Topic: [RFC v2 5/8] xen/arm: introduce SCMI-SMC mediator driver
Thread-Index: AQHYHRW24Dmb0qV8ZkqAv39Pf6/nVayODW6A
Date: Fri, 11 Feb 2022 08:46:05 +0000
Message-ID: <F9811680-C6EC-4372-A451-5C1DA279E35E@arm.com>
References: <cover.1644341635.git.oleksii_moisieiev@epam.com>
 <cb1493f5d9b5c3437268054b4a8e345cb35c8708.1644341635.git.oleksii_moisieiev@epam.com>
In-Reply-To:
 <cb1493f5d9b5c3437268054b4a8e345cb35c8708.1644341635.git.oleksii_moisieiev@epam.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3693.60.0.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 8df23766-40a3-46c1-7a52-08d9ed3af6ab
x-ms-traffictypediagnostic:
	AM4PR0802MB2323:EE_|VE1EUR03FT044:EE_|AM6PR08MB3525:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR08MB3525186F2694FAD4C847A6379D309@AM6PR08MB3525.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 qejN7X/koKxtL12k5Sa7GzEl0Kous5/LAs/M0ktF6mxXL/katY7PkjS79pczt+W9YjgONIv3oaUBmW+SKryVR7XoNVb0fcHgD4RP81YEel+btC+DWdhMfpbAotR0kpJWQgqK1CaK8e/QL3I6iZxCfqkH8Qh3fDKF+wnWb3IPUCvvk1FcOd9O+qzz2UZp9l8Sgq3L9PKL72zmVcTF2SF78r2sJ8gwSmOBXQc5NvjklPlA2OKc7VOlkdrj372SdxcTddDQjh3uWzu8Jo0cw1mDCfut4Et6QT2v2AyHPIeseIMxfBCsmMwdtZNHjlV2pkBfLL6Nhwbi/hTfBWWMiMF2nmkD/5taON+hepuHRMUKt7VlPT20wdc1+zlXci8Ax7dMAzwuYxReNUxpZNLFfNESQ/72Z9m32ywh/4zXKrKVwG2D5tW1J1b+sb/iX1rG/5KTXNDKGYn2EE58gn9IEW8HvdpXi3jQoOx0ZCwMVAL/IFzT3i+c7KQCBh3r61+Q3QfSv5GSUzZ5UqA/BYsMn2AxXoAsikkCrwFHIavbViHvLTkqgCioCDoXE3WbmhF+Rcdiq1+34Xji1bExKA8j9KBr4PTRNxA1hJp2S6Ck2eQ8H6+noascgPFTD2MJ1eMFl0XgQAZTmTBTyTTCf+1z+sf06RVUoAjbB1YXFnFYG1rwc2D14lnTt+OmUX0UmXqorD8+jGmz5GOoJS7Gnmk3rma0ySPgaIamIh5SQx95DIo7bTVFSUzMmvu4UczRbHTdk+XvYXFju/FRhugs34FXszGQCw==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(2616005)(2906002)(6512007)(26005)(186003)(38070700005)(86362001)(83380400001)(33656002)(30864003)(316002)(91956017)(76116006)(508600001)(66946007)(38100700002)(66556008)(66476007)(66446008)(64756008)(4326008)(122000001)(71200400001)(8676002)(5660300002)(6486002)(53546011)(6506007)(36756003)(54906003)(8936002)(6916009)(2004002)(45980500001)(579004)(559001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <FD80FDBDE00C3F448EE01280073467F2@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0802MB2323
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT044.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	900b16b9-b270-4ee4-c207-08d9ed3af0f5
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	6S3W9gvZJuFIbTXpkIn8oSAXP+HClEKkrXezyKzN9QomCSAyf7Nc0ru+W/1yJ6ciCw3v2MXFqETk2nwEgB9nEkKOlZM2+VoqopkBM+MocfeV3I6rLiW0gy+oVKJmAmdlDR7I7BjENcCF4IAH8yHytmKaNEElRHQTh9fdaalg91i/CFYHlfUJs6L034hq7PnWypYxYvPcBmAltEt48Qb7GnR3B94UntWduHzVsEsRf+BSBCtVlAwC6NSzIaYJxHmqfE/P2zNiwkRYN55k/tFm9GVWv4i8M59no6rIO4Mow+j52fu0fMVgmh2Gk/hnMtmWIt5RI9uYipcWlE/cJ8YRthIA+8Y36ACfILEr3wGMYeFX5kgS6YYwEnWSbuNXJKsTIt5CtRzH+JTKgs+RXAO4jShVecR94Wh58+y6XVSkkTx9yFTrdJqdFnAapX4jVHmaybg6MPt71sSOrzKfHK4oE9UQHlK32u7fmoQYS1cTXPU7jl+AL1IzLY0q0deHaVZ/Xl9CBdwybIk1tz43GyFYYZePfx6EdCKbCoH1ditq5wjCy+J5A3FunQsX7I3x6WXXAkDCDA6MyeET2lkZ3LwJj1NPVsNr8W+xWR8MdVBixTMkGTYiU6gO4jO/Ej9A1dqaLvL+bGx+GtpFkHwrHoIFbR1yMDej9wjXcqHJG2ETkYqHn6QgaI2KWvnu53HLD7m9SeqsOvRx6PPHU+44PSuDLA==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(508600001)(336012)(70586007)(4326008)(356005)(8936002)(70206006)(6486002)(8676002)(6506007)(33656002)(36756003)(86362001)(81166007)(53546011)(6862004)(82310400004)(316002)(6512007)(40460700003)(30864003)(107886003)(186003)(83380400001)(47076005)(26005)(5660300002)(36860700001)(2616005)(2906002)(54906003)(2004002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2022 08:46:15.0392
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 8df23766-40a3-46c1-7a52-08d9ed3af6ab
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT044.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3525

SGkgT2xla3NpaSwNCg0KDQo+IE9uIDggRmViIDIwMjIsIGF0IDE4OjAwLCBPbGVrc2lpIE1vaXNp
ZWlldiA8T2xla3NpaV9Nb2lzaWVpZXZAZXBhbS5jb20+IHdyb3RlOg0KPiANCj4gVGhpcyBpcyB0
aGUgaW1wbGVtZW50YXRpb24gb2YgU0NJIGludGVyZmFjZSwgY2FsbGVkIFNDTUktU01DIGRyaXZl
ciwNCj4gd2hpY2ggd29ya3MgYXMgdGhlIG1lZGlhdG9yIGJldHdlZW4gWEVOIERvbWFpbnMgYW5k
IEZpcm13YXJlIChTQ1AsIEFURiBldGMpLg0KPiBUaGlzIGFsbG93cyBkZXZpY2VzIGZyb20gdGhl
IERvbWFpbnMgdG8gd29yayB3aXRoIGNsb2NrcywgcmVzZXRzIGFuZA0KPiBwb3dlci1kb21haW5z
IHdpdGhvdXQgYWNjZXNzIHRvIENQRy4NCj4gDQo+IE9yaWdpbmFsbHksIGNwZyBzaG91bGQgYmUg
cGFzc2VkIHRvIHRoZSBkb21haW4gc28gaXQgY2FuIHdvcmsgd2l0aA0KPiBwb3dlci1kb21haW5z
L2Nsb2Nrcy9yZXNldHMgZXRjLiBDb25zaWRlcmluZyB0aGF0IGNwZyBjYW4ndCBiZSBzcGxpdCBi
ZXR3ZWVuDQo+IHRoZSBEb21haW5zLCB3ZSBnZXQgdGhlIGxpbWl0YXRpb24gdGhhdCB0aGUgZGV2
aWNlcywgd2hpY2ggYXJlIHVzaW5nDQo+IHBvd2VyLWRvbWFpbnMvY2xvY2tzL3Jlc2V0cyBldGMs
IGNvdWxkbid0IGJlIHNwbGl0IGJldHdlZW4gdGhlIGRvbWFpbnMuDQo+IFRoZSBzb2x1dGlvbiBp
cyB0byBtb3ZlIHRoZSBwb3dlci1kb21haW4vY2xvY2svcmVzZXRzIGV0YyB0byB0aGUNCj4gRmly
bXdhcmUgKHN1Y2ggYXMgU0NQIGZpcm13YXJlIG9yIEFURikgYW5kIHByb3ZpZGUgaW50ZXJmYWNl
IGZvciB0aGUNCj4gRG9tYWlucy4gWEVOIHNob3VsZCBoYXZlIGFuIGVudGl0eSwgY2FsZWQgU0NJ
LU1lZGlhdG9yLCB3aGljaCBpcw0KPiByZXNwb25zaWJsZSBmb3IgbWVzc2FnZXMgcmVkaXJlY3Rp
b24gYmV0d2VlbiBEb21haW5zIGFuZCBGaXJtd2FyZSBhbmQNCj4gZm9yIHBlcm1pc3Npb24gaGFu
ZGxpbmcuDQo+IA0KPiBUaGUgZm9sbG93aW5nIGZlYXR1cmVzIGFyZSBpbXBsZW1lbnRlZDoNCj4g
LSByZXF1ZXN0IFNDTUkgY2hhbm5lbHMgZnJvbSBBVEYgYW5kIHBhc3MgY2hhbm5lbHMgdG8gRG9t
YWluczsNCj4gLSBzZXQgZGV2aWNlIHBlcm1pc3Npb25zIGZvciBEb21haW5zIGJhc2VkIG9uIHRo
ZSBEb21haW4gcGFydGlhbA0KPiBkZXZpY2UtdHJlZS4gRGV2aWNlcyB3aXRoIHBlcm1pc3Npb25z
IGFyZSBhYmxlIHRvIHdvcmsgd2l0aCBjbG9ja3MsDQo+IHJlc2V0cyBhbmQgcG93ZXItZG9tYWlu
cyB2aWEgU0NNSTsNCj4gLSByZWRpcmVjdCBzY21pIG1lc3NhZ2VzIGZyb20gRG9tYWlucyB0byBB
VEYuDQoNCkJlZm9yZSBnb2luZyBtb3JlIGRlZXBseSBpbiB0aGUgY29kZSBJIHdvdWxkIGxpa2Ug
dG8gZGlzY3VzcyB0aGUgZ2VuZXJhbA0KZGVzaWduIGhlcmUgYW5kIGFzayBzb21lIHF1ZXN0aW9u
cyB0byBwcmV2ZW50IHRvIHJld29yayB0aGUgY29kZSBiZWZvcmUNCndlIGFsbCBhZ3JlZSB0aGF0
IHRoaXMgaXMgdGhlIHJpZ2h0IHNvbHV0aW9uIGFuZCB0aGF0IHdlIHdhbnQgdGhpcyBpbiBYZW4u
DQoNCkZpcnN0IEkgd2FudCB0byBwb2ludCBvdXQgdGhhdCBjbG9jay9yZXNldC9wb3dlciB2aXJ0
dWFsaXphdGlvbiBpcyBhIHByb2JsZW0NCm9uIG1vc3QgYXBwbGljYXRpb25zIHVzaW5nIGRldmlj
ZSBwYXNzLXRocm91Z2ggYW5kIEkgYW0gdmVyeSBnbGFkIHRoYXQNCnNvbWVvbmUgaXMgbG9va2lu
ZyBpbnRvIGl0Lg0KQWxzbyBTQ01JIGlzIHRoZSBjdXJyZW50IHN0YW5kYXJkIGV4aXN0aW5nIGZv
ciB0aGlzIHNvIHJlbHlpbmcgb24gaXQgaXMgYSB2ZXJ5DQpnb29kIGlkZWEuDQoNCkxhdGVzdCB2
ZXJzaW9uIFNDTUkgc3RhbmRhcmQgKERFTjAwNTZEIHYzLjEpIGlzIGRlZmluaW5nIHNvbWUgbWVh
bnMNCnRvIHVzZSBTQ01JIG9uIGEgdmlydHVhbGlzZWQgc3lzdGVtLiBJbiBjaGFwdGVyIDQuMi4x
LCB0aGUgc3RhbmRhcmQNCnJlY29tbWVuZHMgdG8gc2V0IHBlcm1pc3Npb25zIHBlciBhZ2VudCBp
biB0aGUgaHlwZXJ2aXNvciBzbyB0aGF0IGEgVk0NCmNvdWxkIGxhdGVyIHVzZSB0aGUgZGlzY292
ZXJ5IHByb3RvY29sIHRvIGRldGVjdCB0aGUgcmVzb3VyY2VzIGFuZCB1c2UgdGhlbS4NClVzaW5n
IHRoaXMga2luZCBvZiBzY2VuYXJpbyB0aGUgbWVkaWF0b3IgaW4gWGVuIHdvdWxkIGp1c3QgY29u
ZmlndXJlIHRoZQ0KUGVybWlzc2lvbnMgaW4gdGhlIFNDTUkgYW5kIHdvdWxkIHRoZW4gcmVseSBv
biBpdCB0byBsaW1pdCB3aGF0IGlzIHBvc3NpYmxlDQpieSB3aG8ganVzdCBieSBqdXN0IGFzc2ln
bmluZyBhIGNoYW5uZWwgdG8gYSBWTS4NCg0KSW4geW91ciBjdXJyZW50IGRlc2lnbiAocGxlYXNl
IGNvcnJlY3QgbWUgaWYgSSBhbSB3cm9uZykgeW91IHNlZW0gdG8gZnVsbHkNCnJlbHkgb24gWGVu
IGFuZCB0aGUgRkRUIGZvciBkaXNjb3ZlcnkgYW5kIHBlcm1pc3Npb24uDQpXb3VsZG7igJl0IGl0
IGJlIGEgYmV0dGVyIGlkZWEgdG8gdXNlIHRoZSBwcm90b2NvbCBmdWxseSA/DQpDb3VsZCB3ZSBn
ZXQgcmlkIG9mIHNvbWUgb2YgdGhlIEZEVCBkZXBlbmRlbmNpZXMgYnkgdXNpbmcgdGhlIGRpc2Nv
dmVyeQ0Kc3lzdGVtIG9mIFNDTUkgPw0KSG93IGlzIExpbnV4IGRvaW5nIHRoaXMgY3VycmVudGx5
ID8gSXMgaXQgcmVseWluZyBvbiBkZXZpY2UgdHJlZSB0byBkaXNjb3Zlcg0KIHRoZSBTQ01JIHJl
c291cmNlcyA/DQoNCkFsc28gSSB1bmRlcnN0YW5kIHRoYXQgeW91IHJlbHkgb24gc29tZSBlbnRy
aWVzIHRvIGJlIGRlY2xhcmVkIGluIHRoZSBkZXZpY2UNCnRyZWUgYW5kIGFsc28gc29tZSBzdXBw
b3J0IHRvIGJlIGltcGxlbWVudGVkIGluIEFURiBvciBTQ1AuIEkgY2hlY2tlZCBpbg0KVGhlIGJv
YXJkcyBJIGhhdmUgYWNjZXNzIHRvIGFuZCB0aGUgZGV2aWNlIHRyZWVzIGJ1dCBub25lIG9mIHRo
aXMgc2VlbSB0bw0KYmUgc3VwcG9ydGVkIHRoZXJlLiBDb3VsZCB5b3UgdGVsbCB3aGljaCBib2Fy
ZC9jb25maWd1cmF0aW9uL0FURiB5b3UgYXJlDQp1c2luZyBzbyB0aGF0IHRoZSBpbXBsZW1lbnRh
dGlvbiBjb3VsZCBiZSB0ZXN0ZWQvdmFsaWRhdGVkID8NCg0KDQpSZWdhcmRzDQpCZXJ0cmFuZA0K
DQoNCj4gDQo+IFNpZ25lZC1vZmYtYnk6IE9sZWtzaWkgTW9pc2llaWV2IDxvbGVrc2lpX21vaXNp
ZWlldkBlcGFtLmNvbT4NCj4gLS0tDQo+IHhlbi9hcmNoL2FybS9LY29uZmlnICAgICAgICB8ICAg
MiArDQo+IHhlbi9hcmNoL2FybS9zY2kvS2NvbmZpZyAgICB8ICAxMCArDQo+IHhlbi9hcmNoL2Fy
bS9zY2kvc2NtaV9zbWMuYyB8IDk1OSArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr
KysNCj4gMyBmaWxlcyBjaGFuZ2VkLCA5NzEgaW5zZXJ0aW9ucygrKQ0KPiBjcmVhdGUgbW9kZSAx
MDA2NDQgeGVuL2FyY2gvYXJtL3NjaS9LY29uZmlnDQo+IGNyZWF0ZSBtb2RlIDEwMDY0NCB4ZW4v
YXJjaC9hcm0vc2NpL3NjbWlfc21jLmMNCj4gDQo+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0v
S2NvbmZpZyBiL3hlbi9hcmNoL2FybS9LY29uZmlnDQo+IGluZGV4IGFiMDc4MzM1ODIuLjNiMGRm
YzU3YjYgMTAwNjQ0DQo+IC0tLSBhL3hlbi9hcmNoL2FybS9LY29uZmlnDQo+ICsrKyBiL3hlbi9h
cmNoL2FybS9LY29uZmlnDQo+IEBAIC0xMjMsNiArMTIzLDggQEAgY29uZmlnIEFSTV9TQ0kNCj4g
CSAgc3VwcG9ydC4gSXQgYWxsb3dzIGd1ZXN0cyB0byBjb250cm9sIHN5c3RlbSByZXNvdXJjZXNz
IHZpYSBvbmUgb2YNCj4gCSAgQVJNX1NDSSBtZWRpYXRvcnMgaW1wbGVtZW50ZWQgaW4gWEVOLg0K
PiANCj4gKwlzb3VyY2UgImFyY2gvYXJtL3NjaS9LY29uZmlnIg0KPiArDQo+IGVuZG1lbnUNCj4g
DQo+IG1lbnUgIkFSTSBlcnJhdGEgd29ya2Fyb3VuZCB2aWEgdGhlIGFsdGVybmF0aXZlIGZyYW1l
d29yayINCj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9zY2kvS2NvbmZpZyBiL3hlbi9hcmNo
L2FybS9zY2kvS2NvbmZpZw0KPiBuZXcgZmlsZSBtb2RlIDEwMDY0NA0KPiBpbmRleCAwMDAwMDAw
MDAwLi4xMGI2MzRkMmVkDQo+IC0tLSAvZGV2L251bGwNCj4gKysrIGIveGVuL2FyY2gvYXJtL3Nj
aS9LY29uZmlnDQo+IEBAIC0wLDAgKzEsMTAgQEANCj4gK2NvbmZpZyBTQ01JX1NNQw0KPiArCWJv
b2wgIkVuYWJsZSBTQ01JLVNNQyBtZWRpYXRvciBkcml2ZXIiDQo+ICsJZGVmYXVsdCBuDQo+ICsJ
ZGVwZW5kcyBvbiBBUk1fU0NJICYmIEhPU1RfRFRCX0VYUE9SVA0KPiArCS0tLWhlbHAtLS0NCj4g
Kw0KPiArCUVuYWJsZXMgbWVkaWF0b3IgaW4gWEVOIHRvIHBhc3MgU0NNSSByZXF1ZXN0cyBmcm9t
IERvbWFpbnMgdG8gQVRGLg0KPiArCVRoaXMgZmVhdHVyZSBhbGxvd3MgZHJpdmVycyBmcm9tIERv
bWFpbnMgdG8gd29yayB3aXRoIFN5c3RlbQ0KPiArCUNvbnRyb2xsZXJzIChzdWNoIGFzIHBvd2Vy
LHJlc2V0cyxjbG9jayBldGMuKS4gU0NQIGlzIHVzZWQgYXMgdHJhbnNwb3J0DQo+ICsJZm9yIGNv
bW11bmljYXRpb24uDQo+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vc2NpL3NjbWlfc21jLmMg
Yi94ZW4vYXJjaC9hcm0vc2NpL3NjbWlfc21jLmMNCj4gbmV3IGZpbGUgbW9kZSAxMDA2NDQNCj4g
aW5kZXggMDAwMDAwMDAwMC4uMTAzNTI5ZGZhYg0KPiAtLS0gL2Rldi9udWxsDQo+ICsrKyBiL3hl
bi9hcmNoL2FybS9zY2kvc2NtaV9zbWMuYw0KPiBAQCAtMCwwICsxLDk1OSBAQA0KPiArLyoNCj4g
KyAqIHhlbi9hcmNoL2FybS9zY2kvc2NtaV9zbWMuYw0KPiArICoNCj4gKyAqIFNDTUkgbWVkaWF0
b3IgZHJpdmVyLCB1c2luZyBTQ1AgYXMgdHJhbnNwb3J0Lg0KPiArICoNCj4gKyAqIE9sZWtzaWkg
TW9pc2llaWV2IDxvbGVrc2lpX21vaXNpZWlldkBlcGFtLmNvbT4NCj4gKyAqIENvcHlyaWdodCAo
QykgMjAyMSwgRVBBTSBTeXN0ZW1zLg0KPiArICoNCj4gKyAqIFRoaXMgcHJvZ3JhbSBpcyBmcmVl
IHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3IgbW9kaWZ5DQo+ICsgKiBp
dCB1bmRlciB0aGUgdGVybXMgb2YgdGhlIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGFzIHB1
Ymxpc2hlZCBieQ0KPiArICogdGhlIEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbjsgZWl0aGVyIHZl
cnNpb24gMiBvZiB0aGUgTGljZW5zZSwgb3INCj4gKyAqIChhdCB5b3VyIG9wdGlvbikgYW55IGxh
dGVyIHZlcnNpb24uDQo+ICsgKg0KPiArICogVGhpcyBwcm9ncmFtIGlzIGRpc3RyaWJ1dGVkIGlu
IHRoZSBob3BlIHRoYXQgaXQgd2lsbCBiZSB1c2VmdWwsDQo+ICsgKiBidXQgV0lUSE9VVCBBTlkg
V0FSUkFOVFk7IHdpdGhvdXQgZXZlbiB0aGUgaW1wbGllZCB3YXJyYW50eSBvZg0KPiArICogTUVS
Q0hBTlRBQklMSVRZIG9yIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQT1NFLiAgU2VlIHRo
ZQ0KPiArICogR05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2UgZm9yIG1vcmUgZGV0YWlscy4NCj4g
KyAqLw0KPiArDQo+ICsjaW5jbHVkZSA8YXNtL3NjaS9zY2kuaD4NCj4gKyNpbmNsdWRlIDxhc20v
c21jY2MuaD4NCj4gKyNpbmNsdWRlIDxhc20vaW8uaD4NCj4gKyNpbmNsdWRlIDx4ZW4vYml0b3Bz
Lmg+DQo+ICsjaW5jbHVkZSA8eGVuL2NvbmZpZy5oPg0KPiArI2luY2x1ZGUgPHhlbi9zY2hlZC5o
Pg0KPiArI2luY2x1ZGUgPHhlbi9kZXZpY2VfdHJlZS5oPg0KPiArI2luY2x1ZGUgPHhlbi9pb2Nh
cC5oPg0KPiArI2luY2x1ZGUgPHhlbi9pbml0Lmg+DQo+ICsjaW5jbHVkZSA8eGVuL2Vyci5oPg0K
PiArI2luY2x1ZGUgPHhlbi9saWIuaD4NCj4gKyNpbmNsdWRlIDx4ZW4vbGlzdC5oPg0KPiArI2lu
Y2x1ZGUgPHhlbi9tbS5oPg0KPiArI2luY2x1ZGUgPHhlbi9zdHJpbmcuaD4NCj4gKyNpbmNsdWRl
IDx4ZW4vdGltZS5oPg0KPiArI2luY2x1ZGUgPHhlbi92bWFwLmg+DQo+ICsNCj4gKyNkZWZpbmUg
U0NNSV9CQVNFX1BST1RPQ09MICAgICAgICAgICAgICAgICAgMHgxMA0KPiArI2RlZmluZSBTQ01J
X0JBU0VfUFJPVE9DT0xfQVRUSUJVVEVTICAgICAgICAweDENCj4gKyNkZWZpbmUgU0NNSV9CQVNF
X1NFVF9ERVZJQ0VfUEVSTUlTU0lPTlMgICAgMHg5DQo+ICsjZGVmaW5lIFNDTUlfQkFTRV9SRVNF
VF9BR0VOVF9DT05GSUdVUkFUSU9OIDB4Qg0KPiArI2RlZmluZSBTQ01JX0JBU0VfRElTQ09WRVJf
QUdFTlQgICAgICAgICAgICAweDcNCj4gKw0KPiArLyogU0NNSSByZXR1cm4gY29kZXMuIFNlZSBz
ZWN0aW9uIDQuMS40IG9mIFNDTUkgc3BlYyAoREVOMDA1NkMpICovDQo+ICsjZGVmaW5lIFNDTUlf
U1VDQ0VTUyAgICAgICAgICAgICAgMA0KPiArI2RlZmluZSBTQ01JX05PVF9TVVBQT1JURUQgICAg
ICAoLTEpDQo+ICsjZGVmaW5lIFNDTUlfSU5WQUxJRF9QQVJBTUVURVJTICgtMikNCj4gKyNkZWZp
bmUgU0NNSV9ERU5JRUQgICAgICAgICAgICAgKC0zKQ0KPiArI2RlZmluZSBTQ01JX05PVF9GT1VO
RCAgICAgICAgICAoLTQpDQo+ICsjZGVmaW5lIFNDTUlfT1VUX09GX1JBTkdFICAgICAgICgtNSkN
Cj4gKyNkZWZpbmUgU0NNSV9CVVNZICAgICAgICAgICAgICAgKC02KQ0KPiArI2RlZmluZSBTQ01J
X0NPTU1TX0VSUk9SICAgICAgICAoLTcpDQo+ICsjZGVmaW5lIFNDTUlfR0VORVJJQ19FUlJPUiAg
ICAgICgtOCkNCj4gKyNkZWZpbmUgU0NNSV9IQVJEV0FSRV9FUlJPUiAgICAgKC05KQ0KPiArI2Rl
ZmluZSBTQ01JX1BST1RPQ09MX0VSUk9SICAgICAoLTEwKQ0KPiArDQo+ICsjZGVmaW5lIERUX01B
VENIX1NDTUlfU01DIERUX01BVENIX0NPTVBBVElCTEUoImFybSxzY21pLXNtYyIpDQo+ICsNCj4g
KyNkZWZpbmUgU0NNSV9TTUNfSUQgICAgICAgICAgICAgICAgICAgICAgICAiYXJtLHNtYy1pZCIN
Cj4gKyNkZWZpbmUgU0NNSV9TSEFSRURfTUVNT1JZICAgICAgICAgICAgICAgICAiYXJtLHNjbWkt
c2htZW0iDQo+ICsjZGVmaW5lIFNDTUlfU0hNRU0gICAgICAgICAgICAgICAgICAgICAgICAgInNo
bWVtIg0KPiArI2RlZmluZSBTQ01JX1NITUVNX01BUFBFRF9TSVpFICAgICAgICAgICAgIFBBR0Vf
U0laRQ0KPiArDQo+ICsjZGVmaW5lIEhZUF9DSEFOTkVMICAgICAgICAgICAgICAgICAgICAgICAg
ICAweDANCj4gKw0KPiArI2RlZmluZSBIRFJfSUQgICAgICAgICAgICAgICAgICAgICAgICAgICAg
IEdFTk1BU0soNywwKQ0KPiArI2RlZmluZSBIRFJfVFlQRSAgICAgICAgICAgICAgICAgICAgICAg
ICAgIEdFTk1BU0soOSwgOCkNCj4gKyNkZWZpbmUgSERSX1BST1RPICAgICAgICAgICAgICAgICAg
ICAgICAgICBHRU5NQVNLKDE3LCAxMCkNCj4gKw0KPiArLyogU0NNSSBwcm90b2NvbCwgcmVmZXIg
dG8gc2VjdGlvbiA0LjIuMi4yIChERU4wMDU2QykgKi8NCj4gKyNkZWZpbmUgTVNHX05fQUdFTlRT
X01BU0sgICAgICAgICAgICAgICAgICBHRU5NQVNLKDE1LCA4KQ0KPiArDQo+ICsjZGVmaW5lIEZJ
RUxEX0dFVChfbWFzaywgX3JlZylcDQo+ICsgICAgKCh0eXBlb2YoX21hc2spKSgoKF9yZWcpICYg
KF9tYXNrKSkgPj4gKGZmczY0KF9tYXNrKSAtIDEpKSkNCj4gKyNkZWZpbmUgRklFTERfUFJFUChf
bWFzaywgX3ZhbClcDQo+ICsgICAgKCgodHlwZW9mKF9tYXNrKSkoX3ZhbCkgPDwgKGZmczY0KF9t
YXNrKSAtIDEpKSAmIChfbWFzaykpDQo+ICsNCj4gK3R5cGVkZWYgc3RydWN0IHNjbWlfbXNnX2hl
YWRlciB7DQo+ICsgICAgdWludDhfdCBpZDsNCj4gKyAgICB1aW50OF90IHR5cGU7DQo+ICsgICAg
dWludDhfdCBwcm90b2NvbDsNCj4gK30gc2NtaV9tc2dfaGVhZGVyX3Q7DQo+ICsNCj4gKyNkZWZp
bmUgU0NNSV9TSE1FTV9DSEFOX1NUQVRfQ0hBTk5FTF9GUkVFICAgQklUKDAsIFVMKQ0KPiArI2Rl
ZmluZSBTQ01JX1NITUVNX0NIQU5fU1RBVF9DSEFOTkVMX0VSUk9SICBCSVQoMSwgVUwpDQo+ICsN
Cj4gKyNkZWZpbmUgU0NNSV9BTExPV19BQ0NFU1MgICAgICAgICAgICAgICAgICAgQklUKDAsIFVM
KQ0KPiArDQo+ICtzdHJ1Y3Qgc2NtaV9zaGFyZWRfbWVtIHsNCj4gKyAgICB1aW50MzJfdCByZXNl
cnZlZDsNCj4gKyAgICB1aW50MzJfdCBjaGFubmVsX3N0YXR1czsNCj4gKyAgICB1aW50MzJfdCBy
ZXNlcnZlZDFbMl07DQo+ICsgICAgdWludDMyX3QgZmxhZ3M7DQo+ICsgICAgdWludDMyX3QgbGVu
Z3RoOw0KPiArICAgIHVpbnQzMl90IG1zZ19oZWFkZXI7DQo+ICsgICAgdWludDhfdCBtc2dfcGF5
bG9hZFtdOw0KPiArfTsNCj4gKw0KPiArc3RydWN0IGR0X2NoYW5uZWxfYWRkciB7DQo+ICsgICAg
dTY0IGFkZHI7DQo+ICsgICAgdTY0IHNpemU7DQo+ICsgICAgc3RydWN0IGxpc3RfaGVhZCBsaXN0
Ow0KPiArfTsNCj4gKw0KPiArc3RydWN0IHNjbWlfY2hhbm5lbCB7DQo+ICsgICAgaW50IGNoYW5f
aWQ7DQo+ICsgICAgaW50IGFnZW50X2lkOw0KPiArICAgIHVpbnQzMl90IGZ1bmNfaWQ7DQo+ICsg
ICAgZG9taWRfdCBkb21haW5faWQ7DQo+ICsgICAgdWludDY0X3QgcGFkZHI7DQo+ICsgICAgdWlu
dDY0X3QgbGVuOw0KPiArICAgIHN0cnVjdCBzY21pX3NoYXJlZF9tZW0gKnNobWVtOw0KPiArICAg
IHNwaW5sb2NrX3QgbG9jazsNCj4gKyAgICBzdHJ1Y3QgbGlzdF9oZWFkIGxpc3Q7DQo+ICt9Ow0K
PiArDQo+ICtzdHJ1Y3Qgc2NtaV9kYXRhIHsNCj4gKyAgICBzdHJ1Y3QgbGlzdF9oZWFkIGNoYW5u
ZWxfbGlzdDsNCj4gKyAgICBzcGlubG9ja190IGNoYW5uZWxfbGlzdF9sb2NrOw0KPiArICAgIGJv
b2wgaW5pdGlhbGl6ZWQ7DQo+ICt9Ow0KPiArDQo+ICtzdGF0aWMgc3RydWN0IHNjbWlfZGF0YSBz
Y21pX2RhdGE7DQo+ICsNCj4gKw0KPiArLyoNCj4gKyAqIHBhY2tfc2NtaV9oZWFkZXIoKSAtIHBh
Y2tzIGFuZCByZXR1cm5zIDMyLWJpdCBoZWFkZXINCj4gKyAqDQo+ICsgKiBAaGRyOiBwb2ludGVy
IHRvIGhlYWRlciBjb250YWluaW5nIGFsbCB0aGUgaW5mb3JtYXRpb24gb24gbWVzc2FnZSBpZCwN
Cj4gKyAqICAgIHByb3RvY29sIGlkIGFuZCB0eXBlIGlkLg0KPiArICoNCj4gKyAqIFJldHVybjog
MzItYml0IHBhY2tlZCBtZXNzYWdlIGhlYWRlciB0byBiZSBzZW50IHRvIHRoZSBwbGF0Zm9ybS4N
Cj4gKyAqLw0KPiArc3RhdGljIGlubGluZSB1aW50MzJfdCBwYWNrX3NjbWlfaGVhZGVyKHNjbWlf
bXNnX2hlYWRlcl90ICpoZHIpDQo+ICt7DQo+ICsgICAgcmV0dXJuIEZJRUxEX1BSRVAoSERSX0lE
LCBoZHItPmlkKSB8DQo+ICsgICAgICAgIEZJRUxEX1BSRVAoSERSX1RZUEUsIGhkci0+dHlwZSkg
fA0KPiArICAgICAgICBGSUVMRF9QUkVQKEhEUl9QUk9UTywgaGRyLT5wcm90b2NvbCk7DQo+ICt9
DQo+ICsNCj4gKy8qDQo+ICsgKiB1bnBhY2tfc2NtaV9oZWFkZXIoKSAtIHVucGFja3MgYW5kIHJl
Y29yZHMgbWVzc2FnZSBhbmQgcHJvdG9jb2wgaWQNCj4gKyAqDQo+ICsgKiBAbXNnX2hkcjogMzIt
Yml0IHBhY2tlZCBtZXNzYWdlIGhlYWRlciBzZW50IGZyb20gdGhlIHBsYXRmb3JtDQo+ICsgKiBA
aGRyOiBwb2ludGVyIHRvIGhlYWRlciB0byBmZXRjaCBtZXNzYWdlIGFuZCBwcm90b2NvbCBpZC4N
Cj4gKyAqLw0KPiArc3RhdGljIGlubGluZSB2b2lkIHVucGFja19zY21pX2hlYWRlcih1aW50MzJf
dCBtc2dfaGRyLCBzY21pX21zZ19oZWFkZXJfdCAqaGRyKQ0KPiArew0KPiArICAgIGhkci0+aWQg
PSBGSUVMRF9HRVQoSERSX0lELCBtc2dfaGRyKTsNCj4gKyAgICBoZHItPnR5cGUgPSBGSUVMRF9H
RVQoSERSX1RZUEUsIG1zZ19oZHIpOw0KPiArICAgIGhkci0+cHJvdG9jb2wgPSBGSUVMRF9HRVQo
SERSX1BST1RPLCBtc2dfaGRyKTsNCj4gK30NCj4gKw0KPiArc3RhdGljIGlubGluZSBpbnQgY2hh
bm5lbF9pc19mcmVlKHN0cnVjdCBzY21pX2NoYW5uZWwgKmNoYW5faW5mbykNCj4gK3sNCj4gKyAg
ICByZXR1cm4gKCBjaGFuX2luZm8tPnNobWVtLT5jaGFubmVsX3N0YXR1cw0KPiArICAgICAgICAg
ICAgJiBTQ01JX1NITUVNX0NIQU5fU1RBVF9DSEFOTkVMX0ZSRUUgKSA/IDAgOiAtRUJVU1k7DQo+
ICt9DQo+ICsNCj4gKy8qDQo+ICsgKiBDb3B5IGRhdGEgZnJvbSBJTyBtZW1vcnkgc3BhY2UgdG8g
InJlYWwiIG1lbW9yeSBzcGFjZS4NCj4gKyAqLw0KPiArdm9pZCBfX21lbWNweV9mcm9taW8odm9p
ZCAqdG8sIGNvbnN0IHZvbGF0aWxlIHZvaWQgX19pb21lbSAqZnJvbSwgc2l6ZV90IGNvdW50KQ0K
PiArew0KPiArICAgIHdoaWxlIChjb3VudCAmJiAhSVNfQUxJR05FRCgodW5zaWduZWQgbG9uZylm
cm9tLCA0KSkgew0KPiArICAgICAgICAqKHU4ICopdG8gPSBfX3Jhd19yZWFkYihmcm9tKTsNCj4g
KyAgICAgICAgZnJvbSsrOw0KPiArICAgICAgICB0bysrOw0KPiArICAgICAgICBjb3VudC0tOw0K
PiArICAgIH0NCj4gKw0KPiArICAgIHdoaWxlIChjb3VudCA+PSA0KSB7DQo+ICsgICAgICAgICoo
dTMyICopdG8gPSBfX3Jhd19yZWFkbChmcm9tKTsNCj4gKyAgICAgICAgZnJvbSArPSA0Ow0KPiAr
ICAgICAgICB0byArPSA0Ow0KPiArICAgICAgICBjb3VudCAtPSA0Ow0KPiArICAgIH0NCj4gKw0K
PiArICAgIHdoaWxlIChjb3VudCkgew0KPiArICAgICAgICAqKHU4ICopdG8gPSBfX3Jhd19yZWFk
Yihmcm9tKTsNCj4gKyAgICAgICAgZnJvbSsrOw0KPiArICAgICAgICB0bysrOw0KPiArICAgICAg
ICBjb3VudC0tOw0KPiArICAgIH0NCj4gK30NCj4gKw0KPiArLyoNCj4gKyAqIENvcHkgZGF0YSBm
cm9tICJyZWFsIiBtZW1vcnkgc3BhY2UgdG8gSU8gbWVtb3J5IHNwYWNlLg0KPiArICovDQo+ICt2
b2lkIF9fbWVtY3B5X3RvaW8odm9sYXRpbGUgdm9pZCBfX2lvbWVtICp0bywgY29uc3Qgdm9pZCAq
ZnJvbSwgc2l6ZV90IGNvdW50KQ0KPiArew0KPiArICAgIHdoaWxlIChjb3VudCAmJiAhSVNfQUxJ
R05FRCgodW5zaWduZWQgbG9uZyl0bywgNCkpIHsNCj4gKyAgICAgICAgX19yYXdfd3JpdGViKCoo
dTggKilmcm9tLCB0byk7DQo+ICsgICAgICAgIGZyb20rKzsNCj4gKyAgICAgICAgdG8rKzsNCj4g
KyAgICAgICAgY291bnQtLTsNCj4gKyAgICB9DQo+ICsNCj4gKyAgICB3aGlsZSAoY291bnQgPj0g
NCkgew0KPiArICAgICAgICBfX3Jhd193cml0ZWwoKih1MzIgKilmcm9tLCB0byk7DQo+ICsgICAg
ICAgIGZyb20gKz0gNDsNCj4gKyAgICAgICAgdG8gKz0gNDsNCj4gKyAgICAgICAgY291bnQgLT0g
NDsNCj4gKyAgICB9DQo+ICsNCj4gKyAgICB3aGlsZSAoY291bnQpIHsNCj4gKyAgICAgICAgX19y
YXdfd3JpdGViKCoodTggKilmcm9tLCB0byk7DQo+ICsgICAgICAgIGZyb20rKzsNCj4gKyAgICAg
ICAgdG8rKzsNCj4gKyAgICAgICAgY291bnQtLTsNCj4gKyAgICB9DQo+ICt9DQo+ICsNCj4gK3N0
YXRpYyBpbnQgc2VuZF9zbWNfbWVzc2FnZShzdHJ1Y3Qgc2NtaV9jaGFubmVsICpjaGFuX2luZm8s
DQo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgc2NtaV9tc2dfaGVhZGVyX3QgKmhkciwg
dm9pZCAqZGF0YSwgaW50IGxlbikNCj4gK3sNCj4gKyAgICBzdHJ1Y3QgYXJtX3NtY2NjX3JlcyBy
ZXNwOw0KPiArICAgIGludCByZXQ7DQo+ICsNCj4gKyAgICBpZiAoIChsZW4gKyBzaXplb2YoY2hh
bl9pbmZvLT5zaG1lbS0+bXNnX2hlYWRlcikpID4NCj4gKyAgICAgICAgICAgICAgICAgICAgICAg
ICBTQ01JX1NITUVNX01BUFBFRF9TSVpFICkNCj4gKyAgICB7DQo+ICsgICAgICAgIHByaW50ayhY
RU5MT0dfRVJSDQo+ICsgICAgICAgICAgICAgICAic2NtaTogV3Jvbmcgc2l6ZSBvZiBzbWMgbWVz
c2FnZS4gRGF0YSBpcyBpbnZhbGlkXG4iKTsNCj4gKyAgICAgICAgcmV0dXJuIC1FSU5WQUw7DQo+
ICsgICAgfQ0KPiArDQo+ICsgICAgcHJpbnRrKFhFTkxPR19ERUJVRyAic2NtaTogc3RhdHVzID0l
ZCBsZW49JWRcbiIsDQo+ICsgICAgICAgICAgIGNoYW5faW5mby0+c2htZW0tPmNoYW5uZWxfc3Rh
dHVzLCBsZW4pOw0KPiArICAgIHByaW50ayhYRU5MT0dfREVCVUcgInNjbWk6IGhlYWRlciBpZCA9
ICVkIHR5cGUgPSAlZCwgcHJvdG8gPSAlZFxuIiwNCj4gKyAgICAgICAgICAgaGRyLT5pZCwgaGRy
LT50eXBlLCBoZHItPnByb3RvY29sKTsNCj4gKw0KPiArICAgIHJldCA9IGNoYW5uZWxfaXNfZnJl
ZShjaGFuX2luZm8pOw0KPiArICAgIGlmICggSVNfRVJSX1ZBTFVFKHJldCkgKQ0KPiArICAgICAg
ICByZXR1cm4gcmV0Ow0KPiArDQo+ICsgICAgY2hhbl9pbmZvLT5zaG1lbS0+Y2hhbm5lbF9zdGF0
dXMgPSAweDA7DQo+ICsgICAgLyogV3JpdGluZyAweDAgcmlnaHQgbm93LCBidXQgU0NNSV9TSE1F
TV9GTEFHX0lOVFJfRU5BQkxFRCBjYW4gYmUgc2V0ICovDQo+ICsgICAgY2hhbl9pbmZvLT5zaG1l
bS0+ZmxhZ3MgPSAweDA7DQo+ICsgICAgY2hhbl9pbmZvLT5zaG1lbS0+bGVuZ3RoID0gc2l6ZW9m
KGNoYW5faW5mby0+c2htZW0tPm1zZ19oZWFkZXIpICsgbGVuOw0KPiArICAgIGNoYW5faW5mby0+
c2htZW0tPm1zZ19oZWFkZXIgPSBwYWNrX3NjbWlfaGVhZGVyKGhkcik7DQo+ICsNCj4gKyAgICBw
cmludGsoWEVOTE9HX0RFQlVHICJzY21pOiBXcml0aW5nIHRvIHNobWVtIGFkZHJlc3MgJXBcbiIs
DQo+ICsgICAgICAgICAgIGNoYW5faW5mby0+c2htZW0pOw0KPiArICAgIGlmICggbGVuID4gMCAm
JiBkYXRhICkNCj4gKyAgICAgICAgX19tZW1jcHlfdG9pbygodm9pZCAqKShjaGFuX2luZm8tPnNo
bWVtLT5tc2dfcGF5bG9hZCksIGRhdGEsIGxlbik7DQo+ICsNCj4gKyAgICBhcm1fc21jY2Nfc21j
KGNoYW5faW5mby0+ZnVuY19pZCwgMCwgMCwgMCwgMCwgMCwgMCwgY2hhbl9pbmZvLT5jaGFuX2lk
LA0KPiArICAgICAgICAgICAgICAgICAgJnJlc3ApOw0KPiArDQo+ICsgICAgcHJpbnRrKFhFTkxP
R19ERUJVRyAic2NtaTogc2NtY2NjX3NtYyByZXNwb25zZSAlZFxuIiwgKGludCkocmVzcC5hMCkp
Ow0KPiArDQo+ICsgICAgaWYgKCByZXNwLmEwICkNCj4gKyAgICAgICAgcmV0dXJuIC1FT1BOT1RT
VVBQOw0KPiArDQo+ICsgICAgcmV0dXJuIDA7DQo+ICt9DQo+ICsNCj4gK3N0YXRpYyBpbnQgY2hl
Y2tfc2NtaV9zdGF0dXMoaW50IHNjbWlfc3RhdHVzKQ0KPiArew0KPiArICAgIGlmICggc2NtaV9z
dGF0dXMgPT0gU0NNSV9TVUNDRVNTICkNCj4gKyAgICAgICAgcmV0dXJuIDA7DQo+ICsNCj4gKyAg
ICBwcmludGsoWEVOTE9HX0RFQlVHICJzY21pOiBFcnJvciByZWNlaXZlZDogJWRcbiIsIHNjbWlf
c3RhdHVzKTsNCj4gKw0KPiArICAgIHN3aXRjaCAoIHNjbWlfc3RhdHVzICkNCj4gKyAgICB7DQo+
ICsgICAgY2FzZSBTQ01JX05PVF9TVVBQT1JURUQ6DQo+ICsgICAgICAgIHJldHVybiAtRU9QTk9U
U1VQUDsNCj4gKyAgICBjYXNlIFNDTUlfSU5WQUxJRF9QQVJBTUVURVJTOg0KPiArICAgICAgICBy
ZXR1cm4gLUVJTlZBTDsNCj4gKyAgICBjYXNlIFNDTUlfREVOSUVEOg0KPiArICAgICAgICByZXR1
cm4gLUVBQ0NFUzsNCj4gKyAgICBjYXNlIFNDTUlfTk9UX0ZPVU5EOg0KPiArICAgICAgICByZXR1
cm4gLUVOT0VOVDsNCj4gKyAgICBjYXNlIFNDTUlfT1VUX09GX1JBTkdFOg0KPiArICAgICAgICBy
ZXR1cm4gLUVSQU5HRTsNCj4gKyAgICBjYXNlIFNDTUlfQlVTWToNCj4gKyAgICAgICAgcmV0dXJu
IC1FQlVTWTsNCj4gKyAgICBjYXNlIFNDTUlfQ09NTVNfRVJST1I6DQo+ICsgICAgICAgIHJldHVy
biAtRU5PVENPTk47DQo+ICsgICAgY2FzZSBTQ01JX0dFTkVSSUNfRVJST1I6DQo+ICsgICAgICAg
IHJldHVybiAtRUlPOw0KPiArICAgIGNhc2UgU0NNSV9IQVJEV0FSRV9FUlJPUjoNCj4gKyAgICAg
ICAgcmV0dXJuIC1FTlhJTzsNCj4gKyAgICBjYXNlIFNDTUlfUFJPVE9DT0xfRVJST1I6DQo+ICsg
ICAgICAgIHJldHVybiAtRUJBRE1TRzsNCj4gKyAgICBkZWZhdWx0Og0KPiArICAgICAgICByZXR1
cm4gLUVJTlZBTDsNCj4gKyAgICB9DQo+ICt9DQo+ICsNCj4gK3N0YXRpYyBpbnQgZ2V0X3NtY19y
ZXNwb25zZShzdHJ1Y3Qgc2NtaV9jaGFubmVsICpjaGFuX2luZm8sDQo+ICsgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgc2NtaV9tc2dfaGVhZGVyX3QgKmhkciwgdm9pZCAqZGF0YSwgaW50IGxl
bikNCj4gK3sNCj4gKyAgICBpbnQgcmVjdl9sZW47DQo+ICsgICAgaW50IHJldDsNCj4gKw0KPiAr
ICAgIHByaW50ayhYRU5MT0dfREVCVUcgInNjbWk6IGdldCBzbWMgcmVzcG9uY2UgbXNnaWQgJWRc
biIsIGhkci0+aWQpOw0KPiArDQo+ICsgICAgaWYgKCBsZW4gPj0gU0NNSV9TSE1FTV9NQVBQRURf
U0laRSAtIHNpemVvZihjaGFuX2luZm8tPnNobWVtKSApDQo+ICsgICAgew0KPiArICAgICAgICBw
cmludGsoWEVOTE9HX0VSUg0KPiArICAgICAgICAgICAgICAgInNjbWk6IFdyb25nIHNpemUgb2Yg
aW5wdXQgc21jIG1lc3NhZ2UuIERhdGEgbWF5IGJlIGludmFsaWRcbiIpOw0KPiArICAgICAgICBy
ZXR1cm4gLUVJTlZBTDsNCj4gKyAgICB9DQo+ICsNCj4gKyAgICByZXQgPSBjaGFubmVsX2lzX2Zy
ZWUoY2hhbl9pbmZvKTsNCj4gKyAgICBpZiAoIElTX0VSUl9WQUxVRShyZXQpICkNCj4gKyAgICAg
ICAgcmV0dXJuIHJldDsNCj4gKw0KPiArICAgIHJlY3ZfbGVuID0gY2hhbl9pbmZvLT5zaG1lbS0+
bGVuZ3RoIC0gc2l6ZW9mKGNoYW5faW5mby0+c2htZW0tPm1zZ19oZWFkZXIpOw0KPiArDQo+ICsg
ICAgaWYgKCByZWN2X2xlbiA8IDAgKQ0KPiArICAgIHsNCj4gKyAgICAgICAgcHJpbnRrKFhFTkxP
R19FUlINCj4gKyAgICAgICAgICAgICAgICJzY21pOiBXcm9uZyBzaXplIG9mIHNtYyBtZXNzYWdl
LiBEYXRhIG1heSBiZSBpbnZhbGlkXG4iKTsNCj4gKyAgICAgICAgcmV0dXJuIC1FSU5WQUw7DQo+
ICsgICAgfQ0KPiArDQo+ICsgICAgaWYgKCByZWN2X2xlbiA+IGxlbiApDQo+ICsgICAgew0KPiAr
ICAgICAgICBwcmludGsoWEVOTE9HX0VSUg0KPiArICAgICAgICAgICAgICAgInNjbWk6IE5vdCBl
bm91Z2ggYnVmZmVyIGZvciBtZXNzYWdlICVkLCBleHBlY3RpbmcgJWRcbiIsDQo+ICsgICAgICAg
ICAgICAgICByZWN2X2xlbiwgbGVuKTsNCj4gKyAgICAgICAgcmV0dXJuIC1FSU5WQUw7DQo+ICsg
ICAgfQ0KPiArDQo+ICsgICAgdW5wYWNrX3NjbWlfaGVhZGVyKGNoYW5faW5mby0+c2htZW0tPm1z
Z19oZWFkZXIsIGhkcik7DQo+ICsNCj4gKyAgICBpZiAoIHJlY3ZfbGVuID4gMCApDQo+ICsgICAg
ew0KPiArICAgICAgICBfX21lbWNweV9mcm9taW8oZGF0YSwgY2hhbl9pbmZvLT5zaG1lbS0+bXNn
X3BheWxvYWQsIHJlY3ZfbGVuKTsNCj4gKyAgICB9DQo+ICsNCj4gKyAgICByZXR1cm4gMDsNCj4g
K30NCj4gKw0KPiArc3RhdGljIGludCBkb19zbWNfeGZlcihzdHJ1Y3Qgc2NtaV9jaGFubmVsICpj
aGFubmVsLCBzY21pX21zZ19oZWFkZXJfdCAqaGRyLCB2b2lkICp0eF9kYXRhLCBpbnQgdHhfc2l6
ZSwNCj4gKyAgICAgICAgICAgICAgICAgICAgICAgdm9pZCAqcnhfZGF0YSwgaW50IHJ4X3NpemUp
DQo+ICt7DQo+ICsgICAgaW50IHJldCA9IDA7DQo+ICsNCj4gKyAgICBBU1NFUlQoIGNoYW5uZWwg
JiYgY2hhbm5lbC0+c2htZW0pOw0KPiArDQo+ICsgICAgaWYgKCAhaGRyICkNCj4gKyAgICAgICAg
cmV0dXJuIC1FSU5WQUw7DQo+ICsNCj4gKyAgICBzcGluX2xvY2soJmNoYW5uZWwtPmxvY2spOw0K
PiArDQo+ICsgICAgcmV0ID0gc2VuZF9zbWNfbWVzc2FnZShjaGFubmVsLCBoZHIsIHR4X2RhdGEs
IHR4X3NpemUpOw0KPiArICAgIGlmICggcmV0ICkNCj4gKyAgICAgICAgZ290byBjbGVhbjsNCj4g
Kw0KPiArICAgIHJldCA9IGdldF9zbWNfcmVzcG9uc2UoY2hhbm5lbCwgaGRyLCByeF9kYXRhLCBy
eF9zaXplKTsNCj4gK2NsZWFuOg0KPiArICAgIHNwaW5fdW5sb2NrKCZjaGFubmVsLT5sb2NrKTsN
Cj4gKw0KPiArICAgIHJldHVybiByZXQ7DQo+ICt9DQo+ICsNCj4gK3N0YXRpYyBzdHJ1Y3Qgc2Nt
aV9jaGFubmVsICpnZXRfY2hhbm5lbF9ieV9pZCh1aW50OF90IGNoYW5faWQpDQo+ICt7DQo+ICsg
ICAgc3RydWN0IHNjbWlfY2hhbm5lbCAqY3VycjsNCj4gKyAgICBib29sIGZvdW5kID0gZmFsc2U7
DQo+ICsNCj4gKyAgICBzcGluX2xvY2soJnNjbWlfZGF0YS5jaGFubmVsX2xpc3RfbG9jayk7DQo+
ICsgICAgbGlzdF9mb3JfZWFjaF9lbnRyeShjdXJyLCAmc2NtaV9kYXRhLmNoYW5uZWxfbGlzdCwg
bGlzdCkNCj4gKyAgICB7DQo+ICsgICAgICAgIGlmICggY3Vyci0+Y2hhbl9pZCA9PSBjaGFuX2lk
ICkNCj4gKyAgICAgICAgew0KPiArICAgICAgICAgICAgZm91bmQgPSB0cnVlOw0KPiArICAgICAg
ICAgICAgYnJlYWs7DQo+ICsgICAgICAgIH0NCj4gKyAgICB9DQo+ICsNCj4gKyAgICBzcGluX3Vu
bG9jaygmc2NtaV9kYXRhLmNoYW5uZWxfbGlzdF9sb2NrKTsNCj4gKyAgICBpZiAoIGZvdW5kICkN
Cj4gKyAgICAgICAgcmV0dXJuIGN1cnI7DQo+ICsNCj4gKyAgICByZXR1cm4gTlVMTDsNCj4gK30N
Cj4gKw0KPiArc3RhdGljIHN0cnVjdCBzY21pX2NoYW5uZWwgKmFxdWlyZV9zY21pX2NoYW5uZWwo
ZG9taWRfdCBkb21haW5faWQpDQo+ICt7DQo+ICsgICAgc3RydWN0IHNjbWlfY2hhbm5lbCAqY3Vy
cjsNCj4gKyAgICBib29sIGZvdW5kID0gZmFsc2U7DQo+ICsNCj4gKyAgICBBU1NFUlQoZG9tYWlu
X2lkICE9IERPTUlEX0lOVkFMSUQgJiYgZG9tYWluX2lkID49IDApOw0KPiArDQo+ICsgICAgc3Bp
bl9sb2NrKCZzY21pX2RhdGEuY2hhbm5lbF9saXN0X2xvY2spOw0KPiArICAgIGxpc3RfZm9yX2Vh
Y2hfZW50cnkoY3VyciwgJnNjbWlfZGF0YS5jaGFubmVsX2xpc3QsIGxpc3QpDQo+ICsgICAgew0K
PiArICAgICAgICBpZiAoIGN1cnItPmRvbWFpbl9pZCA9PSBET01JRF9JTlZBTElEICkNCj4gKyAg
ICAgICAgew0KPiArICAgICAgICAgICAgY3Vyci0+ZG9tYWluX2lkID0gZG9tYWluX2lkOw0KPiAr
ICAgICAgICAgICAgZm91bmQgPSB0cnVlOw0KPiArICAgICAgICAgICAgYnJlYWs7DQo+ICsgICAg
ICAgIH0NCj4gKyAgICB9DQo+ICsNCj4gKyAgICBzcGluX3VubG9jaygmc2NtaV9kYXRhLmNoYW5u
ZWxfbGlzdF9sb2NrKTsNCj4gKyAgICBpZiAoIGZvdW5kICkNCj4gKyAgICAgICAgcmV0dXJuIGN1
cnI7DQo+ICsNCj4gKyAgICByZXR1cm4gTlVMTDsNCj4gK30NCj4gKw0KPiArc3RhdGljIHZvaWQg
cmVsaW5xdWlzaF9zY21pX2NoYW5uZWwoc3RydWN0IHNjbWlfY2hhbm5lbCAqY2hhbm5lbCkNCj4g
K3sNCj4gKyAgICBBU1NFUlQoY2hhbm5lbCAhPSBOVUxMKTsNCj4gKw0KPiArICAgIHNwaW5fbG9j
aygmc2NtaV9kYXRhLmNoYW5uZWxfbGlzdF9sb2NrKTsNCj4gKyAgICBjaGFubmVsLT5kb21haW5f
aWQgPSBET01JRF9JTlZBTElEOw0KPiArICAgIHNwaW5fdW5sb2NrKCZzY21pX2RhdGEuY2hhbm5l
bF9saXN0X2xvY2spOw0KPiArfQ0KPiArDQo+ICtzdGF0aWMgaW50IG1hcF9jaGFubmVsX21lbW9y
eShzdHJ1Y3Qgc2NtaV9jaGFubmVsICpjaGFubmVsKQ0KPiArew0KPiArICAgIEFTU0VSVCggY2hh
bm5lbCAmJiBjaGFubmVsLT5wYWRkciApOw0KPiArICAgIGNoYW5uZWwtPnNobWVtID0gaW9yZW1h
cF9jYWNoZShjaGFubmVsLT5wYWRkciwgU0NNSV9TSE1FTV9NQVBQRURfU0laRSk7DQo+ICsgICAg
aWYgKCAhY2hhbm5lbC0+c2htZW0gKQ0KPiArICAgICAgICByZXR1cm4gLUVOT01FTTsNCj4gKw0K
PiArICAgIGNoYW5uZWwtPnNobWVtLT5jaGFubmVsX3N0YXR1cyA9IFNDTUlfU0hNRU1fQ0hBTl9T
VEFUX0NIQU5ORUxfRlJFRTsNCj4gKyAgICBwcmludGsoWEVOTE9HX0RFQlVHICJzY21pOiBHb3Qg
c2htZW0gYWZ0ZXIgdm1hcCAlcFxuIiwgY2hhbm5lbC0+c2htZW0pOw0KPiArICAgIHJldHVybiAw
Ow0KPiArfQ0KPiArDQo+ICtzdGF0aWMgdm9pZCB1bm1hcF9jaGFubmVsX21lbW9yeShzdHJ1Y3Qg
c2NtaV9jaGFubmVsICpjaGFubmVsKQ0KPiArew0KPiArICAgIEFTU0VSVCggY2hhbm5lbCAmJiBj
aGFubmVsLT5zaG1lbSApOw0KPiArICAgIGlvdW5tYXAoY2hhbm5lbC0+c2htZW0pOw0KPiArICAg
IGNoYW5uZWwtPnNobWVtID0gTlVMTDsNCj4gK30NCj4gKw0KPiArc3RhdGljIHN0cnVjdCBzY21p
X2NoYW5uZWwgKnNtY19jcmVhdGVfY2hhbm5lbCh1aW50OF90IGNoYW5faWQsDQo+ICsgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVpbnQzMl90IGZ1bmNfaWQs
IHVpbnQ2NF90IGFkZHIpDQo+ICt7DQo+ICsgICAgc3RydWN0IHNjbWlfY2hhbm5lbCAqY2hhbm5l
bDsNCj4gKw0KPiArICAgIGNoYW5uZWwgPSBnZXRfY2hhbm5lbF9ieV9pZChjaGFuX2lkKTsNCj4g
KyAgICBpZiAoIGNoYW5uZWwgKQ0KPiArICAgICAgICByZXR1cm4gRVJSX1BUUihFRVhJU1QpOw0K
PiArDQo+ICsgICAgY2hhbm5lbCA9IHhtYWxsb2Moc3RydWN0IHNjbWlfY2hhbm5lbCk7DQo+ICsg
ICAgaWYgKCAhY2hhbm5lbCApDQo+ICsgICAgICAgIHJldHVybiBFUlJfUFRSKEVOT01FTSk7DQo+
ICsNCj4gKyAgICBjaGFubmVsLT5jaGFuX2lkID0gY2hhbl9pZDsNCj4gKyAgICBjaGFubmVsLT5m
dW5jX2lkID0gZnVuY19pZDsNCj4gKyAgICBjaGFubmVsLT5kb21haW5faWQgPSBET01JRF9JTlZB
TElEOw0KPiArICAgIGNoYW5uZWwtPnNobWVtID0gTlVMTDsNCj4gKyAgICBjaGFubmVsLT5wYWRk
ciA9IGFkZHI7DQo+ICsgICAgc3Bpbl9sb2NrX2luaXQoJmNoYW5uZWwtPmxvY2spOw0KPiArICAg
IHNwaW5fbG9jaygmc2NtaV9kYXRhLmNoYW5uZWxfbGlzdF9sb2NrKTsNCj4gKyAgICBsaXN0X2Fk
ZCgmY2hhbm5lbC0+bGlzdCwgJnNjbWlfZGF0YS5jaGFubmVsX2xpc3QpOw0KPiArICAgIHNwaW5f
dW5sb2NrKCZzY21pX2RhdGEuY2hhbm5lbF9saXN0X2xvY2spOw0KPiArICAgIHJldHVybiBjaGFu
bmVsOw0KPiArfQ0KPiArDQo+ICtzdGF0aWMgaW50IG1lbV9wZXJtaXRfYWNjZXNzKHN0cnVjdCBk
b21haW4gKmQsIHVpbnQ2NF90IGFkZHIsIHVpbnQ2NF90IGxlbikNCj4gK3sNCj4gKyAgICByZXR1
cm4gaW9tZW1fcGVybWl0X2FjY2VzcyhkLCBwYWRkcl90b19wZm4oYWRkciksDQo+ICsgICAgICAg
ICAgICAgICAgcGFkZHJfdG9fcGZuKFBBR0VfQUxJR04oYWRkciArIGxlbiAtMSkpKTsNCj4gK30N
Cj4gKw0KPiArc3RhdGljIGludCBtZW1fZGVueV9hY2Nlc3Moc3RydWN0IGRvbWFpbiAqZCwgdWlu
dDY0X3QgYWRkciwNCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1aW50
NjRfdCBsZW4pDQo+ICt7DQo+ICsgICAgcmV0dXJuIGlvbWVtX2RlbnlfYWNjZXNzKGQsIHBhZGRy
X3RvX3BmbihhZGRyKSwNCj4gKyAgICAgICAgICAgICAgICBwYWRkcl90b19wZm4oUEFHRV9BTElH
TihhZGRyICsgbGVuIC0xKSkpOw0KPiArfQ0KPiArDQo+ICtzdGF0aWMgaW50IGR0X3VwZGF0ZV9k
b21haW5fcmFuZ2UodWludDY0X3QgYWRkciwgdWludDY0X3Qgc2l6ZSkNCj4gK3sNCj4gKyAgICBz
dHJ1Y3QgZHRfZGV2aWNlX25vZGUgKnNobWVtX25vZGU7DQo+ICsgICAgX19iZTMyICpod19yZWc7
DQo+ICsgICAgY29uc3Qgc3RydWN0IGR0X3Byb3BlcnR5ICpwcDsNCj4gKyAgICB1aW50MzJfdCBs
ZW47DQo+ICsNCj4gKyAgICBzaG1lbV9ub2RlID0gZHRfZmluZF9jb21wYXRpYmxlX25vZGUoTlVM
TCwgTlVMTCwgU0NNSV9TSEFSRURfTUVNT1JZKTsNCj4gKyAgICBpZiAoICFzaG1lbV9ub2RlICkN
Cj4gKyAgICB7DQo+ICsgICAgICAgIHByaW50ayhYRU5MT0dfRVJSICJzY21pOiBVbmFibGUgdG8g
ZmluZCAlcyBub2RlIGluIERUXG4iLCBTQ01JX1NITUVNKTsNCj4gKyAgICAgICAgcmV0dXJuIC1F
SU5WQUw7DQo+ICsgICAgfQ0KPiArDQo+ICsgICAgcHAgPSBkdF9maW5kX3Byb3BlcnR5KHNobWVt
X25vZGUsICJyZWciLCAmbGVuKTsNCj4gKyAgICBpZiAoICFwcCApDQo+ICsgICAgew0KPiArICAg
ICAgICBwcmludGsoWEVOTE9HX0VSUiAic2NtaTogVW5hYmxlIHRvIGZpbmQgcmVncyBlbnRyeSBp
biBzaG1lbSBub2RlXG4iKTsNCj4gKyAgICAgICAgcmV0dXJuIC1FTk9FTlQ7DQo+ICsgICAgfQ0K
PiArDQo+ICsgICAgaHdfcmVnID0gcHAtPnZhbHVlOw0KPiArICAgIGR0X3NldF9yYW5nZSgmaHdf
cmVnLCBzaG1lbV9ub2RlLCBhZGRyLCBzaXplKTsNCj4gKw0KPiArICAgIHJldHVybiAwOw0KPiAr
fQ0KPiArDQo+ICtzdGF0aWMgdm9pZCBmcmVlX2NoYW5uZWxfbGlzdCh2b2lkKQ0KPiArew0KPiAr
ICAgIHN0cnVjdCBzY21pX2NoYW5uZWwgKmN1cnIsICpfY3VycjsNCj4gKw0KPiArICAgIHNwaW5f
bG9jaygmc2NtaV9kYXRhLmNoYW5uZWxfbGlzdF9sb2NrKTsNCj4gKyAgICBsaXN0X2Zvcl9lYWNo
X2VudHJ5X3NhZmUgKGN1cnIsIF9jdXJyLCAmc2NtaV9kYXRhLmNoYW5uZWxfbGlzdCwgbGlzdCkN
Cj4gKyAgICB7DQo+ICsgICAgICAgIGxpc3RfZGVsKCZjdXJyLT5saXN0KTsNCj4gKyAgICAgICAg
eGZyZWUoY3Vycik7DQo+ICsgICAgfQ0KPiArDQo+ICsgICAgc3Bpbl91bmxvY2soJnNjbWlfZGF0
YS5jaGFubmVsX2xpc3RfbG9jayk7DQo+ICt9DQo+ICsNCj4gK3N0YXRpYyBzdHJ1Y3QgZHRfZGV2
aWNlX25vZGUgKmdldF9kdF9ub2RlX2Zyb21fcHJvcGVydHkoDQo+ICsgICAgICAgICAgICAgICAg
c3RydWN0IGR0X2RldmljZV9ub2RlICpub2RlLCBjb25zdCBjaGFyICogcF9uYW1lKQ0KPiArew0K
PiArICAgIGNvbnN0IF9fYmUzMiAqcHJvcDsNCj4gKw0KPiArICAgIEFTU0VSVCggbm9kZSApOw0K
PiArDQo+ICsgICAgcHJvcCA9IGR0X2dldF9wcm9wZXJ0eShub2RlLCBwX25hbWUsIE5VTEwpOw0K
PiArICAgIGlmICggIXByb3AgKQ0KPiArICAgICAgICByZXR1cm4gRVJSX1BUUigtRUlOVkFMKTsN
Cj4gKw0KPiArICAgIHJldHVybiBkdF9maW5kX25vZGVfYnlfcGhhbmRsZShiZTMyX3RvX2NwdXAo
cHJvcCkpOw0KPiArfQ0KPiArDQo+ICtzdGF0aWMgaW50IGdldF9zaG1lbV9yZWdpb25zKHN0cnVj
dCBsaXN0X2hlYWQgKmhlYWQsIHU2NCBoeXBfYWRkcikNCj4gK3sNCj4gKyAgICBzdHJ1Y3QgZHRf
ZGV2aWNlX25vZGUgKm5vZGU7DQo+ICsgICAgaW50IHJldDsNCj4gKyAgICBzdHJ1Y3QgZHRfY2hh
bm5lbF9hZGRyICpsY2hhbjsNCj4gKyAgICB1NjQgbGFkZHIsIGxzaXplOw0KPiArDQo+ICsgICAg
bm9kZSA9IGR0X2ZpbmRfY29tcGF0aWJsZV9ub2RlKE5VTEwsIE5VTEwsIFNDTUlfU0hBUkVEX01F
TU9SWSk7DQo+ICsgICAgaWYgKCAhbm9kZSApDQo+ICsgICAgICAgIHJldHVybiAtRU5PRU5UOw0K
PiArDQo+ICsgICAgd2hpbGUgKCBub2RlICkNCj4gKyAgICB7DQo+ICsgICAgICAgIHJldCA9IGR0
X2RldmljZV9nZXRfYWRkcmVzcyhub2RlLCAwLCAmbGFkZHIsICZsc2l6ZSk7DQo+ICsgICAgICAg
IGlmICggcmV0ICkNCj4gKyAgICAgICAgICAgIHJldHVybiByZXQ7DQo+ICsNCj4gKyAgICAgICAg
aWYgKCBsYWRkciAhPSBoeXBfYWRkciApDQo+ICsgICAgICAgIHsNCj4gKyAgICAgICAgICAgIGxj
aGFuID0geG1hbGxvYyhzdHJ1Y3QgZHRfY2hhbm5lbF9hZGRyKTsNCj4gKyAgICAgICAgICAgIGlm
ICggIWxjaGFuICkNCj4gKyAgICAgICAgICAgICAgICByZXR1cm4gLUVOT01FTTsNCj4gKyAgICAg
ICAgICAgIGxjaGFuLT5hZGRyID0gbGFkZHI7DQo+ICsgICAgICAgICAgICBsY2hhbi0+c2l6ZSA9
IGxzaXplOw0KPiArDQo+ICsgICAgICAgICAgICBsaXN0X2FkZF90YWlsKCZsY2hhbi0+bGlzdCwg
aGVhZCk7DQo+ICsgICAgICAgIH0NCj4gKw0KPiArICAgICAgICBub2RlID0gZHRfZmluZF9jb21w
YXRpYmxlX25vZGUobm9kZSwgTlVMTCwgU0NNSV9TSEFSRURfTUVNT1JZKTsNCj4gKyAgICB9DQo+
ICsNCj4gKyAgICByZXR1cm4gMDsNCj4gK30NCj4gKw0KPiArc3RhdGljIGludCByZWFkX2h5cF9j
aGFubmVsX2FkZHIoc3RydWN0IGR0X2RldmljZV9ub2RlICpzY21pX25vZGUsDQo+ICsgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICB1NjQgKmFkZHIsIHU2NCAqc2l6ZSkNCj4gK3sNCj4g
KyAgICBzdHJ1Y3QgZHRfZGV2aWNlX25vZGUgKnNobWVtX25vZGU7DQo+ICsgICAgc2htZW1fbm9k
ZSA9IGdldF9kdF9ub2RlX2Zyb21fcHJvcGVydHkoc2NtaV9ub2RlLCAic2htZW0iKTsNCj4gKyAg
ICBpZiAoIElTX0VSUl9PUl9OVUxMKHNobWVtX25vZGUpICkNCj4gKyAgICB7DQo+ICsgICAgICAg
IHByaW50ayhYRU5MT0dfRVJSDQo+ICsgICAgICAgICAgICAgICAic2NtaTogRGV2aWNlIHRyZWUg
ZXJyb3IsIGNhbid0IHBhcnNlIHJlc2VydmVkIG1lbW9yeSAlbGRcbiIsDQo+ICsgICAgICAgICAg
ICAgICBQVFJfRVJSKHNobWVtX25vZGUpKTsNCj4gKyAgICAgICAgcmV0dXJuIFBUUl9FUlIoc2ht
ZW1fbm9kZSk7DQo+ICsgICAgfQ0KPiArDQo+ICsgICAgcmV0dXJuIGR0X2RldmljZV9nZXRfYWRk
cmVzcyhzaG1lbV9ub2RlLCAwLCBhZGRyLCBzaXplKTsNCj4gK30NCj4gKw0KPiArc3RhdGljIHZv
aWQgZnJlZV9zaG1lbV9yZWdpb25zKHN0cnVjdCBsaXN0X2hlYWQgKmFkZHJfbGlzdCkNCj4gK3sN
Cj4gKyAgICBzdHJ1Y3QgZHRfY2hhbm5lbF9hZGRyICpjdXJyLCAqX2N1cnI7DQo+ICsNCj4gKyAg
ICBsaXN0X2Zvcl9lYWNoX2VudHJ5X3NhZmUgKGN1cnIsIF9jdXJyLCBhZGRyX2xpc3QsIGxpc3Qp
DQo+ICsgICAgew0KPiArICAgICAgICBsaXN0X2RlbCgmY3Vyci0+bGlzdCk7DQo+ICsgICAgICAg
IHhmcmVlKGN1cnIpOw0KPiArICAgIH0NCj4gK30NCj4gKw0KPiArc3RhdGljIF9faW5pdCBib29s
IHNjbWlfcHJvYmUoc3RydWN0IGR0X2RldmljZV9ub2RlICpzY21pX25vZGUpDQo+ICt7DQo+ICsg
ICAgdTY0IGFkZHIsIHNpemU7DQo+ICsgICAgaW50IHJldCwgaTsNCj4gKyAgICBzdHJ1Y3Qgc2Nt
aV9jaGFubmVsICpjaGFubmVsLCAqYWdlbnRfY2hhbm5lbDsNCj4gKyAgICBpbnQgbl9hZ2VudHM7
DQo+ICsgICAgc2NtaV9tc2dfaGVhZGVyX3QgaGRyOw0KPiArICAgIHN0cnVjdCByeF90IHsNCj4g
KyAgICAgICAgaW50MzJfdCBzdGF0dXM7DQo+ICsgICAgICAgIHVpbnQzMl90IGF0dHJpYnV0ZXM7
DQo+ICsgICAgfSByeDsNCj4gKyAgICBzdHJ1Y3QgZHRfY2hhbm5lbF9hZGRyICplbnRyeTsNCj4g
KyAgICBzdHJ1Y3QgbGlzdF9oZWFkIGFkZHJfbGlzdDsNCj4gKw0KPiArICAgIHVpbnQzMl90IGZ1
bmNfaWQ7DQo+ICsNCj4gKyAgICBBU1NFUlQoc2NtaV9ub2RlICE9IE5VTEwpOw0KPiArDQo+ICsg
ICAgSU5JVF9MSVNUX0hFQUQoJnNjbWlfZGF0YS5jaGFubmVsX2xpc3QpOw0KPiArICAgIHNwaW5f
bG9ja19pbml0KCZzY21pX2RhdGEuY2hhbm5lbF9saXN0X2xvY2spOw0KPiArDQo+ICsgICAgaWYg
KCAhZHRfcHJvcGVydHlfcmVhZF91MzIoc2NtaV9ub2RlLCBTQ01JX1NNQ19JRCwgJmZ1bmNfaWQp
ICkNCj4gKyAgICB7DQo+ICsgICAgICAgIHByaW50ayhYRU5MT0dfRVJSICJzY21pOiBVbmFibGUg
dG8gcmVhZCBzbWMtaWQgZnJvbSBEVFxuIik7DQo+ICsgICAgICAgIHJldHVybiBmYWxzZTsNCj4g
KyAgICB9DQo+ICsNCj4gKyAgICByZXQgPSByZWFkX2h5cF9jaGFubmVsX2FkZHIoc2NtaV9ub2Rl
LCAmYWRkciwgJnNpemUpOw0KPiArICAgIGlmICggSVNfRVJSX1ZBTFVFKHJldCkgKQ0KPiArICAg
ICAgICByZXR1cm4gZmFsc2U7DQo+ICsNCj4gKyAgICBpZiAoICFJU19BTElHTkVEKHNpemUsIFND
TUlfU0hNRU1fTUFQUEVEX1NJWkUpICkNCj4gKyAgICB7DQo+ICsgICAgICAgIHByaW50ayhYRU5M
T0dfRVJSICJzY21pOiBSZXNlcnZlZCBtZW1vcnkgaXMgbm90IGFsaWduZWRcbiIpOw0KPiArICAg
ICAgICByZXR1cm4gZmFsc2U7DQo+ICsgICAgfQ0KPiArDQo+ICsgICAgSU5JVF9MSVNUX0hFQUQo
JmFkZHJfbGlzdCk7DQo+ICsNCj4gKyAgICByZXQgPSBnZXRfc2htZW1fcmVnaW9ucygmYWRkcl9s
aXN0LCBhZGRyKTsNCj4gKyAgICBpZiAoIElTX0VSUl9WQUxVRShyZXQpICkNCj4gKyAgICAgICAg
Z290byBvdXQ7DQo+ICsNCj4gKyAgICBjaGFubmVsID0gc21jX2NyZWF0ZV9jaGFubmVsKEhZUF9D
SEFOTkVMLCBmdW5jX2lkLCBhZGRyKTsNCj4gKyAgICBpZiAoIElTX0VSUihjaGFubmVsKSApDQo+
ICsgICAgICAgIGdvdG8gb3V0Ow0KPiArDQo+ICsgICAgcmV0ID0gbWFwX2NoYW5uZWxfbWVtb3J5
KGNoYW5uZWwpOw0KPiArICAgIGlmICggcmV0ICkNCj4gKyAgICAgICAgZ290byBvdXQ7DQo+ICsN
Cj4gKyAgICBzcGluX2xvY2soJnNjbWlfZGF0YS5jaGFubmVsX2xpc3RfbG9jayk7DQo+ICsgICAg
Y2hhbm5lbC0+ZG9tYWluX2lkID0gRE9NSURfWEVOOw0KPiArICAgIHNwaW5fdW5sb2NrKCZzY21p
X2RhdGEuY2hhbm5lbF9saXN0X2xvY2spOw0KPiArDQo+ICsgICAgaGRyLmlkID0gU0NNSV9CQVNF
X1BST1RPQ09MX0FUVElCVVRFUzsNCj4gKyAgICBoZHIudHlwZSA9IDA7DQo+ICsgICAgaGRyLnBy
b3RvY29sID0gU0NNSV9CQVNFX1BST1RPQ09MOw0KPiArDQo+ICsgICAgcmV0ID0gZG9fc21jX3hm
ZXIoY2hhbm5lbCwgJmhkciwgTlVMTCwgMCwgJnJ4LCBzaXplb2YocngpKTsNCj4gKyAgICBpZiAo
IHJldCApDQo+ICsgICAgICAgIGdvdG8gZXJyb3I7DQo+ICsNCj4gKyAgICByZXQgPSBjaGVja19z
Y21pX3N0YXR1cyhyeC5zdGF0dXMpOw0KPiArICAgIGlmICggcmV0ICkNCj4gKyAgICAgICAgZ290
byBlcnJvcjsNCj4gKw0KPiArICAgIG5fYWdlbnRzID0gRklFTERfR0VUKE1TR19OX0FHRU5UU19N
QVNLLCByeC5hdHRyaWJ1dGVzKTsNCj4gKyAgICBwcmludGsoWEVOTE9HX0RFQlVHICJzY21pOiBH
b3QgYWdlbnQgY291bnQgJWRcbiIsIG5fYWdlbnRzKTsNCj4gKw0KPiArICAgIGkgPSAxOw0KPiAr
ICAgIGxpc3RfZm9yX2VhY2hfZW50cnkoZW50cnksICZhZGRyX2xpc3QsIGxpc3QpDQo+ICsgICAg
ew0KPiArICAgICAgICB1aW50MzJfdCB0eF9hZ2VudF9pZCA9IDB4RkZGRkZGRkY7DQo+ICsgICAg
ICAgIHN0cnVjdCB7DQo+ICsgICAgICAgICAgICBpbnQzMl90IHN0YXR1czsNCj4gKyAgICAgICAg
ICAgIHVpbnQzMl90IGFnZW50X2lkOw0KPiArICAgICAgICAgICAgY2hhciBuYW1lWzE2XTsNCj4g
KyAgICAgICAgfSBkYV9yeDsNCj4gKw0KPiArICAgICAgICBhZ2VudF9jaGFubmVsID0gc21jX2Ny
ZWF0ZV9jaGFubmVsKGksIGZ1bmNfaWQsDQo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgZW50cnktPmFkZHIpOw0KPiArICAgICAgICBpZiAoIElTX0VSUihhZ2Vu
dF9jaGFubmVsKSApDQo+ICsgICAgICAgIHsNCj4gKyAgICAgICAgICAgIHJldCA9IFBUUl9FUlIo
YWdlbnRfY2hhbm5lbCk7DQo+ICsgICAgICAgICAgICBnb3RvIGVycm9yOw0KPiArICAgICAgICB9
DQo+ICsNCj4gKyAgICAgICAgcmV0ID0gbWFwX2NoYW5uZWxfbWVtb3J5KGFnZW50X2NoYW5uZWwp
Ow0KPiArICAgICAgICBpZiAoIHJldCApDQo+ICsgICAgICAgICAgICBnb3RvIGVycm9yOw0KPiAr
DQo+ICsgICAgICAgIGhkci5pZCA9IFNDTUlfQkFTRV9ESVNDT1ZFUl9BR0VOVDsNCj4gKyAgICAg
ICAgaGRyLnR5cGUgPSAwOw0KPiArICAgICAgICBoZHIucHJvdG9jb2wgPSBTQ01JX0JBU0VfUFJP
VE9DT0w7DQo+ICsNCj4gKyAgICAgICAgcmV0ID0gZG9fc21jX3hmZXIoYWdlbnRfY2hhbm5lbCwg
JmhkciwgJnR4X2FnZW50X2lkLA0KPiArICAgICAgICAgICAgICAgICAgICAgICAgICBzaXplb2Yo
dHhfYWdlbnRfaWQpLCAmZGFfcngsIHNpemVvZihkYV9yeCkpOw0KPiArICAgICAgICBpZiAoIHJl
dCApDQo+ICsgICAgICAgIHsNCj4gKyAgICAgICAgICAgIHVubWFwX2NoYW5uZWxfbWVtb3J5KGFn
ZW50X2NoYW5uZWwpOw0KPiArICAgICAgICAgICAgZ290byBlcnJvcjsNCj4gKyAgICAgICAgfQ0K
PiArDQo+ICsgICAgICAgIHVubWFwX2NoYW5uZWxfbWVtb3J5KGFnZW50X2NoYW5uZWwpOw0KPiAr
DQo+ICsgICAgICAgIHJldCA9IGNoZWNrX3NjbWlfc3RhdHVzKGRhX3J4LnN0YXR1cyk7DQo+ICsg
ICAgICAgIGlmICggcmV0ICkNCj4gKyAgICAgICAgICAgIGdvdG8gZXJyb3I7DQo+ICsNCj4gKyAg
ICAgICAgcHJpbnRrKFhFTkxPR19ERUJVRyAic2NtaTogc3RhdHVzPTB4JXggaWQ9MHgleCBuYW1l
PSVzXG4iLA0KPiArICAgICAgICAgICAgICAgIGRhX3J4LnN0YXR1cywgZGFfcnguYWdlbnRfaWQs
IGRhX3J4Lm5hbWUpOw0KPiArDQo+ICsgICAgICAgIGFnZW50X2NoYW5uZWwtPmFnZW50X2lkID0g
ZGFfcnguYWdlbnRfaWQ7DQo+ICsNCj4gKyAgICAgICAgaWYgKCBpID09IG5fYWdlbnRzICkNCj4g
KyAgICAgICAgICAgIGJyZWFrOw0KPiArDQo+ICsgICAgICAgIGkrKzsNCj4gKyAgICB9DQo+ICsN
Cj4gKyAgICBzY21pX2RhdGEuaW5pdGlhbGl6ZWQgPSB0cnVlOw0KPiArICAgIGdvdG8gb3V0Ow0K
PiArDQo+ICtlcnJvcjoNCj4gKyAgICB1bm1hcF9jaGFubmVsX21lbW9yeShjaGFubmVsKTsNCj4g
KyAgICBmcmVlX2NoYW5uZWxfbGlzdCgpOw0KPiArb3V0Og0KPiArICAgIGZyZWVfc2htZW1fcmVn
aW9ucygmYWRkcl9saXN0KTsNCj4gKyAgICByZXR1cm4gcmV0ID09IDA7DQo+ICt9DQo+ICsNCj4g
K3N0YXRpYyBpbnQgc2NtaV9kb21haW5faW5pdChzdHJ1Y3QgZG9tYWluICpkLA0KPiArICAgICAg
ICAgICAgICAgICAgICAgICAgICAgc3RydWN0IHhlbl9hcmNoX2RvbWFpbmNvbmZpZyAqY29uZmln
KQ0KPiArew0KPiArICAgIHN0cnVjdCBzY21pX2NoYW5uZWwgKmNoYW5uZWw7DQo+ICsgICAgaW50
IHJldDsNCj4gKw0KPiArICAgIGlmICggIXNjbWlfZGF0YS5pbml0aWFsaXplZCApDQo+ICsgICAg
ICAgIHJldHVybiAwOw0KPiArDQo+ICsgICAgcHJpbnRrKFhFTkxPR19JTkZPICJzY21pOiBkb21h
aW5faWQgPSAlZFxuIiwgZC0+ZG9tYWluX2lkKTsNCj4gKw0KPiArICAgIGNoYW5uZWwgPSBhcXVp
cmVfc2NtaV9jaGFubmVsKGQtPmRvbWFpbl9pZCk7DQo+ICsgICAgaWYgKCBJU19FUlJfT1JfTlVM
TChjaGFubmVsKSApDQo+ICsgICAgICAgIHJldHVybiAtRU5PRU5UOw0KPiArDQo+ICsjaWZkZWYg
Q09ORklHX0FSTV8zMg0KPiArICAgIHByaW50ayhYRU5MT0dfSU5GTw0KPiArICAgICAgICAgICAi
c2NtaTogQXF1aXJlIFNDTUkgY2hhbm5lbCBpZCA9IDB4JXggLCBkb21haW5faWQgPSAlZCBwYWRk
ciA9IDB4JWxseFxuIiwNCj4gKyAgICAgICAgICAgY2hhbm5lbC0+Y2hhbl9pZCwgY2hhbm5lbC0+
ZG9tYWluX2lkLCBjaGFubmVsLT5wYWRkcik7DQo+ICsjZWxzZQ0KPiArICAgIHByaW50ayhYRU5M
T0dfSU5GTw0KPiArICAgICAgICAgICAic2NtaTogQXF1aXJlIFNDTUkgY2hhbm5lbCBpZCA9IDB4
JXggLCBkb21haW5faWQgPSAlZCBwYWRkciA9IDB4JWx4XG4iLA0KPiArICAgICAgICAgICBjaGFu
bmVsLT5jaGFuX2lkLCBjaGFubmVsLT5kb21haW5faWQsIGNoYW5uZWwtPnBhZGRyKTsNCj4gKyNl
bmRpZg0KPiArDQo+ICsgICAgaWYgKCBpc19oYXJkd2FyZV9kb21haW4oZCkgKQ0KPiArICAgIHsN
Cj4gKyAgICAgICAgcmV0ID0gbWVtX3Blcm1pdF9hY2Nlc3MoZCwgY2hhbm5lbC0+cGFkZHIsIFBB
R0VfU0laRSk7DQo+ICsgICAgICAgIGlmICggSVNfRVJSX1ZBTFVFKHJldCkgKQ0KPiArICAgICAg
ICAgICAgZ290byBlcnJvcjsNCj4gKw0KPiArICAgICAgICByZXQgPSBkdF91cGRhdGVfZG9tYWlu
X3JhbmdlKGNoYW5uZWwtPnBhZGRyLCBQQUdFX1NJWkUpOw0KPiArICAgICAgICBpZiAoIElTX0VS
Ul9WQUxVRShyZXQpICkNCj4gKyAgICAgICAgew0KPiArICAgICAgICAgICAgaW50IHJjID0gbWVt
X2RlbnlfYWNjZXNzKGQsIGNoYW5uZWwtPnBhZGRyLCBQQUdFX1NJWkUpOw0KPiArICAgICAgICAg
ICAgaWYgKCByYyApDQo+ICsgICAgICAgICAgICAgICAgcHJpbnRrKFhFTkxPR19FUlIgIlVuYWJs
ZSB0byBtZW1fZGVueV9hY2Nlc3NcbiIpOw0KPiArDQo+ICsgICAgICAgICAgICBnb3RvIGVycm9y
Ow0KPiArICAgICAgICB9DQo+ICsgICAgfQ0KPiArDQo+ICsgICAgZC0+YXJjaC5zY2kgPSBjaGFu
bmVsOw0KPiArICAgIGlmICggY29uZmlnICkNCj4gKyAgICAgICAgY29uZmlnLT5hcm1fc2NpX2Fn
ZW50X3BhZGRyID0gY2hhbm5lbC0+cGFkZHI7DQo+ICsNCj4gKyAgICByZXR1cm4gMDsNCj4gK2Vy
cm9yOg0KPiArICAgIHJlbGlucXVpc2hfc2NtaV9jaGFubmVsKGNoYW5uZWwpOw0KPiArDQo+ICsg
ICAgcmV0dXJuIHJldDsNCj4gK30NCj4gKw0KPiArc3RhdGljIGludCBzY21pX2FkZF9kZXZpY2Vf
YnlfZGV2aWQoc3RydWN0IGRvbWFpbiAqZCwgdWludDMyX3Qgc2NtaV9kZXZpZCkNCj4gK3sNCj4g
KyAgICBzdHJ1Y3Qgc2NtaV9jaGFubmVsICpjaGFubmVsLCAqYWdlbnRfY2hhbm5lbDsNCj4gKyAg
ICBzY21pX21zZ19oZWFkZXJfdCBoZHI7DQo+ICsgICAgc3RydWN0IHNjbWlfcGVybXNfdHggew0K
PiArICAgICAgICB1aW50MzJfdCBhZ2VudF9pZDsNCj4gKyAgICAgICAgdWludDMyX3QgZGV2aWNl
X2lkOw0KPiArICAgICAgICB1aW50MzJfdCBmbGFnczsNCj4gKyAgICB9IHR4Ow0KPiArICAgIHN0
cnVjdCByeF90IHsNCj4gKyAgICAgICAgaW50MzJfdCBzdGF0dXM7DQo+ICsgICAgICAgIHVpbnQz
Ml90IGF0dHJpYnV0ZXM7DQo+ICsgICAgfSByeDsNCj4gKyAgICBpbnQgcmV0Ow0KPiArDQo+ICsg
ICAgaWYgKCAhc2NtaV9kYXRhLmluaXRpYWxpemVkICkNCj4gKyAgICAgICAgcmV0dXJuIDA7DQo+
ICsNCj4gKyAgICBwcmludGsoWEVOTE9HX0RFQlVHICJzY21pOiBzY21pX2RldmlkID0gJWRcbiIs
IHNjbWlfZGV2aWQpOw0KPiArDQo+ICsgICAgYWdlbnRfY2hhbm5lbCA9IGQtPmFyY2guc2NpOw0K
PiArICAgIGlmICggSVNfRVJSX09SX05VTEwoYWdlbnRfY2hhbm5lbCkgKQ0KPiArICAgICAgICBy
ZXR1cm4gUFRSX0VSUihhZ2VudF9jaGFubmVsKTsNCj4gKw0KPiArICAgIGNoYW5uZWwgPSBnZXRf
Y2hhbm5lbF9ieV9pZChIWVBfQ0hBTk5FTCk7DQo+ICsgICAgaWYgKCBJU19FUlJfT1JfTlVMTChj
aGFubmVsKSApDQo+ICsgICAgICAgIHJldHVybiBQVFJfRVJSKGNoYW5uZWwpOw0KPiArDQo+ICsg
ICAgaGRyLmlkID0gU0NNSV9CQVNFX1NFVF9ERVZJQ0VfUEVSTUlTU0lPTlM7DQo+ICsgICAgaGRy
LnR5cGUgPSAwOw0KPiArICAgIGhkci5wcm90b2NvbCA9IFNDTUlfQkFTRV9QUk9UT0NPTDsNCj4g
Kw0KPiArICAgIHR4LmFnZW50X2lkID0gYWdlbnRfY2hhbm5lbC0+YWdlbnRfaWQ7DQo+ICsgICAg
dHguZGV2aWNlX2lkID0gc2NtaV9kZXZpZDsNCj4gKyAgICB0eC5mbGFncyA9IFNDTUlfQUxMT1df
QUNDRVNTOw0KPiArDQo+ICsgICAgcmV0ID0gZG9fc21jX3hmZXIoY2hhbm5lbCwgJmhkciwgJnR4
LCBzaXplb2YodHgpLCAmcngsIHNpemVvZigmcngpKTsNCj4gKyAgICBpZiAoIElTX0VSUl9WQUxV
RShyZXQpICkNCj4gKyAgICAgICAgcmV0dXJuIHJldDsNCj4gKw0KPiArICAgIHJldCA9IGNoZWNr
X3NjbWlfc3RhdHVzKHJ4LnN0YXR1cyk7DQo+ICsgICAgaWYgKCBJU19FUlJfVkFMVUUocmV0KSAp
DQo+ICsgICAgICAgIHJldHVybiByZXQ7DQo+ICsNCj4gKyAgICByZXR1cm4gMDsNCj4gK30NCj4g
Kw0KPiArc3RhdGljIGludCBzY21pX2FkZF9kdF9kZXZpY2Uoc3RydWN0IGRvbWFpbiAqZCwgc3Ry
dWN0IGR0X2RldmljZV9ub2RlICpkZXYpDQo+ICt7DQo+ICsgICAgdWludDMyX3Qgc2NtaV9kZXZp
ZDsNCj4gKw0KPiArICAgIGlmICggKCFzY21pX2RhdGEuaW5pdGlhbGl6ZWQpIHx8ICghZC0+YXJj
aC5zY2kpICkNCj4gKyAgICAgICAgcmV0dXJuIDA7DQo+ICsNCj4gKyAgICBpZiAoICFkdF9wcm9w
ZXJ0eV9yZWFkX3UzMihkZXYsICJzY21pX2RldmlkIiwgJnNjbWlfZGV2aWQpICkNCj4gKyAgICAg
ICAgcmV0dXJuIDA7DQo+ICsNCj4gKyAgICBwcmludGsoWEVOTE9HX0lORk8gInNjbWk6IGR0X25v
ZGUgPSAlc1xuIiwgZHRfbm9kZV9mdWxsX25hbWUoZGV2KSk7DQo+ICsNCj4gKyAgICByZXR1cm4g
c2NtaV9hZGRfZGV2aWNlX2J5X2RldmlkKGQsIHNjbWlfZGV2aWQpOw0KPiArfQ0KPiArDQo+ICtz
dGF0aWMgaW50IHNjbWlfcmVsaW5xdWlzaF9yZXNvdXJjZXMoc3RydWN0IGRvbWFpbiAqZCkNCj4g
K3sNCj4gKyAgICBpbnQgcmV0Ow0KPiArICAgIHN0cnVjdCBzY21pX2NoYW5uZWwgKmNoYW5uZWws
ICphZ2VudF9jaGFubmVsOw0KPiArICAgIHNjbWlfbXNnX2hlYWRlcl90IGhkcjsNCj4gKyAgICBz
dHJ1Y3QgcmVzZXRfYWdlbnRfdHggew0KPiArICAgICAgICB1aW50MzJfdCBhZ2VudF9pZDsNCj4g
KyAgICAgICAgdWludDMyX3QgZmxhZ3M7DQo+ICsgICAgfSB0eDsNCj4gKyAgICB1aW50MzJfdCBy
eDsNCj4gKw0KPiArICAgIGlmICggIWQtPmFyY2guc2NpICkNCj4gKyAgICAgICAgcmV0dXJuIDA7
DQo+ICsNCj4gKyAgICBhZ2VudF9jaGFubmVsID0gZC0+YXJjaC5zY2k7DQo+ICsNCj4gKyAgICBz
cGluX2xvY2soJmFnZW50X2NoYW5uZWwtPmxvY2spOw0KPiArICAgIHR4LmFnZW50X2lkID0gYWdl
bnRfY2hhbm5lbC0+YWdlbnRfaWQ7DQo+ICsgICAgc3Bpbl91bmxvY2soJmFnZW50X2NoYW5uZWwt
PmxvY2spOw0KPiArDQo+ICsgICAgY2hhbm5lbCA9IGdldF9jaGFubmVsX2J5X2lkKEhZUF9DSEFO
TkVMKTsNCj4gKyAgICBpZiAoICFjaGFubmVsICkNCj4gKyAgICB7DQo+ICsgICAgICAgIHByaW50
ayhYRU5MT0dfRVJSDQo+ICsgICAgICAgICAgICAgICAic2NtaTogVW5hYmxlIHRvIGdldCBIeXBl
cnZpc29yIHNjbWkgY2hhbm5lbCBmb3IgZG9tYWluICVkXG4iLA0KPiArICAgICAgICAgICAgICAg
ZC0+ZG9tYWluX2lkKTsNCj4gKyAgICAgICAgcmV0dXJuIC1FSU5WQUw7DQo+ICsgICAgfQ0KPiAr
DQo+ICsgICAgaGRyLmlkID0gU0NNSV9CQVNFX1JFU0VUX0FHRU5UX0NPTkZJR1VSQVRJT047DQo+
ICsgICAgaGRyLnR5cGUgPSAwOw0KPiArICAgIGhkci5wcm90b2NvbCA9IFNDTUlfQkFTRV9QUk9U
T0NPTDsNCj4gKw0KPiArICAgIHR4LmZsYWdzID0gMDsNCj4gKw0KPiArICAgIHJldCA9IGRvX3Nt
Y194ZmVyKGNoYW5uZWwsICZoZHIsICZ0eCwgc2l6ZW9mKHR4KSwgJnJ4LCBzaXplb2YocngpKTsN
Cj4gKyAgICBpZiAoIHJldCApDQo+ICsgICAgICAgIHJldHVybiByZXQ7DQo+ICsNCj4gKyAgICBy
ZXQgPSBjaGVja19zY21pX3N0YXR1cyhyeCk7DQo+ICsNCj4gKyAgICByZXR1cm4gcmV0Ow0KPiAr
fQ0KPiArDQo+ICtzdGF0aWMgdm9pZCBzY21pX2RvbWFpbl9kZXN0cm95KHN0cnVjdCBkb21haW4g
KmQpDQo+ICt7DQo+ICsgICAgc3RydWN0IHNjbWlfY2hhbm5lbCAqY2hhbm5lbDsNCj4gKw0KPiAr
ICAgIGlmICggIWQtPmFyY2guc2NpICkNCj4gKyAgICAgICAgcmV0dXJuOw0KPiArDQo+ICsgICAg
Y2hhbm5lbCA9IGQtPmFyY2guc2NpOw0KPiArICAgIHNwaW5fbG9jaygmY2hhbm5lbC0+bG9jayk7
DQo+ICsNCj4gKyAgICByZWxpbnF1aXNoX3NjbWlfY2hhbm5lbChjaGFubmVsKTsNCj4gKyAgICBw
cmludGsoWEVOTE9HX0RFQlVHICJzY21pOiBGcmVlIGRvbWFpbiAlZFxuIiwgZC0+ZG9tYWluX2lk
KTsNCj4gKw0KPiArICAgIGQtPmFyY2guc2NpID0gTlVMTDsNCj4gKw0KPiArICAgIG1lbV9kZW55
X2FjY2VzcyhkLCBjaGFubmVsLT5wYWRkciwgUEFHRV9TSVpFKTsNCj4gKyAgICBzcGluX3VubG9j
aygmY2hhbm5lbC0+bG9jayk7DQo+ICt9DQo+ICsNCj4gK3N0YXRpYyBib29sIHNjbWlfaGFuZGxl
X2NhbGwoc3RydWN0IGRvbWFpbiAqZCwgdm9pZCAqYXJncykNCj4gK3sNCj4gKyAgICBib29sIHJl
cyA9IGZhbHNlOw0KPiArICAgIHN0cnVjdCBzY21pX2NoYW5uZWwgKmFnZW50X2NoYW5uZWw7DQo+
ICsgICAgc3RydWN0IGFybV9zbWNjY19yZXMgcmVzcDsNCj4gKyAgICBzdHJ1Y3QgY3B1X3VzZXJf
cmVncyAqcmVncyA9IGFyZ3M7DQo+ICsNCj4gKyAgICBpZiAoICFkLT5hcmNoLnNjaSApDQo+ICsg
ICAgICAgIHJldHVybiBmYWxzZTsNCj4gKw0KPiArICAgIGFnZW50X2NoYW5uZWwgPSBkLT5hcmNo
LnNjaTsNCj4gKyAgICBzcGluX2xvY2soJmFnZW50X2NoYW5uZWwtPmxvY2spOw0KPiArDQo+ICsg
ICAgaWYgKCBhZ2VudF9jaGFubmVsLT5mdW5jX2lkICE9IHJlZ3MtPnIwICkNCj4gKyAgICB7DQo+
ICsgICAgICAgIHJlcyA9IGZhbHNlOw0KPiArICAgICAgICBnb3RvIHVubG9jazsNCj4gKyAgICB9
DQo+ICsNCj4gKyAgICBhcm1fc21jY2Nfc21jKGFnZW50X2NoYW5uZWwtPmZ1bmNfaWQsIDAsIDAs
IDAsIDAsIDAsIDAsDQo+ICsgICAgICAgICAgICAgICAgICBhZ2VudF9jaGFubmVsLT5jaGFuX2lk
LCAmcmVzcCk7DQo+ICsNCj4gKyAgICBzZXRfdXNlcl9yZWcocmVncywgMCwgcmVzcC5hMCk7DQo+
ICsgICAgc2V0X3VzZXJfcmVnKHJlZ3MsIDEsIHJlc3AuYTEpOw0KPiArICAgIHNldF91c2VyX3Jl
ZyhyZWdzLCAyLCByZXNwLmEyKTsNCj4gKyAgICBzZXRfdXNlcl9yZWcocmVncywgMywgcmVzcC5h
Myk7DQo+ICsgICAgcmVzID0gdHJ1ZTsNCj4gK3VubG9jazoNCj4gKyAgICBzcGluX3VubG9jaygm
YWdlbnRfY2hhbm5lbC0+bG9jayk7DQo+ICsNCj4gKyAgICByZXR1cm4gcmVzOw0KPiArfQ0KPiAr
DQo+ICtzdGF0aWMgY29uc3Qgc3RydWN0IGR0X2RldmljZV9tYXRjaCBzY21pX3NtY19tYXRjaFtd
IF9faW5pdGNvbnN0ID0NCj4gK3sNCj4gKyAgICBEVF9NQVRDSF9TQ01JX1NNQywNCj4gKyAgICB7
IC8qIHNlbnRpbmVsICovIH0sDQo+ICt9Ow0KPiArDQo+ICtzdGF0aWMgY29uc3Qgc3RydWN0IHNj
aV9tZWRpYXRvcl9vcHMgc2NtaV9vcHMgPQ0KPiArew0KPiArICAgIC5wcm9iZSA9IHNjbWlfcHJv
YmUsDQo+ICsgICAgLmRvbWFpbl9pbml0ID0gc2NtaV9kb21haW5faW5pdCwNCj4gKyAgICAuZG9t
YWluX2Rlc3Ryb3kgPSBzY21pX2RvbWFpbl9kZXN0cm95LA0KPiArICAgIC5hZGRfZHRfZGV2aWNl
ID0gc2NtaV9hZGRfZHRfZGV2aWNlLA0KPiArICAgIC5yZWxpbnF1aXNoX3Jlc291cmNlcyA9IHNj
bWlfcmVsaW5xdWlzaF9yZXNvdXJjZXMsDQo+ICsgICAgLmhhbmRsZV9jYWxsID0gc2NtaV9oYW5k
bGVfY2FsbCwNCj4gK307DQo+ICsNCj4gK1JFR0lTVEVSX1NDSV9NRURJQVRPUihzY21pX3NtYywg
IlNDTUktU01DIiwgWEVOX0RPTUNUTF9DT05GSUdfQVJNX1NDSV9TQ01JX1NNQywNCj4gKyAgICAg
ICAgICAgICAgICAgICAgICBzY21pX3NtY19tYXRjaCwgJnNjbWlfb3BzKTsNCj4gKw0KPiArLyoN
Cj4gKyAqIExvY2FsIHZhcmlhYmxlczoNCj4gKyAqIG1vZGU6IEMNCj4gKyAqIGMtZmlsZS1zdHls
ZTogIkJTRCINCj4gKyAqIGMtYmFzaWMtb2Zmc2V0OiA0DQo+ICsgKiBpbmRlbnQtdGFicy1tb2Rl
OiBuaWwNCj4gKyAqIEVuZDoNCj4gKyAqLw0KPiAtLSANCj4gMi4yNy4wDQoNCg==


From xen-devel-bounces@lists.xenproject.org Fri Feb 11 08:47:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 08:47:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270239.464455 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIRaB-0002Zj-PF; Fri, 11 Feb 2022 08:47:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270239.464455; Fri, 11 Feb 2022 08:47:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIRaB-0002Zc-LT; Fri, 11 Feb 2022 08:47:11 +0000
Received: by outflank-mailman (input) for mailman id 270239;
 Fri, 11 Feb 2022 08:47:10 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=XOdK=S2=epam.com=prvs=4041dc41fc=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nIRaA-0002Sr-Br
 for xen-devel@lists.xenproject.org; Fri, 11 Feb 2022 08:47:10 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 316654c5-8b17-11ec-8eb8-a37418f5ba1a;
 Fri, 11 Feb 2022 09:47:08 +0100 (CET)
Received: from pps.filterd (m0174683.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 21B8gP8d012181;
 Fri, 11 Feb 2022 08:47:03 GMT
Received: from eur01-ve1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2050.outbound.protection.outlook.com [104.47.1.50])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3e5krx886g-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 11 Feb 2022 08:47:03 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM6PR03MB4709.eurprd03.prod.outlook.com (2603:10a6:20b:e::26) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.12; Fri, 11 Feb
 2022 08:46:59 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::fc4d:4749:5d1:eb73]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::fc4d:4749:5d1:eb73%4]) with mapi id 15.20.4975.015; Fri, 11 Feb 2022
 08:46:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 316654c5-8b17-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=PwjEsBHv2ZQmmPTTpZ4kLZbmP3e5L2TIZIppjgePbL2+POe43OfVifDBBJCYF2FhvWSue3eSEao7TfPF6vkrfNrK+R+FS6FKYXtQqiJ2NG2GfRpN5Dx9aoEFjDK2BsS5hhi5u2MJ38kPq0ETdI6DlnnJaUjCdLv8GSA5IyKCO4cArt4vmuZJ3x9siLeAKIBFRcC/IobswpQsHe6cbGkmkfbwyZDkyyTt5AraZolbmRwkbExOqOPh0Q72TN32BELkzCCXUj1QRYSWznyEVIaQ9uB1TNQgu3lDNcjyj+d6esJTgczeUksfnkbICBp5fuzRCLNUKcFNtomeJdyhCttUog==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=yeuJjIm0ppIE4mbB5Upuc8Cu1bqR0aTx12VuRlgGjBw=;
 b=mhg1lGSsmVQLu+tMq/SbhcebpM5K3Lcaa/REQfCyIPyjbXnHi9/hJcavprKBcdUkXfvXpwrDZXt0q35MJUla9MpJp8l9Vd1YbcuqA0BoFRo3vA1g28EwjEqLxbjQoIKLTLnJKi4DAzmjk8Uf5XxHJtyLeGmScm55jLooahhe6rCTaDFXaULHkPEN5yTFZ40Ow7+Z+iq4SA/5Nn4qm4AsoDPjq/OCkHz+hM/BuINes3dWIdDawAc2AdoKFAlbCkGrYcXyFONXS/BgmaKLTmPVAItaLvOg6O3bXP0Gm0qlIdg1kyIPov80uYQwqZao3ly3l56ZO1eah1qR6b2nuljjsw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=yeuJjIm0ppIE4mbB5Upuc8Cu1bqR0aTx12VuRlgGjBw=;
 b=doKot9rhQH93GgK8Y0SPwoxRbbx1yUCJfBurcFVctuWGJO21+n/CspweYGMwABNm86sCicxOLUBzYOfOt1usbCghRwfGMylxRUZkc9Q+kizxhkayBz2ysWDuylPrX1JwcORjAIC2aJjOPQYsmaarYvHBZv1YiJvNX2LK/PKkOsjbMDd/ayaabgtC1btFOvy0S89a1ZPgZiWEUsESjldu+BIXwEdko7SxsdjFlEAA0v1U07NYEy/sseuMyn/fJIVimgqvz4FC4nSweegkQJAUTz2cvnT77WbQfs87KB+ORyjkLSSsgmFUapUSy1uBdXYoe2YCJZKkfSz+JUyJdrlayg==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "jbeulich@suse.com" <jbeulich@suse.com>,
        "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org" <sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH] vpci: introduce per-domain lock to protect vpci structure
Thread-Topic: [PATCH] vpci: introduce per-domain lock to protect vpci
 structure
Thread-Index: AQHYHboQT3cBWYI1/EGunE7hOwop6ayM95MAgAEU1AA=
Date: Fri, 11 Feb 2022 08:46:59 +0000
Message-ID: <878371dd-4269-6e44-4e73-344a74a04a84@epam.com>
References: <20220209133627.959649-1-andr2000@gmail.com>
 <YgU6Snk8GTytJXZp@Air-de-Roger>
In-Reply-To: <YgU6Snk8GTytJXZp@Air-de-Roger>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 8be8efcb-81fa-4e46-6a96-08d9ed3b111c
x-ms-traffictypediagnostic: AM6PR03MB4709:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM6PR03MB4709116243DAC91347927A2EE7309@AM6PR03MB4709.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 vLEYTj4/yrqfYl7BsCHpYv1WF3tUpnFW3EDWt7zxqwPFLq3cEFGtr02+XtlcSJlUAAqzC4QdK93d8KKHRZoxEFMb/EXQfE07tFziaS4nYas5oMv2TugPNjNXa0+PvthpuCNIIgGcV6VLHA1XpHvtctVOrZFyNqpCDG6Tnp3r4kBthQ/INwjAFO7D87FsYskFoA4qEfkuDgTUU94taGJKeeWWBitx6y3QKe5Q9KMb6jsIIp4Nn5tJYvmy7CTMYQtoOlUoq9+++nX/XJOipkFDyssD9Vp4g8d+f31oRdjfVZD01vO8M9ZRuksVcizw/88Bry/rpoLpiO7I8G6MA3ptZmzLizUKpjtaSv0CngUZ7+DfyGB3+5g+Ib6oZ639uXTFnMzW5x49e6DkA4MyvaXGd92Z/BSM1OMdwtaflyAo1IqyGkuiRuRcS99fJoxmglZxpn6ASXsSDDl818KyaHMZf3hbKUs83Ro/4NbXNMk4skh7CRJjzF5/dl+70gCMgHWlBxdWpW+NHJaQdDI1I1N7o0IixXiglLvo3ShyyaGdGy5a4JhRzkxtZdQvKpKvxtMnFuRrqasZZoKzW2yVDGpa3MFK6BVsWpQ5natUwFdMQBCwk72uY5fjPBNIJfFXhGUSxrZJ0V1C7wXZGjixUwLDmKWAcIM7j5ZrPEArZjV9pXc1Pvvt8AkAfhndiMHR4aXxe8BzkTKNX/pJV6AYamIu3CFwroAJhs2RjJbrH6+B+jhA41HkVDi0PkSOSwWCkvXV
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(36756003)(8936002)(6512007)(83380400001)(2616005)(107886003)(31686004)(186003)(26005)(2906002)(6506007)(316002)(38070700005)(8676002)(71200400001)(53546011)(55236004)(508600001)(86362001)(6486002)(122000001)(91956017)(54906003)(5660300002)(31696002)(4326008)(38100700002)(66476007)(66446008)(64756008)(6916009)(66946007)(76116006)(66556008)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?ditvMSttVUNGTWZncVdKbitaRjRpUHRZT0RMZUUvWHAyaFg2ald4YjUzM29p?=
 =?utf-8?B?cVJVelRQOXhqd0ltUS9QZ1loWVBtNXd6dXZmRDZ1dExIbFJndnVUd2w1a0Yz?=
 =?utf-8?B?Z1pPcGdwdUhEc0lYZDc5VDdiT0JMVk5uRTVsWjlyYXNOUDBpRW9CWjVTQk9W?=
 =?utf-8?B?dm56cnFLWUhWd3ZTNklLcWo5aU92bk1QRm5yUGtZWkR0TngzUFpVdGxoMWRY?=
 =?utf-8?B?YmUwNG5XajV6YjAyUWpOaXhXQ1BSRTVObU0xUU9ua2wxQ0lyS3FsQ3YrMjBr?=
 =?utf-8?B?cjhqdW05RER6Mnp4S2VqU085dGUxaVdQa01LeVZ0d08zNzFMa2Z3b0czcWZk?=
 =?utf-8?B?L0RSK2lWdnpTUXBOc3lVY1BBanEvWHVaNkJNWHh5Smo2QThZV1ZYRkVHbnJh?=
 =?utf-8?B?Um50Njh1anZZcmFzRmUwWVU3YTA4RGx1dzJXUDg4RDFWUzJtU1JTSkxqbEJV?=
 =?utf-8?B?dkxzY3pRdjZOMVRSZ0VCN0tCckNaZWRVQnlOdjc2RXBadWdCMEwvR2NFaW1k?=
 =?utf-8?B?OHk5cjEydFlGMGxHRjFJbHhrU1Z6T1ZUZVY3NTRNVlUzZ2w2RnNnSUVsNE8z?=
 =?utf-8?B?ZTBNeU5rZVp0RCtxZ0RNZ2R2UXlSMEFWaVRMZHMyYmVLUXh1R2VKTTE1ZkVL?=
 =?utf-8?B?VGxoRXpKS0xwM0lEcUxGQ2d4dWlwZXV1Q0M2SGZjVlU1NkFVWnpCa0ZyQWpw?=
 =?utf-8?B?UXJYV256SmltaTNaRHF0anNJcDV4KzlQQVFoTHFIWnhzaTZvdjlFSUtvOEFW?=
 =?utf-8?B?OTBKRVVyQUlGc2NJMXl5eGhkeW9OdVRuVElHTjdoMHhUcjBCOGV1N3daSmdS?=
 =?utf-8?B?SDYyNkZaTVNYMm8yamE4cldYbGFVRUF1ejJUclJkakJUbjNuOUdMUGQ2SGpD?=
 =?utf-8?B?dmUyUTcwL1V6Y0oxdHZlbmVSUVdQMldVelBEUFBQSHVkS2taTVFnNHA3amts?=
 =?utf-8?B?TGVxdThIS0ZWZ0VqMXJyRlVtUUxjd0xoUWFML25JcWV6YnRlUnM2NEQ1Smlv?=
 =?utf-8?B?OU82ZzBucVFvZzBoNnRhVjYrL0I0S0R0YzF2eUNlK01EdTJraVZSZ0MramJv?=
 =?utf-8?B?UnFIQkZRcHBTLzk0b2w3enR5T0M5QWMrMmlNdnFzYlZ6RXhRNU1Cb09sZGhs?=
 =?utf-8?B?MFRoZzZSOSs5WGhDTEk1bjlmeHY0NWJGS3F0M0dlUXFDcW9GeFJhVW9tQm5Q?=
 =?utf-8?B?Y0ZieUJ1VVJDUDIzREhHdkVGWStyZUk2Y3dWSkZUY2lRb1A3VU5nM0NiVkJ4?=
 =?utf-8?B?Wk5ELzl1MUdrUHI3YVUzbGJ2cDlJUW5idVlCUkprZWsyclBCR0YvSURBcUQz?=
 =?utf-8?B?ajErL01EaC9qTlVaVmxSdm1VR2twUENXdE5KOWd6b0VJL0twa2h0REc5alFG?=
 =?utf-8?B?WGZlN2JycTk2bnNUeU9PcVVWZjd0OFdPZ2k5LzU3OHQwZ3JhRWxvV3BxKzFF?=
 =?utf-8?B?OS8xeEtlbjY3NHNJK3N0V1FKZ0QvaWJaN1F3Q3c2U1BJYk9yWXhNd1BWU3ZN?=
 =?utf-8?B?cUJYUmdJNmhaZDQvSDJWVGF4QzVxYS9QdFV5VnRuTkloYi84SXN0NnVLb3F4?=
 =?utf-8?B?WWNOMjBBaTBVNzk1bzYvbWJIRUJaUThmRVUrK1NweTE0SlJ1dTNkRnlZT0Zq?=
 =?utf-8?B?Ny80OUViZHJlN0hYenVXSFgwQjAvdXVIc0VQU3k0d1hvU2dVOEw3NHJIUU5y?=
 =?utf-8?B?RG9Tdm9DbHRvUDFzdnBVWTFxYWd6YzRrMWl0cllENDRMNkpsSnRHd0haZ1Qv?=
 =?utf-8?B?bmRhUjdTTUpYY1JsUWtXWXNHc3dwenBmUHhJOTZhWGQxYkVKQXd5VjJiMEtR?=
 =?utf-8?B?OUZyNndyQ0Y3R3BuV1libmdNMUF5OE8xN2tFZXRINGhrdkMyK0lyemZUMkxM?=
 =?utf-8?B?MWt0bU96Wi9zTy9DV0wrUTJ5OUtKZ3k2NUZ2bjN3V0VmYkd4bDlWbXNQeHpZ?=
 =?utf-8?B?cjk2ckowMUlwY3BTS25IVHliY2djVGZITmhZTWIvMEppdklQNlI3TVZkaHFt?=
 =?utf-8?B?cy9jbmJMT1QrOVBxemJsdXFaVzA1ZXRUV3ZHc3dUdjlwNUx4VWI0OTVLTzBZ?=
 =?utf-8?B?emNYUEttcHdVdkViWEJ5d1hQYTFWU2ZGQzZ1V3d4MHpnQlJXSlZKeloyYith?=
 =?utf-8?B?NE5aUHU5cXdhQmlsZll1VnA2Qk1tbXMvYm9ZTThYbFRiZ2dkNVNGSU9TZUda?=
 =?utf-8?B?SlQ5cEJWZG03cG9IR1hxRGpoelVTb3dsR0FrNHJENnF1MmFlR0NPR2lmWTVl?=
 =?utf-8?B?SmdTV0lDQXJRYXhKYTBVMlN0SG1DYlZta0Q3ekZZUWFsTUZEMGNxN2pKeEVW?=
 =?utf-8?B?ZlUvUk9HWVpIVjB3Zm54ZVpTOFg5VzF0cyt1TEhGaUpXYlRzWGR6Zz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <F7BA105B38477942A3BEB757E18D626D@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8be8efcb-81fa-4e46-6a96-08d9ed3b111c
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Feb 2022 08:46:59.4470
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: zxnwIyUAtDKz8vuSYKPF/R7MZWG3avgj2l15g//u2l8YeC/cUVAp08eM0Iq8+n6+FUpPJs7c9bB/NlBmEP0ykMb+G5BjNkp4OWVG2zaEOQ8bvxuMALc/7J4LI4dYzS2N
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR03MB4709
X-Proofpoint-ORIG-GUID: fijSHzZ8kZqIfyCcBWHUarCSW0_gHVjA
X-Proofpoint-GUID: fijSHzZ8kZqIfyCcBWHUarCSW0_gHVjA
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-11_03,2022-02-09_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0
 mlxlogscore=999 priorityscore=1501 adultscore=0 malwarescore=0
 lowpriorityscore=0 spamscore=0 phishscore=0 bulkscore=0 impostorscore=0
 clxscore=1015 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202110048

DQoNCk9uIDEwLjAyLjIyIDE4OjE2LCBSb2dlciBQYXUgTW9ubsOpIHdyb3RlOg0KPiBPbiBXZWQs
IEZlYiAwOSwgMjAyMiBhdCAwMzozNjoyN1BNICswMjAwLCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5r
byB3cm90ZToNCj4+IEZyb206IE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIDxvbGVrc2FuZHJfYW5k
cnVzaGNoZW5rb0BlcGFtLmNvbT4NCj4+DQo+PiBJbnRyb2R1Y2UgYSBwZXItZG9tYWluIHJlYWQv
d3JpdGUgbG9jayB0byBjaGVjayB3aGV0aGVyIHZwY2kgaXMgcHJlc2VudCwNCj4+IHNvIHdlIGFy
ZSBzdXJlIHRoZXJlIGFyZSBubyBhY2Nlc3NlcyB0byB0aGUgY29udGVudHMgb2YgdGhlIHZwY2kg
c3RydWN0DQo+PiBpZiBub3QuIFRoaXMgbG9jayBjYW4gYmUgdXNlZCAoYW5kIGluIGEgZmV3IGNh
c2VzIGlzIHVzZWQgcmlnaHQgYXdheSkNCj4+IHNvIHRoYXQgdnBjaSByZW1vdmFsIGNhbiBiZSBw
ZXJmb3JtZWQgd2hpbGUgaG9sZGluZyB0aGUgbG9jayBpbiB3cml0ZQ0KPj4gbW9kZS4gUHJldmlv
dXNseSBzdWNoIHJlbW92YWwgY291bGQgcmFjZSB3aXRoIHZwY2lfcmVhZCBmb3IgZXhhbXBsZS4N
Cj4gU2FkbHkgdGhlcmUncyBzdGlsbCBhIHJhY2UgaW4gdGhlIHVzYWdlIG9mIHBjaV9nZXRfcGRl
dl9ieV9kb21haW4gd3J0DQo+IHBjaV9yZW1vdmVfZGV2aWNlLCBhbmQgbGlrZWx5IHdoZW4gdlBD
SSBnZXRzIGFsc28gdXNlZCBpbg0KPiB7ZGV9YXNzaWduX2RldmljZSBJIHRoaW5rLg0KPg0KSG93
IGFib3V0IHRoZSBiZWxvdz8gSXQgc2VlbXMgdG8gZ3VhcmFudGVlIHRoYXQgd2UgY2FuIGFjY2Vz
cyBwZGV2DQp3aXRob3V0IGlzc3VlcyBhbmQgd2l0aG91dCByZXF1aXJpbmcgcGNpZGV2c19sb2Nr
IHRvIGJlIHVzZWQ/DQoNCmRpZmYgLS1naXQgYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9wY2ku
YyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3BjaS5jDQppbmRleCBlOGIwOWQ3N2Q4ODAuLmZk
NDY0YTU4YjNiMyAxMDA2NDQNCi0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3BjaS5jDQor
KysgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9wY2kuYw0KQEAgLTkzNyw4ICs5MzcsMTQgQEAg
c3RhdGljIGludCBkZWFzc2lnbl9kZXZpY2Uoc3RydWN0IGRvbWFpbiAqZCwgdWludDE2X3Qgc2Vn
LCB1aW50OF90IGJ1cywNCiDCoMKgwqDCoCB9DQoNCiDCoMKgwqDCoCBkZXZmbiA9IHBkZXYtPmRl
dmZuOw0KKyNpZmRlZiBDT05GSUdfSEFTX1ZQQ0kNCivCoMKgwqAgd3JpdGVfbG9jaygmZC0+dnBj
aV9yd2xvY2spOw0KKyNlbmRpZg0KIMKgwqDCoMKgIHJldCA9IGlvbW11X2NhbGwoaGQtPnBsYXRm
b3JtX29wcywgcmVhc3NpZ25fZGV2aWNlLCBkLCB0YXJnZXQsIGRldmZuLA0KIMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBwY2lfdG9fZGV2KHBkZXYpKTsNCisjaWZk
ZWYgQ09ORklHX0hBU19WUENJDQorwqDCoMKgIHdyaXRlX3VubG9jaygmZC0+dnBjaV9yd2xvY2sp
Ow0KKyNlbmRpZg0KIMKgwqDCoMKgIGlmICggcmV0ICkNCiDCoMKgwqDCoMKgwqDCoMKgIGdvdG8g
b3V0Ow0KDQpAQCAtMTQ3NCw2ICsxNDgwLDkgQEAgc3RhdGljIGludCBhc3NpZ25fZGV2aWNlKHN0
cnVjdCBkb21haW4gKmQsIHUxNiBzZWcsIHU4IGJ1cywgdTggZGV2Zm4sIHUzMiBmbGFnKQ0KIMKg
wqDCoMKgIGNvbnN0IHN0cnVjdCBkb21haW5faW9tbXUgKmhkID0gZG9tX2lvbW11KGQpOw0KIMKg
wqDCoMKgIHN0cnVjdCBwY2lfZGV2ICpwZGV2Ow0KIMKgwqDCoMKgIGludCByYyA9IDA7DQorI2lm
ZGVmIENPTkZJR19IQVNfVlBDSQ0KK8KgwqDCoCBzdHJ1Y3QgZG9tYWluICpvbGRfZDsNCisjZW5k
aWYNCg0KIMKgwqDCoMKgIGlmICggIWlzX2lvbW11X2VuYWJsZWQoZCkgKQ0KIMKgwqDCoMKgwqDC
oMKgwqAgcmV0dXJuIDA7DQpAQCAtMTQ4NywxNSArMTQ5NiwzNCBAQCBzdGF0aWMgaW50IGFzc2ln
bl9kZXZpY2Uoc3RydWN0IGRvbWFpbiAqZCwgdTE2IHNlZywgdTggYnVzLCB1OCBkZXZmbiwgdTMy
IGZsYWcpDQogwqDCoMKgwqAgQVNTRVJUKHBkZXYgJiYgKHBkZXYtPmRvbWFpbiA9PSBoYXJkd2Fy
ZV9kb21haW4gfHwNCiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHBk
ZXYtPmRvbWFpbiA9PSBkb21faW8pKTsNCg0KKyNpZmRlZiBDT05GSUdfSEFTX1ZQQ0kNCivCoMKg
wqAgLyogcGRldi0+ZG9tYWluIGlzIGVpdGhlciBod2RvbSBvciBkb21faW8uIFdlIGRvIG5vdCB3
YW50IHRoZSBsYXRlci4gKi8NCivCoMKgwqAgb2xkX2QgPSBwZGV2LT5kb21haW4gPT0gaGFyZHdh
cmVfZG9tYWluID8gcGRldi0+ZG9tYWluIDogTlVMTDsNCivCoMKgwqAgaWYgKCBvbGRfZCApDQor
wqDCoMKgwqDCoMKgwqAgd3JpdGVfbG9jaygmb2xkX2QtPnZwY2lfcndsb2NrKTsNCisjZW5kaWYN
CisNCiDCoMKgwqDCoCByYyA9IHBkZXZfbXNpeF9hc3NpZ24oZCwgcGRldik7DQogwqDCoMKgwqAg
aWYgKCByYyApDQorwqDCoMKgIHsNCisjaWZkZWYgQ09ORklHX0hBU19WUENJDQorwqDCoMKgwqDC
oMKgwqAgaWYgKCBvbGRfZCApDQorwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB3cml0ZV91bmxvY2so
Jm9sZF9kLT52cGNpX3J3bG9jayk7DQorI2VuZGlmDQogwqDCoMKgwqDCoMKgwqDCoCBnb3RvIGRv
bmU7DQorwqDCoMKgIH0NCg0KIMKgwqDCoMKgIHBkZXYtPmZhdWx0LmNvdW50ID0gMDsNCg0KIMKg
wqDCoMKgIGlmICggKHJjID0gaW9tbXVfY2FsbChoZC0+cGxhdGZvcm1fb3BzLCBhc3NpZ25fZGV2
aWNlLCBkLCBkZXZmbiwNCiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgIHBjaV90b19kZXYocGRldiksIGZsYWcpKSApDQorwqDCoMKgIHsNCisjaWZk
ZWYgQ09ORklHX0hBU19WUENJDQorwqDCoMKgwqDCoMKgwqAgaWYgKCBvbGRfZCApDQorwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoCB3cml0ZV91bmxvY2soJm9sZF9kLT52cGNpX3J3bG9jayk7DQorI2Vu
ZGlmDQogwqDCoMKgwqDCoMKgwqDCoCBnb3RvIGRvbmU7DQorwqDCoMKgIH0NCg0KIMKgwqDCoMKg
IGZvciAoIDsgcGRldi0+cGhhbnRvbV9zdHJpZGU7IHJjID0gMCApDQogwqDCoMKgwqAgew0KDQpJ
IHRoaW5rIHdlIGRvbid0IGNhcmUgYWJvdXQgcGNpX3JlbW92ZV9kZXZpY2UgYmVjYXVzZToNCg0K
aW50IHBjaV9yZW1vdmVfZGV2aWNlKHUxNiBzZWcsIHU4IGJ1cywgdTggZGV2Zm4pDQp7DQpbc25p
cF0NCiDCoMKgwqAgcGNpZGV2c19sb2NrKCk7DQogwqDCoMKgIGxpc3RfZm9yX2VhY2hfZW50cnkg
KCBwZGV2LCAmcHNlZy0+YWxsZGV2c19saXN0LCBhbGxkZXZzX2xpc3QgKQ0KIMKgwqDCoMKgwqDC
oMKgIGlmICggcGRldi0+YnVzID09IGJ1cyAmJiBwZGV2LT5kZXZmbiA9PSBkZXZmbiApDQogwqDC
oMKgwqDCoMKgwqAgew0KIMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgdnBjaV9yZW1vdmVfZGV2aWNl
KHBkZXYpOw0KDQphcyB2cGNpX3JlbW92ZV9kZXZpY2Ugd2lsbCB0YWtlIGNhcmUgdGhlcmUgYXJl
IG5vIHJlYWRlcnMgYW5kDQp3aWxsIHNhZmVseSByZW1vdmUgdnBjaS4NCg0KVGhhbmsgeW91LA0K
T2xla3NhbmRy


From xen-devel-bounces@lists.xenproject.org Fri Feb 11 09:02:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 09:02:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270248.464466 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIRpI-0004w3-3m; Fri, 11 Feb 2022 09:02:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270248.464466; Fri, 11 Feb 2022 09:02:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIRpI-0004vw-0e; Fri, 11 Feb 2022 09:02:48 +0000
Received: by outflank-mailman (input) for mailman id 270248;
 Fri, 11 Feb 2022 09:02:46 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=dFbI=S2=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nIRpG-0004vq-ON
 for xen-devel@lists.xenproject.org; Fri, 11 Feb 2022 09:02:46 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5f679065-8b19-11ec-8eb8-a37418f5ba1a;
 Fri, 11 Feb 2022 10:02:45 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5f679065-8b19-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644570165;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=sFJ7vHZLreRxlZg8j1a+Hf8zN3kE/6BfXYc1RVwX+8E=;
  b=Nw3Dpz/4/rWYZtugNH4WlKRLibnHP4wrQMPFylEThoYtmvfaOl0HPaD9
   JloZUsVEezEBeNto+KhgQhkvl8h2JHjA4axjMAABZhPh63Juwd+xb62b7
   d28UuLzjDViui80hXemzeKmKF69xWkg3gH1zoKuneqBW/gj0aXp51zrur
   Q=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: fZbxRwMWMELa8BsgtPOv94sgOCTI3j9M17UBJZskzu3CF6iULGrDh6/c60dK4H7OgdzcZh/cKX
 YVRsBBWjn/lRJbUzTBewZx8VOdkY4GDacav/WHIIMCC9DK5U+IARQ4h2rM7e6dH0/2UmzStssp
 SqFuCn/OXI93KajiWsthxhxFe5V3TJpOI52FspDGhiD6p24a3eGVcVms+dGeCaCnhwcjffcveT
 WSkx/yA9QMZsIO/dco/wnqyfLy2rq/O9IEqW8+yKuvTvziQp0EaDIi1e/JhHSfUegH8mn0AIj+
 r9IiTivfkA739AveFj1PwZso
X-SBRS: 5.1
X-MesageID: 63446092
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:WUjHEKkhDg6Igp/KUZnElt7o5gxvIURdPkR7XQ2eYbSJt1+Wr1Gzt
 xIfXmuCMv3cZ2XxLtp3bY2/9U9QvcOAy9I2GQU6qH1mHiMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BClVlxJVF/fngqoDUUYYoAQgsA180IMsdoUg7wbRh2Ncx2YHR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 NFzkJmcEiQiBb3vxbwbTThWFCBCApQTrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBNPsM44F/Glp0BnSDOo8QICFSKLPjTNd9Glr2pwQRaeED
 yYfQRpWdDrdaDMUBgkWEbQyjvbzwV//fyIN/Tp5ooJoujOOnWSdyoPFMtDYZ9iLTsV9hVuDq
 yTN+GGRKg4eHMySz3yC6H3ErunKlCXnWI8DPLS9/+xthhufywQ7GBAQEFe2v/S9okq/QM5Eb
 VwZ/DI0qqo//1DtScPyNyBUu1bd4ERaAYAJVbRntkfdkcI4/jp1GEAAcBtERIcFv/QmZmFy0
 EGokdToOQNW5ej9pW2myp+Yqja7OC4wJGAEZDMZQQZt3+QPsL3fnTqUEI89TffdYsndXGipn
 mvU9HRWa6A70JZTv5hX62wrlN5FSnLhagcurjvaUWu+hu+STN70Ptf4gbQ3ABspEWp4crVjl
 CVc8yR9xLpXZX1oqMBraL9cdF1Oz6zbWAAweXY1Q/EcG82FohZPh7x47jBkP1tOOc0ZYzLva
 0K7kVoPuMMOZib1MvUqOtrZ5yEWIU7IT4WNuhf8NIQmX3SMXFXfoHEGibC4gwgBb3TAYYlgY
 MzGIK5A/F4RCLh9zSreegvu+eRD+8zK/kuKHcqT503+idK2PSfJIZ9YYArmRr1ot8us/VSKm
 +uzwuPXkn2zpsWlOXKJmWPSRHhXRUUG6Wfe9ZAJKL7Zf1YO9aNII6a5/I7NsrdNxsx9vuzJ4
 mu8Sglfzl/+jmfAMgKEdjZob7aHYHq1hStT0fUEMQn61n49T5yo6atDJZI7caN+rL5ozOJuT
 ulDcMKFW6wdRjPC8jUbTJ/8sI09K0j72VPQZ3KoMGolYpptZw3V4du4LAHhwzYDU3isvswkr
 rz+ig6CGcgfRx5vBdr9Ye60yw/jpmAUne9/BhOaItRadEj23pJtLij90q0+L80WcE2RzTqGz
 QeGRxwfoLCV8YMy9dDIg4GCrpuoTLQiThYLQTGD4O/vZyfA/2elzYtRa8qyfGjQBDHu5aGvR
 eRJ1PWgYvcJq0lH7thnGLFxwKNgu9a2/+1Gzh5pFWngZkiwDu8yOWGP2MRCu/EfxrJdvgfqC
 EuD9sMDZOeMMcLhVlUQOBAkfqKI0vRNwmve6vE8IUPb4i5r/eXYDRUObkfU0CENfqFoNI4Fw
 Ps6vJ9E4gOyvRMmL9Kag30G7G+LNHEBD/0qu5xy7FUHUeb3JoWuuaDhNxI=
IronPort-HdrOrdr: A9a23:en3hgqnZodz4BT9FcYY8ZJGpIhbpDfIQ3DAbv31ZSRFFG/Fw8P
 re+MjztCWE7Qr5N0tQ+uxoVJPgfZq+z/BICOsqTNCftWDd0QPDQb2KhbGSpQEIcBeOlNK1u5
 0BT0FWMqyIMbAk5vyQ3ODDKbkdKXO8gdiVbJzlo0tQcQ==
X-IronPort-AV: E=Sophos;i="5.88,360,1635220800"; 
   d="scan'208";a="63446092"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XNYmODpVDxydugSmm36gtB9reoXYcgngKzTXleXWzDnOeZGaBxq+VDAyMKJrWC9lH0dZG35YB6WXhuD2ZIno3Xoq/fdT2bwj2uYAh/l3tQlEkVwdDUbUCCJAwy+orlJjJaDEe8PpdxShCbUjMNewCEYdGpWtdKTUz7+If1bmNBwepUIivldKDpLigGfjKuTU4ATWamxAes+1+qa8JjWa1m/ssEZWeT7AaAxTipAqcxirkwwI7tyCdNZNmVd1rDE4E+CymE8b7S8HQkTrrvjgCfrtv+a2wigMQOpx6LN4gHKy4n4IqXGylUWuCyskWu5XlSSOUl612oXMWdastIar2Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Dv+VwNmuL7unPD8m05z/0WAG7OmF1zQHlan0/tURldA=;
 b=PVbrQQN4jVW+25PtS5WeAk+tM+8r6VFcGcMgxj64wweK3zdFUoZjLtX4bFdLErJCAZxJPkMzWFbKdTwj2QlqLWn39Yzz6wuNTZz9PIrrpBr/W9jqQIBOmeqoQy0uGCPQq0gbRx7w9V6UzCv2oCRl8hA6tUC/NJXVv2SM8z3YFyj7Tc8plA+sWT2TXZ/T4wJZU3pXBQCjZxRNM8s7EAoe5nKxEu60W6/rWKVw6E15horuXiTWnjEJJ0ypPxkmqooV3QzkbTARYBZaB2WYl7AoK7biymerJjvG1hoBCL4hJT8wCtny9/36VPkdiJNaEZh+idwcE+R17Z0bQJNTFVXGUQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Dv+VwNmuL7unPD8m05z/0WAG7OmF1zQHlan0/tURldA=;
 b=eq9UAz04M1g3AQrTgILp3cR/eEwzVc8rKpK4exuuzoFojZQGyeS4wnjJ1kmTEefMPh1M3N39viinHuBDXc7Qs0SN4R9azgXXXX3vBO0ryFYKzI48P1Fb7dlTvOh7sFD2FmEtYVfCeqpZ+RQejicq2xQRgSPz98AxkeKOxHRODs4=
Date: Fri, 11 Feb 2022 10:02:34 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Norbert Manthey <nmanthey@amazon.de>
CC: <xen-devel@lists.xenproject.org>, Jan Beulich <jbeulich@suse.com>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH CPU v1] cpuid: initialize cpuinfo with boot_cpu_data
Message-ID: <YgYmKiZaX2vZYgKP@Air-de-Roger>
References: <20220211072327.1213-1-nmanthey@amazon.de>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20220211072327.1213-1-nmanthey@amazon.de>
X-ClientProxiedBy: MR2P264CA0192.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501::31)
 To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4b3ed7a4-12eb-45a2-436d-08d9ed3d4173
X-MS-TrafficTypeDiagnostic: BN7PR03MB3540:EE_
X-Microsoft-Antispam-PRVS: <BN7PR03MB354068953356500BC84D7C3F8F309@BN7PR03MB3540.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3383;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: MdWOUrqR9gvfcBs6zp9NgqmCmKbPDoJIlywMLZGAQmr4MQWetAeHd1/cH13toq2hHJ0oQTbs8iJYUXF7vrfmF+ItL9Oe/eIspydNsUZv9Vny+vMAqbbTu8SWqOh2PWW8igUOo0N2dzvApL1c2EC44ec5fZkLXTRmggcmsjFYgyAONx8i0UP7m4IBuCH/UtEPiekCViPXONQfveX9xmCQoWYWHiC0aB9mCnWYC5VMt4d9Hj6254WiuKDSgdUURrfgmIMqAQsC3jckaZ5O2lFKJySBh3vgrBpXuMFThTvQ+710Jq3CLEyZjVtTwqKf/c3zEXhrrYeJEH2eRyciFJ4eBRAerB9UuwMLgK4k+gFeaKImoGdPPD+CyKsg7z0TjIYg7s96MDi/G+W2AUBdiKXTH33EAHsPes3ZYgNO8eWYz0rN2BACXnR2YH24sneMUiSJjjgzbyxJxDh8wiSaIClXkYar/Y26rjopXuHEfBRg7AEM9Ufb4BAoHKtV/6LcOzdEaoCUgJVsP9+T5ytdajgwIfeW2JpmUM57PZmDNzJh0Ts5XDPZDb8E0ZDPvfuZ0CWfLv5my/GlnXFfEOFbBgNoavKoblj56+WilADrjg2sE3cqkFrbWIBybBCNOozRcguiPWFDLX8j+Ts/X0QL9cQqOg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(54906003)(8936002)(316002)(508600001)(6486002)(9686003)(6506007)(6512007)(33716001)(6666004)(6916009)(2906002)(86362001)(85182001)(4744005)(38100700002)(66946007)(4326008)(8676002)(66476007)(5660300002)(66556008)(26005)(186003)(82960400001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ditZWHhZdFVtd0RIYWpTVkhFODcvTXlWdi9pZUdUYTc4aitSYzR0MGRWRGJS?=
 =?utf-8?B?QVllSjNSVG5NYTg3eEF1SDBLQ3lsRGFrVG96QU0wYW5lV0NNc0wzNnFCS25H?=
 =?utf-8?B?anpEaG16YncrQkZ5L2ZaMTE2cjh6SUcyU0I0Yk9zNlZKYVRxZmRwVXBrSzhx?=
 =?utf-8?B?bWt4b2pHa3FPMjNhWnkyUWZsM3FmZHI2TEUwazh1ZHFmZFY0QzdpQk1ENUMr?=
 =?utf-8?B?bFpmWmxHUzQybEpyM29sQkkrOTZVdkZzTUkxV1YrZEREUGxXb1lqV2RJSkZT?=
 =?utf-8?B?ZU1kbUJFM085ZjgxWkxnUEtXQUFpWTExQUdIS1pUL3BzaGYvWjRLMzQ3blBF?=
 =?utf-8?B?U0g1SUs1NlpibUN3WjA2cUhUb1RNdDM5Y2JaQXNtOGRxbXVXQzFkc1VkaWM1?=
 =?utf-8?B?UVNMTkRnT3F0Z2tBdFpWcnViaDlGbXJiNVRCa3ZvV1MxUWc0UnR0RFFpSWZZ?=
 =?utf-8?B?SjZaV0p6Q0xGTUNaTVJaQWZSZ1lWeTVxSjZpcEJFWXdOSFBBVEUzUGF1Q01N?=
 =?utf-8?B?TDlwOVY3L2lOcFpFZlFmMFUyRUlSYUpWV2RiTFJEUHpTbk43cldMVEhQUlQx?=
 =?utf-8?B?MEVyd2xIakJhQWFLR3JXa2JuY2d3eEZoKzcydzl2cU5ybUpYOHlLcE4yU2VU?=
 =?utf-8?B?UmM4ZmdxRThrb09SaTZoSXRLbkdTVncvK0VxYVZaMkRmZnhyeFBtUndCRzNp?=
 =?utf-8?B?RzNpeDBjOHhTZjI4MTBnV2g5dk41cE1sNlZkdEFvUnZlMnN5eFoxa3krbVJk?=
 =?utf-8?B?VmxncjR2ZGFNZEVkSk1DY01kbFVUMG83SHBOS0RiaUpVV1QxRitXTDN6UkpU?=
 =?utf-8?B?N3JMd3BUek9vaXhiemR1TGludjlRZnFFYWlXSy9pWXlWRDV6T2NibGxwNW9z?=
 =?utf-8?B?SFhhYnNxU0ZxN2xFUkxKOE83dVErS0h4SUl1REljbi9sbjhhd0oySmc3Nnhk?=
 =?utf-8?B?KysraE55ZnFaUVVib2pUL3VJa2NCUFY5RHp4eWZ0cU5NT1lWK1BDVG1tblBM?=
 =?utf-8?B?Yk1GTWVha0NEdXJLWENWaHJtVUdMeEUrRzVTUnJFQWFhd1IrYS9BSjdVNE83?=
 =?utf-8?B?aDNzZDA5c09hdXlIb1FqUjVpekZIN1RJZnJFUFVLdHlRdjVwMnFkSisxQitv?=
 =?utf-8?B?L2FzWmxwMjUwdGMrWFIxb1NST0VVcWl2VVhsWmVQVCtkeFFqZ004c0M3WFIr?=
 =?utf-8?B?bkk2WWVleUhWcVRvbno4TEtsbVg0bDZha0NDT2hqS1VNQ3oyRGxVOG9JT3RS?=
 =?utf-8?B?b3lOei9CSWFoakNCVW55U0Q4SWlldXlvUVdlMWxZMlVHR1pwcFV6QTdjZmdT?=
 =?utf-8?B?c1cyRjJMcTVGcVVwOU1RRlA2NWlpQnl0M08zZkJkUGFYSjR5b0owM0ZYR1JX?=
 =?utf-8?B?WTRweDZLSEpIemQ3N2V3dXA4UmxyMldrVE9rZit5ajN6TGRxeUJVTGR4Z1ln?=
 =?utf-8?B?ZDZUSVFySkFxMkZQTlVrMHJUM000K1RGcWtIRWh2aGpsNjFBSGQ4SnhZOWRG?=
 =?utf-8?B?RnNZNnFyVFpoK2dNNjk2cHlaNmRyMTE4YiszVmpibVRCMFJPUWxiNmhuR0Nj?=
 =?utf-8?B?ZExsMWN3cWlZZVZlMi80SWdCVFE4Sm1oQzN1WmI1ZG12b0d0QXAwVGU4aFBX?=
 =?utf-8?B?NFFLdjkzdGNEYWhFdytja1p1eDRud1VFb1d2cUhsZ29ZUmMvbytFTmEzQTVC?=
 =?utf-8?B?cUpuVGdGc0x2aGlYVzVMZitPdDRwU3ZIdEtYeGZxRUlDTW9uRVF1N0pEKzVz?=
 =?utf-8?B?WXcwck1XVEZTR1dMcW9PenJHT1BlVHpZYkJjRksrNnJEQW9adGlaYWdOc3FU?=
 =?utf-8?B?TWxjUWdudnVnQ2lPQ20rbU9uWVVHWnZIMVA4bk5EcE0zcU93WTdiOTlhejVk?=
 =?utf-8?B?cGd0ODhFZ21YRnRodVc3alJNWHdqOXZLU2JnVkdGSHVCZGJvVXdRRjl2eFdY?=
 =?utf-8?B?Y281c1FyTStuTzFFVHU1dmpjcWU2WlhsMHhCU1JNTVFZY3F4Y3ZRQ0lBUHhm?=
 =?utf-8?B?QWJnWWsrNW5NYTBTOU9lYnJlcVZoOEFsYWVMTHhYaFNsUkh4R1paSm94U3RC?=
 =?utf-8?B?bnByZ1lmUS9uVTFNaUtQYm1ZSEVDeCtva2haWVYzb2cwUkxXNzFqL2YvN0FT?=
 =?utf-8?B?Q1ZZUmlUM0hZaSt2NWVjd2dxSUxKa3BYYzVkLzFlUjRhUldPT3JBQllkYkp4?=
 =?utf-8?Q?+TE5j8GtZOi+TDkFTd+btNs=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4b3ed7a4-12eb-45a2-436d-08d9ed3d4173
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2022 09:02:39.8215
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Dpc3uFzb+jJYp5H4/WhyeeGvZFMYU/F0S4YdgL9k6puTJaw9lZVGqjKk9x2feH8xO68fGmunOKS3M2AIuT0RwA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB3540
X-OriginatorOrg: citrix.com

On Fri, Feb 11, 2022 at 08:23:27AM +0100, Norbert Manthey wrote:
> When re-identifying CPU data, we might use uninitialized data when
> checking for the cache line property to adapt the cache
> alignment. The data that depends on this uninitialized read is
> currently not forwarded.
> 
> To avoid problems in the future, initialize the data cpuinfo
> structure before re-identifying the CPU again.
> 
> The trace to hit the uninitialized read reported by Coverity is:
> 
> bool recheck_cpu_features(unsigned int cpu)
> ...
>     struct cpuinfo_x86 c;
>     ...
>     identify_cpu(&c);
> 
> void identify_cpu(struct cpuinfo_x86 *c)
> ...
>     generic_identify(c)
> 
> static void generic_identify(struct cpuinfo_x86 *c)
> ...

Would it be more appropriate for generic_identify to also set
x86_cache_alignment like it's done in early_cpu_init?

generic_identify already re-fetches a bunch of stuff that's also
set by early_cpu_init for the BSP.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Feb 11 09:40:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 09:40:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270255.464477 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nISPi-0000XX-1T; Fri, 11 Feb 2022 09:40:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270255.464477; Fri, 11 Feb 2022 09:40:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nISPh-0000XQ-UW; Fri, 11 Feb 2022 09:40:25 +0000
Received: by outflank-mailman (input) for mailman id 270255;
 Fri, 11 Feb 2022 09:40:23 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=dFbI=S2=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nISPf-0000XK-EG
 for xen-devel@lists.xenproject.org; Fri, 11 Feb 2022 09:40:23 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9f617777-8b1e-11ec-8eb8-a37418f5ba1a;
 Fri, 11 Feb 2022 10:40:20 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9f617777-8b1e-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644572420;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=A1f9r5ncU9SUlNKvw4uKoNawn8Lzqtw1MJjsoLb4tXk=;
  b=E07A9op/rIdLP9AH1i14jpWZgTjmqwbXMVBBEl0p8bo9EpH6nYNtvUQ/
   96uRWv3TYGsLqt3aStCevahHoDxppkhxTarmLqP7omEjKomb/fejPy5ez
   /6U/+XTVPL/WbaA+3l1G8CV8JgP84Oq297aiqS4Utfu1V5E65sbZHGhqV
   Q=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: nrYU3ccSSfdgGjEryl8uVvPQvkmDcp1AauUgeOk1nT6h9nmrPLjoAtVU766Pq7kV6r3I6cUlon
 6E6uWwNX/CwBPideYwDF6pEfXUdLBbB8TTKPwDugZl5QQDh2ylo82nyHPWRZH8VPkSpO+cwSyo
 hf7l6qMkiM9kTZkz+2K6DQ46444STvQCE4uWpz3kbN2QsWshHsDtK5TDQUq3zyQAyrW4ucGdj+
 AZyj2qWF2sY78rIiAC2DXwvbUXNLMOkv3YJtTKqRhMBhlN9BlH/Xc8TPzfmWc/zyYiuh3vhvwV
 LLM+QGHACKUkCtcDpuaQ/WKZ
X-SBRS: 5.1
X-MesageID: 64407617
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:eQDfMKJUvBnrxoPGFE+RA5IlxSXFcZb7ZxGr2PjKsXjdYENShjUDm
 zcdWT2ObvbYamXyc9ElaYW18ExSvJWEmIQwHgZlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokcxIn5BC5C5xZVG/fjgqoHUVaiUakideSc+EH170Ug6wrZg6mJVqYPR7z2l6
 IuaT/L3YDdJ6xYsWo7Dw/vewP/HlK2aVAIw5jTSV9gS1LPtvyB94KYkDbOwNxPFrrx8RYZWc
 QphIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbrGvaUXe345iXMfwZ3u7hB2Jlepa+
 utriqeREzt2Janogv44U0lHRnQW0a1uoNcrIFC6uM2XiUbHb2Ht07NlC0Re0Y8wo7gtRzsUr
 LpBdW5LPkvra+GemdpXTsF2gcsuNo/zNZ43sXB81zDJS/0hRPgvRo2UuYMAg2lp2aiiG97FY
 foieR1ONSjkRAdgExAsU4sRmcC30yyXnzpw9wvO+PtfD3Lo5BN1+KjgNpzSYNPibdVYmAOUq
 3zL+0z9AwoGL5qPxDyd6HWui+TT2yThV+o6Fre16/pri1273XEIBVsdUl7TnBWiohfgAZQFc
 RVSo3dw6/hpnKC2cjXjdx2ymlW2gDgjYPsKL7Ih7CWX0I/UsxnMUwDoUQV9QNAhscY3Qxkj2
 VmIg87lCFRTjVGFdZ6O3uzK9G3vYED5OUdHPHZZFlVdv7EPtalu1kqnczp1LEKiYjQZ8xnUy
 ivCkiUxjq57YSUjh/TipgCvb95BS/H0ou8JCuf/AzrNAuBRPtfNi2mUBb7zt6cowGGxFAfpg
 ZT8s5LChN3i9LnU/MB3fM0DHauy+9GOOyDGjFhkEvEJrmrxpyP5IN8PumwnfC+F1/ronxezM
 Sc/XisLuvdu0IaCN/crM+pd9ex2pUQfKTgVfq+NNYcfCnSAXASG4DtvdSatM5PFyyARfVUEE
 c7DK66EVC9CYYw+lWbeb7pNgNcDm3FlrUuOFM+T8vhS+efHDJJjYexeawXmgyFQxP7snTg5B
 P4Ba5XUm08CDIUToED/qOYuELzDFlBibbjeoM1LbO+TZA1gHWAqEfjKxr09PYdimsxoei3gp
 xlRg2dUlwjyg2PpMwKPZiwxYb/jR88n/3k6ITYtLRCj3H16OdSj66IWdp0We7g79bM8ka4oH
 qddI8jQUO5STjnn+igGacWvpoJVaxn21xmFODCoYWZjcsc4FRDJ4NLtYiDm6DIKUnisrcI7r
 rD5jlHbTJMPSh5MFsHTbP7znVq9sWJEwLB5XlfSI8kVc0LpqdA4Jyv0h/4xAscNNRScmWfKi
 1fIWU8V/LCfrZU0/d/FgbG/g72oS+YuTFBHG2T77KqtMXWI9GSU3oIdAv2DeirQVT2o9fz6N
 /lV1fz1LNYOgE1O79hnC79uwK8zu4nvqrtdwlg2FXnHdQ32WLZpI33A1shTrKxdgLRevFLuC
 E6I/9BbP5SPOd/kTwFNdFZ0MLzb2KFGgCTW4NQ0PF7+tX1+87ewWElPOwWB1X5GJ7xvPYJ5m
 eostab6MeBkZsbG5jpesh1pyg==
IronPort-HdrOrdr: A9a23:KWYzl6OAIOR8nMBcTyP155DYdb4zR+YMi2TDiHofdfUFSKClfp
 6V8cjztSWUtN4QMEtQ/uxoHJPwO080lKQFmrX5WI3NYOCIghrLEGgP1/qG/9SkIVyCygc/79
 YfT0EdMqyIMbESt6+Ti2PZYrUdKZu8gdiVbI/lvghQpGpRGsddBmlCe2Km+hocfng7OXN1Lu
 vV2uN34x6bPVgHZMWyAXcIG8DFut3wjZrjJToLHQQu5gWihS6hrOeSKWnT4j4uFxd0hZsy+2
 nMlAL0oo2lrvGA0xfZk0ve9Y5fltfNwsZKQOaMls8WADPxjRvAXvUrZ5Sy+BQO5M2/4lcjl9
 fB5z8mIsRI8nvUOlq4pBP8sjOQpwoG2jvH8xu1kHHjqcv2SHYREMxan79UdRPf9g4JoMx8+L
 gj5RPXi7NnSTf72Ajt7dnBUB9n0mCup2A5rOIVh3tDFaMDdb5qq5AF9k89KuZNIMvD0vFnLA
 BSNrCd2B4PGmnqLEwx/1MfjeBEZ05DUCtvGSM5y46oOzs/pgEM86JX/r1bop46zuNMd3Bz3Z
 WwDk1ZrsA+ciYoV9MPOA4ge7rANoWfe2OEDIqtSW6XZp3vfUi976LK3A==
X-IronPort-AV: E=Sophos;i="5.88,360,1635220800"; 
   d="scan'208";a="64407617"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=hmUcBRtpTzjGre9rfiEVcFeOjNmf0L9UC5DizgAYlQ1jNG9ElxCI88q3R8797zqpXxoj1EkfNSJm3oBwcfMHwFDj3LWs2/4uYQJNI9e7HMRC5DH9RqmlFhvU7nW9yYE5gzdiSfR+XAGQXLaTimFt/tFWGQmO8cCgvJHJUmSgobSgiPgPC52tDPxhoLwNbis2kwwNRL3JgRWAWpW64Moi/gcdyapAMTJZaLu+Faub+87jqFZuGVlJ5omVl+Zbq+TjLblR65VNOnbLrJyWpJpr1CdTjiguMyxgt61PGcDSNm34R04aJq78gGAXGn06pqQ+MWG8MKkwvi/vMqpajJL2IQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=A1f9r5ncU9SUlNKvw4uKoNawn8Lzqtw1MJjsoLb4tXk=;
 b=OY+EKWmYomycA+EqWNWOhonDuLdMj32BQHodAgK9Sm7M97DjeY8lS8IelR5WdlNNn7a9Ogplp2hJ95EwtwuG7ReMWrknQLHXbX8RuGbd0nV3jVfNlgz8nGS6BNetgrQs8x+eaLIL71xiV62lJrq3l30sBZV+CeQ8Ng136OLroNuLzGUvhVX1hHjl9sGRmc/dx8HGP4KpquwIFLKOd2BdZkpganeo1tGsOO2uK/i7iNPNMbIMl8m9T1L/FYMspYIz8/ttxZluWtAgM7ibpt5imwrN1fHXTVgVrQp8hTL7Bq75nlYWOgROwsbC2XOJN1mqr2SbrUEOUx/E5OQ7WN8+IQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=A1f9r5ncU9SUlNKvw4uKoNawn8Lzqtw1MJjsoLb4tXk=;
 b=WBv5edrQ9op7mSvpntDzXDECPtwU1crbStfz6YTvr5O3c4Gwl8gY/jpRld0syk525qr6K7a5dgn4rARWSqgrTS71ljyaNwNuBw/ckxIS2BdzvSdcAReztPXXG1iS2LQumAVGalN2lWcj7+w5QNG/K+2q/bZz9ErzL2NNR15bJQ0=
Date: Fri, 11 Feb 2022 10:40:08 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH 1/3] x86/Intel: skip PLATFORM_INFO reads on family 0xf
Message-ID: <YgYu+OoAovYmTg8E@Air-de-Roger>
References: <5d275d7a-7751-af19-db4f-d91e3592d30f@suse.com>
 <6f56a75c-cd68-0dad-b1ef-a3421271ee47@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <6f56a75c-cd68-0dad-b1ef-a3421271ee47@suse.com>
X-ClientProxiedBy: LO2P265CA0042.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:61::30) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 00efa24f-ddbe-4bae-04a6-08d9ed42809c
X-MS-TrafficTypeDiagnostic: DM6PR03MB4443:EE_
X-Microsoft-Antispam-PRVS: <DM6PR03MB44434C1F8861E805C593C97D8F309@DM6PR03MB4443.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: /tZPY6DN2B4pfLsq3gLSZEjek7SfkJWIF3LQGrZSo5HDu7UeWeumKy0teug+q/9OF3o1idY9QmM+z6dGkjTTR3nBfrgJ0T3++dgSPgwwA8egaRSSBERv2G/bjkINVWg63dU+Uycp2P/p2OpnDuIJA5pXu+cgbyn9RgidNKQTdsFmXFyjUqCnrEWndsHEjhUp7SHRjqi3i8u9ve+9xhSfN3pmanoYnDoxmWGT7sY0buzLMympEaicdiC7/VL4/Scu8Ysm81c5CgR19WpFY97HYAFWZFRFulPlZu6ZLIoEOJao9k3PHXDILYt/MCGK/L17VLEccf00nwQYewKk9S0wWzHUy88x6bgw3xGBZHcpxN5ae2FY7PSh6xUIF7G1C3L/p9iXl/bQ4NdM4ZMC36fRySU8QQZ66ZqzrXCL0xvQ+yJqyI1O7tvW4YJqAOVFxsJHSeBN7/JAlNJxhpFoM10DXmh+YE3XxzldkAdFN1ZiCYsYG4Ok7DAQNflStQ/EOWHkGZjP+vgvVt8ieEemwaY0ZMM/+UmMsXUdVC1ZExIDPVgIulLx07GVVnt02g/kY68FJF1U/W54JH9Gapggd9//XbS10NLIbu0uHXhhjjCezv8/UHyPc9HekMXFvg23JmdSB4K7CVPF3y1TP2c7DtBp8GIKUvLpTardNofOKRl1tkKZITn4feGYwrpBP5Vc+hDGRWISvf1pWgwA3O+n/wNDoA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(83380400001)(54906003)(6666004)(4326008)(6512007)(9686003)(6506007)(508600001)(86362001)(66946007)(82960400001)(6486002)(33716001)(66476007)(8936002)(66556008)(8676002)(6916009)(26005)(38100700002)(186003)(4744005)(5660300002)(2906002)(85182001)(316002)(67856001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q0NNeDRIMWNsMEtXbjE1ZFN5ZVFESTdHeXJxdE1pNFJWc1lYdUdEMlcvTmlq?=
 =?utf-8?B?TGE0alBlZEZDOThCS0xuenJmd2Ntd2pNYjhUZC9oeWF5OEFOWkVtZ3pnYTdW?=
 =?utf-8?B?TUQ4TVJKNGo4dzlGMndPS0xua0Q5bFRDc1RCdmNKOTY3S1FJRFIyR3U0NUMx?=
 =?utf-8?B?czFESSt1V0FyTWNwOFV0SWpGcm84SmpuL0F2U0lmSjdiUGNlK01VYXlkdHpx?=
 =?utf-8?B?RFE0UndIZ1U3TnZIQ1gzcCsyTE9tUTBMaUo2bnU4akxHQjIvdnowcDBhQ3RN?=
 =?utf-8?B?djZXdzlkbzFYVXZQTUZhTUlpUEd4blVEOHBpdzhiQkVvZWtjR2svb1k0Z0c4?=
 =?utf-8?B?ZDZITTlGK3BnakNqQ3N2YnkrYXdndkNuRiszbDJreENtUDE0bGtoVGJSV2Z2?=
 =?utf-8?B?UzNOdkxMMmVwTmxZeHZFNjVWRzlTSVRWRDdEVnBWdFZKVDladlBJVEV5SXV0?=
 =?utf-8?B?M21PRFZhVWFsdy9IZ2MwNGpBMnpwbzRQaXRESWxHMkdJOXVvZDAzZHBRdHJC?=
 =?utf-8?B?RnBsdFkrTWV5N0ZEbkJhMFdpZHY1Rm1LZlp4clNMNW0vUjhMbkhMNGNoblFC?=
 =?utf-8?B?dzVSQ2NISWQyYlZOY3BzOHpPdFQ2dnlOMG5uTjBCUjc4UkZWdmRUNlV1WVdm?=
 =?utf-8?B?TmZWbmdlSDZqK1VKTFZaYzFyU2VWUDlzTjBScTkrczVBZVAySjlrajdJNVRq?=
 =?utf-8?B?amhhbUN5TGtyeWUrb0ttdDlsaHkvQlpPZ3llbjVucVF5YTlOTHlsemtFWWZR?=
 =?utf-8?B?TDgvZTlYYTMvRG1Ld1ZvbFBSOGtiWDVaWS8yU0FFL2RxeXhJYkczaS9Vak8w?=
 =?utf-8?B?eXBmVlhtUVVTS3hoZFNpYU9tbEw3VTZKN3ZkS1QwYkZ2R2l6YWcwNTVMRFZV?=
 =?utf-8?B?WXhuRkcvWXZac0xlVEQ2dmhXeWRHNkdMMkpud1JWN1I5aXRpRFlDOTBlWHdD?=
 =?utf-8?B?eWFJTUcvbjVjODh5SE92WGoxRzRCVnlzQXBuV0xkL0VBekF0TWlEc3ZQSGJW?=
 =?utf-8?B?VmwxdlkxdzFvd1p6eklkbWN2bE4rbjFlOFpKMFp0ejZEa1l4bVpoVHl1cHBH?=
 =?utf-8?B?ZC8rK01SaEFmSnEzaGdIc0Ezc3BseDRyRFQxSElOZGlWdG1JakdFTDVuUVNw?=
 =?utf-8?B?ak9mNzl6ZEdBL0xCNHBEODBXdnpZV1M3YWlKbVpBM1NIcDBHbWxkSE5vakpu?=
 =?utf-8?B?WGcxZzBKL1hOMWZ6SWl6cVp2M2pWOGpseG5VZGMvcFQ4YkVXZ29CbE84aTg3?=
 =?utf-8?B?THQ3dCtDeUxHWGZxRHExTzRSaXBEaEhLSDdOQ2I4ZGh2RXJiRnpHWTE5RERu?=
 =?utf-8?B?TzBPWW0rVFJGTWU0elJtVituSHhpSVhKSGduY2plMStySmVRNlhpVkNudG1K?=
 =?utf-8?B?NHF4eEZnY0dIb0dvaHdrbFRVdHErNmlCcTBvdHJBR1JJaGkxVFNtRkdPRkM1?=
 =?utf-8?B?RURqaUtwUGNCNHQ2cXJnVXRrckNaUllielV3czlMR3RBR1Rqd1hncmhNYmFt?=
 =?utf-8?B?UzZ1a0dpSFNSbU5FMzhRajR1SlVtTEFQcm1wMlNaVFk2SWowM2ZFTjd2clJy?=
 =?utf-8?B?TC9jU1VWazZzb0pYVElJb1ZJSHpEUDdCdDZaa3BKbjdWVk5FMjZ3N1VxWFpY?=
 =?utf-8?B?U3p6R2k1T2w5cXBydDNVOFpvR05MTWlWRHFoYkp0WEt1Zi95eGhLZzJVK2pz?=
 =?utf-8?B?QmVDNThSeXlFMGR3VGVKaHhNVnF6VEJORVF6V2cwSGFjS2o4UEJqZmNLZjBo?=
 =?utf-8?B?VTM5UUR4dTZIUlN3ZmkzYU53dFNuNWhMSHdmby82WVdpVWVsL29QcTlhTFpR?=
 =?utf-8?B?MmkraUVhd3ZDNTVTdjNWRE01cFBqV3VtNWVwR0oxekM0QUtoL2FDR29FSGM5?=
 =?utf-8?B?ak1WdkVFUGVIV21UcUNNU2xTQzZaN0FncDA3am9DM2ErSEVlMElUQ05UUWx1?=
 =?utf-8?B?Z0RMTGtkd1huYk4vcDdxb0JtREs0Qi9nbnIxMmt2RWhNTHZrWTJkVnJpK3V5?=
 =?utf-8?B?blNLaGlIS1hTWmlqRGxpNVhMeDRRNHdHVy8wNlIyc3RHVTFWR0RSeTgxODJ1?=
 =?utf-8?B?dXI0RW5KdFo1cUdlRTZEcllCTm1uUGQ3cnJYT0ZqQWljckRTVHh2Z0pucS9D?=
 =?utf-8?B?UzdDUVZxR2VKZGluejBiQUZRaThvZm1Gajg3NHl3aVA0c1U4em5GYytkT3hC?=
 =?utf-8?Q?PiBJZ+f9ePHAfYit58AoLNo=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 00efa24f-ddbe-4bae-04a6-08d9ed42809c
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2022 09:40:13.1906
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wdbG9a9A0rZaLY6du1zgNKtqXP4/BhgcQjfWnQ+xr4F2dy6jIYczLzKeGcVhhgtJoP4+CSy2W569szqyROoXKA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4443
X-OriginatorOrg: citrix.com

On Thu, Feb 10, 2022 at 03:55:52PM +0100, Jan Beulich wrote:
> This avoids unnecessary (and always somewhat scary) log messages for the
> recovered from #GP(0).

Could we maybe get rid of the #GP messages for cases like this where we
are explicitly probing for MSR presence? (ie: it's expected that we
can get a #GP)

> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> Perhaps even use "!= 6" in at least the CPUID-faulting family check?

Likely, or else you would also need to check for family 11 (Knights
Corner?) which doesn't seem to support PLATFORM_INFO either.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Feb 11 09:59:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 09:59:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270264.464488 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIShy-0002BY-Lh; Fri, 11 Feb 2022 09:59:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270264.464488; Fri, 11 Feb 2022 09:59:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIShy-0002BR-Hj; Fri, 11 Feb 2022 09:59:18 +0000
Received: by outflank-mailman (input) for mailman id 270264;
 Fri, 11 Feb 2022 09:59:17 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=jrYj=S2=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nIShx-0002BL-Ls
 for xen-devel@lists.xenproject.org; Fri, 11 Feb 2022 09:59:17 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 459de98a-8b21-11ec-8eb8-a37418f5ba1a;
 Fri, 11 Feb 2022 10:59:16 +0100 (CET)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2055.outbound.protection.outlook.com [104.47.6.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-23-MF_YvvIFPhONmmX_GOAhZQ-1; Fri, 11 Feb 2022 10:59:14 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM6PR04MB4215.eurprd04.prod.outlook.com (2603:10a6:209:4f::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.12; Fri, 11 Feb
 2022 09:59:12 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4975.015; Fri, 11 Feb 2022
 09:59:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 459de98a-8b21-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644573555;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=2rvPjWIXJX3c14Akzkvm/COtfz4A1SfrfTWH7Z2dgZg=;
	b=j6aBWmbxCmhzOFIwOFR8joeO54JEby3QFKMVVuBppy3BrEFpFje0doMJ72SNFZ7v1mZtup
	3rWklToAR684Ma2L8XvSQ4uvuwydoGUM+fzPomUdCrKekjFtqkUd4UfX00eP/wKVGsA97a
	ehHfHf70Nlb8Q/baWkvV4hNBzXWuw0c=
X-MC-Unique: MF_YvvIFPhONmmX_GOAhZQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=KP3j8anBK9qfxSdLgKjUf6sCByonlvayZyGhSaGxKeqQOuDC+RfxVqqFcvmhS+5yJrkvTMeo1enf7/kzSdukoAIWmXCvfA86nBGFtoPNjeSJKHMRrjZcCtfqTvCWhz/UF2r2pgd8UxGe5hG0Z/H4Qjnrm0DdPf1IsdCK6OjFayXuhbdkd8zTTJ0IIhbixQCcsFE7f8qK9UA6dyimTfkuA8ts92dgXpI8jj3guU95lRPVEpnBmChcGvbhCBkGm5SKw7UlL+NpGOqwHxepZy2QN2kS0vCwIZvk6motT8+1avLzw5t1LLBoMgnbEC66nNSgRl4fbClxAdyBNo29PSQspA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=bWKHPpJzzG3FUFJYm97r50yYyjzyjcEYUYdLV4MCfRw=;
 b=YJD2HTFTkWIgjqKdOQSDCg3gJTQVwye9xlpvEkGOxOt4ZxcrMnDI8NvTvMrBXMxjEeE6FTb/D3joVDkMbPQv6F4dzeH5sqHnLyUmKWdvQ5ff0mwT6FNHHjgKOCePj0DiE3gSiXFwjOdRNFKBeiMxL/FOAvY70MiSItpyeqtWnyoF5BAz8xWIc/Mhva2t1Pp0RZBXJHH7wPNrcpEX16CgNlDnVhBBsROrC2SMxFNK+agPjsf2moHVn3PUBBkLJFIsU6wUnLBhJsVnt4rnLKr6yJFeMrAmHbXMz4QXNWBLtUXX4L9cZcw9845ibIxxZOccqPy0PWH2XRkjqMCR7Ud08Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <b751bc52-7878-e1dc-9769-55328ef1abf7@suse.com>
Date: Fri, 11 Feb 2022 10:59:10 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH 1/3] x86/Intel: skip PLATFORM_INFO reads on family 0xf
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
References: <5d275d7a-7751-af19-db4f-d91e3592d30f@suse.com>
 <6f56a75c-cd68-0dad-b1ef-a3421271ee47@suse.com>
 <YgYu+OoAovYmTg8E@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YgYu+OoAovYmTg8E@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM5PR1001CA0056.EURPRD10.PROD.OUTLOOK.COM
 (2603:10a6:206:15::33) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4cb59ab6-96c0-4f2e-b5c9-08d9ed4527c5
X-MS-TrafficTypeDiagnostic: AM6PR04MB4215:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB42153DAB4E7F17E4C47F3B27B3309@AM6PR04MB4215.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	I0Y6Juu5J3z6tn3lRE60BQ+7IyYID0JWnPjd8B04sHbPwLWyYOAuW7cv5ycGWIL6PIeWkBOIWtlzLi1/tgOn0NEGz8qEU9FFSgJUAWCyp4ONONwxrNRgi9Ih6nINmXH0OfMUMdcILV2NyewrLcnnORvk8stEtlLSHsBHzpMaLCw1UUPhwai6baLE7S1w358FN0epYhRLRu5VO5dG3r3SxOypLwbl/loLnEKmjxRLJ6CLU1XvEpRfq2R2T27stpL+Ix1Fkhk/i4imhZjkcER/m7NepDvNlsK3zk7RH3Yjwtv9spOMnwI6bS0rBUZCagaCuBhFcJWUk4d0yhqMRVsrsZREZ8lkfWfuJ2o9qfWoGrkvnpABz7pLVKwH8w3frGiys+hmTBZJXAXPsXTr6rWyLYvYqQPRvPn1MoLMhiWU0BaIO4vqzNDhT+V9TCUzoocpuoaJZfxDv4B01yJFTZ6duqqMDi0G4tHARLEcfcLe2ivgGdclW2CKtiBXs01ygHtrkabVDBXr2QLdtIh5uSdzZbt9H2n/RqtQlKNME7i3QmbjtQhavLK9a08Lp5CtdfoOI28CPJzue6hSxXxNOeyJMR0s/2bXaQPCHBN5BsFDu+/7TL+muh0u0WjKoFmG38wuC/r/EWQJ5p82NtfehJUffe00DYJiXI+8j2yJE6cAtVcheom/RVN+YAPImHpb6CebreMYOMjEGdTTgXDypioW9gerWWVRho0aeLNzQlycbTzBHaW6UPb8zmNh7P5kXgYx
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(5660300002)(6486002)(38100700002)(508600001)(83380400001)(6512007)(26005)(186003)(2616005)(2906002)(6506007)(86362001)(4326008)(53546011)(8676002)(8936002)(31696002)(54906003)(31686004)(66476007)(66556008)(66946007)(36756003)(6916009)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?vb/vW6FwHjKe5jYI34FN95cRLVGpmNhAHKqvZcSII5ISaAvmopIS3dA826fR?=
 =?us-ascii?Q?TMtk68n0J9fa8ECPsi7H2yVS3Le3DAY96W2a+tokzYEn15gSTNAYO3VzAOUF?=
 =?us-ascii?Q?JREowvJx3fh+YxUffRieYi42Jngyt+qfaqYbzmPErcHXaDgn+33lTmD/h0gg?=
 =?us-ascii?Q?cLI3muq4l6LQA8Jb3PNIU6ksWtG6plTmy/bidX35XI5H7tO0V+yuTq1OuXdt?=
 =?us-ascii?Q?pH6iu0fwkoRJxxgBvNCux7LtrMG1zkPce7R8hLS6tLdJkUkdBaI785aG+60n?=
 =?us-ascii?Q?1GhXGqFFAtR1PnkIvha2v/JabhUSZPejHzWU3NExmP+cHHZZlY5re9O2FdWF?=
 =?us-ascii?Q?d5+owE0vWsZsSKOpqCyLc0d0l+L4ud+bjgrWQPsc4rzaUi4wESTVLWHVC5dv?=
 =?us-ascii?Q?71uVQlsjLaoSTYDyZdrSSwsNtkvWI+1GjyH6lscBillOQSTdKZBv5OpSlJ1G?=
 =?us-ascii?Q?PPzrpBcQkH3yo0TR7hxWeS3S7jUoyowMAOOAPN/EEB5VRBL+lnjF1nC7nh41?=
 =?us-ascii?Q?56WY1BjpAx99epfmiRCa0P2MDwtTBItOR5V499HtBLnYLHgm+sK/1baW3Q3a?=
 =?us-ascii?Q?N2VSR02cf1DKUEjO/i+df16xA0ALNrxKJqiJS2ukt2xnr5hZ0pc3V1SF9eEW?=
 =?us-ascii?Q?nL2G4oKBbUyzDow3YxeAxOxvzeIM/FLq/q77VbbyshXJfk+0SNPRzs1RhS0j?=
 =?us-ascii?Q?coeUCb4sYPD9Q/gkzJgMT2k7fKffV1j/wCA3PjceWvtfVPQEeIcX+Q+IHJ/Q?=
 =?us-ascii?Q?oxgUKp2KQ6veaVYRkStcqbQ7fB0/EG+FmInAsbaUbJGZ5zXqhDtAcbMT1+ig?=
 =?us-ascii?Q?iPM1EZl2jIw/5MeVE5MbiOe+LKYAl1aAGHJQ+NROXgBOufvSUORdhi59hFdm?=
 =?us-ascii?Q?jIUbgLn3togBDYmkmlqyyqITE7BRUH0x+Ea/yhiJEsVbq34z2WaPO796+IVE?=
 =?us-ascii?Q?uUozVhypQx2Zxt8ScSEXkW9uHKCwdECu+usUPQwYoT3dATpDHbdm/ULvWbgA?=
 =?us-ascii?Q?j49JO9nGtrSA8PSPjlNQL1gpLpYTAeTHO0qKYDG0HHw6f9k2rOMFQMYGViJr?=
 =?us-ascii?Q?80Z8SN7B8Updt/3pMAAZAhQss0UFIJK44ZfPi9mupDVzIIrPRhMIFVY0pP3Z?=
 =?us-ascii?Q?UXFpQToq8mQilvnt2MG+acJ/41iP1NWI9Wm5qpSRhCaTBtKnb2t9xDQSDZ20?=
 =?us-ascii?Q?vkzN3nHDoTScTswjyXj96c1gPPY0PvN8WI1pYUJCDksoe6NLDX3GIBhOgASN?=
 =?us-ascii?Q?UfL05FSe00PvUn1F10yZtX1G44YWQr19fuhRRXSJGLgCkpXSVUMtevdz/cCI?=
 =?us-ascii?Q?AoSO9fzw2IlSAzjGpoxY/ca/aoRLrWSDVZXoINb4JHkHc//7sS/UcNrHzYxf?=
 =?us-ascii?Q?Odfj2b3uFPeKZFRaAadtHuuwWf82XHGtwVP1VxaqDgXc5858D3apsrVvOriZ?=
 =?us-ascii?Q?/2I3S9jyqvg/ZZOD2HV9pk3obgJ1iPfIMqbFEfRKEnG8MtoHarhidVKJ9bH8?=
 =?us-ascii?Q?ZWKR5ATAt3EpXqjHjA6QlFuogBv9c6BI6DF7Px18Xqk93WXRrV4t8QFPcHmW?=
 =?us-ascii?Q?rnzvshcF2kxbJRseWm5ATYNdQoa/CYF4wG4ZWFdNXuJupoa2JKmDZNPnTGHC?=
 =?us-ascii?Q?5uR+xQo+aBY/sGzYMdVJulA=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4cb59ab6-96c0-4f2e-b5c9-08d9ed4527c5
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2022 09:59:12.6836
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cwigN42W7vFfx8HxWpQ0Y1k7WFJqLV6RKSJpbdi+7m/nflf203LEyJ4JmD1pN1sPrYxo1UD4miCILzWcFaAKgA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4215

On 11.02.2022 10:40, Roger Pau Monn=C3=A9 wrote:
> On Thu, Feb 10, 2022 at 03:55:52PM +0100, Jan Beulich wrote:
>> This avoids unnecessary (and always somewhat scary) log messages for the
>> recovered from #GP(0).
>=20
> Could we maybe get rid of the #GP messages for cases like this where we
> are explicitly probing for MSR presence? (ie: it's expected that we
> can get a #GP)

This would mean some form of annotation of such RDMSR attempts (for
the recovery code to recognize in order to skip the printk()). Not
all rdmsr_safe() uses are, strictly speaking, probes, so I wouldn't
want to put such in rdmsr_safe() itself.

In any event - quite a bit more work. Plus I'm not convinced it's a
good idea to suppress any such log messages.

>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> ---
>> Perhaps even use "!=3D 6" in at least the CPUID-faulting family check?
>=20
> Likely, or else you would also need to check for family 11 (Knights
> Corner?) which doesn't seem to support PLATFORM_INFO either.

I don't think Xen is able to run on these (likewise for IA64, which
iirc were surfacing as x86 model 7)? These are the co-processor ones,
aren't they? My question was more towards whether we would (wrongly)
exclude future processors when using !=3D 6, if Intel decided to ever
make new CPUs with a family other than 6.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Feb 11 10:07:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 10:07:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270271.464499 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nISpP-0003hh-Ex; Fri, 11 Feb 2022 10:06:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270271.464499; Fri, 11 Feb 2022 10:06:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nISpP-0003ha-BH; Fri, 11 Feb 2022 10:06:59 +0000
Received: by outflank-mailman (input) for mailman id 270271;
 Fri, 11 Feb 2022 10:06:58 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JgwB=S2=citrix.com=Jane.Malalane@srs-se1.protection.inumbo.net>)
 id 1nISpO-0003hM-CN
 for xen-devel@lists.xenproject.org; Fri, 11 Feb 2022 10:06:58 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 56b98864-8b22-11ec-8f75-fffcc8bd4f1a;
 Fri, 11 Feb 2022 11:06:56 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 56b98864-8b22-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644574016;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=n7pQDiOy8SYXQFImR2ih146+tHBRFjraEgjdFyik4Fo=;
  b=PnQ8woPX1pqRhvqLt58zR90ZIHuG8CTP8NxRELcoWpMvimUGWN6bRC10
   /fFulrOWgYgc3AbgXCY0N9+QhAj3FSQi4D1cJNFQTgKfbvA6FOjP7d57e
   Yfj718dglZkCIo5hPg62CfptisnrUnl2h9p5k3SJBCdA2QjwJdvsFSWdF
   k=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: Y3bTxsiFgpn0CXMgYdzu6Juq1t8POL6vS/yoWJ73+/f1etkd5Q/PcVEBEukbCn2Y0d5p4BJlRd
 AxhkSgN170O50A0mEmHQFGVuVOUin/r5s9ql9HDJtO2xuTEZra3jQ4OrqFSmLKkbpmZeeqzYHE
 7eMoxj25dQ29nbGD+WH/tA07Kmy5YcnM/jF7FyEw2Iyos5ix7r9BcljN/c9fFyum09rlji9U+N
 cQ3pzZW/Klf+Qf78gmNyIIWym1tAxONNDv90zh8y8F8hMbBDQwbySoLqDLsd+ODWutQ0MYsnl5
 36nhvyOfa6NaLrlbamtdPq7G
X-SBRS: 5.1
X-MesageID: 66227615
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:DO4FmK41G3w56Sm8jNS5IwxRtEXBchMFZxGqfqrLsTDasY5as4F+v
 jdJXzyDOveNZmWnKtl2bNu+8UxUupDUmIdgTwBvpCozHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FV8MpBsJ00o5wbZj29cw2LBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zj
 4sXk8KuFFoTBI7rsb4mDl5SMghjMvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALDsDtMcU6s3VpyTjfAN4tQIzZQrWM7thdtNs1rp4QR6yBO
 ZNEAdZpRBTfUjFwGVgrMZYjo/eM23LAVWIHqnvA8MLb5ECMlVcsgdABKuH9RNuOQslEm1eCk
 UjP9W/5HxIyOcSWzHyO9XfErvTUgSrxVYYWFbu53v1nmluewioUEhJ+fVG2u+Wjg0iyHddWM
 VUJ+zEGpLI3skesS7HVXBCmoXjCoh8VXfJRFfE37EeGza+8ywSEAC4CRz1Iat0jvec3QyAn0
 hmCmNaBLSxitviZRGyQ8p+QrCiuIm4FIGkafygGQAAZpd75r+kbjBjCU9JiG66dlcDuFHf7x
 DXihDc6r6Uei4gMzarT1VLahzOhoLDZQwhz4R/YNkqn4Rl+f5WNfJGz5B7Q6vMoEWqCZgDf5
 j5ewZHYtb1QS8HW/MCQfAkTNPb3vdDbLmCBu2RMOLB7zGnq8V+KYI8FtVmSO3xVGsoDfDboZ
 mratgVQ+IJfMROWUENnX26iI590lPa9TLwJQtiRN4MTOcYpKGdr6QkzPRb44oz7rKQ7fUjT0
 7+/eN3kM3sVAL8PINGeF7ZEiu9DKszTKAruqXHHI/aPjOL2iJ29E+5t3L6yggYRtvLsTOL9q
 Yg3Cidy408DONASmwGOmWLpEXgELGIgGbf9oNFNe+iIL2JOQT99V6KLnOx+IdE8x8y5c9skG
 FnnCye0L3Kl2xX6xfiiMCg/ONsDo74jxZ7EAcDcFQnxgCVyCWpexKwea4E2bdEaGB9LlpZJo
 w0+U5zYWJxnE22fkxxENMWVhNEyJXyD2FPVVwL4MWdXQnKVb1GQkjMSVlC0r3dm4+venZZWn
 oBMISuFHcRdF14/UK47qpuHljuMgJTUo8orN2PgKdhPYkT8to9sLi36lPgsJM8Qbx7Ew1OnO
 8y+WH/0fMHB/N049sfnn6eBo9v7GudyBBMCTWLa8ay3JW/R+W/6md1MV+OBfDb8UmLo+fr9O
 bUJnq+kaPBXzkxXt4dcEqpwyf5s7dXYuLIHnB9vG2/Gbgr3B+o4cGWGx8RGqoZE2qRd5VmtQ
 kuK99QDYeeJNcrpHUQ/Pg0gaujfh/gYliOLtaY+IVng5T8x972CCB0AMx6JgS1bDb10LIJ6n
 rtx5J9Is1Sy00N4PMyHgyZY83W3AkYBC6h35IsHBILLixYwzg0Qa5LrFSKrsoqEbM9BMxd2L
 2bM1rbCnblV2mHLb2E3SSrWxeNYiJkD5EJKwVsFKwjbk9bJnKZqjhhY8DBxRQVJ1BRXlel0P
 zEzZUFyIKyP+RZuhdRCAD/wS10QWkXB9xyj0UYNmU3YU1KsBz7EI2AKMOqQ+FwUrjBHdT9B8
 bDEkGvoXF4Gpi0qMvfejaK9l8HecA==
IronPort-HdrOrdr: A9a23:atOEqK31EYache9RaEw5AgqjBRFyeYIsimQD101hICG9Lfb2qy
 n+ppgmPEHP5Qr5AEtQ5OxpOMG7MBbhHQYc2/heAV7QZnibhILOFvAi0WKC+UyuJ8SazIBgPM
 hbAtFD4bHLfDtHZIPBkXOF+rUbsZm6GcKT9J/jJh5WJGkAAcAB0+46MHfhLqQffngdOXNTLu
 v52iMznUvHRZ1hVLXdOpBqZZmgm/T70LbdJTIWDR8u7weDyRmy7qThLhSe1hACFxtS3LYL6w
 H+4k/Ez5Tml8v+5g7X1mfV4ZgTssDm0MF/CMuFjdVQAinwizyveJ9qV9S5zXIISaCUmRMXee
 v30lAd1vdImjXsl6aO0ELQMjzboXITArnZuAelaDXY0JfErXkBerV8bMpiA2XkAgwbzYxBOe
 twrhOknosSAhXakCvn4d/UExlsi0qvuHIn1fUelnpFTOIlGfVsRCMkjTZo+bo7bWrHAbocYa
 JT5QDnlYJrWELfa2qcsnhkwdSqUHh2FhCaQlIassjQ1zRNhnh2w0YR2cRaxx47hd4AYogB4/
 6BPrVjlblIQMNTZaVhBP0ZSc/yDmDWWxrDPG+bPFyiHqAaPHDGrYLx/dwOlayXUY1NyIF3lI
 XKUVteu2J3c0XyCdeW1JkO6RzJSHXVZ0Wl9iif3ekOhlTRfsuZDcSzciFYryL7mYRuPiTyYY
 fABK5r
X-IronPort-AV: E=Sophos;i="5.88,360,1635220800"; 
   d="scan'208";a="66227615"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=C5B6Ww7IG7uE2l5E83mypACRsFZgVyAXEKf+i6UxALZlJVPJxZNc5HJassch6+DHwhe1Olc1siemXvo5sK8bZ9SLFW4Zh2hddtEy4Yp5xJ7cqsKgBvFIC8+YRt3S2lAubUrHvMOCqVhyaP0ctYfNGIT8z2isg905uEdgpQYsn/gTCxzFRAD68dlpr0ca4SsDNwktF4P8Q3AtvLIHnZqqH7l7IBfUiDdOvvY/L2nBBRejTVWs7rYJM7fo4Yed5r0H41LGLCm6ScMbg+zO7P26FWh5vdnpJBSHHG526S/Pg4Gai0hge4DjUZSiEc8afXgeaixKbO8EJF/4xYc5fQSk5w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=n7pQDiOy8SYXQFImR2ih146+tHBRFjraEgjdFyik4Fo=;
 b=UFf6IYyuXjSnAJ+hLA2WmlYIqNDjDJN9wYJdT8rLjJpMRMwywAybwW6oE5BuTAREg/I2iVIhx562EXgCoozuldSKiGHSJINtaHElPW8hFxHlq5jLVCaY4k2prhW1Fj6uu54IevREe49zJie529PJTqbNPtdotMDLRpUe0zX4t1R96AVGjPFgSsl7nZiTgQBLf0qwZm7UgCAx/ahjjp1pAZHM3CzAsRzWkjdV7e1m40ulp6M3zQWvf8R2+ZizkpnKmYElEhwOtGiMFncw6TAorgKLR43zOtJU1jeHFNp7U1TU0CGl38pCjMQAc4CAWN+MsWe3a6/zfmteIRjfV0k/ZA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=n7pQDiOy8SYXQFImR2ih146+tHBRFjraEgjdFyik4Fo=;
 b=O5MNZz/ATX5uupN6rZSwMJlRaal18KaAxYYV8dSoLyNZIel6koUAqLH47IZyEWH+MjKzeDCZjCLO5nAnfkSzP2bQkbrR9p+ZuSf7KZEYWXvE3OGdNcz4Rl7JWSrEhI9y7oGNNrnnSVhZEf1U289LQqfTkux8r0GK7cagnnuXLrY=
From: Jane Malalane <Jane.Malalane@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>, Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <Andrew.Cooper3@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>, "Anthony
 Perard" <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, "Andrew
 Cooper" <Andrew.Cooper3@citrix.com>, George Dunlap
	<George.Dunlap@citrix.com>, Julien Grall <julien@xen.org>, Stefano Stabellini
	<sstabellini@kernel.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>, Jun Nakajima
	<jun.nakajima@intel.com>, Kevin Tian <kevin.tian@intel.com>
Subject: Re: [PATCH v2 1/2] xen+tools: Report Interrupt Controller
 Virtualization capabilities on x86
Thread-Topic: [PATCH v2 1/2] xen+tools: Report Interrupt Controller
 Virtualization capabilities on x86
Thread-Index: AQHYHE+TdJl64aH33EedeR0PZ4zblKyMkj6AgAGTLwA=
Date: Fri, 11 Feb 2022 10:06:48 +0000
Message-ID: <dff9c5c0-7bee-ce0d-3288-91255a701c99@citrix.com>
References: <20220207182101.31941-1-jane.malalane@citrix.com>
 <20220207182101.31941-2-jane.malalane@citrix.com>
 <YgTi6bzeojtcu0xL@Air-de-Roger>
In-Reply-To: <YgTi6bzeojtcu0xL@Air-de-Roger>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 5817aba1-0bec-4454-baa5-08d9ed4637bc
x-ms-traffictypediagnostic: BYAPR03MB4870:EE_
x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
x-microsoft-antispam-prvs: <BYAPR03MB4870C3502A6DB7CF6DBB011881309@BYAPR03MB4870.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: gBahJt30VqlxGhh613xPuCnAUQ/j9PgI1NSWq+yk3SwbBSOm1q3PDewPbdY25JDdrOWVK76CKMJ36850D9xfQqjjyi+v5rmRmnO8RUGtN7spt7M7smr5fobKhWZmmu6c+LbtGW4J3iDQRufuEtngK0rziCD5cjAnpMsBNTeJ3xEY9EryoSmQtCiv2riTyq11WtXMqR3AmbUsBI/R8Wt/6MDi8mdedIXBz7MRYGwvKjJvTbwDVPfwdihkfH1W6p2pY7//euUMRIoP3DIBsNl7aBAV2I7kPTcXAnzbBf+vUjUsJYx7TgUkD3Oid9ATMPyHTdWV3buk6CoN9pI+Vutv07c8I9Zi4xm1xh2MRTsdgruHPpvckzPIRqleYj2IzLXqql1qlrCabyjTDF3kRtzyvGiR/u1deoYoQXDpSzj6+VUS2yqKueVBb+RvL7KMqxhpZtwIwcg8mhQ5ad+fMmwIrpUq1z9t21Tw32tW0fIEV+le+CAxGyKLJk08Jyc0sNDa+jYIvsOSgB5jW0vv1NDDfDfMaOfmP5VQnPWAtn+xnZdOLHn9ry3aff8viGXbcHi2qlJvHANt9sXXsN53eOdlTO+N9QmFVKs8YhfKzcr0vITaayW5Zn5qPjeFy/T+dz6Sso0ZYV91CCvgwhmOszvc7r1Oikl+/ynW27sBkDhxrhA8i86I0bRf0d9yQTRKjtdqWxpAco3iahexcAuDiJ5otemmzUe3H7WwB9l1+al36vIzkMZQQXWO/KUIOTL5AQsZ
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR03MB3386.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6506007)(83380400001)(508600001)(31686004)(53546011)(36756003)(26005)(6512007)(186003)(31696002)(2616005)(7416002)(66556008)(38100700002)(6636002)(8936002)(316002)(110136005)(38070700005)(122000001)(54906003)(8676002)(2906002)(86362001)(66476007)(5660300002)(76116006)(66946007)(91956017)(6486002)(71200400001)(4326008)(66446008)(82960400001)(64756008)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?bmpjYnJmS2dzN0UwcUZ5Z3lHa1dLOUF4VDAwWHhYWjhWN0kyMGNoM0pmVlBR?=
 =?utf-8?B?NjNkL291K2o4R2NEc2lSeVJvNVM0OEYwOXVnVnNUZUV1Tisrdm9PS01peVNJ?=
 =?utf-8?B?dGJicTFHRDlHOXBtUWxQQzhpbmswdFRuYUFkUGdtaWxxOW5HdGFIN2I1NkRO?=
 =?utf-8?B?OC9SUkV3M3orUWd3WG1zTERMV2tNZ1pYNGxaOGJuVUhpUTA0dkJDYmJ1VFpq?=
 =?utf-8?B?d3VZM0hycU54SFNtcDJabUZickdscEluZUU1K291YXVrcHEveTZSOFJ6TGRM?=
 =?utf-8?B?czlFUnk1elZabE9GaGZwZFVKVHpSalVsV0cwTHlBMGZRQnFhN0Q4RW5jWlpO?=
 =?utf-8?B?TUVMUHRSbmVtaUJlVkxuVnYzb1phNFkxRjN3Y3ZXZHYreUFlc0JGb3lyZjhH?=
 =?utf-8?B?STVRK01zdVRQaFVUdG5LSndlaTF2Y1Vtb1RvWVorSDJHdUNvUE9KUzM0VEow?=
 =?utf-8?B?UzNHaUsvS0RpZ1FPL21lWUt2WHJ0RmE4aUtmWXlSNjJnME1PczJrSlZCSG5K?=
 =?utf-8?B?RmVjb3ZxYmNXWjZUZnlBdVl1OVZBZmNvK2puLzI3V1AybTJLQjdvaTRiSjlw?=
 =?utf-8?B?OEVIUDJyUFpoa2gveExvblNGUHJ1a3l6SGFKVjk3Sm1iT2sybEJ1VVFQNHBi?=
 =?utf-8?B?U2Z0RUZjSVFCZ0QzNGFJRlRmajJEUGhFeW43WXZxQTg3dk5LVHJ6SCtJYTE3?=
 =?utf-8?B?U1FMcEowU0JOYXhkSWhXUGI2dTBwcC9zeE9Gd0thclBKRCtqNktaZW9lQlFC?=
 =?utf-8?B?dkxEZks3bllpV0syQVBsWVl2Sldyd1J1THpxbmxVaUU4aGxoVE1pQ01CV3ZH?=
 =?utf-8?B?Z2h5VVFlaEFTRG40S3EreXR5SktjVVBEbEo4b2dzOXhvZWM4RnkxWEJYTWZy?=
 =?utf-8?B?clBIVHZOdUhwdkJQQ0VMVGdEYVdlRmgxWmdCUG9qbytRSTRHcEp2SEZadlRl?=
 =?utf-8?B?eHdha3dtTTZJeGhHN1owOTVrNDNRVVR1YlpUUFRaMU1Gb0NiQWg0bnBFWDE3?=
 =?utf-8?B?SUlNN09aVVZ2NmwwZks3QUhuZTRMM2JPNDd5cUl3S2pGSHA2dXNCSHVPM24z?=
 =?utf-8?B?dTRJT0RhYXRhdDk3Q1JFR2dyUkE2cllpVEZpdUdqaWxJamdXK0FlUWdSSzFK?=
 =?utf-8?B?UDg1Znc2TXdualE4YmRPNFFlSXhqRVN3NmhqVTB4MFY2K3ZPSjdWd1NpamdI?=
 =?utf-8?B?bi92M0ppYzd3U0xCdGZPRjdOOTk4QnlWVExrYndsM2lJQVlJWDRCVGtHcVJx?=
 =?utf-8?B?em1sZ1ExUGVHTVN1MDRQbEhqK3FPbUdsUkRkYUx0VHJRZUwvbHR3Qi9GYnJK?=
 =?utf-8?B?OEVVWnlUZGlvWFhwa1VtMDJjVFZlWnh1S2szd3ZBODVOYmJmSGVmUytzTE00?=
 =?utf-8?B?UWZzQ2txZGVKcXgzM051c1U3a0VZb1NqVFhnK1JBMVlJcEtnZEZQUTg0eE5Z?=
 =?utf-8?B?bGVWOG1VeGxobUJIUmJReUVqWVVxbnRiczNLTjlGVmVWWCtwU0xhZENxYVBV?=
 =?utf-8?B?N1AyZk9MQjAxUFEyT0wzckROWlp4TDgyT2w0ZSt2djE0ZkNXNVJJSDBOcVFV?=
 =?utf-8?B?elpwZG5SV0hQTUFyQ1l4Y2F2QURwdllPQ1IwSUJadEkxc09mYkFTcmt4S2Rm?=
 =?utf-8?B?Z1NxUWNFckdlNWw3UzA3Wk9zTDZ2VWJpallEY3dIVElwRTBpazV3V2R6NFFp?=
 =?utf-8?B?WlQyY3NSN0NhcmpxVmhuYkpzMU5hWkR5NmJFVjR5TkNUM0tyRU9lWXdOTUg2?=
 =?utf-8?B?di9mbGdRWE82VXV5MERLOWw5a0lINjFJUURONjlOQlYxYUdHeFpOOFFFSlhk?=
 =?utf-8?B?S0FpRjBWa0VaSWl6UDZTcW9VcDVOZmUxWE1LNVJ5QUVtbUZxQVQwTmJ3Tk4y?=
 =?utf-8?B?WGpxbEdhbEtQSG9ZampnQnVlUnh2QU1jZU9ScHI5SlhtWngyU3I5TzB0VUxE?=
 =?utf-8?B?TkRielBGRWVESmYrNlhQd2FyWXRuNjVXUXhYSmU4bkNUWUhORitFcnRwMWRj?=
 =?utf-8?B?c2swT2xrN2J6NGlOdUIvNXdKSmZSMWNlOVNoRytyR2JqSFdjVWQ5NGFPeTJD?=
 =?utf-8?B?N2o1b3BmazRRclBDR0NvQkdTWUhxT29wY3dZUEliTGhDQk1mZFhGYXkwem0x?=
 =?utf-8?B?NS9CVzRvZmtOa0pDcU5xYUdseGdZTHE1RjhRWGJGWGRkajJvcVNBSnAwK3gr?=
 =?utf-8?B?NExMVXJjelEvQWRYVklvbThIK1ZWR0cyb0xwSS8rZk1zbVE5VE1YSjdKZGJq?=
 =?utf-8?Q?StpJ6xUPFevD4Hsi+wgngAiAR1HOuJt9dVWY2teJts=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <63DE51BE07CFA34AA168BED1E55DB0F5@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM5PR03MB3386.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5817aba1-0bec-4454-baa5-08d9ed4637bc
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Feb 2022 10:06:48.6370
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: UPxkwL6D/P+hSz1/Zib6i13XoYaySkSt9ioF4VEvZkj9+O/MwxDygP2GOTxQED8EvHt1rMl8EWxulF7cyyFpUeY6IrmXRkoTClwJyvOurJE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4870
X-OriginatorOrg: citrix.com

T24gMTAvMDIvMjAyMiAxMDowMywgUm9nZXIgUGF1IE1vbm7DqSB3cm90ZToNCj4gT24gTW9uLCBG
ZWIgMDcsIDIwMjIgYXQgMDY6MjE6MDBQTSArMDAwMCwgSmFuZSBNYWxhbGFuZSB3cm90ZToNCj4+
IGRpZmYgLS1naXQgYS94ZW4vYXJjaC94ODYvaHZtL3ZteC92bWNzLmMgYi94ZW4vYXJjaC94ODYv
aHZtL3ZteC92bWNzLmMNCj4+IGluZGV4IDdhYjE1ZTA3YTAuLjQwNjBhZWYxYmQgMTAwNjQ0DQo+
PiAtLS0gYS94ZW4vYXJjaC94ODYvaHZtL3ZteC92bWNzLmMNCj4+ICsrKyBiL3hlbi9hcmNoL3g4
Ni9odm0vdm14L3ZtY3MuYw0KPj4gQEAgLTM0Myw2ICszNDMsMTUgQEAgc3RhdGljIGludCB2bXhf
aW5pdF92bWNzX2NvbmZpZyhib29sIGJzcCkNCj4+ICAgICAgICAgICAgICAgTVNSX0lBMzJfVk1Y
X1BST0NCQVNFRF9DVExTMiwgJm1pc21hdGNoKTsNCj4+ICAgICAgIH0NCj4+ICAgDQo+PiArICAg
IC8qIENoZWNrIHdoZXRoZXIgaGFyZHdhcmUgc3VwcG9ydHMgYWNjZWxlcmF0ZWQgeGFwaWMgYW5k
IHgyYXBpYy4gKi8NCj4+ICsgICAgaWYgKCBic3AgKQ0KPj4gKyAgICB7DQo+PiArICAgICAgICBh
c3Npc3RlZF94YXBpY19hdmFpbGFibGUgPSBjcHVfaGFzX3ZteF92aXJ0dWFsaXplX2FwaWNfYWNj
ZXNzZXM7DQo+PiArICAgICAgICBhc3Npc3RlZF94MmFwaWNfYXZhaWxhYmxlID0gKGNwdV9oYXNf
dm14X2FwaWNfcmVnX3ZpcnQgfHwNCj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgY3B1X2hhc192bXhfdmlydHVhbF9pbnRyX2RlbGl2ZXJ5KSAmJg0KPj4gKyAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNwdV9oYXNfdm14X3ZpcnR1YWxpemVfeDJhcGlj
X21vZGU7DQo+IA0KPiBJJ3ZlIGJlZW4gdGhpbmsgYWJvdXQgdGhpcywgYW5kIGl0IHNlZW1zIGtp
bmQgb2YgYXN5bW1ldHJpYyB0aGF0IGZvcg0KPiB4QVBJQyBtb2RlIHdlIHJlcG9ydCBodyBhc3Np
c3RlZCBzdXBwb3J0IG9ubHkgd2l0aA0KPiB2aXJ0dWFsaXplX2FwaWNfYWNjZXNzZXMgYXZhaWxh
YmxlLCB3aGlsZSBmb3IgeDJBUElDIHdlIHJlcXVpcmUNCj4gdmlydHVhbGl6ZV94MmFwaWNfbW9k
ZSBwbHVzIGVpdGhlciBhcGljX3JlZ192aXJ0IG9yDQo+IHZpcnR1YWxfaW50cl9kZWxpdmVyeS4N
Cj4gDQo+IEkgdGhpbmsgd2UgbGlrZWx5IG5lZWQgdG8gYmUgbW9yZSBjb25zaXN0ZW50IGhlcmUs
IGFuZCByZXBvcnQgaHcNCj4gYXNzaXN0ZWQgeDJBUElDIHN1cHBvcnQgYXMgbG9uZyBhcyB2aXJ0
dWFsaXplX3gyYXBpY19tb2RlIGlzDQo+IGF2YWlsYWJsZS4NCj4gDQo+IFRoaXMgd2lsbCBsaWtl
bHkgaGF2ZSBzb21lIGVmZmVjdCBvbiBwYXRjaCAyIGFsc28sIGFzIHlvdSB3aWxsIGhhdmUgdG8N
Cj4gYWRqdXN0IHZteF92bGFwaWNfbXNyX2NoYW5nZWQuDQo+IA0KPiBUaGFua3MsIFJvZ2VyLg0K
DQpBbnkgb3RoZXIgdGhvdWdodHMgb24gdGhpcz8gQXMgb24gb25lIGhhbmQgaXQgaXMgYXN5bW1l
dHJpYyBidXQgYWxzbyANCnRoZXJlIGlzbid0IG11Y2ggYXNzaXN0YW5jZSB3aXRoIG9ubHkgdmly
dHVhbGl6ZV94MmFwaWNfbW9kZSBzZXQgYXMsIGluIA0KdGhpcyBjYXNlLCBhIFZNIGV4aXQgd2ls
bCBiZSBhdm9pZGVkIG9ubHkgd2hlbiB0cnlpbmcgdG8gYWNjZXNzIHRoZSBUUFIgDQpyZWdpc3Rl
ci4NCg0KVGhhbmtzLA0KDQpKYW5lLg==


From xen-devel-bounces@lists.xenproject.org Fri Feb 11 10:22:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 10:22:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270280.464509 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIT4d-0005yT-SY; Fri, 11 Feb 2022 10:22:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270280.464509; Fri, 11 Feb 2022 10:22:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIT4d-0005yM-PU; Fri, 11 Feb 2022 10:22:43 +0000
Received: by outflank-mailman (input) for mailman id 270280;
 Fri, 11 Feb 2022 10:22:42 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=dFbI=S2=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nIT4c-0005yG-LY
 for xen-devel@lists.xenproject.org; Fri, 11 Feb 2022 10:22:42 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 898ed3a0-8b24-11ec-8eb8-a37418f5ba1a;
 Fri, 11 Feb 2022 11:22:41 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 898ed3a0-8b24-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644574960;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=vnBS9HMfLyvn7z1o/VlGLvpaq2zihXpPQgNgeqxoW5Q=;
  b=OfSJ+I1DZDrYVex6nQrUoHXWZA5qimYUpcAypxJUI8qlINhlmedPk9No
   oLTlt5NOum3R86Mk0FCnf+XfeF3LTlCzHxIVdE+MbzDffyxewDqoJt7fq
   EmEhRZmChWaNll5WsM4JP5yf9nuNpaK1zNb9Ifei67JmLtEMpD9/qPtRl
   s=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: qGpFwpJNQU4Puxje5MDNNlpCPqWM5dg4scYFXLQjOouX0RS+v93i0MFuelwixC3VoO/w/utrDf
 iF28v7ip5wRqR+1g1oIKpPQRJvWdpXLsyxiJYQxVXNMTAGKZNeDDFJHgGa5fKIHCR4gvFm8mGk
 KPxpYOW8tc53xhQnZ79VJShQsqZD6QDJvscFNyNCIQT5c3ydzG2f4kMPwEGlD5sj1kVICyoOrU
 4WGt/UyKCLNwkKm1yqp55acaTzS/+0Rfj5/ug7BTD0h6vHEBG3xjBrOBsqpEvmVixHutezaPts
 p2+HEHNQmpWFrX7oWywG02vr
X-SBRS: 5.1
X-MesageID: 63908875
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:HSoFmaI+e518GLM3FE+RA5IlxSXFcZb7ZxGr2PjKsXjdYENShTQCx
 2FLUWrUP/yDNDD3f98gPY20o0IDuJ6Hm4dmTFBlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokcxIn5BC5C5xZVG/fjgqoHUVaiUakideSc+EH170Ug6wrZg6mJVqYPR7z2l6
 IuaT/L3YDdJ6xYsWo7Dw/vewP/HlK2aVAIw5jTSV9gS1LPtvyB94KYkDbOwNxPFrrx8RYZWc
 QphIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbrGvaUXe345iXMfwZ3u7hB223PRek
 5Z9paaVclcKO7DyqbQkUklhRnQW0a1uoNcrIFC6uM2XiUbHb2Ht07NlC0Re0Y8wo7gtRzsUr
 LpBdW5LPkvra+GemdpXTsF2gcsuNo/zNZ43sXB81zDJS/0hRPgvRo2Uvo4AjGdv26iiG97Dd
 eRDSQVASC3HOUxxYmcTCKh9msmB0yyXnzpw9wvO+PtfD3Lo5BN1+KjgNpzSYNPibdVYmAOUq
 3zL+0z9AwoGL5qPxDyd6HWui+TT2yThV+o6Fre16/pri1273XEIBVsdUl7TnBWiohfgAZQFc
 RVSo3dw6/hpnKC2cjXjdyL7hFHf/S4MYf9rQ84/9T+8mpPVsz/MUwDoUQV9QNAhscY3Qxkj2
 VmIg87lCFRTjVGFdZ6O3uzK9G3vYED5OUdHPHZZFlVdv7EPtalu1kqnczp1LEKiYjQZ8xnUy
 ivCkiUxjq57YSUjh/TipgCvb95BS/H0ou8JCuf/AzrNAuBRPtfNi2mUBb7zt6cowGGxFAfpg
 ZT8s5LChN3i9LnU/MB3fM0DHauy+9GOOyDGjFhkEvEJrmrxpyP5IN8PumwnfC+F1/ronxezM
 Sc/XisLuvdu0IaCN/crM+pd9ex2pUQfKTgVfq+NNYcfCnSAXASG4DtvdSatM5PFyyARfVUEE
 c7DK66EVC9CYYw+lWbeb7pNgNcDm3FlrUuOFM+T8vhS+efHDJJjYexeawXmgyFQxP7snTg5B
 P4Ba5XUm08CDIUToED/qOYuELzDFlBibbjeoM1LbO+TZA1gHWAqEfjKxr09PYdimsxoei3gp
 xlRg2dUlwjyg2PpMwKPZiwxYb/jR88n/3k6ITYtLRCj3H16OdSj66IWdp0We7g79bM8ka4oH
 qddI8jQUO5STjnn+igGacWvpoJVaxn21xmFODCoYWZjcsc4FRDJ4NLtYiDm6DIKUnisrcI7r
 rD5jlHbTJMPSh5MFsHTbP7znVq9sWJEwLB5XlfSI8kVc0LpqdA4Jyv0h/4xAscNNRScmWfKi
 1fIWU8V/LCfrZU0/d/FgbG/g72oS+YuTFBHG2T77KqtMXWI9GSU3oIdAv2DeirQVT2o9fz6N
 /lV1fz1LNYOgE1O79hnC79uwK8zu4nvqrtdwlg2FXnHdQ32WLZpI33A1shTrKxdgLRevFLuC
 E6I/9BbP5SPOd/kTwFNdFZ0MLzb2KFGgCTW4NQ0PF7+tX1+87ewWElPOwWB1X5GJ7xvPYJ5m
 eostab6MeBkZsbG5jpesh1pyg==
IronPort-HdrOrdr: A9a23:mizs9q75Fl2mzmw1zQPXwPbXdLJyesId70hD6qkXc202TiX4rb
 HMoB1/73TJYVkqOU3I9eruBEDiex/hHPxOjLX5VI3KNDUO0FHYSb2KhrGD/9SPIUPDHkg279
 YFT4FOTPnLSXhgjdy/xAWkG/sp3dHvysqVuds=
X-IronPort-AV: E=Sophos;i="5.88,360,1635220800"; 
   d="scan'208";a="63908875"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=BGAoW8aepAI8t45cibvzsVa4OB0EvZVUYWadpDkikcWPxsL/xkkGPWWNF1Wdu/Gu8C4vKbjJFVhjnfmcIWmjIPfa6zJ2q1f11QJ2RqIHUtwWiEXvBKTtAvCdwwvlR0+eKDURLNBu5QLlYys51NYccuGaTbt0Kd/UwHFNbwfMpJPHTtSFTcpdUaTHUUv2XmStn7JS3H759MzQdQMISI4PBdghy9nJF7ZnIQvtHOr1mnJE9Zj9g07ZGsZFYWWp3Wyt16AWS85VPHfdpH+TtW3E1nIi3OS5ujpqyPntjOTu02mwePWLVxTZ6mv6wLMazlXknxeGzL7CMXh/i/CdirPGwA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=M2z+UpBgPwg5bYg5mejRY+EeYHpt04WkYh5f3MMfUuo=;
 b=Y3XAtTu5NAQj7L4PveuChsY2d0RuIsKrS8WBa+H7dhXHES9qa65GRgOf3kiOQjCO3YtK8zemPIF+F2PjEGpfnWzH6/eNb1TT7ph+lAZsUftyB5dpr03F0c0jHT9LFT0EohZ0PSc3ix9PV86Rp0fX9v9kDwmT7Z23lE89XagNDhrc0rCeRgp4kd99XVJlIHfH8MPP1/sQKgw3CkUUx7Kpef+P4JEdEMnEMHxhOGpY85L9b9SMPxdOo9wA2hv8xhm6fpRGa+wIxocRPIn91essPx7Xk0ndItjdyB4Y+BhklLHUmPAaEGQP8bkDZkjyfC6qMoQCdc+I5a32aaggF3Zprw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=M2z+UpBgPwg5bYg5mejRY+EeYHpt04WkYh5f3MMfUuo=;
 b=oSTMyjYz9lYtUcGVGULNDL1ooeBJuXKzb7Sr8G4ugfv2kM1irKX0e5ypZxr0KDZhAiFM1BdQuOkEb8HJNf6oGMTYNhDSHdAeP1DaL361aKRMlH+bTD8xkxon/b/1G1LcfVQ1nqySfIIdeWWDNMKFtN4AzSf+xXyfaboy8w/z4/g=
Date: Fri, 11 Feb 2022 11:22:30 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH 3/3] x86/Intel: also display CPU freq for family 0xf
Message-ID: <YgY45kBkFFN7ZDHd@Air-de-Roger>
References: <5d275d7a-7751-af19-db4f-d91e3592d30f@suse.com>
 <58f81931-cb7d-1710-4f52-380c8f880156@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <58f81931-cb7d-1710-4f52-380c8f880156@suse.com>
X-ClientProxiedBy: LO2P123CA0021.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:a6::33) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2b9e355b-934d-4d56-0cc5-08d9ed486b92
X-MS-TrafficTypeDiagnostic: BY5PR03MB5048:EE_
X-Microsoft-Antispam-PRVS: <BY5PR03MB50488408F4929AA0221CB0D68F309@BY5PR03MB5048.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: M8NjY91SOuFxvJJgOP3IEud1mkZk6Od+AE/ig8Sou9XVCcMVB+asp2xYmbSqaHS5EUzG8SCfFKJcYsFkojPu7NrvZHoxCPagy7+SWyKvNo5qZQSU5Bfh0y+ms/cK7r/frfUCO/jYM2g+SfYRVtugelIes88z1o5rRlSlfVIo2CpMYu+ar1fFbPAeu8rf9EHCthT8AxK6IhDys0IBVxOikXi4INYBEpoA5lLeOq6ZlooYTkZeteqkZErBCwW9ykqwMcbwe5kCB6XQhSJW2rRHf3rdQkLN/RoQdXlKkpwgHdyaDYQZafbIh/4XZ/p70pqKDFR2xsJFqnbBt/ruy3Cp8j3O4urqBiKn+URFmqfVjJXOmcUsnTXNqryEYdDjLOcsCMiV+FvoC+gHztr04maVpObhVm/CjsaP71aWd+ZAkFmDOweSr23KUwh7uVLW+T4x7DUAX0VbEFWeRTyu8iJY17jxMDhs/yD6n5cpb03lD5BXmlLgY9OJ5ZB1SwVBgi0FxrwVskhnROGJPeLL98FHMqjCmpqcuR7mAJKFgBRKiFyo4/JyEjm1cpzq7ScaBhjwH+XkcysyJSfG2lWdnkb/crmKbyv5hsJC8GIew1cbH3oF+G4p28jEwSGdt/zoOSJVMiplBfm/L1r31lsXLB9Afg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(85182001)(2906002)(33716001)(83380400001)(26005)(6512007)(186003)(66556008)(316002)(54906003)(6486002)(8936002)(508600001)(9686003)(5660300002)(86362001)(6916009)(6506007)(38100700002)(66946007)(82960400001)(6666004)(66476007)(4326008)(8676002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?akFCYSt0ZXpoM0FlVGl4cVpmd2lxdGw3UXFPM1J5N2hYMy9Hb2xxNFA2d2xX?=
 =?utf-8?B?L0hRUW1VNW1PdFpaQllSVTV6UFJvSjh5VHRhbFZuQTQ2UWgyZ0FLRzZLODFF?=
 =?utf-8?B?WnBPbW5XNTcycEFQYmsrL0NIRkZEYW5ZaVZ3dVNDbHN3UmhwaTZXMlVKRVdF?=
 =?utf-8?B?MXFHNE9Nb2VDekNBRFlsWU1MUkNOV1I2Um8wcks0N1Rwb21YSHVOLzV6dzUz?=
 =?utf-8?B?RDZwQTRwc3dDdmVKYnlHZ0pvTVAyMlRZUkJ6RXZLQVhiYjJxcW1IVEZRZ2ty?=
 =?utf-8?B?bzhrUkl5Z0ErK21LeE1senZxbEZwQUtrSHZIYjM2N01aYXk3R1dCS0xMRlJL?=
 =?utf-8?B?QlVaV3l4Y3RhazlRU1Z3QlVYZjY3ZWcrQ1ZVZXlOdm9JSXc0L29VVHhOTFdt?=
 =?utf-8?B?a3l0clkxd3FTZzNvbG9NeE1PbGxnUm51bjg0Y1lNUG82RTEwTDNoNG9rOGFk?=
 =?utf-8?B?UWhiRXRKQTQxS0NBMGF0YW5CdGtUSkF4bXRsSlBqaVN1MFdCWVpkZ3dtZnlu?=
 =?utf-8?B?Z0pWWnNiT1BxRGhqZGpTRklENy92VmFiQitpUlBaMXR4Rmd5RW10SXdmWGty?=
 =?utf-8?B?SS9NSFlHbHp3eWppRzdzSWdpMHlzcnBjYnpoUnRTUWVGL2tUdDFrdzBqZmRi?=
 =?utf-8?B?SVdzTzJFZkpPek9sekdjeEZLZnhuSkZPL0pHWHYzWCs2S0d6aGt2UjQ5a3RC?=
 =?utf-8?B?MHkra3J5UHpVaTI0c21mSzJJVW9aQWdmaHpQMk1CQmJWVTZlWCtRL0R1WTl1?=
 =?utf-8?B?anpxTzFIdDI1YWtrM3VSODgreXpLRnI4REZIZVF0Q1JVYmNYZUxXZWtmc3N5?=
 =?utf-8?B?cFNvUDEwaE1BQWtDb05Oek5VTytVRXg1aWlDc0FLZkh0MCtNTUNaMHAxWlk4?=
 =?utf-8?B?YnBUT2xnZ1RpaVU5WnBqcG15UVlLaFBSZUY3eVBoN003T0I4VWJJVXdjM0pC?=
 =?utf-8?B?QjNVY1F4aVZ1UmRvaW5Hc0kxb204QS93emdTdDlhSU8xVi9RNjdaSVJRUXdr?=
 =?utf-8?B?WWpkNkQybFhxeTM0Yng4YTZ0Z2lWeExYNFJlU1lDSFpwUzY1ZHhMdDBFSURi?=
 =?utf-8?B?Zk9DeHMwOVFQUTdzNmpWNDVoR0VHSVk1ME1ZUWNpNllDKzAyOGQwTnZsVVJL?=
 =?utf-8?B?U3JudzVWRDdlSmZZaENoK3lyMWFoZ0pNVlhtTWpnaGR3d0g3ZTY5bENaRURZ?=
 =?utf-8?B?K3B0VlYvKzBrMU02VXlIeXZmZG9jOE5nbGxnUnFZWVlMSE9mOTR2WWZTWndC?=
 =?utf-8?B?VjVaNmlyTUtZS2szVzdOR2NXYmExTFkzeW45b3dHVVdmZ2NRVWp6U2lzU1BL?=
 =?utf-8?B?OERXRWxpRVNEU3VFM2FCVW9JNnk1NHoxalNMTytTMXJoYVdtK3I3RXRiMk8x?=
 =?utf-8?B?dDZhS05xSllzTFh4eTN3d1VzRUcweXdnYVNUOUdFTkEvR2dodnZXUE1NaFo2?=
 =?utf-8?B?Myt5Z0xKTGoyM2ZRdUcyc1BUTXpvTU9STFdWL2FTNTlCdTNwdW00Z2xxajR0?=
 =?utf-8?B?UzE3K0R5QkwxT05TbzBYOFhqL0dOd0ZTNkxGUFh6V0FaajZtZXY5alpCdmZR?=
 =?utf-8?B?cXlsNXBualdIUktTcXplSFB0UmVWWVdtTEJoeThkV2pqaDVKVUludHlUendh?=
 =?utf-8?B?Z0ovbGhTNHdFTHJBZjM4dEt4bHJhUGRPbFpXRzNCcnJ6SVA5cmpCM21hbVFW?=
 =?utf-8?B?ZUUzNnBVc3Q5dnBsSHZZREZRaTgvZWJ6Sll5ZnNsMU84OHlsNTNmUjhLWGxZ?=
 =?utf-8?B?RllFZHlrWjFXSG5TMFY0a2dSZnY2QUpGdmZHLzNQUXdRdEhrYkNtWDl1Y2Iw?=
 =?utf-8?B?L0ZLZ090dS9pN2ZEalVrWGpGenNjTkJtc0dsQXZuU3NBNERralVKVU1nUXp4?=
 =?utf-8?B?dkQyc2pHYnNMYlB2QWhOS09pYjZ1cFNYTW9GNTA4Smg2WEZJWmdEa0lXeER6?=
 =?utf-8?B?UThKNzVaVEx2UEd1aU9XS1pHTXZEN1JHVnNyaFlnc2FVRW01blFkL1BBMVBB?=
 =?utf-8?B?Zll1OXIwYUZxMm9uUEpRdEJVR3dxOFFzOXJCWHhWNTA2V2ZHOWViMjlUd1hK?=
 =?utf-8?B?NkNTcEd1cGUvUXY3TXA3UW1tcVZnVjA3a1c3alNBbCtCRC9vbEZzOW5scVFR?=
 =?utf-8?B?RGNSNzFWMXFjMDhzUFh2R3Qrb2FxVGFZL0ZjdGx6VzVyRU9PeW5rd3BsdmxL?=
 =?utf-8?Q?gMYitq9POOZP1k+GnqLip3Q=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 2b9e355b-934d-4d56-0cc5-08d9ed486b92
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2022 10:22:35.0765
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: U/p3cjkG1j0tFwIMXxdDkuo62fU8a5T1DzqyQ8VEzu6Be+XGFC6mxchc6pmcfhAPudysmsxwzm7liY4Va9IrVQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB5048
X-OriginatorOrg: citrix.com

On Thu, Feb 10, 2022 at 03:56:48PM +0100, Jan Beulich wrote:
> Actually we can do better than simply bailing for there not being any
> PLATFORM_INFO MSR on these. The "max" part of the information is
> available in another MSR, alongside the scaling factor (which is
> encoded in similar ways to Core/Core2, and hence the decoding table can
> be shared).
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

> ---
> The inner switch() is left indented one level too much (and with an
> extra pair of braces) to limit the diff. I'd prefer to make a follow-up
> patch reducing the indentation, unless I'm told to do so right here.

I'm fine with a followup patch.

> --- a/xen/arch/x86/cpu/intel.c
> +++ b/xen/arch/x86/cpu/intel.c
> @@ -412,9 +412,9 @@ static int num_cpu_cores(struct cpuinfo_
>  
>  static void intel_log_freq(const struct cpuinfo_x86 *c)
>  {
> -    unsigned int eax, ebx, ecx, edx;
> +    unsigned int eax, ebx, ecx, edx, factor;
>      uint64_t msrval;
> -    uint8_t max_ratio;
> +    uint8_t max_ratio, min_ratio;
>  
>      if ( c->cpuid_level >= 0x15 )
>      {
> @@ -455,21 +455,22 @@ static void intel_log_freq(const struct
>          }
>      }
>  
> -    if ( c->x86 == 0xf || rdmsr_safe(MSR_INTEL_PLATFORM_INFO, msrval) )
> -        return;
> -    max_ratio = msrval >> 8;
> -
> -    if ( max_ratio )
> +    switch ( c->x86 )
>      {
> -        unsigned int factor = 10000;
> -        uint8_t min_ratio = msrval >> 40;
> +        static const unsigned short core_factors[] =

This no longer applies to Core models only, so I wouldn't be opposed
to renaming to scaling_factors or similar.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Feb 11 10:32:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 10:32:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270289.464520 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nITES-0007UV-Vj; Fri, 11 Feb 2022 10:32:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270289.464520; Fri, 11 Feb 2022 10:32:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nITES-0007UO-Sg; Fri, 11 Feb 2022 10:32:52 +0000
Received: by outflank-mailman (input) for mailman id 270289;
 Fri, 11 Feb 2022 10:32:52 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=jrYj=S2=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nITES-0007UI-EJ
 for xen-devel@lists.xenproject.org; Fri, 11 Feb 2022 10:32:52 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f6ba95f1-8b25-11ec-8eb8-a37418f5ba1a;
 Fri, 11 Feb 2022 11:32:51 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2168.outbound.protection.outlook.com [104.47.17.168]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-41-YUS_j6aIOwOyjP7W1IYgWQ-1; Fri, 11 Feb 2022 11:32:49 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM0PR04MB5841.eurprd04.prod.outlook.com (2603:10a6:208:132::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.15; Fri, 11 Feb
 2022 10:32:47 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4975.015; Fri, 11 Feb 2022
 10:32:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f6ba95f1-8b25-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644575571;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=3a8toassrk+o4pEn53Vk8AUGP7ODNV0t++fUQbMYsGY=;
	b=LKh1XvAq7Awz8hLhCwkOTbGBS4agfopHxrtB6emjJFLxDUXQ6SDv4RWS0f46Rb0LgpGBWG
	/HDTROefi2fd+/2ux2lcfywgFTJK/JqeGZ/zJNiavgKn5CJ6/tPX9fUS3tfrCjO8/5svgV
	7m5MxR3aXW4IlpZs6ltpqKNOmlGfz5U=
X-MC-Unique: YUS_j6aIOwOyjP7W1IYgWQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=AP+CBEKUqK/3/hgDre9oJrfLeaQl/ifAFC9qsOeePfMaZdBYKAbvOab5WpuKETyk0mwmOBJObfEI8oqI8HlOfPIn/cZiWbdL9Wril0lpABrneuE9BwU3j8uiBunD20KcVLilptQ7H4uQH26mYcjJ8ui4K0p2p2gCLVtX6py8T0D7pItoU52Xh8ed0Iw4If3PoHOKaJEo855nSVc/nLgFkY66vn2PEbILjg4e5J7QHDtJGN5vfraEYFtgBruKf3+4m94nK5Ly2+yzAntJCmp7rPEbjDRgNfmjon7tuwN7LzUplMkwtCmDb/mHu9nLB+bXYAZOtLRY8bsWWyvkRRGJ/w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=jhbg54gqM0f1OEtfeuuPPbEtsbc8QfwX5FkxtUnbRkE=;
 b=ZMkMHzYetU/kKAfq9nmvH9IPEjBdc0AUdvmFan6p0B2QZrAOnjs3K+492VNTo1nTbIIvLumxn4z6eo2Ir6n0JvM2hl6YU7MjqHAbCIj/r4RY7RzdqSwJu+RbVocFhq0yc8zT1BSWv3I6GMEtljfW8blaFp/Oi4wH42aj9/3+kFgObxCDsiB8YCgmbwk0KWBhMvVzpucQVCE4Hxmd3pCucwByfSjsJgQwquM8yrHLvS8XEWOfosn7hfbXCQZJZhtDaUWULJFM9KC1iWmWUmGftppL6uXBsOcltQlhH8594xh1OMiXNbWVwWz/CX4VCib2xQKA0ouMJYKgMeLex0uzSw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <85182aaf-1d3b-981a-1108-8eed79516893@suse.com>
Date: Fri, 11 Feb 2022 11:32:45 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH CPU v1] cpuid: initialize cpuinfo with boot_cpu_data
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: xen-devel@lists.xenproject.org, Andrew Cooper
 <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 Norbert Manthey <nmanthey@amazon.de>
References: <20220211072327.1213-1-nmanthey@amazon.de>
 <YgYmKiZaX2vZYgKP@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YgYmKiZaX2vZYgKP@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: FR0P281CA0058.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:49::19) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b453c06e-1abc-483a-5a5f-08d9ed49d8ce
X-MS-TrafficTypeDiagnostic: AM0PR04MB5841:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB5841F5FA74399C0B745333A0B3309@AM0PR04MB5841.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3826;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	NdPPOvNcU7tvZDGPuDg6qDRMA8m008uqk/7wySmNj8rP0wDdUiYyGel73Ie1Fxx7XW2Urss9b+iiq0kKskSBUX7fVOAzOy6D7OB9N9RQ+jhNPCqtHcD2DAxYnWi+/b4qT4bFPzIzzfSP1xV5I6i0w9hIm/llL/Ym5fWIHEZLNkbaO42H8GUXeCpP9Atxz2x7JK+wT+eHaAjI0JATuW3/1FyH3HNnKMee1BJ2TotwL7ql2QlzURHxL7eVjUeHySIkVF8DKbuxtyL1D8lVpJbciKdOlJhTzmVUpT3H4yEtazhNpRxh8z8RQf5s3udS8fffIIMCTO9fNQXKdlktEZ44GK/VuSvA94sMcLgTj0V0AZeTRnDCErnlBkYTTC+yiiCDh9XPiqNsF1uPtnomi7lmdtj8/wk8GEWpVZdTr9twBnE0SsQWBBexSNHx9EQuAyicBhvqcdttkW7A2mCCvGRkraSe/752btBw9ETkJTtZhY/eyJiL2slNyiIxAZ7miq7pMhe4k7Pu/NlnMBjN5CmFJQh1PRfB5p5IsiEleoFPtPW83eDnmImS3rNUhUEIZ70i4fh0wScHkAeF0HeN8SokQ5p+qn0rpRWFP49uOufV+8DiiRGT8NynCkedoWrj0GWD3QcDfWzRFZeVOpvRzOIzwALwRyIJTAoreH8JOFrmzv/I2Il4ibnFGIEZEc5t2rK4gtfBXaZ0tAMXe7CvAPfDdx/ADIlfBZOJAbunW5v1Nxs=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(186003)(26005)(2906002)(8936002)(8676002)(6486002)(66946007)(66476007)(66556008)(2616005)(4326008)(86362001)(6512007)(6506007)(53546011)(316002)(38100700002)(36756003)(54906003)(31696002)(5660300002)(508600001)(31686004)(6916009)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?ICMGhaQeBTzp9ZoyAtI/THsql28fJ1LeHAe97Ani6hQauRu/5Ds+mFRoDVoV?=
 =?us-ascii?Q?Po2BjYphss7wKsLwdJZcYLDqLVS6U2lNcMQyYFJa1ghMT9QMaIMoD63GP/N7?=
 =?us-ascii?Q?Bx0TiTn5XYACI45Xdoc3d2JJDcWTq93wpHOIFcLQ1Km9pn/jvTNzXv4yH0gV?=
 =?us-ascii?Q?aKj6M8UAqo0wpvxSO5F9LSXDvsP9+hNMHKrGpEx7whx90LNmSktTf78NbzfS?=
 =?us-ascii?Q?sa0bzulHzOPbPY78NlBd2HLa1Fjg+7GmPdYrjBs7h2h/SoZKp+k66Q3mkkT3?=
 =?us-ascii?Q?yeJLVHlPxQ1Sfvy48UUggE1S/TE4Oo3l/D4JXm27jOVINpvuNrGquxwkR+To?=
 =?us-ascii?Q?By9BxniwkXTPg9fCIx1Dtf7vmBBfTourVZ6+XUs1C7MvlE5FBWdWjDqWQLwH?=
 =?us-ascii?Q?FsRxN5xqBN9mxDE3K1rusmGpzNNB963YElt4L8BY5TxTqJZpkPaxefKLme5x?=
 =?us-ascii?Q?lrXZUM4ppemGMBw1+igTSgIn2AHyONKxQ8g0KfROeysDS4CaqK6IGgaVi8rz?=
 =?us-ascii?Q?ACHW6ZiyYwXgR4IrGT8AkZVKxRfFUH6/ARyWtd+XT3yq/b9UHbwK6WGuiIZp?=
 =?us-ascii?Q?opgDd39uFMFipx+MtxFCkUWmBzT/+ia/P8edIH+uWO0BV2vsr3p71/JD8Au7?=
 =?us-ascii?Q?aW6jMAbciz4SAOvcrY0bepE3GEWjJDB0LAJO9ZoTfQ/G0zFfhpF09Vxc4DFK?=
 =?us-ascii?Q?hWzfI+U6HSUjxoMgzxcIkt35d+PpQE2eR37IN39Smn7kgW2rbvjnbprF63XB?=
 =?us-ascii?Q?zaAFtGq2eSp92VTnOFbi31ncusz1apqT3cc/zpp2cNV2N/VuBvPzGuLU/gVN?=
 =?us-ascii?Q?Bu6/Q/RmJbbbk+qX092Xk42dkldBrclKpfUsoPKx+T4uB74W2IhVgM/3XRNq?=
 =?us-ascii?Q?NrKSfyVKiweUYzIfnFd2keiNpaKbVzUCqpA8nVl8+8jcWYuR3+tE7KZg43wY?=
 =?us-ascii?Q?S7ootHtqWn4w6JAhfA3Be1FhnRNRbNwhdrptYWt0BjtAK/E1U5gwfURctuo/?=
 =?us-ascii?Q?O2qmVZsnduJcvN0yineDEBNAXZUc+GYgMDVIMkWmlO40JBdQqHZxjDKgze5s?=
 =?us-ascii?Q?zYK6UeELSlgs6M5VXiy9RBsz7wdhcFq84Xd0aqDL/HHCNs7Pr3qrgAvFtqcH?=
 =?us-ascii?Q?RPzWC0s5luz+FAuZ86H0iNGHjHsy6KDERev/m09L1W/5dm4Ddl3x3KZrwIWz?=
 =?us-ascii?Q?+WOFiExTJum6FVawVS934HUBsVO58C3BoX2EPHFTS0F1zvLInD/bV7df2hA1?=
 =?us-ascii?Q?OAm4WXBVclGqkpQEzHB2QdPXSRFIiidxEka7zLLeBeLJSOOdud5P8vuPp53m?=
 =?us-ascii?Q?RbUbCH1HuhGNhDZ81AkcKyU7eXZ4JvOgNMmFP1fWJlgtyB50gQmoPyjp2Sr/?=
 =?us-ascii?Q?pNwx19rT9Q8ArvbqxXTRXljTUHnvSspiNjX/aVnKIzowCM+d6gHYjAkfy/au?=
 =?us-ascii?Q?mbcaNmJxL3cW/nHYLlAleSV3ztZEu/3nQMi9N0zGH3LDkrbbyXPQOhaFAh9h?=
 =?us-ascii?Q?nt40qfyz+eiAmf1u/JnEqjPWOf4Faecs5vToctcaW6GGZrAx4KLJg3q3JK1Y?=
 =?us-ascii?Q?mF0ErO1bo06s4qDbtW/QeeQu/ExIhKh4M/5ysPsTWzfNeYeO55aRlk0XUdPa?=
 =?us-ascii?Q?OpcAk0nCYPXbHYIjARNlj24=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b453c06e-1abc-483a-5a5f-08d9ed49d8ce
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2022 10:32:47.6683
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9owi+Iup/gMclTkxmE26ToNyhFVOfIxvkd/+Ez123vdHAZYpC+/j1KiutS/qGiSwLNqwAzLU5imGtcPSQjpfMw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5841

On 11.02.2022 10:02, Roger Pau Monn=C3=A9 wrote:
> On Fri, Feb 11, 2022 at 08:23:27AM +0100, Norbert Manthey wrote:
>> When re-identifying CPU data, we might use uninitialized data when
>> checking for the cache line property to adapt the cache
>> alignment. The data that depends on this uninitialized read is
>> currently not forwarded.
>>
>> To avoid problems in the future, initialize the data cpuinfo
>> structure before re-identifying the CPU again.
>>
>> The trace to hit the uninitialized read reported by Coverity is:
>>
>> bool recheck_cpu_features(unsigned int cpu)
>> ...
>>     struct cpuinfo_x86 c;
>>     ...
>>     identify_cpu(&c);
>>
>> void identify_cpu(struct cpuinfo_x86 *c)
>> ...
>>     generic_identify(c)
>>
>> static void generic_identify(struct cpuinfo_x86 *c)
>> ...
>=20
> Would it be more appropriate for generic_identify to also set
> x86_cache_alignment like it's done in early_cpu_init?
>=20
> generic_identify already re-fetches a bunch of stuff that's also
> set by early_cpu_init for the BSP.

This would be an option, but how sure are you that there isn't
(going to be) another field with similar properties? We better
wouldn't require _everything_ to be re-filled in generic_identify().

Jan



From xen-devel-bounces@lists.xenproject.org Fri Feb 11 10:35:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 10:35:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270296.464532 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nITGb-000851-DS; Fri, 11 Feb 2022 10:35:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270296.464532; Fri, 11 Feb 2022 10:35:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nITGb-00084u-9Y; Fri, 11 Feb 2022 10:35:05 +0000
Received: by outflank-mailman (input) for mailman id 270296;
 Fri, 11 Feb 2022 10:35:04 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=jrYj=S2=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nITGa-00084o-6o
 for xen-devel@lists.xenproject.org; Fri, 11 Feb 2022 10:35:04 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 45194c67-8b26-11ec-8eb8-a37418f5ba1a;
 Fri, 11 Feb 2022 11:35:03 +0100 (CET)
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2055.outbound.protection.outlook.com [104.47.1.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-10-SNc-5iT9ONypeaEG8Vhh_Q-1; Fri, 11 Feb 2022 11:35:01 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM6PR0402MB3512.eurprd04.prod.outlook.com (2603:10a6:209:11::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Fri, 11 Feb
 2022 10:34:59 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4975.015; Fri, 11 Feb 2022
 10:34:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 45194c67-8b26-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644575702;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=XBxIgWuFIZ4NRX8iR9jLvUoZxw/GDZu4YlYw4MoH5N4=;
	b=EBEV6kyo3gPVaGCV5bv8iZK3lRLBlL7NjDv2uxfaJMcdJmFMLI+/GQb7N11RkRbIxcw0EW
	Fy+HzJkAzOd5MdjvvwpomYuu/MI0XEISUXUBC0OzJsXYPEygnhOiSPxVW8RTTAT4H2OIYJ
	eCpv+fDy+qmdMIfmJcgaOpJpak5BTpg=
X-MC-Unique: SNc-5iT9ONypeaEG8Vhh_Q-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=NiiK29wtUtO/CxX+MeHBYQJjvIUXNtHoDhL+ch7LqkipoNTKX5+Q+mC3kOTtBvF12D1URck67BArWy4h/GHWdnKopTAHZXH8ADS6XP3qFrb9rhtID1YB4f30uxZDBC4wXfJ+rLkRRqmC4e1CPQGxLxMA63Y/LOGCxhgidwo4+X1k/IMM60xWmes/gUmcSHhTrDdJLCYVfwEggmm1PRN0FnZVNENZkH9+OwERyWEuOcqwKLZILYev/3A56Vmgi3Jb1NPej6LGDR/7l2oqJrmD0fpGlQ1FBr/VT3FHA8sco1Et/XEkhxJrB6eDpGiDii5KSVsvjgpFr9L0Y5+YBYojmQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=XBxIgWuFIZ4NRX8iR9jLvUoZxw/GDZu4YlYw4MoH5N4=;
 b=exSN2sNyRamPX18f+xZ1VmxCdV6Vn2Az8QcR2sIVsLpjCyO2rzufrfCpg9m3jxSDg6fECPmLQ2guB30AgXqLknwLMHDg6b9/qsR3oYMjwaH3IqGGTjDqdX2w3e8fnBFC7fkVhkoDBWQeC7jf63wsD/fwSjU6HC+DbHjdMKRqKAmJoHX0IcgeqsQEh3RJAd5NljXSFicNs0LqIfZmb5hctzVW9NuRN0av0fv6iuRqu0FSw/ZcuP12VUV6zuiRK/g1OPWjbgBNq5sEby4lZVFQ3QXNu+HFK0/+yy/qIVsCuA2t348Gt5OYRL35R4QrSMre5F1CVoeUFQA1B/rWW0ieGw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <c10ec679-258a-f983-7c5d-b9f536b7ca26@suse.com>
Date: Fri, 11 Feb 2022 11:34:57 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH CPU v1] cpuid: initialize cpuinfo with boot_cpu_data
Content-Language: en-US
To: Norbert Manthey <nmanthey@amazon.de>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20220211072327.1213-1-nmanthey@amazon.de>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220211072327.1213-1-nmanthey@amazon.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P195CA0014.EURP195.PROD.OUTLOOK.COM
 (2603:10a6:209:81::27) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a0425470-6430-428d-a22d-08d9ed4a2767
X-MS-TrafficTypeDiagnostic: AM6PR0402MB3512:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR0402MB35128B5C85C2AB988197F705B3309@AM6PR0402MB3512.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4714;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	IPiEM/syVm6O2pKgfb1U+d45atCZf2KeaPxwf7B7glmn6Sv0zSbOg+Mk0WYglCJseIZVntT8v7n5jplCTjB0+RWvGKOENnfL4OskOxQqudaNsVH7Ec5VKvVqYAeSVTrD2TtJz3SJPisQ8KL/knWYBqktZ4SofGl9SNtglI2uzfdadc6Di80vO0x0mzGBT9QM30mg6bXkWmYiRvwU9WOifDKaO4nra7nNTM1/X5eEeMuEvbHg5sC5CBp614Q0wPe625wSlI1znlpTLXuFSt1SmPr/5p5AnaxqHW8kB/bEQ7nWzSv8ze/hkg+to+BrKW/FeKUIqT6mgNWBhQJZcxNUi1cOYzN7XIqlSvdSakWew4947FFRNClLofzNV0KHu9EyHTiQUkyGcohyccHDolJm2m2epdU7IP8svsCvsqCzvX54jHEqAUVpHQAHtrkAub2DZ66sl/ZcRpjAPb7kTD1Zkx9brcNdV+gj6gO0/UUFP9WuPtHCoXNKfAOnsny4IWkxH7vWn6YVQwnwXQkq8yEFVwvngrLFfa6o2D/pdJxRSWlbE3geJnyk+EiiGsdI0kM3nwhKt7OtKkLJqUuRhSIHQ1wzD9xMc0rqIlraxHW4cZqBYhpjoVrG05k3Xq1YK0YU2TlIMbkvZsCq1qRLU8InXwDRhUnRg7gfp4BD8iHJ7C8aBXO8+lbARkJhW3mDvoqZr5/ONLYpH2t4bUegv+082k/cHT1x+J0OjIWs0li/HNbKMqEsKRQVabZ2ShS4xP7e
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2616005)(36756003)(31686004)(316002)(4744005)(2906002)(6512007)(54906003)(8936002)(6506007)(8676002)(5660300002)(66476007)(66556008)(86362001)(66946007)(38100700002)(508600001)(6486002)(31696002)(26005)(186003)(6916009)(4326008)(53546011)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UlZHZlRpUUtRbElKMU9PTTg2RUdnbzJ4blZqamI2QWR4OHo2aE9weXQ1MUlH?=
 =?utf-8?B?WDYrZjBtWldobE1zNnFjWExXQ09vSWpIa0c3R3MrRTRwWUd5OUlvcE9keEdE?=
 =?utf-8?B?M1ZBd3liZzVnMWJXVlpSLzAzZ0k2K1RaZ0dWSXZpWlBVdTFEd0ZjaTZvVGZU?=
 =?utf-8?B?U2JVWklidEIrdVZzM29Md3pQMjhockFwOG44a1Mwck5DWVlVeHBXdzJPeEV6?=
 =?utf-8?B?VXBCVWVpR2F1YVBCZCtMdXg2NENUbVVjS3JqRDFxTjNsL0dDMTFnNjNqTkVu?=
 =?utf-8?B?dkJwZ3p0RVQ1OEwydmtQZnhack1ZRkRZU0llZWtHcE45VnY3OEVPSFBzYytm?=
 =?utf-8?B?SXNOYml2VjZLZ1UyeUVoU1ozamUyVWhaWU1KcDVhc3lYbGRqR0dvMUtEb0ZR?=
 =?utf-8?B?d3IrMTVLakJQL2grM2FoZ2ZWSmNRSlFsRmMrQ05HamVYd3BESUVpYytmZWU3?=
 =?utf-8?B?VFRBcHJQd0FKVU5pakFoRS94anF2ZTZtRXFaUWNuQ2dlcjJKaDI1Qjh1QkJF?=
 =?utf-8?B?c1ZPZFJ3WWpSS0lad0hEVkVRYTM4RGVEVGNRWUNTeTN1K1puZXFFZkdQb21O?=
 =?utf-8?B?QWlxcEhJb1VVemdZQ2RZMU9UTlMvOTRCQWJ4WXBmTTkrWEVWZnBDUjdMa1Zh?=
 =?utf-8?B?bWdnVWtrUHhzejdlTm56ZXZDOW1LOHMrWXNjZ1d4VFBRWmlSWm16bjNnWU4x?=
 =?utf-8?B?VmZYRFYvSkU1UHM1cTc2cEhVYzQwQ2RxZW1jZTJIbGdsUGpxNFRPN2NDTmlX?=
 =?utf-8?B?RjVNSzZML21GNXRTaG9kRndPcnZLMjhjK2ZQV2xDQjNWUEt2cmVoVDZkRk9K?=
 =?utf-8?B?Y1d4dm8rRUdwcXZGdUZoQVkzVGYvU1Irc2lUNVMzVzdmaysxQnQvMTB2Rk43?=
 =?utf-8?B?Qmk1b3RoSTlhVjhjVUFockFJbzhNRnBablRGTCtNcHQrR2Y3VHNaL3VTMktJ?=
 =?utf-8?B?ZEthMnA5KzZ0OUVkVFlYWXc5RTRuZHlUVzAyQjAwSkdUbXE1Q3A5Zm5QY2hK?=
 =?utf-8?B?YitVdVN4UW1GVjRlbWVHcjNkbTR6UmlqS25tRmw3aGVQR3VwNnZlYXhqUmNX?=
 =?utf-8?B?aGtyNFVEN1NFSGJnWE1zWEQrRy9DaGpVL0lpZU5jdFJSaHVyZ285cWY0TThh?=
 =?utf-8?B?TUltVDZ6T1RmQjN0K3NqdUh3VkFXZXBCN1JuM3lvdHk3aXRwb0VCQUFtTjVt?=
 =?utf-8?B?ZkZUTnltV25aOWJYMm9Ca3pkelBNZDNkZHRBSEE5L0I5VWEzZTViMVgrVVNt?=
 =?utf-8?B?K3QyMXJOUjdKZk9JajZ3QTRwQ1U5dXhHbHZzRkZwSmVNcHpUWHhZRE8xaW9N?=
 =?utf-8?B?MUErSUNVb3ZvbGpQQVRXQVF1UVY1YWhVdi95cHV5bFluK3hkeERJNi9LNU5a?=
 =?utf-8?B?RjRKdE04MFY4aFVUb2I5VUw0czVNWUJyRTRTQmZwUnp2YVdpSlA5VFVYajZu?=
 =?utf-8?B?TWNBNnhXd3NuNVJzN05JZW1BVkRCQXpaSHJvZjltZ3BSVGVPRXM5WkVGalRV?=
 =?utf-8?B?VVFTc0pTaXMya3MwTzNmei9ucTFUMkNGdGRPV0tORjhHd2R2Vm9BZGloeFJ5?=
 =?utf-8?B?RDgxRzR6Mk1hYkcxTGdjejdjNW9BeEo3YzVxYmtTbmRPU0ZCSTFNQ0w2dENo?=
 =?utf-8?B?dTFxbDkwUnVBSTk2TUpIQjErSUc5YjJPaTBrL2lkeFZKTVlRMjloOVhCRERh?=
 =?utf-8?B?cHFncHRld0E1RlBBRFRpdjBidUlxSC9CS2NydWcwRFdkbVpsMktJcTBzdHFB?=
 =?utf-8?B?R09RRUN4Yi9tL0d3NUd0S05KdVl2VXVmblFxemVXQk1MTlVTMXkzaXFaVkhF?=
 =?utf-8?B?SEJ3TGROQXBLdG1UUk5OQmdOZEZJbTVtcHZ5MzgyWjh5VGhZS0o1Q3JqcGN3?=
 =?utf-8?B?UGRZZ1VGeDlWZzZ3NnRFNEQvT25EbXdBY3JEYXZwcmFsSnQwcHBVQlN4d2VM?=
 =?utf-8?B?T3hDdjJ6dFh2RE9CNWlhQWcxMEIzTW9GYkdBbDMweWt2UUxyZ0NKa3VoNXhI?=
 =?utf-8?B?M2JIWlNFK2VzR2dYQldGZW1hWTlsbmxDVjc5Q0QydEdYOHU1dmdGdmtYZkJP?=
 =?utf-8?B?UWlTbjI4YlhacmluZjl6Yjcva1ZEYW1KVEZyN3ZUbjRiSTZqNituZDNZSVhs?=
 =?utf-8?B?amlxbGoxNUF0NzUrVWRyRmhxQWNHb295dDYyRmNQcjlVNStUbVd4ZFJRN2tV?=
 =?utf-8?Q?q4HlQvjA/S0TwHPTJDrYoAY=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a0425470-6430-428d-a22d-08d9ed4a2767
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2022 10:34:59.5664
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7S1lIkAfI9Fz4476h2f0azpqP9gDpNdHsxXJWAIRjrgdjz/07BAmwl1DWTwiEtop+RPpFqiCzVT3Gy/SqA2HWA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR0402MB3512

On 11.02.2022 08:23, Norbert Manthey wrote:
> --- a/xen/arch/x86/cpuid.c
> +++ b/xen/arch/x86/cpuid.c
> @@ -609,7 +609,7 @@ void __init init_guest_cpuid(void)
>  bool recheck_cpu_features(unsigned int cpu)
>  {
>      bool okay = true;
> -    struct cpuinfo_x86 c;
> +    struct cpuinfo_x86 c = boot_cpu_data;
>      const struct cpuinfo_x86 *bsp = &boot_cpu_data;
>      unsigned int i;

While I agree with the need to initialize the local variable, I
don't think it should be pre-seeded with previous indentification
results: This could end up hiding bugs. Instead I'd see it simply
be zero-filled.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Feb 11 10:42:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 10:42:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270303.464543 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nITNE-00015g-3w; Fri, 11 Feb 2022 10:41:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270303.464543; Fri, 11 Feb 2022 10:41:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nITNE-00015Z-0t; Fri, 11 Feb 2022 10:41:56 +0000
Received: by outflank-mailman (input) for mailman id 270303;
 Fri, 11 Feb 2022 10:41:54 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=dFbI=S2=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nITNC-00015T-8K
 for xen-devel@lists.xenproject.org; Fri, 11 Feb 2022 10:41:54 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 3828bfeb-8b27-11ec-8eb8-a37418f5ba1a;
 Fri, 11 Feb 2022 11:41:52 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3828bfeb-8b27-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644576112;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=9SBDqUXRraIhI70rhDQmUt5L2qOlgQOsw4XyafgKXf8=;
  b=K2X3mshZK9BhnOZ+mWFs/awgHmIHRF1040d9P8ozGHhyKY4c+9khJfRy
   xvXy2fY8KNv+MjTOr7P94BYoJY+w+hDPROaejbQ2MZYqtX4jNNJmwjZlY
   MbtwFT20U63wGF2N35NppQiddHkpfa1VhVj0lE3Rxf7/SUDt30Nl2IeEx
   M=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: zgDg91yGhUWKo/WSY2E9zXDvXXhrdB9+L0HySU7w7V8jAqTGVpzlfpUNaqSoNJnsbTsZHGNvP+
 XQmS9exfS4IbCm8jSDVGhdAKkUeb2FGmhBrL6Q1n5QBg56OVU9FHcUH+4KVbIdVHOiMRTwhkZJ
 uCNGygwU+BVKuMd9UxNOeiZbpGvPqt3Egx3njfJRVgeMNLBbwxe6Yzdy6iCIgjuAV8OvoVvqAg
 g23cOFwvHqotT+o3MXfm1O3JJFGcpBuGv9SjwKA/13EGg3B0n8vhyozOmVZh7+JEgLaOlpoMT/
 pZxmG//u/XuQy4hoKoM4/Q9P
X-SBRS: 5.1
X-MesageID: 66229629
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:RDGVfa3Ti0PxIoHXbvbD5QF2kn2cJEfYwER7XKvMYLTBsI5bp2ABx
 mMdXG2CPffca2T2fowjYYi0p0wPvMSEnYBnS1NopC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkS5PE3oHJ9RGQ74nRLlbHILOCanAZqTNMEn9700o5wrdh2+aEvPDia++zk
 YKqyyHgEAfNNw5cagr4PIra9XuDFNyr0N8plgRWicJj5TcypFFMZH4rHomjLmOQf2VhNrXSq
 9Avbl2O1jixEx8FUrtJm1tgG6EAaua60QOm0hK6V0U+6/TrS+NbPqsTbZIhhUlrZzqhoo1c0
 8tPs4OMawpyeYvPo+5MVzx8DHQrVUFG0OevzXmXtMWSywvNcmf2wuUoB0YzVWEa0r8pWycUr
 6VecW1TKEDY7w616OvTpu1EnMMsIdOtJIoCknph0SvYHbAtRpWrr6Diu4EChmZu3JEm8fD2f
 5taRBdVcTb8QRh0HUYUAcwgtdf1iSyqG9FfgA3M/vdmi4TJ9yRu1JD9PdyTfcaFLe1Fk0Ddq
 m/Y8mDRBhABKMfZ2TeD6mirhOLEgWX8Qo16PL+y++NugVaT7ncOExBQXly+ycRVkWbnBYgZc
 RZNvHNz8+5iryRHU+URQTWF/VOfoBwaROZyHrZ9zgK2wPvQxiKGUz1soiF6VPQqs8o/RDoP3
 1CPns/0CTEHjIB5WU5x5Z/P82rsZHF9wXsqIHZdEFBbu4WLTJQb00qXJuuPBpJZmTEc9dvY5
 zmR5BYziLwI5SLg//XqpAuX695AS3Wgc+LU2uk1dj/9hu+aTNT8D2BN1bQ9xawRRGp+ZgPf1
 EXoY+DEsIgz4WilzURhutklErCz/OqiOzbBm1NpFJRJ323zpyL+J90Pv2sjfR8B3iM4ldnBO
 h67VeR5vsE7AZdXRfUvP9LZ5zoCkcAM6ugJptiLN4ETM/CdhSeM/T10ZF744oweuBNErE3LA
 r/CKZzEJS9DUcxPlWPqL89Age5D7n1vngv7GMGkpylLJJLDPRZ5v59eawDQBg34hYvZyDjoH
 yF3aZfUlUUFDbGWj+u+2dd7EG3m5EMTXPjeg8dWavSCMkxhHmQgAOXW2rQvZ8pumKE9qwsC1
 ivVtpZwxAWtiHvZBx+Nb3w/OrrjUYwm9SAwPDA2PEbu0H8mON794KAafpoxXL8m6O08kqIkE
 6hbI52NUqZVVzDK2zUBdp2h/oZsQwum2FCVNC2/bTlhI5M5H17V+sXpdxfE/TUVCnblrtM3p
 rCtj1uJQZcKSwl4ItzRbfajkwG4sXQHwbogVErUONhDPk7r9dEyeSD2i/Y2JeAKKAnCmWTGh
 1rHX09AqLCU8YEv8dTPiaSVlKuTErNzThhAAm3WzbeqLi2GrGCt9pBNDbSTdjfHWWKqpKj7P
 bdJz+vxOeEslUpRt9YuCK5iyK8z6oe9p7JeyQg4TnzHY07yV+FlK3iCm8JOqrdM1vlSvg7vA
 hCD/dxTOLOoPsL5EQFOeFp5P7rbjfxEyCPP6fkVIVnh4H4l9bWKZkxeIh2QhXEPN7ByKo4kn
 b8stcN+B9ZTUfb23gJqVhxpylk=
IronPort-HdrOrdr: A9a23:IhuT9KPJmkHAXMBcT1n155DYdb4zR+YMi2TDiHofdfUFSKClfp
 6V8cjztSWUtN4QMEtQ/uxoHJPwO080kqQFnLX5XI3SJzUO3VHHEGgM1/qB/9SNIVyaygcZ79
 YdT0EcMqyAMbEZt7eC3ODQKb9Jq7PmgcOVbKXlvg9QpGlRGt9dBmxCe2Cm+yNNNW177c1TLu
 vi2iMLnUvqRV0nKuCAQlUVVenKoNPG0LrgfB49HhYirC2Dlymh5rLWGwWRmk52aUID/Z4StU
 z+1yDp7KSqtP+2jjfaym/o9pxT3P/s0MFKCsCggtUcbh/slgGrToJ8XKDqhkF+nMifrHIR1P
 XcqRYpOMp+r1vXY2GOuBPonzLt1T4/gkWSv2OwsD/Gm4jUVTg6A81OicZyaR3C8Xctu9l6ze
 Ziw3+Zn4A/N2KPoA3No/zzEz16nEu9pnQv1cQJiWZEbIcYYLhN6aQC4UJuFosaFi6S0vFpLA
 BXNrCd2B9qSyLYU5iA1VMfguBEH05DUitue3Jy+/B8iFNt7TVEJ0hx/r1pop5PzuN4d3B+3Z
 W2Dk1frsA7ciYnV9MMOA4/e7rENoXse2OEDIvAGyWuKEk4U0i93qIfpo9Fo92XRA==
X-IronPort-AV: E=Sophos;i="5.88,360,1635220800"; 
   d="scan'208";a="66229629"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=BS6x9Mq0xN/pR+9XGsqYDgX31BvmyMktVGmS8R6nmYY5J/es8qKH8jsqXsmCq5EWL8UvGx7rQp6xoPVSuSeIrN0QSLIMmyhB9XMmNzAX3P8Kg+at8IxirB+rGW+yLgxMTC6dAHjZi2cdyXTINy74XRqXYKAMXKF0ajOGtpYo9Rh0OTdKRHe4Z0+cMVgw2B+RWVrzUqw5nwNgzDOERDdspyzDEsGcOusgwvGZ49BJ8P/coKAhvijTKtY8BdgnVQIKpfDK1iTXOk7Vdj7Dax85uVQTIacVwD6WSRm9eYTkA6kYq6j/E/505NJLFelQKG/O3OmWudEDXqenqfuhHeGGgg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=sfSqR2dH8GqQfY9mYwIKStsHGShHmQ34UwiEZAaj4zU=;
 b=J2Oozk3OL2lfNPJPIe02XzFaY8KmOeZd0LFX/HJ6s6h1wOtLPx5OT+yNQjFHDbPzrEur0ub7HH6kcryiORdtof7rPySJADYR1OZPSbvbCHvDgl3cWPcGfBO3RBGW2rcKn/8Ruz6SbHgKEYNjcCn0M1eGPDkQ6LDgvQy2JRR4SIb2mu9kYsM4E/n6eSvtwn9DAFN4QHPw60CQZ02iyqFKJPJFtO6tP0IrLbiXbquSKQ0RIpY2HXo5BK+372NJqqNlHAU0zhyxU/qmXmmX8reb0zbrWolvAIsuj1lA60WxcbrjjIjYTQ6r7nlkS+hJFtkrsfdLiEgjdYsQEvlZ7Fp3Yw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=sfSqR2dH8GqQfY9mYwIKStsHGShHmQ34UwiEZAaj4zU=;
 b=qn5UXVuMc3R/U2gNv0eysmiuJJA4ika/1RbS4fFgQAbUtRuJWSRBfDV/Qe2jp4kCV1d24ATVviMGl5VYGJAnB9onsBB1XgaWi9Gqc6cPt7qlAgBwm8fQNOHTI/j8JmANZiTKThgFl7Tz5klz8o/lV96scSQrZwQEcDEdv/4/tHE=
Date: Fri, 11 Feb 2022 11:41:36 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH 1/3] x86/Intel: skip PLATFORM_INFO reads on family 0xf
Message-ID: <YgY9YKlGZwV0QuwV@Air-de-Roger>
References: <5d275d7a-7751-af19-db4f-d91e3592d30f@suse.com>
 <6f56a75c-cd68-0dad-b1ef-a3421271ee47@suse.com>
 <YgYu+OoAovYmTg8E@Air-de-Roger>
 <b751bc52-7878-e1dc-9769-55328ef1abf7@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <b751bc52-7878-e1dc-9769-55328ef1abf7@suse.com>
X-ClientProxiedBy: LNXP265CA0036.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:5c::24) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 6f6297f3-f8f8-4df4-fb70-08d9ed4b164e
X-MS-TrafficTypeDiagnostic: BN8PR03MB4692:EE_
X-Microsoft-Antispam-PRVS: <BN8PR03MB46927A5663B0466BA9CD505F8F309@BN8PR03MB4692.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 0OFQRor/9JICzVIYQaoRg7Bht44rg79hMegTys+eEJ+wv0bdiR1nzP3n8DhSMJV46bqYvI0BX6Npy0QAQAcOLFK+BCgvgPBM8tQ4J4HjLDDTEfn2sMjputpl3Xf1VdqDpXVdleO8G0Uy6HUdVuAL5MWoUCk+FKEiIh85USyhmx1DzQJb6Y4yjJNxPpk0S/OdsUKE3/jvFBVPJs4NEPFXkGa00nbzqm5H4m3hghZ/rG1GVaFjIMKTTxvWvaZvIoELVW9mhynF/Ykbz3zi0YX165mKBN2RIipUEVknaq0ekllld2fxJipaxdoA2j1j8knUV1Iw+835/uPd9VSxDgo5EgoHJqTOnGkLURBAJZp8JU4/oRdoAZUVSr97XKQJeM/gKS0c8yTNWmu26cOr12peCdfHRw50x8UWfpHI9w5g8hSLF+XAcDBNjmU5h+DlKFZfBOa68mdZJogrHAwzpqosjWw47mOezM+AhzdsiMDHrXFV+94n2mCCT21Ioju9GQ/tCZlde4VmMh+bZHcMn65Tt//4Y8fVQDJw2xK0J6S2DnUDNjuMToK2G190JQnd4qa1xnBHad9DrvHCj8lAl6LkT3MdmLg21E+DqpGrZECIvpf74/YKnn1zVfbAiL0Qm5awk/lKfDkC7UVuf9Esc5KZpA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(6666004)(83380400001)(508600001)(6486002)(5660300002)(33716001)(85182001)(2906002)(186003)(8936002)(86362001)(66946007)(4326008)(66556008)(66476007)(316002)(8676002)(54906003)(38100700002)(82960400001)(9686003)(6512007)(6916009)(26005)(6506007)(53546011);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UExWOXdTZEJiTWZ0WGNaZTY2cyt0VWpjeVVoUGR3Kzdra1Q3aFpreThRUDE0?=
 =?utf-8?B?YUFzU0VFcHVneEQ5Mkg0V1k0ZGRYc0g0ZnY2S05qVTNrSE9BNnNPejF1NFhi?=
 =?utf-8?B?ZWJlT1RPL3gybUVBdFJFYStDZHNqeDZQV2ovcnZVTllOYitYcDFKS2ZEWEtM?=
 =?utf-8?B?UGxLOC9lZ0szNGtsN3dyeFRPT2xVR0JtdndrWmJ3c09CWWxmU2x2NkNvRWVl?=
 =?utf-8?B?emMycUQzYnRuL2RBRW82cWI3c3M1RGNtTzhVbGNUYndPYmdhWTlENjNlSm1k?=
 =?utf-8?B?RzhRT3JFYVIzaWdGVjZ1dGlrMWVqaHllc0FPNERXTzZIenBVVVBMSXN4OTRr?=
 =?utf-8?B?K0ZncERSSmFkTU05U2NSUjdlRkpod1F1Q0N4eEIvd2Y5WGZsaWtsbXhyVVdO?=
 =?utf-8?B?TzBLUHlnOWw3SXZlRThHdkw3TSthT3VXSTU2QVhGYlZiTmV2akRCK0drTERZ?=
 =?utf-8?B?U3VpRXNKbkRheEF0RDZXOEJCVUVBYmV2cDd5emVYWC9TZnR2RDFOa2x5ZExz?=
 =?utf-8?B?WUpZTkpwenV3TFV0a3d5bWM0Wkhock4rY1BPY1QxZnlxeCthN2prakY3SUlH?=
 =?utf-8?B?dWxqYlZqSGhTdm1YcHNrN05FbmNBbTZHU3czOXk4K054dktLQ1NoTlBQZWFw?=
 =?utf-8?B?dm9FR01nbXlOdUl2RFdncGJTK0dMRUJqdGxiemJiZXRGL1BKRlFYd1owVzZ5?=
 =?utf-8?B?MC9uc3liSk5ZK0NFRXlreEdkSUFNSi9oSFc1RzMrc0F0MWFmSUtMZ2F6QVdq?=
 =?utf-8?B?Z0MxNHFHUG1qWXFLUThkckpjdjRINDJyNEdWdlpIcVFuNjBDOXJpamtzUjNI?=
 =?utf-8?B?SG9NMGpXY3dLUE91M2VuY1F1dWN1RFFSZTRZVUdveEdFY1NBcTIwbkd5eFdE?=
 =?utf-8?B?bVdvOGQxenJ1SG9rR3RjYU9yZnpLMnZmVmxpdEZ0Z0ljZXR2SnA4RWpNOFEr?=
 =?utf-8?B?YjB0UjVNS0RzNGJneEErR3E0MmNLRE1sS0QvbUN0VmlJcWN1SjJ1WFk2N1JB?=
 =?utf-8?B?d3JSRVlIcFZkeVJGa1o5NVZ0UXhuVEZ0MEZkb2tCRGRLWDRqNWprNEE4Q3BR?=
 =?utf-8?B?QjduNDQ4UWJndTQ1SlhsTHNFUktFdUxPWSt3RU1RTUN0MHBKNFlsQ05HR1JC?=
 =?utf-8?B?REdGeFZXbnFVcFpyaThSS2RQRWtnelhMY0wvSUM0K2xmdDlTUEk4bjZ4TDZl?=
 =?utf-8?B?c3N1ck1lMm1jeGx2OCt3UnNWa2c5VTNxTnFZRjBFSW01aFBvclZ6MkpYbDJV?=
 =?utf-8?B?QWErc2c3ZGRKV2VnTlNEekdUUnJRcm5NODZmNm1WNlVTZHpnWHR3NWw0UVNz?=
 =?utf-8?B?VVkwWTVzM0FubVBDdEFmaW5FeUJ4V3ZmaDJ5NlcyLzcvM2ozWi9sNEMrdEV5?=
 =?utf-8?B?RTZSbER0Y3Vld2I0WXRrSEhFYTZHazk4eXNvcUd2d0ZtSkRxWUFRN0FyZzRS?=
 =?utf-8?B?SGF4ZC9CS2dmN1FFU1d4anBxSlc3QWl4bGt2dGJsWndWMGJmRXNSUzlEOWVu?=
 =?utf-8?B?WUlJR3p5NktmdTQ3aURxN2tQSmpIRm54UERLbHloN1RYYXBXRGE1Z1p5SVor?=
 =?utf-8?B?U3RsN01KOENOV2ZjMjdkOTJORk4rWm9BY0VOZnB4ZFBMaTlqZERmR0h3QWhs?=
 =?utf-8?B?Qi9YY0N0OWNiQ283MWJaVDZUNC9FQWZ1VlVobGNIQmVvM1FXRmlxeXNRelZv?=
 =?utf-8?B?OGp4cWF4bTcxWXFMU0JJd0l1OGo3TzVLeHpER0I5dklQNDJOQ0htelF3VVlm?=
 =?utf-8?B?Vis5Mk1EUENWaFRSbzdra2VCbldpQ0FweTJIbldrYzF6N1dPaEJlKy9MS1dG?=
 =?utf-8?B?RXc1V3Z0aCsxU3JOdnp4STQ2UDJnNVR3dEJGcnJSRk5sb1BPV2pTeGE1RndF?=
 =?utf-8?B?Sm5JQ0FIZmVnNHUzRmQ1L0NHb0hpaUd6WGNTMW0vdTRYLzVoNWZqdGJaa3NB?=
 =?utf-8?B?WThIcTJ1Vkd5OFFoMVVGTHE0SXdHbWh0dEJndzlpNExyUDd4QWVuTXMvL2pJ?=
 =?utf-8?B?WHRqc2xoVzFpajI1WVRZRThUSUl4dFo2UURSRGRSejJOTVRabWtoekR2L1FB?=
 =?utf-8?B?MU52NzR1dEU3U0c0alFiYU1HNks4dGExdVN5aXRrUXdZQ3ZBaGQzekQ5TmJE?=
 =?utf-8?B?ZHgzbnNZbmxLSDhMRSsyVEVFTmU4Ri9tSFljMk8yOWFXalBNZ0s0ZklxMzkr?=
 =?utf-8?Q?HGYobBfJLCHuCTuhFKObkZ8=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6f6297f3-f8f8-4df4-fb70-08d9ed4b164e
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2022 10:41:40.4427
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: l42SI1Q9NxHAvSYK5/e7wHdX3dfXt7Lj4oxV71LBLRhz61tJGuNZe5gnwMhGhvXJF9yHt4iSVjo6NdK8FMvuEA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR03MB4692
X-OriginatorOrg: citrix.com

On Fri, Feb 11, 2022 at 10:59:10AM +0100, Jan Beulich wrote:
> On 11.02.2022 10:40, Roger Pau Monné wrote:
> > On Thu, Feb 10, 2022 at 03:55:52PM +0100, Jan Beulich wrote:
> >> This avoids unnecessary (and always somewhat scary) log messages for the
> >> recovered from #GP(0).
> > 
> > Could we maybe get rid of the #GP messages for cases like this where we
> > are explicitly probing for MSR presence? (ie: it's expected that we
> > can get a #GP)
> 
> This would mean some form of annotation of such RDMSR attempts (for
> the recovery code to recognize in order to skip the printk()). Not
> all rdmsr_safe() uses are, strictly speaking, probes, so I wouldn't
> want to put such in rdmsr_safe() itself.
> 
> In any event - quite a bit more work. Plus I'm not convinced it's a
> good idea to suppress any such log messages.
> 
> >> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

> >> ---
> >> Perhaps even use "!= 6" in at least the CPUID-faulting family check?
> > 
> > Likely, or else you would also need to check for family 11 (Knights
> > Corner?) which doesn't seem to support PLATFORM_INFO either.
> 
> I don't think Xen is able to run on these (likewise for IA64, which
> iirc were surfacing as x86 model 7)? These are the co-processor ones,
> aren't they?

Right, Knights Corner uses a socket mount but it's still a
co-processor. It was Knights Landing the first one that could be used
as a host processor.

> My question was more towards whether we would (wrongly)
> exclude future processors when using != 6, if Intel decided to ever
> make new CPUs with a family other than 6.

In the case here I think we should only avoid the probe for family
0xf. Newer families (or even models on family 6 not supporting
PLATFORM_INFO) will just get a #GP message which is OK I think, we
could fix that in due time.

It's better to get a #GP message for probing than to just skip
detection of CPUID faulting on unknown newer families IMO.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Feb 11 10:44:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 10:44:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270311.464554 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nITPZ-0001jh-Ld; Fri, 11 Feb 2022 10:44:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270311.464554; Fri, 11 Feb 2022 10:44:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nITPZ-0001ja-HL; Fri, 11 Feb 2022 10:44:21 +0000
Received: by outflank-mailman (input) for mailman id 270311;
 Fri, 11 Feb 2022 10:44:19 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=17AN=S2=epam.com=prvs=4041139d62=oleksii_moisieiev@srs-se1.protection.inumbo.net>)
 id 1nITPX-0001jQ-3G
 for xen-devel@lists.xenproject.org; Fri, 11 Feb 2022 10:44:19 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8e4b1137-8b27-11ec-8eb8-a37418f5ba1a;
 Fri, 11 Feb 2022 11:44:16 +0100 (CET)
Received: from pps.filterd (m0174680.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 21BAhuGe032401;
 Fri, 11 Feb 2022 10:44:09 GMT
Received: from eur01-db5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2053.outbound.protection.outlook.com [104.47.2.53])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3e5pa30016-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 11 Feb 2022 10:44:09 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com (2603:10a6:102:ea::23)
 by VI1PR0302MB2702.eurprd03.prod.outlook.com (2603:10a6:800:e3::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Fri, 11 Feb
 2022 10:44:04 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::c1c:f98:9dd:86e0]) by PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::c1c:f98:9dd:86e0%6]) with mapi id 15.20.4975.015; Fri, 11 Feb 2022
 10:44:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8e4b1137-8b27-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=aLI1sdR2ddh3kzRWq2zOE2QPLs8+ifmHEyb0YfXhXqD8HnY+pz0S4rAROIMBeSv5HBV/ilHqfYgyhTUHSkkqlPEcVvI66oY/XlncLgyHsh4zSHcbQuPMnURu1UVdmzUSrX8H1hEWjLIzSAQQfG95YMXAbPbljnOAEhXX6c0G/dROg6COvxpuetcGaLbZgiyr9gBlc2s2n1PH4zDPQCGZ6N0UguAmMpTMGloRz6CQ0PAiUG27RD20JO3XU+6EPqaVZN6mw9sg+/wCl9ULoXQwX4K52mnu2en4bz+XRNlD2On/WDqKu+W6IcYopbBlFyTxjs8h1LnGBsJ6SgHUluGf/g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Ar2I8RsecLU377miWVEFY0JwVRE28rTHIxyitlgOxJs=;
 b=fQ+vni9MXLtnGzotViGLIeeV1UPAQAQD4SLg5ToujqGdqaahhZGEcXn4XKeqK9SNjTxsMckPzbZlf1HUtls/V4TOujUGef4c011F3xJgoJGo1vvjdIjJgbpKN1QNmOto2G7JLw3N47D73yzXNO71CYQhGDh59duhFtCt5X8/Zu2kV8Ta3Cbjn4no2H7c2+bwbsIEyHmH6AsF8nVcoZsb3mDwCKOTvXUiXCBe79jPdhSPHOHhGAdm6s6KfmG+unMI6Vq/oNtiG7jRgrg+xEJr9AYGJ6mFF+H5Q7vl/NXrVnnmCliOR7hnuXSGid4hKPYOhsdmHC+hc6DN03XCROKqpA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Ar2I8RsecLU377miWVEFY0JwVRE28rTHIxyitlgOxJs=;
 b=MrwxTpGmfb3HYVRX5HBybOyUf3KVkhGtETb+igvNWMbMPxav9Jkh5mxpx5sD8hkqdES6rlY5dk1/nIIX9usrgHdInYhl+6CNLvb2KSmduqEFQCaCVUExNegK/Fdo/qAF4je64AFtIrxJNDprYObO2kBcEHVDbcvdoSjt2Nb2O/ftEKDZQVZ8ywWRrM32fUMy4v7wO/T3FLvWlCSVWHuLv5N2EDU2KvMYkZiDRafe4Xty6hly89W9cD0RHOqG5pOPHZeognDsQB+nS5oDJ8n0vxhqHYumAsGNm8l0Pr0R+H7kX654YgOM6fqEdIssg1SxTDPHKL3xGsOyZajjXV5jDQ==
From: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
To: Bertrand Marquis <bertrand.marquis@arm.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        Stefano
 Stabellini <sstabellini@kernel.org>,
        Julien Grall <julien@xen.org>,
        Volodymyr
 Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [RFC v2 5/8] xen/arm: introduce SCMI-SMC mediator driver
Thread-Topic: [RFC v2 5/8] xen/arm: introduce SCMI-SMC mediator driver
Thread-Index: AQHYHRW24Dmb0qV8ZkqAv39Pf6/nVayODW6AgAAg+IA=
Date: Fri, 11 Feb 2022 10:44:04 +0000
Message-ID: <20220211104403.GA2291814@EPUAKYIW015D>
References: <cover.1644341635.git.oleksii_moisieiev@epam.com>
 <cb1493f5d9b5c3437268054b4a8e345cb35c8708.1644341635.git.oleksii_moisieiev@epam.com>
 <F9811680-C6EC-4372-A451-5C1DA279E35E@arm.com>
In-Reply-To: <F9811680-C6EC-4372-A451-5C1DA279E35E@arm.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: b7222d0f-d630-4f53-e457-08d9ed4b6c61
x-ms-traffictypediagnostic: VI1PR0302MB2702:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <VI1PR0302MB2702C7A985AF29A63D7FC0F7E3309@VI1PR0302MB2702.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 ZmDYjdD4uLOgJmOKceIuyHuSciJrZQU2Cc6Pa5GMy2FRjp3RnI4AE9oPtu1l0CxD5oZ6SLr2ocJgrWV3gXTUVFscGZJIYmdejAFIvLa6wKqJC1DG2aJGF3onl96iZPPvfzY/f3MHtEY5nOhx1o61vQEVsdlFTcCl6zWLZAt/tu3hYIjv1rKeF32S60WBaxLiNSDWm4/YYgUWcMMhVKzYtnPiqJShzn88Cv8ZlWZCtTVUyJSxTP7KiYzgwjH9R/235DSnFa/rC3PFxQ6eDYclNEA+mLDQyR30R3Op0Lff/GQyeEzK+iEoe/vOIXtcpzZr/OBcy9+OOhurUUOLiG7+co8Ps1gNhxzUITjp4Mkwk+f/RgDXGKzWok2mRXbrfJU3uVCjDO9/Oxx9W4D9zIx0zoIcWPlCfiS3/MaxEZsowoe/Am+7sw8Q5cukcF0O9Dr+H4fErg8XnvK8OFSPXZHkHHYIkJMLZapTW1u2WBEpwq/WZZA7VXTM/mC9fHiePsXFhSSui1u1Rfy9Hi00PtKEbl0hR0D5cmk4oacD3K01iUQ8C+6nU4SqVFm09NdJNvQLY9Fb5ViPMF/8GgUj3bGN2htjcYrA61iCPQlYF9oDVf8YzJTU/JmDc4WmBTJs6Nq1P1YuKt0OP3esKNNeKc730BITdFQKEgHfseFIQXEEqdhSc3szHGm4EfWd9Mj1W1roJh6UFEGxH+5f5t/RCQknU21TvapH45kGS6CYhAV8t2w=
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR03MB7136.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(6916009)(76116006)(83380400001)(33656002)(66946007)(54906003)(316002)(8676002)(91956017)(66476007)(66446008)(64756008)(26005)(4326008)(1076003)(33716001)(8936002)(86362001)(5660300002)(53546011)(186003)(6512007)(66556008)(107886003)(2906002)(30864003)(9686003)(508600001)(6486002)(6506007)(71200400001)(38070700005)(38100700002)(122000001)(2004002)(579004)(559001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?OS9KMzlhZ2hQVXkxLzkzbjIzQ0J1K2ttNVg0VkhkdVBLR25xZnBGSytrUGh2?=
 =?utf-8?B?Ym9HbHE5TkhSM2dDNzJrdzhZY2FvMU5UUmdOTE1RWlRqeGZoRnJSR0tKQjJu?=
 =?utf-8?B?ZUl6TThFcWVERG10VnZ2cVNkdTcxVkNQN0JVcUdTRDZjY0NZemZWTGJKMk5y?=
 =?utf-8?B?Um5aMzIxelFFcVdlZm02M2lXUDN3Nk1qZEdMN3d4OHpkZ29pbjMva2hiMmc5?=
 =?utf-8?B?MmRCNGQ4VVRUU1NDYW90Y05YTVZkZ0swN1FrN1VJQzJSd2FyZ0ZlWnhObzU5?=
 =?utf-8?B?ZEJrTUN4dXh3eEZOVzJQRlcrU2doQUY0eXpIRGNWaFh0Ry9TeUw2OHlLejE4?=
 =?utf-8?B?SUdLSjNiT0ViSVZFbWNFL1oxaHJrNjlRVUtiU3RkdDhObmlQKzZVZHptVUxJ?=
 =?utf-8?B?RCtkS3cyUG9iL0pwSmhqeElXM2U0cnl4Nzd1OXYwYUdQc0Q0OGVjNHBVZUtF?=
 =?utf-8?B?OTJJMVpsNEZ3RmEvRmxJa1kwYXZZcFYvNGFoc1pxc213MVFnZ0lDOGJNZjBh?=
 =?utf-8?B?Qk5pYTl6dWs0T2xQcW56TUpibzRaSVpGOXlta3o5ODZBdHVIejl2bzkxTWlW?=
 =?utf-8?B?Z1cwZCtFYlEzR3VFWUc5RTVYbjAxbjR6YXN4T0ZGWkZDUlBsTjNGWWZidVhh?=
 =?utf-8?B?NC8zODlkQ2lSb0U3T0F4T0dQYjBkYm94TklSaWF2eEl5bko1bElXMUIxdWVa?=
 =?utf-8?B?cmZRVHRjOHE5eFAreDdVNVg4Z1Q4TCs1YzdKRTFWdjRzMzYwTVdERFR6dEg0?=
 =?utf-8?B?c2d1MnhycnJMaGttbVhWTG9ZVjM1R2JmbVNxTFkveGZsWVI5ankrckVmV2N6?=
 =?utf-8?B?K2NmcWNUTDA2YnQ2SVgvR1BWVmJZN3JCaUxIc0U5cW9sbDJBZ0tQZmVUbHY4?=
 =?utf-8?B?cXYwZmlva053K0NuUDVoOTRGUGhRaEdsRlpaWmhqWitrT0ozSjJ4L2paYkNr?=
 =?utf-8?B?SjVXanErdTBxWjE4bGcwVGFkVU51Mkpnc1dSd0R1UitIaHh5RTBSOEJTNEh3?=
 =?utf-8?B?bG1iVVZnYXJRb1RwdldhcGhaaml3TFZ6L0lvUExUSzYzNmVCU0FWczBqLzV5?=
 =?utf-8?B?Q0toQ0t5VFFuSlJiMzlTek5FYmNoWlZRc0VrZExEb3pmYVdHOVJDUUVHdENN?=
 =?utf-8?B?QU9ZeUtrS3FXaW9EaWVKZjJ3SVRJRDRINFZQUGRHTWlZaGJtY3pDT21Pbm1T?=
 =?utf-8?B?VEQvT0lFYTM0ZE9ad0FQT2xTOUpkbTRaSWlIU1BSYnEzU01ORlBQMHlpUkRJ?=
 =?utf-8?B?RDc3SHhjKzNOMFdnL1JtMFBMdS9yL04vSk9NaEZRNU8wMTNuS2pQWXAzTHBO?=
 =?utf-8?B?UnVycTd4c2dRR05pMlY2YmxQUVk5V21oblppSTlVRkY5aWNCdXM4THhadCs0?=
 =?utf-8?B?Z1gzUVdoc0RvREJZZTlWYWFRYlZxVVUyWTBYVTVKRFlOUDJYTXJoZERiMUtR?=
 =?utf-8?B?bFBHZCtkZFhYNHBGcWkySlIvbjliOHdOVW9jV1RMbUxhNlV6d3ZkOGpQRHNs?=
 =?utf-8?B?dkpMZTF6RFFyRzdrQkduV0V2aGlKYmFGT1RMQ0VTMi9kQTN6TEdoSG5JMEQ2?=
 =?utf-8?B?dElRT1V4b1JqZlpkcy8zaEtRUXhaeU5FMWZoS2trZ1c1c2FvajUxNVVObEhr?=
 =?utf-8?B?dlJ2T2JUeVJBYWNiOGZSbVhPanNlQlNud3B5d0YyTGQxaE5Qclk1QkJXcnFT?=
 =?utf-8?B?VWdKbUVjZUxKSktHWHQ2Rmk2N1FzbmdlcUJKdkVvSzdTRUNjSzJidGE5dXN5?=
 =?utf-8?B?ZjZTL3EwY2l4SWk5ZWEvdG4yaEVYbnNLMURINTNYNnpmV0VENGFXTjJjSDA5?=
 =?utf-8?B?eWt0M21EL0VZU0dDRnBlOXBROWxtUnlveWNERmwwVDQxckN3T0JacXBlS2V0?=
 =?utf-8?B?djhHQzl0bnNWemhkSDh4MWxiclZ0Qmw3dXYxc3JVeGNsTkNKZHVuWTVpd1po?=
 =?utf-8?B?RmlYaVI2WlM1VGVCNFc3eTdDTW5PZGRJMzNKaTE3MUp2RERaZkhDQ0xxcmFP?=
 =?utf-8?B?U2hUeGhScnZXWHZQeFhGMDREMnhUNVFmUjVMWWN3VTBLYUtMQ2t2dGIyT3Ry?=
 =?utf-8?B?Z21rQmpETG1xOUxEMXA5cmV2NFV4bDE5S3poUk5yWWUwUUFSQkF4WHI1dytn?=
 =?utf-8?B?KzRhOE1sMm5wNDZvVG52Rm5zYy9FeXVEaUpieVN6Wk12WkdKNmttY3VPUzJF?=
 =?utf-8?B?OGNweFFGanR4VDhjL2FmeFZjMWRnVWI2ZkljZlg5VWQzelA2TllMdEdVTlRv?=
 =?utf-8?Q?/04ysyKgJ+mjFTowC5RWmuOBzw28Cq522PrNzzV7W4=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <826A16CA187CED418C31932C39D3E5DA@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR03MB7136.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b7222d0f-d630-4f53-e457-08d9ed4b6c61
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Feb 2022 10:44:04.5383
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 0ijcbrO67i+ku7lWTzTtWz/+hl1E3XgIpztEK2YtITQG7V03YFyxoWsoQh4+GotX4jHIxXVFzECA5uZtannctS1Bqh8qE6YV4nd7+sMcdwA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0302MB2702
X-Proofpoint-ORIG-GUID: Z801M0Nv-oukcHpxgFSYggyHW_rgKgHf
X-Proofpoint-GUID: Z801M0Nv-oukcHpxgFSYggyHW_rgKgHf
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-11_03,2022-02-11_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0
 priorityscore=1501 clxscore=1015 impostorscore=0 bulkscore=0 adultscore=0
 suspectscore=0 lowpriorityscore=0 malwarescore=0 phishscore=0 mlxscore=0
 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202110061

SGkgQmVydHJhbmQsDQoNCk9uIEZyaSwgRmViIDExLCAyMDIyIGF0IDA4OjQ2OjA1QU0gKzAwMDAs
IEJlcnRyYW5kIE1hcnF1aXMgd3JvdGU6DQo+IEhpIE9sZWtzaWksDQo+IA0KPiANCj4gPiBPbiA4
IEZlYiAyMDIyLCBhdCAxODowMCwgT2xla3NpaSBNb2lzaWVpZXYgPE9sZWtzaWlfTW9pc2llaWV2
QGVwYW0uY29tPiB3cm90ZToNCj4gPiANCj4gPiBUaGlzIGlzIHRoZSBpbXBsZW1lbnRhdGlvbiBv
ZiBTQ0kgaW50ZXJmYWNlLCBjYWxsZWQgU0NNSS1TTUMgZHJpdmVyLA0KPiA+IHdoaWNoIHdvcmtz
IGFzIHRoZSBtZWRpYXRvciBiZXR3ZWVuIFhFTiBEb21haW5zIGFuZCBGaXJtd2FyZSAoU0NQLCBB
VEYgZXRjKS4NCj4gPiBUaGlzIGFsbG93cyBkZXZpY2VzIGZyb20gdGhlIERvbWFpbnMgdG8gd29y
ayB3aXRoIGNsb2NrcywgcmVzZXRzIGFuZA0KPiA+IHBvd2VyLWRvbWFpbnMgd2l0aG91dCBhY2Nl
c3MgdG8gQ1BHLg0KPiA+IA0KPiA+IE9yaWdpbmFsbHksIGNwZyBzaG91bGQgYmUgcGFzc2VkIHRv
IHRoZSBkb21haW4gc28gaXQgY2FuIHdvcmsgd2l0aA0KPiA+IHBvd2VyLWRvbWFpbnMvY2xvY2tz
L3Jlc2V0cyBldGMuIENvbnNpZGVyaW5nIHRoYXQgY3BnIGNhbid0IGJlIHNwbGl0IGJldHdlZW4N
Cj4gPiB0aGUgRG9tYWlucywgd2UgZ2V0IHRoZSBsaW1pdGF0aW9uIHRoYXQgdGhlIGRldmljZXMs
IHdoaWNoIGFyZSB1c2luZw0KPiA+IHBvd2VyLWRvbWFpbnMvY2xvY2tzL3Jlc2V0cyBldGMsIGNv
dWxkbid0IGJlIHNwbGl0IGJldHdlZW4gdGhlIGRvbWFpbnMuDQo+ID4gVGhlIHNvbHV0aW9uIGlz
IHRvIG1vdmUgdGhlIHBvd2VyLWRvbWFpbi9jbG9jay9yZXNldHMgZXRjIHRvIHRoZQ0KPiA+IEZp
cm13YXJlIChzdWNoIGFzIFNDUCBmaXJtd2FyZSBvciBBVEYpIGFuZCBwcm92aWRlIGludGVyZmFj
ZSBmb3IgdGhlDQo+ID4gRG9tYWlucy4gWEVOIHNob3VsZCBoYXZlIGFuIGVudGl0eSwgY2FsZWQg
U0NJLU1lZGlhdG9yLCB3aGljaCBpcw0KPiA+IHJlc3BvbnNpYmxlIGZvciBtZXNzYWdlcyByZWRp
cmVjdGlvbiBiZXR3ZWVuIERvbWFpbnMgYW5kIEZpcm13YXJlIGFuZA0KPiA+IGZvciBwZXJtaXNz
aW9uIGhhbmRsaW5nLg0KPiA+IA0KPiA+IFRoZSBmb2xsb3dpbmcgZmVhdHVyZXMgYXJlIGltcGxl
bWVudGVkOg0KPiA+IC0gcmVxdWVzdCBTQ01JIGNoYW5uZWxzIGZyb20gQVRGIGFuZCBwYXNzIGNo
YW5uZWxzIHRvIERvbWFpbnM7DQo+ID4gLSBzZXQgZGV2aWNlIHBlcm1pc3Npb25zIGZvciBEb21h
aW5zIGJhc2VkIG9uIHRoZSBEb21haW4gcGFydGlhbA0KPiA+IGRldmljZS10cmVlLiBEZXZpY2Vz
IHdpdGggcGVybWlzc2lvbnMgYXJlIGFibGUgdG8gd29yayB3aXRoIGNsb2NrcywNCj4gPiByZXNl
dHMgYW5kIHBvd2VyLWRvbWFpbnMgdmlhIFNDTUk7DQo+ID4gLSByZWRpcmVjdCBzY21pIG1lc3Nh
Z2VzIGZyb20gRG9tYWlucyB0byBBVEYuDQo+IA0KPiBCZWZvcmUgZ29pbmcgbW9yZSBkZWVwbHkg
aW4gdGhlIGNvZGUgSSB3b3VsZCBsaWtlIHRvIGRpc2N1c3MgdGhlIGdlbmVyYWwNCj4gZGVzaWdu
IGhlcmUgYW5kIGFzayBzb21lIHF1ZXN0aW9ucyB0byBwcmV2ZW50IHRvIHJld29yayB0aGUgY29k
ZSBiZWZvcmUNCj4gd2UgYWxsIGFncmVlIHRoYXQgdGhpcyBpcyB0aGUgcmlnaHQgc29sdXRpb24g
YW5kIHRoYXQgd2Ugd2FudCB0aGlzIGluIFhlbi4NCj4gDQo+IEZpcnN0IEkgd2FudCB0byBwb2lu
dCBvdXQgdGhhdCBjbG9jay9yZXNldC9wb3dlciB2aXJ0dWFsaXphdGlvbiBpcyBhIHByb2JsZW0N
Cj4gb24gbW9zdCBhcHBsaWNhdGlvbnMgdXNpbmcgZGV2aWNlIHBhc3MtdGhyb3VnaCBhbmQgSSBh
bSB2ZXJ5IGdsYWQgdGhhdA0KPiBzb21lb25lIGlzIGxvb2tpbmcgaW50byBpdC4NCj4gQWxzbyBT
Q01JIGlzIHRoZSBjdXJyZW50IHN0YW5kYXJkIGV4aXN0aW5nIGZvciB0aGlzIHNvIHJlbHlpbmcg
b24gaXQgaXMgYSB2ZXJ5DQo+IGdvb2QgaWRlYS4NCj4gDQo+IExhdGVzdCB2ZXJzaW9uIFNDTUkg
c3RhbmRhcmQgKERFTjAwNTZEIHYzLjEpIGlzIGRlZmluaW5nIHNvbWUgbWVhbnMNCj4gdG8gdXNl
IFNDTUkgb24gYSB2aXJ0dWFsaXNlZCBzeXN0ZW0uIEluIGNoYXB0ZXIgNC4yLjEsIHRoZSBzdGFu
ZGFyZA0KPiByZWNvbW1lbmRzIHRvIHNldCBwZXJtaXNzaW9ucyBwZXIgYWdlbnQgaW4gdGhlIGh5
cGVydmlzb3Igc28gdGhhdCBhIFZNDQo+IGNvdWxkIGxhdGVyIHVzZSB0aGUgZGlzY292ZXJ5IHBy
b3RvY29sIHRvIGRldGVjdCB0aGUgcmVzb3VyY2VzIGFuZCB1c2UgdGhlbS4NCj4gVXNpbmcgdGhp
cyBraW5kIG9mIHNjZW5hcmlvIHRoZSBtZWRpYXRvciBpbiBYZW4gd291bGQganVzdCBjb25maWd1
cmUgdGhlDQo+IFBlcm1pc3Npb25zIGluIHRoZSBTQ01JIGFuZCB3b3VsZCB0aGVuIHJlbHkgb24g
aXQgdG8gbGltaXQgd2hhdCBpcyBwb3NzaWJsZQ0KPiBieSB3aG8ganVzdCBieSBqdXN0IGFzc2ln
bmluZyBhIGNoYW5uZWwgdG8gYSBWTS4NCg0KPiANCj4gSW4geW91ciBjdXJyZW50IGRlc2lnbiAo
cGxlYXNlIGNvcnJlY3QgbWUgaWYgSSBhbSB3cm9uZykgeW91IHNlZW0gdG8gZnVsbHkNCj4gcmVs
eSBvbiBYZW4gYW5kIHRoZSBGRFQgZm9yIGRpc2NvdmVyeSBhbmQgcGVybWlzc2lvbi4NCg0KSW4g
Y3VycmVudCBpbXBsZW1lbnRhdGlvbiBYZW4gaXMgdGhlIHRydXN0ZWQgYWdlbnQuIEFuZCBpdCdz
IHJlc3BvbnNpYmxlDQpmb3IgcGVybWlzc2lvbnMgc2V0dGluZy4gRHVyaW5nIGluaXRpYWxpemF0
aW9uIGl0IGRpc2NvdmVycyBhZ2VudCBhbmQNCnNldCBwZXJtaXNzaW9ucyBieSB1c2luZyBCQVNF
X1NFVF9ERVZJQ0VfUEVSTUlTU0lPTlMgdG8gdGhlIERvbTAuIFdoZW4NCm5ldyBkb21haW4gaXMg
Y3JlYXRlZCwgWGVuIGFzc2lnbnMgYWdlbnQgaWQgZm9yIHRoaXMgZG9tYWluIGFuZCByZXF1ZXN0
DQpyZXNvdXJjZXMsIHRoYXQgYXJlIHBhc3NlZC10aHJvdWdoIHRvIHRoaXMgRG9tYWluLg0KDQpJ
J20gZ2V0dGluZyB0aGUgZm9sbHdpbmcgaW5mb3JtYXRpb24gZnJvbSBGRFQ6DQoxKSBTaGFyZWQg
bWVtb3J5IGFkZHJlc3NlZCwgd2hpY2ggc2hvdWxkIGJlIHVzZWQgZm9yIGFnZW50cy4gRHVyaW5n
DQppbml0aWFsaXphdGlvbiBJIHNlbmQgQkFTRV9ESVNDT1ZFUl9BR0VOVCB0byBlYWNoIG9mIHRo
aXMgYWRkcmVzc2VzIGFuZA0KcmVjZWl2ZSBhZ2VudF9pZC4gWGVuIGlzIHJlc3BvbnNpYmxlIGZv
ciBhc3NpZ25pbmcgYWdlbnRfaWQgZm9yIHRoZQ0KRG9tYWluLiBUaGVuIFhlbiBpbnRlcmNlcHQg
c21jIGNhbGxzIGZyb20gdGhlIGRvbWFpbiwgc2V0IGFnZW50X2lkIGFuZA0KcmVkaXJlY3RzIGl0
IHRvIHRoZSBGaXJtd2FyZS4NCg0KMikgRGV2aWNlcywgdGhhdCBhcmUgdXNpbmcgU0NNSS4gVGhv
c2UgZGV2aWNlcyBoYXMgY2xvY2svcG93ZXIvcmVzZXRzDQpldGMgcmVsYXRlZCB0byBzY21pIHBy
b3RvY29sIChhcyBpdCBpcyBkb25lIGluIExpbnV4IGtlcm5lbCkNCmFuZCBzY21pX2RldmlkIHNo
b3VsZCBiZSBzZXQuIEknbSBjdXJyZW50bHkgcHJlcGFyaW5nIHRvIHNlbmQgcGF0Y2gsDQp1cGRh
dGluZyBrZXJuZWwgYmluZGluZ3Mgd2l0aCB0aGlzIHBhcmFtZXRlciB0byBMaW51eCBrZXJuZWwu
DQpzY21pX2RldmlkIHZhbHVlIHNob3VsZCBtYXRjaCBkZXZpY2UgaWQsIHNldCBpbiB0aGUgRmly
bXdhcmUuDQpkdCBleGFtcGxlOg0KJnVzYjAgew0KICAgIHNjbWlfZGV2aWQgPSA8MT47IC8vIHVz
YjAgZGV2aWNlIGlkDQogICAgY2xvY2tzID0gPCZzY21pX2Nsb2NrIDE+IC8vIHJlbGF5cyBvbiBj
bG9jayB3aXRoIGlkIDENCn0NCg0KWGVuIHJlcXVlc3RzIHBlcm1pc3Npb24gZm9yIHRoZSBkZXZp
Y2Ugd2hlbiBkZXZpY2UgaXMgYXR0YWNoZWQgdG8gdGhlDQpEb21haW4gZHVyaW5nIGNyZWF0aW9u
Lg0KDQo+IFdvdWxkbuKAmXQgaXQgYmUgYSBiZXR0ZXIgaWRlYSB0byB1c2UgdGhlIHByb3RvY29s
IGZ1bGx5ID8NCg0KSG0sIEkgd2FzIHRoaW5raW5nIEkgYW0gdXNpbmcgdGhlIHByb3RvY29sIGZ1
bGx5LiBEaWQgSSBtaXNzIHNvbWV0aGluZz8NCg0KPiBDb3VsZCB3ZSBnZXQgcmlkIG9mIHNvbWUg
b2YgdGhlIEZEVCBkZXBlbmRlbmNpZXMgYnkgdXNpbmcgdGhlIGRpc2NvdmVyeQ0KPiBzeXN0ZW0g
b2YgU0NNSSA/DQoNCkknbSB1c2luZyBGRFQgdG8gZ2V0IHNobWVtIHJlZ2lvbnMgZm9yIHRoZSBj
aGFubmVscy4gVGhlbiBJIHNlbmQNCkJBU0VfRElTQ09WRVJfQUdFTlQgdG8gZWFjaCByZWdpb24g
YW5kIGdldHRpbmcgYWdlbnQgZGF0YS4gRGlkIEkgdXNlIHRoZQ0KZGlzY292ZXJ5IHN5c3RlbSB3
cm9uZz8NCg0KPiBIb3cgaXMgTGludXggZG9pbmcgdGhpcyBjdXJyZW50bHkgPyBJcyBpdCByZWx5
aW5nIG9uIGRldmljZSB0cmVlIHRvIGRpc2NvdmVyDQo+ICB0aGUgU0NNSSByZXNvdXJjZXMgPw0K
DQpZZXMuIExpbnV4IGtlcm5lbCBoYXMgMiBub2RlcyBpbiB0aGUgZGV2aWNlLXRyZWU6IGFybSxz
Y21pLXNobWVtLCB3aGljaA0KaW5jbHVkZXMgbWVtb3J5IHJlZ2lvbiBmb3IgdGhlIGNvbW11bmlj
YXRpb24gYW5kIGFybSxzY21pLXNtYyBub2RlLA0Kd2hpY2ggZGVzY3JpYmVzIGFsbCBkYXRhIHJl
bGF0ZWQgdG8gc2NtaSAoIGZ1bmNfaWQsIHByb3RvY29scyBldGMpDQpUaGVuIHRoZSBkZXZpY2Ug
bm9kZXMgcmVmZXIgdG8gdGhlIHByb3RvY29scyBieSBzZXR0aW5nDQpjbG9jay9yZXNldHMvcG93
ZXItZG9tYWlucyBldGMuIFBsZWFzZSBzZWUgdGhlIGV4YW1wbGUgYWJvdmUuDQpCQVNFX0RJU0NP
VkVSX0FHRU5UIGlzIG5vdCB1c2VkIGluIExpbnV4IGtlcm5lbC4NClRoZSBtYWluIGlkZWEgd2Fz
IHRoYXQgc2NtaSByZWxhdGVkIGNoYW5nZXMgdG8gdGhlIGRldmljZS10cmVlIGFyZQ0KY29tbW9u
IGZvciB2aXJ0dWFsaXplZCBhbmQgbm9uIHZpcnR1YWxpemVkIHN5c3RlbXMuIFNvIHRoZSBzYW1l
IEZEVA0KY29uZmlndXJhdGlvbiBzaG91bGQgd29yayB3aXRoIG9mIHdpdGhvdXQgWGVuLg0KDQo+
IA0KPiBBbHNvIEkgdW5kZXJzdGFuZCB0aGF0IHlvdSByZWx5IG9uIHNvbWUgZW50cmllcyB0byBi
ZSBkZWNsYXJlZCBpbiB0aGUgZGV2aWNlDQo+IHRyZWUgYW5kIGFsc28gc29tZSBzdXBwb3J0IHRv
IGJlIGltcGxlbWVudGVkIGluIEFURiBvciBTQ1AuIEkgY2hlY2tlZCBpbg0KPiBUaGUgYm9hcmRz
IEkgaGF2ZSBhY2Nlc3MgdG8gYW5kIHRoZSBkZXZpY2UgdHJlZXMgYnV0IG5vbmUgb2YgdGhpcyBz
ZWVtIHRvDQo+IGJlIHN1cHBvcnRlZCB0aGVyZS4gQ291bGQgeW91IHRlbGwgd2hpY2ggYm9hcmQv
Y29uZmlndXJhdGlvbi9BVEYgeW91IGFyZQ0KPiB1c2luZyBzbyB0aGF0IHRoZSBpbXBsZW1lbnRh
dGlvbiBjb3VsZCBiZSB0ZXN0ZWQvdmFsaWRhdGVkID8NCj4gDQoNCldlJ3JlIGN1cnJlbnRseSBo
YXZlIFBPQyBtYWRlIGZvciByOGE3Nzk1MS11bGNiLWtmIGFuZA0KcjhhNzc5NjEtc2FsdmF0b3It
eHMgYm9hcmRzLiBJdCdzIGJhc2VkIG9uOg0KTGludXgtYnNwIGtlcm5lbDogDQpnaXRAZ2l0aHVi
LmNvbTpyZW5lc2FzLXJjYXIvbGludXgtYnNwLmdpdA0KYmFzZWQgb24gdGFnIDxyY2FyLTUuMC4w
LnJjND4NCg0KQVRGOiANCmdpdEBnaXRodWIuY29tOnJlbmVzYXMtcmNhci9hcm0tdHJ1c3RlZC1m
aXJtd2FyZS5naXQNCmJhc2VkIG9uIGJyYW5jaCA8cmNhcl9nZW4zX3YyLjU+DQoNCkkgY2FuIHB1
c2ggdGhvc2UgY2hhbmdlcyB0byBHaXRodWIsIHNvIHlvdSBjYW4gcmV2aWV3IHRoZW0uDQoNCkJl
c3QgcmVnYXJkcywNCk9sZWtzaWkuDQoNCj4gDQo+IFJlZ2FyZHMNCj4gQmVydHJhbmQNCj4gDQo+
IA0KPiA+IA0KPiA+IFNpZ25lZC1vZmYtYnk6IE9sZWtzaWkgTW9pc2llaWV2IDxvbGVrc2lpX21v
aXNpZWlldkBlcGFtLmNvbT4NCj4gPiAtLS0NCj4gPiB4ZW4vYXJjaC9hcm0vS2NvbmZpZyAgICAg
ICAgfCAgIDIgKw0KPiA+IHhlbi9hcmNoL2FybS9zY2kvS2NvbmZpZyAgICB8ICAxMCArDQo+ID4g
eGVuL2FyY2gvYXJtL3NjaS9zY21pX3NtYy5jIHwgOTU5ICsrKysrKysrKysrKysrKysrKysrKysr
KysrKysrKysrKysrKw0KPiA+IDMgZmlsZXMgY2hhbmdlZCwgOTcxIGluc2VydGlvbnMoKykNCj4g
PiBjcmVhdGUgbW9kZSAxMDA2NDQgeGVuL2FyY2gvYXJtL3NjaS9LY29uZmlnDQo+ID4gY3JlYXRl
IG1vZGUgMTAwNjQ0IHhlbi9hcmNoL2FybS9zY2kvc2NtaV9zbWMuYw0KPiA+IA0KPiA+IGRpZmYg
LS1naXQgYS94ZW4vYXJjaC9hcm0vS2NvbmZpZyBiL3hlbi9hcmNoL2FybS9LY29uZmlnDQo+ID4g
aW5kZXggYWIwNzgzMzU4Mi4uM2IwZGZjNTdiNiAxMDA2NDQNCj4gPiAtLS0gYS94ZW4vYXJjaC9h
cm0vS2NvbmZpZw0KPiA+ICsrKyBiL3hlbi9hcmNoL2FybS9LY29uZmlnDQo+ID4gQEAgLTEyMyw2
ICsxMjMsOCBAQCBjb25maWcgQVJNX1NDSQ0KPiA+IAkgIHN1cHBvcnQuIEl0IGFsbG93cyBndWVz
dHMgdG8gY29udHJvbCBzeXN0ZW0gcmVzb3VyY2VzcyB2aWEgb25lIG9mDQo+ID4gCSAgQVJNX1ND
SSBtZWRpYXRvcnMgaW1wbGVtZW50ZWQgaW4gWEVOLg0KPiA+IA0KPiA+ICsJc291cmNlICJhcmNo
L2FybS9zY2kvS2NvbmZpZyINCj4gPiArDQo+ID4gZW5kbWVudQ0KPiA+IA0KPiA+IG1lbnUgIkFS
TSBlcnJhdGEgd29ya2Fyb3VuZCB2aWEgdGhlIGFsdGVybmF0aXZlIGZyYW1ld29yayINCj4gPiBk
aWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL3NjaS9LY29uZmlnIGIveGVuL2FyY2gvYXJtL3NjaS9L
Y29uZmlnDQo+ID4gbmV3IGZpbGUgbW9kZSAxMDA2NDQNCj4gPiBpbmRleCAwMDAwMDAwMDAwLi4x
MGI2MzRkMmVkDQo+ID4gLS0tIC9kZXYvbnVsbA0KPiA+ICsrKyBiL3hlbi9hcmNoL2FybS9zY2kv
S2NvbmZpZw0KPiA+IEBAIC0wLDAgKzEsMTAgQEANCj4gPiArY29uZmlnIFNDTUlfU01DDQo+ID4g
Kwlib29sICJFbmFibGUgU0NNSS1TTUMgbWVkaWF0b3IgZHJpdmVyIg0KPiA+ICsJZGVmYXVsdCBu
DQo+ID4gKwlkZXBlbmRzIG9uIEFSTV9TQ0kgJiYgSE9TVF9EVEJfRVhQT1JUDQo+ID4gKwktLS1o
ZWxwLS0tDQo+ID4gKw0KPiA+ICsJRW5hYmxlcyBtZWRpYXRvciBpbiBYRU4gdG8gcGFzcyBTQ01J
IHJlcXVlc3RzIGZyb20gRG9tYWlucyB0byBBVEYuDQo+ID4gKwlUaGlzIGZlYXR1cmUgYWxsb3dz
IGRyaXZlcnMgZnJvbSBEb21haW5zIHRvIHdvcmsgd2l0aCBTeXN0ZW0NCj4gPiArCUNvbnRyb2xs
ZXJzIChzdWNoIGFzIHBvd2VyLHJlc2V0cyxjbG9jayBldGMuKS4gU0NQIGlzIHVzZWQgYXMgdHJh
bnNwb3J0DQo+ID4gKwlmb3IgY29tbXVuaWNhdGlvbi4NCj4gPiBkaWZmIC0tZ2l0IGEveGVuL2Fy
Y2gvYXJtL3NjaS9zY21pX3NtYy5jIGIveGVuL2FyY2gvYXJtL3NjaS9zY21pX3NtYy5jDQo+ID4g
bmV3IGZpbGUgbW9kZSAxMDA2NDQNCj4gPiBpbmRleCAwMDAwMDAwMDAwLi4xMDM1MjlkZmFiDQo+
ID4gLS0tIC9kZXYvbnVsbA0KPiA+ICsrKyBiL3hlbi9hcmNoL2FybS9zY2kvc2NtaV9zbWMuYw0K
PiA+IEBAIC0wLDAgKzEsOTU5IEBADQo+ID4gKy8qDQo+ID4gKyAqIHhlbi9hcmNoL2FybS9zY2kv
c2NtaV9zbWMuYw0KPiA+ICsgKg0KPiA+ICsgKiBTQ01JIG1lZGlhdG9yIGRyaXZlciwgdXNpbmcg
U0NQIGFzIHRyYW5zcG9ydC4NCj4gPiArICoNCj4gPiArICogT2xla3NpaSBNb2lzaWVpZXYgPG9s
ZWtzaWlfbW9pc2llaWV2QGVwYW0uY29tPg0KPiA+ICsgKiBDb3B5cmlnaHQgKEMpIDIwMjEsIEVQ
QU0gU3lzdGVtcy4NCj4gPiArICoNCj4gPiArICogVGhpcyBwcm9ncmFtIGlzIGZyZWUgc29mdHdh
cmU7IHlvdSBjYW4gcmVkaXN0cmlidXRlIGl0IGFuZC9vciBtb2RpZnkNCj4gPiArICogaXQgdW5k
ZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSBhcyBwdWJsaXNo
ZWQgYnkNCj4gPiArICogdGhlIEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbjsgZWl0aGVyIHZlcnNp
b24gMiBvZiB0aGUgTGljZW5zZSwgb3INCj4gPiArICogKGF0IHlvdXIgb3B0aW9uKSBhbnkgbGF0
ZXIgdmVyc2lvbi4NCj4gPiArICoNCj4gPiArICogVGhpcyBwcm9ncmFtIGlzIGRpc3RyaWJ1dGVk
IGluIHRoZSBob3BlIHRoYXQgaXQgd2lsbCBiZSB1c2VmdWwsDQo+ID4gKyAqIGJ1dCBXSVRIT1VU
IEFOWSBXQVJSQU5UWTsgd2l0aG91dCBldmVuIHRoZSBpbXBsaWVkIHdhcnJhbnR5IG9mDQo+ID4g
KyAqIE1FUkNIQU5UQUJJTElUWSBvciBGSVRORVNTIEZPUiBBIFBBUlRJQ1VMQVIgUFVSUE9TRS4g
IFNlZSB0aGUNCj4gPiArICogR05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2UgZm9yIG1vcmUgZGV0
YWlscy4NCj4gPiArICovDQo+ID4gKw0KPiA+ICsjaW5jbHVkZSA8YXNtL3NjaS9zY2kuaD4NCj4g
PiArI2luY2x1ZGUgPGFzbS9zbWNjYy5oPg0KPiA+ICsjaW5jbHVkZSA8YXNtL2lvLmg+DQo+ID4g
KyNpbmNsdWRlIDx4ZW4vYml0b3BzLmg+DQo+ID4gKyNpbmNsdWRlIDx4ZW4vY29uZmlnLmg+DQo+
ID4gKyNpbmNsdWRlIDx4ZW4vc2NoZWQuaD4NCj4gPiArI2luY2x1ZGUgPHhlbi9kZXZpY2VfdHJl
ZS5oPg0KPiA+ICsjaW5jbHVkZSA8eGVuL2lvY2FwLmg+DQo+ID4gKyNpbmNsdWRlIDx4ZW4vaW5p
dC5oPg0KPiA+ICsjaW5jbHVkZSA8eGVuL2Vyci5oPg0KPiA+ICsjaW5jbHVkZSA8eGVuL2xpYi5o
Pg0KPiA+ICsjaW5jbHVkZSA8eGVuL2xpc3QuaD4NCj4gPiArI2luY2x1ZGUgPHhlbi9tbS5oPg0K
PiA+ICsjaW5jbHVkZSA8eGVuL3N0cmluZy5oPg0KPiA+ICsjaW5jbHVkZSA8eGVuL3RpbWUuaD4N
Cj4gPiArI2luY2x1ZGUgPHhlbi92bWFwLmg+DQo+ID4gKw0KPiA+ICsjZGVmaW5lIFNDTUlfQkFT
RV9QUk9UT0NPTCAgICAgICAgICAgICAgICAgIDB4MTANCj4gPiArI2RlZmluZSBTQ01JX0JBU0Vf
UFJPVE9DT0xfQVRUSUJVVEVTICAgICAgICAweDENCj4gPiArI2RlZmluZSBTQ01JX0JBU0VfU0VU
X0RFVklDRV9QRVJNSVNTSU9OUyAgICAweDkNCj4gPiArI2RlZmluZSBTQ01JX0JBU0VfUkVTRVRf
QUdFTlRfQ09ORklHVVJBVElPTiAweEINCj4gPiArI2RlZmluZSBTQ01JX0JBU0VfRElTQ09WRVJf
QUdFTlQgICAgICAgICAgICAweDcNCj4gPiArDQo+ID4gKy8qIFNDTUkgcmV0dXJuIGNvZGVzLiBT
ZWUgc2VjdGlvbiA0LjEuNCBvZiBTQ01JIHNwZWMgKERFTjAwNTZDKSAqLw0KPiA+ICsjZGVmaW5l
IFNDTUlfU1VDQ0VTUyAgICAgICAgICAgICAgMA0KPiA+ICsjZGVmaW5lIFNDTUlfTk9UX1NVUFBP
UlRFRCAgICAgICgtMSkNCj4gPiArI2RlZmluZSBTQ01JX0lOVkFMSURfUEFSQU1FVEVSUyAoLTIp
DQo+ID4gKyNkZWZpbmUgU0NNSV9ERU5JRUQgICAgICAgICAgICAgKC0zKQ0KPiA+ICsjZGVmaW5l
IFNDTUlfTk9UX0ZPVU5EICAgICAgICAgICgtNCkNCj4gPiArI2RlZmluZSBTQ01JX09VVF9PRl9S
QU5HRSAgICAgICAoLTUpDQo+ID4gKyNkZWZpbmUgU0NNSV9CVVNZICAgICAgICAgICAgICAgKC02
KQ0KPiA+ICsjZGVmaW5lIFNDTUlfQ09NTVNfRVJST1IgICAgICAgICgtNykNCj4gPiArI2RlZmlu
ZSBTQ01JX0dFTkVSSUNfRVJST1IgICAgICAoLTgpDQo+ID4gKyNkZWZpbmUgU0NNSV9IQVJEV0FS
RV9FUlJPUiAgICAgKC05KQ0KPiA+ICsjZGVmaW5lIFNDTUlfUFJPVE9DT0xfRVJST1IgICAgICgt
MTApDQo+ID4gKw0KPiA+ICsjZGVmaW5lIERUX01BVENIX1NDTUlfU01DIERUX01BVENIX0NPTVBB
VElCTEUoImFybSxzY21pLXNtYyIpDQo+ID4gKw0KPiA+ICsjZGVmaW5lIFNDTUlfU01DX0lEICAg
ICAgICAgICAgICAgICAgICAgICAgImFybSxzbWMtaWQiDQo+ID4gKyNkZWZpbmUgU0NNSV9TSEFS
RURfTUVNT1JZICAgICAgICAgICAgICAgICAiYXJtLHNjbWktc2htZW0iDQo+ID4gKyNkZWZpbmUg
U0NNSV9TSE1FTSAgICAgICAgICAgICAgICAgICAgICAgICAic2htZW0iDQo+ID4gKyNkZWZpbmUg
U0NNSV9TSE1FTV9NQVBQRURfU0laRSAgICAgICAgICAgICBQQUdFX1NJWkUNCj4gPiArDQo+ID4g
KyNkZWZpbmUgSFlQX0NIQU5ORUwgICAgICAgICAgICAgICAgICAgICAgICAgIDB4MA0KPiA+ICsN
Cj4gPiArI2RlZmluZSBIRFJfSUQgICAgICAgICAgICAgICAgICAgICAgICAgICAgIEdFTk1BU0so
NywwKQ0KPiA+ICsjZGVmaW5lIEhEUl9UWVBFICAgICAgICAgICAgICAgICAgICAgICAgICAgR0VO
TUFTSyg5LCA4KQ0KPiA+ICsjZGVmaW5lIEhEUl9QUk9UTyAgICAgICAgICAgICAgICAgICAgICAg
ICAgR0VOTUFTSygxNywgMTApDQo+ID4gKw0KPiA+ICsvKiBTQ01JIHByb3RvY29sLCByZWZlciB0
byBzZWN0aW9uIDQuMi4yLjIgKERFTjAwNTZDKSAqLw0KPiA+ICsjZGVmaW5lIE1TR19OX0FHRU5U
U19NQVNLICAgICAgICAgICAgICAgICAgR0VOTUFTSygxNSwgOCkNCj4gPiArDQo+ID4gKyNkZWZp
bmUgRklFTERfR0VUKF9tYXNrLCBfcmVnKVwNCj4gPiArICAgICgodHlwZW9mKF9tYXNrKSkoKChf
cmVnKSAmIChfbWFzaykpID4+IChmZnM2NChfbWFzaykgLSAxKSkpDQo+ID4gKyNkZWZpbmUgRklF
TERfUFJFUChfbWFzaywgX3ZhbClcDQo+ID4gKyAgICAoKCh0eXBlb2YoX21hc2spKShfdmFsKSA8
PCAoZmZzNjQoX21hc2spIC0gMSkpICYgKF9tYXNrKSkNCj4gPiArDQo+ID4gK3R5cGVkZWYgc3Ry
dWN0IHNjbWlfbXNnX2hlYWRlciB7DQo+ID4gKyAgICB1aW50OF90IGlkOw0KPiA+ICsgICAgdWlu
dDhfdCB0eXBlOw0KPiA+ICsgICAgdWludDhfdCBwcm90b2NvbDsNCj4gPiArfSBzY21pX21zZ19o
ZWFkZXJfdDsNCj4gPiArDQo+ID4gKyNkZWZpbmUgU0NNSV9TSE1FTV9DSEFOX1NUQVRfQ0hBTk5F
TF9GUkVFICAgQklUKDAsIFVMKQ0KPiA+ICsjZGVmaW5lIFNDTUlfU0hNRU1fQ0hBTl9TVEFUX0NI
QU5ORUxfRVJST1IgIEJJVCgxLCBVTCkNCj4gPiArDQo+ID4gKyNkZWZpbmUgU0NNSV9BTExPV19B
Q0NFU1MgICAgICAgICAgICAgICAgICAgQklUKDAsIFVMKQ0KPiA+ICsNCj4gPiArc3RydWN0IHNj
bWlfc2hhcmVkX21lbSB7DQo+ID4gKyAgICB1aW50MzJfdCByZXNlcnZlZDsNCj4gPiArICAgIHVp
bnQzMl90IGNoYW5uZWxfc3RhdHVzOw0KPiA+ICsgICAgdWludDMyX3QgcmVzZXJ2ZWQxWzJdOw0K
PiA+ICsgICAgdWludDMyX3QgZmxhZ3M7DQo+ID4gKyAgICB1aW50MzJfdCBsZW5ndGg7DQo+ID4g
KyAgICB1aW50MzJfdCBtc2dfaGVhZGVyOw0KPiA+ICsgICAgdWludDhfdCBtc2dfcGF5bG9hZFtd
Ow0KPiA+ICt9Ow0KPiA+ICsNCj4gPiArc3RydWN0IGR0X2NoYW5uZWxfYWRkciB7DQo+ID4gKyAg
ICB1NjQgYWRkcjsNCj4gPiArICAgIHU2NCBzaXplOw0KPiA+ICsgICAgc3RydWN0IGxpc3RfaGVh
ZCBsaXN0Ow0KPiA+ICt9Ow0KPiA+ICsNCj4gPiArc3RydWN0IHNjbWlfY2hhbm5lbCB7DQo+ID4g
KyAgICBpbnQgY2hhbl9pZDsNCj4gPiArICAgIGludCBhZ2VudF9pZDsNCj4gPiArICAgIHVpbnQz
Ml90IGZ1bmNfaWQ7DQo+ID4gKyAgICBkb21pZF90IGRvbWFpbl9pZDsNCj4gPiArICAgIHVpbnQ2
NF90IHBhZGRyOw0KPiA+ICsgICAgdWludDY0X3QgbGVuOw0KPiA+ICsgICAgc3RydWN0IHNjbWlf
c2hhcmVkX21lbSAqc2htZW07DQo+ID4gKyAgICBzcGlubG9ja190IGxvY2s7DQo+ID4gKyAgICBz
dHJ1Y3QgbGlzdF9oZWFkIGxpc3Q7DQo+ID4gK307DQo+ID4gKw0KPiA+ICtzdHJ1Y3Qgc2NtaV9k
YXRhIHsNCj4gPiArICAgIHN0cnVjdCBsaXN0X2hlYWQgY2hhbm5lbF9saXN0Ow0KPiA+ICsgICAg
c3BpbmxvY2tfdCBjaGFubmVsX2xpc3RfbG9jazsNCj4gPiArICAgIGJvb2wgaW5pdGlhbGl6ZWQ7
DQo+ID4gK307DQo+ID4gKw0KPiA+ICtzdGF0aWMgc3RydWN0IHNjbWlfZGF0YSBzY21pX2RhdGE7
DQo+ID4gKw0KPiA+ICsNCj4gPiArLyoNCj4gPiArICogcGFja19zY21pX2hlYWRlcigpIC0gcGFj
a3MgYW5kIHJldHVybnMgMzItYml0IGhlYWRlcg0KPiA+ICsgKg0KPiA+ICsgKiBAaGRyOiBwb2lu
dGVyIHRvIGhlYWRlciBjb250YWluaW5nIGFsbCB0aGUgaW5mb3JtYXRpb24gb24gbWVzc2FnZSBp
ZCwNCj4gPiArICogICAgcHJvdG9jb2wgaWQgYW5kIHR5cGUgaWQuDQo+ID4gKyAqDQo+ID4gKyAq
IFJldHVybjogMzItYml0IHBhY2tlZCBtZXNzYWdlIGhlYWRlciB0byBiZSBzZW50IHRvIHRoZSBw
bGF0Zm9ybS4NCj4gPiArICovDQo+ID4gK3N0YXRpYyBpbmxpbmUgdWludDMyX3QgcGFja19zY21p
X2hlYWRlcihzY21pX21zZ19oZWFkZXJfdCAqaGRyKQ0KPiA+ICt7DQo+ID4gKyAgICByZXR1cm4g
RklFTERfUFJFUChIRFJfSUQsIGhkci0+aWQpIHwNCj4gPiArICAgICAgICBGSUVMRF9QUkVQKEhE
Ul9UWVBFLCBoZHItPnR5cGUpIHwNCj4gPiArICAgICAgICBGSUVMRF9QUkVQKEhEUl9QUk9UTywg
aGRyLT5wcm90b2NvbCk7DQo+ID4gK30NCj4gPiArDQo+ID4gKy8qDQo+ID4gKyAqIHVucGFja19z
Y21pX2hlYWRlcigpIC0gdW5wYWNrcyBhbmQgcmVjb3JkcyBtZXNzYWdlIGFuZCBwcm90b2NvbCBp
ZA0KPiA+ICsgKg0KPiA+ICsgKiBAbXNnX2hkcjogMzItYml0IHBhY2tlZCBtZXNzYWdlIGhlYWRl
ciBzZW50IGZyb20gdGhlIHBsYXRmb3JtDQo+ID4gKyAqIEBoZHI6IHBvaW50ZXIgdG8gaGVhZGVy
IHRvIGZldGNoIG1lc3NhZ2UgYW5kIHByb3RvY29sIGlkLg0KPiA+ICsgKi8NCj4gPiArc3RhdGlj
IGlubGluZSB2b2lkIHVucGFja19zY21pX2hlYWRlcih1aW50MzJfdCBtc2dfaGRyLCBzY21pX21z
Z19oZWFkZXJfdCAqaGRyKQ0KPiA+ICt7DQo+ID4gKyAgICBoZHItPmlkID0gRklFTERfR0VUKEhE
Ul9JRCwgbXNnX2hkcik7DQo+ID4gKyAgICBoZHItPnR5cGUgPSBGSUVMRF9HRVQoSERSX1RZUEUs
IG1zZ19oZHIpOw0KPiA+ICsgICAgaGRyLT5wcm90b2NvbCA9IEZJRUxEX0dFVChIRFJfUFJPVE8s
IG1zZ19oZHIpOw0KPiA+ICt9DQo+ID4gKw0KPiA+ICtzdGF0aWMgaW5saW5lIGludCBjaGFubmVs
X2lzX2ZyZWUoc3RydWN0IHNjbWlfY2hhbm5lbCAqY2hhbl9pbmZvKQ0KPiA+ICt7DQo+ID4gKyAg
ICByZXR1cm4gKCBjaGFuX2luZm8tPnNobWVtLT5jaGFubmVsX3N0YXR1cw0KPiA+ICsgICAgICAg
ICAgICAmIFNDTUlfU0hNRU1fQ0hBTl9TVEFUX0NIQU5ORUxfRlJFRSApID8gMCA6IC1FQlVTWTsN
Cj4gPiArfQ0KPiA+ICsNCj4gPiArLyoNCj4gPiArICogQ29weSBkYXRhIGZyb20gSU8gbWVtb3J5
IHNwYWNlIHRvICJyZWFsIiBtZW1vcnkgc3BhY2UuDQo+ID4gKyAqLw0KPiA+ICt2b2lkIF9fbWVt
Y3B5X2Zyb21pbyh2b2lkICp0bywgY29uc3Qgdm9sYXRpbGUgdm9pZCBfX2lvbWVtICpmcm9tLCBz
aXplX3QgY291bnQpDQo+ID4gK3sNCj4gPiArICAgIHdoaWxlIChjb3VudCAmJiAhSVNfQUxJR05F
RCgodW5zaWduZWQgbG9uZylmcm9tLCA0KSkgew0KPiA+ICsgICAgICAgICoodTggKil0byA9IF9f
cmF3X3JlYWRiKGZyb20pOw0KPiA+ICsgICAgICAgIGZyb20rKzsNCj4gPiArICAgICAgICB0bysr
Ow0KPiA+ICsgICAgICAgIGNvdW50LS07DQo+ID4gKyAgICB9DQo+ID4gKw0KPiA+ICsgICAgd2hp
bGUgKGNvdW50ID49IDQpIHsNCj4gPiArICAgICAgICAqKHUzMiAqKXRvID0gX19yYXdfcmVhZGwo
ZnJvbSk7DQo+ID4gKyAgICAgICAgZnJvbSArPSA0Ow0KPiA+ICsgICAgICAgIHRvICs9IDQ7DQo+
ID4gKyAgICAgICAgY291bnQgLT0gNDsNCj4gPiArICAgIH0NCj4gPiArDQo+ID4gKyAgICB3aGls
ZSAoY291bnQpIHsNCj4gPiArICAgICAgICAqKHU4ICopdG8gPSBfX3Jhd19yZWFkYihmcm9tKTsN
Cj4gPiArICAgICAgICBmcm9tKys7DQo+ID4gKyAgICAgICAgdG8rKzsNCj4gPiArICAgICAgICBj
b3VudC0tOw0KPiA+ICsgICAgfQ0KPiA+ICt9DQo+ID4gKw0KPiA+ICsvKg0KPiA+ICsgKiBDb3B5
IGRhdGEgZnJvbSAicmVhbCIgbWVtb3J5IHNwYWNlIHRvIElPIG1lbW9yeSBzcGFjZS4NCj4gPiAr
ICovDQo+ID4gK3ZvaWQgX19tZW1jcHlfdG9pbyh2b2xhdGlsZSB2b2lkIF9faW9tZW0gKnRvLCBj
b25zdCB2b2lkICpmcm9tLCBzaXplX3QgY291bnQpDQo+ID4gK3sNCj4gPiArICAgIHdoaWxlIChj
b3VudCAmJiAhSVNfQUxJR05FRCgodW5zaWduZWQgbG9uZyl0bywgNCkpIHsNCj4gPiArICAgICAg
ICBfX3Jhd193cml0ZWIoKih1OCAqKWZyb20sIHRvKTsNCj4gPiArICAgICAgICBmcm9tKys7DQo+
ID4gKyAgICAgICAgdG8rKzsNCj4gPiArICAgICAgICBjb3VudC0tOw0KPiA+ICsgICAgfQ0KPiA+
ICsNCj4gPiArICAgIHdoaWxlIChjb3VudCA+PSA0KSB7DQo+ID4gKyAgICAgICAgX19yYXdfd3Jp
dGVsKCoodTMyICopZnJvbSwgdG8pOw0KPiA+ICsgICAgICAgIGZyb20gKz0gNDsNCj4gPiArICAg
ICAgICB0byArPSA0Ow0KPiA+ICsgICAgICAgIGNvdW50IC09IDQ7DQo+ID4gKyAgICB9DQo+ID4g
Kw0KPiA+ICsgICAgd2hpbGUgKGNvdW50KSB7DQo+ID4gKyAgICAgICAgX19yYXdfd3JpdGViKCoo
dTggKilmcm9tLCB0byk7DQo+ID4gKyAgICAgICAgZnJvbSsrOw0KPiA+ICsgICAgICAgIHRvKys7
DQo+ID4gKyAgICAgICAgY291bnQtLTsNCj4gPiArICAgIH0NCj4gPiArfQ0KPiA+ICsNCj4gPiAr
c3RhdGljIGludCBzZW5kX3NtY19tZXNzYWdlKHN0cnVjdCBzY21pX2NoYW5uZWwgKmNoYW5faW5m
bywNCj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgIHNjbWlfbXNnX2hlYWRlcl90ICpo
ZHIsIHZvaWQgKmRhdGEsIGludCBsZW4pDQo+ID4gK3sNCj4gPiArICAgIHN0cnVjdCBhcm1fc21j
Y2NfcmVzIHJlc3A7DQo+ID4gKyAgICBpbnQgcmV0Ow0KPiA+ICsNCj4gPiArICAgIGlmICggKGxl
biArIHNpemVvZihjaGFuX2luZm8tPnNobWVtLT5tc2dfaGVhZGVyKSkgPg0KPiA+ICsgICAgICAg
ICAgICAgICAgICAgICAgICAgU0NNSV9TSE1FTV9NQVBQRURfU0laRSApDQo+ID4gKyAgICB7DQo+
ID4gKyAgICAgICAgcHJpbnRrKFhFTkxPR19FUlINCj4gPiArICAgICAgICAgICAgICAgInNjbWk6
IFdyb25nIHNpemUgb2Ygc21jIG1lc3NhZ2UuIERhdGEgaXMgaW52YWxpZFxuIik7DQo+ID4gKyAg
ICAgICAgcmV0dXJuIC1FSU5WQUw7DQo+ID4gKyAgICB9DQo+ID4gKw0KPiA+ICsgICAgcHJpbnRr
KFhFTkxPR19ERUJVRyAic2NtaTogc3RhdHVzID0lZCBsZW49JWRcbiIsDQo+ID4gKyAgICAgICAg
ICAgY2hhbl9pbmZvLT5zaG1lbS0+Y2hhbm5lbF9zdGF0dXMsIGxlbik7DQo+ID4gKyAgICBwcmlu
dGsoWEVOTE9HX0RFQlVHICJzY21pOiBoZWFkZXIgaWQgPSAlZCB0eXBlID0gJWQsIHByb3RvID0g
JWRcbiIsDQo+ID4gKyAgICAgICAgICAgaGRyLT5pZCwgaGRyLT50eXBlLCBoZHItPnByb3RvY29s
KTsNCj4gPiArDQo+ID4gKyAgICByZXQgPSBjaGFubmVsX2lzX2ZyZWUoY2hhbl9pbmZvKTsNCj4g
PiArICAgIGlmICggSVNfRVJSX1ZBTFVFKHJldCkgKQ0KPiA+ICsgICAgICAgIHJldHVybiByZXQ7
DQo+ID4gKw0KPiA+ICsgICAgY2hhbl9pbmZvLT5zaG1lbS0+Y2hhbm5lbF9zdGF0dXMgPSAweDA7
DQo+ID4gKyAgICAvKiBXcml0aW5nIDB4MCByaWdodCBub3csIGJ1dCBTQ01JX1NITUVNX0ZMQUdf
SU5UUl9FTkFCTEVEIGNhbiBiZSBzZXQgKi8NCj4gPiArICAgIGNoYW5faW5mby0+c2htZW0tPmZs
YWdzID0gMHgwOw0KPiA+ICsgICAgY2hhbl9pbmZvLT5zaG1lbS0+bGVuZ3RoID0gc2l6ZW9mKGNo
YW5faW5mby0+c2htZW0tPm1zZ19oZWFkZXIpICsgbGVuOw0KPiA+ICsgICAgY2hhbl9pbmZvLT5z
aG1lbS0+bXNnX2hlYWRlciA9IHBhY2tfc2NtaV9oZWFkZXIoaGRyKTsNCj4gPiArDQo+ID4gKyAg
ICBwcmludGsoWEVOTE9HX0RFQlVHICJzY21pOiBXcml0aW5nIHRvIHNobWVtIGFkZHJlc3MgJXBc
biIsDQo+ID4gKyAgICAgICAgICAgY2hhbl9pbmZvLT5zaG1lbSk7DQo+ID4gKyAgICBpZiAoIGxl
biA+IDAgJiYgZGF0YSApDQo+ID4gKyAgICAgICAgX19tZW1jcHlfdG9pbygodm9pZCAqKShjaGFu
X2luZm8tPnNobWVtLT5tc2dfcGF5bG9hZCksIGRhdGEsIGxlbik7DQo+ID4gKw0KPiA+ICsgICAg
YXJtX3NtY2NjX3NtYyhjaGFuX2luZm8tPmZ1bmNfaWQsIDAsIDAsIDAsIDAsIDAsIDAsIGNoYW5f
aW5mby0+Y2hhbl9pZCwNCj4gPiArICAgICAgICAgICAgICAgICAgJnJlc3ApOw0KPiA+ICsNCj4g
PiArICAgIHByaW50ayhYRU5MT0dfREVCVUcgInNjbWk6IHNjbWNjY19zbWMgcmVzcG9uc2UgJWRc
biIsIChpbnQpKHJlc3AuYTApKTsNCj4gPiArDQo+ID4gKyAgICBpZiAoIHJlc3AuYTAgKQ0KPiA+
ICsgICAgICAgIHJldHVybiAtRU9QTk9UU1VQUDsNCj4gPiArDQo+ID4gKyAgICByZXR1cm4gMDsN
Cj4gPiArfQ0KPiA+ICsNCj4gPiArc3RhdGljIGludCBjaGVja19zY21pX3N0YXR1cyhpbnQgc2Nt
aV9zdGF0dXMpDQo+ID4gK3sNCj4gPiArICAgIGlmICggc2NtaV9zdGF0dXMgPT0gU0NNSV9TVUND
RVNTICkNCj4gPiArICAgICAgICByZXR1cm4gMDsNCj4gPiArDQo+ID4gKyAgICBwcmludGsoWEVO
TE9HX0RFQlVHICJzY21pOiBFcnJvciByZWNlaXZlZDogJWRcbiIsIHNjbWlfc3RhdHVzKTsNCj4g
PiArDQo+ID4gKyAgICBzd2l0Y2ggKCBzY21pX3N0YXR1cyApDQo+ID4gKyAgICB7DQo+ID4gKyAg
ICBjYXNlIFNDTUlfTk9UX1NVUFBPUlRFRDoNCj4gPiArICAgICAgICByZXR1cm4gLUVPUE5PVFNV
UFA7DQo+ID4gKyAgICBjYXNlIFNDTUlfSU5WQUxJRF9QQVJBTUVURVJTOg0KPiA+ICsgICAgICAg
IHJldHVybiAtRUlOVkFMOw0KPiA+ICsgICAgY2FzZSBTQ01JX0RFTklFRDoNCj4gPiArICAgICAg
ICByZXR1cm4gLUVBQ0NFUzsNCj4gPiArICAgIGNhc2UgU0NNSV9OT1RfRk9VTkQ6DQo+ID4gKyAg
ICAgICAgcmV0dXJuIC1FTk9FTlQ7DQo+ID4gKyAgICBjYXNlIFNDTUlfT1VUX09GX1JBTkdFOg0K
PiA+ICsgICAgICAgIHJldHVybiAtRVJBTkdFOw0KPiA+ICsgICAgY2FzZSBTQ01JX0JVU1k6DQo+
ID4gKyAgICAgICAgcmV0dXJuIC1FQlVTWTsNCj4gPiArICAgIGNhc2UgU0NNSV9DT01NU19FUlJP
UjoNCj4gPiArICAgICAgICByZXR1cm4gLUVOT1RDT05OOw0KPiA+ICsgICAgY2FzZSBTQ01JX0dF
TkVSSUNfRVJST1I6DQo+ID4gKyAgICAgICAgcmV0dXJuIC1FSU87DQo+ID4gKyAgICBjYXNlIFND
TUlfSEFSRFdBUkVfRVJST1I6DQo+ID4gKyAgICAgICAgcmV0dXJuIC1FTlhJTzsNCj4gPiArICAg
IGNhc2UgU0NNSV9QUk9UT0NPTF9FUlJPUjoNCj4gPiArICAgICAgICByZXR1cm4gLUVCQURNU0c7
DQo+ID4gKyAgICBkZWZhdWx0Og0KPiA+ICsgICAgICAgIHJldHVybiAtRUlOVkFMOw0KPiA+ICsg
ICAgfQ0KPiA+ICt9DQo+ID4gKw0KPiA+ICtzdGF0aWMgaW50IGdldF9zbWNfcmVzcG9uc2Uoc3Ry
dWN0IHNjbWlfY2hhbm5lbCAqY2hhbl9pbmZvLA0KPiA+ICsgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgc2NtaV9tc2dfaGVhZGVyX3QgKmhkciwgdm9pZCAqZGF0YSwgaW50IGxlbikNCj4gPiAr
ew0KPiA+ICsgICAgaW50IHJlY3ZfbGVuOw0KPiA+ICsgICAgaW50IHJldDsNCj4gPiArDQo+ID4g
KyAgICBwcmludGsoWEVOTE9HX0RFQlVHICJzY21pOiBnZXQgc21jIHJlc3BvbmNlIG1zZ2lkICVk
XG4iLCBoZHItPmlkKTsNCj4gPiArDQo+ID4gKyAgICBpZiAoIGxlbiA+PSBTQ01JX1NITUVNX01B
UFBFRF9TSVpFIC0gc2l6ZW9mKGNoYW5faW5mby0+c2htZW0pICkNCj4gPiArICAgIHsNCj4gPiAr
ICAgICAgICBwcmludGsoWEVOTE9HX0VSUg0KPiA+ICsgICAgICAgICAgICAgICAic2NtaTogV3Jv
bmcgc2l6ZSBvZiBpbnB1dCBzbWMgbWVzc2FnZS4gRGF0YSBtYXkgYmUgaW52YWxpZFxuIik7DQo+
ID4gKyAgICAgICAgcmV0dXJuIC1FSU5WQUw7DQo+ID4gKyAgICB9DQo+ID4gKw0KPiA+ICsgICAg
cmV0ID0gY2hhbm5lbF9pc19mcmVlKGNoYW5faW5mbyk7DQo+ID4gKyAgICBpZiAoIElTX0VSUl9W
QUxVRShyZXQpICkNCj4gPiArICAgICAgICByZXR1cm4gcmV0Ow0KPiA+ICsNCj4gPiArICAgIHJl
Y3ZfbGVuID0gY2hhbl9pbmZvLT5zaG1lbS0+bGVuZ3RoIC0gc2l6ZW9mKGNoYW5faW5mby0+c2ht
ZW0tPm1zZ19oZWFkZXIpOw0KPiA+ICsNCj4gPiArICAgIGlmICggcmVjdl9sZW4gPCAwICkNCj4g
PiArICAgIHsNCj4gPiArICAgICAgICBwcmludGsoWEVOTE9HX0VSUg0KPiA+ICsgICAgICAgICAg
ICAgICAic2NtaTogV3Jvbmcgc2l6ZSBvZiBzbWMgbWVzc2FnZS4gRGF0YSBtYXkgYmUgaW52YWxp
ZFxuIik7DQo+ID4gKyAgICAgICAgcmV0dXJuIC1FSU5WQUw7DQo+ID4gKyAgICB9DQo+ID4gKw0K
PiA+ICsgICAgaWYgKCByZWN2X2xlbiA+IGxlbiApDQo+ID4gKyAgICB7DQo+ID4gKyAgICAgICAg
cHJpbnRrKFhFTkxPR19FUlINCj4gPiArICAgICAgICAgICAgICAgInNjbWk6IE5vdCBlbm91Z2gg
YnVmZmVyIGZvciBtZXNzYWdlICVkLCBleHBlY3RpbmcgJWRcbiIsDQo+ID4gKyAgICAgICAgICAg
ICAgIHJlY3ZfbGVuLCBsZW4pOw0KPiA+ICsgICAgICAgIHJldHVybiAtRUlOVkFMOw0KPiA+ICsg
ICAgfQ0KPiA+ICsNCj4gPiArICAgIHVucGFja19zY21pX2hlYWRlcihjaGFuX2luZm8tPnNobWVt
LT5tc2dfaGVhZGVyLCBoZHIpOw0KPiA+ICsNCj4gPiArICAgIGlmICggcmVjdl9sZW4gPiAwICkN
Cj4gPiArICAgIHsNCj4gPiArICAgICAgICBfX21lbWNweV9mcm9taW8oZGF0YSwgY2hhbl9pbmZv
LT5zaG1lbS0+bXNnX3BheWxvYWQsIHJlY3ZfbGVuKTsNCj4gPiArICAgIH0NCj4gPiArDQo+ID4g
KyAgICByZXR1cm4gMDsNCj4gPiArfQ0KPiA+ICsNCj4gPiArc3RhdGljIGludCBkb19zbWNfeGZl
cihzdHJ1Y3Qgc2NtaV9jaGFubmVsICpjaGFubmVsLCBzY21pX21zZ19oZWFkZXJfdCAqaGRyLCB2
b2lkICp0eF9kYXRhLCBpbnQgdHhfc2l6ZSwNCj4gPiArICAgICAgICAgICAgICAgICAgICAgICB2
b2lkICpyeF9kYXRhLCBpbnQgcnhfc2l6ZSkNCj4gPiArew0KPiA+ICsgICAgaW50IHJldCA9IDA7
DQo+ID4gKw0KPiA+ICsgICAgQVNTRVJUKCBjaGFubmVsICYmIGNoYW5uZWwtPnNobWVtKTsNCj4g
PiArDQo+ID4gKyAgICBpZiAoICFoZHIgKQ0KPiA+ICsgICAgICAgIHJldHVybiAtRUlOVkFMOw0K
PiA+ICsNCj4gPiArICAgIHNwaW5fbG9jaygmY2hhbm5lbC0+bG9jayk7DQo+ID4gKw0KPiA+ICsg
ICAgcmV0ID0gc2VuZF9zbWNfbWVzc2FnZShjaGFubmVsLCBoZHIsIHR4X2RhdGEsIHR4X3NpemUp
Ow0KPiA+ICsgICAgaWYgKCByZXQgKQ0KPiA+ICsgICAgICAgIGdvdG8gY2xlYW47DQo+ID4gKw0K
PiA+ICsgICAgcmV0ID0gZ2V0X3NtY19yZXNwb25zZShjaGFubmVsLCBoZHIsIHJ4X2RhdGEsIHJ4
X3NpemUpOw0KPiA+ICtjbGVhbjoNCj4gPiArICAgIHNwaW5fdW5sb2NrKCZjaGFubmVsLT5sb2Nr
KTsNCj4gPiArDQo+ID4gKyAgICByZXR1cm4gcmV0Ow0KPiA+ICt9DQo+ID4gKw0KPiA+ICtzdGF0
aWMgc3RydWN0IHNjbWlfY2hhbm5lbCAqZ2V0X2NoYW5uZWxfYnlfaWQodWludDhfdCBjaGFuX2lk
KQ0KPiA+ICt7DQo+ID4gKyAgICBzdHJ1Y3Qgc2NtaV9jaGFubmVsICpjdXJyOw0KPiA+ICsgICAg
Ym9vbCBmb3VuZCA9IGZhbHNlOw0KPiA+ICsNCj4gPiArICAgIHNwaW5fbG9jaygmc2NtaV9kYXRh
LmNoYW5uZWxfbGlzdF9sb2NrKTsNCj4gPiArICAgIGxpc3RfZm9yX2VhY2hfZW50cnkoY3Vyciwg
JnNjbWlfZGF0YS5jaGFubmVsX2xpc3QsIGxpc3QpDQo+ID4gKyAgICB7DQo+ID4gKyAgICAgICAg
aWYgKCBjdXJyLT5jaGFuX2lkID09IGNoYW5faWQgKQ0KPiA+ICsgICAgICAgIHsNCj4gPiArICAg
ICAgICAgICAgZm91bmQgPSB0cnVlOw0KPiA+ICsgICAgICAgICAgICBicmVhazsNCj4gPiArICAg
ICAgICB9DQo+ID4gKyAgICB9DQo+ID4gKw0KPiA+ICsgICAgc3Bpbl91bmxvY2soJnNjbWlfZGF0
YS5jaGFubmVsX2xpc3RfbG9jayk7DQo+ID4gKyAgICBpZiAoIGZvdW5kICkNCj4gPiArICAgICAg
ICByZXR1cm4gY3VycjsNCj4gPiArDQo+ID4gKyAgICByZXR1cm4gTlVMTDsNCj4gPiArfQ0KPiA+
ICsNCj4gPiArc3RhdGljIHN0cnVjdCBzY21pX2NoYW5uZWwgKmFxdWlyZV9zY21pX2NoYW5uZWwo
ZG9taWRfdCBkb21haW5faWQpDQo+ID4gK3sNCj4gPiArICAgIHN0cnVjdCBzY21pX2NoYW5uZWwg
KmN1cnI7DQo+ID4gKyAgICBib29sIGZvdW5kID0gZmFsc2U7DQo+ID4gKw0KPiA+ICsgICAgQVNT
RVJUKGRvbWFpbl9pZCAhPSBET01JRF9JTlZBTElEICYmIGRvbWFpbl9pZCA+PSAwKTsNCj4gPiAr
DQo+ID4gKyAgICBzcGluX2xvY2soJnNjbWlfZGF0YS5jaGFubmVsX2xpc3RfbG9jayk7DQo+ID4g
KyAgICBsaXN0X2Zvcl9lYWNoX2VudHJ5KGN1cnIsICZzY21pX2RhdGEuY2hhbm5lbF9saXN0LCBs
aXN0KQ0KPiA+ICsgICAgew0KPiA+ICsgICAgICAgIGlmICggY3Vyci0+ZG9tYWluX2lkID09IERP
TUlEX0lOVkFMSUQgKQ0KPiA+ICsgICAgICAgIHsNCj4gPiArICAgICAgICAgICAgY3Vyci0+ZG9t
YWluX2lkID0gZG9tYWluX2lkOw0KPiA+ICsgICAgICAgICAgICBmb3VuZCA9IHRydWU7DQo+ID4g
KyAgICAgICAgICAgIGJyZWFrOw0KPiA+ICsgICAgICAgIH0NCj4gPiArICAgIH0NCj4gPiArDQo+
ID4gKyAgICBzcGluX3VubG9jaygmc2NtaV9kYXRhLmNoYW5uZWxfbGlzdF9sb2NrKTsNCj4gPiAr
ICAgIGlmICggZm91bmQgKQ0KPiA+ICsgICAgICAgIHJldHVybiBjdXJyOw0KPiA+ICsNCj4gPiAr
ICAgIHJldHVybiBOVUxMOw0KPiA+ICt9DQo+ID4gKw0KPiA+ICtzdGF0aWMgdm9pZCByZWxpbnF1
aXNoX3NjbWlfY2hhbm5lbChzdHJ1Y3Qgc2NtaV9jaGFubmVsICpjaGFubmVsKQ0KPiA+ICt7DQo+
ID4gKyAgICBBU1NFUlQoY2hhbm5lbCAhPSBOVUxMKTsNCj4gPiArDQo+ID4gKyAgICBzcGluX2xv
Y2soJnNjbWlfZGF0YS5jaGFubmVsX2xpc3RfbG9jayk7DQo+ID4gKyAgICBjaGFubmVsLT5kb21h
aW5faWQgPSBET01JRF9JTlZBTElEOw0KPiA+ICsgICAgc3Bpbl91bmxvY2soJnNjbWlfZGF0YS5j
aGFubmVsX2xpc3RfbG9jayk7DQo+ID4gK30NCj4gPiArDQo+ID4gK3N0YXRpYyBpbnQgbWFwX2No
YW5uZWxfbWVtb3J5KHN0cnVjdCBzY21pX2NoYW5uZWwgKmNoYW5uZWwpDQo+ID4gK3sNCj4gPiAr
ICAgIEFTU0VSVCggY2hhbm5lbCAmJiBjaGFubmVsLT5wYWRkciApOw0KPiA+ICsgICAgY2hhbm5l
bC0+c2htZW0gPSBpb3JlbWFwX2NhY2hlKGNoYW5uZWwtPnBhZGRyLCBTQ01JX1NITUVNX01BUFBF
RF9TSVpFKTsNCj4gPiArICAgIGlmICggIWNoYW5uZWwtPnNobWVtICkNCj4gPiArICAgICAgICBy
ZXR1cm4gLUVOT01FTTsNCj4gPiArDQo+ID4gKyAgICBjaGFubmVsLT5zaG1lbS0+Y2hhbm5lbF9z
dGF0dXMgPSBTQ01JX1NITUVNX0NIQU5fU1RBVF9DSEFOTkVMX0ZSRUU7DQo+ID4gKyAgICBwcmlu
dGsoWEVOTE9HX0RFQlVHICJzY21pOiBHb3Qgc2htZW0gYWZ0ZXIgdm1hcCAlcFxuIiwgY2hhbm5l
bC0+c2htZW0pOw0KPiA+ICsgICAgcmV0dXJuIDA7DQo+ID4gK30NCj4gPiArDQo+ID4gK3N0YXRp
YyB2b2lkIHVubWFwX2NoYW5uZWxfbWVtb3J5KHN0cnVjdCBzY21pX2NoYW5uZWwgKmNoYW5uZWwp
DQo+ID4gK3sNCj4gPiArICAgIEFTU0VSVCggY2hhbm5lbCAmJiBjaGFubmVsLT5zaG1lbSApOw0K
PiA+ICsgICAgaW91bm1hcChjaGFubmVsLT5zaG1lbSk7DQo+ID4gKyAgICBjaGFubmVsLT5zaG1l
bSA9IE5VTEw7DQo+ID4gK30NCj4gPiArDQo+ID4gK3N0YXRpYyBzdHJ1Y3Qgc2NtaV9jaGFubmVs
ICpzbWNfY3JlYXRlX2NoYW5uZWwodWludDhfdCBjaGFuX2lkLA0KPiA+ICsgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVpbnQzMl90IGZ1bmNfaWQsIHVpbnQ2
NF90IGFkZHIpDQo+ID4gK3sNCj4gPiArICAgIHN0cnVjdCBzY21pX2NoYW5uZWwgKmNoYW5uZWw7
DQo+ID4gKw0KPiA+ICsgICAgY2hhbm5lbCA9IGdldF9jaGFubmVsX2J5X2lkKGNoYW5faWQpOw0K
PiA+ICsgICAgaWYgKCBjaGFubmVsICkNCj4gPiArICAgICAgICByZXR1cm4gRVJSX1BUUihFRVhJ
U1QpOw0KPiA+ICsNCj4gPiArICAgIGNoYW5uZWwgPSB4bWFsbG9jKHN0cnVjdCBzY21pX2NoYW5u
ZWwpOw0KPiA+ICsgICAgaWYgKCAhY2hhbm5lbCApDQo+ID4gKyAgICAgICAgcmV0dXJuIEVSUl9Q
VFIoRU5PTUVNKTsNCj4gPiArDQo+ID4gKyAgICBjaGFubmVsLT5jaGFuX2lkID0gY2hhbl9pZDsN
Cj4gPiArICAgIGNoYW5uZWwtPmZ1bmNfaWQgPSBmdW5jX2lkOw0KPiA+ICsgICAgY2hhbm5lbC0+
ZG9tYWluX2lkID0gRE9NSURfSU5WQUxJRDsNCj4gPiArICAgIGNoYW5uZWwtPnNobWVtID0gTlVM
TDsNCj4gPiArICAgIGNoYW5uZWwtPnBhZGRyID0gYWRkcjsNCj4gPiArICAgIHNwaW5fbG9ja19p
bml0KCZjaGFubmVsLT5sb2NrKTsNCj4gPiArICAgIHNwaW5fbG9jaygmc2NtaV9kYXRhLmNoYW5u
ZWxfbGlzdF9sb2NrKTsNCj4gPiArICAgIGxpc3RfYWRkKCZjaGFubmVsLT5saXN0LCAmc2NtaV9k
YXRhLmNoYW5uZWxfbGlzdCk7DQo+ID4gKyAgICBzcGluX3VubG9jaygmc2NtaV9kYXRhLmNoYW5u
ZWxfbGlzdF9sb2NrKTsNCj4gPiArICAgIHJldHVybiBjaGFubmVsOw0KPiA+ICt9DQo+ID4gKw0K
PiA+ICtzdGF0aWMgaW50IG1lbV9wZXJtaXRfYWNjZXNzKHN0cnVjdCBkb21haW4gKmQsIHVpbnQ2
NF90IGFkZHIsIHVpbnQ2NF90IGxlbikNCj4gPiArew0KPiA+ICsgICAgcmV0dXJuIGlvbWVtX3Bl
cm1pdF9hY2Nlc3MoZCwgcGFkZHJfdG9fcGZuKGFkZHIpLA0KPiA+ICsgICAgICAgICAgICAgICAg
cGFkZHJfdG9fcGZuKFBBR0VfQUxJR04oYWRkciArIGxlbiAtMSkpKTsNCj4gPiArfQ0KPiA+ICsN
Cj4gPiArc3RhdGljIGludCBtZW1fZGVueV9hY2Nlc3Moc3RydWN0IGRvbWFpbiAqZCwgdWludDY0
X3QgYWRkciwNCj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVpbnQ2
NF90IGxlbikNCj4gPiArew0KPiA+ICsgICAgcmV0dXJuIGlvbWVtX2RlbnlfYWNjZXNzKGQsIHBh
ZGRyX3RvX3BmbihhZGRyKSwNCj4gPiArICAgICAgICAgICAgICAgIHBhZGRyX3RvX3BmbihQQUdF
X0FMSUdOKGFkZHIgKyBsZW4gLTEpKSk7DQo+ID4gK30NCj4gPiArDQo+ID4gK3N0YXRpYyBpbnQg
ZHRfdXBkYXRlX2RvbWFpbl9yYW5nZSh1aW50NjRfdCBhZGRyLCB1aW50NjRfdCBzaXplKQ0KPiA+
ICt7DQo+ID4gKyAgICBzdHJ1Y3QgZHRfZGV2aWNlX25vZGUgKnNobWVtX25vZGU7DQo+ID4gKyAg
ICBfX2JlMzIgKmh3X3JlZzsNCj4gPiArICAgIGNvbnN0IHN0cnVjdCBkdF9wcm9wZXJ0eSAqcHA7
DQo+ID4gKyAgICB1aW50MzJfdCBsZW47DQo+ID4gKw0KPiA+ICsgICAgc2htZW1fbm9kZSA9IGR0
X2ZpbmRfY29tcGF0aWJsZV9ub2RlKE5VTEwsIE5VTEwsIFNDTUlfU0hBUkVEX01FTU9SWSk7DQo+
ID4gKyAgICBpZiAoICFzaG1lbV9ub2RlICkNCj4gPiArICAgIHsNCj4gPiArICAgICAgICBwcmlu
dGsoWEVOTE9HX0VSUiAic2NtaTogVW5hYmxlIHRvIGZpbmQgJXMgbm9kZSBpbiBEVFxuIiwgU0NN
SV9TSE1FTSk7DQo+ID4gKyAgICAgICAgcmV0dXJuIC1FSU5WQUw7DQo+ID4gKyAgICB9DQo+ID4g
Kw0KPiA+ICsgICAgcHAgPSBkdF9maW5kX3Byb3BlcnR5KHNobWVtX25vZGUsICJyZWciLCAmbGVu
KTsNCj4gPiArICAgIGlmICggIXBwICkNCj4gPiArICAgIHsNCj4gPiArICAgICAgICBwcmludGso
WEVOTE9HX0VSUiAic2NtaTogVW5hYmxlIHRvIGZpbmQgcmVncyBlbnRyeSBpbiBzaG1lbSBub2Rl
XG4iKTsNCj4gPiArICAgICAgICByZXR1cm4gLUVOT0VOVDsNCj4gPiArICAgIH0NCj4gPiArDQo+
ID4gKyAgICBod19yZWcgPSBwcC0+dmFsdWU7DQo+ID4gKyAgICBkdF9zZXRfcmFuZ2UoJmh3X3Jl
Zywgc2htZW1fbm9kZSwgYWRkciwgc2l6ZSk7DQo+ID4gKw0KPiA+ICsgICAgcmV0dXJuIDA7DQo+
ID4gK30NCj4gPiArDQo+ID4gK3N0YXRpYyB2b2lkIGZyZWVfY2hhbm5lbF9saXN0KHZvaWQpDQo+
ID4gK3sNCj4gPiArICAgIHN0cnVjdCBzY21pX2NoYW5uZWwgKmN1cnIsICpfY3VycjsNCj4gPiAr
DQo+ID4gKyAgICBzcGluX2xvY2soJnNjbWlfZGF0YS5jaGFubmVsX2xpc3RfbG9jayk7DQo+ID4g
KyAgICBsaXN0X2Zvcl9lYWNoX2VudHJ5X3NhZmUgKGN1cnIsIF9jdXJyLCAmc2NtaV9kYXRhLmNo
YW5uZWxfbGlzdCwgbGlzdCkNCj4gPiArICAgIHsNCj4gPiArICAgICAgICBsaXN0X2RlbCgmY3Vy
ci0+bGlzdCk7DQo+ID4gKyAgICAgICAgeGZyZWUoY3Vycik7DQo+ID4gKyAgICB9DQo+ID4gKw0K
PiA+ICsgICAgc3Bpbl91bmxvY2soJnNjbWlfZGF0YS5jaGFubmVsX2xpc3RfbG9jayk7DQo+ID4g
K30NCj4gPiArDQo+ID4gK3N0YXRpYyBzdHJ1Y3QgZHRfZGV2aWNlX25vZGUgKmdldF9kdF9ub2Rl
X2Zyb21fcHJvcGVydHkoDQo+ID4gKyAgICAgICAgICAgICAgICBzdHJ1Y3QgZHRfZGV2aWNlX25v
ZGUgKm5vZGUsIGNvbnN0IGNoYXIgKiBwX25hbWUpDQo+ID4gK3sNCj4gPiArICAgIGNvbnN0IF9f
YmUzMiAqcHJvcDsNCj4gPiArDQo+ID4gKyAgICBBU1NFUlQoIG5vZGUgKTsNCj4gPiArDQo+ID4g
KyAgICBwcm9wID0gZHRfZ2V0X3Byb3BlcnR5KG5vZGUsIHBfbmFtZSwgTlVMTCk7DQo+ID4gKyAg
ICBpZiAoICFwcm9wICkNCj4gPiArICAgICAgICByZXR1cm4gRVJSX1BUUigtRUlOVkFMKTsNCj4g
PiArDQo+ID4gKyAgICByZXR1cm4gZHRfZmluZF9ub2RlX2J5X3BoYW5kbGUoYmUzMl90b19jcHVw
KHByb3ApKTsNCj4gPiArfQ0KPiA+ICsNCj4gPiArc3RhdGljIGludCBnZXRfc2htZW1fcmVnaW9u
cyhzdHJ1Y3QgbGlzdF9oZWFkICpoZWFkLCB1NjQgaHlwX2FkZHIpDQo+ID4gK3sNCj4gPiArICAg
IHN0cnVjdCBkdF9kZXZpY2Vfbm9kZSAqbm9kZTsNCj4gPiArICAgIGludCByZXQ7DQo+ID4gKyAg
ICBzdHJ1Y3QgZHRfY2hhbm5lbF9hZGRyICpsY2hhbjsNCj4gPiArICAgIHU2NCBsYWRkciwgbHNp
emU7DQo+ID4gKw0KPiA+ICsgICAgbm9kZSA9IGR0X2ZpbmRfY29tcGF0aWJsZV9ub2RlKE5VTEws
IE5VTEwsIFNDTUlfU0hBUkVEX01FTU9SWSk7DQo+ID4gKyAgICBpZiAoICFub2RlICkNCj4gPiAr
ICAgICAgICByZXR1cm4gLUVOT0VOVDsNCj4gPiArDQo+ID4gKyAgICB3aGlsZSAoIG5vZGUgKQ0K
PiA+ICsgICAgew0KPiA+ICsgICAgICAgIHJldCA9IGR0X2RldmljZV9nZXRfYWRkcmVzcyhub2Rl
LCAwLCAmbGFkZHIsICZsc2l6ZSk7DQo+ID4gKyAgICAgICAgaWYgKCByZXQgKQ0KPiA+ICsgICAg
ICAgICAgICByZXR1cm4gcmV0Ow0KPiA+ICsNCj4gPiArICAgICAgICBpZiAoIGxhZGRyICE9IGh5
cF9hZGRyICkNCj4gPiArICAgICAgICB7DQo+ID4gKyAgICAgICAgICAgIGxjaGFuID0geG1hbGxv
YyhzdHJ1Y3QgZHRfY2hhbm5lbF9hZGRyKTsNCj4gPiArICAgICAgICAgICAgaWYgKCAhbGNoYW4g
KQ0KPiA+ICsgICAgICAgICAgICAgICAgcmV0dXJuIC1FTk9NRU07DQo+ID4gKyAgICAgICAgICAg
IGxjaGFuLT5hZGRyID0gbGFkZHI7DQo+ID4gKyAgICAgICAgICAgIGxjaGFuLT5zaXplID0gbHNp
emU7DQo+ID4gKw0KPiA+ICsgICAgICAgICAgICBsaXN0X2FkZF90YWlsKCZsY2hhbi0+bGlzdCwg
aGVhZCk7DQo+ID4gKyAgICAgICAgfQ0KPiA+ICsNCj4gPiArICAgICAgICBub2RlID0gZHRfZmlu
ZF9jb21wYXRpYmxlX25vZGUobm9kZSwgTlVMTCwgU0NNSV9TSEFSRURfTUVNT1JZKTsNCj4gPiAr
ICAgIH0NCj4gPiArDQo+ID4gKyAgICByZXR1cm4gMDsNCj4gPiArfQ0KPiA+ICsNCj4gPiArc3Rh
dGljIGludCByZWFkX2h5cF9jaGFubmVsX2FkZHIoc3RydWN0IGR0X2RldmljZV9ub2RlICpzY21p
X25vZGUsDQo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHU2NCAqYWRkciwg
dTY0ICpzaXplKQ0KPiA+ICt7DQo+ID4gKyAgICBzdHJ1Y3QgZHRfZGV2aWNlX25vZGUgKnNobWVt
X25vZGU7DQo+ID4gKyAgICBzaG1lbV9ub2RlID0gZ2V0X2R0X25vZGVfZnJvbV9wcm9wZXJ0eShz
Y21pX25vZGUsICJzaG1lbSIpOw0KPiA+ICsgICAgaWYgKCBJU19FUlJfT1JfTlVMTChzaG1lbV9u
b2RlKSApDQo+ID4gKyAgICB7DQo+ID4gKyAgICAgICAgcHJpbnRrKFhFTkxPR19FUlINCj4gPiAr
ICAgICAgICAgICAgICAgInNjbWk6IERldmljZSB0cmVlIGVycm9yLCBjYW4ndCBwYXJzZSByZXNl
cnZlZCBtZW1vcnkgJWxkXG4iLA0KPiA+ICsgICAgICAgICAgICAgICBQVFJfRVJSKHNobWVtX25v
ZGUpKTsNCj4gPiArICAgICAgICByZXR1cm4gUFRSX0VSUihzaG1lbV9ub2RlKTsNCj4gPiArICAg
IH0NCj4gPiArDQo+ID4gKyAgICByZXR1cm4gZHRfZGV2aWNlX2dldF9hZGRyZXNzKHNobWVtX25v
ZGUsIDAsIGFkZHIsIHNpemUpOw0KPiA+ICt9DQo+ID4gKw0KPiA+ICtzdGF0aWMgdm9pZCBmcmVl
X3NobWVtX3JlZ2lvbnMoc3RydWN0IGxpc3RfaGVhZCAqYWRkcl9saXN0KQ0KPiA+ICt7DQo+ID4g
KyAgICBzdHJ1Y3QgZHRfY2hhbm5lbF9hZGRyICpjdXJyLCAqX2N1cnI7DQo+ID4gKw0KPiA+ICsg
ICAgbGlzdF9mb3JfZWFjaF9lbnRyeV9zYWZlIChjdXJyLCBfY3VyciwgYWRkcl9saXN0LCBsaXN0
KQ0KPiA+ICsgICAgew0KPiA+ICsgICAgICAgIGxpc3RfZGVsKCZjdXJyLT5saXN0KTsNCj4gPiAr
ICAgICAgICB4ZnJlZShjdXJyKTsNCj4gPiArICAgIH0NCj4gPiArfQ0KPiA+ICsNCj4gPiArc3Rh
dGljIF9faW5pdCBib29sIHNjbWlfcHJvYmUoc3RydWN0IGR0X2RldmljZV9ub2RlICpzY21pX25v
ZGUpDQo+ID4gK3sNCj4gPiArICAgIHU2NCBhZGRyLCBzaXplOw0KPiA+ICsgICAgaW50IHJldCwg
aTsNCj4gPiArICAgIHN0cnVjdCBzY21pX2NoYW5uZWwgKmNoYW5uZWwsICphZ2VudF9jaGFubmVs
Ow0KPiA+ICsgICAgaW50IG5fYWdlbnRzOw0KPiA+ICsgICAgc2NtaV9tc2dfaGVhZGVyX3QgaGRy
Ow0KPiA+ICsgICAgc3RydWN0IHJ4X3Qgew0KPiA+ICsgICAgICAgIGludDMyX3Qgc3RhdHVzOw0K
PiA+ICsgICAgICAgIHVpbnQzMl90IGF0dHJpYnV0ZXM7DQo+ID4gKyAgICB9IHJ4Ow0KPiA+ICsg
ICAgc3RydWN0IGR0X2NoYW5uZWxfYWRkciAqZW50cnk7DQo+ID4gKyAgICBzdHJ1Y3QgbGlzdF9o
ZWFkIGFkZHJfbGlzdDsNCj4gPiArDQo+ID4gKyAgICB1aW50MzJfdCBmdW5jX2lkOw0KPiA+ICsN
Cj4gPiArICAgIEFTU0VSVChzY21pX25vZGUgIT0gTlVMTCk7DQo+ID4gKw0KPiA+ICsgICAgSU5J
VF9MSVNUX0hFQUQoJnNjbWlfZGF0YS5jaGFubmVsX2xpc3QpOw0KPiA+ICsgICAgc3Bpbl9sb2Nr
X2luaXQoJnNjbWlfZGF0YS5jaGFubmVsX2xpc3RfbG9jayk7DQo+ID4gKw0KPiA+ICsgICAgaWYg
KCAhZHRfcHJvcGVydHlfcmVhZF91MzIoc2NtaV9ub2RlLCBTQ01JX1NNQ19JRCwgJmZ1bmNfaWQp
ICkNCj4gPiArICAgIHsNCj4gPiArICAgICAgICBwcmludGsoWEVOTE9HX0VSUiAic2NtaTogVW5h
YmxlIHRvIHJlYWQgc21jLWlkIGZyb20gRFRcbiIpOw0KPiA+ICsgICAgICAgIHJldHVybiBmYWxz
ZTsNCj4gPiArICAgIH0NCj4gPiArDQo+ID4gKyAgICByZXQgPSByZWFkX2h5cF9jaGFubmVsX2Fk
ZHIoc2NtaV9ub2RlLCAmYWRkciwgJnNpemUpOw0KPiA+ICsgICAgaWYgKCBJU19FUlJfVkFMVUUo
cmV0KSApDQo+ID4gKyAgICAgICAgcmV0dXJuIGZhbHNlOw0KPiA+ICsNCj4gPiArICAgIGlmICgg
IUlTX0FMSUdORUQoc2l6ZSwgU0NNSV9TSE1FTV9NQVBQRURfU0laRSkgKQ0KPiA+ICsgICAgew0K
PiA+ICsgICAgICAgIHByaW50ayhYRU5MT0dfRVJSICJzY21pOiBSZXNlcnZlZCBtZW1vcnkgaXMg
bm90IGFsaWduZWRcbiIpOw0KPiA+ICsgICAgICAgIHJldHVybiBmYWxzZTsNCj4gPiArICAgIH0N
Cj4gPiArDQo+ID4gKyAgICBJTklUX0xJU1RfSEVBRCgmYWRkcl9saXN0KTsNCj4gPiArDQo+ID4g
KyAgICByZXQgPSBnZXRfc2htZW1fcmVnaW9ucygmYWRkcl9saXN0LCBhZGRyKTsNCj4gPiArICAg
IGlmICggSVNfRVJSX1ZBTFVFKHJldCkgKQ0KPiA+ICsgICAgICAgIGdvdG8gb3V0Ow0KPiA+ICsN
Cj4gPiArICAgIGNoYW5uZWwgPSBzbWNfY3JlYXRlX2NoYW5uZWwoSFlQX0NIQU5ORUwsIGZ1bmNf
aWQsIGFkZHIpOw0KPiA+ICsgICAgaWYgKCBJU19FUlIoY2hhbm5lbCkgKQ0KPiA+ICsgICAgICAg
IGdvdG8gb3V0Ow0KPiA+ICsNCj4gPiArICAgIHJldCA9IG1hcF9jaGFubmVsX21lbW9yeShjaGFu
bmVsKTsNCj4gPiArICAgIGlmICggcmV0ICkNCj4gPiArICAgICAgICBnb3RvIG91dDsNCj4gPiAr
DQo+ID4gKyAgICBzcGluX2xvY2soJnNjbWlfZGF0YS5jaGFubmVsX2xpc3RfbG9jayk7DQo+ID4g
KyAgICBjaGFubmVsLT5kb21haW5faWQgPSBET01JRF9YRU47DQo+ID4gKyAgICBzcGluX3VubG9j
aygmc2NtaV9kYXRhLmNoYW5uZWxfbGlzdF9sb2NrKTsNCj4gPiArDQo+ID4gKyAgICBoZHIuaWQg
PSBTQ01JX0JBU0VfUFJPVE9DT0xfQVRUSUJVVEVTOw0KPiA+ICsgICAgaGRyLnR5cGUgPSAwOw0K
PiA+ICsgICAgaGRyLnByb3RvY29sID0gU0NNSV9CQVNFX1BST1RPQ09MOw0KPiA+ICsNCj4gPiAr
ICAgIHJldCA9IGRvX3NtY194ZmVyKGNoYW5uZWwsICZoZHIsIE5VTEwsIDAsICZyeCwgc2l6ZW9m
KHJ4KSk7DQo+ID4gKyAgICBpZiAoIHJldCApDQo+ID4gKyAgICAgICAgZ290byBlcnJvcjsNCj4g
PiArDQo+ID4gKyAgICByZXQgPSBjaGVja19zY21pX3N0YXR1cyhyeC5zdGF0dXMpOw0KPiA+ICsg
ICAgaWYgKCByZXQgKQ0KPiA+ICsgICAgICAgIGdvdG8gZXJyb3I7DQo+ID4gKw0KPiA+ICsgICAg
bl9hZ2VudHMgPSBGSUVMRF9HRVQoTVNHX05fQUdFTlRTX01BU0ssIHJ4LmF0dHJpYnV0ZXMpOw0K
PiA+ICsgICAgcHJpbnRrKFhFTkxPR19ERUJVRyAic2NtaTogR290IGFnZW50IGNvdW50ICVkXG4i
LCBuX2FnZW50cyk7DQo+ID4gKw0KPiA+ICsgICAgaSA9IDE7DQo+ID4gKyAgICBsaXN0X2Zvcl9l
YWNoX2VudHJ5KGVudHJ5LCAmYWRkcl9saXN0LCBsaXN0KQ0KPiA+ICsgICAgew0KPiA+ICsgICAg
ICAgIHVpbnQzMl90IHR4X2FnZW50X2lkID0gMHhGRkZGRkZGRjsNCj4gPiArICAgICAgICBzdHJ1
Y3Qgew0KPiA+ICsgICAgICAgICAgICBpbnQzMl90IHN0YXR1czsNCj4gPiArICAgICAgICAgICAg
dWludDMyX3QgYWdlbnRfaWQ7DQo+ID4gKyAgICAgICAgICAgIGNoYXIgbmFtZVsxNl07DQo+ID4g
KyAgICAgICAgfSBkYV9yeDsNCj4gPiArDQo+ID4gKyAgICAgICAgYWdlbnRfY2hhbm5lbCA9IHNt
Y19jcmVhdGVfY2hhbm5lbChpLCBmdW5jX2lkLA0KPiA+ICsgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgZW50cnktPmFkZHIpOw0KPiA+ICsgICAgICAgIGlmICggSVNf
RVJSKGFnZW50X2NoYW5uZWwpICkNCj4gPiArICAgICAgICB7DQo+ID4gKyAgICAgICAgICAgIHJl
dCA9IFBUUl9FUlIoYWdlbnRfY2hhbm5lbCk7DQo+ID4gKyAgICAgICAgICAgIGdvdG8gZXJyb3I7
DQo+ID4gKyAgICAgICAgfQ0KPiA+ICsNCj4gPiArICAgICAgICByZXQgPSBtYXBfY2hhbm5lbF9t
ZW1vcnkoYWdlbnRfY2hhbm5lbCk7DQo+ID4gKyAgICAgICAgaWYgKCByZXQgKQ0KPiA+ICsgICAg
ICAgICAgICBnb3RvIGVycm9yOw0KPiA+ICsNCj4gPiArICAgICAgICBoZHIuaWQgPSBTQ01JX0JB
U0VfRElTQ09WRVJfQUdFTlQ7DQo+ID4gKyAgICAgICAgaGRyLnR5cGUgPSAwOw0KPiA+ICsgICAg
ICAgIGhkci5wcm90b2NvbCA9IFNDTUlfQkFTRV9QUk9UT0NPTDsNCj4gPiArDQo+ID4gKyAgICAg
ICAgcmV0ID0gZG9fc21jX3hmZXIoYWdlbnRfY2hhbm5lbCwgJmhkciwgJnR4X2FnZW50X2lkLA0K
PiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgIHNpemVvZih0eF9hZ2VudF9pZCksICZkYV9y
eCwgc2l6ZW9mKGRhX3J4KSk7DQo+ID4gKyAgICAgICAgaWYgKCByZXQgKQ0KPiA+ICsgICAgICAg
IHsNCj4gPiArICAgICAgICAgICAgdW5tYXBfY2hhbm5lbF9tZW1vcnkoYWdlbnRfY2hhbm5lbCk7
DQo+ID4gKyAgICAgICAgICAgIGdvdG8gZXJyb3I7DQo+ID4gKyAgICAgICAgfQ0KPiA+ICsNCj4g
PiArICAgICAgICB1bm1hcF9jaGFubmVsX21lbW9yeShhZ2VudF9jaGFubmVsKTsNCj4gPiArDQo+
ID4gKyAgICAgICAgcmV0ID0gY2hlY2tfc2NtaV9zdGF0dXMoZGFfcnguc3RhdHVzKTsNCj4gPiAr
ICAgICAgICBpZiAoIHJldCApDQo+ID4gKyAgICAgICAgICAgIGdvdG8gZXJyb3I7DQo+ID4gKw0K
PiA+ICsgICAgICAgIHByaW50ayhYRU5MT0dfREVCVUcgInNjbWk6IHN0YXR1cz0weCV4IGlkPTB4
JXggbmFtZT0lc1xuIiwNCj4gPiArICAgICAgICAgICAgICAgIGRhX3J4LnN0YXR1cywgZGFfcngu
YWdlbnRfaWQsIGRhX3J4Lm5hbWUpOw0KPiA+ICsNCj4gPiArICAgICAgICBhZ2VudF9jaGFubmVs
LT5hZ2VudF9pZCA9IGRhX3J4LmFnZW50X2lkOw0KPiA+ICsNCj4gPiArICAgICAgICBpZiAoIGkg
PT0gbl9hZ2VudHMgKQ0KPiA+ICsgICAgICAgICAgICBicmVhazsNCj4gPiArDQo+ID4gKyAgICAg
ICAgaSsrOw0KPiA+ICsgICAgfQ0KPiA+ICsNCj4gPiArICAgIHNjbWlfZGF0YS5pbml0aWFsaXpl
ZCA9IHRydWU7DQo+ID4gKyAgICBnb3RvIG91dDsNCj4gPiArDQo+ID4gK2Vycm9yOg0KPiA+ICsg
ICAgdW5tYXBfY2hhbm5lbF9tZW1vcnkoY2hhbm5lbCk7DQo+ID4gKyAgICBmcmVlX2NoYW5uZWxf
bGlzdCgpOw0KPiA+ICtvdXQ6DQo+ID4gKyAgICBmcmVlX3NobWVtX3JlZ2lvbnMoJmFkZHJfbGlz
dCk7DQo+ID4gKyAgICByZXR1cm4gcmV0ID09IDA7DQo+ID4gK30NCj4gPiArDQo+ID4gK3N0YXRp
YyBpbnQgc2NtaV9kb21haW5faW5pdChzdHJ1Y3QgZG9tYWluICpkLA0KPiA+ICsgICAgICAgICAg
ICAgICAgICAgICAgICAgICBzdHJ1Y3QgeGVuX2FyY2hfZG9tYWluY29uZmlnICpjb25maWcpDQo+
ID4gK3sNCj4gPiArICAgIHN0cnVjdCBzY21pX2NoYW5uZWwgKmNoYW5uZWw7DQo+ID4gKyAgICBp
bnQgcmV0Ow0KPiA+ICsNCj4gPiArICAgIGlmICggIXNjbWlfZGF0YS5pbml0aWFsaXplZCApDQo+
ID4gKyAgICAgICAgcmV0dXJuIDA7DQo+ID4gKw0KPiA+ICsgICAgcHJpbnRrKFhFTkxPR19JTkZP
ICJzY21pOiBkb21haW5faWQgPSAlZFxuIiwgZC0+ZG9tYWluX2lkKTsNCj4gPiArDQo+ID4gKyAg
ICBjaGFubmVsID0gYXF1aXJlX3NjbWlfY2hhbm5lbChkLT5kb21haW5faWQpOw0KPiA+ICsgICAg
aWYgKCBJU19FUlJfT1JfTlVMTChjaGFubmVsKSApDQo+ID4gKyAgICAgICAgcmV0dXJuIC1FTk9F
TlQ7DQo+ID4gKw0KPiA+ICsjaWZkZWYgQ09ORklHX0FSTV8zMg0KPiA+ICsgICAgcHJpbnRrKFhF
TkxPR19JTkZPDQo+ID4gKyAgICAgICAgICAgInNjbWk6IEFxdWlyZSBTQ01JIGNoYW5uZWwgaWQg
PSAweCV4ICwgZG9tYWluX2lkID0gJWQgcGFkZHIgPSAweCVsbHhcbiIsDQo+ID4gKyAgICAgICAg
ICAgY2hhbm5lbC0+Y2hhbl9pZCwgY2hhbm5lbC0+ZG9tYWluX2lkLCBjaGFubmVsLT5wYWRkcik7
DQo+ID4gKyNlbHNlDQo+ID4gKyAgICBwcmludGsoWEVOTE9HX0lORk8NCj4gPiArICAgICAgICAg
ICAic2NtaTogQXF1aXJlIFNDTUkgY2hhbm5lbCBpZCA9IDB4JXggLCBkb21haW5faWQgPSAlZCBw
YWRkciA9IDB4JWx4XG4iLA0KPiA+ICsgICAgICAgICAgIGNoYW5uZWwtPmNoYW5faWQsIGNoYW5u
ZWwtPmRvbWFpbl9pZCwgY2hhbm5lbC0+cGFkZHIpOw0KPiA+ICsjZW5kaWYNCj4gPiArDQo+ID4g
KyAgICBpZiAoIGlzX2hhcmR3YXJlX2RvbWFpbihkKSApDQo+ID4gKyAgICB7DQo+ID4gKyAgICAg
ICAgcmV0ID0gbWVtX3Blcm1pdF9hY2Nlc3MoZCwgY2hhbm5lbC0+cGFkZHIsIFBBR0VfU0laRSk7
DQo+ID4gKyAgICAgICAgaWYgKCBJU19FUlJfVkFMVUUocmV0KSApDQo+ID4gKyAgICAgICAgICAg
IGdvdG8gZXJyb3I7DQo+ID4gKw0KPiA+ICsgICAgICAgIHJldCA9IGR0X3VwZGF0ZV9kb21haW5f
cmFuZ2UoY2hhbm5lbC0+cGFkZHIsIFBBR0VfU0laRSk7DQo+ID4gKyAgICAgICAgaWYgKCBJU19F
UlJfVkFMVUUocmV0KSApDQo+ID4gKyAgICAgICAgew0KPiA+ICsgICAgICAgICAgICBpbnQgcmMg
PSBtZW1fZGVueV9hY2Nlc3MoZCwgY2hhbm5lbC0+cGFkZHIsIFBBR0VfU0laRSk7DQo+ID4gKyAg
ICAgICAgICAgIGlmICggcmMgKQ0KPiA+ICsgICAgICAgICAgICAgICAgcHJpbnRrKFhFTkxPR19F
UlIgIlVuYWJsZSB0byBtZW1fZGVueV9hY2Nlc3NcbiIpOw0KPiA+ICsNCj4gPiArICAgICAgICAg
ICAgZ290byBlcnJvcjsNCj4gPiArICAgICAgICB9DQo+ID4gKyAgICB9DQo+ID4gKw0KPiA+ICsg
ICAgZC0+YXJjaC5zY2kgPSBjaGFubmVsOw0KPiA+ICsgICAgaWYgKCBjb25maWcgKQ0KPiA+ICsg
ICAgICAgIGNvbmZpZy0+YXJtX3NjaV9hZ2VudF9wYWRkciA9IGNoYW5uZWwtPnBhZGRyOw0KPiA+
ICsNCj4gPiArICAgIHJldHVybiAwOw0KPiA+ICtlcnJvcjoNCj4gPiArICAgIHJlbGlucXVpc2hf
c2NtaV9jaGFubmVsKGNoYW5uZWwpOw0KPiA+ICsNCj4gPiArICAgIHJldHVybiByZXQ7DQo+ID4g
K30NCj4gPiArDQo+ID4gK3N0YXRpYyBpbnQgc2NtaV9hZGRfZGV2aWNlX2J5X2RldmlkKHN0cnVj
dCBkb21haW4gKmQsIHVpbnQzMl90IHNjbWlfZGV2aWQpDQo+ID4gK3sNCj4gPiArICAgIHN0cnVj
dCBzY21pX2NoYW5uZWwgKmNoYW5uZWwsICphZ2VudF9jaGFubmVsOw0KPiA+ICsgICAgc2NtaV9t
c2dfaGVhZGVyX3QgaGRyOw0KPiA+ICsgICAgc3RydWN0IHNjbWlfcGVybXNfdHggew0KPiA+ICsg
ICAgICAgIHVpbnQzMl90IGFnZW50X2lkOw0KPiA+ICsgICAgICAgIHVpbnQzMl90IGRldmljZV9p
ZDsNCj4gPiArICAgICAgICB1aW50MzJfdCBmbGFnczsNCj4gPiArICAgIH0gdHg7DQo+ID4gKyAg
ICBzdHJ1Y3QgcnhfdCB7DQo+ID4gKyAgICAgICAgaW50MzJfdCBzdGF0dXM7DQo+ID4gKyAgICAg
ICAgdWludDMyX3QgYXR0cmlidXRlczsNCj4gPiArICAgIH0gcng7DQo+ID4gKyAgICBpbnQgcmV0
Ow0KPiA+ICsNCj4gPiArICAgIGlmICggIXNjbWlfZGF0YS5pbml0aWFsaXplZCApDQo+ID4gKyAg
ICAgICAgcmV0dXJuIDA7DQo+ID4gKw0KPiA+ICsgICAgcHJpbnRrKFhFTkxPR19ERUJVRyAic2Nt
aTogc2NtaV9kZXZpZCA9ICVkXG4iLCBzY21pX2RldmlkKTsNCj4gPiArDQo+ID4gKyAgICBhZ2Vu
dF9jaGFubmVsID0gZC0+YXJjaC5zY2k7DQo+ID4gKyAgICBpZiAoIElTX0VSUl9PUl9OVUxMKGFn
ZW50X2NoYW5uZWwpICkNCj4gPiArICAgICAgICByZXR1cm4gUFRSX0VSUihhZ2VudF9jaGFubmVs
KTsNCj4gPiArDQo+ID4gKyAgICBjaGFubmVsID0gZ2V0X2NoYW5uZWxfYnlfaWQoSFlQX0NIQU5O
RUwpOw0KPiA+ICsgICAgaWYgKCBJU19FUlJfT1JfTlVMTChjaGFubmVsKSApDQo+ID4gKyAgICAg
ICAgcmV0dXJuIFBUUl9FUlIoY2hhbm5lbCk7DQo+ID4gKw0KPiA+ICsgICAgaGRyLmlkID0gU0NN
SV9CQVNFX1NFVF9ERVZJQ0VfUEVSTUlTU0lPTlM7DQo+ID4gKyAgICBoZHIudHlwZSA9IDA7DQo+
ID4gKyAgICBoZHIucHJvdG9jb2wgPSBTQ01JX0JBU0VfUFJPVE9DT0w7DQo+ID4gKw0KPiA+ICsg
ICAgdHguYWdlbnRfaWQgPSBhZ2VudF9jaGFubmVsLT5hZ2VudF9pZDsNCj4gPiArICAgIHR4LmRl
dmljZV9pZCA9IHNjbWlfZGV2aWQ7DQo+ID4gKyAgICB0eC5mbGFncyA9IFNDTUlfQUxMT1dfQUND
RVNTOw0KPiA+ICsNCj4gPiArICAgIHJldCA9IGRvX3NtY194ZmVyKGNoYW5uZWwsICZoZHIsICZ0
eCwgc2l6ZW9mKHR4KSwgJnJ4LCBzaXplb2YoJnJ4KSk7DQo+ID4gKyAgICBpZiAoIElTX0VSUl9W
QUxVRShyZXQpICkNCj4gPiArICAgICAgICByZXR1cm4gcmV0Ow0KPiA+ICsNCj4gPiArICAgIHJl
dCA9IGNoZWNrX3NjbWlfc3RhdHVzKHJ4LnN0YXR1cyk7DQo+ID4gKyAgICBpZiAoIElTX0VSUl9W
QUxVRShyZXQpICkNCj4gPiArICAgICAgICByZXR1cm4gcmV0Ow0KPiA+ICsNCj4gPiArICAgIHJl
dHVybiAwOw0KPiA+ICt9DQo+ID4gKw0KPiA+ICtzdGF0aWMgaW50IHNjbWlfYWRkX2R0X2Rldmlj
ZShzdHJ1Y3QgZG9tYWluICpkLCBzdHJ1Y3QgZHRfZGV2aWNlX25vZGUgKmRldikNCj4gPiArew0K
PiA+ICsgICAgdWludDMyX3Qgc2NtaV9kZXZpZDsNCj4gPiArDQo+ID4gKyAgICBpZiAoICghc2Nt
aV9kYXRhLmluaXRpYWxpemVkKSB8fCAoIWQtPmFyY2guc2NpKSApDQo+ID4gKyAgICAgICAgcmV0
dXJuIDA7DQo+ID4gKw0KPiA+ICsgICAgaWYgKCAhZHRfcHJvcGVydHlfcmVhZF91MzIoZGV2LCAi
c2NtaV9kZXZpZCIsICZzY21pX2RldmlkKSApDQo+ID4gKyAgICAgICAgcmV0dXJuIDA7DQo+ID4g
Kw0KPiA+ICsgICAgcHJpbnRrKFhFTkxPR19JTkZPICJzY21pOiBkdF9ub2RlID0gJXNcbiIsIGR0
X25vZGVfZnVsbF9uYW1lKGRldikpOw0KPiA+ICsNCj4gPiArICAgIHJldHVybiBzY21pX2FkZF9k
ZXZpY2VfYnlfZGV2aWQoZCwgc2NtaV9kZXZpZCk7DQo+ID4gK30NCj4gPiArDQo+ID4gK3N0YXRp
YyBpbnQgc2NtaV9yZWxpbnF1aXNoX3Jlc291cmNlcyhzdHJ1Y3QgZG9tYWluICpkKQ0KPiA+ICt7
DQo+ID4gKyAgICBpbnQgcmV0Ow0KPiA+ICsgICAgc3RydWN0IHNjbWlfY2hhbm5lbCAqY2hhbm5l
bCwgKmFnZW50X2NoYW5uZWw7DQo+ID4gKyAgICBzY21pX21zZ19oZWFkZXJfdCBoZHI7DQo+ID4g
KyAgICBzdHJ1Y3QgcmVzZXRfYWdlbnRfdHggew0KPiA+ICsgICAgICAgIHVpbnQzMl90IGFnZW50
X2lkOw0KPiA+ICsgICAgICAgIHVpbnQzMl90IGZsYWdzOw0KPiA+ICsgICAgfSB0eDsNCj4gPiAr
ICAgIHVpbnQzMl90IHJ4Ow0KPiA+ICsNCj4gPiArICAgIGlmICggIWQtPmFyY2guc2NpICkNCj4g
PiArICAgICAgICByZXR1cm4gMDsNCj4gPiArDQo+ID4gKyAgICBhZ2VudF9jaGFubmVsID0gZC0+
YXJjaC5zY2k7DQo+ID4gKw0KPiA+ICsgICAgc3Bpbl9sb2NrKCZhZ2VudF9jaGFubmVsLT5sb2Nr
KTsNCj4gPiArICAgIHR4LmFnZW50X2lkID0gYWdlbnRfY2hhbm5lbC0+YWdlbnRfaWQ7DQo+ID4g
KyAgICBzcGluX3VubG9jaygmYWdlbnRfY2hhbm5lbC0+bG9jayk7DQo+ID4gKw0KPiA+ICsgICAg
Y2hhbm5lbCA9IGdldF9jaGFubmVsX2J5X2lkKEhZUF9DSEFOTkVMKTsNCj4gPiArICAgIGlmICgg
IWNoYW5uZWwgKQ0KPiA+ICsgICAgew0KPiA+ICsgICAgICAgIHByaW50ayhYRU5MT0dfRVJSDQo+
ID4gKyAgICAgICAgICAgICAgICJzY21pOiBVbmFibGUgdG8gZ2V0IEh5cGVydmlzb3Igc2NtaSBj
aGFubmVsIGZvciBkb21haW4gJWRcbiIsDQo+ID4gKyAgICAgICAgICAgICAgIGQtPmRvbWFpbl9p
ZCk7DQo+ID4gKyAgICAgICAgcmV0dXJuIC1FSU5WQUw7DQo+ID4gKyAgICB9DQo+ID4gKw0KPiA+
ICsgICAgaGRyLmlkID0gU0NNSV9CQVNFX1JFU0VUX0FHRU5UX0NPTkZJR1VSQVRJT047DQo+ID4g
KyAgICBoZHIudHlwZSA9IDA7DQo+ID4gKyAgICBoZHIucHJvdG9jb2wgPSBTQ01JX0JBU0VfUFJP
VE9DT0w7DQo+ID4gKw0KPiA+ICsgICAgdHguZmxhZ3MgPSAwOw0KPiA+ICsNCj4gPiArICAgIHJl
dCA9IGRvX3NtY194ZmVyKGNoYW5uZWwsICZoZHIsICZ0eCwgc2l6ZW9mKHR4KSwgJnJ4LCBzaXpl
b2YocngpKTsNCj4gPiArICAgIGlmICggcmV0ICkNCj4gPiArICAgICAgICByZXR1cm4gcmV0Ow0K
PiA+ICsNCj4gPiArICAgIHJldCA9IGNoZWNrX3NjbWlfc3RhdHVzKHJ4KTsNCj4gPiArDQo+ID4g
KyAgICByZXR1cm4gcmV0Ow0KPiA+ICt9DQo+ID4gKw0KPiA+ICtzdGF0aWMgdm9pZCBzY21pX2Rv
bWFpbl9kZXN0cm95KHN0cnVjdCBkb21haW4gKmQpDQo+ID4gK3sNCj4gPiArICAgIHN0cnVjdCBz
Y21pX2NoYW5uZWwgKmNoYW5uZWw7DQo+ID4gKw0KPiA+ICsgICAgaWYgKCAhZC0+YXJjaC5zY2kg
KQ0KPiA+ICsgICAgICAgIHJldHVybjsNCj4gPiArDQo+ID4gKyAgICBjaGFubmVsID0gZC0+YXJj
aC5zY2k7DQo+ID4gKyAgICBzcGluX2xvY2soJmNoYW5uZWwtPmxvY2spOw0KPiA+ICsNCj4gPiAr
ICAgIHJlbGlucXVpc2hfc2NtaV9jaGFubmVsKGNoYW5uZWwpOw0KPiA+ICsgICAgcHJpbnRrKFhF
TkxPR19ERUJVRyAic2NtaTogRnJlZSBkb21haW4gJWRcbiIsIGQtPmRvbWFpbl9pZCk7DQo+ID4g
Kw0KPiA+ICsgICAgZC0+YXJjaC5zY2kgPSBOVUxMOw0KPiA+ICsNCj4gPiArICAgIG1lbV9kZW55
X2FjY2VzcyhkLCBjaGFubmVsLT5wYWRkciwgUEFHRV9TSVpFKTsNCj4gPiArICAgIHNwaW5fdW5s
b2NrKCZjaGFubmVsLT5sb2NrKTsNCj4gPiArfQ0KPiA+ICsNCj4gPiArc3RhdGljIGJvb2wgc2Nt
aV9oYW5kbGVfY2FsbChzdHJ1Y3QgZG9tYWluICpkLCB2b2lkICphcmdzKQ0KPiA+ICt7DQo+ID4g
KyAgICBib29sIHJlcyA9IGZhbHNlOw0KPiA+ICsgICAgc3RydWN0IHNjbWlfY2hhbm5lbCAqYWdl
bnRfY2hhbm5lbDsNCj4gPiArICAgIHN0cnVjdCBhcm1fc21jY2NfcmVzIHJlc3A7DQo+ID4gKyAg
ICBzdHJ1Y3QgY3B1X3VzZXJfcmVncyAqcmVncyA9IGFyZ3M7DQo+ID4gKw0KPiA+ICsgICAgaWYg
KCAhZC0+YXJjaC5zY2kgKQ0KPiA+ICsgICAgICAgIHJldHVybiBmYWxzZTsNCj4gPiArDQo+ID4g
KyAgICBhZ2VudF9jaGFubmVsID0gZC0+YXJjaC5zY2k7DQo+ID4gKyAgICBzcGluX2xvY2soJmFn
ZW50X2NoYW5uZWwtPmxvY2spOw0KPiA+ICsNCj4gPiArICAgIGlmICggYWdlbnRfY2hhbm5lbC0+
ZnVuY19pZCAhPSByZWdzLT5yMCApDQo+ID4gKyAgICB7DQo+ID4gKyAgICAgICAgcmVzID0gZmFs
c2U7DQo+ID4gKyAgICAgICAgZ290byB1bmxvY2s7DQo+ID4gKyAgICB9DQo+ID4gKw0KPiA+ICsg
ICAgYXJtX3NtY2NjX3NtYyhhZ2VudF9jaGFubmVsLT5mdW5jX2lkLCAwLCAwLCAwLCAwLCAwLCAw
LA0KPiA+ICsgICAgICAgICAgICAgICAgICBhZ2VudF9jaGFubmVsLT5jaGFuX2lkLCAmcmVzcCk7
DQo+ID4gKw0KPiA+ICsgICAgc2V0X3VzZXJfcmVnKHJlZ3MsIDAsIHJlc3AuYTApOw0KPiA+ICsg
ICAgc2V0X3VzZXJfcmVnKHJlZ3MsIDEsIHJlc3AuYTEpOw0KPiA+ICsgICAgc2V0X3VzZXJfcmVn
KHJlZ3MsIDIsIHJlc3AuYTIpOw0KPiA+ICsgICAgc2V0X3VzZXJfcmVnKHJlZ3MsIDMsIHJlc3Au
YTMpOw0KPiA+ICsgICAgcmVzID0gdHJ1ZTsNCj4gPiArdW5sb2NrOg0KPiA+ICsgICAgc3Bpbl91
bmxvY2soJmFnZW50X2NoYW5uZWwtPmxvY2spOw0KPiA+ICsNCj4gPiArICAgIHJldHVybiByZXM7
DQo+ID4gK30NCj4gPiArDQo+ID4gK3N0YXRpYyBjb25zdCBzdHJ1Y3QgZHRfZGV2aWNlX21hdGNo
IHNjbWlfc21jX21hdGNoW10gX19pbml0Y29uc3QgPQ0KPiA+ICt7DQo+ID4gKyAgICBEVF9NQVRD
SF9TQ01JX1NNQywNCj4gPiArICAgIHsgLyogc2VudGluZWwgKi8gfSwNCj4gPiArfTsNCj4gPiAr
DQo+ID4gK3N0YXRpYyBjb25zdCBzdHJ1Y3Qgc2NpX21lZGlhdG9yX29wcyBzY21pX29wcyA9DQo+
ID4gK3sNCj4gPiArICAgIC5wcm9iZSA9IHNjbWlfcHJvYmUsDQo+ID4gKyAgICAuZG9tYWluX2lu
aXQgPSBzY21pX2RvbWFpbl9pbml0LA0KPiA+ICsgICAgLmRvbWFpbl9kZXN0cm95ID0gc2NtaV9k
b21haW5fZGVzdHJveSwNCj4gPiArICAgIC5hZGRfZHRfZGV2aWNlID0gc2NtaV9hZGRfZHRfZGV2
aWNlLA0KPiA+ICsgICAgLnJlbGlucXVpc2hfcmVzb3VyY2VzID0gc2NtaV9yZWxpbnF1aXNoX3Jl
c291cmNlcywNCj4gPiArICAgIC5oYW5kbGVfY2FsbCA9IHNjbWlfaGFuZGxlX2NhbGwsDQo+ID4g
K307DQo+ID4gKw0KPiA+ICtSRUdJU1RFUl9TQ0lfTUVESUFUT1Ioc2NtaV9zbWMsICJTQ01JLVNN
QyIsIFhFTl9ET01DVExfQ09ORklHX0FSTV9TQ0lfU0NNSV9TTUMsDQo+ID4gKyAgICAgICAgICAg
ICAgICAgICAgICBzY21pX3NtY19tYXRjaCwgJnNjbWlfb3BzKTsNCj4gPiArDQo+ID4gKy8qDQo+
ID4gKyAqIExvY2FsIHZhcmlhYmxlczoNCj4gPiArICogbW9kZTogQw0KPiA+ICsgKiBjLWZpbGUt
c3R5bGU6ICJCU0QiDQo+ID4gKyAqIGMtYmFzaWMtb2Zmc2V0OiA0DQo+ID4gKyAqIGluZGVudC10
YWJzLW1vZGU6IG5pbA0KPiA+ICsgKiBFbmQ6DQo+ID4gKyAqLw0KPiA+IC0tIA0KPiA+IDIuMjcu
MA0KPiA=


From xen-devel-bounces@lists.xenproject.org Fri Feb 11 10:47:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 10:47:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270321.464565 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nITSY-0002SC-9a; Fri, 11 Feb 2022 10:47:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270321.464565; Fri, 11 Feb 2022 10:47:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nITSY-0002S5-6U; Fri, 11 Feb 2022 10:47:26 +0000
Received: by outflank-mailman (input) for mailman id 270321;
 Fri, 11 Feb 2022 10:47:25 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=dFbI=S2=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nITSX-0002Rz-8B
 for xen-devel@lists.xenproject.org; Fri, 11 Feb 2022 10:47:25 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id fe260188-8b27-11ec-8f75-fffcc8bd4f1a;
 Fri, 11 Feb 2022 11:47:24 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fe260188-8b27-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644576444;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=8Eg009wCsazYzX6qRy3sTtnrhnlj56TwiA66pPgXoic=;
  b=I/Do+b9FcuLk7Q2WjKFfY3UhMFoO6EbSJif3lVcmIBoZPOVVaqAJBx6K
   CvbOnrPBYggz7iAZMXaEJT7uDaZtZ4rNw7YQvmFhhbdpmOILQL1cSjmBb
   lauojHpHETjbEQOIj2jXJxdCcIl2xbAwPnG/bOiBt/snk0Oh33Qabbs72
   M=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: OC7T+dZLWueop0iIqpTfTvYdMRThrshseCfHVZHQ+cVIMFXOwlewxuZx+k3u6m4RxAne7cB3z0
 B58deIf9FN/sEGwVQJAmJzrvKzeRs9dvJi3KMFhsm9ZZFNutWFlrOSML/7i7ru5d07AYOYsGgL
 6sx5+CtB6+LGRIZVj/8mwkBShctDGD7Iq70uPgT1m6ic01jYWu0dIYO2yxc7MlsIq5wcu6jWvZ
 SP5Do11DhQQl4JPQ74Z21FEg8/pvLnxh/U/Gm0geen1GgiecXZWtmesOn9M0LNjVTM8eqxUEu3
 UqWa7uNaBNH1+iolZB5TQk/d
X-SBRS: 5.1
X-MesageID: 66229934
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:eUlLP6rPCLvStSt7T7SlrIbwMcpeBmL2YhIvgKrLsJaIsI4StFCzt
 garIBmAPvqJZjSheNB+Pti190kHsJLXx4JiSgJspX1gQnsS85uZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlZT4vE2xbuKU5NTsY0idfic5Dndx4f5fs7Rh2NQw24HgW1rlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCnaShdCYYH4qLpMMybRVyFA99EbVDooaSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFJkYtXx6iynQEN4tQIzZQrWM7thdtNs1rp4QR6yPN
 pFFAdZpRBbdQTJ2OWo0M8gdvcaVoD6hUhpkuF3A8MLb5ECMlVcsgdABKuH9ZdiiVchT2EGCq
 Qru+WHwBA0aOc23wD+M4HWqwOPC9Qv5Uo8PELyz9tZxnUaegGcUDXU+RVa95PW0lEO6c9ZeM
 FAPvDojq7Ao806mRcW7WAe3yENopTZFBYAWSbdjrljQlOyEuG51G1ToUBZ5eeEHhe4RAgAN+
 WGFtdTHBhB3teesHCf1GqivkRu+Pi0cLGknbCACTBcY79SLnLzfni4jXf44Tvfr04Sd9SXYh
 mnT8XNg3+l7Ydsjiv3jlW0rlQ5AsXQgouQdwgzMFlyo4QpiDGJOT9z5sAOLhRqswWvwc7Vgg
 JTms5XGhAztJcvU/MBofAnrNOv4jxpiGGeC6WOD57F7q1yQF4eLJOi8Gg1WKkZzKdojcjT0e
 kLVsg45zMYNYCf3N/IoPNjsUpxCIU3c+TLNDKG8gj1mOMYZSeN61Hs2OR74M57FzCDAbp3Ty
 b/EKJ3xXB72+IxszSasRvd17FPY7ntW+I8nfriil07P+ePHPBa9EO5ZWHPTPrFRxP7V+239r
 ocAX/ZmPj0CCYUSlAGMqtVNRb3LRFBmba3LRzt/KLLdfFo8RT1J5j246epJRrGJVp99z4/g1
 nq8RlVZ2Bz4g3jGIh+NcXdtdPXkWpMXkJ7xFXVE0Y+A1ydxbICxwr0YcpdrL7Ar+PY6lax/T
 uUfetXGCfNKE2yV9zMYZJj7jYpjaBX02l7eY3v7OGAyL8x6WgjE2t74ZQ+zpiMAOTW66Jklq
 Lq62wKFHZdaH1Z+DNzbYe6Exk+quSRPg/p7WkbFe4EBeEjl/IVwBTb2i/s7f5MFJRnZn2PI3
 AeKGxYI4+LKptZtotXOgKmFqaavEvd/QRUGTzWKs+7uOHCDrGS5wIJGXOKZRhznVTv5qPe4e
 OFY7/DgK/lbzlxEhJVxTuRwxqUk6tqx+7IDllZ4HG/GZkiAA697JiXUxtFGs6BAy+MLuQayX
 U7TqNBWNa/QZZHgGV8VYgEkcv6CxbcfnTyLtaY5J0Dz5SlW+rubUBoNY0nQ2XIFdLYlYpk4x
 eoBudIN713tgxUnBd+KkyRI+jneNXcHSagm6skXDYKDZtDHEb2ejUgw0hPL3aw=
IronPort-HdrOrdr: A9a23:Q82n5qxcl/9Zre64+1UyKrPw+L1zdoMgy1knxilNoHtuA7Olfq
 GV7YgmPHDP6Ar5NEtMpTnEAtjkfZq+z+8K3WByB8bAYOCOggLBR+tfBMnZsl/d8kbFmdK1oJ
 0AT0EIMrPN5DZB4foSyTPIdOrJmrG8gcaVbKzlvhNQpElRGthdB1IQMHfgLqVfLDM2eKbQPf
 Knl7F6TyzJQwVuUviG
X-IronPort-AV: E=Sophos;i="5.88,360,1635220800"; 
   d="scan'208";a="66229934"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gEnEot0RfysF9MLm3MC6DYmBtxGeZ2ij/66xmERCTZaTvAkOXTE1X/DJhgktvYhIMxlSbaquK3GHxX3eeeET8aBaJE9KV/T0Ye4RL90ZKjzjiVgkECIpzCUfNbeoDTIB5+KyKD2e1rTKdr2EWTahmDlpZtbIwmlJDgQ9rJ0DCgLxlVWIvkJ7tpQ48NrfcE7ooJBuZBNURKsHonlDjLItV8Bh+YQTfxIX3D85Ijows+Sy5TiYUYjlTYfr6xTPWSZXwI/eS0uOfnd56JQ7v74jSDY3ZZToliR2fj52SG2X7z6598kC/mczyv0r56WjGnkzTOI3oY3wtsnrcrLhGGpk0g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=aJUqTpsQtK4VKXD+d4l8Y1skLV/8v0nbHPJn6/rdzv4=;
 b=gdtfAnuP7QdDX0Rr6NIFPqFkYFKRW8RCIWLppE6gdSpd4KF+weExsehc6yAbVGOO6yMRVmJWgL+G5RCsBhD6gSTTigf8XvvpHgImkuqH/hfZMsq9ZWOHZdV3DQe3ZPhOEid2lsxyqCgYy822CxpCXEw2xRPF/6zUfDedugJNm5KxVsk9xPWOOHtUcltwoi5F3Uulw1ibszYWd2RYc3XGKxyrYkQZinKm0OmuGL1edn8ennRdemeXixA7NngJ6NYhL+KQIyWMrgQC2H1cJQ+T6rnkcOIBF8FGDdnZ6f2ZvUwonp8ag8EYB727FfRF2oDNc2viSsxhakN0gNIcEL2upQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=aJUqTpsQtK4VKXD+d4l8Y1skLV/8v0nbHPJn6/rdzv4=;
 b=ICFXCPv+1twx2WFmXCKE3QugWMKOXJV2huIucq8but7V31j+N1WKoX/dJkRMZtoz8niD7U+7+R2YnTvvgS41N3bE9oquMMBV1zAGBY5OeRW6E1HE6qeDSUcIfaveuL5TWeAYWk48PDGm+D91fvQl3M2aJscA4u05speZs3hnwkg=
Date: Fri, 11 Feb 2022 11:47:13 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: <xen-devel@lists.xenproject.org>, Andrew Cooper
	<andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>, Norbert Manthey
	<nmanthey@amazon.de>
Subject: Re: [PATCH CPU v1] cpuid: initialize cpuinfo with boot_cpu_data
Message-ID: <YgY+sUOIaW7c3Mq2@Air-de-Roger>
References: <20220211072327.1213-1-nmanthey@amazon.de>
 <YgYmKiZaX2vZYgKP@Air-de-Roger>
 <85182aaf-1d3b-981a-1108-8eed79516893@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <85182aaf-1d3b-981a-1108-8eed79516893@suse.com>
X-ClientProxiedBy: LO4P123CA0104.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:191::19) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 47f141c4-4bab-4485-fcb4-08d9ed4bdff7
X-MS-TrafficTypeDiagnostic: BN8PR03MB4692:EE_
X-Microsoft-Antispam-PRVS: <BN8PR03MB469231A9B7044A9B13B282C68F309@BN8PR03MB4692.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5797;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: kP2cjfinirfzwfmoasNHZ9OlWfOg0NRAQTAIDHgTa/6vS/3AsPq0aqsOMFUMNNVvjOI/CCGLAPXu60CWgCbatEkWrLr75Q5NXpgPh452NT+tnRIYSe1qExu1wvSK0HT138n/Msw6Bp/eO5omgqxnGq5NUaBiRVDkdjc3sP/KiyGMKgiUkL1TgwAuttT5Xoueg/O6irgqCUTzSFHXuvoMN4JURJu5MuMR0QGLovks3KJXLspT5YwormBW8+JeAgn0rbrmeUm+a+Anz7LB5kau3fl+0Qp82BsnBb2KViq4c9Xaty6zk8xfTyQ0dZfB8M13RzZ8l02vzUBS8ShCnJ89jygV77R730M2kBBYo3eqilnQlxpe56GL1a2i7WgZ/PvQBMdeLOJQs+p/9HINdU/wDy4JULISdJjTiOfF7epYgXFaZxtbvw+3VZ1DWZWYTaGkrZ+uPKAbAc2/4Ct81d24Cw35CYREtA91mnl8mW5NLM1zZnymiO35DDrWAEylLVlfcjyAI4Izf88k3y/rwLFekMT9FSnyY12Si+EuKE6pzM3NYh5QdU44KkIvAqxACCtXuVxVwzrAghNlamFjJLqp/rOwI4uSOlUB+EIvaH/kq3ZR6Piir4OEYs/ToL05/u+nDPF0VqMI3myMs9E2ugp2ecr4RS/3V4BN5dlKp+2KilXbXIZQAGU6Ds8MP2PvWzofuR+8j7I+8/ASKx4gsFpxFg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(6666004)(508600001)(6486002)(5660300002)(33716001)(85182001)(2906002)(186003)(8936002)(86362001)(66946007)(4326008)(66556008)(66476007)(316002)(8676002)(54906003)(38100700002)(82960400001)(9686003)(6512007)(6916009)(26005)(6506007)(53546011)(67856001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R0Z2VFZMTElUL2dBbEp1NURRUkR2QmE1RFIvV2tNV2NDZEtILzBPdk51VzVY?=
 =?utf-8?B?elgvOURzcWE1WDJ6bGtteWJoY3RHUm1ORlFNcFFmS2xsYmc2RndlOHdTbXUx?=
 =?utf-8?B?N2V5L3UyTThFMXJiV3IwTEpzd2dsUUJkL1JWNWZnU2UvMFh3ZE8vdE5UZWtm?=
 =?utf-8?B?NW13Y21sZ240KzBrVWtiVnQ3bE4vak9ucXFDODJrU0tvN2ZBaGJCb2VqQjhW?=
 =?utf-8?B?VVdOamtNQnFCc1RaNW5WWWUyQ1RwUzMvWS8rWXFxenVDQ1RTamhOQWxuSWhE?=
 =?utf-8?B?M0pZRGgxUTNRYk1FV0R5NFM1NTArbHdRQUp6dTNvdHlPUzYrenE3aEdkNnBh?=
 =?utf-8?B?ZDVwenM2OUJ4WUQ5UkYvMzlTRGZTaFFzaXk5ZTNmdUpjQnBzNk9ZMGxrMU9L?=
 =?utf-8?B?cmM0OGkxZ010blZHMG1ZZHVjSXF1aUEvR2J5VjRNSDE4YWdSYzNIQ1VVcE1t?=
 =?utf-8?B?TGVwajJndE9vZmUvZU1YMS9IUzNzVnkwU25oSlErQkpJVnlJaTN5RlhQN1Rj?=
 =?utf-8?B?empWRG5xdlBCd1NQWFFWeWdiS3ZsM1UrM2pPWnZ5bTY3b3dkcVBSa0tuYXFr?=
 =?utf-8?B?Q3huK3QwWEkrcnJsSStVdzVBYkdQdEtLU0hJbnRJVFRlMW9PYW9FK1dIVzVC?=
 =?utf-8?B?ZnE3SUxzSU0rWEtVS25IN2cveFhDRnFDZUswbno2azdmMnRXUk5Pc1A5UWUw?=
 =?utf-8?B?ZWlKcUZNRm9NLzRUejFhTys2YXFsU0JqMnRqN2tKZ2R5d1c0Nk9DS20vWVF5?=
 =?utf-8?B?QWdXeXF6NHR4bXA0eXBJMWp0NjhDVTlxZ3BnRGJ0ay9tU055OW0yV2NjOFJj?=
 =?utf-8?B?TmJUUjZCalIvbi9TZWdSTmpnQm5MQ25XTlRZa1pRRnVJSmZUZEdJSDdpSXZR?=
 =?utf-8?B?UHRZaUJxYlZRN2ZqcjRwa3dhSk4zUElybTE4OGY2T204dzYvL0t6VlQ3WW5n?=
 =?utf-8?B?QTFQYVVyanZYNlJubVhKUzB6YjRSWlR2N0RmTjl4VDBxZTgvTkJHS2NONE9w?=
 =?utf-8?B?K3A0bHJyd21vNEZBM0RmdmtuRnNqMFhtSHNLbTZWaTVNM1BiT0pjZWZQTFZv?=
 =?utf-8?B?aTlJd3RDaVNycHRMVStHc0s2dlk0SlVFcDNTNjExejBacUxadHZoeFp0c1Az?=
 =?utf-8?B?K253OExZdlVSeVNZMGNtMGdSNGJXcTRja1Z0SkZKZ2thYS9hbXE1VmczczY2?=
 =?utf-8?B?RGkxSGtmOTNQQ0dlc29FY1ZFZmQwSmdNQnZ0YncyQkl5dkZiK3E4MXBaYVd2?=
 =?utf-8?B?cjMyV21xdGhNcmJNdlgydHpiWjZpMHpFRkNiZDNLVkNMYjhyQ3N3UElWcFpJ?=
 =?utf-8?B?YVZGaVBLZzdmdmY3TnlYL1N2UWcvWG54eFY1SnBWMXliNHlvMjdIRmNYMjd5?=
 =?utf-8?B?Smt1OWZLbUtPY2lEMnlVcmRHSk00c3hha1c0eHhiRktndmM2dDBOZjhTZVh4?=
 =?utf-8?B?dWs4ZllHdERsQ1ZveHkxU3VFVUZDOHc0RmxBbGNqS1p0R0JEMTZOT0RlYzMx?=
 =?utf-8?B?Q29ZVlQyYVd2bEFhWjA2UTNhbnJFN3lLSFVCdUowQ2gzYldyK0dLT3hPSzVU?=
 =?utf-8?B?cXVDMGg2U1BQUEZXb0VGSGRFeGlJUUMzbjgwMWdGSWliMGh6NG14WExONlhn?=
 =?utf-8?B?ajlXVEcrdnZ5TXE3MTNyMTZVb0dUcnZQTlpnc0k4MUNmUHlQTVIwcnBMTWMv?=
 =?utf-8?B?bmQ3bWh1OFA5Zlp3KzVkUDIwOVd4TXl0WkJnL2tJLzRHVThxUzFwUXEyejNV?=
 =?utf-8?B?Q1J4c2Y0WkYzbXlkT3N1REJpUm1VY1ora3dsL3RlVlZUbzFtakNLQzhQenpY?=
 =?utf-8?B?MXZ6Nzk5SE12UXJPTUx1ZmZHajFDTTkzR2xodnNOV3R3SldLbzNSekQ5NGZ1?=
 =?utf-8?B?R0FjeFNDdldkQlI5a2pKY3Qyc0ZPMno3THlvWGd2SDFHc0VYV3hwb1BUOEMy?=
 =?utf-8?B?SSt0Ky9UZi9BNTAyTkpGOGFrZTNjZFkzZ1A5QWJZVy9oRVRMQ3QxbmZNOVRE?=
 =?utf-8?B?c2hWVU8waGZyd2JGUEFvSzlpWG1kU0JXUHZzbTNzcDRnU2NQTkhPTG82WmNj?=
 =?utf-8?B?Q3BDQmRZeU92ZGFya3lHVktNSUpUalBydmp6UUl6SzR1UVhrODhWZ2p0a0N4?=
 =?utf-8?B?b1NpYVFzSHlJd1k3Z3NwaS9IdlpzOHRGcks4bGRBREJDcWQyTG5tMFNjcWMy?=
 =?utf-8?Q?2YrTqn/qDPM1PJnpKOAUvQo=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 47f141c4-4bab-4485-fcb4-08d9ed4bdff7
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2022 10:47:18.7568
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jgLLysNML8Oy8IkLpdYcX/Re+bNNEfQINaI/wCN3NK+FOg0fTJZPIOn2qa7WL9T6b4ro2FxkRlcx3C0nIbOs4w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR03MB4692
X-OriginatorOrg: citrix.com

On Fri, Feb 11, 2022 at 11:32:45AM +0100, Jan Beulich wrote:
> On 11.02.2022 10:02, Roger Pau Monné wrote:
> > On Fri, Feb 11, 2022 at 08:23:27AM +0100, Norbert Manthey wrote:
> >> When re-identifying CPU data, we might use uninitialized data when
> >> checking for the cache line property to adapt the cache
> >> alignment. The data that depends on this uninitialized read is
> >> currently not forwarded.
> >>
> >> To avoid problems in the future, initialize the data cpuinfo
> >> structure before re-identifying the CPU again.
> >>
> >> The trace to hit the uninitialized read reported by Coverity is:
> >>
> >> bool recheck_cpu_features(unsigned int cpu)
> >> ...
> >>     struct cpuinfo_x86 c;
> >>     ...
> >>     identify_cpu(&c);
> >>
> >> void identify_cpu(struct cpuinfo_x86 *c)
> >> ...
> >>     generic_identify(c)
> >>
> >> static void generic_identify(struct cpuinfo_x86 *c)
> >> ...
> > 
> > Would it be more appropriate for generic_identify to also set
> > x86_cache_alignment like it's done in early_cpu_init?
> > 
> > generic_identify already re-fetches a bunch of stuff that's also
> > set by early_cpu_init for the BSP.
> 
> This would be an option, but how sure are you that there isn't
> (going to be) another field with similar properties? We better
> wouldn't require _everything_ to be re-filled in generic_identify().

So you think generic_identify should call into early_cpu_init, or even
split the cpuinfo_x86 filling done in early_cpu_init into a non-init
function that could be called by both generic_identify and
early_cpu_init?

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Feb 11 10:50:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 10:50:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270329.464576 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nITVu-0003on-Q8; Fri, 11 Feb 2022 10:50:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270329.464576; Fri, 11 Feb 2022 10:50:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nITVu-0003og-Mn; Fri, 11 Feb 2022 10:50:54 +0000
Received: by outflank-mailman (input) for mailman id 270329;
 Fri, 11 Feb 2022 10:50:53 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=jrYj=S2=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nITVt-0003oa-FQ
 for xen-devel@lists.xenproject.org; Fri, 11 Feb 2022 10:50:53 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7b0eeb66-8b28-11ec-8eb8-a37418f5ba1a;
 Fri, 11 Feb 2022 11:50:52 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2177.outbound.protection.outlook.com [104.47.17.177]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-22-29lRvt1EPBOCpJMNNlIOFw-1; Fri, 11 Feb 2022 11:50:50 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM6PR0402MB3878.eurprd04.prod.outlook.com (2603:10a6:209:16::31)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Fri, 11 Feb
 2022 10:50:49 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4975.015; Fri, 11 Feb 2022
 10:50:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7b0eeb66-8b28-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644576652;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=8BYn4als1Dc2v5D6UFzwcjqbPQqsMn3/f/Bwb1l5V+U=;
	b=MLDsdgZGy2h2MInZjK4DHHy2bW8i7YibtEIaqWT6EF1+7xnBvtiLYjMskVyF9ki2oZ9SEI
	A1Zv/wBgxqM40IjQFZnuLBs62i3x8mOZdDfKNlV/Yxd9wX4gFmbXmY4pyfZr9DRdpjXh7W
	ev9tUaDGmh768mCzR0qIFHYePoP856k=
X-MC-Unique: 29lRvt1EPBOCpJMNNlIOFw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=oEuFDbeGWLtAaOb9/vHjAnLtEdINFktQmpGVlfJV5zlLe5wHhu5Hk2UBFdriL2L60m5HyJ3ivrnNgnlcXkl4W71nfU3Y0zFsKzp0xu07hF/fywkp9JiPA4ISyI17a3EPC4NENrxmowuax5IlFiHkhf5obZUnXRUjIShIX2G+NNNFnN1eA9xSMXEBE01yfOi4lmZErXISTAlCdrEWobtbsdekllcJ367l1HTnBnP3FOpb8NORPQqdhM+/0AvWWgZhxL2cXuBnMd7Vy6hRbRo+Ab0QtadMiFAg/j7q1oHKPAoYWdy4V5qYow9j5/F/t+SPR7Y8v2tEvGqJTUi6TjkYEw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=tMokT7ZxKOF7IoLPmv848YKFSrrZom3MZndFvDTZ0aU=;
 b=dir/JVqrTY4fcVPTmPOtI4SNiaeuQnlh5namd64eOL17ybteUTFWHGWN96lV2fEFjTSI/7sEJjVlvANDMcatyXFLC0NrNU2ADR8SbihSweO/RSaMKJ1ELuNDyD5uRB4yDn4tStObWTVr2jWbDtfzshXoc/LbUxZEZujEI6wL5fxTvEwFiJGZk2fvpGQJ5wbDxUm4XyVzcY87f34Et1hg2XXQJL3SNhuACrm4ZCuqudAOBJ/Qqmxp9ogTrYsp21k5bhKpci5nvhpMmeEnIbxRF/qHmZWa53lOVD/DBR15LUC/ch0ljb5290ggcHxWkf/8v3fw6It1zGDWB/c7uPrqyA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <717694b1-bcb9-b2cd-3740-71d8431a3058@suse.com>
Date: Fri, 11 Feb 2022 11:50:46 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH CPU v1] cpuid: initialize cpuinfo with boot_cpu_data
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: xen-devel@lists.xenproject.org, Andrew Cooper
 <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 Norbert Manthey <nmanthey@amazon.de>
References: <20220211072327.1213-1-nmanthey@amazon.de>
 <YgYmKiZaX2vZYgKP@Air-de-Roger>
 <85182aaf-1d3b-981a-1108-8eed79516893@suse.com>
 <YgY+sUOIaW7c3Mq2@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YgY+sUOIaW7c3Mq2@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM7PR03CA0012.eurprd03.prod.outlook.com
 (2603:10a6:20b:130::22) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d367e558-463c-41b2-2865-08d9ed4c5d40
X-MS-TrafficTypeDiagnostic: AM6PR0402MB3878:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR0402MB3878E56D6BD2EBC398828A5FB3309@AM6PR0402MB3878.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5236;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	lKmi4CGQnEYbcQkQ1O73dzHkG+1EyrXUJFTAlss8CknB/BhyBgBhe6dpYDP2petHhjoMhSHgSTvuWI4s4q4Dr2JRqJKdQaa3PLo6oTbLJkgnyDKsXsG86VrlqDiGOkPvKmm5sh7wv65Lds8nA8uBz6PMuUJ+rWNt7V0xlFAmEw6hhZO5dTZE0yXPCRGohAedMNTjWsPQeNtyGDU4DKKijtX6B5criyNUfkWvP49B6/bw7bYB0ce0Obxj9sCV64Wnd9hZWra2uSyRbfr+CoEPfUkJMKjrehcQhNXjwNCNg4Av7v+BByykA4LF2F6AQ2YFRfETaZY8SWCgfVSNdFQx3gG95Qc8myAhUlWMTMyNxj8Kbv2PPPkm5y21VnhOrEZZ1er4Iv5Vocm6M1DOrSAmkMf85QcJizlKarpqVFtkCmffwga0/sEq3KCaY0Ypf9wzyioPhnRM8bayAl1NNMm8Ajf3YxelC1EZZwZvDEmkDvNSjd3n0zb2yK7RPns4FfMj7/YxBXAvOuGDVB0GQhID9bJcOEayXAZ/M++4iWciTA6xMW246LdNQaGgj1n+uQVBJRiobSPGWrGqwOGXUb/TWbGPPtBraiP+nX4mhVoTDYStNc3glPG5wMU/E/FzdJbg/yYq4hY/9JBAwIrp0X9V6NpFqxJcH34q1f39/slKbh3aNW906n2rx7kSlh+mvE1TyDfuPivR0Pyruo5JcvaX6jZ/CwqDviaqGTP1Eg4mhHGKdLmYKAyWBwPfsuWTwW8y
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6666004)(53546011)(6486002)(2616005)(26005)(186003)(36756003)(86362001)(31686004)(508600001)(316002)(66476007)(8936002)(31696002)(66946007)(8676002)(4326008)(54906003)(6916009)(66556008)(6512007)(6506007)(2906002)(5660300002)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?d5TAwTm1cUVm7oYcZv+tSCxlb/ElxIb5I6KRC3M//h9SS1oIKSEDdDuCST0r?=
 =?us-ascii?Q?XNkrigapBby7hdY35rPWS3lmrTuCrY6XVCUcCj9Zrc2YcYrj72AqWroyf+en?=
 =?us-ascii?Q?XXSaSmn83vMAFE+xFBMKlEz9DLx9e4UlkYJRY27vV/ThmnxEYjUOrd8ukr0e?=
 =?us-ascii?Q?Nf8pZkBPFwic77hXbE16T9Po/uzdqPeCcwDLb/Svlcyf71Lr5+XIYtH9kQ7n?=
 =?us-ascii?Q?7qoZNd+YOOTcDV7lqNQHUpOh5hMXjS/ynDJEaNQ7h0j4VGOi6MrYZf8sNt2b?=
 =?us-ascii?Q?7YolkAugweP0bo/yrqo62nDrmLXZ38DKc27APHu+s9r04LF8CajnRXI3VEqH?=
 =?us-ascii?Q?IE/kN07n4v1w8zEseBFu000KcewNvKCcf7N7xJEGJxSyLjk0kZY3eh+o3GNw?=
 =?us-ascii?Q?BBAbpLmEBVHajsSr6gybOTSgwl4DjaBrZ5Ig4MPIFO6Nl5LIMTIRBBMWX0n/?=
 =?us-ascii?Q?z15t8D/zGqHC5J0qLR5t83RwARRR8I3fczCVg1smdXzMH+Q6/GhRQEJtJngO?=
 =?us-ascii?Q?VCLOXaVRhcCGpUpk0zPS0zb+RIelhjBbYAS0foyWu7v9oQJ23eQWFSr/qWv1?=
 =?us-ascii?Q?Bm1TaCPUsH6svkOaN+22hcPmTLp+ApabpJCHzcdiHm3cAW/P5wBOpN+0u5m4?=
 =?us-ascii?Q?2a7R7yHgUZ5EqlyrgLnr8Hb0BHsjTapKSom9ZJTOn6OItIB8G0qfQfkrfX/f?=
 =?us-ascii?Q?mNje+W5iCqJq47jT+53eBO73s0E7O7wQTA0kDTJKODo/oTyf5mDwPn0eWYK3?=
 =?us-ascii?Q?N/WjSfpg5BAyAQ5RRd2RiZky5i/OxaZJvcER1BjNgnqWLb11/mNAphLuPU7G?=
 =?us-ascii?Q?4JJYdr7cP8Q5LuL7oYgbAV9UQ2Z9r35Iu36t9phN2LRHGnCn0r9VHrItZiiW?=
 =?us-ascii?Q?hEEpNX3XCPMq44x1L/2FdMvMVwLr+i2XyaHYLshAy/MjnQsJoWnquMX9JLw/?=
 =?us-ascii?Q?CpTlUrh4WWIk3EzRfKlV0cwz+JtITO6KFkocXjPGbRpQf2A5ORvqO159jplO?=
 =?us-ascii?Q?ko7JYCtaikMtAByMTgEoKeZC1LVZXjQC+pTr4X6zDweWQ3/EIuDJKCkE56Tn?=
 =?us-ascii?Q?fJrqHFVG0yFQO+bJ3q4ZlUf+NkBHbJ9IWtlvjzPq/OhJekN1yma9IFfthp7E?=
 =?us-ascii?Q?LQzwHoOAdhMxmgloF2/xQ2fbraH07It65Vg5WFbfnsCuzbV5K/QNMNlousFx?=
 =?us-ascii?Q?KuzEzl71N+eahN6OhdzB7eoR3adY5Oqpk9mt5/bhgZ55cXDeGS66se/AHAe5?=
 =?us-ascii?Q?UPLV6QLKzIHw5kgpnkP0OZjk15aWv30hEqVxpCwZj8rnS9yWoBsNw8FsM6NG?=
 =?us-ascii?Q?yTaWjAoJyf54jwuXmOmrjl9QK2zAXj4NIJXdYkrbFBvgfAjRBEdr8dVSIq7X?=
 =?us-ascii?Q?lfvUXbvNQjL443ipBtR7y/7noOjwmnI1h2fPAuv06xY1aNupeNCopdkF7sDq?=
 =?us-ascii?Q?ev4hyWnIoQS3qRfhmJO0ppu1Xn5hsIInA1jsDBFMyc3mSRdnLNCggdc3SV/T?=
 =?us-ascii?Q?Ype9p9FipIWgBkJXIV8uc99oi+q5YHeeOVPVo2/bHaqyIYmnytD8mItWlQQI?=
 =?us-ascii?Q?ZWsZ1yLlLbJUFxKRAVuIuOH0SQ5ibfaTuQXcFPOFM+G/XIImiKspuYndR+1N?=
 =?us-ascii?Q?+KIoRjW7/Pl6ij+r2cx/lFc=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d367e558-463c-41b2-2865-08d9ed4c5d40
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2022 10:50:48.8668
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Rj3mJLQfdPsBPLasG3B6ySvgupNDiFNfw0t17ZouSYcQ/tN5+7OmbA9SZf9UUx1CrQR+/lAAwK54sMiES8MCvg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR0402MB3878

On 11.02.2022 11:47, Roger Pau Monn=C3=A9 wrote:
> On Fri, Feb 11, 2022 at 11:32:45AM +0100, Jan Beulich wrote:
>> On 11.02.2022 10:02, Roger Pau Monn=C3=A9 wrote:
>>> On Fri, Feb 11, 2022 at 08:23:27AM +0100, Norbert Manthey wrote:
>>>> When re-identifying CPU data, we might use uninitialized data when
>>>> checking for the cache line property to adapt the cache
>>>> alignment. The data that depends on this uninitialized read is
>>>> currently not forwarded.
>>>>
>>>> To avoid problems in the future, initialize the data cpuinfo
>>>> structure before re-identifying the CPU again.
>>>>
>>>> The trace to hit the uninitialized read reported by Coverity is:
>>>>
>>>> bool recheck_cpu_features(unsigned int cpu)
>>>> ...
>>>>     struct cpuinfo_x86 c;
>>>>     ...
>>>>     identify_cpu(&c);
>>>>
>>>> void identify_cpu(struct cpuinfo_x86 *c)
>>>> ...
>>>>     generic_identify(c)
>>>>
>>>> static void generic_identify(struct cpuinfo_x86 *c)
>>>> ...
>>>
>>> Would it be more appropriate for generic_identify to also set
>>> x86_cache_alignment like it's done in early_cpu_init?
>>>
>>> generic_identify already re-fetches a bunch of stuff that's also
>>> set by early_cpu_init for the BSP.
>>
>> This would be an option, but how sure are you that there isn't
>> (going to be) another field with similar properties? We better
>> wouldn't require _everything_ to be re-filled in generic_identify().
>=20
> So you think generic_identify should call into early_cpu_init, or even
> split the cpuinfo_x86 filling done in early_cpu_init into a non-init
> function that could be called by both generic_identify and
> early_cpu_init?

No, I think it is quite fine for this to be a two-step process. In
fact I was hoping to eliminate some of the remaining redundancy
where possible. recheck_cpu_features(), after all, cares about just
the feature flags, so doesn't require things like cache line
alignment to be filled in.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Feb 11 10:58:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 10:58:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270337.464587 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nITdB-0004VK-Ki; Fri, 11 Feb 2022 10:58:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270337.464587; Fri, 11 Feb 2022 10:58:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nITdB-0004VD-Gc; Fri, 11 Feb 2022 10:58:25 +0000
Received: by outflank-mailman (input) for mailman id 270337;
 Fri, 11 Feb 2022 10:58:24 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=dFbI=S2=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nITdA-0004V7-IK
 for xen-devel@lists.xenproject.org; Fri, 11 Feb 2022 10:58:24 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 86f4544c-8b29-11ec-8eb8-a37418f5ba1a;
 Fri, 11 Feb 2022 11:58:23 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 86f4544c-8b29-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644577103;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=LAEMfu8n54iOxG/eCkkoBZkOUxGOxN0Zn7OnGAgWokc=;
  b=T0wGAX6CKlSJCAm3iKBXBo7Y9NInCcSppd5N3XkHgWnz7GijYjXdUDQk
   mi3n7YKHrk0+S1Wd6WEACesTdZiwEqhBsFbJvcuS0ihMCk4aWb2vUgbT9
   teTqVYSkhLzd0yJl2o//gspSBz4l0yS8uBW+nSulYtCmTYoIPIajgzOHy
   U=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: TNa7oPwQa454r2nP3RT3bUfsiYmqTRXgQeTLgbxmY6Ek+tFaZSvej+EboXwH9H1ETJc7uCF/Cy
 E7jSQt3ZtqbLDCKaC0E0KALlpD6IJmtikgCxjgzsahxXtb+/kDTBqGv6cdYYoFfLU0friyhpqV
 DRgSluSQrw9CUah8bgmPAX5SpNZW7XSsltz+5j5oPYgkh/yYNwoTYz5gVuC375+QZMijGnluv6
 AOMgD5vnj+Y8zqVVBRIYq29Hi82Fg6hlWbgryH0Ff6rQ30USNx1C+/4azsHh50qcaEC5isgh3n
 GGYlF5NYRS9zQrbPuGoNe+Nm
X-SBRS: 5.1
X-MesageID: 63910987
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:HA6mUqL111I2bOM3FE+RA5IlxSXFcZb7ZxGr2PjKsXjdYENS0TFSz
 mIWWj+BMvvcYmOmfYp3aNng90IH7cPWyNA1HQRlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokcxIn5BC5C5xZVG/fjgqoHUVaiUakideSc+EH170Ug6wrZg6mJVqYPR7z2l6
 IuaT/L3YDdJ6xYsWo7Dw/vewP/HlK2aVAIw5jTSV9gS1LPtvyB94KYkDbOwNxPFrrx8RYZWc
 QphIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbrGvaUXe345iXMfwZ3u7hB2wueFx7
 PoRu6a+RCciDIfUybs4eTZxRnQW0a1uoNcrIFC6uM2XiUbHb2Ht07NlC0Re0Y8wo7gtRzsUr
 LpBdW5LPkvra+GemdpXTsF2gcsuNo/zNZ43sXB81zDJS/0hRPgvRo2Uvo4BhGZg2aiiG97dX
 40LRgp9My/jfiZFM0UdN5BmssG30yyXnzpw9wvO+PtfD3Lo5BN1+KjgNpzSYNPibdVYmAOUq
 3zL+0z9AwoGL5qPxDyd6HWui+TT2yThV+o6Fre16/pri1273XEIBVsdUl7TnBWiohfgAZQFc
 RVSo3dw6/hpnKC2cjXjdySekX6gkUISYdRdM+YIwhnclY/+zC/MUwDoUQV9QNAhscY3Qxkj2
 VmIg87lCFRTjVGFdZ6O3uzK9G3vYED5OUdHPHZZFlVdv7EPtalu1kqnczp1LEKiYjQZ8xnUy
 ivCkiUxjq57YSUjh/TipgCvb95BS/H0ou8JCuf/AzrNAuBRPtfNi2mUBb7zt6cowGGxFAfpg
 ZT8s5LChN3i9LnU/MB3fM0DHauy+9GOOyDGjFhkEvEJrmrxpyP5IN8PumwnfC+F1/ronxezM
 Sc/XisLuvdu0IaCN/crM+pd9ex2pUQfKTgVfq+NNYcfCnSAXASG4DtvdSatM5PFyyARfVUEE
 c7DK66EVC9CYYw+lWbeb7pNgNcDm3FlrUuOFM+T8vhS+efHDJJjYexeawXmgyFQxP7snTg5B
 P4Ba5XUm08CDIUToED/qOYuELzDFlBibbjeoM1LbO+TZA1gHWAqEfjKxr09PYdimsxoei3gp
 xlRg2dUlwjyg2PpMwKPZiwxYb/jR88n/3k6ITYtLRCj3H16OdSj66IWdp0We7g79bM8ka4oH
 qddI8jQUO5STjnn+igGacWvpoJVaxn21xmFODCoYWZjcsc4FRDJ4NLtYiDm6DIKUnisrcI7r
 rD5jlHbTJMPSh5MFsHTbP7znVq9sWJEwLB5XlfSI8kVc0LpqdA4Jyv0h/4xAscNNRScmWfKi
 1fIWU8V/LCfrZU0/d/FgbG/g72oS+YuTFBHG2T77KqtMXWI9GSU3oIdAv2DeirQVT2o9fz6N
 /lV1fz1LNYOgE1O79hnC79uwK8zu4nvqrtdwlg2FXnHdQ32WLZpI33A1shTrKxdgLRevFLuC
 E6I/9BbP5SPOd/kTwFNdFZ0MLzb2KFGgCTW4NQ0PF7+tX1+87ewWElPOwWB1X5GJ7xvPYJ5m
 eostab6MeBkZsbG5jpesh1pyg==
IronPort-HdrOrdr: A9a23:A5/LT6jYpND+PvJqaK9HPbQXO3BQX0B13DAbv31ZSRFFG/FwyP
 rBoB1L73DJYWgqNE3I+erhBEGBKUmsk6KdxbNhQItKOzOWxFdATbsSl7cKpgeAJ8SQzJ856U
 4NSdkbNDS0NykEsS+Y2njJLz9D+qj+zEnAv463pB0BPGIaCZ2IrT0JcTpzencGNTWubqBJba
 Z0iPA3wAZJLh8sH7qG7zQ+LqL+juyOsKijTQ8NBhYh5gXLpTS06ITiGxzd+hsFSTtAzZor7G
 CAymXCl+memsD+7iWZ+37Y7pxQltek4txfBPaUgsxQDjn3kA6naKloRrXHljEop+OE7kosjb
 D30lodFvU2z0mUUnC+oBPr1QWl+DEy60X6wVvdunfnqdyRfkNyN+NxwaZiNjfJ4Uspu99xlI
 hR2XiCipZRBRTc2Azg+tnhTXhR5wuJiEtntdRWo21UUIMYZrMUh5cY5llpHJAJGz+/wJw7Ed
 NpENrX6J9tAB2nhkjizypSKeGXLzYO9k/seDlGhiXV6UkYoJlB9TpZ+CRF9U1wsK7USPF/lp
 L52+pT5fZzp/QtHNBA7dE6MLyK41z2MGHx2V2pUCHa/YE8SjrwQs3Mkf4IDN/DQu198HJ1ou
 WGbG9l
X-IronPort-AV: E=Sophos;i="5.88,360,1635220800"; 
   d="scan'208";a="63910987"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=at3+zOGEq5vlzTFTmHR6wnBX4/2ktG4q7VaRRD2HGpEAANfd9zNVgTuPHzQgjUBljfZtalPDBztkXyzUgQXrKx4mlVJUv6BYLIcAdp+/753Kexva42e+PLKeAU0fUUslv1A9jHdc/eKWPQOrVuwY4n9dAYGQ0x2Epoz3PFMMPI4THtjBdFQ2VT0zTI5FEvFJAzF4THuM/We93+POcuXFeBzM17Sl5u8gFz5AdCM/rT95F7IZLyY8XB0ybtO5C8WGhqzpVmTl+dCBDwWQDijE/00TNMLe/4uqpkB7lLHKCwHUABkDjLvihAe1h9q6BbrqgC64TTIXTFgdNErl2pFk0Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=PFKd2TXUXKVQldH4H3LFexBdjNxq6wIR2a2fM1vQX10=;
 b=jZv9bs+0P2ShKm6XZqw7Vl0EBHLlCR01XpiBH49oRMwwkDoSekk/6g8bel+1jStJ4vfTG+jh7IsKvE0luqum5GLFt1Bk3GPF43R/qp5ZF9/nJl5lfya9FT+3FUyt0vkq0Q/9vV73MznpDIN9rPo8RcONrjX4kKrzLY3oxSaYdrZjzgMqCloVKnHGNfKY9MTJnamis7uVTNi1O6E+NToEKIs1OPY2r9iaPc2OQllvixLdAZSmFsHlfn9aG5EvoxeV8q5kfFxL1YimP8FRdJxS/ps+2tQc5otiwn/5ip0yQC78yBXFGIN2ecp6BU0UUkwioC8dZe6fP+umcx3AKirbaA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=PFKd2TXUXKVQldH4H3LFexBdjNxq6wIR2a2fM1vQX10=;
 b=j6itnMF0PVjfurTmvJ4D8h3wE359nKmOSgXiIyw/BFPSySQGNQxBEXO67+MVStpIK3olHIoYU0+YtInU5nDcXmR1JsjYCJ5uLGg0Md2H/swJvUfsYMS0urXaMm6X/jyId+yfn7wrPOO6VkS81wjDNkNpF0kJoYNlH270iXUebSE=
Date: Fri, 11 Feb 2022 11:58:09 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Andrew
 Cooper" <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH 2/3] x86/Intel: skip CORE_THREAD_COUNT read on family 0xf
Message-ID: <YgZBQQFxx5dSZQfg@Air-de-Roger>
References: <5d275d7a-7751-af19-db4f-d91e3592d30f@suse.com>
 <1c16c2c4-0943-1db5-e22d-a6e1ffe5d00e@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1c16c2c4-0943-1db5-e22d-a6e1ffe5d00e@suse.com>
X-ClientProxiedBy: LO2P265CA0104.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:c::20) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c19536ff-6ac3-4db7-2a6f-08d9ed4d66dc
X-MS-TrafficTypeDiagnostic: BN7PR03MB3938:EE_
X-Microsoft-Antispam-PRVS: <BN7PR03MB3938848AB5861B06B7200FAB8F309@BN7PR03MB3938.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: bOTihgLKvZwFDeqdjC8jLdKSqY/PNsMnK9piC1U3shWtS3MfyiEBlUvkDZ5qcOv8jMn8eZsjrRDO2AAD9jF9mWT7vLFDB3GPxvTy1J6KbTIRxAkGmymsKel78pOeStGuwlkR13t7w5NZ4DBMzbjg461OOXHPP5UgpjB70q92ugZcqgi76TbvY/GNzuDvIW43S2Mwl55K5Ef/H4L7Dv4oBj60UZJ0n5+uXw4stmcYGqzLnLKyrrWBbi/7L2lt1c4f3vcgCRx7Wy3P/7Hz3ie8N4kfLnevNaCXPSP0CZvYYeq/VOT3bew2LNbXCUDgfySTofnWyACO523W8xBIQuPehYLpl8qUTEkI/S+5gWJ8OvUkqTjQbCN10brUbGBLtPHtiwgQNo3u5EAjdq6+BmkgcNMalwIUemAc+i9Vf4pWuf09blRNt5zA2rQ7UZf73u/miAZ8h/Fcqm/sJgAtFzbKnBaUV27dzdVqsBOHYqzW7WekybYFUYdOOQ9f8b1MroXSZOB8IsVzyvsNxLfVLxzvOu82W4U2dHPZrpWfI6TE4h6ctrDRJM2DixVAchqLAKEUJuwXakp295Ia30Hipl7fbz/rcCgeT6CNJO1FSitcifqph8QcaL8EkM0YTaxk5BVTh+6pmXEWMKBLGUs+sdFpRw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(6486002)(6666004)(6506007)(54906003)(4744005)(6916009)(83380400001)(186003)(26005)(4326008)(8936002)(33716001)(38100700002)(9686003)(66476007)(508600001)(8676002)(66556008)(66946007)(85182001)(2906002)(5660300002)(82960400001)(86362001)(6512007)(316002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TTc5dDlYSFVFM0UxTVlZeThUbWRZd2FkalZwQXpzMmVEcnU3NTI2dklsb1F1?=
 =?utf-8?B?OWhIOU5iUmdEcVdIVVA3TmVyNGR5UFBjdkVGMzFnMEdJTjZKUmh0aWdOQjk5?=
 =?utf-8?B?bDJKVWkxTmdWcVU3cjBrNmtxUFdINnYzOEN5OVFMbkNNSEZEYVdwMXNJbUVB?=
 =?utf-8?B?R21nMHY2MGFHS3A0cFVGbHZMUVFmR09IQlpxU2xpeTYzSnhxT2dUd1NCTkNk?=
 =?utf-8?B?clU2UjVRY1Zpem1xRndwYjgxMEUydjZHVjY4TDdERmxsVDBjZUsxdVU2ZTU4?=
 =?utf-8?B?aE8rZW55WVVGM3RTcWVaY0lOR2h0NEUzaVg5TU4yYmdjYi9EUVR6SW1MaU1R?=
 =?utf-8?B?RTRNMFlNZmdzQVRhWUtsbkpnaHN0NlZBSFhOUFdwL0g4ZDAxMkorODhudXFI?=
 =?utf-8?B?TUU0cXFpRDhONGMvZkxvTS9oaTVMaHdqenVZS3F3d3dObkFUQjJiUkoyakFI?=
 =?utf-8?B?cENkUUtaRlpvekpiNitycVl4NFdwa084YkswdmZhdmthU0ZFM1lhWUVVL29P?=
 =?utf-8?B?QWUxVXRFOHBHY2RCeU91WTdFbUQvKzBlbVZUbi9EM2JNWVU0d0lCRFdvenlh?=
 =?utf-8?B?b3Y0R1g3ZituQ3hWYU9LeHhoVWd3TE9CUXEvZi9LbUpmcWRqc1FhSjBISnZz?=
 =?utf-8?B?NjU4T2JHNnFRakNYZmsvL2xPZW5waGRIUTZJbXYvaFlNM2t6cnhjREJqdjRF?=
 =?utf-8?B?eHA2dGcza3krNkRsYjBKTll6YXRGSUcxOXVXaURrSDJYcnBwcDBHNHZKRTA5?=
 =?utf-8?B?UmtoQisyRi9mcDlHeDdLcExTMjg3b2RTdWo1NGFlaFYxaVhZODdnOHp2aXhl?=
 =?utf-8?B?TGFvcXpKaVVaUkdVYXFFUDVxSWNoRTN3SnlKL3c1bTBIUFdVM2lVWUlwKzBR?=
 =?utf-8?B?MHFXL0RXMFE1a2o0OVJ3YWd3alJhMEtnaytkYW9VeVl0cHp0T0FDUEFTZnZr?=
 =?utf-8?B?cXEzUWYrWExtd3ZyZlRmZEhJZWluWm5Sc3EyVER0Sm05aFMrLzJyYjRRTFBD?=
 =?utf-8?B?M09jL29vMno3TjcvZkFCMm9CWlBDNVlud3JEVEVXRkk5czRqSFd3c0cvbWRk?=
 =?utf-8?B?YkFjdk42d05hM0lERUZkM3pzZnlhdnpzUnlUL28xSlkwUHd1bDI2Q09scWpu?=
 =?utf-8?B?ZWhwbmlNNzVYQ3Vud3kwUGZaSFNMYVI2cWUvcUk5Kyt0NjUweXByeW4ydG9p?=
 =?utf-8?B?aEhwcmFvTzhiQWxvSitGZnhSSGNhVW1VYjVuK09zZkNMajZzTFFiOGhIVjFH?=
 =?utf-8?B?Q0VYalVvTGxZZEFOaWpjSGhabXViWkg4MDltT1RVd2k4VS8rL2dGWnhJL1Fq?=
 =?utf-8?B?VFNoQmo2VWhodC9kSlA5TkZNZmV1M3pwNXpWeFQ2UXUza2ZERVd4UHhjZVY0?=
 =?utf-8?B?TTNZYWg5aWF2YW1lZHlZQ3ZmcXJGb1paSzUwVUI2MGtQbE1sREwreGtESFdo?=
 =?utf-8?B?dHRhSlBWaTllRzFUaXVZYUFNdEVSSzdhRitmSlB6TjR2L3h1bTJYMWRLV05P?=
 =?utf-8?B?WFlOTEdadE9DaVFmck11b1ZtR0VkSVFkUmUxRWpJTFVXOUx5clhYWEM1emNn?=
 =?utf-8?B?ZmtsVnR6b2ovd0pLUG9IdHNkSXNDQ3NQRUE0UGJKMlFYVEtMcHhuMEFFUEZS?=
 =?utf-8?B?QTN5cmxMQm1RZ3pESTJGRXQ2SXl2TVBGUzNZYTROM3JZenN6MHBRTUJxMFV6?=
 =?utf-8?B?SU9xREdaL0p6QmFrUmRJWHZueXJHbzhzRW9ZS2NPNUNmTnpidnZEN1dXNTkr?=
 =?utf-8?B?U3ZDcFFPc2JnVDVLeXBTT2tIMGVIRFlZRjhKQThyVFJSb1crZEJMdXphUWdw?=
 =?utf-8?B?dnBWbU1TYjFVa2xKaUJvNnp2KzRBTU83NkZlS1htcjdjUXkrdnhDM1pkdHdF?=
 =?utf-8?B?R1NhWHBsaS9TTXVCNHpneXI3SFhWSUlESDFhOVNOTjZIdUYzb2FBSWF6SFZG?=
 =?utf-8?B?RCtpYkpTaHhYdzVYcmlyZGZ6RFlIUXc4WDVMcHFsNjY4OGs4UHM3SERhcFhx?=
 =?utf-8?B?WHZkRXR4dVVid0s5MlFHOGxMYzJiQ0ZkdXVRZEcwc0FpN21MMmdsNUh4aHFp?=
 =?utf-8?B?NE9kUG9TQzMwVExTQVI2ZThDV0hpNjVCZEkwdXljTENWYmtiZ0g2Z0grVDFr?=
 =?utf-8?B?NGtSa2IvMndjMDRXRDRmVGlEK2hIajdLaGtNZjVnWUlxTUY5bzZ6V09SWVdW?=
 =?utf-8?Q?M0nMVyJ1BTiUOGLrOBt5hbc=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c19536ff-6ac3-4db7-2a6f-08d9ed4d66dc
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2022 10:58:14.4855
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: twsySJ7pFBZv4J0d2wJ3SR9lTbzzLbKL4F9U9nGoa93Njmov+EwkHtm0i5uKD2GLXetTjyhRjMUGT7ms5mqE8A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB3938
X-OriginatorOrg: citrix.com

On Thu, Feb 10, 2022 at 03:56:12PM +0100, Jan Beulich wrote:
> This avoids an unnecessary (and always somewhat scary) log message for
> the recovered from #GP(0).
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

> ---
> Perhaps even use "== 6" in the family check?

I think it's best as is. Even on family 6 this seems to be supported
only on model 3f? (Haswell Xeon E5 v3 and E7 v3?)

The comment also seems to note this is mostly undocumented.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Feb 11 11:02:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 11:02:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270346.464598 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nITgh-0005y9-7K; Fri, 11 Feb 2022 11:02:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270346.464598; Fri, 11 Feb 2022 11:02:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nITgh-0005y2-4F; Fri, 11 Feb 2022 11:02:03 +0000
Received: by outflank-mailman (input) for mailman id 270346;
 Fri, 11 Feb 2022 11:02:01 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=jrYj=S2=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nITgf-0005xw-C1
 for xen-devel@lists.xenproject.org; Fri, 11 Feb 2022 11:02:01 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 093c48b3-8b2a-11ec-8f75-fffcc8bd4f1a;
 Fri, 11 Feb 2022 12:02:00 +0100 (CET)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2051.outbound.protection.outlook.com [104.47.13.51]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-20-BVCUc8VtMhmptrKVPFXJ-Q-1; Fri, 11 Feb 2022 12:01:58 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by HE1PR0401MB2682.eurprd04.prod.outlook.com (2603:10a6:3:85::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.12; Fri, 11 Feb
 2022 11:01:57 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4975.015; Fri, 11 Feb 2022
 11:01:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 093c48b3-8b2a-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644577320;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=mqWSMNbinB3HFih3Xj9/43lf1h0NXWDh3BWfNe5x+o4=;
	b=fKZWjRQ4VoYfMfDaMlXdChD/5a5VL2hVrztgsShqXxp3KFsNRvGZxgqZi/yUNymhjJtIIo
	V5BRlGBPIjkJQ/LIDc16cByYz1YQLJnAzCQfNrvHTqJ3d7gBLfwRFZGJ4yx0CVSijr09Rp
	3gRFSjaN5XjvVS/mJVxYMvr0HFRGgHU=
X-MC-Unique: BVCUc8VtMhmptrKVPFXJ-Q-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=JatLgsb8IHwjgL+vPOvP+Xse7if746rP0tX4BcPM9YOXXcVdDRUgG3EhDTt3ML9GDATpwJonbDZKwjJqLRjx7pDF9Kr4dK9CCFw7PgV3TD0epKEerg9Ii6Aiu9d7iXT6P9QTo8SBge62akkFsYr6PtazoEalTrF6GGtUzcF1WMZzupI8Wu2kTeuPqIM9sqvXa/2Rfp93IezAKEBdbsu0M+zTVxvDRG+vigtKwNxbn8MwYWmwlYgza6U8wFklerhejcImnGR4nCBsPyBBqn/GV67XqMyTRfVvxWLPKVGvc6leSm3te6sxS8nc3LdY3oerFxZ0lYOq3atwUSVQTa1olg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=mqWSMNbinB3HFih3Xj9/43lf1h0NXWDh3BWfNe5x+o4=;
 b=kQPseOy+aw39XEg1OStGpwD7fEUNggyfEa97Sh0s2LB/LZoGdV66dgRHNwSJqkFRSn44oQtLMrNkYU2G9oV35QmuJ8qH/Tx1JfhfjNXmC/N1hBwiaxF+JSU0I1Dhd/mRwSBYV77ePd8PtuHkCCFLKYi2zE+Q493O/kRmbm3QlAOKGLlvZcjyGcZzCR3I9IXEdavYOv+BCAo7+eD+AqC54pe53qmeRv5Iu4P+ZbQf7vgY6+HsZnvTllgVsIOlT0RLNvQVVkRAOutG8OCEfwgSFKp8PiBaMj4mD9JGkmhmA5HMT6XlDj7sqqnwy7dcQk8xagB0AD+9tGbfQr2DlDbXHw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <83d3077d-76ad-b35f-4be0-5e968fbcae19@suse.com>
Date: Fri, 11 Feb 2022 12:01:53 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Content-Language: en-US
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH] x86emul: work around gcc11 bug in SIMD tests
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0023.eurprd06.prod.outlook.com
 (2603:10a6:20b:462::28) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e1f1f6e9-a692-4fff-2e7f-08d9ed4deaeb
X-MS-TrafficTypeDiagnostic: HE1PR0401MB2682:EE_
X-Microsoft-Antispam-PRVS:
	<HE1PR0401MB268235A00FAD7BFEC7EFB283B3309@HE1PR0401MB2682.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1417;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	lvFDlWL0Wb3BZ2tmM8/NNPUkgzxHbXjGNsNcMHwfCVZbyIk3R3cW5D30LPyrIEuiP+53N5qmQrgQNUnJOPPDRfgpQEZo29oUChIaOh1e5d3+j+G0b0ohQGlyfizOq387e7MX++F15q7+Cxb4dOdmTI1iccyPB0dH6rZQ/lxoc36rTI068VsLyGB7Nd+j2YRsOBLXXf591Ps2e4Q59UIJn00LlJ+/9CxRU5TkC6Oz/Cz5ZQybgN6oEI+yT2VlGfPPYal+oeiZ4ro/+P7FZVAe4CBuvyyK3ogwjvmeveq3pXAwf6MJo59dCTybB0Rk/5kA6//gHoWboweZf2RMBOZ8qwZf1WUp16n1bhLThWYbQMA57Y4d9v+IGcnT2lmLNZlZ3R0TAqMGppBkqaZzcoyz7qEY/YdbgWihm0gSbYulvvu9SpxZVXQM0TCHpfG5VpQKKlj2m4bfvPU2FuBEVcl+qwjXD2cP543D6Dymq1qUL0GaE9LO0N9h/PPRGVcRG11ADwxGcMqrSfN4+xjucRmc9WIumN6pW+ZMnUiWF8nO2lmtrJo48ofhWbeThZaxrtEKDD1ZglmFvgQUXjTroKfuO5hYsfqZdabQ9uvOWwaJwWcaTMGxjZ/NBrPo3D6/UCVa9jdTX7uzjDl92zu4YeMU62K2vJvOz6UpOM9aFaiZO9bVrFiWUo7fZR1ozmVIkkwjgLRNJdDgxfb9HV9Kj6UXH1/0YWbAuSyWqGTlzGA9dYJF6ifWaPP3zTnORuLX77J75oZ1qFdaZ9zxAu5RlXvsowppV0kEGExXosjIo/jlobNjuCXlY0+CeuYYpxzQT5fLPRvy/UeORk0EObBCcbFjfA==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6666004)(508600001)(4326008)(6486002)(966005)(6916009)(54906003)(8676002)(66476007)(66946007)(66556008)(316002)(36756003)(86362001)(31696002)(6512007)(31686004)(2906002)(26005)(6506007)(8936002)(5660300002)(2616005)(38100700002)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UmR3dTFSM0tpZm9QWUdrTFZGMEpudFVlMWxXamJEREhVa1d1TEVqRkR3bG4x?=
 =?utf-8?B?b2dJTGRzOE1zNDB1TEVrRUlzaCs4OWExWE83YWFkTXZsUlo0dEQ1N08xNGNP?=
 =?utf-8?B?L3IramcrcTk3YXA4RTc1U1FNZkpGSWt5OTA5MmNaMUtyMlcwbi90NFAzNUdx?=
 =?utf-8?B?T3prVmlseW1VVEtXTXBNbTRlU1lsVWtJYlFqa2JBUG9JVXEwZVhTd1U5Y09C?=
 =?utf-8?B?UEJkVzg0bTRsS2hoc2xHdzNEYjZQdEd2T3dHSUZSZWFqcmJFcnJNMk44U2Zn?=
 =?utf-8?B?dk0rS29XQ0ZKQUxwei9TYlNiMUxBR1BzTWx2ZVo5S2VaeWZIL28vU0JJZHV0?=
 =?utf-8?B?SFl4cVpNeWR4eWlxTUVpTkJHeXdudEc1VzV0WTdnb2lodGQ3MHE4a1FmZExo?=
 =?utf-8?B?ckEyM0g0dXJqb29JMDlyejNCd2doekUzWXlTbUw1OUJTclZneFhPMWJGZzlL?=
 =?utf-8?B?V3haSUFvSWN1YldwV3JIMzhYdWNDY21LT2tzdTF3enNBVzRobFZhQ0tEd2l3?=
 =?utf-8?B?UmFaL0g2ZDJjVGJVcHFrc0QwQmhwWngwc1p5Y096b2dNaEFyUjZHUXR1TWdy?=
 =?utf-8?B?Ukg3eXhRd1J1QzhKRTVJWWluRkNxSG92Wm0xNERndHg3bWVSM0JuOXl2eThl?=
 =?utf-8?B?NUlWUWtzb1lYVndKU0ZPUnFIb0xQcnhRZXI4WTdTNnFHbXQwSjFFMDA1ejNE?=
 =?utf-8?B?WVgrdk9uK3psZUNpTDBmaGhSVENGbnBIc05HbjFyU2lxWWVvTFRkK3ZweFlt?=
 =?utf-8?B?cm5NREh4RVFCZnZmN09MaHFIclc2Zkg5WFVZdUtEaUVGNEQ2QXlQN3AxelF0?=
 =?utf-8?B?MWlYUnA5by9SanFadVJxQjIyd0N6S3dBc1JaMlR0VklxNjhjSkRUeXkwbjUw?=
 =?utf-8?B?ckJhN3UraUNEdkxFMUFRQzVKVUlVWFBTKzltTm0xd2FuL3RFTjcxOW1kalpP?=
 =?utf-8?B?SGRWQ1pzRUpQckxmVE1Wbll0a1BMaDZQVnc4OFMwT1RhdHdETU11cENrYWFw?=
 =?utf-8?B?bjJMdGNNdkVlUjhPSjYxUklqdmgyUTZabXRBclpvclhKT29JUGU4d2g4RHRD?=
 =?utf-8?B?K29nekdNeXh0NkxjZCt6T1JZS1kxMWVpLzlERDAxTjJWSGJvVkFZSnllNEtv?=
 =?utf-8?B?L1B0WVcyeUVNbjdZWGRQV0lJQk1sa0MvSXBlVXRnNjZVQUdqU0RlWDZvVktG?=
 =?utf-8?B?UXVMOVl2THhERHhTSFF6aTA1cUF0VjhXaDN0NEpTOWdGdHQ2MEg0L3JBYXRN?=
 =?utf-8?B?ZE5VbS91Z08zVytzeWNSYnlOOWpGZEdiaVZPNjNKQXR1UGhjcXNKTWgzY1Ix?=
 =?utf-8?B?WGN2eTdvRCs4WEs3bzF4c2x6VlJsbEErTHhONEZiNEpsK0dWcm40VzF0Z3Zw?=
 =?utf-8?B?aitjaUx2NlZrdXlTaGpYTHRsOEhTYURZVTdoVFI1SHVETStIeGtyVzNsa0I4?=
 =?utf-8?B?eWthblBOeWwrTjY1UGl1UGFma3pNWUVEa1FvNi84TDE4SHFIQk93OWU0OUlh?=
 =?utf-8?B?ZjhZRjJLb2VIZnplVCthbmliVEZlUmZzeThyRnY1cklWamxrUzd5d0paRS8x?=
 =?utf-8?B?YllEaGtQMXNmTkwrckVabVlTbU1xcitseGM3cmpOOW1aMEZjbU9UR2ZtaHN5?=
 =?utf-8?B?eXZTSnd3TjlkRkY4Y2xNaGRWdmw2NnJ2dGRDV0ZaY0twZWtyNWN0S3Fsd0U1?=
 =?utf-8?B?b1BsNk1FN0N2cUhEenlTMlI4VE5nbUdiV2xlclNJaFZMRnlsRmtvQUpRY3Zj?=
 =?utf-8?B?WldqTEtMYXBlbTh0aFZxVlBJeEJ5MUdybWRMVC9PbDZGQmVwbXhGbFFVZmVL?=
 =?utf-8?B?S0lQMjBwbFlrM3o5di9JSWZxSnRJRVpnQXJ6RzBuQ25MSmlSUlo3R2NpdnMv?=
 =?utf-8?B?R0c2SFpWM3lDeGdoQU5lY25HRVp3RGdkRWVOL3I1djhRYXhVU01DN0YvTTRJ?=
 =?utf-8?B?TlFEV0F4Y0dVc0JXZmE4SEpjL0NScHNwRW4yR1lVVE1XalBhazZiUXBRS2t3?=
 =?utf-8?B?clYvR3ZVSzViZWNBYmZOZWl0clRyNENoOHAyTWs1T21NN05ZbnZrYnFCdUpv?=
 =?utf-8?B?SW9Tdy9sUUx2RjI4Qlc5SndSYm9tUFA5akdmNjNlajRJcGlpWXlqeWFPYmFW?=
 =?utf-8?B?M3drNCtYd0dPNkRpSjE3elVDeEI4R0xXaHpJRzlYRXQ2bTZYUU5yd1lQMGg2?=
 =?utf-8?Q?HboFN3c8d47b/vvf/aaifDQ=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e1f1f6e9-a692-4fff-2e7f-08d9ed4deaeb
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2022 11:01:56.0588
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: M0NxGU6CGoZ12KolyMg5FMzfOsYNQrsLqnoBUIc0BdpT/pqEjJd1G6Er+3razcgrKU8TOk1Pdum9gV/Y3t+ZrA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0401MB2682

Gcc11 looks to have trouble with conditional expressions used with
vector operands: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104497.
Replace two instances causing SEGV there in certain cases.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/tools/tests/x86_emulator/simd.c
+++ b/tools/tests/x86_emulator/simd.c
@@ -1727,8 +1727,8 @@ int simd_test(void)
     if ( !eq(x - src, (alt + 1) / 2) ) return __LINE__;
 #endif
 
-    for ( i = 0; i < ELEM_COUNT; ++i )
-        y[i] = (i & 1 ? inv : src)[i];
+    for ( y = src, i = 1; i < ELEM_COUNT; i += 2 )
+        y[i] = inv[i];
 
 #ifdef select
 # ifdef UINT_SIZE
--- a/tools/tests/x86_emulator/simd-sg.c
+++ b/tools/tests/x86_emulator/simd-sg.c
@@ -282,7 +282,7 @@ int sg_test(void)
 # if ELEM_SIZE == IDX_SIZE
     y = gather(x, array, idx, (idx & inv) != 0, ELEM_SIZE);
     for ( i = 0; i < ITEM_COUNT; ++i )
-        if ( y[i] != ((i + 1) & (ITEM_COUNT - i) ? idx : inv)[i] + 1 )
+        if ( y[i] != ((i + 1) & (ITEM_COUNT - i) ? idx[i] : inv[i]) + 1 )
             return __LINE__;
     for ( ; i < ELEM_COUNT; ++i )
         if ( y[i] )



From xen-devel-bounces@lists.xenproject.org Fri Feb 11 11:05:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 11:05:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270353.464608 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nITkI-0006aX-OE; Fri, 11 Feb 2022 11:05:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270353.464608; Fri, 11 Feb 2022 11:05:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nITkI-0006aQ-L7; Fri, 11 Feb 2022 11:05:46 +0000
Received: by outflank-mailman (input) for mailman id 270353;
 Fri, 11 Feb 2022 11:05:45 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=jrYj=S2=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nITkH-0006aK-P0
 for xen-devel@lists.xenproject.org; Fri, 11 Feb 2022 11:05:45 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8efe54df-8b2a-11ec-8f75-fffcc8bd4f1a;
 Fri, 11 Feb 2022 12:05:44 +0100 (CET)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2104.outbound.protection.outlook.com [104.47.18.104]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-31-YqVv7aDUPRK54OLsu3iYsQ-1; Fri, 11 Feb 2022 12:05:43 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM6PR04MB5893.eurprd04.prod.outlook.com (2603:10a6:20b:af::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Fri, 11 Feb
 2022 11:05:42 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4975.015; Fri, 11 Feb 2022
 11:05:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8efe54df-8b2a-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644577544;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=g9fj4HX6Kc01yafvXKV4apai7LtrZXN/X8RGz/oPFqU=;
	b=hSnDeZpLOM8+60B5ymVF6uSOuJk8tnke1AjcwdnZvts6APl/rwuropoMHuV4b7lT0VlZa5
	uVlStlTqh42xJ5rkj5HOh955YtEMkn8HJdaO/ev15pcS53i4UQMW2/HL/Zafp6DRdgfhOB
	82S6cPROv4LXvFWXTOI82aVhhX3vE3E=
X-MC-Unique: YqVv7aDUPRK54OLsu3iYsQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=i1yMJNkCKZZ0K17W0P3LKS12Nx+UnCPqorCFLC6L6VoTDTxOxPXIBMsf85n8nYOEkjsDq2a8o8RYb8cdsrHwYZM64vc6pekocZ+nCUXfbNZU/E1W1Bkze3Dmmdgtz0Y08lcxq0TKQmZ/pu7sNWPLOrSV49CXPYoX7b9Vav/GkU5AiduBpkNYo1oRrFXn83symi4dCHS8kZaf/u/wVVy8FyWsOdHmz4Ih04j9i9RKMaoPmEVhksmXCdCZ/WKeTTj+cP5Q1xqEu+FX4x6OJIplp3qhPWL+RAabUYcYCTJzViAEcvkPgVRsKKn43bJbBs2e7MZRU1jWwMGBFYrelt8y9g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=npim5LqAP5/y355XR0wWSnzCG2KxB7erRmW8EKAG2MQ=;
 b=e2oZrrIgIq/Q7rk00yxevEfsnAkmMjOQjanbAkP2ugbRP9ybJp3SaKbLZyMQr82+Sg9mnzmoqWF7miQbbuQS0aYHLb1fVIbD5/rehzDYm989yWNtp26PC51DzWjQgNc7ivld2nFvdCNEV9SbDehKd6v53+ENuv9nHV6p07Q03ZuAeIUz3H77XsJk91vVbR/uFiYrYoFV+zaU+woT5MSB8Wz+5NgmeRJmnSIvilnKItP3QJCtw9RMaswqdPy/5+bYp1xwZm+dnGm7Q+mrsXOTm4DBbqsRQu2vESbwR3wgTkD4kNGX32YfcU7Dmsf1TE5mU2BIAo6Kz7n4FMFUEb0sIQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <0efb2210-88de-a4a9-a5f9-0e321445cce5@suse.com>
Date: Fri, 11 Feb 2022 12:05:40 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH 2/3] x86/Intel: skip CORE_THREAD_COUNT read on family 0xf
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
References: <5d275d7a-7751-af19-db4f-d91e3592d30f@suse.com>
 <1c16c2c4-0943-1db5-e22d-a6e1ffe5d00e@suse.com>
 <YgZBQQFxx5dSZQfg@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YgZBQQFxx5dSZQfg@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM5PR0301CA0023.eurprd03.prod.outlook.com
 (2603:10a6:206:14::36) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2af5925f-83f8-4a1f-d48c-08d9ed4e71e0
X-MS-TrafficTypeDiagnostic: AM6PR04MB5893:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB5893C5C202172A89E2277965B3309@AM6PR04MB5893.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	xSLs/ax3WK5UbfVVGD4h0KCThHL2S6TsWaO1ZQ1X+zMpK75LMDRNlNE/VCqy4u+jCnoYcgdjoqDmiOgMsuZ+w4a0fZjJDizISSOjHmVVUr7iKuYCSSVkmO5eCGYraymHxfcsp91kiKsIRUmQT4McGCFFc70UUJwr82FTTmfqPqCDQVLXms/eQgVWpAALjCdhphUdACZ8a0ZpNor6FmFXv4Rs/rR0bzau5JfT0TXfiudxDOIEC2+NXTC6JDyQvcpCeVMZnIJg1ZhxUccxvpQz8Tf53u9M8yQBWe1uEhedIbUgxB2rwNPTSqF/JseZI5BnYXj16RCQLJkpMfhBIcA85QP7EpuKPDD9aAvO7ms3XeHw4rsrRwEHk1koMURzyQI9uIT4r73oRA2/ahAbyIJaxep85RSw03QsCDLX47ZghphGjtfRE8SjpxxaZoCRQYLQx3EsdKIsKhlm4osC+AH2Oo7WhQ6i/2pK4DM+mb4eQJm16xP9E0BEuSFMIqIrX4XZ/62geqnbcBfKrXW+MJbaXRZwvzKkKOVCv4d1sqLaBdy1NT/mkIJ6OU4mYWa1zm/TJ852+psGumgl7zo5e1C4ScoP+rvZUuGQE2a+jESEkzd9anVJDlfjILa6tk6R7n6dBuYJDzVRUX6aCJ49kaJbJVz91Hk6WC83Ds3nI21rmsga7KfHMLcQsjCVMfPsQFWuhFzUhq4brG71l56P7UiZ5KI4dTsmtFhkUDkWdcgBrliWIStgXzPYa/qAwjGOmnem
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(38100700002)(66556008)(86362001)(66946007)(6506007)(5660300002)(66476007)(8676002)(54906003)(8936002)(508600001)(53546011)(6486002)(31696002)(26005)(186003)(4326008)(6916009)(31686004)(36756003)(2616005)(83380400001)(316002)(4744005)(2906002)(6512007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?L+qLDQbecV0SSpI1o501riSpeBHktXlBvHmf2g80Z7+xkyhX4LnHEBNHA5Vu?=
 =?us-ascii?Q?So5QGMFr/9p0oLa0Nt/ns2OCz+v6K75Sj/3FVpYlmcM0gEMZIYutV4ra0W1v?=
 =?us-ascii?Q?+xwJxkaIXGnP1uaT13d/fGl2iis/7Nanxe4fQPWt8nb21BcpKSmvHvxsHZF3?=
 =?us-ascii?Q?vyzO+I3wdFEYfwWpG6wVwjiUqysLLYN8emBrHSbJge/5IK8hnI8NJKAdDccf?=
 =?us-ascii?Q?93BMfgbU7weG+B5WEDB10U7//p65gurCA39VshjP7Uck6/C5UUGXoxE+1Vop?=
 =?us-ascii?Q?x8WOly9M943h39xquTebVm6Hvl3QAmuP0B+By0631oagnkVb0UKiIkdjTddS?=
 =?us-ascii?Q?P7BVjode1ZnNzJbIpAFNG7/MaAb1Oe6nkvPjys8TrDLdsTcH9J4Cl0DlST8N?=
 =?us-ascii?Q?MkOGQiIlc+qudDCTlCbagXid+jlX9CkxaMrLmG157/Igpb3mzBZUCspLBHbG?=
 =?us-ascii?Q?An6zj5qFBBexyvKQLmPpjZR44U3b9vudl61+0wIyd5I4ul6/dViU1drE0Stm?=
 =?us-ascii?Q?PFoCoBGpS+1QCjESONTVuIcTUKPJBnkRg+rWNgse8AhYOKjrzjDm+CWor2fO?=
 =?us-ascii?Q?9/MeldBzoHUnjwwBAP0oeTFfxixnT2u+jTfDONAdUJ9Kn0G9njHSVg1msXwb?=
 =?us-ascii?Q?0OcnoEW1zIuSdtP+SgpLW3Hl2/jgRt3B6/p+CLSdVVYEEV87AayMMQs7uX/6?=
 =?us-ascii?Q?IXCO8bjZ1M2+7z1XUXVUfrT2RPtW8dtkaRgpLr/ATcF6a9rUQY3jZT5SNbMd?=
 =?us-ascii?Q?hh3xFo8/DEE56sSEAEla6KEJsFAek8RvRTmGi/2Cahgx0hZ14jSrNdDtpL1p?=
 =?us-ascii?Q?sFsofnz0UY4QCkKUEs/sJ9ypfp8tH2V9fa0h1hBDxRohenR5Ac0yWSoMdgRk?=
 =?us-ascii?Q?cse2sXUmYyrIdmg2IIvjqcjepG0RLrPTjZVgJe6DECoGVvBNjFLmCyDpS7k1?=
 =?us-ascii?Q?78F5+0q5uRo7oDTAUR4cknCBEKPw2FevBU4/NdwnUng0cv5oa55fXx9vDTp2?=
 =?us-ascii?Q?zo1VjA0was8dTiYf88keXGKJiUIl9T1vUFnnW6PsdS84F4j7fRR7j4jQLY9B?=
 =?us-ascii?Q?9dUmXhm1yLEuduX/knMxrHjmCsA2EJcclzogrR4bBHM3UyX1GZ6htaP291bA?=
 =?us-ascii?Q?+uW5HybWS86k52kzlgqsX4WyWQmMm+w6f0OeE46iDqvHuFhSq0/qU38gzYjj?=
 =?us-ascii?Q?XzD/fFOLJ5yyzKN0ZW0nWNNAiGEe6c0TUpYPb7RmK6dPU0GK7tAJ1t0KENO0?=
 =?us-ascii?Q?v/4x4nHmr2Wl43hkxrr3CH7e+O5XiRAKa+IikVdLrqGoREjfXdMn2/XM3C4F?=
 =?us-ascii?Q?28TdGymCByZgqGG+8vvho5d6d0ov0REvVNa1NR5x0eiq3ZgY1xWExQNInsmY?=
 =?us-ascii?Q?Jb7D6T0HVpZuA4f0jiDFb/uVfD2/5DC1oGym+RG3rFJZfePwJrvd69YJkNux?=
 =?us-ascii?Q?Uz0owK0PwBDE2TgEHFg7OF1HsekZfirQFU+sfplO5lANdbFePjq8KMDuqpfi?=
 =?us-ascii?Q?mJFf1qs5Uw/0RZ/nLnB4VkImZuwXMKhDrcnCl4hbbHvPlwcXbrQwyuuxO9aF?=
 =?us-ascii?Q?TQWsa+Wx71w4JEJ8x1ApeRVfBhCC8hN4EyHJfdW80HXeX8gLdr1GOxEeQLTF?=
 =?us-ascii?Q?Tj2S7qjtA4eqnsTlxuL9o84=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2af5925f-83f8-4a1f-d48c-08d9ed4e71e0
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2022 11:05:42.4208
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BgvCPHCBpRHiLzvzXmhut6ljngRPuuncOYNtjOUZ0X+VqJAY46mDPVKJjkSlRRiL9TxGvvR1+5HtfIDb0zre/g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5893

On 11.02.2022 11:58, Roger Pau Monn=C3=A9 wrote:
> On Thu, Feb 10, 2022 at 03:56:12PM +0100, Jan Beulich wrote:
>> This avoids an unnecessary (and always somewhat scary) log message for
>> the recovered from #GP(0).
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>=20
> Acked-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>

Thanks.

>> ---
>> Perhaps even use "=3D=3D 6" in the family check?
>=20
> I think it's best as is. Even on family 6 this seems to be supported
> only on model 3f? (Haswell Xeon E5 v3 and E7 v3?)

Well, ...

> The comment also seems to note this is mostly undocumented.

... this same comment says "Nehalem and later". And this also
matches my observations (and, given he has written the comment, quite
clearly Andrew's as well), no matter what the (notoriously incomplete)
SDM Vol 4 may say.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Feb 11 11:09:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 11:09:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270359.464620 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nITnb-0007DZ-6e; Fri, 11 Feb 2022 11:09:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270359.464620; Fri, 11 Feb 2022 11:09:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nITnb-0007DS-3a; Fri, 11 Feb 2022 11:09:11 +0000
Received: by outflank-mailman (input) for mailman id 270359;
 Fri, 11 Feb 2022 11:09:10 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=jrYj=S2=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nITna-0007DM-DU
 for xen-devel@lists.xenproject.org; Fri, 11 Feb 2022 11:09:10 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 08e87df1-8b2b-11ec-8eb8-a37418f5ba1a;
 Fri, 11 Feb 2022 12:09:09 +0100 (CET)
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2051.outbound.protection.outlook.com [104.47.2.51]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-10-av687yQ9OHmWzqIhyCzKOg-1; Fri, 11 Feb 2022 12:09:08 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM9PR04MB8290.eurprd04.prod.outlook.com (2603:10a6:20b:3e3::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Fri, 11 Feb
 2022 11:09:07 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4975.015; Fri, 11 Feb 2022
 11:09:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 08e87df1-8b2b-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644577749;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=vle0Ii9zLD/mplP4nqUmRUtRDq+Ksr5YXBw/LJA402c=;
	b=g3J8i4RCcLUrQti+O9pSmucRjsnRk/XqJbILZLMsZJW9JI8XXZ53533OwaZmAz7iyDe9Iy
	esu1p7Tv/7BViDI+ZW2H6ff64R/Zb4y6OA017M3aWfP3Gq64mQmxuFbbnWsLXQ4XDpkQBg
	U35Z5F2Y/fHyNk3X3LqoFWI5ra0JYIk=
X-MC-Unique: av687yQ9OHmWzqIhyCzKOg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=k0881IkRPU9aYIcVnH6EiY50VIb/f4rW/QWoRZmMzp1uOELhYHbVKVQptdED9nv7RQnwA5UqnYqSGyNrUZ2kQ8P/3WRs1Gy1+XHkphGhkXkViPLgcG2QdSHBXvinIUAjRnLe/G1zqFdwa3sylA1IV7UbWERQ1ICLXekladAWux9+zeUCqotGG7fjPn/7EiCsaffasXgizr5AbE287sFaYN3HHX0VH/+hpejSLAg4Cz1amq4HVVPZiI9oSo6eaQ6t/8qIaTsdIOoYUTKjQb4TlR66Sis4M6+ovSe6PEaUaum5GWz+PUX9IZwmBqIx37C6nhwl760TRhf5gsHN4BU+0g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=vle0Ii9zLD/mplP4nqUmRUtRDq+Ksr5YXBw/LJA402c=;
 b=MhxObvdoQHngComXdIr7k385Xz0UZkllJD/OR3qIfGst5JmNxdc66OblwQmmogIS9MGauPPlvCVUYMqVNrY/ePKqlleFmGPnkikyJNKS2tWsT1UgQV93swX4xR0RkAy9dB+uL+uSJK3u4i4j/43MezoiZpp8fwkOONSS27Fo/pPKPs7hyaQ3TwMNQ04LIXinqWxgzIBq76oOVwy6NARMtrnV+hhHITuf74E1rou4nH4RKOAnUEs+dpKpSUOF8Ibng9iA2ZRxLbGER4+yxKxGCKQ3zVE9BjsMo7opaVcIP8fcfnrXLnf/iAczJYIFQpapo79zdOmnOH/SgUr1iwcc7w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <0d06eaa2-a9b4-5791-e26e-31db0a954827@suse.com>
Date: Fri, 11 Feb 2022 12:09:03 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Content-Language: en-US
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH] x86emul: fix VPBLENDMW with mask and memory operand
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR07CA0001.eurprd07.prod.outlook.com
 (2603:10a6:20b:46c::11) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a7449490-e15e-4804-73e9-08d9ed4eebb2
X-MS-TrafficTypeDiagnostic: AM9PR04MB8290:EE_
X-Microsoft-Antispam-PRVS:
	<AM9PR04MB8290A22492205F5C10F532D5B3309@AM9PR04MB8290.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6790;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	lLCvqgyE0umFVQmHFiN8XKSEiW0610DN7+Id8ndDXL2M3l3rOmWj6vKZP+nksQ4lSuSJNvah9/PUppvLR87XS0AGu6LCNE5/nq1mMwhwh7rb3FyFiLslRTcMIyhaiewt48oDPN70tGR/Q/Zx4W4jM4DVTZL+tx7SOLGSwEUZMNseZACpIy047gHoCFWNm626UFs2hCwjGHUU0T3rErSGkqQKXQAVEVb5evV+uMxzYzF8Aca1Prb5wssJBTs0UNAdVCJodUxj+E4SDWsykO14eg9ahmrqFX9GQf+9SIVKiwJrOXKJgIz+tILLuuNwxL96YhU7T8yHL+iVrlBTh86eDX0EYhksY+7Nlsc8fIdCg+gVVpNz+T+pSRMaqnfwP++hp8by9Ivz5aP3/EK6S4qnp3Gbq3GSptNWbrQuCNA4jSMl6IHZHBpSYe/r5dNw/DZImHNJEXkAVDXyhKWAXDcd+I8daWVfjSnpfYMRYgl9THzRfaHtsQFZeHeJaze+dBMc+PeUi/DSYHGoz5jtbAxm3LTvTlc9ImPlnB9GqQCIUaQIIXTx7WC1T7YOXMHZ8DG3O1FEBx4l0R1/hju9rHdTgcGsZq9tgl1vIjwDeUajDxLSHLPnnKTZmYBznfLKXdfRzRg0nR1gNbBEw8jWoTTKwKtEx5eRLraN4ROGrcXuW2XaDphfkpFI05yvIyUaHrNBCoWef2OSsXkkUt9lC9SeWBheoTxQQpYf0gBm9laKCI5ETgD1jgxeD4mBUqKZV2pY
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2906002)(36756003)(508600001)(31686004)(4326008)(6666004)(66556008)(6506007)(31696002)(8676002)(66476007)(6486002)(6512007)(66946007)(26005)(2616005)(186003)(86362001)(54906003)(38100700002)(5660300002)(8936002)(6916009)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bGJkcG9GaU5IdzhOWHlPRnFuMzN4Y2tsTHBTQytmcHVVbm5hdXBib3YydmNE?=
 =?utf-8?B?akRjWkczMmxJdnpZQjB0dS9uV1Z0OVRVTzduOVg3azhiZWw1WXJJdExUdDVQ?=
 =?utf-8?B?bDljZnY5MHIzUTdwd0ducEhLR3NjbjAya09sSk9LR3I0TElWSmhxeXQ1WnpU?=
 =?utf-8?B?WUpnMDNsc015YUhkN1VhODZYb296SDZQVDVQcFUxY2dSMTZIc3R1MmdGYTNM?=
 =?utf-8?B?WnRBMXRtdmtYRHhxM21Oc0V5Vk9POXhNdUNDZGN3cElRWTBRd1dOTnlYU0NN?=
 =?utf-8?B?Y3l4ZS9qSXcxazNDajcrOHFHVzVMSDlNb1JZNkhPSE5wMmR4ZUJFejRWc3VR?=
 =?utf-8?B?TlYxbmR6T1RLN21XandZVWhVcUdwR1prYlhwSk5uZXpNeE5tMmZkYkpiOHhh?=
 =?utf-8?B?NjFaZVFtZXlnQnM3c25mOEFvV1ZkazZNRWVoRDBCbHFmMkNvaEtUZkdTRGdo?=
 =?utf-8?B?eHlrc0RKWi9pWUMzaXhFekoxNndud3ZTV1h0Sitzd092eHh4N2N0bVhjVzFr?=
 =?utf-8?B?bXVtczVCdUZ5WHZYckhOSERLajM1eUtTdXFINlZ0Zjg2NnJ6ZGxsQVlHL2pU?=
 =?utf-8?B?M0NXYklLd2tJVmlnNVdKNyt5cHhmWCthRHdCeC96bFp5YmZsWnlWTjhRa2tH?=
 =?utf-8?B?SmpZeFg2Rko4WE15YTFuNDJMZEI5V1ZxWWdYenpRR2VxRi96ekpCdkUydGRE?=
 =?utf-8?B?c3ZSK0ZYdVpsNlZhczM5Ri9JT0dncnZhdC9pNlMyYmwzSXBpL2NyUVBhTlR0?=
 =?utf-8?B?cVZWamZjcldTdjJXTVBGUGN2Z28zT1plenhSMnIzZHVDLy9UVnBmeFl5QVpJ?=
 =?utf-8?B?d2cwdWxncklBb0tCUXVuaUwwZmgxRy9ZcXJxR2YveFJ0MkcrR01SbElkYWRT?=
 =?utf-8?B?YllZSGdRSjNVRCtKazZMb1RsTjJieDRHZDU1aWIzSVkreXpRS0ZraTB5Mk52?=
 =?utf-8?B?aVZrNFJPbFpWb1o1NzRCMXA2cVAzVmNObTcyOHJYb2Qvd2NadFJ0bVFNQUJY?=
 =?utf-8?B?UWlseWsyUy9HOUFya2dscldwcStoMFZSN1pLR0EzbXlSUVlNYllzRkd2aWdU?=
 =?utf-8?B?dXRSWCtmYmMxbngybzNsTWdWMU5LWXpJKyt1UzhXN0p3ZnNMQU03YS93Z2Yw?=
 =?utf-8?B?TkhQU0xDUGVrU0t1cmFLc0xsa2RZNGRvclMrN2FYRWdJWXA3bUNhNDNlSi9L?=
 =?utf-8?B?VnkybGt3Q0NzMU84OFFCTjBsdmtQTXZFbm8wdXdnTjh6TkpMVWN6UzM4cDFB?=
 =?utf-8?B?Wm44VWVKY2hMa1lWTklpZ1ZxR1JQcHdqSDZDWUs3bHNCc2ozc1JRNmNQT3oy?=
 =?utf-8?B?Y3h1YnEzb1IySm9tT2JMcERCM1NUeWp3OEpielVxUUUwRXd1Ym84cEtweWU5?=
 =?utf-8?B?Z0lVWS9IYzNGLy9UWmtva1hBaWE3TVZRVThLdW9zaFpGcy9EWGM5UGg5Y3Vq?=
 =?utf-8?B?VTFnNkw2dDdUc0QrWG13L2wxNHR4bmRMVFJOa1RkSFRqanFmRHhEUzF0WnU3?=
 =?utf-8?B?MFFDREhMdEZFaE1aUFVYRTVEZEk1Y3hDZWIveU1ZM21hc1J3ZTJHcUFnTG1y?=
 =?utf-8?B?M2UzYlQvYmJ2d2hLU1BxL0w0RU5EaUhZT0ppNUZ0bkV5NDBTQ0lWaktwTEhw?=
 =?utf-8?B?UEJTcmdnZmVMaDVLV0l1VTBXc0w2V1JPbFNzVWZEc0ZoRTRya1g1TlVzRXBn?=
 =?utf-8?B?RHJNZ1FUK3Bzb0dpc1IvZmFOYkFEZjFacUJyVzM3VjIvdWlJR1ZxUjg4M0U5?=
 =?utf-8?B?cmgxQXVLZlNBckpwV1E0MWRaOU4yM2tCelJnYWxQM3BzOUozZHVhQ3VhUHc1?=
 =?utf-8?B?UFhTb3J6dFNlZ3lEZUplVzAzWDE1YVZyN0xQdUdobjJuV0Y4MnllRUxwS01o?=
 =?utf-8?B?bmRXSW5FUXlhZnY3UjJ4eGNqUlFnQklpMDQzQm5aL0twWjlNQmI4VFJqaWtF?=
 =?utf-8?B?bHVzM1BMSEdHNjUwMHFrcTZQd3pURnhJSCt4cUt3N3UwL3JlbCtYNmJkUnZn?=
 =?utf-8?B?K0EySXhvUzRwNEI3NUE1enVpU1c1clF0M0tWRVgyZ0ZpeXQ1V2xOVktoOWVh?=
 =?utf-8?B?cE9wU3ZpS3RHdTNtRVdVQm5iU2ZrNnBEenBicU1rUmhlV1FkazdjRDFqbGpI?=
 =?utf-8?B?K1lPZlNudTV4aGMzcmxFL01FalEvS3YvaDZJbFZGNG9lY2crNEljNktDR3Zk?=
 =?utf-8?Q?oN0/v9ZElpnJ7ObXPJxHss8=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a7449490-e15e-4804-73e9-08d9ed4eebb2
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2022 11:09:06.8146
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LEtRcKw3pXU9XezuIUKQRGrg8g4Oz9z3brlejLcUL+0/pz0TPvpWhJGAjl5uq6/MVmD3qdl/l/iUtaJz1zathA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8290

Element size for this opcode depends on EVEX.W, not the low opcode bit.
Make use of AVX512BW being a prereq to AVX512_BITALG and move the case
label there, adding an AVX512BW feature check.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/arch/x86/x86_emulate/x86_emulate.c
+++ b/xen/arch/x86/x86_emulate/x86_emulate.c
@@ -7401,7 +7401,6 @@ x86_emulate(
     case X86EMUL_OPC_EVEX_66(0x0f38, 0x0b): /* vpmulhrsw [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */
     case X86EMUL_OPC_EVEX_66(0x0f38, 0x1c): /* vpabsb [xyz]mm/mem,[xyz]mm{k} */
     case X86EMUL_OPC_EVEX_66(0x0f38, 0x1d): /* vpabsw [xyz]mm/mem,[xyz]mm{k} */
-    case X86EMUL_OPC_EVEX_66(0x0f38, 0x66): /* vpblendm{b,w} [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */
         host_and_vcpu_must_have(avx512bw);
         generate_exception_if(evex.brs, EXC_UD);
         elem_bytes = 1 << (b & 1);
@@ -9558,6 +9557,9 @@ x86_emulate(
         /* fall through */
     case X86EMUL_OPC_EVEX_66(0x0f38, 0x54): /* vpopcnt{b,w} [xyz]mm/mem,[xyz]mm{k} */
         host_and_vcpu_must_have(avx512_bitalg);
+        /* fall through */
+    case X86EMUL_OPC_EVEX_66(0x0f38, 0x66): /* vpblendm{b,w} [xyz]mm/mem,[xyz]mm,[xyz]mm{k} */
+        host_and_vcpu_must_have(avx512bw);
         generate_exception_if(evex.brs, EXC_UD);
         elem_bytes = 1 << evex.w;
         goto avx512f_no_sae;



From xen-devel-bounces@lists.xenproject.org Fri Feb 11 11:11:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 11:11:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270368.464631 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nITps-0000BE-OG; Fri, 11 Feb 2022 11:11:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270368.464631; Fri, 11 Feb 2022 11:11:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nITps-0000B7-Kn; Fri, 11 Feb 2022 11:11:32 +0000
Received: by outflank-mailman (input) for mailman id 270368;
 Fri, 11 Feb 2022 11:11:31 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=jrYj=S2=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nITpr-0000B1-9i
 for xen-devel@lists.xenproject.org; Fri, 11 Feb 2022 11:11:31 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5cf1f810-8b2b-11ec-8eb8-a37418f5ba1a;
 Fri, 11 Feb 2022 12:11:30 +0100 (CET)
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur02lp2051.outbound.protection.outlook.com [104.47.4.51]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-40-RuU47eVtMNW5BE_A1Olc2A-1; Fri, 11 Feb 2022 12:11:29 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DU2PR04MB8902.eurprd04.prod.outlook.com (2603:10a6:10:2e1::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Fri, 11 Feb
 2022 11:11:28 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4975.015; Fri, 11 Feb 2022
 11:11:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5cf1f810-8b2b-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644577890;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=mntgJm/vlrefY5oDYBfkQrVxSgDdqW81Pnz5MPk/d8A=;
	b=X6+SoLjzFeE1lmIcVh0NDmpX12x7K4bb6epQAOejlX4thiMuvCplx1VHFmPpXDbO1fSE+P
	XFYt040Kz5n0P0egYB9qcfZMUev76zXSwJkVnB4bnOUrVu9uGnZebblnIjplby4J8isZdT
	OEsGK1c7+Dn9NPO4+rja2UnDpUQrfHI=
X-MC-Unique: RuU47eVtMNW5BE_A1Olc2A-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jGfAJIr4jeMi0+fXtHKgfI+krca68BVh7V1U6FFnn82cnGihLTgFHLTDOCB+CvB/QNWNbMQOUvBuI2cwQP1mzLPsD3b5ZAb3J+Xt+e3bJ1opyK1i1mwHJzOE+IyMyfof5U5VX37n5mwoURhymaJn4BM/NeQvQMBUdCqDYm6/xc91uUjwDq8CqgHGhp+Il8quExhBVa5duzsI2sGrU3DcSizpzi1sAdtviqPosqYvkk6fPP/FETNz3kDnGVmpomk5T4eHX1pWNFMWpo6/54HJTdrhNZpg04alR70mMASL1xCtTjxoi9t4uUMYywfLOdkY4oVUE7eMqQy6qWp3HdYymA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=mntgJm/vlrefY5oDYBfkQrVxSgDdqW81Pnz5MPk/d8A=;
 b=m6yXb9ymppQMLiYrVKOYvq/47a2nfB6MKUoQuS1rCf9YHpeb/ZF1rojHERqVYy9L5YGgOfio/cvAnWvSGRRA6mJnSAR8uarEZSZeE+6UbpsbFC9fgZcig+KapR3gsTdQsyL4JOEwZ0lAd1MhzZUOXFqL9RCh1Q/TIsPFglSrvf7XMtuev4HQszSwhDEEsPKCjPvUqVHRuSSm29PRdPrv5SPilxc2UmfUsxh9hz/J2jusq5yl3OD+cT2CFuPSY7tNorAQTKfnhSmmlwHDxJfH8Vs6jnUzD9YNu4MGWTKZTN27aFj7JIfgrHo62qcO/K9VQYdeq8PjsRri9Ocamt3w8A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <0519c820-f1ee-1b37-f1be-90bd1daf37ed@suse.com>
Date: Fri, 11 Feb 2022 12:11:26 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Content-Language: en-US
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH] x86emul: fix SIMD test overriding of VBROADCASTS{S,D}
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0402CA0003.eurprd04.prod.outlook.com
 (2603:10a6:203:90::13) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 181fddd6-0125-4861-5e5b-08d9ed4f3fdd
X-MS-TrafficTypeDiagnostic: DU2PR04MB8902:EE_
X-Microsoft-Antispam-PRVS:
	<DU2PR04MB890269A196A097BE5072E85BB3309@DU2PR04MB8902.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3276;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	fdzQYntupZ9p5rQVdNj+kxCIa9Ec38pZzcNRkzfZz+ABsWQiZhttOPPHZn/oBfQrdpTdyf9OnvwGqeedJd6RA7m6shaWiAm52MHC8UucafWrvvByMp5BIFZ7JwXsLEFLwhzsk8tn8PnIOzsSrPtetftFJ4divrOfNmlMOlh/bBzsEFawCKdfvzrb4DNEMrKY1PW8fPw0BobBqKmK2BFov/2yw0uul2ickZol7ohoY74BLsMkwgUfIjR50/xYQAgb01u1bauH1X+MG/rleHNaE6vLeAaB3b7pq++OR0HODUwrackOXrdLSAunqsdxWu4eKrffjNQs33wWyCQJfYQPdGEe6kP1iGvU0nonVrL3Jmf8tjJQyBbi5+flYQcgWFn5kKLRq86MF8jV9lQcmOoDMe1dznCOFbEXibWUz1yBMr/mU377F757SiQY2yQHElkKR1Xmb6qxwtnzbekwpY9G3+ylUb9MyDznrOxQJB04Gffhx5Zm+qk9qYN+FqWwuQ1eCP2Juh0HGJDihNNbmOsXwFZVREx/HUgvus2pW8DKP3Loh7ynH2Ln8iYY712JuYOYUDMkRlwb+UmLOGHiLoU8XnCsdlFPnAV0Gu+JXsLKF6SRCq8kaH8JHU6ZLl7othV/dfk2HjFZbCk8vCcBKeO0TgtQafeakHvGVnRmwqRa1/U62g8cuID3h20Xhi6neU0pR+5bkANodjrYcmlf+Exyvwi2AuNYj356DqQjjrzefePG81h/oOyQxJRWja7zPLid
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(508600001)(4744005)(2616005)(6486002)(31686004)(5660300002)(31696002)(26005)(6512007)(38100700002)(186003)(66556008)(66476007)(6506007)(316002)(54906003)(8676002)(8936002)(4326008)(6916009)(36756003)(2906002)(66946007)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RGRBWXYwQnp5WTI3Qk9peDJaMVlucVdEeEtTMllOU2xWUkVPc2p3dUN4dmpr?=
 =?utf-8?B?V1Bmd0NQUXFpSWRmVFZNVU93UlNLT0tuMHpwWnRjeno2TUh0dTdpQWJJTERa?=
 =?utf-8?B?c3UzczVnTjJXU2dTN09qVVBFUXpWZXJEaHdKRDRGRHZHcXIrS1F1N0ZlSERM?=
 =?utf-8?B?UnJPa0Y1M1A4NENhdjRZRUVveFlqSjB0SmtUaUlweHlsbEFxUHk1LzI1NG5G?=
 =?utf-8?B?OVRmYm83U1Q1cnZyS2V2U3V2ZnRweUw2aklqS1d2TW8xLzBPVjh6SWJ0ZXNS?=
 =?utf-8?B?Q21PZFJKV2g2SW5aQnpkMkk1Uk55WnBZTmtGWWVud1FQR2h5eVpWYkV5TVZh?=
 =?utf-8?B?WHk1MXVWNlo1T3JjSXJXREZvQnAzclJCbkUrdStudHVaUlhJMVNWdXFpRDQ4?=
 =?utf-8?B?bFFpNGFvek5HYkVWMTluZ0VCSjlNekJsVGVNMll3L1c1SDhqOVh4cEFqK001?=
 =?utf-8?B?cjIvVVFKWnRKOS9FbmpDNmlPZXVLQ0FRUXVnQ09xYXZuT1N4QnF3OTErVFha?=
 =?utf-8?B?UW0rWjB3Ylp3T1prR2Q2VVI2alY1TU9ENWFhbGxZOTlHY3FpbUhkbUZxMUtu?=
 =?utf-8?B?a0FndGxsUzB1V1JkeXBGZkdYcUdOem9DNTZDT1lhZDMwU05kL0l4TjB1SW9p?=
 =?utf-8?B?cEhZaElPZlBYc1NpMmlBM3NhYmNSWnRtQ1RhN1NhaG5zdmYycmp6dVJ5bzlj?=
 =?utf-8?B?NkhvYnBxSlR4clNIb3dGd2ZHQVNyL2YzMVBGWTFQTzVQVzNiMDh4M3hsckRT?=
 =?utf-8?B?eE5nNGcyZi9JWHVxUHRiczNxT1M2R2Q1cTZjeUpialJQa1d3V056d1ByaHhC?=
 =?utf-8?B?SEtMdHBoQ015aVh0a0RqSElvbzRBeXMzUzFITW5lK1M4ZndDdmZ0eXN0eDdu?=
 =?utf-8?B?Z2QvZUFyOWU3WitJNHJIbHZSelY0T0Z0Ymw5VXFKL0ZIWjZ4RVEySUorRVMz?=
 =?utf-8?B?bkcycUp0OEVocXdTaUZtUk56V3BBRHRyekRVTGE0T3ZBUUVhUnJPL0NLd0w4?=
 =?utf-8?B?SEN1VWNHb0IzaGVLSWkyZERNOG5zMjZJeFh5aGVwSTBmNHlOb2ZBK0pKYkNr?=
 =?utf-8?B?aS9qVnZMMkp1M3M2ckZhdVdYVkVoVzZGVGgxcWdNdVhlMjlRVUJJWkVoejVW?=
 =?utf-8?B?SVdudE1Uc0tGM20vN3V4dG1NcFI3Q3RLc2RPMjQ2ZzRlQzBiT1p4dnpZSXRv?=
 =?utf-8?B?WmwvVW5ZbW9Pa3p5Zlo2MWgrckJqL3dDS045NkY0TTBhL09PVnVOTlBlLzQ4?=
 =?utf-8?B?RDlWOU9zK2RCOGVzTmJnZmVmMWRxaTdtMURqMkNqNHVTUERJMU1NTE9XWDhE?=
 =?utf-8?B?WEUvcTgxVC80NHN1RVNkQlcxRzJMS1IydFREdTBycWRrVWw1YmNKbFRhSTBh?=
 =?utf-8?B?L1BLNTVrNFg5RkZmY1ErUXdoeGZwaGVnd3pidEUwMlVScmVoR0YrcE1IaEMr?=
 =?utf-8?B?cGNmUFpiLzl0TmF2RFozNzJPc1AxaEF5MWFndHkxelFjQ2l5TFFkM2sreUtU?=
 =?utf-8?B?bksvSll0K1lRbFpTd1RpdlZwQTIza1dOQ01VRmVsMVNUNWJIY0NMNnlRQVZm?=
 =?utf-8?B?SzJpcEQ1cXkwaUZWNnRRWVNzZGdKck8yeENKd3BEbHpwRXZSTmpqR3JrTXE4?=
 =?utf-8?B?OHEvQUFqQ1JpNG4yOVRxdTlHNDZZRG9GT2tjRmNoT2NGZklHaXBhZUIxZ2Z5?=
 =?utf-8?B?UjdTVFAxbnl3cVIzZmtWcWJrUHgvWVAyOC9ZUG5tMVZ6WjB2Q1d3TjFDaTRX?=
 =?utf-8?B?bUlXaGhudkFqNHpLWmZubjZKZ0ZYUmZDMG1pQ0d1Sm5nYU9XWjJQYitiY21P?=
 =?utf-8?B?ckZ6Sld2cGVVUEdMRVF0UzVYMWpieVdTNFNtSm1WVlJ2R0s3TVBjaXB0cGdY?=
 =?utf-8?B?TGljMUloRjNGVG01cm9mK3RjNzRFT0RtZXFmR3F2YjlJU0lnaDVsYnpZVVZM?=
 =?utf-8?B?NnZ4M2pDM2FVUTBkVFlWOG5haklOQ0U1cjJhWEdiLytqM1Z2RlRzRCtrVHcz?=
 =?utf-8?B?T1VNV1VGK0ZsbHJLU1dLeUFsMnJvZjNTaFR2d3JUUnROVDNCYUNYQXorWWVT?=
 =?utf-8?B?RGl0c2QxT2pkNCtmY28rZUdOOHRzYVZXTDlxNlgrZCt2U0NrOXF5bTZ6WVZu?=
 =?utf-8?B?c2hsY0xsOEUvWjRTSEsrazFMck0zOWsxb0R3WW9PZWU1WnlrbFpPY1dOb2s3?=
 =?utf-8?Q?979nOQc+8WGubRFXF3gDpcY=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 181fddd6-0125-4861-5e5b-08d9ed4f3fdd
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2022 11:11:28.0869
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jhL0FFBy34xbsjMso+oC+YeaigXxGbTPM1lVnDlNbIZghHqwAXY75cfrTLHdXMMzpNMCRYRIcDeyglWwIe8dhQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8902

Despite their suffixes these aren't scalar instructions, and hence the
128- and 256-bit EVEX forms may not be used without AVX512VL. Gcc11 ends
up generating such instances for simd-sg.c.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/tools/tests/x86_emulator/simd.h
+++ b/tools/tests/x86_emulator/simd.h
@@ -250,7 +250,9 @@ asm ( ".macro override insn    \n\t"
 # define OVR_INT(n) OVR_BW(n); OVR_DQ(n)
 
 OVR_INT(broadcast);
+# ifdef __AVX512VL__
 OVR_SFP(broadcast);
+# endif
 OVR_SFP(comi);
 OVR_VFP(cvtdq2);
 OVR_INT(abs);



From xen-devel-bounces@lists.xenproject.org Fri Feb 11 11:19:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 11:19:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270376.464641 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nITxJ-0000ur-HM; Fri, 11 Feb 2022 11:19:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270376.464641; Fri, 11 Feb 2022 11:19:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nITxJ-0000uk-Du; Fri, 11 Feb 2022 11:19:13 +0000
Received: by outflank-mailman (input) for mailman id 270376;
 Fri, 11 Feb 2022 11:19:11 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9nq0=S2=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1nITxH-0000ud-9a
 for xen-devel@lists.xenproject.org; Fri, 11 Feb 2022 11:19:11 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on20608.outbound.protection.outlook.com
 [2a01:111:f400:7d00::608])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6f0814ba-8b2c-11ec-8f75-fffcc8bd4f1a;
 Fri, 11 Feb 2022 12:19:10 +0100 (CET)
Received: from AS8PR05CA0016.eurprd05.prod.outlook.com (2603:10a6:20b:311::21)
 by VI1PR0801MB1838.eurprd08.prod.outlook.com (2603:10a6:800:56::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Fri, 11 Feb
 2022 11:18:57 +0000
Received: from VE1EUR03FT022.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:311:cafe::d5) by AS8PR05CA0016.outlook.office365.com
 (2603:10a6:20b:311::21) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.15 via Frontend
 Transport; Fri, 11 Feb 2022 11:18:56 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT022.mail.protection.outlook.com (10.152.18.64) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4975.11 via Frontend Transport; Fri, 11 Feb 2022 11:18:56 +0000
Received: ("Tessian outbound 2877e54fe176:v113");
 Fri, 11 Feb 2022 11:18:56 +0000
Received: from c74b10174dc2.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 D78D2EA8-21DA-436E-92D3-A0C8A35B3BC0.1; 
 Fri, 11 Feb 2022 11:18:49 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c74b10174dc2.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 11 Feb 2022 11:18:49 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by PA4PR08MB5935.eurprd08.prod.outlook.com (2603:10a6:102:e4::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Fri, 11 Feb
 2022 11:18:47 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::aca7:79c4:fa65:dac6]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::aca7:79c4:fa65:dac6%4]) with mapi id 15.20.4951.019; Fri, 11 Feb 2022
 11:18:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6f0814ba-8b2c-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=AQ1kbdgRgQY1DbM0npjKQIudIjlSMj0GSZFre9YsSgw=;
 b=NGHL+lu8yl05yxuiLg4TakQ5rsQeSrApxavpD0muIAyYOU0S2psk8MPlHrIjkdofboZ472hv9+O488zISSxGUPrSVAlQqEPxKRFQZoHKvtDxF1Qi4hfPR2MBhpH675+owCTGW5gzTJac7HFgtMyecRNim+RrmJoH2KyMTXoAQtQ=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: e3fe4f7bfb7c0760
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Qk6uQeUXY1qAEQ1qqd2pjOyIoWuM1ADgzLzvR7SbHYMIO1H0M9qPkw3Qapg+PA8Tair8K1esrYf2Eijj7cEg6xaVmYDfpXlwKhZcn58SRe4Ne99ajDL4bRLjSA1NttQnfCja2+R7oTUrqnykIlBl0GdJQCSF09+ppaEWVlJaabpsSQcVYJR9F4+3m8G1+xBvwT99Iz/xPkZS7b3zER/1sriqeR5AZY2hv5Dbz9eritOLSUldub6ivHrr3DNBMiCeFjYSRuMBD+Y1m7MgjZinf10edJSSSYyhP0O5tHGTeEpIu/FgaKlpjgO6X/GL+hB/lChrBYl6eyrjbE5atLs38w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=AQ1kbdgRgQY1DbM0npjKQIudIjlSMj0GSZFre9YsSgw=;
 b=Eh/UC38XBEWkzXBvCPRb+6iG5oL3yZXtFZfnAhfoLKmXj38iku/LleBsdnr2oaNe2Xb5Tt2iXY50usfbl+1aLF3N/tCVlA1/C9HUQghdVtkogTYvjy0O5mcxxq7erjYmmaeD1OVFBOXEWt0qxxxK3e/GAydk4RzPyetdJQ1SSIDqcGnVMt6coDKe/ojv1DhYww4VmG0poaXVOZCGl4w/O9EH6WRD3jcZ63MRY844aEPamA/VMVWsKoVx5hmXsBJ7+jnaeD+1PiJJwgUSGuEM1lUitz/amdDCKIGGtuear8w+LpAimLroA3WQs2VwOv8BGkjhTDHClx1RwYjM41da0A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=AQ1kbdgRgQY1DbM0npjKQIudIjlSMj0GSZFre9YsSgw=;
 b=NGHL+lu8yl05yxuiLg4TakQ5rsQeSrApxavpD0muIAyYOU0S2psk8MPlHrIjkdofboZ472hv9+O488zISSxGUPrSVAlQqEPxKRFQZoHKvtDxF1Qi4hfPR2MBhpH675+owCTGW5gzTJac7HFgtMyecRNim+RrmJoH2KyMTXoAQtQ=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Stefano
 Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Volodymyr
 Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [RFC v2 5/8] xen/arm: introduce SCMI-SMC mediator driver
Thread-Topic: [RFC v2 5/8] xen/arm: introduce SCMI-SMC mediator driver
Thread-Index: AQHYHRW24Dmb0qV8ZkqAv39Pf6/nVayODW6AgAAg+ICAAAmzAA==
Date: Fri, 11 Feb 2022 11:18:47 +0000
Message-ID: <A9FF3FBC-C29D-4A17-8737-EBABEF240BA2@arm.com>
References: <cover.1644341635.git.oleksii_moisieiev@epam.com>
 <cb1493f5d9b5c3437268054b4a8e345cb35c8708.1644341635.git.oleksii_moisieiev@epam.com>
 <F9811680-C6EC-4372-A451-5C1DA279E35E@arm.com>
 <20220211104403.GA2291814@EPUAKYIW015D>
In-Reply-To: <20220211104403.GA2291814@EPUAKYIW015D>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3693.60.0.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: d6a9c165-f272-4792-b72b-08d9ed504b44
x-ms-traffictypediagnostic:
	PA4PR08MB5935:EE_|VE1EUR03FT022:EE_|VI1PR0801MB1838:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0801MB183878FFE515BB1BD1A7C8989D309@VI1PR0801MB1838.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 RsHOSYlcnzjqTjh3w5hnPAiPzJL5DtRICkBGjUpqfoO8lSlH1NBdMW/M48+TVvdB/LftIkJFeUEECmN9uxxDLhGpub0CIb9//sOpBGBSbFAu3cpXnqFZFurbH2vyS8H5QY3uancYRUwJwg1DZvnoK1fuTvVV2r0OG6AbCAkd3FTf2LFmR2MtINTyqpdfdGz4U6UNSFEoM74BV6Ge3ZEuvc+mtYFLUZRQTeNEf7tAd9ew9S7TQzJAP7gbHH4cWyOEN31tpkDSAfrfF+0Jj0Zk1qOpLBfOwTTCKOiyXmDS+zD4RcvPG6aNe9p0/RkwWJGW3Ou4g8mH/DycCFitoO5jLAucQH+cMlbd1h2UkziJf/mt1Z2XC0vH1yB5Hk3BgoA2buiEoRVXdtjcAS1if0tZG8qoIgX6PKkQeFwwtI3Hd7z3292hNqXdo4ywgcuKWGSs94rHtPaKQqYkeJgvH9Yv2+1n4FWJHu0Pba+xcbRPbMdhhA+ELmYxWFIt9XqrktHpW1foX1jSoqDWA2fzD3m7ULaI5gmBSnQjIA9vDgkwpyjslDsoLQk+09mIvYmn5r9uOEDqkuFvpfcuMdCAyz46ZGdAUonqTUxbs76jxWrB6kNSFfxXutEgjLkY3lEJAJWas8rSRboghGu9BJ9LcSWkF2FIHqFMd+MjzHaLRoxUUHfJaIHNCgxMpY9WH1y1GN5BDTK96lJ5C/6yGKEftRqID7X6YBUswoEbMAlW6OT3vQl5hudPCPrZiJw5L6HuenAXdZc9gCDVYRhb7201BHe9KA==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6512007)(86362001)(91956017)(508600001)(66946007)(76116006)(8676002)(8936002)(6916009)(5660300002)(2616005)(6506007)(71200400001)(53546011)(30864003)(38070700005)(33656002)(66556008)(64756008)(66446008)(66476007)(316002)(4326008)(54906003)(83380400001)(6486002)(186003)(38100700002)(26005)(36756003)(122000001)(2906002)(2004002)(45980500001)(579004)(559001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <991164EB1309FF4A8D590A03F19D22BF@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB5935
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT022.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	360ee090-1744-4820-31e0-08d9ed5045ec
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	HIVatagPB3pPqfruYxggxLvvaNcAv4isKVKKgSXk1kq0PdBnmWO1iheLWCvi1WIM2CPoH7pM+4ihCG0rmthRZGub6DYc/F0QQeSb+4VjIJ3VC3wQKaS3K+N5akwVXiH1plK2IL0vCNTL/NPl/afflNl/zTHanwY4KHw3F+SvdiVdhlDhyXpBBV5ZsAZFqFIK5uaT68G6+iYSJwbgqiISXUIgJtxh7PnoQde+Nt+eFdPDl88CzBIMa00B4Y1Zs06+cXkwBHAxlrHWfRvGogqsPbv3OK5lQBmh0rtw2monhTZOqniE+8GlR6/1g929E5EKm4uHdp3ihMgS20GWQ8bB4LJU0xZyP2Zl+Xbmgtbq24jNTRSKMH03/BJxC7s0qeDiXBM0LEFONWnBptQ91s6IRSN9SLyb5xgwEmIXi1kN4jnWOLajlL1iM5To95JvGHil+OAg1rptAVt8RgIZ6Qfov2JTw6UJ378+2g28Mvr+NFK4LmFvNb7bjCgfpHNOZoy+xM9ZPzXOzKMmGPK0479kD8zhO0SiXtuh3C3Bd+Oy2pWQ3L/l1G5PAhJoTE/UaSE5djWv3/RHlWB4CiRDBoH72T9S3qpsWkVAy5rWLQhpzIBc36zJv5gZ/BP8zWR+35bfxgp+sF2wgyWMlm//tOagSZ5REhh1apsFZx6o05SAABteLA8ETSRUVn+Cj+uWaS4+md5z9PFy0Tsr9fvkGTt8cA==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(2906002)(508600001)(47076005)(186003)(107886003)(70206006)(54906003)(316002)(70586007)(26005)(36860700001)(36756003)(30864003)(336012)(53546011)(356005)(81166007)(86362001)(83380400001)(5660300002)(33656002)(6512007)(82310400004)(8936002)(6486002)(6506007)(4326008)(8676002)(6862004)(40460700003)(2616005)(2004002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2022 11:18:56.4190
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: d6a9c165-f272-4792-b72b-08d9ed504b44
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT022.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB1838

SGkgT2xla3NpaSwNCg0KDQo+IE9uIDExIEZlYiAyMDIyLCBhdCAxMDo0NCwgT2xla3NpaSBNb2lz
aWVpZXYgPE9sZWtzaWlfTW9pc2llaWV2QGVwYW0uY29tPiB3cm90ZToNCj4gDQo+IEhpIEJlcnRy
YW5kLA0KPiANCj4gT24gRnJpLCBGZWIgMTEsIDIwMjIgYXQgMDg6NDY6MDVBTSArMDAwMCwgQmVy
dHJhbmQgTWFycXVpcyB3cm90ZToNCj4+IEhpIE9sZWtzaWksDQo+PiANCj4+IA0KPj4+IE9uIDgg
RmViIDIwMjIsIGF0IDE4OjAwLCBPbGVrc2lpIE1vaXNpZWlldiA8T2xla3NpaV9Nb2lzaWVpZXZA
ZXBhbS5jb20+IHdyb3RlOg0KPj4+IA0KPj4+IFRoaXMgaXMgdGhlIGltcGxlbWVudGF0aW9uIG9m
IFNDSSBpbnRlcmZhY2UsIGNhbGxlZCBTQ01JLVNNQyBkcml2ZXIsDQo+Pj4gd2hpY2ggd29ya3Mg
YXMgdGhlIG1lZGlhdG9yIGJldHdlZW4gWEVOIERvbWFpbnMgYW5kIEZpcm13YXJlIChTQ1AsIEFU
RiBldGMpLg0KPj4+IFRoaXMgYWxsb3dzIGRldmljZXMgZnJvbSB0aGUgRG9tYWlucyB0byB3b3Jr
IHdpdGggY2xvY2tzLCByZXNldHMgYW5kDQo+Pj4gcG93ZXItZG9tYWlucyB3aXRob3V0IGFjY2Vz
cyB0byBDUEcuDQo+Pj4gDQo+Pj4gT3JpZ2luYWxseSwgY3BnIHNob3VsZCBiZSBwYXNzZWQgdG8g
dGhlIGRvbWFpbiBzbyBpdCBjYW4gd29yayB3aXRoDQo+Pj4gcG93ZXItZG9tYWlucy9jbG9ja3Mv
cmVzZXRzIGV0Yy4gQ29uc2lkZXJpbmcgdGhhdCBjcGcgY2FuJ3QgYmUgc3BsaXQgYmV0d2Vlbg0K
Pj4+IHRoZSBEb21haW5zLCB3ZSBnZXQgdGhlIGxpbWl0YXRpb24gdGhhdCB0aGUgZGV2aWNlcywg
d2hpY2ggYXJlIHVzaW5nDQo+Pj4gcG93ZXItZG9tYWlucy9jbG9ja3MvcmVzZXRzIGV0YywgY291
bGRuJ3QgYmUgc3BsaXQgYmV0d2VlbiB0aGUgZG9tYWlucy4NCj4+PiBUaGUgc29sdXRpb24gaXMg
dG8gbW92ZSB0aGUgcG93ZXItZG9tYWluL2Nsb2NrL3Jlc2V0cyBldGMgdG8gdGhlDQo+Pj4gRmly
bXdhcmUgKHN1Y2ggYXMgU0NQIGZpcm13YXJlIG9yIEFURikgYW5kIHByb3ZpZGUgaW50ZXJmYWNl
IGZvciB0aGUNCj4+PiBEb21haW5zLiBYRU4gc2hvdWxkIGhhdmUgYW4gZW50aXR5LCBjYWxlZCBT
Q0ktTWVkaWF0b3IsIHdoaWNoIGlzDQo+Pj4gcmVzcG9uc2libGUgZm9yIG1lc3NhZ2VzIHJlZGly
ZWN0aW9uIGJldHdlZW4gRG9tYWlucyBhbmQgRmlybXdhcmUgYW5kDQo+Pj4gZm9yIHBlcm1pc3Np
b24gaGFuZGxpbmcuDQo+Pj4gDQo+Pj4gVGhlIGZvbGxvd2luZyBmZWF0dXJlcyBhcmUgaW1wbGVt
ZW50ZWQ6DQo+Pj4gLSByZXF1ZXN0IFNDTUkgY2hhbm5lbHMgZnJvbSBBVEYgYW5kIHBhc3MgY2hh
bm5lbHMgdG8gRG9tYWluczsNCj4+PiAtIHNldCBkZXZpY2UgcGVybWlzc2lvbnMgZm9yIERvbWFp
bnMgYmFzZWQgb24gdGhlIERvbWFpbiBwYXJ0aWFsDQo+Pj4gZGV2aWNlLXRyZWUuIERldmljZXMg
d2l0aCBwZXJtaXNzaW9ucyBhcmUgYWJsZSB0byB3b3JrIHdpdGggY2xvY2tzLA0KPj4+IHJlc2V0
cyBhbmQgcG93ZXItZG9tYWlucyB2aWEgU0NNSTsNCj4+PiAtIHJlZGlyZWN0IHNjbWkgbWVzc2Fn
ZXMgZnJvbSBEb21haW5zIHRvIEFURi4NCj4+IA0KPj4gQmVmb3JlIGdvaW5nIG1vcmUgZGVlcGx5
IGluIHRoZSBjb2RlIEkgd291bGQgbGlrZSB0byBkaXNjdXNzIHRoZSBnZW5lcmFsDQo+PiBkZXNp
Z24gaGVyZSBhbmQgYXNrIHNvbWUgcXVlc3Rpb25zIHRvIHByZXZlbnQgdG8gcmV3b3JrIHRoZSBj
b2RlIGJlZm9yZQ0KPj4gd2UgYWxsIGFncmVlIHRoYXQgdGhpcyBpcyB0aGUgcmlnaHQgc29sdXRp
b24gYW5kIHRoYXQgd2Ugd2FudCB0aGlzIGluIFhlbi4NCj4+IA0KPj4gRmlyc3QgSSB3YW50IHRv
IHBvaW50IG91dCB0aGF0IGNsb2NrL3Jlc2V0L3Bvd2VyIHZpcnR1YWxpemF0aW9uIGlzIGEgcHJv
YmxlbQ0KPj4gb24gbW9zdCBhcHBsaWNhdGlvbnMgdXNpbmcgZGV2aWNlIHBhc3MtdGhyb3VnaCBh
bmQgSSBhbSB2ZXJ5IGdsYWQgdGhhdA0KPj4gc29tZW9uZSBpcyBsb29raW5nIGludG8gaXQuDQo+
PiBBbHNvIFNDTUkgaXMgdGhlIGN1cnJlbnQgc3RhbmRhcmQgZXhpc3RpbmcgZm9yIHRoaXMgc28g
cmVseWluZyBvbiBpdCBpcyBhIHZlcnkNCj4+IGdvb2QgaWRlYS4NCj4+IA0KPj4gTGF0ZXN0IHZl
cnNpb24gU0NNSSBzdGFuZGFyZCAoREVOMDA1NkQgdjMuMSkgaXMgZGVmaW5pbmcgc29tZSBtZWFu
cw0KPj4gdG8gdXNlIFNDTUkgb24gYSB2aXJ0dWFsaXNlZCBzeXN0ZW0uIEluIGNoYXB0ZXIgNC4y
LjEsIHRoZSBzdGFuZGFyZA0KPj4gcmVjb21tZW5kcyB0byBzZXQgcGVybWlzc2lvbnMgcGVyIGFn
ZW50IGluIHRoZSBoeXBlcnZpc29yIHNvIHRoYXQgYSBWTQ0KPj4gY291bGQgbGF0ZXIgdXNlIHRo
ZSBkaXNjb3ZlcnkgcHJvdG9jb2wgdG8gZGV0ZWN0IHRoZSByZXNvdXJjZXMgYW5kIHVzZSB0aGVt
Lg0KPj4gVXNpbmcgdGhpcyBraW5kIG9mIHNjZW5hcmlvIHRoZSBtZWRpYXRvciBpbiBYZW4gd291
bGQganVzdCBjb25maWd1cmUgdGhlDQo+PiBQZXJtaXNzaW9ucyBpbiB0aGUgU0NNSSBhbmQgd291
bGQgdGhlbiByZWx5IG9uIGl0IHRvIGxpbWl0IHdoYXQgaXMgcG9zc2libGUNCj4+IGJ5IHdobyBq
dXN0IGJ5IGp1c3QgYXNzaWduaW5nIGEgY2hhbm5lbCB0byBhIFZNLg0KPiANCj4+IA0KPj4gSW4g
eW91ciBjdXJyZW50IGRlc2lnbiAocGxlYXNlIGNvcnJlY3QgbWUgaWYgSSBhbSB3cm9uZykgeW91
IHNlZW0gdG8gZnVsbHkNCj4+IHJlbHkgb24gWGVuIGFuZCB0aGUgRkRUIGZvciBkaXNjb3Zlcnkg
YW5kIHBlcm1pc3Npb24uDQo+IA0KPiBJbiBjdXJyZW50IGltcGxlbWVudGF0aW9uIFhlbiBpcyB0
aGUgdHJ1c3RlZCBhZ2VudC4gQW5kIGl0J3MgcmVzcG9uc2libGUNCj4gZm9yIHBlcm1pc3Npb25z
IHNldHRpbmcuIER1cmluZyBpbml0aWFsaXphdGlvbiBpdCBkaXNjb3ZlcnMgYWdlbnQgYW5kDQo+
IHNldCBwZXJtaXNzaW9ucyBieSB1c2luZyBCQVNFX1NFVF9ERVZJQ0VfUEVSTUlTU0lPTlMgdG8g
dGhlIERvbTAuIFdoZW4NCj4gbmV3IGRvbWFpbiBpcyBjcmVhdGVkLCBYZW4gYXNzaWducyBhZ2Vu
dCBpZCBmb3IgdGhpcyBkb21haW4gYW5kIHJlcXVlc3QNCj4gcmVzb3VyY2VzLCB0aGF0IGFyZSBw
YXNzZWQtdGhyb3VnaCB0byB0aGlzIERvbWFpbi4NCg0KT2sNCg0KPiANCj4gSSdtIGdldHRpbmcg
dGhlIGZvbGx3aW5nIGluZm9ybWF0aW9uIGZyb20gRkRUOg0KPiAxKSBTaGFyZWQgbWVtb3J5IGFk
ZHJlc3NlZCwgd2hpY2ggc2hvdWxkIGJlIHVzZWQgZm9yIGFnZW50cy4gRHVyaW5nDQo+IGluaXRp
YWxpemF0aW9uIEkgc2VuZCBCQVNFX0RJU0NPVkVSX0FHRU5UIHRvIGVhY2ggb2YgdGhpcyBhZGRy
ZXNzZXMgYW5kDQo+IHJlY2VpdmUgYWdlbnRfaWQuIFhlbiBpcyByZXNwb25zaWJsZSBmb3IgYXNz
aWduaW5nIGFnZW50X2lkIGZvciB0aGUNCj4gRG9tYWluLiBUaGVuIFhlbiBpbnRlcmNlcHQgc21j
IGNhbGxzIGZyb20gdGhlIGRvbWFpbiwgc2V0IGFnZW50X2lkIGFuZA0KPiByZWRpcmVjdHMgaXQg
dG8gdGhlIEZpcm13YXJlLg0KDQpTbyBYZW4gaXMgc2V0dGluZyB0aGUgYWdlbnQgSUQsIG5vIHdh
eSBmb3IgYSBndWVzdCB0byBnZXQgYWNjZXNzIHRvIHNvbWV0aGluZyBpdA0Kc2hvdWxkIHdpdGgg
bW9yZSBjaGVjaywgYW0gSSByaWdodCA/DQoNCj4gDQo+IDIpIERldmljZXMsIHRoYXQgYXJlIHVz
aW5nIFNDTUkuIFRob3NlIGRldmljZXMgaGFzIGNsb2NrL3Bvd2VyL3Jlc2V0cw0KPiBldGMgcmVs
YXRlZCB0byBzY21pIHByb3RvY29sIChhcyBpdCBpcyBkb25lIGluIExpbnV4IGtlcm5lbCkNCj4g
YW5kIHNjbWlfZGV2aWQgc2hvdWxkIGJlIHNldC4gSSdtIGN1cnJlbnRseSBwcmVwYXJpbmcgdG8g
c2VuZCBwYXRjaCwNCj4gdXBkYXRpbmcga2VybmVsIGJpbmRpbmdzIHdpdGggdGhpcyBwYXJhbWV0
ZXIgdG8gTGludXgga2VybmVsLg0KPiBzY21pX2RldmlkIHZhbHVlIHNob3VsZCBtYXRjaCBkZXZp
Y2UgaWQsIHNldCBpbiB0aGUgRmlybXdhcmUuDQo+IGR0IGV4YW1wbGU6DQo+ICZ1c2IwIHsNCj4g
ICAgc2NtaV9kZXZpZCA9IDwxPjsgLy8gdXNiMCBkZXZpY2UgaWQNCj4gICAgY2xvY2tzID0gPCZz
Y21pX2Nsb2NrIDE+IC8vIHJlbGF5cyBvbiBjbG9jayB3aXRoIGlkIDENCj4gfQ0KPiANCj4gWGVu
IHJlcXVlc3RzIHBlcm1pc3Npb24gZm9yIHRoZSBkZXZpY2Ugd2hlbiBkZXZpY2UgaXMgYXR0YWNo
ZWQgdG8gdGhlDQo+IERvbWFpbiBkdXJpbmcgY3JlYXRpb24uDQoNCldpdGhvdXQgdGhpcywgaG93
IGlzIChpZiBpdCBpcykgdGhlIGxpbnV4IGtlcm5lbCB1c2luZyBTQ01JIGZvciBwb3dlciBtYW5h
Z2VtZW50ID8NCg0KPiANCj4+IFdvdWxkbuKAmXQgaXQgYmUgYSBiZXR0ZXIgaWRlYSB0byB1c2Ug
dGhlIHByb3RvY29sIGZ1bGx5ID8NCj4gDQo+IEhtLCBJIHdhcyB0aGlua2luZyBJIGFtIHVzaW5n
IHRoZSBwcm90b2NvbCBmdWxseS4gRGlkIEkgbWlzcyBzb21ldGhpbmc/DQoNClNvcnJ5IHlvdSBz
ZWVtIHRvIGJlLCBteSB1bmRlcnN0YW5kaW5nIG9mIHlvdXIgZGVzaWduIHdhcyBub3QgcmlnaHQu
DQoNCj4gDQo+PiBDb3VsZCB3ZSBnZXQgcmlkIG9mIHNvbWUgb2YgdGhlIEZEVCBkZXBlbmRlbmNp
ZXMgYnkgdXNpbmcgdGhlIGRpc2NvdmVyeQ0KPj4gc3lzdGVtIG9mIFNDTUkgPw0KPiANCj4gSSdt
IHVzaW5nIEZEVCB0byBnZXQgc2htZW0gcmVnaW9ucyBmb3IgdGhlIGNoYW5uZWxzLiBUaGVuIEkg
c2VuZA0KPiBCQVNFX0RJU0NPVkVSX0FHRU5UIHRvIGVhY2ggcmVnaW9uIGFuZCBnZXR0aW5nIGFn
ZW50IGRhdGEuIERpZCBJIHVzZSB0aGUNCj4gZGlzY292ZXJ5IHN5c3RlbSB3cm9uZz8NCg0KQWZ0
ZXIgbW9yZSBkaWdnaW5nIGl0IHNlZW1zIHlvdSBhcmUuIFRoZSBsaW5rIGJldHdlZW4gc2NtaSBy
ZXNvdXJjZSBhbmQgZGV2aWNlDQppcyBub3QgcG9zc2libGUgdG8gZ2V0IGF1dG9tYXRpY2FsbHku
DQoNCj4gDQo+PiBIb3cgaXMgTGludXggZG9pbmcgdGhpcyBjdXJyZW50bHkgPyBJcyBpdCByZWx5
aW5nIG9uIGRldmljZSB0cmVlIHRvIGRpc2NvdmVyDQo+PiB0aGUgU0NNSSByZXNvdXJjZXMgPw0K
PiANCj4gWWVzLiBMaW51eCBrZXJuZWwgaGFzIDIgbm9kZXMgaW4gdGhlIGRldmljZS10cmVlOiBh
cm0sc2NtaS1zaG1lbSwgd2hpY2gNCj4gaW5jbHVkZXMgbWVtb3J5IHJlZ2lvbiBmb3IgdGhlIGNv
bW11bmljYXRpb24gYW5kIGFybSxzY21pLXNtYyBub2RlLA0KPiB3aGljaCBkZXNjcmliZXMgYWxs
IGRhdGEgcmVsYXRlZCB0byBzY21pICggZnVuY19pZCwgcHJvdG9jb2xzIGV0YykNCj4gVGhlbiB0
aGUgZGV2aWNlIG5vZGVzIHJlZmVyIHRvIHRoZSBwcm90b2NvbHMgYnkgc2V0dGluZw0KPiBjbG9j
ay9yZXNldHMvcG93ZXItZG9tYWlucyBldGMuIFBsZWFzZSBzZWUgdGhlIGV4YW1wbGUgYWJvdmUu
DQo+IEJBU0VfRElTQ09WRVJfQUdFTlQgaXMgbm90IHVzZWQgaW4gTGludXgga2VybmVsLg0KPiBU
aGUgbWFpbiBpZGVhIHdhcyB0aGF0IHNjbWkgcmVsYXRlZCBjaGFuZ2VzIHRvIHRoZSBkZXZpY2Ut
dHJlZSBhcmUNCj4gY29tbW9uIGZvciB2aXJ0dWFsaXplZCBhbmQgbm9uIHZpcnR1YWxpemVkIHN5
c3RlbXMuIFNvIHRoZSBzYW1lIEZEVA0KPiBjb25maWd1cmF0aW9uIHNob3VsZCB3b3JrIHdpdGgg
b2Ygd2l0aG91dCBYZW4uDQoNClNvIGF0IHRoaXMgc3RhZ2UgdGhpcyBpcyBub3Qgc3VwcG9ydGVk
IGluIExpbnV4IGFuZCB5b3UgcGxhbiB0byBhZGQgc3VwcG9ydCBmb3IgaXQgdG8uDQoNCj4gDQo+
PiANCj4+IEFsc28gSSB1bmRlcnN0YW5kIHRoYXQgeW91IHJlbHkgb24gc29tZSBlbnRyaWVzIHRv
IGJlIGRlY2xhcmVkIGluIHRoZSBkZXZpY2UNCj4+IHRyZWUgYW5kIGFsc28gc29tZSBzdXBwb3J0
IHRvIGJlIGltcGxlbWVudGVkIGluIEFURiBvciBTQ1AuIEkgY2hlY2tlZCBpbg0KPj4gVGhlIGJv
YXJkcyBJIGhhdmUgYWNjZXNzIHRvIGFuZCB0aGUgZGV2aWNlIHRyZWVzIGJ1dCBub25lIG9mIHRo
aXMgc2VlbSB0bw0KPj4gYmUgc3VwcG9ydGVkIHRoZXJlLiBDb3VsZCB5b3UgdGVsbCB3aGljaCBi
b2FyZC9jb25maWd1cmF0aW9uL0FURiB5b3UgYXJlDQo+PiB1c2luZyBzbyB0aGF0IHRoZSBpbXBs
ZW1lbnRhdGlvbiBjb3VsZCBiZSB0ZXN0ZWQvdmFsaWRhdGVkID8NCj4+IA0KPiANCj4gV2UncmUg
Y3VycmVudGx5IGhhdmUgUE9DIG1hZGUgZm9yIHI4YTc3OTUxLXVsY2Ita2YgYW5kDQo+IHI4YTc3
OTYxLXNhbHZhdG9yLXhzIGJvYXJkcy4gSXQncyBiYXNlZCBvbjoNCj4gTGludXgtYnNwIGtlcm5l
bDogDQo+IGdpdEBnaXRodWIuY29tOnJlbmVzYXMtcmNhci9saW51eC1ic3AuZ2l0DQo+IGJhc2Vk
IG9uIHRhZyA8cmNhci01LjAuMC5yYzQ+DQo+IA0KPiBBVEY6IA0KPiBnaXRAZ2l0aHViLmNvbTpy
ZW5lc2FzLXJjYXIvYXJtLXRydXN0ZWQtZmlybXdhcmUuZ2l0DQo+IGJhc2VkIG9uIGJyYW5jaCA8
cmNhcl9nZW4zX3YyLjU+DQo+IA0KPiBJIGNhbiBwdXNoIHRob3NlIGNoYW5nZXMgdG8gR2l0aHVi
LCBzbyB5b3UgY2FuIHJldmlldyB0aGVtLg0KDQpEbyB5b3UgcGxhbiB0byBhZGQgc3VwcG9ydCBm
b3Igb3RoZXIgYm9hcmRzID8NCg0KRGlkIHlvdSBkaXNjdXNzIG1vcmUgaW4gZ2VuZXJhbCB3aXRo
IHRoZSBsaW51eCBrZXJuZWwgZ3V5cyB0byBzZWUgaWYgdGhpcw0KYXBwcm9hY2ggd2FzIGFncmVl
ZCBhbmQgd2lsbCBiZSBhZG9wdGVkIGJ5IG90aGVyIG1hbnVmYWN0dXJlcnMgPw0KDQpBbGwgaW4g
YWxsIEkgdGhpbmsgdGhpcyBpcyBhIGdvb2QgaWRlYSBidXQgSSBmZWFyIHRoYXQgYWxsIHRoaXMg
d2lsbCBhY3R1YWxseSBvbmx5DQpiZSB1c2VkIGJ5IG9uZSBib2FyZCBvciBvbmUgbWFudWZhY3R1
cmVyIGFuZCBvdGhlciBtaWdodCB1c2UgYSBkaWZmZXJlbnQNCnN0cmF0ZWd5LCBJIHdvdWxkIGxp
a2UgdG8gdW5yaXNrIHRoaXMgYmVmb3JlIG1lcmdpbmcgdGhpcyBpbiBYZW4uDQoNCkBqdWxpZW4g
YW5kIFN0ZWZhbm86IHdoYXQgaXMgeW91ciB2aWV3IGhlcmUgPw0KDQpDaGVlcnMNCkJlcnRyYW5k
DQoNCj4gDQo+IEJlc3QgcmVnYXJkcywNCj4gT2xla3NpaS4NCj4gDQo+PiANCj4+IFJlZ2FyZHMN
Cj4+IEJlcnRyYW5kDQo+PiANCj4+IA0KPj4+IA0KPj4+IFNpZ25lZC1vZmYtYnk6IE9sZWtzaWkg
TW9pc2llaWV2IDxvbGVrc2lpX21vaXNpZWlldkBlcGFtLmNvbT4NCj4+PiAtLS0NCj4+PiB4ZW4v
YXJjaC9hcm0vS2NvbmZpZyAgICAgICAgfCAgIDIgKw0KPj4+IHhlbi9hcmNoL2FybS9zY2kvS2Nv
bmZpZyAgICB8ICAxMCArDQo+Pj4geGVuL2FyY2gvYXJtL3NjaS9zY21pX3NtYy5jIHwgOTU5ICsr
KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKw0KPj4+IDMgZmlsZXMgY2hhbmdlZCwg
OTcxIGluc2VydGlvbnMoKykNCj4+PiBjcmVhdGUgbW9kZSAxMDA2NDQgeGVuL2FyY2gvYXJtL3Nj
aS9LY29uZmlnDQo+Pj4gY3JlYXRlIG1vZGUgMTAwNjQ0IHhlbi9hcmNoL2FybS9zY2kvc2NtaV9z
bWMuYw0KPj4+IA0KPj4+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vS2NvbmZpZyBiL3hlbi9h
cmNoL2FybS9LY29uZmlnDQo+Pj4gaW5kZXggYWIwNzgzMzU4Mi4uM2IwZGZjNTdiNiAxMDA2NDQN
Cj4+PiAtLS0gYS94ZW4vYXJjaC9hcm0vS2NvbmZpZw0KPj4+ICsrKyBiL3hlbi9hcmNoL2FybS9L
Y29uZmlnDQo+Pj4gQEAgLTEyMyw2ICsxMjMsOCBAQCBjb25maWcgQVJNX1NDSQ0KPj4+IAkgIHN1
cHBvcnQuIEl0IGFsbG93cyBndWVzdHMgdG8gY29udHJvbCBzeXN0ZW0gcmVzb3VyY2VzcyB2aWEg
b25lIG9mDQo+Pj4gCSAgQVJNX1NDSSBtZWRpYXRvcnMgaW1wbGVtZW50ZWQgaW4gWEVOLg0KPj4+
IA0KPj4+ICsJc291cmNlICJhcmNoL2FybS9zY2kvS2NvbmZpZyINCj4+PiArDQo+Pj4gZW5kbWVu
dQ0KPj4+IA0KPj4+IG1lbnUgIkFSTSBlcnJhdGEgd29ya2Fyb3VuZCB2aWEgdGhlIGFsdGVybmF0
aXZlIGZyYW1ld29yayINCj4+PiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL3NjaS9LY29uZmln
IGIveGVuL2FyY2gvYXJtL3NjaS9LY29uZmlnDQo+Pj4gbmV3IGZpbGUgbW9kZSAxMDA2NDQNCj4+
PiBpbmRleCAwMDAwMDAwMDAwLi4xMGI2MzRkMmVkDQo+Pj4gLS0tIC9kZXYvbnVsbA0KPj4+ICsr
KyBiL3hlbi9hcmNoL2FybS9zY2kvS2NvbmZpZw0KPj4+IEBAIC0wLDAgKzEsMTAgQEANCj4+PiAr
Y29uZmlnIFNDTUlfU01DDQo+Pj4gKwlib29sICJFbmFibGUgU0NNSS1TTUMgbWVkaWF0b3IgZHJp
dmVyIg0KPj4+ICsJZGVmYXVsdCBuDQo+Pj4gKwlkZXBlbmRzIG9uIEFSTV9TQ0kgJiYgSE9TVF9E
VEJfRVhQT1JUDQo+Pj4gKwktLS1oZWxwLS0tDQo+Pj4gKw0KPj4+ICsJRW5hYmxlcyBtZWRpYXRv
ciBpbiBYRU4gdG8gcGFzcyBTQ01JIHJlcXVlc3RzIGZyb20gRG9tYWlucyB0byBBVEYuDQo+Pj4g
KwlUaGlzIGZlYXR1cmUgYWxsb3dzIGRyaXZlcnMgZnJvbSBEb21haW5zIHRvIHdvcmsgd2l0aCBT
eXN0ZW0NCj4+PiArCUNvbnRyb2xsZXJzIChzdWNoIGFzIHBvd2VyLHJlc2V0cyxjbG9jayBldGMu
KS4gU0NQIGlzIHVzZWQgYXMgdHJhbnNwb3J0DQo+Pj4gKwlmb3IgY29tbXVuaWNhdGlvbi4NCj4+
PiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL3NjaS9zY21pX3NtYy5jIGIveGVuL2FyY2gvYXJt
L3NjaS9zY21pX3NtYy5jDQo+Pj4gbmV3IGZpbGUgbW9kZSAxMDA2NDQNCj4+PiBpbmRleCAwMDAw
MDAwMDAwLi4xMDM1MjlkZmFiDQo+Pj4gLS0tIC9kZXYvbnVsbA0KPj4+ICsrKyBiL3hlbi9hcmNo
L2FybS9zY2kvc2NtaV9zbWMuYw0KPj4+IEBAIC0wLDAgKzEsOTU5IEBADQo+Pj4gKy8qDQo+Pj4g
KyAqIHhlbi9hcmNoL2FybS9zY2kvc2NtaV9zbWMuYw0KPj4+ICsgKg0KPj4+ICsgKiBTQ01JIG1l
ZGlhdG9yIGRyaXZlciwgdXNpbmcgU0NQIGFzIHRyYW5zcG9ydC4NCj4+PiArICoNCj4+PiArICog
T2xla3NpaSBNb2lzaWVpZXYgPG9sZWtzaWlfbW9pc2llaWV2QGVwYW0uY29tPg0KPj4+ICsgKiBD
b3B5cmlnaHQgKEMpIDIwMjEsIEVQQU0gU3lzdGVtcy4NCj4+PiArICoNCj4+PiArICogVGhpcyBw
cm9ncmFtIGlzIGZyZWUgc29mdHdhcmU7IHlvdSBjYW4gcmVkaXN0cmlidXRlIGl0IGFuZC9vciBt
b2RpZnkNCj4+PiArICogaXQgdW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJs
aWMgTGljZW5zZSBhcyBwdWJsaXNoZWQgYnkNCj4+PiArICogdGhlIEZyZWUgU29mdHdhcmUgRm91
bmRhdGlvbjsgZWl0aGVyIHZlcnNpb24gMiBvZiB0aGUgTGljZW5zZSwgb3INCj4+PiArICogKGF0
IHlvdXIgb3B0aW9uKSBhbnkgbGF0ZXIgdmVyc2lvbi4NCj4+PiArICoNCj4+PiArICogVGhpcyBw
cm9ncmFtIGlzIGRpc3RyaWJ1dGVkIGluIHRoZSBob3BlIHRoYXQgaXQgd2lsbCBiZSB1c2VmdWws
DQo+Pj4gKyAqIGJ1dCBXSVRIT1VUIEFOWSBXQVJSQU5UWTsgd2l0aG91dCBldmVuIHRoZSBpbXBs
aWVkIHdhcnJhbnR5IG9mDQo+Pj4gKyAqIE1FUkNIQU5UQUJJTElUWSBvciBGSVRORVNTIEZPUiBB
IFBBUlRJQ1VMQVIgUFVSUE9TRS4gIFNlZSB0aGUNCj4+PiArICogR05VIEdlbmVyYWwgUHVibGlj
IExpY2Vuc2UgZm9yIG1vcmUgZGV0YWlscy4NCj4+PiArICovDQo+Pj4gKw0KPj4+ICsjaW5jbHVk
ZSA8YXNtL3NjaS9zY2kuaD4NCj4+PiArI2luY2x1ZGUgPGFzbS9zbWNjYy5oPg0KPj4+ICsjaW5j
bHVkZSA8YXNtL2lvLmg+DQo+Pj4gKyNpbmNsdWRlIDx4ZW4vYml0b3BzLmg+DQo+Pj4gKyNpbmNs
dWRlIDx4ZW4vY29uZmlnLmg+DQo+Pj4gKyNpbmNsdWRlIDx4ZW4vc2NoZWQuaD4NCj4+PiArI2lu
Y2x1ZGUgPHhlbi9kZXZpY2VfdHJlZS5oPg0KPj4+ICsjaW5jbHVkZSA8eGVuL2lvY2FwLmg+DQo+
Pj4gKyNpbmNsdWRlIDx4ZW4vaW5pdC5oPg0KPj4+ICsjaW5jbHVkZSA8eGVuL2Vyci5oPg0KPj4+
ICsjaW5jbHVkZSA8eGVuL2xpYi5oPg0KPj4+ICsjaW5jbHVkZSA8eGVuL2xpc3QuaD4NCj4+PiAr
I2luY2x1ZGUgPHhlbi9tbS5oPg0KPj4+ICsjaW5jbHVkZSA8eGVuL3N0cmluZy5oPg0KPj4+ICsj
aW5jbHVkZSA8eGVuL3RpbWUuaD4NCj4+PiArI2luY2x1ZGUgPHhlbi92bWFwLmg+DQo+Pj4gKw0K
Pj4+ICsjZGVmaW5lIFNDTUlfQkFTRV9QUk9UT0NPTCAgICAgICAgICAgICAgICAgIDB4MTANCj4+
PiArI2RlZmluZSBTQ01JX0JBU0VfUFJPVE9DT0xfQVRUSUJVVEVTICAgICAgICAweDENCj4+PiAr
I2RlZmluZSBTQ01JX0JBU0VfU0VUX0RFVklDRV9QRVJNSVNTSU9OUyAgICAweDkNCj4+PiArI2Rl
ZmluZSBTQ01JX0JBU0VfUkVTRVRfQUdFTlRfQ09ORklHVVJBVElPTiAweEINCj4+PiArI2RlZmlu
ZSBTQ01JX0JBU0VfRElTQ09WRVJfQUdFTlQgICAgICAgICAgICAweDcNCj4+PiArDQo+Pj4gKy8q
IFNDTUkgcmV0dXJuIGNvZGVzLiBTZWUgc2VjdGlvbiA0LjEuNCBvZiBTQ01JIHNwZWMgKERFTjAw
NTZDKSAqLw0KPj4+ICsjZGVmaW5lIFNDTUlfU1VDQ0VTUyAgICAgICAgICAgICAgMA0KPj4+ICsj
ZGVmaW5lIFNDTUlfTk9UX1NVUFBPUlRFRCAgICAgICgtMSkNCj4+PiArI2RlZmluZSBTQ01JX0lO
VkFMSURfUEFSQU1FVEVSUyAoLTIpDQo+Pj4gKyNkZWZpbmUgU0NNSV9ERU5JRUQgICAgICAgICAg
ICAgKC0zKQ0KPj4+ICsjZGVmaW5lIFNDTUlfTk9UX0ZPVU5EICAgICAgICAgICgtNCkNCj4+PiAr
I2RlZmluZSBTQ01JX09VVF9PRl9SQU5HRSAgICAgICAoLTUpDQo+Pj4gKyNkZWZpbmUgU0NNSV9C
VVNZICAgICAgICAgICAgICAgKC02KQ0KPj4+ICsjZGVmaW5lIFNDTUlfQ09NTVNfRVJST1IgICAg
ICAgICgtNykNCj4+PiArI2RlZmluZSBTQ01JX0dFTkVSSUNfRVJST1IgICAgICAoLTgpDQo+Pj4g
KyNkZWZpbmUgU0NNSV9IQVJEV0FSRV9FUlJPUiAgICAgKC05KQ0KPj4+ICsjZGVmaW5lIFNDTUlf
UFJPVE9DT0xfRVJST1IgICAgICgtMTApDQo+Pj4gKw0KPj4+ICsjZGVmaW5lIERUX01BVENIX1ND
TUlfU01DIERUX01BVENIX0NPTVBBVElCTEUoImFybSxzY21pLXNtYyIpDQo+Pj4gKw0KPj4+ICsj
ZGVmaW5lIFNDTUlfU01DX0lEICAgICAgICAgICAgICAgICAgICAgICAgImFybSxzbWMtaWQiDQo+
Pj4gKyNkZWZpbmUgU0NNSV9TSEFSRURfTUVNT1JZICAgICAgICAgICAgICAgICAiYXJtLHNjbWkt
c2htZW0iDQo+Pj4gKyNkZWZpbmUgU0NNSV9TSE1FTSAgICAgICAgICAgICAgICAgICAgICAgICAi
c2htZW0iDQo+Pj4gKyNkZWZpbmUgU0NNSV9TSE1FTV9NQVBQRURfU0laRSAgICAgICAgICAgICBQ
QUdFX1NJWkUNCj4+PiArDQo+Pj4gKyNkZWZpbmUgSFlQX0NIQU5ORUwgICAgICAgICAgICAgICAg
ICAgICAgICAgIDB4MA0KPj4+ICsNCj4+PiArI2RlZmluZSBIRFJfSUQgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgIEdFTk1BU0soNywwKQ0KPj4+ICsjZGVmaW5lIEhEUl9UWVBFICAgICAgICAg
ICAgICAgICAgICAgICAgICAgR0VOTUFTSyg5LCA4KQ0KPj4+ICsjZGVmaW5lIEhEUl9QUk9UTyAg
ICAgICAgICAgICAgICAgICAgICAgICAgR0VOTUFTSygxNywgMTApDQo+Pj4gKw0KPj4+ICsvKiBT
Q01JIHByb3RvY29sLCByZWZlciB0byBzZWN0aW9uIDQuMi4yLjIgKERFTjAwNTZDKSAqLw0KPj4+
ICsjZGVmaW5lIE1TR19OX0FHRU5UU19NQVNLICAgICAgICAgICAgICAgICAgR0VOTUFTSygxNSwg
OCkNCj4+PiArDQo+Pj4gKyNkZWZpbmUgRklFTERfR0VUKF9tYXNrLCBfcmVnKVwNCj4+PiArICAg
ICgodHlwZW9mKF9tYXNrKSkoKChfcmVnKSAmIChfbWFzaykpID4+IChmZnM2NChfbWFzaykgLSAx
KSkpDQo+Pj4gKyNkZWZpbmUgRklFTERfUFJFUChfbWFzaywgX3ZhbClcDQo+Pj4gKyAgICAoKCh0
eXBlb2YoX21hc2spKShfdmFsKSA8PCAoZmZzNjQoX21hc2spIC0gMSkpICYgKF9tYXNrKSkNCj4+
PiArDQo+Pj4gK3R5cGVkZWYgc3RydWN0IHNjbWlfbXNnX2hlYWRlciB7DQo+Pj4gKyAgICB1aW50
OF90IGlkOw0KPj4+ICsgICAgdWludDhfdCB0eXBlOw0KPj4+ICsgICAgdWludDhfdCBwcm90b2Nv
bDsNCj4+PiArfSBzY21pX21zZ19oZWFkZXJfdDsNCj4+PiArDQo+Pj4gKyNkZWZpbmUgU0NNSV9T
SE1FTV9DSEFOX1NUQVRfQ0hBTk5FTF9GUkVFICAgQklUKDAsIFVMKQ0KPj4+ICsjZGVmaW5lIFND
TUlfU0hNRU1fQ0hBTl9TVEFUX0NIQU5ORUxfRVJST1IgIEJJVCgxLCBVTCkNCj4+PiArDQo+Pj4g
KyNkZWZpbmUgU0NNSV9BTExPV19BQ0NFU1MgICAgICAgICAgICAgICAgICAgQklUKDAsIFVMKQ0K
Pj4+ICsNCj4+PiArc3RydWN0IHNjbWlfc2hhcmVkX21lbSB7DQo+Pj4gKyAgICB1aW50MzJfdCBy
ZXNlcnZlZDsNCj4+PiArICAgIHVpbnQzMl90IGNoYW5uZWxfc3RhdHVzOw0KPj4+ICsgICAgdWlu
dDMyX3QgcmVzZXJ2ZWQxWzJdOw0KPj4+ICsgICAgdWludDMyX3QgZmxhZ3M7DQo+Pj4gKyAgICB1
aW50MzJfdCBsZW5ndGg7DQo+Pj4gKyAgICB1aW50MzJfdCBtc2dfaGVhZGVyOw0KPj4+ICsgICAg
dWludDhfdCBtc2dfcGF5bG9hZFtdOw0KPj4+ICt9Ow0KPj4+ICsNCj4+PiArc3RydWN0IGR0X2No
YW5uZWxfYWRkciB7DQo+Pj4gKyAgICB1NjQgYWRkcjsNCj4+PiArICAgIHU2NCBzaXplOw0KPj4+
ICsgICAgc3RydWN0IGxpc3RfaGVhZCBsaXN0Ow0KPj4+ICt9Ow0KPj4+ICsNCj4+PiArc3RydWN0
IHNjbWlfY2hhbm5lbCB7DQo+Pj4gKyAgICBpbnQgY2hhbl9pZDsNCj4+PiArICAgIGludCBhZ2Vu
dF9pZDsNCj4+PiArICAgIHVpbnQzMl90IGZ1bmNfaWQ7DQo+Pj4gKyAgICBkb21pZF90IGRvbWFp
bl9pZDsNCj4+PiArICAgIHVpbnQ2NF90IHBhZGRyOw0KPj4+ICsgICAgdWludDY0X3QgbGVuOw0K
Pj4+ICsgICAgc3RydWN0IHNjbWlfc2hhcmVkX21lbSAqc2htZW07DQo+Pj4gKyAgICBzcGlubG9j
a190IGxvY2s7DQo+Pj4gKyAgICBzdHJ1Y3QgbGlzdF9oZWFkIGxpc3Q7DQo+Pj4gK307DQo+Pj4g
Kw0KPj4+ICtzdHJ1Y3Qgc2NtaV9kYXRhIHsNCj4+PiArICAgIHN0cnVjdCBsaXN0X2hlYWQgY2hh
bm5lbF9saXN0Ow0KPj4+ICsgICAgc3BpbmxvY2tfdCBjaGFubmVsX2xpc3RfbG9jazsNCj4+PiAr
ICAgIGJvb2wgaW5pdGlhbGl6ZWQ7DQo+Pj4gK307DQo+Pj4gKw0KPj4+ICtzdGF0aWMgc3RydWN0
IHNjbWlfZGF0YSBzY21pX2RhdGE7DQo+Pj4gKw0KPj4+ICsNCj4+PiArLyoNCj4+PiArICogcGFj
a19zY21pX2hlYWRlcigpIC0gcGFja3MgYW5kIHJldHVybnMgMzItYml0IGhlYWRlcg0KPj4+ICsg
Kg0KPj4+ICsgKiBAaGRyOiBwb2ludGVyIHRvIGhlYWRlciBjb250YWluaW5nIGFsbCB0aGUgaW5m
b3JtYXRpb24gb24gbWVzc2FnZSBpZCwNCj4+PiArICogICAgcHJvdG9jb2wgaWQgYW5kIHR5cGUg
aWQuDQo+Pj4gKyAqDQo+Pj4gKyAqIFJldHVybjogMzItYml0IHBhY2tlZCBtZXNzYWdlIGhlYWRl
ciB0byBiZSBzZW50IHRvIHRoZSBwbGF0Zm9ybS4NCj4+PiArICovDQo+Pj4gK3N0YXRpYyBpbmxp
bmUgdWludDMyX3QgcGFja19zY21pX2hlYWRlcihzY21pX21zZ19oZWFkZXJfdCAqaGRyKQ0KPj4+
ICt7DQo+Pj4gKyAgICByZXR1cm4gRklFTERfUFJFUChIRFJfSUQsIGhkci0+aWQpIHwNCj4+PiAr
ICAgICAgICBGSUVMRF9QUkVQKEhEUl9UWVBFLCBoZHItPnR5cGUpIHwNCj4+PiArICAgICAgICBG
SUVMRF9QUkVQKEhEUl9QUk9UTywgaGRyLT5wcm90b2NvbCk7DQo+Pj4gK30NCj4+PiArDQo+Pj4g
Ky8qDQo+Pj4gKyAqIHVucGFja19zY21pX2hlYWRlcigpIC0gdW5wYWNrcyBhbmQgcmVjb3JkcyBt
ZXNzYWdlIGFuZCBwcm90b2NvbCBpZA0KPj4+ICsgKg0KPj4+ICsgKiBAbXNnX2hkcjogMzItYml0
IHBhY2tlZCBtZXNzYWdlIGhlYWRlciBzZW50IGZyb20gdGhlIHBsYXRmb3JtDQo+Pj4gKyAqIEBo
ZHI6IHBvaW50ZXIgdG8gaGVhZGVyIHRvIGZldGNoIG1lc3NhZ2UgYW5kIHByb3RvY29sIGlkLg0K
Pj4+ICsgKi8NCj4+PiArc3RhdGljIGlubGluZSB2b2lkIHVucGFja19zY21pX2hlYWRlcih1aW50
MzJfdCBtc2dfaGRyLCBzY21pX21zZ19oZWFkZXJfdCAqaGRyKQ0KPj4+ICt7DQo+Pj4gKyAgICBo
ZHItPmlkID0gRklFTERfR0VUKEhEUl9JRCwgbXNnX2hkcik7DQo+Pj4gKyAgICBoZHItPnR5cGUg
PSBGSUVMRF9HRVQoSERSX1RZUEUsIG1zZ19oZHIpOw0KPj4+ICsgICAgaGRyLT5wcm90b2NvbCA9
IEZJRUxEX0dFVChIRFJfUFJPVE8sIG1zZ19oZHIpOw0KPj4+ICt9DQo+Pj4gKw0KPj4+ICtzdGF0
aWMgaW5saW5lIGludCBjaGFubmVsX2lzX2ZyZWUoc3RydWN0IHNjbWlfY2hhbm5lbCAqY2hhbl9p
bmZvKQ0KPj4+ICt7DQo+Pj4gKyAgICByZXR1cm4gKCBjaGFuX2luZm8tPnNobWVtLT5jaGFubmVs
X3N0YXR1cw0KPj4+ICsgICAgICAgICAgICAmIFNDTUlfU0hNRU1fQ0hBTl9TVEFUX0NIQU5ORUxf
RlJFRSApID8gMCA6IC1FQlVTWTsNCj4+PiArfQ0KPj4+ICsNCj4+PiArLyoNCj4+PiArICogQ29w
eSBkYXRhIGZyb20gSU8gbWVtb3J5IHNwYWNlIHRvICJyZWFsIiBtZW1vcnkgc3BhY2UuDQo+Pj4g
KyAqLw0KPj4+ICt2b2lkIF9fbWVtY3B5X2Zyb21pbyh2b2lkICp0bywgY29uc3Qgdm9sYXRpbGUg
dm9pZCBfX2lvbWVtICpmcm9tLCBzaXplX3QgY291bnQpDQo+Pj4gK3sNCj4+PiArICAgIHdoaWxl
IChjb3VudCAmJiAhSVNfQUxJR05FRCgodW5zaWduZWQgbG9uZylmcm9tLCA0KSkgew0KPj4+ICsg
ICAgICAgICoodTggKil0byA9IF9fcmF3X3JlYWRiKGZyb20pOw0KPj4+ICsgICAgICAgIGZyb20r
KzsNCj4+PiArICAgICAgICB0bysrOw0KPj4+ICsgICAgICAgIGNvdW50LS07DQo+Pj4gKyAgICB9
DQo+Pj4gKw0KPj4+ICsgICAgd2hpbGUgKGNvdW50ID49IDQpIHsNCj4+PiArICAgICAgICAqKHUz
MiAqKXRvID0gX19yYXdfcmVhZGwoZnJvbSk7DQo+Pj4gKyAgICAgICAgZnJvbSArPSA0Ow0KPj4+
ICsgICAgICAgIHRvICs9IDQ7DQo+Pj4gKyAgICAgICAgY291bnQgLT0gNDsNCj4+PiArICAgIH0N
Cj4+PiArDQo+Pj4gKyAgICB3aGlsZSAoY291bnQpIHsNCj4+PiArICAgICAgICAqKHU4ICopdG8g
PSBfX3Jhd19yZWFkYihmcm9tKTsNCj4+PiArICAgICAgICBmcm9tKys7DQo+Pj4gKyAgICAgICAg
dG8rKzsNCj4+PiArICAgICAgICBjb3VudC0tOw0KPj4+ICsgICAgfQ0KPj4+ICt9DQo+Pj4gKw0K
Pj4+ICsvKg0KPj4+ICsgKiBDb3B5IGRhdGEgZnJvbSAicmVhbCIgbWVtb3J5IHNwYWNlIHRvIElP
IG1lbW9yeSBzcGFjZS4NCj4+PiArICovDQo+Pj4gK3ZvaWQgX19tZW1jcHlfdG9pbyh2b2xhdGls
ZSB2b2lkIF9faW9tZW0gKnRvLCBjb25zdCB2b2lkICpmcm9tLCBzaXplX3QgY291bnQpDQo+Pj4g
K3sNCj4+PiArICAgIHdoaWxlIChjb3VudCAmJiAhSVNfQUxJR05FRCgodW5zaWduZWQgbG9uZyl0
bywgNCkpIHsNCj4+PiArICAgICAgICBfX3Jhd193cml0ZWIoKih1OCAqKWZyb20sIHRvKTsNCj4+
PiArICAgICAgICBmcm9tKys7DQo+Pj4gKyAgICAgICAgdG8rKzsNCj4+PiArICAgICAgICBjb3Vu
dC0tOw0KPj4+ICsgICAgfQ0KPj4+ICsNCj4+PiArICAgIHdoaWxlIChjb3VudCA+PSA0KSB7DQo+
Pj4gKyAgICAgICAgX19yYXdfd3JpdGVsKCoodTMyICopZnJvbSwgdG8pOw0KPj4+ICsgICAgICAg
IGZyb20gKz0gNDsNCj4+PiArICAgICAgICB0byArPSA0Ow0KPj4+ICsgICAgICAgIGNvdW50IC09
IDQ7DQo+Pj4gKyAgICB9DQo+Pj4gKw0KPj4+ICsgICAgd2hpbGUgKGNvdW50KSB7DQo+Pj4gKyAg
ICAgICAgX19yYXdfd3JpdGViKCoodTggKilmcm9tLCB0byk7DQo+Pj4gKyAgICAgICAgZnJvbSsr
Ow0KPj4+ICsgICAgICAgIHRvKys7DQo+Pj4gKyAgICAgICAgY291bnQtLTsNCj4+PiArICAgIH0N
Cj4+PiArfQ0KPj4+ICsNCj4+PiArc3RhdGljIGludCBzZW5kX3NtY19tZXNzYWdlKHN0cnVjdCBz
Y21pX2NoYW5uZWwgKmNoYW5faW5mbywNCj4+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAg
IHNjbWlfbXNnX2hlYWRlcl90ICpoZHIsIHZvaWQgKmRhdGEsIGludCBsZW4pDQo+Pj4gK3sNCj4+
PiArICAgIHN0cnVjdCBhcm1fc21jY2NfcmVzIHJlc3A7DQo+Pj4gKyAgICBpbnQgcmV0Ow0KPj4+
ICsNCj4+PiArICAgIGlmICggKGxlbiArIHNpemVvZihjaGFuX2luZm8tPnNobWVtLT5tc2dfaGVh
ZGVyKSkgPg0KPj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgU0NNSV9TSE1FTV9NQVBQRURf
U0laRSApDQo+Pj4gKyAgICB7DQo+Pj4gKyAgICAgICAgcHJpbnRrKFhFTkxPR19FUlINCj4+PiAr
ICAgICAgICAgICAgICAgInNjbWk6IFdyb25nIHNpemUgb2Ygc21jIG1lc3NhZ2UuIERhdGEgaXMg
aW52YWxpZFxuIik7DQo+Pj4gKyAgICAgICAgcmV0dXJuIC1FSU5WQUw7DQo+Pj4gKyAgICB9DQo+
Pj4gKw0KPj4+ICsgICAgcHJpbnRrKFhFTkxPR19ERUJVRyAic2NtaTogc3RhdHVzID0lZCBsZW49
JWRcbiIsDQo+Pj4gKyAgICAgICAgICAgY2hhbl9pbmZvLT5zaG1lbS0+Y2hhbm5lbF9zdGF0dXMs
IGxlbik7DQo+Pj4gKyAgICBwcmludGsoWEVOTE9HX0RFQlVHICJzY21pOiBoZWFkZXIgaWQgPSAl
ZCB0eXBlID0gJWQsIHByb3RvID0gJWRcbiIsDQo+Pj4gKyAgICAgICAgICAgaGRyLT5pZCwgaGRy
LT50eXBlLCBoZHItPnByb3RvY29sKTsNCj4+PiArDQo+Pj4gKyAgICByZXQgPSBjaGFubmVsX2lz
X2ZyZWUoY2hhbl9pbmZvKTsNCj4+PiArICAgIGlmICggSVNfRVJSX1ZBTFVFKHJldCkgKQ0KPj4+
ICsgICAgICAgIHJldHVybiByZXQ7DQo+Pj4gKw0KPj4+ICsgICAgY2hhbl9pbmZvLT5zaG1lbS0+
Y2hhbm5lbF9zdGF0dXMgPSAweDA7DQo+Pj4gKyAgICAvKiBXcml0aW5nIDB4MCByaWdodCBub3cs
IGJ1dCBTQ01JX1NITUVNX0ZMQUdfSU5UUl9FTkFCTEVEIGNhbiBiZSBzZXQgKi8NCj4+PiArICAg
IGNoYW5faW5mby0+c2htZW0tPmZsYWdzID0gMHgwOw0KPj4+ICsgICAgY2hhbl9pbmZvLT5zaG1l
bS0+bGVuZ3RoID0gc2l6ZW9mKGNoYW5faW5mby0+c2htZW0tPm1zZ19oZWFkZXIpICsgbGVuOw0K
Pj4+ICsgICAgY2hhbl9pbmZvLT5zaG1lbS0+bXNnX2hlYWRlciA9IHBhY2tfc2NtaV9oZWFkZXIo
aGRyKTsNCj4+PiArDQo+Pj4gKyAgICBwcmludGsoWEVOTE9HX0RFQlVHICJzY21pOiBXcml0aW5n
IHRvIHNobWVtIGFkZHJlc3MgJXBcbiIsDQo+Pj4gKyAgICAgICAgICAgY2hhbl9pbmZvLT5zaG1l
bSk7DQo+Pj4gKyAgICBpZiAoIGxlbiA+IDAgJiYgZGF0YSApDQo+Pj4gKyAgICAgICAgX19tZW1j
cHlfdG9pbygodm9pZCAqKShjaGFuX2luZm8tPnNobWVtLT5tc2dfcGF5bG9hZCksIGRhdGEsIGxl
bik7DQo+Pj4gKw0KPj4+ICsgICAgYXJtX3NtY2NjX3NtYyhjaGFuX2luZm8tPmZ1bmNfaWQsIDAs
IDAsIDAsIDAsIDAsIDAsIGNoYW5faW5mby0+Y2hhbl9pZCwNCj4+PiArICAgICAgICAgICAgICAg
ICAgJnJlc3ApOw0KPj4+ICsNCj4+PiArICAgIHByaW50ayhYRU5MT0dfREVCVUcgInNjbWk6IHNj
bWNjY19zbWMgcmVzcG9uc2UgJWRcbiIsIChpbnQpKHJlc3AuYTApKTsNCj4+PiArDQo+Pj4gKyAg
ICBpZiAoIHJlc3AuYTAgKQ0KPj4+ICsgICAgICAgIHJldHVybiAtRU9QTk9UU1VQUDsNCj4+PiAr
DQo+Pj4gKyAgICByZXR1cm4gMDsNCj4+PiArfQ0KPj4+ICsNCj4+PiArc3RhdGljIGludCBjaGVj
a19zY21pX3N0YXR1cyhpbnQgc2NtaV9zdGF0dXMpDQo+Pj4gK3sNCj4+PiArICAgIGlmICggc2Nt
aV9zdGF0dXMgPT0gU0NNSV9TVUNDRVNTICkNCj4+PiArICAgICAgICByZXR1cm4gMDsNCj4+PiAr
DQo+Pj4gKyAgICBwcmludGsoWEVOTE9HX0RFQlVHICJzY21pOiBFcnJvciByZWNlaXZlZDogJWRc
biIsIHNjbWlfc3RhdHVzKTsNCj4+PiArDQo+Pj4gKyAgICBzd2l0Y2ggKCBzY21pX3N0YXR1cyAp
DQo+Pj4gKyAgICB7DQo+Pj4gKyAgICBjYXNlIFNDTUlfTk9UX1NVUFBPUlRFRDoNCj4+PiArICAg
ICAgICByZXR1cm4gLUVPUE5PVFNVUFA7DQo+Pj4gKyAgICBjYXNlIFNDTUlfSU5WQUxJRF9QQVJB
TUVURVJTOg0KPj4+ICsgICAgICAgIHJldHVybiAtRUlOVkFMOw0KPj4+ICsgICAgY2FzZSBTQ01J
X0RFTklFRDoNCj4+PiArICAgICAgICByZXR1cm4gLUVBQ0NFUzsNCj4+PiArICAgIGNhc2UgU0NN
SV9OT1RfRk9VTkQ6DQo+Pj4gKyAgICAgICAgcmV0dXJuIC1FTk9FTlQ7DQo+Pj4gKyAgICBjYXNl
IFNDTUlfT1VUX09GX1JBTkdFOg0KPj4+ICsgICAgICAgIHJldHVybiAtRVJBTkdFOw0KPj4+ICsg
ICAgY2FzZSBTQ01JX0JVU1k6DQo+Pj4gKyAgICAgICAgcmV0dXJuIC1FQlVTWTsNCj4+PiArICAg
IGNhc2UgU0NNSV9DT01NU19FUlJPUjoNCj4+PiArICAgICAgICByZXR1cm4gLUVOT1RDT05OOw0K
Pj4+ICsgICAgY2FzZSBTQ01JX0dFTkVSSUNfRVJST1I6DQo+Pj4gKyAgICAgICAgcmV0dXJuIC1F
SU87DQo+Pj4gKyAgICBjYXNlIFNDTUlfSEFSRFdBUkVfRVJST1I6DQo+Pj4gKyAgICAgICAgcmV0
dXJuIC1FTlhJTzsNCj4+PiArICAgIGNhc2UgU0NNSV9QUk9UT0NPTF9FUlJPUjoNCj4+PiArICAg
ICAgICByZXR1cm4gLUVCQURNU0c7DQo+Pj4gKyAgICBkZWZhdWx0Og0KPj4+ICsgICAgICAgIHJl
dHVybiAtRUlOVkFMOw0KPj4+ICsgICAgfQ0KPj4+ICt9DQo+Pj4gKw0KPj4+ICtzdGF0aWMgaW50
IGdldF9zbWNfcmVzcG9uc2Uoc3RydWN0IHNjbWlfY2hhbm5lbCAqY2hhbl9pbmZvLA0KPj4+ICsg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgc2NtaV9tc2dfaGVhZGVyX3QgKmhkciwgdm9pZCAq
ZGF0YSwgaW50IGxlbikNCj4+PiArew0KPj4+ICsgICAgaW50IHJlY3ZfbGVuOw0KPj4+ICsgICAg
aW50IHJldDsNCj4+PiArDQo+Pj4gKyAgICBwcmludGsoWEVOTE9HX0RFQlVHICJzY21pOiBnZXQg
c21jIHJlc3BvbmNlIG1zZ2lkICVkXG4iLCBoZHItPmlkKTsNCj4+PiArDQo+Pj4gKyAgICBpZiAo
IGxlbiA+PSBTQ01JX1NITUVNX01BUFBFRF9TSVpFIC0gc2l6ZW9mKGNoYW5faW5mby0+c2htZW0p
ICkNCj4+PiArICAgIHsNCj4+PiArICAgICAgICBwcmludGsoWEVOTE9HX0VSUg0KPj4+ICsgICAg
ICAgICAgICAgICAic2NtaTogV3Jvbmcgc2l6ZSBvZiBpbnB1dCBzbWMgbWVzc2FnZS4gRGF0YSBt
YXkgYmUgaW52YWxpZFxuIik7DQo+Pj4gKyAgICAgICAgcmV0dXJuIC1FSU5WQUw7DQo+Pj4gKyAg
ICB9DQo+Pj4gKw0KPj4+ICsgICAgcmV0ID0gY2hhbm5lbF9pc19mcmVlKGNoYW5faW5mbyk7DQo+
Pj4gKyAgICBpZiAoIElTX0VSUl9WQUxVRShyZXQpICkNCj4+PiArICAgICAgICByZXR1cm4gcmV0
Ow0KPj4+ICsNCj4+PiArICAgIHJlY3ZfbGVuID0gY2hhbl9pbmZvLT5zaG1lbS0+bGVuZ3RoIC0g
c2l6ZW9mKGNoYW5faW5mby0+c2htZW0tPm1zZ19oZWFkZXIpOw0KPj4+ICsNCj4+PiArICAgIGlm
ICggcmVjdl9sZW4gPCAwICkNCj4+PiArICAgIHsNCj4+PiArICAgICAgICBwcmludGsoWEVOTE9H
X0VSUg0KPj4+ICsgICAgICAgICAgICAgICAic2NtaTogV3Jvbmcgc2l6ZSBvZiBzbWMgbWVzc2Fn
ZS4gRGF0YSBtYXkgYmUgaW52YWxpZFxuIik7DQo+Pj4gKyAgICAgICAgcmV0dXJuIC1FSU5WQUw7
DQo+Pj4gKyAgICB9DQo+Pj4gKw0KPj4+ICsgICAgaWYgKCByZWN2X2xlbiA+IGxlbiApDQo+Pj4g
KyAgICB7DQo+Pj4gKyAgICAgICAgcHJpbnRrKFhFTkxPR19FUlINCj4+PiArICAgICAgICAgICAg
ICAgInNjbWk6IE5vdCBlbm91Z2ggYnVmZmVyIGZvciBtZXNzYWdlICVkLCBleHBlY3RpbmcgJWRc
biIsDQo+Pj4gKyAgICAgICAgICAgICAgIHJlY3ZfbGVuLCBsZW4pOw0KPj4+ICsgICAgICAgIHJl
dHVybiAtRUlOVkFMOw0KPj4+ICsgICAgfQ0KPj4+ICsNCj4+PiArICAgIHVucGFja19zY21pX2hl
YWRlcihjaGFuX2luZm8tPnNobWVtLT5tc2dfaGVhZGVyLCBoZHIpOw0KPj4+ICsNCj4+PiArICAg
IGlmICggcmVjdl9sZW4gPiAwICkNCj4+PiArICAgIHsNCj4+PiArICAgICAgICBfX21lbWNweV9m
cm9taW8oZGF0YSwgY2hhbl9pbmZvLT5zaG1lbS0+bXNnX3BheWxvYWQsIHJlY3ZfbGVuKTsNCj4+
PiArICAgIH0NCj4+PiArDQo+Pj4gKyAgICByZXR1cm4gMDsNCj4+PiArfQ0KPj4+ICsNCj4+PiAr
c3RhdGljIGludCBkb19zbWNfeGZlcihzdHJ1Y3Qgc2NtaV9jaGFubmVsICpjaGFubmVsLCBzY21p
X21zZ19oZWFkZXJfdCAqaGRyLCB2b2lkICp0eF9kYXRhLCBpbnQgdHhfc2l6ZSwNCj4+PiArICAg
ICAgICAgICAgICAgICAgICAgICB2b2lkICpyeF9kYXRhLCBpbnQgcnhfc2l6ZSkNCj4+PiArew0K
Pj4+ICsgICAgaW50IHJldCA9IDA7DQo+Pj4gKw0KPj4+ICsgICAgQVNTRVJUKCBjaGFubmVsICYm
IGNoYW5uZWwtPnNobWVtKTsNCj4+PiArDQo+Pj4gKyAgICBpZiAoICFoZHIgKQ0KPj4+ICsgICAg
ICAgIHJldHVybiAtRUlOVkFMOw0KPj4+ICsNCj4+PiArICAgIHNwaW5fbG9jaygmY2hhbm5lbC0+
bG9jayk7DQo+Pj4gKw0KPj4+ICsgICAgcmV0ID0gc2VuZF9zbWNfbWVzc2FnZShjaGFubmVsLCBo
ZHIsIHR4X2RhdGEsIHR4X3NpemUpOw0KPj4+ICsgICAgaWYgKCByZXQgKQ0KPj4+ICsgICAgICAg
IGdvdG8gY2xlYW47DQo+Pj4gKw0KPj4+ICsgICAgcmV0ID0gZ2V0X3NtY19yZXNwb25zZShjaGFu
bmVsLCBoZHIsIHJ4X2RhdGEsIHJ4X3NpemUpOw0KPj4+ICtjbGVhbjoNCj4+PiArICAgIHNwaW5f
dW5sb2NrKCZjaGFubmVsLT5sb2NrKTsNCj4+PiArDQo+Pj4gKyAgICByZXR1cm4gcmV0Ow0KPj4+
ICt9DQo+Pj4gKw0KPj4+ICtzdGF0aWMgc3RydWN0IHNjbWlfY2hhbm5lbCAqZ2V0X2NoYW5uZWxf
YnlfaWQodWludDhfdCBjaGFuX2lkKQ0KPj4+ICt7DQo+Pj4gKyAgICBzdHJ1Y3Qgc2NtaV9jaGFu
bmVsICpjdXJyOw0KPj4+ICsgICAgYm9vbCBmb3VuZCA9IGZhbHNlOw0KPj4+ICsNCj4+PiArICAg
IHNwaW5fbG9jaygmc2NtaV9kYXRhLmNoYW5uZWxfbGlzdF9sb2NrKTsNCj4+PiArICAgIGxpc3Rf
Zm9yX2VhY2hfZW50cnkoY3VyciwgJnNjbWlfZGF0YS5jaGFubmVsX2xpc3QsIGxpc3QpDQo+Pj4g
KyAgICB7DQo+Pj4gKyAgICAgICAgaWYgKCBjdXJyLT5jaGFuX2lkID09IGNoYW5faWQgKQ0KPj4+
ICsgICAgICAgIHsNCj4+PiArICAgICAgICAgICAgZm91bmQgPSB0cnVlOw0KPj4+ICsgICAgICAg
ICAgICBicmVhazsNCj4+PiArICAgICAgICB9DQo+Pj4gKyAgICB9DQo+Pj4gKw0KPj4+ICsgICAg
c3Bpbl91bmxvY2soJnNjbWlfZGF0YS5jaGFubmVsX2xpc3RfbG9jayk7DQo+Pj4gKyAgICBpZiAo
IGZvdW5kICkNCj4+PiArICAgICAgICByZXR1cm4gY3VycjsNCj4+PiArDQo+Pj4gKyAgICByZXR1
cm4gTlVMTDsNCj4+PiArfQ0KPj4+ICsNCj4+PiArc3RhdGljIHN0cnVjdCBzY21pX2NoYW5uZWwg
KmFxdWlyZV9zY21pX2NoYW5uZWwoZG9taWRfdCBkb21haW5faWQpDQo+Pj4gK3sNCj4+PiArICAg
IHN0cnVjdCBzY21pX2NoYW5uZWwgKmN1cnI7DQo+Pj4gKyAgICBib29sIGZvdW5kID0gZmFsc2U7
DQo+Pj4gKw0KPj4+ICsgICAgQVNTRVJUKGRvbWFpbl9pZCAhPSBET01JRF9JTlZBTElEICYmIGRv
bWFpbl9pZCA+PSAwKTsNCj4+PiArDQo+Pj4gKyAgICBzcGluX2xvY2soJnNjbWlfZGF0YS5jaGFu
bmVsX2xpc3RfbG9jayk7DQo+Pj4gKyAgICBsaXN0X2Zvcl9lYWNoX2VudHJ5KGN1cnIsICZzY21p
X2RhdGEuY2hhbm5lbF9saXN0LCBsaXN0KQ0KPj4+ICsgICAgew0KPj4+ICsgICAgICAgIGlmICgg
Y3Vyci0+ZG9tYWluX2lkID09IERPTUlEX0lOVkFMSUQgKQ0KPj4+ICsgICAgICAgIHsNCj4+PiAr
ICAgICAgICAgICAgY3Vyci0+ZG9tYWluX2lkID0gZG9tYWluX2lkOw0KPj4+ICsgICAgICAgICAg
ICBmb3VuZCA9IHRydWU7DQo+Pj4gKyAgICAgICAgICAgIGJyZWFrOw0KPj4+ICsgICAgICAgIH0N
Cj4+PiArICAgIH0NCj4+PiArDQo+Pj4gKyAgICBzcGluX3VubG9jaygmc2NtaV9kYXRhLmNoYW5u
ZWxfbGlzdF9sb2NrKTsNCj4+PiArICAgIGlmICggZm91bmQgKQ0KPj4+ICsgICAgICAgIHJldHVy
biBjdXJyOw0KPj4+ICsNCj4+PiArICAgIHJldHVybiBOVUxMOw0KPj4+ICt9DQo+Pj4gKw0KPj4+
ICtzdGF0aWMgdm9pZCByZWxpbnF1aXNoX3NjbWlfY2hhbm5lbChzdHJ1Y3Qgc2NtaV9jaGFubmVs
ICpjaGFubmVsKQ0KPj4+ICt7DQo+Pj4gKyAgICBBU1NFUlQoY2hhbm5lbCAhPSBOVUxMKTsNCj4+
PiArDQo+Pj4gKyAgICBzcGluX2xvY2soJnNjbWlfZGF0YS5jaGFubmVsX2xpc3RfbG9jayk7DQo+
Pj4gKyAgICBjaGFubmVsLT5kb21haW5faWQgPSBET01JRF9JTlZBTElEOw0KPj4+ICsgICAgc3Bp
bl91bmxvY2soJnNjbWlfZGF0YS5jaGFubmVsX2xpc3RfbG9jayk7DQo+Pj4gK30NCj4+PiArDQo+
Pj4gK3N0YXRpYyBpbnQgbWFwX2NoYW5uZWxfbWVtb3J5KHN0cnVjdCBzY21pX2NoYW5uZWwgKmNo
YW5uZWwpDQo+Pj4gK3sNCj4+PiArICAgIEFTU0VSVCggY2hhbm5lbCAmJiBjaGFubmVsLT5wYWRk
ciApOw0KPj4+ICsgICAgY2hhbm5lbC0+c2htZW0gPSBpb3JlbWFwX2NhY2hlKGNoYW5uZWwtPnBh
ZGRyLCBTQ01JX1NITUVNX01BUFBFRF9TSVpFKTsNCj4+PiArICAgIGlmICggIWNoYW5uZWwtPnNo
bWVtICkNCj4+PiArICAgICAgICByZXR1cm4gLUVOT01FTTsNCj4+PiArDQo+Pj4gKyAgICBjaGFu
bmVsLT5zaG1lbS0+Y2hhbm5lbF9zdGF0dXMgPSBTQ01JX1NITUVNX0NIQU5fU1RBVF9DSEFOTkVM
X0ZSRUU7DQo+Pj4gKyAgICBwcmludGsoWEVOTE9HX0RFQlVHICJzY21pOiBHb3Qgc2htZW0gYWZ0
ZXIgdm1hcCAlcFxuIiwgY2hhbm5lbC0+c2htZW0pOw0KPj4+ICsgICAgcmV0dXJuIDA7DQo+Pj4g
K30NCj4+PiArDQo+Pj4gK3N0YXRpYyB2b2lkIHVubWFwX2NoYW5uZWxfbWVtb3J5KHN0cnVjdCBz
Y21pX2NoYW5uZWwgKmNoYW5uZWwpDQo+Pj4gK3sNCj4+PiArICAgIEFTU0VSVCggY2hhbm5lbCAm
JiBjaGFubmVsLT5zaG1lbSApOw0KPj4+ICsgICAgaW91bm1hcChjaGFubmVsLT5zaG1lbSk7DQo+
Pj4gKyAgICBjaGFubmVsLT5zaG1lbSA9IE5VTEw7DQo+Pj4gK30NCj4+PiArDQo+Pj4gK3N0YXRp
YyBzdHJ1Y3Qgc2NtaV9jaGFubmVsICpzbWNfY3JlYXRlX2NoYW5uZWwodWludDhfdCBjaGFuX2lk
LA0KPj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVp
bnQzMl90IGZ1bmNfaWQsIHVpbnQ2NF90IGFkZHIpDQo+Pj4gK3sNCj4+PiArICAgIHN0cnVjdCBz
Y21pX2NoYW5uZWwgKmNoYW5uZWw7DQo+Pj4gKw0KPj4+ICsgICAgY2hhbm5lbCA9IGdldF9jaGFu
bmVsX2J5X2lkKGNoYW5faWQpOw0KPj4+ICsgICAgaWYgKCBjaGFubmVsICkNCj4+PiArICAgICAg
ICByZXR1cm4gRVJSX1BUUihFRVhJU1QpOw0KPj4+ICsNCj4+PiArICAgIGNoYW5uZWwgPSB4bWFs
bG9jKHN0cnVjdCBzY21pX2NoYW5uZWwpOw0KPj4+ICsgICAgaWYgKCAhY2hhbm5lbCApDQo+Pj4g
KyAgICAgICAgcmV0dXJuIEVSUl9QVFIoRU5PTUVNKTsNCj4+PiArDQo+Pj4gKyAgICBjaGFubmVs
LT5jaGFuX2lkID0gY2hhbl9pZDsNCj4+PiArICAgIGNoYW5uZWwtPmZ1bmNfaWQgPSBmdW5jX2lk
Ow0KPj4+ICsgICAgY2hhbm5lbC0+ZG9tYWluX2lkID0gRE9NSURfSU5WQUxJRDsNCj4+PiArICAg
IGNoYW5uZWwtPnNobWVtID0gTlVMTDsNCj4+PiArICAgIGNoYW5uZWwtPnBhZGRyID0gYWRkcjsN
Cj4+PiArICAgIHNwaW5fbG9ja19pbml0KCZjaGFubmVsLT5sb2NrKTsNCj4+PiArICAgIHNwaW5f
bG9jaygmc2NtaV9kYXRhLmNoYW5uZWxfbGlzdF9sb2NrKTsNCj4+PiArICAgIGxpc3RfYWRkKCZj
aGFubmVsLT5saXN0LCAmc2NtaV9kYXRhLmNoYW5uZWxfbGlzdCk7DQo+Pj4gKyAgICBzcGluX3Vu
bG9jaygmc2NtaV9kYXRhLmNoYW5uZWxfbGlzdF9sb2NrKTsNCj4+PiArICAgIHJldHVybiBjaGFu
bmVsOw0KPj4+ICt9DQo+Pj4gKw0KPj4+ICtzdGF0aWMgaW50IG1lbV9wZXJtaXRfYWNjZXNzKHN0
cnVjdCBkb21haW4gKmQsIHVpbnQ2NF90IGFkZHIsIHVpbnQ2NF90IGxlbikNCj4+PiArew0KPj4+
ICsgICAgcmV0dXJuIGlvbWVtX3Blcm1pdF9hY2Nlc3MoZCwgcGFkZHJfdG9fcGZuKGFkZHIpLA0K
Pj4+ICsgICAgICAgICAgICAgICAgcGFkZHJfdG9fcGZuKFBBR0VfQUxJR04oYWRkciArIGxlbiAt
MSkpKTsNCj4+PiArfQ0KPj4+ICsNCj4+PiArc3RhdGljIGludCBtZW1fZGVueV9hY2Nlc3Moc3Ry
dWN0IGRvbWFpbiAqZCwgdWludDY0X3QgYWRkciwNCj4+PiArICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgIHVpbnQ2NF90IGxlbikNCj4+PiArew0KPj4+ICsgICAgcmV0dXJuIGlv
bWVtX2RlbnlfYWNjZXNzKGQsIHBhZGRyX3RvX3BmbihhZGRyKSwNCj4+PiArICAgICAgICAgICAg
ICAgIHBhZGRyX3RvX3BmbihQQUdFX0FMSUdOKGFkZHIgKyBsZW4gLTEpKSk7DQo+Pj4gK30NCj4+
PiArDQo+Pj4gK3N0YXRpYyBpbnQgZHRfdXBkYXRlX2RvbWFpbl9yYW5nZSh1aW50NjRfdCBhZGRy
LCB1aW50NjRfdCBzaXplKQ0KPj4+ICt7DQo+Pj4gKyAgICBzdHJ1Y3QgZHRfZGV2aWNlX25vZGUg
KnNobWVtX25vZGU7DQo+Pj4gKyAgICBfX2JlMzIgKmh3X3JlZzsNCj4+PiArICAgIGNvbnN0IHN0
cnVjdCBkdF9wcm9wZXJ0eSAqcHA7DQo+Pj4gKyAgICB1aW50MzJfdCBsZW47DQo+Pj4gKw0KPj4+
ICsgICAgc2htZW1fbm9kZSA9IGR0X2ZpbmRfY29tcGF0aWJsZV9ub2RlKE5VTEwsIE5VTEwsIFND
TUlfU0hBUkVEX01FTU9SWSk7DQo+Pj4gKyAgICBpZiAoICFzaG1lbV9ub2RlICkNCj4+PiArICAg
IHsNCj4+PiArICAgICAgICBwcmludGsoWEVOTE9HX0VSUiAic2NtaTogVW5hYmxlIHRvIGZpbmQg
JXMgbm9kZSBpbiBEVFxuIiwgU0NNSV9TSE1FTSk7DQo+Pj4gKyAgICAgICAgcmV0dXJuIC1FSU5W
QUw7DQo+Pj4gKyAgICB9DQo+Pj4gKw0KPj4+ICsgICAgcHAgPSBkdF9maW5kX3Byb3BlcnR5KHNo
bWVtX25vZGUsICJyZWciLCAmbGVuKTsNCj4+PiArICAgIGlmICggIXBwICkNCj4+PiArICAgIHsN
Cj4+PiArICAgICAgICBwcmludGsoWEVOTE9HX0VSUiAic2NtaTogVW5hYmxlIHRvIGZpbmQgcmVn
cyBlbnRyeSBpbiBzaG1lbSBub2RlXG4iKTsNCj4+PiArICAgICAgICByZXR1cm4gLUVOT0VOVDsN
Cj4+PiArICAgIH0NCj4+PiArDQo+Pj4gKyAgICBod19yZWcgPSBwcC0+dmFsdWU7DQo+Pj4gKyAg
ICBkdF9zZXRfcmFuZ2UoJmh3X3JlZywgc2htZW1fbm9kZSwgYWRkciwgc2l6ZSk7DQo+Pj4gKw0K
Pj4+ICsgICAgcmV0dXJuIDA7DQo+Pj4gK30NCj4+PiArDQo+Pj4gK3N0YXRpYyB2b2lkIGZyZWVf
Y2hhbm5lbF9saXN0KHZvaWQpDQo+Pj4gK3sNCj4+PiArICAgIHN0cnVjdCBzY21pX2NoYW5uZWwg
KmN1cnIsICpfY3VycjsNCj4+PiArDQo+Pj4gKyAgICBzcGluX2xvY2soJnNjbWlfZGF0YS5jaGFu
bmVsX2xpc3RfbG9jayk7DQo+Pj4gKyAgICBsaXN0X2Zvcl9lYWNoX2VudHJ5X3NhZmUgKGN1cnIs
IF9jdXJyLCAmc2NtaV9kYXRhLmNoYW5uZWxfbGlzdCwgbGlzdCkNCj4+PiArICAgIHsNCj4+PiAr
ICAgICAgICBsaXN0X2RlbCgmY3Vyci0+bGlzdCk7DQo+Pj4gKyAgICAgICAgeGZyZWUoY3Vycik7
DQo+Pj4gKyAgICB9DQo+Pj4gKw0KPj4+ICsgICAgc3Bpbl91bmxvY2soJnNjbWlfZGF0YS5jaGFu
bmVsX2xpc3RfbG9jayk7DQo+Pj4gK30NCj4+PiArDQo+Pj4gK3N0YXRpYyBzdHJ1Y3QgZHRfZGV2
aWNlX25vZGUgKmdldF9kdF9ub2RlX2Zyb21fcHJvcGVydHkoDQo+Pj4gKyAgICAgICAgICAgICAg
ICBzdHJ1Y3QgZHRfZGV2aWNlX25vZGUgKm5vZGUsIGNvbnN0IGNoYXIgKiBwX25hbWUpDQo+Pj4g
K3sNCj4+PiArICAgIGNvbnN0IF9fYmUzMiAqcHJvcDsNCj4+PiArDQo+Pj4gKyAgICBBU1NFUlQo
IG5vZGUgKTsNCj4+PiArDQo+Pj4gKyAgICBwcm9wID0gZHRfZ2V0X3Byb3BlcnR5KG5vZGUsIHBf
bmFtZSwgTlVMTCk7DQo+Pj4gKyAgICBpZiAoICFwcm9wICkNCj4+PiArICAgICAgICByZXR1cm4g
RVJSX1BUUigtRUlOVkFMKTsNCj4+PiArDQo+Pj4gKyAgICByZXR1cm4gZHRfZmluZF9ub2RlX2J5
X3BoYW5kbGUoYmUzMl90b19jcHVwKHByb3ApKTsNCj4+PiArfQ0KPj4+ICsNCj4+PiArc3RhdGlj
IGludCBnZXRfc2htZW1fcmVnaW9ucyhzdHJ1Y3QgbGlzdF9oZWFkICpoZWFkLCB1NjQgaHlwX2Fk
ZHIpDQo+Pj4gK3sNCj4+PiArICAgIHN0cnVjdCBkdF9kZXZpY2Vfbm9kZSAqbm9kZTsNCj4+PiAr
ICAgIGludCByZXQ7DQo+Pj4gKyAgICBzdHJ1Y3QgZHRfY2hhbm5lbF9hZGRyICpsY2hhbjsNCj4+
PiArICAgIHU2NCBsYWRkciwgbHNpemU7DQo+Pj4gKw0KPj4+ICsgICAgbm9kZSA9IGR0X2ZpbmRf
Y29tcGF0aWJsZV9ub2RlKE5VTEwsIE5VTEwsIFNDTUlfU0hBUkVEX01FTU9SWSk7DQo+Pj4gKyAg
ICBpZiAoICFub2RlICkNCj4+PiArICAgICAgICByZXR1cm4gLUVOT0VOVDsNCj4+PiArDQo+Pj4g
KyAgICB3aGlsZSAoIG5vZGUgKQ0KPj4+ICsgICAgew0KPj4+ICsgICAgICAgIHJldCA9IGR0X2Rl
dmljZV9nZXRfYWRkcmVzcyhub2RlLCAwLCAmbGFkZHIsICZsc2l6ZSk7DQo+Pj4gKyAgICAgICAg
aWYgKCByZXQgKQ0KPj4+ICsgICAgICAgICAgICByZXR1cm4gcmV0Ow0KPj4+ICsNCj4+PiArICAg
ICAgICBpZiAoIGxhZGRyICE9IGh5cF9hZGRyICkNCj4+PiArICAgICAgICB7DQo+Pj4gKyAgICAg
ICAgICAgIGxjaGFuID0geG1hbGxvYyhzdHJ1Y3QgZHRfY2hhbm5lbF9hZGRyKTsNCj4+PiArICAg
ICAgICAgICAgaWYgKCAhbGNoYW4gKQ0KPj4+ICsgICAgICAgICAgICAgICAgcmV0dXJuIC1FTk9N
RU07DQo+Pj4gKyAgICAgICAgICAgIGxjaGFuLT5hZGRyID0gbGFkZHI7DQo+Pj4gKyAgICAgICAg
ICAgIGxjaGFuLT5zaXplID0gbHNpemU7DQo+Pj4gKw0KPj4+ICsgICAgICAgICAgICBsaXN0X2Fk
ZF90YWlsKCZsY2hhbi0+bGlzdCwgaGVhZCk7DQo+Pj4gKyAgICAgICAgfQ0KPj4+ICsNCj4+PiAr
ICAgICAgICBub2RlID0gZHRfZmluZF9jb21wYXRpYmxlX25vZGUobm9kZSwgTlVMTCwgU0NNSV9T
SEFSRURfTUVNT1JZKTsNCj4+PiArICAgIH0NCj4+PiArDQo+Pj4gKyAgICByZXR1cm4gMDsNCj4+
PiArfQ0KPj4+ICsNCj4+PiArc3RhdGljIGludCByZWFkX2h5cF9jaGFubmVsX2FkZHIoc3RydWN0
IGR0X2RldmljZV9ub2RlICpzY21pX25vZGUsDQo+Pj4gKyAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgIHU2NCAqYWRkciwgdTY0ICpzaXplKQ0KPj4+ICt7DQo+Pj4gKyAgICBzdHJ1Y3Qg
ZHRfZGV2aWNlX25vZGUgKnNobWVtX25vZGU7DQo+Pj4gKyAgICBzaG1lbV9ub2RlID0gZ2V0X2R0
X25vZGVfZnJvbV9wcm9wZXJ0eShzY21pX25vZGUsICJzaG1lbSIpOw0KPj4+ICsgICAgaWYgKCBJ
U19FUlJfT1JfTlVMTChzaG1lbV9ub2RlKSApDQo+Pj4gKyAgICB7DQo+Pj4gKyAgICAgICAgcHJp
bnRrKFhFTkxPR19FUlINCj4+PiArICAgICAgICAgICAgICAgInNjbWk6IERldmljZSB0cmVlIGVy
cm9yLCBjYW4ndCBwYXJzZSByZXNlcnZlZCBtZW1vcnkgJWxkXG4iLA0KPj4+ICsgICAgICAgICAg
ICAgICBQVFJfRVJSKHNobWVtX25vZGUpKTsNCj4+PiArICAgICAgICByZXR1cm4gUFRSX0VSUihz
aG1lbV9ub2RlKTsNCj4+PiArICAgIH0NCj4+PiArDQo+Pj4gKyAgICByZXR1cm4gZHRfZGV2aWNl
X2dldF9hZGRyZXNzKHNobWVtX25vZGUsIDAsIGFkZHIsIHNpemUpOw0KPj4+ICt9DQo+Pj4gKw0K
Pj4+ICtzdGF0aWMgdm9pZCBmcmVlX3NobWVtX3JlZ2lvbnMoc3RydWN0IGxpc3RfaGVhZCAqYWRk
cl9saXN0KQ0KPj4+ICt7DQo+Pj4gKyAgICBzdHJ1Y3QgZHRfY2hhbm5lbF9hZGRyICpjdXJyLCAq
X2N1cnI7DQo+Pj4gKw0KPj4+ICsgICAgbGlzdF9mb3JfZWFjaF9lbnRyeV9zYWZlIChjdXJyLCBf
Y3VyciwgYWRkcl9saXN0LCBsaXN0KQ0KPj4+ICsgICAgew0KPj4+ICsgICAgICAgIGxpc3RfZGVs
KCZjdXJyLT5saXN0KTsNCj4+PiArICAgICAgICB4ZnJlZShjdXJyKTsNCj4+PiArICAgIH0NCj4+
PiArfQ0KPj4+ICsNCj4+PiArc3RhdGljIF9faW5pdCBib29sIHNjbWlfcHJvYmUoc3RydWN0IGR0
X2RldmljZV9ub2RlICpzY21pX25vZGUpDQo+Pj4gK3sNCj4+PiArICAgIHU2NCBhZGRyLCBzaXpl
Ow0KPj4+ICsgICAgaW50IHJldCwgaTsNCj4+PiArICAgIHN0cnVjdCBzY21pX2NoYW5uZWwgKmNo
YW5uZWwsICphZ2VudF9jaGFubmVsOw0KPj4+ICsgICAgaW50IG5fYWdlbnRzOw0KPj4+ICsgICAg
c2NtaV9tc2dfaGVhZGVyX3QgaGRyOw0KPj4+ICsgICAgc3RydWN0IHJ4X3Qgew0KPj4+ICsgICAg
ICAgIGludDMyX3Qgc3RhdHVzOw0KPj4+ICsgICAgICAgIHVpbnQzMl90IGF0dHJpYnV0ZXM7DQo+
Pj4gKyAgICB9IHJ4Ow0KPj4+ICsgICAgc3RydWN0IGR0X2NoYW5uZWxfYWRkciAqZW50cnk7DQo+
Pj4gKyAgICBzdHJ1Y3QgbGlzdF9oZWFkIGFkZHJfbGlzdDsNCj4+PiArDQo+Pj4gKyAgICB1aW50
MzJfdCBmdW5jX2lkOw0KPj4+ICsNCj4+PiArICAgIEFTU0VSVChzY21pX25vZGUgIT0gTlVMTCk7
DQo+Pj4gKw0KPj4+ICsgICAgSU5JVF9MSVNUX0hFQUQoJnNjbWlfZGF0YS5jaGFubmVsX2xpc3Qp
Ow0KPj4+ICsgICAgc3Bpbl9sb2NrX2luaXQoJnNjbWlfZGF0YS5jaGFubmVsX2xpc3RfbG9jayk7
DQo+Pj4gKw0KPj4+ICsgICAgaWYgKCAhZHRfcHJvcGVydHlfcmVhZF91MzIoc2NtaV9ub2RlLCBT
Q01JX1NNQ19JRCwgJmZ1bmNfaWQpICkNCj4+PiArICAgIHsNCj4+PiArICAgICAgICBwcmludGso
WEVOTE9HX0VSUiAic2NtaTogVW5hYmxlIHRvIHJlYWQgc21jLWlkIGZyb20gRFRcbiIpOw0KPj4+
ICsgICAgICAgIHJldHVybiBmYWxzZTsNCj4+PiArICAgIH0NCj4+PiArDQo+Pj4gKyAgICByZXQg
PSByZWFkX2h5cF9jaGFubmVsX2FkZHIoc2NtaV9ub2RlLCAmYWRkciwgJnNpemUpOw0KPj4+ICsg
ICAgaWYgKCBJU19FUlJfVkFMVUUocmV0KSApDQo+Pj4gKyAgICAgICAgcmV0dXJuIGZhbHNlOw0K
Pj4+ICsNCj4+PiArICAgIGlmICggIUlTX0FMSUdORUQoc2l6ZSwgU0NNSV9TSE1FTV9NQVBQRURf
U0laRSkgKQ0KPj4+ICsgICAgew0KPj4+ICsgICAgICAgIHByaW50ayhYRU5MT0dfRVJSICJzY21p
OiBSZXNlcnZlZCBtZW1vcnkgaXMgbm90IGFsaWduZWRcbiIpOw0KPj4+ICsgICAgICAgIHJldHVy
biBmYWxzZTsNCj4+PiArICAgIH0NCj4+PiArDQo+Pj4gKyAgICBJTklUX0xJU1RfSEVBRCgmYWRk
cl9saXN0KTsNCj4+PiArDQo+Pj4gKyAgICByZXQgPSBnZXRfc2htZW1fcmVnaW9ucygmYWRkcl9s
aXN0LCBhZGRyKTsNCj4+PiArICAgIGlmICggSVNfRVJSX1ZBTFVFKHJldCkgKQ0KPj4+ICsgICAg
ICAgIGdvdG8gb3V0Ow0KPj4+ICsNCj4+PiArICAgIGNoYW5uZWwgPSBzbWNfY3JlYXRlX2NoYW5u
ZWwoSFlQX0NIQU5ORUwsIGZ1bmNfaWQsIGFkZHIpOw0KPj4+ICsgICAgaWYgKCBJU19FUlIoY2hh
bm5lbCkgKQ0KPj4+ICsgICAgICAgIGdvdG8gb3V0Ow0KPj4+ICsNCj4+PiArICAgIHJldCA9IG1h
cF9jaGFubmVsX21lbW9yeShjaGFubmVsKTsNCj4+PiArICAgIGlmICggcmV0ICkNCj4+PiArICAg
ICAgICBnb3RvIG91dDsNCj4+PiArDQo+Pj4gKyAgICBzcGluX2xvY2soJnNjbWlfZGF0YS5jaGFu
bmVsX2xpc3RfbG9jayk7DQo+Pj4gKyAgICBjaGFubmVsLT5kb21haW5faWQgPSBET01JRF9YRU47
DQo+Pj4gKyAgICBzcGluX3VubG9jaygmc2NtaV9kYXRhLmNoYW5uZWxfbGlzdF9sb2NrKTsNCj4+
PiArDQo+Pj4gKyAgICBoZHIuaWQgPSBTQ01JX0JBU0VfUFJPVE9DT0xfQVRUSUJVVEVTOw0KPj4+
ICsgICAgaGRyLnR5cGUgPSAwOw0KPj4+ICsgICAgaGRyLnByb3RvY29sID0gU0NNSV9CQVNFX1BS
T1RPQ09MOw0KPj4+ICsNCj4+PiArICAgIHJldCA9IGRvX3NtY194ZmVyKGNoYW5uZWwsICZoZHIs
IE5VTEwsIDAsICZyeCwgc2l6ZW9mKHJ4KSk7DQo+Pj4gKyAgICBpZiAoIHJldCApDQo+Pj4gKyAg
ICAgICAgZ290byBlcnJvcjsNCj4+PiArDQo+Pj4gKyAgICByZXQgPSBjaGVja19zY21pX3N0YXR1
cyhyeC5zdGF0dXMpOw0KPj4+ICsgICAgaWYgKCByZXQgKQ0KPj4+ICsgICAgICAgIGdvdG8gZXJy
b3I7DQo+Pj4gKw0KPj4+ICsgICAgbl9hZ2VudHMgPSBGSUVMRF9HRVQoTVNHX05fQUdFTlRTX01B
U0ssIHJ4LmF0dHJpYnV0ZXMpOw0KPj4+ICsgICAgcHJpbnRrKFhFTkxPR19ERUJVRyAic2NtaTog
R290IGFnZW50IGNvdW50ICVkXG4iLCBuX2FnZW50cyk7DQo+Pj4gKw0KPj4+ICsgICAgaSA9IDE7
DQo+Pj4gKyAgICBsaXN0X2Zvcl9lYWNoX2VudHJ5KGVudHJ5LCAmYWRkcl9saXN0LCBsaXN0KQ0K
Pj4+ICsgICAgew0KPj4+ICsgICAgICAgIHVpbnQzMl90IHR4X2FnZW50X2lkID0gMHhGRkZGRkZG
RjsNCj4+PiArICAgICAgICBzdHJ1Y3Qgew0KPj4+ICsgICAgICAgICAgICBpbnQzMl90IHN0YXR1
czsNCj4+PiArICAgICAgICAgICAgdWludDMyX3QgYWdlbnRfaWQ7DQo+Pj4gKyAgICAgICAgICAg
IGNoYXIgbmFtZVsxNl07DQo+Pj4gKyAgICAgICAgfSBkYV9yeDsNCj4+PiArDQo+Pj4gKyAgICAg
ICAgYWdlbnRfY2hhbm5lbCA9IHNtY19jcmVhdGVfY2hhbm5lbChpLCBmdW5jX2lkLA0KPj4+ICsg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZW50cnktPmFkZHIpOw0K
Pj4+ICsgICAgICAgIGlmICggSVNfRVJSKGFnZW50X2NoYW5uZWwpICkNCj4+PiArICAgICAgICB7
DQo+Pj4gKyAgICAgICAgICAgIHJldCA9IFBUUl9FUlIoYWdlbnRfY2hhbm5lbCk7DQo+Pj4gKyAg
ICAgICAgICAgIGdvdG8gZXJyb3I7DQo+Pj4gKyAgICAgICAgfQ0KPj4+ICsNCj4+PiArICAgICAg
ICByZXQgPSBtYXBfY2hhbm5lbF9tZW1vcnkoYWdlbnRfY2hhbm5lbCk7DQo+Pj4gKyAgICAgICAg
aWYgKCByZXQgKQ0KPj4+ICsgICAgICAgICAgICBnb3RvIGVycm9yOw0KPj4+ICsNCj4+PiArICAg
ICAgICBoZHIuaWQgPSBTQ01JX0JBU0VfRElTQ09WRVJfQUdFTlQ7DQo+Pj4gKyAgICAgICAgaGRy
LnR5cGUgPSAwOw0KPj4+ICsgICAgICAgIGhkci5wcm90b2NvbCA9IFNDTUlfQkFTRV9QUk9UT0NP
TDsNCj4+PiArDQo+Pj4gKyAgICAgICAgcmV0ID0gZG9fc21jX3hmZXIoYWdlbnRfY2hhbm5lbCwg
JmhkciwgJnR4X2FnZW50X2lkLA0KPj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgIHNpemVv
Zih0eF9hZ2VudF9pZCksICZkYV9yeCwgc2l6ZW9mKGRhX3J4KSk7DQo+Pj4gKyAgICAgICAgaWYg
KCByZXQgKQ0KPj4+ICsgICAgICAgIHsNCj4+PiArICAgICAgICAgICAgdW5tYXBfY2hhbm5lbF9t
ZW1vcnkoYWdlbnRfY2hhbm5lbCk7DQo+Pj4gKyAgICAgICAgICAgIGdvdG8gZXJyb3I7DQo+Pj4g
KyAgICAgICAgfQ0KPj4+ICsNCj4+PiArICAgICAgICB1bm1hcF9jaGFubmVsX21lbW9yeShhZ2Vu
dF9jaGFubmVsKTsNCj4+PiArDQo+Pj4gKyAgICAgICAgcmV0ID0gY2hlY2tfc2NtaV9zdGF0dXMo
ZGFfcnguc3RhdHVzKTsNCj4+PiArICAgICAgICBpZiAoIHJldCApDQo+Pj4gKyAgICAgICAgICAg
IGdvdG8gZXJyb3I7DQo+Pj4gKw0KPj4+ICsgICAgICAgIHByaW50ayhYRU5MT0dfREVCVUcgInNj
bWk6IHN0YXR1cz0weCV4IGlkPTB4JXggbmFtZT0lc1xuIiwNCj4+PiArICAgICAgICAgICAgICAg
IGRhX3J4LnN0YXR1cywgZGFfcnguYWdlbnRfaWQsIGRhX3J4Lm5hbWUpOw0KPj4+ICsNCj4+PiAr
ICAgICAgICBhZ2VudF9jaGFubmVsLT5hZ2VudF9pZCA9IGRhX3J4LmFnZW50X2lkOw0KPj4+ICsN
Cj4+PiArICAgICAgICBpZiAoIGkgPT0gbl9hZ2VudHMgKQ0KPj4+ICsgICAgICAgICAgICBicmVh
azsNCj4+PiArDQo+Pj4gKyAgICAgICAgaSsrOw0KPj4+ICsgICAgfQ0KPj4+ICsNCj4+PiArICAg
IHNjbWlfZGF0YS5pbml0aWFsaXplZCA9IHRydWU7DQo+Pj4gKyAgICBnb3RvIG91dDsNCj4+PiAr
DQo+Pj4gK2Vycm9yOg0KPj4+ICsgICAgdW5tYXBfY2hhbm5lbF9tZW1vcnkoY2hhbm5lbCk7DQo+
Pj4gKyAgICBmcmVlX2NoYW5uZWxfbGlzdCgpOw0KPj4+ICtvdXQ6DQo+Pj4gKyAgICBmcmVlX3No
bWVtX3JlZ2lvbnMoJmFkZHJfbGlzdCk7DQo+Pj4gKyAgICByZXR1cm4gcmV0ID09IDA7DQo+Pj4g
K30NCj4+PiArDQo+Pj4gK3N0YXRpYyBpbnQgc2NtaV9kb21haW5faW5pdChzdHJ1Y3QgZG9tYWlu
ICpkLA0KPj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICBzdHJ1Y3QgeGVuX2FyY2hfZG9t
YWluY29uZmlnICpjb25maWcpDQo+Pj4gK3sNCj4+PiArICAgIHN0cnVjdCBzY21pX2NoYW5uZWwg
KmNoYW5uZWw7DQo+Pj4gKyAgICBpbnQgcmV0Ow0KPj4+ICsNCj4+PiArICAgIGlmICggIXNjbWlf
ZGF0YS5pbml0aWFsaXplZCApDQo+Pj4gKyAgICAgICAgcmV0dXJuIDA7DQo+Pj4gKw0KPj4+ICsg
ICAgcHJpbnRrKFhFTkxPR19JTkZPICJzY21pOiBkb21haW5faWQgPSAlZFxuIiwgZC0+ZG9tYWlu
X2lkKTsNCj4+PiArDQo+Pj4gKyAgICBjaGFubmVsID0gYXF1aXJlX3NjbWlfY2hhbm5lbChkLT5k
b21haW5faWQpOw0KPj4+ICsgICAgaWYgKCBJU19FUlJfT1JfTlVMTChjaGFubmVsKSApDQo+Pj4g
KyAgICAgICAgcmV0dXJuIC1FTk9FTlQ7DQo+Pj4gKw0KPj4+ICsjaWZkZWYgQ09ORklHX0FSTV8z
Mg0KPj4+ICsgICAgcHJpbnRrKFhFTkxPR19JTkZPDQo+Pj4gKyAgICAgICAgICAgInNjbWk6IEFx
dWlyZSBTQ01JIGNoYW5uZWwgaWQgPSAweCV4ICwgZG9tYWluX2lkID0gJWQgcGFkZHIgPSAweCVs
bHhcbiIsDQo+Pj4gKyAgICAgICAgICAgY2hhbm5lbC0+Y2hhbl9pZCwgY2hhbm5lbC0+ZG9tYWlu
X2lkLCBjaGFubmVsLT5wYWRkcik7DQo+Pj4gKyNlbHNlDQo+Pj4gKyAgICBwcmludGsoWEVOTE9H
X0lORk8NCj4+PiArICAgICAgICAgICAic2NtaTogQXF1aXJlIFNDTUkgY2hhbm5lbCBpZCA9IDB4
JXggLCBkb21haW5faWQgPSAlZCBwYWRkciA9IDB4JWx4XG4iLA0KPj4+ICsgICAgICAgICAgIGNo
YW5uZWwtPmNoYW5faWQsIGNoYW5uZWwtPmRvbWFpbl9pZCwgY2hhbm5lbC0+cGFkZHIpOw0KPj4+
ICsjZW5kaWYNCj4+PiArDQo+Pj4gKyAgICBpZiAoIGlzX2hhcmR3YXJlX2RvbWFpbihkKSApDQo+
Pj4gKyAgICB7DQo+Pj4gKyAgICAgICAgcmV0ID0gbWVtX3Blcm1pdF9hY2Nlc3MoZCwgY2hhbm5l
bC0+cGFkZHIsIFBBR0VfU0laRSk7DQo+Pj4gKyAgICAgICAgaWYgKCBJU19FUlJfVkFMVUUocmV0
KSApDQo+Pj4gKyAgICAgICAgICAgIGdvdG8gZXJyb3I7DQo+Pj4gKw0KPj4+ICsgICAgICAgIHJl
dCA9IGR0X3VwZGF0ZV9kb21haW5fcmFuZ2UoY2hhbm5lbC0+cGFkZHIsIFBBR0VfU0laRSk7DQo+
Pj4gKyAgICAgICAgaWYgKCBJU19FUlJfVkFMVUUocmV0KSApDQo+Pj4gKyAgICAgICAgew0KPj4+
ICsgICAgICAgICAgICBpbnQgcmMgPSBtZW1fZGVueV9hY2Nlc3MoZCwgY2hhbm5lbC0+cGFkZHIs
IFBBR0VfU0laRSk7DQo+Pj4gKyAgICAgICAgICAgIGlmICggcmMgKQ0KPj4+ICsgICAgICAgICAg
ICAgICAgcHJpbnRrKFhFTkxPR19FUlIgIlVuYWJsZSB0byBtZW1fZGVueV9hY2Nlc3NcbiIpOw0K
Pj4+ICsNCj4+PiArICAgICAgICAgICAgZ290byBlcnJvcjsNCj4+PiArICAgICAgICB9DQo+Pj4g
KyAgICB9DQo+Pj4gKw0KPj4+ICsgICAgZC0+YXJjaC5zY2kgPSBjaGFubmVsOw0KPj4+ICsgICAg
aWYgKCBjb25maWcgKQ0KPj4+ICsgICAgICAgIGNvbmZpZy0+YXJtX3NjaV9hZ2VudF9wYWRkciA9
IGNoYW5uZWwtPnBhZGRyOw0KPj4+ICsNCj4+PiArICAgIHJldHVybiAwOw0KPj4+ICtlcnJvcjoN
Cj4+PiArICAgIHJlbGlucXVpc2hfc2NtaV9jaGFubmVsKGNoYW5uZWwpOw0KPj4+ICsNCj4+PiAr
ICAgIHJldHVybiByZXQ7DQo+Pj4gK30NCj4+PiArDQo+Pj4gK3N0YXRpYyBpbnQgc2NtaV9hZGRf
ZGV2aWNlX2J5X2RldmlkKHN0cnVjdCBkb21haW4gKmQsIHVpbnQzMl90IHNjbWlfZGV2aWQpDQo+
Pj4gK3sNCj4+PiArICAgIHN0cnVjdCBzY21pX2NoYW5uZWwgKmNoYW5uZWwsICphZ2VudF9jaGFu
bmVsOw0KPj4+ICsgICAgc2NtaV9tc2dfaGVhZGVyX3QgaGRyOw0KPj4+ICsgICAgc3RydWN0IHNj
bWlfcGVybXNfdHggew0KPj4+ICsgICAgICAgIHVpbnQzMl90IGFnZW50X2lkOw0KPj4+ICsgICAg
ICAgIHVpbnQzMl90IGRldmljZV9pZDsNCj4+PiArICAgICAgICB1aW50MzJfdCBmbGFnczsNCj4+
PiArICAgIH0gdHg7DQo+Pj4gKyAgICBzdHJ1Y3QgcnhfdCB7DQo+Pj4gKyAgICAgICAgaW50MzJf
dCBzdGF0dXM7DQo+Pj4gKyAgICAgICAgdWludDMyX3QgYXR0cmlidXRlczsNCj4+PiArICAgIH0g
cng7DQo+Pj4gKyAgICBpbnQgcmV0Ow0KPj4+ICsNCj4+PiArICAgIGlmICggIXNjbWlfZGF0YS5p
bml0aWFsaXplZCApDQo+Pj4gKyAgICAgICAgcmV0dXJuIDA7DQo+Pj4gKw0KPj4+ICsgICAgcHJp
bnRrKFhFTkxPR19ERUJVRyAic2NtaTogc2NtaV9kZXZpZCA9ICVkXG4iLCBzY21pX2RldmlkKTsN
Cj4+PiArDQo+Pj4gKyAgICBhZ2VudF9jaGFubmVsID0gZC0+YXJjaC5zY2k7DQo+Pj4gKyAgICBp
ZiAoIElTX0VSUl9PUl9OVUxMKGFnZW50X2NoYW5uZWwpICkNCj4+PiArICAgICAgICByZXR1cm4g
UFRSX0VSUihhZ2VudF9jaGFubmVsKTsNCj4+PiArDQo+Pj4gKyAgICBjaGFubmVsID0gZ2V0X2No
YW5uZWxfYnlfaWQoSFlQX0NIQU5ORUwpOw0KPj4+ICsgICAgaWYgKCBJU19FUlJfT1JfTlVMTChj
aGFubmVsKSApDQo+Pj4gKyAgICAgICAgcmV0dXJuIFBUUl9FUlIoY2hhbm5lbCk7DQo+Pj4gKw0K
Pj4+ICsgICAgaGRyLmlkID0gU0NNSV9CQVNFX1NFVF9ERVZJQ0VfUEVSTUlTU0lPTlM7DQo+Pj4g
KyAgICBoZHIudHlwZSA9IDA7DQo+Pj4gKyAgICBoZHIucHJvdG9jb2wgPSBTQ01JX0JBU0VfUFJP
VE9DT0w7DQo+Pj4gKw0KPj4+ICsgICAgdHguYWdlbnRfaWQgPSBhZ2VudF9jaGFubmVsLT5hZ2Vu
dF9pZDsNCj4+PiArICAgIHR4LmRldmljZV9pZCA9IHNjbWlfZGV2aWQ7DQo+Pj4gKyAgICB0eC5m
bGFncyA9IFNDTUlfQUxMT1dfQUNDRVNTOw0KPj4+ICsNCj4+PiArICAgIHJldCA9IGRvX3NtY194
ZmVyKGNoYW5uZWwsICZoZHIsICZ0eCwgc2l6ZW9mKHR4KSwgJnJ4LCBzaXplb2YoJnJ4KSk7DQo+
Pj4gKyAgICBpZiAoIElTX0VSUl9WQUxVRShyZXQpICkNCj4+PiArICAgICAgICByZXR1cm4gcmV0
Ow0KPj4+ICsNCj4+PiArICAgIHJldCA9IGNoZWNrX3NjbWlfc3RhdHVzKHJ4LnN0YXR1cyk7DQo+
Pj4gKyAgICBpZiAoIElTX0VSUl9WQUxVRShyZXQpICkNCj4+PiArICAgICAgICByZXR1cm4gcmV0
Ow0KPj4+ICsNCj4+PiArICAgIHJldHVybiAwOw0KPj4+ICt9DQo+Pj4gKw0KPj4+ICtzdGF0aWMg
aW50IHNjbWlfYWRkX2R0X2RldmljZShzdHJ1Y3QgZG9tYWluICpkLCBzdHJ1Y3QgZHRfZGV2aWNl
X25vZGUgKmRldikNCj4+PiArew0KPj4+ICsgICAgdWludDMyX3Qgc2NtaV9kZXZpZDsNCj4+PiAr
DQo+Pj4gKyAgICBpZiAoICghc2NtaV9kYXRhLmluaXRpYWxpemVkKSB8fCAoIWQtPmFyY2guc2Np
KSApDQo+Pj4gKyAgICAgICAgcmV0dXJuIDA7DQo+Pj4gKw0KPj4+ICsgICAgaWYgKCAhZHRfcHJv
cGVydHlfcmVhZF91MzIoZGV2LCAic2NtaV9kZXZpZCIsICZzY21pX2RldmlkKSApDQo+Pj4gKyAg
ICAgICAgcmV0dXJuIDA7DQo+Pj4gKw0KPj4+ICsgICAgcHJpbnRrKFhFTkxPR19JTkZPICJzY21p
OiBkdF9ub2RlID0gJXNcbiIsIGR0X25vZGVfZnVsbF9uYW1lKGRldikpOw0KPj4+ICsNCj4+PiAr
ICAgIHJldHVybiBzY21pX2FkZF9kZXZpY2VfYnlfZGV2aWQoZCwgc2NtaV9kZXZpZCk7DQo+Pj4g
K30NCj4+PiArDQo+Pj4gK3N0YXRpYyBpbnQgc2NtaV9yZWxpbnF1aXNoX3Jlc291cmNlcyhzdHJ1
Y3QgZG9tYWluICpkKQ0KPj4+ICt7DQo+Pj4gKyAgICBpbnQgcmV0Ow0KPj4+ICsgICAgc3RydWN0
IHNjbWlfY2hhbm5lbCAqY2hhbm5lbCwgKmFnZW50X2NoYW5uZWw7DQo+Pj4gKyAgICBzY21pX21z
Z19oZWFkZXJfdCBoZHI7DQo+Pj4gKyAgICBzdHJ1Y3QgcmVzZXRfYWdlbnRfdHggew0KPj4+ICsg
ICAgICAgIHVpbnQzMl90IGFnZW50X2lkOw0KPj4+ICsgICAgICAgIHVpbnQzMl90IGZsYWdzOw0K
Pj4+ICsgICAgfSB0eDsNCj4+PiArICAgIHVpbnQzMl90IHJ4Ow0KPj4+ICsNCj4+PiArICAgIGlm
ICggIWQtPmFyY2guc2NpICkNCj4+PiArICAgICAgICByZXR1cm4gMDsNCj4+PiArDQo+Pj4gKyAg
ICBhZ2VudF9jaGFubmVsID0gZC0+YXJjaC5zY2k7DQo+Pj4gKw0KPj4+ICsgICAgc3Bpbl9sb2Nr
KCZhZ2VudF9jaGFubmVsLT5sb2NrKTsNCj4+PiArICAgIHR4LmFnZW50X2lkID0gYWdlbnRfY2hh
bm5lbC0+YWdlbnRfaWQ7DQo+Pj4gKyAgICBzcGluX3VubG9jaygmYWdlbnRfY2hhbm5lbC0+bG9j
ayk7DQo+Pj4gKw0KPj4+ICsgICAgY2hhbm5lbCA9IGdldF9jaGFubmVsX2J5X2lkKEhZUF9DSEFO
TkVMKTsNCj4+PiArICAgIGlmICggIWNoYW5uZWwgKQ0KPj4+ICsgICAgew0KPj4+ICsgICAgICAg
IHByaW50ayhYRU5MT0dfRVJSDQo+Pj4gKyAgICAgICAgICAgICAgICJzY21pOiBVbmFibGUgdG8g
Z2V0IEh5cGVydmlzb3Igc2NtaSBjaGFubmVsIGZvciBkb21haW4gJWRcbiIsDQo+Pj4gKyAgICAg
ICAgICAgICAgIGQtPmRvbWFpbl9pZCk7DQo+Pj4gKyAgICAgICAgcmV0dXJuIC1FSU5WQUw7DQo+
Pj4gKyAgICB9DQo+Pj4gKw0KPj4+ICsgICAgaGRyLmlkID0gU0NNSV9CQVNFX1JFU0VUX0FHRU5U
X0NPTkZJR1VSQVRJT047DQo+Pj4gKyAgICBoZHIudHlwZSA9IDA7DQo+Pj4gKyAgICBoZHIucHJv
dG9jb2wgPSBTQ01JX0JBU0VfUFJPVE9DT0w7DQo+Pj4gKw0KPj4+ICsgICAgdHguZmxhZ3MgPSAw
Ow0KPj4+ICsNCj4+PiArICAgIHJldCA9IGRvX3NtY194ZmVyKGNoYW5uZWwsICZoZHIsICZ0eCwg
c2l6ZW9mKHR4KSwgJnJ4LCBzaXplb2YocngpKTsNCj4+PiArICAgIGlmICggcmV0ICkNCj4+PiAr
ICAgICAgICByZXR1cm4gcmV0Ow0KPj4+ICsNCj4+PiArICAgIHJldCA9IGNoZWNrX3NjbWlfc3Rh
dHVzKHJ4KTsNCj4+PiArDQo+Pj4gKyAgICByZXR1cm4gcmV0Ow0KPj4+ICt9DQo+Pj4gKw0KPj4+
ICtzdGF0aWMgdm9pZCBzY21pX2RvbWFpbl9kZXN0cm95KHN0cnVjdCBkb21haW4gKmQpDQo+Pj4g
K3sNCj4+PiArICAgIHN0cnVjdCBzY21pX2NoYW5uZWwgKmNoYW5uZWw7DQo+Pj4gKw0KPj4+ICsg
ICAgaWYgKCAhZC0+YXJjaC5zY2kgKQ0KPj4+ICsgICAgICAgIHJldHVybjsNCj4+PiArDQo+Pj4g
KyAgICBjaGFubmVsID0gZC0+YXJjaC5zY2k7DQo+Pj4gKyAgICBzcGluX2xvY2soJmNoYW5uZWwt
PmxvY2spOw0KPj4+ICsNCj4+PiArICAgIHJlbGlucXVpc2hfc2NtaV9jaGFubmVsKGNoYW5uZWwp
Ow0KPj4+ICsgICAgcHJpbnRrKFhFTkxPR19ERUJVRyAic2NtaTogRnJlZSBkb21haW4gJWRcbiIs
IGQtPmRvbWFpbl9pZCk7DQo+Pj4gKw0KPj4+ICsgICAgZC0+YXJjaC5zY2kgPSBOVUxMOw0KPj4+
ICsNCj4+PiArICAgIG1lbV9kZW55X2FjY2VzcyhkLCBjaGFubmVsLT5wYWRkciwgUEFHRV9TSVpF
KTsNCj4+PiArICAgIHNwaW5fdW5sb2NrKCZjaGFubmVsLT5sb2NrKTsNCj4+PiArfQ0KPj4+ICsN
Cj4+PiArc3RhdGljIGJvb2wgc2NtaV9oYW5kbGVfY2FsbChzdHJ1Y3QgZG9tYWluICpkLCB2b2lk
ICphcmdzKQ0KPj4+ICt7DQo+Pj4gKyAgICBib29sIHJlcyA9IGZhbHNlOw0KPj4+ICsgICAgc3Ry
dWN0IHNjbWlfY2hhbm5lbCAqYWdlbnRfY2hhbm5lbDsNCj4+PiArICAgIHN0cnVjdCBhcm1fc21j
Y2NfcmVzIHJlc3A7DQo+Pj4gKyAgICBzdHJ1Y3QgY3B1X3VzZXJfcmVncyAqcmVncyA9IGFyZ3M7
DQo+Pj4gKw0KPj4+ICsgICAgaWYgKCAhZC0+YXJjaC5zY2kgKQ0KPj4+ICsgICAgICAgIHJldHVy
biBmYWxzZTsNCj4+PiArDQo+Pj4gKyAgICBhZ2VudF9jaGFubmVsID0gZC0+YXJjaC5zY2k7DQo+
Pj4gKyAgICBzcGluX2xvY2soJmFnZW50X2NoYW5uZWwtPmxvY2spOw0KPj4+ICsNCj4+PiArICAg
IGlmICggYWdlbnRfY2hhbm5lbC0+ZnVuY19pZCAhPSByZWdzLT5yMCApDQo+Pj4gKyAgICB7DQo+
Pj4gKyAgICAgICAgcmVzID0gZmFsc2U7DQo+Pj4gKyAgICAgICAgZ290byB1bmxvY2s7DQo+Pj4g
KyAgICB9DQo+Pj4gKw0KPj4+ICsgICAgYXJtX3NtY2NjX3NtYyhhZ2VudF9jaGFubmVsLT5mdW5j
X2lkLCAwLCAwLCAwLCAwLCAwLCAwLA0KPj4+ICsgICAgICAgICAgICAgICAgICBhZ2VudF9jaGFu
bmVsLT5jaGFuX2lkLCAmcmVzcCk7DQo+Pj4gKw0KPj4+ICsgICAgc2V0X3VzZXJfcmVnKHJlZ3Ms
IDAsIHJlc3AuYTApOw0KPj4+ICsgICAgc2V0X3VzZXJfcmVnKHJlZ3MsIDEsIHJlc3AuYTEpOw0K
Pj4+ICsgICAgc2V0X3VzZXJfcmVnKHJlZ3MsIDIsIHJlc3AuYTIpOw0KPj4+ICsgICAgc2V0X3Vz
ZXJfcmVnKHJlZ3MsIDMsIHJlc3AuYTMpOw0KPj4+ICsgICAgcmVzID0gdHJ1ZTsNCj4+PiArdW5s
b2NrOg0KPj4+ICsgICAgc3Bpbl91bmxvY2soJmFnZW50X2NoYW5uZWwtPmxvY2spOw0KPj4+ICsN
Cj4+PiArICAgIHJldHVybiByZXM7DQo+Pj4gK30NCj4+PiArDQo+Pj4gK3N0YXRpYyBjb25zdCBz
dHJ1Y3QgZHRfZGV2aWNlX21hdGNoIHNjbWlfc21jX21hdGNoW10gX19pbml0Y29uc3QgPQ0KPj4+
ICt7DQo+Pj4gKyAgICBEVF9NQVRDSF9TQ01JX1NNQywNCj4+PiArICAgIHsgLyogc2VudGluZWwg
Ki8gfSwNCj4+PiArfTsNCj4+PiArDQo+Pj4gK3N0YXRpYyBjb25zdCBzdHJ1Y3Qgc2NpX21lZGlh
dG9yX29wcyBzY21pX29wcyA9DQo+Pj4gK3sNCj4+PiArICAgIC5wcm9iZSA9IHNjbWlfcHJvYmUs
DQo+Pj4gKyAgICAuZG9tYWluX2luaXQgPSBzY21pX2RvbWFpbl9pbml0LA0KPj4+ICsgICAgLmRv
bWFpbl9kZXN0cm95ID0gc2NtaV9kb21haW5fZGVzdHJveSwNCj4+PiArICAgIC5hZGRfZHRfZGV2
aWNlID0gc2NtaV9hZGRfZHRfZGV2aWNlLA0KPj4+ICsgICAgLnJlbGlucXVpc2hfcmVzb3VyY2Vz
ID0gc2NtaV9yZWxpbnF1aXNoX3Jlc291cmNlcywNCj4+PiArICAgIC5oYW5kbGVfY2FsbCA9IHNj
bWlfaGFuZGxlX2NhbGwsDQo+Pj4gK307DQo+Pj4gKw0KPj4+ICtSRUdJU1RFUl9TQ0lfTUVESUFU
T1Ioc2NtaV9zbWMsICJTQ01JLVNNQyIsIFhFTl9ET01DVExfQ09ORklHX0FSTV9TQ0lfU0NNSV9T
TUMsDQo+Pj4gKyAgICAgICAgICAgICAgICAgICAgICBzY21pX3NtY19tYXRjaCwgJnNjbWlfb3Bz
KTsNCj4+PiArDQo+Pj4gKy8qDQo+Pj4gKyAqIExvY2FsIHZhcmlhYmxlczoNCj4+PiArICogbW9k
ZTogQw0KPj4+ICsgKiBjLWZpbGUtc3R5bGU6ICJCU0QiDQo+Pj4gKyAqIGMtYmFzaWMtb2Zmc2V0
OiA0DQo+Pj4gKyAqIGluZGVudC10YWJzLW1vZGU6IG5pbA0KPj4+ICsgKiBFbmQ6DQo+Pj4gKyAq
Lw0KPj4+IC0tIA0KPj4+IDIuMjcuMA0KDQo=


From xen-devel-bounces@lists.xenproject.org Fri Feb 11 11:19:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 11:19:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270379.464653 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nITxg-0001Kx-W5; Fri, 11 Feb 2022 11:19:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270379.464653; Fri, 11 Feb 2022 11:19:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nITxg-0001Kq-Sk; Fri, 11 Feb 2022 11:19:36 +0000
Received: by outflank-mailman (input) for mailman id 270379;
 Fri, 11 Feb 2022 11:19:35 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=dFbI=S2=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nITxf-0001KM-MP
 for xen-devel@lists.xenproject.org; Fri, 11 Feb 2022 11:19:35 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7ca5b92d-8b2c-11ec-8eb8-a37418f5ba1a;
 Fri, 11 Feb 2022 12:19:34 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7ca5b92d-8b2c-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644578374;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=x6jNgkM9bZehfeHtkhhSLR0XE2PqZA+afu6dxdcvOGA=;
  b=WhP0TDO1IGYV2hHHRTSaD/ZhqrQ/soGHzUIOSkb2G4FPY3RQf2tS9LZF
   y0fg9p5STjRuPJxDsWnrobFIA8xfft+Pvvo3rVxlen4//Blkpq/ntFdSf
   GNbUO8GHkyCxio64Cz3+9SxzWDX6y52xzua3bCq5xEWkVY60T2wzl4Uam
   0=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: /pi0KTqm2/daGH2o/rYxo/QK61SprCqy2haafOn6fK2LIFBdhinVvHecBi1dxPaca9I0tGJxeh
 xaNK0sl7n8CNqcwLT8XalGDHgoywmsPrFBnc2nbdru3Wzh7sUYO8RXpNTLcvunU1sRMjI1Uo+U
 NdYFGqXOt5ApoNwhBf7xrnr0/C7hSaTWWSdfSeT/pUisFofLzh2WO7EA6HaOUxlFhYCxLhQZY8
 ZRVKiN6IVb3qw+vMYWQvYWolytpKWCs6ZqVxQpqqL6Yx9sN8ds03tRnyMTMu4dBsjbi+z8B0mE
 mLclZH6FnuhRB7xaThNiAnS2
X-SBRS: 5.1
X-MesageID: 64007124
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Siz5D60QfTTV7aS8R/bD5T12kn2cJEfYwER7XKvMYLTBsI5bp2QHm
 DEcCDqHaf/cZmqhfYh2aYTkoE0GvMLSmNFrSQRlpC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkS5PE3oHJ9RGQ74nRLlbHILOCanAZqTNMEn9700o5wrdh2+aEvPDia++zk
 YKqyyHgEAfNNw5cagr4PIra9XuDFNyr0N8plgRWicJj5TcypFFMZH4rHomjLmOQf2VhNrXSq
 9Avbl2O1jixEx8FUrtJm1tgG6EAaua60QOm0hK6V0U+6/TrS+NbPqsTbZIhhUlrZzqh2NRck
 8hBlbuMag4EEqT3vfUafzoGOnQrVUFG0OevzXmXtMWSywvNcmf2wuUoB0YzVWEa0r8pWycUr
 6VecW1TKEDY7w616OvTpu1EnMMsIdOtJIoCknph0SvYHbAtRpWrr6Diu4MAhGhp3Jwm8fD2N
 ssDSgo1SET7ZRxEa14XNbY327qJvyyqG9FfgA3M/vdmi4TJ9yRu1JD9PdyTfcaFLe1Tm0+eu
 mLL7kzwBxgIM9rZxTft2nCmi/LLnCj7cJkPD7D+/flv6HWDy2pWBBAIWF+TpfiillX4S99ZM
 1YT+Cclse417kPDczXmd0Tm+jje5EdaAocOVb1hgO2Q9kbKy0GdKzMZQh5mVP8vmeM/fhk70
 XOqwfq8UFSDr4apYX6a876Vqxa7Ni4UMXIOaEc4cOcV3zXwiNpt10ySF76PBIbw14SoQm+on
 1hmuQBj3+17sCId60msEbkraRqIr4OBcAM67x6/somNvlIgP97Ni2BFBDHmARd8wGSxEwHpU
 JsswZH2AAUy4Xelzn3lrAIlRu/B2hp9GGeA6WOD5rF4n9hXx1atfJpL/BZ1L1pzP8APdFfBO
 RGP5V4LucAMZibzNcebhr5d7exwnMAM8vy/CJjpgidmOMAtJGdrAgkyDaJv44wduBd1yvxuU
 XtqWc2tEWwbGcxaIMmeHI8gPUsQ7nlmnwv7HMmjpzz+iOb2TCPFGN8tbQrVBshkvfzsnekg2
 4sGXyd8404EC7OWj+i+2dN7EG3m2lBlWc6o+5YKKoZu4GNOQQkcNhMY+pt4E6RNlKVJjObYu
 Ha7X05T0l3kgnPbbw6NbxhehHnHB/6TdFo3Yn4hO0iGwX8mbdr95asTbcJvL7Im6PZi3bh/S
 PxcI5eMBfFGSzLm/TUBbMai8Nw+JUrz3Q/ebTC4ZDUffoJ7Q1Cb8NHTYQaypjIFCTC6tJVir
 uT4hB/bW5cKWy9rEN3SNKC011q0sHVEwLByUkLEL8N9YkLp9IQ2eSX9guVue5MHKAnZxyvc3
 AGTWE9Kqe7Iqo4z0d/ImaHb8Nv5T7ogRhJXRjCJ46y3OC/W+nuY7bVBCOvYLyrAUG7U+bm5Y
 bkHxf/LL/Bazk1BtJBxEug3wPtmtcfvvbJT0i9tAG7PMwawErplL3SLgZtPu6lKyuMLsAe6Q
 BvSqNxTOLHPM8L5Cl8BYgEia73bh/0TnzDT69UzIVn7u3ArrObWDx0KMknekjFZIZt0LJghk
 LUot8Mh4gCijgYnb4SdhSdO+mXQdnENXs3LbH3B7FMHXubz9mx/XA==
IronPort-HdrOrdr: A9a23:qWbb1KyOBi99emW7ovZqKrPwKL1zdoMgy1knxilNoHtuA6ulfq
 GV7ZAmPHrP4wr5N0tNpTntAsa9qBDnlaKdg7N+AV7KZmCP0gaVxepZjLfK8nnNHDD/6/4Y9Y
 oISdkaNDQoNykYsS8t2njbL+od
X-IronPort-AV: E=Sophos;i="5.88,360,1635220800"; 
   d="scan'208";a="64007124"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=PagxlZnVtzitg4hfJQ8tKd1K2x3UarJbRI04zMBHS5HT3OaEkFmGPR9XcZ5jY6uCl32lXvpCJOCkP+URXKLlRiCsnMp5pNzpxw0L9buYuDCrKAQ7k2yrIbBO+gZNEj8kUoYJSBjY9lC+K4pk5t1QecYO2JXJIxvAF4QHUGlDQGMcHNBVkkG69tlU9mQN5ykOb6z+3nQNF86/2vYkGTzNHXVizQGlfvo2GqkRUcPtnu2iimqY09HncB6+gYGl14dMKNqS0XOOzxlAdSleN7wtypVN70Rr34o45Vmp/2dGmcdFTuVSQopOs62a5AHci+nhBb0+2wY+vnzFRj6ThWAqOA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=JSUWH+5k24zhRy9OCmURlpbFd59qpEHjrkQ+7Y39Hrs=;
 b=MhpihvUpr+VC1zt3YT6CKoTVLp6KXguABnqhQH5CTZTbSXNwoLptsP+V7axmNshttGsE9XFTp87k3MgHZ3uLsweIJsVZ+AvRbHrIojUGfTbZ97HoIfrWp7mpTFEdiaXcTpQw/cTCd5gmiaZlmfPOJn7xMZkMqj7n0NJSozCy+xbA6a3exnNxZVwKRaTxACHYNuh5u/wbbt9q2gxf27TwaJjkINSShQ41kL7GJ6ot58ubjYSr0ayeg5mGgL4XRfybhGcWvhnlLTCSWXR+gQobfry91GfsQq7E1eUmBubvA6RrXoYQMXJrGaeO8efD5ngZ72tw1SJb0MqlC42RlWp2eQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=JSUWH+5k24zhRy9OCmURlpbFd59qpEHjrkQ+7Y39Hrs=;
 b=ot4q0ReOv7mZOL7QaV5LLVZXi8S8TTF7yBz5iFroCXaKi/YE5oYFZtkKuuBHkyWXNxeqVrQ9vtMJFN/EQlEAYQSP+lNBxGFj9P6Uf7DOoEmdBpXfh3g3LKYu5ZiR3t/YX8kOBA6DJREueoFkSnt14tkfelke0Q+605K8JfSBJoM=
Date: Fri, 11 Feb 2022 12:19:25 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: <xen-devel@lists.xenproject.org>, Andrew Cooper
	<andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>, Norbert Manthey
	<nmanthey@amazon.de>
Subject: Re: [PATCH CPU v1] cpuid: initialize cpuinfo with boot_cpu_data
Message-ID: <YgZGPZUyW0mzGz+Q@Air-de-Roger>
References: <20220211072327.1213-1-nmanthey@amazon.de>
 <YgYmKiZaX2vZYgKP@Air-de-Roger>
 <85182aaf-1d3b-981a-1108-8eed79516893@suse.com>
 <YgY+sUOIaW7c3Mq2@Air-de-Roger>
 <717694b1-bcb9-b2cd-3740-71d8431a3058@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <717694b1-bcb9-b2cd-3740-71d8431a3058@suse.com>
X-ClientProxiedBy: LO4P123CA0152.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:188::13) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 3bc9843b-86e7-4345-6e91-08d9ed505f18
X-MS-TrafficTypeDiagnostic: BN6PR03MB2578:EE_
X-Microsoft-Antispam-PRVS: <BN6PR03MB2578CA29082B69BAB39F08A38F309@BN6PR03MB2578.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6108;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: SnDN3v3OnlGWFE0P/Y2IaBFoaClRV8NQOIJ+XBNiCmGY4CHqVubKb6fhLU3h1moZ4Ur2jK67wtpo0oq899XVNl0u08JrBTsnNfI8gTG0Rn2WTnTRb7LsiYrLfVAGryAfajwNHM9d5UPNBUCU+2digLrBZ/rg4Lcs4LnUtgHjxmNuO6FvoHaHIL8rbjTsOG8PXLFuC1/XHZenq22+55MsbjXBzvNJrLDhNwPrc/Kn/FAJD+sSR+fUwTxyc2d5FezUC/5iFEvoiIsP1x1ruHqzS+A5AY8zEquf8nFYDMGMNWVHtYWfax9YUn2csoWOsjeBCdpIaCzJOmDFHJ74mzmKVi5zXugMcbVThfIpoMZiZH8eJChShrPuOQCzktcBS3JSzo7aHeX1oguTJOWv6anDGv63Tp7LRHujCy1giYDT2Nqvxhp0PCKC/kTMKrgsrMaFjif4JZmTTWnXgcOPa1SyyNkzpiiDl2HTGJ6e6CTds7VVA43PYN34H35fXqISRsBnPK8amji1CxUN12bmOGe/4CmJKYo1aKxxV3BkS3EyNkmE3AXEkFlRCaMgeNY8KHwYa/BRxj/X36Au3G/8nIqplGrVCrPzgSxTTFF5vXJcYVx30X4hBuhO2GlueIYcEwP4g2Shs8iz7MMmRZIwvsjDRUIY4aoAJb6p0qmyfUYbU9UWhCf7A63FOUab7V8z7GJHcNObdGe34UoRFAIxAR9SGQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(66476007)(4326008)(66946007)(66556008)(508600001)(8936002)(6486002)(5660300002)(6512007)(6506007)(53546011)(8676002)(38100700002)(85182001)(6666004)(86362001)(2906002)(82960400001)(9686003)(6916009)(316002)(26005)(186003)(33716001)(54906003)(67856001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eHJaUURxTVdYL20zZUMvS3h3NFN2Q0dWSStCQ1RmZDg1c1EwMURvdE1ZSktq?=
 =?utf-8?B?Q0cwWkh2WTVDb21ZclZ3c1lDaDRuZ2xldDc4ekxqOFBSQ2N6OUJ2c0tvNytj?=
 =?utf-8?B?V09lL1BlZXlxcWdWR2ZCZ0J5YXlEQ1IwaUwrUTRQSnB3WWZrZEJHYTNiSnlL?=
 =?utf-8?B?S2lwRHJSeDZRbVhlS3Iyc0JjNzVjdVVJL0x5TlRtd09WaDJ2SFh4VmRBNzJm?=
 =?utf-8?B?VDFMNXhLeFNIcldFK0N3WTlpNk5naFBtVDBBRlNkMFB3cktBZGFjNVFMZk9s?=
 =?utf-8?B?TjRrUDQyMmF6ZlZRMWpIdFYzeUduVnZsNDg3anQ1V1RjRHNDU1dkN0haYTZI?=
 =?utf-8?B?Rkg0QmRudXoveEN6dFNqMVUrTzlQWjlvQWpaa3Z2MXJ5Rmo0eFo2T0Q3c2Rj?=
 =?utf-8?B?eEhnZDgzdExuV0IvbUNhMXM0VWtyWGpodHIxVlNJV0k0N1owYjRvSGpVelY4?=
 =?utf-8?B?OUhra1lBZ3RHVU5tbzhkMTd1bnFneXJxM3d3R2VvZ3ZQQ0NKbmZHbFI0bzZ3?=
 =?utf-8?B?eGNSbFpBUjdXNTdmbTYzUmd6TW9pUXhYRG4rOUl1SU9CbVBSMkE2d2hxQ3ZC?=
 =?utf-8?B?TGxYY0R1bEtHNWxIeHM4eEo4dEZzYnVlUHNlYTZ5b21jN2hhL0ZkT2VwUTRq?=
 =?utf-8?B?aVlGd3EvdCtqMWJ1MktoQnFHdGJybnBnOVQ5UkpxTmo2UzU3cWdTNlVCRzZa?=
 =?utf-8?B?WlJQVFpCOUNDZmcxZEtkNk5pWTBnanVpMmppWUdNSXc0amRBcVgvdHozeVRU?=
 =?utf-8?B?ekdYVndXN2dUOFFhd0xndHA4VE9qODJGZS9mcjRmdG05MXhzNDZ6MmcrQmpL?=
 =?utf-8?B?OUFoOTdrSEI4ZUcvZ2FtSTBVanprcGVEeFNRVFdPMWJVL015VVhONmpoOHc1?=
 =?utf-8?B?U2NjbThlQWJQNTV4Q1JtVWJzazQrMVBBRXBFN29YUlhJMUVZcGV6VThHT1N6?=
 =?utf-8?B?M0Q2enlnUThhZE1qb2tySXFhMVZQNFRQTm5hcWt0T1NmNmlVVjUzWE9Idklv?=
 =?utf-8?B?MTN6UENuSjdKMm1KMVdoU3RIU0k1dXk5RllqWTRzQ3ZROXN3L0RkS09IRmc1?=
 =?utf-8?B?Z09HaWtpQXVmNnlzWFB0Sit1RGg3M2REWEkvS1FjcEpGVG9tK2pXcEpJV0hS?=
 =?utf-8?B?WjVUMFExUjRqdDk5KzhNckFDOFdNODRtcnJvZWRnNFB0bE9yNEtSeVFpclpJ?=
 =?utf-8?B?b3hjVVV2QjFWR0x5VnFod0pqTEZmejVTREE5NHhoZW81OHl2S1JLeEUxRUor?=
 =?utf-8?B?VmxEN3o4RFM4VlRuU2MzQktFcEpsc1djK2h6TnQvN1VyVkpKeEx1R2toN1lS?=
 =?utf-8?B?MHp1ckQyV3NtMFVkQ04vYkYrKzZuaExKWXdvZS9URnc3L3A2bjFrRUJqd2Fl?=
 =?utf-8?B?aURKQ3dYZEMrY3FyaUdrVUswLzB2L0pnQ1VMSTBXYWV2clVVNGptTTVYZTlR?=
 =?utf-8?B?bGFCTUkrMmVwWS90UWdVdVRjaVp3SzZ3S0JEbkp1SzNrTlhTUmoxaGprV3c5?=
 =?utf-8?B?M1diaGloQUpyTkc5YW5wNGk2SVZFbVZiVHdKT1dITGZucGx5K3hsVjl0Z05y?=
 =?utf-8?B?OHY5WGJvaFhoQ2FZd2VQaTJMVlhpekNPMnAzeWRwZ0EwaWVrV3FIRXhTMXhY?=
 =?utf-8?B?VlpseHhVTWxNWWpWcTBTUEtZdlV3UXJaN0pZbUMwSU9Gb0ExaVNNWDhSUkdu?=
 =?utf-8?B?N0daOW5RWDFWelkreU1wMlh0TFdab1MvUlNSSlpnMFdibXZnMnpsOG8wbHQz?=
 =?utf-8?B?TWtqRkJKL092QkZ5cXpERG1ZYm1Qbm9DZldiV1N4Q0VscXRDWUdRYVJUSnh2?=
 =?utf-8?B?TngxbjJrZXI2QTdtZm9RUjJiSzRrTnpOTTNJVVlKVW9GN0R3ekU0M3lmY2kz?=
 =?utf-8?B?eGJpb1E0emwvQUh4QVZ5cmRrUmRaOHEvclcva1lyWSsvNFRrNXVrQjQ4UFM3?=
 =?utf-8?B?dHFyZGI3T2JGVXlmZWRWMElvdTdxTzNlKzZ6eC9tVndJN2hZbllmQXBEL3JY?=
 =?utf-8?B?eUY2Y0JlQUU5SmNSb2NCTUxyK2ZCQW1UZG1EWXJUd29WQVpuaEpwQVlKdUwr?=
 =?utf-8?B?VjBUL09jUWxkakR0b2xyQ0JJVEhyUG9aQ0YvT0NWQlF0aldKU0JHU29nWkFQ?=
 =?utf-8?B?VEZrREh5cTB2Mk5RVWRLOTVhQ2tSMmhjdGJ5OC96ODVwUlFzeUE1RU8xQ1I1?=
 =?utf-8?Q?vcm1c8rZEGLp5v92ECxBsWI=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 3bc9843b-86e7-4345-6e91-08d9ed505f18
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2022 11:19:30.0114
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: l7MCHuEyehJdY4f8zbEpf3EC7KCo+xWUVwQiHyiJkjoPWDHho4xL+cg7+RtoleXl/X64XwKzR/EbYcxbfCnm8g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2578
X-OriginatorOrg: citrix.com

On Fri, Feb 11, 2022 at 11:50:46AM +0100, Jan Beulich wrote:
> On 11.02.2022 11:47, Roger Pau Monné wrote:
> > On Fri, Feb 11, 2022 at 11:32:45AM +0100, Jan Beulich wrote:
> >> On 11.02.2022 10:02, Roger Pau Monné wrote:
> >>> On Fri, Feb 11, 2022 at 08:23:27AM +0100, Norbert Manthey wrote:
> >>>> When re-identifying CPU data, we might use uninitialized data when
> >>>> checking for the cache line property to adapt the cache
> >>>> alignment. The data that depends on this uninitialized read is
> >>>> currently not forwarded.
> >>>>
> >>>> To avoid problems in the future, initialize the data cpuinfo
> >>>> structure before re-identifying the CPU again.
> >>>>
> >>>> The trace to hit the uninitialized read reported by Coverity is:
> >>>>
> >>>> bool recheck_cpu_features(unsigned int cpu)
> >>>> ...
> >>>>     struct cpuinfo_x86 c;
> >>>>     ...
> >>>>     identify_cpu(&c);
> >>>>
> >>>> void identify_cpu(struct cpuinfo_x86 *c)
> >>>> ...
> >>>>     generic_identify(c)
> >>>>
> >>>> static void generic_identify(struct cpuinfo_x86 *c)
> >>>> ...
> >>>
> >>> Would it be more appropriate for generic_identify to also set
> >>> x86_cache_alignment like it's done in early_cpu_init?
> >>>
> >>> generic_identify already re-fetches a bunch of stuff that's also
> >>> set by early_cpu_init for the BSP.
> >>
> >> This would be an option, but how sure are you that there isn't
> >> (going to be) another field with similar properties? We better
> >> wouldn't require _everything_ to be re-filled in generic_identify().
> > 
> > So you think generic_identify should call into early_cpu_init, or even
> > split the cpuinfo_x86 filling done in early_cpu_init into a non-init
> > function that could be called by both generic_identify and
> > early_cpu_init?
> 
> No, I think it is quite fine for this to be a two-step process.

But it's not a two step process for all CPUs. It's a two step process
for the BSP, that will get it's cpuinfo filled by early_cpu_init
first, and then by identify_cpu. OTHO APs will only get the
information filled by identify_cpu.

Maybe APs don't care about having x86_cache_alignment correctly set?

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Feb 11 11:30:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 11:30:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270392.464664 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIU7g-00031h-0g; Fri, 11 Feb 2022 11:29:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270392.464664; Fri, 11 Feb 2022 11:29:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIU7f-00031a-Sj; Fri, 11 Feb 2022 11:29:55 +0000
Received: by outflank-mailman (input) for mailman id 270392;
 Fri, 11 Feb 2022 11:29:54 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=dFbI=S2=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nIU7e-00031U-8a
 for xen-devel@lists.xenproject.org; Fri, 11 Feb 2022 11:29:54 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ece52a88-8b2d-11ec-8f75-fffcc8bd4f1a;
 Fri, 11 Feb 2022 12:29:52 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ece52a88-8b2d-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644578991;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=9Qya4+/+BU1VQdN6RKeLt6CqIvd7S4iXX6Uw6kt8PwU=;
  b=VqJfYUsfJqxwWWG4ogWu9NfJFP5hrjeWWtRGdl9xPmEBAq3yMvYHFXUw
   idjJh0fHjJ4VHZraLTHl6lmTdbdntO80/3ONMVrc/tauFCPYA7ROEPwr1
   B5LQz7Tg3lUCZaUKOYPVR3smjw9l52xixGtsT7zBBnOjlgDcgyOLHkivO
   4=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: b8Xb08VznzKQ8NUkrPcSD9RQPyMagYaF9a7pK190uQDDe3wIxewPjYUr7IceTutxjwm6t19ttu
 D/rNncGK/bPCPQsNnR3z69wJY661YfgATKlcETW6j9ujQURVNNHbr5imsz9k2t8YfJDOQ/Awc0
 ONNwAHeOOMBAzkgQ442cDcCPwK7IadcFy3lIICR+r0qCe4Bl07ZWjtxXYsoDfqM3AnnQs2jAsO
 1ZKPYZtMUNIfCl4xj3gU24PNGKdKZ7wysNfj8LW7Xk4KZ3oNsjxDPw26rn+3Wy2R1+ZDaAzy8I
 8/431gnQhft3VwGczf7C8D03
X-SBRS: 5.1
X-MesageID: 64007852
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:GwWIVKj92PncSmYSC5WfySqiX161ERYKZh0ujC45NGQN5FlHY01je
 htvCz+OafmCZzTwedl1a47g9hhSu5fWyN9kHgFtqikzFyMb9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oAMKRCQ7InQLlbGILes1htZGEk0GE/NtTo5w7Rj2tQx2IDga++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /1oic2rEgV4fZfXs/VaDhtxSShuLI1/reqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHxO4wSoDd4xCzxBvc6W5HTBa7N4Le02R9u2pgWQqaDP
 aL1bxIxNDTBPjtVZ24RM6ARn6SJjUPPTxhX/Qf9Sa0fvDGIkV0ZPKLWGOTSftuGVMBEhHGyr
 2jN/3n6KhwCPdnZwj2Amlq3nfPGly7/XIMUFZW7++RsjVnVwXYcYDUcWEGnu/C/hgi7UshGN
 k0P0iM0qO4580nDZtrwQRy+5mKFtxg0WtxMHul84waIooLW/gDfAGEHRzxAbdUOtckqSDhs3
 ViM9/v5CDoqvLCLRHa18raPsSj0KSUTNXUFZyIPUU0C+daLiIM5gw/LT91jOLWoldCzEjb1q
 xiVqAAuirNVitQEv4254FTGjjSEtpXPCAkv6W3/XG2/6RhiTJW4fIHu4l/ehcusN67AEAPH5
 iJd3ZHDsqZeVvlhiRBhXs0oIOCyvPTUcwfHqk8oQpsIrT296l6aKNU4DC5FGG9lNcMNeDnMa
 UDVuB9M6JI7AEZGfZObcKrqVZ10kPGI+cDNE6mNM4EQOsQZmBqvoXk2DXN8yVwBh6TFfUsXH
 Z6AOfihAn8BYUiM5GrnHrxNuVPHK81X+I8yeXwZ50n/uVZ9TCTMIVvgDLdoRrpohE9jiF+Lm
 +uzz+PQl31ivBTWO0E7C7I7I1EQNmQcDpvrscFRfePrClM4RD18UaKOnul8ItQNc0FpegHgp
 CDVtqhwkgSXuJE6AV/SNiALhE3HAf6TUk7XzQRzZA31ihDPkK6k7bsFdotfQFXU3LcL8BKAd
 NFcI5/oKq0WElzvom1BBbGg/N0KXEn63mqmYnv6CAXTirY9HmQlDPe/JVCxnMTPZwLq3fYDT
 0qIiF+FH8pZGlgK4QS/QKvH8m5ddEM1wYpad0DJPsNSaAPr9o1rIDb2lfg5P4cHLhCr+9dQ/
 1/+7c4wqbafrokr3sPOgKzY/Y6lH/EnRhhRHnXB7KbwPi7fpzLxzYhFWeeOXDbcSGKrp/nyO
 bQLl6nxYK8dgVJHk4tgCLI3n6gw0MTi+u1BxQN+EXSVM1nyUuF8ImOL1NVkv7FWwuMLohO/X
 0+Co4EIObiANM7/PkQWIQ4pMraK2f0Ow2GA5vUpOkTqoiRw+ePfA0lVOhCNjg1bLad0b9x5k
 btw5pZO5lXm2BQwM9uAgiRFzEi2LyQNA/c9q5UXII73kQ53mFtMVoPRV33t65aVZtQSbkRze
 m2IhLDPjqh3z1bZdyZhDmDE2OdQiMhcuB1Oy1NedV2FlsCc260y1RxVtz82Uh5U3lNM1OcqY
 jpnMEh8JKOv+TZ0hZccAzDwSl8ZXBDJqFbsz1YplXHCSxj6X2PAG2QxJOKR8R1L6GlbZDVao
 OmVxWuNvewGpy0tMv/egXJYlsE=
IronPort-HdrOrdr: A9a23:FqaZaqu5VaK8xQK0KmduRR2b7skDEdV00zEX/kB9WHVpm62j+/
 xG885w6faZslYssRIb9uxoWpPwIk80nKQdieJ9AV7IZmfbUQWTTb2KKbGSoQHdJw==
X-IronPort-AV: E=Sophos;i="5.88,360,1635220800"; 
   d="scan'208";a="64007852"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XIT4GEGIJEEkxj+CXDezhcRqE6C1ARJIVLVGJJ4A8EEKPKqG9lTvmt+YGxozuKTBRKSEPmyhuDLjvgRJDPdroJxuvuepe6t8b5689/y/YhR3tstkMqjVKALp90KDv7uf7xqVShRgOIyptDNjYY2t8bq7EIeV9RecEQjjjs7CAk583NM4tId6sISww7H4tXNP2Ab86V7R7KThuETS73B+Gxe/1t0KpBPzAy+OauD9KWOCU3rj1GFPXpby1kfcQpUY+hfLIa5Ku73lygl+qKWeXuM1CIPgpn1MyEP6Hp6+sJxE5i6uazpW2MvJ23i1gIvEZd5ZPeNo1C84xkbYv3JgDg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=12gU3dD6aF/I0hChB/+yNcF8B+IPZx/hIu8NtiCGK/k=;
 b=Y+xbpkQyYkOMOfEX5PUVWxFO6FJX3zjwDuZ/j9Y9KeN6wV9XrETpAfoQ1e71Jux3FyYQ5a8Y9ISizRdbwX8xP3v11DjcAkUuD62GgqycyrZrOp06e5sS0gFDhQAPV8LlExWXLAEFwcapmU3loYystrweK9xbdNqJ2tdm687ofT/YjRb3hgiQBQhnxuq6hWzkf/Z4JJEb5glSKtzskzmxkkKfZhJJfwHcX//xa8+9wqrtkNjMXu1CE9VDiooNTn/JhMHby1AByPRAGG817baXdnTWo6OT0nTxKJ/LOv4ZjnBR0DpnYiZ/x728EjAr0XR2MGSZqLOGhjOVu1EHqXC9Zw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=12gU3dD6aF/I0hChB/+yNcF8B+IPZx/hIu8NtiCGK/k=;
 b=og2iYj586XeN07S0R2GfCe/9Ahf9VozTsUs2cv9JhN2CdJp0foQTZeXfJ5eE+yCtBGlXIojUszF5lEVW6Un95T5LBCGLVVy2dJr7SKkDKwvntE3WWWdIzgC268cGnjbfyqfQO6s7/q0K7gUsbohmki2Kc/5nGT8y9lwnJh3gphM=
Date: Fri, 11 Feb 2022 12:29:39 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jane Malalane <Jane.Malalane@citrix.com>, Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <Andrew.Cooper3@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>, Anthony
 Perard <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, George
 Dunlap <George.Dunlap@citrix.com>, Julien Grall <julien@xen.org>, Stefano
 Stabellini <sstabellini@kernel.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>,
	Jun Nakajima <jun.nakajima@intel.com>, Kevin Tian <kevin.tian@intel.com>
Subject: Re: [PATCH v2 1/2] xen+tools: Report Interrupt Controller
 Virtualization capabilities on x86
Message-ID: <YgZIo9VQktcqGHTD@Air-de-Roger>
References: <20220207182101.31941-1-jane.malalane@citrix.com>
 <20220207182101.31941-2-jane.malalane@citrix.com>
 <YgTi6bzeojtcu0xL@Air-de-Roger>
 <dff9c5c0-7bee-ce0d-3288-91255a701c99@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <dff9c5c0-7bee-ce0d-3288-91255a701c99@citrix.com>
X-ClientProxiedBy: LO4P123CA0480.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1a8::17) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e35cc484-7d6e-451d-c215-08d9ed51cd7e
X-MS-TrafficTypeDiagnostic: DM5PR03MB2908:EE_
X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
X-Microsoft-Antispam-PRVS: <DM5PR03MB2908EE0352F7500CEB7A0A628F309@DM5PR03MB2908.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: wLO6VbJQYG6ampgHp5sWNoGkz2sxvLIXOFbKyA0NUOR6pGiwaz8z/ue8Xc5OXbQVp9GMsggod4fMhFdgR5lta/BNVXV/ROCAyAR1hfO8cKO2z7yq9lzfLxbfSjmlioA6o9M1RS3u7LKYTZFza1tLTNpIJHYnxknuv+Tw/zPgWrWJdGQfYTed7M2NiYaiXz9bDE3sDhs8I1e3ChnhNL7NrBykZ3QDPwfadDJM5BTcU9gAS2ElggzR0KphPIBDwaTxi5qUw1Ef+cgnh19PBsorkuyhxNWVChjet6oag1kV4y2fW50V7mpM5ZQDsMj9SifRYmiAvuj1CGSe+HTVvQ12uUVBjYTlolERQC8iZZ54ME0HCOK+8RDxTVn8ipbjsI2ch1fBikizuiKrpCXwDIy0YtVNt71evSjhWOwKWUTRaasCuF+M5Yy+XZ4I6OtWz66uwqxtS46lI76XFU1yBsM7IS+NI/HsPwY9201w0P198oqykDKMK8CDjuxiQLZtKIsE7bv1+zcIAV0q1Lgs+t1D8JgUpUdp3pDeKwNkZWk3XJkG5yVfHzIQoOf5d+WGEOEsOVvJrzo+4TKP6nVHlptUsEALSQAprKdvcHBjCkvjDc/77I13njTuM58TamYc+WLX5+5gz+AMzDZWaWlXrSRa2g==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(33716001)(8676002)(26005)(186003)(83380400001)(9686003)(6512007)(6666004)(4326008)(8936002)(6506007)(66476007)(66556008)(66946007)(86362001)(5660300002)(53546011)(38100700002)(54906003)(508600001)(7416002)(110136005)(6486002)(82960400001)(316002)(6636002)(2906002)(85182001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aEVZLzExS21wVTFlS1pjMDVUamNWQ2F3NzFCK3pkVEpnbjRLNVdOYmMvRzN5?=
 =?utf-8?B?dWUrbTFmTU9CVktQK2JkejByKzd3WE4xWUZwTHUzUXdzd0RGUnFtR2E0SFIy?=
 =?utf-8?B?aXplMHhYV2p3N2R2Z2h3K2x6QngvR2pocEJub0lVZmk5VmthOUdVUjBqcnNw?=
 =?utf-8?B?b0NKbVZRelFoZXF1ckNhZzdOSjlZakdXSUxjcEVKQ3lWL1M1cTdMRjJrMTJR?=
 =?utf-8?B?K1RFYVdwRnpjZGQ2bURTaVpMa3dxR0N4bnhzQzNRaXdRbWNIZHNRS3hTY29q?=
 =?utf-8?B?ZDVVTkpHSlNSQURDL1VDV09HaG5PMXM2eVpSWlhZUXdkUEhTRGFkam1mY2pm?=
 =?utf-8?B?eUZSNlBIMm13SmJVdUN2blFjTlB2dEdSeWFicUlwTTZEZi9WSmJaVFhkdlQ1?=
 =?utf-8?B?dkJGU0ZvK0FWL1pXWCs4VjV0UURhakNtNjRvN3psZXRhbHRrekJhRTZoTnQ3?=
 =?utf-8?B?QnBPNEFJcG9sdGE5WjVNS2kzdUhNdkhMcm5LVG1ndWYzNWxaaFRzdWUxT1N6?=
 =?utf-8?B?YkF2a09TNHlvNWx2RHdaZ0tYQVJrMjFYOHVNem1XRUorQXB3WXRySUUvVUZY?=
 =?utf-8?B?eVEzT3BDYUNtWjRVWkE2eEZLL2F4M0VDamdVMFFpczlyWk5lb1BOSXEzQVR6?=
 =?utf-8?B?RVZ1VXl1THhZV3d4TVlRR3lURExDaFpvQ1R3Uzc4bzJOQ0o3bURsOWUzV0ph?=
 =?utf-8?B?VVJzaDZRVjFRODE0YUEwaU9Uc2M2T0ZaU1NWemowTlhCMnpQa3lPZDFrbnhl?=
 =?utf-8?B?RXY3UzAvRFBLcHBzTUMyakRQTU1Kdnc1NTNDeDJxc1hZc3owMHZFWVY4QVRt?=
 =?utf-8?B?T2phZWtpRHFpTGlRRE1zdjg5UE1iVEQ2TmthSDRZZmVxL2hmM1NDQ01PSE5p?=
 =?utf-8?B?WFBicVNpZCt2USttVm03NnZiNkhhUkUyRlJZOVpqU0dXeVJMTVZhTVZVOVd2?=
 =?utf-8?B?ZHN5Sm5kY2RrbmR3U2VLZVdJZVRrV0E1WVo3RlJKeXk0dG1hOUs2aHRiTHUx?=
 =?utf-8?B?YUU1dFdKNy9qeFRRNUdZRmNZK2xyWnh3RERVQjN6ZC9kQ25xaUN1Nll1MDNG?=
 =?utf-8?B?WGlpQ3U2eHhmZmZodzlmd0RUS0hlY1dxdkFFUk8wTVhtYzdBdVFHWU9GMXRP?=
 =?utf-8?B?cXVwM0dCNDFxYTQyUmNaajJHUlFGUUVlcVExbGorclVvZjg3bjQrMzRWUmNJ?=
 =?utf-8?B?cWUweFBzYmYxa25kNTJ2dlBFempzSkozZnJVdlRMQWxoWVcvdXc3N2ZIQnRq?=
 =?utf-8?B?cU1pSkNJb0dERFFiWjEwT3k5UXNhc28vVzI3bVZJNUpKbjdrai9vSEZGSEIz?=
 =?utf-8?B?MCtkQ1VkTEtqUldvcUFlK2NrWnNaVUxBMjQwOTdnUFArRHVTUm54QzlHdSt3?=
 =?utf-8?B?Q1lNSWFvQkdrU2VpYml0aUNEc0dWazVPSWpxQTVkWTFtbk9sQzBOb3NocnBr?=
 =?utf-8?B?SlY4SERiYTlIOGtteDdWUndPNmNGL3cxVjRjTktoT0pzWTd1U2VSWXU2a1Ba?=
 =?utf-8?B?V1BaSm5zbGRueUhFNkpYYndPV25JUmpHTlpydHd4R1RITXl3ZEFvTDY1WStM?=
 =?utf-8?B?S2tvVlZMa2hLRThnbldicWVuMUZGUjc5OVRnTmw2Y0VDYlJCZCtmYmN5Ky9n?=
 =?utf-8?B?M2d5bUZqeEtCRjlEbkxKd0t6Y1BDNDZTWWY2ajJwazRnemNrZStWTGdHUHJz?=
 =?utf-8?B?bnJpdjFXMlVsRDZaYnFaNHlsRENPTzZ2dlZ2cHRZVkZ0bi9JMFNiSVUzKzhK?=
 =?utf-8?B?cHN3TFZ6dUIvQ3hUY0VPZzFDT09mb0VSR1NYOE9WbVN3aXp3OEJtWDFpTTNt?=
 =?utf-8?B?Q0RoMTZRT0JZNUlySDdwdUI5Q3h2aWtKeGZBYTRBL3FKRUd2QVd1SlZNVzBJ?=
 =?utf-8?B?dWZUaXdwbUpabGJ5Q2syRUIrRUV4MFRROG9LQkd6anBjVjBYRkgzY3RFYnZy?=
 =?utf-8?B?aW5uRG5sVFVsQy9RdDNINmZyK2RHTS9hWFI4SFNkckl4QkRCMVRKWTNiNlJM?=
 =?utf-8?B?aWdBd0FKMU1IazUva25zWGo5TVkvdHpvTHh0dllMRTF1cG5ZbExVc012OWVE?=
 =?utf-8?B?ZWpObFRaN2RQWnJuWFAxOUxlRHpoRFl6cUFDNDJ4RlVrcFBYbllIc0JBWXIr?=
 =?utf-8?B?V3NUMjArU2FPWDZiSm8wQ2txSDdNaW9VYTI0c0ZWTm9WeVNRSG54VXhaS1ZQ?=
 =?utf-8?Q?qbGnMuvE9MA7znZi959ifI0=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e35cc484-7d6e-451d-c215-08d9ed51cd7e
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2022 11:29:44.6968
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LPSpEFyHbQfkjR2H2s0JR1FTTiuRQQcd66k+IWoNQD8a0UIhnp7BgOKP8Z/FRRjNYGOEHimfA3vCLxSV0vdmEw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2908
X-OriginatorOrg: citrix.com

On Fri, Feb 11, 2022 at 10:06:48AM +0000, Jane Malalane wrote:
> On 10/02/2022 10:03, Roger Pau Monné wrote:
> > On Mon, Feb 07, 2022 at 06:21:00PM +0000, Jane Malalane wrote:
> >> diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c
> >> index 7ab15e07a0..4060aef1bd 100644
> >> --- a/xen/arch/x86/hvm/vmx/vmcs.c
> >> +++ b/xen/arch/x86/hvm/vmx/vmcs.c
> >> @@ -343,6 +343,15 @@ static int vmx_init_vmcs_config(bool bsp)
> >>               MSR_IA32_VMX_PROCBASED_CTLS2, &mismatch);
> >>       }
> >>   
> >> +    /* Check whether hardware supports accelerated xapic and x2apic. */
> >> +    if ( bsp )
> >> +    {
> >> +        assisted_xapic_available = cpu_has_vmx_virtualize_apic_accesses;
> >> +        assisted_x2apic_available = (cpu_has_vmx_apic_reg_virt ||
> >> +                                     cpu_has_vmx_virtual_intr_delivery) &&
> >> +                                    cpu_has_vmx_virtualize_x2apic_mode;
> > 
> > I've been think about this, and it seems kind of asymmetric that for
> > xAPIC mode we report hw assisted support only with
> > virtualize_apic_accesses available, while for x2APIC we require
> > virtualize_x2apic_mode plus either apic_reg_virt or
> > virtual_intr_delivery.
> > 
> > I think we likely need to be more consistent here, and report hw
> > assisted x2APIC support as long as virtualize_x2apic_mode is
> > available.
> > 
> > This will likely have some effect on patch 2 also, as you will have to
> > adjust vmx_vlapic_msr_changed.
> > 
> > Thanks, Roger.
> 
> Any other thoughts on this? As on one hand it is asymmetric but also 
> there isn't much assistance with only virtualize_x2apic_mode set as, in 
> this case, a VM exit will be avoided only when trying to access the TPR 
> register.

I've been thinking about this, and reporting hardware assisted
x{2}APIC virtualization with just
SECONDARY_EXEC_VIRTUALIZE_APIC_ACCESSES or
SECONDARY_EXEC_VIRTUALIZE_X2APIC_MODE doesn't seem very helpful. While
those provide some assistance to the VMM in order to handle APIC
accesses, it will still require a trap into the hypervisor to handle
most of the accesses.

So maybe we should only report hardware assisted support when the
mentioned features are present together with
SECONDARY_EXEC_APIC_REGISTER_VIRT?

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Feb 11 11:37:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 11:37:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270399.464675 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIUF7-0004U6-R3; Fri, 11 Feb 2022 11:37:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270399.464675; Fri, 11 Feb 2022 11:37:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIUF7-0004Tz-My; Fri, 11 Feb 2022 11:37:37 +0000
Received: by outflank-mailman (input) for mailman id 270399;
 Fri, 11 Feb 2022 11:37:36 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=S5m1=S2=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nIUF5-0004Tt-Up
 for xen-devel@lists.xenproject.org; Fri, 11 Feb 2022 11:37:35 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 00305508-8b2f-11ec-8eb8-a37418f5ba1a;
 Fri, 11 Feb 2022 12:37:34 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 00305508-8b2f-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644579453;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=26khc7dGywFtIThPhk0sIzdIOIh0TJ1xvcNRrfHCh6o=;
  b=fcCx0FoQWjZfa5fKm/lt8TQn8vKT8XaIoxtKwz3q6jum64b7+AShbwvw
   giOK6k5Ki0zQKURdcmHlbqHjb1ZmaoOukfv77P6xh3iNSxf/Es2xlc6Ft
   vF3FFeO9DXEN5kqvnSoIf4U8I8bs98HlndqpFGmME01Inlwo2KScYOU+2
   Y=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: UCC40YeFMc/zhbTE+uQHwQe2OiaLG1LpmsJsEl0laqGkpCE5k5BwodoB8a3tJzA8ax7fJNt6GR
 sD8EjvmzyLUB75UuSXo2HTht9H6f61hXC03i3Rzwa0KOXbWv8iUKp2OLNotYeqeGtg/SUS5mOa
 vxcMmHihleBFcBR5j2pwDn/OdG4Mh4Uxxs39u5pa49HJCWBzQKLaEqYEEAEmXdFUREKBcG8Wrp
 2kZyOhad83/yE2LurZR5xCS81iqlW/3YgtYABN/Tt1Dz9eqKeFS3eE/0e8GYjZokh+37iEE7nL
 EFAhhc3upMNSUX6ny9Uop16K
X-SBRS: 5.1
X-MesageID: 64414836
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:BKLUj6z2kQJsvvY49nZ6t+fuwSrEfRIJ4+MujC+fZmUNrF6WrkUOz
 2ZJUGGAPf6KYzb2eIxwadni8U1V7JLXxoRlSgA+qyAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAhLeNYYH1500g7wbdg2tcAbeWRWGthh
 /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL
 wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt49J0
 9gX6YebcjwwOZWVwrsgdjVUIQgraMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr
 6ZBbmlQMFbT3Ipaw5riIgVoru0lINPmI8U0vXZ4wCuCJf0nXYrCU+PB4towMDIY2JwSRKqOP
 JRxhTxHV1PcR15iAAguAcgil+CVrCfZLRN4twfAzUYwyzeKl1EguFT3C/LKfvSaSMMTmVyXz
 krW8mK8DhwEOdi3zTue7mnqluLJhTn8Wo8ZCPu/7PECqF+Zy3EXCRYWfUCmuvT/gUm7M++zM
 GRNpHBo9/JrshX2EJ+tBHVUvUJooDZDY8FdSbEhwzq2063sulzGO00oQgxoPYlOWNANeRQm0
 VqAntXMDDNpsaGIRX/1yop4vQ9eKgBOczZcOHZsoR8tpoC6/dpt1k6nosNLTfbt5uAZDw0c1
 NxjQMIWo7wIxfAG2Kyglbwsq2L9/8OZJuLZC+i+Y45E0u+bTNP9D2BLwQKChRqlEGp/ZgPQ1
 JTjs5LAhN3i9bnXyESwrBwlRdlFHcqtPjzGmkJIFJI87Tmr8HPLVdkOvG0jfho2bZxZIGeBj
 KrvVeV5vs470JyCN/EfXm5MI55ykfiI+SrNCpg4keaikrAuLVTarUmClGab3nz3kVhErE3ME
 czzTCpYNl5DUf4P5GPvH481iOZ3rghjlTK7bc2qlHyPjOvBDEN5vJ9YaTNimMhit/jayOgUm
 v4CX/a3J+J3DrGgPHmNrNJ7wJJjBSFTOK0aYvd/L4arCgFnBHsgG7nWx7YgcJZihKNbiqHD+
 XTVZ6OS4ACXaaTvJVrYZ3Z9RqnoWJoj/3s3MTZ1ZQSj2mQ5YJbp56AaLsNlcb4i/e1l7Ph1U
 /haJJnQXqUREmzKq2YHcJ3wjI1+bxD31wiACDWoPWokdJl6Sg2XptK9Jlnz9DMDBzacvNclp
 +HyzRvSRJcOHlwwDMvfZP+14Um2uHwRxLB7U0fSe4EBc0Tw6ol6bSf2i6Zvcc0LLBzCwBqc1
 hqXXkhE9bWc/ddt/YCQ166eroqvH+9vJWZgHjHWveSsKC3X3mu/2oscAuyGSi/QCTHv86K4a
 OQLk/ylaK8bnExHupZXGqpwyf5s/MPmorJXw1g2HHjPaFj3WLpsLmPfgJtKv6xJgLRYpRG3S
 gSE/dwDYeeFP8bsEVgwIgs5b7vciaFIy2eKtfllcl/n4CJX/aacVRQANhaBvyVRMb9pPd532
 uwmosMXt1SyhxdC3gxqVcyIG7Bg9kA9bpg=
IronPort-HdrOrdr: A9a23:TXdSPa86kS6MaY3PB7luk+F8db1zdoMgy1knxilNoENuHfBwxv
 rDoB1E73LJYW4qKQwdcdDpAtjkfZtFnaQFr7X5To3SIDUO31HYbb2KjLGSjAEIfheRygcz79
 YYT0ETMqySMbE+t7eB3ODaKadh/DDkytHRuQ629R4EJmsKC52IrT0JcTpzencGHjWubqBJcK
 Z0k/A3wQZIDk5nCfhTaEN1PdTrlpnurtbLcBQGDxko5E2lljWz8oP3FBCew1M3Ty5P6a1Kyx
 mHryXJooGY992rwB7V0GHeq75MnsH699dFDMuQzuAINzTXjBqybogJYczBgNl1mpDr1L8Zqq
 iKn/4SBbU015oXRBDtnfLZ4Xil7N/p0Q679bbXuwq5nSWzfkNENyMIv/MmTvKe0Tt8gDg06t
 M644rS3aAnfC/ojWDz4cPFWAptkVfxqX0+kfQLh3gaSocGbqRNxLZvtn+9Pa1wVB4S0rpXW9
 WGzfuskMp+YBefdTTUr2NvyNujUjA6GQqHWFELvoiQ3yJNlH50wkMEzIhH901wuK4VWt1B/a
 DJI65onLZBQosfar98Hv4IRY+yBnbWSRzBPWqOKRDsFb0BOXjKt5nriY9Fqd2CadgN1t8/iZ
 7BWFRXuSo7fF/vE9SH2NlR/hXEUAyGLH3QIwFllu5EU5HHNcjW2By4OScTepGb0oYi6+XgKo
 OOBK4=
X-IronPort-AV: E=Sophos;i="5.88,360,1635220800"; 
   d="scan'208";a="64414836"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=QpgDSEEBwOu9cQdMxlZBcEE8AYjZhvvdn+8TePom3GJbp1jurJB/iUJct5rinDYY/vRDz69m5ggFCfKvuAXlGtZjbQfh5IqLYgIemYq7aSnhbhGsl7g8JRkOQV3DZ1rAF0L2K2uYATkk20dX5Y0sKwMPWODoy7U+sGIIqKfFGOj35t67ObcK5FfG8gvQOY5Y1clcxqPddgH38hwuuewE48ip2R6VSUdqCml8pvVwmG1Zhwp+Cs60zKNWyfScH6DEKafL0zzfRRDaAee8+HMg35ATmFgObW4Oz5ykqimZRO64koG9Rjpu5UjaQRJj1F1VmEE1BzhCagCgQ3lEpwAqfg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=26khc7dGywFtIThPhk0sIzdIOIh0TJ1xvcNRrfHCh6o=;
 b=NI4kjCFuOPIiMWe7gk9OTmnokVN6dSQzm1mfvyhZLtrzQEefaPucaU1pvBIWK7w9AYoYr7Dof/y4VdltDAF4/NG6TA08avWTe1baJsFv4Lj43ZBkH+KiKq/gh9kwr0Kp1HFBCsI72yu/Ys9OeptgOWy1sJBRjktZpYupSN9mTHds7g1nPBRvaunBxMwh4TbapXrNn8rC//ufXctKf2nydxuHfCbHbWHZLnL5HZcXhBIu0KAogmfnV21fHNiR5OtpK45ClfJHcjAMI2TyjkoV9ZWpL22lfEfA98VuDanoVCHvro0+xzStPF1N39AYBWucQ5Gs/WRv8DuVYHmZCral/g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=26khc7dGywFtIThPhk0sIzdIOIh0TJ1xvcNRrfHCh6o=;
 b=kwrnvx3Z4aGaymOKxm+a9XMTK2+Fty6LdvU4cOZWsAUjOEm7xjt+pT3Q3OxO9/1fXXRVIRhdkl4lbTEHXA4yMfUgNdq9WsWHDfR7+mXicm88cyRMpB9tE16EZ3dAfQQOsUINWAeZpe0xn046esY1kdIr7pDxqmkSSyplduliAJQ=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Wei Liu <wl@xen.org>, Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH] x86emul: work around gcc11 bug in SIMD tests
Thread-Topic: [PATCH] x86emul: work around gcc11 bug in SIMD tests
Thread-Index: AQHYHzbiiLtJAnQKXkmJAKoqDTbVn6yOOQ4A
Date: Fri, 11 Feb 2022 11:37:26 +0000
Message-ID: <a8d8ed37-174f-54da-5ddc-808e056140d5@citrix.com>
References: <83d3077d-76ad-b35f-4be0-5e968fbcae19@suse.com>
In-Reply-To: <83d3077d-76ad-b35f-4be0-5e968fbcae19@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 3e835b5b-55bd-4938-0140-08d9ed52e10e
x-ms-traffictypediagnostic: DS7PR03MB5637:EE_
x-microsoft-antispam-prvs: <DS7PR03MB5637E419D9CAC8DEC74CFD2BBA309@DS7PR03MB5637.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:2331;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: aOwpnPp9dUVstmvehS33REskQ+/+mm71knec7L/mB4P2USHe3klhSAsGSCKWQM+FZITpptbb3g7f35VC9y4Xo2IqnKTVWe25poL/Phr/WZLfpVvjiPsT2oXYQiIY44N6uMJe3zA3jOQhw1/hd0wjrwGp08jvsG2VE4x13dXzrCIHGiYyPMQlJY8zbrlQ9UcjjQzO457WlQIvZYpumbmQ1y5iH+abt4SaZ2DImuR1+nbwtdU/qPNPZKm8/6AwND+DL3Zi7Mrx4drQtmf6jMNto+xw0S9+JY9s/6C/Mun/uMvnPHJtFLE5SIiBjn0AOJLtquPEQXzSXxRAdjF3n17vJjyaGkXP8tZz5ZiYs0/fQU6wRVkiiZNIK22oe65yWDEtL6c6xkPw/NELxc/BUMK9YLs6cFa+RhHSggDkD2NkkQTUPM7hPW+AxUTvAnB/Njh43ceYYQngnNJl76Nh0s+JA3vvwDzDbbUmiml5/XOE/7UWoevi1UZNDNjh0rk3KGq/gjMCVhlWRWtysqmKeqxIBz5CULaxEAMO+b2a4maA+Keh3UheOdQOsxMmmeWpXErDOnbY+JZZqFXhq31D4/a4ov6gBaIU9VXCKw3aD6174lof4IXZO5giuOj8tPg80+jxGV2EwPUa7c0DtiCe5rUa9r64IW/GZklM2wRNvQ7IogL0OuMjfanFpqIdPCgWWA0P6EmRDy1SP/3Q7T3KS6rJcKFh86/KHfzP8jzrnRLVmSzdUb6e10h/6cK1/lqo+ngOcNIz4CRb+MYp+ROZK9ynkBb76aSDr7klzx9tJEzdZKvxo/hygrOO7HZk1YOtBVE/FNlTRK5OZQthPQhKpcDoBOoADWbfkS2bHmEOsYkat0A=
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(110136005)(38100700002)(54906003)(8676002)(508600001)(186003)(5660300002)(2906002)(66446008)(8936002)(53546011)(107886003)(316002)(26005)(2616005)(36756003)(91956017)(4326008)(66476007)(66946007)(76116006)(64756008)(66556008)(71200400001)(31696002)(86362001)(966005)(6506007)(82960400001)(6512007)(558084003)(6486002)(31686004)(38070700005)(122000001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?ejh3azN2NTVKT0dhNHhtS1VLdE1RMmhlSDRmWnVDNjVaYTVHRXJhZnN5amtV?=
 =?utf-8?B?d0o5dEtRNFFpNUoyWFExWjcrUDVPM3pNUkViMFBjQ0FnbUptWFRERks0YUIy?=
 =?utf-8?B?UEh3UjRxSzZyMTd2QVowSExOaUVTMEpFZER5VEsxQVdDLzZtNklraElaMXVo?=
 =?utf-8?B?UGNCbGFpY0l0alBJNlhMd2o3ZlNzd1ozREVGYUMyeFhuRHVpdGsvTjk3SWYw?=
 =?utf-8?B?Ty9ZYlZqdTdkQkF6YVQyWE1UZDNzbE5PamxqY3ZhM2tWdU1oVG5naS9YVzZp?=
 =?utf-8?B?R3NaK2RsbTdrL2tlOGZXeXcxQlBTUSt1ZW8vWEZyVVRXLzhreSt0cFJCdmRU?=
 =?utf-8?B?QWcwSFlPblh0ZzlTRk5nRnRPSGM3MENLbmluVm1LYzZqNVIyUk95OXFFWVRK?=
 =?utf-8?B?TjZIcVhPamFneG5BZmRxK2tpRStPOGpWZE9zcXZJTTIzeUEvTlFmWVJGdlNI?=
 =?utf-8?B?OG5MUzdvRGhjZEo2elN5WTBFVTNLMnI0Qy8wNGk0WjkxcC8rdUg5NzRqK1d4?=
 =?utf-8?B?dDg4NWkydklhOVZTRHcwY0o1UG1WSHkxWmxrbUt1UTg0WWpCc0p5YUR1TFV4?=
 =?utf-8?B?M1RydEJFY0NlR0dld2pSWktDazlsaXNad3I2ZEZQQi9GQkpkV0YrZHA5dHF4?=
 =?utf-8?B?dlFkUFh6YWxJOWJQRmxHL2pkUEc3OVFaVDg2TFRvVlFEZmI1RXIyZFJ6S290?=
 =?utf-8?B?SmNnTzF3Z1UyOGRoSUlHY0pzb1UzSVoxTXVsSW4vTE9nM0p3YkRPZ1lsUWdO?=
 =?utf-8?B?Rlk1Uzlmd0E1RHFlcmNaYUN1UHJ6RzhYZGhzNXJxYWR4V3pmT1N2ZXJweU9u?=
 =?utf-8?B?b0tTcVlXVzVLV2NVSyswL3BkV1V0YmlRMUl6dkFWaXpjd3VLcHN6QmxyditS?=
 =?utf-8?B?VVdGdXZONXF0NGRadHhueDFyVVN2aERlaG52SDNEM3UwTUFjNnc5R3N1TExH?=
 =?utf-8?B?U05zWkE3QUFQc2c1UTlBZVpuQ2huc0tROEt5QVZEand0R1VIMWM3eEVqVkFC?=
 =?utf-8?B?ZEQ5em8xOTU3QkxqeUZ4QmtWVzVuejI5R2pZMlUwRE11dFR1bTh5QzQxWUtK?=
 =?utf-8?B?cDBFQmRrdjV1ZU8yMjI3ejZSRUxvd3dSVmpFM1h0N2NsK2NEWkhtalFxczN2?=
 =?utf-8?B?UExGWDBCUnJDbVVHZS82UzZxMEFSdEYwU09kb28wazB2NmdkckQ4b29NSytS?=
 =?utf-8?B?U2g0bWFTTHg3MVp0ZVFGcjgxM2V2VmVCZDlWSnJDT2hUcHRHRThzQ1NnRjhz?=
 =?utf-8?B?M0hGWlNMRDd2SzVZZHc4NU5RSUJncXRRN3JXcXc1RzhmRTNhSDhKdEMyaDVT?=
 =?utf-8?B?NVk5M21YbUorOTBZQXIycFEyM24ya1V0UElIZnhDSlBRaGwveEVlNjVIbjJj?=
 =?utf-8?B?LzZJMFVHdG1WeDJWMXJnVzExYW5kUTRUb2V4bFpMT3NKcEljRXl0V1ZRZmxr?=
 =?utf-8?B?QS9DdW1mMHZFK1VWcytxTmdCS0tLTDVZSGF6b1VwV2ZPdzMrV0tiV3dnR3Fq?=
 =?utf-8?B?aXdGWWREcCtydG9PVTZ5RElDcTZJTlJuRXVmZ081MzhPbjlDWmlRaUxnOVFE?=
 =?utf-8?B?UktqSXdWejJvQVpiZHpQK1ZpKytIWGFIQ1FyUUxLeGtSaXFWNWw4VGJ3MEoz?=
 =?utf-8?B?cExBVzdaZ2ZZZ2hyU1VGelZjMklrRW8zWmdadEhsSkZoU1pDcUI0LzR2MEtq?=
 =?utf-8?B?eU5YMVV5bnNaM1BtWVMwOUhyVlgxb2pUQ09Jb0xFMnkxN040YnZpcG5RYnlu?=
 =?utf-8?B?TXpYcTZDdHVlZHdqdWM1UW5IMTNBWVpEOTFuUStsZkNWb0tXOGFzUkpja2ti?=
 =?utf-8?B?SDcydjVzTFBTRVpwelRKVFhGYVNTaSt3OFY2cGNxM0psVjhlVGRYWnV3Wm1h?=
 =?utf-8?B?a0wzUnJpMVZWZ041UHp0dEVabXNrWHJqUnZqTmVES0s0cGk2c1FEZ0tuZ3gv?=
 =?utf-8?B?ZGVmU0EzOHM1QUVIQS9xejRwWWFSNnhzMGpTV0lmUHVNMlJZOExFSUl3M29R?=
 =?utf-8?B?a0IzYlc2RmVWTTNtczNkNXBTc1p2N3U3QWxsZmdya0Y4d0h1UjQxODZ6UlVJ?=
 =?utf-8?B?Nk85cE1wN05CNWlLbGRGcEgrTldLYk1jVW5aSWJ3L1dYcTdmWlFZVTJOTkho?=
 =?utf-8?B?V2NKSThDeUsyckM0emUyU1MvMmo0dXRTbVZvY0Z1cHptampZTW5ON2J0TGMx?=
 =?utf-8?B?eUNMQ3VrV0pRUjFBQUZNMUVKdXkzYWp1UE94bVBjTmVhY3pSTUxWOGRCMkE5?=
 =?utf-8?B?MEdJb2dXcWRHV3YrRWxVNE5HLzRRPT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <5C60370E3BB81F41A507DF4D8D385CE0@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3e835b5b-55bd-4938-0140-08d9ed52e10e
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Feb 2022 11:37:26.7278
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: CvaaBVxQHc3TH9DPBh2RvF0gSGSUuZUyYBagkjMy+DgRi089xIdAK53R4obZc7/rKkydXIvxPCQQIe3VXj82fkVC/cilqYCM7zi75tZy5eo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5637
X-OriginatorOrg: citrix.com

T24gMTEvMDIvMjAyMiAxMTowMSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IEdjYzExIGxvb2tzIHRv
IGhhdmUgdHJvdWJsZSB3aXRoIGNvbmRpdGlvbmFsIGV4cHJlc3Npb25zIHVzZWQgd2l0aA0KPiB2
ZWN0b3Igb3BlcmFuZHM6IGh0dHBzOi8vZ2NjLmdudS5vcmcvYnVnemlsbGEvc2hvd19idWcuY2dp
P2lkPTEwNDQ5Ny4NCj4gUmVwbGFjZSB0d28gaW5zdGFuY2VzIGNhdXNpbmcgU0VHViB0aGVyZSBp
biBjZXJ0YWluIGNhc2VzLg0KPg0KPiBTaWduZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJldWxp
Y2hAc3VzZS5jb20+DQoNCkFja2VkLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0Bj
aXRyaXguY29tPg0K


From xen-devel-bounces@lists.xenproject.org Fri Feb 11 11:38:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 11:38:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270407.464685 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIUFy-00055X-7p; Fri, 11 Feb 2022 11:38:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270407.464685; Fri, 11 Feb 2022 11:38:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIUFy-00055Q-4s; Fri, 11 Feb 2022 11:38:30 +0000
Received: by outflank-mailman (input) for mailman id 270407;
 Fri, 11 Feb 2022 11:38:28 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=S5m1=S2=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nIUFw-0004wu-Gt
 for xen-devel@lists.xenproject.org; Fri, 11 Feb 2022 11:38:28 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1f9e73b6-8b2f-11ec-8f75-fffcc8bd4f1a;
 Fri, 11 Feb 2022 12:38:27 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1f9e73b6-8b2f-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644579507;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=YXk0ZG4Ek5wO5Lr4idXm6TDMoNzVbj19xURCRj5Jqcs=;
  b=M3y04fny+kpAQAwpG9MxMzH8RJgrISyCwKd43NxQe7+AJrXuC5/ENLv5
   aptF0rUB5djqCw4K1eu9UkBPNdDeivzPBLqcGiMOA8MtogiU878NksgMm
   uERr/mvfbm+CofT2tJVsyzCuH6MUxxK1uA2FzLW18Ue4DL++kmAm/OAHm
   k=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: L1x06YI5N3QXqOIRSaoEZcLOhhjNaumJ3ZF4nS61+IagDxTPf2zsRH/4wT6Cz9PqvUqbxALupq
 EKaJ71KWi4NpcGoKO5IPWahLCPejCpRMuozhx3lUT5PfgiFPmrdFpeK1XhqC+a4aH53sLnd7lC
 v8Usw/cW8a5HIKowX0O2rKzzZNDBWr+BO3YsvlkmKCelz2lZ/oSXK0rl0qtPARra5A0XZpua5E
 Vr2lT3vKz5+FCSvyM+0nRhDX2qwkjwRPKj9lIEW9lKllaJWCR9xP3RsEWOCKjiTr0ONyaU8oog
 XoyHxrxa5U6YLBhAyL2BI5L6
X-SBRS: 5.1
X-MesageID: 63913632
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:QCj+Oqv7G0w6wzS1zAqRspka2+fnVI9ZMUV32f8akzHdYApBsoF/q
 tZmKWzSaa6MMTb2eo90PY21oB8AvcTdn9MxHldrrCxhFXxH+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZQP0VOZigHtIQMsadUsxKbVIiGHdJZS5LwbZj2NYy2IHhWmthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 Nplj8aqVwgyIfz3wsNDVyRiPHpHLIdl0eqSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DFYUToHx/ixreCu4rW8vrSKTW/95Imjw3g6iiGN6AP
 JtAMmQ0NnwsZTVGAE0YM7wjk9yWg2DEVGBFhFi6q/U4tj27IAtZj+G2bYu9lsaxbdpRtlaVo
 CTB5WuRKgEXMpmTxCSI9lqoh/TThmXrVYQKDrq6+/V2xlqJyQQ7ChcbSF+6qvmRkVOlVpRUL
 El8x8Y1hfFsrgrxFIC7BkDm5i7f1vIBZzZOO9dg8h+C0bWF2Fy+WGw5dBEaUc0Ml+ZjEFTGy
 WS1t9/uADVutpicRnSc6qqYoFuOBMQFEYMRTXRaFFVYurEPtKl210uSFYg7TMZZm/WoQWmY/
 tyckMQpa1z/Z+Yv3r7zw13IiinESnPhHl9svVW/so5IA2pEiG+Zi26AtACzARVodt/xory9U
 J4swZn2AAcmV8/lqcB1aL9RdIxFHt7cWNEmvXZhHoM66xOm8GO5cIZb7VlWfRk1bpteJGC2O
 hKK4Wu9AaO/2lPwPMebhKrrVawXIVXIT4y5Bpg4kPISCnSOSON31H43PhPBt4wcuEMtjbs+K
 f+mnTWEVh4n5VBc5GPuHY81iOZzrghnnD+7bc2rnnyPjOvFDFbIGOhtDbd7Rr1ghE9yiF6Oq
 Ig32grj40g3bdASlQGJrdBNfQpXcRDWx/ne8qRqSwJKGSI/cEkJAP7N27IxPYtjmqVejODT+
 X+hHERfzTLCabfvc21ms1hvN+HiW4hRt3U+MXB+NFqkwSF7M42u8L0eZ908erx+rL5vyvt9T
 v8kfcScA6sQFmSbqmpFNZSt/pZ/cBmLhB6VO3b3ajYIYJM9FRfC/cXpf1Wz+XBWXDa3r8Y3v
 5apyhjfHcgYXw1nAcuPMKCvwlq9sGIzguV3W0eUcNBfdF+1qNphKjDrj+9xKMYJcE2Ryjyf3
 geQIBEZueiS/NNlrIiX3fiJ9t77HfF/E0xWG3jgwYy3bSSKrHC+xYJgUfqTeWyPXm3D56j/N
 /5eyOvxMaNbkQ8S4ZZ8Cbti0Yk3+8Dr++1B1g1hEXjGMwarB7dnLiXU1MVDrPQQlLpQuA/wU
 UOT4NhKf76OPZq9QlIWIQMkaMWF1O0VxWaOvahkfh2i6X8l5qeDXGVTIwKI2X5UI7ZCOY84x
 fss5ZwN4Aulhxt2atuLg0i4LYhXwqDsh0n/iqwnPQ==
IronPort-HdrOrdr: A9a23:qydnEKFR9XuIgqGOpLqFTJHXdLJyesId70hD6qkvc3Nom52j+/
 xGws536fatskdtZJkh8erwXZVp2RvnhNBICPoqTMuftW7dySqVxeBZnMTfKljbdREWmdQtrJ
 uIH5IOa+EYSGIK9/oSgzPIU+rIouP3iJxA7N22pxwGLGFXguNbnnxE426gYxdLrWJ9dP4E/e
 +nl6x6Tk2bCBMqh6qAdxs4dtmGg+eOuIPtYBYACRJiwhKJlymU5LnzFAXd9gsCUhtUqI1Ssl
 Ttokjc3OGOovu7whjT2yv49JJNgubszdNFGYilltUVEDPxkQylDb4RGYFq/QpF5d1H2mxa1+
 UkkC1QefibLEmhJ11dlCGdnzUIFgxes0MKh2Xo2kcL6vaJOw7SQ/Ax+76xNCGptnbI9esMoJ
 6ilQiixutqJAKFkyLn69fSURZ20kKyvHo5iOYWy2dSSI0EddZq3MYiFW5uYd899RjBmcsa+S
 hVfbXhzecTdUnfY2HSv2FpztDpVnMvHg2eSkxHvsCOyTBZkH1w0kNdnaUk7zs93YN4T4MB6/
 XPM6xumr0LRsgKbbhlDONERcesEGTCTR/FLWrXK1X6E6MMPW7LtvfMkfgIzfDvfIZNwIo5mZ
 zHXl8dvWkue1j2AcnLx5FP+gClehT1Yd0s8LAp23FUgMyPeFPbC1z1dLl1qbrSnxw2OLyvZ8
 qO
X-IronPort-AV: E=Sophos;i="5.88,360,1635220800"; 
   d="scan'208";a="63913632"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=T4n2Tym/KfmPYOjZOVt46zuCigRxS777BQw5zKq4ISO1QnPCPfBMeS0oTUrjPUldGEuPNTEfPGyrX531FCYiaYOUS7iLM2riqddaHd1rFS/ZElI2cQRi7JMTefZylin5MSymz8ng4mPPjcG88p3ZuqY+HmjXScgglbE3A6piZSkEpO8dVywUmo9s7u0Is1NgomIQluqdso137huRIJM/O9npgwuugGHGcr64EwqTq/3NrRW1M45838Lnom/15/idJUa8Q2Y9hhObefNNOPx/rPbYVERCaqzGoAvO+HGxQLTc8EaORT7bGybrVE0a+Mp+6wA+x1+JzNo5AfSo9iqqzg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=YXk0ZG4Ek5wO5Lr4idXm6TDMoNzVbj19xURCRj5Jqcs=;
 b=AcCRf1OYzoUUDQoedLxbIv+OtammMQaNjeJ7jCnJ4HFjR/5o1kqzsQOi/vt7MIpNqNxZ9hJTKbECQmDIoxTM6Q/QX+pw5vHGOC4vjlvMBP0hg4fXbFpcV0QXjhC7gX9lnYNbVsyz9xAz8B/nDNw2NW5omAyJ44ytOkZJ9g4vEIkKdd7wK+2ZTKnblnhdh3GG8pieq6UengijHZrhjwtZww0TDH+zKcr6KbYLzMiegE2Bo0JyM7fOrfClcHik0ezkSXBDvvv8xTN22R/XHnuTvjdadjQLnm+lNuH1GBTnFG2btvRjntXzRXxHPjoLMdPafgHMN5y9mUjVEIlOoNhM6Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=YXk0ZG4Ek5wO5Lr4idXm6TDMoNzVbj19xURCRj5Jqcs=;
 b=YUPgN9/zH78QZlGesoRnt0q0eX82ZLijgTjY1bFLMHr0tgpARRSKEKjJieDis/aSx5acnHpcTLDM+5OqBXMUwIV4Ct7DU+bYerxdisNx1lxTfp7k0+8s7oP1Ef04I6aSmfeHx1pYgTcVPZ5pQhde7A7zZHGIhv7lButtdDdI8yg=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Wei Liu <wl@xen.org>, Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH] x86emul: fix SIMD test overriding of VBROADCASTS{S,D}
Thread-Topic: [PATCH] x86emul: fix SIMD test overriding of VBROADCASTS{S,D}
Thread-Index: AQHYHzgi7QaKSip3EUKHXqmfR27DHKyOOU2A
Date: Fri, 11 Feb 2022 11:38:21 +0000
Message-ID: <fb157cd2-4a46-af5d-3780-16e4eaa0e3ef@citrix.com>
References: <0519c820-f1ee-1b37-f1be-90bd1daf37ed@suse.com>
In-Reply-To: <0519c820-f1ee-1b37-f1be-90bd1daf37ed@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 08c10de9-00e2-4873-9599-08d9ed5301af
x-ms-traffictypediagnostic: DS7PR03MB5637:EE_
x-microsoft-antispam-prvs: <DS7PR03MB5637D572E94E01A8F89BEAFFBA309@DS7PR03MB5637.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:3631;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: NxAKVyqUl+r2weRRVlP1RqMCb2h2df6cs597odg944KY7kv9NOhaSR/HkaNMB25sPLG1B/QISOm6eg0b0qhvCyYUYRvyJMJwptbX46/n2VJWzILDKCYDRYzb6HcYIXFFpAsxLaS97bZD8TYb3k5jLksoXNHJHOkGMX8kYdTb239QVEL5tMft7doomfxgVj4W/Ku8Qk7z+c1aNOG3DltMehXp+uJK5nysmxXfNs5qA5HMwCmTcad8eWj5UrNkF74ycP3lZzzySkRNX468A+F7Fn+kzGGYBKMeVjeXvmo5DF0nYBjjnsQrKavyy2rWrGu+043AdbEgtNO7j+uKdoNRS47B2Gd78iTKQqmfGizJnZt0GxDToqLf2B0l1JlU6DW7kEqrAOM+yhQL4DDsBYFdGCG+/0NtJSfId+GOhaD7EgQav+0c4aU8sa+KzTt4/HgJnr2SmnvN9HJMSilw07VqbTrs+OWKruZVfyANeKzwbf/W67jJw8fIWVe0xxEpsaViN22L05gUo0+pNtqwAsxubdx6l+7YJAp0jdhPVF7Y/yREB2+2Kf5+9VKKK6ZV7vFHcSU5lSjhn1sVSUvgG611V9SnmWfhBiVthR7UMzRnOGUA9bMAAuD/k5lq3XaIkgNDK7Rsta3oa/Mzht7Qlys+qmDupGHhXYRI5WFB8Uh8V6vuTFyM//uJCw5UJxO4XIvBqkjQscjKPDf7BkYfY58ak8RlNBeGtH76cg1MPNIP16KrcaVHfaQMXSkMiV7UheIovW3jNph3rNXWmfDZutr/0g==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(110136005)(38100700002)(54906003)(8676002)(508600001)(186003)(5660300002)(2906002)(66446008)(8936002)(53546011)(107886003)(316002)(26005)(2616005)(36756003)(91956017)(4326008)(66476007)(66946007)(76116006)(64756008)(66556008)(71200400001)(31696002)(86362001)(6506007)(82960400001)(6512007)(558084003)(6486002)(31686004)(38070700005)(122000001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?RVpOa2t4WmVGdVozZ2NqRFNQdGx6cjhDcFpCWklDU0piZEJ4Q09yNW1XVGJa?=
 =?utf-8?B?cnRLNi9TTTZRdWlLdnZCSTBEZ0ZpeXNUaTRtTTNNeitzSkdYaWtPM3FaQ1Bw?=
 =?utf-8?B?Sm00Nmd1Y0Y3ejd6blJxV1VTVVNSSU5hVXVrSVpwb0pxYStJa1grYVVSREl6?=
 =?utf-8?B?OVpzR2RvNkIwRlE2ajJka0JyUXZ1cmZWcFVCYit0eFV3b2tzRDVJdFJmMHhv?=
 =?utf-8?B?TkdXUmw4eEMxRTRiY0NNVW9DTENFQldQMkRSNWZ0Z1V2UWg4bHU0aXNsVndE?=
 =?utf-8?B?Vmt5S280eG5vV1Z3T0cvY1ErVmt1Mis5R2tmalJVUUxiOFRVaGx4b1ljcHlx?=
 =?utf-8?B?cWo5cVAzL04zUDc1ZlI0eG5TU1Bxa1l0SWRKZFZBdTgwS1plZ3dKUnphU01z?=
 =?utf-8?B?SVJ4Y1NzSVU0QzVqL2RkSURMbFdLV2Z4Q0FIdG1ndktxNHFwUzM1SnJYQXc3?=
 =?utf-8?B?dmc5RmhmVFNCamp1bEIveDBNelEyVXFneWtoWXEyV0REWGc2Y1dxR3lpc2Nj?=
 =?utf-8?B?Z1VWZW9oWGxUaXRTSGIwWlFpRjhmaXJJZldFblNNb2FKOFpNbWJZVzZEbWd2?=
 =?utf-8?B?UGoyWUZXSitMaFA1TGdvak9PcHIwcTRDci9QTGV6Q1BHTWJEeHUvTUR2VkEv?=
 =?utf-8?B?Y1JUaEpnNDk1V1MwdDY1KzJpc3ZaSEFMaDhXMWxIWmxwUFN3U0tCNE84Vml2?=
 =?utf-8?B?bkJxcHA3OGNydlY4bGY3a3dNQjBxeXFBbUxyMEh4OXVVN21PRUpCTnZqYUZj?=
 =?utf-8?B?MGJFTkVQbFBTWjVzekFtWmZQY0RnV1dBQ0pKcllINEJXaHhkMVVYOTFpZ1F2?=
 =?utf-8?B?Q2x6aDNxY3BsSWNodkRZZG1MVmNwK2tyeUN1UmVMdHArZlY3cE5QWTRQMTkr?=
 =?utf-8?B?TVBQS0pReEx0N21xNXhBa2k5QWZ6TXNVZUl5cWJoODJPaGt1dm5vMDhNVmdM?=
 =?utf-8?B?bkdibTZyZ2pWbThVZVl1WXR4YTRvd3B6dEtCcTZCdTQyeGFpL1AzMHl4U2Z1?=
 =?utf-8?B?Rm9aYjNoZ0IwQnVzVDZ5VTgxRUlEK0hJaGFBQlZJeThWM0pobXc4NHZ0d0k4?=
 =?utf-8?B?Y3NpQVVrYUZyaDJndHNxR0xObzdVRnptRllwSHhTOTljd2Q4TWdMaDZlYjRx?=
 =?utf-8?B?SmVaK2ExMUdyMFpISTRBKy9KZDNINEtGQk10VklVL2VvbzkyZU82WDFXZXh4?=
 =?utf-8?B?bFM0Vy9HRVI1TTFINzhIQVZsMkEvWXZ0ZnVuUFN5c21DMW9ndkY2UkpZeThW?=
 =?utf-8?B?ZFlqMWx6aFZzbTJUZ0FWb0paUEZLYm5pdHhrYTJnMURnWDdDUkdMMVpTbGhC?=
 =?utf-8?B?K3A0aGlXTTZpZ1hYL2lZUCttNGJ6VUJjNFEyZXZKVE5VTWRnZzZxVFNubFpG?=
 =?utf-8?B?THQ4bTJDU0xNYVdVT1Mxb3lvb2dIa1ljazM3ZVFicTRwN3laSk9kbFZQYkh6?=
 =?utf-8?B?SytJVDBMUGdkaTZVeUpEeXBHNW1ISXRzenRZQWoza2svVks4cExJUUp4eTVS?=
 =?utf-8?B?aHY2VmN0MU9JYzlUWVZiNHRGNjY2N2p6YXhwYy9sT1pIUU5VT2lteU5jalBT?=
 =?utf-8?B?THg1SnNmYUJ0b0pEbWRPVUxjeExHOENQOHM0SW9wUUlpWW1FT3VZc1NQQ2Jh?=
 =?utf-8?B?RnhoSllEK2RodDBSQnQrdVVkcXUzL21hUStKUWI2eTJqZWt3bjhtQ2ZmblpH?=
 =?utf-8?B?OGFDamJ6UUJIVkRtMkVJSDE2aHdiVHJrdzV6blRUVFhwOVNCbTQ5ZmZoaWNx?=
 =?utf-8?B?aUlCS01GRFhHUlVUZzB4bFpJRXh0RGJYaEtqbVVXWHpFdkxia21tMmh5SHRG?=
 =?utf-8?B?UGpNSXJHNm9POS8rNlpTMW11Q2xZUHVtLzRxS2VoT205S0RSdlNQdzRocG5k?=
 =?utf-8?B?RUl2ZVNvVkZFeCticjJaUVVGTEQ3Umo2aEhUZlNWRHJEZk9raHdrRmpyRWJI?=
 =?utf-8?B?aHBBTXp4Tm5ZZUdEbVp0d280UmFMcGhlcm1XNlVZWU96US9ISUNpWHpmamxR?=
 =?utf-8?B?VjZUSUlQbGV4bDNnaHc1d1pON1lQV1dweElWZitjblY0OS9WVUk2Tk94VjJN?=
 =?utf-8?B?YnlrYjhvdjQ2UzB6SXExaUs1TnZCd1lqak9yQWIvcmRQYTAyZEM1WWwwbmpP?=
 =?utf-8?B?azhNeXB6RytqNnEzaXpUbVloTWxRTm13RlkzbENVR0dodWNTSVFFdC82anpK?=
 =?utf-8?B?akY1VTBNSTJaQ1NEckNyM1NLaWVZVjdrMlBOdFBPNjBsbTZKMCtRS0kzUS9k?=
 =?utf-8?B?RXNncm02VVFTVHgyc0hoWnViSzJBPT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <61F9C0C6A8787348B299B7A40A221A9C@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 08c10de9-00e2-4873-9599-08d9ed5301af
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Feb 2022 11:38:21.4738
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: RtSOmTUoJAFMuMuxFy5kLkUJmewYPLvcKz5zhLpi5DSGJ76qr91uqGRCsIllAM2A8A1ASYpO7A+VwymHnlHL2p0nCUu9K4dAK4poZHrzvrY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5637
X-OriginatorOrg: citrix.com

T24gMTEvMDIvMjAyMiAxMToxMSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IERlc3BpdGUgdGhlaXIg
c3VmZml4ZXMgdGhlc2UgYXJlbid0IHNjYWxhciBpbnN0cnVjdGlvbnMsIGFuZCBoZW5jZSB0aGUN
Cj4gMTI4LSBhbmQgMjU2LWJpdCBFVkVYIGZvcm1zIG1heSBub3QgYmUgdXNlZCB3aXRob3V0IEFW
WDUxMlZMLiBHY2MxMSBlbmRzDQo+IHVwIGdlbmVyYXRpbmcgc3VjaCBpbnN0YW5jZXMgZm9yIHNp
bWQtc2cuYy4NCj4NCj4gU2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2Uu
Y29tPg0KDQpBY2tlZC1ieTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv
bT4NCg==


From xen-devel-bounces@lists.xenproject.org Fri Feb 11 11:40:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 11:40:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270415.464697 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIUHd-0006SY-KT; Fri, 11 Feb 2022 11:40:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270415.464697; Fri, 11 Feb 2022 11:40:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIUHd-0006SR-Gz; Fri, 11 Feb 2022 11:40:13 +0000
Received: by outflank-mailman (input) for mailman id 270415;
 Fri, 11 Feb 2022 11:40:12 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=dFbI=S2=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nIUHb-0006SJ-TT
 for xen-devel@lists.xenproject.org; Fri, 11 Feb 2022 11:40:12 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5cba7a2d-8b2f-11ec-8eb8-a37418f5ba1a;
 Fri, 11 Feb 2022 12:40:09 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5cba7a2d-8b2f-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644579609;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=0m4hF9xQsEb/cBEDuVUNVhY5NgilRTh0c7SxCggoh30=;
  b=NWyUXd7gP/ZvBC9Z62UGzK5ybxTjHZwj46YiQtS0L9dYIOWVPgV5fy6w
   4Gfrx9eyHeZSM1iQ5dZ+w8E5CGy1FX0XfXWLMIwsoKr/b+oiDHkMxVssP
   4+0PaTi6JIbxNugzNVqdXE37L4Nrk11py1IY2woPMArKtFuf4aqiHtAEo
   o=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: t9UxLRNYCtq6mURdsbkDvB4mWMrz6zVC7yt0T02Q480gnsUmJN0w4mX3/GONbDNMt1fFfHNBqB
 mU5hsrT54m0Qnu8mQczfblxx13A0w8DnaxI+/xN2Bwljl+Utzq2qzThB9TuDyJdazdN6fGVpfB
 WIf711MyMf08ZsHMr4nk56w50f6JrKL/lq38WbBkASior7yTHV3SK8/mn9ys+qf0mnvFkrHLS2
 3Fu36rl/RXMPKNNm+F/W4xLwI0DnfRb9yiWIRp+R/zyP9J55ByO5jqbyvODV6Z8V1zvRaBpdFu
 h+tLpWCnDO62/uXXkw8MNO70
X-SBRS: 5.1
X-MesageID: 63454880
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:0m978K/40JXcILu0Y2VpDrUDkniTJUtcMsCJ2f8bNWPcYEJGY0x3x
 zMXUD2CM/qMM2bzKdAgbdy/oBhS7cLSztYwSQdkris8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhFWeIdA970Ug5w7Rg29Yx6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhU+
 fxGjbi3cTskI/31iPswXgZZN3phaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguw5K8bmJsUHs2xIxjDFF/c2B5vERs0m4PcGh2tt2pAeRZ4yY
 eITdyt9Qw/QeCZkN3QYBZg1vtW6nWHWJmgwRFW9+vNsvjm7IBZK+IbqNN3Za9mbX/J/l0yTp
 n/F12nhCxRcP9uaoRKi9n+vnebJkTnMZJMJFLa4+/hph3We3mUWThYRUDOTiOOlh0uJfsNQI
 k0Z5AIjtaE3skesS7HVRRS4vXrCpR8aVNp4Gvc/rgqKz8L86QuDGnINSDIHbdU8rdI3XhQjz
 FrPlNTsbRR/vbvQRX+D+7O8qTKpJTNTPWIEfTUDTwYO/5/kuo5bpjXLQ9V4Gai5lOrcHz3q3
 iuKpygzgbYUpcMT3qD99lfC6xqurJXUSg8+5i3MQ3moqAh+YeaNfJe04FLW6fJBKoexTVSbu
 nUA3c+E44gmD4yJlSGLaPUAGveu/fntDdHHqQcxRd97rW3roiP9O9ALiN1jGKt3GuM1UDTRR
 EjrhQ5MtKZDI1ancq5TOJ3kXqzG0pPcPdjiU/nVaP9HbZ5waBKL8UlSWKKA44z+uBNyyP9iY
 P93Ze7pVC9HUvo/kFJaUs9AiedD+8wo+Y/EqXkXJTyD2KHWWnOaQKxt3LCmPrFgt/PsTOk4H
 r9i2yq2J/d3DbWWjsr/q9d7wbU2wZ4TX8GeRyt/LLDrH+aeMDt9Y8I9OJt4E2Cfo4xbl/3T4
 la2UVJCxVz0iBXvcFvWNi05NeywB8sm9RrX2BDA237yihDPhq71ss8im2YfJ+F7pISPM9YoJ
 xX6RylwKqsWEWmWk9jsRZL8sJZjZHyWafGmZEKYjMwEV8c4HWTho4a8FiO2rXVmJnfn5KMW/
 uz7viuGEMVreuiXJJuPAB5Z5wjq5iZ1dSMbdxagH+S/j22yrNY0e3as0pfa4agkcH3++9dT7
 C7PaT8wrujRuY4ltt7PgKGPtYCyFOViWEFdGgHmAXyebEE2J0Kvnt1NVvimZzfYWD+m8amuf
 7wNnfr9LOcGjBBBtI8lS+Rnyqc35t3Oob5Gz1s7QCWXPgrzUr4wcGOb2cRvt7FWwuMLswWBR
 U/SqMJRPq+EOZ25HQdJdhYldOmKydodhiLWsaYuOEz/6SIupOiHXExeMgOikitYKLcpYoopz
 f144Jwd6hCliwpsOdGD13gG+2OJJ30GcqMmqpBFX9O71lt1kglPOMWOBDX37ZeDb8R3HnMre
 jLE1rDfg7l8x1bZdyZhH3b6wucA148FvwpHzQFeKg3RyMbFnPI+wDZY7S8zElZO1hxC3u9+Z
 jprOklyKfnc9jtknpEeDWWlGgUHDxyF4E3hjVAOkTSBHUWvU2XMKkw7OPqMox9Foz4NIGAD8
 eHK0nvhXBbrYNr1j3k7VkNSovD+ScB8q1/Zk8e9EsXZR5Q3bFIJWEN1ibbkf/c/Pf4MuQ==
IronPort-HdrOrdr: A9a23:MGJsSqyJmHb8zg8WeoxgKrPxiOskLtp133Aq2lEZdPULSKOlfp
 GV8MjziyWYtN9IYgBcpTiBUJPwJE81bfZOkMcs1MSZLXXbUQyTXcBfBOrZsnLd8kjFmNK1up
 0QCpSWZOeAbmSSyPyKmjVQcOxQgOVvkprY/ds2pk0FJWoBCsFdBkVCe32m+yVNNVN77PECZf
 6hD7981lydkAMsH6OG7xc+Lor+juyOsKijTQ8NBhYh5gXLpyiv8qTGHx+R2Qpbey9TwJ85mF
 K10DDR1+GGibWW2xXc32jc49B9g9360OZOA8SKl4w8NijssAC1f45sMofy/gzd4dvfrWrCou
 O85CvIDP4DrU85uVvF+CcF7jOQlArGLUWSkWNwz0GT+vARDwhKdPapzbgpDCcxrXBQ4e2UmZ
 g7r15w/fBsfGL9tTW46N7SWx5wkE2o5XIkjO4IlnRaFZATcblLsOUkjQlo+bo7bWrHAbocYa
 JT5QDnlYJrWELfa2qcsnhkwdSqUHh2FhCaQlIassjQ1zRNhnh2w0YR2cRaxx47hd4AYogB4/
 6BPrVjlblIQMNTZaVhBP0ZSc/yDmDWWxrDPG+bPFyiHqAaPHDGrYLx/dwOlayXUY1NyIF3lI
 XKUVteu2J3c0XyCdeW1JkO6RzJSHXVZ0Wl9iif3ekOhlTRfsuYDcSzciFYryL7mYRtPiTyYY
 fHBK5r
X-IronPort-AV: E=Sophos;i="5.88,360,1635220800"; 
   d="scan'208";a="63454880"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=fzio09cVLTvCH1jQz7xFJiY0q5MvRnievUhL/HJYqUoQkvk5slpmi5raW1R5hDLIa1SOwB666lREPAmpniG2zxw0c0YeZljjmuiGIqy9C9lSu3YovODWS84fDAOyqMoxd/kxIkXbj7LrAVFOIrnwQrHuhCuv7UBtvJIZVPnXowrSHgMJFh8ZytA46ISY9TL5UTkJQY0zPbA/IaL2gUkvi8lDmQDVBF5n8mzngIOKPpoVQEXFFcsdVNMh4m7+vz1Ad2keVbn5I7vqmeH2qAyLZtu41Jgj6hmcMmi4si7saP8Hl3Jz85ypblvY0nqc8DPc1BTgGVfZftgFXkcY1K1Sbw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=GhEqp8JLPp0ZrWvMW0UOYxMzPylgA9nxtDTn5hBjpZY=;
 b=ZuZYdJnuygGzYaw4t4BsrX+lYDFO0XeJLjFEAW/FAwVCNnWqHnDIO+2A2CyEa+6flIhkE/SM4fVmP+5LhamarGzVV/diln1sI4t+QBa1if7ifKYoGn4iCgerSn5xkGJURIIKSMsIgzQa1t6hJtBPn4i4rTAq7aksDwsIJgZ+8aPuFXF3tf96NgIt8v5HzkDvFW+F3ib0IU/qed3FX6P+uw4AjOSW7fOjn/APxOnVn8F18momdqmrvw+5TN+HG4MHPypJnZTywURiqETzTNrLLMbxOQhpzd/jP5VOf0y1kp9QL2SEUtZrkRU/IVTese0/ILDeLTPYvWaBV6PsI5Id+Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=GhEqp8JLPp0ZrWvMW0UOYxMzPylgA9nxtDTn5hBjpZY=;
 b=uqybv1MoDgixlKgd1RksagnWz1uWEtlYZypxsFYOxupjzEeW79o6g/7eYFodH9lru2yUAgy0DjeT/Axh5MkymobDiku1GPRjEreVKPdfDPU29qgMIMhsnDgf9MoPwpJkC7P+bk0MlNvlBMihp7un88TcazvwpFAbLC7RsV2zsa8=
Date: Fri, 11 Feb 2022 12:40:00 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"jbeulich@suse.com" <jbeulich@suse.com>, "julien@xen.org" <julien@xen.org>,
	"sstabellini@kernel.org" <sstabellini@kernel.org>, Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Artem Mygaiev <Artem_Mygaiev@epam.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>, Rahul Singh
	<rahul.singh@arm.com>
Subject: Re: [PATCH] vpci: introduce per-domain lock to protect vpci structure
Message-ID: <YgZLEMW9US9QjjYG@Air-de-Roger>
References: <20220209133627.959649-1-andr2000@gmail.com>
 <YgU6Snk8GTytJXZp@Air-de-Roger>
 <c4666570-666e-6680-5ec2-adf1da51ad06@epam.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <c4666570-666e-6680-5ec2-adf1da51ad06@epam.com>
X-ClientProxiedBy: LO2P265CA0491.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:13a::16) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b035ff4f-ff0d-4e44-fa02-08d9ed533ed9
X-MS-TrafficTypeDiagnostic: DS7PR03MB5655:EE_
X-Microsoft-Antispam-PRVS: <DS7PR03MB5655EF32D78836B3F618B2FD8F309@DS7PR03MB5655.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 5EURhCTzzJWpY7BhYV+R++ig1bMxl0+QOOH/k/YRWshaP8HRm5ghcr2coXJUXvP7VUsX3HZdxBzAC4bx+O+oGnI5HDqUK0O4Za+wyWuxJ4Vwff+ECb1TVSSjMvqjIOqZsLMhaW/bh1WOeItFNsgTdl1g2fBZdqUBuSt04wf4qPeoIGI/uzmZG/gj/9o9ItKeS9Pb0YHzJzq0G91fhsq1QF3FkJE25DsdKehxFixU6A2cLK+Q3o0t9q5VZwkAJcy3aZ9umGgTM3356pCP5R/3WZLldfCLmyrcY3H6AdcwH2nq30xcGnE8R2x8qDDqDlDwl17ldIXmuLrEd4DiMw24auKBFUyHJRCmxgv3pv2G6JNbyOu6M9POkksgjioLwa0FnLY5g8bDuka2V2TBfTvI+2Fi9YApOyVcwQ3j+NIbPb3J8Kajr9ZOC09QeWbA6p2TJv5q3sITZpLQ0TzgLyPwzZDr9Nu31W4uFNXSy6cLDxJWK/qLSEfjqBp/hZPJ1WoJ3yqVTqk9a970xyEJO/hLEyZwa5zbeLdEEMe8/jgGTsv1BKLMM9QU64BnqBR9rmnkvYaJqJ614IWtwSVFp9f0T27YNqJwLJm4TmZB/8zY/6YXOJizgSAVpL4MYitFfj5EOnONy0Smt1cAVlifvr6h4dV80dLQGqafdZJj3hQ6CgwiIfxC38KbbHnvzzoMeSj4i7TbssQffknEzjwFRhewMxavUM8RMsOohz2ikJJZYk4=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(85182001)(6486002)(8936002)(966005)(53546011)(2906002)(508600001)(38100700002)(186003)(83380400001)(6512007)(26005)(5660300002)(7416002)(316002)(66476007)(86362001)(6506007)(6666004)(66946007)(66556008)(6916009)(8676002)(82960400001)(4326008)(9686003)(33716001)(54906003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?citZVCtsVHQyM2RYelpZemxiSmxMVzVDSUxHSzFiV2hMZlJndk9HbkFGZ0hu?=
 =?utf-8?B?bCt0aktYMUpjaVE3dW02Y0JkUnRqSmFFT3o3SWtidGIwUjBscFBuSFI0NGdw?=
 =?utf-8?B?Y2grKzNZajBmeVR0bDJIME5mOUVQZ09pdlUycmNOUlgwam1KUzZ0Z2cvMWQ1?=
 =?utf-8?B?K0svTTdDdUNHWFZoNU96VGdSNXBqRzduNkFHaEwwUjViaGpKN2pQRkduMnpr?=
 =?utf-8?B?MVAxcXp6aU8rUHRZTGQ4bjZnaHE1eG52TUZqMmVVZDVMQlVuWlUzRmVnOTh5?=
 =?utf-8?B?ZFVTNzN6YW1nZFFla3AreHRLZTA1enVoQk94REV3RkdsQ1RqQm9vOXpaVDk3?=
 =?utf-8?B?RDU2UmhycUdoZGxCeFE2QkYrRXJOQVVYWmw4L0RaQWh5ZUlZUjZlSERQZlNL?=
 =?utf-8?B?TlN3cDdYdW1wZUxsUlg4OGtpSEVWM2N5S2N0a2hJQmROOTdrdjdTYmhVSXdL?=
 =?utf-8?B?VnR2SU4zNVdZTyt5M3Z3UmNUaE1vVlp0b1VwTkhPd0FySXBZT08vREtIWlQ5?=
 =?utf-8?B?UWxrMlUrV3o3ZXpwMHB6REJnVzgxQXhvbWh5S2dRY1plYzh2VmpCdmV0YVpz?=
 =?utf-8?B?bHFOaGhKaCtMb0RjZzdzV3grelpPU2dpZ01uWnhuS1Z5ODhkUTJiVEVaQ0Ra?=
 =?utf-8?B?a251VFpUU05kc1cvUlBtbXFNMWxmOE12Nkt5ckUyaGRiKzRyc2dzSXUrWm95?=
 =?utf-8?B?L1Z5M1Jsc0lzM29nQ0t2OS9uMmRIYjVLRGIzQkE4Y29QZmRVRmZnVUFPOExU?=
 =?utf-8?B?UG80cEY0dGR2b3ZrMWZYdEZuZXJGSWFGajdJNzkvMHQ1dndEenZPWFlqbmNi?=
 =?utf-8?B?OERDMmJBb1JtV0ZubVdEMHNBSSs3NkJqTlpHZmVaaDczd2pSK2ZFVjVmUVFX?=
 =?utf-8?B?VjJweXhNeUxBWW5aTXNMT05rYjQrYVBjQWxrSzd1TUtRdkducDlyaXZyTm9T?=
 =?utf-8?B?Znl6UFZIK0VDeDJvTXNGbzFyOHhFSVhYZzlkcC81YkdrRlhYSVNSc1RHUGlS?=
 =?utf-8?B?RU5TSC9RWGV0YnB2VjMyRHZQTEIrNjdvUmYyTXZCQW50aEovU0twTFhGdWpK?=
 =?utf-8?B?RTRPTjlJdjVRYTJlYXJHR3NCbWJPRUU5UEIzVS9OMC9CTEExdGZ1MHl3WkhQ?=
 =?utf-8?B?TTRWRkl6Wkk1dVA5QWUxbjRDVGsxRjg3aVBicWVlZ0hMMWcvc1JyeGtENTdT?=
 =?utf-8?B?TlpERzdscitJemVKU3JvaERRVld1SjZsVEhDU3J6UVR5Mk9YVXB2Z0oxQ1dU?=
 =?utf-8?B?c01ONkdCeGN3ZHJFYlVTWCtXRmhQZHQ5c2NFU3loRmdMMlJQdGg5SlhPdjlk?=
 =?utf-8?B?dG14TXdCL1l5aGRjTjM2TmV3L0thKy9ZUnAxY29pNGlXUG84KzEyejJWT2pM?=
 =?utf-8?B?c2M1U2k0YldWUXJlYU9jUXRMMlY3L2NwSEpUVWhwRUN0bHQxKytwM1pGTDcx?=
 =?utf-8?B?ZnpTVThPYVVZdEVlTGRsWElSQWVjSHZ3RHl5MlUyQ0RhSzNHN0NYTmdXbUxV?=
 =?utf-8?B?YjViUDBVandzcVFzTW50ZDVQOHMvYytXa2pMUGJkM2pOWnVrYyticEs1U2E2?=
 =?utf-8?B?dzUrelZ5WEJ3U3IzWmhqeHVjMUgwdVd5RHladlpGTXM2Z1ZHQmpOYnFzL2M0?=
 =?utf-8?B?YWE4WGJjM0VTMFpvREtQK0ZWdzhZbXhFWDZlSWg2d3g5S2JIbC84KzZ2Z2R4?=
 =?utf-8?B?dmNFNitVbGFneEFFeFZaZDdoNjFrK3dYTjRjdkxkQzVPVFhFSTcySHd3a0lk?=
 =?utf-8?B?OEpyc3pVUEhyNnp3WXJuRVRYYzRGZUZOZzZ3Mmpic3BNNHptckxibnppMmZL?=
 =?utf-8?B?Uy9iOWF4aXgrUjBKKzM2QXJzQjRQUHZMVFFLeFM5VWZwMVZJeTBGS01ZMXZ2?=
 =?utf-8?B?OXMwZ0U2YnVSOGlEWVNtMXptclJtaWhHTGl1bmRRUzlqdmRMdXAzaUp6aDlj?=
 =?utf-8?B?cmwwRVQ3ZDAwSGRuRE1lT1JEbjQvRm95Y3RzNCsrWjNVRnhpbFdaOENYbHJ0?=
 =?utf-8?B?bWV4UkZ2NXJJTHFVUjh4R2wva2xiQW95RnFoMFNxblhDQjU0dktvbFhlUjlw?=
 =?utf-8?B?bVdFMnhwd3NudkR5ODlnbm11empDR2taWTBmaGY1UG5lRm4wUmx0d3I1YU00?=
 =?utf-8?B?YnJXaXN0Nk12djFWdzVkazBxZFhKSGlrQjFIVG5VWTRuM0V2Q0RCQkt3ZHho?=
 =?utf-8?Q?1y08Hwo2Pxjco2/I7xPPUeE=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b035ff4f-ff0d-4e44-fa02-08d9ed533ed9
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2022 11:40:04.4520
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZXhue4oUtg7Zykj+Zjp051gqWhH6Kh+vmZ5+LMqwzUB0Zg0mzMUDeYH002oDD3dOqhmhpp11rAMVePMyrXCBVQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5655
X-OriginatorOrg: citrix.com

On Fri, Feb 11, 2022 at 07:27:39AM +0000, Oleksandr Andrushchenko wrote:
> Hi, Roger!
> 
> On 10.02.22 18:16, Roger Pau Monné wrote:
> > On Wed, Feb 09, 2022 at 03:36:27PM +0200, Oleksandr Andrushchenko wrote:
> >> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> >>
> >> Introduce a per-domain read/write lock to check whether vpci is present,
> >> so we are sure there are no accesses to the contents of the vpci struct
> >> if not. This lock can be used (and in a few cases is used right away)
> >> so that vpci removal can be performed while holding the lock in write
> >> mode. Previously such removal could race with vpci_read for example.
> > Sadly there's still a race in the usage of pci_get_pdev_by_domain wrt
> > pci_remove_device, and likely when vPCI gets also used in
> > {de}assign_device I think.
> Yes, this is indeed an issue, but I was not trying to solve it in
> context of vPCI locking yet. I think we should discuss how do
> we approach pdev locking, so I can create a patch for that.
> that being said, I would like not to solve pdev in  this patch yet
> 
> ...I do understand we do want to avoid that, but at the moment
> a single reliable way for making sure pdev is alive seems to
> be pcidevs_lock....

I think we will need to make pcidevs_lock a rwlock and take it in read
mode for pci_get_pdev_by_domain.

We didn't have this scenario before where PCI emulation is done in the
hypervisor, and hence the locking around those data structures has not
been designed for those use-cases.

> >
> >> 1. Per-domain's vpci_rwlock is used to protect pdev->vpci structure
> >> from being removed.
> >>
> >> 2. Writing the command register and ROM BAR register may trigger
> >> modify_bars to run, which in turn may access multiple pdevs while
> >> checking for the existing BAR's overlap. The overlapping check, if done
> >> under the read lock, requires vpci->lock to be acquired on both devices
> >> being compared, which may produce a deadlock. It is not possible to
> >> upgrade read lock to write lock in such a case. So, in order to prevent
> >> the deadlock, check which registers are going to be written and acquire
> >> the lock in the appropriate mode from the beginning.
> >>
> >> All other code, which doesn't lead to pdev->vpci destruction and does not
> >> access multiple pdevs at the same time, can still use a combination of the
> >> read lock and pdev->vpci->lock.
> >>
> >> 3. Optimize if ROM BAR write lock required detection by caching offset
> >> of the ROM BAR register in vpci->header->rom_reg which depends on
> >> header's type.
> >>
> >> 4. Reduce locked region in vpci_remove_device as it is now possible
> >> to set pdev->vpci to NULL early right after the write lock is acquired.
> >>
> >> 5. Reduce locked region in vpci_add_handlers as it is possible to
> >> initialize many more fields of the struct vpci before assigning it to
> >> pdev->vpci.
> >>
> >> 6. vpci_{add|remove}_register are required to be called with the write lock
> >> held, but it is not feasible to add an assert there as it requires
> >> struct domain to be passed for that. So, add a comment about this requirement
> >> to these and other functions with the equivalent constraints.
> >>
> >> 7. Drop const qualifier where the new rwlock is used and this is appropriate.
> >>
> >> 8. This is based on the discussion at [1].
> >>
> >> [1] https://urldefense.com/v3/__https://lore.kernel.org/all/20220204063459.680961-4-andr2000@gmail.com/__;!!GF_29dbcQIUBPA!gObSySzN7s6zSKrcpSEi6vw18fRPls157cuRoqq4KDd7Ic_Nvh_cFlyVXPRpEWBkI38pgsvvfg$ [lore[.]kernel[.]org]
> >>
> >> Suggested-by: Roger Pau Monné <roger.pau@citrix.com>
> >> Suggested-by: Jan Beulich <jbeulich@suse.com>
> >> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> >>
> >> ---
> >> This was checked on x86: with and without PVH Dom0.
> >> ---
> >>   xen/arch/x86/hvm/vmsi.c   |   2 +
> >>   xen/common/domain.c       |   3 +
> >>   xen/drivers/vpci/header.c |   8 +++
> >>   xen/drivers/vpci/msi.c    |   8 ++-
> >>   xen/drivers/vpci/msix.c   |  40 +++++++++++--
> >>   xen/drivers/vpci/vpci.c   | 114 ++++++++++++++++++++++++++++----------
> >>   xen/include/xen/sched.h   |   3 +
> >>   xen/include/xen/vpci.h    |   2 +
> >>   8 files changed, 146 insertions(+), 34 deletions(-)
> >>
> >> diff --git a/xen/arch/x86/hvm/vmsi.c b/xen/arch/x86/hvm/vmsi.c
> >> index 13e2a190b439..351cb968a423 100644
> >> --- a/xen/arch/x86/hvm/vmsi.c
> >> +++ b/xen/arch/x86/hvm/vmsi.c
> >> @@ -893,6 +893,8 @@ int vpci_msix_arch_print(const struct vpci_msix *msix)
> >>   {
> >>       unsigned int i;
> >>   
> >> +    ASSERT(!!rw_is_locked(&msix->pdev->domain->vpci_rwlock));
> >                ^ no need for the double negation.
> Ok, will update all asserts which use !!
> >
> > Also this asserts that the lock is taken, but could be by a different
> > pCPU.  I guess it's better than nothing.
> Fair enough. Do you still want the asserts or should I remove them?

Likely fine to leave them.

> >
> >> +
> >>       for ( i = 0; i < msix->max_entries; i++ )
> >>       {
> >>           const struct vpci_msix_entry *entry = &msix->entries[i];
> > Since this function is now called with the per-domain rwlock read
> > locked it's likely not appropriate to call process_pending_softirqs
> > while holding such lock (check below).
> You are right, as it is possible that:
> 
> process_pending_softirqs -> vpci_process_pending -> read_lock
> 
> Even more, vpci_process_pending may also
> 
> read_unlock -> vpci_remove_device -> write_lock
> 
> in its error path. So, any invocation of process_pending_softirqs
> must not hold d->vpci_rwlock at least.
> 
> And also we need to check that pdev->vpci was not removed
> in between or *re-created*
> >
> > We will likely need to re-iterate over the list of pdevs assigned to
> > the domain and assert that the pdev is still assigned to the same
> > domain.
> So, do you mean a pattern like the below should be used at all
> places where we need to call process_pending_softirqs?
> 
> read_unlock
> process_pending_softirqs
> read_lock
> pdev = pci_get_pdev_by_domain(d, sbdf.seg, sbdf.bus, sbdf.devfn);
> if ( pdev && pdev->vpci && is_the_same_vpci(pdev->vpci) )
> <continue processing>

Something along those lines. You likely need to continue iterate using
for_each_pdev.

> >> +{
> >> +    /*
> >> +     * Writing the command register and ROM BAR register may trigger
> >> +     * modify_bars to run which in turn may access multiple pdevs while
> >> +     * checking for the existing BAR's overlap. The overlapping check, if done
> >> +     * under the read lock, requires vpci->lock to be acquired on both devices
> >> +     * being compared, which may produce a deadlock. It is not possible to
> >> +     * upgrade read lock to write lock in such a case. So, in order to prevent
> >> +     * the deadlock, check which registers are going to be written and acquire
> >> +     * the lock in the appropriate mode from the beginning.
> >> +     */
> >> +    if ( !vpci_offset_cmp(start, size, PCI_COMMAND, 2) )
> >> +        return true;
> >> +
> >> +    if ( !vpci_offset_cmp(start, size, pdev->vpci->header.rom_reg, 4) )
> > No need for the comparison if rom_reg is unset. Also you can OR both
> > conditions into a single if.
> If we open code vpci_offset_cmp with a single if all this is going
> to be a bit clumsy:
> 
>      if ( r1_offset < r2_offset + r2_size &&
>           r2_offset < r1_offset + r1_size )
>          return 0;
> This is a single check.
> Now we need to check two registers with the code above and
> also check that pdev->vpci->header.rom_reg != 0
> 
> I think it would be more readable if we have a tiny helper function
> 
> static bool vpci_offset_cmp(unsigned int r1_offset, unsigned int r1_size,
>                             unsigned int r2_offset, unsigned int r2_size)
> {
>      /* Return 0 if registers overlap. */
>      if ( r1_offset < r2_offset + r2_size &&
>           r2_offset < r1_offset + r1_size )
>          return false;
>      return true;
> }
> 
> So, then we can have something like
> 
> static bool vpci_header_write_lock(const struct pci_dev *pdev,
>                                     unsigned int start, unsigned int size)
> {
>      if ( !vpci_offset_cmp(start, size, PCI_COMMAND, 2) ||
>           (pdev->vpci->header.rom_reg &&
>            !vpci_offset_cmp(start, size, pdev->vpci->header.rom_reg, 4)) )
>          return true;
> 
>      return false;
> }

Just create an 'overlaps' static function in header.c.

Thanks, Roger.
> 


From xen-devel-bounces@lists.xenproject.org Fri Feb 11 11:42:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 11:42:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270424.464707 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIUJf-000797-3c; Fri, 11 Feb 2022 11:42:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270424.464707; Fri, 11 Feb 2022 11:42:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIUJf-000790-0b; Fri, 11 Feb 2022 11:42:19 +0000
Received: by outflank-mailman (input) for mailman id 270424;
 Fri, 11 Feb 2022 11:42:17 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=jrYj=S2=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nIUJd-00078m-H0
 for xen-devel@lists.xenproject.org; Fri, 11 Feb 2022 11:42:17 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a916e49b-8b2f-11ec-8eb8-a37418f5ba1a;
 Fri, 11 Feb 2022 12:42:16 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2055.outbound.protection.outlook.com [104.47.14.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-22-4lzJdvFgOVWA-mavSlZ5Fg-1; Fri, 11 Feb 2022 12:42:14 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3423.eurprd04.prod.outlook.com (2603:10a6:803:9::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Fri, 11 Feb
 2022 11:42:13 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4975.015; Fri, 11 Feb 2022
 11:42:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a916e49b-8b2f-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644579735;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=gpfKJJQbNe70w2WbElGbeCD7X2NChvh9GVV9Gf9C2tU=;
	b=MdgBDiqFSPXWeX7UM9ZWOpNSpz+LMzZbAxnj1+6yK8c9htsQTpkk0S/kBEHoNRUcsJNJSH
	T2/OCjpUZ+SKu1wKGqLNr6St6Wgr6XHmu05rvB5eeyEWlKLrOCN71LKTxEuA8TWVMmSrtw
	4Wlfr+ZI5tCU0MitaIe87nI2uCpAhtQ=
X-MC-Unique: 4lzJdvFgOVWA-mavSlZ5Fg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=AaAxfNVPyTEgBMUvyhsSmJfVqo1O/oQyvnDwkxhG8NDzSH/ZdVaEvhr98Bp8UWX/tl9Pz5WLffhZemgXKrQ7cc/Y2afjuOcvzwTLWA707OwDoKMEGEIEfzgqprQD51SVYr50ES759MmEZgmSCmzSQVF+k3m6cn6izIOvhlg8twuriR+FPF3wBl0mXTXfB8TdhQvInYaXMM6sQ3b75QK1BOnvAynJz05RppdzQv/Iw1TWvFm4Nza5tWPVvKsiw3DJFglxnUDD+Zru5S1GWlBDjC6PJzZ+jDAO0N+KQceS/xI0CQbot5GuHh0eM48V00za36/ZDMiHYiiP1jAI9NxtKQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=9w2MAgE6l5LXbxEH9ygOTMgVw6V1z6gRpRmbzHqpZ8k=;
 b=TvCtbikce56vxi3wgnL71ov3flrHVmdM+cdbzx6Z7b38o6JHZ+f6TBoneVeC2dUQzokqHBHf3m9B+6kPMAaRv1uZp7OvfDxVw3qLiMvpsUR8QsyDlrq1mO61rkRKJQ9QA1r1sK8N6l9uNHWwKC9p1km/7ZYUD4k0/T40gwjvNheD699NVf0n29akxUVayxLOIog8FjwMMv18ufQvMStZSJxjMzowlrSivgU2D1lYTH/DCMfyzi4vxrG+Xf2bCVB731rcvOO290/usQqxTJsENc+JNX8Mm6Ccui3oRjj4aieBPMV5FUCE3khFqR9u3ZxmgtnhJEbZYD1jewlnd1fwHg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <fa312e0c-571c-b200-7d34-9f2d14c2b67a@suse.com>
Date: Fri, 11 Feb 2022 12:42:11 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH CPU v1] cpuid: initialize cpuinfo with boot_cpu_data
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: xen-devel@lists.xenproject.org, Andrew Cooper
 <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 Norbert Manthey <nmanthey@amazon.de>
References: <20220211072327.1213-1-nmanthey@amazon.de>
 <YgYmKiZaX2vZYgKP@Air-de-Roger>
 <85182aaf-1d3b-981a-1108-8eed79516893@suse.com>
 <YgY+sUOIaW7c3Mq2@Air-de-Roger>
 <717694b1-bcb9-b2cd-3740-71d8431a3058@suse.com>
 <YgZGPZUyW0mzGz+Q@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YgZGPZUyW0mzGz+Q@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM5PR0701CA0017.eurprd07.prod.outlook.com
 (2603:10a6:203:51::27) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 6ce022a7-4ce3-4081-35d4-08d9ed538bbc
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3423:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB34234D8E641A97F175B2360FB3309@VI1PR0402MB3423.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4714;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	V5wvdmpxOaFA8zQR0HRUMXjssn430120n4V248kLqgCd+vr1Q3/Bz3UUFfRgHP4SC/AXIoVRWVdkQ8XiG0ynRvJPBs2x5Mq5wJr7hHR2N1uPUlSR9h/JKW2ruxkreg5094Bgs0OFOUj0JIpVvSNA0w42YYMzZts7Tse8hHIq2ApQ3C+SbMB/lKDwU6RCexPuL1lmR2bZjfvDP9kJ8EY/+GtIAMKUDWVCfMtf8CMrjs+oU1lPxJwFKmSj8eLoQk/xgJ2zWtbo8I3cbLGMKgg4W1ve3hT4IMROP4KYJWQ3tQ+mpgjVqhW1tlqMDYfwLcYepC1eM6sjt6tWMVwu8BSz737XKyoY7x08jT9jl1CUzH1QmgqsGZBF9DAhnIoMec7yo6Ka58yra9v2Iapk9lBhYpXgB7hyhXfrX4wpub4vfNp1O9XfjhyoaL08hdrPNUsheZysS/zfTRYMEldUnTyjoUrpqEUUgjHIcAD5rGun3pT2djIMfpweAkbGT6jYV4oVcx2zgrSVkTPM1ta9zbz/b6pQSyZaWhF4YWEeSeHvEKV+3ddiEaU95NIrhBAX8A4wBrcR23pFqGtDvbXmAQXLm0e1xrB9GX19omux4o8XbvmZoiL/rvKarXUN8DTvj3j7WGNPsF5imPpMBxcu47QFYBj/63oDhMnflVGk7iSBXo08w5uZ/oIyug/6RLh4lvyNdlNIfT1WkBuAgm6d7FqovE8TZx0gHZek8wBO1OjeKEmvLN8Jm2KLY+sio036BnZZ
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6486002)(66556008)(6916009)(54906003)(31686004)(508600001)(53546011)(2616005)(66476007)(2906002)(6506007)(5660300002)(26005)(186003)(66946007)(4326008)(8936002)(38100700002)(6512007)(31696002)(316002)(86362001)(8676002)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?aenYhepjGiMUEVzX/m9i0p9ecFIReA4GGUnplgAuQu5hCGdCL997HAv86Wck?=
 =?us-ascii?Q?xw9HLD444C5EvKga/J62IhYQoOxFMLnE2QTSPUq/cM/AzlLnciSFjy8UWulE?=
 =?us-ascii?Q?ouD2KpzsKKZRwXtwAD8v06C2/3WdVSq7n6wjvdsrOTOX//LJk3kjMqCCbWHY?=
 =?us-ascii?Q?a6h9+SdDbhM/+jv6I3uY1TvpSXTbpkU7qXjnfVj1/tjjMR7ze2kE94yj8Bui?=
 =?us-ascii?Q?UocoPvUarHL3MYH3M5/JhlRrchCD3PmMgv8YGTN1u/tZu1F8PFcAz2NInP91?=
 =?us-ascii?Q?cApnqDWyLWAD1PGGxQ9j2IiJFogVLDhv2OUA2t0xotUSUr68aZxWYICkthoS?=
 =?us-ascii?Q?K6W4/sA7T/QZ3z7w0mFjjjfdYZyIlyCgi86Kj4jOvRkCVNTCR480BrCPfpCR?=
 =?us-ascii?Q?3J9NtTpjqQEVZWnI/+260Vqm/mxodzOsSa4i6rhIt2w0+ZfTcaC78JJZkw5g?=
 =?us-ascii?Q?lYtWFMLiDB+TKuTVKpW6yQkPaVdTFZqITd9GLLtaDmZwGEkTsgMn/Atb6ANS?=
 =?us-ascii?Q?kc9ht2mZiBGntWlEsoBCtfcfqJmYMDaGhm5jBpFCQ4xfA0fb/IIdNj+OD93/?=
 =?us-ascii?Q?2AUK0ZsT7KeRPgH3qurQncs9YVlhOF8bVqMAf/0k4pBDqGfNpZNGrVL71vk9?=
 =?us-ascii?Q?4zg9ANhnurBXtrCNQESsONAxSFZcsacnmC1q3VW9MPGhvZTXhm/KkF700yjp?=
 =?us-ascii?Q?gls6Wo6tnP9O5+8J2Ttl0veO26OU/yrjeDdTLIsmrzEEJg/ZwG699iKLwmvQ?=
 =?us-ascii?Q?iGnOIk5KHJHv+8vYWwhqBV6XWZ1boeLFQCQ+qzdGYq4ChMBlpyYrWMDbglD6?=
 =?us-ascii?Q?lcqBGNG/mKn4CObawb+c9Wdl3rXpDLns0MtWMAhQ2YzFT0YpnxTU9s3ZPxV8?=
 =?us-ascii?Q?y0ss8SLzC/Zo9/pVJq4I1jRz1ynfK+QdDnX3ETpYwIU6By67sE2uwICS5sje?=
 =?us-ascii?Q?sXQiV2k+0fsw4xpQlT7zkUE56CPR4vmE6x+mNdTogIaOng9RsiDD44u+AFR2?=
 =?us-ascii?Q?IOsmBYazQaAvl/vMNDFaRugugzHonm5e9mBK5/Av3ODowbtloubPreOcgFFK?=
 =?us-ascii?Q?ykDXqsQRq5OSMbODJipZ8TFrC+LANuzHC7y2KCPLPlYwkqrqmAF+oTD560mS?=
 =?us-ascii?Q?SSrEl4RcblCxxQ2bq9SIfpFfWm/2l0hbqYDwm6boK6ZUicqwQvnmcEvfgVtu?=
 =?us-ascii?Q?Vpa/W9UuQLBy7aoIXI++7adcCBOoWN4CSSL/IwYs5pmSBEhaly2NgMOKAJjR?=
 =?us-ascii?Q?IDq9W+JnJ2KxlsQjKzgK5viMiGSckyABPXQXpVgQBpMjNXT+LOgFQKhwWw7o?=
 =?us-ascii?Q?DR96TQH+O0Fx+tUk1Ym0cy0w+TzOp0zHRPrJACd0UqblbdTc5fDjavYiE2cB?=
 =?us-ascii?Q?XsZkDLJ/9WdxljhZ9IfLmKo3NePmR4Mnv4k/DCW/1gHINSn/N2Mn8ffzQFnK?=
 =?us-ascii?Q?C8f/Rr8k8DzPsYWx5+EFGVRDpL0a40VO6c5+i7YnQKWb5xV7kMfhy4ito0Up?=
 =?us-ascii?Q?klQq5EhoeKXx+ZkZaPYy5JyJ+iKQ9eaYRuFCQNc7QRABNd+anuoWV94wXuRP?=
 =?us-ascii?Q?upLSVxefJqT0zyFBnv+evhkBG+UDoVCGFazfgQue0uM5ywsGQHLn1Y7sEV9p?=
 =?us-ascii?Q?lQNGXOdE8gigni6BQ4D6vNE=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6ce022a7-4ce3-4081-35d4-08d9ed538bbc
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2022 11:42:13.3165
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vkwlqLX/7ZjuVoNM+xBe1+6axgJR6X0FKI6jTzg5VR4hDSlIOUy7oek/u8o+gCqMR2NFs37SOIGnypzwHJyCLg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3423

On 11.02.2022 12:19, Roger Pau Monn=C3=A9 wrote:
> On Fri, Feb 11, 2022 at 11:50:46AM +0100, Jan Beulich wrote:
>> On 11.02.2022 11:47, Roger Pau Monn=C3=A9 wrote:
>>> On Fri, Feb 11, 2022 at 11:32:45AM +0100, Jan Beulich wrote:
>>>> On 11.02.2022 10:02, Roger Pau Monn=C3=A9 wrote:
>>>>> On Fri, Feb 11, 2022 at 08:23:27AM +0100, Norbert Manthey wrote:
>>>>>> When re-identifying CPU data, we might use uninitialized data when
>>>>>> checking for the cache line property to adapt the cache
>>>>>> alignment. The data that depends on this uninitialized read is
>>>>>> currently not forwarded.
>>>>>>
>>>>>> To avoid problems in the future, initialize the data cpuinfo
>>>>>> structure before re-identifying the CPU again.
>>>>>>
>>>>>> The trace to hit the uninitialized read reported by Coverity is:
>>>>>>
>>>>>> bool recheck_cpu_features(unsigned int cpu)
>>>>>> ...
>>>>>>     struct cpuinfo_x86 c;
>>>>>>     ...
>>>>>>     identify_cpu(&c);
>>>>>>
>>>>>> void identify_cpu(struct cpuinfo_x86 *c)
>>>>>> ...
>>>>>>     generic_identify(c)
>>>>>>
>>>>>> static void generic_identify(struct cpuinfo_x86 *c)
>>>>>> ...
>>>>>
>>>>> Would it be more appropriate for generic_identify to also set
>>>>> x86_cache_alignment like it's done in early_cpu_init?
>>>>>
>>>>> generic_identify already re-fetches a bunch of stuff that's also
>>>>> set by early_cpu_init for the BSP.
>>>>
>>>> This would be an option, but how sure are you that there isn't
>>>> (going to be) another field with similar properties? We better
>>>> wouldn't require _everything_ to be re-filled in generic_identify().
>>>
>>> So you think generic_identify should call into early_cpu_init, or even
>>> split the cpuinfo_x86 filling done in early_cpu_init into a non-init
>>> function that could be called by both generic_identify and
>>> early_cpu_init?
>>
>> No, I think it is quite fine for this to be a two-step process.
>=20
> But it's not a two step process for all CPUs. It's a two step process
> for the BSP, that will get it's cpuinfo filled by early_cpu_init
> first, and then by identify_cpu. OTHO APs will only get the
> information filled by identify_cpu.
>=20
> Maybe APs don't care about having x86_cache_alignment correctly set?

They do care, and the field also isn't left uninitialized. See
initialize_cpu_data(). Like in many other places we assume full
symmetry among processors here.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Feb 11 11:46:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 11:46:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270431.464719 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIUNU-0007lH-LF; Fri, 11 Feb 2022 11:46:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270431.464719; Fri, 11 Feb 2022 11:46:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIUNU-0007lA-H8; Fri, 11 Feb 2022 11:46:16 +0000
Received: by outflank-mailman (input) for mailman id 270431;
 Fri, 11 Feb 2022 11:46:14 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=jrYj=S2=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nIUNS-0007l4-4L
 for xen-devel@lists.xenproject.org; Fri, 11 Feb 2022 11:46:14 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 335c625e-8b30-11ec-8f75-fffcc8bd4f1a;
 Fri, 11 Feb 2022 12:46:08 +0100 (CET)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2058.outbound.protection.outlook.com [104.47.12.58]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-41-RVFALD3tNwKLTUVYt24OhA-1; Fri, 11 Feb 2022 12:46:06 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DB6PR0402MB2837.eurprd04.prod.outlook.com (2603:10a6:4:98::9) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.15; Fri, 11 Feb
 2022 11:46:04 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4975.015; Fri, 11 Feb 2022
 11:46:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 335c625e-8b30-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644579967;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=9qMvjdILdOQQm8ClcVKENjFlG9tts7eUNCzqR/xl6Sc=;
	b=l4t2fsiLz6hLr10nuSVpDsqwkDF0I/I/sO4nKt53EtKipaRtNA37FNsrcBtTNOr6E3ZQJA
	g1QVGllIgN7OG0fOP6tHcpi+OXHoBWdwwMRctdY8/JwNLZIjX0VGgS1rbYMJuhtFOhd65I
	f2UQfm8Rsm8qb7zHqERzGMyvtPueAeI=
X-MC-Unique: RVFALD3tNwKLTUVYt24OhA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=odcxN23gh9KdGa0cRCFR6P6HI4Gf04XUXQrl8VKGXMnMJHLhQYI5xdHPjKd52EZNbuE++0H8SyRI8TJzSsIvweOI7UxEV97aT6/BqKg8bCk0mD5RwfNJ+3GF1pFydtWS+xQETQ0ugmxSoiIJR9WtBR9AEJ5mgVNQq+/I+sO923aQVXBML8Hf4pLyrvodmx3Fg22sfZm46Rhyr0FSPA9CmwS6sekWYvD7NFM1oFEwzFm2ZvT1Vs4g8beSyLMw6JqtcaLvfFPheLfWM6gA56FlV2wa/A+Ya0yDbPGlhqyzRe9Ng6w9zp+YPf+EeJYcLIh1VeESqzof7ode3k5fXm5hvg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=IX2ExCCCyJ8Ds8YDjq4m8oRjwGlBVybNnIGNuRAwLlg=;
 b=KRya4jVUaSW8uanNmLgBzBisBo6MmkIEMTTRu+LJ9QZpjk/N3isPhIqMj25gHEfO8CQ8ZLkbSJ3qEExHHu4awKYmXke64wlTpHbF1SGCgplnDOqL+8SbXo+mXbzgQHjlXqEuGOf7h9o+K7zrLUykqdlc+uE7u/8BdAk7V1GsXVKfkFLyFo9fyWwSXmEpi3U/tf3/XZryR7mGTKKr8HQPlNPU8+RocaGGv1m+UtEhBHyQbmxZu3ym5R7LXeji9QpcBYsprQ2zqUzPmVs0Q71oq9JsGxrosZnDlnpyyiHhGTU/lhP+hTh2eb/2kss4tTVI/7leLIw0J9fTEL5rc2JAJA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <6d924061-f2fd-5f3d-0f98-79e76398b908@suse.com>
Date: Fri, 11 Feb 2022 12:46:01 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH v2 1/2] xen+tools: Report Interrupt Controller
 Virtualization capabilities on x86
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>,
 Anthony Perard <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 George Dunlap <George.Dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Jun Nakajima <jun.nakajima@intel.com>, Kevin Tian <kevin.tian@intel.com>,
 Jane Malalane <Jane.Malalane@citrix.com>,
 Andrew Cooper <Andrew.Cooper3@citrix.com>
References: <20220207182101.31941-1-jane.malalane@citrix.com>
 <20220207182101.31941-2-jane.malalane@citrix.com>
 <YgTi6bzeojtcu0xL@Air-de-Roger>
 <dff9c5c0-7bee-ce0d-3288-91255a701c99@citrix.com>
 <YgZIo9VQktcqGHTD@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YgZIo9VQktcqGHTD@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR0301CA0002.eurprd03.prod.outlook.com
 (2603:10a6:20b:468::15) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2f401bcc-287f-4511-0702-08d9ed541565
X-MS-TrafficTypeDiagnostic: DB6PR0402MB2837:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<DB6PR0402MB2837E1D2BD33EE7FF64650C8B3309@DB6PR0402MB2837.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	7cfALlDWo82qlML5AKhGMJKMf3LyH+1wiFqzHCLweyryTXDNhZOH1T1La7osYFLFozMvzipz9M+4AhGi98Zurcc11MUK/0rt0p8sSx0gROPX3BhIjDgftG9KNMs3k/boPfm4jbddV53AEplBvfgCRNMfg6jQxcwbXXEZ0yBxK/FVv/vfIZOUElQxbBMsIzG5ZB3gJ5wp+CrpzBe8fO1DCZxnu8WMIJWEeJTkhsMsrCbcIolob+dJBGgGAZmP82PP8HdDbE+jO6uCCg2fF4MC3mNc0ZvJOg/PaMORu56qTEwOsx59FoxoeyYE1JpCXad1g8KbUOXMyA//W/mNWtrtYZ2Sbg75jxcLQRLupnMg8nzzY6UHRZjApt+rhn87qkI8Cvv5k/p/7oNsQfpFbnBQ3vKmpt0Bt1CLGXenQ0kyB9y2rfA0BUxEju2FaqcRN4eiMKBs23Xqbgr1wTsbecjUIa7ZSNKLVQbgdQdAIeV3efGU8BlSW8ALYDzbVX9ONbZUhkdw8GJcubcaWprz3uoK070KFR4HOSWb5guShBMap5FtM76h5ntW/Ys9EH1IrwG/nokDIBT9qebi9czFBcGstJIaABcDAXPdHb300p/xqUtPW/2QYfXvoORxFS1+Z7wbhdlgCgB4odrMrAdv7a/DA7Fb7Ra+ZcstwNOJAP6+tomXnYOIhDEaG2TeA9LMR/vGlxvAEMmyUmzwD+957Uv0LByRswHA8zyQXzreG9e6XfaeQ5KMcZBnc/sIZ8Rgw8D4
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(38100700002)(7416002)(5660300002)(83380400001)(8936002)(316002)(66946007)(66476007)(66556008)(8676002)(2906002)(4326008)(86362001)(6486002)(31696002)(26005)(186003)(6666004)(6512007)(6506007)(53546011)(31686004)(2616005)(36756003)(54906003)(6916009)(508600001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?S9L12r1qUAsr26tTw6iQHolwKmX2LHG+sQJ7VIsDz/WhnD03eylBVE25cwZV?=
 =?us-ascii?Q?T9yLl33CVCGRbczz6kdKRtGDm5JTlIDYtDLanyImp7MOhjOl39pUfGrMQVde?=
 =?us-ascii?Q?Y/L8LZGRzFK2jQ46R6zjuAw6lCFEMrkYd0FRBhZUhNqmWguQMnGsDCZtImvT?=
 =?us-ascii?Q?8FXmiEzfd62ixslchbBykEGiqVYlK0EeRHHej7logOo5wV/dL7gJjqhGwqu+?=
 =?us-ascii?Q?zlhtcRXoahXSUGsvpeDx6+3uXAWs3/7mFMmudotSXWyfoWzwS0ZjxHiWkp9o?=
 =?us-ascii?Q?2+75cgGwlSeqaeGfd8TAQBy5a9JE4bB0EHU6Nh2lUdUkwMIi6HLeIzsRab9j?=
 =?us-ascii?Q?Jtoq+vylovmayeL0O2XqLD6VMWChZDQiBdEufYbPRPmEC9nR2POcuaTKZr5i?=
 =?us-ascii?Q?YyfMSApF6Zju6VP4NRHgiYB/SVDR4OqsGjFDqaUlMBffbzsPGheh9yeYpMyy?=
 =?us-ascii?Q?LYMuhPZ29TN2eExFJpYz6iwhTMzv8Pucwclekvi/Y3fxZGDKVB+hrl9iOc1i?=
 =?us-ascii?Q?wy0+wlKDmGU3Gvvwjx1sxK3z9pKv//xsKyiSnUAAstWCjryw3U1sFfjZp2Hb?=
 =?us-ascii?Q?GNETqotlUjNsWlhSn5rfep2mA5Zelj5VkWYlYp5yZW2MXS7XjHhwwfXWx3LY?=
 =?us-ascii?Q?Z9xRkDz5iPs9bq/bJ/mZcmxAnCau8079lUj/R4BQSeQvEhDDet9fFGS7zuLc?=
 =?us-ascii?Q?CN1YunWQOszAyuP3DDzgEpm0KfEBdnLpyPPhGK6VcckhMb6awDpC4TlNfh5+?=
 =?us-ascii?Q?LXD90rhyaTq1H7BMhzUVTLOzVkApwzIoZ7d4e1C0pTqYz7jA1HvyHw0zlTGV?=
 =?us-ascii?Q?TDuycCBsGAbAVJawsBDfFV0svolFbGveuabZYAVAwixuCyqarTPuZV/+vYk1?=
 =?us-ascii?Q?ypa2AU16pZ4Aaxmnc8MTHoHFh26umfckANjshmAWZvErINQIEBe5i//qJWkS?=
 =?us-ascii?Q?uiQX9YYb3Pjmbmpx6mXsHxc3lOt4gHFr0rhw1iJYlcSaOxlKkTOYGdwAx01I?=
 =?us-ascii?Q?ypzxJoKE05NR5d4pcNOoTiU+CRfgKslPmtIQEH2aPTAhrftswo7Vk/IDiDDa?=
 =?us-ascii?Q?IJc2fPoXDzZdafTb4HNT5Mq+v6bJfZVC33CDu6y1tbCI8DRyRPl1Znxaij87?=
 =?us-ascii?Q?LjVB7kLOXiFy/zbunngUL0orJXqGv0EdbcR5/doCm5/jJ705xyNjGRk8mTjb?=
 =?us-ascii?Q?ybCFm/zUT8XJJYlSm68jnHL8O0th5KbJhSc9bk4ObFOd2JyftLnuthzJtmB3?=
 =?us-ascii?Q?SQI5Sr7SyY/9oLtv9OIduqwW3FXaMx8KSahkOtfGR442munuD0DHlDT1o0zw?=
 =?us-ascii?Q?c12jfdUdWMDw/NSEomOMEaEfjm/1+N2YLb0Or4CExIqdvG7ZVrPq9P2ZS3yy?=
 =?us-ascii?Q?gXGnbFRGYl/2E5Gsic4nQaLeWaDz7wTRMaAk3x8YTygP5l9FyjUJ9e/NxLLs?=
 =?us-ascii?Q?Ak6mPJ/b+r1Gom/1yRwuS85hbTueupxuxwUZnDiGVVtOsL3If3OP8DRHxcHB?=
 =?us-ascii?Q?tUi5hjPra6F9cheQ/QuedFjcsNrGtIpt3fBBk5NLZE+oscyhsP3qJ7kTHC0k?=
 =?us-ascii?Q?/zWocJ7DsaIdBL2zk3NpgkA4zH89u9e4b7RKJ+yY3OBwn1kPJ/lUtGEov82Q?=
 =?us-ascii?Q?VVG6Vy4wrLzem1HZzf5Fj8E=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2f401bcc-287f-4511-0702-08d9ed541565
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2022 11:46:04.2707
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KIYb+5NAo4t2NG22bIXWtEMqXetbFTB/8OeTngQlkl6y4cz9zfTn3KCtQDFuv67KSpDkv/sc2HfkA7e4IrIUhQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0402MB2837

On 11.02.2022 12:29, Roger Pau Monn=C3=A9 wrote:
> On Fri, Feb 11, 2022 at 10:06:48AM +0000, Jane Malalane wrote:
>> On 10/02/2022 10:03, Roger Pau Monn=C3=A9 wrote:
>>> On Mon, Feb 07, 2022 at 06:21:00PM +0000, Jane Malalane wrote:
>>>> diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c
>>>> index 7ab15e07a0..4060aef1bd 100644
>>>> --- a/xen/arch/x86/hvm/vmx/vmcs.c
>>>> +++ b/xen/arch/x86/hvm/vmx/vmcs.c
>>>> @@ -343,6 +343,15 @@ static int vmx_init_vmcs_config(bool bsp)
>>>>               MSR_IA32_VMX_PROCBASED_CTLS2, &mismatch);
>>>>       }
>>>>  =20
>>>> +    /* Check whether hardware supports accelerated xapic and x2apic. =
*/
>>>> +    if ( bsp )
>>>> +    {
>>>> +        assisted_xapic_available =3D cpu_has_vmx_virtualize_apic_acce=
sses;
>>>> +        assisted_x2apic_available =3D (cpu_has_vmx_apic_reg_virt ||
>>>> +                                     cpu_has_vmx_virtual_intr_deliver=
y) &&
>>>> +                                    cpu_has_vmx_virtualize_x2apic_mod=
e;
>>>
>>> I've been think about this, and it seems kind of asymmetric that for
>>> xAPIC mode we report hw assisted support only with
>>> virtualize_apic_accesses available, while for x2APIC we require
>>> virtualize_x2apic_mode plus either apic_reg_virt or
>>> virtual_intr_delivery.
>>>
>>> I think we likely need to be more consistent here, and report hw
>>> assisted x2APIC support as long as virtualize_x2apic_mode is
>>> available.
>>>
>>> This will likely have some effect on patch 2 also, as you will have to
>>> adjust vmx_vlapic_msr_changed.
>>>
>>> Thanks, Roger.
>>
>> Any other thoughts on this? As on one hand it is asymmetric but also=20
>> there isn't much assistance with only virtualize_x2apic_mode set as, in=
=20
>> this case, a VM exit will be avoided only when trying to access the TPR=
=20
>> register.
>=20
> I've been thinking about this, and reporting hardware assisted
> x{2}APIC virtualization with just
> SECONDARY_EXEC_VIRTUALIZE_APIC_ACCESSES or
> SECONDARY_EXEC_VIRTUALIZE_X2APIC_MODE doesn't seem very helpful. While
> those provide some assistance to the VMM in order to handle APIC
> accesses, it will still require a trap into the hypervisor to handle
> most of the accesses.
>=20
> So maybe we should only report hardware assisted support when the
> mentioned features are present together with
> SECONDARY_EXEC_APIC_REGISTER_VIRT?

Not sure - "some assistance" seems still a little better than none at all.
Which route to go depends on what exactly we intend the bit to be used for.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Feb 11 11:52:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 11:52:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270438.464730 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIUTA-0000lV-Bh; Fri, 11 Feb 2022 11:52:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270438.464730; Fri, 11 Feb 2022 11:52:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIUTA-0000lO-6b; Fri, 11 Feb 2022 11:52:08 +0000
Received: by outflank-mailman (input) for mailman id 270438;
 Fri, 11 Feb 2022 11:52:07 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=dFbI=S2=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nIUT8-0000lI-Rp
 for xen-devel@lists.xenproject.org; Fri, 11 Feb 2022 11:52:07 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 076d5a3a-8b31-11ec-8eb8-a37418f5ba1a;
 Fri, 11 Feb 2022 12:52:05 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 076d5a3a-8b31-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644580325;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=ODpKe1Z1mnh2NwbX23CJJ0JMCaIjnnoBv0UYDgTxAUI=;
  b=HOn7IhDOPVLX1UutYcoLlGTHkPIjXcQUCp0x1nykhlIG3jLuf7yIw2ux
   LUYIjKMzvNxLaoqQX7DpysXH+IyrGl/dzSo8O/4Ht9HxVQCJmr63P94Nw
   BLGBMgkKRuX9ByAgvrEQvcJt433TKl5aXjb9zlX/U/L6QEPxYFg0sh/py
   g=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: DFSDBVZwqBcPlvGqGAULNiUihvOs6k/ysY2GoaUSsYdzsC2N8dQVgWCj55i2nFM4r0Yi/Vw2AQ
 eRKfqwi36gsorM4+nuMoAgqc1s0m+ewGFaW7chC5MGokdLWFnPM90JrG7Er+yOXztGVgNUiBmZ
 UpaqZMDx83dBoCn7gwwRzTePmv2+Ysk08ADhqnKyAuJgE3i8dLdvQSarnWA3e98tkvVuxNe9eu
 0pnuay7zDMJaY8uoESMUiLzSb6aDnES5P2fkX2LyeS+j6zzPeuDTZpURCCX2AltZycArmD2Ncg
 rfij0vuTyoOaYqW4KN2BqaNJ
X-SBRS: 5.1
X-MesageID: 64415550
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:PPlgLq6tj/SI/gdAdlOfgwxRtB3BchMFZxGqfqrLsTDasY5as4F+v
 jZJDG2HOvreZ2WkctAjPovj8BlVuZKAnIdiGlNrrSFnHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FV8MpBsJ00o5wbZj29cw2LBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z0
 +5jt5qUDhsTPqCQxf9Gdht1SipCBPgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALNs7kMZlZonh95TrYEewnUdbIRKCiCdpwgmts350TQK62i
 8wxNSBTTjnJehN1YA0xFrMCzMGq2nT+SmgNwL6SjfVuuDWCpOBr65DTN97Sds2PVN9itE+Sr
 WLb/Ez0GhgfcteYzFKt1XahhfTGmy/hb74DD72z9vNsg1q7y3QaDVsdUl7TidCjlkO7bPdOJ
 EUV9zQGoLA78QqgSdyVdwexoGOA+AUdXdVQO+Qg7UeGza+8ywyUHHQeRzhNLtkvrtYrRCcC3
 0WM2djuAFRHoLCTDH6Q6LqQhTezIjQOa38PYzceSgkI6MWlp5s85jroSttgC6ezgsfCMDf82
 S2RrCM+irMQiuYGz6y+u1vAhlqEpJLEUwo07QX/RX++40VyY4vNT5ez9VHR4PJELYCYZlqMp
 n4Jn46Z9u9mJZOQkC2ARs0dEbfv4OyKWAAwmnY2QcNnrW70vSf+I8YAu1mSOXuFLO4fQhHrZ
 muUpTlR6cMOJyCPb4IuaL6IXpFCIbfbKfzpUfXdb9xra5d3dROa8CwGWXN8z1wBg2B3z/hhZ
 M7zndKESC9DVP85lGbeq/I1jOdzrh3S018/UnwSI/6P9bOFLECYRr4eWLdlRrBotfjUyOk5H
 js2Cidr9/m9eLCmCsU02dRKRbzvEZTdLcqnwyCwXrTdSjeK4El7V5fsLUkdU4Jkhb9JsezD4
 2uwXERVoHKm2yGbdF/XNS85Neq3NXqakZ7dFXZ9VbpP8yJ9CbtDEY9FL8dnFVXZ3LALIQFIo
 wktJJzbX6UnpsXv8DUBd5jtxLGOhzzw7T9iyxGNOWBlF7Y5HlSh0oa9ImPHqXlfZgLq5JBWi
 +DxiWvmrW8rGl0KJNzIc8im017ZlSFbwIqeqWOTeYINEKgtmaA3QxHMYggffZ1Sd0WZm2fyO
 sT/KU5wmNQharQdqbHhrauFs52oA615GE9bFHPc9rG4KW/R+W/L/GOKeL3gken1WDym9aO8S
 /9Syv2gYvQLkEwT69h3EqpxzLJ47Nzq/ucIwgNhFXTNTlKqFrI/fSXWgZgR7vVAlu1DpA+7e
 kOT4d0Ga7+HD9zoTQwKLw0/Y+XdifxNwmvO7e44KVnR7TNs+ObVSl1bOhSB0XQPLLZ8PI4/7
 /0mvcoat162hhYwa47UhSFI7WWcaHcHVvx/5J0dBYbqjCsty01DPsOAWnOnvsnXZowVYEcwI
 zKSiK7TvJhmxxLPIygpCHzA/etBnpBS6hpE+0APegaSkd3fi/5pgBAIqWYrTh5Yxwls2v5oP
 jQ5LFV8IKiD8ms6hMVHWGzwSQhNCAfApx70wloN0mbYU1OpRirGK2hkYbSB+0UQ8mR9eDlH/
 e7HlDa5AGiyJMyhjDEvXUNFquD4SY0j/wLPr8mrAsCZEsRoejHimKKvOTIFphaP7RndX6EbS
 T2GJNpNVJA=
IronPort-HdrOrdr: A9a23:p/2ufa3MMhonvN6Pzaa80gqjBSpyeYIsimQD101hICG9Lfb2qy
 n+ppgmPEHP5Qr5OEtApTiBUJPwJk800aQFm7X5Wo3SITUO2VHYV72KiLGN/9SOIVydygcw79
 YET0E6MqyNMbEYt7eK3ODbKadY/DDvysnB7o2/vhRQpENRGtldBm9Ce3im+yZNNW977PQCZf
 6hDp0tnUveRZ1bVLXxOlA1G8z44/HbnpPvZhALQzYh9Qm1lDutrJr3CQKR0BsyWy5Ghe5Kyx
 mJryXJooGY992rwB7V0GHeq7xQhdva09NGQOiBkNIcJDnAghuhIK5hR7qBljYop/zH0idhrP
 D85zMbe+hj4XLYeW+45TPrxgnbyT4rr0TvzFeJ6EGT1/DRdXYfMY5slIhZehzW5w4Lp9dnyp
 9G2Gqfqt5+EQ7AtD6V3amHazha0m6P5VYym+8aiHJSFaEEbqVKkIAZ9ERJVL8dASPB7pw9Gu
 UGNrCS2B9vSyLbU5nlhBgt/DT1NU5DXCtuA3Jy9vB96gIm3UyQlCAjtYkidnRpzuNLd3AL3Z
 WBDk1SrsA8ciYhV9MIOA4we7rGNoXze2O/DIuzGyWvKEhVAQOEl3bIiI9Fkd1CPqZ4i6cPpA
 ==
X-IronPort-AV: E=Sophos;i="5.88,360,1635220800"; 
   d="scan'208";a="64415550"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Jm5rC02hn8y/u16k0iZaWL/HSyHN9G+xmdQ1bCr2JhOBKgsHNOtoMGj+XNqgQdwjTN5abUaceuUg9zwHnpt6jN7mZUjsJe5iuJLmTEHxdM3+b+Bl7ar1tUXeO2vjN9vDL/j+7dseQ6udXQ5Q8Z9VLcXocP2Y/pidcqINo0ZpG2oehZ2HctXVNjNEcxwzSpeQ9CHLrkNhh74A3t9gb1pkqIAiWAIFxQ6ISAWbW2kQxS1sBfFYB2pXo4V0TnIa7gO2AifoVdg3oGhKL2F4e1DullrDo4Haqlht2ZPZdNxR+eyVxhmZSQAxRiALvGIlYdS9oqP/KY5vv/FAIIQ4Kobvcg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=S3iEnlsl/OISpugzlYfdMqzfKrt7Q+BNMrtT57nZTgM=;
 b=LCOPD6A/s9EfYOysuOyRIeKGl+148FRHiCgcI8l1t6Sny6CzJk9d3/Ns2aCU0Wg0HRVc781WJHhwa0RRD2S11+oiXDMHyxOyVAuY8Pds9IOLf2Sm37qY3/vwHHeY1AVfbeihrbi2251jXHKsXPwxjdFEEd7CHOc4ZnX7Lk9fWgfWMHSLwEWVMEg7oqFUgf4zABo1dusCcHKPqwRTHfZCNGQN8ILf5vrG8FwQNSVvDiX6Ck9aEOVFOajG9VLX9PiqZ+zWNjWGSYX3ao0CQ84XNtWwmWjc+JegzDFJV128LACBSmxRrOAEi7+1JbNfqmeoQJfyQfEyBtzk/nToUUsZlQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=S3iEnlsl/OISpugzlYfdMqzfKrt7Q+BNMrtT57nZTgM=;
 b=EaLyVNW4lMwrOPjylMePt0bgH8H1Gh9E78TzmbmKHtocG+5nJdVTxau8pzO+X92s/rm/ahcM2UEmzzXM7VDHAvoR6n4AlGtlLY3oYqF+mlNfOiR7zOdCrxpPo0/G4Lny09/D6/qsR/TtqEVVZxJDI75qBhDTQl1eqNNr92SRipw=
Date: Fri, 11 Feb 2022 12:51:53 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"jbeulich@suse.com" <jbeulich@suse.com>, "julien@xen.org" <julien@xen.org>,
	"sstabellini@kernel.org" <sstabellini@kernel.org>, Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Artem Mygaiev <Artem_Mygaiev@epam.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>, Rahul Singh
	<rahul.singh@arm.com>
Subject: Re: [PATCH] vpci: introduce per-domain lock to protect vpci structure
Message-ID: <YgZN2acOL5B+PYF5@Air-de-Roger>
References: <20220209133627.959649-1-andr2000@gmail.com>
 <YgU6Snk8GTytJXZp@Air-de-Roger>
 <878371dd-4269-6e44-4e73-344a74a04a84@epam.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <878371dd-4269-6e44-4e73-344a74a04a84@epam.com>
X-ClientProxiedBy: LO2P265CA0435.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:e::15) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: eeb84734-a78a-4b1a-9c53-08d9ed54e881
X-MS-TrafficTypeDiagnostic: DM6PR03MB4649:EE_
X-Microsoft-Antispam-PRVS: <DM6PR03MB464977AFD62DB49740825D288F309@DM6PR03MB4649.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: ZB0nyzJoBSG1dClZy+TBqO21AuP2UBMLg6Oh6Umriw9St9GpWcCMaYa45iCGQJsNDFNsM2nfmGJVCangGRXAcG1PfeN274U00cd/DpQHrEubQ8FNmyAFp4AX3eUYcP3oRD9su2TALmjzgryv2dj60AvOjMhOOFgsK7vi1LIJntgo4ChvVGJfhDADi5RZpmQSeD+EwSQK4WofdecMiynsF7sKZzMsx7KOP7MQUdYsF154poWsyjZsRDaE8bLi3Tmqqx9wfj61f3zk4cO7UvCWEjRgDYdCMSGNEYx4bT4QVPfat7QF29GvlBHf2h0f6cIt70oTxImECXVvFAX9Zl1/T/WChAkkYNQiVp5p0C4ULTh1m+H7uDD1OAiLGtR1JLwR1MxmJUYw4x6gPcWuWw6lIGAAOOOOWMo+xaQ8k9JPhZuY0KvO4jSQ0krMXCwh/mXDjZwEXkC0w95vtx3t0A9dVhgtElBgamTwxqd9uMP8gFecQZLeSTzIaD3qJNyf+glmZ91VrkKQEIJa1s8s8y9t1j4uTWH5MyqbsXx1yMcdA7nP11xzphVcA0EwNJR94qY6hIsYHwkC/7h7FfMPljWYESvWB8PkHC1QD9Ih5KuZOcN0rQBXy9K9WeC9UpOOgXrmwBOb0EuGGJcvDF9ECLpwAu37ANG+t3a9k1hkXl+Rj6OD20+FuiUYkxpKuM3BBnvRjuqd947OKt08zSYvF0ZyhQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(4326008)(6666004)(508600001)(66946007)(86362001)(8936002)(8676002)(66556008)(66476007)(6486002)(83380400001)(6916009)(7416002)(5660300002)(316002)(85182001)(82960400001)(186003)(26005)(53546011)(6506007)(9686003)(38100700002)(54906003)(33716001)(6512007)(2906002)(67856001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aXBhSEFXblpmeFdENm9lcyt1WitnUjViNW16QnQ5b1paYUQ4TTJLWGhmRE9v?=
 =?utf-8?B?eWpiNXpWZFJGbG84UHh0MTRxTzgyYnhGZTJQZFIzQVZieTBCbTZpai9NTHhk?=
 =?utf-8?B?bmpWTjl6cVRIeGM3Y3JKYjVCb0dRU3pGc3l4ekwvemQrbmFyS0R1ZGwrZXB4?=
 =?utf-8?B?bDM4cFVVWWZ4RXlaYld6WFhIdHpTbGtkcmxscTJyTnNJNjJlazVLYlNDVzdI?=
 =?utf-8?B?d3UyQnk2MVV1QmlUUWlZOEx5R2pZaXh5enVjV1FWa29Sb09FS29QZEtQUHlW?=
 =?utf-8?B?REdUTEkvMzZvbytPMlI5NnkzZ2pmOVJHcUJLR04wcFNWY0xWZDlSeVZ0bHRB?=
 =?utf-8?B?OU16TzJjRFlEa1E3VFBWc0l1b09Xd0phRk15R2pjQzBGTVZqSmNhc21lZEtS?=
 =?utf-8?B?d21iTlhkYm50RzhLVEdMaVo5TkdlcnhTQXJTcmxMcXhqZEU4QlQ0QWhxbGh0?=
 =?utf-8?B?Y3dQdWdaUzVJTnhWdnVVdFcyUXJtNnB3NDdXenhpVnVPSVlSMHJzNFI2RFdo?=
 =?utf-8?B?YVZZK28yRkFvdzBkcFJnTlhCS2tjOVM2N0xETk1ETTdsOVZzMmM2aktkcGsx?=
 =?utf-8?B?THArcVp2aVlTRHpxNEdXMzFLampPdmlVemxIM0xKeEFrYXBSOHYwUWdsWDZh?=
 =?utf-8?B?ZExmZVpna1RzVDRLR3hsSHNoY0NwQ05qVkczK0xyZ2dJT09WSUpwSE9tSG5m?=
 =?utf-8?B?amxlZFRzZkMxaGYrc04zY3JqVmptWmc0dmkrTGNxNG5JdXFMdG9xQkNoc1FS?=
 =?utf-8?B?REtEdC9GcUZDV0xEYmhYWTlETFlrWW1zY3NWT092aXRHd2FkdlU0UGdNd1JW?=
 =?utf-8?B?N21iN3ZiOWxzSTVnaXloaXZpWE04N3NMUTMyYWVUMUpFRmVmbDdsNHRxSERj?=
 =?utf-8?B?TlBFUmpPcktCVjNsbmhXRTE0TnZjYlVHdzQxbmxDOXVveElpelpPbDAwNXl1?=
 =?utf-8?B?Rjl2L0RwSmVnN3M0amhpVUlsN3NFbHlreTdxaFExRGorUVBFbGVUd3JSZktu?=
 =?utf-8?B?QnJHRCt4L045T2xEaThMbFNXWTY4SytvY1VMb1lZdCt6ZStFNWdXWnppM0I2?=
 =?utf-8?B?T0lsR2ZHTTVEWVBKYUdrSmdvYU5sblMzZHhGdVczMHRWMEZmY3MyaGlKRnNz?=
 =?utf-8?B?YzB5TTZkODZpMk5rMG45ZWlaaDc4V3Z6a3labmhmcEd6dVFRd2JlMVAxR2pL?=
 =?utf-8?B?aFIzZndkNzk1dFRWNXFZSjJCeE5uVHFQOUpNSzhlWXB2QjMxVXlDRk9hTXcr?=
 =?utf-8?B?d3BKT0lLSFI3UHZTRHlsczdoKy9KdnNZZUVCdVAwL0RCZUVYRHcrcUlGSmhj?=
 =?utf-8?B?Y29zUmJveEJQOG5ZSDVFRjRtT21WdXh2OWIwTGY4V0syTXFEMUpsUDdqZVNk?=
 =?utf-8?B?Y1N0Ymw2QXhPZXJ2QVY2VldBNkNLNXhRYlhsUkxOZHBVU0FZVkNjRmVvTkh3?=
 =?utf-8?B?bnhkVHZSTE9Rdko2ODFXS2ZNSHlCS012Y0lWbTdaOUJ2ZmJZSm9aclFkMDVq?=
 =?utf-8?B?eFd1dzc3T1dDeGJHbkhCUlBLdWF6T3VETGxXWTlJM3Avd2FwK0c5cXg3YjlV?=
 =?utf-8?B?WlBBUTRSc0RYTmUvd2wzWWNBZ3RHZzJhVDAvajNqS1NhekNibEdrMFRqajBW?=
 =?utf-8?B?RTVBelVSanNwUmduWnlLV3JUMmVvQUxkTUlSQzNOUVozRjJuQ0hZSWhHMVFn?=
 =?utf-8?B?aFh6aG9zRVRLM25LTGhiOS9Nc0VWWTdORHgyMXhFS052VVBJKzYzS3oybkFp?=
 =?utf-8?B?N3NCNDdGVDI3ZGpLM3g2NnJZdnlJbTAwWDlaSDhnK0hOclBzMmgvczNlSnFs?=
 =?utf-8?B?UDBIVC9wK0JadndMZWZpM1hCcW9NUCtSNHRpQSt6aGdTZExTeEN5OFBXNFNq?=
 =?utf-8?B?azdVcWpJZjRYd3NrSXc5Mk5KRHpJdGVjS3BoeWZrVE5XUDV1bjN3VXdJZzR3?=
 =?utf-8?B?cy9vTi9TbHRxaFdPbWcvamZJRjlQWkVQVmhOZUs2dklKb01kSmF6RW1yWWlW?=
 =?utf-8?B?cmRrcldxR284aXdzeC9ra2pqQ25KSkJMNUlIQUJvK1V4ZmJadFZHUnJCWi9q?=
 =?utf-8?B?UmV5Q0Y2WWJFV1lXRjRXeUwrRGJnc054VEZFSFV0eFFmQzNyeXpNdTJya0I2?=
 =?utf-8?B?d25VSjIxWXErb3FNbmZWTGhFSXY5K2R2eFhpbHBZalRtSStUdURmZUVESE1q?=
 =?utf-8?Q?XqZoHdqa0r6gC/V5Fc2w8+s=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: eeb84734-a78a-4b1a-9c53-08d9ed54e881
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2022 11:51:58.5510
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: m+idTFp82i2EYzVOicOku9iH5IodAvgm6pIjU3SJEdfWKEdBzbMd2dz8R7vUo6BmZn4FckiinQWkGrAtOAmoug==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4649
X-OriginatorOrg: citrix.com

On Fri, Feb 11, 2022 at 08:46:59AM +0000, Oleksandr Andrushchenko wrote:
> 
> 
> On 10.02.22 18:16, Roger Pau Monné wrote:
> > On Wed, Feb 09, 2022 at 03:36:27PM +0200, Oleksandr Andrushchenko wrote:
> >> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> >>
> >> Introduce a per-domain read/write lock to check whether vpci is present,
> >> so we are sure there are no accesses to the contents of the vpci struct
> >> if not. This lock can be used (and in a few cases is used right away)
> >> so that vpci removal can be performed while holding the lock in write
> >> mode. Previously such removal could race with vpci_read for example.
> > Sadly there's still a race in the usage of pci_get_pdev_by_domain wrt
> > pci_remove_device, and likely when vPCI gets also used in
> > {de}assign_device I think.
> >
> How about the below? It seems to guarantee that we can access pdev
> without issues and without requiring pcidevs_lock to be used?

Hm, I'm unsure this is correct. It's in general a bad idea to use a
per-domain lock approach to protect the consistency of elements moving
between domains.

In order for this to be safe you will likely need to hold both the
source and the destination per-domain locks, and then you could also
get into ABBA lock issues unless you always take the lock in the same
order.

I think it's safer to use a global lock in this case (pcidevs_lock).

> diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
> index e8b09d77d880..fd464a58b3b3 100644
> --- a/xen/drivers/passthrough/pci.c
> +++ b/xen/drivers/passthrough/pci.c
> @@ -937,8 +937,14 @@ static int deassign_device(struct domain *d, uint16_t seg, uint8_t bus,
>       }
> 
>       devfn = pdev->devfn;
> +#ifdef CONFIG_HAS_VPCI
> +    write_lock(&d->vpci_rwlock);
> +#endif
>       ret = iommu_call(hd->platform_ops, reassign_device, d, target, devfn,
>                        pci_to_dev(pdev));
> +#ifdef CONFIG_HAS_VPCI
> +    write_unlock(&d->vpci_rwlock);
> +#endif
>       if ( ret )
>           goto out;
> 
> @@ -1474,6 +1480,9 @@ static int assign_device(struct domain *d, u16 seg, u8 bus, u8 devfn, u32 flag)
>       const struct domain_iommu *hd = dom_iommu(d);
>       struct pci_dev *pdev;
>       int rc = 0;
> +#ifdef CONFIG_HAS_VPCI
> +    struct domain *old_d;
> +#endif
> 
>       if ( !is_iommu_enabled(d) )
>           return 0;
> @@ -1487,15 +1496,34 @@ static int assign_device(struct domain *d, u16 seg, u8 bus, u8 devfn, u32 flag)
>       ASSERT(pdev && (pdev->domain == hardware_domain ||
>                       pdev->domain == dom_io));
> 
> +#ifdef CONFIG_HAS_VPCI
> +    /* pdev->domain is either hwdom or dom_io. We do not want the later. */
> +    old_d = pdev->domain == hardware_domain ? pdev->domain : NULL;
> +    if ( old_d )
> +        write_lock(&old_d->vpci_rwlock);
> +#endif
> +
>       rc = pdev_msix_assign(d, pdev);

I don't think you need the vpci lock for this operation.

>       if ( rc )
> +    {
> +#ifdef CONFIG_HAS_VPCI
> +        if ( old_d )
> +            write_unlock(&old_d->vpci_rwlock);
> +#endif
>           goto done;
> +    }
> 
>       pdev->fault.count = 0;
> 
>       if ( (rc = iommu_call(hd->platform_ops, assign_device, d, devfn,
>                             pci_to_dev(pdev), flag)) )
> +    {
> +#ifdef CONFIG_HAS_VPCI
> +        if ( old_d )
> +            write_unlock(&old_d->vpci_rwlock);
> +#endif

Like I've mentioned above, I'm unsure this is correct. You are holding
the lock of the previous domain, but at some point the device will be
assigned to a new domain, so that change won't be protected by the
lock of the new domain.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Feb 11 11:55:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 11:55:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270447.464741 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIUWS-0001Qu-UD; Fri, 11 Feb 2022 11:55:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270447.464741; Fri, 11 Feb 2022 11:55:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIUWS-0001Qn-Qw; Fri, 11 Feb 2022 11:55:32 +0000
Received: by outflank-mailman (input) for mailman id 270447;
 Fri, 11 Feb 2022 11:55:31 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=17AN=S2=epam.com=prvs=4041139d62=oleksii_moisieiev@srs-se1.protection.inumbo.net>)
 id 1nIUWQ-0001Qh-Uy
 for xen-devel@lists.xenproject.org; Fri, 11 Feb 2022 11:55:31 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8016106e-8b31-11ec-8f75-fffcc8bd4f1a;
 Fri, 11 Feb 2022 12:55:27 +0100 (CET)
Received: from pps.filterd (m0174681.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 21BBsQXm019262;
 Fri, 11 Feb 2022 11:55:22 GMT
Received: from eur05-vi1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2172.outbound.protection.outlook.com [104.47.17.172])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3e5qb88030-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 11 Feb 2022 11:55:21 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com (2603:10a6:102:ea::23)
 by AM6PR03MB3766.eurprd03.prod.outlook.com (2603:10a6:209:3c::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.16; Fri, 11 Feb
 2022 11:55:17 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::c1c:f98:9dd:86e0]) by PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::c1c:f98:9dd:86e0%6]) with mapi id 15.20.4975.015; Fri, 11 Feb 2022
 11:55:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8016106e-8b31-11ec-8f75-fffcc8bd4f1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ZRlKFcURWa14rnYOy0QRzz2Ja7FVBqI4tcC5qVTLc6MgCvUTvufIUNDqmF6poe+SZ1biXPq2VELv5RMzjIRD+0UvkEDqGPQfDl1v8Rs1+PiBqMqWprtidKcRGGG+MjoAYKf4S7+gBDBC5x7ctfaVQH5WJTPTpZa+GKfVfkC5aM1CjFE10Eg3URz18qzhohRqe2UHzRiTrBbq2JPm64Fp01bd5XKxRe2vifFRpFhUKegwUFrClipksLbSX2CnfEFC/Zgllo5osf6Q7v2VKQd/aF8NyaCRdDspL2XKPzM/g3Kl5QTI4/Oyd+SBmXD/MzdXCRaIH5rs7U+y3S9+RnTweQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=9Xwu2w50KWGs+cRVjivYdR7qfxGeMtP/wsxnk7kVkDg=;
 b=PKCYz4bvUJ0Bci9kaDKknAv2HQv84rdPo0ZGoZjNxFA5Mmu+3C0t6RRTi/+3akNiM7cEi0lq2H4kp7C096Y+A9M2QZ17Z4N4HxcnR9h6B+knjix/TmQQgKF0Iku6h0Ncsgta/wXy2DxiU5HRPx5Qm+4hUnfn3ipb80rQLegMqbTuODEknN2Dia5dD+a2kpvrTjARrXneNYvJJjtBkyipyGk69xPlBxib2TVAtjbRsHRhl/qROsRU42j52PK6Ipr7GMxyp90/cNwFfwoFr0Iowse5TV9GIIiJLROBTer2fwZwsGD9NPK8DBFkHB9EnGiaTmYHXcOlpbk26xYdxqUAtQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=9Xwu2w50KWGs+cRVjivYdR7qfxGeMtP/wsxnk7kVkDg=;
 b=GvGa2jhQh8OT/zhul7AASc81D6rtkT12U3V8EihNX9GBh83mJh0LFV70964vwx5iy6ams1W3XDyr6oC+XxNUB3DGSMt3cnHYA3ym+iqmaj9rC55zYgrlzTvloa4G88Zpe8Qk/xx0HxjIvGQRONj852V9q4Jc4ccXvmiS7ypt/4YeVCNfWjbTf7kdlDeuhOEowqkKgEacyaskROYVy8V+CIR64m8THEPvxWkhOOzOqokZiVjHUf2HkfQSIgUTXIPerJvxGTyugqL3SpWXrE2ftyOZGmDqTHUrqRg1yLb0OtTaJgITjOU3EvzyE5sLKfuLsQb2bXbxfY3024++Jy7VCQ==
From: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
To: Bertrand Marquis <bertrand.marquis@arm.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        Stefano
 Stabellini <sstabellini@kernel.org>,
        Julien Grall <julien@xen.org>,
        Volodymyr
 Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [RFC v2 5/8] xen/arm: introduce SCMI-SMC mediator driver
Thread-Topic: [RFC v2 5/8] xen/arm: introduce SCMI-SMC mediator driver
Thread-Index: AQHYHRW24Dmb0qV8ZkqAv39Pf6/nVayODW6AgAAg+ICAAAmzAIAACjMA
Date: Fri, 11 Feb 2022 11:55:16 +0000
Message-ID: <20220211115516.GA2356906@EPUAKYIW015D>
References: <cover.1644341635.git.oleksii_moisieiev@epam.com>
 <cb1493f5d9b5c3437268054b4a8e345cb35c8708.1644341635.git.oleksii_moisieiev@epam.com>
 <F9811680-C6EC-4372-A451-5C1DA279E35E@arm.com>
 <20220211104403.GA2291814@EPUAKYIW015D>
 <A9FF3FBC-C29D-4A17-8737-EBABEF240BA2@arm.com>
In-Reply-To: <A9FF3FBC-C29D-4A17-8737-EBABEF240BA2@arm.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 05a90a5f-84a8-46e5-4049-08d9ed555eec
x-ms-traffictypediagnostic: AM6PR03MB3766:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM6PR03MB3766EC7F8B6736AC7FE07C0BE3309@AM6PR03MB3766.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 gOrxDzCEhdSBKZ8L1rkYGGw2nmYghkQ+mXlad7VwNeSOG3iX/yEiWNk25EjA0+Yne0u45E3nbGeEQc+CCcQ2KCDmALkDxErqsHJN7b2P8Hsty+O8lFYqLmhdeuQJgThKzMNrCCjBKRS+SkBtVCD0t5H/+5/iUukOqIqR8mSOdUv4rITBlNDxGIgYz0OL59FOBeBuxB6baSwZtgIm4j3xmH3zyv1ruMuVO+YJqPpQYD76itbnQGVQYAFs/aXIKF1F8fL3uY3tNZJDOV9JwOEpj+iO2ziJyB/OmNFo/wVPYkaS6unOs/TuczuUSPPOxEQXaKwRE74tolG3Yy0RizopDrCauGZru/KDT1FLqsUkUGAW17beik6zg2MV5BydiMSfGIZF9QHiz7K6XSK0tHaztnnLAxn3PsQtXlRQRj8GcNumZmr0GpfkHpfwbAv/Bjjx39sxVBKQL79fAICTtCJ9OjFMXw5GFbHL0DNT4JYygnb8Spx2sM9djOd5Ol+0Q0b3mznyii3cGMrPFPMbZfDVzQ3/WJMiASasIUpjU/SOJeES0c77ilEAnidwtUA/NL6uaUIZB0PGoztJsxktljXn5S7CnmS1rBkLXHbVchKXNV8E4zR4f7ZPGwzuPbbriQNMIY1+4qShNzvUBd3uwMd8HAJMwRl8j3GQWqEC3Gitj3rEtIUZDkAoNVV4v891T6J7mhJflAx8UfMInyO3cZybLweydVxq1twwLILB8f9mVMw=
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR03MB7136.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(38100700002)(30864003)(5660300002)(122000001)(83380400001)(8936002)(316002)(38070700005)(8676002)(76116006)(66476007)(66446008)(64756008)(66946007)(2906002)(91956017)(66556008)(4326008)(6486002)(86362001)(71200400001)(26005)(186003)(107886003)(1076003)(33716001)(33656002)(6512007)(9686003)(6506007)(53546011)(54906003)(508600001)(6916009)(2004002)(579004)(559001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?U0JlL1JMc21lVERFWjgxVGl6MlZXR0luVXQxVDZnSmovUGNheDhjUkcxSHBE?=
 =?utf-8?B?ZWZmWHd3b2lkYTl1MGtmNmQ5cHRzQytqWnVKM0FUS1U0MlpEWC94TVMrK29G?=
 =?utf-8?B?c1dwSjh0ZTVSZjFPc2NLR0tBSm5FQU51ZUsxRFRMdU9iRVhVSGNDNFBYNEhP?=
 =?utf-8?B?SDkwQ0lZTUN3VnVOSEtoSnp6M28rcFpwZzhLRk44bmpvK0I0eUNvazh3U05k?=
 =?utf-8?B?bllPY1lLTWRoU2w1ampUS2NCL2dLUEpaYlJhL3UwK0lkZ3crNUdHK04vTkJi?=
 =?utf-8?B?alk0RTlmVW1NOHRMWUcyYmphN1RXMG0vZENyWU1ia05Jbm1XR2FUYTJTSGRG?=
 =?utf-8?B?eU9aU2kzc2pMai8vZ282K0o3emp5Nkd6MW5FcGNlTVV0TFA3cmVPS2hKNitr?=
 =?utf-8?B?K282Zkw3aitIN1pwNGdxRTNDNUljYnUyd1dOUUV2V0g1dXlxYy9ESnlBbGRq?=
 =?utf-8?B?WjNNQnRiTHJDTTlTOHpaM2QzcjJUSWZzK2VqODN4YjNNQ0ZtZHA5NmZlaWtE?=
 =?utf-8?B?dDdQQVVGYmhwUlk3eFZQQVpDb3creG90aHRXTVBqdmFNenhyUEZCNHpDV05K?=
 =?utf-8?B?cXNacGpkUVlBWm04TnJLcDVwUW0vclRGSFdIM1NEc3JTcTNFb0RFZzlnVUN3?=
 =?utf-8?B?NnUzb3FBL0tmYjlIVzY2YlU2MVVLZEFubWtIdkZkMlZUeEJhVjdXb0cvNzlY?=
 =?utf-8?B?OFVKbTRpa3JsbC9Vem1KaE9jMnl6cnp4czFGRG40bXpLME5VYjI5QzdqZ1VM?=
 =?utf-8?B?V2w3STJsZjhVU2M1Wk11SG41ajdSMGgyU1JVTzZIc1RVMlVyeDJRd045QU1X?=
 =?utf-8?B?dEJhVDdLcjF4V0k2WHZyZVpVQXhKNUpEV2Z5QVpYQk5lUFpEbk1hdytpK2pK?=
 =?utf-8?B?TlRmUWcrbUxGNWdGbXZDVGVvWjQ0di8rNzhGV0RRMGNJZzZZQVArZ1dVTDdL?=
 =?utf-8?B?N1BaRVBDdlQ2eWtFb1E4UTFNRUFrdUs2Z0xzd0k2MCtFUnpiTXhHS2dZSjRK?=
 =?utf-8?B?L3dTWTA4MndHVGZqS2wrdGdEVkpxSElyNmFNRGtNVWR4bWJXcEFGenBPMFNn?=
 =?utf-8?B?bk5QTEtSZ2JBY1p2NFNFUC9PdVZZcHY1N2ZyY1UxRjRhanB0ZTFDTFdKazlp?=
 =?utf-8?B?WHB3cVgxd21UY0RicjJnRkFMWW5qRStreGJNK3pYQ1Fwb3NNMSthV2lFdnVY?=
 =?utf-8?B?YS9NNnYrbmdGTTlqM3htTVZUM2NwQW84ZVIxR0RmVEt6cHpqeWtLR1Z4SzBl?=
 =?utf-8?B?Z3FscmYrWHFWR2s5NUc4Vmw3U0pTY0czTitrSlREdGhVSm43QjA0UkhuTUVG?=
 =?utf-8?B?UGE4T2xFTmdCdzJVTWtkTEVLL1NuMzRXYXB2cjJ4SVBOc0QvenpjeGVmL3U4?=
 =?utf-8?B?am5RVS9aZUV6c24wbWtZekNrQUZNVmRPOElMMU0rK1owMHNhUGZZdjNTU1pU?=
 =?utf-8?B?cUl6ZDFVeUVUZWlKRVI2UCsxVEh0TGFVR095K1dINWpTV3F2ZnRMS1QvZHJ1?=
 =?utf-8?B?NGNjVlk3bTJTYmFYMHI3aTdIa01vSnpyS3kxV204UGVJTDBKQlk3a3hORk53?=
 =?utf-8?B?SlZRZXQyN0lJQ3RxTDliZzJQZ200a0VnODJ1UE5vSlkvaGhTSEFsQllJdWFT?=
 =?utf-8?B?V0dJY2ZsVW52Ukh4L0Yyc3gwR0kwb2dreG5ZeURUai9Fbzh2d1BwSDc2SnM5?=
 =?utf-8?B?aGZvUS9NMFRjZU8wb2o0d1dnQVV5dzRMWjlOZjlGWDU0UnVSeVg4dVM4WmEy?=
 =?utf-8?B?ZWNpMStaRkg2WnEwK0NFSEgvcFRCbXAzbURIU3RiQWNEMTdGeXNyWmlySUh1?=
 =?utf-8?B?bElMdUpVckdqMllVTDNGSk1EOUs2QWVlQUZUdVRzQndFTjZPYjlSN3p5VUs3?=
 =?utf-8?B?VXBUNkZGcDg4KzVrWkhiY1pQcFM0ei9TWkM0TG5BTW9WRElZaVNTLzJBazZ1?=
 =?utf-8?B?bmhxcmMxdWI5R0ZBK2tIQnA3eUY2bXJBU2I1ZnhEVHZrMnlNSWxmNC80bEZT?=
 =?utf-8?B?YVd6NVpsenFUVkYrSUh3Ti9XQ3A1ZVJtRnZIaFZ2MXpDdjU0T2haKzhQUCtJ?=
 =?utf-8?B?eTlDMjNKcnREZ3drU3RKUFkwN0dLYlpscmlLVmdwdzZ3ZGs5RUdCL2dnbzFC?=
 =?utf-8?B?SUdBL0NPRGE3SnVtYjgzTkVHZThPaHJacmJEOHBTUlhtM2l4VUJGa1lXMHds?=
 =?utf-8?B?czhQMU9MbEhPVkVtcVNsUmdWTHV6ZkdmTXFKMDM1RWgzOHdYWk5weXVzR0pr?=
 =?utf-8?Q?YVz4JX7Uq/LeXt46dSr2KhvU26a1qF7Df1018yzhGk=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <64C95FEB86E9C843B4DCE5455993071C@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR03MB7136.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 05a90a5f-84a8-46e5-4049-08d9ed555eec
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Feb 2022 11:55:16.8774
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 5xxE+VimKgFdtiHTfE39tMb0ESb4ztH+ebabAiHzYPerB5v5UkVaYqZ3fSr5GN6kYfJyKG2/NeoBliJ38mp4DbDb72tBhBWkMmXYpHu19zU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR03MB3766
X-Proofpoint-ORIG-GUID: h4zJtP6bE7Td4CVsu0T81_8UI7v2tpNg
X-Proofpoint-GUID: h4zJtP6bE7Td4CVsu0T81_8UI7v2tpNg
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-11_04,2022-02-11_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0
 mlxlogscore=999 priorityscore=1501 malwarescore=0 adultscore=0
 phishscore=0 spamscore=0 impostorscore=0 mlxscore=0 bulkscore=0
 clxscore=1015 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2201110000 definitions=main-2202110068

T24gRnJpLCBGZWIgMTEsIDIwMjIgYXQgMTE6MTg6NDdBTSArMDAwMCwgQmVydHJhbmQgTWFycXVp
cyB3cm90ZToNCj4gSGkgT2xla3NpaSwNCj4gDQo+IA0KPiA+IE9uIDExIEZlYiAyMDIyLCBhdCAx
MDo0NCwgT2xla3NpaSBNb2lzaWVpZXYgPE9sZWtzaWlfTW9pc2llaWV2QGVwYW0uY29tPiB3cm90
ZToNCj4gPiANCj4gPiBIaSBCZXJ0cmFuZCwNCj4gPiANCj4gPiBPbiBGcmksIEZlYiAxMSwgMjAy
MiBhdCAwODo0NjowNUFNICswMDAwLCBCZXJ0cmFuZCBNYXJxdWlzIHdyb3RlOg0KPiA+PiBIaSBP
bGVrc2lpLA0KPiA+PiANCj4gPj4gDQo+ID4+PiBPbiA4IEZlYiAyMDIyLCBhdCAxODowMCwgT2xl
a3NpaSBNb2lzaWVpZXYgPE9sZWtzaWlfTW9pc2llaWV2QGVwYW0uY29tPiB3cm90ZToNCj4gPj4+
IA0KPiA+Pj4gVGhpcyBpcyB0aGUgaW1wbGVtZW50YXRpb24gb2YgU0NJIGludGVyZmFjZSwgY2Fs
bGVkIFNDTUktU01DIGRyaXZlciwNCj4gPj4+IHdoaWNoIHdvcmtzIGFzIHRoZSBtZWRpYXRvciBi
ZXR3ZWVuIFhFTiBEb21haW5zIGFuZCBGaXJtd2FyZSAoU0NQLCBBVEYgZXRjKS4NCj4gPj4+IFRo
aXMgYWxsb3dzIGRldmljZXMgZnJvbSB0aGUgRG9tYWlucyB0byB3b3JrIHdpdGggY2xvY2tzLCBy
ZXNldHMgYW5kDQo+ID4+PiBwb3dlci1kb21haW5zIHdpdGhvdXQgYWNjZXNzIHRvIENQRy4NCj4g
Pj4+IA0KPiA+Pj4gT3JpZ2luYWxseSwgY3BnIHNob3VsZCBiZSBwYXNzZWQgdG8gdGhlIGRvbWFp
biBzbyBpdCBjYW4gd29yayB3aXRoDQo+ID4+PiBwb3dlci1kb21haW5zL2Nsb2Nrcy9yZXNldHMg
ZXRjLiBDb25zaWRlcmluZyB0aGF0IGNwZyBjYW4ndCBiZSBzcGxpdCBiZXR3ZWVuDQo+ID4+PiB0
aGUgRG9tYWlucywgd2UgZ2V0IHRoZSBsaW1pdGF0aW9uIHRoYXQgdGhlIGRldmljZXMsIHdoaWNo
IGFyZSB1c2luZw0KPiA+Pj4gcG93ZXItZG9tYWlucy9jbG9ja3MvcmVzZXRzIGV0YywgY291bGRu
J3QgYmUgc3BsaXQgYmV0d2VlbiB0aGUgZG9tYWlucy4NCj4gPj4+IFRoZSBzb2x1dGlvbiBpcyB0
byBtb3ZlIHRoZSBwb3dlci1kb21haW4vY2xvY2svcmVzZXRzIGV0YyB0byB0aGUNCj4gPj4+IEZp
cm13YXJlIChzdWNoIGFzIFNDUCBmaXJtd2FyZSBvciBBVEYpIGFuZCBwcm92aWRlIGludGVyZmFj
ZSBmb3IgdGhlDQo+ID4+PiBEb21haW5zLiBYRU4gc2hvdWxkIGhhdmUgYW4gZW50aXR5LCBjYWxl
ZCBTQ0ktTWVkaWF0b3IsIHdoaWNoIGlzDQo+ID4+PiByZXNwb25zaWJsZSBmb3IgbWVzc2FnZXMg
cmVkaXJlY3Rpb24gYmV0d2VlbiBEb21haW5zIGFuZCBGaXJtd2FyZSBhbmQNCj4gPj4+IGZvciBw
ZXJtaXNzaW9uIGhhbmRsaW5nLg0KPiA+Pj4gDQo+ID4+PiBUaGUgZm9sbG93aW5nIGZlYXR1cmVz
IGFyZSBpbXBsZW1lbnRlZDoNCj4gPj4+IC0gcmVxdWVzdCBTQ01JIGNoYW5uZWxzIGZyb20gQVRG
IGFuZCBwYXNzIGNoYW5uZWxzIHRvIERvbWFpbnM7DQo+ID4+PiAtIHNldCBkZXZpY2UgcGVybWlz
c2lvbnMgZm9yIERvbWFpbnMgYmFzZWQgb24gdGhlIERvbWFpbiBwYXJ0aWFsDQo+ID4+PiBkZXZp
Y2UtdHJlZS4gRGV2aWNlcyB3aXRoIHBlcm1pc3Npb25zIGFyZSBhYmxlIHRvIHdvcmsgd2l0aCBj
bG9ja3MsDQo+ID4+PiByZXNldHMgYW5kIHBvd2VyLWRvbWFpbnMgdmlhIFNDTUk7DQo+ID4+PiAt
IHJlZGlyZWN0IHNjbWkgbWVzc2FnZXMgZnJvbSBEb21haW5zIHRvIEFURi4NCj4gPj4gDQo+ID4+
IEJlZm9yZSBnb2luZyBtb3JlIGRlZXBseSBpbiB0aGUgY29kZSBJIHdvdWxkIGxpa2UgdG8gZGlz
Y3VzcyB0aGUgZ2VuZXJhbA0KPiA+PiBkZXNpZ24gaGVyZSBhbmQgYXNrIHNvbWUgcXVlc3Rpb25z
IHRvIHByZXZlbnQgdG8gcmV3b3JrIHRoZSBjb2RlIGJlZm9yZQ0KPiA+PiB3ZSBhbGwgYWdyZWUg
dGhhdCB0aGlzIGlzIHRoZSByaWdodCBzb2x1dGlvbiBhbmQgdGhhdCB3ZSB3YW50IHRoaXMgaW4g
WGVuLg0KPiA+PiANCj4gPj4gRmlyc3QgSSB3YW50IHRvIHBvaW50IG91dCB0aGF0IGNsb2NrL3Jl
c2V0L3Bvd2VyIHZpcnR1YWxpemF0aW9uIGlzIGEgcHJvYmxlbQ0KPiA+PiBvbiBtb3N0IGFwcGxp
Y2F0aW9ucyB1c2luZyBkZXZpY2UgcGFzcy10aHJvdWdoIGFuZCBJIGFtIHZlcnkgZ2xhZCB0aGF0
DQo+ID4+IHNvbWVvbmUgaXMgbG9va2luZyBpbnRvIGl0Lg0KPiA+PiBBbHNvIFNDTUkgaXMgdGhl
IGN1cnJlbnQgc3RhbmRhcmQgZXhpc3RpbmcgZm9yIHRoaXMgc28gcmVseWluZyBvbiBpdCBpcyBh
IHZlcnkNCj4gPj4gZ29vZCBpZGVhLg0KPiA+PiANCj4gPj4gTGF0ZXN0IHZlcnNpb24gU0NNSSBz
dGFuZGFyZCAoREVOMDA1NkQgdjMuMSkgaXMgZGVmaW5pbmcgc29tZSBtZWFucw0KPiA+PiB0byB1
c2UgU0NNSSBvbiBhIHZpcnR1YWxpc2VkIHN5c3RlbS4gSW4gY2hhcHRlciA0LjIuMSwgdGhlIHN0
YW5kYXJkDQo+ID4+IHJlY29tbWVuZHMgdG8gc2V0IHBlcm1pc3Npb25zIHBlciBhZ2VudCBpbiB0
aGUgaHlwZXJ2aXNvciBzbyB0aGF0IGEgVk0NCj4gPj4gY291bGQgbGF0ZXIgdXNlIHRoZSBkaXNj
b3ZlcnkgcHJvdG9jb2wgdG8gZGV0ZWN0IHRoZSByZXNvdXJjZXMgYW5kIHVzZSB0aGVtLg0KPiA+
PiBVc2luZyB0aGlzIGtpbmQgb2Ygc2NlbmFyaW8gdGhlIG1lZGlhdG9yIGluIFhlbiB3b3VsZCBq
dXN0IGNvbmZpZ3VyZSB0aGUNCj4gPj4gUGVybWlzc2lvbnMgaW4gdGhlIFNDTUkgYW5kIHdvdWxk
IHRoZW4gcmVseSBvbiBpdCB0byBsaW1pdCB3aGF0IGlzIHBvc3NpYmxlDQo+ID4+IGJ5IHdobyBq
dXN0IGJ5IGp1c3QgYXNzaWduaW5nIGEgY2hhbm5lbCB0byBhIFZNLg0KPiA+IA0KPiA+PiANCj4g
Pj4gSW4geW91ciBjdXJyZW50IGRlc2lnbiAocGxlYXNlIGNvcnJlY3QgbWUgaWYgSSBhbSB3cm9u
ZykgeW91IHNlZW0gdG8gZnVsbHkNCj4gPj4gcmVseSBvbiBYZW4gYW5kIHRoZSBGRFQgZm9yIGRp
c2NvdmVyeSBhbmQgcGVybWlzc2lvbi4NCj4gPiANCj4gPiBJbiBjdXJyZW50IGltcGxlbWVudGF0
aW9uIFhlbiBpcyB0aGUgdHJ1c3RlZCBhZ2VudC4gQW5kIGl0J3MgcmVzcG9uc2libGUNCj4gPiBm
b3IgcGVybWlzc2lvbnMgc2V0dGluZy4gRHVyaW5nIGluaXRpYWxpemF0aW9uIGl0IGRpc2NvdmVy
cyBhZ2VudCBhbmQNCj4gPiBzZXQgcGVybWlzc2lvbnMgYnkgdXNpbmcgQkFTRV9TRVRfREVWSUNF
X1BFUk1JU1NJT05TIHRvIHRoZSBEb20wLiBXaGVuDQo+ID4gbmV3IGRvbWFpbiBpcyBjcmVhdGVk
LCBYZW4gYXNzaWducyBhZ2VudCBpZCBmb3IgdGhpcyBkb21haW4gYW5kIHJlcXVlc3QNCj4gPiBy
ZXNvdXJjZXMsIHRoYXQgYXJlIHBhc3NlZC10aHJvdWdoIHRvIHRoaXMgRG9tYWluLg0KPiANCj4g
T2sNCj4gDQo+ID4gDQo+ID4gSSdtIGdldHRpbmcgdGhlIGZvbGx3aW5nIGluZm9ybWF0aW9uIGZy
b20gRkRUOg0KPiA+IDEpIFNoYXJlZCBtZW1vcnkgYWRkcmVzc2VkLCB3aGljaCBzaG91bGQgYmUg
dXNlZCBmb3IgYWdlbnRzLiBEdXJpbmcNCj4gPiBpbml0aWFsaXphdGlvbiBJIHNlbmQgQkFTRV9E
SVNDT1ZFUl9BR0VOVCB0byBlYWNoIG9mIHRoaXMgYWRkcmVzc2VzIGFuZA0KPiA+IHJlY2VpdmUg
YWdlbnRfaWQuIFhlbiBpcyByZXNwb25zaWJsZSBmb3IgYXNzaWduaW5nIGFnZW50X2lkIGZvciB0
aGUNCj4gPiBEb21haW4uIFRoZW4gWGVuIGludGVyY2VwdCBzbWMgY2FsbHMgZnJvbSB0aGUgZG9t
YWluLCBzZXQgYWdlbnRfaWQgYW5kDQo+ID4gcmVkaXJlY3RzIGl0IHRvIHRoZSBGaXJtd2FyZS4N
Cj4gDQo+IFNvIFhlbiBpcyBzZXR0aW5nIHRoZSBhZ2VudCBJRCwgbm8gd2F5IGZvciBhIGd1ZXN0
IHRvIGdldCBhY2Nlc3MgdG8gc29tZXRoaW5nIGl0DQo+IHNob3VsZCB3aXRoIG1vcmUgY2hlY2ss
IGFtIEkgcmlnaHQgPw0KPiANCg0KWWVzLiBYZW4gaXMgdGhlIG9ubHkgZW50aXR5LCB3aGljaCBp
cyB0cnVzdGVkLiBTbyBpdCdzIHJlc3BvbnNpYmxlIGZvcg0Kc2V0dGluZyBwZXJtaXNzaW9ucyBh
bmQgYXNzaWduaW5nIGFnZW50X2lkLiBHdWVzdCBnZXQncyBhbiBhY2Nlc3Mgb25seQ0KZm9yIHRo
ZSBkZXZpY2VzIGl0J3MgYWxsb3dlZCB0by4NCg0KPiA+IA0KPiA+IDIpIERldmljZXMsIHRoYXQg
YXJlIHVzaW5nIFNDTUkuIFRob3NlIGRldmljZXMgaGFzIGNsb2NrL3Bvd2VyL3Jlc2V0cw0KPiA+
IGV0YyByZWxhdGVkIHRvIHNjbWkgcHJvdG9jb2wgKGFzIGl0IGlzIGRvbmUgaW4gTGludXgga2Vy
bmVsKQ0KPiA+IGFuZCBzY21pX2RldmlkIHNob3VsZCBiZSBzZXQuIEknbSBjdXJyZW50bHkgcHJl
cGFyaW5nIHRvIHNlbmQgcGF0Y2gsDQo+ID4gdXBkYXRpbmcga2VybmVsIGJpbmRpbmdzIHdpdGgg
dGhpcyBwYXJhbWV0ZXIgdG8gTGludXgga2VybmVsLg0KPiA+IHNjbWlfZGV2aWQgdmFsdWUgc2hv
dWxkIG1hdGNoIGRldmljZSBpZCwgc2V0IGluIHRoZSBGaXJtd2FyZS4NCj4gPiBkdCBleGFtcGxl
Og0KPiA+ICZ1c2IwIHsNCj4gPiAgICBzY21pX2RldmlkID0gPDE+OyAvLyB1c2IwIGRldmljZSBp
ZA0KPiA+ICAgIGNsb2NrcyA9IDwmc2NtaV9jbG9jayAxPiAvLyByZWxheXMgb24gY2xvY2sgd2l0
aCBpZCAxDQo+ID4gfQ0KPiA+IA0KPiA+IFhlbiByZXF1ZXN0cyBwZXJtaXNzaW9uIGZvciB0aGUg
ZGV2aWNlIHdoZW4gZGV2aWNlIGlzIGF0dGFjaGVkIHRvIHRoZQ0KPiA+IERvbWFpbiBkdXJpbmcg
Y3JlYXRpb24uDQo+IA0KPiBXaXRob3V0IHRoaXMsIGhvdyBpcyAoaWYgaXQgaXMpIHRoZSBsaW51
eCBrZXJuZWwgdXNpbmcgU0NNSSBmb3IgcG93ZXIgbWFuYWdlbWVudCA/DQoNCkhlcmUgaXMgaG93
IGl0IHNob3VsZCBiZSBkZXNyaWJlZCBpbiBGRFQ6IA0KLw0Kew0KICAgIGZpcm13YXJlIHsNCiAg
ICAgICAgc2NtaSB7DQogICAgICAgICAgICBhcm0sc21jLWlkID0gPDB4ODIwMDAwMDI+Ow0KICAg
ICAgICAgICAgc2NtaV9wb3dlcjogcHJvdG9jb2xAMTEgew0KICAgICAgICAgICAgICAgIHJlZyA9
IDwweDExPjsNCiAgICAgICAgICAgICAgICAjcG93ZXItZG9tYWluLWNlbGxzID0gPDE+Ow0KICAg
ICAgICAgICAgfTsNCiAgICAgICAgICAgIC4uLg0KICAgICAgICAgICAgc2NtaV9jbG9jazogcHJv
dG9jb2xAMTQgew0KICAgICAgICAgICAgLi4uDQogICAgICAgICAgICBzY21pX3Jlc2V0OiBwcm90
b2NvbEAxNiB7DQogICAgICAgICAgICAuLi4NCiAgICAgICAgfTsNCiAgICB9Ow0KfTsNCg0KJmF2
YiB7DQogICAgc2NtaV9kZXZpZCA9IDwwPjsgLy8gTWF0Y2hlcyBFdGhlcm5lZCBkZXZpY2VfaWQg
aW4gRmlybXdhcmUNCiAgICBjbG9ja3MgPSA8JnNjbWlfY2xvY2sgMD47DQogICAgcG93ZXItZG9t
YWlucyA9IDwmc2NtaV9wb3dlciAwPjsNCiAgICByZXNldHMgPSA8JnNjbWlfcmVzZXQgMD47DQp9
Ow0KDQpJbiB0aGUgcHJvdmlkZWQgY2FzZSBkZXZpZCBlcXVhbHMgdG8gcmVzZXQsIGNsb2NrIGFu
ZCBwb3dlci1kb21haW4gaWQsDQpidXQgdGhpcyBpcyBjb25pY2lkZW5jZS4gRWFjaCBjbG9jay9w
b3dlci1kb21haW4vcmVzZXQgcGFyYW1ldGVyIGNhbg0KaGF2ZSBtb3JlIHRoYW4gb25lIGVudGl0
eS4NCkFsc28gLSBubyBjaGFuZ2VzIHdhcyBkb25lIHRvIGxpbnV4IGtlcm5lbCBzY21pIGRyaXZl
cnMuDQoNCj4gDQo+ID4gDQo+ID4+IFdvdWxkbuKAmXQgaXQgYmUgYSBiZXR0ZXIgaWRlYSB0byB1
c2UgdGhlIHByb3RvY29sIGZ1bGx5ID8NCj4gPiANCj4gPiBIbSwgSSB3YXMgdGhpbmtpbmcgSSBh
bSB1c2luZyB0aGUgcHJvdG9jb2wgZnVsbHkuIERpZCBJIG1pc3Mgc29tZXRoaW5nPw0KPiANCj4g
U29ycnkgeW91IHNlZW0gdG8gYmUsIG15IHVuZGVyc3RhbmRpbmcgb2YgeW91ciBkZXNpZ24gd2Fz
IG5vdCByaWdodC4NCj4gDQo+ID4gDQo+ID4+IENvdWxkIHdlIGdldCByaWQgb2Ygc29tZSBvZiB0
aGUgRkRUIGRlcGVuZGVuY2llcyBieSB1c2luZyB0aGUgZGlzY292ZXJ5DQo+ID4+IHN5c3RlbSBv
ZiBTQ01JID8NCj4gPiANCj4gPiBJJ20gdXNpbmcgRkRUIHRvIGdldCBzaG1lbSByZWdpb25zIGZv
ciB0aGUgY2hhbm5lbHMuIFRoZW4gSSBzZW5kDQo+ID4gQkFTRV9ESVNDT1ZFUl9BR0VOVCB0byBl
YWNoIHJlZ2lvbiBhbmQgZ2V0dGluZyBhZ2VudCBkYXRhLiBEaWQgSSB1c2UgdGhlDQo+ID4gZGlz
Y292ZXJ5IHN5c3RlbSB3cm9uZz8NCj4gDQo+IEFmdGVyIG1vcmUgZGlnZ2luZyBpdCBzZWVtcyB5
b3UgYXJlLiBUaGUgbGluayBiZXR3ZWVuIHNjbWkgcmVzb3VyY2UgYW5kIGRldmljZQ0KPiBpcyBu
b3QgcG9zc2libGUgdG8gZ2V0IGF1dG9tYXRpY2FsbHkuDQo+IA0KPiA+IA0KPiA+PiBIb3cgaXMg
TGludXggZG9pbmcgdGhpcyBjdXJyZW50bHkgPyBJcyBpdCByZWx5aW5nIG9uIGRldmljZSB0cmVl
IHRvIGRpc2NvdmVyDQo+ID4+IHRoZSBTQ01JIHJlc291cmNlcyA/DQo+ID4gDQo+ID4gWWVzLiBM
aW51eCBrZXJuZWwgaGFzIDIgbm9kZXMgaW4gdGhlIGRldmljZS10cmVlOiBhcm0sc2NtaS1zaG1l
bSwgd2hpY2gNCj4gPiBpbmNsdWRlcyBtZW1vcnkgcmVnaW9uIGZvciB0aGUgY29tbXVuaWNhdGlv
biBhbmQgYXJtLHNjbWktc21jIG5vZGUsDQo+ID4gd2hpY2ggZGVzY3JpYmVzIGFsbCBkYXRhIHJl
bGF0ZWQgdG8gc2NtaSAoIGZ1bmNfaWQsIHByb3RvY29scyBldGMpDQo+ID4gVGhlbiB0aGUgZGV2
aWNlIG5vZGVzIHJlZmVyIHRvIHRoZSBwcm90b2NvbHMgYnkgc2V0dGluZw0KPiA+IGNsb2NrL3Jl
c2V0cy9wb3dlci1kb21haW5zIGV0Yy4gUGxlYXNlIHNlZSB0aGUgZXhhbXBsZSBhYm92ZS4NCj4g
PiBCQVNFX0RJU0NPVkVSX0FHRU5UIGlzIG5vdCB1c2VkIGluIExpbnV4IGtlcm5lbC4NCj4gPiBU
aGUgbWFpbiBpZGVhIHdhcyB0aGF0IHNjbWkgcmVsYXRlZCBjaGFuZ2VzIHRvIHRoZSBkZXZpY2Ut
dHJlZSBhcmUNCj4gPiBjb21tb24gZm9yIHZpcnR1YWxpemVkIGFuZCBub24gdmlydHVhbGl6ZWQg
c3lzdGVtcy4gU28gdGhlIHNhbWUgRkRUDQo+ID4gY29uZmlndXJhdGlvbiBzaG91bGQgd29yayB3
aXRoIG9mIHdpdGhvdXQgWGVuLg0KPiANCj4gU28gYXQgdGhpcyBzdGFnZSB0aGlzIGlzIG5vdCBz
dXBwb3J0ZWQgaW4gTGludXggYW5kIHlvdSBwbGFuIHRvIGFkZCBzdXBwb3J0IGZvciBpdCB0by4N
Cj4gDQoNClllcy4gVGhhdCdzIGNvcnJlY3QuIEkndmUgYWxyZWFkeSBwcmVwYXJlZCBwYXRjaCB3
aGljaCBzaG91bGQgdXBkYXRlDQpsaW51eCBrZXJuZWwgZGV2aWNlLXRyZWUgYmluZGluZ3MuDQoN
Cj4gPiANCj4gPj4gDQo+ID4+IEFsc28gSSB1bmRlcnN0YW5kIHRoYXQgeW91IHJlbHkgb24gc29t
ZSBlbnRyaWVzIHRvIGJlIGRlY2xhcmVkIGluIHRoZSBkZXZpY2UNCj4gPj4gdHJlZSBhbmQgYWxz
byBzb21lIHN1cHBvcnQgdG8gYmUgaW1wbGVtZW50ZWQgaW4gQVRGIG9yIFNDUC4gSSBjaGVja2Vk
IGluDQo+ID4+IFRoZSBib2FyZHMgSSBoYXZlIGFjY2VzcyB0byBhbmQgdGhlIGRldmljZSB0cmVl
cyBidXQgbm9uZSBvZiB0aGlzIHNlZW0gdG8NCj4gPj4gYmUgc3VwcG9ydGVkIHRoZXJlLiBDb3Vs
ZCB5b3UgdGVsbCB3aGljaCBib2FyZC9jb25maWd1cmF0aW9uL0FURiB5b3UgYXJlDQo+ID4+IHVz
aW5nIHNvIHRoYXQgdGhlIGltcGxlbWVudGF0aW9uIGNvdWxkIGJlIHRlc3RlZC92YWxpZGF0ZWQg
Pw0KPiA+PiANCj4gPiANCj4gPiBXZSdyZSBjdXJyZW50bHkgaGF2ZSBQT0MgbWFkZSBmb3Igcjhh
Nzc5NTEtdWxjYi1rZiBhbmQNCj4gPiByOGE3Nzk2MS1zYWx2YXRvci14cyBib2FyZHMuIEl0J3Mg
YmFzZWQgb246DQo+ID4gTGludXgtYnNwIGtlcm5lbDogDQo+ID4gZ2l0QGdpdGh1Yi5jb206cmVu
ZXNhcy1yY2FyL2xpbnV4LWJzcC5naXQNCj4gPiBiYXNlZCBvbiB0YWcgPHJjYXItNS4wLjAucmM0
Pg0KPiA+IA0KPiA+IEFURjogDQo+ID4gZ2l0QGdpdGh1Yi5jb206cmVuZXNhcy1yY2FyL2FybS10
cnVzdGVkLWZpcm13YXJlLmdpdA0KPiA+IGJhc2VkIG9uIGJyYW5jaCA8cmNhcl9nZW4zX3YyLjU+
DQo+ID4gDQo+ID4gSSBjYW4gcHVzaCB0aG9zZSBjaGFuZ2VzIHRvIEdpdGh1Yiwgc28geW91IGNh
biByZXZpZXcgdGhlbQ0KPiANCj4gRG8geW91IHBsYW4gdG8gYWRkIHN1cHBvcnQgZm9yIG90aGVy
IGJvYXJkcyA/DQo+IA0KDQpSaWdodCBub3cgd2UncmUgd29ya2luZyBvbmx5IHdpdGggcjhhNzc5
NTEgYW5kIHI4YTc3OTYxIGJvYXJkcy4NCg0KPiBEaWQgeW91IGRpc2N1c3MgbW9yZSBpbiBnZW5l
cmFsIHdpdGggdGhlIGxpbnV4IGtlcm5lbCBndXlzIHRvIHNlZSBpZiB0aGlzDQo+IGFwcHJvYWNo
IHdhcyBhZ3JlZWQgYW5kIHdpbGwgYmUgYWRvcHRlZCBieSBvdGhlciBtYW51ZmFjdHVyZXJzID8N
Cg0KSSBkaWRuJ3QuIEkndmUgY29udGFjdGVkIFN1ZGVlcCBIb2xsYSA8c3VkZWVwLmhvbGxhQGFy
bS5jb20+LCB3aG8gaXMgdGhlDQptYWludGFpbmVyIG9mIHRoZSBTQ01JIHByb3RvY29sIGRyaXZl
cnMuIFdhaXRpbmcgZm9yIHRoZSByZXNwb25zZS4NCg0KQWxzbyB3ZSBwcm9wb3NlZCB0byBhZGQg
UGluY3RsIHN1cHBvcnQgdG8gU0NNSSBzcGVjaWZpY2F0aW9uLiBJdCB3YXMNCmFncmVlZCBhbmQg
c2hvdWxkIGJlIGFkZGVkIHRvIFNDTUkgcHJvdG9jb2wgaW4gU0NNSXYzLjIgKGR1ZSBlbmQtMjAy
Mi9lYXJseSAyMDIzKS4NCg0KPiANCj4gQWxsIGluIGFsbCBJIHRoaW5rIHRoaXMgaXMgYSBnb29k
IGlkZWEgYnV0IEkgZmVhciB0aGF0IGFsbCB0aGlzIHdpbGwgYWN0dWFsbHkgb25seQ0KPiBiZSB1
c2VkIGJ5IG9uZSBib2FyZCBvciBvbmUgbWFudWZhY3R1cmVyIGFuZCBvdGhlciBtaWdodCB1c2Ug
YSBkaWZmZXJlbnQNCj4gc3RyYXRlZ3ksIEkgd291bGQgbGlrZSB0byB1bnJpc2sgdGhpcyBiZWZv
cmUgbWVyZ2luZyB0aGlzIGluIFhlbi4NCg0KVGhlIG1haW4gaWRlYSB3YXMgdG8gbWFrZSBYZW4g
U0NNSSBtZWRpYXRvciBjb21wbGV0ZWx5IHRyYW5zcGFyZW50IGZyb20NCnRoZSBEb21haW4gcG9p
bnQgb2Ygdmlldy4gU28gdGhlcmUgaXMgbm8gWGVuIHNwZWNpZmljIGNoYW5nZXMgc2hvdWxkIGJl
DQpkb25lIHRvIE9TIHBpbmN0cmwgZHJpdmVycyB0byB3b3JrIHRocm91Z2ggU0NNSS4NCg0KVGhp
cyBtZWFucyB0aGF0IGFsbCBwbGF0Zm9ybXMsIHRoYXQgYWxyZWFkeSB1c2luZyBTQ01JIGNhbiB3
b3JrIHdpdGggaXQNCmluIHZpcnR1YWxpemVkIHN5c3RlbS4NCg0KQWxzbyB0aGUgYWR2YW50YWdl
IGlzIHRoYXQgdGhlIGRldmljZXMsIHBhc3NlZC10aHJvdWdoIHRoZQ0KRG9tYWlucywgd2hpY2gg
ZG9lc24ndCBoYXZlIGFuIGFjY2VzcyB0byBDUEcsIGNhbiBhY2Nlc3MgdG8NCmNsb2Nrcy9yZXNl
dHMgYW5kIHBvd2VyLWRvbWFpbnMuIFdlIGFscmVhZHkgaGF2ZSBQaW5jdGwgcHJvdG9jb2wgUE9D
LCBzbw0KdGhlIGRldmljZXMgZnJvbSBkaWZmZXJlbnQgRG9tYWlucyBjYW4gYWNjZXNzIHBpbnMg
ZWl0aGVyLg0KDQotLQ0KT2xla3NpaS4NCj4gDQo+IEBqdWxpZW4gYW5kIFN0ZWZhbm86IHdoYXQg
aXMgeW91ciB2aWV3IGhlcmUgPw0KPiANCj4gQ2hlZXJzDQo+IEJlcnRyYW5kDQo+IA0KPiA+IA0K
PiA+IEJlc3QgcmVnYXJkcywNCj4gPiBPbGVrc2lpLg0KPiA+IA0KPiA+PiANCj4gPj4gUmVnYXJk
cw0KPiA+PiBCZXJ0cmFuZA0KPiA+PiANCj4gPj4gDQo+ID4+PiANCj4gPj4+IFNpZ25lZC1vZmYt
Ynk6IE9sZWtzaWkgTW9pc2llaWV2IDxvbGVrc2lpX21vaXNpZWlldkBlcGFtLmNvbT4NCj4gPj4+
IC0tLQ0KPiA+Pj4geGVuL2FyY2gvYXJtL0tjb25maWcgICAgICAgIHwgICAyICsNCj4gPj4+IHhl
bi9hcmNoL2FybS9zY2kvS2NvbmZpZyAgICB8ICAxMCArDQo+ID4+PiB4ZW4vYXJjaC9hcm0vc2Np
L3NjbWlfc21jLmMgfCA5NTkgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrDQo+
ID4+PiAzIGZpbGVzIGNoYW5nZWQsIDk3MSBpbnNlcnRpb25zKCspDQo+ID4+PiBjcmVhdGUgbW9k
ZSAxMDA2NDQgeGVuL2FyY2gvYXJtL3NjaS9LY29uZmlnDQo+ID4+PiBjcmVhdGUgbW9kZSAxMDA2
NDQgeGVuL2FyY2gvYXJtL3NjaS9zY21pX3NtYy5jDQo+ID4+PiANCj4gPj4+IGRpZmYgLS1naXQg
YS94ZW4vYXJjaC9hcm0vS2NvbmZpZyBiL3hlbi9hcmNoL2FybS9LY29uZmlnDQo+ID4+PiBpbmRl
eCBhYjA3ODMzNTgyLi4zYjBkZmM1N2I2IDEwMDY0NA0KPiA+Pj4gLS0tIGEveGVuL2FyY2gvYXJt
L0tjb25maWcNCj4gPj4+ICsrKyBiL3hlbi9hcmNoL2FybS9LY29uZmlnDQo+ID4+PiBAQCAtMTIz
LDYgKzEyMyw4IEBAIGNvbmZpZyBBUk1fU0NJDQo+ID4+PiAJICBzdXBwb3J0LiBJdCBhbGxvd3Mg
Z3Vlc3RzIHRvIGNvbnRyb2wgc3lzdGVtIHJlc291cmNlc3MgdmlhIG9uZSBvZg0KPiA+Pj4gCSAg
QVJNX1NDSSBtZWRpYXRvcnMgaW1wbGVtZW50ZWQgaW4gWEVOLg0KPiA+Pj4gDQo+ID4+PiArCXNv
dXJjZSAiYXJjaC9hcm0vc2NpL0tjb25maWciDQo+ID4+PiArDQo+ID4+PiBlbmRtZW51DQo+ID4+
PiANCj4gPj4+IG1lbnUgIkFSTSBlcnJhdGEgd29ya2Fyb3VuZCB2aWEgdGhlIGFsdGVybmF0aXZl
IGZyYW1ld29yayINCj4gPj4+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vc2NpL0tjb25maWcg
Yi94ZW4vYXJjaC9hcm0vc2NpL0tjb25maWcNCj4gPj4+IG5ldyBmaWxlIG1vZGUgMTAwNjQ0DQo+
ID4+PiBpbmRleCAwMDAwMDAwMDAwLi4xMGI2MzRkMmVkDQo+ID4+PiAtLS0gL2Rldi9udWxsDQo+
ID4+PiArKysgYi94ZW4vYXJjaC9hcm0vc2NpL0tjb25maWcNCj4gPj4+IEBAIC0wLDAgKzEsMTAg
QEANCj4gPj4+ICtjb25maWcgU0NNSV9TTUMNCj4gPj4+ICsJYm9vbCAiRW5hYmxlIFNDTUktU01D
IG1lZGlhdG9yIGRyaXZlciINCj4gPj4+ICsJZGVmYXVsdCBuDQo+ID4+PiArCWRlcGVuZHMgb24g
QVJNX1NDSSAmJiBIT1NUX0RUQl9FWFBPUlQNCj4gPj4+ICsJLS0taGVscC0tLQ0KPiA+Pj4gKw0K
PiA+Pj4gKwlFbmFibGVzIG1lZGlhdG9yIGluIFhFTiB0byBwYXNzIFNDTUkgcmVxdWVzdHMgZnJv
bSBEb21haW5zIHRvIEFURi4NCj4gPj4+ICsJVGhpcyBmZWF0dXJlIGFsbG93cyBkcml2ZXJzIGZy
b20gRG9tYWlucyB0byB3b3JrIHdpdGggU3lzdGVtDQo+ID4+PiArCUNvbnRyb2xsZXJzIChzdWNo
IGFzIHBvd2VyLHJlc2V0cyxjbG9jayBldGMuKS4gU0NQIGlzIHVzZWQgYXMgdHJhbnNwb3J0DQo+
ID4+PiArCWZvciBjb21tdW5pY2F0aW9uLg0KPiA+Pj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2Fy
bS9zY2kvc2NtaV9zbWMuYyBiL3hlbi9hcmNoL2FybS9zY2kvc2NtaV9zbWMuYw0KPiA+Pj4gbmV3
IGZpbGUgbW9kZSAxMDA2NDQNCj4gPj4+IGluZGV4IDAwMDAwMDAwMDAuLjEwMzUyOWRmYWINCj4g
Pj4+IC0tLSAvZGV2L251bGwNCj4gPj4+ICsrKyBiL3hlbi9hcmNoL2FybS9zY2kvc2NtaV9zbWMu
Yw0KPiA+Pj4gQEAgLTAsMCArMSw5NTkgQEANCj4gPj4+ICsvKg0KPiA+Pj4gKyAqIHhlbi9hcmNo
L2FybS9zY2kvc2NtaV9zbWMuYw0KPiA+Pj4gKyAqDQo+ID4+PiArICogU0NNSSBtZWRpYXRvciBk
cml2ZXIsIHVzaW5nIFNDUCBhcyB0cmFuc3BvcnQuDQo+ID4+PiArICoNCj4gPj4+ICsgKiBPbGVr
c2lpIE1vaXNpZWlldiA8b2xla3NpaV9tb2lzaWVpZXZAZXBhbS5jb20+DQo+ID4+PiArICogQ29w
eXJpZ2h0IChDKSAyMDIxLCBFUEFNIFN5c3RlbXMuDQo+ID4+PiArICoNCj4gPj4+ICsgKiBUaGlz
IHByb2dyYW0gaXMgZnJlZSBzb2Z0d2FyZTsgeW91IGNhbiByZWRpc3RyaWJ1dGUgaXQgYW5kL29y
IG1vZGlmeQ0KPiA+Pj4gKyAqIGl0IHVuZGVyIHRoZSB0ZXJtcyBvZiB0aGUgR05VIEdlbmVyYWwg
UHVibGljIExpY2Vuc2UgYXMgcHVibGlzaGVkIGJ5DQo+ID4+PiArICogdGhlIEZyZWUgU29mdHdh
cmUgRm91bmRhdGlvbjsgZWl0aGVyIHZlcnNpb24gMiBvZiB0aGUgTGljZW5zZSwgb3INCj4gPj4+
ICsgKiAoYXQgeW91ciBvcHRpb24pIGFueSBsYXRlciB2ZXJzaW9uLg0KPiA+Pj4gKyAqDQo+ID4+
PiArICogVGhpcyBwcm9ncmFtIGlzIGRpc3RyaWJ1dGVkIGluIHRoZSBob3BlIHRoYXQgaXQgd2ls
bCBiZSB1c2VmdWwsDQo+ID4+PiArICogYnV0IFdJVEhPVVQgQU5ZIFdBUlJBTlRZOyB3aXRob3V0
IGV2ZW4gdGhlIGltcGxpZWQgd2FycmFudHkgb2YNCj4gPj4+ICsgKiBNRVJDSEFOVEFCSUxJVFkg
b3IgRklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSIFBVUlBPU0UuICBTZWUgdGhlDQo+ID4+PiArICog
R05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2UgZm9yIG1vcmUgZGV0YWlscy4NCj4gPj4+ICsgKi8N
Cj4gPj4+ICsNCj4gPj4+ICsjaW5jbHVkZSA8YXNtL3NjaS9zY2kuaD4NCj4gPj4+ICsjaW5jbHVk
ZSA8YXNtL3NtY2NjLmg+DQo+ID4+PiArI2luY2x1ZGUgPGFzbS9pby5oPg0KPiA+Pj4gKyNpbmNs
dWRlIDx4ZW4vYml0b3BzLmg+DQo+ID4+PiArI2luY2x1ZGUgPHhlbi9jb25maWcuaD4NCj4gPj4+
ICsjaW5jbHVkZSA8eGVuL3NjaGVkLmg+DQo+ID4+PiArI2luY2x1ZGUgPHhlbi9kZXZpY2VfdHJl
ZS5oPg0KPiA+Pj4gKyNpbmNsdWRlIDx4ZW4vaW9jYXAuaD4NCj4gPj4+ICsjaW5jbHVkZSA8eGVu
L2luaXQuaD4NCj4gPj4+ICsjaW5jbHVkZSA8eGVuL2Vyci5oPg0KPiA+Pj4gKyNpbmNsdWRlIDx4
ZW4vbGliLmg+DQo+ID4+PiArI2luY2x1ZGUgPHhlbi9saXN0Lmg+DQo+ID4+PiArI2luY2x1ZGUg
PHhlbi9tbS5oPg0KPiA+Pj4gKyNpbmNsdWRlIDx4ZW4vc3RyaW5nLmg+DQo+ID4+PiArI2luY2x1
ZGUgPHhlbi90aW1lLmg+DQo+ID4+PiArI2luY2x1ZGUgPHhlbi92bWFwLmg+DQo+ID4+PiArDQo+
ID4+PiArI2RlZmluZSBTQ01JX0JBU0VfUFJPVE9DT0wgICAgICAgICAgICAgICAgICAweDEwDQo+
ID4+PiArI2RlZmluZSBTQ01JX0JBU0VfUFJPVE9DT0xfQVRUSUJVVEVTICAgICAgICAweDENCj4g
Pj4+ICsjZGVmaW5lIFNDTUlfQkFTRV9TRVRfREVWSUNFX1BFUk1JU1NJT05TICAgIDB4OQ0KPiA+
Pj4gKyNkZWZpbmUgU0NNSV9CQVNFX1JFU0VUX0FHRU5UX0NPTkZJR1VSQVRJT04gMHhCDQo+ID4+
PiArI2RlZmluZSBTQ01JX0JBU0VfRElTQ09WRVJfQUdFTlQgICAgICAgICAgICAweDcNCj4gPj4+
ICsNCj4gPj4+ICsvKiBTQ01JIHJldHVybiBjb2Rlcy4gU2VlIHNlY3Rpb24gNC4xLjQgb2YgU0NN
SSBzcGVjIChERU4wMDU2QykgKi8NCj4gPj4+ICsjZGVmaW5lIFNDTUlfU1VDQ0VTUyAgICAgICAg
ICAgICAgMA0KPiA+Pj4gKyNkZWZpbmUgU0NNSV9OT1RfU1VQUE9SVEVEICAgICAgKC0xKQ0KPiA+
Pj4gKyNkZWZpbmUgU0NNSV9JTlZBTElEX1BBUkFNRVRFUlMgKC0yKQ0KPiA+Pj4gKyNkZWZpbmUg
U0NNSV9ERU5JRUQgICAgICAgICAgICAgKC0zKQ0KPiA+Pj4gKyNkZWZpbmUgU0NNSV9OT1RfRk9V
TkQgICAgICAgICAgKC00KQ0KPiA+Pj4gKyNkZWZpbmUgU0NNSV9PVVRfT0ZfUkFOR0UgICAgICAg
KC01KQ0KPiA+Pj4gKyNkZWZpbmUgU0NNSV9CVVNZICAgICAgICAgICAgICAgKC02KQ0KPiA+Pj4g
KyNkZWZpbmUgU0NNSV9DT01NU19FUlJPUiAgICAgICAgKC03KQ0KPiA+Pj4gKyNkZWZpbmUgU0NN
SV9HRU5FUklDX0VSUk9SICAgICAgKC04KQ0KPiA+Pj4gKyNkZWZpbmUgU0NNSV9IQVJEV0FSRV9F
UlJPUiAgICAgKC05KQ0KPiA+Pj4gKyNkZWZpbmUgU0NNSV9QUk9UT0NPTF9FUlJPUiAgICAgKC0x
MCkNCj4gPj4+ICsNCj4gPj4+ICsjZGVmaW5lIERUX01BVENIX1NDTUlfU01DIERUX01BVENIX0NP
TVBBVElCTEUoImFybSxzY21pLXNtYyIpDQo+ID4+PiArDQo+ID4+PiArI2RlZmluZSBTQ01JX1NN
Q19JRCAgICAgICAgICAgICAgICAgICAgICAgICJhcm0sc21jLWlkIg0KPiA+Pj4gKyNkZWZpbmUg
U0NNSV9TSEFSRURfTUVNT1JZICAgICAgICAgICAgICAgICAiYXJtLHNjbWktc2htZW0iDQo+ID4+
PiArI2RlZmluZSBTQ01JX1NITUVNICAgICAgICAgICAgICAgICAgICAgICAgICJzaG1lbSINCj4g
Pj4+ICsjZGVmaW5lIFNDTUlfU0hNRU1fTUFQUEVEX1NJWkUgICAgICAgICAgICAgUEFHRV9TSVpF
DQo+ID4+PiArDQo+ID4+PiArI2RlZmluZSBIWVBfQ0hBTk5FTCAgICAgICAgICAgICAgICAgICAg
ICAgICAgMHgwDQo+ID4+PiArDQo+ID4+PiArI2RlZmluZSBIRFJfSUQgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgIEdFTk1BU0soNywwKQ0KPiA+Pj4gKyNkZWZpbmUgSERSX1RZUEUgICAgICAg
ICAgICAgICAgICAgICAgICAgICBHRU5NQVNLKDksIDgpDQo+ID4+PiArI2RlZmluZSBIRFJfUFJP
VE8gICAgICAgICAgICAgICAgICAgICAgICAgIEdFTk1BU0soMTcsIDEwKQ0KPiA+Pj4gKw0KPiA+
Pj4gKy8qIFNDTUkgcHJvdG9jb2wsIHJlZmVyIHRvIHNlY3Rpb24gNC4yLjIuMiAoREVOMDA1NkMp
ICovDQo+ID4+PiArI2RlZmluZSBNU0dfTl9BR0VOVFNfTUFTSyAgICAgICAgICAgICAgICAgIEdF
Tk1BU0soMTUsIDgpDQo+ID4+PiArDQo+ID4+PiArI2RlZmluZSBGSUVMRF9HRVQoX21hc2ssIF9y
ZWcpXA0KPiA+Pj4gKyAgICAoKHR5cGVvZihfbWFzaykpKCgoX3JlZykgJiAoX21hc2spKSA+PiAo
ZmZzNjQoX21hc2spIC0gMSkpKQ0KPiA+Pj4gKyNkZWZpbmUgRklFTERfUFJFUChfbWFzaywgX3Zh
bClcDQo+ID4+PiArICAgICgoKHR5cGVvZihfbWFzaykpKF92YWwpIDw8IChmZnM2NChfbWFzaykg
LSAxKSkgJiAoX21hc2spKQ0KPiA+Pj4gKw0KPiA+Pj4gK3R5cGVkZWYgc3RydWN0IHNjbWlfbXNn
X2hlYWRlciB7DQo+ID4+PiArICAgIHVpbnQ4X3QgaWQ7DQo+ID4+PiArICAgIHVpbnQ4X3QgdHlw
ZTsNCj4gPj4+ICsgICAgdWludDhfdCBwcm90b2NvbDsNCj4gPj4+ICt9IHNjbWlfbXNnX2hlYWRl
cl90Ow0KPiA+Pj4gKw0KPiA+Pj4gKyNkZWZpbmUgU0NNSV9TSE1FTV9DSEFOX1NUQVRfQ0hBTk5F
TF9GUkVFICAgQklUKDAsIFVMKQ0KPiA+Pj4gKyNkZWZpbmUgU0NNSV9TSE1FTV9DSEFOX1NUQVRf
Q0hBTk5FTF9FUlJPUiAgQklUKDEsIFVMKQ0KPiA+Pj4gKw0KPiA+Pj4gKyNkZWZpbmUgU0NNSV9B
TExPV19BQ0NFU1MgICAgICAgICAgICAgICAgICAgQklUKDAsIFVMKQ0KPiA+Pj4gKw0KPiA+Pj4g
K3N0cnVjdCBzY21pX3NoYXJlZF9tZW0gew0KPiA+Pj4gKyAgICB1aW50MzJfdCByZXNlcnZlZDsN
Cj4gPj4+ICsgICAgdWludDMyX3QgY2hhbm5lbF9zdGF0dXM7DQo+ID4+PiArICAgIHVpbnQzMl90
IHJlc2VydmVkMVsyXTsNCj4gPj4+ICsgICAgdWludDMyX3QgZmxhZ3M7DQo+ID4+PiArICAgIHVp
bnQzMl90IGxlbmd0aDsNCj4gPj4+ICsgICAgdWludDMyX3QgbXNnX2hlYWRlcjsNCj4gPj4+ICsg
ICAgdWludDhfdCBtc2dfcGF5bG9hZFtdOw0KPiA+Pj4gK307DQo+ID4+PiArDQo+ID4+PiArc3Ry
dWN0IGR0X2NoYW5uZWxfYWRkciB7DQo+ID4+PiArICAgIHU2NCBhZGRyOw0KPiA+Pj4gKyAgICB1
NjQgc2l6ZTsNCj4gPj4+ICsgICAgc3RydWN0IGxpc3RfaGVhZCBsaXN0Ow0KPiA+Pj4gK307DQo+
ID4+PiArDQo+ID4+PiArc3RydWN0IHNjbWlfY2hhbm5lbCB7DQo+ID4+PiArICAgIGludCBjaGFu
X2lkOw0KPiA+Pj4gKyAgICBpbnQgYWdlbnRfaWQ7DQo+ID4+PiArICAgIHVpbnQzMl90IGZ1bmNf
aWQ7DQo+ID4+PiArICAgIGRvbWlkX3QgZG9tYWluX2lkOw0KPiA+Pj4gKyAgICB1aW50NjRfdCBw
YWRkcjsNCj4gPj4+ICsgICAgdWludDY0X3QgbGVuOw0KPiA+Pj4gKyAgICBzdHJ1Y3Qgc2NtaV9z
aGFyZWRfbWVtICpzaG1lbTsNCj4gPj4+ICsgICAgc3BpbmxvY2tfdCBsb2NrOw0KPiA+Pj4gKyAg
ICBzdHJ1Y3QgbGlzdF9oZWFkIGxpc3Q7DQo+ID4+PiArfTsNCj4gPj4+ICsNCj4gPj4+ICtzdHJ1
Y3Qgc2NtaV9kYXRhIHsNCj4gPj4+ICsgICAgc3RydWN0IGxpc3RfaGVhZCBjaGFubmVsX2xpc3Q7
DQo+ID4+PiArICAgIHNwaW5sb2NrX3QgY2hhbm5lbF9saXN0X2xvY2s7DQo+ID4+PiArICAgIGJv
b2wgaW5pdGlhbGl6ZWQ7DQo+ID4+PiArfTsNCj4gPj4+ICsNCj4gPj4+ICtzdGF0aWMgc3RydWN0
IHNjbWlfZGF0YSBzY21pX2RhdGE7DQo+ID4+PiArDQo+ID4+PiArDQo+ID4+PiArLyoNCj4gPj4+
ICsgKiBwYWNrX3NjbWlfaGVhZGVyKCkgLSBwYWNrcyBhbmQgcmV0dXJucyAzMi1iaXQgaGVhZGVy
DQo+ID4+PiArICoNCj4gPj4+ICsgKiBAaGRyOiBwb2ludGVyIHRvIGhlYWRlciBjb250YWluaW5n
IGFsbCB0aGUgaW5mb3JtYXRpb24gb24gbWVzc2FnZSBpZCwNCj4gPj4+ICsgKiAgICBwcm90b2Nv
bCBpZCBhbmQgdHlwZSBpZC4NCj4gPj4+ICsgKg0KPiA+Pj4gKyAqIFJldHVybjogMzItYml0IHBh
Y2tlZCBtZXNzYWdlIGhlYWRlciB0byBiZSBzZW50IHRvIHRoZSBwbGF0Zm9ybS4NCj4gPj4+ICsg
Ki8NCj4gPj4+ICtzdGF0aWMgaW5saW5lIHVpbnQzMl90IHBhY2tfc2NtaV9oZWFkZXIoc2NtaV9t
c2dfaGVhZGVyX3QgKmhkcikNCj4gPj4+ICt7DQo+ID4+PiArICAgIHJldHVybiBGSUVMRF9QUkVQ
KEhEUl9JRCwgaGRyLT5pZCkgfA0KPiA+Pj4gKyAgICAgICAgRklFTERfUFJFUChIRFJfVFlQRSwg
aGRyLT50eXBlKSB8DQo+ID4+PiArICAgICAgICBGSUVMRF9QUkVQKEhEUl9QUk9UTywgaGRyLT5w
cm90b2NvbCk7DQo+ID4+PiArfQ0KPiA+Pj4gKw0KPiA+Pj4gKy8qDQo+ID4+PiArICogdW5wYWNr
X3NjbWlfaGVhZGVyKCkgLSB1bnBhY2tzIGFuZCByZWNvcmRzIG1lc3NhZ2UgYW5kIHByb3RvY29s
IGlkDQo+ID4+PiArICoNCj4gPj4+ICsgKiBAbXNnX2hkcjogMzItYml0IHBhY2tlZCBtZXNzYWdl
IGhlYWRlciBzZW50IGZyb20gdGhlIHBsYXRmb3JtDQo+ID4+PiArICogQGhkcjogcG9pbnRlciB0
byBoZWFkZXIgdG8gZmV0Y2ggbWVzc2FnZSBhbmQgcHJvdG9jb2wgaWQuDQo+ID4+PiArICovDQo+
ID4+PiArc3RhdGljIGlubGluZSB2b2lkIHVucGFja19zY21pX2hlYWRlcih1aW50MzJfdCBtc2df
aGRyLCBzY21pX21zZ19oZWFkZXJfdCAqaGRyKQ0KPiA+Pj4gK3sNCj4gPj4+ICsgICAgaGRyLT5p
ZCA9IEZJRUxEX0dFVChIRFJfSUQsIG1zZ19oZHIpOw0KPiA+Pj4gKyAgICBoZHItPnR5cGUgPSBG
SUVMRF9HRVQoSERSX1RZUEUsIG1zZ19oZHIpOw0KPiA+Pj4gKyAgICBoZHItPnByb3RvY29sID0g
RklFTERfR0VUKEhEUl9QUk9UTywgbXNnX2hkcik7DQo+ID4+PiArfQ0KPiA+Pj4gKw0KPiA+Pj4g
K3N0YXRpYyBpbmxpbmUgaW50IGNoYW5uZWxfaXNfZnJlZShzdHJ1Y3Qgc2NtaV9jaGFubmVsICpj
aGFuX2luZm8pDQo+ID4+PiArew0KPiA+Pj4gKyAgICByZXR1cm4gKCBjaGFuX2luZm8tPnNobWVt
LT5jaGFubmVsX3N0YXR1cw0KPiA+Pj4gKyAgICAgICAgICAgICYgU0NNSV9TSE1FTV9DSEFOX1NU
QVRfQ0hBTk5FTF9GUkVFICkgPyAwIDogLUVCVVNZOw0KPiA+Pj4gK30NCj4gPj4+ICsNCj4gPj4+
ICsvKg0KPiA+Pj4gKyAqIENvcHkgZGF0YSBmcm9tIElPIG1lbW9yeSBzcGFjZSB0byAicmVhbCIg
bWVtb3J5IHNwYWNlLg0KPiA+Pj4gKyAqLw0KPiA+Pj4gK3ZvaWQgX19tZW1jcHlfZnJvbWlvKHZv
aWQgKnRvLCBjb25zdCB2b2xhdGlsZSB2b2lkIF9faW9tZW0gKmZyb20sIHNpemVfdCBjb3VudCkN
Cj4gPj4+ICt7DQo+ID4+PiArICAgIHdoaWxlIChjb3VudCAmJiAhSVNfQUxJR05FRCgodW5zaWdu
ZWQgbG9uZylmcm9tLCA0KSkgew0KPiA+Pj4gKyAgICAgICAgKih1OCAqKXRvID0gX19yYXdfcmVh
ZGIoZnJvbSk7DQo+ID4+PiArICAgICAgICBmcm9tKys7DQo+ID4+PiArICAgICAgICB0bysrOw0K
PiA+Pj4gKyAgICAgICAgY291bnQtLTsNCj4gPj4+ICsgICAgfQ0KPiA+Pj4gKw0KPiA+Pj4gKyAg
ICB3aGlsZSAoY291bnQgPj0gNCkgew0KPiA+Pj4gKyAgICAgICAgKih1MzIgKil0byA9IF9fcmF3
X3JlYWRsKGZyb20pOw0KPiA+Pj4gKyAgICAgICAgZnJvbSArPSA0Ow0KPiA+Pj4gKyAgICAgICAg
dG8gKz0gNDsNCj4gPj4+ICsgICAgICAgIGNvdW50IC09IDQ7DQo+ID4+PiArICAgIH0NCj4gPj4+
ICsNCj4gPj4+ICsgICAgd2hpbGUgKGNvdW50KSB7DQo+ID4+PiArICAgICAgICAqKHU4ICopdG8g
PSBfX3Jhd19yZWFkYihmcm9tKTsNCj4gPj4+ICsgICAgICAgIGZyb20rKzsNCj4gPj4+ICsgICAg
ICAgIHRvKys7DQo+ID4+PiArICAgICAgICBjb3VudC0tOw0KPiA+Pj4gKyAgICB9DQo+ID4+PiAr
fQ0KPiA+Pj4gKw0KPiA+Pj4gKy8qDQo+ID4+PiArICogQ29weSBkYXRhIGZyb20gInJlYWwiIG1l
bW9yeSBzcGFjZSB0byBJTyBtZW1vcnkgc3BhY2UuDQo+ID4+PiArICovDQo+ID4+PiArdm9pZCBf
X21lbWNweV90b2lvKHZvbGF0aWxlIHZvaWQgX19pb21lbSAqdG8sIGNvbnN0IHZvaWQgKmZyb20s
IHNpemVfdCBjb3VudCkNCj4gPj4+ICt7DQo+ID4+PiArICAgIHdoaWxlIChjb3VudCAmJiAhSVNf
QUxJR05FRCgodW5zaWduZWQgbG9uZyl0bywgNCkpIHsNCj4gPj4+ICsgICAgICAgIF9fcmF3X3dy
aXRlYigqKHU4ICopZnJvbSwgdG8pOw0KPiA+Pj4gKyAgICAgICAgZnJvbSsrOw0KPiA+Pj4gKyAg
ICAgICAgdG8rKzsNCj4gPj4+ICsgICAgICAgIGNvdW50LS07DQo+ID4+PiArICAgIH0NCj4gPj4+
ICsNCj4gPj4+ICsgICAgd2hpbGUgKGNvdW50ID49IDQpIHsNCj4gPj4+ICsgICAgICAgIF9fcmF3
X3dyaXRlbCgqKHUzMiAqKWZyb20sIHRvKTsNCj4gPj4+ICsgICAgICAgIGZyb20gKz0gNDsNCj4g
Pj4+ICsgICAgICAgIHRvICs9IDQ7DQo+ID4+PiArICAgICAgICBjb3VudCAtPSA0Ow0KPiA+Pj4g
KyAgICB9DQo+ID4+PiArDQo+ID4+PiArICAgIHdoaWxlIChjb3VudCkgew0KPiA+Pj4gKyAgICAg
ICAgX19yYXdfd3JpdGViKCoodTggKilmcm9tLCB0byk7DQo+ID4+PiArICAgICAgICBmcm9tKys7
DQo+ID4+PiArICAgICAgICB0bysrOw0KPiA+Pj4gKyAgICAgICAgY291bnQtLTsNCj4gPj4+ICsg
ICAgfQ0KPiA+Pj4gK30NCj4gPj4+ICsNCj4gPj4+ICtzdGF0aWMgaW50IHNlbmRfc21jX21lc3Nh
Z2Uoc3RydWN0IHNjbWlfY2hhbm5lbCAqY2hhbl9pbmZvLA0KPiA+Pj4gKyAgICAgICAgICAgICAg
ICAgICAgICAgICAgICBzY21pX21zZ19oZWFkZXJfdCAqaGRyLCB2b2lkICpkYXRhLCBpbnQgbGVu
KQ0KPiA+Pj4gK3sNCj4gPj4+ICsgICAgc3RydWN0IGFybV9zbWNjY19yZXMgcmVzcDsNCj4gPj4+
ICsgICAgaW50IHJldDsNCj4gPj4+ICsNCj4gPj4+ICsgICAgaWYgKCAobGVuICsgc2l6ZW9mKGNo
YW5faW5mby0+c2htZW0tPm1zZ19oZWFkZXIpKSA+DQo+ID4+PiArICAgICAgICAgICAgICAgICAg
ICAgICAgIFNDTUlfU0hNRU1fTUFQUEVEX1NJWkUgKQ0KPiA+Pj4gKyAgICB7DQo+ID4+PiArICAg
ICAgICBwcmludGsoWEVOTE9HX0VSUg0KPiA+Pj4gKyAgICAgICAgICAgICAgICJzY21pOiBXcm9u
ZyBzaXplIG9mIHNtYyBtZXNzYWdlLiBEYXRhIGlzIGludmFsaWRcbiIpOw0KPiA+Pj4gKyAgICAg
ICAgcmV0dXJuIC1FSU5WQUw7DQo+ID4+PiArICAgIH0NCj4gPj4+ICsNCj4gPj4+ICsgICAgcHJp
bnRrKFhFTkxPR19ERUJVRyAic2NtaTogc3RhdHVzID0lZCBsZW49JWRcbiIsDQo+ID4+PiArICAg
ICAgICAgICBjaGFuX2luZm8tPnNobWVtLT5jaGFubmVsX3N0YXR1cywgbGVuKTsNCj4gPj4+ICsg
ICAgcHJpbnRrKFhFTkxPR19ERUJVRyAic2NtaTogaGVhZGVyIGlkID0gJWQgdHlwZSA9ICVkLCBw
cm90byA9ICVkXG4iLA0KPiA+Pj4gKyAgICAgICAgICAgaGRyLT5pZCwgaGRyLT50eXBlLCBoZHIt
PnByb3RvY29sKTsNCj4gPj4+ICsNCj4gPj4+ICsgICAgcmV0ID0gY2hhbm5lbF9pc19mcmVlKGNo
YW5faW5mbyk7DQo+ID4+PiArICAgIGlmICggSVNfRVJSX1ZBTFVFKHJldCkgKQ0KPiA+Pj4gKyAg
ICAgICAgcmV0dXJuIHJldDsNCj4gPj4+ICsNCj4gPj4+ICsgICAgY2hhbl9pbmZvLT5zaG1lbS0+
Y2hhbm5lbF9zdGF0dXMgPSAweDA7DQo+ID4+PiArICAgIC8qIFdyaXRpbmcgMHgwIHJpZ2h0IG5v
dywgYnV0IFNDTUlfU0hNRU1fRkxBR19JTlRSX0VOQUJMRUQgY2FuIGJlIHNldCAqLw0KPiA+Pj4g
KyAgICBjaGFuX2luZm8tPnNobWVtLT5mbGFncyA9IDB4MDsNCj4gPj4+ICsgICAgY2hhbl9pbmZv
LT5zaG1lbS0+bGVuZ3RoID0gc2l6ZW9mKGNoYW5faW5mby0+c2htZW0tPm1zZ19oZWFkZXIpICsg
bGVuOw0KPiA+Pj4gKyAgICBjaGFuX2luZm8tPnNobWVtLT5tc2dfaGVhZGVyID0gcGFja19zY21p
X2hlYWRlcihoZHIpOw0KPiA+Pj4gKw0KPiA+Pj4gKyAgICBwcmludGsoWEVOTE9HX0RFQlVHICJz
Y21pOiBXcml0aW5nIHRvIHNobWVtIGFkZHJlc3MgJXBcbiIsDQo+ID4+PiArICAgICAgICAgICBj
aGFuX2luZm8tPnNobWVtKTsNCj4gPj4+ICsgICAgaWYgKCBsZW4gPiAwICYmIGRhdGEgKQ0KPiA+
Pj4gKyAgICAgICAgX19tZW1jcHlfdG9pbygodm9pZCAqKShjaGFuX2luZm8tPnNobWVtLT5tc2df
cGF5bG9hZCksIGRhdGEsIGxlbik7DQo+ID4+PiArDQo+ID4+PiArICAgIGFybV9zbWNjY19zbWMo
Y2hhbl9pbmZvLT5mdW5jX2lkLCAwLCAwLCAwLCAwLCAwLCAwLCBjaGFuX2luZm8tPmNoYW5faWQs
DQo+ID4+PiArICAgICAgICAgICAgICAgICAgJnJlc3ApOw0KPiA+Pj4gKw0KPiA+Pj4gKyAgICBw
cmludGsoWEVOTE9HX0RFQlVHICJzY21pOiBzY21jY2Nfc21jIHJlc3BvbnNlICVkXG4iLCAoaW50
KShyZXNwLmEwKSk7DQo+ID4+PiArDQo+ID4+PiArICAgIGlmICggcmVzcC5hMCApDQo+ID4+PiAr
ICAgICAgICByZXR1cm4gLUVPUE5PVFNVUFA7DQo+ID4+PiArDQo+ID4+PiArICAgIHJldHVybiAw
Ow0KPiA+Pj4gK30NCj4gPj4+ICsNCj4gPj4+ICtzdGF0aWMgaW50IGNoZWNrX3NjbWlfc3RhdHVz
KGludCBzY21pX3N0YXR1cykNCj4gPj4+ICt7DQo+ID4+PiArICAgIGlmICggc2NtaV9zdGF0dXMg
PT0gU0NNSV9TVUNDRVNTICkNCj4gPj4+ICsgICAgICAgIHJldHVybiAwOw0KPiA+Pj4gKw0KPiA+
Pj4gKyAgICBwcmludGsoWEVOTE9HX0RFQlVHICJzY21pOiBFcnJvciByZWNlaXZlZDogJWRcbiIs
IHNjbWlfc3RhdHVzKTsNCj4gPj4+ICsNCj4gPj4+ICsgICAgc3dpdGNoICggc2NtaV9zdGF0dXMg
KQ0KPiA+Pj4gKyAgICB7DQo+ID4+PiArICAgIGNhc2UgU0NNSV9OT1RfU1VQUE9SVEVEOg0KPiA+
Pj4gKyAgICAgICAgcmV0dXJuIC1FT1BOT1RTVVBQOw0KPiA+Pj4gKyAgICBjYXNlIFNDTUlfSU5W
QUxJRF9QQVJBTUVURVJTOg0KPiA+Pj4gKyAgICAgICAgcmV0dXJuIC1FSU5WQUw7DQo+ID4+PiAr
ICAgIGNhc2UgU0NNSV9ERU5JRUQ6DQo+ID4+PiArICAgICAgICByZXR1cm4gLUVBQ0NFUzsNCj4g
Pj4+ICsgICAgY2FzZSBTQ01JX05PVF9GT1VORDoNCj4gPj4+ICsgICAgICAgIHJldHVybiAtRU5P
RU5UOw0KPiA+Pj4gKyAgICBjYXNlIFNDTUlfT1VUX09GX1JBTkdFOg0KPiA+Pj4gKyAgICAgICAg
cmV0dXJuIC1FUkFOR0U7DQo+ID4+PiArICAgIGNhc2UgU0NNSV9CVVNZOg0KPiA+Pj4gKyAgICAg
ICAgcmV0dXJuIC1FQlVTWTsNCj4gPj4+ICsgICAgY2FzZSBTQ01JX0NPTU1TX0VSUk9SOg0KPiA+
Pj4gKyAgICAgICAgcmV0dXJuIC1FTk9UQ09OTjsNCj4gPj4+ICsgICAgY2FzZSBTQ01JX0dFTkVS
SUNfRVJST1I6DQo+ID4+PiArICAgICAgICByZXR1cm4gLUVJTzsNCj4gPj4+ICsgICAgY2FzZSBT
Q01JX0hBUkRXQVJFX0VSUk9SOg0KPiA+Pj4gKyAgICAgICAgcmV0dXJuIC1FTlhJTzsNCj4gPj4+
ICsgICAgY2FzZSBTQ01JX1BST1RPQ09MX0VSUk9SOg0KPiA+Pj4gKyAgICAgICAgcmV0dXJuIC1F
QkFETVNHOw0KPiA+Pj4gKyAgICBkZWZhdWx0Og0KPiA+Pj4gKyAgICAgICAgcmV0dXJuIC1FSU5W
QUw7DQo+ID4+PiArICAgIH0NCj4gPj4+ICt9DQo+ID4+PiArDQo+ID4+PiArc3RhdGljIGludCBn
ZXRfc21jX3Jlc3BvbnNlKHN0cnVjdCBzY21pX2NoYW5uZWwgKmNoYW5faW5mbywNCj4gPj4+ICsg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgc2NtaV9tc2dfaGVhZGVyX3QgKmhkciwgdm9pZCAq
ZGF0YSwgaW50IGxlbikNCj4gPj4+ICt7DQo+ID4+PiArICAgIGludCByZWN2X2xlbjsNCj4gPj4+
ICsgICAgaW50IHJldDsNCj4gPj4+ICsNCj4gPj4+ICsgICAgcHJpbnRrKFhFTkxPR19ERUJVRyAi
c2NtaTogZ2V0IHNtYyByZXNwb25jZSBtc2dpZCAlZFxuIiwgaGRyLT5pZCk7DQo+ID4+PiArDQo+
ID4+PiArICAgIGlmICggbGVuID49IFNDTUlfU0hNRU1fTUFQUEVEX1NJWkUgLSBzaXplb2YoY2hh
bl9pbmZvLT5zaG1lbSkgKQ0KPiA+Pj4gKyAgICB7DQo+ID4+PiArICAgICAgICBwcmludGsoWEVO
TE9HX0VSUg0KPiA+Pj4gKyAgICAgICAgICAgICAgICJzY21pOiBXcm9uZyBzaXplIG9mIGlucHV0
IHNtYyBtZXNzYWdlLiBEYXRhIG1heSBiZSBpbnZhbGlkXG4iKTsNCj4gPj4+ICsgICAgICAgIHJl
dHVybiAtRUlOVkFMOw0KPiA+Pj4gKyAgICB9DQo+ID4+PiArDQo+ID4+PiArICAgIHJldCA9IGNo
YW5uZWxfaXNfZnJlZShjaGFuX2luZm8pOw0KPiA+Pj4gKyAgICBpZiAoIElTX0VSUl9WQUxVRShy
ZXQpICkNCj4gPj4+ICsgICAgICAgIHJldHVybiByZXQ7DQo+ID4+PiArDQo+ID4+PiArICAgIHJl
Y3ZfbGVuID0gY2hhbl9pbmZvLT5zaG1lbS0+bGVuZ3RoIC0gc2l6ZW9mKGNoYW5faW5mby0+c2ht
ZW0tPm1zZ19oZWFkZXIpOw0KPiA+Pj4gKw0KPiA+Pj4gKyAgICBpZiAoIHJlY3ZfbGVuIDwgMCAp
DQo+ID4+PiArICAgIHsNCj4gPj4+ICsgICAgICAgIHByaW50ayhYRU5MT0dfRVJSDQo+ID4+PiAr
ICAgICAgICAgICAgICAgInNjbWk6IFdyb25nIHNpemUgb2Ygc21jIG1lc3NhZ2UuIERhdGEgbWF5
IGJlIGludmFsaWRcbiIpOw0KPiA+Pj4gKyAgICAgICAgcmV0dXJuIC1FSU5WQUw7DQo+ID4+PiAr
ICAgIH0NCj4gPj4+ICsNCj4gPj4+ICsgICAgaWYgKCByZWN2X2xlbiA+IGxlbiApDQo+ID4+PiAr
ICAgIHsNCj4gPj4+ICsgICAgICAgIHByaW50ayhYRU5MT0dfRVJSDQo+ID4+PiArICAgICAgICAg
ICAgICAgInNjbWk6IE5vdCBlbm91Z2ggYnVmZmVyIGZvciBtZXNzYWdlICVkLCBleHBlY3Rpbmcg
JWRcbiIsDQo+ID4+PiArICAgICAgICAgICAgICAgcmVjdl9sZW4sIGxlbik7DQo+ID4+PiArICAg
ICAgICByZXR1cm4gLUVJTlZBTDsNCj4gPj4+ICsgICAgfQ0KPiA+Pj4gKw0KPiA+Pj4gKyAgICB1
bnBhY2tfc2NtaV9oZWFkZXIoY2hhbl9pbmZvLT5zaG1lbS0+bXNnX2hlYWRlciwgaGRyKTsNCj4g
Pj4+ICsNCj4gPj4+ICsgICAgaWYgKCByZWN2X2xlbiA+IDAgKQ0KPiA+Pj4gKyAgICB7DQo+ID4+
PiArICAgICAgICBfX21lbWNweV9mcm9taW8oZGF0YSwgY2hhbl9pbmZvLT5zaG1lbS0+bXNnX3Bh
eWxvYWQsIHJlY3ZfbGVuKTsNCj4gPj4+ICsgICAgfQ0KPiA+Pj4gKw0KPiA+Pj4gKyAgICByZXR1
cm4gMDsNCj4gPj4+ICt9DQo+ID4+PiArDQo+ID4+PiArc3RhdGljIGludCBkb19zbWNfeGZlcihz
dHJ1Y3Qgc2NtaV9jaGFubmVsICpjaGFubmVsLCBzY21pX21zZ19oZWFkZXJfdCAqaGRyLCB2b2lk
ICp0eF9kYXRhLCBpbnQgdHhfc2l6ZSwNCj4gPj4+ICsgICAgICAgICAgICAgICAgICAgICAgIHZv
aWQgKnJ4X2RhdGEsIGludCByeF9zaXplKQ0KPiA+Pj4gK3sNCj4gPj4+ICsgICAgaW50IHJldCA9
IDA7DQo+ID4+PiArDQo+ID4+PiArICAgIEFTU0VSVCggY2hhbm5lbCAmJiBjaGFubmVsLT5zaG1l
bSk7DQo+ID4+PiArDQo+ID4+PiArICAgIGlmICggIWhkciApDQo+ID4+PiArICAgICAgICByZXR1
cm4gLUVJTlZBTDsNCj4gPj4+ICsNCj4gPj4+ICsgICAgc3Bpbl9sb2NrKCZjaGFubmVsLT5sb2Nr
KTsNCj4gPj4+ICsNCj4gPj4+ICsgICAgcmV0ID0gc2VuZF9zbWNfbWVzc2FnZShjaGFubmVsLCBo
ZHIsIHR4X2RhdGEsIHR4X3NpemUpOw0KPiA+Pj4gKyAgICBpZiAoIHJldCApDQo+ID4+PiArICAg
ICAgICBnb3RvIGNsZWFuOw0KPiA+Pj4gKw0KPiA+Pj4gKyAgICByZXQgPSBnZXRfc21jX3Jlc3Bv
bnNlKGNoYW5uZWwsIGhkciwgcnhfZGF0YSwgcnhfc2l6ZSk7DQo+ID4+PiArY2xlYW46DQo+ID4+
PiArICAgIHNwaW5fdW5sb2NrKCZjaGFubmVsLT5sb2NrKTsNCj4gPj4+ICsNCj4gPj4+ICsgICAg
cmV0dXJuIHJldDsNCj4gPj4+ICt9DQo+ID4+PiArDQo+ID4+PiArc3RhdGljIHN0cnVjdCBzY21p
X2NoYW5uZWwgKmdldF9jaGFubmVsX2J5X2lkKHVpbnQ4X3QgY2hhbl9pZCkNCj4gPj4+ICt7DQo+
ID4+PiArICAgIHN0cnVjdCBzY21pX2NoYW5uZWwgKmN1cnI7DQo+ID4+PiArICAgIGJvb2wgZm91
bmQgPSBmYWxzZTsNCj4gPj4+ICsNCj4gPj4+ICsgICAgc3Bpbl9sb2NrKCZzY21pX2RhdGEuY2hh
bm5lbF9saXN0X2xvY2spOw0KPiA+Pj4gKyAgICBsaXN0X2Zvcl9lYWNoX2VudHJ5KGN1cnIsICZz
Y21pX2RhdGEuY2hhbm5lbF9saXN0LCBsaXN0KQ0KPiA+Pj4gKyAgICB7DQo+ID4+PiArICAgICAg
ICBpZiAoIGN1cnItPmNoYW5faWQgPT0gY2hhbl9pZCApDQo+ID4+PiArICAgICAgICB7DQo+ID4+
PiArICAgICAgICAgICAgZm91bmQgPSB0cnVlOw0KPiA+Pj4gKyAgICAgICAgICAgIGJyZWFrOw0K
PiA+Pj4gKyAgICAgICAgfQ0KPiA+Pj4gKyAgICB9DQo+ID4+PiArDQo+ID4+PiArICAgIHNwaW5f
dW5sb2NrKCZzY21pX2RhdGEuY2hhbm5lbF9saXN0X2xvY2spOw0KPiA+Pj4gKyAgICBpZiAoIGZv
dW5kICkNCj4gPj4+ICsgICAgICAgIHJldHVybiBjdXJyOw0KPiA+Pj4gKw0KPiA+Pj4gKyAgICBy
ZXR1cm4gTlVMTDsNCj4gPj4+ICt9DQo+ID4+PiArDQo+ID4+PiArc3RhdGljIHN0cnVjdCBzY21p
X2NoYW5uZWwgKmFxdWlyZV9zY21pX2NoYW5uZWwoZG9taWRfdCBkb21haW5faWQpDQo+ID4+PiAr
ew0KPiA+Pj4gKyAgICBzdHJ1Y3Qgc2NtaV9jaGFubmVsICpjdXJyOw0KPiA+Pj4gKyAgICBib29s
IGZvdW5kID0gZmFsc2U7DQo+ID4+PiArDQo+ID4+PiArICAgIEFTU0VSVChkb21haW5faWQgIT0g
RE9NSURfSU5WQUxJRCAmJiBkb21haW5faWQgPj0gMCk7DQo+ID4+PiArDQo+ID4+PiArICAgIHNw
aW5fbG9jaygmc2NtaV9kYXRhLmNoYW5uZWxfbGlzdF9sb2NrKTsNCj4gPj4+ICsgICAgbGlzdF9m
b3JfZWFjaF9lbnRyeShjdXJyLCAmc2NtaV9kYXRhLmNoYW5uZWxfbGlzdCwgbGlzdCkNCj4gPj4+
ICsgICAgew0KPiA+Pj4gKyAgICAgICAgaWYgKCBjdXJyLT5kb21haW5faWQgPT0gRE9NSURfSU5W
QUxJRCApDQo+ID4+PiArICAgICAgICB7DQo+ID4+PiArICAgICAgICAgICAgY3Vyci0+ZG9tYWlu
X2lkID0gZG9tYWluX2lkOw0KPiA+Pj4gKyAgICAgICAgICAgIGZvdW5kID0gdHJ1ZTsNCj4gPj4+
ICsgICAgICAgICAgICBicmVhazsNCj4gPj4+ICsgICAgICAgIH0NCj4gPj4+ICsgICAgfQ0KPiA+
Pj4gKw0KPiA+Pj4gKyAgICBzcGluX3VubG9jaygmc2NtaV9kYXRhLmNoYW5uZWxfbGlzdF9sb2Nr
KTsNCj4gPj4+ICsgICAgaWYgKCBmb3VuZCApDQo+ID4+PiArICAgICAgICByZXR1cm4gY3VycjsN
Cj4gPj4+ICsNCj4gPj4+ICsgICAgcmV0dXJuIE5VTEw7DQo+ID4+PiArfQ0KPiA+Pj4gKw0KPiA+
Pj4gK3N0YXRpYyB2b2lkIHJlbGlucXVpc2hfc2NtaV9jaGFubmVsKHN0cnVjdCBzY21pX2NoYW5u
ZWwgKmNoYW5uZWwpDQo+ID4+PiArew0KPiA+Pj4gKyAgICBBU1NFUlQoY2hhbm5lbCAhPSBOVUxM
KTsNCj4gPj4+ICsNCj4gPj4+ICsgICAgc3Bpbl9sb2NrKCZzY21pX2RhdGEuY2hhbm5lbF9saXN0
X2xvY2spOw0KPiA+Pj4gKyAgICBjaGFubmVsLT5kb21haW5faWQgPSBET01JRF9JTlZBTElEOw0K
PiA+Pj4gKyAgICBzcGluX3VubG9jaygmc2NtaV9kYXRhLmNoYW5uZWxfbGlzdF9sb2NrKTsNCj4g
Pj4+ICt9DQo+ID4+PiArDQo+ID4+PiArc3RhdGljIGludCBtYXBfY2hhbm5lbF9tZW1vcnkoc3Ry
dWN0IHNjbWlfY2hhbm5lbCAqY2hhbm5lbCkNCj4gPj4+ICt7DQo+ID4+PiArICAgIEFTU0VSVCgg
Y2hhbm5lbCAmJiBjaGFubmVsLT5wYWRkciApOw0KPiA+Pj4gKyAgICBjaGFubmVsLT5zaG1lbSA9
IGlvcmVtYXBfY2FjaGUoY2hhbm5lbC0+cGFkZHIsIFNDTUlfU0hNRU1fTUFQUEVEX1NJWkUpOw0K
PiA+Pj4gKyAgICBpZiAoICFjaGFubmVsLT5zaG1lbSApDQo+ID4+PiArICAgICAgICByZXR1cm4g
LUVOT01FTTsNCj4gPj4+ICsNCj4gPj4+ICsgICAgY2hhbm5lbC0+c2htZW0tPmNoYW5uZWxfc3Rh
dHVzID0gU0NNSV9TSE1FTV9DSEFOX1NUQVRfQ0hBTk5FTF9GUkVFOw0KPiA+Pj4gKyAgICBwcmlu
dGsoWEVOTE9HX0RFQlVHICJzY21pOiBHb3Qgc2htZW0gYWZ0ZXIgdm1hcCAlcFxuIiwgY2hhbm5l
bC0+c2htZW0pOw0KPiA+Pj4gKyAgICByZXR1cm4gMDsNCj4gPj4+ICt9DQo+ID4+PiArDQo+ID4+
PiArc3RhdGljIHZvaWQgdW5tYXBfY2hhbm5lbF9tZW1vcnkoc3RydWN0IHNjbWlfY2hhbm5lbCAq
Y2hhbm5lbCkNCj4gPj4+ICt7DQo+ID4+PiArICAgIEFTU0VSVCggY2hhbm5lbCAmJiBjaGFubmVs
LT5zaG1lbSApOw0KPiA+Pj4gKyAgICBpb3VubWFwKGNoYW5uZWwtPnNobWVtKTsNCj4gPj4+ICsg
ICAgY2hhbm5lbC0+c2htZW0gPSBOVUxMOw0KPiA+Pj4gK30NCj4gPj4+ICsNCj4gPj4+ICtzdGF0
aWMgc3RydWN0IHNjbWlfY2hhbm5lbCAqc21jX2NyZWF0ZV9jaGFubmVsKHVpbnQ4X3QgY2hhbl9p
ZCwNCj4gPj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
IHVpbnQzMl90IGZ1bmNfaWQsIHVpbnQ2NF90IGFkZHIpDQo+ID4+PiArew0KPiA+Pj4gKyAgICBz
dHJ1Y3Qgc2NtaV9jaGFubmVsICpjaGFubmVsOw0KPiA+Pj4gKw0KPiA+Pj4gKyAgICBjaGFubmVs
ID0gZ2V0X2NoYW5uZWxfYnlfaWQoY2hhbl9pZCk7DQo+ID4+PiArICAgIGlmICggY2hhbm5lbCAp
DQo+ID4+PiArICAgICAgICByZXR1cm4gRVJSX1BUUihFRVhJU1QpOw0KPiA+Pj4gKw0KPiA+Pj4g
KyAgICBjaGFubmVsID0geG1hbGxvYyhzdHJ1Y3Qgc2NtaV9jaGFubmVsKTsNCj4gPj4+ICsgICAg
aWYgKCAhY2hhbm5lbCApDQo+ID4+PiArICAgICAgICByZXR1cm4gRVJSX1BUUihFTk9NRU0pOw0K
PiA+Pj4gKw0KPiA+Pj4gKyAgICBjaGFubmVsLT5jaGFuX2lkID0gY2hhbl9pZDsNCj4gPj4+ICsg
ICAgY2hhbm5lbC0+ZnVuY19pZCA9IGZ1bmNfaWQ7DQo+ID4+PiArICAgIGNoYW5uZWwtPmRvbWFp
bl9pZCA9IERPTUlEX0lOVkFMSUQ7DQo+ID4+PiArICAgIGNoYW5uZWwtPnNobWVtID0gTlVMTDsN
Cj4gPj4+ICsgICAgY2hhbm5lbC0+cGFkZHIgPSBhZGRyOw0KPiA+Pj4gKyAgICBzcGluX2xvY2tf
aW5pdCgmY2hhbm5lbC0+bG9jayk7DQo+ID4+PiArICAgIHNwaW5fbG9jaygmc2NtaV9kYXRhLmNo
YW5uZWxfbGlzdF9sb2NrKTsNCj4gPj4+ICsgICAgbGlzdF9hZGQoJmNoYW5uZWwtPmxpc3QsICZz
Y21pX2RhdGEuY2hhbm5lbF9saXN0KTsNCj4gPj4+ICsgICAgc3Bpbl91bmxvY2soJnNjbWlfZGF0
YS5jaGFubmVsX2xpc3RfbG9jayk7DQo+ID4+PiArICAgIHJldHVybiBjaGFubmVsOw0KPiA+Pj4g
K30NCj4gPj4+ICsNCj4gPj4+ICtzdGF0aWMgaW50IG1lbV9wZXJtaXRfYWNjZXNzKHN0cnVjdCBk
b21haW4gKmQsIHVpbnQ2NF90IGFkZHIsIHVpbnQ2NF90IGxlbikNCj4gPj4+ICt7DQo+ID4+PiAr
ICAgIHJldHVybiBpb21lbV9wZXJtaXRfYWNjZXNzKGQsIHBhZGRyX3RvX3BmbihhZGRyKSwNCj4g
Pj4+ICsgICAgICAgICAgICAgICAgcGFkZHJfdG9fcGZuKFBBR0VfQUxJR04oYWRkciArIGxlbiAt
MSkpKTsNCj4gPj4+ICt9DQo+ID4+PiArDQo+ID4+PiArc3RhdGljIGludCBtZW1fZGVueV9hY2Nl
c3Moc3RydWN0IGRvbWFpbiAqZCwgdWludDY0X3QgYWRkciwNCj4gPj4+ICsgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgdWludDY0X3QgbGVuKQ0KPiA+Pj4gK3sNCj4gPj4+ICsg
ICAgcmV0dXJuIGlvbWVtX2RlbnlfYWNjZXNzKGQsIHBhZGRyX3RvX3BmbihhZGRyKSwNCj4gPj4+
ICsgICAgICAgICAgICAgICAgcGFkZHJfdG9fcGZuKFBBR0VfQUxJR04oYWRkciArIGxlbiAtMSkp
KTsNCj4gPj4+ICt9DQo+ID4+PiArDQo+ID4+PiArc3RhdGljIGludCBkdF91cGRhdGVfZG9tYWlu
X3JhbmdlKHVpbnQ2NF90IGFkZHIsIHVpbnQ2NF90IHNpemUpDQo+ID4+PiArew0KPiA+Pj4gKyAg
ICBzdHJ1Y3QgZHRfZGV2aWNlX25vZGUgKnNobWVtX25vZGU7DQo+ID4+PiArICAgIF9fYmUzMiAq
aHdfcmVnOw0KPiA+Pj4gKyAgICBjb25zdCBzdHJ1Y3QgZHRfcHJvcGVydHkgKnBwOw0KPiA+Pj4g
KyAgICB1aW50MzJfdCBsZW47DQo+ID4+PiArDQo+ID4+PiArICAgIHNobWVtX25vZGUgPSBkdF9m
aW5kX2NvbXBhdGlibGVfbm9kZShOVUxMLCBOVUxMLCBTQ01JX1NIQVJFRF9NRU1PUlkpOw0KPiA+
Pj4gKyAgICBpZiAoICFzaG1lbV9ub2RlICkNCj4gPj4+ICsgICAgew0KPiA+Pj4gKyAgICAgICAg
cHJpbnRrKFhFTkxPR19FUlIgInNjbWk6IFVuYWJsZSB0byBmaW5kICVzIG5vZGUgaW4gRFRcbiIs
IFNDTUlfU0hNRU0pOw0KPiA+Pj4gKyAgICAgICAgcmV0dXJuIC1FSU5WQUw7DQo+ID4+PiArICAg
IH0NCj4gPj4+ICsNCj4gPj4+ICsgICAgcHAgPSBkdF9maW5kX3Byb3BlcnR5KHNobWVtX25vZGUs
ICJyZWciLCAmbGVuKTsNCj4gPj4+ICsgICAgaWYgKCAhcHAgKQ0KPiA+Pj4gKyAgICB7DQo+ID4+
PiArICAgICAgICBwcmludGsoWEVOTE9HX0VSUiAic2NtaTogVW5hYmxlIHRvIGZpbmQgcmVncyBl
bnRyeSBpbiBzaG1lbSBub2RlXG4iKTsNCj4gPj4+ICsgICAgICAgIHJldHVybiAtRU5PRU5UOw0K
PiA+Pj4gKyAgICB9DQo+ID4+PiArDQo+ID4+PiArICAgIGh3X3JlZyA9IHBwLT52YWx1ZTsNCj4g
Pj4+ICsgICAgZHRfc2V0X3JhbmdlKCZod19yZWcsIHNobWVtX25vZGUsIGFkZHIsIHNpemUpOw0K
PiA+Pj4gKw0KPiA+Pj4gKyAgICByZXR1cm4gMDsNCj4gPj4+ICt9DQo+ID4+PiArDQo+ID4+PiAr
c3RhdGljIHZvaWQgZnJlZV9jaGFubmVsX2xpc3Qodm9pZCkNCj4gPj4+ICt7DQo+ID4+PiArICAg
IHN0cnVjdCBzY21pX2NoYW5uZWwgKmN1cnIsICpfY3VycjsNCj4gPj4+ICsNCj4gPj4+ICsgICAg
c3Bpbl9sb2NrKCZzY21pX2RhdGEuY2hhbm5lbF9saXN0X2xvY2spOw0KPiA+Pj4gKyAgICBsaXN0
X2Zvcl9lYWNoX2VudHJ5X3NhZmUgKGN1cnIsIF9jdXJyLCAmc2NtaV9kYXRhLmNoYW5uZWxfbGlz
dCwgbGlzdCkNCj4gPj4+ICsgICAgew0KPiA+Pj4gKyAgICAgICAgbGlzdF9kZWwoJmN1cnItPmxp
c3QpOw0KPiA+Pj4gKyAgICAgICAgeGZyZWUoY3Vycik7DQo+ID4+PiArICAgIH0NCj4gPj4+ICsN
Cj4gPj4+ICsgICAgc3Bpbl91bmxvY2soJnNjbWlfZGF0YS5jaGFubmVsX2xpc3RfbG9jayk7DQo+
ID4+PiArfQ0KPiA+Pj4gKw0KPiA+Pj4gK3N0YXRpYyBzdHJ1Y3QgZHRfZGV2aWNlX25vZGUgKmdl
dF9kdF9ub2RlX2Zyb21fcHJvcGVydHkoDQo+ID4+PiArICAgICAgICAgICAgICAgIHN0cnVjdCBk
dF9kZXZpY2Vfbm9kZSAqbm9kZSwgY29uc3QgY2hhciAqIHBfbmFtZSkNCj4gPj4+ICt7DQo+ID4+
PiArICAgIGNvbnN0IF9fYmUzMiAqcHJvcDsNCj4gPj4+ICsNCj4gPj4+ICsgICAgQVNTRVJUKCBu
b2RlICk7DQo+ID4+PiArDQo+ID4+PiArICAgIHByb3AgPSBkdF9nZXRfcHJvcGVydHkobm9kZSwg
cF9uYW1lLCBOVUxMKTsNCj4gPj4+ICsgICAgaWYgKCAhcHJvcCApDQo+ID4+PiArICAgICAgICBy
ZXR1cm4gRVJSX1BUUigtRUlOVkFMKTsNCj4gPj4+ICsNCj4gPj4+ICsgICAgcmV0dXJuIGR0X2Zp
bmRfbm9kZV9ieV9waGFuZGxlKGJlMzJfdG9fY3B1cChwcm9wKSk7DQo+ID4+PiArfQ0KPiA+Pj4g
Kw0KPiA+Pj4gK3N0YXRpYyBpbnQgZ2V0X3NobWVtX3JlZ2lvbnMoc3RydWN0IGxpc3RfaGVhZCAq
aGVhZCwgdTY0IGh5cF9hZGRyKQ0KPiA+Pj4gK3sNCj4gPj4+ICsgICAgc3RydWN0IGR0X2Rldmlj
ZV9ub2RlICpub2RlOw0KPiA+Pj4gKyAgICBpbnQgcmV0Ow0KPiA+Pj4gKyAgICBzdHJ1Y3QgZHRf
Y2hhbm5lbF9hZGRyICpsY2hhbjsNCj4gPj4+ICsgICAgdTY0IGxhZGRyLCBsc2l6ZTsNCj4gPj4+
ICsNCj4gPj4+ICsgICAgbm9kZSA9IGR0X2ZpbmRfY29tcGF0aWJsZV9ub2RlKE5VTEwsIE5VTEws
IFNDTUlfU0hBUkVEX01FTU9SWSk7DQo+ID4+PiArICAgIGlmICggIW5vZGUgKQ0KPiA+Pj4gKyAg
ICAgICAgcmV0dXJuIC1FTk9FTlQ7DQo+ID4+PiArDQo+ID4+PiArICAgIHdoaWxlICggbm9kZSAp
DQo+ID4+PiArICAgIHsNCj4gPj4+ICsgICAgICAgIHJldCA9IGR0X2RldmljZV9nZXRfYWRkcmVz
cyhub2RlLCAwLCAmbGFkZHIsICZsc2l6ZSk7DQo+ID4+PiArICAgICAgICBpZiAoIHJldCApDQo+
ID4+PiArICAgICAgICAgICAgcmV0dXJuIHJldDsNCj4gPj4+ICsNCj4gPj4+ICsgICAgICAgIGlm
ICggbGFkZHIgIT0gaHlwX2FkZHIgKQ0KPiA+Pj4gKyAgICAgICAgew0KPiA+Pj4gKyAgICAgICAg
ICAgIGxjaGFuID0geG1hbGxvYyhzdHJ1Y3QgZHRfY2hhbm5lbF9hZGRyKTsNCj4gPj4+ICsgICAg
ICAgICAgICBpZiAoICFsY2hhbiApDQo+ID4+PiArICAgICAgICAgICAgICAgIHJldHVybiAtRU5P
TUVNOw0KPiA+Pj4gKyAgICAgICAgICAgIGxjaGFuLT5hZGRyID0gbGFkZHI7DQo+ID4+PiArICAg
ICAgICAgICAgbGNoYW4tPnNpemUgPSBsc2l6ZTsNCj4gPj4+ICsNCj4gPj4+ICsgICAgICAgICAg
ICBsaXN0X2FkZF90YWlsKCZsY2hhbi0+bGlzdCwgaGVhZCk7DQo+ID4+PiArICAgICAgICB9DQo+
ID4+PiArDQo+ID4+PiArICAgICAgICBub2RlID0gZHRfZmluZF9jb21wYXRpYmxlX25vZGUobm9k
ZSwgTlVMTCwgU0NNSV9TSEFSRURfTUVNT1JZKTsNCj4gPj4+ICsgICAgfQ0KPiA+Pj4gKw0KPiA+
Pj4gKyAgICByZXR1cm4gMDsNCj4gPj4+ICt9DQo+ID4+PiArDQo+ID4+PiArc3RhdGljIGludCBy
ZWFkX2h5cF9jaGFubmVsX2FkZHIoc3RydWN0IGR0X2RldmljZV9ub2RlICpzY21pX25vZGUsDQo+
ID4+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdTY0ICphZGRyLCB1NjQgKnNp
emUpDQo+ID4+PiArew0KPiA+Pj4gKyAgICBzdHJ1Y3QgZHRfZGV2aWNlX25vZGUgKnNobWVtX25v
ZGU7DQo+ID4+PiArICAgIHNobWVtX25vZGUgPSBnZXRfZHRfbm9kZV9mcm9tX3Byb3BlcnR5KHNj
bWlfbm9kZSwgInNobWVtIik7DQo+ID4+PiArICAgIGlmICggSVNfRVJSX09SX05VTEwoc2htZW1f
bm9kZSkgKQ0KPiA+Pj4gKyAgICB7DQo+ID4+PiArICAgICAgICBwcmludGsoWEVOTE9HX0VSUg0K
PiA+Pj4gKyAgICAgICAgICAgICAgICJzY21pOiBEZXZpY2UgdHJlZSBlcnJvciwgY2FuJ3QgcGFy
c2UgcmVzZXJ2ZWQgbWVtb3J5ICVsZFxuIiwNCj4gPj4+ICsgICAgICAgICAgICAgICBQVFJfRVJS
KHNobWVtX25vZGUpKTsNCj4gPj4+ICsgICAgICAgIHJldHVybiBQVFJfRVJSKHNobWVtX25vZGUp
Ow0KPiA+Pj4gKyAgICB9DQo+ID4+PiArDQo+ID4+PiArICAgIHJldHVybiBkdF9kZXZpY2VfZ2V0
X2FkZHJlc3Moc2htZW1fbm9kZSwgMCwgYWRkciwgc2l6ZSk7DQo+ID4+PiArfQ0KPiA+Pj4gKw0K
PiA+Pj4gK3N0YXRpYyB2b2lkIGZyZWVfc2htZW1fcmVnaW9ucyhzdHJ1Y3QgbGlzdF9oZWFkICph
ZGRyX2xpc3QpDQo+ID4+PiArew0KPiA+Pj4gKyAgICBzdHJ1Y3QgZHRfY2hhbm5lbF9hZGRyICpj
dXJyLCAqX2N1cnI7DQo+ID4+PiArDQo+ID4+PiArICAgIGxpc3RfZm9yX2VhY2hfZW50cnlfc2Fm
ZSAoY3VyciwgX2N1cnIsIGFkZHJfbGlzdCwgbGlzdCkNCj4gPj4+ICsgICAgew0KPiA+Pj4gKyAg
ICAgICAgbGlzdF9kZWwoJmN1cnItPmxpc3QpOw0KPiA+Pj4gKyAgICAgICAgeGZyZWUoY3Vycik7
DQo+ID4+PiArICAgIH0NCj4gPj4+ICt9DQo+ID4+PiArDQo+ID4+PiArc3RhdGljIF9faW5pdCBi
b29sIHNjbWlfcHJvYmUoc3RydWN0IGR0X2RldmljZV9ub2RlICpzY21pX25vZGUpDQo+ID4+PiAr
ew0KPiA+Pj4gKyAgICB1NjQgYWRkciwgc2l6ZTsNCj4gPj4+ICsgICAgaW50IHJldCwgaTsNCj4g
Pj4+ICsgICAgc3RydWN0IHNjbWlfY2hhbm5lbCAqY2hhbm5lbCwgKmFnZW50X2NoYW5uZWw7DQo+
ID4+PiArICAgIGludCBuX2FnZW50czsNCj4gPj4+ICsgICAgc2NtaV9tc2dfaGVhZGVyX3QgaGRy
Ow0KPiA+Pj4gKyAgICBzdHJ1Y3QgcnhfdCB7DQo+ID4+PiArICAgICAgICBpbnQzMl90IHN0YXR1
czsNCj4gPj4+ICsgICAgICAgIHVpbnQzMl90IGF0dHJpYnV0ZXM7DQo+ID4+PiArICAgIH0gcng7
DQo+ID4+PiArICAgIHN0cnVjdCBkdF9jaGFubmVsX2FkZHIgKmVudHJ5Ow0KPiA+Pj4gKyAgICBz
dHJ1Y3QgbGlzdF9oZWFkIGFkZHJfbGlzdDsNCj4gPj4+ICsNCj4gPj4+ICsgICAgdWludDMyX3Qg
ZnVuY19pZDsNCj4gPj4+ICsNCj4gPj4+ICsgICAgQVNTRVJUKHNjbWlfbm9kZSAhPSBOVUxMKTsN
Cj4gPj4+ICsNCj4gPj4+ICsgICAgSU5JVF9MSVNUX0hFQUQoJnNjbWlfZGF0YS5jaGFubmVsX2xp
c3QpOw0KPiA+Pj4gKyAgICBzcGluX2xvY2tfaW5pdCgmc2NtaV9kYXRhLmNoYW5uZWxfbGlzdF9s
b2NrKTsNCj4gPj4+ICsNCj4gPj4+ICsgICAgaWYgKCAhZHRfcHJvcGVydHlfcmVhZF91MzIoc2Nt
aV9ub2RlLCBTQ01JX1NNQ19JRCwgJmZ1bmNfaWQpICkNCj4gPj4+ICsgICAgew0KPiA+Pj4gKyAg
ICAgICAgcHJpbnRrKFhFTkxPR19FUlIgInNjbWk6IFVuYWJsZSB0byByZWFkIHNtYy1pZCBmcm9t
IERUXG4iKTsNCj4gPj4+ICsgICAgICAgIHJldHVybiBmYWxzZTsNCj4gPj4+ICsgICAgfQ0KPiA+
Pj4gKw0KPiA+Pj4gKyAgICByZXQgPSByZWFkX2h5cF9jaGFubmVsX2FkZHIoc2NtaV9ub2RlLCAm
YWRkciwgJnNpemUpOw0KPiA+Pj4gKyAgICBpZiAoIElTX0VSUl9WQUxVRShyZXQpICkNCj4gPj4+
ICsgICAgICAgIHJldHVybiBmYWxzZTsNCj4gPj4+ICsNCj4gPj4+ICsgICAgaWYgKCAhSVNfQUxJ
R05FRChzaXplLCBTQ01JX1NITUVNX01BUFBFRF9TSVpFKSApDQo+ID4+PiArICAgIHsNCj4gPj4+
ICsgICAgICAgIHByaW50ayhYRU5MT0dfRVJSICJzY21pOiBSZXNlcnZlZCBtZW1vcnkgaXMgbm90
IGFsaWduZWRcbiIpOw0KPiA+Pj4gKyAgICAgICAgcmV0dXJuIGZhbHNlOw0KPiA+Pj4gKyAgICB9
DQo+ID4+PiArDQo+ID4+PiArICAgIElOSVRfTElTVF9IRUFEKCZhZGRyX2xpc3QpOw0KPiA+Pj4g
Kw0KPiA+Pj4gKyAgICByZXQgPSBnZXRfc2htZW1fcmVnaW9ucygmYWRkcl9saXN0LCBhZGRyKTsN
Cj4gPj4+ICsgICAgaWYgKCBJU19FUlJfVkFMVUUocmV0KSApDQo+ID4+PiArICAgICAgICBnb3Rv
IG91dDsNCj4gPj4+ICsNCj4gPj4+ICsgICAgY2hhbm5lbCA9IHNtY19jcmVhdGVfY2hhbm5lbChI
WVBfQ0hBTk5FTCwgZnVuY19pZCwgYWRkcik7DQo+ID4+PiArICAgIGlmICggSVNfRVJSKGNoYW5u
ZWwpICkNCj4gPj4+ICsgICAgICAgIGdvdG8gb3V0Ow0KPiA+Pj4gKw0KPiA+Pj4gKyAgICByZXQg
PSBtYXBfY2hhbm5lbF9tZW1vcnkoY2hhbm5lbCk7DQo+ID4+PiArICAgIGlmICggcmV0ICkNCj4g
Pj4+ICsgICAgICAgIGdvdG8gb3V0Ow0KPiA+Pj4gKw0KPiA+Pj4gKyAgICBzcGluX2xvY2soJnNj
bWlfZGF0YS5jaGFubmVsX2xpc3RfbG9jayk7DQo+ID4+PiArICAgIGNoYW5uZWwtPmRvbWFpbl9p
ZCA9IERPTUlEX1hFTjsNCj4gPj4+ICsgICAgc3Bpbl91bmxvY2soJnNjbWlfZGF0YS5jaGFubmVs
X2xpc3RfbG9jayk7DQo+ID4+PiArDQo+ID4+PiArICAgIGhkci5pZCA9IFNDTUlfQkFTRV9QUk9U
T0NPTF9BVFRJQlVURVM7DQo+ID4+PiArICAgIGhkci50eXBlID0gMDsNCj4gPj4+ICsgICAgaGRy
LnByb3RvY29sID0gU0NNSV9CQVNFX1BST1RPQ09MOw0KPiA+Pj4gKw0KPiA+Pj4gKyAgICByZXQg
PSBkb19zbWNfeGZlcihjaGFubmVsLCAmaGRyLCBOVUxMLCAwLCAmcngsIHNpemVvZihyeCkpOw0K
PiA+Pj4gKyAgICBpZiAoIHJldCApDQo+ID4+PiArICAgICAgICBnb3RvIGVycm9yOw0KPiA+Pj4g
Kw0KPiA+Pj4gKyAgICByZXQgPSBjaGVja19zY21pX3N0YXR1cyhyeC5zdGF0dXMpOw0KPiA+Pj4g
KyAgICBpZiAoIHJldCApDQo+ID4+PiArICAgICAgICBnb3RvIGVycm9yOw0KPiA+Pj4gKw0KPiA+
Pj4gKyAgICBuX2FnZW50cyA9IEZJRUxEX0dFVChNU0dfTl9BR0VOVFNfTUFTSywgcnguYXR0cmli
dXRlcyk7DQo+ID4+PiArICAgIHByaW50ayhYRU5MT0dfREVCVUcgInNjbWk6IEdvdCBhZ2VudCBj
b3VudCAlZFxuIiwgbl9hZ2VudHMpOw0KPiA+Pj4gKw0KPiA+Pj4gKyAgICBpID0gMTsNCj4gPj4+
ICsgICAgbGlzdF9mb3JfZWFjaF9lbnRyeShlbnRyeSwgJmFkZHJfbGlzdCwgbGlzdCkNCj4gPj4+
ICsgICAgew0KPiA+Pj4gKyAgICAgICAgdWludDMyX3QgdHhfYWdlbnRfaWQgPSAweEZGRkZGRkZG
Ow0KPiA+Pj4gKyAgICAgICAgc3RydWN0IHsNCj4gPj4+ICsgICAgICAgICAgICBpbnQzMl90IHN0
YXR1czsNCj4gPj4+ICsgICAgICAgICAgICB1aW50MzJfdCBhZ2VudF9pZDsNCj4gPj4+ICsgICAg
ICAgICAgICBjaGFyIG5hbWVbMTZdOw0KPiA+Pj4gKyAgICAgICAgfSBkYV9yeDsNCj4gPj4+ICsN
Cj4gPj4+ICsgICAgICAgIGFnZW50X2NoYW5uZWwgPSBzbWNfY3JlYXRlX2NoYW5uZWwoaSwgZnVu
Y19pZCwNCj4gPj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ZW50cnktPmFkZHIpOw0KPiA+Pj4gKyAgICAgICAgaWYgKCBJU19FUlIoYWdlbnRfY2hhbm5lbCkg
KQ0KPiA+Pj4gKyAgICAgICAgew0KPiA+Pj4gKyAgICAgICAgICAgIHJldCA9IFBUUl9FUlIoYWdl
bnRfY2hhbm5lbCk7DQo+ID4+PiArICAgICAgICAgICAgZ290byBlcnJvcjsNCj4gPj4+ICsgICAg
ICAgIH0NCj4gPj4+ICsNCj4gPj4+ICsgICAgICAgIHJldCA9IG1hcF9jaGFubmVsX21lbW9yeShh
Z2VudF9jaGFubmVsKTsNCj4gPj4+ICsgICAgICAgIGlmICggcmV0ICkNCj4gPj4+ICsgICAgICAg
ICAgICBnb3RvIGVycm9yOw0KPiA+Pj4gKw0KPiA+Pj4gKyAgICAgICAgaGRyLmlkID0gU0NNSV9C
QVNFX0RJU0NPVkVSX0FHRU5UOw0KPiA+Pj4gKyAgICAgICAgaGRyLnR5cGUgPSAwOw0KPiA+Pj4g
KyAgICAgICAgaGRyLnByb3RvY29sID0gU0NNSV9CQVNFX1BST1RPQ09MOw0KPiA+Pj4gKw0KPiA+
Pj4gKyAgICAgICAgcmV0ID0gZG9fc21jX3hmZXIoYWdlbnRfY2hhbm5lbCwgJmhkciwgJnR4X2Fn
ZW50X2lkLA0KPiA+Pj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgc2l6ZW9mKHR4X2FnZW50
X2lkKSwgJmRhX3J4LCBzaXplb2YoZGFfcngpKTsNCj4gPj4+ICsgICAgICAgIGlmICggcmV0ICkN
Cj4gPj4+ICsgICAgICAgIHsNCj4gPj4+ICsgICAgICAgICAgICB1bm1hcF9jaGFubmVsX21lbW9y
eShhZ2VudF9jaGFubmVsKTsNCj4gPj4+ICsgICAgICAgICAgICBnb3RvIGVycm9yOw0KPiA+Pj4g
KyAgICAgICAgfQ0KPiA+Pj4gKw0KPiA+Pj4gKyAgICAgICAgdW5tYXBfY2hhbm5lbF9tZW1vcnko
YWdlbnRfY2hhbm5lbCk7DQo+ID4+PiArDQo+ID4+PiArICAgICAgICByZXQgPSBjaGVja19zY21p
X3N0YXR1cyhkYV9yeC5zdGF0dXMpOw0KPiA+Pj4gKyAgICAgICAgaWYgKCByZXQgKQ0KPiA+Pj4g
KyAgICAgICAgICAgIGdvdG8gZXJyb3I7DQo+ID4+PiArDQo+ID4+PiArICAgICAgICBwcmludGso
WEVOTE9HX0RFQlVHICJzY21pOiBzdGF0dXM9MHgleCBpZD0weCV4IG5hbWU9JXNcbiIsDQo+ID4+
PiArICAgICAgICAgICAgICAgIGRhX3J4LnN0YXR1cywgZGFfcnguYWdlbnRfaWQsIGRhX3J4Lm5h
bWUpOw0KPiA+Pj4gKw0KPiA+Pj4gKyAgICAgICAgYWdlbnRfY2hhbm5lbC0+YWdlbnRfaWQgPSBk
YV9yeC5hZ2VudF9pZDsNCj4gPj4+ICsNCj4gPj4+ICsgICAgICAgIGlmICggaSA9PSBuX2FnZW50
cyApDQo+ID4+PiArICAgICAgICAgICAgYnJlYWs7DQo+ID4+PiArDQo+ID4+PiArICAgICAgICBp
Kys7DQo+ID4+PiArICAgIH0NCj4gPj4+ICsNCj4gPj4+ICsgICAgc2NtaV9kYXRhLmluaXRpYWxp
emVkID0gdHJ1ZTsNCj4gPj4+ICsgICAgZ290byBvdXQ7DQo+ID4+PiArDQo+ID4+PiArZXJyb3I6
DQo+ID4+PiArICAgIHVubWFwX2NoYW5uZWxfbWVtb3J5KGNoYW5uZWwpOw0KPiA+Pj4gKyAgICBm
cmVlX2NoYW5uZWxfbGlzdCgpOw0KPiA+Pj4gK291dDoNCj4gPj4+ICsgICAgZnJlZV9zaG1lbV9y
ZWdpb25zKCZhZGRyX2xpc3QpOw0KPiA+Pj4gKyAgICByZXR1cm4gcmV0ID09IDA7DQo+ID4+PiAr
fQ0KPiA+Pj4gKw0KPiA+Pj4gK3N0YXRpYyBpbnQgc2NtaV9kb21haW5faW5pdChzdHJ1Y3QgZG9t
YWluICpkLA0KPiA+Pj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0cnVjdCB4ZW5fYXJj
aF9kb21haW5jb25maWcgKmNvbmZpZykNCj4gPj4+ICt7DQo+ID4+PiArICAgIHN0cnVjdCBzY21p
X2NoYW5uZWwgKmNoYW5uZWw7DQo+ID4+PiArICAgIGludCByZXQ7DQo+ID4+PiArDQo+ID4+PiAr
ICAgIGlmICggIXNjbWlfZGF0YS5pbml0aWFsaXplZCApDQo+ID4+PiArICAgICAgICByZXR1cm4g
MDsNCj4gPj4+ICsNCj4gPj4+ICsgICAgcHJpbnRrKFhFTkxPR19JTkZPICJzY21pOiBkb21haW5f
aWQgPSAlZFxuIiwgZC0+ZG9tYWluX2lkKTsNCj4gPj4+ICsNCj4gPj4+ICsgICAgY2hhbm5lbCA9
IGFxdWlyZV9zY21pX2NoYW5uZWwoZC0+ZG9tYWluX2lkKTsNCj4gPj4+ICsgICAgaWYgKCBJU19F
UlJfT1JfTlVMTChjaGFubmVsKSApDQo+ID4+PiArICAgICAgICByZXR1cm4gLUVOT0VOVDsNCj4g
Pj4+ICsNCj4gPj4+ICsjaWZkZWYgQ09ORklHX0FSTV8zMg0KPiA+Pj4gKyAgICBwcmludGsoWEVO
TE9HX0lORk8NCj4gPj4+ICsgICAgICAgICAgICJzY21pOiBBcXVpcmUgU0NNSSBjaGFubmVsIGlk
ID0gMHgleCAsIGRvbWFpbl9pZCA9ICVkIHBhZGRyID0gMHglbGx4XG4iLA0KPiA+Pj4gKyAgICAg
ICAgICAgY2hhbm5lbC0+Y2hhbl9pZCwgY2hhbm5lbC0+ZG9tYWluX2lkLCBjaGFubmVsLT5wYWRk
cik7DQo+ID4+PiArI2Vsc2UNCj4gPj4+ICsgICAgcHJpbnRrKFhFTkxPR19JTkZPDQo+ID4+PiAr
ICAgICAgICAgICAic2NtaTogQXF1aXJlIFNDTUkgY2hhbm5lbCBpZCA9IDB4JXggLCBkb21haW5f
aWQgPSAlZCBwYWRkciA9IDB4JWx4XG4iLA0KPiA+Pj4gKyAgICAgICAgICAgY2hhbm5lbC0+Y2hh
bl9pZCwgY2hhbm5lbC0+ZG9tYWluX2lkLCBjaGFubmVsLT5wYWRkcik7DQo+ID4+PiArI2VuZGlm
DQo+ID4+PiArDQo+ID4+PiArICAgIGlmICggaXNfaGFyZHdhcmVfZG9tYWluKGQpICkNCj4gPj4+
ICsgICAgew0KPiA+Pj4gKyAgICAgICAgcmV0ID0gbWVtX3Blcm1pdF9hY2Nlc3MoZCwgY2hhbm5l
bC0+cGFkZHIsIFBBR0VfU0laRSk7DQo+ID4+PiArICAgICAgICBpZiAoIElTX0VSUl9WQUxVRShy
ZXQpICkNCj4gPj4+ICsgICAgICAgICAgICBnb3RvIGVycm9yOw0KPiA+Pj4gKw0KPiA+Pj4gKyAg
ICAgICAgcmV0ID0gZHRfdXBkYXRlX2RvbWFpbl9yYW5nZShjaGFubmVsLT5wYWRkciwgUEFHRV9T
SVpFKTsNCj4gPj4+ICsgICAgICAgIGlmICggSVNfRVJSX1ZBTFVFKHJldCkgKQ0KPiA+Pj4gKyAg
ICAgICAgew0KPiA+Pj4gKyAgICAgICAgICAgIGludCByYyA9IG1lbV9kZW55X2FjY2VzcyhkLCBj
aGFubmVsLT5wYWRkciwgUEFHRV9TSVpFKTsNCj4gPj4+ICsgICAgICAgICAgICBpZiAoIHJjICkN
Cj4gPj4+ICsgICAgICAgICAgICAgICAgcHJpbnRrKFhFTkxPR19FUlIgIlVuYWJsZSB0byBtZW1f
ZGVueV9hY2Nlc3NcbiIpOw0KPiA+Pj4gKw0KPiA+Pj4gKyAgICAgICAgICAgIGdvdG8gZXJyb3I7
DQo+ID4+PiArICAgICAgICB9DQo+ID4+PiArICAgIH0NCj4gPj4+ICsNCj4gPj4+ICsgICAgZC0+
YXJjaC5zY2kgPSBjaGFubmVsOw0KPiA+Pj4gKyAgICBpZiAoIGNvbmZpZyApDQo+ID4+PiArICAg
ICAgICBjb25maWctPmFybV9zY2lfYWdlbnRfcGFkZHIgPSBjaGFubmVsLT5wYWRkcjsNCj4gPj4+
ICsNCj4gPj4+ICsgICAgcmV0dXJuIDA7DQo+ID4+PiArZXJyb3I6DQo+ID4+PiArICAgIHJlbGlu
cXVpc2hfc2NtaV9jaGFubmVsKGNoYW5uZWwpOw0KPiA+Pj4gKw0KPiA+Pj4gKyAgICByZXR1cm4g
cmV0Ow0KPiA+Pj4gK30NCj4gPj4+ICsNCj4gPj4+ICtzdGF0aWMgaW50IHNjbWlfYWRkX2Rldmlj
ZV9ieV9kZXZpZChzdHJ1Y3QgZG9tYWluICpkLCB1aW50MzJfdCBzY21pX2RldmlkKQ0KPiA+Pj4g
K3sNCj4gPj4+ICsgICAgc3RydWN0IHNjbWlfY2hhbm5lbCAqY2hhbm5lbCwgKmFnZW50X2NoYW5u
ZWw7DQo+ID4+PiArICAgIHNjbWlfbXNnX2hlYWRlcl90IGhkcjsNCj4gPj4+ICsgICAgc3RydWN0
IHNjbWlfcGVybXNfdHggew0KPiA+Pj4gKyAgICAgICAgdWludDMyX3QgYWdlbnRfaWQ7DQo+ID4+
PiArICAgICAgICB1aW50MzJfdCBkZXZpY2VfaWQ7DQo+ID4+PiArICAgICAgICB1aW50MzJfdCBm
bGFnczsNCj4gPj4+ICsgICAgfSB0eDsNCj4gPj4+ICsgICAgc3RydWN0IHJ4X3Qgew0KPiA+Pj4g
KyAgICAgICAgaW50MzJfdCBzdGF0dXM7DQo+ID4+PiArICAgICAgICB1aW50MzJfdCBhdHRyaWJ1
dGVzOw0KPiA+Pj4gKyAgICB9IHJ4Ow0KPiA+Pj4gKyAgICBpbnQgcmV0Ow0KPiA+Pj4gKw0KPiA+
Pj4gKyAgICBpZiAoICFzY21pX2RhdGEuaW5pdGlhbGl6ZWQgKQ0KPiA+Pj4gKyAgICAgICAgcmV0
dXJuIDA7DQo+ID4+PiArDQo+ID4+PiArICAgIHByaW50ayhYRU5MT0dfREVCVUcgInNjbWk6IHNj
bWlfZGV2aWQgPSAlZFxuIiwgc2NtaV9kZXZpZCk7DQo+ID4+PiArDQo+ID4+PiArICAgIGFnZW50
X2NoYW5uZWwgPSBkLT5hcmNoLnNjaTsNCj4gPj4+ICsgICAgaWYgKCBJU19FUlJfT1JfTlVMTChh
Z2VudF9jaGFubmVsKSApDQo+ID4+PiArICAgICAgICByZXR1cm4gUFRSX0VSUihhZ2VudF9jaGFu
bmVsKTsNCj4gPj4+ICsNCj4gPj4+ICsgICAgY2hhbm5lbCA9IGdldF9jaGFubmVsX2J5X2lkKEhZ
UF9DSEFOTkVMKTsNCj4gPj4+ICsgICAgaWYgKCBJU19FUlJfT1JfTlVMTChjaGFubmVsKSApDQo+
ID4+PiArICAgICAgICByZXR1cm4gUFRSX0VSUihjaGFubmVsKTsNCj4gPj4+ICsNCj4gPj4+ICsg
ICAgaGRyLmlkID0gU0NNSV9CQVNFX1NFVF9ERVZJQ0VfUEVSTUlTU0lPTlM7DQo+ID4+PiArICAg
IGhkci50eXBlID0gMDsNCj4gPj4+ICsgICAgaGRyLnByb3RvY29sID0gU0NNSV9CQVNFX1BST1RP
Q09MOw0KPiA+Pj4gKw0KPiA+Pj4gKyAgICB0eC5hZ2VudF9pZCA9IGFnZW50X2NoYW5uZWwtPmFn
ZW50X2lkOw0KPiA+Pj4gKyAgICB0eC5kZXZpY2VfaWQgPSBzY21pX2RldmlkOw0KPiA+Pj4gKyAg
ICB0eC5mbGFncyA9IFNDTUlfQUxMT1dfQUNDRVNTOw0KPiA+Pj4gKw0KPiA+Pj4gKyAgICByZXQg
PSBkb19zbWNfeGZlcihjaGFubmVsLCAmaGRyLCAmdHgsIHNpemVvZih0eCksICZyeCwgc2l6ZW9m
KCZyeCkpOw0KPiA+Pj4gKyAgICBpZiAoIElTX0VSUl9WQUxVRShyZXQpICkNCj4gPj4+ICsgICAg
ICAgIHJldHVybiByZXQ7DQo+ID4+PiArDQo+ID4+PiArICAgIHJldCA9IGNoZWNrX3NjbWlfc3Rh
dHVzKHJ4LnN0YXR1cyk7DQo+ID4+PiArICAgIGlmICggSVNfRVJSX1ZBTFVFKHJldCkgKQ0KPiA+
Pj4gKyAgICAgICAgcmV0dXJuIHJldDsNCj4gPj4+ICsNCj4gPj4+ICsgICAgcmV0dXJuIDA7DQo+
ID4+PiArfQ0KPiA+Pj4gKw0KPiA+Pj4gK3N0YXRpYyBpbnQgc2NtaV9hZGRfZHRfZGV2aWNlKHN0
cnVjdCBkb21haW4gKmQsIHN0cnVjdCBkdF9kZXZpY2Vfbm9kZSAqZGV2KQ0KPiA+Pj4gK3sNCj4g
Pj4+ICsgICAgdWludDMyX3Qgc2NtaV9kZXZpZDsNCj4gPj4+ICsNCj4gPj4+ICsgICAgaWYgKCAo
IXNjbWlfZGF0YS5pbml0aWFsaXplZCkgfHwgKCFkLT5hcmNoLnNjaSkgKQ0KPiA+Pj4gKyAgICAg
ICAgcmV0dXJuIDA7DQo+ID4+PiArDQo+ID4+PiArICAgIGlmICggIWR0X3Byb3BlcnR5X3JlYWRf
dTMyKGRldiwgInNjbWlfZGV2aWQiLCAmc2NtaV9kZXZpZCkgKQ0KPiA+Pj4gKyAgICAgICAgcmV0
dXJuIDA7DQo+ID4+PiArDQo+ID4+PiArICAgIHByaW50ayhYRU5MT0dfSU5GTyAic2NtaTogZHRf
bm9kZSA9ICVzXG4iLCBkdF9ub2RlX2Z1bGxfbmFtZShkZXYpKTsNCj4gPj4+ICsNCj4gPj4+ICsg
ICAgcmV0dXJuIHNjbWlfYWRkX2RldmljZV9ieV9kZXZpZChkLCBzY21pX2RldmlkKTsNCj4gPj4+
ICt9DQo+ID4+PiArDQo+ID4+PiArc3RhdGljIGludCBzY21pX3JlbGlucXVpc2hfcmVzb3VyY2Vz
KHN0cnVjdCBkb21haW4gKmQpDQo+ID4+PiArew0KPiA+Pj4gKyAgICBpbnQgcmV0Ow0KPiA+Pj4g
KyAgICBzdHJ1Y3Qgc2NtaV9jaGFubmVsICpjaGFubmVsLCAqYWdlbnRfY2hhbm5lbDsNCj4gPj4+
ICsgICAgc2NtaV9tc2dfaGVhZGVyX3QgaGRyOw0KPiA+Pj4gKyAgICBzdHJ1Y3QgcmVzZXRfYWdl
bnRfdHggew0KPiA+Pj4gKyAgICAgICAgdWludDMyX3QgYWdlbnRfaWQ7DQo+ID4+PiArICAgICAg
ICB1aW50MzJfdCBmbGFnczsNCj4gPj4+ICsgICAgfSB0eDsNCj4gPj4+ICsgICAgdWludDMyX3Qg
cng7DQo+ID4+PiArDQo+ID4+PiArICAgIGlmICggIWQtPmFyY2guc2NpICkNCj4gPj4+ICsgICAg
ICAgIHJldHVybiAwOw0KPiA+Pj4gKw0KPiA+Pj4gKyAgICBhZ2VudF9jaGFubmVsID0gZC0+YXJj
aC5zY2k7DQo+ID4+PiArDQo+ID4+PiArICAgIHNwaW5fbG9jaygmYWdlbnRfY2hhbm5lbC0+bG9j
ayk7DQo+ID4+PiArICAgIHR4LmFnZW50X2lkID0gYWdlbnRfY2hhbm5lbC0+YWdlbnRfaWQ7DQo+
ID4+PiArICAgIHNwaW5fdW5sb2NrKCZhZ2VudF9jaGFubmVsLT5sb2NrKTsNCj4gPj4+ICsNCj4g
Pj4+ICsgICAgY2hhbm5lbCA9IGdldF9jaGFubmVsX2J5X2lkKEhZUF9DSEFOTkVMKTsNCj4gPj4+
ICsgICAgaWYgKCAhY2hhbm5lbCApDQo+ID4+PiArICAgIHsNCj4gPj4+ICsgICAgICAgIHByaW50
ayhYRU5MT0dfRVJSDQo+ID4+PiArICAgICAgICAgICAgICAgInNjbWk6IFVuYWJsZSB0byBnZXQg
SHlwZXJ2aXNvciBzY21pIGNoYW5uZWwgZm9yIGRvbWFpbiAlZFxuIiwNCj4gPj4+ICsgICAgICAg
ICAgICAgICBkLT5kb21haW5faWQpOw0KPiA+Pj4gKyAgICAgICAgcmV0dXJuIC1FSU5WQUw7DQo+
ID4+PiArICAgIH0NCj4gPj4+ICsNCj4gPj4+ICsgICAgaGRyLmlkID0gU0NNSV9CQVNFX1JFU0VU
X0FHRU5UX0NPTkZJR1VSQVRJT047DQo+ID4+PiArICAgIGhkci50eXBlID0gMDsNCj4gPj4+ICsg
ICAgaGRyLnByb3RvY29sID0gU0NNSV9CQVNFX1BST1RPQ09MOw0KPiA+Pj4gKw0KPiA+Pj4gKyAg
ICB0eC5mbGFncyA9IDA7DQo+ID4+PiArDQo+ID4+PiArICAgIHJldCA9IGRvX3NtY194ZmVyKGNo
YW5uZWwsICZoZHIsICZ0eCwgc2l6ZW9mKHR4KSwgJnJ4LCBzaXplb2YocngpKTsNCj4gPj4+ICsg
ICAgaWYgKCByZXQgKQ0KPiA+Pj4gKyAgICAgICAgcmV0dXJuIHJldDsNCj4gPj4+ICsNCj4gPj4+
ICsgICAgcmV0ID0gY2hlY2tfc2NtaV9zdGF0dXMocngpOw0KPiA+Pj4gKw0KPiA+Pj4gKyAgICBy
ZXR1cm4gcmV0Ow0KPiA+Pj4gK30NCj4gPj4+ICsNCj4gPj4+ICtzdGF0aWMgdm9pZCBzY21pX2Rv
bWFpbl9kZXN0cm95KHN0cnVjdCBkb21haW4gKmQpDQo+ID4+PiArew0KPiA+Pj4gKyAgICBzdHJ1
Y3Qgc2NtaV9jaGFubmVsICpjaGFubmVsOw0KPiA+Pj4gKw0KPiA+Pj4gKyAgICBpZiAoICFkLT5h
cmNoLnNjaSApDQo+ID4+PiArICAgICAgICByZXR1cm47DQo+ID4+PiArDQo+ID4+PiArICAgIGNo
YW5uZWwgPSBkLT5hcmNoLnNjaTsNCj4gPj4+ICsgICAgc3Bpbl9sb2NrKCZjaGFubmVsLT5sb2Nr
KTsNCj4gPj4+ICsNCj4gPj4+ICsgICAgcmVsaW5xdWlzaF9zY21pX2NoYW5uZWwoY2hhbm5lbCk7
DQo+ID4+PiArICAgIHByaW50ayhYRU5MT0dfREVCVUcgInNjbWk6IEZyZWUgZG9tYWluICVkXG4i
LCBkLT5kb21haW5faWQpOw0KPiA+Pj4gKw0KPiA+Pj4gKyAgICBkLT5hcmNoLnNjaSA9IE5VTEw7
DQo+ID4+PiArDQo+ID4+PiArICAgIG1lbV9kZW55X2FjY2VzcyhkLCBjaGFubmVsLT5wYWRkciwg
UEFHRV9TSVpFKTsNCj4gPj4+ICsgICAgc3Bpbl91bmxvY2soJmNoYW5uZWwtPmxvY2spOw0KPiA+
Pj4gK30NCj4gPj4+ICsNCj4gPj4+ICtzdGF0aWMgYm9vbCBzY21pX2hhbmRsZV9jYWxsKHN0cnVj
dCBkb21haW4gKmQsIHZvaWQgKmFyZ3MpDQo+ID4+PiArew0KPiA+Pj4gKyAgICBib29sIHJlcyA9
IGZhbHNlOw0KPiA+Pj4gKyAgICBzdHJ1Y3Qgc2NtaV9jaGFubmVsICphZ2VudF9jaGFubmVsOw0K
PiA+Pj4gKyAgICBzdHJ1Y3QgYXJtX3NtY2NjX3JlcyByZXNwOw0KPiA+Pj4gKyAgICBzdHJ1Y3Qg
Y3B1X3VzZXJfcmVncyAqcmVncyA9IGFyZ3M7DQo+ID4+PiArDQo+ID4+PiArICAgIGlmICggIWQt
PmFyY2guc2NpICkNCj4gPj4+ICsgICAgICAgIHJldHVybiBmYWxzZTsNCj4gPj4+ICsNCj4gPj4+
ICsgICAgYWdlbnRfY2hhbm5lbCA9IGQtPmFyY2guc2NpOw0KPiA+Pj4gKyAgICBzcGluX2xvY2so
JmFnZW50X2NoYW5uZWwtPmxvY2spOw0KPiA+Pj4gKw0KPiA+Pj4gKyAgICBpZiAoIGFnZW50X2No
YW5uZWwtPmZ1bmNfaWQgIT0gcmVncy0+cjAgKQ0KPiA+Pj4gKyAgICB7DQo+ID4+PiArICAgICAg
ICByZXMgPSBmYWxzZTsNCj4gPj4+ICsgICAgICAgIGdvdG8gdW5sb2NrOw0KPiA+Pj4gKyAgICB9
DQo+ID4+PiArDQo+ID4+PiArICAgIGFybV9zbWNjY19zbWMoYWdlbnRfY2hhbm5lbC0+ZnVuY19p
ZCwgMCwgMCwgMCwgMCwgMCwgMCwNCj4gPj4+ICsgICAgICAgICAgICAgICAgICBhZ2VudF9jaGFu
bmVsLT5jaGFuX2lkLCAmcmVzcCk7DQo+ID4+PiArDQo+ID4+PiArICAgIHNldF91c2VyX3JlZyhy
ZWdzLCAwLCByZXNwLmEwKTsNCj4gPj4+ICsgICAgc2V0X3VzZXJfcmVnKHJlZ3MsIDEsIHJlc3Au
YTEpOw0KPiA+Pj4gKyAgICBzZXRfdXNlcl9yZWcocmVncywgMiwgcmVzcC5hMik7DQo+ID4+PiAr
ICAgIHNldF91c2VyX3JlZyhyZWdzLCAzLCByZXNwLmEzKTsNCj4gPj4+ICsgICAgcmVzID0gdHJ1
ZTsNCj4gPj4+ICt1bmxvY2s6DQo+ID4+PiArICAgIHNwaW5fdW5sb2NrKCZhZ2VudF9jaGFubmVs
LT5sb2NrKTsNCj4gPj4+ICsNCj4gPj4+ICsgICAgcmV0dXJuIHJlczsNCj4gPj4+ICt9DQo+ID4+
PiArDQo+ID4+PiArc3RhdGljIGNvbnN0IHN0cnVjdCBkdF9kZXZpY2VfbWF0Y2ggc2NtaV9zbWNf
bWF0Y2hbXSBfX2luaXRjb25zdCA9DQo+ID4+PiArew0KPiA+Pj4gKyAgICBEVF9NQVRDSF9TQ01J
X1NNQywNCj4gPj4+ICsgICAgeyAvKiBzZW50aW5lbCAqLyB9LA0KPiA+Pj4gK307DQo+ID4+PiAr
DQo+ID4+PiArc3RhdGljIGNvbnN0IHN0cnVjdCBzY2lfbWVkaWF0b3Jfb3BzIHNjbWlfb3BzID0N
Cj4gPj4+ICt7DQo+ID4+PiArICAgIC5wcm9iZSA9IHNjbWlfcHJvYmUsDQo+ID4+PiArICAgIC5k
b21haW5faW5pdCA9IHNjbWlfZG9tYWluX2luaXQsDQo+ID4+PiArICAgIC5kb21haW5fZGVzdHJv
eSA9IHNjbWlfZG9tYWluX2Rlc3Ryb3ksDQo+ID4+PiArICAgIC5hZGRfZHRfZGV2aWNlID0gc2Nt
aV9hZGRfZHRfZGV2aWNlLA0KPiA+Pj4gKyAgICAucmVsaW5xdWlzaF9yZXNvdXJjZXMgPSBzY21p
X3JlbGlucXVpc2hfcmVzb3VyY2VzLA0KPiA+Pj4gKyAgICAuaGFuZGxlX2NhbGwgPSBzY21pX2hh
bmRsZV9jYWxsLA0KPiA+Pj4gK307DQo+ID4+PiArDQo+ID4+PiArUkVHSVNURVJfU0NJX01FRElB
VE9SKHNjbWlfc21jLCAiU0NNSS1TTUMiLCBYRU5fRE9NQ1RMX0NPTkZJR19BUk1fU0NJX1NDTUlf
U01DLA0KPiA+Pj4gKyAgICAgICAgICAgICAgICAgICAgICBzY21pX3NtY19tYXRjaCwgJnNjbWlf
b3BzKTsNCj4gPj4+ICsNCj4gPj4+ICsvKg0KPiA+Pj4gKyAqIExvY2FsIHZhcmlhYmxlczoNCj4g
Pj4+ICsgKiBtb2RlOiBDDQo+ID4+PiArICogYy1maWxlLXN0eWxlOiAiQlNEIg0KPiA+Pj4gKyAq
IGMtYmFzaWMtb2Zmc2V0OiA0DQo+ID4+PiArICogaW5kZW50LXRhYnMtbW9kZTogbmlsDQo+ID4+
PiArICogRW5kOg0KPiA+Pj4gKyAqLw0KPiA+Pj4gLS0gDQo+ID4+PiAyLjI3LjANCj4g


From xen-devel-bounces@lists.xenproject.org Fri Feb 11 11:58:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 11:58:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270456.464751 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIUZS-00029G-FO; Fri, 11 Feb 2022 11:58:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270456.464751; Fri, 11 Feb 2022 11:58:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIUZS-000299-CD; Fri, 11 Feb 2022 11:58:38 +0000
Received: by outflank-mailman (input) for mailman id 270456;
 Fri, 11 Feb 2022 11:58:36 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nIUZQ-00028z-LM; Fri, 11 Feb 2022 11:58:36 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nIUZQ-0006pr-Iu; Fri, 11 Feb 2022 11:58:36 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nIUZQ-0005by-0B; Fri, 11 Feb 2022 11:58:36 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nIUZP-0003LI-Vp; Fri, 11 Feb 2022 11:58:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=5e0CNLI7NR8M7Q0TwSW7oGQya2m0LVRtTBlYnsBb5fI=; b=FEIni7DySxhuU+D+1NzWgtMIL/
	dZri1bGWBfcVyY0lUifhZDMuRBTh6OMCOvAMasJEENlFMNvyWpmVIaFBqW+zLuiZVmy2fz2ASiVcb
	ophpeXPhTafFc9/X8mDh5NE0TvTTKd3arRR0SbcZrxXT2sDQ0sFBg8tQGzAunjISjFWU=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168081-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 168081: trouble: broken/fail/pass
X-Osstest-Failures:
    xen-unstable:test-arm64-arm64-xl-credit1:<job status>:broken:regression
    xen-unstable:test-arm64-arm64-xl-credit2:<job status>:broken:regression
    xen-unstable:test-arm64-arm64-xl-seattle:<job status>:broken:regression
    xen-unstable:test-arm64-arm64-xl-xsm:<job status>:broken:regression
    xen-unstable:test-arm64-arm64-xl-seattle:host-install(5):broken:heisenbug
    xen-unstable:test-arm64-arm64-xl-credit2:host-install(5):broken:heisenbug
    xen-unstable:test-arm64-arm64-xl-xsm:host-install(5):broken:heisenbug
    xen-unstable:test-arm64-arm64-xl-credit1:host-install(5):broken:heisenbug
    xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=87319afb96973213ec0a76270d93696f3b8d6743
X-Osstest-Versions-That:
    xen=87319afb96973213ec0a76270d93696f3b8d6743
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 11 Feb 2022 11:58:35 +0000

flight 168081 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168081/

Failures and problems with tests :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-credit1     <job status>                 broken
 test-arm64-arm64-xl-credit2     <job status>                 broken
 test-arm64-arm64-xl-seattle     <job status>                 broken
 test-arm64-arm64-xl-xsm         <job status>                 broken

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-xl-seattle   5 host-install(5)          broken pass in 168075
 test-arm64-arm64-xl-credit2   5 host-install(5)          broken pass in 168075
 test-arm64-arm64-xl-xsm       5 host-install(5)          broken pass in 168075
 test-arm64-arm64-xl-credit1   5 host-install(5)          broken pass in 168075
 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 168075 pass in 168081
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 168075 pass in 168081

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl-seattle 15 migrate-support-check fail in 168075 never pass
 test-arm64-arm64-xl-seattle 16 saverestore-support-check fail in 168075 never pass
 test-arm64-arm64-xl-xsm     15 migrate-support-check fail in 168075 never pass
 test-arm64-arm64-xl-credit2 15 migrate-support-check fail in 168075 never pass
 test-arm64-arm64-xl-credit1 15 migrate-support-check fail in 168075 never pass
 test-arm64-arm64-xl-credit2 16 saverestore-support-check fail in 168075 never pass
 test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 168075 never pass
 test-arm64-arm64-xl-credit1 16 saverestore-support-check fail in 168075 never pass
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168075
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168075
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168075
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168075
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168075
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168075
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168075
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168075
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168075
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168075
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168075
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168075
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 xen                  87319afb96973213ec0a76270d93696f3b8d6743
baseline version:
 xen                  87319afb96973213ec0a76270d93696f3b8d6743

Last test of basis   168081  2022-02-11 01:52:03 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      broken  
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  broken  
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  broken  
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  broken  
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary

broken-job test-arm64-arm64-xl-credit1 broken
broken-job test-arm64-arm64-xl-credit2 broken
broken-job test-arm64-arm64-xl-seattle broken
broken-job test-arm64-arm64-xl-xsm broken
broken-step test-arm64-arm64-xl-seattle host-install(5)
broken-step test-arm64-arm64-xl-credit2 host-install(5)
broken-step test-arm64-arm64-xl-xsm host-install(5)
broken-step test-arm64-arm64-xl-credit1 host-install(5)

Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Fri Feb 11 11:58:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 11:58:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270459.464763 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIUZe-0002Tt-OK; Fri, 11 Feb 2022 11:58:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270459.464763; Fri, 11 Feb 2022 11:58:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIUZe-0002Tg-KQ; Fri, 11 Feb 2022 11:58:50 +0000
Received: by outflank-mailman (input) for mailman id 270459;
 Fri, 11 Feb 2022 11:58:48 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=WJSo=S2=amazon.de=prvs=034f27e45=nmanthey@srs-se1.protection.inumbo.net>)
 id 1nIUZc-0002SW-H2
 for xen-devel@lists.xenproject.org; Fri, 11 Feb 2022 11:58:48 +0000
Received: from smtp-fw-80007.amazon.com (smtp-fw-80007.amazon.com
 [99.78.197.218]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f6a291bb-8b31-11ec-8f75-fffcc8bd4f1a;
 Fri, 11 Feb 2022 12:58:46 +0100 (CET)
Received: from pdx4-co-svc-p1-lb2-vlan2.amazon.com (HELO
 email-inbound-relay-iad-1e-0bfdb89e.us-east-1.amazon.com) ([10.25.36.210])
 by smtp-border-fw-80007.pdx80.corp.amazon.com with ESMTP;
 11 Feb 2022 11:58:29 +0000
Received: from EX13D02EUB001.ant.amazon.com
 (iad12-ws-svc-p26-lb9-vlan3.iad.amazon.com [10.40.163.38])
 by email-inbound-relay-iad-1e-0bfdb89e.us-east-1.amazon.com (Postfix) with
 ESMTPS id 8D9BFE0116; Fri, 11 Feb 2022 11:58:26 +0000 (UTC)
Received: from [192.168.4.205] (10.43.162.202) by EX13D02EUB001.ant.amazon.com
 (10.43.166.150) with Microsoft SMTP Server (TLS) id 15.0.1497.28;
 Fri, 11 Feb 2022 11:58:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f6a291bb-8b31-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
  d=amazon.de; i=@amazon.de; q=dns/txt; s=amazon201209;
  t=1644580727; x=1676116727;
  h=message-id:date:mime-version:to:cc:references:from:
   in-reply-to:content-transfer-encoding:subject;
  bh=x426+bmpQfTrZ/ZTSUkxnxM4vfK12dd/uB1OPhp7Ccc=;
  b=ip/H7lqlZlEyurHvd+LiyTLUFgYjfpZ94OBwr0d+yTSUn1vxlllq3o9t
   HjQlQbK4mSHmIUAt3aXFzQmSkew385kC60ccTE/NWRw7bNfuKEdAOWUNV
   0LIP3pQ7cPzTvjxDm+3fzUpo/3ZDcOjcxBdh4RNeY/Kq8gP/ZZ/92R6my
   Y=;
X-IronPort-AV: E=Sophos;i="5.88,360,1635206400"; 
   d="scan'208";a="62347671"
Subject: Re: [PATCH CPU v1] cpuid: initialize cpuinfo with boot_cpu_data
Message-ID: <8f38f316-134c-b884-527c-7869ef6b3425@amazon.de>
Date: Fri, 11 Feb 2022 12:58:19 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.1
Content-Language: en-US
To: Jan Beulich <jbeulich@suse.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
	<wl@xen.org>, <xen-devel@lists.xenproject.org>
References: <20220211072327.1213-1-nmanthey@amazon.de>
 <c10ec679-258a-f983-7c5d-b9f536b7ca26@suse.com>
From: Norbert Manthey <nmanthey@amazon.de>
In-Reply-To: <c10ec679-258a-f983-7c5d-b9f536b7ca26@suse.com>
X-Originating-IP: [10.43.162.202]
X-ClientProxiedBy: EX13d09UWC003.ant.amazon.com (10.43.162.113) To
 EX13D02EUB001.ant.amazon.com (10.43.166.150)
Precedence: Bulk
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64

T24gMi8xMS8yMiAxMTozNCwgSmFuIEJldWxpY2ggd3JvdGU6Cj4gT24gMTEuMDIuMjAyMiAwODoy
MywgTm9yYmVydCBNYW50aGV5IHdyb3RlOgo+PiAtLS0gYS94ZW4vYXJjaC94ODYvY3B1aWQuYwo+
PiArKysgYi94ZW4vYXJjaC94ODYvY3B1aWQuYwo+PiBAQCAtNjA5LDcgKzYwOSw3IEBAIHZvaWQg
X19pbml0IGluaXRfZ3Vlc3RfY3B1aWQodm9pZCkKPj4gIGJvb2wgcmVjaGVja19jcHVfZmVhdHVy
ZXModW5zaWduZWQgaW50IGNwdSkKPj4gIHsKPj4gICAgICBib29sIG9rYXkgPSB0cnVlOwo+PiAt
ICAgIHN0cnVjdCBjcHVpbmZvX3g4NiBjOwo+PiArICAgIHN0cnVjdCBjcHVpbmZvX3g4NiBjID0g
Ym9vdF9jcHVfZGF0YTsKPj4gICAgICBjb25zdCBzdHJ1Y3QgY3B1aW5mb194ODYgKmJzcCA9ICZi
b290X2NwdV9kYXRhOwo+PiAgICAgIHVuc2lnbmVkIGludCBpOwo+IFdoaWxlIEkgYWdyZWUgd2l0
aCB0aGUgbmVlZCB0byBpbml0aWFsaXplIHRoZSBsb2NhbCB2YXJpYWJsZSwgSQo+IGRvbid0IHRo
aW5rIGl0IHNob3VsZCBiZSBwcmUtc2VlZGVkIHdpdGggcHJldmlvdXMgaW5kZW50aWZpY2F0aW9u
Cj4gcmVzdWx0czogVGhpcyBjb3VsZCBlbmQgdXAgaGlkaW5nIGJ1Z3MuIEluc3RlYWQgSSdkIHNl
ZSBpdCBzaW1wbHkKPiBiZSB6ZXJvLWZpbGxlZC4KClRoYXQgd29ya3MgZm9yIG1lIGFzIHdlbGws
IEknbGwgc2VuZCBhIHJldi0yIGFjY29yZGluZ2x5LgoKTm9yYmVydAoKCgoKQW1hem9uIERldmVs
b3BtZW50IENlbnRlciBHZXJtYW55IEdtYkgKS3JhdXNlbnN0ci4gMzgKMTAxMTcgQmVybGluCkdl
c2NoYWVmdHNmdWVocnVuZzogQ2hyaXN0aWFuIFNjaGxhZWdlciwgSm9uYXRoYW4gV2Vpc3MKRWlu
Z2V0cmFnZW4gYW0gQW10c2dlcmljaHQgQ2hhcmxvdHRlbmJ1cmcgdW50ZXIgSFJCIDE0OTE3MyBC
ClNpdHo6IEJlcmxpbgpVc3QtSUQ6IERFIDI4OSAyMzcgODc5CgoK



From xen-devel-bounces@lists.xenproject.org Fri Feb 11 11:58:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 11:58:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270460.464768 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIUZf-0002Y8-5o; Fri, 11 Feb 2022 11:58:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270460.464768; Fri, 11 Feb 2022 11:58:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIUZe-0002XT-V3; Fri, 11 Feb 2022 11:58:50 +0000
Received: by outflank-mailman (input) for mailman id 270460;
 Fri, 11 Feb 2022 11:58:49 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=dFbI=S2=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nIUZd-0002SW-9n
 for xen-devel@lists.xenproject.org; Fri, 11 Feb 2022 11:58:49 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f7a0f4c5-8b31-11ec-8f75-fffcc8bd4f1a;
 Fri, 11 Feb 2022 12:58:48 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f7a0f4c5-8b31-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644580727;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=GzzCxmTrm6T7Zp4l13te72+dteyyhmVZyhQ/ZGKMTvE=;
  b=iYHoVEiI4ehJ8OL7uvtISiG3PPqFqEuK+9XSriXxIs9gxeBeXO7crgsO
   fH26ra5/sECBuOGLRkZDeER5/TxwbQJ7gHeg4ku/Qx7r1+yxpRw+rMNz4
   mF4N2K4ccGFHVBMwu13jiHLAxLjL9To7BVr13ENKAo91mBUH2UEaTxfQW
   I=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: ekfzAd781f4GDP+leoICK9yCcCDbIynRSTE7OqG/of+H8/j/emqz2hLZPboq8ABsaiEKmxnjV6
 4D6ep35JvEZA+qffxoRI1xj7Hit1XJT/JoKUVyjO8NgyNbpXcesCgH2eTm+sweSShVQJfqkD6m
 CwdERZuL5/xKDDNgnHr6dc20a5FACfX4AkiCpRrEcmVmUl15nsEol6+7+wGSVPyVGpY7r1uSLX
 /7wlqMUsiOtHm5Dhe2L0DQF/M+vTlle77eQzCJy3I2EZl4ukZXQ9MX7q1wQOC3lJ6N1Ql+Au6w
 upVgFzzzSpoR2Bk0FeWVf8uS
X-SBRS: 5.1
X-MesageID: 63455831
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:kCWj3KCMNVxuqxVW/8fkw5YqxClBgxIJ4kV8jS/XYbTApG4nhj0Dz
 TQdDW3Ta/mOMGbzLYojYN7np0gCvpbczdBmQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMo/u1Si6FatANl1ElvU2zbue6WL6s1hxZH1c+En970Es7wobVv6Yz6TSHK1LV0
 T/Ni5W31G+Ng1aY5UpNtspvADs21BjDkGtwUm4WPJinj3eH/5UhN7oNJLnZEpfNatI88thW5
 Qr05OrREmvxp3/BAz4++1rxWhVirrX6ZWBihpfKMkQLb9crSiEai84G2PQghUh/mhPOsP8ol
 eh07YXzewsZDr+XidkgXEwNe81+FfUuFL7vJHG+tYqYzlHccmuqyPJrZK00FdRGoKAtWzgIr
 KFGbmBWBvyAr7veLLaTUO5ji95lNMD2FIgepmth3XfSCvNOrZXrHf6WuIIIh25YasZmGczBe
 OQ0VWJWcUqdfy0TGG8GKp55k7L97pX4W2IB8w/EzUYt2EDMyCRh3b6rN8DaEvSMQMxTgkaVt
 0rP+m3rBRdcONH34TiP/2+oh+TPtTjmQ49UH7q9ntZ6jVvWymENBRk+UVqgveL/mkO4Q8hYK
 UEf5mwpt6dayaCwZoCjBVvi+ifC50NCHYoLewEn1O2T4rvypCm2XzU5d2ZYK+4qhP8kHi0X6
 1DcyrsFGgdTmLGSTHuc8JKdojWzJTUZIAc+WMMUcecWy4K9+d9u13ojWv4mSffo1YOtRVkc1
 hjX9HBWulkFsSIcO0xXF3jjiinkmJXGRxVdCu7/DjP8tVMRiGJIiuWVBbnnARRocd7xorqp5
 iFsdy2iAAYmV8DleMulGrtlIV1Rz6zZWAAweHY2d3Xbyxyj+mS4Yadb6yxkKUFiP64sIGG1P
 BKJ5FwOvsIKZBNGiJObharrWqzGKoC6S7zYug38NIISMvCdiifblM2RWaJg9z+0yxV9+U3OE
 ZyabdytHR4n5VdPl1KLqxMm+eZznEgWnDqLLbiilkjP+efONRa9FOZeWHPTP79R0U9xiFiMm
 zqpH5DRkEs3vSyXSnS/zLP/2nhUcSZlVcqr96S6tIere2JbJY3oMNeIqZsJcI15haVF0ODO+
 3C2QEhDz1Tjw3bALG23hrpLMdsDhL5z8iA2OzICJ1Gt1yRxaIqj9v5HJZA2YaMm5KpoyvstF
 6sJfMCJA/JuTDXb+mtCMcmh/dI6LBn71xiTOyeFYSQke8IyTQL+5dK5LBDk8zMDD3TruJJm8
 aGgzA7SXbEKWx9mUJTNcPuqwl7o5Sodlet+UlHmON5WfEmwooFmJzao1q08It0WKAWFzTyfj
 l7EDRAdrOjLgok07NiW2vzU89b3S7NzRxMIEXPa4LC6MTjh0lCimYIQAvyVeT39VX/v/Pnwb
 +ti0PyhYuYMm0xHstQgHu8zn74+/dbmu5RT0h9gQCfQd12uB75tfiuG0M1IuvEfz7NVo1LrC
 EeG+90cMrSVIsL1VlUWIVN9POiE0PgVnBjU7Og0fxqmtHMmouLfXBUAJQSIhQxcMKBxYdEsz
 uoWscIL7xCy10gxOdGcgyEIr2mBIxTsiUn8Wk321GMztjcW9w==
IronPort-HdrOrdr: A9a23:XnvWfK/btBwtrjJp531uk+FAdb1zdoMgy1knxilNoENuHfBwxv
 rDoB1E73LJYVYqOU3Jmbi7Sc69qFfnhORICO4qTMqftWjdyRCVxeRZg7cKrAeQeREWmtQtsJ
 uINpIOdOEYbmIK/PoSgjPIaurIqePvmMvD5Za8854ud3ATV0gJ1XYGNu/xKDwReOApP+tcKH
 LKjfA32AZINE5nJfiTNz0gZazuttfLnJXpbVovAAMm0hCHiXeN5KThGxaV8x8CW3cXqI1SvF
 Ttokjc3OGOovu7whjT2yv66IlXosLozp9mCNaXgsYYBz3wgkKDZZhnWZeFoDcpydvfomoCoZ
 3pmVMNLs5z43TeciWcpgbs4RDp1HIU53rr2Taj8A3eiP28YAh/J9tKhIpffBecwVEnpstA3K
 VC2H/cn4ZLDDvb9R6NqeTgZlVPrA6ZsHAimekcgzh0So0FcoJcqoQZ4Qd8DIoAJiTn84oqed
 MeQ/003MwmMW9yUkqp/VWGmLeXLzYO91a9MwQ/U/WuonlrdCsT9Tpc+CQd9k1wg67VBaM0o9
 gsCZ4Y542mePVmGZ6VNN1xMfdfNVa9My4kEFjiaGgPR5t3c04klfbMkcAIDaeRCds18Kc=
X-IronPort-AV: E=Sophos;i="5.88,360,1635220800"; 
   d="scan'208";a="63455831"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=d5Ls8hlSI+WZsVvNNtVaYuWz5aUJYyRvdtaQQhdTxxfAxO6hSnda4h15gxOiQCKF9gytKaLKCsDddlzsfnzMqBo9NoHPPwd5jqdhO9V53J+dwlrwY8mCwonoVtFzQ1glxzXdJAeCqBPCGVA2zshiLN6JicYbNlLUW0T0+/w9zc1wotxFl8wPAJcGyTEyQXFQYpmGXajPX6kvob9XY+rUr35w0qMrGmCY1BXdBMAaGw+g+CKCkiM8tKNhD08obUd7uSb4MJph9o64/yXTO5SgbTbBb5+17s+CVtuHY7NLbqUGanUoep2RbtJayJrKVi94y1EEOj+U1WOTynGxydSR1g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=hkUSgd0/s3YgqRWYKzA4XzU7NSSREIDDlyfEsRht7X0=;
 b=Ynos6ufzGGlmn+RvPh2XmA/hhoo/KSf6buU6TgYYQ+qlh+XaQoxsqEvvuv1Fsy7jOJUYx+khnc2sg6SzXHXeNawfes+VHQ4MZVbLdWLqZdFnJPx7GuBfHw45hMSy3s8WTJM7QUSKsV2nWehQAjzkBJ/IyFmUEb69A5gtUrevZ+AJpI+4IDKb8QYo/gCiArnEjlD4q4akoyN4CBO/avSR9IPoeSiJmgfaECNcgYZuWS8zw3pBmXkyby5mqvc3SrMrXBn9DE7j/hLfhyQBiBYw8ol5H+i4j0cNMfuGoXEzHxiyCYakuhM4iPARTCDg5sTOMdGoKVHBl2l0T0CxSgk0Fw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=hkUSgd0/s3YgqRWYKzA4XzU7NSSREIDDlyfEsRht7X0=;
 b=TUlM2hl/m6sDAqf8v1ufNWZ57cXhB2BkU6dmsFSptugWepUKKq5PctgLJ9WAPwiiWg/2Wlf+Tgi8xKI4MwNjS3SCK/JcyIwgWgOhPuyJyAiyNmVzqhwkj78T/3S3+EIHcXDUvMWiS/boTtdBgCH5Nj9vU4MvxvgeASGYZBnOUFg=
Date: Fri, 11 Feb 2022 12:58:38 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: <xen-devel@lists.xenproject.org>, Andrew Cooper
	<andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>, Norbert Manthey
	<nmanthey@amazon.de>
Subject: Re: [PATCH CPU v1] cpuid: initialize cpuinfo with boot_cpu_data
Message-ID: <YgZPbjIORYSykyOv@Air-de-Roger>
References: <20220211072327.1213-1-nmanthey@amazon.de>
 <YgYmKiZaX2vZYgKP@Air-de-Roger>
 <85182aaf-1d3b-981a-1108-8eed79516893@suse.com>
 <YgY+sUOIaW7c3Mq2@Air-de-Roger>
 <717694b1-bcb9-b2cd-3740-71d8431a3058@suse.com>
 <YgZGPZUyW0mzGz+Q@Air-de-Roger>
 <fa312e0c-571c-b200-7d34-9f2d14c2b67a@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <fa312e0c-571c-b200-7d34-9f2d14c2b67a@suse.com>
X-ClientProxiedBy: LO4P123CA0017.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:150::22) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 977ad77d-085c-4bfa-6ded-08d9ed55d99f
X-MS-TrafficTypeDiagnostic: SN6PR03MB3456:EE_
X-Microsoft-Antispam-PRVS: <SN6PR03MB34560B0755D4818ABA4549C78F309@SN6PR03MB3456.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: W6U6KmYzrizF6t+aKYBbJAPZaOTPCLfZrsgX0zZPFmsH7YOSwD3QjrVNrrD/gaxUjA4ODxkfU711KzwCYhY/qmY1lG3XSel0AA2jIP/qNKJWfcuoGrrV1RIpwQzV7JX/u8I+LgvGzARZsQ6d8YKCRxU42cQw99wKn8VSRu4JtN9fkdmBEtXVB4tV3bY9F3tPHtlptXlOhuVN5M70fUt3tCpi6Zyifv6oWz40vFL5OhpVELz2TXLjLcM78n6RUE2sa+lmztZ9uSQHLgW5/otPeRJpAS6e/xttVy/KxdPGmN4lAKMFvdDg5pjTBouW2azRAw+n7Pft271FQWPTAsuYtlUX4Mh7VjdoBK2i25qJdJlJRgMT8DkPEzLxSV32za0+ukYnGfcS7ugs1FBrkQTx2syrkeCEA4o/d4S/9iWqFqetOBXA/ai//O0ju510/2HLmZ7l2ll/hxgJK6/LMn3st+brkf9y6ZF3TT6flakxE0sK7gNHufqKnpXeyny5E8TPNN5Gnie7LT3hKvbWYKVtwHgXc4/4yHZ8YTJw8wVYj7KHPeZrg1Em2bGGwGcaKis3BoloHiiF2PYuCcyjgk0Nfx/68z2xhG25dTTWeSDpru0WsYEl8xeL22GuyXU+FhlflJ6l/vt6He0AJlMLcoYlAg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(8676002)(6666004)(82960400001)(66476007)(6512007)(316002)(38100700002)(86362001)(508600001)(4326008)(6916009)(6486002)(9686003)(54906003)(53546011)(66556008)(66946007)(6506007)(8936002)(83380400001)(186003)(2906002)(85182001)(33716001)(26005)(5660300002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZkhLOUVQd2dOTUk2NUhWTUVQUzdDRmxMY21iMURmdnRnSmNnWUV1c0JrSEJW?=
 =?utf-8?B?VUZ1akU0WldiemkvNTV4RjQyQ2EzNDhGdU51MlFDZkhIMFZEMjNJTERrd2Vn?=
 =?utf-8?B?aHVRTnVwcHBsaDhiUkl0N2k0M3l4MzNDZ25pS2pCTUJ2cEZZMUNLL1hIcVRh?=
 =?utf-8?B?UzBvdUJETDVGNUxmOTBqSWM0NzJRak5PVURaSndqalY5WHhma2FiNmwvbUhZ?=
 =?utf-8?B?dGtQeXFxSnhQRmZLSS85eFFFWTIzZEpoWE45TXV4N0NYeUZ2Y0RydUZnQTFj?=
 =?utf-8?B?Nm4yNFV4MzhaZ1cvenpqRjcvQ1g5clNBMWFCNDN3N3BMUjdWL0RVTHhrUElJ?=
 =?utf-8?B?NWJSVGJNdHpKSTBQZGFFYVUwcTNhVldOVkVkaUpEUWU2Q1FGSzVtc1FRVHBU?=
 =?utf-8?B?OUJIa3FzMmRmcGpPRDJmZm9Vb0ViK0E3YU1oVDk1ZWV4RHMzQkx3YjBYMkhm?=
 =?utf-8?B?b1RsRkF5MUJCR3JaUU5tMy8vZVFVdkRYSEN5bTZvYmdmdVN2WGV2alpvZFhM?=
 =?utf-8?B?SlI4Y1VDc0FlQ3FzRk9iUTc4aDh6QmhaMC9xVmRYU0Q2OGx5bUROYnlkYXJF?=
 =?utf-8?B?bnY4RXkzM3ltZHJsRGFwenJOYTF0WDlPRStJQTV4Mit0NWg1TzVWOXBDa01i?=
 =?utf-8?B?bWI0Vmh2empWRmZsTStuTjFNQm9tcktpRlAxeTRubHBoVWd2Q1FreXphY0Y3?=
 =?utf-8?B?bWRtVmFrcFF1NnZaZWNSYklISFJNZ1hLK1JuVm16UDA2THRMUnhPMmtFTk5x?=
 =?utf-8?B?WThSTzFuelAvOVkyZXkvMnF0dUhlRTZaR1VYZmVCbXpxWVlqZm9lR3ZPdWpR?=
 =?utf-8?B?d0JVQU81OS9FaE5YcGZibTgwa3liQm80bElnS3F3YXhHT3BHcXRaQXV5Nmh5?=
 =?utf-8?B?bStTeUNCRy9OSG9OQjhlTGxpUFk3bzQrRTUvdnVhNXh4dEM3VnZMR2xuZFYw?=
 =?utf-8?B?RDQ1MlhsOWZ5TlB2RCtIcjNSd1M5RE1rSFFDM29XekJJeW9SbGk3ODVBNkE4?=
 =?utf-8?B?YitQU2V5dEtCdmhpa0EyM2hBWVh3RW5KUEZ0cnpEZkh3MXlGNE8vdEhFeFFH?=
 =?utf-8?B?Vys3WUkrNmNYQjZlVkgxOTVMR09rTGtFQ21pcHhkSk5nQWZGMll2OFllNHc2?=
 =?utf-8?B?MWRId1M1bTAwWktiMkk2WUt6alVWNktnQ3dDNzc2eXJKYk81Zk5XUlR3NjZn?=
 =?utf-8?B?bjk2M0Nvc2ZxZmNiME8wYXNJQ3J1b2Q4bVByb3dHcVFRVFB3WXRrYWZ4SE44?=
 =?utf-8?B?OHBWRTNuMTRKaU1halZoWjJiVWJ0YU1YQktPemk3TlF5alNwa215SDRRc1Zy?=
 =?utf-8?B?M05VWlB3bmdySkhNZmgvcWFzNEp5a2paNEpYU2xXYzNrckNVejM0TkN6dnhK?=
 =?utf-8?B?QS9HVEhZZy9PdkV1NDNrZTZjcXpYeG1KTk1CRVllb0tyTVdHSVJuWHIzalpO?=
 =?utf-8?B?Um1Oa1FjZ1Z6eW9hQTBTbE5HaExJVk43amVzSkJ0aEQ4aEQ2K3Fkd3g5NW9J?=
 =?utf-8?B?OStxQ3ZsejI0MXVWN3h0blJzZjRZQXdOVE4vb0FEN2Q4K0dsWUxnQW9SOUlR?=
 =?utf-8?B?SWZpTHBSUGhpK1ZUVDUrUWRsWERNcmQxNTBRWEdBUWdoUE5XaXEyMGROZlpN?=
 =?utf-8?B?bXhyUW1MVUdGMHBLd2Z6Um9tTnYzRGFhemhnbGJWelJDTmZFR0tmRm1YVUk4?=
 =?utf-8?B?NkJYUmdsVGw3emhUVE8rdDZXQ1pqcnpzbmlrS2xvbm1keE40Wmh6UnBITnIr?=
 =?utf-8?B?MXFkbWg4MmpyT3lWa2dqVHZtR3JOZmNlRkVBSW92L2ZIUkpvMGxlYXFKNysz?=
 =?utf-8?B?REs3YWZWMTVzSXFhVHk5OFBlOUZJT2pqOG5JbXJXREdSd1hFc3hlV0FhZjNv?=
 =?utf-8?B?elpSMmZ1OGkrNDgxM3NBWkE2VzZVSUdyU0R6TEJNNFladFozL0RVaUw3YjZG?=
 =?utf-8?B?NitiUGZnWG9QcEEvZWZmRGNkeTNZSFJ4ODk1MU9idmlubHBjVmFrY3pZeDY3?=
 =?utf-8?B?ZCtjOEIyNzVLMU1oNTVLVml6UVlPZmFXWmZxNWFLS0RhMWJlT3VqMDBIemJo?=
 =?utf-8?B?L0hjWDB4a2lrczNxMlBRdWJYalF3VTd6TTlQdkVDYWFSN1V1MWxTaDIwVVBj?=
 =?utf-8?B?UllsZEZmU0ZrVXBUei96RnYrUDlaNmFqT1F3U2Q1ZWtYRnZrME9lZDA3bmpz?=
 =?utf-8?Q?/rCBX3hLWxXqOJFC7iMPK4E=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 977ad77d-085c-4bfa-6ded-08d9ed55d99f
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2022 11:58:43.0149
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 24jQIQgav5odVlQAJPaumFypnVjNI/HFyXuL+D4t+5Fss71bQCHZYvFFvWPfh4U8W5UADi1FE3vLzRYwR8Y8Hg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR03MB3456
X-OriginatorOrg: citrix.com

On Fri, Feb 11, 2022 at 12:42:11PM +0100, Jan Beulich wrote:
> On 11.02.2022 12:19, Roger Pau Monné wrote:
> > On Fri, Feb 11, 2022 at 11:50:46AM +0100, Jan Beulich wrote:
> >> On 11.02.2022 11:47, Roger Pau Monné wrote:
> >>> On Fri, Feb 11, 2022 at 11:32:45AM +0100, Jan Beulich wrote:
> >>>> On 11.02.2022 10:02, Roger Pau Monné wrote:
> >>>>> On Fri, Feb 11, 2022 at 08:23:27AM +0100, Norbert Manthey wrote:
> >>>>>> When re-identifying CPU data, we might use uninitialized data when
> >>>>>> checking for the cache line property to adapt the cache
> >>>>>> alignment. The data that depends on this uninitialized read is
> >>>>>> currently not forwarded.
> >>>>>>
> >>>>>> To avoid problems in the future, initialize the data cpuinfo
> >>>>>> structure before re-identifying the CPU again.
> >>>>>>
> >>>>>> The trace to hit the uninitialized read reported by Coverity is:
> >>>>>>
> >>>>>> bool recheck_cpu_features(unsigned int cpu)
> >>>>>> ...
> >>>>>>     struct cpuinfo_x86 c;
> >>>>>>     ...
> >>>>>>     identify_cpu(&c);
> >>>>>>
> >>>>>> void identify_cpu(struct cpuinfo_x86 *c)
> >>>>>> ...
> >>>>>>     generic_identify(c)
> >>>>>>
> >>>>>> static void generic_identify(struct cpuinfo_x86 *c)
> >>>>>> ...
> >>>>>
> >>>>> Would it be more appropriate for generic_identify to also set
> >>>>> x86_cache_alignment like it's done in early_cpu_init?
> >>>>>
> >>>>> generic_identify already re-fetches a bunch of stuff that's also
> >>>>> set by early_cpu_init for the BSP.
> >>>>
> >>>> This would be an option, but how sure are you that there isn't
> >>>> (going to be) another field with similar properties? We better
> >>>> wouldn't require _everything_ to be re-filled in generic_identify().
> >>>
> >>> So you think generic_identify should call into early_cpu_init, or even
> >>> split the cpuinfo_x86 filling done in early_cpu_init into a non-init
> >>> function that could be called by both generic_identify and
> >>> early_cpu_init?
> >>
> >> No, I think it is quite fine for this to be a two-step process.
> > 
> > But it's not a two step process for all CPUs. It's a two step process
> > for the BSP, that will get it's cpuinfo filled by early_cpu_init
> > first, and then by identify_cpu. OTHO APs will only get the
> > information filled by identify_cpu.
> > 
> > Maybe APs don't care about having x86_cache_alignment correctly set?
> 
> They do care, and the field also isn't left uninitialized. See
> initialize_cpu_data(). Like in many other places we assume full
> symmetry among processors here.

Thanks, I did miss that part. Then I think it's fine to initialize the
struct in recheck_cpu_features to zero. That's likely to make it more
obvious if we somehow miss to update certain featuresets? (as they
would be empty instead of inheriting from boot CPU data).

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Feb 11 12:13:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 12:13:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270483.464785 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIUoC-0005gS-JN; Fri, 11 Feb 2022 12:13:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270483.464785; Fri, 11 Feb 2022 12:13:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIUoC-0005gJ-Fr; Fri, 11 Feb 2022 12:13:52 +0000
Received: by outflank-mailman (input) for mailman id 270483;
 Fri, 11 Feb 2022 12:13:51 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=XOdK=S2=epam.com=prvs=4041dc41fc=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nIUoB-0005gD-3e
 for xen-devel@lists.xenproject.org; Fri, 11 Feb 2022 12:13:51 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 109c6f1f-8b34-11ec-8f75-fffcc8bd4f1a;
 Fri, 11 Feb 2022 13:13:48 +0100 (CET)
Received: from pps.filterd (m0174679.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 21BC8oii018966;
 Fri, 11 Feb 2022 12:13:44 GMT
Received: from eur03-ve1-obe.outbound.protection.outlook.com
 (mail-ve1eur03lp2055.outbound.protection.outlook.com [104.47.9.55])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e5qhvr0yj-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 11 Feb 2022 12:13:44 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by DB7PR03MB4169.eurprd03.prod.outlook.com (2603:10a6:10:20::16) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Fri, 11 Feb
 2022 12:13:39 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::fc4d:4749:5d1:eb73]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::fc4d:4749:5d1:eb73%4]) with mapi id 15.20.4975.015; Fri, 11 Feb 2022
 12:13:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 109c6f1f-8b34-11ec-8f75-fffcc8bd4f1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jgK5VrIWitM6pqfPPF9QBJD7Ui7tIJ1dTe8YzyBuq/Y3Bvy5tedBIvUJ+jNfjR3upsFsDzwVm24SVc1RTexMfqkY1f/hRv8Mw7haEVQ1k86Y8T/Ffk3HEM3oDKwq4wf5rSFAjxy+mGVrOoKTNuhZifGzYs8FUmbbEE6dYvyMLPuSH+4e7AcqvrC8oYTAH2xtZvPfJ6jeM8f6MmrXEXoUg9I/BB0Ll9Vivlfu9iK5kiWRiTRF8nQz7FmDGnL92Vag5hG3s8PY31FltwWQFJVRNaLjwaexXDI6lM4FXPE3nAIW7DS5+cZ95aP1dsBmxAGx9mb8Kq+KueqVjPh3GpOD3A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Z2oDGDdVmBcEEVO3cC0cRgN2Gjv4o4MwjSCJnIdkem0=;
 b=TKgiz5+QLrOE0AyjN2Wd8AUhN069Ed0SbHDELe2VUrznlm6LQ0Zk5frfET7l7a35YxOI8uGqpjof+NV5rBFMo2692BWX060TadsM3U1cavxDO3ZwQwvNfNDVLxzy9WO1M2aXy2Etahku2lZbhPm6SpN+bjvUgS0T2k6qXsRwUNxjHd/U9VzvKpQ7lur/DqHQX0HKkBTWJun6BB/0xrhrFId+ZE3u8CRgIJNuQ775c3o05jpc5IHsemVPshjtBZboz5OM5UpX65nkO9qa2xaq3C0jxyJEKBRmkX7PbgaCGs54Mgp2eYkdsgkcy9xqlmlwBHlt63JRIm6u8lpm+85G6A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Z2oDGDdVmBcEEVO3cC0cRgN2Gjv4o4MwjSCJnIdkem0=;
 b=nwESQ3lQXBbZBfGvtaOMkIj+UgSBKhqtQhWZ1gWDd5CMJ4EKSB8BG0efuzOec9RBSK1XUe+Prri6XY5ckqfGidlniAdKKrNx/e83VfO5kNfUJiG0K8wbZ6FPusColN7RT07/JP1A8zulnCUTWGQzX47ZdHvNTLBj2nakMET7dqDzilMqV3kLZEPpWZ84wPX2JBi1Ce/F7smksPi/SsHyoIz8/svzF3V+tQXFTioeGukRkwCZmyGccSB0RviO3vZ/BwGettacWsNLFg20NTDz1fmRx1JbVfsQNkoDs9/cRNJOjr/S7Ffj6/gkamFe7eGZ/7qiQHbJWYjcaI76ULbvrg==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "jbeulich@suse.com" <jbeulich@suse.com>,
        "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org" <sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH] vpci: introduce per-domain lock to protect vpci structure
Thread-Topic: [PATCH] vpci: introduce per-domain lock to protect vpci
 structure
Thread-Index: AQHYHboQT3cBWYI1/EGunE7hOwop6ayM95MAgAD+qQCAAEaDAIAACWWA
Date: Fri, 11 Feb 2022 12:13:38 +0000
Message-ID: <1dbd0f54-affb-1e67-215c-6e6c8fb8535b@epam.com>
References: <20220209133627.959649-1-andr2000@gmail.com>
 <YgU6Snk8GTytJXZp@Air-de-Roger>
 <c4666570-666e-6680-5ec2-adf1da51ad06@epam.com>
 <YgZLEMW9US9QjjYG@Air-de-Roger>
In-Reply-To: <YgZLEMW9US9QjjYG@Air-de-Roger>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 5fc06c84-e414-4175-dd2c-08d9ed57efa9
x-ms-traffictypediagnostic: DB7PR03MB4169:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <DB7PR03MB41696DE2041FA57A0CA6184AE7309@DB7PR03MB4169.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 FWxnLaFS1+03b8ygznt3B1NUPpmpCwZbmiK8OMGJoPlW058muKIH7x1Mkfs6PtpU1HcFGgScRn6Aw+ZgJuduzaQz8h+iWh2pDgQDZsexKLyiczJ63gd9VHZx71+Zz1QKWgSXX7aGeVqie4cELJHcZ74am8GwmIPlPJOmxiRPbmx991IX1wW/1x6zFW8wIy4VNl7kZWsTopkA7MpqYFJnvIJeu7yhUjmZ+RhkR6AluPyTYJiP6yC2owPO30XtgrpR4Lh92n/JgE2szKzmBoypNYG2cblqFfpoQC0cSlyeuxEJL2M6xxGscBzH+hfajz3x5mQtuQ0I/JyWgd/4HdAew5Ip5xTc7je0zaxiz+H6GrQV19rsUeVLd+NwJ2T9Fm2sbszFiShMuKfmpDEWB3Q1i2zHasaRAHAStQsZDAz3ps6r5ULn1NWeTw6p8J2sA5ndDre0R3H2TUlRlbCZSti1vd0QorsLoyzI4it8FwJ1WyXJPGZ1IMQUJK4DA3mgbVMqSAw9Znhtpy56zgrZ/vniouIWwzDKxLImu4/WH0eU9yw4tlo4UmqXMtJEQ+L9QfefctqYqZHENxLlxCndUV6lJy83mx+c2AI0zM8/5REogllGsvZTaObaFyM0+/0Iqz6OGYRFJYHKAgY1AeHckTmCPhSAG0u+oFFFHa8xTpOzNpAJmcMBElW61mkz9FfvFoFLyQfec8Ps7UXy8uMF2gOdn7V8KC22XaPkp/bdXz3m4bn1cIIaLA/Tt5eSHpME+uisziwrSteGu901mfWq4gjW2EJWIVCZ5i2Td4WXSJTwvIl3gxk5Gi7yE0XLXRgntrW+N91gxFv9DRiG0LvB2P/Pfw==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(55236004)(2616005)(316002)(71200400001)(6512007)(8936002)(54906003)(6506007)(36756003)(38070700005)(53546011)(91956017)(107886003)(966005)(31686004)(6916009)(6486002)(508600001)(64756008)(122000001)(26005)(83380400001)(86362001)(2906002)(66446008)(186003)(31696002)(4326008)(66476007)(66556008)(66946007)(76116006)(8676002)(5660300002)(38100700002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?NmZOYnB4RlM3Smp1a3RDenVFTUNnWndTd0RSQzlMQmZqMloxY3FqQXhsNW9t?=
 =?utf-8?B?Y01JSFVrcTE3TUxOelBDOXJaRllnY2JKd2NyMUo2R09xVUYrSWthN0pRMFk3?=
 =?utf-8?B?ajhPaWdHZlpXMXVUMWxkS09wT1I4bUxucS9aSlQwcklMS1d4MmhDcUVBWHJl?=
 =?utf-8?B?OXdiK1J5V3ozT1hTWURERDhLSDJJT0tyOG1VMkFzem1pbEJPVk1RY21Qd1gz?=
 =?utf-8?B?M1BJSWJobm96N3JyaGdvdk82dGlSNlkvZDF3dGN2SmFrQ0Vlak1oWWVERytw?=
 =?utf-8?B?RHhaY25ZdXVhTUxISFJ1Y3lqSmorUElhRjNpT2thWUVuY1ptRWVYWGx3OTFi?=
 =?utf-8?B?Z1o3bm93WlQxOEFkV1JlT1JLWk1oTGZ0dnZIVUphZTZGNVhTRW5vYXBWcVk1?=
 =?utf-8?B?OE9nRkNLdjJLbVpBVmVWRW10OFI3TEI5ZklJMUk1Ty9NRXBiWU1ZK0RKL05E?=
 =?utf-8?B?d2NmcjI2TFEvZzQzV2UvM29FMjNlWTkyYUxQd2YvNXVoVzByR3Y0TFNNSG95?=
 =?utf-8?B?dEd2aFAyRVN1Tk5sSE9saTJBU2lNWlE4bFJveUVZaFdvMTFoSHhmWUJEWkxa?=
 =?utf-8?B?R1JpbndIZGJML1BKcDRWRlF6cVFMazBQU3dHYUZwN09HS2NtWTQzcXVNc29P?=
 =?utf-8?B?d0Q5OXJXVng1eWhLWFlzQkFTaitrNXhML2tiZGExY0E0R0FKMFBKdkVmMGxw?=
 =?utf-8?B?bVFCanJySDgxN2EwMmdTZUlhQ0NqT0tvVmF6Wi8rWStuRWpsalA5U3JucjVp?=
 =?utf-8?B?M3c4dE5tSjNlNmhzR1ZJTDlaa2pkWGI5Z2JXdGdJbzhDUDRXQ0l0OGw1UXVo?=
 =?utf-8?B?VWxPc1FqRzhJZ0lBZ3dVMlUwK2trUmZyMk5SbEliRDkzc1hUVzlFQ2V1Z1M1?=
 =?utf-8?B?QWtZS0hIRVh3WjRYbnZkNGNKUjJBN28xRStzY01iUjZ3VkdKSDNjUVZuTXk1?=
 =?utf-8?B?eS84TmJmSXZDMUUvZ2hESktrSE40WGNwTEh4VS95M3JHMGVOcXV4aEJ0TzVB?=
 =?utf-8?B?NFVScjNrNklqS2FlVEoyYkRYUk51ZGhFWUZNZlBIenBqNyszczViRG1jV1Ew?=
 =?utf-8?B?L0dJMU5BdWllUUJ0N3B3WlV1VEwyNHE2THIvU2p2dCthNjcyNjFwelE0TDdZ?=
 =?utf-8?B?UW9XVHAxZFJBWE5Ub0lQS2oxRm5SZG54amk0c1B0WHZweldRcVpTRWR5a1kw?=
 =?utf-8?B?TlJVSU4yaGttMTVRa0h4K3JvM3F5NWdiQTRhZ043TW9FbEt6R3RvaThYNjcw?=
 =?utf-8?B?VTg4K01kVzBBQ0FhZkpZdEI3UTNwN1AwdDcxeEV2T0pJV3g3QmhFWGdlUlBi?=
 =?utf-8?B?ZkYweW9YdS8xTzRCbENEdVBvdERyVC9VR01ja3B5MW85RzFDN1JuT3JEOENh?=
 =?utf-8?B?S29Hc3FQdkRPajNVMUsza2NJMFFnSUVqZmVVN0xOUTZSbG9JMWFiaWNoOWVp?=
 =?utf-8?B?RFFqN3Uyc29nZ0xuMXc4L3VNQTBGZmpSdUNyTnhEVFAyN0tqMHJUMllaQjRX?=
 =?utf-8?B?aEd5cWZYaml3K0tZdVR1U2YycThsY3JXYUdSUkFSSlcvbndYL2JCWWNuTk0w?=
 =?utf-8?B?ZlZhdXU2VTlBYnpkTXYrWUV1OU0rWjRtMk5GajNFR1o1eVl3dklCQ0ZscUFo?=
 =?utf-8?B?enN0R0diMkMwQ0Q0NHFzZ2VYZ3BvcXZOeWh6SVZiTlRHa3VVZEN0Sy8xY3NL?=
 =?utf-8?B?OUhmVUhnYzhTbTRpYU9aL0p6Y3dwQkR0bmZZTS9tK0FXZy9VR0piMy9QdnM4?=
 =?utf-8?B?ZC9aT092SXpQaUQ5aGZnaTZ0VW1Pekd1TjZyckVXREJPcmhOK3VVcjR4azA3?=
 =?utf-8?B?cm1pa2xJcE1VQnpET0VFbGl1ZVdxQkh6NTZvVlpYdHVtanJMZmtTc2FsdTVh?=
 =?utf-8?B?NldEVld4WC9lRUMvV3Bteng2WEl5cGJqOTVLRURWQ0ZaTUxOSFJWWkFvemVw?=
 =?utf-8?B?YjFFVERHMEc4S1cxRHdsTHlSMUg2VWorOGx3dE9OOWsrM0FCQWNVSmN6aS90?=
 =?utf-8?B?S0xZVE1IQnN6KzRNTnBIU3FqN1ZkTC9xYTRBcFlQVndDUjNUVGJsTGVsN2U4?=
 =?utf-8?B?WWdSbXRFeEIwUkpTaFZrNkVua3hYaCtZZUh3WUtpYmQzeW5XeE5rRjhvZURu?=
 =?utf-8?B?SWlOMGJINlMwMVJTTHhOVGdmeno0Tmg2cEJvU2xMeW9ueXlKWnF3V0hrc2RE?=
 =?utf-8?B?RGNZR0NQQVE1dS9HL1EzRExjV1dWWlovRk5nZ21zL1VDTDYyeFZNNUI1QUlI?=
 =?utf-8?B?UWRYZForSzZEcmVFMEcxOHF4YXR1TnhhL2Vza0ZHKzV4RjBxRlQ0ZGJJSXRU?=
 =?utf-8?B?UlhLU3VJeGx0TGgyTzJVWi8raEZ3Qk1GNGQ5OUVPcEZhbC9mR0V6UT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <40B93CFE2C6735408BDC419DC59D1E8C@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5fc06c84-e414-4175-dd2c-08d9ed57efa9
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Feb 2022 12:13:38.6741
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: /71uxsIwXFDrW1EXPSbeduYsPYbCkd6UF0hpvXy9Ptl6ly60PEmerz+LxqIU/J85Rt6k1Q3a+vx6C2y32S4kgc/MxjwzIOPX3bZpQUmprK2TzaB97LIQPVqoS6zgNBq5
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR03MB4169
X-Proofpoint-GUID: mnqGVgUw6xI7PS3DhfZQ1grik_o-oVq9
X-Proofpoint-ORIG-GUID: mnqGVgUw6xI7PS3DhfZQ1grik_o-oVq9
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-11_04,2022-02-11_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0
 suspectscore=0 bulkscore=0 impostorscore=0 malwarescore=0 mlxlogscore=999
 priorityscore=1501 mlxscore=0 adultscore=0 spamscore=0 lowpriorityscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2202110071

DQoNCk9uIDExLjAyLjIyIDEzOjQwLCBSb2dlciBQYXUgTW9ubsOpIHdyb3RlOg0KPiBPbiBGcmks
IEZlYiAxMSwgMjAyMiBhdCAwNzoyNzozOUFNICswMDAwLCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5r
byB3cm90ZToNCj4+IEhpLCBSb2dlciENCj4+DQo+PiBPbiAxMC4wMi4yMiAxODoxNiwgUm9nZXIg
UGF1IE1vbm7DqSB3cm90ZToNCj4+PiBPbiBXZWQsIEZlYiAwOSwgMjAyMiBhdCAwMzozNjoyN1BN
ICswMjAwLCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyB3cm90ZToNCj4+Pj4gRnJvbTogT2xla3Nh
bmRyIEFuZHJ1c2hjaGVua28gPG9sZWtzYW5kcl9hbmRydXNoY2hlbmtvQGVwYW0uY29tPg0KPj4+
Pg0KPj4+PiBJbnRyb2R1Y2UgYSBwZXItZG9tYWluIHJlYWQvd3JpdGUgbG9jayB0byBjaGVjayB3
aGV0aGVyIHZwY2kgaXMgcHJlc2VudCwNCj4+Pj4gc28gd2UgYXJlIHN1cmUgdGhlcmUgYXJlIG5v
IGFjY2Vzc2VzIHRvIHRoZSBjb250ZW50cyBvZiB0aGUgdnBjaSBzdHJ1Y3QNCj4+Pj4gaWYgbm90
LiBUaGlzIGxvY2sgY2FuIGJlIHVzZWQgKGFuZCBpbiBhIGZldyBjYXNlcyBpcyB1c2VkIHJpZ2h0
IGF3YXkpDQo+Pj4+IHNvIHRoYXQgdnBjaSByZW1vdmFsIGNhbiBiZSBwZXJmb3JtZWQgd2hpbGUg
aG9sZGluZyB0aGUgbG9jayBpbiB3cml0ZQ0KPj4+PiBtb2RlLiBQcmV2aW91c2x5IHN1Y2ggcmVt
b3ZhbCBjb3VsZCByYWNlIHdpdGggdnBjaV9yZWFkIGZvciBleGFtcGxlLg0KPj4+IFNhZGx5IHRo
ZXJlJ3Mgc3RpbGwgYSByYWNlIGluIHRoZSB1c2FnZSBvZiBwY2lfZ2V0X3BkZXZfYnlfZG9tYWlu
IHdydA0KPj4+IHBjaV9yZW1vdmVfZGV2aWNlLCBhbmQgbGlrZWx5IHdoZW4gdlBDSSBnZXRzIGFs
c28gdXNlZCBpbg0KPj4+IHtkZX1hc3NpZ25fZGV2aWNlIEkgdGhpbmsuDQo+PiBZZXMsIHRoaXMg
aXMgaW5kZWVkIGFuIGlzc3VlLCBidXQgSSB3YXMgbm90IHRyeWluZyB0byBzb2x2ZSBpdCBpbg0K
Pj4gY29udGV4dCBvZiB2UENJIGxvY2tpbmcgeWV0LiBJIHRoaW5rIHdlIHNob3VsZCBkaXNjdXNz
IGhvdyBkbw0KPj4gd2UgYXBwcm9hY2ggcGRldiBsb2NraW5nLCBzbyBJIGNhbiBjcmVhdGUgYSBw
YXRjaCBmb3IgdGhhdC4NCj4+IHRoYXQgYmVpbmcgc2FpZCwgSSB3b3VsZCBsaWtlIG5vdCB0byBz
b2x2ZSBwZGV2IGluwqAgdGhpcyBwYXRjaCB5ZXQNCj4+DQo+PiAuLi5JIGRvIHVuZGVyc3RhbmQg
d2UgZG8gd2FudCB0byBhdm9pZCB0aGF0LCBidXQgYXQgdGhlIG1vbWVudA0KPj4gYSBzaW5nbGUg
cmVsaWFibGUgd2F5IGZvciBtYWtpbmcgc3VyZSBwZGV2IGlzIGFsaXZlIHNlZW1zIHRvDQo+PiBi
ZSBwY2lkZXZzX2xvY2suLi4uDQo+IEkgdGhpbmsgd2Ugd2lsbCBuZWVkIHRvIG1ha2UgcGNpZGV2
c19sb2NrIGEgcndsb2NrIGFuZCB0YWtlIGl0IGluIHJlYWQNCj4gbW9kZSBmb3IgcGNpX2dldF9w
ZGV2X2J5X2RvbWFpbi4NCj4NCj4gV2UgZGlkbid0IGhhdmUgdGhpcyBzY2VuYXJpbyBiZWZvcmUg
d2hlcmUgUENJIGVtdWxhdGlvbiBpcyBkb25lIGluIHRoZQ0KPiBoeXBlcnZpc29yLCBhbmQgaGVu
Y2UgdGhlIGxvY2tpbmcgYXJvdW5kIHRob3NlIGRhdGEgc3RydWN0dXJlcyBoYXMgbm90DQo+IGJl
ZW4gZGVzaWduZWQgZm9yIHRob3NlIHVzZS1jYXNlcy4NClllcywgSSBkbyB1bmRlcnN0YW5kIHRo
YXQuDQpJIGhvcGUgcGNpZGV2cyBsb2NrIG1vdmUgdG8gcndsb2NrIGNhbiBiZSBkb25lIGFzIGEg
c2VwYXJhdGUNCnBhdGNoLiBXaGlsZSB0aGlzIGlzIG5vdCBkb25lLCBkbyB5b3UgdGhpbmsgd2Ug
Y2FuIHByb2NlZWQgd2l0aA0KdlBDSSBzZXJpZXMgYW5kIHBjaWRldnMgbG9ja2luZyByZS13b3Jr
IGJlaW5nIGRvbmUgYWZ0ZXI/DQoNCj4NCj4+Pj4gMS4gUGVyLWRvbWFpbidzIHZwY2lfcndsb2Nr
IGlzIHVzZWQgdG8gcHJvdGVjdCBwZGV2LT52cGNpIHN0cnVjdHVyZQ0KPj4+PiBmcm9tIGJlaW5n
IHJlbW92ZWQuDQo+Pj4+DQo+Pj4+IDIuIFdyaXRpbmcgdGhlIGNvbW1hbmQgcmVnaXN0ZXIgYW5k
IFJPTSBCQVIgcmVnaXN0ZXIgbWF5IHRyaWdnZXINCj4+Pj4gbW9kaWZ5X2JhcnMgdG8gcnVuLCB3
aGljaCBpbiB0dXJuIG1heSBhY2Nlc3MgbXVsdGlwbGUgcGRldnMgd2hpbGUNCj4+Pj4gY2hlY2tp
bmcgZm9yIHRoZSBleGlzdGluZyBCQVIncyBvdmVybGFwLiBUaGUgb3ZlcmxhcHBpbmcgY2hlY2ss
IGlmIGRvbmUNCj4+Pj4gdW5kZXIgdGhlIHJlYWQgbG9jaywgcmVxdWlyZXMgdnBjaS0+bG9jayB0
byBiZSBhY3F1aXJlZCBvbiBib3RoIGRldmljZXMNCj4+Pj4gYmVpbmcgY29tcGFyZWQsIHdoaWNo
IG1heSBwcm9kdWNlIGEgZGVhZGxvY2suIEl0IGlzIG5vdCBwb3NzaWJsZSB0bw0KPj4+PiB1cGdy
YWRlIHJlYWQgbG9jayB0byB3cml0ZSBsb2NrIGluIHN1Y2ggYSBjYXNlLiBTbywgaW4gb3JkZXIg
dG8gcHJldmVudA0KPj4+PiB0aGUgZGVhZGxvY2ssIGNoZWNrIHdoaWNoIHJlZ2lzdGVycyBhcmUg
Z29pbmcgdG8gYmUgd3JpdHRlbiBhbmQgYWNxdWlyZQ0KPj4+PiB0aGUgbG9jayBpbiB0aGUgYXBw
cm9wcmlhdGUgbW9kZSBmcm9tIHRoZSBiZWdpbm5pbmcuDQo+Pj4+DQo+Pj4+IEFsbCBvdGhlciBj
b2RlLCB3aGljaCBkb2Vzbid0IGxlYWQgdG8gcGRldi0+dnBjaSBkZXN0cnVjdGlvbiBhbmQgZG9l
cyBub3QNCj4+Pj4gYWNjZXNzIG11bHRpcGxlIHBkZXZzIGF0IHRoZSBzYW1lIHRpbWUsIGNhbiBz
dGlsbCB1c2UgYSBjb21iaW5hdGlvbiBvZiB0aGUNCj4+Pj4gcmVhZCBsb2NrIGFuZCBwZGV2LT52
cGNpLT5sb2NrLg0KPj4+Pg0KPj4+PiAzLiBPcHRpbWl6ZSBpZiBST00gQkFSIHdyaXRlIGxvY2sg
cmVxdWlyZWQgZGV0ZWN0aW9uIGJ5IGNhY2hpbmcgb2Zmc2V0DQo+Pj4+IG9mIHRoZSBST00gQkFS
IHJlZ2lzdGVyIGluIHZwY2ktPmhlYWRlci0+cm9tX3JlZyB3aGljaCBkZXBlbmRzIG9uDQo+Pj4+
IGhlYWRlcidzIHR5cGUuDQo+Pj4+DQo+Pj4+IDQuIFJlZHVjZSBsb2NrZWQgcmVnaW9uIGluIHZw
Y2lfcmVtb3ZlX2RldmljZSBhcyBpdCBpcyBub3cgcG9zc2libGUNCj4+Pj4gdG8gc2V0IHBkZXYt
PnZwY2kgdG8gTlVMTCBlYXJseSByaWdodCBhZnRlciB0aGUgd3JpdGUgbG9jayBpcyBhY3F1aXJl
ZC4NCj4+Pj4NCj4+Pj4gNS4gUmVkdWNlIGxvY2tlZCByZWdpb24gaW4gdnBjaV9hZGRfaGFuZGxl
cnMgYXMgaXQgaXMgcG9zc2libGUgdG8NCj4+Pj4gaW5pdGlhbGl6ZSBtYW55IG1vcmUgZmllbGRz
IG9mIHRoZSBzdHJ1Y3QgdnBjaSBiZWZvcmUgYXNzaWduaW5nIGl0IHRvDQo+Pj4+IHBkZXYtPnZw
Y2kuDQo+Pj4+DQo+Pj4+IDYuIHZwY2lfe2FkZHxyZW1vdmV9X3JlZ2lzdGVyIGFyZSByZXF1aXJl
ZCB0byBiZSBjYWxsZWQgd2l0aCB0aGUgd3JpdGUgbG9jaw0KPj4+PiBoZWxkLCBidXQgaXQgaXMg
bm90IGZlYXNpYmxlIHRvIGFkZCBhbiBhc3NlcnQgdGhlcmUgYXMgaXQgcmVxdWlyZXMNCj4+Pj4g
c3RydWN0IGRvbWFpbiB0byBiZSBwYXNzZWQgZm9yIHRoYXQuIFNvLCBhZGQgYSBjb21tZW50IGFi
b3V0IHRoaXMgcmVxdWlyZW1lbnQNCj4+Pj4gdG8gdGhlc2UgYW5kIG90aGVyIGZ1bmN0aW9ucyB3
aXRoIHRoZSBlcXVpdmFsZW50IGNvbnN0cmFpbnRzLg0KPj4+Pg0KPj4+PiA3LiBEcm9wIGNvbnN0
IHF1YWxpZmllciB3aGVyZSB0aGUgbmV3IHJ3bG9jayBpcyB1c2VkIGFuZCB0aGlzIGlzIGFwcHJv
cHJpYXRlLg0KPj4+Pg0KPj4+PiA4LiBUaGlzIGlzIGJhc2VkIG9uIHRoZSBkaXNjdXNzaW9uIGF0
IFsxXS4NCj4+Pj4NCj4+Pj4gWzFdIGh0dHBzOi8vdXJsZGVmZW5zZS5jb20vdjMvX19odHRwczov
L2xvcmUua2VybmVsLm9yZy9hbGwvMjAyMjAyMDQwNjM0NTkuNjgwOTYxLTQtYW5kcjIwMDBAZ21h
aWwuY29tL19fOyEhR0ZfMjlkYmNRSVVCUEEhZ09iU3lTek43czZ6U0tyY3BTRWk2dncxOGZSUGxz
MTU3Y3VSb3FxNEtEZDdJY19OdmhfY0ZseVZYUFJwRVdCa0kzOHBnc3Z2ZmckIFtsb3JlWy5da2Vy
bmVsWy5db3JnXQ0KPj4+Pg0KPj4+PiBTdWdnZXN0ZWQtYnk6IFJvZ2VyIFBhdSBNb25uw6kgPHJv
Z2VyLnBhdUBjaXRyaXguY29tPg0KPj4+PiBTdWdnZXN0ZWQtYnk6IEphbiBCZXVsaWNoIDxqYmV1
bGljaEBzdXNlLmNvbT4NCj4+Pj4gU2lnbmVkLW9mZi1ieTogT2xla3NhbmRyIEFuZHJ1c2hjaGVu
a28gPG9sZWtzYW5kcl9hbmRydXNoY2hlbmtvQGVwYW0uY29tPg0KPj4+Pg0KPj4+PiAtLS0NCj4+
Pj4gVGhpcyB3YXMgY2hlY2tlZCBvbiB4ODY6IHdpdGggYW5kIHdpdGhvdXQgUFZIIERvbTAuDQo+
Pj4+IC0tLQ0KPj4+PiAgICB4ZW4vYXJjaC94ODYvaHZtL3Ztc2kuYyAgIHwgICAyICsNCj4+Pj4g
ICAgeGVuL2NvbW1vbi9kb21haW4uYyAgICAgICB8ICAgMyArDQo+Pj4+ICAgIHhlbi9kcml2ZXJz
L3ZwY2kvaGVhZGVyLmMgfCAgIDggKysrDQo+Pj4+ICAgIHhlbi9kcml2ZXJzL3ZwY2kvbXNpLmMg
ICAgfCAgIDggKystDQo+Pj4+ICAgIHhlbi9kcml2ZXJzL3ZwY2kvbXNpeC5jICAgfCAgNDAgKysr
KysrKysrKystLQ0KPj4+PiAgICB4ZW4vZHJpdmVycy92cGNpL3ZwY2kuYyAgIHwgMTE0ICsrKysr
KysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tDQo+Pj4+ICAgIHhlbi9pbmNsdWRlL3hl
bi9zY2hlZC5oICAgfCAgIDMgKw0KPj4+PiAgICB4ZW4vaW5jbHVkZS94ZW4vdnBjaS5oICAgIHwg
ICAyICsNCj4+Pj4gICAgOCBmaWxlcyBjaGFuZ2VkLCAxNDYgaW5zZXJ0aW9ucygrKSwgMzQgZGVs
ZXRpb25zKC0pDQo+Pj4+DQo+Pj4+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC94ODYvaHZtL3Ztc2ku
YyBiL3hlbi9hcmNoL3g4Ni9odm0vdm1zaS5jDQo+Pj4+IGluZGV4IDEzZTJhMTkwYjQzOS4uMzUx
Y2I5NjhhNDIzIDEwMDY0NA0KPj4+PiAtLS0gYS94ZW4vYXJjaC94ODYvaHZtL3Ztc2kuYw0KPj4+
PiArKysgYi94ZW4vYXJjaC94ODYvaHZtL3Ztc2kuYw0KPj4+PiBAQCAtODkzLDYgKzg5Myw4IEBA
IGludCB2cGNpX21zaXhfYXJjaF9wcmludChjb25zdCBzdHJ1Y3QgdnBjaV9tc2l4ICptc2l4KQ0K
Pj4+PiAgICB7DQo+Pj4+ICAgICAgICB1bnNpZ25lZCBpbnQgaTsNCj4+Pj4gICAgDQo+Pj4+ICsg
ICAgQVNTRVJUKCEhcndfaXNfbG9ja2VkKCZtc2l4LT5wZGV2LT5kb21haW4tPnZwY2lfcndsb2Nr
KSk7DQo+Pj4gICAgICAgICAgICAgICAgIF4gbm8gbmVlZCBmb3IgdGhlIGRvdWJsZSBuZWdhdGlv
bi4NCj4+IE9rLCB3aWxsIHVwZGF0ZSBhbGwgYXNzZXJ0cyB3aGljaCB1c2UgISENCj4+PiBBbHNv
IHRoaXMgYXNzZXJ0cyB0aGF0IHRoZSBsb2NrIGlzIHRha2VuLCBidXQgY291bGQgYmUgYnkgYSBk
aWZmZXJlbnQNCj4+PiBwQ1BVLiAgSSBndWVzcyBpdCdzIGJldHRlciB0aGFuIG5vdGhpbmcuDQo+
PiBGYWlyIGVub3VnaC4gRG8geW91IHN0aWxsIHdhbnQgdGhlIGFzc2VydHMgb3Igc2hvdWxkIEkg
cmVtb3ZlIHRoZW0/DQo+IExpa2VseSBmaW5lIHRvIGxlYXZlIHRoZW0uDQpPaw0KPg0KPj4+PiAr
DQo+Pj4+ICAgICAgICBmb3IgKCBpID0gMDsgaSA8IG1zaXgtPm1heF9lbnRyaWVzOyBpKysgKQ0K
Pj4+PiAgICAgICAgew0KPj4+PiAgICAgICAgICAgIGNvbnN0IHN0cnVjdCB2cGNpX21zaXhfZW50
cnkgKmVudHJ5ID0gJm1zaXgtPmVudHJpZXNbaV07DQo+Pj4gU2luY2UgdGhpcyBmdW5jdGlvbiBp
cyBub3cgY2FsbGVkIHdpdGggdGhlIHBlci1kb21haW4gcndsb2NrIHJlYWQNCj4+PiBsb2NrZWQg
aXQncyBsaWtlbHkgbm90IGFwcHJvcHJpYXRlIHRvIGNhbGwgcHJvY2Vzc19wZW5kaW5nX3NvZnRp
cnFzDQo+Pj4gd2hpbGUgaG9sZGluZyBzdWNoIGxvY2sgKGNoZWNrIGJlbG93KS4NCj4+IFlvdSBh
cmUgcmlnaHQsIGFzIGl0IGlzIHBvc3NpYmxlIHRoYXQ6DQo+Pg0KPj4gcHJvY2Vzc19wZW5kaW5n
X3NvZnRpcnFzIC0+IHZwY2lfcHJvY2Vzc19wZW5kaW5nIC0+IHJlYWRfbG9jaw0KPj4NCj4+IEV2
ZW4gbW9yZSwgdnBjaV9wcm9jZXNzX3BlbmRpbmcgbWF5IGFsc28NCj4+DQo+PiByZWFkX3VubG9j
ayAtPiB2cGNpX3JlbW92ZV9kZXZpY2UgLT4gd3JpdGVfbG9jaw0KPj4NCj4+IGluIGl0cyBlcnJv
ciBwYXRoLiBTbywgYW55IGludm9jYXRpb24gb2YgcHJvY2Vzc19wZW5kaW5nX3NvZnRpcnFzDQo+
PiBtdXN0IG5vdCBob2xkIGQtPnZwY2lfcndsb2NrIGF0IGxlYXN0Lg0KPj4NCj4+IEFuZCBhbHNv
IHdlIG5lZWQgdG8gY2hlY2sgdGhhdCBwZGV2LT52cGNpIHdhcyBub3QgcmVtb3ZlZA0KPj4gaW4g
YmV0d2VlbiBvciAqcmUtY3JlYXRlZCoNCj4+PiBXZSB3aWxsIGxpa2VseSBuZWVkIHRvIHJlLWl0
ZXJhdGUgb3ZlciB0aGUgbGlzdCBvZiBwZGV2cyBhc3NpZ25lZCB0bw0KPj4+IHRoZSBkb21haW4g
YW5kIGFzc2VydCB0aGF0IHRoZSBwZGV2IGlzIHN0aWxsIGFzc2lnbmVkIHRvIHRoZSBzYW1lDQo+
Pj4gZG9tYWluLg0KPj4gU28sIGRvIHlvdSBtZWFuIGEgcGF0dGVybiBsaWtlIHRoZSBiZWxvdyBz
aG91bGQgYmUgdXNlZCBhdCBhbGwNCj4+IHBsYWNlcyB3aGVyZSB3ZSBuZWVkIHRvIGNhbGwgcHJv
Y2Vzc19wZW5kaW5nX3NvZnRpcnFzPw0KPj4NCj4+IHJlYWRfdW5sb2NrDQo+PiBwcm9jZXNzX3Bl
bmRpbmdfc29mdGlycXMNCj4+IHJlYWRfbG9jaw0KPj4gcGRldiA9IHBjaV9nZXRfcGRldl9ieV9k
b21haW4oZCwgc2JkZi5zZWcsIHNiZGYuYnVzLCBzYmRmLmRldmZuKTsNCj4+IGlmICggcGRldiAm
JiBwZGV2LT52cGNpICYmIGlzX3RoZV9zYW1lX3ZwY2kocGRldi0+dnBjaSkgKQ0KPj4gPGNvbnRp
bnVlIHByb2Nlc3Npbmc+DQo+IFNvbWV0aGluZyBhbG9uZyB0aG9zZSBsaW5lcy4gWW91IGxpa2Vs
eSBuZWVkIHRvIGNvbnRpbnVlIGl0ZXJhdGUgdXNpbmcNCj4gZm9yX2VhY2hfcGRldi4NCkknbGwg
dHJ5IHRvIHBsYXkgYXJvdW5kIGl0IGFuZCBzZWUgd2hhdCB3aWxsIGl0IGxvb2sgbGlrZQ0KPg0K
Pj4+PiArew0KPj4+PiArICAgIC8qDQo+Pj4+ICsgICAgICogV3JpdGluZyB0aGUgY29tbWFuZCBy
ZWdpc3RlciBhbmQgUk9NIEJBUiByZWdpc3RlciBtYXkgdHJpZ2dlcg0KPj4+PiArICAgICAqIG1v
ZGlmeV9iYXJzIHRvIHJ1biB3aGljaCBpbiB0dXJuIG1heSBhY2Nlc3MgbXVsdGlwbGUgcGRldnMg
d2hpbGUNCj4+Pj4gKyAgICAgKiBjaGVja2luZyBmb3IgdGhlIGV4aXN0aW5nIEJBUidzIG92ZXJs
YXAuIFRoZSBvdmVybGFwcGluZyBjaGVjaywgaWYgZG9uZQ0KPj4+PiArICAgICAqIHVuZGVyIHRo
ZSByZWFkIGxvY2ssIHJlcXVpcmVzIHZwY2ktPmxvY2sgdG8gYmUgYWNxdWlyZWQgb24gYm90aCBk
ZXZpY2VzDQo+Pj4+ICsgICAgICogYmVpbmcgY29tcGFyZWQsIHdoaWNoIG1heSBwcm9kdWNlIGEg
ZGVhZGxvY2suIEl0IGlzIG5vdCBwb3NzaWJsZSB0bw0KPj4+PiArICAgICAqIHVwZ3JhZGUgcmVh
ZCBsb2NrIHRvIHdyaXRlIGxvY2sgaW4gc3VjaCBhIGNhc2UuIFNvLCBpbiBvcmRlciB0byBwcmV2
ZW50DQo+Pj4+ICsgICAgICogdGhlIGRlYWRsb2NrLCBjaGVjayB3aGljaCByZWdpc3RlcnMgYXJl
IGdvaW5nIHRvIGJlIHdyaXR0ZW4gYW5kIGFjcXVpcmUNCj4+Pj4gKyAgICAgKiB0aGUgbG9jayBp
biB0aGUgYXBwcm9wcmlhdGUgbW9kZSBmcm9tIHRoZSBiZWdpbm5pbmcuDQo+Pj4+ICsgICAgICov
DQo+Pj4+ICsgICAgaWYgKCAhdnBjaV9vZmZzZXRfY21wKHN0YXJ0LCBzaXplLCBQQ0lfQ09NTUFO
RCwgMikgKQ0KPj4+PiArICAgICAgICByZXR1cm4gdHJ1ZTsNCj4+Pj4gKw0KPj4+PiArICAgIGlm
ICggIXZwY2lfb2Zmc2V0X2NtcChzdGFydCwgc2l6ZSwgcGRldi0+dnBjaS0+aGVhZGVyLnJvbV9y
ZWcsIDQpICkNCj4+PiBObyBuZWVkIGZvciB0aGUgY29tcGFyaXNvbiBpZiByb21fcmVnIGlzIHVu
c2V0LiBBbHNvIHlvdSBjYW4gT1IgYm90aA0KPj4+IGNvbmRpdGlvbnMgaW50byBhIHNpbmdsZSBp
Zi4NCj4+IElmIHdlIG9wZW4gY29kZSB2cGNpX29mZnNldF9jbXAgd2l0aCBhIHNpbmdsZSBpZiBh
bGwgdGhpcyBpcyBnb2luZw0KPj4gdG8gYmUgYSBiaXQgY2x1bXN5Og0KPj4NCj4+ICAgwqDCoMKg
IGlmICggcjFfb2Zmc2V0IDwgcjJfb2Zmc2V0ICsgcjJfc2l6ZSAmJg0KPj4gICDCoMKgwqDCoMKg
wqDCoMKgIHIyX29mZnNldCA8IHIxX29mZnNldCArIHIxX3NpemUgKQ0KPj4gICDCoMKgwqDCoMKg
wqDCoCByZXR1cm4gMDsNCj4+IFRoaXMgaXMgYSBzaW5nbGUgY2hlY2suDQo+PiBOb3cgd2UgbmVl
ZCB0byBjaGVjayB0d28gcmVnaXN0ZXJzIHdpdGggdGhlIGNvZGUgYWJvdmUgYW5kDQo+PiBhbHNv
IGNoZWNrIHRoYXQgcGRldi0+dnBjaS0+aGVhZGVyLnJvbV9yZWcgIT0gMA0KPj4NCj4+IEkgdGhp
bmsgaXQgd291bGQgYmUgbW9yZSByZWFkYWJsZSBpZiB3ZSBoYXZlIGEgdGlueSBoZWxwZXIgZnVu
Y3Rpb24NCj4+DQo+PiBzdGF0aWMgYm9vbCB2cGNpX29mZnNldF9jbXAodW5zaWduZWQgaW50IHIx
X29mZnNldCwgdW5zaWduZWQgaW50IHIxX3NpemUsDQo+PiAgIMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgdW5zaWduZWQgaW50IHIyX29mZnNldCwg
dW5zaWduZWQgaW50IHIyX3NpemUpDQo+PiB7DQo+PiAgIMKgwqDCoCAvKiBSZXR1cm4gMCBpZiBy
ZWdpc3RlcnMgb3ZlcmxhcC4gKi8NCj4+ICAgwqDCoMKgIGlmICggcjFfb2Zmc2V0IDwgcjJfb2Zm
c2V0ICsgcjJfc2l6ZSAmJg0KPj4gICDCoMKgwqDCoMKgwqDCoMKgIHIyX29mZnNldCA8IHIxX29m
ZnNldCArIHIxX3NpemUgKQ0KPj4gICDCoMKgwqDCoMKgwqDCoCByZXR1cm4gZmFsc2U7DQo+PiAg
IMKgwqDCoCByZXR1cm4gdHJ1ZTsNCj4+IH0NCkRvIHlvdSBtZWFuIHRoaXMgaGVscGVyIHRvIGJl
IGNvbnZlcnRlZCBpbnRvDQpzdGF0aWMgYm9vbCBvdmVybGFwcyh1bnNpZ25lZCBpbnQgcjFfb2Zm
c2V0LCB1bnNpZ25lZCBpbnQgcjFfc2l6ZSwNCiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgdW5zaWduZWQgaW50IHIyX29mZnNldCwgdW5zaWdu
ZWQgaW50IHIyX3NpemUpDQo+Pg0KPj4gU28sIHRoZW4gd2UgY2FuIGhhdmUgc29tZXRoaW5nIGxp
a2UNCj4+DQo+PiBzdGF0aWMgYm9vbCB2cGNpX2hlYWRlcl93cml0ZV9sb2NrKGNvbnN0IHN0cnVj
dCBwY2lfZGV2ICpwZGV2LA0KPj4gICDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB1bnNpZ25lZCBpbnQgc3RhcnQsIHVu
c2lnbmVkIGludCBzaXplKQ0KPj4gew0KPj4gICDCoMKgwqAgaWYgKCAhdnBjaV9vZmZzZXRfY21w
KHN0YXJ0LCBzaXplLCBQQ0lfQ09NTUFORCwgMikgfHwNCj4+ICAgwqDCoMKgwqDCoMKgwqDCoCAo
cGRldi0+dnBjaS0+aGVhZGVyLnJvbV9yZWcgJiYNCj4+ICAgwqDCoMKgwqDCoMKgwqDCoMKgICF2
cGNpX29mZnNldF9jbXAoc3RhcnQsIHNpemUsIHBkZXYtPnZwY2ktPmhlYWRlci5yb21fcmVnLCA0
KSkgKQ0KPj4gICDCoMKgwqDCoMKgwqDCoCByZXR1cm4gdHJ1ZTsNCj4+DQo+PiAgIMKgwqDCoCBy
ZXR1cm4gZmFsc2U7DQo+PiB9DQo+IEp1c3QgY3JlYXRlIGFuICdvdmVybGFwcycgc3RhdGljIGZ1
bmN0aW9uIGluIGhlYWRlci5jLg0KUGxlYXNlIHNlZSBhYm92ZQ0KPg0KPiBUaGFua3MsIFJvZ2Vy
Lg0KVGhhbmsgeW91LA0KT2xla3NhbmRy


From xen-devel-bounces@lists.xenproject.org Fri Feb 11 12:14:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 12:14:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270489.464796 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIUp3-0006DY-TX; Fri, 11 Feb 2022 12:14:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270489.464796; Fri, 11 Feb 2022 12:14:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIUp3-0006DR-QT; Fri, 11 Feb 2022 12:14:45 +0000
Received: by outflank-mailman (input) for mailman id 270489;
 Fri, 11 Feb 2022 12:14:44 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=XOdK=S2=epam.com=prvs=4041dc41fc=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nIUp2-0006CC-IM
 for xen-devel@lists.xenproject.org; Fri, 11 Feb 2022 12:14:44 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 31125c59-8b34-11ec-8eb8-a37418f5ba1a;
 Fri, 11 Feb 2022 13:14:43 +0100 (CET)
Received: from pps.filterd (m0174676.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 21BC8N1q020930;
 Fri, 11 Feb 2022 12:14:39 GMT
Received: from eur05-vi1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2174.outbound.protection.outlook.com [104.47.17.174])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e5qhqr1cc-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 11 Feb 2022 12:14:39 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by DB6PR0302MB2727.eurprd03.prod.outlook.com (2603:10a6:4:ae::7) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Fri, 11 Feb
 2022 12:14:35 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::fc4d:4749:5d1:eb73]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::fc4d:4749:5d1:eb73%4]) with mapi id 15.20.4975.015; Fri, 11 Feb 2022
 12:14:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 31125c59-8b34-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Fv26pfbdpMOnRE3T7wYassSTmzd5cBZfKnQ8tDDp/PM2aI80uubhN5VxCN8RKtInIgSEWVyrJh+NRhjE35MwCkShQjiki0hoDFXwTWf7IqC3peMxjglOiIhuzXKD/6hVksplTZYyz6TrvY64YLCiEPs/a3w7CmLLDkTPEquQqJALliqp6xUA/1XlkF3VeKwdpJEj7AzuevR47B3nLNNreSyzOyjiRjnJUctFu4Bx4zkwSGzXZCgRc4jusshQ3wP5ae1xwa+VE2EnBGB9dXw3O/3+3v4SOWdazdk96HNFtoRHfh6dfL0RY5H+ss2CEkCj3iQ+GN4UYfzvZRYqYx9Upg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ElQ75QBlI0Kxwoeo9HL4MsI7cdTdXqwa9XEr14uRJsw=;
 b=Dvd5Rss8brRYW8m5wc2Aa2gZLQoioxBKuHqUzEd+4NsKJQGijTra5Rgbdl9nNKPFS2oI/uEedxoJSRAlSKTplxq7lFivm6briD8JkOofhAxy6++XcAvszM6eZu5E3E4QhfnV+6/JQitWjKBmApBi3oL84LdMbpGDTPmv9KK7wWzC7iYDUBHWMR1TCWVRPwXNB+P4u3WHoFzRmPT5MlVk3B9xdqnWkGU+zE7gTRgiDYsD9kJwtyockZatCMQQsm7q4mWbZi7dwjZr38I6It9eriza5roFLyYs3+WjHQG23WaIGmqRbnHFGnnjIe5a3MCZIMSYH0sNnIh/PuPP+KFDzg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ElQ75QBlI0Kxwoeo9HL4MsI7cdTdXqwa9XEr14uRJsw=;
 b=qXiXz6UTz7LdMRMvMaQ+HRUjEcabkU6hkRIplIxi1qIf/o8u7Rb3MccWOUH4wolKsXuJtyo9Viv3hWjXfz/6ed3oPACgTPmaWSvK3tS8JfU7Zx+1hJeqi3LbbK3bbFANW+GQx++tIm64Nom5jH1YQuJuZJnAsd7mHuarahb4r4e8vNm50JteAWdnDZc0iVbB8knJsViZgCsDrH6eaDrAxMoFjUq0JfOiNHi6nhf8CtLmpFE1GqeRrVe+Kb2j6P4atAxYNy6v0OpXMFZapwUgzwRZ7xpJZTwtO7fzERfwQbkk0SK2JQmm03Z9tQrqdN3HlEpfu8P0fGQfzkjlJxI+dw==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "jbeulich@suse.com" <jbeulich@suse.com>,
        "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org" <sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH] vpci: introduce per-domain lock to protect vpci structure
Thread-Topic: [PATCH] vpci: introduce per-domain lock to protect vpci
 structure
Thread-Index: AQHYHboQT3cBWYI1/EGunE7hOwop6ayM95MAgAEU1ACAADOqgIAABlcA
Date: Fri, 11 Feb 2022 12:14:35 +0000
Message-ID: <5e3119c5-0f0d-43c7-064b-61ba247832b1@epam.com>
References: <20220209133627.959649-1-andr2000@gmail.com>
 <YgU6Snk8GTytJXZp@Air-de-Roger>
 <878371dd-4269-6e44-4e73-344a74a04a84@epam.com>
 <YgZN2acOL5B+PYF5@Air-de-Roger>
In-Reply-To: <YgZN2acOL5B+PYF5@Air-de-Roger>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: c030b411-e84b-4170-2576-08d9ed581133
x-ms-traffictypediagnostic: DB6PR0302MB2727:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <DB6PR0302MB2727E422077242FADA2066D6E7309@DB6PR0302MB2727.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 GN08JvxCbW1KRTWSp15Htc1h4SuVnySd1TawJux7/JssJq1XLAoSEu14trkVhc+/wb6moFXsoWpJ3+CAi+woC3prBnTDBF+cSZaCWwKPVNuOW/CYfDLJBrWNlTmwdcyqMKHjWwnZ+FlUWn++cdxEeF3CT5K2qQEtJV2K8NfRpn3IjlZD7YgoyaX7RDbahR27UOYIuHx0G+shOVi23pTUMbZNDxqsL4o+lTMi03P9i2EXKfNRqnQo4xGg2jQBqXCldf6PH6P8lOk4pxYZswjsNZQTgNFAT4/o/9GpImhXEsJbKIdPaMfWZOp4VmRsF8q6GASTBGEg+fSR9WNlRrsti9kdRKVftFpp1yq32BOlxeSAt6JN1MFWnkVXYaR4rXvP/2rqYIGYPtDyJZuZoSHsXou/KmONFPO3xwh6B5JqYN0x/HHfiyqEVWJGnRUdN7Jgq2SjuVzLVpfShKnUW8v1ln/bQl5/JRuaFgQbdrnY+eM8WKMFzJJ1AdEMSNOkfrCHCodOHQxcg61Hd+l8pd/96HyC+6E46EXD//r5SCLit9IWBu+vEkFvXYTanu5horjlTAXdRejTn0o4kwp7x0L4jBxNikud9PIZtYMXJ2K+YMqfoWBMyt9+nZngCwak/SqXjtFV1P1CyFR8J7K9FBp5bx3tw0I1JoyWD9V6C9Kdo/xMPbOzsAxQcUnk92Tu0AxgjKg0XVYWRslRoN4r40G0eF4qObn8HKN/3OPtwLm8RP/3Vv74IbKc1N0MmWOOMl2I
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(8676002)(8936002)(6506007)(4326008)(76116006)(6512007)(66946007)(71200400001)(6486002)(66446008)(31696002)(86362001)(53546011)(38100700002)(66556008)(508600001)(55236004)(54906003)(6916009)(122000001)(316002)(66476007)(91956017)(64756008)(36756003)(5660300002)(186003)(38070700005)(31686004)(2906002)(2616005)(26005)(107886003)(83380400001)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?R20rNE5IZ2J6L0xMUXNiU2JJVk40VnlQQzAzenIzeFNvaWV2MkEyM0FBeTBx?=
 =?utf-8?B?WHlMZTJxRXQ2U3BLeWJoejFzL3VQd0tUZ1YyakYvVEU0MXhTbllDdGVsVWZ2?=
 =?utf-8?B?R2xMQWwzOXhxSDMxdUd2cHQxbVRITTFaZzhrd3EwOHNmOEtaWVlZd2hWN2dw?=
 =?utf-8?B?NzlXdlFMVVFvOU5aNlB0OEZHdjhmdWpucjJKOG4yNEJxWkZBalpRNjh4WEMr?=
 =?utf-8?B?Rmtqb2VPb05uQnhCZzFxU2hUQThQbVgwdHg5VHNiL2lJRmlJSElLRE1uQmlC?=
 =?utf-8?B?a0duQW52TWRsRENTeVBzK0tPcW5ZSjRZMGlsMmtBZ25zYXJxeU9yQUZMMERx?=
 =?utf-8?B?Nm1XL1ZQVmtUNyt2UUlrcE1zbCt6UC9zcFBEYmVjbGpsaUVzZFJmNVVRLzg3?=
 =?utf-8?B?UkFUQVhhRDZnNlpLZklrRUcxY1RQZHdhMW9WdWYwbUJjWDBpMVVORWFtd3dT?=
 =?utf-8?B?VkpoTlV5OEQydy9RVmxndzFORjdkc2QwTUxWTmFVVXRKZGpUN0kxNTdkRXpS?=
 =?utf-8?B?bmovdWVpU3ZqWktwVk5rWkwwT01Ja0RZTGNDMjhzTlN6eTBDSWw2dU1qTWlS?=
 =?utf-8?B?MkxuajUyTlhvT08vQmQzb0FaRCtRVUtIQ241dVRkSWNpYTdib3k0YjM3aksx?=
 =?utf-8?B?S0FnMjRlYTJtbldBZEhUbVp5WGdUYmhGMUVxZmdoeW1yR0tXNWZ6ZE1rdHZl?=
 =?utf-8?B?N2k0RFplRFZSR1duZnNkdVRDNDk2KzBiUG9hMGZ5MFRFUFRJVDNQaDdFblVB?=
 =?utf-8?B?bFBiS0Q0K3dOakdybUxudndIRGJDbGthdG5JYWxzR1lMOTcrbytUUE1kK0RG?=
 =?utf-8?B?ZnFxVXhpYk10U0JjVWt2SHB5bmVpTHhIUVkwWCtjN1pTWTE2Q2VtVU9DWGlz?=
 =?utf-8?B?OFlPMy9RZ2FDNm9tR2NZZ1g0QW11Nys4bkhrNlRpd1J5aFphelFNeFFva2Rp?=
 =?utf-8?B?dU1VRE5XSVIzdVZ5ZTA1NEg2dnZEc3FoaXJ3RWpibkpNVmFESDhFMW5ZOWhq?=
 =?utf-8?B?L2U1SytwSXdYbldWUzUzcklLbTkvUGdqTHZ6a0lwNEo4a012TWVENFNsY21M?=
 =?utf-8?B?cE5SVDRoV0N1SHVCL1hPSVBpcUdpMUFUaDNyMUlNcTBTR0taMVRvSHpVUUNQ?=
 =?utf-8?B?bEtweGI0Tnl4a0VSR3ZTb2NjTXpuV3hjcVY5Qm9zZVpGK0Raclk1QlhPNzFz?=
 =?utf-8?B?WUMzYnRQejFodlpLSUM4aWptWW9lKy8vOUJCT1lvNXZodkRmWGNValcwL3dS?=
 =?utf-8?B?NkRCVXNJLzFsTzRpYVlwSmpwc3JjTHpQRTFxam9uOUJnMHNYTTlrU0FrVWd5?=
 =?utf-8?B?MnVUNkpJcjRDV1ZvTUUySDI5K3hmNm8ySHlWRWxiaTRxRkJoZ1dMYVkrYkh6?=
 =?utf-8?B?bUJBRXJVaEJSMHNEZzVQQmdmaUlBRVUwRFVDVi80cVI5bGVrcXltcFdHMlJ0?=
 =?utf-8?B?U0ZHSm5raG1mQTBBVFlOK0JXTGJNNndqalZhYjVzL0xNajBFQUxZWGxDd01W?=
 =?utf-8?B?dUFaSHYyRWZzSERMclFGWHo2Z3d6N0pUNVE2dDg2MVRwNUVaUHJxYXQzNkZ0?=
 =?utf-8?B?UUc5c1RJWmVRNjN3VzFOd3lMMzkwUnlLdjhpVjB3K1g5ZjV5ZHJTVXVTbVhX?=
 =?utf-8?B?K1VEVDU5MHRjZUxxam1iWXFDMlE2NWthbTU2NGs1cmRxUExWVlo2cWlham9l?=
 =?utf-8?B?c2lndFBoL2xmRXhONnI3TmU5WFFHZ0ZXQi9EUTJkMitVVWhpNHg5UDJESEpK?=
 =?utf-8?B?YXVOTHAyTFgydHJ0elkvTi9qZ3kwNWQvdWVRbUZBNnBrTXJkSERweTNoTDND?=
 =?utf-8?B?MHFjQU1wMVM5aVkwMVJ6Q0x6aXU0M0NYeWxNam1wZ3N6dnIzTEp4VTBhbE5o?=
 =?utf-8?B?Wm5Xb3M1N0phU0FRTndiZmNKNGpaTkw3MEtCbUNTZ3lWZzBCUTV1T0I2TjVo?=
 =?utf-8?B?b25YdmsvN0FGMkRJOXlLaWR2M1cvN0x5YXVXbkpMVW45NVVxNENUZnVtM25P?=
 =?utf-8?B?b0pPUjhpOTZ2K2R4YWhIMmZKVE5Bb2FtOHJ6VzV6VDB4SkYvZ0dMYWdVQ3NV?=
 =?utf-8?B?RkkvVWFFWFZyWmkxdUp3TGJUWVhYQU1KbnAzMHNPL2tHa3lLSXNaY2JhWm5S?=
 =?utf-8?B?b0pXSzRtMzA3Rmk2eDVvd1Q1OHlWSS9mcEVvaVRia2l0K2VEVm9qZ2hsQ3Fn?=
 =?utf-8?B?d0JqcnFERzJTUUJrcGlTN0VrNGZSRzdtendrSzIyVVhLUlpmR0RiK3FrbHNu?=
 =?utf-8?B?Ukk4dlhSakd1dnZzZ2w2eDRQTUJETWkzaVRzUkwwVkVXZ05QNkI3TlkwN01r?=
 =?utf-8?B?bVZJdzM4QUlPVjdKeGNRUUFUY1ZpWGtmbjN3SnhPOW1HcUt1MWlBUT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <3D5CFE355135764BA064F0FDE594816C@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c030b411-e84b-4170-2576-08d9ed581133
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Feb 2022 12:14:35.0324
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: DwdvSAwfRXusi0jBftn9bmqo/A4PY/lddRe9X8xTzF1+XKMjAb87YJnApTTiDewSrrgkf90RnT9k54CXwdheOYH9lPbrG2bJPM3abhUGQaGXnS/UPMbryov/kO38t4pb
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0302MB2727
X-Proofpoint-GUID: AQZXOoyWw-H5l7U_ruQ3TdkHOqJX3iWZ
X-Proofpoint-ORIG-GUID: AQZXOoyWw-H5l7U_ruQ3TdkHOqJX3iWZ
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-11_04,2022-02-11_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 mlxscore=0
 malwarescore=0 suspectscore=0 adultscore=0 clxscore=1015 bulkscore=0
 mlxlogscore=999 lowpriorityscore=0 priorityscore=1501 spamscore=0
 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202110071

DQoNCk9uIDExLjAyLjIyIDEzOjUxLCBSb2dlciBQYXUgTW9ubsOpIHdyb3RlOg0KPiBPbiBGcmks
IEZlYiAxMSwgMjAyMiBhdCAwODo0Njo1OUFNICswMDAwLCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5r
byB3cm90ZToNCj4+DQo+PiBPbiAxMC4wMi4yMiAxODoxNiwgUm9nZXIgUGF1IE1vbm7DqSB3cm90
ZToNCj4+PiBPbiBXZWQsIEZlYiAwOSwgMjAyMiBhdCAwMzozNjoyN1BNICswMjAwLCBPbGVrc2Fu
ZHIgQW5kcnVzaGNoZW5rbyB3cm90ZToNCj4+Pj4gRnJvbTogT2xla3NhbmRyIEFuZHJ1c2hjaGVu
a28gPG9sZWtzYW5kcl9hbmRydXNoY2hlbmtvQGVwYW0uY29tPg0KPj4+Pg0KPj4+PiBJbnRyb2R1
Y2UgYSBwZXItZG9tYWluIHJlYWQvd3JpdGUgbG9jayB0byBjaGVjayB3aGV0aGVyIHZwY2kgaXMg
cHJlc2VudCwNCj4+Pj4gc28gd2UgYXJlIHN1cmUgdGhlcmUgYXJlIG5vIGFjY2Vzc2VzIHRvIHRo
ZSBjb250ZW50cyBvZiB0aGUgdnBjaSBzdHJ1Y3QNCj4+Pj4gaWYgbm90LiBUaGlzIGxvY2sgY2Fu
IGJlIHVzZWQgKGFuZCBpbiBhIGZldyBjYXNlcyBpcyB1c2VkIHJpZ2h0IGF3YXkpDQo+Pj4+IHNv
IHRoYXQgdnBjaSByZW1vdmFsIGNhbiBiZSBwZXJmb3JtZWQgd2hpbGUgaG9sZGluZyB0aGUgbG9j
ayBpbiB3cml0ZQ0KPj4+PiBtb2RlLiBQcmV2aW91c2x5IHN1Y2ggcmVtb3ZhbCBjb3VsZCByYWNl
IHdpdGggdnBjaV9yZWFkIGZvciBleGFtcGxlLg0KPj4+IFNhZGx5IHRoZXJlJ3Mgc3RpbGwgYSBy
YWNlIGluIHRoZSB1c2FnZSBvZiBwY2lfZ2V0X3BkZXZfYnlfZG9tYWluIHdydA0KPj4+IHBjaV9y
ZW1vdmVfZGV2aWNlLCBhbmQgbGlrZWx5IHdoZW4gdlBDSSBnZXRzIGFsc28gdXNlZCBpbg0KPj4+
IHtkZX1hc3NpZ25fZGV2aWNlIEkgdGhpbmsuDQo+Pj4NCj4+IEhvdyBhYm91dCB0aGUgYmVsb3c/
IEl0IHNlZW1zIHRvIGd1YXJhbnRlZSB0aGF0IHdlIGNhbiBhY2Nlc3MgcGRldg0KPj4gd2l0aG91
dCBpc3N1ZXMgYW5kIHdpdGhvdXQgcmVxdWlyaW5nIHBjaWRldnNfbG9jayB0byBiZSB1c2VkPw0K
PiBIbSwgSSdtIHVuc3VyZSB0aGlzIGlzIGNvcnJlY3QuDQpZZXMsIHdlIG5lZWQgcGNpZGV2cyBh
cyByd2xvY2sgaW4gb3JkZXIgdG8gc29sdmUgdGhpcyByZWxpYWJseS4uLg0KPiAgIEl0J3MgaW4g
Z2VuZXJhbCBhIGJhZCBpZGVhIHRvIHVzZSBhDQo+IHBlci1kb21haW4gbG9jayBhcHByb2FjaCB0
byBwcm90ZWN0IHRoZSBjb25zaXN0ZW5jeSBvZiBlbGVtZW50cyBtb3ZpbmcNCj4gYmV0d2VlbiBk
b21haW5zLg0KPg0KPiBJbiBvcmRlciBmb3IgdGhpcyB0byBiZSBzYWZlIHlvdSB3aWxsIGxpa2Vs
eSBuZWVkIHRvIGhvbGQgYm90aCB0aGUNCj4gc291cmNlIGFuZCB0aGUgZGVzdGluYXRpb24gcGVy
LWRvbWFpbiBsb2NrcywgYW5kIHRoZW4geW91IGNvdWxkIGFsc28NCj4gZ2V0IGludG8gQUJCQSBs
b2NrIGlzc3VlcyB1bmxlc3MgeW91IGFsd2F5cyB0YWtlIHRoZSBsb2NrIGluIHRoZSBzYW1lDQo+
IG9yZGVyLg0KPg0KPiBJIHRoaW5rIGl0J3Mgc2FmZXIgdG8gdXNlIGEgZ2xvYmFsIGxvY2sgaW4g
dGhpcyBjYXNlIChwY2lkZXZzX2xvY2spLg0KPg0KPj4gZGlmZiAtLWdpdCBhL3hlbi9kcml2ZXJz
L3Bhc3N0aHJvdWdoL3BjaS5jIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvcGNpLmMNCj4+IGlu
ZGV4IGU4YjA5ZDc3ZDg4MC4uZmQ0NjRhNThiM2IzIDEwMDY0NA0KPj4gLS0tIGEveGVuL2RyaXZl
cnMvcGFzc3Rocm91Z2gvcGNpLmMNCj4+ICsrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3Bj
aS5jDQo+PiBAQCAtOTM3LDggKzkzNywxNCBAQCBzdGF0aWMgaW50IGRlYXNzaWduX2RldmljZShz
dHJ1Y3QgZG9tYWluICpkLCB1aW50MTZfdCBzZWcsIHVpbnQ4X3QgYnVzLA0KPj4gICDCoMKgwqDC
oCB9DQo+Pg0KPj4gICDCoMKgwqDCoCBkZXZmbiA9IHBkZXYtPmRldmZuOw0KPj4gKyNpZmRlZiBD
T05GSUdfSEFTX1ZQQ0kNCj4+ICvCoMKgwqAgd3JpdGVfbG9jaygmZC0+dnBjaV9yd2xvY2spOw0K
Pj4gKyNlbmRpZg0KPj4gICDCoMKgwqDCoCByZXQgPSBpb21tdV9jYWxsKGhkLT5wbGF0Zm9ybV9v
cHMsIHJlYXNzaWduX2RldmljZSwgZCwgdGFyZ2V0LCBkZXZmbiwNCj4+ICAgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHBjaV90b19kZXYocGRldikpOw0KPj4gKyNp
ZmRlZiBDT05GSUdfSEFTX1ZQQ0kNCj4+ICvCoMKgwqAgd3JpdGVfdW5sb2NrKCZkLT52cGNpX3J3
bG9jayk7DQo+PiArI2VuZGlmDQo+PiAgIMKgwqDCoMKgIGlmICggcmV0ICkNCj4+ICAgwqDCoMKg
wqDCoMKgwqDCoCBnb3RvIG91dDsNCj4+DQo+PiBAQCAtMTQ3NCw2ICsxNDgwLDkgQEAgc3RhdGlj
IGludCBhc3NpZ25fZGV2aWNlKHN0cnVjdCBkb21haW4gKmQsIHUxNiBzZWcsIHU4IGJ1cywgdTgg
ZGV2Zm4sIHUzMiBmbGFnKQ0KPj4gICDCoMKgwqDCoCBjb25zdCBzdHJ1Y3QgZG9tYWluX2lvbW11
ICpoZCA9IGRvbV9pb21tdShkKTsNCj4+ICAgwqDCoMKgwqAgc3RydWN0IHBjaV9kZXYgKnBkZXY7
DQo+PiAgIMKgwqDCoMKgIGludCByYyA9IDA7DQo+PiArI2lmZGVmIENPTkZJR19IQVNfVlBDSQ0K
Pj4gK8KgwqDCoCBzdHJ1Y3QgZG9tYWluICpvbGRfZDsNCj4+ICsjZW5kaWYNCj4+DQo+PiAgIMKg
wqDCoMKgIGlmICggIWlzX2lvbW11X2VuYWJsZWQoZCkgKQ0KPj4gICDCoMKgwqDCoMKgwqDCoMKg
IHJldHVybiAwOw0KPj4gQEAgLTE0ODcsMTUgKzE0OTYsMzQgQEAgc3RhdGljIGludCBhc3NpZ25f
ZGV2aWNlKHN0cnVjdCBkb21haW4gKmQsIHUxNiBzZWcsIHU4IGJ1cywgdTggZGV2Zm4sIHUzMiBm
bGFnKQ0KPj4gICDCoMKgwqDCoCBBU1NFUlQocGRldiAmJiAocGRldi0+ZG9tYWluID09IGhhcmR3
YXJlX2RvbWFpbiB8fA0KPj4gICDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgIHBkZXYtPmRvbWFpbiA9PSBkb21faW8pKTsNCj4+DQo+PiArI2lmZGVmIENPTkZJR19IQVNf
VlBDSQ0KPj4gK8KgwqDCoCAvKiBwZGV2LT5kb21haW4gaXMgZWl0aGVyIGh3ZG9tIG9yIGRvbV9p
by4gV2UgZG8gbm90IHdhbnQgdGhlIGxhdGVyLiAqLw0KPj4gK8KgwqDCoCBvbGRfZCA9IHBkZXYt
PmRvbWFpbiA9PSBoYXJkd2FyZV9kb21haW4gPyBwZGV2LT5kb21haW4gOiBOVUxMOw0KPj4gK8Kg
wqDCoCBpZiAoIG9sZF9kICkNCj4+ICvCoMKgwqDCoMKgwqDCoCB3cml0ZV9sb2NrKCZvbGRfZC0+
dnBjaV9yd2xvY2spOw0KPj4gKyNlbmRpZg0KPj4gKw0KPj4gICDCoMKgwqDCoCByYyA9IHBkZXZf
bXNpeF9hc3NpZ24oZCwgcGRldik7DQo+IEkgZG9uJ3QgdGhpbmsgeW91IG5lZWQgdGhlIHZwY2kg
bG9jayBmb3IgdGhpcyBvcGVyYXRpb24uDQo+DQo+PiAgIMKgwqDCoMKgIGlmICggcmMgKQ0KPj4g
K8KgwqDCoCB7DQo+PiArI2lmZGVmIENPTkZJR19IQVNfVlBDSQ0KPj4gK8KgwqDCoMKgwqDCoMKg
IGlmICggb2xkX2QgKQ0KPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgd3JpdGVfdW5sb2NrKCZv
bGRfZC0+dnBjaV9yd2xvY2spOw0KPj4gKyNlbmRpZg0KPj4gICDCoMKgwqDCoMKgwqDCoMKgIGdv
dG8gZG9uZTsNCj4+ICvCoMKgwqAgfQ0KPj4NCj4+ICAgwqDCoMKgwqAgcGRldi0+ZmF1bHQuY291
bnQgPSAwOw0KPj4NCj4+ICAgwqDCoMKgwqAgaWYgKCAocmMgPSBpb21tdV9jYWxsKGhkLT5wbGF0
Zm9ybV9vcHMsIGFzc2lnbl9kZXZpY2UsIGQsIGRldmZuLA0KPj4gICDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHBjaV90b19kZXYocGRldiksIGZs
YWcpKSApDQo+PiArwqDCoMKgIHsNCj4+ICsjaWZkZWYgQ09ORklHX0hBU19WUENJDQo+PiArwqDC
oMKgwqDCoMKgwqAgaWYgKCBvbGRfZCApDQo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB3cml0
ZV91bmxvY2soJm9sZF9kLT52cGNpX3J3bG9jayk7DQo+PiArI2VuZGlmDQo+IExpa2UgSSd2ZSBt
ZW50aW9uZWQgYWJvdmUsIEknbSB1bnN1cmUgdGhpcyBpcyBjb3JyZWN0LiBZb3UgYXJlIGhvbGRp
bmcNCj4gdGhlIGxvY2sgb2YgdGhlIHByZXZpb3VzIGRvbWFpbiwgYnV0IGF0IHNvbWUgcG9pbnQg
dGhlIGRldmljZSB3aWxsIGJlDQo+IGFzc2lnbmVkIHRvIGEgbmV3IGRvbWFpbiwgc28gdGhhdCBj
aGFuZ2Ugd29uJ3QgYmUgcHJvdGVjdGVkIGJ5IHRoZQ0KPiBsb2NrIG9mIHRoZSBuZXcgZG9tYWlu
Lg0KPg0KPiBUaGFua3MsIFJvZ2VyLg0K


From xen-devel-bounces@lists.xenproject.org Fri Feb 11 12:35:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 12:35:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270499.464807 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIV8l-0000Ef-PF; Fri, 11 Feb 2022 12:35:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270499.464807; Fri, 11 Feb 2022 12:35:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIV8l-0000EY-LE; Fri, 11 Feb 2022 12:35:07 +0000
Received: by outflank-mailman (input) for mailman id 270499;
 Fri, 11 Feb 2022 12:35:07 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=S5m1=S2=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nIV8l-0000ES-38
 for xen-devel@lists.xenproject.org; Fri, 11 Feb 2022 12:35:07 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0992670a-8b37-11ec-8f75-fffcc8bd4f1a;
 Fri, 11 Feb 2022 13:35:05 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0992670a-8b37-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644582905;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=J3dx+gqoJ4Xol3x41MWi11wjGAaBeaeRcnsskeI9gzA=;
  b=ca9iZV39q7EOiDwdiUk8U9Z+HfNE9nC+7DIq+pH7uSkkrxeQY0i2F608
   uzMtYaO79okZmpFVeAGBdAeMAEOQrk2GeTJiZm0Xb/SnaVE2UgknkatwW
   R5sO3+SBuabm1Yk9juRGjfkL00YskclllNkYtC48FjhFWzYl9HOAoK4iC
   4=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: ZyVWNUsjIyujTyo0j7ZVu0Q4zLC7BRZJiRW/lcvOhAoodTd0IU25RuHNKZT62TVsVJv1RV8z3P
 /pVADqLpAD0N6FYruhbJGcOT/bQix0f4gGNhRcg/CqIcaE+VjONTt/aimFxfkeG9jZbwhEvwrQ
 aiFZOEaAiXvrxP3PCu9OGmALnRiMc+e70trFF8xdFDGZIuNIx/jIQ6nuORqt9Xj3KZPPjhAHxz
 iJYVFw8fTU+nffk8cdk4njEHANvysTt2QIdpm0iBjkpaOwAspfJS+N1WYmX3NFVWIX1XjLKvDv
 59kv5zuP1hh7a8y+cVsCVJHk
X-SBRS: 5.1
X-MesageID: 63457667
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:M1/aLKzbnwJ5F36l3FB6t+fuwSrEfRIJ4+MujC+fZmUNrF6WrkUFm
 GcaXGHVaf6KN2r9ctAlaYW/9EgF65Ddm4BlHAZrqyAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAhLeNYYH1500g7wbdg2tcAbeWRWGthh
 /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL
 wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt4B+2
 MgOjaDzdSA4OIrMmrkUUytaCwgraMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr
 6ZBbmlQMFbT3Ipaw5riIgVoru0lINPmI8U0vXZ4wCuCJf0nXYrCU+PB4towMDIY2JsSQKmAO
 ZVxhTxHRTLyfwNEEHMuBp8XovmPi2DyVxFStwfAzUYwyzeKl1EguFT3C/LKfvSaSMMTmVyXz
 krW8mK8DhwEOdi3zTue7mnqluLJhTn8Wo8ZCPu/7PECqF+Zy3EXCRYWfUCmuvT/gUm7M++zM
 GRNpHBo9/JrshX2EJ+tBHVUvUJooDZMVMpNUNUGqz2q26zz4wTED2g2TCZoPYlOWNANeRQm0
 VqAntXMDDNpsaGIRX/1yop4vQ9eKgBOczZcOHZsoR8tpoC6/dpt1k6nosNLTfbt5uAZDw0c1
 NxjQMIWo7wIxfAG2Kyglbwsq2L9/8OZJuLZC+i+Y45E0u+bTNP9D2BLwQKChRqlEGp/ZgPQ1
 JTjs5LAhN3i9bnXyESwrBwlRdlFHcqtPjzGmkJIFJI87Tmr8HPLVdkOvG0jfho2bZxZIGeBj
 KrvVeV5vs470JyCN/EfXm5MI55ykfiI+SrNCpg4keaikrAuLVTarUmClGab3nz3kVhErE3ME
 czzTCpYNl5DUf4P5GPvH481iOZ3rghjlTK7bc2qlHyPjOvBDEN5vJ9YaTNimMhit/jayOgUm
 v4CX/a3J+J3DrGgPHmNrNJ7wJJjBSFTOK0aYvd/L4arCgFnBHsgG7nWx7YgcJZihKNbiqHD+
 XTVZ6OS4AOXaaTvJVrYZ3Z9RqnoWJoj/3s3MTZ1ZQSj2mQ5YJbp56AaLsNlcb4i/e1l7Ph1U
 /haJJnQXqUREmzKq2YHcJ3wjI1+bxD31wiACDWoPWokdJl6Sg2XptK9Jlnz9DMDBzacvNclp
 +HyzRvSRJcOHlwwDMvfZP+14Um2uHwRxLB7U0fSe4EBc0Tw6ol6bSf2i6Zvcc0LLBzCwBqc1
 hqXXkhE9bWc/ddt/YCQ166eroqvH+9vJWZgHjHWveSsKC3X3mu/2oscAuyGSi/QCTHv86K4a
 OQLk/ylaK8bnExHupZXGqpwyf5s/MPmorJXw1g2HHjPaFj3WLpsLmPfgJtKv6xJgLRYpRG3S
 gSE/dwDYeeFP8bsEVgwIgs5b7vciaFIy2eKtfllcl/n4CJX/aacVRQANhaBvyVRMb9pPd532
 uwmosMXt1SyhxdC3gxqVcyIG7Bg9kA9bpg=
IronPort-HdrOrdr: A9a23:RXdOM6loovlfNS/gzPQb+1xuvZLpDfO2imdD5ihNYBxZY6Wkfp
 iV7YkmPNrP+UgssHFJo6HkBEDyewKMyXcV2/hAAV7MZniehILFFvAA0WKm+UybJ8SczJ8U6U
 4DSdkHNDSYNzET5quXjmjZLz9j+qj9zEnBv5aT854Hd3APV0gU1XYeNu/tKDwQeOApP+taKH
 JBjvA37QaISDA7Ytm2DGQCRMjv4+TRkpjrewQLCnccmUSzZAeTmfHH+lWjr1Iju/wm+8ZqzY
 Bp+DaS2oyT99WAjjPM3W7a6Jpb3PPn19t4HcSJzvMYLz394zzYELiID9e50wwdkaWK0hIHgd
 PMqxAvM4BY8HXKZFy4phPrxk3JzCsuw2WK8y7DvVLT5ejCAB4qActIgoxUNjHD7VA7gd162K
 VXm0qEqptsCw/aliiV3amSa/hTrDvonZMeq59Ls5Ufa/pZVFZpl/1ZwKqBKuZZIMr4gLpXZd
 WGQvusr4cLTbtdB0qp8FWHi+bcIkjbJS32M3TrYKSuonhrdUBCvgolLYQk7wg9HbIGOtp5Dr
 f/Q+ZVfEcndL5hUUpCbN1xMvde/QT2MGXx2OX4GyW4KEnSUEi99KIfpo9FoN1CSaZ4vqfasK
 6xIG9liQ==
X-IronPort-AV: E=Sophos;i="5.88,360,1635220800"; 
   d="scan'208";a="63457667"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=lccuYNlv1PqgR4LGdlLrj+jVgyWIflvd2fe45XATOzOHadHfj6f+UFxwPeiGaWg8HXxpfVAi31U2TUTkoRoYv5own5Yn8S5nd6E8VOAOXsJa9j6b4R2+r0r89ho14GkkRRSz8skkEhEgD/9mDs5BqjcsurWJYVUNS3W/kWcbQjNThDU1udeyTJCBlDd9YkzxGueh4FFIfJa65YHgEv629Dg9Z8XfHdh95YmXwraF9pgj4IinegElYe8cSb6Qzd6FCw8lH6FLPYSAC/HI55AxB5hlNP5/pfCY6cfh6zymhq+QdjY1FX18Jp1nuyj9XJH3vXIF1G5IX72aRBlZVNbJGg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=J3dx+gqoJ4Xol3x41MWi11wjGAaBeaeRcnsskeI9gzA=;
 b=FP2leeSZHcjJwdSoxBYmmxLHdy+SQzt6SEHhi1WZy9wcMDXXJNwtb+4b03LlkNY9AOEF67L04EQJjvwMkvg+oE9JVNfjhKUxVBkuj8nYpwnJ4oyHXhNta1pF3w5asItEHCha5ZEu56xvm+V+mU3TZTormTSfnsrIGA0Krslo8AGMFLi9vMC+ELZHioNcaioqNJq+b1oL6oXXw8g6VDUE4pJUok8EKVC3eoe3hqGlkbla/DvEAF7zZuRHZf9ijwwZYIU/NIyQjs0mDMm2190zAbdgRx1XtnQ1T9g8Vnzwguc7wHdrE3VfUwS6qGFpMUVUuqbRjpLObxRVBukN/fJGJw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=J3dx+gqoJ4Xol3x41MWi11wjGAaBeaeRcnsskeI9gzA=;
 b=qr4Lq2x2KQ4+PuBKYIsewb32hM93eE3hM0WE+zv1bJdyejO3jqDpxXmSG7h+OkBKCuTVoZFmxjkksidzI/Rs/HlEUaqVcdbsr58lz1+Px+haEfGBQ0NI7PKwkLqgdEFfh6Th1dQb36KJdQuRCJUULTWHlD+mtdtumDzJ01/TX5Y=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Wei Liu <wl@xen.org>, Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH] x86emul: fix VPBLENDMW with mask and memory operand
Thread-Topic: [PATCH] x86emul: fix VPBLENDMW with mask and memory operand
Thread-Index: AQHYHzffi/wD0570GUy0S5ifa6zkcKyOSRuA
Date: Fri, 11 Feb 2022 12:34:55 +0000
Message-ID: <fb11f488-edc3-3162-4d69-6e2ff6b52f9c@citrix.com>
References: <0d06eaa2-a9b4-5791-e26e-31db0a954827@suse.com>
In-Reply-To: <0d06eaa2-a9b4-5791-e26e-31db0a954827@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: a1e3bb2f-2d87-4bc4-d351-08d9ed5ae8df
x-ms-traffictypediagnostic: BLAPR03MB5457:EE_
x-microsoft-antispam-prvs: <BLAPR03MB545733054B5DE05A208163CBBA309@BLAPR03MB5457.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:6108;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: dtGl146/JibKuYxKORjZ5nJDHRG912nznF5oDcwyYwl56/+I+sYSnqcHOxqM3W/55/is3BjkNwt6B/lkJ9cMy0lIj85VYfyl34Ggbw/6GpDJaIgUNo0kPnE4227GC9moczwQI/xQE5kjzH/CW8cvhGEgpzz44zzXgj79NGbAKB0qJBzOFj6znhs+PLaNIOXHM6poq9OWPQq2TGysLJD4QbB4QAWwSSNi34hVhK7dFOrqaEv2WPQcVL4IhzUVk4wWMHC5kTYQIrTzAJyJRqU2TahV/7Jo1uRbCYXq1BUo3QwBsm+AofQbqFAWBxrkeBnIc5JxgIyKcV+VEan29mSVEWFRqM4MK2UFf3FNrcS4tOSpEO0OqMNozda+DySNU+Y0IN4vmLaUOdU+weKe4zU6uRY8ysUG2GxaQYYulMatw1dgirX7Amu7YbCZiaTe92WCD/b6zxS4iaNx6J5e29v4zAuoBFN9Hoa9XxX0wpSAfmTbW6QHFGX+bTgZ9p6qAkfmrFaJer+ts1Cx02mbPteIZFtqEiyGkB6pE2F/Gvs5qJgga4EhR28WAXufl2kU+sVT+DO7JO3+pgBKCrJw+c1MH2mlniUJDjeO4/4UHj00bDXwxSobyoxcHb+VHolzJ6w4XVv+TFCe8CJ5VYGf3Q+wSE6zaGttPzcYMKZ73/7K7R/bbdPPl+DkajkJcr54kO28FyLwjbJD/tWcVNH29ReSu2yARH73iPye5crH09uiJtTQdTEy3FmRYF9sPoJSAPig/T2ZAoM8upT+Os2U1vUoMA==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66946007)(316002)(8936002)(53546011)(4326008)(66556008)(8676002)(64756008)(66446008)(66476007)(110136005)(6512007)(6506007)(508600001)(31686004)(5660300002)(91956017)(54906003)(76116006)(86362001)(26005)(38100700002)(558084003)(38070700005)(6486002)(31696002)(36756003)(122000001)(82960400001)(2906002)(107886003)(71200400001)(2616005)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Mjk4cEMwcDdXajdPM0I1ZWJmUC9YSS9OVTkvckpncEJ5U05sUzN0VEhlKy9V?=
 =?utf-8?B?VElRRXpxU21uOWp5dHJ6N0xrMDRhRWx1ZERtQ1llNFEwQzUxWUlqRXo0TGpt?=
 =?utf-8?B?bW8vbStxSVR6dWRhemE0UElCUnpQWm01VVV6YWNMd1phZmRJc2ZlY2pmSXdO?=
 =?utf-8?B?ZGtaNXcya2ZZeFBraFJBLzFrUE1peTVDMysrb3VPS2c0RGRPTEpjdlRVMTR3?=
 =?utf-8?B?cDd5N3c5VVlmTmhWRm8zQkdVd3BiRDZaVnhzNzgxZElFbjlCdEFLMmxlQkFn?=
 =?utf-8?B?OVpzMWdtVFFROVVvUmkvRVc5Qk44RVlIekhpRVlQUzRiRDFlMVVSL3JianFS?=
 =?utf-8?B?V3VFdlNwWStCOVc3OVpuWTUzbkV1cnlUNlZLcWR2WXRsRU14RUQyS0RzUDh1?=
 =?utf-8?B?ZUgyYTRIQ0wzZUVDcStKUVBFQkFGMGFPaHVjYnBHRkd3KzI0M0dkMkdHZi9V?=
 =?utf-8?B?bWpuWk9CY2FBT0tRclFvRTdzcTNmZnFNYUNVSkoxUzgwblFjYzlCWnF6NkRu?=
 =?utf-8?B?d3I0NjlBZlJ2SlIyVkxYdGJNNUt2VHZYWnRFeTB0RkV2K3VHMlVzOXpNaU53?=
 =?utf-8?B?VTIxWHVuSldZdG5lMmlVamgxWTM3cStMdm5vUmdpNEpUcytvdDA0eTVCTTZk?=
 =?utf-8?B?bjR0KzBCRmtwQThrNEU1U2grTWFOd1hFNmsvbzZUaWRzV0h6ajNvalpGNmJ5?=
 =?utf-8?B?bjNVajlLNG1HbkxZQjUyTFU5UDlLblYyV0NmT29WcFVPMG9xNnNJTTduUVVk?=
 =?utf-8?B?WS9MZytiRFZCNEdGdVZFY284Sm0xWDRwSk1NMmRhNHM4ZTZhZXpBay9ETHA0?=
 =?utf-8?B?cno0K3l3NVpramFSWlRWa3M0MlJmb2hPSWJQNHY4ZG8zT1BsLzJJRmdLMVNN?=
 =?utf-8?B?MHNFd3Aydy91RW56OUl6ZUFaNmhtQ00yTXBqV3pQODdkaVlwYXdWeUNXdjA5?=
 =?utf-8?B?RTZEUTA2NERtWTNoMU1DYXEvRzI2aWFMemovSHFtT2l0TkFRNmtNVW9xa01i?=
 =?utf-8?B?SGlXTU8va3NKbXN2SFFSVHFsci9hM1k5M2Z6UVY5T2pxdlpVRDdGQks5dXhy?=
 =?utf-8?B?dmNRQWNKa0NHV2lJVnhTMmttUnZ2NUF1VHYyK3lBZmlMMVowaHp3eE5iKy95?=
 =?utf-8?B?Q3NsVXFDK1BQSmEzUDBhejQ2bVU1RkR2bHVXTFhjN0x1bnh2YzRXSGtxT05s?=
 =?utf-8?B?dGxFM25MNVZzMnRPbllXcmNRTHFXWFk0SExYeDIrNDhtUWc4eU0zdkppRVhK?=
 =?utf-8?B?ajBSVjcrbE9ITTQrbURSVVpDeXhzUzZKejhkTHJCMTdHU0xoVXVWb3VmUFVX?=
 =?utf-8?B?bkJvVzF3Vkk2WkJid3FOK3dEMjF2RGhYQi9IaXk1Y0UrVm5xbHNZUEVtWjNK?=
 =?utf-8?B?cURKUWc5QVp1MjVBenJLSG10SEovd1ZNVFdBUmdZMkxMQXNtNGp0MFMvTEJI?=
 =?utf-8?B?TDlFZGVPM09HbHFPSGI4QUYzUHJKYWxvVDBaSzF3WDQ2WW5LVnU5bm9wR1RJ?=
 =?utf-8?B?QU85OXdjQTRJenlHRlg3bmY0MXdDN2NRa1BjT3VOZlBKVmZpMUVjZ3hoeU5n?=
 =?utf-8?B?Q0tITUNwdGRDUUM5MGI1cktpWm84NSt0UFpVVW5UZ0tlbUJtWUhlakdzcXBB?=
 =?utf-8?B?WStCQmlTSFM3Uy9aQ1o0UmNrSEM5aS83dGVIWVhyNlNPWFdzZUdmZEYrVU1U?=
 =?utf-8?B?WEJpNWpMeStPck96cGhrR2drVFdqazcyVHZCdVRjZ1UxWmFPcmc5MDJRb09F?=
 =?utf-8?B?bDE5czU2VG45VkxKeUFKS0k2cGtJTFNJd05Ca3NoOU9MQXFDd1RXY0hIMk5I?=
 =?utf-8?B?ek5OY001clorcFNKTGNIK3N5Z2V2QldxVUVtVkJwQkNzMDVJOVRUemdVS013?=
 =?utf-8?B?THFvNGtZQllPZ2dzNU1zQ1djUzE1R0dEeGFaYlhxV1dDL29zWXJJQVFCUC9T?=
 =?utf-8?B?b1ZDK2x2cDZMSFZlbDRuN2tEZVhhdm5aRkxQekhUeGNBa0F5a1JCRVk3RXNH?=
 =?utf-8?B?cGMrekIrUWlvU2Q3dU1DNytVWlMxTjhEaVY5R093NURKMXRFZnlyT3l5dXZk?=
 =?utf-8?B?WHNkUWFleXZNY2g0dWZNNjhPVzJCeGFvQWxjVzhUS1UzZnpCRTJCNnNxY2lN?=
 =?utf-8?B?cG02ZzhNTVFKemVTT2FDZUhCdzV6TzZrSVFMMEkyNS9nT2kzWTMwOFN6d2Yx?=
 =?utf-8?B?bjlXZUptTEdSL3VrY1pmOHQ1UkpmN2k0cGd0ZWdaQy9Hbng3andvV25uUVN2?=
 =?utf-8?B?YjY3M1VaTXM1ZGZnanVOSmF4dDVRPT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <2E8FD407BF47FA46954EFA50140EFC16@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a1e3bb2f-2d87-4bc4-d351-08d9ed5ae8df
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Feb 2022 12:34:55.8208
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ueRzf6HpESGvwEY3OhphCJyak0LkdJDK2mamZGzc1BAiNnJ39XW222i0ZdtXw0oDB379pK8y9/xPcvOx0edjpNy2HSlLPkZlX4sDxOy5HnE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR03MB5457
X-OriginatorOrg: citrix.com

T24gMTEvMDIvMjAyMiAxMTowOSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IEVsZW1lbnQgc2l6ZSBm
b3IgdGhpcyBvcGNvZGUgZGVwZW5kcyBvbiBFVkVYLlcsIG5vdCB0aGUgbG93IG9wY29kZSBiaXQu
DQo+IE1ha2UgdXNlIG9mIEFWWDUxMkJXIGJlaW5nIGEgcHJlcmVxIHRvIEFWWDUxMl9CSVRBTEcg
YW5kIG1vdmUgdGhlIGNhc2UNCj4gbGFiZWwgdGhlcmUsIGFkZGluZyBhbiBBVlg1MTJCVyBmZWF0
dXJlIGNoZWNrLg0KPg0KPiBTaWduZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3Vz
ZS5jb20+DQoNClJldmlld2VkLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRy
aXguY29tPg0K


From xen-devel-bounces@lists.xenproject.org Fri Feb 11 13:29:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 13:29:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270508.464818 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIVyn-0005Kq-Ta; Fri, 11 Feb 2022 13:28:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270508.464818; Fri, 11 Feb 2022 13:28:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIVyn-0005Kj-QP; Fri, 11 Feb 2022 13:28:53 +0000
Received: by outflank-mailman (input) for mailman id 270508;
 Fri, 11 Feb 2022 13:28:52 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=hiEx=S2=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nIVym-0005Kd-3P
 for xen-devel@lists.xenproject.org; Fri, 11 Feb 2022 13:28:52 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8c66c3f2-8b3e-11ec-8f75-fffcc8bd4f1a;
 Fri, 11 Feb 2022 14:28:50 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id BE59921138;
 Fri, 11 Feb 2022 13:28:49 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A676913C29;
 Fri, 11 Feb 2022 13:28:49 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id RgpAJ5FkBmKXDwAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 11 Feb 2022 13:28:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8c66c3f2-8b3e-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1644586129; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=hNFq6vRhRpF6zkQHoyRWrc1mAdIaUde+DZLA4+kxNJg=;
	b=lnIpUUGIB6hV68imzazz6jkJsB6XqtrYE8Nxq5IQ/LdVneGqZsfqTZmoSN/1rXt5FFXrDo
	jK64JXeE+5biqnTAWMJSDRYVJ9PN5xrgkjSkzm+IKRLbbVNnLXGQVIfpH4zu3Lcr4MUCoY
	SU7+KDj8itG4cVY7vXOaQGsRYw1zpVw=
Message-ID: <342456bd-9138-fd6c-3c5c-2384bbf5d98b@suse.com>
Date: Fri, 11 Feb 2022 14:28:49 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Subject: Re: [RFC v2 1/8] xen/hypfs: support fo nested dynamic hypfs nodes
Content-Language: en-US
To: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <cover.1644341635.git.oleksii_moisieiev@epam.com>
 <8ab7e9ffd5f041c2631f754c7c596874cf6a99c1.1644341635.git.oleksii_moisieiev@epam.com>
 <74e4635d-10ad-86c4-71b1-6e46bc76a89a@suse.com>
 <20220211081613.GA2274024@EPUAKYIW015D>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <20220211081613.GA2274024@EPUAKYIW015D>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------0mMCKmwjSgsalR0qPwrO1Et4"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------0mMCKmwjSgsalR0qPwrO1Et4
Content-Type: multipart/mixed; boundary="------------WyFgZlxqbrrgS0VOeL2DGMXM";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Message-ID: <342456bd-9138-fd6c-3c5c-2384bbf5d98b@suse.com>
Subject: Re: [RFC v2 1/8] xen/hypfs: support fo nested dynamic hypfs nodes
References: <cover.1644341635.git.oleksii_moisieiev@epam.com>
 <8ab7e9ffd5f041c2631f754c7c596874cf6a99c1.1644341635.git.oleksii_moisieiev@epam.com>
 <74e4635d-10ad-86c4-71b1-6e46bc76a89a@suse.com>
 <20220211081613.GA2274024@EPUAKYIW015D>
In-Reply-To: <20220211081613.GA2274024@EPUAKYIW015D>

--------------WyFgZlxqbrrgS0VOeL2DGMXM
Content-Type: multipart/mixed; boundary="------------Nhkl2v46yIaYBTycFiWOldcO"

--------------Nhkl2v46yIaYBTycFiWOldcO
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMTEuMDIuMjIgMDk6MTYsIE9sZWtzaWkgTW9pc2llaWV2IHdyb3RlOg0KPiBIaSBKdWVy
Z2VuLA0KPiANCj4gT24gVGh1LCBGZWIgMTAsIDIwMjIgYXQgMDg6MzQ6MDhBTSArMDEwMCwg
SnVlcmdlbiBHcm9zcyB3cm90ZToNCj4+IE9uIDA4LjAyLjIyIDE5OjAwLCBPbGVrc2lpIE1v
aXNpZWlldiB3cm90ZToNCj4+DQo+IA0KPj4+IEFkZCBuZXcgYXBpOg0KPj4+IC0gaHlwZnNf
cmVhZF9keW5kaXJfZW50cnkNCj4+PiAtIGh5cGZzX2dlbl9keW5kaXJfZW50cnkNCj4+PiB3
aGljaCBhcmUgdGhlIGV4dGVuc2lvbiBvZiB0aGUgZHluYW1pYyBoeXBmcyBub2RlcyBzdXBw
b3J0LCBwcmVzZW50ZWQgaW4NCj4+PiAwYjNiNTNiZThjZjIyNmQ5NDdhNzljMjUzNWE5ZWZi
YjJkZDdiYzM4Lg0KPj4+IFRoaXMgYWxsb3dzIG5lc3RlZCBkeW5hbWljIG5vZGVzIHRvIGJl
IGFkZGVkLiBBbHNvIGlucHV0IHBhcmFtZXRlciBpcw0KPj4+IGh5cGZzX2VudHJ5LCBzbyBw
cm9wZXJ0aWVzIGNhbiBhbHNvIGJlIGdlbmVyYXRlZCBkeW5hbWljYWxseS4NCj4+Pg0KPj4+
IEdlbmVyYXRpbmcgbWl4ZWQgbGlzdCBvZiBkaXJzIGFuZCBwcm9wZXJ0aWVzIGlzIGFsc28g
c3VwcG9ydGVkLg0KPj4+IFNhbWUgYXMgdG8gdGhlIGR5bmFtaWMgaHlwZnMgbm9kZXMsIHRo
aXMgaXMgYW5jaG9yZWQgaW4gcGVyY3B1IHBvaW50ZXIsDQo+Pj4gd2hpY2ggY2FuIGJlIHJl
dHJpZXdlZCBvbiBhbnkgbGV2ZWwgb2YgdGhlIGR5bmFtaWMgZW50cmllcy4NCj4+PiBUaGlz
IGhhbmRsZSBzaG91bGQgYmUgYWxsb2NhdGVkIG9uIGVudGVyKCkgY2FsbGJhY2sgYW5kIHJl
bGVhc2VkIG9uDQo+Pj4gZXhpdCgpIGNhbGxiYWNrLiBXaGVuIHVzaW5nIG5lc3RlZCBkeW5h
bWljIGRpcnMgYW5kIHByb3BlcnRpZXMgaGFuZGxlDQo+Pj4gc2hvdWxkIGJlIGFsbG9jYXRl
ZCBvbiB0aGUgZmlyc3QgZW50ZXIoKSBjYWxsIGFuZCByZWxlYXNlZCBvbiB0aGUgbGFzdA0K
Pj4+IGV4aXQoKSBjYWxsLg0KPj4+DQo+Pj4gU2lnbmVkLW9mZi1ieTogT2xla3NpaSBNb2lz
aWVpZXYgPG9sZWtzaWlfbW9pc2llaWV2QGVwYW0uY29tPg0KDQouLi4NCg0KPj4+IGRpZmYg
LS1naXQgYS94ZW4vaW5jbHVkZS94ZW4vaHlwZnMuaCBiL3hlbi9pbmNsdWRlL3hlbi9oeXBm
cy5oDQo+Pj4gaW5kZXggZTlkNGMyNTU1Yi4uNWQyNzI4Yjk2MyAxMDA2NDQNCj4+PiAtLS0g
YS94ZW4vaW5jbHVkZS94ZW4vaHlwZnMuaA0KPj4+ICsrKyBiL3hlbi9pbmNsdWRlL3hlbi9o
eXBmcy5oDQo+Pj4gQEAgLTc5LDggKzc5LDggQEAgc3RydWN0IGh5cGZzX2VudHJ5X2RpciB7
DQo+Pj4gICAgc3RydWN0IGh5cGZzX2R5bmRpcl9pZCB7DQo+Pg0KPj4gUGxlYXNlIHJlbmFt
ZSB0byBzdHJ1Y3QgaHlwZnNfZHluZGlyLg0KPiANCj4gT2ssIHRoYW5rcy4NCj4gDQo+Pg0K
Pj4+ICAgICAgICBzdHJ1Y3QgaHlwZnNfZW50cnlfZGlyIGRpcjsgICAgICAgICAgICAgLyog
TW9kaWZpZWQgY29weSBvZiB0ZW1wbGF0ZS4gKi8NCj4+PiAgICAgICAgc3RydWN0IGh5cGZz
X2Z1bmNzIGZ1bmNzOyAgICAgICAgICAgICAgIC8qIER5bmFtaWMgZnVuY3Rpb25zLiAqLw0K
Pj4+IC0gICAgY29uc3Qgc3RydWN0IGh5cGZzX2VudHJ5X2RpciAqdGVtcGxhdGU7IC8qIFRl
bXBsYXRlIHVzZWQuICovDQo+Pj4gLSNkZWZpbmUgSFlQRlNfRFlORElSX0lEX05BTUVMRU4g
MTINCj4+PiArICAgIGNvbnN0IHN0cnVjdCBoeXBmc19lbnRyeSAqdGVtcGxhdGU7IC8qIFRl
bXBsYXRlIHVzZWQuICovDQo+Pj4gKyNkZWZpbmUgSFlQRlNfRFlORElSX0lEX05BTUVMRU4g
MzINCj4+PiAgICAgICAgY2hhciBuYW1lW0hZUEZTX0RZTkRJUl9JRF9OQU1FTEVOXTsgICAg
IC8qIE5hbWUgb2YgaHlwZnMgZW50cnkuICovDQo+Pj4gICAgICAgIHVuc2lnbmVkIGludCBp
ZDsgICAgICAgICAgICAgICAgICAgICAgICAvKiBOdW1lcmljYWwgaWQuICovDQo+Pg0KPj4g
V2hhdCBhYm91dCB0aGUgZm9sbG93aW5nIGNoYW5nZSBpbnN0ZWFkOg0KPj4NCj4+IC0gICAg
Y29uc3Qgc3RydWN0IGh5cGZzX2VudHJ5X2RpciAqdGVtcGxhdGU7IC8qIFRlbXBsYXRlIHVz
ZWQuICovDQo+PiAtI2RlZmluZSBIWVBGU19EWU5ESVJfSURfTkFNRUxFTiAxMg0KPj4gLSAg
ICBjaGFyIG5hbWVbSFlQRlNfRFlORElSX0lEX05BTUVMRU5dOyAgICAgLyogTmFtZSBvZiBo
eXBmcyBlbnRyeS4gKi8NCj4+IC0NCj4+IC0gICAgdW5zaWduZWQgaW50IGlkOyAgICAgICAg
ICAgICAgICAgICAgICAgIC8qIE51bWVyaWNhbCBpZC4gKi8NCj4+IC0gICAgdm9pZCAqZGF0
YTsgICAgICAgICAgICAgICAgICAgICAgICAgICAgIC8qIERhdGEgYXNzb2NpYXRlZCB3aXRo
IGlkLiAqLw0KPj4gKyAgICBjb25zdCBzdHJ1Y3QgaHlwZnNfZW50cnkgKnRlbXBsYXRlOyAg
LyogVGVtcGxhdGUgdXNlZC4gKi8NCj4+ICsgICAgdW5pb24gew0KPj4gKyNkZWZpbmUgSFlQ
RlNfRFlORElSX05BTUVMRU4gICAgMzINCj4+ICsgICAgICAgIGNoYXIgbmFtZVtIWVBGU19E
WU5ESVJfTkFNRUxFTl07IC8qIE5hbWUgb2YgaHlwZnMgZW50cnkuICovDQo+PiArICAgICAg
ICBzdHJ1Y3Qgew0KPj4gKyNkZWZpbmUgSFlQRlNfRFlORElSX0lEX05BTUVMRU4gMTINCj4+
ICsgICAgICAgICAgICBjaGFyIG5hbWVbSFlQRlNfRFlORElSX0lEX05BTUVMRU5dOyAvKiBO
YW1lIG9mIGlkIGVudHJ5LiAqLw0KPj4gKyAgICAgICAgICAgIHVuc2lnbmVkIGludCBpZDsg
ICAgICAgICAgICAgICAgICAgIC8qIE51bWVyaWNhbCBpZC4gKi8NCj4+ICsgICAgICAgIH0g
aWQ7DQo+PiArICAgIH07DQo+PiArICAgIHZvaWQqZGF0YTsgICAgICAgICAgICAgICAgICAg
ICAgICAgIC8qIERhdGEgYXNzb2NpYXRlZCB3aXRoIGVudHJ5LiAqLw0KPj4NCj4gDQo+IEkn
bSBub3Qgc3VyZSBJIHNlZSB0aGUgYmVuZWZpdCBmcm9tIHRoaXMgdW5pb24uIFRoZSBvbmx5
IG9uZSBJIHNlZSBpcw0KPiB0aGF0IHN0cnVjdCBoeXBkc19keW5kaXIgd2lsbCBiZSBzbWFs
bGVyIGJ5IHNpemVvZih1bnNpZ25lZCBpbnQpLg0KPiBDb3VsZCB5b3UgZXhwbGFpbiBwbGVh
c2U/DQoNCk15IG1haW4gY29uY2VybiBpcyB0aGF0IGl0IGlzIG5vdCBvYnZpb3VzIHRvIGEg
dXNlciB0aGF0IHRoZQ0KbnVtZXJpY2FsIGlkIGlzIG5lZWRlZCBvbmx5IGZvciBhIHNwZWNp
YWwgY2FzZS4gUHV0dGluZyBpdCBpbnRvDQp0aGUgdW5pb24gbWFrZXMgdGhpcyBtdWNoIG1v
cmUgY2xlYXIuDQoNCj4gDQo+IEFsc28gd2hhdCBkbyB5b3UgdGhpbmsgYWJvdXQgdGhlIGZv
bGxvd2luZyBjaGFuZ2U6DQo+IC0gICAgY2hhciBuYW1lW0hZUEZTX0RZTkRJUl9JRF9OQU1F
TEVOXTsgICAgIC8qIE5hbWUgb2YgaHlwZnMgZW50cnkuICovDQo+IC0NCj4gLSAgICB1bnNp
Z25lZCBpbnQgaWQ7ICAgICAgICAgICAgICAgICAgICAgICAgLyogTnVtZXJpY2FsIGlkLiAq
Lw0KPiAtICAgIHZvaWQgKmRhdGE7ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAvKiBE
YXRhIGFzc29jaWF0ZWQgd2l0aCBpZC4gKi8NCj4gKyAgICBjaGFyIG5hbWVbSFlQRlNfRFlO
RElSX0lEX05BTUVMRU5dOyAgICAgLyogTmFtZSBvZiBoeXBmcyBlbnRyeS4gKi8NCj4gKw0K
PiArICAgIHVuc2lnbmVkIGludCBpZDsgICAgICAgICAgICAgICAgICAgICAgICAvKiBOdW1l
cmljYWwgaWQuICovDQo+ICsgICAgdW5pb24gew0KPiArICAgICAgIGNvbnN0IHZvaWQgKmNv
bnRlbnQ7DQo+ICsgICAgICAgdm9pZCAqZGF0YTsgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgIC8qIERhdGEgYXNzb2NpYXRlZCB3aXRoIGlkLiAqLw0KPiArICAgIH0NCj4gVGhpcyBj
aGFuZ2UgaXMgc2ltaWxhciB0byB0aGUgaHlwZnNfZW50cnlfbGVhZi4gSW4gdGhpcyBjYXNl
IHdlIGNhbg0KPiBzdG9yZSBjb25zdCBwb2ludGVyIGZvciByZWFkLW9ubHkgZW50cmllcyBh
bmQgdXNlIGRhdGEgd2hlbiB3cml0ZSBhY2Nlc3MNCj4gaXMgbmVlZGVkPw0KDQpTdXJlLCBp
ZiB5b3UgbmVlZCB0aGF0Lg0KDQo+IA0KPiBQUzogSSB3aWxsIGFkZHJlc3MgYWxsIHlvdXIg
Y29tbWVudHMgaW4gdjMuDQoNClRoYW5rcywNCg0KDQpKdWVyZ2VuDQo=
--------------Nhkl2v46yIaYBTycFiWOldcO
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------Nhkl2v46yIaYBTycFiWOldcO--

--------------WyFgZlxqbrrgS0VOeL2DGMXM--

--------------0mMCKmwjSgsalR0qPwrO1Et4
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmIGZJEFAwAAAAAACgkQsN6d1ii/Ey8P
GQf/YKOwH6a1yORXioBDg9Mk2TKzmaNUsZBX/m2346CvU6beJRnNWSn9PIKN0it2BepaqMEArs/M
43e+v3D2OSTIgjMjLSaQge/epwGkM4WPOfaYv1j4zPwL2yQQtg12NqBNh9/dwV/Q3CyJ1GbQhLMq
QPLrZMIkKon3Wp4q4PL2mcUGwWAT+POLIVeKKg3wdpbaLtCfLWrwrRE5evvQ44rSumbfpxFncIrj
uJvnFCWo6jHw0LE+XsdJkfzPhISLFurKS6qIATml38VE8nV7r8WDAj5TsNcmt9jaKDPlYgK9jdaW
fpIgSYJbFHebwxdvP0jxtoGlx16mjCoINRaNwE3lhw==
=iDRQ
-----END PGP SIGNATURE-----

--------------0mMCKmwjSgsalR0qPwrO1Et4--


From xen-devel-bounces@lists.xenproject.org Fri Feb 11 13:33:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 13:33:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270515.464829 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIW39-0006i3-F8; Fri, 11 Feb 2022 13:33:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270515.464829; Fri, 11 Feb 2022 13:33:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIW39-0006hw-BD; Fri, 11 Feb 2022 13:33:23 +0000
Received: by outflank-mailman (input) for mailman id 270515;
 Fri, 11 Feb 2022 13:33:21 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=17AN=S2=epam.com=prvs=4041139d62=oleksii_moisieiev@srs-se1.protection.inumbo.net>)
 id 1nIW37-0006hk-Co
 for xen-devel@lists.xenproject.org; Fri, 11 Feb 2022 13:33:21 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2c1cc74b-8b3f-11ec-8f75-fffcc8bd4f1a;
 Fri, 11 Feb 2022 14:33:19 +0100 (CET)
Received: from pps.filterd (m0174679.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 21BDXHH5013770;
 Fri, 11 Feb 2022 13:33:17 GMT
Received: from eur03-db5-obe.outbound.protection.outlook.com
 (mail-db5eur03lp2050.outbound.protection.outlook.com [104.47.10.50])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e5re2837x-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 11 Feb 2022 13:33:17 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com (2603:10a6:102:ea::23)
 by VI1PR03MB6543.eurprd03.prod.outlook.com (2603:10a6:800:17d::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.15; Fri, 11 Feb
 2022 13:32:56 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::c1c:f98:9dd:86e0]) by PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::c1c:f98:9dd:86e0%6]) with mapi id 15.20.4975.015; Fri, 11 Feb 2022
 13:32:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2c1cc74b-8b3f-11ec-8f75-fffcc8bd4f1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=YbXx/mdvPJ3gyIjLImoP8clYqZReC9YyLiXY1s2Xrx537W2NcIhiRFWE7x6dc+RMBkGiH04l7ADlqcI0X41QCCn47nGCnaeeGdoTFtRdy939v5TvZvi2NCTgqAQOqk4PQWyMSn2tbd8eAkecoOKBhDazN3qq9IQZfgK96O6qSYRwIVs7J8ydZ411PnTdbU+XKY8x8/Cpqmre5+Xjs8WsiT8+ztbyBkyh6xC3mD7rHZhtvjINX6ox/UUyJkWp1vlOVhir2InYyviKd4hjLPIeffoAaB87HKvyQgbcQC2+c3/m0YTg4D55YhE5i1WQdfPCs8KYJogwrA52APPgkLryig==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=8bomLOGTWhU73lBEobhu7KCXWLNL+7knZzPF9tfwpRg=;
 b=MtqG4p2jj3frsnEEEwSkSg9y5D2uviRbJySuoCqtF9CkCMMoWPEYOljhs2P36w9d+tkSjeRuZxzfi1z4kPbIcM22HaEYOTlh/bHKspwh3eFzDc6MdoJH2wvtx4oCBsTcpzWaDkPG6CuWx+h4yvQRxq2m6T0vp6hEnU1sh+OYDeGUsmy0SlUF8Ebnh+XYDObiaxoR5G4DK2q4XsMoJMbSsQCOaj4D7qYWsW2LUVvW57err58AeWRzdjLZZ5Of7IG7NRXX7CVYbipVznAetH4cv1zX4yis2+rlvKDDT+vAQR7Ac27lkxyoWIAKh7RSZKopQkWZl6vnTK7IzOUr91R+LA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=8bomLOGTWhU73lBEobhu7KCXWLNL+7knZzPF9tfwpRg=;
 b=IFF5UehHMHK1p/4RDle2dvKRd4YxuyQ+/f2kC4av5BdZCNHm7xZC70Ox3pEaSvNoDvEKH4nHMh1Fk3ZSJftxV0EHERlgWxkiEae3uaWJlwuGO6WOYntFYzrDfdnY1AFqJUtq3xUfWx/HkdT/8YR4NbeDyCoolLq7G2zs9Sgqylm5s5PGkfFVRsT9Y+4SxKsn1+amJGPJLUz0xoc8av53+mxgimn9X3qL11iVGiF5r+Ypi/hi82Na4yIyUXCn6y9S3o65bEVJ1esZSS2ruMOhsj0pmf6AyZwTdwyQt8eygMl+wxWkXHpEwNzEXsFFPjMjuPmdm6wKbqH8uyCHqy1i5A==
From: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
To: Juergen Gross <jgross@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [RFC v2 1/8] xen/hypfs: support fo nested dynamic hypfs nodes
Thread-Topic: [RFC v2 1/8] xen/hypfs: support fo nested dynamic hypfs nodes
Thread-Index: AQHYHRW07SkrMxyT/k6/hhSCHW7RmqyMZwEAgAGeF4CAAFdXgIAAASWA
Date: Fri, 11 Feb 2022 13:32:56 +0000
Message-ID: <20220211133255.GA2391443@EPUAKYIW015D>
References: <cover.1644341635.git.oleksii_moisieiev@epam.com>
 <8ab7e9ffd5f041c2631f754c7c596874cf6a99c1.1644341635.git.oleksii_moisieiev@epam.com>
 <74e4635d-10ad-86c4-71b1-6e46bc76a89a@suse.com>
 <20220211081613.GA2274024@EPUAKYIW015D>
 <342456bd-9138-fd6c-3c5c-2384bbf5d98b@suse.com>
In-Reply-To: <342456bd-9138-fd6c-3c5c-2384bbf5d98b@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 7c8a30ef-58ef-40fc-abbf-08d9ed63035c
x-ms-traffictypediagnostic: VI1PR03MB6543:EE_
x-microsoft-antispam-prvs: 
 <VI1PR03MB6543B5D53A74A18267609508E3309@VI1PR03MB6543.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 Qv4AN/PsAQ1uHJemKkju+vD2meOAxNv38/xpkkrzqEbXhkTGZPOBbFtlBVM/19X6GJBFOYIzwTjcUCNw9DQIasuvwS8FjdZ1VDGrLzZWPWzymoLZR1fsFu4L/q5koF3AXNbAyCHI1p5SD/A/PzGfBOsF8R8c4cGJiG6oW3pf3tni7jDZ8KOlNFSKC7F3wu7+GgqdmLVsF6iV85htSsy4z9/GhXqSv65jW1P+6+92RCezswe7L3Uzdl7rDdN7GbJze4Y6BKQsv52WDvU2LSfDIHdDilnIh1mw3jpaf22H8AQSksLV641fzUEvpbo9/9aGcyiByivyH40oai6fNxtQ2arvJHm5NlI0F35LoKcqVcdErNcf7MRF9DTCVUG4z+pHDl2Vzgdo7PuJMa1XI4SDZQXNI3zWPwpMN2TLce51dyg7kk0mfayvGYWphlcXaPqyt39xnPItbyKJUX10VymPrQXGE1R/fYljNq2IpMBCSps88cXCVvIzHlxjkmjsccNFmKqHYAdyGdmpGXostO4KSKSFQCewLESO3L6k7X/oie8B2OL9bZ3K5B5hcZ18BM2aBK2T6AmueZJ/wbzftqUK8qc709wx6lcHIoGkKwDnqhGBiECiVbVTUZhKrEm/pZ8qZ6rIEG9bR3dJzxWPwI3DcVAhvD7erJgV8P30gVwsCfdQPR2/GYRVOWn4L3ujuVD7X895ngFwJXgRiMXcpcE9Qw==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR03MB7136.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(71200400001)(86362001)(38100700002)(1076003)(38070700005)(83380400001)(6486002)(122000001)(33716001)(508600001)(33656002)(316002)(6506007)(6916009)(66476007)(186003)(2906002)(26005)(53546011)(6512007)(91956017)(9686003)(8936002)(5660300002)(8676002)(76116006)(66946007)(64756008)(66446008)(66556008)(4326008);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?stzdXVS9BuMiS+J0YLe+VQXCsym1jGdNWewzxyCeAFs+Wx6hUznziN1z+3/D?=
 =?us-ascii?Q?5fyX3VpMzdASgtnv4ATirxVZdtExw87qQcwXH2dvW0HImZIQrgeWYkbi/5Zk?=
 =?us-ascii?Q?P07sBrCI7fvjCWHd3XScWXcNKCgdK447qXg36llBGohddtuiDziamuG9DN/2?=
 =?us-ascii?Q?T842Qo3GHf0Y8KoritaywQT8460YaPx0niMKDnEvBZ5QJd3h3i0I43LSYvsM?=
 =?us-ascii?Q?dMaRTB62f12h+I67zYMUrxs2cl1s6/FiFLrDYzKBRVuh7+rH/xong+bYqArA?=
 =?us-ascii?Q?X+9IW7Xg8juev+0Y7HC3jHIwjM3PTcHsMuIyaLPzmWtym19X/UIjVWl3GPQl?=
 =?us-ascii?Q?FRl4HkmQHzkexNNw681UdtaRFd5qaYrJbOBB/qkmcxyHp8HBS9ECEzEqN7m5?=
 =?us-ascii?Q?VZ3C6r4JQSsnmezi8HLw0Y5d9LgCHsNDS28O46bHZ3kQjPXDFmq6ZL/gOBDG?=
 =?us-ascii?Q?dRcgCZiOb30mC0B2bffMIv4PF+v87W7MezF1EePrxUq7UwAZjbp+2tEuhDTY?=
 =?us-ascii?Q?YKOElqcgEBoUMuc6IQSE6/KCuN2rQulzdB7JhATMcuQCEb+XmpNzZ9+iXxyR?=
 =?us-ascii?Q?IZ/qTjtBQLZ8wkw1XuPPH6a+YX92YAnbDRfFq038SXaugHPRxdyrvSL69vrV?=
 =?us-ascii?Q?l1c+Vpu8/CF0Q5CItuizhVhF87be/HEgXIOGbb9h+QSuC2zvDJKdy4sRPJB4?=
 =?us-ascii?Q?+lvlafvyov0UDDXOnjmjWpWBEPXDQrk0DOsLFgP6zVCqzGpW7JepQZjbgjJ8?=
 =?us-ascii?Q?9zi3vKlP9fhDhZgbQSpzX3QcKsYonwLO74yj969UV9eq6PE4BCjibXM32VgD?=
 =?us-ascii?Q?rrrDVCTZqWvBAGUvpnDSIQ9mORxrK0e07JPxaJC8KexSpUhTwYBpg+zVI5y5?=
 =?us-ascii?Q?2kmL64XlHxEGQ7s7y+mlZWQhGK3de/++3qkcBYLOjJk+U6qT1VFkpoMNy1Ys?=
 =?us-ascii?Q?g+ZL9ybnXWrI7j9fLE/K/GTfG9fVlXKUGGiZDY6c/JUsFJAMLFujTo/+1GoM?=
 =?us-ascii?Q?3m4su9ZZ8HDfFZcukPcpXhstkFAbf8p+LZjcZiBLzrZbpzjCgyUgg+VEP8Tx?=
 =?us-ascii?Q?/Qv7erwIyewqgwnvu53oK2z6zb829kuJv3CI4W8Q0mcM/0+IXuMhsEdsmCEm?=
 =?us-ascii?Q?1B/WCojNXoALjp5gcRdwkfcnccy9aoJIWFQq8h/N+dJB3cnqGt3Tx2DXC/P6?=
 =?us-ascii?Q?jf6jWor2Hn9Ov/itQIrL96e4c8hdWIEO3tMVth9vjcJqWiaJWc+N/Qlb4IUW?=
 =?us-ascii?Q?UA79eQGEmplxL0u1uo+quTUF/0I5m0LcK7GJOW03ID9f0I31qvhRSP99tHV6?=
 =?us-ascii?Q?oOQvNiVlVyswkc+VNyoWywDS8HFsCDRuaZPfE3PSNQQoZTqErnjp3n31WlYf?=
 =?us-ascii?Q?hkN/AC9AxQSmEtTrigz5TR6+ZKWJ/qcb+RFyFXl8X4Eo1hxF6SJ1Qwz6VZag?=
 =?us-ascii?Q?FOqw7sOSOFSfe516nzfv8pG9aGo54apSmKeA8gxQsYFNXmUP7JEzkz3i8f7F?=
 =?us-ascii?Q?X+Jw6u+oZ1qGgjQZkSU6uI9YKUXDR8WjwGXXCJZqoK+f9bvmzMretFf54EBn?=
 =?us-ascii?Q?Y1LcNLCVqmH8zvq6JFSShBTGfSKYXTYbVtv1xnoSh++rpoD9xGTEEF4VWqUu?=
 =?us-ascii?Q?99tRS8NKSbPxMrsqV3yT8wqG1Vfg3SLbFxza0CZYLPBNVmx1oPSAr6g5T6KR?=
 =?us-ascii?Q?lbv+Umgajpd1LvLKPvLUwB3imvI=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2DDFFFC342B06F439F7DAD4B0BB37DD4@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR03MB7136.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7c8a30ef-58ef-40fc-abbf-08d9ed63035c
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Feb 2022 13:32:56.2961
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: z6AJUOXLvpUamu6uIzrYTbxF2RzSlJ/0Sw4VqISvJQbkdSniWhmSRrpwehatUGlEkLE28PHh2VqV7fvzwLJY7M9omSAkqV9eFnAezHFDneQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR03MB6543
X-Proofpoint-GUID: 6JYfY-NxFT2vHv541C0IP_5VCiKL3CQ4
X-Proofpoint-ORIG-GUID: 6JYfY-NxFT2vHv541C0IP_5VCiKL3CQ4
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-11_04,2022-02-11_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 spamscore=0
 priorityscore=1501 mlxlogscore=999 mlxscore=0 suspectscore=0
 malwarescore=0 phishscore=0 impostorscore=0 clxscore=1015 adultscore=0
 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202110076

On Fri, Feb 11, 2022 at 02:28:49PM +0100, Juergen Gross wrote:
> On 11.02.22 09:16, Oleksii Moisieiev wrote:
> > Hi Juergen,
> >=20
> > On Thu, Feb 10, 2022 at 08:34:08AM +0100, Juergen Gross wrote:
> > > On 08.02.22 19:00, Oleksii Moisieiev wrote:
> > >=20
> >=20
> > > > Add new api:
> > > > - hypfs_read_dyndir_entry
> > > > - hypfs_gen_dyndir_entry
> > > > which are the extension of the dynamic hypfs nodes support, present=
ed in
> > > > 0b3b53be8cf226d947a79c2535a9efbb2dd7bc38.
> > > > This allows nested dynamic nodes to be added. Also input parameter =
is
> > > > hypfs_entry, so properties can also be generated dynamically.
> > > >=20
> > > > Generating mixed list of dirs and properties is also supported.
> > > > Same as to the dynamic hypfs nodes, this is anchored in percpu poin=
ter,
> > > > which can be retriewed on any level of the dynamic entries.
> > > > This handle should be allocated on enter() callback and released on
> > > > exit() callback. When using nested dynamic dirs and properties hand=
le
> > > > should be allocated on the first enter() call and released on the l=
ast
> > > > exit() call.
> > > >=20
> > > > Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@epam.com>
>=20
> ...
>=20
> > > > diff --git a/xen/include/xen/hypfs.h b/xen/include/xen/hypfs.h
> > > > index e9d4c2555b..5d2728b963 100644
> > > > --- a/xen/include/xen/hypfs.h
> > > > +++ b/xen/include/xen/hypfs.h
> > > > @@ -79,8 +79,8 @@ struct hypfs_entry_dir {
> > > >    struct hypfs_dyndir_id {
> > >=20
> > > Please rename to struct hypfs_dyndir.
> >=20
> > Ok, thanks.
> >=20
> > >=20
> > > >        struct hypfs_entry_dir dir;             /* Modified copy of =
template. */
> > > >        struct hypfs_funcs funcs;               /* Dynamic functions=
. */
> > > > -    const struct hypfs_entry_dir *template; /* Template used. */
> > > > -#define HYPFS_DYNDIR_ID_NAMELEN 12
> > > > +    const struct hypfs_entry *template; /* Template used. */
> > > > +#define HYPFS_DYNDIR_ID_NAMELEN 32
> > > >        char name[HYPFS_DYNDIR_ID_NAMELEN];     /* Name of hypfs ent=
ry. */
> > > >        unsigned int id;                        /* Numerical id. */
> > >=20
> > > What about the following change instead:
> > >=20
> > > -    const struct hypfs_entry_dir *template; /* Template used. */
> > > -#define HYPFS_DYNDIR_ID_NAMELEN 12
> > > -    char name[HYPFS_DYNDIR_ID_NAMELEN];     /* Name of hypfs entry. =
*/
> > > -
> > > -    unsigned int id;                        /* Numerical id. */
> > > -    void *data;                             /* Data associated with =
id. */
> > > +    const struct hypfs_entry *template;  /* Template used. */
> > > +    union {
> > > +#define HYPFS_DYNDIR_NAMELEN    32
> > > +        char name[HYPFS_DYNDIR_NAMELEN]; /* Name of hypfs entry. */
> > > +        struct {
> > > +#define HYPFS_DYNDIR_ID_NAMELEN 12
> > > +            char name[HYPFS_DYNDIR_ID_NAMELEN]; /* Name of id entry.=
 */
> > > +            unsigned int id;                    /* Numerical id. */
> > > +        } id;
> > > +    };
> > > +    void*data;                          /* Data associated with entr=
y. */
> > >=20
> >=20
> > I'm not sure I see the benefit from this union. The only one I see is
> > that struct hypds_dyndir will be smaller by sizeof(unsigned int).
> > Could you explain please?
>=20
> My main concern is that it is not obvious to a user that the
> numerical id is needed only for a special case. Putting it into
> the union makes this much more clear.
>=20

This make sense. I'll make this union. Thanks.

> >=20
> > Also what do you think about the following change:
> > -    char name[HYPFS_DYNDIR_ID_NAMELEN];     /* Name of hypfs entry. */
> > -
> > -    unsigned int id;                        /* Numerical id. */
> > -    void *data;                             /* Data associated with id=
. */
> > +    char name[HYPFS_DYNDIR_ID_NAMELEN];     /* Name of hypfs entry. */
> > +
> > +    unsigned int id;                        /* Numerical id. */
> > +    union {
> > +       const void *content;
> > +       void *data;                             /* Data associated with=
 id. */
> > +    }
> > This change is similar to the hypfs_entry_leaf. In this case we can
> > store const pointer for read-only entries and use data when write acces=
s
> > is needed?
>=20
> Sure, if you need that.

Thanks I will do this as well.

Best regards,
Oleksii
>=20
> >=20
> > PS: I will address all your comments in v3.
>=20
> Thanks,
>=20
>=20
> Juergen






From xen-devel-bounces@lists.xenproject.org Fri Feb 11 15:01:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 15:01:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270531.464845 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIXPs-00077E-Uw; Fri, 11 Feb 2022 15:00:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270531.464845; Fri, 11 Feb 2022 15:00:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIXPs-000777-Rf; Fri, 11 Feb 2022 15:00:56 +0000
Received: by outflank-mailman (input) for mailman id 270531;
 Fri, 11 Feb 2022 15:00:56 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ixe1=S2=arm.com=luca.fancellu@srs-se1.protection.inumbo.net>)
 id 1nIXPs-000771-Dg
 for xen-devel@lists.xenproject.org; Fri, 11 Feb 2022 15:00:56 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 68c05bdd-8b4b-11ec-8f75-fffcc8bd4f1a;
 Fri, 11 Feb 2022 16:00:54 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 604D4106F;
 Fri, 11 Feb 2022 07:00:53 -0800 (PST)
Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com
 [10.1.195.16])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 82EC93F718;
 Fri, 11 Feb 2022 07:00:52 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 68c05bdd-8b4b-11ec-8f75-fffcc8bd4f1a
From: Luca Fancellu <luca.fancellu@arm.com>
To: xen-devel@lists.xenproject.org
Cc: wei.chen@arm.com,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>
Subject: [RFC PATCH] arm/vgic-v3: provide custom callbacks for pend_lpi_tree radix tree
Date: Fri, 11 Feb 2022 15:00:42 +0000
Message-Id: <20220211150042.11972-1-luca.fancellu@arm.com>
X-Mailer: git-send-email 2.17.1

pend_lpi_tree is a radix tree used to store pending irqs, the tree is
protected by a lock for read/write operations.

Currently the radix tree default function to free items uses the
RCU mechanism, calling call_rcu and deferring the operation.

However every access to the structure is protected by the lock so we
can avoid using the default free function that, by using RCU,
increases memory usage and impacts the predictability of the system.

This commit provides custom callbacks to alloc/free items of the radix
tree and the free function doesn't use the RCU mechanism.

Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
---
 xen/arch/arm/vgic-v3.c | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c
index 65bb7991a69b..970747a72012 100644
--- a/xen/arch/arm/vgic-v3.c
+++ b/xen/arch/arm/vgic-v3.c
@@ -1650,6 +1650,18 @@ static inline unsigned int vgic_v3_max_rdist_count(struct domain *d)
                GUEST_GICV3_RDIST_REGIONS;
 }
 
+static struct radix_tree_node *vgic_v3_radix_tree_node_alloc(void *arg)
+{
+    struct radix_tree_node *node = xmalloc(struct radix_tree_node);
+
+    return node ? node : NULL;
+}
+
+static void vgic_v3_radix_tree_node_free(struct radix_tree_node *elem, void *arg)
+{
+    xfree(elem);
+}
+
 static int vgic_v3_domain_init(struct domain *d)
 {
     struct vgic_rdist_region *rdist_regions;
@@ -1668,6 +1680,14 @@ static int vgic_v3_domain_init(struct domain *d)
     rwlock_init(&d->arch.vgic.pend_lpi_tree_lock);
     radix_tree_init(&d->arch.vgic.pend_lpi_tree);
 
+    /*
+     * pend_lpi_tree is protected by rwlock, so don't use lockless RCU default
+     * management for it and provide callbacks to alloc/free elements.
+     */
+    radix_tree_set_alloc_callbacks(&d->arch.vgic.pend_lpi_tree,
+                                   vgic_v3_radix_tree_node_alloc,
+                                   vgic_v3_radix_tree_node_free, NULL);
+
     /*
      * Domain 0 gets the hardware address.
      * Guests get the virtual platform layout.
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Fri Feb 11 15:21:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 15:21:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270538.464855 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIXjB-00011T-K1; Fri, 11 Feb 2022 15:20:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270538.464855; Fri, 11 Feb 2022 15:20:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIXjB-00011M-Gr; Fri, 11 Feb 2022 15:20:53 +0000
Received: by outflank-mailman (input) for mailman id 270538;
 Fri, 11 Feb 2022 15:20:52 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nIXjA-00011C-9C; Fri, 11 Feb 2022 15:20:52 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nIXjA-00027W-5w; Fri, 11 Feb 2022 15:20:52 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nIXj9-0004yp-Jr; Fri, 11 Feb 2022 15:20:51 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nIXj9-00032h-JQ; Fri, 11 Feb 2022 15:20:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Ul2Q88MeiX6urb9RRHiwu+ZvT6yTLfAGupzuT53rPa0=; b=i7rDLf5sHAiOUwRDmNaEz0NXI2
	4p9dgfNQ8Ft9TuDg0HjVcK9p+EM1ucwOLrDQ0mfwQGUUWMxsfyPbJtitFqIU8fw/uRPTo+2ILewvG
	2SodqTQsLIga1Bl7gRurv4Iy5HCFxvOfIp0w2iDtOpWbALkj07nMZjNaB9lSHj1YidoQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168084-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-5.4 test] 168084: trouble: blocked/broken/fail/pass
X-Osstest-Failures:
    linux-5.4:build-arm64:<job status>:broken:regression
    linux-5.4:build-arm64-pvops:<job status>:broken:regression
    linux-5.4:build-arm64-xsm:<job status>:broken:regression
    linux-5.4:build-arm64-pvops:host-install(4):broken:regression
    linux-5.4:build-arm64-xsm:host-install(4):broken:regression
    linux-5.4:build-arm64:host-install(4):broken:regression
    linux-5.4:test-arm64-arm64-examine:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-xl:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking
    linux-5.4:build-arm64-libvirt:build-check(1):blocked:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=52871671099d1bb3fca5ed076029e4b937bfc053
X-Osstest-Versions-That:
    linux=76fd334f07cc11e047c2237a19b2cf8b1f653ba2
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 11 Feb 2022 15:20:51 +0000

flight 168084 linux-5.4 real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168084/

Failures and problems with tests :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-arm64                     <job status>                 broken
 build-arm64-pvops               <job status>                 broken
 build-arm64-xsm                 <job status>                 broken
 build-arm64-pvops             4 host-install(4)        broken REGR. vs. 168060
 build-arm64-xsm               4 host-install(4)        broken REGR. vs. 168060
 build-arm64                   4 host-install(4)        broken REGR. vs. 168060

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-examine      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl           1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit1   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit2   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-seattle   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-thunderx  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-vhd       1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-xsm       1 build-check(1)               blocked  n/a
 build-arm64-libvirt           1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168060
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168060
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168060
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168060
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168060
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168060
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168060
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168060
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168060
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168060
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168060
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168060
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 linux                52871671099d1bb3fca5ed076029e4b937bfc053
baseline version:
 linux                76fd334f07cc11e047c2237a19b2cf8b1f653ba2

Last test of basis   168060  2022-02-08 17:43:16 Z    2 days
Testing same since   168084  2022-02-11 08:43:38 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Florian Fainelli <f.fainelli@gmail.com>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Guenter Roeck <linux@roeck-us.net>
  Jon Hunter <jonathanh@nvidia.com>
  Jon Maloy <jmaloy@redhat.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Linux Kernel Functional Testing <lkft@linaro.org>
  Shuah Khan <skhan@linuxfoundation.org>
  Slade Watkins <slade@sladewatkins.com>
  Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
  Ulf Hansson <ulf.hansson@linaro.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              broken  
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  broken  
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          blocked 
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            broken  
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          blocked 
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      blocked 
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  blocked 
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  blocked 
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     blocked 
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 blocked 
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      blocked 
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary

broken-job build-arm64 broken
broken-job build-arm64-pvops broken
broken-job build-arm64-xsm broken
broken-step build-arm64-pvops host-install(4)
broken-step build-arm64-xsm host-install(4)
broken-step build-arm64 host-install(4)

Not pushing.

------------------------------------------------------------
commit 52871671099d1bb3fca5ed076029e4b937bfc053
Author: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date:   Fri Feb 11 09:07:52 2022 +0100

    Linux 5.4.179
    
    Link: https://lore.kernel.org/r/20220209191248.688351316@linuxfoundation.org
    Tested-by: Shuah Khan <skhan@linuxfoundation.org>
    Tested-by: Florian Fainelli <f.fainelli@gmail.com>
    Tested-by: Jon Hunter <jonathanh@nvidia.com>
    Tested-by: Linux Kernel Functional Testing <lkft@linaro.org>
    Tested-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
    Tested-by: Slade Watkins <slade@sladewatkins.com>
    Tested-by: Guenter Roeck <linux@roeck-us.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

commit d692e3406e052dbf9f6d9da0cba36cb763272529
Author: Jon Maloy <jmaloy@redhat.com>
Date:   Sat Feb 5 14:11:18 2022 -0500

    tipc: improve size validations for received domain records
    
    commit 9aa422ad326634b76309e8ff342c246800621216 upstream.
    
    The function tipc_mon_rcv() allows a node to receive and process
    domain_record structs from peer nodes to track their views of the
    network topology.
    
    This patch verifies that the number of members in a received domain
    record does not exceed the limit defined by MAX_MON_DOMAIN, something
    that may otherwise lead to a stack overflow.
    
    tipc_mon_rcv() is called from the function tipc_link_proto_rcv(), where
    we are reading a 32 bit message data length field into a uint16.  To
    avert any risk of bit overflow, we add an extra sanity check for this in
    that function.  We cannot see that happen with the current code, but
    future designers being unaware of this risk, may introduce it by
    allowing delivery of very large (> 64k) sk buffers from the bearer
    layer.  This potential problem was identified by Eric Dumazet.
    
    This fixes CVE-2022-0435
    
    Reported-by: Samuel Page <samuel.page@appgate.com>
    Reported-by: Eric Dumazet <edumazet@google.com>
    Fixes: 35c55c9877f8 ("tipc: add neighbor monitoring framework")
    Signed-off-by: Jon Maloy <jmaloy@redhat.com>
    Reviewed-by: Xin Long <lucien.xin@gmail.com>
    Reviewed-by: Samuel Page <samuel.page@appgate.com>
    Reviewed-by: Eric Dumazet <edumazet@google.com>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

commit 3a0a7ec5574b510b067cfc734b8bdb6564b31d4e
Author: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date:   Thu Jan 27 08:16:38 2022 +0100

    moxart: fix potential use-after-free on remove path
    
    commit bd2db32e7c3e35bd4d9b8bbff689434a50893546 upstream.
    
    It was reported that the mmc host structure could be accessed after it
    was freed in moxart_remove(), so fix this by saving the base register of
    the device and using it instead of the pointer dereference.
    
    Cc: Ulf Hansson <ulf.hansson@linaro.org>
    Cc: Xiyu Yang <xiyuyang19@fudan.edu.cn>
    Cc: Xin Xiong <xiongx18@fudan.edu.cn>
    Cc: Xin Tan <tanxin.ctf@gmail.com>
    Cc: Tony Lindgren <tony@atomide.com>
    Cc: Yang Li <yang.lee@linux.alibaba.com>
    Cc: linux-mmc@vger.kernel.org
    Cc: stable <stable@vger.kernel.org>
    Reported-by: whitehat002 <hackyzh002@gmail.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Link: https://lore.kernel.org/r/20220127071638.4057899-1-gregkh@linuxfoundation.org
    Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>


From xen-devel-bounces@lists.xenproject.org Fri Feb 11 15:26:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 15:26:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270549.464866 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIXof-0001g7-7K; Fri, 11 Feb 2022 15:26:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270549.464866; Fri, 11 Feb 2022 15:26:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIXof-0001g0-4Q; Fri, 11 Feb 2022 15:26:33 +0000
Received: by outflank-mailman (input) for mailman id 270549;
 Fri, 11 Feb 2022 15:26:31 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nIXod-0001fp-DO
 for xen-devel@lists.xenproject.org; Fri, 11 Feb 2022 15:26:31 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nIXoc-0002Eq-Vh; Fri, 11 Feb 2022 15:26:30 +0000
Received: from 54-240-197-235.amazon.com ([54.240.197.235]
 helo=[192.168.30.126]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nIXoc-0001eR-Pr; Fri, 11 Feb 2022 15:26:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=KTSoUtgjwSy7gl6uk/Mujrv4cOe4EP/gFFPDHqVbYj0=; b=cEMn2gtqhXpzWVySrQJURQiovT
	Ozr1I5dupZhL6jadjnIAuj9XxFWip5nnZOqtqXV/IonXlRCYeRsyskFD7SeXXYQKEBFlaALypnMVW
	8UccRuIjgZ2aHHxtukuhJP4aadW3z9Cy9/BPKDqSE0trd94ae69xrPXXAIZEpU7esumU=;
Message-ID: <81a2f978-9337-2e58-c8b2-86dc7defc2ec@xen.org>
Date: Fri, 11 Feb 2022 15:26:28 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.1
Subject: Re: [RFC PATCH] arm/vgic-v3: provide custom callbacks for
 pend_lpi_tree radix tree
To: Luca Fancellu <luca.fancellu@arm.com>, xen-devel@lists.xenproject.org
Cc: wei.chen@arm.com, Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <20220211150042.11972-1-luca.fancellu@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220211150042.11972-1-luca.fancellu@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Luca,

On 11/02/2022 15:00, Luca Fancellu wrote:
> pend_lpi_tree is a radix tree used to store pending irqs, the tree is
> protected by a lock for read/write operations.
> 
> Currently the radix tree default function to free items uses the
> RCU mechanism, calling call_rcu and deferring the operation.
> 
> However every access to the structure is protected by the lock so we
> can avoid using the default free function that, by using RCU,
> increases memory usage and impacts the predictability of the system.

I understand goal but looking at the implementation of 
vgic_v3_lpi_to_pending() (Copied below for convenience). We would 
release the lock as soon as the look-up finish, yet the element is returned.

static struct pending_irq *vgic_v3_lpi_to_pending(struct domain *d,
                                                   unsigned int lpi)
{
     struct pending_irq *pirq;

     read_lock(&d->arch.vgic.pend_lpi_tree_lock);
     pirq = radix_tree_lookup(&d->arch.vgic.pend_lpi_tree, lpi);
     read_unlock(&d->arch.vgic.pend_lpi_tree_lock);

     return pirq;
}

So the lock will not protect us against removal. If you want to drop the 
RCU, you will need to ensure the structure pending_irq is suitably 
protected. I haven't check whether there are other locks that may suit 
us here.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Feb 11 15:26:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 15:26:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270550.464872 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIXof-0001j5-I3; Fri, 11 Feb 2022 15:26:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270550.464872; Fri, 11 Feb 2022 15:26:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIXof-0001hm-Bo; Fri, 11 Feb 2022 15:26:33 +0000
Received: by outflank-mailman (input) for mailman id 270550;
 Fri, 11 Feb 2022 15:26:31 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=WJSo=S2=amazon.de=prvs=034f27e45=nmanthey@srs-se1.protection.inumbo.net>)
 id 1nIXoc-0001fo-WA
 for xen-devel@lists.xenproject.org; Fri, 11 Feb 2022 15:26:31 +0000
Received: from smtp-fw-9103.amazon.com (smtp-fw-9103.amazon.com
 [207.171.188.200]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id faa00943-8b4e-11ec-8f75-fffcc8bd4f1a;
 Fri, 11 Feb 2022 16:26:29 +0100 (CET)
Received: from pdx4-co-svc-p1-lb2-vlan2.amazon.com (HELO
 email-inbound-relay-pdx-2a-92ba9394.us-west-2.amazon.com) ([10.25.36.210])
 by smtp-border-fw-9103.sea19.amazon.com with ESMTP; 11 Feb 2022 15:26:12 +0000
Received: from EX13D02EUB001.ant.amazon.com
 (pdx1-ws-svc-p6-lb9-vlan3.pdx.amazon.com [10.236.137.198])
 by email-inbound-relay-pdx-2a-92ba9394.us-west-2.amazon.com (Postfix) with
 ESMTPS id 1811141887; Fri, 11 Feb 2022 15:26:12 +0000 (UTC)
Received: from EX13MTAUEE002.ant.amazon.com (10.43.62.24) by
 EX13D02EUB001.ant.amazon.com (10.43.166.150) with Microsoft SMTP Server (TLS)
 id 15.0.1497.28; Fri, 11 Feb 2022 15:26:09 +0000
Received: from u6fc700a6f3c650.ant.amazon.com (10.1.212.14) by
 mail-relay.amazon.com (10.43.62.224) with Microsoft SMTP Server id
 15.0.1497.28 via Frontend Transport; Fri, 11 Feb 2022 15:26:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: faa00943-8b4e-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
  d=amazon.de; i=@amazon.de; q=dns/txt; s=amazon201209;
  t=1644593189; x=1676129189;
  h=from:to:cc:subject:date:message-id:mime-version;
  bh=TT+qw2jJTN+YB51Wk3Q538yOVcAVuWNCzpcJJfEh1m0=;
  b=ft1j6k2N2FSCn8qZVPC5uxad4fk713vSA1IWAp5hhEhjQZCCgsAdNp9I
   GYcASWFiFgLu/1pjR5hHSma5JKtQtyxnCfnAFMfsEX/g3L1kXPUqbVNlg
   pij95dQt4HyGJy4orQ7fUHmtg1qIP4xDc29EMAcgiRGAkuTqrVPzWV/PZ
   g=;
X-IronPort-AV: E=Sophos;i="5.88,361,1635206400"; 
   d="scan'208";a="991414143"
From: Norbert Manthey <nmanthey@amazon.de>
To: <xen-devel@lists.xenproject.org>
CC: Norbert Manthey <nmanthey@amazon.de>, Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>, Wei Liu
	<wl@xen.org>
Subject: [PATCH CPU v2] cpuid: initialize cpuinfo with boot_cpu_data
Date: Fri, 11 Feb 2022 16:25:59 +0100
Message-ID: <20220211152559.27862-1-nmanthey@amazon.de>
X-Mailer: git-send-email 2.17.1
MIME-Version: 1.0
Content-Type: text/plain
Precedence: Bulk

When re-identifying CPU data, we might use uninitialized data when
checking for the cache line property to adapt the cache
alignment. The data that depends on this uninitialized read is
currently not forwarded.

To avoid problems in the future, initialize the data cpuinfo
structure before re-identifying the CPU again.

The trace to hit the uninitialized read reported by Coverity is:

bool recheck_cpu_features(unsigned int cpu)
...
    struct cpuinfo_x86 c;
    ...
    identify_cpu(&c);

void identify_cpu(struct cpuinfo_x86 *c)
...
    generic_identify(c)

static void generic_identify(struct cpuinfo_x86 *c)
...
        if (this_cpu->c_early_init)
                this_cpu->c_early_init(c); // which is early_init_intel

static void early_init_intel(struct cpuinfo_x86 *c)
...
    if (c->x86 == 15 && c->x86_cache_alignment == 64)
        c->x86_cache_alignment = 128;

This bug was discovered and resolved using Coverity Static Analysis
Security Testing (SAST) by Synopsys, Inc.

Signed-off-by: Norbert Manthey <nmanthey@amazon.de>

---
 xen/arch/x86/cpuid.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/arch/x86/cpuid.c b/xen/arch/x86/cpuid.c
--- a/xen/arch/x86/cpuid.c
+++ b/xen/arch/x86/cpuid.c
@@ -609,7 +609,7 @@ void __init init_guest_cpuid(void)
 bool recheck_cpu_features(unsigned int cpu)
 {
     bool okay = true;
-    struct cpuinfo_x86 c;
+    struct cpuinfo_x86 c = {0};
     const struct cpuinfo_x86 *bsp = &boot_cpu_data;
     unsigned int i;
 
-- 
2.17.1




Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879





From xen-devel-bounces@lists.xenproject.org Fri Feb 11 15:28:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 15:28:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270565.464889 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIXqF-0002wX-3X; Fri, 11 Feb 2022 15:28:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270565.464889; Fri, 11 Feb 2022 15:28:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIXqF-0002wQ-0Z; Fri, 11 Feb 2022 15:28:11 +0000
Received: by outflank-mailman (input) for mailman id 270565;
 Fri, 11 Feb 2022 15:28:09 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nIXqD-0002wI-LZ
 for xen-devel@lists.xenproject.org; Fri, 11 Feb 2022 15:28:09 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nIXqC-0002GZ-Lo; Fri, 11 Feb 2022 15:28:08 +0000
Received: from 54-240-197-235.amazon.com ([54.240.197.235]
 helo=[192.168.30.126]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nIXqC-0001hU-FZ; Fri, 11 Feb 2022 15:28:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=07OLUu5EaiN7izujrTb3pRsmPF4oJCmfCQr7UHmVJ7s=; b=ivVihV/5VTvamBlCIwQd+zEzaq
	C2rzSGJurOSyLuP9vJBOX20F56mIMponNcar2gegbi8wqNITgb434dB4DTu5G4z/FEQd9TiUjDULY
	csUYS3N7Er66ZU02OaQD3N1wmpoKG+a2Pv92mb1zuruWrkXX6t39PGvmQVN7AQoTZS8I=;
Message-ID: <49b3abe8-39e7-5b74-0471-8b65aa234ee3@xen.org>
Date: Fri, 11 Feb 2022 15:28:05 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.1
Subject: Re: [PATCH v6 13/13] xen/arm: account IO handlers for emulated PCI
 MSI-X
To: Oleksandr Andrushchenko <andr2000@gmail.com>,
 xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, oleksandr_tyshchenko@epam.com,
 volodymyr_babchuk@epam.com, artem_mygaiev@epam.com, roger.pau@citrix.com,
 jbeulich@suse.com, andrew.cooper3@citrix.com, george.dunlap@citrix.com,
 paul@xen.org, bertrand.marquis@arm.com, rahul.singh@arm.com,
 Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
References: <20220204063459.680961-1-andr2000@gmail.com>
 <20220204063459.680961-14-andr2000@gmail.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220204063459.680961-14-andr2000@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Oleksandr,

On 04/02/2022 06:34, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> At the moment, we always allocate an extra 16 slots for IO handlers
> (see MAX_IO_HANDLER). So while adding IO trap handlers for the emulated
> MSI-X registers we need to explicitly tell that we have additional IO
> handlers, so those are accounted.
> 
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

Acked-by: Julien Grall <jgrall@amazon.com>

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Feb 11 15:44:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 15:44:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270572.464900 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIY5u-0005Eb-Gn; Fri, 11 Feb 2022 15:44:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270572.464900; Fri, 11 Feb 2022 15:44:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIY5u-0005EU-DU; Fri, 11 Feb 2022 15:44:22 +0000
Received: by outflank-mailman (input) for mailman id 270572;
 Fri, 11 Feb 2022 15:44:21 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=dFbI=S2=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nIY5s-0005EO-UZ
 for xen-devel@lists.xenproject.org; Fri, 11 Feb 2022 15:44:21 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 784e1590-8b51-11ec-8eb8-a37418f5ba1a;
 Fri, 11 Feb 2022 16:44:18 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 784e1590-8b51-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644594258;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=SIr7/WtiBl1F0ZoXxDRjaDCDTuaOnEY0ZZxoZSftg/0=;
  b=ZjRFC+d4PhCtu5/cLJKDGueyxoEu/qNSGcS6IyTk8Ug9dYmFhoBA2pUN
   /4mCSCakr3pVhx5hp8Yrh44NusRZuXIFpQTJENpyzPzer+BztEWbaqMwO
   1K9kcegtoJmvfDzPdKh+GZU6YZGGJze5pJkJVjhfzcd4Mc2YU2re4kna4
   Q=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: 028tthY1i0h/JNOt3X+QEEQwHFcqeQRf9FBFZylQrlvvdDvZFILVm2XKi9ZUv9wnP/4z49YpEl
 MsGbwyIoWbuooyc6HQqY9Gi6tg+Y01kg3q0estmv3rLR663lcq092UvKZl17ct/LR/gekMXK9K
 rEO7TL56whGAvcUUhXxp+qD010woG1dLmanzd0/fAWaipdWF+ekDQW7Wv5Cinvkncz6jMUuCyX
 H4OSW0kerEQXWGkNDEUblySXHcn/tw3FKp7VgUmOBCDli701CkRCFXaw7R7kDEOh9cQiTKaGCv
 Z1JawnNPh5LizNun/wFvYKuu
X-SBRS: 5.1
X-MesageID: 66251363
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:VuD+yq6TlY11zgSjxNbH2AxRtCrBchMFZxGqfqrLsTDasY5as4F+v
 mNND2nQb67ba2P3fox1PYq08BhSv5TcydYwTFBu+CxhHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FV8MpBsJ00o5wbZj29cw27BVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z+
 okWq6WbGAgVNZaUkeQMD0YCODx8IvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALNs7kMZlZonh95TrYEewnUdbIRKCiCdpwgmlq25kVQ622i
 8wxOBxBUwrpbT5zCF4dIbRiv8rzv3umbGgNwL6SjfVuuDWCpOBr65DTN97Sds2PVN9itE+Sr
 WLb/Ez0GhgfcteYzFKt1XahhfTGmy/hb74DD72z9vNsg1q7y3QaDVsdUl7TidCjlkO7bPdOJ
 EUV9zQGoLA78QqgSdyVdwexoGOA+AUdXdVQO+Qg7UeGza+8ywyUHHQeRzhNLtkvrtYrRCcC3
 0WM2djuAFRHoLCTDH6Q6LqQhTezIjQOa38PYzceSgkI6MWlp5s85jroSttgC6ezgsfCMDf82
 S2RrCM+irMQiuYGz6y+u1vAhlqEpJLEUwo07QX/RX++40VyY4vNT5ez9VHR4PJELYCYZlqMp
 n4Jn46Z9u9mJZOQkC2ARs0dEbfv4OyKWAAwmnY2QcNnrW70vSf+I8YAu1mSOXuFLO42JWT3W
 WSCtj9a38daPGr2MvVcfoCuXpFCIbfbKfzpUfXdb9xra5d3dROa8CwGWXN8z1wBg2B3z/hhZ
 M7zndKESC9DVP85lGbeq/I1jOdzrh3S018/UnwSI/6P9bOFLECYRr4eWLdlRrBotfjUyOk5H
 js2Cidr9/m9eLCmCsU02dRKRbzvEZTdLcqnwyCwXrTdSjeK4El7V5fsLUoJIuSJZZh9mObS5
 W2aUURF0lf5jnCvAVzUNiw+Mu6wAswi9CpT0ckQ0bCAgSlLjWGHtvl3SnfKVeN/qLwLIQBcE
 5HphPls8twQE2+aqlzxnLH2rZB4dQTDuO59F3HNXdTLRLY5H1ah0oa9JmPHrXBSZgLq5ZpWi
 +DxjWvzHMtcLzmO+e6LMZpDOXvq5iND8A+zNmOVSuRulLLErtQ0dXyr06NfzgNlAUyr+wZ2H
 j2+WH8wjeLMv5U04J/Og6WFpJ2uCOxwAgxRGGyz0Fp8HXOyErOLzdASXeCWUyraUW+oqqyua
 f8Ml6P3MeEdnUYMuI15Su45waU77trphrlb0gU7QymbMwX1UuttciucwM1ClqxR3bsF6wG4b
 V2Cp4tBMrKTNcK7TFNIfFg5bv6O3O0/kyXJ6ahnO13z4SJ6peLVUUhbMxSWpjZaKb95bNEsz
 es74ZZE4A2jkBs6dN2Bi3kMpWiLK3UBVYQht40bX9C32lZ6lAkabMWFWCHs4ZyJZ9FdCWUQI
 2eZ1PjYmrBR5kveaH5vR3LD6vVQ2MYVsxdQwV5ce1nQwojZhuU61QF6+CgsSlgH1Q1O1u9+N
 zQ5N0BxIqnSrT5kiNIaAjKpEgBFQhaY5lbw2x0Ck2iAFxukUWnELWscP+eR/R9GrzIAL2YDp
 LzImnz4VTvKfd3q2npgUEFonPXvUNht+1CQg8ugBcmEQ8E3bDeNbnVCvobUR88L2f8MuXA=
IronPort-HdrOrdr: A9a23:8T0ED6qT0wL8BuXBMvC6pPgaV5u8L9V00zEX/kB9WHVpm5Oj+P
 xGzc526farslsssSkb6Ku90dq7MAnhHP9OkMMs1NiZLW7bUQeTTL2KqLGSuwEIeBeOu9K1t5
 0QFZSWYeeYZTMR46fHCUuDYq8dKbG8geWVbIzlvhVQpHRRGsVdBnBCe2Om+yNNNWp7LKt8MK
 DZyttMpjKmd3hSRN+8HGM5U+/KoMCOvI76YDYdbiRXpDWmvHeN0vrXAhKY1hARX3dk2rE561
 XIlAT/++GKr+y78BnBzGXehq4m1+cJi+EzSvBkuPJlagkEuTzYJ7iJbofy/Qzd7tvfqmrC2+
 O83ivId/4Dl085OFvF5ScFkjOQrwoG+jvsz0SVjmDkptG8TDUmC9BZjYYcaRfB7VE81esMmZ
 6j8ljpwKa/Nymw6hgVJuK4JC1Chw6xuz4vgOQTh3tQXc8Xb6JQt5UW+AdQHI0bFCz35Yg7GK
 02Zfusr8p+YBefdTTUr2NvyNujUjA6GQqHWFELvoiQ3yJNlH50wkMEzIgUn2sG9pg6V55Yjt
 60ephAhfVLVIsbfKh9DOAOTY++DXHMWwvFNCaILVHuBMg8SgbwQl7MkcAIDc2RCe01JaoJ6e
 b8uQljxBAPkmrVeL2z4KE=
X-IronPort-AV: E=Sophos;i="5.88,361,1635220800"; 
   d="scan'208";a="66251363"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=evmNfj5J9athv/Q/MAnV7/PHE9GU+ldOFkQc+Q+YKI9q8tPdqachrlArfdybyw3U0ZSjrM/RfYitXNc9tf+BIEaPjpywV10vwQrXupZZmdJQjPcTluJWfuSiS6ksSvSymtgx5PFqXkFHVMQvGFTF0W0/y4DMGwoyAQdM+j+E0/ZsWIsmAzjF7Sp8f0ahbLYnUdIlJaxS+Jz8XYioFdLsLEK1YN0dVjKZAaADmCDsDopnIWPtG39MYBjNmHpg9/C16LYOHx/+Pv6/Z6KGAWRlaDqC9OzVUcQ5Q9YWXaDSq0LKv5wtJvwAAfGkP9mFGHMyojxiNqIQHfNxUu4uGSV77A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=wgKdJrADDx7vLgciLHuGqrjnG5eQrRWvFKfaM1dzUKY=;
 b=Tl4WEtRHsVykSO3PvfnAeVftRfLkr8aXv0IPzeWoSLtp8RLHTtIAKL5IbDZlHcNIoeKCBB7YVZ/xPfn9eWvRuMnP0nNeAEQPSXJGGPJzbuVaHYXpJjrFbb4B5vc2hzb6SIxI6JFgt+DkaMtta3+sqp3DaJA73WF3FWgBsGhOzR4CsUCWTjFhGBzf2r8gF/fb4hRpZA4dTle9k3wVynYx7D4CDN4XOUPjRdm0WJnKlm0Xm3nqhb96/PNblyuh38mrmTCAyyvzzHhvw7VmQHQ4m7rneOaiaAXtgZhius46Ld7fSZXUEq7sqrBWoH01AzypBs4wtT6GdIbwLzOLRzMykw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=wgKdJrADDx7vLgciLHuGqrjnG5eQrRWvFKfaM1dzUKY=;
 b=Zi0QLNrTuCoONlJ4Wkz2DIbxGPo74sofgiua1WUuFhxAsbUoe+cqSUeYd+okHEAJnNPOfT65Vsats4fLJlAk0yXE7Wvfvz2dHDRNmqxC2IQ7nPNU9SwgFkhuyVNqY+X3ic0WG/LacqDfpnoKs0PSaylQWkUtbG0eOVqnBUxmTdM=
Date: Fri, 11 Feb 2022 16:44:02 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"jbeulich@suse.com" <jbeulich@suse.com>, "julien@xen.org" <julien@xen.org>,
	"sstabellini@kernel.org" <sstabellini@kernel.org>, Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Artem Mygaiev <Artem_Mygaiev@epam.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>, Rahul Singh
	<rahul.singh@arm.com>
Subject: Re: [PATCH] vpci: introduce per-domain lock to protect vpci structure
Message-ID: <YgaEQrqIEPc258Fy@Air-de-Roger>
References: <20220209133627.959649-1-andr2000@gmail.com>
 <YgU6Snk8GTytJXZp@Air-de-Roger>
 <c4666570-666e-6680-5ec2-adf1da51ad06@epam.com>
 <YgZLEMW9US9QjjYG@Air-de-Roger>
 <1dbd0f54-affb-1e67-215c-6e6c8fb8535b@epam.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1dbd0f54-affb-1e67-215c-6e6c8fb8535b@epam.com>
X-ClientProxiedBy: LO4P123CA0351.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:18d::14) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 89f04d0a-1153-4b01-5e2e-08d9ed755718
X-MS-TrafficTypeDiagnostic: MWHPR03MB2462:EE_
X-Microsoft-Antispam-PRVS: <MWHPR03MB246216286C87BD780EBCE76D8F309@MWHPR03MB2462.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: ep671u9f9pgFMQJuaAgL8qj5ORbtOy2WhBmfZuSeX7//jY2yWWenF/kGi0S3dfqbcVF+7Pyc5iAb17wLUCmwUUWwVO1S6fMQLa3qZN18wwvrrPFEX8lnCJPw7Gg5J0NuDtKiPB5E/P3+eMJ8vZarWL9+z+IhdalZ80uCIylWzpqfEo5DTIdKuH13CrokqPyQ5ASZpQpW8qyyMCRi+n4kKHFCCOXaOfdYYr5E+MM0vIWYmOyp0kX/Y+DOoXR4LOUOIEQd6TxJXZRXBos6u1DIAR8sddFzfjGd/HsTFiMyV+CpuNuy6kilEK86niTQnFZda6PaTTupzxMb3ntO7wvgi5ePBa1/n7wJlBmR+MblhcVZLHI13pvp9u/xmuDxwdt+3xgFxARoAYvZPe6Me9QJ57Un3Rx4hMH5ToOrET5smftWl3LBhBtHdjkXPpaizeSaHX7NEnOMCshzSZlzNQXWM48sBIl4cyQ7cdnks4vB+fXu8OpQBnLIcE6SfZc2i3cUZpa+1JwA4KBPH51WVIOVqk6Ud/7m38Nqj3MpD/bwupqVDhSGa6z346ENyc1HFUKpDEMDcq6b61k4DVpW1doRuxqM7x6vkr7iFnYg93qkpBoPuDW4REqeCIfVVKQNSXpKAdjBLlNG27evitB0YCOS/Q==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(33716001)(83380400001)(186003)(26005)(9686003)(8676002)(6512007)(4326008)(6666004)(5660300002)(8936002)(6506007)(66476007)(66556008)(53546011)(66946007)(86362001)(54906003)(85182001)(508600001)(7416002)(6486002)(82960400001)(6916009)(316002)(38100700002)(2906002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VzVFWVdNOFVYNmVXRFlKbHlvMkk0VGFsSnR1MVBsKzBIUTdRM0xweTcvMDJD?=
 =?utf-8?B?bzAvaU9Hb21FMlZXTTlsQm9KSEZIVEtXQ1Y4NjZrb1kydjdiQUdqNDg1N0s2?=
 =?utf-8?B?STZObVhHZ1NlSnFaL1pyTzFZMlNoc2NzUzZNQXZZemhsbXhiN1JMTzNhVlUx?=
 =?utf-8?B?cDI1S0pTTFMyVHdZeHdIRjVzbExCMll0VWs1UjEzbFp2cmM1Tm5nZGVmMW9z?=
 =?utf-8?B?QWF3UzV5cldWTHlyZlgzRFpWcWYzdzJCdUhIQ2VhSmEvUWZON3F3dWRVOTBx?=
 =?utf-8?B?T2tzeTBvaUtydWJscjNZYjRIRk5ZcEFRV0tjcDVoS1NnMTdidko5T1V1QWpu?=
 =?utf-8?B?RThMSHE5QllKUTlaYVpDay9sdFJBZE05dnMyZFZGZVY0KzRJa3o0VXUvT3Yx?=
 =?utf-8?B?Mk1nSWJnUk1CWFBxRk8yV0xvdnV3NDhjcW9BYmJFL0VuckZPRTNRdk1EZUFO?=
 =?utf-8?B?b0lqbkJYZjd2Uk9Fb3dSS200RmNXcGhpcnBsSWtJa3pQMERpZTd4Qm1DdTVu?=
 =?utf-8?B?aEE3dDBDaDYxY2lOVUI0dmxodUFiRUtqNS9CelFQYm5zUUlvT0ZPc3Y3Ullx?=
 =?utf-8?B?N21BWGU1Ylc5TDBhMWRpdXR0SjZNaFkvb3lycXB5QmphVk5UOU1FR2NUeTNs?=
 =?utf-8?B?ejlUTGlHc21ZellhbzhSU3VhMzBFaTU3SnI2eXE5a2xpMzhPeVlTSWJwUHN4?=
 =?utf-8?B?SVJadDZDZ0lidmRHUUExMDBjTTlyb1lhNVJmYnQyNVMyUWI2dEFNeHdOczFX?=
 =?utf-8?B?TksySVdqSSt3NmI5OC9CUEQ0bGFZamZCVTBuTHppTEM4YkQyR3dRUWd2aWd6?=
 =?utf-8?B?QzRMWEJGcnUwVk5YWTRFMHh3clVmU1ZIOGdPWlBlOWtWRjRnZmhKOHFkWm45?=
 =?utf-8?B?bFdRdTJaWEJMNjcrbmJOM1FRYzZPUnFqK2Z1cmMyOWp1TnNHUzFZQm83NGVM?=
 =?utf-8?B?dXlaQWhEdGlFaHFzQVpPQ2RkckNIbWdIZkQyWmJ1SklnL1NYRFFnYTRneE82?=
 =?utf-8?B?N1B0Z0dwNkNvUGlQNXlXQ0N5aGE1Vm50ejhRODhHUTJEOElrZkVoYVU2YnNn?=
 =?utf-8?B?c1J5VEUycTM0cWt1bXFBWmtoNUtVY1BSbmZNUnBSaEFwNXZrSXE3cjZxYllT?=
 =?utf-8?B?Q1RieVFISEVoRVUwUmdscGRJNTVDZ01rWCt3d1k4WVdPcWF0NmJENXY2TmFO?=
 =?utf-8?B?WWx1TEROM01IYVFnUEp2a3lwaDdUV2VmSVFyOEdVQTRVRytVL2lUd0h6clpr?=
 =?utf-8?B?SVRGc3VJMTNLYVlaYXUzeEtRdW5tZmtVYklmMXdJNDc4YU5kWjVHN0lZNEJR?=
 =?utf-8?B?UzF2MFNDWkJ5UjJoNGlSU2pLVHhjUnFXSjUzemNhd2ZRcmdYQ2lTdS9yL3B0?=
 =?utf-8?B?Nm1mdWdXU1JjOExTM3Y3eGJtcjhsUzZJdTZaWFlmcG1OVis5ZVNLWFUrQ3VM?=
 =?utf-8?B?NVBWcjd1Y0xJanVUSk14MWcxRXExcjB5U0JNTlp3bzczV2tXcnZWeWhXUnQ5?=
 =?utf-8?B?Yk5ZYkVWRmlTNVdHdmpZWUFIMDdyeEdrYWNmdlpORDZUNGJDQWlRamtmUUE0?=
 =?utf-8?B?bWxmRUdoWElIWGM3eUlQS0drVUN2V1RUTGZZRXdJSXh2Mm1mbHcrOVVFS3FN?=
 =?utf-8?B?Wnhxc3Q1ZDZ6QWN4SUtGUFNsRjRTSHJuSFgwcWQwNWNVeHZ5U2FpRlEvb0Ix?=
 =?utf-8?B?VEVvcGZYQzVHalhaTjVLY0pCUlpicGttSUlhTm15dnRkMU83am8wRjl2Y2s5?=
 =?utf-8?B?ZnlwdXRhMWlQUFVJWGtlK25LRFB3cm0vRWJkU3ZkMUFwQlk2M0tlNDF0TkM3?=
 =?utf-8?B?bWRlWjMvMS82M0FNR2JWUEpoMCthbUQyb2Z0QkVJcjNZSWlxKzdMVUViYlVC?=
 =?utf-8?B?Tm9IbnpkaE51U3lYTnArL3lTNlZsTzl3bGE5c25FTUxTZDdZKzV2a0RzRXNm?=
 =?utf-8?B?V0pVV2gxaHYzNHBZRjBYZ2h4NGtJRkFLSlpjQWYxSkY5Y0xsY0dDa1N2eW03?=
 =?utf-8?B?U2RyU29TMmVoaDBhRitjaDFrc3JlRXhnTzRPNUtZVVJyMDNZZXM4b0hIekYv?=
 =?utf-8?B?TWROVCtUWWhmNEI4a1NlZThkVjBEYVJTY1dUVXdZMmlWaWRhZjkvUmcyeFRI?=
 =?utf-8?B?dnN3a3ZRVFhIbVAyMnZCSnlPK0NLK1p4QjZ0Z2dwMFJwVG9GK0lLczIrWVNN?=
 =?utf-8?Q?tUot7LIO17gnk0QKjmx5soo=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 89f04d0a-1153-4b01-5e2e-08d9ed755718
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2022 15:44:07.9681
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IJOasxIqPaYJqwajZ2WC7Vk19Mnf4VbsmYe4qxB8XREpiTTbQbqy4P/5A5ngLSNAqkT6YaY/ShCHPiFTbV83Xw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2462
X-OriginatorOrg: citrix.com

On Fri, Feb 11, 2022 at 12:13:38PM +0000, Oleksandr Andrushchenko wrote:
> 
> 
> On 11.02.22 13:40, Roger Pau Monné wrote:
> > On Fri, Feb 11, 2022 at 07:27:39AM +0000, Oleksandr Andrushchenko wrote:
> >> Hi, Roger!
> >>
> >> On 10.02.22 18:16, Roger Pau Monné wrote:
> >>> On Wed, Feb 09, 2022 at 03:36:27PM +0200, Oleksandr Andrushchenko wrote:
> >>>> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> >>>>
> >>>> Introduce a per-domain read/write lock to check whether vpci is present,
> >>>> so we are sure there are no accesses to the contents of the vpci struct
> >>>> if not. This lock can be used (and in a few cases is used right away)
> >>>> so that vpci removal can be performed while holding the lock in write
> >>>> mode. Previously such removal could race with vpci_read for example.
> >>> Sadly there's still a race in the usage of pci_get_pdev_by_domain wrt
> >>> pci_remove_device, and likely when vPCI gets also used in
> >>> {de}assign_device I think.
> >> Yes, this is indeed an issue, but I was not trying to solve it in
> >> context of vPCI locking yet. I think we should discuss how do
> >> we approach pdev locking, so I can create a patch for that.
> >> that being said, I would like not to solve pdev in  this patch yet
> >>
> >> ...I do understand we do want to avoid that, but at the moment
> >> a single reliable way for making sure pdev is alive seems to
> >> be pcidevs_lock....
> > I think we will need to make pcidevs_lock a rwlock and take it in read
> > mode for pci_get_pdev_by_domain.
> >
> > We didn't have this scenario before where PCI emulation is done in the
> > hypervisor, and hence the locking around those data structures has not
> > been designed for those use-cases.
> Yes, I do understand that.
> I hope pcidevs lock move to rwlock can be done as a separate
> patch. While this is not done, do you think we can proceed with
> vPCI series and pcidevs locking re-work being done after?

Ideally we would like to sort out the locking once and for all. I
would like to be sure that what we introduce now doesn't turn out to
interact badly when we decide to look at the pcidevs locking issue.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Feb 11 15:45:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 15:45:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270578.464910 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIY73-0005mh-Qo; Fri, 11 Feb 2022 15:45:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270578.464910; Fri, 11 Feb 2022 15:45:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIY73-0005ma-Nm; Fri, 11 Feb 2022 15:45:33 +0000
Received: by outflank-mailman (input) for mailman id 270578;
 Fri, 11 Feb 2022 15:45:32 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ixe1=S2=arm.com=Luca.Fancellu@srs-se1.protection.inumbo.net>)
 id 1nIY72-0005mM-3h
 for xen-devel@lists.xenproject.org; Fri, 11 Feb 2022 15:45:32 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05on2061c.outbound.protection.outlook.com
 [2a01:111:f400:7e1b::61c])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a3973b33-8b51-11ec-8f75-fffcc8bd4f1a;
 Fri, 11 Feb 2022 16:45:30 +0100 (CET)
Received: from AS8PR04CA0173.eurprd04.prod.outlook.com (2603:10a6:20b:331::28)
 by DB7PR08MB3499.eurprd08.prod.outlook.com (2603:10a6:10:4b::31) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Fri, 11 Feb
 2022 15:45:26 +0000
Received: from VE1EUR03FT025.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:331:cafe::34) by AS8PR04CA0173.outlook.office365.com
 (2603:10a6:20b:331::28) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11 via Frontend
 Transport; Fri, 11 Feb 2022 15:45:26 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT025.mail.protection.outlook.com (10.152.18.74) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4975.11 via Frontend Transport; Fri, 11 Feb 2022 15:45:25 +0000
Received: ("Tessian outbound 18e50a6f0513:v113");
 Fri, 11 Feb 2022 15:45:25 +0000
Received: from 2cea64039e45.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 0691BBB3-C0EC-4B88-8CFE-914A7EC87FD6.1; 
 Fri, 11 Feb 2022 15:45:13 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 2cea64039e45.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 11 Feb 2022 15:45:13 +0000
Received: from VI1PR0801MB2125.eurprd08.prod.outlook.com
 (2603:10a6:800:5b::23) by DB7PR08MB3513.eurprd08.prod.outlook.com
 (2603:10a6:10:4a::17) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Fri, 11 Feb
 2022 15:45:09 +0000
Received: from VI1PR0801MB2125.eurprd08.prod.outlook.com
 ([fe80::704c:5bce:5b39:136d]) by VI1PR0801MB2125.eurprd08.prod.outlook.com
 ([fe80::704c:5bce:5b39:136d%5]) with mapi id 15.20.4951.019; Fri, 11 Feb 2022
 15:45:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a3973b33-8b51-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Vnyqr+qWkFjFNmaWaLvScoHCIQEIOKeGAKRi94FpXhI=;
 b=t97pgbmKZh6xTM3NJv9/tzyAlT4w0YleFTYyHIjJCzMqFqJnYyL/u3FhjsE7dFFtkvawTsuhzu8qkbSEM/g1fXN61DkYVPjjfMIzlEahLNj3skBM9gi+TuDLinhdwaCjTm+o9+3cRS8SYXX1w5OqjPGBuNzFpSRl85zpaw1wXAg=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 24515c21129a0bce
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=amtLo3Y0G2m0PjIteIHjTBDbBr6Qc8LXjA1LQOMy+8Jv20ObLowWW0pK7EtYbevP5dgTzkHRf1Bz47ES7NkfzzW45gpxdKOr+tndPjcrfvV8WmHwpvpbaYhjkrV8sXcEZCP9FaeDUqCrZb+E1ylfeCA/FOLgQ4h4FEdJ1dzu+WnVuP+ukeEpDOqIxglQuUtHL/upM3Fjgthm9U7VVPn6RhjpXj59fmDL+Eu3XW+A/5cxEvjiKoM2fxj9q2/y8IvP+0eMSZ2HSIhNjPBtwd6dr3F84sEqdafEMip5lNLZ1u6NaXorFBKPNwFhv+8+cJ7cdfPSdw4nouCNC7Ex+djTMA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Vnyqr+qWkFjFNmaWaLvScoHCIQEIOKeGAKRi94FpXhI=;
 b=TYI1bbtstGM1vVUaSScwKZ14Lb3a92oe6gm/RcPymV+cmkGED7/+xeqStnm3k9BkbtrGjYneIl9/nj/PZZOgT1UT3BrHzQ5yAVCdXjPki7bJUC45lBO9h3b+iA74gYbvRxVDo8/PfrdUspzDQ/nh3PGZN6PRHheFnnF3B/xqc2N+8q3rDlC4UfgPypS6SG9oRU3p1CNPH3NIBG61m9sGB9Idd9Gk2lCmWHSkpGgQkjxqcKw2QpEFyFnid7Eb5dPXBVNN43IBvWNfOGmZa/331kSUHiDdxpznXizYVPEf/h34kRPziBGvoTvUWxtKmq1fAg+25l0K9WbQjG5d4dzVrg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Vnyqr+qWkFjFNmaWaLvScoHCIQEIOKeGAKRi94FpXhI=;
 b=t97pgbmKZh6xTM3NJv9/tzyAlT4w0YleFTYyHIjJCzMqFqJnYyL/u3FhjsE7dFFtkvawTsuhzu8qkbSEM/g1fXN61DkYVPjjfMIzlEahLNj3skBM9gi+TuDLinhdwaCjTm+o9+3cRS8SYXX1w5OqjPGBuNzFpSRl85zpaw1wXAg=
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
Content-Type: text/plain;
	charset=us-ascii
Subject: Re: [RFC PATCH] arm/vgic-v3: provide custom callbacks for
 pend_lpi_tree radix tree
From: Luca Fancellu <luca.fancellu@arm.com>
In-Reply-To: <81a2f978-9337-2e58-c8b2-86dc7defc2ec@xen.org>
Date: Fri, 11 Feb 2022 15:45:06 +0000
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
 wei.chen@arm.com,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <1A16E009-F34C-4C6B-ABF6-FC08E395EABE@arm.com>
References: <20220211150042.11972-1-luca.fancellu@arm.com>
 <81a2f978-9337-2e58-c8b2-86dc7defc2ec@xen.org>
To: Julien Grall <julien@xen.org>
X-Mailer: Apple Mail (2.3693.60.0.1.1)
X-ClientProxiedBy: LO4P123CA0014.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:150::19) To VI1PR0801MB2125.eurprd08.prod.outlook.com
 (2603:10a6:800:5b::23)
MIME-Version: 1.0
X-MS-Office365-Filtering-Correlation-Id: 20d55dae-d292-463e-719f-08d9ed758573
X-MS-TrafficTypeDiagnostic:
	DB7PR08MB3513:EE_|VE1EUR03FT025:EE_|DB7PR08MB3499:EE_
X-Microsoft-Antispam-PRVS:
	<DB7PR08MB3499CFFFC9E943692EC79B1BE4309@DB7PR08MB3499.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 aoSQT2ab/Apu5PFP0t0cmgQXqdjQ7Z9xB/1dxupkz2SWCUXk1W/7oW//iH646Y8tizU2HZEbnn0iAghERe0+FxN6+5zuL6SVgoyZeg4Zfu456YiUqOxq8ix0e94scMrsexhJ3U1+AdyeC71hQdgy5SO1N6hfTPeEt/mEm7ynfOhd3+lgBYszGUpBg9H5j7hPCN1crwLAvM44D9mGgMNs5tPKe3Hq4sH1NnyRYBqVPBcIfHUxj0RFdsmhqacQj50xNxSoj5v6aYJXRWRQVAaG7Gah1DGS51fR40ESemC+K6qA7Ap7vCfHK7apWEsUybiQPbIYKGd/tCHGU3bU3YAvKp+Zp6AhEGGPCbWCM6y8igIfY/uESXeRNSs8dZIrkt076RUH4uazWb/udsscy8Cuhw5IbfV9zC0wuEfL9+VP0QOSb2Nrf1fHEEKIwY2mErKj0YTQei6TWlV19qe8Pm926pOI9syHFbyPjf+pIl86T18gx8zc+rX3g+NVsnQYWbEk3Wy+Hbz3tGKp8j7kYQZu1XGsu3xU+om5D5y3yYekQy1w6hDAf7SYM8TwgujbFz0YmwuvmscKKE3pSrMjcTIdO6tYaiJtg3flVxoaPAiyUDnM0n91STm2qm3/h5x6csoMjafyAee8H7uZkOvkvn5tGERw8KGwHlrax/b7EOS7M/y5ZiuKDbvBCjfiZ4njKFOlhniZHJ+lbIOu7DkKtp5cwcHY9zHVRKdmEKv7TVu/Veg=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR0801MB2125.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(4326008)(186003)(26005)(83380400001)(66556008)(66476007)(66946007)(38100700002)(8936002)(44832011)(86362001)(5660300002)(6916009)(36756003)(6666004)(6486002)(2906002)(6506007)(54906003)(33656002)(508600001)(6512007)(38350700002)(52116002)(2616005)(316002)(53546011)(8676002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3513
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT025.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	2e45bb8d-61d2-41ed-567a-08d9ed757b95
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	fsSOCd5GbBVxJM8TQUXXa7TO9O1HuhVOZuNDAjLXqh8oxpJspdzNAYX3mQs08dpJ6oEkHGAScX3Zwg+OmCeV0CFB1AxsaT9DxEg/XsaYp1aYLkawnyAi1n6ElrGMkrwIS8i2gcLJwnCVTl9fhlWnfG47YqMjj6wFKKhksGRtTpj4M1CZ7SFhHuimlIDCTpfUgJeBGxfXjvXfzyhPrQ8hYmsrYzbxKbI6gl8i3Dd08CTIu2Emn1jGSxVnq+9gdLylrW6WkKJE5YHCh+/J+rRhZrK9HFqIWc8yoVIl8RyLnuej1dL7eMPXSVIio53MFEDiQ/IKn/P2GNy3X+EomxTu70UC9n61yOo14ckvyK/pwxiFqT4U3ARiXPyYE0IRo9iLHJAmBDS1pxpej29aS165x34id8QxQ9UfUHKSPc7FehOCOsNfBbOBdJ3bgJ5u/GTBYBpOlyvxUkVMfPWyU+it8hS2231iit+eLbmUAji7X01r7Ly77DRlWx0JPtilEjWDY58tIe8B0AAk3GHcyN7AdxVFsDtXZ3QfU5CW0RlAwQ2EJUPibXL+Rvd26h6koRqe6dT/EaZRnjS1TZNoRp8y2x9hp8t9iDbzCAaN320HX5maLnRwzfVAjvISroZgPjLvHL7SZMkZEB93HyD9tJHUP5/Ozv58vdpGdrcR2LgCDcTGgDLXzYrd1wvVY3z7pinp
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(8676002)(6862004)(4326008)(70586007)(70206006)(53546011)(6512007)(54906003)(8936002)(36860700001)(2906002)(5660300002)(316002)(6506007)(508600001)(86362001)(6486002)(6666004)(40460700003)(47076005)(26005)(2616005)(44832011)(81166007)(356005)(336012)(83380400001)(186003)(82310400004)(36756003)(33656002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2022 15:45:25.4424
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 20d55dae-d292-463e-719f-08d9ed758573
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT025.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3499



> On 11 Feb 2022, at 15:26, Julien Grall <julien@xen.org> wrote:
>=20
> Hi Luca,
>=20
> On 11/02/2022 15:00, Luca Fancellu wrote:
>> pend_lpi_tree is a radix tree used to store pending irqs, the tree is
>> protected by a lock for read/write operations.
>> Currently the radix tree default function to free items uses the
>> RCU mechanism, calling call_rcu and deferring the operation.
>> However every access to the structure is protected by the lock so we
>> can avoid using the default free function that, by using RCU,
>> increases memory usage and impacts the predictability of the system.
>=20
> I understand goal but looking at the implementation of vgic_v3_lpi_to_pen=
ding() (Copied below for convenience). We would release the lock as soon as=
 the look-up finish, yet the element is returned.
>=20
> static struct pending_irq *vgic_v3_lpi_to_pending(struct domain *d,
>                                                  unsigned int lpi)
> {
>    struct pending_irq *pirq;
>=20
>    read_lock(&d->arch.vgic.pend_lpi_tree_lock);
>    pirq =3D radix_tree_lookup(&d->arch.vgic.pend_lpi_tree, lpi);
>    read_unlock(&d->arch.vgic.pend_lpi_tree_lock);
>=20
>    return pirq;
> }
>=20
> So the lock will not protect us against removal. If you want to drop the =
RCU, you will need to ensure the structure pending_irq is suitably protecte=
d. I haven't check whether there are other locks that may suit us here.
>=20

Hi Julien,

Yes you are right! I missed that, sorry for the noise.

Cheers,
Luca

> Cheers,
>=20
> --=20
> Julien Grall



From xen-devel-bounces@lists.xenproject.org Fri Feb 11 15:48:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 15:48:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270588.464921 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIYAE-0006Xl-Fw; Fri, 11 Feb 2022 15:48:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270588.464921; Fri, 11 Feb 2022 15:48:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIYAE-0006Xe-Ck; Fri, 11 Feb 2022 15:48:50 +0000
Received: by outflank-mailman (input) for mailman id 270588;
 Fri, 11 Feb 2022 15:47:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Ifew=S2=linux.intel.com=srinivas.pandruvada@srs-se1.protection.inumbo.net>)
 id 1nIY8c-0006V5-FV
 for xen-devel@lists.xenproject.org; Fri, 11 Feb 2022 15:47:10 +0000
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id dcac54c6-8b51-11ec-8f75-fffcc8bd4f1a;
 Fri, 11 Feb 2022 16:47:07 +0100 (CET)
Received: from orsmga008.jf.intel.com ([10.7.209.65])
 by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 11 Feb 2022 07:46:52 -0800
Received: from ankitata-mobl1.amr.corp.intel.com (HELO
 spandruv-desk1.amr.corp.intel.com) ([10.212.170.20])
 by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 11 Feb 2022 07:46:51 -0800
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dcac54c6-8b51-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
  d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
  t=1644594427; x=1676130427;
  h=message-id:subject:from:to:date:in-reply-to:references:
   mime-version:content-transfer-encoding;
  bh=pVxiaW+vV0quQ79sfEqbYXTjlLZHvVBgUsqT5Tk+lEY=;
  b=GZ4Jw9NuIjrxD3kvZ8YYjDICHW1THznaLD4AcksdQsl1saARH7MhpDZQ
   shPkeSj9i7XfkHlMWK5OHj36yscUVxhWMIXVZTq+da+Ugim5c4usuzFli
   wdHBtxmrpNpdXZfx8Sn8iH2fmN6uC54G/MTOmnmFUocBX3+VeleNZ0Jxw
   pYscTCUwJyLvrxmPAWajgkYeLnN/p+cwrFIhFeHEY7tSGs+dsopJRklX2
   1GR/8syo+ecv9HDuUcPDuRL78DBnWjgANS8gyIH4LQUeAYpCezF+Zcumf
   6ACCqNevuG6xX80GRieeFP+b99N763V8HzLun1idCRp6/psjGCaFsEfzy
   A==;
X-IronPort-AV: E=McAfee;i="6200,9189,10254"; a="274310314"
X-IronPort-AV: E=Sophos;i="5.88,361,1635231600"; 
   d="scan'208";a="274310314"
X-IronPort-AV: E=Sophos;i="5.88,361,1635231600"; 
   d="scan'208";a="542134195"
Message-ID: <077501bfcb710c66754c61d69e45cac66fccf38a.camel@linux.intel.com>
Subject: Re: [PATCH V2 5/13] hid: use time_is_after_jiffies() instead of
 jiffies judgment
From: srinivas pandruvada <srinivas.pandruvada@linux.intel.com>
To: Qing Wang <wangqing@vivo.com>, Konrad Rzeszutek Wilk
 <konrad.wilk@oracle.com>, Roger Pau =?ISO-8859-1?Q?Monn=E9?=
 <roger.pau@citrix.com>, Jens Axboe <axboe@kernel.dk>, Michael Turquette
 <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, Jani Nikula
 <jani.nikula@linux.intel.com>, Joonas Lahtinen
 <joonas.lahtinen@linux.intel.com>,  Rodrigo Vivi <rodrigo.vivi@intel.com>,
 David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,  Alex
 Deucher <alexander.deucher@amd.com>, Christian =?ISO-8859-1?Q?K=F6nig?=
 <christian.koenig@amd.com>,  "Pan, Xinhui" <Xinhui.Pan@amd.com>, Jiri
 Kosina <jikos@kernel.org>, Benjamin Tissoires
 <benjamin.tissoires@redhat.com>, Dmitry Torokhov
 <dmitry.torokhov@gmail.com>,  Alasdair Kergon <agk@redhat.com>, Mike
 Snitzer <snitzer@redhat.com>, dm-devel@redhat.com,  Mauro Carvalho Chehab
 <mchehab@kernel.org>, Hans Verkuil <hverkuil@xs4all.nl>, 
 xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, 
 linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, 
 intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, 
 amd-gfx@lists.freedesktop.org, linux-input@vger.kernel.org, 
 linux-media@vger.kernel.org
Date: Fri, 11 Feb 2022 07:46:51 -0800
In-Reply-To: <1644546640-23283-6-git-send-email-wangqing@vivo.com>
References: <1644546640-23283-1-git-send-email-wangqing@vivo.com>
	 <1644546640-23283-6-git-send-email-wangqing@vivo.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.42.3 (3.42.3-1.fc35) 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

On Thu, 2022-02-10 at 18:30 -0800, Qing Wang wrote:
> From: Wang Qing <wangqing@vivo.com>
> 
> It is better to use time_xxx() directly instead of jiffies judgment
> for understanding.
> 
> Signed-off-by: Wang Qing <wangqing@vivo.com>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>

> ---
>  drivers/hid/intel-ish-hid/ipc/ipc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/intel-ish-hid/ipc/ipc.c b/drivers/hid/intel-
> ish-hid/ipc/ipc.c
> index 8ccb246..15e1423
> --- a/drivers/hid/intel-ish-hid/ipc/ipc.c
> +++ b/drivers/hid/intel-ish-hid/ipc/ipc.c
> @@ -578,7 +578,7 @@ static void _ish_sync_fw_clock(struct
> ishtp_device *dev)
>         static unsigned long    prev_sync;
>         uint64_t        usec;
>  
> -       if (prev_sync && jiffies - prev_sync < 20 * HZ)
> +       if (prev_sync && time_is_after_jiffies(prev_sync + 20 * HZ))
>                 return;
>  
>         prev_sync = jiffies;



From xen-devel-bounces@lists.xenproject.org Fri Feb 11 16:12:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 16:12:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270596.464933 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIYXC-0001lk-F7; Fri, 11 Feb 2022 16:12:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270596.464933; Fri, 11 Feb 2022 16:12:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIYXC-0001ld-Am; Fri, 11 Feb 2022 16:12:34 +0000
Received: by outflank-mailman (input) for mailman id 270596;
 Fri, 11 Feb 2022 16:12:32 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nIYXA-0001lW-NJ
 for xen-devel@lists.xenproject.org; Fri, 11 Feb 2022 16:12:32 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nIYXA-0003ac-A4; Fri, 11 Feb 2022 16:12:32 +0000
Received: from 54-240-197-235.amazon.com ([54.240.197.235]
 helo=[192.168.30.126]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nIYXA-0004c5-4M; Fri, 11 Feb 2022 16:12:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=HoFjDlOCW3H9Xicd1JAfQbuaSoHiZfdJ/a+X3qLrYU0=; b=gKud3CIhU62loXyISUI/AJDAkv
	HkDNok6aWGFdLHx/HeqimyInR6XycHPy25He6URO6hQP4+IiVMN7Q+7otQIuSxZbIt2xwZQf1sSpb
	e+ogQXjG16/OC5mBJuYaEFmcoFwrPMSNKLD9FBZgK6yaDKRW4bgpM4hLQzd3vRs8FYBw=;
Message-ID: <9eb5072b-6c55-7df1-75a3-c96594d64277@xen.org>
Date: Fri, 11 Feb 2022 16:12:30 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.0
Subject: Re: [RFC PATCH] arm/vgic-v3: provide custom callbacks for
 pend_lpi_tree radix tree
To: Luca Fancellu <luca.fancellu@arm.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>, wei.chen@arm.com,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <20220211150042.11972-1-luca.fancellu@arm.com>
 <81a2f978-9337-2e58-c8b2-86dc7defc2ec@xen.org>
 <1A16E009-F34C-4C6B-ABF6-FC08E395EABE@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <1A16E009-F34C-4C6B-ABF6-FC08E395EABE@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit



On 11/02/2022 15:45, Luca Fancellu wrote:
> 
> 
>> On 11 Feb 2022, at 15:26, Julien Grall <julien@xen.org> wrote:
>>
>> Hi Luca,
>>
>> On 11/02/2022 15:00, Luca Fancellu wrote:
>>> pend_lpi_tree is a radix tree used to store pending irqs, the tree is
>>> protected by a lock for read/write operations.
>>> Currently the radix tree default function to free items uses the
>>> RCU mechanism, calling call_rcu and deferring the operation.
>>> However every access to the structure is protected by the lock so we
>>> can avoid using the default free function that, by using RCU,
>>> increases memory usage and impacts the predictability of the system.
>>
>> I understand goal but looking at the implementation of vgic_v3_lpi_to_pending() (Copied below for convenience). We would release the lock as soon as the look-up finish, yet the element is returned.
>>
>> static struct pending_irq *vgic_v3_lpi_to_pending(struct domain *d,
>>                                                   unsigned int lpi)
>> {
>>     struct pending_irq *pirq;
>>
>>     read_lock(&d->arch.vgic.pend_lpi_tree_lock);
>>     pirq = radix_tree_lookup(&d->arch.vgic.pend_lpi_tree, lpi);
>>     read_unlock(&d->arch.vgic.pend_lpi_tree_lock);
>>
>>     return pirq;
>> }
>>
>> So the lock will not protect us against removal. If you want to drop the RCU, you will need to ensure the structure pending_irq is suitably protected. I haven't check whether there are other locks that may suit us here.
>>
> 
> Hi Julien,
> 
> Yes you are right! I missed that, sorry for the noise.

Actually,... I think I am wrong :/.

I thought the lock pend_lpi_tre_lock would protect pending_irq, but it 
only protects the radix tree element (not the value).

The use in its_discard_event() seems to confirm that because the
pending_irq is re-initialized as soon as it gets destroyed.

I would like a second opinion though.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Feb 11 16:14:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 16:14:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270602.464943 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIYYo-0002L4-PT; Fri, 11 Feb 2022 16:14:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270602.464943; Fri, 11 Feb 2022 16:14:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIYYo-0002Kx-Mf; Fri, 11 Feb 2022 16:14:14 +0000
Received: by outflank-mailman (input) for mailman id 270602;
 Fri, 11 Feb 2022 16:14:13 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=SRLR=S2=kernel.org=helgaas@srs-se1.protection.inumbo.net>)
 id 1nIYYn-0002Kn-6L
 for xen-devel@lists.xenproject.org; Fri, 11 Feb 2022 16:14:13 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a4e1d34f-8b55-11ec-8f75-fffcc8bd4f1a;
 Fri, 11 Feb 2022 17:14:10 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 375CF60F0B;
 Fri, 11 Feb 2022 16:14:09 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 45745C340E9;
 Fri, 11 Feb 2022 16:14:08 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a4e1d34f-8b55-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1644596048;
	bh=XREO/vHXAOv2lzh893fJ6xMwvKK3WUm+gggcHq0vKp0=;
	h=Date:From:To:Cc:Subject:In-Reply-To:From;
	b=LXLOGAMvDQ33vZawEwa4mVqilZaLr10bwMntw+1iw3exUxZInn2n/T9lrXNvNwrrL
	 0zxjqbjSHBCvX5Qf/cjMnNasn7nEMRR6XIJlozJLOgdvuQwBY5faHSO0ChxR4eM8Y2
	 Zb6Oy7q//i9FNdhShP5ZSQz2qE8becZOH4isLfLfrKnILrOlYCAB2uBFl2KKgPeTgG
	 6EeD25WCeAFQxCoTM4QE4eEV+MDz/TmCDoH7jyJ+Avnl/WwyFcfKdWStIOKZwZODnS
	 V/r3Ep9MHnCnA9v5b6Gi912vRAnBdCEghvLpcTguoxK28EN7NWcraUkB1tW8BWyfEi
	 vH8CM9fS9dRlw==
Date: Fri, 11 Feb 2022 10:14:06 -0600
From: Bjorn Helgaas <helgaas@kernel.org>
To: Josef Johansson <josef@oderland.se>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Bjorn Helgaas <bhelgaas@google.com>, linux-pci@vger.kernel.org,
	xen-devel <xen-devel@lists.xenproject.org>,
	Jason Gunthorpe <jgg@nvidia.com>
Subject: Re: [PATCH] PCI/MSI: msix_setup_msi_descs: Restore logic for
 msi_attrib.can_mask
Message-ID: <20220211161406.GA714343@bhelgaas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <69d705f3-8e0d-31b7-9a80-4413b8dbe7a3@oderland.se>

On Fri, Feb 11, 2022 at 01:10:22AM +0100, Josef Johansson wrote:
> On 2/11/22 00:55, Bjorn Helgaas wrote:
> > On Sat, Jan 22, 2022 at 02:10:01AM +0100, Josef Johansson wrote:
> >> From: Josef Johansson <josef@oderland.se>
> >>
> >> PCI/MSI: msix_setup_msi_descs: Restore logic for msi_attrib.can_mask
> > Please match the form and style of previous subject lines (in
> > particular, omit "msix_setup_msi_descs:").
> Would this subject suffice?
> PCI/MSI: Correct use of can_mask in msi_add_msi_desc()

Looks good to me!

Bjorn


From xen-devel-bounces@lists.xenproject.org Fri Feb 11 18:26:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 18:26:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270615.464954 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIach-000628-2P; Fri, 11 Feb 2022 18:26:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270615.464954; Fri, 11 Feb 2022 18:26:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIacg-000621-Vo; Fri, 11 Feb 2022 18:26:22 +0000
Received: by outflank-mailman (input) for mailman id 270615;
 Fri, 11 Feb 2022 18:26:21 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=tVj4=S2=linaro.org=alex.bennee@srs-se1.protection.inumbo.net>)
 id 1nIacf-00061v-Oi
 for xen-devel@lists.xenproject.org; Fri, 11 Feb 2022 18:26:21 +0000
Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com
 [2a00:1450:4864:20::635])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1b19045c-8b68-11ec-8f75-fffcc8bd4f1a;
 Fri, 11 Feb 2022 19:26:19 +0100 (CET)
Received: by mail-ej1-x635.google.com with SMTP id e7so20564316ejn.13
 for <xen-devel@lists.xenproject.org>; Fri, 11 Feb 2022 10:26:19 -0800 (PST)
Received: from zen.linaroharston ([51.148.130.216])
 by smtp.gmail.com with ESMTPSA id a19sm6342921ejt.7.2022.02.11.10.26.17
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 11 Feb 2022 10:26:17 -0800 (PST)
Received: from zen (localhost [127.0.0.1])
 by zen.linaroharston (Postfix) with ESMTP id 9F5141FFB7;
 Fri, 11 Feb 2022 18:26:16 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1b19045c-8b68-11ec-8f75-fffcc8bd4f1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=references:user-agent:from:to:cc:subject:date:in-reply-to
         :message-id:mime-version:content-transfer-encoding;
        bh=BEQerwhm5Wp0S3tjCPAtRdmBeDWl6qB2J4pcBvnrW9s=;
        b=izrxAqKMMH8Rr8pCgmTm2MAVFBdvp+rztTtvm7lXOlc2RqAOtHWy1PSpYohQ1vpq49
         uak8gsSQTQLL7RGXRLgLpKDG0Z7HGuluOvgYpmEl2+WAR4JmuouvkpM7qRA6pXMTs+d9
         lpZumeq3tOnh8YcKpxMRMXpsVx8bGAD6KANpygnZSZrJ+qGS4zcfSTvGTx2fz7BX/drd
         mWEMs+jxAI8qG/XKFFMq0kk/tUMKzMnKflxiha1mvvyjQ3EFTj2+2Z5+oQEcQYnS2hNL
         0xmta6O02h1VxwjtW3hCiG/+ZByUaPaPavBLTX96WAxCSX0LIFiDQPaGIBFhA558r/Xl
         YhhA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:references:user-agent:from:to:cc:subject:date
         :in-reply-to:message-id:mime-version:content-transfer-encoding;
        bh=BEQerwhm5Wp0S3tjCPAtRdmBeDWl6qB2J4pcBvnrW9s=;
        b=pUQpty22QX9pcybVo9XaOVgTIYXNB2JdupqobKrpvfeyJ6Fn7aEkiV88yevnsLCljo
         US+oE+qhBg97bjMiKueU+UlMB96CcBkaUzIpyHz2zN5P5R/QdiaMFX+Cs/QfRU4Hn5Gl
         qvJ281rSzEWX0imVz/R8GOx1janaM7sgXuWDVODijS2FCdU5EjaMkCEOnbLDPK+XgWL+
         Q3nP8fE/HVlNsgaXWIg/xpA0ggBlCYA4dVdYdvhwSaiPAAcRQJJQGJOsiQuX7sKKbqB8
         hyyFdHZWwk4h+NeBIx/hEwHjSli+rT3wKnK2vI19b3GWGufJ9XLNUeCr2myfSEDtZGFP
         uiwQ==
X-Gm-Message-State: AOAM533h/tPxWeSp1NpL2OKcCvW/3mvn1WWep42wE/6CvWMy6RFrWs5F
	zxalEiBuLg9yAgZLn9sBP31oGA==
X-Google-Smtp-Source: ABdhPJznsKIixGZnvshYn8SwxIZ8Rf6/+8SM7aEkKYG5T699wm6BxxHROaBvQIv2s6ireOkVAFpeow==
X-Received: by 2002:a17:907:90d5:: with SMTP id gk21mr2384157ejb.633.1644603978353;
        Fri, 11 Feb 2022 10:26:18 -0800 (PST)
References: <87h79bgd1m.fsf@linaro.org>
 <alpine.DEB.2.22.394.2202071419270.2091381@ubuntu-linux-20-04-desktop>
User-agent: mu4e 1.7.7; emacs 28.0.91
From: Alex =?utf-8?Q?Benn=C3=A9e?= <alex.bennee@linaro.org>
To: Stefano Stabellini <stefano.stabellini@xilinx.com>
Cc: Vincent Guittot <vincent.guittot@linaro.org>,
 stratos-dev@op-lists.linaro.org, xen-devel@lists.xenproject.org, AKASHI
 Takahiro <takahiro.akashi@linaro.org>, Arnd Bergmann
 <arnd.bergmann@linaro.org>, Christopher Clark
 <christopher.w.clark@gmail.com>, Dmytro Firsov <dmytro_firsov@epam.com>,
 Julien Grall <julien@xen.org>, Volodymyr Babchuk
 <Volodymyr_Babchuk@epam.com>, Oleksandr_Tyshchenko@epam.com,
 Artem_Mygaiev@epam.com, bertrand.marquis@arm.com, Wei.Chen@arm.com,
 Ed.Doxat@arm.com, Oleksii_Moisieiev@epam.com
Subject: Re: Metadata and signalling channels for Zephyr virtio-backends on Xen
Date: Fri, 11 Feb 2022 18:20:30 +0000
In-reply-to: <alpine.DEB.2.22.394.2202071419270.2091381@ubuntu-linux-20-04-desktop>
Message-ID: <87k0e1cl9z.fsf@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


Stefano Stabellini <stefano.stabellini@xilinx.com> writes:

> On Mon, 7 Feb 2022, Alex Benn=C3=A9e wrote:
>> Hi Stefano,
>>=20
>> Vincent gave an update on his virtio-scmi work at the last Stratos sync
>> call and the discussion moved onto next steps.
>
> Hi Alex,
>
> I don't know the specifics of virtio-scmi, but if it is about power,
> clocks, reset, etc. like the original SCMI protocol, then virtio-scmi is
> likely going to be very different from all the other virtio frontends
> and backends. That's because SCMI requires a full view of the system,
> which is different from something like virtio-net that is limited to the
> emulation of 1 device. For this reason, it is likely that the
> virtio-scmi backend would be a better fit in Xen itself, rather than run
> in userspace inside a VM.

That may be a good solution for Xen but I still think it's worthwhile
being able to package SCMI in a VM for other hypervisors. We are just
happening to use Xen as a nice type-1 example.

Vincents SCMI server code is portable anyway and can reside in a Zephyr
app, firmware blob or a userspace vhost-user client.

> FYI, a good and promising approach to handle both SCMI and SCPI is the
> series recently submitted by EPAM to mediate SCMI and SCPI requests in
> Xen: https://marc.info/?l=3Dxen-devel&m=3D163947444032590
>
> (Another "special" virtio backend is virtio-iommu for similar reasons:
> the guest p2m address mappings and also the IOMMU drivers are in Xen.
> It is not immediately clear whether a virtio-iommu backend would need to
> be in Xen or run as a process in dom0/domU.)
>
> On the other hand, for all the other "normal" protocols (e.g.
> virtio-net, virtio-block, etc.) the backend would naturally run as a
> process in dom0 or domU (e.g. QEMU in Dom0) as one would expect.

Can domU's not be given particular access to HW they might want to
tweak? I assume at some point a block device backend needs to actually
talk to real HW to store the blocks (even if in most cases it would be a
kernel doing the HW access on it's behalf).

>> Currently the demo setup
>> is intermediated by a double-ended vhost-user daemon running on the
>> devbox acting as a go between a number of QEMU instances representing
>> the front and back-ends. You can view the architecture with Vincents
>> diagram here:
>>=20
>>   https://docs.google.com/drawings/d/1YSuJUSjEdTi2oEUq4oG4A9pBKSEJTAp6hh=
cHKKhmYHs/edit?usp=3Dsharing
>>=20
>> The key virtq handling is done over the special carve outs of shared
>> memory between the front end and guest. However the signalling is
>> currently over a virtio device on the backend. This is useful for the
>> PoC but obviously in a real system we don't have a hidden POSIX system
>> acting as a go between not to mention the additional latency it causes
>> with all those context switches.
>>=20
>> I was hoping we could get some more of the Xen experts to the next
>> Stratos sync (17th Feb) to go over approaches for a properly hosted on
>> Xen approach. From my recollection (Vincent please correct me if I'm
>> wrong) of last week the issues that need solving are:
>
> Unfortunately I have a regular conflict which prevents me from being
> able to join the Stratos calls. However, I can certainly make myself
> available for one call (unless something unexpected comes up).
>
>
>>  * How to handle configuration steps as FE guests come up
>>=20
>> The SCMI server will be a long running persistent backend because it is
>> managing real HW resources. However the guests may be ephemeral (or just
>> restarted) so we can't just hard-code everything in a DTB. While the
>> virtio-negotiation in the config space covers most things we still need
>> information like where in the guests address space the shared memory
>> lives and at what offset into that the queues are created. As far as I'm
>> aware the canonical source of domain information is XenStore
>> (https://wiki.xenproject.org/wiki/XenStore) but this relies on a Dom0
>> type approach. Is there an alternative for dom0less systems or do we
>> need a dom0-light approach, for example using STR-21 (Ensure Zephyr can
>> run cleanly as a Dom0 guest) providing just enough services for FE's to
>> register metadata and BE's to read it?
>
> I'll try to answer the question for a generic virtio frontend and
> backend instead (not SCMI because SCMI is unique due to the reasons
> above.)
>
> Yes, xenstore is the easiest way to exchange configuration information
> between domains. I think EPAM used xenstore to exchange the
> configuration information in their virtio-block demo. There is a way to
> use xenstore even between dom0less VMs:
> https://marc.info/?l=3Dxen-devel&m=3D164340547602391 Not just xenstore but
> full PV drivers too. However, in the dom0less case xenstore is going to
> become available some time after boot, not immediately at startup time.
> That's because you need to wait until xenstored is up and running.
>
> There are other ways to send data from one VM to another which are
> available immediately at boot, such as Argo and static shared memory.
>
> But dom0less is all about static partitioning, so it makes sense to
> exploit the build-time tools to the fullest. In the dom0less case, we
> already know what is going to run on the target before it is even turned
> on. As an example, we might have already prepared an environment with 3
> VMs using Yocto and ImageBuilder. We could also generate all
> configurations needed and place them inside each VMs using Yocto's
> standard tools and ImageBuilder. So for dom0less, I recommend to go via
> a different route and pre-generate the configuration directly where
> needed instead of doing dynamic discovery.

Even in a full dom0less setup you still need to manage lifetimes somehow
if a guest reboots.

>
>
>>  * How to handle mapping of memory
>>=20
>> AIUI the Xen model is the FE guest explicitly makes grant table requests
>> to expose portions of it's memory to other domains. Can the BE query the
>> hypervisor itself to discover the available grants or does it require
>> coordination with Dom0/XenStore for that information to be available to
>> the BE domain?
>
> Typically the frontend passes grant table references to the backend
> (i.e. instead of plain guest physical addresses on the virtio ring.)
> Then, the backend maps the grants; Xen checks that the mapping is
> allowed.
>
> We might be able to use the same model with virtio devices. A special
> pseudo-IOMMU driver in Linux would return a grant table reference and an
> offset as "DMA address". The "DMA address" is passed to the virtio
> backend over the virtio ring. The backend would map the grant table
> reference using the regular grant table hypercalls.
>
>
>>  * How to handle signalling
>>=20
>> I guess this requires a minimal implementation of the IOREQ calls for
>> Zephyr so we can register the handler in the backend? Does the IOREQ API
>> allow for a IPI style notifications using the global GIC IRQs?
>>=20
>> Forgive the incomplete notes from the Stratos sync, I was trying to type
>> while participating in the discussion so hopefully this email captures
>> what was missed:
>>=20
>>   https://linaro.atlassian.net/wiki/spaces/STR/pages/28682518685/2022-02=
-03+Project+Stratos+Sync+Meeting+Notes
>
> Yes, any emulation backend (including virtio backends) would require an
> IOREQ implementation, which includes notifications via event channels.
> Event channels are delivered as a GIC PPI interrupt to the Linux kernel.
> Then, the kernel sends the notification to userspace via a file
> descriptor.

Thanks.

--=20
Alex Benn=C3=A9e


From xen-devel-bounces@lists.xenproject.org Fri Feb 11 23:15:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 23:15:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270665.464987 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIf8a-0007Wa-1O; Fri, 11 Feb 2022 23:15:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270665.464987; Fri, 11 Feb 2022 23:15:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIf8Z-0007WT-UE; Fri, 11 Feb 2022 23:15:35 +0000
Received: by outflank-mailman (input) for mailman id 270665;
 Fri, 11 Feb 2022 23:15:34 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nIf8Y-0007WJ-0l; Fri, 11 Feb 2022 23:15:34 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nIf8X-0002lU-Th; Fri, 11 Feb 2022 23:15:33 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nIf8X-0007vk-Cd; Fri, 11 Feb 2022 23:15:33 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nIf8X-000652-B1; Fri, 11 Feb 2022 23:15:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=XyIEuoNYzh9Gc+rMZWeTGgv4VhHMuOkJkpATNIX7NFM=; b=1GmE6DbVXtu97OjZPBzalY7TJ7
	StrO2Zy/X5tNAVxcBk4WDeQ9ePbVgzvDoIee0CIL97uyUbct04knMPFw9LwMpaA8UbC9yRuSp/YsY
	wdNIbJidBwktEPP/MG9tXWAUCHLilh0ksWKqq8orU9O17kemjLKYUaqE8PIYs8kNhPQc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168085-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-5.4 test] 168085: trouble: blocked/broken/fail/pass
X-Osstest-Failures:
    linux-5.4:build-arm64:<job status>:broken:regression
    linux-5.4:build-arm64-pvops:<job status>:broken:regression
    linux-5.4:build-arm64-xsm:<job status>:broken:regression
    linux-5.4:build-arm64-pvops:host-install(4):broken:regression
    linux-5.4:build-arm64-xsm:host-install(4):broken:regression
    linux-5.4:build-arm64:host-install(4):broken:regression
    linux-5.4:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-arm64-arm64-examine:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-xl:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking
    linux-5.4:build-arm64-libvirt:build-check(1):blocked:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=52871671099d1bb3fca5ed076029e4b937bfc053
X-Osstest-Versions-That:
    linux=76fd334f07cc11e047c2237a19b2cf8b1f653ba2
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 11 Feb 2022 23:15:33 +0000

flight 168085 linux-5.4 real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168085/

Failures and problems with tests :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-arm64                     <job status>                 broken
 build-arm64-pvops               <job status>                 broken
 build-arm64-xsm                 <job status>                 broken
 build-arm64-pvops             4 host-install(4)        broken REGR. vs. 168060
 build-arm64-xsm               4 host-install(4)        broken REGR. vs. 168060
 build-arm64                   4 host-install(4)        broken REGR. vs. 168060

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 168084
 test-armhf-armhf-xl-rtds     18 guest-start/debian.repeat  fail pass in 168084

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-examine      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl           1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit1   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit2   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-seattle   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-thunderx  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-vhd       1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-xsm       1 build-check(1)               blocked  n/a
 build-arm64-libvirt           1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168060
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168060
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168060
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168060
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168060
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168060
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168060
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168060
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168060
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168060
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168060
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168060
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 linux                52871671099d1bb3fca5ed076029e4b937bfc053
baseline version:
 linux                76fd334f07cc11e047c2237a19b2cf8b1f653ba2

Last test of basis   168060  2022-02-08 17:43:16 Z    3 days
Testing same since   168084  2022-02-11 08:43:38 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Florian Fainelli <f.fainelli@gmail.com>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Guenter Roeck <linux@roeck-us.net>
  Jon Hunter <jonathanh@nvidia.com>
  Jon Maloy <jmaloy@redhat.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Linux Kernel Functional Testing <lkft@linaro.org>
  Shuah Khan <skhan@linuxfoundation.org>
  Slade Watkins <slade@sladewatkins.com>
  Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
  Ulf Hansson <ulf.hansson@linaro.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              broken  
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  broken  
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          blocked 
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            broken  
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          blocked 
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      blocked 
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  blocked 
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  blocked 
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     blocked 
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 blocked 
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      blocked 
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary

broken-job build-arm64 broken
broken-job build-arm64-pvops broken
broken-job build-arm64-xsm broken
broken-step build-arm64-pvops host-install(4)
broken-step build-arm64-xsm host-install(4)
broken-step build-arm64 host-install(4)
broken-job build-arm64-xsm broken
broken-job build-arm64-pvops broken
broken-job build-arm64 broken

Not pushing.

------------------------------------------------------------
commit 52871671099d1bb3fca5ed076029e4b937bfc053
Author: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date:   Fri Feb 11 09:07:52 2022 +0100

    Linux 5.4.179
    
    Link: https://lore.kernel.org/r/20220209191248.688351316@linuxfoundation.org
    Tested-by: Shuah Khan <skhan@linuxfoundation.org>
    Tested-by: Florian Fainelli <f.fainelli@gmail.com>
    Tested-by: Jon Hunter <jonathanh@nvidia.com>
    Tested-by: Linux Kernel Functional Testing <lkft@linaro.org>
    Tested-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
    Tested-by: Slade Watkins <slade@sladewatkins.com>
    Tested-by: Guenter Roeck <linux@roeck-us.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

commit d692e3406e052dbf9f6d9da0cba36cb763272529
Author: Jon Maloy <jmaloy@redhat.com>
Date:   Sat Feb 5 14:11:18 2022 -0500

    tipc: improve size validations for received domain records
    
    commit 9aa422ad326634b76309e8ff342c246800621216 upstream.
    
    The function tipc_mon_rcv() allows a node to receive and process
    domain_record structs from peer nodes to track their views of the
    network topology.
    
    This patch verifies that the number of members in a received domain
    record does not exceed the limit defined by MAX_MON_DOMAIN, something
    that may otherwise lead to a stack overflow.
    
    tipc_mon_rcv() is called from the function tipc_link_proto_rcv(), where
    we are reading a 32 bit message data length field into a uint16.  To
    avert any risk of bit overflow, we add an extra sanity check for this in
    that function.  We cannot see that happen with the current code, but
    future designers being unaware of this risk, may introduce it by
    allowing delivery of very large (> 64k) sk buffers from the bearer
    layer.  This potential problem was identified by Eric Dumazet.
    
    This fixes CVE-2022-0435
    
    Reported-by: Samuel Page <samuel.page@appgate.com>
    Reported-by: Eric Dumazet <edumazet@google.com>
    Fixes: 35c55c9877f8 ("tipc: add neighbor monitoring framework")
    Signed-off-by: Jon Maloy <jmaloy@redhat.com>
    Reviewed-by: Xin Long <lucien.xin@gmail.com>
    Reviewed-by: Samuel Page <samuel.page@appgate.com>
    Reviewed-by: Eric Dumazet <edumazet@google.com>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

commit 3a0a7ec5574b510b067cfc734b8bdb6564b31d4e
Author: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date:   Thu Jan 27 08:16:38 2022 +0100

    moxart: fix potential use-after-free on remove path
    
    commit bd2db32e7c3e35bd4d9b8bbff689434a50893546 upstream.
    
    It was reported that the mmc host structure could be accessed after it
    was freed in moxart_remove(), so fix this by saving the base register of
    the device and using it instead of the pointer dereference.
    
    Cc: Ulf Hansson <ulf.hansson@linaro.org>
    Cc: Xiyu Yang <xiyuyang19@fudan.edu.cn>
    Cc: Xin Xiong <xiongx18@fudan.edu.cn>
    Cc: Xin Tan <tanxin.ctf@gmail.com>
    Cc: Tony Lindgren <tony@atomide.com>
    Cc: Yang Li <yang.lee@linux.alibaba.com>
    Cc: linux-mmc@vger.kernel.org
    Cc: stable <stable@vger.kernel.org>
    Reported-by: whitehat002 <hackyzh002@gmail.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Link: https://lore.kernel.org/r/20220127071638.4057899-1-gregkh@linuxfoundation.org
    Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>


From xen-devel-bounces@lists.xenproject.org Fri Feb 11 23:35:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 23:35:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270678.464998 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIfRF-0001UQ-Qj; Fri, 11 Feb 2022 23:34:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270678.464998; Fri, 11 Feb 2022 23:34:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIfRF-0001UJ-NV; Fri, 11 Feb 2022 23:34:53 +0000
Received: by outflank-mailman (input) for mailman id 270678;
 Fri, 11 Feb 2022 23:34:52 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=u2lR=S2=xilinx.com=stefanos@srs-se1.protection.inumbo.net>)
 id 1nIfRE-0001UC-7L
 for xen-devel@lists.xenproject.org; Fri, 11 Feb 2022 23:34:52 +0000
Received: from NAM10-DM6-obe.outbound.protection.outlook.com
 (mail-dm6nam10on20603.outbound.protection.outlook.com
 [2a01:111:f400:7e88::603])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 349f76e6-8b93-11ec-8eb8-a37418f5ba1a;
 Sat, 12 Feb 2022 00:34:50 +0100 (CET)
Received: from SA0PR11CA0028.namprd11.prod.outlook.com (2603:10b6:806:d3::33)
 by PH0PR02MB8763.namprd02.prod.outlook.com (2603:10b6:510:f0::9) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Fri, 11 Feb
 2022 23:34:45 +0000
Received: from SN1NAM02FT0042.eop-nam02.prod.protection.outlook.com
 (2603:10b6:806:d3:cafe::45) by SA0PR11CA0028.outlook.office365.com
 (2603:10b6:806:d3::33) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.15 via Frontend
 Transport; Fri, 11 Feb 2022 23:34:45 +0000
Received: from xsj-pvapexch02.xlnx.xilinx.com (149.199.62.198) by
 SN1NAM02FT0042.mail.protection.outlook.com (10.97.4.129) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.4975.11 via Frontend Transport; Fri, 11 Feb 2022 23:34:44 +0000
Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by
 xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2176.14; Fri, 11 Feb 2022 15:34:43 -0800
Received: from smtp.xilinx.com (172.19.127.95) by
 xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id
 15.1.2176.14 via Frontend Transport; Fri, 11 Feb 2022 15:34:43 -0800
Received: from [10.23.120.145] (port=64944 helo=ubuntu-20.04.2-arm64.shared)
 by smtp.xilinx.com with esmtp (Exim 4.90)
 (envelope-from <stefano.stabellini@xilinx.com>)
 id 1nIfR5-0006V2-Oj; Fri, 11 Feb 2022 15:34:43 -0800
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 349f76e6-8b93-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=JNmrGS0gijoKvcXHFqQjw2hZ117r0PVLPNBQJKSrfORbHYLlc+n7FfVhVVzPBTFBpvrsdS9qbmayY4/V49At/HCPDkFBqWysebSAtysYWUOofqUeGTf4NEYTLv1QFIOQHd//BRIAj+MOA9hGucSd8dpNTTv7uQwhsBnDgPRDxNyAjj0xaRQjfUiE6qVEmMaTy6aFSNHYLAtolUXN61Unz0LHuZXY7vLXc1PfWSSmkaV1vwubXP6mbkh3bU74qevVWlTa20SaA1VkGFEIdR9MlbHHDT9Q4krdHKVKrABl/8hK5SnVOw7czmjuFybBhBKVzQXx+HiuBH9mM3MQJFGz/g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=cvFQN9JienQG+muiB2OfHI1+NPX3aY65DQpnak25QD0=;
 b=F5WT0h5+K4/nxbtw+/aTdszAZKjDdeA+FggSPVdBrijXbEeEpbyKRDnlhehpT+SB/DbjqDIjIATVInc2DlQxETNzq11g/fnGfqW/5m9aK5tjKP1kam1F1dE5Uo2koIR/es9AFNW5vFclSvP4bzN/UDUaHP1UWB87ykNm8fIiL/bef52LxfznbhuFyuEsGXKiKNiNsip8nrH78oFTDEymGSBDW+c6e/c8SVOPSDyo5BuQ4gZYo7N5ej+a6bIa3vyogAuNv57o4cz593iARl2S/1LYiRzgOY6tlC9SXM8WIMxlB9IBtcVp9jVYJnZRbZpEJ+0cgWoqzXGg7TYQnkQAjw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 149.199.62.198) smtp.rcpttodomain=linaro.org smtp.mailfrom=xilinx.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=cvFQN9JienQG+muiB2OfHI1+NPX3aY65DQpnak25QD0=;
 b=sGiuY9Wx0b5jlZ+7uo6vmActZ004eUv3LiRMHdXVf6iDhjdd0eO/XZZ/f9ZcILikGmoS0KyqWTpJSHpNXFshVqSfBpCgsQY7NvjYHo7J6Qm8GaWObgU9+qDhnoV+XC/HLJvYPVmiNy6TLLEPIlkqHAgaaA5mRN27+165bPsG3eA=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198)
 smtp.mailfrom=xilinx.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=xilinx.com;
Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates
 149.199.62.198 as permitted sender) receiver=protection.outlook.com;
 client-ip=149.199.62.198; helo=xsj-pvapexch02.xlnx.xilinx.com;
Date: Fri, 11 Feb 2022 15:34:43 -0800
From: Stefano Stabellini <stefano.stabellini@xilinx.com>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: =?UTF-8?Q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>
CC: Stefano Stabellini <stefano.stabellini@xilinx.com>, Vincent Guittot
	<vincent.guittot@linaro.org>, <stratos-dev@op-lists.linaro.org>,
	<xen-devel@lists.xenproject.org>, AKASHI Takahiro
	<takahiro.akashi@linaro.org>, Arnd Bergmann <arnd.bergmann@linaro.org>,
	Christopher Clark <christopher.w.clark@gmail.com>, Dmytro Firsov
	<dmytro_firsov@epam.com>, Julien Grall <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, <Oleksandr_Tyshchenko@epam.com>,
	<Artem_Mygaiev@epam.com>, <bertrand.marquis@arm.com>, <Wei.Chen@arm.com>,
	<Ed.Doxat@arm.com>, <Oleksii_Moisieiev@epam.com>
Subject: Re: Metadata and signalling channels for Zephyr virtio-backends on
 Xen
In-Reply-To: <87k0e1cl9z.fsf@linaro.org>
Message-ID: <alpine.DEB.2.22.394.2202111445290.2091381@ubuntu-linux-20-04-desktop>
References: <87h79bgd1m.fsf@linaro.org> <alpine.DEB.2.22.394.2202071419270.2091381@ubuntu-linux-20-04-desktop> <87k0e1cl9z.fsf@linaro.org>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed;
	boundary="8323329-1747806176-1644620554=:2091381"
Content-ID: <alpine.DEB.2.22.394.2202111502360.2091381@ubuntu-linux-20-04-desktop>
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 72b68da3-503f-4211-6362-08d9edb715b7
X-MS-TrafficTypeDiagnostic: PH0PR02MB8763:EE_
X-Microsoft-Antispam-PRVS:
	<PH0PR02MB8763FCACB86D7A36F79FBB74A0309@PH0PR02MB8763.namprd02.prod.outlook.com>
X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	si7BCVIg49xhfZRZO/pWSSF4QJdwyHvHR+690P1YfEAqp6bjPKYjiuEyzI9OjgsAVl1/82NqnB17XCrpPOm++qrqAdn3WkVy8l4KYkQjXFB8clg57BEFed7gMsehQ1RsWlI06nlU+Azs9nzbuosWW4kN5QwsNc1lXrPkQUp1WQDLq1pfv+xZEhosEP3rOrxosiWm60r4s/8vEXa9Cw2RQy3HEGvUZn1tBIKtloCQSIjvdmgpNe1ckUNgKiO45DH3IbbB6+xnvgUGwkGp+Rl8Fc5ny+ckG+aIkAaGvd6FwIdHFeuLCumz4y7FpipMlvMoOqoSnlDauX8f42+8Jn5GaOiExbxDXR/2hBeoTYDl0YTgSd+3+DDH04yrFpG+Wu6TYKUZFpFmgxSrQkGKy30/8kPlKy6oJXaIjc9L83Sgm2ASOEw2mQ2y4Madami1wDvCLqrqfkchLgt65RmZjCu/xWOC4XPEjIVyQ4qoNfHtINU6Kk+rlsThQYZsIUKB0i9wSC8Xf17+Wx+YQqs4o69v30y7SeUm6tzXqdjc+E6CLjGOpjU9zJqZlQAKY+w2pWQsM4mJRlY20YhoaL8i5rXE5DcExCvIc/GhkCiFzhMu1IlTR3THvyDWjwfPXQXEplhqj+YgNI3jjlFLIcBp3llOLe7zjpdIU31+nJknr0q8rw+N/vOE6+D1kFsyAoVVQD0nXUOykSIXMUSqhXkJvspyrzLKUokw6b/BISKLzgfLiCqgbGZt88BVJrKmjZixyzciEP17ZK/XZBQKE3To67jJ5vP+U7TW4apXiO3x7ozEk+I=
X-Forefront-Antispam-Report:
	CIP:149.199.62.198;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:xsj-pvapexch02.xlnx.xilinx.com;PTR:unknown-62-198.xilinx.com;CAT:NONE;SFS:(13230001)(7916004)(4636009)(36840700001)(40470700004)(46966006)(66574015)(356005)(26005)(186003)(40460700003)(47076005)(5660300002)(2906002)(33716001)(9786002)(44832011)(7416002)(33964004)(8936002)(4326008)(82310400004)(6916009)(70206006)(316002)(54906003)(966005)(9686003)(508600001)(8676002)(83380400001)(426003)(336012)(7636003)(36860700001)(70586007);DIR:OUT;SFP:1101;
X-OriginatorOrg: xilinx.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2022 23:34:44.7992
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 72b68da3-503f-4211-6362-08d9edb715b7
X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch02.xlnx.xilinx.com]
X-MS-Exchange-CrossTenant-AuthSource:
	SN1NAM02FT0042.eop-nam02.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR02MB8763

--8323329-1747806176-1644620554=:2091381
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Content-ID: <alpine.DEB.2.22.394.2202111502361.2091381@ubuntu-linux-20-04-desktop>

On Fri, 11 Feb 2022, Alex Bennée wrote:
> > FYI, a good and promising approach to handle both SCMI and SCPI is the
> > series recently submitted by EPAM to mediate SCMI and SCPI requests in
> > Xen: https://marc.info/?l=xen-devel&m=163947444032590
> >
> > (Another "special" virtio backend is virtio-iommu for similar reasons:
> > the guest p2m address mappings and also the IOMMU drivers are in Xen.
> > It is not immediately clear whether a virtio-iommu backend would need to
> > be in Xen or run as a process in dom0/domU.)
> >
> > On the other hand, for all the other "normal" protocols (e.g.
> > virtio-net, virtio-block, etc.) the backend would naturally run as a
> > process in dom0 or domU (e.g. QEMU in Dom0) as one would expect.
> 
> Can domU's not be given particular access to HW they might want to
> tweak? I assume at some point a block device backend needs to actually
> talk to real HW to store the blocks (even if in most cases it would be a
> kernel doing the HW access on it's behalf).

Yes, it would. Block and network are subsystems with limited visibility,
access, and harmful capabilities (assuming IOMMU).

If the block device goes down or is misused, block might not work but
everything else is expected to work. Block only requires visibility of
the block device for it to work. The same is true for network, GPU, USB,
etc.

SCMI is different. If SCMI is misused the whole platform is affected.
SCMI implies visibility of everything in the system. It is not much
about emulating SCMI but more about mediating SCMI calls.

In other words, SCMI is not a device, it is a core interface. In a Xen
model, Xen virtualizes CPU and memory and other core features/interfaces
(timers, interrupt controller, IOMMU, etc). The PCI root complex is
handled by Xen too. Individual (PCI and non-PCI) devices are assigned to
guests.

These are the reasons why I think the best way to enable SCMI in
upstream Xen is with a mediator in the hypervisor as it is currently in
development. Any chances you could combine your efforts with EPAM's
outstanding series? You might be able to spot gaps if any, and might
even have already code to fill those gaps. It would be fantastic to have
your reviews and/or contributions on xen-devel.

Otherwise, if you have to run the virtio-scmi backend in userspace, why
not try to get it to work on Xen :-) It might not be the ideal solution,
but it could be a good learning experience and pave the way for the
other virtio backends which definitely will be in userspace
(virtio-block, virtio-gpu, etc).


> >> Currently the demo setup
> >> is intermediated by a double-ended vhost-user daemon running on the
> >> devbox acting as a go between a number of QEMU instances representing
> >> the front and back-ends. You can view the architecture with Vincents
> >> diagram here:
> >> 
> >>   https://docs.google.com/drawings/d/1YSuJUSjEdTi2oEUq4oG4A9pBKSEJTAp6hhcHKKhmYHs/edit?usp=sharing
> >> 
> >> The key virtq handling is done over the special carve outs of shared
> >> memory between the front end and guest. However the signalling is
> >> currently over a virtio device on the backend. This is useful for the
> >> PoC but obviously in a real system we don't have a hidden POSIX system
> >> acting as a go between not to mention the additional latency it causes
> >> with all those context switches.
> >> 
> >> I was hoping we could get some more of the Xen experts to the next
> >> Stratos sync (17th Feb) to go over approaches for a properly hosted on
> >> Xen approach. From my recollection (Vincent please correct me if I'm
> >> wrong) of last week the issues that need solving are:
> >
> > Unfortunately I have a regular conflict which prevents me from being
> > able to join the Stratos calls. However, I can certainly make myself
> > available for one call (unless something unexpected comes up).
> >
> >
> >>  * How to handle configuration steps as FE guests come up
> >> 
> >> The SCMI server will be a long running persistent backend because it is
> >> managing real HW resources. However the guests may be ephemeral (or just
> >> restarted) so we can't just hard-code everything in a DTB. While the
> >> virtio-negotiation in the config space covers most things we still need
> >> information like where in the guests address space the shared memory
> >> lives and at what offset into that the queues are created. As far as I'm
> >> aware the canonical source of domain information is XenStore
> >> (https://wiki.xenproject.org/wiki/XenStore) but this relies on a Dom0
> >> type approach. Is there an alternative for dom0less systems or do we
> >> need a dom0-light approach, for example using STR-21 (Ensure Zephyr can
> >> run cleanly as a Dom0 guest) providing just enough services for FE's to
> >> register metadata and BE's to read it?
> >
> > I'll try to answer the question for a generic virtio frontend and
> > backend instead (not SCMI because SCMI is unique due to the reasons
> > above.)
> >
> > Yes, xenstore is the easiest way to exchange configuration information
> > between domains. I think EPAM used xenstore to exchange the
> > configuration information in their virtio-block demo. There is a way to
> > use xenstore even between dom0less VMs:
> > https://marc.info/?l=xen-devel&m=164340547602391 Not just xenstore but
> > full PV drivers too. However, in the dom0less case xenstore is going to
> > become available some time after boot, not immediately at startup time.
> > That's because you need to wait until xenstored is up and running.
> >
> > There are other ways to send data from one VM to another which are
> > available immediately at boot, such as Argo and static shared memory.
> >
> > But dom0less is all about static partitioning, so it makes sense to
> > exploit the build-time tools to the fullest. In the dom0less case, we
> > already know what is going to run on the target before it is even turned
> > on. As an example, we might have already prepared an environment with 3
> > VMs using Yocto and ImageBuilder. We could also generate all
> > configurations needed and place them inside each VMs using Yocto's
> > standard tools and ImageBuilder. So for dom0less, I recommend to go via
> > a different route and pre-generate the configuration directly where
> > needed instead of doing dynamic discovery.
> 
> Even in a full dom0less setup you still need to manage lifetimes somehow
> if a guest reboots.

Sure but that's not a problem: all the info and configuration related to
rebooting the guest can also be pre-generated in Yocto or ImageBuilder.

As an example, it is already possible (although rudimental) in
ImageBuilder to generate the dom0less configuration and also the domU xl
config file for the same domU with passthrough devices.
--8323329-1747806176-1644620554=:2091381--


From xen-devel-bounces@lists.xenproject.org Fri Feb 11 23:35:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 11 Feb 2022 23:35:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270679.465009 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIfRZ-0001sE-5S; Fri, 11 Feb 2022 23:35:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270679.465009; Fri, 11 Feb 2022 23:35:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIfRZ-0001s7-0a; Fri, 11 Feb 2022 23:35:13 +0000
Received: by outflank-mailman (input) for mailman id 270679;
 Fri, 11 Feb 2022 23:35:11 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=kHth=S2=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nIfRX-0001UC-14
 for xen-devel@lists.xenproject.org; Fri, 11 Feb 2022 23:35:11 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 3fa18ec3-8b93-11ec-8eb8-a37418f5ba1a;
 Sat, 12 Feb 2022 00:35:08 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 82247B80D57;
 Fri, 11 Feb 2022 23:35:08 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 08953C340E9;
 Fri, 11 Feb 2022 23:35:06 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3fa18ec3-8b93-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1644622507;
	bh=APsCFhU/hEwebhCwGfM+/31CQoeUD9aRNkoMeanb6JI=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=gP+kYQqNIQ9mL+lMlxiPq7bvppZpYj/ayOZTrNco9L+CFM5mcYIS9hJ8jKC2RNai+
	 hTljWBCiFtffvUzl5M+d/1lE2jBKCEawnhvIe2/6xYqwHnPiCKFvyJfBaunbguWRGE
	 6fqw3430qBRLJz3dRXIp/LCWbcJCNaaKkXhC4+idXqbeHp5tQ4U7ewDUIAuKpwRpDr
	 HDCYwg3klENpuGQ2JBEHuNwUD10G3VC0wcOmmSwLpuAf6l/yemEEo+pxpfa2qvKtxS
	 bbLMeWsPFoQtks1Cp7Pj+6WzKoUgGaCOzfU9Xbiav6K+QQKyVpS0BBH3kVpIOlxrBi
	 7W3WKTZMBYr9Q==
Date: Fri, 11 Feb 2022 15:35:06 -0800 (PST)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
cc: Bertrand Marquis <bertrand.marquis@arm.com>, 
    "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
    Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [RFC v2 5/8] xen/arm: introduce SCMI-SMC mediator driver
In-Reply-To: <20220211115516.GA2356906@EPUAKYIW015D>
Message-ID: <alpine.DEB.2.22.394.2202111428290.2091381@ubuntu-linux-20-04-desktop>
References: <cover.1644341635.git.oleksii_moisieiev@epam.com> <cb1493f5d9b5c3437268054b4a8e345cb35c8708.1644341635.git.oleksii_moisieiev@epam.com> <F9811680-C6EC-4372-A451-5C1DA279E35E@arm.com> <20220211104403.GA2291814@EPUAKYIW015D>
 <A9FF3FBC-C29D-4A17-8737-EBABEF240BA2@arm.com> <20220211115516.GA2356906@EPUAKYIW015D>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-665559561-1644618992=:2091381"
Content-ID: <alpine.DEB.2.22.394.2202111516170.2091381@ubuntu-linux-20-04-desktop>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-665559561-1644618992=:2091381
Content-Type: text/plain; CHARSET=UTF-8
Content-Transfer-Encoding: 8BIT
Content-ID: <alpine.DEB.2.22.394.2202111516171.2091381@ubuntu-linux-20-04-desktop>

On Fri, 11 Feb 2022, Oleksii Moisieiev wrote:
> On Fri, Feb 11, 2022 at 11:18:47AM +0000, Bertrand Marquis wrote:
> > Hi Oleksii,
> > 
> > 
> > > On 11 Feb 2022, at 10:44, Oleksii Moisieiev <Oleksii_Moisieiev@epam.com> wrote:
> > > 
> > > Hi Bertrand,
> > > 
> > > On Fri, Feb 11, 2022 at 08:46:05AM +0000, Bertrand Marquis wrote:
> > >> Hi Oleksii,
> > >> 
> > >> 
> > >>> On 8 Feb 2022, at 18:00, Oleksii Moisieiev <Oleksii_Moisieiev@epam.com> wrote:
> > >>> 
> > >>> This is the implementation of SCI interface, called SCMI-SMC driver,
> > >>> which works as the mediator between XEN Domains and Firmware (SCP, ATF etc).
> > >>> This allows devices from the Domains to work with clocks, resets and
> > >>> power-domains without access to CPG.
> > >>> 
> > >>> Originally, cpg should be passed to the domain so it can work with
> > >>> power-domains/clocks/resets etc. Considering that cpg can't be split between
> > >>> the Domains, we get the limitation that the devices, which are using
> > >>> power-domains/clocks/resets etc, couldn't be split between the domains.
> > >>> The solution is to move the power-domain/clock/resets etc to the
> > >>> Firmware (such as SCP firmware or ATF) and provide interface for the
> > >>> Domains. XEN should have an entity, caled SCI-Mediator, which is
> > >>> responsible for messages redirection between Domains and Firmware and
> > >>> for permission handling.
> > >>> 
> > >>> The following features are implemented:
> > >>> - request SCMI channels from ATF and pass channels to Domains;
> > >>> - set device permissions for Domains based on the Domain partial
> > >>> device-tree. Devices with permissions are able to work with clocks,
> > >>> resets and power-domains via SCMI;
> > >>> - redirect scmi messages from Domains to ATF.
> > >> 
> > >> Before going more deeply in the code I would like to discuss the general
> > >> design here and ask some questions to prevent to rework the code before
> > >> we all agree that this is the right solution and that we want this in Xen.
> > >> 
> > >> First I want to point out that clock/reset/power virtualization is a problem
> > >> on most applications using device pass-through and I am very glad that
> > >> someone is looking into it.
> > >> Also SCMI is the current standard existing for this so relying on it is a very
> > >> good idea.
> > >> 
> > >> Latest version SCMI standard (DEN0056D v3.1) is defining some means
> > >> to use SCMI on a virtualised system. In chapter 4.2.1, the standard
> > >> recommends to set permissions per agent in the hypervisor so that a VM
> > >> could later use the discovery protocol to detect the resources and use them.
> > >> Using this kind of scenario the mediator in Xen would just configure the
> > >> Permissions in the SCMI and would then rely on it to limit what is possible
> > >> by who just by just assigning a channel to a VM.
> > > 
> > >> 
> > >> In your current design (please correct me if I am wrong) you seem to fully
> > >> rely on Xen and the FDT for discovery and permission.
> > > 
> > > In current implementation Xen is the trusted agent. And it's responsible
> > > for permissions setting. During initialization it discovers agent and
> > > set permissions by using BASE_SET_DEVICE_PERMISSIONS to the Dom0. When
> > > new domain is created, Xen assigns agent id for this domain and request
> > > resources, that are passed-through to this Domain.
> > 
> > Ok
> > 
> > > 
> > > I'm getting the follwing information from FDT:
> > > 1) Shared memory addressed, which should be used for agents. During
> > > initialization I send BASE_DISCOVER_AGENT to each of this addresses and
> > > receive agent_id. Xen is responsible for assigning agent_id for the
> > > Domain. Then Xen intercept smc calls from the domain, set agent_id and
> > > redirects it to the Firmware.
> > 
> > So Xen is setting the agent ID, no way for a guest to get access to something it
> > should with more check, am I right ?
> > 
> 
> Yes. Xen is the only entity, which is trusted. So it's responsible for
> setting permissions and assigning agent_id. Guest get's an access only
> for the devices it's allowed to.
> 
> > > 
> > > 2) Devices, that are using SCMI. Those devices has clock/power/resets
> > > etc related to scmi protocol (as it is done in Linux kernel)
> > > and scmi_devid should be set. I'm currently preparing to send patch,
> > > updating kernel bindings with this parameter to Linux kernel.
> > > scmi_devid value should match device id, set in the Firmware.
> > > dt example:
> > > &usb0 {
> > >    scmi_devid = <1>; // usb0 device id
> > >    clocks = <&scmi_clock 1> // relays on clock with id 1
> > > }
> > > 
> > > Xen requests permission for the device when device is attached to the
> > > Domain during creation.
> > 
> > Without this, how is (if it is) the linux kernel using SCMI for power management ?
> 
> Here is how it should be desribed in FDT: 
> /
> {
>     firmware {
>         scmi {
>             arm,smc-id = <0x82000002>;
>             scmi_power: protocol@11 {
>                 reg = <0x11>;
>                 #power-domain-cells = <1>;
>             };
>             ...
>             scmi_clock: protocol@14 {
>             ...
>             scmi_reset: protocol@16 {
>             ...
>         };
>     };
> };
> 
> &avb {
>     scmi_devid = <0>; // Matches Etherned device_id in Firmware
>     clocks = <&scmi_clock 0>;
>     power-domains = <&scmi_power 0>;
>     resets = <&scmi_reset 0>;
> };
> 
> In the provided case devid equals to reset, clock and power-domain id,
> but this is conicidence. Each clock/power-domain/reset parameter can
> have more than one entity.
> Also - no changes was done to linux kernel scmi drivers.
> 
> > 
> > > 
> > >> Wouldn’t it be a better idea to use the protocol fully ?
> > > 
> > > Hm, I was thinking I am using the protocol fully. Did I miss something?
> > 
> > Sorry you seem to be, my understanding of your design was not right.
> > 
> > > 
> > >> Could we get rid of some of the FDT dependencies by using the discovery
> > >> system of SCMI ?
> > > 
> > > I'm using FDT to get shmem regions for the channels. Then I send
> > > BASE_DISCOVER_AGENT to each region and getting agent data. Did I use the
> > > discovery system wrong?
> > 
> > After more digging it seems you are. The link between scmi resource and device
> > is not possible to get automatically.
> > 
> > > 
> > >> How is Linux doing this currently ? Is it relying on device tree to discover
> > >> the SCMI resources ?
> > > 
> > > Yes. Linux kernel has 2 nodes in the device-tree: arm,scmi-shmem, which
> > > includes memory region for the communication and arm,scmi-smc node,
> > > which describes all data related to scmi ( func_id, protocols etc)
> > > Then the device nodes refer to the protocols by setting
> > > clock/resets/power-domains etc. Please see the example above.
> > > BASE_DISCOVER_AGENT is not used in Linux kernel.
> > > The main idea was that scmi related changes to the device-tree are
> > > common for virtualized and non virtualized systems. So the same FDT
> > > configuration should work with of without Xen.
> > 
> > So at this stage this is not supported in Linux and you plan to add support for it to.
> > 
> 
> Yes. That's correct. I've already prepared patch which should update
> linux kernel device-tree bindings.
> 
> > > 
> > >> 
> > >> Also I understand that you rely on some entries to be declared in the device
> > >> tree and also some support to be implemented in ATF or SCP. I checked in
> > >> The boards I have access to and the device trees but none of this seem to
> > >> be supported there. Could you tell which board/configuration/ATF you are
> > >> using so that the implementation could be tested/validated ?
> > >> 
> > > 
> > > We're currently have POC made for r8a77951-ulcb-kf and
> > > r8a77961-salvator-xs boards. It's based on:
> > > Linux-bsp kernel: 
> > > git@github.com:renesas-rcar/linux-bsp.git
> > > based on tag <rcar-5.0.0.rc4>
> > > 
> > > ATF: 
> > > git@github.com:renesas-rcar/arm-trusted-firmware.git
> > > based on branch <rcar_gen3_v2.5>
> > > 
> > > I can push those changes to Github, so you can review them
> > 
> > Do you plan to add support for other boards ?
> > 
> 
> Right now we're working only with r8a77951 and r8a77961 boards.
> 
> > Did you discuss more in general with the linux kernel guys to see if this
> > approach was agreed and will be adopted by other manufacturers ?
> 
> I didn't. I've contacted Sudeep Holla <sudeep.holla@arm.com>, who is the
> maintainer of the SCMI protocol drivers. Waiting for the response.
> 
> Also we proposed to add Pinctl support to SCMI specification. It was
> agreed and should be added to SCMI protocol in SCMIv3.2 (due end-2022/early 2023).
> 
> > 
> > All in all I think this is a good idea but I fear that all this will actually only
> > be used by one board or one manufacturer and other might use a different
> > strategy, I would like to unrisk this before merging this in Xen.
> 
> The main idea was to make Xen SCMI mediator completely transparent from
> the Domain point of view. So there is no Xen specific changes should be
> done to OS pinctrl drivers to work through SCMI.
> 
> This means that all platforms, that already using SCMI can work with it
> in virtualized system.

I like this statement. The aim of this series should not be just one
board, but it should be able to easily support any board with an SCMI
interface. For it to work, any changes to device tree interfaces should
be done in upstream device tree
(linux.git/Documentation/devicetree/bindings and/or devicetree.org).

Xilinx doesn't make use of SCMI yet. We are currently using an older
firmware interface called EEMI. EEMI and SCMI are not the same but they
are somewhat similar.

>From my experience with this kind of interfaces, I think Oleksii's
design is the right way to go. There are some important details to
review, like the device tree interfaces at the host level and domU
level, and the memory mapping of the channels; we need to be very
careful about those details. But overall I think it is the right
design.
--8323329-665559561-1644618992=:2091381--


From xen-devel-bounces@lists.xenproject.org Sat Feb 12 01:34:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 12 Feb 2022 01:34:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270695.465020 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIhIi-0007aI-DD; Sat, 12 Feb 2022 01:34:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270695.465020; Sat, 12 Feb 2022 01:34:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIhIi-0007Zr-5c; Sat, 12 Feb 2022 01:34:12 +0000
Received: by outflank-mailman (input) for mailman id 270695;
 Sat, 12 Feb 2022 01:34:11 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=/1S/=S3=m5p.com=ehem@srs-se1.protection.inumbo.net>)
 id 1nIhIh-0007Zl-9p
 for xen-devel@lists.xenproject.org; Sat, 12 Feb 2022 01:34:11 +0000
Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id de2dc48e-8ba3-11ec-b215-9bbe72dcb22c;
 Sat, 12 Feb 2022 02:34:08 +0100 (CET)
Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7])
 by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 21C1Xtom026988
 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO);
 Fri, 11 Feb 2022 20:34:01 -0500 (EST) (envelope-from ehem@m5p.com)
Received: (from ehem@localhost)
 by m5p.com (8.16.1/8.15.2/Submit) id 21C1XtsZ026987;
 Fri, 11 Feb 2022 17:33:55 -0800 (PST) (envelope-from ehem)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: de2dc48e-8ba3-11ec-b215-9bbe72dcb22c
Date: Fri, 11 Feb 2022 17:33:55 -0800
From: Elliott Mitchell <ehem+xen@m5p.com>
To: Julien Grall <julien@xen.org>
Cc: Jan Beulich <jbeulich@suse.com>, Julien Grall <jgrall@amazon.com>,
        xen-devel@lists.xenproject.org, Daniel Kiper <daniel.kiper@oracle.com>
Subject: Re: [PATCH RFC 1/3] xen/efi: Always query the console information
 and get GOP
Message-ID: <YgcOg6p8D+6hWWsE@mattapan.m5p.com>
References: <20220206192839.75711-1-julien@xen.org>
 <20220206192839.75711-2-julien@xen.org>
 <88741681-929f-4cda-e841-023bdbf8f772@suse.com>
 <26cdd9cf-15d6-a463-b1bb-28964005f618@xen.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <26cdd9cf-15d6-a463-b1bb-28964005f618@xen.org>
X-Spam-Status: No, score=0.4 required=10.0 tests=KHOP_HELO_FCRDNS autolearn=no
	autolearn_force=no version=3.4.5
X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on mattapan.m5p.com

On Mon, Feb 07, 2022 at 06:52:57PM +0000, Julien Grall wrote:
> On 07/02/2022 08:46, Jan Beulich wrote:
> > On 06.02.2022 20:28, Julien Grall wrote:
> >>
> >> It is not entirely clear to me why the GOP was only fetched when
> >> the configuration file is used.
> >>
> >> I have tested this on RPI4 and it seems to work. Any chance this
> >> was done to workaround an x86 platform?
> > 
> > This was done so in the context of making the code work for Arm. See
> > commit c38cf865ec82 ("EFI: ignore EFI commandline, skip console setup
> > when booted from GRUB"), the description of which explicitly says
> > 
> > "Don't do EFI console or video configuration when booted by GRUB.  The EFI boot
> >   code does some console and video initialization to support native EFI boot from
> >   the EFI boot manager or EFI shell.  This initlization should not be done when
> >   booted using GRUB."
> 
> I read that and still couldn't figure out why this was done like that.

The most likely motivation was simply "Eww!  ACPI/UEFI use gobs of
memory!  Purge the abomination!"

Unfortunately ACPI/UEFI are large an complex due to trying to solve a
large and complex problem.  ACPI/UEFI attempt to provide an OS agnostic
presentation of the hardware layout.  Whereas device-trees are a common
*format* for presenting hardware to *an* OS (similar to how JSON is a
common format).

Due to the size and complexity, most developers have preferred the
simpler device-tree format even though that severely limits OS choice.
As such, nuking ACPI/UEFI's presence is common in the ARM world.  Versus
the x86 world where Intel dragged everyone onto ACPI/UEFI.

One can see this in patches like Roman Shaposhnik's "Making full 2G of
memory available to Xen on HiKey" which simply tosses EFI into the
garbage bin as useless overhead.

Yet the ARM world is now large enough to justify OS-agnostic solutions
such as ACPI/UEFI.  The standards behind device-trees might be heading in
this direction, but they're way behind.




You stated your patch was for 5.17-rc2.  How much backporting would you
expect this patch to be viable for?  (I'm unsure how much churn is
occuring in the relevant portions of Linux) The long-term branches of
Linux include 5.4.179, 5.10.100 and 5.15.23.  `patch` indicated it could
apply to 5.10.92 source with fuzz (hmm).  This suggests 5.15 is likely
viable, but 5.10 is risky and 5.4 is a very long shot.


-- 
(\___(\___(\______          --=> 8-) EHM <=--          ______/)___/)___/)
 \BS (    |         ehem+sigmsg@m5p.com  PGP 87145445         |    )   /
  \_CS\   |  _____  -O #include <stddisclaimer.h> O-   _____  |   /  _/
8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445




From xen-devel-bounces@lists.xenproject.org Sat Feb 12 01:46:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 12 Feb 2022 01:46:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270704.465031 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIhUg-0000gK-L5; Sat, 12 Feb 2022 01:46:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270704.465031; Sat, 12 Feb 2022 01:46:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIhUg-0000g9-Et; Sat, 12 Feb 2022 01:46:34 +0000
Received: by outflank-mailman (input) for mailman id 270704;
 Sat, 12 Feb 2022 01:46:33 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=/1S/=S3=m5p.com=ehem@srs-se1.protection.inumbo.net>)
 id 1nIhUf-0000g3-0u
 for xen-devel@lists.xenproject.org; Sat, 12 Feb 2022 01:46:33 +0000
Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 99de8542-8ba5-11ec-b215-9bbe72dcb22c;
 Sat, 12 Feb 2022 02:46:31 +0100 (CET)
Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7])
 by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 21C1kMhe027027
 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO)
 for <xen-devel@lists.xenproject.org>; Fri, 11 Feb 2022 20:46:28 -0500 (EST)
 (envelope-from ehem@m5p.com)
Received: (from ehem@localhost)
 by m5p.com (8.16.1/8.15.2/Submit) id 21C1kMN0027026
 for xen-devel@lists.xenproject.org; Fri, 11 Feb 2022 17:46:22 -0800 (PST)
 (envelope-from ehem)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 99de8542-8ba5-11ec-b215-9bbe72dcb22c
Date: Fri, 11 Feb 2022 17:46:22 -0800
From: Elliott Mitchell <ehem+xen@m5p.com>
To: xen-devel@lists.xenproject.org
Subject: Development Issue of Concern
Message-ID: <YgcRbq4yJlKSonzj@mattapan.m5p.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
X-Spam-Status: No, score=0.4 required=10.0 tests=KHOP_HELO_FCRDNS autolearn=no
	autolearn_force=no version=3.4.5
X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on mattapan.m5p.com

The tradition has been to name the active development branch in GIT has
been named "master".  Quite a number of people object to the name due to
its history.

In light of such concerns, perhaps the Xen Project should join with other
similar projects and move to have the active development branch renamed
"main"?


-- 
(\___(\___(\______          --=> 8-) EHM <=--          ______/)___/)___/)
 \BS (    |         ehem+sigmsg@m5p.com  PGP 87145445         |    )   /
  \_CS\   |  _____  -O #include <stddisclaimer.h> O-   _____  |   /  _/
8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445




From xen-devel-bounces@lists.xenproject.org Sat Feb 12 03:59:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 12 Feb 2022 03:59:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270712.465041 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIjZK-0004cn-3e; Sat, 12 Feb 2022 03:59:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270712.465041; Sat, 12 Feb 2022 03:59:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIjZK-0004cg-0j; Sat, 12 Feb 2022 03:59:30 +0000
Received: by outflank-mailman (input) for mailman id 270712;
 Sat, 12 Feb 2022 03:59:28 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nIjZI-0004cW-3G; Sat, 12 Feb 2022 03:59:28 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nIjZI-00021g-08; Sat, 12 Feb 2022 03:59:28 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nIjZH-0002X8-DU; Sat, 12 Feb 2022 03:59:27 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nIjZH-00033a-Cs; Sat, 12 Feb 2022 03:59:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=f6NvD0T36fo8IdNuhaSFShMm+dVquZPUtjprW0QWVOQ=; b=NQ2OPCXQqc3kUbX3DEOrgE+R2q
	6PcdHtdSYfqoTccAezmfti7r/rzOSJiq5vV5/UbzfJ5t8u5bKd7rdrrWZIbZD9DGYuZI7K9SZC+mC
	BQIQ32MSYDu5d0uYer/vMJvyK5+KX3aGlo7snwoBL+WCwq2kuKcf3OSQBld9/PFgRvZk=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168086-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 168086: trouble: blocked/broken/fail/pass
X-Osstest-Failures:
    linux-linus:build-arm64:<job status>:broken:regression
    linux-linus:build-arm64-pvops:<job status>:broken:regression
    linux-linus:build-arm64-xsm:<job status>:broken:regression
    linux-linus:build-arm64-xsm:host-install(4):broken:regression
    linux-linus:build-arm64:host-install(4):broken:regression
    linux-linus:build-arm64-pvops:host-install(4):broken:regression
    linux-linus:test-arm64-arm64-examine:build-check(1):blocked:nonblocking
    linux-linus:build-arm64-libvirt:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=1d41d2e82623b40ee27811fe9ea38bafe2e722e9
X-Osstest-Versions-That:
    linux=f1baf68e1383f6ed93eb9cff2866d46562607a43
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 12 Feb 2022 03:59:27 +0000

flight 168086 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168086/

Failures and problems with tests :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-arm64                     <job status>                 broken
 build-arm64-pvops               <job status>                 broken
 build-arm64-xsm                 <job status>                 broken
 build-arm64-xsm               4 host-install(4)        broken REGR. vs. 168080
 build-arm64                   4 host-install(4)        broken REGR. vs. 168080
 build-arm64-pvops             4 host-install(4)        broken REGR. vs. 168080

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-examine      1 build-check(1)               blocked  n/a
 build-arm64-libvirt           1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl           1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit1   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit2   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-seattle   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-thunderx  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-vhd       1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-xsm       1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168080
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168080
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168080
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168080
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168080
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail like 168080
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168080
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168080
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168080
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                1d41d2e82623b40ee27811fe9ea38bafe2e722e9
baseline version:
 linux                f1baf68e1383f6ed93eb9cff2866d46562607a43

Last test of basis   168080  2022-02-11 00:09:22 Z    1 days
Testing same since   168086  2022-02-11 20:11:19 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Aaron Liu <aaron.liu@amd.com>
  Alex Deucher <alexander.deucher@amd.com>
  Alexandre Ghiti <alexandre.ghiti@canonical.com>
  Alviro Iskandar Setiawan <alviro.iskandar@gmail.com>
  Ammar Faizi <ammarfaizi2@gnuweeb.org>
  Andreas Gruenbacher <agruenba@redhat.com>
  Andrzej Pietrasiewicz <andrzej.p@collabora.com>
  Andy Shevchenko <andriy.shevchenko@linux.intel.com>
  Aurelien Jarno <aurelien@aurel32.net>
  Bartosz Golaszewski <brgl@bgdev.pl>
  Bean Huo <beanhuo@micron.com>
  Bob Peterson <rpeterso@redhat.com>
  Brian Norris <briannorris@chromium.org>
  Catalin Marinas <catalin.marinas@arm.com>
  Changbin Du <changbin.du@gmail.com>
  Christoph Hellwig <hch@lst.de>
  Christoph Niedermaier <cniedermaier@dh-electronics.com>
  Damien Le Moal <damien.lemoal@opensource.wdc.com>
  Daniel Bristot de Oliveira <bristot@kernel.org>
  Daniel Stone <daniels@collabora.com>
  Daniel Vetter <daniel.vetter@ffwll.ch>
  Daniel Vetter <daniel.vetter@intel.com>
  Daniel Wheeler <daniel.wheeler@amd.com>
  Dave Airlie <airlied@redhat.com>
  Dave Stevenson <dave.stevenson@raspberrypi.com>
  Dmytro Laktyushkin <Dmytro.Laktyushkin@amd.com>
  Geert Uytterhoeven <geert+renesas@glider.be>
  Geert Uytterhoeven <geert@linux-m68k.org>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>Cc: Dave Airlie <airlied@gmail.com>
  Hans de Goede <hdegoede@redhat.com>
  Heiko Stuebner <heiko@sntech.de>
  Helge Deller <deller@gmx.de>
  JaeSang Yoo <js.yoo.5b@gmail.com>
  JaeSang Yoo <jsyoo5b@gmail.com>
  Jan Kara <jack@suse.cz>
  Jani Nikula <jani.nikula@intel.com>
  Jasdeep Dhillon <jdhillon@amd.com>
  Jens Axboe <axboe@kernel.dk>
  Jisheng Zhang <jszhang@kernel.org>
  Kai-Heng Feng <kai.heng.feng@canonical.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
  Lucas De Marchi <lucas.demarchi@intel.com>
  Marek Vasut <marex@denx.de>
  Mario Limonciello <mario.limonciello@amd.com>
  Mark Brown <broonie@kernel.org>
  Maxime Ripard <maxime@cerno.tech>
  Myrtle Shah <gatecat@ds0.me>
  Niklas Cassel <niklas.cassel@wdc.com>
  Palmer Dabbelt <palmer@rivosinc.com>
  Pingfan Liu <kernelfans@gmail.com>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Robin Murphy <robin.murphy@arm.com>
  Roman Li <Roman.Li@amd.com>
  Sagi Grimberg <sagi@grimberg.me>
  Sam Ravnborg <sam@ravnborg.org>
  Sascha Hauer <s.hauer@pengutronix.de>
  Shakeel Butt <shakeelb@google.com>
  Steven Rostedt (Google) <rostedt@goodmis.org>
  Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
  Thomas Hellström <thomas.hellstrom@linux.intel.com>
  Thomas Zimmermann <tzimmermann@suse.de>
  Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
  Tvrtko Ursulin <tvrtko.ursulin@intel.com>
  Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
  Ville Syrjälä <ville.syrjala@linux.intel.com>
  Vlastimil Babka <vbabka@suse.cz>
  Yang Wang <KevinYang.Wang@amd.com>
  Yizhuo Zhai <yzhai003@ucr.edu>
  Zhan Liu <Zhan.Liu@amd.com>
  Zoltán Böszörményi <zboszor@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              broken  
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  broken  
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          blocked 
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            broken  
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          blocked 
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      blocked 
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  blocked 
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  blocked 
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     blocked 
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 blocked 
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      blocked 
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary

broken-job build-arm64 broken
broken-job build-arm64-pvops broken
broken-job build-arm64-xsm broken
broken-step build-arm64-xsm host-install(4)
broken-step build-arm64 host-install(4)
broken-step build-arm64-pvops host-install(4)

Not pushing.

(No revision log; it would be 1680 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Feb 12 09:52:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 12 Feb 2022 09:52:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270735.465052 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIp4z-00047q-Hb; Sat, 12 Feb 2022 09:52:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270735.465052; Sat, 12 Feb 2022 09:52:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIp4z-00047j-EI; Sat, 12 Feb 2022 09:52:33 +0000
Received: by outflank-mailman (input) for mailman id 270735;
 Sat, 12 Feb 2022 09:52:32 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nIp4y-00047V-2T; Sat, 12 Feb 2022 09:52:32 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nIp4x-0000yG-VK; Sat, 12 Feb 2022 09:52:32 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nIp4x-0003wV-Gs; Sat, 12 Feb 2022 09:52:31 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nIp4x-0003Qi-GC; Sat, 12 Feb 2022 09:52:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=S/PPd8b6rftgAoGsbhUCt+gewNRXZLeHNgQw/4pD6xE=; b=lkF1gNW5DEY9a+LCl6abBd47CH
	u34B1MI89JQRki61Og9q1Fof9DVynqhY0OM+PwSU2Pzncn+zhW4nb2GXqodmjfZV3PYltlQLyN8L2
	WKLsByMpI0E6vlNCN+fBRtXm5aLpkDDBqo3EqtW2k6EVM4zltyLdKPB9uk81JasKAV+4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168087-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-5.4 test] 168087: trouble: blocked/broken/fail/pass
X-Osstest-Failures:
    linux-5.4:build-arm64:<job status>:broken:regression
    linux-5.4:build-arm64-pvops:<job status>:broken:regression
    linux-5.4:build-arm64-xsm:<job status>:broken:regression
    linux-5.4:build-arm64-xsm:host-install(4):broken:regression
    linux-5.4:build-arm64-pvops:host-install(4):broken:regression
    linux-5.4:build-arm64:host-install(4):broken:regression
    linux-5.4:test-arm64-arm64-examine:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-xl:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking
    linux-5.4:build-arm64-libvirt:build-check(1):blocked:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=52871671099d1bb3fca5ed076029e4b937bfc053
X-Osstest-Versions-That:
    linux=76fd334f07cc11e047c2237a19b2cf8b1f653ba2
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 12 Feb 2022 09:52:31 +0000

flight 168087 linux-5.4 real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168087/

Failures and problems with tests :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-arm64                     <job status>                 broken
 build-arm64-pvops               <job status>                 broken
 build-arm64-xsm                 <job status>                 broken
 build-arm64-xsm               4 host-install(4)        broken REGR. vs. 168060
 build-arm64-pvops             4 host-install(4)        broken REGR. vs. 168060
 build-arm64                   4 host-install(4)        broken REGR. vs. 168060

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-examine      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl           1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit1   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit2   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-seattle   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-thunderx  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-vhd       1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-xsm       1 build-check(1)               blocked  n/a
 build-arm64-libvirt           1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168060
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168060
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168060
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168060
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168060
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168060
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168060
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168060
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168060
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168060
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168060
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168060
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 linux                52871671099d1bb3fca5ed076029e4b937bfc053
baseline version:
 linux                76fd334f07cc11e047c2237a19b2cf8b1f653ba2

Last test of basis   168060  2022-02-08 17:43:16 Z    3 days
Testing same since   168084  2022-02-11 08:43:38 Z    1 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
  Florian Fainelli <f.fainelli@gmail.com>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Guenter Roeck <linux@roeck-us.net>
  Jon Hunter <jonathanh@nvidia.com>
  Jon Maloy <jmaloy@redhat.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Linux Kernel Functional Testing <lkft@linaro.org>
  Shuah Khan <skhan@linuxfoundation.org>
  Slade Watkins <slade@sladewatkins.com>
  Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
  Ulf Hansson <ulf.hansson@linaro.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              broken  
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  broken  
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          blocked 
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            broken  
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          blocked 
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      blocked 
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  blocked 
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  blocked 
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     blocked 
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 blocked 
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      blocked 
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary

broken-job build-arm64 broken
broken-job build-arm64-pvops broken
broken-job build-arm64-xsm broken
broken-step build-arm64-xsm host-install(4)
broken-step build-arm64-pvops host-install(4)
broken-step build-arm64 host-install(4)

Not pushing.

------------------------------------------------------------
commit 52871671099d1bb3fca5ed076029e4b937bfc053
Author: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date:   Fri Feb 11 09:07:52 2022 +0100

    Linux 5.4.179
    
    Link: https://lore.kernel.org/r/20220209191248.688351316@linuxfoundation.org
    Tested-by: Shuah Khan <skhan@linuxfoundation.org>
    Tested-by: Florian Fainelli <f.fainelli@gmail.com>
    Tested-by: Jon Hunter <jonathanh@nvidia.com>
    Tested-by: Linux Kernel Functional Testing <lkft@linaro.org>
    Tested-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
    Tested-by: Slade Watkins <slade@sladewatkins.com>
    Tested-by: Guenter Roeck <linux@roeck-us.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

commit d692e3406e052dbf9f6d9da0cba36cb763272529
Author: Jon Maloy <jmaloy@redhat.com>
Date:   Sat Feb 5 14:11:18 2022 -0500

    tipc: improve size validations for received domain records
    
    commit 9aa422ad326634b76309e8ff342c246800621216 upstream.
    
    The function tipc_mon_rcv() allows a node to receive and process
    domain_record structs from peer nodes to track their views of the
    network topology.
    
    This patch verifies that the number of members in a received domain
    record does not exceed the limit defined by MAX_MON_DOMAIN, something
    that may otherwise lead to a stack overflow.
    
    tipc_mon_rcv() is called from the function tipc_link_proto_rcv(), where
    we are reading a 32 bit message data length field into a uint16.  To
    avert any risk of bit overflow, we add an extra sanity check for this in
    that function.  We cannot see that happen with the current code, but
    future designers being unaware of this risk, may introduce it by
    allowing delivery of very large (> 64k) sk buffers from the bearer
    layer.  This potential problem was identified by Eric Dumazet.
    
    This fixes CVE-2022-0435
    
    Reported-by: Samuel Page <samuel.page@appgate.com>
    Reported-by: Eric Dumazet <edumazet@google.com>
    Fixes: 35c55c9877f8 ("tipc: add neighbor monitoring framework")
    Signed-off-by: Jon Maloy <jmaloy@redhat.com>
    Reviewed-by: Xin Long <lucien.xin@gmail.com>
    Reviewed-by: Samuel Page <samuel.page@appgate.com>
    Reviewed-by: Eric Dumazet <edumazet@google.com>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

commit 3a0a7ec5574b510b067cfc734b8bdb6564b31d4e
Author: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date:   Thu Jan 27 08:16:38 2022 +0100

    moxart: fix potential use-after-free on remove path
    
    commit bd2db32e7c3e35bd4d9b8bbff689434a50893546 upstream.
    
    It was reported that the mmc host structure could be accessed after it
    was freed in moxart_remove(), so fix this by saving the base register of
    the device and using it instead of the pointer dereference.
    
    Cc: Ulf Hansson <ulf.hansson@linaro.org>
    Cc: Xiyu Yang <xiyuyang19@fudan.edu.cn>
    Cc: Xin Xiong <xiongx18@fudan.edu.cn>
    Cc: Xin Tan <tanxin.ctf@gmail.com>
    Cc: Tony Lindgren <tony@atomide.com>
    Cc: Yang Li <yang.lee@linux.alibaba.com>
    Cc: linux-mmc@vger.kernel.org
    Cc: stable <stable@vger.kernel.org>
    Reported-by: whitehat002 <hackyzh002@gmail.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Link: https://lore.kernel.org/r/20220127071638.4057899-1-gregkh@linuxfoundation.org
    Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>


From xen-devel-bounces@lists.xenproject.org Sat Feb 12 09:59:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 12 Feb 2022 09:59:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270748.465064 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIpBa-0004rj-Fz; Sat, 12 Feb 2022 09:59:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270748.465064; Sat, 12 Feb 2022 09:59:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIpBa-0004rc-Ce; Sat, 12 Feb 2022 09:59:22 +0000
Received: by outflank-mailman (input) for mailman id 270748;
 Sat, 12 Feb 2022 09:59:21 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nIpBZ-0004rR-2V; Sat, 12 Feb 2022 09:59:21 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nIpBY-00014c-Tp; Sat, 12 Feb 2022 09:59:20 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nIpBY-0004Fe-Bo; Sat, 12 Feb 2022 09:59:20 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nIpBY-0000mZ-9O; Sat, 12 Feb 2022 09:59:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=tQa6Th7R4ieAlixdtt1IGfl2E+5llyedUH4faBnRy+g=; b=FyITlin0RpkGjWgwD2uaQ9DtDX
	zbca3aDRRZIeSyrBx6aGT+xh43Ma2pokLE+cLWV31+ewF0JUQVcivEgKIpEazVdERpszqqe3pGIci
	7J/OtIGIK10Gxk/riwB0t3bfP3SsDvl6k7cJGvXqtXLycA91B6trVV/IqmaTSYeHdVVM=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168090-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 168090: regressions - trouble: blocked/broken/fail/pass
X-Osstest-Failures:
    libvirt:build-arm64:<job status>:broken:regression
    libvirt:build-arm64-pvops:<job status>:broken:regression
    libvirt:build-arm64-xsm:<job status>:broken:regression
    libvirt:build-arm64-pvops:host-install(4):broken:regression
    libvirt:build-arm64:host-install(4):broken:regression
    libvirt:build-arm64-xsm:host-install(4):broken:regression
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=6ccafcb53e2bdf50695c151cf768a36fc5697bab
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 12 Feb 2022 09:59:20 +0000

flight 168090 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168090/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-arm64                     <job status>                 broken
 build-arm64-pvops               <job status>                 broken
 build-arm64-xsm                 <job status>                 broken
 build-arm64-pvops             4 host-install(4)        broken REGR. vs. 151777
 build-arm64                   4 host-install(4)        broken REGR. vs. 151777
 build-arm64-xsm               4 host-install(4)        broken REGR. vs. 151777
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 build-arm64-libvirt           1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              6ccafcb53e2bdf50695c151cf768a36fc5697bab
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  582 days
Failing since        151818  2020-07-11 04:18:52 Z  581 days  563 attempts
Testing same since   168090  2022-02-12 04:18:54 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brad Laue <brad@brad-x.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Christophe Fergeau <cfergeau@redhat.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Divya Garg <divya.garg@nutanix.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Emilio Herrera <ehespinosa57@gmail.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Ivan Teterevkov <ivan.teterevkov@nutanix.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jing Qi <jinqi@redhat.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Lubomir Rintel <lkundrak@v3.sk>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nicolas Lécureuil <neoclust@mageia.org>
  Nicolas Lécureuil <nicolas.lecureuil@siveo.net>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Rohit Kumar <rohit.kumar3@nutanix.com>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  shenjiatong <yshxxsjt715@gmail.com>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tu Qiang <tu.qiang35@zte.com.cn>
  Tuguoyi <tu.guoyi@h3c.com>
  tuqiang <tu.qiang35@zte.com.cn>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Vineeth Pillai <viremana@linux.microsoft.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yasuhiko Kamata <belphegor@belbel.or.jp>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              broken  
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  broken  
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          blocked 
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            broken  
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary

broken-job build-arm64 broken
broken-job build-arm64-pvops broken
broken-job build-arm64-xsm broken
broken-step build-arm64-pvops host-install(4)
broken-step build-arm64 host-install(4)
broken-step build-arm64-xsm host-install(4)

Not pushing.

(No revision log; it would be 97411 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Feb 12 10:25:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 12 Feb 2022 10:25:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270759.465075 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIpab-000866-Lt; Sat, 12 Feb 2022 10:25:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270759.465075; Sat, 12 Feb 2022 10:25:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIpab-00085z-ID; Sat, 12 Feb 2022 10:25:13 +0000
Received: by outflank-mailman (input) for mailman id 270759;
 Sat, 12 Feb 2022 10:25:12 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=IMsy=S3=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nIpaa-00085t-Lf
 for xen-devel@lists.xenproject.org; Sat, 12 Feb 2022 10:25:12 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0e5c6d96-8bee-11ec-8eb8-a37418f5ba1a;
 Sat, 12 Feb 2022 11:25:11 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id C7BA01F3AB;
 Sat, 12 Feb 2022 10:25:09 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 99727133A6;
 Sat, 12 Feb 2022 10:25:09 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id VLYyJAWLB2IUJwAAMHmgww
 (envelope-from <jgross@suse.com>); Sat, 12 Feb 2022 10:25:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0e5c6d96-8bee-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1644661509; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=5yXRQYPz7tyCPh12Y6Rub4FEyQM5xqaM15UqmQ0cHI0=;
	b=hK0dVY9gMUYw5lm60eoc/yhhP8D82RZIj0sUbLJvcZM0BVyEIomMKz9HLqR75ORkZnMjZg
	Z/p4dfWEuxqFeT/MkfK1Z+PNmpLkaRgZmBCd2chTSVshmMJXI8vQJMzlcFvzoWtpQoWfPI
	wfeX/xpC7jJcU4NB/IOcjxqsqWhY7mQ=
From: Juergen Gross <jgross@suse.com>
To: torvalds@linux-foundation.org
Cc: linux-kernel@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	boris.ostrovsky@oracle.com
Subject: [GIT PULL] xen: branch for v5.17-rc4
Date: Sat, 12 Feb 2022 11:25:09 +0100
Message-Id: <20220212102509.24629-1-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Linus,

Please git pull the following tag:

 git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-5.17a-rc4-tag

xen: branch for v5.17-rc4

It contains the following patches:

- 2 small cleanups

- Another fix for addressing the EFI framebuffer above 4GB when running
  as Xen dom0

- A patch for letting Xen guests use reserved bits in MSI- and IO-APIC-
  registers for extended APIC-IDs the same way KVM guests are doing it
  already.

Thanks.

Juergen

 arch/x86/include/asm/xen/cpuid.h |  7 +++++++
 arch/x86/xen/enlighten_hvm.c     |  9 +++++++--
 arch/x86/xen/vga.c               | 16 ++++++++--------
 drivers/xen/pci.c                |  2 +-
 4 files changed, 23 insertions(+), 11 deletions(-)

Cai Huoqing (1):
      xen/pci: Make use of the helper macro LIST_HEAD()

Jan Beulich (1):
      xen/x86: obtain full video frame buffer address for Dom0 also under EFI

Jiapeng Chong (1):
      xen/x2apic: Fix inconsistent indenting

Roger Pau Monne (1):
      xen/x86: detect support for extended destination ID


From xen-devel-bounces@lists.xenproject.org Sat Feb 12 12:10:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 12 Feb 2022 12:10:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270770.465086 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIrDw-0000jo-Bb; Sat, 12 Feb 2022 12:09:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270770.465086; Sat, 12 Feb 2022 12:09:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIrDw-0000jh-6r; Sat, 12 Feb 2022 12:09:56 +0000
Received: by outflank-mailman (input) for mailman id 270770;
 Sat, 12 Feb 2022 12:09:55 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nIrDv-0000jX-3Z; Sat, 12 Feb 2022 12:09:55 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nIrDu-0003PO-Vf; Sat, 12 Feb 2022 12:09:55 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nIrDu-0001pd-Ih; Sat, 12 Feb 2022 12:09:54 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nIrDu-0004g1-ID; Sat, 12 Feb 2022 12:09:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=eSz+axHRvzQp15MHxxqV1CLbDaH3e5yLNmf+RRz4FRY=; b=FIpxM+1x/wHoJ8BA8RA4RV5L70
	wrMYqQDmVlRM8Boa5Z4+iWOPnOSGCA55iK/oeTpGHGe0vxIpTU9VPpjOxW+nHfCJt0TpIvPrF6hin
	eN+D4N4J4fh0JhnQJm7+4P80iDxWY1hVuuvkDGNHdGWjy5xmlCrhg82mIwof0yrnV1b0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168088-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 168088: trouble: blocked/broken/fail/pass
X-Osstest-Failures:
    xen-unstable:build-arm64:<job status>:broken:regression
    xen-unstable:build-arm64-pvops:<job status>:broken:regression
    xen-unstable:build-arm64-xsm:<job status>:broken:regression
    xen-unstable:build-arm64-pvops:host-install(4):broken:regression
    xen-unstable:build-arm64-xsm:host-install(4):broken:regression
    xen-unstable:build-arm64:host-install(4):broken:regression
    xen-unstable:test-arm64-arm64-xl-credit2:<job status>:broken:regression
    xen-unstable:test-arm64-arm64-xl-xsm:<job status>:broken:regression
    xen-unstable:test-arm64-arm64-xl-credit1:<job status>:broken:regression
    xen-unstable:test-arm64-arm64-xl-seattle:<job status>:broken:regression
    xen-unstable:test-arm64-arm64-xl-seattle:host-install(5):broken:heisenbug
    xen-unstable:test-arm64-arm64-xl-credit2:host-install(5):broken:heisenbug
    xen-unstable:test-arm64-arm64-xl-xsm:host-install(5):broken:heisenbug
    xen-unstable:test-arm64-arm64-xl-credit1:host-install(5):broken:heisenbug
    xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-unstable:test-arm64-arm64-examine:build-check(1):blocked:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    xen-unstable:test-arm64-arm64-xl:build-check(1):blocked:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking
    xen-unstable:build-arm64-libvirt:build-check(1):blocked:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=87319afb96973213ec0a76270d93696f3b8d6743
X-Osstest-Versions-That:
    xen=87319afb96973213ec0a76270d93696f3b8d6743
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 12 Feb 2022 12:09:54 +0000

flight 168088 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168088/

Failures and problems with tests :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-arm64                     <job status>                 broken
 build-arm64-pvops               <job status>                 broken
 build-arm64-xsm                 <job status>                 broken
 build-arm64-pvops             4 host-install(4)        broken REGR. vs. 168081
 build-arm64-xsm               4 host-install(4)        broken REGR. vs. 168081
 build-arm64                   4 host-install(4)        broken REGR. vs. 168081
 test-arm64-arm64-xl-credit2     <job status>                 broken  in 168081
 test-arm64-arm64-xl-xsm         <job status>                 broken  in 168081
 test-arm64-arm64-xl-credit1     <job status>                 broken  in 168081
 test-arm64-arm64-xl-seattle     <job status>                 broken  in 168081

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-xl-seattle  5 host-install(5) broken in 168081 pass in 168075
 test-arm64-arm64-xl-credit2  5 host-install(5) broken in 168081 pass in 168075
 test-arm64-arm64-xl-xsm      5 host-install(5) broken in 168081 pass in 168075
 test-arm64-arm64-xl-credit1  5 host-install(5) broken in 168081 pass in 168075
 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 168075 pass in 168088
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 168081
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 168081

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-examine      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl           1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit1   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit2   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-seattle   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-thunderx  1 build-check(1)               blocked  n/a
 build-arm64-libvirt           1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-vhd       1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-xsm       1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-seattle 15 migrate-support-check fail in 168075 never pass
 test-arm64-arm64-xl-seattle 16 saverestore-support-check fail in 168075 never pass
 test-arm64-arm64-xl-credit2 15 migrate-support-check fail in 168075 never pass
 test-arm64-arm64-xl-credit2 16 saverestore-support-check fail in 168075 never pass
 test-arm64-arm64-xl-xsm     15 migrate-support-check fail in 168075 never pass
 test-arm64-arm64-xl-credit1 15 migrate-support-check fail in 168075 never pass
 test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 168075 never pass
 test-arm64-arm64-xl-credit1 16 saverestore-support-check fail in 168075 never pass
 test-arm64-arm64-xl         15 migrate-support-check fail in 168081 never pass
 test-arm64-arm64-xl     16 saverestore-support-check fail in 168081 never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail in 168081 never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail in 168081 never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check fail in 168081 never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail in 168081 never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check fail in 168081 never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail in 168081 never pass
 test-arm64-arm64-xl-vhd     14 migrate-support-check fail in 168081 never pass
 test-arm64-arm64-xl-vhd 15 saverestore-support-check fail in 168081 never pass
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail like 168075
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168081
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168081
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168081
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168081
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168081
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168081
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168081
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168081
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168081
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168081
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168081
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168081
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  87319afb96973213ec0a76270d93696f3b8d6743
baseline version:
 xen                  87319afb96973213ec0a76270d93696f3b8d6743

Last test of basis   168088  2022-02-12 01:53:20 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              broken  
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  broken  
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          blocked 
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            broken  
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          blocked 
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  fail    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      blocked 
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  blocked 
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  blocked 
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     blocked 
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 blocked 
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      blocked 
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary

broken-job build-arm64 broken
broken-job build-arm64-pvops broken
broken-job build-arm64-xsm broken
broken-step build-arm64-pvops host-install(4)
broken-step build-arm64-xsm host-install(4)
broken-step build-arm64 host-install(4)
broken-job test-arm64-arm64-xl-credit2 broken
broken-job test-arm64-arm64-xl-xsm broken
broken-job test-arm64-arm64-xl-credit1 broken
broken-job test-arm64-arm64-xl-seattle broken

Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Sat Feb 12 12:44:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 12 Feb 2022 12:44:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270781.465097 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIrkw-0004jl-1v; Sat, 12 Feb 2022 12:44:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270781.465097; Sat, 12 Feb 2022 12:44:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIrkv-0004je-V0; Sat, 12 Feb 2022 12:44:01 +0000
Received: by outflank-mailman (input) for mailman id 270781;
 Sat, 12 Feb 2022 12:44:00 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nIrku-0004jY-Fp
 for xen-devel@lists.xenproject.org; Sat, 12 Feb 2022 12:44:00 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nIrkt-00040P-AI; Sat, 12 Feb 2022 12:43:59 +0000
Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nIrkt-0004Gn-4n; Sat, 12 Feb 2022 12:43:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=8RDYz19e6hQ6eQ6Xx8thMUZgK+ZufT++G8O6jPEqbnw=; b=SzOAenoeQ0rAwSz9m1v6dwtjfq
	VUm7mba5jpcx1drAW64qPXAiltmbN15/Msh3zi1hk1XaHkcIMHvNCaUs2qs25XSBr0IngcZyx3dEP
	0a4ppC1EQy24X7eNCfyQI+5Hs4dbM66m3SS69XszQy4XV5an/Q9VxRWq1NNlwiH9xahg=;
Message-ID: <c13f6312-3922-4504-3248-e2e4701b1a10@xen.org>
Date: Sat, 12 Feb 2022 12:43:56 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.1
Subject: Re: [RFC v2 5/8] xen/arm: introduce SCMI-SMC mediator driver
To: Bertrand Marquis <Bertrand.Marquis@arm.com>,
 Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <cover.1644341635.git.oleksii_moisieiev@epam.com>
 <cb1493f5d9b5c3437268054b4a8e345cb35c8708.1644341635.git.oleksii_moisieiev@epam.com>
 <F9811680-C6EC-4372-A451-5C1DA279E35E@arm.com>
 <20220211104403.GA2291814@EPUAKYIW015D>
 <A9FF3FBC-C29D-4A17-8737-EBABEF240BA2@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <A9FF3FBC-C29D-4A17-8737-EBABEF240BA2@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 11/02/2022 11:18, Bertrand Marquis wrote:
> Do you plan to add support for other boards ?
> 
> Did you discuss more in general with the linux kernel guys to see if this
> approach was agreed and will be adopted by other manufacturers ?
> 
> All in all I think this is a good idea but I fear that all this will actually only
> be used by one board or one manufacturer and other might use a different
> strategy, I would like to unrisk this before merging this in Xen.

In the past we merged code that would only benefits one vendor (i.e. 
EEMI). That said, this was a vendor specific protocol. I believe the 
situation is different here because the spec is meant to be generic.

> @julien and Stefano: what is your view here ?

I share the same concerns as you. I think we need to make sure all the 
pieces we rely on (e.g. firmware, DT bindings) have been agreed before 
we can merge such code in Xen.

The first step is to have all the pieces available in public so they can 
be reviewed and tested together.

Oleksii, on a separate e-mail, you said you made change for ATF. How 
much of those changes was related to support for Xen? If they are some, 
then I think they should be upstreamed first.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Sat Feb 12 13:11:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 12 Feb 2022 13:11:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270790.465108 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIsB1-0007zT-Bw; Sat, 12 Feb 2022 13:10:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270790.465108; Sat, 12 Feb 2022 13:10:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIsB1-0007zM-8d; Sat, 12 Feb 2022 13:10:59 +0000
Received: by outflank-mailman (input) for mailman id 270790;
 Sat, 12 Feb 2022 13:10:58 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nIsB0-0007zG-Id
 for xen-devel@lists.xenproject.org; Sat, 12 Feb 2022 13:10:58 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nIsAw-0004Tx-8m; Sat, 12 Feb 2022 13:10:54 +0000
Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nIsAw-00060U-3K; Sat, 12 Feb 2022 13:10:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=AK4vEzvFoCH6e3/5YXNZ8uag4c5YYUEXBP0I+v28ygg=; b=jruou1ZuNJZzRVNtnOd1GLc+Sm
	ERfLay7O94i/qtMzYivCYm84/IOaJ43BFEaWVgfQ/JYvG2rWCOL6TCH8anj6Sp0nX9SNAz2Qu5r2r
	VHDIAIkmkPoSD47FZcNG4IVASxZJzJUmAG2+xtMl7sEQ67dYHgeANjISyWV++StpLKkQ=;
Message-ID: <d2a2f715-9eab-aeb1-8099-4db614eb26a8@xen.org>
Date: Sat, 12 Feb 2022 13:10:52 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.1
Subject: Re: [PATCH RFC 1/3] xen/efi: Always query the console information and
 get GOP
To: Elliott Mitchell <ehem+xen@m5p.com>
Cc: Jan Beulich <jbeulich@suse.com>, Julien Grall <jgrall@amazon.com>,
 xen-devel@lists.xenproject.org, Daniel Kiper <daniel.kiper@oracle.com>
References: <20220206192839.75711-1-julien@xen.org>
 <20220206192839.75711-2-julien@xen.org>
 <88741681-929f-4cda-e841-023bdbf8f772@suse.com>
 <26cdd9cf-15d6-a463-b1bb-28964005f618@xen.org>
 <YgcOg6p8D+6hWWsE@mattapan.m5p.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <YgcOg6p8D+6hWWsE@mattapan.m5p.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 12/02/2022 01:33, Elliott Mitchell wrote:
> On Mon, Feb 07, 2022 at 06:52:57PM +0000, Julien Grall wrote:
>> On 07/02/2022 08:46, Jan Beulich wrote:
>>> On 06.02.2022 20:28, Julien Grall wrote:
>>>>
>>>> It is not entirely clear to me why the GOP was only fetched when
>>>> the configuration file is used.
>>>>
>>>> I have tested this on RPI4 and it seems to work. Any chance this
>>>> was done to workaround an x86 platform?
>>>
>>> This was done so in the context of making the code work for Arm. See
>>> commit c38cf865ec82 ("EFI: ignore EFI commandline, skip console setup
>>> when booted from GRUB"), the description of which explicitly says
>>>
>>> "Don't do EFI console or video configuration when booted by GRUB.  The EFI boot
>>>    code does some console and video initialization to support native EFI boot from
>>>    the EFI boot manager or EFI shell.  This initlization should not be done when
>>>    booted using GRUB."
>>
>> I read that and still couldn't figure out why this was done like that.
> 
> The most likely motivation was simply "Eww!  ACPI/UEFI use gobs of
> memory!  Purge the abomination!"
> 
> Unfortunately ACPI/UEFI are large an complex due to trying to solve a
> large and complex problem.  ACPI/UEFI attempt to provide an OS agnostic
> presentation of the hardware layout.  Whereas device-trees are a common
> *format* for presenting hardware to *an* OS (similar to how JSON is a
> common format).
> 
> Due to the size and complexity, most developers have preferred the
> simpler device-tree format even though that severely limits OS choice.
> As such, nuking ACPI/UEFI's presence is common in the ARM world.  Versus > the x86 world where Intel dragged everyone onto ACPI/UEFI.
> 
> One can see this in patches like Roman Shaposhnik's "Making full 2G of
> memory available to Xen on HiKey" which simply tosses EFI into the
> garbage bin as useless overhead.

I couldn't find a series with this name in my archives. By any chance, 
are you referring to [1]?

[...]

> 
> You stated your patch was for 5.17-rc2.  How much backporting would you
> expect this patch to be viable for?  (I'm unsure how much churn is
> occuring in the relevant portions of Linux) The long-term branches of
> Linux include 5.4.179, 5.10.100 and 5.15.23.  `patch` indicated it could
> apply to 5.10.92 source with fuzz (hmm).  This suggests 5.15 is likely
> viable, but 5.10 is risky and 5.4 is a very long shot.
I haven't looked at backports, so I don't know. But this is not a patch 
I would consider to request for backport myself because IHMO this is 
adding device support.

Cheers,

[1] 
https://lore.kernel.org/all/CAMmSBy8Zh00tebTvz=__GDv478++b-2t4248YnkH0W9DVgqKbw@mail.gmail.com/

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Sat Feb 12 14:00:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 12 Feb 2022 14:00:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270797.465119 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIswU-00042U-Rc; Sat, 12 Feb 2022 14:00:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270797.465119; Sat, 12 Feb 2022 14:00:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIswU-000426-Nr; Sat, 12 Feb 2022 14:00:02 +0000
Received: by outflank-mailman (input) for mailman id 270797;
 Sat, 12 Feb 2022 14:00:01 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nIswT-0003jv-7s; Sat, 12 Feb 2022 14:00:01 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nIswT-0005KC-3z; Sat, 12 Feb 2022 14:00:01 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nIswS-0006hK-JV; Sat, 12 Feb 2022 14:00:00 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nIswS-0001z9-J5; Sat, 12 Feb 2022 14:00:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=G0nOJtPRlkHeNXVACA2uTjYxQB13qRgtKuDC3D0xbb8=; b=WymxO89xEfZAwPqdFq536L0Fdn
	mXvM3u2zPIisml3TCgLOxBx5TsOWHPMrCVnGzp0sB6WQJKKfvCGwzQ8YB7HarbLsrjmDycLToIcKQ
	wkOsrnRinnc15JWW3A0NaD1nPkOAn/PYrwy/JcakQdMVvxnpnwrOu6GR8Ea+vBetZ4fE=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168089-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 168089: trouble: blocked/broken/fail/pass
X-Osstest-Failures:
    linux-linus:build-arm64:<job status>:broken:regression
    linux-linus:build-arm64-pvops:<job status>:broken:regression
    linux-linus:build-arm64-xsm:<job status>:broken:regression
    linux-linus:build-arm64-xsm:host-install(4):broken:regression
    linux-linus:build-arm64:host-install(4):broken:regression
    linux-linus:build-arm64-pvops:host-install(4):broken:regression
    linux-linus:test-arm64-arm64-examine:build-check(1):blocked:nonblocking
    linux-linus:build-arm64-libvirt:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=83e396641110663d3c7bb25b9bc0c6a750359ecf
X-Osstest-Versions-That:
    linux=f1baf68e1383f6ed93eb9cff2866d46562607a43
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 12 Feb 2022 14:00:00 +0000

flight 168089 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168089/

Failures and problems with tests :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-arm64                     <job status>                 broken
 build-arm64-pvops               <job status>                 broken
 build-arm64-xsm                 <job status>                 broken
 build-arm64-xsm               4 host-install(4)        broken REGR. vs. 168080
 build-arm64                   4 host-install(4)        broken REGR. vs. 168080
 build-arm64-pvops             4 host-install(4)        broken REGR. vs. 168080

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-examine      1 build-check(1)               blocked  n/a
 build-arm64-libvirt           1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl           1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit1   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit2   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-seattle   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-thunderx  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-vhd       1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-xsm       1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168080
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168080
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168080
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168080
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168080
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail like 168080
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168080
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168080
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168080
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                83e396641110663d3c7bb25b9bc0c6a750359ecf
baseline version:
 linux                f1baf68e1383f6ed93eb9cff2866d46562607a43

Last test of basis   168080  2022-02-11 00:09:22 Z    1 days
Failing since        168086  2022-02-11 20:11:19 Z    0 days    2 attempts
Testing same since   168089  2022-02-12 04:02:27 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Aaron Liu <aaron.liu@amd.com>
  Alex Deucher <alexander.deucher@amd.com>
  Alexander Stein <alexander.stein@ew.tq-group.com>
  Alexandre Ghiti <alexandre.ghiti@canonical.com>
  Alim Akhtar <alim.akhtar@samsung.com>
  Alviro Iskandar Setiawan <alviro.iskandar@gmail.com>
  Ammar Faizi <ammarfaizi2@gnuweeb.org>
  Andreas Gruenbacher <agruenba@redhat.com>
  Andrzej Pietrasiewicz <andrzej.p@collabora.com>
  Andy Shevchenko <andriy.shevchenko@linux.intel.com>
  Arnd Bergmann <arnd@arndb.de>
  Aswath Govindraju <a-govindraju@ti.com>
  Aurelien Jarno <aurelien@aurel32.net>
  Bartosz Golaszewski <brgl@bgdev.pl>
  Bean Huo <beanhuo@micron.com>
  Benjamin Gaignard <benjamin.gaignard@collabora.com>
  Bjorn Helgaas <bhelgaas@google.com>
  Bob Peterson <rpeterso@redhat.com>
  Brian Norris <briannorris@chromium.org>
  Catalin Marinas <catalin.marinas@arm.com>
  Changbin Du <changbin.du@gmail.com>
  Chia-Wei Wang <chiawei_wang@aspeedtech.com>
  Christian Hewitt <christianshewitt@gmail.com>
  Christoph Hellwig <hch@lst.de>
  Christoph Niedermaier <cniedermaier@dh-electronics.com>
  Christophe JAILLET <christophe.jaillet@wanadoo.fr>
  Damien Le Moal <damien.lemoal@opensource.wdc.com>
  Daniel Bristot de Oliveira <bristot@kernel.org>
  Daniel Stone <daniels@collabora.com>
  Daniel Vetter <daniel.vetter@ffwll.ch>
  Daniel Vetter <daniel.vetter@intel.com>
  Daniel Wheeler <daniel.wheeler@amd.com>
  Dave Airlie <airlied@redhat.com>
  Dave Stevenson <dave.stevenson@raspberrypi.com>
  Dinh Nguyen <dinguyen@kernel.org>
  Dmytro Laktyushkin <Dmytro.Laktyushkin@amd.com>
  Dongjin Kim <tobetter@gmail.com>
  Fabio Estevam <festevam@gmail.com>
  Geert Uytterhoeven <geert+renesas@glider.be>
  Geert Uytterhoeven <geert@linux-m68k.org>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>Cc: Dave Airlie <airlied@gmail.com>
  Hans de Goede <hdegoede@redhat.com>
  Hector Martin <marcan@marcan.st>
  Heiko Stuebner <heiko@sntech.de>
  Helge Deller <deller@gmx.de>
  Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
  JaeSang Yoo <js.yoo.5b@gmail.com>
  JaeSang Yoo <jsyoo5b@gmail.com>
  Jan Kara <jack@suse.cz>
  Jani Nikula <jani.nikula@intel.com>
  Jarkko Nikula <jarkko.nikula@bitmer.com>
  Jasdeep Dhillon <jdhillon@amd.com>
  Jayesh Choudhary <j-choudhary@ti.com>
  Jens Axboe <axboe@kernel.dk>
  Jens Wiklander <jens.wiklander@linaro.org>
  Jerome Forissier <jerome@forissier.org>
  Jisheng Zhang <jszhang@kernel.org>
  Joel Stanley <joel@jms.id.au>
  Kai-Heng Feng <kai.heng.feng@canonical.com>
  Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Linus Walleij <linus.walleij@linaro.org>
  Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
  Lucas De Marchi <lucas.demarchi@intel.com>
  Lutz Koschorreck <theleks@ko-hh.de>
  Marek Vasut <marex@denx.de>
  Mario Limonciello <mario.limonciello@amd.com>
  Mark Brown <broonie@kernel.org>
  Martin Blumenstingl <martin.blumenstingl@googlemail.com>
  Martin Kepplinger <martin.kepplinger@puri.sm>
  Maxime Ripard <maxime@cerno.tech>
  Michael Walle <michael@walle.cc>
  Myrtle Shah <gatecat@ds0.me>
  Neil Armstrong <narmstrong@baylibre.com>
  Niklas Cassel <niklas.cassel@wdc.com>
  Nishanth Menon <nm@ti.com>
  Palmer Dabbelt <palmer@rivosinc.com>
  Philippe Cornu <philippe.cornu@foss.st.com>
  Pingfan Liu <kernelfans@gmail.com>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Rob Herring <robh@kernel.org>
  Robin Murphy <robin.murphy@arm.com>
  Roman Li <Roman.Li@amd.com>
  Sagi Grimberg <sagi@grimberg.me>
  Sam Protsenko <semen.protsenko@linaro.org>
  Sam Ravnborg <sam@ravnborg.org>
  Sascha Hauer <s.hauer@pengutronix.de>
  Shakeel Butt <shakeelb@google.com>
  Shawn Guo <shawnguo@kernel.org>
  Steven Rostedt (Google) <rostedt@goodmis.org>
  Sven Peter <sven@svenpeter.dev>
  Sylwester Nawrocki <s.nawrocki@samsung.com>
  Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
  Thomas Hellström <thomas.hellstrom@linux.intel.com>
  Thomas Zimmermann <tzimmermann@suse.de>
  Tim Harvey <tharvey@gateworks.com>
  Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
  Tony Lindgren <tony@atomide.com>
  Tvrtko Ursulin <tvrtko.ursulin@intel.com>
  Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
  Vignesh Raghavendra <vigneshr@ti.com>
  Ville Syrjälä <ville.syrjala@linux.intel.com>
  Vlastimil Babka <vbabka@suse.cz>
  Wan Jiabing <wanjiabing@vivo.com>
  Yang Wang <KevinYang.Wang@amd.com>
  Ye Guojin <ye.guojin@zte.com.cn>
  Yizhuo Zhai <yzhai003@ucr.edu>
  Zhan Liu <Zhan.Liu@amd.com>
  Zoltán Böszörményi <zboszor@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              broken  
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  broken  
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          blocked 
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            broken  
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          blocked 
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      blocked 
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  blocked 
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  blocked 
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     blocked 
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 blocked 
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      blocked 
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary

broken-job build-arm64 broken
broken-job build-arm64-pvops broken
broken-job build-arm64-xsm broken
broken-step build-arm64-xsm host-install(4)
broken-step build-arm64 host-install(4)
broken-step build-arm64-pvops host-install(4)

Not pushing.

(No revision log; it would be 2806 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Feb 12 16:47:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 12 Feb 2022 16:47:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270808.465129 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIvYb-00033P-6p; Sat, 12 Feb 2022 16:47:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270808.465129; Sat, 12 Feb 2022 16:47:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIvYb-00033I-39; Sat, 12 Feb 2022 16:47:33 +0000
Received: by outflank-mailman (input) for mailman id 270808;
 Sat, 12 Feb 2022 16:47:32 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Gda3=S3=mit.edu=tytso@srs-se1.protection.inumbo.net>)
 id 1nIvYa-000339-Ct
 for xen-devel@lists.xenproject.org; Sat, 12 Feb 2022 16:47:32 +0000
Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 772730df-8c23-11ec-b215-9bbe72dcb22c;
 Sat, 12 Feb 2022 17:47:30 +0100 (CET)
Received: from cwcc.thunk.org (pool-108-7-220-252.bstnma.fios.verizon.net
 [108.7.220.252]) (authenticated bits=0)
 (User authenticated as tytso@ATHENA.MIT.EDU)
 by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 21CGkxsP010096
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Sat, 12 Feb 2022 11:47:00 -0500
Received: by cwcc.thunk.org (Postfix, from userid 15806)
 id 1847215C0040; Sat, 12 Feb 2022 11:46:59 -0500 (EST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 772730df-8c23-11ec-b215-9bbe72dcb22c
Date: Sat, 12 Feb 2022 11:46:59 -0500
From: "Theodore Ts'o" <tytso@mit.edu>
To: Qing Wang <wangqing@vivo.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
        Roger Pau =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>,
        Jens Axboe <axboe@kernel.dk>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Jani Nikula <jani.nikula@linux.intel.com>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
        Rodrigo Vivi <rodrigo.vivi@intel.com>, David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Alex Deucher <alexander.deucher@amd.com>,
        Christian =?iso-8859-1?Q?K=F6nig?= <christian.koenig@amd.com>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        Jiri Kosina <jikos@kernel.org>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Alasdair Kergon <agk@redhat.com>, Mike Snitzer <snitzer@redhat.com>,
        dm-devel@redhat.com, Mauro Carvalho Chehab <mchehab@kernel.org>,
        Hans Verkuil <hverkuil@xs4all.nl>, xen-devel@lists.xenproject.org,
        linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-clk@vger.kernel.org, intel-gfx@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
        linux-input@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [PATCH V2 00/13] use time_is_xxx() instead of jiffies judgment
Message-ID: <Ygfkg0n6RvvJYMJa@mit.edu>
References: <1644546640-23283-1-git-send-email-wangqing@vivo.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1644546640-23283-1-git-send-email-wangqing@vivo.com>

On Thu, Feb 10, 2022 at 06:30:23PM -0800, Qing Wang wrote:
> From: Wang Qing <wangqing@vivo.com>
> 
> It is better to use time_is_xxx() directly instead of jiffies judgment
> for understanding.

Hi Wang,

"judgement" doesn't really make sense as a description to an English
speaker.  The following a commit desription (for all of these series)
is probably going to be a bit more understable:

Use the helper function time_is_{before,after}_jiffies() to improve
code readability.

Cheers,

						- Ted


From xen-devel-bounces@lists.xenproject.org Sat Feb 12 17:17:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 12 Feb 2022 17:17:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270818.465141 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIw1N-0006MX-M9; Sat, 12 Feb 2022 17:17:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270818.465141; Sat, 12 Feb 2022 17:17:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIw1N-0006MQ-IF; Sat, 12 Feb 2022 17:17:17 +0000
Received: by outflank-mailman (input) for mailman id 270818;
 Sat, 12 Feb 2022 17:17:16 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=4/jW=S3=kernel.org=pr-tracker-bot@srs-se1.protection.inumbo.net>)
 id 1nIw1M-0006MK-Ok
 for xen-devel@lists.xenproject.org; Sat, 12 Feb 2022 17:17:16 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9ec34492-8c27-11ec-b215-9bbe72dcb22c;
 Sat, 12 Feb 2022 18:17:14 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 2F1476112D;
 Sat, 12 Feb 2022 17:17:13 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPS id 8AAD6C340ED;
 Sat, 12 Feb 2022 17:17:12 +0000 (UTC)
Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org
 (localhost.localdomain [127.0.0.1])
 by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id
 75161E6BB38; Sat, 12 Feb 2022 17:17:12 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9ec34492-8c27-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1644686232;
	bh=K9FxhrDSiUEfPIdtyrZQqRS7/xd1SjAvYu9qrqtjRFM=;
	h=Subject:From:In-Reply-To:References:Date:To:Cc:From;
	b=IwQPEdhOPywW3Jsg6ZA196lwmukcmkusvnsvjebABmWwagXViKLE5j71nVcECbJjH
	 7kPKWGUlGawJbySO2qemnX8zHyBVK0THD/NjyUeDjq6w5wagB4xdHjTALUxIWKpM5t
	 erKG2HG9gx2YQghwcJz4zfm9WmWiaArk+9CTUHSSjZ8NeJ0u7x4zO0BPzgX/Tj0nYO
	 /gYlYz3oq/Bhf7+YsB4Z8aBTdeOoV4Ul8E5tPtYzAZYMh/LfppOxqpz943hNFulzfn
	 sPP6QBYnX4da6ykk9Vb2XU1YLFC2Eh9skY5Kv1hVAA6qk3Z/6LAfLjEBKHQMGA14SA
	 cxZ0spG0HWoWA==
Subject: Re: [GIT PULL] xen: branch for v5.17-rc4
From: pr-tracker-bot@kernel.org
In-Reply-To: <20220212102509.24629-1-jgross@suse.com>
References: <20220212102509.24629-1-jgross@suse.com>
X-PR-Tracked-List-Id: <linux-kernel.vger.kernel.org>
X-PR-Tracked-Message-Id: <20220212102509.24629-1-jgross@suse.com>
X-PR-Tracked-Remote: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-5.17a-rc4-tag
X-PR-Tracked-Commit-Id: f66edf684edcb85c1db0b0aa8cf1a9392ba68a9d
X-PR-Merge-Tree: torvalds/linux.git
X-PR-Merge-Refname: refs/heads/master
X-PR-Merge-Commit-Id: 4a387c98b3abc7cf9a2281f01f9b4dd7dbc48f65
Message-Id: <164468623247.20961.11131810270936389812.pr-tracker-bot@kernel.org>
Date: Sat, 12 Feb 2022 17:17:12 +0000
To: Juergen Gross <jgross@suse.com>
Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com

The pull request you sent on Sat, 12 Feb 2022 11:25:09 +0100:

> git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-5.17a-rc4-tag

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/4a387c98b3abc7cf9a2281f01f9b4dd7dbc48f65

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html


From xen-devel-bounces@lists.xenproject.org Sat Feb 12 18:20:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 12 Feb 2022 18:20:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270825.465152 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIx0V-0004aU-G6; Sat, 12 Feb 2022 18:20:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270825.465152; Sat, 12 Feb 2022 18:20:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIx0V-0004aN-Bd; Sat, 12 Feb 2022 18:20:27 +0000
Received: by outflank-mailman (input) for mailman id 270825;
 Sat, 12 Feb 2022 18:20:26 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=/1S/=S3=m5p.com=ehem@srs-se1.protection.inumbo.net>)
 id 1nIx0T-0004aH-UQ
 for xen-devel@lists.xenproject.org; Sat, 12 Feb 2022 18:20:26 +0000
Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7118b3af-8c30-11ec-b215-9bbe72dcb22c;
 Sat, 12 Feb 2022 19:20:23 +0100 (CET)
Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7])
 by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 21CIK8eh030897
 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO);
 Sat, 12 Feb 2022 13:20:14 -0500 (EST) (envelope-from ehem@m5p.com)
Received: (from ehem@localhost)
 by m5p.com (8.16.1/8.15.2/Submit) id 21CIK7Fr030896;
 Sat, 12 Feb 2022 10:20:07 -0800 (PST) (envelope-from ehem)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7118b3af-8c30-11ec-b215-9bbe72dcb22c
Date: Sat, 12 Feb 2022 10:20:07 -0800
From: Elliott Mitchell <ehem+xen@m5p.com>
To: Julien Grall <julien@xen.org>
Cc: Jan Beulich <jbeulich@suse.com>, Julien Grall <jgrall@amazon.com>,
        xen-devel@lists.xenproject.org, Daniel Kiper <daniel.kiper@oracle.com>
Subject: Re: [PATCH RFC 1/3] xen/efi: Always query the console information
 and get GOP
Message-ID: <Ygf6VznolUhlpAzp@mattapan.m5p.com>
References: <20220206192839.75711-1-julien@xen.org>
 <20220206192839.75711-2-julien@xen.org>
 <88741681-929f-4cda-e841-023bdbf8f772@suse.com>
 <26cdd9cf-15d6-a463-b1bb-28964005f618@xen.org>
 <YgcOg6p8D+6hWWsE@mattapan.m5p.com>
 <d2a2f715-9eab-aeb1-8099-4db614eb26a8@xen.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <d2a2f715-9eab-aeb1-8099-4db614eb26a8@xen.org>
X-Spam-Status: No, score=0.4 required=10.0 tests=KHOP_HELO_FCRDNS autolearn=no
	autolearn_force=no version=3.4.5
X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on mattapan.m5p.com

On Sat, Feb 12, 2022 at 01:10:52PM +0000, Julien Grall wrote:
> 
> On 12/02/2022 01:33, Elliott Mitchell wrote:
> > On Mon, Feb 07, 2022 at 06:52:57PM +0000, Julien Grall wrote:
> >> On 07/02/2022 08:46, Jan Beulich wrote:
> >>> On 06.02.2022 20:28, Julien Grall wrote:
> >>>>
> >>>> It is not entirely clear to me why the GOP was only fetched when
> >>>> the configuration file is used.
> >>>>
> >>>> I have tested this on RPI4 and it seems to work. Any chance this
> >>>> was done to workaround an x86 platform?
> >>>
> >>> This was done so in the context of making the code work for Arm. See
> >>> commit c38cf865ec82 ("EFI: ignore EFI commandline, skip console setup
> >>> when booted from GRUB"), the description of which explicitly says
> >>>
> >>> "Don't do EFI console or video configuration when booted by GRUB.  The EFI boot
> >>>    code does some console and video initialization to support native EFI boot from
> >>>    the EFI boot manager or EFI shell.  This initlization should not be done when
> >>>    booted using GRUB."
> >>
> >> I read that and still couldn't figure out why this was done like that.
> > 
> > The most likely motivation was simply "Eww!  ACPI/UEFI use gobs of
> > memory!  Purge the abomination!"
> > 
> > Unfortunately ACPI/UEFI are large an complex due to trying to solve a
> > large and complex problem.  ACPI/UEFI attempt to provide an OS agnostic
> > presentation of the hardware layout.  Whereas device-trees are a common
> > *format* for presenting hardware to *an* OS (similar to how JSON is a
> > common format).
> > 
> > Due to the size and complexity, most developers have preferred the
> > simpler device-tree format even though that severely limits OS choice.
> > As such, nuking ACPI/UEFI's presence is common in the ARM world.  Versus > the x86 world where Intel dragged everyone onto ACPI/UEFI.
> > 
> > One can see this in patches like Roman Shaposhnik's "Making full 2G of
> > memory available to Xen on HiKey" which simply tosses EFI into the
> > garbage bin as useless overhead.
> 
> I couldn't find a series with this name in my archives. By any chance, 
> are you referring to [1]?

The patch may have appeared under more than one title.  The raw content
is publically visible at:

https://github.com/lf-edge/eve/blob/master/pkg/xen/arch/aarch64/0002-arm-efi-mem-detection.patch

The issue is few ARM projects are really trying to support enough
different devices for ACPI/UEFI to hit their forte.  At which point
ACPI/UEFI get treated as worthless overhead.



> > You stated your patch was for 5.17-rc2.  How much backporting would you
> > expect this patch to be viable for?  (I'm unsure how much churn is
> > occuring in the relevant portions of Linux) The long-term branches of
> > Linux include 5.4.179, 5.10.100 and 5.15.23.  `patch` indicated it could
> > apply to 5.10.92 source with fuzz (hmm).  This suggests 5.15 is likely
> > viable, but 5.10 is risky and 5.4 is a very long shot.

> I haven't looked at backports, so I don't know. But this is not a patch 
> I would consider to request for backport myself because IHMO this is 
> adding device support.

People who need this feature are likely to backport it themselves.

Looking at the 5.10.92 source I've got handy, it appears reasonable.  The
fuzz appears to have be a missed newline when I attempted to grab the
patch from the site you used.

You want test reports yet?


-- 
(\___(\___(\______          --=> 8-) EHM <=--          ______/)___/)___/)
 \BS (    |         ehem+sigmsg@m5p.com  PGP 87145445         |    )   /
  \_CS\   |  _____  -O #include <stddisclaimer.h> O-   _____  |   /  _/
8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445




From xen-devel-bounces@lists.xenproject.org Sat Feb 12 18:26:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 12 Feb 2022 18:26:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270832.465163 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIx6b-0005FZ-3m; Sat, 12 Feb 2022 18:26:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270832.465163; Sat, 12 Feb 2022 18:26:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIx6b-0005FS-0G; Sat, 12 Feb 2022 18:26:45 +0000
Received: by outflank-mailman (input) for mailman id 270832;
 Sat, 12 Feb 2022 18:26:43 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nIx6Z-0005FI-T6; Sat, 12 Feb 2022 18:26:43 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nIx6Z-0002D0-Pp; Sat, 12 Feb 2022 18:26:43 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nIx6Z-00039V-9T; Sat, 12 Feb 2022 18:26:43 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nIx6Z-0008RK-90; Sat, 12 Feb 2022 18:26:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=OoHXJWznSGGpQ1cqadPlICP+hmOlf4cyjPFUDt2yOeI=; b=waYO9foiiOKjvyEmSuwUlF5k4J
	kR1vJEZBbw4M56JpabSczQGMV95RS2t3U+ky0UlwBEpssLtRGl/yHDZ1WIVvxSHVWac4+rDVQ4Vz4
	bzFezPbZpX2zbW0lyhZ4hiXOv3pLyiv96l3XahDB/T7YnH4FGyY1bBXUZjIbqE6vGX9Y=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168091-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-5.4 test] 168091: trouble: blocked/broken/fail/pass
X-Osstest-Failures:
    linux-5.4:build-arm64:<job status>:broken:regression
    linux-5.4:build-arm64-pvops:<job status>:broken:regression
    linux-5.4:build-arm64-xsm:<job status>:broken:regression
    linux-5.4:build-arm64-xsm:host-install(4):broken:regression
    linux-5.4:build-arm64-pvops:host-install(4):broken:regression
    linux-5.4:build-arm64:host-install(4):broken:regression
    linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    linux-5.4:test-arm64-arm64-examine:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-xl:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking
    linux-5.4:build-arm64-libvirt:build-check(1):blocked:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=52871671099d1bb3fca5ed076029e4b937bfc053
X-Osstest-Versions-That:
    linux=76fd334f07cc11e047c2237a19b2cf8b1f653ba2
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 12 Feb 2022 18:26:43 +0000

flight 168091 linux-5.4 real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168091/

Failures and problems with tests :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-arm64                     <job status>                 broken
 build-arm64-pvops               <job status>                 broken
 build-arm64-xsm                 <job status>                 broken
 build-arm64-xsm               4 host-install(4)        broken REGR. vs. 168060
 build-arm64-pvops             4 host-install(4)        broken REGR. vs. 168060
 build-arm64                   4 host-install(4)        broken REGR. vs. 168060

Tests which are failing intermittently (not blocking):
 test-armhf-armhf-xl-rtds     18 guest-start/debian.repeat  fail pass in 168087
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 168087

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-examine      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl           1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit1   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit2   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-seattle   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-thunderx  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-vhd       1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-xsm       1 build-check(1)               blocked  n/a
 build-arm64-libvirt           1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168060
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168060
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168060
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168060
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168060
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168060
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168060
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168060
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168060
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168060
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168060
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168060
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                52871671099d1bb3fca5ed076029e4b937bfc053
baseline version:
 linux                76fd334f07cc11e047c2237a19b2cf8b1f653ba2

Last test of basis   168060  2022-02-08 17:43:16 Z    4 days
Testing same since   168084  2022-02-11 08:43:38 Z    1 days    4 attempts

------------------------------------------------------------
People who touched revisions under test:
  Florian Fainelli <f.fainelli@gmail.com>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Guenter Roeck <linux@roeck-us.net>
  Jon Hunter <jonathanh@nvidia.com>
  Jon Maloy <jmaloy@redhat.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Linux Kernel Functional Testing <lkft@linaro.org>
  Shuah Khan <skhan@linuxfoundation.org>
  Slade Watkins <slade@sladewatkins.com>
  Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
  Ulf Hansson <ulf.hansson@linaro.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              broken  
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  broken  
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          blocked 
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            broken  
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          blocked 
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      blocked 
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  blocked 
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  blocked 
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     blocked 
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 blocked 
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      blocked 
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary

broken-job build-arm64 broken
broken-job build-arm64-pvops broken
broken-job build-arm64-xsm broken
broken-step build-arm64-xsm host-install(4)
broken-step build-arm64-pvops host-install(4)
broken-step build-arm64 host-install(4)
broken-job build-arm64 broken
broken-job build-arm64-xsm broken
broken-job build-arm64-pvops broken

Not pushing.

------------------------------------------------------------
commit 52871671099d1bb3fca5ed076029e4b937bfc053
Author: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date:   Fri Feb 11 09:07:52 2022 +0100

    Linux 5.4.179
    
    Link: https://lore.kernel.org/r/20220209191248.688351316@linuxfoundation.org
    Tested-by: Shuah Khan <skhan@linuxfoundation.org>
    Tested-by: Florian Fainelli <f.fainelli@gmail.com>
    Tested-by: Jon Hunter <jonathanh@nvidia.com>
    Tested-by: Linux Kernel Functional Testing <lkft@linaro.org>
    Tested-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
    Tested-by: Slade Watkins <slade@sladewatkins.com>
    Tested-by: Guenter Roeck <linux@roeck-us.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

commit d692e3406e052dbf9f6d9da0cba36cb763272529
Author: Jon Maloy <jmaloy@redhat.com>
Date:   Sat Feb 5 14:11:18 2022 -0500

    tipc: improve size validations for received domain records
    
    commit 9aa422ad326634b76309e8ff342c246800621216 upstream.
    
    The function tipc_mon_rcv() allows a node to receive and process
    domain_record structs from peer nodes to track their views of the
    network topology.
    
    This patch verifies that the number of members in a received domain
    record does not exceed the limit defined by MAX_MON_DOMAIN, something
    that may otherwise lead to a stack overflow.
    
    tipc_mon_rcv() is called from the function tipc_link_proto_rcv(), where
    we are reading a 32 bit message data length field into a uint16.  To
    avert any risk of bit overflow, we add an extra sanity check for this in
    that function.  We cannot see that happen with the current code, but
    future designers being unaware of this risk, may introduce it by
    allowing delivery of very large (> 64k) sk buffers from the bearer
    layer.  This potential problem was identified by Eric Dumazet.
    
    This fixes CVE-2022-0435
    
    Reported-by: Samuel Page <samuel.page@appgate.com>
    Reported-by: Eric Dumazet <edumazet@google.com>
    Fixes: 35c55c9877f8 ("tipc: add neighbor monitoring framework")
    Signed-off-by: Jon Maloy <jmaloy@redhat.com>
    Reviewed-by: Xin Long <lucien.xin@gmail.com>
    Reviewed-by: Samuel Page <samuel.page@appgate.com>
    Reviewed-by: Eric Dumazet <edumazet@google.com>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

commit 3a0a7ec5574b510b067cfc734b8bdb6564b31d4e
Author: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date:   Thu Jan 27 08:16:38 2022 +0100

    moxart: fix potential use-after-free on remove path
    
    commit bd2db32e7c3e35bd4d9b8bbff689434a50893546 upstream.
    
    It was reported that the mmc host structure could be accessed after it
    was freed in moxart_remove(), so fix this by saving the base register of
    the device and using it instead of the pointer dereference.
    
    Cc: Ulf Hansson <ulf.hansson@linaro.org>
    Cc: Xiyu Yang <xiyuyang19@fudan.edu.cn>
    Cc: Xin Xiong <xiongx18@fudan.edu.cn>
    Cc: Xin Tan <tanxin.ctf@gmail.com>
    Cc: Tony Lindgren <tony@atomide.com>
    Cc: Yang Li <yang.lee@linux.alibaba.com>
    Cc: linux-mmc@vger.kernel.org
    Cc: stable <stable@vger.kernel.org>
    Reported-by: whitehat002 <hackyzh002@gmail.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Link: https://lore.kernel.org/r/20220127071638.4057899-1-gregkh@linuxfoundation.org
    Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>


From xen-devel-bounces@lists.xenproject.org Sat Feb 12 18:54:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 12 Feb 2022 18:54:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270845.465174 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIxXm-0008Vf-I1; Sat, 12 Feb 2022 18:54:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270845.465174; Sat, 12 Feb 2022 18:54:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIxXm-0008VY-Ej; Sat, 12 Feb 2022 18:54:50 +0000
Received: by outflank-mailman (input) for mailman id 270845;
 Sat, 12 Feb 2022 18:54:49 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nIxXk-0008VS-Uo
 for xen-devel@lists.xenproject.org; Sat, 12 Feb 2022 18:54:48 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nIxXh-0002fO-T3; Sat, 12 Feb 2022 18:54:45 +0000
Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nIxXh-0000gN-NU; Sat, 12 Feb 2022 18:54:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=ktHzQV8yIQsZP8qebA2zS5vxbuKHD3CYO3HGLia9my8=; b=5C+PCbqJQsHU9IddheSVdGYo70
	iOV0L2Bb+IlGteaE3gECeGvYsMaL+WKx7AXP/MXTb0Ht2KqdnwzukMl4N/xshdK9rra8oh267pwug
	BQVlzQ/ZkX0aVYRYPdPnk+YyrZSPD6pAUTs8LEI2rWJ/Wy9aFmKbM3TRaDB6WupIagVI=;
Message-ID: <b1968764-e26e-35ea-1e74-7c3509c97707@xen.org>
Date: Sat, 12 Feb 2022 18:54:43 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.1
Subject: Re: [PATCH RFC 1/3] xen/efi: Always query the console information and
 get GOP
To: Elliott Mitchell <ehem+xen@m5p.com>
Cc: Jan Beulich <jbeulich@suse.com>, Julien Grall <jgrall@amazon.com>,
 xen-devel@lists.xenproject.org, Daniel Kiper <daniel.kiper@oracle.com>
References: <20220206192839.75711-1-julien@xen.org>
 <20220206192839.75711-2-julien@xen.org>
 <88741681-929f-4cda-e841-023bdbf8f772@suse.com>
 <26cdd9cf-15d6-a463-b1bb-28964005f618@xen.org>
 <YgcOg6p8D+6hWWsE@mattapan.m5p.com>
 <d2a2f715-9eab-aeb1-8099-4db614eb26a8@xen.org>
 <Ygf6VznolUhlpAzp@mattapan.m5p.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <Ygf6VznolUhlpAzp@mattapan.m5p.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit



On 12/02/2022 18:20, Elliott Mitchell wrote:
> On Sat, Feb 12, 2022 at 01:10:52PM +0000, Julien Grall wrote:
>>
>> On 12/02/2022 01:33, Elliott Mitchell wrote:
>>> On Mon, Feb 07, 2022 at 06:52:57PM +0000, Julien Grall wrote:
>>>> On 07/02/2022 08:46, Jan Beulich wrote:
>>>>> On 06.02.2022 20:28, Julien Grall wrote:
>>>>>>
>>>>>> It is not entirely clear to me why the GOP was only fetched when
>>>>>> the configuration file is used.
>>>>>>
>>>>>> I have tested this on RPI4 and it seems to work. Any chance this
>>>>>> was done to workaround an x86 platform?
>>>>>
>>>>> This was done so in the context of making the code work for Arm. See
>>>>> commit c38cf865ec82 ("EFI: ignore EFI commandline, skip console setup
>>>>> when booted from GRUB"), the description of which explicitly says
>>>>>
>>>>> "Don't do EFI console or video configuration when booted by GRUB.  The EFI boot
>>>>>     code does some console and video initialization to support native EFI boot from
>>>>>     the EFI boot manager or EFI shell.  This initlization should not be done when
>>>>>     booted using GRUB."
>>>>
>>>> I read that and still couldn't figure out why this was done like that.
>>>
>>> The most likely motivation was simply "Eww!  ACPI/UEFI use gobs of
>>> memory!  Purge the abomination!"
>>>
>>> Unfortunately ACPI/UEFI are large an complex due to trying to solve a
>>> large and complex problem.  ACPI/UEFI attempt to provide an OS agnostic
>>> presentation of the hardware layout.  Whereas device-trees are a common
>>> *format* for presenting hardware to *an* OS (similar to how JSON is a
>>> common format).
>>>
>>> Due to the size and complexity, most developers have preferred the
>>> simpler device-tree format even though that severely limits OS choice.
>>> As such, nuking ACPI/UEFI's presence is common in the ARM world.  Versus > the x86 world where Intel dragged everyone onto ACPI/UEFI.
>>>
>>> One can see this in patches like Roman Shaposhnik's "Making full 2G of
>>> memory available to Xen on HiKey" which simply tosses EFI into the
>>> garbage bin as useless overhead.
>>
>> I couldn't find a series with this name in my archives. By any chance,
>> are you referring to [1]?
> 
> The patch may have appeared under more than one title.  The raw content
> is publically visible at:
> 
> https://github.com/lf-edge/eve/blob/master/pkg/xen/arch/aarch64/0002-arm-efi-mem-detection.patch
> 
> The issue is few ARM projects are really trying to support enough
> different devices for ACPI/UEFI to hit their forte.  At which point
> ACPI/UEFI get treated as worthless overhead.

Thanks! I wasn't aware of that patch.

>>> You stated your patch was for 5.17-rc2.  How much backporting would you
>>> expect this patch to be viable for?  (I'm unsure how much churn is
>>> occuring in the relevant portions of Linux) The long-term branches of
>>> Linux include 5.4.179, 5.10.100 and 5.15.23.  `patch` indicated it could
>>> apply to 5.10.92 source with fuzz (hmm).  This suggests 5.15 is likely
>>> viable, but 5.10 is risky and 5.4 is a very long shot.
> 
>> I haven't looked at backports, so I don't know. But this is not a patch
>> I would consider to request for backport myself because IHMO this is
>> adding device support.
> 
> People who need this feature are likely to backport it themselves.

Well, anyone can ask backport. I am not planning to ask nor do the 
backport work myselff. But feel free to send an e-mail to stable after 
the Linux patch is merged.

> 
> Looking at the 5.10.92 source I've got handy, it appears reasonable.  The
> fuzz appears to have be a missed newline when I attempted to grab the
> patch from the site you used.
> 
> You want test reports yet?

I need to do some respin. So I would say wait until the next version.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Sat Feb 12 19:16:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 12 Feb 2022 19:16:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270852.465184 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIxsM-0002Td-AV; Sat, 12 Feb 2022 19:16:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270852.465184; Sat, 12 Feb 2022 19:16:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIxsM-0002TW-7X; Sat, 12 Feb 2022 19:16:06 +0000
Received: by outflank-mailman (input) for mailman id 270852;
 Sat, 12 Feb 2022 19:16:04 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nIxsK-0002TQ-N1
 for xen-devel@lists.xenproject.org; Sat, 12 Feb 2022 19:16:04 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nIxsK-00032M-Cz; Sat, 12 Feb 2022 19:16:04 +0000
Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nIxsK-0002Lw-7r; Sat, 12 Feb 2022 19:16:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=Hbwq3ZWfNkA9pT9T5LtDOIXrdpYQXja8mm6vhDOaPDE=; b=lLn+rqvSSyqpn5HnlOgrdkATgr
	+w3z21HyLYntVUsONmi+TH3zG86eDwwsQQiBvGyVTNgmMt3dgLPhdFfJNWn/klpWdDMvQ/av0ETO8
	3mH1K6jmMkAqhtOikcEZ/OX0tyYiNpA2C2KpKbC9bscviR1kHO6xPpvSujCHq2HSDOLc=;
Message-ID: <6513ab57-3b7c-56b6-b89d-41a5545b64a4@xen.org>
Date: Sat, 12 Feb 2022 19:16:01 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.1
Subject: Re: [PATCH RFCv2 14/15] xen/arm: mm: Rework setup_xenheap_mappings()
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org, Wei.Chen@arm.com, Henry.Wang@arm.com,
 Penny.Zheng@arm.com, Bertrand.Marquis@arm.com,
 Julien Grall <julien.grall@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Julien Grall <jgrall@amazon.com>
References: <20210425201318.15447-1-julien@xen.org>
 <20210425201318.15447-15-julien@xen.org>
 <alpine.DEB.2.21.2105141646340.14426@sstabellini-ThinkPad-T480s>
 <8cda6d2d-7f3c-fef6-c534-2fadabed1bad@xen.org>
 <alpine.DEB.2.21.2105171738320.14426@sstabellini-ThinkPad-T480s>
From: Julien Grall <julien@xen.org>
In-Reply-To: <alpine.DEB.2.21.2105171738320.14426@sstabellini-ThinkPad-T480s>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

Sorry for the late answering. I finally picked up that series again and 
now preparing a new version.

On 18/05/2021 01:50, Stefano Stabellini wrote:
> On Sat, 15 May 2021, Julien Grall wrote:
>> Hi,
>>
>> On 15/05/2021 00:51, Stefano Stabellini wrote:
>>> On Sun, 25 Apr 2021, Julien Grall wrote:
>>>> From: Julien Grall <julien.grall@arm.com>
>>>>
>>>> A few issues have been reported with setup_xenheap_mappings() over the
>>>> last couple of years. The main ones are:
>>>>       - It will break on platform supporting more than 512GB of RAM
>>>>         because the memory allocated by the boot allocator is not yet
>>>>         mapped.
>>>>       - Aligning all the regions to 1GB may lead to unexpected result
>>>>         because we may alias non-cacheable region (such as device or
>>>> reserved
>>>>         regions).
>>>>
>>>> map_pages_to_xen() was recently reworked to allow superpage mappings and
>>>> deal with the use of page-tables before they are mapped.
>>>>
>>>> Most of the code in setup_xenheap_mappings() is now replaced with a
>>>> single call to map_pages_to_xen().
>>>>
>>>> This also require to re-order the steps setup_mm() so the regions are
>>>> given to the boot allocator first and then we setup the xenheap
>>>> mappings.
>>>
>>> I know this is paranoia but doesn't this introduce a requirement on the
>>> size of the first bank in bootinfo.mem.bank[] ?
>>>
>>> It should be at least 8KB?
>>
>> AFAIK, the current requirement is 4KB because of the 1GB mapping. Long term,
>> it would be 8KB.
>>
>>>
>>> I know it is unlikely but it is theoretically possible to have a first
>>> bank of just 1KB.
>>
>> All the page allocators are working at the page granularity level. I am not
>> entirely sure whether the current Xen would ignore the region or break.
>>
>> Note that setup_xenheap_mappings() is taking a base MFN and a number of pages
>> to map. So this doesn't look to be a new problem here.
> 
> Yeah... the example of the first bank being 1KB is wrong because, like
> you wrote, it wouldn't work before your patches either, and probably it
> will never work.
> 
> Maybe a better example is a first bank of 4KB exactly.

I have done more testing with the 1GB alignment dropped. The 
restrictions are a bit more complicated.

Not all the memory in a bank will go to the boot allocator. This can 
happen if the memory were have already been allocated for other purpose 
(e.g. modules, reserved area...).

So the region needs enough free memory to be able to map the entire 
region. The amount needed will depend on the size of the region.

So I will split the loop in two separate loops. The first loop will add 
all available pages to the boot allocator. The second loop will actually 
do the mapping.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Sat Feb 12 21:17:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 12 Feb 2022 21:17:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270860.465196 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIzlh-0005Lx-4v; Sat, 12 Feb 2022 21:17:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270860.465196; Sat, 12 Feb 2022 21:17:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nIzlh-0005Lq-1d; Sat, 12 Feb 2022 21:17:21 +0000
Received: by outflank-mailman (input) for mailman id 270860;
 Sat, 12 Feb 2022 21:17:20 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nIzlg-0005Lg-0S; Sat, 12 Feb 2022 21:17:20 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nIzlf-0005Sj-SV; Sat, 12 Feb 2022 21:17:19 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nIzlf-0001V6-C9; Sat, 12 Feb 2022 21:17:19 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nIzlf-0002zZ-Bg; Sat, 12 Feb 2022 21:17:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=dtwDX/mxIKv0sHOySK3GLemdWkuBaya3fokeWfX9hU0=; b=On6PYYFA6u8L/rZU3x9//szbJk
	XWtF0q17lHiomxIYwokdvSYAweXifVdFeLMiA0NFLHcB4FPJ+Qe2/6rprlVOOhbrW7zDbDyTmxOv9
	2I3BMrbDjIJiKQcsihWOC6mQeySALJEnAzmO0RiGAjLCC/uIuUbNtOH2TRmVRY5J6Dyw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168092-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 168092: trouble: blocked/broken/fail/pass
X-Osstest-Failures:
    linux-linus:build-arm64:<job status>:broken:regression
    linux-linus:build-arm64-pvops:<job status>:broken:regression
    linux-linus:build-arm64-xsm:<job status>:broken:regression
    linux-linus:build-arm64-xsm:host-install(4):broken:regression
    linux-linus:build-arm64:host-install(4):broken:regression
    linux-linus:build-arm64-pvops:host-install(4):broken:regression
    linux-linus:test-amd64-amd64-xl-xsm:guest-localmigrate/x10:fail:heisenbug
    linux-linus:test-arm64-arm64-examine:build-check(1):blocked:nonblocking
    linux-linus:build-arm64-libvirt:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=83e396641110663d3c7bb25b9bc0c6a750359ecf
X-Osstest-Versions-That:
    linux=f1baf68e1383f6ed93eb9cff2866d46562607a43
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 12 Feb 2022 21:17:19 +0000

flight 168092 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168092/

Failures and problems with tests :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-arm64                     <job status>                 broken
 build-arm64-pvops               <job status>                 broken
 build-arm64-xsm                 <job status>                 broken
 build-arm64-xsm               4 host-install(4)        broken REGR. vs. 168080
 build-arm64                   4 host-install(4)        broken REGR. vs. 168080
 build-arm64-pvops             4 host-install(4)        broken REGR. vs. 168080

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-xsm      20 guest-localmigrate/x10     fail pass in 168089

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-examine      1 build-check(1)               blocked  n/a
 build-arm64-libvirt           1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl           1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit1   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit2   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-seattle   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-thunderx  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-vhd       1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-xsm       1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 168089 like 168080
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168080
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168080
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168080
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168080
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168080
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168080
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168080
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168080
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                83e396641110663d3c7bb25b9bc0c6a750359ecf
baseline version:
 linux                f1baf68e1383f6ed93eb9cff2866d46562607a43

Last test of basis   168080  2022-02-11 00:09:22 Z    1 days
Failing since        168086  2022-02-11 20:11:19 Z    1 days    3 attempts
Testing same since   168089  2022-02-12 04:02:27 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Aaron Liu <aaron.liu@amd.com>
  Alex Deucher <alexander.deucher@amd.com>
  Alexander Stein <alexander.stein@ew.tq-group.com>
  Alexandre Ghiti <alexandre.ghiti@canonical.com>
  Alim Akhtar <alim.akhtar@samsung.com>
  Alviro Iskandar Setiawan <alviro.iskandar@gmail.com>
  Ammar Faizi <ammarfaizi2@gnuweeb.org>
  Andreas Gruenbacher <agruenba@redhat.com>
  Andrzej Pietrasiewicz <andrzej.p@collabora.com>
  Andy Shevchenko <andriy.shevchenko@linux.intel.com>
  Arnd Bergmann <arnd@arndb.de>
  Aswath Govindraju <a-govindraju@ti.com>
  Aurelien Jarno <aurelien@aurel32.net>
  Bartosz Golaszewski <brgl@bgdev.pl>
  Bean Huo <beanhuo@micron.com>
  Benjamin Gaignard <benjamin.gaignard@collabora.com>
  Bjorn Helgaas <bhelgaas@google.com>
  Bob Peterson <rpeterso@redhat.com>
  Brian Norris <briannorris@chromium.org>
  Catalin Marinas <catalin.marinas@arm.com>
  Changbin Du <changbin.du@gmail.com>
  Chia-Wei Wang <chiawei_wang@aspeedtech.com>
  Christian Hewitt <christianshewitt@gmail.com>
  Christoph Hellwig <hch@lst.de>
  Christoph Niedermaier <cniedermaier@dh-electronics.com>
  Christophe JAILLET <christophe.jaillet@wanadoo.fr>
  Damien Le Moal <damien.lemoal@opensource.wdc.com>
  Daniel Bristot de Oliveira <bristot@kernel.org>
  Daniel Stone <daniels@collabora.com>
  Daniel Vetter <daniel.vetter@ffwll.ch>
  Daniel Vetter <daniel.vetter@intel.com>
  Daniel Wheeler <daniel.wheeler@amd.com>
  Dave Airlie <airlied@redhat.com>
  Dave Stevenson <dave.stevenson@raspberrypi.com>
  Dinh Nguyen <dinguyen@kernel.org>
  Dmytro Laktyushkin <Dmytro.Laktyushkin@amd.com>
  Dongjin Kim <tobetter@gmail.com>
  Fabio Estevam <festevam@gmail.com>
  Geert Uytterhoeven <geert+renesas@glider.be>
  Geert Uytterhoeven <geert@linux-m68k.org>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>Cc: Dave Airlie <airlied@gmail.com>
  Hans de Goede <hdegoede@redhat.com>
  Hector Martin <marcan@marcan.st>
  Heiko Stuebner <heiko@sntech.de>
  Helge Deller <deller@gmx.de>
  Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
  JaeSang Yoo <js.yoo.5b@gmail.com>
  JaeSang Yoo <jsyoo5b@gmail.com>
  Jan Kara <jack@suse.cz>
  Jani Nikula <jani.nikula@intel.com>
  Jarkko Nikula <jarkko.nikula@bitmer.com>
  Jasdeep Dhillon <jdhillon@amd.com>
  Jayesh Choudhary <j-choudhary@ti.com>
  Jens Axboe <axboe@kernel.dk>
  Jens Wiklander <jens.wiklander@linaro.org>
  Jerome Forissier <jerome@forissier.org>
  Jisheng Zhang <jszhang@kernel.org>
  Joel Stanley <joel@jms.id.au>
  Kai-Heng Feng <kai.heng.feng@canonical.com>
  Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Linus Walleij <linus.walleij@linaro.org>
  Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
  Lucas De Marchi <lucas.demarchi@intel.com>
  Lutz Koschorreck <theleks@ko-hh.de>
  Marek Vasut <marex@denx.de>
  Mario Limonciello <mario.limonciello@amd.com>
  Mark Brown <broonie@kernel.org>
  Martin Blumenstingl <martin.blumenstingl@googlemail.com>
  Martin Kepplinger <martin.kepplinger@puri.sm>
  Maxime Ripard <maxime@cerno.tech>
  Michael Walle <michael@walle.cc>
  Myrtle Shah <gatecat@ds0.me>
  Neil Armstrong <narmstrong@baylibre.com>
  Niklas Cassel <niklas.cassel@wdc.com>
  Nishanth Menon <nm@ti.com>
  Palmer Dabbelt <palmer@rivosinc.com>
  Philippe Cornu <philippe.cornu@foss.st.com>
  Pingfan Liu <kernelfans@gmail.com>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Rob Herring <robh@kernel.org>
  Robin Murphy <robin.murphy@arm.com>
  Roman Li <Roman.Li@amd.com>
  Sagi Grimberg <sagi@grimberg.me>
  Sam Protsenko <semen.protsenko@linaro.org>
  Sam Ravnborg <sam@ravnborg.org>
  Sascha Hauer <s.hauer@pengutronix.de>
  Shakeel Butt <shakeelb@google.com>
  Shawn Guo <shawnguo@kernel.org>
  Steven Rostedt (Google) <rostedt@goodmis.org>
  Sven Peter <sven@svenpeter.dev>
  Sylwester Nawrocki <s.nawrocki@samsung.com>
  Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
  Thomas Hellström <thomas.hellstrom@linux.intel.com>
  Thomas Zimmermann <tzimmermann@suse.de>
  Tim Harvey <tharvey@gateworks.com>
  Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
  Tony Lindgren <tony@atomide.com>
  Tvrtko Ursulin <tvrtko.ursulin@intel.com>
  Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
  Vignesh Raghavendra <vigneshr@ti.com>
  Ville Syrjälä <ville.syrjala@linux.intel.com>
  Vlastimil Babka <vbabka@suse.cz>
  Wan Jiabing <wanjiabing@vivo.com>
  Yang Wang <KevinYang.Wang@amd.com>
  Ye Guojin <ye.guojin@zte.com.cn>
  Yizhuo Zhai <yzhai003@ucr.edu>
  Zhan Liu <Zhan.Liu@amd.com>
  Zoltán Böszörményi <zboszor@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              broken  
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  broken  
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          blocked 
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            broken  
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          blocked 
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-amd64-xl-xsm                                      fail    
 test-arm64-arm64-xl-xsm                                      blocked 
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  blocked 
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  blocked 
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     blocked 
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 blocked 
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      blocked 
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary

broken-job build-arm64 broken
broken-job build-arm64-pvops broken
broken-job build-arm64-xsm broken
broken-step build-arm64-xsm host-install(4)
broken-step build-arm64 host-install(4)
broken-step build-arm64-pvops host-install(4)
broken-job build-arm64-xsm broken
broken-job build-arm64-pvops broken
broken-job build-arm64 broken

Not pushing.

(No revision log; it would be 2806 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Feb 12 23:35:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 12 Feb 2022 23:35:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270873.465207 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJ1uk-0001UH-9z; Sat, 12 Feb 2022 23:34:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270873.465207; Sat, 12 Feb 2022 23:34:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJ1uk-0001UA-5f; Sat, 12 Feb 2022 23:34:50 +0000
Received: by outflank-mailman (input) for mailman id 270873;
 Sat, 12 Feb 2022 23:34:49 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=u0Ww=S3=xilinx.com=ayankuma@srs-se1.protection.inumbo.net>)
 id 1nJ1uj-0001U4-E4
 for xen-devel@lists.xenproject.org; Sat, 12 Feb 2022 23:34:49 +0000
Received: from NAM10-BN7-obe.outbound.protection.outlook.com
 (mail-bn7nam10on2060b.outbound.protection.outlook.com
 [2a01:111:f400:7e8a::60b])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5cef5486-8c5c-11ec-8eb8-a37418f5ba1a;
 Sun, 13 Feb 2022 00:34:46 +0100 (CET)
Received: from BN9PR03CA0878.namprd03.prod.outlook.com (2603:10b6:408:13c::13)
 by SJ0PR02MB8612.namprd02.prod.outlook.com (2603:10b6:a03:3f8::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Sat, 12 Feb
 2022 23:34:43 +0000
Received: from BN1NAM02FT017.eop-nam02.prod.protection.outlook.com
 (2603:10b6:408:13c:cafe::22) by BN9PR03CA0878.outlook.office365.com
 (2603:10b6:408:13c::13) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12 via Frontend
 Transport; Sat, 12 Feb 2022 23:34:43 +0000
Received: from xir-pvapexch01.xlnx.xilinx.com (149.199.80.198) by
 BN1NAM02FT017.mail.protection.outlook.com (10.13.2.134) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.4975.11 via Frontend Transport; Sat, 12 Feb 2022 23:34:42 +0000
Received: from xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) by
 xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2176.14; Sat, 12 Feb 2022 23:34:41 +0000
Received: from smtp.xilinx.com (172.21.105.198) by
 xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server id
 15.1.2176.14 via Frontend Transport; Sat, 12 Feb 2022 23:34:41 +0000
Received: from [10.108.8.223] (port=57002 helo=xcbayankuma41x.xilinx.com)
 by smtp.xilinx.com with esmtp (Exim 4.90)
 (envelope-from <ayan.kumar.halder@xilinx.com>)
 id 1nJ1ua-0006SM-Bw; Sat, 12 Feb 2022 23:34:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5cef5486-8c5c-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=BkmLCrExvWYhBu+BALRYlojc8Wb5xC1MbS3pPB2f58tkOLEVQx0qd7OfBl2CcGT2AaT57iD+8gvSOc0xrB6a/Py0UHiljQToKa4mtGH/LKjeyJLhHsnuo3XS0UlfFDpPHcyv6fja/XaqDT4Y6FSd28c2DhpLgD9s0Z5Tgp1TTBZNIuZ2oxXH7GasK+NXAu2hKlG7DPBcid9kpx+dtHz5MgGR9H7L+K9wjQF7mCgG+m32URWPuc7LQclxbogkz9aZ5wQNqWtRQngqXmlH2Lure0S93CzKDF7p3+E8/jyaVCa/axYkuD4V6iYPgHQO/mE+Xq16E8G8H21mraCvRflhwA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=xysOWxW0K4OJpfN/VdY+O8CJSYB9Lqyw/B18QsvDyeM=;
 b=kTVesOkgk8iBIK5Y/HzMDXNbZpWu0tJtHkWI8hCKSl/ogzpCvY67vkgQUsTob/ltmga1wrzG2dBt1fkGNH3Bz1b6LKOmXREWvSnyhdfCiPvIRMIuyden/Ivh7iun6nfvTbTq2KQFmXuJB4hMv7r9FdGUagmLB4kQLsUyeV9JeVVVQ8rjERXWxCQQ4PsxLAnMWNVcFsOe/SQoUU5xpfg1Ou0duS/cEJS6FShz6eyCpG95KisCk3oUL6ngEKhwyLudQvvCUsFSf/s0qLi2i249lIUWU4DOuuah+Q5TiC5MjssIQ0Pr36h6NvL2Jv5V7O5M0Q6umiV7kfPGadX1D9TK/A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 149.199.80.198) smtp.rcpttodomain=lists.xenproject.org
 smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none
 header.from=xilinx.com; dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=xysOWxW0K4OJpfN/VdY+O8CJSYB9Lqyw/B18QsvDyeM=;
 b=INsI0d2utKqNt9NO0qg4GM3pvsJvlMQtAOlWblaWI4GXZ/UhmaL83fVGxSAxzEUqQTKUg67sHIQBFIJC24NL/+nclLQupq66aHbd86sRJCmpKE6F/wvf+Wc73fgwA6GqN4o6DkIm9WVenx/5rZS0ABbgg7oYk7lsvc4GkVQDQd8=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198)
 smtp.mailfrom=xilinx.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=xilinx.com;
Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates
 149.199.80.198 as permitted sender) receiver=protection.outlook.com;
 client-ip=149.199.80.198; helo=xir-pvapexch01.xlnx.xilinx.com;
From: Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>
To: <xen-devel@lists.xenproject.org>
CC: <sstabellini@kernel.org>, <stefanos@xilinx.com>, <julien@xen.org>,
	<Volodymyr_Babchuk@epam.com>, <bertrand.marquis@arm.com>, Ayan Kumar Halder
	<ayankuma@xilinx.com>
Subject: [XEN v8 0/2] xen/arm64: io: Decode ldr/str post-indexing instruction
Date: Sat, 12 Feb 2022 23:34:31 +0000
Message-ID: <20220212233433.46018-1-ayankuma@xilinx.com>
X-Mailer: git-send-email 2.17.1
MIME-Version: 1.0
Content-Type: text/plain
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7d5bb0f7-e738-437b-609d-08d9ee803ee9
X-MS-TrafficTypeDiagnostic: SJ0PR02MB8612:EE_
X-Microsoft-Antispam-PRVS:
	<SJ0PR02MB861267E369195A0181539BC0B2319@SJ0PR02MB8612.namprd02.prod.outlook.com>
X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply
X-MS-Oob-TLC-OOBClassifiers: OLM:5516;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	HoSw3dAL0dja0y7LhdqV0cDF6oXjOd77SJxn7MS02HmgdfvdyVNbuQBQcp5su8MJ01bEO9iVO9YQoWNDlQU/dDcxuKQjaBqhobSJ3g6xGb+OBEWg5Jby4RqFGLzKRQPjKx7udXLASUW+mdWQ3XTzpnJ9+V2Xzq0wWJijbXzglAHB8+wucy9A4lTVmEoO/d5CJqety+vWkmOypLBxuXDLuCcH/L2SraXXQpS6OSUq1CRW87PuMu7iVt9m09dw4JPhWINLGhHUfnSTuB0uzPMUhbUEndl3kBDcWhoUmL+Dl0a6OniGzF/yL8YY5cK8qgao2e4rC5np0jn2KJ/y82NqVdTPXOIJsIeyXDKWwcGZiRI/krNWxu5z2/WgJ7fT/RCNq4I9IwIibq2342EqbbkOAmgK+gJbL/OzGjU+40l5NXfECs+gMal/YIPQeASOLLDLsiaQJX6vWIgdThfIvjwxuOH4V/u88OVL8g8O4jni8bpbpTlKSXMLCNU2UyDT8K5HfHC/GxhjyaN1H1E1nsedkXF5fVK1rfWJXj8ihHpe8uYZ3ZzdjDHWmQlLUnBNIsH8xxRynWbC3UON1UAtYnoQDYpu4+o2+GtXv45ozR7H9GQBk8918cebVouBax4RSG38v5/RYYnGS8kTVXvIFiKJbJc8g+zJT2Fmp2fgvFxAARVEHD6qSeK31lesRKxQXNDa3Gbq4amdJTqmcM+jfbSF2Q==
X-Forefront-Antispam-Report:
	CIP:149.199.80.198;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:xir-pvapexch01.xlnx.xilinx.com;PTR:unknown-80-198.xilinx.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(6666004)(47076005)(356005)(336012)(426003)(9786002)(7636003)(7696005)(508600001)(1076003)(2616005)(6916009)(8676002)(4326008)(26005)(5660300002)(70586007)(82310400004)(70206006)(54906003)(316002)(186003)(8936002)(36860700001)(107886003)(2906002)(36756003)(83380400001)(102446001)(473944003);DIR:OUT;SFP:1101;
X-OriginatorOrg: xilinx.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Feb 2022 23:34:42.6780
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 7d5bb0f7-e738-437b-609d-08d9ee803ee9
X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.80.198];Helo=[xir-pvapexch01.xlnx.xilinx.com]
X-MS-Exchange-CrossTenant-AuthSource:
	BN1NAM02FT017.eop-nam02.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR02MB8612

Hi All,

The patch series introduces support to decode instructions by Xen when ISS is
invalid. Currently, when the guest executes post indexing ldr/str instructions
on emulated MMIO, these instructions are trapped into Xen as a data abort.
Xen reads hsr_dabt.isv == 0, so ISS is invalid. Therefore, it reads the faulting
instruction's opcode from guest's PC. It decodes and executes the instruction on
the emulated region.

Ayan Kumar Halder (2):
  xen/arm64: Decode ldr/str post increment operations
  xen/arm64: io: Support instructions (for which ISS is not valid) on
    emulated MMIO region using MMIO/ioreq handler

 xen/arch/arm/arm32/traps.c        |  7 +++
 xen/arch/arm/arm64/traps.c        | 47 +++++++++++++++
 xen/arch/arm/decode.c             | 80 ++++++++++++++++++++++++-
 xen/arch/arm/decode.h             | 48 +++++++++++++--
 xen/arch/arm/include/asm/domain.h |  4 ++
 xen/arch/arm/include/asm/mmio.h   | 19 +++++-
 xen/arch/arm/include/asm/traps.h  |  2 +
 xen/arch/arm/io.c                 | 98 ++++++++++++++++++++-----------
 xen/arch/arm/ioreq.c              |  7 ++-
 xen/arch/arm/traps.c              | 80 +++++++++++++++++++++----
 xen/arch/x86/include/asm/ioreq.h  |  3 +
 xen/include/xen/sched.h           |  2 +
 12 files changed, 340 insertions(+), 57 deletions(-)

Changelog :-
v2 - 1. Updated the rn register after reading from it. (Pointed by Julien,
        Stefano)
     2. Used a union to represent the instruction opcode (Suggestd by Bertrand)
     3. Fixed coding style issues (Pointed by Julien)
     4. In the previous patch, I was updating dabt->sign based on the signedness
        of imm9. This was incorrect. As mentioned in ARMv8 ARM  DDI 0487G.b,
        Page 3221, SSE indicates the signedness of the data item loaded. In our
        case, the data item loaded is always unsigned.

v3- 1. Handled all the variants of ldr/str (ie 64, 32, 16, 8 bit variants).
       Thus, I have removed the check for "instr->code.opc == 0" (Suggested by
       Andre)
    2. Handled the scenario when rn = SP, rt = XZR (Suggested by Jan, Andre)
    3. Added restriction for "rt != rn" (Suggested by Andre)
    4. Moved union ldr_str_instr_class {} to decode.h. This is the header included
       by io.c and decode.c (where the union is referred). (Suggested by Jan)
    5. Indentation and typo fixes (Suggested by Jan)

v4- 1. Fixed the patch as per Stefano's comments on v3. They are as follows :-
        1.1 Use macros to determine the fixed values in the instruction opcode
        1.2 Checked if instr != NULL
        1.3 Changed some data types and added #define ARM_64 for AArch64 specific
            code
        1.4 Moved post_increment_register() to decode.c so that the decoding
            logic is confined to a single file.
        1.5 Moved some checks from post_increment_register() to
            decode_loadstore_postindexing()
        1.6 Removed a duplicate check
    2. Updated the commit message as per Andre's comments.
    3. Changed the names of a label and some comments. *32bit* was erroneously
       mentioned in a label and comments in decode_loadstore_postindexing()
       although the function handled all variants of ldr/str post indexing.

v5- 1. Renamed decode_loadstore_postindexing() to decode_arm64(). The reason
       being this will be extended in future to support more instructions for
       which hsr_badt.isv = 0
    2. Introduce a function try_decode_instruction_invalid_iss() to determine
       if the instruction needs to be decoded before invoking decode_instruction().

       It checks :-
       2.1  dabt->s1ptw - Returns IO_UNHANDLED
       2.2  dabt->cache - Returns IO_IGNORED. (new enum instroduced to let the
            caller know that the instruction needs to be ignored by Xen. Thus
            the caller needs to increment the PC and return to the guest.

    3. Invoked try_decode_instruction_invalid_iss() from the following 2 places :-
        3.a - try_handle_mmio() - When we have determined that there is a valid
              mmio handler.
        3.b - try_fwd_ioserv()
        When ioserver completes the io request, the acknowledgement is sent via
        handle_ioserv(). Here, we need to increment the register. As there is no
        common data shared between try_fwd_ioserv() and handle_ioserv(), we need
        to decode the instruction again in handle_ioserv() to determine rn, imm9.

        (NOTE to Reviewers) - This does not feel correct. However, I could not
        think of a better approach. Please provide your inputs.

    4. Augumented struct hsr_dabt{} with struct hsr_dabt_instr_details{} to hold
       rn and imm9. This is passed to post_increment_register() to update rn.
    5. Other style changes as suggested in v4.

v6 - 1. Split the patch into three parts.

v7 - 1. Merged patch2 and patch3 into a single patch.

v8 - 1. Changes mentioned in the individual patches.

-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Sat Feb 12 23:35:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 12 Feb 2022 23:35:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270875.465229 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJ1uu-000247-Q4; Sat, 12 Feb 2022 23:35:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270875.465229; Sat, 12 Feb 2022 23:35:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJ1uu-00023y-M3; Sat, 12 Feb 2022 23:35:00 +0000
Received: by outflank-mailman (input) for mailman id 270875;
 Sat, 12 Feb 2022 23:34:59 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=u0Ww=S3=xilinx.com=ayankuma@srs-se1.protection.inumbo.net>)
 id 1nJ1us-000219-VD
 for xen-devel@lists.xenproject.org; Sat, 12 Feb 2022 23:34:59 +0000
Received: from NAM11-CO1-obe.outbound.protection.outlook.com
 (mail-co1nam11on20606.outbound.protection.outlook.com
 [2a01:111:f400:7eab::606])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6144b450-8c5c-11ec-b215-9bbe72dcb22c;
 Sun, 13 Feb 2022 00:34:55 +0100 (CET)
Received: from SA9P223CA0024.NAMP223.PROD.OUTLOOK.COM (2603:10b6:806:26::29)
 by BL3PR02MB7924.namprd02.prod.outlook.com (2603:10b6:208:353::8) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Sat, 12 Feb
 2022 23:34:50 +0000
Received: from SN1NAM02FT0064.eop-nam02.prod.protection.outlook.com
 (2603:10b6:806:26:cafe::a2) by SA9P223CA0024.outlook.office365.com
 (2603:10b6:806:26::29) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11 via Frontend
 Transport; Sat, 12 Feb 2022 23:34:50 +0000
Received: from xir-pvapexch02.xlnx.xilinx.com (149.199.80.198) by
 SN1NAM02FT0064.mail.protection.outlook.com (10.97.4.66) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.4975.11 via Frontend Transport; Sat, 12 Feb 2022 23:34:49 +0000
Received: from xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) by
 xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2176.14; Sat, 12 Feb 2022 23:34:48 +0000
Received: from smtp.xilinx.com (172.21.105.198) by
 xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server id
 15.1.2176.14 via Frontend Transport; Sat, 12 Feb 2022 23:34:48 +0000
Received: from [10.108.8.223] (port=57002 helo=xcbayankuma41x.xilinx.com)
 by smtp.xilinx.com with esmtp (Exim 4.90)
 (envelope-from <ayan.kumar.halder@xilinx.com>)
 id 1nJ1ui-0006SM-6k; Sat, 12 Feb 2022 23:34:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6144b450-8c5c-11ec-b215-9bbe72dcb22c
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Us4gLUvoAODkLkPWLrkZCvWSJSMHRD6dtgPooZTlALpGAXg1cqgXN3OgNkxreRdDcHHRB0yQE+vSC1BWnvdy4BZ3Xgc0HzLHdbwhclYlk5j0B1MwI6uSd3f0VKJc3ielNZDvPIPe8KI/JcNI6jJhRDqVA0ZIH/J5HCUxw0nmI1JUkslO9leX7QztM1AaX1cMfZX8cOquak6YRVwmeMzxL/IAndTVSGhSOnkW2hAyypexMKi+qMu4jpDXOBwGn6bSIejvqLk9G8exj2eXRWEbyzymAs2TUCugQckcvjpLbMZKxQQoCdLIrcPpf3dTrcwa4D5Cnyj5z87Mwg7r+8owhg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=7jOvmc08nGNsVVOOrm/imkMHCxTzAqUx6NSijrCnRUo=;
 b=jfxrLJx9Mxpnr+3/Qz0rG8xJnXMEP1Awg4Xl0qnLVF2bQRlQRAHEjPikJOA5K/7tTWPSSWBQvg740UJQF5h2A3zT2HJ/aBSx+67641n2eOjdtY4bLnxghKbEOYYllXXtalWdS1YxfTcA/uUhl4b8PeOVYcSkpkbHx6E1TunZXbMizaDzOyQFtKGugx3hd00Vrq8h2rRGWN3pT2Ffrk4PmCC1KQET5uK/hs1krt35B/k0IshbhqM/FH0l8ALWHyAvzxi+K3Ux6+GpZb7EYxjzPqTD62bsP2gE8rWyOvDQM6l+aUJN2d7cmbU9j0k7LWY6Gk2aeK1IljjX+qSCQkaIaw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 149.199.80.198) smtp.rcpttodomain=lists.xenproject.org
 smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none
 header.from=xilinx.com; dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=7jOvmc08nGNsVVOOrm/imkMHCxTzAqUx6NSijrCnRUo=;
 b=rgRrrjEgabSHVUgqcPA8F0GfdhHNDsHiy/sGN5FoduvHW5SZ5h06RiTen/XaoFNkFPTlO+5lPpfrAFJAshfJotTp6D64JuA/zhhAe70Q4LIZmMvhtnfh7ryHEGRUyUBmSr2UWeNCGVks/LJWr5/SK0AZJ4B8VhXyswGOriFx0Io=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198)
 smtp.mailfrom=xilinx.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=xilinx.com;
Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates
 149.199.80.198 as permitted sender) receiver=protection.outlook.com;
 client-ip=149.199.80.198; helo=xir-pvapexch02.xlnx.xilinx.com;
From: Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>
To: <xen-devel@lists.xenproject.org>
CC: <sstabellini@kernel.org>, <stefanos@xilinx.com>, <julien@xen.org>,
	<Volodymyr_Babchuk@epam.com>, <bertrand.marquis@arm.com>, Ayan Kumar Halder
	<ayankuma@xilinx.com>
Subject: [XEN v8 2/2] xen/arm64: io: Support instructions (for which ISS is not valid) on emulated MMIO region using MMIO/ioreq handler
Date: Sat, 12 Feb 2022 23:34:33 +0000
Message-ID: <20220212233433.46018-3-ayankuma@xilinx.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20220212233433.46018-1-ayankuma@xilinx.com>
References: <20220212233433.46018-1-ayankuma@xilinx.com>
MIME-Version: 1.0
Content-Type: text/plain
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 1cc2a274-1032-49c2-446d-08d9ee804324
X-MS-TrafficTypeDiagnostic: BL3PR02MB7924:EE_
X-Microsoft-Antispam-PRVS:
	<BL3PR02MB79245811DF7B6440E3E095A4B2319@BL3PR02MB7924.namprd02.prod.outlook.com>
X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply
X-MS-Oob-TLC-OOBClassifiers: OLM:6108;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	P6Sre/7sP/xeTBO2GmY/WvdGbo/pIpS76r/cDXX9p2cpW05+uvdZIKWSdJ+Pwg8K766EfY+xA23nhywHFDTB5vMmrYVG2ioCKv64gGvmj1LiTwq9j6Rs1AJlMHhNV7+QouwtUR3cGhQwQsn37GlRn6oJ1JYkXOg7kffrrMfVjj3PoYoUL90kGx0GTZJaUAd1Iq8lHSf7bkbYOrViEhzWKMFe2JaVDOZzeleX458giRbQTcdp1WzxaOkmvlnRUuoyf4uLF6lDKciwpwfItHEj607GozXfE8aO6IlJeO+I6JMAIfXVKIlyS+sN5fPyaMMFdkBLekaJES05gPTqk0M0lpsFMsrNZtcVzN9LLmS3P47lnxP2uCCW/jwZRPSx+mkIrYc2xzZ2LEmy7bCyznrzBh1M8i4flCCykHgoK1ZE5jOFJ9oHtVLEE0oc/pyLBuNWdFt3IlciER4aS/d+/nCwYy3eWYJbUCASA2rVpkiU/kUuL8GsyN8KFtX3/Dm2aHhSJtTNBf9UGFdmYDslRu9/kS+BMkVVCIs3LldWWuveWrnVNcaqufadP5+OOQFvypIcPvb5L28gZimttAa8MTEft5/b/HCjfslHGNO0bPB7ItGpwZ0z2K/kgmy7uuv/LozFsW2y3wiNqzVWJEoDv3JsmZ0wpK1wO6qwoeIOwVh5hX9D8i4fxxa+z1uaqOBODvNsIE883ZPJIWLI0I6z7th9ww==
X-Forefront-Antispam-Report:
	CIP:149.199.80.198;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:xir-pvapexch02.xlnx.xilinx.com;PTR:unknown-80-198.xilinx.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(36860700001)(107886003)(356005)(2616005)(7636003)(47076005)(36756003)(7696005)(1076003)(83380400001)(2906002)(6666004)(5660300002)(186003)(426003)(26005)(70206006)(508600001)(4326008)(8936002)(9786002)(6916009)(30864003)(316002)(54906003)(8676002)(82310400004)(336012)(70586007)(102446001)(473944003);DIR:OUT;SFP:1101;
X-OriginatorOrg: xilinx.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Feb 2022 23:34:49.6654
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 1cc2a274-1032-49c2-446d-08d9ee804324
X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.80.198];Helo=[xir-pvapexch02.xlnx.xilinx.com]
X-MS-Exchange-CrossTenant-AuthSource:
	SN1NAM02FT0064.eop-nam02.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR02MB7924

When an instruction is trapped in Xen due to translation fault, Xen
checks if the ISS is valid. If not, Xen tries to resolve the translation
fault using p2m page tables. In case if it is a data abort, Xen will
try to map the mmio region to the guest (ie tries to emulate the mmio
region).

If the ISS is not valid and it is a data abort, then Xen tries to
decode the instruction. In case of ioreq, Xen  saves the decoding state,
rn and imm9 to vcpu_io. Whenever the vcpu handles the ioreq successfully,
it will read the decoding state to determine if the instruction decoded
was a ldr/str post indexing (ie INSTR_LDR_STR_POSTINDEXING). If so, it
uses these details to post increment rn.

In case of mmio handler, if the mmio operation was successful, then Xen
retrives the decoding state, rn and imm9. For state ==
INSTR_LDR_STR_POSTINDEXING, Xen will update rn.

If there is an error encountered while decoding the instruction, Xen
will issue an abort to the guest. If the instruction was trapped due
to stage1 page translation table walk, Xen will update the page tables
(under the assumption that they are in non-MMIO region) and will return
to the guest so that it can retry the instruction. To handle all these
different states, we have introduced 'enum instr_decode_state'.

Signed-off-by: Ayan Kumar Halder <ayankuma@xilinx.com>
---

Changelog :-

v2..v5 - Mentioned in the cover letter.

v6 - 1. Mantained the decoding state of the instruction. This is used by the
caller to either abort the guest or retry or ignore or perform read/write on
the mmio region.

2. try_decode() invokes decoding for both aarch64 and thumb state. (Previously
it used to invoke decoding only for aarch64 state). Thus, it handles all the
checking of the registers before invoking any decoding of instruction.
try_decode_instruction_invalid_iss() has thus been removed.

3. Introduced a new field('enum instr_decode_state state') inside
'struct instr_details'. This holds the decoding state of the instruction.
This is later read by the post_increment_register() to determine if rn needs to
be incremented. Also, this is read by the callers of try_decode_instruction()
to determine if the instruction was valid or ignored or to be retried or
error or decoded successfully.

4. Also stored 'instr_details' inside 'struct ioreq'. This enables
arch_ioreq_complete_mmio() to invoke post_increment_register() without decoding
the instruction again.

5. Check hsr.dabt.valid in do_trap_stage2_abort_guest(). If it is not valid,
then decode the instruction. This ensures that try_handle_mmio() is invoked only
when the instruction is either valid or decoded successfully.

6. Inside do_trap_stage2_abort_guest(), if hsr.dabt.valid is not set, then
resolve the translation fault before trying to decode the instruction. If
translation fault is resolved, then return to the guest to execute the instruction
again.


v7 - 1. Moved the decoding instruction details ie instr_details from 'struct ioreq'
to 'struct vcpu_io'.

2. The instruction is decoded only when we get a data abort.

3. Replaced ASSERT_UNREACHABLE() with domain_crash(). The reason being asserts
can be disabled in some builds. In this scenario when the guest's cpsr is in an
erroneous state, Xen should crash the guest.

4. Introduced check_p2m() which invokes p2m_resolve_translation_fault() and
try_map_mmio() to resolve translation fault by configuring the page tables. This
gets invoked first if ISS is invalid and it is an instruction abort. If it is
a data abort and hsr.dabt.s1ptw is set or try_handle_mmio() returns IO_UNHANDLED,
then check_p2m() gets invoked again.


v8 - 1. Removed the handling of data abort when info->dabt.cache is set. This will
be implemented in a subsequent patch. (Not as part of this series)

2. When the data abort is due to access to stage 1 translation tables, Xen will
try to fix the mapping of the page table for the corresponding address. If this
returns an error, Xen will abort the guest. Else, it will ask the guest to retry
the instruction.

3. Changed v->io.info.dabt_instr from pointer to variable. The reason being that
arch_ioreq_complete_mmio() is called from leave_hypervisor_to_guest().
That is after do_trap_stage2_abort_guest()  has been invoked. So the original
variable will be no longer valid.

4. Some other style issues pointed out in v7.


 xen/arch/arm/arm32/traps.c        |  7 +++
 xen/arch/arm/arm64/traps.c        | 47 +++++++++++++++
 xen/arch/arm/decode.c             |  1 +
 xen/arch/arm/include/asm/domain.h |  4 ++
 xen/arch/arm/include/asm/mmio.h   | 15 ++++-
 xen/arch/arm/include/asm/traps.h  |  2 +
 xen/arch/arm/io.c                 | 98 ++++++++++++++++++++-----------
 xen/arch/arm/ioreq.c              |  7 ++-
 xen/arch/arm/traps.c              | 80 +++++++++++++++++++++----
 xen/arch/x86/include/asm/ioreq.h  |  3 +
 xen/include/xen/sched.h           |  2 +
 11 files changed, 217 insertions(+), 49 deletions(-)

diff --git a/xen/arch/arm/arm32/traps.c b/xen/arch/arm/arm32/traps.c
index 9c9790a6d1..70c6238196 100644
--- a/xen/arch/arm/arm32/traps.c
+++ b/xen/arch/arm/arm32/traps.c
@@ -18,9 +18,11 @@
 
 #include <xen/lib.h>
 #include <xen/kernel.h>
+#include <xen/sched.h>
 
 #include <public/xen.h>
 
+#include <asm/mmio.h>
 #include <asm/processor.h>
 #include <asm/traps.h>
 
@@ -82,6 +84,11 @@ void do_trap_data_abort(struct cpu_user_regs *regs)
         do_unexpected_trap("Data Abort", regs);
 }
 
+void post_increment_register(const struct instr_details *instr)
+{
+    domain_crash(current->domain);
+}
+
 /*
  * Local variables:
  * mode: C
diff --git a/xen/arch/arm/arm64/traps.c b/xen/arch/arm/arm64/traps.c
index 9113a15c7a..a6766689b3 100644
--- a/xen/arch/arm/arm64/traps.c
+++ b/xen/arch/arm/arm64/traps.c
@@ -23,6 +23,7 @@
 #include <asm/processor.h>
 
 #include <public/xen.h>
+#include <xen/sched.h>
 
 static const char *handler[]= {
         "Synchronous Abort",
@@ -44,6 +45,52 @@ void do_bad_mode(struct cpu_user_regs *regs, int reason)
     panic("bad mode\n");
 }
 
+void post_increment_register(const struct instr_details *instr)
+{
+    struct cpu_user_regs *regs = guest_cpu_user_regs();
+    register_t val = 0;
+
+    /* Currently, we handle only ldr/str post indexing instructions */
+    if ( instr->state != INSTR_LDR_STR_POSTINDEXING )
+        return;
+
+    /*
+     * Handle when rn = SP
+     * Refer ArmV8 ARM DDI 0487G.b, Page - D1-2463 "Stack pointer register
+     * selection"
+     * t = SP_EL0
+     * h = SP_ELx
+     * and M[3:0] (Page - C5-474 "When exception taken from AArch64 state:")
+     */
+    if (instr->rn == 31 )
+    {
+        if ( (regs->cpsr & PSR_MODE_MASK) == PSR_MODE_EL1h )
+            val = regs->sp_el1;
+        else if ( ((regs->cpsr & PSR_MODE_MASK) == PSR_MODE_EL1t) ||
+                    ((regs->cpsr & PSR_MODE_MASK) == PSR_MODE_EL0t) )
+            val = regs->sp_el0;
+        else
+        {
+            domain_crash(current->domain);
+            return;
+        }
+    }
+    else
+        val = get_user_reg(regs, instr->rn);
+
+    val += instr->imm9;
+
+    if ( instr->rn == 31 )
+    {
+        if ( (regs->cpsr & PSR_MODE_MASK) == PSR_MODE_EL1h )
+            regs->sp_el1 = val;
+        else
+            regs->sp_el0 = val;
+    }
+    else
+        set_user_reg(regs, instr->rn, val);
+}
+
 /*
  * Local variables:
  * mode: C
diff --git a/xen/arch/arm/decode.c b/xen/arch/arm/decode.c
index 3c3cd703e0..e90f95ecd3 100644
--- a/xen/arch/arm/decode.c
+++ b/xen/arch/arm/decode.c
@@ -146,6 +146,7 @@ static int decode_arm64(register_t pc, mmio_info_t *info)
 
     update_dabt(dabt, opcode.ldr_str.rt, opcode.ldr_str.size, false);
 
+    dabt_instr->state = INSTR_LDR_STR_POSTINDEXING;
     dabt_instr->rn = opcode.ldr_str.rn;
     dabt_instr->imm9 = opcode.ldr_str.imm9;
 
diff --git a/xen/arch/arm/include/asm/domain.h b/xen/arch/arm/include/asm/domain.h
index 9b3647587a..40b9125141 100644
--- a/xen/arch/arm/include/asm/domain.h
+++ b/xen/arch/arm/include/asm/domain.h
@@ -266,6 +266,10 @@ static inline void arch_vcpu_block(struct vcpu *v) {}
 /* vPCI is not available on Arm */
 #define has_vpci(d)    ({ (void)(d); false; })
 
+struct arch_vcpu_io {
+    struct instr_details dabt_instr; /* when the instruction is decoded */
+};
+
 #endif /* __ASM_DOMAIN_H__ */
 
 /*
diff --git a/xen/arch/arm/include/asm/mmio.h b/xen/arch/arm/include/asm/mmio.h
index 3354d9c635..745130b7fe 100644
--- a/xen/arch/arm/include/asm/mmio.h
+++ b/xen/arch/arm/include/asm/mmio.h
@@ -26,12 +26,22 @@
 
 #define MAX_IO_HANDLER  16
 
+enum instr_decode_state
+{
+    INSTR_ERROR,                    /* Error encountered while decoding instr */
+    INSTR_VALID,                    /* ISS is valid, so no need to decode */
+    INSTR_LDR_STR_POSTINDEXING,     /* Instruction is decoded successfully.
+                                       It is ldr/str post indexing */
+    INSTR_RETRY                     /* Instruction is to be retried */
+};
+
 typedef struct
 {
     struct hsr_dabt dabt;
     struct instr_details {
         unsigned long rn:5;
         signed int imm9:9;
+        enum instr_decode_state state;
     } dabt_instr;
     paddr_t gpa;
 } mmio_info_t;
@@ -69,14 +79,15 @@ struct vmmio {
 };
 
 enum io_state try_handle_mmio(struct cpu_user_regs *regs,
-                              const union hsr hsr,
-                              paddr_t gpa);
+                              mmio_info_t *info);
 void register_mmio_handler(struct domain *d,
                            const struct mmio_handler_ops *ops,
                            paddr_t addr, paddr_t size, void *priv);
 int domain_io_init(struct domain *d, int max_count);
 void domain_io_free(struct domain *d);
 
+void try_decode_instruction(const struct cpu_user_regs *regs,
+                            mmio_info_t *info);
 
 #endif  /* __ASM_ARM_MMIO_H__ */
 
diff --git a/xen/arch/arm/include/asm/traps.h b/xen/arch/arm/include/asm/traps.h
index 2ed2b85c6f..95c46ad391 100644
--- a/xen/arch/arm/include/asm/traps.h
+++ b/xen/arch/arm/include/asm/traps.h
@@ -109,6 +109,8 @@ static inline register_t sign_extend(const struct hsr_dabt dabt, register_t r)
     return r;
 }
 
+void post_increment_register(const struct instr_details *instr);
+
 #endif /* __ASM_ARM_TRAPS__ */
 /*
  * Local variables:
diff --git a/xen/arch/arm/io.c b/xen/arch/arm/io.c
index a289d393f9..203466b869 100644
--- a/xen/arch/arm/io.c
+++ b/xen/arch/arm/io.c
@@ -95,57 +95,87 @@ static const struct mmio_handler *find_mmio_handler(struct domain *d,
     return handler;
 }
 
+void try_decode_instruction(const struct cpu_user_regs *regs,
+                            mmio_info_t *info)
+{
+    int rc;
+
+    /*
+     * Erratum 766422: Thumb store translation fault to Hypervisor may
+     * not have correct HSR Rt value.
+     */
+    if ( check_workaround_766422() && (regs->cpsr & PSR_THUMB) &&
+         info->dabt.write )
+    {
+        rc = decode_instruction(regs, info);
+        if ( rc )
+        {
+            gprintk(XENLOG_DEBUG, "Unable to decode instruction\n");
+            info->dabt_instr.state = INSTR_ERROR;
+            return;
+        }
+    }
+
+    /* If ISS is valid, then no need to decode the instruction any further */
+    if ( info->dabt.valid )
+    {
+        info->dabt_instr.state = INSTR_VALID;
+        return;
+    }
+
+    /*
+     * Xen should not decode the instruction when it was trapped due to
+     * translation fault.
+     */
+    if ( info->dabt.s1ptw )
+    {
+        info->dabt_instr.state = INSTR_RETRY;
+        return;
+    }
+
+    /*
+     * Armv8 processor does not provide a valid syndrome for decoding some
+     * instructions. So in order to process these instructions, Xen must
+     * decode them.
+     */
+    rc = decode_instruction(regs, info);
+    if ( rc )
+    {
+        gprintk(XENLOG_ERR, "Unable to decode instruction\n");
+        info->dabt_instr.state = INSTR_ERROR;
+    }
+}
+
 enum io_state try_handle_mmio(struct cpu_user_regs *regs,
-                              const union hsr hsr,
-                              paddr_t gpa)
+                              mmio_info_t *info)
 {
     struct vcpu *v = current;
     const struct mmio_handler *handler = NULL;
-    const struct hsr_dabt dabt = hsr.dabt;
-    mmio_info_t info = {
-        .gpa = gpa,
-        .dabt = dabt
-    };
+    int rc;
 
-    ASSERT(hsr.ec == HSR_EC_DATA_ABORT_LOWER_EL);
+    ASSERT(info->dabt.ec == HSR_EC_DATA_ABORT_LOWER_EL);
 
-    handler = find_mmio_handler(v->domain, info.gpa);
+    handler = find_mmio_handler(v->domain, info->gpa);
     if ( !handler )
     {
-        int rc;
-
-        rc = try_fwd_ioserv(regs, v, &info);
+        rc = try_fwd_ioserv(regs, v, info);
         if ( rc == IO_HANDLED )
             return handle_ioserv(regs, v);
 
         return rc;
     }
 
-    /* All the instructions used on emulated MMIO region should be valid */
-    if ( !dabt.valid )
-        return IO_ABORT;
-
     /*
-     * Erratum 766422: Thumb store translation fault to Hypervisor may
-     * not have correct HSR Rt value.
+     * At this point, we know that the instruction is either valid or has been
+     * decoded successfully. Thus, Xen should be allowed to execute the
+     * instruction on the emulated MMIO region.
      */
-    if ( check_workaround_766422() && (regs->cpsr & PSR_THUMB) &&
-         dabt.write )
-    {
-        int rc;
-
-        rc = decode_instruction(regs, &info);
-        if ( rc )
-        {
-            gprintk(XENLOG_DEBUG, "Unable to decode instruction\n");
-            return IO_ABORT;
-        }
-    }
-
-    if ( info.dabt.write )
-        return handle_write(handler, v, &info);
+    if ( info->dabt.write )
+        rc = handle_write(handler, v, info);
     else
-        return handle_read(handler, v, &info);
+        rc = handle_read(handler, v, info);
+
+    return rc;
 }
 
 void register_mmio_handler(struct domain *d,
diff --git a/xen/arch/arm/ioreq.c b/xen/arch/arm/ioreq.c
index 308650b400..3c0a935ccf 100644
--- a/xen/arch/arm/ioreq.c
+++ b/xen/arch/arm/ioreq.c
@@ -47,6 +47,7 @@ enum io_state try_fwd_ioserv(struct cpu_user_regs *regs,
                              struct vcpu *v, mmio_info_t *info)
 {
     struct vcpu_io *vio = &v->io;
+    struct dabt_instr instr = info->dabt_instr;
     ioreq_t p = {
         .type = IOREQ_TYPE_COPY,
         .addr = info->gpa,
@@ -76,10 +77,8 @@ enum io_state try_fwd_ioserv(struct cpu_user_regs *regs,
     if ( !s )
         return IO_UNHANDLED;
 
-    if ( !info->dabt.valid )
-        return IO_ABORT;
-
     vio->req = p;
+    vio->info.dabt_instr = instr;
 
     rc = ioreq_send(s, &p, 0);
     if ( rc != IO_RETRY || v->domain->is_shutting_down )
@@ -95,6 +94,7 @@ enum io_state try_fwd_ioserv(struct cpu_user_regs *regs,
 bool arch_ioreq_complete_mmio(void)
 {
     struct vcpu *v = current;
+    struct instr_details dabt_instr = v->io.info.dabt_instr;
     struct cpu_user_regs *regs = guest_cpu_user_regs();
     const union hsr hsr = { .bits = regs->hsr };
 
@@ -106,6 +106,7 @@ bool arch_ioreq_complete_mmio(void)
 
     if ( handle_ioserv(regs, v) == IO_HANDLED )
     {
+        post_increment_register(&dabt_instr);
         advance_pc(regs, hsr);
         return true;
     }
diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c
index 9339d12f58..455e51cdbe 100644
--- a/xen/arch/arm/traps.c
+++ b/xen/arch/arm/traps.c
@@ -1893,6 +1893,21 @@ static bool try_map_mmio(gfn_t gfn)
     return !map_regions_p2mt(d, gfn, 1, mfn, p2m_mmio_direct_c);
 }
 
+static inline bool check_p2m(bool is_data, paddr_t gpa)
+{
+    /*
+     * First check if the translation fault can be resolved by the P2M subsystem.
+     * If that's the case nothing else to do.
+     */
+    if ( p2m_resolve_translation_fault(current->domain,gaddr_to_gfn(gpa)) )
+        return true;
+
+    if ( is_data && try_map_mmio(gaddr_to_gfn(gpa)) )
+        return true;
+
+    return false;
+}
+
 static void do_trap_stage2_abort_guest(struct cpu_user_regs *regs,
                                        const union hsr hsr)
 {
@@ -1906,6 +1921,7 @@ static void do_trap_stage2_abort_guest(struct cpu_user_regs *regs,
     paddr_t gpa;
     uint8_t fsc = xabt.fsc & ~FSC_LL_MASK;
     bool is_data = (hsr.ec == HSR_EC_DATA_ABORT_LOWER_EL);
+    mmio_info_t info;
 
     /*
      * If this bit has been set, it means that this stage-2 abort is caused
@@ -1959,6 +1975,25 @@ static void do_trap_stage2_abort_guest(struct cpu_user_regs *regs,
         return;
     }
     case FSC_FLT_TRANS:
+    {
+        info.gpa = gpa;
+        info.dabt = hsr.dabt;
+
+        /* Check that the ISS is invalid and it is not data abort. */
+        if ( !hsr.dabt.valid && !is_data )
+        {
+
+            /*
+             * Assumption :- Most of the times when we get a translation fault
+             * and the ISS is invalid, the underlying cause is that the page
+             * tables have not been set up correctly.
+             */
+            if ( check_p2m(is_data, gpa) )
+                return;
+            else
+                goto inject_abt;
+        }
+
         /*
          * Attempt first to emulate the MMIO as the data abort will
          * likely happen in an emulated region.
@@ -1967,13 +2002,45 @@ static void do_trap_stage2_abort_guest(struct cpu_user_regs *regs,
          */
         if ( is_data )
         {
-            enum io_state state = try_handle_mmio(regs, hsr, gpa);
+            enum io_state state;
+
+            try_decode_instruction(regs, &info);
+
+            /*
+             * If Xen could not decode the instruction for any reason, then it
+             * should ask the caller to abort the guest.
+             */
+            if ( info.dabt_instr.state == INSTR_ERROR )
+                goto inject_abt;
+
+            /*
+             * When the instruction needs to be retried by the guest after
+             * resolving the translation fault.
+             */
+            else if ( info.dabt_instr.state == INSTR_RETRY )
+            {
+                /*
+                 * Try resolving the translation fault for access to the stage1
+                 * translation tables which should be in non MMIO region.
+                 */
+                if ( !check_p2m(false, gpa) )
+                    goto inject_abt;
+            }
+
+            state = try_handle_mmio(regs, &info);
 
             switch ( state )
             {
             case IO_ABORT:
                 goto inject_abt;
             case IO_HANDLED:
+                /*
+                 * If the instruction was decoded and has executed successfully
+                 * on the MMIO region, then Xen should execute the next part of
+                 * the instruction. (for eg increment the rn if it is a
+                 * post-indexing instruction.
+                 */
+                post_increment_register(&info.dabt_instr);
                 advance_pc(regs, hsr);
                 return;
             case IO_RETRY:
@@ -1985,18 +2052,11 @@ static void do_trap_stage2_abort_guest(struct cpu_user_regs *regs,
             }
         }
 
-        /*
-         * First check if the translation fault can be resolved by the
-         * P2M subsystem. If that's the case nothing else to do.
-         */
-        if ( p2m_resolve_translation_fault(current->domain,
-                                           gaddr_to_gfn(gpa)) )
-            return;
-
-        if ( is_data && try_map_mmio(gaddr_to_gfn(gpa)) )
+        if ( check_p2m(is_data, gpa) )
             return;
 
         break;
+    }
     default:
         gprintk(XENLOG_WARNING,
                 "Unsupported FSC: HSR=%#"PRIregister" DFSC=%#x\n",
diff --git a/xen/arch/x86/include/asm/ioreq.h b/xen/arch/x86/include/asm/ioreq.h
index d06ce9a6ea..ecfe7f9fdb 100644
--- a/xen/arch/x86/include/asm/ioreq.h
+++ b/xen/arch/x86/include/asm/ioreq.h
@@ -26,6 +26,9 @@
 #include <asm/hvm/ioreq.h>
 #endif
 
+struct arch_vcpu_io {
+};
+
 #endif /* __ASM_X86_IOREQ_H__ */
 
 /*
diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
index 37f78cc4c4..afe5508be8 100644
--- a/xen/include/xen/sched.h
+++ b/xen/include/xen/sched.h
@@ -160,6 +160,8 @@ struct vcpu_io {
     /* I/O request in flight to device model. */
     enum vio_completion  completion;
     ioreq_t              req;
+    /* Arch specific info pertaining to the io request */
+    struct arch_vcpu_io  info;
 };
 
 struct vcpu
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Sat Feb 12 23:35:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 12 Feb 2022 23:35:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270874.465217 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJ1uo-0001k7-Ge; Sat, 12 Feb 2022 23:34:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270874.465217; Sat, 12 Feb 2022 23:34:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJ1uo-0001k0-DY; Sat, 12 Feb 2022 23:34:54 +0000
Received: by outflank-mailman (input) for mailman id 270874;
 Sat, 12 Feb 2022 23:34:53 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=u0Ww=S3=xilinx.com=ayankuma@srs-se1.protection.inumbo.net>)
 id 1nJ1un-0001U4-Jj
 for xen-devel@lists.xenproject.org; Sat, 12 Feb 2022 23:34:53 +0000
Received: from NAM12-DM6-obe.outbound.protection.outlook.com
 (mail-dm6nam12on20614.outbound.protection.outlook.com
 [2a01:111:f400:fe59::614])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5f6668da-8c5c-11ec-8eb8-a37418f5ba1a;
 Sun, 13 Feb 2022 00:34:52 +0100 (CET)
Received: from SN4PR0401CA0039.namprd04.prod.outlook.com
 (2603:10b6:803:2a::25) by BL0PR02MB4580.namprd02.prod.outlook.com
 (2603:10b6:208:40::27) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.15; Sat, 12 Feb
 2022 23:34:47 +0000
Received: from SN1NAM02FT0060.eop-nam02.prod.protection.outlook.com
 (2603:10b6:803:2a:cafe::39) by SN4PR0401CA0039.outlook.office365.com
 (2603:10b6:803:2a::25) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.14 via Frontend
 Transport; Sat, 12 Feb 2022 23:34:46 +0000
Received: from xir-pvapexch02.xlnx.xilinx.com (149.199.80.198) by
 SN1NAM02FT0060.mail.protection.outlook.com (10.97.4.134) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.4975.11 via Frontend Transport; Sat, 12 Feb 2022 23:34:46 +0000
Received: from xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) by
 xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2176.14; Sat, 12 Feb 2022 23:34:44 +0000
Received: from smtp.xilinx.com (172.21.105.198) by
 xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server id
 15.1.2176.14 via Frontend Transport; Sat, 12 Feb 2022 23:34:44 +0000
Received: from [10.108.8.223] (port=57002 helo=xcbayankuma41x.xilinx.com)
 by smtp.xilinx.com with esmtp (Exim 4.90)
 (envelope-from <ayan.kumar.halder@xilinx.com>)
 id 1nJ1ue-0006SM-OS; Sat, 12 Feb 2022 23:34:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5f6668da-8c5c-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=E6lSejk360ZSRTP207x2kJsCPXRZa6RYXDQJcQ0EaT0GG7Zx1BNXhE1sXVgqq9VOwbhGKnE5BmR3eMEB0YVLifJ+/+KFL8erVqgXaTiDQZq2M3W0WU2KV778BVD9odQepzj42Aq+3d3+V/DnnFqCThyCD/A5cvSX7NVuz2EJT4RurM1YMOs3l6FPHmPrOXbTYE047n3Sigu5dnKk/WwKpJXLL5xnqrkVEystfYXYRrYgxDoVXNFsF0gnS7yb9Cv0qzSDIW6UkWACiFy8Cokt7lm20NrpODpc6B1/TB0AO52O8tyqfB/Oa0IrRi3RFJsHi0sMHiDTnhNnz+GMYvo3BQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=5HT5IRRBRqCfZCmtaXFR4rjZP12Su6d9eB8IzF3Ul0o=;
 b=F1L35XKchQJ+B7XfRoFxW+vMmq4WH5YxmqiyB2ji/ui3iCX26Hfksm1XsjG00qRa4gfe2JykolsU9ST8aPPh6XjhI6Zx0ixCt0v6pCG5L8UPVdD6yrdR6ttwBYgiumjqeMAyWQnZi4ZNh2ov0HOj9GpPfgXjkProc/nWdGIJMb1UbSxzGXTkChtiVjAkDMCadOKgrmHbtAGqebze7RGdIuJY+TVpsXucNE0XP8PpLV7HHlzweHBpKlJbWIiVBQsEa0B/6CKsLemQZz17xRBleRJZr7WpV9AX5am07Dgrn4jRkPVMNBjgB2qv8gX1UOaFBJo/hFZ3Cx1akITR89L+UA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 149.199.80.198) smtp.rcpttodomain=lists.xenproject.org
 smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none
 header.from=xilinx.com; dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=5HT5IRRBRqCfZCmtaXFR4rjZP12Su6d9eB8IzF3Ul0o=;
 b=T6HNiH3Y58wxs1b/6ckP8q9crNw4XwtpvMdj9K6eQ7o0UhhKb82GAyaObukQV/r5VgWuhMn0b4CKWeiAyVRUa1bEDyTOx4wAx5LfgXULb61nyAoKO9OoDYpVno/nUIZR+K7wqRXtD+wRBpzDbK5VbP4qUm9Nhzl8PC/xiUDP5IY=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198)
 smtp.mailfrom=xilinx.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=xilinx.com;
Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates
 149.199.80.198 as permitted sender) receiver=protection.outlook.com;
 client-ip=149.199.80.198; helo=xir-pvapexch02.xlnx.xilinx.com;
From: Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>
To: <xen-devel@lists.xenproject.org>
CC: <sstabellini@kernel.org>, <stefanos@xilinx.com>, <julien@xen.org>,
	<Volodymyr_Babchuk@epam.com>, <bertrand.marquis@arm.com>, Ayan Kumar Halder
	<ayankuma@xilinx.com>
Subject: [XEN v8 1/2] xen/arm64: Decode ldr/str post increment operations
Date: Sat, 12 Feb 2022 23:34:32 +0000
Message-ID: <20220212233433.46018-2-ayankuma@xilinx.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20220212233433.46018-1-ayankuma@xilinx.com>
References: <20220212233433.46018-1-ayankuma@xilinx.com>
MIME-Version: 1.0
Content-Type: text/plain
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5720377c-b70b-4657-a1b4-08d9ee804110
X-MS-TrafficTypeDiagnostic: BL0PR02MB4580:EE_
X-Microsoft-Antispam-PRVS:
	<BL0PR02MB458057193C2E5C3F3498BB15B2319@BL0PR02MB4580.namprd02.prod.outlook.com>
X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Sg9SZVG3dUGhgOiRX2Dp1djwdXLh0vHlodUDIjH4HS0FczZhO1RAhIzVT2N8mztM7xZEd+h5bpWDRtWdmT5WhDkV8S19RXS2UhqyOQp2RF3zQjHzNx5Y+jFfYcdeXLq1R0gVZy9TedB/megMWuLFc6hyiD2obljIkEZtCRaWfPoDufaBHDAwFvQSWoNJ9hGa4yfTBDklI6TIZ0gNXD/SgPcx56P6gSKuppHtxeey5MQwWUUCxO2EmZNogAh67Mv047BDdrYDc2SbvtM/KigN7A23POQme9CY1FWcTb6rpLez7zwJLCduc0uR/3CffV5rCOc5OdsZ2Ibg7Z4GQsiqavY/gpVWGxuY8j7McC+Fp7BQDnQC8Q5yN9NttcZPmE3E8+TLsaXxTZEDq3RIaJDInkW4+b/KyYT2SyITzotcRVeDlAQDoxtz8TmRN7LDebfXbxb2SuJCxo9THyThFxdQp7TejKIxtQv1JpcqRfpunz0e6a+cMr64UEISPt0JiVze1RWinaRHCBM8pOdlLbKPc1BZfSzF64GHlD1VSORrcUzhxI+L3WahrlesgyKCvvV6DP8KtIR9KmV5rplYS0J+q7D0mrjmSBgrEjbcjkdA/TozGdINnBoc4k7b1F5rKtH6TgfdMTWtyGFG/FzX71s0UoQRtzSsdNV480xzskTUR4yrXhyW7AdwYZmApgKlSAhm
X-Forefront-Antispam-Report:
	CIP:149.199.80.198;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:xir-pvapexch02.xlnx.xilinx.com;PTR:unknown-80-198.xilinx.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(5660300002)(2616005)(336012)(426003)(6666004)(83380400001)(8936002)(9786002)(1076003)(107886003)(508600001)(36756003)(186003)(26005)(7696005)(2906002)(36860700001)(4326008)(6916009)(82310400004)(47076005)(54906003)(316002)(356005)(70586007)(8676002)(70206006)(7636003)(102446001);DIR:OUT;SFP:1101;
X-OriginatorOrg: xilinx.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Feb 2022 23:34:46.1813
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 5720377c-b70b-4657-a1b4-08d9ee804110
X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.80.198];Helo=[xir-pvapexch02.xlnx.xilinx.com]
X-MS-Exchange-CrossTenant-AuthSource:
	SN1NAM02FT0060.eop-nam02.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR02MB4580

At the moment, Xen does not decode any of the arm64 instructions. This
means that when hsr_dabt.isv == 0, Xen cannot handle those instructions.
This will lead to Xen to abort the guests (from which those instructions
originate).

With this patch, Xen is able to decode ldr/str post indexing instructions.
These are a subset of instructions for which hsr_dabt.isv == 0.

The following instructions are now supported by Xen :-
1.      ldr     x2,    [x1],    #8
2.      ldr     w2,    [x1],    #-4
3.      ldr     x2,    [x1],    #-8
4.      ldr     w2,    [x1],    #4
5.      ldrh    w2,    [x1],    #2
6.      ldrb    w2,    [x1],    #1
7.      str     x2,    [x1],    #8
8.      str     w2,    [x1],    #-4
9.      strh    w2,    [x1],    #2
10.     strb    w2,    [x1],    #1

In the subsequent patch, decode_arm64() will get invoked when
hsr_dabt.isv == 0.

Signed-off-by: Ayan Kumar Halder <ayankuma@xilinx.com>
---

Changelog :-

v2..v5 - Mentioned in the cover letter.

v6 - 1. Fixed the code style issues as mentioned in v5.

v7 - No change.

v8 - 1. Removed some un-necessary header files inclusion.
     2. Some style changes pointed out in v7.

 xen/arch/arm/decode.c           | 79 ++++++++++++++++++++++++++++++++-
 xen/arch/arm/decode.h           | 48 +++++++++++++++++---
 xen/arch/arm/include/asm/mmio.h |  4 ++
 xen/arch/arm/io.c               |  2 +-
 4 files changed, 124 insertions(+), 9 deletions(-)

diff --git a/xen/arch/arm/decode.c b/xen/arch/arm/decode.c
index 792c2e92a7..3c3cd703e0 100644
--- a/xen/arch/arm/decode.c
+++ b/xen/arch/arm/decode.c
@@ -84,6 +84,78 @@ bad_thumb2:
     return 1;
 }
 
+static int decode_arm64(register_t pc, mmio_info_t *info)
+{
+    union instr opcode = {0};
+    struct hsr_dabt *dabt = &info->dabt;
+    struct instr_details *dabt_instr = &info->dabt_instr;
+
+    if ( raw_copy_from_guest(&opcode.value, (void * __user)pc, sizeof (opcode)) )
+    {
+        gprintk(XENLOG_ERR, "Could not copy the instruction from PC\n");
+        return 1;
+    }
+
+    /*
+     * Refer Arm v8 ARM DDI 0487G.b, Page - C6-1107
+     * "Shared decode for all encodings" (under ldr immediate)
+     * If n == t && n != 31, then the return value is implementation defined
+     * (can be WBSUPPRESS, UNKNOWN, UNDEFINED or NOP). Thus, we do not support
+     * this. This holds true for ldrb/ldrh immediate as well.
+     *
+     * Also refer, Page - C6-1384, the above described behaviour is same for
+     * str immediate. This holds true for strb/strh immediate as well
+     */
+    if ( (opcode.ldr_str.rn == opcode.ldr_str.rt) && (opcode.ldr_str.rn != 31) )
+    {
+        gprintk(XENLOG_ERR, "Rn should not be equal to Rt except for r31\n");
+        goto bad_loadstore;
+    }
+
+    /* First, let's check for the fixed values */
+    if ( (opcode.value & POST_INDEX_FIXED_MASK) != POST_INDEX_FIXED_VALUE )
+    {
+        gprintk(XENLOG_ERR,
+                "Decoding instruction 0x%x is not supported\n", opcode.value);
+        goto bad_loadstore;
+    }
+
+    if ( opcode.ldr_str.v != 0 )
+    {
+        gprintk(XENLOG_ERR,
+                "ldr/str post indexing for vector types are not supported\n");
+        goto bad_loadstore;
+    }
+
+    /* Check for STR (immediate) */
+    if ( opcode.ldr_str.opc == 0 )
+        dabt->write = 1;
+    /* Check for LDR (immediate) */
+    else if ( opcode.ldr_str.opc == 1 )
+        dabt->write = 0;
+    else
+    {
+        gprintk(XENLOG_ERR,
+                "Decoding ldr/str post indexing is not supported for this variant\n");
+        goto bad_loadstore;
+    }
+
+    gprintk(XENLOG_INFO,
+            "opcode->ldr_str.rt = 0x%x, opcode->ldr_str.size = 0x%x, opcode->ldr_str.imm9 = %d\n",
+            opcode.ldr_str.rt, opcode.ldr_str.size, opcode.ldr_str.imm9);
+
+    update_dabt(dabt, opcode.ldr_str.rt, opcode.ldr_str.size, false);
+
+    dabt_instr->rn = opcode.ldr_str.rn;
+    dabt_instr->imm9 = opcode.ldr_str.imm9;
+
+    return 0;
+
+ bad_loadstore:
+    gprintk(XENLOG_ERR, "unhandled Arm instruction 0x%x\n", opcode.value);
+    return 1;
+}
+
 static int decode_thumb(register_t pc, struct hsr_dabt *dabt)
 {
     uint16_t instr;
@@ -150,10 +222,13 @@ bad_thumb:
     return 1;
 }
 
-int decode_instruction(const struct cpu_user_regs *regs, struct hsr_dabt *dabt)
+int decode_instruction(const struct cpu_user_regs *regs, mmio_info_t *info)
 {
     if ( is_32bit_domain(current->domain) && regs->cpsr & PSR_THUMB )
-        return decode_thumb(regs->pc, dabt);
+        return decode_thumb(regs->pc, &info->dabt);
+
+    if ( !psr_mode_is_32bit(regs) )
+        return decode_arm64(regs->pc, info);
 
     /* TODO: Handle ARM instruction */
     gprintk(XENLOG_ERR, "unhandled ARM instruction\n");
diff --git a/xen/arch/arm/decode.h b/xen/arch/arm/decode.h
index 4613763bdb..13db8ac968 100644
--- a/xen/arch/arm/decode.h
+++ b/xen/arch/arm/decode.h
@@ -23,19 +23,55 @@
 #include <asm/regs.h>
 #include <asm/processor.h>
 
-/**
+/*
+ * Refer to the ARMv8 ARM (DDI 0487G.b), Section C4.1.4 Loads and Stores
+ * Page 318 specifies the following bit pattern for
+ * "load/store register (immediate post-indexed)".
+ *
+ * 31 30 29  27 26 25  23   21 20              11   9         4       0
+ * ___________________________________________________________________
+ * |size|1 1 1 |V |0 0 |opc |0 |      imm9     |0 1 |  Rn     |  Rt   |
+ * |____|______|__|____|____|__|_______________|____|_________|_______|
+ */
+union instr {
+    uint32_t value;
+    struct {
+        unsigned int rt:5;     /* Rt register */
+        unsigned int rn:5;     /* Rn register */
+        unsigned int fixed1:2; /* value == 01b */
+        signed int imm9:9;     /* imm9 */
+        unsigned int fixed2:1; /* value == 0b */
+        unsigned int opc:2;    /* opc */
+        unsigned int fixed3:2; /* value == 00b */
+        unsigned int v:1;      /* vector */
+        unsigned int fixed4:3; /* value == 111b */
+        unsigned int size:2;   /* size */
+    } ldr_str;
+};
+
+#define POST_INDEX_FIXED_MASK   0x3B200C00
+#define POST_INDEX_FIXED_VALUE  0x38000400
+
+/*
  * Decode an instruction from pc
- * /!\ This function is not intended to fully decode an instruction. It
- * considers that the instruction is valid.
+ * /!\ This function is intended to decode an instruction. It considers that the
+ * instruction is valid.
  *
- * This function will get:
- *  - The transfer register
+ * In case of thumb mode, this function will get:
+ *  - The transfer register (ie Rt)
  *  - Sign bit
  *  - Size
+ *
+ * In case of arm64 mode, this function will get:
+ * - The transfer register (ie Rt)
+ * - The source register (ie Rn)
+ * - Size
+ * - Immediate offset
+ * - Read or write
  */
 
 int decode_instruction(const struct cpu_user_regs *regs,
-                       struct hsr_dabt *dabt);
+                       mmio_info_t *info);
 
 #endif /* __ARCH_ARM_DECODE_H_ */
 
diff --git a/xen/arch/arm/include/asm/mmio.h b/xen/arch/arm/include/asm/mmio.h
index 7ab873cb8f..3354d9c635 100644
--- a/xen/arch/arm/include/asm/mmio.h
+++ b/xen/arch/arm/include/asm/mmio.h
@@ -29,6 +29,10 @@
 typedef struct
 {
     struct hsr_dabt dabt;
+    struct instr_details {
+        unsigned long rn:5;
+        signed int imm9:9;
+    } dabt_instr;
     paddr_t gpa;
 } mmio_info_t;
 
diff --git a/xen/arch/arm/io.c b/xen/arch/arm/io.c
index 729287e37c..a289d393f9 100644
--- a/xen/arch/arm/io.c
+++ b/xen/arch/arm/io.c
@@ -134,7 +134,7 @@ enum io_state try_handle_mmio(struct cpu_user_regs *regs,
     {
         int rc;
 
-        rc = decode_instruction(regs, &info.dabt);
+        rc = decode_instruction(regs, &info);
         if ( rc )
         {
             gprintk(XENLOG_DEBUG, "Unable to decode instruction\n");
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Sun Feb 13 03:28:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 13 Feb 2022 03:28:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270898.465240 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJ5YK-0001Ey-Pg; Sun, 13 Feb 2022 03:27:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270898.465240; Sun, 13 Feb 2022 03:27:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJ5YK-0001En-J9; Sun, 13 Feb 2022 03:27:56 +0000
Received: by outflank-mailman (input) for mailman id 270898;
 Sun, 13 Feb 2022 03:27:55 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJ5YJ-0001Ed-7e; Sun, 13 Feb 2022 03:27:55 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJ5YJ-0006Qb-4E; Sun, 13 Feb 2022 03:27:55 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJ5YI-00036D-I3; Sun, 13 Feb 2022 03:27:54 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nJ5YI-0005Fa-HI; Sun, 13 Feb 2022 03:27:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Tamcx9oIQHCi8PFkZJgxaUmVAVjkmCRv9Zga49wY8QA=; b=nZCtrMO5KBi2Vx/yozIS7RcIMg
	S3vD+AK/toDCGzHi7vnlPyvQOpGAjDIhR0Y00BNEHntc9dy8W0fAQSNktk5/IFlcyjVadtu5mxBKy
	mEI7E+Ubvl05rw7MY39lpk1m6Y+lUNGQgByq1OPFUW4uZ+ouajOophKOT0gdIK3neaS0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168093-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-5.4 test] 168093: trouble: blocked/broken/fail/pass
X-Osstest-Failures:
    linux-5.4:build-arm64:<job status>:broken:regression
    linux-5.4:build-arm64-pvops:<job status>:broken:regression
    linux-5.4:build-arm64-xsm:<job status>:broken:regression
    linux-5.4:build-arm64-xsm:host-install(4):broken:regression
    linux-5.4:build-arm64-pvops:host-install(4):broken:regression
    linux-5.4:build-arm64:host-install(4):broken:regression
    linux-5.4:test-arm64-arm64-examine:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-xl:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking
    linux-5.4:build-arm64-libvirt:build-check(1):blocked:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=52871671099d1bb3fca5ed076029e4b937bfc053
X-Osstest-Versions-That:
    linux=76fd334f07cc11e047c2237a19b2cf8b1f653ba2
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 13 Feb 2022 03:27:54 +0000

flight 168093 linux-5.4 real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168093/

Failures and problems with tests :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-arm64                     <job status>                 broken
 build-arm64-pvops               <job status>                 broken
 build-arm64-xsm                 <job status>                 broken
 build-arm64-xsm               4 host-install(4)        broken REGR. vs. 168060
 build-arm64-pvops             4 host-install(4)        broken REGR. vs. 168060
 build-arm64                   4 host-install(4)        broken REGR. vs. 168060

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-examine      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl           1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit1   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit2   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-seattle   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-thunderx  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-vhd       1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-xsm       1 build-check(1)               blocked  n/a
 build-arm64-libvirt           1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168060
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168060
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168060
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168060
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168060
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168060
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168060
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168060
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168060
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168060
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168060
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168060
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                52871671099d1bb3fca5ed076029e4b937bfc053
baseline version:
 linux                76fd334f07cc11e047c2237a19b2cf8b1f653ba2

Last test of basis   168060  2022-02-08 17:43:16 Z    4 days
Testing same since   168084  2022-02-11 08:43:38 Z    1 days    5 attempts

------------------------------------------------------------
People who touched revisions under test:
  Florian Fainelli <f.fainelli@gmail.com>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Guenter Roeck <linux@roeck-us.net>
  Jon Hunter <jonathanh@nvidia.com>
  Jon Maloy <jmaloy@redhat.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Linux Kernel Functional Testing <lkft@linaro.org>
  Shuah Khan <skhan@linuxfoundation.org>
  Slade Watkins <slade@sladewatkins.com>
  Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
  Ulf Hansson <ulf.hansson@linaro.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              broken  
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  broken  
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          blocked 
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            broken  
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          blocked 
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      blocked 
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  blocked 
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  blocked 
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     blocked 
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 blocked 
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      blocked 
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary

broken-job build-arm64 broken
broken-job build-arm64-pvops broken
broken-job build-arm64-xsm broken
broken-step build-arm64-xsm host-install(4)
broken-step build-arm64-pvops host-install(4)
broken-step build-arm64 host-install(4)

Not pushing.

------------------------------------------------------------
commit 52871671099d1bb3fca5ed076029e4b937bfc053
Author: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date:   Fri Feb 11 09:07:52 2022 +0100

    Linux 5.4.179
    
    Link: https://lore.kernel.org/r/20220209191248.688351316@linuxfoundation.org
    Tested-by: Shuah Khan <skhan@linuxfoundation.org>
    Tested-by: Florian Fainelli <f.fainelli@gmail.com>
    Tested-by: Jon Hunter <jonathanh@nvidia.com>
    Tested-by: Linux Kernel Functional Testing <lkft@linaro.org>
    Tested-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
    Tested-by: Slade Watkins <slade@sladewatkins.com>
    Tested-by: Guenter Roeck <linux@roeck-us.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

commit d692e3406e052dbf9f6d9da0cba36cb763272529
Author: Jon Maloy <jmaloy@redhat.com>
Date:   Sat Feb 5 14:11:18 2022 -0500

    tipc: improve size validations for received domain records
    
    commit 9aa422ad326634b76309e8ff342c246800621216 upstream.
    
    The function tipc_mon_rcv() allows a node to receive and process
    domain_record structs from peer nodes to track their views of the
    network topology.
    
    This patch verifies that the number of members in a received domain
    record does not exceed the limit defined by MAX_MON_DOMAIN, something
    that may otherwise lead to a stack overflow.
    
    tipc_mon_rcv() is called from the function tipc_link_proto_rcv(), where
    we are reading a 32 bit message data length field into a uint16.  To
    avert any risk of bit overflow, we add an extra sanity check for this in
    that function.  We cannot see that happen with the current code, but
    future designers being unaware of this risk, may introduce it by
    allowing delivery of very large (> 64k) sk buffers from the bearer
    layer.  This potential problem was identified by Eric Dumazet.
    
    This fixes CVE-2022-0435
    
    Reported-by: Samuel Page <samuel.page@appgate.com>
    Reported-by: Eric Dumazet <edumazet@google.com>
    Fixes: 35c55c9877f8 ("tipc: add neighbor monitoring framework")
    Signed-off-by: Jon Maloy <jmaloy@redhat.com>
    Reviewed-by: Xin Long <lucien.xin@gmail.com>
    Reviewed-by: Samuel Page <samuel.page@appgate.com>
    Reviewed-by: Eric Dumazet <edumazet@google.com>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

commit 3a0a7ec5574b510b067cfc734b8bdb6564b31d4e
Author: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date:   Thu Jan 27 08:16:38 2022 +0100

    moxart: fix potential use-after-free on remove path
    
    commit bd2db32e7c3e35bd4d9b8bbff689434a50893546 upstream.
    
    It was reported that the mmc host structure could be accessed after it
    was freed in moxart_remove(), so fix this by saving the base register of
    the device and using it instead of the pointer dereference.
    
    Cc: Ulf Hansson <ulf.hansson@linaro.org>
    Cc: Xiyu Yang <xiyuyang19@fudan.edu.cn>
    Cc: Xin Xiong <xiongx18@fudan.edu.cn>
    Cc: Xin Tan <tanxin.ctf@gmail.com>
    Cc: Tony Lindgren <tony@atomide.com>
    Cc: Yang Li <yang.lee@linux.alibaba.com>
    Cc: linux-mmc@vger.kernel.org
    Cc: stable <stable@vger.kernel.org>
    Reported-by: whitehat002 <hackyzh002@gmail.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Link: https://lore.kernel.org/r/20220127071638.4057899-1-gregkh@linuxfoundation.org
    Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>


From xen-devel-bounces@lists.xenproject.org Sun Feb 13 06:54:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 13 Feb 2022 06:54:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270909.465251 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJ8m4-00046G-IA; Sun, 13 Feb 2022 06:54:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270909.465251; Sun, 13 Feb 2022 06:54:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJ8m4-000469-F0; Sun, 13 Feb 2022 06:54:20 +0000
Received: by outflank-mailman (input) for mailman id 270909;
 Sun, 13 Feb 2022 06:54:19 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJ8m3-00045z-PE; Sun, 13 Feb 2022 06:54:19 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJ8m3-000290-MX; Sun, 13 Feb 2022 06:54:19 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJ8m3-0003Bm-1Z; Sun, 13 Feb 2022 06:54:19 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nJ8m3-0006fd-0g; Sun, 13 Feb 2022 06:54:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=rKKWYyrHyfC2VnhFEvITyuFC9VXshhoxfBPYjEsrQsI=; b=oqKj2bzgCTRtSSksU7rAm9QfUS
	UAAjCwWXXhMwYmmHY4ShUkb1but8VlB96ee3GZaN6Ed8P56TthQ3ekEZFIwyPi1DVmBFrUBRAKMaW
	ijqL3W55L+S1y9VZTxSDHtrUaEJTpr/eiv6sTLc/Rgj3h5YVmApFQY3USG4KVULke0eo=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168094-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 168094: trouble: blocked/broken/fail/pass
X-Osstest-Failures:
    linux-linus:build-arm64:<job status>:broken:regression
    linux-linus:build-arm64-pvops:<job status>:broken:regression
    linux-linus:build-arm64-xsm:<job status>:broken:regression
    linux-linus:build-arm64-xsm:host-install(4):broken:regression
    linux-linus:build-arm64:host-install(4):broken:regression
    linux-linus:build-arm64-pvops:host-install(4):broken:regression
    linux-linus:test-arm64-arm64-examine:build-check(1):blocked:nonblocking
    linux-linus:build-arm64-libvirt:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=b81b1829e7e39f6cebdf6e4d5484eacbceda8554
X-Osstest-Versions-That:
    linux=f1baf68e1383f6ed93eb9cff2866d46562607a43
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 13 Feb 2022 06:54:19 +0000

flight 168094 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168094/

Failures and problems with tests :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-arm64                     <job status>                 broken
 build-arm64-pvops               <job status>                 broken
 build-arm64-xsm                 <job status>                 broken
 build-arm64-xsm               4 host-install(4)        broken REGR. vs. 168080
 build-arm64                   4 host-install(4)        broken REGR. vs. 168080
 build-arm64-pvops             4 host-install(4)        broken REGR. vs. 168080

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-examine      1 build-check(1)               blocked  n/a
 build-arm64-libvirt           1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl           1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit1   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit2   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-seattle   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-thunderx  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-vhd       1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-xsm       1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168080
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168080
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168080
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168080
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168080
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail like 168080
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168080
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168080
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168080
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                b81b1829e7e39f6cebdf6e4d5484eacbceda8554
baseline version:
 linux                f1baf68e1383f6ed93eb9cff2866d46562607a43

Last test of basis   168080  2022-02-11 00:09:22 Z    2 days
Failing since        168086  2022-02-11 20:11:19 Z    1 days    4 attempts
Testing same since   168094  2022-02-12 21:42:38 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Aaron Liu <aaron.liu@amd.com>
  Adam Ford <aford173@gmail.com>
  Al Cooper <alcooperx@gmail.com>
  Alex Deucher <alexander.deucher@amd.com>
  Alexander Egorenkov <egorenar@linux.ibm.com>
  Alexander Gordeev <agordeev@linux.ibm.com>
  Alexander Stein <alexander.stein@ew.tq-group.com>
  Alexandre Ghiti <alexandre.ghiti@canonical.com>
  Alim Akhtar <alim.akhtar@samsung.com>
  Alviro Iskandar Setiawan <alviro.iskandar@gmail.com>
  Ammar Faizi <ammarfaizi2@gnuweeb.org>
  Andreas Gruenbacher <agruenba@redhat.com>
  Andrew Morton <akpm@linux-foundation.org>
  Andrey Konovalov <andreyknvl@gmail.com>
  Andrzej Pietrasiewicz <andrzej.p@collabora.com>
  Andy Shevchenko <andriy.shevchenko@linux.intel.com>
  Arnd Bergmann <arnd@arndb.de>
  Aswath Govindraju <a-govindraju@ti.com>
  Aurelien Jarno <aurelien@aurel32.net>
  Bartosz Golaszewski <brgl@bgdev.pl>
  Bean Huo <beanhuo@micron.com>
  Benjamin Gaignard <benjamin.gaignard@collabora.com>
  Bjorn Helgaas <bhelgaas@google.com>
  Bob Peterson <rpeterso@redhat.com>
  Brian Johannesmeyer <bjohannesmeyer@gmail.com>
  Brian Norris <briannorris@chromium.org>
  Cai Huoqing <cai.huoqing@linux.dev>
  Cameron Williams <cang1@live.co.uk>
  Catalin Marinas <catalin.marinas@arm.com>
  Changbin Du <changbin.du@gmail.com>
  Chia-Wei Wang <chiawei_wang@aspeedtech.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Borntraeger <borntraeger@linux.ibm.com>
  Christian Hewitt <christianshewitt@gmail.com>
  Christian König <christian.koenig@amd.com>
  Christoph Hellwig <hch@lst.de>
  Christoph Niedermaier <cniedermaier@dh-electronics.com>
  Christophe JAILLET <christophe.jaillet@wanadoo.fr>
  Chunfeng Yun <chunfeng.yun@mediatek.com>
  Damien Le Moal <damien.lemoal@opensource.wdc.com>
  Dan Carpenter <dan.carpenter@oracle.com>
  Daniel Bristot de Oliveira <bristot@kernel.org>
  Daniel Stone <daniels@collabora.com>
  Daniel Vetter <daniel.vetter@ffwll.ch>
  Daniel Vetter <daniel.vetter@intel.com>
  Daniel Wheeler <daniel.wheeler@amd.com>
  Dave Airlie <airlied@redhat.com>
  Dave Stevenson <dave.stevenson@raspberrypi.com>
  David Hildenbrand <david@redhat.com>
  David Rientjes <rientjes@google.com>
  Dinh Nguyen <dinguyen@kernel.org>
  Dmytro Laktyushkin <Dmytro.Laktyushkin@amd.com>
  Dongjin Kim <tobetter@gmail.com>
  Fabio Estevam <festevam@gmail.com>
  Fabio M. De Francesco <fmdefrancesco@gmail.com>
  Fabrice Gasnier <fabrice.gasnier@foss.st.com>
  Florian Fainelli <f.fainelli@gmail.com>
  Geert Uytterhoeven <geert+renesas@glider.be>
  Geert Uytterhoeven <geert@linux-m68k.org>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>Cc: Dave Airlie <airlied@gmail.com>
  Guido Günther <agx@sigxcpu.org> # Librem 5 (imx8mq) with it's rather picky panel
  Hans de Goede <hdegoede@redhat.com>
  Hector Martin <marcan@marcan.st>
  Heiko Carstens <hca@linux.ibm.com>
  Heiko Stuebner <heiko@sntech.de>
  Helge Deller <deller@gmx.de>
  Ilya Leoshkevich <iii@linux.ibm.com>
  Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
  JaeSang Yoo <js.yoo.5b@gmail.com>
  JaeSang Yoo <jsyoo5b@gmail.com>
  Jakob Koschel <jakobkoschel@gmail.com>
  James Smart <jsmart2021@gmail.com>
  Jan Beulich <jbeulich@suse.com>
  Jan Kara <jack@suse.cz>
  Jani Nikula <jani.nikula@intel.com>
  Jann Horn <jannh@google.com>
  Jarkko Nikula <jarkko.nikula@bitmer.com>
  Jasdeep Dhillon <jdhillon@amd.com>
  Jayesh Choudhary <j-choudhary@ti.com>
  Jens Axboe <axboe@kernel.dk>
  Jens Wiklander <jens.wiklander@linaro.org>
  Jeremy Linton <jeremy.linton@arm.com>
  Jerome Forissier <jerome@forissier.org>
  Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
  Jisheng Zhang <jszhang@kernel.org>
  Joel Stanley <joel@jms.id.au>
  Johan Hovold <johan@kernel.org>
  Jonas Malaco <jonas@protocubo.io>
  Juergen Gross <jgross@suse.com>
  Kai-Heng Feng <kai.heng.feng@canonical.com>
  Kees Cook <keescook@chromium.org>
  Kishon Vijay Abraham I <kishon@ti.com>
  Kosuke Tatsukawa <tatsu-ab1@nec.com>
  Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Linus Walleij <linus.walleij@linaro.org>
  Liu Ying <victor.liu@nxp.com>
  Liu Ying <victor.liu@nxp.com> # RM67191 DSI panel on i.MX8mq EVK
  Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
  Lucas De Marchi <lucas.demarchi@intel.com>
  Lutz Koschorreck <theleks@ko-hh.de>
  Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
  Marek Vasut <marex@denx.de>
  Mario Limonciello <mario.limonciello@amd.com>
  Mark Brown <broonie@kernel.org>
  Martin Blumenstingl <martin.blumenstingl@googlemail.com>
  Martin K. Petersen <martin.petersen@oracle.com>
  Martin Kepplinger <martin.kepplinger@puri.sm>
  Mathias Krause <minipli@grsecurity.net>
  Maxime Ripard <maxime@cerno.tech>
  Mel Gorman <mgorman@suse.de>
  Michael Walle <michael@walle.cc>
  Michal Hocko <mhocko@suse.com>
  Michal Simek <michal.simek@xilinx.com>
  Mike Rapoport <rppt@linux.ibm.com>
  Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>
  Myrtle Shah <gatecat@ds0.me>
  Nathan Chancellor <nathan@kernel.org>
  Neil Armstrong <narmstrong@baylibre.com>
  Neil Armstrong <narmstrong@baylibre.com> # for phy-meson-axg-mipi-dphy.c
  Niklas Cassel <niklas.cassel@wdc.com>
  Nishanth Menon <nm@ti.com>
  Padmanabha Srinivasaiah <treasure4paddy@gmail.com>
  Palmer Dabbelt <palmer@rivosinc.com>
  Pavel Hofman <pavel.hofman@ivitera.com>
  Pawel Dembicki <paweldembicki@gmail.com>
  Peng Liu <liupeng256@huawei.com>
  Philippe Cornu <philippe.cornu@foss.st.com>
  Pingfan Liu <kernelfans@gmail.com>
  Pratham Pratap <quic_ppratap@quicinc.com>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Rafał Miłecki <rafal@milecki.pl>
  Rob Herring <robh@kernel.org>
  Robert Hancock <robert.hancock@calian.com>
  Robin Murphy <robin.murphy@arm.com>
  Roger Pau Monne <roger.pau@citrix.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Roman Gushchin <guro@fb.com>
  Roman Li <Roman.Li@amd.com>
  Rui Salvaterra <rsalvaterra@gmail.com>
  Sagi Grimberg <sagi@grimberg.me>
  Sam Protsenko <semen.protsenko@linaro.org>
  Sam Ravnborg <sam@ravnborg.org>
  Samuel Thibault <samuel.thibault@ens-lyon.org>
  Sascha Hauer <s.hauer@pengutronix.de>
  Sean Anderson <sean.anderson@seco.com>
  Shakeel Butt <shakeelb@google.com>
  Shawn Guo <shawnguo@kernel.org>
  Slark Xiao <slark_xiao@163.com>
  Stefan Wahren <stefan.wahren@i2se.com>
  Stephan Brunner <s.brunner@stephan-brunner.net>
  Steven Rostedt (Google) <rostedt@goodmis.org>
  Sven Peter <sven@svenpeter.dev>
  Sven Schnelle <svens@linux.ibm.com>
  Sylwester Nawrocki <s.nawrocki@samsung.com>
  Szymon Heidrich <szymon.heidrich@gmail.com>
  TATSUKAWA KOSUKE (立川 江介) <tatsu-ab1@nec.com>
  Tejun Heo <tj@kernel.org>
  Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
  Thomas Hellström <thomas.hellstrom@linux.intel.com>
  Thomas Zimmermann <tzimmermann@suse.de>
  Tim Harvey <tharvey@gateworks.com>
  Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
  Tommaso Merciai <tomm.merciai@gmail.com>
  Tony Lindgren <tony@atomide.com>
  Tvrtko Ursulin <tvrtko.ursulin@intel.com>
  Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
  Udipto Goswami <quic_ugoswami@quicinc.com>
  Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
  Vasily Gorbik <gor@linux.ibm.com>
  Vignesh Raghavendra <vigneshr@ti.com>
  Ville Syrjälä <ville.syrjala@linux.intel.com>
  Vineeth Vijayan <vneethv@linux.ibm.com>
  Vinod Koul <vkoul@kernel.org>
  Vlastimil Babka <vbabka@suse.cz>
  Wan Jiabing <wanjiabing@vivo.com>
  Yang Shi <shy828301@gmail.com>
  Yang Wang <KevinYang.Wang@amd.com>
  Ye Guojin <ye.guojin@zte.com.cn>
  Yizhuo Zhai <yzhai003@ucr.edu>
  Zhan Liu <Zhan.Liu@amd.com>
  Zoltán Böszörményi <zboszor@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              broken  
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  broken  
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          blocked 
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            broken  
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          blocked 
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      blocked 
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  blocked 
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  blocked 
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     blocked 
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 blocked 
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      blocked 
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary

broken-job build-arm64 broken
broken-job build-arm64-pvops broken
broken-job build-arm64-xsm broken
broken-step build-arm64-xsm host-install(4)
broken-step build-arm64 host-install(4)
broken-step build-arm64-pvops host-install(4)

Not pushing.

(No revision log; it would be 4657 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Feb 13 09:48:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 13 Feb 2022 09:48:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270939.465261 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJBUS-0003TB-Eb; Sun, 13 Feb 2022 09:48:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270939.465261; Sun, 13 Feb 2022 09:48:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJBUS-0003T4-BT; Sun, 13 Feb 2022 09:48:20 +0000
Received: by outflank-mailman (input) for mailman id 270939;
 Sun, 13 Feb 2022 09:48:18 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJBUQ-0003Su-S9; Sun, 13 Feb 2022 09:48:18 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJBUQ-0005gW-Pk; Sun, 13 Feb 2022 09:48:18 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJBUQ-0004JW-E0; Sun, 13 Feb 2022 09:48:18 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nJBUQ-0001ef-DW; Sun, 13 Feb 2022 09:48:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=D6Psc2tIoWJIHdmnAlqusRCZ7+PUuZjOBNsIyoiidsA=; b=eufz3ur0vgL0RfXqh5UJnJUlG0
	Hpywka83KkbxUDJstjHELIbxto1BXlVY5h/66V4w1VDANXlhxShRGqejQEHvZDOe8oh0M4gq83xIs
	SsGafZkD94UeOOHtsvtEpyx+hi12iUvf1mu7frVJvtervkAVXPCY8OkBdcL30+tIG0mI=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168100-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-coverity test] 168100: all pass - PUSHED
X-Osstest-Versions-This:
    xen=87319afb96973213ec0a76270d93696f3b8d6743
X-Osstest-Versions-That:
    xen=52ce1c97844db213de01c5300eaaa8cf101a285f
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 13 Feb 2022 09:48:18 +0000

flight 168100 xen-unstable-coverity real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168100/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 xen                  87319afb96973213ec0a76270d93696f3b8d6743
baseline version:
 xen                  52ce1c97844db213de01c5300eaaa8cf101a285f

Last test of basis   168068  2022-02-09 09:21:03 Z    4 days
Testing same since   168100  2022-02-13 09:18:29 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Volodymyr Babchuk <volodymyr_babchuk@epam.com>

jobs:
 coverity-amd64                                               pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   52ce1c9784..87319afb96  87319afb96973213ec0a76270d93696f3b8d6743 -> coverity-tested/smoke


From xen-devel-bounces@lists.xenproject.org Sun Feb 13 10:06:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 13 Feb 2022 10:06:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270950.465273 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJBmM-0005rN-2Z; Sun, 13 Feb 2022 10:06:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270950.465273; Sun, 13 Feb 2022 10:06:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJBmL-0005rG-VN; Sun, 13 Feb 2022 10:06:49 +0000
Received: by outflank-mailman (input) for mailman id 270950;
 Sun, 13 Feb 2022 10:06:48 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJBmK-0005r6-Pt; Sun, 13 Feb 2022 10:06:48 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJBmK-00064h-Lo; Sun, 13 Feb 2022 10:06:48 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJBmK-0005Jx-9c; Sun, 13 Feb 2022 10:06:48 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nJBmK-000600-9A; Sun, 13 Feb 2022 10:06:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ibhMAC9lk+1COIAxGJ4ChwTbN0uE1GFSnfLpHodiDqU=; b=R7IP0EmMcofQ1z+3GCy4h1BN3+
	Iywa66SuUlz3hji2Lv4p/RG7GCc5jfS4ZdPucKOPiyxxx/fOgIETo/uRcq9rscg+lWZl1mHaihzxr
	2qRrvm0jShfmLJoRHQZ2JTedqLIrl1FxWCxAp4wz6xXrJciegWkhhEbiRIkcpmRXpQdA=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168095-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 168095: trouble: blocked/broken/fail/pass
X-Osstest-Failures:
    qemu-mainline:build-arm64:<job status>:broken:regression
    qemu-mainline:build-arm64-pvops:<job status>:broken:regression
    qemu-mainline:build-arm64-xsm:<job status>:broken:regression
    qemu-mainline:build-arm64-pvops:host-install(4):broken:regression
    qemu-mainline:build-arm64-xsm:host-install(4):broken:regression
    qemu-mainline:build-arm64:host-install(4):broken:regression
    qemu-mainline:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-arm64-arm64-xl:build-check(1):blocked:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:build-arm64-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=da36afa2d8dc9c778292ff172083caba9558b4fa
X-Osstest-Versions-That:
    qemuu=0a301624c2f4ced3331ffd5bce85b4274fe132af
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 13 Feb 2022 10:06:48 +0000

flight 168095 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168095/

Failures and problems with tests :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-arm64                     <job status>                 broken
 build-arm64-pvops               <job status>                 broken
 build-arm64-xsm                 <job status>                 broken
 build-arm64-pvops             4 host-install(4)        broken REGR. vs. 168059
 build-arm64-xsm               4 host-install(4)        broken REGR. vs. 168059
 build-arm64                   4 host-install(4)        broken REGR. vs. 168059

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl           1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit1   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit2   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-seattle   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-thunderx  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-vhd       1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-xsm       1 build-check(1)               blocked  n/a
 build-arm64-libvirt           1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168059
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168059
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168059
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168059
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168059
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168059
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168059
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168059
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                da36afa2d8dc9c778292ff172083caba9558b4fa
baseline version:
 qemuu                0a301624c2f4ced3331ffd5bce85b4274fe132af

Last test of basis   168059  2022-02-08 15:36:56 Z    4 days
Testing same since   168095  2022-02-12 22:37:11 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alex Bennée <alex.bennee@linaro.org>
  Cédric Le Goater <clg@kaod.org>
  Ivanov Arkady <arkadiy.ivanov@ispras.ru>
  Michael Tokarev <mjt@tls.msk.ru>
  Peter Maydell <peter.maydell@linaro.org>
  Philippe Mathieu-Daudé <f4bug@amsat.org>
  Stefan Hajnoczi <stefanha@redhat.com>
  Thomas Huth <thuth@redhat.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              broken  
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  broken  
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          blocked 
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            broken  
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          blocked 
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      blocked 
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  blocked 
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  blocked 
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 blocked 
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      blocked 
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary

broken-job build-arm64 broken
broken-job build-arm64-pvops broken
broken-job build-arm64-xsm broken
broken-step build-arm64-pvops host-install(4)
broken-step build-arm64-xsm host-install(4)
broken-step build-arm64 host-install(4)

Not pushing.

(No revision log; it would be 585 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Feb 13 12:19:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 13 Feb 2022 12:19:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270964.465284 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJDqo-00019H-OV; Sun, 13 Feb 2022 12:19:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270964.465284; Sun, 13 Feb 2022 12:19:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJDqo-00019A-LH; Sun, 13 Feb 2022 12:19:34 +0000
Received: by outflank-mailman (input) for mailman id 270964;
 Sun, 13 Feb 2022 12:19:32 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nJDqm-000194-K5
 for xen-devel@lists.xenproject.org; Sun, 13 Feb 2022 12:19:32 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nJDqm-0008Lz-Ac; Sun, 13 Feb 2022 12:19:32 +0000
Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nJDqm-0006iN-4n; Sun, 13 Feb 2022 12:19:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=H1OhpEfaf7zVs6t7T7nrliV14lWX9YMX8nzaHgAZefg=; b=NaqPkwwbflAohkET9s8XEPdZSg
	JZ9fdwqqTNYdr7RuO6ZBwb1uINDGvdkwH5Ug6L8o19UcXo+XZKiCzHSkFuIM2wcO4JwuLTAoihv2v
	5a8G8qxHV9SpllAQT9/zmWng0yPU+RnPkmd2PZMLstQMQOmMHzS62er7TFWwBPxxzxw4=;
Message-ID: <1599e2f3-0a34-020a-dd42-5ba87dad555d@xen.org>
Date: Sun, 13 Feb 2022 12:19:29 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.1
Subject: Re: [XEN v8 2/2] xen/arm64: io: Support instructions (for which ISS
 is not valid) on emulated MMIO region using MMIO/ioreq handler
To: Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>,
 xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com,
 bertrand.marquis@arm.com, Ayan Kumar Halder <ayankuma@xilinx.com>
References: <20220212233433.46018-1-ayankuma@xilinx.com>
 <20220212233433.46018-3-ayankuma@xilinx.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220212233433.46018-3-ayankuma@xilinx.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 12/02/2022 23:34, Ayan Kumar Halder wrote:
> 
>   xen/arch/arm/arm32/traps.c        |  7 +++
>   xen/arch/arm/arm64/traps.c        | 47 +++++++++++++++
>   xen/arch/arm/decode.c             |  1 +
>   xen/arch/arm/include/asm/domain.h |  4 ++
>   xen/arch/arm/include/asm/mmio.h   | 15 ++++-
>   xen/arch/arm/include/asm/traps.h  |  2 +
>   xen/arch/arm/io.c                 | 98 ++++++++++++++++++++-----------
>   xen/arch/arm/ioreq.c              |  7 ++-
>   xen/arch/arm/traps.c              | 80 +++++++++++++++++++++----
>   xen/arch/x86/include/asm/ioreq.h  |  3 +

This change technically needs an ack from the x86 maintainers. And...

>   xen/include/xen/sched.h           |  2 +

this one for anyone from THE REST (Stefano and I are part of it). Please 
use scripts/add_maintainers.pl to automatically add the relevant 
maintainers in CC.

>   11 files changed, 217 insertions(+), 49 deletions(-)
> 
> diff --git a/xen/arch/arm/arm32/traps.c b/xen/arch/arm/arm32/traps.c
> index 9c9790a6d1..70c6238196 100644
> --- a/xen/arch/arm/arm32/traps.c
> +++ b/xen/arch/arm/arm32/traps.c
> @@ -18,9 +18,11 @@
>   
>   #include <xen/lib.h>
>   #include <xen/kernel.h>
> +#include <xen/sched.h>
>   
>   #include <public/xen.h>
>   
> +#include <asm/mmio.h>
>   #include <asm/processor.h>
>   #include <asm/traps.h>
>   
> @@ -82,6 +84,11 @@ void do_trap_data_abort(struct cpu_user_regs *regs)
>           do_unexpected_trap("Data Abort", regs);
>   }
>   
> +void post_increment_register(const struct instr_details *instr)
> +{
> +    domain_crash(current->domain);


Please add a comment explaning why this is resulting to a domain crash. 
AFAICT, this is because this should not be reachable (yet) for 32-bit.


> +}
> +
>   /*
>    * Local variables:
>    * mode: C
> diff --git a/xen/arch/arm/arm64/traps.c b/xen/arch/arm/arm64/traps.c
> index 9113a15c7a..a6766689b3 100644
> --- a/xen/arch/arm/arm64/traps.c
> +++ b/xen/arch/arm/arm64/traps.c
> @@ -23,6 +23,7 @@
>   #include <asm/processor.h>
>   
>   #include <public/xen.h>
> +#include <xen/sched.h>

The headers should ordered so <xen/*.h> are first, then <asm/*.h>, then 
<public/*.h>. They should then be ordered alphabetically within each of 
the category.

So, this new header should be included right after <xen/lib.h>

[...]

> diff --git a/xen/arch/arm/include/asm/mmio.h b/xen/arch/arm/include/asm/mmio.h
> index 3354d9c635..745130b7fe 100644
> --- a/xen/arch/arm/include/asm/mmio.h
> +++ b/xen/arch/arm/include/asm/mmio.h
> @@ -26,12 +26,22 @@
>   
>   #define MAX_IO_HANDLER  16
>   
> +enum instr_decode_state
> +{
> +    INSTR_ERROR,                    /* Error encountered while decoding instr */
> +    INSTR_VALID,                    /* ISS is valid, so no need to decode */
> +    INSTR_LDR_STR_POSTINDEXING,     /* Instruction is decoded successfully.
> +                                       It is ldr/str post indexing */

Coding style: multiple-line comments for Xen should be:

/*
  * ...
  * ...
  */

In this case, I would simply move the comment on top.

[...]

> diff --git a/xen/arch/arm/io.c b/xen/arch/arm/io.c
> index a289d393f9..203466b869 100644
> --- a/xen/arch/arm/io.c
> +++ b/xen/arch/arm/io.c
> @@ -95,57 +95,87 @@ static const struct mmio_handler *find_mmio_handler(struct domain *d,
>       return handler;
>   }
>   
> +void try_decode_instruction(const struct cpu_user_regs *regs,
> +                            mmio_info_t *info)
> +{
> +    int rc;
> +
> +    /*
> +     * Erratum 766422: Thumb store translation fault to Hypervisor may
> +     * not have correct HSR Rt value.
> +     */
> +    if ( check_workaround_766422() && (regs->cpsr & PSR_THUMB) &&
> +         info->dabt.write )
> +    {
> +        rc = decode_instruction(regs, info);
> +        if ( rc )
> +        {
> +            gprintk(XENLOG_DEBUG, "Unable to decode instruction\n");
> +            info->dabt_instr.state = INSTR_ERROR;
> +            return;
> +        }
> +    }

At the moment, the errata would only be handled when the ISS is valid. 
Now, you are moving it before we know if it is valid. Can you explain why?

[...]

>   enum io_state try_handle_mmio(struct cpu_user_regs *regs,
> -                              const union hsr hsr,
> -                              paddr_t gpa)
> +                              mmio_info_t *info)
>   {
>       struct vcpu *v = current;
>       const struct mmio_handler *handler = NULL;
> -    const struct hsr_dabt dabt = hsr.dabt;
> -    mmio_info_t info = {
> -        .gpa = gpa,
> -        .dabt = dabt
> -    };
> +    int rc;
>   
> -    ASSERT(hsr.ec == HSR_EC_DATA_ABORT_LOWER_EL);
> +    ASSERT(info->dabt.ec == HSR_EC_DATA_ABORT_LOWER_EL);
>   
> -    handler = find_mmio_handler(v->domain, info.gpa);
> +    handler = find_mmio_handler(v->domain, info->gpa);
>       if ( !handler )
>       {
> -        int rc;
> -
> -        rc = try_fwd_ioserv(regs, v, &info);
> +        rc = try_fwd_ioserv(regs, v, info);
>           if ( rc == IO_HANDLED )
>               return handle_ioserv(regs, v);
>   
>           return rc;
>       }
>   
> -    /* All the instructions used on emulated MMIO region should be valid */
> -    if ( !dabt.valid )
> -        return IO_ABORT;
> -

AFAIU, the assumption is now try_handle_mmio() and try_fwd_ioserv() will 
always be called when dabt.valid == 1. I think it would still be good to 
check that assumption.

So I would move the check at the beginning of try_handle_mmio() and add 
an ASSERT_UNREACHABLE in the if(). Something like:

if ( !dabt.valid )
{
     ASSERT_UNREACHABLE();
     return IO_ABORT;
}

>       /*
> -     * Erratum 766422: Thumb store translation fault to Hypervisor may
> -     * not have correct HSR Rt value.
> +     * At this point, we know that the instruction is either valid or has been
> +     * decoded successfully. Thus, Xen should be allowed to execute the
> +     * instruction on the emulated MMIO region.
>        */
> -    if ( check_workaround_766422() && (regs->cpsr & PSR_THUMB) &&
> -         dabt.write )
> -    {
> -        int rc;
> -
> -        rc = decode_instruction(regs, &info);
> -        if ( rc )
> -        {
> -            gprintk(XENLOG_DEBUG, "Unable to decode instruction\n");
> -            return IO_ABORT;
> -        }
> -    }
> -
> -    if ( info.dabt.write )
> -        return handle_write(handler, v, &info);
> +    if ( info->dabt.write )
> +        rc = handle_write(handler, v, info);
>       else
> -        return handle_read(handler, v, &info);
> +        rc = handle_read(handler, v, info);
> +
> +    return rc;

It looks like there are some left-over of the previous approach. It is 
fine to return directly from each branch.


>   }
>   
>   void register_mmio_handler(struct domain *d,
> diff --git a/xen/arch/arm/ioreq.c b/xen/arch/arm/ioreq.c
> index 308650b400..3c0a935ccf 100644
> --- a/xen/arch/arm/ioreq.c
> +++ b/xen/arch/arm/ioreq.c
> @@ -47,6 +47,7 @@ enum io_state try_fwd_ioserv(struct cpu_user_regs *regs,
>                                struct vcpu *v, mmio_info_t *info)
>   {
>       struct vcpu_io *vio = &v->io;
> +    struct dabt_instr instr = info->dabt_instr;
>       ioreq_t p = {
>           .type = IOREQ_TYPE_COPY,
>           .addr = info->gpa,
> @@ -76,10 +77,8 @@ enum io_state try_fwd_ioserv(struct cpu_user_regs *regs,
>       if ( !s )
>           return IO_UNHANDLED;
>   
> -    if ( !info->dabt.valid )
> -        return IO_ABORT;
> -

For this one, I would switch to ASSERT(dabt.valid);

>       vio->req = p;
> +    vio->info.dabt_instr = instr;
>   
>       rc = ioreq_send(s, &p, 0);
>       if ( rc != IO_RETRY || v->domain->is_shutting_down )
> @@ -95,6 +94,7 @@ enum io_state try_fwd_ioserv(struct cpu_user_regs *regs,
>   bool arch_ioreq_complete_mmio(void)
>   {
>       struct vcpu *v = current;
> +    struct instr_details dabt_instr = v->io.info.dabt_instr;
>       struct cpu_user_regs *regs = guest_cpu_user_regs();
>       const union hsr hsr = { .bits = regs->hsr };
>   
> @@ -106,6 +106,7 @@ bool arch_ioreq_complete_mmio(void)
>   
>       if ( handle_ioserv(regs, v) == IO_HANDLED )
>       {
> +        post_increment_register(&dabt_instr);
>           advance_pc(regs, hsr);
>           return true;
>       }
> diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c
> index 9339d12f58..455e51cdbe 100644
> --- a/xen/arch/arm/traps.c
> +++ b/xen/arch/arm/traps.c
> @@ -1893,6 +1893,21 @@ static bool try_map_mmio(gfn_t gfn)
>       return !map_regions_p2mt(d, gfn, 1, mfn, p2m_mmio_direct_c);
>   }
>   
> +static inline bool check_p2m(bool is_data, paddr_t gpa)
> +{
> +    /*
> +     * First check if the translation fault can be resolved by the P2M subsystem.
> +     * If that's the case nothing else to do.
> +     */
> +    if ( p2m_resolve_translation_fault(current->domain,gaddr_to_gfn(gpa)) )

Coding style: missing space before and after the comma.

> +        return true;
> +
> +    if ( is_data && try_map_mmio(gaddr_to_gfn(gpa)) )
> +        return true;
> +
> +    return false;
> +}
> +
>   static void do_trap_stage2_abort_guest(struct cpu_user_regs *regs,
>                                          const union hsr hsr)
>   {
> @@ -1906,6 +1921,7 @@ static void do_trap_stage2_abort_guest(struct cpu_user_regs *regs,
>       paddr_t gpa;
>       uint8_t fsc = xabt.fsc & ~FSC_LL_MASK;
>       bool is_data = (hsr.ec == HSR_EC_DATA_ABORT_LOWER_EL);
> +    mmio_info_t info;
>   
>       /*
>        * If this bit has been set, it means that this stage-2 abort is caused
> @@ -1959,6 +1975,25 @@ static void do_trap_stage2_abort_guest(struct cpu_user_regs *regs,
>           return;
>       }
>       case FSC_FLT_TRANS:
> +    {
> +        info.gpa = gpa;
> +        info.dabt = hsr.dabt;
> +
> +        /* Check that the ISS is invalid and it is not data abort. */

This comment looks a bit pointless. You are writing literally what the 
check is doing. But you don't really explain why. I think you want to 
move some of the commint with the if here.

However,...

> +        if ( !hsr.dabt.valid && !is_data )

... this code can be reached by Instruction Abort and Data Abort. So you 
can't use hsr.dabt. Instead, you should use xabt (or check is_data first).

If you use xabt, you will notice that the 'valid' bit is not existent
because the instruction syndrome only exists for data abort.

But then, I don't understand why this is only restricted to instruction 
abort. As I wrote in the previous versions and on IRC, there are valid 
use cases to trap a data abort with invalid syndrome. Below...


> +        {
> +
> +            /*
> +             * Assumption :- Most of the times when we get a translation fault
> +             * and the ISS is invalid, the underlying cause is that the page
> +             * tables have not been set up correctly.
> +             */
> +            if ( check_p2m(is_data, gpa) )
> +                return;
> +            else
> +                goto inject_abt;
> +        }
> +
>           /*
>            * Attempt first to emulate the MMIO as the data abort will
>            * likely happen in an emulated region.
> @@ -1967,13 +2002,45 @@ static void do_trap_stage2_abort_guest(struct cpu_user_regs *regs,
>            */
>           if ( is_data )
>           {
> -            enum io_state state = try_handle_mmio(regs, hsr, gpa);
> +            enum io_state state;
> +
> +            try_decode_instruction(regs, &info);
> +
> +            /*
> +             * If Xen could not decode the instruction for any reason, then it
> +             * should ask the caller to abort the guest.
> +             */
> +            if ( info.dabt_instr.state == INSTR_ERROR )
> +                goto inject_abt;

... this will inject a data abort to the guest when we can't decode. 
This is not what we want. We should check whether this is a P2M 
translation fault or we need to map an MMIO region.

In pseudo-code, this would look like:

if ( !is_data || hsr.dabt.valid )
{
     if ( check_p2m() )
       return;


     if ( !is_data )
        goto inject_dabt;

     decode_instruction();
     if ( !dabt.invalid )
       goto inject_dabt;
}

try_handle_mmio();

if ( instruction was not decoded )
   check_p2m();

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Sun Feb 13 12:57:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 13 Feb 2022 12:57:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270971.465295 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJERf-0005BN-La; Sun, 13 Feb 2022 12:57:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270971.465295; Sun, 13 Feb 2022 12:57:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJERf-0005BG-Hv; Sun, 13 Feb 2022 12:57:39 +0000
Received: by outflank-mailman (input) for mailman id 270971;
 Sun, 13 Feb 2022 12:57:38 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJERe-0005B6-Rb; Sun, 13 Feb 2022 12:57:38 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJERe-0000aJ-Oo; Sun, 13 Feb 2022 12:57:38 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJERe-0006Oh-9c; Sun, 13 Feb 2022 12:57:38 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nJERe-0003ej-99; Sun, 13 Feb 2022 12:57:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=HSCK0FoLzI2qXeJOF8iCP9KB229eBYRkfdSF26AIDPo=; b=6fK9CheW305hXj4fHiSRmAIQ8E
	Q6BODloPmUzTttYf5Cw5LC6PCf4KQjs9o1cUnoHfToVCcYvnSFpB0qI7/aX0ep5rm2vX9pm8Z6R7a
	9j8Hzkg0QB2QC36HViBKjUon8D8Y/GqOAAWfOhyZXVvLfiiDJhr64gPZ5gexfPN40lzQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168098-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 168098: regressions - trouble: blocked/broken/fail/pass
X-Osstest-Failures:
    libvirt:build-arm64:<job status>:broken:regression
    libvirt:build-arm64-pvops:<job status>:broken:regression
    libvirt:build-arm64-xsm:<job status>:broken:regression
    libvirt:build-arm64-pvops:host-install(4):broken:regression
    libvirt:build-arm64:host-install(4):broken:regression
    libvirt:build-arm64-xsm:host-install(4):broken:regression
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=6ccafcb53e2bdf50695c151cf768a36fc5697bab
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 13 Feb 2022 12:57:38 +0000

flight 168098 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168098/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-arm64                     <job status>                 broken
 build-arm64-pvops               <job status>                 broken
 build-arm64-xsm                 <job status>                 broken
 build-arm64-pvops             4 host-install(4)        broken REGR. vs. 151777
 build-arm64                   4 host-install(4)        broken REGR. vs. 151777
 build-arm64-xsm               4 host-install(4)        broken REGR. vs. 151777
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 build-arm64-libvirt           1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              6ccafcb53e2bdf50695c151cf768a36fc5697bab
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  583 days
Failing since        151818  2020-07-11 04:18:52 Z  582 days  564 attempts
Testing same since   168090  2022-02-12 04:18:54 Z    1 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brad Laue <brad@brad-x.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Christophe Fergeau <cfergeau@redhat.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Divya Garg <divya.garg@nutanix.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Emilio Herrera <ehespinosa57@gmail.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Ivan Teterevkov <ivan.teterevkov@nutanix.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jing Qi <jinqi@redhat.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Lubomir Rintel <lkundrak@v3.sk>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nicolas Lécureuil <neoclust@mageia.org>
  Nicolas Lécureuil <nicolas.lecureuil@siveo.net>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Rohit Kumar <rohit.kumar3@nutanix.com>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  shenjiatong <yshxxsjt715@gmail.com>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tu Qiang <tu.qiang35@zte.com.cn>
  Tuguoyi <tu.guoyi@h3c.com>
  tuqiang <tu.qiang35@zte.com.cn>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Vineeth Pillai <viremana@linux.microsoft.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yasuhiko Kamata <belphegor@belbel.or.jp>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              broken  
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  broken  
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          blocked 
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            broken  
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary

broken-job build-arm64 broken
broken-job build-arm64-pvops broken
broken-job build-arm64-xsm broken
broken-step build-arm64-pvops host-install(4)
broken-step build-arm64 host-install(4)
broken-step build-arm64-xsm host-install(4)

Not pushing.

(No revision log; it would be 97411 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Feb 13 14:48:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 13 Feb 2022 14:48:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270984.465305 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJGAW-0007Cf-Oa; Sun, 13 Feb 2022 14:48:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270984.465305; Sun, 13 Feb 2022 14:48:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJGAW-0007CY-Ld; Sun, 13 Feb 2022 14:48:04 +0000
Received: by outflank-mailman (input) for mailman id 270984;
 Sun, 13 Feb 2022 14:48:02 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJGAU-0007CO-S3; Sun, 13 Feb 2022 14:48:02 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJGAU-0002Xe-NO; Sun, 13 Feb 2022 14:48:02 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJGAU-0003Hp-8U; Sun, 13 Feb 2022 14:48:02 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nJGAU-0004tn-80; Sun, 13 Feb 2022 14:48:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=JcpLnz2CFUbr4aHu/FwviFNWoOBy7KMgcfyCYltlpOU=; b=VEs9SAeGN5fKnARD3YkraV2qVU
	llVbzUrGKFazBKv/yEDGMmcEv5w+sip8Y7p6mwsrpj8dUPE5jGfB8dqZgVjP/6Hd/2+ydYcu8ywCS
	tZjKwi6ORl/+HY7pP/QGPMp1+Xma4UTDBqIQQ1rUXIfdJ5xrML4SqybzUXOthOybR3ig=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168096-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 168096: trouble: blocked/broken/fail/pass
X-Osstest-Failures:
    xen-unstable:build-arm64:<job status>:broken:regression
    xen-unstable:build-arm64-pvops:<job status>:broken:regression
    xen-unstable:build-arm64-xsm:<job status>:broken:regression
    xen-unstable:build-arm64-pvops:host-install(4):broken:regression
    xen-unstable:build-arm64-xsm:host-install(4):broken:regression
    xen-unstable:build-arm64:host-install(4):broken:regression
    xen-unstable:test-arm64-arm64-examine:build-check(1):blocked:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    xen-unstable:test-arm64-arm64-xl:build-check(1):blocked:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking
    xen-unstable:build-arm64-libvirt:build-check(1):blocked:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=87319afb96973213ec0a76270d93696f3b8d6743
X-Osstest-Versions-That:
    xen=87319afb96973213ec0a76270d93696f3b8d6743
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 13 Feb 2022 14:48:02 +0000

flight 168096 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168096/

Failures and problems with tests :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-arm64                     <job status>                 broken
 build-arm64-pvops               <job status>                 broken
 build-arm64-xsm                 <job status>                 broken
 build-arm64-pvops             4 host-install(4)        broken REGR. vs. 168081
 build-arm64-xsm               4 host-install(4)        broken REGR. vs. 168081
 build-arm64                   4 host-install(4)        broken REGR. vs. 168081

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-examine      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl           1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit1   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit2   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-seattle   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-thunderx  1 build-check(1)               blocked  n/a
 build-arm64-libvirt           1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-vhd       1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-xsm       1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168088
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168088
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168088
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168088
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168088
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168088
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168088
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168088
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168088
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168088
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168088
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168088
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  87319afb96973213ec0a76270d93696f3b8d6743
baseline version:
 xen                  87319afb96973213ec0a76270d93696f3b8d6743

Last test of basis   168096  2022-02-13 01:53:06 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              broken  
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  broken  
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          blocked 
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            broken  
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          blocked 
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      blocked 
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  blocked 
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  blocked 
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     blocked 
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 blocked 
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      blocked 
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary

broken-job build-arm64 broken
broken-job build-arm64-pvops broken
broken-job build-arm64-xsm broken
broken-step build-arm64-pvops host-install(4)
broken-step build-arm64-xsm host-install(4)
broken-step build-arm64 host-install(4)

Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Sun Feb 13 16:06:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 13 Feb 2022 16:06:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.270996.465316 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJHOC-0006wy-Jg; Sun, 13 Feb 2022 16:06:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 270996.465316; Sun, 13 Feb 2022 16:06:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJHOC-0006wr-Gh; Sun, 13 Feb 2022 16:06:16 +0000
Received: by outflank-mailman (input) for mailman id 270996;
 Sun, 13 Feb 2022 16:06:14 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nJHOA-0006wl-In
 for xen-devel@lists.xenproject.org; Sun, 13 Feb 2022 16:06:14 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nJHO9-0004QW-6V; Sun, 13 Feb 2022 16:06:13 +0000
Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nJHO8-0006P3-Vk; Sun, 13 Feb 2022 16:06:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=COWVWcQ9dDXZNDzM555CyAyBgWveir0btyJ1U2eFnno=; b=nparCt/mZEJl/SuI3Z61vQhZc5
	NSQkpE/S/T2Ojb5cKR+6anFj9XDfBMey08DtxIHOk8tnwIbl2rm5xZfoS80SFvLzrs0I77Z99b9lq
	exuRVduBs69YWIxJPLq3UNj0zPOV1wstWOAxOf6bfcTzOF1bMFxsmtENAdz2Urtj4OvY=;
Message-ID: <40ec7063-0c59-02d1-90c7-4cfc9791ad27@xen.org>
Date: Sun, 13 Feb 2022 16:06:09 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.1
Subject: Re: [PATCH V5] xen/gnttab: Store frame GFN in struct page_info on Arm
To: Oleksandr <olekstysh@gmail.com>
Cc: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Jan Beulich <jbeulich@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Bob Eshleman <bobbyeshleman@gmail.com>,
 Alistair Francis <alistair.francis@wdc.com>,
 Connor Davis <connojdavis@gmail.com>
References: <1641424268-12968-1-git-send-email-olekstysh@gmail.com>
 <a54213c4-1c68-694e-c130-d95faeef3953@xen.org>
 <78d94e1e-6db4-25c1-adb8-e4bdbfe42774@epam.com>
 <82d8bfe0-cb46-d303-6a60-2324dd76a1f7@xen.org>
 <79fbf83e-d25e-2634-9769-8e07634bfd63@epam.com>
 <a104d3ea-170e-8175-ac04-abfcebb4ae29@xen.org>
 <f9e3ee5b-0811-8317-42c2-61c8cdbfe254@gmail.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <f9e3ee5b-0811-8317-42c2-61c8cdbfe254@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Oleksandr,

On 10/02/2022 16:55, Oleksandr wrote:
> 
> On 10.02.22 11:46, Julien Grall wrote:
>>
>>
>> On 08/02/2022 19:50, Oleksandr Tyshchenko wrote:
>>>
>>> On 08.02.22 13:58, Julien Grall wrote:
>>> Below the diff I have locally:
>>>
>>> diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
>>> index 5646343..90d7563 100644
>>> --- a/xen/arch/arm/p2m.c
>>> +++ b/xen/arch/arm/p2m.c
>>> @@ -1315,11 +1315,32 @@ static inline int p2m_remove_mapping(struct
>>> domain *d,
>>>                                         mfn_t mfn)
>>>    {
>>>        struct p2m_domain *p2m = p2m_get_hostp2m(d);
>>> +    unsigned long i;
>>>        int rc;
>>>
>>>        p2m_write_lock(p2m);
>>> +    for ( i = 0; i < nr; )
>>> +    {
>>> +        unsigned int cur_order;
>>> +        bool valid;
>>> +        mfn_t mfn_return = p2m_get_entry(p2m, gfn_add(start_gfn, i),
>>> NULL, NULL,
>>> +                                         &cur_order, &valid); > +
>>> +        if ( valid &&
>>
>> valid is a copy of the LPAE bit valid. This may be 0 if Xen decided to 
>> clear it (i.e when emulating set/way). Yet the mapping itself is 
>> considered valid from Xen PoV.
>>
>> So you want to replace with a different check (see below).
> 
> 
> Hmm, I got it, so ...
> 
> 
>>
>>
>>> +             (!mfn_valid(mfn) || !mfn_eq(mfn_add(mfn, i), 
>>> mfn_return)) )
>>> +        {
>>> +            rc = -EILSEQ;
>>> +            goto out;
>>> +        }
>>> +
>>> +        i += (1UL << cur_order) -
>>> +             ((gfn_x(start_gfn) + i) & ((1UL << cur_order) - 1));
>>> +    }
>>> +
>>>        rc = p2m_set_entry(p2m, start_gfn, nr, INVALID_MFN,
>>>                           p2m_invalid, p2m_access_rwx);
>>> +
>>> +out:
>>>        p2m_write_unlock(p2m);
>>>
>>>        return rc;
>>>
>>>
>>> Could you please clarify, is it close to what you had in mind? If yes, I
>>> am wondering, don't we need this check to be only executed for xenheap
>>> pages (and, probably, which P2M's entry type in RAM?) rather than for
>>> all pages?
>>
>> From my understanding, for the purpose of this work, we only strictly 
>> need to check that for xenheap pages.
> 
> 
>   ... yes, but ...
> 
> 
>>
>>
>> But I think it would be a good opportunity to harden the P2M code. At 
>> the moment, on Arm, you can remove any mappings you want (even with 
>> the wrong helpers). This lead us to a few issues when mapping were 
>> overriden silently (in particular when building dom0).
>> So I would say we should enforce it for every RAM mapping. 
> 
> 
> ... I think this makes sense, so the proper check in that case, I 
> assume, should contain p2m_is_any_ram() macro:


Correct, p2m_is_any_ram() looks the macro we want to use here.

>> Note that, I would like to see this change in a separate commit. It 
>> will be easier to review.
> 
> 
> ok, I will introduce this check by a separate patch.

Thank you!

[...]

>>> It is going to be a non-protected write to GFN portion of type_info.
>>
>> Well no. You are using a Read-Modify-Write operation on type_info. 
>> This is not atomic and will overwrite any change (if any) done on 
>> other part of the type_info.
> 
> 
> I am confused a bit, to which my comment your comment above belongs (to 
> the diff for page_set_xenheap_gfn() above or to sentence right after it)?
> The "It is going to be a non-protected write to GFN portion of 
> type_info." sentence is related to the diff for alloc_heap_pages() 
> below. Sorry if I didn't separate the comments properly.

Ok. So it will be a write operation, but I still don't understand why 
you think it is just the GFN portion.

The code is using "...type_info = PGT_TYPE_INFO_INITIALIZER". So the 
full 64-bit (assuming arm64) will be modified.

In general, the GFN takes 60 of the 64-bits. So any time you need to 
modify the GFN (or the count_info), you will end up to modify the entire 
of type_info (and vice-versa). If this is becoming we problem (e.g. the 
count_info is actively used) we will need to use cmpxchg() to modify the 
GFN portion.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Sun Feb 13 17:51:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 13 Feb 2022 17:51:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271003.465328 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJJ21-0000Fi-5G; Sun, 13 Feb 2022 17:51:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271003.465328; Sun, 13 Feb 2022 17:51:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJJ21-0000Fb-20; Sun, 13 Feb 2022 17:51:29 +0000
Received: by outflank-mailman (input) for mailman id 271003;
 Sun, 13 Feb 2022 17:51:27 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJJ1z-0000FR-Oa; Sun, 13 Feb 2022 17:51:27 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJJ1z-0006FY-Kr; Sun, 13 Feb 2022 17:51:27 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJJ1z-00036P-65; Sun, 13 Feb 2022 17:51:27 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nJJ1z-0000LV-5f; Sun, 13 Feb 2022 17:51:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=V0ttSZl39qZx4EZqjKZDu7HcbXsdyaJssVojXyLzZJs=; b=CjIowzyJXnlgzUcWRI9dPa/oXC
	83VP/ZTjaOdJePzJoRRCNBBMmlnFZY1CQrNFqAbw7I70D5kw5wKRQBokz66SoQRyjRHtvvzjjUFLj
	2daVjQGs8RiM2Hgv1OWZ51Ou18B1K1sdc6DsW5pJLDIElvTUQymV0wAHHN8aFjCNQsnc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168097-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-5.4 test] 168097: trouble: blocked/broken/fail/pass
X-Osstest-Failures:
    linux-5.4:build-arm64:<job status>:broken:regression
    linux-5.4:build-arm64-pvops:<job status>:broken:regression
    linux-5.4:build-arm64-xsm:<job status>:broken:regression
    linux-5.4:build-arm64-xsm:host-install(4):broken:regression
    linux-5.4:build-arm64-pvops:host-install(4):broken:regression
    linux-5.4:build-arm64:host-install(4):broken:regression
    linux-5.4:test-armhf-armhf-xl-rtds:guest-start:fail:heisenbug
    linux-5.4:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    linux-5.4:test-arm64-arm64-examine:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-xl:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking
    linux-5.4:build-arm64-libvirt:build-check(1):blocked:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=52871671099d1bb3fca5ed076029e4b937bfc053
X-Osstest-Versions-That:
    linux=76fd334f07cc11e047c2237a19b2cf8b1f653ba2
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 13 Feb 2022 17:51:27 +0000

flight 168097 linux-5.4 real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168097/

Failures and problems with tests :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-arm64                     <job status>                 broken
 build-arm64-pvops               <job status>                 broken
 build-arm64-xsm                 <job status>                 broken
 build-arm64-xsm               4 host-install(4)        broken REGR. vs. 168060
 build-arm64-pvops             4 host-install(4)        broken REGR. vs. 168060
 build-arm64                   4 host-install(4)        broken REGR. vs. 168060

Tests which are failing intermittently (not blocking):
 test-armhf-armhf-xl-rtds     14 guest-start                fail pass in 168093
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 168093

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-examine      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl           1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit1   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit2   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-seattle   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-thunderx  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-vhd       1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-xsm       1 build-check(1)               blocked  n/a
 build-arm64-libvirt           1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-rtds    15 migrate-support-check fail in 168093 never pass
 test-armhf-armhf-xl-rtds 16 saverestore-support-check fail in 168093 never pass
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168060
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168060
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168060
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168060
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168060
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168060
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168060
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168060
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168060
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168060
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168060
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168060
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                52871671099d1bb3fca5ed076029e4b937bfc053
baseline version:
 linux                76fd334f07cc11e047c2237a19b2cf8b1f653ba2

Last test of basis   168060  2022-02-08 17:43:16 Z    5 days
Testing same since   168084  2022-02-11 08:43:38 Z    2 days    6 attempts

------------------------------------------------------------
People who touched revisions under test:
  Florian Fainelli <f.fainelli@gmail.com>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Guenter Roeck <linux@roeck-us.net>
  Jon Hunter <jonathanh@nvidia.com>
  Jon Maloy <jmaloy@redhat.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Linux Kernel Functional Testing <lkft@linaro.org>
  Shuah Khan <skhan@linuxfoundation.org>
  Slade Watkins <slade@sladewatkins.com>
  Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
  Ulf Hansson <ulf.hansson@linaro.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              broken  
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  broken  
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          blocked 
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            broken  
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          blocked 
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      blocked 
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  blocked 
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  blocked 
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     blocked 
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 blocked 
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      blocked 
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary

broken-job build-arm64 broken
broken-job build-arm64-pvops broken
broken-job build-arm64-xsm broken
broken-step build-arm64-xsm host-install(4)
broken-step build-arm64-pvops host-install(4)
broken-step build-arm64 host-install(4)
broken-job build-arm64-pvops broken
broken-job build-arm64-xsm broken
broken-job build-arm64 broken

Not pushing.

------------------------------------------------------------
commit 52871671099d1bb3fca5ed076029e4b937bfc053
Author: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date:   Fri Feb 11 09:07:52 2022 +0100

    Linux 5.4.179
    
    Link: https://lore.kernel.org/r/20220209191248.688351316@linuxfoundation.org
    Tested-by: Shuah Khan <skhan@linuxfoundation.org>
    Tested-by: Florian Fainelli <f.fainelli@gmail.com>
    Tested-by: Jon Hunter <jonathanh@nvidia.com>
    Tested-by: Linux Kernel Functional Testing <lkft@linaro.org>
    Tested-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
    Tested-by: Slade Watkins <slade@sladewatkins.com>
    Tested-by: Guenter Roeck <linux@roeck-us.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

commit d692e3406e052dbf9f6d9da0cba36cb763272529
Author: Jon Maloy <jmaloy@redhat.com>
Date:   Sat Feb 5 14:11:18 2022 -0500

    tipc: improve size validations for received domain records
    
    commit 9aa422ad326634b76309e8ff342c246800621216 upstream.
    
    The function tipc_mon_rcv() allows a node to receive and process
    domain_record structs from peer nodes to track their views of the
    network topology.
    
    This patch verifies that the number of members in a received domain
    record does not exceed the limit defined by MAX_MON_DOMAIN, something
    that may otherwise lead to a stack overflow.
    
    tipc_mon_rcv() is called from the function tipc_link_proto_rcv(), where
    we are reading a 32 bit message data length field into a uint16.  To
    avert any risk of bit overflow, we add an extra sanity check for this in
    that function.  We cannot see that happen with the current code, but
    future designers being unaware of this risk, may introduce it by
    allowing delivery of very large (> 64k) sk buffers from the bearer
    layer.  This potential problem was identified by Eric Dumazet.
    
    This fixes CVE-2022-0435
    
    Reported-by: Samuel Page <samuel.page@appgate.com>
    Reported-by: Eric Dumazet <edumazet@google.com>
    Fixes: 35c55c9877f8 ("tipc: add neighbor monitoring framework")
    Signed-off-by: Jon Maloy <jmaloy@redhat.com>
    Reviewed-by: Xin Long <lucien.xin@gmail.com>
    Reviewed-by: Samuel Page <samuel.page@appgate.com>
    Reviewed-by: Eric Dumazet <edumazet@google.com>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

commit 3a0a7ec5574b510b067cfc734b8bdb6564b31d4e
Author: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date:   Thu Jan 27 08:16:38 2022 +0100

    moxart: fix potential use-after-free on remove path
    
    commit bd2db32e7c3e35bd4d9b8bbff689434a50893546 upstream.
    
    It was reported that the mmc host structure could be accessed after it
    was freed in moxart_remove(), so fix this by saving the base register of
    the device and using it instead of the pointer dereference.
    
    Cc: Ulf Hansson <ulf.hansson@linaro.org>
    Cc: Xiyu Yang <xiyuyang19@fudan.edu.cn>
    Cc: Xin Xiong <xiongx18@fudan.edu.cn>
    Cc: Xin Tan <tanxin.ctf@gmail.com>
    Cc: Tony Lindgren <tony@atomide.com>
    Cc: Yang Li <yang.lee@linux.alibaba.com>
    Cc: linux-mmc@vger.kernel.org
    Cc: stable <stable@vger.kernel.org>
    Reported-by: whitehat002 <hackyzh002@gmail.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Link: https://lore.kernel.org/r/20220127071638.4057899-1-gregkh@linuxfoundation.org
    Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>


From xen-devel-bounces@lists.xenproject.org Sun Feb 13 18:52:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 13 Feb 2022 18:52:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271016.465338 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJJyW-0006K8-SL; Sun, 13 Feb 2022 18:51:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271016.465338; Sun, 13 Feb 2022 18:51:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJJyW-0006K1-PJ; Sun, 13 Feb 2022 18:51:56 +0000
Received: by outflank-mailman (input) for mailman id 271016;
 Sun, 13 Feb 2022 18:51:55 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=gbK4=S4=epam.com=prvs=4043a61b92=oleksandr_tyshchenko@srs-se1.protection.inumbo.net>)
 id 1nJJyV-0006Jv-1x
 for xen-devel@lists.xenproject.org; Sun, 13 Feb 2022 18:51:55 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 019b1aeb-8cfe-11ec-b215-9bbe72dcb22c;
 Sun, 13 Feb 2022 19:51:53 +0100 (CET)
Received: from pps.filterd (m0174678.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 21DHjAwM005287;
 Sun, 13 Feb 2022 18:51:40 GMT
Received: from eur04-db3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2058.outbound.protection.outlook.com [104.47.12.58])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e76n2r2x6-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Sun, 13 Feb 2022 18:51:40 +0000
Received: from DB8PR03MB6108.eurprd03.prod.outlook.com (2603:10a6:10:ed::15)
 by AM0PR03MB4945.eurprd03.prod.outlook.com (2603:10a6:208:102::32) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.14; Sun, 13 Feb
 2022 18:51:36 +0000
Received: from DB8PR03MB6108.eurprd03.prod.outlook.com
 ([fe80::e975:b192:b8cd:4f73]) by DB8PR03MB6108.eurprd03.prod.outlook.com
 ([fe80::e975:b192:b8cd:4f73%5]) with mapi id 15.20.4975.015; Sun, 13 Feb 2022
 18:51:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 019b1aeb-8cfe-11ec-b215-9bbe72dcb22c
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=RvZbXnRGsdDtEZ4ukq26kxG9BtpBMtffZi0kH/OJ1bRxtCNSUc4ApJqP3iz8vVLmAvKoS7zNuJdT0lxheUTse+TPgnbeeGodgkWuNabWIr0OCOqII72SESEr0MdlTDq29wAp8YabYRkTQxW0+rg1lQxip0qxsPGUQPkaAWOdQTTW52EBUI8RkbB1wnvgeFJqXh+XGQ3HQzobP435bMFlZ4sLPuZpucxh8rS1rCwbvz2VvXVWDZZIPnCK5rhmd13NxUsHaqyI1X7O7S/4VrSHZa4GTbGY2uuLmC7UTybu7QQPB6pYcW/VX87caAavb5h+p29hO1zyTNuOfQ2eYquS2A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ZXye8hZdmDwQ1nQ06sjz3T3zcN7JDchhKvN/KbavBeA=;
 b=Fpom+oKJuBJ2bAqFVWO0iEnG9oFP2EsqrPUGxd3KhnXKtIgg0u5LWa+q5IsuLolZgB7DR2Hz0N886CfaextRND0f2koeGZ2iU1naxnu8wuVGaSnfk0rDQKDOxh3aZ3eNzeszunl0ckRFCd8SWmHzT80lvXxigs3O9cjCuIZwQwUwvggGoxWLa3fF7l91SxxKb7PFPmDyUipjU/v5zTbOGnGDxoartdThCcWG6legdOkA65/FNocH80xXh79Jlrx+B4xHX1Tj7a3ifPITja1n9qJ0R/tig5s2cn4XJ9FYcyfNbxK1yTob8DRYyi0mooK36dFIdIrF+JYF2nojZHLMGw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ZXye8hZdmDwQ1nQ06sjz3T3zcN7JDchhKvN/KbavBeA=;
 b=quPDRItBzUfoOpGEqBbOzrPXLlzKlCkJOB6tqDcAOyOfJtBKeNCRCBWlGRizRHDjGpQE767x//N0aZFD0kYSgaYu3FeQ+Kxc25CKSPo1xIITvbwIbKgBiyVvEpTx1sNB+jdunVOhkPph7K0EMscMoc2IrYv/kDJ7H1yVyaMbLPMMbaG0j4/MbUrlnuR9TzY4oK9EToywId3V20s5dFRW14rCvL9bCgtlyFU5+Jq6xRalTwzWCSD3COTIvEL1TbXKgkVCMgXHDi65eHfBSN/P3JYhwauSD8lbUbHdvZlGhhdfinUoTnSrqrJ6lpOG24DfaJLQkJtPcRnhihj8PEWDSA==
From: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>
To: Julien Grall <julien@xen.org>
CC: Oleksandr <olekstysh@gmail.com>, Jan Beulich <jbeulich@suse.com>,
        "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        Stefano
 Stabellini <sstabellini@kernel.org>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Andrew Cooper <andrew.cooper3@citrix.com>,
        George Dunlap
	<george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
        =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>,
        Bob Eshleman
	<bobbyeshleman@gmail.com>,
        Alistair Francis <alistair.francis@wdc.com>,
        Connor Davis <connojdavis@gmail.com>
Subject: Re: [PATCH V5] xen/gnttab: Store frame GFN in struct page_info on Arm
Thread-Topic: [PATCH V5] xen/gnttab: Store frame GFN in struct page_info on
 Arm
Thread-Index: 
 AQHYAomKM/4d8JNsdEqc8nNA4dib2KyIh6IAgAAs1wCAAQzHgIAAg9oAgAJ8BQCAAHfAAIAEqUeAgAAuOAA=
Date: Sun, 13 Feb 2022 18:51:35 +0000
Message-ID: <98105196-5f2b-d9a6-5f2a-10bf60d309b0@epam.com>
References: <1641424268-12968-1-git-send-email-olekstysh@gmail.com>
 <a54213c4-1c68-694e-c130-d95faeef3953@xen.org>
 <78d94e1e-6db4-25c1-adb8-e4bdbfe42774@epam.com>
 <82d8bfe0-cb46-d303-6a60-2324dd76a1f7@xen.org>
 <79fbf83e-d25e-2634-9769-8e07634bfd63@epam.com>
 <a104d3ea-170e-8175-ac04-abfcebb4ae29@xen.org>
 <f9e3ee5b-0811-8317-42c2-61c8cdbfe254@gmail.com>
 <40ec7063-0c59-02d1-90c7-4cfc9791ad27@xen.org>
In-Reply-To: <40ec7063-0c59-02d1-90c7-4cfc9791ad27@xen.org>
Accept-Language: en-US, ru-RU
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 66c7a59f-199f-443c-7dad-08d9ef21dc51
x-ms-traffictypediagnostic: AM0PR03MB4945:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM0PR03MB4945E79CC29D22B8A31E542386329@AM0PR03MB4945.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 yVsJhWbC/yotMTY7eWLwrXQoDXPKwl0BwO4ABtHQKN0HQQkQPNoN3nsSxNH9vvOgq1mvXlV1volpfkH7BqfAXZglJyPqI6YSLWQeucoT5gu5eYjiia5LttD94Xl1WRGSQXKJCLWBxAJPa/zXwaHzKNm4YGdhs/AeC0F8B1Thcijc+4gEzaiz5+9q/hQwcJMfdnS1tWeFx/Dezsz13qXnEPcpL5NH1dXFf1C6wDFqNufcwp+16eA7fzQ6Mzvf3MRWuEBqhhea24ca4yHxT2pTtgiM73ligfIKdcDsAkB8QcQ+e8fcQm5OgWDbzg81uhR9LBlQ6JbdVYIYNAxsSLexa/mvzn2pECnJWHmFlbPyPOSI0MkLFELpNIz/7r4V96Ik5OAbsjxFoGFfxAx26xM2UNVCMn6aVH7tTNOOXf0Dv0zNAIgoSflMKDc0qZSqQY9u0zEYUvm584A20A2MeQKo24mZo+3KlV+TCKfApKpHj5IVdT9Lq2IjnWur0oCu1NryaA5k+dN125n82sdElJCydU+kd3E8a6GNMbf86AEl9KaLXhCPs0ry+6Ir/eptyfUw39/tbX+ludz5rCMocMS4c4hudr01D7kYAzW/ql50LuZxAO5chaulcqp45/RYPQXBU3pWe5iegN7OeuWZE0SpENgCpFScb98F5y2W2O/soi2niRdpPWOgmkNqU7fMXnrUFEvw8JoX95nBJ6PHs7h/1CGJhaLNWwIG+SDaR5W6iwmnrBO1u5oG4WjS6ljMoAB/Yhe2G2l4npDVN23oaMF3JeCJ0IB7QfCWy60+NvJcG09Knn842rw7MC8OwKM4lHcAVjxRrp31F8LAvHGCm+0TwQ==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB8PR03MB6108.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6486002)(38070700005)(7416002)(8676002)(31686004)(8936002)(186003)(64756008)(66476007)(66946007)(66446008)(66556008)(83380400001)(76116006)(4326008)(31696002)(2616005)(26005)(966005)(91956017)(5660300002)(53546011)(508600001)(55236004)(71200400001)(6512007)(6506007)(2906002)(86362001)(38100700002)(54906003)(316002)(6916009)(36756003)(122000001)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?T3pKMDVCOWpBZVVxU2ZnWXlhR0RSU3ZueVpUTkF2Wk5ER1QrcUt6V1YzRzFX?=
 =?utf-8?B?cE9xR3FGWTNHL0R5WHdJbENzU1lIMEgyY1NZTzJkRVFpN2pEM25TMG01V1FO?=
 =?utf-8?B?MXA5OUp0d1ovZUwxVFZmVjVjS3ovVzRDRHhWMk1WVjdNb1RWSWpkQzhRVitR?=
 =?utf-8?B?SnVQTFdmaW9tNWFxMnd5Z0lIN29KZlZsSmtRdEdkcC9Eb1FVL0Z5cHhiQjhQ?=
 =?utf-8?B?OWk4OHVMWGNVdnlqMzY3WE5XTFA1ZklNNHZZRU9zbHB3eklLckZvanZycnh1?=
 =?utf-8?B?MXNhaUhVL0ZuQmpWOElqb0hpNDdDdHZ5S1djeFZGT21qZDlqMHpLcXd2STIz?=
 =?utf-8?B?cVdjd1hoa2pKVWlaeWRnRFAwZDVjMGJVOGxhN1EzNWNmNG1Qazc2UDBiVjll?=
 =?utf-8?B?eEZkVVQ5MFlIRHlRdEJBeTJjUHEzUVNWenlPaTE0cytBS1NOSWNITDdtQ2tF?=
 =?utf-8?B?MGE5WDBVeWR0RFB2Qld4blhpbzE0MTZvY3NJME93ZExya2hXelNWVlpwSEdn?=
 =?utf-8?B?bmZYdGsyNlBnN3dxbGo4eVU4ZDlTV2p0MVFqZEYyUGVBUFdXSmxzZnpKeXBT?=
 =?utf-8?B?V3ZYQS9pUTk0QlkvSmtTMUxPWEZwNGxSQmg2TkhrYnlBb2w5N05kMXFMUFR6?=
 =?utf-8?B?TGx4eTRad2oyYmFvcGhHYXFITmNMZjhQd1diSWxiZEttVWhPcVlRTVB3SEpC?=
 =?utf-8?B?U2ZDODRBUjBiaVFCOVpZeEtWakN2TUZwcUVaRHhRaW1SVW11VG1wQ3k2VDJn?=
 =?utf-8?B?S0RVWmV4WnFVcjA5TEQ4cVI2RE1sNUliQ1RiaCtvY0hURU9XTGJaNURGWnVK?=
 =?utf-8?B?THM1TVJ3NFQ5Q1hReEpBazRESVZ4ZUxvMy92b1dFbmN5NE9aenhjWDlnNXFW?=
 =?utf-8?B?clY2aHB1V2U5R01QZ1UyZG9PcExzOFdtMnlPQllrYkVqK2dGQ0JGK3RGZENj?=
 =?utf-8?B?ZlJHVEtMalZ5M0ZWQnNUZjBwVkRWZkV4TG41eE5RQ1pTc3k0S1VVRWdEd1hu?=
 =?utf-8?B?WUJFVGs0U0FtNk1WYml5eE5ORGNlUGg3OTJDVlFvVStoNzRRUDFHNVJscWtr?=
 =?utf-8?B?RkZIVzdKK0w4ZkI4VTc0Zmh4MXBFVTVTeUZRTUh4ekJKMVc3eG16ZkE1ajBt?=
 =?utf-8?B?ZGJzSVZkaGVNVS82b2RZS0UrT0R5QVhmQWtGTnJuVjFTUGZtZisrenBpbmtM?=
 =?utf-8?B?b2MwWlRWL0dudHZKZFZiWU1qVTdOZnNHNzJWVjFRL3o1VVk0ZzVtREI5N2p3?=
 =?utf-8?B?VTdWL1doSTVSb3RQOXl2N2FBNTlqWXVCTUNVNVlHUmJ2QzV2NVNHOWZzSU01?=
 =?utf-8?B?MjFnNjlVUjFxeXFGY1VIL3NzQVc1aUIyY0o0em5yanl3MGtZQU9UVlV6T25r?=
 =?utf-8?B?TFZPdWtpUENjbzVVMG1HVUJZWnRiMGtVT3Y1OHVzbE90MEZ3QUROSnp5N0VY?=
 =?utf-8?B?TFdHekVLeS9SeUFZVUJTamVVNUNhZ1dVZjFhNk93ZnFzN1FuRWx0QjBoQ0Vz?=
 =?utf-8?B?SHpWVWM1TFRLVEdQOGxFRVJ1Z0RjOXkxTzVDdUZNZGRMNnpIelFpb0FvZEZs?=
 =?utf-8?B?SnJjQndRVzRMZTc1UVp5T2hlc1pUem5wRUt5bGdINmJkeElVUHJXd1lBYnlw?=
 =?utf-8?B?blgwMkoxWkJVN1ZCc2hnNVR3TmxaVjN1NEhOYVFlNTVIMlIzUnVZWlFoTmI2?=
 =?utf-8?B?cGNnb0pPY0xsNzJUcE9lb3lvYmpQMUVWV0oyU3B5WWJ3RFhHZkN3YWNKYmpm?=
 =?utf-8?B?OWhhWDRMUHF0djROSUFRaXNDVEhnVU5YL2ZDa2QxUGZUd01hWnBDazUxUm11?=
 =?utf-8?B?OVpORmlWSXhRTlNTc2wyZElxT29yYkJMbHdJTjJuNE1tT3VXNC9TZXQ4NjVL?=
 =?utf-8?B?Tm1mVWxXUVNnOGFucWVISDg0MnBDMjZEbEJzSWZBU1g1SHNFNzZ0Y2lDU0c3?=
 =?utf-8?B?bUFJWEsvMTNCbEozWmg3aUN3R0twcVBYSnd4ZERJZXhTa0N1RGRlRXdyaGtB?=
 =?utf-8?B?WW44V1pTMHFnbFZTOEZOYXlyclRuU3dCdENOTUlrOWhkbXo4ZTFwM3ArQThX?=
 =?utf-8?B?ZjVHa1R2YmVXZEVGaEVxVk5ieUYwQVdyQ2Q1cDVzWDVxTzFSZFJDbWsxNlVR?=
 =?utf-8?B?Vjl4anVkVk9mcEZMbmg2YWU4WmdPemNzcVY3QTFrK3JieHVLUk84ZmpUQkNS?=
 =?utf-8?B?TnN4SnNlcTRUQlFaQ0duanREaWp1T2xlNy93SHQ2czFNcUdKMTNlajhMelZx?=
 =?utf-8?Q?SPpz9+9l3LB5oWRjll70rVmzet9zazSuZ1See/9+tk=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <6DE577D54A7F1A48B490C3E8073542DD@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DB8PR03MB6108.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 66c7a59f-199f-443c-7dad-08d9ef21dc51
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Feb 2022 18:51:35.7985
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: BJwObXzUoemjANuG8Vj/oHsxY7Naiyyfpm6aVK1i9JBi0HWhu3CGlQ+5xyP+dCboeAG4lhByu/1LYhU6Gw+aJ+8jrCzXqCNAQlx2Fe8OGo8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB4945
X-Proofpoint-GUID: 10wRGyhLoii-xf76UeLOUXLbMh4P6JrO
X-Proofpoint-ORIG-GUID: 10wRGyhLoii-xf76UeLOUXLbMh4P6JrO
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-13_07,2022-02-11_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 mlxscore=0
 phishscore=0 clxscore=1015 lowpriorityscore=0 bulkscore=0 impostorscore=0
 adultscore=0 priorityscore=1501 suspectscore=0 spamscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2202130128

DQpPbiAxMy4wMi4yMiAxODowNiwgSnVsaWVuIEdyYWxsIHdyb3RlOg0KPiBIaSBPbGVrc2FuZHIs
DQoNCg0KSGkgSnVsaWVuDQoNCg0KDQo+DQo+IE9uIDEwLzAyLzIwMjIgMTY6NTUsIE9sZWtzYW5k
ciB3cm90ZToNCj4+DQo+PiBPbiAxMC4wMi4yMiAxMTo0NiwgSnVsaWVuIEdyYWxsIHdyb3RlOg0K
Pj4+DQo+Pj4NCj4+PiBPbiAwOC8wMi8yMDIyIDE5OjUwLCBPbGVrc2FuZHIgVHlzaGNoZW5rbyB3
cm90ZToNCj4+Pj4NCj4+Pj4gT24gMDguMDIuMjIgMTM6NTgsIEp1bGllbiBHcmFsbCB3cm90ZToN
Cj4+Pj4gQmVsb3cgdGhlIGRpZmYgSSBoYXZlIGxvY2FsbHk6DQo+Pj4+DQo+Pj4+IGRpZmYgLS1n
aXQgYS94ZW4vYXJjaC9hcm0vcDJtLmMgYi94ZW4vYXJjaC9hcm0vcDJtLmMNCj4+Pj4gaW5kZXgg
NTY0NjM0My4uOTBkNzU2MyAxMDA2NDQNCj4+Pj4gLS0tIGEveGVuL2FyY2gvYXJtL3AybS5jDQo+
Pj4+ICsrKyBiL3hlbi9hcmNoL2FybS9wMm0uYw0KPj4+PiBAQCAtMTMxNSwxMSArMTMxNSwzMiBA
QCBzdGF0aWMgaW5saW5lIGludCBwMm1fcmVtb3ZlX21hcHBpbmcoc3RydWN0DQo+Pj4+IGRvbWFp
biAqZCwNCj4+Pj4gwqAgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgbWZuX3QgbWZuKQ0KPj4+PiDCoCDCoHsN
Cj4+Pj4gwqAgwqDCoMKgwqAgc3RydWN0IHAybV9kb21haW4gKnAybSA9IHAybV9nZXRfaG9zdHAy
bShkKTsNCj4+Pj4gK8KgwqDCoCB1bnNpZ25lZCBsb25nIGk7DQo+Pj4+IMKgIMKgwqDCoMKgIGlu
dCByYzsNCj4+Pj4NCj4+Pj4gwqAgwqDCoMKgwqAgcDJtX3dyaXRlX2xvY2socDJtKTsNCj4+Pj4g
K8KgwqDCoCBmb3IgKCBpID0gMDsgaSA8IG5yOyApDQo+Pj4+ICvCoMKgwqAgew0KPj4+PiArwqDC
oMKgwqDCoMKgwqAgdW5zaWduZWQgaW50IGN1cl9vcmRlcjsNCj4+Pj4gK8KgwqDCoMKgwqDCoMKg
IGJvb2wgdmFsaWQ7DQo+Pj4+ICvCoMKgwqDCoMKgwqDCoCBtZm5fdCBtZm5fcmV0dXJuID0gcDJt
X2dldF9lbnRyeShwMm0sIGdmbl9hZGQoc3RhcnRfZ2ZuLCBpKSwNCj4+Pj4gTlVMTCwgTlVMTCwN
Cj4+Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgICZjdXJfb3JkZXIsICZ2YWxpZCk7ID4gKw0K
Pj4+PiArwqDCoMKgwqDCoMKgwqAgaWYgKCB2YWxpZCAmJg0KPj4+DQo+Pj4gdmFsaWQgaXMgYSBj
b3B5IG9mIHRoZSBMUEFFIGJpdCB2YWxpZC4gVGhpcyBtYXkgYmUgMCBpZiBYZW4gZGVjaWRlZCAN
Cj4+PiB0byBjbGVhciBpdCAoaS5lIHdoZW4gZW11bGF0aW5nIHNldC93YXkpLiBZZXQgdGhlIG1h
cHBpbmcgaXRzZWxmIGlzIA0KPj4+IGNvbnNpZGVyZWQgdmFsaWQgZnJvbSBYZW4gUG9WLg0KPj4+
DQo+Pj4gU28geW91IHdhbnQgdG8gcmVwbGFjZSB3aXRoIGEgZGlmZmVyZW50IGNoZWNrIChzZWUg
YmVsb3cpLg0KPj4NCj4+DQo+PiBIbW0sIEkgZ290IGl0LCBzbyAuLi4NCj4+DQo+Pg0KPj4+DQo+
Pj4NCj4+Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAoIW1mbl92YWxpZChtZm4pIHx8ICFt
Zm5fZXEobWZuX2FkZChtZm4sIGkpLCANCj4+Pj4gbWZuX3JldHVybikpICkNCj4+Pj4gK8KgwqDC
oMKgwqDCoMKgIHsNCj4+Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcmMgPSAtRUlMU0VROw0K
Pj4+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBnb3RvIG91dDsNCj4+Pj4gK8KgwqDCoMKgwqDC
oMKgIH0NCj4+Pj4gKw0KPj4+PiArwqDCoMKgwqDCoMKgwqAgaSArPSAoMVVMIDw8IGN1cl9vcmRl
cikgLQ0KPj4+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgICgoZ2ZuX3goc3RhcnRfZ2ZuKSAr
IGkpICYgKCgxVUwgPDwgY3VyX29yZGVyKSAtIDEpKTsNCj4+Pj4gK8KgwqDCoCB9DQo+Pj4+ICsN
Cj4+Pj4gwqAgwqDCoMKgwqAgcmMgPSBwMm1fc2V0X2VudHJ5KHAybSwgc3RhcnRfZ2ZuLCBuciwg
SU5WQUxJRF9NRk4sDQo+Pj4+IMKgIMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqAgcDJtX2ludmFsaWQsIHAybV9hY2Nlc3Nfcnd4KTsNCj4+Pj4gKw0KPj4+PiAr
b3V0Og0KPj4+PiDCoCDCoMKgwqDCoCBwMm1fd3JpdGVfdW5sb2NrKHAybSk7DQo+Pj4+DQo+Pj4+
IMKgIMKgwqDCoMKgIHJldHVybiByYzsNCj4+Pj4NCj4+Pj4NCj4+Pj4gQ291bGQgeW91IHBsZWFz
ZSBjbGFyaWZ5LCBpcyBpdCBjbG9zZSB0byB3aGF0IHlvdSBoYWQgaW4gbWluZD8gSWYgDQo+Pj4+
IHllcywgSQ0KPj4+PiBhbSB3b25kZXJpbmcsIGRvbid0IHdlIG5lZWQgdGhpcyBjaGVjayB0byBi
ZSBvbmx5IGV4ZWN1dGVkIGZvciB4ZW5oZWFwDQo+Pj4+IHBhZ2VzIChhbmQsIHByb2JhYmx5LCB3
aGljaCBQMk0ncyBlbnRyeSB0eXBlIGluIFJBTT8pIHJhdGhlciB0aGFuIGZvcg0KPj4+PiBhbGwg
cGFnZXM/DQo+Pj4NCj4+PiBGcm9tIG15IHVuZGVyc3RhbmRpbmcsIGZvciB0aGUgcHVycG9zZSBv
ZiB0aGlzIHdvcmssIHdlIG9ubHkgDQo+Pj4gc3RyaWN0bHkgbmVlZCB0byBjaGVjayB0aGF0IGZv
ciB4ZW5oZWFwIHBhZ2VzLg0KPj4NCj4+DQo+PiDCoMKgLi4uIHllcywgYnV0IC4uLg0KPj4NCj4+
DQo+Pj4NCj4+Pg0KPj4+IEJ1dCBJIHRoaW5rIGl0IHdvdWxkIGJlIGEgZ29vZCBvcHBvcnR1bml0
eSB0byBoYXJkZW4gdGhlIFAyTSBjb2RlLiANCj4+PiBBdCB0aGUgbW9tZW50LCBvbiBBcm0sIHlv
dSBjYW4gcmVtb3ZlIGFueSBtYXBwaW5ncyB5b3Ugd2FudCAoZXZlbiANCj4+PiB3aXRoIHRoZSB3
cm9uZyBoZWxwZXJzKS4gVGhpcyBsZWFkIHVzIHRvIGEgZmV3IGlzc3VlcyB3aGVuIG1hcHBpbmcg
DQo+Pj4gd2VyZSBvdmVycmlkZW4gc2lsZW50bHkgKGluIHBhcnRpY3VsYXIgd2hlbiBidWlsZGlu
ZyBkb20wKS4NCj4+PiBTbyBJIHdvdWxkIHNheSB3ZSBzaG91bGQgZW5mb3JjZSBpdCBmb3IgZXZl
cnkgUkFNIG1hcHBpbmcuIA0KPj4NCj4+DQo+PiAuLi4gSSB0aGluayB0aGlzIG1ha2VzIHNlbnNl
LCBzbyB0aGUgcHJvcGVyIGNoZWNrIGluIHRoYXQgY2FzZSwgSSANCj4+IGFzc3VtZSwgc2hvdWxk
IGNvbnRhaW4gcDJtX2lzX2FueV9yYW0oKSBtYWNybzoNCj4NCj4NCj4gQ29ycmVjdCwgcDJtX2lz
X2FueV9yYW0oKSBsb29rcyB0aGUgbWFjcm8gd2Ugd2FudCB0byB1c2UgaGVyZS4NCg0KDQpHb29k
LCB0aGFuayB5b3UgZm9yIHRoZSBjbGFyaWZpY2F0aW9uISBGWUksIEkgaGF2ZSBhbHJlYWR5IHJl
LWNoZWNrZWQgDQp3aXRoIHAybV9pc19hbnlfcmFtKCkuIERvbVUgd2l0aCBQViBkZXZpY2VzIChk
aXNwbGF5LCBzb3VuZCwgbmV0KSBhbmQgDQpWaXJ0aW8gKGJsb2NrKSBib290cyB3aXRob3V0IGFu
eSBpc3N1ZXMsIHRoZSByZWJvb3QgYW5kIGRlc3Ryb3kgYWxzbyANCndvcmsuIFRvIGJlIGNsZWFy
LCBhbGwgYmFja2VuZHMgaW4gbXkgZW52aXJvbm1lbnQgcmVzaWRlIGluIERvbUQuDQoNCg0KPg0K
Pj4+IE5vdGUgdGhhdCwgSSB3b3VsZCBsaWtlIHRvIHNlZSB0aGlzIGNoYW5nZSBpbiBhIHNlcGFy
YXRlIGNvbW1pdC4gSXQgDQo+Pj4gd2lsbCBiZSBlYXNpZXIgdG8gcmV2aWV3Lg0KPj4NCj4+DQo+
PiBvaywgSSB3aWxsIGludHJvZHVjZSB0aGlzIGNoZWNrIGJ5IGEgc2VwYXJhdGUgcGF0Y2guDQo+
DQo+IFRoYW5rIHlvdSENCj4NCj4gWy4uLl0NCj4NCj4+Pj4gSXQgaXMgZ29pbmcgdG8gYmUgYSBu
b24tcHJvdGVjdGVkIHdyaXRlIHRvIEdGTiBwb3J0aW9uIG9mIHR5cGVfaW5mby4NCj4+Pg0KPj4+
IFdlbGwgbm8uIFlvdSBhcmUgdXNpbmcgYSBSZWFkLU1vZGlmeS1Xcml0ZSBvcGVyYXRpb24gb24g
dHlwZV9pbmZvLiANCj4+PiBUaGlzIGlzIG5vdCBhdG9taWMgYW5kIHdpbGwgb3ZlcndyaXRlIGFu
eSBjaGFuZ2UgKGlmIGFueSkgZG9uZSBvbiANCj4+PiBvdGhlciBwYXJ0IG9mIHRoZSB0eXBlX2lu
Zm8uDQo+Pg0KPj4NCj4+IEkgYW0gY29uZnVzZWQgYSBiaXQsIHRvIHdoaWNoIG15IGNvbW1lbnQg
eW91ciBjb21tZW50IGFib3ZlIGJlbG9uZ3MgDQo+PiAodG8gdGhlIGRpZmYgZm9yIHBhZ2Vfc2V0
X3hlbmhlYXBfZ2ZuKCkgYWJvdmUgb3IgdG8gc2VudGVuY2UgcmlnaHQgDQo+PiBhZnRlciBpdCk/
DQo+PiBUaGUgIkl0IGlzIGdvaW5nIHRvIGJlIGEgbm9uLXByb3RlY3RlZCB3cml0ZSB0byBHRk4g
cG9ydGlvbiBvZiANCj4+IHR5cGVfaW5mby4iIHNlbnRlbmNlIGlzIHJlbGF0ZWQgdG8gdGhlIGRp
ZmYgZm9yIGFsbG9jX2hlYXBfcGFnZXMoKSANCj4+IGJlbG93LiBTb3JyeSBpZiBJIGRpZG4ndCBz
ZXBhcmF0ZSB0aGUgY29tbWVudHMgcHJvcGVybHkuDQo+DQo+IE9rLiBTbyBpdCB3aWxsIGJlIGEg
d3JpdGUgb3BlcmF0aW9uLCBidXQgSSBzdGlsbCBkb24ndCB1bmRlcnN0YW5kIHdoeSANCj4geW91
IHRoaW5rIGl0IGlzIGp1c3QgdGhlIEdGTiBwb3J0aW9uLg0KPg0KPiBUaGUgY29kZSBpcyB1c2lu
ZyAiLi4udHlwZV9pbmZvID0gUEdUX1RZUEVfSU5GT19JTklUSUFMSVpFUiIuIFNvIHRoZSANCj4g
ZnVsbCA2NC1iaXQgKGFzc3VtaW5nIGFybTY0KSB3aWxsIGJlIG1vZGlmaWVkLg0KDQoNCllvdSBh
cmUgcmlnaHQsIEkgd2Fzbid0IHByZWNpc2UsIHNvcnJ5Lg0KDQoNCj4NCj4NCj4gSW4gZ2VuZXJh
bCwgdGhlIEdGTiB0YWtlcyA2MCBvZiB0aGUgNjQtYml0cy4gU28gYW55IHRpbWUgeW91IG5lZWQg
dG8gDQo+IG1vZGlmeSB0aGUgR0ZOIChvciB0aGUgY291bnRfaW5mbyksIHlvdSB3aWxsIGVuZCB1
cCB0byBtb2RpZnkgdGhlIA0KPiBlbnRpcmUgb2YgdHlwZV9pbmZvIChhbmQgdmljZS12ZXJzYSku
IElmIHRoaXMgaXMgYmVjb21pbmcgd2UgcHJvYmxlbSANCj4gKGUuZy4gdGhlIGNvdW50X2luZm8g
aXMgYWN0aXZlbHkgdXNlZCkgd2Ugd2lsbCBuZWVkIHRvIHVzZSBjbXB4Y2hnKCkgDQo+IHRvIG1v
ZGlmeSB0aGUgR0ZOIHBvcnRpb24uDQoNCg0KSSBnb3QgaXQsIGFzIEkgdW5kZXJzdG9vZCBmcm9t
IHlvdXIgZXhwbGFuYXRpb24gYWJvdXQgDQpzaGFyZV94ZW5fcGFnZV93aXRoX2d1ZXN0KCkgYXQg
WzFdIHRoaXMgaXMgbm90IGEgcHJvYmxlbSB5ZXQgd2l0aGluIA0KY3VycmVudCBjb2RlIGJhc2Uu
DQoNCg0KWzFdIA0KaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcveGVuLWRldmVsL2ExMDRkM2VhLTE3
MGUtODE3NS1hYzA0LWFiZmNlYmI0YWUyOUB4ZW4ub3JnLw0KDQoNCj4NCj4NCj4gQ2hlZXJzLA0K
Pg0KLS0gDQpSZWdhcmRzLA0KDQpPbGVrc2FuZHIgVHlzaGNoZW5rbw0K


From xen-devel-bounces@lists.xenproject.org Sun Feb 13 21:13:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 13 Feb 2022 21:13:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271023.465350 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJMBE-0002Ov-W6; Sun, 13 Feb 2022 21:13:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271023.465350; Sun, 13 Feb 2022 21:13:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJMBE-0002Oo-SK; Sun, 13 Feb 2022 21:13:12 +0000
Received: by outflank-mailman (input) for mailman id 271023;
 Sun, 13 Feb 2022 21:13:12 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJMBE-0002Oe-1u; Sun, 13 Feb 2022 21:13:12 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJMBD-0001To-UL; Sun, 13 Feb 2022 21:13:11 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJMBD-0003yj-Dm; Sun, 13 Feb 2022 21:13:11 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nJMBD-0007BN-DK; Sun, 13 Feb 2022 21:13:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=gSZhzOqCYzFI+Hm42jPpoYPStlc9aGuJlep8ncRi3hs=; b=F4UMKzg1SZdPq7SNB9JH0s6VlN
	zsCYd5HeGvfC8PtoahZk7/XicPXBYCZIfP4anU1BUNV1fefeWkQbsrXnFlbmHhFxMxRV54vMYLAfG
	YxowHgGzUEWMmMAQUl8zVT5ow+59Fo2M7B9F6R8mYw66T69wQDGR56DavQEkW1ITguCA=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168099-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 168099: trouble: blocked/broken/fail/pass
X-Osstest-Failures:
    linux-linus:build-arm64:<job status>:broken:regression
    linux-linus:build-arm64-pvops:<job status>:broken:regression
    linux-linus:build-arm64-xsm:<job status>:broken:regression
    linux-linus:build-arm64-xsm:host-install(4):broken:regression
    linux-linus:build-arm64:host-install(4):broken:regression
    linux-linus:build-arm64-pvops:host-install(4):broken:regression
    linux-linus:test-arm64-arm64-examine:build-check(1):blocked:nonblocking
    linux-linus:build-arm64-libvirt:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=b81b1829e7e39f6cebdf6e4d5484eacbceda8554
X-Osstest-Versions-That:
    linux=f1baf68e1383f6ed93eb9cff2866d46562607a43
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 13 Feb 2022 21:13:11 +0000

flight 168099 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168099/

Failures and problems with tests :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-arm64                     <job status>                 broken
 build-arm64-pvops               <job status>                 broken
 build-arm64-xsm                 <job status>                 broken
 build-arm64-xsm               4 host-install(4)        broken REGR. vs. 168080
 build-arm64                   4 host-install(4)        broken REGR. vs. 168080
 build-arm64-pvops             4 host-install(4)        broken REGR. vs. 168080

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-examine      1 build-check(1)               blocked  n/a
 build-arm64-libvirt           1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl           1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit1   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit2   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-seattle   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-thunderx  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-vhd       1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-xsm       1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168080
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168080
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168080
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168080
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168080
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail like 168080
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168080
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168080
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168080
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                b81b1829e7e39f6cebdf6e4d5484eacbceda8554
baseline version:
 linux                f1baf68e1383f6ed93eb9cff2866d46562607a43

Last test of basis   168080  2022-02-11 00:09:22 Z    2 days
Failing since        168086  2022-02-11 20:11:19 Z    2 days    5 attempts
Testing same since   168094  2022-02-12 21:42:38 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Aaron Liu <aaron.liu@amd.com>
  Adam Ford <aford173@gmail.com>
  Al Cooper <alcooperx@gmail.com>
  Alex Deucher <alexander.deucher@amd.com>
  Alexander Egorenkov <egorenar@linux.ibm.com>
  Alexander Gordeev <agordeev@linux.ibm.com>
  Alexander Stein <alexander.stein@ew.tq-group.com>
  Alexandre Ghiti <alexandre.ghiti@canonical.com>
  Alim Akhtar <alim.akhtar@samsung.com>
  Alviro Iskandar Setiawan <alviro.iskandar@gmail.com>
  Ammar Faizi <ammarfaizi2@gnuweeb.org>
  Andreas Gruenbacher <agruenba@redhat.com>
  Andrew Morton <akpm@linux-foundation.org>
  Andrey Konovalov <andreyknvl@gmail.com>
  Andrzej Pietrasiewicz <andrzej.p@collabora.com>
  Andy Shevchenko <andriy.shevchenko@linux.intel.com>
  Arnd Bergmann <arnd@arndb.de>
  Aswath Govindraju <a-govindraju@ti.com>
  Aurelien Jarno <aurelien@aurel32.net>
  Bartosz Golaszewski <brgl@bgdev.pl>
  Bean Huo <beanhuo@micron.com>
  Benjamin Gaignard <benjamin.gaignard@collabora.com>
  Bjorn Helgaas <bhelgaas@google.com>
  Bob Peterson <rpeterso@redhat.com>
  Brian Johannesmeyer <bjohannesmeyer@gmail.com>
  Brian Norris <briannorris@chromium.org>
  Cai Huoqing <cai.huoqing@linux.dev>
  Cameron Williams <cang1@live.co.uk>
  Catalin Marinas <catalin.marinas@arm.com>
  Changbin Du <changbin.du@gmail.com>
  Chia-Wei Wang <chiawei_wang@aspeedtech.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Borntraeger <borntraeger@linux.ibm.com>
  Christian Hewitt <christianshewitt@gmail.com>
  Christian König <christian.koenig@amd.com>
  Christoph Hellwig <hch@lst.de>
  Christoph Niedermaier <cniedermaier@dh-electronics.com>
  Christophe JAILLET <christophe.jaillet@wanadoo.fr>
  Chunfeng Yun <chunfeng.yun@mediatek.com>
  Damien Le Moal <damien.lemoal@opensource.wdc.com>
  Dan Carpenter <dan.carpenter@oracle.com>
  Daniel Bristot de Oliveira <bristot@kernel.org>
  Daniel Stone <daniels@collabora.com>
  Daniel Vetter <daniel.vetter@ffwll.ch>
  Daniel Vetter <daniel.vetter@intel.com>
  Daniel Wheeler <daniel.wheeler@amd.com>
  Dave Airlie <airlied@redhat.com>
  Dave Stevenson <dave.stevenson@raspberrypi.com>
  David Hildenbrand <david@redhat.com>
  David Rientjes <rientjes@google.com>
  Dinh Nguyen <dinguyen@kernel.org>
  Dmytro Laktyushkin <Dmytro.Laktyushkin@amd.com>
  Dongjin Kim <tobetter@gmail.com>
  Fabio Estevam <festevam@gmail.com>
  Fabio M. De Francesco <fmdefrancesco@gmail.com>
  Fabrice Gasnier <fabrice.gasnier@foss.st.com>
  Florian Fainelli <f.fainelli@gmail.com>
  Geert Uytterhoeven <geert+renesas@glider.be>
  Geert Uytterhoeven <geert@linux-m68k.org>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>Cc: Dave Airlie <airlied@gmail.com>
  Guido Günther <agx@sigxcpu.org> # Librem 5 (imx8mq) with it's rather picky panel
  Hans de Goede <hdegoede@redhat.com>
  Hector Martin <marcan@marcan.st>
  Heiko Carstens <hca@linux.ibm.com>
  Heiko Stuebner <heiko@sntech.de>
  Helge Deller <deller@gmx.de>
  Ilya Leoshkevich <iii@linux.ibm.com>
  Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
  JaeSang Yoo <js.yoo.5b@gmail.com>
  JaeSang Yoo <jsyoo5b@gmail.com>
  Jakob Koschel <jakobkoschel@gmail.com>
  James Smart <jsmart2021@gmail.com>
  Jan Beulich <jbeulich@suse.com>
  Jan Kara <jack@suse.cz>
  Jani Nikula <jani.nikula@intel.com>
  Jann Horn <jannh@google.com>
  Jarkko Nikula <jarkko.nikula@bitmer.com>
  Jasdeep Dhillon <jdhillon@amd.com>
  Jayesh Choudhary <j-choudhary@ti.com>
  Jens Axboe <axboe@kernel.dk>
  Jens Wiklander <jens.wiklander@linaro.org>
  Jeremy Linton <jeremy.linton@arm.com>
  Jerome Forissier <jerome@forissier.org>
  Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
  Jisheng Zhang <jszhang@kernel.org>
  Joel Stanley <joel@jms.id.au>
  Johan Hovold <johan@kernel.org>
  Jonas Malaco <jonas@protocubo.io>
  Juergen Gross <jgross@suse.com>
  Kai-Heng Feng <kai.heng.feng@canonical.com>
  Kees Cook <keescook@chromium.org>
  Kishon Vijay Abraham I <kishon@ti.com>
  Kosuke Tatsukawa <tatsu-ab1@nec.com>
  Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Linus Walleij <linus.walleij@linaro.org>
  Liu Ying <victor.liu@nxp.com>
  Liu Ying <victor.liu@nxp.com> # RM67191 DSI panel on i.MX8mq EVK
  Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
  Lucas De Marchi <lucas.demarchi@intel.com>
  Lutz Koschorreck <theleks@ko-hh.de>
  Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
  Marek Vasut <marex@denx.de>
  Mario Limonciello <mario.limonciello@amd.com>
  Mark Brown <broonie@kernel.org>
  Martin Blumenstingl <martin.blumenstingl@googlemail.com>
  Martin K. Petersen <martin.petersen@oracle.com>
  Martin Kepplinger <martin.kepplinger@puri.sm>
  Mathias Krause <minipli@grsecurity.net>
  Maxime Ripard <maxime@cerno.tech>
  Mel Gorman <mgorman@suse.de>
  Michael Walle <michael@walle.cc>
  Michal Hocko <mhocko@suse.com>
  Michal Simek <michal.simek@xilinx.com>
  Mike Rapoport <rppt@linux.ibm.com>
  Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>
  Myrtle Shah <gatecat@ds0.me>
  Nathan Chancellor <nathan@kernel.org>
  Neil Armstrong <narmstrong@baylibre.com>
  Neil Armstrong <narmstrong@baylibre.com> # for phy-meson-axg-mipi-dphy.c
  Niklas Cassel <niklas.cassel@wdc.com>
  Nishanth Menon <nm@ti.com>
  Padmanabha Srinivasaiah <treasure4paddy@gmail.com>
  Palmer Dabbelt <palmer@rivosinc.com>
  Pavel Hofman <pavel.hofman@ivitera.com>
  Pawel Dembicki <paweldembicki@gmail.com>
  Peng Liu <liupeng256@huawei.com>
  Philippe Cornu <philippe.cornu@foss.st.com>
  Pingfan Liu <kernelfans@gmail.com>
  Pratham Pratap <quic_ppratap@quicinc.com>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Rafał Miłecki <rafal@milecki.pl>
  Rob Herring <robh@kernel.org>
  Robert Hancock <robert.hancock@calian.com>
  Robin Murphy <robin.murphy@arm.com>
  Roger Pau Monne <roger.pau@citrix.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Roman Gushchin <guro@fb.com>
  Roman Li <Roman.Li@amd.com>
  Rui Salvaterra <rsalvaterra@gmail.com>
  Sagi Grimberg <sagi@grimberg.me>
  Sam Protsenko <semen.protsenko@linaro.org>
  Sam Ravnborg <sam@ravnborg.org>
  Samuel Thibault <samuel.thibault@ens-lyon.org>
  Sascha Hauer <s.hauer@pengutronix.de>
  Sean Anderson <sean.anderson@seco.com>
  Shakeel Butt <shakeelb@google.com>
  Shawn Guo <shawnguo@kernel.org>
  Slark Xiao <slark_xiao@163.com>
  Stefan Wahren <stefan.wahren@i2se.com>
  Stephan Brunner <s.brunner@stephan-brunner.net>
  Steven Rostedt (Google) <rostedt@goodmis.org>
  Sven Peter <sven@svenpeter.dev>
  Sven Schnelle <svens@linux.ibm.com>
  Sylwester Nawrocki <s.nawrocki@samsung.com>
  Szymon Heidrich <szymon.heidrich@gmail.com>
  TATSUKAWA KOSUKE (立川 江介) <tatsu-ab1@nec.com>
  Tejun Heo <tj@kernel.org>
  Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
  Thomas Hellström <thomas.hellstrom@linux.intel.com>
  Thomas Zimmermann <tzimmermann@suse.de>
  Tim Harvey <tharvey@gateworks.com>
  Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
  Tommaso Merciai <tomm.merciai@gmail.com>
  Tony Lindgren <tony@atomide.com>
  Tvrtko Ursulin <tvrtko.ursulin@intel.com>
  Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
  Udipto Goswami <quic_ugoswami@quicinc.com>
  Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
  Vasily Gorbik <gor@linux.ibm.com>
  Vignesh Raghavendra <vigneshr@ti.com>
  Ville Syrjälä <ville.syrjala@linux.intel.com>
  Vineeth Vijayan <vneethv@linux.ibm.com>
  Vinod Koul <vkoul@kernel.org>
  Vlastimil Babka <vbabka@suse.cz>
  Wan Jiabing <wanjiabing@vivo.com>
  Yang Shi <shy828301@gmail.com>
  Yang Wang <KevinYang.Wang@amd.com>
  Ye Guojin <ye.guojin@zte.com.cn>
  Yizhuo Zhai <yzhai003@ucr.edu>
  Zhan Liu <Zhan.Liu@amd.com>
  Zoltán Böszörményi <zboszor@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              broken  
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  broken  
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          blocked 
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            broken  
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          blocked 
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      blocked 
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  blocked 
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  blocked 
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     blocked 
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 blocked 
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      blocked 
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary

broken-job build-arm64 broken
broken-job build-arm64-pvops broken
broken-job build-arm64-xsm broken
broken-step build-arm64-xsm host-install(4)
broken-step build-arm64 host-install(4)
broken-step build-arm64-pvops host-install(4)

Not pushing.

(No revision log; it would be 4657 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Feb 13 23:18:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 13 Feb 2022 23:18:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271037.465361 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJO87-0005Id-Ab; Sun, 13 Feb 2022 23:18:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271037.465361; Sun, 13 Feb 2022 23:18:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJO87-0005IW-7X; Sun, 13 Feb 2022 23:18:07 +0000
Received: by outflank-mailman (input) for mailman id 271037;
 Sun, 13 Feb 2022 23:18:05 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJO85-0005IM-SQ; Sun, 13 Feb 2022 23:18:05 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJO85-0003io-Mz; Sun, 13 Feb 2022 23:18:05 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJO85-0001J7-9h; Sun, 13 Feb 2022 23:18:05 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nJO85-0004ir-71; Sun, 13 Feb 2022 23:18:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Pb8lh4VqISvKt9pwjEkhPlHqkj/hsASaIPLAt/Q30Ps=; b=LmIOx7Q+/89UrauUg3WsHJtegi
	NSJlHkp/D0oiW4+qqJyIHHPJfROn4jVQddme1DFWTTCxfRMEagLSRFYznYUpeB74BJMgZTcBEDJBp
	h2nlXGtbzcTrn/pjuqRcwoZSRQh78m01Aq1VlxWF9iVlBhd+dJil1rOgk29agUPCQrbM=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168101-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 168101: trouble: blocked/broken/fail/pass
X-Osstest-Failures:
    qemu-mainline:build-arm64:<job status>:broken:regression
    qemu-mainline:build-arm64-pvops:<job status>:broken:regression
    qemu-mainline:build-arm64-xsm:<job status>:broken:regression
    qemu-mainline:build-arm64-pvops:host-install(4):broken:regression
    qemu-mainline:build-arm64-xsm:host-install(4):broken:regression
    qemu-mainline:build-arm64:host-install(4):broken:regression
    qemu-mainline:test-amd64-amd64-qemuu-freebsd11-amd64:xen-boot:fail:heisenbug
    qemu-mainline:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-arm64-arm64-xl:build-check(1):blocked:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:build-arm64-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=da36afa2d8dc9c778292ff172083caba9558b4fa
X-Osstest-Versions-That:
    qemuu=0a301624c2f4ced3331ffd5bce85b4274fe132af
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 13 Feb 2022 23:18:05 +0000

flight 168101 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168101/

Failures and problems with tests :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-arm64                     <job status>                 broken
 build-arm64-pvops               <job status>                 broken
 build-arm64-xsm                 <job status>                 broken
 build-arm64-pvops             4 host-install(4)        broken REGR. vs. 168059
 build-arm64-xsm               4 host-install(4)        broken REGR. vs. 168059
 build-arm64                   4 host-install(4)        broken REGR. vs. 168059

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-qemuu-freebsd11-amd64  8 xen-boot         fail pass in 168095

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl           1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit1   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit2   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-seattle   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-thunderx  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-vhd       1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-xsm       1 build-check(1)               blocked  n/a
 build-arm64-libvirt           1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168059
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168059
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168059
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168059
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168059
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168059
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168059
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168059
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                da36afa2d8dc9c778292ff172083caba9558b4fa
baseline version:
 qemuu                0a301624c2f4ced3331ffd5bce85b4274fe132af

Last test of basis   168059  2022-02-08 15:36:56 Z    5 days
Testing same since   168095  2022-02-12 22:37:11 Z    1 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alex Bennée <alex.bennee@linaro.org>
  Cédric Le Goater <clg@kaod.org>
  Ivanov Arkady <arkadiy.ivanov@ispras.ru>
  Michael Tokarev <mjt@tls.msk.ru>
  Peter Maydell <peter.maydell@linaro.org>
  Philippe Mathieu-Daudé <f4bug@amsat.org>
  Stefan Hajnoczi <stefanha@redhat.com>
  Thomas Huth <thuth@redhat.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              broken  
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  broken  
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          blocked 
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            broken  
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          blocked 
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      blocked 
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       fail    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  blocked 
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  blocked 
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 blocked 
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      blocked 
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary

broken-job build-arm64 broken
broken-job build-arm64-pvops broken
broken-job build-arm64-xsm broken
broken-step build-arm64-pvops host-install(4)
broken-step build-arm64-xsm host-install(4)
broken-step build-arm64 host-install(4)
broken-job build-arm64 broken
broken-job build-arm64-xsm broken
broken-job build-arm64-pvops broken

Not pushing.

(No revision log; it would be 585 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Feb 14 01:42:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 01:42:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271048.465372 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJQNO-0004ki-BF; Mon, 14 Feb 2022 01:42:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271048.465372; Mon, 14 Feb 2022 01:42:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJQNO-0004ka-4p; Mon, 14 Feb 2022 01:42:02 +0000
Received: by outflank-mailman (input) for mailman id 271048;
 Mon, 14 Feb 2022 01:42:00 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=ZoBT=S5=vivo.com=wangqing@srs-se1.protection.inumbo.net>)
 id 1nJQNM-0004kU-Kq
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 01:42:00 +0000
Received: from APC01-HK2-obe.outbound.protection.outlook.com
 (mail-hk2apc01on0712.outbound.protection.outlook.com
 [2a01:111:f400:febc::712])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 49bf8013-8d37-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 02:41:56 +0100 (CET)
Received: from SL2PR06MB3082.apcprd06.prod.outlook.com (2603:1096:100:37::17)
 by TYAPR06MB2094.apcprd06.prod.outlook.com (2603:1096:404:20::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Mon, 14 Feb
 2022 01:41:50 +0000
Received: from SL2PR06MB3082.apcprd06.prod.outlook.com
 ([fe80::80b4:e787:47a9:41bb]) by SL2PR06MB3082.apcprd06.prod.outlook.com
 ([fe80::80b4:e787:47a9:41bb%4]) with mapi id 15.20.4975.014; Mon, 14 Feb 2022
 01:41:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 49bf8013-8d37-11ec-b215-9bbe72dcb22c
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cByJnK2R0KIDD7t2qwUlZD3akT/PyWr/bEQUMhWOwtYczsZbQGtitGNFX//sFSeX1a5gfxdbLpsYTHJd9tsVvftpoTYMITrQ9rRLOYHpySVixTDEfRbb2MNm1LK/oluAdBjIp5RUlOoSYZd/V92QnULLc7mlqj25IjflNAV31MeDOcpGz6sUrasNsNxe7sU7btb260dVnWmrl/KtzevZHqHnasjK2wHc6NUCj5ZXI6dlQ8WctidawQCWE8yako+/Hhy9Au93I4YjiqBAntRYxidToKPH18UU4Myzt8AadrSewab/O17pkgHxxBgXmNchx8YjtK2mF7rOMp9MwrKNqQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=XWsgorvkriMC4IBobVyClEuihyZfprg5Hjjrgj1aERo=;
 b=BJhP7er1O/jbZmv6ON4rot5exV6vcnYzRiVUPrAWNyfSP4JqaS6HhJDJ/1DlsbSIkcqX1CSkj/9OejtnRUjP1bj5pGbzKOjraZdZfScY3OkG2vFE8GXmt+LvgytsRshYudxzvBMSwCd0qkVSZo5CSWWl14XLH3RXgOXkWGCEGTISOYdbTXfvVi4zDo7DgJtPzOQFNrajapNXNWkBnO9aEuM4kJXaWsNMagJykyJyjc1qWRXB8X7G27HSYH6b125HPXk+lDNjZwXHbxvBLXd4ugSdslU4XF0xivRK5IOszYCqvpHetfwGe8i5uJX2nhkWiCDhD4M//txueLhZv8vSmA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo0.onmicrosoft.com;
 s=selector2-vivo0-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=XWsgorvkriMC4IBobVyClEuihyZfprg5Hjjrgj1aERo=;
 b=UeDTi0zuOUmr9Pid30vIe6C8hCWfkRXGYnEiQ6LhWigLRwvjnZ5RwF0j5DhsI5srVRvWy9pKid7ijyAne95WYKI39KyUngU7q0dndaFcrrpGcup4qLKC1q+ksmU5naMkUJ2GXeC5vU0r7gvQlAt7XZfVtiUx42LDpFAse5CKK6A=
From: =?utf-8?B?546L5pOO?= <wangqing@vivo.com>
To: Theodore Ts'o <tytso@mit.edu>
CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	=?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>, Jens Axboe
	<axboe@kernel.dk>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd
	<sboyd@kernel.org>, Jani Nikula <jani.nikula@linux.intel.com>, Joonas
 Lahtinen <joonas.lahtinen@linux.intel.com>, Rodrigo Vivi
	<rodrigo.vivi@intel.com>, David Airlie <airlied@linux.ie>, Daniel Vetter
	<daniel@ffwll.ch>, Alex Deucher <alexander.deucher@amd.com>,
	=?utf-8?B?Q2hyaXN0aWFuIEvDtm5pZw==?= <christian.koenig@amd.com>, "Pan,
 Xinhui" <Xinhui.Pan@amd.com>, Srinivas Pandruvada
	<srinivas.pandruvada@linux.intel.com>, Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>, Dmitry Torokhov
	<dmitry.torokhov@gmail.com>, Alasdair Kergon <agk@redhat.com>, Mike Snitzer
	<snitzer@redhat.com>, "dm-devel@redhat.com" <dm-devel@redhat.com>, Mauro
 Carvalho Chehab <mchehab@kernel.org>, Hans Verkuil <hverkuil@xs4all.nl>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
	"intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>,
	"dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
	"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>,
	"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
	"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>
Subject: RE: [PATCH V2 00/13] use time_is_xxx() instead of jiffies judgment
Thread-Topic: [PATCH V2 00/13] use time_is_xxx() instead of jiffies judgment
Thread-Index: AQHYHu9qiPwDdlFSYEaDYTiIhZy3uayQIm6AgAImXJI=
Date: Mon, 14 Feb 2022 01:41:48 +0000
Message-ID:
 <SL2PR06MB308222AB00048FDE424524EABD339@SL2PR06MB3082.apcprd06.prod.outlook.com>
References: <1644546640-23283-1-git-send-email-wangqing@vivo.com>
 <AC2AdwCTE8eh*443p3QtSarp.9.1644684463005.Hmail.wangqing@vivo.com.@PFlnZmtnMG42UnZ2SllNSmFAbWl0LmVkdT4=>
In-Reply-To:
 <AC2AdwCTE8eh*443p3QtSarp.9.1644684463005.Hmail.wangqing@vivo.com.@PFlnZmtnMG42UnZ2SllNSmFAbWl0LmVkdT4=>
Accept-Language: zh-CN, en-US
Content-Language: zh-CN
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
suggested_attachment_session_id: 7bc8dbe4-fcbe-1b44-0918-3ec81ee5fc0a
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=vivo.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 6ab30851-031f-469f-73b5-08d9ef5b2afa
x-ms-traffictypediagnostic: TYAPR06MB2094:EE_
x-microsoft-antispam-prvs:
 <TYAPR06MB2094CADEBE0B9CDAB3ECF323BD339@TYAPR06MB2094.apcprd06.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:2276;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 PoQok9Mu3ZF5QO0IncVJflif2uy9diA524kPlDSLHY4UBs37e6JGiHkASFwIG+4yflYdZDqKgeWKeCYB5/Sbo32xdJcxsLyQ/+diycx6UprHMN0GVTLNQKoNW0v31rQHBp+1wnsHABWy51mcsQCAEVXtJ9ZEvXJVMu8MuZsbAU5tmZSMaxqF+8mSi+I4FD5uLIDv3TRe1qjuVPgIP2qTgJUPOaX1eoAvuBIn2y6zUMqMd/iyV2mgzBYPXMaJnOq+lnMd2D6lC/wDwrqZfZOvqsqsD/HyqwiVItBCTOonUeoinlpGPlRgF5Yon2yVaTf3I6qEDtgRKDDyTGx1BRID+Z3HechR68/SJbfFBWHZ3N+rEm59C2CBX7yAjzi1gp6jcfZHjKMqfIyokwvMQYnx22lA01R/AjbyxACX/Vh8uJXZBLdj4KLBn/dUIdnVl4NeEpujW80I19/Z2vpRIcxK4wcfU5uHYU/kD6kPgFTHaheNXHNrKltgMvqvwCArlDlN6Z0udpAEEJAjfTbODfYGN/zKMtn7TlR3VQCtcP0oN7QKXuD4eTy3IESB3FwXpSAnD5PPp+bag17YYRetFZpDxcEfSqEtDnYCeSdk0asfM96eC1an000kBwvsUpGkJ+u/4bK/gEW8lYFEK8lvRmI8u7AP439gqA5wcToYSWOR0LEDd6S7wSJjPXJuNRQcmv67qM0vj81Rspl+cs+8ReRhO5pmjS7z7PGWWgItqnMwFJ8=
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SL2PR06MB3082.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(8936002)(66946007)(6916009)(52536014)(71200400001)(6506007)(5660300002)(66446008)(54906003)(86362001)(9686003)(316002)(55016003)(91956017)(66476007)(33656002)(66556008)(4326008)(64756008)(8676002)(76116006)(7696005)(38100700002)(2906002)(508600001)(38070700005)(7406005)(26005)(186003)(4744005)(7416002)(85182001)(122000001)(21314003);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?ODRtSGRHcm8xbmh6VWlHS09HZ2JBWkFYVlFvNnBTNFJwaEZjQkhYVUpLZFpq?=
 =?utf-8?B?QS9jSTZRbDhzdjJoNmpwdFByT0hMcVN6aTZSazROcGhpVmlsTTBoUnZxdGJT?=
 =?utf-8?B?MHUxQU5maGVZQmovMmhLdnBWZitJVDlnVEhoaThxWGJNODBWRlEvQjRyNENK?=
 =?utf-8?B?REtlRStNOHhuTjIxeFVJTEcwVW9IRWx4cEJBM05vSlViWTgvUENLakxKM2Jk?=
 =?utf-8?B?OURpV254c2ZiRGw2UC9PUEU0REYzbFJ5MEoxdnl6K0REanh5aVMrY3U1Ymlp?=
 =?utf-8?B?Q3RxL2w1Zm53S3RuV05Zem1sa0Y4K253dldUWnk4ekY2aWU5MDBsQ09qblpq?=
 =?utf-8?B?am1EUU5qcEtubDM2T2p2UVFGWDduVXdVeU1jeVVrazc1SE5yeFN6Q3VObjRa?=
 =?utf-8?B?bjA1UFZBUHFDd3A2dGVaaDVta2dmUVR0aXNnQ2dESWt4UHluQVdIR28wYjh3?=
 =?utf-8?B?eHRzeFhyN1hlVkp3UURXVUp5ZU5XckxNQWUrVmxrVTdtc1dqU3FzQ2dUbTlu?=
 =?utf-8?B?WnpDUWxjQzdHRkIvVGJ3NWV6MGI3MnEwSkVIL0xvT3BTS0g5a09FRkswNnhp?=
 =?utf-8?B?Ukg5dUV2UDdxTm83Q2JVSlprOTEzU2tFbFBqdDMwTU0vSm44eW9FdWdiRkhR?=
 =?utf-8?B?LzNNV2Qyd3RkS29ONkdLRlRiUnJaYW5UTXlmb3ZUL000aXFrYkkraGFjR05O?=
 =?utf-8?B?cEV6MmxyM1JRalZGYUxKcHBqeittZ3Z3TWZVQzg4TFRwVWk5czMwS0JITFdz?=
 =?utf-8?B?QWlNZ2IwT09ROHhkbmNkbFNXOCtHcXNwbHNsajVaZ00wT2FvTWlBNCtYb1dE?=
 =?utf-8?B?QXJqemdOQVY2Vm5LajY1Vi9nM0VVUVZoNDMzMlJla2grZkJIVVFVclFIdmJz?=
 =?utf-8?B?Nm1QZGY4a0FUeXh0N013cWk3eVlHd21VdFRQNDl3a2N3NWJFRXVzbm5qaDRz?=
 =?utf-8?B?a1JkNUx0MC9nMzJHbTNoSmJMdW9udmZyQU5RSDdPMzdTdFV6Q3Q2czcvMTAv?=
 =?utf-8?B?cjhFenFMWjEyaFpQcHlIS016RWUvaWZDTVpLSzA1TnFieSs1dW9lUkV6UkxD?=
 =?utf-8?B?SERZZnF6NlZMWURyank2TnJvNnFCOGJNRlludFh3Q3lOcHZ1QSsyc01VaUI4?=
 =?utf-8?B?MDhBQjNMUjJLZFVVd0ZBRzEyWGlaYjZ0YndDY1NTRU5aZkpUOVhBNHdNVWp2?=
 =?utf-8?B?NXJXVDZSY21hcUZ3cVBlcTZPM0wxakI3TmVXVDdDZGt2NDlaZ2VsSVREaWJQ?=
 =?utf-8?B?Y0tHZzBzZGQyaFhtZFRRanBQV1Ixa0h1SXBUb01NWEhTekViSFM3cVNzZ00x?=
 =?utf-8?B?WUF5QXNUZ3NNRmYzakNDNkVORGluVGJENzBKOUcvajZxbGdTUHo2T2NrT3Z3?=
 =?utf-8?B?Wk0xWmhsdWluamJ0dHNRRElzZjM3WmprdS9LMm4xY3k0NGdzWHFGL2pyZnpp?=
 =?utf-8?B?WEtjcE96U09SSncvREhsaVVmVysxNDY0Qy9JTnZsc3BBY1l0cGFBYjVkRm5i?=
 =?utf-8?B?SnBHWmVwM0hzc2ZEeUZNcXJyZVJNc0NzcSt0TS9HdXlGTWpWbllYNlZJeXAz?=
 =?utf-8?B?cU5uVWdjUWVCOUg4TkFuZTRxY2RJL0k5clNiYU83NWNpS0s4Z3ZmSU9WWmpp?=
 =?utf-8?B?N2FNVWtWSjRlUHF3OStWUUVITnFGd1FtL1ZCRTdHU0lPRFRpbGJaQ2NkdXJF?=
 =?utf-8?B?T3A0dVE1ZU8wRVNWU3YxWktlVS9qdFFSTHRWMmp3YmVVNytrSDMvUUYvSm1j?=
 =?utf-8?B?NVBobGtVdlFJNHUwLzhGbGdGRHZuOGtWVnFTU2tqVEhiUEJjd0xEc01MZVgz?=
 =?utf-8?B?VXpzQldneDB4NHRIcUsvVkpPVzJBU3loVFpuTG0va09WZ1BDZFVzSnpKZVdJ?=
 =?utf-8?B?MExSYnJ5UnEwSEo5TUpJTHVhaVd2aEF5bVJNN2lkL2xUWkZOdG4zbUo0UWtD?=
 =?utf-8?B?VlJrTVVveE1UL2ZqTFA1R29sWFFuY0tDa1hvRFpJbHJuQVFYWXYzbGxtRENX?=
 =?utf-8?B?UTNTYXhnakxrOC9UaW15UXI1RER6UVlkeWNLRzJ6K2FFREljR0d1RVJKN3l1?=
 =?utf-8?B?T3hzOTZtMkhpeE5wc2tIczlWWThHTHp2aFRoRndzeWwrUHhzNWpqcEJpVzFu?=
 =?utf-8?B?MGhPRkJPeFZrZDRkNWNzTW1Rakg3Y3h2V0ZOa1RxL25HN3BFRlpZVTNNRzhF?=
 =?utf-8?B?OVE9PQ==?=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SL2PR06MB3082.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6ab30851-031f-469f-73b5-08d9ef5b2afa
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Feb 2022 01:41:48.3161
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: fYwai20+OBS3ibqU/l+iaNIA5hOEXoZPBj1zj3uSvEsBIMpWKxEJan80CVtyXohqi7yQF6XOy3ruUEsVXAclRA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYAPR06MB2094

wqAKPj5PbiBUaHUsIEZlYiAxMCwgMjAyMiBhdCAwNjozMDoyM1BNIC0wODAwLCBRaW5nIFdhbmcg
d3JvdGU6Cj4+IEZyb206IFdhbmcgUWluZyA8d2FuZ3FpbmdAdml2by5jb20+Cj4+IAo+PiBJdCBp
cyBiZXR0ZXIgdG8gdXNlIHRpbWVfaXNfeHh4KCkgZGlyZWN0bHkgaW5zdGVhZCBvZiBqaWZmaWVz
IGp1ZGdtZW50Cj4+IGZvciB1bmRlcnN0YW5kaW5nLgo+Cj5IaSBXYW5nLAo+Cj4ianVkZ2VtZW50
IiBkb2Vzbid0IHJlYWxseSBtYWtlIHNlbnNlIGFzIGEgZGVzY3JpcHRpb24gdG8gYW4gRW5nbGlz
aAo+c3BlYWtlci7CoCBUaGUgZm9sbG93aW5nIGEgY29tbWl0IGRlc3JpcHRpb24gKGZvciBhbGwg
b2YgdGhlc2Ugc2VyaWVzKQo+aXMgcHJvYmFibHkgZ29pbmcgdG8gYmUgYSBiaXQgbW9yZSB1bmRl
cnN0YWJsZToKPgo+VXNlIHRoZSBoZWxwZXIgZnVuY3Rpb24gdGltZV9pc197YmVmb3JlLGFmdGVy
fV9qaWZmaWVzKCkgdG8gaW1wcm92ZQo+Y29kZSByZWFkYWJpbGl0eS4KPgo+Q2hlZXJzLAo+Cj7C
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAtIFRlZAoKSSBzZWUsIGl0IHdpbGwg
YmUgY29ycmVjdGVkIGluIFYzLgpJJ2xsIHdhaXQgYSBmZXcgZGF5cyBpZiB0aGVyZSBhcmUgYW55
IG90aGVyIGRpc2FncmVlbWVudHMuCgpUaGFua3MsClFpbmc=


From xen-devel-bounces@lists.xenproject.org Mon Feb 14 02:56:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 02:56:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271057.465383 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJRXW-0003Y4-T0; Mon, 14 Feb 2022 02:56:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271057.465383; Mon, 14 Feb 2022 02:56:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJRXW-0003Xx-Pm; Mon, 14 Feb 2022 02:56:34 +0000
Received: by outflank-mailman (input) for mailman id 271057;
 Mon, 14 Feb 2022 02:56:33 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJRXV-0003Xn-9n; Mon, 14 Feb 2022 02:56:33 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJRXV-0001tp-7E; Mon, 14 Feb 2022 02:56:33 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJRXU-00043B-Tm; Mon, 14 Feb 2022 02:56:32 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nJRXU-0006sL-Rr; Mon, 14 Feb 2022 02:56:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=VHPI7oqzNM/tl+i1qFvWjysJCgL8t3ORB7Mbr0Q3bPA=; b=oMhvTEkjbaBQdfCf+vDk/10vS7
	qtXWQqnPU3S3aXw4fwIPrcKdA8zcx0kMbbLvYZif1Vc7gztHBHUgiCF4z/1gAOBKWv4d2gIjrdTX3
	ToBXckpQACFdfn7HEyCSp7WOPjHDlowaxSdRaX6G66Ie74FoX1xlScFM/T6wrPaFC1ng=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168102-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-5.4 test] 168102: trouble: blocked/broken/fail/pass
X-Osstest-Failures:
    linux-5.4:build-arm64:<job status>:broken:regression
    linux-5.4:build-arm64-pvops:<job status>:broken:regression
    linux-5.4:build-arm64-xsm:<job status>:broken:regression
    linux-5.4:build-arm64-xsm:host-install(4):broken:regression
    linux-5.4:build-arm64-pvops:host-install(4):broken:regression
    linux-5.4:build-arm64:host-install(4):broken:regression
    linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-arm64-arm64-examine:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-xl:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking
    linux-5.4:build-arm64-libvirt:build-check(1):blocked:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=52871671099d1bb3fca5ed076029e4b937bfc053
X-Osstest-Versions-That:
    linux=76fd334f07cc11e047c2237a19b2cf8b1f653ba2
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 14 Feb 2022 02:56:32 +0000

flight 168102 linux-5.4 real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168102/

Failures and problems with tests :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-arm64                     <job status>                 broken
 build-arm64-pvops               <job status>                 broken
 build-arm64-xsm                 <job status>                 broken
 build-arm64-xsm               4 host-install(4)        broken REGR. vs. 168060
 build-arm64-pvops             4 host-install(4)        broken REGR. vs. 168060
 build-arm64                   4 host-install(4)        broken REGR. vs. 168060

Tests which are failing intermittently (not blocking):
 test-armhf-armhf-xl-rtds     18 guest-start/debian.repeat  fail pass in 168093

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-examine      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl           1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit1   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit2   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-seattle   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-thunderx  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-vhd       1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-xsm       1 build-check(1)               blocked  n/a
 build-arm64-libvirt           1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168060
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168060
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168060
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168060
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168060
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168060
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168060
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168060
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168060
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168060
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168060
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168060
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                52871671099d1bb3fca5ed076029e4b937bfc053
baseline version:
 linux                76fd334f07cc11e047c2237a19b2cf8b1f653ba2

Last test of basis   168060  2022-02-08 17:43:16 Z    5 days
Testing same since   168084  2022-02-11 08:43:38 Z    2 days    7 attempts

------------------------------------------------------------
People who touched revisions under test:
  Florian Fainelli <f.fainelli@gmail.com>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Guenter Roeck <linux@roeck-us.net>
  Jon Hunter <jonathanh@nvidia.com>
  Jon Maloy <jmaloy@redhat.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Linux Kernel Functional Testing <lkft@linaro.org>
  Shuah Khan <skhan@linuxfoundation.org>
  Slade Watkins <slade@sladewatkins.com>
  Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
  Ulf Hansson <ulf.hansson@linaro.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              broken  
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  broken  
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          blocked 
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            broken  
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          blocked 
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      blocked 
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  blocked 
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  blocked 
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     blocked 
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 blocked 
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      blocked 
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary

broken-job build-arm64 broken
broken-job build-arm64-pvops broken
broken-job build-arm64-xsm broken
broken-step build-arm64-xsm host-install(4)
broken-step build-arm64-pvops host-install(4)
broken-step build-arm64 host-install(4)
broken-job build-arm64-xsm broken
broken-job build-arm64 broken
broken-job build-arm64-pvops broken

Not pushing.

------------------------------------------------------------
commit 52871671099d1bb3fca5ed076029e4b937bfc053
Author: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date:   Fri Feb 11 09:07:52 2022 +0100

    Linux 5.4.179
    
    Link: https://lore.kernel.org/r/20220209191248.688351316@linuxfoundation.org
    Tested-by: Shuah Khan <skhan@linuxfoundation.org>
    Tested-by: Florian Fainelli <f.fainelli@gmail.com>
    Tested-by: Jon Hunter <jonathanh@nvidia.com>
    Tested-by: Linux Kernel Functional Testing <lkft@linaro.org>
    Tested-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
    Tested-by: Slade Watkins <slade@sladewatkins.com>
    Tested-by: Guenter Roeck <linux@roeck-us.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

commit d692e3406e052dbf9f6d9da0cba36cb763272529
Author: Jon Maloy <jmaloy@redhat.com>
Date:   Sat Feb 5 14:11:18 2022 -0500

    tipc: improve size validations for received domain records
    
    commit 9aa422ad326634b76309e8ff342c246800621216 upstream.
    
    The function tipc_mon_rcv() allows a node to receive and process
    domain_record structs from peer nodes to track their views of the
    network topology.
    
    This patch verifies that the number of members in a received domain
    record does not exceed the limit defined by MAX_MON_DOMAIN, something
    that may otherwise lead to a stack overflow.
    
    tipc_mon_rcv() is called from the function tipc_link_proto_rcv(), where
    we are reading a 32 bit message data length field into a uint16.  To
    avert any risk of bit overflow, we add an extra sanity check for this in
    that function.  We cannot see that happen with the current code, but
    future designers being unaware of this risk, may introduce it by
    allowing delivery of very large (> 64k) sk buffers from the bearer
    layer.  This potential problem was identified by Eric Dumazet.
    
    This fixes CVE-2022-0435
    
    Reported-by: Samuel Page <samuel.page@appgate.com>
    Reported-by: Eric Dumazet <edumazet@google.com>
    Fixes: 35c55c9877f8 ("tipc: add neighbor monitoring framework")
    Signed-off-by: Jon Maloy <jmaloy@redhat.com>
    Reviewed-by: Xin Long <lucien.xin@gmail.com>
    Reviewed-by: Samuel Page <samuel.page@appgate.com>
    Reviewed-by: Eric Dumazet <edumazet@google.com>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

commit 3a0a7ec5574b510b067cfc734b8bdb6564b31d4e
Author: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date:   Thu Jan 27 08:16:38 2022 +0100

    moxart: fix potential use-after-free on remove path
    
    commit bd2db32e7c3e35bd4d9b8bbff689434a50893546 upstream.
    
    It was reported that the mmc host structure could be accessed after it
    was freed in moxart_remove(), so fix this by saving the base register of
    the device and using it instead of the pointer dereference.
    
    Cc: Ulf Hansson <ulf.hansson@linaro.org>
    Cc: Xiyu Yang <xiyuyang19@fudan.edu.cn>
    Cc: Xin Xiong <xiongx18@fudan.edu.cn>
    Cc: Xin Tan <tanxin.ctf@gmail.com>
    Cc: Tony Lindgren <tony@atomide.com>
    Cc: Yang Li <yang.lee@linux.alibaba.com>
    Cc: linux-mmc@vger.kernel.org
    Cc: stable <stable@vger.kernel.org>
    Reported-by: whitehat002 <hackyzh002@gmail.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Link: https://lore.kernel.org/r/20220127071638.4057899-1-gregkh@linuxfoundation.org
    Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>


From xen-devel-bounces@lists.xenproject.org Mon Feb 14 03:21:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 03:21:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271071.465414 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJRvQ-0007UW-3h; Mon, 14 Feb 2022 03:21:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271071.465414; Mon, 14 Feb 2022 03:21:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJRvP-0007Rd-RL; Mon, 14 Feb 2022 03:21:15 +0000
Received: by outflank-mailman (input) for mailman id 271071;
 Mon, 14 Feb 2022 03:21:14 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=aDlx=S5=arm.com=Penny.Zheng@srs-se1.protection.inumbo.net>)
 id 1nJRvO-0007B5-CV
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 03:21:14 +0000
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur03on0628.outbound.protection.outlook.com
 [2a01:111:f400:fe09::628])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 285dd3ec-8d45-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 04:21:12 +0100 (CET)
Received: from DB6PR0801CA0054.eurprd08.prod.outlook.com (2603:10a6:4:2b::22)
 by VI1PR0801MB2015.eurprd08.prod.outlook.com (2603:10a6:800:8b::8)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.15; Mon, 14 Feb
 2022 03:21:09 +0000
Received: from DB5EUR03FT006.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:4:2b:cafe::c2) by DB6PR0801CA0054.outlook.office365.com
 (2603:10a6:4:2b::22) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11 via Frontend
 Transport; Mon, 14 Feb 2022 03:21:08 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT006.mail.protection.outlook.com (10.152.20.106) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4975.11 via Frontend Transport; Mon, 14 Feb 2022 03:21:08 +0000
Received: ("Tessian outbound 1f399c739551:v113");
 Mon, 14 Feb 2022 03:21:08 +0000
Received: from c0aeb5dd910e.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 2FE714F8-BF9D-4F72-BD1C-88F2E3E17C2C.1; 
 Mon, 14 Feb 2022 03:21:01 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c0aeb5dd910e.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 14 Feb 2022 03:21:01 +0000
Received: from AM6PR08CA0010.eurprd08.prod.outlook.com (2603:10a6:20b:b2::22)
 by AM6PR08MB4834.eurprd08.prod.outlook.com (2603:10a6:20b:c9::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Mon, 14 Feb
 2022 03:20:59 +0000
Received: from AM5EUR03FT018.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:b2:cafe::ac) by AM6PR08CA0010.outlook.office365.com
 (2603:10a6:20b:b2::22) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.15 via Frontend
 Transport; Mon, 14 Feb 2022 03:20:59 +0000
Received: from nebula.arm.com (40.67.248.234) by
 AM5EUR03FT018.mail.protection.outlook.com (10.152.16.114) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.4975.11 via Frontend Transport; Mon, 14 Feb 2022 03:20:59 +0000
Received: from AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) by AZ-NEU-EX03.Arm.com
 (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2308.20; Mon, 14 Feb
 2022 03:21:02 +0000
Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX01.Emea.Arm.com
 (10.251.26.4) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.20; Mon, 14
 Feb 2022 03:20:56 +0000
Received: from penny.shanghai.arm.com (10.169.188.91) by mail.arm.com
 (10.251.24.31) with Microsoft SMTP Server id 15.1.2308.20 via Frontend
 Transport; Mon, 14 Feb 2022 03:20:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 285dd3ec-8d45-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=2d0zlUHuPGVdtqU2Zxo5Ydvr8hkysX87Lzm7MZgBpwE=;
 b=GIQPPv+IoohPF5PVyWHV8YnIOtdHsMpzbP7sneM/6n0t2gU2ANA+H4QVKzcsFNcOPIW8jM5P1EnMGGkg/Epgth6l03fXaDiKC4neO6HKMNf589CHR1vipPaD2Sqk/bKVyzcWntQmu8lCJAwyp5kaAMbdBGwese4+uP1C+PbBh6o=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 0c811310ce51801b
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=mjn970oYqCajI24+Nn48qG+Gg/BAG6Jow34nhBv28T0fwmm5KuHgh8Np6JEZpL1d7w9CkJUArqCAoH/4JTVhdbcJhlOfmlrWuhLSY82PMy6Qy/7eN1IcKuGi87nyBprdNLnOwWe+kUpnmxEgDVTsspWgn171IL+EmwP+G6ckTGKuoQxAqRsm3K0PhKxuaPPbyN72f9Z3sBl7TiOWY8uzkezfkbLsXJfJmMX8if4EOfu/ANz+kd3IKxeenQSVGuDdt5ArUVRXowlvIs2oNOyeFT3ejpRT/ucc7IZDH/Qaa35wWxCkOyGWEENQag9aOfcYJ/+Keyn/TPJoL/VLPeFi4w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=2d0zlUHuPGVdtqU2Zxo5Ydvr8hkysX87Lzm7MZgBpwE=;
 b=YeCTwQp3olGEcJtgzoRwU2Q9eYUdkqd9ahcMkVYoNqH20iuFBFb3ctA80tNoKI2SF4+YoXysi21VFfFi4X2o0fwJmQdZwm8wI9xXmzr8eyCu5HpTjG1gr/KS1ryVrBQ93OrAL+y67LTcUHEUzHzMfZCdr5jsrCs3KFG4FsntVtLvriHUTfr+mNfmgOkIYE+ZRmd5oRwfleIA8jxPwzZv1HySCEy0u90OHzi6x6r84ewQ4ulwiXA6qn0OsI5EIvYSaWb4PUm2jXNgNa1X3sNwiy5jpGlq4oVowytP/UhsCY/QgLALlt+LTibk6/AlsUBTwTPq/6V5mos8YlmxBIGyuw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=2d0zlUHuPGVdtqU2Zxo5Ydvr8hkysX87Lzm7MZgBpwE=;
 b=GIQPPv+IoohPF5PVyWHV8YnIOtdHsMpzbP7sneM/6n0t2gU2ANA+H4QVKzcsFNcOPIW8jM5P1EnMGGkg/Epgth6l03fXaDiKC4neO6HKMNf589CHR1vipPaD2Sqk/bKVyzcWntQmu8lCJAwyp5kaAMbdBGwese4+uP1C+PbBh6o=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com;
From: Penny Zheng <penny.zheng@arm.com>
To: <xen-devel@lists.xenproject.org>, <sstabellini@kernel.org>,
	<julien@xen.org>
CC: <Bertrand.Marquis@arm.com>, <Wei.Chen@arm.com>
Subject: [PATCH v6 02/11] xen: introduce CDF_directmap
Date: Mon, 14 Feb 2022 03:19:47 +0000
Message-ID: <20220214031956.3726764-3-penny.zheng@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220214031956.3726764-1-penny.zheng@arm.com>
References: <20220214031956.3726764-1-penny.zheng@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
X-EOPAttributedMessage: 1
X-MS-Office365-Filtering-Correlation-Id: 7c63ec18-bcc2-488a-3a00-08d9ef690af3
X-MS-TrafficTypeDiagnostic:
	AM6PR08MB4834:EE_|DB5EUR03FT006:EE_|VI1PR0801MB2015:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0801MB20155156AE9701850C9E962DF7339@VI1PR0801MB2015.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:213;OLM:213;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 p3bzuHgkvDc1pwwpyCUAydWwVYR+bobpg7XCrCpxjVrHtjTFIhaA8rI4lwpJHgToCDYv+7B/CAVxpLYae8uszExuvK7H/UhD+9XHXqy2TqT+6JMMheCMoUGWVPFLXLptWdhY7dOlCE5WsS+YXd1HNrKIXfWCvkkH4bCuZqBJDO1C2yggH/FzmMRsn0atMpbLozGfkWQHdxkZCR8GCM1dtgprgPxRlrr6cW2Z6sWyC2b55p18Icvxykfh2whzTU36wTlrh2uLPBPbmzEBCXonSVctUNj9QiAeI5yE8YE3c0uPXorgjQLcRF0B/vXW7WF//dopxFuDrcdgmFihyklewQ0dRI5xjVKTHkQj3MsGHc/6h/NO8spyWAHy9xGnxf8ciDlREInzXnx7jcT81CXhNyaS8A+xAb8LS/ozcWVskEn+6AliJ9A++6YOfWsqnaHX0mFbsU8e9729BXK/7QBATr14pLBjraL00t3w6zWGz3Om7k3UGIpCHwK36cvixImVzmARLlJ/RivQeNK7jIkSjJWDNxnR0qXpSbRRCKeX4Wj/k4EN2sRaMNjK2Jil+yHCABntLPT2quBAQ77z4oqbQMk3fxGF6/4Bw/I9/jGf1l9767mYXFtpCaAzX6e3scwqxYMW06vi2ClW2D+Z8bt/ZtTQ9s394VZDfkEDjuwFNU6mzFhU9tVB3BN5EvHR8lL1lrdqDBAnxpnQ4MBPbgM/TLEmIKp+8qlZUjTKiLZpmCo=
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(86362001)(26005)(7696005)(186003)(44832011)(36860700001)(508600001)(336012)(426003)(6666004)(2616005)(36756003)(83380400001)(1076003)(47076005)(82310400004)(356005)(8676002)(81166007)(316002)(54906003)(110136005)(70586007)(70206006)(4326008)(2906002)(8936002)(5660300002)(40460700003)(21314003)(36900700001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4834
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT006.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	b8e73cd8-c584-4be0-41a5-08d9ef690568
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	SpDAuX+OUEqdbZcTcSxXLcGF9ML5ITITA48pBInlhM4aqO/KAVkOpM3BHCUw2u6TlzxcmLzTeoMK6izIVRUz4GDOlTmDt/QXm62ogBtYly2T05qxjaILjIyRASEux211gg/0Zw6Yq3cD0EqmLih1+rgEsx5ZBB7qyxb4rKvtYtBKm43thhc+txKuegzS8YCeSVqTEQbwNBd+KOKZPmgTjorNlshY9A4bfL/tREiS7RDKulZLsCyCfaZ57iwlJ9oetxOZgHCJNL7qVVzzxEIBsQDCCs60ZZMr1e9DBZfFTXTRECXE+0x8IKbUpCbtqM2d/G5AVJ4AwjQ321uLjfbtT6E/sIxlnqq24DRnztK6SNUGGSk/E8CPPEjUppPbnXkNZLuclguiZN38MX84na140hefxNNNoTRsE2kvO2mFk2sp+JGTZ1HJ6mfiMS7y0rXIDTrYOvvlGMHFCUb75AjyDo3SrNAusg2c4AyW1gtLcofFQta437pvpONlAzyvPq+IHD+raNaIwkKOFuSEQZt/RJuubCv2X0Jo5mEDGVVISmTcyHPVMBT/yX4mm7EDyscPkQneuFzKy19SkUEYkkZtke/xsTzlsdZjp+JQRS/Zir7WAl3RiYeCq8cmac3wu9f9IXIu9bqIiorFcQZ2MvEoHA1aOYXPvJN5Mnh+NixaVek=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(86362001)(70586007)(110136005)(54906003)(36756003)(4326008)(70206006)(316002)(8676002)(508600001)(5660300002)(81166007)(6666004)(8936002)(186003)(26005)(83380400001)(7696005)(36860700001)(44832011)(2906002)(47076005)(82310400004)(426003)(1076003)(2616005)(336012)(21314003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2022 03:21:08.3796
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 7c63ec18-bcc2-488a-3a00-08d9ef690af3
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT006.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB2015

From: Stefano Stabellini <sstabellini@kernel.org>

This commit introduces a new arm-specific flag CDF_directmap to specify
that a domain should have its memory direct-map(guest physical address
== host physical address) at domain creation.

Also, add a directmap flag under struct arch_domain and use it to
reimplement is_domain_direct_mapped.

For now, direct-map is only available when statically allocated memory is
used for the domain, that is, "xen,static-mem" must be also defined in the
domain configuration.

Signed-off-by: Stefano Stabellini <sstabellini@kernel.org>
Signed-off-by: Penny Zheng <penny.zheng@arm.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
Tested-by: Stefano Stabellini <sstabellini@kernel.org>
---
CC: andrew.cooper3@citrix.com
CC: jbeulich@suse.com
CC: George Dunlap <George.Dunlap@eu.citrix.com>
CC: Ian Jackson <ian.jackson@eu.citrix.com>
CC: Wei Liu <wl@xen.org>
CC: "Roger Pau Monné" <roger.pau@citrix.com>
---
v2 changes
- remove the introduce of internal flag
- remove flag direct_map since we already store this flag in d->options
- Refine is_domain_direct_mapped to check whether the flag
XEN_DOMCTL_CDF_directmap is set
- reword "1:1 direct-map" to just "direct-map"
---
v3 changes
- move flag back to xen/include/xen/domain.h, to let it be only available for
domain created by XEN.
- name it with extra "INTERNAL" and add comments to warn developers not
to accidently use its bitfield when introducing new XEN_DOMCTL_CDF_xxx flag.
- reject this flag in x86'es arch_sanitise_domain_config()
---
v4 changes
- introduce new internal flag CDF_directmap
- add a directmap flag under struct arch_domain and use it to
reimplement is_domain_direct_mapped.
- expand arch_domain_create to include internal-only parameter "const unsigned
int flags"
---
v5 changes
- remove const constraint
---
v6 changes
- comment and coding style fix
- protect CDF_directmap with #ifdef CONFIG_ARM
---
 docs/misc/arm/device-tree/booting.txt |  6 ++++++
 xen/arch/arm/domain.c                 |  5 ++++-
 xen/arch/arm/domain_build.c           | 14 ++++++++++++--
 xen/arch/arm/include/asm/domain.h     |  5 +++--
 xen/arch/x86/domain.c                 |  3 ++-
 xen/common/domain.c                   |  2 +-
 xen/include/xen/domain.h              |  7 ++++++-
 7 files changed, 34 insertions(+), 8 deletions(-)

diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt
index 71895663a4..a94125394e 100644
--- a/docs/misc/arm/device-tree/booting.txt
+++ b/docs/misc/arm/device-tree/booting.txt
@@ -182,6 +182,12 @@ with the following properties:
     Both #address-cells and #size-cells need to be specified because
     both sub-nodes (described shortly) have reg properties.
 
+- direct-map
+
+    Only available when statically allocated memory is used for the domain.
+    An empty property to request the memory of the domain to be
+    direct-map (guest physical address == physical address).
+
 Under the "xen,domain" compatible node, one or more sub-nodes are present
 for the DomU kernel and ramdisk.
 
diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
index 92a6c509e5..8110c1df86 100644
--- a/xen/arch/arm/domain.c
+++ b/xen/arch/arm/domain.c
@@ -692,7 +692,8 @@ int arch_sanitise_domain_config(struct xen_domctl_createdomain *config)
 }
 
 int arch_domain_create(struct domain *d,
-                       struct xen_domctl_createdomain *config)
+                       struct xen_domctl_createdomain *config,
+                       unsigned int flags)
 {
     int rc, count = 0;
 
@@ -708,6 +709,8 @@ int arch_domain_create(struct domain *d,
     ioreq_domain_init(d);
 #endif
 
+    d->arch.directmap = flags & CDF_directmap;
+
     /* p2m_init relies on some value initialized by the IOMMU subsystem */
     if ( (rc = iommu_domain_init(d, config->iommu_opts)) != 0 )
         goto fail;
diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index 0fab8604de..6467e8ee32 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -3029,10 +3029,20 @@ void __init create_domUs(void)
             .max_maptrack_frames = -1,
             .grant_opts = XEN_DOMCTL_GRANT_version(opt_gnttab_max_version),
         };
+        unsigned int flags = 0U;
 
         if ( !dt_device_is_compatible(node, "xen,domain") )
             continue;
 
+        if ( dt_property_read_bool(node, "direct-map") )
+        {
+            if ( !IS_ENABLED(CONFIG_STATIC_MEMORY) || !dt_find_property(node, "xen,static-mem", NULL) )
+                panic("direct-map is not valid for domain %s without static allocation.\n",
+                      dt_node_name(node));
+
+            flags |= CDF_directmap;
+        }
+
         if ( !dt_property_read_u32(node, "cpus", &d_cfg.max_vcpus) )
             panic("Missing property 'cpus' for domain %s\n",
                   dt_node_name(node));
@@ -3058,7 +3068,7 @@ void __init create_domUs(void)
          * very important to use the pre-increment operator to call
          * domain_create() with a domid > 0. (domid == 0 is reserved for Dom0)
          */
-        d = domain_create(++max_init_domid, &d_cfg, 0);
+        d = domain_create(++max_init_domid, &d_cfg, flags);
         if ( IS_ERR(d) )
             panic("Error creating domain %s\n", dt_node_name(node));
 
@@ -3160,7 +3170,7 @@ void __init create_dom0(void)
     if ( iommu_enabled )
         dom0_cfg.flags |= XEN_DOMCTL_CDF_iommu;
 
-    dom0 = domain_create(0, &dom0_cfg, CDF_privileged);
+    dom0 = domain_create(0, &dom0_cfg, CDF_privileged | CDF_directmap);
     if ( IS_ERR(dom0) || (alloc_dom0_vcpu0(dom0) == NULL) )
         panic("Error creating domain 0\n");
 
diff --git a/xen/arch/arm/include/asm/domain.h b/xen/arch/arm/include/asm/domain.h
index 9b3647587a..aabe942cde 100644
--- a/xen/arch/arm/include/asm/domain.h
+++ b/xen/arch/arm/include/asm/domain.h
@@ -29,8 +29,7 @@ enum domain_type {
 #define is_64bit_domain(d) (0)
 #endif
 
-/* The hardware domain has always its memory direct mapped. */
-#define is_domain_direct_mapped(d) is_hardware_domain(d)
+#define is_domain_direct_mapped(d) (d)->arch.directmap
 
 struct vtimer {
     struct vcpu *v;
@@ -89,6 +88,8 @@ struct arch_domain
 #ifdef CONFIG_TEE
     void *tee;
 #endif
+
+    bool directmap;
 }  __cacheline_aligned;
 
 struct arch_vcpu
diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c
index ef1812dc14..9835f90ea0 100644
--- a/xen/arch/x86/domain.c
+++ b/xen/arch/x86/domain.c
@@ -722,7 +722,8 @@ static bool emulation_flags_ok(const struct domain *d, uint32_t emflags)
 }
 
 int arch_domain_create(struct domain *d,
-                       struct xen_domctl_createdomain *config)
+                       struct xen_domctl_createdomain *config,
+                       unsigned int flags)
 {
     bool paging_initialised = false;
     uint32_t emflags;
diff --git a/xen/common/domain.c b/xen/common/domain.c
index a79103e04a..3742322d22 100644
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -659,7 +659,7 @@ struct domain *domain_create(domid_t domid,
         radix_tree_init(&d->pirq_tree);
     }
 
-    if ( (err = arch_domain_create(d, config)) != 0 )
+    if ( (err = arch_domain_create(d, config, flags)) != 0 )
         goto fail;
     init_status |= INIT_arch;
 
diff --git a/xen/include/xen/domain.h b/xen/include/xen/domain.h
index cfb0b47f13..24eb4cc7d3 100644
--- a/xen/include/xen/domain.h
+++ b/xen/include/xen/domain.h
@@ -31,6 +31,10 @@ void arch_get_domain_info(const struct domain *d,
 /* CDF_* constant. Internal flags for domain creation. */
 /* Is this a privileged domain? */
 #define CDF_privileged           (1U << 0)
+#ifdef CONFIG_ARM
+/* Should domain memory be directly mapped? */
+#define CDF_directmap            (1U << 1)
+#endif
 
 /*
  * Arch-specifics.
@@ -65,7 +69,8 @@ int map_vcpu_info(struct vcpu *v, unsigned long gfn, unsigned offset);
 void unmap_vcpu_info(struct vcpu *v);
 
 int arch_domain_create(struct domain *d,
-                       struct xen_domctl_createdomain *config);
+                       struct xen_domctl_createdomain *config,
+                       unsigned int flags);
 
 void arch_domain_destroy(struct domain *d);
 
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 03:21:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 03:21:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271072.465438 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJRvS-0008EL-I4; Mon, 14 Feb 2022 03:21:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271072.465438; Mon, 14 Feb 2022 03:21:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJRvS-0008EA-DD; Mon, 14 Feb 2022 03:21:18 +0000
Received: by outflank-mailman (input) for mailman id 271072;
 Mon, 14 Feb 2022 03:21:16 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=aDlx=S5=arm.com=Penny.Zheng@srs-se1.protection.inumbo.net>)
 id 1nJRvQ-0007B4-JH
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 03:21:16 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04on062b.outbound.protection.outlook.com
 [2a01:111:f400:fe0c::62b])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2a8a1568-8d45-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 04:21:15 +0100 (CET)
Received: from AS8P189CA0023.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:31f::31)
 by VI1PR08MB3647.eurprd08.prod.outlook.com (2603:10a6:803:85::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.17; Mon, 14 Feb
 2022 03:21:11 +0000
Received: from VE1EUR03FT011.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:31f:cafe::eb) by AS8P189CA0023.outlook.office365.com
 (2603:10a6:20b:31f::31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.15 via Frontend
 Transport; Mon, 14 Feb 2022 03:21:11 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT011.mail.protection.outlook.com (10.152.18.134) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4975.11 via Frontend Transport; Mon, 14 Feb 2022 03:21:10 +0000
Received: ("Tessian outbound 741ca6c82739:v113");
 Mon, 14 Feb 2022 03:21:10 +0000
Received: from 30609cc8816b.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 EC72F650-BF67-4D34-838E-9C43BA604C61.1; 
 Mon, 14 Feb 2022 03:21:03 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 30609cc8816b.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 14 Feb 2022 03:21:03 +0000
Received: from AS9P194CA0027.EURP194.PROD.OUTLOOK.COM (2603:10a6:20b:46d::22)
 by PR3PR08MB5818.eurprd08.prod.outlook.com (2603:10a6:102:8b::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Mon, 14 Feb
 2022 03:21:02 +0000
Received: from AM5EUR03FT049.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:46d:cafe::49) by AS9P194CA0027.outlook.office365.com
 (2603:10a6:20b:46d::22) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.15 via Frontend
 Transport; Mon, 14 Feb 2022 03:21:02 +0000
Received: from nebula.arm.com (40.67.248.234) by
 AM5EUR03FT049.mail.protection.outlook.com (10.152.17.130) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.4975.11 via Frontend Transport; Mon, 14 Feb 2022 03:21:02 +0000
Received: from AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) by AZ-NEU-EX04.Arm.com
 (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2308.20; Mon, 14 Feb
 2022 03:21:06 +0000
Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX01.Emea.Arm.com
 (10.251.26.4) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.20; Mon, 14
 Feb 2022 03:21:00 +0000
Received: from penny.shanghai.arm.com (10.169.188.91) by mail.arm.com
 (10.251.24.31) with Microsoft SMTP Server id 15.1.2308.20 via Frontend
 Transport; Mon, 14 Feb 2022 03:21:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2a8a1568-8d45-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=IsRjtoJi/dcXTUUD4SSPKSVxouxZVNwFWUBYcsUvmi8=;
 b=fofnIoQZwPXgw63GyUq5/Z9SuEkZyR+t0eanuA+BQenlPMm+H0d9j5VxEVFHzktHCvvczjJ/AqTq1cQXKJeJKfQigp+ivdKdoIflsW1TwQBPKk6ZIoZrveg72txQlaTgjG0B+gFR7FicHN/lY9F3dv8MLdLdmEgtOp1mYW7L3H0=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 69b00cd927348eea
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=EaLeEkK0a/EteRqRe4DJaluPeRcYh57lMCZj9tJm+fKJ/LM7Bxzs1bTAO0iIcyZrew759ZN1WiUKadDgYPwcHemCgPgfxFvB3XIIeK8YKDS4yAO1kmYvtevTuQHR6wQDZv4SjR7jhbCixvo4wqjHAURF9lcPxKdA+GdnqzMvnyvzkZ4SIWwe/m4K+oDD8MM378v8WFgq+xVxY3/78Qb36TLklGRezlWz6JcfqFTe9K4U+RS3PAYy1bpgXTmJURUSDwb5ujlDcjqTjYf5+Rc7kiQc8mhpsEoahibMwK2Bi/JAq1yvDjaSx8hoNn85IaXZvaBwwo5AuR+0emuW76IiCA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=IsRjtoJi/dcXTUUD4SSPKSVxouxZVNwFWUBYcsUvmi8=;
 b=VfZiKdxkgpR6wowdFIZtdDFqk3j64NyWb1KwlkSnfhVwD3RNcGnvOGOknhWxxmkoQMq9C8wQpM8ZuT9KhMpxcm0V2jItGCfXVKxGmNXRtCHxugcujXGt7UK9su0EzNUABrxCUaGAtKQgWWw07jhjdJOJHooPIibvh8pLI/0cgcFsvzo2l3/wcon4cup7V3TgD2Ih3Rxgs4+zHWLXQVo/UcJQFzINGjZqZQHk8PC4cA2/07vC7/uyaZkxabjzDia+Cz6euzjwxWs9IReXKA0aNpiM2g6T/gonJIcl8veaIr/y2LNQvSKi12R4zGC1G+Aj0GC8r4c/J0seepz3YMXJHA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=IsRjtoJi/dcXTUUD4SSPKSVxouxZVNwFWUBYcsUvmi8=;
 b=fofnIoQZwPXgw63GyUq5/Z9SuEkZyR+t0eanuA+BQenlPMm+H0d9j5VxEVFHzktHCvvczjJ/AqTq1cQXKJeJKfQigp+ivdKdoIflsW1TwQBPKk6ZIoZrveg72txQlaTgjG0B+gFR7FicHN/lY9F3dv8MLdLdmEgtOp1mYW7L3H0=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com;
From: Penny Zheng <penny.zheng@arm.com>
To: <xen-devel@lists.xenproject.org>, <sstabellini@kernel.org>,
	<julien@xen.org>
CC: <Bertrand.Marquis@arm.com>, <Wei.Chen@arm.com>
Subject: [PATCH v6 04/11] xen/arm: introduce new helper parse_static_mem_prop and acquire_static_memory_bank
Date: Mon, 14 Feb 2022 03:19:49 +0000
Message-ID: <20220214031956.3726764-5-penny.zheng@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220214031956.3726764-1-penny.zheng@arm.com>
References: <20220214031956.3726764-1-penny.zheng@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 1
X-MS-Office365-Filtering-Correlation-Id: 35907ce1-104b-4a40-ebb3-08d9ef690c39
X-MS-TrafficTypeDiagnostic:
	PR3PR08MB5818:EE_|VE1EUR03FT011:EE_|VI1PR08MB3647:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR08MB36476A652192D7BBB57DEFB3F7339@VI1PR08MB3647.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:281;OLM:281;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 GD4RcxewPWLK6t3R5KHoKfXnSXNK6oNPvUFLMNkUkt64zcoQddi1VDMe2o4Wfe6ErKDLK59BJeij7HD/In7R4/U/MoLFfr+DzjRzW3u42j6QScuWut7+8zXW5myfEIWWaleqY4cPcUKzIEiZyu5/Kp+gTp49fV9x77Jnb4dN2dr93Y1RIAn/akCuETmHFb8nPJ0YK2DQ+jAbQVEhFOgURtThFZWQUzPPP5tTFGTpjpe4t3RC6BQskqiDIGXBuS2DpNRwb9R3cXjsRl89Q/TnEc360fkLhVofxKzxcNC8czS3eBo1s2CKjdNGeXW0q3xHHp25xAKks0/Zu5Ri3nxbL8+7LwFBsRMASvidJuM/GubiRTGUMJpQPIcw/4+Xt3LuiGiLM8jK5rSSReDFJlmI65cge+8gctG3zepaIbqiMJTHX8uPtlYpsG6W40wBvaUYsswTpYQoeM51XFR10jWmwGwytupGWLxGakn6Qi3vBVF0iUKmNWzrIcP7/1zEU/uSSz8pdbiBjl0bqB9Adr9u7cq1NFUWYaxXF/k0yASahELeq32gJyIVWA/+ndIcDIoPMkbUYmWMyUAbVr331rIf/BJAQDPRd0KJxtISj51TdwZhL0F5RErcpzErK47DPVld2F6NiiYbB+Lux35jyZXRnIWKjFy0YX91a/HY38C0qTQSwgXMK4mIt7htqqKl7Gbpt2600Dew8h63dX9jqW8JDQ==
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(336012)(426003)(36756003)(82310400004)(44832011)(1076003)(186003)(26005)(2906002)(2616005)(47076005)(36860700001)(83380400001)(356005)(81166007)(70586007)(70206006)(4326008)(8676002)(8936002)(6666004)(7696005)(316002)(86362001)(508600001)(40460700003)(54906003)(110136005)(5660300002)(36900700001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5818
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT011.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	9cc47751-86f4-4140-07d5-08d9ef690730
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	MVjfpaaaROgCi2fsfysjOPTc7k/RPswQ8TrtpDrdps5V/oQkKi8Ftm5K5B7T82Gw0YwqDJVCdlPtsDe1TVL0sYQF0PaW6opAgi8scmpHjZYGFfjD9Ma1Vpx52yD7qCRM7HLlk94Oik45jNBVTzoHhILqL7EG+I1NQFo0xDtvYwdX89zKkwL03rI2RduBm3UoJQpYmKE3zIiHzOfDC4LcB91RiJg/XVCMU3GBB2yfreN/dN6jKcoiKVJ31kPw09MLPC1tiidcZD1MACvg58ZbBgVUnlNKOOVe7F8Pkn5FYpFdcXMcg/eRgKWke2cDfefgh6XLLYPE9uboKU1doJjE5eO2VO/wXlb4dZO/JTCB7Ws8KfLZHjiEG5Jf0+8eVOkvc2QORP8HzLK8Fbh5wk3c4Xt05ElSV+IppFqqyKWdi9UVCZUrW0Y8jzpGMfq8HpfHgLaj8ZJEtTI7jcdxRSo37kjpJYn0RNBYh7VO3h19SBcJdPe44s5eEyhNCJ205dgsdlCCVBTVa58b/NlGeFkPYR8F9NCK7pNUuDTgHsoXHTmPN2X6rwpnKCjJjO8z0mWIndyeTE2fd2ScLpcW6OJYE5T397fuC3e//8Z02YYQjkGTIwRX7K6bdXz3+LIpIgBKj50MVxGKR5vUh9ljaQPRNg==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(4326008)(70586007)(70206006)(36756003)(5660300002)(8676002)(86362001)(8936002)(47076005)(82310400004)(83380400001)(81166007)(7696005)(54906003)(110136005)(2616005)(44832011)(316002)(2906002)(6666004)(26005)(186003)(1076003)(426003)(508600001)(36860700001)(336012);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2022 03:21:10.4269
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 35907ce1-104b-4a40-ebb3-08d9ef690c39
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT011.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3647

Later, we will introduce assign_static_memory_11 for allocating static
memory for direct-map domains, and it will share a lot common codes with
the existing allocate_static_memory.

In order not to bring a lot of duplicate codes, and also to make the whole
code more readable, this commit extracts common codes into two new helpers
parse_static_mem_prop and acquire_static_memory_bank.

Signed-off-by: Penny Zheng <penny.zheng@arm.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
Tested-by: Stefano Stabellini <sstabellini@kernel.org>
---
v3 changes:
- new commit, split from the original "[PATCH v2 2/6] xen/arm: introduce
direct-map for domUs"
---
v4 changes
- explain briefly in the commit message why we want to do device assignment
without IOMMU.
---
v5 changes
- fix coding style
---
v6 changes
- no changes
---
 xen/arch/arm/domain_build.c | 100 +++++++++++++++++++++++-------------
 1 file changed, 64 insertions(+), 36 deletions(-)

diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index c1e8c99f64..e61d2d53ba 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -509,12 +509,69 @@ static bool __init append_static_memory_to_bank(struct domain *d,
     return true;
 }
 
+static mfn_t __init acquire_static_memory_bank(struct domain *d,
+                                               const __be32 **cell,
+                                               u32 addr_cells, u32 size_cells,
+                                               paddr_t *pbase, paddr_t *psize)
+{
+    mfn_t smfn;
+    int res;
+
+    device_tree_get_reg(cell, addr_cells, size_cells, pbase, psize);
+    ASSERT(IS_ALIGNED(*pbase, PAGE_SIZE) && IS_ALIGNED(*psize, PAGE_SIZE));
+    if ( PFN_DOWN(*psize) > UINT_MAX )
+    {
+        printk(XENLOG_ERR "%pd: static memory size too large: %#"PRIpaddr,
+               d, *psize);
+        return INVALID_MFN;
+    }
+
+    smfn = maddr_to_mfn(*pbase);
+    res = acquire_domstatic_pages(d, smfn, PFN_DOWN(*psize), 0);
+    if ( res )
+    {
+        printk(XENLOG_ERR
+               "%pd: failed to acquire static memory: %d.\n", d, res);
+        return INVALID_MFN;
+    }
+
+    return smfn;
+}
+
+static int __init parse_static_mem_prop(const struct dt_device_node *node,
+                                        u32 *addr_cells, u32 *size_cells,
+                                        int *length, const __be32 **cell)
+{
+    const struct dt_property *prop;
+
+    prop = dt_find_property(node, "xen,static-mem", NULL);
+    if ( !dt_property_read_u32(node, "#xen,static-mem-address-cells",
+                               addr_cells) )
+    {
+        printk(XENLOG_ERR
+               "failed to read \"#xen,static-mem-address-cells\".\n");
+        return -EINVAL;
+    }
+
+    if ( !dt_property_read_u32(node, "#xen,static-mem-size-cells",
+                               size_cells) )
+    {
+        printk(XENLOG_ERR
+               "failed to read \"#xen,static-mem-size-cells\".\n");
+        return -EINVAL;
+    }
+
+    *cell = (const __be32 *)prop->value;
+    *length = prop->length;
+
+    return 0;
+}
+
 /* Allocate memory from static memory as RAM for one specific domain d. */
 static void __init allocate_static_memory(struct domain *d,
                                           struct kernel_info *kinfo,
                                           const struct dt_device_node *node)
 {
-    const struct dt_property *prop;
     u32 addr_cells, size_cells, reg_cells;
     unsigned int nr_banks, gbank, bank = 0;
     const uint64_t rambase[] = GUEST_RAM_BANK_BASES;
@@ -523,24 +580,10 @@ static void __init allocate_static_memory(struct domain *d,
     u64 tot_size = 0;
     paddr_t pbase, psize, gsize;
     mfn_t smfn;
-    int res;
-
-    prop = dt_find_property(node, "xen,static-mem", NULL);
-    if ( !dt_property_read_u32(node, "#xen,static-mem-address-cells",
-                               &addr_cells) )
-    {
-        printk(XENLOG_ERR
-               "%pd: failed to read \"#xen,static-mem-address-cells\".\n", d);
-        goto fail;
-    }
+    int length;
 
-    if ( !dt_property_read_u32(node, "#xen,static-mem-size-cells",
-                               &size_cells) )
-    {
-        printk(XENLOG_ERR
-               "%pd: failed to read \"#xen,static-mem-size-cells\".\n", d);
+    if ( parse_static_mem_prop(node, &addr_cells, &size_cells, &length, &cell) )
         goto fail;
-    }
     reg_cells = addr_cells + size_cells;
 
     /*
@@ -551,29 +594,14 @@ static void __init allocate_static_memory(struct domain *d,
     gbank = 0;
     gsize = ramsize[gbank];
     kinfo->mem.bank[gbank].start = rambase[gbank];
-
-    cell = (const __be32 *)prop->value;
-    nr_banks = (prop->length) / (reg_cells * sizeof (u32));
+    nr_banks = length / (reg_cells * sizeof (u32));
 
     for ( ; bank < nr_banks; bank++ )
     {
-        device_tree_get_reg(&cell, addr_cells, size_cells, &pbase, &psize);
-        ASSERT(IS_ALIGNED(pbase, PAGE_SIZE) && IS_ALIGNED(psize, PAGE_SIZE));
-
-        if ( PFN_DOWN(psize) > UINT_MAX )
-        {
-            printk(XENLOG_ERR "%pd: static memory size too large: %#"PRIpaddr,
-                   d, psize);
+        smfn = acquire_static_memory_bank(d, &cell, addr_cells, size_cells,
+                                          &pbase, &psize);
+        if ( mfn_eq(smfn, INVALID_MFN) )
             goto fail;
-        }
-        smfn = maddr_to_mfn(pbase);
-        res = acquire_domstatic_pages(d, smfn, PFN_DOWN(psize), 0);
-        if ( res )
-        {
-            printk(XENLOG_ERR
-                   "%pd: failed to acquire static memory: %d.\n", d, res);
-            goto fail;
-        }
 
         printk(XENLOG_INFO "%pd: STATIC BANK[%u] %#"PRIpaddr"-%#"PRIpaddr"\n",
                d, bank, pbase, pbase + psize);
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 03:21:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 03:21:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271070.465406 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJRvP-0007M6-No; Mon, 14 Feb 2022 03:21:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271070.465406; Mon, 14 Feb 2022 03:21:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJRvP-0007KJ-HR; Mon, 14 Feb 2022 03:21:15 +0000
Received: by outflank-mailman (input) for mailman id 271070;
 Mon, 14 Feb 2022 03:21:14 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=aDlx=S5=arm.com=Penny.Zheng@srs-se1.protection.inumbo.net>)
 id 1nJRvO-0007B4-4f
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 03:21:14 +0000
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur02on0630.outbound.protection.outlook.com
 [2a01:111:f400:fe05::630])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 26eb130a-8d45-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 04:21:10 +0100 (CET)
Received: from DB9PR02CA0024.eurprd02.prod.outlook.com (2603:10a6:10:1d9::29)
 by VE1PR08MB5614.eurprd08.prod.outlook.com (2603:10a6:800:1a8::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.15; Mon, 14 Feb
 2022 03:21:06 +0000
Received: from DB5EUR03FT004.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:1d9:cafe::83) by DB9PR02CA0024.outlook.office365.com
 (2603:10a6:10:1d9::29) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19 via Frontend
 Transport; Mon, 14 Feb 2022 03:21:05 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT004.mail.protection.outlook.com (10.152.20.128) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4975.11 via Frontend Transport; Mon, 14 Feb 2022 03:21:05 +0000
Received: ("Tessian outbound 18e50a6f0513:v113");
 Mon, 14 Feb 2022 03:21:05 +0000
Received: from 1e3b77a573ee.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 9BD198F7-54EC-48D3-892A-28F6A9466F78.1; 
 Mon, 14 Feb 2022 03:20:59 +0000
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 1e3b77a573ee.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 14 Feb 2022 03:20:59 +0000
Received: from AM5PR0502CA0008.eurprd05.prod.outlook.com
 (2603:10a6:203:91::18) by VI1PR08MB3181.eurprd08.prod.outlook.com
 (2603:10a6:803:3f::17) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.15; Mon, 14 Feb
 2022 03:20:56 +0000
Received: from AM5EUR03FT034.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:203:91:cafe::2) by AM5PR0502CA0008.outlook.office365.com
 (2603:10a6:203:91::18) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19 via Frontend
 Transport; Mon, 14 Feb 2022 03:20:55 +0000
Received: from nebula.arm.com (40.67.248.234) by
 AM5EUR03FT034.mail.protection.outlook.com (10.152.16.81) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.4975.11 via Frontend Transport; Mon, 14 Feb 2022 03:20:55 +0000
Received: from AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) by AZ-NEU-EX04.Arm.com
 (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2308.20; Mon, 14 Feb
 2022 03:21:00 +0000
Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX01.Emea.Arm.com
 (10.251.26.4) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.20; Mon, 14
 Feb 2022 03:20:53 +0000
Received: from penny.shanghai.arm.com (10.169.188.91) by mail.arm.com
 (10.251.24.31) with Microsoft SMTP Server id 15.1.2308.20 via Frontend
 Transport; Mon, 14 Feb 2022 03:20:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 26eb130a-8d45-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=KB1S60IihEv8VGYUXws5DWDnmLCtiZ1gCsStIIhUK5E=;
 b=sOoA07eoaC5uOlpPGVmeR2z5sgVr5iWqc6Tv5RyNiOR2nwfnHVlj/BjxKdXKz2zeIi6Jf27o9Oy6paEfSvXc3YOj/PZF6LL/lm3w7FLpEEBsPSRg3U7y9Le9lZqHy7OuMQKJL3RreGD/Na3I8E1agVZau7T5HZI0PIUY31K19Hc=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: f5f60d10bf1e6aaa
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=dkafOOd8VhO2QbtLdJrAULqWM+im+y1uDTqEokvYpTwHFVvJu5NiFrsLe9jGI0moHwYhn/EDcPI0fiuqtFnFHjviLOGpNp8VRmJO+02oU/PDKMXG4aGesmfZUafqUm/2H79QSEP15gNYQUktoaID2Gp77hiXdCjP4Ax9yXIF2p4ms9RUsVA0q8m30R67wS1zq8mzYhDqFHRUgfpDcqBlkqtTKcGJMS+YgFQW79YNxQHS+CYyLV6m13uI1yv+SoGW9dq0zbbgCSlPtCKbWuNRDOBUCFF06xH6ooOzwhtrpfQGIFTUgxMsk6640ZytT5pNu33b4cjtRtA9+McpnWt5kQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=KB1S60IihEv8VGYUXws5DWDnmLCtiZ1gCsStIIhUK5E=;
 b=bDhwU+g9YSIU/VJb7DzeDmC8pywD0rEzlsBeiLWjvKknxzovgcv+40C9fglb1x6ZMpj2kd9Ph0F4F35f8ccpFggk6feSGUOyGKMtdVjCG6kimcuaSBzZBHaSaJ+MuYJAR9coC0NqkE+QUmrS2/x38JVO4c2xgWK4DLuMmNUdEyPTqYLa+K38w4DG0niOV8bBPn6W96Ker0oGws5oPOjknt9pyVfZtIv4r+7T5Du3jMZ1A+vweK+gakn2wxkhv8U7OU+Q1wBSPXuvnCqAi3mEKO7Su/0O/TZvdtVQG6k2tAQkIczJYHCbkfaevZakHInVka6XiuTEUW0j2o7OpnBktA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=KB1S60IihEv8VGYUXws5DWDnmLCtiZ1gCsStIIhUK5E=;
 b=sOoA07eoaC5uOlpPGVmeR2z5sgVr5iWqc6Tv5RyNiOR2nwfnHVlj/BjxKdXKz2zeIi6Jf27o9Oy6paEfSvXc3YOj/PZF6LL/lm3w7FLpEEBsPSRg3U7y9Le9lZqHy7OuMQKJL3RreGD/Na3I8E1agVZau7T5HZI0PIUY31K19Hc=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com;
From: Penny Zheng <penny.zheng@arm.com>
To: <xen-devel@lists.xenproject.org>, <sstabellini@kernel.org>,
	<julien@xen.org>
CC: <Bertrand.Marquis@arm.com>, <Wei.Chen@arm.com>
Subject: [PATCH v6 01/11] xen: introduce internal CDF_xxx flags for domain creation
Date: Mon, 14 Feb 2022 03:19:46 +0000
Message-ID: <20220214031956.3726764-2-penny.zheng@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220214031956.3726764-1-penny.zheng@arm.com>
References: <20220214031956.3726764-1-penny.zheng@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 1
X-MS-Office365-Filtering-Correlation-Id: 563f6192-236e-484c-9565-08d9ef690945
X-MS-TrafficTypeDiagnostic:
	VI1PR08MB3181:EE_|DB5EUR03FT004:EE_|VE1PR08MB5614:EE_
X-Microsoft-Antispam-PRVS:
	<VE1PR08MB5614D5E2F4EB2DB2576D52DCF7339@VE1PR08MB5614.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:1051;OLM:1051;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 FxnqTkrpzjeRvOJmUOWcWxbskkmFYJnn70Hu+8YE+PaDNaYdc8DfSR6DgBDxmnP/393XD/y/pi3VuMYTPZxLSoSPhWZTtSm/pIzb2hryCkqvV/ookrLy45GpyL8D7yZw9FmEEbeB0bs+TESoXSuLfy5RiqZZQ77DIt+fxP0CO7dEbH/hyuxJceYjjquGBUWxAh/M7jVySs6+8QLSZKwbPAmaqJwq+ShJn4dU7TxQqDddo22K/YvT4cbDrsqeWoJFmErwTXodxgByrsUtQj7MpH/sxkZGgi+aX+05hE8sC6yF7wtNO/Yo4Em5bSWCPJ0TjnFx0xM5r60Sz06AxD0ODzH+w53VbVAopwwIiLY/iBSn5lNe+UJ8ci3a0yNnuXW0IUFdWlQX49F+ZuuyrB9Bc7HdSqDmSRrrFyWYUzqT4JZcF6vSvwxH2kdQ8uZbfamfcefArKMHWWgB/005Z4NqqUe2RVm70MiBTC2x/X02quMa3SBwyRv5NIJeTkp33J0u7bGce2gRLU3euoyLIKwBBYt6yHwY2uk4PirloqGE2+sb/G3IUuypoNuq/zhFsr6BPvfurSndKRqIUlW56so2FRC3eUranvhQqo4kkO6yBjccc52Sp7/wzGPPLDIRWJhZ+iqVAHyklgrDJVn4ztTdcZj4idrDc1rJn2z5C3Kep3i8gOzDHYHE62aCeIX5kJa9pTsc4aaSTKIh7uQ8sfyckg==
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(83380400001)(86362001)(70206006)(70586007)(47076005)(26005)(186003)(316002)(336012)(81166007)(356005)(36860700001)(82310400004)(4326008)(426003)(2616005)(508600001)(8676002)(7696005)(6666004)(1076003)(110136005)(2906002)(54906003)(36756003)(44832011)(5660300002)(8936002)(21314003)(36900700001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3181
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT004.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	db33df49-10bd-4325-1f62-08d9ef69033d
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	wBF02sTg2RHE5EadfEpipcNu7EVR2ItR2hlP1wI10ZC+Olum/tlF8TEd1Lmt7y0jM4JovCB3JBBaaBcqq1GYRwafuTy8fbGiOqoV2Zz4gHY5tdTDrxWbXKxtUdqhW9wskk9w/jsJQxS3uBhMfZCjlwrnQvfttacAzxK99XQngvOJKMRz3EYdADwxP+03Jo1VugmgQrnQj8ZxeJ/2ahHNuDFaNgcHd/wTmBvB26yWW+wJToJeJJMyA3VLFAvzWPdU+0+ru9X4m2gQ932dwv8j6OpPduu3pDVWWMooFtA3XnqIns0MinLzerLckPZ0H4xb7dhv2NYYhdvB7d4Kal+i8gQ8A+64jr5ACzeUD85D2FjqfpdDSZmqSyU5w4TEnS/Ef62KEsZGJ459jQ2KO3qtSg/0iHq5iqWxhDIkSiG6izSd4KP9eQkd7yEBUCiEXmuwxTz0/kdR1jt8xNo26wYt/3v3RGOIet2igFsOWNM1CWp6gdYlgCY32siCKTuePH84qXZKe53vvMMnGa/tXsw4Sb9BoqSm9DQwW7g94uV12hj21Qzd+HeoZvQ/yA4acW7tt2rAu8YLxUMjJ+Rv2XLtaGakZvNVDPUMZLZs/eFBs+VE6BCmJ1O9ScAX1mYrAhAqucoxGcN5ujDuIfT54mvuAQVFspS/j0G1Vxdxcpj6IqE=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(186003)(26005)(1076003)(70586007)(2906002)(2616005)(70206006)(7696005)(44832011)(81166007)(4326008)(8936002)(8676002)(6666004)(82310400004)(47076005)(36756003)(336012)(508600001)(426003)(5660300002)(36860700001)(316002)(54906003)(110136005)(83380400001)(86362001)(21314003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2022 03:21:05.5639
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 563f6192-236e-484c-9565-08d9ef690945
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT004.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5614

From: Stefano Stabellini <sstabellini@kernel.org>

We are passing an internal-only boolean flag at domain creation to
specify whether we want the domain to be privileged (i.e. dom0) or
not. Another flag will be introduced later in this series.

This commit extends original "boolean" to an "unsigned int" covering both
the existing "is_priv" and our new "directmap", which will be introduced later.

To make visible the relationship, we name the respective constants CDF_xxx
(with no XEN_DOMCTL_ prefix) to represent the difference with the public
constants XEN_DOMCTL_CDF_xxx.

Allocate bit 0 as CDF_privileged: whether a domain is privileged or not.

Signed-off-by: Stefano Stabellini <sstabellini@kernel.org>
Signed-off-by: Penny Zheng <penny.zheng@arm.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Julien Grall <jgrall@amazon.com>
Tested-by: Stefano Stabellini <sstabellini@kernel.org>
---
v4 changes:
- new commit
---
v5 changes
- remove const constraint
---
v6 changes
- no changes
---
 xen/arch/arm/domain_build.c |  4 ++--
 xen/arch/x86/setup.c        |  2 +-
 xen/common/domain.c         | 10 +++++-----
 xen/common/sched/core.c     |  2 +-
 xen/include/xen/domain.h    |  4 ++++
 xen/include/xen/sched.h     |  2 +-
 6 files changed, 14 insertions(+), 10 deletions(-)

diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index 6931c022a2..0fab8604de 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -3058,7 +3058,7 @@ void __init create_domUs(void)
          * very important to use the pre-increment operator to call
          * domain_create() with a domid > 0. (domid == 0 is reserved for Dom0)
          */
-        d = domain_create(++max_init_domid, &d_cfg, false);
+        d = domain_create(++max_init_domid, &d_cfg, 0);
         if ( IS_ERR(d) )
             panic("Error creating domain %s\n", dt_node_name(node));
 
@@ -3160,7 +3160,7 @@ void __init create_dom0(void)
     if ( iommu_enabled )
         dom0_cfg.flags |= XEN_DOMCTL_CDF_iommu;
 
-    dom0 = domain_create(0, &dom0_cfg, true);
+    dom0 = domain_create(0, &dom0_cfg, CDF_privileged);
     if ( IS_ERR(dom0) || (alloc_dom0_vcpu0(dom0) == NULL) )
         panic("Error creating domain 0\n");
 
diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c
index 115f8f6517..624b53ded4 100644
--- a/xen/arch/x86/setup.c
+++ b/xen/arch/x86/setup.c
@@ -789,7 +789,7 @@ static struct domain *__init create_dom0(const module_t *image,
 
     /* Create initial domain.  Not d0 for pvshim. */
     domid = get_initial_domain_id();
-    d = domain_create(domid, &dom0_cfg, !pv_shim);
+    d = domain_create(domid, &dom0_cfg, pv_shim ? 0 : CDF_privileged);
     if ( IS_ERR(d) )
         panic("Error creating d%u: %ld\n", domid, PTR_ERR(d));
 
diff --git a/xen/common/domain.c b/xen/common/domain.c
index 2048ebad86..a79103e04a 100644
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -552,7 +552,7 @@ static int sanitise_domain_config(struct xen_domctl_createdomain *config)
 
 struct domain *domain_create(domid_t domid,
                              struct xen_domctl_createdomain *config,
-                             bool is_priv)
+                             unsigned int flags)
 {
     struct domain *d, **pd, *old_hwdom = NULL;
     enum { INIT_watchdog = 1u<<1,
@@ -578,7 +578,7 @@ struct domain *domain_create(domid_t domid,
     }
 
     /* Sort out our idea of is_control_domain(). */
-    d->is_privileged = is_priv;
+    d->is_privileged = flags & CDF_privileged;
 
     /* Sort out our idea of is_hardware_domain(). */
     if ( domid == 0 || domid == hardware_domid )
@@ -772,7 +772,7 @@ void __init setup_system_domains(void)
      * Hidden PCI devices will also be associated with this domain
      * (but be [partly] controlled by Dom0 nevertheless).
      */
-    dom_xen = domain_create(DOMID_XEN, NULL, false);
+    dom_xen = domain_create(DOMID_XEN, NULL, 0);
     if ( IS_ERR(dom_xen) )
         panic("Failed to create d[XEN]: %ld\n", PTR_ERR(dom_xen));
 
@@ -782,7 +782,7 @@ void __init setup_system_domains(void)
      * array. Mappings occur at the priv of the caller.
      * Quarantined PCI devices will be associated with this domain.
      */
-    dom_io = domain_create(DOMID_IO, NULL, false);
+    dom_io = domain_create(DOMID_IO, NULL, 0);
     if ( IS_ERR(dom_io) )
         panic("Failed to create d[IO]: %ld\n", PTR_ERR(dom_io));
 
@@ -791,7 +791,7 @@ void __init setup_system_domains(void)
      * Initialise our COW domain.
      * This domain owns sharable pages.
      */
-    dom_cow = domain_create(DOMID_COW, NULL, false);
+    dom_cow = domain_create(DOMID_COW, NULL, 0);
     if ( IS_ERR(dom_cow) )
         panic("Failed to create d[COW]: %ld\n", PTR_ERR(dom_cow));
 #endif
diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c
index 8f4b1ca10d..f5c819349b 100644
--- a/xen/common/sched/core.c
+++ b/xen/common/sched/core.c
@@ -3021,7 +3021,7 @@ void __init scheduler_init(void)
         sched_ratelimit_us = SCHED_DEFAULT_RATELIMIT_US;
     }
 
-    idle_domain = domain_create(DOMID_IDLE, NULL, false);
+    idle_domain = domain_create(DOMID_IDLE, NULL, 0);
     BUG_ON(IS_ERR(idle_domain));
     BUG_ON(nr_cpu_ids > ARRAY_SIZE(idle_vcpu));
     idle_domain->vcpu = idle_vcpu;
diff --git a/xen/include/xen/domain.h b/xen/include/xen/domain.h
index 160c8dbdab..cfb0b47f13 100644
--- a/xen/include/xen/domain.h
+++ b/xen/include/xen/domain.h
@@ -28,6 +28,10 @@ void getdomaininfo(struct domain *d, struct xen_domctl_getdomaininfo *info);
 void arch_get_domain_info(const struct domain *d,
                           struct xen_domctl_getdomaininfo *info);
 
+/* CDF_* constant. Internal flags for domain creation. */
+/* Is this a privileged domain? */
+#define CDF_privileged           (1U << 0)
+
 /*
  * Arch-specifics.
  */
diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
index 37f78cc4c4..24a9a87f83 100644
--- a/xen/include/xen/sched.h
+++ b/xen/include/xen/sched.h
@@ -665,7 +665,7 @@ int arch_sanitise_domain_config(struct xen_domctl_createdomain *config);
  */
 struct domain *domain_create(domid_t domid,
                              struct xen_domctl_createdomain *config,
-                             bool is_priv);
+                             unsigned int flags);
 
 /*
  * rcu_lock_domain_by_id() is more efficient than get_domain_by_id().
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 03:21:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 03:21:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271068.465393 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJRvO-0007BX-VC; Mon, 14 Feb 2022 03:21:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271068.465393; Mon, 14 Feb 2022 03:21:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJRvO-0007BQ-RS; Mon, 14 Feb 2022 03:21:14 +0000
Received: by outflank-mailman (input) for mailman id 271068;
 Mon, 14 Feb 2022 03:21:13 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=aDlx=S5=arm.com=Penny.Zheng@srs-se1.protection.inumbo.net>)
 id 1nJRvN-0007B4-CJ
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 03:21:13 +0000
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01on062e.outbound.protection.outlook.com
 [2a01:111:f400:fe02::62e])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2402e16b-8d45-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 04:21:05 +0100 (CET)
Received: from DB6PR1001CA0035.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:4:55::21)
 by AM0PR08MB3522.eurprd08.prod.outlook.com (2603:10a6:208:da::25)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Mon, 14 Feb
 2022 03:21:01 +0000
Received: from DB5EUR03FT010.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:4:55:cafe::fe) by DB6PR1001CA0035.outlook.office365.com
 (2603:10a6:4:55::21) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11 via Frontend
 Transport; Mon, 14 Feb 2022 03:21:01 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT010.mail.protection.outlook.com (10.152.20.96) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4975.11 via Frontend Transport; Mon, 14 Feb 2022 03:21:01 +0000
Received: ("Tessian outbound 741ca6c82739:v113");
 Mon, 14 Feb 2022 03:21:01 +0000
Received: from 29a95deb44b5.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 7D6E3D34-46F9-4CCF-A540-6101C6E372DC.1; 
 Mon, 14 Feb 2022 03:20:54 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 29a95deb44b5.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 14 Feb 2022 03:20:54 +0000
Received: from AM6PR10CA0065.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:80::42)
 by AM8PR08MB6372.eurprd08.prod.outlook.com (2603:10a6:20b:369::5)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Mon, 14 Feb
 2022 03:20:53 +0000
Received: from AM5EUR03FT013.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:80:cafe::8) by AM6PR10CA0065.outlook.office365.com
 (2603:10a6:209:80::42) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11 via Frontend
 Transport; Mon, 14 Feb 2022 03:20:53 +0000
Received: from nebula.arm.com (40.67.248.234) by
 AM5EUR03FT013.mail.protection.outlook.com (10.152.16.140) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.4975.11 via Frontend Transport; Mon, 14 Feb 2022 03:20:53 +0000
Received: from AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) by AZ-NEU-EX03.Arm.com
 (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2308.20; Mon, 14 Feb
 2022 03:20:57 +0000
Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX01.Emea.Arm.com
 (10.251.26.4) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.20; Mon, 14
 Feb 2022 03:20:51 +0000
Received: from penny.shanghai.arm.com (10.169.188.91) by mail.arm.com
 (10.251.24.31) with Microsoft SMTP Server id 15.1.2308.20 via Frontend
 Transport; Mon, 14 Feb 2022 03:20:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2402e16b-8d45-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=KaO+t7pfgDgfgVk5Xeps2SUiiu2wKmJ9Hqjc8YeTY+w=;
 b=kPBtWJgbmqx6J1msk7lKSF3P/vNVXN/bvU0duOIYjUWMbfXrLhNLQo9oDTj2/OVUAsjYgo4B4zEiPbHLZBX2xuCfBiuSPMJ4ID6dvGQEek+ud6v8Hqd1O3DOUv/U15lBc2FzkrsFxSRn2e6v+6bSH+IjFRrCoP8hDAbNhWIEssM=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 4b4342021d747928
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=V1mxeHl49bzGYc0hJsxksiv/nVtBZQj3h9vunh742Ei7AALSO6yvRew166G2ATa1Y/ZWtpNC0Ygoh2/efA+p3LIrKOvBSt7zbUrUZLx5DHYfdxKCxKwD6AdnovDoERFvNSWqOTIWv748iS0ldsOPpSutVVH7ghnf9p2IEzCkcwm38buQ7ecJy3ekJqr7fyaqgkxS9WZojCvCWqtd/7ODxyBXFR0jiSudpF9wbe3ucGvMIQS+VI1Gm/FSWSE68LSbcRSNPlNgr+wzQ6wHiIp6GL1EaXityfcgLUAMA8HvxMD+e5Neog6VShHwERSgDykQqN9fMUPcUEujdN+MCSMtIA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=KaO+t7pfgDgfgVk5Xeps2SUiiu2wKmJ9Hqjc8YeTY+w=;
 b=e0nSGtSLHqE+0RBZDpJY6YpKRcmxtHb8tHfBy1GPYMIkAX0If9hemHWhfPIyE1IeztcCrsTZg45IJagy+ntHhDUQnVAE0DsBeocwDuwwC6+nJfCZypohzoM8IDxOnEhrznhGywu5lW9V33JoRsmPWrPHelU1YnrPHXdmw6buJQ+zb/yUZnluTeTFdVlcUtggK+X/JSUANcGVQ+YSj/Dt5VQDCskJDujaOig15fK7P+7Sfty3DtWQcqoySApjXMDJ41wgWcz6r86xD3ETW8+REFlsJzaaxc9l21XdI6uGeexD+8A/DNjzvrH1gbIV8ZNJDSYuF8owZ06SGCYEDt+1Mw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=KaO+t7pfgDgfgVk5Xeps2SUiiu2wKmJ9Hqjc8YeTY+w=;
 b=kPBtWJgbmqx6J1msk7lKSF3P/vNVXN/bvU0duOIYjUWMbfXrLhNLQo9oDTj2/OVUAsjYgo4B4zEiPbHLZBX2xuCfBiuSPMJ4ID6dvGQEek+ud6v8Hqd1O3DOUv/U15lBc2FzkrsFxSRn2e6v+6bSH+IjFRrCoP8hDAbNhWIEssM=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com;
From: Penny Zheng <penny.zheng@arm.com>
To: <xen-devel@lists.xenproject.org>, <sstabellini@kernel.org>,
	<julien@xen.org>
CC: <Bertrand.Marquis@arm.com>, <Wei.Chen@arm.com>
Subject: [PATCH v6 00/11] direct-map memory map
Date: Mon, 14 Feb 2022 03:19:45 +0000
Message-ID: <20220214031956.3726764-1-penny.zheng@arm.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
X-EOPAttributedMessage: 1
X-MS-Office365-Filtering-Correlation-Id: 8d3f9a44-d17b-4112-394b-08d9ef69069d
X-MS-TrafficTypeDiagnostic:
	AM8PR08MB6372:EE_|DB5EUR03FT010:EE_|AM0PR08MB3522:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR08MB3522CF27A57A922EED347A1CF7339@AM0PR08MB3522.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:3826;OLM:3826;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 /TlwEO26+1DPxL2wsE6oWBDxRvmfKPbJ8otX1/h6ireDSQlVD86UcvP19lA3SqEtso5e4DOMuJc+2TCkXjhhupvZ9ihIC9MwJT4kHI8GOKE6cKJKLHH8zchyxqiyzgzxu8OIj88lZ1yZdsZy9pFDwoT0kdwE++1ZaJ+1Smi0LFKUujt2WP//zKpipoAq7Ciy7xWrLNm2AdKCtuy3Lu9fxarg/Crn3k6/x4H2nvbwnad+3GduaJw43TNAOg3gauOUzWZmmLITHXqx82TYaygvz37CXlndaS41nqPFLscN8Ak14NDbhCbpFisX/pvh4DUeGqFcv1XwqUU//Z9lhIaWfmqZP1E1SaEwEdWMmZURTyixaC/gdeTDp8hDadF1ZuhtE/2QlQTWH74O1fUCq9JAEeiUHKhqn0Jmstg0E1yWPeCOX5FRM4rIkF2s9Ckjzg/d52H7R9YRsZYORu6O6pa0F3hA5dNtJo4tReOHlukqOdBMKArQGRRgzHRVOWIhOtJbdVA7QQmwehS7Cq39mj7UdSJt85ElNBvsir/i7eeGuYxPsb6X3FaygAWwjMUM70YSY0ZDJ13BqnGYX5I/u2JIyurhFTMLhGK5Zwoxo5xYSltXfMZm3RdkVCm1qjegnyT+wOViwp9JPMOTtGcxkXUS2ifiKi6bcLbNAqhXA1koLEAtuN9zbgTeciTzvCR3nQh1qxO9tn1PwYAszGeuQaNriDZac+ehdFGxDsezSzibpAvux3p+Aqe1G7FfLi7Q9L4XKv+wZFPMOwKYcDqbKHy1H0VlpZ8ORFTXz5XQ0pTlut+YGgzMj18uaotG4eaz50Ymx6DCsGVAaS9py9a9IvOVtRZGit6O376xpG+oFhZAXKk=
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(4326008)(8676002)(966005)(1076003)(8936002)(336012)(36756003)(54906003)(70586007)(316002)(40460700003)(426003)(508600001)(70206006)(36860700001)(26005)(83380400001)(47076005)(110136005)(82310400004)(2906002)(5660300002)(6666004)(44832011)(7696005)(186003)(86362001)(81166007)(2616005)(356005)(21314003)(36900700001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6372
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT010.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	da9a677f-7035-42d0-a382-08d9ef6901d8
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	W7Wc+FIGRhCcwWo3xpcc7VQtF4cFo/fyK4L43fzJwfkoa72QqK0oTAF3USmJKJ/kDZYflB+VDeLGvcif4lnyu1s8ouIATENV8bQKk2fkQHNrgXoMKilNh8bpA0WJHOcoIR8LUHTpsdnrAWWNZlO5cm+TEC+OQWmGG+GoyOZnz9rLekOfTZUQyrDOQJPTiswWukxOsFq9LU+yLIaFj3Ev/wOesd+3p3qr4UonirZ4Ye08tVtGqTJJH7X7txhJjyWFEGIcxqBs6OEKOOfEJMzoZBGgKgmW8gfhca/dCUos+LxpJsWnC12ghCA4nO3n+tTdvBliV7N0tp50LOzh2EzF9/qUEki8QgbJvUfUUx1/5v/NDkCyCaL//l1K9q54aiptNNvHK8YDUGOLbxNU7fNppwZz/+r6O2J5P3zSmk2WFlVhxWYI72kV/Agrl72tM+kfwV5EITMdL4pOGx0MuORx2m4dFzjTiTmndBM6L3tGJNwTEdlZjMuEmc4f/WCVqVX4HFLEcyK7iDEV8ZW686HAkTkNE7oaakv+VvDlWTP/PImfhpP2fNDyO92bpdNFMzRJ0sv1pCIEUa1YOIYz7KBrnbvK1d0OEhyuBQB2DXL4FtFFmhlwN8RvQ9E/2wakzKprGGR5oJw0mfbi/AaeArxweEeYvw9I8lkc1gFDV2FNa0MQBu56DQzFU+lsNnrXsI23apNllpguVFXBtbOjyj7GaUh8XT//p5iqsQm25fv0ariN34NHTJFhEXGN0fCLJstQ5BCNzd+Rw9MDjMvSSMn9DYpGoAHmV69oLs+frqxRfv4=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(82310400004)(47076005)(336012)(7696005)(316002)(83380400001)(81166007)(426003)(6666004)(2906002)(54906003)(110136005)(8936002)(5660300002)(508600001)(36860700001)(966005)(4326008)(70206006)(70586007)(8676002)(36756003)(26005)(44832011)(186003)(2616005)(86362001)(1076003)(21314003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2022 03:21:01.1051
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 8d3f9a44-d17b-4112-394b-08d9ef69069d
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT010.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3522

"direct-map" property shall be added under the appropriate domain node,
when users requesting direct-map memory mapping for the domain.

Right now, direct-map is only supported when domain on Static Allocation,
that is, "xen,static-mem" is also necessary in the domain configuration.

Looking into related [design link](
https://lists.xenproject.org/archives/html/xen-devel/2021-05/msg00882.html)
for more details.

The whole design is about Static Allocation and direct-map, and this
Patch Serie only covers parts of it, which are direct-map memory map.
Other features will be delievered through different patch series.

See https://lists.xenproject.org/archives/html/xen-devel/2021-09/msg00855.html
for Domain on Static Allocation.

This patch serie is based on
https://lists.xenproject.org/archives/html/xen-devel/2021-10/msg00822.html\
---
v6 changes:
- comment, commit message and coding style fix
- protect CDF_directmap with #ifdef CONFIG_ARM
---
v5 changes:
- remove const constraint and strict "static allocation" check
- fix coding style
---
v4 changes:
- introduce internal const CDF_xxx flags for domain creation
- introduce internal flag CDF_privileged
- introduce new internal flag CDF_directmap
- add a directmap flag under struct arch_domain and use it to
reimplement is_domain_direct_mapped.
- expand arch_domain_create/domain_create to include internal-only parameter
"const unsigned int flags"
- use mfn_eq() instead, because it is the only value used to indicate
there is an error and this is more lightweight than mfn_valid()
- rename function allocate_static_memory_11() to assign_static_memory_11()
to make clear there is actually no allocation done. Instead we are only
mapping pre-defined host regions to pre-defined guest regions.
- remove tot_size to directly substract psize from kinfo->unassigned_mem
- check kinfo->unassigned_mem doesn't underflow or overflow
- remove nested if/else
- remove ASSERT_UNREACHABLE() to avoid breaking compilation on prod build with
CONFIG_GICV3=n
- comment and commit message refinement
---
v3 changes:
- move flag XEN_DOMCTL_CDF_INTERNAL_directmap back to xen/include/xen/domain.h,
to let it be only available for domain created by XEN.
- name it with extra "INTERNAL" and add comments to warn developers not
to accidently use its bitfield when introducing new XEN_DOMCTL_CDF_xxx flag.
- reject this flag in x86'es arch_sanitise_domain_config()
- add ASSERT_UNREACHABLE to catch any misuse in allocate_static_memory()
and allocate_static_memory_11()
- add another check of validating flag XEN_DOMCTL_CDF_INTERNAL_directmap only
when CONFIG_STATIC_MEMORY is set.
- simply map the CPU interface at the GPA vgic_v2_hw.cbase
- drop 'cells += (GUEST_ROOT_ADDRESS_CELLS + GUEST_ROOT_SIZE_CELLS)'
- rename 'is_domain_use_host_layout()' to 'domain_use_host_layout()'
---
v2 changes:
- remove the introduce of internal flag
- Refine is_domain_direct_mapped to check whether the flag
XEN_DOMCTL_CDF_directmap is set
- reword "1:1 direct-map" to just "direct-map"
- split the common codes into two helpers: parse_static_mem_prop and
acquire_static_memory_bank to deduce complexity.
- introduce a new helper allocate_static_memory_11 for allocating static
memory for direct-map guests
- remove panic action since it is fine to assign a non-DMA capable device when
IOMMU and direct-map both off
- remove redistributor accessor
- introduce new helper "is_domain_use_host_layout()"
- explain why vpl011 initialization before creating its device tree node
- error out if the domain is direct-mapped and the IRQ is not found
- harden the code and add a check/comment when the hardware UART region
is smaller than CUEST_VPL011_SIZE.
Penny Zheng (4):
  xen/arm: introduce new helper parse_static_mem_prop and
    acquire_static_memory_bank
  xen/arm: introduce direct-map for domUs
  xen/arm: add ASSERT_UNREACHABLE in allocate_static_memory
  xen/arm: gate make_gicv3_domU_node with CONFIG_GICV3

Stefano Stabellini (7):
  xen: introduce internal CDF_xxx flags for domain creation
  xen: introduce CDF_directmap
  xen/arm: Allow device-passthrough even the IOMMU is off
  xen/arm: if direct-map domain use native addresses for GICv2
  xen/arm: if direct-map domain use native addresses for GICv3
  xen/arm: if direct-map domain use native UART address and IRQ number
    for vPL011
  xen/docs: Document how to do passthrough without IOMMU

 docs/misc/arm/device-tree/booting.txt |   6 +
 docs/misc/arm/passthrough-noiommu.txt |  52 +++++
 xen/arch/arm/domain.c                 |   5 +-
 xen/arch/arm/domain_build.c           | 308 +++++++++++++++++++++-----
 xen/arch/arm/include/asm/domain.h     |  19 +-
 xen/arch/arm/include/asm/new_vgic.h   |  10 +
 xen/arch/arm/include/asm/vgic.h       |  11 +
 xen/arch/arm/include/asm/vpl011.h     |   2 +
 xen/arch/arm/vgic-v2.c                |  34 ++-
 xen/arch/arm/vgic-v3.c                |  30 +--
 xen/arch/arm/vgic/vgic-v2.c           |  34 ++-
 xen/arch/arm/vpl011.c                 |  60 ++++-
 xen/arch/x86/domain.c                 |   3 +-
 xen/arch/x86/setup.c                  |   2 +-
 xen/common/domain.c                   |  12 +-
 xen/common/sched/core.c               |   2 +-
 xen/include/xen/domain.h              |  11 +-
 xen/include/xen/sched.h               |   2 +-
 18 files changed, 494 insertions(+), 109 deletions(-)
 create mode 100644 docs/misc/arm/passthrough-noiommu.txt

-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 03:21:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 03:21:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271069.465399 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJRvP-0007E8-AJ; Mon, 14 Feb 2022 03:21:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271069.465399; Mon, 14 Feb 2022 03:21:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJRvP-0007DO-3h; Mon, 14 Feb 2022 03:21:15 +0000
Received: by outflank-mailman (input) for mailman id 271069;
 Mon, 14 Feb 2022 03:21:13 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=aDlx=S5=arm.com=Penny.Zheng@srs-se1.protection.inumbo.net>)
 id 1nJRvN-0007B5-KL
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 03:21:13 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04on060f.outbound.protection.outlook.com
 [2a01:111:f400:fe0c::60f])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2877ef72-8d45-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 04:21:12 +0100 (CET)
Received: from AS9PR06CA0170.eurprd06.prod.outlook.com (2603:10a6:20b:45c::30)
 by AM5PR0801MB1922.eurprd08.prod.outlook.com (2603:10a6:203:4b::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Mon, 14 Feb
 2022 03:21:08 +0000
Received: from VE1EUR03FT058.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:45c:cafe::5) by AS9PR06CA0170.outlook.office365.com
 (2603:10a6:20b:45c::30) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.12 via Frontend
 Transport; Mon, 14 Feb 2022 03:21:08 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT058.mail.protection.outlook.com (10.152.19.86) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4975.11 via Frontend Transport; Mon, 14 Feb 2022 03:21:08 +0000
Received: ("Tessian outbound 2877e54fe176:v113");
 Mon, 14 Feb 2022 03:21:08 +0000
Received: from 14b0bff7f3e5.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 7EF27C02-6C50-451F-977D-8ACBA3309D22.1; 
 Mon, 14 Feb 2022 03:21:01 +0000
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 14b0bff7f3e5.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 14 Feb 2022 03:21:01 +0000
Received: from AM6PR08CA0014.eurprd08.prod.outlook.com (2603:10a6:20b:b2::26)
 by AM5PR0801MB1617.eurprd08.prod.outlook.com (2603:10a6:203:39::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Mon, 14 Feb
 2022 03:21:00 +0000
Received: from AM5EUR03FT018.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:b2:cafe::99) by AM6PR08CA0014.outlook.office365.com
 (2603:10a6:20b:b2::26) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11 via Frontend
 Transport; Mon, 14 Feb 2022 03:21:00 +0000
Received: from nebula.arm.com (40.67.248.234) by
 AM5EUR03FT018.mail.protection.outlook.com (10.152.16.114) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.4975.11 via Frontend Transport; Mon, 14 Feb 2022 03:21:00 +0000
Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX03.Arm.com
 (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 14 Feb
 2022 03:21:03 +0000
Received: from penny.shanghai.arm.com (10.169.188.91) by mail.arm.com
 (10.251.24.31) with Microsoft SMTP Server id 15.1.2308.20 via Frontend
 Transport; Mon, 14 Feb 2022 03:21:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2877ef72-8d45-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=oRbPxrfxtUguB6iv9k6N/YrNB/mDdmcGGUpf5LaQEEM=;
 b=l7JVg8X8abnzkPvGmomkMftevNR2bTX6whbXQVw0jRvKt5ASev6kniqONP+B/JdEsyMoE5KPUlGkth99to24XgFr+HMe4pILFaspHUBl9ZoKlE8Kza02xVBFsD8rSrqwaQgZ9fL7KHRPh4Ilcj24yp60v9DE82EI8o1grc/2Xck=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 0aa005b79a539185
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Qn7t9wL/8zslFhuNOCp+J8soot3UWDQ3Koi6/Ht1ctiI/tetglwQ9acSck/+wJK2D9ff6LEafTCWqcIsXPuCi/x59cJSuOqkMnOip3qbgVqICyIn/CFgQAL4GMZBXrJA5nSgu1kYdbj+QB3ieuLQKQNEq8p+f3ZHsiMRDoyiJuadeiweyOcUL1rVDjgTCcm3PS6VOkPN14JqvqjpAKjhZxubS0u4e1YeJC45mtjoVFCnGpraLWSquVERM5kIhDftNa7vUG5yRzvt39Ah2v87I8ovXdQs/YmfcSwejIKCK6pnvRdfTuWAEdog2u2oqY3/ctU6/ZTZmL8m5TeKM6lC4g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=oRbPxrfxtUguB6iv9k6N/YrNB/mDdmcGGUpf5LaQEEM=;
 b=XSJMtEzIpVWbVItoH67FfefwmcRj3Jmd/2XecuMbxWfaJFmKkXzpz09/B9LPE/M7ye5BIKfKO1j0LNyg7boKeJ0ZeVibf2ITNpEuw4qDBzMGAzHTByV50mDUd95SsFkaGXVOGL99LPKeaXR8EjOCU0PAjClmUIEtzQf42SgDYDpmHnf59NSP5/xrjxpvUWNOvSk0nNb6XgPZmY5LMUgY/2NvlvzOegOnqFS+7QRR7X7c5i5pIzLkCy1zYNrK0XV3tcMAGNyErBt03K6xWnfalwpPB646uXqctnMpOM16o3Z027msAVQQeV6zFmYVU1Q3w4DZ6aydGwmgT9kWSrXJIg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=oRbPxrfxtUguB6iv9k6N/YrNB/mDdmcGGUpf5LaQEEM=;
 b=l7JVg8X8abnzkPvGmomkMftevNR2bTX6whbXQVw0jRvKt5ASev6kniqONP+B/JdEsyMoE5KPUlGkth99to24XgFr+HMe4pILFaspHUBl9ZoKlE8Kza02xVBFsD8rSrqwaQgZ9fL7KHRPh4Ilcj24yp60v9DE82EI8o1grc/2Xck=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com;
From: Penny Zheng <penny.zheng@arm.com>
To: <xen-devel@lists.xenproject.org>, <sstabellini@kernel.org>,
	<julien@xen.org>
CC: <Bertrand.Marquis@arm.com>, <Wei.Chen@arm.com>
Subject: [PATCH v6 03/11] xen/arm: Allow device-passthrough even the IOMMU is off
Date: Mon, 14 Feb 2022 03:19:48 +0000
Message-ID: <20220214031956.3726764-4-penny.zheng@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220214031956.3726764-1-penny.zheng@arm.com>
References: <20220214031956.3726764-1-penny.zheng@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 1
X-MS-Office365-Filtering-Correlation-Id: f5050ff9-08df-4a93-8e63-08d9ef690afb
X-MS-TrafficTypeDiagnostic:
	AM5PR0801MB1617:EE_|VE1EUR03FT058:EE_|AM5PR0801MB1922:EE_
X-Microsoft-Antispam-PRVS:
	<AM5PR0801MB1922B4AEB99AF3B313563C2FF7339@AM5PR0801MB1922.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 ephZ2oyUDcH98HjX9CcnN3bu0CdjZtw1BtLTurq8DI6iT2zBzilFMpZpdrhcQ+ay7YVtAGJYzyIhK4ZLpr0oFVPROXligPXfkzHrK8+xmSzqrJE+GHKeYQsaAsTpz0Stnull4wpvet0wM6pdGAnsR+IMW3JDBZyfUZhn+SCC9MXr0VxA5wb3j8/F6SvhecSKxSILGks9Mjer5XAvO679ZPok4A0Gn3yJ2iA81/lViO7ShRAj/aCAI/XXbS04R30YzI/5B6+yS8EQ7JXd6xd3OTTnYgLPMwDKGEHZvwOr5yMgKkFPI7zcMaE5NaiWSWrq+gZuw2FZb3bXXKXlIGPp30sjOzMpKb1651iJowJsmxJ72b4S58LSEVHLFi5yh1e0OhJkFRx8QcZ/4Yasau+4jvSU5SF56bE3PJIpjd3ncHf0ym92qzWXHOEyegV01xPoJMsldu/lTCfUpDUNd/W+5+SMzwYMoLEGeDulqb9VXzYE1XWsq56EYu/9amP6U71TsWJ3es2C9gyo6UXbiABCbG3BBYDbfnAXXReA5KXVvwSPn1eYwE7+5Re4ywBtiiUVsIqYTZAMX2Y1E5Nq04bxc9m7Xno07kOHj2vpLpHssv7w0TlsggKuDw0u+tr0VM1tImcPNVH+EEhyycIgXmLku1lo1G6Z/P071gLLdRImV4SUXCbVW7F1P5L9P0Azwqzl9Wwqtu9tfdGsSfS29171pg==
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(316002)(81166007)(8936002)(54906003)(26005)(186003)(110136005)(70206006)(4326008)(8676002)(5660300002)(44832011)(82310400004)(2906002)(356005)(70586007)(86362001)(47076005)(2616005)(36860700001)(36756003)(508600001)(83380400001)(1076003)(40460700003)(336012)(426003)(7696005)(6666004)(36900700001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB1617
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT058.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	53cd6acd-612c-4cf5-aee3-08d9ef6905f9
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	+pBOsRCrhHTUW51ns4zGeurTLnkY4LiIVBo8mlf5Gb7iOMhsLiKQjCTOP3+Y909ekFIuEeC1veqVRfte+FZixoKjByEqJccjiOxKRlhIS9x/8uLOzUS9IiNn2HCWiZW3rgCNIQ4vMZSf85GF+sT/rn19ceCVkL6TSUw3UIbhdlC/z8FChpY0qPb2Xj4LaJCtZRmI7N7ynMIFLzT9fNK1NWiyUqwfVUp30V1ALSRWrw+FvXXGv6QkF9InVkJEWWFxSbvQSsM3JHcOrC1XPgkOT3lKR2+fNcLSiNWTMV9MuY7S300djFwiMajCOnMdggZEQqBGaMj6y/Nlm2BReHQRPks7rYhf94VgsXDoO8Z+uFoNGtq1Qetp+dpVhHJfrPKgO9hg45kaetKGQCoCb0/JZBTZS3lH7vAvnjeGup8tVIjX3DvS3hTkkKLwVmhvJMTTsjKJry0rBBEH1cnXQeg1v/ppnYnGStsug6UqBrQ7FCiFifnR4oPXwCrY4qfRKkhnvtZcwXSgcK7n5Ds1pgOhWtGR3wJnpGGDmy+VO16FOQuu9ce5+rEwPnmbYE2XOJZk1x+ZkBuMS24CebxOm+0anZ8vMCanMATzW7POPVXYRTbDlbXDzPZLsfW9fO6vJJao5qUrRm8KoS3n36I38teheQ==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(2906002)(83380400001)(44832011)(508600001)(426003)(336012)(7696005)(5660300002)(47076005)(6666004)(81166007)(316002)(82310400004)(8936002)(8676002)(186003)(2616005)(4326008)(36860700001)(54906003)(26005)(36756003)(110136005)(70586007)(1076003)(86362001)(70206006);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2022 03:21:08.3404
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: f5050ff9-08df-4a93-8e63-08d9ef690afb
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT058.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB1922

From: Stefano Stabellini <sstabellini@kernel.org>

At the moment, we are only supporting device-passthrough when Xen has
enabled the IOMMU. There are some use cases where it is not possible to
use the IOMMU (e.g. doesn't exist, hardware limitation, performance) yet
it would be OK to assign a device to trusted domain so long they are
direct-mapped or the device doesn't do DMA.

Note that when the IOMMU is disabled, it will be necessary to add
xen,force-assign-without-iommu for every device that needs to be assigned.

Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
Signed-off-by: Penny Zheng <penny.zheng@arm.com>
Tested-by: Stefano Stabellini <sstabellini@kernel.org>
---
v3 changes:
- new commit, split from the original "[PATCH v2 2/6] xen/arm: introduce
direct-map for domUs"
---
v4 changes:
- explain briefly in the commit message why we want to do device assignment
without IOMMU.
---
v5 changes:
- nothing changed
---
v6 changes
- commit message refinement
---
 xen/arch/arm/domain_build.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index 6467e8ee32..c1e8c99f64 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -3047,7 +3047,8 @@ void __init create_domUs(void)
             panic("Missing property 'cpus' for domain %s\n",
                   dt_node_name(node));
 
-        if ( dt_find_compatible_node(node, NULL, "multiboot,device-tree") )
+        if ( dt_find_compatible_node(node, NULL, "multiboot,device-tree") &&
+             iommu_enabled )
             d_cfg.flags |= XEN_DOMCTL_CDF_iommu;
 
         if ( !dt_property_read_u32(node, "nr_spis", &d_cfg.arch.nr_spis) )
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 03:21:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 03:21:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271073.465448 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJRvY-0000IK-VR; Mon, 14 Feb 2022 03:21:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271073.465448; Mon, 14 Feb 2022 03:21:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJRvY-0000Hs-Qu; Mon, 14 Feb 2022 03:21:24 +0000
Received: by outflank-mailman (input) for mailman id 271073;
 Mon, 14 Feb 2022 03:21:24 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=aDlx=S5=arm.com=Penny.Zheng@srs-se1.protection.inumbo.net>)
 id 1nJRvY-0007B5-0S
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 03:21:24 +0000
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur02on0605.outbound.protection.outlook.com
 [2a01:111:f400:fe05::605])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2f003a5b-8d45-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 04:21:22 +0100 (CET)
Received: from AM7PR04CA0001.eurprd04.prod.outlook.com (2603:10a6:20b:110::11)
 by AM6PR08MB2966.eurprd08.prod.outlook.com (2603:10a6:209:4e::31)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.18; Mon, 14 Feb
 2022 03:21:20 +0000
Received: from AM5EUR03FT016.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:110:cafe::e7) by AM7PR04CA0001.outlook.office365.com
 (2603:10a6:20b:110::11) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.18 via Frontend
 Transport; Mon, 14 Feb 2022 03:21:20 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT016.mail.protection.outlook.com (10.152.16.142) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4975.11 via Frontend Transport; Mon, 14 Feb 2022 03:21:20 +0000
Received: ("Tessian outbound 741ca6c82739:v113");
 Mon, 14 Feb 2022 03:21:20 +0000
Received: from 8473bcff6336.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 59C6AD33-613C-4FFC-A6BC-0D6A6DC6FF14.1; 
 Mon, 14 Feb 2022 03:21:14 +0000
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8473bcff6336.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 14 Feb 2022 03:21:14 +0000
Received: from AM6PR08CA0001.eurprd08.prod.outlook.com (2603:10a6:20b:b2::13)
 by DBAPR08MB5701.eurprd08.prod.outlook.com (2603:10a6:10:1a6::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Mon, 14 Feb
 2022 03:21:04 +0000
Received: from AM5EUR03FT018.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:b2:cafe::8b) by AM6PR08CA0001.outlook.office365.com
 (2603:10a6:20b:b2::13) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11 via Frontend
 Transport; Mon, 14 Feb 2022 03:21:04 +0000
Received: from nebula.arm.com (40.67.248.234) by
 AM5EUR03FT018.mail.protection.outlook.com (10.152.16.114) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.4975.11 via Frontend Transport; Mon, 14 Feb 2022 03:21:03 +0000
Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX03.Arm.com
 (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 14 Feb
 2022 03:21:08 +0000
Received: from penny.shanghai.arm.com (10.169.188.91) by mail.arm.com
 (10.251.24.31) with Microsoft SMTP Server id 15.1.2308.20 via Frontend
 Transport; Mon, 14 Feb 2022 03:21:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2f003a5b-8d45-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Rwq3BQ8hJu/bwkftJjd/wj3OUNX0PEAg7LDBt9R1U8E=;
 b=kl7UJ7H+T+M9GPV1l7QEe5Dpu0FdyVhw3aiV3/ype7jy7ncBY/1IAJ+RXEq0L5JiQusHDWJih819LwONK1H2r19JJKwdhooM24GTQzk90lStmMHb0h5Vk06WWLgvy4zokQhU88RJjAWklaAEb6ndHtxGE+LHvO10c5t3N9Nr6N8=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 09d991b60ae58833
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=MsZWMXJxXJcKwcsEWKa6DckZwJLt0SrYSoQQeop5T3yGUTQEV0SLlJwouYjEBhfW0/coU1V3IzVeGM9m13OAHIQmVI0bxOajPEEYGnEjhwvmg/NLgi5UZEUD8djZLQFyzFTgeZqBgrvQcUcWZdOgofMcYLc/Y9xTjtLu/4CITlpabtQ4KzAG1+ZTiz6UzVCeqxSwiNBo1mHN4RyfaCz9/Viniz4IKYnKA/adVc8jFu5JTklxez9Ki9WxD9i/kBZIIjauxS6VLpGFXXozul0w62uqit/hFiCDEwByY68/Feb0bkabGHBc5TDZkqDKOzuISnIoIWXBSp1gbCaieBTFeA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Rwq3BQ8hJu/bwkftJjd/wj3OUNX0PEAg7LDBt9R1U8E=;
 b=Viulyf05yy/wQGOAB4Vds5igfWUDMetwg8+X0cFADAZmI0rOwcFxy3d682TFTIrvB3oHJDkBZdnAmZ480Tw/1ZWkjiPiueNrE5gbdCoFF62uFlpxvgQ2PyIa1YqmngZ7xHc+xjBsu6zPxqdul0+IgBb5Yogultq0TcU1vL2CyWKsf4BhYul3vPjLBKMGPb4ikQQ5K4p5j6dV3QsMYQRp255ER0Zn+L1OuCAEMGFk1EHap6vjQmJmQOmjALSIj7mw/cJV1J4HNY0YntSkoXpZWlGDtwpIozjivav7edyjYI+i1b2khPBJZgR7A+tQDiPJS5vwLC2h2m4iAG20t0609Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Rwq3BQ8hJu/bwkftJjd/wj3OUNX0PEAg7LDBt9R1U8E=;
 b=kl7UJ7H+T+M9GPV1l7QEe5Dpu0FdyVhw3aiV3/ype7jy7ncBY/1IAJ+RXEq0L5JiQusHDWJih819LwONK1H2r19JJKwdhooM24GTQzk90lStmMHb0h5Vk06WWLgvy4zokQhU88RJjAWklaAEb6ndHtxGE+LHvO10c5t3N9Nr6N8=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com;
From: Penny Zheng <penny.zheng@arm.com>
To: <xen-devel@lists.xenproject.org>, <sstabellini@kernel.org>,
	<julien@xen.org>
CC: <Bertrand.Marquis@arm.com>, <Wei.Chen@arm.com>
Subject: [PATCH v6 05/11] xen/arm: introduce direct-map for domUs
Date: Mon, 14 Feb 2022 03:19:50 +0000
Message-ID: <20220214031956.3726764-6-penny.zheng@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220214031956.3726764-1-penny.zheng@arm.com>
References: <20220214031956.3726764-1-penny.zheng@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 1
X-MS-Office365-Filtering-Correlation-Id: 0deb74f3-4d3c-4512-e5a7-08d9ef691246
X-MS-TrafficTypeDiagnostic:
	DBAPR08MB5701:EE_|AM5EUR03FT016:EE_|AM6PR08MB2966:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR08MB2966AEDBFCAE15D3C07C734FF7339@AM6PR08MB2966.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:1332;OLM:1332;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 xxI8AOTSggpt3uZwj46T7btNz1EuphtQhrT2uKwQ9q2bWNrB4q437Y871rcPFgEx+v4HIEV9S3gYpJwUFjHVtBuQqdiqrJOyFx2f9031gcmNBc+59x4iBoTay+vMkSnCORkEBxdbtWWIhCJPnZmH5pW9O8ER4DCE/pWb15HRWOU0RNc3G7Fx6MOyBCgXqBjs/hyh3umM899NzJLVCjVqcROG3JLcK6YSw9VjTUZfmItzyE/qoPRZ2nelv17Gj0Uk4qDbfurPRi9lcCIVovaJOgoZmLPfRbLQTlvc1BD76gJCGmliyS2Gq4G3Bef3OfTeFgmdAs1n6N5jBLsGhTOe81oD8PGbNU1WcnkTZaCxWSI/1Sf2O7rihGcl475wYn2iV9134XQSAapdiCO1BgHrftEdyGGUcLY3qLP9ftiJsWwHI4510dm7lkCKfxToyMlcjw34/PYZl8KB959VSX8l71oEPrdIJLfpOu5LyMCTN0sdz9NgklC+LU/njRvHEBf3onPQs2Db0o4uLUb/UhrKke2U34VC9lO40WjDLeqr7MdQY/T4/tP2m5zbOjSLcY+vdxR3VpoGkgyZw6iBUDkhZl1sKxEAyGF9xfFwH+rePlOlNEw0yBMlj6SASrE3owa41qorH6gp98x7uIa7jmUnTMXLX3tCnoSpNYHnCFKnV7O6lBf6hF8yCMVUAtXXwaM44I/D7GKB8FHWA6hCfEdczQ==
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(8676002)(508600001)(2906002)(7696005)(47076005)(6666004)(5660300002)(8936002)(44832011)(4326008)(70206006)(70586007)(81166007)(36860700001)(82310400004)(316002)(86362001)(1076003)(83380400001)(426003)(186003)(26005)(336012)(36756003)(110136005)(2616005)(54906003)(356005)(40460700003)(36900700001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5701
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT016.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	07d3af5b-3362-4988-75fd-08d9ef690852
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Gf42OWAQ4ClTJIYQGOmav9/7/wEBIF5Qy2LWNIec9ZjcXZjiNZYHrN47YMyF2PCQQBjsinicF2W95VKYpo6ZX16Nhb9RR7tiUBMcSzXwGTvwI6wRCVb/lGxn83Nlxy3IP7fIf+3PzmD61xEk7p+MsHcM4YZjtYpKJzvTnlOCkASx0LrRilvT/8OPImSnOQmH61o3QVrk47sPXmuLfLvcge7cQrTVMVTcW+RSHOYzb2gg15FH+I2RCxoqO5Ab2++dr4NSO7MZTGv82f44k1AGu2dnRg1/XJ0dO+w06Dn+VTzQ1NLWpVAwDJSP6Gv1VYzvib1YCSjnl1ErAKvwBe8e6xUDBCDIC09M1ev1cZFFtcd8/QW1v7p7u7eawvlkpoZWQ7PZ9UqSK4Ih9kBJjZ1TUcDDscBOMoBZ7H1G9N1yU7FPH/7/0QSSwwURpHW1G7//eS9DbjVH+QQ5nCLR3JBXFBz4GssYfrgg5gA0k/D5giPE/PXel4imaTDcIlAE2nNe2ysvm0UoiqgBXmjOqoRKPTuUpww8Y9OhEoPEPPyBVEnkvmEW5MVZkSVZM2G7ZtHMiy5s2QHOwPcPdq9ZayUt5yyIE2LI7itzren5FnOxXJJ2kLuKm/QUr2G3KQrNaCI5wZjVMUya8CjHjDhjjyBl6g==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(70586007)(70206006)(2906002)(86362001)(8676002)(4326008)(8936002)(82310400004)(44832011)(5660300002)(81166007)(186003)(26005)(426003)(336012)(2616005)(1076003)(83380400001)(6666004)(7696005)(36756003)(508600001)(36860700001)(47076005)(316002)(54906003)(110136005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2022 03:21:20.6347
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 0deb74f3-4d3c-4512-e5a7-08d9ef691246
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT016.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB2966

Cases where domU needs direct-map memory map:
  * IOMMU not present in the system.
  * IOMMU disabled if it doesn't cover a specific device and all the guests
are trusted. Thinking a mixed scenario, where a few devices with IOMMU and
a few without, then guest DMA security still could not be totally guaranteed.
So users may want to disable the IOMMU, to at least gain some performance
improvement from IOMMU disabled.
  * IOMMU disabled as a workaround when it doesn't have enough bandwidth.
To be specific, in a few extreme situation, when multiple devices do DMA
concurrently, these requests may exceed IOMMU's transmission capacity.
  * IOMMU disabled when it adds too much latency on DMA. For example,
TLB may be missing in some IOMMU hardware, which may bring latency in DMA
progress, so users may want to disable it in some realtime scenario.
  * Guest OS relies on the host memory layout

This commit introduces a new helper assign_static_memory_11 to allocate
static memory as guest RAM for direct-map domain.

Signed-off-by: Penny Zheng <penny.zheng@arm.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
Tested-by: Stefano Stabellini <sstabellini@kernel.org>
---
v2 changes:
- split the common codes into two helpers: parse_static_mem_prop and
acquire_static_memory_bank to deduce complexity.
- introduce a new helper allocate_static_memory_11 for allocating static
memory for direct-map guests
- remove redundant use "bool direct_map", to be replaced by
d_cfg.flags & XEN_DOMCTL_CDF_directmap
- remove panic action since it is fine to assign a non-DMA capable device when
IOMMU and direct-map both off
---
v3 changes:
- doc refinement
- drop the pointless gbank
- add check of the size of nr_banks shall not exceed NR_MEM_BANKS
- add ASSERT_UNREACHABLE to catch any misuse
- add another check of validating flag XEN_DOMCTL_CDF_INTERNAL_directmap only
when CONFIG_STATIC_MEMORY is set.
---
v4 changes:
- comment refinement
- rename function allocate_static_memory_11() to assign_static_memory_11()
to make clear there is actually no allocation done. Instead we are only
mapping pre-defined host regions to pre-defined guest regions.
- remove tot_size to directly substract psize from kinfo->unassigned_mem
- check kinfo->unassigned_mem doesn't underflow or overflow
- remove nested if/else
- refine "panic" info
---
v5 changes:
- fix coding style
---
v6 changes:
- no changes
---
 xen/arch/arm/domain_build.c | 97 +++++++++++++++++++++++++++++++++++--
 1 file changed, 94 insertions(+), 3 deletions(-)

diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index e61d2d53ba..ec29bd302c 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -494,8 +494,17 @@ static bool __init append_static_memory_to_bank(struct domain *d,
 {
     int res;
     unsigned int nr_pages = PFN_DOWN(size);
-    /* Infer next GFN. */
-    gfn_t sgfn = gaddr_to_gfn(bank->start + bank->size);
+    gfn_t sgfn;
+
+    /*
+     * For direct-mapped domain, the GFN match the MFN.
+     * Otherwise, this is inferred on what has already been allocated
+     * in the bank.
+     */
+    if ( !is_domain_direct_mapped(d) )
+        sgfn = gaddr_to_gfn(bank->start + bank->size);
+    else
+        sgfn = gaddr_to_gfn(mfn_to_maddr(smfn));
 
     res = guest_physmap_add_pages(d, sgfn, smfn, nr_pages);
     if ( res )
@@ -668,12 +677,92 @@ static void __init allocate_static_memory(struct domain *d,
  fail:
     panic("Failed to allocate requested static memory for domain %pd.", d);
 }
+
+/*
+ * Allocate static memory as RAM for one specific domain d.
+ * The static memory will be directly mapped in the guest(Guest Physical
+ * Address == Physical Address).
+ */
+static void __init assign_static_memory_11(struct domain *d,
+                                           struct kernel_info *kinfo,
+                                           const struct dt_device_node *node)
+{
+    u32 addr_cells, size_cells, reg_cells;
+    unsigned int nr_banks, bank = 0;
+    const __be32 *cell;
+    paddr_t pbase, psize;
+    mfn_t smfn;
+    int length;
+
+    if ( parse_static_mem_prop(node, &addr_cells, &size_cells, &length, &cell) )
+    {
+        printk(XENLOG_ERR
+               "%pd: failed to parse \"xen,static-mem\" property.\n", d);
+        goto fail;
+    }
+    reg_cells = addr_cells + size_cells;
+    nr_banks = length / (reg_cells * sizeof(u32));
+
+    if ( nr_banks > NR_MEM_BANKS )
+    {
+        printk(XENLOG_ERR
+               "%pd: exceed max number of supported guest memory banks.\n", d);
+        goto fail;
+    }
+
+    for ( ; bank < nr_banks; bank++ )
+    {
+        smfn = acquire_static_memory_bank(d, &cell, addr_cells, size_cells,
+                                          &pbase, &psize);
+        if ( mfn_eq(smfn, INVALID_MFN) )
+            goto fail;
+
+        printk(XENLOG_INFO "%pd: STATIC BANK[%u] %#"PRIpaddr"-%#"PRIpaddr"\n",
+               d, bank, pbase, pbase + psize);
+
+        /* One guest memory bank is matched with one physical memory bank. */
+        kinfo->mem.bank[bank].start = pbase;
+        if ( !append_static_memory_to_bank(d, &kinfo->mem.bank[bank],
+                                           smfn, psize) )
+            goto fail;
+
+        kinfo->unassigned_mem -= psize;
+    }
+
+    kinfo->mem.nr_banks = nr_banks;
+
+    /*
+     * The property 'memory' should match the amount of memory given to
+     * the guest.
+     * Currently, it is only possible to either acquire static memory or
+     * let Xen allocate. *Mixing* is not supported.
+     */
+    if ( kinfo->unassigned_mem != 0 )
+    {
+        printk(XENLOG_ERR
+               "Size of \"memory\" property doesn't match up with the sum-up of \"xen,static-mem\".\n");
+        goto fail;
+    }
+
+    return;
+
+ fail:
+    panic("Failed to assign requested static memory for direct-map domain %pd.",
+          d);
+}
 #else
 static void __init allocate_static_memory(struct domain *d,
                                           struct kernel_info *kinfo,
                                           const struct dt_device_node *node)
 {
 }
+
+static void __init assign_static_memory_11(struct domain *d,
+                                           struct kernel_info *kinfo,
+                                           const struct dt_device_node *node)
+{
+    ASSERT_UNREACHABLE();
+}
 #endif
 
 /*
@@ -3023,8 +3112,10 @@ static int __init construct_domU(struct domain *d,
 #endif
     if ( !dt_find_property(node, "xen,static-mem", NULL) )
         allocate_memory(d, &kinfo);
-    else
+    else if ( !is_domain_direct_mapped(d) )
         allocate_static_memory(d, &kinfo, node);
+    else
+        assign_static_memory_11(d, &kinfo, node);
 
     rc = prepare_dtb_domU(d, &kinfo);
     if ( rc < 0 )
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 03:21:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 03:21:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271074.465459 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJRvc-0000fn-Cb; Mon, 14 Feb 2022 03:21:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271074.465459; Mon, 14 Feb 2022 03:21:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJRvc-0000fU-8v; Mon, 14 Feb 2022 03:21:28 +0000
Received: by outflank-mailman (input) for mailman id 271074;
 Mon, 14 Feb 2022 03:21:26 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=aDlx=S5=arm.com=Penny.Zheng@srs-se1.protection.inumbo.net>)
 id 1nJRva-0007B4-Lh
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 03:21:26 +0000
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur02on0621.outbound.protection.outlook.com
 [2a01:111:f400:fe05::621])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 30b8c398-8d45-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 04:21:25 +0100 (CET)
Received: from AM6PR04CA0017.eurprd04.prod.outlook.com (2603:10a6:20b:92::30)
 by PAXPR08MB6880.eurprd08.prod.outlook.com (2603:10a6:102:13d::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Mon, 14 Feb
 2022 03:21:20 +0000
Received: from VE1EUR03FT027.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:92:cafe::9) by AM6PR04CA0017.outlook.office365.com
 (2603:10a6:20b:92::30) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.18 via Frontend
 Transport; Mon, 14 Feb 2022 03:21:19 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT027.mail.protection.outlook.com (10.152.18.154) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4975.11 via Frontend Transport; Mon, 14 Feb 2022 03:21:19 +0000
Received: ("Tessian outbound 2877e54fe176:v113");
 Mon, 14 Feb 2022 03:21:19 +0000
Received: from ff8e26062fb6.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 0D39541A-15DB-4FF8-AB74-588CD450E1DF.1; 
 Mon, 14 Feb 2022 03:21:13 +0000
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ff8e26062fb6.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 14 Feb 2022 03:21:13 +0000
Received: from AS8PR04CA0170.eurprd04.prod.outlook.com (2603:10a6:20b:331::25)
 by DBBPR08MB4887.eurprd08.prod.outlook.com (2603:10a6:10:d7::11) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.15; Mon, 14 Feb
 2022 03:21:08 +0000
Received: from AM5EUR03FT026.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:331:cafe::b3) by AS8PR04CA0170.outlook.office365.com
 (2603:10a6:20b:331::25) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.18 via Frontend
 Transport; Mon, 14 Feb 2022 03:21:08 +0000
Received: from nebula.arm.com (40.67.248.234) by
 AM5EUR03FT026.mail.protection.outlook.com (10.152.16.155) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.4975.11 via Frontend Transport; Mon, 14 Feb 2022 03:21:08 +0000
Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX03.Arm.com
 (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 14 Feb
 2022 03:21:12 +0000
Received: from penny.shanghai.arm.com (10.169.188.91) by mail.arm.com
 (10.251.24.31) with Microsoft SMTP Server id 15.1.2308.20 via Frontend
 Transport; Mon, 14 Feb 2022 03:21:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 30b8c398-8d45-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=op4V66n/UXRW6FyBCeIN+WP0ySiF94rkWc6FafgtJa0=;
 b=6k9SugG66QvHHxz3hMEy4xVuHdMpGYJW8ELVR6T7ZUeRDALON2ib+rgpeaPXmomk3of2Ca7U5k6DDeCnOQB9vbhX8eoF7igm0WoEqW84Q31AIv9JaUFQ0/6gapbAqHYx/8sIB0hdpTSVsLziSOBEfc5Ei7Tn8t3Gbm/FHeViApk=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 2ab075b81aeb8afa
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Ni/JsYX2nWEqT8MuQX6TmphQBldfF6NHqTXqUja+PeABpMJcOz0Fbf3oDafms2VG6dmushkjYqy7ztZ2L+o7Hnb1f1mHNLJEJOHabUgnihanDOAeH1RZ1DuEW6A7WpjC51VuW5xDVALP4Tpub7n+XqRw/XgGwKS+1/DIhG3A+sdHfkR1O1jJBROvM9ib9njNIHSLJIF6hR6T+5s9wg7A0sy38lOYmnWx5sOQkMM5YiN7gK8O37zauc+HdPGeVaP3utEA5k3toMF4PAerXO/MB7VHzOee24lGXKFCU4O8HD0gz/rOaEQmWW1dJxJcDAYBOthxQGLUzTdkAcI3lyQ+3g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=op4V66n/UXRW6FyBCeIN+WP0ySiF94rkWc6FafgtJa0=;
 b=BUYLS6QLfK1GUycyngeQ0XtUAmh6G7xDBSI6OCcgB2M8RI+2Mbnnu8Oof/4aconmBH8mraM6s5HwAGhB5+iOUzpTmY/S6BDQNhqB3C7GdGmoEXBvSJr3eo80VI7VGM1iHFJP4NKyDuGcWMvTASUvlBy4w1psD3cX19oHqukQ4MrX8C9d7PyYzY8P9sz+SegVUWcO0BvuBaZ932NqBr9NXXn+mOi0NqvgiJ2R5o8fOA8qbNDRFEa4j8JhYroU7/5nD0LDwUJPSAWIvUG+wLiBAbWSSn3RMt5tdfmww5MVo1tWVW+T2jcDB+0s/6lF4tAC7MSXFv6IpMx9+5WMwz4pwQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=op4V66n/UXRW6FyBCeIN+WP0ySiF94rkWc6FafgtJa0=;
 b=6k9SugG66QvHHxz3hMEy4xVuHdMpGYJW8ELVR6T7ZUeRDALON2ib+rgpeaPXmomk3of2Ca7U5k6DDeCnOQB9vbhX8eoF7igm0WoEqW84Q31AIv9JaUFQ0/6gapbAqHYx/8sIB0hdpTSVsLziSOBEfc5Ei7Tn8t3Gbm/FHeViApk=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com;
From: Penny Zheng <penny.zheng@arm.com>
To: <xen-devel@lists.xenproject.org>, <sstabellini@kernel.org>,
	<julien@xen.org>
CC: <Bertrand.Marquis@arm.com>, <Wei.Chen@arm.com>
Subject: [PATCH v6 07/11] xen/arm: if direct-map domain use native addresses for GICv2
Date: Mon, 14 Feb 2022 03:19:52 +0000
Message-ID: <20220214031956.3726764-8-penny.zheng@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220214031956.3726764-1-penny.zheng@arm.com>
References: <20220214031956.3726764-1-penny.zheng@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 1
X-MS-Office365-Filtering-Correlation-Id: ea5ab49d-5b45-49ac-44aa-08d9ef6911b5
X-MS-TrafficTypeDiagnostic:
	DBBPR08MB4887:EE_|VE1EUR03FT027:EE_|PAXPR08MB6880:EE_
X-Microsoft-Antispam-PRVS:
	<PAXPR08MB6880E661E8E91BF4E45942D0F7339@PAXPR08MB6880.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 65EDMwFw7r/1JnM1TrD/hhq3bNp0mlzRWmPFDYvS0ieKAT/Tra3Tku8bGP7vTCt4aLI4zGAMCyVnbufuDDzJ4dTxvcElJkeT8KQBz5vwx2G6V+LKWbK1nUmiZqari0xSKf9Dn5ie/Y1HoAvh33uVZSvdEapoqP39QGAVluauI6BrhERGKugpq8LG1QvgZgDmqOCLZQblmlqZIEJmV10ve/MZRpLEZpES2X2ZxhOostqClzW3bPDCGD/0h1UjpKnZvGGZDLF56Efx1/VNGZsQ+fFp7ZF2J6VeFYjKCpQBN01BaCxgBuptYirAINvwBaOs4r9acUynNWdiHsBAmVyqOLr/r2MWWlTdzYxi2k/9i6lcuP6auW6PTsJxGwsvmM8IQBNqggRTKwkJbDFUjfg12+Ja64H6r3C6bUpPttnc7SoyZdmOYtAzSQo5DoajiBoK/2PmNqbPj8LgJDXOaKAJ5dkFE7QER5fDG8H3E2+aBH2BcdSgy/9B36w7HyIXwAEY+FU9zpLeCQb7Y59jKHARP1cDDB6EH/MyqAI6l1Dh58oGjUA7Q6WSvJZBIfMZRTcYLfMKSQVKWl74YpUZ6Takaw/SSBdh/lsOLmTbjN8Vd3hpUOyUophKuXWcd3CobCJcdHJd8KxrNFzjF/zjYumSe2iLit3XgdKurn5fmIt6eWdERPZjvMBMyxwmib+HAHjwCN7j8sOY+b9AfoTJntH0iQ==
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(8676002)(40460700003)(4326008)(36756003)(8936002)(70206006)(70586007)(7696005)(6666004)(36860700001)(44832011)(86362001)(5660300002)(186003)(336012)(426003)(1076003)(2616005)(26005)(316002)(83380400001)(81166007)(508600001)(82310400004)(110136005)(47076005)(54906003)(356005)(2906002)(36900700001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4887
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT027.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	452b18ba-45b1-4296-57c8-08d9ef690afd
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	xFP0qlXNUFm3RJK9jtcLPdUsbbLmpBeK8Vq6LzFDZMKESYOZ14sWO9M+GObF1TlaQvbS6/JFuaTGCm7qcPMFsjUeYq5PvgprljnQB68ea9vRBT87MvOMO3aqy9AOkNZBevvHXzl/JFw+cop+6LzaDWHQLQPGVmU+2mcCFIDybQxTwoDaCXlsS7IwJzfGa+ki6dqdToQVeC5s6Pkl4R4VQEjt7nml9susPFGGKkOnTYvw5B+bmeomlAoeuk4eb70vY5cieylTiGQmWtABtjpSF78VxvnIouMS6i9qsk8pWbr44L/Rf/Uvb4DOzSgLH/XPNCKPlQqsA9oHGRJjXA2stSmcOXAuXUUgyQ4qi2KoDXcimpVPQkpdgR381waio4JjQIxb2P2EoRPNIAZ/y55PbjDyhABKalY3RqKDdbFKgspq4qiPz6U71C14+gkIoRMiKxJ6IK0lCKTYq6fLtjRYUKRURXzDv7Pcb1PnSBZfBJThsWZioMEVKO7iXqwwzvRp7sF4olLh3zhDeW+t2lRZCyBrnWMbQ8dnuxnxQNuVl2QSBHyeHJl6S80KkLf06uPtGLAwU1LU8BlCkU2OXRvPGt7OBFx25dnp1VVPqWjz53rVWqBGWx35aQ0kH084nG6+dczdtttR11HY5zsq5lfWKA==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(81166007)(8936002)(426003)(2906002)(5660300002)(44832011)(1076003)(186003)(83380400001)(336012)(36756003)(2616005)(36860700001)(26005)(47076005)(82310400004)(70206006)(316002)(110136005)(54906003)(7696005)(8676002)(4326008)(508600001)(6666004)(70586007)(86362001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2022 03:21:19.6082
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: ea5ab49d-5b45-49ac-44aa-08d9ef6911b5
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT027.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6880

From: Stefano Stabellini <sstabellini@kernel.org>

Today we use native addresses to map the GICv2 for Dom0 and fixed
addresses for DomUs.

This patch changes the behavior so that native addresses are used for
all domains that are direct-mapped.

NEW VGIC has different naming schemes, like referring distributor base
address as vgic_dist_base, other than the dbase. So this patch also introduces
vgic_dist_base/vgic_cpu_base accessor to access correct distributor base
address/cpu interface base address on varied scenarios,

Signed-off-by: Stefano Stabellini <sstabellini@kernel.org>
Signed-off-by: Penny Zheng <penny.zheng@arm.com>
Reviewed-by: Julien Grall <jgrall@amazon.com>
Tested-by: Stefano Stabellini <sstabellini@kernel.org>
---
v2 changes
- combine all changes in patch 4-6 here
---
v3 changes
- refine comment message
- add a comment explaining how the 38 was found of "char buf[38]"
- simply map the CPU interface at the GPA vgic_v2_hw.cbase
- remove a spurious change
---
v4 changes:
- refine comment to let it be a summary of the if/else if/else.
---
v5 changes:
- nothing changed
---
v6 changes:
- nothing changed
---
 xen/arch/arm/domain_build.c         | 11 +++++++---
 xen/arch/arm/include/asm/new_vgic.h | 10 +++++++++
 xen/arch/arm/include/asm/vgic.h     | 11 ++++++++++
 xen/arch/arm/vgic-v2.c              | 34 +++++++++++++++++++++++------
 xen/arch/arm/vgic/vgic-v2.c         | 34 +++++++++++++++++++++++------
 5 files changed, 83 insertions(+), 17 deletions(-)

diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index 52f256de9c..87391adde6 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -2273,8 +2273,13 @@ static int __init make_gicv2_domU_node(struct kernel_info *kinfo)
     int res = 0;
     __be32 reg[(GUEST_ROOT_ADDRESS_CELLS + GUEST_ROOT_SIZE_CELLS) * 2];
     __be32 *cells;
+    const struct domain *d = kinfo->d;
+    /* Placeholder for interrupt-controller@ + a 64-bit number + \0 */
+    char buf[38];
 
-    res = fdt_begin_node(fdt, "interrupt-controller@"__stringify(GUEST_GICD_BASE));
+    snprintf(buf, sizeof(buf), "interrupt-controller@%"PRIx64,
+             vgic_dist_base(&d->arch.vgic));
+    res = fdt_begin_node(fdt, buf);
     if ( res )
         return res;
 
@@ -2296,9 +2301,9 @@ static int __init make_gicv2_domU_node(struct kernel_info *kinfo)
 
     cells = &reg[0];
     dt_child_set_range(&cells, GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS,
-                       GUEST_GICD_BASE, GUEST_GICD_SIZE);
+                       vgic_dist_base(&d->arch.vgic), GUEST_GICD_SIZE);
     dt_child_set_range(&cells, GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS,
-                       GUEST_GICC_BASE, GUEST_GICC_SIZE);
+                       vgic_cpu_base(&d->arch.vgic), GUEST_GICC_SIZE);
 
     res = fdt_property(fdt, "reg", reg, sizeof(reg));
     if (res)
diff --git a/xen/arch/arm/include/asm/new_vgic.h b/xen/arch/arm/include/asm/new_vgic.h
index 97d622bff6..ab57fcd91d 100644
--- a/xen/arch/arm/include/asm/new_vgic.h
+++ b/xen/arch/arm/include/asm/new_vgic.h
@@ -186,6 +186,16 @@ struct vgic_cpu {
     uint32_t num_id_bits;
 };
 
+static inline paddr_t vgic_cpu_base(const struct vgic_dist *vgic)
+{
+    return vgic->vgic_cpu_base;
+}
+
+static inline paddr_t vgic_dist_base(const struct vgic_dist *vgic)
+{
+    return vgic->vgic_dist_base;
+}
+
 #endif /* __ASM_ARM_NEW_VGIC_H */
 
 /*
diff --git a/xen/arch/arm/include/asm/vgic.h b/xen/arch/arm/include/asm/vgic.h
index ade427a808..d2a9fc7d83 100644
--- a/xen/arch/arm/include/asm/vgic.h
+++ b/xen/arch/arm/include/asm/vgic.h
@@ -152,6 +152,7 @@ struct vgic_dist {
     struct pending_irq *pending_irqs;
     /* Base address for guest GIC */
     paddr_t dbase; /* Distributor base address */
+    paddr_t cbase; /* CPU interface base address */
 #ifdef CONFIG_GICV3
     /* GIC V3 addressing */
     /* List of contiguous occupied by the redistributors */
@@ -271,6 +272,16 @@ static inline int REG_RANK_NR(int b, uint32_t n)
 
 enum gic_sgi_mode;
 
+static inline paddr_t vgic_cpu_base(const struct vgic_dist *vgic)
+{
+    return vgic->cbase;
+}
+
+static inline paddr_t vgic_dist_base(const struct vgic_dist *vgic)
+{
+    return vgic->dbase;
+}
+
 /*
  * Offset of GICD_<FOO><n> with its rank, for GICD_<FOO> size <s> with
  * <b>-bits-per-interrupt.
diff --git a/xen/arch/arm/vgic-v2.c b/xen/arch/arm/vgic-v2.c
index 589c033eda..b1bd7a46ad 100644
--- a/xen/arch/arm/vgic-v2.c
+++ b/xen/arch/arm/vgic-v2.c
@@ -654,12 +654,16 @@ static int vgic_v2_vcpu_init(struct vcpu *v)
 static int vgic_v2_domain_init(struct domain *d)
 {
     int ret;
-    paddr_t cbase, csize;
+    paddr_t csize;
     paddr_t vbase;
 
     /*
-     * The hardware domain gets the hardware address.
-     * Guests get the virtual platform layout.
+     * The hardware domain and direct-mapped domain both get the hardware
+     * address.
+     * We have to handle them separately because the hwdom is re-using the
+     * same Device-Tree as the host (see more details below).
+     *
+     * Other domains get the virtual platform layout.
      */
     if ( is_hardware_domain(d) )
     {
@@ -671,10 +675,26 @@ static int vgic_v2_domain_init(struct domain *d)
          * Note that we assume the size of the CPU interface is always
          * aligned to PAGE_SIZE.
          */
-        cbase = vgic_v2_hw.cbase;
+        d->arch.vgic.cbase = vgic_v2_hw.cbase;
         csize = vgic_v2_hw.csize;
         vbase = vgic_v2_hw.vbase;
     }
+    else if ( is_domain_direct_mapped(d) )
+    {
+        /*
+         * For all the direct-mapped domain other than the hardware domain,
+         * we only map a 8kB CPU interface but we make sure it is at a
+         * location occupied by the physical GIC in the host device tree.
+         *
+         * We need to add an offset to the virtual CPU interface base
+         * address when the GIC is aliased to get a 8kB contiguous
+         * region.
+         */
+        d->arch.vgic.dbase = vgic_v2_hw.dbase;
+        d->arch.vgic.cbase = vgic_v2_hw.cbase;
+        csize = GUEST_GICC_SIZE;
+        vbase = vgic_v2_hw.vbase + vgic_v2_hw.aliased_offset;
+    }
     else
     {
         d->arch.vgic.dbase = GUEST_GICD_BASE;
@@ -685,7 +705,7 @@ static int vgic_v2_domain_init(struct domain *d)
          * region.
          */
         BUILD_BUG_ON(GUEST_GICC_SIZE != SZ_8K);
-        cbase = GUEST_GICC_BASE;
+        d->arch.vgic.cbase = GUEST_GICC_BASE;
         csize = GUEST_GICC_SIZE;
         vbase = vgic_v2_hw.vbase + vgic_v2_hw.aliased_offset;
     }
@@ -694,8 +714,8 @@ static int vgic_v2_domain_init(struct domain *d)
      * Map the gic virtual cpu interface in the gic cpu interface
      * region of the guest.
      */
-    ret = map_mmio_regions(d, gaddr_to_gfn(cbase), csize / PAGE_SIZE,
-                           maddr_to_mfn(vbase));
+    ret = map_mmio_regions(d, gaddr_to_gfn(d->arch.vgic.cbase),
+                           csize / PAGE_SIZE, maddr_to_mfn(vbase));
     if ( ret )
         return ret;
 
diff --git a/xen/arch/arm/vgic/vgic-v2.c b/xen/arch/arm/vgic/vgic-v2.c
index b5ba4ace87..1a99d3a8b4 100644
--- a/xen/arch/arm/vgic/vgic-v2.c
+++ b/xen/arch/arm/vgic/vgic-v2.c
@@ -258,13 +258,17 @@ void vgic_v2_enable(struct vcpu *vcpu)
 int vgic_v2_map_resources(struct domain *d)
 {
     struct vgic_dist *dist = &d->arch.vgic;
-    paddr_t cbase, csize;
+    paddr_t csize;
     paddr_t vbase;
     int ret;
 
     /*
-     * The hardware domain gets the hardware address.
-     * Guests get the virtual platform layout.
+     * The hardware domain and direct-mapped domain both get the hardware
+     * address.
+     * We have to handle them separately because the hwdom is re-using the
+     * same Device-Tree as the host (see more details below).
+     *
+     * Other domains get the virtual platform layout.
      */
     if ( is_hardware_domain(d) )
     {
@@ -276,10 +280,26 @@ int vgic_v2_map_resources(struct domain *d)
          * Note that we assume the size of the CPU interface is always
          * aligned to PAGE_SIZE.
          */
-        cbase = gic_v2_hw_data.cbase;
+        d->arch.vgic.vgic_cpu_base = gic_v2_hw_data.cbase;
         csize = gic_v2_hw_data.csize;
         vbase = gic_v2_hw_data.vbase;
     }
+    else if ( is_domain_direct_mapped(d) )
+    {
+        d->arch.vgic.vgic_dist_base = gic_v2_hw_data.dbase;
+        /*
+         * For all the direct-mapped domain other than the hardware domain,
+         * we only map a 8kB CPU interface but we make sure it is at a location
+         * occupied by the physical GIC in the host device tree.
+         *
+         * We need to add an offset to the virtual CPU interface base
+         * address when the GIC is aliased to get a 8kB contiguous
+         * region.
+         */
+        d->arch.vgic.vgic_cpu_base = gic_v2_hw_data.cbase;
+        csize = GUEST_GICC_SIZE;
+        vbase = gic_v2_hw_data.vbase + gic_v2_hw_data.aliased_offset;
+    }
     else
     {
         d->arch.vgic.vgic_dist_base = GUEST_GICD_BASE;
@@ -290,7 +310,7 @@ int vgic_v2_map_resources(struct domain *d)
          * region.
          */
         BUILD_BUG_ON(GUEST_GICC_SIZE != SZ_8K);
-        cbase = GUEST_GICC_BASE;
+        d->arch.vgic.vgic_cpu_base = GUEST_GICC_BASE;
         csize = GUEST_GICC_SIZE;
         vbase = gic_v2_hw_data.vbase + gic_v2_hw_data.aliased_offset;
     }
@@ -308,8 +328,8 @@ int vgic_v2_map_resources(struct domain *d)
      * Map the gic virtual cpu interface in the gic cpu interface
      * region of the guest.
      */
-    ret = map_mmio_regions(d, gaddr_to_gfn(cbase), csize / PAGE_SIZE,
-                           maddr_to_mfn(vbase));
+    ret = map_mmio_regions(d, gaddr_to_gfn(d->arch.vgic.vgic_cpu_base),
+                           csize / PAGE_SIZE, maddr_to_mfn(vbase));
     if ( ret )
     {
         gdprintk(XENLOG_ERR, "Unable to remap VGIC CPU to VCPU\n");
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 03:21:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 03:21:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271075.465466 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJRvd-0000lU-60; Mon, 14 Feb 2022 03:21:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271075.465466; Mon, 14 Feb 2022 03:21:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJRvc-0000jR-O7; Mon, 14 Feb 2022 03:21:28 +0000
Received: by outflank-mailman (input) for mailman id 271075;
 Mon, 14 Feb 2022 03:21:27 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=aDlx=S5=arm.com=Penny.Zheng@srs-se1.protection.inumbo.net>)
 id 1nJRva-0007B5-P8
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 03:21:26 +0000
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur02on061a.outbound.protection.outlook.com
 [2a01:111:f400:fe07::61a])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3069747a-8d45-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 04:21:25 +0100 (CET)
Received: from AM6P195CA0107.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:86::48)
 by DB9PR08MB6973.eurprd08.prod.outlook.com (2603:10a6:10:2bc::13) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.17; Mon, 14 Feb
 2022 03:21:23 +0000
Received: from VE1EUR03FT042.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:86:cafe::aa) by AM6P195CA0107.outlook.office365.com
 (2603:10a6:209:86::48) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11 via Frontend
 Transport; Mon, 14 Feb 2022 03:21:23 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT042.mail.protection.outlook.com (10.152.19.62) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4975.11 via Frontend Transport; Mon, 14 Feb 2022 03:21:22 +0000
Received: ("Tessian outbound 826a6d8e58c3:v113");
 Mon, 14 Feb 2022 03:21:22 +0000
Received: from 8c3fe565e400.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 997CE106-D74D-4D5A-9B62-E657899B0A6C.1; 
 Mon, 14 Feb 2022 03:21:15 +0000
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8c3fe565e400.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 14 Feb 2022 03:21:15 +0000
Received: from AS8PR04CA0184.eurprd04.prod.outlook.com (2603:10a6:20b:2f3::9)
 by AM0PR08MB4962.eurprd08.prod.outlook.com (2603:10a6:208:15a::31)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Mon, 14 Feb
 2022 03:21:13 +0000
Received: from AM5EUR03FT040.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:2f3:cafe::d8) by AS8PR04CA0184.outlook.office365.com
 (2603:10a6:20b:2f3::9) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.18 via Frontend
 Transport; Mon, 14 Feb 2022 03:21:13 +0000
Received: from nebula.arm.com (40.67.248.234) by
 AM5EUR03FT040.mail.protection.outlook.com (10.152.17.148) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.4975.11 via Frontend Transport; Mon, 14 Feb 2022 03:21:13 +0000
Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX03.Arm.com
 (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 14 Feb
 2022 03:21:17 +0000
Received: from penny.shanghai.arm.com (10.169.188.91) by mail.arm.com
 (10.251.24.31) with Microsoft SMTP Server id 15.1.2308.20 via Frontend
 Transport; Mon, 14 Feb 2022 03:21:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3069747a-8d45-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=8+EdtF5Eoz17ctXTfNPy+lev1ALcPCfwOoK+hIw6c4I=;
 b=CTRJynQyC4iCAbDP7f8fZnBuGDYP+iYwlf7872YurhlDYqvuiEB2TtR7KBMuvWfY4rwiXRV4+lKHN2dYvBOCryat5qOC4uAFG+JM10h4yKxqF+yY18sCCZnu4hXHyxjbBoCY9S8B1QBGqFuqAECEtBMjgMh/9t7V1JhGUshgztw=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 9ab8caaaae34ad5f
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=GXskdfmAsQiJ2GqhvhcgHLOdu2Y26E/G0tai+uaEIjBcDbwqh2WBmY/DfZ8Jf2N7+08PTR9rHmGWIjT9kTKMtXJKl3/OWvTQRVjH2yPsCrQRBs5O6HUrqVWomTxDXHK3dPcKC6PaQsBKY89fhnI8cKrGCWYXJeVfq6WRe/6ONMQA+MrJuCRmXK/3XQ8omow6GwM34DwHf8rbkwY4sIQrQYaiZbLnqmdnmL8WfXDAdmhmSh9bNZKQvzQrUegDU6AToQ4/QYE9ZoCQNJAwF7+1JdaLrG9Mt6gLqGlhXZUysbVW/oVYmAnANNeUxKMxTNVK6NIAhfCdo2n9Pokbk77nvg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=8+EdtF5Eoz17ctXTfNPy+lev1ALcPCfwOoK+hIw6c4I=;
 b=HzIeU+bMKjiE0lFR4azwOuSjjrOHbaDOFxLSfmPSXuM64Gyw8RGBeC9OHMSEJSkdIPwplU/85UYPlLmtXyvOPKB5cEkgb6n8kC2KsFAfY/ZvTfl2mHK0mpd/kuFhVdgM2MigKlxQNzj8tpqo01VtXZbcXWp7HTcrx9v8Xi7nlES9qtX8+S9H1NDGpzESkwb23c/M5L7FrYQqfGx70lSrO629Fx7Fc4GTrnQyuzI7uKTMd02VFelX3cKaI4SZ2QBtb/dDumwmbeXhAISJyfU/98a//VfpUY69I5f/VD1xEYVLOeWg8GzA0ouN2WOiUmVHQyhHjy/D90ny7oKRFLqmJQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=8+EdtF5Eoz17ctXTfNPy+lev1ALcPCfwOoK+hIw6c4I=;
 b=CTRJynQyC4iCAbDP7f8fZnBuGDYP+iYwlf7872YurhlDYqvuiEB2TtR7KBMuvWfY4rwiXRV4+lKHN2dYvBOCryat5qOC4uAFG+JM10h4yKxqF+yY18sCCZnu4hXHyxjbBoCY9S8B1QBGqFuqAECEtBMjgMh/9t7V1JhGUshgztw=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com;
From: Penny Zheng <penny.zheng@arm.com>
To: <xen-devel@lists.xenproject.org>, <sstabellini@kernel.org>,
	<julien@xen.org>
CC: <Bertrand.Marquis@arm.com>, <Wei.Chen@arm.com>
Subject: [PATCH v6 09/11] xen/arm: if direct-map domain use native addresses for GICv3
Date: Mon, 14 Feb 2022 03:19:54 +0000
Message-ID: <20220214031956.3726764-10-penny.zheng@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220214031956.3726764-1-penny.zheng@arm.com>
References: <20220214031956.3726764-1-penny.zheng@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 1
X-MS-Office365-Filtering-Correlation-Id: 9f4d2ce9-69f7-4042-8347-08d9ef69136a
X-MS-TrafficTypeDiagnostic:
	AM0PR08MB4962:EE_|VE1EUR03FT042:EE_|DB9PR08MB6973:EE_
X-Microsoft-Antispam-PRVS:
	<DB9PR08MB6973D1EDC17951D30028A87AF7339@DB9PR08MB6973.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:6430;OLM:6430;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 eHD1O12Kj0SGr1X2cg8fAo0czXNM4i3qXqIH93bbs5Tgl10FM0Ya2ArJKV/Ttle1op80O0Ed+AGOd/gTkxEiRIVwszeuUeD4XPvRCiusKuqpzlFXvnfWx/Pw0C5d+be1+QAv08v6nhfxQ2bhXrLWwOHWwdy1TwkBo0tGmLSvbIy52SP1MxGD5S4FuKIQxkJtzkVIEeAam4cT2ygrokyJ5IG301HbmuX2JIXdzqiJyOlyKV3L2JAamkjDQh0QU7FgOBTxGe0k4/IQ1nbGuvvFKktGmGtJi7r9pZ7Q/C5XTH7W7cDxeWppEiP5rpFZWYBzqK8y6Y6XfE5Rd04zidljMXSd5N1+j55FdhpWT31OAz5iHlh/mBztVWpkxqLTxzcwDVLKHzddPedIEu5V1RSRoaRGYTY6WWyUuR9SR0pF/IbdLwaDVy/bndeosW8IhQxBNuI+6xEVuIgK5oTZk987efIqLQYLEXT7lX3IH+Rvl5XKVbTo26K7wqaN/x5GS65DcGjshKrXBrGgDWRtVK9AiBpTG+TKWiAY5crvUZxyLgSY64MU0oWN3mNfYrJwkYY6j29NqUFlXpiWiHwWvWD/JubWaA2AupoNxSiI92wnfzudm7VcnCy1eMChNVe7Eb++Rujb8SjrQSnRbIFsWTZ9NmUz17sI+T661N5UigScfiCWUqkil/cLye+NjMtkTzAnNgjgZd/i4iNGBuLG7SsFfQ==
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(110136005)(508600001)(4326008)(70586007)(2616005)(8676002)(2906002)(70206006)(81166007)(82310400004)(54906003)(186003)(26005)(356005)(1076003)(316002)(83380400001)(6666004)(8936002)(40460700003)(44832011)(47076005)(7696005)(5660300002)(336012)(426003)(86362001)(36860700001)(36756003)(36900700001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4962
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT042.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	31ce6402-b8f6-43dd-d7b0-08d9ef690e06
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	NSXoTmDLBVYxJoWrTPZgL3LqoImiJ5SLOSii0af5dESizqcHQiMZEX6J7q9xDEeh1u5KCVwbW2F108g24H5SwY5hXWcLGlc6PqoAxdbHhGhjHXeNH476WQlGqihsQkZbE/PWS8yRB2a1vCPRJEVjHnnolHDFPxf/mRmw5Jjd8jtSHq5aVd1tqewAp7Whho98PoC6osQGDRNhrk5TVTzcjZU/cFCS6yQkPKfTSMDypt+1lNHt98Q9Y0DJ+LiJyx3OV4kNuu/i64QeNk5MsbbFbHmuu88N5uKEHqj/i/KS5i37wmWhNaws7AfhQuUPmT8oTcdJAZEr7eqhlIASYt/f6hciJdm0Y7eESOL42u10oh+WgYJHy/nTnBCUsWQz+U1CV0C4v8PDtgJ8QYspCqtAvv/j2EHdewS0yPuM74xRHHF66t1DsoGDpsQjwRZpEOfOH9eTFWaOPvLp9Ek5qC58WlOKYjCUmzOEif9hyrb+iJgDiX1WDTTwWnwGt7kgMd0obw87bObkIzRitFOTovSt+IOlVHEjrSXTsnZ0dNm91+pYdS3btk8ASTKyTkzkb4gZHbNZRSY82pA5xFNqEDcU+4Yvr1EvE6ypLuzI9yWp+yRf5TmUYOwBOgf6h+WJOKHnTij+AYMRM8qJ16i0pyYbUg==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(36860700001)(110136005)(7696005)(6666004)(54906003)(2616005)(86362001)(8936002)(36756003)(26005)(83380400001)(186003)(426003)(5660300002)(2906002)(82310400004)(508600001)(336012)(4326008)(1076003)(8676002)(44832011)(47076005)(316002)(81166007)(70586007)(70206006);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2022 03:21:22.4894
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 9f4d2ce9-69f7-4042-8347-08d9ef69136a
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT042.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6973

From: Stefano Stabellini <sstabellini@kernel.org>

Today we use native addresses to map the GICv3 for Dom0 and fixed
addresses for DomUs.

This patch changes the behavior so that native addresses are used for
all domain which is using the host memory layout

Considering that DOM0 may not always be directly mapped in the future,
this patch introduces a new helper "domain_use_host_layout()" that
wraps both two check "is_domain_direct_mapped(d) || is_hardware_domain(d)"
for more flexible usage.

Signed-off-by: Stefano Stabellini <sstabellini@kernel.org>
Signed-off-by: Penny Zheng <penny.zheng@arm.com>
Reviewed-by: Julien Grall <jgrall@amazon.com>
Tested-by: Stefano Stabellini <sstabellini@kernel.org>
---
v2 changes:
- remove redistributor accessor
- introduce new helper "is_domain_use_host_layout()"
- comment fix
---
v3 changes:
- the comment on top of 'buf' to explain how 38 was found
- fix res getting overwritten
- drop 'cells += (GUEST_ROOT_ADDRESS_CELLS + GUEST_ROOT_SIZE_CELLS)'
- free 'reg' right way
- fix comment
- rename 'is_domain_use_host_layout()' to 'domain_use_host_layout()'
---
v4 changes:
- refine comment
---
v5 changes:
- nothing changed
---
v6 changes:
- refine comment
---
 xen/arch/arm/domain_build.c       | 34 +++++++++++++++++++++++--------
 xen/arch/arm/include/asm/domain.h | 14 +++++++++++++
 xen/arch/arm/vgic-v3.c            | 30 ++++++++++++++-------------
 3 files changed, 56 insertions(+), 22 deletions(-)

diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index a01dc60b55..cff2cb93cc 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -2327,10 +2327,16 @@ static int __init make_gicv3_domU_node(struct kernel_info *kinfo)
 {
     void *fdt = kinfo->fdt;
     int res = 0;
-    __be32 reg[(GUEST_ROOT_ADDRESS_CELLS + GUEST_ROOT_SIZE_CELLS) * 2];
-    __be32 *cells;
+    __be32 *reg, *cells;
+    const struct domain *d = kinfo->d;
+    /* Placeholder for interrupt-controller@ + a 64-bit number + \0 */
+    char buf[38];
+    unsigned int i, len = 0;
+
+    snprintf(buf, sizeof(buf), "interrupt-controller@%"PRIx64,
+             vgic_dist_base(&d->arch.vgic));
 
-    res = fdt_begin_node(fdt, "interrupt-controller@"__stringify(GUEST_GICV3_GICD_BASE));
+    res = fdt_begin_node(fdt, buf);
     if ( res )
         return res;
 
@@ -2350,13 +2356,25 @@ static int __init make_gicv3_domU_node(struct kernel_info *kinfo)
     if ( res )
         return res;
 
-    cells = &reg[0];
-    dt_child_set_range(&cells, GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS,
-                       GUEST_GICV3_GICD_BASE, GUEST_GICV3_GICD_SIZE);
+    /* reg specifies all re-distributors and Distributor. */
+    len = (GUEST_ROOT_ADDRESS_CELLS + GUEST_ROOT_SIZE_CELLS) *
+          (d->arch.vgic.nr_regions + 1) * sizeof(__be32);
+    reg = xmalloc_bytes(len);
+    if ( reg == NULL )
+        return -ENOMEM;
+    cells = reg;
+
     dt_child_set_range(&cells, GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS,
-                       GUEST_GICV3_GICR0_BASE, GUEST_GICV3_GICR0_SIZE);
+                       vgic_dist_base(&d->arch.vgic), GUEST_GICV3_GICD_SIZE);
 
-    res = fdt_property(fdt, "reg", reg, sizeof(reg));
+    for ( i = 0; i < d->arch.vgic.nr_regions; i++ )
+        dt_child_set_range(&cells,
+                           GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS,
+                           d->arch.vgic.rdist_regions[i].base,
+                           d->arch.vgic.rdist_regions[i].size);
+
+    res = fdt_property(fdt, "reg", reg, len);
+    xfree(reg);
     if (res)
         return res;
 
diff --git a/xen/arch/arm/include/asm/domain.h b/xen/arch/arm/include/asm/domain.h
index aabe942cde..c56f6e4398 100644
--- a/xen/arch/arm/include/asm/domain.h
+++ b/xen/arch/arm/include/asm/domain.h
@@ -31,6 +31,20 @@ enum domain_type {
 
 #define is_domain_direct_mapped(d) (d)->arch.directmap
 
+/*
+ * Is the domain using the host memory layout?
+ *
+ * Direct-mapped domain will always have the RAM mapped with GFN == MFN.
+ * To avoid any trouble finding space, it is easier to force using the
+ * host memory layout.
+ *
+ * The hardware domain will use the host layout regardless of
+ * direct-mapped because some OS may rely on a specific address ranges
+ * for the devices.
+ */
+#define domain_use_host_layout(d) (is_domain_direct_mapped(d) || \
+                                   is_hardware_domain(d))
+
 struct vtimer {
     struct vcpu *v;
     int irq;
diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c
index 65bb7991a6..e4ba9a6476 100644
--- a/xen/arch/arm/vgic-v3.c
+++ b/xen/arch/arm/vgic-v3.c
@@ -1640,14 +1640,15 @@ static inline unsigned int vgic_v3_max_rdist_count(struct domain *d)
      * Normally there is only one GICv3 redistributor region.
      * The GICv3 DT binding provisions for multiple regions, since there are
      * platforms out there which need those (multi-socket systems).
-     * For Dom0 we have to live with the MMIO layout the hardware provides,
-     * so we have to copy the multiple regions - as the first region may not
-     * provide enough space to hold all redistributors we need.
-     * However DomU get a constructed memory map, so we can go with
-     * the architected single redistributor region.
+     * For domain using the host memory layout, we have to live with the MMIO
+     * layout the hardware provides, so we have to copy the multiple regions
+     * - as the first region may not provide enough space to hold all
+     * redistributors we need.
+     * All the other domains will get a constructed memory map, so we can go
+     * with the architected single redistributor region.
      */
-    return is_hardware_domain(d) ? vgic_v3_hw.nr_rdist_regions :
-               GUEST_GICV3_RDIST_REGIONS;
+    return domain_use_host_layout(d) ? vgic_v3_hw.nr_rdist_regions :
+                                       GUEST_GICV3_RDIST_REGIONS;
 }
 
 static int vgic_v3_domain_init(struct domain *d)
@@ -1669,10 +1670,11 @@ static int vgic_v3_domain_init(struct domain *d)
     radix_tree_init(&d->arch.vgic.pend_lpi_tree);
 
     /*
-     * Domain 0 gets the hardware address.
-     * Guests get the virtual platform layout.
+     * For domain using the host memory layout, it gets the hardware
+     * address.
+     * Other domains get the virtual platform layout.
      */
-    if ( is_hardware_domain(d) )
+    if ( domain_use_host_layout(d) )
     {
         unsigned int first_cpu = 0;
 
@@ -1695,10 +1697,10 @@ static int vgic_v3_domain_init(struct domain *d)
         }
 
         /*
-         * The hardware domain may not use all the re-distributors
-         * regions (e.g when the number of vCPUs does not match the
-         * number of pCPUs). Update the number of regions to avoid
-         * exposing unused region as they will not get emulated.
+         * For domain using the host memory layout, it may not use all
+         * the re-distributors regions (e.g when the number of vCPUs does
+         * not match the number of pCPUs). Update the number of regions to
+         * avoid exposing unused region as they will not get emulated.
          */
         d->arch.vgic.nr_regions = i + 1;
 
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 03:21:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 03:21:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271076.465471 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJRvd-0000um-RZ; Mon, 14 Feb 2022 03:21:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271076.465471; Mon, 14 Feb 2022 03:21:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJRvd-0000sr-G3; Mon, 14 Feb 2022 03:21:29 +0000
Received: by outflank-mailman (input) for mailman id 271076;
 Mon, 14 Feb 2022 03:21:28 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=aDlx=S5=arm.com=Penny.Zheng@srs-se1.protection.inumbo.net>)
 id 1nJRvb-0007B4-U8
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 03:21:28 +0000
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur01on061d.outbound.protection.outlook.com
 [2a01:111:f400:fe1e::61d])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 318beeb5-8d45-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 04:21:27 +0100 (CET)
Received: from AM6PR04CA0027.eurprd04.prod.outlook.com (2603:10a6:20b:92::40)
 by VI1PR08MB3022.eurprd08.prod.outlook.com (2603:10a6:803:41::25)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Mon, 14 Feb
 2022 03:21:16 +0000
Received: from VE1EUR03FT027.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:92:cafe::98) by AM6PR04CA0027.outlook.office365.com
 (2603:10a6:20b:92::40) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.15 via Frontend
 Transport; Mon, 14 Feb 2022 03:21:16 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT027.mail.protection.outlook.com (10.152.18.154) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4975.11 via Frontend Transport; Mon, 14 Feb 2022 03:21:15 +0000
Received: ("Tessian outbound 2877e54fe176:v113");
 Mon, 14 Feb 2022 03:21:15 +0000
Received: from 2f95158a49a2.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 83B4BB29-FEA0-4D64-A62A-0878618A94C8.1; 
 Mon, 14 Feb 2022 03:21:09 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 2f95158a49a2.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 14 Feb 2022 03:21:09 +0000
Received: from AS8PR04CA0176.eurprd04.prod.outlook.com (2603:10a6:20b:331::31)
 by VI1PR08MB4590.eurprd08.prod.outlook.com (2603:10a6:803:c3::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.17; Mon, 14 Feb
 2022 03:21:06 +0000
Received: from AM5EUR03FT026.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:331:cafe::c4) by AS8PR04CA0176.outlook.office365.com
 (2603:10a6:20b:331::31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.19 via Frontend
 Transport; Mon, 14 Feb 2022 03:21:06 +0000
Received: from nebula.arm.com (40.67.248.234) by
 AM5EUR03FT026.mail.protection.outlook.com (10.152.16.155) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.4975.11 via Frontend Transport; Mon, 14 Feb 2022 03:21:06 +0000
Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX03.Arm.com
 (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 14 Feb
 2022 03:21:10 +0000
Received: from penny.shanghai.arm.com (10.169.188.91) by mail.arm.com
 (10.251.24.31) with Microsoft SMTP Server id 15.1.2308.20 via Frontend
 Transport; Mon, 14 Feb 2022 03:21:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 318beeb5-8d45-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=NA3/zFgsd8czwwlA2vS7TK6OY5eYCgsFdWBPbAyOYuI=;
 b=wfYRLJrq67BbINzObSsLLYvF68MlhQQ0sUbSTmyoy5KmgAiHcgd3LuS0yMJ+fBt+X5MXHhD0ut3m6wsQAl0ErYAPnJc8WuT89ZeDQPXhcwzU7M0QHkjzCPm7NauEDdeoxq0CcYp6rNYsumGqZG47wGMegirzz8xdC2ZicEpfHDs=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: ef95869d07175b08
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=VFTH8IxnJjqD2STISE2u8vrCQftScDLU7DiSLIZEh1FIZsS8V1aEfcBZHZMKYWZiGiO29esc4+9E2UMUjgxKFb0SzsHYPC9JRu0Y1zjzqtbrmJXa6uTaq2HygZ2D7Xp6WirzZ7Y9iOVK/kYjYGM1u8ra0N9I0fat6PlgCj5le/oLJ+PdmSWgl3TnIcWuceRMLi39J6Z5gZdb8l5LwtLBF0SFCDqO9hRmXyqgfamyKMdmqoA4PGZO5aPSjlq2tkMyoi6duzL5OPp/+lC3L00jQjxqrovrxuI4PfR5z1raJUFmbyIrQzF13hPvsjD+eucXTI/o+Hrf/uk/UXBbgG4o4w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=NA3/zFgsd8czwwlA2vS7TK6OY5eYCgsFdWBPbAyOYuI=;
 b=aE/mVwJIl9qy/cY/okStLtDn5n8qXatoEneArWOpVPIrfce0VzJ156xJnMNVc1iwQJwvYAhVPg+67Vaf/idYdQ2Y9dZtprgDOAURFPRTAIgfj+reNWGEYDwVY0UH98GmVeCX6gfJysr6nYjIkDRzxHFIAu+SncembhMDQFn0Co3UMmKDxkV7S5QHiHNc6O5PUevH0L40Do5NZ4VAbxkgOcyE4orUzHsKUZpToHTrpeKihUsrkbrNPpbJruL6tZEhytsh0RX73Aaa8WcQoQCnhlgspIe9bhJ6OFoj6qigpCfg9ZMjkANgLqzbPF8qwPPrZO343JiqY6xwrnPHvgWjAA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=NA3/zFgsd8czwwlA2vS7TK6OY5eYCgsFdWBPbAyOYuI=;
 b=wfYRLJrq67BbINzObSsLLYvF68MlhQQ0sUbSTmyoy5KmgAiHcgd3LuS0yMJ+fBt+X5MXHhD0ut3m6wsQAl0ErYAPnJc8WuT89ZeDQPXhcwzU7M0QHkjzCPm7NauEDdeoxq0CcYp6rNYsumGqZG47wGMegirzz8xdC2ZicEpfHDs=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com;
From: Penny Zheng <penny.zheng@arm.com>
To: <xen-devel@lists.xenproject.org>, <sstabellini@kernel.org>,
	<julien@xen.org>
CC: <Bertrand.Marquis@arm.com>, <Wei.Chen@arm.com>
Subject: [PATCH v6 06/11] xen/arm: add ASSERT_UNREACHABLE in allocate_static_memory
Date: Mon, 14 Feb 2022 03:19:51 +0000
Message-ID: <20220214031956.3726764-7-penny.zheng@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220214031956.3726764-1-penny.zheng@arm.com>
References: <20220214031956.3726764-1-penny.zheng@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 1
X-MS-Office365-Filtering-Correlation-Id: 8cf46b9c-100a-49a9-cc37-08d9ef690f6a
X-MS-TrafficTypeDiagnostic:
	VI1PR08MB4590:EE_|VE1EUR03FT027:EE_|VI1PR08MB3022:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR08MB3022D78899480CAB7B9B6585F7339@VI1PR08MB3022.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:326;OLM:326;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 8/Yuw2l6JSKob5EkCWsq+HxIVYNw2YnDp2eJm/iwL39VAAHnejz5zd1D9eQQy1BSmghWjlJurkO//SbTNabMeqo8Cmymwn04yeJj3JQ8jg5+vNCtHwH98icEr/OArXDyHOeBD03v+2b56r9p/cKw5qjtk0yRVlbawIVTHmKOvNU+/uVMsKFje3oo6UX0egvtDyMC/zwj9fCbubrQESsx0EPJSlMyOdox+zb21AhfJ1578yWPG37tMBhvZr/Y5gbd6wxdRRRm2wq6S1AYYdkERZtw0n1k2h+OVY108kHuWym0eiYzbYhZKjYjHgTmIlBarYwPejUwHCOnuKjDpw/RUJsdN4r6lWyDcFBFR7HpUQUXKpvBFkmZfeAE6S3yn/JVudpjJG5vHtlUusNKeLueIKQLn8XuKvZbeuDidfhqoxqN2d9+pPceXCE5as6Z7Fi/AZdZ2YRV6VhWSznuXm/EnLTB1nRZW8XVdKz3LcXU/Lfzm5RQhbjkrlW2uxNp+iSKzfiZIu4yseNDRYmxJJuWbTTtehfrr7EPHC3ZbGeq9P4pC+N31Vs0quKBuUyMoi1fm+sHhciGzwjdmN/tfawgT2kKSeqEq0+/qj6jbUP5TJjdZ4EBBWk6IDFGlo+kFvujTqTZq2LckyJDy+/ZyCxuZhllNRVqT+g/a1UXWpHrQsQi2yg1SaZAveDJbnCztyi/
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(47076005)(508600001)(54906003)(1076003)(6666004)(110136005)(316002)(2616005)(36860700001)(426003)(336012)(70586007)(70206006)(356005)(36756003)(81166007)(8676002)(4326008)(186003)(7696005)(26005)(8936002)(5660300002)(4744005)(44832011)(86362001)(82310400004)(2906002)(36900700001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4590
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT027.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	9ce4d7a6-3342-4bb2-07c5-08d9ef6909a6
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	wund4c2iZ4camLE9JUYfaubc9q/gyzSkyw7HC1ncB/4jcwaqF6OSLhGiNoQPqz5RlRHIHZtfMXYTEhGHN0wqsr99jm07PFU1w2NC5+UcGVTu0rJd8lAd+EwtZL76S7tZsHPStz6NEXhb5bk2r1W3ZXXz0n49LFN0+qfUGqAVrFJLncWNkfH8d7Fgrby2g08zbnli38G6czoUjV7OOX8ulVT8SwbPJjWicAOB4G6BSZ0xE/5CHik05LxSQO+inPxLYaGTfnVpZIm3fOekWy+z0zwt4KV39S/E/DVXKrBeAlHUUe0ZaPnDj++qeuuMtTbMUD5+1Lj6i+NqvcwkqEpPLLWUM8iF2Wuj4kr0vSp926bfcroOoX7jKyKDLl2jGe9F9zXITfpotYYI/wItb6CVLpmKXu8NmUSDD+zyc0H7MeIjvvlbOz19LYiMHeiYDH+bUFnnZkqeYO0KecngW3/UVyss5Yd+ffXd4i5pNqnzcHaefa/K/xLcq4d+ds5MG5tEdX4oAkcu0eIZKanS+T1ofUgl8ORtgmeC0anCAQxroctv3zRg2Q/r+YIc6b+vZiLvz+XS1tRm/tlX2c6RbWahaCI8zTPG+FZtkTk0TxkHvtAL4OMBcBeyPg5BC5hKipmK8Gk+1o57ZsK7MNhV1xKwVg==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(70586007)(70206006)(6666004)(36756003)(82310400004)(316002)(5660300002)(336012)(426003)(2616005)(4744005)(2906002)(44832011)(26005)(186003)(1076003)(86362001)(4326008)(8936002)(8676002)(7696005)(36860700001)(508600001)(47076005)(81166007)(54906003)(110136005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2022 03:21:15.7804
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 8cf46b9c-100a-49a9-cc37-08d9ef690f6a
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT027.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3022

Helper allocate_static_memory is not meant to be reachable when built with
!CONFIG_STATIC_MEMORY, so this commit adds ASSERT_UNREACHABLE in it to catch
potential misuse.

Signed-off-by: Penny Zheng <penny.zheng@arm.com>
Acked-by: Julien Grall <jgrall@amazon.com>
Tested-by: Stefano Stabellini <sstabellini@kernel.org>
---
v3 changes:
- new commit
---
v4 changes:
- nothing changed
---
v5 changes:
- nothing changed
---
v6 changes:
- nothing changed
---
 xen/arch/arm/domain_build.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index ec29bd302c..52f256de9c 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -755,6 +755,7 @@ static void __init allocate_static_memory(struct domain *d,
                                           struct kernel_info *kinfo,
                                           const struct dt_device_node *node)
 {
+    ASSERT_UNREACHABLE();
 }
 
 static void __init assign_static_memory_11(struct domain *d,
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 03:21:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 03:21:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271077.465492 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJRvh-0001lp-2r; Mon, 14 Feb 2022 03:21:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271077.465492; Mon, 14 Feb 2022 03:21:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJRvg-0001ib-Mt; Mon, 14 Feb 2022 03:21:32 +0000
Received: by outflank-mailman (input) for mailman id 271077;
 Mon, 14 Feb 2022 03:21:31 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=aDlx=S5=arm.com=Penny.Zheng@srs-se1.protection.inumbo.net>)
 id 1nJRve-0007B4-HW
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 03:21:30 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04on0602.outbound.protection.outlook.com
 [2a01:111:f400:fe0e::602])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 32e1864c-8d45-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 04:21:29 +0100 (CET)
Received: from AM6PR04CA0054.eurprd04.prod.outlook.com (2603:10a6:20b:f0::31)
 by VE1PR08MB5758.eurprd08.prod.outlook.com (2603:10a6:800:1a0::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.14; Mon, 14 Feb
 2022 03:21:26 +0000
Received: from AM5EUR03FT060.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:f0:cafe::ed) by AM6PR04CA0054.outlook.office365.com
 (2603:10a6:20b:f0::31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.18 via Frontend
 Transport; Mon, 14 Feb 2022 03:21:26 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT060.mail.protection.outlook.com (10.152.16.160) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4975.17 via Frontend Transport; Mon, 14 Feb 2022 03:21:25 +0000
Received: ("Tessian outbound 18e50a6f0513:v113");
 Mon, 14 Feb 2022 03:21:25 +0000
Received: from a94bf39b6601.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 0AD5F8ED-0BA1-4D6E-B331-2C86B46ECDC7.1; 
 Mon, 14 Feb 2022 03:21:20 +0000
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a94bf39b6601.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 14 Feb 2022 03:21:20 +0000
Received: from AS9PR06CA0346.eurprd06.prod.outlook.com (2603:10a6:20b:466::21)
 by DB7PR08MB3562.eurprd08.prod.outlook.com (2603:10a6:10:49::24) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.17; Mon, 14 Feb
 2022 03:21:16 +0000
Received: from AM5EUR03FT025.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:466:cafe::d8) by AS9PR06CA0346.outlook.office365.com
 (2603:10a6:20b:466::21) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11 via Frontend
 Transport; Mon, 14 Feb 2022 03:21:16 +0000
Received: from nebula.arm.com (40.67.248.234) by
 AM5EUR03FT025.mail.protection.outlook.com (10.152.16.157) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.4975.11 via Frontend Transport; Mon, 14 Feb 2022 03:21:16 +0000
Received: from AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) by AZ-NEU-EX03.Arm.com
 (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2308.20; Mon, 14 Feb
 2022 03:21:20 +0000
Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX01.Emea.Arm.com
 (10.251.26.4) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.20; Mon, 14
 Feb 2022 03:21:13 +0000
Received: from penny.shanghai.arm.com (10.169.188.91) by mail.arm.com
 (10.251.24.31) with Microsoft SMTP Server id 15.1.2308.20 via Frontend
 Transport; Mon, 14 Feb 2022 03:21:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 32e1864c-8d45-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=4kFUJ81gEGlN2jJY6+KgXNfmBvm2zTX0lMR9H45QEE0=;
 b=OMyfBVeJ4v0lLibhhiVg66fAdRLYWbtBU1bJJt4xOkxrNSRORYmBDDHZZniEIwdg91HfNd0rvwIhxV9dXz1l8dkQEgrbWiVGeTx7mKzGJZpvFclzn5wan64BdQEsgdpRZbJIUtopKquHi5FZjWRsKvBG94drv8RAvXohPW06VGI=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 24731f0ab9f456f4
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=WSKSTuDiA7WiywnMS9DKIQ1JhwGd0u3xN6ACqVX11Nabfq2wmRIKL7CiR3ydlHSr2a9hLnF4sce9tVDFGOTzANvwT5P36GW6hPZIQkcsaeb5Jx6Mb9q1M05/sfOhkQc8gPzGKiRHj9Edz6Sb4wcjMSUeY/lt5ZS3GAMwfdQObk5aAZF/z3j6NVMASzfE5NA155htreTZQTOh1gcE0uQyrq0BYEh/LnAt5KmpuQ+xqYvfcOzQgy4UF2ZrLlEpG1MRfFL+zbCgEX97O8ERD26DvIch/i9LsvqihpNcwkWgsWVrXfwIKERibbDn4gkMnLX6lNn5ond6jvOv9E+XKOVR3g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=4kFUJ81gEGlN2jJY6+KgXNfmBvm2zTX0lMR9H45QEE0=;
 b=Nqt05MXXkPXMK7MoPxPniucxKr8XxaOtYi5nWJxGjM1gr22HgGbzQ2SBzetAXslSQvnExsMpqnSF5lO0R89CfCB0wUaVUBP1eKzw2c1Vzpirj/R2TeBMzLkNPoGvzyjRzRVDk9/925eFxss3K/xKJ+EL+IO5nWXIDT3vE+sWtQkSd9rGKT182Cbv8N+M4lI04LfZayHs3Mqbo9AMHuRquxlf1Xs5pgkjpc6gl4hYM/UFy9qVLsGbKraZ1oxKVXv3WpV5C4GNNNgEOl3ojstwz6Yx3iy746ltEKs0bJaYpIlf3kTUdmKch4tybNqyjrNxgDuoq/efuq+P1Ty/IiiA8A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=4kFUJ81gEGlN2jJY6+KgXNfmBvm2zTX0lMR9H45QEE0=;
 b=OMyfBVeJ4v0lLibhhiVg66fAdRLYWbtBU1bJJt4xOkxrNSRORYmBDDHZZniEIwdg91HfNd0rvwIhxV9dXz1l8dkQEgrbWiVGeTx7mKzGJZpvFclzn5wan64BdQEsgdpRZbJIUtopKquHi5FZjWRsKvBG94drv8RAvXohPW06VGI=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com;
From: Penny Zheng <penny.zheng@arm.com>
To: <xen-devel@lists.xenproject.org>, <sstabellini@kernel.org>,
	<julien@xen.org>
CC: <Bertrand.Marquis@arm.com>, <Wei.Chen@arm.com>
Subject: [PATCH v6 10/11] xen/arm: if direct-map domain use native UART address and IRQ number for vPL011
Date: Mon, 14 Feb 2022 03:19:55 +0000
Message-ID: <20220214031956.3726764-11-penny.zheng@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220214031956.3726764-1-penny.zheng@arm.com>
References: <20220214031956.3726764-1-penny.zheng@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 1
X-MS-Office365-Filtering-Correlation-Id: 94b0662e-c6ea-42fc-1f8c-08d9ef69155d
X-MS-TrafficTypeDiagnostic:
	DB7PR08MB3562:EE_|AM5EUR03FT060:EE_|VE1PR08MB5758:EE_
X-Microsoft-Antispam-PRVS:
	<VE1PR08MB5758BEABFF0E9225CF258078F7339@VE1PR08MB5758.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 sBCdoNosfDED/Eg6m3/bqEFGqIyfnudxpRSwSBAmhQYT8Csy70df4B6boVHxEsCMrbX8jjxMEPm3VbheAD3QA1it9qECcEhkkCMt8mt5hrPKC9+mtdmF5KJBYbR/q2Xwc9swnFIdqvmSd/kWwjQmv2JrKNAfBqR7sc3tfSghNcr1M6YaRg5C0DVDP/StaKHHfM0efUnXY2KsUcSAAZP0OFpUKD92oZxBWmQ4FxkH51LZxH7DoRp0PeKBc+ql9CYiUZpw1j2Vyd49R7uS4MvJrZMswtKLliVXNZs5C17HeVMB+LLTFsLjNgUhCFeLYROdSmtmyDDwy4uKlOhEufPcbMcRI6byKQCn/AcJmwOGVasXQiyDsucfd9H7L0kJtOwVMH7v2EIR74Z+F/HDM2xGe9wMJqNsmIvO3atsaxkavzYBMddY8R1YNv8iu6dBbLAAsv7pvVNMpH1DURV9K41QWp2IvGg0CHZCpXC6kyFo/1Jq7ap+ffjSUnzp6x+7ZFkNdYxSZsp05oyKodlU9NT089FZ+umj7gM2t9vk2sRspkqEO9DmgiMGtat+WczfPphPPDtMq/bX3l7IzCSK+ncPPxdeFlM50RBp+sXkAoHJZ9FddhCsjg36C+KIEKjuCLVeRZbwf4MaUyIfGKsFcPCwnSg634lSRTDffWXIvxB974HeMQmWZ795NHak1WlPvyQF
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(54906003)(2616005)(44832011)(36860700001)(1076003)(82310400004)(186003)(36756003)(26005)(110136005)(47076005)(86362001)(316002)(2906002)(5660300002)(70206006)(8936002)(4326008)(8676002)(83380400001)(7696005)(336012)(508600001)(81166007)(70586007)(6666004)(426003)(356005)(36900700001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3562
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT060.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	a5bcebf9-9b26-4cc6-244c-08d9ef690fd2
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	kIPJV7+Eo0n9QfbJ0cJuwXTNW+K5hFM37aPbLo0eaWho8R+uDSABCf9fkCLlFSlQvQuvjoe3zpzemr6JU0LNB26Rd8kpkIg902+YnCTQL9VVBo9uzNRGoubg9sNzfIRqjwHAXNNnOw43s2sKgXotSi4O8lOqAog6fU2Q53X4vm8yLWYpXPVmhscJhNmGwZZKxv3osRE6SI2cE5HNQUjDpUmcfM03ZhOZr9gSavZzq5LaGeTFoo7nA+4LVns/cH0JNiBe3NKpEtl2ND88AJOQ543i/Hi4zKARlgICZW/byHr47SX+Zwbo4Pt7MDXx9Wnz30Ji+6X3DFk3ZDJLrak+jm+HMa6YQGHKeES4dpMhNbd24a78InQcMkL7LSpic62BOxRlMZejSFtK9YwwIxUrjZNnVYZ4qYdd6Q80QbC67qD3mq3AJtCbHtmM5JIiMXoBpqIqqxQ7SuPYoZig+BTgOjk0A7pH/yZ7Ig/tX0papKiuWfav61Y5yt31T+KcB7rkoKTuzppFQPzN0XFmkJ9jv5J3yYrbjGGXjRyhmOdl4H1VtILiG0JbIgnFAxy+HQUbX0gimt6rcFkbk114TXARUNqjh4f/jooL4w8G8TOyL6lNdTwg7QN1uKHhcXh0jyUo8xFAwuDlDl9p9C/ok3ZqG9SHUkBVKE3Gbp9YRio2YLveV5Xr31KJLRODjvCTHH3Q
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(70206006)(316002)(508600001)(70586007)(2906002)(82310400004)(54906003)(110136005)(4326008)(5660300002)(8676002)(86362001)(44832011)(8936002)(47076005)(81166007)(7696005)(1076003)(83380400001)(36756003)(186003)(426003)(6666004)(36860700001)(2616005)(26005)(336012)(36900700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2022 03:21:25.8039
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 94b0662e-c6ea-42fc-1f8c-08d9ef69155d
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT060.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5758

From: Stefano Stabellini <sstabellini@kernel.org>

We always use a fix address to map the vPL011 to domains. The address
could be a problem for direct-map domains.

So, for domains that are directly mapped, reuse the address of the
physical UART on the platform to avoid potential clashes.

Do the same for the virtual IRQ number: instead of always using
GUEST_VPL011_SPI, try to reuse the physical SPI number if possible.

Signed-off-by: Stefano Stabellini <sstabellini@kernel.org>
Signed-off-by: Penny Zheng <penny.zheng@arm.com>
Reviewed-by: Julien Grall <jgrall@amazon.com>
Tested-by: Stefano Stabellini <sstabellini@kernel.org>
---
v2 changes:
- explain why vpl011 initialization before creating its device tree node
- error out if the domain is direct-mapped and the IRQ is not found
- harden the code and add a check/comment when the hardware UART region
is smaller than GUEST_VPL011_SIZE.
---
v3 changes:
- explain how the '27' was found for 'buf'
- fix checking before dereferencing
- refine comment message
---
v4 changes:
- refine comment message
---
v5 changes:
- nothing changed
---
v6 changes:
- nothing changed
---
 xen/arch/arm/domain_build.c       | 44 +++++++++++++++++++----
 xen/arch/arm/include/asm/vpl011.h |  2 ++
 xen/arch/arm/vpl011.c             | 60 +++++++++++++++++++++++++++----
 3 files changed, 92 insertions(+), 14 deletions(-)

diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index cff2cb93cc..8be01678de 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -30,6 +30,7 @@
 
 #include <xen/irq.h>
 #include <xen/grant_table.h>
+#include <xen/serial.h>
 
 static unsigned int __initdata opt_dom0_max_vcpus;
 integer_param("dom0_max_vcpus", opt_dom0_max_vcpus);
@@ -2415,8 +2416,12 @@ static int __init make_vpl011_uart_node(struct kernel_info *kinfo)
     gic_interrupt_t intr;
     __be32 reg[GUEST_ROOT_ADDRESS_CELLS + GUEST_ROOT_SIZE_CELLS];
     __be32 *cells;
+    struct domain *d = kinfo->d;
+    /* Placeholder for sbsa-uart@ + a 64-bit number + \0 */
+    char buf[27];
 
-    res = fdt_begin_node(fdt, "sbsa-uart@"__stringify(GUEST_PL011_BASE));
+    snprintf(buf, sizeof(buf), "sbsa-uart@%"PRIx64, d->arch.vpl011.base_addr);
+    res = fdt_begin_node(fdt, buf);
     if ( res )
         return res;
 
@@ -2426,14 +2431,14 @@ static int __init make_vpl011_uart_node(struct kernel_info *kinfo)
 
     cells = &reg[0];
     dt_child_set_range(&cells, GUEST_ROOT_ADDRESS_CELLS,
-                       GUEST_ROOT_SIZE_CELLS, GUEST_PL011_BASE,
+                       GUEST_ROOT_SIZE_CELLS, d->arch.vpl011.base_addr,
                        GUEST_PL011_SIZE);
 
     res = fdt_property(fdt, "reg", reg, sizeof(reg));
     if ( res )
         return res;
 
-    set_interrupt(intr, GUEST_VPL011_SPI, 0xf, DT_IRQ_TYPE_LEVEL_HIGH);
+    set_interrupt(intr, d->arch.vpl011.virq, 0xf, DT_IRQ_TYPE_LEVEL_HIGH);
 
     res = fdt_property(fdt, "interrupts", intr, sizeof (intr));
     if ( res )
@@ -3145,6 +3150,14 @@ static int __init construct_domU(struct domain *d,
     else
         assign_static_memory_11(d, &kinfo, node);
 
+    /*
+     * Base address and irq number are needed when creating vpl011 device
+     * tree node in prepare_dtb_domU, so initialization on related variables
+     * shall be done first.
+     */
+    if ( kinfo.vpl011 )
+        rc = domain_vpl011_init(d, NULL);
+
     rc = prepare_dtb_domU(d, &kinfo);
     if ( rc < 0 )
         return rc;
@@ -3153,9 +3166,6 @@ static int __init construct_domU(struct domain *d,
     if ( rc < 0 )
         return rc;
 
-    if ( kinfo.vpl011 )
-        rc = domain_vpl011_init(d, NULL);
-
     return rc;
 }
 
@@ -3200,15 +3210,35 @@ void __init create_domUs(void)
 
         if ( !dt_property_read_u32(node, "nr_spis", &d_cfg.arch.nr_spis) )
         {
+            unsigned int vpl011_virq = GUEST_VPL011_SPI;
+
             d_cfg.arch.nr_spis = gic_number_lines() - 32;
 
+            /*
+             * The VPL011 virq is GUEST_VPL011_SPI, unless direct-map is
+             * set, in which case it'll match the hardware.
+             *
+             * Since the domain is not yet created, we can't use
+             * d->arch.vpl011.irq. So the logic to find the vIRQ has to
+             * be hardcoded.
+             * The logic here shall be consistent with the one in
+             * domain_vpl011_init().
+             */
+            if ( flags & CDF_directmap )
+            {
+                vpl011_virq = serial_irq(SERHND_DTUART);
+                if ( vpl011_virq < 0 )
+                    panic("Error getting IRQ number for this serial port %d\n",
+                          SERHND_DTUART);
+            }
+
             /*
              * vpl011 uses one emulated SPI. If vpl011 is requested, make
              * sure that we allocate enough SPIs for it.
              */
             if ( dt_property_read_bool(node, "vpl011") )
                 d_cfg.arch.nr_spis = MAX(d_cfg.arch.nr_spis,
-                                         GUEST_VPL011_SPI - 32 + 1);
+                                         vpl011_virq - 32 + 1);
         }
 
         /*
diff --git a/xen/arch/arm/include/asm/vpl011.h b/xen/arch/arm/include/asm/vpl011.h
index e6c7ab7381..c09abcd7a9 100644
--- a/xen/arch/arm/include/asm/vpl011.h
+++ b/xen/arch/arm/include/asm/vpl011.h
@@ -53,6 +53,8 @@ struct vpl011 {
     uint32_t    uarticr;        /* Interrupt clear register */
     uint32_t    uartris;        /* Raw interrupt status register */
     uint32_t    shadow_uartmis; /* shadow masked interrupt register */
+    paddr_t     base_addr;
+    unsigned int virq;
     spinlock_t  lock;
     evtchn_port_t evtchn;
 };
diff --git a/xen/arch/arm/vpl011.c b/xen/arch/arm/vpl011.c
index 895f436cc4..43522d48fd 100644
--- a/xen/arch/arm/vpl011.c
+++ b/xen/arch/arm/vpl011.c
@@ -29,6 +29,7 @@
 #include <xen/mm.h>
 #include <xen/sched.h>
 #include <xen/console.h>
+#include <xen/serial.h>
 #include <public/domctl.h>
 #include <public/io/console.h>
 #include <asm/pl011-uart.h>
@@ -71,11 +72,11 @@ static void vpl011_update_interrupt_status(struct domain *d)
      * status bit has been set since the last time.
      */
     if ( uartmis & ~vpl011->shadow_uartmis )
-        vgic_inject_irq(d, NULL, GUEST_VPL011_SPI, true);
+        vgic_inject_irq(d, NULL, vpl011->virq, true);
 
     vpl011->shadow_uartmis = uartmis;
 #else
-    vgic_inject_irq(d, NULL, GUEST_VPL011_SPI, uartmis);
+    vgic_inject_irq(d, NULL, vpl011->virq, uartmis);
 #endif
 }
 
@@ -347,7 +348,8 @@ static int vpl011_mmio_read(struct vcpu *v,
                             void *priv)
 {
     struct hsr_dabt dabt = info->dabt;
-    uint32_t vpl011_reg = (uint32_t)(info->gpa - GUEST_PL011_BASE);
+    uint32_t vpl011_reg = (uint32_t)(info->gpa -
+                                     v->domain->arch.vpl011.base_addr);
     struct vpl011 *vpl011 = &v->domain->arch.vpl011;
     struct domain *d = v->domain;
     unsigned long flags;
@@ -430,7 +432,8 @@ static int vpl011_mmio_write(struct vcpu *v,
                              void *priv)
 {
     struct hsr_dabt dabt = info->dabt;
-    uint32_t vpl011_reg = (uint32_t)(info->gpa - GUEST_PL011_BASE);
+    uint32_t vpl011_reg = (uint32_t)(info->gpa -
+                                     v->domain->arch.vpl011.base_addr);
     struct vpl011 *vpl011 = &v->domain->arch.vpl011;
     struct domain *d = v->domain;
     unsigned long flags;
@@ -626,6 +629,49 @@ int domain_vpl011_init(struct domain *d, struct vpl011_init_info *info)
     if ( vpl011->backend.dom.ring_buf )
         return -EINVAL;
 
+    /*
+     * The VPL011 virq is GUEST_VPL011_SPI, except for direct-map domains
+     * where the hardware value shall be used.
+     * The logic here should stay in sync with the one in
+     * create_domUs().
+     */
+    if ( is_domain_direct_mapped(d) )
+    {
+        const struct vuart_info *uart = serial_vuart_info(SERHND_DTUART);
+        int vpl011_irq = serial_irq(SERHND_DTUART);
+
+        if ( (uart != NULL) && (vpl011_irq > 0) )
+        {
+            vpl011->base_addr = uart->base_addr;
+            vpl011->virq = vpl011_irq;
+        }
+        else
+        {
+            printk(XENLOG_ERR
+                   "vpl011: Unable to re-use the Xen UART information.\n");
+            return -EINVAL;
+        }
+
+        /*
+         * Since the PL011 we emulate for the guest requires a 4KB region,
+         * and on some Hardware (e.g. on some sunxi SoC), the UART MMIO
+         * region is less than 4KB, in which case, there may exist multiple
+         * devices within the same 4KB region, here adds the following check to
+         * prevent potential known pitfalls
+         */
+        if ( uart->size < GUEST_PL011_SIZE )
+        {
+            printk(XENLOG_ERR
+                   "vpl011: Can't re-use the Xen UART MMIO region as it is too small.\n");
+            return -EINVAL;
+        }
+    }
+    else
+    {
+        vpl011->base_addr = GUEST_PL011_BASE;
+        vpl011->virq = GUEST_VPL011_SPI;
+    }
+
     /*
      * info is NULL when the backend is in Xen.
      * info is != NULL when the backend is in a domain.
@@ -661,7 +707,7 @@ int domain_vpl011_init(struct domain *d, struct vpl011_init_info *info)
         }
     }
 
-    rc = vgic_reserve_virq(d, GUEST_VPL011_SPI);
+    rc = vgic_reserve_virq(d, vpl011->virq);
     if ( !rc )
     {
         rc = -EINVAL;
@@ -673,12 +719,12 @@ int domain_vpl011_init(struct domain *d, struct vpl011_init_info *info)
     spin_lock_init(&vpl011->lock);
 
     register_mmio_handler(d, &vpl011_mmio_handler,
-                          GUEST_PL011_BASE, GUEST_PL011_SIZE, NULL);
+                          vpl011->base_addr, GUEST_PL011_SIZE, NULL);
 
     return 0;
 
 out2:
-    vgic_free_virq(d, GUEST_VPL011_SPI);
+    vgic_free_virq(d, vpl011->virq);
 
 out1:
     if ( vpl011->backend_in_domain )
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 03:21:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 03:21:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271078.465497 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJRvi-00020x-7N; Mon, 14 Feb 2022 03:21:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271078.465497; Mon, 14 Feb 2022 03:21:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJRvh-0001vp-HS; Mon, 14 Feb 2022 03:21:33 +0000
Received: by outflank-mailman (input) for mailman id 271078;
 Mon, 14 Feb 2022 03:21:31 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=aDlx=S5=arm.com=Penny.Zheng@srs-se1.protection.inumbo.net>)
 id 1nJRvf-0007B4-6i
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 03:21:31 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04on0602.outbound.protection.outlook.com
 [2a01:111:f400:fe0d::602])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 3366048f-8d45-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 04:21:30 +0100 (CET)
Received: from AS8PR04CA0182.eurprd04.prod.outlook.com (2603:10a6:20b:2f3::7)
 by DU2PR08MB7311.eurprd08.prod.outlook.com (2603:10a6:10:2e6::7) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.16; Mon, 14 Feb
 2022 03:21:28 +0000
Received: from AM5EUR03FT059.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:2f3:cafe::a) by AS8PR04CA0182.outlook.office365.com
 (2603:10a6:20b:2f3::7) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.18 via Frontend
 Transport; Mon, 14 Feb 2022 03:21:27 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT059.mail.protection.outlook.com (10.152.17.193) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4975.17 via Frontend Transport; Mon, 14 Feb 2022 03:21:27 +0000
Received: ("Tessian outbound 18e50a6f0513:v113");
 Mon, 14 Feb 2022 03:21:27 +0000
Received: from c188c6299f47.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 E6604294-B868-450D-BE46-4DF1C63FEED2.1; 
 Mon, 14 Feb 2022 03:21:21 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c188c6299f47.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 14 Feb 2022 03:21:21 +0000
Received: from AS9PR06CA0332.eurprd06.prod.outlook.com (2603:10a6:20b:466::11)
 by VE1PR08MB5743.eurprd08.prod.outlook.com (2603:10a6:800:1b2::5)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.17; Mon, 14 Feb
 2022 03:21:18 +0000
Received: from AM5EUR03FT025.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:466:cafe::a1) by AS9PR06CA0332.outlook.office365.com
 (2603:10a6:20b:466::11) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11 via Frontend
 Transport; Mon, 14 Feb 2022 03:21:17 +0000
Received: from nebula.arm.com (40.67.248.234) by
 AM5EUR03FT025.mail.protection.outlook.com (10.152.16.157) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.4975.11 via Frontend Transport; Mon, 14 Feb 2022 03:21:17 +0000
Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX03.Arm.com
 (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 14 Feb
 2022 03:21:21 +0000
Received: from penny.shanghai.arm.com (10.169.188.91) by mail.arm.com
 (10.251.24.31) with Microsoft SMTP Server id 15.1.2308.20 via Frontend
 Transport; Mon, 14 Feb 2022 03:21:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3366048f-8d45-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=2d4IKv3T5/Hx+dqQ3Y2Ud1C+n1KbiL2IC5h2n3T2Clw=;
 b=8QGPLPeWSQYc+vJdmdH/ZbZiK+Y48Dq3ktEpUJqc+/JAVbibI6qsAjrCa/RU97Bzy6DX/ZbxfsIrdobbmZrPFh0V5BuRvGLUX3Y8y2Oo76R253udOyutw5ajyIHQUIDQQDwY3QPr2yEGiVaOverr/TVoKXNfYNeeaXSTPdIeZhQ=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: f4c5b5180ddb3c01
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=e/6Hi8rKArxLn20nBH1w4wA/pmdRyOCbk4QbSuEmQR4NKTqiedXz2Lf3QDxDz3PJQft7bdf5BW10bSu5jswvqqZQOte//bggJUbRoxbiLJpEACoe95uXK6Hao8qZzvjAyykJ+qQENGWeDvyGnQieockVzA3QbRUNnYK/h81ENXvFIS4U+uZtXzDFhW4DGexSTm+sfetpH780spKdWTtRf2a1iaCnDO0ZynNOHV2Zw2sg3nCHLXH9B0hwa87ZvgM7OrfjhTYfnHUqRqt/9uDL3itqQLVubnL19d37k1G3Fhz7AO5ycv26Ip6tmhbj5TJKEYLIWDEqzN88uYBnGOmRIw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=2d4IKv3T5/Hx+dqQ3Y2Ud1C+n1KbiL2IC5h2n3T2Clw=;
 b=hGxWDzkQHr6e3/xqOQKa97PhE1jnejsPhubxmRXryL4FUlOTfehpT93jRJl+wpjKip73JenCfdHAAynPMzlBe1UdxaL1mmOkjsoLgyDDW1D1vzdkxN9C9UHCGwKY0axieYh3wrGmhk6QxQI8cNWltbnOROJdHXgi+4eBgXCFcvoZwfV2XF6izg0rbaHgqqrws5liWTOPO3WfZAVG4VeYK/ue29/Sy4ReE2GV9hp6I0CsyBDsC1Kb50NlxtOFumNlMQgBzo1CNBZvx8boSTlxakkqWKLLbAyFYjzJxb4ZGAiBIPS+DQYt/v4NNnGT/K7VCbY9gwQZSn5quqkuuMxumQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=2d4IKv3T5/Hx+dqQ3Y2Ud1C+n1KbiL2IC5h2n3T2Clw=;
 b=8QGPLPeWSQYc+vJdmdH/ZbZiK+Y48Dq3ktEpUJqc+/JAVbibI6qsAjrCa/RU97Bzy6DX/ZbxfsIrdobbmZrPFh0V5BuRvGLUX3Y8y2Oo76R253udOyutw5ajyIHQUIDQQDwY3QPr2yEGiVaOverr/TVoKXNfYNeeaXSTPdIeZhQ=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com;
From: Penny Zheng <penny.zheng@arm.com>
To: <xen-devel@lists.xenproject.org>, <sstabellini@kernel.org>,
	<julien@xen.org>
CC: <Bertrand.Marquis@arm.com>, <Wei.Chen@arm.com>
Subject: [PATCH v6 11/11] xen/docs: Document how to do passthrough without IOMMU
Date: Mon, 14 Feb 2022 03:19:56 +0000
Message-ID: <20220214031956.3726764-12-penny.zheng@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220214031956.3726764-1-penny.zheng@arm.com>
References: <20220214031956.3726764-1-penny.zheng@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 1
X-MS-Office365-Filtering-Correlation-Id: fc1a79dc-e9a2-431b-efa0-08d9ef691684
X-MS-TrafficTypeDiagnostic:
	VE1PR08MB5743:EE_|AM5EUR03FT059:EE_|DU2PR08MB7311:EE_
X-Microsoft-Antispam-PRVS:
	<DU2PR08MB7311E73A13C3B0FAB2EC8E41F7339@DU2PR08MB7311.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:1751;OLM:1751;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 WombyMC2bDJlw1FT3vngoMtKKHro+kaCE4NpYGnxtI3SiHgaqUkraK4E3/85N+tMS0oDfzIrmgS4eaZDtovISQ6ihAKT2FRo5OQwH4OFc6HLjTuADAVV1MAHRPzLjZtqFVLd5vxjkMgruYTJlghAt0cUP1fxHgsairttfUvW6hzjE3mo3jcV8oIIrssVUMtqZhjJEO1xL/eHGTyjaTQlC3n54/eyJOof8qn5AT22eowiJb6rvY0GNK1T6g7OXY/FV+xlQGYfiFPtis/C+4joNjlHp8HUBLmnDL2Otc33EheajX11jma7Rpe2H7SW4gZyrA/zH7E96lL7kQTCjwX0GFQS9/t7ZJso1/lhl67+O3ueI9lVz6NQjqHVV/WUXVDlm+wDPrwdZF6fjYivcVjLrPaw6Fd7Fv+sfHazo4rJBrrAmRmNx92tPQnIJjV3TNnALyKyix2c/xAdog9pEpjpafAFUD3sogNTLfDNq7+1wmcVoGYmGWtP5pk989At+STW7wz9BcTbZccVzZjLHiZB47u4Cp18i4X9irvkQYTt9egq6QXL/wHTBD98cZBTZJk83C/VIgcPdFDfSLDu2++co3AikdFtYuWBsw0EmODldMa1rCZh3KBqXHcbKO5/7hsTd36O6U59TN1MAqgfXF3v25AqPzw4jtJuchFZDW8BdGMH0zHj6BWJWTxUi0CRzZ8N
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(6666004)(2906002)(86362001)(83380400001)(82310400004)(5660300002)(8936002)(44832011)(7696005)(8676002)(47076005)(110136005)(54906003)(508600001)(36860700001)(81166007)(356005)(4326008)(316002)(70586007)(70206006)(186003)(1076003)(26005)(426003)(336012)(36756003)(2616005)(36900700001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5743
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT059.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	397e7931-24d2-4804-7357-08d9ef691092
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	DZU9tpJg6ddacCdSAtrFFAh1X3HwtCMOjhELwiqms7IWWdgEAECNZUGFsqMPFyl382WZsgBOoJa6Z5tI61JMFf6FvyhOZDmjfSZL+VpcyVYncdhkneo/QI9AKkrv95w5NgCUQujyDfOVSj5dmgTqWjQMVy2O0EyAkI5z7OV8oaLRrUm/Os8lVd0HFPAFC8CHDf6FQ/EluUUGxMUqjnFEuxhOpWIyMCNDSJ3FtJKglDRMbP7xH14pFv58ttfw9GUHJMG06wOIjvVmpPNBHvFYnem4N58RhRwheVqaDdrCWv9KSKywqNZN1RiFQw+yQKGO/uOX56s1OAgl2aWWEdCTankSJCalwQYWcyUAtcIEqq/6sClyMyosHKO03+wpApF7IS4kmlUnVw0IJmYVGXdQGitBVQJzRpez9QHe1l1k+hjXcSwMuMc1hU72oEbRx5HHHVulEhyQHxltLK3LXuj4uQQ06oeUfH+ppOvG+hQJ15nlydRbrfQbq9i1W964HctU8RIHljMZ5cTc1gezj+glPoctSFAgMSNC/FUhNeYvwYTV0wWW/LHpvkN9LChYmvLGdgcM/9LRp1Ha4qmqd6EHLiUrhMJBJbMWvs5OPoRO2v+CnEoR5gFFuNVWPCQhs5J+Cwf9/Dg32h8dKO6faOFtog==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(2616005)(508600001)(426003)(26005)(316002)(336012)(6666004)(7696005)(44832011)(36860700001)(2906002)(1076003)(186003)(36756003)(8676002)(5660300002)(70206006)(47076005)(82310400004)(8936002)(110136005)(54906003)(86362001)(4326008)(83380400001)(81166007)(70586007);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2022 03:21:27.7582
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: fc1a79dc-e9a2-431b-efa0-08d9ef691684
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT059.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR08MB7311

From: Stefano Stabellini <sstabellini@kernel.org>

This commit creates a new doc to document how to do passthrough without IOMMU.

Signed-off-by: Stefano Stabellini <sstabellini@kernel.org>
Signed-off-by: Penny Zheng <penny.zheng@arm.com>
Acked-by: Julien Grall <jgrall@amazon.com>
Tested-by: Stefano Stabellini <sstabellini@kernel.org>
---
v2 changes:
- nothing changed
---
v3 changes:
- nothing changed
---
v4 changes:
- nothing changed
---
v5 changes:
- nothing changed
---
v6 changes:
- nothing changed
---
 docs/misc/arm/passthrough-noiommu.txt | 52 +++++++++++++++++++++++++++
 1 file changed, 52 insertions(+)
 create mode 100644 docs/misc/arm/passthrough-noiommu.txt

diff --git a/docs/misc/arm/passthrough-noiommu.txt b/docs/misc/arm/passthrough-noiommu.txt
new file mode 100644
index 0000000000..3e2ef21ad7
--- /dev/null
+++ b/docs/misc/arm/passthrough-noiommu.txt
@@ -0,0 +1,52 @@
+Request Device Assignment without IOMMU support
+===============================================
+
+*WARNING:
+Users should be aware that it is not always secure to assign a device without
+IOMMU protection.
+When the device is not protected by the IOMMU, the administrator should make
+sure that:
+ 1. The device is assigned to a trusted guest.
+ 2. Users have additional security mechanism on the platform.
+
+This document assumes that the IOMMU is absent from the system or it is
+disabled (status = "disabled" in device tree).
+
+Add xen,force-assign-without-iommu; to the device tree snippet:
+
+ethernet: ethernet@ff0e0000 {
+	compatible = "cdns,zynqmp-gem";
+	xen,path = "/amba/ethernet@ff0e0000";
+	xen,reg = <0x0 0xff0e0000 0x1000 0x0 0xff0e0000>;
+	xen,force-assign-without-iommu;
+};
+
+Request 1:1 memory mapping for the domain on static allocation
+==============================================================
+
+Add a direct-map property under the appropriate /chosen/domU node which
+is also statically allocated with physical memory ranges through
+xen,static-mem property as its guest RAM.
+
+Below is an example on how to specify the 1:1 memory mapping for the domain
+on static allocation in the device-tree:
+
+/ {
+	chosen {
+		domU1 {
+			compatible = "xen,domain";
+			#address-cells = <0x2>;
+			#size-cells = <0x2>;
+			cpus = <2>;
+			memory = <0x0 0x80000>;
+			#xen,static-mem-address-cells = <0x1>;
+			#xen,static-mem-size-cells = <0x1>;
+			xen,static-mem = <0x30000000 0x20000000>;
+			direct-map;
+			...
+		};
+	};
+};
+
+Besides reserving a 512MB region starting at the host physical address
+0x30000000 to DomU1, it also requests 1:1 memory mapping.
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 03:21:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 03:21:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271080.465504 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJRvj-0002LK-Ra; Mon, 14 Feb 2022 03:21:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271080.465504; Mon, 14 Feb 2022 03:21:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJRvj-0002Hc-89; Mon, 14 Feb 2022 03:21:35 +0000
Received: by outflank-mailman (input) for mailman id 271080;
 Mon, 14 Feb 2022 03:21:33 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=aDlx=S5=arm.com=Penny.Zheng@srs-se1.protection.inumbo.net>)
 id 1nJRvg-0007B4-Nm
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 03:21:32 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05on20600.outbound.protection.outlook.com
 [2a01:111:f400:7e1b::600])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 34853964-8d45-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 04:21:32 +0100 (CET)
Received: from AM6PR01CA0049.eurprd01.prod.exchangelabs.com
 (2603:10a6:20b:e0::26) by DBAPR08MB5558.eurprd08.prod.outlook.com
 (2603:10a6:10:1b3::19) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Mon, 14 Feb
 2022 03:21:27 +0000
Received: from VE1EUR03FT035.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:e0:cafe::76) by AM6PR01CA0049.outlook.office365.com
 (2603:10a6:20b:e0::26) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11 via Frontend
 Transport; Mon, 14 Feb 2022 03:21:26 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT035.mail.protection.outlook.com (10.152.18.110) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4975.11 via Frontend Transport; Mon, 14 Feb 2022 03:21:26 +0000
Received: ("Tessian outbound 63bb5eb69ee8:v113");
 Mon, 14 Feb 2022 03:21:26 +0000
Received: from d598cff77efc.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 1E48593B-EF03-4EF8-80B0-0BA192DFFB56.1; 
 Mon, 14 Feb 2022 03:21:19 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d598cff77efc.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 14 Feb 2022 03:21:19 +0000
Received: from AM6P193CA0100.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:88::41)
 by VE1PR08MB5087.eurprd08.prod.outlook.com (2603:10a6:803:114::10) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.15; Mon, 14 Feb
 2022 03:21:11 +0000
Received: from AM5EUR03FT005.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:88:cafe::4c) by AM6P193CA0100.outlook.office365.com
 (2603:10a6:209:88::41) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11 via Frontend
 Transport; Mon, 14 Feb 2022 03:21:11 +0000
Received: from nebula.arm.com (40.67.248.234) by
 AM5EUR03FT005.mail.protection.outlook.com (10.152.16.146) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.4975.11 via Frontend Transport; Mon, 14 Feb 2022 03:21:10 +0000
Received: from AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) by AZ-NEU-EX03.Arm.com
 (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2308.20; Mon, 14 Feb
 2022 03:21:15 +0000
Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX01.Emea.Arm.com
 (10.251.26.4) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.20; Mon, 14
 Feb 2022 03:21:09 +0000
Received: from penny.shanghai.arm.com (10.169.188.91) by mail.arm.com
 (10.251.24.31) with Microsoft SMTP Server id 15.1.2308.20 via Frontend
 Transport; Mon, 14 Feb 2022 03:21:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 34853964-8d45-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=imow8UlbEMwA9qvqpckFhNwsAsfpDkhGSm02fiqstow=;
 b=nSoUmthnjbBw6NNu09CxwQAw3on4GhtgQVv5XGFm7s1YJLbJV36UUW7k4K73KWZPfKD20DqS+d283nBJJux7u5qnc7J4mhp1IE5vUUVylWPaRuJh/kZJT/kTjLWa5Dx77e7DYkBmMVvYaAUlqjmt2pd3TIm2X/Za4CcNbdgTU1I=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: c7f7bee1a37ed5a6
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=TYi6Wz4nOK7GaP0/DV/GVLvprPQ37wn8jHnE6MTK7Qx2KAuWKPqTFLy4z4uNNiZqd3c99Owt3/N15vSOH8oSBU+4UPnosg+P1AlLY/cHe++/UJextnR9Rjn1bQV2u3SktdY0Ie35vjr5HbQOqzRElUkvlbSrObzrSVo5x23j79/B9izwqKvu78sARLpS4h6tVU335mhakWU5TgJnZk0l/oSttXpDdvYPaIbJrjVvQ5Q8u3ip8yOIapkNMTIFQyg5fPNG+Cxq6FvM7wJxGAf/5ByQhST741blShnx92OmMGAm8nomtb4FQELi3kx5RHp4bbCBVSFNZ+aoPRFXr3vAVw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=imow8UlbEMwA9qvqpckFhNwsAsfpDkhGSm02fiqstow=;
 b=DvPJaEMq5U/8pL4EAQqdqQuLCPTHBt5+XXTXA5HdKHH5jUL8anM7hHO9tMM4OgN8WGQaFemRmFKUqanMMOPYiTbB3LMMWrsDsVs/nPuw4y2Px90Y6RVDpCVCt0G4ksMDYzzUonkl2/I0HlTRXtlwwVgSDuzXSbUctPuS/2QS0KtUbzszy4XnTBTO+02zRyKDi9CdKSyPy5uRW24smnZLMnlpW2ECJo+m9MfLP5YW/DSWZUqVfFNVdNYdFcWgZFxq7n5G/6Hmo+Xwo4ld586r0Xf3BsmXx0nITLtL7T8iqM7J27B3eP8nzprVltpmdpLa9Z00AH3PfFK6dbmTwjeDeQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=imow8UlbEMwA9qvqpckFhNwsAsfpDkhGSm02fiqstow=;
 b=nSoUmthnjbBw6NNu09CxwQAw3on4GhtgQVv5XGFm7s1YJLbJV36UUW7k4K73KWZPfKD20DqS+d283nBJJux7u5qnc7J4mhp1IE5vUUVylWPaRuJh/kZJT/kTjLWa5Dx77e7DYkBmMVvYaAUlqjmt2pd3TIm2X/Za4CcNbdgTU1I=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com;
From: Penny Zheng <penny.zheng@arm.com>
To: <xen-devel@lists.xenproject.org>, <sstabellini@kernel.org>,
	<julien@xen.org>
CC: <Bertrand.Marquis@arm.com>, <Wei.Chen@arm.com>
Subject: [PATCH v6 08/11] xen/arm: gate make_gicv3_domU_node with CONFIG_GICV3
Date: Mon, 14 Feb 2022 03:19:53 +0000
Message-ID: <20220214031956.3726764-9-penny.zheng@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220214031956.3726764-1-penny.zheng@arm.com>
References: <20220214031956.3726764-1-penny.zheng@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 1
X-MS-Office365-Filtering-Correlation-Id: a89c6f7a-2286-444e-dfd5-08d9ef6915b8
X-MS-TrafficTypeDiagnostic:
	VE1PR08MB5087:EE_|VE1EUR03FT035:EE_|DBAPR08MB5558:EE_
X-Microsoft-Antispam-PRVS:
	<DBAPR08MB5558DA2FE8FCC86A05054EE8F7339@DBAPR08MB5558.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:78;OLM:78;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 G996ObXfx5BZRFYmOUGYcjMl11+BqvuSPuwP5+AevCsiItsOYlfuw7/TW+yBgSV3agrzOH2dH8ErAQlHQsBGw8QItRwnCLGrCGlKJg//hjYlMbHBRxtUIcVTSi208y5KIVseert+9qbLUPFEsO8KqI9r5vwnbbX7h0fVu4UJxVthyDEEaN9dSZYvIymRKELSoJjFHt0prV080zt1LyPk8g8AGJxZ+yU7ZMj0gt5bX0PIAkdAVJ60tDATAwEN28AtsLi/v29ke4GyabxcFdxhR8hNkko4LxJSdKcfSfYdjggWIz+haJVDOmV8OMfXnlwV59hE3Xqs3P9qu9SJZvCdGAGiY+uJP0yc8+xw4alxOGVxD1AaN0TjJGbKwqGaKabRk8bfdN0e9uJ/hYZHvDFCcigujhCCCl1N4YJ3XfFavNkF/OOP+BC48kiJZFR4Mfxi97WazGc1/hsx5lfKK+9aZ0nrUBqSmZTIizPtm2pYddIGj+M1UsclecjM4wu3lIT3YpSQsZke080kdu9oxVstB5Cg5HDxRWa+Oby0IKLPcrV2+LAJisQGlCh+DCJF8edAZugwtV3XKW3O/EWLGFeEI+kOpy9nzEHBR/s2CSnLxa66DN6G7d0v6QWb2px36Um8Ixlye9af/eUlEgq/AjgGKzOYs0inu9/xclFqvzpi/0HxlwhXNfgKCxU/XV86xzt3
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(110136005)(4326008)(70586007)(508600001)(426003)(186003)(316002)(54906003)(5660300002)(70206006)(36756003)(336012)(8676002)(2906002)(26005)(1076003)(2616005)(86362001)(47076005)(356005)(36860700001)(81166007)(6666004)(8936002)(7696005)(44832011)(82310400004)(36900700001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5087
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT035.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	8d210955-ed99-4d27-af66-08d9ef690c4f
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	DNfMHOtK5MklINxiTawPXw2mT8b+kOZ+w9AZ1ynNPyAV4VxX7GnYrM9Z93vfGuAEWvlpLla63DOo79DzHM/96ONetwGclJCPktVOFl0Awi9zwf8XhBMvGdyylpUdzQiyAj/64Nc++pCSPBtVlY+m0/X8qwYnzv9xhC9VYmjXwFv99FakFvGzPvEjYr1bncokXy0pBD/TSQpICNhge36IkRq3vRH+qrwamiPK5MP/Y8/U/GunMH8RDj1sO/iGQI10U1KiJ8o/jrWzXJ/44DaMqNm5YcTExnj2uVSIbyTLTiOT7HQQSwH9adE4nrIxAVEFtTxGL4BZ2G/9kL4TET+uzGV4PZSyywnjCFXsnSq2cY2rem9WALhzZc5hDR1lms5fXHT2lD4D70spn7ytzew89ItoMRHiNAI9wY1UultNCmFBFemgXGKRgGbG+qfa4P5xjDWvOXH1abcneJzk/vMkxpHHcsXq7pWT44r4XItOhuy8O5XWZ0m9lSux4h29dJFhmd4jv0BMD+BuV3ytpsYsHy3wbxMLuRncxcBw3cTTHGe5zuV+sBrgEmFPSX5q392/5+eCrJqduGbkq1RTFWDVW0UlzqKZMda/JjhkT3rl7nExBMiH1UR1V4wG9YX7UmIsFcTNc4MN+n9owqX2glpoxQ==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(36756003)(44832011)(508600001)(47076005)(5660300002)(316002)(336012)(70586007)(70206006)(426003)(8676002)(4326008)(54906003)(110136005)(7696005)(8936002)(186003)(26005)(6666004)(1076003)(86362001)(2616005)(82310400004)(36860700001)(81166007)(2906002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2022 03:21:26.3584
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: a89c6f7a-2286-444e-dfd5-08d9ef6915b8
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT035.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5558

This commit gates function make_gicv3_domU_node with CONFIG_GICV3.

Signed-off-by: Penny Zheng <penny.zheng@arm.com>
Acked-by: Stefano Stabellini <sstabellini@kernel.org>
Tested-by: Stefano Stabellini <sstabellini@kernel.org>
---
v4 changes:
- remove ASSERT_UNREACHABLE() to avoid breaking compilation on prod build with
CONFIG_GICV3=n
---
v5 changes:
- nothing changed
---
v6 changes:
- nothing changed
---
 xen/arch/arm/domain_build.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index 87391adde6..a01dc60b55 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -2322,6 +2322,7 @@ static int __init make_gicv2_domU_node(struct kernel_info *kinfo)
     return res;
 }
 
+#ifdef CONFIG_GICV3
 static int __init make_gicv3_domU_node(struct kernel_info *kinfo)
 {
     void *fdt = kinfo->fdt;
@@ -2371,13 +2372,16 @@ static int __init make_gicv3_domU_node(struct kernel_info *kinfo)
 
     return res;
 }
+#endif
 
 static int __init make_gic_domU_node(struct kernel_info *kinfo)
 {
     switch ( kinfo->d->arch.vgic.version )
     {
+#ifdef CONFIG_GICV3
     case GIC_V3:
         return make_gicv3_domU_node(kinfo);
+#endif
     case GIC_V2:
         return make_gicv2_domU_node(kinfo);
     default:
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 06:19:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 06:19:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271177.465526 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJUhw-0004yI-Dn; Mon, 14 Feb 2022 06:19:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271177.465526; Mon, 14 Feb 2022 06:19:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJUhw-0004yB-AP; Mon, 14 Feb 2022 06:19:32 +0000
Received: by outflank-mailman (input) for mailman id 271177;
 Mon, 14 Feb 2022 06:19:31 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJUhv-0004y1-0Y; Mon, 14 Feb 2022 06:19:31 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJUhu-0006Pf-Ss; Mon, 14 Feb 2022 06:19:30 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJUhu-00041a-Br; Mon, 14 Feb 2022 06:19:30 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nJUhu-000433-BA; Mon, 14 Feb 2022 06:19:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=WRpb0hoTESmNGbxcdlyRC7YP+krbTn9x2XDMRpc68n4=; b=ZvPA54L9IN65fVWWmCuXiieq/A
	MOtXHzYtwxN1xL3dhD7BetFU4/H3L7SEiXdi/53aamJLovp3JKUnqWEw/k9Zip1zNE+bNdeCZqeSx
	VUUY4gjZ6SjlgojDB5W2iBRd6sbZdwoL1z/gMbLaqqoSDJz5wWNWoRKSWVlrYTXZ+iI4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168103-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 168103: trouble: blocked/broken/fail/pass
X-Osstest-Failures:
    linux-linus:build-arm64:<job status>:broken:regression
    linux-linus:build-arm64-pvops:<job status>:broken:regression
    linux-linus:build-arm64-xsm:<job status>:broken:regression
    linux-linus:test-armhf-armhf-libvirt-qcow2:<job status>:broken:regression
    linux-linus:build-arm64-xsm:host-install(4):broken:regression
    linux-linus:build-arm64:host-install(4):broken:regression
    linux-linus:build-arm64-pvops:host-install(4):broken:regression
    linux-linus:test-armhf-armhf-libvirt-qcow2:host-install(5):broken:regression
    linux-linus:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:allowable
    linux-linus:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable
    linux-linus:test-arm64-arm64-examine:build-check(1):blocked:nonblocking
    linux-linus:build-arm64-libvirt:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=754e0b0e35608ed5206d6a67a791563c631cec07
X-Osstest-Versions-That:
    linux=f1baf68e1383f6ed93eb9cff2866d46562607a43
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 14 Feb 2022 06:19:30 +0000

flight 168103 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168103/

Failures and problems with tests :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-arm64                     <job status>                 broken
 build-arm64-pvops               <job status>                 broken
 build-arm64-xsm                 <job status>                 broken
 test-armhf-armhf-libvirt-qcow2    <job status>                 broken
 build-arm64-xsm               4 host-install(4)        broken REGR. vs. 168080
 build-arm64                   4 host-install(4)        broken REGR. vs. 168080
 build-arm64-pvops             4 host-install(4)        broken REGR. vs. 168080
 test-armhf-armhf-libvirt-qcow2  5 host-install(5)      broken REGR. vs. 168080

Regressions which are regarded as allowable (not blocking):
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10   fail REGR. vs. 168080
 test-armhf-armhf-xl-rtds    18 guest-start/debian.repeat fail REGR. vs. 168080

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-examine      1 build-check(1)               blocked  n/a
 build-arm64-libvirt           1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl           1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit1   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit2   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-seattle   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-thunderx  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-vhd       1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-xsm       1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168080
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168080
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168080
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168080
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168080
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168080
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168080
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                754e0b0e35608ed5206d6a67a791563c631cec07
baseline version:
 linux                f1baf68e1383f6ed93eb9cff2866d46562607a43

Last test of basis   168080  2022-02-11 00:09:22 Z    3 days
Failing since        168086  2022-02-11 20:11:19 Z    2 days    6 attempts
Testing same since   168103  2022-02-13 21:41:20 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Aaron Liu <aaron.liu@amd.com>
  Adam Ford <aford173@gmail.com>
  Al Cooper <alcooperx@gmail.com>
  Alex Deucher <alexander.deucher@amd.com>
  Alexander Egorenkov <egorenar@linux.ibm.com>
  Alexander Gordeev <agordeev@linux.ibm.com>
  Alexander Stein <alexander.stein@ew.tq-group.com>
  Alexandre Ghiti <alexandre.ghiti@canonical.com>
  Alim Akhtar <alim.akhtar@samsung.com>
  Alviro Iskandar Setiawan <alviro.iskandar@gmail.com>
  Ammar Faizi <ammarfaizi2@gnuweeb.org>
  Andreas Gruenbacher <agruenba@redhat.com>
  Andrew Morton <akpm@linux-foundation.org>
  Andrey Konovalov <andreyknvl@gmail.com>
  Andrzej Pietrasiewicz <andrzej.p@collabora.com>
  Andy Shevchenko <andriy.shevchenko@linux.intel.com>
  Arnd Bergmann <arnd@arndb.de>
  Aswath Govindraju <a-govindraju@ti.com>
  Aurelien Jarno <aurelien@aurel32.net>
  Bartosz Golaszewski <brgl@bgdev.pl>
  Bean Huo <beanhuo@micron.com>
  Benjamin Gaignard <benjamin.gaignard@collabora.com>
  Bjorn Helgaas <bhelgaas@google.com>
  Bob Peterson <rpeterso@redhat.com>
  Brenda Streiff <brenda.streiff@ni.com>
  Brian Johannesmeyer <bjohannesmeyer@gmail.com>
  Brian Norris <briannorris@chromium.org>
  Cai Huoqing <cai.huoqing@linux.dev>
  Cameron Williams <cang1@live.co.uk>
  Catalin Marinas <catalin.marinas@arm.com>
  Changbin Du <changbin.du@gmail.com>
  Chia-Wei Wang <chiawei_wang@aspeedtech.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Borntraeger <borntraeger@linux.ibm.com>
  Christian Hewitt <christianshewitt@gmail.com>
  Christian König <christian.koenig@amd.com>
  Christoph Hellwig <hch@lst.de>
  Christoph Niedermaier <cniedermaier@dh-electronics.com>
  Christophe JAILLET <christophe.jaillet@wanadoo.fr>
  Chunfeng Yun <chunfeng.yun@mediatek.com>
  Damien Le Moal <damien.lemoal@opensource.wdc.com>
  Dan Carpenter <dan.carpenter@oracle.com>
  Daniel Bristot de Oliveira <bristot@kernel.org>
  Daniel Stone <daniels@collabora.com>
  Daniel Vetter <daniel.vetter@ffwll.ch>
  Daniel Vetter <daniel.vetter@intel.com>
  Daniel Wheeler <daniel.wheeler@amd.com>
  Dave Airlie <airlied@redhat.com>
  Dave Hansen <dave.hansen@linux.intel.com>
  Dave Stevenson <dave.stevenson@raspberrypi.com>
  David Hildenbrand <david@redhat.com>
  David Rientjes <rientjes@google.com>
  Dinh Nguyen <dinguyen@kernel.org>
  Dmytro Laktyushkin <Dmytro.Laktyushkin@amd.com>
  Dongjin Kim <tobetter@gmail.com>
  Fabio Estevam <festevam@gmail.com>
  Fabio M. De Francesco <fmdefrancesco@gmail.com>
  Fabrice Gasnier <fabrice.gasnier@foss.st.com>
  Florian Fainelli <f.fainelli@gmail.com>
  Geert Uytterhoeven <geert+renesas@glider.be>
  Geert Uytterhoeven <geert@linux-m68k.org>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>Cc: Dave Airlie <airlied@gmail.com>
  Guido Günther <agx@sigxcpu.org> # Librem 5 (imx8mq) with it's rather picky panel
  Guo Ren <guoren@linux.alibaba.com>
  Hans de Goede <hdegoede@redhat.com>
  Hector Martin <marcan@marcan.st>
  Heiko Carstens <hca@linux.ibm.com>
  Heiko Stuebner <heiko@sntech.de>
  Helge Deller <deller@gmx.de>
  Ilya Leoshkevich <iii@linux.ibm.com>
  Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
  JaeSang Yoo <js.yoo.5b@gmail.com>
  JaeSang Yoo <jsyoo5b@gmail.com>
  Jakob Koschel <jakobkoschel@gmail.com>
  James Smart <jsmart2021@gmail.com>
  Jan Beulich <jbeulich@suse.com>
  Jan Kara <jack@suse.cz>
  Jani Nikula <jani.nikula@intel.com>
  Jann Horn <jannh@google.com>
  Jarkko Nikula <jarkko.nikula@bitmer.com>
  Jarkko Sakkinen <jarkko@kernel.org>  (kselftest as sanity check)
  Jasdeep Dhillon <jdhillon@amd.com>
  Jayesh Choudhary <j-choudhary@ti.com>
  Jens Axboe <axboe@kernel.dk>
  Jens Wiklander <jens.wiklander@linaro.org>
  Jeremy Linton <jeremy.linton@arm.com>
  Jerome Forissier <jerome@forissier.org>
  Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
  Jing Leng <jleng@ambarella.com>
  Jisheng Zhang <jszhang@kernel.org>
  Joel Stanley <joel@jms.id.au>
  Johan Hovold <johan@kernel.org>
  Jonas Malaco <jonas@protocubo.io>
  Josh Poimboeuf <jpoimboe@redhat.com>
  Juergen Gross <jgross@suse.com>
  Kai-Heng Feng <kai.heng.feng@canonical.com>
  Kees Cook <keescook@chromium.org>
  Kishon Vijay Abraham I <kishon@ti.com>
  Kosuke Tatsukawa <tatsu-ab1@nec.com>
  Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Linus Walleij <linus.walleij@linaro.org>
  Liu Ying <victor.liu@nxp.com>
  Liu Ying <victor.liu@nxp.com> # RM67191 DSI panel on i.MX8mq EVK
  Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
  Lucas De Marchi <lucas.demarchi@intel.com>
  Lutz Koschorreck <theleks@ko-hh.de>
  Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
  Marc Zyngier <maz@kernel.org>
  Marek Vasut <marex@denx.de>
  Mario Limonciello <mario.limonciello@amd.com>
  Mark Brown <broonie@kernel.org>
  Martin Blumenstingl <martin.blumenstingl@googlemail.com>
  Martin K. Petersen <martin.petersen@oracle.com>
  Martin Kepplinger <martin.kepplinger@puri.sm>
  Masahiro Yamada <masahiroy@kernel.org>
  Mathias Krause <minipli@grsecurity.net>
  Maxime Ripard <maxime@cerno.tech>
  Mel Gorman <mgorman@suse.de>
  Michael Walle <michael@walle.cc>
  Michal Hocko <mhocko@suse.com>
  Michal Simek <michal.simek@xilinx.com>
  Mike Rapoport <rppt@linux.ibm.com>
  Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>
  Myrtle Shah <gatecat@ds0.me>
  Nathan Chancellor <nathan@kernel.org>
  Neil Armstrong <narmstrong@baylibre.com>
  Neil Armstrong <narmstrong@baylibre.com> # for phy-meson-axg-mipi-dphy.c
  Nick Desaulniers <ndesaulniers@google.com>
  Niklas Cassel <niklas.cassel@wdc.com>
  Nishanth Menon <nm@ti.com>
  Padmanabha Srinivasaiah <treasure4paddy@gmail.com>
  Palmer Dabbelt <palmer@rivosinc.com>
  Pavel Hofman <pavel.hofman@ivitera.com>
  Pawel Dembicki <paweldembicki@gmail.com>
  Peng Liu <liupeng256@huawei.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Philippe Cornu <philippe.cornu@foss.st.com>
  Pingfan Liu <kernelfans@gmail.com>
  Pratham Pratap <quic_ppratap@quicinc.com>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Rafał Miłecki <rafal@milecki.pl>
  Reinette Chatre <reinette.chatre@intel.com>
  Rob Herring <robh@kernel.org>
  Robert Hancock <robert.hancock@calian.com>
  Robin Murphy <robin.murphy@arm.com>
  Roger Pau Monne <roger.pau@citrix.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Roman Gushchin <guro@fb.com>
  Roman Li <Roman.Li@amd.com>
  Rui Salvaterra <rsalvaterra@gmail.com>
  Sagi Grimberg <sagi@grimberg.me>
  Sam Protsenko <semen.protsenko@linaro.org>
  Sam Ravnborg <sam@ravnborg.org>
  Samuel Holland <samuel@sholland.org>
  Samuel Thibault <samuel.thibault@ens-lyon.org>
  Sascha Hauer <s.hauer@pengutronix.de>
  Sean Anderson <sean.anderson@seco.com>
  Shakeel Butt <shakeelb@google.com>
  Shawn Guo <shawnguo@kernel.org>
  Shyam Prasad N <sprasad@microsoft.com>
  Slark Xiao <slark_xiao@163.com>
  Song Liu <song@kernel.org>
  Steev Klimaszewski <steev@kali.org>
  Stefan Wahren <stefan.wahren@i2se.com>
  Stephan Brunner <s.brunner@stephan-brunner.net>
  Steve French <stfrench@microsoft.com>
  Steven Rostedt (Google) <rostedt@goodmis.org>
  Sven Peter <sven@svenpeter.dev>
  Sven Schnelle <svens@linux.ibm.com>
  Sylwester Nawrocki <s.nawrocki@samsung.com>
  Szymon Heidrich <szymon.heidrich@gmail.com>
  Tadeusz Struk <tadeusz.struk@linaro.org>
  TATSUKAWA KOSUKE (立川 江介) <tatsu-ab1@nec.com>
  Tejun Heo <tj@kernel.org>
  Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
  Thomas Gleixner <tglx@linutronix.de>
  Thomas Hellström <thomas.hellstrom@linux.intel.com>
  Thomas Zimmermann <tzimmermann@suse.de>
  Tim Harvey <tharvey@gateworks.com>
  Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
  Tommaso Merciai <tomm.merciai@gmail.com>
  Tony Lindgren <tony@atomide.com>
  Tvrtko Ursulin <tvrtko.ursulin@intel.com>
  Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
  Udipto Goswami <quic_ugoswami@quicinc.com>
  Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
  Vasily Gorbik <gor@linux.ibm.com>
  Vignesh Raghavendra <vigneshr@ti.com>
  Ville Syrjälä <ville.syrjala@linux.intel.com>
  Vineeth Vijayan <vneethv@linux.ibm.com>
  Vinod Koul <vkoul@kernel.org>
  Vlastimil Babka <vbabka@suse.cz>
  Wan Jiabing <wanjiabing@vivo.com>
  Yang Shi <shy828301@gmail.com>
  Yang Wang <KevinYang.Wang@amd.com>
  Ye Guojin <ye.guojin@zte.com.cn>
  Yizhuo Zhai <yzhai003@ucr.edu>
  Zhan Liu <Zhan.Liu@amd.com>
  Zoltán Böszörményi <zboszor@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              broken  
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  broken  
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          blocked 
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            broken  
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          blocked 
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      blocked 
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  blocked 
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  blocked 
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     blocked 
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               broken  
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 blocked 
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      blocked 
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary

broken-job build-arm64 broken
broken-job build-arm64-pvops broken
broken-job build-arm64-xsm broken
broken-job test-armhf-armhf-libvirt-qcow2 broken
broken-step build-arm64-xsm host-install(4)
broken-step build-arm64 host-install(4)
broken-step build-arm64-pvops host-install(4)
broken-step test-armhf-armhf-libvirt-qcow2 host-install(5)

Not pushing.

(No revision log; it would be 5152 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Feb 14 06:33:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 06:33:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271190.465537 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJUvO-0007Kh-RT; Mon, 14 Feb 2022 06:33:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271190.465537; Mon, 14 Feb 2022 06:33:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJUvO-0007Ka-Nq; Mon, 14 Feb 2022 06:33:26 +0000
Received: by outflank-mailman (input) for mailman id 271190;
 Mon, 14 Feb 2022 06:33:25 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=YsDI=S5=epam.com=prvs=4044e07e7c=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nJUvN-0007KU-Km
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 06:33:25 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 01d81dd8-8d60-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 07:33:23 +0100 (CET)
Received: from pps.filterd (m0174681.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 21E5h6aO030180;
 Mon, 14 Feb 2022 06:33:12 GMT
Received: from eur01-ve1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2058.outbound.protection.outlook.com [104.47.1.58])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3e7fqn08wy-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Mon, 14 Feb 2022 06:33:12 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM9PR03MB7123.eurprd03.prod.outlook.com (2603:10a6:20b:286::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.18; Mon, 14 Feb
 2022 06:33:08 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::fc4d:4749:5d1:eb73]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::fc4d:4749:5d1:eb73%4]) with mapi id 15.20.4975.018; Mon, 14 Feb 2022
 06:33:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 01d81dd8-8d60-11ec-b215-9bbe72dcb22c
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=AHr/tvDdFj5Hfxs6PLmkajk6UjBW6SVfhUaukTKrYFiWkfd3YEpBSEXKdUkSVOaJCks7vTvRQzQICPqmO86fUguDHRPlLmqVHOCzc0Dv2MNhEv9atpCiSVVSkyaUShmH/kJ2hjj9EBUSbvlgjXfbGdnHDqxj6D1THYBkWJOARar/Z2PMl2kFa4oQ2ci23uaiLrokGJfAmjLz+j98xHFiahE/zTMKTXbiLDn8EudRfxii4blQg6UlD72TKXuv7KCpj/3AhC5gQdlzshkqC8dKAEj772k5Pb1pU4+oOxvYxUoEBT5rmTxbnhrsFrVO2OdI4xQd+K4SUp7HgHgK5jAleA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=w8ELf5Y1gF5qwnJww0uaqHGz69o6pXjws34kuC23Lk4=;
 b=Be731YC7JL0ztOMcfolHtJFsUigL35hVR9InqqNHT9toUtBl6efnM9sVW5L5XNFEujX/AjgvQrqQrqRcVBCBh32TBnqtG6ARWpLlqBy2+BRzXjZnlEO+tIu5r4QpAK8yIxfT2IsZP7xjaVm0LBLR74VNTJ7Gm0/I70ffhwlzLCLBnb6A/Aaboc7Xoml1aaWCSATiB5M1L39CG7WLMWw7s9vuZgoCUjTxKs7vvhXsEg5d+0xTYKor5sdMDX9JAgHR76AP8zyojSitzoqh0Mspq3VQkSYFRB4qLcrSsiL4BhDoT/GPMA1oBXjr+W3s1AZmWJiakHF/qnGvUAQ1AzvXmQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=w8ELf5Y1gF5qwnJww0uaqHGz69o6pXjws34kuC23Lk4=;
 b=YPpd2P8ygckqj5x7QypwGWzy+w5rINNE9kHkiSvzUttiI2pV9RdE+Cdl+5kxiUsPtl1qGISptAT2rZjjXAk01NjJgVd/l25SlMv4w7259fmage7Y4OOrTdI+JKDnLCk4WXphF/BaQ7Wy4osApkdI+m9laYsx7bg09Ou7QBO5mazSZn781TAFDQTtW9IojlrMDAfgGth3Ne2xT6PRrP2qDTkc4Ki5iiPi2IVOBk9krNbf7iQFjQtm4fUCbYm/txH+VDejyegylcAgK44nEeNSg4W6c/0JGbF1hAAk1pbDFiIQTdaByrDKJ/HOgqBAX2Jee61OIOPphzpX+7w3dtOkNw==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "jbeulich@suse.com" <jbeulich@suse.com>,
        "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org" <sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>
Subject: Re: [PATCH] vpci: introduce per-domain lock to protect vpci structure
Thread-Topic: [PATCH] vpci: introduce per-domain lock to protect vpci
 structure
Thread-Index: 
 AQHYHboQT3cBWYI1/EGunE7hOwop6ayM95MAgAD+qQCAAEaDAIAACWWAgAA6ygCABB0SgA==
Date: Mon, 14 Feb 2022 06:33:07 +0000
Message-ID: <6905d6ab-e435-fb65-2e93-446644b69b82@epam.com>
References: <20220209133627.959649-1-andr2000@gmail.com>
 <YgU6Snk8GTytJXZp@Air-de-Roger>
 <c4666570-666e-6680-5ec2-adf1da51ad06@epam.com>
 <YgZLEMW9US9QjjYG@Air-de-Roger>
 <1dbd0f54-affb-1e67-215c-6e6c8fb8535b@epam.com>
 <YgaEQrqIEPc258Fy@Air-de-Roger>
In-Reply-To: <YgaEQrqIEPc258Fy@Air-de-Roger>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 776ac44d-7cc9-4ae1-1030-08d9ef83dd47
x-ms-traffictypediagnostic: AM9PR03MB7123:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM9PR03MB7123D95765FF17EF679F554FE7339@AM9PR03MB7123.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 JK8/SKlQazjsBO6lRndBZs6DqSXHPefERGXRub+qFmMYk30fVo+syUQi3cdD/+TQArXWAbsafKxs1r+Ky9uz9TgIHWr6vqPXl5oiHIl9khKvdbrcU7gpANe5XIdhHQkEXn2AD0iuG7Dl3dXoqm4HVNiLwjBB04zq9wDT2xDc2Nm63tc6Y4uzE+ZUjRA3HBxVfNh7A7RoxlL5j0kCuIjRsMoa/TNPYGD6ziBsZCdbjYmeH3PpaRdEh30DMGOG9Tz4TvsvELU/OQQScW+mBqAHudTRyQsjxuo+CIxx9JRH20XcanRexpL8btOX49z5LdY7DwNvgCWmjG1xhCObGdLFreXT+fhS2u7vd7IVCgvY82N3jexaQbEg1XE07+PJZ5/VSwxm+eUFddHAqqU/51O/zVOq3YMGl5WFICXX4TON+VhkhXVdnrZj8WfJ1aa7lK2NItnPIBqpTgk6sT1svyjuXV1IVapmc+daI6WacltBoT7tAlSvl2QHGu6y1mAaDTQsTz6e91GPSJAt2bBb0/Woj4XG5sgefz9wrB6f7zWhGzExwlIRkYCDQVXGMYNDtgRGZRctWNbDWVKT8ahoolTxZmudqYMN/BgIAxIJx4YK9m2eusqJdFPC2Fu+rfT5vu+8j8NIYpYazr9hRcZzsrVRhjtm45sceYddVBY/ss79xm6Xj+tRkwNptLZZGpsOEDyHKADCeXVje7UxeAgDwV+qh8t5Y1ptI0E/Gpv+w0Ev49K8QzYOz8TcwJQ/qGhoh4lB
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(508600001)(122000001)(5660300002)(38100700002)(6916009)(54906003)(6486002)(316002)(6512007)(55236004)(2616005)(2906002)(36756003)(26005)(64756008)(66446008)(66476007)(66556008)(86362001)(186003)(38070700005)(66946007)(31686004)(4326008)(8676002)(71200400001)(31696002)(53546011)(8936002)(6506007)(91956017)(83380400001)(76116006)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?T3VqKzE5bUk1SUd5bHhMbVpWelN5V0tOWWFjL0lkYU9TUTAvQjYrblNlMnd3?=
 =?utf-8?B?RXdEa3lBSUJoYzZPNlJxSnlOMTBhUkxFaEtEN0RVVzhhTHZmQUFMTFVYcGlh?=
 =?utf-8?B?ZkN2U09MQWI5SVN6b1NzOXQ1cVNNenpaU05xcDl6TkhSYnE4NUlCeFVvTFpY?=
 =?utf-8?B?anlscmNLbnpQbHlSSktKZmMvejNFMXpONDNjZTg2SEpVSGU0d3FQOU5UTFNp?=
 =?utf-8?B?STh1TTBOSDl3YnJtS3JyTERiV3dFK1N1c0YwdTVWMGwveGY1RFo0cjJaSER1?=
 =?utf-8?B?SHUwZERWSGlSeUhGK0dkSTMyZmVneHRVUTlzTHVGWURUU2FZMzA4dUNMbktL?=
 =?utf-8?B?UXVacnVSQ25nMTcyYnpTK3dFRTdzZkRycEJ6eTh4Y04xeWFTdGVNR3ZHWnU4?=
 =?utf-8?B?d2o3U2EyWjhqdWNTeWV5LzVlYTBrK1U5U0tCTXBtc1p3NWM1QjZPaFdFaGpk?=
 =?utf-8?B?dmNDRm1oaUFaY2pQSWREdHFiQmhUM1dKcVdsTmRQa3EzRE5Ka2FYekc5N1BJ?=
 =?utf-8?B?bnhTcE81Ym93VkFCZWcvWHl1cy83VncwaG9meVB0M0RyTjBrTzNjQU4vaDFS?=
 =?utf-8?B?RU1JUzFXNTMvRFZyeHA0eWNFTy9nR1ZYZGFWTEFDZkcxWHAraVRFTmVNbFhk?=
 =?utf-8?B?a25jRkw5TUpmdkNWOWI5MnlMT0VMS3BwY3JVRjBENTU5VFRKemtGVENGN1Yy?=
 =?utf-8?B?VnVJeVRMT0hta1NEbmM4VitiRVJKRWpuNzlzOUMrODhaYlM3QTRlM2ExSW45?=
 =?utf-8?B?RTVPWDlwaVVSTEJWMVNtbG9rRlJGOC9TdUxoTTNqK2g3T2xsMFpUQkU3U0lK?=
 =?utf-8?B?Z3ZuUmtNeHRXejRzNEZ6Tk9uSFRTQStnK3NpRXJqVWZLYzBmVFJrT0Z2d0gz?=
 =?utf-8?B?UnlQQXBpNUE4cW00UjRXRjN4dDNlaThveGU1RlBrVW9zSkc4Tzd4WGtBbytE?=
 =?utf-8?B?NHNwK3lmL1hGbkNiODA0a2UxNjhwWk5XMElLY3Y0dlVVMVMyMCt5YzlHMnk3?=
 =?utf-8?B?ajd4dE9QYlpIODlZVG1lR3YwT1MzSG13QjhmQW5vUTNxMDdvT29YTEFNMWlJ?=
 =?utf-8?B?bjJxR05wOGdYUlMzNGRnUVNhSVlReTM5RGNDbjkrTXVCZDBqaHhzVmdtclU1?=
 =?utf-8?B?MmlWYXJpTlNWSGxnWmNtZUkzay9tRkcyM1U3V1hQL1lwYVJXK21vc0t3WnY0?=
 =?utf-8?B?YUJFQmxNT04yZXp0S2I5NmRiY1RyQ1BiR281cVk4RmNSZktvOHRXVHk5VU5L?=
 =?utf-8?B?ZGZZWVI0cFU3UW10UnV3alZrdnpQUm5VWXhJWWdnVGI2OGM3VW9aSlFHcXY5?=
 =?utf-8?B?Rm9oMTJvT0lzUlZaTWFXb1k5Y1h6N0RXbStCRnNhV2V3M0MxQ2huNU9TNVFr?=
 =?utf-8?B?a2Q0M1MraGNYTUoyVUxsTnl5cE8ySXlCdkZTb1ZOaDRRbElhSnJFbEU1R2kz?=
 =?utf-8?B?U05CcmI2enNDUk9aTWNpUklmUVJwVU9FdUwybWdSRkUxTE05TDR4SFFiWUZp?=
 =?utf-8?B?TFVZbk9wZmdrTTF5RjhBOWdycUF1UHJ0WE9RK0VtK3AvelFweGpONWNyTWJQ?=
 =?utf-8?B?OUdSdnhzb1lzN1JOZXBlZ3J5QTF6cXgyUWVqYklVeG42R0ZZd092ak5PZGZE?=
 =?utf-8?B?d1pIdXNhVUpXQmJsbURMTXFEZnZOTjQrQkd4b1p0TmxMdVdtVGk2OXdwUHND?=
 =?utf-8?B?Y0tBQW56RmFuakZGUmFFZXBkRzh4TE5zUy9JUjA0WG9hVDgvdXR5NFlZVXFC?=
 =?utf-8?B?Qk44blpmUzA2UlgxN1ROM1RZSGJjYm1IaTZCeGhSb3RlMitFZlRqQlplMzVK?=
 =?utf-8?B?QWVFaFowV29tclVVOVE2TE1EY0pybm1NU0ZHenREaENmb2VScjhEeTcySUNT?=
 =?utf-8?B?VWVWbzJuUWg4ZE9mdFhUaWxJZjcrdG1ubUFERkhRdXFBWUY5ek9KcFFVTGdr?=
 =?utf-8?B?SnZMak96VFhCY0VCN2FwcnJyZXpLbU1hVUp5N082UFNpVjJldWIvWXFQR1Z0?=
 =?utf-8?B?eWc3VUJveHJKeElUQVh5aVB1M3JGQTRFV0F2MU1sN1RzY1NWNFdGeFNTM2ZR?=
 =?utf-8?B?VlFlT2JJczVXMk1MMzI3RFpBYUMwU1JtZHFqeUxwN3RZaG91bFhsa0tuRHh5?=
 =?utf-8?B?dlk4bXVUb213cUNUeXpVWVZEMlhBbDhabFgvcUJITWUydmRyZ053eXgvYk1M?=
 =?utf-8?B?Qml4MVZPUk1qaDJVdkZTaWRmcVNiaFgzRVdUS0tGMzFBdUlPUnNieGxHcWZq?=
 =?utf-8?B?TmNVTXBtTU5iUnllQW5ZUUx3NS9sU2I1bnBVQkhXWHFCbDJIdmZlWkVhcjhp?=
 =?utf-8?B?ell5L2VPU3RZZzVFZUtwS3VMb05rOGJ5Vmk0RnVaeEVrUVNhY2FyZz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <08F98950CD8F1E48AAE9EDAB8B5438A2@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 776ac44d-7cc9-4ae1-1030-08d9ef83dd47
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Feb 2022 06:33:08.0406
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: mySMycqgbty8v4wdGQtc9XBhM6U7c2VaJB5w6I2CuQnwv8RurkyA7JA3LzADaHFdYc74IuFEq8geu/rJ7ltZAB3bpnpcw4WXygSEXygxR93nqvWjDWpWBWHdsIcHh85u
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR03MB7123
X-Proofpoint-ORIG-GUID: wFph8D3mjqfLTyHuk0_3Ht2xgbG9x3_n
X-Proofpoint-GUID: wFph8D3mjqfLTyHuk0_3Ht2xgbG9x3_n
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-14_01,2022-02-11_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0
 lowpriorityscore=0 bulkscore=0 impostorscore=0 priorityscore=1501
 mlxscore=0 phishscore=0 mlxlogscore=901 spamscore=0 clxscore=1015
 suspectscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2201110000 definitions=main-2202140042

DQoNCk9uIDExLjAyLjIyIDE3OjQ0LCBSb2dlciBQYXUgTW9ubsOpIHdyb3RlOg0KPiBPbiBGcmks
IEZlYiAxMSwgMjAyMiBhdCAxMjoxMzozOFBNICswMDAwLCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5r
byB3cm90ZToNCj4+DQo+PiBPbiAxMS4wMi4yMiAxMzo0MCwgUm9nZXIgUGF1IE1vbm7DqSB3cm90
ZToNCj4+PiBPbiBGcmksIEZlYiAxMSwgMjAyMiBhdCAwNzoyNzozOUFNICswMDAwLCBPbGVrc2Fu
ZHIgQW5kcnVzaGNoZW5rbyB3cm90ZToNCj4+Pj4gSGksIFJvZ2VyIQ0KPj4+Pg0KPj4+PiBPbiAx
MC4wMi4yMiAxODoxNiwgUm9nZXIgUGF1IE1vbm7DqSB3cm90ZToNCj4+Pj4+IE9uIFdlZCwgRmVi
IDA5LCAyMDIyIGF0IDAzOjM2OjI3UE0gKzAyMDAsIE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIHdy
b3RlOg0KPj4+Pj4+IEZyb206IE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIDxvbGVrc2FuZHJfYW5k
cnVzaGNoZW5rb0BlcGFtLmNvbT4NCj4+Pj4+Pg0KPj4+Pj4+IEludHJvZHVjZSBhIHBlci1kb21h
aW4gcmVhZC93cml0ZSBsb2NrIHRvIGNoZWNrIHdoZXRoZXIgdnBjaSBpcyBwcmVzZW50LA0KPj4+
Pj4+IHNvIHdlIGFyZSBzdXJlIHRoZXJlIGFyZSBubyBhY2Nlc3NlcyB0byB0aGUgY29udGVudHMg
b2YgdGhlIHZwY2kgc3RydWN0DQo+Pj4+Pj4gaWYgbm90LiBUaGlzIGxvY2sgY2FuIGJlIHVzZWQg
KGFuZCBpbiBhIGZldyBjYXNlcyBpcyB1c2VkIHJpZ2h0IGF3YXkpDQo+Pj4+Pj4gc28gdGhhdCB2
cGNpIHJlbW92YWwgY2FuIGJlIHBlcmZvcm1lZCB3aGlsZSBob2xkaW5nIHRoZSBsb2NrIGluIHdy
aXRlDQo+Pj4+Pj4gbW9kZS4gUHJldmlvdXNseSBzdWNoIHJlbW92YWwgY291bGQgcmFjZSB3aXRo
IHZwY2lfcmVhZCBmb3IgZXhhbXBsZS4NCj4+Pj4+IFNhZGx5IHRoZXJlJ3Mgc3RpbGwgYSByYWNl
IGluIHRoZSB1c2FnZSBvZiBwY2lfZ2V0X3BkZXZfYnlfZG9tYWluIHdydA0KPj4+Pj4gcGNpX3Jl
bW92ZV9kZXZpY2UsIGFuZCBsaWtlbHkgd2hlbiB2UENJIGdldHMgYWxzbyB1c2VkIGluDQo+Pj4+
PiB7ZGV9YXNzaWduX2RldmljZSBJIHRoaW5rLg0KPj4+PiBZZXMsIHRoaXMgaXMgaW5kZWVkIGFu
IGlzc3VlLCBidXQgSSB3YXMgbm90IHRyeWluZyB0byBzb2x2ZSBpdCBpbg0KPj4+PiBjb250ZXh0
IG9mIHZQQ0kgbG9ja2luZyB5ZXQuIEkgdGhpbmsgd2Ugc2hvdWxkIGRpc2N1c3MgaG93IGRvDQo+
Pj4+IHdlIGFwcHJvYWNoIHBkZXYgbG9ja2luZywgc28gSSBjYW4gY3JlYXRlIGEgcGF0Y2ggZm9y
IHRoYXQuDQo+Pj4+IHRoYXQgYmVpbmcgc2FpZCwgSSB3b3VsZCBsaWtlIG5vdCB0byBzb2x2ZSBw
ZGV2IGluwqAgdGhpcyBwYXRjaCB5ZXQNCj4+Pj4NCj4+Pj4gLi4uSSBkbyB1bmRlcnN0YW5kIHdl
IGRvIHdhbnQgdG8gYXZvaWQgdGhhdCwgYnV0IGF0IHRoZSBtb21lbnQNCj4+Pj4gYSBzaW5nbGUg
cmVsaWFibGUgd2F5IGZvciBtYWtpbmcgc3VyZSBwZGV2IGlzIGFsaXZlIHNlZW1zIHRvDQo+Pj4+
IGJlIHBjaWRldnNfbG9jay4uLi4NCj4+PiBJIHRoaW5rIHdlIHdpbGwgbmVlZCB0byBtYWtlIHBj
aWRldnNfbG9jayBhIHJ3bG9jayBhbmQgdGFrZSBpdCBpbiByZWFkDQo+Pj4gbW9kZSBmb3IgcGNp
X2dldF9wZGV2X2J5X2RvbWFpbi4NCj4+Pg0KPj4+IFdlIGRpZG4ndCBoYXZlIHRoaXMgc2NlbmFy
aW8gYmVmb3JlIHdoZXJlIFBDSSBlbXVsYXRpb24gaXMgZG9uZSBpbiB0aGUNCj4+PiBoeXBlcnZp
c29yLCBhbmQgaGVuY2UgdGhlIGxvY2tpbmcgYXJvdW5kIHRob3NlIGRhdGEgc3RydWN0dXJlcyBo
YXMgbm90DQo+Pj4gYmVlbiBkZXNpZ25lZCBmb3IgdGhvc2UgdXNlLWNhc2VzLg0KPj4gWWVzLCBJ
IGRvIHVuZGVyc3RhbmQgdGhhdC4NCj4+IEkgaG9wZSBwY2lkZXZzIGxvY2sgbW92ZSB0byByd2xv
Y2sgY2FuIGJlIGRvbmUgYXMgYSBzZXBhcmF0ZQ0KPj4gcGF0Y2guIFdoaWxlIHRoaXMgaXMgbm90
IGRvbmUsIGRvIHlvdSB0aGluayB3ZSBjYW4gcHJvY2VlZCB3aXRoDQo+PiB2UENJIHNlcmllcyBh
bmQgcGNpZGV2cyBsb2NraW5nIHJlLXdvcmsgYmVpbmcgZG9uZSBhZnRlcj8NCj4gSWRlYWxseSB3
ZSB3b3VsZCBsaWtlIHRvIHNvcnQgb3V0IHRoZSBsb2NraW5nIG9uY2UgYW5kIGZvciBhbGwuIEkN
Cj4gd291bGQgbGlrZSB0byBiZSBzdXJlIHRoYXQgd2hhdCB3ZSBpbnRyb2R1Y2Ugbm93IGRvZXNu
J3QgdHVybiBvdXQgdG8NCj4gaW50ZXJhY3QgYmFkbHkgd2hlbiB3ZSBkZWNpZGUgdG8gbG9vayBh
dCB0aGUgcGNpZGV2cyBsb2NraW5nIGlzc3VlLg0KT2ssIHNvIEknbGwgc3RhcnQgY29udmVydGlu
ZyBwY2lkZXZzIGludG8gcndsb2NrIHRoZW4NCj4NCj4gVGhhbmtzLCBSb2dlci4NClRoYW5rIHlv
dSwNCk9sZWtzYW5kcg==


From xen-devel-bounces@lists.xenproject.org Mon Feb 14 07:00:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 07:00:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271197.465548 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJVLD-00027X-VG; Mon, 14 Feb 2022 07:00:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271197.465548; Mon, 14 Feb 2022 07:00:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJVLD-00027Q-S9; Mon, 14 Feb 2022 07:00:07 +0000
Received: by outflank-mailman (input) for mailman id 271197;
 Mon, 14 Feb 2022 07:00:06 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Ur5s=S5=wind.enjellic.com=greg@srs-se1.protection.inumbo.net>)
 id 1nJVLC-00023A-U8
 for xen-devel@lists.xen.org; Mon, 14 Feb 2022 07:00:06 +0000
Received: from wind.enjellic.com (wind.enjellic.com [76.10.64.91])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id bc1ea17d-8d63-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 08:00:04 +0100 (CET)
Received: from wind.enjellic.com (localhost [127.0.0.1])
 by wind.enjellic.com (8.15.2/8.15.2) with ESMTP id 21E60CFD024972
 for <xen-devel@lists.xen.org>; Mon, 14 Feb 2022 00:00:12 -0600
Received: (from greg@localhost)
 by wind.enjellic.com (8.15.2/8.15.2/Submit) id 21E60BjV024971
 for xen-devel@lists.xen.org; Mon, 14 Feb 2022 00:00:11 -0600
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bc1ea17d-8d63-11ec-b215-9bbe72dcb22c
Date: Mon, 14 Feb 2022 00:00:11 -0600
From: "Dr. Greg" <greg@enjellic.com>
To: xen-devel@lists.xen.org
Subject: IGD pass-through failures since 4.10.
Message-ID: <20220214060011.GA24404@wind.enjellic.com>
Reply-To: "Dr. Greg" <greg@enjellic.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.4i
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.2.3 (wind.enjellic.com [127.0.0.1]); Mon, 14 Feb 2022 00:00:12 -0600 (CST)

Good morning, I hope the week is starting well for everyone.

We've made extensive use of PCI based graphics pass through for many
years, since around Xen 4.2.  In fact, we maintained a set of patches
for ATI cards against qemu-traditional that have seen a lot of
downloads from our FTP site.

We ended up switching to IGD based graphics a couple of years ago and
built a stack on top of Xen 4.10 using qemu-traditional.  That
coincided with our transition from Windows 7 to Windows 10.

We've never enjoyed anywhere near the stability with IGD/Windows-10
that we had with the ATI/Windows-7 desktops, ie. we see fairly
frequent crashes, lockups, reduced performance etc.  The ATI/Windows-y
desktops were almost astonishingly reliable, ie. hundreds of
consecutive Windows VM boot/passthrough cycles.

In order to try and address this issue we set out to upgrade our
workstation infrastructure.  Unfortunately we haven't found anything
that has worked post 4.10.

To be precise, 4.11 with qemu-traditional works, but upon exit from
the virtual machine, to which the graphics adapter and USB controller
are passed through to, both the USB controller and the graphics
controller cannot be re-initialized and re-attached to the Dom0
instance.

It appears to be a problem with mapping interrupts back to dom0 given
that we see the following:

Feb 10 08:16:05 hostname kernel: xhci_hcd 0000:00:14.0: xen map irq failed -19 for 32752 domain

Feb 10 08:16:05 hostname kernel: i915 0000:00:02.0: xen map irq failed -19 for 32752 domain

Feb 10 08:16:12 hostname kernel: xhci_hcd 0000:00:14.0: Error while assigning device slot ID

At which point the monitor has green and block bars on it and the USB
controller doesn't function.

Upstream QEMU doesn't work at all, the qemu-system-i386 process fails
and is caught by xl and then tries to re-start the domain, which
remains dead to the world and has to be destroyed.

We revved up to the most current 4.14.x release, but that acts exactly
the same way that 4.11.x does.  We've built up the most recent 4.15.x
release, so that we would be testing the most current release that
still supports qemu-traditional, but haven't been able to get the
testing done yet.  Given our current experiences, I would be surpised
if it would work.

We've tentatively tracked the poor Windows 10 performance down to the
hypervisor emitting hundreds of thousands of IOMMU/DMA violations.  We
made those go away by disabling the IGD IOMMU but that doesn't fix the
problem with upstream QEMU being able to boot the Windows instance,
nor does it fix the problem with remapping the device interrupts back
to Dom0 on domain exit.

The 4.10 based stack had been running with 16 GIG of memory in the
DomU Windows instances.  Based on some online comments, we tested
guests with 4 GIG of RAM but that doesn't impact the issues we are
seeing.

We've tested with the most recent 5.4 and 5.10 Linux kernels but the
Dom0 kernel version doesn't seem to have any impact on the issues we
are seeing.

We'd be interested in any comments/suggestions the group may have.  We
have the in-house skills to do fairly significant investigations and
would like to improve the performance of IGD pass-through for other
users of what is fairly useful and ubiquitious (IGD) technology.

Have a good day.

Dr. Greg

As always,
Dr. Greg Wettstein, Ph.D, Worker      Autonomously self-defensive
Enjellic Systems Development, LLC     IOT platforms and edge devices.
4206 N. 19th Ave.
Fargo, ND  58102
PH: 701-281-1686                      EMAIL: dg@enjellic.com
------------------------------------------------------------------------------
"My thoughts on the composition and effectiveness of the advisory
 committee?

 I think they are destined to accomplish about the same thing as what
 you would get from locking 9 chimpanzees in a room with an armed
 thermonuclear weapon and a can opener with orders to disarm it."
                                -- Dr. Greg Wettstein
                                   Resurrection


From xen-devel-bounces@lists.xenproject.org Mon Feb 14 08:36:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 08:36:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271213.465559 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJWpt-0002nv-8W; Mon, 14 Feb 2022 08:35:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271213.465559; Mon, 14 Feb 2022 08:35:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJWpt-0002no-4w; Mon, 14 Feb 2022 08:35:53 +0000
Received: by outflank-mailman (input) for mailman id 271213;
 Mon, 14 Feb 2022 08:35:52 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KkXt=S5=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nJWpr-0002ni-RG
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 08:35:51 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1cac1751-8d71-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 09:35:49 +0100 (CET)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2059.outbound.protection.outlook.com [104.47.13.59]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-7-rQL8-wCnM1inenlQ_GI8SA-1; Mon, 14 Feb 2022 09:35:48 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DB7PR04MB4250.eurprd04.prod.outlook.com (2603:10a6:5:27::24) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.18; Mon, 14 Feb
 2022 08:35:46 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4975.015; Mon, 14 Feb 2022
 08:35:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1cac1751-8d71-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644827749;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=afKhXFrMDhUUQ7oYTlAQJHdkIdmbKvx8UuZLSRateHE=;
	b=KfWG6LNYR3X2HsBs6m0aghhq+5TRS7Q4Qj6ipSBAvNO15tG3unuAd+/3pJCg3Bn90DAMez
	TWHZAk1Psg1T3uwQnMAwe9C8zaWmNXzdAMCYUqKjy446qD9upJ8ja2h1hA8TVi5HbaUVX7
	DhlsCyaDGe12uQ/INGtvG2QMl/c8pSY=
X-MC-Unique: rQL8-wCnM1inenlQ_GI8SA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=fqVwa5LcUDNRiPXHA1UBvJaY+Qgp06SaAnXqeMF3FmzwyzS61ZWxpjK8LvdwBzOAqxwO12HsZUASNTvH4avC0jz8hDTzfCRRqWeLxeqptupTkQoH0tfAn3p31DSYvYwTwO8nnf2CWpp4UB32sU06nrAAxelKBPWGbzYwov1B8jbQ1whrl19fDFGVzxXjXIkVkZidRSpDI2L5GNc4l+lq4X8Vt5nDKyHQ5U0RWvxSKyLTucA9iIimMqk88WGATFRrFlq2xUjxNnaSxnVSxZW9Ytd4+j1vo3xrXDELyJyBOkSI95GyE595oQQYOhXzL/iOmjrxljVG6FgB/PsNwPjx2w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=afKhXFrMDhUUQ7oYTlAQJHdkIdmbKvx8UuZLSRateHE=;
 b=grWtPw+7aKMlkEsMW9KuYhQ4/8Cr/C3me0eXmLPVzlQEkZXPtdmUYYsndcrXFPHSiLgMjIWjeDo1lALFfcy4FSGVkQdbt9TX9A7fKiME4p5/6koncZj7QoVqwQoFYhrc7s+9MxaW2DAUiIQqvIhs9sacPdN13PdzcMGqXseVg65iANvBETI58ZfgpG7DdYk0yxqiHTnOAZnfNnixsQqtdvXv3b47+2P6bN0l93EShg4HinpcF9g+ynx8bitj7Sh39JiOTKk8ZvJTSmv7K3gW13zPdWBn8pKGE08hvHJ/0qT1GR9JRu3NIk/4QwGLWQwCwee1IsPcg9XbGVp8aIpg/A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <f7c7eed8-eb12-5fef-ceb3-e4216aa0918c@suse.com>
Date: Mon, 14 Feb 2022 09:35:47 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH CPU v2] cpuid: initialize cpuinfo with boot_cpu_data
Content-Language: en-US
To: Norbert Manthey <nmanthey@amazon.de>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20220211152559.27862-1-nmanthey@amazon.de>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220211152559.27862-1-nmanthey@amazon.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0301CA0013.eurprd03.prod.outlook.com
 (2603:10a6:206:14::26) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d7c7bcea-497a-4f8b-a0c9-08d9ef94fefc
X-MS-TrafficTypeDiagnostic: DB7PR04MB4250:EE_
X-Microsoft-Antispam-PRVS:
	<DB7PR04MB4250B804F81B5012CE53C80DB3339@DB7PR04MB4250.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ktWxbovZsX400bEHbZYe/VmAnTgcL15x+2KcCmLgBKiVdsFuA/JTC2kYoI+Wg1hi54sjMkM1Ssl8nyc6B6MabXEDK07TEwzV4mDLG/l0Yj3f18zbcGbkiytyUOc6QVeW5hOqWCPQFRIWNW4WuItEgqn5bLBly3k8dKWdUOiPXwATos9e4IduYvWHPAhBSQC16LODMrZmFl1rtT1uSCxy9vKZLgdJKjFWNSWwlsJRtqbV96eDDvKl2+lBfT4GOGON3yfxm+vgot2bT8dHAf1ibPBNH8mHAOChtgn3AVijrNbpyXxDpEK3H4COrMEBagaCpBNwythSA11p0Da51G+5Ndd5lXFeXmWJuCt3DB7u3wEM3WFHeGVa/MjvcPabxh+7/1Ty363XAH1hqlM1PEyvAe9W49oxkhVwfCz7o0Xd+L1KJVkBHfRHbe5sPMLWf6TMxBmFi9RwOkqVCw6cohHw0nHzuDq/qM+ziY0FalhO0ybanuZWMhhyLUtjDGv/EpNZihjI9Rll750knpZUtDnkjmqHbGm3drgH9cY/qRoORJUkf+lXPQmMdkhIJ/D9S5tDi3l73Y6msSdhpuXiLPg8se0RaYwN7SHqTlusANtlYqTYIcIp342lketse+tKw1xjJUW9ulyMzR2aBf/8Neyag5TgU71Y3l7oOOdt7GF9wp2FYT+z4TJh54zFSanW3QbslqpEiY12ckoIYZr+LhaoIif0+BQ5R1Xtmfwn5EKIWnE=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(26005)(5660300002)(186003)(83380400001)(4326008)(86362001)(316002)(6486002)(8676002)(66556008)(66476007)(66946007)(8936002)(2906002)(54906003)(36756003)(6916009)(38100700002)(31696002)(6512007)(508600001)(2616005)(31686004)(53546011)(6506007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VlM0TVBpOXV4K0VaWWJWZTdPNE5RMi8rci9PT2JnWUoySmd4UFNnRDFET0xY?=
 =?utf-8?B?MkQ0dzFKeW9vbjJXd3RoU3dRL2FiQ2Z3T3VCaW1kQTJJK0phSXZXSHVXMGRi?=
 =?utf-8?B?Zm5SeFcxSWI5bjVucEN4cG5Uek05S1NuNVNqVnhRRzBEN0ZIZTNqcXBtU0FF?=
 =?utf-8?B?TUN4T1JFK0FEazNHcU5GY0RnKzhVbkk3VEJUR0kveFZXY0VmUzRYS09IdzRT?=
 =?utf-8?B?Uk1UNTVOVlh1ajVDQURIRyt2TkErWkJSTmN0RXhrOEZJK0JqSWVFdklKaGY4?=
 =?utf-8?B?WWhUVmxrdWVFdGxFU3dYWm1WaXFrQ2IxdWFZUUVnTUZxd0RBNC9rRzE0a2hn?=
 =?utf-8?B?aitWNzBPSTNCNkpGdFFHODR6UmxiTFREQkUwNFREbUYrWFpsZ0ZZNkU3algr?=
 =?utf-8?B?VW9CTkt6aWFpZ0U2Mk1mdm5SYmVWOEExQ1NCckhMU1NMTzlwTUpiaVhkV0Ry?=
 =?utf-8?B?N3lwNmNsc05Mamt5SDhnKytBTDJVS1YwNXFDckIrNXA0NXF4bXp6YzNuak1N?=
 =?utf-8?B?eVRVQXVCNVAyMUZqaXdJS2lyUTdHUCsxbEFIUXJNS3M3ZzVlK1kzUVhKcWFT?=
 =?utf-8?B?U1NRKzdYVjRUVkxSVU5DVTNrN1BxK05qL3hJVE94R0w4TnJCdHRzS0s1aGNK?=
 =?utf-8?B?cXdTaE8vQmlqZnJmRlVwSkRWZ3JQN250T05zZUsvNVdBanJXMGR6SktXRSsw?=
 =?utf-8?B?dm03dSszQlBLSjR4cjhrbkZOS1Q0VE1HVnpXZTh5N2o0Y3pZVVRUdlNweHht?=
 =?utf-8?B?VnNRYnlzbnFxbjN5K3A1UWFrOGptWC9xSlJnZmdlUksyVGRwY3F6N1ZSc2ty?=
 =?utf-8?B?anJvN1JzSitMMHBIbWYvbXFBaFlGOGgwNnpQaGkvRmR1VkVBL2c5Znk2ZEdV?=
 =?utf-8?B?ME5GWjNZN1M3akZzd1FpS1pwaDRFWWlJL09PMWsxdTEramZhQXZKeXdpM2Ix?=
 =?utf-8?B?ZjliVHJpc3dBQkVTZGVYT0dhWVdNS0tSNndxVDEvd0RXMktidFlINGFRektu?=
 =?utf-8?B?RThvc1V0eFFhOFdmbm1ZbTNxSWo3Ri9aSjVDZ1VWRG5ORHhmd2NQeE4zNjA2?=
 =?utf-8?B?V1N2dTBSRWJXcTJHeWVBS0hiVzVRdzZFdzlwa1hYVUtQUUg2S1dWN2RKMS9m?=
 =?utf-8?B?NG52ZzBUMVBaMEVvVjk3UU94MkN1RFBUd1VBU0YyRmcxblpQN2FDcnF0NGJK?=
 =?utf-8?B?bTVzbGlJK2h2cVozMUx2YUNOQ1dEd2pZVndwNEhreGRTRStWYW9ZREs1TzNa?=
 =?utf-8?B?VW8zMkRYRzdkU3A3YXFpb1FGdzhNZ2N2TDNrSVpMWmVleUp2Q2hQZjBadzh6?=
 =?utf-8?B?U04zaURxRVMvNzlYdnNhZEVjenNvL0E2NU9RL2hzMEdhcVpQMkR6aG5kM0xO?=
 =?utf-8?B?MVgxRzZlVmhDamppbWpaTW12b3Z6b3JvQy96d3ZXOHRBMWNjQkRsYjBkQjBC?=
 =?utf-8?B?YjRkWUMrU2JOZWZrV0Y2dVNUbmxDN251eitZY2pwY2dSbzRMREdWcW0raUFB?=
 =?utf-8?B?b05nTHU0V1BpcHU2UzI5MFltZDVvRzhySkV5SXpUdUJlci8yY2JCbVA5VTFJ?=
 =?utf-8?B?S2Y2dWVSUFpOMGUzM3VOdnFGMS81byt5NEdFcDVMVmNydGt2NXh1cDN0bXEz?=
 =?utf-8?B?aExMQXZ6aUZ1YlQvd1hqWmRiVzU4M3ZtTFZaRWVmMitiWHRYQTNzOVZqU2lp?=
 =?utf-8?B?KzNHNnJkK096bFVrM1lKbU9aNGV4akQrMGdzK1RKK1c1YlY3RHJpVmtZcVdQ?=
 =?utf-8?B?M0VsWGJzSVZZdTVoNHM4Z0dWcnhuY2o4cXFNc3lIY0RJUVlhYkRzNUNSZmlV?=
 =?utf-8?B?dE9qZVJ0UlNvWlpTMXpRY2kvNTEyNE1nbmFOdHlUMmRxRi8zNG51M3RUNTZV?=
 =?utf-8?B?RWlXUHArWElrbmtxTnRVMkZ5KzBWUGM5cFcyamUyeFNoeWcrWWt2R2Jma3cx?=
 =?utf-8?B?c296VmVadEZnUGJhY3I4cGNZWDdBbytYQWFZNGpRaDJwVHFUVytvTzRMWlVS?=
 =?utf-8?B?SEZBVE9DYjFGR1orUzAvVEkvVVlNK1VPSCt1VnZreVkreE9aUmJkMkZ3REts?=
 =?utf-8?B?b1RDWk13TFprWFBTWllWTDI3S0JvZUlrYXZYSklQRUZlWi9ZOWpEcENacmVl?=
 =?utf-8?B?VUJXUy90MkQyc28ralpWS0xEcUJsRExSUGdPaUM3U3pzcksrVDBBNHQ4VDNp?=
 =?utf-8?Q?9vfOYF8q+mU+BefCLW4hdjw=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d7c7bcea-497a-4f8b-a0c9-08d9ef94fefc
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2022 08:35:46.3365
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ll2wAY2DiuxvlLKykeCAfjfq2EDHQA774GaPF2LOiBUq4qY+bZsZlNOB/vHxLhFTEGSaWwFGDa8MW7U8H0ZvWw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4250

On 11.02.2022 16:25, Norbert Manthey wrote:
> When re-identifying CPU data, we might use uninitialized data when
> checking for the cache line property to adapt the cache
> alignment. The data that depends on this uninitialized read is
> currently not forwarded.
> 
> To avoid problems in the future, initialize the data cpuinfo
> structure before re-identifying the CPU again.
> 
> The trace to hit the uninitialized read reported by Coverity is:
> 
> bool recheck_cpu_features(unsigned int cpu)
> ...
>     struct cpuinfo_x86 c;
>     ...
>     identify_cpu(&c);
> 
> void identify_cpu(struct cpuinfo_x86 *c)
> ...
>     generic_identify(c)
> 
> static void generic_identify(struct cpuinfo_x86 *c)
> ...
>         if (this_cpu->c_early_init)
>                 this_cpu->c_early_init(c); // which is early_init_intel
> 
> static void early_init_intel(struct cpuinfo_x86 *c)
> ...
>     if (c->x86 == 15 && c->x86_cache_alignment == 64)
>         c->x86_cache_alignment = 128;
> 
> This bug was discovered and resolved using Coverity Static Analysis
> Security Testing (SAST) by Synopsys, Inc.
> 
> Signed-off-by: Norbert Manthey <nmanthey@amazon.de>

Acked-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 08:48:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 08:48:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271222.465570 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJX1j-0004NL-Fg; Mon, 14 Feb 2022 08:48:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271222.465570; Mon, 14 Feb 2022 08:48:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJX1j-0004NE-CK; Mon, 14 Feb 2022 08:48:07 +0000
Received: by outflank-mailman (input) for mailman id 271222;
 Mon, 14 Feb 2022 08:48:06 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=jzps=S5=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nJX1i-0004N8-7g
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 08:48:06 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ceb177e7-8d72-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 09:48:00 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ceb177e7-8d72-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644828484;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=hXfZbY8I+9B/2jlQsMG7c9Q3i7+a9tTwWGvZ6NQJqLA=;
  b=Zin8Ld2BDTAOt6Zy6sq/t772/tLfoyUk/Ty+QH6yzLPYp9LUOqM1nmMZ
   GCjzhmuZBqhrjuOWeTXawnRLFXgg9dTOUlxyUt/oR9qhmyq1wcL3q/+Sl
   NcCY1/tQzpqnkKZWCNsB2p2wFgWOGEh91M3xeeLHdUiA/5VxvkVE4/KFH
   g=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: uoQxWw9EjeA9nFy8qmfA7bCWdddjnc9lvol8SNVTOsB1pTmByHhVj85fcIKXj5iUYYnzZ3bPMT
 jCJ7kQKmOVE/mcBYc5ZrfYYMIWN1Qeldf7lewyUmxNu647Zxu5P6RCppGhXY4AkyfuiTKIYJHj
 F3cP+s6Dlk849jVdzwXjEzfm97pdK2VtxXW0pyioaVQ4y68qTxkEjjPeHsFso4+3ReVjYXXew1
 A1LZZr+qoSL2t+OsiuO28+XM9ybSJX3QzGRn7CUmhpk70wn4HY5FTxe5ouY8yO2nlpUJRv/pQa
 Gb1eZvqPOln8AktZ4JxDZip7
X-SBRS: 5.1
X-MesageID: 64134855
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Qa268q+4i6/NNqvXpKY8DrUDjniTJUtcMsCJ2f8bNWPcYEJGY0x3z
 DcaWjvQP6mLN2LweN93YNvk/E8FvZ7Tz9FrHlE/+3o8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhFWeIdA970Ug5w7Rg3tYx6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhel
 ohvtqSLSDx2N/CRu/tHXUliMC9XaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguw5K8bmJsUHs2xIxjDFF/c2B5vERs0m4PcGgG5r2pATQJ4yY
 eIicCZEbjHAeCddJ2pHKZ5ixNW5oFLgJmgwRFW9+vNsvjm7IBZK+IbqNN3Za9mbX/J/l0yTp
 n/F12nhCxRcP9uaoRKi9n+vnebJkTnMZJMJFLa4+/hph3We3mUWThYRUDOTiOOlh0uJfsNQI
 k0Z5AIjtaE3skesS7HVRRS4vXrCpR8aVNp4Gvc/rgqKz8L86QuDGnINSDIHbdU8rdI3XhQjz
 FrPlNTsbRR/vbvQRX+D+7O8qTKpJTNTPWIEfTUDTwYO/5/kuo5bpjXLQ9V4Gai5lOrcHz3q3
 iuKpygzgbYUpcMT3qD99lfC6xqurJXUSg8+5i3MQ3moqAh+YeaNfJe04FLW6fJBKoexTVSbu
 nUA3c+E44gmD4yJlSGLaPUAGveu/fntDdHHqQcxRd97rW3roiP9O9ALiN1jGKt3GulaJB3qW
 HTSglxYucJwIyGkPZVUbavkXqzG0pPcPdjiU/nVaP9HbZ5waBKL8UlSWKKA44z+uBNyyP9iY
 P93Ze7pVC9HUvo/kFJaUs9AiedD+8wo+Y/EqXkXJTyD2KHWWnOaQKxt3LCmPrFgt/PsTOk4H
 r9i2yq2J/d3DbeWjsr/q9d7wbU2wZ8TX86eliCvXrTfSjeK4Ul4YxMr/ZsvepZ+g4NenfrS8
 3e2VydwkQSj2SKXeVjXMik4MtsDuKqTSlphY0QR0auAgSB/Me5DEo9DH3fIQVXX3LM6lqMlJ
 xX0U86BHu5OWlz6F8c1NvHAQHhZXE3z32qmZnP9CBBmJsIIb1GZq7fMI1q0nAFTX3XfiCfLi
 +D5vu8tacFYHFoK4Qe/QK/H8m5dSlBDxLwsDxGVfrG+uizEqeBXFsA4tdduS+kkIhTf3DqKk
 QGQBBYTv+7WpIEpttLOgMi5Q02BSoOSx2JWQDvW66iYLy7f8jbxyINMSr/QLzvcSHn16OOpY
 uAMl6PwN/gOnVBrtYtgEuk0kfJitoW3/7IKnB55GHjrbkiwDu8yKHexwsQS5LZGwaVUuFXqV
 xvXqMVaI7iAJOjsDEUVeFg+du2G2PxNwmvS4P05LV/U/ihy+LbbA0xeMwPV0H5WLadvMZNjy
 uAk4ZZE5wu6gxssE9CHkiELqDjcci1eC/0q78hIDpXqhwwnzkB5TabdUiKmsouSb9hsM1UxJ
 mPGjqT1mLkBlFHJdGA+FCaR0LMF14gOoh1D0HQLO0+NxojenvYy0RBcrWY3QwBSwkkV2u5/I
 DE2ZUh8JKHI9DZ0nslTGWurHlgZVhGe/0XwzXoPlXHYEBb0BjCccjVlNLbf5l0d/kJdYiNfr
 eORx2vSWDr3eN38g3kpUkl/pv2/FdF8+2UuQix88xhpy3XiXQfYvw==
IronPort-HdrOrdr: A9a23:/WjFbK7EebF6bjzPpAPXwVCBI+orL9Y04lQ7vn2ZFiY7TiXIra
 yTdaoguCMc6AxxZJkh8erwX5VoZUmsj6KdhrNhQItKPTOWw1dASbsN0WKM+UyDJ8STzJ856U
 4kSdkDNDSSNykKsS+Z2njALz9I+rDum8rJ9ITjJjVWPHlXgslbnnlE422gYytLrWd9dP4E/M
 323Ls5m9PsQwVdUu2LQl0+G8TTrdzCk5zrJTYAGh4c8QGLyRel8qTzHRS01goXF2on+8ZuzU
 H11yjCoomzufCyzRHRk0fV8pRtgdPkjv9OHtaFhMQ5IijlziyoeINicbufuy1dmpDk1H8a1P
 335zswNcV67H3cOkmzvBvWwgHllA0j7nfzoGXo90fLkIjcfnYXGsBBjYVWfl/y8Ew7puxx16
 pNwiawq4dXJQmoplWy2/H4EzVR0makq3srluAey1ZFV5EFVbNXpYsDuGtIDZY7Gj7g4oxPKp
 ggMCjl3ocXTbqmVQGbgoE2q+bcHEjbXy32DnTqg/blkgS/xxtCvg4lLM92pAZ2yHtycegB2w
 3+CNUaqFh5dL5jUUtMPpZwfSKJMB2+ffvtChPaHb21LtBOB5ryw6SHlYndotvaP6A18A==
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="64134855"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jGfiT0hy+C4I3lvv2oEJbyKSNquHRnG9t735RMAfMnHU3mEqwf5q7O3On3S0b+cqmlDChkhmLknWdJo1OVeMOMX6mL673Q3FnscNGMtveW+tE8PjxogCacW14z13H5cSigbcDv4xFwUKI1zb5AXwpca8PuXCIB/6EBwlEkMa/J1nD/h0wM/N6UAL2CKnUPVvqwrSc58iAbkAoKzh4x/vTXA2A+WfQ1ng6vR4jzw2PW+AbHuoynB7Huhwc8OlLm8jfsA20qE4weO6Bqwh0v35yTuO2tKbkWyW3vkBoeQg5Aq9TFK9oSmZ9VsGIvLxk+1Kzqrvn7ckp8KKcFrY5ptDJw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=kGCVuJ1wF5D/hUbD2805DTVSD6WhajzxFCZ9JVtj7pY=;
 b=EIj2foSZPOP6CmAUCtp9U3e3rAsQjLjLq74xPeONQJ0XMz6I49k78xl2XE4PNFTV7WwjRH6ilaiGHpApDODF479jgNYC8w1iPDB+Y81jQ+fHjzCVBu7D4g9hN0zLH8rVSC60UXf+mbLp6KVGzl/BJMpIOyP0I8z0vyTbjxeMDjypEMGrdRsV5YBge3WJY3Su7CANUgPmLeBEn/MbO67V/tPcWVhMmNTE1jbA1MjIVD2RctB/wixeIj+QwT88+ZfRnuBBk2uuRrJ71OH4Oj8r557JYyq6jBg6N2Qdc9hg3Ys1ryVHwzy3OnqM2HOBT0YoZkPe0PQrBmGkLV3Biz1S3Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=kGCVuJ1wF5D/hUbD2805DTVSD6WhajzxFCZ9JVtj7pY=;
 b=BRXtPVN/8sHXbkUxF1MU9OW147GvLdmxWic7NXcA0xu72SH6Kjk0XSnP0BHT3R7kqc3yb0Jadv69vFedhnMwB8szkcB9zECCFeeG+QYV7JTdcbrN3b2dQkxzEW1c61deQ+tuqmc+Z5vN30wnBGtpIqv55R4SFMwAs870LuBfqrc=
Date: Mon, 14 Feb 2022 09:47:07 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"jbeulich@suse.com" <jbeulich@suse.com>, "julien@xen.org" <julien@xen.org>,
	"sstabellini@kernel.org" <sstabellini@kernel.org>, Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Artem Mygaiev <Artem_Mygaiev@epam.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>, Rahul Singh
	<rahul.singh@arm.com>
Subject: Re: [PATCH] vpci: introduce per-domain lock to protect vpci structure
Message-ID: <YgoXC8vJvsz4lwBM@Air-de-Roger>
References: <20220209133627.959649-1-andr2000@gmail.com>
 <YgU6Snk8GTytJXZp@Air-de-Roger>
 <c4666570-666e-6680-5ec2-adf1da51ad06@epam.com>
 <YgZLEMW9US9QjjYG@Air-de-Roger>
 <1dbd0f54-affb-1e67-215c-6e6c8fb8535b@epam.com>
 <YgaEQrqIEPc258Fy@Air-de-Roger>
 <6905d6ab-e435-fb65-2e93-446644b69b82@epam.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <6905d6ab-e435-fb65-2e93-446644b69b82@epam.com>
X-ClientProxiedBy: MR2P264CA0010.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:500:1::22) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 858ff025-3c55-4768-61c5-08d9ef96983b
X-MS-TrafficTypeDiagnostic: DM4PR03MB6064:EE_
X-Microsoft-Antispam-PRVS: <DM4PR03MB60643B5D587EFCEBCC3523408F339@DM4PR03MB6064.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: u4xfKptPectNI5vZpHmBHLl/sY7XNZCqqOD+wLtsr/C1dg+kcVWqqzxAkR/c7rJA5iu8C7eCHkdGOP5P8zKPC8SjS1GgpGyHkWC+TTttxTmF8KaWOBo2fyEEiRMY38ihmqdcbLpnBmf/vdsqY/V5i6IZvU+p8mZZy7KciIc+3kbnw7gnZQqEOGKbqAU5zpS4DliWCfxUne3Pi2VmNYnRurjXs2ipyOoS+sRXdB1a4wzpe8yECzY5pQY3s354bxoYrBL4wBeWfKoRHDsBXJeR7TEdyLfV0jjyOSVUc+YyqmDAKmdZvW6cG8JJwDLhdxnV8zTfIUYwW7ZUwNMLELvPadEw+8Pdv77JtgvP+Gzcin8od4TvbqP1mCp+XGGH8QHqpmDT+YidwSRt3FEdlK2Y/48jqUw0hSPxaYmGhLz/4rVyJtG4DWHUTmBzyjTrMi16z9lG2Mb10Gq/vq6Dr98CVH/7H73oXTVZXxqNHFgsvTd3nghouqtOOw2tVEMyJeC5C3IogpgEeVhsza9t0yt7PqGO9owKXJ27UrAo8Ja1C/uPcI2eFnWjQoFbcIqjPX0G2DgbpZVCsS3JNFCCK9yXy1DdXoZETAaijdGMYA7L6TSjAtprZpNzo7agKkGaKHeQVradP7DnBxGehvj81ijdYA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(82960400001)(66946007)(316002)(6916009)(54906003)(85182001)(4326008)(8676002)(66476007)(66556008)(2906002)(83380400001)(33716001)(7416002)(5660300002)(186003)(86362001)(26005)(8936002)(6506007)(53546011)(38100700002)(6666004)(6512007)(508600001)(9686003)(6486002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L2hVOXZoZm9ON0pESm1UTVB1ZFNJQTZzamoxdWRlZ1M0Q3VodGxKVXpSVUdG?=
 =?utf-8?B?WW9TYWl4R2FhTlY2bXNkY2VkbmxReEpCeXZ4ZVRqOG9KZ1YycGJsVkZFOUx3?=
 =?utf-8?B?Y0ZkVHkxSE5rVEltdHpjV3l2cllMRDV5NmNXMHRpUEs3L3FLdFRXNjg2VFNK?=
 =?utf-8?B?YmZrQWNsRGNmbW40OHR2cHF6a0tBbjVaa2ZQaHo5dDRZR2dwdFk3WUR6Yzc2?=
 =?utf-8?B?U2hBUjg3N1ZFT0tPT2NvT21YTkJ3aTdHYnZKdnFmSnN6ekttRFJPcWZXYmQ5?=
 =?utf-8?B?MGJZalVNRGxYQ0dlR1UrN1ZpNVkxVzZEVFU5bFEwdHJ3SUI3QmlSMVA5SGI2?=
 =?utf-8?B?L2pSZXVjRzFLWjBxQ2FnakQ1WWVBSllxdktleEN1OE0wY2NubXpOS3ZiZ0hX?=
 =?utf-8?B?NlJQQ1ZjWkM2eUdqcm8wQldxb1pDTCt1WGdISHdJTHJjLzRUWjZBU2EvRFZC?=
 =?utf-8?B?R3VFdDk1R2xUbzhySHE4Yi85WjlnNDkzUmI4RkN3WUphcURTVTRTUklCc2kv?=
 =?utf-8?B?bk1FY3JodUVQMHZYV0tyeUFQZnJoMkIzdDNqaldPOXJtNUZVNTVOVjROYU9y?=
 =?utf-8?B?UHVaR2F1SG5jYXJJeHhod2p6SDBSV3RvQkJJdm9pNDZWZlhnNmpZZkF4MnJo?=
 =?utf-8?B?OGwyYTR4b2NXeitGbGtIVVprUCt6Q1NnRW1NR1lqb2E5U0piRkdSVE41dHJ0?=
 =?utf-8?B?VnlkRndQd1BrWDM4aTgydk0rT3B1b0FXSi9WUVFLWkNEQTI4RWlsaUowcHBS?=
 =?utf-8?B?YXZwZ2xncUFocEJYbGZrcmkvMVFxRzlSbGZhQTdUQ05RSE1ObXBDYnVJUU9W?=
 =?utf-8?B?TEVLU3EyTUhBMmdXZ3ViajUzcUhGck1acGVZOUpoWVlVZVM2b2FaQUwvVGNr?=
 =?utf-8?B?dWRQK21UV0RubWFYRk0vcVdFWXRYY0FNSDB1N1h2ZG9HMDhxOUlISHFpVWVV?=
 =?utf-8?B?bmI4MkNZR0x5dzJVVlR4SVYraXBCRXhmYUFyc2M4elloSGsyQzZ5VkN2ZXhN?=
 =?utf-8?B?cmJmK1dGQzVkYWJKdUlQR2FGMlR4OXJibmZFZkNhTDVQQ2NCMnVDbk1iSmdR?=
 =?utf-8?B?OHlzeWFnN1J3VUg1SFR5SzE1UHJ6SkpLNGNrbU1uRmpYdE55ZVh3MkRueTFr?=
 =?utf-8?B?Y3U2S0NWZjFDMUc5Um5RaTlCb3NwQnJ4d25PY0d5aEJ3SW91VVN0VTc3eUo5?=
 =?utf-8?B?dmJOZ1lWN1FRby9PYnQvK0paSzZmMkduSGpyaWU5TFcrMEFjZDY3S3c4L3Fp?=
 =?utf-8?B?TTJ1MGkza3prdnQ0dHNGME9wK2EvY01rbGlsWloxY3ZCNWtQTlJQMjVPbE1L?=
 =?utf-8?B?Wk5jVGpNY3VIWVlXcUhnSGI4b3RNRjJ6T3NUSXBsVE4vZG1nTnpDdEx6R3Nk?=
 =?utf-8?B?Q3RjUjFUeU04bHRydEQ0dkl2OUd4RFlqMzg1dDdMZ1FaaXBYUTZMQjlFelZU?=
 =?utf-8?B?d0hRZjBXNjFydElnTDdZWDZzQVpKTitvcHYzbEJsd2J2VkhhaDBIc0NzS3FZ?=
 =?utf-8?B?bFJsdnBkMUZpR0NSbVN3OXBoUWhDQ1RmSFZSVThWZzhTbHIvRlVyeFIwUlZY?=
 =?utf-8?B?VVVZVnFTZGorUHJsaFhVMG9kaDN4S212ZlhhbzlyU0RaVE9sU3VsM0lZTWZr?=
 =?utf-8?B?Mi8yWFJKTHh5ZENJM2FVOTJOSWR3dkh0RVMyRm5WSWJtNUkzWUZYSlN3Sk9N?=
 =?utf-8?B?dXMrdGdOYVhrL2tnUzdoRkhQekozVmpTaDY3azdoWEwreU5oeEkyQlJPSzIw?=
 =?utf-8?B?ZGsvbGljby8rQzVkWW42K0pmL1BsdWF5VVdhbExXT1RGczNCUzlVZDQ1N3Nv?=
 =?utf-8?B?NG94VVNEMEYzWUdJR3ZtTnl2YjNvWjRqNmlCWlgxaWxhMSsyQ2VWRE9RU3FS?=
 =?utf-8?B?WHozdDcwK2FCcmNENTlrVFJkWUZMcmdhbVdqdzc2Y3NOYjgxVjluMG9qbEdC?=
 =?utf-8?B?T1dORldOTlVJRktyRW1EVmowOE0rR3UybkZSTEVBQkpnVy9ScFNHOTBTTWJF?=
 =?utf-8?B?d0Y4bnF2cWRDQ1hzajQ3c3VMaEo1SWlKb3NBQW9KYjVudU9ReUNQV09hdTZ1?=
 =?utf-8?B?RWk5UEdZbU14THkydWlRS0g1dlNnSjFpVnRYN0hRMTYxa040MDZlU1hObFBR?=
 =?utf-8?B?d0JPZXRDcTB5SFNtWlhPS2hycGxpMitBVGpaWDVJTjNHUm1qMjFNenhKdmp6?=
 =?utf-8?Q?PbnO1TjTCdYKy+TjCFDcFMs=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 858ff025-3c55-4768-61c5-08d9ef96983b
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2022 08:47:13.0765
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7wcBf8DmydeNrd1tKPyo5zXM7ilViCwE5715XyGeAi5oV0tzzIbeO7pLKU9uCmJjikfSCMnTBSlXRlMXWYkNNA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB6064
X-OriginatorOrg: citrix.com

On Mon, Feb 14, 2022 at 06:33:07AM +0000, Oleksandr Andrushchenko wrote:
> 
> 
> On 11.02.22 17:44, Roger Pau Monné wrote:
> > On Fri, Feb 11, 2022 at 12:13:38PM +0000, Oleksandr Andrushchenko wrote:
> >>
> >> On 11.02.22 13:40, Roger Pau Monné wrote:
> >>> On Fri, Feb 11, 2022 at 07:27:39AM +0000, Oleksandr Andrushchenko wrote:
> >>>> Hi, Roger!
> >>>>
> >>>> On 10.02.22 18:16, Roger Pau Monné wrote:
> >>>>> On Wed, Feb 09, 2022 at 03:36:27PM +0200, Oleksandr Andrushchenko wrote:
> >>>>>> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> >>>>>>
> >>>>>> Introduce a per-domain read/write lock to check whether vpci is present,
> >>>>>> so we are sure there are no accesses to the contents of the vpci struct
> >>>>>> if not. This lock can be used (and in a few cases is used right away)
> >>>>>> so that vpci removal can be performed while holding the lock in write
> >>>>>> mode. Previously such removal could race with vpci_read for example.
> >>>>> Sadly there's still a race in the usage of pci_get_pdev_by_domain wrt
> >>>>> pci_remove_device, and likely when vPCI gets also used in
> >>>>> {de}assign_device I think.
> >>>> Yes, this is indeed an issue, but I was not trying to solve it in
> >>>> context of vPCI locking yet. I think we should discuss how do
> >>>> we approach pdev locking, so I can create a patch for that.
> >>>> that being said, I would like not to solve pdev in  this patch yet
> >>>>
> >>>> ...I do understand we do want to avoid that, but at the moment
> >>>> a single reliable way for making sure pdev is alive seems to
> >>>> be pcidevs_lock....
> >>> I think we will need to make pcidevs_lock a rwlock and take it in read
> >>> mode for pci_get_pdev_by_domain.
> >>>
> >>> We didn't have this scenario before where PCI emulation is done in the
> >>> hypervisor, and hence the locking around those data structures has not
> >>> been designed for those use-cases.
> >> Yes, I do understand that.
> >> I hope pcidevs lock move to rwlock can be done as a separate
> >> patch. While this is not done, do you think we can proceed with
> >> vPCI series and pcidevs locking re-work being done after?
> > Ideally we would like to sort out the locking once and for all. I
> > would like to be sure that what we introduce now doesn't turn out to
> > interact badly when we decide to look at the pcidevs locking issue.
> Ok, so I'll start converting pcidevs into rwlock then

Sorry, maybe I didn't express myself correctly, since the current
series doesn't lead to a functional implementation of vPCI for domUs I
would be fine with postponing the locking work, as long as the
currently introduced code doesn't make it any worse or extend the
locking scheme into new paths, but maybe that's not very helpful.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Feb 14 08:53:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 08:53:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271229.465581 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJX6t-0005lO-3m; Mon, 14 Feb 2022 08:53:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271229.465581; Mon, 14 Feb 2022 08:53:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJX6t-0005lH-0G; Mon, 14 Feb 2022 08:53:27 +0000
Received: by outflank-mailman (input) for mailman id 271229;
 Mon, 14 Feb 2022 08:53:25 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=YsDI=S5=epam.com=prvs=4044e07e7c=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nJX6r-0005lB-HR
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 08:53:25 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 908e40a4-8d73-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 09:53:24 +0100 (CET)
Received: from pps.filterd (m0174678.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 21E8DtdU014749;
 Mon, 14 Feb 2022 08:53:17 GMT
Received: from eur03-ve1-obe.outbound.protection.outlook.com
 (mail-ve1eur03lp2057.outbound.protection.outlook.com [104.47.9.57])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e7kctg483-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Mon, 14 Feb 2022 08:53:17 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by VI1PR03MB6528.eurprd03.prod.outlook.com (2603:10a6:800:19f::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.15; Mon, 14 Feb
 2022 08:53:13 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::fc4d:4749:5d1:eb73]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::fc4d:4749:5d1:eb73%4]) with mapi id 15.20.4975.018; Mon, 14 Feb 2022
 08:53:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 908e40a4-8d73-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cWcDTqykrxxtcwp8YB3JWwRFed3NuKUgU4tL1YBkTb2dg/62Xg6qgOLNuEQtLMEa1XCUdm1yn8lrk62txwATKn1oDtw2qDqpyeECGnDunlhB1SneJ6BOsldMBaKuO9YhkfePqOZFxmNDQAGWK/qXnmXl7gW0LtWpGP9bB5HdAjPK1onKs+vYgVxfBaN0INlwGfb9Vf6DBtIWCrpRnLwes1zVlaOgE9gS24xH2KLdF1883LPMcOdQ5zwkFW50OGgTBbuzYYWbqIbqz7piIJd/zgLwqMb8GMzwDYID0zPKZr4D9FR1s9i5PlvO4WrN+a9pHy3+EzIHwDK2Cj4rUWdKfg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=BefIVjQcvlVTtlENzRPpwAwVSdTuSTWB3PHFzHO4qak=;
 b=OExCZxxHIj+LDfByvjkI+rmmAOUcd1R9jNZw/0hdkDbhX/MX2/Nu4vRY6247qGnb3JUS5He8M+2m2Y/GJCC0y2UOFDW/LYljEpkT/Yfsz9xB/1nauTScMsnqJcO9VrFy2ZfMZ34dvtX5RnchYWXaprON7nA47wTzrHr7pwTyBHoHqwde3BRZDMFXPZOJ1GsTIbGidtlnBqZ94YzLrxMNqFcCJDJYsbrvDlf4vQIGs79hoIzWnarK+6uFrD6hjwKW+/t28uW77VPJPobabcR7OMB1G4I7Fs1TuXRYktAtZQ9zmliZsBAJ/XBrWutwkd08QZztq6mRVfhQ2SvoditrPA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=BefIVjQcvlVTtlENzRPpwAwVSdTuSTWB3PHFzHO4qak=;
 b=F4HIURfoZ/N7VCHrly0mBAr5S6iMD2JS1GqtEW/bLRBjq9jLqZXGxefm9zxXJBe9OfXRqbV73+B5GgPANRwOmuI1nk9a5SQBPV0ZocS3maVbVMpZz+aNR3OB33XVX7h/ZM7/kBgPkaWXkdRGGb2w65eijaejp6r7nS9NR7ytHz4zwWCp7f+Sd7DrB3nYsX8UU1KbRfdC/RGTZdOSKcy3UYmC7NASrKo0gOJEhkBYuZqam63d/V1mA/TMCQSjJAHmy0A0UrYrveWtCcYtyQPe4gje0s4dDDTqYmOrMv6ziVCUkjH3XFLbAKAOEMvQKEYG3v4N4Z6WRz5jHq3ai1Pf4A==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "jbeulich@suse.com" <jbeulich@suse.com>,
        "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org" <sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH] vpci: introduce per-domain lock to protect vpci structure
Thread-Topic: [PATCH] vpci: introduce per-domain lock to protect vpci
 structure
Thread-Index: 
 AQHYHboQT3cBWYI1/EGunE7hOwop6ayM95MAgAD+qQCAAEaDAIAACWWAgAA6ygCABB0SgIAAJXCAgAABswA=
Date: Mon, 14 Feb 2022 08:53:13 +0000
Message-ID: <a5fc3216-123c-ab4e-49d0-f104fb49686d@epam.com>
References: <20220209133627.959649-1-andr2000@gmail.com>
 <YgU6Snk8GTytJXZp@Air-de-Roger>
 <c4666570-666e-6680-5ec2-adf1da51ad06@epam.com>
 <YgZLEMW9US9QjjYG@Air-de-Roger>
 <1dbd0f54-affb-1e67-215c-6e6c8fb8535b@epam.com>
 <YgaEQrqIEPc258Fy@Air-de-Roger>
 <6905d6ab-e435-fb65-2e93-446644b69b82@epam.com>
 <YgoXC8vJvsz4lwBM@Air-de-Roger>
In-Reply-To: <YgoXC8vJvsz4lwBM@Air-de-Roger>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 2e0c9cb9-29fd-4ab9-a05b-08d9ef976f13
x-ms-traffictypediagnostic: VI1PR03MB6528:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <VI1PR03MB65280883011EAB4C2C11C5A5E7339@VI1PR03MB6528.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 Ao2B1hP/ROLxHhxMIx05lan14eV7o01qmGxYMUcjgGbzbodBMySCPVla2QhAIQJjOiufz5c7YIeIJimc5RctN41eDHTZnVxAxwPAyKPWIhs3S+SvcR3pnpenVQJO3AVmUjm2oYB1YK4p8PtarJE9KCTYBVVAV3eBOUKyqwIWvDfQc3MZc5F83l0b7oHdXLOXWQmsFvMal4aErlWPiXpYCUZCAlMZmVhCiJnIYWWaHms7cnYm/aNOl/bI+iFdFzJGcVHFBDCIBiX7vzL9lnUsrhQwdGlIQtq3ktP4zekS3meoSRohxNH5pZwwnB70nSFsciUu5eRsg0d6lBMpIvSIJLIxZQo0wv132sQfcf11x+J4ialGdrMnvqlrq41Ywoi8ouKtomevAr/DxV+8sA/47LTOTJS849SGEQizYp/l13sAUwVxoIu7lqkVLraYjejnWFI1L50IbN+C4LfbcSZ1v1ubpgCUrsUpR3OGpmrDF1HC1UdPOWKVTwDuDGm0ewwyFLzTd1Povg3oD1s0LakqxCk9KbF+kl9YMYWHhOXeeTUtXbtfncgZXFFchUf6PHgnXkJUDHFGXLS7u5ToD4f9Lcdcb6RxWVIz0JNmb6MngMG9e5vPXB87AlHEX9fFPbjnDMVRAIW2ttI9AUORRNMG9tEJVroOh26A9RPo+q6lDXyYtNWErC4EB43z9+FzIEJ+Pd3EE1qjEETuzCNt3N/9iB/qThjvu+vlQOjgLjlF6UrPQaqo3yUvgnS3dQUzbz7+
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(64756008)(86362001)(38070700005)(31696002)(122000001)(38100700002)(8676002)(76116006)(66446008)(66556008)(66476007)(4326008)(66946007)(6916009)(54906003)(316002)(91956017)(8936002)(5660300002)(2906002)(2616005)(53546011)(107886003)(186003)(26005)(83380400001)(508600001)(6486002)(55236004)(71200400001)(31686004)(36756003)(6512007)(6506007)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?NDZyVnR0RWNZekR4RTIzV2pKbXl1NXFoTUVvQTFxbXVOU2NJNmozdE8yaFlE?=
 =?utf-8?B?SlZ2R2lYK0tybmtLMmtuR0RXMmVVTHBEU2ZmTkV0Zk42RndaSEZOOStsdUtS?=
 =?utf-8?B?b28wNzkzZ1hpb2J1VkRIWkZNZGlUS0NjallUUCtvQ1hjUjQwbzNyWEVMS0lS?=
 =?utf-8?B?cmwzd3RTcU0zQ3V3Sk9na2UyRFdQMnFiRnpDc1lFL2k1MkJnU3Z6SUtzQUFK?=
 =?utf-8?B?Vm9QdG9paDVSb256dy9IWnF2c0MvelFsODdDemtRRmdCMCtiM2VjU2JkQ2pC?=
 =?utf-8?B?bVNXTkZRWHljMXpDQUU3VkZvcVVYaEwwTUllRTNBbTJrQ3NLdTdqVm5teHJG?=
 =?utf-8?B?Wi9vN0JxbHpQTlFWR2pDbEVaQXFibWZEdWNjbVV2cEpBTVp2MmYvZXNmUEln?=
 =?utf-8?B?cFRaUmNORUh5SjlDMUt0VUNsbGJ6M1pVQ0xBVEtDcjA3MkZHNGJ3d2lhVGpW?=
 =?utf-8?B?QmpKd01pMVFLOUJKNGE3ZTA1VGo1TVZBd1QyRjUvd1BlaG5nWjhtbzRCdHlM?=
 =?utf-8?B?UTQ3K0lNamN2TUdWMTBjN213WDZTVEtUZmNPbUxtdWoyLy9FNWl3SmpjNjVL?=
 =?utf-8?B?eXVvenU3UXVjOVAvTVVVN1pxOXJMRFYwMVpENnhvbHRoQ0p5MWRFNHQwVGV5?=
 =?utf-8?B?N0NocUVZY2ZTM1lGd1JwRmV4R0VBMEpxUkM1alo5RnRTenR1YUNIbXl3MWNF?=
 =?utf-8?B?MUU5bzhQU0MvT3hFSG5mcnZvYzlQRHA1UFlUSEFwb2xTd0VmamZQSTdHcUsr?=
 =?utf-8?B?dHM2c3VFYWlIWkk0WGJpNlJvS2QwVTlqNGRMTGtGYVdEUThyaHBpN1BPUjRw?=
 =?utf-8?B?Y1hYRVdoQ3FvV1lFK3dMeDQ1NGI3WkxNc0E5MlJpWHJESmx4d2JKV1BwejVn?=
 =?utf-8?B?bVlJU1loTUNoUVptMDN5emxWbXBmbUhFZGFBYVlxdGJ5dTNUYS90OVpVUWRK?=
 =?utf-8?B?V1p6TGZFTlVxSVVQSUZ3ZkNEaWszU3NkM3d4NFh2YnZDaWRmSU5sVHk0cDdt?=
 =?utf-8?B?R3JaQWU5V2VUZDhsVXUwVDVzcjY4SzNWQmFoWXdFblVHSUJOa2xRSVlWWFVa?=
 =?utf-8?B?N0NleWRURWc3S0ZSaHd1OVhwdWFqeTdXQXRsWUIrdzgvL0MxUWxFR0ZiRHAy?=
 =?utf-8?B?UmR0VHRJT3lrTjVyS2lZbFVtbi9hM3drWnByYXNRVEIwY2sxNmNRTm9nNVk1?=
 =?utf-8?B?NmI3Z1hTL2pad3h4bEx0T3hhZTVJay80WEZKNzg4b2thOGNvejlHb1pWVy82?=
 =?utf-8?B?QVl6bzVFUlg0cStaa1VzTkZEaHNhcFBBVTF0M3dFVERCYlM0dDdZcWt3bGVG?=
 =?utf-8?B?c0RKOVBaQW9JVTVpbjIvMXFQRUdrQ3NKRmdQT2wxakNEYWpVNnNPSTUveFJz?=
 =?utf-8?B?ZFNzVWFuYVd6eUFqdEN0T082MWJMNzZKa2E1RmFsbERRWDIxaE1pQ3BSc3Q0?=
 =?utf-8?B?amhvS25SdTlSenVFMjFsQUdWMkUzV0pmcDZlazdLQ1AxZ1kxT3E0bVlhc1I1?=
 =?utf-8?B?S2tvQUpTSG9xblRFNEJXem9oakhHS2doKyt2Q0cxY05NTi9KYkdOWWJPZGk1?=
 =?utf-8?B?UzRNWkpiUjBFUXR2dzRsd1RoeG5vamVyM0V3MjB3ZmtycGJZTmV4MWNzZVhG?=
 =?utf-8?B?YUk2aXRxRElOaU5nRWI1ZU1rUVBIRExDUHBla1RXdjBVek5BVnVjTGhQRXl3?=
 =?utf-8?B?UEUvWS9lazFOU0ZSTTNpVEZDK1NTQWdBWUE2dHVwdm1IVkwyREFDNUsrVHBm?=
 =?utf-8?B?ZTVWV2VhNUdYZHU3U1FNT0hmbVlCV3pka2lwcnJWWVM0UnRma3JWcGd5RE9B?=
 =?utf-8?B?ak9PODFpKzNFT0VRZkxlZEpLVHZSVVdnMzE2MUxKWHZQNUNXak00SVBWdEJa?=
 =?utf-8?B?L2xVR1U3QXhPaHZFN1Q1ckdqMk1VUkxOVVdGU25nQkJzQkVJSktkQzVRY0Rs?=
 =?utf-8?B?QTFXMFVqSEdkQzFTZGx4Rnh5dnNDVng1aXoxZ3hqUGdXV0Y4a3FtNTBJNHp5?=
 =?utf-8?B?aHMvalpYczkzYSthcDdlOXJia2ZUSjlpMTYwTVYvcnNWTnMyQzhoaW1sNDlK?=
 =?utf-8?B?VlhTMFNGRU05dzBSOWlvNW5udGk4eDlwVlVnLzBPZUVidzcranRoSVRkVTRS?=
 =?utf-8?B?ekQzYmNWaktMQUM0M0puSkRwMEoxWjk5R0RkZjUzekw5aThIb3FySFM1S3pP?=
 =?utf-8?B?elU2U1RhRk5jTkRxejFrNE53V2JEeVZ2VkkyeWVmaGo3cHUrV1dhN284U0NW?=
 =?utf-8?B?c2dnZEk2UldTOVdRdTVQbzJ2aHZseWpDTjNrZEE2ZGxMRHBnVUNoZ0RIcGhF?=
 =?utf-8?B?Zzh6Y0NoaTRGd2lLVGMwMHk0bnVDV1dneDZDbmN3M24raTFHMXUwZz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <96D793DBFEDA8746BD1123B81510C54B@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2e0c9cb9-29fd-4ab9-a05b-08d9ef976f13
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Feb 2022 08:53:13.1355
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: IR8gd5raoVTXKUwQI7ZbsccOr72jZCMH6AZauL90JGWThxTbu61R4GNMMxx/yubS8iV18LMI8wPDgfzQIB3U9V5QgCxCvlauZDGyuA+amI58TpYSpWqLY3Aq/BT58Ji7
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR03MB6528
X-Proofpoint-GUID: JuBgX6d7SnQrd0HdiUMG0Bb_hMxqYaSp
X-Proofpoint-ORIG-GUID: JuBgX6d7SnQrd0HdiUMG0Bb_hMxqYaSp
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-14_01,2022-02-14_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0
 mlxlogscore=999 impostorscore=0 malwarescore=0 phishscore=0 bulkscore=0
 clxscore=1015 adultscore=0 mlxscore=0 spamscore=0 priorityscore=1501
 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202140054

DQoNCk9uIDE0LjAyLjIyIDEwOjQ3LCBSb2dlciBQYXUgTW9ubsOpIHdyb3RlOg0KPiBPbiBNb24s
IEZlYiAxNCwgMjAyMiBhdCAwNjozMzowN0FNICswMDAwLCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5r
byB3cm90ZToNCj4+DQo+PiBPbiAxMS4wMi4yMiAxNzo0NCwgUm9nZXIgUGF1IE1vbm7DqSB3cm90
ZToNCj4+PiBPbiBGcmksIEZlYiAxMSwgMjAyMiBhdCAxMjoxMzozOFBNICswMDAwLCBPbGVrc2Fu
ZHIgQW5kcnVzaGNoZW5rbyB3cm90ZToNCj4+Pj4gT24gMTEuMDIuMjIgMTM6NDAsIFJvZ2VyIFBh
dSBNb25uw6kgd3JvdGU6DQo+Pj4+PiBPbiBGcmksIEZlYiAxMSwgMjAyMiBhdCAwNzoyNzozOUFN
ICswMDAwLCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyB3cm90ZToNCj4+Pj4+PiBIaSwgUm9nZXIh
DQo+Pj4+Pj4NCj4+Pj4+PiBPbiAxMC4wMi4yMiAxODoxNiwgUm9nZXIgUGF1IE1vbm7DqSB3cm90
ZToNCj4+Pj4+Pj4gT24gV2VkLCBGZWIgMDksIDIwMjIgYXQgMDM6MzY6MjdQTSArMDIwMCwgT2xl
a3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+Pj4+Pj4+PiBGcm9tOiBPbGVrc2FuZHIgQW5k
cnVzaGNoZW5rbyA8b2xla3NhbmRyX2FuZHJ1c2hjaGVua29AZXBhbS5jb20+DQo+Pj4+Pj4+Pg0K
Pj4+Pj4+Pj4gSW50cm9kdWNlIGEgcGVyLWRvbWFpbiByZWFkL3dyaXRlIGxvY2sgdG8gY2hlY2sg
d2hldGhlciB2cGNpIGlzIHByZXNlbnQsDQo+Pj4+Pj4+PiBzbyB3ZSBhcmUgc3VyZSB0aGVyZSBh
cmUgbm8gYWNjZXNzZXMgdG8gdGhlIGNvbnRlbnRzIG9mIHRoZSB2cGNpIHN0cnVjdA0KPj4+Pj4+
Pj4gaWYgbm90LiBUaGlzIGxvY2sgY2FuIGJlIHVzZWQgKGFuZCBpbiBhIGZldyBjYXNlcyBpcyB1
c2VkIHJpZ2h0IGF3YXkpDQo+Pj4+Pj4+PiBzbyB0aGF0IHZwY2kgcmVtb3ZhbCBjYW4gYmUgcGVy
Zm9ybWVkIHdoaWxlIGhvbGRpbmcgdGhlIGxvY2sgaW4gd3JpdGUNCj4+Pj4+Pj4+IG1vZGUuIFBy
ZXZpb3VzbHkgc3VjaCByZW1vdmFsIGNvdWxkIHJhY2Ugd2l0aCB2cGNpX3JlYWQgZm9yIGV4YW1w
bGUuDQo+Pj4+Pj4+IFNhZGx5IHRoZXJlJ3Mgc3RpbGwgYSByYWNlIGluIHRoZSB1c2FnZSBvZiBw
Y2lfZ2V0X3BkZXZfYnlfZG9tYWluIHdydA0KPj4+Pj4+PiBwY2lfcmVtb3ZlX2RldmljZSwgYW5k
IGxpa2VseSB3aGVuIHZQQ0kgZ2V0cyBhbHNvIHVzZWQgaW4NCj4+Pj4+Pj4ge2RlfWFzc2lnbl9k
ZXZpY2UgSSB0aGluay4NCj4+Pj4+PiBZZXMsIHRoaXMgaXMgaW5kZWVkIGFuIGlzc3VlLCBidXQg
SSB3YXMgbm90IHRyeWluZyB0byBzb2x2ZSBpdCBpbg0KPj4+Pj4+IGNvbnRleHQgb2YgdlBDSSBs
b2NraW5nIHlldC4gSSB0aGluayB3ZSBzaG91bGQgZGlzY3VzcyBob3cgZG8NCj4+Pj4+PiB3ZSBh
cHByb2FjaCBwZGV2IGxvY2tpbmcsIHNvIEkgY2FuIGNyZWF0ZSBhIHBhdGNoIGZvciB0aGF0Lg0K
Pj4+Pj4+IHRoYXQgYmVpbmcgc2FpZCwgSSB3b3VsZCBsaWtlIG5vdCB0byBzb2x2ZSBwZGV2IGlu
wqAgdGhpcyBwYXRjaCB5ZXQNCj4+Pj4+Pg0KPj4+Pj4+IC4uLkkgZG8gdW5kZXJzdGFuZCB3ZSBk
byB3YW50IHRvIGF2b2lkIHRoYXQsIGJ1dCBhdCB0aGUgbW9tZW50DQo+Pj4+Pj4gYSBzaW5nbGUg
cmVsaWFibGUgd2F5IGZvciBtYWtpbmcgc3VyZSBwZGV2IGlzIGFsaXZlIHNlZW1zIHRvDQo+Pj4+
Pj4gYmUgcGNpZGV2c19sb2NrLi4uLg0KPj4+Pj4gSSB0aGluayB3ZSB3aWxsIG5lZWQgdG8gbWFr
ZSBwY2lkZXZzX2xvY2sgYSByd2xvY2sgYW5kIHRha2UgaXQgaW4gcmVhZA0KPj4+Pj4gbW9kZSBm
b3IgcGNpX2dldF9wZGV2X2J5X2RvbWFpbi4NCj4+Pj4+DQo+Pj4+PiBXZSBkaWRuJ3QgaGF2ZSB0
aGlzIHNjZW5hcmlvIGJlZm9yZSB3aGVyZSBQQ0kgZW11bGF0aW9uIGlzIGRvbmUgaW4gdGhlDQo+
Pj4+PiBoeXBlcnZpc29yLCBhbmQgaGVuY2UgdGhlIGxvY2tpbmcgYXJvdW5kIHRob3NlIGRhdGEg
c3RydWN0dXJlcyBoYXMgbm90DQo+Pj4+PiBiZWVuIGRlc2lnbmVkIGZvciB0aG9zZSB1c2UtY2Fz
ZXMuDQo+Pj4+IFllcywgSSBkbyB1bmRlcnN0YW5kIHRoYXQuDQo+Pj4+IEkgaG9wZSBwY2lkZXZz
IGxvY2sgbW92ZSB0byByd2xvY2sgY2FuIGJlIGRvbmUgYXMgYSBzZXBhcmF0ZQ0KPj4+PiBwYXRj
aC4gV2hpbGUgdGhpcyBpcyBub3QgZG9uZSwgZG8geW91IHRoaW5rIHdlIGNhbiBwcm9jZWVkIHdp
dGgNCj4+Pj4gdlBDSSBzZXJpZXMgYW5kIHBjaWRldnMgbG9ja2luZyByZS13b3JrIGJlaW5nIGRv
bmUgYWZ0ZXI/DQo+Pj4gSWRlYWxseSB3ZSB3b3VsZCBsaWtlIHRvIHNvcnQgb3V0IHRoZSBsb2Nr
aW5nIG9uY2UgYW5kIGZvciBhbGwuIEkNCj4+PiB3b3VsZCBsaWtlIHRvIGJlIHN1cmUgdGhhdCB3
aGF0IHdlIGludHJvZHVjZSBub3cgZG9lc24ndCB0dXJuIG91dCB0bw0KPj4+IGludGVyYWN0IGJh
ZGx5IHdoZW4gd2UgZGVjaWRlIHRvIGxvb2sgYXQgdGhlIHBjaWRldnMgbG9ja2luZyBpc3N1ZS4N
Cj4+IE9rLCBzbyBJJ2xsIHN0YXJ0IGNvbnZlcnRpbmcgcGNpZGV2cyBpbnRvIHJ3bG9jayB0aGVu
DQo+IFNvcnJ5LCBtYXliZSBJIGRpZG4ndCBleHByZXNzIG15c2VsZiBjb3JyZWN0bHksIHNpbmNl
IHRoZSBjdXJyZW50DQo+IHNlcmllcyBkb2Vzbid0IGxlYWQgdG8gYSBmdW5jdGlvbmFsIGltcGxl
bWVudGF0aW9uIG9mIHZQQ0kgZm9yIGRvbVVzIEkNCj4gd291bGQgYmUgZmluZSB3aXRoIHBvc3Rw
b25pbmcgdGhlIGxvY2tpbmcgd29yaywgYXMgbG9uZyBhcyB0aGUNCj4gY3VycmVudGx5IGludHJv
ZHVjZWQgY29kZSBkb2Vzbid0IG1ha2UgaXQgYW55IHdvcnNlIG9yIGV4dGVuZCB0aGUNCj4gbG9j
a2luZyBzY2hlbWUgaW50byBuZXcgcGF0aHMsIGJ1dCBtYXliZSB0aGF0J3Mgbm90IHZlcnkgaGVs
cGZ1bC4NCkluZGVlZCwgSSBtaXN1bmRlcnN0b29kIHlvdSBwcm9iYWJseS4gR3JlYXQsIHNvIHdl
IGNhbiBjb250aW51ZQ0Kd29ya2luZyBvbiB0aGUgdlBDSSBzZXJpZXMgd2hpY2ggd2hlbiBhY2Nl
cHRlZCB3aWxsIHVuYmxvY2sNCk1TSS9NU0ktWCB3b3JrIHdoaWNoIGRlcGVuZHMgb24gdlBDSS4g
VGhlbiwgaW4gcGFyYWxsZWwgd2l0aCBNU0lzLA0Kd2UgY2FuIHN0YXJ0IHJlLXdvcmtpbmcgcGNp
ZGV2cyBsb2NraW5nLg0KPg0KPiBUaGFua3MsIFJvZ2VyLg0KVGhhbmsgeW91LA0KT2xla3NhbmRy


From xen-devel-bounces@lists.xenproject.org Mon Feb 14 08:56:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 08:56:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271238.465592 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJX9y-0006Qs-LL; Mon, 14 Feb 2022 08:56:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271238.465592; Mon, 14 Feb 2022 08:56:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJX9y-0006Ql-IA; Mon, 14 Feb 2022 08:56:38 +0000
Received: by outflank-mailman (input) for mailman id 271238;
 Mon, 14 Feb 2022 08:56:37 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KkXt=S5=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nJX9x-0006Qf-DU
 for xen-devel@lists.xen.org; Mon, 14 Feb 2022 08:56:37 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 00fa70eb-8d74-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 09:56:32 +0100 (CET)
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur03lp2059.outbound.protection.outlook.com [104.47.9.59]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-41--E9HlSLbPs-w55SFsBq-6Q-1; Mon, 14 Feb 2022 09:56:33 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4352.eurprd04.prod.outlook.com (2603:10a6:803:4a::25)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Mon, 14 Feb
 2022 08:56:33 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4975.015; Mon, 14 Feb 2022
 08:56:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 00fa70eb-8d74-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644828995;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=nmcLXdKCZh2RrIZlwlMXZjoH+JRYIYQEMFj87H/mvMU=;
	b=H+8ayhugkRFTCGKL2sR3mqyMCTdFfQ4oMTSQFQ0jUvenINQnhB/4vpWATHDe0Eae3tuaIb
	0jnoZDPkae/NSRFyT5E3cK5ABNOn5r4CLo90BEusJz9dKQ2T/3r3SDVfOg2TlezWvNqraj
	b2DRUz8AUSXRZhSDl6Ol1QUj7vCWQ0c=
X-MC-Unique: -E9HlSLbPs-w55SFsBq-6Q-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=JSGZjnLoa6J37+f1/13hkjimeVkBuFSmtjdcf+eKPvAC7ostLXN9oxc2ZAGxsZ20gj//YzQSvBRFS60SH0gIcv6gRIrZrbsfds4zG6eLhrYI1AU1vtD1HJzZhCJFTpiS5/LXiBpDGyBidLXKNIotv+/eQZKLHM6GSgFFcK1iN7EuXn6Xu/WH+TEWL4exfLXRB31mbkvNgi3pwqY8kfoDO/CUWmSB2eoDj/jz2RPxCLxdFrmAddZbPZ8GF/4feBAeCyltz974nec3nepusLPqX6K8QJWFdiMlzkJjOJDM87R1OzP21E2Sd0q6lZPb36x+YF7HG4tFRSY21bdbU+if7A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=nmcLXdKCZh2RrIZlwlMXZjoH+JRYIYQEMFj87H/mvMU=;
 b=BW0gfoO1XvBiiZZzsm4Dfs07rfJR1gRwoiQEWZ8b8AyxjefAlHpnhhWv8aFn4wd7Wb/NDINRFxgni1cFq1DmdWZAno99a3a3Pwepkp4nXgCHi1sJXFrtICbLcgYUuDf8J2uHWRxxsrYtIht3IsHyu710CYZWRErbnqhE3FmpByZTHuEDQ9THq6KcF3qfS2GPzUm2II5jTPp23Eg3PqtPI0wRR6ZeR3G509JMoJg5wSn+oEwfnYfXnC8LPBOr33e5MQsNxADZL3VXoZJA3xdqvgaCjFFg4NC9O0w+KblGPN9ISm+Gkf9752mbkzBjGZIZ7GsrmrgZK3q3pf33lwsb+g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <198ef291-4dee-ddac-aef6-8451bc1e880c@suse.com>
Date: Mon, 14 Feb 2022 09:56:34 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: IGD pass-through failures since 4.10.
Content-Language: en-US
To: "Dr. Greg" <greg@enjellic.com>
References: <20220214060011.GA24404@wind.enjellic.com>
Cc: xen-devel@lists.xen.org
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220214060011.GA24404@wind.enjellic.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR0P281CA0054.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:48::16) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9ad2a51e-3de4-4124-5460-08d9ef97e5fa
X-MS-TrafficTypeDiagnostic: VI1PR04MB4352:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB4352E9E7A43CAD6B44686665B3339@VI1PR04MB4352.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	8evDbwQg6fp43OS0Zatqc6PJd0fhVOQ02EjnPrQAJn2kAqTBVCVUAELJ7fiyI4UACd7ReXxlEchsfQAA09z+PyaytxWhFhyK6ui2dk4wbXrXD/zTY4IVD3ioUfBSO3b5vYW0hsz6k43wgpbV9b1vLtyCtB9bd2tf/Ti6jUHzSFXWvHcDnfXmj2SVipbT5CMzRZJUpf1wD2Hm1MF8DSIg7c6PLXQQenSwc3pPEeQnEIIae6VVelYQ9+HHMZqQEq2Ddbu65ZRnLQzW2O2W11txp8e82F6ipWjq7fjAThmSxeucbXSf+E6CSjaKBISSbda/C6oW/7+QuAW6cr/MC+fS7OGhrNgGLIeStDD7DZH/X9+kQkR2ehhBtsTXUEl2gIcOVA+FhnfZlc9yQbghDH93PwwBWEbpwMilCrshe68mPwFWVy47h0G/0lCQF0x/cJEdU2jR/G6BXsapIDaXNviZExdoX73mLBCrIGvpmmqRHfdorFAXncppDZgQuXBGOtD7GTSXY4ckunjbHgeB6E8xt5pQ2GlF2/Uw6s4IEsECFTBV+qS4XdJIawcAZMyxOF1YTXSDb2QZgsI2WhMrl867WcHFS3UjZSvV7cpw3iWBLZOYnNxtGLqQogWii7n37oLRofkmOHNbxj9AzJYtOABxsX8YhgKnPhoSk+rL1zu76BXcS0c1BuOMDvAf7aiLrIxnUmARCKXOZv30BNcV4QWc3gezJoZ3hbpvjwRb30itB1k=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6512007)(6916009)(36756003)(316002)(86362001)(53546011)(2616005)(508600001)(31686004)(6486002)(186003)(26005)(31696002)(40140700001)(6506007)(66556008)(5660300002)(66476007)(4326008)(66946007)(8676002)(8936002)(38100700002)(2906002)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?blp4SUYrUjR4enNZS21YUFJJYVEwYVo2ZE96b0xYTlRHQy9mZTZ1Q2hSbGNH?=
 =?utf-8?B?d3FjcmovQXdyL2dIRHkrODVLSklPTVZwWU13SGpDRVVFT3JrWnFteG5IV2hZ?=
 =?utf-8?B?UTZiRzk2S1JQZFlCclRLOGRVRzFYQWFFMkJVTWI0Q3d1a09DTWNPS0FERTRu?=
 =?utf-8?B?dFdhYmdkcWpKYTdKWE5Sci9kc1pIV0lNanNmYjQwT2ZjQjJNQWJ1TXNqWVhm?=
 =?utf-8?B?ZHVaQXcyTEx3NXBnbGJCRTRQZDV2TmxLYU5vQTkwMmRDWGRXNVd3TW9nZ29z?=
 =?utf-8?B?SkxrN3R0eVlmQ3JyVU9wcDFqQzRKcGdPZjk1Y2pFU1hSU1FtZFd2d3lTejhB?=
 =?utf-8?B?MTlyYjgwY2Q3TXlRdUNxVm5xM25lNGJCSnY4SjlIb1hoaHIxNEo5M3lHM0E2?=
 =?utf-8?B?VXM0ZVNXQkRBaWVjRVkvbW9PRWxLMHdhRWxoTmsvYTE3REFBN1pBcGdrK1RK?=
 =?utf-8?B?Y0hzdWJSYU5HMW9JSUdSWXJTSm9pczVaRXJTZlN0ZXN5TnBwcjd2d0NhUEFG?=
 =?utf-8?B?MXQ3VEovRFNiaGdZaldFSHVzQVNvUXcwZEtyd0VPMlgyYXlrNGloMEsxMTZ0?=
 =?utf-8?B?cVAramZRclROL2xZQVNwNFdybm5GeUZYdEpIVlJrRisxTzlCdGxGUDk3THdz?=
 =?utf-8?B?eVV5dFV3eDJKdGNabGZQR25BVHFDMEpobVNOemx0NkpBWGRIWndvWnMxY2Z4?=
 =?utf-8?B?dlU4QlZ6WEVYcEorQUdiT0kzR3k3ZWYvOW9MYjZlczR1b09JVEtsM0hvMVI5?=
 =?utf-8?B?bDBYWG1OcUkvOEppQ3RWalArdHhoOTYyQ2VtSmZwaE0vTGdiWkJEUE9WVnNh?=
 =?utf-8?B?Tk5DQWNPbGxDLzM2YXY0TG1menQxanZtZ3d3Y2ZpVFhMRDZCMVFlN1J5SzlZ?=
 =?utf-8?B?SzhkUmVHNE00TytnNGhVcktGS05CTG9WY01JdUZPY2tTcnoxekRPeEVZL0Y1?=
 =?utf-8?B?Sk1jWnJaZDdTM2ZmN1FsL0dOTDNqNHhENWNyMzE0RVd1ZUFOeW5MaGtOMzhB?=
 =?utf-8?B?OFFNazlsNmFiMmRwRTk2ZTVoVEc0a3pXTkVwd0dnRGF4Z0t4YjNtb2pLZ2hF?=
 =?utf-8?B?S3JMV2JXc2U5d3BGN2RFOWVaZW81TVVIWm1TT0R2TEZTRzVkaWhGZkZQM2Y2?=
 =?utf-8?B?ZVROQ1FDUWlsM1IxNE9IY1NzdkovWTdWNVoyOW5mYjlYdkdkUGg3VVhrc3J2?=
 =?utf-8?B?cjI2TmQ0US90TkJjQnZ1Nk5LZlhmYm9ULzU4NzlhUGh5U0Q3cDlpclBONkIr?=
 =?utf-8?B?MFVlYTFQR1VTMlF4UHlnVktDNWNhek5GbVFwSTdsdm53ZEtRVzNqdC9rUUZT?=
 =?utf-8?B?SzJOelhySVZOUzE4VlVMaW15TXJCL3pZYkV0RjNjaGhqZW5sS1JEUXAvd0V5?=
 =?utf-8?B?ZHBuMHRlQlF4MlB1aHRvQUo5a3NIUjV4NUtLQlYvcHRiTllhWUQ4R1hjRUZG?=
 =?utf-8?B?NERCR3RuU2xteU9idFR1NG1rVHZpWS9GZGRvZlcwUFNYc1ZsaERIZ2hYRW1D?=
 =?utf-8?B?Sm01bFJsQ0NHY3A5OC9Jb0kwcmxIQVNrT3NSVjBzRFQ1S1Baa2pjTFlWL1E0?=
 =?utf-8?B?NTF1NDlmdkVBMkpYN3hRMXZLTTRSZnBjTHo2TTNybGoxcVNGcEpVZzU1a1pm?=
 =?utf-8?B?TEZHRUl5bmN3VFdGSmIvcCtXcWc5WXFTNC9XbGtCYUlFanNmWVV2bkxJQm5J?=
 =?utf-8?B?R2hsYVVoa3MwRXZ5U2ZEVnJaTklURzlJYUoweGZxZGJEZUt0aGNaL3NDcFB4?=
 =?utf-8?B?RmdKNjNqaW15M2FrNmlFdHdJZk5QT0dvR1Y4SURqOTJKM1BKY1dEVG96djFm?=
 =?utf-8?B?QUlEa1BhY05Oc0xUNEdFNnFvdG5CMXdIVXRxVjMyaTBSeVFPZWdGdWVrNWt1?=
 =?utf-8?B?Sm1pZEZFM29iclpzNG9PVDZvS3kyK0ZUc20vci9ya1ZzbXRxK0hibTZyU1Vo?=
 =?utf-8?B?ZlRpZFhqMFZnV2VSR2xUTU5KaVcrTEJ0OEQ4SEZSL2NwalZiVnpDalZGY1lq?=
 =?utf-8?B?cjR5U05TM0pJVndtRDdaYzF6Mys5TnNpR1k4RGMvMWFJb0RjMFdUOGFjc2JY?=
 =?utf-8?B?Tll3VlBaSFpHUWE4UE9RSEUzZG1XZ1NnZjhzdnY0MGU1VEtaZHZ1OUwvT1dL?=
 =?utf-8?B?UUVhRXc2SlUyZFhqSlFHUm1pMGpIV3Q5NzcyOVdKSzY5K1pNTnBDa2Z5ODhK?=
 =?utf-8?Q?uOlh+6MDsCDHjbwcYPwUoj8=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9ad2a51e-3de4-4124-5460-08d9ef97e5fa
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2022 08:56:32.8530
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jadD8QXT3VT58xXcYUGZ5QfNYJMPDgYFQeiRIOaqErnZtcWnsW8pYOHiuoa3xAobuc1wKWe/N6O9NlSFiulS0A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4352

On 14.02.2022 07:00, Dr. Greg wrote:
> Good morning, I hope the week is starting well for everyone.
> 
> We've made extensive use of PCI based graphics pass through for many
> years, since around Xen 4.2.  In fact, we maintained a set of patches
> for ATI cards against qemu-traditional that have seen a lot of
> downloads from our FTP site.
> 
> We ended up switching to IGD based graphics a couple of years ago and
> built a stack on top of Xen 4.10 using qemu-traditional.  That
> coincided with our transition from Windows 7 to Windows 10.
> 
> We've never enjoyed anywhere near the stability with IGD/Windows-10
> that we had with the ATI/Windows-7 desktops, ie. we see fairly
> frequent crashes, lockups, reduced performance etc.  The ATI/Windows-y
> desktops were almost astonishingly reliable, ie. hundreds of
> consecutive Windows VM boot/passthrough cycles.
> 
> In order to try and address this issue we set out to upgrade our
> workstation infrastructure.  Unfortunately we haven't found anything
> that has worked post 4.10.
> 
> To be precise, 4.11 with qemu-traditional works, but upon exit from
> the virtual machine, to which the graphics adapter and USB controller
> are passed through to, both the USB controller and the graphics
> controller cannot be re-initialized and re-attached to the Dom0
> instance.
> 
> It appears to be a problem with mapping interrupts back to dom0 given
> that we see the following:
> 
> Feb 10 08:16:05 hostname kernel: xhci_hcd 0000:00:14.0: xen map irq failed -19 for 32752 domain
> 
> Feb 10 08:16:05 hostname kernel: i915 0000:00:02.0: xen map irq failed -19 for 32752 domain
> 
> Feb 10 08:16:12 hostname kernel: xhci_hcd 0000:00:14.0: Error while assigning device slot ID

Just on this one aspect: It depends a lot what precisely you've used as
4.10 before. Was this the plain 4.10.4 release, or did you track the
stable branch, accumulating security fixes? In the former case I would
suspect device quarantining to get getting in your way. In which case
it would be relevant to know what exactly "re-attach to the Dom0" means
in your case.

Which brings me to this more general remark: What you describe sounds
like a number of possibly independent problems. I'm afraid it'll be
difficult for anyone to help without you drilling further down into
what lower level operations are actually causing trouble. It also feels
as if things may have ended up working for you on 4.10 just by chance.

I'm sorry that I'm not really of any help here,
Jan

> At which point the monitor has green and block bars on it and the USB
> controller doesn't function.
> 
> Upstream QEMU doesn't work at all, the qemu-system-i386 process fails
> and is caught by xl and then tries to re-start the domain, which
> remains dead to the world and has to be destroyed.
> 
> We revved up to the most current 4.14.x release, but that acts exactly
> the same way that 4.11.x does.  We've built up the most recent 4.15.x
> release, so that we would be testing the most current release that
> still supports qemu-traditional, but haven't been able to get the
> testing done yet.  Given our current experiences, I would be surpised
> if it would work.
> 
> We've tentatively tracked the poor Windows 10 performance down to the
> hypervisor emitting hundreds of thousands of IOMMU/DMA violations.  We
> made those go away by disabling the IGD IOMMU but that doesn't fix the
> problem with upstream QEMU being able to boot the Windows instance,
> nor does it fix the problem with remapping the device interrupts back
> to Dom0 on domain exit.
> 
> The 4.10 based stack had been running with 16 GIG of memory in the
> DomU Windows instances.  Based on some online comments, we tested
> guests with 4 GIG of RAM but that doesn't impact the issues we are
> seeing.
> 
> We've tested with the most recent 5.4 and 5.10 Linux kernels but the
> Dom0 kernel version doesn't seem to have any impact on the issues we
> are seeing.
> 
> We'd be interested in any comments/suggestions the group may have.  We
> have the in-house skills to do fairly significant investigations and
> would like to improve the performance of IGD pass-through for other
> users of what is fairly useful and ubiquitious (IGD) technology.
> 
> Have a good day.
> 
> Dr. Greg
> 
> As always,
> Dr. Greg Wettstein, Ph.D, Worker      Autonomously self-defensive
> Enjellic Systems Development, LLC     IOT platforms and edge devices.
> 4206 N. 19th Ave.
> Fargo, ND  58102
> PH: 701-281-1686                      EMAIL: dg@enjellic.com
> ------------------------------------------------------------------------------
> "My thoughts on the composition and effectiveness of the advisory
>  committee?
> 
>  I think they are destined to accomplish about the same thing as what
>  you would get from locking 9 chimpanzees in a room with an armed
>  thermonuclear weapon and a can opener with orders to disarm it."
>                                 -- Dr. Greg Wettstein
>                                    Resurrection
> 



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 09:19:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 09:19:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271252.465631 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJXVT-0000NK-Oh; Mon, 14 Feb 2022 09:18:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271252.465631; Mon, 14 Feb 2022 09:18:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJXVT-0000Mt-HO; Mon, 14 Feb 2022 09:18:51 +0000
Received: by outflank-mailman (input) for mailman id 271252;
 Mon, 14 Feb 2022 09:18:51 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KkXt=S5=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nJXVT-0000Mn-0U
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 09:18:51 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1bdb9582-8d77-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 10:18:45 +0100 (CET)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2105.outbound.protection.outlook.com [104.47.18.105]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-28-Pe1rmBISPdm6btwxw60gdg-1; Mon, 14 Feb 2022 10:18:47 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM6PR04MB5701.eurprd04.prod.outlook.com (2603:10a6:20b:a5::25)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.18; Mon, 14 Feb
 2022 09:18:47 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4975.015; Mon, 14 Feb 2022
 09:18:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1bdb9582-8d77-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644830328;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=NHclxgsO2wIjGnas3J2z0bvbE6Wc/i62+cLKn6ifHNc=;
	b=aYs7hdz+/+DPgwQq7HThKqP8+M405G657drDeuWEMw4cZAOK//VAVhjKHcYwWV6gh5F2YR
	1jx4VbcHZ96zc4aCY+izar/DwihE2W/D0oqJ12IEiHut//QPwP5JHPJKbecCXni2LQo/+G
	ByireRQkGHRLJrtXlqqkzJxTfnNwD9c=
X-MC-Unique: Pe1rmBISPdm6btwxw60gdg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=k1LZkgtKYVsPRUXovmXXrMqRrl8zc3WwhvukIHx/tzGsdhkcGnbzun8IMUkqus9D6mbpw1FefJjAqUpTnMWuczmi5SsiG9zolshSCiAN7Ur7fJLa4LPaGeQMch6bIwXvEhmNbd1uqvRYyYj7yWC+AnfiwK/4fZKBmhpUyE5XQLpCSxBIeUN4x48hTSKokfsq4NBNTkF8U3YYrsAjqRVUNdFVzrsptSSZg0H1YSU75oNsy4R81IcOe2dO3pbAYRSGilfmeTmd6LQRiBNgaijuNG/0vWpMuprnjnHBHbyBr5MFIhLCH0tC6cRYqGY5mlEWxx37SevnFMQcM5P80Iaobg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=NHclxgsO2wIjGnas3J2z0bvbE6Wc/i62+cLKn6ifHNc=;
 b=YiLdY3Fyp3us9kbTfuSb4y5w8coSkobAw3TPbt3FBKC+k8v0Zv6CSf9QD2msHXOH21I+e/FD31EyWKtYEHUt2JZZlF93IlB870bkvAhg10ZwUdwMvxjSLn/9mlrjAVG0XUs3g1JzL2NrjDor30Q1H/KB7+Z1LKwgkXvi2e8++7SBhYsgXym+d+hprP/vJdpYw8un5KoT/y2kWOcRmIRagt2D4KcgKHz9Ig9RWr0DGGPQtd50o8p29eQud/1yTXXrW1TBoKxuy6ID1EGjW6pRSrDsw+moXlocB956NppIHlk38/YpDeLabHUNMEqJ0/EM2N1uQKJpOXfAKNYII9nw4w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <92d00aea-9984-3940-2e2a-d54281e4c3a1@suse.com>
Date: Mon, 14 Feb 2022 10:18:47 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Content-Language: en-US
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH] x86/Intel: re-indent family 6 switch() in intel_log_freq()
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM7PR02CA0012.eurprd02.prod.outlook.com
 (2603:10a6:20b:100::22) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 49c7c767-5e7e-4b03-a397-08d9ef9b00ff
X-MS-TrafficTypeDiagnostic: AM6PR04MB5701:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB57014A3D496C0AB609A92F06B3339@AM6PR04MB5701.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	NoAMbhcwcBjRCNl1734LlLB4UdnZ156+D7OiRHssbLaNIbnedP+rr8B+f3QBajaEX/VJxFbbEADl9NOKwfkXpqDKHb+Nn9lCgBLlIFhcimd3RHQzdtEqXdSfxbPJHO/D0V0iZ+D1FgW9CkKMnOV3vclQctKQcJZfKZfJ6SWMtNzayr8a4hfz6sZdmcNEgS1wMyd7U61JgADcCdfIZ1HCfJl3Zv49xJw0rtq82o05g7NNSjKLOdtmSyfXlEgJKi2qJGy1uN21ycmuUvQaPjS+NJQnYiwuCpyREESsMGRw2jPZqGr6VLAnBH41TS/BhLrU02Ll5IJhYJ4/Qk5Taz28T9Vwvnl2uyzc3dnF31J7q+r22KRw43dXPkNdiJvCk497VTnRAvfKAUlCnOmMK8Utkd2H1aDdKKWiKYU1K6RmQvWm9SL9US3vq3uvdLv61Uz1gR4Kf4aF8DTKcuFQiZND9plY4Rsa+QZZba24GnEkO3pFNstbDAv5dksZmW7uwLIcXFYzcyZ6ZDTzAyoBo+ZsZkN2trq+JZC5DfcEeq+L6/gq7wAkld8Vikv9fQgAWL92nXlV9rHQu/q3ePJS0Ad7A+un0wy73QCo3zpp68RIL2F+ZcNAva5zbGad1X2zoVL3SeAyuQHyRFOfOjP6ZmBpYiwOHGUjrScIGiRl55NjNM3sRi5Z3L6yjFlFXtTwcwcODLp0xfSq681yqTiOC4okRuDr0tCULEFFzHpP6yrm5AY=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(31696002)(6916009)(54906003)(86362001)(508600001)(316002)(6486002)(66946007)(31686004)(6506007)(38100700002)(8936002)(5660300002)(36756003)(6512007)(2906002)(26005)(8676002)(4326008)(66476007)(66556008)(2616005)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?SmhQT3B2aXhxV2JGZWQ0eUNwZGdWQ1FsRFlzd2xHblVnaG4zb3Vhb1JiOGRO?=
 =?utf-8?B?NVc1cDZpcjd5amV1MktvQzMrZGZoY2tTeTQyMFVNZmlhNno3bVRtdjhWUG9z?=
 =?utf-8?B?MjFIOWJDdkhBVFhIWGNrMnp2Z1JoR1FpY3JJL3NaRzFhZ1NNMkN2ZXppWTFI?=
 =?utf-8?B?WGgvL25Hbm9lNzc4UXc3aWsvZ0pCYkVVSk5tMXJpWFR5T3loRWRIcldmbVM5?=
 =?utf-8?B?U2N4VGdiZVBqYnNRQng4N2VTN3huMmtIUEtpYTYrRzNpMkpTQ3lIL0pMNVVL?=
 =?utf-8?B?eHJLam9sZTlqK1ZwUHlyZUdpdzRTTG9OcGJ1bDRoc29rbDhiUjFrVkpvWUdN?=
 =?utf-8?B?cDhWYmR3ZG1UcVFWOXBFdkxjMDZETjJVQ2tZRnprdzBsR01UcGNHeVFlZjAz?=
 =?utf-8?B?anR3dWpLZzhEamJvRHRDNThkRFM0Q05oVmR1L2FYcnMxWXVubm56TXNFdU0r?=
 =?utf-8?B?TUxZYlNNeHloczAwbEhoT0FzUDE1dkh4TWJyc2dUYXExOUx6dy9ua0JKcnRw?=
 =?utf-8?B?TEtENzQxQ0ZEQ1JKbElxOGtpejJseUZhKzl4Z2p4aFlBdlZzLy9ud05ETlR4?=
 =?utf-8?B?eVpuU2QyT2NGclQ0dTRzRjVEbGlpMUFqLzRIcklkQ1FiNkpkT3RjL1hHYnNy?=
 =?utf-8?B?NmsvVEZhVk1Hc3FEbzBSYVpRb3kyZVNlSlpDVmxQOTJ2d1ZOdHJ0dWd5UTJX?=
 =?utf-8?B?dHN3MDBPb0ErQzVsWDVSbkg4ZEI2bHhvQUNybzZ0UldGbEoyZkMyWWRadG93?=
 =?utf-8?B?Zy9vcG9ENHhKRU16aUxtOXRIbG1HbndoTUpHOEp5MklicHdyd3VQTk10d0xY?=
 =?utf-8?B?YVc2enVzTmdvK1krOEpxUG92d3RidGVwRWF3VC9Wc1hGU2RkdG9jNlF5NkZM?=
 =?utf-8?B?Y3dmdW1hcExYYWZmclFJS2loNXNVZ01Uc0Zha0d0ZmhSTEd5aWpZT3dlaTEr?=
 =?utf-8?B?NFRROHZyL3pUSk8wemliUzBCS1UrVEVrRGU0RjVpMWhKMXBDUW1tZWVJV3FT?=
 =?utf-8?B?cDgvcDFhVDlmMWxUTGV6NlVKZ3IvcTNaUTJTeFIvUU84U1h0eFVJdzJzeWtH?=
 =?utf-8?B?cjBwUWJPdmltTi9zWUhrUVVjZjlQVEpLb2NvaHRpcHJCcXVOOHRTblZ2cFVs?=
 =?utf-8?B?aFpybTBwRlJxVGFVVU1uNTZvcTlqMERpVEFnZWNVaEp6UXlIYS94T2EyZDhl?=
 =?utf-8?B?TlREREV0UERPdWt6ZW9kTDdGU3FmbzRJSjlKM1IzbHN4U1AzK2JSQWRFRW5x?=
 =?utf-8?B?NnV6UEZkSk5HcGpwbUQ0TmRWcEw1NDdnNjI2VFdsOUpuNVdvUEc1VkZMaTFR?=
 =?utf-8?B?OERocytxRFFROWZxdW5kUXk2TUg2RXBoNHlQRlJ2WTBoT09qM0cxZE5namNv?=
 =?utf-8?B?azQ5QnNyMk5VQ0hNaVI2SEYwL08xbkV6SHNPVDZlWTd4WlBLa2dyRGtMUGNY?=
 =?utf-8?B?aFJiQzVvbEVTWXVKZkh0dVRmQmNoZ0EvOEhiT3hCVE9QVGVnaGFxOTdOQnc4?=
 =?utf-8?B?OXNPNGpGR0NOK1JRdUdaVDlnNjU0TFlVbmdocE15VUduQWg5OURFMDIwd1Fp?=
 =?utf-8?B?K2luRWM4NDMwZlNrUjJQeWltUnRQdmxzbDc1Qmh0TGZkR0RQemFiSGE3TXIz?=
 =?utf-8?B?Zld5Z1BueS9leXJ4RzJEUUZUaldjQ29YM0VQMytIY3A0NW9rOUNVWmp4LzBE?=
 =?utf-8?B?WGN4RzV0dFJMUy82WHhIU0RINDBzbzluWnhwcElrRmN4N3U2R1RMRWk0b09k?=
 =?utf-8?B?WHBuSElxeVZTUy9xOThkY3ZxOW1GSjYwUjg0YUVHcXNGbmhKb2dyQ05xNC9u?=
 =?utf-8?B?NWVnLzZCMVBUK3FOTUJoTHN3UXA0YThDY296dzFUNllzQ1lYbTdIRHU5WlBJ?=
 =?utf-8?B?RnR1ZHFIbGtENWJDeVY3ZkZsYVNidVA2L2hOUWxVWnRYd2FzS01nVHF6Q1RP?=
 =?utf-8?B?TFIrSzduSS9POU0wc2ozKzEreEp4Q3gyTDhFK1lIODdtMVo4aTZuZ2xCN2Q2?=
 =?utf-8?B?eHF0SEJ6K2pPcFJ1d1JTS3Z4T1d0VUkzc095ZFVjM2dpaUk1NEFraWZySkk2?=
 =?utf-8?B?WFhnYU5FYWkvK0xIOXIyTWpHaDZCTXdkNXJXcEZKUWRRNmthOEE4S0xiNU1s?=
 =?utf-8?B?T0ExME1yK1JiOGdtNkhsV2dGRjFkcEtpYjRiNkxaUTcyYllwQTZndHNwd2Y0?=
 =?utf-8?Q?zEWd8DOvs2XoKTPRXfojF6k=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 49c7c767-5e7e-4b03-a397-08d9ef9b00ff
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2022 09:18:46.7389
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1LDO4MM3Wdj3F8ONEjhEuvpI+gUmVFXLx00RgK8ZHWQSRBr2h3bDck9PigSsx+2sI/jCzkRoair6kt5UUuYMIA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5701

This was left at its previous indentation by e6e3cf191d37 ("x86/Intel:
also display CPU freq for family 0xf") to ease review. Remove the now
unnecessary level of indentation.

No functional change.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/arch/x86/cpu/intel.c
+++ b/xen/arch/x86/cpu/intel.c
@@ -468,35 +468,33 @@ static void intel_log_freq(const struct
         if ( !max_ratio )
             return;
 
+        switch ( c->x86_model )
         {
-            switch ( c->x86_model )
-            {
-            case 0x0e: /* Core */
-            case 0x0f: case 0x16: case 0x17: case 0x1d: /* Core2 */
-                /*
-                 * PLATFORM_INFO, while not documented for these, appears to
-                 * exist in at least some cases, but what it holds doesn't
-                 * match the scheme used by newer CPUs.  At a guess, the min
-                 * and max fields look to be reversed, while the scaling
-                 * factor is encoded in FSB_FREQ.
-                 */
-                if ( min_ratio > max_ratio )
-                    SWAP(min_ratio, max_ratio);
-                if ( rdmsr_safe(MSR_FSB_FREQ, msrval) ||
-                     (msrval &= 7) >= ARRAY_SIZE(core_factors) )
-                    return;
-                factor = core_factors[msrval];
-                break;
+        case 0x0e: /* Core */
+        case 0x0f: case 0x16: case 0x17: case 0x1d: /* Core2 */
+            /*
+             * PLATFORM_INFO, while not documented for these, appears to exist
+             * in at least some cases, but what it holds doesn't match the
+             * scheme used by newer CPUs.  At a guess, the min and max fields
+             * look to be reversed, while the scaling factor is encoded in
+             * FSB_FREQ.
+             */
+            if ( min_ratio > max_ratio )
+                SWAP(min_ratio, max_ratio);
+            if ( rdmsr_safe(MSR_FSB_FREQ, msrval) ||
+                 (msrval &= 7) >= ARRAY_SIZE(core_factors) )
+                return;
+            factor = core_factors[msrval];
+            break;
 
-            case 0x1a: case 0x1e: case 0x1f: case 0x2e: /* Nehalem */
-            case 0x25: case 0x2c: case 0x2f: /* Westmere */
-                factor = 13333;
-                break;
+        case 0x1a: case 0x1e: case 0x1f: case 0x2e: /* Nehalem */
+        case 0x25: case 0x2c: case 0x2f: /* Westmere */
+            factor = 13333;
+            break;
 
-            default:
-                factor = 10000;
-                break;
-            }
+        default:
+            factor = 10000;
+            break;
         }
         break;
 



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 09:21:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 09:21:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271259.465642 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJXXo-0001gm-1A; Mon, 14 Feb 2022 09:21:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271259.465642; Mon, 14 Feb 2022 09:21:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJXXn-0001gf-UQ; Mon, 14 Feb 2022 09:21:15 +0000
Received: by outflank-mailman (input) for mailman id 271259;
 Mon, 14 Feb 2022 09:21:14 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=jzps=S5=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nJXXm-0001gX-GK
 for xen-devel@lists.xen.org; Mon, 14 Feb 2022 09:21:14 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 71580dd5-8d77-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 10:21:12 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 71580dd5-8d77-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644830472;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=aTzFiiQ/Jn4gpxeJo7wbZYqOGI8DY5YKZSGkwK9yf3E=;
  b=bwlZ2jrTJKnBFqrY5blVml6aGwncvwm36gci/mr7O96btUcYPF/26WCj
   /Yn+nFKD6M/8TIP2EbS+Snm/Alb6VVri0+LYybDuCN4JHjgKM6dQ+h9mM
   +oXfZD8cYEOPvamRrjqs5pKdfft6uFL/ScgpZHwJKlYHkXgaWEVLheAVc
   w=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: Gey/G3I7B7AKDqtOrXYnpGExfc5ruVYSNhH6HxkwxsZLrOFg8aT6yS46iiApK2rQW4OLKBb6/B
 329iQeVszSfQyBdceDvXPmx8fiAYg3bf7x9Pi8tdnPyyB3ONYbaU/owBTms0jZbSqpBUXABT+w
 X3wEF4UBvQUscXzhRr4bGdBRS1WGBSnAFsf5lsKvKNXAbsgzZOaIECDcsvLRfs+/WlEsejC2Do
 VJ+/CQujCv8ZCQ5YUSwb/qNKC0u6syeeacTOvENpzLQ06XNE6HnAoG3xyN7YIkk4Z+BmlvqGdw
 W1Q/Hd2WNiBzFHNsijnpizLm
X-SBRS: 5.1
X-MesageID: 64037046
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:ZIcwQqiAnmq+K1OeTr7bz4wuX161XBcKZh0ujC45NGQN5FlHY01je
 htvDGuDa/2KZWf0KNtzPYrk9UkDvZDTz9cyT1Zp/n83EXgb9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oAMKRCQ7InQLlbGILes1htZGEk0GE/NtTo5w7Rj2tQx3YDga++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /0Kv7KgVyZ0BJfJxtZDYT8AQyBZAIFvreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHxO4wSoDd4xCzxBvc6W5HTBa7N4Le02R9u2pgVQq6CO
 aL1bxI+NxrjSjdwFmw4M4I8peD0oEXQTTth/Qf9Sa0fvDGIkV0ZPKLWGMrYfJmGSNtYmm6cp
 3na5CLpDxdcM8aQoRKK6H+jruLJny7/XIMZUra/85ZXbEa7nzJJTkdMDB3i/Kf/2hXWt89jx
 1I8vSAAvbYTqXaRS4fPAS+e+C6FmSMwco8FewEl0z2lxq3R6gefI2ELSD9dddAr3PMLqSwWO
 kyhxI2wW2E22FGBYTfEr+rP82vuUcQABTJaPUc5oR05D84PSW3ZpjbGVZ5dHaG8lbUZ8hmgk
 mnR/EDSa1j+5PPnNplXH3ia2VpARbCTF2bZAzk7uUr/sGtEiHaNPdDA1LQixa8owHylZleAp
 mMYvMOV8foDC5qA/ATUHrlRQ+H5uqvdaWaG6bKKI3XG327zk0NPgKgKuG0uTKuXGppslcDVj
 L/75loKuc470IqCZq5reYOhY/nGPoC7fekJosv8N4IUCrAoLVfv1Hg3OSa4gjC8+GBxwPpXE
 crKLq6R4YMyVP0PIMyeHLxGj9fGB0kWmAvueHwM50r7gOTOPCbPEd/o8jKmN4gE0U9Nmy2Mm
 /53PMqW0RRPFur4Zyjc64kIKl4Wa3M8APjLRwZ/L4Zv+yJqRzMsDeH/27Qkd9A3lqhZjL6Qr
 Hq8RlVZ2Bz0gniecVeGbXVqabXOW5djrC1kYXxwbAjwg3VzM5yy6Ko/docseeV1/uJU0vMpH
 eIOfN+NA6oTR22fqSgdd5T0sKdraA+v2VCVJyOgbTVmJ8xgSgXF98XKZAzq8CVSXCO7udFn+
 ++r1x/BQIpFTANnVZ6EZPWqxlK3nH4chOMtABeYfogNIB3hqdE4JTbwg/k7J9A3BS/CnjbKh
 RyLBRo4pPXWp9Nn+tf+mq3Z/ZyiFPFzHxQGEjCDv6q2LyTT4kGq3ZREDLSTZTnYWW75pPeia
 OFSw62uOfELhg8X4Y91ErItxqMi/dr/4bRdy108TnnMal2qDJJmI2WHgpYT5vEcmOcBtFvkQ
 F+L9/lbJa6NaZHsH1MmLQY4aviOiKMPkT7I4PVpeEj36UebJlZcvZm+6/VUtBFgEQ==
IronPort-HdrOrdr: A9a23:LA/8KqhMGswgAxB/Hj8Oz+ldrXBQXzh13DAbv31ZSRFFG/FwyP
 rAoB1L73PJYWgqNU3I+ergBEGBKUmskqKdxbNhR4tKPTOWw1dASbsN0WKM+UyDJ8STzJ856U
 4kSdkCNDSSNykFsS+Z2njALz9I+rDum8rJ9ITjJjVWPHlXgslbnnhE422gYytLrWd9dP4E/M
 323Ls6m9PsQwVeUu2LQl0+G8TTrdzCk5zrJTYAGh4c8QGLyRel8qTzHRS01goXF2on+8ZpzU
 H11yjCoomzufCyzRHRk0fV8pRtgdPkjv9OHtaFhMQ5IijlziyoeINicbufuy1dmpDl1H8a1P
 335zswNcV67H3cOkmzvBvWwgHllA0j7nfzoGXo9kfLkIjcfnYXGsBBjYVWfl/y8Ew7puxx16
 pNwiawq4dXJQmoplWz2/H4EzVR0makq3srluAey1ZFV5EFVbNXpYsDuGtIDZY7Gj7g4oxPKp
 gjMCjl3ocWTbqmVQGYgoE2q+bcHUjbXy32D3Tqg/blnQS/xxtCvgklLM92pAZ1yHtycegA2w
 3+CNUZqFh5dL5iUUtMPpZxfSKJMB2/ffvtChPlHb21LtBPB5ryw6SHkondotvaPKA18A==
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="64037046"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=BVb2oEWwpzSUXb5Ff6eyVSz3jZJDqlq8GyCSFlt++ZobBzVaKQ02a+pH54lS6b4AltcEafBXKNGQUZ3xot3T9/cMT28T2qjcfBAGNRgVFyPjzJGtHd1yxHAvt0DFgWzrUyk9NKXh35DWOW1Yv94swlTHgpkWRcsDzDBtfDgvm4lxEUkE4uUkyhi9ffDoSb8JpFSOElkXVG5Yu1HkZ44Lz7GhtiowosazwXJ0Fc7JZFsdB+AtBZxI/l+ooKJW3lRtYnomC3jYSDjJ4n7XrKUPDzZZupU16xqwH3j0L5VCrzUbKM6o7xi74O3+MSAuan0i52Q4XcNnSkgpoyx6CbG4sQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=e93GEiZLikR/MygTaIWrH1FCGnuc38AdZzBR5cJbqN4=;
 b=a8OEpOJJUtuUQtpyrh15TknoTCQ24c3KAQU2zZ3Ov3V7nA9eiXTe4I26wbwZrB6uM/9dxBOpipN3iw0GwspBdmu69DqrGKh8Rg/rGzeesEFPBzEUFaIZz2t8dg4q7AFfmtXOwt8UDLHSD2SnKG7v6dqCTeYF1VwJ4qP+CHI2haYgz1/QnctKs6qqKoytQeH8iS5fj8lReBOfGytII78T4hhk+994xyNgMvgu6TlMAtOTaH+Mivmji3Toux2e+BTEcKI+ArvNLiCdMHzhpHlDtjamnXXwFkiOhq3LsID6N3h05tlz2RA5EnYuGPGZOnqKTyThdKPxUf7aHhHXJJb40g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=e93GEiZLikR/MygTaIWrH1FCGnuc38AdZzBR5cJbqN4=;
 b=QsHrCuEPSax46vOMSrjO9dfKKT8/Scyq0o14aIW98c4JRq2hWU6uVTJHyNYmdOSw1Iyo3vyjqgui+ByZH6FhutINUogsh6LHjEubxv0AfzvF94xapgwnAwy4JyFrS4drz4gEfrUyhm3sqAmO8i8e0sZKn/T5hkg/j5Nzs2My1Gk=
Date: Mon, 14 Feb 2022 10:21:01 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: "Dr. Greg" <greg@enjellic.com>
CC: <xen-devel@lists.xen.org>
Subject: Re: IGD pass-through failures since 4.10.
Message-ID: <Ygoe/e+UzAtHe3Ac@Air-de-Roger>
References: <20220214060011.GA24404@wind.enjellic.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20220214060011.GA24404@wind.enjellic.com>
X-ClientProxiedBy: FR3P281CA0032.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:1c::13) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 3a437ae6-44bc-43be-a4f9-08d9ef9b537f
X-MS-TrafficTypeDiagnostic: BN9PR03MB6043:EE_
X-Microsoft-Antispam-PRVS: <BN9PR03MB60430AE75FED0AFD10C3AAFB8F339@BN9PR03MB6043.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: lRMDMOLVl6auWS5RPwSSow/ao4iWgBUgShOc5sGGjOljk3Hyccbbs3krS6gCBOHQDkJK1kvv78Axvyko1Me2WivhsyHhc2+gp9oqNy0Bhj2IOpOaM9eRqjjwdXnfBXM0K0dcRnzP8zrvvA5wFw7qtNbJqycWvpR1kumgiBUc0uzkFM2iY2tUqgwUDtXO0yW+BNrnCDXsPi9Eo/7TjbBMgv53mk6hKfrlr+xQwNaSv96lcyyiPlT2f41TaElGb0FBGEgExJiQM8S+yKZxkZO+1S+PueL7Tb9GwfHN54GUOyrjKr5CPDUzBw00v8mCfj+PAXKeLMAwHeQLkLTobZqyPNEZj+s54zwOochs3l03kW2CgoLLbGleWrIhtu5PvajQc0RUImvGbhM4/7RMxLP4dXwz8xgvUaI+SEq7p1+KVDZcZ9P2Mu7nLzXO3i5eAfP8lcr6FJsIxZqpPzPibD3I7dRXBEP18IW9O7xrHE088Vlf8KzoT1oOXLHiIVd2hRkqRGBh/EDYS1KJUGBIU5VA6romGSR12N2Tb42EGlaTGExMQN3A2xJaHLdn1kHR4EQnWAwrKNIdeN7D4N3OFvolJ0VqpRSZ3s2WdN/Wg9INHUraiyAySjuT0Ebl8XQ0qvitQOF6G+uPn0TG5fo6jqkBEg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(6506007)(66946007)(66556008)(26005)(8676002)(66476007)(9686003)(6512007)(33716001)(508600001)(6916009)(6486002)(86362001)(6666004)(316002)(82960400001)(186003)(83380400001)(38100700002)(4326008)(8936002)(85182001)(5660300002)(2906002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZU4vN2VJWVdpWWYzZ044Mm5CTElLTWdwbmxPODdEVVB2MS9mM3NFc1IrUmNn?=
 =?utf-8?B?Y0k1ODlrZVQyU1ZET0ZiSXV0L2xybVZJTDZxU2ZsQkVaN0Rwa1dPQXB4czRh?=
 =?utf-8?B?K1B6Z25rNWhNOU4yOUJBUzRha3gvUFc1V1VpanVNbk1vN2xaVGNpZnlYeCt2?=
 =?utf-8?B?bWt5OGJiLzd5a2c4d2QySUpua3pNbjViektJY0o4OGJVS000U25Xd3lVdkFs?=
 =?utf-8?B?amF6UXYxTmJ5VlRoRmw5eGs5VExURDY3NkZBY2N2NE9DYTRRTHB0aHVzbUNq?=
 =?utf-8?B?cVIwamRLOWZTU0Z0czF0ZDY5akM1T0dqNFZlY2M4V3dOUnF3K3J5YzJvQWlF?=
 =?utf-8?B?Q1RoTG5ReHZ0elhiOTE4SzF6Wm5UTVV5cTZJcVlYbDduR0tUb0prQ2s2c1U1?=
 =?utf-8?B?V082ZXlZZGYyYUVzSmRoYVV6c2oyU21sRDQ3WUt4YlJwZEJWR1V1aENXT0Q5?=
 =?utf-8?B?QWhkNzhDaUEwQytkT2NGWXFxdUppUjZDOXQvcEl3ZkhTbkNYYTAwend5bEFG?=
 =?utf-8?B?L3RmM3M5c1J6aHdYNnkzQVZYeW8xY0ZMcGVJaVRvQzNXcityQTFEdzBUcSt6?=
 =?utf-8?B?YzNjVEUrWnVMVjFRVU9jNDZRWUtxdEhQR0xsRFBNVU15N2phSVlPOG1PNFBX?=
 =?utf-8?B?Z3VCelhsVUJIdTM0d09uMkc2MEc1VjUwZHdCRGx0VG1ubktvQUViQ25henN3?=
 =?utf-8?B?MUw2ODdEb2Y3R3BITDQwVU5pS2NUTzhmL1NHdFlZbFBuT29QK0ZrTS9WRFlu?=
 =?utf-8?B?cFBxNUNBMGQzanhCUnBiV1VDcmNTazhaUXVIQ1dncWVweVVFUjJVUWh0VlFV?=
 =?utf-8?B?cnBxMGRuSTBIb1huMkpIcXpmMWZsWlhoeG1FdDhIWFZ5UjlTMEFsa1hrU1lq?=
 =?utf-8?B?bDROVkN4Z3VlcnI2M1kzR1RWRDZTdGg1SXhweHJkTURiUGM2emxrNDVqOXA4?=
 =?utf-8?B?SU9XY2hINk5QOFRCY3pQend4dmJZanJ5Y3IrMGdpdlVkU0dtQTZuVTJiVzcw?=
 =?utf-8?B?NHhmeEdQUEM5OG5LbUpNaTVEL0dDNEo5OHhSWEQwSGtPa0NuKzRiYjU1bDdv?=
 =?utf-8?B?VUZGOGVNVzFRSHY4R1NqSUk0d21ieUdaTUdYbk9EOUV3cGxBeEFHSy9XNWtz?=
 =?utf-8?B?TzJMSkJZc3JiQVVSeXhuUVNDKzRBYVpDaEZPa1I4U3I4dkhTMWU2T1h4UHFr?=
 =?utf-8?B?cU9KYys5WmJScjFhREZSVXdHVEJMNU9GbWdnY2hyTHRIUTdzRHFTMXZiWmYy?=
 =?utf-8?B?OGg1R1hUTUo3c25CS1dCQUlFaVM4azIvS0RsNFVKNWFzK21rMnBDQkE0TGxI?=
 =?utf-8?B?aUxYRjE5MnJDREJjbmVPODFoUHhpdlBySHJGL2Rxamp5WFlmU24rRnB0WnFi?=
 =?utf-8?B?ZXU3UGZ6UkQ3d1drS3JGNnd1Nm42cmlCK3pmc1Y1VlRldEEzekwrcWlYK3c0?=
 =?utf-8?B?KzFmTnRlLy9TTUNSTXZhZDFSR1BDY0t1TzhTb1JxcVJyMHc3SkZGRTdTY0NY?=
 =?utf-8?B?d1hJM2lrOW1YUzFsczRxMHNEVGhlbjh2dERnaGJ6dVNBS1ZiWU5BWXAxK3E1?=
 =?utf-8?B?MFRNM2dlRWpJb21WOUhOUHJqL0dvRHZjMW9GL2tUbVhKS0FSZE1sZUN6Qndt?=
 =?utf-8?B?YldZZ3JOQ3RIREc2bVF2QXloNzB0YmNOaUFCK1B5b0tWWnNJSkhENHI5M1hv?=
 =?utf-8?B?T09DMXBRNVBUSXI2ejRaQ0p0ZkhRQ2FZWHRaMFBTS3Vodk95S3dYYnZNU3JM?=
 =?utf-8?B?aU12S1p6MnNxUTVuV1NrNVR2Q2NTRWNtVG8rTGkyejFFL010K0VxMDUvVStR?=
 =?utf-8?B?U2dNMW1sWlJ6S2ZoVTlXYWhjaWJEYVJUUTFLOEErTDZNdEtaUUloOGFXZUNP?=
 =?utf-8?B?Zmp3MWJNanFFaHRRNlp6bTNyZmVRK0sxOGdWRURZRi9sTGJjcEVIenR1WXZK?=
 =?utf-8?B?TnFiSFgrekprRTdjWVV5Y1dWZ05wLzczcURKSFdObTR2SHdtN0I2MUhZOGxy?=
 =?utf-8?B?SnBaSjNkK1lWc3FwZlpyUW9ZWFV5aGs1aVc5N2Nud3RKN2J6KzVMelM1VWJQ?=
 =?utf-8?B?WW5xTlltb2ZyR0ZoTDgvajdaVDQxcEZldkJpZVpwTDM4Z2N0VkpKaHJIU1hN?=
 =?utf-8?B?cVdIWTY5NjJoSE1QSlMxQjBmUlM3eDk4R0twd3lZQWR4YmhLY09GSUVPSVFW?=
 =?utf-8?Q?yjOccrQsrVoYyN9CbdnKZ5Y=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 3a437ae6-44bc-43be-a4f9-08d9ef9b537f
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2022 09:21:05.1353
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SbZynhqpaMz7PuS5YzvflRfumsxnb8XhEe0ZhFs0hvRtfFNU0k0OHUx2Mot70jmCv7wneI2EwJhHbcDicjoWAA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR03MB6043
X-OriginatorOrg: citrix.com

On Mon, Feb 14, 2022 at 12:00:11AM -0600, Dr. Greg wrote:
> Good morning, I hope the week is starting well for everyone.
> 
> We've made extensive use of PCI based graphics pass through for many
> years, since around Xen 4.2.  In fact, we maintained a set of patches
> for ATI cards against qemu-traditional that have seen a lot of
> downloads from our FTP site.
> 
> We ended up switching to IGD based graphics a couple of years ago and
> built a stack on top of Xen 4.10 using qemu-traditional.  That
> coincided with our transition from Windows 7 to Windows 10.
> 
> We've never enjoyed anywhere near the stability with IGD/Windows-10
> that we had with the ATI/Windows-7 desktops, ie. we see fairly
> frequent crashes, lockups, reduced performance etc.  The ATI/Windows-y
> desktops were almost astonishingly reliable, ie. hundreds of
> consecutive Windows VM boot/passthrough cycles.
> 
> In order to try and address this issue we set out to upgrade our
> workstation infrastructure.  Unfortunately we haven't found anything
> that has worked post 4.10.
> 
> To be precise, 4.11 with qemu-traditional works, but upon exit from
> the virtual machine, to which the graphics adapter and USB controller
> are passed through to, both the USB controller and the graphics
> controller cannot be re-initialized and re-attached to the Dom0
> instance.
> 
> It appears to be a problem with mapping interrupts back to dom0 given
> that we see the following:
> 
> Feb 10 08:16:05 hostname kernel: xhci_hcd 0000:00:14.0: xen map irq failed -19 for 32752 domain
> 
> Feb 10 08:16:05 hostname kernel: i915 0000:00:02.0: xen map irq failed -19 for 32752 domain
> 
> Feb 10 08:16:12 hostname kernel: xhci_hcd 0000:00:14.0: Error while assigning device slot ID

Are you testing with an hypervisor with debug enabled? If not, please
build one and see if there are any messages in Xen dmesg also as a
result of the error (uisng `xl dmesg` if you don't have a serial
attached to the box). Posting full Linux and Xen dmesgs (Xen build
with debug=y) could also help.

PHYSDEVOP_map_pirq is failing but without further information it's
impossible to limit the scope of the issue (and whether the issue is
with PHYSDEVOP_map_pirq or some previous operation).

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Feb 14 09:22:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 09:22:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271267.465653 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJXZ5-0002MN-Ew; Mon, 14 Feb 2022 09:22:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271267.465653; Mon, 14 Feb 2022 09:22:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJXZ5-0002MG-Bm; Mon, 14 Feb 2022 09:22:35 +0000
Received: by outflank-mailman (input) for mailman id 271267;
 Mon, 14 Feb 2022 09:22:34 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=jzps=S5=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nJXZ4-0002M7-7v
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 09:22:34 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a2e1abfc-8d77-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 10:22:33 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a2e1abfc-8d77-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644830553;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=rYkfkLUhq/ht2Astbyq1XPgusmFyRU50M5DZUeZP9H8=;
  b=Ogx5YA2jjKnMdzoBYCOlawPc9KTin9ycGUVYriRZnQYacDvkNHgzw+r/
   ErnuMyZPEWmv+BcGPVfv28pr5gYhufAIllH1RdbDzFcRxeoBM0eSy/eO+
   kPvr8e0hsGzqRcC1o60PbSABJuBAvY5EZhfp8hKll90xWlNDTRnuv+DFo
   s=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: NXQlrb/lw4cAeVsGqpiZyQecvvmy42F0gYKj1lyOIg5hz8cyBXp8jhwDyJZLcZx6JU8NrcbGzj
 kLAh8AzqKoR7HKQitdCPshmrXCdxx0Hl+hZ+l7UO2lE5H3Wn20IrCzckOoFqIPVJ0sESOhZT8G
 0NnnP7rFrtEXoXoj5/mEn1Cg+tIUnms2OcQK78dhbpN3j9JWihcdzOUdqT0YhxBjjrTDgqcpYX
 bSY1vwpuQWT/epGlAPt9liZKGLTU5l6m2/UM5BgBwY+7a95qxdOfpUmsstPlOp0CUE1zG+6QDG
 6aOvttRQlT9OLtc6uRsIRzuM
X-SBRS: 5.1
X-MesageID: 64037144
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:fBOPlKzFONxS03bLLzp6t+f+wSrEfRIJ4+MujC+fZmUNrF6WrkUDn
 2cZWmyAMvmMYmGhKNlyPo+x8R8B75KGn9ViGVA9/iAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAhLeNYYH1500g7wbdl2tcAbeWRWGthh
 /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL
 wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt81O5
 4h/67q5cBo4G6SSqMMsFAUfFxgraMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr
 6ZBbmlQMFbT3Ipaw5riIgVort4kI8TxepsWp1lrzC3DDOZgSpfGK0nPzYEEhGxv35wSdRrYT
 +oAamFkcE77WEJSOm43VJ8hzeuw2GaqJlW0r3rK/PFqsgA/1jdZz7zFINfTPNuQSq19jkue4
 27L4Wn9KhUbL8CEjyqI9Gq2ge3Clj+9X5gdfJW6/PN3hFyYxkQIFQYbE1C8pJGEZlWWAowFb
 RZOo2x38PZ0pBfDosTBswOQvUGr4yxCfdNpDvwf4V+97ZuT/0GdPz1RJtJeU+AOuMgzTD0s8
 1aGmdL1GDBi2IGopWKhGqS89m3rZ3VMRYMWTWpdFFZevYG/yG0mpk+XFr5e/LiJYsoZ8N0a6
 xSDt2AAiroalqbnPI3rrAmc01pASnUkJzPZBzk7vEr4tGuVh6b/PuREDGQ3Ct4acu6koqGp5
 iRspiRnxLlm4WuxvCKMWv4RO7qi+uyINjbR6XY2QcV9qGT9piP7JNsKiN2bGKuOGpxaEQIFn
 WeJ4V8BjHOtFCfCgVBLj3KZVJ1xkPmI+SXNXfHIdNteCqWdhyfclByCkXW4hji3+GB1yPlXE
 c7CLa6EUCZLYYw6nWHeb7pMjtcWKtUWmDq7qWbTlE/8j9JzpRe9FN84Dbd5Rr5lvf3U+F2Pq
 76y9aKikn1ibQE3WQGOmaY7JlEWN3krQ5fwrs1cbOmYJQR6XmomDpfsLXkJIeSJRoxZybXF+
 G+TQEhdxAatjHHLM1zSOHtidKnuTdB0qndiZX4gOlOh2n4CZ4ez7fhAK8trLOd/rOEzn+RpS
 /QletmbBqgdQDrw5DlAP4L2q5ZvdUr3iFvWbTalejU2Y7VpWxfNpo3/ZgLq+SRXVni3uMIyr
 qeOzATeRZZfFQ1uANyPMKCkzk+rvGhbk+V3BhOaLt5WcUTq0Y5rNy2u0aNnf5BScU3On2LI2
 RyXDBEUofj2j7U0qNSZ17qZq4qJEvdlGhYIFWfs8rvrZzLR+XCuwNEcXb/QLyzdTm795I6re
 f5Rk6PnKPQCkVtH79h8HrJswf5s7tfjveYHnAFtHXGNZFW3ELJwZHKB2JAX5KFKw7ZYvyqwW
 16OpYYGaenYZpu9HQ5DPhchY8SCyeoQy2vb4vkCKUnn4DN6oeicWkJIMhjQ0CFQIdOZ6m/+L
 TvNbCLO1zGCtw==
IronPort-HdrOrdr: A9a23:Bz1EyqCiUQ4xkf/lHeg2sceALOsnbusQ8zAXPh9KJyC9I/b2qy
 nxppgmPH/P6Ar4WBkb6La90Y27MA7hHPlOkPUs1NaZLXPbUQ6TTb2KgrGSpgEIdxeOktK1kJ
 0QDJSWa+eAfWSS7/yKmDVQeuxIqLLsndHK9IXjJjVWPHpXgslbnnZE422gYzRLrWd9dP0E/M
 323Ls4m9PsQwVcUu2LQl0+G8TTrdzCk5zrJTYAGh4c8QGLyRel8qTzHRS01goXF2on+8ZvzU
 H11yjCoomzufCyzRHRk0fV8pRtgdPkjv9OHtaFhMQ5IijlziyoeINicbufuy1dmpDj1H8a1P
 335zswNcV67H3cOkmzvBvWwgHllA0j7nfzoGXoyEfLkIjcfnYXGsBBjYVWfl/y8Ew7puxx16
 pNwiawq4dXJQmoplW92/H4EzVR0makq3srluAey1ZFV5EFVbNXpYsDuGtIDZY7Gj7g4oxPKp
 ghMCjl3ocUTbqmVQGagoE2q+bcG0jbXy32DXTqg/blkwS/xxtCvg8lLM92pAZ3yHtycegC2w
 3+CNUbqFh5dL5gUUtMPpZzfSKJMB25ffvtChPbHb21LtBNB5ryw6SHlIndotvaPqA18A==
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="64037144"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Kt2M6BhtWrLeOl8jXfiJggw86dv33OVQWk8jwrfF4wajEXYpqY32SElg3szDgrCSbt/pQdjBvmcUGEk1478jgg4vXc5DcnA9s4ch0M0wLgFFc3oAC3gAKsqYHnKGiUvLrDP8QLXdiUhpJAzuuFa6mIDWzfV/5O70bTqTkmBw1qAApeyaEJJkV5c+nZzDVzkLK3v0+pDiDoL+C5nWCNHmJ17NH8VpeBIJ+LVcSR5bhhXnDoop8uk7BqxRf29sxhT7lziy2AFfyFXNa+0QeE3aFzqHLkFhrKdfKsor4jbqxrhCQi1BLru/65bcFkwGf67gl7KtaK8RcwLxj2zVktpFDA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=KSRV7VK9yrauXdyLSbSueMKkeR6/fnPifTYno4dZ87s=;
 b=azy5X5HFs5sU5kdqa5jvfPvDwh7uLfmVURFqhdheCAaKZCmos5OsBJbHO28nz9V09yojLinW9yI/rlmokR9PrY2+zivC8wEDLRGa9Jzh2xQ7FUXeRCgj5N+VKjdXwCdbvQQy37VreeKArOzIddsaslfUzmozUEsy0mJHFT5UxxGTd/dhEd5cK7QEl267ugdWA9qEYNbOXDkvrcmdMy5WuOcDyqUhg9WbY6rOqP5p23ecwU4POyo3Kx3dMg9hJNr9QdwXqp4Dy3Am/iWV1t47nAbkv70JIoveulrwBO3X7ombx1Tifro+ww5dajsepnGeug5aGTqtqlcNL6kn1RUBFw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=KSRV7VK9yrauXdyLSbSueMKkeR6/fnPifTYno4dZ87s=;
 b=dO/2uObaE/fkh+ZsE+S/vV/v+mUGKDTGK1XIPyt0EzV/gxZX3Lk/Th8bplgmXf7WNrXialjrwIHKhJPQz/2IKMb74Z0ZCv308NTO/g+h5+7MBVtdWq8h7K71F03UHmmE070oaHgVyb0FCeFBPCEFvbvWwCfYcv+WhvKxf++aQS0=
Date: Mon, 14 Feb 2022 10:22:23 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Andrew
 Cooper" <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH] x86/Intel: re-indent family 6 switch() in
 intel_log_freq()
Message-ID: <YgofT7jG9CFSunkO@Air-de-Roger>
References: <92d00aea-9984-3940-2e2a-d54281e4c3a1@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <92d00aea-9984-3940-2e2a-d54281e4c3a1@suse.com>
X-ClientProxiedBy: FR3P281CA0069.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:4b::16) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7bda64aa-893a-48c7-fa3c-08d9ef9b84bf
X-MS-TrafficTypeDiagnostic: BN9PR03MB6043:EE_
X-Microsoft-Antispam-PRVS: <BN9PR03MB604320876AFDAE9CE69E3EA88F339@BN9PR03MB6043.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3173;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: xNLKsNNTq1XFV05SoCUSk1Nj7muj1ddxtjDe4jVDtjue+B2zNQvFz2c2Iz9Fs85fUZeNoAXmMlbLAMYZj+KLozEOzr3HKknGNcnR4kDVpOyjDtTEzw3bsuX3MczFHoomnBGYIw2EvDK+FnIQxEeZqmZPnBdBuMsCpmUOBRLL2QHtVcspVijXv+cCJcECcbo9M2fWCB/850fDLpeofTmF7WYGjzcSnRbpsqX4qJwE1tiQInkobFDLEwhifNn/bRBhqPNrEYpMzy9GdyIndhddJxjXuGNyRR6yPi+wRUiBtwS51lW20Ck8iUNkp+0ZcKbsxPqaDaXb6iqnryjEtBq6djUjCmQ2H3wkOf9DAhuWN1DHT7Z62zc8FvnSL+3uU1jfDtnrG/nFeP55tpZ4PY0KdSNHxPpqeSLfooDGaravyCZbqYVQm/EkF8ORJhLzVQHXp0OVWeTXGiRIYXWGP8lax2q6zQmZuB5nQOzqWoYjWcGKlfTq6cB2uezj9HH/9wztvYVlFX0hgN9YO2zSnm5nOsMJBctD7NUAPqYaGwr6ax3FS2zSHZI8Rx/ibkWNPH+a5LaS39OvGjXwngGz3m8+Re+DZD1KBJnz4WZ2yTFmHv5tXKsXwZbhUXnyeKH34FY4tOBWTdAZHL8Y9XAGT+lPIw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(6506007)(66946007)(66556008)(26005)(8676002)(66476007)(9686003)(6512007)(33716001)(508600001)(6916009)(54906003)(6486002)(86362001)(6666004)(316002)(82960400001)(186003)(38100700002)(4326008)(8936002)(85182001)(5660300002)(2906002)(4744005);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QlJpeVlWcU5wQkI1NVhBYUVJN3dnMFN6citiVGNubnZNWTEzWXlobTVtUDBj?=
 =?utf-8?B?a1NseVdrUklKcEdnSzlkcVBVR2Q3L2U2ZkJtbmx1aEhNVlNzSzdEN3JpeVJD?=
 =?utf-8?B?eVRmOEtuOWphaUhtOVdvbGVNVmtLRHRsSENKUVlxTFJtQnM3cDZwL211RUtJ?=
 =?utf-8?B?dGVTUHNzZERyUzdSYlZlQTVWd0pGdndvZjZlMTE2Smsxd2M0bVpwTHVQRDJu?=
 =?utf-8?B?QklteEhabGhjR2NTSkRkSVovaWFRbG11elpzdWtET0w1REFJdG5mTEl1MitV?=
 =?utf-8?B?MExQdm9HVFdkNkljcnFPK1VqMmlLQjFkbXJQbUFRTlBIV1hRWkt2N1NLcWYw?=
 =?utf-8?B?SFFmZlExTkpLdnBkdDQvQVppZ2hDeHVGNkJnaVRIOEFOSzViRTFRRHJPa3Fo?=
 =?utf-8?B?dTNkMm9oeVdNTlA2ZE9JUjJqdUdDK0EyNFRKYlM2K3VnZTNDUWU3S2xhOTAy?=
 =?utf-8?B?RXNyMSs2WkdVYXFwUE1OUTFpOXUwcXM0Ymd2WWNjaE1KRzkyOGxMQzloL1lE?=
 =?utf-8?B?K0hmb21nOGVucC9MRlpBMVB3TEd3L2ZSUTFuS0hSVHUzTjlpOHZyZTZ1RVlZ?=
 =?utf-8?B?aFVKdTlRbUVDOUhRMThucTRZcHdOYXBSYVV5aFRTSzNZeVdyaTBPZGJzRkpB?=
 =?utf-8?B?SjFiSEpQUTBhODMrWHBrdlo0bkQ1cjd1SW14REU4NHVPUHBrMCtUaWNTaDZB?=
 =?utf-8?B?SzZJTUl6SnNWSTVvZ09iakZCVmljbG1VL0gzOXVuOHNmSXBPcmxETWtPNCsr?=
 =?utf-8?B?QWhSMWtlemZsZVRIMHJkWlFKQzVkcjJ0dGQrOVlQMDJUcTRCR3JvcjlCQklx?=
 =?utf-8?B?U0t0ZmVyZHd2ZjM0K1pvMEdsemZ0ckRZN2Y1SlZGVSs2R29XTEF3ejhsWkho?=
 =?utf-8?B?ZmQxT1RkMzk0Q2pyTlc2b0J0OWFEaWdBeEw2ajNlaXYvczV4ZENkOU1DS2tT?=
 =?utf-8?B?V25ZY3VvUUcybkJmMDkwaytJNkJodjQ2QTRmd1IvcXkwUCt0RE85S0swOVFS?=
 =?utf-8?B?QVRnMDA2MWVST05kTG5pZXBYT2NuQnBQRmVteWV2U3VkdUxteG5RamxQSi9x?=
 =?utf-8?B?STJoVjdqVjU3SDl3MWp0QlVHY3BkU1BXa3lydW81YVJGME1oazBLeG0yS0JR?=
 =?utf-8?B?eUUyK0E1MnMzbjR5cFFQLzQ0VlZJS0VFTUxISGZLU3pjb25zeEUxb0ZrRlhs?=
 =?utf-8?B?aXdqSi90MG9ZcC83WEx2cUZLazJiRisvTVNJTVJHd054b1l6czNBRXNFUHdv?=
 =?utf-8?B?LzdRLzArODA0a2tRb0ZoY2VWODBxRTJtTWMrakx6U3Z3MXBuTlVBTlFLUXBU?=
 =?utf-8?B?QWEzVmdlbG8zcUU5VzlON2J5RHBGRE9iTXI3WFlaYkMxRnVvaGdoaXVid0Zz?=
 =?utf-8?B?TW5WWXlBVXdsbHVLUmJWN2gzeExaQTlVQVYyMVZVSGNJTHVYd0ZPOFRLcVFT?=
 =?utf-8?B?RXZ5OVA0SU9yeWhBWHpuZlJiNzhpUWVTUTd6SEN1YWNQbDFsd3JKOHhkeXJj?=
 =?utf-8?B?QlBaYzV2VkZ3V01EWEw0MW80Y2F3eUlkOGJUNUl3RjRPcUFBWVpWRFZSM3Yv?=
 =?utf-8?B?TE5IeUpORm1MTFdSSGpORyt6VkxRMnVxcjl0cXhUeFg4UEpsMURsZmpUWU1n?=
 =?utf-8?B?U3VMTnhvRVhxM21tN2JYWHBtUXo5Z2k5Nmd1anQ5T1Qvdkl2QVBoSGNRYWRj?=
 =?utf-8?B?VHNiUlE5SWx3czRmYzhILzVycFlEKzZwU1pYd1k0RDhqL3pnbzNzM0pkVy9k?=
 =?utf-8?B?VW1GZk5WVlI1L0F4Z2hpVzUxRmxMYTV4U3gzREc0NjB5NGppUURBaExvSkRq?=
 =?utf-8?B?SzYvb0lnVHFudkU3WVAwMU5yTTcrV1NqMnV2WWU2RUdob0tkOGdYNUcrQ3lp?=
 =?utf-8?B?TmJzaXZXOG5HTXArZ0VGM3RGUTZBR2hub3VreU94bmFhdWg2VnZBdTFuQVJ4?=
 =?utf-8?B?RkxoQ3JwVS8ra3k1dzRud04vMFcvSXJrU0p2a2Q5Uzg5OTk1RWkwNGc5VjIv?=
 =?utf-8?B?Z3VscjZHc0lOMEVzMmJDdnVRL0pYcmRKYzBFeWNwc3NsanVKQkducktoSlhn?=
 =?utf-8?B?RE1DaFJOcEhZS3UyNURUWkNQRmc0NkRiZGpPSFp0VEUrNnFlSmwxRjhkajlP?=
 =?utf-8?B?c1pwaS92SHhjbTllZEVkSEU4Q29mcUM1dFl5RW85Z29QOTFFMnlXWGtIM29p?=
 =?utf-8?Q?dnfk1Dm8I/NeWK3n3mMOcoQ=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7bda64aa-893a-48c7-fa3c-08d9ef9b84bf
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2022 09:22:27.6404
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dHDa0k9fx9Epyucr/ZrvU3vRYXi0teotEysKVwLcx2cVoB/iBUOhRQC+y/7QUuBRiRaqSxCxS1AD15vQBzOg/Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR03MB6043
X-OriginatorOrg: citrix.com

On Mon, Feb 14, 2022 at 10:18:47AM +0100, Jan Beulich wrote:
> This was left at its previous indentation by e6e3cf191d37 ("x86/Intel:
> also display CPU freq for family 0xf") to ease review. Remove the now
> unnecessary level of indentation.
> 
> No functional change.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Feb 14 09:23:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 09:23:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271272.465664 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJXZV-0002sC-PA; Mon, 14 Feb 2022 09:23:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271272.465664; Mon, 14 Feb 2022 09:23:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJXZV-0002rV-Ko; Mon, 14 Feb 2022 09:23:01 +0000
Received: by outflank-mailman (input) for mailman id 271272;
 Mon, 14 Feb 2022 09:22:59 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KkXt=S5=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nJXZT-0002qw-Mg
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 09:22:59 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b0c01e55-8d77-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 10:22:54 +0100 (CET)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2107.outbound.protection.outlook.com [104.47.18.107]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-41-3pz0AI1ON-S8xnDz9ARIJw-1; Mon, 14 Feb 2022 10:22:57 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AS8PR04MB7688.eurprd04.prod.outlook.com (2603:10a6:20b:29d::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.15; Mon, 14 Feb
 2022 09:22:56 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4975.015; Mon, 14 Feb 2022
 09:22:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b0c01e55-8d77-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644830578;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=wGx4FH1iZaavxWV8ixKSZfSy2uLtsBdwLhDIdoatfZc=;
	b=VO/zDXFpesQrB2gXDaghhIpuyFh8vawP6shAVd2RvtpaF4TV3czwxgY8ts1T7c5YavkMJU
	cuXM2RMWCzt8fH7xsw24L0ajLdnOvna7XF39xqI2/odhpKrlsk6lUnq5nqCaEJ9NM+9pxZ
	NIiNXFxwDbdEWzx2W/Aql5r7XuTOCaQ=
X-MC-Unique: 3pz0AI1ON-S8xnDz9ARIJw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=RZXLkE9Ee5KM3PsRaPpDvfQ4ZWxdvUd52gWdRIOE0/4I3pgeQCL+uASQsOIquiFmyNLk4yW2ShUU0x4+pLr66kW2ilb5y+jE6Mo97kt4UcCET99DH+EdVWdmKUeKKV5D73CEhsg5oIDnrFgBfJzSp/WmONTvm54MQPqF5pzKnXRh306KS0kPvHLmddynF8h35u4YG9Pprj2bSIYqaAWO5s+qhY1AxCEnJH7IJjJ2ZcMZ8uei4hJfVX/Lm7Fd66UuAR8VbAFYxYpL1xw5qdp4CDt2GtG3XV/rCTzcvGk300hOM/W+9Sxr89gagHrTmU5hkGPQzT2/3+Rd39+fP4xTvg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=wGx4FH1iZaavxWV8ixKSZfSy2uLtsBdwLhDIdoatfZc=;
 b=DQaqEPIyr6v+P9fDN6M8eGWpGupZrHo1SydxdH/uCoOnAMCkwqfvXC6N5hHVvo15t5ngL3yI3xztgPdgnB4ek8A9bVBzhANx3z80u07r6pM2yZeEQZIea7Qx/nYFCsQelP4xcdM4+makz9hdfVHJZiF0NBxAYaG6ugPWPB5xlugLYW5E2hH7CbEd0kcg9KANYD08uW2gngT0fVq6Gww5Z2K/ZKFxzeCoEqStB0b7iltV08sbEv5rr3mwZBmH2g/Yq6/2ssI8oCPOOMaFadHaCbhF5jdXgR2ez9YpPaV4SStgODh6bh3puhvPzVT2ia4cdAjmDpqVlTMwdpSUVHL4Ow==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <35cb3c72-05ba-24c7-1fdd-3ee1aced3aec@suse.com>
Date: Mon, 14 Feb 2022 10:22:56 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH v3 0/4] x86: further improve timer freq calibration accuracy
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR01CA0039.eurprd01.prod.exchangelabs.com
 (2603:10a6:20b:e0::16) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5f15b2fa-49b8-4a53-20aa-08d9ef9b957d
X-MS-TrafficTypeDiagnostic: AS8PR04MB7688:EE_
X-Microsoft-Antispam-PRVS:
	<AS8PR04MB768847E0EEDD04E9D7C52A2BB3339@AS8PR04MB7688.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4303;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	dgP4EJQ9RqlChFzA30RiArtIKyTWRUA4eTcpEQ1mCP5mk+3Ml9b8uuGmP/3mWm+kDYukqmPfg3D54VI20JNG3RvEWeGAJs1097B5oM4W7lC+jAnXMbJN9mqRqt5aNE9pbp/zfBSawk2jP+e+JNssrv1PuvFyoSOwNn7stqWuR8M4Fu+7IDGHtJgupEDAQZZbt+l2fLC1Sy2XTfDet8ULknYupGXZhnNq3kE/P8ZU6r9+tWDjPQGBXat98PC4h4d8iaPHT+fu+BvwR01yPz7+xxT4l1BrarWPpKmHrW2Gbdl814lprY4VzqwINzCSWJP4lnFRfJDRLP6PwFxslFvvYrdtFIU6sbeeb6T48vtvWGXfJjNM92Z8t+rCWUZubONep7xl65vk3qwY0z1+Cq3rL0n4EScg5/bsgMQGBKSHwnK5eNM72sZL7OrNDCmTSsxMq5CqKu9VtkywJCV9XgB9Mfx02R7Rok+7XjlrTvZX24i99aprdEZsWN92/XFVVAbzBVH0mQ2Lif8RlP8l1pPDu9vXLlxrKeCGlJMNAy9XRvFSPu1fYL7fKxvjba8LyjW4hbHhKVbC//wz8yzsTPa4ExLc0PQY+hCTzQTrq1QxfduTSIa6tnEJ6HRGwJH4igAQhQUqxA6C7dekxrq74KQ1Cci5aVrvIkhqyShQ+CvtlQtFZXZlD4cr1KniEzUG3qAb/G/lr3kmRXvJSc+aYaAg6jGMxj7YCa+yLZSWvMV4fb4=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(186003)(6916009)(38100700002)(26005)(6486002)(508600001)(54906003)(6512007)(6506007)(316002)(2616005)(86362001)(66946007)(4326008)(31686004)(5660300002)(66556008)(66476007)(8936002)(31696002)(4744005)(8676002)(2906002)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VmlZQzE3WWp3bUFqRkdMSmNjU1VtU2o4a29BVzVFRTJ2emtKTzZjam9KSUww?=
 =?utf-8?B?U041SmxaMTlRYzlUOHIvVitqODlReGNsSnU5djZMNVdaVS9McUpBQmt6UGJh?=
 =?utf-8?B?YzQzTTZjYS9Dam4xV0V2UklzWHpmLytRMGY2Tjc3eFZyaTdEMUEwOG0veUdn?=
 =?utf-8?B?M1NmL3JiODhJc3M1UXduVEd3cnJlSTJuM1dyc2V2VW1Qc3pvS3FwcngzaEMy?=
 =?utf-8?B?TXNUUTdrbWtkYzJ4Q3FSQ2dwdG9WSzJkZ0ZXRjhKNUJoZTBkZDNsQ0dKV1Vn?=
 =?utf-8?B?VFVpLzB3Y2poczRhQzIzdy9SSFZvS1dkOXZzSHZ1T0Z4VHNnK3FsRTJ6aXZm?=
 =?utf-8?B?UWs0QlludjdFcEF4QW9GQ25yM2hpdWdIVlo0U3RWb1pYYlhNc1NCaWNrNkIr?=
 =?utf-8?B?K1U1cVpxUlYyVVUxbktaNUo5Z2xUTmNoNmhXSDRTa1huTXRwdDlqOHdQUHg4?=
 =?utf-8?B?SjkzSU9RUXlPbHRHZzRQdTRsODlua2pUbzlsTnljdUwvT2x3REIxZTlCNFFR?=
 =?utf-8?B?NmFkdEUyUXdqbnE0WENkbGNQSVVuQ2I1TzllK1gySHhkTHZ6bWFnd1E1cEhP?=
 =?utf-8?B?aGo4RFdyY29YRjlqYStEa1Rzams1WURINS81THNuWThZUkwxNTRvREZFYkxE?=
 =?utf-8?B?dTRaVE5KT0hOS2Z0TVNubDYwQTc4Y2JoaUtEaW80NWQvMkJTRTRUdjVFd3hh?=
 =?utf-8?B?Q1ZjdVduMHpzRmVYenF0RU5malZnRmhWbEorT1QxZ0dVdE12Yy9nNnQ2ci9y?=
 =?utf-8?B?TUdsNE4yTnFIRWxSa0wxd3pxQ2VTOGlPMEIxV2tNOVB6NkVycWMwQ3Bqa1ZJ?=
 =?utf-8?B?M0RzTVo3WDFFQzk4czhwVy9Ld0tUSmY3bEdMTGJGempBeDRLcXF6bjlaSXY5?=
 =?utf-8?B?aFFPLzcraWxBYzZENStXVUhDNXlaVFVhZnF6ODZQalZsRVBFQ2VmZzdoOU5T?=
 =?utf-8?B?MkNQWU1RMG9OT0JGV01hR1NmcXE0V1dPU2llc0g3OHVNNGdpWGpuM1krYS9B?=
 =?utf-8?B?eEhOVFdPczl3TkFpYTlZeUtSMEkvYWIyRTFRcWZxdi9LUUdROXNtcGtPZENj?=
 =?utf-8?B?WHBzZ3hDSkJHM0FPTXM0L0dPQlpBalorYXo3SkNKRElrTFNWUkE4Z2lHYW9p?=
 =?utf-8?B?WHJKOHl1Nk5RcVR4TTZuWnNDRTJ1U0NzRng3R0o3Y2VQUWgrU2NPUlMySWZX?=
 =?utf-8?B?L2RKOGp6cE8rQzFyN3paWGY5QVJkd3EzYXp5T3M1c29WRk82bFRqZmVrMzBB?=
 =?utf-8?B?bDJIYXVlNXdENi96a0JVMjk1ZVdQNTBhZzJWZ00wcjlWY1FiZ0lDdkUvL2xx?=
 =?utf-8?B?RzVMTi9oWHNMWFMxcDBNZnJSVlpTWnloeTMxWEhzUGQzTEt4ZEFFNHBSbC9T?=
 =?utf-8?B?Z0cxcytBZDRCUi9GSjZ3VmN4RjMxcUh5NUI3TTBaMWxSNGQ1ZldyRjlmZlRz?=
 =?utf-8?B?WjJoY2swaGNjZWFHZTBmaDBSS0pOR1kxbHFnL2o5a2h1NUVhUU92bGJCK1RC?=
 =?utf-8?B?Mk1aS01FelpjWS9tbFEwNU84bTg2ZVFlVUdHdWpNL2x4OTBZLzRIbjUrenlT?=
 =?utf-8?B?b0RxRXk2WHVWWDFIamxuR0FOaFZsb3E1MFRlbWo4OFpsQUtvQXNjSnhvdlFs?=
 =?utf-8?B?OEJrK1pYc3NxUnc4aisyejZIR3BRVFRBWGZyQkpoWDRlTHUrL01jUzA5SVoy?=
 =?utf-8?B?MGdyci9oa0FTN0k5WXQrcG03U0F0eDFPTVNXNHhDTHNtaVJwTHVqelZtQm9m?=
 =?utf-8?B?THVFbDRPd0hQU3ZZM3NVN2tkcUZybFA3N3NxbzVvb2ZLeWNtcVVrUnBsdUVL?=
 =?utf-8?B?YVh1UnBZZitUQ0wwLzFVcW9ISzZhZHE0dkdORjM1NCtmNjFuUmtla2xKNkFB?=
 =?utf-8?B?OTNaS2tYUUVkWHhTa3Q1Lzk2QVlXWU1rWWFjdUVWUHlnQ3RCR1REcmhLVXVh?=
 =?utf-8?B?YWpKWUhOL1JsK3JycTcvMzVocUpZb1lXQm5DNmJWM0tmZUpFNmVlRVlzbTJY?=
 =?utf-8?B?WjBVMWMveTN3Y1M1QmpwWHh0aHpnMmFJcS92cHUvRzlYek1rdjQ1WFZ3Rll2?=
 =?utf-8?B?S3ZyeDM2WjBya0Vva3l0TU11aG56ZW83dEhVWFQzY3I4c3VUb1lQSUZtTXRz?=
 =?utf-8?B?Uzd3STNzQzZieUtHdk4rYXNtS1c5UDB2ajR3cnZoZU1XQW9sWFJEc0hPOEll?=
 =?utf-8?Q?WUBDnTOWyDomcudH1y6Vv80=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5f15b2fa-49b8-4a53-20aa-08d9ef9b957d
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2022 09:22:55.8485
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QuDa+60kZX5tXGY9fB6bw0lhQcAy0DOIdAoVu08gQz02c6oUTEUAX/MUdvVcx3UkIEH1UNkOrvrJpm3vA6TyCQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7688

... plus some tidying (or so I hope). Only the 1st patch changed compared
to v2.

1: time: further improve TSC / CPU freq calibration accuracy
2: APIC: calibrate against platform timer when possible
3: APIC: skip unnecessary parts of __setup_APIC_LVTT()
4: APIC: make connections between seemingly arbitrary numbers

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 09:24:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 09:24:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271282.465675 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJXbJ-0003XD-1E; Mon, 14 Feb 2022 09:24:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271282.465675; Mon, 14 Feb 2022 09:24:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJXbI-0003X6-UG; Mon, 14 Feb 2022 09:24:52 +0000
Received: by outflank-mailman (input) for mailman id 271282;
 Mon, 14 Feb 2022 09:24:51 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KkXt=S5=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nJXbH-0003X0-BS
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 09:24:51 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f54e5ad5-8d77-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 10:24:50 +0100 (CET)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2111.outbound.protection.outlook.com [104.47.18.111]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-30-lqBSNoEcPIG3vdXAKS47dg-1; Mon, 14 Feb 2022 10:24:48 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AS8PR04MB7688.eurprd04.prod.outlook.com (2603:10a6:20b:29d::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.15; Mon, 14 Feb
 2022 09:24:47 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4975.015; Mon, 14 Feb 2022
 09:24:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f54e5ad5-8d77-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644830689;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=jRtj4tiv1hm3ixQ2cH3tp9s+VaiO4YvJFI8HrqxEZ68=;
	b=dEBsRK+YI8zdr/7wM+r8gZBYg+DTeOvb7SjoMFPbF7BPltWzA7cGCxVmc5xkHP4jR+eUYU
	Pyo8YS/3/qva5icvxGLJkJIoJTey9X5F6W6PSJUjsCY8P1jx2r+LsBTuv1KjfBNwm/ShZu
	DLYlK+vRKF3F4rdyvuRda09Zh25SPys=
X-MC-Unique: lqBSNoEcPIG3vdXAKS47dg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ccgPs2X5KqWgOEOwIW7kXcoewEniZzSlZGVxrxmgWKQCkHdoVdGV1UWwspWegJchnVoMEJs8fSr2ESEQ3uj8YZ9KKiTU/pAMcFM/eMxCOhF0BhpbpWuEGtrHdVoT1rVFu1sUGBCLS9jivgqupyec0oP6ItfFmN9vKtY1Ivuhkk/WSbsVAf9PjjZxDSqDPUZ8Fv6K8U38ZKq7agvDQbnmutGVX440fWEE29zOUbxZ7grZ9sHWh+Xp06MstCnzWFlj8xHLJW0mE6wiNibYsjfz3QEe4djZ82SY9z7yAMAih9dkiTuSxQD9Cpe7pwnn0s1WPahgvkzlIiygPaAkUK33vA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=jRtj4tiv1hm3ixQ2cH3tp9s+VaiO4YvJFI8HrqxEZ68=;
 b=NlyTV/Mbsw6gLNr0FgehfXhr/4aMY43s4ZJQXbq3HSEZ9ndbow/4xK75WxwGBShSYZTrrSdjVDTa1lFTKbT6sfd2+X/HfKlXb/Ihz4QqVKhM78HmJe6iUP4o0hZSK68vO/3wy0mqNbxl71lYbMhp4VOif7XYPsYah5CsyD9FvMB+LO6Dx4a+mmHbHEX9XOynJb9T/+g/Qhg9bOzpMGFVNMDi2ZnfhwE7kIp8K3hXCJlh9JwCqcBOuhGZ9dUxYwpS9e0YTD+fPNVMyYEyI4mL+5ENwQ3D0dFgkfuJrWsfLoYkWPeS1JegbCz/kL0+2ASk5a5FfvpLVl/zCMt/+mGGJg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <65c123fe-c8e7-b9cf-4dea-904bf28170a7@suse.com>
Date: Mon, 14 Feb 2022 10:24:49 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: [PATCH v3 1/4] x86/time: further improve TSC / CPU freq calibration
 accuracy
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <35cb3c72-05ba-24c7-1fdd-3ee1aced3aec@suse.com>
In-Reply-To: <35cb3c72-05ba-24c7-1fdd-3ee1aced3aec@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FRYP281CA0004.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10::14)
 To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 99849706-52eb-4af9-8704-08d9ef9bd83b
X-MS-TrafficTypeDiagnostic: AS8PR04MB7688:EE_
X-Microsoft-Antispam-PRVS:
	<AS8PR04MB76885C8E3E09322A00C101CBB3339@AS8PR04MB7688.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	jdYvnhKPTPi8T6jFp3jmFSaWfU30V+UsWq/K/w8dGM2YA6GC7Q2UWA7Gzy1bXJFjFfSp20ZPDNKf9yFrz5q1OUkfw1mPSYNZzjvaI2I2lKufhB5/rG2g6hJTmvJGZ4EuGfQhnFCg8bSg6d6MLdVRehCik0JnXIUmVPwlZgFQcnCWWWio/t/IdSTTaD4EgHjDllESOfugFQzXy17ZS3P/HMOJ6M8z/2ValhqlQdTpyj2p6NkSm+K7G6ZvaIFaeVn/ttfp1IZEH+bFSztdzHediIA6LPLTfe4ihYqTy9LvePXlLe5PUmufPnn5WHacKdICzrkPy+buiDfQbnyqA0hGUR78j5xPOoGwJIZ0rVq+f3GmOOhVE3RMSGzEzs02wFIRAbbvsawc94JAyCJhiNeHMRVsWzOtL4sB6AxAeZAvdqo0SDab+b9g49cYRwbk6dM2j4i4dK8bH3Kj5fbaXUTxqHmEFBjCWZvkLcAAZSpUPwuuQbzB7RQox8vDZkAeN1qXrtE2q8/MAlGadKd/ecBqJZ81eghzqbvtLQqNX+15jvq7LgPWGYjiZHZcQJ34YRzSWa5anoyza4ayGF04d4pUWqPx+CCfKWXziStk+6wYeDZJxt6GTqeDbLa+pof+PxNOzGdCtZshgOWl//GYue2FUB5Maobz3svsZ4/YXdU+YD7nlutqCWI+HBayhan57cvhxhYU0lbezkX79poe1AzBir8QIkcjdtr1s/c0pPSVo18=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(186003)(6916009)(38100700002)(26005)(6486002)(508600001)(54906003)(6512007)(6506007)(316002)(2616005)(86362001)(66946007)(4326008)(31686004)(5660300002)(66556008)(66476007)(8936002)(31696002)(8676002)(83380400001)(2906002)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?R1lGYThMTWFZYXA1UlJvWnJFZHdCdmpWWGIwK2ZqcEVSR2VQS3RIM1BIUGg5?=
 =?utf-8?B?M0tvZzYrMjJuVVBlV2NxM0VoT1dRT3VvWjVINS9sZW9Nb0tZbnVhc010T0Q0?=
 =?utf-8?B?b1RKSWVLaER6Q2NQVVVreVRYVzQ2NkloVHc1TEV6NDVCMVE2Slh5eDB5aldK?=
 =?utf-8?B?eVZFYkNLQ3RFcko3NHBTY2tsY21RQWNuUWkwV3ROSGVDR0YxZHJuakh5V2ZR?=
 =?utf-8?B?NHVnYWNnd08xTnMrMGdhK2VUd21UTXYrd01ickpnaDE0RmtVN0RRRHp5L1ZF?=
 =?utf-8?B?aFV0Y1U1bWtXOEJBNXBOSk5VeFFNQUZWcnlsVFVvMXJZOTFZeFhsbldVS1cx?=
 =?utf-8?B?alpMeUpmV1hTVlJpbzljay9rMFRDZEFUYUdEUGNGZzVDMW5INmVjNE9KSDdF?=
 =?utf-8?B?SkR4NFh6MlNrZ2w2bmoxSE82WVFhWkp1RW5TZjBZT2NCVzdRUTFPZ0xhajE5?=
 =?utf-8?B?eDVna21GMnJTSi9HbE1maDBEemJpSEJrVW1PZjN0bjQzUkE1bldqUS80UWtw?=
 =?utf-8?B?OTJBbDhqN0dYcFRGUlJScGU5dmpSNXBQaDZNZzhaUWRQcGw1WTdRc3RDSFR1?=
 =?utf-8?B?OU5jSXVRU2pCL3BPM2RYS1YzYjduTFdMTERmY3N2S0x3ZzN1M0tUL29qTHlN?=
 =?utf-8?B?eE1KYzRGbGN0b3NwNXFUSFhCSGZOcHhGdVcxUWlJTUkydG9IbDNuL2RSckx6?=
 =?utf-8?B?YnlER3ZNZ3QzRXdsVXZrTVFOZjhpT3dlNkpFc0wza2ZwN2FpS3hOZDdBQkpF?=
 =?utf-8?B?Nmh1VkRBeHFjcFdKTWhmNjFRU3AwNE9RSGx6SVRQY05xWnJUSXpLOVpVZU91?=
 =?utf-8?B?dzkwNlFRZ3ZGVTR2Uzk4Q0ZKT2FxazdyRm5VSGl5VEhIKy9GazJhUnkrY0xy?=
 =?utf-8?B?eW5tSjFJSGZ2cVZIcnkwSGZVVGc4Sk9seHlLbWtkUTlzWnprVUFiV2ppRytk?=
 =?utf-8?B?T1hkakt1SUNyaFJQSWdiaWN1VUtWQXRhdWtPdkc1emFva013VW9jQ2pFVTVz?=
 =?utf-8?B?aXNGTEF5djdxVkthNW5TZFBhZGJzVm9UUlA3dmo3T3prdktpeHRETDBsWDg2?=
 =?utf-8?B?QkQ4bVBmRmdUbzVML0IzMW1VVmhycE85cnlxUmI0TkEzN1VaQkdWQzk5QTNO?=
 =?utf-8?B?b2JwRmlkSGk1VTArOGc4YmcrSzBmeDFpdkJWZk5JczhWRE5ydTlXUmRiVE1j?=
 =?utf-8?B?eDhrZUVHUnhLMG5uRmV1ODMrUGcwTHhOSWNzQTJNSlF4WmdEOW5aaTdMNkU0?=
 =?utf-8?B?QXNnYTdqSW5kbmR2NkhUNWRrV1pJbGI2QnJkZHBod2JyQ0xmWE1MdDgvYStz?=
 =?utf-8?B?TDZQd3ZUN2NlWjV5R29rc1pSMU5tS1R1aEcwcStKdlNwdlZjL1pqTCtNdzRu?=
 =?utf-8?B?Y1NGMmdtZkxCUW9yVGZaTFRZc1JUcElTdUFTMVdMeEdzclk3aW0yMHduY3Ay?=
 =?utf-8?B?N0ZqeE1SWjRnSFFONm41ejlaQXlTU0tsakhmWVEzK3c0SXlqNzIwSGY3R1NS?=
 =?utf-8?B?UlROMEppOUJjdklYWVNYK0VXRTl0S0I1czMzNWN6Y3RtZGY4dktGdVpGbmt4?=
 =?utf-8?B?Z0hOVWdsR1B3K1UwcjVmRTJ6N21LeDdycFFEVysybDNuMFoycHBVcEpJbDZH?=
 =?utf-8?B?ckZnUzlMRldEUno3L1hlU2VrQlBRSURCcEVqWC8yYUdHSFViZlBGOGpzbFlS?=
 =?utf-8?B?RzZVcVRKckVyRWxINlV1bVBvbWZIOXlPMTA0d0dRYjhkYW9yK1pQYU44WEp4?=
 =?utf-8?B?VlVJSzdmOUtzYjFoZ08ybnQvbzFCUUJ1ZjhONXp5aGIxZy8yOXZhZC9xUXFt?=
 =?utf-8?B?enB6T0c1L1JBRWVpdVNrdnhxVDBUWTVoZG5IMnVUdUlobWlXUDdvRUg3OVZG?=
 =?utf-8?B?S3ozYndWcU4wRE1SOHpLTnoyZzgwbEpMbytsYmM4b3dHckszVFlmdG94cVJ6?=
 =?utf-8?B?L3BLTyt3QjJtemxYZjh0M09PWFZCL013YWQ5d2FmWDBIN3g2MElhV0wxTWM1?=
 =?utf-8?B?R0tQOGNyVjBlZTRIaWZ4N0pLdnJVRDdiUEIzaVY4Z3Iwa2dVWmV3S1dYajRV?=
 =?utf-8?B?STgxZlMrUWlKY21KeEtpWngzVmQ0d2VOWGxCU0VkSis2OVYwbm9IT1h6UE8z?=
 =?utf-8?B?VzR3bkpmM2Q5VWNWelpUSzdRYkJWT2MxS0EyNWg1ZXdWamJvQ0VFRjhzSXR2?=
 =?utf-8?Q?LLpi7eM/5IIh+6C3vPq4Wxw=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 99849706-52eb-4af9-8704-08d9ef9bd83b
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2022 09:24:47.7478
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: o3T5TjLjqbFv4ZxLJBYKRlWqhR+09NYnFNHxifvSSgawRhPMQmxWcbvkM/8O3L1epdeUPfpnuTipJUc1jN8jbw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7688

Calibration logic assumes that the platform timer (HPET or ACPI PM
timer) and the TSC are read at about the same time. This assumption may
not hold when a long latency event (e.g. SMI or NMI) occurs between the
two reads. Reduce the risk of reading uncorrelated values by doing at
least four pairs of reads, using the tuple where the delta between the
enclosing TSC reads was smallest. From the fourth iteration onwards bail
if the new TSC delta isn't better (smaller) than the best earlier one.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
When running virtualized, scheduling in the host would also constitute
long latency events. I wonder whether, to compensate for that, we'd want
more than 3 "base" iterations, as I would expect scheduling events to
occur more frequently than e.g. SMI (and with a higher probability of
multiple ones occurring in close succession).
---
v3: Fix 24-bit PM timer wrapping between the two read_pt_and_tsc()
    invocations.
v2: Use helper functions to fold duplicate code.

--- a/xen/arch/x86/time.c
+++ b/xen/arch/x86/time.c
@@ -287,9 +287,47 @@ static char *freq_string(u64 freq)
     return s;
 }
 
-static uint64_t adjust_elapsed(uint64_t elapsed, uint32_t actual,
-                               uint32_t target)
+static uint32_t __init read_pt_and_tsc(uint64_t *tsc,
+                                       const struct platform_timesource *pts)
 {
+    uint64_t tsc_prev = *tsc = rdtsc_ordered(), tsc_min = ~0;
+    uint32_t best = best;
+    unsigned int i;
+
+    for ( i = 0; ; ++i )
+    {
+        uint32_t pt = pts->read_counter();
+        uint64_t tsc_cur = rdtsc_ordered();
+        uint64_t tsc_delta = tsc_cur - tsc_prev;
+
+        if ( tsc_delta < tsc_min )
+        {
+            tsc_min = tsc_delta;
+            *tsc = tsc_cur;
+            best = pt;
+        }
+        else if ( i > 2 )
+            break;
+
+        tsc_prev = tsc_cur;
+    }
+
+    return best;
+}
+
+static uint64_t __init calibrate_tsc(const struct platform_timesource *pts)
+{
+    uint64_t start, end, elapsed;
+    unsigned int count = read_pt_and_tsc(&start, pts);
+    unsigned int target = CALIBRATE_VALUE(pts->frequency), actual;
+    unsigned int mask = (uint32_t)~0 >> (32 - pts->counter_bits);
+
+    while ( ((pts->read_counter() - count) & mask) < target )
+        continue;
+
+    actual = (read_pt_and_tsc(&end, pts) - count) & mask;
+    elapsed = end - start;
+
     if ( likely(actual > target) )
     {
         /*
@@ -395,8 +433,7 @@ static u64 read_hpet_count(void)
 
 static int64_t __init init_hpet(struct platform_timesource *pts)
 {
-    uint64_t hpet_rate, start;
-    uint32_t count, target, elapsed;
+    uint64_t hpet_rate;
     /*
      * Allow HPET to be setup, but report a frequency of 0 so it's not selected
      * as a timer source. This is required so it can be used in legacy
@@ -467,13 +504,7 @@ static int64_t __init init_hpet(struct p
 
     pts->frequency = hpet_rate;
 
-    count = hpet_read32(HPET_COUNTER);
-    start = rdtsc_ordered();
-    target = CALIBRATE_VALUE(hpet_rate);
-    while ( (elapsed = hpet_read32(HPET_COUNTER) - count) < target )
-        continue;
-
-    return adjust_elapsed(rdtsc_ordered() - start, elapsed, target);
+    return calibrate_tsc(pts);
 }
 
 static void resume_hpet(struct platform_timesource *pts)
@@ -508,22 +539,12 @@ static u64 read_pmtimer_count(void)
 
 static s64 __init init_pmtimer(struct platform_timesource *pts)
 {
-    uint64_t start;
-    uint32_t count, target, mask, elapsed;
-
     if ( !pmtmr_ioport || (pmtmr_width != 24 && pmtmr_width != 32) )
         return 0;
 
     pts->counter_bits = pmtmr_width;
-    mask = 0xffffffff >> (32 - pmtmr_width);
-
-    count = inl(pmtmr_ioport);
-    start = rdtsc_ordered();
-    target = CALIBRATE_VALUE(ACPI_PM_FREQUENCY);
-    while ( (elapsed = (inl(pmtmr_ioport) - count) & mask) < target )
-        continue;
 
-    return adjust_elapsed(rdtsc_ordered() - start, elapsed, target);
+    return calibrate_tsc(pts);
 }
 
 static struct platform_timesource __initdata plt_pmtimer =



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 09:25:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 09:25:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271286.465686 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJXbh-000445-Ci; Mon, 14 Feb 2022 09:25:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271286.465686; Mon, 14 Feb 2022 09:25:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJXbh-00043y-9V; Mon, 14 Feb 2022 09:25:17 +0000
Received: by outflank-mailman (input) for mailman id 271286;
 Mon, 14 Feb 2022 09:25:16 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KkXt=S5=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nJXbf-00043T-T6
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 09:25:16 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 019c5b25-8d78-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 10:25:10 +0100 (CET)
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur02lp2050.outbound.protection.outlook.com [104.47.5.50]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-28-FVX4WaY3NL2bj_q26NJuLw-2; Mon, 14 Feb 2022 10:25:13 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5168.eurprd04.prod.outlook.com (2603:10a6:803:56::33)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.18; Mon, 14 Feb
 2022 09:25:10 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4975.015; Mon, 14 Feb 2022
 09:25:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 019c5b25-8d78-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644830714;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=jCxscIvq6zLulNKcY3/NWbd2vQ3CrupkD38ZmXXmcn4=;
	b=IjK0pCrTHa7qvrMdV0z1bj+fdmCDhPevyzDv1upUqpouyGIFSkir/RbOTo/p0EU5x4S3Sm
	5zF5s0JjguopesyxkZc1hZGHuvmGzYO7ahVo8yEK+aWksGw2AN53e50q1mZL8aC84aX/wk
	V4Udg+Fb4zyEeqqw6rnGONB1l6N6SVo=
X-MC-Unique: FVX4WaY3NL2bj_q26NJuLw-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Me3rN0K44Qo1Dwa2BajlxJYcjyIZKXkdUv7ynhC5osN/BStBFZrYOAjR8e6veGNvV/7n72gb/YgvqFmuwnlf8uYMjmhsCJg6gAMh7Slm6HPG+7TX88oHVmrLLULHJ79DbS1IvOju9dyYjrhw1udvOEkOO2n4GrUWi+gTf5mWSDFtDnMD0AD5IL180KU1QpkPOhzyVsRkLXdEW90Df0OQavfDqi8Uteq0VrgWynBaDuJctVGE2PDQuSiWu4goO14F9YPtd2EE7oZlLrufh4lOV8ufAguvLc9rEmjDZL71wR796E1TYUe5RNl9S9lVIAjvsx58hTmUZSy5/abABxWqKw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=jCxscIvq6zLulNKcY3/NWbd2vQ3CrupkD38ZmXXmcn4=;
 b=G8q/9ZRn6bsNqFo7W3kv5VnUFpQDuPArOIMxB3pCRVwmi8GTfJ1/D2pEAzVMZItTa/K0U7+M3YOW822PI/KXijN8GpUesG1YSiHHgCejYQgj4x9cKVae/6DMBEEd4bT2WUet/Cr8WJx0wcOY+PkRzisZn/5tqYY5mgOo4MPiVfdC3FOZZZbNdclrqfQBa9KUAmiXXVSsNMVj40Ludb9nfMcfkIKucjJerSkF4jVpqOhgEDv0pZIphmei/TXsugECDIPcpvsf6zXoQ7mD5IGzI3hZIm8dbv5SvRY/FgyBk2RFBWrImMxO8p79+lfbHpatbElybt5z8B9OLfO4y9kLtg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <cb7dd6bc-79a4-2137-5e82-805b9daf5d58@suse.com>
Date: Mon, 14 Feb 2022 10:25:11 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: [PATCH v3 2/4] x86/APIC: calibrate against platform timer when
 possible
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <35cb3c72-05ba-24c7-1fdd-3ee1aced3aec@suse.com>
In-Reply-To: <35cb3c72-05ba-24c7-1fdd-3ee1aced3aec@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FRYP281CA0015.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10::25)
 To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f922ffd4-8132-4aac-11e1-08d9ef9be5cd
X-MS-TrafficTypeDiagnostic: VI1PR04MB5168:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB5168E51243B8549A7B9B7639B3339@VI1PR04MB5168.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5797;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	SHdl4Z4XHmSQ2gTxzFX/8pyNdq/odi/ilnDIezipMC9QHCOm7QT6J7qlonGdFQKD0Dfe10yX3KuvxCHJF1p/OryNfM3uqQZYPjTLHs0KijGsZekf0ktwwLNtUbme4HSzjA4flMQDyw1/GirNoBDB2AdSOYG2GRw5s3JC0AFBqRHbQq9cbqqZynxVLGa3IIz4Z++hbisMRpALV310A9AiGB6rZV2EjRuNhVCR0agfy9JULi3gNhvqWthDPzzxg9Yz778Dhoainu3xs4+9crcOq6OwkiASonUgWlCjC4bFlnjIqbRkcEKRdZT9+OaWpfKt7R9VjScwgdnA2/EceRCvA48jVGW2YHSGVWTyUw/y2+JiQFtKwMFVVa6Wrf8kSvGQs5reozzQdhIthVLbDQTkp6/jJE2B5kyZ7TmDxoKy1QbA0bV/q5di09R5mfFv21hzXTGwYdcAJP5XGeKCxrzTPIa+vggeRt1qe3FqbJb1m1rwUI+a4Ra6GhhlMqbsaLVjU4w2E1KLI9iRKNx8p7o+bUGJo9IKya+YRCsqPfGvuGTMSuejhp/A6BjyNEMlxQOr3/Othm5Q0BLtCFaN1QzQVwYSkbEjTtBUSeETdsdABQOkWkHUZx4M6Fr2TYJ3gfA4lWN+EO2iNuqVG57imUFwP567Wf8Ai/D1BF5OM1WxJknswv1+LkpINxtk5mOMO8nWw48kpeZRifHIonIFAK2F/98ZQlGQYO8bciYqiTK+bI0=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(36756003)(316002)(38100700002)(6916009)(31686004)(66556008)(66476007)(5660300002)(86362001)(54906003)(4326008)(8676002)(6486002)(508600001)(31696002)(83380400001)(26005)(2616005)(2906002)(8936002)(66946007)(186003)(6512007)(6506007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?MVVqbUFVdkpsMHc5YTNXQ1creFQ0RHF2YU50NFlpbDZDa3NmcURJaDlraHk5?=
 =?utf-8?B?T0RxcDhUbGs5TmxBTHVSa2J5QWV5MXJIMzdGRTlaYXNRdHluRnBEaGtuS2tC?=
 =?utf-8?B?WjBlYXpqZTJZZ3IzKzY5M2ptK204S2JucUJkZ0E3MEQxVkg0cjVXSkZGN1hh?=
 =?utf-8?B?anBKaThOTHRtWE4vOUxrQXYyaCsvbldNRmpTNlF3MkRyT0cxWDJGOFVkZzZ0?=
 =?utf-8?B?cEZLME9VaHJoK3FLVEUwVEN2QTRVRThRNW1SQUVGYlFRZDQyVnVEc2tTc2Fp?=
 =?utf-8?B?YWdlZlRlSGRaZ3FwaUNPU3JuazlsNndsSzM1TjNCc0JHbXRSYlpSaUxRWVVK?=
 =?utf-8?B?M25RWjB5dlNwb09FTDRnYUplVzgwWG5GSTg2aXBRd0tsUkkrOFAvaEhGMG90?=
 =?utf-8?B?QnhkaW9nMHd0Rjl3allldzNZR3REdENkanZsWGNCeWRNOHVXNDhtN1JGSW5I?=
 =?utf-8?B?Y1hpcEVqMlBkUDl5NkJCaUNKdkk5a0N0QVhOb3FYNW4wTm0zcitHQ2c3b01E?=
 =?utf-8?B?M0M1aW1qQlVSNUhEM2o3OTM3NnUwTkVGWU04THR5MEoxQ1JoUHJXdEoxNldx?=
 =?utf-8?B?bzZ3Z0pXNjJUdE5lYjBOSktrRElTeHlHNnBHWkpodktnSEhWWTNWTkFUSEVE?=
 =?utf-8?B?S3BGcFlia3QrZFFMWlgwbWIwem95c0RMOUZudm5qNE8yMXFDVlZod25RZk9G?=
 =?utf-8?B?dG54YkxOREhEdWNEWEFQdEVmOEdTdlJmUjR2b3ZFUkVXRlErREhjeUo2VHpr?=
 =?utf-8?B?K3RoakQvQXFVczNDWUJpSkhpa3BidGJGWHJkVS9FcXE0d3VvNnd6eE51dlJ5?=
 =?utf-8?B?QWE1T1R2dXZab3hIbDhZU2FNQng0b1FETGxYVDQrZ01XRWtvUGNEeXk2TUN0?=
 =?utf-8?B?YkJaS3NlY2p0VFNwaCtzbmtwVHlQUHZYU1Q5djg3R1NTQlNrYjg3N3NCc08y?=
 =?utf-8?B?Yjc5UHpIWGJyNVZRSGJUSEtHOVpGT0pLdnErRUhKdDRxZXM5TENsYUdrMENh?=
 =?utf-8?B?OFRWNXNXZSt2UWJINXNrVlhRdmtyUHBiSW1SSDdIRHo2S0xNOVpibHc3NU44?=
 =?utf-8?B?TWVKeVFIZ3hFR3dHVVBOMVlwckpUTTZ4OHdGbHU2QnkrQmZlN2lUMjdWZVlF?=
 =?utf-8?B?T0NCL1prQ21sOFRMQXVpRExCdmNvZ3ZwL2tUcE45elVIOWpUZGJidEJCcjVv?=
 =?utf-8?B?ejU2dGxBSlFuUEdCakE3bEJVbjE1UThjcXB2V29VcE1PZVlWUzNRQUo5eHNx?=
 =?utf-8?B?dEZ6ZmNnR29xMUE0OTd1TWF3VXJwbGF3SE81ZTdPZFNiZCtIR210OUJ4SjBx?=
 =?utf-8?B?UFR6Snk4ajV3NFhMaEMzNVdOT0xQLzBoTXhLeS9RbDZHV3ZoajcyTW9LVUFV?=
 =?utf-8?B?cDB3RlVzdkFjUnN6QlJnbnFXOHZua3RPT1M2YlFwR1haY1IwNkw3OXEveU1p?=
 =?utf-8?B?STZ2YTY0YVdRN2JJTUdNRW1sNGJjbWtHNTdnUUwzM3YvS0lhTEhBbnprM2N1?=
 =?utf-8?B?c1FtM2NmTGtIdWhTNW50SmM2SzVqS2szYmtmdXJUVks2Zng5d2RTeGF4Q2Nz?=
 =?utf-8?B?Vys0SVMwK2U1Q1Y0ampselhWakJyTWVOZVdhN3RnNTRVVjRtdHpHb1JFTGxI?=
 =?utf-8?B?dHJaNEkyZ1NMYnV4alFlSFB0ZWh1TlBWaFo1aE1LOFY4THgxL0ZvcjA4OFEr?=
 =?utf-8?B?akUyeWkzbnE0SlFPbWdvYmtjMS90Yy9BVk02OTVrK3cyMjdjYVBGUms2SGpV?=
 =?utf-8?B?WjN6bTVQSU54dHp5T28xUEdFbWJlc2RqbWRrU0Fjb2lkUlhCdi9TME54cnIw?=
 =?utf-8?B?V1htZ0hxYm9ZbzFGc0FZWXBWMnJMcDZBTmhRQ25mL2p5VFJtUlA4b0h5Y3RQ?=
 =?utf-8?B?MGRhT0lmOVFJWlhVUE1wQ3ZhUER4MlV5TWxTYm15YWQ5SCt6Z0ZkcG42MFow?=
 =?utf-8?B?UWgwL1lJTDVEOFFXdFFUOURPaXNLSWtHWFpPU3VuN2JJZVIvcmUyV2dQNHBn?=
 =?utf-8?B?YnRCSmVkRXVOVnpYSUw2dTFCV0FwbVB1VmZvTUp2TzNwejdWb1RzZW5ud3FN?=
 =?utf-8?B?UlRHazRmV003Y3NURCtxcDhXYlJSUDhBWjhocnIrTEF4alp6WUx4QTFDNXVR?=
 =?utf-8?B?L3BWdUFLTXFPb2RQTElKYnhBSmRBQTJJR1JaRGIvNEYzVXd6VWJPT21md0Zk?=
 =?utf-8?Q?vwr12mSJ8CXZDyXrgvw0lng=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f922ffd4-8132-4aac-11e1-08d9ef9be5cd
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2022 09:25:10.5277
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DTMdktAVdtUzWkNAwAskxLRp3X4OBGh/tN6Sa7IEttAaQUfHkW5Qs3IG+VUpAF8EF66f7WbSsrS6sVsotzQHjQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5168

Use the original calibration against PIT only when the platform timer
is PIT. This implicitly excludes the "xen_guest" case from using the PIT
logic (init_pit() fails there, and as of 5e73b2594c54 ["x86/time: minor
adjustments to init_pit()"] using_pit also isn't being set too early
anymore), so the respective hack there can be dropped at the same time.
This also reduces calibration time from 100ms to 50ms, albeit this step
is being skipped as of 0731a56c7c72 ("x86/APIC: no need for timer
calibration when using TDT") anyway.

While re-indenting the PIT logic in calibrate_APIC_clock(), besides
adjusting style also switch around the 2nd TSC/TMCCT read pair, to match
the order of the 1st one, yielding more consistent deltas.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
Open-coding apic_read() in read_tmcct() isn't overly nice, but I wanted
to avoid x2apic_enabled being evaluated twice in close succession. (The
barrier is there just in case only anyway: While this RDMSR isn't
serializing, I'm unaware of any statement whether it can also be
executed speculatively, like RDTSC can.) An option might be to move the
function to apic.c such that it would also be used by
calibrate_APIC_clock().

Unlike the CPU frequencies enumerated in CPUID leaf 0x16 (which aren't
precise), using CPUID[0x15].ECX - if populated - may be an option to
skip calibration altogether. Iirc the value there is precise, but using
the systems I have easy access to I cannot verify this: In the sample
of three I have, none have ECX populated.

I wonder whether the secondary CPU freq measurement (used for display
purposes only) wouldn't better be dropped at this occasion.
---
v2: New.

--- a/xen/arch/x86/apic.c
+++ b/xen/arch/x86/apic.c
@@ -1182,20 +1182,6 @@ static void __init check_deadline_errata
            "please update microcode to version %#x (or later)\n", rev);
 }
 
-static void __init wait_tick_pvh(void)
-{
-    u64 lapse_ns = 1000000000ULL / HZ;
-    s_time_t start, curr_time;
-
-    start = NOW();
-
-    /* Won't wrap around */
-    do {
-        cpu_relax();
-        curr_time = NOW();
-    } while ( curr_time - start < lapse_ns );
-}
-
 /*
  * In this function we calibrate APIC bus clocks to the external
  * timer. Unfortunately we cannot use jiffies and the timer irq
@@ -1211,9 +1197,6 @@ static void __init wait_tick_pvh(void)
 
 static void __init calibrate_APIC_clock(void)
 {
-    unsigned long long t1, t2;
-    unsigned long tt1, tt2;
-    unsigned int i;
     unsigned long bus_freq; /* KAF: pointer-size avoids compile warns. */
     unsigned int bus_cycle; /* length of one bus cycle in pico-seconds */
 #define LOOPS_FRAC 10U      /* measure for one tenth of a second */
@@ -1226,39 +1209,38 @@ static void __init calibrate_APIC_clock(
      */
     __setup_APIC_LVTT(0xffffffff);
 
-    if ( !xen_guest )
+    bus_freq = calibrate_apic_timer();
+    if ( !bus_freq )
+    {
+        unsigned int i, tt1, tt2;
+        unsigned long t1, t2;
+
+        ASSERT(!xen_guest);
+
         /*
-         * The timer chip counts down to zero. Let's wait
-         * for a wraparound to start exact measurement:
-         * (the current tick might have been already half done)
+         * The timer chip counts down to zero. Let's wait for a wraparound to
+         * start exact measurement (the current tick might have been already
+         * half done):
          */
         wait_8254_wraparound();
-    else
-        wait_tick_pvh();
 
-    /*
-     * We wrapped around just now. Let's start:
-     */
-    t1 = rdtsc_ordered();
-    tt1 = apic_read(APIC_TMCCT);
+        /* We wrapped around just now. Let's start: */
+        t1 = rdtsc_ordered();
+        tt1 = apic_read(APIC_TMCCT);
 
-    /*
-     * Let's wait HZ / LOOPS_FRAC ticks:
-     */
-    for (i = 0; i < HZ / LOOPS_FRAC; i++)
-        if ( !xen_guest )
+        /* Let's wait HZ / LOOPS_FRAC ticks: */
+        for ( i = 0; i < HZ / LOOPS_FRAC; ++i )
             wait_8254_wraparound();
-        else
-            wait_tick_pvh();
 
-    tt2 = apic_read(APIC_TMCCT);
-    t2 = rdtsc_ordered();
+        t2 = rdtsc_ordered();
+        tt2 = apic_read(APIC_TMCCT);
 
-    bus_freq = (tt1 - tt2) * APIC_DIVISOR * LOOPS_FRAC;
+        bus_freq = (tt1 - tt2) * APIC_DIVISOR * LOOPS_FRAC;
 
-    apic_printk(APIC_VERBOSE, "..... CPU clock speed is %lu.%04lu MHz.\n",
-                ((unsigned long)(t2 - t1) * LOOPS_FRAC) / 1000000,
-                (((unsigned long)(t2 - t1) * LOOPS_FRAC) / 100) % 10000);
+        apic_printk(APIC_VERBOSE, "..... CPU clock speed is %lu.%04lu MHz.\n",
+                    ((t2 - t1) * LOOPS_FRAC) / 1000000,
+                    (((t2 - t1) * LOOPS_FRAC) / 100) % 10000);
+    }
 
     apic_printk(APIC_VERBOSE, "..... host bus clock speed is %ld.%04ld MHz.\n",
                 bus_freq / 1000000, (bus_freq / 100) % 10000);
--- a/xen/arch/x86/include/asm/apic.h
+++ b/xen/arch/x86/include/asm/apic.h
@@ -192,6 +192,8 @@ extern void record_boot_APIC_mode(void);
 extern enum apic_mode current_local_apic_mode(void);
 extern void check_for_unexpected_msi(unsigned int vector);
 
+uint64_t calibrate_apic_timer(void);
+
 extern void check_nmi_watchdog(void);
 
 extern unsigned int nmi_watchdog;
--- a/xen/arch/x86/time.c
+++ b/xen/arch/x86/time.c
@@ -26,6 +26,7 @@
 #include <xen/symbols.h>
 #include <xen/keyhandler.h>
 #include <xen/guest_access.h>
+#include <asm/apic.h>
 #include <asm/io.h>
 #include <asm/iocap.h>
 #include <asm/msr.h>
@@ -1004,6 +1005,78 @@ static u64 __init init_platform_timer(vo
     return rc;
 }
 
+static uint32_t __init read_tmcct(void)
+{
+    if ( x2apic_enabled )
+    {
+        alternative("lfence", "mfence", X86_FEATURE_MFENCE_RDTSC);
+        return apic_rdmsr(APIC_TMCCT);
+    }
+
+    return apic_mem_read(APIC_TMCCT);
+}
+
+static uint64_t __init read_pt_and_tmcct(uint32_t *tmcct)
+{
+    uint32_t tmcct_prev = *tmcct = read_tmcct(), tmcct_min = ~0;
+    uint64_t best = best;
+    unsigned int i;
+
+    for ( i = 0; ; ++i )
+    {
+        uint64_t pt = plt_src.read_counter();
+        uint32_t tmcct_cur = read_tmcct();
+        uint32_t tmcct_delta = tmcct_prev - tmcct_cur;
+
+        if ( tmcct_delta < tmcct_min )
+        {
+            tmcct_min = tmcct_delta;
+            *tmcct = tmcct_cur;
+            best = pt;
+        }
+        else if ( i > 2 )
+            break;
+
+        tmcct_prev = tmcct_cur;
+    }
+
+    return best;
+}
+
+uint64_t __init calibrate_apic_timer(void)
+{
+    uint32_t start, end;
+    uint64_t count = read_pt_and_tmcct(&start), elapsed;
+    uint64_t target = CALIBRATE_VALUE(plt_src.frequency), actual;
+    uint64_t mask = (uint64_t)~0 >> (64 - plt_src.counter_bits);
+
+    /*
+     * PIT cannot be used here as it requires the timer interrupt to maintain
+     * its 32-bit software counter, yet here we run with IRQs disabled.
+     */
+    if ( using_pit )
+        return 0;
+
+    while ( ((plt_src.read_counter() - count) & mask) < target )
+        continue;
+
+    actual = read_pt_and_tmcct(&end) - count;
+    elapsed = start - end;
+
+    if ( likely(actual > target) )
+    {
+        /* See the comment in calibrate_tsc(). */
+        while ( unlikely(actual > (uint32_t)actual) )
+        {
+            actual >>= 1;
+            target >>= 1;
+        }
+        elapsed = muldiv64(elapsed, target, actual);
+    }
+
+    return elapsed * CALIBRATE_FRAC;
+}
+
 u64 stime2tsc(s_time_t stime)
 {
     struct cpu_time *t;



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 09:25:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 09:25:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271291.465697 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJXbz-0004aA-LR; Mon, 14 Feb 2022 09:25:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271291.465697; Mon, 14 Feb 2022 09:25:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJXbz-0004Zb-Hv; Mon, 14 Feb 2022 09:25:35 +0000
Received: by outflank-mailman (input) for mailman id 271291;
 Mon, 14 Feb 2022 09:25:34 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KkXt=S5=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nJXbx-00043T-S7
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 09:25:33 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0cc35a1a-8d78-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 10:25:29 +0100 (CET)
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur02lp2056.outbound.protection.outlook.com [104.47.5.56]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-10-GuhDHtz2NK2pHNWIx8v9mg-1; Mon, 14 Feb 2022 10:25:31 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5168.eurprd04.prod.outlook.com (2603:10a6:803:56::33)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.18; Mon, 14 Feb
 2022 09:25:30 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4975.015; Mon, 14 Feb 2022
 09:25:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0cc35a1a-8d78-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644830733;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=O+QV9f4zvS046E/T2Qkac91dJy0u0hz2Q9q4aDSre0U=;
	b=N+jjAsKrxPQk7f04yzErt10ld9LTyUNC+CdnA4oKjMeheu8qAnKuYUmahqv4QmFkERtvjh
	kWbWw7KgQydCVmxJzJ/MCVZlEL12yGTnjiYphGQfSK83SLz7Osji1mXdb56ADr8fIaUlPl
	lQMVNPkUqwxk9wCTbaKaRywhwPiBg20=
X-MC-Unique: GuhDHtz2NK2pHNWIx8v9mg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=NmsxkszlYhy9rfK5pTW28fFHhpMd0i6AoM1UXVRopzgF7syyUC1934kuiF+UpCyP5UDWAgZfqoRMsWgTg1lBqNzJbAgAudbwNyqrfU3Xu1zmuj61toRonZ0s12QLnidebIRucvN/L8riM7XgVo8Td75i0n6gLK1bKu22dzNISUlBpm1ZzYDTnI12/6noXEm0gddq8skXBLLnNJVglav/E6XNjJ7Lw0zKT1Ez8JUu9L9RLzjAqEAz/FgGm0yEClLAbGe/iiPY09LpM5ZQzoGqVzmc7RCqXlD696ABxMl/C9Fh8HHxu9H4ZgD3ZbvLV46dEHL+1SEa2YBLSQltHjaEEQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=O+QV9f4zvS046E/T2Qkac91dJy0u0hz2Q9q4aDSre0U=;
 b=KfutONe6ZQ8QBqcd0ReSkeFI54gpCk4BVW+Dvn8SSeh2vdOmq10wI6IFSDTmjAA5Czw64VcxFTqNcV1SsrCOi1OQfIaCUMpA4R5UqKCCWpd6NZ6cyTEtHdSFbpEW+GdnHj9Xk0/wCXKYoi7omNQolZCtoT/9hJZrtqff7R7Q6a+qJqCzyt7Dd5XQktq2B31KHDLp+PsTu2fbQ1JBkkMWRu0Dygi9AKI6oL66uo65PQE9uxKKhPv0Ay7vIIkxrd3AjlPBP3XapV8DvMWbRP44r3lFhT+94d8fqi31+hcxrDuMy916Dfk3xw575fzXK4LrcAN1yU3SL9nOgSZTUcVUCQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <c679a11a-d2b5-403a-5341-3e00ac91ff45@suse.com>
Date: Mon, 14 Feb 2022 10:25:31 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: [PATCH v3 3/4] x86/APIC: skip unnecessary parts of
 __setup_APIC_LVTT()
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <35cb3c72-05ba-24c7-1fdd-3ee1aced3aec@suse.com>
In-Reply-To: <35cb3c72-05ba-24c7-1fdd-3ee1aced3aec@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0125.eurprd04.prod.outlook.com
 (2603:10a6:20b:127::10) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 6c447af9-bff8-4182-a35a-08d9ef9bf1b8
X-MS-TrafficTypeDiagnostic: VI1PR04MB5168:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB516854A429E7B2DCD673BF72B3339@VI1PR04MB5168.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5236;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	BF58ZCy2mrVZd/TySIs1MooX5HdVPTPsrTfAQgyWDd+NmvD7jVjw7rKng8kkpbowlmuMrIHqap44KKLJZNwTN7ApD4r7RN/vcFaEMZ6nJoAnhDXCI02DCv48QAlr5hFiXk+noeTLszOslzjKVtshP6Gk1MytEVKIFoJTYD2BP3sbPcC550RDXJm7fg/FPxDV73BTj6nZy1CqTD96ajF1xKZ+PcgYIZUXrv36GBvh80kw9JVTn5gKj9COdcHuZC4VRq1MI8xwL8vXSzAZ4G2BNYidYHHbn/bCW/rf/B8wsv1wMLW7QtgNCX4Bs3Rfq0f/4SNDNudztUcPtf30jM7aWdBJ0I66cFNLLkJhoywHygKSvGzCVUsldPwrEm7yc1lYzwrvB/YglBRHEAVS/Vffj2Z7xinPAQsQcRDxOPhqz8huR5WfBR4ov1F+sa+XBDOAaodCr/K6C8ta7K/Vje/Il5nuFyUJmp38Mp5agnkvabnXl+5lq5TI/6MBeT5+rYZH3RqdVn9yP3nAAqrqjiWWr2k3Zplbtblesp9lV+SbpdgN15inAuSx+wwGO5FQFj5wKbG0Y30bpAohS1K3J7wu7AlxLML609/brBc0Qbk79Y+V9BLZlJ34hCQ3S8OfC4hQK374rxsGfsoFElFzt9KYWpDHV4GtuswMpVOZISIg/lrmRzjMRs5b7Fzjy60FYk0JGYv9Y5MV2/03uNfabyb0vKjEHNyZNgoAn1IDre2eYGpX/ON1o6nBG0261f021B8n
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(36756003)(316002)(38100700002)(6916009)(31686004)(66556008)(66476007)(5660300002)(86362001)(54906003)(4326008)(8676002)(6486002)(508600001)(31696002)(26005)(2616005)(2906002)(8936002)(66946007)(186003)(6512007)(6506007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Y2dNQnVvVCtPUzJxS2cwb3N2alJDMVIzOUl0TUlBdXlCcm1VOFI0c1FzUFJm?=
 =?utf-8?B?Wko3d2wzSzhNYXh0WTBabFNxbFNtK3FTMXVkQlJtL0F0QlVLQm0vYkUydnIy?=
 =?utf-8?B?QVVTSnYyOUJoLzRUaStZUCtRcFh3ZXRxSDJPMjJXbkVaY2dvTmFXU3RRd1Y0?=
 =?utf-8?B?Yk42cVVaODVPTEZORTJRdkVjTzdNUVdxS3IxYlFPditYUkZrNUhUd0h4bEJ2?=
 =?utf-8?B?VHF4ajhlZ3g3WFpzM3Qxb1lTVlNKZkZzMVlBYlEyVEdGUjYwVFR6bHpCenc4?=
 =?utf-8?B?RitOd1p1Q0xhbkNFQnJGVVd4bi9rbzIzamw0NXI5K1NDbGloalQ2S0ppeTk1?=
 =?utf-8?B?bzBYYW8rWW9KTm5TSWxYa2g3c0IrbmYzQ01rd3ZvVGRtU0Z3THhBdXBhcE1E?=
 =?utf-8?B?VWNXZU5pa0FaTmNuZmx5cXhndGpFN2FnVWJMUzE0dDVaSS9PS2I1MHVvcjJw?=
 =?utf-8?B?eG1aQy9uYVprSzgzUUpaM0MxdUgvSitZZC9ocndVUS9GOEMxaUV6TkR6d2pO?=
 =?utf-8?B?NExOMXZlMjFvdXRWUW1YMDdFeXVJYkFIMnZwcEhtekVPcjJndWxDNWpEcVlK?=
 =?utf-8?B?L2FhMlE3MHdTWTBTdllYTHFlZ2pwcUFsS1J3NW1yWjhNdlpIT0pDT2ZaNFhS?=
 =?utf-8?B?OXZsRFNBK1dOYnZaVmhtSGF6d3VadUlqNThGV3JGenZNVHk1UXFIa1kydHhT?=
 =?utf-8?B?Y1h3U3p6UWhnaWZ2WjY1SmNDd0I1eTZiK0xQZ2ZOT3Uwa1JCOGlPN1haSmFN?=
 =?utf-8?B?b1BSOVNkdElhMk43YnN6T0xtYitTbmtVNHI5RWZZQkFYdlV2VDB0dDBndGFQ?=
 =?utf-8?B?OStVd01JVyt5SndyVXphbVZrdjNvOStSeFZJdGRDbWxxazV0dHJJTnQzaXdH?=
 =?utf-8?B?aXJZQTZVMm5IQ1pYQnptbDc4MlpxcmNSS1RrbENyYmlDc2RrRklzZ3NsdGZW?=
 =?utf-8?B?ZkxUMi92ditEM2FwMTFIRi8vT2FhcmZrZUxPaStBN2RSMlB4b3JweDJ2T3RZ?=
 =?utf-8?B?WjFpd3RsTkZhdXEvM0t1SGJyakVwb25VeENHSld1NGZpVW1LeDFhNGRPR2sw?=
 =?utf-8?B?blA0QW9WK2Y3ODNEa211NStIUkgvdHFKdXNjT2FFRnN2MHNHMlp6UVNqeUZC?=
 =?utf-8?B?TWhSQ08yOXU0R0U1dDJyRGNjUThPQ2Q4WSt5MElocGU5K2FVemxKYnk1WU1N?=
 =?utf-8?B?aTRHSFAzREtuWWRsR3JoaXh6TUVVaU5IcHF1NkRYTW9qTitBL1NWSDNLV2E1?=
 =?utf-8?B?WXN3cm9UNFlBay9oVmRPMmdzT2JFRXFkTGthK2ZyYjcwRTZIVDlZUjNFOFJX?=
 =?utf-8?B?VmJMcXdwVzRnV3hxb1RmOHYvKy9QQVJCeGdYRHBXb2RGczZFcDgrMUkxT1ZH?=
 =?utf-8?B?MlFnV1ltdXZJMUwwWlYvTEI1WEJLZ2I1NmY1ZUZxNi9TMXJ2REVnQnRiN0Vk?=
 =?utf-8?B?M1Ixd1d5d3hXMkdkQXBaNXV5QWdFNDR1LzRwN3I0YTg2WUdHWUVsM2lsWEJh?=
 =?utf-8?B?L0F0R3Q3Rm05SmlmNDZTTy9Ha1phbFk5bitUVERLQkhYTmZLZHZnWXJENUto?=
 =?utf-8?B?clRuUzlpd3poVXg1SFZFeFB2U0FRRTZGKzhQMGkzK0FRUUF5MEYySGl0d3Yv?=
 =?utf-8?B?ZFBxeVBOdGxrNThNcHpTYXdQbmI4dnlHbHZjL2g1RElwTnhQbWRaZXpuM1l6?=
 =?utf-8?B?YjNySGZpeDdjU3l5RzJZNGlzZzRvb0J5UVZYMDNpdU9vODE0SDJEeDFRN3JO?=
 =?utf-8?B?WkNtQ2prVi8zNkNrTVEyaitidGJQRnhCTUFjQ25ZNGY5NTZET2pyWkUwNkJR?=
 =?utf-8?B?c24rYWkxWmQ0QkRoanlQNXdMMzFzZ212ejhaRmQ2c1R2d3dTWnNCOUxPQUo2?=
 =?utf-8?B?aTJSdk05Qm0rb2VER0pnQlp6ZGZBZXE0RSt2dmpDOG5tQWZQa05ORWJLcDEv?=
 =?utf-8?B?eWtzWHBmOHlJeEV1KytFRXZ3Q05US09CVnJUZTNtbEFoa0U4V3IwY2hiZlcw?=
 =?utf-8?B?clN1TGViRnNKWlNzKzY1eWtFMnFXcndWelFQNDR0UGNNaEthRkk0YnM4eTN5?=
 =?utf-8?B?Y2RidnovUXE2bzhIeCtPMy96dytJQzZWYzVEYTdNNnRjTkp5THMwMXBYK2Zy?=
 =?utf-8?B?TnlZeEpBOXlmQlFockFQSk45TTNmVlhrMEhudTlHcEFkRmFvZDlESDZnM1hs?=
 =?utf-8?Q?hl2dRG+KZtxZdntm+IpO4kE=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6c447af9-bff8-4182-a35a-08d9ef9bf1b8
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2022 09:25:30.6202
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AKz6K/yInSzvCMCOegjV14k5CrxAh3N/Wq3em6a+ELqHlNs9BPO0nZQgtZmIPXGxsQhdfMJR9eP+wvNuLzhf8g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5168

In TDT mode there's no point writing TDCR or TMICT, while outside of
that mode there's no need for the MFENCE.

No change intended to overall functioning.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
v2: New.

--- a/xen/arch/x86/apic.c
+++ b/xen/arch/x86/apic.c
@@ -1059,24 +1059,25 @@ static void __setup_APIC_LVTT(unsigned i
 {
     unsigned int lvtt_value, tmp_value;
 
-    /* NB. Xen uses local APIC timer in one-shot mode. */
-    lvtt_value = /*APIC_TIMER_MODE_PERIODIC |*/ LOCAL_TIMER_VECTOR;
-
     if ( tdt_enabled )
     {
-        lvtt_value &= (~APIC_TIMER_MODE_MASK);
-        lvtt_value |= APIC_TIMER_MODE_TSC_DEADLINE;
+        lvtt_value = APIC_TIMER_MODE_TSC_DEADLINE | LOCAL_TIMER_VECTOR;
+        apic_write(APIC_LVTT, lvtt_value);
+
+        /*
+         * See Intel SDM: TSC-Deadline Mode chapter. In xAPIC mode,
+         * writing to the APIC LVTT and TSC_DEADLINE MSR isn't serialized.
+         * According to Intel, MFENCE can do the serialization here.
+         */
+        asm volatile( "mfence" : : : "memory" );
+
+        return;
     }
 
+    /* NB. Xen uses local APIC timer in one-shot mode. */
+    lvtt_value = /*APIC_TIMER_MODE_PERIODIC |*/ LOCAL_TIMER_VECTOR;
     apic_write(APIC_LVTT, lvtt_value);
 
-    /*
-     * See Intel SDM: TSC-Deadline Mode chapter. In xAPIC mode,
-     * writing to the APIC LVTT and TSC_DEADLINE MSR isn't serialized.
-     * According to Intel, MFENCE can do the serialization here.
-     */
-    asm volatile( "mfence" : : : "memory" );
-
     tmp_value = apic_read(APIC_TDCR);
     apic_write(APIC_TDCR, tmp_value | APIC_TDR_DIV_1);
 



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 09:26:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 09:26:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271299.465708 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJXcP-0005Dn-Vy; Mon, 14 Feb 2022 09:26:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271299.465708; Mon, 14 Feb 2022 09:26:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJXcP-0005Dg-S3; Mon, 14 Feb 2022 09:26:01 +0000
Received: by outflank-mailman (input) for mailman id 271299;
 Mon, 14 Feb 2022 09:26:00 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KkXt=S5=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nJXcO-00043T-7o
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 09:26:00 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1c6b6420-8d78-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 10:25:55 +0100 (CET)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2107.outbound.protection.outlook.com [104.47.17.107]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-37-44xOc3-cNESaSOgGW-xH_Q-1; Mon, 14 Feb 2022 10:25:58 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM0PR04MB5522.eurprd04.prod.outlook.com (2603:10a6:208:116::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.18; Mon, 14 Feb
 2022 09:25:56 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4975.015; Mon, 14 Feb 2022
 09:25:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1c6b6420-8d78-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644830759;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=UMb8XxBGQTglh7QS0g0uFzDDbX+ZM/GP4Y8wGvBBNIg=;
	b=mRdAclEOr//rEAsbA5nW6vo6WGZ2K0Mtmi0xj6pSgO5ovwU+SOeW2clKxIqetaZvEP+z07
	0otW1HStR8JQWWyp/mWnAsrSS3oa3Bx0VaE5rkVuq/ZCw+OQtY1DVDTIv34Imyo0rbbNYW
	mFPRCjz/KEJWVBpMEejNqdSUYNGP1eA=
X-MC-Unique: 44xOc3-cNESaSOgGW-xH_Q-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=h2lIMcFN/Xk1/EWFHbeENn5NOo8ur8Q/hwxL9PUUxZsKWoUoumgCEC0USv578EU4oP6xtkfpVewigMenXqZ0oxNZXI+n3zH03r1HkEfGUCZzxHKqdw5cijhj6J4nvNkdK4mto6DFR4EtfRN8RFcuOshYK73Cgl+ohNY3TrUiuaTJSLBWQcspkmKHV6kbTtRjRxsauuU21U2Ok+fah3nOB8QqYDDuT69JEMOUZAbRfdsfa9aOhdoWEjt2l2bPTIqntb6SBV9aO+Fb7UeBeDvGdVyfYugtQi6vv7pjQYuRa770Ta6hsFwk12dD+vZZ4W37bLh01AHmWsvQpqecq90IgQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=UMb8XxBGQTglh7QS0g0uFzDDbX+ZM/GP4Y8wGvBBNIg=;
 b=TUitKUC7TY2iXqruTsb5cNw8Z9W5KyyNJ7FYo71aedaQR+xlcqsAuGMyvfpx5H7ZkYPE7LTboLOHc6nVgPIAJzJstQfAn/i9401hDdxHLO01m+1g0T5ocJVyGe3i+wbPgKK8Ziy5lfHLUTpt5RUyTjh4be2h9gJcuyvcyS8oUYQmjW7MlQXP8g0nQBN+shcIqE0yKdOfcYGgM4VkAfkkaeaGnkrQx/AJ/g2qeQQA0wxC0VYgdYJ/rsSZ2SrjxobxVEnvB1WTh6HoStyyRJ3EWy0shUY3+7eTbP1WwtrGbxabQ10eLPuT1sam6d3LFACnmylPdbHDv4E+CxzDSaEdJQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <123a9ae8-caab-01ae-5bea-8c590bd8f9d9@suse.com>
Date: Mon, 14 Feb 2022 10:25:57 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: [PATCH v3 4/4] x86/APIC: make connections between seemingly arbitrary
 numbers
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <35cb3c72-05ba-24c7-1fdd-3ee1aced3aec@suse.com>
In-Reply-To: <35cb3c72-05ba-24c7-1fdd-3ee1aced3aec@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0021.eurprd06.prod.outlook.com
 (2603:10a6:20b:462::27) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a71eb634-5e70-4ede-25e7-08d9ef9c010f
X-MS-TrafficTypeDiagnostic: AM0PR04MB5522:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB55220C3E8B672B7C0D4A1375B3339@AM0PR04MB5522.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:913;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	kswmukf+cs3lUe73hJqwM7zK573UjtjOyK3XOdlQncPof+NAghW8VsVwDhci2KFalTP8uKZTUQsrPLIXMhGmjb+dHn4JTSenENCVw1LhS/2+MaXjB2dghW6gWOBVIjLxlFP9BkTeOgihnVQyUdZyMZxQBWQQu0QTeUJ7Vn/KzWXlq7inGRY+3xn6SmMZ2zRA9ahh/HNPwj8o0YVsehdfsEQSPCzkrHlazzOzjUixmwKyKttP3HPEzujppX4AEcygrjIxK0rhLbLkySs3eqqyhnIj4Oj7CBHb4w5GDTyD00VI6pJUuFV8WbngmAuzr4SRQa6XFdC0fzSM1zjvUfN5OsXTDoEOTV5KQMm5pkfG++m3kRcLWX+Ak7H8jmecsveaI9eOXWqdCDjLFJglJsHO7i9Lp8JJUKXAeCVMUSTfjmrEFnmCihOsCn4ErYHOw+NRhMjslZtBCUUCroG5kRfM0SDbndKeAmoB34zVqZTXhqm8cegEHZCiJNivFBLiqPSgpchRX7aCM4sftH8af6ifHI4FUNW/rC6Y2JyIcyoiGIss4C+gd5FJlMZzsnmSkbowEolJwnFKY1Omzxum9vUYRMKAOK3qR4WQgaIBoffSzsQ2wBubqs53+xRTJ3YMCnSNSKoBsj5p/bLYOB9lx/TItAu/ZeTEuxpVdzZWM0i6Asd8SVAVOSWMA/qTdQiHf7E/uS+R7UWSz1qLSx/eaRc4WxeJvU0HVZsQHCvmPKJmWETXTJRhsa6U8hjG9uHrRLqK
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66556008)(66946007)(8676002)(66476007)(4326008)(2616005)(2906002)(6506007)(38100700002)(8936002)(6512007)(5660300002)(6916009)(54906003)(83380400001)(186003)(26005)(31696002)(36756003)(6486002)(31686004)(86362001)(508600001)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?eHN1Q2htMTd1YitpalFCejJ3UDc2ZjBOYk5YSmgyWGY5bmdBS2V1c2Y2T3FY?=
 =?utf-8?B?LzdTc3FHWWlHTXFSeUJ1VGtnNm1acVlndmpiQlB1T2Fzdng2WTZTMWVvYkpq?=
 =?utf-8?B?enZ0TXErTlFxZEt5emtVeVBndlB1THJpMTBhTCtPZjNkS0l0a3hTTGZtREZy?=
 =?utf-8?B?MzV3Qlc5bVJ2U2s4K0ZTMnJKNVFIMktHT2dQbjZpUFFwR0JrTWVpcFMyTGRu?=
 =?utf-8?B?MlRWc0ZkelZJUEFOZ3ZlUEorVElrTE1tZWRsSndLbEsvdWpsVXRFbEp4K3VK?=
 =?utf-8?B?VzhnSzBTUHVZT00vYUFJSnlHTXVwRnlwSDJ2U1NWVXhiTytyMHBDOTFzdHFJ?=
 =?utf-8?B?ek0xT2wyNzk2Z0RnZDdqaHFxdlorc0xLRnVVRk9Da3htVVVnaE1KZEF1UHMy?=
 =?utf-8?B?d0wrZEs3VzZoZnNiSmhNc2s3RUl3S2Zkdy9haC9FU05SZ0R4SDI4Yko4Szg4?=
 =?utf-8?B?ejFpUmx6L1FHUW1lNm43NXBxbW5aYU9vaEdEL2M3aWZWZXEzcklIOVBqT2lu?=
 =?utf-8?B?U0syOHBWU092eURBNVF4NVVmcUxnbkVtRWRyRWFHQXdpY2lpdUdTRmRlMzFm?=
 =?utf-8?B?UDhvYWoyMzc2dG91eVl4dzhJdTJJNVBoaXFTcHNsQndXN3FuQ3dCN2dweVU2?=
 =?utf-8?B?RTEzNnl0eFRNQThEYVBqckFVU0ZRaHIzY3RoYnFZQzFqV0VKN1pzZXNIU3JY?=
 =?utf-8?B?U045NVpQbFA5aDJoR1NyYStEbmlRS2xIOENQWmQ1RE5vMEx2bWVSbXRzckdH?=
 =?utf-8?B?TjlId3F6Sys4UDRVRHN0NEU2Nm5weG96QWZTeTgrU3VzemxUVjNuejZLU01i?=
 =?utf-8?B?d2gxak5lOGZDS1dFNjZxRGVSK2ZPckhRcEhJOHFVNEYyVVk4R1g2S1lMM0FR?=
 =?utf-8?B?M2ZZQjJrWWNPd1c0R2hLdDhhVmNXU1QxMzVWdHZvMGdQbURpa2dUZFhFcFRC?=
 =?utf-8?B?TmZaOXZYN0svL0tzS0trQmVjNXIydlVqckZiUlkra0RHaStKbk9NVjhraXlj?=
 =?utf-8?B?eWZlSEZZY01RTUdSR3VtTktyLy9mMFpMZElEZ0ZqSlFIODlkb0w0eFNCNVY1?=
 =?utf-8?B?bTZBN3E4dDJCbEQ1VmRuc0lta0pFQ243SUE2Mllvd0pkeXR5UGsxZ2RjeDVw?=
 =?utf-8?B?N3lwZUxWRGZnR0lydk9kZW1nTVVIT3VPalptVElab2hnWk1PcFh4eVQ2dVVz?=
 =?utf-8?B?RDQzNE1YbGE4dnRweHNadHdFZWtyeFdVekVyUFk1R05uMmdYOTBkUFlhVXJp?=
 =?utf-8?B?bTR4OHRVZmY2bytydjlkWXFzcHlYdzlFWjFVOWNFOHliaFJuMmVhWlFrbzU4?=
 =?utf-8?B?Zm5sZGdrT3pRSUtFMFRZYkwraHRFNTlMaWV0NU1EOVJnb0tCdkE5eVhzam9p?=
 =?utf-8?B?TzQrRytmU2pSNmZ6d081RERYcXhpdnJoY1BjWUhLRWZ3bE0va0RwWXB4WXZT?=
 =?utf-8?B?RWJsMEJ3N2xRVUNiY1lEbHBOVW1ZSWtqYTl4QXcxUHJBYXdzaERpZWNZNXdk?=
 =?utf-8?B?aG00NDBEdVB6MFZLbksvRjRhU0Q1TlNiRzRFY2o1NEMreUdFRjFlcm84OTdJ?=
 =?utf-8?B?M1VhdHh5UVVMbjExd1p4MmpraFN2WmFOYTNkVmNscEFJZ2gyNVkyWnd1L0NX?=
 =?utf-8?B?OHZMc3I5cDFnWm9md0tWVlp2REp4VGlvS1RzemVvaDN2K2xUeVpLVUFBeFly?=
 =?utf-8?B?blBuTkRnLzVqcHRWbmRkVnlyd3pPZXdZTWlpdFNmYk1nOE05N3dQWld5SktW?=
 =?utf-8?B?VE02K3VMNkV4bGx4c2VLelVuQjhzY3ZTaFZZaUI5R3h3WGtGcGpVaXJqOEV5?=
 =?utf-8?B?V0FmWE16MGVlTnE2cjJKRjUyUnpxK1RVQ1BxL0JzeWF4VVdZeUlrejZEQUFX?=
 =?utf-8?B?UlRFbXFHUmRNQnkxU2ZhS0lDYUN5RVI5Q2w5Z2FsckhGUGMxeG5oU0N0Wng4?=
 =?utf-8?B?anFVMTdMbGtMVGVhY2kxd0hHSGhkRXg0NEl3ZE02clhwcnJRSjBwVVhTTFc0?=
 =?utf-8?B?ajkxM3ZnbVRBK1NRdzVYaG1BVHBmbms4MGI1ckxLS2RPdHJrNlNQTkNKYk5W?=
 =?utf-8?B?RXRPSm1MZ1NpRWx0Qmh4V24yelJycjJsR3F0OHJlYzVvYkZHOUxiZWZuamxG?=
 =?utf-8?B?S01weFdCVnFMbGpvSEJPWGxQZ00yOG01Z0l5ZmFSNEM4UlhGbkM3bGwza2VN?=
 =?utf-8?Q?o45Xs/x/i7IqzxoPOXjBp0w=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a71eb634-5e70-4ede-25e7-08d9ef9c010f
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2022 09:25:56.2592
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QfCXRqUmHuKmIHXDpbd9qz9DH02FHdx+3RNSlbt9rIpUkd6DuE2AhkmiXySJCj5LLuI3nWshpXgVQyUIFhTCGw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5522

Making adjustments to arbitrarily chosen values shouldn't require
auditing the code for possible derived numbers - such a change should
be doable in a single place, having an effect on all code depending on
that choice.

For one make the TDCR write actually use APIC_DIVISOR. With the
necessary mask constant introduced, also use that in vLAPIC code. While
introducing the constant, drop APIC_TDR_DIV_TMBASE: The bit has been
undefined in halfway recent SDM and PM versions.

And then introduce a constant tying together the scale used when
converting nanoseconds to bus clocks.

No functional change intended.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
I thought we have a generic "glue" macro, but I couldn't find one. Hence
I'm (ab)using _AC().
---
v2: New.

--- a/xen/arch/x86/apic.c
+++ b/xen/arch/x86/apic.c
@@ -1078,8 +1078,8 @@ static void __setup_APIC_LVTT(unsigned i
     lvtt_value = /*APIC_TIMER_MODE_PERIODIC |*/ LOCAL_TIMER_VECTOR;
     apic_write(APIC_LVTT, lvtt_value);
 
-    tmp_value = apic_read(APIC_TDCR);
-    apic_write(APIC_TDCR, tmp_value | APIC_TDR_DIV_1);
+    tmp_value = apic_read(APIC_TDCR) & ~APIC_TDR_DIV_MASK;
+    apic_write(APIC_TDCR, tmp_value | _AC(APIC_TDR_DIV_, APIC_DIVISOR));
 
     apic_write(APIC_TMICT, clocks / APIC_DIVISOR);
 }
@@ -1196,6 +1196,8 @@ static void __init check_deadline_errata
  * APIC irq that way.
  */
 
+#define BUS_SCALE_SHIFT 18
+
 static void __init calibrate_APIC_clock(void)
 {
     unsigned long bus_freq; /* KAF: pointer-size avoids compile warns. */
@@ -1249,8 +1251,8 @@ static void __init calibrate_APIC_clock(
     /* set up multipliers for accurate timer code */
     bus_cycle  = 1000000000000UL / bus_freq; /* in pico seconds */
     bus_cycle += (1000000000000UL % bus_freq) * 2 > bus_freq;
-    bus_scale  = (1000*262144)/bus_cycle;
-    bus_scale += ((1000 * 262144) % bus_cycle) * 2 > bus_cycle;
+    bus_scale  = (1000 << BUS_SCALE_SHIFT) / bus_cycle;
+    bus_scale += ((1000 << BUS_SCALE_SHIFT) % bus_cycle) * 2 > bus_cycle;
 
     apic_printk(APIC_VERBOSE, "..... bus_scale = %#x\n", bus_scale);
     /* reset APIC to zero timeout value */
@@ -1337,7 +1339,8 @@ int reprogram_timer(s_time_t timeout)
     }
 
     if ( timeout && ((expire = timeout - NOW()) > 0) )
-        apic_tmict = min_t(u64, (bus_scale * expire) >> 18, UINT_MAX);
+        apic_tmict = min_t(uint64_t, (bus_scale * expire) >> BUS_SCALE_SHIFT,
+                           UINT32_MAX);
 
     apic_write(APIC_TMICT, (unsigned long)apic_tmict);
 
--- a/xen/arch/x86/hvm/vlapic.c
+++ b/xen/arch/x86/hvm/vlapic.c
@@ -580,7 +580,7 @@ static uint32_t vlapic_get_tmcct(const s
 static void vlapic_set_tdcr(struct vlapic *vlapic, unsigned int val)
 {
     /* Only bits 0, 1 and 3 are settable; others are MBZ. */
-    val &= 0xb;
+    val &= APIC_TDR_DIV_MASK;
     vlapic_set_reg(vlapic, APIC_TDCR, val);
 
     /* Update the demangled hw.timer_divisor. */
@@ -887,7 +887,7 @@ void vlapic_reg_write(struct vcpu *v, un
     {
         uint32_t current_divisor = vlapic->hw.timer_divisor;
 
-        vlapic_set_tdcr(vlapic, val & 0xb);
+        vlapic_set_tdcr(vlapic, val);
 
         vlapic_update_timer(vlapic, vlapic_get_reg(vlapic, APIC_LVTT), false,
                             current_divisor);
@@ -1019,7 +1019,7 @@ int guest_wrmsr_x2apic(struct vcpu *v, u
         break;
 
     case APIC_TDCR:
-        if ( msr_content & ~APIC_TDR_DIV_1 )
+        if ( msr_content & ~APIC_TDR_DIV_MASK )
             return X86EMUL_EXCEPTION;
         break;
 
--- a/xen/arch/x86/include/asm/apicdef.h
+++ b/xen/arch/x86/include/asm/apicdef.h
@@ -106,7 +106,7 @@
 #define		APIC_TMICT	0x380
 #define		APIC_TMCCT	0x390
 #define		APIC_TDCR	0x3E0
-#define			APIC_TDR_DIV_TMBASE	(1<<2)
+#define			APIC_TDR_DIV_MASK	0xB
 #define			APIC_TDR_DIV_1		0xB
 #define			APIC_TDR_DIV_2		0x0
 #define			APIC_TDR_DIV_4		0x1



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 09:27:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 09:27:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271314.465719 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJXdt-00062M-G1; Mon, 14 Feb 2022 09:27:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271314.465719; Mon, 14 Feb 2022 09:27:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJXdt-00062F-CR; Mon, 14 Feb 2022 09:27:33 +0000
Received: by outflank-mailman (input) for mailman id 271314;
 Mon, 14 Feb 2022 09:27:31 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJXdr-00061y-Jr; Mon, 14 Feb 2022 09:27:31 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJXdr-0000Uw-Fz; Mon, 14 Feb 2022 09:27:31 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJXdq-0004hG-V9; Mon, 14 Feb 2022 09:27:31 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nJXdq-0007iQ-Uf; Mon, 14 Feb 2022 09:27:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=er5C+UBdpqlKgl4wwh8S4aRnVKfr85u8503Eh/ThHCk=; b=oKvqUpwjZbg9ptGfLKXaeejRCz
	ProD0wEjcE5qQdbIniw6cvGTjltrvw24WNsRVGFVlY2NsJUsRlpP5+PKNJjHscnrZLn5zIeXzdsNK
	Iwb/R1jcX6IwZyGfuj66n2VBUROD9f6qFgTLgu+zsf85siXhp2gvdhnMpnbX3dJAKGis=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168107-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 168107: regressions - trouble: blocked/broken/fail/pass
X-Osstest-Failures:
    libvirt:build-arm64:<job status>:broken:regression
    libvirt:build-arm64-pvops:<job status>:broken:regression
    libvirt:build-arm64-xsm:<job status>:broken:regression
    libvirt:build-arm64-pvops:host-install(4):broken:regression
    libvirt:build-arm64:host-install(4):broken:regression
    libvirt:build-arm64-xsm:host-install(4):broken:regression
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=6ccafcb53e2bdf50695c151cf768a36fc5697bab
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 14 Feb 2022 09:27:30 +0000

flight 168107 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168107/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-arm64                     <job status>                 broken
 build-arm64-pvops               <job status>                 broken
 build-arm64-xsm                 <job status>                 broken
 build-arm64-pvops             4 host-install(4)        broken REGR. vs. 151777
 build-arm64                   4 host-install(4)        broken REGR. vs. 151777
 build-arm64-xsm               4 host-install(4)        broken REGR. vs. 151777
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 build-arm64-libvirt           1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              6ccafcb53e2bdf50695c151cf768a36fc5697bab
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  584 days
Failing since        151818  2020-07-11 04:18:52 Z  583 days  565 attempts
Testing same since   168090  2022-02-12 04:18:54 Z    2 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brad Laue <brad@brad-x.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Christophe Fergeau <cfergeau@redhat.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Divya Garg <divya.garg@nutanix.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Emilio Herrera <ehespinosa57@gmail.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Ivan Teterevkov <ivan.teterevkov@nutanix.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jing Qi <jinqi@redhat.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Lubomir Rintel <lkundrak@v3.sk>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nicolas Lécureuil <neoclust@mageia.org>
  Nicolas Lécureuil <nicolas.lecureuil@siveo.net>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Rohit Kumar <rohit.kumar3@nutanix.com>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  shenjiatong <yshxxsjt715@gmail.com>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tu Qiang <tu.qiang35@zte.com.cn>
  Tuguoyi <tu.guoyi@h3c.com>
  tuqiang <tu.qiang35@zte.com.cn>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Vineeth Pillai <viremana@linux.microsoft.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yasuhiko Kamata <belphegor@belbel.or.jp>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              broken  
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  broken  
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          blocked 
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            broken  
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary

broken-job build-arm64 broken
broken-job build-arm64-pvops broken
broken-job build-arm64-xsm broken
broken-step build-arm64-pvops host-install(4)
broken-step build-arm64 host-install(4)
broken-step build-arm64-xsm host-install(4)

Not pushing.

(No revision log; it would be 97411 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Feb 14 09:35:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 09:35:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271325.465730 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJXlY-0007W9-7q; Mon, 14 Feb 2022 09:35:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271325.465730; Mon, 14 Feb 2022 09:35:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJXlY-0007W2-4b; Mon, 14 Feb 2022 09:35:28 +0000
Received: by outflank-mailman (input) for mailman id 271325;
 Mon, 14 Feb 2022 09:35:27 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJXlX-0007Vs-Gy; Mon, 14 Feb 2022 09:35:27 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJXlX-0000bx-B5; Mon, 14 Feb 2022 09:35:27 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJXlW-0005Md-ED; Mon, 14 Feb 2022 09:35:26 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nJXlW-0003jY-Dl; Mon, 14 Feb 2022 09:35:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=R588smpYSqg5Z+gBUamp7YXPV5dx5FqsLIgpJW2mOII=; b=B25yT36bhKkShmcvj2zy4/eUuA
	19IcIVGLpM2H4cIx94brH39DWMB/7ZrcdlIBvuo6TrH56QJFqSfVdscVvNfC+iktcEcceVp1Sayv1
	KhUDK5bZL82rj9ChuTaViBu9FL/mJzE/XRSxTrcgUKhpS2KlVDtSzKOMo6okAfaqq+W8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168104-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 168104: regressions - trouble: blocked/broken/fail/pass
X-Osstest-Failures:
    qemu-mainline:build-arm64:<job status>:broken:regression
    qemu-mainline:build-arm64-pvops:<job status>:broken:regression
    qemu-mainline:build-arm64-xsm:<job status>:broken:regression
    qemu-mainline:build-arm64-pvops:host-install(4):broken:regression
    qemu-mainline:build-arm64-xsm:host-install(4):broken:regression
    qemu-mainline:build-arm64:host-install(4):broken:regression
    qemu-mainline:test-armhf-armhf-libvirt:xen-boot:fail:regression
    qemu-mainline:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-arm64-arm64-xl:build-check(1):blocked:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:build-arm64-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=48033ad678ae2def43bf0d543a2c4c3d2a93feaf
X-Osstest-Versions-That:
    qemuu=0a301624c2f4ced3331ffd5bce85b4274fe132af
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 14 Feb 2022 09:35:26 +0000

flight 168104 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168104/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-arm64                     <job status>                 broken
 build-arm64-pvops               <job status>                 broken
 build-arm64-xsm                 <job status>                 broken
 build-arm64-pvops             4 host-install(4)        broken REGR. vs. 168059
 build-arm64-xsm               4 host-install(4)        broken REGR. vs. 168059
 build-arm64                   4 host-install(4)        broken REGR. vs. 168059
 test-armhf-armhf-libvirt      8 xen-boot                 fail REGR. vs. 168059

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl           1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit1   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit2   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-seattle   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-thunderx  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-vhd       1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-xsm       1 build-check(1)               blocked  n/a
 build-arm64-libvirt           1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168059
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168059
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168059
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168059
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168059
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168059
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168059
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                48033ad678ae2def43bf0d543a2c4c3d2a93feaf
baseline version:
 qemuu                0a301624c2f4ced3331ffd5bce85b4274fe132af

Last test of basis   168059  2022-02-08 15:36:56 Z    5 days
Failing since        168095  2022-02-12 22:37:11 Z    1 days    3 attempts
Testing same since   168104  2022-02-13 23:39:38 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alex Bennée <alex.bennee@linaro.org>
  Cédric Le Goater <clg@kaod.org>
  Hanna Reitz <hreitz@redhat.com>
  Ivanov Arkady <arkadiy.ivanov@ispras.ru>
  Michael Tokarev <mjt@tls.msk.ru>
  Peter Maydell <peter.maydell@linaro.org>
  Philippe Mathieu-Daudé <f4bug@amsat.org>
  Stefan Hajnoczi <stefanha@redhat.com>
  Thomas Huth <thuth@redhat.com>
  Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              broken  
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  broken  
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          blocked 
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            broken  
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          blocked 
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      blocked 
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  blocked 
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  blocked 
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 blocked 
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      blocked 
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary

broken-job build-arm64 broken
broken-job build-arm64-pvops broken
broken-job build-arm64-xsm broken
broken-step build-arm64-pvops host-install(4)
broken-step build-arm64-xsm host-install(4)
broken-step build-arm64 host-install(4)

Not pushing.

(No revision log; it would be 768 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Feb 14 09:36:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 09:36:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271337.465740 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJXmv-0008Bp-OX; Mon, 14 Feb 2022 09:36:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271337.465740; Mon, 14 Feb 2022 09:36:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJXmv-0008Bi-LE; Mon, 14 Feb 2022 09:36:53 +0000
Received: by outflank-mailman (input) for mailman id 271337;
 Mon, 14 Feb 2022 09:36:52 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=YsDI=S5=epam.com=prvs=4044e07e7c=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nJXmu-0008Ba-8S
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 09:36:52 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a2527a57-8d79-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 10:36:50 +0100 (CET)
Received: from pps.filterd (m0174682.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 21E9Q7ix017561;
 Mon, 14 Feb 2022 09:36:44 GMT
Received: from eur05-vi1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2172.outbound.protection.outlook.com [104.47.17.172])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3e7mer817j-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Mon, 14 Feb 2022 09:36:44 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM0PR03MB5522.eurprd03.prod.outlook.com (2603:10a6:208:171::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.18; Mon, 14 Feb
 2022 09:36:40 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::fc4d:4749:5d1:eb73]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::fc4d:4749:5d1:eb73%4]) with mapi id 15.20.4975.018; Mon, 14 Feb 2022
 09:36:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a2527a57-8d79-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=NuvyXHSmFdDS3RZMn8MhWCVqf+3O3SzyvAE+s6B/rQ7tDobEr94EYogM6h9+jHfr6d+RhFs+Yzy+Shx3gW6maPsw9pyqFsuSLMKXq4efUmXqyRkZxbIRP7BxlJpuoy9BhG1SEx/qji1BUGrMXJ38R+2WsENR+L8ti+m9XSYfugBXBgvFhaltVSpk103LKQBWUwgD+YbuexwH4Xi9JDL5W5adKUHi9rDuutWkVOO+OYmfUzHqjQQUpV4odPCBEP2sQv1Itl7aBfn4tm9u7oSYvFvKab+mkJKoWYcuLqTAUVL8bbleVbJc0IHpxSrEF3j1KzRY+WnWvBRCGwDdSpoTAQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=275EXLjnNOik2YoOQdvWDpRY4pPe4tyftRlYIU+Lsoc=;
 b=JOETXkEjC8m8eQkP8WGdW4n1yOYt+3saOZhcxVYHkvn1Wt1AEHQDJf9GJAefLp81lVfJPE8WwoaapiDpaNIfMkB0KYRLyUefAMdvbVnbFJsWL47QgivmkO+ye3XZ74owMH1D14OWbVKKsiWDWngxsVDWnT38tCw+i7VEogKM5+w2dpcWHkytWm3O+VTnI9RJJkGyCy+Q/EoIuLfAMnP8Hv9v6Ox0HAuMwHs9YoaRWfQ2oFfKpXHLvs2EMBg1pxDOFaxkrxgltSRfJeC7ImjKmSOb+RjJkPJbAjddvfEL5hO9Rxj9tUZwsmEt+TswEfJcfozOPyJtfuAQINzoC2vGhQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=275EXLjnNOik2YoOQdvWDpRY4pPe4tyftRlYIU+Lsoc=;
 b=Nm1iv+FJJwBaHBtrieA0SG6Qnol3XOaz2eVWWI/lQVIRp6I6MjNeb+Iv4KalfetDXl25m9QTp6QSczxQ6L4Xd6oCceuz0z7AYb0j+OkrsYDthmbGfXqU/MPBvApcKwurgifYKyCWoDiuOa6acw5/RljdXJFF8/3Hha8AWeUCMWHBJTPI0oPHZawKYHC/zwRSxZkoTFwFl0XH4h63/sNKMncVmzDM9dmRKBpm5avcM2buEiyAQloi5mPW0ydkdgTgq7xnY9PzDaI8skOxE5CBgpFwjFxWKOqSfbvXMbvmdzsG9Qw7dd4PIfnHzblAK/zfWZf9eE+EzBvqcrPT7OA0EA==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "jbeulich@suse.com" <jbeulich@suse.com>,
        "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org" <sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH] vpci: introduce per-domain lock to protect vpci structure
Thread-Topic: [PATCH] vpci: introduce per-domain lock to protect vpci
 structure
Thread-Index: AQHYHboQT3cBWYI1/EGunE7hOwop6ayM95MAgAD+qQCAAEaDAIAElIcA
Date: Mon, 14 Feb 2022 09:36:39 +0000
Message-ID: <33fb1095-64ed-29ef-ba6b-cbde21d941f8@epam.com>
References: <20220209133627.959649-1-andr2000@gmail.com>
 <YgU6Snk8GTytJXZp@Air-de-Roger>
 <c4666570-666e-6680-5ec2-adf1da51ad06@epam.com>
 <YgZLEMW9US9QjjYG@Air-de-Roger>
In-Reply-To: <YgZLEMW9US9QjjYG@Air-de-Roger>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 439bc7b0-41b1-4ae5-f9f8-08d9ef9d80b4
x-ms-traffictypediagnostic: AM0PR03MB5522:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM0PR03MB552271E043054CBF0DEAEA67E7339@AM0PR03MB5522.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 TWO4GeJTZ/U2PloYYTJLIH6ML0QRwyZVQQ5FjRdJlbeX2IlrNpi4pO6cNwu0vveJHIzdbPc+zId9SmMgngDZ76rc/U2MmMVaE5NXCFOTBO4K3dJKZf0pBYtJpX1Eqd8BAFkm4lkGLKDuGfRxKxrAcc8gCzi9lEjM1y4+Id6P3vqKi4ES44bVF7lTNJRkSvWcs0raMQxScySVe+M1zC/OE0o5jNxET6MT4kao+VT/Cl1jh8b82YZ3voqnsoP3y1cscE/oLt7oCZqqm75gHuP+hwyud7tWB6ihcCjWOr2etD/eYFAj4S3grKCduUlN0zezM/1YsHX/ptSKuV1JElc455nrPQp3lsV0eT9YhzDAs8X2JckDFN9o3JrZFTBMOoa+QJt53CFHrvVpTly4I07XPY6QDpANqLltlBabi7b6+7+Nq3bNu8yIcznd519HNfikJP7U1bHPfHzlqmvNQO0Uer4xMZSVQqnIMr8jVKNDb9VSz5KvTjh/gxEUz28Xng1s35/Yt6NOS1XfpAqo7ii1w2pRy0bOR5/HX+GT+y8ESpqZLrnabkMewBcfLAbRfp2H/mzutV3q4GJI5HfQuaSJFp5qdJQxku+t6/4j3AuEa3JD9PT6aJPqPZB8+q5HdVOA7aKdDYJxtdrfq7V8zvX8JtfSk7iPB9XJpN4vzSwVkDKz3WBNWpch//jbwbxfPrxpxHZx7QXnq18TEchOzJlK6lGg92UOm5afSKSIrCW17mB/qrIu711fWq4tsewLulVaXhKNkhNb4SDRQPkJHSt1ENa+CdNNxF62pDxqe6uzOm5fnepwHkDrpZwv7fHloLb1
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(508600001)(36756003)(107886003)(54906003)(6916009)(2616005)(31686004)(122000001)(2906002)(31696002)(83380400001)(86362001)(316002)(966005)(6486002)(6512007)(91956017)(64756008)(66446008)(66476007)(66556008)(76116006)(66946007)(8676002)(38100700002)(5660300002)(71200400001)(26005)(186003)(4326008)(38070700005)(55236004)(53546011)(6506007)(8936002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?T3ZaUTFaQjZuTlJXT3JOZ1RNZjgwMGdSaEQ5eGErTWpBd2V0RW5VOSttckZR?=
 =?utf-8?B?ZHNPNEFhOXltWkJQbHJ2SXRzYWRaSHJZdG1HcHVWdnFDL2pMclhTaElRWUYy?=
 =?utf-8?B?OExJTzlnQXJhZlRIY2ZzOWhlcGRDZkwzcHUzd25LejNHSDA1dStuZEdsTGhW?=
 =?utf-8?B?ZXJFVnFyRTBETHNacTIyMTNaTTM5cXEzWkJPc2tuOVV4M2Vrc3p6N0tnK0ZU?=
 =?utf-8?B?bnBaaFRnM1NnYkNya0x6aDlrbmFHUEVHTHkxU29pVElheW5Ta0tzZzBzYXVh?=
 =?utf-8?B?THZ6QXNscUxoQXNZT1BBYzNjZGJ5M1phSVhOR2l6OXJhY2tFNW9kUGVibHZp?=
 =?utf-8?B?S3RHTGJNWnp5c0UzLzFHdjRNNjQ5eG0vbG9ZQVdESHNWS0pNNmY1djUybGtK?=
 =?utf-8?B?ZkdiM0xKdFhHTDhEZ0VwUW5jZ000T2JGSWFpVHF4OEgvNFpBcmdDUXJWVU5G?=
 =?utf-8?B?WWJpS1ZKYUNzaE1NUFJIWWpMcm5kVXRYa0FFNzl3K2R5Q3M5VFZWdENEM3Fv?=
 =?utf-8?B?YzdaNTlWbGNVK1VHSHpDeXVTeFBVNkY0RFNSeFJvcFgvRHhFSDZLa3lrYjNy?=
 =?utf-8?B?Sng4NE13eEE4bmdGNU9ZRVlKSnFDUFRxQlhvUmdVdTNwc1FZb3QyOVJiSlQv?=
 =?utf-8?B?ZzZnK0FVUjV1TW1PMTIyOWJHUURVS0piQXJjT2NxMUFicVJwUmljTS9UWDJi?=
 =?utf-8?B?NGtNRXBTWkc5dTFHdGpabkw3eHZ6T25TbW5rcjgzM2l2bm9BRVQ0MjhPOVhI?=
 =?utf-8?B?RlU5WGJuZjU2TWxIQklRdVpmMDRHdVRZaExhQ3JLUmtheGptTFd5NjIxNmlx?=
 =?utf-8?B?OE5vMkI2Znc0Z0Q5WEd5QUVpS1F6allBV3pUbkFtc3dzNnUxYVo5eGM3SStD?=
 =?utf-8?B?WGxva0E5eEFPcjZFeEMwRW95VE5hTURMSFY2cEFJRjBFYy93RnVxcm1xNlBH?=
 =?utf-8?B?OHNFMS9ZK0JjZFdUdmxia1ByUlJobitiTFc4UmhRVnZaQU56WE5wNllGWWhG?=
 =?utf-8?B?MzU3MGtFN05MUFk0c0dKM3I5Z3d5SFkxOXNtZWRxaWIrVktObzdOSVJkNUhQ?=
 =?utf-8?B?aUhCR2JVN1l2bEhhMkJTYlhkaFNmV2pjT25LMkFZWDdNcW1veGMvL1M0Snhh?=
 =?utf-8?B?cGdtejUwd3JSWjg4dDNab3FtaENVMzNxcGE5L1lVQmc0U0dralpjTTAvVzJa?=
 =?utf-8?B?YVZ3T3VWSzY3dGpPZ0pnTFh5VjJCTHRwQTZIYmxZdVdOblBvY2IvYzhlek04?=
 =?utf-8?B?YUlXS2J6OVJxb2tOTUVwTEhHSU1OOHhGREFEaHkwWFZGc3g3L2xlSVVpc2R4?=
 =?utf-8?B?UExURUk3WVVma1ZLbXQ3LzRrTW5zQWVsUEtySkQxc3ZvOUI4QzIzRGRKMkxC?=
 =?utf-8?B?Y0dGMVZmSHVxUDErWkJtdmJ0M2pDUHNIQzFvMW9tenFPdTZGdmJiN3E1REVR?=
 =?utf-8?B?UWdhOTBBWnZ0eDVwa0k3Ni9sZDM3VGU5cS95Zkxtb0xvbVY3bjg5cHFDbDBF?=
 =?utf-8?B?MGFFUlJRN0VqUEMrdnZ0cEY0NVhwb2JYUkc2cmZSL0JGNkFvN0dPY3dqczNp?=
 =?utf-8?B?dEdOM3RrQXNGWnFDNS8xN3FmelhIZTlGTnNpNkRyRllZZ2JBMjVWaVRJblJD?=
 =?utf-8?B?QVRJSmg1ZStIelVwNTVUZHpBcUxNcHdDa0t5ZEwyUU40T2N3ZDRJWGxIVnBu?=
 =?utf-8?B?Zmx1WUFUMXo1b3V3Ly95TFYyNFFzL2dsTWlaUU53ekt4U1JlUnJKckNVNlp4?=
 =?utf-8?B?MEpJeHVtYWRzQjBsS2xHZ2FjbGRjQ1V3OWk4bHpVcjd1YlRkNmE1WVV2ZTBm?=
 =?utf-8?B?L0VPQ2s2S2NBdExYeTlPOHhxSGQycXBGVHZPS1poNmFaeGorNjRpaW1MUldm?=
 =?utf-8?B?SGtydkc4RHdlR0IvdENDQ2lyZ3p1UGVOUFBZYUNQeHMyR2t6VmhXNFNMNjRY?=
 =?utf-8?B?TVU5c2NkQVcvejFVa3NHdWFpK2V5Tkl0OWRtMmFlRjZtVEtpSjBkRkZXTE04?=
 =?utf-8?B?d0ppSFptMDVNVjJ1c0lybnltVW1SUTBQYU8rbUJKZkZIL0RwNGg1TGRacFdh?=
 =?utf-8?B?N2RJRUxQWjhyNlA1S3drVHo1OTdCRjRReGd1Sm9WUG8zUk52UnRsaDVqdVJn?=
 =?utf-8?B?TFVxemtSN2RFeEo0YlA4K2NBYkZaQUxsWFk2WEpZN2s1UVlLYjYvdExYdWk1?=
 =?utf-8?B?NndhR0pmMlBtYzFwOFVWWVgvaUNKbzd1dHlwSkZpYkJoTExnSnZKUnFORjZF?=
 =?utf-8?B?UlZCRnZ6aFBuSXh2MVdvb1lDYlAwN1RZaU1FU0xmRW9MUjRSK3JCNEhmM1J6?=
 =?utf-8?B?dlkyeTNJa1o2T3hjbk9KYms3OTI4d1RoMENGK1FKZUU1MGx6cFIzdz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <8810E1878EF4D44BBBD5C908DB8A5B8A@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 439bc7b0-41b1-4ae5-f9f8-08d9ef9d80b4
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Feb 2022 09:36:39.6165
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: iKsZGjr378gRjKis1cl3jtZYhJnG+SRDCaKMYN1Nq9OHQsVFoGCiM49EAhwxXXoHfPdJhmTwJ0oV+LB3uoZqcY1heLwvj8SX5UglK9JmdixHzsJYYTv96xFLa8MH1V0L
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB5522
X-Proofpoint-GUID: IsMPRVNszC0SUuCK1npszKdMZ1Qj6V71
X-Proofpoint-ORIG-GUID: IsMPRVNszC0SUuCK1npszKdMZ1Qj6V71
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-14_02,2022-02-14_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 malwarescore=0
 clxscore=1015 adultscore=0 phishscore=0 lowpriorityscore=0 mlxlogscore=873
 priorityscore=1501 spamscore=0 impostorscore=0 bulkscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2202140058

DQoNCk9uIDExLjAyLjIyIDEzOjQwLCBSb2dlciBQYXUgTW9ubsOpIHdyb3RlOg0KPiArDQo+Pj4+
ICAgICAgICBmb3IgKCBpID0gMDsgaSA8IG1zaXgtPm1heF9lbnRyaWVzOyBpKysgKQ0KPj4+PiAg
ICAgICAgew0KPj4+PiAgICAgICAgICAgIGNvbnN0IHN0cnVjdCB2cGNpX21zaXhfZW50cnkgKmVu
dHJ5ID0gJm1zaXgtPmVudHJpZXNbaV07DQo+Pj4gU2luY2UgdGhpcyBmdW5jdGlvbiBpcyBub3cg
Y2FsbGVkIHdpdGggdGhlIHBlci1kb21haW4gcndsb2NrIHJlYWQNCj4+PiBsb2NrZWQgaXQncyBs
aWtlbHkgbm90IGFwcHJvcHJpYXRlIHRvIGNhbGwgcHJvY2Vzc19wZW5kaW5nX3NvZnRpcnFzDQo+
Pj4gd2hpbGUgaG9sZGluZyBzdWNoIGxvY2sgKGNoZWNrIGJlbG93KS4NCj4+IFlvdSBhcmUgcmln
aHQsIGFzIGl0IGlzIHBvc3NpYmxlIHRoYXQ6DQo+Pg0KPj4gcHJvY2Vzc19wZW5kaW5nX3NvZnRp
cnFzIC0+IHZwY2lfcHJvY2Vzc19wZW5kaW5nIC0+IHJlYWRfbG9jaw0KPj4NCj4+IEV2ZW4gbW9y
ZSwgdnBjaV9wcm9jZXNzX3BlbmRpbmcgbWF5IGFsc28NCj4+DQo+PiByZWFkX3VubG9jayAtPiB2
cGNpX3JlbW92ZV9kZXZpY2UgLT4gd3JpdGVfbG9jaw0KPj4NCj4+IGluIGl0cyBlcnJvciBwYXRo
LiBTbywgYW55IGludm9jYXRpb24gb2YgcHJvY2Vzc19wZW5kaW5nX3NvZnRpcnFzDQo+PiBtdXN0
IG5vdCBob2xkIGQtPnZwY2lfcndsb2NrIGF0IGxlYXN0Lg0KPj4NCj4+IEFuZCBhbHNvIHdlIG5l
ZWQgdG8gY2hlY2sgdGhhdCBwZGV2LT52cGNpIHdhcyBub3QgcmVtb3ZlZA0KPj4gaW4gYmV0d2Vl
biBvciAqcmUtY3JlYXRlZCoNCj4+PiBXZSB3aWxsIGxpa2VseSBuZWVkIHRvIHJlLWl0ZXJhdGUg
b3ZlciB0aGUgbGlzdCBvZiBwZGV2cyBhc3NpZ25lZCB0bw0KPj4+IHRoZSBkb21haW4gYW5kIGFz
c2VydCB0aGF0IHRoZSBwZGV2IGlzIHN0aWxsIGFzc2lnbmVkIHRvIHRoZSBzYW1lDQo+Pj4gZG9t
YWluLg0KPj4gU28sIGRvIHlvdSBtZWFuIGEgcGF0dGVybiBsaWtlIHRoZSBiZWxvdyBzaG91bGQg
YmUgdXNlZCBhdCBhbGwNCj4+IHBsYWNlcyB3aGVyZSB3ZSBuZWVkIHRvIGNhbGwgcHJvY2Vzc19w
ZW5kaW5nX3NvZnRpcnFzPw0KPj4NCj4+IHJlYWRfdW5sb2NrDQo+PiBwcm9jZXNzX3BlbmRpbmdf
c29mdGlycXMNCj4+IHJlYWRfbG9jaw0KPj4gcGRldiA9IHBjaV9nZXRfcGRldl9ieV9kb21haW4o
ZCwgc2JkZi5zZWcsIHNiZGYuYnVzLCBzYmRmLmRldmZuKTsNCj4+IGlmICggcGRldiAmJiBwZGV2
LT52cGNpICYmIGlzX3RoZV9zYW1lX3ZwY2kocGRldi0+dnBjaSkgKQ0KPj4gPGNvbnRpbnVlIHBy
b2Nlc3Npbmc+DQo+IFNvbWV0aGluZyBhbG9uZyB0aG9zZSBsaW5lcy4gWW91IGxpa2VseSBuZWVk
IHRvIGNvbnRpbnVlIGl0ZXJhdGUgdXNpbmcNCj4gZm9yX2VhY2hfcGRldi4NCkhvdyBkbyB3ZSB0
ZWxsIGlmIHBkZXYtPnZwY2kgaXMgdGhlIHNhbWU/IEphbiBoYXMgYWxyZWFkeSBicm91Z2h0DQp0
aGlzIHF1ZXN0aW9uIGJlZm9yZSBbMV0gYW5kIEkgd2FzIGFib3V0IHRvIHVzZSBzb21lIElEIGZv
ciB0aGF0IHB1cnBvc2U6DQpwZGV2LT52cGNpLT5pZCA9IGQtPnZwY2lfaWQrKyBhbmQgdGhlbiB3
ZSB1c2UgcGRldi0+dnBjaS0+aWTCoCBmb3IgY2hlY2tzDQoNClRoYW5rIHlvdSwNCk9sZWtzYW5k
cg0KDQpbMV0gaHR0cHM6Ly93d3cubWFpbC1hcmNoaXZlLmNvbS94ZW4tZGV2ZWxAbGlzdHMueGVu
cHJvamVjdC5vcmcvbXNnMTEzNzkwLmh0bWw=


From xen-devel-bounces@lists.xenproject.org Mon Feb 14 10:07:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 10:07:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271348.465751 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJYGu-00039I-8I; Mon, 14 Feb 2022 10:07:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271348.465751; Mon, 14 Feb 2022 10:07:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJYGu-00039B-5L; Mon, 14 Feb 2022 10:07:52 +0000
Received: by outflank-mailman (input) for mailman id 271348;
 Mon, 14 Feb 2022 10:07:50 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=S9OP=S5=oderland.se=josef@srs-se1.protection.inumbo.net>)
 id 1nJYGs-000395-AG
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 10:07:50 +0000
Received: from office.oderland.com (office.oderland.com [91.201.60.5])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f454b0cb-8d7d-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 11:07:45 +0100 (CET)
Received: from [193.180.18.160] (port=46784 helo=[10.137.0.14])
 by office.oderland.com with esmtpsa (TLS1.2) tls
 TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2)
 (envelope-from <josef@oderland.se>)
 id 1nJYGq-00FJ2L-Q4; Mon, 14 Feb 2022 11:07:48 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f454b0cb-8d7d-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=oderland.se
	; s=default; h=Content-Transfer-Encoding:Content-Type:Cc:To:Subject:From:
	MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID:Content-Description:
	Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:
	In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
	List-Post:List-Owner:List-Archive;
	bh=DBcZFOZFOzAo0487ORwdyo67faVNaoS7BuODPg0NpSc=; b=G2iBx9UAIY7r4NBbcXyTDLChbw
	Zgw1vyY89SDtdMDHqsdCOLiyD0ju+cpr2blUyln1I+Lq8jk+Pugfx0BpX9MHsjvZGwlvDOY8EdrcN
	jGT5YBha3W4hhznMoEJ4ehSglNSQ0Mbplhw5Ws2ylCjociLp6FRMi3kOkO3pHh8eBlAtoVvEMFKlT
	pNH6WgHV7uuMd1VUyrROPx8wiCaTbNyzotCCp5sYdwznYq0yp4Q6OceiB1Nb56b5Uk+DtayFC/NpD
	uSpOYKz3sPZBukIkgAMdmvd7rCyiCiXWueogd/tWwZjkfgr3VCdmLV1E7dsuX3F10b7HqVqhgSNZj
	uBVcE0Wg==;
Message-ID: <d818f9c9-a432-213e-4152-eaff3b7da52e@oderland.se>
Date: Mon, 14 Feb 2022 11:07:47 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:97.0) Gecko/20100101
 Thunderbird/97.0
From: Josef Johansson <josef@oderland.se>
Subject: [PATCH v2] PCI/MSI: Correct use of can_mask in msi_add_msi_desc()
To: Thomas Gleixner <tglx@linutronix.de>, Bjorn Helgaas
 <bhelgaas@google.com>, linux-pci@vger.kernel.org,
 Jason Gunthorpe <jgg@nvidia.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-AntiAbuse: This header was added to track abuse, please include it with any abuse report
X-AntiAbuse: Primary Hostname - office.oderland.com
X-AntiAbuse: Original Domain - lists.xenproject.org
X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-AntiAbuse: Sender Address Domain - oderland.se
X-Get-Message-Sender-Via: office.oderland.com: authenticated_id: josjoh@oderland.se
X-Authenticated-Sender: office.oderland.com: josjoh@oderland.se

From: Josef Johansson <josef@oderland.se>

PCI/MSI: Correct use of can_mask in msi_add_msi_desc()
    
Commit 71020a3c0dff4 ("PCI/MSI: Use msi_add_msi_desc()") modifies
the logic of checking msi_attrib.can_mask, without any reason.
    
This commits restores that logic.

Fixes: 71020a3c0dff4 ("PCI/MSI: Use msi_add_msi_desc()")
Signed-off-by: Josef Johansson <josef@oderland.se>

---
v2: Changing subject line to fit earlier commits.

Trying to fix a NULL BUG in the NVMe MSIX implementation I stumbled upon this code,
which ironically was what my last MSI patch resulted into.

I don't see any reason why this logic was change, and it did not break anything
correcting the logic.

CC xen-devel since it very much relates to Xen kernel (via pci_msi_ignore_mask).
---

diff --git a/drivers/pci/msi/msi.c b/drivers/pci/msi/msi.c
index c19c7ca58186..146e7b9a01cc 100644
--- a/drivers/pci/msi/msi.c
+++ b/drivers/pci/msi/msi.c
@@ -526,7 +526,7 @@ static int msix_setup_msi_descs(struct pci_dev *dev, void __iomem *base,
 		desc.pci.msi_attrib.can_mask = !pci_msi_ignore_mask &&
 					       !desc.pci.msi_attrib.is_virtual;
 
-		if (!desc.pci.msi_attrib.can_mask) {
+		if (desc.pci.msi_attrib.can_mask) {
 			addr = pci_msix_desc_addr(&desc);
 			desc.pci.msix_ctrl = readl(addr + PCI_MSIX_ENTRY_VECTOR_CTRL);
 		}

--
2.31.1



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 10:18:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 10:18:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271361.465763 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJYRY-0004cb-79; Mon, 14 Feb 2022 10:18:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271361.465763; Mon, 14 Feb 2022 10:18:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJYRY-0004cU-3w; Mon, 14 Feb 2022 10:18:52 +0000
Received: by outflank-mailman (input) for mailman id 271361;
 Mon, 14 Feb 2022 10:18:50 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KkXt=S5=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nJYRW-0004cO-T2
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 10:18:50 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7da2131a-8d7f-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 11:18:45 +0100 (CET)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2057.outbound.protection.outlook.com [104.47.13.57]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-14-SyXc_BCANty9kbVPh2YMkQ-1; Mon, 14 Feb 2022 11:18:47 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4415.eurprd04.prod.outlook.com (2603:10a6:803:74::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.18; Mon, 14 Feb
 2022 10:18:46 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4975.015; Mon, 14 Feb 2022
 10:18:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7da2131a-8d7f-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644833929;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=FbQnGuAQmyX9dDjrZ7j+sMeyeoSJ3f+/EGE3I1YR6/Q=;
	b=E9gQC1qu6oFIVV6s12wK8Rp52ao+lDj75klQoqQs/FnB7NB9q2ZzKbpegswtgiOrCZ/WDp
	0wRJ09qsu8gcF09X6rSpXMchip29TjzHkmZMbXCCDF8PKsYuP96PCOsDUADNX56O2DdDF1
	9XAlwsyTiXspMDRwQIMBnEvYak4TcEg=
X-MC-Unique: SyXc_BCANty9kbVPh2YMkQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=F+FnR1OgbMmF5M0MKML9smeMiXlT9mGRgIBsYxpDtJucwQBkLQ31nVvzKUW8rAEppUlot4SwIFfKJuwum2cnIju2IJb3ofrIlffZeOhxLS+vuaYl1GdLdFH2exGo3k3IljGSYi6v09DEzlzoKzluq+JdQ7ZCoq1zrvkEyQsDKMrYo9p7jqrWZUt1pzbQ7i2XWfBdny4jn75tq0BcyMG3E7aL+opiedU3aw+IHltfSRHebIh8SuygsJ6ODXBKdu1fXiPsLCkT8Qzbmb1R5ZueMu5jKNUb3I9Y8hyqgr7Wo8Pmt5qICFSCn+hql7an4j8ZR/lpfrQbXVzT3T6r8FbmGA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=FbQnGuAQmyX9dDjrZ7j+sMeyeoSJ3f+/EGE3I1YR6/Q=;
 b=bDXgbf973lBz9QXB7qN7klJb606fzE6gqaZ70f8y9Sr19IUnIF8WHwkgsxWUKLbJtsHIz3hzsvbi2yzlRrD+uXUvKEjO4wGiuxTQh2VQxdv/GDvqsQXR0dzQfD9wggvpPYUrb98+ZhKMHyAOofmwYmkaDXN+Ya/oJS1FiYfPxWrLKIY8z8GzDceYcgCDKcjommgnG/CUrZV/A+3nA8LnJEpnPLiD+TFUaeZLDGU8ICMUb+/qpXNOB7M97zJtBemGBmSFRu4NEBYtep3s18N2vT3/c/cwtIIKB2wttgWBBH+gClDSrE+UrSjDo9a5iIkiO8h/5GgEoPpa+ihUawvLbw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <710fd687-16d5-c088-d3be-749851e6eab3@suse.com>
Date: Mon, 14 Feb 2022 11:18:44 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Content-Language: en-US
To: Anthony Perard <anthony.perard@citrix.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
From: Jan Beulich <jbeulich@suse.com>
Subject: tools backports
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR3P281CA0016.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:1d::21) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f5271fb0-eb94-45f2-466a-08d9efa3625f
X-MS-TrafficTypeDiagnostic: VI1PR04MB4415:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB44157098A0FBEF50B066B612B3339@VI1PR04MB4415.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6430;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	nNHXJAU8nXBhBPVuOzmk3nxbrWUaxcq6Oc75AT+PgQxr4hFZ4Xp1yzBsGi+9vSsXEYXv7Jh7XZLbYg2KzzwXtlDsOS8h5ZsUEiXzTbBlH0/Os9kp/r/TXQMfRRLhkWzDvA23Ckh7n/2am3aCAtLd/J/rWoUxLfZCwWWLU8JOdnsEoACc1V/Tk49P4+JeIBUFg910/G8MaeHxGniRGkgK+LXFgZirLtjBpI/aeabmJUUT6jJuZ0RrGu3IPMk6TkZUS8XzK8od15gSxBZ/lxDez32rOpWqma+ksgTXy8P7PRLA/6WhbHa8nZBz04FW61HBtQS2D7OLYd53HIwQ3xgxnZalYJFDhV3vTCk8QgZSn6PKl6sS+yOuF/2CakW9rycBsoobghHfthSIEEIyQaYlYu8SflLzLKphso5H+9lw1tsbhawwKmND5ynxgmHiADv563RdV7Lg0lRdrjAMfiQ/lc8CvAqHCOLfmbke8v2EbMI4kfm2rGqpl4E+tdr4jsRhIli8zxIva+MzeKe/7muMoLOGKoqI7GG8tdXQGrnxia3RuxFT8FE8eIe1xFxuOSGd9rfVsZkQAWk+IxUL6An6MjAlpBWv7re3+wCmzATnvlRim5eID7lvCcjDZa1ufw2OzazwWs5WsaqGyuTvSro8MJZ8mdSmwFDfVcsdYZ69VVrz49CC0fTjl7pEP8NQIVTa4F4R+mXu0nl4B/+4piRUZXrzezQVvzEqAiCBoxqQiCE=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(508600001)(36756003)(31686004)(6486002)(3480700007)(6916009)(316002)(2616005)(186003)(86362001)(26005)(4326008)(31696002)(4744005)(5660300002)(6512007)(38100700002)(66476007)(8676002)(8936002)(2906002)(66946007)(6506007)(66556008)(7116003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Y1lQWHpjbXlFa2ZLNUE1bFNQcW9uQzhmZW42a2tqNTJ0MXNuaFo4ZUhYY1Qr?=
 =?utf-8?B?OWJnKzFGcnF3bkg2WHVmWEVPQ3UwV0s2aVFNZWMwb2JyanQvbmE3bHp2VkV3?=
 =?utf-8?B?WERMdlZBdHdtVmdmOTVDOGRuVzhkMzlJbzJ0b21pWW1iZ0lTZ0dVcmFuODUv?=
 =?utf-8?B?cDdZSU96SmlsV056eTNWVVh6Yzd6WUtORi9nM3pDb0xrZzVSZjhPUFQxQkdG?=
 =?utf-8?B?NEJQWi8xZEtSWDhkWnhDMmJCU1FwK3hBNkZkcDRHUERLRmpoYUlva3YvMlpn?=
 =?utf-8?B?ZStVRmpLYVpCZkNBeHJVUVhyVWNpKytKRk9HbkthMXg5ZDRpdmo0UXlEbndh?=
 =?utf-8?B?NDdVYW00b2xFdDFBUzBTVmRHZElPVHNpY2psNjdNZ2F4bzFNUkZuSGd1eWJl?=
 =?utf-8?B?a09DbW55ZGhqYldIZGpLY3FhN24ySmd6cExmZ1NqZ0kwd0tXNDFhOXFGUTg2?=
 =?utf-8?B?NlFJU2VkZTlpM2NyOHFjNTFIbXJjRkdYc2t4T3lWUk9iRlZ3OFBjZi8rT1Iz?=
 =?utf-8?B?aFZPWWtoTGxVT3ZHcXNKRXZLTkxCL0ZQejZOZUFLVW5rUkZ5eVdiQ2poUzJW?=
 =?utf-8?B?TGRHQ0hGWm9hczllZ2xJUk12NnVubEJaUWV5UHNKdUN6WWNuUGNrQXNSRzVX?=
 =?utf-8?B?MTBBQllSUk1Mcmx0ZnFsS1hMTDJFck12MXB3Yk9JVEYwN3ZOM1Z4Uk5Da2RW?=
 =?utf-8?B?T2FGck1LMHh6b1NvR2k1aElOcWVSSkVsT1pVb3h6Y3RRejcvL01oTXM1MllL?=
 =?utf-8?B?ME5kcGZPMEJkcE1ENTU0SWVGK1RDMG5IRlN1dkhVOWJ2UzJWbUd3RTlZNTRk?=
 =?utf-8?B?U2xrOFJDczVqUHlZUElpRnZ0a3UxWWtDbUxQUTkvMFM0YjFSb3YrK2ZoRzlW?=
 =?utf-8?B?cHZ5aDhlVGRmL01WWDV4bXdtbmhDeTNBMjcxT2tFbHZYTFBmcDBrZElxL0tM?=
 =?utf-8?B?WXRkRm9iNUJqL2c0MnFDb0hEa1dUc2Y4ZDAvL1hjR3pkL3JxZXRIVEtmVHgv?=
 =?utf-8?B?Q1N0bTYxN3VRWDU4NVNhOXdnZktYZEVza3dmdGdUaWllRmxVNDNZZ0tna3V4?=
 =?utf-8?B?QWJPNUpvVVo5N0tWQ3k1ZEx3aHM3RVZPUndQeTNxTTY5clBidEpoNklPUGZs?=
 =?utf-8?B?Vy8zazFBRU1DZGx1UmhTaHRVK2tCUkVZYm9vMDhsaGdoM3ZTMG5SaWpLRmR5?=
 =?utf-8?B?cXQrMmxQVElLK3VkZ3kva1Zya1RaWkZFS1k2NGdQWUVPS1k1WGJRYVdDdW03?=
 =?utf-8?B?SW1KM3NUcXdZeVgvOUFhWEMvM242a0w1THNUR3pwc1pMN0hFaWRGdktyYUpq?=
 =?utf-8?B?YkdPc2tYTnRlTDBvckVyUVViWUhEMkVqSHl2QzRaeE1qR21lbVJmclkxQTRn?=
 =?utf-8?B?QTM2b2w2dEVyMThRem1EWkoyYmxLMFNaaEhrdGpWQXFrek84cG4yMFI2M1c2?=
 =?utf-8?B?YlVJZnE4YW52Zy9XWmlpNU8yUERhRzMvaUlWeGk1ay80TmNncG1NYjNVTGxU?=
 =?utf-8?B?WWx2YjdqNlZaSnN2OGJvMDlBUmRQM3ZYWnFNYzNZSFNSZ2JBSHdGUGZQSUx5?=
 =?utf-8?B?QmlwY05GR1cwdm9XZHhCUmZYYzF4SXNQVzZ1TmVvTlU3aVE4L0FuZFdwUldL?=
 =?utf-8?B?eGUyUjMxTTBoR1JEVU1YSmRHNTJ4enI3Z0JRY0JVQmxHRWp3K3djTUpQU1ND?=
 =?utf-8?B?U09yOUpYZzg2U3dKRTdORGoydXpzYW1HVmNQSlpxMXNSVEdtVUZuZXBCU0Qz?=
 =?utf-8?B?YVNKMllsUHp3RzFPZytpTXJuYXlmVkRjU2ZxTHpCeXdPOG5EZGo2bEk5em1X?=
 =?utf-8?B?OHI4d1AzeFYvNlJnaTNUbDBmaTEwcVIwc3Z0UStIdHg5UFBMZkkwbi9qMFJP?=
 =?utf-8?B?WUhtbWM1UHZta1JJNmFwUGpCWkVjYXh1SjBYRWRrNEpITnhQbGNRdUF0L1Mv?=
 =?utf-8?B?N01LWGd3MmNGOTEvNkdtMmR0UktVNHcwZXY4OVNiRVNlTUczSWt5SXNzczlw?=
 =?utf-8?B?TEJWTDBpQUZxT3QraWRjYWw1aDdmK2toSlVsNHJuU1VKZjJXZ0FOejFORzdj?=
 =?utf-8?B?dmxyUEtPMDVGNlRIeGJxZ3k1VXZWZ2g5T2xXMFQzTTJsUzU1NFZRYXN4WnF5?=
 =?utf-8?B?V1NscVB0V09JSzliS256aGJCbnRqMmlTYzRVbWNuVk5GeTlQQ2wxTnZPWDNP?=
 =?utf-8?Q?0XVcUEs72xsZULisHK8gc0I=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f5271fb0-eb94-45f2-466a-08d9efa3625f
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2022 10:18:46.1254
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: K4grKFMAjA9uWvDmpC7J+W2bc5LEvjxUf6CQ4+Rrx/PHTm+oJVnYsuzzzCa4KAbN/QaEUHdH/3qqZxcGo5+dtw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4415

Anthony,

I have a couple of simple tool stack backports queued, which - with your
agreement - I would want to put onto the stable tree whenever I get
around to applying the next batch of backports:

d9d3496e817a tools/libs/light: don't touch nr_vcpus_out if listing vcpus and returning NULL
e62cc29f9b6c tools/libs: Fix build dependencies

For 4.15 additionally

dd6c062a7a4a tools/libxl: Correctly align the ACPI tables

Please let me know if that's okay with you.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 10:22:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 10:22:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271368.465774 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJYUj-0005zv-Mb; Mon, 14 Feb 2022 10:22:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271368.465774; Mon, 14 Feb 2022 10:22:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJYUj-0005zo-Ip; Mon, 14 Feb 2022 10:22:09 +0000
Received: by outflank-mailman (input) for mailman id 271368;
 Mon, 14 Feb 2022 10:22:08 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJYUi-0005zi-CB
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 10:22:08 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f437d6b0-8d7f-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 11:22:05 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f437d6b0-8d7f-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644834125;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=XjycwK1Z6bMv6+kfGGbscoOQqpz9whOwOdZSkYJQb8k=;
  b=ZMNacLiJBrZlFYuif2en8UQBRpcoO6L7t1gr6Vno+SqiIsOxDZk6E4OY
   1BYo1gX/Ua47gIQ1sRpQio6LMO38Ls22uXQyI00YFG/mMziM97PM456gK
   VCQq5fJPkL5mhtBTuIO3cQbq65zPUGRF0h9CCAsWSfzqStmkZKNyN2oNV
   k=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: ttEhlEvUaJhqZbkejddNakCGHHByZfkvBxlOvSRWv4RdF3mS/rCg5S0h8kAEQb2B9x+91+NGtW
 u9D2AUoNk2n6RfWd+2e3np6/+H+TusKdblCw/A0Yl8VjiurzLwbH3mQ8cC4f7JqbPU6uqueBnE
 /kW8YpleLjGX2yfkUIUmhRYLtfoxcRBfQyP6GhqnIFe6pNF1nKGADTscMQQOL11Wsvz8iNA3Lu
 f62pa4U41DoWS+K/CqmcNBL/TfvuywcNMKgQEZ6LnbZctUZI/8Ixp7q7UD6/zyqhpgjcVgJcgW
 tRdV2xgfESaiurRv13yxou41
X-SBRS: 5.1
X-MesageID: 64040987
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:xSyB26OH4T3dj6nvrR1kkMFynXyQoLVcMsEvi/4bfWQNrUokhTIPy
 msYCmuDOv+LY2f8eYtwaIu18UwEvpbUmoI2QQto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6UUsxNbVU8En1500s/w7dRbrNA2rBVPSvc4
 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq
 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYoxeDou9s+
 s8Rjq6tGFkQM42WwuEPDBYNRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs
 6VFdnZdNXhvhMrvqF6/YsBqit4uM4/AO4QHt2s75TrYEewnUdbIRKCiCdpwgmto2pgfTam2i
 8wxWDNIMgz9cRF1JnQ5V4sCgfj0pHTQbGgNwL6SjfVuuDWCpOBr65D9PdyQdtGUSMF9mkeDu
 nmA72n/GgsdNtGU1XyC6H3Eru3FkD7/WYkSPKal7fMsi1qWrlH/EzVPCwH9+6PgzBfjBZQPc
 CT45xbCs4AQ/nGUU+vnAyaKvS/ahxM8AYBVAbI1vVTlJrXv3y6VAW0NTzhkYdMgtdMrSTFC6
 mJlj+8FFhQ07uTLFCv1GqO86GrrZHNLdTNqiTosEFNdi+QPtr3fmf4mojxLNKeuxuP4Fjjrq
 9xhhHhv3u5D5SLnOkjSwLwmv95OjsWTJuLWzl+ONo5A0u+eTNT7D7FEEXCBsZ59wH+xFzFtR
 kQslcmE9/wpBpqQjiGLS+hlNOj3u6raYG2B3AY2RMNJG9GRF5mLJ9443d2DDB0xbpZslcHBP
 Cc/Rj+9FLcMZSD3PMebkqq6CtgwzLiIKDgWfqu8Uza6WbAoLFXv1Hg3PSa4hjmx+GBxwfBXE
 crKKq6EUCdFYZmLORLrHo/xJ5dwnXtgrY4SLLimpymaPU22OiLLF+dfbQfmgyJQxPrsnTg5O
 u13bqOi4x5eTPf/cm/Q94sSJkoNNn81Gdb9rMk/SwJJClMO9LgJB6CDzLU/VZZimqgJxO7E8
 mvkAh1TyUblhG2BIgKPMygxZLTqVJd5jHQ6IS1zYgr4hyl9Od6ivPUFap86Xbg77+g/n/R6e
 OYIJpebCfNVRzWZpzlENcvhrJZvfQiAjB6VO3b3eyA2epNtHlSb+tLtcgb12jMJCy676Zk3r
 7G6j1uJSpsfXQVySs3Rbav3nV+2uHEcnsN0XlfJfYYPKBm9rtAyJnWo3PEtIswKJRHS/Reg1
 l6bUUUCuO3Ag44p692V16qKmJikTrllFU1AEmiFsbvvbXvG/nCuyJNrWfqTeWyPT3v9/aiva
 LkHz/z4N/Fbzl9Gv5AlTuRuxKM6odDuu6Vb3kJvG3CSNwanDbZpI3+n28hTt/ISmu8F6FXuA
 k/fqMNHPbipOd/+FA9DLQUoWe2PyPUIl2SA9v8yOkj7uHd68bfvvZ++5PVQZPix9IdIDb4=
IronPort-HdrOrdr: A9a23:+7iV9aAI+D14nDHlHegKsceALOsnbusQ8zAXPh9KJyC9I/b2qy
 nxppgmPEfP+UossHFJo6HlBEEZKUmstKKdkrNhQotKOzOW+FdATbsSo7cKpgeAJ8SQzJ8k6U
 4NSdkdNDS0NykGsS+Y2nj6Lz9D+qj9zEnAv463pB0BLXAIV0gj1XYCNu/yKDwqeOAsP+tfKH
 Po3Ls/m9PWQwVwUi3UPAhhY8Hz4/nw0L72ax8PABAqrCOUiymz1bL8Gx+Emj8DTjJm294ZgC
 r4uj28wp/mn+Cwyxfa2WOWxY9RgsHdxtxKA9HJotQJKw/rlh2jaO1aKvi/VXEO0aWSAWQR4Z
 /xSiQbTp1OArTqDzmISC7Wqk7dOfAVmiTfIBGj8CHeSIfCNUwH4oJ69PNkm13imhYdVZhHod
 F2NyjyjesmMTrQ2Cv6/NTGTBdsiw69pmcji/caizhFXZIZc6I5l/1TwKp5KuZKIMvB0vFsLA
 CuNrCq2N9GNVeBK3zJtGhmx9KhGnw1AxedW0AH/siYySJfknx1x1YRgJV3pAZOyLstD51fo+
 jUOKVhk79DCscQcKJmHe8EBc+6EHbETx7AOH+bZV7nCKYEMXTQrIOf2sR42Mi6PJgTiJcikp
 XIV11V8WY0ZkL1EMWLmIZG9xjcKV/NFQgFCvsurqSRloeMMYYDABfzPmzGyfHQ0cn3KverL8
 qOBA==
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="64040987"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=SdmnsArA5TvH5MivsPtoh0GNjRa/2ECRzogpbi0EHFmOeZeF+cWSIRTHU0SygwKjVKveLdVSOhk3lk1j05rZNGbj6KHvjdWyZ0SCbdFs9+voGCmLrtmObXByWnm2BT7kjBat0t4bTOdOH61AF2p2urkdWGyGWWICcCGYRculHO3+mVoiUU63Lh2J8jItPEpb9DgnpQ3e+RPWt7Q8F1ZwjYJOREn8k/zLUtj41FaXdUX39R7g+wJm5mzyVjTfjNSQwO7GZmURQZ0OpwWnWe9U946iUJVqRmDXC9nZaR8Xb/SVSimRpCYC3RW6SwRwJ0bNhvUxhC4yULrcgSR+V61E2A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=XjycwK1Z6bMv6+kfGGbscoOQqpz9whOwOdZSkYJQb8k=;
 b=D+SoBdOV9KN64U/bl8nEEZHB28OGH36ztZBXvYTFkkyR/ry80zdYcQsw2bjv5Cq8wVf6NIQtB/DUxeHzttRQBvQIQIx+8QyU/4zADnLAl8eLVUplsik4xJTZL76prGIngxmoSx7DfvPCWtEpFCBZgihNe8HuK9J3KPWmTDNfyt/IwTfd+gMcUu1Z3l8S+8xX8u+qput7Gh8HH117bhN9dI2IfyI460ouk5zig2H34F3cyNnj1+DMSrFA8lRpMfO5SBr9ixFpBVn3ApDfIAyPFF2lJ6UsrEXwEOt95W4fdrLuaYBxrP4xQ/IXIPpCR0DL/U9xZvak6Nx45PTdcM1FGw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=XjycwK1Z6bMv6+kfGGbscoOQqpz9whOwOdZSkYJQb8k=;
 b=hes9JJWidZOS9XIuHdkKFRpP3HDgjWFitqQWQUHnXAoNfnqm5/LKMK8lMBzUYjbia9Z+uBTjROGcpTrV4K5RxbmChGNbF9f4Nhp7fR65p37VV9P3Qx5XGeVNQj2Pmi0D/dNW0bNyzGYGO9MhFKEX4VxcIpZfGQpHVvaumHRgOwc=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>, Anthony Perard
	<anthony.perard@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: tools backports
Thread-Topic: tools backports
Thread-Index: AQHYIYxOf3hnmEAHzECVq7GqiCZgPKyS1kwA
Date: Mon, 14 Feb 2022 10:21:59 +0000
Message-ID: <6f3157af-6ab7-ae67-0080-48754d41c19f@citrix.com>
References: <710fd687-16d5-c088-d3be-749851e6eab3@suse.com>
In-Reply-To: <710fd687-16d5-c088-d3be-749851e6eab3@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 7495f29c-2920-4220-83eb-08d9efa3d5d3
x-ms-traffictypediagnostic: CY4PR03MB3158:EE_
x-microsoft-antispam-prvs: <CY4PR03MB3158A54C087C87F02AADECF0BA339@CY4PR03MB3158.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:7219;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: tdu9dEo/WfcKbDYTqWgpA+lbkuphCX6jelsE5EwtQXsR4iikDmMDU/Saw/B3E1C/5uvrx4hedWD/MBjoja/KyKlhN98gVE5tmgvY2s7T/j/EV+rpf8cxPHIFJu/aIUUcm/ra1Y67dCJuGcw7NPdlrjdmilAiYjKohe+QLD/pr0g5MevIZkz0eLwhTzfAsqwL7lUmEz18ep0HPSFt5OI9vO0sT9lTVQvJzJQ2q6EhavasKWKxl/0tfhnyznvuQvqmgEuCBU5HbgsB8qYtq+2c4DsFsR6bvc6HdG768yoTMBus/PZiFGzXJFdWtB25ojd3vpBx5sFe4a/zxhpeF5JKyN5Vfc3hYFCspwY+xFBH+EIgJoQxluiItNgUMrIT676VYWEkDleZ2RJZTnrD0icQqDh4u7qmkTzDBWO+zQM1dBDiWEq+UWMeaNw+ICl8tmpz7C9rFc+fLD0pEvAAdH4oXKuzHwCal5v5AOuLleAaCGzMIg8tFHk+QTB0s3VQmf1DhXu1B6jo2FlDLatwbZu7HAYsCQD4hhLdLDeg7AgrymlZKQGNVfLSroZskzItQ4/62MUb+Dg+aOwfxQbKhH/Bd0IPn/nc1DLUA6LVUdIIXs39UUZ9LCwAeLg7K3p9OFBGru6KVX/wPUYML78eMnyEfsczR0ckaC/DTf0CId3/LnXay+iho6Dz/RKEJgSBTYNayfuiIkkTzkStqtuLkhgfa9xfYUdpPnxxQvlk80YjALgHoNVAtDSEmAtN1/SXoklMFqqILbKrSqvnsdZLpfD0jQ==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(122000001)(53546011)(26005)(6506007)(7116003)(4326008)(38100700002)(5660300002)(36756003)(186003)(6512007)(31696002)(86362001)(8676002)(2906002)(82960400001)(38070700005)(8936002)(4744005)(6486002)(3480700007)(31686004)(508600001)(316002)(2616005)(91956017)(76116006)(66946007)(66556008)(66476007)(66446008)(64756008)(71200400001)(110136005)(6636002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?TjNzTzI0bUxTMmZER1lLSkJpOFFqZ2NxNzNPU044NFZlOTZIYi83bUZTMlU0?=
 =?utf-8?B?SmVCdE1TQUZtYmtlTVRjdmhXajI0N3FlYjBqVGYxT1ZkSmFza2lnTEpkUngy?=
 =?utf-8?B?VU5JN0FIQ0t6aGtoQVZMRlhTQmhMQ3IwSk5nK3VQQ1ZVZTY0TVJxdXA4N0t4?=
 =?utf-8?B?NVVabEdPQjBsL3gycGYvZTljQnlodWVYLzZhRXFmTG9OcURKRnNqSXVPNktx?=
 =?utf-8?B?YTZsa09xeWZucWZML0V3T2UvYXUvcjVWNUxFSzdtL0tYbXF6T1RuSWlXeTRk?=
 =?utf-8?B?WUg4Z2U4WUN1OENNamQ2LzY3ZnIzUjR0S2toeXlMRTBGUXJHS1o2dHl2QXNZ?=
 =?utf-8?B?Q1FSbU9Yc3JlZFZlcXFOTXA1dEUvM3RCUFhad2hEN1oyR1BqWVJucVd5eWww?=
 =?utf-8?B?T3JtZ3VjZjFMRSt4VFRySzdKbWhjS1hyY2xFaVZxWkMvNmw1OHpPbk9Kc2VP?=
 =?utf-8?B?aStVZlRGOXBNVDAweHFZVWFTaUJkUlhwZjJKdUF0SjFNLzIyZHNwRVFpSlZv?=
 =?utf-8?B?My9NS2hNL1dXUDdZSHZ1bGJQODJ3eXZzcXhJUTQrbStLenB3SDZnMngvcDNt?=
 =?utf-8?B?K3RGcHhuZUcyaTBNVmxMSFhGRTRNV3pveU04am5ZeTdvU3FtTHFVb1Z3cGlz?=
 =?utf-8?B?dWdlc2lOdlY0ZG50eXlKOCtHa2MwS2FFTitJdkVUUy81VThRV1diTkZwbEhm?=
 =?utf-8?B?bUppSHdUTGp1OHhsNmdCTGZyRUlZcXNQWFNXMG5DaFRyRUJrT3ZUNSs5RlE3?=
 =?utf-8?B?OUQwNE14dEk2R0IxWktUaW00cnVSRURQcXlGN3E0YkFxVGZNa2ZXbHFIVXJK?=
 =?utf-8?B?b3E5UmJlNU5ucHh3c2cyZmxOS01XektvS2dyeXlCcGRCZGJTb0JLeXUzcUp3?=
 =?utf-8?B?YVYrNUtmeUE5bGk4WXlGZHpSVk9EbEFZWTdabGJDK3ZoaUdYNkR4LzhBZUpF?=
 =?utf-8?B?K1ZJWmVoRGF4M0VkOW5FVHJHalpVdHlGVER3eWFqam9sVjZUY3ZxRUZMbE9G?=
 =?utf-8?B?QzdwWk0zSGgxdysvMmEzTUdwMWp2RjdIaUdNcEtrSm5DV0tma3U5RS9LN1Bp?=
 =?utf-8?B?eVZObDNGcEw5R1dzL0tmRmNwRDhYa0xRd1g2TEtqbTF0anpTMnA2YVlmbndS?=
 =?utf-8?B?cjZRemw3T2wrYm5RVDBVdE1kc3h6NWV5YXA5dDcvclBDbkkxVGwrVWZxbmdk?=
 =?utf-8?B?SmIvVTdJeFBrVDd4OWEzU0l6UVFwc1Q2azFVWk00aW1FeVJYL3FpR25Hdk9w?=
 =?utf-8?B?NGh2Q2lBT1Q0MTdpbUxrTG4vaU1STXNsMlVwemVCS054emQ2Mmkxb2IxaGlB?=
 =?utf-8?B?YWQ4OW1BZmEwWVZmRGgwdk9BODREbVFWamdPMHl1SkwvZmFBQWMzcC9qbm02?=
 =?utf-8?B?dHRaT3grYnFNWG5OTW9NRWFOSm16NVV6b3V5Zm5qVjYxclV0RUtFTlZxTll4?=
 =?utf-8?B?d09kNDlicjUwb3I4bkhaRGdiTE1ZazU3aS9xZXJvUmRGazZzQWxMMTRHcFg4?=
 =?utf-8?B?RTBrY2NURDEzQ1F1aDh5czB3a242TWszdDByMG81aUtoa2tmTXplUjN6clZW?=
 =?utf-8?B?UklJSW0vZ2tyR0gwcGVZWG9DN3ZzRHdObmpZampDakpmbTNERWZKSEtUMXFo?=
 =?utf-8?B?cWJidTc5L0ZranRNdG5mTTg0TGdqU2NIbHduOXdPWmpOSlBaV2ZlbldRMUx0?=
 =?utf-8?B?UjNNRDBvc3VsVW8ySGwyZTA1NTJWczJhT1YrcUJSdy81enFTcUtFRnlZUGUx?=
 =?utf-8?B?Z2JqcDB0dUdZSnFaRGFsb2JjSXNSZDZxSnV2ZWV6aU5YL1BQcW9OZU5EZCta?=
 =?utf-8?B?b1l6YS8wWEhVTGVJRGFGck41cG5DV003SXZFRHAvaHJyek5BWU4zeldPNE9h?=
 =?utf-8?B?NGxTZHZnYUROU0x6ZVhnWTExUVVjOS8xNzVaeWE1VW5SQzl6YlgrWUlVM0ZL?=
 =?utf-8?B?LzlmU0tKaHhiQU9pWUozM082UFVhQk1kY0E1dm5GL3ZBdytneUFubTlUMVFq?=
 =?utf-8?B?MmJzUUk2b0E4Z3AwUzZOMldqK3JWK0t2Z0pFU3lyby9XWlpwWXlacldCbzB5?=
 =?utf-8?B?S1lYZDZOVEVYVG8rTTQ2WFRJb0VlYjBLcC8vNDZCazZDSWlLUG5rdzJ2YUNV?=
 =?utf-8?B?dlZzQ08zUUhNemdHUlhMbGZPK0VvMWxzeEo1S21KUjlPRU1oWEtDV01DYWth?=
 =?utf-8?B?Ym1YdE5LZEozVVRRdXNNTXZvVHZXQ0wyL2NxTDQxTjhCUFYvTmhPbmtYT0ho?=
 =?utf-8?B?YmNxUDhmUll4QTFhTXBlZ1RaL3dRPT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <E7AB11E4406FBA4EAB1BD6579BA56043@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7495f29c-2920-4220-83eb-08d9efa3d5d3
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Feb 2022 10:21:59.4971
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 7+AJP085rIlIOQ0ZIP1WrveGNUvHucJnKUByyvPKQpXUZYk41OYpTJtM4nuNwZra71w8yUr4Vj4KLjEwNa8MCptvcpZ3A/a8eiJ9K1q3FHg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR03MB3158
X-OriginatorOrg: citrix.com

T24gMTQvMDIvMjAyMiAxMDoxOCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IEFudGhvbnksDQo+DQo+
IEkgaGF2ZSBhIGNvdXBsZSBvZiBzaW1wbGUgdG9vbCBzdGFjayBiYWNrcG9ydHMgcXVldWVkLCB3
aGljaCAtIHdpdGggeW91cg0KPiBhZ3JlZW1lbnQgLSBJIHdvdWxkIHdhbnQgdG8gcHV0IG9udG8g
dGhlIHN0YWJsZSB0cmVlIHdoZW5ldmVyIEkgZ2V0DQo+IGFyb3VuZCB0byBhcHBseWluZyB0aGUg
bmV4dCBiYXRjaCBvZiBiYWNrcG9ydHM6DQo+DQo+IGQ5ZDM0OTZlODE3YSB0b29scy9saWJzL2xp
Z2h0OiBkb24ndCB0b3VjaCBucl92Y3B1c19vdXQgaWYgbGlzdGluZyB2Y3B1cyBhbmQgcmV0dXJu
aW5nIE5VTEwNCj4gZTYyY2MyOWY5YjZjIHRvb2xzL2xpYnM6IEZpeCBidWlsZCBkZXBlbmRlbmNp
ZXMNCj4NCj4gRm9yIDQuMTUgYWRkaXRpb25hbGx5DQo+DQo+IGRkNmMwNjJhN2E0YSB0b29scy9s
aWJ4bDogQ29ycmVjdGx5IGFsaWduIHRoZSBBQ1BJIHRhYmxlcw0KDQpjNzZjZmFkYTFjZmFkMCAi
dG9vbHMvbGliYWNwaTogVXNlIDY0LWJ5dGUgYWxpZ25tZW50IGZvciBGQUNTIiB0b28sDQp3aGlj
aCB3YXMgdGhlIHVuZGVybHlpbmcgYnVnLg0KDQp+QW5kcmV3DQo=


From xen-devel-bounces@lists.xenproject.org Mon Feb 14 10:32:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 10:32:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271378.465784 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJYes-0007Wx-Pd; Mon, 14 Feb 2022 10:32:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271378.465784; Mon, 14 Feb 2022 10:32:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJYes-0007Wq-Mk; Mon, 14 Feb 2022 10:32:38 +0000
Received: by outflank-mailman (input) for mailman id 271378;
 Mon, 14 Feb 2022 10:32:37 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KkXt=S5=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nJYer-0007Wk-LO
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 10:32:37 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6d04eef2-8d81-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 11:32:36 +0100 (CET)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2055.outbound.protection.outlook.com [104.47.12.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-31-qlTSl-meOzaVxqDn54pwGw-1; Mon, 14 Feb 2022 11:32:35 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM6PR04MB5031.eurprd04.prod.outlook.com (2603:10a6:20b:f::11) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.15; Mon, 14 Feb
 2022 10:32:33 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4975.015; Mon, 14 Feb 2022
 10:32:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6d04eef2-8d81-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644834756;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=CdbRabmxR5P8EhWmmPZ2BUPcRqpFsvxGmQkBSq8dR6M=;
	b=CfF/H1MbM+rHuYbrNyS2O4bk6VoYeRE/KwL+V7JxYHPY8kOrcO13OwziiwJph8wdpG6sZf
	d5yRYLl0Rg7PHWOP8Jz3scNG04GGrsTM9kIbar95Tu8x9VRj3W+6lX5urLCADwX6pAZQ5U
	rycegmT7BMb+ef/WE3RD5r+3n1hQCsc=
X-MC-Unique: qlTSl-meOzaVxqDn54pwGw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=UqVhylEPq942nvM+VhEee8yik3B0Magxzd5MHkHFBxvguy67FVlkEJCRGU2tQafNHNv2klN8lVEE1oPAybs8HzvhHojECs/dGJramBiVWDasnLOZegK24Q075Yn6A2KSAqAnCu76VqdycuOCGVMd96i2QqJEy2t0yu3luc/jzqtj8GMw87LOxvysIM1sWrIYDQDJnjQNRgPX1uCln1HmBqFzzAOqUyFvuWA9obOzW79IM1k0LWIQ7KHcRnbrmqLAtadYZ0VaqbJxCDEW+omY65fRw2YRehcKdxz81i7Cf2S0mKGV4k9w6JJb+Rdeh6BIYhd7IAa4MnqTZ4bu8HI/tA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=CdbRabmxR5P8EhWmmPZ2BUPcRqpFsvxGmQkBSq8dR6M=;
 b=g8ru2jAMPHNFxL8aToPekHzlDJ5zuugJBZSc+HMX0G9TrVcRbF/IhVeHZBB/lvsGgFs2DqBgWVI2qEi1wgQwm76Ct1a1f0lWEY9FbLI9Ah5bTBTJVeQ2mlbLgh4vkKodfGwRgpUSFcqinsEhroYXq2cNo4v46WX/Zp70gKqTXe6Fvl9lI2GLmDaUVGikqtx33sEkM1gJyJ/RkJlJdyUTwT2U8SKDDo9UtAQe14XFyDX1xsgPatBxRntWuOc0BF/bg+62i5chAxpDMkPRBH8PWB8F8jW35d470UBw93YBlYxxSjDWB7ALjJcU1JNwy91pkk3aZTwD2wI7SEMGTgV4og==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <7a71b56d-1f28-e0df-c89e-6fb69ff64dcd@suse.com>
Date: Mon, 14 Feb 2022 11:32:31 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: tools backports
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Anthony Perard <anthony.perard@citrix.com>
References: <710fd687-16d5-c088-d3be-749851e6eab3@suse.com>
 <6f3157af-6ab7-ae67-0080-48754d41c19f@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <6f3157af-6ab7-ae67-0080-48754d41c19f@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P191CA0077.EURP191.PROD.OUTLOOK.COM
 (2603:10a6:209:8a::18) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a7d73a1e-6e9a-4447-621a-08d9efa54fa7
X-MS-TrafficTypeDiagnostic: AM6PR04MB5031:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB5031FB983A6A14B50275F0FDB3339@AM6PR04MB5031.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	LTMDS8wZcy0sbfeH0PpQsLmwD0DbN0EBmQuQUqxmhIVmMIBTahw5RuK+E7woHlaZON0/J3tSMf4HRK1MyoGBxSliOfj+4ttEOG+VZgPZk1CLw2MAm9A6/sQMQSYvn0pSH9XNOV3dt42rS/6AAzL7pR9W8mhXrMw0HaT7tvh73fB/7zwVJQKe0v/Pfr9tjoWXuCcvDJ+z+GfE7Ss9lz5Y9juWqnNk5yCNqFZcBvzL1YEUFJIwrSjT4elY7/bpPIFgf26G8+up40UBVkpqs3euZO0D/6d3OK0HBsgqUWgOMtMRU0Cnzseee5giOLe4+PFMpBhiZ63sinCm9JZCLUrUqDYO55jJ3a3WmL9u8X1ANGoFbBI8jw8S4Htn51Ww0k7jpwWpWScxdmlvGc7D7229vzilltmXxt9vQjuqs2FM1sUFWP0Z6BjhPc8wr5MtW04tx9F7X3Rv4TpZWnP04zhokIMQ95TfPFzGN9XDoKGW4eI5tCV66WnLlgX/AasfGKfDeRzwUPjx1jHE4ec659Id4Oq9ONF+tINShOYnfUE+CvYUt5anuGbwXUQtUmTepwMJUn3lrpLlENoTOCgMfCXZkz5MNTQsb8nRQHDmnYynxxLcsnPK5BJai459ARyhx6IJ20iqrQU42BNJ+hZBLTo7LbMz8opcZjrChD8RJd+zOdloNabVdGamqN9JtguBOxJvdoP+vzF2/Yn5Yf33pZaclzRpDEV/Dj5MWen2CM1Q/aFc3YSDpcM98aAv4SA5eIfN
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(26005)(186003)(6486002)(6512007)(8936002)(53546011)(6506007)(508600001)(5660300002)(36756003)(2616005)(31696002)(31686004)(3480700007)(8676002)(316002)(2906002)(66946007)(54906003)(86362001)(4744005)(7116003)(6916009)(38100700002)(66476007)(66556008)(4326008)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?d0ZtbG40RWpYWFN6WGVRYkNBQzRvS08ycVE3S213d1hCNThlNG1XWkZpcEV3?=
 =?utf-8?B?S21rbnROZ3d1YldDVU9XYUUza3dnTDZOQzJsdUZWeXlXSHBHeHBkc2tHU1I2?=
 =?utf-8?B?VDZKbXdLa2Z2ZjJvMG8xeXUzNWEvVXJaMVhGUm9LR3k5eDhselQreFdZZmRm?=
 =?utf-8?B?VE4yZjlNRWFwZTNZQ0JUc2FmYWJONmFSaXJOU1d6QzRteWttSTJTaWM0MzJv?=
 =?utf-8?B?bm1xMjZKTGFZR040M1RwWG1ad2xYeFBsVFZGbkpTcXBKdTdqa3JiVm5tOUp0?=
 =?utf-8?B?aElUWktzMVpQR09wWUJCK3ZWSitjWHJmVmdRREQ4OFZIMTVxR1JMTDJZNkcz?=
 =?utf-8?B?L1VkSnE2RHV6Vkw1S3ZVOWtOSEt4MTVpY09YcSthTytiejBmanpHb0VOLzZu?=
 =?utf-8?B?OXBIZXFjVE54ZEU0TFFTS0hMaTZzbUhMbXdCelh4T1lEMUV6NU56eUI2aldv?=
 =?utf-8?B?VkU5em53R1hzS1dSTmdxYm84YWdPUU9RdzlrWitHQTM0eHpFbjk0Mi8reVFp?=
 =?utf-8?B?bGVqcW11dXFuK3h3aVhQV1F1bExoWllacHJhKzBoYU8vM2JsMURycVJmZmtk?=
 =?utf-8?B?NDRyNHFyeXIrNDdNR0ZOMHVpTGViRlZ1b3ZUdG1qbGlkQ2RkL1NJRkc5RG9P?=
 =?utf-8?B?YUdsM2x3Rzl5cmkwMnorNnpCL1k3MDRzRHByRkNKUG1Sd3Bmd3dmYWVjdHZN?=
 =?utf-8?B?REhVdVFPZklWNW5VODhJRHlyM1NWalp0cG9PRW0wOXlTYVFlZVU0UUE0Nnlp?=
 =?utf-8?B?cXkzTU1KNDBYVWZJUnA3bDN2eHdIcytCTGgrZDhIa3BKVDFBMi82L0dsQXRx?=
 =?utf-8?B?ZlZuSlMrMkU2YmF3STZ4UjZFaWlIL3NLZXpyQ0M0K1dmeUM1NFg3N0tEUFF5?=
 =?utf-8?B?TGRCSWtVT010eEk4cmJmY0tUdE5OdVQ3TnNTWGdXL2FpUlJiclloNm1RTVJI?=
 =?utf-8?B?eENsRGxNNTBEeWd4VnMvZlQ0S0hraEJXZW1wejdjOEpSMXoxVzN2WkVFME5k?=
 =?utf-8?B?R1RqUFJDd1FVYnNvbWZYSFVWVmp4L0pId3R0ZFE1UnhldDc4MHNDU2Z3aFRh?=
 =?utf-8?B?TkNKNVI5L00yY3h3YUFKamFubEc5d3ZGRUcrQTl1RmFTTEpYUzEyd3k1RXFD?=
 =?utf-8?B?WXFaT05xYmp6Q0ZNRHNRWGE0a0kveTJyK1hTTEd4QmR1QitjTW43bFpidzRT?=
 =?utf-8?B?TS9ubVJwMVBJUVNhbmYybDl5WnZzQkNCTXh4eVU0NkxSK003SDhsc1RndCtj?=
 =?utf-8?B?RHhQRlM0bVJzSEpoMmxMZkZqcVZKV3I0b2JTZ3NmWmZyV2dBWkE0KzlaTm94?=
 =?utf-8?B?Z0c5NHRIcFNhNHpncEhBNDZ1U3EzalVmemVYSHpPY1B2ZU1zNTJreDJodFNy?=
 =?utf-8?B?YVVoaVJhNGpvVG5rSWVMb3lTNVJ2R1YyaktKbDhxNVZVVkJOMjEveHpaaWNp?=
 =?utf-8?B?M21YL3hUdVhXRjVONGkrNm43M29nZ09MUWF2aTBCRGdpTFNFazNEVGxYa28w?=
 =?utf-8?B?bjREQlkySlFoOVUvRjlTbGFOYlhGSWl5N0U1OG9oU0xmRHE4V2xDcGdUTzFy?=
 =?utf-8?B?ZlRqbmZWWFNLUW1aS1p0WHUzWU1VOHptS2x4RmV2NXgrbmpnemU5N3lFTE5E?=
 =?utf-8?B?Y09YbGFIQnBGRkg2UGIxTVF6UTRGM1dKcVJISEd0U1Rmdk55OGl0T2drSEQx?=
 =?utf-8?B?SnUrMGZsRnpRc2F2b1BDKzRlZHNubVRQeDBDaTI4RzRVSnBwZGRodXNCazNE?=
 =?utf-8?B?dHEzbnFmZVh3VG9EYTdWTWdFamNLOFFXZEVLL3JKSjJrMlpqOGFLd2tPd1NE?=
 =?utf-8?B?cjdOQXE2VkcwN01QWDVTdG16aTNTVk8zYmx0UUhNeXBESHhveGY4anlGeFFE?=
 =?utf-8?B?NFkrQ0RQaXROM3NTN2JTZ2R1MDMzZGVXL2ljUFU1Mm54ZHo2MWxGck5xMkdL?=
 =?utf-8?B?Q0grRzhEVjl3VWxXSDQrOUorRFBOdlBMalZNei9YMFRrMjFQWGtNWjU3SVdt?=
 =?utf-8?B?MTN6d3krNm16U3VGMGpFZjhIYVhDVVh6cndvdjdkSzREVDk1UXRmQlJMSUJ2?=
 =?utf-8?B?Vm5oV0lqeUp6VEtZNnUraGtKL1VpeUJCZCtTUDM2ZUxic0lQb2hKSlA4TGhx?=
 =?utf-8?B?TlltWWNOVXc2NGRyKzRlVUlzbklNNW5VQ3FiZy9wY2JudStlRFJGMU9BYjRY?=
 =?utf-8?Q?Npq6CuSBrOS3gTSvodtKdWI=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a7d73a1e-6e9a-4447-621a-08d9efa54fa7
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2022 10:32:33.6366
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gW24tfmSkphLuS1zUCEm+LEEW52pvpzVfoeU5ColMppffn2zx67oXKGmBzFf/ZWNsBs2jV1rMCaiRN2bztJ8HQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5031

On 14.02.2022 11:21, Andrew Cooper wrote:
> On 14/02/2022 10:18, Jan Beulich wrote:
>> I have a couple of simple tool stack backports queued, which - with your
>> agreement - I would want to put onto the stable tree whenever I get
>> around to applying the next batch of backports:
>>
>> d9d3496e817a tools/libs/light: don't touch nr_vcpus_out if listing vcpus and returning NULL
>> e62cc29f9b6c tools/libs: Fix build dependencies
>>
>> For 4.15 additionally
>>
>> dd6c062a7a4a tools/libxl: Correctly align the ACPI tables
> 
> c76cfada1cfad0 "tools/libacpi: Use 64-byte alignment for FACS" too,
> which was the underlying bug.

Well, yes, that one is already in 4.15.2.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 10:34:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 10:34:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271385.465796 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJYgd-00086r-5N; Mon, 14 Feb 2022 10:34:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271385.465796; Mon, 14 Feb 2022 10:34:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJYgd-00086k-1c; Mon, 14 Feb 2022 10:34:27 +0000
Received: by outflank-mailman (input) for mailman id 271385;
 Mon, 14 Feb 2022 10:34:25 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=jzps=S5=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nJYgb-00086c-Cs
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 10:34:25 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ac30901d-8d81-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 11:34:23 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ac30901d-8d81-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644834863;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=1K7QpBsf61UgIbizoELgKqH/McdEYZCIUsYc92CX0Ws=;
  b=HPYOY0RVwZl5y86ejJ1BHVhPa46lXQKZM3L6qohGe7zy6uNj9QA+gGR4
   HUc4BU4JpxOkR58XeB6iJdKOERsVKNXq7ElyB47ut5dTV34QEoZ2Y1ZOh
   KpZqebbr4PwAS9DOwpBjhsUcj8EnwXGrqXRI0Dlo/2oNf5tozzaZolXY7
   0=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: 76OQfkmBvS5FJB+kS8cd7h1xjaWZH2B5lLKGydugqQMieh+tJNjpU6gKw9sdvr7FEakNP2kOp8
 G9+rE8p5kf2++H/6+40M0ipWRUzj+xSdMulF+x+Ox5+Z6eJGT5kte7wtazeG/e72FMMNxhgQRD
 phqdpz92aG053z9uTPIVAVzvWxSiwyCo60V4q28BqQ/sG4WEaUTc3giL6rkqHH9rHk6NvEPEvW
 k899bwDERwA19oGsV/5IQwI3Hvsk1rrjUlY1oL8cQEsI+y3iplPtMULxL1cvL9oDxYQZq28GSH
 bog4CRUssZZgzpAxM6UMaC1T
X-SBRS: 5.1
X-MesageID: 64546006
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:OmcUwKrHHoT5M46tCfCIG+BsUcNeBmIRYxIvgKrLsJaIsI4StFCzt
 garIBmFP67camr8ctEgYYiz90kPvsTQmN5rTVBv+SwzFC9D8ZuZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlZT4vE2xbuKU5NTsY0idfic5Dndx4f5fs7Rh2NQw24HlW1rlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCnZqRTgwmFLLPpN0+TUMBGB97HqFA2paSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFJkYtXx6iynQEN4tQIzZQrWM7thdtNs1rp4SQKqAP
 5JHAdZpRCvqbRhiNFc5M7sVgd2OiV/ZI2RCkl3A8MLb5ECMlVcsgdABKuH9RNuOQslEm1eCk
 UjP9W/5HxIyOcSWzHyO9XfErsjLkCDgUYQeDoqE5+Vqi12ewG8UIBAOXF79qv684maXQc5SL
 nsx6yUnrKUs3EGzR9y7VBq9yFaetx4BX5xLEus16CmE0K+S6AGcbkAOQyRdctUguIkzTCYzy
 16St9rzAHpkt7j9YWKQ8PKYoC2/PQARLHQefmkUQA0d+d7hrYovyBXVQb5LN6q4jcb8Hz3q9
 BmMoDIjnLUYjcMN1KKT8EjOhnSnoZ2hZgw/6xjTX2mlxhhkf4PjbIutgXDA9upJJoudSliHv
 VAHltKY4eRICouC/ASPXeEMEbeB9/uDdjrGjjZS84IJrmr3vST5JMYJvW84dBwB3ts4lSHBZ
 m7Usgx7+5xvBVi0N/Z8XYeSB8II5P21fTj6bcz8Yt1La5l3UQaI+iByeEKdt1zQfFgQfbIXY
 snCL5v1ZZoOIeE+lWftGb9BuVM+7n1mnQvuqYbHIwNLOFZ0TFqcUv87PVSHdYjVB4vU8VyOo
 76z2yZnoiizsdESgAGKq+b/znhQdBDX4KwaTOQNKIa+zvJOQj1JNhMo6epJl3ZZt6pUjPzU2
 Xq2R1VVzlHy7VWed1nWNSAzNe63BM0lxZ7eAcDLFQz2s0XPnK71tPtPH3fJVeVPGBNfIQ5cE
 KBeJpTo7gVnQTXb4TUNBaQRX6Q5HClHcTmmZnL/CBBmJsYIb1WQprfMI1u+nAFTX3HfnZZv/
 NWdOvbzHMNrq/JKV52NNppCDjqZ4BAgpQ6FdxWUc4cDIB22qOCH6UXZ15cKHi3FEj2arhOy3
 AeKGxYI4+7Lpo4+6t7Sgq6Y6YyuFoND8oByRgE3NJ66anvX+HSN24hFXLradDzRTjqsqq6je
 f9U37f3N/hexARGtI91ErBKy6Mi5oSw++8Gn1o8RHibPU62Dr5AI2Wd2ZUdvKN62bIE6xC9X
 ViC+4cGNOzRat/lClMYOCEscv+HiaMPgjDX4PlseBf66SZ78aCpS0JXOxXQ2iVRIKEsaNEuw
 Ps7ud5Q4Au600J4PtGDhyFS1mKNMn1fDPl36sBEWNfm01N5xEtDbJrQDj7NzKuOM9gcYFM3J
 jK0hbbZg+gOzET1bHduR2PG2vBQhMpStUkSnkMCPVmAhvHMmuQzgE9K6T0yQwlYkkdH3uZ0N
 jQ5PkF5P/zTrTJhhcwFVGGwAQBRQhae/xWpmVcOkWTYSWiuV3DMczJhabrcohhB/jIOZCVf8
 ZGZ1H3hAGTjc8zG1ycvXVJo9q74Rttr+wyewM2qEqxpxXXhjeYJVkN2WVc1lg==
IronPort-HdrOrdr: A9a23:wCjSlqt8Fh3CFSHPHxzhSYfs7skDjNV00zEX/kB9WHVpm6yj+v
 xGUs566faUskd0ZJhEo7q90ca7Lk80maQa3WBzB8bGYOCFghrKEGgK1+KLrwEIcxeUygc379
 YDT0ERMrzN5VgRt7eG3OG7eexQvOVuJsqT9JjjJ3QGd3AVV0l5hT0JbTpyiidNNXJ77ZxSLu
 v72uN34wCOVF4wdcqBCnwMT4H41qf2fMKPW29+O/Y/gjP+9Q+V1A==
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="64546006"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=EwRWFQ8rsekNSXwm1it7e54XqbMRVwNemwAvMLiG7sl4isGtQ48zUZ+E2QN7Op104m+eujYdOpct7xfRczcaMA9n5N23qxZzW16RGLpyus/paKo8r85sB4ixNTvyCuflJJIssllM7kg30mhp6rdEfshVZKQ9H9w+L8sKxGyQMMb0CijaxbXFWFzzZmi8OV431ofoIuOwGMBDPREmdsonQcnDwZaLysR6eEIxHpHDUiBjA6vnCZjVHwW/f5zwaLpLZ36JqaafWC4USKI86ijX1KZc0ErZEOb/m4A09FMT6GVSSzi+F01FwIl7yLtZk0SYxdb4Jp1N7OSGXCkk2yBNwQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=vqJWdz4JBMkBkzUw2CFYm6S3JoAdOb5DfgABmNHPOfY=;
 b=jnyZkzeHEHlZCzKqbTVhVewpzH6l5m7elPMX8gzCj8Ilwq24rKSdMKNVliZGa8SUPKx5FkvRvR6G4JXRmhpVl0zAZiKoLNvt9825mksNL/1HX2s9wb21ShruCnxEu4DH12ZhmUwg4oCnbASu8XDXOw5N87JlGGXAQSvkHxF3woIAHPU+r42IGmh5TFjxg2OpwiCKVhM/EpQr8E0VjOXS/Hyo1cY5ikc3OTGRfE9mgmBkIGQJDI0PQCxC8aFz9PUMCp4KIucP65SnrQnRKPcp9Q050GbiDqfe1ZMnHUmeHnJGdqoodUHS1stAQXEg1EznonSXaMK9IG6Yr5Qbq5HxMA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=vqJWdz4JBMkBkzUw2CFYm6S3JoAdOb5DfgABmNHPOfY=;
 b=i4euMjxZr5awSlggfgQ83fo49UNtuUA4IN3CzFC+38ear9mrBcWGz3+MpBNd3ykGEiVQh9Yq8rsRiMyu/c4TO/+Pfjzme/2oeyXx4vnCxoJSxaTSD+w1L0HlrRueCOyNPCxkD7byGnbxUkLMMroL8ON3bUFujXa/wAQ7LVbLIoA=
Date: Mon, 14 Feb 2022 11:34:10 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"jbeulich@suse.com" <jbeulich@suse.com>, "julien@xen.org" <julien@xen.org>,
	"sstabellini@kernel.org" <sstabellini@kernel.org>, Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Artem Mygaiev <Artem_Mygaiev@epam.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>, Rahul Singh
	<rahul.singh@arm.com>
Subject: Re: [PATCH] vpci: introduce per-domain lock to protect vpci structure
Message-ID: <YgowIg5MvTaf2zsR@Air-de-Roger>
References: <20220209133627.959649-1-andr2000@gmail.com>
 <YgU6Snk8GTytJXZp@Air-de-Roger>
 <c4666570-666e-6680-5ec2-adf1da51ad06@epam.com>
 <YgZLEMW9US9QjjYG@Air-de-Roger>
 <33fb1095-64ed-29ef-ba6b-cbde21d941f8@epam.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <33fb1095-64ed-29ef-ba6b-cbde21d941f8@epam.com>
X-ClientProxiedBy: LO2P265CA0037.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:61::25) To SA0PR03MB5610.namprd03.prod.outlook.com
 (2603:10b6:806:b2::9)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f134c820-b2c9-446a-9d41-08d9efa58d18
X-MS-TrafficTypeDiagnostic: MWHPR03MB2431:EE_
X-Microsoft-Antispam-PRVS: <MWHPR03MB2431FCC3709382278D9160DD8F339@MWHPR03MB2431.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: VA+A3LxK4jVOcRoy8D1WggObdAcsvPKPSZAmWEjPL9vCSwg2K2XOrPHMAk/iiAo6+eUNRTFHPILt7FJ9LCfisO7pzFxfn7zRXb/AvLQVljQrVeUiGByCiJPzsUU3dXNSbAueCTYiNL7yq2ifq+q8sUa7ChPBgS6hCjfq02SIwSC1O9dKIMKIVDnxta+2R0PKPPTSu4eQh8E9YK4GGZG+vGvnyuAeEP9xFGYS3UM9pxa3NlOLcLq3AZlb+Kn8J8iPAW6IQ8dr6NnW6ubuJ3XhSWoeBRVRypWCmAT8cgqLeSIfqFY7Vhv/y5OL5WFRsIV7eSki8jnHhcnhOajD4xLYJO+/TIuGDs/KlQhWcOWj7vujziyovFIaA/mDzSwlBCS5G43PJ/LRs9zMGmVPS3ikFpgkJSEMihPkl6ua9c+nE7+kVznHxYlcoW1kcl0xwwXt5+FBH1XqXA9lUOSqt9FTM87bi9GsdPusqfbrAvRX+OxbAxAl9+BcyZpOggUoycGgVViAPYx/e9Ul48HyOEqsl4s58aRj5NIaMv0l0+E/L0R2KgNNgAUJ8QhFS7fHbj4VbrljqOyju7XsC33jzso8vyvNbezetvDmxMSdZATzBnbpk2UIZP1UfnT0eap0Mdcj0TaOAh8Ck6TKzM4JPoY7ig==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA0PR03MB5610.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(7416002)(6506007)(8936002)(5660300002)(53546011)(186003)(26005)(6512007)(9686003)(83380400001)(2906002)(38100700002)(316002)(82960400001)(85182001)(8676002)(33716001)(508600001)(86362001)(66476007)(6486002)(66946007)(66556008)(54906003)(6916009)(6666004)(4326008);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z3FDRlFVMVIyczZtMUtYbzkwOHZMQ2lMRHRZYnlNbmpsWVlZenk0NG1DVFBU?=
 =?utf-8?B?cmZNZ3QwQlRURHF6QmlBdkZjdnlHR0dSSUV4SVhaMWxycGg3SmFwVkJBMnVx?=
 =?utf-8?B?dGx5WG5hNm1uZlhmUWc3d3B3UGNPZVoyV0VjLzhZK2o2K1M5Yk1oemlmd0ZF?=
 =?utf-8?B?MWh4clZLT3JRV243KzQ0QkUyTFNLMVRDRDhEeEkzRnZJdllNcE83WDlUZ0Nl?=
 =?utf-8?B?bTFPVVlqQXFCdEZtd0RHMmxJdU9LakM3VDBVNUZnUEl2NkQ1clFGSVdlMGhR?=
 =?utf-8?B?SytvTWM1RCtHZXVtbWhhNFRyWG5NMXl5RENPM3JMWnA0aktMdjlneWV0d3Vi?=
 =?utf-8?B?V3k2YVlJSXM5Q0ZYaUw1aXh6MUd1eU1FZ3NuaHNaZmV6Sk8rK0NJRWpiMTh0?=
 =?utf-8?B?SWJMWDlSa2lRUGoxNkIxN0JLbVJLQmN1aU9id1B4RVJHYjhQZVpHNkEvdFht?=
 =?utf-8?B?RkVNYjJneXZxVVNqTnlxc2V3UzhtYnp0K2hvbnNrNm5kS0F5d09hdWcvUUV4?=
 =?utf-8?B?bzF2NU44Ry82ckxHQnY0MU03aTQwbVVKMXRmbTdkZVRTZk8yNzJYdGhZelBP?=
 =?utf-8?B?LzZoODVSZlphK25WdmhNN0pydmdPQ1ZwRTRwV1hnaDJ5TWVvTXllV1NCSjBp?=
 =?utf-8?B?UHlxT0s3Q2Jzck1US1A1Rml6dERKcWZRZkFnUWhVMHFydWpPUnF2NnZDVVk0?=
 =?utf-8?B?bnArNFNxL2dxUUhSaGJWSjY1ZzV0Ymw1SnBYMUNURHhoT0EvVkdBTk5NQUhk?=
 =?utf-8?B?dWs0ekkwMEdVaWtBcXYvY3ZNa2RMVnAzNjhoWUVVNU1Edm0yVVI3bFozZ0Fm?=
 =?utf-8?B?Vzg0OHJEQXFHVmxrUHhSNGpKc1FxK3kzUG5CUnBqdHRrQjJjcXZ1WjNMbFNr?=
 =?utf-8?B?dm1pd2o0Y3QrWU1HM0VXdVB6Zk0yNG1PdG1kOElJbDBYSFNleVJlQWwrcFlw?=
 =?utf-8?B?SEp2U0VIekdXNmRaR25PVlA1eFhwY3k4eXVwQ2ZCQzV2R2ZibXVqcC9WNnJi?=
 =?utf-8?B?ek15c3I1bTgzL1I1WGppYmxSWnd6U3RIWHdRNmdWV1djbzFtYnd0UUV3WjhL?=
 =?utf-8?B?azdDWkFzNVdpcUxrOTAwYkZ3M1o5MWpBeGhSMndIRWJJYnZ5ZG83MjY2dGNj?=
 =?utf-8?B?YVoxVnRENGtWbG9kbGxlRlQ0enVMWW9haWQvRGRBLzNiMzNFeEhLNlA1UjYz?=
 =?utf-8?B?c1pRbHBSdlprMHNUNElqRFMrMXlqVGtid3JVTmg4bXg4ZUU1TGdaSjhwZFd2?=
 =?utf-8?B?em9WMlVGeVBncE9Xbm1QR0thaENhbExLVWdJaDRKb3NKaFJuUmhkTkxSNXRm?=
 =?utf-8?B?WkdzQUUyZXRLNDV6YlpRcGFYaTVNbERGMDJrYTdnMkF1RHA2S1hQZVFINC9F?=
 =?utf-8?B?YkhmZlkwL1JTWFZPdUxPaDJLSVExMnlxejJqZUNya0JjRkhFbVBLL3k2Y0NQ?=
 =?utf-8?B?ZlBrZCsvM2NvWmF1aC9Lc2JJZmE0N2hnTTcrT0Fidm05UmdnZnk2Y1JaMG9i?=
 =?utf-8?B?RDVZbFRtR3ZEa2daeXl6MUsxc0FmUWlpSmdPbWFMS0tsU0o0cTJSSG04OW1Y?=
 =?utf-8?B?TG5ONFVZaXIrR1RwTFliTWhiODd1SDF3MFJkNDd1ZlJJa3pDWjRXbE1OSTVk?=
 =?utf-8?B?c0FCbVhQZm5GS0RVdmtHdHVDVU9mOVFwUG5GM1BoVFJuVXk2MWlyL2RBNmdQ?=
 =?utf-8?B?QWREa2hJeXFLUFpNUHRPSm1NNEN1TFlCUFRvOVFqWTdLTGs1STdGeUo2Tk9l?=
 =?utf-8?B?dlQ0YmZUb0FCT3VqQ3MxS1JYRlQ3T2tZT2xxYm8yVnprL3NsUitaY1ByT1V6?=
 =?utf-8?B?ZklRM1c1TVQrNXNPWDhLY2h2VFk2Q25ING5tZmJCaVVKbFJwRjBablMxbVZO?=
 =?utf-8?B?WlBHTTBzc0lmNnJQYXhtbHYva0t5T1YxMm1VeUlSbHN5Q0NYeWx6RXV0VHhj?=
 =?utf-8?B?MG93TExIZnBYM2hDVlVjaExiRUdMU2VtYURuWnZHTW91WnozRXRRL0hYRUFP?=
 =?utf-8?B?VUE2aHFxdGs5N2h2SVFjaTJ1enkzWXVEYTl5Yms3MlJkK1ZnYnJOaG5qUWFp?=
 =?utf-8?B?c3M3eGRmNzRTd0pJNWdGUFRseDVzVjBUajEraXliQnFvRUROVmFUNnFaWXdX?=
 =?utf-8?B?UFpRWlNjOFJWTEUvT0EvOHBYQjlNVXV1UEJHeXVOWWp0dWtjUnFyRlR5OTVQ?=
 =?utf-8?Q?bW+p/eHSe7UGGv8qYy9uzJQ=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f134c820-b2c9-446a-9d41-08d9efa58d18
X-MS-Exchange-CrossTenant-AuthSource: SA0PR03MB5610.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2022 10:34:17.0946
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fAxjXeVOjyyQoPkoWiKyOPCRh6do3YzCyl8dsmqS1X5SOM6w6fI2RJdqavlmUUUqFxNwkuNXHHAkBUxRXh8PRA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2431
X-OriginatorOrg: citrix.com

On Mon, Feb 14, 2022 at 09:36:39AM +0000, Oleksandr Andrushchenko wrote:
> 
> 
> On 11.02.22 13:40, Roger Pau Monné wrote:
> > +
> >>>>        for ( i = 0; i < msix->max_entries; i++ )
> >>>>        {
> >>>>            const struct vpci_msix_entry *entry = &msix->entries[i];
> >>> Since this function is now called with the per-domain rwlock read
> >>> locked it's likely not appropriate to call process_pending_softirqs
> >>> while holding such lock (check below).
> >> You are right, as it is possible that:
> >>
> >> process_pending_softirqs -> vpci_process_pending -> read_lock
> >>
> >> Even more, vpci_process_pending may also
> >>
> >> read_unlock -> vpci_remove_device -> write_lock
> >>
> >> in its error path. So, any invocation of process_pending_softirqs
> >> must not hold d->vpci_rwlock at least.
> >>
> >> And also we need to check that pdev->vpci was not removed
> >> in between or *re-created*
> >>> We will likely need to re-iterate over the list of pdevs assigned to
> >>> the domain and assert that the pdev is still assigned to the same
> >>> domain.
> >> So, do you mean a pattern like the below should be used at all
> >> places where we need to call process_pending_softirqs?
> >>
> >> read_unlock
> >> process_pending_softirqs
> >> read_lock
> >> pdev = pci_get_pdev_by_domain(d, sbdf.seg, sbdf.bus, sbdf.devfn);
> >> if ( pdev && pdev->vpci && is_the_same_vpci(pdev->vpci) )
> >> <continue processing>
> > Something along those lines. You likely need to continue iterate using
> > for_each_pdev.
> How do we tell if pdev->vpci is the same? Jan has already brought
> this question before [1] and I was about to use some ID for that purpose:
> pdev->vpci->id = d->vpci_id++ and then we use pdev->vpci->id  for checks

Given this is a debug message I would be OK with just doing the
minimal checks to prevent Xen from crashing (ie: pdev->vpci exists)
and that the resume MSI entry is not past the current limit. Otherwise
just print a message and move on to the next device.

The recreating of pdev->vpci only occurs as a result of some admin
operations, and doing it while also trying to print the current MSI
status is not a reliable approach. So dumping an incomplete or
incoherent state as a result of ongoing admin operations would be
fine.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Feb 14 10:35:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 10:35:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271390.465807 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJYhF-0000G1-EI; Mon, 14 Feb 2022 10:35:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271390.465807; Mon, 14 Feb 2022 10:35:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJYhF-0000Fu-BC; Mon, 14 Feb 2022 10:35:05 +0000
Received: by outflank-mailman (input) for mailman id 271390;
 Mon, 14 Feb 2022 10:35:03 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJYhD-00009q-GR
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 10:35:03 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c2ba31f5-8d81-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 11:35:02 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c2ba31f5-8d81-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644834902;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=QFE2DIl/Ie7gzfnmO+D9RWOr4Uik6UQDTVuD/Xn5gDI=;
  b=J2Wv85NHzUE1/m9TwL3yhnWftWosoxveKnScrc8aiZdJ/Okpvf2VvTHY
   MYhSKm+f/l9rFOeSt5wdInqvnMB0gL9FSsBIyO1YToV/xWACHThZkyPtv
   uuQXUF4Ty0bwob4fESM1XgHUubMis0PwvGQ2ftppdNCerh7r1cYN/AoRl
   M=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: UiOY1U4cqR3t7qoW2qN6joT9BJhhKYaXTl05ZBUzhsP8uK1r8dOcy4eFq+bw2oUw2pJRALq5i8
 nudI64AeWUwU2xkVQ+lPh8pDXWwhqBVMQJHJJAjIryaIQaLhKSXQVJMQS3/Ax4i9MJRbAqrMlN
 v4tUxIquLLqtRGEGBWSnk0I4FEzcfqxeYXJBiolXlgNuussSwD46ZJDxGW4zCv8li4m8/pn3Vc
 JM/oEIM513laFIqEWElfNyoGdqcKbGxYmkUCkjChbd57baWGWhmq8fYpcluc98MaXni7WWBIiP
 2sKTC/sRl8iyvbusxTA/z2r5
X-SBRS: 5.1
X-MesageID: 66366182
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:aAp+eKPRl7Th4nLvrR1lkMFynXyQoLVcMsEvi/4bfWQNrUp01TxRy
 WNMDDiHMq6Pa2T2f9t3PIzk8EoHsMTcmoI3Ggto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6UUsxNbVU8En1500s/w7dRbrNA2rBVPSvc4
 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq
 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYow2Xxu5vw
 9VGjtufYygLHZXqu7kmaTANRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs
 6VFdnZdNXhvhMrvqF6/YsBqit4uM4/AO4QHt2s75TrYEewnUdbIRKCiCdpwgmlr2J4XTay2i
 8wxcDFjYSXbbg9zPUYaN6sgh7aEhGbZfGgNwL6SjfVuuDWCpOBr65D9PdyQdtGUSMF9mkeDu
 nmA72n/GgsdNtGU1XyC6H3Eru3FkD7/WYkSPKal7fMsi1qWrlH/EzVPCwH9+6PgzBfjBZQPc
 CT45xbCs4AK6hWVUNL9VCb/j1SrnD0kffkNKNcTvVTlJrXv3y6VAW0NTzhkYdMgtdMrSTFC6
 mJlj+8FFhQ07uTLFCv1GqO86GrrZHNLdTNqiTosEFNdi+QPtr3fmf4mojxLNKeuxuP4Fjjrq
 9xhhHhv3u5D5SLnOkjSwLwmv95OjsWTJuLWzl+ONo5A0u+eTNT7D7FEEXCBsZ59wH+xFzFtR
 kQslcmE9/wpBpqQjiGLS+hlNOj3u6raYG2B3AY2RMNJG9GRF5mLJ9443d2DDB0xbpZslcHBP
 Cc/Rj+9FLcMZSD3PMebkqq6CtgwzLiIKDgWfqu8Uza6WbAoLFXv1Hg3PSa4hjmx+GBxwfBXE
 crKKq6EUCdFYZmLORLrHo/xJ5dwnXtgrY4SLLimpymaPU22OiLLF+dfbQfmgyJQxPrsnTg5O
 u13bqOi4x5eTPf/cm/Q94sSJkoNNn81Gdb9rMk/SwJJClM2cI34I/OOk74nZaJ/mKFZyrXB8
 n2nAxcKw1vjn3zXbw6Nbyk7Or/oWJ9+q1M9PDAtYgn0iyRyP9734fdNbYYzcJkm6Pdnkax+Q
 c4adpjSGf9IUDnGpWgQNMGvsIx4eR23rguSJC75MiMndpttSlWRqN/pdwfi7gcUCS+zuZdsq
 rGszFqDE5ECWx5jHIDdb/f2lwG9un0UmeRTWUrUI4YMJBWwodYycyGo1605OcABLxnH1wC27
 QfODEdKv/TJrq807MLN2fKOobC2HrYsBUFdBWTas+q7bHGI4mq5zIZce++UZjSBBnjs8aCva
 OgJnfHxNPoLwARDv4ZmSus5yKs/453kpqNAzxQiF3LONgz5BrRlK3iA/M9OqqwSmeMJ5VroA
 hqCqotAJLGEGML5C1pAdgMqY9OK2ewQhjSPv+8+J1/35XMv8beKOamI08JgVMCJwGNJDb4Y
IronPort-HdrOrdr: A9a23:bIaJEql3zEx8/kPytZNyAKLqOn/pDfOIimdD5ihNYBxZY6Wkfp
 +V88jzhCWZtN9OYhwdcIi7SdS9qXO1z+8R3WGIVY3SEjUOy1HYUL2KirGSggEIeheOudK1sJ
 0PT0EQMqyIMbEXt7eY3OD8Kadb/DDlytHpuQ699QYUcegCUcgJhG0ZajpzUHcGPzWubaBJTq
 Z0jfA3wwZIDE5nCPhTcUN1ONQryee79q7OUFojPVoK+QOOhTSn5PrRCB6DxCoTVDtJ3PML7X
 XFuxaR3NThj9iLjjvnk0PD5ZVfn9XsjvFZAtaXt8QTIjLwzi61eYVaXaGYtjxdmpDs1L9qqq
 iIn/4TBbU115rjRBDynfIr4Xi47N8a0Q6n9bZfuwq6nSW2fkNgNyMLv/MnTvKQ0TtfgDg76t
 MX44vRjesmMfuL9h6NluTgRlVkkFG5rmEllvNWh3tDUZEGYLsUtoAH+lhJea1wVh4SxbpXWN
 WGNvusr8q+sGnqG0zxry1q2pihT34zFhCJTgwLvdGUySFfmDR8w1EDzMISk38c/NZlIqM0q9
 jsI+BtjvVDX8UWZaVyCKMIRta2EHXERVbJPHiJKVrqGakbMzbGqoLx4r8y+Oa2EaZ4gacaid
 DEShdVpGQyc0XhBYmH24BK6AnERCGnUTHk2qhlltFEU33HNczW2AG4OSITevqb0oIi65fgKo
 WO0bptcoreEVc=
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="66366182"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=QxcrzXsZSLS+tF6nxynWsZeP/UrFZCP2tfHJt+QeKEWSgGUQGPtoKDt5VQMXTodpEbCu+l3QntsAK6Zsixjd+iRbiV9wbejVBI7/EcBMv7qHEypLA9hXakuK27nc0QtKj7IYfHf+gPD2QAIXV3Zql8i46IV69ZGNLnV9fDpXSptkBPvTRA/rqjK7mLLdYmwOz/qSq/ORzZ6B7g5dsjsgBplqVlsTUxz9v4MGzwc6Bw1B7xrAV5jJT7kRkmEkzfbqxsmn5TauDwdLz0HupNupDPLGUZnTbrJ0YaO7j3IhARGTUGHDt11xF8sB+k+Fn2twzD0pam2zrcQbJxdusBiBYw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=QFE2DIl/Ie7gzfnmO+D9RWOr4Uik6UQDTVuD/Xn5gDI=;
 b=kaACbmOXJCTk9pB6S0cZN3ftmDDUehYhl9lHw5RS41brZCE53K+ZIqXQ8Ht/cziCPdUyU7Mg1TvaysRqEYuc/SSEGMCOYSZK+cLTj7fhYn4z8xqdh3PzDyBrthQgMEXKo5ljgygNqUTH2wSQG1voPr6j/iCYvzJb0VPtcs90tR1ca3ZVuunDqLAkBKrGnA/t4btk5KJeCBbUSay8i+/eRaYTyOr3/NiZasysGJoeWMD41xfhJGD6pgWlk4ib1jOVBMRd+WE3lgDLDt9tlpKwj0IUW5Tu3ivsVlFyPb7057hjCkr87t7d0v9py/OzzaolNajHSAivfzH2w71EUXdG7w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=QFE2DIl/Ie7gzfnmO+D9RWOr4Uik6UQDTVuD/Xn5gDI=;
 b=oXNosxhKs8astVZXIk4eZn6iA/sB2L4hliXVu37ScYhSG+8dddakp2DtsgBPL5fUlnuPj8bQ/5HvgdHoHTxLvITwWQAL5U/sgOrm41lk7stm02XMxC/08/yIgaobClvrW2EsrYtEJfI+CZI41m74NInL19yU956pp+zvhSxO6EM=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>, Andrew Cooper <Andrew.Cooper3@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"Anthony Perard" <anthony.perard@citrix.com>
Subject: Re: tools backports
Thread-Topic: tools backports
Thread-Index: AQHYIYxOf3hnmEAHzECVq7GqiCZgPKyS1kwAgAAC8oCAAACrAA==
Date: Mon, 14 Feb 2022 10:34:54 +0000
Message-ID: <d806c100-0f11-fd2c-db7a-9806d936154a@citrix.com>
References: <710fd687-16d5-c088-d3be-749851e6eab3@suse.com>
 <6f3157af-6ab7-ae67-0080-48754d41c19f@citrix.com>
 <7a71b56d-1f28-e0df-c89e-6fb69ff64dcd@suse.com>
In-Reply-To: <7a71b56d-1f28-e0df-c89e-6fb69ff64dcd@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: c5d59cc2-8bfd-4fa4-f111-08d9efa5a3f1
x-ms-traffictypediagnostic: SJ0PR03MB5439:EE_
x-microsoft-antispam-prvs: <SJ0PR03MB5439E5AF9FA99C4A20A011CBBA339@SJ0PR03MB5439.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:7691;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: q43xaR5uVwvmCBXpINzXbykSsbv/qTXf8oi7gbnGyLjBj5c2FieSToFjtkM+oZb315EcOrSiA1eksWt693iyBTr//j7h6vgmaIIGgPezg0d0SotTm6k/42qIhHakLsYjBGIqcSSMDm/wtZhBXLgyzthEK0MoIl3dIuf0tVv4g2lCDyuZRo/FL7106PCOI9bSquK9ETKXLfCM+A5xjDqRXhoMGPVjDUSEQ0ls5uic6ATGM8JSm85/JqxiBPZvqa4Jhkt5O+1AHpn+QNI052TWAziw/dfDccH3Uz8mY+HMQdbQ2eKWrZntixvDK4P246mJUr0m/NK9XhGRyO6WBa6Ah/piBOq1HXMQ6GheJNYYKZmJBlPqqe98NfsATpPPjsWvl3gTdFnh8AndpXmOt7M2afHZQgoP3j2AOg01M1lkIFcbfIEhObO+Naf0k8lJ2d2gwF/CJ88+OAmKV6uMKwVuCXOcpXd+ar6cGSZpDYaY45vBbJNMS8A7cWW8J3YFjxY0auSOByEvykW2vBnIWCU0CEfapwl4LgLQKhA5l4oV0Euki2W0gdgC2yaVWwNnMjnPff3ry4NpGPfaq4vr2oDyPZPYz42REEu+qLeEQgAoQ4VoE1sg34UkjUgC7es6Vl1O7tf6wDdVfv6099rRkNjIXBNVqa9NB7EYskF8Wl4IFDgU4Sbljt1pSmJal48M0VXpF3bsJyeZ6ZeSScpHKSDMpkQ4kRKWcz00pU3ftfY8AHAPqZfPfZDx3xC7NE8wHIOrKRdLDuUddJIxa3LxDaK0jw==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(26005)(91956017)(186003)(82960400001)(122000001)(31686004)(71200400001)(2616005)(38070700005)(5660300002)(6506007)(6512007)(107886003)(64756008)(36756003)(38100700002)(54906003)(4744005)(316002)(66476007)(76116006)(66446008)(66946007)(4326008)(66556008)(8676002)(31696002)(2906002)(86362001)(110136005)(508600001)(6486002)(8936002)(7116003)(53546011)(3480700007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?UXdFWGJaVTdVaUx6N1NHWlNYd3dZNS85aE9wRHdIK0Q0SDk4Ym9PSjF4OWhE?=
 =?utf-8?B?dnJxKzhJeHJsVkIwbVVta0poUG5CenVNbjlrbkJBWnlVTEpOOFhnNHRacVZS?=
 =?utf-8?B?RHBjdmRFMk8vSFQvdCtNUllYZjN3S3JDNTNPUjEweWpyR1hxRGVLZVJDU05v?=
 =?utf-8?B?VEFOeGtRNzFIa29nT0g4Nk9EMkRza0FlVkRWemNsWllIMlJoU2FEVEtUWUZ2?=
 =?utf-8?B?QVJka0E4bngrNDkrUWsveU1nMElkTzYwMnJmZ1NJZkZWRTN0aEZ0ZGVpbU45?=
 =?utf-8?B?ZHA1eDhQWHVMSXdZa0hFb0lpRjVEeVhWbnZCNFRUY083d2lnbDZIQnI2OU5I?=
 =?utf-8?B?alRjVVJZV0p4WncwYStRNG9KYkMwa0poWTFGUjA3dk1CTmI3SWw1aExrTG43?=
 =?utf-8?B?aUsxSDlXNFFsYkxRVnhqNFVDSUlCOUIzQi9DR0Nneit3WXVCVHpxcnpXSHRN?=
 =?utf-8?B?Q2tVdlhVanpCTTZQcFRYQW5BMHNzUXgvejJjR0FwRkxrL09tUnl4MW9sWGFB?=
 =?utf-8?B?TlZsQkU2N0c1ZG5BcWZMR1FrbVlydkhKdEVzQ21zQUFQZnZuNEZhQy9rUk5Q?=
 =?utf-8?B?d3ZFeE0ydFQ5Tk4yTVhGSDBFNnhYRi9UY0VoOHlvbnRkRFhIUVoyT0hzYkIx?=
 =?utf-8?B?LzVFZlpBTzVPU243MmZtSWZSUjA2WFF5MnZlMXVobmVCZG1YV3Y1UXNwa0F6?=
 =?utf-8?B?UDhmMDVWTzgxN2dnQXI2S242QnlZN1lTZk9mUjBnV1JmZFJEeDc3L2JMTFJI?=
 =?utf-8?B?ZzYzcDdIYW81ejJPMWxrQTlRWnJFdWs1WEJlV2hFSUVtWWpWSlQ1Qm8zd2Zw?=
 =?utf-8?B?RXE5cmxXUXk2WnpleDlDV1lvYk5ZUWNvTVUxdENmVml5UEVGdU9EamVwT0h2?=
 =?utf-8?B?YnpUbEtKMG5RL0QwS3kwbTNxbHZER0RyclBxSEQyZEVLY1BqM1l0TG51UXlQ?=
 =?utf-8?B?ckQ2OHBGcjhLcUQyNitRZEdRdnI3b0NZYjJ1RUhnSXAwZDNJbUdwS1FxbThz?=
 =?utf-8?B?d2YwS1psYnc1b0dtSEhzdHViNkJ4d3JKcVphSjRCc2Rrd1dhRkNaWVN4V2tl?=
 =?utf-8?B?N2dPeFVqbnVlWm1lZy91b2JKaXhCSWw0a01sQjAvSWFkd1FPc29SZk1uUTBL?=
 =?utf-8?B?eHg2VnRiV0czU1ZyUkJmUUMyNFp3WjRMcVd4RFdlOUVvZ2tGU2VseFg1ZmZn?=
 =?utf-8?B?U2kzbkRveWZDVmxOaW5waWhGZjNCd3JDa1VHRFRXamJRcGVlRmtDL3p3Uyt0?=
 =?utf-8?B?VnlTejNOVnN1L0thUUNuRnNNQ1ZOUE5yNkNMSE1hYi91ZkNNd1VGL3RPOUQ0?=
 =?utf-8?B?eFRjN2ZvZEtQenZCMldTdG5JR1JVM2QzQUNzTkFhMW4wZm4rNlRGVnpUYTFY?=
 =?utf-8?B?VGd2VXJubzB1Zm5xMTJVQmZUYTAycE5hME5sSkg2c0p6TlVvNHd4NXpSMDg5?=
 =?utf-8?B?R0hEaFBlbFplT2NUVytGZ1VycDdiano4aDVXdEg0dit5Q0ZsQkxhOUxOSzZW?=
 =?utf-8?B?d1MxYm40cTE1bEpFNUxrNWJBem8xT2hFMUVHVkdocEUybHQ2bnFac09lRlJC?=
 =?utf-8?B?b2xVRnFWOS9XNnFEQXM2MEtIblkvWE9GZTVZWlBQTW5WZjJ2OTJCK1VGb1p4?=
 =?utf-8?B?cENweWZDSm9wZEhaRUxLZ1oxR3FPS2dob0pSY2xoMkJEa0RFUXh6ZGhUTm00?=
 =?utf-8?B?M2VsZmVjN1pTU2RpNUxnbXBUUEJ2S3l1Vy9yWklLaCtVcXFkWTVlancwQjNK?=
 =?utf-8?B?UGk5emwvZE9xU3F4YkNyS1hUYjFZS2tOTG10aGFxUmZxRXBRL1lnSDZNYnRh?=
 =?utf-8?B?dlpuWVpQcjNnU3ZGMElIZFpZNGN1Skp1TEQ2bHBnRkZRUmdFa2JzVFN1QXZG?=
 =?utf-8?B?MWdSMW1TbXE0aXp0ME9rSGRadFhaNDV3aC81TFQvb0hCRGZZaU15SzM1UGFP?=
 =?utf-8?B?SVIrVVl1U2kxMGZSWUZFVmplbGdxc3VkUE5KbEx3R0VJN2ljQ0t5Q1dFTVNi?=
 =?utf-8?B?OEtMaFM5Sk9oMEZQWGNidEhOZFU1QmYrb2FmN1oycGR5Y2NmcklBRFdRV3M3?=
 =?utf-8?B?TXE5MlZyaWRvV0JlaDV1VnlpWDdSbVNEdXUyUDZ2NXNseVBmZ3BFRkdzR3Q4?=
 =?utf-8?B?M0N6NVhIRUdUaVNTa1VXOFh6YlNocE9zQnZxTGN0V2ZNSmZtcW1GMWNiZWpk?=
 =?utf-8?B?cmw1VzlWWVc3RkVrcHMvM2hyZTBqWk00MkdhY0l1aHlMQ3FkUFR0VEdxeVlQ?=
 =?utf-8?B?MTlXbWdxWTNYL3FNOHZKZWRaQmVBPT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <4F7A51CCCC28FE418F7DB0D112D00DEF@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c5d59cc2-8bfd-4fa4-f111-08d9efa5a3f1
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Feb 2022 10:34:54.8195
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: CjqXeAcoorUmpfpJiBzrhED4ym7hj7CAPLJQ1MhdyIt28FtrcjHATYPCRwoNEJufahtrwM2ClixvjS7os7YKutK8PyWMYDRhNFOn0Ru/ZK4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5439
X-OriginatorOrg: citrix.com

T24gMTQvMDIvMjAyMiAxMDozMiwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDE0LjAyLjIwMjIg
MTE6MjEsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBPbiAxNC8wMi8yMDIyIDEwOjE4LCBKYW4g
QmV1bGljaCB3cm90ZToNCj4+PiBJIGhhdmUgYSBjb3VwbGUgb2Ygc2ltcGxlIHRvb2wgc3RhY2sg
YmFja3BvcnRzIHF1ZXVlZCwgd2hpY2ggLSB3aXRoIHlvdXINCj4+PiBhZ3JlZW1lbnQgLSBJIHdv
dWxkIHdhbnQgdG8gcHV0IG9udG8gdGhlIHN0YWJsZSB0cmVlIHdoZW5ldmVyIEkgZ2V0DQo+Pj4g
YXJvdW5kIHRvIGFwcGx5aW5nIHRoZSBuZXh0IGJhdGNoIG9mIGJhY2twb3J0czoNCj4+Pg0KPj4+
IGQ5ZDM0OTZlODE3YSB0b29scy9saWJzL2xpZ2h0OiBkb24ndCB0b3VjaCBucl92Y3B1c19vdXQg
aWYgbGlzdGluZyB2Y3B1cyBhbmQgcmV0dXJuaW5nIE5VTEwNCj4+PiBlNjJjYzI5ZjliNmMgdG9v
bHMvbGliczogRml4IGJ1aWxkIGRlcGVuZGVuY2llcw0KPj4+DQo+Pj4gRm9yIDQuMTUgYWRkaXRp
b25hbGx5DQo+Pj4NCj4+PiBkZDZjMDYyYTdhNGEgdG9vbHMvbGlieGw6IENvcnJlY3RseSBhbGln
biB0aGUgQUNQSSB0YWJsZXMNCj4+IGM3NmNmYWRhMWNmYWQwICJ0b29scy9saWJhY3BpOiBVc2Ug
NjQtYnl0ZSBhbGlnbm1lbnQgZm9yIEZBQ1MiIHRvbywNCj4+IHdoaWNoIHdhcyB0aGUgdW5kZXJs
eWluZyBidWcuDQo+IFdlbGwsIHllcywgdGhhdCBvbmUgaXMgYWxyZWFkeSBpbiA0LjE1LjIuDQoN
Ck9vcHMuwqAgSSB0eXBvJ2QgbXkgYGdpdCBsb2dgIGNvbW1hbmQgdG8gc2VlIHdoZXRoZXIgaXQg
d2FzIHByZXNlbnQgb3Igbm90Lg0KDQpTb3JyeSBmb3IgdGhlIG5vaXNlLg0KDQp+QW5kcmV3DQo=


From xen-devel-bounces@lists.xenproject.org Mon Feb 14 10:48:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 10:48:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271401.465817 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJYuG-0001s4-Nz; Mon, 14 Feb 2022 10:48:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271401.465817; Mon, 14 Feb 2022 10:48:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJYuG-0001rx-Kw; Mon, 14 Feb 2022 10:48:32 +0000
Received: by outflank-mailman (input) for mailman id 271401;
 Mon, 14 Feb 2022 10:48:31 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ti2k=S5=dingwall.me.uk=james@srs-se1.protection.inumbo.net>)
 id 1nJYuF-0001rr-Rl
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 10:48:31 +0000
Received: from smarthost01c.sbp.mail.zen.net.uk
 (smarthost01c.sbp.mail.zen.net.uk [212.23.1.5])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a49b01f6-8d83-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 11:48:28 +0100 (CET)
Received: from [217.155.64.189] (helo=mail0.xen.dingwall.me.uk)
 by smarthost01c.sbp.mail.zen.net.uk with esmtpsa
 (TLS1.0:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1)
 (envelope-from <james@dingwall.me.uk>)
 id 1nJYuB-0001oD-Sd; Mon, 14 Feb 2022 10:48:27 +0000
Received: from localhost (localhost [IPv6:::1])
 by mail0.xen.dingwall.me.uk (Postfix) with ESMTP id 00A382C683F;
 Mon, 14 Feb 2022 10:48:27 +0000 (GMT)
Received: from mail0.xen.dingwall.me.uk ([IPv6:::1])
 by localhost (mail0.xen.dingwall.me.uk [IPv6:::1]) (amavisd-new, port 10024)
 with ESMTP id FDCdNp8S8c1q; Mon, 14 Feb 2022 10:48:26 +0000 (GMT)
Received: from ghoul.dingwall.me.uk (ghoul.dingwall.me.uk
 [IPv6:2a02:8010:698e:302::c0a8:1c8])
 by dingwall.me.uk (Postfix) with ESMTP id D0EAD2C683C;
 Mon, 14 Feb 2022 10:48:26 +0000 (GMT)
Received: by ghoul.dingwall.me.uk (Postfix, from userid 1000)
 id C89E515E; Mon, 14 Feb 2022 10:48:26 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a49b01f6-8d83-11ec-8eb8-a37418f5ba1a
X-Virus-Scanned: Debian amavisd-new at dingwall.me.uk
Date: Mon, 14 Feb 2022 10:48:26 +0000
From: James Dingwall <james-xen@dingwall.me.uk>
To: xen-devel@lists.xenproject.org
Cc: paul@xen.org
Subject: tools: propogate MTU to vif frontends (backporting)
Message-ID: <20220214104826.GA1607026@dingwall.me.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
X-Originating-smarthost01c-IP: [217.155.64.189]
Feedback-ID: 217.155.64.189

Hi,

I've been backporting this series to xen 4.14 and everything relating to the
backend seems to be working well.  For the frontend I can see the mtu value
published to xenstore but it does't appear to be consumed to set the matching
mtu in the guest.

https://lists.xenproject.org/archives/html/xen-devel/2020-08/msg00458.html

Is the expected solution a custom script running in the guest to make the
necessary change or have I missed something in how this is supposed to
operate?

Thanks,
James


From xen-devel-bounces@lists.xenproject.org Mon Feb 14 10:53:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 10:53:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271408.465829 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJYzT-0003Fr-At; Mon, 14 Feb 2022 10:53:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271408.465829; Mon, 14 Feb 2022 10:53:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJYzT-0003Fk-7h; Mon, 14 Feb 2022 10:53:55 +0000
Received: by outflank-mailman (input) for mailman id 271408;
 Mon, 14 Feb 2022 10:53:54 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=YsDI=S5=epam.com=prvs=4044e07e7c=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nJYzR-0003Fe-Tc
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 10:53:54 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 64e27ca2-8d84-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 11:53:52 +0100 (CET)
Received: from pps.filterd (m0174682.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 21EAmMg4016074;
 Mon, 14 Feb 2022 10:53:47 GMT
Received: from eur02-he1-obe.outbound.protection.outlook.com
 (mail-he1eur02lp2050.outbound.protection.outlook.com [104.47.5.50])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3e7mwur7ka-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Mon, 14 Feb 2022 10:53:47 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM0PR03MB3860.eurprd03.prod.outlook.com (2603:10a6:208:79::33)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.15; Mon, 14 Feb
 2022 10:53:43 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::fc4d:4749:5d1:eb73]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::fc4d:4749:5d1:eb73%4]) with mapi id 15.20.4975.018; Mon, 14 Feb 2022
 10:53:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 64e27ca2-8d84-11ec-b215-9bbe72dcb22c
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ZbKXZKdCEpO0QFYxE3WdyTm72oEWknf95vUrWMy+PUiPHQnChIFBqCapbLOeV+Oo+oASzhueJ3Z1IynqqOg61+bC/M6RtY7GOIygcyhbSRFQYmvqiCMx6JtNBm5NKdrLDvdNSVzz7/0yZJ0cKQ9hmmOxhdkI/GLOGMYPqHhY8ac4XZE3pZ2cFbaCs/70y0eM+Jo1mrkyKYASGuBbpvGqkSjxbqkQ9VlOnivFOXCBmvcShHvxTjxe4b+eQhAvGHwwFcYQ03X82t1Km5N1gb1aVS8Xizb/3wTlmpWtHA2iER+9p9k1/cp86Lwzdzxsplm1nEOKGgfoLarT1OPkjgd4TQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=/e0SPBZ/4O04i3G7vZZBM9Qi708rujy5qWRFWriiu/0=;
 b=UC3PvHeOMRUJSfGZV9LJyPcX9gV05pBw9QLrO66I7ohtSp67LZ4tQrow5ex/kV1FvUl3CZWFrCLwN9LNm/iF7nuEUP6bj77blRXpBdyLymOXeP36mk+pccJgfQMP0GW6VBMaKR/OeiAWA8aGIypOXBwZeiFgEspWukY0jrj7CYdJvsYk86KysXo43iX4jUnvIJaP9oXyuYf2pqYXxo7FcblxBS1xbmVmdqhHvkuXB6kI2il3sRCfDKquvCl92R/YnfV/qVXoJpxHYi7m5DD2QqLHQ6bPmw+4UpfjUW+wWXxWe1hmOwsAugYvPZqHunw5Ft5UE4Su51K3QKGlgqeDmg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=/e0SPBZ/4O04i3G7vZZBM9Qi708rujy5qWRFWriiu/0=;
 b=AUbpdbE/GXsjI+d6582NlgZ5yQAuUrXWw30LNm8tSLzBJVJ8wKvpRyi1wIR5+je9L1J87HFnU9CZlE4V8ZjmDjFwYexsoFBSxD1yHEkxQ2+DK8QBoHRsJEBfEGXPEcing7O5QJG3KmX/N5nq7ZO64tP9n+Xip3buCtIGpwCSK3LOi6sXZD1uL8I5sWjtP2hKLJPTIMBBYVumw5PClw/WIKkpzOyMZAZwU/dhQJH4beTYjzAQTTpaOeBZv1dB3nm1xUop+QHCkpDNyCEeQxoy4r95qpvWUv1ecq2AMn8SNjC/DjxP5F4JRDrvziLwt+TPSRyuT1X2XLni7kfJ+pAhWw==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "jbeulich@suse.com" <jbeulich@suse.com>,
        "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org" <sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH] vpci: introduce per-domain lock to protect vpci structure
Thread-Topic: [PATCH] vpci: introduce per-domain lock to protect vpci
 structure
Thread-Index: 
 AQHYHboQT3cBWYI1/EGunE7hOwop6ayM95MAgAD+qQCAAEaDAIAElIcAgAAQEwCAAAV1AA==
Date: Mon, 14 Feb 2022 10:53:43 +0000
Message-ID: <d8389a90-00c8-b34a-8488-b0f3fc5bde1b@epam.com>
References: <20220209133627.959649-1-andr2000@gmail.com>
 <YgU6Snk8GTytJXZp@Air-de-Roger>
 <c4666570-666e-6680-5ec2-adf1da51ad06@epam.com>
 <YgZLEMW9US9QjjYG@Air-de-Roger>
 <33fb1095-64ed-29ef-ba6b-cbde21d941f8@epam.com>
 <YgowIg5MvTaf2zsR@Air-de-Roger>
In-Reply-To: <YgowIg5MvTaf2zsR@Air-de-Roger>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 92e56870-3ede-48c8-b151-08d9efa8447e
x-ms-traffictypediagnostic: AM0PR03MB3860:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM0PR03MB38605CA4943FC88238A460DDE7339@AM0PR03MB3860.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 PRP3/BAFchDuq3yL+W2lWrz5sSP8Hawt0oRlKjSNqrwNYvUzQeI1sH5kazN56yPpHRfGW5pW0tQX/p377FwEBiLmBW4GOOcnNs6tYDlls2vs3yzknR25M8cuWGdMuo/QcUVK+lgWDk9pdw9fU6wmPxfid6L3GDdjO4WHHtKDS/TWkFQTUCPYJK8K1ewkx2exRFdH2a9OiKmZWUzm4uI+uZcD5dc7qsajTj3SBSzV2IuoqYTpWAc2z5e8vTEr6LpwPAvt5u0Vx2LC2FlIVpz5WpNt75zQGe7xo400Lbi6348kPOmJM2PI4Jr2z6sc13bqy5vWqQrlr2lZMQHuzcrv2o6ugC9Ufxy9K71FyKcSX0txF+PvS2V8nyCahtoe/CCVziPZES3ilnJ7Yu3pPLsB3ZxIbDuJA0r9qlRK/GRlds9Umn+QCb+UoJGia+wvu8u0XLHy38eNoqQQZn4kSeVv4qMJvn17Fw1PzNqKTIJ86/KDb76gimhSKft+uipXpylLxKuE94pMIr7xpmL8IizXaH9g5VcueqMKB5s4kZm11ja2A+Q4OJAkH854DjnX5xNuaNcBBpnIjal3/t3kdy2EzfQEQqUQbHKA9YdeJQ6NqakAgsgqrKUB4cFB6XyvE8lSwgSHUZcgB3LPlya1QhroPLYRrTnegp52UolI4qB8bX86k0yzfHe7lluNu2yLrbi/i2qF0mHb5m2h0lqhzVBvk6U75d8JrYKpLub7BtACAVBdVltfhWhbIWYSbjHm4j0C
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(2616005)(66946007)(66556008)(107886003)(76116006)(36756003)(6916009)(54906003)(91956017)(38070700005)(316002)(64756008)(4326008)(8676002)(31686004)(2906002)(66446008)(66476007)(83380400001)(31696002)(5660300002)(186003)(26005)(86362001)(8936002)(6506007)(71200400001)(53546011)(55236004)(38100700002)(122000001)(6512007)(508600001)(6486002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?L1U1NTdGNmVtdE0vOVcrYnkxNDZGRGgxQmw3TGZJQ3J4ekZia2VYRUxUREtY?=
 =?utf-8?B?NTdsUitMN3lvWnpKMmhGdVUvbXE2ZXRwV1NkWHpETW12YU45THFmclRmalZH?=
 =?utf-8?B?alVDM1Y5VVp2OWdaYklsMmd1RitnWVpVaXcvazF1YTVTeTNGUGVPaW5yQU8x?=
 =?utf-8?B?Q2pwSmR3ZnlKaUJQRG5VQjFoZTlwaDJzMjFCMG9YWGhDVHdBZDNyM3o4Zkph?=
 =?utf-8?B?aVNuR0EzUXordFVFeDhzLzFRNFJJbStSOU5tWGxCY2taWFE0LzFmMExlY0Rz?=
 =?utf-8?B?WnN6Q0lkNHEwZ3g3YzhxUEF2TVNsaW42dTFxS0FSLzI5OU8xejZmZXIwOTd4?=
 =?utf-8?B?MytmeWZVeWpFY3duTWpkaW81QlcvWjJ6U2pKWE5qYzhYT3ZscDE3WXRWZ2Vp?=
 =?utf-8?B?bUQ5RUUxN283SEtvb2R6WmpKcVozMEU4WDd3c09QU1cwNFN4RFIrbDRMbXda?=
 =?utf-8?B?RHVVOG10dno2UEl2bDZydDdjSDk3RTF2czZDN1pzS3d5UVNEUW8xMGt2TEhC?=
 =?utf-8?B?NzR6bExHU0VSbVprQm5XS004VXBuWWZoQStvQTk5Mi9kMDd1MGIyMHMxNnk0?=
 =?utf-8?B?K3FJL0k5aTZWWlRJd1RIaWdrcW8rQStpQXY1UGJrZ0p1R1VFUTBlNlVSYVIy?=
 =?utf-8?B?K2Zoc3VYT0s0M3JLZ3ZxRHJPOTNpcXY3MDUxOHg1R2RWcVA2MjhLQVZVd29v?=
 =?utf-8?B?cnJWYkZOd0w3RmxySXkwUkdPMzJZK0NaSk5xb3N3L2JjU2syVWVScjdlemhk?=
 =?utf-8?B?cE5yYnVHeUxqWkRFU0tUcTRKZkNxWHpSVjlaY2NUN1NBL1VYSGV1RE5XWnMw?=
 =?utf-8?B?ZEcyaXJtODNLcVRiUmgwNkdmeXo0ZTZSWm5yeUd6bURjdVVSMlZpRmJoTERs?=
 =?utf-8?B?REFGWW4rQ20rK3VkbytxL0FpbVNzMEl3VWt0dmZaNnhDcUR2UGpVMnJJSFhs?=
 =?utf-8?B?VWUzWnFJYWhRQ2Fud2JmaVNuQnNVQmxVcDJkb0l1WlQ3OHFuRVVpdkMrWllW?=
 =?utf-8?B?V0lEa0hON0NWWkgzNW1OVTRaaHBia3hJSEU4RUY3UUlGYkJUWGVvd2J3dEk3?=
 =?utf-8?B?eE56RnpoelYyaENsKzU4YUJKUjZkOEFieXZKb0REQzMvSlZsUU9kNmlUVHBi?=
 =?utf-8?B?Tk5ZMnpKVkNRWGprWENydHcxNW40akVwTjlOOHBqZzcxOCtld2JGZE5qV1lD?=
 =?utf-8?B?R2NOTFRRYUdQbjR0SUNUUVI1TVQyZUFVaEYvOHZKcThyODhidFJwbG5uWHhV?=
 =?utf-8?B?VHlmbjlOeXBMTFIrWTJyVWU1N2JrMmxVZ2FDTU13cEVzeEp6S2FLRndHRE9j?=
 =?utf-8?B?T0h5QktyMExZRjNGWXZuSHB0VTFPRDR4RHdnT09lK0FUbTlYRXZJUklvSFgr?=
 =?utf-8?B?WllWbVRSb0Y2R2pOT2RFSUpRdHk5eUtBVFhSMGxUQ1RzUmxENmJzWDgwWEF0?=
 =?utf-8?B?V25TTjRZOVVpRHdsRWk1b3FSQmZFeWJFUS8zclNwKzRpZTNaZVZnWk9mRnVv?=
 =?utf-8?B?THphRC9YZjdsYWVQWEtLSnN2clI4UE9WWFBwVWI1UkJFMUhrR056MjROZU04?=
 =?utf-8?B?MVdQVGFaQUZBQlZ5R29NSzMyVVBtL0Zvd2phb25NMXZsTmJCQkpJRit2Wit3?=
 =?utf-8?B?aDc1R2phaFBqNWpmckF5bG93VkFuQmRHdDRFenNNSUVkRXZ1aVlLS1ZXa1I2?=
 =?utf-8?B?b0pkYUNZUkltMG43WXlYcG40eTlDclp1STBsd3pJcStVVjlpNnljSUdUZjVD?=
 =?utf-8?B?dk1LN1JWYlZQcm5JL2xrN3FDbTF2SGNNSjY4ZXk5ejRYRXFWZ2JzY0cxVVVy?=
 =?utf-8?B?RlhxQzRRalc4aTBMNU1ZcVJ2T1FMMFNxUS9LOFJKRHVNUmIwWDUrV0MrYXd4?=
 =?utf-8?B?REg3U25UdWlOUThhV1RjS1V2ejU0Y1hZVjgvbittakxLcjFISy9TMjRoZ0ht?=
 =?utf-8?B?NWM5S2VWa3JQWEVjV0ZSeU0zcWdmcE5PRU5ZZ1pMaGYxYzM0T1dCTjcydTIz?=
 =?utf-8?B?Z2YwdHlYbVJ3K2xkYm1NMEp1SWM0VzZ1c21ZRmRtWTZqUjYycS83MXdHLzJX?=
 =?utf-8?B?M01jejRvTlgvQTR6eXpFSkJZSUVPVnlMZHQ1TkhJTkIzbklKRHRWMWRDSitr?=
 =?utf-8?B?dWxQaXd4Wi9XbFBVbDlKR3AwMHFTa3E4RTMzRjdqcWFnU29IZzI4bjBiWnF1?=
 =?utf-8?B?N3MyaHpNZy9kU2hoQ05QMHdrMXVYT0doU1dlMWdJVTVGZ0U2aFUvT21TbkRL?=
 =?utf-8?B?dW1Xbm54OVNtaXIwYnVhQWdmVzExZDZVVXM1bFloeXFsVG9XYXJWVjl5ZmZV?=
 =?utf-8?B?eURjOFhoQnVEUHByMzE0TElaT3U3NVh1Q1QwOHVsYXNYNjJzVTlnUT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <94F3639C60DCCA45B538EE0628EDA5DA@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 92e56870-3ede-48c8-b151-08d9efa8447e
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Feb 2022 10:53:43.0927
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: nrpP6txCwt+LDQQTNUhCVUbvaAjZ+8GCbQNgj7hy9F94z8kXc297IXbxslRbs39KycrvGPSbnHI18vjWhOHv7WPIC7UuXeR/VOd88/Na0cNsZySawN28TGL9IrHY0WML
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB3860
X-Proofpoint-GUID: CRa2E2hxtvhmDkdP038gemlglDfiZUZN
X-Proofpoint-ORIG-GUID: CRa2E2hxtvhmDkdP038gemlglDfiZUZN
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-14_02,2022-02-14_03,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 mlxscore=0
 malwarescore=0 mlxlogscore=999 priorityscore=1501 impostorscore=0
 adultscore=0 bulkscore=0 clxscore=1015 phishscore=0 suspectscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202140067

DQoNCk9uIDE0LjAyLjIyIDEyOjM0LCBSb2dlciBQYXUgTW9ubsOpIHdyb3RlOg0KPiBPbiBNb24s
IEZlYiAxNCwgMjAyMiBhdCAwOTozNjozOUFNICswMDAwLCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5r
byB3cm90ZToNCj4+DQo+PiBPbiAxMS4wMi4yMiAxMzo0MCwgUm9nZXIgUGF1IE1vbm7DqSB3cm90
ZToNCj4+PiArDQo+Pj4+Pj4gICAgICAgICBmb3IgKCBpID0gMDsgaSA8IG1zaXgtPm1heF9lbnRy
aWVzOyBpKysgKQ0KPj4+Pj4+ICAgICAgICAgew0KPj4+Pj4+ICAgICAgICAgICAgIGNvbnN0IHN0
cnVjdCB2cGNpX21zaXhfZW50cnkgKmVudHJ5ID0gJm1zaXgtPmVudHJpZXNbaV07DQo+Pj4+PiBT
aW5jZSB0aGlzIGZ1bmN0aW9uIGlzIG5vdyBjYWxsZWQgd2l0aCB0aGUgcGVyLWRvbWFpbiByd2xv
Y2sgcmVhZA0KPj4+Pj4gbG9ja2VkIGl0J3MgbGlrZWx5IG5vdCBhcHByb3ByaWF0ZSB0byBjYWxs
IHByb2Nlc3NfcGVuZGluZ19zb2Z0aXJxcw0KPj4+Pj4gd2hpbGUgaG9sZGluZyBzdWNoIGxvY2sg
KGNoZWNrIGJlbG93KS4NCj4+Pj4gWW91IGFyZSByaWdodCwgYXMgaXQgaXMgcG9zc2libGUgdGhh
dDoNCj4+Pj4NCj4+Pj4gcHJvY2Vzc19wZW5kaW5nX3NvZnRpcnFzIC0+IHZwY2lfcHJvY2Vzc19w
ZW5kaW5nIC0+IHJlYWRfbG9jaw0KPj4+Pg0KPj4+PiBFdmVuIG1vcmUsIHZwY2lfcHJvY2Vzc19w
ZW5kaW5nIG1heSBhbHNvDQo+Pj4+DQo+Pj4+IHJlYWRfdW5sb2NrIC0+IHZwY2lfcmVtb3ZlX2Rl
dmljZSAtPiB3cml0ZV9sb2NrDQo+Pj4+DQo+Pj4+IGluIGl0cyBlcnJvciBwYXRoLiBTbywgYW55
IGludm9jYXRpb24gb2YgcHJvY2Vzc19wZW5kaW5nX3NvZnRpcnFzDQo+Pj4+IG11c3Qgbm90IGhv
bGQgZC0+dnBjaV9yd2xvY2sgYXQgbGVhc3QuDQo+Pj4+DQo+Pj4+IEFuZCBhbHNvIHdlIG5lZWQg
dG8gY2hlY2sgdGhhdCBwZGV2LT52cGNpIHdhcyBub3QgcmVtb3ZlZA0KPj4+PiBpbiBiZXR3ZWVu
IG9yICpyZS1jcmVhdGVkKg0KPj4+Pj4gV2Ugd2lsbCBsaWtlbHkgbmVlZCB0byByZS1pdGVyYXRl
IG92ZXIgdGhlIGxpc3Qgb2YgcGRldnMgYXNzaWduZWQgdG8NCj4+Pj4+IHRoZSBkb21haW4gYW5k
IGFzc2VydCB0aGF0IHRoZSBwZGV2IGlzIHN0aWxsIGFzc2lnbmVkIHRvIHRoZSBzYW1lDQo+Pj4+
PiBkb21haW4uDQo+Pj4+IFNvLCBkbyB5b3UgbWVhbiBhIHBhdHRlcm4gbGlrZSB0aGUgYmVsb3cg
c2hvdWxkIGJlIHVzZWQgYXQgYWxsDQo+Pj4+IHBsYWNlcyB3aGVyZSB3ZSBuZWVkIHRvIGNhbGwg
cHJvY2Vzc19wZW5kaW5nX3NvZnRpcnFzPw0KPj4+Pg0KPj4+PiByZWFkX3VubG9jaw0KPj4+PiBw
cm9jZXNzX3BlbmRpbmdfc29mdGlycXMNCj4+Pj4gcmVhZF9sb2NrDQo+Pj4+IHBkZXYgPSBwY2lf
Z2V0X3BkZXZfYnlfZG9tYWluKGQsIHNiZGYuc2VnLCBzYmRmLmJ1cywgc2JkZi5kZXZmbik7DQo+
Pj4+IGlmICggcGRldiAmJiBwZGV2LT52cGNpICYmIGlzX3RoZV9zYW1lX3ZwY2kocGRldi0+dnBj
aSkgKQ0KPj4+PiA8Y29udGludWUgcHJvY2Vzc2luZz4NCj4+PiBTb21ldGhpbmcgYWxvbmcgdGhv
c2UgbGluZXMuIFlvdSBsaWtlbHkgbmVlZCB0byBjb250aW51ZSBpdGVyYXRlIHVzaW5nDQo+Pj4g
Zm9yX2VhY2hfcGRldi4NCj4+IEhvdyBkbyB3ZSB0ZWxsIGlmIHBkZXYtPnZwY2kgaXMgdGhlIHNh
bWU/IEphbiBoYXMgYWxyZWFkeSBicm91Z2h0DQo+PiB0aGlzIHF1ZXN0aW9uIGJlZm9yZSBbMV0g
YW5kIEkgd2FzIGFib3V0IHRvIHVzZSBzb21lIElEIGZvciB0aGF0IHB1cnBvc2U6DQo+PiBwZGV2
LT52cGNpLT5pZCA9IGQtPnZwY2lfaWQrKyBhbmQgdGhlbiB3ZSB1c2UgcGRldi0+dnBjaS0+aWTC
oCBmb3IgY2hlY2tzDQo+IEdpdmVuIHRoaXMgaXMgYSBkZWJ1ZyBtZXNzYWdlIEkgd291bGQgYmUg
T0sgd2l0aCBqdXN0IGRvaW5nIHRoZQ0KPiBtaW5pbWFsIGNoZWNrcyB0byBwcmV2ZW50IFhlbiBm
cm9tIGNyYXNoaW5nIChpZTogcGRldi0+dnBjaSBleGlzdHMpDQo+IGFuZCB0aGF0IHRoZSByZXN1
bWUgTVNJIGVudHJ5IGlzIG5vdCBwYXN0IHRoZSBjdXJyZW50IGxpbWl0LiBPdGhlcndpc2UNCj4g
anVzdCBwcmludCBhIG1lc3NhZ2UgYW5kIG1vdmUgb24gdG8gdGhlIG5leHQgZGV2aWNlLg0KQWdy
ZWUsIEkgc2VlIG5vIGJpZyBpc3N1ZSAocHJvYmFibHkpIGlmIHdlIGFyZSBub3QgYWJsZSB0byBw
cmludA0KDQpIb3cgYWJvdXQgdGhpcyBvbmU6DQoNCmRpZmYgLS1naXQgYS94ZW4vZHJpdmVycy92
cGNpL2hlYWRlci5jIGIveGVuL2RyaXZlcnMvdnBjaS9oZWFkZXIuYw0KaW5kZXggODA5YTZiNDc3
M2UxLi41MDM3M2YwNGRhODIgMTAwNjQ0DQotLS0gYS94ZW4vZHJpdmVycy92cGNpL2hlYWRlci5j
DQorKysgYi94ZW4vZHJpdmVycy92cGNpL2hlYWRlci5jDQpAQCAtMTcxLDEwICsxNzEsMzEgQEAg
c3RhdGljIGludCBfX2luaXQgYXBwbHlfbWFwKHN0cnVjdCBkb21haW4gKmQsIGNvbnN0IHN0cnVj
dCBwY2lfZGV2ICpwZGV2LA0KIMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgIHN0cnVjdCByYW5nZXNldCAqbWVtLCB1aW50MTZfdCBjbWQpDQog
wqB7DQogwqDCoMKgwqAgc3RydWN0IG1hcF9kYXRhIGRhdGEgPSB7IC5kID0gZCwgLm1hcCA9IHRy
dWUgfTsNCivCoMKgwqAgcGNpX3NiZGZfdCBzYmRmID0gcGRldi0+c2JkZjsNCiDCoMKgwqDCoCBp
bnQgcmM7DQoNCisgQVNTRVJUKHJ3X2lzX3dyaXRlX2xvY2tlZCgmcGRldi0+ZG9tYWluLT52cGNp
X3J3bG9jaykpOw0KKw0KIMKgwqDCoMKgIHdoaWxlICggKHJjID0gcmFuZ2VzZXRfY29uc3VtZV9y
YW5nZXMobWVtLCBtYXBfcmFuZ2UsICZkYXRhKSkgPT0gLUVSRVNUQVJUICkNCivCoMKgwqAgew0K
Kw0KK8KgwqDCoMKgwqDCoMKgIC8qDQorwqDCoMKgwqDCoMKgwqDCoCAqIHByb2Nlc3NfcGVuZGlu
Z19zb2Z0aXJxcyBtYXkgdHJpZ2dlciB2cGNpX3Byb2Nlc3NfcGVuZGluZyB3aGljaA0KK8KgwqDC
oMKgwqDCoMKgwqAgKiBtYXkgbmVlZCB0byBhY3F1aXJlIHBkZXYtPmRvbWFpbi0+dnBjaV9yd2xv
Y2sgaW4gcmVhZCBtb2RlLg0KK8KgwqDCoMKgwqDCoMKgwqAgKi8NCivCoMKgwqDCoMKgwqDCoCB3
cml0ZV91bmxvY2soJnBkZXYtPmRvbWFpbi0+dnBjaV9yd2xvY2spOw0KIMKgwqDCoMKgwqDCoMKg
wqAgcHJvY2Vzc19wZW5kaW5nX3NvZnRpcnFzKCk7DQorwqDCoMKgwqDCoMKgwqAgd3JpdGVfbG9j
aygmcGRldi0+ZG9tYWluLT52cGNpX3J3bG9jayk7DQorDQorwqDCoMKgwqDCoMKgwqAgLyogQ2hl
Y2sgaWYgcGRldiBzdGlsbCBleGlzdHMgYW5kIHZQQ0kgd2FzIG5vdCByZW1vdmVkIG9yIHJlLWNy
ZWF0ZWQuICovDQorwqDCoMKgwqDCoMKgwqAgaWYgKHBjaV9nZXRfcGRldl9ieV9kb21haW4oZCwg
c2JkZi5zZWcsIHNiZGYuYnVzLCBzYmRmLmRldmZuKSAhPSBwZGV2KQ0KK8KgwqDCoMKgwqDCoMKg
wqDCoMKgwqAgaWYgKCB2cGNpIGlzIE5PVCB0aGUgc2FtZSApDQorwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoCB7DQorwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHJjID0gMDsNCivCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgYnJlYWs7DQorwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB9
DQorwqDCoMKgIH0NCisNCiDCoMKgwqDCoCByYW5nZXNldF9kZXN0cm95KG1lbSk7DQogwqDCoMKg
wqAgaWYgKCAhcmMgKQ0KIMKgwqDCoMKgwqDCoMKgwqAgbW9kaWZ5X2RlY29kaW5nKHBkZXYsIGNt
ZCwgZmFsc2UpOw0KDQpUaGlzIG9uZSBhbHNvIHdhbnRzIHByb2Nlc3NfcGVuZGluZ19zb2Z0aXJx
cyB0byBydW4gc28gaXQgKm1pZ2h0Kg0Kd2FudCBwZGV2IGFuZCB2cGNpIGNoZWNrcy4gQnV0IGF0
IHRoZSBzYW1lIHRpbWUgYXBwbHlfbWFwIHJ1bnMNCmF0ICggc3lzdGVtX3N0YXRlIDwgU1lTX1NU
QVRFX2FjdGl2ZSApLCBzbyBkZWZlcl9tYXAgd29uJ3QgYmUNCnJ1bm5pbmcgeWV0LCB0aHVzIG5v
IHZwY2lfcHJvY2Vzc19wZW5kaW5nIGlzIHBvc3NpYmxlIHlldCAoaW4gdGVybXMNCml0IGhhcyBz
b21ldGhpbmcgdG8gZG8geWV0KS4gU28sIEkgdGhpbmsgd2UganVzdCBuZWVkOg0KDQogwqDCoMKg
wqDCoMKgwqAgd3JpdGVfdW5sb2NrKCZwZGV2LT5kb21haW4tPnZwY2lfcndsb2NrKTsNCiDCoMKg
wqDCoMKgwqDCoCBwcm9jZXNzX3BlbmRpbmdfc29mdGlycXMoKTsNCiDCoMKgwqDCoMKgwqDCoCB3
cml0ZV9sb2NrKCZwZGV2LT5kb21haW4tPnZwY2lfcndsb2NrKTsNCg0KYW5kIHRoaXMgc2hvdWxk
IGJlIGVub3VnaA0KPg0KPiBUaGUgcmVjcmVhdGluZyBvZiBwZGV2LT52cGNpIG9ubHkgb2NjdXJz
IGFzIGEgcmVzdWx0IG9mIHNvbWUgYWRtaW4NCj4gb3BlcmF0aW9ucywgYW5kIGRvaW5nIGl0IHdo
aWxlIGFsc28gdHJ5aW5nIHRvIHByaW50IHRoZSBjdXJyZW50IE1TSQ0KPiBzdGF0dXMgaXMgbm90
IGEgcmVsaWFibGUgYXBwcm9hY2guIFNvIGR1bXBpbmcgYW4gaW5jb21wbGV0ZSBvcg0KPiBpbmNv
aGVyZW50IHN0YXRlIGFzIGEgcmVzdWx0IG9mIG9uZ29pbmcgYWRtaW4gb3BlcmF0aW9ucyB3b3Vs
ZCBiZQ0KPiBmaW5lLg0KT2sNCj4NCj4gVGhhbmtzLCBSb2dlci4NCj4NClRoYW5rIHlvdSwNCk9s
ZWtzYW5kcg==


From xen-devel-bounces@lists.xenproject.org Mon Feb 14 10:55:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 10:55:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271415.465840 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJZ1A-0003rX-Ms; Mon, 14 Feb 2022 10:55:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271415.465840; Mon, 14 Feb 2022 10:55:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJZ1A-0003rQ-Jd; Mon, 14 Feb 2022 10:55:40 +0000
Received: by outflank-mailman (input) for mailman id 271415;
 Mon, 14 Feb 2022 10:55:39 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=jzps=S5=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nJZ19-0003rI-4y
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 10:55:39 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a3589f9f-8d84-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 11:55:37 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a3589f9f-8d84-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644836137;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=19S5wilP4hRGRchAvWwmZI1zlqFT0NvTbPr5WRsxhcE=;
  b=ic2YzDU6YNBfLhGDBWGmXoz7OHI0iQ0bf4ZFedafhisfU9O2jtP6oF/C
   7THF41VTFrRayZ72ajPUQllQ1LzF6NzYQsCSEOEFit4IRdUKc5FP0vFVT
   Q1yTHR72BgTvICZe+IWl+ZitwTTu29i/GKy1BtmJknyrMxttULN08GEyu
   A=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: aBqiKJzNAxDE7hAWtU7KuQyEtGLS3Gx2JpxUJaIFV+bfTcxvvqhGwfw9MufeBvlOwiRuWDUIDI
 Yfty8asJvYHGb03I64dfKAMINCUtgwHnR6eJkwPygWVWIP+jYTUQzC3x34U1m5ed2ODOiPbhLT
 2kwcX92zfXgVGcT0ru6iIKGxyBYFqQLOMuGV5bweu0P0hcuf3R//pn+jVmYASZykRdPlMm7Ard
 WnknG++x1t3mTaL2Rx+8aGqXWnyUpWfSa16thG8RD/UN/dxcglHFnCybov659N1r+Y16tCXCFg
 U0sjzy++C+7ykOAVRfXEBu2y
X-SBRS: 5.1
X-MesageID: 64142337
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:/XvonaP2eAA8iU3vrR2fkMFynXyQoLVcMsEvi/4bfWQNrUon3jIAn
 2oZCmrVa/mCajajf4skYYqy9k4PuZXTnYNiTQto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6UUsxNbVU8En1500s/w7dRbrNA2rBVPSvc4
 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq
 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYo2q1vsloy
 uhKjJHqZS0VF4/dmN4FChYNRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs
 6VFdnZdNXhvhMrvqF6/YvNrick5atHiIasUu216zCGfBvEjKXzGa/uWvIMCh2xv7ixINfLaY
 tdeTCFKV0rnbkNmJ0sSMIA6v/j90xETdBUH8QnI9MLb+VP73AF3lbTgLtfRUtiLXtlO2FaVo
 Hrc+Gb0CQ1cM8aQoRKH+H+xgu7EnQvgRZkfUra/85ZXbEa7nzJJTkdMDB3i/Kf/2hXWt89jx
 1I8pRYPtLEwyUuSQ4PRdSGRgm+EhAZFVI8FewEl0z2lxq3R6gefI2ELSD9dddAr3PMLqSwWO
 kyhxI2wW2E22FGBYTfEr+rP82vuUcQABTJaPUc5oR05D84PSW3ZpjbGVZ5dHaG8lbUZ8hmgk
 mnR/EDSa1j+5PPnNplXH3ia2VpARbCTF2bZAzk7uUr/sGtEiHaNPdDA1LQixa8owHylZleAp
 mMYvMOV8foDC5qA/ATUHrlRQ+H5uqvdaWaG6bKKI3XG327zk0NPgKgKuG0uTKuXGppslcDVj
 L/75loKuc470IqCZq5reYOhY/nGPoC7fekJosv8N4IUCrAoLVfv1Hg3OSa4gjC8+GBxwPpXE
 crKLq6R4YMyVP0PIMyeHLxGj9fGB0kWmAvueHwM50r7j+TOPiPJIVrHWXPXBt0EAGq/iFy92
 /5UNteQygUZV+v7YyLN9pUUI0xMJn8+ba0aYeQOHgJaCgY5SmwnFdHLxrYtJ95sk6hPz7+a9
 XChQE5IjlH4gCSfewmNb3libpLpXIp+8i1nbXB9Yw7w1ihxe5ur4Ycea4AzIest+tt8wKMmV
 PICYciBXKhCE2yV5zQHYJDhh4V+bxD31xmWNi+obWFnLZ5tTgDE4PH+eQ7r+HVcBya7r5Jm8
 bahyhnaUdwIQAE7VJTab/emzlWQu3kBmb0tAxuUc4cLIEi1qdpkMS38iPMzMvogExSby2vIz
 RuSDDcZufLJ/90//u7WiP3WtIyuCeZ/QBZXRjGJ8basOCDG1WO/2oscAv2QdDXQWW6oqqWvY
 eJZk6P1PPEdxQsYtoN9F/BgzL4k5suprLhfl1w2EHLOZlWtK7VhPnjZgpUf6vwTnudU6VmsR
 0aC2thGIrHYasrqHWkYKBchcuneh+ofnSPf7KhtLUj3jMOtEGFrjamG08GwtRFg
IronPort-HdrOrdr: A9a23:+lxyvaGA/Ym5KijvpLqEyMeALOsnbusQ8zAXPiFKOHpom6Oj+f
 xG8M576fawskdyZJhCo6HmBEDjewK+yXcd2+B4Vt3PMzUO+lHYSb2KhrGSpwEIbheOjNK1op
 0QCJSWZueRMXFKye7/6Ba5CZIFxtSG/6CliI7lokuFNTsaE52IuD0JczqmLg==
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="64142337"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=NGTogouJcxImVNM9nlc4oAMmLDB0u/doRV+SyEXEwG8iktsKGDlWm1qs9rObbyPxDubDPOChFhdfb0xWmtXZTnr88+C3BnOS/buaJDMESuHC0pQ563/46iOAEighCAfGBhOiBsAvm9o/KCBIuOLl5DnbNqoDeonHyKXETYhPeCXTA/1mM2mwWu0D3Vc3J+soW3Yqp6In9yyS5/2Vo3lAGPZhPCh3hcYkpDwrYK4UGnQN/fysoi7XI+NyFe7coeQce3wf6MNcGWIl/3FS0IfnVa8fShBYadexZlS5NN2p96mgab5AfTt4M1MczpvgCCyHnH8HbxY1dD3yMI0ELN1yAw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Q0MpsQB+2Ex1eUukD0jz2QOTmkFaZjvrGXMIzk8d//s=;
 b=fGyEImkPuTwTtTCZzpYpApZmFwhLghggmfbM9B4L9bEM5d3y7/OFFXCFhTefaEyMvCT/TFsoG05AlvW2eStzQ+aPbbJekEuxZ8S4KS1EUdlvobh13FbiQtuDeip6vQSkVuHFVSPtrsF4MVbO8jEPcfgzasdBuMn3Vt4fXPvk1a9FyUO6iqBOP/yMZdRq5RTrAFnkg008IyjQkeDSly1SXtUlFiy7OfgXYjQdkEiwVjEQQ1qzcR0SFLiHlt2hiGZDyE7l3svLbGgcY7rTinqgi/pLrRGySaApvUf0mcp23G7O9YgcIXNhhfH7o8yTDMZp0XUbkoLh5TQzXcPcx9EWyg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Q0MpsQB+2Ex1eUukD0jz2QOTmkFaZjvrGXMIzk8d//s=;
 b=CNZt7aC5qQVDBPg9c5Qnc8JRmKkK/lOIYailvthEF6qKCUZro19V0AnnxQBATHZswf+59UqO5QqGOZYBy+9xxtc3wzYa3FLu/EU6QFjH5LY93yGkg7Medb4qbXNaT3k42GlDLtLC4zCMnSctCZZsDc4q6tdOoCDt/S4/2PoKmzo=
Date: Mon, 14 Feb 2022 11:55:26 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Anthony Perard <anthony.perard@citrix.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: tools backports
Message-ID: <Ygo1Hh8RoZfmPOjo@Air-de-Roger>
References: <710fd687-16d5-c088-d3be-749851e6eab3@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <710fd687-16d5-c088-d3be-749851e6eab3@suse.com>
X-ClientProxiedBy: LO2P265CA0463.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:a2::19) To SA0PR03MB5610.namprd03.prod.outlook.com
 (2603:10b6:806:b2::9)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 072d5c70-1ecc-4ea5-d45a-08d9efa884f2
X-MS-TrafficTypeDiagnostic: DM6PR03MB3705:EE_
X-Microsoft-Antispam-PRVS: <DM6PR03MB3705CA8BAE2501A85B1D37378F339@DM6PR03MB3705.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6108;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: +xE7mIluCOIXrnp2EjDPwR+mVqqPYHfXX1XxWN3pyRxh8cR41hTwDZblIdR8CCAenxsWvhgG3mWWwqWUl34DYnzoA9Pgnf1crhilxfPwcG5EiAhfLc4ktTI6vQE8uOSjxMkqBg0qrAmCIQJ1RzNVHYPlsE+i4HiJ+qrffjTDSXM/8G6arH/eh8lg/vLiH4j0ahfsnZvKv0lAZpkAHEUsv4m2vQlNt+KJs4ebkHHozfGrEimYsGolUy0EJRvmLnAP5l55Ehflz4e9LV+JaFs66FClXxWCofahB47Yk0xbH1zfmAqmQHd0h/u4TUxnAOuQjRZnriXY3ucUTv3NtiMCpP3fbZr6Dq37VzbsQKfpwcb4cv17LuxiQc3zJTpM3fagHAZd9jaNx6adb5i9trsjimjOQXB5KbeyW/CLUDuQ5N+l6jrz32mif5L8PeV8aRz+DinkPSl7xU6/7udRaECjYpR79PCYvx5m+ZHVIRG7R3h8e3EskV3hn6ddRizhZM7jB7JPco8GwUCFA1DaNehylq4gqV7NqlPZFRnVBX6KPuyw+9KgB5/lvFIgX7sRxIggfD45IF/zHZQIX7OTI7/VvdQnWVsgmFcdOUvEuSiJzDsYdzH7DUJRhBm6DhpvjJXFiUhAthIMx0DLtDAyVs7NAQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA0PR03MB5610.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(7116003)(6916009)(82960400001)(9686003)(316002)(86362001)(66946007)(66476007)(8676002)(4326008)(66556008)(26005)(6506007)(54906003)(186003)(6512007)(8936002)(38100700002)(33716001)(6486002)(508600001)(83380400001)(3480700007)(2906002)(85182001)(5660300002)(6666004)(4744005);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YmN3a2Q4NS9tWGtGN2p6R2gxRlVEMUxyZy9NYVdPZi96M0pMWDBFVm1obGps?=
 =?utf-8?B?UWw2ZmtWSE9EUUNqWmI3QnNFaVhRamJFdUl4SjFENU9oSUgyOFVZM0xxVkFW?=
 =?utf-8?B?Tk9RMFcvNXgxekdzamhZODZCREg2RWJ0dVBUd0h6aE1jcXArS1RDdEJwRkt3?=
 =?utf-8?B?L2dIQ04vRWN3TFlvWVpzaGlJRjZ2SC9tSWdYYi9lWjBERUVxNHRQYnJjME1a?=
 =?utf-8?B?WUJObUE4S3NMakVFVkxqdHdCUGloQXdUNTFSdVo3SzlGVS8xZ1lZSjZDb01v?=
 =?utf-8?B?bHJGTjhSQVNVM05KSWUzNXdBaDc1dUYrM0l6VDJjRU1CR2RZK1pUQ1dXaXNZ?=
 =?utf-8?B?TTBzVDllNWlwc09mbEtYZWh2YmpJUC9HKzZ3NGdWUkd5VXJnN1c4emsrenAy?=
 =?utf-8?B?SS82QXhweEdVajJaNTR5MDlpRVgvek9iNWVWcWMwakd2TXNmNCtmaTZMTEdS?=
 =?utf-8?B?Q3dadzlxL2xyU0hxOVVXR2hJYkpGaTlWK0dhc2oyL1VBeDJtZlNSWUdJVCt2?=
 =?utf-8?B?MGNTZit2eEJkdExrL3ZYTkN0UEYySUhEMlRhZ1BhS3ZOMW45TnBEUjhMbGls?=
 =?utf-8?B?WmJ1Njh3M3JLcHA1Rk1CdTZHVTFtK04wU1F5c1JrRkdtUUxUWXR0TUVNNHVE?=
 =?utf-8?B?ZjlBRGwvbjVvTlFVc3ZQV2pGNG5LN1lxVzVIMjBpOWEyUFJjUjRkNHBZKytl?=
 =?utf-8?B?SGhWUnc2NDVxclZUQk5Vakw5Tm9xS1U1UVFTMXhGeVlSY1MrU2p3Q3NIbDFK?=
 =?utf-8?B?cGk5N2xxbzJNNkhNajBIcCtmQitKWXpaNkVKNC9BaDlTcWMvc0xHZjh4Wmxv?=
 =?utf-8?B?blpqS2RDUld5QzZQQ2RkUmZQSGgzYitOY0FiT3AzQ3JuRXRBL3ZmVmFlamFH?=
 =?utf-8?B?VTFWRW1NODJkd1NhQmVTcTFLb1dWcFZZd01TOC9Vb2Q0OFpVb3d3R3c5N3Vo?=
 =?utf-8?B?MU10Y0VMYVpBaG1qd3RYSm5QVzU5NCs0UFRwNzhhaE5qN0RPNDNueXlkYVgw?=
 =?utf-8?B?ajQvdVl1eTgyQWU5cG5IdkdydThwbm5IeVZYTG5QanhsN05MQTQ3M3g4cjZ5?=
 =?utf-8?B?L3BTK2FDRG5FRGdzV3VSMVhXV3J0WFYwTmNtS3RNRFRWK2NzRDd2T3U0UzE0?=
 =?utf-8?B?cURadytQbTNVdWZkaTV0UHRPcGhnOCt3S3VWcWF3N09IQ3VsVDVZMjNqNmp2?=
 =?utf-8?B?dG5SVWJsWnhGQ2huOUVSdnR2TnY2d2NpZENlUUZ6NGQvMlE0ZFAyeHk3SzdD?=
 =?utf-8?B?TXpaMklJdEk1SzVuS3FIV3hiYm9WQ0d5bFZCbHlrODV5QUkrVm9WTlNyNkxj?=
 =?utf-8?B?Sm05bmZ5SFVodHRLeWpVRnNrS2ZoTy9PMitkc0w2ZFJPWXJzOHJ0eWtscEFE?=
 =?utf-8?B?R0xCT0x1SWRwbzJibFZSUHFzQUJBSzd1QktIY3EweHpkZDhVbVVzdDdMdE9Q?=
 =?utf-8?B?dkJPNjhNaDk2NlI0RGJCUnZGTVRPODZ3T3NkSi8wTFVTczJFM2lXOVdtWVJX?=
 =?utf-8?B?RFZJSlBxZ2JQaFd4OFhURFBOUzNDNlpHRGJPejIwZ2hwU0ZPb1lLNFE2eklH?=
 =?utf-8?B?UzJvMDNmaktuQmM5QndkU2ZUK3VORWNFSUtNWVByc2xqWnhQUjQrbzI2SjVH?=
 =?utf-8?B?NC9JMU9MSjVHMXd5dTdpVnUxdHFEL2JMakxIMHpOWGhaSTZkMFZpU1pPYmsv?=
 =?utf-8?B?SUZyOFlvNFVVNE9CZjJ2ZGg3SW13L3o5UFRKdUhFOWwvOGxqZndld1d0NFVn?=
 =?utf-8?B?Ym41VGdjK1VhMTVzNXpieXAvMFRVcVBVdWVQajhEUTJabk5ZSG5XTjVuV1FC?=
 =?utf-8?B?RytMa3FTMEE1VlZ2WjlERlYxOWd0UU9Bc2JVMTRHbmo5NUgvREdtbWJIa0k4?=
 =?utf-8?B?WU55NktSTElESUNoaU85cVJwSFFrb1JNUmY0ZHJyamdJZkIvUjdEN25rWFFq?=
 =?utf-8?B?QmlBRjRtMWVaaW44Qld1OEtNczBKYWZKUDI4ZStJZEVXWkl6VTMwdlBRZlJ1?=
 =?utf-8?B?VVBwZU16U0RWcTFReGt2SkpSSFI4QzliejNOYXg2aVUyYktaTGIvQUljQzZQ?=
 =?utf-8?B?SHg0QTlFSDVWSUplK2c2R1h4R1hHY0dCNWtyazV5QjJybGVGNERGVzlwaWQx?=
 =?utf-8?B?OEpDUlM0MnVtYXNqMzNkTVZheXVQUmg0M1BsL0xOYTN2YkRScXVnZ3BUaDlo?=
 =?utf-8?Q?uYDo9DfTarXYp7mXsl/o/lo=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 072d5c70-1ecc-4ea5-d45a-08d9efa884f2
X-MS-Exchange-CrossTenant-AuthSource: SA0PR03MB5610.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2022 10:55:31.5092
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ox7CkxJQSDgzfqrEYFJ/24DC1WiF0HKjGutBiRwK8eRxz85hE/cYx6/G1TJi+ETR/WkAF1yVG+xlgsDosK4+Ew==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3705
X-OriginatorOrg: citrix.com

On Mon, Feb 14, 2022 at 11:18:44AM +0100, Jan Beulich wrote:
> Anthony,
> 
> I have a couple of simple tool stack backports queued, which - with your
> agreement - I would want to put onto the stable tree whenever I get
> around to applying the next batch of backports:
> 
> d9d3496e817a tools/libs/light: don't touch nr_vcpus_out if listing vcpus and returning NULL
> e62cc29f9b6c tools/libs: Fix build dependencies

I would also like to request:

0bdc43c8de libxl: force netback to wait for hotplug execution before connecting

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Feb 14 11:11:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 11:11:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271424.465851 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJZGQ-0006F1-7F; Mon, 14 Feb 2022 11:11:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271424.465851; Mon, 14 Feb 2022 11:11:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJZGQ-0006Eu-43; Mon, 14 Feb 2022 11:11:26 +0000
Received: by outflank-mailman (input) for mailman id 271424;
 Mon, 14 Feb 2022 11:11:24 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=jzps=S5=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nJZGO-0006Eo-E1
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 11:11:24 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d6b568d5-8d86-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 12:11:22 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d6b568d5-8d86-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644837082;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=3X5TbiYxIcmGeMsEYuWJowladoxgQEwdMVDxs5bkkzw=;
  b=YJfJQO9K2gyEkZNLK4tLCMXQN+zirinOrmzWdFw2WEy+8fXSIKsh0xxn
   5XzcInuZARChcMc7LsuXLihrI6tMLdQ4XxFa+jhWuDlrVXYThPchyMW6b
   vlEAebBc8QVg9Mwr1bUDk6b7UWjMWS+hvPFac8DOi509/yTEN6e5jPsrI
   w=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: GxV0ZSIrcLEFptTL9rcORFpEVNHERXBkvMyjemQNxaarfDJHDrPDBOq27E81Wa/V/7pG9ak9YJ
 C9Ex6F61BdVnjzFqz34BlJikzOeUSG3i4Y1EmuLP3uKg2zW+kr/VWRyeAGZ6ms873pF3qUqvL/
 EMoD3nUd1RaLy0LfbS5f+REN8f5jAYWbvzMk6s0y62NCByF3oBUH1IdPSV/TKmMTelQcfeODCM
 bZO/3Rs5xedEQTcAt5HUoJMIN3nLBpNykT6vaPyzaZciah5c17YZAYcrVh2x/Z5VQPo721NPZK
 OCBBxyDyvPJ2bGd60iqsh8Ze
X-SBRS: 5.1
X-MesageID: 64043705
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:p5RdLaO8GJQvuufvrR2skcFynXyQoLVcMsEvi/4bfWQNrUp0hTVRn
 zcXWmGEbqyIYGD9fdFzbo619hgC7ZCHyYcxSQto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6UUsxNbVU8En1500s/w7dRbrNA2rBVPSvc4
 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq
 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYoz6Ao45/y
 tsKj8OxEVg5HrLRo6cMfiANRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs
 6VFdnZdNXhvhMrvqF6/YvNrick5atHiIasUu216zCGfBvEjKXzGa/uWvYMDg29t7ixINe3XO
 towNCBzVg7vWSQTalI4BrIBx8790xETdBUH8QnI9MLb+VP78gt117T8NcvPTfaDT85Vg0Wwq
 3rP+iLyBRRyHPubxDme+3SgnNjzjDj7U4IfEr6/3vNyiVjVzWsWYDU/T0e2pM6cm0G3Wt9BA
 0EM8y9opq83nGSxR9ngW1ujoXiLvjYVQd8WGOo/gCmHx7DI+Q+fCi4BRyRYdd09nMYsQHoh0
 Vrht8PkA3ljvaOYTVqZ96yItnWiNC4NN2gAaCQYCwwf7LHLh4U+jQnGSNp5J4ezgsfoAjH7w
 z2Mry8Wiq0aiIgA0KDT1VLNji+op5PJZhUo/QiRVWWghitif5KsbYGs7Vnd7N5DIZyfQ13Hu
 2IL8+Cc8eQPAJelhCGLBuIXE9mUC+2taWOGxwQ1Rt94qmrrqyXLkZ1sDC9WL05VbMgGd3jTP
 06L5hNx+4Jof2qHVPoiC26uMPgCwa/lHNXjc/nbaNtSf5R8HDO6EDFSiV24hD60zhV1+U0rE
 dLCKJv3Uy5GYUhy5GfuH48gPakXKjfSLI85bbTy1FyZ3LWXfxZ5op9VYQLVPojVAE5pyTg5E
 uqz1ePXkX2zs8WkO0E7FLL/ynhQcxAG6Wje8ZA/SwJ6ClMO9JsdI/HQ26g9XIdugr5YkOzFl
 lnkBBMElwqv2CCfcF7QApyGVF8IdcwhxU/XwAR2ZQr4s5TdSdrHAFgjm2sfIuB8qb0LIQ9cR
 PgZYcSQasmjuRyckwnxmaLV9dQ4HDzy3FrmF3P8PFAXIs4xLySUq4SMVla+q0Ez4t+f6JJWT
 0uIjViAH/Luhm1KUa7rVR5Y5w3t7CZNwLooByMl4LB7IS3RzWSjEASo5tcfKMAQMxTTgDyc0
 gedGxADoufR5YQy9bH0aWqs9u9FysNyQRhXGXf197GzOXWI92av29YYAu2JYSrcRCX//6D7P
 bdZyPT1MfsmmldWstUjT+Y3nPxmv9a/9aVHyglEHWnQawj5AL1XPXTbj9JEsbdAx+EFtFLuC
 F6P4NRTJZ6AJNjhTAwKPAMgY+najaMUlzDe4O4bOkL/4CMrrrOLXV8LZ0uHiTBHLaszO4Qgm
 L9ztMkT4g25qxwrLtfZ0XwEqzXSdiQNCvx1uIsbDYnnjhsQ5mtDOZGMWDXr5JyvaslXNhV4K
 DGjm6ef1a9XwVDPciRvGCGVj/Zdn5kHpDtD0EQGewaSgtPAi/I6gE9R/DAwQlgHxxlLybsua
 G1iNkkzLqSS5TZ4wsNEWjn0SQ1GARSY/G33ykcIyzKFHxX5CDSVIT1vI/uJ8WAY73lYL2pS8
 7yvwWr4VSrnIZPq1SwoVE858/HuQLSdLOEZdBxLyyhdI6QHXA==
IronPort-HdrOrdr: A9a23:VtdhAKxk4Je236DgXxQqKrPxtuskLtp133Aq2lEZdPULSKKlfp
 GV88jziyWZtN9wYhEdcdDpAtjnfZr5z+8J3WB3B8bfYOCGghrTEGgG1+rfKlLbakjDH4JmpM
 Ndmu1FeaLN5DtB/LbHCWuDYq4dKbC8mcjC74qurAYOcegpUdAa0+4QMHfrLqQcfng+OXNWLu
 v62iIRzADQB0j/I/7LTEUtbqzmnZnmhZjmaRkJC1oO7xSPtyqh7PrfHwKD1hkTfjtTyfN6mF
 K13zDR1+GGibWW2xXc32jc49B/n8bg8MJKAIiphtIOIjvhpw60bMBKWqGEvhoyvOazgWxa3e
 XkklMFBYBe+nnRdma6rV/E3BTh6i8n7zvYxVqRkRLY0IXEbQN/L/AEqZNScxPf5UZllsp7yr
 h302WQsIcSJQ/cnQzmjuK4Fi1Cpw6Rmz4PgOQTh3tQXc81c7lKt7ES+0tTDdMpAD/60oY6C+
 NjZfusqsq+SWnqLEwxg1MfguBFBh8Ib1K7qwk5y4OoOgFt7TBEJxBy/r1aop8CnKhNPaWsqd
 60dZiAr4s+PPP+W5gNc9vpcfHHeVAlfii8RV56AW6XXJ3vaEi94KIe3t0OlZWXkdozvd0PpK
 g=
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="64043705"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ZjPLYZZmBwsobBDPx7+BH89dppX3eeuOjlikmoYzSlE5lA2kzIiXCPC1FYxPoNJpeJumwGTuYdmQ9n4trSZybB+lHw+J8lmrIqOuBFrRYP0STcCnFsRn46MpOb274uqDGnqhSe7US7iZtXBO0F2MlfNDD2aBtODOcSvpNls6D6QvDN1bg2nWRA+0prILBubP/Bi8zIVV6LylCSGqZr7VkbivoNMoq/Xbykwx6Te6spzQ6c1oCYdLU5ztZc3iZiwgfIAL6ZbSMPqjlW3neLM5JirsCvbZBgKgvZnToMgp7Aj3F6pyxd+oaxAR6bMU4ugWgjDi+jQJKRJ5q99yotLPxw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=AxbcAcIV1mqtbUwec8vq0aeTNEJjfjry4Um6tFjlGaM=;
 b=CZHI/tz8+5Zvizk3NLmgr54VBpk2+7dbUVxzP9NBdbTNnE7bn7o20Uxre7xZyk4P2Hy0nCIZRvUv3pYxqGUuCeB/z/6uk2g5vEbUWNaXc88oScA1dz2buANw8kNCTIo1u+wjExRdhE4NrM7jKe8JKIry10LgD6kSN87HzuX3OR5XUi/zVCgr+W79vYWssvQkFt1fHqDgeerWBfCoGFR7LGZEGC3Gw/jNtmStEFDMBjEwV8/fbj5++zpfOVN37rAu6fsOYLB84bESinMBZTGF4kYz9DvelFukW4DKy7QdhKxfF0GWsku5zQnoM6ObKG6n3Xad77edLYjSoCO88nXDCQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=AxbcAcIV1mqtbUwec8vq0aeTNEJjfjry4Um6tFjlGaM=;
 b=mFMlWN1WE7yy+5RhfF1h74h7zol7Jdiywq/k23m/g10V7d/QOJH2nArTKbX2q6zvlQo9aX0FeVM/C44I7zhuBHihFOHbenyLSqWznDS90S1AE0wz6um7MvldT+GEioZzXjYF+SZ6lf1yQEe54nA0L2KdJbweI6FBl10zBWMinLo=
Date: Mon, 14 Feb 2022 12:11:12 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"jbeulich@suse.com" <jbeulich@suse.com>, "julien@xen.org" <julien@xen.org>,
	"sstabellini@kernel.org" <sstabellini@kernel.org>, Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Artem Mygaiev <Artem_Mygaiev@epam.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>, Rahul Singh
	<rahul.singh@arm.com>
Subject: Re: [PATCH] vpci: introduce per-domain lock to protect vpci structure
Message-ID: <Ygo40L4dMPJjZKRF@Air-de-Roger>
References: <20220209133627.959649-1-andr2000@gmail.com>
 <YgU6Snk8GTytJXZp@Air-de-Roger>
 <c4666570-666e-6680-5ec2-adf1da51ad06@epam.com>
 <YgZLEMW9US9QjjYG@Air-de-Roger>
 <33fb1095-64ed-29ef-ba6b-cbde21d941f8@epam.com>
 <YgowIg5MvTaf2zsR@Air-de-Roger>
 <d8389a90-00c8-b34a-8488-b0f3fc5bde1b@epam.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <d8389a90-00c8-b34a-8488-b0f3fc5bde1b@epam.com>
X-ClientProxiedBy: LO4P123CA0344.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:18d::7) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2fb8e2f8-377a-4305-2ccc-08d9efaab827
X-MS-TrafficTypeDiagnostic: CO1PR03MB5729:EE_
X-Microsoft-Antispam-PRVS: <CO1PR03MB57295657D8AC19CAD9796F3B8F339@CO1PR03MB5729.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: k2lFOSAKtx3UlkAXBovR2w3lUYNeTuPkkGVAFoJkD+rfWBkyN2KO3QTXVOcUDr7ZxUcOCjBi8OFVodYHTHny6ii3laoLr5J1GHyz81wPaHXmvEtEdkw+pRIsSIEIWCE8ah75udoYpG/eT9UJRubFK7JbOy9a2D2nKitYVIJd8/iGvp+lGtpvE/Fp8hA6yq1lfUhtIXyY8o1ODEEWSiuCnjkijG3CHYsq1xyCPiQBCkUgMfLKeqn/MfgGi8DIbavnOOWKbQvH9pm8/uVu4E3Y+/eva8MwniaPwBClKgEbddDphvotxyuB7nFf1ctnaY0k/6zEF60WMV7XqAHJQcR4E81R+VCrbEYUpJZXlBlMgrcyUUY+60cP9gfLu/EEGA9ssGJN9vvWrK1DU7TFRJ6RdGd68adTt3CkfhHitD+0U0Zl+Yngw+iScidkS2LVGq3AL+/5tp/Mrq34NnpvMXGhxrAW0u57B55dlaJ1ty6U7D9HNdXxMGpDMXfB94keGgbxa98nfckhPS5/7dg4nxCALv99/lx9frNcTA/Ot7X5yAppquZdpulwbJhjayrWk/ayGYctvWzB+SPhyqW/tE2bngXd+6g7U1pseOCNVXtbyuCfF/7yCN14imX0b08O8E9mQPwKiFa1nK1S9GRYa7Z1Kw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(38100700002)(33716001)(82960400001)(53546011)(6666004)(8936002)(66946007)(66556008)(6486002)(5660300002)(7416002)(8676002)(66476007)(508600001)(4326008)(6506007)(186003)(85182001)(26005)(86362001)(83380400001)(2906002)(316002)(54906003)(6916009)(9686003)(6512007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OXVvdmEreEFwRGN0ZEQybkdFMUQ3aDdoSmcyRFYwbTZEa2JseXVjOHpZZUZI?=
 =?utf-8?B?NHVOb1RuenRjWnMrUzU5MndsZUFCQkM2U0FacURiS1R0QUFBVzE5VHE3RlBR?=
 =?utf-8?B?MFE1dlNKekZBeFpEUWxVb3N6ZEVmZ091NisxL29ZK2pRSEw4c1VBaG1rdG4y?=
 =?utf-8?B?c3lzQ29KUnJUais2L2lFTm1FNFhFUDVQT3dRQVpjc3ZuN01tWFZFV1hOdmVB?=
 =?utf-8?B?MTh0TFI5aTAzQ2tiZ3JSNzc0QW1tRmlsKytjSG0xYmtpUjZqbUM3aVZFTzBK?=
 =?utf-8?B?V08rejJlZFEzVXdtQm9xYnhWSFhSSnJzdDJkYWNRY3BZTWxRanViOE5Ib2sx?=
 =?utf-8?B?akwxcndNR2lVNUE1cmNPV2ZETk5SZGl6UjRpQUN3aEh0eVNRVFhheU1vTW1K?=
 =?utf-8?B?dUYvME1BYldkdVA2MC91ZzdIVnp5S1RjV3RMSUpKanUzQTIrR1FaWDhqY2Qy?=
 =?utf-8?B?YlhHMW4wczRQMWdCMWVLd1k5bzl5VWVSUUIwVDhOK0Rtcmd5ckJrMkpmUHNC?=
 =?utf-8?B?cHdJK29SZ1pUbTJMenl2RUl1Q2RyMEtpWFFWb3BFdDdHZmxVcGJxekx4Q2ow?=
 =?utf-8?B?U2J2bkF5WFRSWVRVcVdiZWViQ2VVdEs3K1lCdHRkZW0zenlCUzA4eXE5dC9N?=
 =?utf-8?B?UHJUck82d0k2aGFsbnNENUtGalJaK1dLMXYxTG8wbnJjTzFmMFJZS3ZxU0pk?=
 =?utf-8?B?NTJYZTVydXVYTEpXNHY1UVZpaXdCajhwTnE1S0Z3SG9OdXMxcXk0bWkxMFFl?=
 =?utf-8?B?UUEvV1JoQktYWG00ZFgvM09Da1FOa1ZQbTF1YUhVTk9hUzhmRUlISVdzeTJt?=
 =?utf-8?B?dnZ3dHFtOVMxR3dkU1p3QTdFdC9rdENnTWZvR0JVVmdpN0VOMFFKQzhOMi8y?=
 =?utf-8?B?aXhzNnI2dEdJTVplUk1FbXVFN3U0QmsxbFN6NFQ0ZFFGbkJESW9BU0JjeDR3?=
 =?utf-8?B?ZlBUWWRyNWxSNDVnS1VzNkxYVENneEQ5aWpFRlo5dW5raVdGWnF2ck1lYU04?=
 =?utf-8?B?SGlYZ1V5K0lUamZveGNZWlJuYzc4ZHpWWmJtTUxwUWFFY29Zb01RYmJGN3lY?=
 =?utf-8?B?TWJwM1lSYkdYbEdLZ20rdXVhRURUUDVZcmRlVVp1UU8wSFJZb250MUo4ZmpW?=
 =?utf-8?B?MGF4eG1yL3Z4SWhNNE84V0NpTFp4ZFpYejJBcFBIYSsrb01hR1hkVW1hTDd0?=
 =?utf-8?B?NkpxdzdVS2lqMjlUajhiT1BIbU81REpDbFBsS2VYd2dHZmNJMFhpS2NnZ056?=
 =?utf-8?B?TzlZdVFrbnhjcFoxd0J2SW9vTTQ3Y2JYaWlEV1g3R0t0WmNmUUtyVHgvWUc4?=
 =?utf-8?B?WmZyeU8xejBldWdNRjBnZ0wyN1VoOEtza0phTjdsb1hyWmppNHhPUVM0ZlVV?=
 =?utf-8?B?Z093U2drRDMydmk0OWlocmNZdmsyWi9hZGNRNlJWQ1N1MEM0cFhsK3ljTk5n?=
 =?utf-8?B?QmZmZXQzZVU0K3krY0Y2WEprbEFyRFJ2UkhWSGtzRjJxanY5U3QyeVpNbVZm?=
 =?utf-8?B?R0IvNWNwYUR4aXhoV1FCeDQxaW9kSHhYaG52Y2I0aTRYV2tOaVpxWUROakpO?=
 =?utf-8?B?bk04M09Sc0dZOXdnWTRHNzVzRWp5QXRFL1JUZDl3Y0lGR0syRHZZQlBjV092?=
 =?utf-8?B?N0RQd1dENURHT2pONFF4SlZOMEtvTVF1cFdqOHo5djd4aGZRMmxCcUlrNytw?=
 =?utf-8?B?dEhOckJSZWZqcFR4cUszaHJuYmZmajBnYUJTZndwM1NoNmRUTTNCdFJYbm1r?=
 =?utf-8?B?cEhaRVpPRlJNSkd6dVB0Y2VBWGg0TzNneUVtZ2oyaGsyamF5MTRJSUxMcU85?=
 =?utf-8?B?d2FFSElzamhwaVRDMzNpeENncVlQQnFTdjNaM24xSVBSZ2wzbFFaWENCL1Jk?=
 =?utf-8?B?b2RneTlBNzdEOXNkTVVQSlRTbGlpWWNnZVdZNEptaTRKVmhjckd0MVg5M3BH?=
 =?utf-8?B?cjI4OFh5SXp4MkRtVHBrbHRYcWFsZ29rQjRCNHg1QVVkb3JaMDhsZzJ5U0tR?=
 =?utf-8?B?ZG1JY2M1elh0NVNJdmFva3hWdkowekxhOGRtaGt0UUwwZ3AyWkJDMkNLMHcw?=
 =?utf-8?B?c0QrMUJjUGFOVWl5UTg4bVRTZUZ5STAzMlFxbjBYZGZnNm1WcTliSnZXc2pu?=
 =?utf-8?B?UjlZaWQrNXYwMUZKZ3JWclRQYnBxOUVuSnowcVFxazB3TUNGUTlCZEIxOEZp?=
 =?utf-8?Q?Zoq1g8Jr31M8YUV2mMr9vXk=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 2fb8e2f8-377a-4305-2ccc-08d9efaab827
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2022 11:11:16.4408
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FnnBnIwzMTV7Lhe9GqEGkUjCZhboDQVI06Pok7JtyS0px9gGL6bgocdlM03dq4USmHr6+hesnDu5DPRXkS12tg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR03MB5729
X-OriginatorOrg: citrix.com

On Mon, Feb 14, 2022 at 10:53:43AM +0000, Oleksandr Andrushchenko wrote:
> 
> 
> On 14.02.22 12:34, Roger Pau Monné wrote:
> > On Mon, Feb 14, 2022 at 09:36:39AM +0000, Oleksandr Andrushchenko wrote:
> >>
> >> On 11.02.22 13:40, Roger Pau Monné wrote:
> >>> +
> >>>>>>         for ( i = 0; i < msix->max_entries; i++ )
> >>>>>>         {
> >>>>>>             const struct vpci_msix_entry *entry = &msix->entries[i];
> >>>>> Since this function is now called with the per-domain rwlock read
> >>>>> locked it's likely not appropriate to call process_pending_softirqs
> >>>>> while holding such lock (check below).
> >>>> You are right, as it is possible that:
> >>>>
> >>>> process_pending_softirqs -> vpci_process_pending -> read_lock
> >>>>
> >>>> Even more, vpci_process_pending may also
> >>>>
> >>>> read_unlock -> vpci_remove_device -> write_lock
> >>>>
> >>>> in its error path. So, any invocation of process_pending_softirqs
> >>>> must not hold d->vpci_rwlock at least.
> >>>>
> >>>> And also we need to check that pdev->vpci was not removed
> >>>> in between or *re-created*
> >>>>> We will likely need to re-iterate over the list of pdevs assigned to
> >>>>> the domain and assert that the pdev is still assigned to the same
> >>>>> domain.
> >>>> So, do you mean a pattern like the below should be used at all
> >>>> places where we need to call process_pending_softirqs?
> >>>>
> >>>> read_unlock
> >>>> process_pending_softirqs
> >>>> read_lock
> >>>> pdev = pci_get_pdev_by_domain(d, sbdf.seg, sbdf.bus, sbdf.devfn);
> >>>> if ( pdev && pdev->vpci && is_the_same_vpci(pdev->vpci) )
> >>>> <continue processing>
> >>> Something along those lines. You likely need to continue iterate using
> >>> for_each_pdev.
> >> How do we tell if pdev->vpci is the same? Jan has already brought
> >> this question before [1] and I was about to use some ID for that purpose:
> >> pdev->vpci->id = d->vpci_id++ and then we use pdev->vpci->id  for checks
> > Given this is a debug message I would be OK with just doing the
> > minimal checks to prevent Xen from crashing (ie: pdev->vpci exists)
> > and that the resume MSI entry is not past the current limit. Otherwise
> > just print a message and move on to the next device.
> Agree, I see no big issue (probably) if we are not able to print
> 
> How about this one:
> 
> diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c
> index 809a6b4773e1..50373f04da82 100644
> --- a/xen/drivers/vpci/header.c
> +++ b/xen/drivers/vpci/header.c
> @@ -171,10 +171,31 @@ static int __init apply_map(struct domain *d, const struct pci_dev *pdev,
>                               struct rangeset *mem, uint16_t cmd)
>   {
>       struct map_data data = { .d = d, .map = true };
> +    pci_sbdf_t sbdf = pdev->sbdf;
>       int rc;
> 
> + ASSERT(rw_is_write_locked(&pdev->domain->vpci_rwlock));
> +
>       while ( (rc = rangeset_consume_ranges(mem, map_range, &data)) == -ERESTART )
> +    {
> +
> +        /*
> +         * process_pending_softirqs may trigger vpci_process_pending which
> +         * may need to acquire pdev->domain->vpci_rwlock in read mode.
> +         */
> +        write_unlock(&pdev->domain->vpci_rwlock);
>           process_pending_softirqs();
> +        write_lock(&pdev->domain->vpci_rwlock);
> +
> +        /* Check if pdev still exists and vPCI was not removed or re-created. */
> +        if (pci_get_pdev_by_domain(d, sbdf.seg, sbdf.bus, sbdf.devfn) != pdev)
> +            if ( vpci is NOT the same )
> +            {
> +                rc = 0;
> +                break;
> +            }
> +    }
> +
>       rangeset_destroy(mem);
>       if ( !rc )
>           modify_decoding(pdev, cmd, false);
> 
> This one also wants process_pending_softirqs to run so it *might*
> want pdev and vpci checks. But at the same time apply_map runs
> at ( system_state < SYS_STATE_active ), so defer_map won't be
> running yet, thus no vpci_process_pending is possible yet (in terms
> it has something to do yet). So, I think we just need:
> 
>          write_unlock(&pdev->domain->vpci_rwlock);
>          process_pending_softirqs();
>          write_lock(&pdev->domain->vpci_rwlock);
> 
> and this should be enough

Given the context apply_map is called from (dom0 specific init code),
there's no need to check for the pdev to still exits, or whether vpci
has been recreated, as it's not possible. Just add a comment to
explicitly note that the context of the function is special, and thus
there's no possibility of either the device or vpci going away.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Feb 14 11:13:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 11:13:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271430.465862 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJZI8-0006of-Ki; Mon, 14 Feb 2022 11:13:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271430.465862; Mon, 14 Feb 2022 11:13:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJZI8-0006oY-G4; Mon, 14 Feb 2022 11:13:12 +0000
Received: by outflank-mailman (input) for mailman id 271430;
 Mon, 14 Feb 2022 11:13:11 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Fl/D=S5=epam.com=prvs=4044f48eaf=oleksii_moisieiev@srs-se1.protection.inumbo.net>)
 id 1nJZI7-0006oS-Q3
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 11:13:11 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 16be63d1-8d87-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 12:13:09 +0100 (CET)
Received: from pps.filterd (m0174676.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 21EB3sG8018396;
 Mon, 14 Feb 2022 11:13:06 GMT
Received: from eur04-db3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2051.outbound.protection.outlook.com [104.47.12.51])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e7nvfr0ve-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Mon, 14 Feb 2022 11:13:05 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com (2603:10a6:102:ea::23)
 by VI1PR03MB4048.eurprd03.prod.outlook.com (2603:10a6:803:6c::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.15; Mon, 14 Feb
 2022 11:13:02 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::c1c:f98:9dd:86e0]) by PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::c1c:f98:9dd:86e0%6]) with mapi id 15.20.4975.018; Mon, 14 Feb 2022
 11:13:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 16be63d1-8d87-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=bKopcK520S2aotV2j/zX7iVnd1eVXHiRkIW1bD9cI5fddMntXkUYCDYtdBi66L2Av81fPWWULh5xtWZfGIG7noozTtUHc8YQH/NwZlqKv7jI7CKyZgoZJ0jwYC5cMoorew31XsGNGyt7bqzH5LUBc3jxoFpjkeEdL6HqVR7S+xCGMSFpplGo9+i/MyL9hc5ghPlzfULwO+ajybJhLyxXI8D6b6zoa1PhKNWrXQrPEns9hS2yD2W/xuvMhJPdTPM3L60A8NIWohaaGSnhF5mjGjSgiusZqXVusvP/FQcM5sFRGHd9EF8BdA3sOtbcqmlnJBLldYNObA29J64za8jbtg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=uWaxXS7Z1X7Gxf4sIFuQi9p23QJMjFL2IpMhQlPDNng=;
 b=Qo2MjaPPKY5TW254dHJcN8tG3f8YQNiH5uE05uAHi7Qo/I7Jq40PSvi/MzEsPf4SHNHvQHp3OwLDqcNnCZIAE4IMmnT9vwlLb1v8EPMgecPe7/r/Uh+cJ4FlJ+6Bq9l9aZ8X2F1SVa9JAsFIz+KCW1GZefke0oPpkKCOlu/x6h0v+Q5cs88Su/6d1yIzCbRtzxcW2SoCI5uff7M3vOQ4VsR70bFDuSs2qbLVjafnfs+0zo1CG5Wxys7ECq7zB+O7MHXtXGb5G4JQVUfDFIosSJKJJOmu3oDIkgqS0tth0zpKy4xNznfW9ZlVd0O4TXyUQNjouey4mIhoxV5IuJ+GNA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=uWaxXS7Z1X7Gxf4sIFuQi9p23QJMjFL2IpMhQlPDNng=;
 b=UKlGRkQTJRRi1e4OivuvhQBERSk+EDt+uo2Yo0Av+WPzhfCujIr223RiPDMLYp1ptqhLXNaZKKhmpUUHcNWiMQaYg0f/xzzAnopF+VJWRN5pBtlbUx1jQp8SVTCvvbVHTUyHy9bmUWkTu50QbireKpH83IAwN/jZaG79oiqujZkbK1Lg9p+S6qiyhj9lZJT/cbrpi2jnmv4g3J16XWNv+BicBMcpbGMYSXAsEqYt5DlSZ8UVF+FEhej2n1zlOzQxAM62fLytGPMxkAk/RNZ/BUey1JRd/zOUrGpDqAiK8WMjIU6P2nlMyyE1CgANu9stJppviByXPsAbwojqOoTxuw==
From: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
To: Julien Grall <julien@xen.org>
CC: Bertrand Marquis <bertrand.marquis@arm.com>,
        "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        Stefano
 Stabellini <sstabellini@kernel.org>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>
Subject: Re: [RFC v2 5/8] xen/arm: introduce SCMI-SMC mediator driver
Thread-Topic: [RFC v2 5/8] xen/arm: introduce SCMI-SMC mediator driver
Thread-Index: AQHYHRW24Dmb0qV8ZkqAv39Pf6/nVayODW6AgAAg+ICAAAmzAIABqiEAgAMLQQA=
Date: Mon, 14 Feb 2022 11:13:01 +0000
Message-ID: <20220214111300.GA3615313@EPUAKYIW015D>
References: <cover.1644341635.git.oleksii_moisieiev@epam.com>
 <cb1493f5d9b5c3437268054b4a8e345cb35c8708.1644341635.git.oleksii_moisieiev@epam.com>
 <F9811680-C6EC-4372-A451-5C1DA279E35E@arm.com>
 <20220211104403.GA2291814@EPUAKYIW015D>
 <A9FF3FBC-C29D-4A17-8737-EBABEF240BA2@arm.com>
 <c13f6312-3922-4504-3248-e2e4701b1a10@xen.org>
In-Reply-To: <c13f6312-3922-4504-3248-e2e4701b1a10@xen.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 439d4a28-00c0-460f-52ec-08d9efaaf725
x-ms-traffictypediagnostic: VI1PR03MB4048:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <VI1PR03MB404812D466520413022BB96AE3339@VI1PR03MB4048.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 S9RwJdiqOAVTc25eMhe+p3L2jzSEdFbkTPvBU0TRJminAERUojunD+DdWnOetbXEbTuPGZFU3mzW0Zr5X4yK1mcV9twJ58Xjh8yl0KDy6bOURwMoDykPvAdDK6dhwgL/nc9wieSZkusYRtAV0mEweqQoHcDCjOqJVqyDa0gtfEoFgvLmS4lnO0GqusKBpNnu6pKyBPfzYM/pJQ60EhTnKPfneladrwgLCn/EKHVTvHt24AOpRJUJK+R+bQrU1K8Kdimgy0q/Wv9IIQVqaj2f7aXpP18htBvhNCIVFbRVOeqURsplVl/nrvy1WZeCkHNOL7uznunuhkIwaquJCziPMs4qOYITpmAItwIwUBwdD79KA+HeSM75au7QHtGF3bNqImRZm8tmERhV1E9/75Lope9eh1Qal0bKbpBpo+BWnc4yEckQgNj3yR26yrhLI3ag/jfi1vTMEF8UUQaRpqfqGEpC+v7wSRNZs8QrSHzjVwGB1ANdZUDj8YgcbsMxH6DpOLKFXhRGNBgCB2VdQjK/IZWHt50t1XDpyVTl2c6b+7PFAE0iaLGijBTeh07sRbYIDBvj2k8wthZTxiJhIgg+MfaHXoCfNUl+70S89c+gRk05KZDOGRmSmkdbzkIUdicpGyjRTXF6jfnSGxKPZh7zGrTP2EFgNyjhVXM2vu4ux9RLd8dioemu22enmZFLkfu4BQw2RLHBA4X2ZrFiNJy/0sB0I0xaiAbjXpP03TEjzewEmjBnXqy77KjCKF+0zimwHlpD7FAZMcogRuswd6ZUHFVONP0iNyE5pcnskFOW6H8OmR34PxtpT3DIu1CyVl7pZ1MJVCjOn3YH+bUtm+dCVWjiaC6MwigWNKkm49qzQhMRnwxdUljgWEP9Ujdlr6jj
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR03MB7136.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(66946007)(76116006)(83380400001)(4326008)(91956017)(107886003)(86362001)(2906002)(5660300002)(66556008)(66476007)(8936002)(66446008)(64756008)(8676002)(6512007)(9686003)(966005)(6506007)(54906003)(6486002)(33656002)(6916009)(1076003)(71200400001)(186003)(33716001)(53546011)(122000001)(508600001)(38070700005)(38100700002)(316002)(26005);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?Cogbt11ya8WUbJEN8UdtLplpzCDXSVO72b8CXjNR0ubavWLFXeezZ9ETT9TG?=
 =?us-ascii?Q?uHQlrn7yGjEJlX09P/Ck7FIEonaeaUukgVT43cqrKveoiikMzD2yBSm8h7Mc?=
 =?us-ascii?Q?fnHaJnjiXZofJY7t2clG3k0NPUXIc/W9W02PWGof76k+h3UDaIX2xnHgzARG?=
 =?us-ascii?Q?0C58IlUZRKaVcWD7+XcHPxiW9xYf1kdFyIDdwT4/jLaYs+HySr2iK8uhlf66?=
 =?us-ascii?Q?iPBOFTzqAgrJNmTP2ZY82cKmxsXmRImhVadM3tZcAUip65RuRBpDO3BuiQS3?=
 =?us-ascii?Q?9DElyssxpu2rUSkGGhibZXOrYUFChXd5968bvK+fdZY1MNAVJK8Np3S+q02u?=
 =?us-ascii?Q?9yc+Dr5hgUAhMUEqXsDTxJKeqntjPoSdY7hOQaVLnJh3HGGccaW6ocVB7xGd?=
 =?us-ascii?Q?L081CIY72/cspg0opCb5YB9vVL0DfYwR7xiHa3LikvSVUQXN030A7ZCir3h7?=
 =?us-ascii?Q?hNjTjzO9t/xVPIE+VbqHd7IczY6hrkRwDWBiMgcWeRj2Eb4XPxIh3BEeofnx?=
 =?us-ascii?Q?nSpgpoRBQWX1rEcRDEYdC3TLONmWrMcVOd79FYKKR04CkQIPlFxE1S6+M7m9?=
 =?us-ascii?Q?qW0Mr9ZfcIVtESLRiMXQTGC/w3jTzt6w+EOOJniguEfEALT2GSrfnJ5ga0mb?=
 =?us-ascii?Q?Qeu1MSQEEqybOptR2U6u3lzA2Px9+M7tqNIyGK10bOSHtBalJdbD0Z+d1+Js?=
 =?us-ascii?Q?8IS8F3AYX0TrUyDjPfSDMla5HLvQJV3s4xlujJgwImyDgieibkzWWfLawO9a?=
 =?us-ascii?Q?AFuRSDZ97BrnbGyCwo/Y6A2VuklAIltlRgfEIJFqEHqnDxXZ5HQEwckphJb1?=
 =?us-ascii?Q?B198lefCuOr1jEbmwX/rDtpMe37wn/GdkQGnQG9RN5DAWnalDDkukUpt9HWV?=
 =?us-ascii?Q?e/u2FpPT356kSjOugY3zKUpGhbl41lx465suE1g+N47JwLiK+lz2izSymh1j?=
 =?us-ascii?Q?/DSPomTm3Hklw3TogasG7IItz51K9HRyK8E3E82pEjP7YZGC3JwrQSnD4zMl?=
 =?us-ascii?Q?T8GnuDRIfwA2rQ9leDc3hfO0U0BW4auZVONNeAr0uvTPA4rr5rJNG3Pat9nb?=
 =?us-ascii?Q?OCB6q4W69C06OEKYF1c+t8Ygduley2UPnh+/kOBDvjkR1yApJfScR2/1LuHP?=
 =?us-ascii?Q?iZNUW0JV0VYSh6368P3VG5I/LZ0jmBgQ1VAUKOdOkIcIBH7/0AMhwNQE7yxl?=
 =?us-ascii?Q?Fa6wrJKOYYMKyzma7NylRxHHs46k668yVF3BBY38tpuv3lEdEAdLNj9LlhQ3?=
 =?us-ascii?Q?xoCsU2zdUFHqxPKgNlnNgIYA3FVCZInqgZ4YI1j7BtoLxy4nr9T5KfhpxAR5?=
 =?us-ascii?Q?ZYTsSbHqnKg88FSINeesmyqnYH2AaPo0aeoNylsfoQkrCgJCImRFUpJn9oAW?=
 =?us-ascii?Q?Oh9ItWxh5Jkx3tSlyfgiDiX89jADFtsPOALDmq+TZsPJOUIVKLMZnxzoJghz?=
 =?us-ascii?Q?GP+GMnYEcfi3af7RnQpcJcTPIRscNuD+AZjNq5Zv0Iux2UV4M036n1/MiTnL?=
 =?us-ascii?Q?LiYid6Uj7AGzfUUo2SGzm4xtCBXJMFARO/JulFDyIx32QEp7mPtyD7ggA5+4?=
 =?us-ascii?Q?SHrfLm3WlK7GQwU/f7Hkqsq6xgEnXMSmgjeoYr70DlTHXY19qZMBkqfiWhBy?=
 =?us-ascii?Q?HI5EEI35Iq15FcM1yUGvGvmbVasHIyAyVksOh6abhzB2e6aUJB1ki6tX3i0p?=
 =?us-ascii?Q?Ki3VSQEnIFrqAE5dLQwXPz2/voA=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <20477E8907A18E47A6B315465FF00150@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR03MB7136.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 439d4a28-00c0-460f-52ec-08d9efaaf725
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Feb 2022 11:13:01.8751
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: fplD4PZ0p3LWiN/JQ5+OsIsITB/iUmHm1KtTnH1SN0srTGQQCwE3DkXepvvAAh0I8E1ScoovUUvnP7EoGFtICcI/qm3yY8UnOszEV3aqpjQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR03MB4048
X-Proofpoint-GUID: XjdeaObatHf1vfpPiORV_B7SEGa_FKzs
X-Proofpoint-ORIG-GUID: XjdeaObatHf1vfpPiORV_B7SEGa_FKzs
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-14_02,2022-02-14_03,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0
 malwarescore=0 spamscore=0 mlxscore=0 lowpriorityscore=0 bulkscore=0
 priorityscore=1501 mlxlogscore=911 phishscore=0 adultscore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202140068

Hi Julien,

On Sat, Feb 12, 2022 at 12:43:56PM +0000, Julien Grall wrote:
> Hi,
>=20
> On 11/02/2022 11:18, Bertrand Marquis wrote:
> > Do you plan to add support for other boards ?
> >=20
> > Did you discuss more in general with the linux kernel guys to see if th=
is
> > approach was agreed and will be adopted by other manufacturers ?
> >=20
> > All in all I think this is a good idea but I fear that all this will ac=
tually only
> > be used by one board or one manufacturer and other might use a differen=
t
> > strategy, I would like to unrisk this before merging this in Xen.
>=20
> In the past we merged code that would only benefits one vendor (i.e. EEMI=
).
> That said, this was a vendor specific protocol. I believe the situation i=
s
> different here because the spec is meant to be generic.
>=20
> > @julien and Stefano: what is your view here ?
>=20
> I share the same concerns as you. I think we need to make sure all the
> pieces we rely on (e.g. firmware, DT bindings) have been agreed before we
> can merge such code in Xen.
>=20
> The first step is to have all the pieces available in public so they can =
be
> reviewed and tested together.
>=20
> Oleksii, on a separate e-mail, you said you made change for ATF. How much=
 of
> those changes was related to support for Xen? If they are some, then I th=
ink
> they should be upstreamed first.
>=20

Let me share changes, that were done to AT-F and Linux kernel
device-tree in terms of the SCMI mediator POC.
Changes to the Linux kernel:
https://github.com/oleksiimoisieiev/arm-trusted-firmware/pull/4
Based on renesas-rcar linux-bsp, branch v5.10/rcar-5.0.0.rc5

Changes to AT-F:
https://github.com/oleksiimoisieiev/linux-bsp/pull/3
Based on renesas-rcar/arm-trusted-firmware branch rcar_gen3_v2.5.

All changes that were done are not Xen specific. Given AT-F changes are
the implementation of the SCMI feature using SMC as transport. All
changes were done accoding to the DEN0056C [0] and DEN0028D [1].

We pass channel_id via SMC to the Firmware on r7 bits [15:0] (See Section
4.1 of [1]). Then Firmware converts channel_id to agent_id. Channel_id can'=
t be
equal to agent_id in our case, because, according to the 4.2.2.8 of [0]
- agent_id 0 is reserved to identify platform itself.


[0] https://developer.arm.com/documentation/den0056/latest
[1] https://developer.arm.com/documentation/den0028/latest

Best regards,
Oleksii.=


From xen-devel-bounces@lists.xenproject.org Mon Feb 14 11:15:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 11:15:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271439.465874 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJZKX-0007W7-6O; Mon, 14 Feb 2022 11:15:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271439.465874; Mon, 14 Feb 2022 11:15:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJZKX-0007W0-1L; Mon, 14 Feb 2022 11:15:41 +0000
Received: by outflank-mailman (input) for mailman id 271439;
 Mon, 14 Feb 2022 11:15:39 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=YsDI=S5=epam.com=prvs=4044e07e7c=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nJZKV-0007Vu-NX
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 11:15:39 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6fa17b9f-8d87-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 12:15:38 +0100 (CET)
Received: from pps.filterd (m0174681.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 21EAmCi0026083;
 Mon, 14 Feb 2022 11:15:33 GMT
Received: from eur05-vi1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2177.outbound.protection.outlook.com [104.47.17.177])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3e7nkg8358-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Mon, 14 Feb 2022 11:15:33 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM9PR03MB7712.eurprd03.prod.outlook.com (2603:10a6:20b:3dd::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.18; Mon, 14 Feb
 2022 11:15:28 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::fc4d:4749:5d1:eb73]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::fc4d:4749:5d1:eb73%4]) with mapi id 15.20.4975.018; Mon, 14 Feb 2022
 11:15:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6fa17b9f-8d87-11ec-b215-9bbe72dcb22c
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=RD1QfVsGYdfRZFS1m85A6QuOk+P6vv7KlivCkXC6/U0jRt+PL6ax56Oma0aOo79F5yRFLSKq3hREZcJJ0hiq+mzuH7afiYBOfY5UJCyrRMMHvDke7SacLRfq6i7lCQdpCxn6OvTlBDZh4KNi7nRU8UukYtouVH+WCvdTHjlDxcbK8HR+DERf52dwWgCWFDbkh8f0nTgA29z0BxPcJD4xi9B6d4DQLiHxpHkBxuOOi+AOO34ozOGByTfyi5ICux25IgbqUoV+2nZkB9w5xAhErq6vLLpYaO2HW8GkNyqmKl7JvbPp+9zC5U7H6DIR+eelzYYSswKuazpRhfamkcJsXg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=BhNrOzYs5sJctlI2hMYOJh0hNztlBRy0Yi+1k1h84sc=;
 b=PuZlzSYjovFotSODMhYc/jp924ILeQEvSHrL9G2DAopZCpbIeb1WgIQ/sGvSuVR3rOmneKr4++ZZAn73WeltM2B1rOiZcVBKKV+gdVF+fBnlhlKEcFhrAOiyHMbFf+0RzO6Ogd25lGLK1+IZ7iWIQJ3G5IKf7VQwjmmnACHCYv6hmEwAnNU0Y/rpYwx29xgl3w4Vka1B8XJrqkOGNJwtrS4tNebzapwJ5v08oT206OXXILtAWseerx29+KJQAU1dpyealj7IPu/mEqPjK4vcZ12gEnkdvBcp7V9poyOI/mrEt82ji+2w0/6B9emaRsUreYtkXGK08a5GHm7A0lpvEw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=BhNrOzYs5sJctlI2hMYOJh0hNztlBRy0Yi+1k1h84sc=;
 b=HJwkHTlBkP+iRxD71RrnQYLE3OGvkVNAt438pUukpkRj/2AVu3Rcm+s5J29t4k0scAjL9j+iiAWVRTtI6t0ESFba2b1sYrmAQO7I4Q9S9ZY0WNx4wtq6QnfuaPpS69EL9GsYyuQnuIG4RIMCZ8mnzDWwXLlOGphuwZRYbNaBk9sZkQDzQZsV2P0ji6rOTj2DuRloUEQNRYAGdm3xNfEED859cYKM2HW8Kw5MMe09tOprbIykxjsry1gX5qTK2hrqvu2ZevNdm3qpuj2EXEAkKiaupD0hBf9BxT1A6IsbJxi3CfzSWSpkFxLC2MaEMKNyRwrhbgFlCfDFbVjJtfbMgw==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "jbeulich@suse.com" <jbeulich@suse.com>,
        "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org" <sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH] vpci: introduce per-domain lock to protect vpci structure
Thread-Topic: [PATCH] vpci: introduce per-domain lock to protect vpci
 structure
Thread-Index: 
 AQHYHboQT3cBWYI1/EGunE7hOwop6ayM95MAgAD+qQCAAEaDAIAElIcAgAAQEwCAAAV1AIAABOQAgAABMIA=
Date: Mon, 14 Feb 2022 11:15:27 +0000
Message-ID: <746860aa-c403-1eca-0a75-587c5d10c8c2@epam.com>
References: <20220209133627.959649-1-andr2000@gmail.com>
 <YgU6Snk8GTytJXZp@Air-de-Roger>
 <c4666570-666e-6680-5ec2-adf1da51ad06@epam.com>
 <YgZLEMW9US9QjjYG@Air-de-Roger>
 <33fb1095-64ed-29ef-ba6b-cbde21d941f8@epam.com>
 <YgowIg5MvTaf2zsR@Air-de-Roger>
 <d8389a90-00c8-b34a-8488-b0f3fc5bde1b@epam.com>
 <Ygo40L4dMPJjZKRF@Air-de-Roger>
In-Reply-To: <Ygo40L4dMPJjZKRF@Air-de-Roger>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 2c245e28-f36f-4bd3-645d-08d9efab4e29
x-ms-traffictypediagnostic: AM9PR03MB7712:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM9PR03MB7712F58CEA50A3B595FCE73FE7339@AM9PR03MB7712.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 StQ2wwCZXQVQs7S/vNcUrOLW5eNgIhfwXSZyI7qL9G4sAcEApHXOBb+KVB81tdstX4vzuI4oGAOksff83eyHtPzSR3brwFSc5BQ2W96NgDVe60dleQPcwbhlDjrsCHV6EC42fZrreZMetQ0by4uVr2+h7hjPJz1MvLvN40d2cmW3jWp7U/hXB2NCZ9IBe+saNTHKKVYT/DhTSpUlu82RSxZRJoU/tAcxhYNCWCR+xDOScxsru1wXO3jammDZGD1wSLKwLO5vY/7kTHHmxhGbrwWwXe4S2NIQ09sRS6zuUYI2kSftUOaEqecQXLGFnjshigUbSZyvQ1BMaKOC6epnGXxneFMGmOnQt+NAktVPbMDxj9RFktpzMyk5ls5O5oQhWLovQKZYlS5Kv8+LBDJR8rwTvoqoj1o4l1SNPgmlFvhkC8aX1EAIOGn5kXvtkw0Zc9fTzfjwXg6uSb1dqAiBycIRfO5JwNA/EMirvdbHLpKzBCUu8d/YLaDFQK3IhkPwWs7ig4/galg+PVZUaWQ4Duk7sC4nn8Bvv2pYmZC8CLvVIEn2GfOubgyPPng3Rznoa3nusvaCg0oaPK31zx8QoO56a6DrIxF4w2gDn5gHecfZ+rJ0Hi8ngnlHrdaObAud/1x6Fdf4xxD68DDKqN1dtwUHHM9FabDua6xP7+yI+/bnJjnTpduIqvx9mqjIrAagnwXmp45yKFViWVxRmC/BduuVJS9OG/WOPWpRn62dUCBehP+O6q61XPCnNGs4C6nJ
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(76116006)(66446008)(91956017)(8676002)(83380400001)(71200400001)(38100700002)(66946007)(66556008)(36756003)(5660300002)(316002)(2616005)(107886003)(38070700005)(2906002)(26005)(186003)(86362001)(55236004)(53546011)(4326008)(8936002)(64756008)(31696002)(6506007)(6512007)(66476007)(6486002)(31686004)(508600001)(54906003)(6916009)(122000001)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?Yk0xM3p4WXNteTRWaFpUVGd6TEt1cmRlMVVKMWtCQ0lLSmZFUmRDRDQzYVpz?=
 =?utf-8?B?T3krVjVzaURyTWZTV0l3ck9uZ2dLQ0t0aU9lQ1k5blQzUk5LQXJKSm9YVWFE?=
 =?utf-8?B?ajEwL2NhV04vRGR0VjQzZXV4YmFHU3dJT3p2QTh4Wm5aZnByek81ejNQYVNJ?=
 =?utf-8?B?bm1YRExjQWNWWlR3RjZpRTRQNE5tREJPWjQ1ZVVvZjFyVDRhSndvTGlubER4?=
 =?utf-8?B?b3VKYlRJbkRDWEpPYWZGdDhhYUlrb01sMFNBaUZjbzFyZW1zTnB5V2pzWnNt?=
 =?utf-8?B?UzRPU01wTUo2bDFWUTVDalFaRDhOaURPOXdxTUYzMnVqTU5kS1Q5cmM4UzYr?=
 =?utf-8?B?alA5TlRyUGNpbEhzWFUrR1VrbkFRc2RIb1hZZDZQWkpBVWplT1B5RU1PZVl6?=
 =?utf-8?B?Wk01UjVTNTJ4V3lxSmE1dENEVzlLekE0SW5GalhrbWo4YUM5ajR0VXg4SlJO?=
 =?utf-8?B?b05RUmM3endHSi81MFNVbmZBVlNPaG4vNkhoMXNZRlY5dVNRY0lKS21zVUxo?=
 =?utf-8?B?bWZRVUVzRlZSSHJXNDdhR29WQ3V4M1o5Y1h6aTE1V0pJT3c4aVZ4aUlPZnEv?=
 =?utf-8?B?TUtORGU3b1pLOWFaOFhNNDZIVnhGYVNDYnB1SDdOM3lFem9MT0I2UGdFeXBw?=
 =?utf-8?B?ZmM1N3kvQ0p2MHF3NDVCUy93TlZybXdlSGthb3VDR2ZSVzYvVHI0VkR0dG5p?=
 =?utf-8?B?T1dURHlxSTBlbDRwb28rQkJQQjJuVXZBOWFodXBLVS90aGVnOUY0OFpraW1t?=
 =?utf-8?B?Z0Rlb1pZaHR2VnJGc0JoVWxWTExIdG1YMWIxYlBQQndYeWgzN3VwQmwyWm5U?=
 =?utf-8?B?VFdhOE9XaU9COW12MWZxWlV1djJlc3FTRFNKT3kwcitIelNFc2xvZlF2Uyt5?=
 =?utf-8?B?RnAwR0pzcjZwV1NhNk9NU3pXUlljWEdEc2Exbzd0bVE1ZzNiSDhFUk9lSFZB?=
 =?utf-8?B?K0I4SFpLYTFxL0xFMVF6WElsTlpUWk9QcURwOVVYNUFWRzNJRDI4clU2ZDRC?=
 =?utf-8?B?MG9Sd01mVGQ3dkZTelBBS0VNY3JWdlNxL3NuZmx2MXFHeUgzMWR2algrc0di?=
 =?utf-8?B?SENpSGdtanE2Y3pxZDhrYWI1V3RWUmRUN1JGaVE2RkErTTIxY2NPdjVkK2pa?=
 =?utf-8?B?UkhaVVhEcFN3UmdmRU5ZK3d2MDFteEVmUjFMSWtJcjFHYWVDc2VtUXBORlhI?=
 =?utf-8?B?MUw1dVVjcGdTMjJGaXA3UHhrOTBraGlYUnRmcXpJODhMU1k2MWZaOWU1QUtX?=
 =?utf-8?B?R3poSW9MTGp5d2QwcVdsSjVTbFRmYkxiRTErZ2lZZ3ZmK3p0RkJDVkdLRk0x?=
 =?utf-8?B?VVhXb2dsR3BxTHc5Qnp1Nm5oaFRPQnVucENGUmc1NVpCYlFTNXhubzhRREhp?=
 =?utf-8?B?aEVaWmhYUW55Rmpma2xkQ0ZOUDB1ZFd1dFVsQTBqY0VRL1hkenNYRUl2bVIz?=
 =?utf-8?B?WVR3b2YxMXQ3UndSelF2YjVyT2o1eURjTStKdzVsOGl0aUVSUXJRUks0NCtI?=
 =?utf-8?B?Vmk2aDU3eFJ5dW9uTlczTjBpSldiRFlUczlaV0tsUzVWR3BiTzROcFlpR1JU?=
 =?utf-8?B?Mk0yNVVnNlROZ0lreldYN1RvREk4bmNsMGVYZWxRdWJ6L0ZRZFg3UlUyNWlN?=
 =?utf-8?B?MVcvWHArTy9mMkhTMGhEOTRxR1NTbmEzcC9KamJ0Q3FMVlY4M2JBY2NzNDFi?=
 =?utf-8?B?b0FNZ3J6a3ZRQnJLVFZXUG5JMGxnWmR4RW5nUXd0U3YzdWdEdVhJczJ2andr?=
 =?utf-8?B?M0gxQ1JMWFhUY2V3c0ZwQkgrWnFFNCsrajNzS1pnSE50L1ZpdVBXZGRYaXVz?=
 =?utf-8?B?MHFWRXRlQmErMEQ5OEpFQkd1clFLY25yS2w0aDA1Y01uTHE2U0NFVnJDL29B?=
 =?utf-8?B?OUczMWlSQkJHYWVYTDAzTXBqaklKVDhaRklKMXZKOVlvcXpXM3JrRFB3Uy8w?=
 =?utf-8?B?WTNQcktxU09vTkR5V3FMcXozWVZERCtmb1JlNEpia3l0K1BSSFdoSzl3b0JG?=
 =?utf-8?B?K3VQTG12aHA0bERxUUlmSEpmeE1peTFuMk9qUEtCRFRBS2ozOGRzUTVzMWY3?=
 =?utf-8?B?ZnBwMEkxRkI4WVN4MEtObyt6Uzdjd2ZJN1RtYkhKVE5IMjY3TGFXQ3h1N1ZM?=
 =?utf-8?B?bzhyaFVmMm5TMnd3b3ptaURLN3JoUC96M3RWK0FBc0ZhSU9CUDEyOXNZR2Jj?=
 =?utf-8?B?a2VoTmlUNStNWlBraENTWUJ2bXhML1lsaEtYY3NDU1JIc3craXdmRjA1dUhH?=
 =?utf-8?B?UFFWblA0OG93cEFEckFpSlJ4NnNqUWJxNmdYdTh5cFRmMFZlL0NDaDEzUGhL?=
 =?utf-8?B?Njd0aTJLR1VSeGxyVmhoZ1dOWEowbnU0amFhWDBoZUdsMktNaFhLUT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <F958D472CD8D8848B694FF99B1326F56@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2c245e28-f36f-4bd3-645d-08d9efab4e29
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Feb 2022 11:15:27.8011
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ozsD2QxKzeKltrVz2GF9gqLelEbcE20JMuZQQcnhR7ray6ekzplGIf6DvK0mgH/FhRVdx3X1UqJJdfKgkewO1yJLIj+uQaxJJ3IiQycf6zB/JVb+rjZmZnuuQZnBrk0g
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR03MB7712
X-Proofpoint-ORIG-GUID: -vPnl3bXiATb0CjXpalXZLeo41THlwwo
X-Proofpoint-GUID: -vPnl3bXiATb0CjXpalXZLeo41THlwwo
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-14_03,2022-02-14_03,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0
 adultscore=0 priorityscore=1501 mlxscore=0 spamscore=0 mlxlogscore=999
 malwarescore=0 bulkscore=0 suspectscore=0 phishscore=0 impostorscore=0
 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202140069

DQoNCk9uIDE0LjAyLjIyIDEzOjExLCBSb2dlciBQYXUgTW9ubsOpIHdyb3RlOg0KPiBPbiBNb24s
IEZlYiAxNCwgMjAyMiBhdCAxMDo1Mzo0M0FNICswMDAwLCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5r
byB3cm90ZToNCj4+DQo+PiBPbiAxNC4wMi4yMiAxMjozNCwgUm9nZXIgUGF1IE1vbm7DqSB3cm90
ZToNCj4+PiBPbiBNb24sIEZlYiAxNCwgMjAyMiBhdCAwOTozNjozOUFNICswMDAwLCBPbGVrc2Fu
ZHIgQW5kcnVzaGNoZW5rbyB3cm90ZToNCj4+Pj4gT24gMTEuMDIuMjIgMTM6NDAsIFJvZ2VyIFBh
dSBNb25uw6kgd3JvdGU6DQo+Pj4+PiArDQo+Pj4+Pj4+PiAgICAgICAgICBmb3IgKCBpID0gMDsg
aSA8IG1zaXgtPm1heF9lbnRyaWVzOyBpKysgKQ0KPj4+Pj4+Pj4gICAgICAgICAgew0KPj4+Pj4+
Pj4gICAgICAgICAgICAgIGNvbnN0IHN0cnVjdCB2cGNpX21zaXhfZW50cnkgKmVudHJ5ID0gJm1z
aXgtPmVudHJpZXNbaV07DQo+Pj4+Pj4+IFNpbmNlIHRoaXMgZnVuY3Rpb24gaXMgbm93IGNhbGxl
ZCB3aXRoIHRoZSBwZXItZG9tYWluIHJ3bG9jayByZWFkDQo+Pj4+Pj4+IGxvY2tlZCBpdCdzIGxp
a2VseSBub3QgYXBwcm9wcmlhdGUgdG8gY2FsbCBwcm9jZXNzX3BlbmRpbmdfc29mdGlycXMNCj4+
Pj4+Pj4gd2hpbGUgaG9sZGluZyBzdWNoIGxvY2sgKGNoZWNrIGJlbG93KS4NCj4+Pj4+PiBZb3Ug
YXJlIHJpZ2h0LCBhcyBpdCBpcyBwb3NzaWJsZSB0aGF0Og0KPj4+Pj4+DQo+Pj4+Pj4gcHJvY2Vz
c19wZW5kaW5nX3NvZnRpcnFzIC0+IHZwY2lfcHJvY2Vzc19wZW5kaW5nIC0+IHJlYWRfbG9jaw0K
Pj4+Pj4+DQo+Pj4+Pj4gRXZlbiBtb3JlLCB2cGNpX3Byb2Nlc3NfcGVuZGluZyBtYXkgYWxzbw0K
Pj4+Pj4+DQo+Pj4+Pj4gcmVhZF91bmxvY2sgLT4gdnBjaV9yZW1vdmVfZGV2aWNlIC0+IHdyaXRl
X2xvY2sNCj4+Pj4+Pg0KPj4+Pj4+IGluIGl0cyBlcnJvciBwYXRoLiBTbywgYW55IGludm9jYXRp
b24gb2YgcHJvY2Vzc19wZW5kaW5nX3NvZnRpcnFzDQo+Pj4+Pj4gbXVzdCBub3QgaG9sZCBkLT52
cGNpX3J3bG9jayBhdCBsZWFzdC4NCj4+Pj4+Pg0KPj4+Pj4+IEFuZCBhbHNvIHdlIG5lZWQgdG8g
Y2hlY2sgdGhhdCBwZGV2LT52cGNpIHdhcyBub3QgcmVtb3ZlZA0KPj4+Pj4+IGluIGJldHdlZW4g
b3IgKnJlLWNyZWF0ZWQqDQo+Pj4+Pj4+IFdlIHdpbGwgbGlrZWx5IG5lZWQgdG8gcmUtaXRlcmF0
ZSBvdmVyIHRoZSBsaXN0IG9mIHBkZXZzIGFzc2lnbmVkIHRvDQo+Pj4+Pj4+IHRoZSBkb21haW4g
YW5kIGFzc2VydCB0aGF0IHRoZSBwZGV2IGlzIHN0aWxsIGFzc2lnbmVkIHRvIHRoZSBzYW1lDQo+
Pj4+Pj4+IGRvbWFpbi4NCj4+Pj4+PiBTbywgZG8geW91IG1lYW4gYSBwYXR0ZXJuIGxpa2UgdGhl
IGJlbG93IHNob3VsZCBiZSB1c2VkIGF0IGFsbA0KPj4+Pj4+IHBsYWNlcyB3aGVyZSB3ZSBuZWVk
IHRvIGNhbGwgcHJvY2Vzc19wZW5kaW5nX3NvZnRpcnFzPw0KPj4+Pj4+DQo+Pj4+Pj4gcmVhZF91
bmxvY2sNCj4+Pj4+PiBwcm9jZXNzX3BlbmRpbmdfc29mdGlycXMNCj4+Pj4+PiByZWFkX2xvY2sN
Cj4+Pj4+PiBwZGV2ID0gcGNpX2dldF9wZGV2X2J5X2RvbWFpbihkLCBzYmRmLnNlZywgc2JkZi5i
dXMsIHNiZGYuZGV2Zm4pOw0KPj4+Pj4+IGlmICggcGRldiAmJiBwZGV2LT52cGNpICYmIGlzX3Ro
ZV9zYW1lX3ZwY2kocGRldi0+dnBjaSkgKQ0KPj4+Pj4+IDxjb250aW51ZSBwcm9jZXNzaW5nPg0K
Pj4+Pj4gU29tZXRoaW5nIGFsb25nIHRob3NlIGxpbmVzLiBZb3UgbGlrZWx5IG5lZWQgdG8gY29u
dGludWUgaXRlcmF0ZSB1c2luZw0KPj4+Pj4gZm9yX2VhY2hfcGRldi4NCj4+Pj4gSG93IGRvIHdl
IHRlbGwgaWYgcGRldi0+dnBjaSBpcyB0aGUgc2FtZT8gSmFuIGhhcyBhbHJlYWR5IGJyb3VnaHQN
Cj4+Pj4gdGhpcyBxdWVzdGlvbiBiZWZvcmUgWzFdIGFuZCBJIHdhcyBhYm91dCB0byB1c2Ugc29t
ZSBJRCBmb3IgdGhhdCBwdXJwb3NlOg0KPj4+PiBwZGV2LT52cGNpLT5pZCA9IGQtPnZwY2lfaWQr
KyBhbmQgdGhlbiB3ZSB1c2UgcGRldi0+dnBjaS0+aWTCoCBmb3IgY2hlY2tzDQo+Pj4gR2l2ZW4g
dGhpcyBpcyBhIGRlYnVnIG1lc3NhZ2UgSSB3b3VsZCBiZSBPSyB3aXRoIGp1c3QgZG9pbmcgdGhl
DQo+Pj4gbWluaW1hbCBjaGVja3MgdG8gcHJldmVudCBYZW4gZnJvbSBjcmFzaGluZyAoaWU6IHBk
ZXYtPnZwY2kgZXhpc3RzKQ0KPj4+IGFuZCB0aGF0IHRoZSByZXN1bWUgTVNJIGVudHJ5IGlzIG5v
dCBwYXN0IHRoZSBjdXJyZW50IGxpbWl0LiBPdGhlcndpc2UNCj4+PiBqdXN0IHByaW50IGEgbWVz
c2FnZSBhbmQgbW92ZSBvbiB0byB0aGUgbmV4dCBkZXZpY2UuDQo+PiBBZ3JlZSwgSSBzZWUgbm8g
YmlnIGlzc3VlIChwcm9iYWJseSkgaWYgd2UgYXJlIG5vdCBhYmxlIHRvIHByaW50DQo+Pg0KPj4g
SG93IGFib3V0IHRoaXMgb25lOg0KPj4NCj4+IGRpZmYgLS1naXQgYS94ZW4vZHJpdmVycy92cGNp
L2hlYWRlci5jIGIveGVuL2RyaXZlcnMvdnBjaS9oZWFkZXIuYw0KPj4gaW5kZXggODA5YTZiNDc3
M2UxLi41MDM3M2YwNGRhODIgMTAwNjQ0DQo+PiAtLS0gYS94ZW4vZHJpdmVycy92cGNpL2hlYWRl
ci5jDQo+PiArKysgYi94ZW4vZHJpdmVycy92cGNpL2hlYWRlci5jDQo+PiBAQCAtMTcxLDEwICsx
NzEsMzEgQEAgc3RhdGljIGludCBfX2luaXQgYXBwbHlfbWFwKHN0cnVjdCBkb21haW4gKmQsIGNv
bnN0IHN0cnVjdCBwY2lfZGV2ICpwZGV2LA0KPj4gICDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBzdHJ1Y3QgcmFuZ2VzZXQgKm1lbSwgdWlu
dDE2X3QgY21kKQ0KPj4gICDCoHsNCj4+ICAgwqDCoMKgwqAgc3RydWN0IG1hcF9kYXRhIGRhdGEg
PSB7IC5kID0gZCwgLm1hcCA9IHRydWUgfTsNCj4+ICvCoMKgwqAgcGNpX3NiZGZfdCBzYmRmID0g
cGRldi0+c2JkZjsNCj4+ICAgwqDCoMKgwqAgaW50IHJjOw0KPj4NCj4+ICsgQVNTRVJUKHJ3X2lz
X3dyaXRlX2xvY2tlZCgmcGRldi0+ZG9tYWluLT52cGNpX3J3bG9jaykpOw0KPj4gKw0KPj4gICDC
oMKgwqDCoCB3aGlsZSAoIChyYyA9IHJhbmdlc2V0X2NvbnN1bWVfcmFuZ2VzKG1lbSwgbWFwX3Jh
bmdlLCAmZGF0YSkpID09IC1FUkVTVEFSVCApDQo+PiArwqDCoMKgIHsNCj4+ICsNCj4+ICvCoMKg
wqDCoMKgwqDCoCAvKg0KPj4gK8KgwqDCoMKgwqDCoMKgwqAgKiBwcm9jZXNzX3BlbmRpbmdfc29m
dGlycXMgbWF5IHRyaWdnZXIgdnBjaV9wcm9jZXNzX3BlbmRpbmcgd2hpY2gNCj4+ICvCoMKgwqDC
oMKgwqDCoMKgICogbWF5IG5lZWQgdG8gYWNxdWlyZSBwZGV2LT5kb21haW4tPnZwY2lfcndsb2Nr
IGluIHJlYWQgbW9kZS4NCj4+ICvCoMKgwqDCoMKgwqDCoMKgICovDQo+PiArwqDCoMKgwqDCoMKg
wqAgd3JpdGVfdW5sb2NrKCZwZGV2LT5kb21haW4tPnZwY2lfcndsb2NrKTsNCj4+ICAgwqDCoMKg
wqDCoMKgwqDCoCBwcm9jZXNzX3BlbmRpbmdfc29mdGlycXMoKTsNCj4+ICvCoMKgwqDCoMKgwqDC
oCB3cml0ZV9sb2NrKCZwZGV2LT5kb21haW4tPnZwY2lfcndsb2NrKTsNCj4+ICsNCj4+ICvCoMKg
wqDCoMKgwqDCoCAvKiBDaGVjayBpZiBwZGV2IHN0aWxsIGV4aXN0cyBhbmQgdlBDSSB3YXMgbm90
IHJlbW92ZWQgb3IgcmUtY3JlYXRlZC4gKi8NCj4+ICvCoMKgwqDCoMKgwqDCoCBpZiAocGNpX2dl
dF9wZGV2X2J5X2RvbWFpbihkLCBzYmRmLnNlZywgc2JkZi5idXMsIHNiZGYuZGV2Zm4pICE9IHBk
ZXYpDQo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBpZiAoIHZwY2kgaXMgTk9UIHRoZSBzYW1l
ICkNCj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHsNCj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqAgcmMgPSAwOw0KPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBi
cmVhazsNCj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIH0NCj4+ICvCoMKgwqAgfQ0KPj4gKw0K
Pj4gICDCoMKgwqDCoCByYW5nZXNldF9kZXN0cm95KG1lbSk7DQo+PiAgIMKgwqDCoMKgIGlmICgg
IXJjICkNCj4+ICAgwqDCoMKgwqDCoMKgwqDCoCBtb2RpZnlfZGVjb2RpbmcocGRldiwgY21kLCBm
YWxzZSk7DQo+Pg0KPj4gVGhpcyBvbmUgYWxzbyB3YW50cyBwcm9jZXNzX3BlbmRpbmdfc29mdGly
cXMgdG8gcnVuIHNvIGl0ICptaWdodCoNCj4+IHdhbnQgcGRldiBhbmQgdnBjaSBjaGVja3MuIEJ1
dCBhdCB0aGUgc2FtZSB0aW1lIGFwcGx5X21hcCBydW5zDQo+PiBhdCAoIHN5c3RlbV9zdGF0ZSA8
IFNZU19TVEFURV9hY3RpdmUgKSwgc28gZGVmZXJfbWFwIHdvbid0IGJlDQo+PiBydW5uaW5nIHll
dCwgdGh1cyBubyB2cGNpX3Byb2Nlc3NfcGVuZGluZyBpcyBwb3NzaWJsZSB5ZXQgKGluIHRlcm1z
DQo+PiBpdCBoYXMgc29tZXRoaW5nIHRvIGRvIHlldCkuIFNvLCBJIHRoaW5rIHdlIGp1c3QgbmVl
ZDoNCj4+DQo+PiAgIMKgwqDCoMKgwqDCoMKgIHdyaXRlX3VubG9jaygmcGRldi0+ZG9tYWluLT52
cGNpX3J3bG9jayk7DQo+PiAgIMKgwqDCoMKgwqDCoMKgIHByb2Nlc3NfcGVuZGluZ19zb2Z0aXJx
cygpOw0KPj4gICDCoMKgwqDCoMKgwqDCoCB3cml0ZV9sb2NrKCZwZGV2LT5kb21haW4tPnZwY2lf
cndsb2NrKTsNCj4+DQo+PiBhbmQgdGhpcyBzaG91bGQgYmUgZW5vdWdoDQo+IEdpdmVuIHRoZSBj
b250ZXh0IGFwcGx5X21hcCBpcyBjYWxsZWQgZnJvbSAoZG9tMCBzcGVjaWZpYyBpbml0IGNvZGUp
LA0KPiB0aGVyZSdzIG5vIG5lZWQgdG8gY2hlY2sgZm9yIHRoZSBwZGV2IHRvIHN0aWxsIGV4aXRz
LCBvciB3aGV0aGVyIHZwY2kNCj4gaGFzIGJlZW4gcmVjcmVhdGVkLCBhcyBpdCdzIG5vdCBwb3Nz
aWJsZS4gSnVzdCBhZGQgYSBjb21tZW50IHRvDQo+IGV4cGxpY2l0bHkgbm90ZSB0aGF0IHRoZSBj
b250ZXh0IG9mIHRoZSBmdW5jdGlvbiBpcyBzcGVjaWFsLCBhbmQgdGh1cw0KPiB0aGVyZSdzIG5v
IHBvc3NpYmlsaXR5IG9mIGVpdGhlciB0aGUgZGV2aWNlIG9yIHZwY2kgZ29pbmcgYXdheS4NCkRv
ZXMgaXQgcmVhbGx5IG5lZWQgd3JpdGVfdW5sb2NrL3dyaXRlX2xvY2sgZ2l2ZW4gdGhlIGNvbnRl
eHQ/Li4uDQpJIHRoaW5rIGl0IGRvZXNuJ3QgYXMgdGhlcmUgaXMgbm8gY2hhbmNlIGRlZmVyX21h
cCBpcyBjYWxsZWQsIHRodXMNCnByb2Nlc3NfcGVuZGluZ19zb2Z0aXJxcyAtPiB2cGNpX3Byb2Nl
c3NfcGVuZGluZyAtPiByZWFkX2xvY2sNCmlzIG5vdCBwb3NzaWJsZQ0KSSdsbCBqdXN0IGFkZCBh
IGNvbW1lbnQgYWJvdXQgdGhhdA0KPiBUaGFua3MsIFJvZ2VyLg0KVGhhbmsgeW91LA0KT2xla3Nh
bmRy


From xen-devel-bounces@lists.xenproject.org Mon Feb 14 11:26:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 11:26:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271447.465884 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJZUQ-0000Zm-2M; Mon, 14 Feb 2022 11:25:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271447.465884; Mon, 14 Feb 2022 11:25:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJZUP-0000Zf-VZ; Mon, 14 Feb 2022 11:25:53 +0000
Received: by outflank-mailman (input) for mailman id 271447;
 Mon, 14 Feb 2022 11:25:52 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=jzps=S5=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nJZUO-0000ZZ-61
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 11:25:52 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id dba4670c-8d88-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 12:25:49 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dba4670c-8d88-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644837949;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=x2ACjNyR/Yyor8CYIBA+dwgi1Pv4XrWPNo6hi4My4jQ=;
  b=XBNXOt1X0U3bOdUaZi2XYdAV3tOAVXDK7SViZ0MWfjCxQV463epmx4jA
   uXwpR+OWAVgBFXPI3lKWzqAu/zNFqVWVpvWkVvTX00j6jLTZcnKV58Ffa
   NkyY5NWHZeY0P4QCMaMG6EdTgiQ/m5Qd9HRWJOo/ui4DDRJYvcNOXd3Jo
   w=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: ojCVVkJR/IOdNp5aqHlLdkK2v3oVTT7gfpHFNW4z++Rh0oYJsIKyCnAUNKNxVwDRjLGm7nIl3e
 meptWAyG7lT7C/m7qLy1Lr+dQICU60i/4RaJZ5YP0PGu/cKAzUdUFzrfxlHh8ayWgjFLOXNkhr
 uyo7mvUOkdBm3a40ebcZPX+5YzJwN6HRaJdDViHeU12HF+tOAPbNDeLr/SRfrDSce+ChE01dJJ
 W3XyAx2e7eWjF9YS2Uxf+mCCOi0dN5w/6A+SxUNGrKWpz/nItACS7uzZHbLrawLzxcX+RGFhRM
 wvt4gtjTzRp+0kgxF9hf6YC9
X-SBRS: 5.1
X-MesageID: 64044387
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:u3wS2K1nBFbJiF+LTfbD5d13kn2cJEfYwER7XKvMYLTBsI5bpz0By
 WEXXzyDa6qJa2ujLtB1ad6y9ENTvpCByoRjHgdlpC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkS5PE3oHJ9RGQ74nRLlbHILOCanAZqTNMEn9700o5wrJh2+aEvPDia++zk
 YKqyyHgEAfNNw5cagr4PIra9XuDFNyr0N8plgRWicJj5TcypFFMZH4rHomjLmOQf2VhNrXSq
 9Avbl2O1jixEx8FUrtJm1tgG6EAaua60QOm0hK6V0U+6/TrS+NbPqsTbZIhhUlrZzqhxt5O8
 c0VjJeKYjgxGo7v39Q0bil6OnQrVUFG0OevzXmXtMWSywvNcmf2wuUoB0YzVWEa0r8pWycUr
 6VecW1TKEDY7w616OvTpu1EnMMsIdOtJIoCknph0SvYHbAtRpWrr6Diu4MAgGtr1p8m8fD2X
 Ps4VAhLc1f7UhxxZgpIBZgiu8imiSyqG9FfgA3M/vdmi4TJ9yRP17zqPMvQa8a9b8xflUaFp
 UrL5238RBodMbS37j6I8WmlgOPVqh/qQ4IZFLC+9flCjUWawyoYDxh+fXKhvfS8vWuvVNteJ
 lI89zInqO4580nDZsP0XwC85mWFuBEcc9NKFqsx7wTl4qDZ+RqDD24ICDtIcsU7tdQeTCYvk
 FSOmrvBFTFp9bGYV3+Z3rOVti+pfzgYK3cYYi0JRhdD5MPsyKkUih/MVd9lHLSCp9v5Ayzrw
 zuKoS49gJ0elccOka68+DjvgTihu5zIRQ4d/RjMUySu6QYRTJW+e4Wi5Fzf7PBBBIWUVF+Mu
 D4Dgcf2xOITCZCAkgSdTeNLG6umj8tpKxWF3wQpRcN4sW3wpTjzJui8/Q2SOm8wPPk9YWfQa
 3X4hht1x7wUDFKXXY1eNtfZ59sR8YDsEtHsV/bxZ9VIY4RseALvwByCdXJ8zEi2zhFyzPhX1
 YOzNJ/1UC1EUfgPIC+eGr9FuYLH0BzS0o86qXrT6x28mYSTa3eOIVvuGAvfN7tphE9oTei8z
 jq+Cydo40gFOAEdSnOOmWL2EbztBSJlba0aU+QNKoa+zvNOQQnN8cP5z7I7YJBClK9IjOrO9
 XzVchYGlAag1S2adF3TMSoLhFbTsXFX9yxTAMDRFQzwhyhLjXiHsM/ziKfbjZF4rbc+nJaYv
 tEOetmaA+Qnd9g00291UHUJl6Q7LE7DrVvXZ0KNOWFjF7Y9F12h0oK1JWPHqXhRZhdbQONj+
 tVMICuAGsFdL+mjZe6LAM+SI6SZ4yRDxrIoAhegzxs6UByEzbWG4hfZ15cfC8oNNQ/C1n2d0
 QOXCg0fvu7Dv8k+99yhuExOh9jB/zJWEhUIEm/Fw6yxMCWGrGOvzZUZCLSDfCzHVXOy86KnP
 L0Hw/b5OfwBvVBLr4sjTOo7kfNgv4Pi9+1A0wBpPHTXdFD3WLluFWaLgJtUvapXy74H5QbvA
 hCT+sNXMKmiMd/+FAJDPxIsa+mOjKlGmjTb4fkvDl/94St7oOiOXUlIZkHegy1BNrpldogix
 L556sIR7gW+jDssM8qH0X8IpzjdcCRYXvx+5J8AAYLthg468X14YMTRWn3s/ZWCS9RQKU12c
 DWas7XP2uZHzU3YfnttSXWUhbhBhY4DsQxhxUMZIwjbgcLMg/I60UED8TkzSQgJnBxL3/gqZ
 zpuPkxxY66P4y1plI5IWGX1Q1NNAxiQ+0rQzVoVlTKGExn0BzKVdGBta/yQ+E058n5HemkJ9
 b6V/2/pTDL2cZyjxSA1Q0Nk96TuQNEZGtcuQyx78xBpx6UHXAc=
IronPort-HdrOrdr: A9a23:ScNwTavuzrDShlXaTKITW6O47skC7oMji2hC6mlwRA09TyXGra
 +TdaUguSMc1gx9ZJhBo7G90KnpewK6yXdQ2/hqAV7EZniahILIFvAY0WKG+VPd8kLFh4xgPM
 tbAs1D4ZjLfCRHZKXBkXiF+rQbsaC6GcmT7I+0pRcdLj2CKZsQlzuRYjzrbHGeLzM2Y6bReq
 Dsgvau8FGbCAsqh4mAdzI4dtmGg+eOuIPtYBYACRJiwA6SjQmw4Lq/NxSDxB8RXx5G3L9nqA
 H+4kHEz5Tml8v+5g7X1mfV4ZgTsNz9yuFbDMjJrsQOMD3jhiuheYwkcbyfuzIepv2p9T8R4Z
 PxiiZlG/42x2Laf2mzrxeo8w780Aw243un8lOciWuLm72OeBsKT+56wa5JeBrQ7EQt+Ptm1r
 hQ4m6fv51LSTvdgSXU/bHzJl9Xv3vxhUBnvf8YjnRZX4dbQqRWt5Yj8ERcF4pFND7m6bogDP
 JlAKjnlblrmGuhHjDkV1RUsZ+RtixZJGbFfqFCgL3Y79FupgE586NCr/Zv20vp9/oGOu55Dq
 r/Q+BVfYp1P7wrhJRGdZM8qPuMexzwqC33QRCvyHTcZeg60iH22tbKCItc3pDeRHVP9up0pK
 j8
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="64044387"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=MQCGWPP0gQSIuWDQd/gdQ6//HORooSHho+NGArm0bP1gzl51dw14Dpv3I6rMAzhE6C0HsNhSrSvJCU5Alts5a2pXZgIp9W8gNlGlLPWSNgRyt6ZqJTCThG48HtOdjy3TQpaerbCI38DDKulLmkvStlvTrgLqhsInUkj8pVwlpUTHsFfDh2fLIJDeDzqLlARQcf0p9P1U1ug7JsvxUWnt1hZ7rb0QQU8n2Sp8w9hGpSo04PkICcDLW0FxYgjPCLhf5UI0ESg8MQpCUCLIxaRr5sSICbkXxueaCqrgN9WcgNZtMH6ybUo4x/68BI6u2CK8zH1g8P5YQf7lis//+bVLsA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=kGS02Bj8gu4kyj6h4LbulHz3XtLOXZDVhRTZrzGK7yU=;
 b=KLzlGP6HpUPJ1KIm68W7+Rq4sUyOXZgmEweOVtqy17kIY0VB60yhVVg0b1rQcq2NfYv75Q13yqeGG992UEOnhzcTV/9qL0ZNfZig5fbuCAl7InWA7eXt0MwT+fhezhXzNWUDrQFBrNo186vXnggRdvrtKQoaewvGxh0FsXdctG/nBuob04Vh+cYr6icjnYY1CWBbI6t2j7cWqt7kY+nSAabDhuuQnViv+xDhlem7jHLMpk2rZcqbLsjtFKRQ7pVeiCJd051csO6PwKykHq/3ft/iquAvvH5usgC8P38ZsVF0fDGF01Gm9mgTCb4D+jNq9yHmTjgzakJpHv/5w5G0ug==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=kGS02Bj8gu4kyj6h4LbulHz3XtLOXZDVhRTZrzGK7yU=;
 b=OY6GTYedDsBme7aLhrVoxJU5oApFVXvr7khBolAgvEWZrwKR2vg6pGEdKlZg1KDGPVapUr6Rffx4smKI4YBc3yvVuGtm0rfRTBsae3ZllEPLhEx4/TSwoDsfBlJrCvFTmtwRXpMAHDKxmlp0Q7CcEScSITC/Ov3O0r/1HWyGQpc=
Date: Mon, 14 Feb 2022 12:25:39 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"jbeulich@suse.com" <jbeulich@suse.com>, "julien@xen.org" <julien@xen.org>,
	"sstabellini@kernel.org" <sstabellini@kernel.org>, Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Artem Mygaiev <Artem_Mygaiev@epam.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>, Rahul Singh
	<rahul.singh@arm.com>
Subject: Re: [PATCH] vpci: introduce per-domain lock to protect vpci structure
Message-ID: <Ygo8M3Y6BLzljn15@Air-de-Roger>
References: <20220209133627.959649-1-andr2000@gmail.com>
 <YgU6Snk8GTytJXZp@Air-de-Roger>
 <c4666570-666e-6680-5ec2-adf1da51ad06@epam.com>
 <YgZLEMW9US9QjjYG@Air-de-Roger>
 <33fb1095-64ed-29ef-ba6b-cbde21d941f8@epam.com>
 <YgowIg5MvTaf2zsR@Air-de-Roger>
 <d8389a90-00c8-b34a-8488-b0f3fc5bde1b@epam.com>
 <Ygo40L4dMPJjZKRF@Air-de-Roger>
 <746860aa-c403-1eca-0a75-587c5d10c8c2@epam.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <746860aa-c403-1eca-0a75-587c5d10c8c2@epam.com>
X-ClientProxiedBy: LO4P123CA0068.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:153::19) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ced6a369-6258-4d9f-8ebb-08d9efacbd5e
X-MS-TrafficTypeDiagnostic: CO1PR03MB5905:EE_
X-Microsoft-Antispam-PRVS: <CO1PR03MB590544E5EB849496B273F2FF8F339@CO1PR03MB5905.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: fZQopwKNfHzn25LvhU3rMcCKTtWHrQome1xVtR2Y7Uf5mcj/61ZrWCYvGTso0W0Wf5sEIFpvJwJHyCKB9WFrXHyOgaTvHn17kiGqMwJQqPb78gjkccu17Iw/ZQjnGQr6NVwoXnLoP6tK2TcdGLiSjeLGa9skzTUQH6dYnQ3lPg3tLRM5DSZ94ayHP/MKnfdrXMCEYQeNXEaH7St8pkxBmL2vGjE6tEXnDveXKCuocJUvV5I/QNWOT48rem9Wrm+EosJ4XtflBRhYXrC5DZ7HiB6bYniPsmTqls4c40t5dgCMUi/2teEFxBxoFuVAzlkjxg9jfRJIRswrKsYT41hghSdnYEtcyiEh3Jf5COYynSSx3Z4E+W+LRAe5xWijT0tPE6q1hQ/6uQ42jihsQU/8TbEfNtjX/1MGWePtuVQ/X6+YqVuA+H44JjxjdUFccseqCYpJlTAHDccM1+43aWC1W+TpeFLU+K+P9y+dgdiWEzgFnA171axW7Y/A4GhS+3HnbLQOL8Mz01B6Um67k/WE5LBChEbwZx78lNpdu/rWiUkpPDc9evDABRzlArUlG6HPKOVP/uPv3Iamzp5PG8Ddg7pTNw3O1GPS1ZgQNzf9JkSRoaTqYgJpYgo7Er8uT6OHR5thcGFpoI5TfkZS5YXHRA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(86362001)(82960400001)(38100700002)(54906003)(6916009)(316002)(4326008)(8676002)(8936002)(6486002)(66946007)(66556008)(66476007)(7416002)(2906002)(5660300002)(83380400001)(33716001)(9686003)(85182001)(6512007)(6666004)(26005)(186003)(6506007)(53546011)(508600001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZlFDWDJHZHRRZ2w2dmtmVTUvQzhadG5LRzdvVGszZmxNNWZmUGNFTjRrd1pa?=
 =?utf-8?B?eHVZcCtzV1dxL2ZIMEtnYmRZVU5Sb0IzdWlXNWdpQktkNDZWSE4vVGhEU1ZB?=
 =?utf-8?B?QkVtcHpqcUI4akVkWmN6UHZwQVI3VzNKSHkzQy9jamZWVUZmVmdFRS9xSGhM?=
 =?utf-8?B?OHErWms2V012ZE9NYk0wbUI4ZkJEWC9pTHNsR1V2Q1l0S2JXR0tDZXZxcmQx?=
 =?utf-8?B?RHhXYjdBeThINjh4eHA3UWZjNVZUTnFVcXRja2hFR2hDd21Pa3R3NS9PTk5i?=
 =?utf-8?B?WitiaWN1RG91RmdJQjFneHFuVUZ0QXl2amlvYXRUZ1BOUDZqYk1KWTdRcXZt?=
 =?utf-8?B?b2lENzBQRmw1ZTBIZ0FJbXV6dkdINEVqT2ZnK0pLNFJCeHN2d2N4amxabi8y?=
 =?utf-8?B?N1JsSEJqWFdpM0U0N1U5WXlvMWFEbkZxVkU4SFFTeUVZV0t2MEJHZkJNZ053?=
 =?utf-8?B?b1pZYzZ3ZkxrdzhxQUNMa2xUT3NsMGU5LzVMbG1UU3k5SzNmU2JZNklKWEEr?=
 =?utf-8?B?dit1ZzZWYVBFczVtZEtQSFZvTEtxYXlML05HZXhVNzMvcVFFZnR0c3Irc3Jq?=
 =?utf-8?B?WXNwYm5YTkx3KzJiNEZNN0F0Znh1cjBacllTVGRDcUVObVdPMm5WbTNucXlT?=
 =?utf-8?B?N0dVZVl1elpUQVJZc20zYVVBLzIyMC9kaEIyYnNLNjRDY05BZjJ5TDc1VG9D?=
 =?utf-8?B?bzRCV3d0Nytidm93RENvUk16bUxYK0pXQlgxSWdhanFRWmtZRTdOcFl4Z1Ns?=
 =?utf-8?B?RlIraUduaFc1ckw2OTN6bVh6UnB3UzlzTEVwWGdITFpOTFlEdHFXcE10SDIw?=
 =?utf-8?B?ak1TZkhhOUoyNHVXZko2cGRFREpmVmUyZlN2cysxclJDRytFRnlGMlFEQ0hR?=
 =?utf-8?B?Tll3WHo1Y0RINEdCcUNNNHByR3dOYTkza0hqdXdUcHpZRWtxZjA5cVAzakl1?=
 =?utf-8?B?RVRBSngvSnloT0hGR0VUT2xRZ0g1MTNmWGNwOG5OMTJESDIvQ0YrRzdZbDls?=
 =?utf-8?B?VlNTMVhLTjJ0SHhOdmFJYzV3UmU3NnhKSGdIYnhZSCtvZzdCTnpib3REWlJM?=
 =?utf-8?B?cjAxUGxOMHl1MEhnZmNZU2VlUmJlT05nUmI3SmVmSjNSdThIR0hWU2o0MDZx?=
 =?utf-8?B?UjVCS2tTNDZLK1JJc3UyclZMNjRZOFc4OUp3a3NTNHI5UmU1RlRVMlhZNTkw?=
 =?utf-8?B?RVN2ckp4bC83bTV4NHJONW5QS09ubXQyTlBqMEZFSFNtWVpEMFdlVTZaN1g2?=
 =?utf-8?B?MzJZY254SEFsWGpkdUI1NWR3NDVaLzhicXlHV25tY3p1cTRteVdURmxpSFho?=
 =?utf-8?B?cm9DQkVFbjRaLzI1NFRkRDh2bVpCMGZjdDNjNHFQS2pQdTh6Nlp2NTRZTWhh?=
 =?utf-8?B?OThnTkR1WS8yOURWWDArSmQwdUpFdHVMWWE2cHJPeG1Hbk5KbWxGNUpaQktY?=
 =?utf-8?B?dmhFZ0ZpclJQRk9HZlVNbGhMQVYvc2Z6N1hLbU1wc1libGRRU1UxZFNPTUVN?=
 =?utf-8?B?QTNENGxsaE9NRlJHTjRBdWhwYW9tMjcvRzZBSVZhNUs0RFFLbjNqc29maDI2?=
 =?utf-8?B?cUtpMUF1aTdqQUNpM3JqdVFqS0pNbjl5UWUwazZmQXdOaEFPMmRzQVAwQjZP?=
 =?utf-8?B?ZS83U05seUw0cjVGR2lWVFU2SDhOTVIzRTFZcjNOSnZYd0c2MkFKVTVQU3dF?=
 =?utf-8?B?U3k0eTBnQUwzNXJycGM3VEZhdTF2RWp4MndSeW8wUzNyQTUvM3NHcVFTSTZJ?=
 =?utf-8?B?dnNkYVFwMlUxTUV0b0dSbDJkdm8wQXg4QTZCMjBEd2lXY2lmMkdhckNiL284?=
 =?utf-8?B?SmQ5eDdYdU1PcGpUK0NwbmdkSVAwVWRocjZUVG5BSis0eXh2SmRvWHJiMTJE?=
 =?utf-8?B?T0tMeUZRcDU1TjB3MGlMT2Fic1llUVR2aFdqcTU1NW9BekY5L2x2RGZ2MWlI?=
 =?utf-8?B?d1QxNlFiaWdxYzZiZkNBRnE3bkFjY0dJQXEzTjNUOENTbE1NaE5LRWlieEFD?=
 =?utf-8?B?OG4zeVRqekVRV290YzZlMkVLOTMxNEpnMngwVm9wWFJ1b2MyNG0xNTNKQ3BS?=
 =?utf-8?B?NTEzTElwMHljZDZucC8wVVNpcTYzdytqWm9pdEhCbUlGM1ltNXMyL3FocmFU?=
 =?utf-8?B?aUNBdTRrbXNJTVB3ekVjOFdJdU9MOHUzeWV0Y3IrdGFhWG8yUGxpSHFrYTU0?=
 =?utf-8?Q?HutJ+5UnjDa1W44beUyI4U8=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ced6a369-6258-4d9f-8ebb-08d9efacbd5e
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2022 11:25:44.1545
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IIdDXb+V4rPD8xuMLBfAkPRiRfV3jcb8Yvem55yZ1amxpAqx/MOVxFghV4l2oHeRkt8djoBIPkAsnc3qDycOEw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR03MB5905
X-OriginatorOrg: citrix.com

On Mon, Feb 14, 2022 at 11:15:27AM +0000, Oleksandr Andrushchenko wrote:
> 
> 
> On 14.02.22 13:11, Roger Pau Monné wrote:
> > On Mon, Feb 14, 2022 at 10:53:43AM +0000, Oleksandr Andrushchenko wrote:
> >>
> >> On 14.02.22 12:34, Roger Pau Monné wrote:
> >>> On Mon, Feb 14, 2022 at 09:36:39AM +0000, Oleksandr Andrushchenko wrote:
> >>>> On 11.02.22 13:40, Roger Pau Monné wrote:
> >>>>> +
> >>>>>>>>          for ( i = 0; i < msix->max_entries; i++ )
> >>>>>>>>          {
> >>>>>>>>              const struct vpci_msix_entry *entry = &msix->entries[i];
> >>>>>>> Since this function is now called with the per-domain rwlock read
> >>>>>>> locked it's likely not appropriate to call process_pending_softirqs
> >>>>>>> while holding such lock (check below).
> >>>>>> You are right, as it is possible that:
> >>>>>>
> >>>>>> process_pending_softirqs -> vpci_process_pending -> read_lock
> >>>>>>
> >>>>>> Even more, vpci_process_pending may also
> >>>>>>
> >>>>>> read_unlock -> vpci_remove_device -> write_lock
> >>>>>>
> >>>>>> in its error path. So, any invocation of process_pending_softirqs
> >>>>>> must not hold d->vpci_rwlock at least.
> >>>>>>
> >>>>>> And also we need to check that pdev->vpci was not removed
> >>>>>> in between or *re-created*
> >>>>>>> We will likely need to re-iterate over the list of pdevs assigned to
> >>>>>>> the domain and assert that the pdev is still assigned to the same
> >>>>>>> domain.
> >>>>>> So, do you mean a pattern like the below should be used at all
> >>>>>> places where we need to call process_pending_softirqs?
> >>>>>>
> >>>>>> read_unlock
> >>>>>> process_pending_softirqs
> >>>>>> read_lock
> >>>>>> pdev = pci_get_pdev_by_domain(d, sbdf.seg, sbdf.bus, sbdf.devfn);
> >>>>>> if ( pdev && pdev->vpci && is_the_same_vpci(pdev->vpci) )
> >>>>>> <continue processing>
> >>>>> Something along those lines. You likely need to continue iterate using
> >>>>> for_each_pdev.
> >>>> How do we tell if pdev->vpci is the same? Jan has already brought
> >>>> this question before [1] and I was about to use some ID for that purpose:
> >>>> pdev->vpci->id = d->vpci_id++ and then we use pdev->vpci->id  for checks
> >>> Given this is a debug message I would be OK with just doing the
> >>> minimal checks to prevent Xen from crashing (ie: pdev->vpci exists)
> >>> and that the resume MSI entry is not past the current limit. Otherwise
> >>> just print a message and move on to the next device.
> >> Agree, I see no big issue (probably) if we are not able to print
> >>
> >> How about this one:
> >>
> >> diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c
> >> index 809a6b4773e1..50373f04da82 100644
> >> --- a/xen/drivers/vpci/header.c
> >> +++ b/xen/drivers/vpci/header.c
> >> @@ -171,10 +171,31 @@ static int __init apply_map(struct domain *d, const struct pci_dev *pdev,
> >>                                struct rangeset *mem, uint16_t cmd)
> >>    {
> >>        struct map_data data = { .d = d, .map = true };
> >> +    pci_sbdf_t sbdf = pdev->sbdf;
> >>        int rc;
> >>
> >> + ASSERT(rw_is_write_locked(&pdev->domain->vpci_rwlock));
> >> +
> >>        while ( (rc = rangeset_consume_ranges(mem, map_range, &data)) == -ERESTART )
> >> +    {
> >> +
> >> +        /*
> >> +         * process_pending_softirqs may trigger vpci_process_pending which
> >> +         * may need to acquire pdev->domain->vpci_rwlock in read mode.
> >> +         */
> >> +        write_unlock(&pdev->domain->vpci_rwlock);
> >>            process_pending_softirqs();
> >> +        write_lock(&pdev->domain->vpci_rwlock);
> >> +
> >> +        /* Check if pdev still exists and vPCI was not removed or re-created. */
> >> +        if (pci_get_pdev_by_domain(d, sbdf.seg, sbdf.bus, sbdf.devfn) != pdev)
> >> +            if ( vpci is NOT the same )
> >> +            {
> >> +                rc = 0;
> >> +                break;
> >> +            }
> >> +    }
> >> +
> >>        rangeset_destroy(mem);
> >>        if ( !rc )
> >>            modify_decoding(pdev, cmd, false);
> >>
> >> This one also wants process_pending_softirqs to run so it *might*
> >> want pdev and vpci checks. But at the same time apply_map runs
> >> at ( system_state < SYS_STATE_active ), so defer_map won't be
> >> running yet, thus no vpci_process_pending is possible yet (in terms
> >> it has something to do yet). So, I think we just need:
> >>
> >>           write_unlock(&pdev->domain->vpci_rwlock);
> >>           process_pending_softirqs();
> >>           write_lock(&pdev->domain->vpci_rwlock);
> >>
> >> and this should be enough
> > Given the context apply_map is called from (dom0 specific init code),
> > there's no need to check for the pdev to still exits, or whether vpci
> > has been recreated, as it's not possible. Just add a comment to
> > explicitly note that the context of the function is special, and thus
> > there's no possibility of either the device or vpci going away.
> Does it really need write_unlock/write_lock given the context?...

I think it's bad practice to call process_pending_softirqs while
holding any locks. This is a very specific context so it's likely fine
to not drop the lock, but would still seem incorrect to me.

> I think it doesn't as there is no chance defer_map is called, thus
> process_pending_softirqs -> vpci_process_pending -> read_lock

Indeed, there's no chance of that because process_pending_softirqs
will never try to do a scheduling operation that would result in our
context being scheduled out.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Feb 14 11:27:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 11:27:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271456.465895 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJZW6-0001EA-Jf; Mon, 14 Feb 2022 11:27:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271456.465895; Mon, 14 Feb 2022 11:27:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJZW6-0001E3-GA; Mon, 14 Feb 2022 11:27:38 +0000
Received: by outflank-mailman (input) for mailman id 271456;
 Mon, 14 Feb 2022 11:27:37 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=gtPN=S5=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1nJZW5-0001Dx-Ar
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 11:27:37 +0000
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur03on0626.outbound.protection.outlook.com
 [2a01:111:f400:fe09::626])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1bed3292-8d89-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 12:27:36 +0100 (CET)
Received: from AM6PR10CA0072.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:80::49)
 by DBBPR08MB5996.eurprd08.prod.outlook.com (2603:10a6:10:201::8) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Mon, 14 Feb
 2022 11:27:29 +0000
Received: from AM5EUR03FT039.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:80:cafe::74) by AM6PR10CA0072.outlook.office365.com
 (2603:10a6:209:80::49) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.18 via Frontend
 Transport; Mon, 14 Feb 2022 11:27:29 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT039.mail.protection.outlook.com (10.152.17.185) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4975.11 via Frontend Transport; Mon, 14 Feb 2022 11:27:29 +0000
Received: ("Tessian outbound 63bb5eb69ee8:v113");
 Mon, 14 Feb 2022 11:27:29 +0000
Received: from fd1ac9cc958f.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 BCE1E87E-1E60-444E-8AF9-54CE6B1BDE0E.1; 
 Mon, 14 Feb 2022 11:27:23 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id fd1ac9cc958f.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 14 Feb 2022 11:27:23 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by AM9PR08MB6273.eurprd08.prod.outlook.com (2603:10a6:20b:2d7::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Mon, 14 Feb
 2022 11:27:21 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::aca7:79c4:fa65:dac6]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::aca7:79c4:fa65:dac6%5]) with mapi id 15.20.4975.019; Mon, 14 Feb 2022
 11:27:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1bed3292-8d89-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=2V37/ukN9UxE3o3Kp+xKf4cCwyMAtoZ+XtH9Ls9o4Js=;
 b=l6HfSFezaIjNkw+H85wRFble/cy2hzwrreMH3k1R44TNm6t6Sp0LBOWOKrTFqmeXthhonWXYGAAfhzc8X5PdxJcxXVAtAo2WcaEfHpvqedfPXhAxhLeG2PO8fzqWph/LuVtUm87WoCjFEuA4LDz8hza43qK3H+VgrpIN6jyW0hE=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: db13a75bb7ff63ea
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=DhtNLaO2x7uzyQxK61irfDuM4sdIS6P2spoGj3mPl0vJUu6Xp42dL02cDgOOMh3oZHBwCVLJufXJib1banrjRztuFgM2IG8J9cS+u8FuErcqp7I2mskAXTEGNojl9+zSy4KykJf1MtRkJ0dQ8g7/FvrUD8TTobJM+yZAJWvrAsJ7zC2FDvkJQ3hXHb5BnELWpfFQgGwTQVcyFyEm38w0qTOxikpkRWpmoV1QkCB9Qx4RrhFObxkSUuBgbKMHbS2Zl0SXQAz/g3cQ7a6UL1jHLgXQM7LKip8I5N2G54rHLNN2yRTqPo4qQHHrYCpJAiZr5sYH/nAfyrSQf0gkbkrGww==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=2V37/ukN9UxE3o3Kp+xKf4cCwyMAtoZ+XtH9Ls9o4Js=;
 b=arbiQEyiHDzDrjH5UotXYJmF7wc8ZQp4YC3mIhH096GH6U/8oiWSu4WgOia9OkSouj+LclnfeUqom7ZkzhE9mVzK951k/PXkI2ELttTNop2gSWcjpH5/iYOXVTBEi6imAFIJZrzyJDnzHDPapkMP2t8VJVSeDximrucA76SHGOPiCJ6gsmqqdohUIhZGHKDU13KCH1rYjkwJekket+0xOykZYsYtUmH6BUW2okoTTpBOjCJrrnwPXFhTwHKcg0LtgRbMikX5B0XOzRrtPhTY6VAeuadnv4G4M1Kq6zAObq4kka8MjD18Eo9IiublgQ6/vreaUBHlcRAgY//BZglRfQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=2V37/ukN9UxE3o3Kp+xKf4cCwyMAtoZ+XtH9Ls9o4Js=;
 b=l6HfSFezaIjNkw+H85wRFble/cy2hzwrreMH3k1R44TNm6t6Sp0LBOWOKrTFqmeXthhonWXYGAAfhzc8X5PdxJcxXVAtAo2WcaEfHpvqedfPXhAxhLeG2PO8fzqWph/LuVtUm87WoCjFEuA4LDz8hza43qK3H+VgrpIN6jyW0hE=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
CC: Julien Grall <julien@xen.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, Stefano Stabellini
	<sstabellini@kernel.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [RFC v2 5/8] xen/arm: introduce SCMI-SMC mediator driver
Thread-Topic: [RFC v2 5/8] xen/arm: introduce SCMI-SMC mediator driver
Thread-Index:
 AQHYHRW24Dmb0qV8ZkqAv39Pf6/nVayODW6AgAAg+ICAAAmzAIABqiEAgAMLQQCAAAQDgA==
Date: Mon, 14 Feb 2022 11:27:21 +0000
Message-ID: <E78206B4-3793-498E-A580-F0561DF6D4AC@arm.com>
References: <cover.1644341635.git.oleksii_moisieiev@epam.com>
 <cb1493f5d9b5c3437268054b4a8e345cb35c8708.1644341635.git.oleksii_moisieiev@epam.com>
 <F9811680-C6EC-4372-A451-5C1DA279E35E@arm.com>
 <20220211104403.GA2291814@EPUAKYIW015D>
 <A9FF3FBC-C29D-4A17-8737-EBABEF240BA2@arm.com>
 <c13f6312-3922-4504-3248-e2e4701b1a10@xen.org>
 <20220214111300.GA3615313@EPUAKYIW015D>
In-Reply-To: <20220214111300.GA3615313@EPUAKYIW015D>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3693.60.0.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 28da943d-6e7b-4470-53d7-08d9efacfc38
x-ms-traffictypediagnostic:
	AM9PR08MB6273:EE_|AM5EUR03FT039:EE_|DBBPR08MB5996:EE_
X-Microsoft-Antispam-PRVS:
	<DBBPR08MB59960322FD4CFBE8AB36A8579D339@DBBPR08MB5996.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 PSPpdEUETwv9uzeEDJ6rsRBRLCYuZXod1OWRV4hul/gvBaOdndgdDdJXY9Uupaz3UyJ/iNmI1XQqAQqA67stYfD9PUvsOTMzYDLmILvn6eBSW/vj/BFKRay75td7XX5RC0TblugKE3yGFw9HQNm6IwKxartepQBXNvFxpVRTw6cbIZEuXwXJSvQciSLrundwWBYJqul66pd8Jt3me9Me2NvinlLN+qG8AAkwBQsMvPa/YP79mwlSOw8z0orQ/psZgH28WJp+8LKC0A0iqx168kz0lGFzP5Ove+yytobXBRupbUXqv8nP/DxVxjLmK2rW9TSFOiMmH1NjWTXHYjsT7PWtiXpLiWTCuDztUDf2PDPc0BDgiISBt6zp+5rLUXa+RecJhv8FQKbn2hGujjzZYXPf64ag9OiEn7hfMh66u3sML7uuE6BnalK8Z8/YaNqKzCG8w675fKCMF5H2jr68LQ3u3ONGyx8u/mlMBmmeRDh+rrGsf/BCmkuJC5L2WXTfMg3tRlXONHO+wWNIRdnSRSvoW04hQEQWfuu0g0QAPf4BqkZxr5xUpOJhECJKFHYOMsVzIrLqY8AzA9iO4hyIo4vHa8VrQiM01uL8rbYfwCBp0vN6Z8O8nNGWyrcjXdphMqgRqLiiQwZ4ZDfFKR8RoL7RJLkkKvOko6Oqpc+rTOAXTidwcNBCnEMDFOatMkaDSi+FDPYQaFIyL2nD/DaiglnSUjIg56UtvCdp4//yxlOFxx1MgJghu6qBAaMrK0vbVSupblIR9RGuNw50gzZ0sGe2oeV+c6ceTbBus7/cmCTOKjqseY8cD63hbBs13OaH/4rA5A1NFpF1fvetqLXZOG7AyYIwkE44cPG2+ntw/e8=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6486002)(6506007)(508600001)(86362001)(6512007)(53546011)(2616005)(966005)(71200400001)(38100700002)(83380400001)(186003)(26005)(122000001)(66446008)(8676002)(8936002)(38070700005)(33656002)(5660300002)(316002)(4326008)(64756008)(76116006)(66946007)(36756003)(66556008)(6916009)(91956017)(54906003)(66476007)(2906002)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <B977726E290F5E4F8F2F4DC27E8EF9EA@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6273
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT039.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	5f7408e6-4967-472c-2f45-08d9efacf791
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	JegdCA2vNObgT4vL/DtCZkUK8puf4ZMmccQlJaquiQ9AQrjWNXhGyAMg0UrnqFs1Abn/a8xWBCCJlPjtye2SAhCQSKtifTqv8CnIG4O6BvciKrzgI0qnKcbgzWcjkQxEB6iU+/bYVW51XA8/RBRHqkFj1k74Kp9z4lX3gC+iKtwR2gXA+95ZQK6LY4OaTkV2v4QVRSEnu7tFevM4mDG8yuXTznFlmObHtod+0Fv4uWSqt03HOio7TDx0+MzG/2zZUZbOgqOXPx7RXVBJX22s45P4P3fCdZW/SZUq3X46J9pw9Um4myw83LNPE+twNukHjd2dvVrHVzj/TZDtmlqj761jOTm4BrWud2sR9v8GgxNXp0RqolpAeW60whiMIq08PPzeYYFx3jr8yGOc4zZbeL2mIjLcnMVwDW5TmaB80w6SrjNgRlHdtbKi/ABDNLWXrDBnoF58Od/npPtjUTHp64GVh0ZXnGmyJetLuBYP5AwkAYPkH/yQiVR5if5AmXZ/YCBjAi3oGQZhjYPsFdPJnH8fKX+V4JEtewul5tC3n6gHVqvZnT9LPojLbS+hzAspaliaK7yDAm3PPAbn2FiAuNvbeMaZIYw36QkINvHTrsNUwr0RKbATLHjqerdrNbUR0ZBokavHI0XdCduIXNrTDJG/IBCqrvF2NWd2oHdcTjp4NTPTnzyAmJMLhFUd9X/cWiEfPWfEXG6MZhoi2i5uY+OF1yRlWHDzQZQCKHvr+rozNx2hOGU1FiboIblTQ3/QijUzz5RBqM17rVQGtkl2mMV2nOPVetWifXhSbu9BVyLFMSnIUvCwGZC0ln33IAGx
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(6512007)(40460700003)(316002)(107886003)(2616005)(54906003)(86362001)(47076005)(53546011)(6506007)(36860700001)(186003)(26005)(2906002)(33656002)(36756003)(83380400001)(966005)(82310400004)(81166007)(5660300002)(70206006)(6486002)(70586007)(336012)(356005)(8676002)(4326008)(6862004)(508600001)(8936002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2022 11:27:29.3974
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 28da943d-6e7b-4470-53d7-08d9efacfc38
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT039.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB5996

Hi Oleksii,

> On 14 Feb 2022, at 11:13, Oleksii Moisieiev <Oleksii_Moisieiev@epam.com> =
wrote:
>=20
> Hi Julien,
>=20
> On Sat, Feb 12, 2022 at 12:43:56PM +0000, Julien Grall wrote:
>> Hi,
>>=20
>> On 11/02/2022 11:18, Bertrand Marquis wrote:
>>> Do you plan to add support for other boards ?
>>>=20
>>> Did you discuss more in general with the linux kernel guys to see if th=
is
>>> approach was agreed and will be adopted by other manufacturers ?
>>>=20
>>> All in all I think this is a good idea but I fear that all this will ac=
tually only
>>> be used by one board or one manufacturer and other might use a differen=
t
>>> strategy, I would like to unrisk this before merging this in Xen.
>>=20
>> In the past we merged code that would only benefits one vendor (i.e. EEM=
I).
>> That said, this was a vendor specific protocol. I believe the situation =
is
>> different here because the spec is meant to be generic.
>>=20
>>> @julien and Stefano: what is your view here ?
>>=20
>> I share the same concerns as you. I think we need to make sure all the
>> pieces we rely on (e.g. firmware, DT bindings) have been agreed before w=
e
>> can merge such code in Xen.
>>=20
>> The first step is to have all the pieces available in public so they can=
 be
>> reviewed and tested together.
>>=20
>> Oleksii, on a separate e-mail, you said you made change for ATF. How muc=
h of
>> those changes was related to support for Xen? If they are some, then I t=
hink
>> they should be upstreamed first.
>>=20
>=20
> Let me share changes, that were done to AT-F and Linux kernel
> device-tree in terms of the SCMI mediator POC.
> Changes to the Linux kernel:
> https://github.com/oleksiimoisieiev/arm-trusted-firmware/pull/4
> Based on renesas-rcar linux-bsp, branch v5.10/rcar-5.0.0.rc5
>=20
> Changes to AT-F:
> https://github.com/oleksiimoisieiev/linux-bsp/pull/3
> Based on renesas-rcar/arm-trusted-firmware branch rcar_gen3_v2.5.

You inverted the links but thanks this is really useful.

Did you push the ATF changes to mainstream ATF or discuss those with
the maintainers ?

The strategy overall is nice but we need to make sure this is accepted and
 merged by all parties (ATF and Linux) to make sure the support for this wi=
ll
not only be available in Xen and for one board.

I will try to get in touch with the SCMI linux driver maintainer at arm to =
get his view.

Regards
Bertrand

>=20
> All changes that were done are not Xen specific. Given AT-F changes are
> the implementation of the SCMI feature using SMC as transport. All
> changes were done accoding to the DEN0056C [0] and DEN0028D [1].
>=20
> We pass channel_id via SMC to the Firmware on r7 bits [15:0] (See Section
> 4.1 of [1]). Then Firmware converts channel_id to agent_id. Channel_id ca=
n't be
> equal to agent_id in our case, because, according to the 4.2.2.8 of [0]
> - agent_id 0 is reserved to identify platform itself.
>=20
>=20
> [0] https://developer.arm.com/documentation/den0056/latest
> [1] https://developer.arm.com/documentation/den0028/latest
>=20
> Best regards,
> Oleksii.



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 11:37:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 11:37:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271463.465905 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJZfX-0002iW-HI; Mon, 14 Feb 2022 11:37:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271463.465905; Mon, 14 Feb 2022 11:37:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJZfX-0002iP-EB; Mon, 14 Feb 2022 11:37:23 +0000
Received: by outflank-mailman (input) for mailman id 271463;
 Mon, 14 Feb 2022 11:37:22 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=YsDI=S5=epam.com=prvs=4044e07e7c=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nJZfW-0002iJ-Hk
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 11:37:22 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 76f436c1-8d8a-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 12:37:19 +0100 (CET)
Received: from pps.filterd (m0174679.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 21EAmY4g004034;
 Mon, 14 Feb 2022 11:37:16 GMT
Received: from eur03-am5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2054.outbound.protection.outlook.com [104.47.8.54])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e7nbmg74e-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Mon, 14 Feb 2022 11:37:15 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM6PR03MB5048.eurprd03.prod.outlook.com (2603:10a6:20b:8c::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Mon, 14 Feb
 2022 11:37:12 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::fc4d:4749:5d1:eb73]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::fc4d:4749:5d1:eb73%4]) with mapi id 15.20.4975.018; Mon, 14 Feb 2022
 11:37:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 76f436c1-8d8a-11ec-b215-9bbe72dcb22c
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=JR7RD0yh1xy1dLcfaWMc+c9sBkcLMNXpw89bpROvGP6GmY6Dc6iW/vZRKPkU2adRsCJV8bFUb2FvPc/Hjqecl44ZvB3B/Y3joKxtNbeEinssHJH1sO/NGlQBeydrnCucrxeDScHvFr+gTW+JFeCrl5aUYbdbq9pN0VKCJfUief/5/L/yEWJz3J7XJmnnWQ1UoZFw0GLZ4T4ldCYdOhsiK9b3q+oLa2g18jt5c6MlXaNaxpt4G6EtPV+Ps9BvLUx4LFlyIDaBOuaCPGbk7EUi8eQD27Y8shc9P/Le93sN8lp8axY3cDogcMfctGgLHgvn2B/uqXdrY4cmj19tzD7jgw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=BiGEzq9pRHRTrpgjt37xa+q5mYAKxcH1FrQrR3MGeZo=;
 b=gqyTnIKsQJPlNgoo+ydzLZ1t8Gf/7UPbhJ/tSGc6aH+fqZlwSJo7atuJfpxw7iZvyGAXNsdvA7cRFKMx7Voxayt6hX536fVultnEE3qjFnjN4mi0coAHEiZxFEzCvQWoXp1HpnQloUIkVqT2yWgVq89Dg8XgmoMDJkYma/bxilMtndAc4Efj7CM61ep5cdXdjEtdin4RziJIEzo8TT6QGljkeJ9d8bhv4kY6Umz+1Eq7S6VG/qVIZ74rKJuWO0f1vzpxFhbnqn5xthRQnPFBdH99xj3EfaQ194aAEzlszkrXB3zOsG4gRHP2AKasZFGAsnT/OH9e8FL1IrrTJlalmg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=BiGEzq9pRHRTrpgjt37xa+q5mYAKxcH1FrQrR3MGeZo=;
 b=iPwGXr0wK7LqbsYgn31MEWWPz7cW1wAWH8cAQRIDXMNzX/YaWqEMBJgCSLlOaSq3LXiwYe8P0nx3V7Bz3pUHezt3/k2H3izUzjMSe462yetWxqf1d1V/f3z0KB7wYW+t3hSD4L/F5pxQca5ZcURNHqplsQ1uX6l0J/ROjIv3hm3QwUeoZEJOIrUfhDIFEGussY7EQjmfvZhE+XnSOm3Du4h8onthYusDIABMqoMwr8ZbI5ywXWuzHnupeafvD/kz+gY34hrWYbVkqNkZmuKMMO5HJu1gfNHTZQF471C4RG0pAxGZTk8Su14twleDJxjzQ3Szoj4/1cT9oruNZE7pCQ==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "jbeulich@suse.com" <jbeulich@suse.com>,
        "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org" <sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>,
        Rahul Singh <rahul.singh@arm.com>
Subject: Re: [PATCH] vpci: introduce per-domain lock to protect vpci structure
Thread-Topic: [PATCH] vpci: introduce per-domain lock to protect vpci
 structure
Thread-Index: 
 AQHYHboQT3cBWYI1/EGunE7hOwop6ayM95MAgAD+qQCAAEaDAIAElIcAgAAQEwCAAAV1AIAABOQAgAABMICAAALZgIAAAzmA
Date: Mon, 14 Feb 2022 11:37:12 +0000
Message-ID: <114b8578-ee13-b67d-e282-d060187ef509@epam.com>
References: <20220209133627.959649-1-andr2000@gmail.com>
 <YgU6Snk8GTytJXZp@Air-de-Roger>
 <c4666570-666e-6680-5ec2-adf1da51ad06@epam.com>
 <YgZLEMW9US9QjjYG@Air-de-Roger>
 <33fb1095-64ed-29ef-ba6b-cbde21d941f8@epam.com>
 <YgowIg5MvTaf2zsR@Air-de-Roger>
 <d8389a90-00c8-b34a-8488-b0f3fc5bde1b@epam.com>
 <Ygo40L4dMPJjZKRF@Air-de-Roger>
 <746860aa-c403-1eca-0a75-587c5d10c8c2@epam.com>
 <Ygo8M3Y6BLzljn15@Air-de-Roger>
In-Reply-To: <Ygo8M3Y6BLzljn15@Air-de-Roger>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 66ffcf85-b5c7-42cc-08ce-08d9efae57d0
x-ms-traffictypediagnostic: AM6PR03MB5048:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM6PR03MB50488924CB37F290720E792FE7339@AM6PR03MB5048.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 hG5d9Boh8ELfZRF/jk4yegz0Ph4B+p/kPXylzYS23OBbdppj0pGQI5Y0CJV1D7y3hHy/+vdZNrgs+7tu88KUttvPHWsBBI79s4BDJ0kS+cgtWQsTw+fzIZ2IE+r6P1OjO9flRLuS09Rl+HYAGog3z+ikh6rh1PDbJpfI9WGnaHUYarMBTii57BvqAjGbNqJLcPwK7K4blIiPnYtCP7TjDQH2gaBVjSqtBbU+fsJSCHHKPV5PMdPaYPlG8AWie6w96pIDO0NIWmrvnuzo5ONxqrLK7KgOrDnkW/Oy+fyENSpP9gVlb3QrunbSnMj7yElxucLfvlBPb9YOHETl9NlTWXotw4+MtLcaeUm+KmWC/ZPRg+2FlFIlMWd5gohf0008twJ2afhRW6ijW66MBXaR/o6i0XDOVBq/CFa1k5ElsSEUhxItIwNeHvSjOuq6Jn26j1jEOskb10yxxIpJxQMlNPpSsZgF7pIJ6omOOLAC+rGQzBG6zvDJ67r9BKfwsPVhJGi6x5W6X8xkLsHHGCwAtBkE8uV3A+u3bqJhNOHFhSJ97XHCp7+6jMQ763kErrGVCMzrpWuuyBRZATG9CxJlFkX79+diNkZ8M2r1/1kxICjgQKaG5JOXDTThbSUIa7HagOCkl/DW/IAlpi7s2R+xx9rCaPcjljf46vnmOKxkCTA9kRmHqZbwi+cs4xktvhENAgjBRwsj4QgHVIupNpvQJwuKjaIlXXs+oFBKzPpgFu+e/EkEJ9RZ3Os3uT5Ylvj5
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(2616005)(53546011)(6506007)(8936002)(54906003)(316002)(6512007)(55236004)(38070700005)(91956017)(36756003)(71200400001)(31686004)(6916009)(6486002)(508600001)(122000001)(64756008)(8676002)(2906002)(83380400001)(31696002)(86362001)(66476007)(26005)(66946007)(66446008)(186003)(66556008)(4326008)(76116006)(5660300002)(38100700002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?Qm9IQjh0ZGxRZWdzK3lqbU9ZNG1WTXFRZitkajJZdnNUb2lvTXY3QlA5N3VU?=
 =?utf-8?B?Y29yV0F3SG1PY0NQVGNxMldrK21nbWNmekxjN2xWOFd3ZDdrQ2g3cXBDSk5u?=
 =?utf-8?B?UjBEbkIxanpucFY3ZFQzaDJKYVlqay9TVVR3a0FwUHdlRGxobUR1YjNsY3dj?=
 =?utf-8?B?WWsxdTFMMXdLckQ0TkFOZnhJbE1RWjdKcTFXaVU3M1FPVit2QkNOcFNXamU5?=
 =?utf-8?B?Nll3Mk4raXJEOGVRMjN3eXlCbzllT20zblNieDhucVVwMU5ZR1ltMDc3eTR6?=
 =?utf-8?B?SU1sTFBEcFdDQ2VqWlh4aThDZUJGbWZ2TWpQZmZGRFZsckpxRDRnNVdMcFA4?=
 =?utf-8?B?RUJnZ1NiRkZJZ0FoVnU0TXJucVBMREJtTEg4NXVVakN1UWk4VmxSNHNaUE82?=
 =?utf-8?B?b2VPSVVoTmtId3FrNm80MVFUQkNHWktZSyt3UnRQemxVd09PT3JpRUxNTTBG?=
 =?utf-8?B?dXlSUzdVQXpqOGNPTjU4aTBKaEVwanFjNC9iUTZtaVJvL0FETTRaT3luWVZR?=
 =?utf-8?B?K0l3dnc2bTVqRTl3eldGNCsvKzBsdTVTdWlmOFIyR3pEeWd5N0RiQXpRTDV2?=
 =?utf-8?B?Rlp1SmlkYi8xVTg3QldINTdaNmdhaXFUczBXeTNnMCtHajczeVd2ZTROdllV?=
 =?utf-8?B?OS94U2xDOEJJTk9VTFV5eE9Wcm1WWXgwUGJTUDBySERVL0pMczlML01uTE4x?=
 =?utf-8?B?NzkrRnZUNHBUS0REWHRkQWh1eXhSU2NkbTViQ01jSlpzZFY2ckoybUVrN0lG?=
 =?utf-8?B?Z0dMUWRLNXFOQmZCRDFKdXVlVG9xdGQ0MUhHZ0ZVZDJZSEZ4MFJXUEgrakhu?=
 =?utf-8?B?VXFhekpuL283QnJ4SWVsUzBnaHpnN1EvY3JXR3Njb3Q2SnV0VGUzdXlRbXhO?=
 =?utf-8?B?MG1FVjR2cktuRTRxc1gvZDF4MDFmM1NEOXduSVN4V0hxV1RhOTdsM2lrd2xm?=
 =?utf-8?B?Z0J4Qjk1cjVPMnBHcXBkWVgxNnZrNkNiZHo1UldxRWU3dmZEcWx4K3RUY0hC?=
 =?utf-8?B?N1Q5cFFYVVFRWHo1WWFkYzdCNGppeUJYNUJ4UnJidkVHbFlYNGczRTg4VFVJ?=
 =?utf-8?B?cUg5Rk5JSDB1REk0TFBQVU43S2psaGtaWjkzRnlNMUQvN29ySzBnTm9FcXI1?=
 =?utf-8?B?NjFyTFlBRlUybmRoUWlQNzhOell0anBMS0lMdFZTbG0rOUx2NzEyZ1Y4LzNV?=
 =?utf-8?B?blczQmJBYWIrekcraEZPMUZnajdvWWNjVVp2eDNUK1FtM05PTHQwT2J3U0sv?=
 =?utf-8?B?Nmp4eW1xWjJCcnRpWWVvaDUraW8rcENEZHZjelpudXh3elJDWlVMeTVibC9u?=
 =?utf-8?B?VHdNZG1CQW9VaEc1bHdpellrQXVPYWViRnRnVVdRQVdTWS8vaHUzRDg1MjZB?=
 =?utf-8?B?MWFycXBlazYweUZzWEFILzNadE91TkZ2TlozRnhnR09Pa3Z2Zm1UYkx4ckJy?=
 =?utf-8?B?ZEJnaEtkeXlRYzQzdmFTeEdNb3JEUit0R2tQSnJoNGtXUlpuU0ZvZXRNSzgw?=
 =?utf-8?B?MWRUSFdHK0NVaTZrK296RnZrQi9lWEpVV1g4R2xUVXQzaTR1QWQyazJ5b29M?=
 =?utf-8?B?ZVYrTHFSNUJlZGdmejlwQVNWTkpONFdJMTk2R2xTd082blhNV3RWL3BJNTk5?=
 =?utf-8?B?QWRSWDNnSTZNZHBDRUdhVEVaZDRIdlNIRU9PMXJxRXY4NGIyNlp2eWFkbGc4?=
 =?utf-8?B?NnNrNno4SUNIVVdWL3BqNFhxWi9TbnNibCtzZ3ZBcWYzY2pyUDVTWjhWL0VJ?=
 =?utf-8?B?cjhxcFU5NVcrQ3ZJVmdWdmNiODk5RXpNcVkveGdTRXIwYUxzSXhXUDlMZGd0?=
 =?utf-8?B?ZHZCQWgyNGlzVXl2TUk1OWx5OStaendrbm9yclo0d05oKzFhM1Z1YWg3UVMr?=
 =?utf-8?B?bDNFMHdOR3BDejE4MHdHcmlPWmY0dkwrbjgvOWdyK21ZMnpoZmZZeElGcElS?=
 =?utf-8?B?Y2s3Zlc0cFd1UFpMdG1LK2JhTi9uK1F0NlpObFpyUC85VDMxaVVObXoxTXlP?=
 =?utf-8?B?eW1DVWdaNUZJYWlwVWVTU2VsTk9idEZWVGZYWGc0RGRFTGRFUDczKzJ0eWdW?=
 =?utf-8?B?MGhOWHhleFBlZFYzd0NxK1k5VWk2UmpudmJqOHlNQW4yWGdJODhMTElzYXY2?=
 =?utf-8?B?Y3NoOVFIOThhNTlYZDIzY1lhMWY5YThJaVFxa2hGcG5VSFd4OGhGM01XTEFx?=
 =?utf-8?B?a3BSdlV2bVhuQUcvakw3RWdvMWlNRTV1MzIvUGNCdE5RYmtmWGQyamJVc05W?=
 =?utf-8?B?OGVETExKMHBnUG0vSkdVK0p0RnV6dk84L2E0aEZ4aTZRa3FDTEROYUtTSDRT?=
 =?utf-8?B?cjZhR29TdVl2UXNnY3MrVGRvV0xpVHR0ck9Rb0VEN3F3QlBCUGZwQT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <BB01C1908D38F248BD965921D9EAB571@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 66ffcf85-b5c7-42cc-08ce-08d9efae57d0
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Feb 2022 11:37:12.5298
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: lNAPHiaxcpjEEIjp1Mod8QWMXS+C1xyayAC2H5Z7/pPq46KSwVzQrbEAP34xddrskCvNCAuZpzqx26JtpR377pp82DPzIdaa4e852iTfnGenI/4lnqYeGpMuRnZW0hZ0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR03MB5048
X-Proofpoint-ORIG-GUID: ZEKKYbF7mDeo7EhV3KWlzOp3YmMV9AzK
X-Proofpoint-GUID: ZEKKYbF7mDeo7EhV3KWlzOp3YmMV9AzK
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-14_03,2022-02-14_03,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 bulkscore=0
 mlxlogscore=999 adultscore=0 clxscore=1015 spamscore=0 malwarescore=0
 phishscore=0 lowpriorityscore=0 priorityscore=1501 suspectscore=0
 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202140070

DQoNCk9uIDE0LjAyLjIyIDEzOjI1LCBSb2dlciBQYXUgTW9ubsOpIHdyb3RlOg0KPiBPbiBNb24s
IEZlYiAxNCwgMjAyMiBhdCAxMToxNToyN0FNICswMDAwLCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5r
byB3cm90ZToNCj4+DQo+PiBPbiAxNC4wMi4yMiAxMzoxMSwgUm9nZXIgUGF1IE1vbm7DqSB3cm90
ZToNCj4+PiBPbiBNb24sIEZlYiAxNCwgMjAyMiBhdCAxMDo1Mzo0M0FNICswMDAwLCBPbGVrc2Fu
ZHIgQW5kcnVzaGNoZW5rbyB3cm90ZToNCj4+Pj4gT24gMTQuMDIuMjIgMTI6MzQsIFJvZ2VyIFBh
dSBNb25uw6kgd3JvdGU6DQo+Pj4+PiBPbiBNb24sIEZlYiAxNCwgMjAyMiBhdCAwOTozNjozOUFN
ICswMDAwLCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyB3cm90ZToNCj4+Pj4+PiBPbiAxMS4wMi4y
MiAxMzo0MCwgUm9nZXIgUGF1IE1vbm7DqSB3cm90ZToNCj4+Pj4+Pj4gKw0KPj4+Pj4+Pj4+PiAg
ICAgICAgICAgZm9yICggaSA9IDA7IGkgPCBtc2l4LT5tYXhfZW50cmllczsgaSsrICkNCj4+Pj4+
Pj4+Pj4gICAgICAgICAgIHsNCj4+Pj4+Pj4+Pj4gICAgICAgICAgICAgICBjb25zdCBzdHJ1Y3Qg
dnBjaV9tc2l4X2VudHJ5ICplbnRyeSA9ICZtc2l4LT5lbnRyaWVzW2ldOw0KPj4+Pj4+Pj4+IFNp
bmNlIHRoaXMgZnVuY3Rpb24gaXMgbm93IGNhbGxlZCB3aXRoIHRoZSBwZXItZG9tYWluIHJ3bG9j
ayByZWFkDQo+Pj4+Pj4+Pj4gbG9ja2VkIGl0J3MgbGlrZWx5IG5vdCBhcHByb3ByaWF0ZSB0byBj
YWxsIHByb2Nlc3NfcGVuZGluZ19zb2Z0aXJxcw0KPj4+Pj4+Pj4+IHdoaWxlIGhvbGRpbmcgc3Vj
aCBsb2NrIChjaGVjayBiZWxvdykuDQo+Pj4+Pj4+PiBZb3UgYXJlIHJpZ2h0LCBhcyBpdCBpcyBw
b3NzaWJsZSB0aGF0Og0KPj4+Pj4+Pj4NCj4+Pj4+Pj4+IHByb2Nlc3NfcGVuZGluZ19zb2Z0aXJx
cyAtPiB2cGNpX3Byb2Nlc3NfcGVuZGluZyAtPiByZWFkX2xvY2sNCj4+Pj4+Pj4+DQo+Pj4+Pj4+
PiBFdmVuIG1vcmUsIHZwY2lfcHJvY2Vzc19wZW5kaW5nIG1heSBhbHNvDQo+Pj4+Pj4+Pg0KPj4+
Pj4+Pj4gcmVhZF91bmxvY2sgLT4gdnBjaV9yZW1vdmVfZGV2aWNlIC0+IHdyaXRlX2xvY2sNCj4+
Pj4+Pj4+DQo+Pj4+Pj4+PiBpbiBpdHMgZXJyb3IgcGF0aC4gU28sIGFueSBpbnZvY2F0aW9uIG9m
IHByb2Nlc3NfcGVuZGluZ19zb2Z0aXJxcw0KPj4+Pj4+Pj4gbXVzdCBub3QgaG9sZCBkLT52cGNp
X3J3bG9jayBhdCBsZWFzdC4NCj4+Pj4+Pj4+DQo+Pj4+Pj4+PiBBbmQgYWxzbyB3ZSBuZWVkIHRv
IGNoZWNrIHRoYXQgcGRldi0+dnBjaSB3YXMgbm90IHJlbW92ZWQNCj4+Pj4+Pj4+IGluIGJldHdl
ZW4gb3IgKnJlLWNyZWF0ZWQqDQo+Pj4+Pj4+Pj4gV2Ugd2lsbCBsaWtlbHkgbmVlZCB0byByZS1p
dGVyYXRlIG92ZXIgdGhlIGxpc3Qgb2YgcGRldnMgYXNzaWduZWQgdG8NCj4+Pj4+Pj4+PiB0aGUg
ZG9tYWluIGFuZCBhc3NlcnQgdGhhdCB0aGUgcGRldiBpcyBzdGlsbCBhc3NpZ25lZCB0byB0aGUg
c2FtZQ0KPj4+Pj4+Pj4+IGRvbWFpbi4NCj4+Pj4+Pj4+IFNvLCBkbyB5b3UgbWVhbiBhIHBhdHRl
cm4gbGlrZSB0aGUgYmVsb3cgc2hvdWxkIGJlIHVzZWQgYXQgYWxsDQo+Pj4+Pj4+PiBwbGFjZXMg
d2hlcmUgd2UgbmVlZCB0byBjYWxsIHByb2Nlc3NfcGVuZGluZ19zb2Z0aXJxcz8NCj4+Pj4+Pj4+
DQo+Pj4+Pj4+PiByZWFkX3VubG9jaw0KPj4+Pj4+Pj4gcHJvY2Vzc19wZW5kaW5nX3NvZnRpcnFz
DQo+Pj4+Pj4+PiByZWFkX2xvY2sNCj4+Pj4+Pj4+IHBkZXYgPSBwY2lfZ2V0X3BkZXZfYnlfZG9t
YWluKGQsIHNiZGYuc2VnLCBzYmRmLmJ1cywgc2JkZi5kZXZmbik7DQo+Pj4+Pj4+PiBpZiAoIHBk
ZXYgJiYgcGRldi0+dnBjaSAmJiBpc190aGVfc2FtZV92cGNpKHBkZXYtPnZwY2kpICkNCj4+Pj4+
Pj4+IDxjb250aW51ZSBwcm9jZXNzaW5nPg0KPj4+Pj4+PiBTb21ldGhpbmcgYWxvbmcgdGhvc2Ug
bGluZXMuIFlvdSBsaWtlbHkgbmVlZCB0byBjb250aW51ZSBpdGVyYXRlIHVzaW5nDQo+Pj4+Pj4+
IGZvcl9lYWNoX3BkZXYuDQo+Pj4+Pj4gSG93IGRvIHdlIHRlbGwgaWYgcGRldi0+dnBjaSBpcyB0
aGUgc2FtZT8gSmFuIGhhcyBhbHJlYWR5IGJyb3VnaHQNCj4+Pj4+PiB0aGlzIHF1ZXN0aW9uIGJl
Zm9yZSBbMV0gYW5kIEkgd2FzIGFib3V0IHRvIHVzZSBzb21lIElEIGZvciB0aGF0IHB1cnBvc2U6
DQo+Pj4+Pj4gcGRldi0+dnBjaS0+aWQgPSBkLT52cGNpX2lkKysgYW5kIHRoZW4gd2UgdXNlIHBk
ZXYtPnZwY2ktPmlkwqAgZm9yIGNoZWNrcw0KPj4+Pj4gR2l2ZW4gdGhpcyBpcyBhIGRlYnVnIG1l
c3NhZ2UgSSB3b3VsZCBiZSBPSyB3aXRoIGp1c3QgZG9pbmcgdGhlDQo+Pj4+PiBtaW5pbWFsIGNo
ZWNrcyB0byBwcmV2ZW50IFhlbiBmcm9tIGNyYXNoaW5nIChpZTogcGRldi0+dnBjaSBleGlzdHMp
DQo+Pj4+PiBhbmQgdGhhdCB0aGUgcmVzdW1lIE1TSSBlbnRyeSBpcyBub3QgcGFzdCB0aGUgY3Vy
cmVudCBsaW1pdC4gT3RoZXJ3aXNlDQo+Pj4+PiBqdXN0IHByaW50IGEgbWVzc2FnZSBhbmQgbW92
ZSBvbiB0byB0aGUgbmV4dCBkZXZpY2UuDQo+Pj4+IEFncmVlLCBJIHNlZSBubyBiaWcgaXNzdWUg
KHByb2JhYmx5KSBpZiB3ZSBhcmUgbm90IGFibGUgdG8gcHJpbnQNCj4+Pj4NCj4+Pj4gSG93IGFi
b3V0IHRoaXMgb25lOg0KPj4+Pg0KPj4+PiBkaWZmIC0tZ2l0IGEveGVuL2RyaXZlcnMvdnBjaS9o
ZWFkZXIuYyBiL3hlbi9kcml2ZXJzL3ZwY2kvaGVhZGVyLmMNCj4+Pj4gaW5kZXggODA5YTZiNDc3
M2UxLi41MDM3M2YwNGRhODIgMTAwNjQ0DQo+Pj4+IC0tLSBhL3hlbi9kcml2ZXJzL3ZwY2kvaGVh
ZGVyLmMNCj4+Pj4gKysrIGIveGVuL2RyaXZlcnMvdnBjaS9oZWFkZXIuYw0KPj4+PiBAQCAtMTcx
LDEwICsxNzEsMzEgQEAgc3RhdGljIGludCBfX2luaXQgYXBwbHlfbWFwKHN0cnVjdCBkb21haW4g
KmQsIGNvbnN0IHN0cnVjdCBwY2lfZGV2ICpwZGV2LA0KPj4+PiAgICDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBzdHJ1Y3QgcmFuZ2VzZXQg
Km1lbSwgdWludDE2X3QgY21kKQ0KPj4+PiAgICDCoHsNCj4+Pj4gICAgwqDCoMKgwqAgc3RydWN0
IG1hcF9kYXRhIGRhdGEgPSB7IC5kID0gZCwgLm1hcCA9IHRydWUgfTsNCj4+Pj4gK8KgwqDCoCBw
Y2lfc2JkZl90IHNiZGYgPSBwZGV2LT5zYmRmOw0KPj4+PiAgICDCoMKgwqDCoCBpbnQgcmM7DQo+
Pj4+DQo+Pj4+ICsgQVNTRVJUKHJ3X2lzX3dyaXRlX2xvY2tlZCgmcGRldi0+ZG9tYWluLT52cGNp
X3J3bG9jaykpOw0KPj4+PiArDQo+Pj4+ICAgIMKgwqDCoMKgIHdoaWxlICggKHJjID0gcmFuZ2Vz
ZXRfY29uc3VtZV9yYW5nZXMobWVtLCBtYXBfcmFuZ2UsICZkYXRhKSkgPT0gLUVSRVNUQVJUICkN
Cj4+Pj4gK8KgwqDCoCB7DQo+Pj4+ICsNCj4+Pj4gK8KgwqDCoMKgwqDCoMKgIC8qDQo+Pj4+ICvC
oMKgwqDCoMKgwqDCoMKgICogcHJvY2Vzc19wZW5kaW5nX3NvZnRpcnFzIG1heSB0cmlnZ2VyIHZw
Y2lfcHJvY2Vzc19wZW5kaW5nIHdoaWNoDQo+Pj4+ICvCoMKgwqDCoMKgwqDCoMKgICogbWF5IG5l
ZWQgdG8gYWNxdWlyZSBwZGV2LT5kb21haW4tPnZwY2lfcndsb2NrIGluIHJlYWQgbW9kZS4NCj4+
Pj4gK8KgwqDCoMKgwqDCoMKgwqAgKi8NCj4+Pj4gK8KgwqDCoMKgwqDCoMKgIHdyaXRlX3VubG9j
aygmcGRldi0+ZG9tYWluLT52cGNpX3J3bG9jayk7DQo+Pj4+ICAgIMKgwqDCoMKgwqDCoMKgwqAg
cHJvY2Vzc19wZW5kaW5nX3NvZnRpcnFzKCk7DQo+Pj4+ICvCoMKgwqDCoMKgwqDCoCB3cml0ZV9s
b2NrKCZwZGV2LT5kb21haW4tPnZwY2lfcndsb2NrKTsNCj4+Pj4gKw0KPj4+PiArwqDCoMKgwqDC
oMKgwqAgLyogQ2hlY2sgaWYgcGRldiBzdGlsbCBleGlzdHMgYW5kIHZQQ0kgd2FzIG5vdCByZW1v
dmVkIG9yIHJlLWNyZWF0ZWQuICovDQo+Pj4+ICvCoMKgwqDCoMKgwqDCoCBpZiAocGNpX2dldF9w
ZGV2X2J5X2RvbWFpbihkLCBzYmRmLnNlZywgc2JkZi5idXMsIHNiZGYuZGV2Zm4pICE9IHBkZXYp
DQo+Pj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGlmICggdnBjaSBpcyBOT1QgdGhlIHNhbWUg
KQ0KPj4+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB7DQo+Pj4+ICvCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqAgcmMgPSAwOw0KPj4+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgIGJyZWFrOw0KPj4+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB9DQo+Pj4+ICvCoMKgwqAg
fQ0KPj4+PiArDQo+Pj4+ICAgIMKgwqDCoMKgIHJhbmdlc2V0X2Rlc3Ryb3kobWVtKTsNCj4+Pj4g
ICAgwqDCoMKgwqAgaWYgKCAhcmMgKQ0KPj4+PiAgICDCoMKgwqDCoMKgwqDCoMKgIG1vZGlmeV9k
ZWNvZGluZyhwZGV2LCBjbWQsIGZhbHNlKTsNCj4+Pj4NCj4+Pj4gVGhpcyBvbmUgYWxzbyB3YW50
cyBwcm9jZXNzX3BlbmRpbmdfc29mdGlycXMgdG8gcnVuIHNvIGl0ICptaWdodCoNCj4+Pj4gd2Fu
dCBwZGV2IGFuZCB2cGNpIGNoZWNrcy4gQnV0IGF0IHRoZSBzYW1lIHRpbWUgYXBwbHlfbWFwIHJ1
bnMNCj4+Pj4gYXQgKCBzeXN0ZW1fc3RhdGUgPCBTWVNfU1RBVEVfYWN0aXZlICksIHNvIGRlZmVy
X21hcCB3b24ndCBiZQ0KPj4+PiBydW5uaW5nIHlldCwgdGh1cyBubyB2cGNpX3Byb2Nlc3NfcGVu
ZGluZyBpcyBwb3NzaWJsZSB5ZXQgKGluIHRlcm1zDQo+Pj4+IGl0IGhhcyBzb21ldGhpbmcgdG8g
ZG8geWV0KS4gU28sIEkgdGhpbmsgd2UganVzdCBuZWVkOg0KPj4+Pg0KPj4+PiAgICDCoMKgwqDC
oMKgwqDCoCB3cml0ZV91bmxvY2soJnBkZXYtPmRvbWFpbi0+dnBjaV9yd2xvY2spOw0KPj4+PiAg
ICDCoMKgwqDCoMKgwqDCoCBwcm9jZXNzX3BlbmRpbmdfc29mdGlycXMoKTsNCj4+Pj4gICAgwqDC
oMKgwqDCoMKgwqAgd3JpdGVfbG9jaygmcGRldi0+ZG9tYWluLT52cGNpX3J3bG9jayk7DQo+Pj4+
DQo+Pj4+IGFuZCB0aGlzIHNob3VsZCBiZSBlbm91Z2gNCj4+PiBHaXZlbiB0aGUgY29udGV4dCBh
cHBseV9tYXAgaXMgY2FsbGVkIGZyb20gKGRvbTAgc3BlY2lmaWMgaW5pdCBjb2RlKSwNCj4+PiB0
aGVyZSdzIG5vIG5lZWQgdG8gY2hlY2sgZm9yIHRoZSBwZGV2IHRvIHN0aWxsIGV4aXRzLCBvciB3
aGV0aGVyIHZwY2kNCj4+PiBoYXMgYmVlbiByZWNyZWF0ZWQsIGFzIGl0J3Mgbm90IHBvc3NpYmxl
LiBKdXN0IGFkZCBhIGNvbW1lbnQgdG8NCj4+PiBleHBsaWNpdGx5IG5vdGUgdGhhdCB0aGUgY29u
dGV4dCBvZiB0aGUgZnVuY3Rpb24gaXMgc3BlY2lhbCwgYW5kIHRodXMNCj4+PiB0aGVyZSdzIG5v
IHBvc3NpYmlsaXR5IG9mIGVpdGhlciB0aGUgZGV2aWNlIG9yIHZwY2kgZ29pbmcgYXdheS4NCj4+
IERvZXMgaXQgcmVhbGx5IG5lZWQgd3JpdGVfdW5sb2NrL3dyaXRlX2xvY2sgZ2l2ZW4gdGhlIGNv
bnRleHQ/Li4uDQo+IEkgdGhpbmsgaXQncyBiYWQgcHJhY3RpY2UgdG8gY2FsbCBwcm9jZXNzX3Bl
bmRpbmdfc29mdGlycXMgd2hpbGUNCj4gaG9sZGluZyBhbnkgbG9ja3MuIFRoaXMgaXMgYSB2ZXJ5
IHNwZWNpZmljIGNvbnRleHQgc28gaXQncyBsaWtlbHkgZmluZQ0KPiB0byBub3QgZHJvcCB0aGUg
bG9jaywgYnV0IHdvdWxkIHN0aWxsIHNlZW0gaW5jb3JyZWN0IHRvIG1lLg0KT2sNCj4NCj4+IEkg
dGhpbmsgaXQgZG9lc24ndCBhcyB0aGVyZSBpcyBubyBjaGFuY2UgZGVmZXJfbWFwIGlzIGNhbGxl
ZCwgdGh1cw0KPj4gcHJvY2Vzc19wZW5kaW5nX3NvZnRpcnFzIC0+IHZwY2lfcHJvY2Vzc19wZW5k
aW5nIC0+IHJlYWRfbG9jaw0KPiBJbmRlZWQsIHRoZXJlJ3Mgbm8gY2hhbmNlIG9mIHRoYXQgYmVj
YXVzZSBwcm9jZXNzX3BlbmRpbmdfc29mdGlycXMNCj4gd2lsbCBuZXZlciB0cnkgdG8gZG8gYSBz
Y2hlZHVsaW5nIG9wZXJhdGlvbiB0aGF0IHdvdWxkIHJlc3VsdCBpbiBvdXINCj4gY29udGV4dCBi
ZWluZyBzY2hlZHVsZWQgb3V0Lg0KDQogwqDCoMKgIHdoaWxlICggKHJjID0gcmFuZ2VzZXRfY29u
c3VtZV9yYW5nZXMobWVtLCBtYXBfcmFuZ2UsICZkYXRhKSkgPT0gLUVSRVNUQVJUICkNCiDCoMKg
wqAgew0KIMKgwqDCoMKgwqDCoMKgIC8qDQogwqDCoMKgwqDCoMKgwqDCoCAqIEZJWE1FOiBHaXZl
biB0aGUgY29udGV4dCBhcHBseV9tYXAgaXMgY2FsbGVkIGZyb20gKGRvbTAgc3BlY2lmaWMNCiDC
oMKgwqDCoMKgwqDCoMKgICogaW5pdCBjb2RlIGF0IHN5c3RlbV9zdGF0ZSA8IFNZU19TVEFURV9h
Y3RpdmUpIGl0IGlzIG5vdCBzdHJpY3RseQ0KIMKgwqDCoMKgwqDCoMKgwqAgKiByZXF1aXJlZCB0
aGF0IHBkZXYtPmRvbWFpbi0+dnBjaV9yd2xvY2sgaXMgdW5sb2NrZWQgYmVmb3JlIGNhbGxpbmcN
CiDCoMKgwqDCoMKgwqDCoMKgICogcHJvY2Vzc19wZW5kaW5nX3NvZnRpcnFzIGFzIHRoZXJlIGlz
IG5vIGNvbnRlbnRpb24gcG9zc2libGUgYmV0d2Vlbg0KIMKgwqDCoMKgwqDCoMKgwqAgKiB0aGlz
IGNvZGUgYW5kIHZwY2lfcHJvY2Vzc19wZW5kaW5nIHRyeWluZyB0byBhY3F1aXJlIHRoZSBsb2Nr
IGluDQogwqDCoMKgwqDCoMKgwqDCoCAqIHJlYWQgbW9kZS4gQnV0IHJ1bm5pbmcgcHJvY2Vzc19w
ZW5kaW5nX3NvZnRpcnFzIHdpdGggYW55IGxvY2sgaGVsZA0KIMKgwqDCoMKgwqDCoMKgwqAgKiBk
b2Vzbid0IHNlZW0gdG8gYmUgYSBnb29kIHByYWN0aWNlLCBzbyBkcm9wIHRoZSBsb2NrIGFuZCBy
ZS1hY3F1aXJlDQogwqDCoMKgwqDCoMKgwqDCoCAqIGl0IHJpZ2h0IGFnYWluLg0KIMKgwqDCoMKg
wqDCoMKgwqAgKi8NCiDCoMKgwqDCoMKgwqDCoCB3cml0ZV91bmxvY2soJnBkZXYtPmRvbWFpbi0+
dnBjaV9yd2xvY2spOw0KIMKgwqDCoMKgwqDCoMKgIHByb2Nlc3NfcGVuZGluZ19zb2Z0aXJxcygp
Ow0KIMKgwqDCoMKgwqDCoMKgIHdyaXRlX2xvY2soJnBkZXYtPmRvbWFpbi0+dnBjaV9yd2xvY2sp
Ow0KIMKgwqDCoCB9DQoNCldpbGwgdGhpcyBiZSBnb29kIGVub3VnaD8NCj4NCj4gVGhhbmtzLCBS
b2dlci4NCj4NClRoYW5rIHlvdSwNCk9sZWtzYW5kcg==


From xen-devel-bounces@lists.xenproject.org Mon Feb 14 11:51:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 11:51:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271472.465916 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJZtJ-00053W-Tr; Mon, 14 Feb 2022 11:51:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271472.465916; Mon, 14 Feb 2022 11:51:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJZtJ-00053P-R0; Mon, 14 Feb 2022 11:51:37 +0000
Received: by outflank-mailman (input) for mailman id 271472;
 Mon, 14 Feb 2022 11:51:36 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Fl/D=S5=epam.com=prvs=4044f48eaf=oleksii_moisieiev@srs-se1.protection.inumbo.net>)
 id 1nJZtI-00053J-J1
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 11:51:36 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 75205ab6-8d8c-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 12:51:35 +0100 (CET)
Received: from pps.filterd (m0174683.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 21EBmegr031673;
 Mon, 14 Feb 2022 11:51:31 GMT
Received: from eur05-vi1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2174.outbound.protection.outlook.com [104.47.17.174])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3e7pbw0113-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Mon, 14 Feb 2022 11:51:31 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com (2603:10a6:102:ea::23)
 by DU2PR03MB8075.eurprd03.prod.outlook.com (2603:10a6:10:2e6::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.18; Mon, 14 Feb
 2022 11:51:28 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::c1c:f98:9dd:86e0]) by PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::c1c:f98:9dd:86e0%6]) with mapi id 15.20.4975.018; Mon, 14 Feb 2022
 11:51:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 75205ab6-8d8c-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Bj8z6vQ8CYDd8y69gXvlohtC1M62RL2s5q/gw6qMU14S/yOcWO5AYyXT7sY+wZyjvz7OP0sLPhe20Oa9jTlFu+rDfhLAz0OelUVbEW5eobYcmSzT1hbJODJFnwnFT9H3nlzAYwyFIIT1hzwZcK9SYJjM1SXMEmJmcI/sNhMnSnkbruqxGrTrlCWivW7LQZQXi6T9p6P8QikM9VQC1Wk9s4AARouvPqcRv1rsi8g9aC1dne5tNMVLGM8pBe1FCLX68zhr15yqakYy8y4XFYNdmfiYkbpNkKyOhGZ8mQuky2ahza0NKPfpasUEnJ93UM6QwoOoC/bc5OP25ma1gXufog==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Fst2D0zh1VI0gfzIlirfbmElXSEF3iy1BK0XTAg6il4=;
 b=FzSAZueLRN7UHdGoiX+aSGEjJSbFhJCmYge7AvSVnazPFp5+5GxlBl5Vqhg4dYhOglcmH+hoN/76V0Onthn2DOpG6MLTg/MC6GB98HF4vDdq7VanhoEIbU1v6QkkXZGZZx97KWnTd5j1CaUwXe3benChd6fE2XKYimiFluJSJefmbqLVQzqaFrFTa2afFx2WEjROCEKelANw2R1GuiLhLhYWWJovMM3k8mVu7DgRoX5neRoCYcwOHq1MRXL6GpLZia8exYLr6sWlvd7uQXe6tzg/h7PY9emFrqdGQKCej0jVNx0MrXvMIcIu1M/1sjtuWb84jpE6vOGlTpWCY1Yt2Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Fst2D0zh1VI0gfzIlirfbmElXSEF3iy1BK0XTAg6il4=;
 b=Oig+DFeLvIW7QlMsn8PiZ4a68kHvYkTeQwY3UpfOHH3A2kfxKIQn8IxtYc+/zZPJ8W/3h/7jRv4Il9nlDACOxwN31ZYnD3McW2nEdC+j0m9sGZYcJDKqO3vaegLc8TnQS+jIiqZHbuJXdKhGWEhJnPXc1nDR4VoY6Fl8/Pc4B1mIxJkK3wkOfIB82lsiZehnSE8DwpgRg3QE/3Jrf9cd+yvfvMw81GbQJtvd9cI2Prh/rO/KzTPBZSa8O2u/UxAo7czVSlyYbzPHSbJEuEH+V52t+AzUMK4y3Owo80LwlGgQZcxe9ETSwDFJxZmrc/mLj6eRq9DRNUtN6VFnGKLSSw==
From: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
To: Bertrand Marquis <bertrand.marquis@arm.com>
CC: Julien Grall <julien@xen.org>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        Stefano Stabellini
	<sstabellini@kernel.org>,
        Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [RFC v2 5/8] xen/arm: introduce SCMI-SMC mediator driver
Thread-Topic: [RFC v2 5/8] xen/arm: introduce SCMI-SMC mediator driver
Thread-Index: 
 AQHYHRW24Dmb0qV8ZkqAv39Pf6/nVayODW6AgAAg+ICAAAmzAIABqiEAgAMLQQCAAAQDgIAABruA
Date: Mon, 14 Feb 2022 11:51:28 +0000
Message-ID: <20220214115127.GA3637134@EPUAKYIW015D>
References: <cover.1644341635.git.oleksii_moisieiev@epam.com>
 <cb1493f5d9b5c3437268054b4a8e345cb35c8708.1644341635.git.oleksii_moisieiev@epam.com>
 <F9811680-C6EC-4372-A451-5C1DA279E35E@arm.com>
 <20220211104403.GA2291814@EPUAKYIW015D>
 <A9FF3FBC-C29D-4A17-8737-EBABEF240BA2@arm.com>
 <c13f6312-3922-4504-3248-e2e4701b1a10@xen.org>
 <20220214111300.GA3615313@EPUAKYIW015D>
 <E78206B4-3793-498E-A580-F0561DF6D4AC@arm.com>
In-Reply-To: <E78206B4-3793-498E-A580-F0561DF6D4AC@arm.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 915e20ac-91d6-4c85-2b03-08d9efb055be
x-ms-traffictypediagnostic: DU2PR03MB8075:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <DU2PR03MB80751B068CC52B2C9717EBD9E3339@DU2PR03MB8075.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 pQ0+pSBVf1iWNUhPgv9cjFL0PsmRQRDvk8lJK8mHbEimYCUyV4X3CnU4vMvbo6MqxsW9FcdNjeAb7GxGGQ6FCRGHg7+m/STxcDxuxkE/t2MYHlTeC9Qcyxnvt+hBUzNbjJgaTxpwlsFusctuJdXVrbktwGVxhSG6Gb6MYoFtYmZEBFERrqy3iM6afpn0WU+xys20zFxyCuL9w2oCWvESpPoX2lSSvrJJ+F1t0hrOtmk2sv0kdC5A8ndj1Gv62HO24yjSnCKEfFc0SpZFf5CiJDoPC62lDb6cxj2/sWztAMZGC2nVIb5pNCIZhvkLc3t+7Sm87WIarvADsujEsqmzvHkYknLDEIwMLcN6MF6hh/UTOzNMSI9+p463KITfJ2UzBmDQk0xs9jNqvwV9Y0P1h/4zR8oYUcdsiROsU44tHWRGsifLik2BMXzCuGj70qTyDpLJEc72afRePWvyy1nuu880tqFdB04q+pLTLslA1e3VxWqN3oNkWzJsWJicBVCwgC2i+eMtiP3sju3tgiOWitXadHf3KE9fdpVzkac152p7N7hpGn1bZrPki9zdXRtTI8rV6tuK3OkhfwU5/n3uWXNXEpCPM1oHTkudiW+QH0DOsMVdJwAYRR8FKUeC81PCRd86ljGELzwB00PNjA9cZVHX4O3OAUn5zd29sTadzSFYgx/l49DSZsFeyq+xYhm8/L2elyE+9XGFqJlEFoXEBPmM4fLn7JoseL5PVUMhMnKldohq6D2WZlvMMxfflFa8ix16X1Sfn5QppEvWMuxx2ZpcaIDIC636OKeszqimazygaCwQjsAg0D08WqhW/Pcux/iydGlnCk0a+EWaOL62pA==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR03MB7136.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(5660300002)(6512007)(9686003)(54906003)(508600001)(71200400001)(6506007)(53546011)(6486002)(966005)(76116006)(2906002)(8936002)(4326008)(91956017)(66446008)(83380400001)(316002)(107886003)(64756008)(6916009)(26005)(186003)(1076003)(38070700005)(33656002)(66476007)(86362001)(33716001)(38100700002)(66556008)(66946007)(122000001)(8676002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?NhUDcflhKkGT4aXt551GMhcbyKVm0dey5Hbb00gtIVIOb9xxO6OcxXvzlpSN?=
 =?us-ascii?Q?qhVRIH9ClHI5Mi/TrUlXaCo6ZTA33slLc71cnmCQeMOOBYbgnrpiFxbgRQHO?=
 =?us-ascii?Q?hhbwm0XlzwKRX56IYCMXC7ylEDHjGEG8OUM4IWDrdhrLm5khmranUcURIYxQ?=
 =?us-ascii?Q?KXCXa+527wIHbpiur/pxxlvOT0D5d/C6sRW6RDLGbOHeFUEqu2HHF4X3STWu?=
 =?us-ascii?Q?irb+62W37UQRAQ9dyQJBH4lyZ9QW3JdlXs0NnaVmmfNsiQNQK921UK6aTBeh?=
 =?us-ascii?Q?oKDb9HmroTX7FMUJYw/csnnd2d09kLG21PVCmzF3r4jtbbVJQrhvF+nrhI7Q?=
 =?us-ascii?Q?s5K0Y7cKT3hDGhCfF/XZS5EjoVpjSi8LtGaKo/dqJnHcPq6b9FZfV2R5q3iR?=
 =?us-ascii?Q?zoBo2i31vPywNw51fEi4tdf2hsSPbTYv4/uM3+8hSGW/GVa+HRODenHvwq3j?=
 =?us-ascii?Q?ccVAMkBR4QO2w3+bzIFYK6NACW9NAEkkwtwcx9Vj7EQ+jSnPG+BDXFdGqKMd?=
 =?us-ascii?Q?eep2gK687emA1swwPIAJca8jjMEX5WMS9tUgCyE8G3cxr1/uptUO4FwSJEmr?=
 =?us-ascii?Q?MqAcNiiT2Rc2YoYdd5Etf1V/N0Av53AfO4VwjWR2GIAm2638vyZEMEGaJhs0?=
 =?us-ascii?Q?uUFl7FwVBDD9wMD1O4vCiqESRilXKmBWgjcITUBFHJ4q69scOsmKV/foSffo?=
 =?us-ascii?Q?7NYV9pqbQiZCZt+58eXnpSbdV6oxDJ/bHuowBdUxn3CgXfxdf9Kdltw/Fqr2?=
 =?us-ascii?Q?fEhezvHTA/XQ3h3Ns7aQIogUFiBzt5eL5gIjRp//64/q5GOvmBbAFVRscIK0?=
 =?us-ascii?Q?gSa6uVI1iSJliz6pIe3ASnSJw86QxCsb0VBSqsoY+8Kr3plrEZLn/6027rib?=
 =?us-ascii?Q?dmHvsvGFm6Uv0T2gON0B8Axc9qD8nUZXXXaFayzcbzWfZ5YT17R/zB/WkAkW?=
 =?us-ascii?Q?OovmInHYdNQL3A1L0WD983g50MLC7DHjCvJMOS75D9kLJNXpEXWaI39QKojX?=
 =?us-ascii?Q?0Olqj0VpHvnF3OGO69SuUnTk517rP8hdCivN+kQrwyUhhewBWpmsjpsQHFpf?=
 =?us-ascii?Q?II6Q2/Bx4S76QmzrRIbqGcinfx7cx2M81YN/cq6pKRChafshXrfRoLuIyWiL?=
 =?us-ascii?Q?fLB/nWofTeMF42Xq55Zs8HhcwOV9MwotPWf8nFHFrJoyd5UTvmoz9lq0Sx1T?=
 =?us-ascii?Q?xKWo6N6m1LAJp6kdJyj7wWNFV0vbzqjOlbsGq8AlBf/MWnEr5COmbUACKmxH?=
 =?us-ascii?Q?HsWepI/YLfeuBwLFYwW7Cq4YiI+/a2QRBHlzplfA0nUOfW3S4kW6hje9aY23?=
 =?us-ascii?Q?ExKfhPqb06Tn2M5xPBtTopUoCqNxdMaliK+Jo9Bg/CnGA/Y13eTfB4luzBqs?=
 =?us-ascii?Q?46Pq0ZuhlJJWk9paytGWw6E0RaorQNMF6qfBYP/qOM6NwVWLJ/vQCmo5+mdd?=
 =?us-ascii?Q?CIhjns8pp7zR4+489qx3rO3VRxPYqD4w8r0FWZTEY2Q/imIPWHdfOJLWOvxx?=
 =?us-ascii?Q?br/ODcVbMV6gNEIAiz1w8c5FQX1cYO2TNHrAtZ6IVpfKoO1ZxvL7+fl0g8Ke?=
 =?us-ascii?Q?trUnmyV/j2C9KDoIoOkCGqoa/9HiNHxMzn3e5Sn3wIucu2bpcn7ru0L17+xX?=
 =?us-ascii?Q?Vv55qiyqrS6I81mN6Z09jw03/QTTiw4LeycjSaFAXBjs+w3JTbO9Lsa1f/Cq?=
 =?us-ascii?Q?gI+2FnOwBWFWmLlqI/EIe6A4bvY=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <B3483B31BF10154DB26867698D94DE45@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR03MB7136.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 915e20ac-91d6-4c85-2b03-08d9efb055be
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Feb 2022 11:51:28.0663
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Z/NWkY3MiNdp8NqoBRbLxeTLNv7TtrhDYFnKXdQ/xtmALs2krbG2oksJaRst/1ojjip8SrrF86ecH4QQ0EFb0dh87WIj5Mc1KDlqSZNZ7lA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR03MB8075
X-Proofpoint-GUID: you5i6Jk3vfZCT50tKfgK9dDCO_ktbdP
X-Proofpoint-ORIG-GUID: you5i6Jk3vfZCT50tKfgK9dDCO_ktbdP
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-14_04,2022-02-14_03,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501
 clxscore=1015 spamscore=0 mlxscore=0 bulkscore=0 adultscore=0
 lowpriorityscore=0 malwarescore=0 suspectscore=0 mlxlogscore=791
 phishscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2201110000 definitions=main-2202140072

Hi Bertrand,

On Mon, Feb 14, 2022 at 11:27:21AM +0000, Bertrand Marquis wrote:
> Hi Oleksii,
>=20
> > On 14 Feb 2022, at 11:13, Oleksii Moisieiev <Oleksii_Moisieiev@epam.com=
> wrote:
> >=20
> > Hi Julien,
> >=20
> > On Sat, Feb 12, 2022 at 12:43:56PM +0000, Julien Grall wrote:
> >> Hi,
> >>=20
> >> On 11/02/2022 11:18, Bertrand Marquis wrote:
> >>> Do you plan to add support for other boards ?
> >>>=20
> >>> Did you discuss more in general with the linux kernel guys to see if =
this
> >>> approach was agreed and will be adopted by other manufacturers ?
> >>>=20
> >>> All in all I think this is a good idea but I fear that all this will =
actually only
> >>> be used by one board or one manufacturer and other might use a differ=
ent
> >>> strategy, I would like to unrisk this before merging this in Xen.
> >>=20
> >> In the past we merged code that would only benefits one vendor (i.e. E=
EMI).
> >> That said, this was a vendor specific protocol. I believe the situatio=
n is
> >> different here because the spec is meant to be generic.
> >>=20
> >>> @julien and Stefano: what is your view here ?
> >>=20
> >> I share the same concerns as you. I think we need to make sure all the
> >> pieces we rely on (e.g. firmware, DT bindings) have been agreed before=
 we
> >> can merge such code in Xen.
> >>=20
> >> The first step is to have all the pieces available in public so they c=
an be
> >> reviewed and tested together.
> >>=20
> >> Oleksii, on a separate e-mail, you said you made change for ATF. How m=
uch of
> >> those changes was related to support for Xen? If they are some, then I=
 think
> >> they should be upstreamed first.
> >>=20
> >=20
> > Let me share changes, that were done to AT-F and Linux kernel
> > device-tree in terms of the SCMI mediator POC.
> > Changes to the Linux kernel:
> > https://urldefense.com/v3/__https://github.com/oleksiimoisieiev/arm-tru=
sted-firmware/pull/4__;!!GF_29dbcQIUBPA!je9Cu0n0498Yn76OLWjxxVaB7jWJtyWycHX=
0YARezTnc7aYHpGRJ8tSxHqIC0fTMUUSV$ [github[.]com]
> > Based on renesas-rcar linux-bsp, branch v5.10/rcar-5.0.0.rc5
> >=20
> > Changes to AT-F:
> > https://urldefense.com/v3/__https://github.com/oleksiimoisieiev/linux-b=
sp/pull/3__;!!GF_29dbcQIUBPA!je9Cu0n0498Yn76OLWjxxVaB7jWJtyWycHX0YARezTnc7a=
YHpGRJ8tSxHqIC0eDKS3ge$ [github[.]com]
> > Based on renesas-rcar/arm-trusted-firmware branch rcar_gen3_v2.5.
>=20
> You inverted the links but thanks this is really useful.
>=20

That's strange. Links looks good from xen.markmail.org interface.

> Did you push the ATF changes to mainstream ATF or discuss those with
> the maintainers ?

No. We did changes in ATF as a proof of concept.

>=20
> The strategy overall is nice but we need to make sure this is accepted an=
d
>  merged by all parties (ATF and Linux) to make sure the support for this =
will
> not only be available in Xen and for one board.

I've prepared patch to Linux kernel, which is introducing scmi_devid
binding, needed to set device permissions via SCMI. I've contacted
Sudeep Holla <sudeep.holla@arm.com>, who is the maintainer of the SCMI prot=
ocol
drivers. Waiting for the response.

Changes to ATF are not Xen specific and were done in terms of POC. We do
not have plans to upstream those changes right now.

>=20
> I will try to get in touch with the SCMI linux driver maintainer at arm t=
o get his view.
>=20

Thanks.

Best regards,
Oleksii.=


From xen-devel-bounces@lists.xenproject.org Mon Feb 14 12:23:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 12:23:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271482.465927 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJaNj-0008MZ-Em; Mon, 14 Feb 2022 12:23:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271482.465927; Mon, 14 Feb 2022 12:23:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJaNj-0008MS-Bu; Mon, 14 Feb 2022 12:23:03 +0000
Received: by outflank-mailman (input) for mailman id 271482;
 Mon, 14 Feb 2022 12:23:01 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=oHKf=S5=gmail.com=xadimgnik@srs-se1.protection.inumbo.net>)
 id 1nJaNh-0008MM-6b
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 12:23:01 +0000
Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com
 [2a00:1450:4864:20::433])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d9292226-8d90-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 13:23:00 +0100 (CET)
Received: by mail-wr1-x433.google.com with SMTP id d27so26534039wrc.6
 for <xen-devel@lists.xenproject.org>; Mon, 14 Feb 2022 04:23:00 -0800 (PST)
Received: from ?IPV6:2a00:23c5:5785:9a01:4cbc:cb8a:e37e:c1e9?
 ([2a00:23c5:5785:9a01:4cbc:cb8a:e37e:c1e9])
 by smtp.gmail.com with ESMTPSA id g8sm12786395wrd.9.2022.02.14.04.22.58
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Mon, 14 Feb 2022 04:22:59 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d9292226-8d90-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=message-id:date:mime-version:user-agent:reply-to:subject
         :content-language:to:cc:references:from:in-reply-to
         :content-transfer-encoding;
        bh=fiR81myXrw2bWyQUuNNbFZNkEWaXxpitBbAn0xHszvI=;
        b=NsPbT/5BxrqJ5rWob5lUVp71U9g97gxwVkM6PA45jzcc5vB8nmF3sM0DlWH3iJDOEu
         mIhp/324FdCT1KNc4QtQBK2wJd835/+zKv1ZO6mJUf7ptRoJsc+yStHXzMfiC1ZoZR7F
         lrBjfFVuTbXX0VQIECXsbl7RjL5wiNxWm9j/XvUZzJuq+Xvo+CX4DzK8CGXLATFzUrmF
         Vh9kj+6gZUDr+6ntiqdm8Xo9VMC158YSNU7XFw5wLODkBMdNMytDoiSGrxU6a+WEU+I9
         3bm2zDdNGIEKNyFliFKb7Ppq5kVVT0aieqVYjcJruHmqM03MguH/NQuRkj+xqTVvQZEJ
         6VVA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:message-id:date:mime-version:user-agent:reply-to
         :subject:content-language:to:cc:references:from:in-reply-to
         :content-transfer-encoding;
        bh=fiR81myXrw2bWyQUuNNbFZNkEWaXxpitBbAn0xHszvI=;
        b=nVSdG/0/aSimTQOJJht6U1+o7HmAF8hn2xA7EFgGyjkHH254v9IwrP8E060r+EhG1g
         lxqP64zIR9m7aeK36t7Dkb9iy/Zm+lK2y/lJ96fd/G3LGDZlKxCJmyAIJBzPLQvcUYbQ
         9EOnpNFOyCivPJVKRYo/eKsL2DNcnC4AlGYWaYMN2U6o6g3hPWN4vEcZ+utSfjVessSx
         er6cvebKRct3UFEyxrIclLwznYNEwmb3rhHz2OvJzDYBSsau1Jmlvw+9Nx2MQ5xOTFu0
         ktPargHja9ah1zBrfA8qe9ACVsDsRujbPgj4KWUk2S9Wb4XiLqh8r3lWffKnO44aGv+P
         LMMA==
X-Gm-Message-State: AOAM532EDotILb62XyLacLrN1ANES5sTHsxGMhJ3jmzx5y4SRmA5Dc72
	qZNJz2lOqYYWCtlNMdalYmg=
X-Google-Smtp-Source: ABdhPJzQZ9mp9Ecg+Z7inJuf8PgmrHQ0P/SA34vlx3AvWu3CCoodWPGLTU1jGZ6s3qtiqT4EXmYoSA==
X-Received: by 2002:a5d:47aa:: with SMTP id 10mr2762220wrb.459.1644841379596;
        Mon, 14 Feb 2022 04:22:59 -0800 (PST)
Message-ID: <c4a107f2-db1b-ff5a-65ab-62407a360e37@gmail.com>
Date: Mon, 14 Feb 2022 12:22:58 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Reply-To: paul@xen.org
Subject: Re: tools: propogate MTU to vif frontends (backporting)
Content-Language: en-US
To: James Dingwall <james-xen@dingwall.me.uk>, xen-devel@lists.xenproject.org
Cc: paul@xen.org
References: <20220214104826.GA1607026@dingwall.me.uk>
From: "Durrant, Paul" <xadimgnik@gmail.com>
In-Reply-To: <20220214104826.GA1607026@dingwall.me.uk>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 14/02/2022 10:48, James Dingwall wrote:
> Hi,
> 
> I've been backporting this series to xen 4.14 and everything relating to the
> backend seems to be working well.  For the frontend I can see the mtu value
> published to xenstore but it does't appear to be consumed to set the matching
> mtu in the guest.
> 
> https://lists.xenproject.org/archives/html/xen-devel/2020-08/msg00458.html
> 
> Is the expected solution a custom script running in the guest to make the
> necessary change or have I missed something in how this is supposed to
> operate?
> 

It depends on your guest. Linux happily gets the MTU from DHCP, but 
Windows does not. Hence:

https://xenbits.xen.org/gitweb/?p=pvdrivers/win/xenvif.git;a=blob;f=src/xenvif/mac.c;;hb=HEAD#l440

Cheers,

   Paul



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 12:37:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 12:37:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271489.465939 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJabp-0001T9-NN; Mon, 14 Feb 2022 12:37:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271489.465939; Mon, 14 Feb 2022 12:37:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJabp-0001T2-Jb; Mon, 14 Feb 2022 12:37:37 +0000
Received: by outflank-mailman (input) for mailman id 271489;
 Mon, 14 Feb 2022 12:37:36 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJabo-0001Ss-Rp; Mon, 14 Feb 2022 12:37:36 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJabo-00040a-MB; Mon, 14 Feb 2022 12:37:36 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJabo-0006sA-1x; Mon, 14 Feb 2022 12:37:36 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nJabo-0002e9-1Q; Mon, 14 Feb 2022 12:37:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=TRS8IyWXdAB+oIrpjWrJFvjGJsQRny7V2aGe1Qy4diE=; b=gd78mr/iG3QVdJ19hljqXc6zA3
	ybg0EwkVFJzf/q8c21WxFh3TA9H0bA3FnxWvXr7eKYoq4P+yqBCDNNyUIVP03/fli4tIc2GXwdn0o
	Mirr4lZz5ilZscM1bArEpyvHWl8qzcjR0+KE+vN6iII7Gd2YjEg+SGzNBm8NLHMaRX78=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168105-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 168105: trouble: blocked/broken/fail/pass
X-Osstest-Failures:
    xen-unstable:build-arm64:<job status>:broken:regression
    xen-unstable:build-arm64-pvops:<job status>:broken:regression
    xen-unstable:build-arm64-xsm:<job status>:broken:regression
    xen-unstable:build-arm64-pvops:host-install(4):broken:regression
    xen-unstable:build-arm64-xsm:host-install(4):broken:regression
    xen-unstable:build-arm64:host-install(4):broken:regression
    xen-unstable:test-arm64-arm64-examine:build-check(1):blocked:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    xen-unstable:test-arm64-arm64-xl:build-check(1):blocked:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking
    xen-unstable:build-arm64-libvirt:build-check(1):blocked:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=87319afb96973213ec0a76270d93696f3b8d6743
X-Osstest-Versions-That:
    xen=87319afb96973213ec0a76270d93696f3b8d6743
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 14 Feb 2022 12:37:36 +0000

flight 168105 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168105/

Failures and problems with tests :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-arm64                     <job status>                 broken
 build-arm64-pvops               <job status>                 broken
 build-arm64-xsm                 <job status>                 broken
 build-arm64-pvops             4 host-install(4)        broken REGR. vs. 168081
 build-arm64-xsm               4 host-install(4)        broken REGR. vs. 168081
 build-arm64                   4 host-install(4)        broken REGR. vs. 168081

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-examine      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl           1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit1   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit2   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-seattle   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-thunderx  1 build-check(1)               blocked  n/a
 build-arm64-libvirt           1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-vhd       1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-xsm       1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail like 168088
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168096
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168096
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168096
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168096
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168096
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168096
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168096
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168096
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168096
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168096
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168096
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168096
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  87319afb96973213ec0a76270d93696f3b8d6743
baseline version:
 xen                  87319afb96973213ec0a76270d93696f3b8d6743

Last test of basis   168105  2022-02-14 01:51:55 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              broken  
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  broken  
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          blocked 
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            broken  
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          blocked 
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      blocked 
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  blocked 
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  blocked 
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     blocked 
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 blocked 
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      blocked 
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary

broken-job build-arm64 broken
broken-job build-arm64-pvops broken
broken-job build-arm64-xsm broken
broken-step build-arm64-pvops host-install(4)
broken-step build-arm64-xsm host-install(4)
broken-step build-arm64 host-install(4)

Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 12:51:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 12:51:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271503.465983 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJape-0004Uu-Un; Mon, 14 Feb 2022 12:51:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271503.465983; Mon, 14 Feb 2022 12:51:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJape-0004U6-Pt; Mon, 14 Feb 2022 12:51:54 +0000
Received: by outflank-mailman (input) for mailman id 271503;
 Mon, 14 Feb 2022 12:51:53 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJapd-0003jk-Dh
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 12:51:53 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e113971b-8d94-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 13:51:51 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e113971b-8d94-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644843111;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=OM1G6c/BDHwKCEjd4XaBXduFB7GfRa2QTRUE5y+VtvI=;
  b=I9b5R5jBLFqhk5tgOpGizR7lsaaH5Hbb7S5/Kgqmce23ynZTM8y2xA8b
   PnYOch9sXd5SZn0UE4Ms2T0ZavPIiDMqMCxun/WAnkTigOlgw5qvCkt2f
   GRIY3eS/0XAoqDIWz9wrzoFqfLhRAxy0tnJIq8NlDHKp3UzZCnNIkG97U
   U=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: bMVoiWl/SqiephNQZZdM0jr+KyVglX9h9DTAuRNTCIiLqueZt+NbwSDLC87RExF/DKY0E2LLi7
 VxNv0TYS77xL+lUtl9j3Y/DsmlH3DzjAJqcI0FcNBQQhZQtlKVTYqBS9B8+y7YJR2RIIiHJA/q
 mktrqta4Pj4xG51lZmNUM/ExSMtTMBbdvtGjLVx0nh63fsdOvpBE6cL6yd9iaB5c4BEf9WtDEV
 OHFI7Q+50beCDZeLXEx9+F+8cwlUdkGy5+80Y9YeYDwvc6MjDM8Uh2OBOG4LWszVFJZwM642Pp
 T9E7rXgPS10tsEwL5uUY3kZa
X-SBRS: 5.1
X-MesageID: 64148317
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:HX3pta0YVdWs3LQelvbD5cx2kn2cJEfYwER7XKvMYLTBsI5bp2AGz
 jEWWGHVb/3ZYDT3e9sjPo62/EsEsZ+ByoVmGws/pC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkS5PE3oHJ9RGQ74nRLlbHILOCanAZqTNMEn9700o5wrJh2+aEvPDia++zk
 YKqyyHgEAfNNw5cagr4PIra9XuDFNyr0N8plgRWicJj5TcypFFMZH4rHomjLmOQf2VhNrXSq
 9Avbl2O1jixEx8FUrtJm1tgG6EAaua60QOm0hK6V0U+6/TrS+NbPqsTbZIhhUlrZzqhrvshx
 4tm5JyLFlkrZuqcur8SDRlVHHQrVUFG0OevzXmXtMWSywvNcmf2wuUoB0YzVWEa0r8pWycUr
 6VecW1TKEDY7w616OvTpu1Er8IvNsT0eqgYvWlt12rxBvc6W5HTBa7N4Le02R9u2pkSTa2HO
 KL1bxJJMC3nZBkfB24eUrdg29+XmXPSbR9X/Qf9Sa0fvDGIkV0ZPKLWGMrYfJmGSNtYmm6cp
 3na5CLpDxcCLtudxDGZtHW2iYfycTjTAdxIUufir7gz3QPVljd75AAquUWTkNLphRCVCtJkd
 BIWom1+j/M9qkymQYyoN/Gnm0KsshkZUttWNuQ17gCR16bZizqk6ng4oi1pM4J/6pJvLdA+/
 hrQxo6yW2Qz2FGAYS/Frt+pQSWO1T/5xIPoTQsNVkM77tbqu+nfZTqfH484QMZZYjAYcAwcI
 gxmTgBj3d3/buZRjs1XGGwrZBr2+PD0ovYdvFm/Y45cxloRiHSZT4Kp80PHyv1LMZyUSFKM1
 FBdxZTCs7BeUMzVzXfXKAnoIF1Oz6zbWAAwfHY1R8Vxn9hT0yLLkX9sDMFWex4yb5dslc7Ba
 07PowJBjKK/z1PxBZKbl7mZUpxwpYC5TIyNfqmNMrJmP8ggHCfarXoGTRPBgAjQfL0EzPhX1
 WGzKp33Ux73yM1PkVKLegvq+eF3mH5unz6PLX05pjz+uYejiLeuYe9tGDOzgioRtctoeS3Zr
 IRSMdWk0RJaXLGsayXb69dLf1sLMWI6Fdb9rMkOLryPJQ9vGWcADf7NwOx+J9w5zvoNzuqYr
 GugXkJ4yUbkgSGVIwu9dX0+OqjkWoxyrCxnMHV0b0qowXUqfa2m8LwbK8ksZbAi+eE6lax0Q
 vAJdt+uGPNKTjibqT0RYYOk9N5pdQixhBLINC2gOWBtc5llTg3P29nlYgqwq3VeUnvp7ZMz+
 uTy2BnaTJwPQxVZIPzXMP//nUmsuXU9mf5pWxeaKNdkZ0ixopNhLDb8j6FrLphUewnD3DaTy
 y2fHQwc+bvWu4Yw/dTE2fKEooOuH7csF0ZWBTCGv7O/NC2c9Wu/245QFu2PeGmFBm/z/ayjY
 8RTzu39b6JbzAob7dIkHuY517866vvuu6Ren1ZtE3j8Zli2Dq9tfyud1s5Vu6wRnrJUtGNag
 K5UFgW27VlRBP7YLQ==
IronPort-HdrOrdr: A9a23:f2vcC66UM7Gkg5Ht3APXwMzXdLJyesId70hD6qkXc20zTiX4rb
 HLoB1/73TJYVkqNE3I9eruBEDiexPhHPxOj7X5VI3KNGOKhILCFuBfxLqn7zr8GzDvss5xvJ
 0QFpSW0eeAbmSSW/yKgjWFLw==
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="64148317"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v2 01/70] xen/domain: Improve pirq handling
Date: Mon, 14 Feb 2022 12:50:18 +0000
Message-ID: <20220214125127.17985-2-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

free_pirq_struct() has no external users, so shouldn't be exposed.  Making it
static necessistates moving the function as domain_destroy() uses it.

Rework pirq_get_info() to have easier-to-follow logic.  The one functional
change is to the insertion failure path; we should not be using a full
call_rcu() chain to free an otherwise local structure we failed to insert into
the radix tree to begin with.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
v2:
 * Drop likely/unlikey
---
 xen/common/domain.c      | 62 ++++++++++++++++++++++++++----------------------
 xen/include/xen/domain.h |  1 -
 2 files changed, 33 insertions(+), 30 deletions(-)

diff --git a/xen/common/domain.c b/xen/common/domain.c
index 2048ebad86ff..571ef4fe615e 100644
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -365,6 +365,39 @@ static int __init parse_extra_guest_irqs(const char *s)
 }
 custom_param("extra_guest_irqs", parse_extra_guest_irqs);
 
+static void _free_pirq_struct(struct rcu_head *head)
+{
+    xfree(container_of(head, struct pirq, rcu_head));
+}
+
+static void free_pirq_struct(void *ptr)
+{
+    struct pirq *pirq = ptr;
+
+    call_rcu(&pirq->rcu_head, _free_pirq_struct);
+}
+
+struct pirq *pirq_get_info(struct domain *d, int pirq)
+{
+    struct pirq *info = pirq_info(d, pirq);
+
+    if ( info )
+        return info;
+
+    info = alloc_pirq_struct(d);
+    if ( !info )
+        return NULL;
+
+    info->pirq = pirq;
+    if ( radix_tree_insert(&d->pirq_tree, pirq, info) == 0 )
+        return info; /* Success. */
+
+    /* Don't use call_rcu() to free a struct we failed to insert. */
+    _free_pirq_struct(&info->rcu_head);
+
+    return NULL;
+}
+
 /*
  * Release resources held by a domain.  There may or may not be live
  * references to the domain, and it may or may not be fully constructed.
@@ -1780,35 +1813,6 @@ long do_vm_assist(unsigned int cmd, unsigned int type)
 }
 #endif
 
-struct pirq *pirq_get_info(struct domain *d, int pirq)
-{
-    struct pirq *info = pirq_info(d, pirq);
-
-    if ( !info && (info = alloc_pirq_struct(d)) != NULL )
-    {
-        info->pirq = pirq;
-        if ( radix_tree_insert(&d->pirq_tree, pirq, info) )
-        {
-            free_pirq_struct(info);
-            info = NULL;
-        }
-    }
-
-    return info;
-}
-
-static void _free_pirq_struct(struct rcu_head *head)
-{
-    xfree(container_of(head, struct pirq, rcu_head));
-}
-
-void free_pirq_struct(void *ptr)
-{
-    struct pirq *pirq = ptr;
-
-    call_rcu(&pirq->rcu_head, _free_pirq_struct);
-}
-
 struct migrate_info {
     long (*func)(void *data);
     void *data;
diff --git a/xen/include/xen/domain.h b/xen/include/xen/domain.h
index 160c8dbdab33..b4d202fda9fd 100644
--- a/xen/include/xen/domain.h
+++ b/xen/include/xen/domain.h
@@ -44,7 +44,6 @@ void free_vcpu_struct(struct vcpu *v);
 #ifndef alloc_pirq_struct
 struct pirq *alloc_pirq_struct(struct domain *);
 #endif
-void free_pirq_struct(void *);
 
 /*
  * Initialise/destroy arch-specific details of a VCPU.
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 12:51:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 12:51:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271501.465961 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJapd-0003zk-9Q; Mon, 14 Feb 2022 12:51:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271501.465961; Mon, 14 Feb 2022 12:51:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJapd-0003zd-6Q; Mon, 14 Feb 2022 12:51:53 +0000
Received: by outflank-mailman (input) for mailman id 271501;
 Mon, 14 Feb 2022 12:51:51 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJapb-0003jk-Lc
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 12:51:51 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id defbff4d-8d94-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 13:51:49 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: defbff4d-8d94-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644843109;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=pkih7ZsMQp5X2IhcDlZLwpA1su4gAvfwPCKXwyjRwo8=;
  b=RBu5lWIflALOdDtAcjiIrp27xqBqWk4RURdPc2etHdjNH4hxn1QFQ45b
   e8gDoMK9epKixAl1w4ks6Lm3nwEVFgYDnEnKQsA/qjpn8BccMMYJ/bgER
   zCfFIDGEx8KxBLGk7Nwx1IFPJMaopuYMgY9MMoSFhqvcyJnQ12eApgCtN
   g=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: laa0lK+0JjaWzClqAAaAldTnDTe1D9EinE+gsidtVsx+0tM8A419Q6TNow1WxzBGMUyfgzu709
 423ZM5mSYKngLY7UPC3rY0S5u72Xhg/OwP1p6uA2t0wo9SqDjkRGDH8Cz75WI6PmZ96F0ls3km
 ZHCrJLYCL+CvzsapoCu4dWjVPKbgaGr32tNmLy2DFTMOYbXSHwKSOxMx+xozbCGF/M9dB0NbnJ
 OItCR/WWYkQVPifTChW/nJ6i2zYXBAm9nm9uaslefP9XOEYZZy+h4K1Gp9awtN02dHGcWf0cgQ
 g1JS2YjxOeiAk/TkzowbPPb1
X-SBRS: 5.1
X-MesageID: 63591037
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Mo1cOqoX1Qa+BZ11yenAXQEvu05eBmLNYhIvgKrLsJaIsI4StFCzt
 garIBmGbv2NYmf3et91Ptu3pxsDv5SDmNQyGgo4rnxnE3kXp5uZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlZT4vE2xbuKU5NTsY0idfic5Dndx4f5fs7Rh2NQw24HlW1rlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCnceeGBoVI/HIpM86ShtGHCghP6Fn/KCSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFKoZtmtt0nfyCvE+TIqYa67L+cVZzHE7gcUm8fP2O
 ZFEOGM3N0uojxtnCAk0V70ulcmUt3jYd3pdtlPJmu0Syj2GpOB2+Oe0a4eEEjCQfu1Zhl2dp
 37G123hDwsGKceEzj6Y7nOrgPSJliT+MKoeG7G1+eRjqEGCzWwUThsNXB20pufRol6zXZdTJ
 lIZ/gIqrLMu7wq7Q9/lRRq6rXWY+BkGVLJt//YSsV/XjPCOukDAWzZCHmUphMEaWNEeHhJ7y
 2OUw9fVLht2sqOaQC2f+paQsmbnUcQKFlMqaSgBRAoDxtDspoAvkx7CJupe/L6JYs7dQm+pn
 W3TxMQqr/BK1JNQif3nlbzSq2/0/vD0ohgJChI7t45Pxidwf8abaoOh8jA3Bt4Qfd/CHjFtU
 JXp8vVyDdzi77nQzkRho81XRdlFAspp1xWG3zZS82EJrWjFxpJaVdk4DMtCDEloKN0YXjTif
 VXevwhcjLcKYif2Mv8nPt/pUp9wpUQFKTgCfqqKBuein7ArLFPXlM2QTRL4M5/RfLgEzvhkZ
 MbznTeEBncGE6V3pAdatM9GuYLHMhsWnDuJLbiilkzP+ePHOBa9FOdUWHPTP7tRxP7V/23oH
 yN3apLiJ+N3C7alPEE6MOc7cDg3EJTMLc6q+pIHLrbZemKL2ggJUpfs/F/oQKQ994w9qwsC1
 ivVtpZwxAWtiHvZBx+Nb3w/OrrjUYwm9SAwPDA2PEbu0H8mON794KAafpoxXL8m6O08kqIkE
 6hbI52NUqZVVzDK2zUBdp2h/oZsQwum2FCVNC2/bTlhI5M5H17V+sXpdxfE/TUVCnblrtM3p
 rCtj1uJQZcKSwl4ItzRbfajkwG4sXQHwbogVErUONhDPk7r9dEyeSD2i/Y2JeAKKAnCmWTGh
 1rHX09AqLCU8YEv8dTPiaSVlKuTErNzThhAAm3WzbeqLi2GrGCt9pBNDbSTdjfHWWKqpKj7P
 bdJz+vxOeEslUpRt9YuCK5iyK8z6oe9p7JeyQg4TnzHY07yV+FlK3iCm8JOqrdM1vlSvg7vA
 hCD/dxTOLOoPsL5EQFOeFp5P7rbjfxEyCPP6fkVIVnh4H4l9bWKZkxeIh2QhXEPN7ByKo4kn
 b8stcN+B9ZTUfb23gJqVhxpylk=
IronPort-HdrOrdr: A9a23:trI3O6+l3qfOOfUeqKJuk+DaI+orL9Y04lQ7vn2YSXRuHPBw9v
 re5cjzuiWVtN98Yh0dcJW7Scy9qBDnhPhICOsqTNSftWDd0QPCRuxfBMnZslnd8kXFh4lgPM
 xbEpSWZueeMbEDt7eZ3DWF
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="63591037"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Daniel De Graaf
	<dgdegra@tycho.nsa.gov>, Daniel Smith <dpsmith@apertussolutions.com>
Subject: [PATCH v2 03/70] xen/xsm: Move {do,compat}_flask_op() declarations into a header
Date: Mon, 14 Feb 2022 12:50:20 +0000
Message-ID: <20220214125127.17985-4-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

Declaring sideways like this is unsafe, because the compiler can't check that
the implementaton in flask_op.c still has the same type.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Daniel De Graaf <dgdegra@tycho.nsa.gov>
CC: Daniel Smith <dpsmith@apertussolutions.com>

v2:
 * Rework in the face of no useful progress on the better fix.
---
 xen/xsm/flask/flask_op.c | 1 +
 xen/xsm/flask/hooks.c    | 4 +---
 xen/xsm/flask/private.h  | 9 +++++++++
 3 files changed, 11 insertions(+), 3 deletions(-)
 create mode 100644 xen/xsm/flask/private.h

diff --git a/xen/xsm/flask/flask_op.c b/xen/xsm/flask/flask_op.c
index 221ff00fd3cc..bb3bebc30e01 100644
--- a/xen/xsm/flask/flask_op.c
+++ b/xen/xsm/flask/flask_op.c
@@ -21,6 +21,7 @@
 #include <avc_ss.h>
 #include <objsec.h>
 #include <conditional.h>
+#include "private.h"
 
 #define ret_t long
 #define _copy_to_guest copy_to_guest
diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c
index 3b29f7fde372..6ff1be28e4a4 100644
--- a/xen/xsm/flask/hooks.c
+++ b/xen/xsm/flask/hooks.c
@@ -36,6 +36,7 @@
 #include <avc_ss.h>
 #include <objsec.h>
 #include <conditional.h>
+#include "private.h"
 
 static u32 domain_sid(const struct domain *dom)
 {
@@ -1742,9 +1743,6 @@ static int flask_argo_send(const struct domain *d, const struct domain *t)
 
 #endif
 
-long do_flask_op(XEN_GUEST_HANDLE_PARAM(void) u_flask_op);
-int compat_flask_op(XEN_GUEST_HANDLE_PARAM(void) u_flask_op);
-
 static const struct xsm_ops __initconstrel flask_ops = {
     .security_domaininfo = flask_security_domaininfo,
     .domain_create = flask_domain_create,
diff --git a/xen/xsm/flask/private.h b/xen/xsm/flask/private.h
new file mode 100644
index 000000000000..73b0de87245a
--- /dev/null
+++ b/xen/xsm/flask/private.h
@@ -0,0 +1,9 @@
+#ifndef XSM_FLASK_PRIVATE
+#define XSM_FLASK_PRIVATE
+
+#include <public/xen.h>
+
+long do_flask_op(XEN_GUEST_HANDLE_PARAM(void) u_flask_op);
+int compat_flask_op(XEN_GUEST_HANDLE_PARAM(void) u_flask_op);
+
+#endif /* XSM_FLASK_PRIVATE */
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 12:51:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 12:51:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271500.465949 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJapb-0003jx-Vf; Mon, 14 Feb 2022 12:51:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271500.465949; Mon, 14 Feb 2022 12:51:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJapb-0003jq-Se; Mon, 14 Feb 2022 12:51:51 +0000
Received: by outflank-mailman (input) for mailman id 271500;
 Mon, 14 Feb 2022 12:51:50 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJapa-0003jd-Dm
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 12:51:50 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id dd86c4bb-8d94-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 13:51:47 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dd86c4bb-8d94-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644843108;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=aXXIf+NNN0QNk4zfqFs4eP6IyzxPbQMRw4LdRyX5iLE=;
  b=DLn+ya2af5u4QtUc1x13c/XqDhf1fGdxxiGJLYCSVLlpICWC9mY+NXz0
   Mk7wcVXLuwbteeOLN11tIq18UWYPnWwz6+CPiMgy4zV63LBpKFnzGjvsn
   SMXKeAc2PzvtztRjVkjOO+PQD6OyDvfyji6WmcmkR4PcFLqIlUPTn2VDT
   Q=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: JUo4Vd3pfWa8T/jVOep+89YwoUs2d7+ivu7Rcedm30U9L93QAmJj3deGVoZiN3Fe8jL8JI5s3u
 4/puwCUfVqCWZSy/P3twSEYNjYwy9njJhXFAeG0lQRXpTuovLJCb04Th2Oh0eCFmzyokEO359f
 SDQrj1MO4Cs1CdWigft0Bnjq7kPZgNV5E+hqLoMqAzfSfnPHnRUtgk8z0oLbVJayvGqcZhC6J7
 5sqCCY2kVV0v8THKKOGgIFXXTyrPUCSjgHBimhX1rUPeW0RP49WwsAtDgOlh5oraD5EilFIWQy
 8EftccNWIhriLpMoDfdvkJBn
X-SBRS: 5.1
X-MesageID: 64148059
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:rOj1sKsrj3R06oxB0P+t65vbz+fnVMtZMUV32f8akzHdYApBsoF/q
 tZmKWiOPq7YY2r0L90lO462/RsDvMLVn943TQdlryBkFSwV+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZQP0VOZigHtIQMsadUsxKbVIiGHdJZS5LwbZj2NYy2IThWmthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 Nplioa9WRoTOIT2qv03VzhjCxlleqJL0eqSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DFYUToHx/ixreCu4rW8vrSKTW/95Imjw3g6iiGN6AO
 5NFOWIyPXwsZTVvKBQPEZAbwdyLh3zjXSF/knnNv5c4tj27IAtZj+G2bYu9lsaxbcdImkeVo
 ErW8mK/BQsVXPShzj6C/mOpl/X4tyrxU4IPF5W17vdvxlaUwwQ7AhAMSUGyp/X/j0ekQs9eM
 GQd4C9opq83nGS0SvHtUhv+p2SL1jYMVtwVH+Ak5QWlzqvP/x3fFmUCViRGatEtqIkxXzNC/
 n2jks7tBDdvmKaIUn/b/bCRxRupIjQcJ2IGYS4CTCMG7sPlrYV1iQjAJuuPC4bs0IezQ2uph
 WnX8m5u3N3/kPLnyY2E513Xngiqj6L7VyQxxz7PZnni4Q5QMdvNi5OT1XDX6vNJLYC8R1aHv
 WQZl8X20N3iHa1hhwTWHrxTQejBC+KtdWSF3AUxR8VJGyGFpib7Fb289g2SM6uA3iwsXTbyK
 HHetgpKjHO4FCv7NPQnC25d5ilD8EQBKTgHfq2OBjatSsIoHONiwM2JTRTOt10BaGB2zckC1
 W6zKK5A90oyB6V91yaRTOwAy7ItzS1W7TqNGcykn0T6jOLHPyT9pVI53LymNL5R0U95iF+Nr
 4Y32zWil32zr9ESkgGIqNVOfDjm3FAwBIzsqtw/SwJwClEOJY3VMNeImelJU9U8x8x9z76Ul
 lngCh4w4Aeu3hXvdFTVAk2PnZuyBP6TW1pgZndyVbtpslB+CbuSAFA3KcdmI+l/rLY7pRO2J
 tFcE/i97j10Ymyv01wggVPV9uSOrTyn2lCDOTSLej86c8IyTgDF4Ia8LADu6DMPHmy8ss5n+
 ++s0QbSQJwiQQV+DZmJNKLzng3p5XVNyvhvW0boI8VIfBm++oZdNCGs3OQ8JNsBKEufy2LCh
 RqWGxoRucLEv5QxrIvSnamBoorwS7l+E0NWEnP197GzMSWGrGOvzZUZCLSDfCzHVXOy86KnP
 L0Hw/b5OfwBvVBLr4sjTOo7kfNgv4Pi/uYIwB5lEXPHa0WQJolhenTWj9NSsqBtx6NCvVfkU
 Ey45dQHa66CP9noEQBNKVN9PPiDz/wdhhLb8e8xfBfh/CZy8beKDRdSMh2LhHAPJbd5Ktp4k
 +IoucpQ4A2jkBs6dN2Bi3kMpWiLK3UBVYQht40bX9C32lZ6lAkabMyOEDLy7bGOd85IYxsjL
 TKjjabfg6hRmxjZeH0pGHmRhedQiPziYvyRIIPu87hRpuf4uw==
IronPort-HdrOrdr: A9a23:l6iu4qsnagOUOA9OLGPnExlv7skDTtV00zEX/kB9WHVpmszxra
 6TdZMgpGbJYVcqKRcdcL+7WJVoLUmxyXcx2/h1AV7AZniAhILLFvAA0WKK+VSJcEeSygce79
 YFT0EXMqyJMbEQt6fHCWeDfOrIuOP3kpyVuQ==
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="64148059"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>
Subject: [PATCH v2 02/70] xen/sort: Switch to an extern inline implementation
Date: Mon, 14 Feb 2022 12:50:19 +0000
Message-ID: <20220214125127.17985-3-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

There are exactly 3 callers of sort() in the hypervisor.  Callbacks in a tight
loop like this are problematic for performance, especially with Spectre v2
protections, which is why extern inline is used commonly by libraries.

Both ARM callers pass in NULL for the swap function, and while this might seem
like an attractive option at first, it causes generic_swap() to be used, which
forced a byte-wise copy.  Provide real swap functions so the compiler can
optimise properly, which is very important for ARM downstreams where
milliseconds until the system is up matters.

No functional change.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>
CC: Stefano Stabellini <sstabellini@kernel.org>
CC: Julien Grall <julien@xen.org>
CC: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
CC: Bertrand Marquis <bertrand.marquis@arm.com>

v2:
 * Adjust commit message
---
 xen/arch/arm/bootfdt.c |  9 +++++-
 xen/arch/arm/io.c      |  9 +++++-
 xen/include/xen/sort.h | 55 +++++++++++++++++++++++++++++++++-
 xen/lib/sort.c         | 80 ++------------------------------------------------
 4 files changed, 72 insertions(+), 81 deletions(-)

diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c
index afaa0e249b71..e318ef960386 100644
--- a/xen/arch/arm/bootfdt.c
+++ b/xen/arch/arm/bootfdt.c
@@ -448,6 +448,13 @@ static int __init cmp_memory_node(const void *key, const void *elem)
     return 0;
 }
 
+static void __init swap_memory_node(void *_a, void *_b, size_t size)
+{
+    struct membank *a = _a, *b = _b;
+
+    SWAP(*a, *b);
+}
+
 /**
  * boot_fdt_info - initialize bootinfo from a DTB
  * @fdt: flattened device tree binary
@@ -472,7 +479,7 @@ size_t __init boot_fdt_info(const void *fdt, paddr_t paddr)
      * the banks sorted in ascending order. So sort them through.
      */
     sort(bootinfo.mem.bank, bootinfo.mem.nr_banks, sizeof(struct membank),
-         cmp_memory_node, NULL);
+         cmp_memory_node, swap_memory_node);
 
     early_print_info();
 
diff --git a/xen/arch/arm/io.c b/xen/arch/arm/io.c
index 729287e37c59..1a066f9ae502 100644
--- a/xen/arch/arm/io.c
+++ b/xen/arch/arm/io.c
@@ -80,6 +80,13 @@ static int cmp_mmio_handler(const void *key, const void *elem)
     return 0;
 }
 
+static void swap_mmio_handler(void *_a, void *_b, size_t size)
+{
+    struct mmio_handler *a = _a, *b = _b;
+
+    SWAP(*a, *b);
+}
+
 static const struct mmio_handler *find_mmio_handler(struct domain *d,
                                                     paddr_t gpa)
 {
@@ -170,7 +177,7 @@ void register_mmio_handler(struct domain *d,
 
     /* Sort mmio handlers in ascending order based on base address */
     sort(vmmio->handlers, vmmio->num_entries, sizeof(struct mmio_handler),
-         cmp_mmio_handler, NULL);
+         cmp_mmio_handler, swap_mmio_handler);
 
     write_unlock(&vmmio->lock);
 }
diff --git a/xen/include/xen/sort.h b/xen/include/xen/sort.h
index a403652948e7..01479ea44606 100644
--- a/xen/include/xen/sort.h
+++ b/xen/include/xen/sort.h
@@ -3,8 +3,61 @@
 
 #include <xen/types.h>
 
+/*
+ * sort - sort an array of elements
+ * @base: pointer to data to sort
+ * @num: number of elements
+ * @size: size of each element
+ * @cmp: pointer to comparison function
+ * @swap: pointer to swap function or NULL
+ *
+ * This function does a heapsort on the given array. You may provide a
+ * swap function optimized to your element type.
+ *
+ * Sorting time is O(n log n) both on average and worst-case. While
+ * qsort is about 20% faster on average, it suffers from exploitable
+ * O(n*n) worst-case behavior and extra memory requirements that make
+ * it less suitable for kernel use.
+ */
+#ifndef SORT_IMPLEMENTATION
+extern gnu_inline
+#endif
 void sort(void *base, size_t num, size_t size,
           int (*cmp)(const void *, const void *),
-          void (*swap)(void *, void *, size_t));
+          void (*swap)(void *, void *, size_t))
+{
+    /* pre-scale counters for performance */
+    size_t i = (num / 2) * size, n = num * size, c, r;
+
+    /* heapify */
+    while ( i > 0 )
+    {
+        for ( r = i -= size; r * 2 + size < n; r = c )
+        {
+            c = r * 2 + size;
+            if ( (c < n - size) && (cmp(base + c, base + c + size) < 0) )
+                c += size;
+            if ( cmp(base + r, base + c) >= 0 )
+                break;
+            swap(base + r, base + c, size);
+        }
+    }
+
+    /* sort */
+    for ( i = n; i > 0; )
+    {
+        i -= size;
+        swap(base, base + i, size);
+        for ( r = 0; r * 2 + size < i; r = c )
+        {
+            c = r * 2 + size;
+            if ( (c < i - size) && (cmp(base + c, base + c + size) < 0) )
+                c += size;
+            if ( cmp(base + r, base + c) >= 0 )
+                break;
+            swap(base + r, base + c, size);
+        }
+    }
+}
 
 #endif /* __XEN_SORT_H__ */
diff --git a/xen/lib/sort.c b/xen/lib/sort.c
index 35ce0d7abdec..b7e78cc0e8d2 100644
--- a/xen/lib/sort.c
+++ b/xen/lib/sort.c
@@ -4,81 +4,5 @@
  * Jan 23 2005  Matt Mackall <mpm@selenic.com>
  */
 
-#include <xen/types.h>
-
-static void u32_swap(void *a, void *b, size_t size)
-{
-    uint32_t t = *(uint32_t *)a;
-
-    *(uint32_t *)a = *(uint32_t *)b;
-    *(uint32_t *)b = t;
-}
-
-static void generic_swap(void *a, void *b, size_t size)
-{
-    char t;
-
-    do {
-        t = *(char *)a;
-        *(char *)a++ = *(char *)b;
-        *(char *)b++ = t;
-    } while ( --size > 0 );
-}
-
-/*
- * sort - sort an array of elements
- * @base: pointer to data to sort
- * @num: number of elements
- * @size: size of each element
- * @cmp: pointer to comparison function
- * @swap: pointer to swap function or NULL
- *
- * This function does a heapsort on the given array. You may provide a
- * swap function optimized to your element type.
- *
- * Sorting time is O(n log n) both on average and worst-case. While
- * qsort is about 20% faster on average, it suffers from exploitable
- * O(n*n) worst-case behavior and extra memory requirements that make
- * it less suitable for kernel use.
- */
-
-void sort(void *base, size_t num, size_t size,
-          int (*cmp)(const void *, const void *),
-          void (*swap)(void *, void *, size_t size))
-{
-    /* pre-scale counters for performance */
-    size_t i = (num / 2) * size, n = num * size, c, r;
-
-    if ( !swap )
-        swap = (size == 4 ? u32_swap : generic_swap);
-
-    /* heapify */
-    while ( i > 0 )
-    {
-        for ( r = i -= size; r * 2 + size < n; r = c )
-        {
-            c = r * 2 + size;
-            if ( (c < n - size) && (cmp(base + c, base + c + size) < 0) )
-                c += size;
-            if ( cmp(base + r, base + c) >= 0 )
-                break;
-            swap(base + r, base + c, size);
-        }
-    }
-
-    /* sort */
-    for ( i = n; i > 0; )
-    {
-        i -= size;
-        swap(base, base + i, size);
-        for ( r = 0; r * 2 + size < i; r = c )
-        {
-            c = r * 2 + size;
-            if ( (c < i - size) && (cmp(base + c, base + c + size) < 0) )
-                c += size;
-            if ( cmp(base + r, base + c) >= 0 )
-                break;
-            swap(base + r, base + c, size);
-        }
-    }
-}
+#define SORT_IMPLEMENTATION
+#include <xen/sort.h>
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 12:51:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 12:51:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271502.465966 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJapd-00042w-M7; Mon, 14 Feb 2022 12:51:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271502.465966; Mon, 14 Feb 2022 12:51:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJapd-00042C-Ft; Mon, 14 Feb 2022 12:51:53 +0000
Received: by outflank-mailman (input) for mailman id 271502;
 Mon, 14 Feb 2022 12:51:52 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJapc-0003jk-Dh
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 12:51:52 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id deb652d9-8d94-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 13:51:49 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: deb652d9-8d94-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644843109;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=J9m3axxGB3YzDKMm3KiRlCtcpIXM6a9lXiT912knQRU=;
  b=C0LN7lOZaZokznpIJGwtMXW4HOaYfkhat9gqyiUSjzpzdrpb2lANUQYD
   D2J6v447sqHHRjsXz3dponQz37M63MiUkrOPBa4X7nFmbNIkllPJPbWcd
   cGVjQHPhBpzAYpPmCPNZXpTbwmKF3UvbfngyIfor6RxTPtDyoqmUB1fvb
   8=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: BICKEwSReIH9eKmvBo1CRZ9hxo4Da6Hik5VETf0yI/mn9LqrA8Izd43jktE8HFjvDSqyIJw48N
 63A2GHtGC2m/pwqvKv7gip4KKW+Mb015Xzr4XymjNNyVfcFraUpL+YXKwkW9krvO8c9X/eaggd
 1c0RjsJF9gBK01/v/fEb4BuaZ5QUqKm761Od2YvicIks++DpI9E0gSsLivtvpPmVFeSJQGl8qe
 /gIZi21dliI72pJ7VEC0mhMeaVBOQhwg/quX30LrT5Qm0ktHOLzmSn2YphvDRhOaxTmu/r99SB
 J4uU9l28uFRE/OvEjnQP8paS
X-SBRS: 5.1
X-MesageID: 64148314
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:VgrLkq7kD8T3EMb2ajxFVgxRtBbAchMFZxGqfqrLsTDasY5as4F+v
 mUXDG2DP/2IM2D2fo0jbdi29UgCupbUy4BmGwtlri0xHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FV8MpBsJ00o5wbZj29Iw2LBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z6
 /B86ICuUV8QG4rXm94NbQkDCD4gBPgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALBc/nJo4A/FpnyinUF60OSpHfWaTao9Rf2V/cg+gQQa+CN
 5FANVKDajzgXAV0KgsOAqkdmeyuonPFfSVVun2K8P9fD2/7k1UqjemF3MDuUt6FX8JOhW6Du
 3nLuW/+B3kyJNGZjDaI7H+oruvOhj/gHpIfEqWi8fxni0HVwXYcYCD6TnPi/6P/0BTnHYsCd
 QpEoULCsJTe6mSIa+igQwOg+EehmQUfYcpuA7Yh91+0n/+8DxmiOkAISTtIadoDvcAwRCA32
 lLho+4FFQCDo5XOFyvDq+78QSeafHFMcDRcPXNsoR4tvoG7yLzfmC4jWTqK/ESdqtTuUQ/9z
 DmRxMTVr+VC1JVbv0lXEL2uvt5NmnQrZlNvjuk0djj8hu+cWGJCT9b2gWU3Fd4acO6koqCp5
 RDoYfS24uEUFo2qnyeQWugLF7zBz6/bbGGD0Q4yQsF4rG7FF5ufkWd4um8WGauUGpxcJW+Bj
 LH75Wu9G6O/zFP1NPQqMupd+uwhzLT6FMSNaxwnRoEmX3SFTyfepHsGTRfJhwjFyRFw+Ylia
 cbzWZv9Vh4yVPU4pAdass9AiNfHMAhlnjiNLX06pjz6uYejiIm9F+tbbgvUM7xRAWHtiFy9z
 uuz/vCik313ONASqAGNmWLKBVxVf3U9G77srMlbKryKLgZ8QTlzAP7N27IxPYdimv0NxOvP+
 3i8XG5eyUb+2iKbeVnbNCg7ZeO9R4t7oFI6ITcoYQSi1U88bNv996wYbZY2I+UqrbQx0f5uQ
 vAZUMycGfATGC/f8jEQYMCl/oxvfRimnyyUOC+hbGRtdpJsXVWRqNTlYhHu5G8FCS/u7Zkyp
 Lip1wX6R5sfRls9UJaKOaz3l17o5CoTguN/WUfMM+J/QkS0/dg4MTH1g982P9oIdUfJyAyF2
 lvEGhwfv+TM/dM4qYGbmaCeoo61OOJiBU4GTXLD5LO7OCSGrGquxYhMDLSBcTzHDT6m/ayjY
 aNezu3mMe1Bl1FP6tIuH7FuxKM4xt3uu74FkVg0QCSVNwymWuF6P32L/chTrakclLZWtDy/V
 l+L5tQHa66CP9noEQJJKQcoBghZOSr4RtUGASwJHXjH
IronPort-HdrOrdr: A9a23:ssub/qNNZ3p9EcBcTvKjsMiBIKoaSvp037B87TEJdfU1SL38qy
 jN9M5w6faQslsssR4b9exoVJPufZq+z+8W3WByB9eftVLdyQ2VxehZhOOI/9SHIUPDH4VmpM
 RdmsZFaeEZojJB/L7HCKXTKadF/DEnmprY4tvj8w==
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="64148314"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Juergen Gross <jgross@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v2 04/70] x86/pv-shim: Don't modify the hypercall table
Date: Mon, 14 Feb 2022 12:50:21 +0000
Message-ID: <20220214125127.17985-5-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

From: Juergen Gross <jgross@suse.com>

When running as pv-shim the hypercall is modified today in order to
replace the functions for __HYPERVISOR_event_channel_op and
__HYPERVISOR_grant_table_op hypercalls.

Change this to call the related functions from the normal handlers
instead when running as shim. The performance implications are not
really relevant, as a normal production hypervisor will not be
configured to support shim mode, so the related calls will be dropped
due to optimization of the compiler.

Note that for the CONFIG_PV_SHIM_EXCLUSIVE case there is a dummy
wrapper do_grant_table_op() needed, as in this case grant_table.c
isn't being built.

Signed-off-by: Juergen Gross <jgross@suse.com>
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
 xen/arch/x86/include/asm/hypercall.h     |  4 ++-
 xen/arch/x86/include/asm/pv/shim.h       |  3 ++
 xen/arch/x86/pv/hypercall.c              |  2 +-
 xen/arch/x86/pv/shim.c                   | 54 ++++++++++++++++----------------
 xen/arch/x86/x86_64/platform_hypercall.c |  2 +-
 xen/common/compat/multicall.c            |  3 +-
 xen/common/event_channel.c               |  9 ++++++
 xen/common/grant_table.c                 |  9 ++++++
 8 files changed, 54 insertions(+), 32 deletions(-)

diff --git a/xen/arch/x86/include/asm/hypercall.h b/xen/arch/x86/include/asm/hypercall.h
index 5d394d492318..f004824f16b6 100644
--- a/xen/arch/x86/include/asm/hypercall.h
+++ b/xen/arch/x86/include/asm/hypercall.h
@@ -145,6 +145,7 @@ do_set_segment_base(
 
 #include <compat/arch-x86/xen.h>
 #include <compat/physdev.h>
+#include <compat/platform.h>
 
 extern int
 compat_physdev_op(
@@ -161,8 +162,9 @@ extern int compat_mmuext_op(
     XEN_GUEST_HANDLE_PARAM(uint) pdone,
     unsigned int foreigndom);
 
+DEFINE_XEN_GUEST_HANDLE(compat_platform_op_t);
 extern int compat_platform_op(
-    XEN_GUEST_HANDLE_PARAM(void) u_xenpf_op);
+    XEN_GUEST_HANDLE_PARAM(compat_platform_op_t) u_xenpf_op);
 
 extern long compat_callback_op(
     int cmd, XEN_GUEST_HANDLE(void) arg);
diff --git a/xen/arch/x86/include/asm/pv/shim.h b/xen/arch/x86/include/asm/pv/shim.h
index 8a91f4f9dfbf..6415f8068e5c 100644
--- a/xen/arch/x86/include/asm/pv/shim.h
+++ b/xen/arch/x86/include/asm/pv/shim.h
@@ -19,6 +19,7 @@
 #ifndef __X86_PV_SHIM_H__
 #define __X86_PV_SHIM_H__
 
+#include <xen/hypercall.h>
 #include <xen/types.h>
 
 #if defined(CONFIG_PV_SHIM_EXCLUSIVE)
@@ -45,6 +46,8 @@ domid_t get_initial_domain_id(void);
 uint64_t pv_shim_mem(uint64_t avail);
 void pv_shim_fixup_e820(struct e820map *e820);
 const struct platform_bad_page *pv_shim_reserved_pages(unsigned int *size);
+typeof(do_event_channel_op) pv_shim_event_channel_op;
+typeof(do_grant_table_op) pv_shim_grant_table_op;
 
 #else
 
diff --git a/xen/arch/x86/pv/hypercall.c b/xen/arch/x86/pv/hypercall.c
index ecdd58deea69..50cd219c18fc 100644
--- a/xen/arch/x86/pv/hypercall.c
+++ b/xen/arch/x86/pv/hypercall.c
@@ -64,7 +64,7 @@ const pv_hypercall_table_t pv_hypercall_table[] = {
     COMPAT_CALL(xen_version),
     HYPERCALL(console_io),
     COMPAT_CALL(physdev_op_compat),
-#ifdef CONFIG_GRANT_TABLE
+#if defined(CONFIG_GRANT_TABLE) || defined(CONFIG_PV_SHIM)
     COMPAT_CALL(grant_table_op),
 #endif
     HYPERCALL(vm_assist),
diff --git a/xen/arch/x86/pv/shim.c b/xen/arch/x86/pv/shim.c
index d9704121a739..7e891fe2f7a4 100644
--- a/xen/arch/x86/pv/shim.c
+++ b/xen/arch/x86/pv/shim.c
@@ -56,11 +56,6 @@ static DEFINE_SPINLOCK(balloon_lock);
 
 static struct platform_bad_page __initdata reserved_pages[2];
 
-static long pv_shim_event_channel_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg);
-static long pv_shim_grant_table_op(unsigned int cmd,
-                                   XEN_GUEST_HANDLE_PARAM(void) uop,
-                                   unsigned int count);
-
 /*
  * By default give the shim 1MB of free memory slack. Some users may wish to
  * tune this constants for better memory utilization. This can be achieved
@@ -203,7 +198,6 @@ void __init pv_shim_setup_dom(struct domain *d, l4_pgentry_t *l4start,
                               start_info_t *si)
 {
     bool compat = is_pv_32bit_domain(d);
-    pv_hypercall_table_t *rw_pv_hypercall_table;
     uint64_t param = 0;
     long rc;
 
@@ -249,23 +243,6 @@ void __init pv_shim_setup_dom(struct domain *d, l4_pgentry_t *l4start,
         consoled_set_ring_addr(page);
     }
 
-    /*
-     * Locate pv_hypercall_table[] (usually .rodata) in the directmap (which
-     * is writeable) and insert some shim-specific hypercall handlers.
-     */
-    rw_pv_hypercall_table = __va(__pa(pv_hypercall_table));
-    rw_pv_hypercall_table[__HYPERVISOR_event_channel_op].native =
-        (hypercall_fn_t *)pv_shim_event_channel_op;
-    rw_pv_hypercall_table[__HYPERVISOR_grant_table_op].native =
-        (hypercall_fn_t *)pv_shim_grant_table_op;
-
-#ifdef CONFIG_PV32
-    rw_pv_hypercall_table[__HYPERVISOR_event_channel_op].compat =
-        (hypercall_fn_t *)pv_shim_event_channel_op;
-    rw_pv_hypercall_table[__HYPERVISOR_grant_table_op].compat =
-        (hypercall_fn_t *)pv_shim_grant_table_op;
-#endif
-
     guest = d;
 
     /*
@@ -435,7 +412,7 @@ int pv_shim_shutdown(uint8_t reason)
     return 0;
 }
 
-static long pv_shim_event_channel_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
+long pv_shim_event_channel_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
 {
     struct domain *d = current->domain;
     struct evtchn_close close;
@@ -683,9 +660,9 @@ void pv_shim_inject_evtchn(unsigned int port)
 # define compat_handle_okay guest_handle_okay
 #endif
 
-static long pv_shim_grant_table_op(unsigned int cmd,
-                                   XEN_GUEST_HANDLE_PARAM(void) uop,
-                                   unsigned int count)
+long pv_shim_grant_table_op(unsigned int cmd,
+                            XEN_GUEST_HANDLE_PARAM(void) uop,
+                            unsigned int count)
 {
     struct domain *d = current->domain;
     long rc = 0;
@@ -845,6 +822,29 @@ static long pv_shim_grant_table_op(unsigned int cmd,
     return rc;
 }
 
+#ifndef CONFIG_GRANT_TABLE
+/* Thin wrapper(s) needed. */
+long do_grant_table_op(unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) uop,
+                       unsigned int count)
+{
+    if ( !pv_shim )
+        return -ENOSYS;
+
+    return pv_shim_grant_table_op(cmd, uop, count);
+}
+
+#ifdef CONFIG_PV32
+int compat_grant_table_op(unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) uop,
+                          unsigned int count)
+{
+    if ( !pv_shim )
+        return -ENOSYS;
+
+    return pv_shim_grant_table_op(cmd, uop, count);
+}
+#endif
+#endif
+
 long pv_shim_cpu_up(void *data)
 {
     struct vcpu *v = data;
diff --git a/xen/arch/x86/x86_64/platform_hypercall.c b/xen/arch/x86/x86_64/platform_hypercall.c
index fbba893a47cb..966fd27b5f22 100644
--- a/xen/arch/x86/x86_64/platform_hypercall.c
+++ b/xen/arch/x86/x86_64/platform_hypercall.c
@@ -6,8 +6,8 @@ EMIT_FILE;
 
 #include <xen/lib.h>
 #include <compat/platform.h>
+#include <xen/hypercall.h>
 
-DEFINE_XEN_GUEST_HANDLE(compat_platform_op_t);
 #define xen_platform_op     compat_platform_op
 #define xen_platform_op_t   compat_platform_op_t
 #define do_platform_op(x)   compat_platform_op(_##x)
diff --git a/xen/common/compat/multicall.c b/xen/common/compat/multicall.c
index a0e9918f4805..b17739d21829 100644
--- a/xen/common/compat/multicall.c
+++ b/xen/common/compat/multicall.c
@@ -5,7 +5,7 @@
 EMIT_FILE;
 
 #include <xen/types.h>
-#include <xen/multicall.h>
+#include <xen/hypercall.h>
 #include <xen/trace.h>
 
 #define COMPAT
@@ -19,7 +19,6 @@ static inline void xlat_multicall_entry(struct mc_state *mcs)
         mcs->compat_call.args[i] = mcs->call.args[i];
 }
 
-DEFINE_XEN_GUEST_HANDLE(multicall_entry_compat_t);
 #define multicall_entry      compat_multicall_entry
 #define multicall_entry_t    multicall_entry_compat_t
 #define do_multicall_call    compat_multicall_call
diff --git a/xen/common/event_channel.c b/xen/common/event_channel.c
index da88ad141a69..c9912122d1e5 100644
--- a/xen/common/event_channel.c
+++ b/xen/common/event_channel.c
@@ -31,6 +31,10 @@
 #include <public/event_channel.h>
 #include <xsm/xsm.h>
 
+#ifdef CONFIG_PV_SHIM
+#include <asm/guest.h>
+#endif
+
 #define ERROR_EXIT(_errno)                                          \
     do {                                                            \
         gdprintk(XENLOG_WARNING,                                    \
@@ -1189,6 +1193,11 @@ long do_event_channel_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
 {
     int rc;
 
+#ifdef CONFIG_PV_SHIM
+    if ( unlikely(pv_shim) )
+        return pv_shim_event_channel_op(cmd, arg);
+#endif
+
     switch ( cmd )
     {
     case EVTCHNOP_alloc_unbound: {
diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c
index 3d92fee59285..925ed7d6bee2 100644
--- a/xen/common/grant_table.c
+++ b/xen/common/grant_table.c
@@ -44,6 +44,10 @@
 #include <asm/flushtlb.h>
 #include <asm/guest_atomics.h>
 
+#ifdef CONFIG_PV_SHIM
+#include <asm/guest.h>
+#endif
+
 /* Per-domain grant information. */
 struct grant_table {
     /*
@@ -3561,6 +3565,11 @@ do_grant_table_op(
     long rc;
     unsigned int opaque_in = cmd & GNTTABOP_ARG_MASK, opaque_out = 0;
 
+#ifdef CONFIG_PV_SHIM
+    if ( unlikely(pv_shim) )
+        return pv_shim_grant_table_op(cmd, uop, count);
+#endif
+
     if ( (int)count < 0 )
         return -EINVAL;
 
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 12:51:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 12:51:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271504.465994 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJapg-0004mQ-9g; Mon, 14 Feb 2022 12:51:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271504.465994; Mon, 14 Feb 2022 12:51:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJapg-0004m1-3g; Mon, 14 Feb 2022 12:51:56 +0000
Received: by outflank-mailman (input) for mailman id 271504;
 Mon, 14 Feb 2022 12:51:54 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJape-0003jk-Dm
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 12:51:54 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e10c9c4d-8d94-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 13:51:51 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e10c9c4d-8d94-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644843111;
  h=from:to:cc:subject:date:message-id:mime-version:
   content-transfer-encoding;
  bh=wfzPn2sSm2e8+srGFEUmhSi8Dq3buCdWtdRdygc21UY=;
  b=X6hK3op73RnYnbZizMSCYwhTgBT5/lwLZFLBpaTz1hiZJQmt/rnVaC8A
   EpBEUeeWj+7DBH/6ovh96O0AW0P7W7vTUJhVZo50gtFCOHOuSHQsvLcCe
   xX8li9mqJRXa9mOB3UqnENxs5XESsLG1X3SDJyEz5zFzLoEozarUarne3
   s=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: IPKGrAFd4+3F1wO7whQbdxx5U7v0ccAGWdeCw8LR0t0fJFevObn7veAKRvcgnyyXXQYu6xFOdH
 sY5M+fCIqDIZvuki8wUjM6MOk6XDYJx8FGt6wdsWUyg3mRrigXjbQAMZIYjn45LZ9JUA01Bvvs
 TxurnV73pcyeXsDCwiQKDoq+mMcvT3M1zA4IGnFJBWeo6NyX2TOm4a7yBZV+jfI1QLgZ3InOLA
 +ZS0/Ntd0ZkniTuH0A406XLixoCds7kSy1bo23Ab5uftehVcbISJ5JHQZf/+wJoSjAUOSKFaxy
 Vu2ZHA6CEONdo2cC67pELD5H
X-SBRS: 5.1
X-MesageID: 63591039
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Lx90GqP0tuM/cebvrR0SkMFynXyQoLVcMsEvi/4bfWQNrUoj1zZTz
 TQdWz+AOf3cajSgLdx3aNm+pEhX7JaGz9AyTgto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6UUsxNbVU8En1500s/w7dRbrNA2rBVPSvc4
 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq
 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYo26nzs1N1
 YlJibeXUAU3MaSTmug8VwYNRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs
 6VFdnZdNXhvhMrvqF6/YsBqit4uM4/AO4QHt2s75TrYEewnUdbIRKCiCdpwgmxt15kWRqe2i
 8wxMjMoR0qDQkd1PA0sUYhvjeGthHX2WmgNwL6SjfVuuDWCpOBr65DvP8DSYceiXthOkwCTo
 Weu10bTDwweNdef4SGY6X/qjejK9Qv+UZgXHae19dZrhkOS3W0ZDBAKVVq9ruK9g0T4UNVaQ
 2QY4jErrLQy3EWzQ8PhQgajp3qZoh8bXcEWGOo/gCmW0bbd6QudAmkCTxZCZcYguctwQiYlv
 neZktWsCTFxvbm9TXOG6qzSvT60ITISL2IJeWkDVwRty9v+pIA+iDrfQ9AlF7S65vXqHRngz
 jbMqzIx74j/luZSif/9pwqexWvx+N6ZFWbZ+zk7QEr+wFJkWJP5Y7CDzkHZ8/lJc4SVb12e6
 S1sd9el0MgCCpSElSqoSeoLHa206/vtDAAwkWKDDLF6qW3zpifLkZR4pWgneRw3appslSrBP
 ReL0T698qO/K5dDgUVfR4uqQ/onwqH7fTgOfqCFN4EeCnSdmeLuwc2PWaJy9z23+KTPuftmU
 Xt+TSpLJSxEYZmLNBLsG48gPUYDn0jSP1/7S5Hh1AiA2rGDfnOTQrptGALQMrxmvPPZ/V2Mq
 Iw32y62J/J3CrOWX8Uq2dRLcQBiwYYTWfgaVPC7hsbce1E7SQnN+tfawK87epwNokimvrygw
 51JYWcBkACXrSSecW2iMyk/AJuyDccXhS9qZkQEYAf3s0XPlK7ytc/zgbNsJuJ5nAGipNYpJ
 8Q4lzKoXKgeFGSfo25FBXQ/xaQ7HCmWacu1F3LNSFACk1RIG2QlI/foIVni8jcgFC2yuZdsq
 rGszFqDE5ECWx5jHIDdb/f2lwG9un0UmeRTWUrUI4YMJBWwodYycyGh3OUqJ8wsKAnYwmfI3
 QihHhpF9/LGpJU48YeViPnc/ZupCeZ3AmFTA3LfseStLSDf82f6md1AXe+EcCrzTmTx/Kn+N
 +xZw+ulaK8MnUpQspo6GLFulPps69zqrr5c7wJlAHSUMAj7VuI+eiGLhJAduLdMy7lVvRqNd
 niOotQKa6+UPM7FEUIKIFZ3ZOq0yvxJyCLZ6u44IRum6XYvrqaHS0hbIzKFlDdZcOluKIogz
 Oos5JwW5gi4hkZ4O9qKlHkJpWGFL3hGWKQ7rJAKRoTsj1NzmF1FZJXdDA7w4Y2ONIoQYhV7f
 GfMifqQnalYy2rDb2E3RCrE0udqjJgTvAxHkQ0ZLFOTl9uZ3vI60XW9K9jsoti5Gvmf799OB
 w==
IronPort-HdrOrdr: A9a23:NbPCLKEzIOqvgCGSpLqE5MeALOsnbusQ8zAXP0AYc3Jom6uj5q
 eTdZUgpHvJYVkqOE3I9ertBEDiewK4yXcW2/hzAV7KZmCP0wHEEGgL1/qF/9SKIUzDH4Bmup
 uIC5IOauHNMQ==
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="63591039"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, Stefano Stabellini <sstabellini@kernel.org>, Wei Liu
	<wl@xen.org>, Julien Grall <julien@xen.org>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>, Juergen Gross
	<jgross@suse.com>, Daniel Smith <dpsmith@apertussolutions.com>,
	=?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?=
	<marmarek@invisiblethingslab.com>
Subject: [PATCH v2 00/70] x86: Support for CET Indirect Branch Tracking
Date: Mon, 14 Feb 2022 12:50:17 +0000
Message-ID: <20220214125127.17985-1-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

CET Indirect Branch Tracking is a hardware feature designed to protect against
forward-edge control flow hijacking (Call/Jump oriented programming), and is a
companion feature to CET Shadow Stacks added in Xen 4.14.

Patches 1 thru 5 are prerequisites.  Patches 6 thru 60 are fairly mechanical
annotations of function pointer targets.  Patches 61 thru 70 are the final
enablement of CET-IBT.

This series functions correctly with GCC 9 and later, although an experimental
GCC patch is required to get more helpful typechecking at build time.

Tested on a TigerLake NUC.

CI pipelines:
  https://gitlab.com/xen-project/people/andyhhp/xen/-/pipelines/470453652
  https://cirrus-ci.com/build/4962308362338304

Major changes from v1:
 * Boilerplate for mechanical commits
 * UEFI runtime services unconditionally disable IBT
 * Comprehensive build time check for embedded endbr's

Andrew Cooper (67):
  xen/domain: Improve pirq handling
  xen/sort: Switch to an extern inline implementation
  xen/xsm: Move {do,compat}_flask_op() declarations into a header
  x86: Introduce support for CET-IBT
  xen: CFI hardening for x86 hypercalls
  xen: CFI hardening for custom_param()
  xen: CFI hardening for __initcall()
  xen: CFI hardening for notifier callbacks
  xen: CFI hardening for acpi_table_parse()
  xen: CFI hardening for continue_hypercall_on_cpu()
  xen: CFI hardening for init_timer()
  xen: CFI hardening for call_rcu()
  xen: CFI hardening for IPIs
  xen: CFI hardening for open_softirq()
  xsm/flask/ss: CFI hardening
  xsm: CFI hardening
  xen/sched: CFI hardening
  xen/evtchn: CFI hardening
  xen/hypfs: CFI hardening
  xen/tasklet: CFI hardening
  xen/keyhandler: CFI hardening
  xen/vpci: CFI hardening
  xen/decompress: CFI hardening
  xen/iommu: CFI hardening
  xen/video: CFI hardening
  xen/console: CFI hardening
  xen/misc: CFI hardening
  x86: CFI hardening for request_irq()
  x86/hvm: CFI hardening for hvm_funcs
  x86/hvm: CFI hardening for device emulation
  x86/emul: CFI hardening
  x86/ucode: CFI hardening
  x86/power: CFI hardening
  x86/apic: CFI hardening
  x86/nmi: CFI hardening
  x86/mtrr: CFI hardening
  x86/idle: CFI hardening
  x86/quirks: CFI hardening
  x86/hvmsave: CFI hardening
  x86/mce: CFI hardening
  x86/pmu: CFI hardening
  x86/cpu: CFI hardening
  x86/guest: CFI hardening
  x86/logdirty: CFI hardening
  x86/shadow: CFI hardening
  x86/hap: CFI hardening
  x86/p2m: CFI hardening
  x86/irq: CFI hardening
  x86/apei: CFI hardening
  x86/psr: CFI hardening
  x86/dpci: CFI hardening
  x86/pt: CFI hardening
  x86/time: CFI hardening
  x86/misc: CFI hardening
  x86/stack: CFI hardening
  x86/bugframe: CFI hardening
  x86: Use control flow typechecking where possible
  x86/setup: Read CR4 earlier in __start_xen()
  x86/alternatives: Clear CR4.CET when clearing CR0.WP
  x86/traps: Rework write_stub_trampoline() to not hardcode the jmp
  x86: Introduce helpers/checks for endbr64 instructions
  x86/emul: Update emulation stubs to be CET-IBT compatible
  x86/entry: Make syscall/sysenter entrypoints CET-IBT compatible
  x86/entry: Make IDT entrypoints CET-IBT compatible
  x86/setup: Rework MSR_S_CET handling for CET-IBT
  x86/efi: Disable CET-IBT around Runtime Services calls
  x86: Enable CET Indirect Branch Tracking

Juergen Gross (2):
  x86/pv-shim: Don't modify the hypercall table
  x86: Don't use the hypercall table for calling compat hypercalls

Marek Marczykowski-Górecki (1):
  x86: Build check for embedded endbr64 instructions

 Config.mk                                    |   1 -
 docs/misc/xen-command-line.pandoc            |  16 +-
 tools/firmware/Makefile                      |   2 +
 tools/libs/guest/xg_dom_decompress_unsafe.h  |   2 +
 tools/tests/x86_emulator/x86-emulate.h       |   2 +
 xen/arch/arm/bootfdt.c                       |   9 +-
 xen/arch/arm/io.c                            |   9 +-
 xen/arch/x86/Kconfig                         |  17 ++
 xen/arch/x86/Makefile                        |   3 +
 xen/arch/x86/acpi/boot.c                     |  24 +-
 xen/arch/x86/acpi/cpu_idle.c                 |  43 ++-
 xen/arch/x86/acpi/cpufreq/cpufreq.c          |  24 +-
 xen/arch/x86/acpi/cpufreq/powernow.c         |  21 +-
 xen/arch/x86/acpi/cpuidle_menu.c             |   6 +-
 xen/arch/x86/acpi/lib.c                      |   2 +-
 xen/arch/x86/acpi/power.c                    |   4 +-
 xen/arch/x86/acpi/wakeup_prot.S              |  38 ++-
 xen/arch/x86/alternative.c                   |  13 +-
 xen/arch/x86/apic.c                          |  12 +-
 xen/arch/x86/arch.mk                         |   7 +
 xen/arch/x86/boot/x86_64.S                   |  30 +-
 xen/arch/x86/compat.c                        |  21 +-
 xen/arch/x86/cpu/amd.c                       |   8 +-
 xen/arch/x86/cpu/centaur.c                   |   2 +-
 xen/arch/x86/cpu/common.c                    |   3 +-
 xen/arch/x86/cpu/cpu.h                       |   2 +-
 xen/arch/x86/cpu/hygon.c                     |   2 +-
 xen/arch/x86/cpu/intel.c                     |   6 +-
 xen/arch/x86/cpu/mcheck/amd_nonfatal.c       |   4 +-
 xen/arch/x86/cpu/mcheck/mce.c                |  22 +-
 xen/arch/x86/cpu/mcheck/mce.h                |   2 +-
 xen/arch/x86/cpu/mcheck/mce_amd.c            |   9 +-
 xen/arch/x86/cpu/mcheck/mce_amd.h            |   4 +-
 xen/arch/x86/cpu/mcheck/mce_intel.c          |  49 ++--
 xen/arch/x86/cpu/mcheck/non-fatal.c          |   6 +-
 xen/arch/x86/cpu/mcheck/vmce.c               |   4 +-
 xen/arch/x86/cpu/microcode/amd.c             |   9 +-
 xen/arch/x86/cpu/microcode/core.c            |  15 +-
 xen/arch/x86/cpu/microcode/intel.c           |  10 +-
 xen/arch/x86/cpu/mtrr/generic.c              |  20 +-
 xen/arch/x86/cpu/mtrr/main.c                 |   4 +-
 xen/arch/x86/cpu/mtrr/mtrr.h                 |   8 +-
 xen/arch/x86/cpu/mwait-idle.c                |  12 +-
 xen/arch/x86/cpu/shanghai.c                  |   2 +-
 xen/arch/x86/cpu/vpmu.c                      |  13 +-
 xen/arch/x86/cpu/vpmu_amd.c                  |  16 +-
 xen/arch/x86/cpu/vpmu_intel.c                |  16 +-
 xen/arch/x86/cpuid.c                         |   8 +-
 xen/arch/x86/crash.c                         |   7 +-
 xen/arch/x86/dmi_scan.c                      |  10 +-
 xen/arch/x86/dom0_build.c                    |   8 +-
 xen/arch/x86/domain.c                        |  16 +-
 xen/arch/x86/emul-i8254.c                    |  14 +-
 xen/arch/x86/extable.c                       |  18 +-
 xen/arch/x86/genapic/bigsmp.c                |   4 +-
 xen/arch/x86/genapic/delivery.c              |  12 +-
 xen/arch/x86/genapic/probe.c                 |   2 +-
 xen/arch/x86/genapic/x2apic.c                |  18 +-
 xen/arch/x86/guest/hyperv/hyperv.c           |  10 +-
 xen/arch/x86/guest/xen/xen.c                 |  15 +-
 xen/arch/x86/hpet.c                          |  29 +-
 xen/arch/x86/hvm/dm.c                        |   5 +-
 xen/arch/x86/hvm/dom0_build.c                |  16 +-
 xen/arch/x86/hvm/emulate.c                   |  93 +++---
 xen/arch/x86/hvm/hpet.c                      |  12 +-
 xen/arch/x86/hvm/hvm.c                       |  47 ++--
 xen/arch/x86/hvm/hypercall.c                 |   5 +-
 xen/arch/x86/hvm/intercept.c                 |  28 +-
 xen/arch/x86/hvm/io.c                        |  38 +--
 xen/arch/x86/hvm/ioreq.c                     |   2 +-
 xen/arch/x86/hvm/irq.c                       |  16 +-
 xen/arch/x86/hvm/mtrr.c                      |   8 +-
 xen/arch/x86/hvm/nestedhvm.c                 |   6 +-
 xen/arch/x86/hvm/pmtimer.c                   |  10 +-
 xen/arch/x86/hvm/quirks.c                    |   4 +-
 xen/arch/x86/hvm/rtc.c                       |  18 +-
 xen/arch/x86/hvm/stdvga.c                    |  19 +-
 xen/arch/x86/hvm/svm/nestedsvm.c             |  22 +-
 xen/arch/x86/hvm/svm/svm.c                   | 404 ++++++++++++++-------------
 xen/arch/x86/hvm/svm/vmcb.c                  |   2 +-
 xen/arch/x86/hvm/vioapic.c                   |  12 +-
 xen/arch/x86/hvm/viridian/time.c             |   2 +-
 xen/arch/x86/hvm/viridian/viridian.c         |  17 +-
 xen/arch/x86/hvm/vlapic.c                    |  25 +-
 xen/arch/x86/hvm/vmsi.c                      |  16 +-
 xen/arch/x86/hvm/vmx/intr.c                  |   2 +-
 xen/arch/x86/hvm/vmx/vmcs.c                  |  22 +-
 xen/arch/x86/hvm/vmx/vmx.c                   | 155 +++++-----
 xen/arch/x86/hvm/vmx/vvmx.c                  |  16 +-
 xen/arch/x86/hvm/vpic.c                      |   8 +-
 xen/arch/x86/hvm/vpt.c                       |   2 +-
 xen/arch/x86/i8259.c                         |  10 +-
 xen/arch/x86/include/asm/asm-defns.h         |   6 +
 xen/arch/x86/include/asm/bug.h               |  10 +-
 xen/arch/x86/include/asm/cpufeature.h        |   1 +
 xen/arch/x86/include/asm/cpufeatures.h       |   1 +
 xen/arch/x86/include/asm/cpuidle.h           |   4 +-
 xen/arch/x86/include/asm/current.h           |   6 +-
 xen/arch/x86/include/asm/endbr.h             |  53 ++++
 xen/arch/x86/include/asm/flushtlb.h          |   2 +-
 xen/arch/x86/include/asm/genapic.h           |  18 +-
 xen/arch/x86/include/asm/hpet.h              |   8 +-
 xen/arch/x86/include/asm/hvm/emulate.h       |   8 +-
 xen/arch/x86/include/asm/hvm/save.h          |   2 +-
 xen/arch/x86/include/asm/hvm/svm/nestedsvm.h |  18 +-
 xen/arch/x86/include/asm/hvm/svm/svm.h       |   1 -
 xen/arch/x86/include/asm/hvm/vioapic.h       |   2 +-
 xen/arch/x86/include/asm/hvm/vmx/vmcs.h      |   8 +-
 xen/arch/x86/include/asm/hvm/vmx/vmx.h       |   4 +-
 xen/arch/x86/include/asm/hvm/vmx/vvmx.h      |  18 +-
 xen/arch/x86/include/asm/hypercall.h         |  81 +++---
 xen/arch/x86/include/asm/irq.h               |  24 +-
 xen/arch/x86/include/asm/mm.h                |  16 +-
 xen/arch/x86/include/asm/msi.h               |   8 +-
 xen/arch/x86/include/asm/msr-index.h         |   1 +
 xen/arch/x86/include/asm/mtrr.h              |   2 +-
 xen/arch/x86/include/asm/p2m.h               |   4 +-
 xen/arch/x86/include/asm/paging.h            |   2 +-
 xen/arch/x86/include/asm/processor.h         |   4 +-
 xen/arch/x86/include/asm/pv/domain.h         |   4 +-
 xen/arch/x86/include/asm/pv/shim.h           |   7 +-
 xen/arch/x86/include/asm/shadow.h            |   2 +-
 xen/arch/x86/include/asm/smp.h               |   6 +-
 xen/arch/x86/include/asm/tboot.h             |   2 +-
 xen/arch/x86/include/asm/time.h              |   6 +-
 xen/arch/x86/io_apic.c                       |  28 +-
 xen/arch/x86/ioport_emulate.c                |   4 +-
 xen/arch/x86/irq.c                           |  28 +-
 xen/arch/x86/livepatch.c                     |   2 +-
 xen/arch/x86/mm.c                            |  35 +--
 xen/arch/x86/mm/hap/guest_walk.c             |   4 +-
 xen/arch/x86/mm/hap/hap.c                    |  29 +-
 xen/arch/x86/mm/hap/nested_hap.c             |   2 +-
 xen/arch/x86/mm/hap/private.h                |  30 +-
 xen/arch/x86/mm/mem_sharing.c                |   2 +-
 xen/arch/x86/mm/p2m-ept.c                    |  34 ++-
 xen/arch/x86/mm/p2m-pt.c                     |  19 +-
 xen/arch/x86/mm/paging.c                     |   3 +-
 xen/arch/x86/mm/shadow/common.c              |  33 +--
 xen/arch/x86/mm/shadow/hvm.c                 |  16 +-
 xen/arch/x86/mm/shadow/multi.c               |  80 +++---
 xen/arch/x86/mm/shadow/multi.h               |  20 +-
 xen/arch/x86/mm/shadow/private.h             |  12 +-
 xen/arch/x86/mm/shadow/pv.c                  |   4 +-
 xen/arch/x86/msi.c                           |  18 +-
 xen/arch/x86/nmi.c                           |  16 +-
 xen/arch/x86/numa.c                          |  10 +-
 xen/arch/x86/oprofile/nmi_int.c              |  16 +-
 xen/arch/x86/oprofile/op_model_athlon.c      |  18 +-
 xen/arch/x86/oprofile/op_model_p4.c          |  14 +-
 xen/arch/x86/oprofile/op_model_ppro.c        |  26 +-
 xen/arch/x86/percpu.c                        |   6 +-
 xen/arch/x86/physdev.c                       |   2 +-
 xen/arch/x86/platform_hypercall.c            |  11 +-
 xen/arch/x86/psr.c                           |  41 +--
 xen/arch/x86/pv/callback.c                   |  25 +-
 xen/arch/x86/pv/descriptor-tables.c          |  14 +-
 xen/arch/x86/pv/domain.c                     |  12 +-
 xen/arch/x86/pv/emul-gate-op.c               |   9 +-
 xen/arch/x86/pv/emul-priv-op.c               |  71 +++--
 xen/arch/x86/pv/emulate.h                    |   7 -
 xen/arch/x86/pv/hypercall.c                  |  11 +-
 xen/arch/x86/pv/iret.c                       |   4 +-
 xen/arch/x86/pv/misc-hypercalls.c            |  10 +-
 xen/arch/x86/pv/ro-page-fault.c              |  31 +-
 xen/arch/x86/pv/shim.c                       |  60 ++--
 xen/arch/x86/pv/traps.c                      |   2 +-
 xen/arch/x86/setup.c                         |  80 ++++--
 xen/arch/x86/shutdown.c                      |  10 +-
 xen/arch/x86/smp.c                           |  20 +-
 xen/arch/x86/smpboot.c                       |   2 +-
 xen/arch/x86/spec_ctrl.c                     |   6 +-
 xen/arch/x86/srat.c                          |   4 +-
 xen/arch/x86/sysctl.c                        |   4 +-
 xen/arch/x86/tboot.c                         |   2 +-
 xen/arch/x86/time.c                          |  68 ++---
 xen/arch/x86/traps.c                         |   8 +-
 xen/arch/x86/tsx.c                           |   2 +-
 xen/arch/x86/x86_64/acpi_mmcfg.c             |   2 +-
 xen/arch/x86/x86_64/compat.c                 |   1 -
 xen/arch/x86/x86_64/compat/entry.S           |   1 +
 xen/arch/x86/x86_64/compat/mm.c              |   7 +-
 xen/arch/x86/x86_64/entry.S                  |  49 +++-
 xen/arch/x86/x86_64/mmconfig-shared.c        |  10 +-
 xen/arch/x86/x86_64/mmconfig.h               |   2 +-
 xen/arch/x86/x86_64/platform_hypercall.c     |   2 +-
 xen/arch/x86/x86_64/traps.c                  |  42 ++-
 xen/arch/x86/x86_emulate.c                   |  34 ++-
 xen/arch/x86/x86_emulate/x86_emulate.c       |  10 +-
 xen/arch/x86/x86_emulate/x86_emulate.h       |  33 +--
 xen/common/argo.c                            |   6 +-
 xen/common/bunzip2.c                         |   2 +-
 xen/common/compat/domain.c                   |   3 +-
 xen/common/compat/grant_table.c              |   5 +-
 xen/common/compat/kernel.c                   |   2 +-
 xen/common/compat/memory.c                   |   7 +-
 xen/common/compat/multicall.c                |   3 +-
 xen/common/core_parking.c                    |  10 +-
 xen/common/cpu.c                             |   4 +-
 xen/common/debugtrace.c                      |  10 +-
 xen/common/decompress.c                      |   2 +-
 xen/common/dm.c                              |   6 +-
 xen/common/domain.c                          |  73 ++---
 xen/common/domctl.c                          |   2 +-
 xen/common/efi/boot.c                        |   6 +-
 xen/common/efi/runtime.c                     |  18 ++
 xen/common/event_2l.c                        |  21 +-
 xen/common/event_channel.c                   |  18 +-
 xen/common/event_fifo.c                      |  30 +-
 xen/common/gdbstub.c                         |   9 +-
 xen/common/grant_table.c                     |  29 +-
 xen/common/hypfs.c                           |  63 ++---
 xen/common/irq.c                             |   6 +-
 xen/common/kernel.c                          |   6 +-
 xen/common/kexec.c                           |  18 +-
 xen/common/keyhandler.c                      |  47 ++--
 xen/common/livepatch.c                       |  15 +-
 xen/common/memory.c                          |   8 +-
 xen/common/multicall.c                       |   2 +-
 xen/common/page_alloc.c                      |  14 +-
 xen/common/perfc.c                           |   4 +-
 xen/common/radix-tree.c                      |   8 +-
 xen/common/random.c                          |   2 +-
 xen/common/rangeset.c                        |   2 +-
 xen/common/rcupdate.c                        |   8 +-
 xen/common/sched/arinc653.c                  |  20 +-
 xen/common/sched/compat.c                    |   2 +-
 xen/common/sched/core.c                      |  40 +--
 xen/common/sched/cpupool.c                   |  35 +--
 xen/common/sched/credit.c                    |  59 ++--
 xen/common/sched/credit2.c                   |  55 ++--
 xen/common/sched/null.c                      |  60 ++--
 xen/common/sched/rt.c                        |  47 ++--
 xen/common/spinlock.c                        |  12 +-
 xen/common/stop_machine.c                    |   6 +-
 xen/common/sysctl.c                          |   2 +-
 xen/common/tasklet.c                         |   4 +-
 xen/common/timer.c                           |   6 +-
 xen/common/trace.c                           |   4 +-
 xen/common/unlzma.c                          |   2 +-
 xen/common/vm_event.c                        |   6 +-
 xen/common/xenoprof.c                        |   2 +-
 xen/common/xmalloc_tlsf.c                    |   4 +-
 xen/common/zstd/zstd_common.c                |   4 +-
 xen/common/zstd/zstd_internal.h              |   4 +-
 xen/drivers/acpi/apei/apei-base.c            |  32 +--
 xen/drivers/acpi/apei/apei-internal.h        |  20 +-
 xen/drivers/acpi/apei/erst.c                 |  57 ++--
 xen/drivers/acpi/apei/hest.c                 |   4 +-
 xen/drivers/acpi/numa.c                      |  10 +-
 xen/drivers/acpi/tables.c                    |   2 +-
 xen/drivers/char/console.c                   |  36 +--
 xen/drivers/char/ehci-dbgp.c                 |  28 +-
 xen/drivers/char/ns16550.c                   |  34 +--
 xen/drivers/cpufreq/cpufreq.c                |   6 +-
 xen/drivers/cpufreq/cpufreq_misc_governors.c |  22 +-
 xen/drivers/cpufreq/cpufreq_ondemand.c       |  10 +-
 xen/drivers/passthrough/amd/iommu.h          |  45 +--
 xen/drivers/passthrough/amd/iommu_acpi.c     |  15 +-
 xen/drivers/passthrough/amd/iommu_guest.c    |  12 +-
 xen/drivers/passthrough/amd/iommu_init.c     |  49 ++--
 xen/drivers/passthrough/amd/iommu_intr.c     |  20 +-
 xen/drivers/passthrough/amd/iommu_map.c      |  22 +-
 xen/drivers/passthrough/amd/pci_amd_iommu.c  |  32 +--
 xen/drivers/passthrough/iommu.c              |  56 ++--
 xen/drivers/passthrough/pci.c                |  18 +-
 xen/drivers/passthrough/vtd/dmar.c           |   7 +-
 xen/drivers/passthrough/vtd/extern.h         |  38 +--
 xen/drivers/passthrough/vtd/intremap.c       |  14 +-
 xen/drivers/passthrough/vtd/iommu.c          |  96 +++----
 xen/drivers/passthrough/vtd/qinval.c         |  28 +-
 xen/drivers/passthrough/vtd/quirks.c         |   2 +-
 xen/drivers/passthrough/vtd/utils.c          |   2 +-
 xen/drivers/passthrough/vtd/x86/hvm.c        |   4 +-
 xen/drivers/passthrough/x86/hvm.c            |  14 +-
 xen/drivers/video/lfb.c                      |   4 +-
 xen/drivers/video/lfb.h                      |   4 +-
 xen/drivers/video/vesa.c                     |   6 +-
 xen/drivers/video/vga.c                      |   6 +-
 xen/drivers/vpci/header.c                    |  18 +-
 xen/drivers/vpci/msi.c                       |  42 +--
 xen/drivers/vpci/msix.c                      |  20 +-
 xen/drivers/vpci/vpci.c                      |  16 +-
 xen/include/acpi/cpufreq/cpufreq.h           |   1 -
 xen/include/xen/acpi.h                       |   2 +-
 xen/include/xen/compiler.h                   |   6 +
 xen/include/xen/domain.h                     |   1 -
 xen/include/xen/hypercall.h                  |  69 ++---
 xen/include/xen/hypfs.h                      |  49 ++--
 xen/include/xen/irq.h                        |   6 +-
 xen/include/xen/lib.h                        |   2 +-
 xen/include/xen/perfc.h                      |   4 +-
 xen/include/xen/sched.h                      |   2 +-
 xen/include/xen/sort.h                       |  55 +++-
 xen/include/xen/spinlock.h                   |   4 +-
 xen/include/xen/vpci.h                       |   8 +-
 xen/include/xsm/dummy.h                      | 211 +++++++-------
 xen/lib/sort.c                               |  80 +-----
 xen/tools/check-endbr.sh                     |  76 +++++
 xen/xsm/flask/avc.c                          |   2 +-
 xen/xsm/flask/flask_op.c                     |   8 +-
 xen/xsm/flask/hooks.c                        | 236 +++++++++-------
 xen/xsm/flask/private.h                      |   9 +
 xen/xsm/flask/ss/avtab.c                     |   4 +-
 xen/xsm/flask/ss/conditional.c               |  10 +-
 xen/xsm/flask/ss/conditional.h               |   6 +-
 xen/xsm/flask/ss/policydb.c                  |  53 ++--
 xen/xsm/flask/ss/services.c                  |   6 +-
 xen/xsm/flask/ss/symtab.c                    |   5 +-
 xen/xsm/silo.c                               |  24 +-
 xen/xsm/xsm_core.c                           |   6 +-
 311 files changed, 3220 insertions(+), 2743 deletions(-)
 create mode 100644 xen/arch/x86/include/asm/endbr.h
 create mode 100755 xen/tools/check-endbr.sh
 create mode 100644 xen/xsm/flask/private.h

-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 12:52:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 12:52:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271505.466005 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJapj-0005D0-Sk; Mon, 14 Feb 2022 12:51:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271505.466005; Mon, 14 Feb 2022 12:51:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJapj-0005Ch-O1; Mon, 14 Feb 2022 12:51:59 +0000
Received: by outflank-mailman (input) for mailman id 271505;
 Mon, 14 Feb 2022 12:51:58 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJapi-0003jk-OP
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 12:51:58 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e494dfa9-8d94-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 13:51:57 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e494dfa9-8d94-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644843117;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=buQ4vU5zrwUnxyg9VsKbyngF1+pXb0VGwNc+MlpJ+mM=;
  b=bRtiKHd1uW9uN1ZelZttxi1VxjSGrZJ49jRDL2sBh0LTWHqrttE3d7Kz
   M+gQGwE8j9yupKbZWrpXcN0gCnIooy8jpKFRPwc89MZe6Yx/MQ9CV0hO1
   2jMnoSm18AhA+9dY1XakQI6crYEZlK3zKYyyC6KPdC32e7UHu5Ka1vo5I
   k=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: uAzcBEHgs19KlcXxNtoAvTZkwZ39kwU1m9GZ9FRn48W4ZaiXUIaaipYVtaEw3ruaz5uP0Jtg4N
 SnJJ07QGeQob/LUubRxfxMc5/P4hg/FRyqkSfhiu/XYR7be/bjuLxn+UV3ln+EfVvPLw+eXj7V
 D/knoMag1kbEvJ++VjLcb1DQiSnSJkv9H3p+8e28kAXnHbD49GfHB5xDVWUeNJrbvkOmFPyVY5
 2fYTPHWKMY0Y1wEzKsJFpkknnkjKcHe8Ry/3FczqUw8sygsaRrn/Z4EStq2O05qZ17gF+sPQBD
 DRNft9JDcj11+w2Qs7aR816/
X-SBRS: 5.1
X-MesageID: 63591047
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:jQSZzKuY9vLYwld9Kw/5VP2hwefnVH9ZMUV32f8akzHdYApBsoF/q
 tZmKT+GOazeMGPxLdpzbYmy8hkH7cLWmoVkHAVs/i5nQ34U+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZQP0VOZigHtIQMsadUsxKbVIiGHdJZS5LwbZj2NYy2IThWmthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 NplrIeKGTgJJ4z1keEAdBVqVHxvHLRd0eqSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DFYUToHx/ixreCu4rW8vrSKTW/95Imjw3g6iiGN6AP
 JdIMGIzM3wsZTVKMFUrULFildutgyG4TR1qrgLNt7Q4tj27IAtZj+G2bYu9lsaxbcdahEGDv
 Urd4n/0RBodMbS32TeDt36hmOLLtSf6Q54JUq218OZwh1+ezXBVDwcZPWZXutHg1BT4AYgGb
 RVJpGx+9sDe6XBHUPHkRCfon16dnycVXsd3H999tRCs07H9tlPx6nc/chZNb9kvtckTTDMs1
 0OUk96BOQGDoIF5WlrGqO7K8Gra1Tw9aDZbOHRaFVdtD8zL/dlr5i8jWOqPB0JcYjfdPTjri
 w6HoyEl71n4pZ5ajv7rlbwrbt/Fm3QocuLXzliNNo5GxlkgDGJAW2BPwQKFhcus1K7DEjG8U
 IEswqByFtwmA5CXjzCqS+4QBryv7PvtGGSC3QIwT8l8qmz0oCTLkWVsDNZWfhkBDyr5UWWxP
 B+7Vf15uPe/w0dGnYcoOtnsWqzGPIDrFMj/V+C8Uza9SsMZSeNzxwk3PRT49zm0yCAEyPhjU
 b/GIZfEJStLUsxPkWvpL9rxJJd2n0jSM0uIHsulp/lmuJLDDEOopUAtbgffMLBhtPncyOgXm
 v4GX/a3J9xkeLWWSkHqHUQ7dzjm9FA3WsL7rdJ5bOmGLlY0EW0tEaaJk7ggZ5Zkj+JekeKRp
 iOxXUpRyVzeg3zbKFrVNiA/Oe23BZsv/2gmOSEMPEqz3yRxa4iY86pCJYA8eqMq9bI/wKcsH
 eUFYciJHt9GVi/Dp2YGdZD4oYE7LEariAuCMjCLej86e5I8FQXF9sW9Jlnk9TUUDzrxvsw7+
 uXy2gTeSJsFZgJjEMeJN67/kwLv5SAQwbsgUVHJL99ffFTX3LJrcyGh3OUqJ8wsKAnYwmfI3
 QihHhpF9/LGpJU48YeViPnc/ZupCeZ3AmFTA3LfseStLSDf82eund1AXeKPcWyPXW/44vz/N
 +BczvW6O/wbhlda9YF7Fu8zn6454tLuoZ5czxhlQyqXPwj6VOs4LynUx9RLu41M2qRd6Fm/V
 U+489VHPamEZZH+G1kLKQt5NumO2Jn4QNUJASjZ9Kki2BJKwQ==
IronPort-HdrOrdr: A9a23:6W+QAq9A7d3sZRss+UNuk+DcI+orL9Y04lQ7vn2ZLiYlFfBw9v
 re+MjzsCWetN9/Yh0dcLy7V5VoIkm9yXcW2+cs1N6ZNWGN1VdAR7sC0aLShxHmBi3i5qp8+M
 5bAs1D4QTLfDtHZBDBkWuFL+o=
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="63591047"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Juergen Gross <jgross@suse.com>
Subject: [PATCH v2 05/70] x86: Don't use the hypercall table for calling compat hypercalls
Date: Mon, 14 Feb 2022 12:50:22 +0000
Message-ID: <20220214125127.17985-6-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

From: Juergen Gross <jgross@suse.com>

Today the *_op_compat hypercalls call the modern handler functions by
using the entries from the hypercall table. This is resulting in a
not needed indirect function call which can be avoided by using the
correct handler function directly. This is basically a revert of
commit 1252e282311734 ("86/pv: Export pv_hypercall_table[] rather
than working around it in several ways"), which reasoning no longer
applies, as shim no longer modifies the hypercall table.

The hypercall table can now be made static as there is no external
reference to it any longer.

Commit 834cb8761051f7 ("x86/PV32: fix physdev_op_compat handling")
can be reverted, too, as using the direct call of the correct handler
is already handled fine without that patch.

Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
---
 xen/arch/x86/compat.c                | 14 ++++----------
 xen/arch/x86/include/asm/hypercall.h |  8 --------
 xen/arch/x86/pv/hypercall.c          |  9 ++++++++-
 xen/arch/x86/x86_64/compat.c         |  1 -
 4 files changed, 12 insertions(+), 20 deletions(-)

diff --git a/xen/arch/x86/compat.c b/xen/arch/x86/compat.c
index 58b202f701d5..939b449dec29 100644
--- a/xen/arch/x86/compat.c
+++ b/xen/arch/x86/compat.c
@@ -17,14 +17,12 @@ typedef long ret_t;
 /* Legacy hypercall (as of 0x00030202). */
 ret_t do_physdev_op_compat(XEN_GUEST_HANDLE_PARAM(physdev_op_t) uop)
 {
-    typeof(do_physdev_op) *fn =
-        (void *)pv_hypercall_table[__HYPERVISOR_physdev_op].native;
     struct physdev_op op;
 
     if ( unlikely(copy_from_guest(&op, uop, 1) != 0) )
         return -EFAULT;
 
-    return fn(op.cmd, guest_handle_from_ptr(&uop.p->u, void));
+    return do_physdev_op(op.cmd, guest_handle_from_ptr(&uop.p->u, void));
 }
 
 #ifndef COMPAT
@@ -32,14 +30,11 @@ ret_t do_physdev_op_compat(XEN_GUEST_HANDLE_PARAM(physdev_op_t) uop)
 /* Legacy hypercall (as of 0x00030101). */
 long do_sched_op_compat(int cmd, unsigned long arg)
 {
-    typeof(do_sched_op) *fn =
-        (void *)pv_hypercall_table[__HYPERVISOR_sched_op].native;
-
     switch ( cmd )
     {
     case SCHEDOP_yield:
     case SCHEDOP_block:
-        return fn(cmd, guest_handle_from_ptr(NULL, void));
+        return do_sched_op(cmd, guest_handle_from_ptr(NULL, void));
 
     case SCHEDOP_shutdown:
         TRACE_3D(TRC_SCHED_SHUTDOWN,
@@ -57,8 +52,6 @@ long do_sched_op_compat(int cmd, unsigned long arg)
 /* Legacy hypercall (as of 0x00030202). */
 long do_event_channel_op_compat(XEN_GUEST_HANDLE_PARAM(evtchn_op_t) uop)
 {
-    typeof(do_event_channel_op) *fn =
-        (void *)pv_hypercall_table[__HYPERVISOR_event_channel_op].native;
     struct evtchn_op op;
 
     if ( unlikely(copy_from_guest(&op, uop, 1) != 0) )
@@ -76,7 +69,8 @@ long do_event_channel_op_compat(XEN_GUEST_HANDLE_PARAM(evtchn_op_t) uop)
     case EVTCHNOP_bind_ipi:
     case EVTCHNOP_bind_vcpu:
     case EVTCHNOP_unmask:
-        return fn(op.cmd, guest_handle_from_ptr(&uop.p->u, void));
+        return do_event_channel_op(op.cmd,
+                                   guest_handle_from_ptr(&uop.p->u, void));
 
     default:
         return -ENOSYS;
diff --git a/xen/arch/x86/include/asm/hypercall.h b/xen/arch/x86/include/asm/hypercall.h
index f004824f16b6..eb3aed3bf70e 100644
--- a/xen/arch/x86/include/asm/hypercall.h
+++ b/xen/arch/x86/include/asm/hypercall.h
@@ -16,13 +16,6 @@ typedef unsigned long hypercall_fn_t(
     unsigned long, unsigned long);
 
 typedef struct {
-    hypercall_fn_t *native;
-#ifdef CONFIG_PV32
-    hypercall_fn_t *compat;
-#endif
-} pv_hypercall_table_t;
-
-typedef struct {
     uint8_t native;
 #ifdef CONFIG_COMPAT
     uint8_t compat;
@@ -32,7 +25,6 @@ typedef struct {
 extern const hypercall_args_t hypercall_args_table[NR_hypercalls];
 
 #ifdef CONFIG_PV
-extern const pv_hypercall_table_t pv_hypercall_table[];
 void pv_hypercall(struct cpu_user_regs *regs);
 #endif
 
diff --git a/xen/arch/x86/pv/hypercall.c b/xen/arch/x86/pv/hypercall.c
index 50cd219c18fc..e8fbee7bbbc0 100644
--- a/xen/arch/x86/pv/hypercall.c
+++ b/xen/arch/x86/pv/hypercall.c
@@ -27,6 +27,13 @@
 #include <asm/multicall.h>
 #include <irq_vectors.h>
 
+typedef struct {
+    hypercall_fn_t *native;
+#ifdef CONFIG_PV32
+    hypercall_fn_t *compat;
+#endif
+} pv_hypercall_table_t;
+
 #ifdef CONFIG_PV32
 #define HYPERCALL(x)                                                \
     [ __HYPERVISOR_ ## x ] = { (hypercall_fn_t *) do_ ## x,         \
@@ -42,7 +49,7 @@
 
 #define do_arch_1             paging_domctl_continuation
 
-const pv_hypercall_table_t pv_hypercall_table[] = {
+static const pv_hypercall_table_t pv_hypercall_table[] = {
     COMPAT_CALL(set_trap_table),
     HYPERCALL(mmu_update),
     COMPAT_CALL(set_gdt),
diff --git a/xen/arch/x86/x86_64/compat.c b/xen/arch/x86/x86_64/compat.c
index fcbc1cc0d780..0e4c71f2aa17 100644
--- a/xen/arch/x86/x86_64/compat.c
+++ b/xen/arch/x86/x86_64/compat.c
@@ -12,7 +12,6 @@ EMIT_FILE;
 #define physdev_op_t                  physdev_op_compat_t
 #define do_physdev_op                 compat_physdev_op
 #define do_physdev_op_compat(x)       compat_physdev_op_compat(_##x)
-#define native                        compat
 
 #define COMPAT
 #define _XEN_GUEST_HANDLE(t) XEN_GUEST_HANDLE(t)
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 12:52:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 12:52:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271506.466015 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJapn-0005b4-5T; Mon, 14 Feb 2022 12:52:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271506.466015; Mon, 14 Feb 2022 12:52:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJapn-0005ap-1x; Mon, 14 Feb 2022 12:52:03 +0000
Received: by outflank-mailman (input) for mailman id 271506;
 Mon, 14 Feb 2022 12:52:01 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJapl-0003jd-8V
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 12:52:01 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e4836a4a-8d94-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 13:51:59 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e4836a4a-8d94-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644843119;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=9InvRPHFIdzqh83XB2chSO1PILFwtwPb/Bgms+iLNm0=;
  b=N3ylDT5YZGajxf+RzUwGQFQ14Xnu7T1R0wE+Sfd9he4MAESlqNtsyPbM
   ut/wOFYnulKp17KRJlj/lDpwoo0DIQ81AWbXrVwWxxNdADjdPnzkYALbt
   DXXrJ84XQr8GDB/24G9Nakwra+IA1TWiLMIfzSKl5JVelikWEIqKp+kVb
   4=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: 6UWwk60Ynj3vZcjN/RSwXI0H3ofMc4YpZw3PGz2Ob2ypecmVK4fAByPgTJqiGSoYvZQ5jTI0eH
 bqMCvBvJqSWO5eo3ke5Ox0DZWILx6+iC/d+kG48fQeIXqLqAsChUY8BS2Q91zEQFzpKcLTNEBi
 fc8lLYzSV9QMqQdGUp9ELd5+wItaaaJdjpiyPYmAsYrhCY0gLZb1rxOesKJqulwkNNhql05YTN
 JD+9ZRGBrrTEroh/lN60PHSfaMVXasArKdTcoAyyAQu+5BRz4buWpGnORTRI7IUnBkPM3yWOAJ
 5BT5zpVoT8tUbh3c72eKWH+o
X-SBRS: 5.1
X-MesageID: 64148330
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:MUR3G6B+1aXM/xVW/xbkw5YqxClBgxIJ4kV8jS/XYbTApDgm0mYPm
 2scWm+HbK2KMzfwLtt1PIq/80NVu8TXx9IwQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMo/u1Si6FatANl1ElvU2zbue6WL6s1hxZH1c+En970E47wobVv6Yz6TSHK1LV0
 T/Ni5W31G+Ng1aY5UpNtspvADs21BjDkGtwUm4WPJinj3eH/5UhN7oNJLnZEpfNatI88thW5
 Qr05OrREmvxp3/BAz4++1rxWhVirrX6ZWBihpfKMkQLb9crSiEai84G2PQghUh/0BLRgPtQk
 PN0mbOPRggRA4jJsuEGXEwNe81+FfUuFL7vJHG+tYqYzlHccmuqyPJrZK00FdRGoKAtWzgIr
 KFGbmBWBvyAr7veLLaTY+9gnMk8auLsO5sSoCpIxjDFF/c2B5vERs0m4PcGgG5s1psVRZ4yY
 eITSAhCVi/4TSZdIwkcD50Bns2smzrwJmgwRFW9+vNsvjm7IBZK+KfpGMrYfJqNX8o9tmSyq
 3/C/m/5KgoHL9HZwj2Amlq8i+mKkS7lVYY6ELyj6uUskFCV3nYUChAdSR28u/bRt6Klc4sBc
 QpOoHNo9PVsshzwJjXgY/GmiCWj5gE3eoJ2KsEV1w6C8pfx5iycHWdRG1atd+canMMxQDUr0
 HqAkNXoGSFjvdWpdJ6NyluHhWjsYHZIdAfucQdBFFJYuIe7/OnfmzqSFo4LLUKjsjHi9dgcK
 RiupTN2ubgchNVjO06TrQGe2GLESnQko2cICuTrsoCNs1kRiG2NPdXABb3nARFodtjxc7V5l
 CJY8/VyFchXZX13qASDQf8WAJai7OufPTvXjDZHRsd9q2v9qyP+JdkLulmSwXuF1e5eJ1fUj
 LL741sNtPe/wlP2BUOIX25BI5tzlvWxfTgUfvvVcsBPcvBMmPyvp0lTibqr9zm1yiAEyPhnU
 b/CKJrEJStKWMxPkWvtL89AgOBD+8zL7T6KLXwN50/8iuT2ib/8YeptDWZimchnsPLa8F2Nq
 Y432gnj40w3bdASqxL/qeY7RW3m51BhbXwvg8AIJOOFPCR8H2QtV63Yzb87ItQ3lKVJjObYu
 Hq6XxYAmlb4gHTGLySMa2xiN+yzDcou8ypjMHx+J0us1lgifZ2rsPUVeawocOR17+dk1/N1E
 aUIIp3SHvRVRz3b0D0Bdp2h/pd6fRGmiFvWbSqoaTQyZbB6QAnN9oO2dwfj7nBWXCG2qdE/s
 /ur0QaCGcgPQAFrDcD3bvOzzgzu4ShBybwqB0aRe4tdYkTh9oRuOhfdtP5vLpFeMwjHyxuby
 x2SXUUSq97SrtJn69LOn62F8dukSrMsAkpAEmDHxr+qLi2GrHG7yIpNXevULzDQUGT4pPera
 elPlqyuNfQGmBBBspZmEqYtxqU7voO9q7hfxwViPXPKc1X0Ve8wfijYhZFC5v9X27tUmQqqQ
 UbeqNBVNIKANN7hDFNMdhEuaf6O1K1MlzTfhRjvzJ4WOMOjEGK7bHhv
IronPort-HdrOrdr: A9a23:J5ECuKOSIEHWEMBcTsWjsMiBIKoaSvp037BN7TEXdfU1SL39qy
 nKpp8mPHDP5Ar5NEtOpTniAsm9qBHnm6KdiLN5Vd3OYOCMggqVBbAnwYz+wyDxXw3Sn9QtsJ
 uIqpIOa+EY22IK7/rH3A==
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="64148330"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>
Subject: [PATCH v2 06/70] x86: Introduce support for CET-IBT
Date: Mon, 14 Feb 2022 12:50:23 +0000
Message-ID: <20220214125127.17985-7-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

CET Indirect Branch Tracking is a hardware feature designed to provide
forward-edge control flow integrity, protecting against jump/call oriented
programming.

IBT requires the placement of ENDBR{32,64} instructions at the target of every
indirect call/jmp, and every entrypoint.

However, the default -fcf-protection=branch places an ENDBR on every function
which far more than necessary, and reduces the quantity of protection
afforded.  Therefore, we use manual placement using the cf_check attribute.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>

Clang/LLVM support for -mmanual-endbr is in progress:
  https://reviews.llvm.org/D118355

v2:
 * Correct CONFIG_HAS_CC_CET_IBT to CONFIG_XEN_IBT in some places
 * Move cf_check compatibility into tools/tests/x86_emulator/x86-emulate.h
---
 Config.mk                                   |  1 -
 tools/firmware/Makefile                     |  2 ++
 tools/libs/guest/xg_dom_decompress_unsafe.h |  2 ++
 tools/tests/x86_emulator/x86-emulate.h      |  2 ++
 xen/arch/x86/Kconfig                        | 17 +++++++++++++++++
 xen/arch/x86/arch.mk                        |  6 ++++++
 xen/arch/x86/include/asm/asm-defns.h        |  6 ++++++
 xen/arch/x86/include/asm/cpufeature.h       |  1 +
 xen/arch/x86/include/asm/cpufeatures.h      |  1 +
 xen/include/xen/compiler.h                  |  6 ++++++
 10 files changed, 43 insertions(+), 1 deletion(-)

diff --git a/Config.mk b/Config.mk
index 95c053212ec3..f56f7dc33468 100644
--- a/Config.mk
+++ b/Config.mk
@@ -190,7 +190,6 @@ APPEND_CFLAGS += $(foreach i, $(APPEND_INCLUDES), -I$(i))
 
 EMBEDDED_EXTRA_CFLAGS := -nopie -fno-stack-protector -fno-stack-protector-all
 EMBEDDED_EXTRA_CFLAGS += -fno-exceptions -fno-asynchronous-unwind-tables
-EMBEDDED_EXTRA_CFLAGS += -fcf-protection=none
 
 XEN_EXTFILES_URL ?= http://xenbits.xen.org/xen-extfiles
 # All the files at that location were downloaded from elsewhere on
diff --git a/tools/firmware/Makefile b/tools/firmware/Makefile
index 345037b93b7f..53ed4f161edb 100644
--- a/tools/firmware/Makefile
+++ b/tools/firmware/Makefile
@@ -6,6 +6,8 @@ TARGET      := hvmloader/hvmloader
 INST_DIR := $(DESTDIR)$(XENFIRMWAREDIR)
 DEBG_DIR := $(DESTDIR)$(DEBUG_DIR)$(XENFIRMWAREDIR)
 
+EMBEDDED_EXTRA_CFLAGS += -fcf-protection=none
+
 SUBDIRS-y :=
 SUBDIRS-$(CONFIG_OVMF) += ovmf-dir
 SUBDIRS-$(CONFIG_SEABIOS) += seabios-dir
diff --git a/tools/libs/guest/xg_dom_decompress_unsafe.h b/tools/libs/guest/xg_dom_decompress_unsafe.h
index 4e0bf23aa587..3bce0cfefb88 100644
--- a/tools/libs/guest/xg_dom_decompress_unsafe.h
+++ b/tools/libs/guest/xg_dom_decompress_unsafe.h
@@ -8,6 +8,8 @@ typedef int decompress_fn(unsigned char *inbuf, unsigned int len,
                           void (*error)(const char *x));
 #endif
 
+#define cf_check
+
 int xc_dom_decompress_unsafe(
     decompress_fn fn, struct xc_dom_image *dom, void **blob, size_t *size)
     __attribute__((visibility("internal")));
diff --git a/tools/tests/x86_emulator/x86-emulate.h b/tools/tests/x86_emulator/x86-emulate.h
index 7f60ef9e89ba..c6819a417d05 100644
--- a/tools/tests/x86_emulator/x86-emulate.h
+++ b/tools/tests/x86_emulator/x86-emulate.h
@@ -54,6 +54,8 @@
 #define likely(x)   __builtin_expect(!!(x), true)
 #define unlikely(x) __builtin_expect(!!(x), false)
 
+#define cf_check
+
 #define container_of(ptr, type, member) ({             \
     typeof(((type *)0)->member) *mptr__ = (ptr);       \
     (type *)((char *)mptr__ - offsetof(type, member)); \
diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig
index b4abfca46f6a..8b7ad0145b29 100644
--- a/xen/arch/x86/Kconfig
+++ b/xen/arch/x86/Kconfig
@@ -39,6 +39,11 @@ config HAS_AS_CET_SS
 	# binutils >= 2.29 or LLVM >= 6
 	def_bool $(as-instr,wrssq %rax$(comma)0;setssbsy)
 
+config HAS_CC_CET_IBT
+	# GCC >= 9 and binutils >= 2.29
+	# Retpoline check to work around https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93654
+	def_bool $(cc-option,-fcf-protection=branch -mmanual-endbr -mindirect-branch=thunk-extern) && $(as-instr,endbr64)
+
 menu "Architecture Features"
 
 source "arch/Kconfig"
@@ -124,6 +129,18 @@ config XEN_SHSTK
 	  When CET-SS is active, 32bit PV guests cannot be used.  Backwards
 	  compatiblity can be provided via the PV Shim mechanism.
 
+config XEN_IBT
+	bool "Supervisor Indirect Branch Tracking"
+	depends on HAS_CC_CET_IBT
+	default y
+	help
+	  Control-flow Enforcement Technology (CET) is a set of features in
+	  hardware designed to combat Return-oriented Programming (ROP, also
+	  call/jump COP/JOP) attacks.  Indirect Branch Tracking is one CET
+	  feature designed to provide function pointer protection.
+
+	  This option arranges for Xen to use CET-IBT for its own protection.
+
 config SHADOW_PAGING
 	bool "Shadow Paging"
 	default !PV_SHIM_EXCLUSIVE
diff --git a/xen/arch/x86/arch.mk b/xen/arch/x86/arch.mk
index fa7cf3844362..8b88f0240e85 100644
--- a/xen/arch/x86/arch.mk
+++ b/xen/arch/x86/arch.mk
@@ -47,6 +47,12 @@ CFLAGS-$(CONFIG_INDIRECT_THUNK) += -mindirect-branch=thunk-extern
 CFLAGS-$(CONFIG_INDIRECT_THUNK) += -mindirect-branch-register
 CFLAGS-$(CONFIG_INDIRECT_THUNK) += -fno-jump-tables
 
+ifdef CONFIG_XEN_IBT
+CFLAGS += -fcf-protection=branch -mmanual-endbr
+else
+$(call cc-option-add,CFLAGS,CC,-fcf-protection=none)
+endif
+
 # If supported by the compiler, reduce stack alignment to 8 bytes. But allow
 # this to be overridden elsewhere.
 $(call cc-option-add,CFLAGS_stack_boundary,CC,-mpreferred-stack-boundary=3)
diff --git a/xen/arch/x86/include/asm/asm-defns.h b/xen/arch/x86/include/asm/asm-defns.h
index 505f39ad5f76..8bd9007731d5 100644
--- a/xen/arch/x86/include/asm/asm-defns.h
+++ b/xen/arch/x86/include/asm/asm-defns.h
@@ -57,6 +57,12 @@
     INDIRECT_BRANCH jmp \arg
 .endm
 
+#ifdef CONFIG_XEN_IBT
+# define ENDBR64 endbr64
+#else
+# define ENDBR64
+#endif
+
 .macro guest_access_mask_ptr ptr:req, scratch1:req, scratch2:req
 #if defined(CONFIG_SPECULATIVE_HARDEN_GUEST_ACCESS)
     /*
diff --git a/xen/arch/x86/include/asm/cpufeature.h b/xen/arch/x86/include/asm/cpufeature.h
index a0ab6d7d78ea..f2c6f255ace9 100644
--- a/xen/arch/x86/include/asm/cpufeature.h
+++ b/xen/arch/x86/include/asm/cpufeature.h
@@ -152,6 +152,7 @@
 #define cpu_has_nscb            boot_cpu_has(X86_FEATURE_NSCB)
 #define cpu_has_xen_lbr         boot_cpu_has(X86_FEATURE_XEN_LBR)
 #define cpu_has_xen_shstk       boot_cpu_has(X86_FEATURE_XEN_SHSTK)
+#define cpu_has_xen_ibt         boot_cpu_has(X86_FEATURE_XEN_IBT)
 
 #define cpu_has_msr_tsc_aux     (cpu_has_rdtscp || cpu_has_rdpid)
 
diff --git a/xen/arch/x86/include/asm/cpufeatures.h b/xen/arch/x86/include/asm/cpufeatures.h
index b10154fc44bb..7413febd7ad8 100644
--- a/xen/arch/x86/include/asm/cpufeatures.h
+++ b/xen/arch/x86/include/asm/cpufeatures.h
@@ -39,6 +39,7 @@ XEN_CPUFEATURE(SC_VERW_PV,        X86_SYNTH(23)) /* VERW used by Xen for PV */
 XEN_CPUFEATURE(SC_VERW_HVM,       X86_SYNTH(24)) /* VERW used by Xen for HVM */
 XEN_CPUFEATURE(SC_VERW_IDLE,      X86_SYNTH(25)) /* VERW used by Xen for idle */
 XEN_CPUFEATURE(XEN_SHSTK,         X86_SYNTH(26)) /* Xen uses CET Shadow Stacks */
+XEN_CPUFEATURE(XEN_IBT,           X86_SYNTH(27)) /* Xen uses CET Indirect Branch Tracking */
 
 /* Bug words follow the synthetic words. */
 #define X86_NR_BUG 1
diff --git a/xen/include/xen/compiler.h b/xen/include/xen/compiler.h
index 696c7eb89e4c..933aec09a92d 100644
--- a/xen/include/xen/compiler.h
+++ b/xen/include/xen/compiler.h
@@ -37,6 +37,12 @@
 # define nocall
 #endif
 
+#ifdef CONFIG_XEN_IBT
+# define cf_check     __attribute__((__cf_check__))
+#else
+# define cf_check
+#endif
+
 #if (!defined(__clang__) && (__GNUC__ == 4) && (__GNUC_MINOR__ < 5))
 #define unreachable() do {} while (1)
 #else
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 12:52:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 12:52:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271507.466020 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJapn-0005fS-Pe; Mon, 14 Feb 2022 12:52:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271507.466020; Mon, 14 Feb 2022 12:52:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJapn-0005dd-Df; Mon, 14 Feb 2022 12:52:03 +0000
Received: by outflank-mailman (input) for mailman id 271507;
 Mon, 14 Feb 2022 12:52:02 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJapl-0003jk-Kh
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 12:52:01 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e4ac43fb-8d94-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 13:51:58 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e4ac43fb-8d94-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644843118;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=LDFys9qkWZQwimW2LVFGkIq2g5umxCHwhtWsKzFzSd8=;
  b=GTe66ceLkHNYQ6GDecdgKbd7CynQeAaI4UA35WnamC2l2rs9wH8uPM40
   9pzUloFcuBN+rhdJKy6qacNQzfOvXLssz0FFHVSawxGn0Rf0gWeq6Ycx7
   tWS4k0jwDtfYzeRYg1XZ1HAvbEf3RHcRlWiogMw5Y4eZWbVRTml2Il5R8
   s=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: oPRjvKs0pPrCMLv66khxI8jrMLdUSvMEhCYgCdFBfWfwtzmJlUVZnGGr5MPCtIjwqdh+e/snZO
 pozZIg8KlLawPZMHZ4/Y3naBq795WABEYAAYdGwVwlVZGAhbibsIuGZnUrYSrq+UAwFHoTeFNu
 +8Wz2REqp7obneg1RjfW4+L8MHLz4ybD0Texd+/5SVWgXXK7uWrUViR2drHMJ/Cg3PnogzXP8V
 9SBQK3yI1dH/SjstRp8zFTdfvI02QS1/FYc+eMFCWcVv9S+qaH5YXTwfZjlvZewG2jUj+lRIJm
 CNGcx8dJbScEfDZSkQuwJwND
X-SBRS: 5.1
X-MesageID: 64048979
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:0RL5e6+cYBGhNKtWBEapDrUDnnmTJUtcMsCJ2f8bNWPcYEJGY0x3n
 2ZMXzuHPv+JZTagf9okbd7g800D6JXVyodqTVA+qnw8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhFWeIdA970Ug5w7Rg3tYx6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhql
 utSl7GaGDsFN/zvwac7ehdDHwxHaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguwKKsXxMZxZkXZn1TzDVt4tQIzZQrWM7thdtNs1rp4SRaqON
 pVIAdZpRAj/aFoUO2gqNJ4Roe7ypFL0bmdorl3A8MLb5ECMlVcsgdABKuH9atGMAMlYgEucj
 mbH5HjiRAEXMsSFzjiI+W7qgfXA9R4XQ6pLSuf+rKQzxgTOmCpDU3X6SGdXv9Gi1HChef91e
 nA483sN9OsU3UKwQvTECkjQTGG/gjYQXN9ZEusf4Q6Ly7bJ7wvxOlXoXgKte/R96pZoGGVCO
 kuh2oqwWGcx6OH9pWe1q+/MxQ5eLxT5OoPricUsaQIeq+fur4go5v4kZoYySfXl5jEZ9NyZ/
 txrkMTcr+hJ5SLo///ilbwiv95LjsKXJjPZHi2NAgqYAvpRPeZJnbCA51nB9upnJ42EVFSHt
 3Vss5HAsLxRXcHQyXTUG79l8FSVCxGtamO0vLKSN8N5q2TFF4CLIei8Hw2S1G82a51ZKFcFk
 WfYuB9L5Y87AZdZRfQfXm5FMOxzlfKIPY28Dpj8N4MSCrAsJF7v1Hw/Pia4gjGy+HXAZIliY
 P93h+73Vi1EYUmmpRLrL9ogPUgDmHxvmzOLHcqjp/lluJLHDEOopX4+GAPmRogEAGms+m05K
 v5TaJmHzQtxSur7bnWF+IIfNwlSf3M6GYr3u4pccevaelhqH2QoCvnwx7I9etM6w/QJx7mQp
 nztCFVFzFffhGHcLVnYYH5Ud76yD410qmg2PHJwMA/wiWQje4um8IwWa4AzIes87OVmwPMtF
 6sFdsyMD+5hUDPC/zhBP5DxoJY7LEaghB6UPjrjaz86JsYySwvM897iXw3u6ChRUXbn6Zpg+
 +Wtj1qJT4ACSgJuCNftRMiul17h72IAnO9SXlfTJoUBckvb74U3eTf6ieU6Ip9QJEyblCeaz
 QufHTwRufLJ/90u6NDMiK2J89WpHu95EhYIFmXX9+/rZyzT/27lyo5cSueYOzvaUTqsqqmlY
 OxUydD6MeEGwwkW49YtTe4zwPJs/cbrqp9b0h9gTSfCYFmcA799JmWLgJtUvapXy74F4Qa7V
 ypjIDWB1Wll7C89LGMsGQ==
IronPort-HdrOrdr: A9a23:ky84r66UKIx0ubM9kQPXwMrXdLJyesId70hD6qhwISY6TiX4rb
 HWoB1173/JYVoqNE3I3OrwXZVoIkmsk6Kdg7NhXotKNTOO0ADDQb2Kr7GSpwEIcxeOkdK1vp
 0AT0ERMrLN5CBB/KTH3DU=
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="64048979"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v2 08/70] xen: CFI hardening for x86 hypercalls
Date: Mon, 14 Feb 2022 12:50:25 +0000
Message-ID: <20220214125127.17985-9-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

Control Flow Integrity schemes use toolchain and optionally hardware support
to help protect against call/jump/return oriented programming attacks.

Use cf_check to annotate function pointer targets for the toolchain.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
 xen/arch/x86/compat.c                |  7 ++--
 xen/arch/x86/cpu/mcheck/mce.c        |  2 +-
 xen/arch/x86/cpu/vpmu.c              |  3 +-
 xen/arch/x86/hvm/dm.c                |  5 ++-
 xen/arch/x86/hvm/hvm.c               |  2 +-
 xen/arch/x86/hvm/hypercall.c         |  5 +--
 xen/arch/x86/include/asm/hypercall.h | 69 +++++++++++++++++++-----------------
 xen/arch/x86/include/asm/paging.h    |  2 +-
 xen/arch/x86/mm.c                    | 23 ++++++------
 xen/arch/x86/mm/paging.c             |  3 +-
 xen/arch/x86/physdev.c               |  2 +-
 xen/arch/x86/platform_hypercall.c    |  3 +-
 xen/arch/x86/pv/callback.c           | 25 +++++++------
 xen/arch/x86/pv/descriptor-tables.c  | 14 ++++----
 xen/arch/x86/pv/iret.c               |  4 +--
 xen/arch/x86/pv/misc-hypercalls.c    | 10 +++---
 xen/arch/x86/pv/shim.c               |  8 ++---
 xen/arch/x86/x86_64/compat/mm.c      |  7 ++--
 xen/common/argo.c                    |  4 +--
 xen/common/compat/domain.c           |  3 +-
 xen/common/compat/grant_table.c      |  5 ++-
 xen/common/compat/kernel.c           |  2 +-
 xen/common/compat/memory.c           |  3 +-
 xen/common/dm.c                      |  6 ++--
 xen/common/domain.c                  |  5 +--
 xen/common/domctl.c                  |  2 +-
 xen/common/event_channel.c           |  2 +-
 xen/common/grant_table.c             |  2 +-
 xen/common/hypfs.c                   |  6 ++--
 xen/common/kernel.c                  |  2 +-
 xen/common/kexec.c                   |  4 +--
 xen/common/memory.c                  |  2 +-
 xen/common/multicall.c               |  2 +-
 xen/common/sched/compat.c            |  2 +-
 xen/common/sched/core.c              |  4 +--
 xen/common/sysctl.c                  |  2 +-
 xen/common/xenoprof.c                |  2 +-
 xen/drivers/char/console.c           |  4 +--
 xen/include/xen/hypercall.h          | 69 ++++++++++++++++++------------------
 xen/xsm/xsm_core.c                   |  4 +--
 40 files changed, 169 insertions(+), 162 deletions(-)

diff --git a/xen/arch/x86/compat.c b/xen/arch/x86/compat.c
index 939b449dec29..28281a262a3c 100644
--- a/xen/arch/x86/compat.c
+++ b/xen/arch/x86/compat.c
@@ -15,7 +15,7 @@ typedef long ret_t;
 #endif
 
 /* Legacy hypercall (as of 0x00030202). */
-ret_t do_physdev_op_compat(XEN_GUEST_HANDLE_PARAM(physdev_op_t) uop)
+ret_t cf_check do_physdev_op_compat(XEN_GUEST_HANDLE_PARAM(physdev_op_t) uop)
 {
     struct physdev_op op;
 
@@ -28,7 +28,7 @@ ret_t do_physdev_op_compat(XEN_GUEST_HANDLE_PARAM(physdev_op_t) uop)
 #ifndef COMPAT
 
 /* Legacy hypercall (as of 0x00030101). */
-long do_sched_op_compat(int cmd, unsigned long arg)
+long cf_check do_sched_op_compat(int cmd, unsigned long arg)
 {
     switch ( cmd )
     {
@@ -50,7 +50,8 @@ long do_sched_op_compat(int cmd, unsigned long arg)
 }
 
 /* Legacy hypercall (as of 0x00030202). */
-long do_event_channel_op_compat(XEN_GUEST_HANDLE_PARAM(evtchn_op_t) uop)
+long cf_check do_event_channel_op_compat(
+    XEN_GUEST_HANDLE_PARAM(evtchn_op_t) uop)
 {
     struct evtchn_op op;
 
diff --git a/xen/arch/x86/cpu/mcheck/mce.c b/xen/arch/x86/cpu/mcheck/mce.c
index 7f433343bca3..eae08caa07cd 100644
--- a/xen/arch/x86/cpu/mcheck/mce.c
+++ b/xen/arch/x86/cpu/mcheck/mce.c
@@ -1351,7 +1351,7 @@ CHECK_mcinfo_recovery;
 # endif /* CONFIG_COMPAT */
 
 /* Machine Check Architecture Hypercall */
-long do_mca(XEN_GUEST_HANDLE_PARAM(xen_mc_t) u_xen_mc)
+long cf_check do_mca(XEN_GUEST_HANDLE_PARAM(xen_mc_t) u_xen_mc)
 {
     long ret = 0;
     struct xen_mc curop, *op = &curop;
diff --git a/xen/arch/x86/cpu/vpmu.c b/xen/arch/x86/cpu/vpmu.c
index 8ec4547bedf4..598291f4ece9 100644
--- a/xen/arch/x86/cpu/vpmu.c
+++ b/xen/arch/x86/cpu/vpmu.c
@@ -671,7 +671,8 @@ void vpmu_dump(struct vcpu *v)
         alternative_vcall(vpmu_ops.arch_vpmu_dump, v);
 }
 
-long do_xenpmu_op(unsigned int op, XEN_GUEST_HANDLE_PARAM(xen_pmu_params_t) arg)
+long cf_check do_xenpmu_op(
+    unsigned int op, XEN_GUEST_HANDLE_PARAM(xen_pmu_params_t) arg)
 {
     int ret;
     struct vcpu *curr;
diff --git a/xen/arch/x86/hvm/dm.c b/xen/arch/x86/hvm/dm.c
index b60b9f3364a8..d80975efcf45 100644
--- a/xen/arch/x86/hvm/dm.c
+++ b/xen/arch/x86/hvm/dm.c
@@ -654,9 +654,8 @@ CHECK_dm_op_relocate_memory;
 CHECK_dm_op_pin_memory_cacheattr;
 CHECK_dm_op_nr_vcpus;
 
-int compat_dm_op(domid_t domid,
-                 unsigned int nr_bufs,
-                 XEN_GUEST_HANDLE_PARAM(void) bufs)
+int cf_check compat_dm_op(
+    domid_t domid, unsigned int nr_bufs, XEN_GUEST_HANDLE_PARAM(void) bufs)
 {
     struct dmop_args args;
     unsigned int i;
diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c
index c4ddb8607d9c..4e685c1b0c1b 100644
--- a/xen/arch/x86/hvm/hvm.c
+++ b/xen/arch/x86/hvm/hvm.c
@@ -5015,7 +5015,7 @@ static int hvmop_get_mem_type(
     return rc;
 }
 
-long do_hvm_op(unsigned long op, XEN_GUEST_HANDLE_PARAM(void) arg)
+long cf_check do_hvm_op(unsigned long op, XEN_GUEST_HANDLE_PARAM(void) arg)
 {
     long rc = 0;
 
diff --git a/xen/arch/x86/hvm/hypercall.c b/xen/arch/x86/hvm/hypercall.c
index 384724ec41a3..030243810e48 100644
--- a/xen/arch/x86/hvm/hypercall.c
+++ b/xen/arch/x86/hvm/hypercall.c
@@ -31,7 +31,8 @@
 #include <public/hvm/hvm_op.h>
 #include <public/hvm/params.h>
 
-static long hvm_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
+static long cf_check hvm_memory_op(
+    unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
 {
     long rc;
 
@@ -51,7 +52,7 @@ static long hvm_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
 }
 
 #ifdef CONFIG_GRANT_TABLE
-static long hvm_grant_table_op(
+static long cf_check hvm_grant_table_op(
     unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) uop, unsigned int count)
 {
     switch ( cmd )
diff --git a/xen/arch/x86/include/asm/hypercall.h b/xen/arch/x86/include/asm/hypercall.h
index eb3aed3bf70e..16d8418b5774 100644
--- a/xen/arch/x86/include/asm/hypercall.h
+++ b/xen/arch/x86/include/asm/hypercall.h
@@ -38,97 +38,97 @@ void pv_ring3_init_hypercall_page(void *ptr);
  */
 #define MMU_UPDATE_PREEMPTED          (~(~0U>>1))
 
-extern long
+extern long cf_check
 do_event_channel_op_compat(
     XEN_GUEST_HANDLE_PARAM(evtchn_op_t) uop);
 
 /* Legacy hypercall (as of 0x00030202). */
-extern long do_physdev_op_compat(
+extern long cf_check do_physdev_op_compat(
     XEN_GUEST_HANDLE(physdev_op_t) uop);
 
 /* Legacy hypercall (as of 0x00030101). */
-extern long do_sched_op_compat(
+extern long cf_check do_sched_op_compat(
     int cmd, unsigned long arg);
 
-extern long
+extern long cf_check
 do_set_trap_table(
     XEN_GUEST_HANDLE_PARAM(const_trap_info_t) traps);
 
-extern long
+extern long cf_check
 do_mmu_update(
     XEN_GUEST_HANDLE_PARAM(mmu_update_t) ureqs,
     unsigned int count,
     XEN_GUEST_HANDLE_PARAM(uint) pdone,
     unsigned int foreigndom);
 
-extern long
+extern long cf_check
 do_set_gdt(
     XEN_GUEST_HANDLE_PARAM(xen_ulong_t) frame_list,
     unsigned int entries);
 
-extern long
+extern long cf_check
 do_stack_switch(
     unsigned long ss,
     unsigned long esp);
 
-extern long
+extern long cf_check
 do_fpu_taskswitch(
     int set);
 
-extern long
+extern long cf_check
 do_set_debugreg(
     int reg,
     unsigned long value);
 
-extern unsigned long
+extern unsigned long cf_check
 do_get_debugreg(
     int reg);
 
-extern long
+extern long cf_check
 do_update_descriptor(
     uint64_t gaddr, seg_desc_t desc);
 
-extern long
+extern long cf_check
 do_mca(XEN_GUEST_HANDLE_PARAM(xen_mc_t) u_xen_mc);
 
-extern long
+extern long cf_check
 do_update_va_mapping(
     unsigned long va,
     u64 val64,
     unsigned long flags);
 
-extern long
+extern long cf_check
 do_physdev_op(
     int cmd, XEN_GUEST_HANDLE_PARAM(void) arg);
 
-extern long
+extern long cf_check
 do_update_va_mapping_otherdomain(
     unsigned long va,
     u64 val64,
     unsigned long flags,
     domid_t domid);
 
-extern long
+extern long cf_check
 do_mmuext_op(
     XEN_GUEST_HANDLE_PARAM(mmuext_op_t) uops,
     unsigned int count,
     XEN_GUEST_HANDLE_PARAM(uint) pdone,
     unsigned int foreigndom);
 
-extern long do_callback_op(
+extern long cf_check do_callback_op(
     int cmd, XEN_GUEST_HANDLE_PARAM(const_void) arg);
 
-extern unsigned long
+extern unsigned long cf_check
 do_iret(
     void);
 
-extern long
+extern long cf_check
 do_set_callbacks(
     unsigned long event_address,
     unsigned long failsafe_address,
     unsigned long syscall_address);
 
-extern long
+extern long cf_check
 do_set_segment_base(
     unsigned int which,
     unsigned long base);
@@ -139,7 +139,7 @@ do_set_segment_base(
 #include <compat/physdev.h>
 #include <compat/platform.h>
 
-extern int
+extern int cf_check
 compat_physdev_op(
     int cmd,
     XEN_GUEST_HANDLE_PARAM(void) arg);
@@ -148,44 +148,47 @@ extern int
 arch_compat_vcpu_op(
     int cmd, struct vcpu *v, XEN_GUEST_HANDLE_PARAM(void) arg);
 
-extern int compat_mmuext_op(
+extern int cf_check compat_mmuext_op(
     XEN_GUEST_HANDLE_PARAM(void) arg,
     unsigned int count,
     XEN_GUEST_HANDLE_PARAM(uint) pdone,
     unsigned int foreigndom);
 
 DEFINE_XEN_GUEST_HANDLE(compat_platform_op_t);
-extern int compat_platform_op(
+extern int cf_check compat_platform_op(
     XEN_GUEST_HANDLE_PARAM(compat_platform_op_t) u_xenpf_op);
 
-extern long compat_callback_op(
+extern long cf_check compat_callback_op(
     int cmd, XEN_GUEST_HANDLE(void) arg);
 
-extern int compat_update_va_mapping(
+extern int cf_check compat_update_va_mapping(
     unsigned int va, u32 lo, u32 hi, unsigned int flags);
 
-extern int compat_update_va_mapping_otherdomain(
+extern int cf_check compat_update_va_mapping_otherdomain(
     unsigned int va, u32 lo, u32 hi, unsigned int flags, domid_t domid);
 
 DEFINE_XEN_GUEST_HANDLE(trap_info_compat_t);
-extern int compat_set_trap_table(XEN_GUEST_HANDLE(trap_info_compat_t) traps);
+extern int cf_check compat_set_trap_table(
+    XEN_GUEST_HANDLE(trap_info_compat_t) traps);
 
-extern int compat_set_gdt(
+extern int cf_check compat_set_gdt(
     XEN_GUEST_HANDLE_PARAM(uint) frame_list, unsigned int entries);
 
-extern int compat_update_descriptor(
+extern int cf_check compat_update_descriptor(
     u32 pa_lo, u32 pa_hi, u32 desc_lo, u32 desc_hi);
 
-extern unsigned int compat_iret(void);
+extern unsigned int cf_check compat_iret(void);
 
-extern int compat_nmi_op(unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) arg);
+extern int cf_check compat_nmi_op(
+    unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) arg);
 
-extern long compat_set_callbacks(
+extern long cf_check compat_set_callbacks(
     unsigned long event_selector, unsigned long event_address,
     unsigned long failsafe_selector, unsigned long failsafe_address);
 
 DEFINE_XEN_GUEST_HANDLE(physdev_op_compat_t);
-extern int compat_physdev_op_compat(XEN_GUEST_HANDLE(physdev_op_compat_t) uop);
+extern int cf_check compat_physdev_op_compat(
+    XEN_GUEST_HANDLE(physdev_op_compat_t) uop);
 
 #endif /* CONFIG_COMPAT */
 
diff --git a/xen/arch/x86/include/asm/paging.h b/xen/arch/x86/include/asm/paging.h
index 2ddcfb022c7b..f0b4efc66e2d 100644
--- a/xen/arch/x86/include/asm/paging.h
+++ b/xen/arch/x86/include/asm/paging.h
@@ -235,7 +235,7 @@ int paging_domctl(struct domain *d, struct xen_domctl_shadow_op *sc,
                   bool_t resuming);
 
 /* Helper hypercall for dealing with continuations. */
-long paging_domctl_continuation(XEN_GUEST_HANDLE_PARAM(xen_domctl_t));
+long cf_check paging_domctl_continuation(XEN_GUEST_HANDLE_PARAM(xen_domctl_t));
 
 /* Call when destroying a vcpu/domain */
 void paging_vcpu_teardown(struct vcpu *v);
diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c
index b80e4ab9c564..6484c3b97bbc 100644
--- a/xen/arch/x86/mm.c
+++ b/xen/arch/x86/mm.c
@@ -3377,7 +3377,7 @@ static int vcpumask_to_pcpumask(
     }
 }
 
-long do_mmuext_op(
+long cf_check do_mmuext_op(
     XEN_GUEST_HANDLE_PARAM(mmuext_op_t) uops,
     unsigned int count,
     XEN_GUEST_HANDLE_PARAM(uint) pdone,
@@ -3916,7 +3916,7 @@ long do_mmuext_op(
     return rc;
 }
 
-long do_mmu_update(
+long cf_check do_mmu_update(
     XEN_GUEST_HANDLE_PARAM(mmu_update_t) ureqs,
     unsigned int count,
     XEN_GUEST_HANDLE_PARAM(uint) pdone,
@@ -4501,8 +4501,8 @@ static int __do_update_va_mapping(
     return rc;
 }
 
-long do_update_va_mapping(unsigned long va, u64 val64,
-                          unsigned long flags)
+long cf_check do_update_va_mapping(
+    unsigned long va, u64 val64, unsigned long flags)
 {
     int rc = __do_update_va_mapping(va, val64, flags, current->domain);
 
@@ -4513,9 +4513,8 @@ long do_update_va_mapping(unsigned long va, u64 val64,
     return rc;
 }
 
-long do_update_va_mapping_otherdomain(unsigned long va, u64 val64,
-                                      unsigned long flags,
-                                      domid_t domid)
+long cf_check do_update_va_mapping_otherdomain(
+    unsigned long va, u64 val64, unsigned long flags, domid_t domid)
 {
     struct domain *pg_owner;
     int rc;
@@ -4537,8 +4536,8 @@ long do_update_va_mapping_otherdomain(unsigned long va, u64 val64,
 #endif /* CONFIG_PV */
 
 #ifdef CONFIG_PV32
-int compat_update_va_mapping(unsigned int va, uint32_t lo, uint32_t hi,
-                             unsigned int flags)
+int cf_check compat_update_va_mapping(
+    unsigned int va, uint32_t lo, uint32_t hi, unsigned int flags)
 {
     int rc = __do_update_va_mapping(va, ((uint64_t)hi << 32) | lo,
                                     flags, current->domain);
@@ -4550,9 +4549,9 @@ int compat_update_va_mapping(unsigned int va, uint32_t lo, uint32_t hi,
     return rc;
 }
 
-int compat_update_va_mapping_otherdomain(unsigned int va,
-                                         uint32_t lo, uint32_t hi,
-                                         unsigned int flags, domid_t domid)
+int cf_check compat_update_va_mapping_otherdomain(
+    unsigned int va, uint32_t lo, uint32_t hi, unsigned int flags,
+    domid_t domid)
 {
     struct domain *pg_owner;
     int rc;
diff --git a/xen/arch/x86/mm/paging.c b/xen/arch/x86/mm/paging.c
index dc3a4a0b4bb1..1f0b94ad212a 100644
--- a/xen/arch/x86/mm/paging.c
+++ b/xen/arch/x86/mm/paging.c
@@ -759,7 +759,8 @@ int paging_domctl(struct domain *d, struct xen_domctl_shadow_op *sc,
         return shadow_domctl(d, sc, u_domctl);
 }
 
-long paging_domctl_continuation(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl)
+long cf_check paging_domctl_continuation(
+    XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl)
 {
     struct xen_domctl op;
     struct domain *d;
diff --git a/xen/arch/x86/physdev.c b/xen/arch/x86/physdev.c
index ea38be8b797a..2ddcf44f33a4 100644
--- a/xen/arch/x86/physdev.c
+++ b/xen/arch/x86/physdev.c
@@ -174,7 +174,7 @@ int physdev_unmap_pirq(domid_t domid, int pirq)
 }
 #endif /* COMPAT */
 
-ret_t do_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
+ret_t cf_check do_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
 {
     int irq;
     ret_t ret;
diff --git a/xen/arch/x86/platform_hypercall.c b/xen/arch/x86/platform_hypercall.c
index bf4090c94201..84566bbfaa3d 100644
--- a/xen/arch/x86/platform_hypercall.c
+++ b/xen/arch/x86/platform_hypercall.c
@@ -213,7 +213,8 @@ void resource_access(void *info)
 }
 #endif
 
-ret_t do_platform_op(XEN_GUEST_HANDLE_PARAM(xen_platform_op_t) u_xenpf_op)
+ret_t cf_check do_platform_op(
+    XEN_GUEST_HANDLE_PARAM(xen_platform_op_t) u_xenpf_op)
 {
     ret_t ret;
     struct xen_platform_op curop, *op = &curop;
diff --git a/xen/arch/x86/pv/callback.c b/xen/arch/x86/pv/callback.c
index 42a6aa0831b7..55148c7f9e50 100644
--- a/xen/arch/x86/pv/callback.c
+++ b/xen/arch/x86/pv/callback.c
@@ -140,7 +140,7 @@ static long unregister_guest_callback(struct callback_unregister *unreg)
     return ret;
 }
 
-long do_callback_op(int cmd, XEN_GUEST_HANDLE_PARAM(const_void) arg)
+long cf_check do_callback_op(int cmd, XEN_GUEST_HANDLE_PARAM(const_void) arg)
 {
     long ret;
 
@@ -178,9 +178,9 @@ long do_callback_op(int cmd, XEN_GUEST_HANDLE_PARAM(const_void) arg)
     return ret;
 }
 
-long do_set_callbacks(unsigned long event_address,
-                      unsigned long failsafe_address,
-                      unsigned long syscall_address)
+long cf_check do_set_callbacks(
+    unsigned long event_address, unsigned long failsafe_address,
+    unsigned long syscall_address)
 {
     struct callback_register event = {
         .type = CALLBACKTYPE_event,
@@ -283,7 +283,7 @@ static long compat_unregister_guest_callback(
     return ret;
 }
 
-long compat_callback_op(int cmd, XEN_GUEST_HANDLE(void) arg)
+long cf_check compat_callback_op(int cmd, XEN_GUEST_HANDLE(void) arg)
 {
     long ret;
 
@@ -321,10 +321,9 @@ long compat_callback_op(int cmd, XEN_GUEST_HANDLE(void) arg)
     return ret;
 }
 
-long compat_set_callbacks(unsigned long event_selector,
-                          unsigned long event_address,
-                          unsigned long failsafe_selector,
-                          unsigned long failsafe_address)
+long cf_check compat_set_callbacks(
+    unsigned long event_selector, unsigned long event_address,
+    unsigned long failsafe_selector, unsigned long failsafe_address)
 {
     struct compat_callback_register event = {
         .type = CALLBACKTYPE_event,
@@ -349,7 +348,7 @@ long compat_set_callbacks(unsigned long event_selector,
 
 #endif /* CONFIG_PV32 */
 
-long do_set_trap_table(XEN_GUEST_HANDLE_PARAM(const_trap_info_t) traps)
+long cf_check do_set_trap_table(XEN_GUEST_HANDLE_PARAM(const_trap_info_t) traps)
 {
     struct trap_info cur;
     struct vcpu *curr = current;
@@ -395,7 +394,7 @@ long do_set_trap_table(XEN_GUEST_HANDLE_PARAM(const_trap_info_t) traps)
 }
 
 #ifdef CONFIG_PV32
-int compat_set_trap_table(XEN_GUEST_HANDLE(trap_info_compat_t) traps)
+int cf_check compat_set_trap_table(XEN_GUEST_HANDLE(trap_info_compat_t) traps)
 {
     struct vcpu *curr = current;
     struct compat_trap_info cur;
@@ -438,7 +437,7 @@ int compat_set_trap_table(XEN_GUEST_HANDLE(trap_info_compat_t) traps)
 }
 #endif
 
-long do_nmi_op(unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
+long cf_check do_nmi_op(unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
 {
     struct xennmi_callback cb;
     long rc = 0;
@@ -464,7 +463,7 @@ long do_nmi_op(unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
 }
 
 #ifdef CONFIG_PV32
-int compat_nmi_op(unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
+int cf_check compat_nmi_op(unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
 {
     struct compat_nmi_callback cb;
     int rc = 0;
diff --git a/xen/arch/x86/pv/descriptor-tables.c b/xen/arch/x86/pv/descriptor-tables.c
index 5e847044009b..653a61d0b518 100644
--- a/xen/arch/x86/pv/descriptor-tables.c
+++ b/xen/arch/x86/pv/descriptor-tables.c
@@ -124,8 +124,8 @@ int pv_set_gdt(struct vcpu *v, const unsigned long frames[],
     return -EINVAL;
 }
 
-long do_set_gdt(XEN_GUEST_HANDLE_PARAM(xen_ulong_t) frame_list,
-                unsigned int entries)
+long cf_check do_set_gdt(
+    XEN_GUEST_HANDLE_PARAM(xen_ulong_t) frame_list, unsigned int entries)
 {
     unsigned int nr_frames = DIV_ROUND_UP(entries, 512);
     unsigned long frames[16];
@@ -151,8 +151,8 @@ long do_set_gdt(XEN_GUEST_HANDLE_PARAM(xen_ulong_t) frame_list,
 
 #ifdef CONFIG_PV32
 
-int compat_set_gdt(XEN_GUEST_HANDLE_PARAM(uint) frame_list,
-                   unsigned int entries)
+int cf_check compat_set_gdt(
+    XEN_GUEST_HANDLE_PARAM(uint) frame_list, unsigned int entries)
 {
     struct vcpu *curr = current;
     unsigned int i, nr_frames = DIV_ROUND_UP(entries, 512);
@@ -187,8 +187,8 @@ int compat_set_gdt(XEN_GUEST_HANDLE_PARAM(uint) frame_list,
     return ret;
 }
 
-int compat_update_descriptor(uint32_t pa_lo, uint32_t pa_hi,
-                             uint32_t desc_lo, uint32_t desc_hi)
+int cf_check compat_update_descriptor(
+    uint32_t pa_lo, uint32_t pa_hi, uint32_t desc_lo, uint32_t desc_hi)
 {
     seg_desc_t d;
 
@@ -299,7 +299,7 @@ int validate_segdesc_page(struct page_info *page)
     return i == 512 ? 0 : -EINVAL;
 }
 
-long do_update_descriptor(uint64_t gaddr, seg_desc_t d)
+long cf_check do_update_descriptor(uint64_t gaddr, seg_desc_t d)
 {
     struct domain *currd = current->domain;
     gfn_t gfn = gaddr_to_gfn(gaddr);
diff --git a/xen/arch/x86/pv/iret.c b/xen/arch/x86/pv/iret.c
index 29a2f7cc452b..dd2965d8f08d 100644
--- a/xen/arch/x86/pv/iret.c
+++ b/xen/arch/x86/pv/iret.c
@@ -48,7 +48,7 @@ static void async_exception_cleanup(struct vcpu *curr)
         curr->arch.async_exception_state(trap).old_mask;
 }
 
-unsigned long do_iret(void)
+unsigned long cf_check do_iret(void)
 {
     struct cpu_user_regs *regs = guest_cpu_user_regs();
     struct iret_context iret_saved;
@@ -105,7 +105,7 @@ unsigned long do_iret(void)
 }
 
 #ifdef CONFIG_PV32
-unsigned int compat_iret(void)
+unsigned int cf_check compat_iret(void)
 {
     struct cpu_user_regs *regs = guest_cpu_user_regs();
     struct vcpu *v = current;
diff --git a/xen/arch/x86/pv/misc-hypercalls.c b/xen/arch/x86/pv/misc-hypercalls.c
index 5dade2472687..5649aaab4436 100644
--- a/xen/arch/x86/pv/misc-hypercalls.c
+++ b/xen/arch/x86/pv/misc-hypercalls.c
@@ -23,12 +23,12 @@
 
 #include <asm/debugreg.h>
 
-long do_set_debugreg(int reg, unsigned long value)
+long cf_check do_set_debugreg(int reg, unsigned long value)
 {
     return set_debugreg(current, reg, value);
 }
 
-unsigned long do_get_debugreg(int reg)
+unsigned long cf_check do_get_debugreg(int reg)
 {
     unsigned long val;
     int res = x86emul_read_dr(reg, &val, NULL);
@@ -36,7 +36,7 @@ unsigned long do_get_debugreg(int reg)
     return res == X86EMUL_OKAY ? val : -ENODEV;
 }
 
-long do_fpu_taskswitch(int set)
+long cf_check do_fpu_taskswitch(int set)
 {
     struct vcpu *v = current;
 
@@ -171,7 +171,7 @@ long set_debugreg(struct vcpu *v, unsigned int reg, unsigned long value)
     return 0;
 }
 
-long do_stack_switch(unsigned long ss, unsigned long esp)
+long cf_check do_stack_switch(unsigned long ss, unsigned long esp)
 {
     fixup_guest_stack_selector(current->domain, ss);
     current->arch.pv.kernel_ss = ss;
@@ -180,7 +180,7 @@ long do_stack_switch(unsigned long ss, unsigned long esp)
     return 0;
 }
 
-long do_set_segment_base(unsigned int which, unsigned long base)
+long cf_check do_set_segment_base(unsigned int which, unsigned long base)
 {
     struct vcpu *v = current;
     long ret = 0;
diff --git a/xen/arch/x86/pv/shim.c b/xen/arch/x86/pv/shim.c
index 7e891fe2f7a4..4c710ad8913f 100644
--- a/xen/arch/x86/pv/shim.c
+++ b/xen/arch/x86/pv/shim.c
@@ -824,8 +824,8 @@ long pv_shim_grant_table_op(unsigned int cmd,
 
 #ifndef CONFIG_GRANT_TABLE
 /* Thin wrapper(s) needed. */
-long do_grant_table_op(unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) uop,
-                       unsigned int count)
+long cf_check do_grant_table_op(
+    unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) uop, unsigned int count)
 {
     if ( !pv_shim )
         return -ENOSYS;
@@ -834,8 +834,8 @@ long do_grant_table_op(unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) uop,
 }
 
 #ifdef CONFIG_PV32
-int compat_grant_table_op(unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) uop,
-                          unsigned int count)
+int cf_check compat_grant_table_op(
+    unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) uop, unsigned int count)
 {
     if ( !pv_shim )
         return -ENOSYS;
diff --git a/xen/arch/x86/x86_64/compat/mm.c b/xen/arch/x86/x86_64/compat/mm.c
index 215e96aba032..b3da8fafbb0c 100644
--- a/xen/arch/x86/x86_64/compat/mm.c
+++ b/xen/arch/x86/x86_64/compat/mm.c
@@ -176,10 +176,9 @@ int compat_arch_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
 #ifdef CONFIG_PV
 DEFINE_XEN_GUEST_HANDLE(mmuext_op_compat_t);
 
-int compat_mmuext_op(XEN_GUEST_HANDLE_PARAM(void) arg,
-                     unsigned int count,
-                     XEN_GUEST_HANDLE_PARAM(uint) pdone,
-                     unsigned int foreigndom)
+int cf_check compat_mmuext_op(
+    XEN_GUEST_HANDLE_PARAM(void) arg, unsigned int count,
+    XEN_GUEST_HANDLE_PARAM(uint) pdone, unsigned int foreigndom)
 {
     unsigned int i, preempt_mask;
     int rc = 0;
diff --git a/xen/common/argo.c b/xen/common/argo.c
index eaea7ba8885a..1448faf65731 100644
--- a/xen/common/argo.c
+++ b/xen/common/argo.c
@@ -2069,7 +2069,7 @@ sendv(struct domain *src_d, xen_argo_addr_t *src_addr,
     return ( ret < 0 ) ? ret : len;
 }
 
-long
+long cf_check
 do_argo_op(unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) arg1,
            XEN_GUEST_HANDLE_PARAM(void) arg2, unsigned long raw_arg3,
            unsigned long raw_arg4)
@@ -2207,7 +2207,7 @@ do_argo_op(unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) arg1,
 }
 
 #ifdef CONFIG_COMPAT
-long
+long cf_check
 compat_argo_op(unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) arg1,
                XEN_GUEST_HANDLE_PARAM(void) arg2, unsigned long arg3,
                unsigned long arg4)
diff --git a/xen/common/compat/domain.c b/xen/common/compat/domain.c
index 98b8c15cea7f..afae27eeba02 100644
--- a/xen/common/compat/domain.c
+++ b/xen/common/compat/domain.c
@@ -38,7 +38,8 @@ CHECK_vcpu_hvm_context;
 
 #endif
 
-int compat_vcpu_op(int cmd, unsigned int vcpuid, XEN_GUEST_HANDLE_PARAM(void) arg)
+int cf_check compat_vcpu_op(
+    int cmd, unsigned int vcpuid, XEN_GUEST_HANDLE_PARAM(void) arg)
 {
     struct domain *d = current->domain;
     struct vcpu *v;
diff --git a/xen/common/compat/grant_table.c b/xen/common/compat/grant_table.c
index ff1d678f01c7..c6199e89188d 100644
--- a/xen/common/compat/grant_table.c
+++ b/xen/common/compat/grant_table.c
@@ -55,9 +55,8 @@ CHECK_gnttab_swap_grant_ref;
 CHECK_gnttab_cache_flush;
 #undef xen_gnttab_cache_flush
 
-int compat_grant_table_op(unsigned int cmd,
-                          XEN_GUEST_HANDLE_PARAM(void) cmp_uop,
-                          unsigned int count)
+int cf_check compat_grant_table_op(
+    unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) cmp_uop, unsigned int count)
 {
     int rc = 0;
     unsigned int i, cmd_op;
diff --git a/xen/common/compat/kernel.c b/xen/common/compat/kernel.c
index 804b919bdc72..8e8c413bf1d0 100644
--- a/xen/common/compat/kernel.c
+++ b/xen/common/compat/kernel.c
@@ -37,7 +37,7 @@ CHECK_TYPE(capabilities_info);
 
 CHECK_TYPE(domain_handle);
 
-#define DO(fn) int compat_##fn
+#define DO(fn) int cf_check compat_##fn
 #define COMPAT
 
 #include "../kernel.c"
diff --git a/xen/common/compat/memory.c b/xen/common/compat/memory.c
index c43fa97cf15f..ec8ba54bb66e 100644
--- a/xen/common/compat/memory.c
+++ b/xen/common/compat/memory.c
@@ -53,7 +53,8 @@ static int get_reserved_device_memory(xen_pfn_t start, xen_ulong_t nr,
 }
 #endif
 
-int compat_memory_op(unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) compat)
+int cf_check compat_memory_op(
+    unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) compat)
 {
     struct vcpu *curr = current;
     struct domain *currd = curr->domain;
diff --git a/xen/common/dm.c b/xen/common/dm.c
index 2d1d98ca583e..fcb3a1aa0557 100644
--- a/xen/common/dm.c
+++ b/xen/common/dm.c
@@ -19,9 +19,9 @@
 #include <xen/hypercall.h>
 #include <xen/nospec.h>
 
-long do_dm_op(domid_t domid,
-              unsigned int nr_bufs,
-              XEN_GUEST_HANDLE_PARAM(xen_dm_op_buf_t) bufs)
+long cf_check do_dm_op(
+    domid_t domid, unsigned int nr_bufs,
+    XEN_GUEST_HANDLE_PARAM(xen_dm_op_buf_t) bufs)
 {
     struct dmop_args args;
     int rc;
diff --git a/xen/common/domain.c b/xen/common/domain.c
index 571ef4fe615e..e58c0bd4ddc4 100644
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -1603,7 +1603,8 @@ int default_initialise_vcpu(struct vcpu *v, XEN_GUEST_HANDLE_PARAM(void) arg)
     return rc;
 }
 
-long do_vcpu_op(int cmd, unsigned int vcpuid, XEN_GUEST_HANDLE_PARAM(void) arg)
+long cf_check do_vcpu_op(
+    int cmd, unsigned int vcpuid, XEN_GUEST_HANDLE_PARAM(void) arg)
 {
     struct domain *d = current->domain;
     struct vcpu *v;
@@ -1790,7 +1791,7 @@ long do_vcpu_op(int cmd, unsigned int vcpuid, XEN_GUEST_HANDLE_PARAM(void) arg)
 }
 
 #ifdef arch_vm_assist_valid_mask
-long do_vm_assist(unsigned int cmd, unsigned int type)
+long cf_check do_vm_assist(unsigned int cmd, unsigned int type)
 {
     struct domain *currd = current->domain;
     const unsigned long valid = arch_vm_assist_valid_mask(currd);
diff --git a/xen/common/domctl.c b/xen/common/domctl.c
index 879a2adcbeb0..9606fa4f1aed 100644
--- a/xen/common/domctl.c
+++ b/xen/common/domctl.c
@@ -274,7 +274,7 @@ static struct vnuma_info *vnuma_init(const struct xen_domctl_vnuma *uinfo,
     return ERR_PTR(ret);
 }
 
-long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl)
+long cf_check do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl)
 {
     long ret = 0;
     bool_t copyback = 0;
diff --git a/xen/common/event_channel.c b/xen/common/event_channel.c
index c9912122d1e5..a5ee8b8ebf76 100644
--- a/xen/common/event_channel.c
+++ b/xen/common/event_channel.c
@@ -1189,7 +1189,7 @@ static int evtchn_set_priority(const struct evtchn_set_priority *set_priority)
     return ret;
 }
 
-long do_event_channel_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
+long cf_check do_event_channel_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
 {
     int rc;
 
diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c
index 925ed7d6bee2..153332b7bfbe 100644
--- a/xen/common/grant_table.c
+++ b/xen/common/grant_table.c
@@ -3558,7 +3558,7 @@ gnttab_cache_flush(XEN_GUEST_HANDLE_PARAM(gnttab_cache_flush_t) uop,
     return 0;
 }
 
-long
+long cf_check
 do_grant_table_op(
     unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) uop, unsigned int count)
 {
diff --git a/xen/common/hypfs.c b/xen/common/hypfs.c
index e71f7df47958..1526bcc52810 100644
--- a/xen/common/hypfs.c
+++ b/xen/common/hypfs.c
@@ -671,9 +671,9 @@ static int hypfs_write(struct hypfs_entry *entry,
     return entry->funcs->write(l, uaddr, ulen);
 }
 
-long do_hypfs_op(unsigned int cmd,
-                 XEN_GUEST_HANDLE_PARAM(const_char) arg1, unsigned long arg2,
-                 XEN_GUEST_HANDLE_PARAM(void) arg3, unsigned long arg4)
+long cf_check do_hypfs_op(
+    unsigned int cmd, XEN_GUEST_HANDLE_PARAM(const_char) arg1,
+    unsigned long arg2, XEN_GUEST_HANDLE_PARAM(void) arg3, unsigned long arg4)
 {
     int ret;
     struct hypfs_entry *entry;
diff --git a/xen/common/kernel.c b/xen/common/kernel.c
index e119e5401f9d..752c2e0dae44 100644
--- a/xen/common/kernel.c
+++ b/xen/common/kernel.c
@@ -451,7 +451,7 @@ static int __init param_init(void)
 __initcall(param_init);
 #endif
 
-# define DO(fn) long do_##fn
+# define DO(fn) long cf_check do_##fn
 
 #endif
 
diff --git a/xen/common/kexec.c b/xen/common/kexec.c
index c63db618a707..8471590aeea2 100644
--- a/xen/common/kexec.c
+++ b/xen/common/kexec.c
@@ -1265,13 +1265,13 @@ static int do_kexec_op_internal(unsigned long op,
     return ret;
 }
 
-long do_kexec_op(unsigned long op, XEN_GUEST_HANDLE_PARAM(void) uarg)
+long cf_check do_kexec_op(unsigned long op, XEN_GUEST_HANDLE_PARAM(void) uarg)
 {
     return do_kexec_op_internal(op, uarg, 0);
 }
 
 #ifdef CONFIG_COMPAT
-int compat_kexec_op(unsigned long op, XEN_GUEST_HANDLE_PARAM(void) uarg)
+int cf_check compat_kexec_op(unsigned long op, XEN_GUEST_HANDLE_PARAM(void) uarg)
 {
     return do_kexec_op_internal(op, uarg, 1);
 }
diff --git a/xen/common/memory.c b/xen/common/memory.c
index 0d7c413df820..38732dde6fd7 100644
--- a/xen/common/memory.c
+++ b/xen/common/memory.c
@@ -1367,7 +1367,7 @@ static int acquire_resource(
     return rc;
 }
 
-long do_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
+long cf_check do_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
 {
     struct domain *d, *curr_d = current->domain;
     long rc;
diff --git a/xen/common/multicall.c b/xen/common/multicall.c
index 794638392b40..e48f46dbe011 100644
--- a/xen/common/multicall.c
+++ b/xen/common/multicall.c
@@ -32,7 +32,7 @@ static void trace_multicall_call(multicall_entry_t *call)
     __trace_multicall_call(call);
 }
 
-ret_t
+ret_t cf_check
 do_multicall(
     XEN_GUEST_HANDLE_PARAM(multicall_entry_t) call_list, uint32_t nr_calls)
 {
diff --git a/xen/common/sched/compat.c b/xen/common/sched/compat.c
index 040b4caca2c4..66ba0fe88f2e 100644
--- a/xen/common/sched/compat.c
+++ b/xen/common/sched/compat.c
@@ -39,7 +39,7 @@ static int compat_poll(struct compat_sched_poll *compat)
 
 #include "core.c"
 
-int compat_set_timer_op(u32 lo, s32 hi)
+int cf_check compat_set_timer_op(u32 lo, s32 hi)
 {
     return do_set_timer_op(((s64)hi << 32) | lo);
 }
diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c
index 8f4b1ca10d1c..0f527024ba2e 100644
--- a/xen/common/sched/core.c
+++ b/xen/common/sched/core.c
@@ -1862,7 +1862,7 @@ typedef long ret_t;
 
 #endif /* !COMPAT */
 
-ret_t do_sched_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
+ret_t cf_check do_sched_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
 {
     ret_t ret = 0;
 
@@ -1999,7 +1999,7 @@ ret_t do_sched_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
 #ifndef COMPAT
 
 /* Per-vcpu oneshot-timer hypercall. */
-long do_set_timer_op(s_time_t timeout)
+long cf_check do_set_timer_op(s_time_t timeout)
 {
     struct vcpu *v = current;
     s_time_t offset = timeout - NOW();
diff --git a/xen/common/sysctl.c b/xen/common/sysctl.c
index 1ad3c29351db..fc4a0b31d6f0 100644
--- a/xen/common/sysctl.c
+++ b/xen/common/sysctl.c
@@ -29,7 +29,7 @@
 #include <xen/livepatch.h>
 #include <xen/coverage.h>
 
-long do_sysctl(XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) u_sysctl)
+long cf_check do_sysctl(XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) u_sysctl)
 {
     long ret = 0;
     int copyback = -1;
diff --git a/xen/common/xenoprof.c b/xen/common/xenoprof.c
index 1926a92fe481..af617f1d0b83 100644
--- a/xen/common/xenoprof.c
+++ b/xen/common/xenoprof.c
@@ -721,7 +721,7 @@ static int xenoprof_op_get_buffer(XEN_GUEST_HANDLE_PARAM(void) arg)
                       || (op == XENOPROF_disable_virq)  \
                       || (op == XENOPROF_get_buffer))
  
-ret_t do_xenoprof_op(int op, XEN_GUEST_HANDLE_PARAM(void) arg)
+ret_t cf_check do_xenoprof_op(int op, XEN_GUEST_HANDLE_PARAM(void) arg)
 {
     int ret = 0;
     
diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c
index 7d0a603d0311..a043e9521afd 100644
--- a/xen/drivers/char/console.c
+++ b/xen/drivers/char/console.c
@@ -675,8 +675,8 @@ static long guest_console_write(XEN_GUEST_HANDLE_PARAM(char) buffer,
     return 0;
 }
 
-long do_console_io(unsigned int cmd, unsigned int count,
-                   XEN_GUEST_HANDLE_PARAM(char) buffer)
+long cf_check do_console_io(
+    unsigned int cmd, unsigned int count, XEN_GUEST_HANDLE_PARAM(char) buffer)
 {
     long rc;
     unsigned int idx, len;
diff --git a/xen/include/xen/hypercall.h b/xen/include/xen/hypercall.h
index 07b10ec2303b..4dfd64cf716c 100644
--- a/xen/include/xen/hypercall.h
+++ b/xen/include/xen/hypercall.h
@@ -18,12 +18,12 @@
 #include <asm/hypercall.h>
 #include <xsm/xsm.h>
 
-extern long
+extern long cf_check
 do_sched_op(
     int cmd,
     XEN_GUEST_HANDLE_PARAM(void) arg);
 
-extern long
+extern long cf_check
 do_domctl(
     XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl);
 
@@ -32,7 +32,7 @@ arch_do_domctl(
     struct xen_domctl *domctl, struct domain *d,
     XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl);
 
-extern long
+extern long cf_check
 do_sysctl(
     XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) u_sysctl);
 
@@ -41,7 +41,7 @@ arch_do_sysctl(
     struct xen_sysctl *sysctl,
     XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) u_sysctl);
 
-extern long
+extern long cf_check
 do_platform_op(
     XEN_GUEST_HANDLE_PARAM(xen_platform_op_t) u_xenpf_op);
 
@@ -62,47 +62,47 @@ pci_physdev_op(
 #define MEMOP_EXTENT_SHIFT 6 /* cmd[:6] == start_extent */
 #define MEMOP_CMD_MASK     ((1 << MEMOP_EXTENT_SHIFT) - 1)
 
-extern long
+extern long cf_check
 do_memory_op(
     unsigned long cmd,
     XEN_GUEST_HANDLE_PARAM(void) arg);
 
-extern long
+extern long cf_check
 do_multicall(
     XEN_GUEST_HANDLE_PARAM(multicall_entry_t) call_list,
     unsigned int nr_calls);
 
-extern long
+extern long cf_check
 do_set_timer_op(
     s_time_t timeout);
 
-extern long
+extern long cf_check
 do_event_channel_op(
     int cmd, XEN_GUEST_HANDLE_PARAM(void) arg);
 
-extern long
+extern long cf_check
 do_xen_version(
     int cmd,
     XEN_GUEST_HANDLE_PARAM(void) arg);
 
-extern long
+extern long cf_check
 do_console_io(
     unsigned int cmd,
     unsigned int count,
     XEN_GUEST_HANDLE_PARAM(char) buffer);
 
-extern long
+extern long cf_check
 do_grant_table_op(
     unsigned int cmd,
     XEN_GUEST_HANDLE_PARAM(void) uop,
     unsigned int count);
 
-extern long
+extern long cf_check
 do_vm_assist(
     unsigned int cmd,
     unsigned int type);
 
-extern long
+extern long cf_check
 do_vcpu_op(
     int cmd,
     unsigned int vcpuid,
@@ -114,27 +114,27 @@ arch_do_vcpu_op(int cmd,
     struct vcpu *v,
     XEN_GUEST_HANDLE_PARAM(void) arg);
 
-extern long
+extern long cf_check
 do_nmi_op(
     unsigned int cmd,
     XEN_GUEST_HANDLE_PARAM(void) arg);
 
-extern long
+extern long cf_check
 do_hvm_op(
     unsigned long op,
     XEN_GUEST_HANDLE_PARAM(void) arg);
 
-extern long
+extern long cf_check
 do_kexec_op(
     unsigned long op,
     XEN_GUEST_HANDLE_PARAM(void) uarg);
 
-extern long
+extern long cf_check
 do_xsm_op(
     XEN_GUEST_HANDLE_PARAM(void) u_xsm_op);
 
 #ifdef CONFIG_ARGO
-extern long do_argo_op(
+extern long cf_check do_argo_op(
     unsigned int cmd,
     XEN_GUEST_HANDLE_PARAM(void) arg1,
     XEN_GUEST_HANDLE_PARAM(void) arg2,
@@ -142,20 +142,20 @@ extern long do_argo_op(
     unsigned long arg4);
 #endif
 
-extern long
+extern long cf_check
 do_xenoprof_op(int op, XEN_GUEST_HANDLE_PARAM(void) arg);
 
-extern long
+extern long cf_check
 do_xenpmu_op(unsigned int op, XEN_GUEST_HANDLE_PARAM(xen_pmu_params_t) arg);
 
-extern long
+extern long cf_check
 do_dm_op(
     domid_t domid,
     unsigned int nr_bufs,
     XEN_GUEST_HANDLE_PARAM(xen_dm_op_buf_t) bufs);
 
 #ifdef CONFIG_HYPFS
-extern long
+extern long cf_check
 do_hypfs_op(
     unsigned int cmd,
     XEN_GUEST_HANDLE_PARAM(const_char) arg1,
@@ -166,53 +166,54 @@ do_hypfs_op(
 
 #ifdef CONFIG_COMPAT
 
-extern int
+extern int cf_check
 compat_memory_op(
     unsigned int cmd,
     XEN_GUEST_HANDLE_PARAM(void) arg);
 
-extern int
+extern int cf_check
 compat_grant_table_op(
     unsigned int cmd,
     XEN_GUEST_HANDLE_PARAM(void) uop,
     unsigned int count);
 
-extern int
+extern int cf_check
 compat_vcpu_op(
     int cmd,
     unsigned int vcpuid,
     XEN_GUEST_HANDLE_PARAM(void) arg);
 
-extern int
+extern int cf_check
 compat_xenoprof_op(int op, XEN_GUEST_HANDLE_PARAM(void) arg);
 
-extern int
+extern int cf_check
 compat_xen_version(
     int cmd,
     XEN_GUEST_HANDLE_PARAM(void) arg);
 
-extern int
+extern int cf_check
 compat_sched_op(
     int cmd,
     XEN_GUEST_HANDLE_PARAM(void) arg);
 
-extern int
+extern int cf_check
 compat_set_timer_op(
     u32 lo,
     s32 hi);
 
-extern int compat_xsm_op(
+extern int cf_check compat_xsm_op(
     XEN_GUEST_HANDLE_PARAM(void) op);
 
-extern int compat_kexec_op(unsigned long op, XEN_GUEST_HANDLE_PARAM(void) uarg);
+extern int cf_check compat_kexec_op(
+    unsigned long op, XEN_GUEST_HANDLE_PARAM(void) uarg);
 
 DEFINE_XEN_GUEST_HANDLE(multicall_entry_compat_t);
-extern int compat_multicall(
+extern int cf_check compat_multicall(
     XEN_GUEST_HANDLE_PARAM(multicall_entry_compat_t) call_list,
     uint32_t nr_calls);
 
 #ifdef CONFIG_ARGO
-extern long compat_argo_op(
+extern long cf_check compat_argo_op(
     unsigned int cmd,
     XEN_GUEST_HANDLE_PARAM(void) arg1,
     XEN_GUEST_HANDLE_PARAM(void) arg2,
@@ -220,7 +221,7 @@ extern long compat_argo_op(
     unsigned long arg4);
 #endif
 
-extern int
+extern int cf_check
 compat_dm_op(
     domid_t domid,
     unsigned int nr_bufs,
diff --git a/xen/xsm/xsm_core.c b/xen/xsm/xsm_core.c
index 14d98f1f725f..5fc3a5f75478 100644
--- a/xen/xsm/xsm_core.c
+++ b/xen/xsm/xsm_core.c
@@ -219,13 +219,13 @@ bool __init has_xsm_magic(paddr_t start)
 
 #endif
 
-long do_xsm_op(XEN_GUEST_HANDLE_PARAM(void) op)
+long cf_check do_xsm_op(XEN_GUEST_HANDLE_PARAM(void) op)
 {
     return xsm_do_xsm_op(op);
 }
 
 #ifdef CONFIG_COMPAT
-int compat_xsm_op(XEN_GUEST_HANDLE_PARAM(void) op)
+int cf_check compat_xsm_op(XEN_GUEST_HANDLE_PARAM(void) op)
 {
     return xsm_do_compat_op(op);
 }
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 12:52:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 12:52:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271509.466038 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJapr-0006Ny-Bx; Mon, 14 Feb 2022 12:52:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271509.466038; Mon, 14 Feb 2022 12:52:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJapr-0006NK-43; Mon, 14 Feb 2022 12:52:07 +0000
Received: by outflank-mailman (input) for mailman id 271509;
 Mon, 14 Feb 2022 12:52:05 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJapp-0003jk-Hz
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 12:52:05 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e7d49223-8d94-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 13:52:04 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e7d49223-8d94-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644843124;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=oxJaFnzRqRx4KksSzKdm9U/GeHdsnrwelajX2UNO1Ws=;
  b=QWiTa+KJGTp3Ol0d5YAtgCRtnzxPfBUgVnXUp5JZwSnWb2U/p7g3NX6B
   dABX5IFCTBNC4kF72yyLtowF/AuG0EQEzWCdxAOEQtsCOMMHGecoFecF2
   1wWbTv3SS5NIvDr/iNK9Bvq0z7/F7JflbgTTiCa+HydrPjn0nY2QPbKCI
   c=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: xsBF8hEax4w9v1BBDx5lBacOYqJkw1ZtbWPKGqe3M74rDPMUYHUwo4NUX65uOjv8NjT9PxHecG
 cSMSVGRJWv5YkhU0C9cZNM5hkj+toofGDFUNpWrnO6cYIxpSzEDVhndGhBoBkFVMUZOB2m+2sK
 /M8Yo/4460TajJqgOsVrwt63Kiu89raAL5mQP/4TbkCJN6t7Ou/EAEhX1htranQBAxyk2R0BVP
 YO6qkiNL1+cfeFYDuDnwxZUCNLx+4ZsrauR6dfviqssZeCB8y1OyWYqwfgHKBGiVIDkiiFpNfS
 1RFlJboZXgXCy7EAi/DR8PoE
X-SBRS: 5.1
X-MesageID: 64553121
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:nJyemqk0CKoYXB36bu28rk7o5gy/IURdPkR7XQ2eYbSJt1+Wr1Gzt
 xIaDWrVb66JYGX0c4sgbd/i900HsZPUyYUwQFM4rC9mHyMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BClVlxJVF/fngqoDUUYYoAQgsA180IMsdoUg7wbRh2Nc02YHR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 Ndykq2vTUArB47nsc46Dl5nKHtbOYQTrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBODtMJkSpTdLyjbBAOx9aZvCX7/L9ZlT2zJYasVmQ6qDO
 pFAM2MHgBLoODhNZVUXE70Hoeb3uVr5Ly9VugmZqv9ii4TU5FMoi+W8WDbPQfSPTN9Ql1yVp
 UrH+Xr4GRAQMNGDyTuD/Wmoj+WJliT+MKoCGbv9+vN0jVm7wm0IFAZQRVa9ueO+iEO1R5RYM
 UN8x8Y1hfFsrgrxFIC7BkDm5i7f1vIBZzZOO+8FzzCSzu3W2iWyL0IjE3l+U4YDsOZjEFTGy
 WS1t9/uADVutpicRnSc6qqYoFuOBMQFEYMRTXRaFFVYurEPtKl210uSFYg7TMZZm/WoQWmY/
 tyckMQpa1z/Z+Yv3r7zw13IiinESnPhHl9svVW/so5IA2pEiG+Zi26AtAKzARVodt/xory9U
 J8swZb20Qz2JcvR/BFhuc1UdF1T296LMSfHnXlkFIQ7+jKm9haLJN4MvG4udBo0ap9fI1cFh
 XM/XisLuvdu0IaCN/crM+pd9ex2pUQfKTgVfq+NNYcfCnSAXASG4DtvdSatM5PFyyARfVUEE
 c7DK66EVC9CYYw+lWbeb7pNgNcDm3FlrUuOFM+T8vhS+efHDJJjYexeawXmgyFQxP7snTg5B
 P4Ba5XUm08CDIUToED/qOYuELzDFlBjbbieliCdXrXrztNOFD5zBvnP76kmfoA5za1Zmv2Rp
 iO2W1NCyUq5jnrCcF3YZndmYbLpfJB+sXNkYnB8YQf2gyAuMdS18aMSV5orZr17puZt+uF5E
 qsecMKaD/URFjmeo2YBbYPwpZBJfQiwgV7cJDKsZTUyJsYyRwHA9tL+UBHo8S0CUni+ucck+
 uXy3QLHW5sTAQ9lCZ+OOv6oylqwu1kbmf5zABSUcoUCJh20/dEzeSLrj/IxL8UdEjn5x2OXh
 1SMHBMVhejRuItpotPHsr+J8tWyGOxkE0sEQ2SCteSqNTPX93aIyJNbVLraZijUUW759fnwZ
 ehRyP2gYvQLkEwT7th5Grdvi6k/+8Hut/lRyQE9RCfHaFGiC7VBJHia3JYQ6v0Rl+EB4QbmC
 FiS/tR6OKmSPJK3GVEcEwMpc+Cf2KxGgTLV9/k0fB336SIfEGBriqmO081gUBBgEYY=
IronPort-HdrOrdr: A9a23:70og06kttIZ1SWNHzmotKXlgjgDpDfIf3DAbv31ZSRFFG/Fwwf
 re5cjztCWE7Qr4Ohkb8+xoXZPsfZqyz/JICOUqUotKPzOW2ldATrsD0WK4+UyHJ8SWzIc0vp
 uIFZIRNDSaNykYsS+V2miF+3lL+qj+zEgF792uq0uE7GtRGsZd0zs=
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="64553121"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?=
	<marmarek@invisiblethingslab.com>, Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v2 07/70] x86: Build check for embedded endbr64 instructions
Date: Mon, 14 Feb 2022 12:50:24 +0000
Message-ID: <20220214125127.17985-8-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

From: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>

Embedded endbr64 instructions mark legal indirect branches as far as the CPU
is concerned, which aren't legal as far as the logic is concerned.

When CET-IBT is active, check for embedded byte sequences.  Example failures
look like:

  Fail: Found 2 embedded endbr64 instructions
  0xffff82d040325677: test_endbr64 at /local/xen.git/xen/arch/x86/x86_64/entry.S:28
  0xffff82d040352da6: init_done at /local/xen.git/xen/arch/x86/setup.c:675

Signed-off-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
v2:
 * New
---
 xen/arch/x86/Makefile    |  3 ++
 xen/tools/check-endbr.sh | 76 ++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 79 insertions(+)
 create mode 100755 xen/tools/check-endbr.sh

diff --git a/xen/arch/x86/Makefile b/xen/arch/x86/Makefile
index 9fc884813cb5..f15a984aacc2 100644
--- a/xen/arch/x86/Makefile
+++ b/xen/arch/x86/Makefile
@@ -155,6 +155,9 @@ $(TARGET)-syms: prelink.o xen.lds
 	$(MAKE) -f $(BASEDIR)/Rules.mk $(@D)/.$(@F).1.o
 	$(LD) $(XEN_LDFLAGS) -T xen.lds -N prelink.o $(build_id_linker) \
 	    $(@D)/.$(@F).1.o -o $@
+ifeq ($(CONFIG_XEN_IBT),y)
+	$(SHELL) $(BASEDIR)/tools/check-endbr.sh $@
+endif
 	$(NM) -pa --format=sysv $(@D)/$(@F) \
 		| $(BASEDIR)/tools/symbols --all-symbols --xensyms --sysv --sort \
 		>$(@D)/$(@F).map
diff --git a/xen/tools/check-endbr.sh b/xen/tools/check-endbr.sh
new file mode 100755
index 000000000000..3d96e02bdf93
--- /dev/null
+++ b/xen/tools/check-endbr.sh
@@ -0,0 +1,76 @@
+#!/bin/sh
+
+#
+# Usage ./$0 xen-syms
+#
+
+set -e
+
+OBJCOPY="${OBJCOPY:-objcopy} -j .text $1"
+OBJDUMP="${OBJDUMP:-objdump} -j .text $1"
+
+D=$(mktemp -d)
+trap "rm -rf $D" EXIT
+
+TEXT_BIN=$D/xen-syms.text
+VALID=$D/valid-addrs
+ALL=$D/all-addrs
+BAD=$D/bad-addrs
+
+#
+# First, look for all the valid endbr64 instructions.
+# A worst-case disassembly, viewed through cat -A, may look like:
+#
+# ffff82d040337bd4 <endbr64>:$
+# ffff82d040337bd4:^If3 0f 1e fa          ^Iendbr64 $
+# ffff82d040337bd8:^Ieb fe                ^Ijmp    ffff82d040337bd8 <endbr64+0x4>$
+# ffff82d040337bda:^Ib8 f3 0f 1e fa       ^Imov    $0xfa1e0ff3,%eax$
+#
+# Want to grab the address of endbr64 instructions only, ignoring function
+# names/jump labels/etc, so look for 'endbr64' preceeded by a tab and with any
+# number of trailing spaces before the end of the line.
+#
+${OBJDUMP} -d | grep '	endbr64 *$' | cut -f 1 -d ':' > $VALID &
+
+#
+# Second, look for any endbr64 byte sequence
+# This has a couple of complications:
+#
+# 1) Grep binary search isn't VMA aware.  Copy .text out as binary, causing
+#    the grep offset to be from the start of .text.
+#
+# 2) AWK can't add 64bit integers, because internally all numbers are doubles.
+#    When the upper bits are set, the exponents worth of precision is lost in
+#    the lower bits, rounding integers to the nearest 4k.
+#
+#    Instead, use the fact that Xen's .text is within a 1G aligned region, and
+#    split the VMA in half so AWK's numeric addition is only working on 32 bit
+#    numbers, which don't lose precision.
+#
+eval $(${OBJDUMP} -h | awk '$2 == ".text" {printf "vma_hi=%s\nvma_lo=%s\n", substr($4, 1, 8), substr($4, 9, 16)}')
+
+${OBJCOPY} -O binary $TEXT_BIN
+grep -aob "$(printf '\363\17\36\372')" $TEXT_BIN |
+    awk -F':' '{printf "%s%x\n", "'$vma_hi'", strtonum(0x'$vma_lo') + $1}' > $ALL
+
+# Wait for $VALID to become complete
+wait
+
+# Sanity check $VALID and $ALL, in case the string parsing bitrots
+val_sz=$(stat -c '%s' $VALID)
+all_sz=$(stat -c '%s' $ALL)
+[ "$val_sz" -eq 0 ]         && { echo "Error: Empty valid-addrs" >&2; exit 1; }
+[ "$all_sz" -eq 0 ]         && { echo "Error: Empty all-addrs" >&2; exit 1; }
+[ "$all_sz" -lt "$val_sz" ] && { echo "Error: More valid-addrs than all-addrs" >&2; exit 1; }
+
+# $BAD = $ALL - $VALID
+join -v 2 $VALID $ALL > $BAD
+nr_bad=$(wc -l < $BAD)
+
+# Success
+[ "$nr_bad" -eq 0 ] && exit 0
+
+# Failure
+echo "Fail: Found ${nr_bad} embedded endbr64 instructions" >&2
+addr2line -afip -e $1 < $BAD >&2
+exit 1
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 12:52:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 12:52:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271517.466049 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJapu-00075k-P5; Mon, 14 Feb 2022 12:52:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271517.466049; Mon, 14 Feb 2022 12:52:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJapu-00075U-LS; Mon, 14 Feb 2022 12:52:10 +0000
Received: by outflank-mailman (input) for mailman id 271517;
 Mon, 14 Feb 2022 12:52:09 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJaps-0003jk-Uz
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 12:52:09 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e979f1c8-8d94-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 13:52:05 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e979f1c8-8d94-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644843125;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=rK4VCi93KFKBnJQ5QLYsQgt3WnHUX2SPT8tUAOdYGog=;
  b=IrbeiJticmChzmCxMqogUUahafKWaZ/inwfIFLjVAX3+Jm4zXmmR/eqQ
   OdRyV1tXIDI6zX5DLlC1PLiqTw8AYe32GkveCpjecVderVruQh82z4pZW
   Q+cNWum9OX40NPy1LTrNFAgvTUMK9f8jL2Ltdo+cOy3fJZapH2vMMc70P
   k=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: dFFB1oS3HxDtLGaDaGUQO4z3R+i4Yy465nNZjrLABHNH9HeVtBATEP6kas6Q1YbNVzd09T5v6w
 B2HHN7WhmgVfk5oC+tJotqaRghbejqZp3CbnpqoCBzdwKTBlxfT3MI3xpCiiRqfpNtkv/cEBXY
 HOupXji8cT9wTxhAbRs0QfLCwsKHK48l0e25d/8jGIG8rwFntH7XlXOAu4lN22XPeq6KAcTAit
 OrSSv468zj8rMrMbI+stEweAw+BZQ/mkxUtQi11LbvofuoN1kAcupPWqvUf8fQqtP6vkDTxUw5
 OLdPCP1w4inC0aW+taLb4peo
X-SBRS: 5.1
X-MesageID: 64553120
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:0I7lr6Dly1DjixVW/zbkw5YqxClBgxIJ4kV8jS/XYbTApDsqhjADy
 2MdDTjSPfyJYTemf4x0bYqw8RwDv5Tcx9YwQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMo/u1Si6FatANl1ElvU2zbue6WL6s1hxZH1c+En970E47wobVv6Yz6TSHK1LV0
 T/Ni5W31G+Ng1aY5UpNtspvADs21BjDkGtwUm4WPJinj3eH/5UhN7oNJLnZEpfNatI88thW5
 Qr05OrREmvxp3/BAz4++1rxWhVirrX6ZWBihpfKMkQLb9crSiEai84G2PQghUh/iQqurs91j
 9d0lreZYyB0eZL3wsEZekwNe81+FfUuFL7vJHG+tYqYzlHccmuqyPJrZK00FdRGoKAtWzgIr
 KFGbmBWBvyAr7veLLaTY+9gnMk8auLsO5sSoCpIxjDFF/c2B5vERs0m4PcGgGpt3ZkURZ4yY
 eIFOQhEQlfCPSZFM1wyGop9zOf5uyTgJmgwRFW9+vNsvjm7IBZK+KjgNp/Zd8KHQe1Rn12Ev
 STW8mLhGBYYOdeDjz2f/RqRavTnxH2hHthITfvhq6As0Ab7KnEv5AM+V2SckOa9zUyHePl2A
 WtJvRUV94023Rn+JjXiZCGQrHmBtx8aftNfFewm9Q2AopbpDxal6nssFWAYNoF/3CMibXlzj
 wLSwYu1bdB6mODNERqgGqGoQSRe0MT/BUsLfmc6QAQM+LEPS6lj30uUHr6P/ENY5+AZ+A0cI
 RjX9kDSZJ1J1KbnMplXGnid3VqRSmDhFFJd2+kudjvNAvlFTICkfZe0zlPQ8OxNKo2UJnHY4
 iRYxJjOsb1WVMrX/MBofAnqNOv3j8tpzRWG2QI/d3Xf32jFF4GfkXB4v2gleRYB3jcscj71e
 k7D0T69F7cIVEZGmZRfOtrrY+xzlPCIPY28Cpj8M4ofCrAsJVTv1Hw/OiatM5XFzRFEfVcXY
 szAL65BzB8yVMxa8dZBb7lBj+F7nH1irY4RLLiipymaPXOlTCb9Yd843JGmNYjVNYuI/1fY9
 chxLcyPx0kNWeHyeHCPo4USMUoLPT4wApWv855bceuKIwxHHmA9CqCOneN9KtI9x6kFxP3V+
 nydW1NDzAatj3PwNgjXOGtob6niXMgjoCtjbzAsJ1uhx1MqfZ2rsPUEb5IycLR+rL5jwPd4Q
 uMrYcKFBvgTGD3L9y5ENcv2rZB4dQTtjgWLZnL3bD86dp9mZgrI5t67IVe/qHhQVnK67JJsr
 aeh2wXXRYs4az5jVMuGOuiyy16RvGQGnL4gVUX/PdQOKl7n95JnKnKtg6Zvcd0MMxjK2hCTy
 x2SXUUDveDIroI4rIvJiKSDo9v7GudyBBMHTWzS7LLwPijG5Guzh4RHVb/QLzzaUWr1/oSkZ
 PlUkK6gYKFWwg4SvtouCatvwII/+8Dr9u1TwQlTFXnWa0imV+F7KX6c0MgT7qBAy9e1Y+dtt
 p5jLjWCBYi0BQ==
IronPort-HdrOrdr: A9a23:DVMhu6BSaOvK/XzlHemf55DYdb4zR+YMi2TDgXoBMCC9E/bo8v
 xH/pwgvyMc7Qx9ZJhOo7y90cW7Lk80lqQFg7X5X43DYOC8ghrPEGgK1+KLqAEIfReRygc379
 YCT0ERMrzN5fcRt7eD3OEVeexQpOVuUcqT9IDj80s=
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="64553120"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v2 09/70] xen: CFI hardening for custom_param()
Date: Mon, 14 Feb 2022 12:50:26 +0000
Message-ID: <20220214125127.17985-10-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

Control Flow Integrity schemes use toolchain and optionally hardware support
to help protect against call/jump/return oriented programming attacks.

Use cf_check to annotate function pointer targets for the toolchain.

The "watchdog_timeout" and "cpu_type" handlers were missing __init.

The "numa", "acpi", "irq_vector_map" and "flask" handlers can skip forward
declarations by altering the custom_param() position.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
 xen/arch/x86/acpi/cpu_idle.c             |  2 +-
 xen/arch/x86/acpi/power.c                |  2 +-
 xen/arch/x86/apic.c                      |  4 ++--
 xen/arch/x86/cpu/mcheck/mce.c            |  2 +-
 xen/arch/x86/cpu/microcode/core.c        |  2 +-
 xen/arch/x86/cpu/vpmu.c                  |  2 +-
 xen/arch/x86/cpuid.c                     |  8 ++++----
 xen/arch/x86/dom0_build.c                |  8 ++++----
 xen/arch/x86/genapic/probe.c             |  2 +-
 xen/arch/x86/hpet.c                      |  2 +-
 xen/arch/x86/hvm/viridian/viridian.c     |  2 +-
 xen/arch/x86/hvm/vmx/vmcs.c              |  8 ++++----
 xen/arch/x86/io_apic.c                   |  2 +-
 xen/arch/x86/irq.c                       |  6 ++----
 xen/arch/x86/mm.c                        |  2 +-
 xen/arch/x86/nmi.c                       |  4 ++--
 xen/arch/x86/numa.c                      |  6 ++----
 xen/arch/x86/oprofile/nmi_int.c          |  2 +-
 xen/arch/x86/psr.c                       |  2 +-
 xen/arch/x86/pv/domain.c                 |  8 ++++----
 xen/arch/x86/pv/shim.c                   |  2 +-
 xen/arch/x86/setup.c                     | 11 +++++------
 xen/arch/x86/shutdown.c                  |  2 +-
 xen/arch/x86/spec_ctrl.c                 |  6 +++---
 xen/arch/x86/time.c                      |  2 +-
 xen/arch/x86/tsx.c                       |  2 +-
 xen/arch/x86/x86_64/mmconfig-shared.c    |  2 +-
 xen/common/argo.c                        |  2 +-
 xen/common/core_parking.c                |  2 +-
 xen/common/debugtrace.c                  |  2 +-
 xen/common/domain.c                      |  2 +-
 xen/common/efi/boot.c                    |  2 +-
 xen/common/grant_table.c                 | 14 +++++++-------
 xen/common/kexec.c                       |  6 +++---
 xen/common/memory.c                      |  2 +-
 xen/common/page_alloc.c                  |  2 +-
 xen/common/sched/cpupool.c               |  2 +-
 xen/common/sched/credit2.c               |  2 +-
 xen/drivers/acpi/tables.c                |  2 +-
 xen/drivers/char/console.c               | 18 +++++++++---------
 xen/drivers/cpufreq/cpufreq.c            |  2 +-
 xen/drivers/passthrough/amd/iommu_acpi.c |  6 +++---
 xen/drivers/passthrough/iommu.c          |  4 ++--
 xen/drivers/passthrough/pci.c            |  4 ++--
 xen/drivers/passthrough/vtd/dmar.c       |  2 +-
 xen/drivers/passthrough/vtd/quirks.c     |  2 +-
 xen/drivers/video/vesa.c                 |  2 +-
 xen/xsm/flask/flask_op.c                 |  5 ++---
 xen/xsm/xsm_core.c                       |  2 +-
 49 files changed, 92 insertions(+), 98 deletions(-)

diff --git a/xen/arch/x86/acpi/cpu_idle.c b/xen/arch/x86/acpi/cpu_idle.c
index d788c8bffc84..5d73eb5917af 100644
--- a/xen/arch/x86/acpi/cpu_idle.c
+++ b/xen/arch/x86/acpi/cpu_idle.c
@@ -106,7 +106,7 @@ void (*__read_mostly pm_idle_save)(void);
 unsigned int max_cstate __read_mostly = UINT_MAX;
 unsigned int max_csubstate __read_mostly = UINT_MAX;
 
-static int __init parse_cstate(const char *s)
+static int __init cf_check parse_cstate(const char *s)
 {
     max_cstate = simple_strtoul(s, &s, 0);
     if ( *s == ',' )
diff --git a/xen/arch/x86/acpi/power.c b/xen/arch/x86/acpi/power.c
index 5eaa77f66a28..912d4c4d62f4 100644
--- a/xen/arch/x86/acpi/power.c
+++ b/xen/arch/x86/acpi/power.c
@@ -35,7 +35,7 @@
 
 uint32_t system_reset_counter = 1;
 
-static int __init parse_acpi_sleep(const char *s)
+static int __init cf_check parse_acpi_sleep(const char *s)
 {
     const char *ss;
     unsigned int flag = 0;
diff --git a/xen/arch/x86/apic.c b/xen/arch/x86/apic.c
index 583656158532..68e4d870c749 100644
--- a/xen/arch/x86/apic.c
+++ b/xen/arch/x86/apic.c
@@ -775,7 +775,7 @@ int lapic_resume(void)
  * Original code written by Keir Fraser.
  */
 
-static int __init lapic_disable(const char *str)
+static int __init cf_check lapic_disable(const char *str)
 {
     enable_local_apic = -1;
     setup_clear_cpu_cap(X86_FEATURE_APIC);
@@ -784,7 +784,7 @@ static int __init lapic_disable(const char *str)
 custom_param("nolapic", lapic_disable);
 boolean_param("lapic", enable_local_apic);
 
-static int __init apic_set_verbosity(const char *str)
+static int __init cf_check apic_set_verbosity(const char *str)
 {
     if (strcmp("debug", str) == 0)
         apic_verbosity = APIC_DEBUG;
diff --git a/xen/arch/x86/cpu/mcheck/mce.c b/xen/arch/x86/cpu/mcheck/mce.c
index eae08caa07cd..ea86d84481b2 100644
--- a/xen/arch/x86/cpu/mcheck/mce.c
+++ b/xen/arch/x86/cpu/mcheck/mce.c
@@ -63,7 +63,7 @@ struct mca_banks *mca_allbanks;
 #endif
 
 int mce_verbosity;
-static int __init mce_set_verbosity(const char *str)
+static int __init cf_check mce_set_verbosity(const char *str)
 {
     if ( strcmp("verbose", str) == 0 )
         mce_verbosity = MCE_VERBOSE;
diff --git a/xen/arch/x86/cpu/microcode/core.c b/xen/arch/x86/cpu/microcode/core.c
index ac3ceb567c41..95d35ca0f3f7 100644
--- a/xen/arch/x86/cpu/microcode/core.c
+++ b/xen/arch/x86/cpu/microcode/core.c
@@ -111,7 +111,7 @@ void __init microcode_set_module(unsigned int idx)
  * optional. If the EFI has forced which of the multiboot payloads is to be
  * used, only nmi=<bool> is parsed.
  */
-static int __init parse_ucode(const char *s)
+static int __init cf_check parse_ucode(const char *s)
 {
     const char *ss;
     int val, rc = 0;
diff --git a/xen/arch/x86/cpu/vpmu.c b/xen/arch/x86/cpu/vpmu.c
index 598291f4ece9..b10d6e2eb458 100644
--- a/xen/arch/x86/cpu/vpmu.c
+++ b/xen/arch/x86/cpu/vpmu.c
@@ -56,7 +56,7 @@ static unsigned vpmu_count;
 
 static DEFINE_PER_CPU(struct vcpu *, last_vcpu);
 
-static int __init parse_vpmu_params(const char *s)
+static int __init cf_check parse_vpmu_params(const char *s)
 {
     const char *ss;
     int rc = 0, val;
diff --git a/xen/arch/x86/cpuid.c b/xen/arch/x86/cpuid.c
index e24dd283e761..7632b8344f87 100644
--- a/xen/arch/x86/cpuid.c
+++ b/xen/arch/x86/cpuid.c
@@ -101,7 +101,7 @@ static int __init always_inline parse_cpuid(
     return rc;
 }
 
-static void __init _parse_xen_cpuid(unsigned int feat, bool val)
+static void __init cf_check _parse_xen_cpuid(unsigned int feat, bool val)
 {
     if ( !val )
         setup_clear_cpu_cap(feat);
@@ -110,7 +110,7 @@ static void __init _parse_xen_cpuid(unsigned int feat, bool val)
         setup_force_cpu_cap(X86_FEATURE_RDRAND);
 }
 
-static int __init parse_xen_cpuid(const char *s)
+static int __init cf_check parse_xen_cpuid(const char *s)
 {
     return parse_cpuid(s, _parse_xen_cpuid);
 }
@@ -120,13 +120,13 @@ static bool __initdata dom0_cpuid_cmdline;
 static uint32_t __initdata dom0_enable_feat[FSCAPINTS];
 static uint32_t __initdata dom0_disable_feat[FSCAPINTS];
 
-static void __init _parse_dom0_cpuid(unsigned int feat, bool val)
+static void __init cf_check _parse_dom0_cpuid(unsigned int feat, bool val)
 {
     __set_bit  (feat, val ? dom0_enable_feat  : dom0_disable_feat);
     __clear_bit(feat, val ? dom0_disable_feat : dom0_enable_feat );
 }
 
-static int __init parse_dom0_cpuid(const char *s)
+static int __init cf_check parse_dom0_cpuid(const char *s)
 {
     dom0_cpuid_cmdline = true;
 
diff --git a/xen/arch/x86/dom0_build.c b/xen/arch/x86/dom0_build.c
index a7fec05956c1..4d1c5c60e407 100644
--- a/xen/arch/x86/dom0_build.c
+++ b/xen/arch/x86/dom0_build.c
@@ -115,7 +115,7 @@ static int __init parse_amt(const char *s, const char **ps, struct memsize *sz)
     return 0;
 }
 
-static int __init parse_dom0_mem(const char *s)
+static int __init cf_check parse_dom0_mem(const char *s)
 {
     int ret;
 
@@ -144,7 +144,7 @@ custom_param("dom0_mem", parse_dom0_mem);
 static unsigned int __initdata opt_dom0_max_vcpus_min = 1;
 static unsigned int __initdata opt_dom0_max_vcpus_max = UINT_MAX;
 
-static int __init parse_dom0_max_vcpus(const char *s)
+static int __init cf_check parse_dom0_max_vcpus(const char *s)
 {
     if ( *s == '-' )                   /* -M */
         opt_dom0_max_vcpus_max = simple_strtoul(s + 1, &s, 0);
@@ -168,7 +168,7 @@ static __initdata unsigned int dom0_pxms[MAX_NUMNODES] =
     { [0 ... MAX_NUMNODES - 1] = ~0 };
 bool __initdata dom0_affinity_relaxed;
 
-static int __init parse_dom0_nodes(const char *s)
+static int __init cf_check parse_dom0_nodes(const char *s)
 {
     const char *ss;
     int rc = 0;
@@ -266,7 +266,7 @@ bool __initdata opt_dom0_pvh = !IS_ENABLED(CONFIG_PV);
 bool __initdata opt_dom0_verbose = IS_ENABLED(CONFIG_VERBOSE_DEBUG);
 bool __initdata opt_dom0_msr_relaxed;
 
-static int __init parse_dom0_param(const char *s)
+static int __init cf_check parse_dom0_param(const char *s)
 {
     const char *ss;
     int rc = 0;
diff --git a/xen/arch/x86/genapic/probe.c b/xen/arch/x86/genapic/probe.c
index 66bc5ce072dc..ad57912f506b 100644
--- a/xen/arch/x86/genapic/probe.c
+++ b/xen/arch/x86/genapic/probe.c
@@ -43,7 +43,7 @@ void __init generic_bigsmp_probe(void)
 		}
 }
 
-static int __init genapic_apic_force(const char *str)
+static int __init cf_check genapic_apic_force(const char *str)
 {
 	int i, rc = -EINVAL;
 
diff --git a/xen/arch/x86/hpet.c b/xen/arch/x86/hpet.c
index afe104dc93c2..7b009a930498 100644
--- a/xen/arch/x86/hpet.c
+++ b/xen/arch/x86/hpet.c
@@ -65,7 +65,7 @@ u8 __initdata hpet_flags;
 static bool __initdata force_hpet_broadcast;
 boolean_param("hpetbroadcast", force_hpet_broadcast);
 
-static int __init parse_hpet_param(const char *s)
+static int __init cf_check parse_hpet_param(const char *s)
 {
     const char *ss;
     int val, rc = 0;
diff --git a/xen/arch/x86/hvm/viridian/viridian.c b/xen/arch/x86/hvm/viridian/viridian.c
index 8986b8e03c2e..7ebcaa1c899f 100644
--- a/xen/arch/x86/hvm/viridian/viridian.c
+++ b/xen/arch/x86/hvm/viridian/viridian.c
@@ -1186,7 +1186,7 @@ static int viridian_load_vcpu_ctxt(struct domain *d,
 HVM_REGISTER_SAVE_RESTORE(VIRIDIAN_VCPU, viridian_save_vcpu_ctxt,
                           viridian_load_vcpu_ctxt, 1, HVMSR_PER_VCPU);
 
-static int __init parse_viridian_version(const char *arg)
+static int __init cf_check parse_viridian_version(const char *arg)
 {
     const char *t;
     unsigned int n[3];
diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c
index 7ab15e07a0b2..f72a7db0453d 100644
--- a/xen/arch/x86/hvm/vmx/vmcs.c
+++ b/xen/arch/x86/hvm/vmx/vmcs.c
@@ -71,7 +71,7 @@ static bool __read_mostly opt_ept_pml = true;
 static s8 __read_mostly opt_ept_ad = -1;
 int8_t __read_mostly opt_ept_exec_sp = -1;
 
-static int __init parse_ept_param(const char *s)
+static int __init cf_check parse_ept_param(const char *s)
 {
     const char *ss;
     int val, rc = 0;
@@ -107,16 +107,16 @@ static void update_ept_param(void)
                  opt_ept_exec_sp);
 }
 
-static void __init init_ept_param(struct param_hypfs *par)
+static void __init cf_check init_ept_param(struct param_hypfs *par)
 {
     update_ept_param();
     custom_runtime_set_var(par, opt_ept_setting);
 }
 
-static int parse_ept_param_runtime(const char *s);
+static int cf_check parse_ept_param_runtime(const char *s);
 custom_runtime_only_param("ept", parse_ept_param_runtime, init_ept_param);
 
-static int parse_ept_param_runtime(const char *s)
+static int cf_check parse_ept_param_runtime(const char *s)
 {
     struct domain *d;
     int val;
diff --git a/xen/arch/x86/io_apic.c b/xen/arch/x86/io_apic.c
index 1c49a0fe1478..4135a9c06052 100644
--- a/xen/arch/x86/io_apic.c
+++ b/xen/arch/x86/io_apic.c
@@ -1601,7 +1601,7 @@ static unsigned int startup_level_ioapic_irq(struct irq_desc *desc)
     return 0; /* don't check for pending */
 }
 
-static int __init setup_ioapic_ack(const char *s)
+static int __init cf_check setup_ioapic_ack(const char *s)
 {
     if ( !strcmp(s, "old") )
     {
diff --git a/xen/arch/x86/irq.c b/xen/arch/x86/irq.c
index 67cbf6b979dc..84b174d0f51f 100644
--- a/xen/arch/x86/irq.c
+++ b/xen/arch/x86/irq.c
@@ -28,8 +28,6 @@
 #include <irq_vectors.h>
 #include <public/physdev.h>
 
-static int parse_irq_vector_map_param(const char *s);
-
 /* opt_noirqbalance: If true, software IRQ balancing/affinity is disabled. */
 bool __read_mostly opt_noirqbalance;
 boolean_param("noirqbalance", opt_noirqbalance);
@@ -40,7 +38,6 @@ integer_param("nr_irqs", nr_irqs);
 
 /* This default may be changed by the AMD IOMMU code */
 int __read_mostly opt_irq_vector_map = OPT_IRQ_VECTOR_MAP_DEFAULT;
-custom_param("irq_vector_map", parse_irq_vector_map_param);
 
 /* Max number of guests IRQ could be shared with */
 static unsigned char __read_mostly irq_max_guests;
@@ -66,7 +63,7 @@ static struct timer irq_ratelimit_timer;
 static unsigned int __read_mostly irq_ratelimit_threshold = 10000;
 integer_param("irq_ratelimit", irq_ratelimit_threshold);
 
-static int __init parse_irq_vector_map_param(const char *s)
+static int __init cf_check parse_irq_vector_map_param(const char *s)
 {
     const char *ss;
     int rc = 0;
@@ -90,6 +87,7 @@ static int __init parse_irq_vector_map_param(const char *s)
 
     return rc;
 }
+custom_param("irq_vector_map", parse_irq_vector_map_param);
 
 /* Must be called when irq disabled */
 void lock_vector_lock(void)
diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c
index 6484c3b97bbc..3b8bc3dda977 100644
--- a/xen/arch/x86/mm.c
+++ b/xen/arch/x86/mm.c
@@ -189,7 +189,7 @@ static uint32_t base_disallow_mask;
 
 static s8 __read_mostly opt_mmio_relax;
 
-static int __init parse_mmio_relax(const char *s)
+static int __init cf_check parse_mmio_relax(const char *s)
 {
     if ( !*s )
         opt_mmio_relax = 1;
diff --git a/xen/arch/x86/nmi.c b/xen/arch/x86/nmi.c
index ab94a96c4d03..1a225d499295 100644
--- a/xen/arch/x86/nmi.c
+++ b/xen/arch/x86/nmi.c
@@ -48,7 +48,7 @@ bool __initdata opt_watchdog;
 /* watchdog_force: If true, process unknown NMIs when running the watchdog. */
 bool watchdog_force;
 
-static int __init parse_watchdog(const char *s)
+static int __init cf_check parse_watchdog(const char *s)
 {
     if ( !*s )
     {
@@ -78,7 +78,7 @@ custom_param("watchdog", parse_watchdog);
 /* opt_watchdog_timeout: Number of seconds to wait before panic. */
 static unsigned int opt_watchdog_timeout = 5;
 
-static int parse_watchdog_timeout(const char *s)
+static int __init cf_check parse_watchdog_timeout(const char *s)
 {
     const char *q;
 
diff --git a/xen/arch/x86/numa.c b/xen/arch/x86/numa.c
index ce79ee44cefe..6be5a0c93322 100644
--- a/xen/arch/x86/numa.c
+++ b/xen/arch/x86/numa.c
@@ -19,9 +19,6 @@
 #include <xen/sched.h>
 #include <xen/softirq.h>
 
-static int numa_setup(const char *s);
-custom_param("numa", numa_setup);
-
 #ifndef Dprintk
 #define Dprintk(x...)
 #endif
@@ -294,7 +291,7 @@ void numa_set_node(int cpu, nodeid_t node)
 }
 
 /* [numa=off] */
-static __init int numa_setup(const char *opt)
+static int __init cf_check numa_setup(const char *opt)
 {
     if ( !strncmp(opt,"off",3) )
         numa_off = true;
@@ -321,6 +318,7 @@ static __init int numa_setup(const char *opt)
 
     return 0;
 } 
+custom_param("numa", numa_setup);
 
 /*
  * Setup early cpu_to_node.
diff --git a/xen/arch/x86/oprofile/nmi_int.c b/xen/arch/x86/oprofile/nmi_int.c
index a13bd82915ac..7842d95b95ea 100644
--- a/xen/arch/x86/oprofile/nmi_int.c
+++ b/xen/arch/x86/oprofile/nmi_int.c
@@ -340,7 +340,7 @@ static int __init p4_init(char ** cpu_type)
 
 static int force_arch_perfmon;
 
-static int force_cpu_type(const char *str)
+static int __init cf_check force_cpu_type(const char *str)
 {
 	if (!strcmp(str, "arch_perfmon")) {
 		force_arch_perfmon = 1;
diff --git a/xen/arch/x86/psr.c b/xen/arch/x86/psr.c
index d805b85dc60b..56916344cb1d 100644
--- a/xen/arch/x86/psr.c
+++ b/xen/arch/x86/psr.c
@@ -573,7 +573,7 @@ static bool __init parse_psr_bool(const char *s, const char *delim,
     return false;
 }
 
-static int __init parse_psr_param(const char *s)
+static int __init cf_check parse_psr_param(const char *s)
 {
     const char *ss, *val_delim;
     const char *q;
diff --git a/xen/arch/x86/pv/domain.c b/xen/arch/x86/pv/domain.c
index 6ad533183bcd..125c4561a7ea 100644
--- a/xen/arch/x86/pv/domain.c
+++ b/xen/arch/x86/pv/domain.c
@@ -20,7 +20,7 @@
 int8_t __read_mostly opt_pv32 = -1;
 #endif
 
-static __init int parse_pv(const char *s)
+static int __init cf_check parse_pv(const char *s)
 {
     const char *ss;
     int val, rc = 0;
@@ -63,16 +63,16 @@ static const char opt_pcid_2_string[][7] = {
     [PCID_NOXPTI] = "noxpti",
 };
 
-static void __init opt_pcid_init(struct param_hypfs *par)
+static void __init cf_check opt_pcid_init(struct param_hypfs *par)
 {
     custom_runtime_set_var(par, opt_pcid_2_string[opt_pcid]);
 }
 #endif
 
-static int parse_pcid(const char *s);
+static int cf_check parse_pcid(const char *s);
 custom_runtime_param("pcid", parse_pcid, opt_pcid_init);
 
-static int parse_pcid(const char *s)
+static int cf_check parse_pcid(const char *s)
 {
     int rc = 0;
 
diff --git a/xen/arch/x86/pv/shim.c b/xen/arch/x86/pv/shim.c
index 4c710ad8913f..ae4d8913faa1 100644
--- a/xen/arch/x86/pv/shim.c
+++ b/xen/arch/x86/pv/shim.c
@@ -73,7 +73,7 @@ static uint64_t __initdata shim_nrpages;
 static uint64_t __initdata shim_min_nrpages;
 static uint64_t __initdata shim_max_nrpages;
 
-static int __init parse_shim_mem(const char *s)
+static int __init cf_check parse_shim_mem(const char *s)
 {
     do {
         if ( !strncmp(s, "min:", 4) )
diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c
index 115f8f651734..eceff0a4e2b4 100644
--- a/xen/arch/x86/setup.c
+++ b/xen/arch/x86/setup.c
@@ -81,8 +81,6 @@ unsigned long __read_mostly cr4_pv32_mask;
 /* "acpi=ht":     Limit ACPI just to boot-time to enable HT.        */
 /* "acpi=noirq":  Disables ACPI interrupt routing.                  */
 /* "acpi=verbose": Enables more verbose ACPI boot time logging.     */
-static int parse_acpi_param(const char *s);
-custom_param("acpi", parse_acpi_param);
 
 /* **** Linux config option: propagated to domain0. */
 /* noapic: Disable IOAPIC setup. */
@@ -104,7 +102,7 @@ static bool __initdata opt_xen_shstk = true;
 #define opt_xen_shstk false
 #endif
 
-static int __init parse_cet(const char *s)
+static int __init cf_check parse_cet(const char *s)
 {
     const char *ss;
     int val, rc = 0;
@@ -159,7 +157,7 @@ static s8 __initdata opt_smep = -1;
  */
 static struct domain *__initdata dom0;
 
-static int __init parse_smep_param(const char *s)
+static int __init cf_check parse_smep_param(const char *s)
 {
     if ( !*s )
     {
@@ -190,7 +188,7 @@ custom_param("smep", parse_smep_param);
 #define SMAP_HVM_ONLY (-2)
 static s8 __initdata opt_smap = -1;
 
-static int __init parse_smap_param(const char *s)
+static int __init cf_check parse_smap_param(const char *s)
 {
     if ( !*s )
     {
@@ -221,7 +219,7 @@ bool __read_mostly acpi_disabled;
 bool __initdata acpi_force;
 static char __initdata acpi_param[10] = "";
 
-static int __init parse_acpi_param(const char *s)
+static int __init cf_check parse_acpi_param(const char *s)
 {
     /* Interpret the parameter for use within Xen. */
     if ( !parse_bool(s, NULL) )
@@ -257,6 +255,7 @@ static int __init parse_acpi_param(const char *s)
 
     return 0;
 }
+custom_param("acpi", parse_acpi_param);
 
 static const module_t *__initdata initial_images;
 static unsigned int __initdata nr_initial_images;
diff --git a/xen/arch/x86/shutdown.c b/xen/arch/x86/shutdown.c
index acef03314372..a01354d93319 100644
--- a/xen/arch/x86/shutdown.c
+++ b/xen/arch/x86/shutdown.c
@@ -56,7 +56,7 @@ static int reboot_mode;
  */
 static enum reboot_type reboot_type = BOOT_INVALID;
 
-static int __init set_reboot_type(const char *str)
+static int __init cf_check set_reboot_type(const char *str)
 {
     int rc = 0;
 
diff --git a/xen/arch/x86/spec_ctrl.c b/xen/arch/x86/spec_ctrl.c
index cbeeb199037e..d45841043c58 100644
--- a/xen/arch/x86/spec_ctrl.c
+++ b/xen/arch/x86/spec_ctrl.c
@@ -68,7 +68,7 @@ static bool __initdata cpu_has_bug_mds; /* Any other M{LP,SB,FB}DS combination.
 
 static int8_t __initdata opt_srb_lock = -1;
 
-static int __init parse_spec_ctrl(const char *s)
+static int __init cf_check parse_spec_ctrl(const char *s)
 {
     const char *ss;
     int val, rc = 0;
@@ -218,7 +218,7 @@ static __init void xpti_init_default(uint64_t caps)
     }
 }
 
-static __init int parse_xpti(const char *s)
+static int __init cf_check parse_xpti(const char *s)
 {
     const char *ss;
     int val, rc = 0;
@@ -264,7 +264,7 @@ custom_param("xpti", parse_xpti);
 int8_t __read_mostly opt_pv_l1tf_hwdom = -1;
 int8_t __read_mostly opt_pv_l1tf_domu = -1;
 
-static __init int parse_pv_l1tf(const char *s)
+static int __init cf_check parse_pv_l1tf(const char *s)
 {
     const char *ss;
     int val, rc = 0;
diff --git a/xen/arch/x86/time.c b/xen/arch/x86/time.c
index 17f64a6ccdd1..2da9c7f5c8dd 100644
--- a/xen/arch/x86/time.c
+++ b/xen/arch/x86/time.c
@@ -2356,7 +2356,7 @@ int hwdom_pit_access(struct ioreq *ioreq)
  * tsc=skewed: Assume TSCs are individually reliable, but skewed across CPUs.
  * tsc=stable:socket: Assume TSCs are reliable across sockets.
  */
-static int __init tsc_parse(const char *s)
+static int __init cf_check tsc_parse(const char *s)
 {
     if ( !strcmp(s, "unstable") )
     {
diff --git a/xen/arch/x86/tsx.c b/xen/arch/x86/tsx.c
index be89741a2f6d..b156844cdec1 100644
--- a/xen/arch/x86/tsx.c
+++ b/xen/arch/x86/tsx.c
@@ -22,7 +22,7 @@ int8_t __read_mostly opt_tsx = -1;
 int8_t __read_mostly cpu_has_tsx_ctrl = -1;
 bool __read_mostly rtm_disabled;
 
-static int __init parse_tsx(const char *s)
+static int __init cf_check parse_tsx(const char *s)
 {
     int rc = 0, val = parse_bool(s, NULL);
 
diff --git a/xen/arch/x86/x86_64/mmconfig-shared.c b/xen/arch/x86/x86_64/mmconfig-shared.c
index 7c3ed64b4c6c..2fa7f3f0bc4b 100644
--- a/xen/arch/x86/x86_64/mmconfig-shared.c
+++ b/xen/arch/x86/x86_64/mmconfig-shared.c
@@ -29,7 +29,7 @@
 
 unsigned int pci_probe = PCI_PROBE_CONF1 | PCI_PROBE_MMCONF;
 
-static int __init parse_mmcfg(const char *s)
+static int __init cf_check parse_mmcfg(const char *s)
 {
     const char *ss;
     int rc = 0;
diff --git a/xen/common/argo.c b/xen/common/argo.c
index 1448faf65731..297f6d11f04d 100644
--- a/xen/common/argo.c
+++ b/xen/common/argo.c
@@ -78,7 +78,7 @@ DEFINE_COMPAT_HANDLE(compat_argo_iov_t);
 static bool __read_mostly opt_argo;
 static bool __read_mostly opt_argo_mac_permissive;
 
-static int __init parse_argo(const char *s)
+static int __init cf_check parse_argo(const char *s)
 {
     const char *ss;
     int val, rc = 0;
diff --git a/xen/common/core_parking.c b/xen/common/core_parking.c
index 411106c675c9..aa432ed2f57b 100644
--- a/xen/common/core_parking.c
+++ b/xen/common/core_parking.c
@@ -40,7 +40,7 @@ static enum core_parking_controller {
     PERFORMANCE_FIRST
 } core_parking_controller __initdata = POWER_FIRST;
 
-static int __init setup_core_parking_option(const char *str)
+static int __init cf_check setup_core_parking_option(const char *str)
 {
     if ( !strcmp(str, "power") )
         core_parking_controller = POWER_FIRST;
diff --git a/xen/common/debugtrace.c b/xen/common/debugtrace.c
index f3794b945376..29b11239f5a5 100644
--- a/xen/common/debugtrace.c
+++ b/xen/common/debugtrace.c
@@ -38,7 +38,7 @@ static bool debugtrace_buf_empty = true;
 static bool debugtrace_used;
 static DEFINE_SPINLOCK(debugtrace_lock);
 
-static int __init debugtrace_parse_param(const char *s)
+static int __init cf_check debugtrace_parse_param(const char *s)
 {
     unsigned long bytes;
 
diff --git a/xen/common/domain.c b/xen/common/domain.c
index e58c0bd4ddc4..5df0d167537b 100644
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -354,7 +354,7 @@ static int late_hwdom_init(struct domain *d)
 static unsigned int __read_mostly extra_hwdom_irqs;
 static unsigned int __read_mostly extra_domU_irqs = 32;
 
-static int __init parse_extra_guest_irqs(const char *s)
+static int __init cf_check parse_extra_guest_irqs(const char *s)
 {
     if ( isdigit(*s) )
         extra_domU_irqs = simple_strtoul(s, &s, 0);
diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c
index 12fd0844bd55..f31f68fd4cd1 100644
--- a/xen/common/efi/boot.c
+++ b/xen/common/efi/boot.c
@@ -1417,7 +1417,7 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable)
 
 static bool __initdata efi_map_uc;
 
-static int __init parse_efi_param(const char *s)
+static int __init cf_check parse_efi_param(const char *s)
 {
     const char *ss;
     int rc = 0, val;
diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c
index 153332b7bfbe..b663845d9c6c 100644
--- a/xen/common/grant_table.c
+++ b/xen/common/grant_table.c
@@ -117,12 +117,12 @@ static void update_gnttab_par(unsigned int val, struct param_hypfs *par,
     custom_runtime_set_var_sz(par, parval, GRANT_CUSTOM_VAL_SZ);
 }
 
-static void __init gnttab_max_frames_init(struct param_hypfs *par)
+static void __init cf_check gnttab_max_frames_init(struct param_hypfs *par)
 {
     update_gnttab_par(opt_max_grant_frames, par, opt_max_grant_frames_val);
 }
 
-static void __init max_maptrack_frames_init(struct param_hypfs *par)
+static void __init cf_check max_maptrack_frames_init(struct param_hypfs *par)
 {
     update_gnttab_par(opt_max_maptrack_frames, par,
                       opt_max_maptrack_frames_val);
@@ -156,23 +156,23 @@ static int parse_gnttab_limit(const char *arg, unsigned int *valp,
     return 0;
 }
 
-static int parse_gnttab_max_frames(const char *arg);
+static int cf_check parse_gnttab_max_frames(const char *arg);
 custom_runtime_param("gnttab_max_frames", parse_gnttab_max_frames,
                      gnttab_max_frames_init);
 
-static int parse_gnttab_max_frames(const char *arg)
+static int cf_check parse_gnttab_max_frames(const char *arg)
 {
     return parse_gnttab_limit(arg, &opt_max_grant_frames,
                               param_2_parfs(parse_gnttab_max_frames),
                               opt_max_grant_frames_val);
 }
 
-static int parse_gnttab_max_maptrack_frames(const char *arg);
+static int cf_check parse_gnttab_max_maptrack_frames(const char *arg);
 custom_runtime_param("gnttab_max_maptrack_frames",
                      parse_gnttab_max_maptrack_frames,
                      max_maptrack_frames_init);
 
-static int parse_gnttab_max_maptrack_frames(const char *arg)
+static int cf_check parse_gnttab_max_maptrack_frames(const char *arg)
 {
     return parse_gnttab_limit(arg, &opt_max_maptrack_frames,
                               param_2_parfs(parse_gnttab_max_maptrack_frames),
@@ -191,7 +191,7 @@ static bool __ro_after_init opt_grant_transfer = true;
 #define opt_grant_transfer false
 #endif
 
-static int __init parse_gnttab(const char *s)
+static int __init cf_check parse_gnttab(const char *s)
 {
     const char *ss, *e;
     int val, rc = 0;
diff --git a/xen/common/kexec.c b/xen/common/kexec.c
index 8471590aeea2..6286c0bbf08b 100644
--- a/xen/common/kexec.c
+++ b/xen/common/kexec.c
@@ -104,7 +104,7 @@ static void *crash_heap_current = NULL, *crash_heap_end = NULL;
  * < and below are synonyomous, the latter being useful for grub2 systems
  * which would otherwise require escaping of the < option
  */
-static int __init parse_crashkernel(const char *str)
+static int __init cf_check parse_crashkernel(const char *str)
 {
     const char *cur;
     int rc = 0;
@@ -201,7 +201,7 @@ custom_param("crashkernel", parse_crashkernel);
  * - all will allocate additional structures such as domain and vcpu structs
  *       low so the crash kernel can perform an extended analysis of state.
  */
-static int __init parse_low_crashinfo(const char *str)
+static int __init cf_check parse_low_crashinfo(const char *str)
 {
 
     if ( !strlen(str) )
@@ -230,7 +230,7 @@ custom_param("low_crashinfo", parse_low_crashinfo);
  *
  * <addr> will be rounded down to the nearest power of two.  Defaults to 64G
  */
-static int __init parse_crashinfo_maxaddr(const char *str)
+static int __init cf_check parse_crashinfo_maxaddr(const char *str)
 {
     u64 addr;
     const char *q;
diff --git a/xen/common/memory.c b/xen/common/memory.c
index 38732dde6fd7..ede45c4af9db 100644
--- a/xen/common/memory.c
+++ b/xen/common/memory.c
@@ -62,7 +62,7 @@ static unsigned int __read_mostly hwdom_max_order = CONFIG_HWDOM_MAX_ORDER;
 static unsigned int __read_mostly ptdom_max_order = CONFIG_PTDOM_MAX_ORDER;
 #endif
 
-static int __init parse_max_order(const char *s)
+static int __init cf_check parse_max_order(const char *s)
 {
     if ( *s != ',' )
         domu_max_order = simple_strtoul(s, &s, 0);
diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c
index f8749b0787a6..ad06655158d2 100644
--- a/xen/common/page_alloc.c
+++ b/xen/common/page_alloc.c
@@ -179,7 +179,7 @@ enum bootscrub_mode {
  * https://bugs.llvm.org/show_bug.cgi?id=39707
  */
 static enum bootscrub_mode __read_mostly opt_bootscrub = BOOTSCRUB_IDLE;
-static int __init parse_bootscrub_param(const char *s)
+static int __init cf_check parse_bootscrub_param(const char *s)
 {
     /* Interpret 'bootscrub' alone in its positive boolean form */
     if ( *s == '\0' )
diff --git a/xen/common/sched/cpupool.c b/xen/common/sched/cpupool.c
index 8c6e6eb9ccd5..f0dd626054a6 100644
--- a/xen/common/sched/cpupool.c
+++ b/xen/common/sched/cpupool.c
@@ -93,7 +93,7 @@ static int sched_gran_get(const char *str, enum sched_gran *mode)
     return -EINVAL;
 }
 
-static int __init sched_select_granularity(const char *str)
+static int __init cf_check sched_select_granularity(const char *str)
 {
     return sched_gran_get(str, &opt_sched_granularity);
 }
diff --git a/xen/common/sched/credit2.c b/xen/common/sched/credit2.c
index 6396b38e044c..a5f073cda51e 100644
--- a/xen/common/sched/credit2.c
+++ b/xen/common/sched/credit2.c
@@ -456,7 +456,7 @@ static const char *const opt_runqueue_str[] = {
 };
 static int __read_mostly opt_runqueue = OPT_RUNQUEUE_SOCKET;
 
-static int __init parse_credit2_runqueue(const char *s)
+static int __init cf_check parse_credit2_runqueue(const char *s)
 {
     unsigned int i;
 
diff --git a/xen/drivers/acpi/tables.c b/xen/drivers/acpi/tables.c
index f39cd5eaac89..96ff96b84c66 100644
--- a/xen/drivers/acpi/tables.c
+++ b/xen/drivers/acpi/tables.c
@@ -472,7 +472,7 @@ int __init acpi_table_init(void)
 	return 0;
 }
 
-static int __init acpi_parse_apic_instance(const char *str)
+static int __init cf_check acpi_parse_apic_instance(const char *str)
 {
 	const char *q;
 
diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c
index a043e9521afd..4694be83db45 100644
--- a/xen/drivers/char/console.c
+++ b/xen/drivers/char/console.c
@@ -88,7 +88,7 @@ static const char con_timestamp_mode_2_string[][7] = {
     [TSM_RAW] = "raw",
 };
 
-static void con_timestamp_mode_upd(struct param_hypfs *par)
+static void cf_check con_timestamp_mode_upd(struct param_hypfs *par)
 {
     const char *val = con_timestamp_mode_2_string[opt_con_timestamp_mode];
 
@@ -98,7 +98,7 @@ static void con_timestamp_mode_upd(struct param_hypfs *par)
 #define con_timestamp_mode_upd(par)
 #endif
 
-static int parse_console_timestamps(const char *s);
+static int cf_check parse_console_timestamps(const char *s);
 custom_runtime_param("console_timestamps", parse_console_timestamps,
                      con_timestamp_mode_upd);
 
@@ -160,8 +160,8 @@ static int __read_mostly xenlog_guest_upper_thresh =
 static int __read_mostly xenlog_guest_lower_thresh =
     XENLOG_GUEST_LOWER_THRESHOLD;
 
-static int parse_loglvl(const char *s);
-static int parse_guest_loglvl(const char *s);
+static int cf_check parse_loglvl(const char *s);
+static int cf_check parse_guest_loglvl(const char *s);
 
 #ifdef CONFIG_HYPFS
 #define LOGLVL_VAL_SZ 16
@@ -176,13 +176,13 @@ static void xenlog_update_val(int lower, int upper, char *val)
     snprintf(val, LOGLVL_VAL_SZ, "%s/%s", lvl2opt[lower], lvl2opt[upper]);
 }
 
-static void __init xenlog_init(struct param_hypfs *par)
+static void __init cf_check xenlog_init(struct param_hypfs *par)
 {
     xenlog_update_val(xenlog_lower_thresh, xenlog_upper_thresh, xenlog_val);
     custom_runtime_set_var(par, xenlog_val);
 }
 
-static void __init xenlog_guest_init(struct param_hypfs *par)
+static void __init cf_check xenlog_guest_init(struct param_hypfs *par)
 {
     xenlog_update_val(xenlog_guest_lower_thresh, xenlog_guest_upper_thresh,
                       xenlog_guest_val);
@@ -240,7 +240,7 @@ static int _parse_loglvl(const char *s, int *lower, int *upper, char *val)
     return *s ? -EINVAL : 0;
 }
 
-static int parse_loglvl(const char *s)
+static int cf_check parse_loglvl(const char *s)
 {
     int ret;
 
@@ -251,7 +251,7 @@ static int parse_loglvl(const char *s)
     return ret;
 }
 
-static int parse_guest_loglvl(const char *s)
+static int cf_check parse_guest_loglvl(const char *s)
 {
     int ret;
 
@@ -793,7 +793,7 @@ static int printk_prefix_check(char *p, char **pp)
             ((loglvl < upper_thresh) && printk_ratelimit()));
 } 
 
-static int parse_console_timestamps(const char *s)
+static int cf_check parse_console_timestamps(const char *s)
 {
     switch ( parse_bool(s, NULL) )
     {
diff --git a/xen/drivers/cpufreq/cpufreq.c b/xen/drivers/cpufreq/cpufreq.c
index 419aae83eea6..36b079296235 100644
--- a/xen/drivers/cpufreq/cpufreq.c
+++ b/xen/drivers/cpufreq/cpufreq.c
@@ -65,7 +65,7 @@ enum cpufreq_controller cpufreq_controller = FREQCTL_xen;
 
 static int __init cpufreq_cmdline_parse(const char *s);
 
-static int __init setup_cpufreq_option(const char *str)
+static int __init cf_check setup_cpufreq_option(const char *str)
 {
     const char *arg = strpbrk(str, ",:");
     int choice;
diff --git a/xen/drivers/passthrough/amd/iommu_acpi.c b/xen/drivers/passthrough/amd/iommu_acpi.c
index b07fa4c40124..5ea227732821 100644
--- a/xen/drivers/passthrough/amd/iommu_acpi.c
+++ b/xen/drivers/passthrough/amd/iommu_acpi.c
@@ -704,7 +704,7 @@ static u16 __init parse_ivhd_device_extended_range(
     return dev_length;
 }
 
-static int __init parse_ivrs_ioapic(const char *str)
+static int __init cf_check parse_ivrs_ioapic(const char *str)
 {
     const char *s = str;
     unsigned long id;
@@ -742,7 +742,7 @@ static int __init parse_ivrs_ioapic(const char *str)
 }
 custom_param("ivrs_ioapic[", parse_ivrs_ioapic);
 
-static int __init parse_ivrs_hpet(const char *str)
+static int __init cf_check parse_ivrs_hpet(const char *str)
 {
     const char *s = str;
     unsigned long id;
@@ -1369,7 +1369,7 @@ int __init amd_iommu_get_supported_ivhd_type(void)
  * Format:
  * ivmd=<start>[-<end>][=<bdf1>[-<bdf1>'][,<bdf2>[-<bdf2>'][,...]]][;<start>...]
  */
-static int __init parse_ivmd_param(const char *s)
+static int __init cf_check parse_ivmd_param(const char *s)
 {
     do {
         unsigned long start, end;
diff --git a/xen/drivers/passthrough/iommu.c b/xen/drivers/passthrough/iommu.c
index fc18f63bd4ac..6ee267d2bfd4 100644
--- a/xen/drivers/passthrough/iommu.c
+++ b/xen/drivers/passthrough/iommu.c
@@ -64,7 +64,7 @@ bool_t __read_mostly amd_iommu_perdev_intremap = 1;
 
 DEFINE_PER_CPU(bool_t, iommu_dont_flush_iotlb);
 
-static int __init parse_iommu_param(const char *s)
+static int __init cf_check parse_iommu_param(const char *s)
 {
     const char *ss;
     int val, rc = 0;
@@ -135,7 +135,7 @@ static int __init parse_iommu_param(const char *s)
 }
 custom_param("iommu", parse_iommu_param);
 
-static int __init parse_dom0_iommu_param(const char *s)
+static int __init cf_check parse_dom0_iommu_param(const char *s)
 {
     const char *ss;
     int rc = 0;
diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
index e8b09d77d880..20cb246598b1 100644
--- a/xen/drivers/passthrough/pci.c
+++ b/xen/drivers/passthrough/pci.c
@@ -146,7 +146,7 @@ static struct phantom_dev {
 } phantom_devs[8];
 static unsigned int nr_phantom_devs;
 
-static int __init parse_phantom_dev(const char *str)
+static int __init cf_check parse_phantom_dev(const char *str)
 {
     const char *s;
     unsigned int seg, bus, slot;
@@ -182,7 +182,7 @@ custom_param("pci-phantom", parse_phantom_dev);
 static u16 __read_mostly command_mask;
 static u16 __read_mostly bridge_ctl_mask;
 
-static int __init parse_pci_param(const char *s)
+static int __init cf_check parse_pci_param(const char *s)
 {
     const char *ss;
     int rc = 0;
diff --git a/xen/drivers/passthrough/vtd/dmar.c b/xen/drivers/passthrough/vtd/dmar.c
index 33a12b2ae976..b152f3da916b 100644
--- a/xen/drivers/passthrough/vtd/dmar.c
+++ b/xen/drivers/passthrough/vtd/dmar.c
@@ -1084,7 +1084,7 @@ int intel_iommu_get_reserved_device_memory(iommu_grdm_t *func, void *ctxt)
  * If a segment is specified for other than the first device, and it does not
  * match the one specified for the first one, an error will be reported.
  */
-static int __init parse_rmrr_param(const char *str)
+static int __init cf_check parse_rmrr_param(const char *str)
 {
     const char *s = str, *cur, *stmp;
     unsigned int seg, bus, dev, func, dev_count;
diff --git a/xen/drivers/passthrough/vtd/quirks.c b/xen/drivers/passthrough/vtd/quirks.c
index 52b47dd89325..0590ddeea7c4 100644
--- a/xen/drivers/passthrough/vtd/quirks.c
+++ b/xen/drivers/passthrough/vtd/quirks.c
@@ -308,7 +308,7 @@ void vtd_ops_postamble_quirk(struct vtd_iommu *iommu)
     }
 }
 
-static int __init parse_snb_timeout(const char *s)
+static int __init cf_check parse_snb_timeout(const char *s)
 {
     int t;
     const char *q = NULL;
diff --git a/xen/drivers/video/vesa.c b/xen/drivers/video/vesa.c
index 2c1bbd927806..cb0e443be4dd 100644
--- a/xen/drivers/video/vesa.c
+++ b/xen/drivers/video/vesa.c
@@ -30,7 +30,7 @@ static unsigned int vram_remap;
 integer_param("vesa-map", vram_remap);
 
 static int font_height;
-static int __init parse_font_height(const char *s)
+static int __init cf_check parse_font_height(const char *s)
 {
     if ( simple_strtoul(s, &s, 10) == 8 && (*s++ == 'x') )
         font_height = simple_strtoul(s, &s, 10);
diff --git a/xen/xsm/flask/flask_op.c b/xen/xsm/flask/flask_op.c
index bb3bebc30e01..2d7ca3abaecd 100644
--- a/xen/xsm/flask/flask_op.c
+++ b/xen/xsm/flask/flask_op.c
@@ -28,8 +28,6 @@
 #define _copy_from_guest copy_from_guest
 
 enum flask_bootparam_t __read_mostly flask_bootparam = FLASK_BOOTPARAM_ENFORCING;
-static int parse_flask_param(const char *s);
-custom_param("flask", parse_flask_param);
 
 bool __read_mostly flask_enforcing = true;
 
@@ -60,7 +58,7 @@ static int flask_security_make_bools(void);
 
 extern int ss_initialized;
 
-static int __init parse_flask_param(const char *s)
+static int __init cf_check parse_flask_param(const char *s)
 {
     if ( !strcmp(s, "enforcing") )
         flask_bootparam = FLASK_BOOTPARAM_ENFORCING;
@@ -75,6 +73,7 @@ static int __init parse_flask_param(const char *s)
 
     return (flask_bootparam == FLASK_BOOTPARAM_INVALID) ? -EINVAL : 0;
 }
+custom_param("flask", parse_flask_param);
 
 static int domain_has_security(struct domain *d, u32 perms)
 {
diff --git a/xen/xsm/xsm_core.c b/xen/xsm/xsm_core.c
index 5fc3a5f75478..2286a502e3e8 100644
--- a/xen/xsm/xsm_core.c
+++ b/xen/xsm/xsm_core.c
@@ -55,7 +55,7 @@ static enum xsm_bootparam __initdata xsm_bootparam =
     XSM_BOOTPARAM_DUMMY;
 #endif
 
-static int __init parse_xsm_param(const char *s)
+static int __init cf_check parse_xsm_param(const char *s)
 {
     int rc = 0;
 
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 12:56:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 12:56:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271580.466082 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJauY-000235-8m; Mon, 14 Feb 2022 12:56:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271580.466082; Mon, 14 Feb 2022 12:56:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJauY-00022w-3b; Mon, 14 Feb 2022 12:56:58 +0000
Received: by outflank-mailman (input) for mailman id 271580;
 Mon, 14 Feb 2022 12:56:56 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJauV-0001Wb-T2
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 12:56:56 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 93f87492-8d95-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 13:56:52 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 93f87492-8d95-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644843413;
  h=from:to:cc:subject:date:message-id:mime-version:
   content-transfer-encoding;
  bh=29CmoU9xptN0UOwky8tYL5EorpibhBcah1/o27J5pFQ=;
  b=KhQXBas6LueM2FoG2LTwo//n0+Y15qtws2ayvKb6zAUQEXGUJ/wFAblw
   XmLO/byZiWS5MM42RyN6LV/AzUSISRovu4aT9dKDl26Im90JkmpXezvr3
   t34zNi2sBe75tjEmg+nU7utW9/JrN3pvvd7iGmUEW1U152btxq2yoAdm8
   Q=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: YQW0OeKcfGXIF1O+BL1fXYN9H+ypog1sfQo7O0/ICmRRNIFvAV1JPTJ5XWOSLxMkwyfBHBK38y
 V1J/zg4P+S3lj+VJqwSIC8V0Rk6N7qPpaN8IArKZnxtAP3lVhtiCF+e5VZGbnJqJHhpj9aG6HY
 KoxRRqUoJCqqQuUwuuZ1Mmm0xak1QPk+vjnaCKC1qvaFBRW336rZLacdnsFgWW74s56rw+/Ltk
 shPrD8X3VS6+XmYLsqSedNCgHzy5KUzI/kDezz4kbp6kL8Usx8MpHLlalTNlpoXKWdRJ7igAB9
 F5qptJ/XI6TdzllDTUozedP8
X-SBRS: 5.1
X-MesageID: 64148579
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:ePkb+qK4Skc9wNJgFE+RRJIlxSXFcZb7ZxGr2PjKsXjdYENS1jUEy
 jZKWGHUbPnbamf8eNxybI6+/UoPvpHVmtVhHgBlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokcxIn5BC5C5xZVG/fjgqoHUVaiUakideSc+EH170Ug6x7Zg6mJVqYPR7z2l6
 IuaT/L3YDdJ6xYsWo7Dw/vewP/HlK2aVAIw5jTSV9gS1LPtvyB94KYkDbOwNxPFrrx8RYZWc
 QphIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbrGvaUXe345iXMfwZ3u7hB2GvMBw9
 tF1jKXvChUlbqyct9keURxhRnQW0a1uoNcrIFC6uM2XiUbHb2Ht07NlC0Re0Y8wo7gtRzsUr
 LpBdW5LPkvra+GemdpXTsFFgMg5IdatF4QYonx6lhnSDOo8QICFSKLPjTNd9Gls35weQKmPD
 yYfQT9oVBHhWixLBm4sOowwxs2E2CPTcRQN/Tp5ooJoujOOnWSdyoPFPNXZd9OQTO1Jj02Yo
 STA5G2/DRYEXPST0SGA826srubXkDnnRZkJE7ml6v9thkbVzWsWYDUTXEG+qOO0iWa/XcxeM
 E0e/icyrak0+1evR9O7VBq9yFaUsxhZV9dOHukS7ACW1rGS8wufHnIDTDNKdJohrsBebR4A2
 0KNntjpLSdyq7DTQnWYnp+LqRuiNC5TKnUNDRLoViNcvYOl+ttqyEuSEJAzS8ZZk+EZBxn/4
 CCLkiwGvoxMztwHh6Tr0m3EgTeV882hohEO2i3bWWes7wVcbYGjZpC15VWz0cusPLp1XXHa4
 iFaxpH2APQmSMjUyXfTGLll8KSBuq7dWAAwl2KDCHXIG96F33e4Nb5d7zhlTKuCGpZVIGS5C
 KM/VO442XOyAJdIRfItC25SI55zpUQFKTgCfqqKBueimrArKGe6ENhGPCZ8JVzFnkk2ir0YM
 pyGa8uqBntyIf05kGbpF7dAjOdynXpWKYbvqXfTlUrP7FZjTCTNFedt3KWmMojVE59oUC2Kq
 o0CZqNmOj1UUfHkYzm/zGLgBQtiEJTPPriv85Y/XrfaemJOQTh9Y9eMkeJJU9E0xMx9y7aXl
 kxRr2cFkTITc1Wccl7UAp2iAZuyNatCQYUTY3B9YwbwgyJ7CWtthY9GH6YKkXAc3LQL5ZZJo
 zMtIq1s29xDFWbK/Sozd574oNAwfRinn1vWbSGkfCI+b9hrQAmQoo3oeQ7m9S8vCCurtJRh/
 +38h12DGZdTFR5/CMv2ae60yw/jt3Yqh+8vDVDDJcNeeRuw/dEyeTDxlPI+P+oFNQ7HmmmBz
 w+TDBpB/bvNroY5/cPnn6eBq4v1QeJyElADRzvQ7KqsNDmc9W2mmNcSXOGNdDHbdWX15KT9O
 rkFk6CiaKUKxQ8YvZB9HrBnybMFy+Hu/7IKnB55GHjrbkiwDu8yKHexwsQS5LZGwaVUuFXqV
 xvXqMVaI7iAJOjsDEUVeFg+du2G2PwZxmvS4PAyLBmo7SN75uPaA0BbPh3Kgy1BNrpldogix
 L556sIR7gW+jDssM8qH0X8IpzjdcCRYXvV1rIweDa/qlhEvmwNLbpHrAyPr5I2CNodXOU4wL
 z7I3KfPitywHKYZn6bfwZQV4ddguA==
IronPort-HdrOrdr: A9a23:hsOKxKvj6IGAgV5qXFgxSCD37skDdNV00zEX/kB9WHVpmszxra
 6TdZUgpGbJYVkqOE3I9ertBEDEewK4yXcX2/h2AV7BZniEhILAFugLhuGO/9SjIVybygc079
 YGT0EUMrzN5DZB4voSmDPIceod/A==
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="64148579"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>, Daniel De Graaf
	<dgdegra@tycho.nsa.gov>, Daniel Smith <dpsmith@apertussolutions.com>,
	=?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?=
	<marmarek@invisiblethingslab.com>
Subject: [PATCH v2 0/7] x86: Further harden function pointers
Date: Mon, 14 Feb 2022 12:56:25 +0000
Message-ID: <20220214125632.24563-1-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

Additional runtime hardning of indirect branches.  Depends on the CET-IBT
series.

Andrew Cooper (7):
  xen/altcall: Use __ro_after_init now that it exists
  x86/altcall: Check and optimise altcall targets
  x86/altcall: Optimise away endbr64 instruction where possible
  xsm: Use __initconst_cf_clobber for xsm_ops
  x86/hvm: Use __initdata_cf_clobber for hvm_funcs
  x86/ucode: Use altcall, and __initconst_cf_clobber
  x86/vpmu: Harden indirect branches

 xen/arch/x86/alternative.c         | 61 ++++++++++++++++++++++++++++++++++++++
 xen/arch/x86/cpu/microcode/amd.c   |  2 +-
 xen/arch/x86/cpu/microcode/core.c  | 38 +++++++++++++-----------
 xen/arch/x86/cpu/microcode/intel.c |  2 +-
 xen/arch/x86/cpu/vpmu_amd.c        |  2 +-
 xen/arch/x86/cpu/vpmu_intel.c      |  2 +-
 xen/arch/x86/hvm/hvm.c             |  2 +-
 xen/arch/x86/hvm/svm/svm.c         |  2 +-
 xen/arch/x86/hvm/vmx/vmx.c         |  2 +-
 xen/arch/x86/xen.lds.S             |  6 ++++
 xen/include/xen/alternative-call.h |  2 +-
 xen/include/xen/init.h             |  3 ++
 xen/xsm/dummy.c                    |  2 +-
 xen/xsm/flask/hooks.c              |  2 +-
 xen/xsm/silo.c                     |  2 +-
 15 files changed, 101 insertions(+), 29 deletions(-)

-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 12:56:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 12:56:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271579.466071 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJauW-0001mV-Vc; Mon, 14 Feb 2022 12:56:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271579.466071; Mon, 14 Feb 2022 12:56:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJauW-0001mO-Qz; Mon, 14 Feb 2022 12:56:56 +0000
Received: by outflank-mailman (input) for mailman id 271579;
 Mon, 14 Feb 2022 12:56:55 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJauU-0001Wb-T7
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 12:56:55 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 937cf4b1-8d95-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 13:56:52 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 937cf4b1-8d95-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644843412;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=1CKl1xVTrEiSTs3I4IXapDMOKGH0W00+m3pdXMEQ9Q4=;
  b=SW39No1f+WAJGY8o3q2fanQ1l0mIvM83jDXYDrIhxKJiDSj4Znl2hmxT
   voCljibNd9Eu4nYoHLAbwrBOxV9Hoz5q5Nj/4ysPNg+ygXlyQkHyiFT+B
   e9Zm3rJ8wxu6HWdgyfou999UCiiKK8zGvrB95erV69Lp3rwCdXCrS7DAW
   4=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: yiPOqDVw2uctAGuI2F6hqobxrJFB39GaQS3Gr4BUngEVXC8oBY5Lh1AqovGOM0unhmWINmJEf2
 UAabnTPv4oC+vZGTp02PDmTfz3gmUSjTQ6JYkDIN1xGnW25qRC0huXnPoY5O9an8arj5SJNn2H
 sADA2f3HsQzhNcPhLkGhz32UIl6zd0Ta5FFkm1q1z0HD6I/2tfaYR2e4BTnfTG0JOrTlBPSwwk
 ykMnc8wUoS6GJD7jk7PwyD8zphewqoQFy3ifaP8+H0uKozUGjtbRUCgTiGofefShypP9IGqQa1
 /UlTK/FNGIMJhalFMgorY/et
X-SBRS: 5.1
X-MesageID: 63591330
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Xf0rk6xvglxnJ/pLb3t6t+cLwSrEfRIJ4+MujC+fZmUNrF6WrkVRz
 2tOCmDUMquCYWfyLosiPYnipEgA7Z7czIBnHFRsqiAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAhLeNYYH1500g7wbdl2tcAbeWRWGthh
 /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL
 wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt9wy6
 tZ2tsKAc14sMaTzoMARUgl5CS4raMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr
 6ZBbmlQMFbT3Ipaw5riIgVoru0lINPmI8U0vXZ4wCuCJf0nXYrCU+PB4towMDIY2JsTTK+FP
 JJxhTxHfSXYUw9/Gw0rB5s1n8q3rWvGUTh7kQfAzUYwyzeKl1EguFT3C/LKfvSaSMMTmVyXz
 krk1WnkBhARNPSE1CGItHmrg4fnjS79HY4fCrC83vprm0GIgHweDgUMUlm2quX/jVSxM++zM
 GRNpHBo9/JrshX2EJ+tBHVUvUJooDYQGPhTKO5k2DvUz6Xd3D69CmkUbyROPYlOWNANeRQm0
 VqAntXMDDNpsaGIRX/1yop4vQ9eKgBOczZcOHZsoR8tpoC6/dpt1k6nosNLTfbt5uAZDw0c1
 NxjQMIWo7wIxfAG2Kyglbwsq2L9/8OZJuLZC+i+Y45E0u+bTNP/D2BLwQKChRqlEGp+ZgPf1
 EXoY+DEsIgz4WilzURhutklErCz/OqiOzbBm1NpFJRJ323zpyL8LdANvWknfx0B3iM4ldjBO
 hG7hO+szMULYCvCgVFfP+pd9PjGPYC/TI+4B5g4n/JFY4RrdR/vwc2dTRX44owZq2B1yftXE
 c7CKa6EVC9GYYw6nGveb7pMitcDm3FhrV4/sLimlnxLJ5LFPyXLIVrEWXPTBt0EAFSs/lmLr
 YYFapfiJtc2eLSWXxQ7OLU7dTgiRUXXz7iswyCOXuLccAdgBk87DPrdneEod4B/xvwHnebU5
 HCtHERfzQOn13HALAyLbFFlaa/uAskj/S5qY3R0MAb6wWUnbKau8LwbK8k9c444+bEx1vVzV
 fQEJZmNW6wdVjTd9j0BRpDht4g+Jg+zjAeDMnP9MjgydpJtXSLT/drgcle9/SUCFHPv58A/v
 6ehxkXQRp9aH1ZuC8PfafSOyVKtvCdCxLIuDhWQetQKIRfi6olnLSD1n8QbGcBUJEWR3Cae2
 iaXHQwc+bvHrbgq/YSbnquDtYqoTbdzRxIIA2nB4L+qHiDG5W7/k5RYWeOFcD2BBmP5/KKuO
 bdcw/3maaBVmV9Lt8x3EqpxzLJ47Nzq/ucIwgNhFXTNTlKqFrI/fSXWgZgR7vVAlu1DpA+7e
 kOT4d0La7yGNfTsHEMVOAd4PP+I0usZm2WK4Pk4SKkgCPSbIFZTvZ1uAiSx
IronPort-HdrOrdr: A9a23:FrYif6Dvp+uPM8/lHemU55DYdb4zR+YMi2TC1yhKJyC9Ffbo7v
 xG/c5rsyMc5wxwZJhNo7y90ey7MBbhHP1OkO4s1NWZLWrbUQKTRekIh+bfKn/baknDH4ZmpN
 9dmsNFaeEYY2IUsS+D2njbL+od
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="63591330"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>
Subject: [PATCH v2 2/7] x86/altcall: Check and optimise altcall targets
Date: Mon, 14 Feb 2022 12:56:27 +0000
Message-ID: <20220214125632.24563-3-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125632.24563-1-andrew.cooper3@citrix.com>
References: <20220214125632.24563-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

When converting indirect to direct calls, there is no need to execute endbr64
instructions.  Detect and optimise this case, leaving a warning in the case
that no endbr64 was found, as it likely indicates a build error.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>
---
 xen/arch/x86/alternative.c | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/xen/arch/x86/alternative.c b/xen/arch/x86/alternative.c
index ec24692e9595..65537fe1f0bd 100644
--- a/xen/arch/x86/alternative.c
+++ b/xen/arch/x86/alternative.c
@@ -18,6 +18,7 @@
 #include <xen/delay.h>
 #include <xen/types.h>
 #include <asm/apic.h>
+#include <asm/endbr.h>
 #include <asm/processor.h>
 #include <asm/alternative.h>
 #include <xen/init.h>
@@ -279,6 +280,28 @@ static void init_or_livepatch _apply_alternatives(struct alt_instr *start,
 
                 if ( dest )
                 {
+                    /*
+                     * When building for CET-IBT, all function pointer targets
+                     * should have an endbr64 instruction.
+                     *
+                     * If this is not the case, leave a warning because
+                     * something is probably wrong with the build.  A CET-IBT
+                     * enabled system might have exploded already.
+                     *
+                     * Otherwise, skip the endbr64 instruction.  This is a
+                     * marginal perf improvement which saves on instruction
+                     * decode bandwidth.
+                     */
+                    if ( IS_ENABLED(CONFIG_HAS_CC_CET_IBT) )
+                    {
+                        if ( is_endbr64(dest) )
+                            dest += 4;
+                        else
+                            printk(XENLOG_WARNING
+                                   "altcall %ps dest %ps has no endbr64\n",
+                                   orig, dest);
+                    }
+
                     disp = dest - (orig + 5);
                     ASSERT(disp == (int32_t)disp);
                     *(int32_t *)(buf + 1) = disp;
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 12:56:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 12:56:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271578.466060 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJauV-0001Wt-NO; Mon, 14 Feb 2022 12:56:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271578.466060; Mon, 14 Feb 2022 12:56:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJauV-0001Wm-Jq; Mon, 14 Feb 2022 12:56:55 +0000
Received: by outflank-mailman (input) for mailman id 271578;
 Mon, 14 Feb 2022 12:56:54 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJauU-0001Wb-4a
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 12:56:54 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 936b9f78-8d95-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 13:56:51 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 936b9f78-8d95-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644843412;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=5PEQQ/t+uQZA4fZ6sVBA/WN/mnXeBHxy/ygwI1pyIvY=;
  b=UNWjCus7gZ0E78JL6p9Q+IzjpzIRIhJ/KBofSrEHnQRMYZesRevVW8Bl
   bGX9XF81fKMqNwTh1xjwoW7ioYqAp0mMt+RMwoGSBZDbeg4JoAaj429/x
   iCtbmlrkzx7GYdhR0X3XJ3PMJZuGnkDp33cM4fQZV2Jix0WHHcP97tW4j
   E=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: m2EkVewb1vahR/r+JHRysfu1ZNgbrrv4szf28kTfkMw8j9nyP2VCXoMmmo/NXoJNzYYLSdjGBK
 rWmRMhGy/te638LFeR2boY87SbYNTST6qi2BkP/zk47jpUZett2qwx10BrSij1TGXNa8NPr2WT
 81oeZBqRg6/z1/bT/Rc3ZysTDu7/nw/MjSshHhpUcHeLPeaDhUG1KindsCAahJThHRP+gwvHcV
 RmEUKW7Vx2QoW1LlDy59o0JCS3Fq1xoIOfQdl4ztBDM/Wf9vG92q5KKNsA3QbXqc1WCahNkSce
 xG6uwEtrgu8RrI+loWr8qov0
X-SBRS: 5.1
X-MesageID: 66373620
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:KUs1xKvSm64PCejjaSMrIZ1kr+fnVGlZMUV32f8akzHdYApBsoF/q
 tZmKTyFa/2IMGCmeI93ao239BhVsJbVzIVlT1E5+C0yE3wX+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZQP0VOZigHtIQMsadUsxKbVIiGHdJZS5LwbZj2NYy2IThWmthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 Npl5b2dTyUpPLDwycsZUAFRLApAAPQZ5+qSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DFYUToHx/ixreCu4rW8vrSKTW/95Imjw3g6iiGN6AO
 ZFGMmQ1NHwsZTV3IHIoELwht92Fh1PcfDJgoVyz+Yw4tj27IAtZj+G2bYu9lsaxbdpRtlaVo
 CTB5WuRKjMwOcGbyDGF2mmxneKJliT+MKoCGbv9+vN0jVm7wm0IFAZQRVa9ueO+iEO1R5RYM
 UN8x8Y1hfFsrgrxFIC7BkDm5i7f1vIBZzZOO70bxQevyqjJ31e2AmscRwFqVuF/69BjEFTGy
 WS1t9/uADVutpicRnSc6qqYoFuOBMQFEYMRTXRaFFVYurEPtKl210uSFYg7TMZZm/WoQWmY/
 tyckMQpa1z/Z+Yv3r7zw13IiinESnPhHl9svVW/so5IA2pEiG+Zi26AtAKzARVodt/xory9U
 J8swZb20Qz2JcvR/BFhuc1UdF1T296LMSfHnXlkFIQ7+jKm9haLJN4MvG4udBo0ap9fI1cFh
 XM/XisLuvdu0IaCN/crM+pd9ex2pUQfKTgVfq+NNYcfCnSAXASG4DtvdSatM5PFyyARfVUEE
 c7DK66EVC9CYYw+lWbeb7pNgNcDm3FlrUuOFM+T8vhS+efHDJJjYexeawXmgyFQxP7snTg5B
 P4Ba5rUm00HCrWWj+u+2dd7EG3m5EMTXfjew/G7vMbaSua/MG1+WfLX3507fIlpw/ZcmuvSp
 ynvUU5E0lvvw3bALFzSOHxkbbruW7d5rG46YnNwbQr5hSB7bNb99robers2YaIjqL5pw8lrQ
 qRXYM6HGPlOFGjKomxPcZnnoYV+Xx23ngbSbTG9aT0ycsc4FQzE89PpZCX18ywKAnblvMcyu
 eT4hAjaXYACV0JpC8OPMKCjyFa4vH48nuNuXhSXfokPKRu0qIUzcn7/lP46Jc0IOC7v/DrC2
 lbEGwocqMnMv5QxrIvDi5ebotr7COB5BEdbQTXWtO7kKSnA82O/6oZcS+LULyvFXWb59aj+N
 +VYy/bwbK8OkFpQ6tcuFr9qyeQ15sf1pq8cxQNhRS2ZY1OuA7JmA3+HwcgQ6fEdmu4H4VO7C
 hCV591XGbSVI8e0QlceKT0sYvmHyfxJyCLZ6u44IRmi6SJ6lFZdvZ6+4/VYZPRhEYZI
IronPort-HdrOrdr: A9a23:BhIo76xSkGhTxw7hj4IAKrPwFL1zdoMgy1knxilNoRw8SKKlfq
 eV7Y0mPH7P+VAssR4b+exoVJPtfZqYz+8R3WBzB8bEYOCFghrKEGgK1+KLqFeMJ8S9zJ846U
 4JSdkHNDSaNzlHZKjBjzVQa+xQouW6zA==
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="66373620"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>
Subject: [PATCH v2 7/7] x86/vpmu: Harden indirect branches
Date: Mon, 14 Feb 2022 12:56:32 +0000
Message-ID: <20220214125632.24563-8-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125632.24563-1-andrew.cooper3@citrix.com>
References: <20220214125632.24563-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

As all function pointer calls are resoved to direct calls on boot, clobber the
endbr64 instructions too to make life harder for an attacker which has managed
to hijack a function pointer.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>

v2:
 * Use __initconst_cf_clobber
---
 xen/arch/x86/cpu/vpmu_amd.c   | 2 +-
 xen/arch/x86/cpu/vpmu_intel.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/xen/arch/x86/cpu/vpmu_amd.c b/xen/arch/x86/cpu/vpmu_amd.c
index 5963ce90150a..9bacc02ec135 100644
--- a/xen/arch/x86/cpu/vpmu_amd.c
+++ b/xen/arch/x86/cpu/vpmu_amd.c
@@ -518,7 +518,7 @@ static int cf_check svm_vpmu_initialise(struct vcpu *v)
     return 0;
 }
 
-static const struct arch_vpmu_ops __initconstrel amd_vpmu_ops = {
+static const struct arch_vpmu_ops __initconst_cf_clobber amd_vpmu_ops = {
     .initialise = svm_vpmu_initialise,
     .do_wrmsr = amd_vpmu_do_wrmsr,
     .do_rdmsr = amd_vpmu_do_rdmsr,
diff --git a/xen/arch/x86/cpu/vpmu_intel.c b/xen/arch/x86/cpu/vpmu_intel.c
index 48b81ab6f018..8612f46973ef 100644
--- a/xen/arch/x86/cpu/vpmu_intel.c
+++ b/xen/arch/x86/cpu/vpmu_intel.c
@@ -880,7 +880,7 @@ static int cf_check vmx_vpmu_initialise(struct vcpu *v)
     return 0;
 }
 
-static const struct arch_vpmu_ops __initconstrel core2_vpmu_ops = {
+static const struct arch_vpmu_ops __initconst_cf_clobber core2_vpmu_ops = {
     .initialise = vmx_vpmu_initialise,
     .do_wrmsr = core2_vpmu_do_wrmsr,
     .do_rdmsr = core2_vpmu_do_rdmsr,
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 12:56:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 12:56:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271581.466086 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJauY-00025A-IJ; Mon, 14 Feb 2022 12:56:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271581.466086; Mon, 14 Feb 2022 12:56:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJauY-00024F-C1; Mon, 14 Feb 2022 12:56:58 +0000
Received: by outflank-mailman (input) for mailman id 271581;
 Mon, 14 Feb 2022 12:56:57 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJauW-0001Wb-TF
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 12:56:57 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 94ef0e1e-8d95-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 13:56:53 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 94ef0e1e-8d95-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644843414;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=KtRbcAVnwSg90xFfImO++msF+yEET8LbZ8bFNj96oow=;
  b=XnpxBPus1N/rk/ODoaX71cZCNOvJYiSeGfpRmfGirqw3Lvp7yZWxT2P0
   KREbQNt9ZKeOccuzybgjQmPsvi/eQmMXEg+8ANT1c9O/4USO7ogfPlXqM
   JpSo/q8d2QpB2jsEqAgr45kG6uPwM4Wc4QaqbX/9OALVvLcwSG4OAZd2y
   0=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: dKn9DAspMXze6wdPTIGSTGLdIP4NAM7WUYNbmq8tRPm+h4w8jbiRpI7BSzM8c7NvOaxd1400wo
 r9t/Xfqym7h/0UNTRS7V9JKhxdOlGHY8Vv0M0xFnj4/fYoTcntRDCTkzP09Gu/fuEbkV9H8Riu
 nlxASVxCFzgIWqNCkE1fobiNpN1jvnFB7hk333c2k5ZFR838NNm76lehM10U3fwzudlbnzDkt2
 HlZx0tN1U094bXNMvuolH2z5ramWfdwat2pV+MaNKWhoOZzwQk5B8QQX0qEtikCZUKpnHQXkkr
 lSHNd/bccUIHvYCcYLqmykhw
X-SBRS: 5.1
X-MesageID: 63591331
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:E39jq6zvnrYqYvO/ibd6t+cLwSrEfRIJ4+MujC+fZmUNrF6WrkVSz
 GsfWD/VPfuMZTahLo0naI7n/EMEvJbczIU1SFNu/CAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAhLeNYYH1500g7wbdl2tcAbeWRWGthh
 /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL
 wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt9wy6
 tZ2tsKAc14sMaTzoMARUgl5CS4raMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr
 6ZBbmlQMFbT3Ipaw5riIgVoru0lINPmI8U0vXZ4wCuCJf0nXYrCU+PB4towMDIY2JsTTK+FP
 JNxhTxHPD/LQRBmAlUsLZ8Gmvj3iWL8IjkftwfAzUYwyzeKl1EguFT3C/LKfvSaSMMTmVyXz
 krk1WnkBhARNPSE1CGItHmrg4fnjS79HY4fCrC83vprm0GIgHweDgUMUlm2quX/jVSxM++zM
 GRNpHBo9/JrshX2EJ+tBHVUvUJooDYQGPhTKO5k2DvUz6Xd3D69CmkUbyROPYlOWNANeRQm0
 VqAntXMDDNpsaGIRX/1yop4vQ9eKgBOczZcOHZsoR8tpoC6/dpt1k6nosNLTfbt5uAZDw0c1
 NxjQMIWo7wIxfAG2Kyglbwsq2L9/8OZJuLZC+i+Y45E0u+bTNP/D2BLwQKChRqlEGp+ZgPf1
 EXoY+DEsIgz4WilzURhutklErCz/OqiOzbBm1NpFJRJ323zpyL8LdANvWknfx0B3iM4ldjBO
 hG7hO+szMULYCvCgVFfP+pd9PjGPYC/TI+4B5g4n/JFY4RrdR/vwc2dTRX44owZq2B1yftXE
 c7CKa6EVC9GYYw6nGveb7pMitcDm3FhrV4/sLimlnxLJ5LFPyXLIVrEWXPTBt0EAFSs/lmLr
 YYFapfiJtc2eLSWXxQ7OLU7dTgiRUXXz7iswyCOXuLccAdgBk87DPrdneEod4B/xvwHnebU5
 HCtHERfzQOn13HALAyLbFFlaa/uAskj/S5qY3R0MAb6wWUnbKau8LwbK8k9c444+bEx1vVzV
 fQEJZmNW6wdVjTd9j0BRpDht4g+Jg+zjAeDMnP9MjgydpJtXSLT/drgcle9/SUCFHPv58A/v
 6ehxkXQRp9aH1ZuC8PfafSOyVKtvCdCxLIuDhWQetQKIRfi6olnLSD1n8QbGcBUJEWR3Cae2
 iaXHQwc+bvHrbgq/YSbnquDtYqoTbdzRxIIA2nB4L+qHiDG5W7/k5RYWeOFcD2BBmP5/KKuO
 bdcw/3maaBVmV9Lt8x3EqpxzLJ47Nzq/ucIwgNhFXTNTlKqFrI/fSXWgZgR7vVAlu1DpA+7e
 kOT4d0La7yGNfTsHEMVOAd4PP+I0usZm2WK4Pk4SKkgCPSbIFZTvZ1uAiSx
IronPort-HdrOrdr: A9a23:mJT8lKAKX1KZImnlHemU55DYdb4zR+YMi2TC1yhKJyC9Ffbo7v
 xG/c5rsyMc5wxwZJhNo7y90ey7MBbhHP1OkO4s1NWZLWrbUQKTRekIh+bfKn/baknDH4ZmpN
 9dmsNFaeEYY2IUsS+D2njbL+od
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="63591331"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>
Subject: [PATCH v2 1/7] xen/altcall: Use __ro_after_init now that it exists
Date: Mon, 14 Feb 2022 12:56:26 +0000
Message-ID: <20220214125632.24563-2-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125632.24563-1-andrew.cooper3@citrix.com>
References: <20220214125632.24563-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

For the !CONFIG_ALTERNATIVE_CALL case, the use of __read_mostly was only a
stopgap while nothing better existed.  __ro_after_init now does, so it use.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>

v2:
 * New
---
 xen/include/xen/alternative-call.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/include/xen/alternative-call.h b/xen/include/xen/alternative-call.h
index c2d3b70e312e..5c6b9a562b92 100644
--- a/xen/include/xen/alternative-call.h
+++ b/xen/include/xen/alternative-call.h
@@ -57,7 +57,7 @@
 #define alternative_call(func, args...)  (func)(args)
 #define alternative_vcall(func, args...) (func)(args)
 
-#define __alt_call_maybe_initdata __read_mostly
+#define __alt_call_maybe_initdata __ro_after_init
 
 #endif /* !CONFIG_ALTERNATIVE_CALL */
 #endif /* XEN_ALTERNATIVE_CALL */
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 12:57:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 12:57:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271582.466103 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJauZ-0002Wa-RM; Mon, 14 Feb 2022 12:56:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271582.466103; Mon, 14 Feb 2022 12:56:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJauZ-0002VQ-LQ; Mon, 14 Feb 2022 12:56:59 +0000
Received: by outflank-mailman (input) for mailman id 271582;
 Mon, 14 Feb 2022 12:56:58 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJauX-0001Wb-TY
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 12:56:58 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 94d0a77e-8d95-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 13:56:53 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 94d0a77e-8d95-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644843413;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=U8FygIZVnvkagn5SaOc/r5k4iytMZOKvEHIjccC32Fg=;
  b=h0AUi6fL7zG25IqviVsZhv5zC6fIfjuxDQLYJFmcn4XLtItYBEylGxc+
   oH1ZWatyh0/axATCQDxRKaAOYf0cqN91VsGHRnd6eJUKtkblbal2PN0A5
   VcU5LZoZIdsgWj6Mh8Zffob5D17tsAj+UhdOkWDSjXEJhSdhoulA8r9b8
   A=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: ZV+Ox5Zu+D9haf/k3fZ44Be3lA/AUjNxxo1S/Znou5buCxV+gy0mqqM7EzOP5Npj5EkWwsIgAM
 5qzHzyVPnRR0+2ySGTOYhmoIGLvqdvFCXDQIjC7OQW91sewoHBsvO4tW/4oftNVjuN9vBPeSaj
 r4/4S8UMfPgbuZfHnk3WWUyHz5zHScqpXlI5IdnK0O3XGmsE+mNaI5XleBRJ5xduAj+hnz72xa
 F4DTPgbvnL7+YDFmZGgDxIbCgfGRXfd4M+x73LUXGAQZD97GpNK0UNMQgI6k2HanGew/ZtSpYP
 JyGmfHVrhsQhQg1dVhFpYRh+
X-SBRS: 5.1
X-MesageID: 66373621
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:GUkoEK34GQKaIx6DofbD5ex2kn2cJEfYwER7XKvMYLTBsI5bp2BRy
 GMcW2GDO62DZmHyeNpxO9/gpEsGscXTm4JrTAs5pC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkS5PE3oHJ9RGQ74nRLlbHILOCanAZqTNMEn9700o5wrJh2+aEvPDia++zk
 YKqyyHgEAfNNw5cagr4PIra9XuDFNyr0N8plgRWicJj5TcypFFMZH4rHomjLmOQf2VhNrXSq
 9Avbl2O1jixEx8FUrtJm1tgG6EAaua60QOm0hK6V0U+6/TrS+NbPqsTbZIhhUlrZzqhz/Fcz
 vdNt4GMGCgtPbXFp88jbkAHDHQrVUFG0OevzXmXtMWSywvNcmf2wuUoB0YzVWEa0r8pWycUr
 6VecW1TKEDY7w616OvTpu1Er8IvNsT0eqgYvWlt12rxBvc6W5HTBa7N4Le02R9u2JsRRqiEP
 qL1bxJRQR6QWwEMHW00N61ngOuZnV6gU2dH/Qf9Sa0fvDGIkV0ZPKLWGMXRUsyHQ4NShEnwj
 kDs8nn9AxoaHMeC0jfD+XWp7sffkCW+VI8MGbmQ8v9xnEbV1mEVEAcRV1awvb++kEHWZj5EA
 xVKoGx09/F0rRH1CImmN/GlnJKalk49dtxyE+8n1FCizqnM6jmyOFVdESEUPbTKq/QKbTAt0
 1aImfbgCjpurKCZRBqhy1uEkd+hEXNLdDFfPEfoWSNAuoC++99r0nojW/4+SPbdszHjJd3nL
 9lmRgAajq5bs8ME3r7TEbvv02P1/cihouLYC2zqsoOZAuFROdTNi2+AswGzARN8wGGxFAfpg
 ZT8s5LChN3i9LnU/MB3fM0DHauy+9GOOyDGjFhkEvEJrmrxpyHzLd0NuGglfi+F1/ronhezP
 ifuVf55vscPbBNGk4crC25ONyja5fe5Tom0PhwlRtFPfoJwZGe6ENJGPiatM5TWuBF0y8kXY
 M7DGe71VCpyIfk3nVKeGrZGuZd2l39W+I8mbc2ip/hR+eHFPyD9pHZsGAbmU93VG4va/FSLo
 44HbZPiJtc2eLSWXxQ7OLU7dTgiRUXXz7ivwyCOXuLccAdgBk87DPrdneEod4B/xvwHnebU5
 HCtHERfzQOn13HALAyLbFFlaa/uAskj/S5qY3R0MAb6wWUnbKau8LwbK8k9c444+bEx1vVzV
 fQEJZmNW6wdVjTd9j0BRpDht4g+Jg+zjAeDMnP9MjgydpJtXSLT/drgcle9/SUCFHPv58A/v
 6ehxkXQRp9aH1ZuC8PfafSOyVKtvCdCxLIuDhWQetQKIRfi6olnLSD1n8QbGcBUJEWR3Cae2
 iaXHQwc+bvHrbgq/YSbnquDtYqoTbdzRxIIA2nB4L+qHiDG5W7/k5RYWeOFcD2BBmP5/KKuO
 bdcw/3maaBVmV9Lt8x3EqpxzLJ47Nzq/ucIwgNhFXTNTlKqFrI/fSXWgZgR7vVAlu1DpA+7e
 kOT4d0La7yGNfTsHEMVOAd4PP+I0usZm2WK4Pk4SKkgCPSbIFZTvZ1uAiSx
IronPort-HdrOrdr: A9a23:GYGrrKCY9De2a3blHemU55DYdb4zR+YMi2TC1yhKJyC9Ffbo7v
 xG/c5rsyMc5wxwZJhNo7y90ey7MBbhHP1OkO4s1NWZLWrbUQKTRekIh+bfKn/baknDH4ZmpN
 9dmsNFaeEYY2IUsS+D2njbL+od
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="66373621"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>
Subject: [PATCH v2 6/7] x86/ucode: Use altcall, and __initconst_cf_clobber
Date: Mon, 14 Feb 2022 12:56:31 +0000
Message-ID: <20220214125632.24563-7-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125632.24563-1-andrew.cooper3@citrix.com>
References: <20220214125632.24563-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

Microcode loading is not a fastpath, but there are control flow integrity
hardening benefits from using altcall, because it allows us to clobber the
endbr64 instructions on all function pointer targets.

Convert the existing microcode_ops pointer into an __ro_after_init structure,
and move {amd,intel}_ucode_ops into __initconst_cf_clobber.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>

v2:
 * Adjust commit message.
 * Use __initconst_cf_clobber and __ro_after_init.
---
 xen/arch/x86/cpu/microcode/amd.c   |  2 +-
 xen/arch/x86/cpu/microcode/core.c  | 38 ++++++++++++++++++++------------------
 xen/arch/x86/cpu/microcode/intel.c |  2 +-
 3 files changed, 22 insertions(+), 20 deletions(-)

diff --git a/xen/arch/x86/cpu/microcode/amd.c b/xen/arch/x86/cpu/microcode/amd.c
index 0afa2192bf1d..8195707ee149 100644
--- a/xen/arch/x86/cpu/microcode/amd.c
+++ b/xen/arch/x86/cpu/microcode/amd.c
@@ -422,7 +422,7 @@ static struct microcode_patch *cf_check cpu_request_microcode(
     return patch;
 }
 
-const struct microcode_ops amd_ucode_ops = {
+const struct microcode_ops __initconst_cf_clobber amd_ucode_ops = {
     .cpu_request_microcode            = cpu_request_microcode,
     .collect_cpu_info                 = collect_cpu_info,
     .apply_microcode                  = apply_microcode,
diff --git a/xen/arch/x86/cpu/microcode/core.c b/xen/arch/x86/cpu/microcode/core.c
index f84dafa82693..452a7ca77340 100644
--- a/xen/arch/x86/cpu/microcode/core.c
+++ b/xen/arch/x86/cpu/microcode/core.c
@@ -21,6 +21,7 @@
  * 2 of the License, or (at your option) any later version.
  */
 
+#include <xen/alternative-call.h>
 #include <xen/cpu.h>
 #include <xen/earlycpio.h>
 #include <xen/err.h>
@@ -214,7 +215,7 @@ void __init microcode_grab_module(
         microcode_scan_module(module_map, mbi);
 }
 
-static const struct microcode_ops __read_mostly *microcode_ops;
+static struct microcode_ops __ro_after_init ucode_ops;
 
 static DEFINE_SPINLOCK(microcode_mutex);
 
@@ -241,9 +242,9 @@ static const struct microcode_patch *nmi_patch = ZERO_BLOCK_PTR;
  */
 static struct microcode_patch *parse_blob(const char *buf, size_t len)
 {
-    microcode_ops->collect_cpu_info();
+    alternative_vcall(ucode_ops.collect_cpu_info);
 
-    return microcode_ops->cpu_request_microcode(buf, len);
+    return alternative_call(ucode_ops.cpu_request_microcode, buf, len);
 }
 
 static void microcode_free_patch(struct microcode_patch *patch)
@@ -258,8 +259,8 @@ static bool microcode_update_cache(struct microcode_patch *patch)
 
     if ( !microcode_cache )
         microcode_cache = patch;
-    else if ( microcode_ops->compare_patch(patch,
-                                           microcode_cache) == NEW_UCODE )
+    else if ( alternative_call(ucode_ops.compare_patch,
+                               patch, microcode_cache) == NEW_UCODE )
     {
         microcode_free_patch(microcode_cache);
         microcode_cache = patch;
@@ -311,14 +312,14 @@ static int microcode_update_cpu(const struct microcode_patch *patch)
 {
     int err;
 
-    microcode_ops->collect_cpu_info();
+    alternative_vcall(ucode_ops.collect_cpu_info);
 
     spin_lock(&microcode_mutex);
     if ( patch )
-        err = microcode_ops->apply_microcode(patch);
+        err = alternative_call(ucode_ops.apply_microcode, patch);
     else if ( microcode_cache )
     {
-        err = microcode_ops->apply_microcode(microcode_cache);
+        err = alternative_call(ucode_ops.apply_microcode, microcode_cache);
         if ( err == -EIO )
         {
             microcode_free_patch(microcode_cache);
@@ -368,7 +369,7 @@ static int primary_thread_work(const struct microcode_patch *patch)
     if ( !wait_for_state(LOADING_ENTER) )
         return -EBUSY;
 
-    ret = microcode_ops->apply_microcode(patch);
+    ret = alternative_call(ucode_ops.apply_microcode, patch);
     if ( !ret )
         atomic_inc(&cpu_updated);
     atomic_inc(&cpu_out);
@@ -481,7 +482,7 @@ static int control_thread_fn(const struct microcode_patch *patch)
     }
 
     /* Control thread loads ucode first while others are in NMI handler. */
-    ret = microcode_ops->apply_microcode(patch);
+    ret = alternative_call(ucode_ops.apply_microcode, patch);
     if ( !ret )
         atomic_inc(&cpu_updated);
     atomic_inc(&cpu_out);
@@ -610,7 +611,8 @@ static long cf_check microcode_update_helper(void *data)
      */
     spin_lock(&microcode_mutex);
     if ( microcode_cache &&
-         microcode_ops->compare_patch(patch, microcode_cache) != NEW_UCODE )
+         alternative_call(ucode_ops.compare_patch,
+                          patch, microcode_cache) != NEW_UCODE )
     {
         spin_unlock(&microcode_mutex);
         printk(XENLOG_WARNING "microcode: couldn't find any newer revision "
@@ -678,7 +680,7 @@ int microcode_update(XEN_GUEST_HANDLE(const_void) buf, unsigned long len)
     if ( len != (uint32_t)len )
         return -E2BIG;
 
-    if ( microcode_ops == NULL )
+    if ( !ucode_ops.apply_microcode )
         return -EINVAL;
 
     buffer = xmalloc_flex_struct(struct ucode_buf, buffer, len);
@@ -722,10 +724,10 @@ __initcall(microcode_init);
 /* Load a cached update to current cpu */
 int microcode_update_one(void)
 {
-    if ( !microcode_ops )
+    if ( !ucode_ops.apply_microcode )
         return -EOPNOTSUPP;
 
-    microcode_ops->collect_cpu_info();
+    alternative_vcall(ucode_ops.collect_cpu_info);
 
     return microcode_update_cpu(NULL);
 }
@@ -780,22 +782,22 @@ int __init early_microcode_init(void)
     {
     case X86_VENDOR_AMD:
         if ( c->x86 >= 0x10 )
-            microcode_ops = &amd_ucode_ops;
+            ucode_ops = amd_ucode_ops;
         break;
 
     case X86_VENDOR_INTEL:
         if ( c->x86 >= 6 )
-            microcode_ops = &intel_ucode_ops;
+            ucode_ops = intel_ucode_ops;
         break;
     }
 
-    if ( !microcode_ops )
+    if ( !ucode_ops.apply_microcode )
     {
         printk(XENLOG_WARNING "Microcode loading not available\n");
         return -ENODEV;
     }
 
-    microcode_ops->collect_cpu_info();
+    alternative_vcall(ucode_ops.collect_cpu_info);
 
     if ( ucode_mod.mod_end || ucode_blob.size )
         rc = early_microcode_update_cpu();
diff --git a/xen/arch/x86/cpu/microcode/intel.c b/xen/arch/x86/cpu/microcode/intel.c
index d3864b5ab03e..f5ba6d76d724 100644
--- a/xen/arch/x86/cpu/microcode/intel.c
+++ b/xen/arch/x86/cpu/microcode/intel.c
@@ -376,7 +376,7 @@ static struct microcode_patch *cf_check cpu_request_microcode(
     return patch;
 }
 
-const struct microcode_ops intel_ucode_ops = {
+const struct microcode_ops __initconst_cf_clobber intel_ucode_ops = {
     .cpu_request_microcode            = cpu_request_microcode,
     .collect_cpu_info                 = collect_cpu_info,
     .apply_microcode                  = apply_microcode,
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 12:57:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 12:57:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271583.466109 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJaua-0002dT-DP; Mon, 14 Feb 2022 12:57:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271583.466109; Mon, 14 Feb 2022 12:57:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJaua-0002ck-2n; Mon, 14 Feb 2022 12:57:00 +0000
Received: by outflank-mailman (input) for mailman id 271583;
 Mon, 14 Feb 2022 12:56:59 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJauY-0001Wb-Tg
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 12:56:59 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 955ad2c9-8d95-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 13:56:54 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 955ad2c9-8d95-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644843414;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=mNfie2MP8cG2OgPaZ9Su1HgYG5WuL0YllF2ieG0fnJE=;
  b=BJW87xX7vA4vhnS5jjLLg60j6+WVq5cK3/EIdz3u3Vm6Nw2sfakxl5f5
   qON0BYKghu8nsIv0vpL3RMzglz8g/CsncEyVDtJtPo6hdTqfYJDGS9TRk
   Taw1p5UrXV17Y3hdYCao/cGKHRzwWiSWXq4LKm3wo+eQTP7utpHPVadiZ
   o=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: 5fwCK46QNMINHaSODo3dbe9bwNd34zbkmByn1roMykKdwEluZshOOOzrf+BHQL8W3mmgOHjo02
 WFPM7Qm/4We8QH2wMprEhZAnGVIE3gfoQ8qBPcbYTnFyM/yUU5CMeHEz72CmpTndMojnReikJU
 3XjDzQbFmKvPNoLYlCNnNYBncfOsXSpb4cWCCaK7b2JwHXMUfuCmsj0EooIS3y9JQpAKtgbp+A
 uesMuQi+HOUeybjNLxqYjEV20VeuCfJ6y/fqqe23QasiL6y+QCTl9lyn3XXl6l82w83e9qUiM7
 n2vmTys8IA+M5cCki/Q+iw5A
X-SBRS: 5.1
X-MesageID: 64148580
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:lGd3sKtnr8WgXqPMkLJOvq260ufnVGlZMUV32f8akzHdYApBsoF/q
 tZmKWDXOvzYY2b2KdggaojnoE4E6sDUx9RgHgVtqi43ES1H+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZQP0VOZigHtIQMsadUsxKbVIiGHdJZS5LwbZj2NYy2IThWmthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 Nplur+gSDktBpT1x6cPX0lZQw5DPq9DweqSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DFYUToHx/ixreCu4rW8vrSKTW/95Imjw3g6iiGN6AO
 5NFOWc/NHwsZTVRZngNCqpls92yj0HiQwVVkV6Qlbsetj27IAtZj+G2bYu9lsaxbdpRtlaVo
 CTB5WuRKjMwOcGbyDGF2mmxneKJliT+MKoCGbv9+vN0jVm7wm0IFAZQRVa9ueO+iEO1R5RYM
 UN8x8Y1hfFsrgrxFIC7BkDm5i7f1vIBZzZOO+IZ+ACzzpLt2lnaFGRUT25uVd8ksfZjEFTGy
 WS1t9/uADVutpicRnSc6qqYoFuOBMQFEYMRTXRaFFVYurEPtKl210uSFYg7TMZZm/WoQWmY/
 tyckMQpa1z/Z+Yv3r7zw13IiinESnPhHl9svVW/so5IA2pEiG+Zi26AtAKzARVodt/xory9U
 J8swZb20Qz2JcvR/BFhuc1UdF1T296LMSfHnXlkFIQ7+jKm9haLJN4MvG4udBo0ap9fI1cFh
 XM/XisLuvdu0IaCN/crM+pd9ex2pUQfKTgVfq+NNYcfCnSAXASG4DtvdSatM5PFyyARfVUEE
 c7DK66EVC9CYYw+lWbeb7pNgNcDm3FlrUuOFM+T8vhS+efHDJJjYexeawXmgyFQxP7snTg5B
 P4Ba5rUm00HCrWWj+u+2dd7EG3m5EMTXfjew/G7vMbaSua/MG1+WfLX3507fIlpw/ZcmuvSp
 ynvUU5E0lvvw3bALFzSOHxkbbruW7d5rG46YnNwbQr5hSB7bNb99robers2YaIjqL5pw8lrQ
 qRXYM6HGPlOFGjKomxPcZnnoYV+Xx23ngbSbTG9aT0ycsc4FQzE89PpZCX18ywKAnblvMcyu
 eT4hAjaXYACV0JpC8OPMKCjyFa4vH48nuNuXhSXfokPKRu0qIUzcn7/lP46Jc0IOC7v/DrC2
 lbEGwocqMnMv5QxrIvDi5ebotr7COB5BEdbQTXWtO7kKSnA82O/6oZcS+LULyvFXWb59aj+N
 +VYy/bwbK8OkFpQ6tcuFr9qyeQ15sf1pq8cxQNhRS2ZY1OuA7JmA3+HwcgQ6fEdmu4H4VO7C
 hCV591XGbSVI8e0QlceKT0sYvmHyfxJyCLZ6u44IRmi6SJ6lFZdvZ6+4/VYZPRhEYZI
IronPort-HdrOrdr: A9a23:anNxi6A1HdEPhzrlHemu55DYdb4zR+YMi2TC1yhKJyC9E/bo7v
 xG88566faZslossTQb6LW90cq7MBXhHPxOkOos1N6ZNWGM0gaVxcNZnO/fKlXbakrDH4VmtJ
 uIHZIQNDSJNykZsfrH
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="64148580"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>
Subject: [PATCH v2 5/7] x86/hvm: Use __initdata_cf_clobber for hvm_funcs
Date: Mon, 14 Feb 2022 12:56:30 +0000
Message-ID: <20220214125632.24563-6-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125632.24563-1-andrew.cooper3@citrix.com>
References: <20220214125632.24563-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

All calls through hvm_funcs are fully altcall'd.  Harden all function pointer
targets.

This optimises away 106 targets.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>
---
 xen/arch/x86/hvm/hvm.c     | 2 +-
 xen/arch/x86/hvm/svm/svm.c | 2 +-
 xen/arch/x86/hvm/vmx/vmx.c | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c
index cdd1529014f2..709a4191efe8 100644
--- a/xen/arch/x86/hvm/hvm.c
+++ b/xen/arch/x86/hvm/hvm.c
@@ -88,7 +88,7 @@ unsigned int opt_hvm_debug_level __read_mostly;
 integer_param("hvm_debug", opt_hvm_debug_level);
 #endif
 
-struct hvm_function_table hvm_funcs __read_mostly;
+struct hvm_function_table __ro_after_init hvm_funcs;
 
 /*
  * The I/O permission bitmap is globally shared by all HVM guests except
diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c
index 63535a74b504..b80d4af6cb90 100644
--- a/xen/arch/x86/hvm/svm/svm.c
+++ b/xen/arch/x86/hvm/svm/svm.c
@@ -2513,7 +2513,7 @@ static void cf_check svm_set_reg(struct vcpu *v, unsigned int reg, uint64_t val)
     }
 }
 
-static struct hvm_function_table __initdata svm_function_table = {
+static struct hvm_function_table __initdata_cf_clobber svm_function_table = {
     .name                 = "SVM",
     .cpu_up_prepare       = svm_cpu_up_prepare,
     .cpu_dead             = svm_cpu_dead,
diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c
index 41db538a9e3d..758df3321884 100644
--- a/xen/arch/x86/hvm/vmx/vmx.c
+++ b/xen/arch/x86/hvm/vmx/vmx.c
@@ -2473,7 +2473,7 @@ static void cf_check vmx_set_reg(struct vcpu *v, unsigned int reg, uint64_t val)
     vmx_vmcs_exit(v);
 }
 
-static struct hvm_function_table __initdata vmx_function_table = {
+static struct hvm_function_table __initdata_cf_clobber vmx_function_table = {
     .name                 = "VMX",
     .cpu_up_prepare       = vmx_cpu_up_prepare,
     .cpu_dead             = vmx_cpu_dead,
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 12:57:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 12:57:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271584.466127 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJauc-0003Ar-DQ; Mon, 14 Feb 2022 12:57:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271584.466127; Mon, 14 Feb 2022 12:57:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJauc-00039K-1n; Mon, 14 Feb 2022 12:57:02 +0000
Received: by outflank-mailman (input) for mailman id 271584;
 Mon, 14 Feb 2022 12:57:00 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJauZ-0001Wb-Tq
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 12:57:00 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9606d693-8d95-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 13:56:55 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9606d693-8d95-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644843415;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=Sj4Jt6Qi86GvIWajmlKXBFXybjwDfP/78ikZXyhmmlU=;
  b=Y7kW5HibSl3KdYRQF/fSbJxPwlnAR7oxkFMSUdmTK8B2Tj1b90hRNk5x
   H1g8Oxw3Tv/pljALuFGVhKewwFSVpgUukBMaB/a43dILMV+XSTSiRXc4Z
   eCXmKK2sTj8AUrCqGMig77MbXI57qtYu9xzdSCR0ISj1/RZaaRUzVz5Sz
   U=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: T3ZvleISg0fcIDCNoPBSn4fFdiIE5ZN1Of8msHm4HwP9rjDGw3/8kUwHCoppwYbF0NXPTuFYq5
 XhJkEsnmFEEGYNO9VyI7mcZ4v48ItQLf5iusNSmTPTL1/M9swOtapgq5sD8oESsc00fWmN9b8u
 MdC1uWcrcR+NdSFVRh/pXuBxNsxtTaXpr/sBhtMu68CglmfhBurzF9Hf9kKE0xpL/nb0EBEUtK
 5UG8yvsCXqBwupfJTPD+5LuCu60Lrm7AcXxP3pe7e2yBKwC8Qo3bEFt9YCNrBK+uNux9bQozCt
 elKK8j9wMOPYhhewDF00XAxn
X-SBRS: 5.1
X-MesageID: 64148581
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:WiQv1Kthah/KGO5iXfWROpuHPufnVGlZMUV32f8akzHdYApBsoF/q
 tZmKT2COaqNN2LzeN5yaY+3oxlTvsSAyoAwS1Fk/igwQXtD+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZQP0VOZigHtIQMsadUsxKbVIiGHdJZS5LwbZj2NYy2IThWmthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 NplmKybGClqEYT3t6c9XgYDNz4lZJIX5+qSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DFYUToHx/ixreCu4rW8vrSKTW/95Imjw3g6iiGN6AO
 5NFOWc/NXwsZTVKKgdQE4hkp9uNhyX0WGR3uUqlr684tj27IAtZj+G2bYu9lsaxbdpRtlaVo
 CTB5WuRKjMwOcGbyDGF2mmxneKJliT+MKoCGbv9+vN0jVm7wm0IFAZQRVa9ueO+iEO1R5RYM
 UN8x8Y1hfFsrgrxFIC7BkDm5i7f1vIBZzZOO8AKw1CjiYX92CnaJmUbFRpeM4UZ5dBjEFTGy
 WS1t9/uADVutpicRnSc6qqYoFuOBMQFEYMRTXRaFFVYurEPtKl210uSFYg7TMZZm/WoQWmY/
 tyckMQpa1z/Z+Yv3r7zw13IiinESnPhHl9svVW/so5IA2pEiG+Zi26AtAKzARVodt/xory9U
 J8swZb20Qz2JcvR/BFhuc1UdF1T296LMSfHnXlkFIQ7+jKm9haLJN4MvG4udBo0ap9fI1cFh
 XM/XisLuvdu0IaCN/crM+pd9ex2pUQfKTgVfq+NNYcfCnSAXASG4DtvdSatM5PFyyARfVUEE
 c7DK66EVC9CYYw+lWbeb7pNgNcDm3FlrUuOFM+T8vhS+efHDJJjYexeawXmgyFQxP7snTg5B
 P4Ba5rUm00HCrWWj+u+2dd7EG3m5EMTXfjew/G7vMbaSua/MG1+WfLX3507fIlpw/ZcmuvSp
 ynvUU5E0lvvw3bALFzSOHxkbbruW7d5rG46YnNwbQr5hSB7bNb99robers2YaIjqL5pw8lrQ
 qRXYM6HGPlOFGjKomxPcZnnoYV+Xx23ngbSbTG9aT0ycsc4FQzE89PpZCX18ywKAnblvMcyu
 eT4hAjaXYACV0JpC8OPMKCjyFa4vH48nuNuXhSXfokPKRu0qIUzcn7/lP46Jc0IOC7v/DrC2
 lbEGwocqMnMv5QxrIvDi5ebotr7COB5BEdbQTXWtO7kKSnA82O/6oZcS+LULyvFXWb59aj+N
 +VYy/bwbK8OkFpQ6tcuFr9qyeQ15sf1pq8cxQNhRS2ZY1OuA7JmA3+HwcgQ6fEdmu4H4VO7C
 hCV591XGbSVI8e0QlceKT0sYvmHyfxJyCLZ6u44IRmi6SJ6lFZdvZ6+4/VYZPRhEYZI
IronPort-HdrOrdr: A9a23:0zFgi6rR0SBIdGgg/dQHZPYaV5opeYIsimQD101hICG8cqSj+f
 xG/c5rrCMc5wxwZJhNo7y90ey7MBbhHP1OkO8s1NWZLWrbUQKTRekIh+bfKn/baknDH4ZmpM
 BdmsNFaeEYY2IUsS+D2njbL+od
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="64148581"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>
Subject: [PATCH v2 3/7] x86/altcall: Optimise away endbr64 instruction where possible
Date: Mon, 14 Feb 2022 12:56:28 +0000
Message-ID: <20220214125632.24563-4-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125632.24563-1-andrew.cooper3@citrix.com>
References: <20220214125632.24563-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

With altcall, we convert indirect branches into direct ones.  With that
complete, none of the potential targets need an endbr64 instruction.

Furthermore, removing the endbr64 instructions is a security defence-in-depth
improvement, because it limits the options available to an attacker who has
managed to hijack a function pointer.

Introduce new .init.{ro,}data.cf_clobber sections.  Have _apply_alternatives()
walk over this, looking for any pointers into .text, and clobber an endbr64
instruction if found.  This is some minor structure (ab)use but it works
alarmingly well.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>

It would be nice for the printk() to say "optimised away %u of %u", but the
latter number can only feasibly come from post-processing of xen-syms during
the build.

v2:
 * Drop hard tabs
 * Add __initconst_cf_clobber too
 * Change types to reduce casting
---
 xen/arch/x86/alternative.c | 38 ++++++++++++++++++++++++++++++++++++++
 xen/arch/x86/xen.lds.S     |  6 ++++++
 xen/include/xen/init.h     |  3 +++
 3 files changed, 47 insertions(+)

diff --git a/xen/arch/x86/alternative.c b/xen/arch/x86/alternative.c
index 65537fe1f0bd..dd4609070001 100644
--- a/xen/arch/x86/alternative.c
+++ b/xen/arch/x86/alternative.c
@@ -173,6 +173,9 @@ text_poke(void *addr, const void *opcode, size_t len)
     return memcpy(addr, opcode, len);
 }
 
+extern void *const __initdata_cf_clobber_start[];
+extern void *const __initdata_cf_clobber_end[];
+
 /*
  * Replace instructions with better alternatives for this CPU type.
  * This runs before SMP is initialized to avoid SMP problems with
@@ -330,6 +333,41 @@ static void init_or_livepatch _apply_alternatives(struct alt_instr *start,
         add_nops(buf + a->repl_len, total_len - a->repl_len);
         text_poke(orig, buf, total_len);
     }
+
+    /*
+     * Clobber endbr64 instructions now that altcall has finished optimising
+     * all indirect branches to direct ones.
+     */
+    if ( force && cpu_has_xen_ibt )
+    {
+        void *const *val;
+        unsigned int clobbered = 0;
+
+        /*
+         * This is some minor structure (ab)use.  We walk the entire contents
+         * of .init.{ro,}data.cf_clobber as if it were an array of pointers.
+         *
+         * If the pointer points into .text, and at an endbr64 instruction,
+         * nop out the endbr64.  This causes the pointer to no longer be a
+         * legal indirect branch target under CET-IBT.  This is a
+         * defence-in-depth measure, to reduce the options available to an
+         * adversary who has managed to hijack a function pointer.
+         */
+        for ( val = __initdata_cf_clobber_start;
+              val < __initdata_cf_clobber_end;
+              val++ )
+        {
+            void *ptr = *val;
+
+            if ( !is_kernel_text(ptr) || !is_endbr64(ptr) )
+                continue;
+
+            add_nops(ptr, 4);
+            clobbered++;
+        }
+
+        printk("altcall: Optimised away %u endbr64 instructions\n", clobbered);
+    }
 }
 
 void init_or_livepatch apply_alternatives(struct alt_instr *start,
diff --git a/xen/arch/x86/xen.lds.S b/xen/arch/x86/xen.lds.S
index ca22e984f807..c399178ac123 100644
--- a/xen/arch/x86/xen.lds.S
+++ b/xen/arch/x86/xen.lds.S
@@ -221,6 +221,12 @@ SECTIONS
        *(.initcall1.init)
        __initcall_end = .;
 
+       . = ALIGN(POINTER_ALIGN);
+       __initdata_cf_clobber_start = .;
+       *(.init.data.cf_clobber)
+       *(.init.rodata.cf_clobber)
+       __initdata_cf_clobber_end = .;
+
        *(.init.data)
        *(.init.data.rel)
        *(.init.data.rel.*)
diff --git a/xen/include/xen/init.h b/xen/include/xen/init.h
index bfe789e93f6b..0af0e234ec80 100644
--- a/xen/include/xen/init.h
+++ b/xen/include/xen/init.h
@@ -18,6 +18,9 @@
 #define __init_call(lvl)  __used_section(".initcall" lvl ".init")
 #define __exit_call       __used_section(".exitcall.exit")
 
+#define __initdata_cf_clobber  __section(".init.data.cf_clobber")
+#define __initconst_cf_clobber __section(".init.rodata.cf_clobber")
+
 /* These macros are used to mark some functions or 
  * initialized data (doesn't apply to uninitialized data)
  * as `initialization' functions. The kernel can take this
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 12:57:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 12:57:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271585.466131 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJauc-0003IP-U1; Mon, 14 Feb 2022 12:57:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271585.466131; Mon, 14 Feb 2022 12:57:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJauc-0003Fg-JS; Mon, 14 Feb 2022 12:57:02 +0000
Received: by outflank-mailman (input) for mailman id 271585;
 Mon, 14 Feb 2022 12:57:01 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJaua-0001Wb-Tu
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 12:57:01 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 95738935-8d95-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 13:56:55 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 95738935-8d95-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644843416;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=bS6U6dpS0uCHmyTfyvV11KW0uKIoo2qJ/wueBOXPivk=;
  b=A6REouaRBDkRyFwQwIO95HTAALUcEYrhICbPBWWG0Jlfg09Swj3zmvoC
   1VABM/sahF7VlpufIgpj/XrCneTchZoZJX4E40TNf2v7UykdVAtBZcq8o
   KQHi0Rqy373+oz0131T+8hiB5qby075h++3Dkfy/ml07lVlmzdCEWzR61
   w=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: DcILunBeCx6JLSKYMAN5Ejn1W6HEpA9UXxQC/kfaq2+bBy5/w2+cDsBLAX4KkGwAkMX0o9PKAR
 Bzf0W+y7J2bdy8v4TnIcTtrANOJceFf0MiXi8rxTIF/CO5wwSp7XlplHnpvd2P2oGBWbixXBwY
 paRC12Nqk103A5rHrfBv+ZxZ3CBzCVp2P8waxCfBA87xT6WYWrkREZcFOVigvSiz1ECi+1BFJt
 vgCd6GO4HmSfFFoI4q70yDuOG55chiPxTDq7Sj4lQSpxVsuFbf+0IltD6EaQpfazFFYhxMnpGV
 nhJTXpPc+fLmHwSpaAsw1U6h
X-SBRS: 5.1
X-MesageID: 64148583
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:XWXNLatFYQLeei+KE2WuiZmVb+fnVEhZMUV32f8akzHdYApBsoF/q
 tZmKWjUaP2CamLxeIx1bdu+9ksCvZbUxtI3TQpory9nFHlH+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZQP0VOZigHtIQMsadUsxKbVIiGHdJZS5LwbZj2NYy2IThWmthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 NplmKybGClqEYT3t6c9XgYDNz4lZJIX5+qSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DFYUToHx/ixreCu4rW8vrSKTW/95Imjw3g6iiGN6AO
 5NFOWc/N3wsZTVsMU0rLp95md6ToUD6fAEDgwq3/LcOtj27IAtZj+G2bYu9lsaxbdVYmAOUq
 3zL+0z9AwoGL5qPxDyd6HWui+TT2yThV+ov+KaQr6AwxgfJnypKVUNQBQDTTeSFZlCWduJ0e
 mJX1QMVgusS+VPwasamBiLpvyvR1vIDYOZ4H+o/4QCL76Pb5QeFG2QJJgJ8hMwaWNweHmJzi
 ALQ9z/9LXk26eDOFyrBnluBhW7qYUAowXk+iTjopOfvy/3qu8kNgx3GVb6P+4bl34SuSVkcL
 91nxRXSZon/b+ZWjc1XHnid2lpAQ6QlqSZvuG3qspqNtF8RWWJcT9XABaLnxfhBNp2FaVKKo
 WIJncOThMhXU83Ry3zdHbhVRerzjxpgDNE7qQQxd6TNChz3oyLzFWyuyG0WyLhV3jYsJmayP
 R67VfJ5755PJnq6BZKbkKrqY/nGOZPITIy/PtiNN4ImSsEoKGevoXE/DWbNjjuFuBV9zskC1
 WKzLJ/E4YAyUv88klJbho41jNcW+8zJ7T2PFM6rl0z9idJzphe9EN84DbdHVchhhIvsnekf2
 4w32xKix0oNXevgTDPQ9IJPf1kGIWJiXcL9qtBNd/7FKQ1jQTlzB/jUyLInWopkg6UKybuYo
 iDjAhdVmAjlmHnKCQSWcXQ/Ornhaoly8CAgNis2MFf2h3V6OdSz7L0SfoccdKU88LAx1uZ9S
 vQIIp3SAvlGRjnd1S4aaJ3x8N5reBix3FrcNCu5ejkvOZVnQlWRqNPjewLu8ggIDza26pRi8
 +HxiFuDTMNaFQp4DcvQZPa+9H+LvCAQyLBoQk/FAthPY0GwooJkHDP8060sKMYWJBSdmjbDj
 1SKAQ0VrPXmqpMu9IWbnriNqoqkHrcsHkdeGGWHv7+6OTODozimyI5EFu2JYSrcRCX//6D7P
 bdZyPT1MfsmmldWstUjT+Y3nPxmv9a/9aVHyglEHWnQawX5A7xtFXCKwM1Tu/Af3bReowa3B
 hqC99Qy1W9l4y85/Ir9/DYYU9k=
IronPort-HdrOrdr: A9a23:8a+lVqnTUB7VIruLicTU/0ogkSXpDfIo3DAbv31ZSRFFG/Fxl6
 iV/cjztCWE8Ar5N0tQ+uxoVJPufZqYz+8Q3WBzB8baYOCFghrLEGgK1+KLqFeMdxEWtNQtsp
 uIG5IObuEYZmIbsS+V2meF+q4bsby6zJw=
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="64148583"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v2 4/7] xsm: Use __initconst_cf_clobber for xsm_ops
Date: Mon, 14 Feb 2022 12:56:29 +0000
Message-ID: <20220214125632.24563-5-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125632.24563-1-andrew.cooper3@citrix.com>
References: <20220214125632.24563-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

All calls through xsm_ops are fully altcall'd.  Harden all fnptr targets.

This yields:

  (XEN) altcall: Optimised away 197 endbr64 instructions

of 1655 on an everything-enabled build of Xen, which is ~12%.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Daniel P. Smith <dpsmith@apertussolutions.com>
---
 xen/xsm/dummy.c       | 2 +-
 xen/xsm/flask/hooks.c | 2 +-
 xen/xsm/silo.c        | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/xen/xsm/dummy.c b/xen/xsm/dummy.c
index 4d29a9aa5b9f..8c044ef61500 100644
--- a/xen/xsm/dummy.c
+++ b/xen/xsm/dummy.c
@@ -13,7 +13,7 @@
 #define XSM_NO_WRAPPERS
 #include <xsm/dummy.h>
 
-static const struct xsm_ops __initconstrel dummy_ops = {
+static const struct xsm_ops __initconst_cf_clobber dummy_ops = {
     .security_domaininfo           = xsm_security_domaininfo,
     .domain_create                 = xsm_domain_create,
     .getdomaininfo                 = xsm_getdomaininfo,
diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c
index 63484e323c09..0bf63ffa84c4 100644
--- a/xen/xsm/flask/hooks.c
+++ b/xen/xsm/flask/hooks.c
@@ -1765,7 +1765,7 @@ static int cf_check flask_argo_send(
 
 #endif
 
-static const struct xsm_ops __initconstrel flask_ops = {
+static const struct xsm_ops __initconst_cf_clobber flask_ops = {
     .security_domaininfo = flask_security_domaininfo,
     .domain_create = flask_domain_create,
     .getdomaininfo = flask_getdomaininfo,
diff --git a/xen/xsm/silo.c b/xen/xsm/silo.c
index 4d5fc98e7e54..b89b36428784 100644
--- a/xen/xsm/silo.c
+++ b/xen/xsm/silo.c
@@ -102,7 +102,7 @@ static int cf_check silo_argo_send(
 
 #endif
 
-static const struct xsm_ops __initconstrel silo_xsm_ops = {
+static const struct xsm_ops __initconst_cf_clobber silo_xsm_ops = {
     .evtchn_unbound = silo_evtchn_unbound,
     .evtchn_interdomain = silo_evtchn_interdomain,
     .grant_mapref = silo_grant_mapref,
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 12:57:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 12:57:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271613.466147 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJaux-0005fF-85; Mon, 14 Feb 2022 12:57:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271613.466147; Mon, 14 Feb 2022 12:57:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJaux-0005f4-4w; Mon, 14 Feb 2022 12:57:23 +0000
Received: by outflank-mailman (input) for mailman id 271613;
 Mon, 14 Feb 2022 12:57:21 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KkXt=S5=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nJauv-0004Ma-EA
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 12:57:21 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a4f4b743-8d95-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 13:57:20 +0100 (CET)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2111.outbound.protection.outlook.com [104.47.17.111]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-41-YXPeW93cNOGkLQFBmqLdxg-1; Mon, 14 Feb 2022 13:57:18 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AS8PR04MB8183.eurprd04.prod.outlook.com (2603:10a6:20b:3f1::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.18; Mon, 14 Feb
 2022 12:57:16 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4975.015; Mon, 14 Feb 2022
 12:57:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a4f4b743-8d95-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644843439;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=croPqHmKXJWdBJGLCGtqbEztezFkGS/M7os30l5spW0=;
	b=FjA+UZHp2F1untA78c1Hvz5VHN0v2lpIDc5k/TBGOpjJtaRv8uhsvItvxfcl34FEvSBWvz
	LjXtAONcJxJAGhaucM01Q701/aM5/p2RLcBcaCaVSRbGlmbo5EZ+WVpY72ahM1teHE3Ez4
	5zsCAc8s3vvZS+1lR+4UQBMIUdot8Fs=
X-MC-Unique: YXPeW93cNOGkLQFBmqLdxg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=TCzn+Mvln+ELbUwR400W/fGkwfyJjziEWdTikok9J6SBH+ctjJLurXhnDFxLrAv6ZWAgaUY5wJRWkYRU3+x+cKgpxATrP26hpskluWozaIL87k9mzaG710fgWAr5FIy+f2aLMYzmiBNtdCISvuQCxV2LjZ+HQtwiFifWiOdXYG6mjGsi3JOGJvg/0rFq3QC9rtJ+Kg52Hrdjrrm32d/f49HJVzXAduUDLnoWJYOBMgAwghZLSnGA9EzhWRqGWYHoDTcBTJXp6U2bTeE++sapUm1C11mka8RRaIxSE8YGJ8t5yp6+dVLJJ058ch2bZal+AiIJMZCP+6uWF+PEvzEH/A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=5yPHLHgmeOQcF1O/ZYWrADpmncFcloF/qTgxcvIwOCM=;
 b=MXjCfKYTNWyxXqB2jtOtpEZ2VEZ9HCiVYdWb76sJzT50s9hQsqV4SgCqoR2xGmLxN+Kne+sj3yVw+hOLbbDPR2tkSUkM/FrE9ZS+tzBI2jjXXedeDDwn30wwfZ2SUzOfh9WDjkPPjoq/5zcLfKJ0wchkM5btXTSKVq3MLUUxeoapfyqO98QUPXYl/UvPXaZ//C20eyvRvQYte+Dfwt5W6wQh4F3gisAaJphVxd3lzX7YRT9piqqphSlGKTSTOML4OV3OdS3WPra07+7EtfrzTr6bClN50/PP5tT09XM0N3VAAUaufaKrm3ia7dW0zQpfB++JfzQX15x79z6wBoFtbg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <06baf0c8-d7d2-50b8-ea8f-1d422ceac728@suse.com>
Date: Mon, 14 Feb 2022 13:57:13 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH] vpci: introduce per-domain lock to protect vpci structure
Content-Language: en-US
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "julien@xen.org" <julien@xen.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Artem Mygaiev <Artem_Mygaiev@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>
References: <20220209133627.959649-1-andr2000@gmail.com>
 <YgU6Snk8GTytJXZp@Air-de-Roger>
 <c4666570-666e-6680-5ec2-adf1da51ad06@epam.com>
 <YgZLEMW9US9QjjYG@Air-de-Roger>
 <33fb1095-64ed-29ef-ba6b-cbde21d941f8@epam.com>
 <YgowIg5MvTaf2zsR@Air-de-Roger>
 <d8389a90-00c8-b34a-8488-b0f3fc5bde1b@epam.com>
 <Ygo40L4dMPJjZKRF@Air-de-Roger>
 <746860aa-c403-1eca-0a75-587c5d10c8c2@epam.com>
 <Ygo8M3Y6BLzljn15@Air-de-Roger>
 <114b8578-ee13-b67d-e282-d060187ef509@epam.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <114b8578-ee13-b67d-e282-d060187ef509@epam.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6P193CA0131.EURP193.PROD.OUTLOOK.COM
 (2603:10a6:209:85::36) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 82237423-8b43-41af-7945-08d9efb986cb
X-MS-TrafficTypeDiagnostic: AS8PR04MB8183:EE_
X-Microsoft-Antispam-PRVS:
	<AS8PR04MB8183CC71CA56D4AD68BC0A06B3339@AS8PR04MB8183.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Or3ANhP0D4E4oj+e3j+KW+BfG5asaVJpSbb1FcyEOQ6drfJ7vOqliX0oYnSEphgtxlU4D0hba1g/NDZ23AOvMLTklL9RgwKpNFc8dRwmjV7P5HtWj26rn+EBWC7Z+L7Isjp7SAFgvnbdhzMaWnZkBWPj+6QqtMVJ8JIM4xCuur/+xNbmOdH6IVVdY6edz5rkk629p9MpJ0xHt9Ljhq969f8R/cOzvPg2xgovKMd7Xq/XWYM0z+bHzaX5qeQBvoPEVF7ymLHWuMgvjdzShsVqTkA7opHC7HuDh8lLz8PsfPeltrzokmtsq1Eulyf4/J5L35VD9DdR48qTx/INJhyedN4lx5X9rNCbvlnSjvA7nNHk3z6+qzQeAWGeTJRm1MK5n3KPZ3DvSkxyViTGTVa1RQTQgcqDvmmTo2Ou1troNy1opgTjRSRnGPkYHUlt/mRIcknEp1JhIe4Com5FHdkFm8hUwqMBpqbTyWzchIUUi9tUp9WP4snNpeTGVFsoQ0zApqbDl/SsWjhNCDhboZIILRz26odFhZgsL5m5puW5A8DXIvwbijrAvxDe8eC3f4Pondpx1ADRSYqS/T0ZMYWEVTVl0OmQEoAskWFZ7UXxf+flKmYPh598cbYKzT24jiPHDBgBNRowHSvXm71gUsKzhP1Beh1RmPOWeDj39kc3T0Dq+ERu+fMfNd9cHsrhxs3sefx3CuFqX7/HvdsUGK7L76h1/eM0R/fYMufs0XIIbaR0Ziw+EnK3BktCpaj+ay/Z
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6512007)(186003)(54906003)(6916009)(26005)(316002)(6506007)(6666004)(2616005)(53546011)(6486002)(83380400001)(86362001)(31696002)(2906002)(7416002)(5660300002)(8936002)(31686004)(508600001)(38100700002)(66556008)(66946007)(66476007)(8676002)(4326008)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?7gZusnAPAUt0tTHsfi0Fgg6OKWOjGIuMQ9NnsTRr4YmRF96LUU/UteSfzf9O?=
 =?us-ascii?Q?j9YGVmGPOz2QoM9GnJZSx/EtWvGDAvFmt0azVJfVbs6O0qInCywuX6VciZuk?=
 =?us-ascii?Q?x5ZMpkucoYEm2W+tLaSSq2i7xBJrRbfAov0P2jes3sb+vNw9kO2V0fg2f48m?=
 =?us-ascii?Q?5YGLjGT+h6p9GCW20MJBRkSwe86Uncdn3TaFJ6/HwhNHrqZIuc5ENGmhpmc3?=
 =?us-ascii?Q?RRqLfuI+co6KDK+Za0aGTh9YZdK1wTpsuS6dnrUASGxAAwVHk319lukMZ0fO?=
 =?us-ascii?Q?6EPm3dOhR257xe0S83CgVT0vzEPDW6uikZutjWMRLMpWxH+PzWD6OPc6PSju?=
 =?us-ascii?Q?DZYJqfYcrbzsomMBf/EhCcxf6cCb4KVDy+b0p3qxlVux1v3XnNcDGHrWwHKd?=
 =?us-ascii?Q?wFRugPGmcbB6ICJBmtnpnLmjHT3FuogUuWMJlRGcErmZMC/7Sqlc2CBtAFrG?=
 =?us-ascii?Q?3yWPSbwkoTcMzKDZ9r5LlD0lY4x69DRqjT/IUED7nvIaOvgC4wqBjFdE90HO?=
 =?us-ascii?Q?c7g2XTMuk2gwF/26YqiIhT74ivyYifoSJOnxws3Ty1civWLt7fe1wPog5JxG?=
 =?us-ascii?Q?PWfmHevOiK8Jg6ZnmaVKrML4VyJhBikbQZQ8y9CzRtxBS1PYZ7xld4F/dr86?=
 =?us-ascii?Q?jQ9omm7R5KtCBWKCahkF8Uo73HtHwSCzMMPnvzWdIUO2b0agyrsEOhnfq5jK?=
 =?us-ascii?Q?IyyDVeBKYgX8SWr9lArClEQFOukhMO0KcjmLq5oU+dR8q7tnIh8QLRvaFotm?=
 =?us-ascii?Q?yiPHjqs2ZpnPa790wXzEiqtS3mqnoenSakrJFt01I5NIBMfC/Aw3XClJEDZ2?=
 =?us-ascii?Q?1UjFqSlwjnx6MSkr5z8OaiCa+NVylxBM6xoYG2RC/wJXRofPIGQsTmFXCJhB?=
 =?us-ascii?Q?Fuck13HSrNjMpD1B5BoUoOPyWezz6Ly8N1CdToKFSy5al4p3jgOUtMz5+x3N?=
 =?us-ascii?Q?X8RP8wxelnGGhHEtz/zx7AfRVmL8u2rr2kvpx9MyABfhP23AQRKx4xyGgWUx?=
 =?us-ascii?Q?XEaTXhdWY7z0ureYZL38gvtq98HlNQVunjfq7SWbJxUfVY82V2ieFFisgOcg?=
 =?us-ascii?Q?F1POaXHyEhsSqiwOrgrmSLpMsBrnEkNI+Csjmedpp/OqYBHXl3aMVs8GI+Ii?=
 =?us-ascii?Q?4arzqLTECugMLZ0lZrQc1JbyeXZwRDuE7UcejuWnfHFMzLZdCTB5Z59D/a7c?=
 =?us-ascii?Q?EhKM9apVdRIvP0ByhqBEXxRUcNR0uYASUCw6AEcOQr7hCcSR5uLyebKcDAKt?=
 =?us-ascii?Q?kzbBeIJ7aLPL5XYnkYpPtX8pzhUogHybl3yQn6f1ag88m2u/xAViuJlet8ja?=
 =?us-ascii?Q?dXTu9AzLGpoxAIINrNPGpBkT8eq3eAu+vZwB0860mIwZONwMYZnnpYZG1Lj8?=
 =?us-ascii?Q?xvkxiDnuCgYfhq3dXPFq1FB11c0e8HxVOG7sghUuDR06NbWbvTY8flqqH/U5?=
 =?us-ascii?Q?dUL7Ctt+p0wJXKf9o3kNVgWFcb6nVAWxSmxBw/H49DBpCFQRScSYmTNchW3t?=
 =?us-ascii?Q?duetJGWrt6lFDB+Gyxp9SrQWjW7XonXVYMvf4aOZfaQVsrC6kfq65NEchAAQ?=
 =?us-ascii?Q?unzeBZsH+6q91g4tMsbOFXOhB+1zHML5BiZmRFxuopfl8sydruVsYl+ru7Ix?=
 =?us-ascii?Q?tbTwKSX224sYxhFv46xWTmM=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 82237423-8b43-41af-7945-08d9efb986cb
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2022 12:57:16.0355
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: H8lA6UntAG0fy3qsM/na8imahqxtTXCutq0lFO1/k9OskK8bnU/R4lOdQprEr+NQSBNBJGWOHpxHZzX8FdhZhg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8183

On 14.02.2022 12:37, Oleksandr Andrushchenko wrote:
>=20
>=20
> On 14.02.22 13:25, Roger Pau Monn=C3=A9 wrote:
>> On Mon, Feb 14, 2022 at 11:15:27AM +0000, Oleksandr Andrushchenko wrote:
>>>
>>> On 14.02.22 13:11, Roger Pau Monn=C3=A9 wrote:
>>>> On Mon, Feb 14, 2022 at 10:53:43AM +0000, Oleksandr Andrushchenko wrot=
e:
>>>>> On 14.02.22 12:34, Roger Pau Monn=C3=A9 wrote:
>>>>>> On Mon, Feb 14, 2022 at 09:36:39AM +0000, Oleksandr Andrushchenko wr=
ote:
>>>>>>> On 11.02.22 13:40, Roger Pau Monn=C3=A9 wrote:
>>>>>>>> +
>>>>>>>>>>>           for ( i =3D 0; i < msix->max_entries; i++ )
>>>>>>>>>>>           {
>>>>>>>>>>>               const struct vpci_msix_entry *entry =3D &msix->en=
tries[i];
>>>>>>>>>> Since this function is now called with the per-domain rwlock rea=
d
>>>>>>>>>> locked it's likely not appropriate to call process_pending_softi=
rqs
>>>>>>>>>> while holding such lock (check below).
>>>>>>>>> You are right, as it is possible that:
>>>>>>>>>
>>>>>>>>> process_pending_softirqs -> vpci_process_pending -> read_lock
>>>>>>>>>
>>>>>>>>> Even more, vpci_process_pending may also
>>>>>>>>>
>>>>>>>>> read_unlock -> vpci_remove_device -> write_lock
>>>>>>>>>
>>>>>>>>> in its error path. So, any invocation of process_pending_softirqs
>>>>>>>>> must not hold d->vpci_rwlock at least.
>>>>>>>>>
>>>>>>>>> And also we need to check that pdev->vpci was not removed
>>>>>>>>> in between or *re-created*
>>>>>>>>>> We will likely need to re-iterate over the list of pdevs assigne=
d to
>>>>>>>>>> the domain and assert that the pdev is still assigned to the sam=
e
>>>>>>>>>> domain.
>>>>>>>>> So, do you mean a pattern like the below should be used at all
>>>>>>>>> places where we need to call process_pending_softirqs?
>>>>>>>>>
>>>>>>>>> read_unlock
>>>>>>>>> process_pending_softirqs
>>>>>>>>> read_lock
>>>>>>>>> pdev =3D pci_get_pdev_by_domain(d, sbdf.seg, sbdf.bus, sbdf.devfn=
);
>>>>>>>>> if ( pdev && pdev->vpci && is_the_same_vpci(pdev->vpci) )
>>>>>>>>> <continue processing>
>>>>>>>> Something along those lines. You likely need to continue iterate u=
sing
>>>>>>>> for_each_pdev.
>>>>>>> How do we tell if pdev->vpci is the same? Jan has already brought
>>>>>>> this question before [1] and I was about to use some ID for that pu=
rpose:
>>>>>>> pdev->vpci->id =3D d->vpci_id++ and then we use pdev->vpci->id=C2=
=A0 for checks
>>>>>> Given this is a debug message I would be OK with just doing the
>>>>>> minimal checks to prevent Xen from crashing (ie: pdev->vpci exists)
>>>>>> and that the resume MSI entry is not past the current limit. Otherwi=
se
>>>>>> just print a message and move on to the next device.
>>>>> Agree, I see no big issue (probably) if we are not able to print
>>>>>
>>>>> How about this one:
>>>>>
>>>>> diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c
>>>>> index 809a6b4773e1..50373f04da82 100644
>>>>> --- a/xen/drivers/vpci/header.c
>>>>> +++ b/xen/drivers/vpci/header.c
>>>>> @@ -171,10 +171,31 @@ static int __init apply_map(struct domain *d, c=
onst struct pci_dev *pdev,
>>>>>    =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0 struct rangeset *mem, uint16_t cmd)
>>>>>    =C2=A0{
>>>>>    =C2=A0=C2=A0=C2=A0=C2=A0 struct map_data data =3D { .d =3D d, .map=
 =3D true };
>>>>> +=C2=A0=C2=A0=C2=A0 pci_sbdf_t sbdf =3D pdev->sbdf;
>>>>>    =C2=A0=C2=A0=C2=A0=C2=A0 int rc;
>>>>>
>>>>> + ASSERT(rw_is_write_locked(&pdev->domain->vpci_rwlock));
>>>>> +
>>>>>    =C2=A0=C2=A0=C2=A0=C2=A0 while ( (rc =3D rangeset_consume_ranges(m=
em, map_range, &data)) =3D=3D -ERESTART )
>>>>> +=C2=A0=C2=A0=C2=A0 {
>>>>> +
>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 /*
>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * process_pending_s=
oftirqs may trigger vpci_process_pending which
>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * may need to acqui=
re pdev->domain->vpci_rwlock in read mode.
>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 */
>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 write_unlock(&pdev->domai=
n->vpci_rwlock);
>>>>>    =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 process_pending_s=
oftirqs();
>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 write_lock(&pdev->domain-=
>vpci_rwlock);
>>>>> +
>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 /* Check if pdev still ex=
ists and vPCI was not removed or re-created. */
>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (pci_get_pdev_by_domai=
n(d, sbdf.seg, sbdf.bus, sbdf.devfn) !=3D pdev)
>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 i=
f ( vpci is NOT the same )
>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 {
>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0 rc =3D 0;
>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0 break;
>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 }
>>>>> +=C2=A0=C2=A0=C2=A0 }
>>>>> +
>>>>>    =C2=A0=C2=A0=C2=A0=C2=A0 rangeset_destroy(mem);
>>>>>    =C2=A0=C2=A0=C2=A0=C2=A0 if ( !rc )
>>>>>    =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 modify_decoding(p=
dev, cmd, false);
>>>>>
>>>>> This one also wants process_pending_softirqs to run so it *might*
>>>>> want pdev and vpci checks. But at the same time apply_map runs
>>>>> at ( system_state < SYS_STATE_active ), so defer_map won't be
>>>>> running yet, thus no vpci_process_pending is possible yet (in terms
>>>>> it has something to do yet). So, I think we just need:
>>>>>
>>>>>    =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 write_unlock(&pdev->dom=
ain->vpci_rwlock);
>>>>>    =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 process_pending_softirq=
s();
>>>>>    =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 write_lock(&pdev->domai=
n->vpci_rwlock);
>>>>>
>>>>> and this should be enough
>>>> Given the context apply_map is called from (dom0 specific init code),
>>>> there's no need to check for the pdev to still exits, or whether vpci
>>>> has been recreated, as it's not possible. Just add a comment to
>>>> explicitly note that the context of the function is special, and thus
>>>> there's no possibility of either the device or vpci going away.
>>> Does it really need write_unlock/write_lock given the context?...
>> I think it's bad practice to call process_pending_softirqs while
>> holding any locks. This is a very specific context so it's likely fine
>> to not drop the lock, but would still seem incorrect to me.
> Ok
>>
>>> I think it doesn't as there is no chance defer_map is called, thus
>>> process_pending_softirqs -> vpci_process_pending -> read_lock
>> Indeed, there's no chance of that because process_pending_softirqs
>> will never try to do a scheduling operation that would result in our
>> context being scheduled out.
>=20
>  =C2=A0=C2=A0=C2=A0 while ( (rc =3D rangeset_consume_ranges(mem, map_rang=
e, &data)) =3D=3D -ERESTART )
>  =C2=A0=C2=A0=C2=A0 {
>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 /*
>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * FIXME: Given the cont=
ext apply_map is called from (dom0 specific
>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * init code at system_s=
tate < SYS_STATE_active) it is not strictly
>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * required that pdev->d=
omain->vpci_rwlock is unlocked before calling
>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * process_pending_softi=
rqs as there is no contention possible between
>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * this code and vpci_pr=
ocess_pending trying to acquire the lock in
>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * read mode. But runnin=
g process_pending_softirqs with any lock held
>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * doesn't seem to be a =
good practice, so drop the lock and re-acquire
>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * it right again.
>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 */
>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 write_unlock(&pdev->domain->v=
pci_rwlock);
>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 process_pending_softirqs();
>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 write_lock(&pdev->domain->vpc=
i_rwlock);
>  =C2=A0=C2=A0=C2=A0 }

I'm afraid that's misleading at best. apply_map() is merely a specific
example where you know the lock is going to be taken. But really any
softirq handler could be acquiring any lock, so requesting to process
softirqs cannot ever be done with any lock held.

What you instead want to explain is why, after re-acquiring the lock,
no further checking is needed for potentially changed state.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 12:59:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 12:59:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271634.466158 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJawu-0006sg-QS; Mon, 14 Feb 2022 12:59:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271634.466158; Mon, 14 Feb 2022 12:59:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJawu-0006sZ-NX; Mon, 14 Feb 2022 12:59:24 +0000
Received: by outflank-mailman (input) for mailman id 271634;
 Mon, 14 Feb 2022 12:59:23 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KkXt=S5=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nJawt-0006sS-IB
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 12:59:23 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ed89f031-8d95-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 13:59:21 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2056.outbound.protection.outlook.com [104.47.14.56]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-22-adn154O8M-ORJoEuBFYa2Q-1; Mon, 14 Feb 2022 13:59:21 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by PAXPR04MB8512.eurprd04.prod.outlook.com (2603:10a6:102:213::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.18; Mon, 14 Feb
 2022 12:59:20 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4975.015; Mon, 14 Feb 2022
 12:59:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ed89f031-8d95-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644843562;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=X0wny9rGsDyi/pLZC6T6iOoE4NQKliZ707q0O8m//uU=;
	b=PiAx8z4KTyFbGP7Rf3MamQ5N7aoepA9cyefy9XZuyGxbGYgnpuJFPxrxPMDU312UfMMy1U
	Kv7thJCERZiVj7J43NoMGdsv9su3aF9V2qLFAO4fQ9yz7JEWHz6E+o8eCRSVa+psXSMkMj
	wU4/ayGq4ag85PogHCCiHIkCnAoyOOM=
X-MC-Unique: adn154O8M-ORJoEuBFYa2Q-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=lV/AE7EMsslhksehNMaT4gl01t+umjXrk+FnXYyZDRwtXrpftc74Ywjtt0u3YtWBEP3M0YCZnucIEGIM2Q5NBbj+2pvMvUXSQ4Kbpcug6m7Sgw6RxjyuQSZyUPK/lIwAYo0lzZnoRFvE2xaQlHI+6yLITrAjypgAhuLQojsNqy/JxxGYuSBnejxAMwPLScyVlld8vqdMPbXm175EDm2X5dt8MLeHnzd7D3wcyiASxvbKZU3Xp4qpuCMRu9UW3IsEjt2RoowFHmbWUkYSUkaMFFcs350FBU4nzTylGSGxc6V3mjZ/1ntl/MJQdV9Hqdws7zIz/t2Dz8dU8+G3Sg3wfA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=X0wny9rGsDyi/pLZC6T6iOoE4NQKliZ707q0O8m//uU=;
 b=Gz+0zfgmR3CKww46BCFRWsln6Ez2+XxuxulukSsfkDN7mnZltjd7n2nXLW/2Bx0jzeA5Tnr39MrA7c66Xmy4XV1fhH5qc5B4HJLVqdI80hnP1CPILMjemAXHeemW/TgaAQQYr+ZhjueFhElPTSWsaRTsNgPWQn+SBayTHVE8+gTITBa2fdu0PguuAeOiRZQewHP9mFom45yTCxFCZUqCohVXXrgObzBUpUoELz/y4kHDf6Y+KWxY1j6eWIdw8xlTRh43tLa+rvans4in6M60cSWw9HtgkN9MmwEo6q5jvii+xXZSS6N7hGoMR04vCXfz0NcnwPmqfUbskXacmcj1Bg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <cecc3dd4-47cc-6f6e-177c-4e8657d2cd6d@suse.com>
Date: Mon, 14 Feb 2022 13:59:17 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH v2 1/7] xen/altcall: Use __ro_after_init now that it
 exists
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20220214125632.24563-1-andrew.cooper3@citrix.com>
 <20220214125632.24563-2-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220214125632.24563-2-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8P250CA0004.EURP250.PROD.OUTLOOK.COM
 (2603:10a6:20b:330::9) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7a15a462-08a0-46ef-5bb8-08d9efb9d09b
X-MS-TrafficTypeDiagnostic: PAXPR04MB8512:EE_
X-Microsoft-Antispam-PRVS:
	<PAXPR04MB851236A6AF6E81D3EC96C186B3339@PAXPR04MB8512.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1122;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ofYGCBG2vSgQPoUC5WNYpq1vmnpIKd2hwXUtHmnzfEID5jWYSmEoUcONZSuY2WkQZpAXxZ/rWsy8k3eJlREmPJFgYe3mtDAg0+uasF1oFr+Kahk4DSWHpYWJyjB22TntOhYdYl92PQj4BFaSk9Eo3lD5aKTK8if47igpRYxDGE4iDzouXKLfPqTq5tEj3ThGA25GXoY27x+qDw6RBUCmlvqfcAZGavWJEhyqD5hWtOssVP5pVm6f9kAV1yhPshpn82fnIJOrnCTQCsKop587rKVbPhZDNceXT1+pxLGafolQu2qL6Gp16hbFcA5neH8DZ/M9eXy9rahemwgfB06vSmTJVkn9UhSRY6SqxkQsEzHd/N55nVjzvW1J/dyJ22NZymc6Jc6VcuemFu987qVXxSjXuMWX9IHgGvZQUWoZywc9gzLVGEQQZPLLqaSf8Qf7hWp5/PQjwWYrvY9E+Xj+mlb8Hl7qBxBVXTx+oaSPwkk9tp/0gVTMfmsa4zhunZRWv0iYT6CqI9XvKghYx8jWD0CRifThzXqh74FANKWCv0VJoRlquHv//hkG0Ub60rRCjlfwl4l/MYePAAcCWAUOTuaUxis6qszRauqTwOIj25/oQBGhAGdXVzwIHLvLcFtzRFqF7Rejq3VRuhL8+cXTC5v+1x54Y3WS/fB3J7jkFbnEPRl6+z0LQhuPg1XwYQKECv3uyf1WdOV6vQmYUT/sq64Gfn7B4RPd40YfgxWLucq6WZgEf3suzVG0haZT7Xk5
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2906002)(508600001)(6666004)(5660300002)(4326008)(6486002)(38100700002)(6512007)(8936002)(6506007)(66946007)(66556008)(53546011)(558084003)(66476007)(8676002)(26005)(186003)(54906003)(6916009)(31686004)(86362001)(2616005)(31696002)(316002)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dFZoTWYwb1RDbnpjOUY5ZlE0aXJvdHRtR3Rrb3B2MUdKSENuTzU3T3UzWjFF?=
 =?utf-8?B?amRYTmNnQzRybXBGR3ovRk01QndtTGtMazZXNDVnbmgxM2hybmwwcWcySkpi?=
 =?utf-8?B?dW5NczZZRkN6OUYxeXVZaVBMOTFwZlR1akc3OHIwRTJ1SEFyb3BKb3lqbnBr?=
 =?utf-8?B?QncyZ2ZjS0tNWVhuMmV6TFphQUVSMWFsM2ZPVHdEU2VJR3ZDMzJFUk1jOEhB?=
 =?utf-8?B?QTUzOHRwVENTMGg2UGJzN0RnOGZ4VFBkRDNVQUk0N2g1RzBxZWFaZk5pQ2J2?=
 =?utf-8?B?bUNJdGJmZFhQejViY01CL2ZsR21ZMFlTSW55RXh3K0JVTzdBYWttRFhreVFY?=
 =?utf-8?B?dE5DZkk5dndtNk4rRG9aYWJtbmJtQ25uTWZDZXN2S2s5Kzd5UHpIclNmeEJw?=
 =?utf-8?B?ZURPOGRqbmNNK05URWpRZDFUR0tvSHpKbmZpTTFtRDd2U3dSaWJOMjF5RXhH?=
 =?utf-8?B?b0ZOYmhVbnFRbXFPNjdraHM4Tk40WUtBcUxibERUcDJtbVNKZVVsbmpxUzJy?=
 =?utf-8?B?YTdDaE5DNm5manRQK2xWdmkzUEk4cEV6RWpINks1c3ZLZ0NlbmJRYkFFWFV2?=
 =?utf-8?B?Uk5lN041TURESXo5Rndrc3cweXpOTjR2emczMzNzSkNlRGhlbm9NVEo4NGUr?=
 =?utf-8?B?UDR3WnMxdXRja2NiSnc2djMvbEdvTUVyYWxURXdkait6T3ZhRzBhbHhubEVW?=
 =?utf-8?B?a3dEQ0s4WG5tWEtsc2t2UUVjczhyekpwSGUyQ1RsdUFJa2tIaVc3UlkzbUV3?=
 =?utf-8?B?YTBzaGJ4dHhZSkE5dGpYSFZXSHFWOGM2bTNMek5kTkR6c0xOMGxUU2Izc2E0?=
 =?utf-8?B?V3pLanBlYWE1a1JtZ1NGQXIwYUVzWmhEQ0NjV2JGU1RLMTV5Tlp5OVNaNXRt?=
 =?utf-8?B?NFNiNlRqcHk5NkQzNWhXMU4rYXhRQzVOVWNYK1lqSzcyM1crZnRNbTlIN2hW?=
 =?utf-8?B?dHpwUmkzWGp2RklHVUJEamhERHF1MzVvYXdLTm96OXFCS2ZXZDhqYzNIMGdD?=
 =?utf-8?B?RkxjOXNNMUJlcSs3ckxESmZ0RHJhZFVXVXhKRzk4ZXR5ZlhaQ0RndjE4Z3N4?=
 =?utf-8?B?c3Brb2JtRk05ZjZKR3ErTGRaaTh6M0hBYjRUTy9uS2lDMFJOMVJEdllrUVVF?=
 =?utf-8?B?OWlMbWVRb2ozcFlONU1KeGZwam5udm5pZVV0dGFsYmxEN0ovTXhVaVQ2UTQw?=
 =?utf-8?B?KzZodFY0allTQnB2SzBaWUoybnl0eU5PV3l2Y21sS0EydWh0UENKaGhaSSto?=
 =?utf-8?B?eFpTUEFtSDJQWHZZay9HVnVnaG52YWQ2NVMxOFUvZHZYcDZuQkFrVGp0OU03?=
 =?utf-8?B?b0QwczFwQnpsTUtJMU9aSnRiVkJLU1E1eTJYY3VWYTA4SGUrQktXcU5ENndJ?=
 =?utf-8?B?TFVBZzZ2cXJKVFF0NFNLVUlhbThMampLRWMvOE9qSG5PNUlzNytLaTdBL3lG?=
 =?utf-8?B?RXQ5TE9hOVpITUVSNU9ZS1p2bGpHVVVxdUUvZlU3UXh1OERpd3VJL1V6dHlB?=
 =?utf-8?B?ZkY3MkQreUlSejMyZSszTjcxSXRjdlJoZUNiNjhHK0Y2NlNYZWdxNXhNWTVS?=
 =?utf-8?B?K2prMTl4WUh1MFM0VERHSUVmZWxTeTBCZkNreVdBZnpFbDV0K1FYREtaeXlh?=
 =?utf-8?B?Q1RsVUxaQnR4MGJkZXVBU3FwMkNIV0ZwTHF3bXRZN3NlOCtYc3NrZUEwUU41?=
 =?utf-8?B?YWJya29hRnlpMURobmxLSHB1NVpKRE5FU094dTlkczZJdlZzdkQ2TTFIVUZY?=
 =?utf-8?B?dCs0dzZEcjFyNXJ1Q2lnQllRNTd0eVFMQ3dqK0M4dmJSZ1pkYkh1RU1yMTBJ?=
 =?utf-8?B?NUFDblZ2U2syUjJDT1NqLzArUFNEa2F5aktVdURNcm1xL3BsdFZjQ3FVcE91?=
 =?utf-8?B?M3RTRnhsVGoydmNPbTh3cWVhNmRlSU9xZTkzcGxrOHI2bGNJSzJRV1o3NjJz?=
 =?utf-8?B?alBQMGt1V2FicFNXZndEOFc0Wm15RTlpaGMweXNkZnN6M3QvMW40SGRPUzFp?=
 =?utf-8?B?b0lMSFFpWDBoSHVEUDUzSk14bk1YTjhod3BHSnZxOHRCUEZkZ1RJRTJuR1lN?=
 =?utf-8?B?Ky9MMEp5YVZIaitlYVZjQWpjUUpFWGdiUzFSQWxlWGsvNktNZmdHdVE3MmRh?=
 =?utf-8?B?OTJvNytGKzU3M2JVSWh0eFF1bHoxVjl2K2JMLzhDSVBrNnJPdDFla0Q0eml4?=
 =?utf-8?Q?Mev2OF4FZNCE8NNJUtgwzA8=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7a15a462-08a0-46ef-5bb8-08d9efb9d09b
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2022 12:59:19.9341
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jdkEGYvAhP1xj/yuBwKxgLvvdpwWgAq6J8FCBjldMpws5jr7tYvqsEjy5T/q0J4inunQZtCbn2Infrz2IBw3sQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8512

On 14.02.2022 13:56, Andrew Cooper wrote:
> For the !CONFIG_ALTERNATIVE_CALL case, the use of __read_mostly was only a
> stopgap while nothing better existed.  __ro_after_init now does, so it use.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Acked-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:04:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:04:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271641.466169 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb26-0008IU-En; Mon, 14 Feb 2022 13:04:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271641.466169; Mon, 14 Feb 2022 13:04:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb26-0008IN-Bm; Mon, 14 Feb 2022 13:04:46 +0000
Received: by outflank-mailman (input) for mailman id 271641;
 Mon, 14 Feb 2022 13:04:45 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJb25-0008IH-3o
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:04:45 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ab3fc353-8d96-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 14:04:41 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ab3fc353-8d96-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644843881;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=9SBKCVUVoHZcNlwGQnO2XD67JHVChjedlbYxSb50LOk=;
  b=eBPHaNCZ6xkpzoqdSSp9ZWbW/RYWnI2qk3xncD9FmzoYsU8Xq2SyiO11
   QMfC6EQVum9eiK3uHEUXsYFHB3fq52/S+hD9MJAQKp24/SHGhSszzWhtX
   S4kv5/edDPmIuM6yFGp46QS3znWMR6AZMQl1nivEYfmjWUGY1orSIpo42
   Y=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: AgAiKrOfsWqmF2MNEfQDzVivIVdmtYdBCm7OfPoGIiWZxQaBsmyXuX8alQ+NOI5jMf6y9mJ9e8
 hj4BbNKMC7YR1fKmr4PuyvKmsJZ0AYtayqdDawFugkoMJDoJjB8Gjbo8zvji+iAL04OaZwmMWn
 b2BuuAJ4MZOL391mKq8zYZFi1Ja7B9f3/00AVsJOvVD7MuLvZzJb+3/0faVX/I99bjVSL36HoR
 C8eAlx+5hRGAdux6FBfxdsbF4ZUfm7wqTKJBEb3A1/8u8Asarxr8pE/h7vqWi6P6QX3XVRKGuc
 VJ6QKOpijtShA65p5e5a77Wk
X-SBRS: 5.1
X-MesageID: 64050477
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:80eQFqsR2Hxyzl3t7rds+EZjAefnVEhZMUV32f8akzHdYApBsoF/q
 tZmKWqHOPqPMWGkfY9zb9m+9koBsJLUzII2Ggpu/CFhES8W+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZQP0VOZigHtIQMsadUsxKbVIiGHdJZS5LwbZj2NYy2IThWmthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 Nplk7++TQwXF/z2gqcNQxN0OSQ9BYgX0eqSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DFYUToHx/ixreCu4rW8vrSKTW/95Imjw3g6iiGN6AO
 5JEMWYwM3wsZTVTAVolOqhkm9yvnyL1cWN+mFzIqvQotj27IAtZj+G2bYu9lsaxbdVYmAOUq
 3zL+0z9AwoGL5qPxDyd6HWui+TT2yThV+ov+KaQr6AwxgfJnypKVUNQBQDTTeSFZlCWffFRL
 0cq03sUt+si5EaHZNy+ZzjpiSvR1vIDYOZ4H+o/4QCL76Pb5QeFG2QJJgJ8hMwaWNweHmJzi
 ALQ9z/9LXk26eDOFyrBnluBhW7qYUAowXk+iTjopOfvy/3qu8kNgx3GVb6P+4bl34SuSVkcL
 91nxRXSZon/b+ZWjc1XHnid2lpAQ6QlqSZvuG3qspqNtF8RWWJcT9XABaLnxfhBNp2FaVKKo
 WIJncOThMhXU83Ry3zdHbhVRerzjxpgDNE7qQQxd6TNChz3oyLzFWyuyG0WyLhV3jYsJmayP
 R67VfJ5755PJnq6BZKbkKrqY/nGOZPITIy/PtiNN4ImSsEoKGevoXE/DWbNjjuFuBV9zskC1
 WKzLJ/E4YAyUv88klJbho41jNcW+8zJ7T2PFM6rl0z9idJzphe9EN84DbdHVchhhIvsnekf2
 4032xKix0oNXevgTDPQ9IJPf1kGIWJiXcL9qtBNd/7FKQ1jQTlzB/jUyLInWopkg6UKybuYo
 iDjAhdVmAjlmHnKCQSWcXQ/Ornhaoly8CAgNis2MFf2h3V6OdSz7L0SfoccdKU88LAx1uZ9S
 vQIIp3SAvlGRjnd1S4aaJ3x8N5reBix3FrcNCu5ejkvOZVnQlWRqNPjewLu8ggIDza26pRi8
 +HxiFuDTMNaFQp4DcvQZPa+9H+LvCAQyLBoQk/FAthPY0GwooJkHDP8060sKMYWJBSdmjbDj
 1SKAQ0VrPXmqpMu9IWbnriNqoqkHrcsHkdeGGWHv7+6OTODozimyI5EFu2JYSrcRCX//6D7P
 bdZyPT1MfsmmldWstUjT+Y3nPxmv9a/9aVHyglEHWnQawX5A7xtFXCKwM1Tu/Af3bReowa3B
 hqC99Qy1W9l4y85/Ir9/DYYU9k=
IronPort-HdrOrdr: A9a23:crUzMKxrAi9bksQpKGTXKrPwLr1zdoMgy1knxilNoRw8SKKlfq
 GV7Y0mPHDP6Ar5NEtNpTnEAtjkfZq+z+8S3WByB8bAYOCOggLBR+sO0WKh+UyFJ8SXzJ876U
 4KSclD4bPLYmSS9fyKgjWFLw==
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="64050477"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v2 32/70] x86/hvm: CFI hardening for hvm_funcs
Date: Mon, 14 Feb 2022 12:50:49 +0000
Message-ID: <20220214125127.17985-33-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

Control Flow Integrity schemes use toolchain and optionally hardware support
to help protect against call/jump/return oriented programming attacks.

Use cf_check to annotate function pointer targets for the toolchain.

In svm.c, make a few rearrangements.  svm_update_guest_cr() has no external
callers so can become static, but needs moving along with svm_fpu_enter() to
avoid a forward declaration.  Move svm_fpu_leave() too, to match.  Also move
svm_update_guest_efer() to drop its forward declaration.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
v2:
 * Move svm_fpu_leave() too.
---
 xen/arch/x86/hvm/svm/nestedsvm.c             |  22 +-
 xen/arch/x86/hvm/svm/svm.c                   | 390 ++++++++++++++-------------
 xen/arch/x86/hvm/vmx/intr.c                  |   2 +-
 xen/arch/x86/hvm/vmx/vmcs.c                  |   8 +-
 xen/arch/x86/hvm/vmx/vmx.c                   | 143 +++++-----
 xen/arch/x86/hvm/vmx/vvmx.c                  |  16 +-
 xen/arch/x86/include/asm/hvm/svm/nestedsvm.h |  18 +-
 xen/arch/x86/include/asm/hvm/svm/svm.h       |   1 -
 xen/arch/x86/include/asm/hvm/vmx/vmcs.h      |   8 +-
 xen/arch/x86/include/asm/hvm/vmx/vmx.h       |   2 +-
 xen/arch/x86/include/asm/hvm/vmx/vvmx.h      |  18 +-
 11 files changed, 320 insertions(+), 308 deletions(-)

diff --git a/xen/arch/x86/hvm/svm/nestedsvm.c b/xen/arch/x86/hvm/svm/nestedsvm.c
index abc178d8d482..9f5f35f16aff 100644
--- a/xen/arch/x86/hvm/svm/nestedsvm.c
+++ b/xen/arch/x86/hvm/svm/nestedsvm.c
@@ -80,7 +80,7 @@ int nestedsvm_vmcb_map(struct vcpu *v, uint64_t vmcbaddr)
 }
 
 /* Interface methods */
-int nsvm_vcpu_initialise(struct vcpu *v)
+int cf_check nsvm_vcpu_initialise(struct vcpu *v)
 {
     void *msrpm;
     struct nestedvcpu *nv = &vcpu_nestedhvm(v);
@@ -110,7 +110,7 @@ int nsvm_vcpu_initialise(struct vcpu *v)
     return -ENOMEM;
 }
 
-void nsvm_vcpu_destroy(struct vcpu *v)
+void cf_check nsvm_vcpu_destroy(struct vcpu *v)
 {
     struct nestedvcpu *nv = &vcpu_nestedhvm(v);
     struct nestedsvm *svm = &vcpu_nestedsvm(v);
@@ -150,7 +150,7 @@ void nsvm_vcpu_destroy(struct vcpu *v)
     svm->ns_iomap = NULL;
 }
 
-int nsvm_vcpu_reset(struct vcpu *v)
+int cf_check nsvm_vcpu_reset(struct vcpu *v)
 {
     struct nestedsvm *svm = &vcpu_nestedsvm(v);
 
@@ -855,8 +855,8 @@ nsvm_vcpu_vmexit_inject(struct vcpu *v, struct cpu_user_regs *regs,
     return 0;
 }
 
-int
-nsvm_vcpu_vmexit_event(struct vcpu *v, const struct x86_event *trap)
+int cf_check nsvm_vcpu_vmexit_event(
+    struct vcpu *v, const struct x86_event *trap)
 {
     ASSERT(vcpu_nestedhvm(v).nv_vvmcx != NULL);
 
@@ -865,7 +865,7 @@ nsvm_vcpu_vmexit_event(struct vcpu *v, const struct x86_event *trap)
     return NESTEDHVM_VMEXIT_DONE;
 }
 
-uint64_t nsvm_vcpu_hostcr3(struct vcpu *v)
+uint64_t cf_check nsvm_vcpu_hostcr3(struct vcpu *v)
 {
     return vcpu_nestedsvm(v).ns_vmcb_hostcr3;
 }
@@ -1030,8 +1030,7 @@ nsvm_vmcb_guest_intercepts_exitcode(struct vcpu *v,
     return 1;
 }
 
-bool_t
-nsvm_vmcb_guest_intercepts_event(
+bool cf_check nsvm_vmcb_guest_intercepts_event(
     struct vcpu *v, unsigned int vector, int errcode)
 {
     return nsvm_vmcb_guest_intercepts_exitcode(v,
@@ -1206,8 +1205,7 @@ nsvm_vmcb_prepare4vmexit(struct vcpu *v, struct cpu_user_regs *regs)
     return 0;
 }
 
-bool_t
-nsvm_vmcb_hap_enabled(struct vcpu *v)
+bool cf_check nsvm_vmcb_hap_enabled(struct vcpu *v)
 {
     return vcpu_nestedsvm(v).ns_hap_enabled;
 }
@@ -1216,7 +1214,7 @@ nsvm_vmcb_hap_enabled(struct vcpu *v)
  * walk is successful, the translated value is returned in
  * L1_gpa. The result value tells what to do next.
  */
-int nsvm_hap_walk_L1_p2m(
+int cf_check nsvm_hap_walk_L1_p2m(
     struct vcpu *v, paddr_t L2_gpa, paddr_t *L1_gpa, unsigned int *page_order,
     uint8_t *p2m_acc, struct npfec npfec)
 {
@@ -1241,7 +1239,7 @@ int nsvm_hap_walk_L1_p2m(
     return NESTEDHVM_PAGEFAULT_DONE;
 }
 
-enum hvm_intblk nsvm_intr_blocked(struct vcpu *v)
+enum hvm_intblk cf_check nsvm_intr_blocked(struct vcpu *v)
 {
     struct nestedsvm *svm = &vcpu_nestedsvm(v);
     struct nestedvcpu *nv = &vcpu_nestedhvm(v);
diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c
index c4ce3f75ab74..de6166241bf1 100644
--- a/xen/arch/x86/hvm/svm/svm.c
+++ b/xen/arch/x86/hvm/svm/svm.c
@@ -67,8 +67,6 @@ void noreturn svm_asm_do_resume(void);
 
 u32 svm_feature_flags;
 
-static void svm_update_guest_efer(struct vcpu *);
-
 static struct hvm_function_table svm_function_table;
 
 /*
@@ -122,11 +120,166 @@ void __update_guest_eip(struct cpu_user_regs *regs, unsigned int inst_len)
         hvm_inject_hw_exception(TRAP_debug, X86_EVENT_NO_EC);
 }
 
-static void svm_cpu_down(void)
+static void cf_check svm_cpu_down(void)
 {
     write_efer(read_efer() & ~EFER_SVME);
 }
 
+static void svm_fpu_enter(struct vcpu *v)
+{
+    struct vmcb_struct *n1vmcb = vcpu_nestedhvm(v).nv_n1vmcx;
+
+    vcpu_restore_fpu_lazy(v);
+    vmcb_set_exception_intercepts(
+        n1vmcb,
+        vmcb_get_exception_intercepts(n1vmcb) & ~(1U << TRAP_no_device));
+}
+
+static void cf_check svm_fpu_leave(struct vcpu *v)
+{
+    struct vmcb_struct *n1vmcb = vcpu_nestedhvm(v).nv_n1vmcx;
+
+    ASSERT(!v->fpu_dirtied);
+    ASSERT(read_cr0() & X86_CR0_TS);
+
+    /*
+     * If the guest does not have TS enabled then we must cause and handle an
+     * exception on first use of the FPU. If the guest *does* have TS enabled
+     * then this is not necessary: no FPU activity can occur until the guest
+     * clears CR0.TS, and we will initialise the FPU when that happens.
+     */
+    if ( !(v->arch.hvm.guest_cr[0] & X86_CR0_TS) )
+    {
+        vmcb_set_exception_intercepts(
+            n1vmcb,
+            vmcb_get_exception_intercepts(n1vmcb) | (1U << TRAP_no_device));
+        vmcb_set_cr0(n1vmcb, vmcb_get_cr0(n1vmcb) | X86_CR0_TS);
+    }
+}
+
+static void cf_check svm_update_guest_cr(
+    struct vcpu *v, unsigned int cr, unsigned int flags)
+{
+    struct vmcb_struct *vmcb = v->arch.hvm.svm.vmcb;
+    uint64_t value;
+
+    switch ( cr )
+    {
+    case 0:
+    {
+        unsigned long hw_cr0_mask = 0;
+
+        if ( !(v->arch.hvm.guest_cr[0] & X86_CR0_TS) )
+        {
+            if ( v != current )
+            {
+                if ( !v->arch.fully_eager_fpu )
+                    hw_cr0_mask |= X86_CR0_TS;
+            }
+            else if ( vmcb_get_cr0(vmcb) & X86_CR0_TS )
+                svm_fpu_enter(v);
+        }
+
+        if ( paging_mode_hap(v->domain) )
+        {
+            uint32_t intercepts = vmcb_get_cr_intercepts(vmcb);
+
+            /* Trap CR3 updates if CR3 memory events are enabled. */
+            if ( v->domain->arch.monitor.write_ctrlreg_enabled &
+                 monitor_ctrlreg_bitmask(VM_EVENT_X86_CR3) )
+               vmcb_set_cr_intercepts(vmcb, intercepts | CR_INTERCEPT_CR3_WRITE);
+        }
+
+        value = v->arch.hvm.guest_cr[0] | hw_cr0_mask;
+        if ( !paging_mode_hap(v->domain) )
+            value |= X86_CR0_PG | X86_CR0_WP;
+        vmcb_set_cr0(vmcb, value);
+        break;
+    }
+    case 2:
+        vmcb_set_cr2(vmcb, v->arch.hvm.guest_cr[2]);
+        break;
+    case 3:
+        vmcb_set_cr3(vmcb, v->arch.hvm.hw_cr[3]);
+        if ( !nestedhvm_enabled(v->domain) )
+        {
+            if ( !(flags & HVM_UPDATE_GUEST_CR3_NOFLUSH) )
+                hvm_asid_flush_vcpu(v);
+        }
+        else if ( nestedhvm_vmswitch_in_progress(v) )
+            ; /* CR3 switches during VMRUN/VMEXIT do not flush the TLB. */
+        else if ( !(flags & HVM_UPDATE_GUEST_CR3_NOFLUSH) )
+            hvm_asid_flush_vcpu_asid(
+                nestedhvm_vcpu_in_guestmode(v)
+                ? &vcpu_nestedhvm(v).nv_n2asid : &v->arch.hvm.n1asid);
+        break;
+    case 4:
+        value = HVM_CR4_HOST_MASK;
+        if ( paging_mode_hap(v->domain) )
+            value &= ~X86_CR4_PAE;
+        value |= v->arch.hvm.guest_cr[4];
+
+        if ( !hvm_paging_enabled(v) )
+        {
+            /*
+             * When the guest thinks paging is disabled, Xen may need to hide
+             * the effects of shadow paging, as hardware runs with the host
+             * paging settings, rather than the guests settings.
+             *
+             * Without CR0.PG, all memory accesses are user mode, so
+             * _PAGE_USER must be set in the shadow pagetables for guest
+             * userspace to function.  This in turn trips up guest supervisor
+             * mode if SMEP/SMAP are left active in context.  They wouldn't
+             * have any effect if paging was actually disabled, so hide them
+             * behind the back of the guest.
+             */
+            value &= ~(X86_CR4_SMEP | X86_CR4_SMAP);
+        }
+
+        vmcb_set_cr4(vmcb, value);
+        break;
+    default:
+        BUG();
+    }
+}
+
+static void cf_check svm_update_guest_efer(struct vcpu *v)
+{
+    struct vmcb_struct *vmcb = v->arch.hvm.svm.vmcb;
+    unsigned long guest_efer = v->arch.hvm.guest_efer,
+        xen_efer = read_efer();
+
+    if ( paging_mode_shadow(v->domain) )
+    {
+        /* EFER.NX is a Xen-owned bit and is not under guest control. */
+        guest_efer &= ~EFER_NXE;
+        guest_efer |= xen_efer & EFER_NXE;
+
+        /*
+         * CR0.PG is a Xen-owned bit, and remains set even when the guest has
+         * logically disabled paging.
+         *
+         * LMA was calculated using the guest CR0.PG setting, but LME needs
+         * clearing to avoid interacting with Xen's CR0.PG setting.  As writes
+         * to CR0 are intercepted, it is safe to leave LME clear at this
+         * point, and fix up both LME and LMA when CR0.PG is set.
+         */
+        if ( !(guest_efer & EFER_LMA) )
+            guest_efer &= ~EFER_LME;
+    }
+
+    /* SVME must remain set in non-root mode. */
+    guest_efer |= EFER_SVME;
+
+    vmcb_set_efer(vmcb, guest_efer);
+
+    ASSERT(nestedhvm_enabled(v->domain) ||
+           !(v->arch.hvm.guest_efer & EFER_SVME));
+
+    if ( nestedhvm_enabled(v->domain) )
+        svm_nested_features_on_efer_update(v);
+}
+
 unsigned long *
 svm_msrbit(unsigned long *msr_bitmap, uint32_t msr)
 {
@@ -165,7 +318,7 @@ void svm_intercept_msr(struct vcpu *v, uint32_t msr, int flags)
         __clear_bit(msr * 2 + 1, msr_bit);
 }
 
-static void svm_enable_msr_interception(struct domain *d, uint32_t msr)
+static void cf_check svm_enable_msr_interception(struct domain *d, uint32_t msr)
 {
     struct vcpu *v;
 
@@ -377,13 +530,13 @@ static void svm_load_cpu_state(struct vcpu *v, struct hvm_hw_cpu *data)
     svm_update_guest_efer(v);
 }
 
-static void svm_save_vmcb_ctxt(struct vcpu *v, struct hvm_hw_cpu *ctxt)
+static void cf_check svm_save_vmcb_ctxt(struct vcpu *v, struct hvm_hw_cpu *ctxt)
 {
     svm_save_cpu_state(v, ctxt);
     svm_vmcb_save(v, ctxt);
 }
 
-static int svm_load_vmcb_ctxt(struct vcpu *v, struct hvm_hw_cpu *ctxt)
+static int cf_check svm_load_vmcb_ctxt(struct vcpu *v, struct hvm_hw_cpu *ctxt)
 {
     svm_load_cpu_state(v, ctxt);
     if ( svm_vmcb_restore(v, ctxt) )
@@ -396,39 +549,7 @@ static int svm_load_vmcb_ctxt(struct vcpu *v, struct hvm_hw_cpu *ctxt)
     return 0;
 }
 
-static void svm_fpu_enter(struct vcpu *v)
-{
-    struct vmcb_struct *n1vmcb = vcpu_nestedhvm(v).nv_n1vmcx;
-
-    vcpu_restore_fpu_lazy(v);
-    vmcb_set_exception_intercepts(
-        n1vmcb,
-        vmcb_get_exception_intercepts(n1vmcb) & ~(1U << TRAP_no_device));
-}
-
-static void svm_fpu_leave(struct vcpu *v)
-{
-    struct vmcb_struct *n1vmcb = vcpu_nestedhvm(v).nv_n1vmcx;
-
-    ASSERT(!v->fpu_dirtied);
-    ASSERT(read_cr0() & X86_CR0_TS);
-
-    /*
-     * If the guest does not have TS enabled then we must cause and handle an
-     * exception on first use of the FPU. If the guest *does* have TS enabled
-     * then this is not necessary: no FPU activity can occur until the guest
-     * clears CR0.TS, and we will initialise the FPU when that happens.
-     */
-    if ( !(v->arch.hvm.guest_cr[0] & X86_CR0_TS) )
-    {
-        vmcb_set_exception_intercepts(
-            n1vmcb,
-            vmcb_get_exception_intercepts(n1vmcb) | (1U << TRAP_no_device));
-        vmcb_set_cr0(n1vmcb, vmcb_get_cr0(n1vmcb) | X86_CR0_TS);
-    }
-}
-
-static unsigned int svm_get_interrupt_shadow(struct vcpu *v)
+static unsigned cf_check int svm_get_interrupt_shadow(struct vcpu *v)
 {
     struct vmcb_struct *vmcb = v->arch.hvm.svm.vmcb;
     unsigned int intr_shadow = 0;
@@ -442,7 +563,8 @@ static unsigned int svm_get_interrupt_shadow(struct vcpu *v)
     return intr_shadow;
 }
 
-static void svm_set_interrupt_shadow(struct vcpu *v, unsigned int intr_shadow)
+static void cf_check svm_set_interrupt_shadow(
+    struct vcpu *v, unsigned int intr_shadow)
 {
     struct vmcb_struct *vmcb = v->arch.hvm.svm.vmcb;
     u32 general1_intercepts = vmcb_get_general1_intercepts(vmcb);
@@ -456,7 +578,7 @@ static void svm_set_interrupt_shadow(struct vcpu *v, unsigned int intr_shadow)
     vmcb_set_general1_intercepts(vmcb, general1_intercepts);
 }
 
-static int svm_guest_x86_mode(struct vcpu *v)
+static int cf_check svm_guest_x86_mode(struct vcpu *v)
 {
     struct vmcb_struct *vmcb = v->arch.hvm.svm.vmcb;
 
@@ -469,129 +591,7 @@ static int svm_guest_x86_mode(struct vcpu *v)
     return likely(vmcb->cs.db) ? 4 : 2;
 }
 
-void svm_update_guest_cr(struct vcpu *v, unsigned int cr, unsigned int flags)
-{
-    struct vmcb_struct *vmcb = v->arch.hvm.svm.vmcb;
-    uint64_t value;
-
-    switch ( cr )
-    {
-    case 0:
-    {
-        unsigned long hw_cr0_mask = 0;
-
-        if ( !(v->arch.hvm.guest_cr[0] & X86_CR0_TS) )
-        {
-            if ( v != current )
-            {
-                if ( !v->arch.fully_eager_fpu )
-                    hw_cr0_mask |= X86_CR0_TS;
-            }
-            else if ( vmcb_get_cr0(vmcb) & X86_CR0_TS )
-                svm_fpu_enter(v);
-        }
-
-        if ( paging_mode_hap(v->domain) )
-        {
-            uint32_t intercepts = vmcb_get_cr_intercepts(vmcb);
-
-            /* Trap CR3 updates if CR3 memory events are enabled. */
-            if ( v->domain->arch.monitor.write_ctrlreg_enabled &
-                 monitor_ctrlreg_bitmask(VM_EVENT_X86_CR3) )
-               vmcb_set_cr_intercepts(vmcb, intercepts | CR_INTERCEPT_CR3_WRITE);
-        }
-
-        value = v->arch.hvm.guest_cr[0] | hw_cr0_mask;
-        if ( !paging_mode_hap(v->domain) )
-            value |= X86_CR0_PG | X86_CR0_WP;
-        vmcb_set_cr0(vmcb, value);
-        break;
-    }
-    case 2:
-        vmcb_set_cr2(vmcb, v->arch.hvm.guest_cr[2]);
-        break;
-    case 3:
-        vmcb_set_cr3(vmcb, v->arch.hvm.hw_cr[3]);
-        if ( !nestedhvm_enabled(v->domain) )
-        {
-            if ( !(flags & HVM_UPDATE_GUEST_CR3_NOFLUSH) )
-                hvm_asid_flush_vcpu(v);
-        }
-        else if ( nestedhvm_vmswitch_in_progress(v) )
-            ; /* CR3 switches during VMRUN/VMEXIT do not flush the TLB. */
-        else if ( !(flags & HVM_UPDATE_GUEST_CR3_NOFLUSH) )
-            hvm_asid_flush_vcpu_asid(
-                nestedhvm_vcpu_in_guestmode(v)
-                ? &vcpu_nestedhvm(v).nv_n2asid : &v->arch.hvm.n1asid);
-        break;
-    case 4:
-        value = HVM_CR4_HOST_MASK;
-        if ( paging_mode_hap(v->domain) )
-            value &= ~X86_CR4_PAE;
-        value |= v->arch.hvm.guest_cr[4];
-
-        if ( !hvm_paging_enabled(v) )
-        {
-            /*
-             * When the guest thinks paging is disabled, Xen may need to hide
-             * the effects of shadow paging, as hardware runs with the host
-             * paging settings, rather than the guests settings.
-             *
-             * Without CR0.PG, all memory accesses are user mode, so
-             * _PAGE_USER must be set in the shadow pagetables for guest
-             * userspace to function.  This in turn trips up guest supervisor
-             * mode if SMEP/SMAP are left active in context.  They wouldn't
-             * have any effect if paging was actually disabled, so hide them
-             * behind the back of the guest.
-             */
-            value &= ~(X86_CR4_SMEP | X86_CR4_SMAP);
-        }
-
-        vmcb_set_cr4(vmcb, value);
-        break;
-    default:
-        BUG();
-    }
-}
-
-static void svm_update_guest_efer(struct vcpu *v)
-{
-    struct vmcb_struct *vmcb = v->arch.hvm.svm.vmcb;
-    unsigned long guest_efer = v->arch.hvm.guest_efer,
-        xen_efer = read_efer();
-
-    if ( paging_mode_shadow(v->domain) )
-    {
-        /* EFER.NX is a Xen-owned bit and is not under guest control. */
-        guest_efer &= ~EFER_NXE;
-        guest_efer |= xen_efer & EFER_NXE;
-
-        /*
-         * CR0.PG is a Xen-owned bit, and remains set even when the guest has
-         * logically disabled paging.
-         *
-         * LMA was calculated using the guest CR0.PG setting, but LME needs
-         * clearing to avoid interacting with Xen's CR0.PG setting.  As writes
-         * to CR0 are intercepted, it is safe to leave LME clear at this
-         * point, and fix up both LME and LMA when CR0.PG is set.
-         */
-        if ( !(guest_efer & EFER_LMA) )
-            guest_efer &= ~EFER_LME;
-    }
-
-    /* SVME must remain set in non-root mode. */
-    guest_efer |= EFER_SVME;
-
-    vmcb_set_efer(vmcb, guest_efer);
-
-    ASSERT(nestedhvm_enabled(v->domain) ||
-           !(v->arch.hvm.guest_efer & EFER_SVME));
-
-    if ( nestedhvm_enabled(v->domain) )
-        svm_nested_features_on_efer_update(v);
-}
-
-static void svm_cpuid_policy_changed(struct vcpu *v)
+static void cf_check svm_cpuid_policy_changed(struct vcpu *v)
 {
     struct svm_vcpu *svm = &v->arch.hvm.svm;
     struct vmcb_struct *vmcb = svm->vmcb;
@@ -636,13 +636,13 @@ void svm_sync_vmcb(struct vcpu *v, enum vmcb_sync_state new_state)
     }
 }
 
-static unsigned int svm_get_cpl(struct vcpu *v)
+static unsigned int cf_check svm_get_cpl(struct vcpu *v)
 {
     return vmcb_get_cpl(v->arch.hvm.svm.vmcb);
 }
 
-static void svm_get_segment_register(struct vcpu *v, enum x86_segment seg,
-                                     struct segment_register *reg)
+static void cf_check svm_get_segment_register(
+    struct vcpu *v, enum x86_segment seg, struct segment_register *reg)
 {
     struct vmcb_struct *vmcb = v->arch.hvm.svm.vmcb;
 
@@ -686,8 +686,8 @@ static void svm_get_segment_register(struct vcpu *v, enum x86_segment seg,
     }
 }
 
-static void svm_set_segment_register(struct vcpu *v, enum x86_segment seg,
-                                     struct segment_register *reg)
+static void cf_check svm_set_segment_register(
+    struct vcpu *v, enum x86_segment seg, struct segment_register *reg)
 {
     struct vmcb_struct *vmcb = v->arch.hvm.svm.vmcb;
 
@@ -756,12 +756,12 @@ static void svm_set_segment_register(struct vcpu *v, enum x86_segment seg,
     }
 }
 
-static unsigned long svm_get_shadow_gs_base(struct vcpu *v)
+static unsigned long cf_check svm_get_shadow_gs_base(struct vcpu *v)
 {
     return v->arch.hvm.svm.vmcb->kerngsbase;
 }
 
-static int svm_set_guest_pat(struct vcpu *v, u64 gpat)
+static int cf_check svm_set_guest_pat(struct vcpu *v, u64 gpat)
 {
     struct vmcb_struct *vmcb = v->arch.hvm.svm.vmcb;
 
@@ -772,7 +772,7 @@ static int svm_set_guest_pat(struct vcpu *v, u64 gpat)
     return 1;
 }
 
-static int svm_get_guest_pat(struct vcpu *v, u64 *gpat)
+static int cf_check svm_get_guest_pat(struct vcpu *v, u64 *gpat)
 {
     struct vmcb_struct *vmcb = v->arch.hvm.svm.vmcb;
 
@@ -820,7 +820,7 @@ static uint64_t svm_get_tsc_offset(uint64_t host_tsc, uint64_t guest_tsc,
     return guest_tsc - scale_tsc(host_tsc, ratio);
 }
 
-static void svm_set_tsc_offset(struct vcpu *v, u64 offset, u64 at_tsc)
+static void cf_check svm_set_tsc_offset(struct vcpu *v, u64 offset, u64 at_tsc)
 {
     struct vmcb_struct *vmcb = v->arch.hvm.svm.vmcb;
     struct vmcb_struct *n1vmcb, *n2vmcb;
@@ -856,7 +856,7 @@ static void svm_set_tsc_offset(struct vcpu *v, u64 offset, u64 at_tsc)
     vmcb_set_tsc_offset(vmcb, offset + n2_tsc_offset);
 }
 
-static void svm_set_rdtsc_exiting(struct vcpu *v, bool_t enable)
+static void cf_check svm_set_rdtsc_exiting(struct vcpu *v, bool enable)
 {
     struct vmcb_struct *vmcb = v->arch.hvm.svm.vmcb;
     u32 general1_intercepts = vmcb_get_general1_intercepts(vmcb);
@@ -875,7 +875,8 @@ static void svm_set_rdtsc_exiting(struct vcpu *v, bool_t enable)
     vmcb_set_general2_intercepts(vmcb, general2_intercepts);
 }
 
-static void svm_set_descriptor_access_exiting(struct vcpu *v, bool enable)
+static void cf_check svm_set_descriptor_access_exiting(
+    struct vcpu *v, bool enable)
 {
     struct vmcb_struct *vmcb = v->arch.hvm.svm.vmcb;
     u32 general1_intercepts = vmcb_get_general1_intercepts(vmcb);
@@ -892,7 +893,7 @@ static void svm_set_descriptor_access_exiting(struct vcpu *v, bool enable)
     vmcb_set_general1_intercepts(vmcb, general1_intercepts);
 }
 
-static unsigned int svm_get_insn_bytes(struct vcpu *v, uint8_t *buf)
+static unsigned int cf_check svm_get_insn_bytes(struct vcpu *v, uint8_t *buf)
 {
     struct vmcb_struct *vmcb = v->arch.hvm.svm.vmcb;
     unsigned int len = v->arch.hvm.svm.cached_insn_len;
@@ -907,7 +908,7 @@ static unsigned int svm_get_insn_bytes(struct vcpu *v, uint8_t *buf)
     return len;
 }
 
-static void svm_init_hypercall_page(void *p)
+static void cf_check svm_init_hypercall_page(void *p)
 {
     unsigned int i;
 
@@ -1148,7 +1149,7 @@ static int acpi_c1e_quirk(int dir, unsigned int port, unsigned int bytes,
     return X86EMUL_OKAY;
 }
 
-static int svm_domain_initialise(struct domain *d)
+static int cf_check svm_domain_initialise(struct domain *d)
 {
     static const struct arch_csw csw = {
         .from = svm_ctxt_switch_from,
@@ -1166,7 +1167,7 @@ static int svm_domain_initialise(struct domain *d)
     return 0;
 }
 
-static int svm_vcpu_initialise(struct vcpu *v)
+static int cf_check svm_vcpu_initialise(struct vcpu *v)
 {
     int rc;
 
@@ -1183,7 +1184,7 @@ static int svm_vcpu_initialise(struct vcpu *v)
     return 0;
 }
 
-static void svm_vcpu_destroy(struct vcpu *v)
+static void cf_check svm_vcpu_destroy(struct vcpu *v)
 {
     svm_destroy_vmcb(v);
     passive_domain_destroy(v);
@@ -1304,7 +1305,7 @@ static void svm_emul_swint_injection(struct x86_event *event)
     event->error_code = ec;
 }
 
-static void svm_inject_event(const struct x86_event *event)
+static void cf_check svm_inject_event(const struct x86_event *event)
 {
     struct vcpu *curr = current;
     struct vmcb_struct *vmcb = curr->arch.hvm.svm.vmcb;
@@ -1434,12 +1435,12 @@ static void svm_inject_event(const struct x86_event *event)
         HVMTRACE_2D(INJ_EXC, _event.vector, _event.error_code);
 }
 
-static bool svm_event_pending(const struct vcpu *v)
+static bool cf_check svm_event_pending(const struct vcpu *v)
 {
     return v->arch.hvm.svm.vmcb->event_inj.v;
 }
 
-static void svm_cpu_dead(unsigned int cpu)
+static void cf_check svm_cpu_dead(unsigned int cpu)
 {
     paddr_t *this_hsa = &per_cpu(hsa, cpu);
     paddr_t *this_vmcb = &per_cpu(host_vmcb, cpu);
@@ -1465,7 +1466,7 @@ static void svm_cpu_dead(unsigned int cpu)
     }
 }
 
-static int svm_cpu_up_prepare(unsigned int cpu)
+static int cf_check svm_cpu_up_prepare(unsigned int cpu)
 {
     paddr_t *this_hsa = &per_cpu(hsa, cpu);
     paddr_t *this_vmcb = &per_cpu(host_vmcb, cpu);
@@ -1620,7 +1621,7 @@ static int _svm_cpu_up(bool bsp)
     return 0;
 }
 
-static int svm_cpu_up(void)
+static int cf_check svm_cpu_up(void)
 {
     return _svm_cpu_up(false);
 }
@@ -1749,7 +1750,7 @@ static void svm_do_nested_pgfault(struct vcpu *v,
     domain_crash(v->domain);
 }
 
-static void svm_fpu_dirty_intercept(void)
+static void cf_check svm_fpu_dirty_intercept(void)
 {
     struct vcpu *v = current;
     struct vmcb_struct *vmcb = v->arch.hvm.svm.vmcb;
@@ -1795,7 +1796,8 @@ static void svm_dr_access(struct vcpu *v, struct cpu_user_regs *regs)
     __restore_debug_registers(vmcb, v);
 }
 
-static int svm_msr_read_intercept(unsigned int msr, uint64_t *msr_content)
+static int cf_check svm_msr_read_intercept(
+    unsigned int msr, uint64_t *msr_content)
 {
     struct vcpu *v = current;
     const struct domain *d = v->domain;
@@ -1990,7 +1992,8 @@ static int svm_msr_read_intercept(unsigned int msr, uint64_t *msr_content)
     return X86EMUL_EXCEPTION;
 }
 
-static int svm_msr_write_intercept(unsigned int msr, uint64_t msr_content)
+static int cf_check svm_msr_write_intercept(
+    unsigned int msr, uint64_t msr_content)
 {
     struct vcpu *v = current;
     struct domain *d = v->domain;
@@ -2409,7 +2412,7 @@ static void svm_vmexit_mce_intercept(
     }
 }
 
-static void svm_wbinvd_intercept(void)
+static void cf_check svm_wbinvd_intercept(void)
 {
     if ( cache_flush_permitted(current->domain) )
         flush_all(FLUSH_CACHE);
@@ -2454,12 +2457,13 @@ static bool is_invlpg(const struct x86_emulate_state *state,
            (ext & 7) == 7;
 }
 
-static void svm_invlpg(struct vcpu *v, unsigned long linear)
+static void cf_check svm_invlpg(struct vcpu *v, unsigned long linear)
 {
     svm_asid_g_invlpg(v, linear);
 }
 
-static bool svm_get_pending_event(struct vcpu *v, struct x86_event *info)
+static bool cf_check svm_get_pending_event(
+    struct vcpu *v, struct x86_event *info)
 {
     const struct vmcb_struct *vmcb = v->arch.hvm.svm.vmcb;
 
@@ -2473,7 +2477,7 @@ static bool svm_get_pending_event(struct vcpu *v, struct x86_event *info)
     return true;
 }
 
-static uint64_t svm_get_reg(struct vcpu *v, unsigned int reg)
+static uint64_t cf_check svm_get_reg(struct vcpu *v, unsigned int reg)
 {
     const struct vmcb_struct *vmcb = v->arch.hvm.svm.vmcb;
     struct domain *d = v->domain;
@@ -2491,7 +2495,7 @@ static uint64_t svm_get_reg(struct vcpu *v, unsigned int reg)
     }
 }
 
-static void svm_set_reg(struct vcpu *v, unsigned int reg, uint64_t val)
+static void cf_check svm_set_reg(struct vcpu *v, unsigned int reg, uint64_t val)
 {
     struct vmcb_struct *vmcb = v->arch.hvm.svm.vmcb;
     struct domain *d = v->domain;
diff --git a/xen/arch/x86/hvm/vmx/intr.c b/xen/arch/x86/hvm/vmx/intr.c
index 80bfbb478782..13bbe8430df5 100644
--- a/xen/arch/x86/hvm/vmx/intr.c
+++ b/xen/arch/x86/hvm/vmx/intr.c
@@ -147,7 +147,7 @@ static void vmx_enable_intr_window(struct vcpu *v, struct hvm_intack intack)
  *         used but may have negative impact on interrupt performance.
  */
 
-enum hvm_intblk nvmx_intr_blocked(struct vcpu *v)
+enum hvm_intblk cf_check nvmx_intr_blocked(struct vcpu *v)
 {
     int r = hvm_intblk_none;
     struct nestedvcpu *nvcpu = &vcpu_nestedhvm(v);
diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c
index d2cafd8ca1c5..60b506ac3f40 100644
--- a/xen/arch/x86/hvm/vmx/vmcs.c
+++ b/xen/arch/x86/hvm/vmx/vmcs.c
@@ -655,7 +655,7 @@ void vmx_vmcs_reload(struct vcpu *v)
     vmx_load_vmcs(v);
 }
 
-int vmx_cpu_up_prepare(unsigned int cpu)
+int cf_check vmx_cpu_up_prepare(unsigned int cpu)
 {
     /*
      * If nvmx_cpu_up_prepare() failed, do not return failure and just fallback
@@ -676,7 +676,7 @@ int vmx_cpu_up_prepare(unsigned int cpu)
     return -ENOMEM;
 }
 
-void vmx_cpu_dead(unsigned int cpu)
+void cf_check vmx_cpu_dead(unsigned int cpu)
 {
     vmx_free_vmcs(per_cpu(vmxon_region, cpu));
     per_cpu(vmxon_region, cpu) = 0;
@@ -774,12 +774,12 @@ static int _vmx_cpu_up(bool bsp)
     return 0;
 }
 
-int vmx_cpu_up()
+int cf_check vmx_cpu_up()
 {
     return _vmx_cpu_up(false);
 }
 
-void vmx_cpu_down(void)
+void cf_check vmx_cpu_down(void)
 {
     struct list_head *active_vmcs_list = &this_cpu(active_vmcs_list);
     unsigned long flags;
diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c
index dade08f60279..2c4804f9b884 100644
--- a/xen/arch/x86/hvm/vmx/vmx.c
+++ b/xen/arch/x86/hvm/vmx/vmx.c
@@ -68,14 +68,16 @@ static void vmx_ctxt_switch_to(struct vcpu *v);
 
 static int alloc_vlapic_mapping(void);
 static void vmx_install_vlapic_mapping(struct vcpu *v);
-static void vmx_update_guest_cr(struct vcpu *v, unsigned int cr,
-                                unsigned int flags);
-static void vmx_update_guest_efer(struct vcpu *v);
-static void vmx_wbinvd_intercept(void);
-static void vmx_fpu_dirty_intercept(void);
-static int vmx_msr_read_intercept(unsigned int msr, uint64_t *msr_content);
-static int vmx_msr_write_intercept(unsigned int msr, uint64_t msr_content);
-static void vmx_invlpg(struct vcpu *v, unsigned long linear);
+static void cf_check vmx_update_guest_cr(
+    struct vcpu *v, unsigned int cr, unsigned int flags);
+static void cf_check vmx_update_guest_efer(struct vcpu *v);
+static void cf_check vmx_wbinvd_intercept(void);
+static void cf_check vmx_fpu_dirty_intercept(void);
+static int cf_check vmx_msr_read_intercept(
+    unsigned int msr, uint64_t *msr_content);
+static int cf_check vmx_msr_write_intercept(
+    unsigned int msr, uint64_t msr_content);
+static void cf_check vmx_invlpg(struct vcpu *v, unsigned long linear);
 
 static mfn_t __read_mostly apic_access_mfn = INVALID_MFN_INITIALIZER;
 
@@ -103,7 +105,7 @@ void vmx_pi_per_cpu_init(unsigned int cpu)
     spin_lock_init(&per_cpu(vmx_pi_blocking, cpu).lock);
 }
 
-static void vmx_vcpu_block(struct vcpu *v)
+static void cf_check vmx_vcpu_block(struct vcpu *v)
 {
     unsigned long flags;
     unsigned int dest;
@@ -395,7 +397,7 @@ void vmx_pi_hooks_deassign(struct domain *d)
     domain_unpause(d);
 }
 
-static int vmx_domain_initialise(struct domain *d)
+static int cf_check vmx_domain_initialise(struct domain *d)
 {
     static const struct arch_csw csw = {
         .from = vmx_ctxt_switch_from,
@@ -414,7 +416,7 @@ static int vmx_domain_initialise(struct domain *d)
     return 0;
 }
 
-static void domain_creation_finished(struct domain *d)
+static void cf_check domain_creation_finished(struct domain *d)
 {
     gfn_t gfn = gaddr_to_gfn(APIC_DEFAULT_PHYS_BASE);
     bool ipat;
@@ -444,7 +446,7 @@ static void vmx_init_ipt(struct vcpu *v)
     v->arch.msrs->rtit.output_limit = size - 1;
 }
 
-static int vmx_vcpu_initialise(struct vcpu *v)
+static int cf_check vmx_vcpu_initialise(struct vcpu *v)
 {
     int rc;
 
@@ -491,7 +493,7 @@ static int vmx_vcpu_initialise(struct vcpu *v)
     return 0;
 }
 
-static void vmx_vcpu_destroy(struct vcpu *v)
+static void cf_check vmx_vcpu_destroy(struct vcpu *v)
 {
     /*
      * There are cases that domain still remains in log-dirty mode when it is
@@ -589,7 +591,7 @@ void vmx_update_exception_bitmap(struct vcpu *v)
         __vmwrite(EXCEPTION_BITMAP, bitmap);
 }
 
-static void vmx_cpuid_policy_changed(struct vcpu *v)
+static void cf_check vmx_cpuid_policy_changed(struct vcpu *v)
 {
     const struct cpuid_policy *cp = v->domain->arch.cpuid;
     int rc = 0;
@@ -647,7 +649,7 @@ static void vmx_cpuid_policy_changed(struct vcpu *v)
     }
 }
 
-int vmx_guest_x86_mode(struct vcpu *v)
+int cf_check vmx_guest_x86_mode(struct vcpu *v)
 {
     unsigned long cs_ar_bytes;
 
@@ -844,7 +846,7 @@ static void vmx_load_cpu_state(struct vcpu *v, struct hvm_hw_cpu *data)
 }
 
 
-static void vmx_save_vmcs_ctxt(struct vcpu *v, struct hvm_hw_cpu *ctxt)
+static void cf_check vmx_save_vmcs_ctxt(struct vcpu *v, struct hvm_hw_cpu *ctxt)
 {
     if ( v == current )
         vmx_save_guest_msrs(v);
@@ -853,7 +855,7 @@ static void vmx_save_vmcs_ctxt(struct vcpu *v, struct hvm_hw_cpu *ctxt)
     vmx_vmcs_save(v, ctxt);
 }
 
-static int vmx_load_vmcs_ctxt(struct vcpu *v, struct hvm_hw_cpu *ctxt)
+static int cf_check vmx_load_vmcs_ctxt(struct vcpu *v, struct hvm_hw_cpu *ctxt)
 {
     /* Not currently safe to use in current context. */
     ASSERT(v != current);
@@ -879,7 +881,7 @@ static void vmx_fpu_enter(struct vcpu *v)
     __vmwrite(HOST_CR0, v->arch.hvm.vmx.host_cr0);
 }
 
-static void vmx_fpu_leave(struct vcpu *v)
+static void cf_check vmx_fpu_leave(struct vcpu *v)
 {
     ASSERT(!v->fpu_dirtied);
     ASSERT(read_cr0() & X86_CR0_TS);
@@ -956,7 +958,7 @@ unsigned int vmx_get_cpl(void)
     return (attr >> 5) & 3;
 }
 
-static unsigned int _vmx_get_cpl(struct vcpu *v)
+static unsigned int cf_check _vmx_get_cpl(struct vcpu *v)
 {
     unsigned int cpl;
 
@@ -982,8 +984,8 @@ static unsigned int _vmx_get_cpl(struct vcpu *v)
 #define vm86_ds_attr 0xf3
 #define vm86_tr_attr 0x8b
 
-static void vmx_get_segment_register(struct vcpu *v, enum x86_segment seg,
-                                     struct segment_register *reg)
+static void cf_check vmx_get_segment_register(
+    struct vcpu *v, enum x86_segment seg, struct segment_register *reg)
 {
     unsigned long attr = 0, sel = 0, limit;
     unsigned int tmp_seg;
@@ -1084,8 +1086,8 @@ static void vmx_get_segment_register(struct vcpu *v, enum x86_segment seg,
     }
 }
 
-static void vmx_set_segment_register(struct vcpu *v, enum x86_segment seg,
-                                     struct segment_register *reg)
+static void cf_check vmx_set_segment_register(
+    struct vcpu *v, enum x86_segment seg, struct segment_register *reg)
 {
     uint32_t attr, sel, limit;
     uint64_t base;
@@ -1174,12 +1176,12 @@ static void vmx_set_segment_register(struct vcpu *v, enum x86_segment seg,
     vmx_vmcs_exit(v);
 }
 
-static unsigned long vmx_get_shadow_gs_base(struct vcpu *v)
+static unsigned long cf_check vmx_get_shadow_gs_base(struct vcpu *v)
 {
     return v->arch.hvm.vmx.shadow_gs;
 }
 
-static int vmx_set_guest_pat(struct vcpu *v, u64 gpat)
+static int cf_check vmx_set_guest_pat(struct vcpu *v, u64 gpat)
 {
     if ( !paging_mode_hap(v->domain) ||
          unlikely(v->arch.hvm.cache_mode == NO_FILL_CACHE_MODE) )
@@ -1191,7 +1193,7 @@ static int vmx_set_guest_pat(struct vcpu *v, u64 gpat)
     return 1;
 }
 
-static int vmx_get_guest_pat(struct vcpu *v, u64 *gpat)
+static int cf_check vmx_get_guest_pat(struct vcpu *v, u64 *gpat)
 {
     if ( !paging_mode_hap(v->domain) ||
          unlikely(v->arch.hvm.cache_mode == NO_FILL_CACHE_MODE) )
@@ -1203,7 +1205,7 @@ static int vmx_get_guest_pat(struct vcpu *v, u64 *gpat)
     return 1;
 }
 
-static void vmx_handle_cd(struct vcpu *v, unsigned long value)
+static void cf_check vmx_handle_cd(struct vcpu *v, unsigned long value)
 {
     if ( !paging_mode_hap(v->domain) )
     {
@@ -1253,7 +1255,7 @@ static void vmx_handle_cd(struct vcpu *v, unsigned long value)
     }
 }
 
-static void vmx_setup_tsc_scaling(struct vcpu *v)
+static void cf_check vmx_setup_tsc_scaling(struct vcpu *v)
 {
     if ( v->domain->arch.vtsc )
         return;
@@ -1263,7 +1265,7 @@ static void vmx_setup_tsc_scaling(struct vcpu *v)
     vmx_vmcs_exit(v);
 }
 
-static void vmx_set_tsc_offset(struct vcpu *v, u64 offset, u64 at_tsc)
+static void cf_check vmx_set_tsc_offset(struct vcpu *v, u64 offset, u64 at_tsc)
 {
     vmx_vmcs_enter(v);
 
@@ -1274,7 +1276,7 @@ static void vmx_set_tsc_offset(struct vcpu *v, u64 offset, u64 at_tsc)
     vmx_vmcs_exit(v);
 }
 
-static void vmx_set_rdtsc_exiting(struct vcpu *v, bool_t enable)
+static void cf_check vmx_set_rdtsc_exiting(struct vcpu *v, bool enable)
 {
     vmx_vmcs_enter(v);
     v->arch.hvm.vmx.exec_control &= ~CPU_BASED_RDTSC_EXITING;
@@ -1284,7 +1286,8 @@ static void vmx_set_rdtsc_exiting(struct vcpu *v, bool_t enable)
     vmx_vmcs_exit(v);
 }
 
-static void vmx_set_descriptor_access_exiting(struct vcpu *v, bool enable)
+static void cf_check vmx_set_descriptor_access_exiting(
+    struct vcpu *v, bool enable)
 {
     if ( enable )
         v->arch.hvm.vmx.secondary_exec_control |=
@@ -1298,7 +1301,7 @@ static void vmx_set_descriptor_access_exiting(struct vcpu *v, bool enable)
     vmx_vmcs_exit(v);
 }
 
-static void vmx_init_hypercall_page(void *p)
+static void cf_check vmx_init_hypercall_page(void *p)
 {
     unsigned int i;
 
@@ -1321,7 +1324,7 @@ static void vmx_init_hypercall_page(void *p)
     }
 }
 
-static unsigned int vmx_get_interrupt_shadow(struct vcpu *v)
+static unsigned int cf_check vmx_get_interrupt_shadow(struct vcpu *v)
 {
     unsigned long intr_shadow;
 
@@ -1330,7 +1333,8 @@ static unsigned int vmx_get_interrupt_shadow(struct vcpu *v)
     return intr_shadow;
 }
 
-static void vmx_set_interrupt_shadow(struct vcpu *v, unsigned int intr_shadow)
+static void cf_check vmx_set_interrupt_shadow(
+    struct vcpu *v, unsigned int intr_shadow)
 {
     __vmwrite(GUEST_INTERRUPTIBILITY_INFO, intr_shadow);
 }
@@ -1381,7 +1385,7 @@ static void vmx_load_pdptrs(struct vcpu *v)
     return;
 }
 
-static void vmx_update_host_cr3(struct vcpu *v)
+static void cf_check vmx_update_host_cr3(struct vcpu *v)
 {
     vmx_vmcs_enter(v);
     __vmwrite(HOST_CR3, v->arch.cr3);
@@ -1400,8 +1404,8 @@ void vmx_update_debug_state(struct vcpu *v)
     vmx_vmcs_exit(v);
 }
 
-static void vmx_update_guest_cr(struct vcpu *v, unsigned int cr,
-                                unsigned int flags)
+static void cf_check vmx_update_guest_cr(
+    struct vcpu *v, unsigned int cr, unsigned int flags)
 {
     vmx_vmcs_enter(v);
 
@@ -1603,7 +1607,7 @@ static void vmx_update_guest_cr(struct vcpu *v, unsigned int cr,
     vmx_vmcs_exit(v);
 }
 
-static void vmx_update_guest_efer(struct vcpu *v)
+static void cf_check vmx_update_guest_efer(struct vcpu *v)
 {
     unsigned long entry_ctls, guest_efer = v->arch.hvm.guest_efer,
         xen_efer = read_efer();
@@ -1705,7 +1709,8 @@ void nvmx_enqueue_n2_exceptions(struct vcpu *v,
                  nvmx->intr.intr_info, nvmx->intr.error_code);
 }
 
-static int nvmx_vmexit_event(struct vcpu *v, const struct x86_event *event)
+static int cf_check nvmx_vmexit_event(
+    struct vcpu *v, const struct x86_event *event)
 {
     nvmx_enqueue_n2_exceptions(v, event->vector, event->error_code,
                                hvm_intsrc_none);
@@ -1791,7 +1796,7 @@ void vmx_inject_nmi(void)
  *  - #DB is X86_EVENTTYPE_HW_EXCEPTION, except when generated by
  *    opcode 0xf1 (which is X86_EVENTTYPE_PRI_SW_EXCEPTION)
  */
-static void vmx_inject_event(const struct x86_event *event)
+static void cf_check vmx_inject_event(const struct x86_event *event)
 {
     unsigned long intr_info;
     struct vcpu *curr = current;
@@ -1872,7 +1877,7 @@ static void vmx_inject_event(const struct x86_event *event)
         HVMTRACE_2D(INJ_EXC, _event.vector, _event.error_code);
 }
 
-static bool vmx_event_pending(const struct vcpu *v)
+static bool cf_check vmx_event_pending(const struct vcpu *v)
 {
     unsigned long intr_info;
 
@@ -1882,7 +1887,7 @@ static bool vmx_event_pending(const struct vcpu *v)
     return intr_info & INTR_INFO_VALID_MASK;
 }
 
-static void vmx_set_info_guest(struct vcpu *v)
+static void cf_check vmx_set_info_guest(struct vcpu *v)
 {
     unsigned long intr_shadow;
 
@@ -1910,7 +1915,8 @@ static void vmx_set_info_guest(struct vcpu *v)
     vmx_vmcs_exit(v);
 }
 
-static void vmx_update_eoi_exit_bitmap(struct vcpu *v, uint8_t vector, bool set)
+static void cf_check vmx_update_eoi_exit_bitmap(
+    struct vcpu *v, uint8_t vector, bool set)
 {
     if ( set )
         vmx_set_eoi_exit_bitmap(v, vector);
@@ -1938,7 +1944,7 @@ static u8 set_svi(int isr)
     return old;
 }
 
-static void vmx_process_isr(int isr, struct vcpu *v)
+static void cf_check vmx_process_isr(int isr, struct vcpu *v)
 {
     unsigned int i;
     const struct vlapic *vlapic = vcpu_vlapic(v);
@@ -2026,7 +2032,7 @@ static void __vmx_deliver_posted_interrupt(struct vcpu *v)
     }
 }
 
-static void vmx_deliver_posted_intr(struct vcpu *v, u8 vector)
+static void cf_check vmx_deliver_posted_intr(struct vcpu *v, u8 vector)
 {
     struct pi_desc old, new, prev;
 
@@ -2073,7 +2079,7 @@ static void vmx_deliver_posted_intr(struct vcpu *v, u8 vector)
     __vmx_deliver_posted_interrupt(v);
 }
 
-static void vmx_sync_pir_to_irr(struct vcpu *v)
+static void cf_check vmx_sync_pir_to_irr(struct vcpu *v)
 {
     struct vlapic *vlapic = vcpu_vlapic(v);
     unsigned int group, i;
@@ -2089,12 +2095,12 @@ static void vmx_sync_pir_to_irr(struct vcpu *v)
         vlapic_set_vector(i, &vlapic->regs->data[APIC_IRR]);
 }
 
-static bool vmx_test_pir(const struct vcpu *v, uint8_t vec)
+static bool cf_check vmx_test_pir(const struct vcpu *v, uint8_t vec)
 {
     return pi_test_pir(vec, &v->arch.hvm.vmx.pi_desc);
 }
 
-static void vmx_handle_eoi(uint8_t vector, int isr)
+static void cf_check vmx_handle_eoi(uint8_t vector, int isr)
 {
     uint8_t old_svi = set_svi(isr);
     static bool warned;
@@ -2103,7 +2109,7 @@ static void vmx_handle_eoi(uint8_t vector, int isr)
         printk(XENLOG_WARNING "EOI for %02x but SVI=%02x\n", vector, old_svi);
 }
 
-static void vmx_enable_msr_interception(struct domain *d, uint32_t msr)
+static void cf_check vmx_enable_msr_interception(struct domain *d, uint32_t msr)
 {
     struct vcpu *v;
 
@@ -2111,7 +2117,7 @@ static void vmx_enable_msr_interception(struct domain *d, uint32_t msr)
         vmx_set_msr_intercept(v, msr, VMX_MSR_W);
 }
 
-static void vmx_vcpu_update_eptp(struct vcpu *v)
+static void cf_check vmx_vcpu_update_eptp(struct vcpu *v)
 {
     struct domain *d = v->domain;
     struct p2m_domain *p2m = NULL;
@@ -2136,7 +2142,7 @@ static void vmx_vcpu_update_eptp(struct vcpu *v)
     vmx_vmcs_exit(v);
 }
 
-static void vmx_vcpu_update_vmfunc_ve(struct vcpu *v)
+static void cf_check vmx_vcpu_update_vmfunc_ve(struct vcpu *v)
 {
     struct domain *d = v->domain;
     u32 mask = SECONDARY_EXEC_ENABLE_VM_FUNCTIONS;
@@ -2180,7 +2186,7 @@ static void vmx_vcpu_update_vmfunc_ve(struct vcpu *v)
     vmx_vmcs_exit(v);
 }
 
-static int vmx_vcpu_emulate_vmfunc(const struct cpu_user_regs *regs)
+static int cf_check vmx_vcpu_emulate_vmfunc(const struct cpu_user_regs *regs)
 {
     int rc = X86EMUL_EXCEPTION;
     struct vcpu *curr = current;
@@ -2193,7 +2199,7 @@ static int vmx_vcpu_emulate_vmfunc(const struct cpu_user_regs *regs)
     return rc;
 }
 
-static bool_t vmx_vcpu_emulate_ve(struct vcpu *v)
+static bool cf_check vmx_vcpu_emulate_ve(struct vcpu *v)
 {
     const struct page_info *pg = vcpu_altp2m(v).veinfo_pg;
     ve_info_t *veinfo;
@@ -2230,7 +2236,8 @@ static bool_t vmx_vcpu_emulate_ve(struct vcpu *v)
     return rc;
 }
 
-static bool vmx_get_pending_event(struct vcpu *v, struct x86_event *info)
+static bool cf_check vmx_get_pending_event(
+    struct vcpu *v, struct x86_event *info)
 {
     unsigned long intr_info, error_code;
 
@@ -2267,7 +2274,8 @@ static bool vmx_get_pending_event(struct vcpu *v, struct x86_event *info)
     (RTIT_STATUS_FILTER_EN | RTIT_STATUS_CONTEXT_EN | RTIT_STATUS_TRIGGER_EN | \
      RTIT_STATUS_ERROR | RTIT_STATUS_STOPPED)
 
-static int vmtrace_get_option(struct vcpu *v, uint64_t key, uint64_t *output)
+static int cf_check vmtrace_get_option(
+    struct vcpu *v, uint64_t key, uint64_t *output)
 {
     const struct vcpu_msrs *msrs = v->arch.msrs;
 
@@ -2288,7 +2296,8 @@ static int vmtrace_get_option(struct vcpu *v, uint64_t key, uint64_t *output)
     return 0;
 }
 
-static int vmtrace_set_option(struct vcpu *v, uint64_t key, uint64_t value)
+static int cf_check vmtrace_set_option(
+    struct vcpu *v, uint64_t key, uint64_t value)
 {
     struct vcpu_msrs *msrs = v->arch.msrs;
     bool new_en, old_en = msrs->rtit.ctl & RTIT_CTL_TRACE_EN;
@@ -2342,7 +2351,7 @@ static int vmtrace_set_option(struct vcpu *v, uint64_t key, uint64_t value)
     return 0;
 }
 
-static int vmtrace_control(struct vcpu *v, bool enable, bool reset)
+static int cf_check vmtrace_control(struct vcpu *v, bool enable, bool reset)
 {
     struct vcpu_msrs *msrs = v->arch.msrs;
     uint64_t new_ctl;
@@ -2374,13 +2383,13 @@ static int vmtrace_control(struct vcpu *v, bool enable, bool reset)
     return 0;
 }
 
-static int vmtrace_output_position(struct vcpu *v, uint64_t *pos)
+static int cf_check vmtrace_output_position(struct vcpu *v, uint64_t *pos)
 {
     *pos = v->arch.msrs->rtit.output_offset;
     return v->arch.hvm.vmx.ipt_active;
 }
 
-static int vmtrace_reset(struct vcpu *v)
+static int cf_check vmtrace_reset(struct vcpu *v)
 {
     if ( !v->arch.hvm.vmx.ipt_active )
         return -EINVAL;
@@ -2390,7 +2399,7 @@ static int vmtrace_reset(struct vcpu *v)
     return 0;
 }
 
-static uint64_t vmx_get_reg(struct vcpu *v, unsigned int reg)
+static uint64_t cf_check vmx_get_reg(struct vcpu *v, unsigned int reg)
 {
     struct domain *d = v->domain;
     uint64_t val = 0;
@@ -2429,7 +2438,7 @@ static uint64_t vmx_get_reg(struct vcpu *v, unsigned int reg)
     return val;
 }
 
-static void vmx_set_reg(struct vcpu *v, unsigned int reg, uint64_t val)
+static void cf_check vmx_set_reg(struct vcpu *v, unsigned int reg, uint64_t val)
 {
     struct domain *d = v->domain;
     int rc;
@@ -2823,7 +2832,7 @@ void update_guest_eip(void)
         hvm_inject_hw_exception(TRAP_debug, X86_EVENT_NO_EC);
 }
 
-static void vmx_fpu_dirty_intercept(void)
+static void cf_check vmx_fpu_dirty_intercept(void)
 {
     struct vcpu *curr = current;
 
@@ -2858,7 +2867,7 @@ static void vmx_invlpg_intercept(unsigned long linear)
     paging_invlpg(current, linear);
 }
 
-static void vmx_invlpg(struct vcpu *v, unsigned long linear)
+static void cf_check vmx_invlpg(struct vcpu *v, unsigned long linear)
 {
     if ( cpu_has_vmx_vpid )
         vpid_sync_vcpu_gva(v, linear);
@@ -3184,7 +3193,8 @@ static int is_last_branch_msr(u32 ecx)
     return 0;
 }
 
-static int vmx_msr_read_intercept(unsigned int msr, uint64_t *msr_content)
+static int cf_check vmx_msr_read_intercept(
+    unsigned int msr, uint64_t *msr_content)
 {
     struct vcpu *curr = current;
     uint64_t tmp;
@@ -3387,7 +3397,8 @@ void vmx_vlapic_msr_changed(struct vcpu *v)
     vmx_vmcs_exit(v);
 }
 
-static int vmx_msr_write_intercept(unsigned int msr, uint64_t msr_content)
+static int cf_check vmx_msr_write_intercept(
+    unsigned int msr, uint64_t msr_content)
 {
     struct vcpu *v = current;
     const struct cpuid_policy *cp = v->domain->arch.cpuid;
@@ -3587,7 +3598,7 @@ static void vmx_do_extint(struct cpu_user_regs *regs)
     do_IRQ(regs);
 }
 
-static void vmx_wbinvd_intercept(void)
+static void cf_check vmx_wbinvd_intercept(void)
 {
     if ( !cache_flush_permitted(current->domain) || iommu_snoop )
         return;
diff --git a/xen/arch/x86/hvm/vmx/vvmx.c b/xen/arch/x86/hvm/vmx/vvmx.c
index 7419ee9dd0bc..5f5445147585 100644
--- a/xen/arch/x86/hvm/vmx/vvmx.c
+++ b/xen/arch/x86/hvm/vmx/vvmx.c
@@ -62,7 +62,7 @@ void nvmx_cpu_dead(unsigned int cpu)
     XFREE(per_cpu(vvmcs_buf, cpu));
 }
 
-int nvmx_vcpu_initialise(struct vcpu *v)
+int cf_check nvmx_vcpu_initialise(struct vcpu *v)
 {
     struct domain *d = v->domain;
     struct nestedvmx *nvmx = &vcpu_2_nvmx(v);
@@ -150,7 +150,7 @@ int nvmx_vcpu_initialise(struct vcpu *v)
     return 0;
 }
  
-void nvmx_vcpu_destroy(struct vcpu *v)
+void cf_check nvmx_vcpu_destroy(struct vcpu *v)
 {
     struct nestedvmx *nvmx = &vcpu_2_nvmx(v);
     struct nestedvcpu *nvcpu = &vcpu_nestedhvm(v);
@@ -199,7 +199,7 @@ static void vcpu_relinquish_resources(struct vcpu *v)
     FREE_XENHEAP_PAGE(nvmx->msr_merged);
 }
 
-void nvmx_domain_relinquish_resources(struct domain *d)
+void cf_check nvmx_domain_relinquish_resources(struct domain *d)
 {
     struct vcpu *v;
 
@@ -210,17 +210,17 @@ void nvmx_domain_relinquish_resources(struct domain *d)
     }
 }
 
-int nvmx_vcpu_reset(struct vcpu *v)
+int cf_check nvmx_vcpu_reset(struct vcpu *v)
 {
     return 0;
 }
 
-uint64_t nvmx_vcpu_eptp_base(struct vcpu *v)
+uint64_t cf_check nvmx_vcpu_eptp_base(struct vcpu *v)
 {
     return get_vvmcs(v, EPT_POINTER) & PAGE_MASK;
 }
 
-bool_t nvmx_ept_enabled(struct vcpu *v)
+bool cf_check nvmx_ept_enabled(struct vcpu *v)
 {
     struct nestedvmx *nvmx = &vcpu_2_nvmx(v);
 
@@ -514,7 +514,7 @@ static void vmfail(struct cpu_user_regs *regs, enum vmx_insn_errno errno)
         vmfail_invalid(regs);
 }
 
-bool_t nvmx_intercepts_exception(
+bool cf_check nvmx_intercepts_exception(
     struct vcpu *v, unsigned int vector, int error_code)
 {
     u32 exception_bitmap, pfec_match=0, pfec_mask=0;
@@ -2346,7 +2346,7 @@ int nvmx_msr_read_intercept(unsigned int msr, u64 *msr_content)
  * walk is successful, the translated value is returned in
  * L1_gpa. The result value tells what to do next.
  */
-int nvmx_hap_walk_L1_p2m(
+int cf_check nvmx_hap_walk_L1_p2m(
     struct vcpu *v, paddr_t L2_gpa, paddr_t *L1_gpa, unsigned int *page_order,
     uint8_t *p2m_acc, struct npfec npfec)
 {
diff --git a/xen/arch/x86/include/asm/hvm/svm/nestedsvm.h b/xen/arch/x86/include/asm/hvm/svm/nestedsvm.h
index c3ef2354140c..656d7d1a9a71 100644
--- a/xen/arch/x86/include/asm/hvm/svm/nestedsvm.h
+++ b/xen/arch/x86/include/asm/hvm/svm/nestedsvm.h
@@ -107,22 +107,22 @@ nestedsvm_check_intercepts(struct vcpu *v, struct cpu_user_regs *regs,
 void svm_nested_features_on_efer_update(struct vcpu *v);
 
 /* Interface methods */
-void nsvm_vcpu_destroy(struct vcpu *v);
-int nsvm_vcpu_initialise(struct vcpu *v);
-int nsvm_vcpu_reset(struct vcpu *v);
+void cf_check nsvm_vcpu_destroy(struct vcpu *v);
+int cf_check nsvm_vcpu_initialise(struct vcpu *v);
+int cf_check nsvm_vcpu_reset(struct vcpu *v);
 int nsvm_vcpu_vmrun(struct vcpu *v, struct cpu_user_regs *regs);
-int nsvm_vcpu_vmexit_event(struct vcpu *v, const struct x86_event *event);
-uint64_t nsvm_vcpu_hostcr3(struct vcpu *v);
-bool_t nsvm_vmcb_guest_intercepts_event(
+int cf_check nsvm_vcpu_vmexit_event(struct vcpu *v, const struct x86_event *event);
+uint64_t cf_check nsvm_vcpu_hostcr3(struct vcpu *v);
+bool cf_check nsvm_vmcb_guest_intercepts_event(
     struct vcpu *v, unsigned int vector, int errcode);
-bool_t nsvm_vmcb_hap_enabled(struct vcpu *v);
-enum hvm_intblk nsvm_intr_blocked(struct vcpu *v);
+bool cf_check nsvm_vmcb_hap_enabled(struct vcpu *v);
+enum hvm_intblk cf_check nsvm_intr_blocked(struct vcpu *v);
 
 /* Interrupts, vGIF */
 void svm_vmexit_do_clgi(struct cpu_user_regs *regs, struct vcpu *v);
 void svm_vmexit_do_stgi(struct cpu_user_regs *regs, struct vcpu *v);
 bool_t nestedsvm_gif_isset(struct vcpu *v);
-int nsvm_hap_walk_L1_p2m(
+int cf_check nsvm_hap_walk_L1_p2m(
     struct vcpu *v, paddr_t L2_gpa, paddr_t *L1_gpa, unsigned int *page_order,
     uint8_t *p2m_acc, struct npfec npfec);
 
diff --git a/xen/arch/x86/include/asm/hvm/svm/svm.h b/xen/arch/x86/include/asm/hvm/svm/svm.h
index 09c32044ec8a..65e35a4f59b7 100644
--- a/xen/arch/x86/include/asm/hvm/svm/svm.h
+++ b/xen/arch/x86/include/asm/hvm/svm/svm.h
@@ -50,7 +50,6 @@ struct vcpu;
 
 unsigned long *svm_msrbit(unsigned long *msr_bitmap, uint32_t msr);
 void __update_guest_eip(struct cpu_user_regs *regs, unsigned int inst_len);
-void svm_update_guest_cr(struct vcpu *, unsigned int cr, unsigned int flags);
 
 /*
  * PV context switch helpers.  Prefetching the VMCB area itself has been shown
diff --git a/xen/arch/x86/include/asm/hvm/vmx/vmcs.h b/xen/arch/x86/include/asm/hvm/vmx/vmcs.h
index 03c9ccf627ab..9119aa8536df 100644
--- a/xen/arch/x86/include/asm/hvm/vmx/vmcs.h
+++ b/xen/arch/x86/include/asm/hvm/vmx/vmcs.h
@@ -22,10 +22,10 @@
 
 extern void vmcs_dump_vcpu(struct vcpu *v);
 extern int vmx_vmcs_init(void);
-extern int  vmx_cpu_up_prepare(unsigned int cpu);
-extern void vmx_cpu_dead(unsigned int cpu);
-extern int  vmx_cpu_up(void);
-extern void vmx_cpu_down(void);
+int cf_check vmx_cpu_up_prepare(unsigned int cpu);
+void cf_check vmx_cpu_dead(unsigned int cpu);
+int cf_check vmx_cpu_up(void);
+void cf_check vmx_cpu_down(void);
 
 struct vmcs_struct {
     u32 vmcs_revision_id;
diff --git a/xen/arch/x86/include/asm/hvm/vmx/vmx.h b/xen/arch/x86/include/asm/hvm/vmx/vmx.h
index 97e7652aa12c..5284fe931f62 100644
--- a/xen/arch/x86/include/asm/hvm/vmx/vmx.h
+++ b/xen/arch/x86/include/asm/hvm/vmx/vmx.h
@@ -588,7 +588,7 @@ static inline int __vmxon(u64 addr)
     return rc;
 }
 
-int vmx_guest_x86_mode(struct vcpu *v);
+int cf_check vmx_guest_x86_mode(struct vcpu *v);
 unsigned int vmx_get_cpl(void);
 
 void vmx_inject_extint(int trap, uint8_t source);
diff --git a/xen/arch/x86/include/asm/hvm/vmx/vvmx.h b/xen/arch/x86/include/asm/hvm/vmx/vvmx.h
index e4ca3bc6ee2b..2c3adb5dd6b3 100644
--- a/xen/arch/x86/include/asm/hvm/vmx/vvmx.h
+++ b/xen/arch/x86/include/asm/hvm/vmx/vvmx.h
@@ -84,23 +84,23 @@ union vmx_inst_info {
     u32 word;
 };
 
-int nvmx_vcpu_initialise(struct vcpu *v);
-void nvmx_vcpu_destroy(struct vcpu *v);
-int nvmx_vcpu_reset(struct vcpu *v);
-uint64_t nvmx_vcpu_eptp_base(struct vcpu *v);
-enum hvm_intblk nvmx_intr_blocked(struct vcpu *v);
-bool_t nvmx_intercepts_exception(
+int cf_check nvmx_vcpu_initialise(struct vcpu *v);
+void cf_check nvmx_vcpu_destroy(struct vcpu *v);
+int cf_check nvmx_vcpu_reset(struct vcpu *v);
+uint64_t cf_check nvmx_vcpu_eptp_base(struct vcpu *v);
+enum hvm_intblk cf_check nvmx_intr_blocked(struct vcpu *v);
+bool cf_check nvmx_intercepts_exception(
     struct vcpu *v, unsigned int vector, int error_code);
-void nvmx_domain_relinquish_resources(struct domain *d);
+void cf_check nvmx_domain_relinquish_resources(struct domain *d);
 
-bool_t nvmx_ept_enabled(struct vcpu *v);
+bool cf_check nvmx_ept_enabled(struct vcpu *v);
 
 #define EPT_TRANSLATE_SUCCEED       0
 #define EPT_TRANSLATE_VIOLATION     1
 #define EPT_TRANSLATE_MISCONFIG     2
 #define EPT_TRANSLATE_RETRY         3
 
-int nvmx_hap_walk_L1_p2m(
+int cf_check nvmx_hap_walk_L1_p2m(
     struct vcpu *v, paddr_t L2_gpa, paddr_t *L1_gpa, unsigned int *page_order,
     uint8_t *p2m_acc, struct npfec npfec);
 
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:04:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:04:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271643.466187 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb29-0000AN-8B; Mon, 14 Feb 2022 13:04:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271643.466187; Mon, 14 Feb 2022 13:04:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb28-00009Q-WD; Mon, 14 Feb 2022 13:04:49 +0000
Received: by outflank-mailman (input) for mailman id 271643;
 Mon, 14 Feb 2022 13:04:47 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJb27-0008IH-U8
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:04:47 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ad5bf47e-8d96-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 14:04:46 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ad5bf47e-8d96-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644843886;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=Hp8XnKkx9GSqf6AkS0zSNG6Qc1BDd2mSHAJ1CWLZ67A=;
  b=KEYNINcKXbCFcUlAb0rtyySzGDIHasWKWDgM1YVcXkLuJysbnOhBKttp
   BtTmfQeIkk3O5jh6BdPpz7ZvP3xmAurWb5l40Yf8n7vD0N4/FY4Joyo0O
   wAHPV+dApsf8HWCalLWMKBy9XrWpvdzgc8K+Brhs0jOWA2RKo/l4iszi3
   U=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: b8XcuBXMKkkieRBqBxoKX2f/U+w8fBkueBB1uchr00ZLQ782fgivKa4VtfsQdZ0i8DAAwG1kMo
 DAsIros95B0kTCDCojtIurVtZNbSi0ObYHFMjR6fLElE48qLIiTEbjONBFVdhx5IBDkPEMjgEQ
 WqzRhnQ3RxJPUvMrpREyjJpfyhISYfvCp3yyxHbTGbjJDQImQL6OlTUuQxAvG7E3jnbOBRpE06
 LW3acygO/i7zV3Qn0oP2Y/l8ZQvpImBGYQv0pyLbO7EmYogBnLDEMo1VQosH5qv4Ilm8QTpZhT
 LRossTjr23IIqbplcHVWydFX
X-SBRS: 5.1
X-MesageID: 64149314
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:MGNz2K04BID6lCN9PvbD5cx2kn2cJEfYwER7XKvMYLTBsI5bpzUHy
 GQfCGHTO6uPZWXzft0nYdu0oElQuZeDzIVqSVE6pC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkS5PE3oHJ9RGQ74nRLlbHILOCanAZqTNMEn9700o5wrJh2+aEvPDia++zk
 YKqyyHgEAfNNw5cagr4PIra9XuDFNyr0N8plgRWicJj5TcypFFMZH4rHomjLmOQf2VhNrXSq
 9Avbl2O1jixEx8FUrtJm1tgG6EAaua60QOm0hK6V0U+6/TrS+NbPqsTbZIhhUlrZzqhpftT4
 e1Jk7aKZBo3LI2Wl+FMXxtqKnQrVUFG0OevzXmXtMWSywvNcmf2wuUoB0YzVWEa0r8pWycUr
 6VecW1TKEDY7w616OvTpu1Er8IvNsT0eqgYvWlt12rxBvc6W5HTBa7N4Le02R9u2pkSTK2HO
 6L1bxJDUz/KbwV3HWxIEY5gw+Sxmnn9fiBh/Qf9Sa0fvDGIkV0ZPKLWGMrYfJmGSNtYmm6cp
 3na5CLpDxcCLtudxDGZtHW2iYfycTjTAdxIUufir7gz3QPVljd75AAquUWTm9Kbo3a6ffhlB
 lEK6Ap0oq1j+E6Zd4yoN/Gnm0KsshkZUttWNuQ17gCR16bZizqk6ng4oi1pM4J/6pJvLdA+/
 hrQxo6yW2Qz2FGAYS/Frt+pQSWO1T/5xIPoTQsNVkM77tbqu+nfZTqfH484QMZZYjAYcAwcI
 gxmTgBj3d3/buZRjs1XGGwrZBr2+PD0ovYdvFm/Y45cxloRiHSZT4Kp80PHyv1LMZyUSFKM1
 FBdxZTCs7BeUMzVzXfXKAnoIF1Oz6zbWAAwfHY1R8Vxn9hT0yLLkX9sDMFWex4yb5dslc7Ba
 07PowJBjKK/z1PxBZKbl7mZUpxwpYC5TIyNfqmNMrJmP8ggHCfarXoGTRPBgAjQfL0EzPhX1
 WGzKp33Ux73yM1PkVKLegvq+eF3mH5unz6PLX05pjz+uYejiLeuYe9tGDOzgioRtstoeS3Zr
 IRSMdWk0RJaXLGsayXb69dLf1sLMWI6Fdb9rMkOLryPJQ9vGWcADf7NwOx+J9w5zvoNzuqYr
 GugXkJ4yUbkgSGVIwu9dX0+OqjkWoxyrCxnMHV0b0qowXUqfa2m8LwbK8ksZbAi+eE6lax0Q
 vAJdt+uGPNKTjibqT0RYYOk9N5pdQixhBLINC2gOWBtc5llTg3P29nlYgqwq3VeUnvp7ZMz+
 uTy2BnaTJwPQxVZIPzXMP//nUmsuXU9mf5pWxeaKNdkZ0ixopNhLDb8j6FrLphUewnD3DaTy
 y2fHQwc+bvWu4Yw/dTE2fKEooOuH7csF0ZWBTCGv7O/NC2c9Wu/245QFu2PeGmFBm/z/ayjY
 8RTzu39b6JbzAob7dIkHuY517866vvuu6Ren1ZtE3j8Zli2Dq9tfyud1s5Vu6wRnrJUtGNag
 K5UFgW27VlRBP7YLQ==
IronPort-HdrOrdr: A9a23:yGHfJ6lbxd44LP+EGVWInaMw9+7pDfIu3DAbv31ZSRFFG/Fxl6
 iV8sjztCWE8Qr5N0tBpTntAsW9qDbnhPtICOoqTNGftWvdyQiVxehZhOOIqVDd8m/Fh4pgPM
 9bAs9D4bbLbGSS4/yU3ODBKadD/OW6
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="64149314"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v2 57/70] x86/misc: CFI hardening
Date: Mon, 14 Feb 2022 12:51:14 +0000
Message-ID: <20220214125127.17985-58-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

Control Flow Integrity schemes use toolchain and optionally hardware support
to help protect against call/jump/return oriented programming attacks.

Use cf_check to annotate function pointer targets for the toolchain.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
 xen/arch/x86/extable.c | 4 ++--
 xen/common/efi/boot.c  | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/xen/arch/x86/extable.c b/xen/arch/x86/extable.c
index 51ef863d786c..4d1875585f9d 100644
--- a/xen/arch/x86/extable.c
+++ b/xen/arch/x86/extable.c
@@ -23,7 +23,7 @@ static inline unsigned long ex_cont(const struct exception_table_entry *x)
 	return EX_FIELD(x, cont);
 }
 
-static int init_or_livepatch cmp_ex(const void *a, const void *b)
+static int init_or_livepatch cf_check cmp_ex(const void *a, const void *b)
 {
 	const struct exception_table_entry *l = a, *r = b;
 	unsigned long lip = ex_addr(l);
@@ -37,7 +37,7 @@ static int init_or_livepatch cmp_ex(const void *a, const void *b)
 	return 0;
 }
 
-static void init_or_livepatch swap_ex(void *a, void *b, size_t size)
+static void init_or_livepatch cf_check swap_ex(void *a, void *b, size_t size)
 {
 	struct exception_table_entry *l = a, *r = b, tmp;
 	long delta = b - a;
diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c
index f31f68fd4cd1..4dd5ea6a0602 100644
--- a/xen/common/efi/boot.c
+++ b/xen/common/efi/boot.c
@@ -1497,7 +1497,7 @@ static __init void copy_mapping(unsigned long mfn, unsigned long end,
     unmap_domain_page(l3dst);
 }
 
-static bool __init ram_range_valid(unsigned long smfn, unsigned long emfn)
+static bool __init cf_check ram_range_valid(unsigned long smfn, unsigned long emfn)
 {
     unsigned long sz = pfn_to_pdx(emfn - 1) / PDX_GROUP_COUNT + 1;
 
@@ -1506,7 +1506,7 @@ static bool __init ram_range_valid(unsigned long smfn, unsigned long emfn)
                          pfn_to_pdx(smfn) / PDX_GROUP_COUNT) < sz;
 }
 
-static bool __init rt_range_valid(unsigned long smfn, unsigned long emfn)
+static bool __init cf_check rt_range_valid(unsigned long smfn, unsigned long emfn)
 {
     return true;
 }
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:04:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:04:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271642.466181 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb28-00007L-Rf; Mon, 14 Feb 2022 13:04:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271642.466181; Mon, 14 Feb 2022 13:04:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb28-00007B-OX; Mon, 14 Feb 2022 13:04:48 +0000
Received: by outflank-mailman (input) for mailman id 271642;
 Mon, 14 Feb 2022 13:04:47 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJb27-0008IH-3M
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:04:47 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ae7b14de-8d96-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 14:04:45 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ae7b14de-8d96-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644843885;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=e92OCL5JW96cE+yF15zAo6mkF0e29pgcSSh3YdFWn/0=;
  b=KOwSP+S7PBX11G4DlPNpJYuku9QogWmZwyvy0Ok88/zSyv+2O1UlHhCG
   +RZzxebWCcEgAgfeCrOfzFzAGMfmm14g9wACFMpVkqas4sTjvS4IOuKe5
   szYUy3uV7iDiX/c57PTWsqA/NAjMHpTywhtzMkY8lOsqFCMdlfA56WSl0
   s=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: rQcdzzGVT9+6Jr1mdg/nHbkZS/dqgRwSrlYb3CNg3PlPpzmkbmRD7LtGnH/db0gppo6wneDbNH
 Y3477CXvYxfIQOu1w4SrnJCi9mm/oyfb+zfln9g9XcJaXO6k1cHXU9oFrTgMTwumZil+Vh6N2u
 x0KtuFZlni5d3pg/mKgFTCtKaTclr3TO88gKduDAthTOFL062ja0px35Iz6hgLLqcE5zFL9vGb
 2nfOHa1gwmJkwEy/owP718rwA9I1XsxYnpPBIn1Cek7g0JilQJ/7FMGWws2Zn4ZAOwEGnXZ1af
 lQBTeCeexUWKjt8UhUOI4B6l
X-SBRS: 5.1
X-MesageID: 64050482
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:ccKvm69ZwnNm15vLh4rODrUDnnmTJUtcMsCJ2f8bNWPcYEJGY0x3y
 WVJWWCHOa3eYzf2e9Fzbdvn9xxVupXWx9RrSVQ+/Hg8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhFWeIdA970Ug5w7Rg3tYx6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPh3w
 94W9rCdWDt3L67jyOMSXjd/H3xxaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguwKKsXxMZxZkXZn1TzDVt4tQIzZQrWM7thdtNs1rp4SRauGO
 5pDAdZpREjCZAAUeUw3MZ4vlvu6hHK4SGx1q03A8MLb5ECMlVcsgdABKuH9atGMAMlYgEucj
 mbH5HjiRAEXMsSFzjiI+W7qgfXA9R4XQ6pLSuf+rKQzxgTOmCpDU3X6SGdXv9G/gUXlGP5yO
 nBK6ykB/a89+WKMQoTyCkjQTGG/gjYQXN9ZEusf4Q6Ly7bJ7wvxOlXoXgKte/R96pZoGGVCO
 kuh2oqwWGcx6OH9pWe1q+/MxQ5eLxT5OoPricUsaQIeq+fur4go5v4kZoYySfXl5jEZ9NyZ/
 txrkMTcr+hJ5SLo///ilbwiv95LjsKXJjPZHi2NAgqYAvpRPeZJnbCA51nB9upnJ42EVFSHt
 3Vss5HAsLxRXcHQyXTUG79l8FSVCxGtamO0vLKSN8N5q2TFF4CLIei8Hw2S1G82a51ZKFcFk
 WfYuB9L5Y87AZdZRfQfXm5FMOxzlfKIPY28Dpj8N4MSCrAsJF7v1Hw/Pia4gjGy+HXAZIliY
 P93h+73Vi1EYUmmpRLrL9ogPUgDmHxvmzOLHcqjp/lluJLHDEOopX4+GAPmRogEAGms+W05K
 v5TaJmHzQtxSur7bnWF+IIfNwlSf3M6GYr3u4pccevaelhqH2QoCvnwx7I9etM6w/QJx7mQp
 nztCFVFzFffhGHcLVnYYH5Ud76yD410qmg2PHJwMA/wiWQje4um8IwWa4AzIes87OVmwPMtF
 6sFdsyMD+5hUDPC/zhBP5DxoJY7LEaghB6UPjrjaz86JsYySwvM897iXw3u6ChRUXbn6Zpg+
 +Wtj1qJT4ACSgJuCNftRMiul17h72IAnO9SXlfTJoUBckvb74U3eTf6ieU6Ip9QJEyblCeaz
 QufHTwRufLJ/90u6NDMiK2J89WpHu95EhYIFmXX9+/rZyzT/27lyo5cSueYOzvaUTqsqqmlY
 OxUydD6MeEGwwkW49YtTe4zwPJs/cbrqp9b0h9gTSfCYFmcA799JmWLgJtUvapXy74F4Qa7V
 ypjIDWB1Wll7C89LGMsGQ==
IronPort-HdrOrdr: A9a23:iy2Qaay9i3yZFZLBISe6KrPw1r1zdoMgy1knxilNoHxuH/BwWf
 rPoB17726RtN91YhsdcL+7V5VoLUmzyXcX2/h1AV7BZniEhILAFugLgbcKqweKJ8SUzJ8+6U
 4PSclD4N2bNykGsS75ijPIb+rJFrO8gd+VbeS19QYScelzAZsQiDuQkmygYzZLrA8tP+teKL
 OsovBpihCHYnotYsGyFhA+LpL+T42iruOeXfYebSRXkDWzsQ==
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="64050482"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v2 43/70] x86/mce: CFI hardening
Date: Mon, 14 Feb 2022 12:51:00 +0000
Message-ID: <20220214125127.17985-44-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

Control Flow Integrity schemes use toolchain and optionally hardware support
to help protect against call/jump/return oriented programming attacks.

Use cf_check to annotate function pointer targets for the toolchain.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
 xen/arch/x86/cpu/mcheck/mce.c       |  8 ++++----
 xen/arch/x86/cpu/mcheck/mce.h       |  2 +-
 xen/arch/x86/cpu/mcheck/mce_amd.c   |  9 ++++----
 xen/arch/x86/cpu/mcheck/mce_amd.h   |  4 ++--
 xen/arch/x86/cpu/mcheck/mce_intel.c | 41 +++++++++++++++++--------------------
 5 files changed, 31 insertions(+), 33 deletions(-)

diff --git a/xen/arch/x86/cpu/mcheck/mce.c b/xen/arch/x86/cpu/mcheck/mce.c
index 3467e0f1a315..275c54be7c0f 100644
--- a/xen/arch/x86/cpu/mcheck/mce.c
+++ b/xen/arch/x86/cpu/mcheck/mce.c
@@ -75,7 +75,7 @@ static int __init cf_check mce_set_verbosity(const char *str)
 custom_param("mce_verbosity", mce_set_verbosity);
 
 /* Handle unconfigured int18 (should never happen) */
-static void unexpected_machine_check(const struct cpu_user_regs *regs)
+static void cf_check unexpected_machine_check(const struct cpu_user_regs *regs)
 {
     console_force_unlock();
     printk("Unexpected Machine Check Exception\n");
@@ -469,7 +469,7 @@ static int mce_urgent_action(const struct cpu_user_regs *regs,
 }
 
 /* Shared #MC handler. */
-void mcheck_cmn_handler(const struct cpu_user_regs *regs)
+void cf_check mcheck_cmn_handler(const struct cpu_user_regs *regs)
 {
     static DEFINE_MCE_BARRIER(mce_trap_bar);
     static atomic_t severity_cpu = ATOMIC_INIT(-1);
@@ -1684,7 +1684,7 @@ long cf_check do_mca(XEN_GUEST_HANDLE_PARAM(xen_mc_t) u_xen_mc)
 }
 
 int mcinfo_dumpped;
-static int x86_mcinfo_dump_panic(mctelem_cookie_t mctc)
+static int cf_check x86_mcinfo_dump_panic(mctelem_cookie_t mctc)
 {
     struct mc_info *mcip = mctelem_dataptr(mctc);
 
@@ -1801,7 +1801,7 @@ static enum mce_result mce_action(const struct cpu_user_regs *regs,
  * should be committed for dom0 consumption, 0 if it should be
  * dismissed.
  */
-static int mce_delayed_action(mctelem_cookie_t mctc)
+static int cf_check mce_delayed_action(mctelem_cookie_t mctc)
 {
     enum mce_result result;
     int ret = 0;
diff --git a/xen/arch/x86/cpu/mcheck/mce.h b/xen/arch/x86/cpu/mcheck/mce.h
index 195362691904..535d0abf8f9b 100644
--- a/xen/arch/x86/cpu/mcheck/mce.h
+++ b/xen/arch/x86/cpu/mcheck/mce.h
@@ -70,7 +70,7 @@ extern void x86_mce_vector_register(x86_mce_vector_t);
  * Common generic MCE handler that implementations may nominate
  * via x86_mce_vector_register.
  */
-extern void mcheck_cmn_handler(const struct cpu_user_regs *regs);
+void cf_check mcheck_cmn_handler(const struct cpu_user_regs *regs);
 
 /* Register a handler for judging whether mce is recoverable. */
 typedef bool (*mce_recoverable_t)(uint64_t status);
diff --git a/xen/arch/x86/cpu/mcheck/mce_amd.c b/xen/arch/x86/cpu/mcheck/mce_amd.c
index 279a8e6f122d..d7ae8919df77 100644
--- a/xen/arch/x86/cpu/mcheck/mce_amd.c
+++ b/xen/arch/x86/cpu/mcheck/mce_amd.c
@@ -113,7 +113,7 @@ mc_ec2type(uint16_t errorcode)
     return 0;
 }
 
-bool mc_amd_recoverable_scan(uint64_t status)
+bool cf_check mc_amd_recoverable_scan(uint64_t status)
 {
     bool ret = false;
     enum mc_ec_type ectype;
@@ -143,7 +143,7 @@ bool mc_amd_recoverable_scan(uint64_t status)
     return ret;
 }
 
-bool mc_amd_addrcheck(uint64_t status, uint64_t misc, int addrtype)
+bool cf_check mc_amd_addrcheck(uint64_t status, uint64_t misc, int addrtype)
 {
     enum mc_ec_type ectype;
     uint16_t errorcode;
@@ -216,7 +216,7 @@ static void mcequirk_amd_apply(enum mcequirk_amd_flags flags)
     }
 }
 
-static struct mcinfo_extended *
+static struct mcinfo_extended *cf_check
 amd_f10_handler(struct mc_info *mi, uint16_t bank, uint64_t status)
 {
     struct mcinfo_extended *mc_ext;
@@ -252,7 +252,8 @@ amd_f10_handler(struct mc_info *mi, uint16_t bank, uint64_t status)
     return mc_ext;
 }
 
-static bool amd_need_clearbank_scan(enum mca_source who, uint64_t status)
+static bool cf_check amd_need_clearbank_scan(
+    enum mca_source who, uint64_t status)
 {
     if ( who != MCA_MCE_SCAN )
         return true;
diff --git a/xen/arch/x86/cpu/mcheck/mce_amd.h b/xen/arch/x86/cpu/mcheck/mce_amd.h
index 67c45454707d..c12c25d74567 100644
--- a/xen/arch/x86/cpu/mcheck/mce_amd.h
+++ b/xen/arch/x86/cpu/mcheck/mce_amd.h
@@ -1,7 +1,7 @@
 #ifndef _MCHECK_AMD_H
 #define _MCHECK_AMD_H
 
-bool mc_amd_recoverable_scan(uint64_t status);
-bool mc_amd_addrcheck(uint64_t status, uint64_t misc, int addrtype);
+bool cf_check mc_amd_recoverable_scan(uint64_t status);
+bool cf_check mc_amd_addrcheck(uint64_t status, uint64_t misc, int addrtype);
 
 #endif
diff --git a/xen/arch/x86/cpu/mcheck/mce_intel.c b/xen/arch/x86/cpu/mcheck/mce_intel.c
index 7aaa56fd02eb..50198e0c295c 100644
--- a/xen/arch/x86/cpu/mcheck/mce_intel.c
+++ b/xen/arch/x86/cpu/mcheck/mce_intel.c
@@ -271,12 +271,13 @@ static void intel_memerr_dhandler(
     mc_memerr_dhandler(binfo, result, regs);
 }
 
-static bool intel_srar_check(uint64_t status)
+static bool cf_check intel_srar_check(uint64_t status)
 {
     return (intel_check_mce_type(status) == intel_mce_ucr_srar);
 }
 
-static bool intel_checkaddr(uint64_t status, uint64_t misc, int addrtype)
+static bool cf_check intel_checkaddr(
+    uint64_t status, uint64_t misc, int addrtype)
 {
     if ( !(status & MCi_STATUS_ADDRV) ||
          !(status & MCi_STATUS_MISCV) ||
@@ -287,10 +288,9 @@ static bool intel_checkaddr(uint64_t status, uint64_t misc, int addrtype)
     return (addrtype == MC_ADDR_PHYSICAL);
 }
 
-static void intel_srar_dhandler(
-             struct mca_binfo *binfo,
-             enum mce_result *result,
-             const struct cpu_user_regs *regs)
+static void cf_check intel_srar_dhandler(
+    struct mca_binfo *binfo, enum mce_result *result,
+    const struct cpu_user_regs *regs)
 {
     uint64_t status = binfo->mib->mc_status;
 
@@ -306,15 +306,14 @@ static void intel_srar_dhandler(
     }
 }
 
-static bool intel_srao_check(uint64_t status)
+static bool cf_check intel_srao_check(uint64_t status)
 {
     return (intel_check_mce_type(status) == intel_mce_ucr_srao);
 }
 
-static void intel_srao_dhandler(
-             struct mca_binfo *binfo,
-             enum mce_result *result,
-             const struct cpu_user_regs *regs)
+static void cf_check intel_srao_dhandler(
+    struct mca_binfo *binfo, enum mce_result *result,
+    const struct cpu_user_regs *regs)
 {
     uint64_t status = binfo->mib->mc_status;
 
@@ -333,15 +332,14 @@ static void intel_srao_dhandler(
     }
 }
 
-static bool intel_default_check(uint64_t status)
+static bool cf_check intel_default_check(uint64_t status)
 {
     return true;
 }
 
-static void intel_default_mce_dhandler(
-             struct mca_binfo *binfo,
-             enum mce_result *result,
-             const struct cpu_user_regs * regs)
+static void cf_check intel_default_mce_dhandler(
+    struct mca_binfo *binfo, enum mce_result *result,
+    const struct cpu_user_regs * regs)
 {
     uint64_t status = binfo->mib->mc_status;
     enum intel_mce_type type;
@@ -360,10 +358,9 @@ static const struct mca_error_handler intel_mce_dhandlers[] = {
     {intel_default_check, intel_default_mce_dhandler}
 };
 
-static void intel_default_mce_uhandler(
-             struct mca_binfo *binfo,
-             enum mce_result *result,
-             const struct cpu_user_regs *regs)
+static void cf_check intel_default_mce_uhandler(
+    struct mca_binfo *binfo, enum mce_result *result,
+    const struct cpu_user_regs *regs)
 {
     uint64_t status = binfo->mib->mc_status;
     enum intel_mce_type type;
@@ -396,7 +393,7 @@ static const struct mca_error_handler intel_mce_uhandlers[] = {
  * 3) ser_support = 1, SRAO, UC = 1, S = 1, AR = 0, [EN = 1]
  */
 
-static bool intel_need_clearbank_scan(enum mca_source who, u64 status)
+static bool cf_check intel_need_clearbank_scan(enum mca_source who, u64 status)
 {
     if ( who == MCA_CMCI_HANDLER )
     {
@@ -453,7 +450,7 @@ static bool intel_need_clearbank_scan(enum mca_source who, u64 status)
  * 4) SRAO ser_support = 1, PCC = 0, S = 1, AR = 0, EN = 1 [UC = 1]
  * 5) UCNA ser_support = 1, OVER = 0, EN = 1, PCC = 0, S = 0, AR = 0, [UC = 1]
  */
-static bool intel_recoverable_scan(uint64_t status)
+static bool cf_check intel_recoverable_scan(uint64_t status)
 {
 
     if ( !(status & MCi_STATUS_UC ) )
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:04:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:04:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271644.466203 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb2B-0000hD-CZ; Mon, 14 Feb 2022 13:04:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271644.466203; Mon, 14 Feb 2022 13:04:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb2B-0000h6-8z; Mon, 14 Feb 2022 13:04:51 +0000
Received: by outflank-mailman (input) for mailman id 271644;
 Mon, 14 Feb 2022 13:04:49 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJb29-0008IH-3O
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:04:49 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id af28c3de-8d96-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 14:04:48 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: af28c3de-8d96-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644843887;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=vffdhJkQcOZTM/FEyvATjcefKfxzfQ918n4MAzGwqnA=;
  b=a67BnXivL47UiuEZHpBA79Hs3m/KEqQCmrZO1KtGTSZxqoUNeiMZPM5t
   bJyckYB/Wdh/vp4hARWBbL4HH/imWaBYtsZ0JMjN2febPlovND8380wiu
   yfAiDUFfBXwt7TdRgX56sf009nFe7nZLd13Av40iorAFjDM+HwEE6xhyk
   s=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: sM20GbCcen2mFkHzTNczXs5slIOV5qqFwR8rms/1B4/eg+cCfD95Sx8tlkm9diDSkpu9Kh79KM
 IbXGPszWolfrSTN5A/PLQNqHzUnGh0/dosl4szeLcIDueiGMIRChT85psiBWhE9yDiaAk/Lcg0
 vj9OZ3jqSE6tboicide6kwTDnSUg5ep3g2RMLgKlCBhxSn6BeSwzrwCUh/AkBZcyyvGmd4Ry+g
 8ZwXUSH/kb+V9qSrG1L0ZkqKiMHWim4waoFCd6jf2mvjemmL9JVdfuBeQ3MKSZcMG2OcFOTdNY
 lXKqS5hrHkeupTHBRiWv7ABy
X-SBRS: 5.1
X-MesageID: 64149316
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:qhcvE6yDkFdLcXQflUd6t+cpwSrEfRIJ4+MujC+fZmUNrF6WrkVSy
 DMXWD+HPvaOazPxLop1aoi+8EoOupXUx9JhSwE6qCAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAhLeNYYH1500g7wbdl2tcAbeWRWGthh
 /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL
 wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt5Nv5
 oRMt6Tqcg0SZbXzoOgDWBRqKT4raMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr
 6ZBbmlQMFbT3Ipaw5riIgVoru0lINPmI8U0vXZ4wCuCJf0nXYrCU+PB4towMDIY2JwXQaeFP
 pRxhTxHMzjMYS9PB24tOq0Fsc2OokXubw1BkQfAzUYwyzeKl1EguFT3C/LFd9rPSchLk0Kwo
 mPd43+/EhwcLMaYyzeO7jSrnOCnoM/gcNtMTvvirKcs2QDNgDxIYPELabelibqnpB+/WeoFE
 EYvoTIRlaQs/0GZdMaoCnVUv0W4lhIbXtNRFcgz5weM1rfY7m6lO4QUctJSQId47ZFrHFTGw
 nfMxoq0XmI37NV5XFrAru/8kN+kBcQCwYbujwcgRBBN3dTsqZpbYvnnHoc6S/7dYjEY9FjNL
 9G2QMoW2u97YS0jjfzTEbX7b9WE/Mahc+LNzl+LNl9JFysgDGJfW6Sm6ELA8dFLJ5uDQ1+Ks
 RAswpbCsL9eXczQzHXWGo3h+Y1FAN7fblXhbaNHRcF9p1xBBVb/FWyv3N2ODBgwaZtVEdMYS
 ETSpRlQ9Pdu0IiCNsdKj3aKI51yl8DITI29PtiNN4YmSsUhJWevoXA1DWbNjj+FraTZufxmU
 XttWZ33Vihy5GUO5GfeetrxJpd1mnFglTuLH8iTItbO+eP2WUN5gIwtaDOmBt3VJoveyOkM2
 9oAZcaM1TtFV+jyPnve/YIJdAhYJnknH5Hm7cdQc7fbcAZhHWggDd7XwK8gJNM5z/gEyL+Q8
 yHvQFJcxXr+mWbDdVeAZEd8Ze69Rp14t386Y3AhZA76x3g5bI+zx64DbJ9rL6I//eluwKcsH
 fkIcsmNGNpVTTHD92hPZJXxttU6Jh+qmRiPL2yuZz1mJ8xsQAnA+9nFeArz9XZRUnrr5JVm+
 7D5j1HVW5sOQQhmHf36UvP3wgPjp2UZlcJzQ1DMfotZdnLz/dU4MCf2lPI2fZ0BcE2R2juA2
 g+KKh4Evu2R8ZQt+dzEiK3Y/YekF+xyQhhTE2XBtOvkMCDb+iyowJNaUfbOdjfYDTum9KKnb
 ORT7vf9LPxYwwoa79siS+5mnfAk+t/ih75G1QA1TnzEYmOiBq5kPnTbj9JEsbdAx+MBtAa7M
 q5VFgK25Vld1BvZLWMs
IronPort-HdrOrdr: A9a23:D+YHTa9R+7BH4lPnc1Nuk+DaI+orL9Y04lQ7vn2YSXRuHPBw9v
 re5cjzuiWVtN98Yh0dcJW7Scy9qBDnhPhICOsqTNSftWDd0QPCRuxfBMnZslnd8kXFh4lgPM
 xbEpSWZueeMbEDt7eZ3DWF
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="64149316"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v2 26/70] xen/decompress: CFI hardening
Date: Mon, 14 Feb 2022 12:50:43 +0000
Message-ID: <20220214125127.17985-27-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

Control Flow Integrity schemes use toolchain and optionally hardware support
to help protect against call/jump/return oriented programming attacks.

Use cf_check to annotate function pointer targets for the toolchain.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
 xen/common/bunzip2.c            | 2 +-
 xen/common/decompress.c         | 2 +-
 xen/common/unlzma.c             | 2 +-
 xen/common/zstd/zstd_common.c   | 4 ++--
 xen/common/zstd/zstd_internal.h | 4 ++--
 5 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/xen/common/bunzip2.c b/xen/common/bunzip2.c
index 2087cfbbedc8..782b589a8b01 100644
--- a/xen/common/bunzip2.c
+++ b/xen/common/bunzip2.c
@@ -607,7 +607,7 @@ static int __init read_bunzip(struct bunzip_data *bd, unsigned char *outbuf, int
 	goto decode_next_byte;
 }
 
-static int __init nofill(void *buf, unsigned int len)
+static int __init cf_check nofill(void *buf, unsigned int len)
 {
 	return -1;
 }
diff --git a/xen/common/decompress.c b/xen/common/decompress.c
index 79e60f4802d5..989336983f61 100644
--- a/xen/common/decompress.c
+++ b/xen/common/decompress.c
@@ -3,7 +3,7 @@
 #include <xen/string.h>
 #include <xen/decompress.h>
 
-static void __init error(const char *msg)
+static void __init cf_check error(const char *msg)
 {
     printk("%s\n", msg);
 }
diff --git a/xen/common/unlzma.c b/xen/common/unlzma.c
index d0ef78eef0d1..6cd99023adf6 100644
--- a/xen/common/unlzma.c
+++ b/xen/common/unlzma.c
@@ -76,7 +76,7 @@ struct rc {
 #define RC_MODEL_TOTAL_BITS 11
 
 
-static int __init nofill(void *buffer, unsigned int len)
+static int __init cf_check nofill(void *buffer, unsigned int len)
 {
 	return -1;
 }
diff --git a/xen/common/zstd/zstd_common.c b/xen/common/zstd/zstd_common.c
index 9a85e938cdd6..5c44e5db7671 100644
--- a/xen/common/zstd/zstd_common.c
+++ b/xen/common/zstd/zstd_common.c
@@ -54,12 +54,12 @@ void *__init ZSTD_stackAllocAll(void *opaque, size_t *size)
 	return stack_push(stack, *size);
 }
 
-void *__init ZSTD_stackAlloc(void *opaque, size_t size)
+void *__init cf_check ZSTD_stackAlloc(void *opaque, size_t size)
 {
 	ZSTD_stack *stack = (ZSTD_stack *)opaque;
 	return stack_push(stack, size);
 }
-void __init ZSTD_stackFree(void *opaque, void *address)
+void __init cf_check ZSTD_stackFree(void *opaque, void *address)
 {
 	(void)opaque;
 	(void)address;
diff --git a/xen/common/zstd/zstd_internal.h b/xen/common/zstd/zstd_internal.h
index b7dd14f6ce79..94f8c586220e 100644
--- a/xen/common/zstd/zstd_internal.h
+++ b/xen/common/zstd/zstd_internal.h
@@ -351,8 +351,8 @@ typedef struct {
 ZSTD_customMem ZSTD_initStack(void *workspace, size_t workspaceSize);
 
 void *ZSTD_stackAllocAll(void *opaque, size_t *size);
-void *ZSTD_stackAlloc(void *opaque, size_t size);
-void ZSTD_stackFree(void *opaque, void *address);
+void *cf_check ZSTD_stackAlloc(void *opaque, size_t size);
+void cf_check ZSTD_stackFree(void *opaque, void *address);
 
 /*======  common function  ======*/
 
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:04:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:04:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271645.466208 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb2B-0000js-Pt; Mon, 14 Feb 2022 13:04:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271645.466208; Mon, 14 Feb 2022 13:04:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb2B-0000jP-IR; Mon, 14 Feb 2022 13:04:51 +0000
Received: by outflank-mailman (input) for mailman id 271645;
 Mon, 14 Feb 2022 13:04:49 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJb29-0008IH-LL
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:04:49 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id af782393-8d96-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 14:04:48 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: af782393-8d96-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644843888;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=BEoNz1G1VEb1PvMVHl3dUIUZku1FDM+32RnsoUebuRQ=;
  b=JpfsnV0I4ACv5kyo+ixL2GWs1tBqlly6FtEObKMqncdivA8rw7A0BJ/L
   trlnzdHdD3UziKDVAs1TLv5iUltIfFUTFVKEg0zim8tBSXoEOQh9nJOxM
   fVdk471ds+H3Fx3ciFJ9CEkfuiSUye9SBNabxVQtPb1KL/iAAskQMc+rk
   c=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: PmpWHPe03+VbbIE8oS71P1YGSlFsPbH89gQw0QKTwC1T5H0nJ9d2eaFOerhhj1Ah1qQnKJENtV
 MpRBfFGnvfyed4YbBcjHH0BgfNLvImeqtPHMzvTttRCI7rCoIJkHz932whdopODlUl7pG1czdn
 9+AA9t4cqorIciBtMdP9cx57Db7benA5L3uTaylXG57W2QWmOJW6Yg7seuVdSaaGJmougDINAJ
 rH20FV5qvSEvCsesfmGrjG/Zs6Ti0kQ0SsfODw6APf/I0laBbDntFLdv/iBgXpSwkRalj5X/E9
 tgAnKaKKSCEbCQs5QgfSEbhJ
X-SBRS: 5.1
X-MesageID: 64149632
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:sJNihKpkBnGbHDq2jI9fCPpKaWdeBmIGYhIvgKrLsJaIsI4StFCzt
 garIBmCa6uPYDbzL98kbo23pBxVsMDVzdMwGlFrris1RCxD9JuZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlZT4vE2xbuKU5NTsY0idfic5Dndx4f5fs7Rh2NQw24HlW1rlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCnZK+axwJGaHdorsmdUNCLjN7IY9IxLCSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFKoZtmtt0nfyCvE+TIqYa67L+cVZzHE7gcUm8fP2O
 ZZANWsxN06ojxtnOGcPGpwek8qRn3zeai9mklu8oYQe2j2GpOB2+Oe0a4eEEjCQfu1Fk0Ddq
 m/Y8mDRBhABKMfZ2TeD6mirhOLEgWX8Qo16KVGj3qc02hvJnDVVUUBIEwvgyRWktqKgc9xRC
 Vc03SY/l/cJ0haxc8v4Qz+2nHHR63bwROFsO+E97QiMzI/d7ACYGnUIQ1Z9VTA2iCMlbWd0j
 wHUxrsFERQq6eTIEizFqt94uBvvYXB9EIMUWcMToeLpCfHHqZp7sB/AR80L/EWd3oysQmGYL
 9xnQUEDa1QvYSwjiv/TEbPv2WvESn31oukdvFu/Y45dxlklDLNJnqTxgbQh0d5OLZyCUn6Kt
 2Uels6V4YgmVM/RyHPdELhQROjyvZ5p1QEwZnY1QfEcG8mFoSb/Lei8HhkiTKuWDir0UWCwO
 xKC0e+gzJRSIGGrfcdKj3GZUKwXIVzbPY29DJj8N4MWCrAoLVPv1Hw+NCa4gjG2+GBxwP5XB
 HtuWZv1ZZrsIf88l2TeqiZ0+eJD+x3SMkuNGcGln0z/i+L2ibz8Ye5tDWZip9sRtMusyDg5O
 f4GXydT4xkAAuD4fAfN9osfcQIDIXQhXMikoM1LbO+TZAFhHTh5WfPWxLogfa1jnrhUybiUr
 i3sBBcAxQqtn2DDJCWLdmtnNOHlU6FgoC9pJicrJ1uphSQuON798KcFepIrVrA77+g/n+VsR
 vwIdpzYUPRCQzjK4RoHapz5oNAwfRinn1vWbSGkfCI+b9hrQAmQoo3oeQ7m9S8vCCurtJRh/
 +38h12DGZdaHlZsFsfbbv6r3midh3lFlbIgRVbML/lSZF7orNpgJRvug6JlOMoLMxjCmGeXj
 l7EHRcCqODRiIYp692V17ucpoKkHuYiTEpXG27XseS/OSXApzfxxIZBVKCDfCzHVXOy86KnP
 L0Hw/b5OfwBvVBLr4sjTOo7kfNgv4Pi9+1A0wBpPHTXdFD6WLpvL06P0dRLqqAQlKRSvhG7W
 x7X99RXUVlT1BgJzLLFyNIZU9m+
IronPort-HdrOrdr: A9a23:F1g3+asH0y7UsJN15xlOxFFn7skDdNV00zEX/kB9WHVpmszxra
 6TdZUgpGbJYVkqOE3I9ertBEDEewK4yXcX2/h2AV7BZniEhILAFugLhuGO/9SjIVybygc079
 YGT0EUMrzN5DZB4voSmDPIceod/A==
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="64149632"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v2 36/70] x86/power: CFI hardening
Date: Mon, 14 Feb 2022 12:50:53 +0000
Message-ID: <20220214125127.17985-37-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

Control Flow Integrity schemes use toolchain and optionally hardware support
to help protect against call/jump/return oriented programming attacks.

Use cf_check to annotate function pointer targets for the toolchain.

cpufreq_governor_dbs() has no external callers so make it static.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
 xen/arch/x86/acpi/cpufreq/cpufreq.c    | 14 +++++++-------
 xen/arch/x86/acpi/cpufreq/powernow.c   | 15 ++++++++-------
 xen/common/core_parking.c              |  4 ++--
 xen/drivers/cpufreq/cpufreq_ondemand.c |  6 ++++--
 xen/include/acpi/cpufreq/cpufreq.h     |  1 -
 5 files changed, 21 insertions(+), 19 deletions(-)

diff --git a/xen/arch/x86/acpi/cpufreq/cpufreq.c b/xen/arch/x86/acpi/cpufreq/cpufreq.c
index 8133c2dd958c..c27cbb2304f2 100644
--- a/xen/arch/x86/acpi/cpufreq/cpufreq.c
+++ b/xen/arch/x86/acpi/cpufreq/cpufreq.c
@@ -320,7 +320,7 @@ unsigned int get_measured_perf(unsigned int cpu, unsigned int flag)
     return policy->cpuinfo.max_freq * perf_percent / 100;
 }
 
-static unsigned int get_cur_freq_on_cpu(unsigned int cpu)
+static unsigned int cf_check get_cur_freq_on_cpu(unsigned int cpu)
 {
     struct cpufreq_policy *policy;
     struct acpi_cpufreq_data *data;
@@ -369,8 +369,9 @@ static unsigned int check_freqs(const cpumask_t *mask, unsigned int freq,
     return 0;
 }
 
-static int acpi_cpufreq_target(struct cpufreq_policy *policy,
-                               unsigned int target_freq, unsigned int relation)
+static int cf_check acpi_cpufreq_target(
+    struct cpufreq_policy *policy,
+    unsigned int target_freq, unsigned int relation)
 {
     struct acpi_cpufreq_data *data = cpufreq_drv_data[policy->cpu];
     struct processor_performance *perf;
@@ -449,7 +450,7 @@ static int acpi_cpufreq_target(struct cpufreq_policy *policy,
     return result;
 }
 
-static int acpi_cpufreq_verify(struct cpufreq_policy *policy)
+static int cf_check acpi_cpufreq_verify(struct cpufreq_policy *policy)
 {
     struct acpi_cpufreq_data *data;
     struct processor_performance *perf;
@@ -494,8 +495,7 @@ acpi_cpufreq_guess_freq(struct acpi_cpufreq_data *data, unsigned int cpu)
     }
 }
 
-static int 
-acpi_cpufreq_cpu_init(struct cpufreq_policy *policy)
+static int cf_check acpi_cpufreq_cpu_init(struct cpufreq_policy *policy)
 {
     unsigned int i;
     unsigned int valid_states = 0;
@@ -609,7 +609,7 @@ acpi_cpufreq_cpu_init(struct cpufreq_policy *policy)
     return result;
 }
 
-static int acpi_cpufreq_cpu_exit(struct cpufreq_policy *policy)
+static int cf_check acpi_cpufreq_cpu_exit(struct cpufreq_policy *policy)
 {
     struct acpi_cpufreq_data *data = cpufreq_drv_data[policy->cpu];
 
diff --git a/xen/arch/x86/acpi/cpufreq/powernow.c b/xen/arch/x86/acpi/cpufreq/powernow.c
index ca71ecf72d67..d4c7dcd5d99d 100644
--- a/xen/arch/x86/acpi/cpufreq/powernow.c
+++ b/xen/arch/x86/acpi/cpufreq/powernow.c
@@ -67,8 +67,8 @@ static void cf_check update_cpb(void *data)
     }
 }
 
-static int powernow_cpufreq_update (int cpuid,
-				     struct cpufreq_policy *policy)
+static int cf_check powernow_cpufreq_update(
+    int cpuid, struct cpufreq_policy *policy)
 {
     if (!cpumask_test_cpu(cpuid, &cpu_online_map))
         return -EINVAL;
@@ -78,8 +78,9 @@ static int powernow_cpufreq_update (int cpuid,
     return 0;
 }
 
-static int powernow_cpufreq_target(struct cpufreq_policy *policy,
-                               unsigned int target_freq, unsigned int relation)
+static int cf_check powernow_cpufreq_target(
+    struct cpufreq_policy *policy,
+    unsigned int target_freq, unsigned int relation)
 {
     struct acpi_cpufreq_data *data = cpufreq_drv_data[policy->cpu];
     struct processor_performance *perf;
@@ -180,7 +181,7 @@ static void cf_check get_cpu_data(void *arg)
         amd_fixup_frequency(&perf->states[i]);
 }
 
-static int powernow_cpufreq_verify(struct cpufreq_policy *policy)
+static int cf_check powernow_cpufreq_verify(struct cpufreq_policy *policy)
 {
     struct acpi_cpufreq_data *data;
     struct processor_performance *perf;
@@ -197,7 +198,7 @@ static int powernow_cpufreq_verify(struct cpufreq_policy *policy)
     return cpufreq_frequency_table_verify(policy, data->freq_table);
 }
 
-static int powernow_cpufreq_cpu_init(struct cpufreq_policy *policy)
+static int cf_check powernow_cpufreq_cpu_init(struct cpufreq_policy *policy)
 {
     unsigned int i;
     unsigned int valid_states = 0;
@@ -303,7 +304,7 @@ static int powernow_cpufreq_cpu_init(struct cpufreq_policy *policy)
     return result;
 }
 
-static int powernow_cpufreq_cpu_exit(struct cpufreq_policy *policy)
+static int cf_check powernow_cpufreq_cpu_exit(struct cpufreq_policy *policy)
 {
     struct acpi_cpufreq_data *data = cpufreq_drv_data[policy->cpu];
 
diff --git a/xen/common/core_parking.c b/xen/common/core_parking.c
index 4afad04f2f68..c4f01291c0be 100644
--- a/xen/common/core_parking.c
+++ b/xen/common/core_parking.c
@@ -53,7 +53,7 @@ static int __init cf_check setup_core_parking_option(const char *str)
 }
 custom_param("core_parking", setup_core_parking_option);
 
-static unsigned int core_parking_performance(unsigned int event)
+static unsigned int cf_check core_parking_performance(unsigned int event)
 {
     unsigned int cpu = -1;
 
@@ -111,7 +111,7 @@ static unsigned int core_parking_performance(unsigned int event)
     return cpu;
 }
 
-static unsigned int core_parking_power(unsigned int event)
+static unsigned int cf_check core_parking_power(unsigned int event)
 {
     unsigned int cpu = -1;
 
diff --git a/xen/drivers/cpufreq/cpufreq_ondemand.c b/xen/drivers/cpufreq/cpufreq_ondemand.c
index ba03eaa2336d..fbcd14d6c32f 100644
--- a/xen/drivers/cpufreq/cpufreq_ondemand.c
+++ b/xen/drivers/cpufreq/cpufreq_ondemand.c
@@ -215,7 +215,8 @@ static void dbs_timer_exit(struct cpu_dbs_info_s *dbs_info)
     kill_timer(&per_cpu(dbs_timer, dbs_info->cpu));
 }
 
-int cpufreq_governor_dbs(struct cpufreq_policy *policy, unsigned int event)
+static int cf_check cpufreq_governor_dbs(
+    struct cpufreq_policy *policy, unsigned int event)
 {
     unsigned int cpu = policy->cpu;
     struct cpu_dbs_info_s *this_dbs_info;
@@ -307,7 +308,8 @@ int cpufreq_governor_dbs(struct cpufreq_policy *policy, unsigned int event)
     return 0;
 }
 
-static bool_t __init cpufreq_dbs_handle_option(const char *name, const char *val)
+static bool __init cf_check cpufreq_dbs_handle_option(
+    const char *name, const char *val)
 {
     if ( !strcmp(name, "rate") && val )
     {
diff --git a/xen/include/acpi/cpufreq/cpufreq.h b/xen/include/acpi/cpufreq/cpufreq.h
index 4958d3f7d315..e5e58c6c30ea 100644
--- a/xen/include/acpi/cpufreq/cpufreq.h
+++ b/xen/include/acpi/cpufreq/cpufreq.h
@@ -227,7 +227,6 @@ struct cpu_dbs_info_s {
     int8_t stoppable;
 };
 
-int cpufreq_governor_dbs(struct cpufreq_policy *policy, unsigned int event);
 int get_cpufreq_ondemand_para(uint32_t *sampling_rate_max,
                               uint32_t *sampling_rate_min,
                               uint32_t *sampling_rate,
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:04:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:04:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271646.466225 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb2F-0001LL-5C; Mon, 14 Feb 2022 13:04:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271646.466225; Mon, 14 Feb 2022 13:04:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb2F-0001L9-1C; Mon, 14 Feb 2022 13:04:55 +0000
Received: by outflank-mailman (input) for mailman id 271646;
 Mon, 14 Feb 2022 13:04:53 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJb2D-0008IH-7c
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:04:53 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b1c1c827-8d96-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 14:04:51 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b1c1c827-8d96-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644843891;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=DcxCCbUcz9kGC1s+CalTd9n61kMqs4eclO1Ue2UkPFk=;
  b=ghlbEI80/nXbYYr+FNiOll1AC/zdGWgpk38jVi1VMITYTFvBGhzn2dhi
   oDN+wWttEVIXY6RYgNf8w+DBGjCP1a+C1iiMB4GQpnW4oigPbtvVwEKeT
   5Uc8BG16AUuPY6xkGjUTNSz+NyHuwqjtLomk3ikA1kp/wh07TKX/jRBtw
   8=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: eEZUEZ9Ij573N0JqESrw5UF2ReAltDdmaV5bWfH2TWTP+RGFhmvJ0pOYJQcjDiiG3QQ/G3VvXt
 hEZUlXCwOc9/GjmZn1rx8i7okXz2WSoPYoDH9pLGLCrjVcUy+uawz+PzpHGQJF4c25sMX9oeX9
 h1D8U/ZsotXm45SqFQyYrj+mM/cNBInZHWnRVdVZEIzP80pm+SeHeXyqDl8c7TJpqpRNqseJUD
 riZDR/36Yk8WcmXBGnpPoIYWt3wgwGiO0svAvFurf0ofJWbQQ+pwlCg9R3Y7C3EbF14zljAfQ8
 82YMjWj9vWwnEagY6TupmSIF
X-SBRS: 5.1
X-MesageID: 64050489
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:62nNwK8ng0wTRPQQI6j+DrUDn3mTJUtcMsCJ2f8bNWPcYEJGY0x3x
 mYcDT2OMv+NZWr3Kdl0Oouxpk0CuJXQz9dkTgE6rn08E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhFWeIdA970Ug5w7Rg3tYx6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhz9
 41z6beBEj14AYvuse43fDRyPQFXaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguwKKsXxMZxZkXZn1TzDVt4tQIzZQrWM7thdtNs1rp4SRauGO
 5pIAdZpRDiaZRcIE1cGM48Rn+aSmnr/SwdkoXvA8MLb5ECMlVcsgdABKuH9atGMAMlYgEucj
 mbH5HjiRAEXMsSFzjiI+W7qgfXA9R4XQ6pLSuf+rKQzxgTOmCpDU3X6SGdXv9G7tRaAB/luc
 HZFxQwMhKIY22GBYPnUCkjQTGG/gjYQXN9ZEusf4Q6Ly7bJ7wvxOlXoXgKte/R96pZoGGVCO
 kuh2oqwWGcx6OH9pWe1q+/MxQ5eLxT5OoPricUsaQIeq+fur4go5v4kZoYySfXl5jEZ9NyZ/
 txrkMTcr+hJ5SLo///ilbwiv95LjsKXJjPZHi2NAgqYAvpRPeZJnbCA51nB9upnJ42EVFSHt
 3Vss5HAsLxRXcHQyXTUG79l8FSVCxGtamO0vLKSN8N5q2TFF4CLIei8Hw2S1G82a51ZKFcFk
 WfYuB9L5Y87AZdZRfQfXm5FMOxzlfKIPY28Dpj8N4MSCrAsJF7v1Hw/Pia4gjGy+HXAZIliY
 P93h+73Vi1EYUmmpRLrL9ogPUgDmHxgmzOJGMyTItbO+eP2WUN5gIwtaDOmBt3VJovYyOkM2
 9oAZcaM1TtFV+jyPnve/YIJdAhYJnknH5Hm7cdQc7fbcAZhHWggDd7XwK8gJNM5z/gEyL+Q8
 yHvQFJcxXr+mWbDdVeAZEd8Ze69Rp14t386Y3AhZA76x3g5bI+zx64DbJ9rL6I//eluwKcsH
 fkIcsmNGNpVTTHD92hPZJXxttU6Jh+qmRiPL2yuZz1mJ8xsQAnA+9nFeArz9XZRUnrr5JVm+
 7D5j1HVW5sOQQhmHf36UvP3wgPjp2UZlcJzQ1DMfotZdnLz/dU4MCf2lPI2fZ0BcE2R2juA2
 g+KKh4Evu2R8ZQt+dzEiK3Y/YekF+xyQhhTE2XBtOvkMCDb+iyowJNaUfbOdjfYDTum9KKnb
 ORT7vf9LPxYwwoa79siS+5mnfAk+t/ih75G1QA1TnzEYmOiBq5kPnTbj9JEsbdAx+MBtAa7M
 q5VFgK25Vld1BvZLWMs
IronPort-HdrOrdr: A9a23:6uJ/H60XEe0sUYgDeKx0tQqjBLAkLtp133Aq2lEZdPRUGvb3qy
 nOpoVj6faaslYssR0b9exofZPwJE80lqQFh7X5X43SPzUO0VHAROoJgLcKgQeQfxEWntQtsp
 uIGJIeNDSfNzdHZL7BkWuFL+o=
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="64050489"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v2 48/70] x86/shadow: CFI hardening
Date: Mon, 14 Feb 2022 12:51:05 +0000
Message-ID: <20220214125127.17985-49-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

Control Flow Integrity schemes use toolchain and optionally hardware support
to help protect against call/jump/return oriented programming attacks.

Use cf_check to annotate function pointer targets for the toolchain.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
 xen/arch/x86/mm/shadow/common.c  | 11 +++---
 xen/arch/x86/mm/shadow/hvm.c     |  8 ++--
 xen/arch/x86/mm/shadow/multi.c   | 80 ++++++++++++++++++++--------------------
 xen/arch/x86/mm/shadow/multi.h   | 20 +++++-----
 xen/arch/x86/mm/shadow/private.h | 12 +++---
 xen/arch/x86/mm/shadow/pv.c      |  4 +-
 6 files changed, 67 insertions(+), 68 deletions(-)

diff --git a/xen/arch/x86/mm/shadow/common.c b/xen/arch/x86/mm/shadow/common.c
index 071a19adce82..8f111901730f 100644
--- a/xen/arch/x86/mm/shadow/common.c
+++ b/xen/arch/x86/mm/shadow/common.c
@@ -1215,7 +1215,7 @@ void shadow_free(struct domain *d, mfn_t smfn)
  * This action is irreversible: the p2m mapping only ever grows.
  * That's OK because the p2m table only exists for translated domains,
  * and those domains can't ever turn off shadow mode. */
-static struct page_info *
+static struct page_info *cf_check
 shadow_alloc_p2m_page(struct domain *d)
 {
     struct page_info *pg;
@@ -1251,7 +1251,7 @@ shadow_alloc_p2m_page(struct domain *d)
     return pg;
 }
 
-static void
+static void cf_check
 shadow_free_p2m_page(struct domain *d, struct page_info *pg)
 {
     struct domain *owner = page_get_owner(pg);
@@ -2290,7 +2290,8 @@ void shadow_prepare_page_type_change(struct domain *d, struct page_info *page,
 /* Reset the up-pointers of every L3 shadow to 0.
  * This is called when l3 shadows stop being pinnable, to clear out all
  * the list-head bits so the up-pointer field is properly inititalised. */
-static int sh_clear_up_pointer(struct vcpu *v, mfn_t smfn, mfn_t unused)
+static int cf_check sh_clear_up_pointer(
+    struct vcpu *v, mfn_t smfn, mfn_t unused)
 {
     mfn_to_page(smfn)->up = 0;
     return 0;
@@ -2490,7 +2491,7 @@ static void sh_update_paging_modes(struct vcpu *v)
     v->arch.paging.mode->update_cr3(v, 0, false);
 }
 
-void shadow_update_paging_modes(struct vcpu *v)
+void cf_check shadow_update_paging_modes(struct vcpu *v)
 {
     paging_lock(v->domain);
     sh_update_paging_modes(v);
@@ -3075,7 +3076,7 @@ static bool flush_vcpu(const struct vcpu *v, const unsigned long *vcpu_bitmap)
 }
 
 /* Flush TLB of selected vCPUs.  NULL for all. */
-bool shadow_flush_tlb(const unsigned long *vcpu_bitmap)
+bool cf_check shadow_flush_tlb(const unsigned long *vcpu_bitmap)
 {
     static DEFINE_PER_CPU(cpumask_t, flush_cpumask);
     cpumask_t *mask = &this_cpu(flush_cpumask);
diff --git a/xen/arch/x86/mm/shadow/hvm.c b/xen/arch/x86/mm/shadow/hvm.c
index c90d326becb3..27dd99f1a12e 100644
--- a/xen/arch/x86/mm/shadow/hvm.c
+++ b/xen/arch/x86/mm/shadow/hvm.c
@@ -794,9 +794,9 @@ sh_remove_all_shadows_and_parents(struct domain *d, mfn_t gmfn)
      * It means extra emulated writes and slows down removal of mappings. */
 }
 
-static void sh_unshadow_for_p2m_change(struct domain *d, unsigned long gfn,
-                                       l1_pgentry_t old, l1_pgentry_t new,
-                                       unsigned int level)
+static void cf_check sh_unshadow_for_p2m_change(
+    struct domain *d, unsigned long gfn, l1_pgentry_t old, l1_pgentry_t new,
+    unsigned int level)
 {
     mfn_t omfn = l1e_get_mfn(old);
     unsigned int oflags = l1e_get_flags(old);
@@ -879,7 +879,7 @@ static void sh_unshadow_for_p2m_change(struct domain *d, unsigned long gfn,
 }
 
 #if (SHADOW_OPTIMIZATIONS & SHOPT_FAST_FAULT_PATH)
-static void
+static void cf_check
 sh_write_p2m_entry_post(struct p2m_domain *p2m, unsigned int oflags)
 {
     struct domain *d = p2m->domain;
diff --git a/xen/arch/x86/mm/shadow/multi.c b/xen/arch/x86/mm/shadow/multi.c
index bddef53163f5..b0b1c31ee033 100644
--- a/xen/arch/x86/mm/shadow/multi.c
+++ b/xen/arch/x86/mm/shadow/multi.c
@@ -369,7 +369,7 @@ static void sh_audit_gw(struct vcpu *v, const walk_t *gw)
 
 #if GUEST_PAGING_LEVELS == 2
 /* From one page of a multi-page shadow, find the next one */
-static inline mfn_t sh_next_page(mfn_t smfn)
+static inline mfn_t cf_check sh_next_page(mfn_t smfn)
 {
     struct page_info *pg = mfn_to_page(smfn), *next;
     struct page_list_head h = PAGE_LIST_HEAD_INIT(h);
@@ -399,8 +399,7 @@ guest_index(void *ptr)
     return (u32)((unsigned long)ptr & ~PAGE_MASK) / sizeof(guest_l1e_t);
 }
 
-static u32
-shadow_l1_index(mfn_t *smfn, u32 guest_index)
+static u32 cf_check shadow_l1_index(mfn_t *smfn, u32 guest_index)
 {
 #if (GUEST_PAGING_LEVELS == 2)
     ASSERT(mfn_to_page(*smfn)->u.sh.head);
@@ -412,8 +411,7 @@ shadow_l1_index(mfn_t *smfn, u32 guest_index)
 #endif
 }
 
-static u32
-shadow_l2_index(mfn_t *smfn, u32 guest_index)
+static u32 cf_check shadow_l2_index(mfn_t *smfn, u32 guest_index)
 {
 #if (GUEST_PAGING_LEVELS == 2)
     int i;
@@ -432,14 +430,12 @@ shadow_l2_index(mfn_t *smfn, u32 guest_index)
 
 #if GUEST_PAGING_LEVELS >= 4
 
-static u32
-shadow_l3_index(mfn_t *smfn, u32 guest_index)
+static u32 cf_check shadow_l3_index(mfn_t *smfn, u32 guest_index)
 {
     return guest_index;
 }
 
-static u32
-shadow_l4_index(mfn_t *smfn, u32 guest_index)
+static u32 cf_check shadow_l4_index(mfn_t *smfn, u32 guest_index)
 {
     return guest_index;
 }
@@ -924,7 +920,7 @@ do {                                                                    \
 /**************************************************************************/
 /* Create a shadow of a given guest page.
  */
-static mfn_t
+static mfn_t cf_check
 sh_make_shadow(struct vcpu *v, mfn_t gmfn, u32 shadow_type)
 {
     struct domain *d = v->domain;
@@ -1459,7 +1455,8 @@ void sh_unhook_64b_mappings(struct domain *d, mfn_t sl4mfn, int user_only)
  */
 
 #if GUEST_PAGING_LEVELS >= 4
-static int validate_gl4e(struct vcpu *v, void *new_ge, mfn_t sl4mfn, void *se)
+static int cf_check validate_gl4e(
+    struct vcpu *v, void *new_ge, mfn_t sl4mfn, void *se)
 {
     shadow_l4e_t new_sl4e;
     guest_l4e_t new_gl4e = *(guest_l4e_t *)new_ge;
@@ -1518,7 +1515,8 @@ static int validate_gl4e(struct vcpu *v, void *new_ge, mfn_t sl4mfn, void *se)
 }
 
 
-static int validate_gl3e(struct vcpu *v, void *new_ge, mfn_t sl3mfn, void *se)
+static int cf_check validate_gl3e(
+    struct vcpu *v, void *new_ge, mfn_t sl3mfn, void *se)
 {
     struct domain *d = v->domain;
     shadow_l3e_t new_sl3e;
@@ -1552,7 +1550,8 @@ static int validate_gl3e(struct vcpu *v, void *new_ge, mfn_t sl3mfn, void *se)
 }
 #endif // GUEST_PAGING_LEVELS >= 4
 
-static int validate_gl2e(struct vcpu *v, void *new_ge, mfn_t sl2mfn, void *se)
+static int cf_check validate_gl2e(
+    struct vcpu *v, void *new_ge, mfn_t sl2mfn, void *se)
 {
     struct domain *d = v->domain;
     shadow_l2e_t new_sl2e;
@@ -1599,7 +1598,8 @@ static int validate_gl2e(struct vcpu *v, void *new_ge, mfn_t sl2mfn, void *se)
     return result;
 }
 
-static int validate_gl1e(struct vcpu *v, void *new_ge, mfn_t sl1mfn, void *se)
+static int cf_check validate_gl1e(
+    struct vcpu *v, void *new_ge, mfn_t sl1mfn, void *se)
 {
     struct domain *d = v->domain;
     shadow_l1e_t new_sl1e;
@@ -2089,8 +2089,8 @@ static DEFINE_PER_CPU(int,trace_extra_emulation_count);
 #endif
 static DEFINE_PER_CPU(guest_pa_t,trace_emulate_write_val);
 
-static void trace_emulate_write_val(const void *ptr, unsigned long vaddr,
-                                    const void *src, unsigned int bytes)
+static void cf_check trace_emulate_write_val(
+    const void *ptr, unsigned long vaddr, const void *src, unsigned int bytes)
 {
 #if GUEST_PAGING_LEVELS == 3
     if ( vaddr == this_cpu(trace_emulate_initial_va) )
@@ -2144,9 +2144,8 @@ static inline void trace_shadow_emulate(guest_l1e_t gl1e, unsigned long va)
  * shadow code (and the guest should retry) or 0 if it is not (and the
  * fault should be handled elsewhere or passed to the guest). */
 
-static int sh_page_fault(struct vcpu *v,
-                          unsigned long va,
-                          struct cpu_user_regs *regs)
+static int cf_check sh_page_fault(
+    struct vcpu *v, unsigned long va, struct cpu_user_regs *regs)
 {
     struct domain *d = v->domain;
     walk_t gw;
@@ -2898,7 +2897,7 @@ static int sh_page_fault(struct vcpu *v,
  * instruction should be issued on the hardware, or false if it's safe not
  * to do so.
  */
-static bool sh_invlpg(struct vcpu *v, unsigned long linear)
+static bool cf_check sh_invlpg(struct vcpu *v, unsigned long linear)
 {
     mfn_t sl1mfn;
     shadow_l2e_t sl2e;
@@ -3030,9 +3029,8 @@ static bool sh_invlpg(struct vcpu *v, unsigned long linear)
 
 #ifdef CONFIG_HVM
 
-static unsigned long
-sh_gva_to_gfn(struct vcpu *v, struct p2m_domain *p2m,
-    unsigned long va, uint32_t *pfec)
+static unsigned long cf_check sh_gva_to_gfn(
+    struct vcpu *v, struct p2m_domain *p2m, unsigned long va, uint32_t *pfec)
 /* Called to translate a guest virtual address to what the *guest*
  * pagetables would map it to. */
 {
@@ -3196,8 +3194,7 @@ sh_update_linear_entries(struct vcpu *v)
  * Removes v->arch.paging.shadow.shadow_table[].
  * Does all appropriate management/bookkeeping/refcounting/etc...
  */
-static void
-sh_detach_old_tables(struct vcpu *v)
+static void cf_check sh_detach_old_tables(struct vcpu *v)
 {
     struct domain *d = v->domain;
     mfn_t smfn;
@@ -3216,8 +3213,7 @@ sh_detach_old_tables(struct vcpu *v)
     }
 }
 
-static void
-sh_update_cr3(struct vcpu *v, int do_locking, bool noflush)
+static void cf_check sh_update_cr3(struct vcpu *v, int do_locking, bool noflush)
 /* Updates vcpu->arch.cr3 after the guest has changed CR3.
  * Paravirtual guests should set v->arch.guest_table (and guest_table_user,
  * if appropriate).
@@ -3525,7 +3521,8 @@ int sh_rm_write_access_from_sl1p(struct domain *d, mfn_t gmfn,
 #endif /* OOS */
 
 #if defined(CONFIG_HVM) && (SHADOW_OPTIMIZATIONS & SHOPT_WRITABLE_HEURISTIC)
-static int sh_guess_wrmap(struct vcpu *v, unsigned long vaddr, mfn_t gmfn)
+static int cf_check sh_guess_wrmap(
+    struct vcpu *v, unsigned long vaddr, mfn_t gmfn)
 /* Look up this vaddr in the current shadow and see if it's a writeable
  * mapping of this gmfn.  If so, remove it.  Returns 1 if it worked. */
 {
@@ -3589,8 +3586,8 @@ static int sh_guess_wrmap(struct vcpu *v, unsigned long vaddr, mfn_t gmfn)
 }
 #endif
 
-int sh_rm_write_access_from_l1(struct domain *d, mfn_t sl1mfn,
-                               mfn_t readonly_mfn)
+int cf_check sh_rm_write_access_from_l1(
+    struct domain *d, mfn_t sl1mfn, mfn_t readonly_mfn)
 /* Excises all writeable mappings to readonly_mfn from this l1 shadow table */
 {
     shadow_l1e_t *sl1e;
@@ -3626,7 +3623,8 @@ int sh_rm_write_access_from_l1(struct domain *d, mfn_t sl1mfn,
 }
 
 
-int sh_rm_mappings_from_l1(struct domain *d, mfn_t sl1mfn, mfn_t target_mfn)
+int cf_check sh_rm_mappings_from_l1(
+    struct domain *d, mfn_t sl1mfn, mfn_t target_mfn)
 /* Excises all mappings to guest frame from this shadow l1 table */
 {
     shadow_l1e_t *sl1e;
@@ -3677,7 +3675,7 @@ void sh_clear_shadow_entry(struct domain *d, void *ep, mfn_t smfn)
     }
 }
 
-int sh_remove_l1_shadow(struct domain *d, mfn_t sl2mfn, mfn_t sl1mfn)
+int cf_check sh_remove_l1_shadow(struct domain *d, mfn_t sl2mfn, mfn_t sl1mfn)
 /* Remove all mappings of this l1 shadow from this l2 shadow */
 {
     shadow_l2e_t *sl2e;
@@ -3700,7 +3698,7 @@ int sh_remove_l1_shadow(struct domain *d, mfn_t sl2mfn, mfn_t sl1mfn)
 }
 
 #if GUEST_PAGING_LEVELS >= 4
-int sh_remove_l2_shadow(struct domain *d, mfn_t sl3mfn, mfn_t sl2mfn)
+int cf_check sh_remove_l2_shadow(struct domain *d, mfn_t sl3mfn, mfn_t sl2mfn)
 /* Remove all mappings of this l2 shadow from this l3 shadow */
 {
     shadow_l3e_t *sl3e;
@@ -3722,7 +3720,7 @@ int sh_remove_l2_shadow(struct domain *d, mfn_t sl3mfn, mfn_t sl2mfn)
     return done;
 }
 
-int sh_remove_l3_shadow(struct domain *d, mfn_t sl4mfn, mfn_t sl3mfn)
+int cf_check sh_remove_l3_shadow(struct domain *d, mfn_t sl4mfn, mfn_t sl3mfn)
 /* Remove all mappings of this l3 shadow from this l4 shadow */
 {
     shadow_l4e_t *sl4e;
@@ -3752,7 +3750,7 @@ int sh_remove_l3_shadow(struct domain *d, mfn_t sl4mfn, mfn_t sl3mfn)
  * and in the meantime we unhook its top-level user-mode entries. */
 
 #if GUEST_PAGING_LEVELS == 3
-static void sh_pagetable_dying(paddr_t gpa)
+static void cf_check sh_pagetable_dying(paddr_t gpa)
 {
     struct vcpu *v = current;
     struct domain *d = v->domain;
@@ -3833,7 +3831,7 @@ static void sh_pagetable_dying(paddr_t gpa)
     put_gfn(d, l3gfn);
 }
 #else
-static void sh_pagetable_dying(paddr_t gpa)
+static void cf_check sh_pagetable_dying(paddr_t gpa)
 {
     struct vcpu *v = current;
     struct domain *d = v->domain;
@@ -3932,7 +3930,7 @@ static const char *sh_audit_flags(struct vcpu *v, int level,
     return NULL;
 }
 
-int sh_audit_l1_table(struct vcpu *v, mfn_t sl1mfn, mfn_t x)
+int cf_check sh_audit_l1_table(struct vcpu *v, mfn_t sl1mfn, mfn_t x)
 {
     guest_l1e_t *gl1e, *gp;
     shadow_l1e_t *sl1e;
@@ -4000,7 +3998,7 @@ int sh_audit_l1_table(struct vcpu *v, mfn_t sl1mfn, mfn_t x)
     return done;
 }
 
-int sh_audit_fl1_table(struct vcpu *v, mfn_t sl1mfn, mfn_t x)
+int cf_check sh_audit_fl1_table(struct vcpu *v, mfn_t sl1mfn, mfn_t x)
 {
     guest_l1e_t *gl1e, e;
     shadow_l1e_t *sl1e;
@@ -4026,7 +4024,7 @@ int sh_audit_fl1_table(struct vcpu *v, mfn_t sl1mfn, mfn_t x)
     return 0;
 }
 
-int sh_audit_l2_table(struct vcpu *v, mfn_t sl2mfn, mfn_t x)
+int cf_check sh_audit_l2_table(struct vcpu *v, mfn_t sl2mfn, mfn_t x)
 {
     struct domain *d = v->domain;
     guest_l2e_t *gl2e, *gp;
@@ -4078,7 +4076,7 @@ int sh_audit_l2_table(struct vcpu *v, mfn_t sl2mfn, mfn_t x)
 }
 
 #if GUEST_PAGING_LEVELS >= 4
-int sh_audit_l3_table(struct vcpu *v, mfn_t sl3mfn, mfn_t x)
+int cf_check sh_audit_l3_table(struct vcpu *v, mfn_t sl3mfn, mfn_t x)
 {
     struct domain *d = v->domain;
     guest_l3e_t *gl3e, *gp;
@@ -4126,7 +4124,7 @@ int sh_audit_l3_table(struct vcpu *v, mfn_t sl3mfn, mfn_t x)
     return 0;
 }
 
-int sh_audit_l4_table(struct vcpu *v, mfn_t sl4mfn, mfn_t x)
+int cf_check sh_audit_l4_table(struct vcpu *v, mfn_t sl4mfn, mfn_t x)
 {
     struct domain *d = v->domain;
     guest_l4e_t *gl4e, *gp;
diff --git a/xen/arch/x86/mm/shadow/multi.h b/xen/arch/x86/mm/shadow/multi.h
index 0bd6a2d5b787..5bcd6ae1a8da 100644
--- a/xen/arch/x86/mm/shadow/multi.h
+++ b/xen/arch/x86/mm/shadow/multi.h
@@ -59,10 +59,10 @@ extern void
 SHADOW_INTERNAL_NAME(sh_unhook_64b_mappings, GUEST_LEVELS)
     (struct domain *d, mfn_t sl4mfn, int user_only);
 
-extern int
+int cf_check
 SHADOW_INTERNAL_NAME(sh_rm_write_access_from_l1, GUEST_LEVELS)
     (struct domain *d, mfn_t sl1mfn, mfn_t readonly_mfn);
-extern int
+int cf_check
 SHADOW_INTERNAL_NAME(sh_rm_mappings_from_l1, GUEST_LEVELS)
     (struct domain *d, mfn_t sl1mfn, mfn_t target_mfn);
 
@@ -70,30 +70,30 @@ extern void
 SHADOW_INTERNAL_NAME(sh_clear_shadow_entry, GUEST_LEVELS)
     (struct domain *d, void *ep, mfn_t smfn);
 
-extern int
+int cf_check
 SHADOW_INTERNAL_NAME(sh_remove_l1_shadow, GUEST_LEVELS)
     (struct domain *d, mfn_t sl2mfn, mfn_t sl1mfn);
-extern int
+int cf_check
 SHADOW_INTERNAL_NAME(sh_remove_l2_shadow, GUEST_LEVELS)
     (struct domain *d, mfn_t sl3mfn, mfn_t sl2mfn);
-extern int
+int cf_check
 SHADOW_INTERNAL_NAME(sh_remove_l3_shadow, GUEST_LEVELS)
     (struct domain *d, mfn_t sl4mfn, mfn_t sl3mfn);
 
 #if SHADOW_AUDIT & SHADOW_AUDIT_ENTRIES
-int
+int cf_check
 SHADOW_INTERNAL_NAME(sh_audit_l1_table, GUEST_LEVELS)
     (struct vcpu *v, mfn_t sl1mfn, mfn_t x);
-int
+int cf_check
 SHADOW_INTERNAL_NAME(sh_audit_fl1_table, GUEST_LEVELS)
     (struct vcpu *v, mfn_t sl1mfn, mfn_t x);
-int
+int cf_check
 SHADOW_INTERNAL_NAME(sh_audit_l2_table, GUEST_LEVELS)
     (struct vcpu *v, mfn_t sl2mfn, mfn_t x);
-int
+int cf_check
 SHADOW_INTERNAL_NAME(sh_audit_l3_table, GUEST_LEVELS)
     (struct vcpu *v, mfn_t sl3mfn, mfn_t x);
-int
+int cf_check
 SHADOW_INTERNAL_NAME(sh_audit_l4_table, GUEST_LEVELS)
     (struct vcpu *v, mfn_t sl4mfn, mfn_t x);
 #endif
diff --git a/xen/arch/x86/mm/shadow/private.h b/xen/arch/x86/mm/shadow/private.h
index e4db8d32546a..3dc024e30f20 100644
--- a/xen/arch/x86/mm/shadow/private.h
+++ b/xen/arch/x86/mm/shadow/private.h
@@ -420,15 +420,15 @@ static inline int sh_remove_write_access(struct domain *d, mfn_t readonly_mfn,
 #endif
 
 /* Functions that atomically write PV guest PT entries */
-void sh_write_guest_entry(struct vcpu *v, intpte_t *p, intpte_t new,
-                          mfn_t gmfn);
-intpte_t sh_cmpxchg_guest_entry(struct vcpu *v, intpte_t *p, intpte_t old,
-                                intpte_t new, mfn_t gmfn);
+void cf_check sh_write_guest_entry(
+    struct vcpu *v, intpte_t *p, intpte_t new, mfn_t gmfn);
+intpte_t cf_check sh_cmpxchg_guest_entry(
+    struct vcpu *v, intpte_t *p, intpte_t old, intpte_t new, mfn_t gmfn);
 
 /* Update all the things that are derived from the guest's CR0/CR3/CR4.
  * Called to initialize paging structures if the paging mode
  * has changed, and when bringing up a VCPU for the first time. */
-void shadow_update_paging_modes(struct vcpu *v);
+void cf_check shadow_update_paging_modes(struct vcpu *v);
 
 /* Unhook the non-Xen mappings in this top-level shadow mfn.
  * With user_only == 1, unhooks only the user-mode mappings. */
@@ -922,7 +922,7 @@ static inline int sh_check_page_has_no_refs(struct page_info *page)
 }
 
 /* Flush the TLB of the selected vCPUs. */
-bool shadow_flush_tlb(const unsigned long *vcpu_bitmap);
+bool cf_check shadow_flush_tlb(const unsigned long *vcpu_bitmap);
 
 #endif /* _XEN_SHADOW_PRIVATE_H */
 
diff --git a/xen/arch/x86/mm/shadow/pv.c b/xen/arch/x86/mm/shadow/pv.c
index f51f980f2694..ed10d5479c5e 100644
--- a/xen/arch/x86/mm/shadow/pv.c
+++ b/xen/arch/x86/mm/shadow/pv.c
@@ -28,7 +28,7 @@
  * Write a new value into the guest pagetable, and update the shadows
  * appropriately.
  */
-void
+void cf_check
 sh_write_guest_entry(struct vcpu *v, intpte_t *p, intpte_t new, mfn_t gmfn)
 {
     paging_lock(v->domain);
@@ -42,7 +42,7 @@ sh_write_guest_entry(struct vcpu *v, intpte_t *p, intpte_t new, mfn_t gmfn)
  * appropriately.  Returns the previous entry found, which the caller is
  * expected to check to see if the cmpxchg was successful.
  */
-intpte_t
+intpte_t cf_check
 sh_cmpxchg_guest_entry(struct vcpu *v, intpte_t *p, intpte_t old,
                        intpte_t new, mfn_t gmfn)
 {
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:04:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:04:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271647.466236 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb2G-0001dZ-L8; Mon, 14 Feb 2022 13:04:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271647.466236; Mon, 14 Feb 2022 13:04:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb2G-0001d3-Fh; Mon, 14 Feb 2022 13:04:56 +0000
Received: by outflank-mailman (input) for mailman id 271647;
 Mon, 14 Feb 2022 13:04:54 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJb2E-0008IH-EI
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:04:54 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b253348c-8d96-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 14:04:53 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b253348c-8d96-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644843893;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=ipAxHYrAKEzK9SFgAkUSAhz6N1h8OI0W6ZrwtK0U1gA=;
  b=P/DyMK0yomKaNBSVSgfoXEmDe9eUlGZu91PE+aKcc78M15aIAsqQDBA/
   DlbUifezqwFpzAPX8/ek2DeM2PCPTjy1cvUfi2lGspnhdLIBOAvdMuujL
   pir86Gz2ZBZnepTpgVF4J3YdKFjW2ZpLa52u7qqACDEa8BR7k8AME43Y4
   0=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: spdufPN7QL5caJcmVWTXNMp5zXVwJqXGVqJ8c49c8TGoa49DhSj9cthVBz2xX32eXHySfnrz3h
 8RbwRuDOI6g/4sXW7ADlK5rW4F1/N77aJOmQtKUgEe30Lprf6UMQODg/E/qb5BgffjialJrY7J
 hLV+9dkO2+iMpGnqOvODt2WsIcpklG/TwJrkO5YeZ3O1VNyOiP0AmK7QLyvInylX762a3CDeL3
 BtzBMrYI4xOP04RfM2mcM/9vDtLqabCKNw9PNbH04IhSo2BxgFpkL+yPI79Iu3qOyzwCmoP6Ya
 RSENZGY+W2QttGzQ38y4sf5K
X-SBRS: 5.1
X-MesageID: 66374750
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:9VU2t6v7QXDun761HSGkfdk2dOfnVElZMUV32f8akzHdYApBsoF/q
 tZmKTuAPaqCYWXyedknOtm/pEsFusDdmNdhHARk+3owHyMb+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZQP0VOZigHtIQMsadUsxKbVIiGHdJZS5LwbZj2NYy2IThWmthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 Npl6MObaT5yAqHw27oef0hDSChDDPd80eqSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DFYUToHx/ixreCu4rW8vrSKTW/95Imjw3g6iiGN6AO
 ZFGNWUyNHwsZTVxOwYPFLISs9v53HelWhlk81Ks/Kk4tj27IAtZj+G2bYu9lsaxbdVYmAOUq
 3zL+0z9AwoGL5qPxDyd6HWui+TT2yThV+ov+KaQr6AwxgfJnypKVUNQBQDTTeSFZlCWBo10C
 3VPxiYS7vYx2B2wFdDAbkeCiSvR1vIDYOZ4H+o/4QCL76Pb5QeFG2QJJgJ8hMwaWNweHmJzi
 ALQ9z/9LXk26eDOFyrBnluBhW7qYUAowXk+iTjopOfvy/3qu8kNgx3GVb6P+4bl34SuSVkcL
 91nxRXSZon/b+ZWjc1XHnid2lpAQ6QlqSZvuG3qspqNtF8RWWJcT9XABaLnxfhBNp2FaVKKo
 WIJncOThMhXU83Ry3zdHbhVRerzjxpgDNE7qQQxd6TNChz3oyLzFWyuyG0WyLhV3jYsJmayP
 R67VfJ5755PJnq6BZKbkKrqY/nGOZPITIy/PtiNN4ImSsEoKGevoXE/DWbNjjuFuBV9zskC1
 WKzLJ/E4YAyUv88klJbho41jNcW+8zJ7T2PG86rlUn7uVdcDVbMIYo43JK1RrhRxMu5TM/9q
 r6z7uOGlEdSVvPQeC7S/dJBJFwGNyFjV5v3t9ZWZqiIJQ8/QDMtDPrYwLUAfY15nvsKyreUr
 y/lAkIImkDigXDnKBmRbiwxYr3YQpsi/2kwOjYhPAj01iF7M5qv9qoWa7A+YaIjqL541fdxQ
 vRcI5eAD/1DRy7p4TMYaZWh/oVueA7y3VCFPja/YSh5dJllHlSb9tjhdwrp1S8PEivo6pdu/
 +z+jlvWGMNRSR5jAcDabOOU42mw5XVNyvhvW0boI8VIfBm++oZdNCGs3OQ8JNsBKEufy2LCh
 RqWGxoRucLEv5QxrIvSnamBooqkT7l+E05dEzWJ5Lq6L3CHrG+qwIsGW+eUZzHNEmjz/fz6N
 +lSyvj9NtwBnUpL7NUgQ+o6k/pm6ou9vaJewyRlAG7PPgaiBb5XK3Wb2dVC6/9WzbhDtArqA
 k+C97G241lS1B8JxLLJGDcYUw==
IronPort-HdrOrdr: A9a23:fRCDYa8SRoZtE6D/+hBuk+DaI+orL9Y04lQ7vn2YSXRuHPBw9v
 re5cjzuiWVtN98Yh0dcJW7Scy9qBDnhPhICOsqTNSftWDd0QPCRuxfBMnZslnd8kXFh4lgPM
 xbEpSWZueeMbEDt7eZ3DWF
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="66374750"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v2 45/70] x86/cpu: CFI hardening
Date: Mon, 14 Feb 2022 12:51:02 +0000
Message-ID: <20220214125127.17985-46-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

Control Flow Integrity schemes use toolchain and optionally hardware support
to help protect against call/jump/return oriented programming attacks.

Use cf_check to annotate function pointer targets for the toolchain.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
 xen/arch/x86/cpu/amd.c      | 6 +++---
 xen/arch/x86/cpu/centaur.c  | 2 +-
 xen/arch/x86/cpu/common.c   | 2 +-
 xen/arch/x86/cpu/cpu.h      | 2 +-
 xen/arch/x86/cpu/hygon.c    | 2 +-
 xen/arch/x86/cpu/intel.c    | 6 +++---
 xen/arch/x86/cpu/shanghai.c | 2 +-
 7 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/xen/arch/x86/cpu/amd.c b/xen/arch/x86/cpu/amd.c
index 2d18223f20ef..4999f8be2b11 100644
--- a/xen/arch/x86/cpu/amd.c
+++ b/xen/arch/x86/cpu/amd.c
@@ -208,7 +208,7 @@ static void __init noinline probe_masking_msrs(void)
  * parameter of NULL is used to context switch to the default host state (by
  * the cpu bringup-code, crash path, etc).
  */
-static void amd_ctxt_switch_masking(const struct vcpu *next)
+static void cf_check amd_ctxt_switch_masking(const struct vcpu *next)
 {
 	struct cpuidmasks *these_masks = &this_cpu(cpuidmasks);
 	const struct domain *nextd = next ? next->domain : NULL;
@@ -634,7 +634,7 @@ void amd_log_freq(const struct cpuinfo_x86 *c)
 #undef FREQ
 }
 
-void early_init_amd(struct cpuinfo_x86 *c)
+void cf_check early_init_amd(struct cpuinfo_x86 *c)
 {
 	if (c == &boot_cpu_data)
 		amd_init_levelling();
@@ -744,7 +744,7 @@ void __init detect_zen2_null_seg_behaviour(void)
 
 }
 
-static void init_amd(struct cpuinfo_x86 *c)
+static void cf_check init_amd(struct cpuinfo_x86 *c)
 {
 	u32 l, h;
 
diff --git a/xen/arch/x86/cpu/centaur.c b/xen/arch/x86/cpu/centaur.c
index 34a5bfcaeef2..eac49d78db62 100644
--- a/xen/arch/x86/cpu/centaur.c
+++ b/xen/arch/x86/cpu/centaur.c
@@ -48,7 +48,7 @@ static void init_c3(struct cpuinfo_x86 *c)
 	display_cacheinfo(c);
 }
 
-static void init_centaur(struct cpuinfo_x86 *c)
+static void cf_check init_centaur(struct cpuinfo_x86 *c)
 {
 	if (c->x86 == 6)
 		init_c3(c);
diff --git a/xen/arch/x86/cpu/common.c b/xen/arch/x86/cpu/common.c
index c4f07f2d1da4..6b674bf15e8b 100644
--- a/xen/arch/x86/cpu/common.c
+++ b/xen/arch/x86/cpu/common.c
@@ -104,7 +104,7 @@ bool __init is_forced_cpu_cap(unsigned int cap)
 	return test_bit(cap, forced_caps);
 }
 
-static void default_init(struct cpuinfo_x86 * c)
+static void cf_check default_init(struct cpuinfo_x86 * c)
 {
 	/* Not much we can do here... */
 	/* Check if at least it has cpuid */
diff --git a/xen/arch/x86/cpu/cpu.h b/xen/arch/x86/cpu/cpu.h
index b593bd85f04f..a228087f9157 100644
--- a/xen/arch/x86/cpu/cpu.h
+++ b/xen/arch/x86/cpu/cpu.h
@@ -18,7 +18,7 @@ extern void display_cacheinfo(struct cpuinfo_x86 *c);
 extern void detect_ht(struct cpuinfo_x86 *c);
 extern bool detect_extended_topology(struct cpuinfo_x86 *c);
 
-void early_init_amd(struct cpuinfo_x86 *c);
+void cf_check early_init_amd(struct cpuinfo_x86 *c);
 void amd_log_freq(const struct cpuinfo_x86 *c);
 void amd_init_lfence(struct cpuinfo_x86 *c);
 void amd_init_ssbd(const struct cpuinfo_x86 *c);
diff --git a/xen/arch/x86/cpu/hygon.c b/xen/arch/x86/cpu/hygon.c
index cdc94130dd2e..3c8516e014c3 100644
--- a/xen/arch/x86/cpu/hygon.c
+++ b/xen/arch/x86/cpu/hygon.c
@@ -28,7 +28,7 @@ static void hygon_get_topology(struct cpuinfo_x86 *c)
 	                        c->phys_proc_id, c->cpu_core_id);
 }
 
-static void init_hygon(struct cpuinfo_x86 *c)
+static void cf_check init_hygon(struct cpuinfo_x86 *c)
 {
 	unsigned long long value;
 
diff --git a/xen/arch/x86/cpu/intel.c b/xen/arch/x86/cpu/intel.c
index 06b0e552cc8f..ff7c02223687 100644
--- a/xen/arch/x86/cpu/intel.c
+++ b/xen/arch/x86/cpu/intel.c
@@ -176,7 +176,7 @@ static void __init probe_masking_msrs(void)
  * parameter of NULL is used to context switch to the default host state (by
  * the cpu bringup-code, crash path, etc).
  */
-static void intel_ctxt_switch_masking(const struct vcpu *next)
+static void cf_check intel_ctxt_switch_masking(const struct vcpu *next)
 {
 	struct cpuidmasks *these_masks = &this_cpu(cpuidmasks);
 	const struct domain *nextd = next ? next->domain : NULL;
@@ -286,7 +286,7 @@ static void __init noinline intel_init_levelling(void)
 		ctxt_switch_masking = intel_ctxt_switch_masking;
 }
 
-static void early_init_intel(struct cpuinfo_x86 *c)
+static void cf_check early_init_intel(struct cpuinfo_x86 *c)
 {
 	u64 misc_enable, disable;
 
@@ -500,7 +500,7 @@ static void intel_log_freq(const struct cpuinfo_x86 *c)
     }
 }
 
-static void init_intel(struct cpuinfo_x86 *c)
+static void cf_check init_intel(struct cpuinfo_x86 *c)
 {
 	/* Detect the extended topology information if available */
 	detect_extended_topology(c);
diff --git a/xen/arch/x86/cpu/shanghai.c b/xen/arch/x86/cpu/shanghai.c
index 08a81f0f0c8e..95ae544f8c54 100644
--- a/xen/arch/x86/cpu/shanghai.c
+++ b/xen/arch/x86/cpu/shanghai.c
@@ -3,7 +3,7 @@
 #include <asm/processor.h>
 #include "cpu.h"
 
-static void init_shanghai(struct cpuinfo_x86 *c)
+static void cf_check init_shanghai(struct cpuinfo_x86 *c)
 {
     if ( cpu_has(c, X86_FEATURE_ITSC) )
     {
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:05:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:05:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271648.466246 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb2K-00027b-AA; Mon, 14 Feb 2022 13:05:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271648.466246; Mon, 14 Feb 2022 13:05:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb2K-00027M-5i; Mon, 14 Feb 2022 13:05:00 +0000
Received: by outflank-mailman (input) for mailman id 271648;
 Mon, 14 Feb 2022 13:04:59 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJb2I-0008IH-Kj
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:04:58 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b3f624cb-8d96-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 14:04:56 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b3f624cb-8d96-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644843895;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=pfhdXVvCWz6Fs6X++wjrTNrqVSs3wjv7wmnK/81GecM=;
  b=ZDay2MKrjN+Mh8oZQyInZNgPP/fl07hSAFxn3vaKgcXWLdoobN5cgFos
   NSW4Pk6sHvcsQ1yJhiEOUmk8o/EBXoHBA6E5KpspR6+ZyBgX6VGHsDrp7
   js1nKcEy4deYJLsarswwXYO1xxClfZ5vUkkcQ6oegMD5BqLI39eqEY0r0
   M=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: 5qzbJEgkWLQuuZ6suPdPbZ5i9qx84NCPrBpyP+ktyWo5TRk6cxC2kKzBxd4F3fonV1/HbnAg4+
 b3a9QZ3hIdKh4rMBvhq0LbJtxDVueOsQXNGE3i8ZY0oefJK7/eimJfDA5VaVDJXuYmIv4pRoeV
 Zs8Rt5QcOwWEhaCg+zfMT+XqgN04O59X90HD29y2giLls1bd/FlzyKwkmm9FdgDhkT3fLoE4BX
 X/dQbuaxdcXVsyaTcGqrcfXcoRUTv6N4M2dzkryVWSmdMHTBz2RjfrCdDkQmvM+mGFNPAow96j
 aa0ejekdB6HgglrhV+trZVYK
X-SBRS: 5.1
X-MesageID: 64149320
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:ZwFvuqx2U3I+ix/11EZ6t+cowSrEfRIJ4+MujC+fZmUNrF6WrkUBm
 GsZCGvSP6zfY2ujKYp/bIiw/UJQvJXSy9EyHQdtqiAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAhLeNYYH1500g7wbdl2tcAbeWRWGthh
 /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL
 wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt4937
 4tOiMXvcyMsIKnPqOMsUh9RSy4raMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr
 6ZBbmlQMFbT3Ipaw5riIgVoru0lINPmI8U0vXZ4wCuCJf0nXYrCU+PB4towMDIY2JwXQaeFP
 ZJxhTxHZRf4PQZMC34sFb0avuD2jHXETABGtwfAzUYwyzeKl1EguFT3C/LFd9rPSchLk0Kwo
 mPd43+/EhwcLMaYyzeO7jSrnOCnoM/gcNtMTvvirKcs2QDNgDxIYPELabeliaa/rRC9ZosAE
 WgR5C4tna8D9UqiFtaoCnVUv0W4lhIbXtNRFcgz5weM1rfY7m6lO4QUctJSQId47ZFrHFTGw
 nfMxoq0XmI37NV5XFrAru/8kN+kBcQCwYbujwcgRBBN3dTsqZpbYvnnHoc6S/7dYjEY9FjNL
 9G2QMoW2u97YS0jjfzTEbX7b9WE/Mahc+LNzl+LNl9JFysgDGJfW6Sm6ELA8dFLJ5uDQ1+Ks
 RAswpbCsL9eXczQzHXWGo3h+Y1FAN7fblXhbaNHRcF9p1xBBVb/FWyv3N2ODBgwaZtVEdMYS
 ETSpRlQ9Pdu0IiCNsdKj3aKI51yl8DITI29PtiNN4YmSsUhJWevoXA1DWbNjj+FraTZufxmU
 XttWZ33Vihy5GUO5GfeetrxJpd1mn5glTmOGfgWDX2PiNKjWZJccp9dWHPmUwzzxPrsTNz9/
 4kNOs2U5Q9YVeGiMCDb/ZRKdQIBLGQhBICwoMtSL7bRLg1jEWAnKvnQ3bJ+JNA1w/ULzr/Fr
 iOnR0tV6Fvjnnmbew+EXW9uNeH0VpFloHNlYSF1ZQS022IuaJqE5bsEc8dlZqEu8eFulKYmT
 /QMd8iaLO5ITzDLp2YUYZXn9dQwfxW3nwOeeSGiZWFnLZJnQgXI/P7ifxfuq3ZSXnbm65Nmr
 uT5hA3BQJcFSwBzN+rsaaqinwGroHwQuONuRE+UcNNdT1rhrdpxICvrg/5pf8xVcUffxiGX3
 hq9CAsDobWfuJc89dTEiPzWr4qtFOciTENWE3OCsOSzPCjeuGGi3ZVBQKCDejWEDDH4/6CrZ
 ON0yfDgMaJYwAYW4tQkS7s7n7gj49bPpqNBylU2FXrGWF2nF7d8LyTUxsJIrKBMmudUtAbet
 phjITWG1WFl4P/YLWM=
IronPort-HdrOrdr: A9a23:uR7z8KPttWKn9MBcTsOjsMiBIKoaSvp037Eqv3oedfU1SL3gqy
 nAppQmPHPP5Ar5HUtQ/OxoW5PwJ080l6QFgrX5VI3KNGKN1VdAbrsSibcKqweQfBEWndQ96U
 4PScdD4aXLfDpHsfo=
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="64149320"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v2 20/70] xen/sched: CFI hardening
Date: Mon, 14 Feb 2022 12:50:37 +0000
Message-ID: <20220214125127.17985-21-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

Control Flow Integrity schemes use toolchain and optionally hardware support
to help protect against call/jump/return oriented programming attacks.

Use cf_check to annotate function pointer targets for the toolchain.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Dario Faggioli <dfaggioli@suse.com>
---
 xen/common/sched/arinc653.c | 20 +++++++--------
 xen/common/sched/core.c     |  8 +++---
 xen/common/sched/credit.c   | 49 ++++++++++++++++++------------------
 xen/common/sched/credit2.c  | 51 +++++++++++++++++++-------------------
 xen/common/sched/null.c     | 60 +++++++++++++++++++++++----------------------
 xen/common/sched/rt.c       | 42 +++++++++++++++----------------
 6 files changed, 115 insertions(+), 115 deletions(-)

diff --git a/xen/common/sched/arinc653.c b/xen/common/sched/arinc653.c
index 542191822192..a82c0d7314a1 100644
--- a/xen/common/sched/arinc653.c
+++ b/xen/common/sched/arinc653.c
@@ -343,7 +343,7 @@ arinc653_sched_get(
  *                  <li> !0 = error
  *                  </ul>
  */
-static int
+static int cf_check
 a653sched_init(struct scheduler *ops)
 {
     a653sched_priv_t *prv;
@@ -366,7 +366,7 @@ a653sched_init(struct scheduler *ops)
  *
  * @param ops       Pointer to this instance of the scheduler structure
  */
-static void
+static void cf_check
 a653sched_deinit(struct scheduler *ops)
 {
     xfree(SCHED_PRIV(ops));
@@ -381,7 +381,7 @@ a653sched_deinit(struct scheduler *ops)
  *
  * @return          Pointer to the allocated data
  */
-static void *
+static void *cf_check
 a653sched_alloc_udata(const struct scheduler *ops, struct sched_unit *unit,
                       void *dd)
 {
@@ -442,7 +442,7 @@ a653sched_alloc_udata(const struct scheduler *ops, struct sched_unit *unit,
  *
  * @param ops       Pointer to this instance of the scheduler structure
  */
-static void
+static void cf_check
 a653sched_free_udata(const struct scheduler *ops, void *priv)
 {
     a653sched_priv_t *sched_priv = SCHED_PRIV(ops);
@@ -469,7 +469,7 @@ a653sched_free_udata(const struct scheduler *ops, void *priv)
  * @param ops       Pointer to this instance of the scheduler structure
  * @param unit      Pointer to struct sched_unit
  */
-static void
+static void cf_check
 a653sched_unit_sleep(const struct scheduler *ops, struct sched_unit *unit)
 {
     if ( AUNIT(unit) != NULL )
@@ -489,7 +489,7 @@ a653sched_unit_sleep(const struct scheduler *ops, struct sched_unit *unit)
  * @param ops       Pointer to this instance of the scheduler structure
  * @param unit      Pointer to struct sched_unit
  */
-static void
+static void cf_check
 a653sched_unit_wake(const struct scheduler *ops, struct sched_unit *unit)
 {
     if ( AUNIT(unit) != NULL )
@@ -505,7 +505,7 @@ a653sched_unit_wake(const struct scheduler *ops, struct sched_unit *unit)
  * @param ops       Pointer to this instance of the scheduler structure
  * @param now       Current time
  */
-static void
+static void cf_check
 a653sched_do_schedule(
     const struct scheduler *ops,
     struct sched_unit *prev,
@@ -604,7 +604,7 @@ a653sched_do_schedule(
  *
  * @return          Scheduler resource to run on
  */
-static struct sched_resource *
+static struct sched_resource *cf_check
 a653sched_pick_resource(const struct scheduler *ops,
                         const struct sched_unit *unit)
 {
@@ -634,7 +634,7 @@ a653sched_pick_resource(const struct scheduler *ops,
  * @param pdata     scheduler specific PCPU data (we don't have any)
  * @param vdata     scheduler specific UNIT data of the idle unit
  */
-static spinlock_t *
+static spinlock_t *cf_check
 a653_switch_sched(struct scheduler *new_ops, unsigned int cpu,
                   void *pdata, void *vdata)
 {
@@ -656,7 +656,7 @@ a653_switch_sched(struct scheduler *new_ops, unsigned int cpu,
  * @param ops       Pointer to this instance of the scheduler structure
  * @param sc        Pointer to the scheduler operation specified by Domain 0
  */
-static int
+static int cf_check
 a653sched_adjust_global(const struct scheduler *ops,
                         struct xen_sysctl_scheduler_op *sc)
 {
diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c
index b1836b591c0a..9e09d9befa23 100644
--- a/xen/common/sched/core.c
+++ b/xen/common/sched/core.c
@@ -98,13 +98,13 @@ static bool scheduler_active;
 static void sched_set_affinity(
     struct sched_unit *unit, const cpumask_t *hard, const cpumask_t *soft);
 
-static struct sched_resource *
+static struct sched_resource *cf_check
 sched_idle_res_pick(const struct scheduler *ops, const struct sched_unit *unit)
 {
     return unit->res;
 }
 
-static void *
+static void *cf_check
 sched_idle_alloc_udata(const struct scheduler *ops, struct sched_unit *unit,
                        void *dd)
 {
@@ -112,12 +112,12 @@ sched_idle_alloc_udata(const struct scheduler *ops, struct sched_unit *unit,
     return ZERO_BLOCK_PTR;
 }
 
-static void
+static void cf_check
 sched_idle_free_udata(const struct scheduler *ops, void *priv)
 {
 }
 
-static void sched_idle_schedule(
+static void cf_check sched_idle_schedule(
     const struct scheduler *ops, struct sched_unit *unit, s_time_t now,
     bool tasklet_work_scheduled)
 {
diff --git a/xen/common/sched/credit.c b/xen/common/sched/credit.c
index 5635271f6fea..4d3bd8cba6fc 100644
--- a/xen/common/sched/credit.c
+++ b/xen/common/sched/credit.c
@@ -507,7 +507,7 @@ static inline void __runq_tickle(const struct csched_unit *new)
         SCHED_STAT_CRANK(tickled_no_cpu);
 }
 
-static void
+static void cf_check
 csched_free_pdata(const struct scheduler *ops, void *pcpu, int cpu)
 {
     const struct csched_private *prv = CSCHED_PRIV(ops);
@@ -524,7 +524,7 @@ csched_free_pdata(const struct scheduler *ops, void *pcpu, int cpu)
     xfree(pcpu);
 }
 
-static void
+static void cf_check
 csched_deinit_pdata(const struct scheduler *ops, void *pcpu, int cpu)
 {
     struct csched_private *prv = CSCHED_PRIV(ops);
@@ -566,7 +566,7 @@ csched_deinit_pdata(const struct scheduler *ops, void *pcpu, int cpu)
     spin_unlock_irqrestore(&prv->lock, flags);
 }
 
-static void *
+static void *cf_check
 csched_alloc_pdata(const struct scheduler *ops, int cpu)
 {
     struct csched_pcpu *spc;
@@ -615,7 +615,7 @@ init_pdata(struct csched_private *prv, struct csched_pcpu *spc, int cpu)
 }
 
 /* Change the scheduler of cpu to us (Credit). */
-static spinlock_t *
+static spinlock_t *cf_check
 csched_switch_sched(struct scheduler *new_ops, unsigned int cpu,
                     void *pdata, void *vdata)
 {
@@ -848,7 +848,7 @@ _csched_cpu_pick(const struct scheduler *ops, const struct sched_unit *unit,
     return cpu;
 }
 
-static struct sched_resource *
+static struct sched_resource *cf_check
 csched_res_pick(const struct scheduler *ops, const struct sched_unit *unit)
 {
     struct csched_unit *svc = CSCHED_UNIT(unit);
@@ -985,9 +985,8 @@ csched_unit_acct(struct csched_private *prv, unsigned int cpu)
     }
 }
 
-static void *
-csched_alloc_udata(const struct scheduler *ops, struct sched_unit *unit,
-                   void *dd)
+static void *cf_check csched_alloc_udata(
+    const struct scheduler *ops, struct sched_unit *unit, void *dd)
 {
     struct csched_unit *svc;
 
@@ -1007,7 +1006,7 @@ csched_alloc_udata(const struct scheduler *ops, struct sched_unit *unit,
     return svc;
 }
 
-static void
+static void cf_check
 csched_unit_insert(const struct scheduler *ops, struct sched_unit *unit)
 {
     struct csched_unit *svc = unit->priv;
@@ -1032,7 +1031,7 @@ csched_unit_insert(const struct scheduler *ops, struct sched_unit *unit)
     SCHED_STAT_CRANK(unit_insert);
 }
 
-static void
+static void cf_check
 csched_free_udata(const struct scheduler *ops, void *priv)
 {
     struct csched_unit *svc = priv;
@@ -1042,7 +1041,7 @@ csched_free_udata(const struct scheduler *ops, void *priv)
     xfree(svc);
 }
 
-static void
+static void cf_check
 csched_unit_remove(const struct scheduler *ops, struct sched_unit *unit)
 {
     struct csched_private *prv = CSCHED_PRIV(ops);
@@ -1069,7 +1068,7 @@ csched_unit_remove(const struct scheduler *ops, struct sched_unit *unit)
     BUG_ON( sdom == NULL );
 }
 
-static void
+static void cf_check
 csched_unit_sleep(const struct scheduler *ops, struct sched_unit *unit)
 {
     struct csched_unit * const svc = CSCHED_UNIT(unit);
@@ -1094,7 +1093,7 @@ csched_unit_sleep(const struct scheduler *ops, struct sched_unit *unit)
         runq_remove(svc);
 }
 
-static void
+static void cf_check
 csched_unit_wake(const struct scheduler *ops, struct sched_unit *unit)
 {
     struct csched_unit * const svc = CSCHED_UNIT(unit);
@@ -1156,7 +1155,7 @@ csched_unit_wake(const struct scheduler *ops, struct sched_unit *unit)
     __runq_tickle(svc);
 }
 
-static void
+static void cf_check
 csched_unit_yield(const struct scheduler *ops, struct sched_unit *unit)
 {
     struct csched_unit * const svc = CSCHED_UNIT(unit);
@@ -1165,7 +1164,7 @@ csched_unit_yield(const struct scheduler *ops, struct sched_unit *unit)
     set_bit(CSCHED_FLAG_UNIT_YIELD, &svc->flags);
 }
 
-static int
+static int cf_check
 csched_dom_cntl(
     const struct scheduler *ops,
     struct domain *d,
@@ -1210,7 +1209,7 @@ csched_dom_cntl(
     return rc;
 }
 
-static void
+static void cf_check
 csched_aff_cntl(const struct scheduler *ops, struct sched_unit *unit,
                 const cpumask_t *hard, const cpumask_t *soft)
 {
@@ -1238,7 +1237,7 @@ __csched_set_tslice(struct csched_private *prv, unsigned int timeslice_ms)
     prv->credit = prv->credits_per_tslice * prv->ncpus;
 }
 
-static int
+static int cf_check
 csched_sys_cntl(const struct scheduler *ops,
                         struct xen_sysctl_scheduler_op *sc)
 {
@@ -1281,7 +1280,7 @@ csched_sys_cntl(const struct scheduler *ops,
     return rc;
 }
 
-static void *
+static void *cf_check
 csched_alloc_domdata(const struct scheduler *ops, struct domain *dom)
 {
     struct csched_dom *sdom;
@@ -1299,7 +1298,7 @@ csched_alloc_domdata(const struct scheduler *ops, struct domain *dom)
     return sdom;
 }
 
-static void
+static void cf_check
 csched_free_domdata(const struct scheduler *ops, void *data)
 {
     xfree(data);
@@ -1809,7 +1808,7 @@ csched_load_balance(struct csched_private *prv, int cpu,
  * This function is in the critical path. It is designed to be simple and
  * fast for the common case.
  */
-static void csched_schedule(
+static void cf_check csched_schedule(
     const struct scheduler *ops, struct sched_unit *unit, s_time_t now,
     bool tasklet_work_scheduled)
 {
@@ -2026,7 +2025,7 @@ csched_dump_unit(const struct csched_unit *svc)
     printk("\n");
 }
 
-static void
+static void cf_check
 csched_dump_pcpu(const struct scheduler *ops, int cpu)
 {
     const struct list_head *runq;
@@ -2079,7 +2078,7 @@ csched_dump_pcpu(const struct scheduler *ops, int cpu)
     spin_unlock_irqrestore(&prv->lock, flags);
 }
 
-static void
+static void cf_check
 csched_dump(const struct scheduler *ops)
 {
     struct list_head *iter_sdom, *iter_svc;
@@ -2143,7 +2142,7 @@ csched_dump(const struct scheduler *ops)
     spin_unlock_irqrestore(&prv->lock, flags);
 }
 
-static int __init
+static int __init cf_check
 csched_global_init(void)
 {
     if ( sched_credit_tslice_ms > XEN_SYSCTL_CSCHED_TSLICE_MAX ||
@@ -2173,7 +2172,7 @@ csched_global_init(void)
     return 0;
 }
 
-static int
+static int cf_check
 csched_init(struct scheduler *ops)
 {
     struct csched_private *prv;
@@ -2215,7 +2214,7 @@ csched_init(struct scheduler *ops)
     return 0;
 }
 
-static void
+static void cf_check
 csched_deinit(struct scheduler *ops)
 {
     struct csched_private *prv;
diff --git a/xen/common/sched/credit2.c b/xen/common/sched/credit2.c
index d96e2749ddfb..0e3f89e5378e 100644
--- a/xen/common/sched/credit2.c
+++ b/xen/common/sched/credit2.c
@@ -2164,7 +2164,7 @@ csched2_unit_check(const struct sched_unit *unit)
 #define CSCHED2_UNIT_CHECK(unit)
 #endif
 
-static void *
+static void *cf_check
 csched2_alloc_udata(const struct scheduler *ops, struct sched_unit *unit,
                     void *dd)
 {
@@ -2208,7 +2208,7 @@ csched2_alloc_udata(const struct scheduler *ops, struct sched_unit *unit,
     return svc;
 }
 
-static void
+static void cf_check
 csched2_unit_sleep(const struct scheduler *ops, struct sched_unit *unit)
 {
     struct csched2_unit * const svc = csched2_unit(unit);
@@ -2230,7 +2230,7 @@ csched2_unit_sleep(const struct scheduler *ops, struct sched_unit *unit)
         __clear_bit(__CSFLAG_delayed_runq_add, &svc->flags);
 }
 
-static void
+static void cf_check
 csched2_unit_wake(const struct scheduler *ops, struct sched_unit *unit)
 {
     struct csched2_unit * const svc = csched2_unit(unit);
@@ -2285,7 +2285,7 @@ csched2_unit_wake(const struct scheduler *ops, struct sched_unit *unit)
     return;
 }
 
-static void
+static void cf_check
 csched2_unit_yield(const struct scheduler *ops, struct sched_unit *unit)
 {
     struct csched2_unit * const svc = csched2_unit(unit);
@@ -2293,7 +2293,7 @@ csched2_unit_yield(const struct scheduler *ops, struct sched_unit *unit)
     __set_bit(__CSFLAG_unit_yield, &svc->flags);
 }
 
-static void
+static void cf_check
 csched2_context_saved(const struct scheduler *ops, struct sched_unit *unit)
 {
     struct csched2_unit * const svc = csched2_unit(unit);
@@ -2335,7 +2335,7 @@ csched2_context_saved(const struct scheduler *ops, struct sched_unit *unit)
 }
 
 #define MAX_LOAD (STIME_MAX)
-static struct sched_resource *
+static struct sched_resource *cf_check
 csched2_res_pick(const struct scheduler *ops, const struct sched_unit *unit)
 {
     struct csched2_private *prv = csched2_priv(ops);
@@ -2867,8 +2867,7 @@ static void balance_load(const struct scheduler *ops, int cpu, s_time_t now)
     return;
 }
 
-static void
-csched2_unit_migrate(
+static void cf_check csched2_unit_migrate(
     const struct scheduler *ops, struct sched_unit *unit, unsigned int new_cpu)
 {
     struct csched2_unit * const svc = csched2_unit(unit);
@@ -2894,7 +2893,7 @@ csched2_unit_migrate(
         sched_set_res(unit, get_sched_res(new_cpu));
 }
 
-static int
+static int cf_check
 csched2_dom_cntl(
     const struct scheduler *ops,
     struct domain *d,
@@ -3100,7 +3099,7 @@ csched2_dom_cntl(
     return rc;
 }
 
-static void
+static void cf_check
 csched2_aff_cntl(const struct scheduler *ops, struct sched_unit *unit,
                  const cpumask_t *hard, const cpumask_t *soft)
 {
@@ -3116,8 +3115,8 @@ csched2_aff_cntl(const struct scheduler *ops, struct sched_unit *unit,
         __clear_bit(__CSFLAG_pinned, &svc->flags);
 }
 
-static int csched2_sys_cntl(const struct scheduler *ops,
-                            struct xen_sysctl_scheduler_op *sc)
+static int cf_check csched2_sys_cntl(
+    const struct scheduler *ops, struct xen_sysctl_scheduler_op *sc)
 {
     struct xen_sysctl_credit2_schedule *params = &sc->u.sched_credit2;
     struct csched2_private *prv = csched2_priv(ops);
@@ -3148,7 +3147,7 @@ static int csched2_sys_cntl(const struct scheduler *ops,
     return 0;
 }
 
-static void *
+static void *cf_check
 csched2_alloc_domdata(const struct scheduler *ops, struct domain *dom)
 {
     struct csched2_private *prv = csched2_priv(ops);
@@ -3180,7 +3179,7 @@ csched2_alloc_domdata(const struct scheduler *ops, struct domain *dom)
     return sdom;
 }
 
-static void
+static void cf_check
 csched2_free_domdata(const struct scheduler *ops, void *data)
 {
     struct csched2_dom *sdom = data;
@@ -3200,7 +3199,7 @@ csched2_free_domdata(const struct scheduler *ops, void *data)
     }
 }
 
-static void
+static void cf_check
 csched2_unit_insert(const struct scheduler *ops, struct sched_unit *unit)
 {
     const struct csched2_unit *svc = unit->priv;
@@ -3231,7 +3230,7 @@ csched2_unit_insert(const struct scheduler *ops, struct sched_unit *unit)
     CSCHED2_UNIT_CHECK(unit);
 }
 
-static void
+static void cf_check
 csched2_free_udata(const struct scheduler *ops, void *priv)
 {
     struct csched2_unit *svc = priv;
@@ -3239,7 +3238,7 @@ csched2_free_udata(const struct scheduler *ops, void *priv)
     xfree(svc);
 }
 
-static void
+static void cf_check
 csched2_unit_remove(const struct scheduler *ops, struct sched_unit *unit)
 {
     struct csched2_unit * const svc = csched2_unit(unit);
@@ -3558,7 +3557,7 @@ runq_candidate(struct csched2_runqueue_data *rqd,
  * This function is in the critical path. It is designed to be simple and
  * fast for the common case.
  */
-static void csched2_schedule(
+static void cf_check csched2_schedule(
     const struct scheduler *ops, struct sched_unit *currunit, s_time_t now,
     bool tasklet_work_scheduled)
 {
@@ -3790,7 +3789,7 @@ dump_pcpu(const struct scheduler *ops, int cpu)
     }
 }
 
-static void
+static void cf_check
 csched2_dump(const struct scheduler *ops)
 {
     struct list_head *iter_sdom;
@@ -3898,7 +3897,7 @@ csched2_dump(const struct scheduler *ops)
     read_unlock_irqrestore(&prv->lock, flags);
 }
 
-static void *
+static void *cf_check
 csched2_alloc_pdata(const struct scheduler *ops, int cpu)
 {
     struct csched2_pcpu *spc;
@@ -3988,7 +3987,7 @@ init_pdata(struct csched2_private *prv, struct csched2_pcpu *spc,
 }
 
 /* Change the scheduler of cpu to us (Credit2). */
-static spinlock_t *
+static spinlock_t *cf_check
 csched2_switch_sched(struct scheduler *new_ops, unsigned int cpu,
                      void *pdata, void *vdata)
 {
@@ -4026,7 +4025,7 @@ csched2_switch_sched(struct scheduler *new_ops, unsigned int cpu,
     return &rqd->lock;
 }
 
-static void
+static void cf_check
 csched2_deinit_pdata(const struct scheduler *ops, void *pcpu, int cpu)
 {
     unsigned long flags;
@@ -4086,7 +4085,7 @@ csched2_deinit_pdata(const struct scheduler *ops, void *pcpu, int cpu)
     return;
 }
 
-static void
+static void cf_check
 csched2_free_pdata(const struct scheduler *ops, void *pcpu, int cpu)
 {
     struct csched2_private *prv = csched2_priv(ops);
@@ -4115,7 +4114,7 @@ csched2_free_pdata(const struct scheduler *ops, void *pcpu, int cpu)
     xfree(pcpu);
 }
 
-static int __init
+static int __init cf_check
 csched2_global_init(void)
 {
     if ( opt_load_precision_shift < LOADAVG_PRECISION_SHIFT_MIN )
@@ -4142,7 +4141,7 @@ csched2_global_init(void)
     return 0;
 }
 
-static int
+static int cf_check
 csched2_init(struct scheduler *ops)
 {
     struct csched2_private *prv;
@@ -4190,7 +4189,7 @@ csched2_init(struct scheduler *ops)
     return 0;
 }
 
-static void
+static void cf_check
 csched2_deinit(struct scheduler *ops)
 {
     struct csched2_private *prv;
diff --git a/xen/common/sched/null.c b/xen/common/sched/null.c
index 82d5d1baab85..65a0a6c5312d 100644
--- a/xen/common/sched/null.c
+++ b/xen/common/sched/null.c
@@ -130,7 +130,7 @@ static inline bool unit_check_affinity(struct sched_unit *unit,
     return cpumask_test_cpu(cpu, cpumask_scratch_cpu(cpu));
 }
 
-static int null_init(struct scheduler *ops)
+static int cf_check null_init(struct scheduler *ops)
 {
     struct null_private *prv;
 
@@ -152,7 +152,7 @@ static int null_init(struct scheduler *ops)
     return 0;
 }
 
-static void null_deinit(struct scheduler *ops)
+static void cf_check null_deinit(struct scheduler *ops)
 {
     xfree(ops->sched_data);
     ops->sched_data = NULL;
@@ -166,7 +166,8 @@ static void init_pdata(struct null_private *prv, struct null_pcpu *npc,
     npc->unit = NULL;
 }
 
-static void null_deinit_pdata(const struct scheduler *ops, void *pcpu, int cpu)
+static void cf_check null_deinit_pdata(
+    const struct scheduler *ops, void *pcpu, int cpu)
 {
     struct null_private *prv = null_priv(ops);
     struct null_pcpu *npc = pcpu;
@@ -177,7 +178,7 @@ static void null_deinit_pdata(const struct scheduler *ops, void *pcpu, int cpu)
     npc->unit = NULL;
 }
 
-static void *null_alloc_pdata(const struct scheduler *ops, int cpu)
+static void *cf_check null_alloc_pdata(const struct scheduler *ops, int cpu)
 {
     struct null_pcpu *npc;
 
@@ -188,13 +189,14 @@ static void *null_alloc_pdata(const struct scheduler *ops, int cpu)
     return npc;
 }
 
-static void null_free_pdata(const struct scheduler *ops, void *pcpu, int cpu)
+static void cf_check null_free_pdata(
+    const struct scheduler *ops, void *pcpu, int cpu)
 {
     xfree(pcpu);
 }
 
-static void *null_alloc_udata(const struct scheduler *ops,
-                              struct sched_unit *unit, void *dd)
+static void *cf_check null_alloc_udata(
+    const struct scheduler *ops, struct sched_unit *unit, void *dd)
 {
     struct null_unit *nvc;
 
@@ -210,15 +212,15 @@ static void *null_alloc_udata(const struct scheduler *ops,
     return nvc;
 }
 
-static void null_free_udata(const struct scheduler *ops, void *priv)
+static void cf_check null_free_udata(const struct scheduler *ops, void *priv)
 {
     struct null_unit *nvc = priv;
 
     xfree(nvc);
 }
 
-static void * null_alloc_domdata(const struct scheduler *ops,
-                                 struct domain *d)
+static void *cf_check null_alloc_domdata(
+    const struct scheduler *ops, struct domain *d)
 {
     struct null_private *prv = null_priv(ops);
     struct null_dom *ndom;
@@ -237,7 +239,7 @@ static void * null_alloc_domdata(const struct scheduler *ops,
     return ndom;
 }
 
-static void null_free_domdata(const struct scheduler *ops, void *data)
+static void cf_check null_free_domdata(const struct scheduler *ops, void *data)
 {
     struct null_dom *ndom = data;
     struct null_private *prv = null_priv(ops);
@@ -426,9 +428,8 @@ static bool unit_deassign(struct null_private *prv, const struct sched_unit *uni
 }
 
 /* Change the scheduler of cpu to us (null). */
-static spinlock_t *null_switch_sched(struct scheduler *new_ops,
-                                     unsigned int cpu,
-                                     void *pdata, void *vdata)
+static spinlock_t *cf_check null_switch_sched(
+    struct scheduler *new_ops, unsigned int cpu, void *pdata, void *vdata)
 {
     struct sched_resource *sr = get_sched_res(cpu);
     struct null_private *prv = null_priv(new_ops);
@@ -450,8 +451,8 @@ static spinlock_t *null_switch_sched(struct scheduler *new_ops,
     return &sr->_lock;
 }
 
-static void null_unit_insert(const struct scheduler *ops,
-                             struct sched_unit *unit)
+static void cf_check null_unit_insert(
+    const struct scheduler *ops, struct sched_unit *unit)
 {
     struct null_private *prv = null_priv(ops);
     struct null_unit *nvc = null_unit(unit);
@@ -516,8 +517,8 @@ static void null_unit_insert(const struct scheduler *ops,
     SCHED_STAT_CRANK(unit_insert);
 }
 
-static void null_unit_remove(const struct scheduler *ops,
-                             struct sched_unit *unit)
+static void cf_check null_unit_remove(
+    const struct scheduler *ops, struct sched_unit *unit)
 {
     struct null_private *prv = null_priv(ops);
     struct null_unit *nvc = null_unit(unit);
@@ -556,8 +557,8 @@ static void null_unit_remove(const struct scheduler *ops,
     SCHED_STAT_CRANK(unit_remove);
 }
 
-static void null_unit_wake(const struct scheduler *ops,
-                           struct sched_unit *unit)
+static void cf_check null_unit_wake(
+    const struct scheduler *ops, struct sched_unit *unit)
 {
     struct null_private *prv = null_priv(ops);
     struct null_unit *nvc = null_unit(unit);
@@ -632,8 +633,8 @@ static void null_unit_wake(const struct scheduler *ops,
         cpumask_raise_softirq(cpumask_scratch_cpu(cpu), SCHEDULE_SOFTIRQ);
 }
 
-static void null_unit_sleep(const struct scheduler *ops,
-                            struct sched_unit *unit)
+static void cf_check null_unit_sleep(
+    const struct scheduler *ops, struct sched_unit *unit)
 {
     struct null_private *prv = null_priv(ops);
     unsigned int cpu = sched_unit_master(unit);
@@ -667,15 +668,15 @@ static void null_unit_sleep(const struct scheduler *ops,
     SCHED_STAT_CRANK(unit_sleep);
 }
 
-static struct sched_resource *
+static struct sched_resource *cf_check
 null_res_pick(const struct scheduler *ops, const struct sched_unit *unit)
 {
     ASSERT(!is_idle_unit(unit));
     return pick_res(null_priv(ops), unit);
 }
 
-static void null_unit_migrate(const struct scheduler *ops,
-                              struct sched_unit *unit, unsigned int new_cpu)
+static void cf_check null_unit_migrate(
+    const struct scheduler *ops, struct sched_unit *unit, unsigned int new_cpu)
 {
     struct null_private *prv = null_priv(ops);
     struct null_unit *nvc = null_unit(unit);
@@ -801,8 +802,9 @@ static inline void null_unit_check(struct sched_unit *unit)
  *  - the unit assigned to the pCPU, if there's one and it can run;
  *  - the idle unit, otherwise.
  */
-static void null_schedule(const struct scheduler *ops, struct sched_unit *prev,
-                          s_time_t now, bool tasklet_work_scheduled)
+static void cf_check null_schedule(
+    const struct scheduler *ops, struct sched_unit *prev, s_time_t now,
+    bool tasklet_work_scheduled)
 {
     unsigned int bs;
     const unsigned int cur_cpu = smp_processor_id();
@@ -939,7 +941,7 @@ static inline void dump_unit(const struct null_private *prv,
                                 sched_unit_master(nvc->unit) : -1);
 }
 
-static void null_dump_pcpu(const struct scheduler *ops, int cpu)
+static void cf_check null_dump_pcpu(const struct scheduler *ops, int cpu)
 {
     struct null_private *prv = null_priv(ops);
     const struct null_pcpu *npc = get_sched_res(cpu)->sched_priv;
@@ -968,7 +970,7 @@ static void null_dump_pcpu(const struct scheduler *ops, int cpu)
     pcpu_schedule_unlock_irqrestore(lock, flags, cpu);
 }
 
-static void null_dump(const struct scheduler *ops)
+static void cf_check null_dump(const struct scheduler *ops)
 {
     struct null_private *prv = null_priv(ops);
     struct list_head *iter;
diff --git a/xen/common/sched/rt.c b/xen/common/sched/rt.c
index 5ea6f01f263c..d6de25531b3c 100644
--- a/xen/common/sched/rt.c
+++ b/xen/common/sched/rt.c
@@ -269,13 +269,13 @@ unit_on_q(const struct rt_unit *svc)
    return !list_empty(&svc->q_elem);
 }
 
-static struct rt_unit *
+static struct rt_unit *cf_check
 q_elem(struct list_head *elem)
 {
     return list_entry(elem, struct rt_unit, q_elem);
 }
 
-static struct rt_unit *
+static struct rt_unit *cf_check
 replq_elem(struct list_head *elem)
 {
     return list_entry(elem, struct rt_unit, replq_elem);
@@ -348,7 +348,7 @@ rt_dump_unit(const struct scheduler *ops, const struct rt_unit *svc)
             svc->flags, CPUMASK_PR(mask));
 }
 
-static void
+static void cf_check
 rt_dump_pcpu(const struct scheduler *ops, int cpu)
 {
     struct rt_private *prv = rt_priv(ops);
@@ -366,7 +366,7 @@ rt_dump_pcpu(const struct scheduler *ops, int cpu)
     spin_unlock_irqrestore(&prv->lock, flags);
 }
 
-static void
+static void cf_check
 rt_dump(const struct scheduler *ops)
 {
     struct list_head *runq, *depletedq, *replq, *iter;
@@ -636,7 +636,7 @@ replq_reinsert(const struct scheduler *ops, struct rt_unit *svc)
  * Valid resource of an unit is intesection of unit's affinity
  * and available resources
  */
-static struct sched_resource *
+static struct sched_resource *cf_check
 rt_res_pick_locked(const struct sched_unit *unit, unsigned int locked_cpu)
 {
     cpumask_t *cpus = cpumask_scratch_cpu(locked_cpu);
@@ -659,7 +659,7 @@ rt_res_pick_locked(const struct sched_unit *unit, unsigned int locked_cpu)
  * Valid resource of an unit is intesection of unit's affinity
  * and available resources
  */
-static struct sched_resource *
+static struct sched_resource *cf_check
 rt_res_pick(const struct scheduler *ops, const struct sched_unit *unit)
 {
     struct sched_resource *res;
@@ -672,7 +672,7 @@ rt_res_pick(const struct scheduler *ops, const struct sched_unit *unit)
 /*
  * Init/Free related code
  */
-static int
+static int cf_check
 rt_init(struct scheduler *ops)
 {
     int rc = -ENOMEM;
@@ -701,7 +701,7 @@ rt_init(struct scheduler *ops)
     return rc;
 }
 
-static void
+static void cf_check
 rt_deinit(struct scheduler *ops)
 {
     struct rt_private *prv = rt_priv(ops);
@@ -714,7 +714,7 @@ rt_deinit(struct scheduler *ops)
 }
 
 /* Change the scheduler of cpu to us (RTDS). */
-static spinlock_t *
+static spinlock_t *cf_check
 rt_switch_sched(struct scheduler *new_ops, unsigned int cpu,
                 void *pdata, void *vdata)
 {
@@ -750,7 +750,7 @@ rt_switch_sched(struct scheduler *new_ops, unsigned int cpu,
     return &prv->lock;
 }
 
-static void
+static void cf_check
 rt_deinit_pdata(const struct scheduler *ops, void *pcpu, int cpu)
 {
     unsigned long flags;
@@ -782,7 +782,7 @@ rt_deinit_pdata(const struct scheduler *ops, void *pcpu, int cpu)
     spin_unlock_irqrestore(&prv->lock, flags);
 }
 
-static void *
+static void *cf_check
 rt_alloc_domdata(const struct scheduler *ops, struct domain *dom)
 {
     unsigned long flags;
@@ -804,7 +804,7 @@ rt_alloc_domdata(const struct scheduler *ops, struct domain *dom)
     return sdom;
 }
 
-static void
+static void cf_check
 rt_free_domdata(const struct scheduler *ops, void *data)
 {
     struct rt_dom *sdom = data;
@@ -822,7 +822,7 @@ rt_free_domdata(const struct scheduler *ops, void *data)
     }
 }
 
-static void *
+static void * cf_check
 rt_alloc_udata(const struct scheduler *ops, struct sched_unit *unit, void *dd)
 {
     struct rt_unit *svc;
@@ -850,7 +850,7 @@ rt_alloc_udata(const struct scheduler *ops, struct sched_unit *unit, void *dd)
     return svc;
 }
 
-static void
+static void cf_check
 rt_free_udata(const struct scheduler *ops, void *priv)
 {
     struct rt_unit *svc = priv;
@@ -865,7 +865,7 @@ rt_free_udata(const struct scheduler *ops, void *priv)
  * It inserts units of moving domain to the scheduler's RunQ in
  * dest. cpupool.
  */
-static void
+static void cf_check
 rt_unit_insert(const struct scheduler *ops, struct sched_unit *unit)
 {
     struct rt_unit *svc = rt_unit(unit);
@@ -901,7 +901,7 @@ rt_unit_insert(const struct scheduler *ops, struct sched_unit *unit)
 /*
  * Remove rt_unit svc from the old scheduler in source cpupool.
  */
-static void
+static void cf_check
 rt_unit_remove(const struct scheduler *ops, struct sched_unit *unit)
 {
     struct rt_unit * const svc = rt_unit(unit);
@@ -1042,7 +1042,7 @@ runq_pick(const struct scheduler *ops, const cpumask_t *mask, unsigned int cpu)
  * schedule function for rt scheduler.
  * The lock is already grabbed in schedule.c, no need to lock here
  */
-static void
+static void cf_check
 rt_schedule(const struct scheduler *ops, struct sched_unit *currunit,
             s_time_t now, bool tasklet_work_scheduled)
 {
@@ -1129,7 +1129,7 @@ rt_schedule(const struct scheduler *ops, struct sched_unit *currunit,
  * Remove UNIT from RunQ
  * The lock is already grabbed in schedule.c, no need to lock here
  */
-static void
+static void cf_check
 rt_unit_sleep(const struct scheduler *ops, struct sched_unit *unit)
 {
     struct rt_unit * const svc = rt_unit(unit);
@@ -1244,7 +1244,7 @@ runq_tickle(const struct scheduler *ops, const struct rt_unit *new)
  * The lock is already grabbed in schedule.c, no need to lock here
  * TODO: what if these two units belongs to the same domain?
  */
-static void
+static void cf_check
 rt_unit_wake(const struct scheduler *ops, struct sched_unit *unit)
 {
     struct rt_unit * const svc = rt_unit(unit);
@@ -1314,7 +1314,7 @@ rt_unit_wake(const struct scheduler *ops, struct sched_unit *unit)
  * scurr has finished context switch, insert it back to the RunQ,
  * and then pick the highest priority unit from runq to run
  */
-static void
+static void cf_check
 rt_context_saved(const struct scheduler *ops, struct sched_unit *unit)
 {
     struct rt_unit *svc = rt_unit(unit);
@@ -1341,7 +1341,7 @@ rt_context_saved(const struct scheduler *ops, struct sched_unit *unit)
 /*
  * set/get each unit info of each domain
  */
-static int
+static int cf_check
 rt_dom_cntl(
     const struct scheduler *ops,
     struct domain *d,
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:05:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:05:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271649.466257 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb2M-0002Y1-8x; Mon, 14 Feb 2022 13:05:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271649.466257; Mon, 14 Feb 2022 13:05:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb2L-0002WP-Tm; Mon, 14 Feb 2022 13:05:01 +0000
Received: by outflank-mailman (input) for mailman id 271649;
 Mon, 14 Feb 2022 13:04:59 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJb2J-00023t-HR
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:04:59 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b44e322f-8d96-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 14:04:56 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b44e322f-8d96-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644843897;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=EY8ZkarZcewNBxs9p+GIs0w3h02UIU90azGWZSpiIn8=;
  b=OPx2bTsGVKk/62xkkCWnEYIam2zc40r8dNaavU1wSyynBFx+//M1zkrV
   pobGNGB9Fu/qah8WF+Ay239riHTBhtIWEM4Rc5pHLGUZBKC9/Y70carTR
   9izE0looKvP3jVrU6ffUh3AEOy3PSeJr8UbS5IjT6irMFy8n0kjeCRpXt
   U=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: lrGRbVeK6QOXSw5wAUcVhWcw7xA8/bUr8mDWXFRSxZpgxHVy02daTvWPD8OITqMjreflBfYFav
 +yyMZ5ougwpaZ56EPOY33dIfArG99TFW3Cn2p78/E3yB3QxLOKhgjRFtQERfGRJH9tlHTD2hlL
 8g4FO0eWLCaIRtdXOuMngBwtPVB35bqzJi9eWiupePa1m4/ormn/FSbVthalZ4ahKoDdKjhNiC
 D6M1a6o0HutMBDhRjv+zFDUYWph7F+iYLtuscB6qVRK8Z2+2sSJiIEI1PcxumX6B1bN/TZFH5b
 lXIoxcXKGR7IobCA5G8LuCMx
X-SBRS: 5.1
X-MesageID: 64149659
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:RlvXQqm8pA1lK+JTilOzsl7o5gyeIURdPkR7XQ2eYbSJt1+Wr1Gzt
 xJKW2mBOvmKMDD9f4glbtvioE4Ov5SHmtRqGVNkqCAxESMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BClVlxJVF/fngqoDUUYYoAQgsA180IMsdoUg7wbRh2Nc02YHR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 MQOiYa2bwknB7LRk9pNcyRXPhF7MJQTrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBODtMJkSpTdLyjbBAOx9aZvCX7/L9ZlT2zJYasVmQ6qHO
 5tHNGsHgBLobQETJA0xT4oEgbmTrSXQWTxCknaxqv9ii4TU5FMoi+W8WDbPQfSaSMMQkkuGq
 2bu+2XiHgpcJNGZ0SCC8H+nmqnIhyyTZW4JPOTmrLgw2gTVnzFNTk1NPbemnRWnol/9Z8hZD
 UIawzUzppZi1HGkY+n4UiTt9RZooSUgc9ZXFuQ77iSExazV/xuVCwA4c9JRVDA1nJRoHGJ3j
 zdli/usXGUy6+PNFRpx45/J9WvaBMQDEYMVicbopyMh6sKrnow8hwmnoj1LQP/s1Y2d9d0dL
 lm3QMkCa1c70JRjO0aTpwmvb9eQSn/hFFBd2+kvdjj5hj6Vnab8D2BS1XDV7OxbMKGSRUSbs
 X4PlqC2tb5SUc7dxHHQGLxWRtlFAspp1xWG3zZS82QJrWzxqxZPg6gMiN2BGKuZGpldImK4C
 KMikQhQ+IVSLBOXgVxfOOqM5zAR5fG4T7zND6mMBvIXO8QZXFLXrUlGOB/Lt0iwwRdErE3KE
 crCGSpaJS1BUvoPIfvfb7p17ILHMQhgmT2NFcqmk3xKE9O2PRaodFvMC3PWBshR0U9OiFm9H
 w93O5TYxhNBfvf5ZyWLo4cfIUpTdSowBIzsqtwRfemGe1I0FGYkAv7X4LUgZ406wPgFyraWp
 imwCh1C1V7ypXzbMgHWOHptX6ziAMRkpnUhMC1yYVvxgyo/YZyi5bs0focseeV17/RqyPN5F
 qFXe8iJDvlVZC7A/jARMcv0oIB4LUz5jgOSJSu1JjM4esc4FQDO/9bleCrp9TUPUXXr5Zdv/
 eX421qCE5QZRglkAMLHU96Vzgu87SoHheZ/f0rUOd0PKk/ix5dndn7qhfgtLsBSdRianmmG1
 xybCAszrPXWp9Nn68HAgK2Jotv7E+Z6GUYGTWDX4azvaHvf92unh4RBTPyJbXbWU2atoPeuY
 uBczvfdNvwbnQkV79ogQugzla9utcHyo7J6zxh/GCSZZlumPbpsP32a0JQdraZK3LJY5VO7V
 0/nFgO24llV1BcJyGIsGTc=
IronPort-HdrOrdr: A9a23:eA9V96uD7sAP5RijWtAMYd087skDdNV00zEX/kB9WHVpmszxra
 6TdZUgpGbJYVkqOE3I9ertBEDEewK4yXcX2/h2AV7BZniEhILAFugLhuGO/9SjIVybygc079
 YGT0EUMrzN5DZB4voSmDPIceod/A==
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="64149659"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v2 14/70] xen: CFI hardening for init_timer()
Date: Mon, 14 Feb 2022 12:50:31 +0000
Message-ID: <20220214125127.17985-15-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

Control Flow Integrity schemes use toolchain and optionally hardware support
to help protect against call/jump/return oriented programming attacks.

Use cf_check to annotate function pointer targets for the toolchain.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
 xen/arch/x86/cpu/mcheck/amd_nonfatal.c |  2 +-
 xen/arch/x86/cpu/mcheck/non-fatal.c    |  2 +-
 xen/arch/x86/hvm/pmtimer.c             |  2 +-
 xen/arch/x86/hvm/rtc.c                 |  6 +++---
 xen/arch/x86/hvm/viridian/time.c       |  2 +-
 xen/arch/x86/hvm/vpt.c                 |  2 +-
 xen/arch/x86/irq.c                     |  4 ++--
 xen/arch/x86/nmi.c                     |  2 +-
 xen/arch/x86/time.c                    |  4 ++--
 xen/common/rcupdate.c                  |  2 +-
 xen/common/sched/core.c                | 18 +++++++++---------
 xen/common/sched/credit.c              | 10 ++++------
 xen/common/sched/credit2.c             |  2 +-
 xen/common/sched/rt.c                  |  5 +++--
 xen/drivers/char/ehci-dbgp.c           |  2 +-
 xen/drivers/char/ns16550.c             |  6 +++---
 xen/drivers/cpufreq/cpufreq_ondemand.c |  2 +-
 17 files changed, 36 insertions(+), 37 deletions(-)

diff --git a/xen/arch/x86/cpu/mcheck/amd_nonfatal.c b/xen/arch/x86/cpu/mcheck/amd_nonfatal.c
index 6e8901530a69..da0bf85f0223 100644
--- a/xen/arch/x86/cpu/mcheck/amd_nonfatal.c
+++ b/xen/arch/x86/cpu/mcheck/amd_nonfatal.c
@@ -127,7 +127,7 @@ static void mce_amd_checkregs(void *info)
  * multiple correctable errors between two polls. In that case,
  * increase polling frequency higher than normal.
  */
-static void mce_amd_work_fn(void *data)
+static void cf_check mce_amd_work_fn(void *data)
 {
 	on_each_cpu(mce_amd_checkregs, data, 1);
 
diff --git a/xen/arch/x86/cpu/mcheck/non-fatal.c b/xen/arch/x86/cpu/mcheck/non-fatal.c
index 2679c220a8a2..f7e411c0870e 100644
--- a/xen/arch/x86/cpu/mcheck/non-fatal.c
+++ b/xen/arch/x86/cpu/mcheck/non-fatal.c
@@ -67,7 +67,7 @@ static void mce_checkregs (void *info)
 	}
 }
 
-static void mce_work_fn(void *data)
+static void cf_check mce_work_fn(void *data)
 { 
 	on_each_cpu(mce_checkregs, NULL, 1);
 
diff --git a/xen/arch/x86/hvm/pmtimer.c b/xen/arch/x86/hvm/pmtimer.c
index 97b9e41712fa..808819d1de91 100644
--- a/xen/arch/x86/hvm/pmtimer.c
+++ b/xen/arch/x86/hvm/pmtimer.c
@@ -124,7 +124,7 @@ static void pmt_update_time(PMTState *s)
 /* This function should be called soon after each time the MSB of the
  * pmtimer register rolls over, to make sure we update the status
  * registers and SCI at least once per rollover */
-static void pmt_timer_callback(void *opaque)
+static void cf_check pmt_timer_callback(void *opaque)
 {
     PMTState *s = opaque;
     uint32_t pmt_cycles_until_flip;
diff --git a/xen/arch/x86/hvm/rtc.c b/xen/arch/x86/hvm/rtc.c
index 3150f5f1479b..09d3501276bc 100644
--- a/xen/arch/x86/hvm/rtc.c
+++ b/xen/arch/x86/hvm/rtc.c
@@ -217,7 +217,7 @@ static void check_update_timer(RTCState *s)
         s->use_timer = 0;
 }
 
-static void rtc_update_timer(void *opaque)
+static void cf_check rtc_update_timer(void *opaque)
 {
     RTCState *s = opaque;
 
@@ -230,7 +230,7 @@ static void rtc_update_timer(void *opaque)
     spin_unlock(&s->lock);
 }
 
-static void rtc_update_timer2(void *opaque)
+static void cf_check rtc_update_timer2(void *opaque)
 {
     RTCState *s = opaque;
 
@@ -421,7 +421,7 @@ static void alarm_timer_update(RTCState *s)
     }
 }
 
-static void rtc_alarm_cb(void *opaque)
+static void cf_check rtc_alarm_cb(void *opaque)
 {
     RTCState *s = opaque;
 
diff --git a/xen/arch/x86/hvm/viridian/time.c b/xen/arch/x86/hvm/viridian/time.c
index 24ff117edb20..b56fd6766292 100644
--- a/xen/arch/x86/hvm/viridian/time.c
+++ b/xen/arch/x86/hvm/viridian/time.c
@@ -126,7 +126,7 @@ static void stop_stimer(struct viridian_stimer *vs)
     vs->started = false;
 }
 
-static void stimer_expire(void *data)
+static void cf_check stimer_expire(void *data)
 {
     struct viridian_stimer *vs = data;
     struct vcpu *v = vs->v;
diff --git a/xen/arch/x86/hvm/vpt.c b/xen/arch/x86/hvm/vpt.c
index 6fdc3e19fe8c..cb1d81bf9e82 100644
--- a/xen/arch/x86/hvm/vpt.c
+++ b/xen/arch/x86/hvm/vpt.c
@@ -271,7 +271,7 @@ void pt_restore_timer(struct vcpu *v)
     pt_vcpu_unlock(v);
 }
 
-static void pt_timer_fn(void *data)
+static void cf_check pt_timer_fn(void *data)
 {
     struct periodic_time *pt = data;
 
diff --git a/xen/arch/x86/irq.c b/xen/arch/x86/irq.c
index bcf46cd54d16..f9c808455535 100644
--- a/xen/arch/x86/irq.c
+++ b/xen/arch/x86/irq.c
@@ -935,7 +935,7 @@ void alloc_direct_apic_vector(
     spin_unlock(&lock);
 }
 
-static void irq_ratelimit_timer_fn(void *data)
+static void cf_check irq_ratelimit_timer_fn(void *data)
 {
     struct irq_desc *desc, *tmp;
     unsigned long flags;
@@ -1129,7 +1129,7 @@ static inline void clear_pirq_eoi(struct domain *d, unsigned int irq)
 
 static void set_eoi_ready(void *data);
 
-static void irq_guest_eoi_timer_fn(void *data)
+static void cf_check irq_guest_eoi_timer_fn(void *data)
 {
     struct irq_desc *desc = data;
     unsigned int i, irq = desc - irq_desc;
diff --git a/xen/arch/x86/nmi.c b/xen/arch/x86/nmi.c
index 5c101a9f97b3..c8ae4a5d7460 100644
--- a/xen/arch/x86/nmi.c
+++ b/xen/arch/x86/nmi.c
@@ -211,7 +211,7 @@ void __init check_nmi_watchdog(void)
     return;
 }
 
-static void nmi_timer_fn(void *unused)
+static void cf_check nmi_timer_fn(void *unused)
 {
     this_cpu(nmi_timer_ticks)++;
     set_timer(&this_cpu(nmi_timer), NOW() + MILLISECS(1000));
diff --git a/xen/arch/x86/time.c b/xen/arch/x86/time.c
index 14f7d3fd635e..fac97023bf10 100644
--- a/xen/arch/x86/time.c
+++ b/xen/arch/x86/time.c
@@ -815,7 +815,7 @@ static s_time_t __read_platform_stime(u64 platform_time)
     return (stime_platform_stamp + scale_delta(diff, &plt_scale));
 }
 
-static void plt_overflow(void *unused)
+static void cf_check plt_overflow(void *unused)
 {
     int i;
     u64 count;
@@ -1855,7 +1855,7 @@ static void time_calibration_nop_rendezvous(void *rv)
 static void (*time_calibration_rendezvous_fn)(void *) =
     time_calibration_std_rendezvous;
 
-static void time_calibration(void *unused)
+static void cf_check time_calibration(void *unused)
 {
     struct calibration_rendezvous r = {
         .semaphore = ATOMIC_INIT(0)
diff --git a/xen/common/rcupdate.c b/xen/common/rcupdate.c
index 2ec5606de5dd..f9dd2584a8b7 100644
--- a/xen/common/rcupdate.c
+++ b/xen/common/rcupdate.c
@@ -575,7 +575,7 @@ static void rcu_idle_timer_stop(void)
         stop_timer(&rdp->idle_timer);
 }
 
-static void rcu_idle_timer_handler(void* data)
+static void cf_check rcu_idle_timer_handler(void* data)
 {
     perfc_incr(rcu_idle_timer);
 
diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c
index 4a79971a1d45..cf1ba01b4d87 100644
--- a/xen/common/sched/core.c
+++ b/xen/common/sched/core.c
@@ -71,10 +71,10 @@ cpumask_t sched_res_mask;
 static DEFINE_SPINLOCK(sched_free_cpu_lock);
 
 /* Various timer handlers. */
-static void s_timer_fn(void *unused);
-static void vcpu_periodic_timer_fn(void *data);
-static void vcpu_singleshot_timer_fn(void *data);
-static void poll_timer_fn(void *data);
+static void cf_check s_timer_fn(void *unused);
+static void cf_check vcpu_periodic_timer_fn(void *data);
+static void cf_check vcpu_singleshot_timer_fn(void *data);
+static void cf_check poll_timer_fn(void *data);
 
 /* This is global for now so that private implementations can reach it */
 DEFINE_PER_CPU_READ_MOSTLY(struct sched_resource *, sched_res);
@@ -1535,7 +1535,7 @@ long vcpu_yield(void)
     return 0;
 }
 
-static void domain_watchdog_timeout(void *data)
+static void cf_check domain_watchdog_timeout(void *data)
 {
     struct domain *d = data;
 
@@ -2697,28 +2697,28 @@ static void schedule(void)
 }
 
 /* The scheduler timer: force a run through the scheduler */
-static void s_timer_fn(void *unused)
+static void cf_check s_timer_fn(void *unused)
 {
     raise_softirq(SCHEDULE_SOFTIRQ);
     SCHED_STAT_CRANK(sched_irq);
 }
 
 /* Per-VCPU periodic timer function: sends a virtual timer interrupt. */
-static void vcpu_periodic_timer_fn(void *data)
+static void cf_check vcpu_periodic_timer_fn(void *data)
 {
     struct vcpu *v = data;
     vcpu_periodic_timer_work(v);
 }
 
 /* Per-VCPU single-shot timer function: sends a virtual timer interrupt. */
-static void vcpu_singleshot_timer_fn(void *data)
+static void cf_check vcpu_singleshot_timer_fn(void *data)
 {
     struct vcpu *v = data;
     send_timer_event(v);
 }
 
 /* SCHEDOP_poll timeout callback. */
-static void poll_timer_fn(void *data)
+static void cf_check poll_timer_fn(void *data)
 {
     struct vcpu *v = data;
 
diff --git a/xen/common/sched/credit.c b/xen/common/sched/credit.c
index d0aa017c643e..5635271f6fea 100644
--- a/xen/common/sched/credit.c
+++ b/xen/common/sched/credit.c
@@ -230,8 +230,8 @@ struct csched_private {
     struct timer master_ticker;
 };
 
-static void csched_tick(void *_cpu);
-static void csched_acct(void *dummy);
+static void cf_check csched_tick(void *_cpu);
+static void cf_check csched_acct(void *dummy);
 
 static inline int
 __unit_on_runq(const struct csched_unit *svc)
@@ -1356,8 +1356,7 @@ csched_runq_sort(struct csched_private *prv, unsigned int cpu)
     pcpu_schedule_unlock_irqrestore(lock, flags, cpu);
 }
 
-static void
-csched_acct(void* dummy)
+static void cf_check csched_acct(void* dummy)
 {
     struct csched_private *prv = dummy;
     unsigned long flags;
@@ -1563,8 +1562,7 @@ csched_acct(void* dummy)
     set_timer( &prv->master_ticker, NOW() + prv->tslice);
 }
 
-static void
-csched_tick(void *_cpu)
+static void cf_check csched_tick(void *_cpu)
 {
     unsigned int cpu = (unsigned long)_cpu;
     const struct sched_resource *sr = get_sched_res(cpu);
diff --git a/xen/common/sched/credit2.c b/xen/common/sched/credit2.c
index a5f073cda51e..d96e2749ddfb 100644
--- a/xen/common/sched/credit2.c
+++ b/xen/common/sched/credit2.c
@@ -2072,7 +2072,7 @@ static inline void do_replenish(struct csched2_dom *sdom)
     sdom->budget += sdom->tot_budget;
 }
 
-static void replenish_domain_budget(void* data)
+static void cf_check replenish_domain_budget(void *data)
 {
     struct csched2_dom *sdom = data;
     unsigned long flags;
diff --git a/xen/common/sched/rt.c b/xen/common/sched/rt.c
index c24cd2ac3200..5ea6f01f263c 100644
--- a/xen/common/sched/rt.c
+++ b/xen/common/sched/rt.c
@@ -173,7 +173,7 @@
 #define TRC_RTDS_SCHED_TASKLET    TRC_SCHED_CLASS_EVT(RTDS, 5)
 #define TRC_RTDS_SCHEDULE         TRC_SCHED_CLASS_EVT(RTDS, 6)
 
-static void repl_timer_handler(void *data);
+static void cf_check repl_timer_handler(void *data);
 
 /*
  * System-wide private data, include global RunQueue/DepletedQ
@@ -1452,7 +1452,8 @@ rt_dom_cntl(
  * The replenishment timer handler picks units
  * from the replq and does the actual replenishment.
  */
-static void repl_timer_handler(void *data){
+static void cf_check repl_timer_handler(void *data)
+{
     s_time_t now;
     const struct scheduler *ops = data;
     struct rt_private *prv = rt_priv(ops);
diff --git a/xen/drivers/char/ehci-dbgp.c b/xen/drivers/char/ehci-dbgp.c
index c893d246defa..a6b57fdf2d19 100644
--- a/xen/drivers/char/ehci-dbgp.c
+++ b/xen/drivers/char/ehci-dbgp.c
@@ -1289,7 +1289,7 @@ static void _ehci_dbgp_poll(struct cpu_user_regs *regs)
     set_timer(&dbgp->timer, NOW() + timeout);
 }
 
-static void ehci_dbgp_poll(void *data)
+static void cf_check ehci_dbgp_poll(void *data)
 {
     poll_port = data;
 #ifdef run_in_exception_handler
diff --git a/xen/drivers/char/ns16550.c b/xen/drivers/char/ns16550.c
index 30596d60d4ed..990cad39fe85 100644
--- a/xen/drivers/char/ns16550.c
+++ b/xen/drivers/char/ns16550.c
@@ -111,7 +111,7 @@ struct ns16550_config_param {
 static void enable_exar_enhanced_bits(const struct ns16550 *uart);
 #endif
 
-static void ns16550_delayed_resume(void *data);
+static void cf_check ns16550_delayed_resume(void *data);
 
 static u8 ns_read_reg(const struct ns16550 *uart, unsigned int reg)
 {
@@ -229,7 +229,7 @@ static void __ns16550_poll(struct cpu_user_regs *regs)
     set_timer(&uart->timer, NOW() + MILLISECS(uart->timeout_ms));
 }
 
-static void ns16550_poll(void *data)
+static void cf_check ns16550_poll(void *data)
 {
     this_cpu(poll_port) = data;
 #ifdef run_in_exception_handler
@@ -532,7 +532,7 @@ static void _ns16550_resume(struct serial_port *port)
 }
 
 static int delayed_resume_tries;
-static void ns16550_delayed_resume(void *data)
+static void cf_check ns16550_delayed_resume(void *data)
 {
     struct serial_port *port = data;
     struct ns16550 *uart = port->uart;
diff --git a/xen/drivers/cpufreq/cpufreq_ondemand.c b/xen/drivers/cpufreq/cpufreq_ondemand.c
index cabd9ffa8886..ba03eaa2336d 100644
--- a/xen/drivers/cpufreq/cpufreq_ondemand.c
+++ b/xen/drivers/cpufreq/cpufreq_ondemand.c
@@ -172,7 +172,7 @@ static void dbs_check_cpu(struct cpu_dbs_info_s *this_dbs_info)
     }
 }
 
-static void do_dbs_timer(void *dbs)
+static void cf_check do_dbs_timer(void *dbs)
 {
     struct cpu_dbs_info_s *dbs_info = (struct cpu_dbs_info_s *)dbs;
 
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:05:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:05:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271650.466264 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb2N-0002fZ-7t; Mon, 14 Feb 2022 13:05:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271650.466264; Mon, 14 Feb 2022 13:05:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb2M-0002bY-JY; Mon, 14 Feb 2022 13:05:02 +0000
Received: by outflank-mailman (input) for mailman id 271650;
 Mon, 14 Feb 2022 13:05:01 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJb2L-0008IH-7o
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:05:01 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b6cd002b-8d96-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 14:04:59 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b6cd002b-8d96-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644843899;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=9zLsHHpejok3Sem3a+Qat8nhch9ye50iKMyyHAXlbbs=;
  b=eJxic+s/otc3Jj5qPM8P8IACeaLptYMAkJ19jqbMKkHEfm7huJKvAwaE
   eGwzwHC+f8NsUVYYgU4KmQ/sWM/0RpDIfMovKnXqwF1OhbXAtsGA4wz3e
   TYFGJOc93mm1WfgiY4f9cj6VHAQnvO0QElF0EKmM93oFDnnw/JypFRtJR
   4=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: xcTQUaIPJGzv7edGZ7Uz35El+vDV1JsKrBHiS+3rDuhHYjmKuY8vv5VR5b1rrpeBzlLlCEqv0c
 dmfSqEI2Hig5hgrIez65nIcM5cdVKl/oRrTqarHmFJsrucJuf+BxdkapFQJpOCMtjD09Z7iPyp
 ukggPEGO9NVZwksBxgYgI4699HNWsDPhKz4cCdcUKlOBQthLYW7JjaF/rIjH6ZxxYzhVka9+Ng
 8+8KI0+s2/Ch++Bq3glKChozkLSaMdDzMvbo+fKcsSuWLxpifzTJNnoKBdi3tF7EQ9TexNyEa/
 c3UGOT9mUGx48+PptAUVkNiR
X-SBRS: 5.1
X-MesageID: 64149336
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:eqHeI6Amv+P9eRVW/xXkw5YqxClBgxIJ4kV8jS/XYbTApD1zgzEAx
 mNKCj2AOffeY2b2ed1waITl908Hu8PRz4BqQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMo/u1Si6FatANl1ElvU2zbue6WL6s1hxZH1c+En970E47wobVv6Yz6TSHK1LV0
 T/Ni5W31G+Ng1aY5UpNtspvADs21BjDkGtwUm4WPJinj3eH/5UhN7oNJLnZEpfNatI88thW5
 Qr05OrREmvxp3/BAz4++1rxWhVirrX6ZWBihpfKMkQLb9crSiEai84G2PQghUh/qiu0o+sv6
 +lxn4GveForH7Lcpb0cTEwNe81+FfUuFL7vJHG+tYqYzlHccmuqyPJrZK00FdRGoKAtWzgIr
 KFGbmBWBvyAr7veLLaTY+9gnMk8auLsO5sSoCpIxjDFF/c2B5vERs0m4PcGgG5s15sVQ54yY
 eJCdx9hNg3wYiZtO08QELUftbys3F3wJmgwRFW9+vNsvjm7IBZK+KfpGMrYfJqNX8o9tmSyq
 3/C/m/5KgoHL9HZwj2Amlq8i+mKkS7lVYY6ELyj6uUskFCV3nYUChAdSR28u/bRt6Klc4sBc
 QpOoHNo9PVsshzwJjXgY/GmiF+agyInBflsL8cn9zDQyIvL8zvAB3dRG1atd+canMMxQDUr0
 HqAkNXoGSFjvdWpdJ6NyluHhWjsYHZIdAfucQdBFFJYuIe7/OnfmzqSFo4LLUKjsjHi9dgcK
 RiupTN2ubgchNVjO06TrQGe2GLESnQko2cICuTrsoCNs1kRiG2NPdXABb3nARFodtjxc7V5l
 CJY8/VyFchXZX13qASDQf8WAJai7OufPTvXjDZHRsd9q2v9qyP+JdkLulmSwXuF1e5eJ1fUj
 LL741sNtPe/wlP2BUOIX25BI5tzlvWxfTgUfvvVcsBPcvBMmPyvp0lTibqr9zm1yiAEyPhnU
 b/CKJrEJStKWMxPkWvtL89AgOBD+8zL7T6KLXwN50/8iuT2ib/8YeptDWZimchnsP3a8F+Ir
 76y9aKikn1ibQE3WQGPmaZ7ELzABSRT6Unep5MFe+idDBBhHW19Wfbdzal4I95unrhPl/eO9
 Xa4AxcKxF36jHzBCAOLdnE8N++/Acch9So2bX42IFKl+3k/eoLzvq0RQIQ6IOs8/+t5wP8qE
 /RcI5ecAu5CQyjs8igGacWvt5RrcRmm3FrcPyesbDUlUYRnQgjFpo3tcgf1rXFcBSurr8ou5
 ban01qDE5YEQg1jCufQae6ukAzt7SRMxroqUhKRcNdJeUjq/Ix7EADLj6c6c5MWNBHO5jqGz
 ALKUx0WkvbA/t0u+97TiKHa84rwS7liHlBXFnXw5KqtMXWI5XKqxIJNXbrafT3ZU2+oqqyua
 f8MkqP5OfwD2l1Lr5B9A/Bgyqdnv4njoLpTzwJFGnTXbgv0VuM8cyfehcQf5LdQwrJ5uBetX
 hPd89ZXDryFJcf5HQNDPwEidOmCiakZlzS6AS7Z+6kmCPubJIa6bHg=
IronPort-HdrOrdr: A9a23:gzxQqKxkV11NCBrsECGWKrPwLr1zdoMgy1knxilNoRw8SKKlfq
 GV7Y0mPHDP6Ar5NEtNpTnEAtjkfZq+z+8S3WByB8bAYOCOggLBR+sO0WKh+UyFJ8SXzJ876U
 4KSclD4bPLYmSS9fyKgjWFLw==
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="64149336"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>
Subject: [PATCH v2 68/70] x86/setup: Rework MSR_S_CET handling for CET-IBT
Date: Mon, 14 Feb 2022 12:51:25 +0000
Message-ID: <20220214125127.17985-69-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

CET-SS and CET-IBT can be independently controlled, so the configuration of
MSR_S_CET can't be constant any more.

Introduce xen_msr_s_cet_value(), mostly because I don't fancy
writing/maintaining that logic in assembly.  Use this in the 3 paths which
alter MSR_S_CET when both features are potentially active.

To active CET-IBT, we only need CR4.CET and MSR_S_CET.ENDBR_EN.  This is
common with the CET-SS setup, so reorder the operations to set up CR4 and
MSR_S_CET for any nonzero result from xen_msr_s_cet_value(), and set up
MSR_PL0_SSP and SSP if SHSTK_EN was also set.

Adjust the crash path to disable CET-IBT too.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>

v2:
 * Asm adjustments.  Add comments regarding safety.
---
 xen/arch/x86/acpi/wakeup_prot.S      | 38 ++++++++++++++++++++++--------------
 xen/arch/x86/boot/x86_64.S           | 30 +++++++++++++++++-----------
 xen/arch/x86/crash.c                 |  4 ++--
 xen/arch/x86/include/asm/msr-index.h |  1 +
 xen/arch/x86/setup.c                 | 17 +++++++++++++++-
 5 files changed, 61 insertions(+), 29 deletions(-)

diff --git a/xen/arch/x86/acpi/wakeup_prot.S b/xen/arch/x86/acpi/wakeup_prot.S
index 15052c300fa1..3855ff1ddb94 100644
--- a/xen/arch/x86/acpi/wakeup_prot.S
+++ b/xen/arch/x86/acpi/wakeup_prot.S
@@ -63,7 +63,26 @@ ENTRY(s3_resume)
         pushq   %rax
         lretq
 1:
-#ifdef CONFIG_XEN_SHSTK
+#if defined(CONFIG_XEN_SHSTK) || defined(CONFIG_XEN_IBT)
+        call    xen_msr_s_cet_value
+        test    %eax, %eax
+        jz      .L_cet_done
+
+        /* Set up MSR_S_CET. */
+        mov     $MSR_S_CET, %ecx
+        xor     %edx, %edx
+        wrmsr
+
+        /* Enable CR4.CET. */
+        mov     $XEN_MINIMAL_CR4 | X86_CR4_CET, %ecx
+        mov     %rcx, %cr4
+
+        /* WARNING! call/ret now fatal (iff SHSTK) until SETSSBSY loads SSP */
+
+#if defined(CONFIG_XEN_SHSTK)
+        test    $CET_SHSTK_EN, %al
+        jz      .L_cet_done
+
         /*
          * Restoring SSP is a little complicated, because we are intercepting
          * an in-use shadow stack.  Write a temporary token under the stack,
@@ -71,14 +90,6 @@ ENTRY(s3_resume)
          * reset MSR_PL0_SSP to its usual value and pop the temporary token.
          */
         mov     saved_ssp(%rip), %rdi
-        cmpq    $1, %rdi
-        je      .L_shstk_done
-
-        /* Set up MSR_S_CET. */
-        mov     $MSR_S_CET, %ecx
-        xor     %edx, %edx
-        mov     $CET_SHSTK_EN | CET_WRSS_EN, %eax
-        wrmsr
 
         /* Construct the temporary supervisor token under SSP. */
         sub     $8, %rdi
@@ -90,10 +101,6 @@ ENTRY(s3_resume)
         mov     %edi, %eax
         wrmsr
 
-        /* Enable CET.  MSR_INTERRUPT_SSP_TABLE is set up later in load_system_tables(). */
-        mov     $XEN_MINIMAL_CR4 | X86_CR4_CET, %ebx
-        mov     %rbx, %cr4
-
         /* Write the temporary token onto the shadow stack, and activate it. */
         wrssq   %rdi, (%rdi)
         setssbsy
@@ -106,8 +113,9 @@ ENTRY(s3_resume)
         /* Pop the temporary token off the stack. */
         mov     $2, %eax
         incsspd %eax
-.L_shstk_done:
-#endif
+#endif /* CONFIG_XEN_SHSTK */
+.L_cet_done:
+#endif /* CONFIG_XEN_SHSTK || CONFIG_XEN_IBT */
 
         call    load_system_tables
 
diff --git a/xen/arch/x86/boot/x86_64.S b/xen/arch/x86/boot/x86_64.S
index 27f52e7a7708..fa41990dde0f 100644
--- a/xen/arch/x86/boot/x86_64.S
+++ b/xen/arch/x86/boot/x86_64.S
@@ -30,18 +30,27 @@ ENTRY(__high_start)
         test    %ebx,%ebx
         jz      .L_bsp
 
-        /* APs.  Set up shadow stacks before entering C. */
-#ifdef CONFIG_XEN_SHSTK
-        testl   $cpufeat_mask(X86_FEATURE_XEN_SHSTK), \
-                CPUINFO_FEATURE_OFFSET(X86_FEATURE_XEN_SHSTK) + boot_cpu_data(%rip)
-        je      .L_ap_shstk_done
+        /* APs.  Set up CET before entering C properly. */
+#if defined(CONFIG_XEN_SHSTK) || defined(CONFIG_XEN_IBT)
+        call    xen_msr_s_cet_value
+        test    %eax, %eax
+        jz      .L_ap_cet_done
 
         /* Set up MSR_S_CET. */
         mov     $MSR_S_CET, %ecx
         xor     %edx, %edx
-        mov     $CET_SHSTK_EN | CET_WRSS_EN, %eax
         wrmsr
 
+        /* Enable CR4.CET. */
+        mov     $XEN_MINIMAL_CR4 | X86_CR4_CET, %ecx
+        mov     %rcx, %cr4
+
+        /* WARNING! call/ret now fatal (iff SHSTK) until SETSSBSY loads SSP */
+
+#if defined(CONFIG_XEN_SHSTK)
+        test    $CET_SHSTK_EN, %al
+        jz      .L_ap_cet_done
+
         /* Derive MSR_PL0_SSP from %rsp (token written when stack is allocated). */
         mov     $MSR_PL0_SSP, %ecx
         mov     %rsp, %rdx
@@ -51,13 +60,12 @@ ENTRY(__high_start)
         or      $(PRIMARY_SHSTK_SLOT + 1) * PAGE_SIZE - 8, %eax
         wrmsr
 
-        /* Enable CET.  MSR_INTERRUPT_SSP_TABLE is set up later in load_system_tables(). */
-        mov     $XEN_MINIMAL_CR4 | X86_CR4_CET, %ecx
-        mov     %rcx, %cr4
         setssbsy
-#endif
 
-.L_ap_shstk_done:
+#endif /* CONFIG_XEN_SHSTK */
+.L_ap_cet_done:
+#endif /* CONFIG_XEN_SHSTK || CONFIG_XEN_IBT */
+
         call    start_secondary
         BUG     /* start_secondary() shouldn't return. */
 
diff --git a/xen/arch/x86/crash.c b/xen/arch/x86/crash.c
index c383f718f5bd..003222c0f1ac 100644
--- a/xen/arch/x86/crash.c
+++ b/xen/arch/x86/crash.c
@@ -190,8 +190,8 @@ void machine_crash_shutdown(void)
     /* Reset CPUID masking and faulting to the host's default. */
     ctxt_switch_levelling(NULL);
 
-    /* Disable shadow stacks. */
-    if ( cpu_has_xen_shstk )
+    /* Disable CET. */
+    if ( cpu_has_xen_shstk || cpu_has_xen_ibt )
     {
         wrmsrl(MSR_S_CET, 0);
         write_cr4(read_cr4() & ~X86_CR4_CET);
diff --git a/xen/arch/x86/include/asm/msr-index.h b/xen/arch/x86/include/asm/msr-index.h
index 9df1959fe5a1..3e038db618ff 100644
--- a/xen/arch/x86/include/asm/msr-index.h
+++ b/xen/arch/x86/include/asm/msr-index.h
@@ -117,6 +117,7 @@
 #define MSR_S_CET                           0x000006a2
 #define  CET_SHSTK_EN                       (_AC(1, ULL) <<  0)
 #define  CET_WRSS_EN                        (_AC(1, ULL) <<  1)
+#define  CET_ENDBR_EN                       (_AC(1, ULL) <<  2)
 
 #define MSR_PL0_SSP                         0x000006a4
 #define MSR_PL1_SSP                         0x000006a5
diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c
index 2b1192d85b77..f6a59d5f0412 100644
--- a/xen/arch/x86/setup.c
+++ b/xen/arch/x86/setup.c
@@ -670,6 +670,21 @@ static void noreturn init_done(void)
     startup_cpu_idle_loop();
 }
 
+#if defined(CONFIG_XEN_SHSTK) || defined(CONFIG_XEN_IBT)
+/*
+ * Used by AP and S3 asm code to calcualte the appropriate MSR_S_CET setting.
+ * Do not use on the BSP before reinit_bsp_stack(), or it may turn SHSTK on
+ * too early.
+ */
+unsigned int xen_msr_s_cet_value(void)
+{
+    return ((cpu_has_xen_shstk ? CET_SHSTK_EN | CET_WRSS_EN : 0) |
+            (cpu_has_xen_ibt   ? CET_ENDBR_EN : 0));
+}
+#else
+unsigned int xen_msr_s_cet_value(void); /* To avoid ifdefary */
+#endif
+
 /* Reinitalise all state referring to the old virtual address of the stack. */
 static void __init noreturn reinit_bsp_stack(void)
 {
@@ -693,7 +708,7 @@ static void __init noreturn reinit_bsp_stack(void)
     {
         wrmsrl(MSR_PL0_SSP,
                (unsigned long)stack + (PRIMARY_SHSTK_SLOT + 1) * PAGE_SIZE - 8);
-        wrmsrl(MSR_S_CET, CET_SHSTK_EN | CET_WRSS_EN);
+        wrmsrl(MSR_S_CET, xen_msr_s_cet_value());
         asm volatile ("setssbsy" ::: "memory");
     }
 
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:05:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:05:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271653.466279 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb2P-0003Nw-UJ; Mon, 14 Feb 2022 13:05:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271653.466279; Mon, 14 Feb 2022 13:05:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb2P-0003LQ-Ck; Mon, 14 Feb 2022 13:05:05 +0000
Received: by outflank-mailman (input) for mailman id 271653;
 Mon, 14 Feb 2022 13:05:03 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJb2N-00023t-C1
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:05:03 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b699f3dd-8d96-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 14:05:00 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b699f3dd-8d96-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644843901;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=Vmf+grYE8bKtbE+rcnkJIH/kZo6uatD1f3oilVOV1Mo=;
  b=dLJwZ9ACtIntA7zQuw9g97zLzcXOs8P1itm25ptg//lLPEE8Cru6NLZh
   MJA7ASW2pQ8L9gAt2dsAX3BLhKZwrv11JBSwneMPnqEbt9NSbooawiJBM
   iTQH4Yl6r+MHh12nvMW7XXJg39M0kAjrZQHkVC6Ifj1URpqCdPNz0mDLY
   g=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: H91983OJySle/XwUPf9C7ClRnyUt40HvBbr2gDnpRR7yQONQvm90NE4gklDMhWGB0bZEeUOBBI
 P9PXFmw5C2dhAChTv2st6OJ0gAL9nt1zq6RRV/CJW/Oe+5pCgK+qEjj5EhuIM0vD2gOpbRNzzH
 bwoJ+gIIsAXKPwrHlYDjJAQBFbCt6KeVJO2fqeTINuU+WOLrgaCHMUGjGzchIYPKifidrH+VC5
 X+Go0idnmudpB804gW1e0E7fQwYTASSOoMgMNeED6UEYdbZCjFsW3zWQxBEFY26vCJ3z/bKudP
 waVTpe3ebicex2b7Oy7eFN5d
X-SBRS: 5.1
X-MesageID: 63592493
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Dmg5K6jnt8cAp/aTP24tSKe0X161eRcKZh0ujC45NGQN5FlHY01je
 htvD2uEb/uPZTP9KI0kPtnj908DsJTRm9NgGgo5/CA2Riwb9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oAMKRCQ7InQLlbGILes1htZGEk0GE/NtTo5w7Rj2tQx3YDga++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /1NiYK5cywFApbundkgbTR7KTlkBLxJreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHCOo8Ft24m5jbeFfs8GrjIQrnQ5M8e1zA17ixLNaiFO
 ptDNWs0BPjGSxNUIAw1AY86p8brikL4XWRVsAvLjpNitgA/yyQuieOwYbI5YOeiVchT20qVu
 G/C12D4GQ0BcsySzyKf9XChjfOJmjn0ML/+D5XhqKQs2gfKgDVOVltGDjNXvMVVlGa+Z8xWE
 Wc4xhEMqJUPymGIdMHnZgy39SvsUgEnZ/JcFOgz6Qeow6XS4hqECmVscgOteODKp+dtG2V0i
 wbhc8fBQGU27ebLES71GqK88GvqURX5O1PucsPtoeEtx9D46L8+gRvUJjqIOP7k14alcd0cL
 t3jkcTfu1nxpZNRv0lY1Qqe695JmnQuZlRrjjg7pkr/smtEiHeNPuREE2Tz4/daN5q+RVKcp
 nUCkMX2xLlQUc3SxHzQHb1UR+vBCxO53Nr02wAHInXc3271py7LkX54vFmS23uFwu5bIGS0M
 Sc/SCta5YNJPWvCUEOES9nZNije9oC5TY6NfqmNNrJmO8EtHCfarHAGTRPBhAjFzRlz+ZzTz
 L/GKK5A+15BUv85pNd3Ls9AuYIWKtcWmz+CG8Cjl07/uVdcDVbMIYo43JK1RrhRxMu5TM/9q
 oY32xKix0oNXevgTDPQ9IJPf1kGIWJiXcL9qtBNd/7FKQ1jQTlzB/jUyLInWopkg6UKybuYo
 iDjAhdVmAjlmHnKCQSWcXQ/Ornhaoly8CAgNis2MFf2h3V6OdSz7L0SfoccdKU88LAx1uZ9S
 vQIIp3SAvlGRjnd1S4aaJ3x8N5reBix3FrcNCu5ejkvOZVnQlWRqNPjewLu8ggIDza26pRi8
 +HxiFuDTMNaFQp4DcvQZPa+9H+LvCAQyLBoQk/FAthPY0GwooJkHDP8060sKMYWJBSdmjbDj
 1SKAQ0VrPXmqpMu9IWbnriNqoqkHrcsHkdeGGWHv7+6OTODozimyI5EFu2JYSrcRCX//6D7P
 bdZyPT1MfsmmldWstUjT+Y3nPxmv9a/9aVHyglEHWnQawX5A7xtFXCKwM1Tu/Af3bReowa3B
 hqC99Qy1W9l4y85/Ir9/DYYU9k=
IronPort-HdrOrdr: A9a23:9wn6f69jvBhkISSWOupuk+DcI+orL9Y04lQ7vn2YSXRuE/Bw9v
 re5MjzuiWE6wr5NEtOpTnEAtjlfZq+z+8N3WByB8bBYOCOggLBR+sOgbcKgQeQfBEWntQts5
 uIGJIfNDSfNzZHZL7BkWyFL+o=
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="63592493"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v2 44/70] x86/pmu: CFI hardening
Date: Mon, 14 Feb 2022 12:51:01 +0000
Message-ID: <20220214125127.17985-45-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

Control Flow Integrity schemes use toolchain and optionally hardware support
to help protect against call/jump/return oriented programming attacks.

Use cf_check to annotate function pointer targets for the toolchain.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
 xen/arch/x86/cpu/vpmu_amd.c             | 16 ++++++++--------
 xen/arch/x86/cpu/vpmu_intel.c           | 16 ++++++++--------
 xen/arch/x86/oprofile/op_model_athlon.c | 16 ++++++++--------
 xen/arch/x86/oprofile/op_model_p4.c     | 14 +++++++-------
 xen/arch/x86/oprofile/op_model_ppro.c   | 26 ++++++++++++++------------
 5 files changed, 45 insertions(+), 43 deletions(-)

diff --git a/xen/arch/x86/cpu/vpmu_amd.c b/xen/arch/x86/cpu/vpmu_amd.c
index 25ad4ecf48a4..5963ce90150a 100644
--- a/xen/arch/x86/cpu/vpmu_amd.c
+++ b/xen/arch/x86/cpu/vpmu_amd.c
@@ -186,7 +186,7 @@ static void amd_vpmu_unset_msr_bitmap(struct vcpu *v)
     msr_bitmap_off(vpmu);
 }
 
-static int amd_vpmu_do_interrupt(struct cpu_user_regs *regs)
+static int cf_check amd_vpmu_do_interrupt(struct cpu_user_regs *regs)
 {
     return 1;
 }
@@ -206,7 +206,7 @@ static inline void context_load(struct vcpu *v)
     }
 }
 
-static int amd_vpmu_load(struct vcpu *v, bool_t from_guest)
+static int cf_check amd_vpmu_load(struct vcpu *v, bool from_guest)
 {
     struct vpmu_struct *vpmu = vcpu_vpmu(v);
     struct xen_pmu_amd_ctxt *ctxt;
@@ -280,7 +280,7 @@ static inline void context_save(struct vcpu *v)
         rdmsrl(counters[i], counter_regs[i]);
 }
 
-static int amd_vpmu_save(struct vcpu *v,  bool_t to_guest)
+static int cf_check amd_vpmu_save(struct vcpu *v,  bool to_guest)
 {
     struct vpmu_struct *vpmu = vcpu_vpmu(v);
     unsigned int i;
@@ -348,7 +348,7 @@ static void context_update(unsigned int msr, u64 msr_content)
     }
 }
 
-static int amd_vpmu_do_wrmsr(unsigned int msr, uint64_t msr_content)
+static int cf_check amd_vpmu_do_wrmsr(unsigned int msr, uint64_t msr_content)
 {
     struct vcpu *v = current;
     struct vpmu_struct *vpmu = vcpu_vpmu(v);
@@ -404,7 +404,7 @@ static int amd_vpmu_do_wrmsr(unsigned int msr, uint64_t msr_content)
     return 0;
 }
 
-static int amd_vpmu_do_rdmsr(unsigned int msr, uint64_t *msr_content)
+static int cf_check amd_vpmu_do_rdmsr(unsigned int msr, uint64_t *msr_content)
 {
     struct vcpu *v = current;
     struct vpmu_struct *vpmu = vcpu_vpmu(v);
@@ -422,7 +422,7 @@ static int amd_vpmu_do_rdmsr(unsigned int msr, uint64_t *msr_content)
     return 0;
 }
 
-static void amd_vpmu_destroy(struct vcpu *v)
+static void cf_check amd_vpmu_destroy(struct vcpu *v)
 {
     struct vpmu_struct *vpmu = vcpu_vpmu(v);
 
@@ -440,7 +440,7 @@ static void amd_vpmu_destroy(struct vcpu *v)
 }
 
 /* VPMU part of the 'q' keyhandler */
-static void amd_vpmu_dump(const struct vcpu *v)
+static void cf_check amd_vpmu_dump(const struct vcpu *v)
 {
     const struct vpmu_struct *vpmu = vcpu_vpmu(v);
     const struct xen_pmu_amd_ctxt *ctxt = vpmu->context;
@@ -480,7 +480,7 @@ static void amd_vpmu_dump(const struct vcpu *v)
     }
 }
 
-static int svm_vpmu_initialise(struct vcpu *v)
+static int cf_check svm_vpmu_initialise(struct vcpu *v)
 {
     struct xen_pmu_amd_ctxt *ctxt;
     struct vpmu_struct *vpmu = vcpu_vpmu(v);
diff --git a/xen/arch/x86/cpu/vpmu_intel.c b/xen/arch/x86/cpu/vpmu_intel.c
index 22dd4469d920..48b81ab6f018 100644
--- a/xen/arch/x86/cpu/vpmu_intel.c
+++ b/xen/arch/x86/cpu/vpmu_intel.c
@@ -288,7 +288,7 @@ static inline void __core2_vpmu_save(struct vcpu *v)
         rdmsrl(MSR_CORE_PERF_GLOBAL_STATUS, core2_vpmu_cxt->global_status);
 }
 
-static int core2_vpmu_save(struct vcpu *v, bool_t to_guest)
+static int cf_check core2_vpmu_save(struct vcpu *v, bool to_guest)
 {
     struct vpmu_struct *vpmu = vcpu_vpmu(v);
 
@@ -407,7 +407,7 @@ static int core2_vpmu_verify(struct vcpu *v)
     return 0;
 }
 
-static int core2_vpmu_load(struct vcpu *v, bool_t from_guest)
+static int cf_check core2_vpmu_load(struct vcpu *v, bool from_guest)
 {
     struct vpmu_struct *vpmu = vcpu_vpmu(v);
 
@@ -522,7 +522,7 @@ static int core2_vpmu_msr_common_check(u32 msr_index, int *type, int *index)
     return 1;
 }
 
-static int core2_vpmu_do_wrmsr(unsigned int msr, uint64_t msr_content)
+static int cf_check core2_vpmu_do_wrmsr(unsigned int msr, uint64_t msr_content)
 {
     int i, tmp;
     int type = -1, index = -1;
@@ -690,7 +690,7 @@ static int core2_vpmu_do_wrmsr(unsigned int msr, uint64_t msr_content)
     return 0;
 }
 
-static int core2_vpmu_do_rdmsr(unsigned int msr, uint64_t *msr_content)
+static int cf_check core2_vpmu_do_rdmsr(unsigned int msr, uint64_t *msr_content)
 {
     int type = -1, index = -1;
     struct vcpu *v = current;
@@ -730,7 +730,7 @@ static int core2_vpmu_do_rdmsr(unsigned int msr, uint64_t *msr_content)
 }
 
 /* Dump vpmu info on console, called in the context of keyhandler 'q'. */
-static void core2_vpmu_dump(const struct vcpu *v)
+static void cf_check core2_vpmu_dump(const struct vcpu *v)
 {
     const struct vpmu_struct *vpmu = vcpu_vpmu(v);
     unsigned int i;
@@ -775,7 +775,7 @@ static void core2_vpmu_dump(const struct vcpu *v)
     }
 }
 
-static int core2_vpmu_do_interrupt(struct cpu_user_regs *regs)
+static int cf_check core2_vpmu_do_interrupt(struct cpu_user_regs *regs)
 {
     struct vcpu *v = current;
     u64 msr_content;
@@ -802,7 +802,7 @@ static int core2_vpmu_do_interrupt(struct cpu_user_regs *regs)
     return 1;
 }
 
-static void core2_vpmu_destroy(struct vcpu *v)
+static void cf_check core2_vpmu_destroy(struct vcpu *v)
 {
     struct vpmu_struct *vpmu = vcpu_vpmu(v);
 
@@ -816,7 +816,7 @@ static void core2_vpmu_destroy(struct vcpu *v)
     vpmu_clear(vpmu);
 }
 
-static int vmx_vpmu_initialise(struct vcpu *v)
+static int cf_check vmx_vpmu_initialise(struct vcpu *v)
 {
     struct vpmu_struct *vpmu = vcpu_vpmu(v);
     u64 msr_content;
diff --git a/xen/arch/x86/oprofile/op_model_athlon.c b/xen/arch/x86/oprofile/op_model_athlon.c
index 2177f02946e2..7bc5853a6c23 100644
--- a/xen/arch/x86/oprofile/op_model_athlon.c
+++ b/xen/arch/x86/oprofile/op_model_athlon.c
@@ -164,7 +164,7 @@ static inline u64 op_amd_randomize_ibs_op(u64 val)
     return val;
 }
 
-static void athlon_fill_in_addresses(struct op_msrs * const msrs)
+static void cf_check athlon_fill_in_addresses(struct op_msrs * const msrs)
 {
 	msrs->counters[0].addr = MSR_K7_PERFCTR0;
 	msrs->counters[1].addr = MSR_K7_PERFCTR1;
@@ -177,7 +177,7 @@ static void athlon_fill_in_addresses(struct op_msrs * const msrs)
 	msrs->controls[3].addr = MSR_K7_EVNTSEL3;
 }
 
-static void fam15h_fill_in_addresses(struct op_msrs * const msrs)
+static void cf_check fam15h_fill_in_addresses(struct op_msrs * const msrs)
 {
 	msrs->counters[0].addr = MSR_AMD_FAM15H_PERFCTR0;
 	msrs->counters[1].addr = MSR_AMD_FAM15H_PERFCTR1;
@@ -194,7 +194,7 @@ static void fam15h_fill_in_addresses(struct op_msrs * const msrs)
 	msrs->controls[5].addr = MSR_AMD_FAM15H_EVNTSEL5;
 }
 
-static void athlon_setup_ctrs(struct op_msrs const * const msrs)
+static void cf_check athlon_setup_ctrs(struct op_msrs const * const msrs)
 {
 	uint64_t msr_content;
 	int i;
@@ -308,9 +308,9 @@ static inline int handle_ibs(int mode, struct cpu_user_regs const * const regs)
     return 1;
 }
 
-static int athlon_check_ctrs(unsigned int const cpu,
-			     struct op_msrs const * const msrs,
-			     struct cpu_user_regs const * const regs)
+static int cf_check athlon_check_ctrs(
+	unsigned int const cpu, struct op_msrs const * const msrs,
+	struct cpu_user_regs const * const regs)
 
 {
 	uint64_t msr_content;
@@ -386,7 +386,7 @@ static inline void start_ibs(void)
 	}
 }
  
-static void athlon_start(struct op_msrs const * const msrs)
+static void cf_check athlon_start(struct op_msrs const * const msrs)
 {
 	uint64_t msr_content;
 	int i;
@@ -415,7 +415,7 @@ static void stop_ibs(void)
 		wrmsrl(MSR_AMD64_IBSOPCTL, 0);
 }
 
-static void athlon_stop(struct op_msrs const * const msrs)
+static void cf_check athlon_stop(struct op_msrs const * const msrs)
 {
 	uint64_t msr_content;
 	int i;
diff --git a/xen/arch/x86/oprofile/op_model_p4.c b/xen/arch/x86/oprofile/op_model_p4.c
index b08ba53cbd39..d047258644db 100644
--- a/xen/arch/x86/oprofile/op_model_p4.c
+++ b/xen/arch/x86/oprofile/op_model_p4.c
@@ -390,7 +390,7 @@ static unsigned int get_stagger(void)
 static unsigned long reset_value[NUM_COUNTERS_NON_HT];
 
 
-static void p4_fill_in_addresses(struct op_msrs * const msrs)
+static void cf_check p4_fill_in_addresses(struct op_msrs * const msrs)
 {
 	unsigned int i;
 	unsigned int addr, stag;
@@ -530,7 +530,7 @@ static void pmc_setup_one_p4_counter(unsigned int ctr)
 }
 
 
-static void p4_setup_ctrs(struct op_msrs const * const msrs)
+static void cf_check p4_setup_ctrs(struct op_msrs const * const msrs)
 {
 	unsigned int i;
 	uint64_t msr_content;
@@ -609,9 +609,9 @@ static void p4_setup_ctrs(struct op_msrs const * const msrs)
 	}
 }
 
-static int p4_check_ctrs(unsigned int const cpu,
-                         struct op_msrs const * const msrs,
-                         struct cpu_user_regs const * const regs)
+static int cf_check p4_check_ctrs(
+	unsigned int const cpu, struct op_msrs const * const msrs,
+	struct cpu_user_regs const * const regs)
 {
 	unsigned long ctr, stag, real;
 	uint64_t msr_content;
@@ -665,7 +665,7 @@ static int p4_check_ctrs(unsigned int const cpu,
 }
 
 
-static void p4_start(struct op_msrs const * const msrs)
+static void cf_check p4_start(struct op_msrs const * const msrs)
 {
 	unsigned int stag;
 	uint64_t msr_content;
@@ -683,7 +683,7 @@ static void p4_start(struct op_msrs const * const msrs)
 }
 
 
-static void p4_stop(struct op_msrs const * const msrs)
+static void cf_check p4_stop(struct op_msrs const * const msrs)
 {
 	unsigned int stag;
 	uint64_t msr_content;
diff --git a/xen/arch/x86/oprofile/op_model_ppro.c b/xen/arch/x86/oprofile/op_model_ppro.c
index 72c504a10216..8d7e13ea8777 100644
--- a/xen/arch/x86/oprofile/op_model_ppro.c
+++ b/xen/arch/x86/oprofile/op_model_ppro.c
@@ -63,7 +63,7 @@ static int counter_width = 32;
 static unsigned long reset_value[OP_MAX_COUNTER];
 int ppro_has_global_ctrl = 0;
 
-static void ppro_fill_in_addresses(struct op_msrs * const msrs)
+static void cf_check ppro_fill_in_addresses(struct op_msrs * const msrs)
 {
 	int i;
 
@@ -74,7 +74,7 @@ static void ppro_fill_in_addresses(struct op_msrs * const msrs)
 }
 
 
-static void ppro_setup_ctrs(struct op_msrs const * const msrs)
+static void cf_check ppro_setup_ctrs(struct op_msrs const * const msrs)
 {
 	uint64_t msr_content;
 	int i;
@@ -128,9 +128,9 @@ static void ppro_setup_ctrs(struct op_msrs const * const msrs)
 	}
 }
 
-static int ppro_check_ctrs(unsigned int const cpu,
-                           struct op_msrs const * const msrs,
-                           struct cpu_user_regs const * const regs)
+static int cf_check ppro_check_ctrs(
+	unsigned int const cpu, struct op_msrs const * const msrs,
+	struct cpu_user_regs const * const regs)
 {
 	u64 val;
 	int i;
@@ -170,7 +170,7 @@ static int ppro_check_ctrs(unsigned int const cpu,
 }
 
 
-static void ppro_start(struct op_msrs const * const msrs)
+static void cf_check ppro_start(struct op_msrs const * const msrs)
 {
 	uint64_t msr_content;
 	int i;
@@ -190,7 +190,7 @@ static void ppro_start(struct op_msrs const * const msrs)
 }
 
 
-static void ppro_stop(struct op_msrs const * const msrs)
+static void cf_check ppro_stop(struct op_msrs const * const msrs)
 {
 	uint64_t msr_content;
 	int i;
@@ -206,7 +206,7 @@ static void ppro_stop(struct op_msrs const * const msrs)
         wrmsrl(MSR_CORE_PERF_GLOBAL_CTRL, 0x0ULL);
 }
 
-static int ppro_is_arch_pmu_msr(u64 msr_index, int *type, int *index)
+static int cf_check ppro_is_arch_pmu_msr(u64 msr_index, int *type, int *index)
 {
 	if ( (msr_index >= MSR_IA32_PERFCTR0) &&
             (msr_index < (MSR_IA32_PERFCTR0 + num_counters)) )
@@ -226,7 +226,7 @@ static int ppro_is_arch_pmu_msr(u64 msr_index, int *type, int *index)
         return 0;
 }
 
-static int ppro_allocate_msr(struct vcpu *v)
+static int cf_check ppro_allocate_msr(struct vcpu *v)
 {
 	struct vpmu_struct *vpmu = vcpu_vpmu(v);
 	struct arch_msr_pair *msr_content;
@@ -245,7 +245,7 @@ static int ppro_allocate_msr(struct vcpu *v)
 	return 0;
 }
 
-static void ppro_free_msr(struct vcpu *v)
+static void cf_check ppro_free_msr(struct vcpu *v)
 {
 	struct vpmu_struct *vpmu = vcpu_vpmu(v);
 
@@ -255,7 +255,8 @@ static void ppro_free_msr(struct vcpu *v)
 	vpmu_reset(vpmu, VPMU_PASSIVE_DOMAIN_ALLOCATED);
 }
 
-static void ppro_load_msr(struct vcpu *v, int type, int index, u64 *msr_content)
+static void cf_check ppro_load_msr(
+	struct vcpu *v, int type, int index, u64 *msr_content)
 {
 	struct arch_msr_pair *msrs = vcpu_vpmu(v)->context;
 	switch ( type )
@@ -269,7 +270,8 @@ static void ppro_load_msr(struct vcpu *v, int type, int index, u64 *msr_content)
 	}
 }
 
-static void ppro_save_msr(struct vcpu *v, int type, int index, u64 msr_content)
+static void cf_check ppro_save_msr(
+	struct vcpu *v, int type, int index, u64 msr_content)
 {
 	struct arch_msr_pair *msrs = vcpu_vpmu(v)->context;
 
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:06:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:06:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271696.466296 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb3S-0006Ls-2B; Mon, 14 Feb 2022 13:06:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271696.466296; Mon, 14 Feb 2022 13:06:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb3R-0006LF-Sw; Mon, 14 Feb 2022 13:06:09 +0000
Received: by outflank-mailman (input) for mailman id 271696;
 Mon, 14 Feb 2022 13:06:08 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJb2d-00023t-3E
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:05:19 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id bf1c7d79-8d96-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 14:05:14 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bf1c7d79-8d96-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644843915;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=Tggw0GZ6bfnXtc3j4bg8kNAeAyzyeywPiqWn1QmRJkY=;
  b=hWqUX8sHy2nidq9jL+80nzlAb/4wFPqq9B9+1a022ixiHc4MDE+naiSN
   wtJcqELJEtDONTMK59Xb0KxjM6LpMmsjHl89uAVqfaVcNEApFdFWSpOqv
   rYCIeTAuBnUDwSclYCYg0+oIANUoj7Mxx3ihyVzHNiJVvdUzFoX72DFQ2
   c=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: h3iYyQsK6zE5hVydfGasuPl2S6zQCRvyDC8bkeVSnsO+uetH8nNUUuE2JnTJOudLkRFmpRcOUe
 I5c65DN0NJLHfNifkAASDni17Vg/KlOm39Lh30kFzAG5/liJWQGB+zDU3lOG6T8GBJdC4zjFSn
 lblgbCBcoLwovYAPr9gZALpt+0UDzLFn8uyjwNwyQmvDcBGEGDZeuJ4Wa1VB/TPBZT7E5AowGq
 ph/ZiH0Yl5aW43fhtRIRVn4X0H6rb1hon0zFmR3gVHOeMSsf/RgnqZnAoiMgnM6XD0F1zcIkRy
 kuPS1TxufY1NFHz90P+tDrp4
X-SBRS: 5.1
X-MesageID: 64050600
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:dK7b7a6cv4gWjnE+dDCrwAxRtCbAchMFZxGqfqrLsTDasY5as4F+v
 mofWmzUOP+MazGkfNAgO4znpk9SuZXSzYVjT1Q6/i5nHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FV8MpBsJ00o5wbZj29Iw2LBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zl
 +h18tuXEzgVPZbhpqc6XEF8KwRTFPgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALBc/nJo4A/FpnyinUF60OSpHfWaTao9Rf2V/cg+gQQa6DP
 5RBMVKDajzjW1pEI0owOqkUjcSajFv9Wm1ktn+a8P9fD2/7k1UqjemF3MDuUsyHQ4BZk1iVo
 krC/n/lGVcKOdqH0z2H/3mwwOjVkkvGtJk6TePisKQw2RvKmzJVWEZ+uUaHTeeR1XOGHJV4c
 XMo+REDk+sV+xSPdvzQdkjtyJKbhSI0V91VGuw8zQiCzKvI/gqUblQ5oi59hM8O75FvG2Fzv
 rOdt5awXGE07uXJIZ6I3urM9VuP1T4pwXjujMPuZS8M+JHdrY46lXojpf4zQffu3rUZ9dwdq
 g1mTRTSZZ1O16bnNI3hpDgrZg5AQbCTEGYICv3/BD7N0++ATNfNi3aUwVba9+1cC42SU0OMu
 nMJ8+DHsrxSUsHdyXHVGb5XdF1M2xpiGGeC6WOD4rF7r2j9k5JdVdw4DM5CyLdBbZ9fJG6Bj
 L77sgJN/p5DVEZGnocsC79d//8ClPC6ffy8D6i8RoMXPvBZKV/WlAkzNBX49z28zyARfVQXZ
 M7znTCEVi1BV8yKDVOeGo8g7FPc7n5ilD2DHcihl3xKE9O2PRaodFvMC3PWBshR0U9OiFq9H
 w93O5TYxhNBfvf5ZyWLo4cfIUpTdSowBIzsqtwRfemGe1I0FGYkAv7X4LUgZ406wPgFyraWp
 imwCh1C1V7ypXzbMgHWOHptX6ziAMRkpnUhMC1yYVvxgyo/YZyi5bs0focseeV17/RqyPN5F
 qFXe8iJDvlVZC7A/jARMcv0oIB4LUz5jgOSJSu1JjM4esc4FQDO/9bleCrp9TUPUXXr5Zdv/
 eX421qCE5QZRglkAMLHU96Vzgu87SoHheZ/f0rUOd0PKk/ix5dndn7qhfgtLsBSdRianmmG1
 xybCAszrPXWp9Nn68HAgK2Jotv7E+Z6GUYGTWDX4azvaHvf92unh4RBTPyJbXbWU2atoPeuY
 uBczvfdNvwbnQkV79ogQugzla9utcHyo7J6zxh/GCSZZlumPbpsP32a0JQdraZK3LJY5VO7V
 0/nFgO24llV1BcJyGIsGTc=
IronPort-HdrOrdr: A9a23:peCOGqMpSc0cScBcTvKjsMiBIKoaSvp037B87TEUdfU1SL3jqy
 nKpp536faaskd2ZJhNo6H5BEDiexPhHPxOkO4s1N6ZNWGMhILPFvAB0WLM+UyEJ8SUzJ8l6U
 4PSdkENDQyNzdHZATBjDVQ3+xA/DBPys7Y5tvj8w==
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="64050600"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v2 49/70] x86/hap: CFI hardening
Date: Mon, 14 Feb 2022 12:51:06 +0000
Message-ID: <20220214125127.17985-50-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

Control Flow Integrity schemes use toolchain and optionally hardware support
to help protect against call/jump/return oriented programming attacks.

Use cf_check to annotate function pointer targets for the toolchain.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
 xen/arch/x86/mm/hap/guest_walk.c |  4 ++--
 xen/arch/x86/mm/hap/hap.c        | 21 +++++++++++----------
 xen/arch/x86/mm/hap/private.h    | 30 ++++++++++++------------------
 3 files changed, 25 insertions(+), 30 deletions(-)

diff --git a/xen/arch/x86/mm/hap/guest_walk.c b/xen/arch/x86/mm/hap/guest_walk.c
index 832a8058471e..1da8d3b99edc 100644
--- a/xen/arch/x86/mm/hap/guest_walk.c
+++ b/xen/arch/x86/mm/hap/guest_walk.c
@@ -36,14 +36,14 @@
 #include <asm/guest_pt.h>
 #include <asm/p2m.h>
 
-unsigned long hap_gva_to_gfn(GUEST_PAGING_LEVELS)(
+unsigned long cf_check hap_gva_to_gfn(GUEST_PAGING_LEVELS)(
     struct vcpu *v, struct p2m_domain *p2m, unsigned long gva, uint32_t *pfec)
 {
     unsigned long cr3 = v->arch.hvm.guest_cr[3];
     return hap_p2m_ga_to_gfn(GUEST_PAGING_LEVELS)(v, p2m, cr3, gva, pfec, NULL);
 }
 
-unsigned long hap_p2m_ga_to_gfn(GUEST_PAGING_LEVELS)(
+unsigned long cf_check hap_p2m_ga_to_gfn(GUEST_PAGING_LEVELS)(
     struct vcpu *v, struct p2m_domain *p2m, unsigned long cr3,
     paddr_t ga, uint32_t *pfec, unsigned int *page_order)
 {
diff --git a/xen/arch/x86/mm/hap/hap.c b/xen/arch/x86/mm/hap/hap.c
index ed5112b00b63..9d67a47f5fe9 100644
--- a/xen/arch/x86/mm/hap/hap.c
+++ b/xen/arch/x86/mm/hap/hap.c
@@ -268,7 +268,7 @@ static void hap_free(struct domain *d, mfn_t mfn)
     page_list_add_tail(pg, &d->arch.paging.hap.freelist);
 }
 
-static struct page_info *hap_alloc_p2m_page(struct domain *d)
+static struct page_info *cf_check hap_alloc_p2m_page(struct domain *d)
 {
     struct page_info *pg;
 
@@ -294,7 +294,7 @@ static struct page_info *hap_alloc_p2m_page(struct domain *d)
     return pg;
 }
 
-static void hap_free_p2m_page(struct domain *d, struct page_info *pg)
+static void cf_check hap_free_p2m_page(struct domain *d, struct page_info *pg)
 {
     struct domain *owner = page_get_owner(pg);
 
@@ -662,8 +662,8 @@ void hap_vcpu_init(struct vcpu *v)
  * HAP guests can handle page faults (in the guest page tables) without
  * needing any action from Xen, so we should not be intercepting them.
  */
-static int hap_page_fault(struct vcpu *v, unsigned long va,
-                          struct cpu_user_regs *regs)
+static int cf_check hap_page_fault(
+    struct vcpu *v, unsigned long va, struct cpu_user_regs *regs)
 {
     struct domain *d = v->domain;
 
@@ -677,7 +677,7 @@ static int hap_page_fault(struct vcpu *v, unsigned long va,
  * should not be intercepting it.  However, we need to correctly handle
  * getting here from instruction emulation.
  */
-static bool_t hap_invlpg(struct vcpu *v, unsigned long linear)
+static bool cf_check hap_invlpg(struct vcpu *v, unsigned long linear)
 {
     /*
      * Emulate INVLPGA:
@@ -690,7 +690,8 @@ static bool_t hap_invlpg(struct vcpu *v, unsigned long linear)
     return 1;
 }
 
-static void hap_update_cr3(struct vcpu *v, int do_locking, bool noflush)
+static void cf_check hap_update_cr3(
+    struct vcpu *v, int do_locking, bool noflush)
 {
     v->arch.hvm.hw_cr[3] = v->arch.hvm.guest_cr[3];
     hvm_update_guest_cr3(v, noflush);
@@ -702,7 +703,7 @@ static bool flush_vcpu(const struct vcpu *v, const unsigned long *vcpu_bitmap)
 }
 
 /* Flush TLB of selected vCPUs.  NULL for all. */
-static bool flush_tlb(const unsigned long *vcpu_bitmap)
+static bool cf_check flush_tlb(const unsigned long *vcpu_bitmap)
 {
     static DEFINE_PER_CPU(cpumask_t, flush_cpumask);
     cpumask_t *mask = &this_cpu(flush_cpumask);
@@ -747,7 +748,7 @@ hap_paging_get_mode(struct vcpu *v)
                                       &hap_paging_protected_mode);
 }
 
-static void hap_update_paging_modes(struct vcpu *v)
+static void cf_check hap_update_paging_modes(struct vcpu *v)
 {
     struct domain *d = v->domain;
     unsigned long cr3_gfn = v->arch.hvm.guest_cr[3] >> PAGE_SHIFT;
@@ -791,13 +792,13 @@ void hap_p2m_init(struct p2m_domain *p2m)
     p2m->write_p2m_entry_post = hap_write_p2m_entry_post;
 }
 
-static unsigned long hap_gva_to_gfn_real_mode(
+static unsigned long cf_check hap_gva_to_gfn_real_mode(
     struct vcpu *v, struct p2m_domain *p2m, unsigned long gva, uint32_t *pfec)
 {
     return ((paddr_t)gva >> PAGE_SHIFT);
 }
 
-static unsigned long hap_p2m_ga_to_gfn_real_mode(
+static unsigned long cf_check hap_p2m_ga_to_gfn_real_mode(
     struct vcpu *v, struct p2m_domain *p2m, unsigned long cr3,
     paddr_t ga, uint32_t *pfec, unsigned int *page_order)
 {
diff --git a/xen/arch/x86/mm/hap/private.h b/xen/arch/x86/mm/hap/private.h
index 973fbe8be59c..1040eaf69f43 100644
--- a/xen/arch/x86/mm/hap/private.h
+++ b/xen/arch/x86/mm/hap/private.h
@@ -24,27 +24,21 @@
 /********************************************/
 /*          GUEST TRANSLATION FUNCS         */
 /********************************************/
-unsigned long hap_gva_to_gfn_2_levels(struct vcpu *v,
-                                     struct p2m_domain *p2m,
-                                     unsigned long gva, 
-                                     uint32_t *pfec);
-unsigned long hap_gva_to_gfn_3_levels(struct vcpu *v,
-                                     struct p2m_domain *p2m,
-                                     unsigned long gva, 
-                                     uint32_t *pfec);
-unsigned long hap_gva_to_gfn_4_levels(struct vcpu *v,
-                                     struct p2m_domain *p2m,
-                                     unsigned long gva, 
-                                     uint32_t *pfec);
+unsigned long cf_check hap_gva_to_gfn_2_levels(
+    struct vcpu *v, struct p2m_domain *p2m, unsigned long gva, uint32_t *pfec);
+unsigned long cf_check hap_gva_to_gfn_3_levels(
+    struct vcpu *v, struct p2m_domain *p2m, unsigned long gva, uint32_t *pfec);
+unsigned long cf_check hap_gva_to_gfn_4_levels(
+    struct vcpu *v, struct p2m_domain *p2m, unsigned long gva, uint32_t *pfec);
 
-unsigned long hap_p2m_ga_to_gfn_2_levels(struct vcpu *v,
-    struct p2m_domain *p2m, unsigned long cr3,
+unsigned long cf_check hap_p2m_ga_to_gfn_2_levels(
+    struct vcpu *v, struct p2m_domain *p2m, unsigned long cr3,
     paddr_t ga, uint32_t *pfec, unsigned int *page_order);
-unsigned long hap_p2m_ga_to_gfn_3_levels(struct vcpu *v,
-    struct p2m_domain *p2m, unsigned long cr3,
+unsigned long cf_check hap_p2m_ga_to_gfn_3_levels(
+    struct vcpu *v, struct p2m_domain *p2m, unsigned long cr3,
     paddr_t ga, uint32_t *pfec, unsigned int *page_order);
-unsigned long hap_p2m_ga_to_gfn_4_levels(struct vcpu *v,
-    struct p2m_domain *p2m, unsigned long cr3,
+unsigned long cf_check hap_p2m_ga_to_gfn_4_levels(
+    struct vcpu *v, struct p2m_domain *p2m, unsigned long cr3,
     paddr_t ga, uint32_t *pfec, unsigned int *page_order);
 
 #endif /* __HAP_PRIVATE_H__ */
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:06:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:06:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271695.466291 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb3R-0006Iv-Ne; Mon, 14 Feb 2022 13:06:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271695.466291; Mon, 14 Feb 2022 13:06:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb3R-0006Im-KM; Mon, 14 Feb 2022 13:06:09 +0000
Received: by outflank-mailman (input) for mailman id 271695;
 Mon, 14 Feb 2022 13:06:08 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJb3B-0008IH-AY
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:05:53 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d54d9daf-8d96-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 14:05:50 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d54d9daf-8d96-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644843950;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=Wv0rQqRPWpcG0ewKeUqSGZKCO/w3udjtsWVFXdBQG/w=;
  b=GOZehs7pXGxGVkQcXy0fYhVsyVvRqgOKYuh4LZoOqCWwUG9xahUv4qiV
   DX51joY5ikmk7z+S6uyxiHetHwk6Y/sfAQ5ZZ8m342UkIqGtRUQscJwMY
   qzB+IV099XfjAf35ihqP/TkJOzsX8CPRl54liFd3USEvVWzZXbohHShrg
   I=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: 0j2hK2Ow4/t6RBTgf3IoSL36BC6PnZvYFQaJXVU6RGynC5Ju3H4l+lDiOqxCgP5yjIAvNJjUr+
 6PDItm1ugrTwjHsbjWfG8ic+6ou3RY54QwD5dYjpLl0PgrwGH+MYXfKBLJ1wjwj8p2UehG8XgT
 lLw7N1mug47SuiyKRm9wZSE13zKt2/UmM3jFqmlDvHKdW7R4h3vTQY6kX7cJhPBqQgo0keN87v
 v7gXwV8nu+qoiyjrkxCQmWDAI4OkjyYUJK8BCOole4sg+AyaQlFPnzidVOPqFfTuUY7G1ac9Qo
 hS6J67BKLqcW5icshTtvRTat
X-SBRS: 5.1
X-MesageID: 66374886
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Lj/RRaP7c1arI2TvrR28kMFynXyQoLVcMsEvi/4bfWQNrUpz0TQFz
 2QdCmHXb/aLN2akc9Ana9mwpkoAsJPSy4VlHAto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6UUsxNbVU8En1500s/w7dRbrNA2rBVPSvc4
 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq
 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYox+rn48u1
 Ophjsa9dkQ4DrLnsusTdyANRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs
 6VFdnZdNXhvhMrvqF6/YsBqit4uM4/AO4QHt2s75TrYEewnUdbIRKCiCdpwgmlr2ZweTai2i
 8wxb31OUjGaex5zORQwV7g4l8qB1lOnfGgNwL6SjfVuuDWCpOBr65D9PdyQdtGUSMF9mkeDu
 nmA72n/GgsdNtGU1XyC6H3EuwPUtXqlAsRITuT+r6M0xg3IroAONPEIfXGZoabmlnGSYIhSF
 A8FyjUFh6c80HX+G7ERQCaEiHKDuxcdXf9ZHOs79ByBx8Lo3uqJOoQXZmUfMYJ77afaURRvj
 wbUxI2xWVSDpZXIESr1y1uCkd+l1cH5x0cmbDRMcwYK6sKLTGob3kOWFYYL/EJYY7TI9dDML
 9Ki8XJWa1Y715djO0CHEbfv2WzEm3QxZlRpjjg7p0r8hu+DWKarZpaz9X/Q5utaIYCSQzGp5
 SZYx5fOvL1TVcjWzkRhpdnh+5nzuZ643MD02wYzT/HNCRzxk5JcQWygyG4nfxo4Wir1UTTof
 FXSqWtsCGx7ZxOXgVtMS9vpUawClPG4ffy8D6y8RoceM/BZKV7clAkzNBH44owYuBV1+U3JE
 czAKpjE4LdzIfkP8QdasM9Dje51lnhmnzu7qFKS503P7IdyrUW9Ed8tWGZipMhgvMtoeS3Zr
 IRSMdWk0RJaXLGsayXb69dLf1sLMWI6Fdb9rMkOLryPJQ9vGWcADf7NwOx+J9w5zvoNzuqYr
 GugXkJ4yUbkgSGVIwu9dX0+OqjkWoxyrCxnMHV0b0qowXUqfa2m8LwbK8ksZbAi+eE6lax0Q
 vAJdt+uGPNKTjibqT0RYYOk9N5pdQixhBLINC2gOWBtc5llTg3P29nlYgqwq3VeUnvp7ZMz+
 uTy2BnaTJwPQxVZIPzXMP//nUmsuXU9mf5pWxeaKNdkZ0ixopNhLDb8j6FrLphUewnD3DaTy
 y2fHQwc+bvWu4Yw/dTE2fKEooOuH7csF0ZWBTCGv7O/NC2c9Wu/245QFu2PeGmFBm/z/ayjY
 8RTzu39b6JbzAob7dIkHuY517866vvuu6Ren1ZtE3j8Zli2Dq9tfyud1s5Vu6wRnrJUtGNag
 K5UFgW27VlRBP7YLQ==
IronPort-HdrOrdr: A9a23:W6QGy67FHYtEWXDOuAPXwMrXdLJyesId70hD6qhwISY6TiX4rb
 HWoB1173/JYVoqNE3I3OrwXZVoIkmsk6Kdg7NhXotKNTOO0ADDQb2Kr7GSpwEIcxeOkdK1vp
 0AT0ERMrLN5CBB/KTH3DU=
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="66374886"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v2 27/70] xen/iommu: CFI hardening
Date: Mon, 14 Feb 2022 12:50:44 +0000
Message-ID: <20220214125127.17985-28-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

Control Flow Integrity schemes use toolchain and optionally hardware support
to help protect against call/jump/return oriented programming attacks.

Use cf_check to annotate function pointer targets for the toolchain.

AMD's parse_ppr_log_entry() has no external callers, so becomes static.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
 xen/common/compat/memory.c                  |  4 +-
 xen/drivers/passthrough/amd/iommu.h         | 41 ++++++++--------
 xen/drivers/passthrough/amd/iommu_init.c    | 22 ++++-----
 xen/drivers/passthrough/amd/iommu_intr.c    | 18 +++----
 xen/drivers/passthrough/amd/iommu_map.c     | 22 +++++----
 xen/drivers/passthrough/amd/pci_amd_iommu.c | 32 ++++++------
 xen/drivers/passthrough/pci.c               |  7 +--
 xen/drivers/passthrough/vtd/dmar.c          |  3 +-
 xen/drivers/passthrough/vtd/extern.h        | 36 +++++++-------
 xen/drivers/passthrough/vtd/intremap.c      | 14 +++---
 xen/drivers/passthrough/vtd/iommu.c         | 75 +++++++++++++++--------------
 xen/drivers/passthrough/vtd/qinval.c        | 28 +++++------
 12 files changed, 153 insertions(+), 149 deletions(-)

diff --git a/xen/common/compat/memory.c b/xen/common/compat/memory.c
index ec8ba54bb66e..077ded4a754c 100644
--- a/xen/common/compat/memory.c
+++ b/xen/common/compat/memory.c
@@ -23,8 +23,8 @@ struct get_reserved_device_memory {
     unsigned int used_entries;
 };
 
-static int get_reserved_device_memory(xen_pfn_t start, xen_ulong_t nr,
-                                      u32 id, void *ctxt)
+static int cf_check get_reserved_device_memory(
+    xen_pfn_t start, xen_ulong_t nr, u32 id, void *ctxt)
 {
     struct get_reserved_device_memory *grdm = ctxt;
     uint32_t sbdf = PCI_SBDF3(grdm->map.dev.pci.seg, grdm->map.dev.pci.bus,
diff --git a/xen/drivers/passthrough/amd/iommu.h b/xen/drivers/passthrough/amd/iommu.h
index 99be9aafcc53..03811fedea57 100644
--- a/xen/drivers/passthrough/amd/iommu.h
+++ b/xen/drivers/passthrough/amd/iommu.h
@@ -236,25 +236,26 @@ int amd_iommu_init_late(void);
 int amd_iommu_update_ivrs_mapping_acpi(void);
 int cf_check iov_adjust_irq_affinities(void);
 
-int amd_iommu_quarantine_init(struct domain *d);
+int cf_check amd_iommu_quarantine_init(struct domain *d);
 
 /* mapping functions */
-int __must_check amd_iommu_map_page(struct domain *d, dfn_t dfn,
-                                    mfn_t mfn, unsigned int flags,
-                                    unsigned int *flush_flags);
-int __must_check amd_iommu_unmap_page(struct domain *d, dfn_t dfn,
-                                      unsigned int *flush_flags);
+int __must_check cf_check amd_iommu_map_page(
+    struct domain *d, dfn_t dfn, mfn_t mfn, unsigned int flags,
+    unsigned int *flush_flags);
+int __must_check cf_check amd_iommu_unmap_page(
+    struct domain *d, dfn_t dfn, unsigned int *flush_flags);
 int __must_check amd_iommu_alloc_root(struct domain *d);
 int amd_iommu_reserve_domain_unity_map(struct domain *domain,
                                        const struct ivrs_unity_map *map,
                                        unsigned int flag);
 int amd_iommu_reserve_domain_unity_unmap(struct domain *d,
                                          const struct ivrs_unity_map *map);
-int amd_iommu_get_reserved_device_memory(iommu_grdm_t *func, void *ctxt);
-int __must_check amd_iommu_flush_iotlb_pages(struct domain *d, dfn_t dfn,
-                                             unsigned long page_count,
-                                             unsigned int flush_flags);
-int __must_check amd_iommu_flush_iotlb_all(struct domain *d);
+int cf_check amd_iommu_get_reserved_device_memory(
+    iommu_grdm_t *func, void *ctxt);
+int __must_check cf_check amd_iommu_flush_iotlb_pages(
+    struct domain *d, dfn_t dfn, unsigned long page_count,
+    unsigned int flush_flags);
+int __must_check cf_check amd_iommu_flush_iotlb_all(struct domain *d);
 
 /* device table functions */
 int get_dma_requestor_id(uint16_t seg, uint16_t bdf);
@@ -282,21 +283,21 @@ void amd_iommu_flush_all_caches(struct amd_iommu *iommu);
 struct amd_iommu *find_iommu_for_device(int seg, int bdf);
 
 /* interrupt remapping */
-bool iov_supports_xt(void);
+bool cf_check iov_supports_xt(void);
 int amd_iommu_setup_ioapic_remapping(void);
 void *amd_iommu_alloc_intremap_table(
     const struct amd_iommu *, unsigned long **, unsigned int nr);
-int amd_iommu_free_intremap_table(
+int cf_check amd_iommu_free_intremap_table(
     const struct amd_iommu *, struct ivrs_mappings *, uint16_t);
 unsigned int amd_iommu_intremap_table_order(
     const void *irt, const struct amd_iommu *iommu);
-void amd_iommu_ioapic_update_ire(
+void cf_check amd_iommu_ioapic_update_ire(
     unsigned int apic, unsigned int reg, unsigned int value);
-unsigned int amd_iommu_read_ioapic_from_ire(
+unsigned int cf_check amd_iommu_read_ioapic_from_ire(
     unsigned int apic, unsigned int reg);
-int amd_iommu_msi_msg_update_ire(
+int cf_check amd_iommu_msi_msg_update_ire(
     struct msi_desc *msi_desc, struct msi_msg *msg);
-int amd_setup_hpet_msi(struct msi_desc *msi_desc);
+int cf_check amd_setup_hpet_msi(struct msi_desc *msi_desc);
 void cf_check amd_iommu_dump_intremap_tables(unsigned char key);
 
 extern struct ioapic_sbdf {
@@ -327,9 +328,9 @@ extern void *shared_intremap_table;
 extern unsigned long *shared_intremap_inuse;
 
 /* power management support */
-void amd_iommu_resume(void);
-int __must_check amd_iommu_suspend(void);
-void amd_iommu_crash_shutdown(void);
+void cf_check amd_iommu_resume(void);
+int __must_check cf_check amd_iommu_suspend(void);
+void cf_check amd_iommu_crash_shutdown(void);
 
 /* guest iommu support */
 #ifdef CONFIG_HVM
diff --git a/xen/drivers/passthrough/amd/iommu_init.c b/xen/drivers/passthrough/amd/iommu_init.c
index 34a9e49f1c5a..06b4d2b1fea0 100644
--- a/xen/drivers/passthrough/amd/iommu_init.c
+++ b/xen/drivers/passthrough/amd/iommu_init.c
@@ -258,8 +258,8 @@ static void register_iommu_exclusion_range(struct amd_iommu *iommu)
     writel(entry, iommu->mmio_base+IOMMU_EXCLUSION_BASE_LOW_OFFSET);
 }
 
-static void set_iommu_event_log_control(struct amd_iommu *iommu,
-                                        bool enable)
+static void cf_check set_iommu_event_log_control(
+    struct amd_iommu *iommu, bool enable)
 {
     /* Reset head and tail pointer manually before enablement */
     if ( enable )
@@ -275,8 +275,8 @@ static void set_iommu_event_log_control(struct amd_iommu *iommu,
     writeq(iommu->ctrl.raw, iommu->mmio_base + IOMMU_CONTROL_MMIO_OFFSET);
 }
 
-static void set_iommu_ppr_log_control(struct amd_iommu *iommu,
-                                      bool enable)
+static void cf_check set_iommu_ppr_log_control(
+    struct amd_iommu *iommu, bool enable)
 {
     /* Reset head and tail pointer manually before enablement */
     if ( enable )
@@ -527,7 +527,7 @@ static hw_irq_controller iommu_x2apic_type = {
     .set_affinity = set_x2apic_affinity,
 };
 
-static void parse_event_log_entry(struct amd_iommu *iommu, u32 entry[])
+static void cf_check parse_event_log_entry(struct amd_iommu *iommu, u32 entry[])
 {
     u32 code;
     static const char *const event_str[] = {
@@ -628,7 +628,7 @@ static void iommu_check_event_log(struct amd_iommu *iommu)
     spin_unlock_irqrestore(&iommu->lock, flags);
 }
 
-void parse_ppr_log_entry(struct amd_iommu *iommu, u32 entry[])
+static void cf_check parse_ppr_log_entry(struct amd_iommu *iommu, u32 entry[])
 {
 
     u16 device_id;
@@ -1243,7 +1243,7 @@ static int __init alloc_ivrs_mappings(u16 seg)
     return 0;
 }
 
-static int __init amd_iommu_setup_device_table(
+static int __init cf_check amd_iommu_setup_device_table(
     u16 seg, struct ivrs_mappings *ivrs_mappings)
 {
     struct amd_iommu_dte *dt = IVRS_MAPPINGS_DEVTAB(ivrs_mappings);
@@ -1543,7 +1543,7 @@ static void invalidate_all_domain_pages(void)
         amd_iommu_flush_all_pages(d);
 }
 
-static int _invalidate_all_devices(
+static int cf_check _invalidate_all_devices(
     u16 seg, struct ivrs_mappings *ivrs_mappings)
 {
     unsigned int bdf; 
@@ -1569,14 +1569,14 @@ static void invalidate_all_devices(void)
     iterate_ivrs_mappings(_invalidate_all_devices);
 }
 
-int amd_iommu_suspend(void)
+int cf_check amd_iommu_suspend(void)
 {
     amd_iommu_crash_shutdown();
 
     return 0;
 }
 
-void amd_iommu_crash_shutdown(void)
+void cf_check amd_iommu_crash_shutdown(void)
 {
     struct amd_iommu *iommu;
 
@@ -1584,7 +1584,7 @@ void amd_iommu_crash_shutdown(void)
         disable_iommu(iommu);
 }
 
-void amd_iommu_resume(void)
+void cf_check amd_iommu_resume(void)
 {
     struct amd_iommu *iommu;
 
diff --git a/xen/drivers/passthrough/amd/iommu_intr.c b/xen/drivers/passthrough/amd/iommu_intr.c
index e7804413c7f4..cebf9ceca74e 100644
--- a/xen/drivers/passthrough/amd/iommu_intr.c
+++ b/xen/drivers/passthrough/amd/iommu_intr.c
@@ -349,7 +349,7 @@ static int update_intremap_entry_from_ioapic(
     return 0;
 }
 
-void amd_iommu_ioapic_update_ire(
+void cf_check amd_iommu_ioapic_update_ire(
     unsigned int apic, unsigned int reg, unsigned int value)
 {
     struct IO_APIC_route_entry old_rte = { 0 };
@@ -455,7 +455,7 @@ void amd_iommu_ioapic_update_ire(
     }
 }
 
-unsigned int amd_iommu_read_ioapic_from_ire(
+unsigned int cf_check amd_iommu_read_ioapic_from_ire(
     unsigned int apic, unsigned int reg)
 {
     unsigned int idx;
@@ -608,7 +608,7 @@ static struct amd_iommu *_find_iommu_for_device(int seg, int bdf)
     return ERR_PTR(-EINVAL);
 }
 
-int amd_iommu_msi_msg_update_ire(
+int cf_check amd_iommu_msi_msg_update_ire(
     struct msi_desc *msi_desc, struct msi_msg *msg)
 {
     struct pci_dev *pdev = msi_desc->dev;
@@ -653,7 +653,7 @@ int amd_iommu_msi_msg_update_ire(
     return rc;
 }
 
-int amd_iommu_free_intremap_table(
+int cf_check amd_iommu_free_intremap_table(
     const struct amd_iommu *iommu, struct ivrs_mappings *ivrs_mapping,
     uint16_t bdf)
 {
@@ -727,7 +727,7 @@ void *amd_iommu_alloc_intremap_table(
     return tb;
 }
 
-bool __init iov_supports_xt(void)
+bool __init cf_check iov_supports_xt(void)
 {
     unsigned int apic;
 
@@ -756,7 +756,7 @@ bool __init iov_supports_xt(void)
     return true;
 }
 
-int __init amd_setup_hpet_msi(struct msi_desc *msi_desc)
+int __init cf_check amd_setup_hpet_msi(struct msi_desc *msi_desc)
 {
     const struct amd_iommu *iommu;
     spinlock_t *lock;
@@ -826,9 +826,9 @@ static void dump_intremap_table(const struct amd_iommu *iommu,
     }
 }
 
-static int dump_intremap_mapping(const struct amd_iommu *iommu,
-                                 struct ivrs_mappings *ivrs_mapping,
-                                 uint16_t unused)
+static int cf_check dump_intremap_mapping(
+    const struct amd_iommu *iommu, struct ivrs_mappings *ivrs_mapping,
+    uint16_t unused)
 {
     unsigned long flags;
 
diff --git a/xen/drivers/passthrough/amd/iommu_map.c b/xen/drivers/passthrough/amd/iommu_map.c
index b0330157eab5..bf5df5fe5d9a 100644
--- a/xen/drivers/passthrough/amd/iommu_map.c
+++ b/xen/drivers/passthrough/amd/iommu_map.c
@@ -276,8 +276,9 @@ static int iommu_pde_from_dfn(struct domain *d, unsigned long dfn,
     return 0;
 }
 
-int amd_iommu_map_page(struct domain *d, dfn_t dfn, mfn_t mfn,
-                       unsigned int flags, unsigned int *flush_flags)
+int cf_check amd_iommu_map_page(
+    struct domain *d, dfn_t dfn, mfn_t mfn, unsigned int flags,
+    unsigned int *flush_flags)
 {
     struct domain_iommu *hd = dom_iommu(d);
     int rc;
@@ -326,8 +327,8 @@ int amd_iommu_map_page(struct domain *d, dfn_t dfn, mfn_t mfn,
     return 0;
 }
 
-int amd_iommu_unmap_page(struct domain *d, dfn_t dfn,
-                         unsigned int *flush_flags)
+int cf_check amd_iommu_unmap_page(
+    struct domain *d, dfn_t dfn, unsigned int *flush_flags)
 {
     unsigned long pt_mfn = 0;
     struct domain_iommu *hd = dom_iommu(d);
@@ -370,9 +371,9 @@ static unsigned long flush_count(unsigned long dfn, unsigned long page_count,
     return end - start;
 }
 
-int amd_iommu_flush_iotlb_pages(struct domain *d, dfn_t dfn,
-                                unsigned long page_count,
-                                unsigned int flush_flags)
+int cf_check amd_iommu_flush_iotlb_pages(
+    struct domain *d, dfn_t dfn, unsigned long page_count,
+    unsigned int flush_flags)
 {
     unsigned long dfn_l = dfn_x(dfn);
 
@@ -410,7 +411,7 @@ int amd_iommu_flush_iotlb_pages(struct domain *d, dfn_t dfn,
     return 0;
 }
 
-int amd_iommu_flush_iotlb_all(struct domain *d)
+int cf_check amd_iommu_flush_iotlb_all(struct domain *d)
 {
     amd_iommu_flush_all_pages(d);
 
@@ -462,7 +463,8 @@ int amd_iommu_reserve_domain_unity_unmap(struct domain *d,
     return rc;
 }
 
-int amd_iommu_get_reserved_device_memory(iommu_grdm_t *func, void *ctxt)
+int cf_check amd_iommu_get_reserved_device_memory(
+    iommu_grdm_t *func, void *ctxt)
 {
     unsigned int seg = 0 /* XXX */, bdf;
     const struct ivrs_mappings *ivrs_mappings = get_ivrs_mappings(seg);
@@ -537,7 +539,7 @@ int amd_iommu_get_reserved_device_memory(iommu_grdm_t *func, void *ctxt)
     return 0;
 }
 
-int __init amd_iommu_quarantine_init(struct domain *d)
+int __init cf_check amd_iommu_quarantine_init(struct domain *d)
 {
     struct domain_iommu *hd = dom_iommu(d);
     unsigned long end_gfn =
diff --git a/xen/drivers/passthrough/amd/pci_amd_iommu.c b/xen/drivers/passthrough/amd/pci_amd_iommu.c
index 9642bba43a26..e57f555d00d1 100644
--- a/xen/drivers/passthrough/amd/pci_amd_iommu.c
+++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c
@@ -197,7 +197,7 @@ int __init acpi_ivrs_init(void)
     return 0;
 }
 
-static int __init iov_detect(void)
+static int __init cf_check iov_detect(void)
 {
     if ( !iommu_enable && !iommu_intremap )
         return 0;
@@ -217,7 +217,7 @@ static int __init iov_detect(void)
     return 0;
 }
 
-static int iov_enable_xt(void)
+static int cf_check iov_enable_xt(void)
 {
     int rc;
 
@@ -253,7 +253,7 @@ int amd_iommu_alloc_root(struct domain *d)
 unsigned int __read_mostly amd_iommu_max_paging_mode = 6;
 int __read_mostly amd_iommu_min_paging_mode = 1;
 
-static int amd_iommu_domain_init(struct domain *d)
+static int cf_check amd_iommu_domain_init(struct domain *d)
 {
     struct domain_iommu *hd = dom_iommu(d);
 
@@ -275,9 +275,9 @@ static int amd_iommu_domain_init(struct domain *d)
     return 0;
 }
 
-static int amd_iommu_add_device(u8 devfn, struct pci_dev *pdev);
+static int cf_check amd_iommu_add_device(u8 devfn, struct pci_dev *pdev);
 
-static void __hwdom_init amd_iommu_hwdom_init(struct domain *d)
+static void __hwdom_init cf_check amd_iommu_hwdom_init(struct domain *d)
 {
     const struct amd_iommu *iommu;
 
@@ -350,8 +350,9 @@ static void amd_iommu_disable_domain_device(const struct domain *domain,
         spin_unlock_irqrestore(&iommu->lock, flags);
 }
 
-static int reassign_device(struct domain *source, struct domain *target,
-                           u8 devfn, struct pci_dev *pdev)
+static int cf_check reassign_device(
+    struct domain *source, struct domain *target, u8 devfn,
+    struct pci_dev *pdev)
 {
     struct amd_iommu *iommu;
     int bdf, rc;
@@ -404,9 +405,8 @@ static int reassign_device(struct domain *source, struct domain *target,
     return 0;
 }
 
-static int amd_iommu_assign_device(struct domain *d, u8 devfn,
-                                   struct pci_dev *pdev,
-                                   u32 flag)
+static int cf_check amd_iommu_assign_device(
+    struct domain *d, u8 devfn, struct pci_dev *pdev, u32 flag)
 {
     struct ivrs_mappings *ivrs_mappings = get_ivrs_mappings(pdev->seg);
     int bdf = PCI_BDF2(pdev->bus, devfn);
@@ -435,7 +435,7 @@ static int amd_iommu_assign_device(struct domain *d, u8 devfn,
     return rc;
 }
 
-static void amd_iommu_clear_root_pgtable(struct domain *d)
+static void cf_check amd_iommu_clear_root_pgtable(struct domain *d)
 {
     struct domain_iommu *hd = dom_iommu(d);
 
@@ -444,13 +444,13 @@ static void amd_iommu_clear_root_pgtable(struct domain *d)
     spin_unlock(&hd->arch.mapping_lock);
 }
 
-static void amd_iommu_domain_destroy(struct domain *d)
+static void cf_check amd_iommu_domain_destroy(struct domain *d)
 {
     iommu_identity_map_teardown(d);
     ASSERT(!dom_iommu(d)->arch.amd.root_table);
 }
 
-static int amd_iommu_add_device(u8 devfn, struct pci_dev *pdev)
+static int cf_check amd_iommu_add_device(u8 devfn, struct pci_dev *pdev)
 {
     struct amd_iommu *iommu;
     u16 bdf;
@@ -525,7 +525,7 @@ static int amd_iommu_add_device(u8 devfn, struct pci_dev *pdev)
     return amd_iommu_setup_domain_device(pdev->domain, iommu, devfn, pdev);
 }
 
-static int amd_iommu_remove_device(u8 devfn, struct pci_dev *pdev)
+static int cf_check amd_iommu_remove_device(u8 devfn, struct pci_dev *pdev)
 {
     struct amd_iommu *iommu;
     u16 bdf;
@@ -562,7 +562,7 @@ static int amd_iommu_remove_device(u8 devfn, struct pci_dev *pdev)
     return 0;
 }
 
-static int amd_iommu_group_id(u16 seg, u8 bus, u8 devfn)
+static int cf_check amd_iommu_group_id(u16 seg, u8 bus, u8 devfn)
 {
     int bdf = PCI_BDF2(bus, devfn);
 
@@ -616,7 +616,7 @@ static void amd_dump_page_table_level(struct page_info *pg, int level,
     unmap_domain_page(table_vaddr);
 }
 
-static void amd_dump_page_tables(struct domain *d)
+static void cf_check amd_dump_page_tables(struct domain *d)
 {
     const struct domain_iommu *hd = dom_iommu(d);
 
diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
index 79f49f0e6007..af1a7f9fab6d 100644
--- a/xen/drivers/passthrough/pci.c
+++ b/xen/drivers/passthrough/pci.c
@@ -1098,7 +1098,7 @@ void pci_check_disable_device(u16 seg, u8 bus, u8 devfn)
  * scan pci devices to add all existed PCI devices to alldevs_list,
  * and setup pci hierarchy in array bus2bridge.
  */
-static int __init _scan_pci_devices(struct pci_seg *pseg, void *arg)
+static int __init cf_check _scan_pci_devices(struct pci_seg *pseg, void *arg)
 {
     struct pci_dev *pdev;
     int bus, dev, func;
@@ -1176,7 +1176,8 @@ static void __hwdom_init setup_one_hwdom_device(const struct setup_hwdom *ctxt,
                ctxt->d->domain_id, err);
 }
 
-static int __hwdom_init _setup_hwdom_pci_devices(struct pci_seg *pseg, void *arg)
+static int __hwdom_init cf_check _setup_hwdom_pci_devices(
+    struct pci_seg *pseg, void *arg)
 {
     struct setup_hwdom *ctxt = arg;
     int bus, devfn;
@@ -1333,7 +1334,7 @@ bool_t pcie_aer_get_firmware_first(const struct pci_dev *pdev)
 }
 #endif
 
-static int _dump_pci_devices(struct pci_seg *pseg, void *arg)
+static int cf_check _dump_pci_devices(struct pci_seg *pseg, void *arg)
 {
     struct pci_dev *pdev;
 
diff --git a/xen/drivers/passthrough/vtd/dmar.c b/xen/drivers/passthrough/vtd/dmar.c
index b8e91f5be1ae..63f8642e126a 100644
--- a/xen/drivers/passthrough/vtd/dmar.c
+++ b/xen/drivers/passthrough/vtd/dmar.c
@@ -1046,7 +1046,8 @@ bool_t __init platform_supports_x2apic(void)
     return cpu_has_x2apic && ((dmar_flags & mask) == ACPI_DMAR_INTR_REMAP);
 }
 
-int intel_iommu_get_reserved_device_memory(iommu_grdm_t *func, void *ctxt)
+int cf_check intel_iommu_get_reserved_device_memory(
+    iommu_grdm_t *func, void *ctxt)
 {
     struct acpi_rmrr_unit *rmrr, *rmrr_cur = NULL;
     unsigned int i;
diff --git a/xen/drivers/passthrough/vtd/extern.h b/xen/drivers/passthrough/vtd/extern.h
index 4595b65e5bce..bf625fd4540e 100644
--- a/xen/drivers/passthrough/vtd/extern.h
+++ b/xen/drivers/passthrough/vtd/extern.h
@@ -33,9 +33,9 @@ void print_iommu_regs(struct acpi_drhd_unit *drhd);
 void print_vtd_entries(struct vtd_iommu *iommu, int bus, int devfn, u64 gmfn);
 keyhandler_fn_t cf_check vtd_dump_iommu_info;
 
-bool intel_iommu_supports_eim(void);
-int intel_iommu_enable_eim(void);
-void intel_iommu_disable_eim(void);
+bool cf_check intel_iommu_supports_eim(void);
+int cf_check intel_iommu_enable_eim(void);
+void cf_check intel_iommu_disable_eim(void);
 
 int enable_qinval(struct vtd_iommu *iommu);
 void disable_qinval(struct vtd_iommu *iommu);
@@ -51,15 +51,13 @@ int iommu_flush_iec_global(struct vtd_iommu *iommu);
 int iommu_flush_iec_index(struct vtd_iommu *iommu, u8 im, u16 iidx);
 void clear_fault_bits(struct vtd_iommu *iommu);
 
-int __must_check vtd_flush_context_reg(struct vtd_iommu *iommu, uint16_t did,
-                                       uint16_t source_id,
-                                       uint8_t function_mask, uint64_t type,
-                                       bool flush_non_present_entry);
-int __must_check vtd_flush_iotlb_reg(struct vtd_iommu *iommu, uint16_t did,
-                                     uint64_t addr, unsigned int size_order,
-                                     uint64_t type,
-                                     bool flush_non_present_entry,
-                                     bool flush_dev_iotlb);
+int __must_check cf_check vtd_flush_context_reg(
+    struct vtd_iommu *iommu, uint16_t did, uint16_t source_id,
+    uint8_t function_mask, uint64_t type, bool flush_non_present_entry);
+int __must_check cf_check vtd_flush_iotlb_reg(
+    struct vtd_iommu *iommu, uint16_t did, uint64_t addr,
+    unsigned int size_order, uint64_t type, bool flush_non_present_entry,
+    bool flush_dev_iotlb);
 
 struct vtd_iommu *ioapic_to_iommu(unsigned int apic_id);
 struct vtd_iommu *hpet_to_iommu(unsigned int hpet_id);
@@ -89,17 +87,19 @@ int domain_context_mapping_one(struct domain *domain, struct vtd_iommu *iommu,
                                u8 bus, u8 devfn, const struct pci_dev *);
 int domain_context_unmap_one(struct domain *domain, struct vtd_iommu *iommu,
                              u8 bus, u8 devfn);
-int intel_iommu_get_reserved_device_memory(iommu_grdm_t *func, void *ctxt);
+int cf_check intel_iommu_get_reserved_device_memory(
+    iommu_grdm_t *func, void *ctxt);
 
-unsigned int io_apic_read_remap_rte(unsigned int apic, unsigned int reg);
-void io_apic_write_remap_rte(unsigned int apic,
-                             unsigned int reg, unsigned int value);
+unsigned int cf_check io_apic_read_remap_rte(
+    unsigned int apic, unsigned int reg);
+void cf_check io_apic_write_remap_rte(
+    unsigned int apic, unsigned int reg, unsigned int value);
 
 struct msi_desc;
 struct msi_msg;
-int msi_msg_write_remap_rte(struct msi_desc *, struct msi_msg *);
+int cf_check msi_msg_write_remap_rte(struct msi_desc *, struct msi_msg *);
 
-int intel_setup_hpet_msi(struct msi_desc *);
+int cf_check intel_setup_hpet_msi(struct msi_desc *);
 
 int is_igd_vt_enabled_quirk(void);
 bool is_azalia_tlb_enabled(const struct acpi_drhd_unit *);
diff --git a/xen/drivers/passthrough/vtd/intremap.c b/xen/drivers/passthrough/vtd/intremap.c
index 01152f200664..e6ba89591b6f 100644
--- a/xen/drivers/passthrough/vtd/intremap.c
+++ b/xen/drivers/passthrough/vtd/intremap.c
@@ -142,7 +142,7 @@ static void set_hpet_source_id(unsigned int id, struct iremap_entry *ire)
     set_ire_sid(ire, SVT_VERIFY_SID_SQ, SQ_13_IGNORE_3, hpetid_to_bdf(id));
 }
 
-bool __init intel_iommu_supports_eim(void)
+bool __init cf_check intel_iommu_supports_eim(void)
 {
     struct acpi_drhd_unit *drhd;
     unsigned int apic;
@@ -414,7 +414,7 @@ static int ioapic_rte_to_remap_entry(struct vtd_iommu *iommu,
     return 0;
 }
 
-unsigned int io_apic_read_remap_rte(
+unsigned int cf_check io_apic_read_remap_rte(
     unsigned int apic, unsigned int reg)
 {
     unsigned int ioapic_pin = (reg - 0x10) / 2;
@@ -438,7 +438,7 @@ unsigned int io_apic_read_remap_rte(
         return (*(((u32 *)&old_rte) + 0));
 }
 
-void io_apic_write_remap_rte(
+void cf_check io_apic_write_remap_rte(
     unsigned int apic, unsigned int reg, unsigned int value)
 {
     unsigned int ioapic_pin = (reg - 0x10) / 2;
@@ -639,7 +639,7 @@ static int msi_msg_to_remap_entry(
     return 0;
 }
 
-int msi_msg_write_remap_rte(
+int cf_check msi_msg_write_remap_rte(
     struct msi_desc *msi_desc, struct msi_msg *msg)
 {
     struct pci_dev *pdev = msi_desc->dev;
@@ -651,7 +651,7 @@ int msi_msg_write_remap_rte(
                 : -EINVAL;
 }
 
-int __init intel_setup_hpet_msi(struct msi_desc *msi_desc)
+int __init cf_check intel_setup_hpet_msi(struct msi_desc *msi_desc)
 {
     struct vtd_iommu *iommu = hpet_to_iommu(msi_desc->hpet_id);
     unsigned long flags;
@@ -802,7 +802,7 @@ void disable_intremap(struct vtd_iommu *iommu)
  * This function is used to enable Interrupt remapping when
  * enable x2apic
  */
-int intel_iommu_enable_eim(void)
+int cf_check intel_iommu_enable_eim(void)
 {
     struct acpi_drhd_unit *drhd;
     struct vtd_iommu *iommu;
@@ -856,7 +856,7 @@ int intel_iommu_enable_eim(void)
  * This function is used to disable Interrupt remapping when
  * suspend local apic
  */
-void intel_iommu_disable_eim(void)
+void cf_check intel_iommu_disable_eim(void)
 {
     struct acpi_drhd_unit *drhd;
 
diff --git a/xen/drivers/passthrough/vtd/iommu.c b/xen/drivers/passthrough/vtd/iommu.c
index 7a9c391bec70..4d7703dd9a20 100644
--- a/xen/drivers/passthrough/vtd/iommu.c
+++ b/xen/drivers/passthrough/vtd/iommu.c
@@ -59,7 +59,7 @@ static unsigned int __read_mostly nr_iommus;
 static struct iommu_ops vtd_ops;
 static struct tasklet vtd_fault_tasklet;
 
-static int setup_hwdom_device(u8 devfn, struct pci_dev *);
+static int cf_check setup_hwdom_device(u8 devfn, struct pci_dev *);
 static void setup_hwdom_rmrr(struct domain *d);
 
 static bool domid_mapping(const struct vtd_iommu *iommu)
@@ -240,7 +240,7 @@ domid_t did_to_domain_id(const struct vtd_iommu *iommu, unsigned int did)
     return iommu->domid_map[did];
 }
 
-static void sync_cache(const void *addr, unsigned int size)
+static void cf_check sync_cache(const void *addr, unsigned int size)
 {
     static unsigned long clflush_size = 0;
     const void *end = addr + size;
@@ -475,9 +475,9 @@ static void iommu_flush_write_buffer(struct vtd_iommu *iommu)
 }
 
 /* return value determine if we need a write buffer flush */
-int vtd_flush_context_reg(struct vtd_iommu *iommu, uint16_t did,
-                          uint16_t source_id, uint8_t function_mask,
-                          uint64_t type, bool flush_non_present_entry)
+int cf_check vtd_flush_context_reg(
+    struct vtd_iommu *iommu, uint16_t did, uint16_t source_id,
+    uint8_t function_mask, uint64_t type, bool flush_non_present_entry)
 {
     unsigned long flags;
 
@@ -542,9 +542,10 @@ static int __must_check iommu_flush_context_device(struct vtd_iommu *iommu,
 }
 
 /* return value determine if we need a write buffer flush */
-int vtd_flush_iotlb_reg(struct vtd_iommu *iommu, uint16_t did, uint64_t addr,
-                        unsigned int size_order, uint64_t type,
-                        bool flush_non_present_entry, bool flush_dev_iotlb)
+int cf_check vtd_flush_iotlb_reg(
+    struct vtd_iommu *iommu, uint16_t did, uint64_t addr,
+    unsigned int size_order, uint64_t type, bool flush_non_present_entry,
+    bool flush_dev_iotlb)
 {
     int tlb_offset = ecap_iotlb_offset(iommu->ecap);
     uint64_t val = type | DMA_TLB_IVT;
@@ -752,10 +753,9 @@ static int __must_check iommu_flush_iotlb(struct domain *d, dfn_t dfn,
     return ret;
 }
 
-static int __must_check iommu_flush_iotlb_pages(struct domain *d,
-                                                dfn_t dfn,
-                                                unsigned long page_count,
-                                                unsigned int flush_flags)
+static int __must_check cf_check iommu_flush_iotlb_pages(
+    struct domain *d, dfn_t dfn, unsigned long page_count,
+    unsigned int flush_flags)
 {
     ASSERT(page_count && !dfn_eq(dfn, INVALID_DFN));
     ASSERT(flush_flags);
@@ -764,7 +764,7 @@ static int __must_check iommu_flush_iotlb_pages(struct domain *d,
                              page_count);
 }
 
-static int __must_check iommu_flush_iotlb_all(struct domain *d)
+static int __must_check cf_check iommu_flush_iotlb_all(struct domain *d)
 {
     return iommu_flush_iotlb(d, INVALID_DFN, 0, 0);
 }
@@ -1393,7 +1393,7 @@ void __init iommu_free(struct acpi_drhd_unit *drhd)
         agaw = 64;                              \
     agaw; })
 
-static int intel_iommu_domain_init(struct domain *d)
+static int cf_check intel_iommu_domain_init(struct domain *d)
 {
     struct domain_iommu *hd = dom_iommu(d);
 
@@ -1407,7 +1407,7 @@ static int intel_iommu_domain_init(struct domain *d)
     return 0;
 }
 
-static void __hwdom_init intel_iommu_hwdom_init(struct domain *d)
+static void __hwdom_init cf_check intel_iommu_hwdom_init(struct domain *d)
 {
     struct acpi_drhd_unit *drhd;
 
@@ -1856,7 +1856,7 @@ static int domain_context_unmap(struct domain *domain, u8 devfn,
     return ret;
 }
 
-static void iommu_clear_root_pgtable(struct domain *d)
+static void cf_check iommu_clear_root_pgtable(struct domain *d)
 {
     struct domain_iommu *hd = dom_iommu(d);
 
@@ -1865,7 +1865,7 @@ static void iommu_clear_root_pgtable(struct domain *d)
     spin_unlock(&hd->arch.mapping_lock);
 }
 
-static void iommu_domain_teardown(struct domain *d)
+static void cf_check iommu_domain_teardown(struct domain *d)
 {
     struct domain_iommu *hd = dom_iommu(d);
     const struct acpi_drhd_unit *drhd;
@@ -1883,9 +1883,9 @@ static void iommu_domain_teardown(struct domain *d)
     XFREE(hd->arch.vtd.iommu_bitmap);
 }
 
-static int __must_check intel_iommu_map_page(struct domain *d, dfn_t dfn,
-                                             mfn_t mfn, unsigned int flags,
-                                             unsigned int *flush_flags)
+static int __must_check cf_check intel_iommu_map_page(
+    struct domain *d, dfn_t dfn, mfn_t mfn, unsigned int flags,
+    unsigned int *flush_flags)
 {
     struct domain_iommu *hd = dom_iommu(d);
     struct dma_pte *page, *pte, old, new = {};
@@ -1954,8 +1954,8 @@ static int __must_check intel_iommu_map_page(struct domain *d, dfn_t dfn,
     return rc;
 }
 
-static int __must_check intel_iommu_unmap_page(struct domain *d, dfn_t dfn,
-                                               unsigned int *flush_flags)
+static int __must_check cf_check intel_iommu_unmap_page(
+    struct domain *d, dfn_t dfn, unsigned int *flush_flags)
 {
     /* Do nothing if VT-d shares EPT page table */
     if ( iommu_use_hap_pt(d) )
@@ -1970,8 +1970,8 @@ static int __must_check intel_iommu_unmap_page(struct domain *d, dfn_t dfn,
     return 0;
 }
 
-static int intel_iommu_lookup_page(struct domain *d, dfn_t dfn, mfn_t *mfn,
-                                   unsigned int *flags)
+static int cf_check intel_iommu_lookup_page(
+    struct domain *d, dfn_t dfn, mfn_t *mfn, unsigned int *flags)
 {
     struct domain_iommu *hd = dom_iommu(d);
     struct dma_pte *page, val;
@@ -2023,7 +2023,7 @@ static int __init vtd_ept_page_compatible(struct vtd_iommu *iommu)
            (ept_has_1gb(ept_cap) && opt_hap_1gb) <= cap_sps_1gb(vtd_cap);
 }
 
-static int intel_iommu_add_device(u8 devfn, struct pci_dev *pdev)
+static int cf_check intel_iommu_add_device(u8 devfn, struct pci_dev *pdev)
 {
     struct acpi_rmrr_unit *rmrr;
     u16 bdf;
@@ -2066,7 +2066,7 @@ static int intel_iommu_add_device(u8 devfn, struct pci_dev *pdev)
     return 0;
 }
 
-static int intel_iommu_enable_device(struct pci_dev *pdev)
+static int cf_check intel_iommu_enable_device(struct pci_dev *pdev)
 {
     struct acpi_drhd_unit *drhd = acpi_find_matched_drhd_unit(pdev);
     int ret = drhd ? ats_device(pdev, drhd) : -ENODEV;
@@ -2081,7 +2081,7 @@ static int intel_iommu_enable_device(struct pci_dev *pdev)
     return ret >= 0 ? 0 : ret;
 }
 
-static int intel_iommu_remove_device(u8 devfn, struct pci_dev *pdev)
+static int cf_check intel_iommu_remove_device(u8 devfn, struct pci_dev *pdev)
 {
     struct acpi_rmrr_unit *rmrr;
     u16 bdf;
@@ -2108,7 +2108,8 @@ static int intel_iommu_remove_device(u8 devfn, struct pci_dev *pdev)
     return domain_context_unmap(pdev->domain, devfn, pdev);
 }
 
-static int __hwdom_init setup_hwdom_device(u8 devfn, struct pci_dev *pdev)
+static int __hwdom_init cf_check setup_hwdom_device(
+    u8 devfn, struct pci_dev *pdev)
 {
     return domain_context_mapping(pdev->domain, devfn, pdev);
 }
@@ -2314,7 +2315,7 @@ static struct iommu_state {
     uint32_t fectl;
 } *__read_mostly iommu_state;
 
-static int __init vtd_setup(void)
+static int __init cf_check vtd_setup(void)
 {
     struct acpi_drhd_unit *drhd;
     struct vtd_iommu *iommu;
@@ -2449,7 +2450,7 @@ static int __init vtd_setup(void)
     return ret;
 }
 
-static int reassign_device_ownership(
+static int cf_check reassign_device_ownership(
     struct domain *source,
     struct domain *target,
     u8 devfn, struct pci_dev *pdev)
@@ -2527,7 +2528,7 @@ static int reassign_device_ownership(
     return ret;
 }
 
-static int intel_iommu_assign_device(
+static int cf_check intel_iommu_assign_device(
     struct domain *d, u8 devfn, struct pci_dev *pdev, u32 flag)
 {
     struct domain *s = pdev->domain;
@@ -2609,7 +2610,7 @@ static int intel_iommu_assign_device(
     return ret;
 }
 
-static int intel_iommu_group_id(u16 seg, u8 bus, u8 devfn)
+static int cf_check intel_iommu_group_id(u16 seg, u8 bus, u8 devfn)
 {
     u8 secbus;
     if ( find_upstream_bridge(seg, &bus, &devfn, &secbus) < 0 )
@@ -2618,7 +2619,7 @@ static int intel_iommu_group_id(u16 seg, u8 bus, u8 devfn)
         return PCI_BDF2(bus, devfn);
 }
 
-static int __must_check vtd_suspend(void)
+static int __must_check cf_check vtd_suspend(void)
 {
     struct acpi_drhd_unit *drhd;
     struct vtd_iommu *iommu;
@@ -2661,7 +2662,7 @@ static int __must_check vtd_suspend(void)
     return 0;
 }
 
-static void vtd_crash_shutdown(void)
+static void cf_check vtd_crash_shutdown(void)
 {
     struct acpi_drhd_unit *drhd;
     struct vtd_iommu *iommu;
@@ -2682,7 +2683,7 @@ static void vtd_crash_shutdown(void)
     }
 }
 
-static void vtd_resume(void)
+static void cf_check vtd_resume(void)
 {
     struct acpi_drhd_unit *drhd;
     struct vtd_iommu *iommu;
@@ -2760,7 +2761,7 @@ static void vtd_dump_page_table_level(paddr_t pt_maddr, int level, paddr_t gpa,
     unmap_vtd_domain_page(pt_vaddr);
 }
 
-static void vtd_dump_page_tables(struct domain *d)
+static void cf_check vtd_dump_page_tables(struct domain *d)
 {
     const struct domain_iommu *hd = dom_iommu(d);
 
@@ -2770,7 +2771,7 @@ static void vtd_dump_page_tables(struct domain *d)
                               agaw_to_level(hd->arch.vtd.agaw), 0, 0);
 }
 
-static int __init intel_iommu_quarantine_init(struct domain *d)
+static int __init cf_check intel_iommu_quarantine_init(struct domain *d)
 {
     struct domain_iommu *hd = dom_iommu(d);
     struct page_info *pg;
diff --git a/xen/drivers/passthrough/vtd/qinval.c b/xen/drivers/passthrough/vtd/qinval.c
index 9f291f47e518..beeb65f0deec 100644
--- a/xen/drivers/passthrough/vtd/qinval.c
+++ b/xen/drivers/passthrough/vtd/qinval.c
@@ -322,9 +322,9 @@ int iommu_flush_iec_index(struct vtd_iommu *iommu, u8 im, u16 iidx)
     return queue_invalidate_iec_sync(iommu, IEC_INDEX_INVL, im, iidx);
 }
 
-static int __must_check flush_context_qi(struct vtd_iommu *iommu, u16 did,
-                                         u16 sid, u8 fm, u64 type,
-                                         bool flush_non_present_entry)
+static int __must_check cf_check flush_context_qi(
+    struct vtd_iommu *iommu, u16 did, u16 sid, u8 fm, u64 type,
+    bool flush_non_present_entry)
 {
     ASSERT(iommu->qinval_maddr);
 
@@ -346,11 +346,9 @@ static int __must_check flush_context_qi(struct vtd_iommu *iommu, u16 did,
                                          type >> DMA_CCMD_INVL_GRANU_OFFSET);
 }
 
-static int __must_check flush_iotlb_qi(struct vtd_iommu *iommu, u16 did,
-                                       u64 addr,
-                                       unsigned int size_order, u64 type,
-                                       bool flush_non_present_entry,
-                                       bool flush_dev_iotlb)
+static int __must_check cf_check flush_iotlb_qi(
+    struct vtd_iommu *iommu, u16 did, u64 addr, unsigned int size_order,
+    u64 type, bool flush_non_present_entry, bool flush_dev_iotlb)
 {
     u8 dr = 0, dw = 0;
     int ret = 0, rc;
@@ -461,18 +459,18 @@ int enable_qinval(struct vtd_iommu *iommu)
     return 0;
 }
 
-static int vtd_flush_context_noop(struct vtd_iommu *iommu, uint16_t did,
-                                  uint16_t source_id, uint8_t function_mask,
-                                  uint64_t type, bool flush_non_present_entry)
+static int cf_check vtd_flush_context_noop(
+    struct vtd_iommu *iommu, uint16_t did, uint16_t source_id,
+    uint8_t function_mask, uint64_t type, bool flush_non_present_entry)
 {
     WARN();
     return -EIO;
 }
 
-static int vtd_flush_iotlb_noop(struct vtd_iommu *iommu, uint16_t did,
-                                uint64_t addr, unsigned int size_order,
-                                uint64_t type, bool flush_non_present_entry,
-                                bool flush_dev_iotlb)
+static int cf_check vtd_flush_iotlb_noop(
+    struct vtd_iommu *iommu, uint16_t did, uint64_t addr,
+    unsigned int size_order, uint64_t type, bool flush_non_present_entry,
+    bool flush_dev_iotlb)
 {
     WARN();
     return -EIO;
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:06:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:06:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271699.466313 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb3U-0006sc-Em; Mon, 14 Feb 2022 13:06:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271699.466313; Mon, 14 Feb 2022 13:06:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb3U-0006sV-AM; Mon, 14 Feb 2022 13:06:12 +0000
Received: by outflank-mailman (input) for mailman id 271699;
 Mon, 14 Feb 2022 13:06:10 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJb2w-0008IH-Gb
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:05:38 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id cca26c48-8d96-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 14:05:37 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cca26c48-8d96-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644843937;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=4s3bqHzDxRb3sy7KdmJzYNLlBSeOBXvCKtFlSSrGjpU=;
  b=CNQti08JLvQqrEccupWdbSo4PoWSm6HyuOiA0tIeLcYMW3e6yssqWxs6
   BQ/8Pzm6vFyCpmbEmaeSrxiPD2a54nJ2TUvCv1PQRdLWvjuEbdQy9GPCG
   M/VCPbyZq5fX4Xr8ePjAleJO/mJFI+t2q0IeB27st3rTZ/8eX032eFL0U
   s=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: f2121Ej7+AAryE+M4fZWH1sR0wMYOCIhdRvvy2ee7nTBRUsqxx5mjG8EbvYG4ULwFfybOvLzbz
 beP00bjVaLt/VtFJzjTyvZxYhAyG7ll6LAv4CYHiKlMN9+b1Z/ArXOVKRZlGGYEH4A6222Bv5N
 av+ofoiIdA7KRlEpTArzl6qgbe/FppWbw232UDgJg5Plhb3Pf5OhXLeAygJc+jXn98UcMWq611
 qRWN282hkenzj0c21G4XpvgibLK9ZOr4OWjwA75o7vALoYEZwP23PvJJ7+4v5JeyZ/FVIg5NRp
 8sFJ+H3wcz2l0helDOTJup3R
X-SBRS: 5.1
X-MesageID: 63592636
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:LIOa8qPhWI2Yj+vvrR27kMFynXyQoLVcMsEvi/4bfWQNrUoggzYPm
 2dMWD2DbKmJYzf8f9ogPoqwo0tXuZ6Ay9IwGgto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6UUsxNbVU8En1500s/w7dRbrNA2rBVPSvc4
 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq
 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYoy2swOFS4
 8Vyibmfaj0DP7zIp80bfBYNRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs
 6VFdnZdNXhvhMrvqF6/YsBqit4uM4/AO4QHt2s75TrYEewnUdbIRKCiCdpwgmxt15oQRqi2i
 8wxVT8yUQr4ZUZzfUYoKooCvsCqmn/kbGgNwL6SjfVuuDWCpOBr65D9PdyQdtGUSMF9mkeDu
 nmA72n/GgsdNtGU1XyC6H3EuwPUtXqlAsRITuT+r6M0xg3IroAONPEIfUOe/siaoV6BZ/dwC
 HY++zsqkoE020P+G7ERQCaEiHKDuxcdXf9ZHOs79ByBx8Lo3uqJOoQXZmUfMYJ77afaURRvj
 wbUxI2xWVSDpZXIESr1y1uCkd+l1cH5x0cmbDRMcwYK6sKLTGob3kOWFYYL/EJYY7TI9dDML
 9Ki8XJWa1Y715djO0CHEbfv2WzEm3QxZlRpjjg7p0r8hu+DWKarZpaz9X/Q5utaIYCSQzGp5
 SZYx5fOvL1TVcjWzkRhpdnh+5nzuZ643MD02wYzT/HNCRzxk5JcQWygyG4nfxo4Wir1UTTof
 FXSqWtsCGx7ZxOXgVtMS9vpUawClPG4ffy8D6y8RoceM/BZKV7clAkzNBH44owYuBV1+U3JE
 czAKpjE4LdzIfkP8QdasM9Dje51lnhmnzu7qFKS503P7IdyrUW9Ed8tWGZipMhghE9diAmKo
 dtZKeWQzBBTDL/3biXNqNZBJlEWN3krQ5vxrpUPJOKEJwNnHkAnCuPQnux9K9A0wfwNm7ea5
 Gy5V29Z1EH72S/NJzKVZy0xc7joR5t+8y42ZHR+IVay1nE/So+z96NDJYAvdLwq+bU7n/55R
 vUIYeuaBfFLRmiV8jgRd8Cl/odjaA6qlUSFOC/8OGozeJtpRgro/N74f1SwqHlSX3Tv7cZn+
 u+uzALWR5YHVj9ONseOZaL91U61sFgchPl2AxnCLO5MdRi+64NtMSHw0KM6epleNRXZyzKG/
 A+KGhNE9/LVqoo4/dSV16CJq4ClT7l3EkZARjSJ6L+3MW/R/3a5wJ8GW+GNJGiPWGTx8aSkR
 ONU0/Cjb6FXwAcU69JxQ+Rx0KYzx9rzvLsLnA1rEULCY0mvFr49cGKN2tNCt/EVy7JU0edst
 pljJjWO1W21Bf7Y
IronPort-HdrOrdr: A9a23:a2X9Z6MLL114acBcTsOjsMiBIKoaSvp037Eqv3oedfU1SL3gqy
 nAppQmPHPP5Ar5HUtQ/OxoW5PwJ080l6QFgrX5VI3KNGKN1VdAbrsSibcKqweQfBEWndQ96U
 4PScdD4aXLfDpHsfo=
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="63592636"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v2 53/70] x86/psr: CFI hardening
Date: Mon, 14 Feb 2022 12:51:10 +0000
Message-ID: <20220214125127.17985-54-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

Control Flow Integrity schemes use toolchain and optionally hardware support
to help protect against call/jump/return oriented programming attacks.

Use cf_check to annotate function pointer targets for the toolchain.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
 xen/arch/x86/psr.c | 33 +++++++++++++++++----------------
 1 file changed, 17 insertions(+), 16 deletions(-)

diff --git a/xen/arch/x86/psr.c b/xen/arch/x86/psr.c
index 6c9cabf3843d..ccb761998f9a 100644
--- a/xen/arch/x86/psr.c
+++ b/xen/arch/x86/psr.c
@@ -282,7 +282,7 @@ static enum psr_feat_type psr_type_to_feat_type(enum psr_type type)
 }
 
 /* Implementation of allocation features' functions. */
-static bool cat_check_cbm(const struct feat_node *feat, uint32_t *val)
+static bool cf_check cat_check_cbm(const struct feat_node *feat, uint32_t *val)
 {
     unsigned int first_bit, zero_bit;
     unsigned int cbm_len = feat->cat.cbm_len;
@@ -417,8 +417,8 @@ static bool mba_init_feature(const struct cpuid_leaf *regs,
     return true;
 }
 
-static bool cat_get_feat_info(const struct feat_node *feat,
-                              uint32_t data[], unsigned int array_len)
+static bool cf_check cat_get_feat_info(
+    const struct feat_node *feat, uint32_t data[], unsigned int array_len)
 {
     if ( array_len != PSR_INFO_ARRAY_SIZE )
         return false;
@@ -431,8 +431,8 @@ static bool cat_get_feat_info(const struct feat_node *feat,
 }
 
 /* L3 CAT props */
-static void l3_cat_write_msr(unsigned int cos, uint32_t val,
-                             enum psr_type type)
+static void cf_check l3_cat_write_msr(
+    unsigned int cos, uint32_t val, enum psr_type type)
 {
     wrmsrl(MSR_IA32_PSR_L3_MASK(cos), val);
 }
@@ -447,8 +447,8 @@ static const struct feat_props l3_cat_props = {
 };
 
 /* L3 CDP props */
-static bool l3_cdp_get_feat_info(const struct feat_node *feat,
-                                 uint32_t data[], uint32_t array_len)
+static bool cf_check l3_cdp_get_feat_info(
+    const struct feat_node *feat, uint32_t data[], uint32_t array_len)
 {
     if ( !cat_get_feat_info(feat, data, array_len) )
         return false;
@@ -458,8 +458,8 @@ static bool l3_cdp_get_feat_info(const struct feat_node *feat,
     return true;
 }
 
-static void l3_cdp_write_msr(unsigned int cos, uint32_t val,
-                             enum psr_type type)
+static void cf_check l3_cdp_write_msr(
+    unsigned int cos, uint32_t val, enum psr_type type)
 {
     wrmsrl(((type == PSR_TYPE_L3_DATA) ?
             MSR_IA32_PSR_L3_MASK_DATA(cos) :
@@ -478,8 +478,8 @@ static const struct feat_props l3_cdp_props = {
 };
 
 /* L2 CAT props */
-static void l2_cat_write_msr(unsigned int cos, uint32_t val,
-                             enum psr_type type)
+static void cf_check l2_cat_write_msr(
+    unsigned int cos, uint32_t val, enum psr_type type)
 {
     wrmsrl(MSR_IA32_PSR_L2_MASK(cos), val);
 }
@@ -494,8 +494,8 @@ static const struct feat_props l2_cat_props = {
 };
 
 /* MBA props */
-static bool mba_get_feat_info(const struct feat_node *feat,
-                              uint32_t data[], unsigned int array_len)
+static bool cf_check mba_get_feat_info(
+    const struct feat_node *feat, uint32_t data[], unsigned int array_len)
 {
     ASSERT(array_len == PSR_INFO_ARRAY_SIZE);
 
@@ -508,13 +508,14 @@ static bool mba_get_feat_info(const struct feat_node *feat,
     return true;
 }
 
-static void mba_write_msr(unsigned int cos, uint32_t val,
-                          enum psr_type type)
+static void cf_check mba_write_msr(
+    unsigned int cos, uint32_t val, enum psr_type type)
 {
     wrmsrl(MSR_IA32_PSR_MBA_MASK(cos), val);
 }
 
-static bool mba_sanitize_thrtl(const struct feat_node *feat, uint32_t *thrtl)
+static bool cf_check mba_sanitize_thrtl(
+    const struct feat_node *feat, uint32_t *thrtl)
 {
     /*
      * Per SDM (chapter "Memory Bandwidth Allocation Configuration"):
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:06:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:06:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271701.466319 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb3V-0006x4-3P; Mon, 14 Feb 2022 13:06:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271701.466319; Mon, 14 Feb 2022 13:06:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb3U-0006vX-Nt; Mon, 14 Feb 2022 13:06:12 +0000
Received: by outflank-mailman (input) for mailman id 271701;
 Mon, 14 Feb 2022 13:06:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJb3I-00023t-II
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:06:00 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d9261969-8d96-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 14:05:58 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d9261969-8d96-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644843959;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=1mxkmFvBHm9TxAw5kL2fslSWdtu5vEoGopavW5H2guc=;
  b=FdX0Bfkwo5GiZMXCWjnQkpoIffe8XjBTrhwaAAXhhvXy6W46ruhcH7fU
   9TBCGmvUbvW7f1G1UrOBAaOrafYgB0QHXdFoVyS2Bc98pRY7dEt31sa0e
   qoNkSBss6oqPs+1V0XTufDPzsfP7hroFWwhySNcKzwMxETvxZ6RwTYeJ0
   c=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: 6qVrT5YlGRLe+iB32YZTsQOWSU/VWq5wH2X4XuAUdRo7uhPMH01lQPSplGVDoye+u39HVFUsWj
 GlaznnRrjnGfI3nWFfVrpuirUGhDsQLb57yNmO3qUT6BYEXWnvvYc9O7U65Ao0fKXnfqLp/BUP
 AK3WxvcZg3D8XHjAHOpDqWsLvj/XBgvQ4xFABRuUe7J2/GnzVlyTrp2zkoDeDSqUrR4Y//wyX1
 JBbQZ7nMLS2KhzG4ebGv2jsDT+2UUKl1cDF5qwLU2Y2sAoOoJ0fgZ2wLWZaJvmIJ7kuIxI/LWK
 BbsIyjiVyyc7sDxvfswrysrR
X-SBRS: 5.1
X-MesageID: 63592665
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:mkvNcauFnnrShkkFCzfWplKis+fnVEhZMUV32f8akzHdYApBsoF/q
 tZmKTrUP/+LMGbzLt4jPIm39BkCvJeEmtZrHQI/r3o2E34R+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZQP0VOZigHtIQMsadUsxKbVIiGHdJZS5LwbZj2NYy2IThWmthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 NplnpWSRF4NDIP3u8cZfD0HDHh+IqN29+qSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DFYUToHx/ixreCu4rW8vrSKTW/95Imjw3g6iiGN6AP
 JdIM2QxMXwsZTUUZwclEsgHu9632F/jLjxTo3/E+KAOtj27IAtZj+G2bYu9lsaxbdVYmAOUq
 3zL+0z9AwoGL5qPxDyd6HWui+TT2yThV+ov+KaQr6AwxgfJnypKVUNQBQDTTeSFZlCWcNt9J
 hUwyAQVjos222j0UYD9QBOIryvR1vIDYOZ4H+o/4QCL76Pb5QeFG2QJJgJ8hMwaWNweHmJzi
 ALQ9z/9LXk26eDOFyrBnluBhW7qYUAowXk+iTjopOfvy/3qu8kNgx3GVb6P+4bl34SuSVkcL
 91nxRXSZon/b+ZWjc1XHnid2lpAQ6QlqSZvuG3qspqNtF8RWWJcT9XABaLnxfhBNp2FaVKKo
 WIJncOThMhXU83Ry3zdHbhVRerzjxpgDNE7qQQxd6TNChz3oyLzFWyuyG0WyLhV3jYsJmayP
 R67VfJ5755PJnq6BZKbkKrqY/nGOZPITIy/PtiNN4ImSsEoKGevoXE/DWbNjjuFuBV9zskC1
 WKzLJ/E4YAyUv88klJbho41jNcW+8zJ7T2PFM6rl0z9idJzphe9EN84DbdHVchhhIvsnekf2
 4832xKix0oNXevgTDPQ9IJPf1kGIWJiXcL9qtBNd/7FKQ1jQTlzB/jUyLInWopkg6UKybuYo
 iDjAhdVmAjlmHnKCQSWcXQ/Ornhaoly8CAgNis2MFf2h3V6OdSz7L0SfoccdKU88LAx1uZ9S
 vQIIp3SAvlGRjnd1S4aaJ3x8N5reBix3FrcNCu5ejkvOZVnQlWRqNPjewLu8ggIDza26pRi8
 +HxiFuDTMNaFQp4DcvQZPa+9H+LvCAQyLBoQk/FAthPY0GwooJkHDP8060sKMYWJBSdmjbDj
 1SKAQ0VrPXmqpMu9IWbnriNqoqkHrcsHkdeGGWHv7+6OTODozimyI5EFu2JYSrcRCX//6D7P
 bdZyPT1MfsmmldWstUjT+Y3nPxmv9a/9aVHyglEHWnQawX5A7xtFXCKwM1Tu/Af3bReowa3B
 hqC99Qy1W9l4y85/Ir9/DYYU9k=
IronPort-HdrOrdr: A9a23:Adm6qK7ZXP0F5SbHMgPXwMrXdLJyesId70hD6qhwISY6TiX4rb
 HWoB1173/JYVoqNE3I3OrwXZVoIkmsk6Kdg7NhXotKNTOO0ADDQb2Kr7GSpwEIcxeOkdK1vp
 0AT0ERMrLN5CBB/KTH3DU=
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="63592665"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v2 37/70] x86/apic: CFI hardening
Date: Mon, 14 Feb 2022 12:50:54 +0000
Message-ID: <20220214125127.17985-38-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

Control Flow Integrity schemes use toolchain and optionally hardware support
to help protect against call/jump/return oriented programming attacks.

Use cf_check to annotate function pointer targets for the toolchain.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
 xen/arch/x86/genapic/bigsmp.c      |  4 ++--
 xen/arch/x86/genapic/delivery.c    | 12 ++++++------
 xen/arch/x86/genapic/x2apic.c      | 16 ++++++++++------
 xen/arch/x86/include/asm/genapic.h | 18 +++++++++---------
 xen/arch/x86/smp.c                 |  6 +++---
 5 files changed, 30 insertions(+), 26 deletions(-)

diff --git a/xen/arch/x86/genapic/bigsmp.c b/xen/arch/x86/genapic/bigsmp.c
index b9d976e8abf2..2000383ab0bf 100644
--- a/xen/arch/x86/genapic/bigsmp.c
+++ b/xen/arch/x86/genapic/bigsmp.c
@@ -10,7 +10,7 @@
 #include <xen/dmi.h>
 #include <asm/io_apic.h>
 
-static __init int force_bigsmp(const struct dmi_system_id *d)
+static int __init cf_check force_bigsmp(const struct dmi_system_id *d)
 {
 	printk(KERN_NOTICE "%s detected: force use of apic=bigsmp\n", d->ident);
 	def_to_bigsmp = true;
@@ -27,7 +27,7 @@ static const struct dmi_system_id __initconstrel bigsmp_dmi_table[] = {
 };
 
 
-static __init int probe_bigsmp(void)
+static int __init cf_check probe_bigsmp(void)
 { 
 	/*
 	 * We don't implement cluster mode, so force use of
diff --git a/xen/arch/x86/genapic/delivery.c b/xen/arch/x86/genapic/delivery.c
index 548c33f282dd..d1f99bf6834a 100644
--- a/xen/arch/x86/genapic/delivery.c
+++ b/xen/arch/x86/genapic/delivery.c
@@ -9,7 +9,7 @@
  * LOGICAL FLAT DELIVERY MODE (multicast via bitmask to <= 8 logical APIC IDs).
  */
 
-void init_apic_ldr_flat(void)
+void cf_check init_apic_ldr_flat(void)
 {
 	unsigned long val;
 
@@ -19,12 +19,12 @@ void init_apic_ldr_flat(void)
 	apic_write(APIC_LDR, val);
 }
 
-const cpumask_t *vector_allocation_cpumask_flat(int cpu)
+const cpumask_t *cf_check vector_allocation_cpumask_flat(int cpu)
 {
 	return &cpu_online_map;
 } 
 
-unsigned int cpu_mask_to_apicid_flat(const cpumask_t *cpumask)
+unsigned int cf_check cpu_mask_to_apicid_flat(const cpumask_t *cpumask)
 {
 	return cpumask_bits(cpumask)[0]&0xFF;
 }
@@ -33,17 +33,17 @@ unsigned int cpu_mask_to_apicid_flat(const cpumask_t *cpumask)
  * PHYSICAL DELIVERY MODE (unicast to physical APIC IDs).
  */
 
-void init_apic_ldr_phys(void)
+void cf_check init_apic_ldr_phys(void)
 {
 	/* We only deliver in phys mode - no setup needed. */
 }
 
-const cpumask_t *vector_allocation_cpumask_phys(int cpu)
+const cpumask_t *cf_check vector_allocation_cpumask_phys(int cpu)
 {
 	return cpumask_of(cpu);
 }
 
-unsigned int cpu_mask_to_apicid_phys(const cpumask_t *cpumask)
+unsigned int cf_check cpu_mask_to_apicid_phys(const cpumask_t *cpumask)
 {
 	/* As we are using single CPU as destination, pick only one CPU here */
 	return cpu_physical_id(cpumask_any(cpumask));
diff --git a/xen/arch/x86/genapic/x2apic.c b/xen/arch/x86/genapic/x2apic.c
index bd44bb753995..de5032f2020a 100644
--- a/xen/arch/x86/genapic/x2apic.c
+++ b/xen/arch/x86/genapic/x2apic.c
@@ -38,7 +38,7 @@ static inline u32 x2apic_cluster(unsigned int cpu)
     return per_cpu(cpu_2_logical_apicid, cpu) >> 16;
 }
 
-static void init_apic_ldr_x2apic_cluster(void)
+static void cf_check init_apic_ldr_x2apic_cluster(void)
 {
     unsigned int cpu, this_cpu = smp_processor_id();
 
@@ -74,12 +74,14 @@ static void init_apic_ldr_x2apic_cluster(void)
     cpumask_set_cpu(this_cpu, per_cpu(cluster_cpus, this_cpu));
 }
 
-static const cpumask_t *vector_allocation_cpumask_x2apic_cluster(int cpu)
+static const cpumask_t *cf_check vector_allocation_cpumask_x2apic_cluster(
+    int cpu)
 {
     return per_cpu(cluster_cpus, cpu);
 }
 
-static unsigned int cpu_mask_to_apicid_x2apic_cluster(const cpumask_t *cpumask)
+static unsigned int cf_check cpu_mask_to_apicid_x2apic_cluster(
+    const cpumask_t *cpumask)
 {
     unsigned int cpu = cpumask_any(cpumask);
     unsigned int dest = per_cpu(cpu_2_logical_apicid, cpu);
@@ -92,12 +94,13 @@ static unsigned int cpu_mask_to_apicid_x2apic_cluster(const cpumask_t *cpumask)
     return dest;
 }
 
-static void send_IPI_self_x2apic(uint8_t vector)
+static void cf_check send_IPI_self_x2apic(uint8_t vector)
 {
     apic_wrmsr(APIC_SELF_IPI, vector);
 }
 
-static void send_IPI_mask_x2apic_phys(const cpumask_t *cpumask, int vector)
+static void cf_check send_IPI_mask_x2apic_phys(
+    const cpumask_t *cpumask, int vector)
 {
     unsigned int cpu;
     unsigned long flags;
@@ -130,7 +133,8 @@ static void send_IPI_mask_x2apic_phys(const cpumask_t *cpumask, int vector)
     local_irq_restore(flags);
 }
 
-static void send_IPI_mask_x2apic_cluster(const cpumask_t *cpumask, int vector)
+static void cf_check send_IPI_mask_x2apic_cluster(
+    const cpumask_t *cpumask, int vector)
 {
     unsigned int cpu = smp_processor_id();
     cpumask_t *ipimask = per_cpu(scratch_mask, cpu);
diff --git a/xen/arch/x86/include/asm/genapic.h b/xen/arch/x86/include/asm/genapic.h
index 51a65d3e0f0c..beeaddf19daa 100644
--- a/xen/arch/x86/include/asm/genapic.h
+++ b/xen/arch/x86/include/asm/genapic.h
@@ -39,12 +39,12 @@ extern struct genapic genapic;
 extern const struct genapic apic_default;
 extern const struct genapic apic_bigsmp;
 
-void send_IPI_self_legacy(uint8_t vector);
+void cf_check send_IPI_self_legacy(uint8_t vector);
 
-void init_apic_ldr_flat(void);
-unsigned int cpu_mask_to_apicid_flat(const cpumask_t *cpumask);
-void send_IPI_mask_flat(const cpumask_t *mask, int vector);
-const cpumask_t *vector_allocation_cpumask_flat(int cpu);
+void cf_check init_apic_ldr_flat(void);
+unsigned int cf_check cpu_mask_to_apicid_flat(const cpumask_t *cpumask);
+void cf_check send_IPI_mask_flat(const cpumask_t *mask, int vector);
+const cpumask_t *cf_check vector_allocation_cpumask_flat(int cpu);
 #define GENAPIC_FLAT \
 	.int_delivery_mode = dest_LowestPrio, \
 	.int_dest_mode = 1 /* logical delivery */, \
@@ -54,10 +54,10 @@ const cpumask_t *vector_allocation_cpumask_flat(int cpu);
 	.send_IPI_mask = send_IPI_mask_flat, \
 	.send_IPI_self = send_IPI_self_legacy
 
-void init_apic_ldr_phys(void);
-unsigned int cpu_mask_to_apicid_phys(const cpumask_t *cpumask);
-void send_IPI_mask_phys(const cpumask_t *mask, int vector);
-const cpumask_t *vector_allocation_cpumask_phys(int cpu);
+void cf_check init_apic_ldr_phys(void);
+unsigned int cf_check cpu_mask_to_apicid_phys(const cpumask_t *cpumask);
+void cf_check send_IPI_mask_phys(const cpumask_t *mask, int vector);
+const cpumask_t *cf_check vector_allocation_cpumask_phys(int cpu);
 #define GENAPIC_PHYS \
 	.int_delivery_mode = dest_Fixed, \
 	.int_dest_mode = 0 /* physical delivery */, \
diff --git a/xen/arch/x86/smp.c b/xen/arch/x86/smp.c
index 33748e629a21..0a02086966c0 100644
--- a/xen/arch/x86/smp.c
+++ b/xen/arch/x86/smp.c
@@ -161,13 +161,13 @@ void send_IPI_self(int vector)
  * The following functions deal with sending IPIs between CPUs.
  */
 
-void send_IPI_self_legacy(uint8_t vector)
+void cf_check send_IPI_self_legacy(uint8_t vector)
 {
     /* NMI continuation handling relies on using a shorthand here. */
     send_IPI_shortcut(APIC_DEST_SELF, vector, APIC_DEST_PHYSICAL);
 }
 
-void send_IPI_mask_flat(const cpumask_t *cpumask, int vector)
+void cf_check send_IPI_mask_flat(const cpumask_t *cpumask, int vector)
 {
     unsigned long mask = cpumask_bits(cpumask)[0];
     unsigned long cfg;
@@ -204,7 +204,7 @@ void send_IPI_mask_flat(const cpumask_t *cpumask, int vector)
     local_irq_restore(flags);
 }
 
-void send_IPI_mask_phys(const cpumask_t *mask, int vector)
+void cf_check send_IPI_mask_phys(const cpumask_t *mask, int vector)
 {
     unsigned long cfg, flags;
     unsigned int query_cpu;
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:06:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:06:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271705.466327 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb3V-00079c-PO; Mon, 14 Feb 2022 13:06:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271705.466327; Mon, 14 Feb 2022 13:06:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb3V-00076e-It; Mon, 14 Feb 2022 13:06:13 +0000
Received: by outflank-mailman (input) for mailman id 271705;
 Mon, 14 Feb 2022 13:06:11 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJb3C-00023t-70
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:05:54 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d495ce3a-8d96-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 14:05:50 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d495ce3a-8d96-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644843951;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=DT/FfQl+XmikwzNvldKPzp5Fi1KnEHWZn7DpIm9D+IQ=;
  b=gmymjwTb0Wx6O3gPuzj83RfrT4ii1LAfdW4yCj++kvS/Mhub4cHBjfEe
   o1WlHM/y+2KO4GUmzhXsq45+3P5NCXQRrXJkyJOpT+2OfvMo7QPFxkDQY
   Us4MHyvcz19xUclRCvTX6UT0QJAVBGgfYgHVMmwv6+bpoTipLd8DlaH1K
   M=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: MjkvN0rIeBabDS3x7UKhMnVMszo15I42VfqX0sZayQ/G2oner+0AKcDs/QXxW2qZS4qjG49qJo
 neTYnJj6lWTHIpCrjyyYmxlhLFxDofa9lJc+NyxHpo+2YvMyCqh4QOiz9w7pkxp7maQO2RlX+m
 MKtdknqBbTagUDm8V7MsjXuWot6Q/b2oDgCcpHfG1DJhFJL0UZjpRvu5vwDt8n4bFG43VHteZD
 TJzF/drGfYXZakKBhWtRZkv6ugmLPOQ1N39j8zJDRZTzZzTB0mYXJn0M4UW3E3uCcu7VZ01U/w
 YeL/ew0PZ42LsHCTI5g2SNis
X-SBRS: 5.1
X-MesageID: 66374915
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:H+7tV6DFwxEnHRVW/zbkw5YqxClBgxIJ4kV8jS/XYbTApGwqhDQAy
 WFNCGGOM/reamTxfY9zPIS08x4C7JHUzYdgQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMo/u1Si6FatANl1ElvU2zbue6WL6s1hxZH1c+En970E47wobVv6Yz6TSHK1LV0
 T/Ni5W31G+Ng1aY5UpNtspvADs21BjDkGtwUm4WPJinj3eH/5UhN7oNJLnZEpfNatI88thW5
 Qr05OrREmvxp3/BAz4++1rxWhVirrX6ZWBihpfKMkQLb9crSiEai84G2PQghUh/tDWRjtxOx
 N92iY2AVSJ0Go32ic1eTEwNe81+FfUuFL7vJHG+tYqYzlHccmuqyPJrZK00FdRGoKAtWzgIr
 KFGbmBWBvyAr7veLLaTY+9gnMk8auLsO5sSoCpIxjDFF/c2B5vERs0m4PcGgmxv2pEXQJ4yY
 eIEeytwRwjeZCFeP3ERLc4DobbzgGXgJmgwRFW9+vNsvjm7IBZK+KjgNp/Zd8KHQe1Rn12Ev
 STW8mLhGBYYOdeDjz2f/RqRavTnxH2hHthITfvhq6As0Ab7KnEv5AM+alujsPWGhkSFZ8NvN
 2lJ3goUvIFx6xn+JjXiZCGQrHmBtx8aftNfFewm9Q2AopbpDxal6nssFWAYNoF/3CMibXlzj
 wLSwYu1bdB6mODNERqgGqGoQSRe0MT/BUsLfmc6QAQM+LEPS6lj30uUHr6P/ENY5+AZ+A0cI
 RjX9kDSZJ1J1KbnMplXGnid3VqRSmDhFFJd2+kudjvNAvlFTICkfZe0zlPQ8OxNKo2UJnHY4
 iRYxJjOsb1WVMrX/MBofAnqNOv3j8tpzRWG2QI/d3Xf32jFF4GfkXB4v2gleRYB3jcscj71e
 k7D0T69F7cIVEZGmZRfOtrrY+xzlPCIPY28Cpj8M4ofCrAsJVTv1Hw/OiatM5XFzRFEfVcXY
 szAL65BzB8yVMxa8dZBb7lBj+F7nH1irY4RLLiipymaPXOlTCb9Yd843JGmMojVNYuI/1fY9
 chxLcyPx0kNWeHyeHCPo4USMUoLPT4wApWv855bceuKIwxHHmA9CqCOneN9KtI9x6kFxP3V+
 nydW1NDzAatj3PwNgjXOGtob6niXMgjoCtjbzAsJ1uhx1MqfZ2rsPUEb5IycLR+rL5jwPd4Q
 uMrYcKFBvgTGD3L9y5ENcv2rZB4dQTtjgWLZnL3bD86dp9mZgrI5t67IVe/qHhQVnK67JJsr
 aeh2wXXRYs4az5jVMuGOuiyy16RvGQGnL4gVUX/PdQOKl7n95JnKnKtg6Zvcd0MMxjK2hCTy
 x2SXUUDveDIroI4rIvJiKSDo9v7GudyBBMHTWzS7LLwPijG5Guzh4RHVb/QLzzaUWr1/oSkZ
 PlUkK6gYKFWwg4SvtouCatvwII/+8Dr9u1TwQlTFXnWa0imV+F7KX6c0MgT7qBAy9e1Y+dtt
 p5jLjWCBYi0BQ==
IronPort-HdrOrdr: A9a23:O8rhhqoHDuk5+g3dL0ydFmYaV5opeYIsimQD101hICG8cqSj+f
 xG/c5rrCMc5wxwZJhNo7y90ey7MBbhHP1OkO8s1NWZLWrbUQKTRekIh+bfKn/baknDH4ZmpM
 BdmsNFaeEYY2IUsS+D2njbL+od
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="66374915"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v2 10/70] xen: CFI hardening for __initcall()
Date: Mon, 14 Feb 2022 12:50:27 +0000
Message-ID: <20220214125127.17985-11-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

Control Flow Integrity schemes use toolchain and optionally hardware support
to help protect against call/jump/return oriented programming attacks.

Use cf_check to annotate function pointer targets for the toolchain.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
 xen/arch/x86/acpi/cpu_idle.c                 | 4 ++--
 xen/arch/x86/acpi/cpufreq/cpufreq.c          | 2 +-
 xen/arch/x86/cpu/mcheck/non-fatal.c          | 2 +-
 xen/arch/x86/cpu/microcode/core.c            | 2 +-
 xen/arch/x86/cpu/mtrr/main.c                 | 2 +-
 xen/arch/x86/cpu/vpmu.c                      | 2 +-
 xen/arch/x86/domain.c                        | 2 +-
 xen/arch/x86/extable.c                       | 2 +-
 xen/arch/x86/hvm/hvm.c                       | 4 ++--
 xen/arch/x86/hvm/irq.c                       | 2 +-
 xen/arch/x86/hvm/mtrr.c                      | 2 +-
 xen/arch/x86/hvm/nestedhvm.c                 | 3 +--
 xen/arch/x86/hvm/quirks.c                    | 2 +-
 xen/arch/x86/include/asm/hvm/save.h          | 2 +-
 xen/arch/x86/ioport_emulate.c                | 4 ++--
 xen/arch/x86/irq.c                           | 4 ++--
 xen/arch/x86/mm/shadow/common.c              | 4 ++--
 xen/arch/x86/msi.c                           | 2 +-
 xen/arch/x86/nmi.c                           | 2 +-
 xen/arch/x86/numa.c                          | 2 +-
 xen/arch/x86/oprofile/nmi_int.c              | 2 +-
 xen/arch/x86/percpu.c                        | 2 +-
 xen/arch/x86/psr.c                           | 2 +-
 xen/arch/x86/pv/domain.c                     | 2 +-
 xen/arch/x86/shutdown.c                      | 2 +-
 xen/arch/x86/time.c                          | 8 ++++----
 xen/common/core_parking.c                    | 2 +-
 xen/common/debugtrace.c                      | 2 +-
 xen/common/event_channel.c                   | 2 +-
 xen/common/gdbstub.c                         | 2 +-
 xen/common/grant_table.c                     | 2 +-
 xen/common/kernel.c                          | 4 ++--
 xen/common/kexec.c                           | 2 +-
 xen/common/livepatch.c                       | 2 +-
 xen/common/page_alloc.c                      | 4 ++--
 xen/common/radix-tree.c                      | 2 +-
 xen/common/random.c                          | 2 +-
 xen/common/sched/cpupool.c                   | 2 +-
 xen/common/spinlock.c                        | 2 +-
 xen/common/stop_machine.c                    | 2 +-
 xen/drivers/cpufreq/cpufreq.c                | 2 +-
 xen/drivers/cpufreq/cpufreq_misc_governors.c | 6 +++---
 xen/drivers/cpufreq/cpufreq_ondemand.c       | 2 +-
 xen/drivers/passthrough/amd/iommu.h          | 2 +-
 xen/drivers/passthrough/amd/iommu_init.c     | 2 +-
 xen/drivers/passthrough/pci.c                | 2 +-
 xen/drivers/passthrough/vtd/iommu.c          | 2 +-
 xen/drivers/passthrough/x86/hvm.c            | 2 +-
 48 files changed, 60 insertions(+), 61 deletions(-)

diff --git a/xen/arch/x86/acpi/cpu_idle.c b/xen/arch/x86/acpi/cpu_idle.c
index 5d73eb5917af..7902ccce6b98 100644
--- a/xen/arch/x86/acpi/cpu_idle.c
+++ b/xen/arch/x86/acpi/cpu_idle.c
@@ -410,7 +410,7 @@ static void dump_cx(unsigned char key)
     }
 }
 
-static int __init cpu_idle_key_init(void)
+static int __init cf_check cpu_idle_key_init(void)
 {
     register_keyhandler('c', dump_cx, "dump ACPI Cx structures", 1);
     return 0;
@@ -1655,7 +1655,7 @@ static struct notifier_block cpu_nfb = {
     .notifier_call = cpu_callback
 };
 
-static int __init cpuidle_presmp_init(void)
+static int __init cf_check cpuidle_presmp_init(void)
 {
     void *cpu = (void *)(long)smp_processor_id();
 
diff --git a/xen/arch/x86/acpi/cpufreq/cpufreq.c b/xen/arch/x86/acpi/cpufreq/cpufreq.c
index 029c9398c42a..9510f05340aa 100644
--- a/xen/arch/x86/acpi/cpufreq/cpufreq.c
+++ b/xen/arch/x86/acpi/cpufreq/cpufreq.c
@@ -630,7 +630,7 @@ static const struct cpufreq_driver __initconstrel acpi_cpufreq_driver = {
     .exit   = acpi_cpufreq_cpu_exit,
 };
 
-static int __init cpufreq_driver_init(void)
+static int __init cf_check cpufreq_driver_init(void)
 {
     int ret = 0;
 
diff --git a/xen/arch/x86/cpu/mcheck/non-fatal.c b/xen/arch/x86/cpu/mcheck/non-fatal.c
index ec52d37c96e1..2679c220a8a2 100644
--- a/xen/arch/x86/cpu/mcheck/non-fatal.c
+++ b/xen/arch/x86/cpu/mcheck/non-fatal.c
@@ -86,7 +86,7 @@ static void mce_work_fn(void *data)
 	adjust = 0;
 }
 
-static int __init init_nonfatal_mce_checker(void)
+static int __init cf_check init_nonfatal_mce_checker(void)
 {
 	struct cpuinfo_x86 *c = &boot_cpu_data;
 
diff --git a/xen/arch/x86/cpu/microcode/core.c b/xen/arch/x86/cpu/microcode/core.c
index 95d35ca0f3f7..46f55fe7f191 100644
--- a/xen/arch/x86/cpu/microcode/core.c
+++ b/xen/arch/x86/cpu/microcode/core.c
@@ -696,7 +696,7 @@ int microcode_update(XEN_GUEST_HANDLE(const_void) buf, unsigned long len)
                                      microcode_update_helper, buffer);
 }
 
-static int __init microcode_init(void)
+static int __init cf_check microcode_init(void)
 {
     /*
      * At this point, all CPUs should have updated their microcode
diff --git a/xen/arch/x86/cpu/mtrr/main.c b/xen/arch/x86/cpu/mtrr/main.c
index e9df53f00d61..428133100d46 100644
--- a/xen/arch/x86/cpu/mtrr/main.c
+++ b/xen/arch/x86/cpu/mtrr/main.c
@@ -632,7 +632,7 @@ void mtrr_bp_restore(void)
 	mtrr_if->set_all();
 }
 
-static int __init mtrr_init_finialize(void)
+static int __init cf_check mtrr_init_finialize(void)
 {
 	if (!mtrr_if)
 		return 0;
diff --git a/xen/arch/x86/cpu/vpmu.c b/xen/arch/x86/cpu/vpmu.c
index b10d6e2eb458..9fc897dc8403 100644
--- a/xen/arch/x86/cpu/vpmu.c
+++ b/xen/arch/x86/cpu/vpmu.c
@@ -844,7 +844,7 @@ static struct notifier_block cpu_nfb = {
     .notifier_call = cpu_callback
 };
 
-static int __init vpmu_init(void)
+static int __init cf_check vpmu_init(void)
 {
     int vendor = current_cpu_data.x86_vendor;
     const struct arch_vpmu_ops *ops = NULL;
diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c
index ef1812dc1402..f943283b2a88 100644
--- a/xen/arch/x86/domain.c
+++ b/xen/arch/x86/domain.c
@@ -2532,7 +2532,7 @@ static void vcpu_kick_softirq(void)
      */
 }
 
-static int __init init_vcpu_kick_softirq(void)
+static int __init cf_check init_vcpu_kick_softirq(void)
 {
     open_softirq(VCPU_KICK_SOFTIRQ, vcpu_kick_softirq);
     return 0;
diff --git a/xen/arch/x86/extable.c b/xen/arch/x86/extable.c
index 78d672722580..51ef863d786c 100644
--- a/xen/arch/x86/extable.c
+++ b/xen/arch/x86/extable.c
@@ -126,7 +126,7 @@ search_exception_table(const struct cpu_user_regs *regs)
 #ifndef NDEBUG
 #include <asm/traps.h>
 
-static int __init stub_selftest(void)
+static int __init cf_check stub_selftest(void)
 {
     static const struct {
         uint8_t opc[4];
diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c
index 4e685c1b0c1b..2ae1685d0aff 100644
--- a/xen/arch/x86/hvm/hvm.c
+++ b/xen/arch/x86/hvm/hvm.c
@@ -164,7 +164,7 @@ static bool __init hap_supported(struct hvm_function_table *fns)
     return true;
 }
 
-static int __init hvm_enable(void)
+static int __init cf_check hvm_enable(void)
 {
     const struct hvm_function_table *fns = NULL;
 
@@ -1506,7 +1506,7 @@ static int hvm_load_cpu_msrs(struct domain *d, hvm_domain_context_t *h)
 /* We need variable length data chunks for XSAVE area and MSRs, hence
  * a custom declaration rather than HVM_REGISTER_SAVE_RESTORE.
  */
-static int __init hvm_register_CPU_save_and_restore(void)
+static int __init cf_check hvm_register_CPU_save_and_restore(void)
 {
     hvm_register_savevm(CPU_XSAVE_CODE,
                         "CPU_XSAVE",
diff --git a/xen/arch/x86/hvm/irq.c b/xen/arch/x86/hvm/irq.c
index 52aae4565f0c..6045c9149bad 100644
--- a/xen/arch/x86/hvm/irq.c
+++ b/xen/arch/x86/hvm/irq.c
@@ -650,7 +650,7 @@ static void dump_irq_info(unsigned char key)
     rcu_read_unlock(&domlist_read_lock);
 }
 
-static int __init dump_irq_info_key_init(void)
+static int __init cf_check dump_irq_info_key_init(void)
 {
     register_keyhandler('I', dump_irq_info, "dump HVM irq info", 1);
     return 0;
diff --git a/xen/arch/x86/hvm/mtrr.c b/xen/arch/x86/hvm/mtrr.c
index 4a9f3177edd4..b3ef1bf54133 100644
--- a/xen/arch/x86/hvm/mtrr.c
+++ b/xen/arch/x86/hvm/mtrr.c
@@ -75,7 +75,7 @@ static uint8_t __read_mostly mtrr_epat_tbl[MTRR_NUM_TYPES][MEMORY_NUM_TYPES] =
 static uint8_t __read_mostly pat_entry_tbl[PAT_TYPE_NUMS] =
     { [0 ... PAT_TYPE_NUMS-1] = INVALID_MEM_TYPE };
 
-static int __init hvm_mtrr_pat_init(void)
+static int __init cf_check hvm_mtrr_pat_init(void)
 {
     unsigned int i, j;
 
diff --git a/xen/arch/x86/hvm/nestedhvm.c b/xen/arch/x86/hvm/nestedhvm.c
index 5021da667a47..23516884482b 100644
--- a/xen/arch/x86/hvm/nestedhvm.c
+++ b/xen/arch/x86/hvm/nestedhvm.c
@@ -125,8 +125,7 @@ nestedhvm_vmcx_flushtlb(struct p2m_domain *p2m)
  * iomap[2]      set        set
  */
 
-static int __init
-nestedhvm_setup(void)
+static int __init cf_check nestedhvm_setup(void)
 {
     /* Same format and size as hvm_io_bitmap (Intel needs only 2 pages). */
     unsigned nr = cpu_has_vmx ? 2 : 3;
diff --git a/xen/arch/x86/hvm/quirks.c b/xen/arch/x86/hvm/quirks.c
index 54cc66c382b6..917356b1312c 100644
--- a/xen/arch/x86/hvm/quirks.c
+++ b/xen/arch/x86/hvm/quirks.c
@@ -36,7 +36,7 @@ static int __init dmi_hvm_deny_port80(const struct dmi_system_id *id)
     return 0;
 }
 
-static int __init check_port80(void)
+static int __init cf_check check_port80(void)
 {
     /*
      * Quirk table for systems that misbehave (lock up, etc.) if port
diff --git a/xen/arch/x86/include/asm/hvm/save.h b/xen/arch/x86/include/asm/hvm/save.h
index 4efc53505500..e975011ddb71 100644
--- a/xen/arch/x86/include/asm/hvm/save.h
+++ b/xen/arch/x86/include/asm/hvm/save.h
@@ -115,7 +115,7 @@ void hvm_register_savevm(uint16_t typecode,
 /* Syntactic sugar around that function: specify the max number of
  * saves, and this calculates the size of buffer needed */
 #define HVM_REGISTER_SAVE_RESTORE(_x, _save, _load, _num, _k)             \
-static int __init __hvm_register_##_x##_save_and_restore(void)            \
+static int __init cf_check __hvm_register_##_x##_save_and_restore(void)   \
 {                                                                         \
     hvm_register_savevm(HVM_SAVE_CODE(_x),                                \
                         #_x,                                              \
diff --git a/xen/arch/x86/ioport_emulate.c b/xen/arch/x86/ioport_emulate.c
index cf1f3f922959..6caeb3d470ce 100644
--- a/xen/arch/x86/ioport_emulate.c
+++ b/xen/arch/x86/ioport_emulate.c
@@ -11,7 +11,7 @@
 unsigned int (*__read_mostly ioemul_handle_quirk)(
     uint8_t opcode, char *io_emul_stub, struct cpu_user_regs *regs);
 
-static unsigned int ioemul_handle_proliant_quirk(
+static unsigned int cf_check ioemul_handle_proliant_quirk(
     u8 opcode, char *io_emul_stub, struct cpu_user_regs *regs)
 {
     static const char stub[] = {
@@ -100,7 +100,7 @@ static const struct dmi_system_id __initconstrel ioport_quirks_tbl[] = {
     { }
 };
 
-static int __init ioport_quirks_init(void)
+static int __init cf_check ioport_quirks_init(void)
 {
     if ( dmi_check_system(ioport_quirks_tbl) )
         ioemul_handle_quirk = ioemul_handle_proliant_quirk;
diff --git a/xen/arch/x86/irq.c b/xen/arch/x86/irq.c
index 84b174d0f51f..bcf46cd54d16 100644
--- a/xen/arch/x86/irq.c
+++ b/xen/arch/x86/irq.c
@@ -954,7 +954,7 @@ static void irq_ratelimit_timer_fn(void *data)
     spin_unlock_irqrestore(&irq_ratelimit_lock, flags);
 }
 
-static int __init irq_ratelimit_init(void)
+static int __init cf_check irq_ratelimit_init(void)
 {
     if ( irq_ratelimit_threshold )
         init_timer(&irq_ratelimit_timer, irq_ratelimit_timer_fn, NULL, 0);
@@ -2504,7 +2504,7 @@ static void dump_irqs(unsigned char key)
     dump_ioapic_irq_info();
 }
 
-static int __init setup_dump_irqs(void)
+static int __init cf_check setup_dump_irqs(void)
 {
     /* In lieu of being able to live in init_irq_data(). */
     BUILD_BUG_ON(sizeof(irq_max_guests) >
diff --git a/xen/arch/x86/mm/shadow/common.c b/xen/arch/x86/mm/shadow/common.c
index 6221630fc2dc..b8730a9441ce 100644
--- a/xen/arch/x86/mm/shadow/common.c
+++ b/xen/arch/x86/mm/shadow/common.c
@@ -105,7 +105,7 @@ static void shadow_audit_key(unsigned char key)
            __func__, shadow_audit_enable);
 }
 
-static int __init shadow_audit_key_init(void)
+static int __init cf_check shadow_audit_key_init(void)
 {
     register_keyhandler('O', shadow_audit_key, "toggle shadow audits", 0);
     return 0;
@@ -1057,7 +1057,7 @@ static void shadow_blow_all_tables(unsigned char c)
 }
 
 /* Register this function in the Xen console keypress table */
-static __init int shadow_blow_tables_keyhandler_init(void)
+static int __init cf_check shadow_blow_tables_keyhandler_init(void)
 {
     register_keyhandler('S', shadow_blow_all_tables, "reset shadow pagetables", 1);
     return 0;
diff --git a/xen/arch/x86/msi.c b/xen/arch/x86/msi.c
index 5febc0ea4b7c..d1497254b188 100644
--- a/xen/arch/x86/msi.c
+++ b/xen/arch/x86/msi.c
@@ -1485,7 +1485,7 @@ static void dump_msi(unsigned char key)
     vpci_dump_msi();
 }
 
-static int __init msi_setup_keyhandler(void)
+static int __init cf_check msi_setup_keyhandler(void)
 {
     register_keyhandler('M', dump_msi, "dump MSI state", 1);
     return 0;
diff --git a/xen/arch/x86/nmi.c b/xen/arch/x86/nmi.c
index 1a225d499295..21e947a46f24 100644
--- a/xen/arch/x86/nmi.c
+++ b/xen/arch/x86/nmi.c
@@ -606,7 +606,7 @@ static void do_nmi_stats(unsigned char key)
         printk("%pv: NMI neither pending nor masked\n", v);
 }
 
-static __init int register_nmi_trigger(void)
+static int __init cf_check register_nmi_trigger(void)
 {
     register_keyhandler('N', do_nmi_trigger, "trigger an NMI", 0);
     register_keyhandler('n', do_nmi_stats, "NMI statistics", 1);
diff --git a/xen/arch/x86/numa.c b/xen/arch/x86/numa.c
index 6be5a0c93322..5de9db4e9943 100644
--- a/xen/arch/x86/numa.c
+++ b/xen/arch/x86/numa.c
@@ -504,7 +504,7 @@ static void dump_numa(unsigned char key)
     rcu_read_unlock(&domlist_read_lock);
 }
 
-static __init int register_numa_trigger(void)
+static int __init cf_check register_numa_trigger(void)
 {
     register_keyhandler('u', dump_numa, "dump NUMA info", 1);
     return 0;
diff --git a/xen/arch/x86/oprofile/nmi_int.c b/xen/arch/x86/oprofile/nmi_int.c
index 7842d95b95ea..ba9c4b9804ca 100644
--- a/xen/arch/x86/oprofile/nmi_int.c
+++ b/xen/arch/x86/oprofile/nmi_int.c
@@ -388,7 +388,7 @@ static int __init arch_perfmon_init(char **cpu_type)
 	return 1;
 }
 
-static int __init nmi_init(void)
+static int __init cf_check nmi_init(void)
 {
 	__u8 vendor = current_cpu_data.x86_vendor;
 	__u8 family = current_cpu_data.x86;
diff --git a/xen/arch/x86/percpu.c b/xen/arch/x86/percpu.c
index 5ea14b6ec312..0e0b6577ca45 100644
--- a/xen/arch/x86/percpu.c
+++ b/xen/arch/x86/percpu.c
@@ -94,7 +94,7 @@ static struct notifier_block cpu_percpu_nfb = {
     .priority = 100 /* highest priority */
 };
 
-static int __init percpu_presmp_init(void)
+static int __init cf_check percpu_presmp_init(void)
 {
     register_cpu_notifier(&cpu_percpu_nfb);
 
diff --git a/xen/arch/x86/psr.c b/xen/arch/x86/psr.c
index 56916344cb1d..9a3670afc341 100644
--- a/xen/arch/x86/psr.c
+++ b/xen/arch/x86/psr.c
@@ -1675,7 +1675,7 @@ static struct notifier_block cpu_nfb = {
     .priority = -1
 };
 
-static int __init psr_presmp_init(void)
+static int __init cf_check psr_presmp_init(void)
 {
     if ( (opt_psr & PSR_CMT) && opt_rmid_max )
         init_psr_cmt(opt_rmid_max);
diff --git a/xen/arch/x86/pv/domain.c b/xen/arch/x86/pv/domain.c
index 125c4561a7ea..55146c15c853 100644
--- a/xen/arch/x86/pv/domain.c
+++ b/xen/arch/x86/pv/domain.c
@@ -167,7 +167,7 @@ unsigned long pv_fixup_guest_cr4(const struct vcpu *v, unsigned long cr4)
 static int8_t __read_mostly opt_global_pages = -1;
 boolean_runtime_param("global-pages", opt_global_pages);
 
-static int __init pge_init(void)
+static int __init cf_check pge_init(void)
 {
     if ( opt_global_pages == -1 )
         opt_global_pages = !cpu_has_hypervisor ||
diff --git a/xen/arch/x86/shutdown.c b/xen/arch/x86/shutdown.c
index a01354d93319..ad3e3a76916f 100644
--- a/xen/arch/x86/shutdown.c
+++ b/xen/arch/x86/shutdown.c
@@ -533,7 +533,7 @@ static const struct dmi_system_id __initconstrel reboot_dmi_table[] = {
     { }
 };
 
-static int __init reboot_init(void)
+static int __init cf_check reboot_init(void)
 {
     /*
      * Only do the DMI check if reboot_type hasn't been overridden
diff --git a/xen/arch/x86/time.c b/xen/arch/x86/time.c
index 2da9c7f5c8dd..14f7d3fd635e 100644
--- a/xen/arch/x86/time.c
+++ b/xen/arch/x86/time.c
@@ -537,7 +537,7 @@ static struct platform_timesource __initdata plt_pmtimer =
 
 static struct time_scale __read_mostly pmt_scale;
 
-static __init int init_pmtmr_scale(void)
+static __init int cf_check init_pmtmr_scale(void)
 {
     set_time_scale(&pmt_scale, ACPI_PM_FREQUENCY);
     return 0;
@@ -2052,7 +2052,7 @@ static void __init try_platform_timer_tail(void)
 }
 
 /* Late init function, after all cpus have booted */
-static int __init verify_tsc_reliability(void)
+static int __init cf_check verify_tsc_reliability(void)
 {
     if ( boot_cpu_has(X86_FEATURE_TSC_RELIABLE) )
     {
@@ -2223,7 +2223,7 @@ static int _disable_pit_irq(void(*hpet_broadcast_setup)(void))
     return ret;
 }
 
-static int __init disable_pit_irq(void)
+static int __init cf_check disable_pit_irq(void)
 {
     if ( !_disable_pit_irq(hpet_broadcast_init) )
     {
@@ -2586,7 +2586,7 @@ static void dump_softtsc(unsigned char key)
             printk("No domains have emulated TSC\n");
 }
 
-static int __init setup_dump_softtsc(void)
+static int __init cf_check setup_dump_softtsc(void)
 {
     register_keyhandler('s', dump_softtsc, "dump softtsc stats", 1);
     return 0;
diff --git a/xen/common/core_parking.c b/xen/common/core_parking.c
index aa432ed2f57b..44a907abfd7f 100644
--- a/xen/common/core_parking.c
+++ b/xen/common/core_parking.c
@@ -258,7 +258,7 @@ static int __init register_core_parking_policy(const struct cp_policy *policy)
     return 0;
 }
 
-static int __init core_parking_init(void)
+static int __init cf_check core_parking_init(void)
 {
     int ret = 0;
 
diff --git a/xen/common/debugtrace.c b/xen/common/debugtrace.c
index 29b11239f5a5..f3c0fd8aa17b 100644
--- a/xen/common/debugtrace.c
+++ b/xen/common/debugtrace.c
@@ -279,7 +279,7 @@ static struct notifier_block debugtrace_nfb = {
     .notifier_call = debugtrace_cpu_callback
 };
 
-static int __init debugtrace_init(void)
+static int __init cf_check debugtrace_init(void)
 {
     unsigned int cpu;
 
diff --git a/xen/common/event_channel.c b/xen/common/event_channel.c
index a5ee8b8ebf76..2026bc30dc95 100644
--- a/xen/common/event_channel.c
+++ b/xen/common/event_channel.c
@@ -1642,7 +1642,7 @@ static void dump_evtchn_info(unsigned char key)
     rcu_read_unlock(&domlist_read_lock);
 }
 
-static int __init dump_evtchn_info_key_init(void)
+static int __init cf_check dump_evtchn_info_key_init(void)
 {
     register_keyhandler('e', dump_evtchn_info, "dump evtchn info", 1);
     return 0;
diff --git a/xen/common/gdbstub.c b/xen/common/gdbstub.c
index 848c1f4327e8..99bfd9a654c9 100644
--- a/xen/common/gdbstub.c
+++ b/xen/common/gdbstub.c
@@ -640,7 +640,7 @@ __trap_to_gdb(struct cpu_user_regs *regs, unsigned long cookie)
     return rc;
 }
 
-static int __init initialise_gdb(void)
+static int __init cf_check initialise_gdb(void)
 {
     if ( *opt_gdb == '\0' )
         return 0;
diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c
index b663845d9c6c..1078e3e16cda 100644
--- a/xen/common/grant_table.c
+++ b/xen/common/grant_table.c
@@ -4291,7 +4291,7 @@ static void gnttab_usage_print_all(unsigned char key)
     printk("%s ] done\n", __func__);
 }
 
-static int __init gnttab_usage_init(void)
+static int __init cf_check gnttab_usage_init(void)
 {
     register_keyhandler('g', gnttab_usage_print_all,
                         "print grant table usage", 1);
diff --git a/xen/common/kernel.c b/xen/common/kernel.c
index 752c2e0dae44..adff2d2c77f3 100644
--- a/xen/common/kernel.c
+++ b/xen/common/kernel.c
@@ -393,7 +393,7 @@ static HYPFS_STRING_INIT(extra, "extra");
 static HYPFS_STRING_INIT(config, "config");
 #endif
 
-static int __init buildinfo_init(void)
+static int __init cf_check buildinfo_init(void)
 {
     hypfs_add_dir(&hypfs_root, &buildinfo, true);
 
@@ -431,7 +431,7 @@ __initcall(buildinfo_init);
 
 static HYPFS_DIR_INIT(params, "params");
 
-static int __init param_init(void)
+static int __init cf_check param_init(void)
 {
     struct param_hypfs *param;
 
diff --git a/xen/common/kexec.c b/xen/common/kexec.c
index 6286c0bbf08b..36384f782db3 100644
--- a/xen/common/kexec.c
+++ b/xen/common/kexec.c
@@ -570,7 +570,7 @@ void __init kexec_early_calculations(void)
         crashinfo_maxaddr_bits = fls64(crashinfo_maxaddr) - 1;
 }
 
-static int __init kexec_init(void)
+static int __init cf_check kexec_init(void)
 {
     void *cpu = (void *)(unsigned long)smp_processor_id();
 
diff --git a/xen/common/livepatch.c b/xen/common/livepatch.c
index 7118551b27e2..33708b4e2388 100644
--- a/xen/common/livepatch.c
+++ b/xen/common/livepatch.c
@@ -2139,7 +2139,7 @@ static struct notifier_block cpu_nfb = {
     .notifier_call = cpu_callback
 };
 
-static int __init livepatch_init(void)
+static int __init cf_check livepatch_init(void)
 {
     unsigned int cpu;
 
diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c
index ad06655158d2..561e238d2d6a 100644
--- a/xen/common/page_alloc.c
+++ b/xen/common/page_alloc.c
@@ -2549,7 +2549,7 @@ static void pagealloc_info(unsigned char key)
     printk("    Dom heap: %lukB free\n", total << (PAGE_SHIFT-10));
 }
 
-static __init int pagealloc_keyhandler_init(void)
+static __init int cf_check pagealloc_keyhandler_init(void)
 {
     register_keyhandler('m', pagealloc_info, "memory info", 1);
     return 0;
@@ -2597,7 +2597,7 @@ static void dump_heap(unsigned char key)
     }
 }
 
-static __init int register_heap_trigger(void)
+static __init int cf_check register_heap_trigger(void)
 {
     register_keyhandler('H', dump_heap, "dump heap info", 1);
     return 0;
diff --git a/xen/common/radix-tree.c b/xen/common/radix-tree.c
index 2384655a2e90..628a7e06988f 100644
--- a/xen/common/radix-tree.c
+++ b/xen/common/radix-tree.c
@@ -744,7 +744,7 @@ static __init unsigned long __maxindex(unsigned int height)
 	return ~0UL >> shift;
 }
 
-static __init int radix_tree_init_maxindex(void)
+static int __init cf_check radix_tree_init_maxindex(void)
 {
 	unsigned int i;
 
diff --git a/xen/common/random.c b/xen/common/random.c
index fb805b0ecd95..a29f2fcb991a 100644
--- a/xen/common/random.c
+++ b/xen/common/random.c
@@ -31,7 +31,7 @@ unsigned int get_random(void)
     return val;
 }
 
-static int __init init_boot_random(void)
+static int __init cf_check init_boot_random(void)
 {
     boot_random = get_random();
     return 0;
diff --git a/xen/common/sched/cpupool.c b/xen/common/sched/cpupool.c
index f0dd626054a6..f26c7f289539 100644
--- a/xen/common/sched/cpupool.c
+++ b/xen/common/sched/cpupool.c
@@ -1218,7 +1218,7 @@ static void cpupool_hypfs_init(void)
 
 #endif /* CONFIG_HYPFS */
 
-static int __init cpupool_init(void)
+static int __init cf_check cpupool_init(void)
 {
     unsigned int cpu;
 
diff --git a/xen/common/spinlock.c b/xen/common/spinlock.c
index b90981bb271e..5ce7e3363863 100644
--- a/xen/common/spinlock.c
+++ b/xen/common/spinlock.c
@@ -508,7 +508,7 @@ void _lock_profile_deregister_struct(
     spin_unlock(&lock_profile_lock);
 }
 
-static int __init lock_prof_init(void)
+static int __init cf_check lock_prof_init(void)
 {
     struct lock_profile **q;
 
diff --git a/xen/common/stop_machine.c b/xen/common/stop_machine.c
index 2d5f6aef61ed..8979d553d677 100644
--- a/xen/common/stop_machine.c
+++ b/xen/common/stop_machine.c
@@ -198,7 +198,7 @@ static struct notifier_block cpu_nfb = {
     .notifier_call = cpu_callback
 };
 
-static int __init cpu_stopmachine_init(void)
+static int __init cf_check cpu_stopmachine_init(void)
 {
     unsigned int cpu;
     for_each_online_cpu ( cpu )
diff --git a/xen/drivers/cpufreq/cpufreq.c b/xen/drivers/cpufreq/cpufreq.c
index 36b079296235..e55e202d5a18 100644
--- a/xen/drivers/cpufreq/cpufreq.c
+++ b/xen/drivers/cpufreq/cpufreq.c
@@ -657,7 +657,7 @@ static struct notifier_block cpu_nfb = {
     .notifier_call = cpu_callback
 };
 
-static int __init cpufreq_presmp_init(void)
+static int __init cf_check cpufreq_presmp_init(void)
 {
     register_cpu_notifier(&cpu_nfb);
     return 0;
diff --git a/xen/drivers/cpufreq/cpufreq_misc_governors.c b/xen/drivers/cpufreq/cpufreq_misc_governors.c
index 746bbcd5ff36..8343f491da87 100644
--- a/xen/drivers/cpufreq/cpufreq_misc_governors.c
+++ b/xen/drivers/cpufreq/cpufreq_misc_governors.c
@@ -116,7 +116,7 @@ struct cpufreq_governor cpufreq_gov_userspace = {
     .handle_option = cpufreq_userspace_handle_option
 };
 
-static int __init cpufreq_gov_userspace_init(void)
+static int __init cf_check cpufreq_gov_userspace_init(void)
 {
     unsigned int cpu;
 
@@ -160,7 +160,7 @@ struct cpufreq_governor cpufreq_gov_performance = {
     .governor = cpufreq_governor_performance,
 };
 
-static int __init cpufreq_gov_performance_init(void)
+static int __init cf_check cpufreq_gov_performance_init(void)
 {
     return cpufreq_register_governor(&cpufreq_gov_performance);
 }
@@ -199,7 +199,7 @@ struct cpufreq_governor cpufreq_gov_powersave = {
     .governor = cpufreq_governor_powersave,
 };
 
-static int __init cpufreq_gov_powersave_init(void)
+static int __init cf_check cpufreq_gov_powersave_init(void)
 {
     return cpufreq_register_governor(&cpufreq_gov_powersave);
 }
diff --git a/xen/drivers/cpufreq/cpufreq_ondemand.c b/xen/drivers/cpufreq/cpufreq_ondemand.c
index 6b905d7cfca8..cabd9ffa8886 100644
--- a/xen/drivers/cpufreq/cpufreq_ondemand.c
+++ b/xen/drivers/cpufreq/cpufreq_ondemand.c
@@ -356,7 +356,7 @@ struct cpufreq_governor cpufreq_gov_dbs = {
     .handle_option = cpufreq_dbs_handle_option
 };
 
-static int __init cpufreq_gov_dbs_init(void)
+static int __init cf_check cpufreq_gov_dbs_init(void)
 {
     return cpufreq_register_governor(&cpufreq_gov_dbs);
 }
diff --git a/xen/drivers/passthrough/amd/iommu.h b/xen/drivers/passthrough/amd/iommu.h
index 93243424e85d..04517c1a024c 100644
--- a/xen/drivers/passthrough/amd/iommu.h
+++ b/xen/drivers/passthrough/amd/iommu.h
@@ -234,7 +234,7 @@ int amd_iommu_prepare(bool xt);
 int amd_iommu_init(bool xt);
 int amd_iommu_init_late(void);
 int amd_iommu_update_ivrs_mapping_acpi(void);
-int iov_adjust_irq_affinities(void);
+int cf_check iov_adjust_irq_affinities(void);
 
 int amd_iommu_quarantine_init(struct domain *d);
 
diff --git a/xen/drivers/passthrough/amd/iommu_init.c b/xen/drivers/passthrough/amd/iommu_init.c
index 559a734bdaa5..f1ed75558227 100644
--- a/xen/drivers/passthrough/amd/iommu_init.c
+++ b/xen/drivers/passthrough/amd/iommu_init.c
@@ -808,7 +808,7 @@ static bool_t __init set_iommu_interrupt_handler(struct amd_iommu *iommu)
     return 1;
 }
 
-int iov_adjust_irq_affinities(void)
+int cf_check iov_adjust_irq_affinities(void)
 {
     const struct amd_iommu *iommu;
 
diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
index 20cb246598b1..ed459f6409a8 100644
--- a/xen/drivers/passthrough/pci.c
+++ b/xen/drivers/passthrough/pci.c
@@ -1358,7 +1358,7 @@ static void dump_pci_devices(unsigned char ch)
     pcidevs_unlock();
 }
 
-static int __init setup_dump_pcidevs(void)
+static int __init cf_check setup_dump_pcidevs(void)
 {
     register_keyhandler('Q', dump_pci_devices, "dump PCI devices", 1);
     return 0;
diff --git a/xen/drivers/passthrough/vtd/iommu.c b/xen/drivers/passthrough/vtd/iommu.c
index 34ea5f485de7..9e85016830bf 100644
--- a/xen/drivers/passthrough/vtd/iommu.c
+++ b/xen/drivers/passthrough/vtd/iommu.c
@@ -2154,7 +2154,7 @@ static void adjust_irq_affinity(struct acpi_drhd_unit *drhd)
     spin_unlock_irqrestore(&desc->lock, flags);
 }
 
-static int adjust_vtd_irq_affinities(void)
+static int cf_check adjust_vtd_irq_affinities(void)
 {
     struct acpi_drhd_unit *drhd;
 
diff --git a/xen/drivers/passthrough/x86/hvm.c b/xen/drivers/passthrough/x86/hvm.c
index 0b37cd145b60..e5a2c5830348 100644
--- a/xen/drivers/passthrough/x86/hvm.c
+++ b/xen/drivers/passthrough/x86/hvm.c
@@ -1076,7 +1076,7 @@ static struct notifier_block cpu_nfb = {
     .notifier_call = cpu_callback,
 };
 
-static int __init setup_dpci_softirq(void)
+static int __init cf_check setup_dpci_softirq(void)
 {
     unsigned int cpu;
 
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:06:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:06:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271707.466336 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb3W-0007Js-Pa; Mon, 14 Feb 2022 13:06:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271707.466336; Mon, 14 Feb 2022 13:06:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb3W-0007IL-AW; Mon, 14 Feb 2022 13:06:14 +0000
Received: by outflank-mailman (input) for mailman id 271707;
 Mon, 14 Feb 2022 13:06:12 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJb3D-0008IH-Cm
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:05:55 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d730742f-8d96-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 14:05:53 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d730742f-8d96-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644843953;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=6nZ3O0wdLsQ8m8lXwVCWVEgPWujRaX5DsONJatSODKA=;
  b=G9ZJpayqO9bP82hoaP0FhIAwhSLDB5uKXAieVBXZm7zOHef4mzK1qcTw
   oJVASdUoWjm3dCI1ytz2mgoToabfmS+KTXPkaxVd9ftJquU+QP7LUQR26
   cuLX2E6oSpOSbqgD1mIAUB1Cs1EzlkzrDbhtyHoA3XEJc481YXRmWsPdW
   s=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: GQTUxjXdtz64efFHYVYqhkT4VKeUQpZMdJCuq4Sb/IRQJEhcxYbZOMG5zuSpK645tT5EPt4UUR
 h5HMv3hPz+8PdBFGIRSI9kt7ds36n3JCKgmzfC74Q5jjjwe0pSYJ8koiTnWj2fD5k7uaM8Roy0
 I2C6maIxHplB5oayzM4Dx57jP9AreX1BodhVgNKItg7KwvhlhtEGXBm5CYlvuBYVPj4v86s3cE
 sSBnEXysYO/P8DnHqxw+6TKbYWCV/j1VYU7HdbSl0MFi2BO6IRfUaWxE3rbMB9QEzMkdv7MfGR
 tC/lcu5OYTWxui7SX00mD8iC
X-SBRS: 5.1
X-MesageID: 66374919
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:vmvu3ajx16L7aG6g1ayRceUaX161fhcKZh0ujC45NGQN5FlHY01je
 htvUT/Sb/2CazeneNslPo+/o04AvpbQy99jSwVqqXtmRXwb9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oAMKRCQ7InQLlbGILes1htZGEk0GE/NtTo5w7Rj2tQx3YDga++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /12kpCxcwVwM5TCs+EcUERSSRg5MPdZreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHCOo8Ft24m5jbeFfs8GrjIQrnQ5M8e1zA17ixLNaiAP
 JVFOGM+BPjGSzsTfVkIFYo7oN6LqGWgaiRVrFOQjpNitgA/yyQuieOwYbI5YOeiVchT20qVu
 G/C12D4GQ0BcsySzyKf9XChjfOJmjn0ML/+D5XhqKQs2gfKgDVOVltGDjNXvMVVlGaFfN5eE
 U5N9xMghq0z9xGhFOC6Uken9SvsUgEnZ/JcFOgz6Qeow6XS4hqECmVscgOteODKp+dtG2V0i
 wbhc8fBQGU27ebLES71GqK88GvqURX5O1PucsPtoeEtx9D46L8+gRvUJjqIOP7k14alcd0cL
 t3jkcTfu1nxpZNRv0lY1Qqe695JmnQuZlRrjjg7pkr/smtEiHeNPuREE2Tz4/daN5q+RVKcp
 nUCkMX2xLlQUc3SxHzQHb1UR+vBCxO53Nr02wAHInXc3271py7LkX54vFmS23uFwu5bIGS0M
 Sc/SCta5YNJPWvCUEOES9nZNije9oC5TY6NfqmNNrJmO8EtHCfarHAGTRPBhAjFzRlz+ZzTz
 L/GKK5A+15BUv85pNd3Ls9AuYIWKtcWmz+CG8Cjl07/uVdcDVbMIYo43JK1RrhRxMu5TM/9q
 r6z7uOGlEdSVvPQeC7S/dJBJFwGNyFjV5v3t9ZWZqiIJQ8/QDMtDPrYwLUAfY15nvsKyreUr
 y/lAkIImkDigXDnKBmRbiwxYr3YQpsi/2kwOjYhPAj01iF7M5qv9qoWa7A+YaIjqL541fdxQ
 vRcI5eAD/1DRy7p4TMYaZWh/oVueA7y3VCFPja/YSh5dJllHlSb9tjhdwrp1S8PEivo6pdu/
 +z+jlvWGMNRSR5jAcDabOOU42mw5XVNyvhvW0boI8VIfBm++oZdNCGs3OQ8JNsBKEufy2LCh
 RqWGxoRucLEv5QxrIvSnamBooqkT7l+E05dEzWJ5Lq6L3CHrG+qwIsGW+eUZzHNEmjz/fz6N
 +lSyvj9NtwBnUpL7NUgQ+o6k/pm6ou9vaJewyRlAG7PPgaiBb5XK3Wb2dVC6/9WzbhDtArqA
 k+C97G241lS1B8JxLLJGDcYUw==
IronPort-HdrOrdr: A9a23:2JFdqKOAtl1h+8BcTsWjsMiBIKoaSvp037Eqv3oRdfU1SL3hqy
 nApoV56faZslkssTQb6LS90cq7MArhHPxOkOss1N6ZNWGM0gbFEGgh1/qE/9SJIVyZygc378
 ddmsZFZuEYdWIK6PrH3A==
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="66374919"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v2 58/70] x86/stack: CFI hardening
Date: Mon, 14 Feb 2022 12:51:15 +0000
Message-ID: <20220214125127.17985-59-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

Control Flow Integrity schemes use toolchain and optionally hardware support
to help protect against call/jump/return oriented programming attacks.

Use cf_check to annotate function pointer targets for the toolchain.

The function typecheck in switch_stack_and_jump() is incompatible with control
flow typechecking.  It's ok for reset_stack_and_jump_ind(), but for
reset_stack_and_jump(), it would force us to ENDBR64 the targets which are
branched to directly.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---

v2:
 * Extend reset_stack_and_jump_ind() with ({ })
---
 xen/arch/x86/domain.c                  | 6 +++---
 xen/arch/x86/hvm/svm/svm.c             | 6 +++---
 xen/arch/x86/hvm/vmx/vmcs.c            | 2 +-
 xen/arch/x86/hvm/vmx/vmx.c             | 8 ++++----
 xen/arch/x86/include/asm/current.h     | 6 ++++--
 xen/arch/x86/include/asm/hvm/vmx/vmx.h | 2 +-
 xen/arch/x86/include/asm/pv/domain.h   | 4 ++--
 xen/arch/x86/pv/domain.c               | 2 +-
 xen/arch/x86/x86_64/entry.S            | 1 +
 9 files changed, 20 insertions(+), 17 deletions(-)

diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c
index ae7c88b51af1..afccc1525f8b 100644
--- a/xen/arch/x86/domain.c
+++ b/xen/arch/x86/domain.c
@@ -132,7 +132,7 @@ void play_dead(void)
         dead_idle();
 }
 
-static void noreturn idle_loop(void)
+static void noreturn cf_check idle_loop(void)
 {
     unsigned int cpu = smp_processor_id();
     /*
@@ -1790,7 +1790,7 @@ static void save_segments(struct vcpu *v)
     }
 }
 
-void paravirt_ctxt_switch_from(struct vcpu *v)
+void cf_check paravirt_ctxt_switch_from(struct vcpu *v)
 {
     save_segments(v);
 
@@ -1804,7 +1804,7 @@ void paravirt_ctxt_switch_from(struct vcpu *v)
         write_debugreg(7, 0);
 }
 
-void paravirt_ctxt_switch_to(struct vcpu *v)
+void cf_check paravirt_ctxt_switch_to(struct vcpu *v)
 {
     root_pgentry_t *root_pgt = this_cpu(root_pgt);
 
diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c
index dedb2848e6a1..63535a74b504 100644
--- a/xen/arch/x86/hvm/svm/svm.c
+++ b/xen/arch/x86/hvm/svm/svm.c
@@ -944,7 +944,7 @@ static inline void svm_tsc_ratio_load(struct vcpu *v)
         wrmsrl(MSR_AMD64_TSC_RATIO, hvm_tsc_scaling_ratio(v->domain));
 }
 
-static void svm_ctxt_switch_from(struct vcpu *v)
+static void cf_check svm_ctxt_switch_from(struct vcpu *v)
 {
     int cpu = smp_processor_id();
 
@@ -969,7 +969,7 @@ static void svm_ctxt_switch_from(struct vcpu *v)
     enable_each_ist(idt_tables[cpu]);
 }
 
-static void svm_ctxt_switch_to(struct vcpu *v)
+static void cf_check svm_ctxt_switch_to(struct vcpu *v)
 {
     struct vmcb_struct *vmcb = v->arch.hvm.svm.vmcb;
     int cpu = smp_processor_id();
@@ -996,7 +996,7 @@ static void svm_ctxt_switch_to(struct vcpu *v)
         wrmsr_tsc_aux(v->arch.msrs->tsc_aux);
 }
 
-static void noreturn svm_do_resume(void)
+static void noreturn cf_check svm_do_resume(void)
 {
     struct vcpu *v = current;
     struct vmcb_struct *vmcb = v->arch.hvm.svm.vmcb;
diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c
index 60b506ac3f40..e1e1fa14e65e 100644
--- a/xen/arch/x86/hvm/vmx/vmcs.c
+++ b/xen/arch/x86/hvm/vmx/vmcs.c
@@ -1865,7 +1865,7 @@ void vmx_vmentry_failure(void)
 
 void noreturn vmx_asm_do_vmentry(void);
 
-void vmx_do_resume(void)
+void cf_check vmx_do_resume(void)
 {
     struct vcpu *v = current;
     bool_t debug_state;
diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c
index 2c4804f9b884..41db538a9e3d 100644
--- a/xen/arch/x86/hvm/vmx/vmx.c
+++ b/xen/arch/x86/hvm/vmx/vmx.c
@@ -63,8 +63,8 @@
 static bool_t __initdata opt_force_ept;
 boolean_param("force-ept", opt_force_ept);
 
-static void vmx_ctxt_switch_from(struct vcpu *v);
-static void vmx_ctxt_switch_to(struct vcpu *v);
+static void cf_check vmx_ctxt_switch_from(struct vcpu *v);
+static void cf_check vmx_ctxt_switch_to(struct vcpu *v);
 
 static int alloc_vlapic_mapping(void);
 static void vmx_install_vlapic_mapping(struct vcpu *v);
@@ -907,7 +907,7 @@ static void cf_check vmx_fpu_leave(struct vcpu *v)
     }
 }
 
-static void vmx_ctxt_switch_from(struct vcpu *v)
+static void cf_check vmx_ctxt_switch_from(struct vcpu *v)
 {
     /*
      * Return early if trying to do a context switch without VMX enabled,
@@ -939,7 +939,7 @@ static void vmx_ctxt_switch_from(struct vcpu *v)
         vmx_pi_switch_from(v);
 }
 
-static void vmx_ctxt_switch_to(struct vcpu *v)
+static void cf_check vmx_ctxt_switch_to(struct vcpu *v)
 {
     vmx_restore_guest_msrs(v);
     vmx_restore_dr(v);
diff --git a/xen/arch/x86/include/asm/current.h b/xen/arch/x86/include/asm/current.h
index dc0edd9ed07d..da5e152a10cc 100644
--- a/xen/arch/x86/include/asm/current.h
+++ b/xen/arch/x86/include/asm/current.h
@@ -173,7 +173,6 @@ unsigned long get_stack_dump_bottom (unsigned long sp);
 #define switch_stack_and_jump(fn, instr, constr)                        \
     ({                                                                  \
         unsigned int tmp;                                               \
-        (void)((fn) == (void (*)(void))NULL);                           \
         BUILD_BUG_ON(!ssaj_has_attr_noreturn(fn));                      \
         __asm__ __volatile__ (                                          \
             SHADOW_STACK_WORK                                           \
@@ -198,7 +197,10 @@ unsigned long get_stack_dump_bottom (unsigned long sp);
 
 /* The constraint may only specify non-call-clobbered registers. */
 #define reset_stack_and_jump_ind(fn)                                    \
-    switch_stack_and_jump(fn, "INDIRECT_JMP %", "b")
+    ({                                                                  \
+        (void)((fn) == (void (*)(void))NULL);                           \
+        switch_stack_and_jump(fn, "INDIRECT_JMP %", "b");               \
+    })
 
 /*
  * Which VCPU's state is currently running on each CPU?
diff --git a/xen/arch/x86/include/asm/hvm/vmx/vmx.h b/xen/arch/x86/include/asm/hvm/vmx/vmx.h
index 5284fe931f62..c2ebdd6864a5 100644
--- a/xen/arch/x86/include/asm/hvm/vmx/vmx.h
+++ b/xen/arch/x86/include/asm/hvm/vmx/vmx.h
@@ -93,7 +93,7 @@ typedef enum {
 
 void vmx_asm_vmexit_handler(struct cpu_user_regs);
 void vmx_intr_assist(void);
-void noreturn vmx_do_resume(void);
+void noreturn cf_check vmx_do_resume(void);
 void vmx_vlapic_msr_changed(struct vcpu *v);
 struct hvm_emulate_ctxt;
 void vmx_realmode_emulate_one(struct hvm_emulate_ctxt *hvmemul_ctxt);
diff --git a/xen/arch/x86/include/asm/pv/domain.h b/xen/arch/x86/include/asm/pv/domain.h
index 6b16da9d187b..924508bbb4f0 100644
--- a/xen/arch/x86/include/asm/pv/domain.h
+++ b/xen/arch/x86/include/asm/pv/domain.h
@@ -118,8 +118,8 @@ static inline void pv_set_reg(struct vcpu *v, unsigned int reg, uint64_t val)
 
 #endif	/* CONFIG_PV */
 
-void paravirt_ctxt_switch_from(struct vcpu *v);
-void paravirt_ctxt_switch_to(struct vcpu *v);
+void cf_check paravirt_ctxt_switch_from(struct vcpu *v);
+void cf_check paravirt_ctxt_switch_to(struct vcpu *v);
 
 #endif	/* __X86_PV_DOMAIN_H__ */
 
diff --git a/xen/arch/x86/pv/domain.c b/xen/arch/x86/pv/domain.c
index 55146c15c853..f94f28c8e271 100644
--- a/xen/arch/x86/pv/domain.c
+++ b/xen/arch/x86/pv/domain.c
@@ -351,7 +351,7 @@ void pv_domain_destroy(struct domain *d)
     FREE_XENHEAP_PAGE(d->arch.pv.gdt_ldt_l1tab);
 }
 
-void noreturn continue_pv_domain(void);
+void noreturn cf_check continue_pv_domain(void);
 
 int pv_domain_initialise(struct domain *d)
 {
diff --git a/xen/arch/x86/x86_64/entry.S b/xen/arch/x86/x86_64/entry.S
index 3eaf0e67b2b9..8494b97a54a2 100644
--- a/xen/arch/x86/x86_64/entry.S
+++ b/xen/arch/x86/x86_64/entry.S
@@ -625,6 +625,7 @@ ENTRY(dom_crash_sync_extable)
 /* No special register assumptions. */
 #ifdef CONFIG_PV
 ENTRY(continue_pv_domain)
+        ENDBR64
         call  check_wakeup_from_wait
 ret_from_intr:
         GET_CURRENT(bx)
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:06:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:06:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271708.466342 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb3X-0007SK-Db; Mon, 14 Feb 2022 13:06:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271708.466342; Mon, 14 Feb 2022 13:06:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb3W-0007Qn-TN; Mon, 14 Feb 2022 13:06:14 +0000
Received: by outflank-mailman (input) for mailman id 271708;
 Mon, 14 Feb 2022 13:06:12 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJb2i-00023t-OI
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:05:24 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c462146e-8d96-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 14:05:22 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c462146e-8d96-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644843923;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=bD8JK36vRGqRDSWFxaOE44j5YN40/rHS1DgBIOAI8XY=;
  b=Qi4Thg3sNKZGSa5toglCZzq0PTNWdHsNuRUIdLRJfOA/Mf4lELxzRoEr
   dGCXYrLb3pG4IrYr3Jj1EkCkxLqOvwZ0GQt4EUS9o0eBF2vQ2+3Yuf56S
   zrY35QhcLk2LYneEAQKV6zkSNTb8+t6/lM0VVsJmVytJMdsR9NdeMbzvz
   c=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: JVOdZys/aqxeJl7kRZqeuoSs2gZSKPJXjw27kX5woK0QSW0axl6G1Z3vIYYvJwiJEBAyN1z1s7
 FcFvA8NkPiS0vbBuXYDuvBAuFyrJEkWgU+3/WMs1nUegjsCLrG8oKCH3wH5IgX1mT4NdtwM7YA
 MmciR7r702RXFzCvU5oiipJlD796xb+s1TYESeumuw35BQ5YHz6zWkcWYPTZAeCEBNwvnAz1Js
 kJujOxX9IlYiiWnjhuMZMgE1c3kHLMx2SJ5maSxgz6U0kGPTm7xmb3MmGSk8biovM5aagWW4rK
 g5hBfjI3SOzQi8a0VtQr+9yo
X-SBRS: 5.1
X-MesageID: 64149402
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:JZd556CcLajG4RVW/zbkw5YqxClBgxIJ4kV8jS/XYbTApGhzhGAEx
 mZJC2GFa/7eNmDzfdAjbYXi/BsCu8DVmtUyQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMo/u1Si6FatANl1ElvU2zbue6WL6s1hxZH1c+En970E47wobVv6Yz6TSHK1LV0
 T/Ni5W31G+Ng1aY5UpNtspvADs21BjDkGtwUm4WPJinj3eH/5UhN7oNJLnZEpfNatI88thW5
 Qr05OrREmvxp3/BAz4++1rxWhVirrX6ZWBihpfKMkQLb9crSiEai84G2PQghUh/khuYkf1uz
 8t0mcb3a0BzFfeLlbsvekwNe81+FfUuFL7vJHG+tYqYzlHccmuqyPJrZK00FdRGoKAtWzgIr
 KFGbmBWBvyAr7veLLaTY+9gnMk8auLsO5sSoCpIxjDFF/c2B5vERs0m4PcGgG5s15wWR54yY
 eIBaiJBchbGXidAZGgXGI8dh+ODjXXwJmgwRFW9+vNsvjm7IBZK+KjgNp/Zd8KHQe1Rn12Ev
 STW8mLhGBYYOdeDjz2f/RqRavTnxH2hHthITfvhq6As0Ab7KnEv5AM+THWqr9SmjVCHd4gYC
 QtO0XBpoPcA3Rn+JjXiZCGQrHmBtx8aftNfFewm9Q2AopbpDxal6nssFWAYNoF/3CMibXlzj
 wLSwYu1bdB6mODNERqgGqGoQSRe0MT/BUsLfmc6QAQM+LEPS6lj30uUHr6P/ENY5+AZ+A0cI
 RjX9kDSZJ1J1KbnMplXGnid3VqRSmDhFFJd2+kudjvNAvlFTICkfZe0zlPQ8OxNKo2UJnHY4
 iRYxJjOsb1WVMrX/MBofAnqNOv3j8tpzRWG2QI/d3Xf32jFF4GfkXB4v2gleRYB3jcscj71e
 k7D0T69F7cIVEZGmZRfOtrrY+xzlPCIPY28Cpj8M4ofCrAsJVTv1Hw/OiatM5XFzRFEfVcXY
 szAL65BzB8yVMxa8dZBb7lBj+F7nH1irY4RLLiipymaPXOlTCb9Yd843JGmN4jVNYuI/1fY9
 chxLcyPx0kNWeHyeHCPo4USMUoLPT4wApWv855bceuKIwxHHmA9CqCOneN9KtI9x6kFxP3V+
 nydW1NDzAatj3PwNgjXOGtob6niXMgjoCtjbzAsJ1uhx1MqfZ2rsPUEb5IycLR+rL5jwPd4Q
 uMrYcKFBvgTGD3L9y5ENcv2rZB4dQTtjgWLZnL3bD86dp9mZgrI5t67IVe/qHhQVnK67JJsr
 aeh2wXXRYs4az5jVMuGOuiyy16RvGQGnL4gVUX/PdQOKl7n95JnKnKtg6Zvcd0MMxjK2hCTy
 x2SXUUDveDIroI4rIvJiKSDo9v7GudyBBMHTWzS7LLwPijG5Guzh4RHVb/QLzzaUWr1/oSkZ
 PlUkK6gYKFWwg4SvtouCatvwII/+8Dr9u1TwQlTFXnWa0imV+F7KX6c0MgT7qBAy9e1Y+dtt
 p5jLjWCBYi0BQ==
IronPort-HdrOrdr: A9a23:2yNHlqlU6HyoEtjAouvxbGok/2fpDfIu3DAbv31ZSRFFG/Fxl6
 iV8sjztCWE8Qr5N0tBpTntAsW9qDbnhPtICOoqTNGftWvdyQiVxehZhOOIqVDd8m/Fh4pgPM
 9bAs9D4bbLbGSS4/yU3ODBKadD/OW6
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="64149402"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v2 13/70] xen: CFI hardening for continue_hypercall_on_cpu()
Date: Mon, 14 Feb 2022 12:50:30 +0000
Message-ID: <20220214125127.17985-14-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

Control Flow Integrity schemes use toolchain and optionally hardware support
to help protect against call/jump/return oriented programming attacks.

Use cf_check to annotate function pointer targets for the toolchain.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
 xen/arch/x86/acpi/power.c          | 2 +-
 xen/arch/x86/cpu/microcode/core.c  | 2 +-
 xen/arch/x86/include/asm/pv/shim.h | 4 ++--
 xen/arch/x86/include/asm/smp.h     | 6 +++---
 xen/arch/x86/platform_hypercall.c  | 4 ++--
 xen/arch/x86/pv/shim.c             | 4 ++--
 xen/arch/x86/smp.c                 | 4 ++--
 xen/arch/x86/sysctl.c              | 2 +-
 xen/common/core_parking.c          | 2 +-
 xen/common/kexec.c                 | 2 +-
 xen/common/sched/cpupool.c         | 2 +-
 11 files changed, 17 insertions(+), 17 deletions(-)

diff --git a/xen/arch/x86/acpi/power.c b/xen/arch/x86/acpi/power.c
index 912d4c4d62f4..c4e7e8698920 100644
--- a/xen/arch/x86/acpi/power.c
+++ b/xen/arch/x86/acpi/power.c
@@ -326,7 +326,7 @@ static int enter_state(u32 state)
     return error;
 }
 
-static long enter_state_helper(void *data)
+static long cf_check enter_state_helper(void *data)
 {
     struct acpi_sleep_info *sinfo = (struct acpi_sleep_info *)data;
     return enter_state(sinfo->sleep_state);
diff --git a/xen/arch/x86/cpu/microcode/core.c b/xen/arch/x86/cpu/microcode/core.c
index 46f55fe7f191..9631042190ab 100644
--- a/xen/arch/x86/cpu/microcode/core.c
+++ b/xen/arch/x86/cpu/microcode/core.c
@@ -558,7 +558,7 @@ struct ucode_buf {
     char buffer[];
 };
 
-static long microcode_update_helper(void *data)
+static long cf_check microcode_update_helper(void *data)
 {
     int ret;
     struct ucode_buf *buffer = data;
diff --git a/xen/arch/x86/include/asm/pv/shim.h b/xen/arch/x86/include/asm/pv/shim.h
index 6415f8068e5c..be4ae4e60bb8 100644
--- a/xen/arch/x86/include/asm/pv/shim.h
+++ b/xen/arch/x86/include/asm/pv/shim.h
@@ -38,8 +38,8 @@ void pv_shim_setup_dom(struct domain *d, l4_pgentry_t *l4start,
                        start_info_t *si);
 int pv_shim_shutdown(uint8_t reason);
 void pv_shim_inject_evtchn(unsigned int port);
-long pv_shim_cpu_up(void *data);
-long pv_shim_cpu_down(void *data);
+long cf_check pv_shim_cpu_up(void *data);
+long cf_check pv_shim_cpu_down(void *data);
 void pv_shim_online_memory(unsigned int nr, unsigned int order);
 void pv_shim_offline_memory(unsigned int nr, unsigned int order);
 domid_t get_initial_domain_id(void);
diff --git a/xen/arch/x86/include/asm/smp.h b/xen/arch/x86/include/asm/smp.h
index f7485f602efa..1747772d232e 100644
--- a/xen/arch/x86/include/asm/smp.h
+++ b/xen/arch/x86/include/asm/smp.h
@@ -57,10 +57,10 @@ int cpu_add(uint32_t apic_id, uint32_t acpi_id, uint32_t pxm);
 
 void __stop_this_cpu(void);
 
-long cpu_up_helper(void *data);
-long cpu_down_helper(void *data);
+long cf_check cpu_up_helper(void *data);
+long cf_check cpu_down_helper(void *data);
 
-long core_parking_helper(void *data);
+long cf_check core_parking_helper(void *data);
 bool core_parking_remove(unsigned int cpu);
 uint32_t get_cur_idle_nums(void);
 
diff --git a/xen/arch/x86/platform_hypercall.c b/xen/arch/x86/platform_hypercall.c
index 84566bbfaa3d..f5d7adc1e802 100644
--- a/xen/arch/x86/platform_hypercall.c
+++ b/xen/arch/x86/platform_hypercall.c
@@ -45,7 +45,7 @@ struct resource_access {
     xenpf_resource_entry_t *entries;
 };
 
-long cpu_frequency_change_helper(void *);
+long cf_check cpu_frequency_change_helper(void *);
 void check_resource_access(struct resource_access *);
 void resource_access(void *);
 
@@ -59,7 +59,7 @@ DEFINE_SPINLOCK(xenpf_lock);
 # undef guest_from_compat_handle
 # define guest_from_compat_handle(x,y) ((x)=(y))
 
-long cpu_frequency_change_helper(void *data)
+long cf_check cpu_frequency_change_helper(void *data)
 {
     return cpu_frequency_change((uint64_t)data);
 }
diff --git a/xen/arch/x86/pv/shim.c b/xen/arch/x86/pv/shim.c
index ae4d8913faa1..2ee290a3920d 100644
--- a/xen/arch/x86/pv/shim.c
+++ b/xen/arch/x86/pv/shim.c
@@ -845,7 +845,7 @@ int cf_check compat_grant_table_op(
 #endif
 #endif
 
-long pv_shim_cpu_up(void *data)
+long cf_check pv_shim_cpu_up(void *data)
 {
     struct vcpu *v = data;
     struct domain *d = v->domain;
@@ -883,7 +883,7 @@ long pv_shim_cpu_up(void *data)
     return 0;
 }
 
-long pv_shim_cpu_down(void *data)
+long cf_check pv_shim_cpu_down(void *data)
 {
     struct vcpu *v = data;
     long rc;
diff --git a/xen/arch/x86/smp.c b/xen/arch/x86/smp.c
index eef0f9c6cbf4..f4952a6bf9a5 100644
--- a/xen/arch/x86/smp.c
+++ b/xen/arch/x86/smp.c
@@ -399,7 +399,7 @@ void call_function_interrupt(struct cpu_user_regs *regs)
     smp_call_function_interrupt();
 }
 
-long cpu_up_helper(void *data)
+long cf_check cpu_up_helper(void *data)
 {
     unsigned int cpu = (unsigned long)data;
     int ret = cpu_up(cpu);
@@ -422,7 +422,7 @@ long cpu_up_helper(void *data)
     return ret;
 }
 
-long cpu_down_helper(void *data)
+long cf_check cpu_down_helper(void *data)
 {
     int cpu = (unsigned long)data;
     int ret = cpu_down(cpu);
diff --git a/xen/arch/x86/sysctl.c b/xen/arch/x86/sysctl.c
index aff52a13f373..1772f51f8f6e 100644
--- a/xen/arch/x86/sysctl.c
+++ b/xen/arch/x86/sysctl.c
@@ -79,7 +79,7 @@ static void l3_cache_get(void *arg)
         l3_info->size = info.size / 1024; /* in KB unit */
 }
 
-static long smt_up_down_helper(void *data)
+static long cf_check smt_up_down_helper(void *data)
 {
     bool up = (bool)data;
     unsigned int cpu, sibling_mask = boot_cpu_data.x86_num_siblings - 1;
diff --git a/xen/common/core_parking.c b/xen/common/core_parking.c
index 44a907abfd7f..4afad04f2f68 100644
--- a/xen/common/core_parking.c
+++ b/xen/common/core_parking.c
@@ -169,7 +169,7 @@ static unsigned int core_parking_power(unsigned int event)
     return cpu;
 }
 
-long core_parking_helper(void *data)
+long cf_check core_parking_helper(void *data)
 {
     uint32_t idle_nums = (unsigned long)data;
     unsigned int cpu;
diff --git a/xen/common/kexec.c b/xen/common/kexec.c
index 3b223cd03d75..b222a5fd782e 100644
--- a/xen/common/kexec.c
+++ b/xen/common/kexec.c
@@ -395,7 +395,7 @@ void kexec_crash(enum crash_reason reason)
     BUG();
 }
 
-static long kexec_reboot(void *_image)
+static long cf_check kexec_reboot(void *_image)
 {
     struct kexec_image *image = _image;
 
diff --git a/xen/common/sched/cpupool.c b/xen/common/sched/cpupool.c
index e5cfb03b857e..b9d4babd0d8a 100644
--- a/xen/common/sched/cpupool.c
+++ b/xen/common/sched/cpupool.c
@@ -544,7 +544,7 @@ static int cpupool_unassign_cpu_start(struct cpupool *c, unsigned int cpu)
     return ret;
 }
 
-static long cpupool_unassign_cpu_helper(void *info)
+static long cf_check cpupool_unassign_cpu_helper(void *info)
 {
     struct cpupool *c = info;
     long ret;
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:06:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:06:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271711.466350 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb3Y-0007hp-JB; Mon, 14 Feb 2022 13:06:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271711.466350; Mon, 14 Feb 2022 13:06:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb3X-0007dK-Rd; Mon, 14 Feb 2022 13:06:15 +0000
Received: by outflank-mailman (input) for mailman id 271711;
 Mon, 14 Feb 2022 13:06:13 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJb2a-00023t-2E
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:05:16 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id bde2d12a-8d96-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 14:05:12 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bde2d12a-8d96-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644843913;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=h36fBx0LFuxnyE677FLM/COl0irN2W1vke1lrZtnkVs=;
  b=eJoAgxtOGX1ha3LQRp167aB0V47GguagKGZ0wiJSvj35ld7YPn9DoRB7
   bPZryP1bYjeRu0zmOklXp/rtXRSNIStvaJ0qNzernalUtfVIjIDdzBacJ
   uwUIi3Nr1WM/10C6822pUALzJjEUfJ36YOS3jv92q2cJYdq/6TIL1GOiF
   k=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: oG2RzYEMxtvV1Y9hwhqCFCQDucZgsQTYSRna3POglRxV+qwki062O3WwLloF6of6BYFGXhJQkY
 raO7T4peL+c5uQ4+XGybny7OuFyDv1JgZ/QTB3RnzlX4Nh2QrFAgcHjDWJzeR6RmlqGPf9lxt0
 czN5YWYQpqNRGJ/+rS3Ks3NmWxiL1FwqbXwzdFN+uu2wNrHWBc6ufxUygI6tuEskyxXAMVhEGt
 YCsqey8UqE6HboXrPVWftZJCQfF0fx68nBI1lim4wHZjQvBBMX36NuA3Ob/EaVegcOPa/SY6ll
 i0Ha7Xd6nxzB9+6A+M65ocsC
X-SBRS: 5.1
X-MesageID: 63592601
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:wUHFDa2ctH4asle9e/bD5c12kn2cJEfYwER7XKvMYLTBsI5bp2NWz
 WAeXW2FOPeKajT0eN5xa4yz8E5X7ZHVz9FiGgpppC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkS5PE3oHJ9RGQ74nRLlbHILOCanAZqTNMEn9700o5wrJh2+aEvPDia++zk
 YKqyyHgEAfNNw5cagr4PIra9XuDFNyr0N8plgRWicJj5TcypFFMZH4rHomjLmOQf2VhNrXSq
 9Avbl2O1jixEx8FUrtJm1tgG6EAaua60QOm0hK6V0U+6/TrS+NbPqsTbZIhhUlrZzqhhsl7j
 /ZEnpyKSQ4rOI2TiMJBazNyKnQrVUFG0OevzXmXtMWSywvNcmf2wuUoB0YzVWEa0r8pWycUr
 6VecW1TKEDY7w616OvTpu1Er8IvNsT0eqgYvWlt12rxBvc6W5HTBa7N4Le02R9u3Z0fR6iGP
 qL1bxJCVTfhQgBRJms6M8xnhPrzonnOawdX/Qf9Sa0fvDGIkV0ZPKLWGMrYfJmGSNtYmm6cp
 3na5CLpDxcCLtudxDGZtHW2iYfycTjTAdxIUufir7gz3QPVljd75AAquUWTuOCzzW23cNJlK
 0UW/ApxvY5uzGaBd4yoN/Gnm0KsshkZUttWNuQ17gCR16bZizqk6ng4oi1pM4J/6pJvLdA+/
 hrQxo6yW2Qz2FGAYS/Frt+pQSWO1T/5xIPoTQsNVkM77tbqu+nfZTqfH484QMZZYjAYcAwcI
 gxmTgBj3d3/buZRjs1XGGwrZBr2+PD0ovYdvFm/Y45cxloRiHSZT4Kp80PHyv1LMZyUSFKM1
 FBdxZTCs7BeUMzVzXfXKAnoIF1Oz6zbWAAwfHY1R8Vxn9hT0yLLkX9sDMFWex4yb5dslc7Ba
 07PowJBjKK/z1PxBZKbl7mZUpxwpYC5TIyNfqmNMrJmP8ggHCfarXoGTRPBgAjQfL0EzPhX1
 WGzKp33Ux73yM1PkVKLegvq+eF3l35unTuJHfgWDX2PiNKjWZJccp9dWHPmUwzzxP/sTNz9/
 4kNOs2U5Q9YVeGiMCDb/ZRKdQIBLGQhBICwoMtSL7bRLg1jEWAnKvnQ3bJ+JNA1w/ULzr/Fr
 iOnR0tV6Fvjnnmbew+EXW9uNeH0VpFloHNlYSF1ZQS022IuaJqE5bsEc8dlZqEu8eFulKYmT
 /QMd8iaLO5ITzDLp2YUYZXn9dQwfxW3nwOeeSGiZWFnLZJnQgXI/P7ifxfuq3ZSXnbm65Nmr
 uT5hA3BQJcFSwBzN+rsaaqinwGroHwQuONuRE+UcNNdT1rhrdpxICvrg/5pf8xVcUffxiGX3
 hq9CAsDobWfuJc89dTEiPzWr4qtFOciTENWE3OCsOSzPCjeuGGi3ZVBQKCDejWEDDH4/6CrZ
 ON0yfDgMaJYwAYW4tQkS7s7n7gj49bPpqNBylU2FXrGWF2nF7d8LyTUxsJIrKBMmudUtAbet
 phjITWG1WFl4P/YLWM=
IronPort-HdrOrdr: A9a23:+pxzu6/PWM23dmoNKOduk+DaI+orL9Y04lQ7vn2YSXRuHPBw9v
 re5cjzuiWVtN98Yh0dcJW7Scy9qBDnhPhICOsqTNSftWDd0QPCRuxfBMnZslnd8kXFh4lgPM
 xbEpSWZueeMbEDt7eZ3DWF
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="63592601"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v2 51/70] x86/irq: CFI hardening
Date: Mon, 14 Feb 2022 12:51:08 +0000
Message-ID: <20220214125127.17985-52-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

Control Flow Integrity schemes use toolchain and optionally hardware support
to help protect against call/jump/return oriented programming attacks.

Use cf_check to annotate function pointer targets for the toolchain.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
 xen/arch/x86/hpet.c                      | 11 ++++++-----
 xen/arch/x86/i8259.c                     | 10 +++++-----
 xen/arch/x86/include/asm/irq.h           |  8 ++++----
 xen/arch/x86/include/asm/msi.h           |  8 ++++----
 xen/arch/x86/io_apic.c                   | 24 ++++++++++++------------
 xen/arch/x86/irq.c                       |  6 +++---
 xen/arch/x86/msi.c                       | 14 +++++++-------
 xen/common/irq.c                         |  6 +++---
 xen/drivers/passthrough/amd/iommu_init.c | 15 ++++++++-------
 xen/drivers/passthrough/vtd/iommu.c      | 13 +++++++------
 xen/include/xen/irq.h                    |  6 +++---
 11 files changed, 62 insertions(+), 59 deletions(-)

diff --git a/xen/arch/x86/hpet.c b/xen/arch/x86/hpet.c
index 20fca839907c..dcc9e16693e9 100644
--- a/xen/arch/x86/hpet.c
+++ b/xen/arch/x86/hpet.c
@@ -256,7 +256,7 @@ static void cf_check hpet_interrupt_handler(
     ch->event_handler(ch);
 }
 
-static void hpet_msi_unmask(struct irq_desc *desc)
+static void cf_check hpet_msi_unmask(struct irq_desc *desc)
 {
     u32 cfg;
     struct hpet_event_channel *ch = desc->action->dev_id;
@@ -267,7 +267,7 @@ static void hpet_msi_unmask(struct irq_desc *desc)
     ch->msi.msi_attrib.host_masked = 0;
 }
 
-static void hpet_msi_mask(struct irq_desc *desc)
+static void cf_check hpet_msi_mask(struct irq_desc *desc)
 {
     u32 cfg;
     struct hpet_event_channel *ch = desc->action->dev_id;
@@ -296,7 +296,7 @@ static int hpet_msi_write(struct hpet_event_channel *ch, struct msi_msg *msg)
     return 0;
 }
 
-static unsigned int hpet_msi_startup(struct irq_desc *desc)
+static unsigned int cf_check hpet_msi_startup(struct irq_desc *desc)
 {
     hpet_msi_unmask(desc);
     return 0;
@@ -304,14 +304,15 @@ static unsigned int hpet_msi_startup(struct irq_desc *desc)
 
 #define hpet_msi_shutdown hpet_msi_mask
 
-static void hpet_msi_ack(struct irq_desc *desc)
+static void cf_check hpet_msi_ack(struct irq_desc *desc)
 {
     irq_complete_move(desc);
     move_native_irq(desc);
     ack_APIC_irq();
 }
 
-static void hpet_msi_set_affinity(struct irq_desc *desc, const cpumask_t *mask)
+static void cf_check hpet_msi_set_affinity(
+    struct irq_desc *desc, const cpumask_t *mask)
 {
     struct hpet_event_channel *ch = desc->action->dev_id;
     struct msi_msg msg = ch->msi.msg;
diff --git a/xen/arch/x86/i8259.c b/xen/arch/x86/i8259.c
index b389bb217622..6b35be10f09a 100644
--- a/xen/arch/x86/i8259.c
+++ b/xen/arch/x86/i8259.c
@@ -40,18 +40,18 @@ bool bogus_8259A_irq(unsigned int irq)
     return _mask_and_ack_8259A_irq(irq);
 }
 
-static void mask_and_ack_8259A_irq(struct irq_desc *desc)
+static void cf_check mask_and_ack_8259A_irq(struct irq_desc *desc)
 {
     _mask_and_ack_8259A_irq(desc->irq);
 }
 
-static unsigned int startup_8259A_irq(struct irq_desc *desc)
+static unsigned int cf_check startup_8259A_irq(struct irq_desc *desc)
 {
     enable_8259A_irq(desc);
     return 0; /* never anything pending */
 }
 
-static void end_8259A_irq(struct irq_desc *desc, u8 vector)
+static void cf_check end_8259A_irq(struct irq_desc *desc, u8 vector)
 {
     if (!(desc->status & (IRQ_DISABLED|IRQ_INPROGRESS)))
         enable_8259A_irq(desc);
@@ -108,12 +108,12 @@ static void _disable_8259A_irq(unsigned int irq)
     spin_unlock_irqrestore(&i8259A_lock, flags);
 }
 
-void disable_8259A_irq(struct irq_desc *desc)
+void cf_check disable_8259A_irq(struct irq_desc *desc)
 {
     _disable_8259A_irq(desc->irq);
 }
 
-void enable_8259A_irq(struct irq_desc *desc)
+void cf_check enable_8259A_irq(struct irq_desc *desc)
 {
     unsigned int mask = ~(1 << desc->irq);
     unsigned long flags;
diff --git a/xen/arch/x86/include/asm/irq.h b/xen/arch/x86/include/asm/irq.h
index b3f49abc5556..76e6ed6d60aa 100644
--- a/xen/arch/x86/include/asm/irq.h
+++ b/xen/arch/x86/include/asm/irq.h
@@ -111,8 +111,8 @@ void alloc_direct_apic_vector(
 
 void do_IRQ(struct cpu_user_regs *regs);
 
-void disable_8259A_irq(struct irq_desc *);
-void enable_8259A_irq(struct irq_desc *);
+void cf_check disable_8259A_irq(struct irq_desc *);
+void cf_check enable_8259A_irq(struct irq_desc *);
 int i8259A_irq_pending(unsigned int irq);
 void mask_8259A(void);
 void unmask_8259A(void);
@@ -173,7 +173,7 @@ int create_irq(nodeid_t node, bool grant_access);
 void destroy_irq(unsigned int irq);
 int assign_irq_vector(int irq, const cpumask_t *);
 
-extern void irq_complete_move(struct irq_desc *);
+void cf_check irq_complete_move(struct irq_desc *);
 
 extern struct irq_desc *irq_desc;
 
@@ -187,7 +187,7 @@ void move_masked_irq(struct irq_desc *);
 
 int bind_irq_vector(int irq, int vector, const cpumask_t *);
 
-void end_nonmaskable_irq(struct irq_desc *, uint8_t vector);
+void cf_check end_nonmaskable_irq(struct irq_desc *, uint8_t vector);
 void irq_set_affinity(struct irq_desc *, const cpumask_t *mask);
 
 int init_domain_irq_mapping(struct domain *);
diff --git a/xen/arch/x86/include/asm/msi.h b/xen/arch/x86/include/asm/msi.h
index e228b0f3f344..117379318f2c 100644
--- a/xen/arch/x86/include/asm/msi.h
+++ b/xen/arch/x86/include/asm/msi.h
@@ -247,10 +247,10 @@ void early_msi_init(void);
 void msi_compose_msg(unsigned vector, const cpumask_t *mask,
                      struct msi_msg *msg);
 void __msi_set_enable(u16 seg, u8 bus, u8 slot, u8 func, int pos, int enable);
-void mask_msi_irq(struct irq_desc *);
-void unmask_msi_irq(struct irq_desc *);
+void cf_check mask_msi_irq(struct irq_desc *);
+void cf_check unmask_msi_irq(struct irq_desc *);
 void guest_mask_msi_irq(struct irq_desc *, bool mask);
-void ack_nonmaskable_msi_irq(struct irq_desc *);
-void set_msi_affinity(struct irq_desc *, const cpumask_t *);
+void cf_check ack_nonmaskable_msi_irq(struct irq_desc *);
+void cf_check set_msi_affinity(struct irq_desc *, const cpumask_t *);
 
 #endif /* __ASM_MSI_H */
diff --git a/xen/arch/x86/io_apic.c b/xen/arch/x86/io_apic.c
index 4c5eaef86273..c086f40f6314 100644
--- a/xen/arch/x86/io_apic.c
+++ b/xen/arch/x86/io_apic.c
@@ -473,7 +473,7 @@ static void __level_IO_APIC_irq (unsigned int irq)
     modify_IO_APIC_irq(irq, IO_APIC_REDIR_LEVEL_TRIGGER, 0);
 }
 
-static void mask_IO_APIC_irq(struct irq_desc *desc)
+static void cf_check mask_IO_APIC_irq(struct irq_desc *desc)
 {
     unsigned long flags;
 
@@ -482,7 +482,7 @@ static void mask_IO_APIC_irq(struct irq_desc *desc)
     spin_unlock_irqrestore(&ioapic_lock, flags);
 }
 
-static void unmask_IO_APIC_irq(struct irq_desc *desc)
+static void cf_check unmask_IO_APIC_irq(struct irq_desc *desc)
 {
     unsigned long flags;
 
@@ -567,7 +567,7 @@ static void clear_IO_APIC (void)
     }
 }
 
-static void
+static void cf_check
 set_ioapic_affinity_irq(struct irq_desc *desc, const cpumask_t *mask)
 {
     unsigned int dest;
@@ -1547,7 +1547,7 @@ static int __init timer_irq_works(void)
  * This is not complete - we should be able to fake
  * an edge even if it isn't on the 8259A...
  */
-static unsigned int startup_edge_ioapic_irq(struct irq_desc *desc)
+static unsigned int cf_check startup_edge_ioapic_irq(struct irq_desc *desc)
 {
     int was_pending = 0;
     unsigned long flags;
@@ -1569,7 +1569,7 @@ static unsigned int startup_edge_ioapic_irq(struct irq_desc *desc)
  * interrupt for real. This prevents IRQ storms from unhandled
  * devices.
  */
-static void ack_edge_ioapic_irq(struct irq_desc *desc)
+static void cf_check ack_edge_ioapic_irq(struct irq_desc *desc)
 {
     irq_complete_move(desc);
     move_native_irq(desc);
@@ -1594,7 +1594,7 @@ static void ack_edge_ioapic_irq(struct irq_desc *desc)
  * generic IRQ layer and by the fact that an unacked local
  * APIC does not accept IRQs.
  */
-static unsigned int startup_level_ioapic_irq(struct irq_desc *desc)
+static unsigned int cf_check startup_level_ioapic_irq(struct irq_desc *desc)
 {
     unmask_IO_APIC_irq(desc);
 
@@ -1652,7 +1652,7 @@ static bool io_apic_level_ack_pending(unsigned int irq)
     return 0;
 }
 
-static void mask_and_ack_level_ioapic_irq(struct irq_desc *desc)
+static void cf_check mask_and_ack_level_ioapic_irq(struct irq_desc *desc)
 {
     unsigned long v;
     int i;
@@ -1702,7 +1702,7 @@ static void mask_and_ack_level_ioapic_irq(struct irq_desc *desc)
     }
 }
 
-static void end_level_ioapic_irq_old(struct irq_desc *desc, u8 vector)
+static void cf_check end_level_ioapic_irq_old(struct irq_desc *desc, u8 vector)
 {
     if ( directed_eoi_enabled )
     {
@@ -1723,7 +1723,7 @@ static void end_level_ioapic_irq_old(struct irq_desc *desc, u8 vector)
         unmask_IO_APIC_irq(desc);
 }
 
-static void end_level_ioapic_irq_new(struct irq_desc *desc, u8 vector)
+static void cf_check end_level_ioapic_irq_new(struct irq_desc *desc, u8 vector)
 {
 /*
  * It appears there is an erratum which affects at least version 0x11
@@ -1807,7 +1807,7 @@ static inline void init_IO_APIC_traps(void)
             make_8259A_irq(irq);
 }
 
-static void enable_lapic_irq(struct irq_desc *desc)
+static void cf_check enable_lapic_irq(struct irq_desc *desc)
 {
     unsigned long v;
 
@@ -1815,7 +1815,7 @@ static void enable_lapic_irq(struct irq_desc *desc)
     apic_write(APIC_LVT0, v & ~APIC_LVT_MASKED);
 }
 
-static void disable_lapic_irq(struct irq_desc *desc)
+static void cf_check disable_lapic_irq(struct irq_desc *desc)
 {
     unsigned long v;
 
@@ -1823,7 +1823,7 @@ static void disable_lapic_irq(struct irq_desc *desc)
     apic_write(APIC_LVT0, v | APIC_LVT_MASKED);
 }
 
-static void ack_lapic_irq(struct irq_desc *desc)
+static void cf_check ack_lapic_irq(struct irq_desc *desc)
 {
     ack_APIC_irq();
 }
diff --git a/xen/arch/x86/irq.c b/xen/arch/x86/irq.c
index 61e09a356f97..285ac399fbfd 100644
--- a/xen/arch/x86/irq.c
+++ b/xen/arch/x86/irq.c
@@ -468,7 +468,7 @@ int __init init_irq_data(void)
     return 0;
 }
 
-static void ack_none(struct irq_desc *desc)
+static void cf_check ack_none(struct irq_desc *desc)
 {
     ack_bad_irq(desc->irq);
 }
@@ -832,7 +832,7 @@ static void send_cleanup_vector(struct irq_desc *desc)
     desc->arch.move_in_progress = 0;
 }
 
-void irq_complete_move(struct irq_desc *desc)
+void cf_check irq_complete_move(struct irq_desc *desc)
 {
     unsigned vector, me;
 
@@ -1086,7 +1086,7 @@ bool cpu_has_pending_apic_eoi(void)
     return pending_eoi_sp(this_cpu(pending_eoi)) != 0;
 }
 
-void end_nonmaskable_irq(struct irq_desc *desc, uint8_t vector)
+void cf_check end_nonmaskable_irq(struct irq_desc *desc, uint8_t vector)
 {
     struct pending_eoi *peoi = this_cpu(pending_eoi);
     unsigned int sp = pending_eoi_sp(peoi);
diff --git a/xen/arch/x86/msi.c b/xen/arch/x86/msi.c
index 77a4fbf13f9f..b32b1378f84e 100644
--- a/xen/arch/x86/msi.c
+++ b/xen/arch/x86/msi.c
@@ -241,7 +241,7 @@ static int write_msi_msg(struct msi_desc *entry, struct msi_msg *msg)
     return 0;
 }
 
-void set_msi_affinity(struct irq_desc *desc, const cpumask_t *mask)
+void cf_check set_msi_affinity(struct irq_desc *desc, const cpumask_t *mask)
 {
     struct msi_msg msg;
     unsigned int dest;
@@ -416,14 +416,14 @@ static int msi_get_mask_bit(const struct msi_desc *entry)
     return -1;
 }
 
-void mask_msi_irq(struct irq_desc *desc)
+void cf_check mask_msi_irq(struct irq_desc *desc)
 {
     if ( unlikely(!msi_set_mask_bit(desc, 1,
                                     desc->msi_desc->msi_attrib.guest_masked)) )
         BUG_ON(!(desc->status & IRQ_DISABLED));
 }
 
-void unmask_msi_irq(struct irq_desc *desc)
+void cf_check unmask_msi_irq(struct irq_desc *desc)
 {
     if ( unlikely(!msi_set_mask_bit(desc, 0,
                                     desc->msi_desc->msi_attrib.guest_masked)) )
@@ -435,26 +435,26 @@ void guest_mask_msi_irq(struct irq_desc *desc, bool mask)
     msi_set_mask_bit(desc, desc->msi_desc->msi_attrib.host_masked, mask);
 }
 
-static unsigned int startup_msi_irq(struct irq_desc *desc)
+static unsigned int cf_check startup_msi_irq(struct irq_desc *desc)
 {
     if ( unlikely(!msi_set_mask_bit(desc, 0, !!(desc->status & IRQ_GUEST))) )
         WARN();
     return 0;
 }
 
-static void shutdown_msi_irq(struct irq_desc *desc)
+static void cf_check shutdown_msi_irq(struct irq_desc *desc)
 {
     if ( unlikely(!msi_set_mask_bit(desc, 1, 1)) )
         BUG_ON(!(desc->status & IRQ_DISABLED));
 }
 
-void ack_nonmaskable_msi_irq(struct irq_desc *desc)
+void cf_check ack_nonmaskable_msi_irq(struct irq_desc *desc)
 {
     irq_complete_move(desc);
     move_native_irq(desc);
 }
 
-static void ack_maskable_msi_irq(struct irq_desc *desc)
+static void cf_check ack_maskable_msi_irq(struct irq_desc *desc)
 {
     ack_nonmaskable_msi_irq(desc);
     ack_APIC_irq(); /* ACKTYPE_NONE */
diff --git a/xen/common/irq.c b/xen/common/irq.c
index f42512db33b7..727cf8bd22da 100644
--- a/xen/common/irq.c
+++ b/xen/common/irq.c
@@ -27,15 +27,15 @@ int init_one_irq_desc(struct irq_desc *desc)
     return err;
 }
 
-void no_action(int cpl, void *dev_id, struct cpu_user_regs *regs)
+void cf_check no_action(int cpl, void *dev_id, struct cpu_user_regs *regs)
 {
 }
 
-void irq_actor_none(struct irq_desc *desc)
+void cf_check irq_actor_none(struct irq_desc *desc)
 {
 }
 
-unsigned int irq_startup_none(struct irq_desc *desc)
+unsigned int cf_check irq_startup_none(struct irq_desc *desc)
 {
     return 0;
 }
diff --git a/xen/drivers/passthrough/amd/iommu_init.c b/xen/drivers/passthrough/amd/iommu_init.c
index d2ad282e93d3..657c7f619a51 100644
--- a/xen/drivers/passthrough/amd/iommu_init.c
+++ b/xen/drivers/passthrough/amd/iommu_init.c
@@ -410,7 +410,7 @@ static void amd_iommu_msi_enable(struct amd_iommu *iommu, int flag)
                      PCI_FUNC(iommu->bdf), iommu->msi.msi_attrib.pos, flag);
 }
 
-static void iommu_msi_unmask(struct irq_desc *desc)
+static void cf_check iommu_msi_unmask(struct irq_desc *desc)
 {
     unsigned long flags;
     struct amd_iommu *iommu = desc->action->dev_id;
@@ -421,7 +421,7 @@ static void iommu_msi_unmask(struct irq_desc *desc)
     iommu->msi.msi_attrib.host_masked = 0;
 }
 
-static void iommu_msi_mask(struct irq_desc *desc)
+static void cf_check iommu_msi_mask(struct irq_desc *desc)
 {
     unsigned long flags;
     struct amd_iommu *iommu = desc->action->dev_id;
@@ -434,13 +434,13 @@ static void iommu_msi_mask(struct irq_desc *desc)
     iommu->msi.msi_attrib.host_masked = 1;
 }
 
-static unsigned int iommu_msi_startup(struct irq_desc *desc)
+static unsigned int cf_check iommu_msi_startup(struct irq_desc *desc)
 {
     iommu_msi_unmask(desc);
     return 0;
 }
 
-static void iommu_msi_end(struct irq_desc *desc, u8 vector)
+static void cf_check iommu_msi_end(struct irq_desc *desc, u8 vector)
 {
     iommu_msi_unmask(desc);
     end_nonmaskable_irq(desc, vector);
@@ -458,14 +458,14 @@ static hw_irq_controller iommu_msi_type = {
     .set_affinity = set_msi_affinity,
 };
 
-static unsigned int iommu_maskable_msi_startup(struct irq_desc *desc)
+static unsigned int cf_check iommu_maskable_msi_startup(struct irq_desc *desc)
 {
     iommu_msi_unmask(desc);
     unmask_msi_irq(desc);
     return 0;
 }
 
-static void iommu_maskable_msi_shutdown(struct irq_desc *desc)
+static void cf_check iommu_maskable_msi_shutdown(struct irq_desc *desc)
 {
     mask_msi_irq(desc);
     iommu_msi_mask(desc);
@@ -489,7 +489,8 @@ static hw_irq_controller iommu_maskable_msi_type = {
     .set_affinity = set_msi_affinity,
 };
 
-static void set_x2apic_affinity(struct irq_desc *desc, const cpumask_t *mask)
+static void cf_check set_x2apic_affinity(
+    struct irq_desc *desc, const cpumask_t *mask)
 {
     struct amd_iommu *iommu = desc->action->dev_id;
     unsigned int dest = set_desc_affinity(desc, mask);
diff --git a/xen/drivers/passthrough/vtd/iommu.c b/xen/drivers/passthrough/vtd/iommu.c
index fc3ff064b692..c05670eb68a8 100644
--- a/xen/drivers/passthrough/vtd/iommu.c
+++ b/xen/drivers/passthrough/vtd/iommu.c
@@ -1128,7 +1128,7 @@ static void cf_check iommu_page_fault(
     tasklet_schedule(&vtd_fault_tasklet);
 }
 
-static void dma_msi_unmask(struct irq_desc *desc)
+static void cf_check dma_msi_unmask(struct irq_desc *desc)
 {
     struct vtd_iommu *iommu = desc->action->dev_id;
     unsigned long flags;
@@ -1143,7 +1143,7 @@ static void dma_msi_unmask(struct irq_desc *desc)
     iommu->msi.msi_attrib.host_masked = 0;
 }
 
-static void dma_msi_mask(struct irq_desc *desc)
+static void cf_check dma_msi_mask(struct irq_desc *desc)
 {
     unsigned long flags;
     struct vtd_iommu *iommu = desc->action->dev_id;
@@ -1158,26 +1158,27 @@ static void dma_msi_mask(struct irq_desc *desc)
     iommu->msi.msi_attrib.host_masked = 1;
 }
 
-static unsigned int dma_msi_startup(struct irq_desc *desc)
+static unsigned int cf_check dma_msi_startup(struct irq_desc *desc)
 {
     dma_msi_unmask(desc);
     return 0;
 }
 
-static void dma_msi_ack(struct irq_desc *desc)
+static void cf_check dma_msi_ack(struct irq_desc *desc)
 {
     irq_complete_move(desc);
     dma_msi_mask(desc);
     move_masked_irq(desc);
 }
 
-static void dma_msi_end(struct irq_desc *desc, u8 vector)
+static void cf_check dma_msi_end(struct irq_desc *desc, u8 vector)
 {
     dma_msi_unmask(desc);
     end_nonmaskable_irq(desc, vector);
 }
 
-static void dma_msi_set_affinity(struct irq_desc *desc, const cpumask_t *mask)
+static void cf_check dma_msi_set_affinity(
+    struct irq_desc *desc, const cpumask_t *mask)
 {
     struct msi_msg msg;
     unsigned int dest;
diff --git a/xen/include/xen/irq.h b/xen/include/xen/irq.h
index 43d567fe445c..d8beadd16b9f 100644
--- a/xen/include/xen/irq.h
+++ b/xen/include/xen/irq.h
@@ -116,9 +116,9 @@ extern int request_irq(unsigned int irq, unsigned int irqflags,
                const char * devname, void *dev_id);
 
 extern hw_irq_controller no_irq_type;
-extern void no_action(int cpl, void *dev_id, struct cpu_user_regs *regs);
-extern unsigned int irq_startup_none(struct irq_desc *);
-extern void irq_actor_none(struct irq_desc *);
+void cf_check no_action(int cpl, void *dev_id, struct cpu_user_regs *regs);
+unsigned int cf_check irq_startup_none(struct irq_desc *);
+void cf_check irq_actor_none(struct irq_desc *);
 #define irq_shutdown_none irq_actor_none
 #define irq_disable_none irq_actor_none
 #define irq_enable_none irq_actor_none
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:06:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:06:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271713.466368 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb3a-0008Id-R6; Mon, 14 Feb 2022 13:06:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271713.466368; Mon, 14 Feb 2022 13:06:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb3a-0008Fe-6K; Mon, 14 Feb 2022 13:06:18 +0000
Received: by outflank-mailman (input) for mailman id 271713;
 Mon, 14 Feb 2022 13:06:16 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJb35-0008IH-46
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:05:47 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d214b42f-8d96-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 14:05:45 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d214b42f-8d96-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644843945;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=cecI+FT44l503L9yO+BFfcS5GuY0TLog87wC0Mx5p8E=;
  b=O38jx71Zul2bjj1rBV6saBgq7h73AZZqdOR4WfXA2ZBD7BWZcSj28j50
   HY5vlczv7P53mFkiPtqaI05RehnRDj7s7zsMWDYjEfRUpcEkfcU3+T/ri
   0clt9S+IV04H07oaRtbP+hY/QOpIsCBbZChJeNYrAQFOP2an3YbEWbwMY
   I=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: vuaVnpiE5/1VbUEBdoc2AlO5mmSNnFUgbdKKI2IOLHaiq6jyqa/Mn4FpVnPXXszc6kH9GYqlLb
 gSeLTktCqP+0rfKjCvIzUqyVBuyHAGv3L9JoiXgBqO6qGW593IugZwb1CQFWlU2i+aXgYJT1Tx
 sacDZZIirfHeeHsrykrZeLrMjslr+KaSTbggrjTaQjIXR3lvC12B8zTdi9IafYSebzEw9HY82a
 KoqP81SzWAFN04S/uePItXnqyPqjy4I/RxyJIpAhdRZCcCb9XkYFMIDVWMsV+QIQY53gqu+PUL
 Z49Y/4s4hJnOJR2Ytmcvbo7c
X-SBRS: 5.1
X-MesageID: 63592652
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Z2RLJK2Z7uUo8pkPHvbD5c12kn2cJEfYwER7XKvMYLTBsI5bpzAAn
 WodCzvTb/bbZGrye9xzOtvi/UgEvZfcm9NhSgNrpC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkS5PE3oHJ9RGQ74nRLlbHILOCanAZqTNMEn9700o5wrJh2+aEvPDia++zk
 YKqyyHgEAfNNw5cagr4PIra9XuDFNyr0N8plgRWicJj5TcypFFMZH4rHomjLmOQf2VhNrXSq
 9Avbl2O1jixEx8FUrtJm1tgG6EAaua60QOm0hK6V0U+6/TrS+NbPqsTbZIhhUlrZzqhxcxX2
 tJunpuLe1k1P/PFqOM/TgFiOnQrVUFG0OevzXmXtMWSywvNcmf2wuUoB0YzVWEa0r8pWycUr
 6VecW1TKEDY7w616OvTpu1Er8IvNsT0eqgYvWlt12rxBvc6W5HTBa7N4Le02R9u3Z0fR6iDP
 aL1bxIzXBvZfkBiCG0NS6oDlcr5r2fWV21x/Qf9Sa0fvDGIkV0ZPKLWGMrYfJmGSNtYmm6cp
 3na5CLpDxcCLtudxDGZtHW2iYfycTjTAdxIUufir7gz3QPVljd75AAquUWT++WfmEmdcNVkG
 RII+3Qnna8Q6VSRZ4yoN/Gnm0KsshkZUttWNuQ17gCR16bZizqk6ng4oi1pM4J/6pJvLdA+/
 hrQxo6yW2Qz2FGAYS/Frt+pQSWO1T/5xIPoTQsNVkM77tbqu+nfZTqfH484QMZZYjAYcAwcI
 gxmTgBj3d3/buZRjs1XGGwrZBr2+PD0ovYdvFm/Y45cxloRiHSZT4Kp80PHyv1LMZyUSFKM1
 FBdxZTCs7BeUMzVzXfXKAnoIF1Oz6zbWAAwfHY1R8Vxn9hT0yLLkX9sDMFWex4yb5dslc7Ba
 07PowJBjKK/z1PxBZKbl7mZUpxwpYC5TIyNfqmNMrJmP8ggHCfarXoGTRPBgAjQfL0EzPhX1
 WGzKp33Ux73yM1PkVKLegvq+eF3l35unTuJHfgWDX2PiNKjWZJccp9dWHPmUwzzxPrsTNz9/
 4kNOs2U5Q9YVeGiMCDb/ZRKdQIBLGQhBICwoMtSL7bRLg1jEWAnKvnQ3bJ+JNA1w/ULzr/Fr
 iOnR0tV6Fvjnnmbew+EXW9uNeH0VpFloHNlYSF1ZQS022IuaJqE5bsEc8dlZqEu8eFulKYmT
 /QMd8iaLO5ITzDLp2YUYZXn9dQwfxW3nwOeeSGiZWFnLZJnQgXI/P7ifxfuq3ZSXnbm65Nmr
 uT5hA3BQJcFSwBzN+rsaaqinwGroHwQuONuRE+UcNNdT1rhrdpxICvrg/5pf8xVcUffxiGX3
 hq9CAsDobWfuJc89dTEiPzWr4qtFOciTENWE3OCsOSzPCjeuGGi3ZVBQKCDejWEDDH4/6CrZ
 ON0yfDgMaJYwAYW4tQkS7s7n7gj49bPpqNBylU2FXrGWF2nF7d8LyTUxsJIrKBMmudUtAbet
 phjITWG1WFl4P/YLWM=
IronPort-HdrOrdr: A9a23:PWc8jarwhvv7Qligx5fKpGkaV5opeYIsimQD101hICG8cqSj+f
 xG/c5rrCMc5wxwZJhNo7y90ey7MBbhHP1OkO8s1NWZLWrbUQKTRekIh+bfKn/baknDH4ZmpM
 BdmsNFaeEYY2IUsS+D2njbL+od
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="63592652"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v2 23/70] xen/tasklet: CFI hardening
Date: Mon, 14 Feb 2022 12:50:40 +0000
Message-ID: <20220214125127.17985-24-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

Control Flow Integrity schemes use toolchain and optionally hardware support
to help protect against call/jump/return oriented programming attacks.

Use cf_check to annotate function pointer targets for the toolchain.

The function pointer cast in hvm_vcpu_initialise() is undefined behaviour.

While it happens to function correctly, it is not compatible with control flow
typechecking, so introduce a new hvm_assert_evtchn_irq_tasklet() to handle the
parameter type conversion in a legal way.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
v2:
 * Fix typo in commit message.
 * Drop changes to arm-only driver.
---
 xen/arch/x86/hvm/hvm.c                    | 7 ++++++-
 xen/arch/x86/hvm/vlapic.c                 | 2 +-
 xen/arch/x86/include/asm/shadow.h         | 2 +-
 xen/arch/x86/mm/shadow/common.c           | 2 +-
 xen/common/domain.c                       | 2 +-
 xen/common/keyhandler.c                   | 6 +++---
 xen/common/livepatch.c                    | 2 +-
 xen/common/stop_machine.c                 | 2 +-
 xen/common/trace.c                        | 2 +-
 xen/drivers/char/console.c                | 2 +-
 xen/drivers/passthrough/amd/iommu_guest.c | 2 +-
 xen/drivers/passthrough/amd/iommu_init.c  | 4 ++--
 xen/drivers/passthrough/vtd/iommu.c       | 2 +-
 13 files changed, 21 insertions(+), 16 deletions(-)

diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c
index 0a193530680a..5ec10f30803e 100644
--- a/xen/arch/x86/hvm/hvm.c
+++ b/xen/arch/x86/hvm/hvm.c
@@ -1528,6 +1528,11 @@ static int __init cf_check hvm_register_CPU_save_and_restore(void)
 }
 __initcall(hvm_register_CPU_save_and_restore);
 
+static void cf_check hvm_assert_evtchn_irq_tasklet(void *v)
+{
+    hvm_assert_evtchn_irq(v);
+}
+
 int hvm_vcpu_initialise(struct vcpu *v)
 {
     int rc;
@@ -1552,7 +1557,7 @@ int hvm_vcpu_initialise(struct vcpu *v)
         goto fail3;
 
     softirq_tasklet_init(&v->arch.hvm.assert_evtchn_irq_tasklet,
-                         (void (*)(void *))hvm_assert_evtchn_irq, v);
+                         hvm_assert_evtchn_irq_tasklet, v);
 
     v->arch.hvm.inject_event.vector = HVM_EVENT_VECTOR_UNSET;
 
diff --git a/xen/arch/x86/hvm/vlapic.c b/xen/arch/x86/hvm/vlapic.c
index b8c84458ffdc..fe375912bef1 100644
--- a/xen/arch/x86/hvm/vlapic.c
+++ b/xen/arch/x86/hvm/vlapic.c
@@ -312,7 +312,7 @@ static void vlapic_init_sipi_one(struct vcpu *target, uint32_t icr)
     vcpu_unpause(target);
 }
 
-static void vlapic_init_sipi_action(void *data)
+static void cf_check vlapic_init_sipi_action(void *data)
 {
     struct vcpu *origin = data;
     uint32_t icr = vcpu_vlapic(origin)->init_sipi.icr;
diff --git a/xen/arch/x86/include/asm/shadow.h b/xen/arch/x86/include/asm/shadow.h
index e25f9604d896..7ef76cc0635b 100644
--- a/xen/arch/x86/include/asm/shadow.h
+++ b/xen/arch/x86/include/asm/shadow.h
@@ -233,7 +233,7 @@ static inline bool pv_l1tf_check_l4e(struct domain *d, l4_pgentry_t l4e)
     return pv_l1tf_check_pte(d, 4, l4e.l4);
 }
 
-void pv_l1tf_tasklet(void *data);
+void cf_check pv_l1tf_tasklet(void *data);
 
 static inline void pv_l1tf_domain_init(struct domain *d)
 {
diff --git a/xen/arch/x86/mm/shadow/common.c b/xen/arch/x86/mm/shadow/common.c
index b8730a9441ce..fb370af90b5c 100644
--- a/xen/arch/x86/mm/shadow/common.c
+++ b/xen/arch/x86/mm/shadow/common.c
@@ -3242,7 +3242,7 @@ void shadow_audit_tables(struct vcpu *v)
 
 #ifdef CONFIG_PV
 
-void pv_l1tf_tasklet(void *data)
+void cf_check pv_l1tf_tasklet(void *data)
 {
     struct domain *d = data;
 
diff --git a/xen/common/domain.c b/xen/common/domain.c
index 32ec156e6f6a..a49c26064601 100644
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -1824,7 +1824,7 @@ struct migrate_info {
 
 static DEFINE_PER_CPU(struct migrate_info *, continue_info);
 
-static void continue_hypercall_tasklet_handler(void *data)
+static void cf_check continue_hypercall_tasklet_handler(void *data)
 {
     struct migrate_info *info = data;
     struct vcpu *v = info->vcpu;
diff --git a/xen/common/keyhandler.c b/xen/common/keyhandler.c
index 2c916d528ab2..b568484ca62c 100644
--- a/xen/common/keyhandler.c
+++ b/xen/common/keyhandler.c
@@ -73,7 +73,7 @@ static struct keyhandler {
 #undef KEYHANDLER
 };
 
-static void keypress_action(void *unused)
+static void cf_check keypress_action(void *unused)
 {
     handle_keypress(keypress_key, NULL);
 }
@@ -206,7 +206,7 @@ static void dump_registers(unsigned char key, struct cpu_user_regs *regs)
 
 static DECLARE_TASKLET(dump_hwdom_tasklet, NULL, NULL);
 
-static void dump_hwdom_action(void *data)
+static void cf_check dump_hwdom_action(void *data)
 {
     struct vcpu *v = data;
 
@@ -437,7 +437,7 @@ static void read_clocks(unsigned char key)
            maxdif_cycles, sumdif_cycles/count, count, dif_cycles);
 }
 
-static void run_all_nonirq_keyhandlers(void *unused)
+static void cf_check run_all_nonirq_keyhandlers(void *unused)
 {
     /* Fire all the non-IRQ-context diagnostic keyhandlers */
     struct keyhandler *h;
diff --git a/xen/common/livepatch.c b/xen/common/livepatch.c
index 701efd87a173..4e1c29ab7879 100644
--- a/xen/common/livepatch.c
+++ b/xen/common/livepatch.c
@@ -1591,7 +1591,7 @@ static int schedule_work(struct payload *data, uint32_t cmd, uint32_t timeout)
     return 0;
 }
 
-static void tasklet_fn(void *unused)
+static void cf_check tasklet_fn(void *unused)
 {
     this_cpu(work_to_do) = 1;
 }
diff --git a/xen/common/stop_machine.c b/xen/common/stop_machine.c
index a122bd4afe09..3adbe380de96 100644
--- a/xen/common/stop_machine.c
+++ b/xen/common/stop_machine.c
@@ -141,7 +141,7 @@ int stop_machine_run(int (*fn)(void *), void *data, unsigned int cpu)
     return ret;
 }
 
-static void stopmachine_action(void *data)
+static void cf_check stopmachine_action(void *data)
 {
     unsigned int cpu = (unsigned long)data;
     enum stopmachine_state state = STOPMACHINE_START;
diff --git a/xen/common/trace.c b/xen/common/trace.c
index b5358508f804..a7c092fcbbe9 100644
--- a/xen/common/trace.c
+++ b/xen/common/trace.c
@@ -663,7 +663,7 @@ static inline void insert_lost_records(struct t_buf *buf)
  * Notification is performed in qtasklet to avoid deadlocks with contexts
  * which __trace_var() may be called from (e.g., scheduler critical regions).
  */
-static void trace_notify_dom0(void *unused)
+static void cf_check trace_notify_dom0(void *unused)
 {
     send_global_virq(VIRQ_TBUF);
 }
diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c
index 4694be83db45..d74b65f6bf23 100644
--- a/xen/drivers/char/console.c
+++ b/xen/drivers/char/console.c
@@ -574,7 +574,7 @@ static void serial_rx(char c, struct cpu_user_regs *regs)
     __serial_rx(c, regs);
 }
 
-static void notify_dom0_con_ring(void *unused)
+static void cf_check notify_dom0_con_ring(void *unused)
 {
     send_global_virq(VIRQ_CON_RING);
 }
diff --git a/xen/drivers/passthrough/amd/iommu_guest.c b/xen/drivers/passthrough/amd/iommu_guest.c
index 85828490ffee..361ff864d846 100644
--- a/xen/drivers/passthrough/amd/iommu_guest.c
+++ b/xen/drivers/passthrough/amd/iommu_guest.c
@@ -456,7 +456,7 @@ static int do_invalidate_dte(struct domain *d, cmd_entry_t *cmd)
     return 0;
 }
 
-static void guest_iommu_process_command(void *data)
+static void cf_check guest_iommu_process_command(void *data)
 {
     unsigned long opcode, tail, head, cmd_mfn;
     cmd_entry_t *cmd;
diff --git a/xen/drivers/passthrough/amd/iommu_init.c b/xen/drivers/passthrough/amd/iommu_init.c
index f1ed75558227..34a9e49f1c5a 100644
--- a/xen/drivers/passthrough/amd/iommu_init.c
+++ b/xen/drivers/passthrough/amd/iommu_init.c
@@ -26,7 +26,7 @@
 static int __initdata nr_amd_iommus;
 static bool __initdata pci_init;
 
-static void do_amd_iommu_irq(void *data);
+static void cf_check do_amd_iommu_irq(void *data);
 static DECLARE_SOFTIRQ_TASKLET(amd_iommu_irq_tasklet, do_amd_iommu_irq, NULL);
 
 unsigned int __read_mostly amd_iommu_acpi_info;
@@ -692,7 +692,7 @@ static void iommu_check_ppr_log(struct amd_iommu *iommu)
     spin_unlock_irqrestore(&iommu->lock, flags);
 }
 
-static void do_amd_iommu_irq(void *unused)
+static void cf_check do_amd_iommu_irq(void *unused)
 {
     struct amd_iommu *iommu;
 
diff --git a/xen/drivers/passthrough/vtd/iommu.c b/xen/drivers/passthrough/vtd/iommu.c
index 9e85016830bf..7a9c391bec70 100644
--- a/xen/drivers/passthrough/vtd/iommu.c
+++ b/xen/drivers/passthrough/vtd/iommu.c
@@ -1097,7 +1097,7 @@ static void __do_iommu_page_fault(struct vtd_iommu *iommu)
     }
 }
 
-static void do_iommu_page_fault(void *unused)
+static void cf_check do_iommu_page_fault(void *unused)
 {
     struct acpi_drhd_unit *drhd;
 
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:06:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:06:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271715.466387 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb3d-0000eN-MH; Mon, 14 Feb 2022 13:06:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271715.466387; Mon, 14 Feb 2022 13:06:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb3d-0000bE-5U; Mon, 14 Feb 2022 13:06:21 +0000
Received: by outflank-mailman (input) for mailman id 271715;
 Mon, 14 Feb 2022 13:06:19 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJb2W-0008IH-WA
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:05:13 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id bc264d17-8d96-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 14:05:09 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bc264d17-8d96-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644843909;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=W97kFRgj/MifUbIaqTE03bRGTNYxneRqJuik8bYXmus=;
  b=Thd1PFc2MnRcHBfQMxNvSPomzPfvLUJHOZ4F39NrscNwPRdQUdWFMtlt
   wWxZrUHtTawOJjhQ8u3QGynC43rjZDcCkJA0rUFrcahN7z8f2a879h22t
   SP+dlt/2rSlgNw0gvqEExKPGpjjY/hmDQs1KVBVk+NRAkAMg5BiOnpGUj
   Q=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: 0kQ1sX3mZvJKZSOECf8Dl6WPt+Bb5qhEtGkfZ7gae1V/6iBUBIwWfi0MvudW4E8bzxH581D6BD
 9EOwQ4DBb5fuK+/kGBnRdybZ4xg/daZ4sni1Mq1kcXVdW3XNu2xC5EYA0AQqnRTMyWEhlbWl/y
 3baz1A/+EfN7+tFWEc/2stWrSppaTdZWIigq4PSG64UZ7hcyc+RcAjXPZFnVyQxg9RJZomyBjk
 tUcIj0AmlZRu/f0GrE0I0KlIIOWIKuo343IWJtlH0hTrWQxBU06Pg6J9wrwXvqtj+Gtw4b6GrK
 iFfIr+LQmWJbCm3N2D0ZJZR7
X-SBRS: 5.1
X-MesageID: 66374839
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:r8h/KKJH11eaxoWtFE+Rz5IlxSXFcZb7ZxGr2PjKsXjdYENS1zwEx
 mIdXjzVP63cY2CnLtl2aYzj9E9UuJLdztZmQQZlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokcxIn5BC5C5xZVG/fjgqoHUVaiUakideSc+EH170Ug6x7Zg6mJVqYPR7z2l6
 IuaT/L3YDdJ6xYsWo7Dw/vewP/HlK2aVAIw5jTSV9gS1LPtvyB94KYkDbOwNxPFrrx8RYZWc
 QphIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbrGvaUXe345iXMfwZ3u7hB2rlfkoz
 uhhjaC3QDssEJ/KlegzVklhRnQW0a1uoNcrIFC6uM2XiUbHb2Ht07NlC0Re0Y8wo7gtRzsUr
 LpBdW5LPkvra+GemdpXTsFFgMg5IdatF4QYonx6lhnSDOo8QICFSKLPjTNd9Glu3Z8STa2PD
 yYfQWFTXUvFcloRBgpUMLYywfXrgEnPLBQN/Tp5ooJoujOOnWSdyoPFINfTP9CHW8hRtkKZv
 X7duXT0BAkAM96SwibD9Wij7tIjhguiBthUTufhsKc33hvDnQT/FSH6S3OZq9DgjHOSY+5YI
 nAR1BgooKQc8RySG4yVswKDnFaIuRsVWtx1GuI86R2Qxqe83zt1FlToXRYaNoV46ZZeqSgCk
 wbQwoi3XWAHXKi9FCrFnop4uw9eLsT8wYUqQSYfBTUI7ND4yG3YpkKeF40zeEJZYzCcJN0R/
 9xohHVk71nwpZRSv0lewbwgq2jyzqUltiZvum3qspuNt2uVnrKNaY2y8kT85v1dNoufRVTpl
 CFax5TBvLBTUMnUz3blrAAx8FaBvajtDdEhqQQ3Q8lJG8qFpxZPgry8EBkhfRw0Y67oiBfiY
 VPJuBM52XOgFCDCUEODWKroU55C5fG5TbzND6mIBvITMskZXFLWp0lGOB/Pt10BZWBxyMnTz
 7/AKp3yZZvbYIw6pAeLqxA1j+N6mHBmnTmLLX05pjz+uYejiLeuYe9tGDOzgioRtctoeS3Zr
 IRSMdWk0RJaXLGsayXb69dLf1sLMWI6Fdb9rMkOLryPJQ9vGWcADf7NwOx+J9w5zvoNzuqYr
 GugXkJ4yUbkgSGVIwu9dX0+OqjkWoxyrCxnMHV0b0qowXUqfa2m8LwbK8ksZbAi+eE6lax0Q
 vAJdt+uGPNKTjibqT0RYYOk9N5pdQixhBLINC2gOWBtc5llTg3P29nlYgqwq3VeUnvp7ZMz+
 uTy2BnaTJwPQxVZIPzXMP//nUmsuXU9mf5pWxeaKNdkZ0ixopNhLDb8j6FrLphUewnD3DaTy
 y2fHQwc+bvWu4Yw/dTE2fKEooOuH7csF0ZWBTCGv7O/NC2c9Wu/245QFu2PeGmFBm/z/ayjY
 8RTzu39b6JbzAob7dIkHuY517866vvuu6Ren1ZtE3j8Zli2Dq9tfyud1s5Vu6wRnrJUtGNag
 K5UFgW27VlRBP7YLQ==
IronPort-HdrOrdr: A9a23:IlRx5KuOjcTHE5hSfMXq4eTl7skDdNV00zEX/kB9WHVpmszxra
 6TdZUgpGbJYVkqOE3I9ertBEDEewK4yXcX2/h2AV7BZniEhILAFugLhuGO/9SjIVybygc079
 YGT0EUMrzN5DZB4voSmDPIceod/A==
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="66374839"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v2 46/70] x86/guest: CFI hardening
Date: Mon, 14 Feb 2022 12:51:03 +0000
Message-ID: <20220214125127.17985-47-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

Control Flow Integrity schemes use toolchain and optionally hardware support
to help protect against call/jump/return oriented programming attacks.

Use cf_check to annotate function pointer targets for the toolchain.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
 xen/arch/x86/guest/hyperv/hyperv.c | 10 +++++-----
 xen/arch/x86/guest/xen/xen.c       | 11 ++++++-----
 2 files changed, 11 insertions(+), 10 deletions(-)

diff --git a/xen/arch/x86/guest/hyperv/hyperv.c b/xen/arch/x86/guest/hyperv/hyperv.c
index 84221b751453..b101ba3080b4 100644
--- a/xen/arch/x86/guest/hyperv/hyperv.c
+++ b/xen/arch/x86/guest/hyperv/hyperv.c
@@ -175,7 +175,7 @@ static int setup_vp_assist(void)
     return 0;
 }
 
-static void __init setup(void)
+static void __init cf_check setup(void)
 {
     ASM_CONSTANT(HV_HCALL_PAGE, __fix_x_to_virt(FIX_X_HYPERV_HCALL));
 
@@ -188,7 +188,7 @@ static void __init setup(void)
         panic("VP assist page setup failed\n");
 }
 
-static int ap_setup(void)
+static int cf_check ap_setup(void)
 {
     int rc;
 
@@ -199,7 +199,7 @@ static int ap_setup(void)
     return setup_vp_assist();
 }
 
-static void __init e820_fixup(struct e820map *e820)
+static void __init cf_check e820_fixup(struct e820map *e820)
 {
     uint64_t s = HV_HCALL_MFN << PAGE_SHIFT;
 
@@ -207,8 +207,8 @@ static void __init e820_fixup(struct e820map *e820)
         panic("Unable to reserve Hyper-V hypercall range\n");
 }
 
-static int flush_tlb(const cpumask_t *mask, const void *va,
-                     unsigned int flags)
+static int cf_check flush_tlb(
+    const cpumask_t *mask, const void *va, unsigned int flags)
 {
     if ( !(ms_hyperv.hints & HV_X64_REMOTE_TLB_FLUSH_RECOMMENDED) )
         return -EOPNOTSUPP;
diff --git a/xen/arch/x86/guest/xen/xen.c b/xen/arch/x86/guest/xen/xen.c
index 17807cdea688..9c2defaa6621 100644
--- a/xen/arch/x86/guest/xen/xen.c
+++ b/xen/arch/x86/guest/xen/xen.c
@@ -237,7 +237,7 @@ static int init_evtchn(void)
     return rc;
 }
 
-static void __init setup(void)
+static void __init cf_check setup(void)
 {
     init_memmap();
 
@@ -265,7 +265,7 @@ static void __init setup(void)
     BUG_ON(init_evtchn());
 }
 
-static int ap_setup(void)
+static int cf_check ap_setup(void)
 {
     set_vcpu_id();
 
@@ -295,7 +295,7 @@ static void cf_check ap_resume(void *unused)
     BUG_ON(init_evtchn());
 }
 
-static void resume(void)
+static void cf_check resume(void)
 {
     /* Reset shared info page. */
     map_shared_info();
@@ -318,13 +318,14 @@ static void resume(void)
         pv_console_init();
 }
 
-static void __init e820_fixup(struct e820map *e820)
+static void __init cf_check e820_fixup(struct e820map *e820)
 {
     if ( pv_shim )
         pv_shim_fixup_e820(e820);
 }
 
-static int flush_tlb(const cpumask_t *mask, const void *va, unsigned int flags)
+static int cf_check flush_tlb(
+    const cpumask_t *mask, const void *va, unsigned int flags)
 {
     return xen_hypercall_hvm_op(HVMOP_flush_tlbs, NULL);
 }
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:06:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:06:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271717.466393 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb3e-0000rR-U4; Mon, 14 Feb 2022 13:06:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271717.466393; Mon, 14 Feb 2022 13:06:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb3e-0000p2-Ca; Mon, 14 Feb 2022 13:06:22 +0000
Received: by outflank-mailman (input) for mailman id 271717;
 Mon, 14 Feb 2022 13:06:20 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJb33-00023t-JR
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:05:45 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id cfb2082c-8d96-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 14:05:42 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cfb2082c-8d96-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644843943;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=OwW5YsR6GfHfWjF2g/4V1G5fiXx9eC4JGeYTntB+Biw=;
  b=bTkovZwz0Ou8CuafAXR06gA2ldSCoXJ7P2ovFY6JiukylJGk8iU7PJ1M
   fcGarIre1D9Hnj4rMc1yFIr575ysQCGf0l6G81wc1dP0W6fc5L/iJdORy
   idbaUD3VAtlui4N0zGY2dSOqH4xOmDHs+0Z8UMoPRyMcxgeeqUIhiCWCq
   U=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: ppeC++WIrsfEBI6t2hLmZt8vYMV2tXZwuCwCNIS6FvQexE0ACL5AgRKNGXFZagJAiT1tiRA6nG
 MV6l7keBqlOIzYfy4HMBhzVhrTYAAPtlUwiuvYBtZPFGZNZIvf/jgUcPJnha7aw2szDUo42rWD
 L4eaFgopv1hTxgKnsGxwX4BY5n71ui/+ZAYRebdCZcK1gobk1vZDDERUN+YJzcsuzQ/FdP10VW
 4lhy+NcDDoRuGRpkVZqtJQy4c/SQFYLI0eBiQvkpKm9yFs5H+wzLxxh5ZbhyB4KnIkIlmAf18B
 sJPbuhNWIj2prJHymCwq9o4V
X-SBRS: 5.1
X-MesageID: 64149826
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:4PPMqKn/87z9ojq+Ckpc0m3o5gyfIURdPkR7XQ2eYbSJt1+Wr1Gzt
 xJNCmHSaK2JZWSgctFxPNi/9kID78fXyNJkHAZkqSo0EiMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BClVlxJVF/fngqoDUUYYoAQgsA180IMsdoUg7wbRh2Nc02YHR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 NYThbGoby4gB6fvovszcwBaVAZuH7ITrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBODtMJkSpTdLyjbBAOx9aZvCX7/L9ZlT2zJYasVmQ6qHO
 5tJM2QHgBLoTkNkPVo9GIsHh+aomDrubD5h6w2pnP9ii4TU5FMoi+W8WDbPQfSaSMMQkkuGq
 2bu+2XiHgpcJNGZ0SCC8H+nmqnIhyyTZW4JPOTmrLgw2gTVnzFNTk1NPbemnRWnok3ga/9HD
 WUdwyANl7cc1FWpCf7tfQLt9RZooSUgc9ZXFuQ77iSExazV/xuVCwA4c9JRVDA1nJRoHGJ3j
 zdli/usXGUy6+PNFRpx45/J9WvaBMQDEYMVicbopyMh6sKrnow8hwmnoj1LQP/s1Y2d9d0dL
 lm3QMkCa1c70JRjO0aTpwmvb9eQSn/hFFBd2+kvdjj5hj6Vnab8D2BS1XDV7OxbMKGSRUSbs
 X4PlqC2tb5SUc7dxHHQGLxWRtlFAspp1xWG3zZS82QJrWzxqxZPg6gMiN2BGKuZGpldImK4C
 KMikQhQ+IVSLBOXgVxfOOqM5zAR5fG4T7zND6mMBvIXO8QZXFLXrUlGOB/Lt0iwwRdErE3KE
 crCGSpaJS1BUvoPIfvfb7p17ILHMQhgmTKNFcijlUzPPHj3TCf9dIrp+WCmNogRhJ5oai2Mm
 zqGH8fVmRhZTsPkZSzbrdwaIVwQdCBpDpHqsc1HMOWEJ1M+Sm0mDvbQx5InepBkwPsJxruZo
 CnlVx8K0kf7iF3GNR6ONiJpZoTwUMsttnk8JyEtYwqlgiBxfYa14a4DXJIrZr17pvd7xPt5Q
 qBdKcWNC/hCUBrd/DEZYcWvpYBubk3z1wmPIzCkcH40eJs5H17F/drtfw3O8igSD3Xo6Zti8
 uP4jg6CGMgNXQVvCsrSecmD9VLpsChPgv92UmvJPsJXJBfm/r91JnGjlfQwOcwNd0nOn2PIy
 waMDB4EjuDRuItposLRjKWJoor1QetzGk1WQzvS4bqsbHSI+2OixclLUfqSfCCbX2Txof3wa
 eJQxvD6EfsGgFcV7NYsT+c1lfozt4n1urtX7gV4B3GaPV2kB4RpLmSCwcQS5LZGwaVUuFfuV
 0+CkjWA1W5l5C8x/IYtGTcY
IronPort-HdrOrdr: A9a23:TUokqq7Qv1JBWj7L5QPXwMrXdLJyesId70hD6qhwISY6TiX4rb
 HWoB1173/JYVoqNE3I3OrwXZVoIkmsk6Kdg7NhXotKNTOO0ADDQb2Kr7GSpwEIcxeOkdK1vp
 0AT0ERMrLN5CBB/KTH3DU=
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="64149826"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v2 33/70] x86/hvm: CFI hardening for device emulation
Date: Mon, 14 Feb 2022 12:50:50 +0000
Message-ID: <20220214125127.17985-34-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

Control Flow Integrity schemes use toolchain and optionally hardware support
to help protect against call/jump/return oriented programming attacks.

Use cf_check to annotate function pointer targets for the toolchain.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
 xen/arch/x86/emul-i8254.c                 |  8 +++----
 xen/arch/x86/hvm/emulate.c                | 21 ++++++++---------
 xen/arch/x86/hvm/hpet.c                   |  6 ++---
 xen/arch/x86/hvm/hvm.c                    |  2 +-
 xen/arch/x86/hvm/intercept.c              | 28 +++++++++++++----------
 xen/arch/x86/hvm/io.c                     | 38 +++++++++++++++++--------------
 xen/arch/x86/hvm/ioreq.c                  |  2 +-
 xen/arch/x86/hvm/pmtimer.c                |  4 ++--
 xen/arch/x86/hvm/rtc.c                    |  6 ++---
 xen/arch/x86/hvm/stdvga.c                 | 19 ++++++++--------
 xen/arch/x86/hvm/svm/svm.c                |  4 ++--
 xen/arch/x86/hvm/vioapic.c                |  8 +++----
 xen/arch/x86/hvm/vlapic.c                 | 11 +++++----
 xen/arch/x86/hvm/vmsi.c                   | 14 +++++++-----
 xen/arch/x86/hvm/vpic.c                   |  4 ++--
 xen/arch/x86/include/asm/hvm/vioapic.h    |  2 +-
 xen/drivers/passthrough/amd/iommu_guest.c | 10 ++++----
 17 files changed, 98 insertions(+), 89 deletions(-)

diff --git a/xen/arch/x86/emul-i8254.c b/xen/arch/x86/emul-i8254.c
index 050c784702af..0e09a173187f 100644
--- a/xen/arch/x86/emul-i8254.c
+++ b/xen/arch/x86/emul-i8254.c
@@ -48,9 +48,9 @@
 #define RW_STATE_WORD0 3
 #define RW_STATE_WORD1 4
 
-static int handle_pit_io(
+static int cf_check handle_pit_io(
     int dir, unsigned int port, unsigned int bytes, uint32_t *val);
-static int handle_speaker_io(
+static int cf_check handle_speaker_io(
     int dir, unsigned int port, unsigned int bytes, uint32_t *val);
 
 #define get_guest_time(v) \
@@ -505,7 +505,7 @@ void pit_deinit(struct domain *d)
 }
 
 /* the intercept action for PIT DM retval:0--not handled; 1--handled */  
-static int handle_pit_io(
+static int cf_check handle_pit_io(
     int dir, unsigned int port, unsigned int bytes, uint32_t *val)
 {
     struct PITState *vpit = vcpu_vpit(current);
@@ -548,7 +548,7 @@ static uint32_t speaker_ioport_read(
             (pit_get_out(pit, 2) << 5) | (refresh_clock << 4));
 }
 
-static int handle_speaker_io(
+static int cf_check handle_speaker_io(
     int dir, unsigned int port, uint32_t bytes, uint32_t *val)
 {
     struct PITState *vpit = vcpu_vpit(current);
diff --git a/xen/arch/x86/hvm/emulate.c b/xen/arch/x86/hvm/emulate.c
index 2b3fb4d6ba05..39dac7fd9d6d 100644
--- a/xen/arch/x86/hvm/emulate.c
+++ b/xen/arch/x86/hvm/emulate.c
@@ -71,19 +71,17 @@ static void hvmtrace_io_assist(const ioreq_t *p)
     trace_var(event, 0/*!cycles*/, size, buffer);
 }
 
-static int null_read(const struct hvm_io_handler *io_handler,
-                     uint64_t addr,
-                     uint32_t size,
-                     uint64_t *data)
+static int cf_check null_read(
+    const struct hvm_io_handler *io_handler, uint64_t addr, uint32_t size,
+    uint64_t *data)
 {
     *data = ~0ul;
     return X86EMUL_OKAY;
 }
 
-static int null_write(const struct hvm_io_handler *handler,
-                      uint64_t addr,
-                      uint32_t size,
-                      uint64_t data)
+static int cf_check null_write(
+    const struct hvm_io_handler *handler, uint64_t addr, uint32_t size,
+    uint64_t data)
 {
     return X86EMUL_OKAY;
 }
@@ -114,10 +112,9 @@ static const struct hvm_io_handler null_handler = {
     .ops = &null_ops
 };
 
-static int ioreq_server_read(const struct hvm_io_handler *io_handler,
-                    uint64_t addr,
-                    uint32_t size,
-                    uint64_t *data)
+static int cf_check ioreq_server_read(
+    const struct hvm_io_handler *io_handler, uint64_t addr, uint32_t size,
+    uint64_t *data)
 {
     if ( hvm_copy_from_guest_phys(data, addr, size) != HVMTRANS_okay )
         return X86EMUL_UNHANDLEABLE;
diff --git a/xen/arch/x86/hvm/hpet.c b/xen/arch/x86/hvm/hpet.c
index 8267f0b8a278..7bdb51cfa1c4 100644
--- a/xen/arch/x86/hvm/hpet.c
+++ b/xen/arch/x86/hvm/hpet.c
@@ -162,7 +162,7 @@ static inline int hpet_check_access_length(
     return 0;
 }
 
-static int hpet_read(
+static int cf_check hpet_read(
     struct vcpu *v, unsigned long addr, unsigned int length,
     unsigned long *pval)
 {
@@ -351,7 +351,7 @@ static void timer_sanitize_int_route(HPETState *h, unsigned int tn)
                   HPET_TN_ROUTE);
 }
 
-static int hpet_write(
+static int cf_check hpet_write(
     struct vcpu *v, unsigned long addr,
     unsigned int length, unsigned long val)
 {
@@ -569,7 +569,7 @@ static int hpet_write(
     return X86EMUL_OKAY;
 }
 
-static int hpet_range(struct vcpu *v, unsigned long addr)
+static int cf_check hpet_range(struct vcpu *v, unsigned long addr)
 {
     return ( (addr >= HPET_BASE_ADDRESS) &&
              (addr < (HPET_BASE_ADDRESS + HPET_MMAP_SIZE)) );
diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c
index 5ec10f30803e..9e4924649077 100644
--- a/xen/arch/x86/hvm/hvm.c
+++ b/xen/arch/x86/hvm/hvm.c
@@ -543,7 +543,7 @@ void hvm_do_resume(struct vcpu *v)
     }
 }
 
-static int hvm_print_line(
+static int cf_check hvm_print_line(
     int dir, unsigned int port, unsigned int bytes, uint32_t *val)
 {
     struct domain *cd = current->domain;
diff --git a/xen/arch/x86/hvm/intercept.c b/xen/arch/x86/hvm/intercept.c
index 02ca3b05b05a..ffa31b746716 100644
--- a/xen/arch/x86/hvm/intercept.c
+++ b/xen/arch/x86/hvm/intercept.c
@@ -32,8 +32,8 @@
 #include <xen/event.h>
 #include <xen/iommu.h>
 
-static bool_t hvm_mmio_accept(const struct hvm_io_handler *handler,
-                              const ioreq_t *p)
+static bool cf_check hvm_mmio_accept(
+    const struct hvm_io_handler *handler, const ioreq_t *p)
 {
     paddr_t first = ioreq_mmio_first_byte(p), last;
 
@@ -51,16 +51,18 @@ static bool_t hvm_mmio_accept(const struct hvm_io_handler *handler,
     return 1;
 }
 
-static int hvm_mmio_read(const struct hvm_io_handler *handler,
-                         uint64_t addr, uint32_t size, uint64_t *data)
+static int cf_check hvm_mmio_read(
+    const struct hvm_io_handler *handler, uint64_t addr, uint32_t size,
+    uint64_t *data)
 {
     BUG_ON(handler->type != IOREQ_TYPE_COPY);
 
     return handler->mmio.ops->read(current, addr, size, data);
 }
 
-static int hvm_mmio_write(const struct hvm_io_handler *handler,
-                          uint64_t addr, uint32_t size, uint64_t data)
+static int cf_check hvm_mmio_write(
+    const struct hvm_io_handler *handler, uint64_t addr, uint32_t size,
+    uint64_t data)
 {
     BUG_ON(handler->type != IOREQ_TYPE_COPY);
 
@@ -73,8 +75,8 @@ static const struct hvm_io_ops mmio_ops = {
     .write = hvm_mmio_write
 };
 
-static bool_t hvm_portio_accept(const struct hvm_io_handler *handler,
-                                const ioreq_t *p)
+static bool cf_check hvm_portio_accept(
+    const struct hvm_io_handler *handler, const ioreq_t *p)
 {
     unsigned int start = handler->portio.port;
     unsigned int end = start + handler->portio.size;
@@ -84,8 +86,9 @@ static bool_t hvm_portio_accept(const struct hvm_io_handler *handler,
     return (p->addr >= start) && ((p->addr + p->size) <= end);
 }
 
-static int hvm_portio_read(const struct hvm_io_handler *handler,
-                           uint64_t addr, uint32_t size, uint64_t *data)
+static int cf_check hvm_portio_read(
+    const struct hvm_io_handler *handler, uint64_t addr, uint32_t size,
+    uint64_t *data)
 {
     uint32_t val = ~0u;
     int rc;
@@ -98,8 +101,9 @@ static int hvm_portio_read(const struct hvm_io_handler *handler,
     return rc;
 }
 
-static int hvm_portio_write(const struct hvm_io_handler *handler,
-                            uint64_t addr, uint32_t size, uint64_t data)
+static int cf_check hvm_portio_write(
+    const struct hvm_io_handler *handler, uint64_t addr, uint32_t size,
+    uint64_t data)
 {
     uint32_t val = data;
 
diff --git a/xen/arch/x86/hvm/io.c b/xen/arch/x86/hvm/io.c
index 93f1d1503fa6..f70bfde90143 100644
--- a/xen/arch/x86/hvm/io.c
+++ b/xen/arch/x86/hvm/io.c
@@ -156,8 +156,8 @@ bool handle_pio(uint16_t port, unsigned int size, int dir)
     return true;
 }
 
-static bool_t g2m_portio_accept(const struct hvm_io_handler *handler,
-                                const ioreq_t *p)
+static bool cf_check g2m_portio_accept(
+    const struct hvm_io_handler *handler, const ioreq_t *p)
 {
     struct vcpu *curr = current;
     const struct hvm_domain *hvm = &curr->domain->arch.hvm;
@@ -179,8 +179,9 @@ static bool_t g2m_portio_accept(const struct hvm_io_handler *handler,
     return 0;
 }
 
-static int g2m_portio_read(const struct hvm_io_handler *handler,
-                           uint64_t addr, uint32_t size, uint64_t *data)
+static int cf_check g2m_portio_read(
+    const struct hvm_io_handler *handler, uint64_t addr, uint32_t size,
+    uint64_t *data)
 {
     struct hvm_vcpu_io *hvio = &current->arch.hvm.hvm_io;
     const struct g2m_ioport *g2m_ioport = hvio->g2m_ioport;
@@ -204,8 +205,9 @@ static int g2m_portio_read(const struct hvm_io_handler *handler,
     return X86EMUL_OKAY;
 }
 
-static int g2m_portio_write(const struct hvm_io_handler *handler,
-                            uint64_t addr, uint32_t size, uint64_t data)
+static int cf_check g2m_portio_write(
+    const struct hvm_io_handler *handler, uint64_t addr, uint32_t size,
+    uint64_t data)
 {
     struct hvm_vcpu_io *hvio = &current->arch.hvm.hvm_io;
     const struct g2m_ioport *g2m_ioport = hvio->g2m_ioport;
@@ -261,14 +263,15 @@ unsigned int hvm_pci_decode_addr(unsigned int cf8, unsigned int addr,
 }
 
 /* vPCI config space IO ports handlers (0xcf8/0xcfc). */
-static bool vpci_portio_accept(const struct hvm_io_handler *handler,
-                               const ioreq_t *p)
+static bool cf_check vpci_portio_accept(
+    const struct hvm_io_handler *handler, const ioreq_t *p)
 {
     return (p->addr == 0xcf8 && p->size == 4) || (p->addr & ~3) == 0xcfc;
 }
 
-static int vpci_portio_read(const struct hvm_io_handler *handler,
-                            uint64_t addr, uint32_t size, uint64_t *data)
+static int cf_check vpci_portio_read(
+    const struct hvm_io_handler *handler, uint64_t addr, uint32_t size,
+    uint64_t *data)
 {
     const struct domain *d = current->domain;
     unsigned int reg;
@@ -299,8 +302,9 @@ static int vpci_portio_read(const struct hvm_io_handler *handler,
     return X86EMUL_OKAY;
 }
 
-static int vpci_portio_write(const struct hvm_io_handler *handler,
-                             uint64_t addr, uint32_t size, uint64_t data)
+static int cf_check vpci_portio_write(
+    const struct hvm_io_handler *handler, uint64_t addr, uint32_t size,
+    uint64_t data)
 {
     struct domain *d = current->domain;
     unsigned int reg;
@@ -387,7 +391,7 @@ static unsigned int vpci_mmcfg_decode_addr(const struct hvm_mmcfg *mmcfg,
     return addr & (PCI_CFG_SPACE_EXP_SIZE - 1);
 }
 
-static int vpci_mmcfg_accept(struct vcpu *v, unsigned long addr)
+static int cf_check vpci_mmcfg_accept(struct vcpu *v, unsigned long addr)
 {
     struct domain *d = v->domain;
     bool found;
@@ -399,8 +403,8 @@ static int vpci_mmcfg_accept(struct vcpu *v, unsigned long addr)
     return found;
 }
 
-static int vpci_mmcfg_read(struct vcpu *v, unsigned long addr,
-                           unsigned int len, unsigned long *data)
+static int cf_check vpci_mmcfg_read(
+    struct vcpu *v, unsigned long addr, unsigned int len, unsigned long *data)
 {
     struct domain *d = v->domain;
     const struct hvm_mmcfg *mmcfg;
@@ -426,8 +430,8 @@ static int vpci_mmcfg_read(struct vcpu *v, unsigned long addr,
     return X86EMUL_OKAY;
 }
 
-static int vpci_mmcfg_write(struct vcpu *v, unsigned long addr,
-                            unsigned int len, unsigned long data)
+static int cf_check vpci_mmcfg_write(
+    struct vcpu *v, unsigned long addr, unsigned int len, unsigned long data)
 {
     struct domain *d = v->domain;
     const struct hvm_mmcfg *mmcfg;
diff --git a/xen/arch/x86/hvm/ioreq.c b/xen/arch/x86/hvm/ioreq.c
index 02ad9db56523..8409d910d689 100644
--- a/xen/arch/x86/hvm/ioreq.c
+++ b/xen/arch/x86/hvm/ioreq.c
@@ -319,7 +319,7 @@ bool arch_ioreq_server_get_type_addr(const struct domain *d,
     return true;
 }
 
-static int hvm_access_cf8(
+static int cf_check hvm_access_cf8(
     int dir, unsigned int port, unsigned int bytes, uint32_t *val)
 {
     struct domain *d = current->domain;
diff --git a/xen/arch/x86/hvm/pmtimer.c b/xen/arch/x86/hvm/pmtimer.c
index 808819d1de91..60e3c8de4c6b 100644
--- a/xen/arch/x86/hvm/pmtimer.c
+++ b/xen/arch/x86/hvm/pmtimer.c
@@ -152,7 +152,7 @@ static void cf_check pmt_timer_callback(void *opaque)
 }
 
 /* Handle port I/O to the PM1a_STS and PM1a_EN registers */
-static int handle_evt_io(
+static int cf_check handle_evt_io(
     int dir, unsigned int port, unsigned int bytes, uint32_t *val)
 {
     struct vcpu *v = current;
@@ -216,7 +216,7 @@ static int handle_evt_io(
 
 
 /* Handle port I/O to the TMR_VAL register */
-static int handle_pmt_io(
+static int cf_check handle_pmt_io(
     int dir, unsigned int port, unsigned int bytes, uint32_t *val)
 {
     struct vcpu *v = current;
diff --git a/xen/arch/x86/hvm/rtc.c b/xen/arch/x86/hvm/rtc.c
index 09d3501276bc..bdc647e433e9 100644
--- a/xen/arch/x86/hvm/rtc.c
+++ b/xen/arch/x86/hvm/rtc.c
@@ -696,7 +696,7 @@ static uint32_t rtc_ioport_read(RTCState *s, uint32_t addr)
     return ret;
 }
 
-static int handle_rtc_io(
+static int cf_check handle_rtc_io(
     int dir, unsigned int port, unsigned int bytes, uint32_t *val)
 {
     struct RTCState *vrtc = vcpu_vrtc(current);
@@ -809,8 +809,8 @@ void rtc_reset(struct domain *d)
 }
 
 /* RTC mediator for HVM hardware domain. */
-static int hw_rtc_io(int dir, unsigned int port, unsigned int size,
-                     uint32_t *val)
+static int cf_check hw_rtc_io(
+    int dir, unsigned int port, unsigned int size, uint32_t *val)
 {
     if ( dir == IOREQ_READ )
         *val = ~0;
diff --git a/xen/arch/x86/hvm/stdvga.c b/xen/arch/x86/hvm/stdvga.c
index ab9781d82a55..be8200c8d072 100644
--- a/xen/arch/x86/hvm/stdvga.c
+++ b/xen/arch/x86/hvm/stdvga.c
@@ -199,7 +199,7 @@ static void stdvga_out(uint32_t port, uint32_t bytes, uint32_t val)
     }
 }
 
-static int stdvga_intercept_pio(
+static int cf_check stdvga_intercept_pio(
     int dir, unsigned int port, unsigned int bytes, uint32_t *val)
 {
     struct hvm_hw_stdvga *s = &current->domain->arch.hvm.stdvga;
@@ -302,8 +302,9 @@ static uint8_t stdvga_mem_readb(uint64_t addr)
     return ret;
 }
 
-static int stdvga_mem_read(const struct hvm_io_handler *handler,
-                           uint64_t addr, uint32_t size, uint64_t *p_data)
+static int cf_check stdvga_mem_read(
+    const struct hvm_io_handler *handler, uint64_t addr, uint32_t size,
+    uint64_t *p_data)
 {
     uint64_t data = ~0ul;
 
@@ -453,9 +454,9 @@ static void stdvga_mem_writeb(uint64_t addr, uint32_t val)
     }
 }
 
-static int stdvga_mem_write(const struct hvm_io_handler *handler,
-                            uint64_t addr, uint32_t size,
-                            uint64_t data)
+static int cf_check stdvga_mem_write(
+    const struct hvm_io_handler *handler, uint64_t addr, uint32_t size,
+    uint64_t data)
 {
     struct hvm_hw_stdvga *s = &current->domain->arch.hvm.stdvga;
     ioreq_t p = {
@@ -514,8 +515,8 @@ static int stdvga_mem_write(const struct hvm_io_handler *handler,
     return ioreq_send(srv, &p, 1);
 }
 
-static bool_t stdvga_mem_accept(const struct hvm_io_handler *handler,
-                                const ioreq_t *p)
+static bool cf_check stdvga_mem_accept(
+    const struct hvm_io_handler *handler, const ioreq_t *p)
 {
     struct hvm_hw_stdvga *s = &current->domain->arch.hvm.stdvga;
 
@@ -558,7 +559,7 @@ static bool_t stdvga_mem_accept(const struct hvm_io_handler *handler,
     return 0;
 }
 
-static void stdvga_mem_complete(const struct hvm_io_handler *handler)
+static void cf_check stdvga_mem_complete(const struct hvm_io_handler *handler)
 {
     struct hvm_hw_stdvga *s = &current->domain->arch.hvm.stdvga;
 
diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c
index de6166241bf1..4c4ebda5e6e4 100644
--- a/xen/arch/x86/hvm/svm/svm.c
+++ b/xen/arch/x86/hvm/svm/svm.c
@@ -1133,8 +1133,8 @@ static void svm_host_osvw_init(void)
     spin_unlock(&osvw_lock);
 }
 
-static int acpi_c1e_quirk(int dir, unsigned int port, unsigned int bytes,
-                          uint32_t *val)
+static int cf_check acpi_c1e_quirk(
+    int dir, unsigned int port, unsigned int bytes, uint32_t *val)
 {
     ASSERT(bytes == 1 && port == acpi_smi_cmd);
 
diff --git a/xen/arch/x86/hvm/vioapic.c b/xen/arch/x86/hvm/vioapic.c
index 553c0f76eff8..b56549aa22d1 100644
--- a/xen/arch/x86/hvm/vioapic.c
+++ b/xen/arch/x86/hvm/vioapic.c
@@ -135,7 +135,7 @@ static uint32_t vioapic_read_indirect(const struct hvm_vioapic *vioapic)
     return result;
 }
 
-static int vioapic_read(
+static int cf_check vioapic_read(
     struct vcpu *v, unsigned long addr,
     unsigned int length, unsigned long *pval)
 {
@@ -351,7 +351,7 @@ static void vioapic_write_indirect(
     }
 }
 
-static int vioapic_write(
+static int cf_check vioapic_write(
     struct vcpu *v, unsigned long addr,
     unsigned int length, unsigned long val)
 {
@@ -383,7 +383,7 @@ static int vioapic_write(
     return X86EMUL_OKAY;
 }
 
-static int vioapic_range(struct vcpu *v, unsigned long addr)
+static int cf_check vioapic_range(struct vcpu *v, unsigned long addr)
 {
     return !!addr_vioapic(v->domain, addr);
 }
@@ -568,7 +568,7 @@ int vioapic_get_mask(const struct domain *d, unsigned int gsi)
     return vioapic->redirtbl[pin].fields.mask;
 }
 
-int vioapic_get_vector(const struct domain *d, unsigned int gsi)
+int cf_check vioapic_get_vector(const struct domain *d, unsigned int gsi)
 {
     unsigned int pin = 0; /* See gsi_vioapic */
     const struct hvm_vioapic *vioapic = gsi_vioapic(d, gsi, &pin);
diff --git a/xen/arch/x86/hvm/vlapic.c b/xen/arch/x86/hvm/vlapic.c
index fe375912bef1..652e3cb87f12 100644
--- a/xen/arch/x86/hvm/vlapic.c
+++ b/xen/arch/x86/hvm/vlapic.c
@@ -615,8 +615,9 @@ static uint32_t vlapic_read_aligned(const struct vlapic *vlapic,
     return 0;
 }
 
-static int vlapic_mmio_read(struct vcpu *v, unsigned long address,
-                            unsigned int len, unsigned long *pval)
+static int cf_check vlapic_mmio_read(
+    struct vcpu *v, unsigned long address, unsigned int len,
+    unsigned long *pval)
 {
     struct vlapic *vlapic = vcpu_vlapic(v);
     unsigned int offset = address - vlapic_base_address(vlapic);
@@ -898,8 +899,8 @@ void vlapic_reg_write(struct vcpu *v, unsigned int reg, uint32_t val)
     }
 }
 
-static int vlapic_mmio_write(struct vcpu *v, unsigned long address,
-                             unsigned int len, unsigned long val)
+static int cf_check vlapic_mmio_write(
+    struct vcpu *v, unsigned long address, unsigned int len, unsigned long val)
 {
     struct vlapic *vlapic = vcpu_vlapic(v);
     unsigned int offset = address - vlapic_base_address(vlapic);
@@ -1052,7 +1053,7 @@ int guest_wrmsr_x2apic(struct vcpu *v, uint32_t msr, uint64_t msr_content)
     return X86EMUL_OKAY;
 }
 
-static int vlapic_range(struct vcpu *v, unsigned long addr)
+static int cf_check vlapic_range(struct vcpu *v, unsigned long addr)
 {
     struct vlapic *vlapic = vcpu_vlapic(v);
     unsigned long offset  = addr - vlapic_base_address(vlapic);
diff --git a/xen/arch/x86/hvm/vmsi.c b/xen/arch/x86/hvm/vmsi.c
index 2889575a2035..d4a8c953e23f 100644
--- a/xen/arch/x86/hvm/vmsi.c
+++ b/xen/arch/x86/hvm/vmsi.c
@@ -211,8 +211,9 @@ static struct msi_desc *msixtbl_addr_to_desc(
     return NULL;
 }
 
-static int msixtbl_read(const struct hvm_io_handler *handler,
-                        uint64_t address, uint32_t len, uint64_t *pval)
+static int cf_check msixtbl_read(
+    const struct hvm_io_handler *handler, uint64_t address, uint32_t len,
+    uint64_t *pval)
 {
     unsigned long offset;
     struct msixtbl_entry *entry;
@@ -350,14 +351,15 @@ static int msixtbl_write(struct vcpu *v, unsigned long address,
     return r;
 }
 
-static int _msixtbl_write(const struct hvm_io_handler *handler,
-                          uint64_t address, uint32_t len, uint64_t val)
+static int cf_check _msixtbl_write(
+    const struct hvm_io_handler *handler, uint64_t address, uint32_t len,
+    uint64_t val)
 {
     return msixtbl_write(current, address, len, val);
 }
 
-static bool_t msixtbl_range(const struct hvm_io_handler *handler,
-                            const ioreq_t *r)
+static bool cf_check msixtbl_range(
+    const struct hvm_io_handler *handler, const ioreq_t *r)
 {
     struct vcpu *curr = current;
     unsigned long addr = r->addr;
diff --git a/xen/arch/x86/hvm/vpic.c b/xen/arch/x86/hvm/vpic.c
index 91c2c6983393..5d8ef259b710 100644
--- a/xen/arch/x86/hvm/vpic.c
+++ b/xen/arch/x86/hvm/vpic.c
@@ -351,7 +351,7 @@ static uint32_t vpic_ioport_read(struct hvm_hw_vpic *vpic, uint32_t addr)
     return vpic->imr;
 }
 
-static int vpic_intercept_pic_io(
+static int cf_check vpic_intercept_pic_io(
     int dir, unsigned int port, unsigned int bytes, uint32_t *val)
 {
     struct hvm_hw_vpic *vpic;
@@ -373,7 +373,7 @@ static int vpic_intercept_pic_io(
     return X86EMUL_OKAY;
 }
 
-static int vpic_intercept_elcr_io(
+static int cf_check vpic_intercept_elcr_io(
     int dir, unsigned int port, unsigned int bytes, uint32_t *val)
 {
     struct hvm_hw_vpic *vpic;
diff --git a/xen/arch/x86/include/asm/hvm/vioapic.h b/xen/arch/x86/include/asm/hvm/vioapic.h
index 36b64d20d60c..2944ec20dd53 100644
--- a/xen/arch/x86/include/asm/hvm/vioapic.h
+++ b/xen/arch/x86/include/asm/hvm/vioapic.h
@@ -66,7 +66,7 @@ void vioapic_irq_positive_edge(struct domain *d, unsigned int irq);
 void vioapic_update_EOI(struct domain *d, u8 vector);
 
 int vioapic_get_mask(const struct domain *d, unsigned int gsi);
-int vioapic_get_vector(const struct domain *d, unsigned int gsi);
+int cf_check vioapic_get_vector(const struct domain *d, unsigned int gsi);
 int vioapic_get_trigger_mode(const struct domain *d, unsigned int gsi);
 
 #endif /* __ASM_X86_HVM_VIOAPIC_H__ */
diff --git a/xen/drivers/passthrough/amd/iommu_guest.c b/xen/drivers/passthrough/amd/iommu_guest.c
index 361ff864d846..80a331f546ed 100644
--- a/xen/drivers/passthrough/amd/iommu_guest.c
+++ b/xen/drivers/passthrough/amd/iommu_guest.c
@@ -645,8 +645,8 @@ static uint64_t iommu_mmio_read64(struct guest_iommu *iommu,
     return val;
 }
 
-static int guest_iommu_mmio_read(struct vcpu *v, unsigned long addr,
-                                 unsigned int len, unsigned long *pval)
+static int cf_check guest_iommu_mmio_read(
+    struct vcpu *v, unsigned long addr, unsigned int len, unsigned long *pval)
 {
     struct guest_iommu *iommu = vcpu_iommu(v);
     unsigned long offset;
@@ -735,8 +735,8 @@ static void guest_iommu_mmio_write64(struct guest_iommu *iommu,
     }
 }
 
-static int guest_iommu_mmio_write(struct vcpu *v, unsigned long addr,
-                                  unsigned int len, unsigned long val)
+static int cf_check guest_iommu_mmio_write(
+    struct vcpu *v, unsigned long addr, unsigned int len, unsigned long val)
 {
     struct guest_iommu *iommu = vcpu_iommu(v);
     unsigned long offset;
@@ -819,7 +819,7 @@ static void guest_iommu_reg_init(struct guest_iommu *iommu)
     iommu->reg_ext_feature = ef;
 }
 
-static int guest_iommu_mmio_range(struct vcpu *v, unsigned long addr)
+static int cf_check guest_iommu_mmio_range(struct vcpu *v, unsigned long addr)
 {
     struct guest_iommu *iommu = vcpu_iommu(v);
 
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:06:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:06:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271718.466401 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb3g-00018C-LO; Mon, 14 Feb 2022 13:06:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271718.466401; Mon, 14 Feb 2022 13:06:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb3f-00012f-LZ; Mon, 14 Feb 2022 13:06:23 +0000
Received: by outflank-mailman (input) for mailman id 271718;
 Mon, 14 Feb 2022 13:06:21 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJb2k-0008IH-St
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:05:27 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c59298a3-8d96-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 14:05:25 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c59298a3-8d96-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644843925;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=+QYHYC1eoLvldjqb5KMKNFpB/QJHZdfvkMfW0IB8GJg=;
  b=dGvbwJFzOxIeHii8yWuBpkvNvhVzYnZ+oU13Iq9gSWMpQr2zNdIBaYQP
   /vkHN0FUCsVsBO0fvn4QRP3GsEjLwhDjRZcUJVaxVwKU2MCxoJWDQP0zR
   9IV3RRM1Z9gtFaiDfvmHUkpNX57OMSSl9HPtNyDy5N71Gwh3y1Gd3JWPm
   0=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: C6Sv2M/yMcWd5uk1UcVDDsDlml2D6fzDMx2LjXFX52Hu9QcWv5sN1dhPbLEi68L49qxmoEgCSk
 yvWMjaeEkbh7r1Pis63iSkFgz1w1dFHGKumlxMMtLzmsQV9fuWLDvBTZL56fVzCOyx49k8uWMc
 t5kkzd4P0s8gP/v/XGfuSa1ajMmeB2+iYoUKgyEQZ26NqWBgxFIImxEYGwni5cHzuQ8TUv+BZg
 SP16gzy3ciunaSBTwwOPWs+wgXEsNFMl1cxmM/iOT7lXFdcHHDcctELGf2Z9TksMuLV8BIS1Fe
 MGQCxQVVzbXcpKjIwtfoVggD
X-SBRS: 5.1
X-MesageID: 64149812
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:wPpoL6JAo3pq/N8yFE+R95IlxSXFcZb7ZxGr2PjKsXjdYENSgWBVy
 TAXDT+POvnZYjT2e412OtmzoB5SsJPSm95qTQJlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokcxIn5BC5C5xZVG/fjgqoHUVaiUakideSc+EH170Ug6x7Zg6mJVqYPR7z2l6
 IuaT/L3YDdJ6xYsWo7Dw/vewP/HlK2aVAIw5jTSV9gS1LPtvyB94KYkDbOwNxPFrrx8RYZWc
 QphIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbrGvaUXe345iXMfwZ3u7hB3OutpP0
 I1A7aecbj0nY4jKw9Q+UUFhRnQW0a1uoNcrIFC6uM2XiUbHb2Ht07NlC0Re0Y8wo7gtRzsUr
 LpBdW5LPkvra+GemdpXTsFFgMg5IdatF4QYonx6lhnSDOo8QICFSKLPjTNd9Gls35wfTa+ED
 yYfQQVvVRHjexkQBlNNT9Ewv9maiFDvbjIN/Tp5ooJoujOOnWSdyoPFINfTP9CHW8hRtkKZv
 X7duXT0BAkAM96SwibD9Wij7tIjhguiBthUTufhsKc33hvDnQT/FSH6S3P8hPOHkhazA+lzD
 HYapw8o9pgR9hSSG4yVswKDnFaIuRsVWtx1GuI86R2Qxqe83zt1FlToXRYaNoV46ZZeqSgCk
 wbQwoi3XWAHXKi9FCrFnop4uw9eLsT8wYUqQSYfBTUI7ND4yG3YpkKeF40zeEJZYzCcJN0R/
 9xohHVk71nwpZRSv0lewbwgq2jyzqUltiZvum3qspiZxg14fpW5QIej9ELW6/1NRK7AEAXd4
 yhUxpXGtbtUZX1oqMBqaL9TdIxFGt7faGGM6bKRN8VJG8uRF46LItkLvWAWyLZBOccYYz75C
 HI/SisKjKK/yECCNPctC6roUpxC5fG5SbzNC6CFBvITM8MZXFLWo0lTibu4gjmFuFIyips2J
 ZrzWZ/qVR72/4w8l2HoLwrcuJd2rh0DKZT7G8ylkUT9jOb2ibz8Ye5tDWZip9sRtMusyDg5O
 f4FXydT4xkAAuD4fAfN9osfcQIDIXQhXMikoM1LbO+TZAFhHTh5WfPWxLogfa1jnrhUybiUr
 i3sBBcAxQqtn2DDJCWLdmtnNOHlU6FgoC9pJicrJ1uphSQuON798KcFepIrVrA77+g/n+VsR
 vwIdpzYUPRCQzjK4RoHapz5oNAwfRinn1vWbSGkfCI+b9hrQAmQoo3oeQ7m9S8vCCurtJRh/
 +38h12DGZdaHlZsFsfbbv6r3midh3lFlbIgRVbML/lSZF7orNpgJRvug6JlOMoLMxjCmGeXj
 l7EHRcCqODRiIYp692V17ucpoKkHuYiTEpXG27XseS/OSXApzfxxIZBVKCDfCzHVXOy86KnP
 L0Hw/b5OfwBvVBLr4sjTOo7kfNgv4Pi9+1A0wBpPHTXdFD6WLpvL06P0dRLqqAQlKRSvhG7W
 x7X99RXUVlT1BgJzLLFyNIZU9m+
IronPort-HdrOrdr: A9a23:Qa61dqnU6+TUEIgrYkd11ElM9YjpDfIu3DAbv31ZSRFFG/Fxl6
 iV8sjztCWE8Qr5N0tBpTntAsW9qDbnhPtICOoqTNGftWvdyQiVxehZhOOIqVDd8m/Fh4pgPM
 9bAs9D4bbLbGSS4/yU3ODBKadD/OW6
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="64149812"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v2 50/70] x86/p2m: CFI hardening
Date: Mon, 14 Feb 2022 12:51:07 +0000
Message-ID: <20220214125127.17985-51-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

Control Flow Integrity schemes use toolchain and optionally hardware support
to help protect against call/jump/return oriented programming attacks.

Use cf_check to annotate function pointer targets for the toolchain.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
 xen/arch/x86/include/asm/p2m.h   |  4 ++--
 xen/arch/x86/mm/hap/hap.c        |  2 +-
 xen/arch/x86/mm/hap/nested_hap.c |  2 +-
 xen/arch/x86/mm/p2m-ept.c        | 32 +++++++++++++++-----------------
 xen/arch/x86/mm/p2m-pt.c         | 19 +++++++++----------
 5 files changed, 28 insertions(+), 31 deletions(-)

diff --git a/xen/arch/x86/include/asm/p2m.h b/xen/arch/x86/include/asm/p2m.h
index 6e2206874d62..787374426371 100644
--- a/xen/arch/x86/include/asm/p2m.h
+++ b/xen/arch/x86/include/asm/p2m.h
@@ -820,8 +820,8 @@ void np2m_flush_base(struct vcpu *v, unsigned long np2m_base);
 void hap_p2m_init(struct p2m_domain *p2m);
 void shadow_p2m_init(struct p2m_domain *p2m);
 
-void nestedp2m_write_p2m_entry_post(struct p2m_domain *p2m,
-                                    unsigned int oflags);
+void cf_check nestedp2m_write_p2m_entry_post(
+    struct p2m_domain *p2m, unsigned int oflags);
 
 /*
  * Alternate p2m: shadow p2m tables used for alternate memory views
diff --git a/xen/arch/x86/mm/hap/hap.c b/xen/arch/x86/mm/hap/hap.c
index 9d67a47f5fe9..c19e337d6585 100644
--- a/xen/arch/x86/mm/hap/hap.c
+++ b/xen/arch/x86/mm/hap/hap.c
@@ -778,7 +778,7 @@ static void cf_check hap_update_paging_modes(struct vcpu *v)
     put_gfn(d, cr3_gfn);
 }
 
-static void
+static void cf_check
 hap_write_p2m_entry_post(struct p2m_domain *p2m, unsigned int oflags)
 {
     struct domain *d = p2m->domain;
diff --git a/xen/arch/x86/mm/hap/nested_hap.c b/xen/arch/x86/mm/hap/nested_hap.c
index d8a7b3b40167..dbe5ad23a112 100644
--- a/xen/arch/x86/mm/hap/nested_hap.c
+++ b/xen/arch/x86/mm/hap/nested_hap.c
@@ -71,7 +71,7 @@
 /*        NESTED VIRT P2M FUNCTIONS         */
 /********************************************/
 
-void
+void cf_check
 nestedp2m_write_p2m_entry_post(struct p2m_domain *p2m, unsigned int oflags)
 {
     if ( oflags & _PAGE_PRESENT )
diff --git a/xen/arch/x86/mm/p2m-ept.c b/xen/arch/x86/mm/p2m-ept.c
index a8a6ad629528..70a401c3a7ea 100644
--- a/xen/arch/x86/mm/p2m-ept.c
+++ b/xen/arch/x86/mm/p2m-ept.c
@@ -624,7 +624,7 @@ int epte_get_entry_emt(struct domain *d, gfn_t gfn, mfn_t mfn,
  * - zero if no adjustment was done,
  * - a positive value if at least one adjustment was done.
  */
-static int resolve_misconfig(struct p2m_domain *p2m, unsigned long gfn)
+static int cf_check resolve_misconfig(struct p2m_domain *p2m, unsigned long gfn)
 {
     struct ept_data *ept = &p2m->ept;
     unsigned int level = ept->wl;
@@ -793,7 +793,7 @@ bool_t ept_handle_misconfig(uint64_t gpa)
  *
  * Returns: 0 for success, -errno for failure
  */
-static int
+static int cf_check
 ept_set_entry(struct p2m_domain *p2m, gfn_t gfn_, mfn_t mfn,
               unsigned int order, p2m_type_t p2mt, p2m_access_t p2ma,
               int sve)
@@ -1002,10 +1002,9 @@ ept_set_entry(struct p2m_domain *p2m, gfn_t gfn_, mfn_t mfn,
 }
 
 /* Read ept p2m entries */
-static mfn_t ept_get_entry(struct p2m_domain *p2m,
-                           gfn_t gfn_, p2m_type_t *t, p2m_access_t* a,
-                           p2m_query_t q, unsigned int *page_order,
-                           bool_t *sve)
+static mfn_t cf_check ept_get_entry(
+    struct p2m_domain *p2m, gfn_t gfn_, p2m_type_t *t, p2m_access_t *a,
+    p2m_query_t q, unsigned int *page_order, bool *sve)
 {
     ept_entry_t *table =
         map_domain_page(pagetable_get_mfn(p2m_get_pagetable(p2m)));
@@ -1165,8 +1164,8 @@ void ept_walk_table(struct domain *d, unsigned long gfn)
     return;
 }
 
-static void ept_change_entry_type_global(struct p2m_domain *p2m,
-                                         p2m_type_t ot, p2m_type_t nt)
+static void cf_check ept_change_entry_type_global(
+    struct p2m_domain *p2m, p2m_type_t ot, p2m_type_t nt)
 {
     unsigned long mfn = p2m->ept.mfn;
 
@@ -1177,10 +1176,9 @@ static void ept_change_entry_type_global(struct p2m_domain *p2m,
         ept_sync_domain(p2m);
 }
 
-static int ept_change_entry_type_range(struct p2m_domain *p2m,
-                                       p2m_type_t ot, p2m_type_t nt,
-                                       unsigned long first_gfn,
-                                       unsigned long last_gfn)
+static int cf_check ept_change_entry_type_range(
+    struct p2m_domain *p2m, p2m_type_t ot, p2m_type_t nt,
+    unsigned long first_gfn, unsigned long last_gfn)
 {
     unsigned int i, wl = p2m->ept.wl;
     unsigned long mask = (1 << EPT_TABLE_ORDER) - 1;
@@ -1224,7 +1222,7 @@ static int ept_change_entry_type_range(struct p2m_domain *p2m,
     return rc < 0 ? rc : 0;
 }
 
-static void ept_memory_type_changed(struct p2m_domain *p2m)
+static void cf_check ept_memory_type_changed(struct p2m_domain *p2m)
 {
     unsigned long mfn = p2m->ept.mfn;
 
@@ -1283,7 +1281,7 @@ void ept_sync_domain(struct p2m_domain *p2m)
     ept_sync_domain_mask(p2m, d->dirty_cpumask);
 }
 
-static void ept_tlb_flush(struct p2m_domain *p2m)
+static void cf_check ept_tlb_flush(struct p2m_domain *p2m)
 {
     ept_sync_domain_mask(p2m, p2m->domain->dirty_cpumask);
 }
@@ -1346,7 +1344,7 @@ static void ept_disable_pml(struct p2m_domain *p2m)
     vmx_domain_update_eptp(p2m->domain);
 }
 
-static void ept_enable_hardware_log_dirty(struct p2m_domain *p2m)
+static void cf_check ept_enable_hardware_log_dirty(struct p2m_domain *p2m)
 {
     struct p2m_domain *hostp2m = p2m_get_hostp2m(p2m->domain);
 
@@ -1355,7 +1353,7 @@ static void ept_enable_hardware_log_dirty(struct p2m_domain *p2m)
     p2m_unlock(hostp2m);
 }
 
-static void ept_disable_hardware_log_dirty(struct p2m_domain *p2m)
+static void cf_check ept_disable_hardware_log_dirty(struct p2m_domain *p2m)
 {
     struct p2m_domain *hostp2m = p2m_get_hostp2m(p2m->domain);
 
@@ -1364,7 +1362,7 @@ static void ept_disable_hardware_log_dirty(struct p2m_domain *p2m)
     p2m_unlock(hostp2m);
 }
 
-static void ept_flush_pml_buffers(struct p2m_domain *p2m)
+static void cf_check ept_flush_pml_buffers(struct p2m_domain *p2m)
 {
     /* Domain must have been paused */
     ASSERT(atomic_read(&p2m->domain->pause_count));
diff --git a/xen/arch/x86/mm/p2m-pt.c b/xen/arch/x86/mm/p2m-pt.c
index ef3f8e02a415..eaba2b0fb4e6 100644
--- a/xen/arch/x86/mm/p2m-pt.c
+++ b/xen/arch/x86/mm/p2m-pt.c
@@ -399,7 +399,7 @@ static int p2m_pt_set_recalc_range(struct p2m_domain *p2m,
  * GFN. Propagate the re-calculation flag down to the next page table level
  * for entries not involved in the translation of the given GFN.
  */
-static int do_recalc(struct p2m_domain *p2m, unsigned long gfn)
+static int cf_check do_recalc(struct p2m_domain *p2m, unsigned long gfn)
 {
     void *table;
     unsigned long gfn_remainder = gfn;
@@ -573,7 +573,7 @@ static void check_entry(mfn_t mfn, p2m_type_t new, p2m_type_t old,
 }
 
 /* Returns: 0 for success, -errno for failure */
-static int
+static int cf_check
 p2m_pt_set_entry(struct p2m_domain *p2m, gfn_t gfn_, mfn_t mfn,
                  unsigned int page_order, p2m_type_t p2mt, p2m_access_t p2ma,
                  int sve)
@@ -774,7 +774,7 @@ p2m_pt_set_entry(struct p2m_domain *p2m, gfn_t gfn_, mfn_t mfn,
     return rc;
 }
 
-static mfn_t
+static mfn_t cf_check
 p2m_pt_get_entry(struct p2m_domain *p2m, gfn_t gfn_,
                  p2m_type_t *t, p2m_access_t *a, p2m_query_t q,
                  unsigned int *page_order, bool_t *sve)
@@ -943,8 +943,8 @@ p2m_pt_get_entry(struct p2m_domain *p2m, gfn_t gfn_,
     return (p2m_is_valid(*t) || p2m_is_any_ram(*t)) ? mfn : INVALID_MFN;
 }
 
-static void p2m_pt_change_entry_type_global(struct p2m_domain *p2m,
-                                            p2m_type_t ot, p2m_type_t nt)
+static void cf_check p2m_pt_change_entry_type_global(
+    struct p2m_domain *p2m, p2m_type_t ot, p2m_type_t nt)
 {
     l1_pgentry_t *tab;
     unsigned long gfn = 0;
@@ -983,10 +983,9 @@ static void p2m_pt_change_entry_type_global(struct p2m_domain *p2m,
          guest_flush_tlb_mask(d, d->dirty_cpumask);
 }
 
-static int p2m_pt_change_entry_type_range(struct p2m_domain *p2m,
-                                          p2m_type_t ot, p2m_type_t nt,
-                                          unsigned long first_gfn,
-                                          unsigned long last_gfn)
+static int cf_check p2m_pt_change_entry_type_range(
+    struct p2m_domain *p2m, p2m_type_t ot, p2m_type_t nt,
+    unsigned long first_gfn, unsigned long last_gfn)
 {
     unsigned long mask = (1 << PAGETABLE_ORDER) - 1;
     unsigned int i;
@@ -1025,7 +1024,7 @@ static int p2m_pt_change_entry_type_range(struct p2m_domain *p2m,
 }
 
 #if P2M_AUDIT
-static long p2m_pt_audit_p2m(struct p2m_domain *p2m)
+static long cf_check p2m_pt_audit_p2m(struct p2m_domain *p2m)
 {
     unsigned long entry_count = 0, pmbad = 0;
     unsigned long mfn, gfn, m2pfn;
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:06:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:06:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271719.466408 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb3i-0001TO-BV; Mon, 14 Feb 2022 13:06:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271719.466408; Mon, 14 Feb 2022 13:06:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb3h-0001PB-Eu; Mon, 14 Feb 2022 13:06:25 +0000
Received: by outflank-mailman (input) for mailman id 271719;
 Mon, 14 Feb 2022 13:06:22 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJb2y-0008IH-J3
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:05:40 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ce48bf03-8d96-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 14:05:39 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ce48bf03-8d96-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644843938;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=tpbBQsuMzZyq6LzFUh1145Bs01ZMNWBvog9FT8SWVF0=;
  b=RmJHp55foSegsmV2b9mRd/BDKgcL3Mea9FQmwQwdx/ifgMiY/U9WUrvF
   MNuRLtM4cDtOoLXGuybezIIBY2LB+HIZ6x47ZWsDFifI4prdOLDjd1yqg
   T3PGZ3TmvFzENvqbeNfHcIB/g+n+ddW4W1CU9H4O1jg/CO5z7CCrkOgL8
   Q=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: 4q+4l8ZC+4wl7Vru7sNrarw+ORF5dGXlfgKV9IUx8+NDQ86Nwv58/Pugh9w6SNG5x2bzuj1Sp1
 BcS0Frn3gJhOxcUdHnLTykY1vCz5Jo5YJIjM1UMm9mPqsKcQqbAagWxdV2cKwIeGXrAGGQMcf5
 Rxd2RDa2ih/QQlXz0NmK5eitb+1754V8qOS0YnjxUYN7QdmZ+q3fHj9Epeb1Zjlz5qfy5wIfH3
 RnB+SbCt4GKFEdqK1HNqUQLmZckI+Fv35yvm22/rEfDUY6d7T4S4QAzrkuUYoeoJ6dxRlbF1fC
 SCUT8Mn7Kjr2aGHRg9LmgtHR
X-SBRS: 5.1
X-MesageID: 63592646
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Hgl8Xq8MsvGHeZib+lalDrUDnnmTJUtcMsCJ2f8bNWPcYEJGY0x3m
 zZMDzjQa/eMMTDzftkia9ux9kMAuJOHyIJqTwFqqis8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhFWeIdA970Ug5w7Rg3tYx6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPht2
 PZEq7KJSzwyZJPsletefjdpAjlXaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguwKKsXxMZxZkXZn1TzDVt4tQIzZQrWM7thdtNs1rp4VQKeEO
 ZZHAdZpRFfRYTd3HFsGMZYBhr7rmkanTTxokU3A8MLb5ECMlVcsgdABKuH9atGMAMlYgEucj
 mbH5HjiRAEXMsSFzjiI+W7qgfXA9R4XQ6pLSuf+rKQzxgTOmCpDU3X6SGdXv9Glmm23RfxmK
 XcPoBQOoKdx2WKaX8HUCkjQTGG/gjYQXN9ZEusf4Q6Ly7bJ7wvxOlXoXgKte/R96pZoGGVCO
 kuh2oqwWGcx6OH9pWe1q+/MxQ5eLxT5OoPricUsaQIeq+fur4go5v4kZoYySfXl5jEZ9NyZ/
 txrkMTcr+hJ5SLo///ilbwiv95LjsKXJjPZHi2NAgqYAvpRPeZJnbCA51nB9upnJ42EVFSHt
 3Vss5HAsLxRXcHQyXTUG79l8FSVCxGtamO0vLKSN8N5q2TFF4CLIei8Hw2S1G82a51ZKFcFk
 WfYuB9L5Y87AZdZRfQfXm5FMOxzlfKIPY28Dpj8N4MSCrAsJF7v1Hw/Pia4gjGy+HXAZIliY
 P93h+73Vi1EYUmmpRLrL9ogPUgDmHxvmzOLHcqjp/lluJLHDEOopX4+GAPmRogEAGms+W05K
 v5TaJmHzQtxSur7bnWF+IIfNwlSf3M6GYr3u4pccevaelhqH2QoCvnwx7I9etM6w/QJx7mQp
 nztCFVFzFffhGHcLVnYYH5Ud76yD410qmg2PHJwMA/wiWQje4um8IwWa4AzIes87OVmwPMtF
 6sFdsyMD+5hUDPC/zhBP5DxoJY7LEaghB6UPjrjaz86JsYySwvM897iXw3u6ChRUXbn6Zpg+
 +Wtj1qJT4ACSgJuCNftRMiul17h72IAnO9SXlfTJoUBckvb74U3eTf6ieU6Ip9QJEyblCeaz
 QufHTwRufLJ/90u6NDMiK2J89WpHu95EhYIFmXX9+/rZyzT/27lyo5cSueYOzvaUTqsqqmlY
 OxUydD6MeEGwwkW49YtTe4zwPJs/cbrqp9b0h9gTSfCYFmcA799JmWLgJtUvapXy74F4Qa7V
 ypjIDWB1Wll7C89LGMsGQ==
IronPort-HdrOrdr: A9a23:7NURPq2rKbbF8K3JVS1OHAqjBLAkLtp133Aq2lEZdPRUGvb3qy
 nOpoVj6faaslYssR0b9exofZPwJE80lqQFh7X5X43SPzUO0VHAROoJgLcKgQeQfxEWntQtsp
 uIGJIeNDSfNzdHZL7BkWuFL+o=
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="63592646"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v2 52/70] x86/apei: CFI hardening
Date: Mon, 14 Feb 2022 12:51:09 +0000
Message-ID: <20220214125127.17985-53-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

Control Flow Integrity schemes use toolchain and optionally hardware support
to help protect against call/jump/return oriented programming attacks.

Use cf_check to annotate function pointer targets for the toolchain.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
 xen/drivers/acpi/apei/apei-base.c     | 32 ++++++++++----------
 xen/drivers/acpi/apei/apei-internal.h | 20 ++++++------
 xen/drivers/acpi/apei/erst.c          | 57 +++++++++++++++++------------------
 3 files changed, 54 insertions(+), 55 deletions(-)

diff --git a/xen/drivers/acpi/apei/apei-base.c b/xen/drivers/acpi/apei/apei-base.c
index 6f81e7fa366a..de75c1cef992 100644
--- a/xen/drivers/acpi/apei/apei-base.c
+++ b/xen/drivers/acpi/apei/apei-base.c
@@ -80,8 +80,8 @@ int __apei_exec_read_register(struct acpi_whea_header *entry, u64 *val)
 	return 0;
 }
 
-int apei_exec_read_register(struct apei_exec_context *ctx,
-			    struct acpi_whea_header *entry)
+int cf_check apei_exec_read_register(
+	struct apei_exec_context *ctx, struct acpi_whea_header *entry)
 {
 	int rc;
 	u64 val = 0;
@@ -94,8 +94,8 @@ int apei_exec_read_register(struct apei_exec_context *ctx,
 	return 0;
 }
 
-int apei_exec_read_register_value(struct apei_exec_context *ctx,
-				  struct acpi_whea_header *entry)
+int cf_check apei_exec_read_register_value(
+	struct apei_exec_context *ctx, struct acpi_whea_header *entry)
 {
 	int rc;
 
@@ -126,14 +126,14 @@ int __apei_exec_write_register(struct acpi_whea_header *entry, u64 val)
 	return rc;
 }
 
-int apei_exec_write_register(struct apei_exec_context *ctx,
-			     struct acpi_whea_header *entry)
+int cf_check apei_exec_write_register(
+	struct apei_exec_context *ctx, struct acpi_whea_header *entry)
 {
 	return __apei_exec_write_register(entry, ctx->value);
 }
 
-int apei_exec_write_register_value(struct apei_exec_context *ctx,
-				   struct acpi_whea_header *entry)
+int cf_check apei_exec_write_register_value(
+	struct apei_exec_context *ctx, struct acpi_whea_header *entry)
 {
 	int rc;
 
@@ -143,8 +143,8 @@ int apei_exec_write_register_value(struct apei_exec_context *ctx,
 	return rc;
 }
 
-int apei_exec_noop(struct apei_exec_context *ctx,
-		   struct acpi_whea_header *entry)
+int cf_check apei_exec_noop(
+	struct apei_exec_context *ctx, struct acpi_whea_header *entry)
 {
 	return 0;
 }
@@ -230,9 +230,9 @@ static int __init apei_exec_for_each_entry(struct apei_exec_context *ctx,
 	return 0;
 }
 
-static int __init pre_map_gar_callback(struct apei_exec_context *ctx,
-				       struct acpi_whea_header *entry,
-				       void *data)
+static int __init cf_check pre_map_gar_callback(
+	struct apei_exec_context *ctx, struct acpi_whea_header *entry,
+	void *data)
 {
 	u8 ins = entry->instruction;
 
@@ -259,9 +259,9 @@ int __init apei_exec_pre_map_gars(struct apei_exec_context *ctx)
 	return rc;
 }
 
-static int __init post_unmap_gar_callback(struct apei_exec_context *ctx,
-					  struct acpi_whea_header *entry,
-					  void *data)
+static int __init cf_check post_unmap_gar_callback(
+	struct apei_exec_context *ctx, struct acpi_whea_header *entry,
+	void *data)
 {
 	u8 ins = entry->instruction;
 
diff --git a/xen/drivers/acpi/apei/apei-internal.h b/xen/drivers/acpi/apei/apei-internal.h
index b813d55b92a9..360e94b9c877 100644
--- a/xen/drivers/acpi/apei/apei-internal.h
+++ b/xen/drivers/acpi/apei/apei-internal.h
@@ -68,16 +68,16 @@ static inline int apei_exec_run_optional(struct apei_exec_context *ctx, u8 actio
 
 int __apei_exec_read_register(struct acpi_whea_header *entry, u64 *val);
 int __apei_exec_write_register(struct acpi_whea_header *entry, u64 val);
-int apei_exec_read_register(struct apei_exec_context *ctx,
-			    struct acpi_whea_header *entry);
-int apei_exec_read_register_value(struct apei_exec_context *ctx,
-				  struct acpi_whea_header *entry);
-int apei_exec_write_register(struct apei_exec_context *ctx,
-			     struct acpi_whea_header *entry);
-int apei_exec_write_register_value(struct apei_exec_context *ctx,
-				   struct acpi_whea_header *entry);
-int apei_exec_noop(struct apei_exec_context *ctx,
-		   struct acpi_whea_header *entry);
+int cf_check apei_exec_read_register(
+	struct apei_exec_context *ctx, struct acpi_whea_header *entry);
+int cf_check apei_exec_read_register_value(
+	struct apei_exec_context *ctx, struct acpi_whea_header *entry);
+int cf_check apei_exec_write_register(
+	struct apei_exec_context *ctx, struct acpi_whea_header *entry);
+int cf_check apei_exec_write_register_value(
+	struct apei_exec_context *ctx, struct acpi_whea_header *entry);
+int cf_check apei_exec_noop(
+	struct apei_exec_context *ctx, struct acpi_whea_header *entry);
 int apei_exec_pre_map_gars(struct apei_exec_context *ctx);
 int apei_exec_post_unmap_gars(struct apei_exec_context *ctx);
 
diff --git a/xen/drivers/acpi/apei/erst.c b/xen/drivers/acpi/apei/erst.c
index c5df512b9838..40d8f00270d0 100644
--- a/xen/drivers/acpi/apei/erst.c
+++ b/xen/drivers/acpi/apei/erst.c
@@ -114,40 +114,40 @@ static int erst_timedout(u64 *t, u64 spin_unit)
 	return 0;
 }
 
-static int erst_exec_load_var1(struct apei_exec_context *ctx,
-			       struct acpi_whea_header *entry)
+static int cf_check erst_exec_load_var1(
+	struct apei_exec_context *ctx, struct acpi_whea_header *entry)
 {
 	return __apei_exec_read_register(entry, &ctx->var1);
 }
 
-static int erst_exec_load_var2(struct apei_exec_context *ctx,
-			       struct acpi_whea_header *entry)
+static int cf_check erst_exec_load_var2(
+	struct apei_exec_context *ctx, struct acpi_whea_header *entry)
 {
 	return __apei_exec_read_register(entry, &ctx->var2);
 }
 
-static int erst_exec_store_var1(struct apei_exec_context *ctx,
-				struct acpi_whea_header *entry)
+static int cf_check erst_exec_store_var1(
+	struct apei_exec_context *ctx, struct acpi_whea_header *entry)
 {
 	return __apei_exec_write_register(entry, ctx->var1);
 }
 
-static int erst_exec_add(struct apei_exec_context *ctx,
-			 struct acpi_whea_header *entry)
+static int cf_check erst_exec_add(
+	struct apei_exec_context *ctx, struct acpi_whea_header *entry)
 {
 	ctx->var1 += ctx->var2;
 	return 0;
 }
 
-static int erst_exec_subtract(struct apei_exec_context *ctx,
-			      struct acpi_whea_header *entry)
+static int cf_check erst_exec_subtract(
+	struct apei_exec_context *ctx, struct acpi_whea_header *entry)
 {
 	ctx->var1 -= ctx->var2;
 	return 0;
 }
 
-static int erst_exec_add_value(struct apei_exec_context *ctx,
-			       struct acpi_whea_header *entry)
+static int cf_check erst_exec_add_value(
+	struct apei_exec_context *ctx, struct acpi_whea_header *entry)
 {
 	int rc;
 	u64 val;
@@ -160,8 +160,8 @@ static int erst_exec_add_value(struct apei_exec_context *ctx,
 	return rc;
 }
 
-static int erst_exec_subtract_value(struct apei_exec_context *ctx,
-				    struct acpi_whea_header *entry)
+static int cf_check erst_exec_subtract_value(
+	struct apei_exec_context *ctx, struct acpi_whea_header *entry)
 {
 	int rc;
 	u64 val;
@@ -174,8 +174,8 @@ static int erst_exec_subtract_value(struct apei_exec_context *ctx,
 	return rc;
 }
 
-static int erst_exec_stall(struct apei_exec_context *ctx,
-			   struct acpi_whea_header *entry)
+static int cf_check erst_exec_stall(
+	struct apei_exec_context *ctx, struct acpi_whea_header *entry)
 {
 	udelay((ctx->var1 > FIRMWARE_MAX_STALL) ? 
 			FIRMWARE_MAX_STALL : 
@@ -183,8 +183,8 @@ static int erst_exec_stall(struct apei_exec_context *ctx,
 	return 0;
 }
 
-static int erst_exec_stall_while_true(struct apei_exec_context *ctx,
-				      struct acpi_whea_header *entry)
+static int cf_check erst_exec_stall_while_true(
+	struct apei_exec_context *ctx, struct acpi_whea_header *entry)
 {
 	int rc;
 	u64 val;
@@ -205,9 +205,8 @@ static int erst_exec_stall_while_true(struct apei_exec_context *ctx,
 	return 0;
 }
 
-static int erst_exec_skip_next_instruction_if_true(
-	struct apei_exec_context *ctx,
-	struct acpi_whea_header *entry)
+static int cf_check erst_exec_skip_next_instruction_if_true(
+	struct apei_exec_context *ctx, struct acpi_whea_header *entry)
 {
 	int rc;
 	u64 val;
@@ -223,27 +222,27 @@ static int erst_exec_skip_next_instruction_if_true(
 	return 0;
 }
 
-static int erst_exec_goto(struct apei_exec_context *ctx,
-			  struct acpi_whea_header *entry)
+static int cf_check erst_exec_goto(
+	struct apei_exec_context *ctx, struct acpi_whea_header *entry)
 {
 	ctx->ip = ctx->value;
 	return APEI_EXEC_SET_IP;
 }
 
-static int erst_exec_set_src_address_base(struct apei_exec_context *ctx,
-					  struct acpi_whea_header *entry)
+static int cf_check erst_exec_set_src_address_base(
+	struct apei_exec_context *ctx, struct acpi_whea_header *entry)
 {
 	return __apei_exec_read_register(entry, &ctx->src_base);
 }
 
-static int erst_exec_set_dst_address_base(struct apei_exec_context *ctx,
-					  struct acpi_whea_header *entry)
+static int cf_check erst_exec_set_dst_address_base(
+	struct apei_exec_context *ctx, struct acpi_whea_header *entry)
 {
 	return __apei_exec_read_register(entry, &ctx->dst_base);
 }
 
-static int erst_exec_move_data(struct apei_exec_context *ctx,
-			       struct acpi_whea_header *entry)
+static int cf_check erst_exec_move_data(
+	struct apei_exec_context *ctx, struct acpi_whea_header *entry)
 {
 	int rc;
 	u64 offset;
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:06:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:06:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271723.466430 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb3n-0002if-Sz; Mon, 14 Feb 2022 13:06:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271723.466430; Mon, 14 Feb 2022 13:06:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb3m-0002dA-Jm; Mon, 14 Feb 2022 13:06:30 +0000
Received: by outflank-mailman (input) for mailman id 271723;
 Mon, 14 Feb 2022 13:06:28 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJb2h-00023t-4r
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:05:23 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c2e7a5a7-8d96-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 14:05:21 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c2e7a5a7-8d96-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644843922;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=QPTLA3fxBXu+aWVC9A50VpUZzEOTsG18u0DPp6i34Rw=;
  b=GSed5NuU4e7fyLn0FMMiVRKkmFUBsHkcWiGsNsy0ZBSaAUBGdEl/TjYZ
   f4G2yyGAFgMANxZ/q07xVsOUoMOE03VS61qJjgZMiRoQpRjKAuqGROqR/
   CNBQoC9SPSvTC7g1lfAoQGSnlcCHdEYuOrSXQYE+YGWH7HkLENkK32xB1
   s=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: c2M73LM69pIwwg1qbCGadoc2ajN9nWF7fZKXxFINZQUIpiechXqiAM9dhGJRicOlH0lNnjKFUQ
 uRNM54fdc3VLddtTFmb1I3uw+xRbmLH+N3tsIZZyCG2VaLCTQ1miqgwmvPZ0J0RSYQLeqINKjW
 /iAsNvjfnQFuzqBsvL97tC4RpaIEBEJU8jaIgQGLTVsvmmofbjewZ/5gnQklSp9gPvcsDymhVj
 GBu4iqutX8ozgWDIl5uHZJfmxUzlIdtgsuPl5sUCoEYq4uaNcVzAeioK2v+5Cg16zFWHUa5uMy
 MyI7uxoZD3JGT23iz1kxgoLg
X-SBRS: 5.1
X-MesageID: 64149399
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:NrpN56M6BtRU0fbvrR27kMFynXyQoLVcMsEvi/4bfWQNrUon1jAEy
 zRNCj2Da/+IZ2unetwiPN7j9U8F6pPRyt5gGQto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6UUsxNbVU8En1500s/w7dRbrNA2rBVPSvc4
 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq
 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYo2WQrs8ux
 5IQjIyPFAwXObWTwuENXzANRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs
 6VFdnZdNXhvhMrvqF6/YsBqit4uM4/AO4QHt2s75TrYEewnUdbIRKCiCdpwgmtp2pEVTKe2i
 8wxZytwSyqZTx1zak4uM5U9oqCL2mLEbGgNwL6SjfVuuDWCpOBr65D9PdyQdtGUSMF9mkeDu
 nmA72n/GgsdNtGU1XyC6H3EuwPUtXqlAsRITuT+r6M0xg3IroAONPEIfQuikObmhQnjYsJgd
 kcq/TJx960i+GX+G7ERQCaEiHKDuxcdXf9ZHOs79ByBx8Lo3uqJOoQXZmUfMYJ77afaURRvj
 wbUxI2xWVSDpZXIESr1y1uCkd+l1cH5x0cmbDRMcwYK6sKLTGob3kOWFYYL/EJYY7TI9dDML
 9Ki8XJWa1Y715djO0CHEbfv2WzEm3QxZlRpjjg7p0r8hu+DWKarZpaz9X/Q5utaIYCSQzGp5
 SZYx5fOvL1TVcjWzkRhpdnh+5nzuZ643MD02wYzT/HNCRzxk5JcQWygyG4nfxo4Wir1UTTof
 FXSqWtsCGx7ZxOXgVtMS9vpUawClPG4ffy8D6y8RoceM/BZKV7clAkzNBH44owYuBV1+U3JE
 czAKpjE4LdzIfkP8QdasM9Dje51lnhmnzu7qFKS503P7IdyrUW9Ed8tWGZipMhghE9diAmKo
 dtZKeWQzBBTDL/3biXNqNZBJlEWN3krQ5vxrpUPJOKEJwNnHkAnCuPQnux9K9A0wfwNm7ea5
 Gy5V29Z1EH72S/NJzKVZy0xc7joR5t+8y42ZHR+IVay1nE/So+z96NDJYAvdLwq+bU7n/55R
 vUIYeuaBfFLRmiV8jgRd8Cl/odjaA6qlUSFOC/8OGozeJtpRgro/N74f1SwqHlSX3Tv7cZn+
 u+uzALWR5YHVj9ONseOZaL91U61sFgchPl2AxnCLO5MdRi+64NtMSHw0KM6epleNRXZyzKG/
 A+KGhNE9/LVqoo4/dSV16CJq4ClT7l3EkZARjSJ6L+3MW/R/3a5wJ8GW+GNJGiPWGTx8aSkR
 ONU0/Cjb6FXwAcU69JxQ+Rx0KYzx9rzvLsLnA1rEULCY0mvFr49cGKN2tNCt/EVy7JU0edst
 pljJjWO1W21Bf7Y
IronPort-HdrOrdr: A9a23:qibe6KHniW4PmsTmpLqE6seALOsnbusQ8zAXP0AYc3Jom62j5r
 mTdZsgtSMc5Ax8ZJhko6HkBEDiewK7yXcW2/hzAV7KZmCP0wHEEGgh1/qH/9SJIVyYygc378
 ZdmsZFZ+EYdWIK7/rH3A==
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="64149399"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v2 41/70] x86/quirks: CFI hardening
Date: Mon, 14 Feb 2022 12:50:58 +0000
Message-ID: <20220214125127.17985-42-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

Control Flow Integrity schemes use toolchain and optionally hardware support
to help protect against call/jump/return oriented programming attacks.

Use cf_check to annotate function pointer targets for the toolchain.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
 xen/arch/x86/dmi_scan.c               | 10 +++++-----
 xen/arch/x86/hvm/quirks.c             |  2 +-
 xen/arch/x86/shutdown.c               |  2 +-
 xen/arch/x86/x86_64/mmconfig-shared.c |  8 ++++----
 4 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/xen/arch/x86/dmi_scan.c b/xen/arch/x86/dmi_scan.c
index d27cd3450a29..81f80c053a7a 100644
--- a/xen/arch/x86/dmi_scan.c
+++ b/xen/arch/x86/dmi_scan.c
@@ -476,7 +476,7 @@ static void __init dmi_save_ident(const struct dmi_header *dm, int slot, int str
 #define NO_MATCH	{ DMI_NONE, NULL}
 #define MATCH		DMI_MATCH
 
-static int __init ich10_bios_quirk(const struct dmi_system_id *d)
+static int __init cf_check ich10_bios_quirk(const struct dmi_system_id *d)
 {
     u32 port, smictl;
 
@@ -499,14 +499,14 @@ static int __init ich10_bios_quirk(const struct dmi_system_id *d)
     return 0;
 }
 
-static __init int reset_videomode_after_s3(const struct dmi_blacklist *d)
+static __init int cf_check reset_videomode_after_s3(const struct dmi_blacklist *d)
 {
 	/* See wakeup.S */
 	acpi_video_flags |= 2;
 	return 0;
 }
 
-static __init int dmi_disable_acpi(const struct dmi_blacklist *d)
+static __init int cf_check dmi_disable_acpi(const struct dmi_blacklist *d)
 { 
 	if (!acpi_force) { 
 		printk(KERN_NOTICE "%s detected: acpi off\n",d->ident);
@@ -521,7 +521,7 @@ static __init int dmi_disable_acpi(const struct dmi_blacklist *d)
 /*
  * Limit ACPI to CPU enumeration for HT
  */
-static __init int force_acpi_ht(const struct dmi_blacklist *d)
+static __init int cf_check force_acpi_ht(const struct dmi_blacklist *d)
 { 
 	if (!acpi_force) { 
 		printk(KERN_NOTICE "%s detected: force use of acpi=ht\n", d->ident);
@@ -650,7 +650,7 @@ static const struct dmi_blacklist __initconstrel dmi_blacklist[] = {
  *	out of here.
  */
 
-static void __init dmi_decode(const struct dmi_header *dm)
+static void __init cf_check dmi_decode(const struct dmi_header *dm)
 {
 #ifdef DMI_DEBUG
 	const uint8_t *data = (const void *)dm;
diff --git a/xen/arch/x86/hvm/quirks.c b/xen/arch/x86/hvm/quirks.c
index 917356b1312c..2adab1f4b84b 100644
--- a/xen/arch/x86/hvm/quirks.c
+++ b/xen/arch/x86/hvm/quirks.c
@@ -25,7 +25,7 @@
 s8 __read_mostly hvm_port80_allowed = -1;
 boolean_param("hvm_port80", hvm_port80_allowed);
 
-static int __init dmi_hvm_deny_port80(const struct dmi_system_id *id)
+static int __init cf_check dmi_hvm_deny_port80(const struct dmi_system_id *id)
 {
     printk(XENLOG_WARNING "%s: port 0x80 access %s allowed for HVM guests\n",
            id->ident, hvm_port80_allowed > 0 ? "forcibly" : "not");
diff --git a/xen/arch/x86/shutdown.c b/xen/arch/x86/shutdown.c
index 30985d36a612..7619544d14da 100644
--- a/xen/arch/x86/shutdown.c
+++ b/xen/arch/x86/shutdown.c
@@ -158,7 +158,7 @@ static void default_reboot_type(void)
         reboot_type = BOOT_ACPI;
 }
 
-static int __init override_reboot(const struct dmi_system_id *d)
+static int __init cf_check override_reboot(const struct dmi_system_id *d)
 {
     enum reboot_type type = (long)d->driver_data;
 
diff --git a/xen/arch/x86/x86_64/mmconfig-shared.c b/xen/arch/x86/x86_64/mmconfig-shared.c
index 2fa7f3f0bc4b..74b22b71a19c 100644
--- a/xen/arch/x86/x86_64/mmconfig-shared.c
+++ b/xen/arch/x86/x86_64/mmconfig-shared.c
@@ -62,7 +62,7 @@ static int __init cf_check parse_mmcfg(const char *s)
 }
 custom_param("mmcfg", parse_mmcfg);
 
-static const char __init *pci_mmcfg_e7520(void)
+static const char *__init cf_check pci_mmcfg_e7520(void)
 {
     u32 win;
     win = pci_conf_read16(PCI_SBDF(0, 0, 0, 0), 0xce);
@@ -84,7 +84,7 @@ static const char __init *pci_mmcfg_e7520(void)
     return "Intel Corporation E7520 Memory Controller Hub";
 }
 
-static const char __init *pci_mmcfg_intel_945(void)
+static const char *__init cf_check pci_mmcfg_intel_945(void)
 {
     u32 pciexbar, mask = 0, len = 0;
 
@@ -137,7 +137,7 @@ static const char __init *pci_mmcfg_intel_945(void)
     return "Intel Corporation 945G/GZ/P/PL Express Memory Controller Hub";
 }
 
-static const char __init *pci_mmcfg_amd_fam10h(void)
+static const char *__init cf_check pci_mmcfg_amd_fam10h(void)
 {
     uint32_t address;
     uint64_t base, msr_content;
@@ -190,7 +190,7 @@ static const char __init *pci_mmcfg_amd_fam10h(void)
     return "AMD Family 10h NB";
 }
 
-static const char __init *pci_mmcfg_nvidia_mcp55(void)
+static const char *__init cf_check pci_mmcfg_nvidia_mcp55(void)
 {
     static bool_t __initdata mcp55_checked;
     int bus, i;
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:06:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:06:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271731.466439 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb3q-0003Mm-KJ; Mon, 14 Feb 2022 13:06:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271731.466439; Mon, 14 Feb 2022 13:06:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb3p-0003FZ-GA; Mon, 14 Feb 2022 13:06:33 +0000
Received: by outflank-mailman (input) for mailman id 271731;
 Mon, 14 Feb 2022 13:06:31 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJb38-0008IH-Mh
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:05:50 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d3c4e5f6-8d96-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 14:05:49 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d3c4e5f6-8d96-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644843949;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=1inRFtu44sj2FbmOrmiHpNybEEC6ccoHhKdjBehHxfA=;
  b=EQIVzqD8N8DjsM7KCw7d1bcdufAa+IKfggxH2Xf3RKSm9cwuj+FrPl6q
   6iMCWgoOElO6lcQtnMrs9Faa2StsGojcQiiVenDeIHkt+wJZLNuiVQgO1
   svGu0bEyiaks7xf7hZCNH8flborxkdkKJNfwT+pojRydwTSwOs2Rl2qL8
   s=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: 8IUVSPeiRFZz83MSk0IJGHorStZHdFjdSElCrSoUa8Hl/9CwbUlVIF6FmSEIoHxfUUUD5/PVjI
 SLN86+5RLAVveE4g0QGIaglQm9kyG75cZkKAxmSJGkMWFsKm6lWfSBWgdVpZkbtcTBn1HJ/a2n
 wvsSAxuwNIulKX7b+C+j0mBB397Ih+VITXxr4CojUMVv5X5x+DMbpX/Iz00607j+fSnJphbxHL
 L/QLFX+Bfrvh8WpTE9Te09+5nKoEcfvz3+dX6cv1rPt82rwtPaMOi+JicD0m5wIBYMvVOaJhY0
 wvkHi2QCEBGMyJpZ2+DYp8U6
X-SBRS: 5.1
X-MesageID: 66374885
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:KmOZM6588DpZukW6csGsAgxRtCHAchMFZxGqfqrLsTDasY5as4F+v
 jcaC2mDP/vcM2v8et8ka4jloU4Bu5Pcmt4wTQo9qywzHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FV8MpBsJ00o5wbZj29Iw2LBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z7
 s9A9rb3eAcTMKjDiMYaUEhUIh1uBPgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALBc/nJo4A/FpnyinUF60OSpHfWaTao9Rf2V/cg+gQQ62BO
 5pJNFKDajyZRSFiNF4QLqg9s8KtjWnteBRE9l6a8P9fD2/7k1UqjemF3MDuUsyHQ4BZk1iVo
 krC/n/lGVcKOdqH0z2H/3mwwOjVkkvGtJk6TePisKQw2RvKmzJVWEZ+uUaHTeeRrFSzGPgYG
 kwu9C8hvYo19x2nf+XtZkjtyJKbhSI0V91VGuw8zQiCzKvI/gqUblQ5oi59hM8O75FvG2Fzv
 rOdt5awXGE07uXJIZ6I3urM9VuP1T4pwXjujMPuZS8M+JHdrY46lXojpf4zQffu3rUZ9dwdq
 g1mTRTSZZ1O16bnNI3hpDgrZg5AQbCTEGYICv3/BD7N0++ATNfNi3aUwVba9+1cC42SU0OMu
 nMJ8+DHsrxSUsHdyXHVGb5XdF1M2xpiGGeC6WOD4rF7r2j9k5JdVdw4DM5CyLdBbZ9fJG6Bj
 L77sgJN/p5DVEZGnocsC79d//8ClPC6ffy8D6i8RoMXPvBZKV/WlAkzNBX49z28zyARfVQXZ
 M7znTCEVi1BV8yKDVOeGo8g7FPc7n5ilD2DHcihl3xKE9O2PRaodFvMC3PWBshR0U9OiFyKm
 zqGH8fVmRhZTsPkZSzbrdwaIVwQdCBpDpHqsc1HMOWEJ1M+Sm0mDvbQx5InepBkwPsJxruZo
 CnlVx8K0kf7iF3GNR6ONiJpZoTwUMsttnk8JyEtYwqlgiBxfYa14a4DXJIrZr17pvd7xPt5Q
 qBdKcWNC/hCUBrd/DEZYcWvpYBubk3z1wmPIzCkcH40eJs5H17F/drtfw3O8igSD3Xo6Zti8
 uP4jg6CGMgNXQVvCsrSecmD9VLpsChPgv92UmvJPsJXJBfm/r91JnGjlfQwOcwNd0nOn2PIy
 waMDB4EjuDRuItposLRjKWJoor1QetzGk1WQzvS4bqsbHSI+2OixclLUfqSfCCbX2Txof3wa
 eJQxvD6EfsGgFcV7NYsT+c1lfozt4n1urtX7gV4B3GaPV2kB4RpLmSCwcQS5LZGwaVUuFfuV
 0+CkjWA1W5l5C8x/IYtGTcY
IronPort-HdrOrdr: A9a23:ou0Nl6hTl85HVVmm6S3OW8D4GXBQXt4ji2hC6mlwRA09TySZ//
 rOoB17726NtN9/YgBCpTntAsa9qDbnhPpICOoqTM6ftWvdyQmVxehZhOOIqVCNJ8S9zJ876U
 4JSdkZNDSaNzhHZKjBjjVQa+xQpeW6zA==
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="66374885"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v2 59/70] x86/bugframe: CFI hardening
Date: Mon, 14 Feb 2022 12:51:16 +0000
Message-ID: <20220214125127.17985-60-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

Control Flow Integrity schemes use toolchain and optionally hardware support
to help protect against call/jump/return oriented programming attacks.

Use cf_check to annotate function pointer targets for the toolchain.

run_in_exception_handler() managed to escape typechecking, as the compiler
can't see where function pointer gets called.  After adding some ad-hoc
typechecking, it turns out that dump_execution_state() alone differs in
const-ness from the other users of run_in_exception_handler().

Introduce a new show_execution_state_nonconst() to make the typechecking
happy.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
 xen/arch/x86/include/asm/bug.h       | 10 +++++++++-
 xen/arch/x86/include/asm/processor.h |  4 +++-
 xen/arch/x86/traps.c                 |  5 +++++
 xen/common/keyhandler.c              |  4 ++--
 xen/drivers/char/ehci-dbgp.c         |  2 +-
 xen/drivers/char/ns16550.c           |  2 +-
 xen/include/xen/lib.h                |  2 +-
 7 files changed, 22 insertions(+), 7 deletions(-)

diff --git a/xen/arch/x86/include/asm/bug.h b/xen/arch/x86/include/asm/bug.h
index 9bb4a194202f..b7265bdfbe33 100644
--- a/xen/arch/x86/include/asm/bug.h
+++ b/xen/arch/x86/include/asm/bug.h
@@ -65,7 +65,15 @@ struct bug_frame {
     unreachable();                                              \
 } while (0)
 
-#define run_in_exception_handler(fn) BUG_FRAME(BUGFRAME_run_fn, 0, fn, 0, NULL)
+/*
+ * TODO: untangle header dependences, break BUILD_BUG_ON() out of xen/lib.h,
+ * and use a real static inline here to get proper type checking of fn().
+ */
+#define run_in_exception_handler(fn)                            \
+    do {                                                        \
+        (void)((fn) == (void (*)(struct cpu_user_regs *))NULL); \
+        BUG_FRAME(BUGFRAME_run_fn, 0, fn, 0, NULL);             \
+    } while ( 0 )
 
 #define assert_failed(msg) do {                                 \
     BUG_FRAME(BUGFRAME_assert, __LINE__, __FILE__, 1, msg);     \
diff --git a/xen/arch/x86/include/asm/processor.h b/xen/arch/x86/include/asm/processor.h
index 23639d5479a3..8e2816fae9b9 100644
--- a/xen/arch/x86/include/asm/processor.h
+++ b/xen/arch/x86/include/asm/processor.h
@@ -496,7 +496,9 @@ void show_code(const struct cpu_user_regs *regs);
 void show_stack_overflow(unsigned int cpu, const struct cpu_user_regs *regs);
 void show_registers(const struct cpu_user_regs *regs);
 void show_execution_state(const struct cpu_user_regs *regs);
-#define dump_execution_state() run_in_exception_handler(show_execution_state)
+void cf_check show_execution_state_nonconst(struct cpu_user_regs *regs);
+#define dump_execution_state() \
+    run_in_exception_handler(show_execution_state_nonconst)
 void show_page_walk(unsigned long addr);
 void noreturn fatal_trap(const struct cpu_user_regs *regs, bool_t show_remote);
 
diff --git a/xen/arch/x86/traps.c b/xen/arch/x86/traps.c
index 7b957101934e..a2278d9499d0 100644
--- a/xen/arch/x86/traps.c
+++ b/xen/arch/x86/traps.c
@@ -681,6 +681,11 @@ void show_execution_state(const struct cpu_user_regs *regs)
     console_unlock_recursive_irqrestore(flags);
 }
 
+void cf_check show_execution_state_nonconst(struct cpu_user_regs *regs)
+{
+    show_execution_state(regs);
+}
+
 void vcpu_show_execution_state(struct vcpu *v)
 {
     unsigned long flags = 0;
diff --git a/xen/common/keyhandler.c b/xen/common/keyhandler.c
index 5dc650a37c5c..b6e22d8120b1 100644
--- a/xen/common/keyhandler.c
+++ b/xen/common/keyhandler.c
@@ -138,7 +138,7 @@ static void cf_check show_handlers(unsigned char key)
 
 static cpumask_t dump_execstate_mask;
 
-void dump_execstate(struct cpu_user_regs *regs)
+void cf_check dump_execstate(struct cpu_user_regs *regs)
 {
     unsigned int cpu = smp_processor_id();
 
@@ -490,7 +490,7 @@ static void cf_check run_all_keyhandlers(
     tasklet_schedule(&run_all_keyhandlers_tasklet);
 }
 
-static void do_debugger_trap_fatal(struct cpu_user_regs *regs)
+static void cf_check do_debugger_trap_fatal(struct cpu_user_regs *regs)
 {
     (void)debugger_trap_fatal(0xf001, regs);
 
diff --git a/xen/drivers/char/ehci-dbgp.c b/xen/drivers/char/ehci-dbgp.c
index e205c0da6a61..16c8ff394d5c 100644
--- a/xen/drivers/char/ehci-dbgp.c
+++ b/xen/drivers/char/ehci-dbgp.c
@@ -1247,7 +1247,7 @@ static int cf_check ehci_dbgp_getc(struct serial_port *port, char *pc)
 /* Safe: ehci_dbgp_poll() runs as timer handler, so not reentrant. */
 static struct serial_port *poll_port;
 
-static void _ehci_dbgp_poll(struct cpu_user_regs *regs)
+static void cf_check _ehci_dbgp_poll(struct cpu_user_regs *regs)
 {
     struct serial_port *port = poll_port;
     struct ehci_dbgp *dbgp = port->uart;
diff --git a/xen/drivers/char/ns16550.c b/xen/drivers/char/ns16550.c
index 8df1ee4d5c2c..e5b4a9085516 100644
--- a/xen/drivers/char/ns16550.c
+++ b/xen/drivers/char/ns16550.c
@@ -206,7 +206,7 @@ static void cf_check ns16550_interrupt(
 /* Safe: ns16550_poll() runs as softirq so not reentrant on a given CPU. */
 static DEFINE_PER_CPU(struct serial_port *, poll_port);
 
-static void __ns16550_poll(struct cpu_user_regs *regs)
+static void cf_check __ns16550_poll(struct cpu_user_regs *regs)
 {
     struct serial_port *port = this_cpu(poll_port);
     struct ns16550 *uart = port->uart;
diff --git a/xen/include/xen/lib.h b/xen/include/xen/lib.h
index c6987973bf88..3a1fdaf7e35a 100644
--- a/xen/include/xen/lib.h
+++ b/xen/include/xen/lib.h
@@ -199,7 +199,7 @@ extern char *print_tainted(char *str);
 extern void add_taint(unsigned int taint);
 
 struct cpu_user_regs;
-void dump_execstate(struct cpu_user_regs *);
+void cf_check dump_execstate(struct cpu_user_regs *);
 
 void init_constructors(void);
 
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:06:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:06:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271739.466446 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb3s-0003uR-Qv; Mon, 14 Feb 2022 13:06:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271739.466446; Mon, 14 Feb 2022 13:06:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb3r-0003p0-UL; Mon, 14 Feb 2022 13:06:35 +0000
Received: by outflank-mailman (input) for mailman id 271739;
 Mon, 14 Feb 2022 13:06:33 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJb3F-00023t-HC
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:05:57 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d8332ef6-8d96-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 14:05:55 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d8332ef6-8d96-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644843956;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=EoLk9ARQfV08rXKWBWT/VxrxjsnGxFJXU/V2o57wTSM=;
  b=fA6FyD371rJHIbzeyFKoqTM0vvD2eAAyhdV8er5RWRxZW8XCx8N87CtJ
   mgSV69ZPf8yF3x6O+762ASYquyFHE9x7i6lwv6/wGMEghfolVfqE14dj1
   sbNPGSxT62A23ROAJCslpuyyDDd+B3cL1/CKnWIAkZYyJog7AsJv+WDdH
   I=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: lwVxee2gONI8zybZijGPgtRb7S5JZ9rR8CHfg0ghaYoxu1E5N9tIvt91HWF+9OTv8XFLfKgO7I
 sGklG4QuNyuWBJRb7GUFbCvvrPewTUet58z1MlJJ4+lbLHr2rZo4uvi9H19dHhZhXDu+i2WFcb
 du2zGaMKUzOB1bYH7qaaAt6KZ91gHLgkteFKozfwjnDGudYqGKLiGB5CzGSwdJqM/tPPQUmyM9
 EIYP7GhssMUXd5fqYC5X04ybu+vZSrLHzftQZGmHstgwt8EmmDoKN+oB/9SOlGseJgJ+GkJIfM
 H0WldQZPdzkqH90PtQKPTWa/
X-SBRS: 5.1
X-MesageID: 64149841
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:yJ9zh6wJaH9Z9ZFyhY96t+cowSrEfRIJ4+MujC+fZmUNrF6WrkUOz
 moeDzuCPqqNMTb1fdtzati/9UMPvZ7Vx4BmTgM4qSAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAhLeNYYH1500g7wbdl2tcAbeWRWGthh
 /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL
 wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt+At9
 vtjubzhchoOF/DGgc9eFDtYDxgraMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr
 6ZBbmlQMFbT3Ipaw5riIgVoru0lINPmI8U0vXZ4wCuCJf0nXYrCU+PB4towMDIY2JwXQaeOO
 5NxhTxHSSryaUcSClorFpMshdiZjHemazYJpwfAzUYwyzeKl1EguFT3C/LFd9rPSchLk0Kwo
 mPd43+/EhwcLMaYyzeO7jSrnOCnoM/gcNtMTvvirKcs2QDNgDxIYPELabelicnltGCQV/IOE
 FEz03cktINxs26rUuCoCnVUv0W4lhIbXtNRFcgz5weM1rfY7m6lO4QUctJSQId47ZFrHFTGw
 nfMxoq0XmI37NV5XFrAru/8kN+kBcQCwYbujwcgRBBN3dTsqZpbYvnnHoc6S/7dYjEY9FjNL
 9G2QMoW2u97YS0jjfzTEbX7b9WE/Mahc+LNzl+LNl9JFysgDGJfW6Sm6ELA8dFLJ5uDQ1+Ks
 RAswpbCsL9eXczQzHXWGo3h+Y1FAN7fblXhbaNHRcF9p1xBBVb/FWyv3N2ODBgwaZtVEdMYS
 ETSpRlQ9Pdu0IiCNsdKj3aKI51yl8DITI29PtiNN4YmSsUhJWevoXA1DWbNjj+FraTZufxmU
 XttWZ33Vihy5GUO5GfeetrxJpd1mn5glTmOGfgWDX2PiNKjWZJccp9dWHPmUwzzxPrsTNz9/
 4kNOs2U5Q9YVeGiMCDb/ZRKdQIBLGQhBICwoMtSL7bRLg1jEWAnKvnQ3bJ+JNA1w/ULzr/Fr
 iOnR0tV6Fvjnnmbew+EXW9uNeH0VpFloHNlYSF1ZQS022IuaJqE5bsEc8dlZqEu8eFulKYmT
 /QMd8iaLO5ITzDLp2YUYZXn9dQwfxW3nwOeeSGiZWFnLZJnQgXI/P7ifxfuq3ZSXnbm65Nmr
 uT5hA3BQJcFSwBzN+rsaaqinwGroHwQuONuRE+UcNNdT1rhrdpxICvrg/5pf8xVcUffxiGX3
 hq9CAsDobWfuJc89dTEiPzWr4qtFOciTENWE3OCsOSzPCjeuGGi3ZVBQKCDejWEDDH4/6CrZ
 ON0yfDgMaJYwAYW4tQkS7s7n7gj49bPpqNBylU2FXrGWF2nF7d8LyTUxsJIrKBMmudUtAbet
 phjITWG1WFl4P/YLWM=
IronPort-HdrOrdr: A9a23:6yYMhqsIzUgwOrs8iYRzYp6c7skDdNV00zEX/kB9WHVpmszxra
 6TdZUgpGbJYVkqOE3I9ertBEDEewK4yXcX2/h2AV7BZniEhILAFugLhuGO/9SjIVybygc079
 YGT0EUMrzN5DZB4voSmDPIceod/A==
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="64149841"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v2 55/70] x86/pt: CFI hardening
Date: Mon, 14 Feb 2022 12:51:12 +0000
Message-ID: <20220214125127.17985-56-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

Control Flow Integrity schemes use toolchain and optionally hardware support
to help protect against call/jump/return oriented programming attacks.

Use cf_check to annotate function pointer targets for the toolchain.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
 xen/arch/x86/emul-i8254.c | 2 +-
 xen/arch/x86/hvm/hpet.c   | 2 +-
 xen/arch/x86/hvm/rtc.c    | 2 +-
 xen/arch/x86/hvm/vlapic.c | 4 ++--
 4 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/xen/arch/x86/emul-i8254.c b/xen/arch/x86/emul-i8254.c
index d170f464d966..18894b63488e 100644
--- a/xen/arch/x86/emul-i8254.c
+++ b/xen/arch/x86/emul-i8254.c
@@ -156,7 +156,7 @@ static int pit_get_gate(PITState *pit, int channel)
     return pit->hw.channels[channel].gate;
 }
 
-static void pit_time_fired(struct vcpu *v, void *priv)
+static void cf_check pit_time_fired(struct vcpu *v, void *priv)
 {
     uint64_t *count_load_time = priv;
     TRACE_0D(TRC_HVM_EMUL_PIT_TIMER_CB);
diff --git a/xen/arch/x86/hvm/hpet.c b/xen/arch/x86/hvm/hpet.c
index ed512fa65b63..45c7b9b40688 100644
--- a/xen/arch/x86/hvm/hpet.c
+++ b/xen/arch/x86/hvm/hpet.c
@@ -219,7 +219,7 @@ static void hpet_stop_timer(HPETState *h, unsigned int tn,
     hpet_get_comparator(h, tn, guest_time);
 }
 
-static void hpet_timer_fired(struct vcpu *v, void *data)
+static void cf_check hpet_timer_fired(struct vcpu *v, void *data)
 {
     unsigned int tn = (unsigned long)data;
     HPETState *h = vcpu_vhpet(v);
diff --git a/xen/arch/x86/hvm/rtc.c b/xen/arch/x86/hvm/rtc.c
index ed397276faa3..d21925db08bc 100644
--- a/xen/arch/x86/hvm/rtc.c
+++ b/xen/arch/x86/hvm/rtc.c
@@ -81,7 +81,7 @@ static void rtc_update_irq(RTCState *s)
 
 /* Called by the VPT code after it's injected a PF interrupt for us.
  * Fix up the register state to reflect what happened. */
-static void rtc_pf_callback(struct vcpu *v, void *opaque)
+static void cf_check rtc_pf_callback(struct vcpu *v, void *opaque)
 {
     RTCState *s = opaque;
 
diff --git a/xen/arch/x86/hvm/vlapic.c b/xen/arch/x86/hvm/vlapic.c
index d4e29ef1ff1d..49be9c8ea4fe 100644
--- a/xen/arch/x86/hvm/vlapic.c
+++ b/xen/arch/x86/hvm/vlapic.c
@@ -691,13 +691,13 @@ int guest_rdmsr_x2apic(const struct vcpu *v, uint32_t msr, uint64_t *val)
     return X86EMUL_OKAY;
 }
 
-static void vlapic_pt_cb(struct vcpu *v, void *data)
+static void cf_check vlapic_pt_cb(struct vcpu *v, void *data)
 {
     TRACE_0D(TRC_HVM_EMUL_LAPIC_TIMER_CB);
     *(s_time_t *)data = hvm_get_guest_time(v);
 }
 
-static void vlapic_tdt_pt_cb(struct vcpu *v, void *data)
+static void cf_check vlapic_tdt_pt_cb(struct vcpu *v, void *data)
 {
     *(s_time_t *)data = hvm_get_guest_time(v);
     vcpu_vlapic(v)->hw.tdt_msr = 0;
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:06:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:06:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271747.466458 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb3v-0004ba-88; Mon, 14 Feb 2022 13:06:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271747.466458; Mon, 14 Feb 2022 13:06:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb3u-0004a4-P5; Mon, 14 Feb 2022 13:06:38 +0000
Received: by outflank-mailman (input) for mailman id 271747;
 Mon, 14 Feb 2022 13:06:36 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJb34-0008IH-44
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:05:46 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d1d065cc-8d96-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 14:05:44 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d1d065cc-8d96-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644843945;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=uqi1jxBHAWzCvFq7xfZy03983Yg3cPF97gGqXtbut+k=;
  b=GdsEl4p4HbJXvigEFQcPPXW7iGAIJbSrb/5bQeFQIB9rg0dfbIO852nt
   JMw10Cuw6sXlMZEQAhuAIp8bOi1lXfT7V6GwoBn/oDrFI/wgYb8GwNy5H
   fAzAyre2CIMeVxkwivTt2A1YmZRqG8PDwKsO7JfMkyfnOSyKNE809WdgW
   o=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: iaDkqD7qUoS+zmzC9I81HrN30704v81fnmngrv1xCn3IcoDwSM9/eR7vPuGemTUvEkaLAHuVgw
 Mn8p46+CExuwiD9jIgXu480cLfiHSwyWwJ3Yc6JE+MhxFLB8bL6KxOhrVgE43IYrnJOfRFaD1a
 9Teps+DNvhyYYUoduPKL32/pXjD2lqKHVes0ctCjQRDAHji9UZTX5Y0M3Ziuqt8n1GadR4wYxU
 WUhQfhVKDwBXOWnS2UOBwyw1ZJ7MfLhbWHgArXpJwfK6v/26wQukn9JbWVDlbRWFc/TyIKdMgC
 UJAZDDG22SsF58EKkwKNHqmQ
X-SBRS: 5.1
X-MesageID: 64149421
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:IDM+Dqr7hQbJCia82Kjfe8P/UYBeBmIGYhIvgKrLsJaIsI4StFCzt
 garIBmFPfyJYGOnL98jYY6x/BkC65XXy4JqSwJk+X0wRisb85uZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlZT4vE2xbuKU5NTsY0idfic5Dndx4f5fs7Rh2NQw24HlW1rlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCnaCgCkBxE6Puo/U6XhBeMCxfBL1D+bCSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFKoZtmtt0nfyCvE+TIqYa67L+cVZzHE7gcUm8fP2O
 ZZANWszNk2ojxtnIE8+UsgVzaSSuSfHdzFkqWOQmqYlyj2GpOB2+Oe0a4eEEjCQfu1Fk0Ddq
 m/Y8mDRBhABKMfZ2TeD6mirhOLEgWX8Qo16KVGj3qc02hvJnDVVUUBIEwvgyRWktqKgc+5Pa
 AtM1yQMlrkV+UWtbdTcZg29oXHR63bwROFsO+E97QiMzI/d7ACYGnUIQ1Z9VTA2iCMlbWd0j
 wHUxrsFERQq6eTIEizFqt94uBvvYXB9EIMUWcMToeLpCfHHqZp7sB/AR80L/EWd3oysQmGYL
 9xnQUEDa1QvYSwjiv/TEbPv2WvESn31oukdvFu/Y45dxlklDLNJnqTxgbQh0d5OLZyCUn6Kt
 2Uels6V4YgmVM/RyHPdELhQROjyvZ5p1QEwZnY1QfEcG8mFoSb/Lei8HhkiTKuWDir0UWCwO
 xKC0e+gzJRSIGGrfcdKj3GZUKwXIVzbPY29DJj8N4MWCrAoLVPv1Hw+NCa4gjG2+GBxwP5XB
 HtuWZv1ZZrsIf88l2TeqiZ0+eJD+x3SMkuNGcGln0z/i+L2ibz8Ye5tDWZip9sRtMusyDg5O
 f4DXydT4xkAAuD4fAfN9osfcQIDIXQhXMikoM1LbO+TZAFhHTh5WfPWxLogfa1jnrhUybiUr
 i3sBBcAxQqtn2DDJCWLdmtnNOHlU6FgoC9pJicrJ1uphSQuON798KcFepIrVrA77+g/n+VsR
 vwIdpzYUPRCQzjK4RoHapz5oNAwfRinn1vWbSGkfCI+b9hrQAmQoo3oeQ7m9S8vCCurtJRh/
 +38h12DGZdaHlZsFsfbbv6r3midh3lFlbIgRVbML/lSZF7orNpgJRvug6JlOMoLMxjCmGeXj
 l7EHRcCqODRiIYp692V17ucpoKkHuYiTEpXG27XseS/OSXApzfxxIZBVKCDfCzHVXOy86KnP
 L0Hw/b5OfwBvVBLr4sjTOo7kfNgv4Pi9+1A0wBpPHTXdFD6WLpvL06P0dRLqqAQlKRSvhG7W
 x7X99RXUVlT1BgJzLLFyNIZU9m+
IronPort-HdrOrdr: A9a23:N2/ke6gbAIuV/gTQIR78AqjGU3BQXtgji2hC6mlwRA09TySZ//
 rBoB17726MtN9/YhEdcLy7VJVoBEmskKKdgrNhW4tKPjOW21dARbsKheCJrgEIWReOktK1vZ
 0QFJSWY+eQMbEVt6nHCXGDYrQd/OU=
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="64149421"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v2 39/70] x86/mtrr: CFI hardening
Date: Mon, 14 Feb 2022 12:50:56 +0000
Message-ID: <20220214125127.17985-40-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

Control Flow Integrity schemes use toolchain and optionally hardware support
to help protect against call/jump/return oriented programming attacks.

Use cf_check to annotate function pointer targets for the toolchain.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
 xen/arch/x86/cpu/mtrr/generic.c | 18 ++++++++++--------
 xen/arch/x86/cpu/mtrr/mtrr.h    |  8 ++++----
 2 files changed, 14 insertions(+), 12 deletions(-)

diff --git a/xen/arch/x86/cpu/mtrr/generic.c b/xen/arch/x86/cpu/mtrr/generic.c
index 7cf4cd01f3f6..47aaf76226e0 100644
--- a/xen/arch/x86/cpu/mtrr/generic.c
+++ b/xen/arch/x86/cpu/mtrr/generic.c
@@ -287,7 +287,8 @@ static void set_fixed_range(int msr, bool *changed, unsigned int *msrwords)
 	}
 }
 
-int generic_get_free_region(unsigned long base, unsigned long size, int replace_reg)
+int cf_check generic_get_free_region(
+    unsigned long base, unsigned long size, int replace_reg)
 /*  [SUMMARY] Get a free MTRR.
     <base> The starting (base) address of the region.
     <size> The size (in bytes) of the region.
@@ -309,8 +310,8 @@ int generic_get_free_region(unsigned long base, unsigned long size, int replace_
 	return -ENOSPC;
 }
 
-static void generic_get_mtrr(unsigned int reg, unsigned long *base,
-			     unsigned long *size, mtrr_type *type)
+static void cf_check generic_get_mtrr(
+    unsigned int reg, unsigned long *base, unsigned long *size, mtrr_type *type)
 {
 	uint64_t _mask, _base;
 
@@ -499,7 +500,7 @@ static void post_set(bool pge)
 	spin_unlock(&set_atomicity_lock);
 }
 
-static void generic_set_all(void)
+static void cf_check generic_set_all(void)
 {
 	unsigned long mask, count;
 	unsigned long flags;
@@ -522,8 +523,8 @@ static void generic_set_all(void)
 	}
 }
 
-static void generic_set_mtrr(unsigned int reg, unsigned long base,
-			     unsigned long size, mtrr_type type)
+static void cf_check generic_set_mtrr(
+    unsigned int reg, unsigned long base, unsigned long size, mtrr_type type)
 /*  [SUMMARY] Set variable MTRR register on the local CPU.
     <reg> The register to set.
     <base> The base address of the region.
@@ -566,7 +567,8 @@ static void generic_set_mtrr(unsigned int reg, unsigned long base,
 	local_irq_restore(flags);
 }
 
-int generic_validate_add_page(unsigned long base, unsigned long size, unsigned int type)
+int cf_check generic_validate_add_page(
+    unsigned long base, unsigned long size, unsigned int type)
 {
 	unsigned long lbase, last;
 
@@ -584,7 +586,7 @@ int generic_validate_add_page(unsigned long base, unsigned long size, unsigned i
 }
 
 
-static int generic_have_wrcomb(void)
+static int cf_check generic_have_wrcomb(void)
 {
 	unsigned long config;
 	rdmsrl(MSR_MTRRcap, config);
diff --git a/xen/arch/x86/cpu/mtrr/mtrr.h b/xen/arch/x86/cpu/mtrr/mtrr.h
index 9a406e6f6199..c7fd44daab27 100644
--- a/xen/arch/x86/cpu/mtrr/mtrr.h
+++ b/xen/arch/x86/cpu/mtrr/mtrr.h
@@ -24,10 +24,10 @@ struct mtrr_ops {
 	int	(*have_wrcomb)(void);
 };
 
-extern int generic_get_free_region(unsigned long base, unsigned long size,
-				   int replace_reg);
-extern int generic_validate_add_page(unsigned long base, unsigned long size,
-				     unsigned int type);
+int cf_check generic_get_free_region(
+    unsigned long base, unsigned long size, int replace_reg);
+int cf_check generic_validate_add_page(
+    unsigned long base, unsigned long size, unsigned int type);
 
 extern const struct mtrr_ops generic_mtrr_ops;
 
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:06:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:06:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271754.466472 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb3y-0005NK-BK; Mon, 14 Feb 2022 13:06:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271754.466472; Mon, 14 Feb 2022 13:06:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb3x-0005K7-Ke; Mon, 14 Feb 2022 13:06:41 +0000
Received: by outflank-mailman (input) for mailman id 271754;
 Mon, 14 Feb 2022 13:06:39 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJb2y-0008IH-15
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:05:40 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id cd88c665-8d96-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 14:05:38 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cd88c665-8d96-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644843939;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=4p8+U7bQUnOYzkSxSSSq0ARZQ5aCAjglSKvDPx7PBXU=;
  b=cdBPF2rTlXP97cxC5uEypg64F2+pKnF/dTu/cYMAJiqW97waMsrs3ZhY
   yNQEjlFVpvuRwFsiyogqWv5PyzfVSDLspM4SLnZJnxbgeuUfj22BJhq0X
   MjMSoD+u9yZgPewdf060FWipMPIF4Rj04ad5hy+xtgSjv0ZzlsAlDjrWA
   o=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: I3xCB+3fYRW2bTBtXxPA9LKnhh8j+kIIwyPJaxWpSWbX0yPGAxBsOCiFCeFL2z8YUP2i2QNjmE
 FuQ+uuwjc8RCpCLbQYpu8t3j0lKvL95ukJnmxd6HFtb5HcJqiUYLZPJtFUJ+vpMwKGaDUqwwsL
 dThtQs3O9pu9DALvZtuqo/EjqgiD2xRQ9SiIyBLBO9NmaFMf2lQvGvkehcPSttwwWMn2NH9Xkw
 AQLscSxktHCugoZ0xvvFAxiD1+/KavASYX1/Oxx/54T9hz5wGMAAEf9zkK702/VqoC+nF3QGuy
 V4LidFhyYeC6kTylrBo6DuQK
X-SBRS: 5.1
X-MesageID: 64149412
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:uiZ6yqJZVFsbZxGpFE+RzpIlxSXFcZb7ZxGr2PjKsXjdYENS1TcBz
 GcbXWjVOPjYM2GkKdB1b4/k90tVusTTxoVgSwJlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokcxIn5BC5C5xZVG/fjgqoHUVaiUakideSc+EH170Ug6x7Zg6mJVqYPR7z2l6
 IuaT/L3YDdJ6xYsWo7Dw/vewP/HlK2aVAIw5jTSV9gS1LPtvyB94KYkDbOwNxPFrrx8RYZWc
 QphIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbrGvaUXe345iXMfwZ3u7hB2Qo/Bj0
 cgdk6brEx8yYZDCwsI+f0VhRnQW0a1uoNcrIFC6uM2XiUbHb2Ht07NlC0Re0Y8wo7gtRzsUr
 LpBdW5LPkvra+GemdpXTsFFgMg5IdatF4QYonx6lhnSDOo8QICFSKLPjTNd9Gls35wfQa+ED
 yYfQRVuQh+DOC8fA24WT8Iag6CIgHzkczIN/Tp5ooJoujOOnWSdyoPFINfTP9CHW8hRtkKZv
 X7duXT0BAkAM96SwibD9Wij7tIjhguiBthUTufhsKc33hvDnQT/FSH6S3Oindmrk1PufegEc
 VQPpRcg944R2BCSG4yVswKDnFaIuRsVWtx1GuI86R2Qxqe83zt1FlToXRYaNoV46ZZeqSgCk
 wbQwoi3XWAHXKi9FCrFnop4uw9eLsT8wYUqQSYfBTUI7ND4yG3YpkKeF40zeEJZYzCcJN0R/
 9xohHVk71nwpZRSv0lewbwgq2jyzqUltiZvum3qspuNt2uVnrKNaY2y8kT85v1dNoufRVTpl
 CFax5TBvLBTUMnUz3blrAAx8FaBvajtDdEhqQQ3Q8lJG8qFpxZPgry8EBkhfRw0Y67oiBfiY
 VPJuBM52XOgFCDCUEODWKroU55C5fG5TbzND6mIBvITMskZXFLWp0lGOB/Pt10BZWBxyMnTz
 7/AKp3yZZvbYIw6pAeLqxA1j+N1mHBkmD+7qFKS503P7IdyrUW9Ed8tWGZipMhjhE9diAmKo
 dtZKeWQzBBTDL/3biXNqNZBJlEWN3krQ5vxrpUPJOKEJwNnHkAnCuPQnux9K9A0wfwNm7ea5
 Gy5V29Z1EH72S/NJzKVZy0xc7joR5t+8y42ZHR+IVay1nE/So+z96NDJYAvdLwq+bU7n/55R
 vUIYeuaBfFLRmiV8jgRd8Cl/odjaA6qlUSFOC/8OGozeJtpRgro/N74f1SwqHlSX3Tv7cZn+
 u+uzALWR5YHVj9ONseOZaL91U61sFgchPl2AxnCLO5MdRi+64NtMSHw0KM6epleNRXZyzKG/
 A+KGhNE9/LVqoo4/dSV16CJq4ClT7l3EkZARjSJ6L+3MW/R/3a5wJ8GW+GNJGiPWGTx8aSkR
 ONU0/Cjb6FXwAcU69JxQ+Rx0KYzx9rzvLsLnA1rEULCY0mvFr49cGKN2tNCt/EVy7JU0edst
 pljJjWO1W21Bf7Y
IronPort-HdrOrdr: A9a23:Ig21wK/4+ssNKksLZx9uk+DcI+orL9Y04lQ7vn2YSXRuE/Bw9v
 re5MjzuiWE6wr5NEtOpTnEAtjlfZq+z+8N3WByB8bBYOCOggLBR+sOgbcKgQeQfBEWntQts5
 uIGJIfNDSfNzZHZL7BkWyFL+o=
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="64149412"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v2 35/70] x86/ucode: CFI hardening
Date: Mon, 14 Feb 2022 12:50:52 +0000
Message-ID: <20220214125127.17985-36-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

Control Flow Integrity schemes use toolchain and optionally hardware support
to help protect against call/jump/return oriented programming attacks.

Use cf_check to annotate function pointer targets for the toolchain.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
 xen/arch/x86/cpu/microcode/amd.c   |  9 +++++----
 xen/arch/x86/cpu/microcode/core.c  |  4 ++--
 xen/arch/x86/cpu/microcode/intel.c | 10 +++++-----
 3 files changed, 12 insertions(+), 11 deletions(-)

diff --git a/xen/arch/x86/cpu/microcode/amd.c b/xen/arch/x86/cpu/microcode/amd.c
index fe92e594f129..0afa2192bf1d 100644
--- a/xen/arch/x86/cpu/microcode/amd.c
+++ b/xen/arch/x86/cpu/microcode/amd.c
@@ -91,7 +91,7 @@ static struct {
     uint16_t id;
 } equiv __read_mostly;
 
-static void collect_cpu_info(void)
+static void cf_check collect_cpu_info(void)
 {
     struct cpu_signature *csig = &this_cpu(cpu_sig);
 
@@ -204,7 +204,7 @@ static enum microcode_match_result compare_header(
     return compare_revisions(old->patch_id, new->patch_id);
 }
 
-static enum microcode_match_result compare_patch(
+static enum microcode_match_result cf_check compare_patch(
     const struct microcode_patch *new, const struct microcode_patch *old)
 {
     /* Both patches to compare are supposed to be applicable to local CPU. */
@@ -214,7 +214,7 @@ static enum microcode_match_result compare_patch(
     return compare_header(new, old);
 }
 
-static int apply_microcode(const struct microcode_patch *patch)
+static int cf_check apply_microcode(const struct microcode_patch *patch)
 {
     int hw_err;
     unsigned int cpu = smp_processor_id();
@@ -299,7 +299,8 @@ static int scan_equiv_cpu_table(const struct container_equiv_table *et)
     return -ESRCH;
 }
 
-static struct microcode_patch *cpu_request_microcode(const void *buf, size_t size)
+static struct microcode_patch *cf_check cpu_request_microcode(
+    const void *buf, size_t size)
 {
     const struct microcode_patch *saved = NULL;
     struct microcode_patch *patch = NULL;
diff --git a/xen/arch/x86/cpu/microcode/core.c b/xen/arch/x86/cpu/microcode/core.c
index 841364208053..c07f68ba350e 100644
--- a/xen/arch/x86/cpu/microcode/core.c
+++ b/xen/arch/x86/cpu/microcode/core.c
@@ -291,12 +291,12 @@ static int wait_for_condition(bool (*func)(unsigned int data),
     return 0;
 }
 
-static bool wait_cpu_callin(unsigned int nr)
+static bool cf_check wait_cpu_callin(unsigned int nr)
 {
     return cpumask_weight(&cpu_callin_map) >= nr;
 }
 
-static bool wait_cpu_callout(unsigned int nr)
+static bool cf_check wait_cpu_callout(unsigned int nr)
 {
     return atomic_read(&cpu_out) >= nr;
 }
diff --git a/xen/arch/x86/cpu/microcode/intel.c b/xen/arch/x86/cpu/microcode/intel.c
index f6d01490e0ab..d3864b5ab03e 100644
--- a/xen/arch/x86/cpu/microcode/intel.c
+++ b/xen/arch/x86/cpu/microcode/intel.c
@@ -116,7 +116,7 @@ static bool signature_matches(const struct cpu_signature *cpu_sig,
     return cpu_sig->pf & ucode_pf;
 }
 
-static void collect_cpu_info(void)
+static void cf_check collect_cpu_info(void)
 {
     struct cpu_signature *csig = &this_cpu(cpu_sig);
     uint64_t msr_content;
@@ -271,7 +271,7 @@ static enum microcode_match_result microcode_update_match(
     return compare_revisions(cpu_sig->rev, mc->rev);
 }
 
-static enum microcode_match_result compare_patch(
+static enum microcode_match_result cf_check compare_patch(
     const struct microcode_patch *new, const struct microcode_patch *old)
 {
     /*
@@ -284,7 +284,7 @@ static enum microcode_match_result compare_patch(
     return compare_revisions(old->rev, new->rev);
 }
 
-static int apply_microcode(const struct microcode_patch *patch)
+static int cf_check apply_microcode(const struct microcode_patch *patch)
 {
     uint64_t msr_content;
     unsigned int cpu = smp_processor_id();
@@ -323,8 +323,8 @@ static int apply_microcode(const struct microcode_patch *patch)
     return 0;
 }
 
-static struct microcode_patch *cpu_request_microcode(const void *buf,
-                                                     size_t size)
+static struct microcode_patch *cf_check cpu_request_microcode(
+    const void *buf, size_t size)
 {
     int error = 0;
     const struct microcode_patch *saved = NULL;
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:06:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:06:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271773.466487 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb43-0006YN-16; Mon, 14 Feb 2022 13:06:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271773.466487; Mon, 14 Feb 2022 13:06:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb42-0006WT-M2; Mon, 14 Feb 2022 13:06:46 +0000
Received: by outflank-mailman (input) for mailman id 271773;
 Mon, 14 Feb 2022 13:06:45 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJb2Y-0008IH-01
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:05:14 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id bcf89745-8d96-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 14:05:11 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bcf89745-8d96-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644843911;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=Cb4WkVIG42hm90giM2dEHS2eAP2rQxieWFvRijYUUxU=;
  b=FbrFc222LRIEcWeBZM7QgWdF4h0S6ZQVQtuphCeLtlitzZLzfoVVfjHA
   KjbaoxaeReZay+dPj422rQS8o1bEvzKxsR/FEcxfO2BUjjP1o6YTh6cha
   T42i+8bus38bYOGN8UWTsrd5hQ6rMjppIUeyzJ+0Eo63vlBqriLVXMghx
   U=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: wvcz5bMK2UNc6Djov4mmUECl6mDnGKEv3tUrl94xvEahsrs/JatFGMdXPJrvx3ZJIxG52eQLWL
 k346EmRYivTwBnIVonTvBAkUgmhtzIjl8qmx6/YaXC9Bd04SXSJYP7X5NLTbuKbddu3QxWO0G0
 ZKIDsqMN0LShsRLQZ1DN7aq4kWmhkQe3wLWZTYNoOTe7ovMOecYEjL5t2lE3krlE8+7C2HStlv
 2XYtdgGErsv1R4kRhxkq0/0vYqNEZe1szKr8V3fsAl3QTt9/aYrFJ9KMO8k4x4UHWVMTdIAzJO
 iQYnyMPtW5KKlSwzull1mLKp
X-SBRS: 5.1
X-MesageID: 64149369
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:MBRlNapPvE+CF00xvMzhsXynCJ5eBmIkYhIvgKrLsJaIsI4StFCzt
 garIBnQPfzcYmX2KNxwOY22oxhU6peDy9AwQQo4+H00Qy9Bo5uZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlZT4vE2xbuKU5NTsY0idfic5Dndx4f5fs7Rh2NQw24HlW1rlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCnY2BUQF3IKHDo+8MAwlzQygjbIFA3aCSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFKoZtmtt0nfyCvE+TIqYa67L+cVZzHE7gcUm8fP2O
 ZZANWs0MkWojxtnJ0w3Grslg8uS33TDKjBVuQqRjLBuyj2GpOB2+Oe0a4eEEjCQfu1Kmm6Iq
 2SA+H72ajk4HtGCzTuO8lq3m/TC2yj8Xeo6BLC+s/JnnlCX7mgSEwENE0u2p+GjjUyzUM4ZL
 FYbkhfCtoBrqhbtFIOkGUTl/jjU5XbwRua8DcUr2RmLlLTY7D2SFzgUZW5INY0KsuopEGlCO
 kCyo/vlAjlmsbuwQH2b96uJoT7aBRX5PVPudgdfE1JbvoCLTJUby0uWE409SPLdYsjdRGmoq
 w1muhTSkFn6YSQj86ygtW7KjDu3znQiZl5kv16HNo5JA+4QWWJEW2BKwQWBhRqjBNzAJrVkg
 JTjs5LAhN3i9bnXyESwrBwlRdlFHcqtPjzGmkJIFJI87Tmr8HPLVdkOvG0hdBc0b55dImWBj
 KrvVeR5vsE7AZdXRfUvP9LZ5zoCkcAM6ugJptiLN4ETM/CdhSeM/T10ZF744oweuBNErE3LA
 r/CKZzEJS9DUcxPlWPqL89Age5D7n1vngv7GMGkpylLJJLDPRZ5v59eawDQBg34hYvZyDjoH
 yF3aZfUlUUFDbGWj+u+2dd7EG3m5EMTXfjew/G7vMbZSua/MG1+WfLX3507fIlpw/ZcmuvSp
 ynvUU5E0lvvw3bALFzSOHxkbbruW7d5rG46YnNwbQr5hSB7bNb99robers2YaIjqL5pw8lrQ
 qRXYM6HGPlOFGjKomxPcZnnoYV+Xx23ngbSbTG9aT0ycsc4FQzE89PpZCX18ywKAnblvMcyu
 eT4hAjaXYACV0JpC8OPMKCjyFa4vH48nuNuXhSXfokPKRu0qIUzcn7/lP46Jc0IOC7v/DrC2
 lbEGwocqMnMv5QxrIvDi5ebotr7COB5BEdbQTXWtO7kKSnA82O/6oZcS+LULyvFXWb59aj+N
 +VYy/bwbK8OkFpQ6tcuFr9qyeQ15sf1pq8cxQNhRS2ZY1OuA7JmA3+HwcgQ6fEdmu4H4VO7C
 hCV591XGbSVI8e0QlceKT0sYvmHyfxJyCLZ6u44IRmi6SJ6lFZdvZ6+4/VYZPRhEYZI
IronPort-HdrOrdr: A9a23:MNCOx62XGtYMj2syZTLDUgqjBLAkLtp133Aq2lEZdPRUGvb3qy
 nOpoVj6faaslYssR0b9exofZPwJE80lqQFh7X5X43SPzUO0VHAROoJgLcKgQeQfxEWntQtsp
 uIGJIeNDSfNzdHZL7BkWuFL+o=
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="64149369"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>
Subject: [PATCH v2 64/70] x86: Introduce helpers/checks for endbr64 instructions
Date: Mon, 14 Feb 2022 12:51:21 +0000
Message-ID: <20220214125127.17985-65-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

... to prevent the optimiser creating unsafe code.  See the code comment for
full details.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>

v2:
 * Fix include to let the header be standalone
 * Add earlyclobber to asm
v1.1:
 * New
---
 xen/arch/x86/include/asm/endbr.h | 53 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 53 insertions(+)
 create mode 100644 xen/arch/x86/include/asm/endbr.h

diff --git a/xen/arch/x86/include/asm/endbr.h b/xen/arch/x86/include/asm/endbr.h
new file mode 100644
index 000000000000..6b6f46afaf29
--- /dev/null
+++ b/xen/arch/x86/include/asm/endbr.h
@@ -0,0 +1,53 @@
+/******************************************************************************
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; If not, see <http://www.gnu.org/licenses/>.
+ *
+ * Copyright (c) 2021-2022 Citrix Systems Ltd.
+ */
+#ifndef XEN_ASM_ENDBR_H
+#define XEN_ASM_ENDBR_H
+
+#include <xen/types.h>
+
+/*
+ * In some cases we need to inspect/insert endbr64 instructions.
+ *
+ * The naive way, mem{cmp,cpy}(ptr, "\xf3\x0f\x1e\xfa", 4), optimises unsafely
+ * by placing 0xfa1e0ff3 in an imm32 operand, and marks a legal indirect
+ * branch target as far as the CPU is concerned.
+ *
+ * gen_endbr64() is written deliberately to avoid the problematic operand, and
+ * marked __const__ as it is safe for the optimiser to hoist/merge/etc.
+ */
+static inline uint32_t __attribute_const__ gen_endbr64(void)
+{
+    uint32_t res;
+
+    asm ( "mov $~0xfa1e0ff3, %[res]\n\t"
+          "not %[res]\n\t"
+          : [res] "=&r" (res) );
+
+    return res;
+}
+
+static inline bool is_endbr64(const void *ptr)
+{
+    return *(const uint32_t *)ptr == gen_endbr64();
+}
+
+static inline void place_endbr64(void *ptr)
+{
+    *(uint32_t *)ptr = gen_endbr64();
+}
+
+#endif /* XEN_ASM_ENDBR_H */
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:06:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:06:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271777.466495 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb44-0006vx-NP; Mon, 14 Feb 2022 13:06:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271777.466495; Mon, 14 Feb 2022 13:06:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb44-0006u3-CJ; Mon, 14 Feb 2022 13:06:48 +0000
Received: by outflank-mailman (input) for mailman id 271777;
 Mon, 14 Feb 2022 13:06:47 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJb3J-00023t-F4
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:06:01 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d9d7fb2a-8d96-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 14:05:59 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d9d7fb2a-8d96-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644843960;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=FaRq4uMLqchtYBsH0ZZXc1AMBt9Hn3Liv9Sb03AHXI0=;
  b=B5cLgp3C7y0GYo1Ykoro8F+fHs3iqBrVbnXxYXnQ8Ps103Z/Ork7ywm9
   BppRO1s8pHAw5mcwYJPxhvo0zqj74n4WG53r5Q4qoQJ9vGKKxwiZnax/S
   JTOl/DIrzAupa/bRRKqynUEetcyY2hiGRKv1+KyiyvC7kZYn13etbgt3O
   I=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: 3HmRFu2V3WurqLDDXunRl3owx5tt8Ietenwy3QtwnZ0FP18z5TgqQJdGbIDDBOpPso1OhSrLlN
 Q38UQ8lu75VdBRqISRBBmB7UJbhVIF9lbjg3dv4emhifGVkCHZB6kWwpdwjEOB5VdRUoH/xwZq
 9D4ebPhhXa5R6TSBUVsPXfF7mgDauGOzIqQJBU3tMWUMUOVf/2NACizqtDIVMb/IMIzZVkLWUu
 N1kWc0dFsktAVvvQS3kOVgP/bohZ/8s0fIdaUgI9zAvNLvaRl0H/wskze5jw5GV55seF+8s0zx
 tR8672NT/dAFTNpv+KV15bdD
X-SBRS: 5.1
X-MesageID: 63592666
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:qM4d1K4AjQLSdC51ES03egxRtCbAchMFZxGqfqrLsTDasY5as4F+v
 mJLCGyDbP7cZzShc9t0Pomz80wOu5bQzNdnTAJuqi4zHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FV8MpBsJ00o5wbZj29Iw2LBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z7
 pJiq6GycCgVGKzchdQjcDdkInBCIvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALBc/nJo4A/FpnyinUF60OSpHfWaTao9Rf2V/cg+gQRquPP
 ZRHN1KDajyQWzRMJ30IOqhimequxVnRTQZH9nus8P9fD2/7k1UqjemF3MDuUsyHQ4BZk1iVo
 krC/n/lGVcKOdqH0z2H/3mwwOjVkkvGtJk6TePisKQw2RvKmzJVWEZ+uUaHTeeRrAmRRe9dE
 mMo3Cs+sJgM12KXf4jBQEjtyJKbhSI0V91VGuw8zQiCzKvI/gqUblQ5oi59hM8O75FvG2Fzv
 rOdt5awXGE07uXJIZ6I3urM9VuP1T4pwXjujMPuZS8M+JHdrY46lXojpf4zQffu3rUZ9dwdq
 g1mTRTSZZ1O16bnNI3hpDgrZg5AQbCTEGYICv3/BD7N0++ATNfNi3aUwVba9+1cC42SU0OMu
 nMJ8+DHsrxSUsHdyXHVGb5XdF1M2xpiGGeC6WOD4rF7r2j9k5JdVdw4DM5CyLdBbZ9fJG6Bj
 L77sgJN/p5DVEZGnocsC79d//8ClPC6ffy8D6i8RoMXPvBZKV/WlAkzNBX49z28zyARfVQXZ
 M7znTCEVi1BV8yKDVOeGo8g7FPc7n5ilD2DHcihl3xKE9O2PRaodFvMC3PWBshR0U9OiFy9H
 w93O5TYxhNBfvf5ZyWLo4cfIUpTdSowBIzsqtwRfemGe1I0FGYkAv7X4LUgZ406wPgFyraWp
 imwCh1C1V7ypXzbMgHWOHptX6ziAMRkpnUhMC1yYVvxgyo/YZyi5bs0focseeV17/RqyPN5F
 qFXe8iJDvlVZC7A/jARMcv0oIB4LUz5jgOSJSu1JjM4esc4FQDO/9bleCrp9TUPUXXr5Zdv/
 eX421qCE5QZRglkAMLHU96Vzgu87SoHheZ/f0rUOd0PKk/ix5dndn7qhfgtLsBSdRianmmG1
 xybCAszrPXWp9Nn68HAgK2Jotv7E+Z6GUYGTWDX4azvaHvf92unh4RBTPyJbXbWU2atoPeuY
 uBczvfdNvwbnQkV79ogQugzla9utcHyo7J6zxh/GCSZZlumPbpsP32a0JQdraZK3LJY5VO7V
 0/nFgO24llV1BcJyGIsGTc=
IronPort-HdrOrdr: A9a23:wn6HVa7CyBCeH2h1PgPXwMrXdLJyesId70hD6qhwISY6TiX4rb
 HWoB1173/JYVoqNE3I3OrwXZVoIkmsk6Kdg7NhXotKNTOO0ADDQb2Kr7GSpwEIcxeOkdK1vp
 0AT0ERMrLN5CBB/KTH3DU=
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="63592666"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v2 38/70] x86/nmi: CFI hardening
Date: Mon, 14 Feb 2022 12:50:55 +0000
Message-ID: <20220214125127.17985-39-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

Control Flow Integrity schemes use toolchain and optionally hardware support
to help protect against call/jump/return oriented programming attacks.

Use cf_check to annotate function pointer targets for the toolchain.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
 xen/arch/x86/alternative.c        | 4 ++--
 xen/arch/x86/cpu/microcode/core.c | 3 ++-
 xen/arch/x86/crash.c              | 3 ++-
 xen/arch/x86/livepatch.c          | 2 +-
 xen/arch/x86/oprofile/nmi_int.c   | 2 +-
 xen/arch/x86/traps.c              | 3 ++-
 6 files changed, 10 insertions(+), 7 deletions(-)

diff --git a/xen/arch/x86/alternative.c b/xen/arch/x86/alternative.c
index 1cb531c9df83..436047abe021 100644
--- a/xen/arch/x86/alternative.c
+++ b/xen/arch/x86/alternative.c
@@ -324,8 +324,8 @@ static unsigned int __initdata alt_done;
  * condition where an NMI hits while we are midway though patching some
  * instructions in the NMI path.
  */
-static int __init nmi_apply_alternatives(const struct cpu_user_regs *regs,
-                                         int cpu)
+static int __init cf_check nmi_apply_alternatives(
+    const struct cpu_user_regs *regs, int cpu)
 {
     /*
      * More than one NMI may occur between the two set_nmi_callback() below.
diff --git a/xen/arch/x86/cpu/microcode/core.c b/xen/arch/x86/cpu/microcode/core.c
index c07f68ba350e..f84dafa82693 100644
--- a/xen/arch/x86/cpu/microcode/core.c
+++ b/xen/arch/x86/cpu/microcode/core.c
@@ -376,7 +376,8 @@ static int primary_thread_work(const struct microcode_patch *patch)
     return ret;
 }
 
-static int microcode_nmi_callback(const struct cpu_user_regs *regs, int cpu)
+static int cf_check microcode_nmi_callback(
+    const struct cpu_user_regs *regs, int cpu)
 {
     unsigned int primary = cpumask_first(this_cpu(cpu_sibling_mask));
     int ret;
diff --git a/xen/arch/x86/crash.c b/xen/arch/x86/crash.c
index f6264946a681..c383f718f5bd 100644
--- a/xen/arch/x86/crash.c
+++ b/xen/arch/x86/crash.c
@@ -36,7 +36,8 @@ static unsigned int crashing_cpu;
 static DEFINE_PER_CPU_READ_MOSTLY(bool, crash_save_done);
 
 /* This becomes the NMI handler for non-crashing CPUs, when Xen is crashing. */
-static int noreturn do_nmi_crash(const struct cpu_user_regs *regs, int cpu)
+static int noreturn cf_check do_nmi_crash(
+    const struct cpu_user_regs *regs, int cpu)
 {
     stac();
 
diff --git a/xen/arch/x86/livepatch.c b/xen/arch/x86/livepatch.c
index d056b1ed8b41..37c9b8435eda 100644
--- a/xen/arch/x86/livepatch.c
+++ b/xen/arch/x86/livepatch.c
@@ -175,7 +175,7 @@ static nmi_callback_t *saved_nmi_callback;
  * Note that because of this NOP code the do_nmi is not safely patchable.
  * Also if we do receive 'real' NMIs we have lost them.
  */
-static int mask_nmi_callback(const struct cpu_user_regs *regs, int cpu)
+static int cf_check mask_nmi_callback(const struct cpu_user_regs *regs, int cpu)
 {
     /* TODO: Handle missing NMI/MCE.*/
     return 1;
diff --git a/xen/arch/x86/oprofile/nmi_int.c b/xen/arch/x86/oprofile/nmi_int.c
index 6ebe20bd1d3e..a90b72825818 100644
--- a/xen/arch/x86/oprofile/nmi_int.c
+++ b/xen/arch/x86/oprofile/nmi_int.c
@@ -95,7 +95,7 @@ bool nmi_oprofile_send_virq(void)
 	return v;
 }
 
-static int nmi_callback(const struct cpu_user_regs *regs, int cpu)
+static int cf_check nmi_callback(const struct cpu_user_regs *regs, int cpu)
 {
 	int xen_mode, ovf;
 
diff --git a/xen/arch/x86/traps.c b/xen/arch/x86/traps.c
index 485bd66971db..7b957101934e 100644
--- a/xen/arch/x86/traps.c
+++ b/xen/arch/x86/traps.c
@@ -752,7 +752,8 @@ static cpumask_t show_state_mask;
 static bool opt_show_all;
 boolean_param("async-show-all", opt_show_all);
 
-static int nmi_show_execution_state(const struct cpu_user_regs *regs, int cpu)
+static int cf_check nmi_show_execution_state(
+    const struct cpu_user_regs *regs, int cpu)
 {
     if ( !cpumask_test_cpu(cpu, &show_state_mask) )
         return 0;
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:06:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:06:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271778.466501 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb45-00076L-JU; Mon, 14 Feb 2022 13:06:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271778.466501; Mon, 14 Feb 2022 13:06:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb45-00073a-6T; Mon, 14 Feb 2022 13:06:49 +0000
Received: by outflank-mailman (input) for mailman id 271778;
 Mon, 14 Feb 2022 13:06:47 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJb2m-00023t-1B
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:05:28 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c68bdee8-8d96-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 14:05:26 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c68bdee8-8d96-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644843926;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=lbPgCP8QoZ01MqJuej5y09QKl0+j0oj0HAV2tSG7L3Y=;
  b=B85S8KRwksAn8Txd/WPly7ZCG5YItRUYEyuEDyrYT4APvJttNcS2Puev
   Ru3qJETC+7kYim03NOmOhr6bUI2UJioA5p4xbaeE5SPwdoR1ewM1pZxtu
   KC4ASGFU60GtShG2PLUBpLBxNkU38P7mizqNxmhlmcHt/te4t826TSq6d
   8=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: C5OFwtAmVeQx/l/W1+zxTCPYzAL33kpFmtq11yYcexwEXk3WumaJv4/kPNy+y+vXMcehNRqhSI
 vNMYItHP8XV5HCyQtSPXghpiniZ9SdWrrh9HotU79Ab/WM7GjsklA3LFPiuCvgZuIc6eUlNo1t
 SbRA4o6837H8grJxLmLRD8XWvGp8TChY+EvJC8nRMD33q0ljspBdAeUTZGcWNPNm+/SYvIhZPT
 1u22/KG3Mgi29pjznTtBGzB/oHkCDWg53epH9OthCbXNCXhTM3oTTv2KWqW/mXVpeyq6nt0LtS
 senlb8Z1rOZQZg5/l6bNP2CJ
X-SBRS: 5.1
X-MesageID: 64149405
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:I3aBJawKCesvIw+J3Px6t+cIwSrEfRIJ4+MujC+fZmUNrF6WrkVVz
 WsbXm3XMvnbYjP9ftt3Pd6zpElUsMLXm4A3SAtuqiAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAhLeNYYH1500g7wbdl2tcAbeWRWGthh
 /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL
 wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt41Wz
 49jsre8dScOHerLtPszCUBUKAgraMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr
 6ZBbmlQMFbT3Ipaw5riIgVoru0lINPmI8U0vXZ4wCuCJf0nXYrCU+PB4towMDIY2JwXQaeCP
 5dxhTxHUA/7Yz51fUksDZswgqCRu0PWaCRcpwfAzUYwyzeKl1EguFT3C/LKfvSaSMMTmVyXz
 krk1WnkBhARNPSE1CGItHmrg4fnjS79HY4fCrC83vprm0GIgHweDgUMUlm2quX/jVSxM++zM
 GRNpHBo9/JrshX2EJ+tBHVUvUJooDZBfN0KPeoR5D2t7YmT5CqGKDJdQgVoPYlOWNANeRQm0
 VqAntXMDDNpsaGIRX/1yop4vQ9eKgBOczZcOHZsoR8tpoC6/dpt1k6nosNLTfbt5uAZDw0c1
 NxjQMIWo7wIxfAG2Kyglbwsq2L9/8OZJuLZC+i+Y45E0u+bTNP/D2BLwQKChRqlEGp+ZgPf1
 EXoY+DEsIgz4WilzURhutklErCz/OqiOzbBm1NpFJRJ323zpyL8LdANvWknfx0B3iM4ldjBO
 hG7hO+szMULYCvCgVFfP+pd9PjGPYC/TI+4B5g4n/JFY4RrdR/vwc2dTRX44owZq2B1yftXE
 c7CKa6EVC9GYYw6nGveb7pMitcDm3FhrV4/sLimlnxLJ5LFPyXLIVrEWXPTBt0EAFSs/lmEr
 YYHb5HSo/idOcWnChTqHUcoBQhiBRAG6Vre8aS7r8aPfVhrHn8PEfjUze9zcoBphf0NxOzJ4
 mu8SglTz1+m3S/LLgCDa3ZCbrLzXMkg8SJnbHJ0ZVv4iWI+ZYuP7bsEc8dld7cQ6+E+n+V/S
 OMIepvcD60XGCjH4TkUcbL0sJdmKEawnQuLMif8OGo/cpdsShbn4NjhegezpiACAjDu7Zk1o
 qG61xOdSp0GHlwwAMHTYfOp7lWwoXlCx74iAxqWeoFeIRy+/pJrJir9iu4MD/sNcRiTlCGH0
 wu2AAsDobWfqYEC79SU17uPqJ2kErUiExMCTXXb97u/KQLT4nGnnd1bSO+NcD3QCDH09aGla
 bkHxv3wKqRazlNDso46GLd316MuodDoouYCnAhjGXzKaXWtC69hfSbajZUe6PUVy+8LoxayV
 2KO5sJeaOeAN87SGVIMIBYoM7aY3vYOlziOtfk4LS0WPsOsEGZrhamKAySxtQ==
IronPort-HdrOrdr: A9a23:yWBmNqMTrwcGn8BcTsWjsMiBIKoaSvp037Eqv3oRdfU1SL3hqy
 nApoV56faZslkssTQb6LS90cq7MArhHPxOkOss1N6ZNWGM0gbFEGgh1/qE/9SJIVyZygc378
 ddmsZFZuEYdWIK6PrH3A==
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="64149405"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>
Subject: [PATCH v2 60/70] x86: Use control flow typechecking where possible
Date: Mon, 14 Feb 2022 12:51:17 +0000
Message-ID: <20220214125127.17985-61-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

Now all callees have been annotated, turn on typechecking to catch issues in
the future.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>

RFC.  This is still an experimental compiler extention
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102953

However, it is also the entire basis of being able to sanely use
-mmanual-endbr in the first place, so is very important.
---
 xen/arch/x86/arch.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/xen/arch/x86/arch.mk b/xen/arch/x86/arch.mk
index 8b88f0240e85..1710d056af3f 100644
--- a/xen/arch/x86/arch.mk
+++ b/xen/arch/x86/arch.mk
@@ -49,6 +49,7 @@ CFLAGS-$(CONFIG_INDIRECT_THUNK) += -fno-jump-tables
 
 ifdef CONFIG_XEN_IBT
 CFLAGS += -fcf-protection=branch -mmanual-endbr
+$(call cc-option-add,CFLAGS,CC,-fcf-check-attribute=no)
 else
 $(call cc-option-add,CFLAGS,CC,-fcf-protection=none)
 endif
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:06:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:06:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271783.466515 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb48-0007lB-B8; Mon, 14 Feb 2022 13:06:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271783.466515; Mon, 14 Feb 2022 13:06:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb47-0007hl-Sn; Mon, 14 Feb 2022 13:06:51 +0000
Received: by outflank-mailman (input) for mailman id 271783;
 Mon, 14 Feb 2022 13:06:49 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJb37-0008IH-Qm
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:05:50 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d3a3793b-8d96-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 14:05:48 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d3a3793b-8d96-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644843948;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=wpC7OHZwlbhpO5r1RmqVd6pYMJ/HbdVJ8EUY+L3SZWA=;
  b=XX75n9f6efhcCupVnBRoo2pBpfUuOHA1OLKp+43u023cSUlwvhJo2exj
   0MjZfCGqaD+s0VwwFPbumxxKNrqk69xUbra85iG4A7QvgypnFs1/coDRM
   L4HswO1wxcMecS0rSFA1QaXOlKEYKCTzRDI+VcVOh+47ohiiNP2y8fCJv
   0=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: HhFuk9Q+k0qwxzBMTkHd8bbbX5Q0gHPvNI/XfoTIgc1RosQNASyqAu3saeVTLkNCSs8X49+GPB
 MMOagAMcYsHzHyxIET3RzsE+R8AID3U7KIJ9/zrY8mAhrvLFobcGoLY+08W4zHEJYKGk1MDIAc
 FktHzS0k969/2uRf8K+ColRkj8+epMR/eaL6y00L6+/E7CEi9EOL7Jtu9OcrX6zIiqP5W6mWv/
 9OxyBxx5M6QqAEyTbNX4g0t1bqieCqUmTlpPKcws8k3xeOVot7IOnNUGTjMoVCp0TApUMpOsZP
 K0MNQsKo3CyNungrpNxzedF7
X-SBRS: 5.1
X-MesageID: 64149429
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:pQ9VjKlyetOFyFuDjmbmqVvo5gyfIURdPkR7XQ2eYbSJt1+Wr1Gzt
 xJLCGHTPPzYZjanedt2bom+9x4Cv5bTmoJqTlBo+C40FyMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BClVlxJVF/fngqoDUUYYoAQgsA180IMsdoUg7wbRh2Nc02YHR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 N9dssaNFiwVBIbzqMQdQxdyIhtZNLITrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBODtMJkSpTdLyjbBAOx9aZvCX7/L9ZlT2zJYasVmQ6qHO
 5tFM2sHgBLoUjJmCg4eF6gHnPqYjSLaYj14hVmUuv9ii4TU5FMoi+W8WDbPQfSaSMMQkkuGq
 2bu+2XiHgpcJNGZ0SCC8H+nmqnIhyyTZW4JPOTmrLgw2gTVnzFNTk1NPbemnRWnokSuXIhid
 GcowAERnYgy5EKBf+PaVgLt9RZooSUgc9ZXFuQ77iSExazV/xuVCwA4c9JRVDA1nJRoHGJ3j
 zdli/usXGUy6+PNFRpx45/J9WvaBMQDEYMVicbopyMh6sKrnow8hwmnoj1LQP/s1Y2d9d0dL
 lm3QMkCa1c70JRjO0aTpwmvb9eQSn/hFFBd2+kvdjj5hj6Vnab8D2BS1XDV7OxbMKGSRUSbs
 X4PlqC2tb5SUc7dxHHQGLxWRtlFAspp1xWG3zZS82QJrWzxqxZPg6gMiN2BGKuZGpldImK4C
 KMikQhQ+IVSLBOXgVxfOOqM5zAR5fG4T7zND6mMBvIXO8QZXFLXrUlGOB/Lt0iwwRdErE3KE
 crCGSpaJS1BUvoPIfvfb7p17ILHMQhgmTKNFcijlUzPPHj3TCf9dIrp+WCmNogRhJ5oai2Pm
 zqGH8fVmRhZTsPkZSzbrdwaIVwQdCBpDpHqsc1HMOWEJ1M+Sm0mDvbQx5InepBkwPsJxruZo
 CnlVx8K0kf7iF3GNR6ONiJpZoTwUMsttnk8JyEtYwqlgiBxfYa14a4DXJIrZr17pvd7xPt5Q
 qBdKcWNC/hCUBrd/DEZYcWvpYBubk3z1wmPIzCkcH40eJs5H17F/drtfw3O8igSD3Xo6Zti8
 uP4jg6CGMgNXQVvCsrSecmD9VLpsChPgv92UmvJPsJXJBfm/r91JnGjlfQwOcwNd0nOn2PIy
 waMDB4EjuDRuItposLRjKWJoor1QetzGk1WQzvS4bqsbHSI+2OixclLUfqSfCCbX2Txof3wa
 eJQxvD6EfsGgFcV7NYsT+c1lfozt4n1urtX7gV4B3GaPV2kB4RpLmSCwcQS5LZGwaVUuFfuV
 0+CkjWA1W5l5C8x/IYtGTcY
IronPort-HdrOrdr: A9a23:tCAOL6BbVakdCkjlHemo55DYdb4zR+YMi2TC1yhKKCC9E/bo7/
 xG885rtiMc5Ax/ZJhko6HlBEDiewKkyXcW2/hyAV7KZmCP0wHEQL2Kr7GSpAEIcxeOkNK1vp
 0BT0ERMrPN5CBB/KPH3DU=
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="64149429"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v2 11/70] xen: CFI hardening for notifier callbacks
Date: Mon, 14 Feb 2022 12:50:28 +0000
Message-ID: <20220214125127.17985-12-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

Control Flow Integrity schemes use toolchain and optionally hardware support
to help protect against call/jump/return oriented programming attacks.

Use cf_check to annotate function pointer targets for the toolchain.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
 xen/arch/x86/acpi/cpu_idle.c                 | 2 +-
 xen/arch/x86/cpu/mcheck/mce.c                | 2 +-
 xen/arch/x86/cpu/mcheck/mce_intel.c          | 2 +-
 xen/arch/x86/cpu/mwait-idle.c                | 4 ++--
 xen/arch/x86/cpu/vpmu.c                      | 2 +-
 xen/arch/x86/genapic/x2apic.c                | 2 +-
 xen/arch/x86/hvm/hvm.c                       | 2 +-
 xen/arch/x86/nmi.c                           | 2 +-
 xen/arch/x86/percpu.c                        | 2 +-
 xen/arch/x86/psr.c                           | 2 +-
 xen/arch/x86/smpboot.c                       | 2 +-
 xen/common/debugtrace.c                      | 4 ++--
 xen/common/kexec.c                           | 2 +-
 xen/common/livepatch.c                       | 2 +-
 xen/common/rcupdate.c                        | 2 +-
 xen/common/sched/core.c                      | 2 +-
 xen/common/sched/cpupool.c                   | 2 +-
 xen/common/stop_machine.c                    | 2 +-
 xen/common/tasklet.c                         | 2 +-
 xen/common/timer.c                           | 2 +-
 xen/common/trace.c                           | 2 +-
 xen/drivers/cpufreq/cpufreq.c                | 2 +-
 xen/drivers/cpufreq/cpufreq_misc_governors.c | 2 +-
 xen/drivers/passthrough/x86/hvm.c            | 2 +-
 24 files changed, 26 insertions(+), 26 deletions(-)

diff --git a/xen/arch/x86/acpi/cpu_idle.c b/xen/arch/x86/acpi/cpu_idle.c
index 7902ccce6b98..fb47eb9ad68e 100644
--- a/xen/arch/x86/acpi/cpu_idle.c
+++ b/xen/arch/x86/acpi/cpu_idle.c
@@ -1622,7 +1622,7 @@ bool cpuidle_using_deep_cstate(void)
                                                                : ACPI_STATE_C1);
 }
 
-static int cpu_callback(
+static int cf_check cpu_callback(
     struct notifier_block *nfb, unsigned long action, void *hcpu)
 {
     unsigned int cpu = (unsigned long)hcpu;
diff --git a/xen/arch/x86/cpu/mcheck/mce.c b/xen/arch/x86/cpu/mcheck/mce.c
index ea86d84481b2..a449fa0424ce 100644
--- a/xen/arch/x86/cpu/mcheck/mce.c
+++ b/xen/arch/x86/cpu/mcheck/mce.c
@@ -733,7 +733,7 @@ static int cpu_bank_alloc(unsigned int cpu)
     return 0;
 }
 
-static int cpu_callback(
+static int cf_check cpu_callback(
     struct notifier_block *nfb, unsigned long action, void *hcpu)
 {
     unsigned int cpu = (unsigned long)hcpu;
diff --git a/xen/arch/x86/cpu/mcheck/mce_intel.c b/xen/arch/x86/cpu/mcheck/mce_intel.c
index d63d6083d3a7..b6da8262e662 100644
--- a/xen/arch/x86/cpu/mcheck/mce_intel.c
+++ b/xen/arch/x86/cpu/mcheck/mce_intel.c
@@ -931,7 +931,7 @@ static int cpu_mcabank_alloc(unsigned int cpu)
     return -ENOMEM;
 }
 
-static int cpu_callback(
+static int cf_check cpu_callback(
     struct notifier_block *nfb, unsigned long action, void *hcpu)
 {
     unsigned int cpu = (unsigned long)hcpu;
diff --git a/xen/arch/x86/cpu/mwait-idle.c b/xen/arch/x86/cpu/mwait-idle.c
index 24d073d315ac..fe1b7af25f01 100644
--- a/xen/arch/x86/cpu/mwait-idle.c
+++ b/xen/arch/x86/cpu/mwait-idle.c
@@ -1275,8 +1275,8 @@ static int __init mwait_idle_probe(void)
 	return 0;
 }
 
-static int mwait_idle_cpu_init(struct notifier_block *nfb,
-			       unsigned long action, void *hcpu)
+static int cf_check mwait_idle_cpu_init(
+    struct notifier_block *nfb, unsigned long action, void *hcpu)
 {
 	unsigned int cpu = (unsigned long)hcpu, cstate;
 	struct acpi_processor_power *dev = processor_powers[cpu];
diff --git a/xen/arch/x86/cpu/vpmu.c b/xen/arch/x86/cpu/vpmu.c
index 9fc897dc8403..df3c9201b2c1 100644
--- a/xen/arch/x86/cpu/vpmu.c
+++ b/xen/arch/x86/cpu/vpmu.c
@@ -817,7 +817,7 @@ long cf_check do_xenpmu_op(
     return ret;
 }
 
-static int cpu_callback(
+static int cf_check cpu_callback(
     struct notifier_block *nfb, unsigned long action, void *hcpu)
 {
     unsigned int cpu = (unsigned long)hcpu;
diff --git a/xen/arch/x86/genapic/x2apic.c b/xen/arch/x86/genapic/x2apic.c
index 9064a0ca4696..bd44bb753995 100644
--- a/xen/arch/x86/genapic/x2apic.c
+++ b/xen/arch/x86/genapic/x2apic.c
@@ -187,7 +187,7 @@ static const struct genapic __initconstrel apic_x2apic_cluster = {
     .send_IPI_self = send_IPI_self_x2apic
 };
 
-static int update_clusterinfo(
+static int cf_check update_clusterinfo(
     struct notifier_block *nfb, unsigned long action, void *hcpu)
 {
     unsigned int cpu = (unsigned long)hcpu;
diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c
index 2ae1685d0aff..0a193530680a 100644
--- a/xen/arch/x86/hvm/hvm.c
+++ b/xen/arch/x86/hvm/hvm.c
@@ -117,7 +117,7 @@ static const char __initconst warning_hvm_fep[] =
 static bool_t __initdata opt_altp2m_enabled = 0;
 boolean_param("altp2m", opt_altp2m_enabled);
 
-static int cpu_callback(
+static int cf_check cpu_callback(
     struct notifier_block *nfb, unsigned long action, void *hcpu)
 {
     unsigned int cpu = (unsigned long)hcpu;
diff --git a/xen/arch/x86/nmi.c b/xen/arch/x86/nmi.c
index 21e947a46f24..5c101a9f97b3 100644
--- a/xen/arch/x86/nmi.c
+++ b/xen/arch/x86/nmi.c
@@ -428,7 +428,7 @@ void setup_apic_nmi_watchdog(void)
     nmi_active = 1;
 }
 
-static int cpu_nmi_callback(
+static int cf_check cpu_nmi_callback(
     struct notifier_block *nfb, unsigned long action, void *hcpu)
 {
     unsigned int cpu = (unsigned long)hcpu;
diff --git a/xen/arch/x86/percpu.c b/xen/arch/x86/percpu.c
index 0e0b6577ca45..eb3ba7bc8874 100644
--- a/xen/arch/x86/percpu.c
+++ b/xen/arch/x86/percpu.c
@@ -63,7 +63,7 @@ static void free_percpu_area(unsigned int cpu)
     call_rcu(&info->rcu, _free_percpu_area);
 }
 
-static int cpu_percpu_callback(
+static int cf_check cpu_percpu_callback(
     struct notifier_block *nfb, unsigned long action, void *hcpu)
 {
     unsigned int cpu = (unsigned long)hcpu;
diff --git a/xen/arch/x86/psr.c b/xen/arch/x86/psr.c
index 9a3670afc341..5b9991bd5b12 100644
--- a/xen/arch/x86/psr.c
+++ b/xen/arch/x86/psr.c
@@ -1642,7 +1642,7 @@ static void psr_cpu_fini(unsigned int cpu)
         free_socket_resources(socket);
 }
 
-static int cpu_callback(
+static int cf_check cpu_callback(
     struct notifier_block *nfb, unsigned long action, void *hcpu)
 {
     int rc = 0;
diff --git a/xen/arch/x86/smpboot.c b/xen/arch/x86/smpboot.c
index 335129a0104d..709704d71ada 100644
--- a/xen/arch/x86/smpboot.c
+++ b/xen/arch/x86/smpboot.c
@@ -1112,7 +1112,7 @@ static int cpu_smpboot_alloc(unsigned int cpu)
     return rc;
 }
 
-static int cpu_smpboot_callback(
+static int cf_check cpu_smpboot_callback(
     struct notifier_block *nfb, unsigned long action, void *hcpu)
 {
     unsigned int cpu = (unsigned long)hcpu;
diff --git a/xen/common/debugtrace.c b/xen/common/debugtrace.c
index f3c0fd8aa17b..160d00b79607 100644
--- a/xen/common/debugtrace.c
+++ b/xen/common/debugtrace.c
@@ -263,8 +263,8 @@ static void debugtrace_alloc_buffer(struct debugtrace_data **ptr,
     *ptr = data;
 }
 
-static int debugtrace_cpu_callback(struct notifier_block *nfb,
-                                   unsigned long action, void *hcpu)
+static int cf_check debugtrace_cpu_callback(
+    struct notifier_block *nfb, unsigned long action, void *hcpu)
 {
     unsigned int cpu = (unsigned long)hcpu;
 
diff --git a/xen/common/kexec.c b/xen/common/kexec.c
index 36384f782db3..3b223cd03d75 100644
--- a/xen/common/kexec.c
+++ b/xen/common/kexec.c
@@ -531,7 +531,7 @@ static int kexec_init_cpu_notes(const unsigned long cpu)
     return ret;
 }
 
-static int cpu_callback(
+static int cf_check cpu_callback(
     struct notifier_block *nfb, unsigned long action, void *hcpu)
 {
     unsigned long cpu = (unsigned long)hcpu;
diff --git a/xen/common/livepatch.c b/xen/common/livepatch.c
index 33708b4e2388..701efd87a173 100644
--- a/xen/common/livepatch.c
+++ b/xen/common/livepatch.c
@@ -2124,7 +2124,7 @@ static void livepatch_printall(unsigned char key)
     spin_unlock(&payload_lock);
 }
 
-static int cpu_callback(
+static int cf_check cpu_callback(
     struct notifier_block *nfb, unsigned long action, void *hcpu)
 {
     unsigned int cpu = (unsigned long)hcpu;
diff --git a/xen/common/rcupdate.c b/xen/common/rcupdate.c
index a5a27af3def0..2ec5606de5dd 100644
--- a/xen/common/rcupdate.c
+++ b/xen/common/rcupdate.c
@@ -641,7 +641,7 @@ static void rcu_init_percpu_data(int cpu, struct rcu_ctrlblk *rcp,
     init_timer(&rdp->idle_timer, rcu_idle_timer_handler, rdp, cpu);
 }
 
-static int cpu_callback(
+static int cf_check cpu_callback(
     struct notifier_block *nfb, unsigned long action, void *hcpu)
 {
     unsigned int cpu = (unsigned long)hcpu;
diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c
index 0f527024ba2e..4a79971a1d45 100644
--- a/xen/common/sched/core.c
+++ b/xen/common/sched/core.c
@@ -2839,7 +2839,7 @@ void sched_rm_cpu(unsigned int cpu)
     cpu_schedule_down(cpu);
 }
 
-static int cpu_schedule_callback(
+static int cf_check cpu_schedule_callback(
     struct notifier_block *nfb, unsigned long action, void *hcpu)
 {
     unsigned int cpu = (unsigned long)hcpu;
diff --git a/xen/common/sched/cpupool.c b/xen/common/sched/cpupool.c
index f26c7f289539..e5cfb03b857e 100644
--- a/xen/common/sched/cpupool.c
+++ b/xen/common/sched/cpupool.c
@@ -985,7 +985,7 @@ void dump_runq(unsigned char key)
     spin_unlock(&cpupool_lock);
 }
 
-static int cpu_callback(
+static int cf_check cpu_callback(
     struct notifier_block *nfb, unsigned long action, void *hcpu)
 {
     unsigned int cpu = (unsigned long)hcpu;
diff --git a/xen/common/stop_machine.c b/xen/common/stop_machine.c
index 8979d553d677..a122bd4afe09 100644
--- a/xen/common/stop_machine.c
+++ b/xen/common/stop_machine.c
@@ -182,7 +182,7 @@ static void stopmachine_action(void *data)
     local_irq_enable();
 }
 
-static int cpu_callback(
+static int cf_check cpu_callback(
     struct notifier_block *nfb, unsigned long action, void *hcpu)
 {
     unsigned int cpu = (unsigned long)hcpu;
diff --git a/xen/common/tasklet.c b/xen/common/tasklet.c
index ac89511a0955..1b16bbcdeb0b 100644
--- a/xen/common/tasklet.c
+++ b/xen/common/tasklet.c
@@ -214,7 +214,7 @@ void softirq_tasklet_init(struct tasklet *t, void (*func)(void *), void *data)
     t->is_softirq = 1;
 }
 
-static int cpu_callback(
+static int cf_check cpu_callback(
     struct notifier_block *nfb, unsigned long action, void *hcpu)
 {
     unsigned int cpu = (unsigned long)hcpu;
diff --git a/xen/common/timer.c b/xen/common/timer.c
index 1bb265ceea0e..b788050ea1d8 100644
--- a/xen/common/timer.c
+++ b/xen/common/timer.c
@@ -637,7 +637,7 @@ static void free_percpu_timers(unsigned int cpu)
         ASSERT(ts->heap == dummy_heap);
 }
 
-static int cpu_callback(
+static int cf_check cpu_callback(
     struct notifier_block *nfb, unsigned long action, void *hcpu)
 {
     unsigned int cpu = (unsigned long)hcpu;
diff --git a/xen/common/trace.c b/xen/common/trace.c
index 61fecc2b2bd2..b5358508f804 100644
--- a/xen/common/trace.c
+++ b/xen/common/trace.c
@@ -79,7 +79,7 @@ static u32 tb_event_mask = TRC_ALL;
  * i.e., sizeof(_type) * ans >= _x. */
 #define fit_to_type(_type, _x) (((_x)+sizeof(_type)-1) / sizeof(_type))
 
-static int cpu_callback(
+static int cf_check cpu_callback(
     struct notifier_block *nfb, unsigned long action, void *hcpu)
 {
     unsigned int cpu = (unsigned long)hcpu;
diff --git a/xen/drivers/cpufreq/cpufreq.c b/xen/drivers/cpufreq/cpufreq.c
index e55e202d5a18..a94520ee57ac 100644
--- a/xen/drivers/cpufreq/cpufreq.c
+++ b/xen/drivers/cpufreq/cpufreq.c
@@ -632,7 +632,7 @@ static int __init cpufreq_cmdline_parse(const char *s)
     return rc;
 }
 
-static int cpu_callback(
+static int cf_check cpu_callback(
     struct notifier_block *nfb, unsigned long action, void *hcpu)
 {
     unsigned int cpu = (unsigned long)hcpu;
diff --git a/xen/drivers/cpufreq/cpufreq_misc_governors.c b/xen/drivers/cpufreq/cpufreq_misc_governors.c
index 8343f491da87..ad79d0f5d246 100644
--- a/xen/drivers/cpufreq/cpufreq_misc_governors.c
+++ b/xen/drivers/cpufreq/cpufreq_misc_governors.c
@@ -91,7 +91,7 @@ cpufreq_userspace_handle_option(const char *name, const char *val)
     return 0;
 }
 
-static int cpufreq_userspace_cpu_callback(
+static int cf_check cpufreq_userspace_cpu_callback(
     struct notifier_block *nfb, unsigned long action, void *hcpu)
 {
     unsigned int cpu = (unsigned long)hcpu;
diff --git a/xen/drivers/passthrough/x86/hvm.c b/xen/drivers/passthrough/x86/hvm.c
index e5a2c5830348..527bd6a56d83 100644
--- a/xen/drivers/passthrough/x86/hvm.c
+++ b/xen/drivers/passthrough/x86/hvm.c
@@ -1046,7 +1046,7 @@ static void dpci_softirq(void)
     }
 }
 
-static int cpu_callback(
+static int cf_check cpu_callback(
     struct notifier_block *nfb, unsigned long action, void *hcpu)
 {
     unsigned int cpu = (unsigned long)hcpu;
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:06:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:06:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271785.466525 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb49-0007vs-Ox; Mon, 14 Feb 2022 13:06:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271785.466525; Mon, 14 Feb 2022 13:06:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb48-0007rv-KK; Mon, 14 Feb 2022 13:06:52 +0000
Received: by outflank-mailman (input) for mailman id 271785;
 Mon, 14 Feb 2022 13:06:50 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJb3G-00023t-Qp
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:05:58 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d8de72df-8d96-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 14:05:56 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d8de72df-8d96-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644843957;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=zYz6cPCtXWh7bl+DWwkU2uoiErkwKYQ2kvdgoIFv7rs=;
  b=YoJRgoZ0YXOZ/qMSM1UJdjRjRVSLpI5i987fERiIf/8Je+WKqvSf15+o
   lwtgxrpMZlIFY4iC+c6NG6MwxHoVxEPGuI7Pqyn3vyaOBEXqDg2K3IUd8
   tOcf3WUMOQF5JLX9gNc363v3ZPM9YdfUebmM8q5sXULK3fbAs0QjD2XEC
   M=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: Gf6TikuuGiZKt0BfoHzvjOEinQFQ60x15BazYMDXdwzhj/eEhUnlLCzXKxok+itIjouokdTk25
 dxB+cl2r844OJqDEQJ37wNtZxG4Lyh1ocCNJcgVeVYM4DxOaLUjvou7nH8k/7Q7/MZ14dk5d9X
 nOlcX8r9zKWYmuttWWY/AeOEf4LC1DtftYSXucyHMLoxAhShcgwlo6fUTgyx5RktVTXxZmT2f3
 K2relrdfYYjyrrgRwNr4mkyeYGBqrbeeNPgHC3ToHoCw804btSuBmAyWlejEWSvvCC2SC1cl7o
 lyU7j286x9nBF1xU1GdS+Jhc
X-SBRS: 5.1
X-MesageID: 64149847
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:HoLt8qwRi5Aj8w1rFmF6t+cowSrEfRIJ4+MujC+fZmUNrF6WrkUPy
 jFLW2vVbP6JNzD0ed8kao7lpx9TsZTQm9E2HFFvpSAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAhLeNYYH1500g7wbdl2tcAbeWRWGthh
 /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL
 wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt8FN1
 I1iuZOCcl0KDpf1kes2bQFgSy4raMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr
 6ZBbmlQMFbT3Ipaw5riIgVoru0lINPmI8U0vXZ4wCuCJf0nXYrCU+PB4towMDIY2JwXQaeOO
 5VxhTxHMA+dZwxXMFosFb1lruGWhXT2UR4BkQfAzUYwyzeKl1EguFT3C/LFd9rPSchLk0Kwo
 mPd43+/EhwcLMaYyzeO7jSrnOCnoM/gcNtMTvvirKcs2QDNgDxIYPELabelieiFlhaRV91tE
 BY3yhAXpKcZylSTFtaoCnVUv0W4lhIbXtNRFcgz5weM1rfY7m6lO4QUctJSQId47ZFrHFTGw
 nfMxoq0XmI37NV5XFrAru/8kN+kBcQCwYbujwcgRBBN3dTsqZpbYvnnHoc6S/7dYjEY9FjNL
 9G2QMoW2u97YS0jjfzTEbX7b9WE/Mahc+LNzl+LNl9JFysgDGJfW6Sm6ELA8dFLJ5uDQ1+Ks
 RAswpbCsL9eXczQzHXWGo3h+Y1FAN7fblXhbaNHRcF9p1xBBVb/FWyv3N2ODBgwaZtVEdMYS
 ETSpRlQ9Pdu0IiCNsdKj3aKI51yl8DITI29PtiNN4YmSsUhJWevoXA1DWbNjj+FraTZufxmU
 XttWZ33Vihy5GUO5GfeetrxJpd1mn5glTmOGfgWDX2PiNKjWZJccp9dWHPmUwzzxPrsTNz9/
 4kNOs2U5Q9YVeGiMCDb/ZRKdQIBLGQhBICwoMtSL7bRLg1jEWAnKvnQ3bJ+JNA1w/ULzr/Fr
 iOnR0tV6Fvjnnmbew+EXW9uNeH0VpFloHNlYSF1ZQS022IuaJqE5bsEc8dlZqEu8eFulKYmT
 /QMd8iaLO5ITzDLp2YUYZXn9dQwfxW3nwOeeSGiZWFnLZJnQgXI/P7ifxfuq3ZSXnbm65Nmr
 uT5hA3BQJcFSwBzN+rsaaqinwGroHwQuONuRE+UcNNdT1rhrdpxICvrg/5pf8xVcUffxiGX3
 hq9CAsDobWfuJc89dTEiPzWr4qtFOciTENWE3OCsOSzPCjeuGGi3ZVBQKCDejWEDDH4/6CrZ
 ON0yfDgMaJYwAYW4tQkS7s7n7gj49bPpqNBylU2FXrGWF2nF7d8LyTUxsJIrKBMmudUtAbet
 phjITWG1WFl4P/YLWM=
IronPort-HdrOrdr: A9a23:wqj72q1gfsnh/TME+yQGOQqjBLAkLtp133Aq2lEZdPRUGvb3qy
 nOpoVj6faaslYssR0b9exofZPwJE80lqQFh7X5X43SPzUO0VHAROoJgLcKgQeQfxEWntQtsp
 uIGJIeNDSfNzdHZL7BkWuFL+o=
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="64149847"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v2 56/70] x86/time: CFI hardening
Date: Mon, 14 Feb 2022 12:51:13 +0000
Message-ID: <20220214125127.17985-57-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

Control Flow Integrity schemes use toolchain and optionally hardware support
to help protect against call/jump/return oriented programming attacks.

Use cf_check to annotate function pointer targets for the toolchain.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
 xen/arch/x86/hpet.c             |  8 ++++----
 xen/arch/x86/include/asm/hpet.h |  4 ++--
 xen/arch/x86/time.c             | 33 +++++++++++++++++----------------
 3 files changed, 23 insertions(+), 22 deletions(-)

diff --git a/xen/arch/x86/hpet.c b/xen/arch/x86/hpet.c
index dcc9e16693e9..2b00c30d1153 100644
--- a/xen/arch/x86/hpet.c
+++ b/xen/arch/x86/hpet.c
@@ -196,7 +196,7 @@ static void evt_do_broadcast(cpumask_t *mask)
        cpumask_raise_softirq(mask, TIMER_SOFTIRQ);
 }
 
-static void handle_hpet_broadcast(struct hpet_event_channel *ch)
+static void cf_check handle_hpet_broadcast(struct hpet_event_channel *ch)
 {
     cpumask_t mask;
     s_time_t now, next_event;
@@ -553,7 +553,7 @@ static void hpet_detach_channel(unsigned int cpu,
 
 void (*__read_mostly pv_rtc_handler)(uint8_t index, uint8_t value);
 
-static void handle_rtc_once(uint8_t index, uint8_t value)
+static void cf_check handle_rtc_once(uint8_t index, uint8_t value)
 {
     if ( index != RTC_REG_B )
         return;
@@ -566,7 +566,7 @@ static void handle_rtc_once(uint8_t index, uint8_t value)
     }
 }
 
-void __init hpet_broadcast_init(void)
+void __init cf_check hpet_broadcast_init(void)
 {
     u64 hpet_rate = hpet_setup();
     u32 hpet_id, cfg;
@@ -637,7 +637,7 @@ void __init hpet_broadcast_init(void)
         hpet_events->flags = HPET_EVT_LEGACY;
 }
 
-void hpet_broadcast_resume(void)
+void cf_check hpet_broadcast_resume(void)
 {
     u32 cfg;
     unsigned int i, n;
diff --git a/xen/arch/x86/include/asm/hpet.h b/xen/arch/x86/include/asm/hpet.h
index f343fe4740f1..9919f7473071 100644
--- a/xen/arch/x86/include/asm/hpet.h
+++ b/xen/arch/x86/include/asm/hpet.h
@@ -89,8 +89,8 @@ void hpet_disable_legacy_replacement_mode(void);
  * Temporarily use an HPET event counter for timer interrupt handling,
  * rather than using the LAPIC timer. Used for Cx state entry.
  */
-void hpet_broadcast_init(void);
-void hpet_broadcast_resume(void);
+void cf_check hpet_broadcast_init(void);
+void cf_check hpet_broadcast_resume(void);
 void cf_check hpet_broadcast_enter(void);
 void cf_check hpet_broadcast_exit(void);
 int hpet_broadcast_is_available(void);
diff --git a/xen/arch/x86/time.c b/xen/arch/x86/time.c
index 043be2a8ec1a..2a1758ebb33b 100644
--- a/xen/arch/x86/time.c
+++ b/xen/arch/x86/time.c
@@ -309,7 +309,7 @@ static uint64_t adjust_elapsed(uint64_t elapsed, uint32_t actual,
  * PLATFORM TIMER 1: PROGRAMMABLE INTERVAL TIMER (LEGACY PIT)
  */
 
-static u64 read_pit_count(void)
+static u64 cf_check read_pit_count(void)
 {
     u16 count16;
     u32 count32;
@@ -328,7 +328,7 @@ static u64 read_pit_count(void)
     return count32;
 }
 
-static s64 __init init_pit(struct platform_timesource *pts)
+static s64 __init cf_check init_pit(struct platform_timesource *pts)
 {
     u8 portb = inb(0x61);
     u64 start, end;
@@ -366,7 +366,7 @@ static s64 __init init_pit(struct platform_timesource *pts)
     return (end - start) * CALIBRATE_FRAC;
 }
 
-static void resume_pit(struct platform_timesource *pts)
+static void cf_check resume_pit(struct platform_timesource *pts)
 {
     /* Set CTC channel 2 to mode 0 again; initial value does not matter. */
     outb(0xb0, PIT_MODE); /* binary, mode 0, LSB/MSB, Ch 2 */
@@ -389,12 +389,12 @@ static struct platform_timesource __initdata plt_pit =
  * PLATFORM TIMER 2: HIGH PRECISION EVENT TIMER (HPET)
  */
 
-static u64 read_hpet_count(void)
+static u64 cf_check read_hpet_count(void)
 {
     return hpet_read32(HPET_COUNTER);
 }
 
-static int64_t __init init_hpet(struct platform_timesource *pts)
+static int64_t __init cf_check init_hpet(struct platform_timesource *pts)
 {
     uint64_t hpet_rate, start;
     uint32_t count, target, elapsed;
@@ -477,7 +477,7 @@ static int64_t __init init_hpet(struct platform_timesource *pts)
     return adjust_elapsed(rdtsc_ordered() - start, elapsed, target);
 }
 
-static void resume_hpet(struct platform_timesource *pts)
+static void cf_check resume_hpet(struct platform_timesource *pts)
 {
     hpet_resume(NULL);
 }
@@ -502,12 +502,12 @@ unsigned int __initdata pmtmr_width;
 /* ACPI PM timer ticks at 3.579545 MHz. */
 #define ACPI_PM_FREQUENCY 3579545
 
-static u64 read_pmtimer_count(void)
+static u64 cf_check read_pmtimer_count(void)
 {
     return inl(pmtmr_ioport);
 }
 
-static s64 __init init_pmtimer(struct platform_timesource *pts)
+static s64 __init cf_check init_pmtimer(struct platform_timesource *pts)
 {
     uint64_t start;
     uint32_t count, target, mask, elapsed;
@@ -562,7 +562,7 @@ static unsigned int __initdata tsc_flags;
  * Called in verify_tsc_reliability() under reliable TSC conditions
  * thus reusing all the checks already performed there.
  */
-static s64 __init init_tsc(struct platform_timesource *pts)
+static s64 __init cf_check init_tsc(struct platform_timesource *pts)
 {
     u64 ret = pts->frequency;
 
@@ -584,7 +584,7 @@ static s64 __init init_tsc(struct platform_timesource *pts)
     return ret;
 }
 
-static u64 read_tsc(void)
+static u64 cf_check read_tsc(void)
 {
     return rdtsc_ordered();
 }
@@ -626,7 +626,7 @@ static uint64_t xen_timer_cpu_frequency(void)
     return freq;
 }
 
-static int64_t __init init_xen_timer(struct platform_timesource *pts)
+static int64_t __init cf_check init_xen_timer(struct platform_timesource *pts)
 {
     if ( !xen_guest )
         return 0;
@@ -647,7 +647,7 @@ static always_inline uint64_t read_cycle(const struct vcpu_time_info *info,
     return info->system_time + offset;
 }
 
-static uint64_t read_xen_timer(void)
+static uint64_t cf_check read_xen_timer(void)
 {
     struct vcpu_time_info *info = &this_cpu(vcpu_info)->time;
     uint32_t version;
@@ -676,7 +676,7 @@ static uint64_t read_xen_timer(void)
     return ret;
 }
 
-static void resume_xen_timer(struct platform_timesource *pts)
+static void cf_check resume_xen_timer(struct platform_timesource *pts)
 {
     write_atomic(&xen_timer_last, 0);
 }
@@ -702,7 +702,8 @@ static struct platform_timesource __initdata plt_xen_timer =
 static struct ms_hyperv_tsc_page *hyperv_tsc;
 static struct page_info *hyperv_tsc_page;
 
-static int64_t __init init_hyperv_timer(struct platform_timesource *pts)
+static int64_t __init cf_check init_hyperv_timer(
+    struct platform_timesource *pts)
 {
     paddr_t maddr;
     uint64_t tsc_msr, freq;
@@ -745,7 +746,7 @@ static int64_t __init init_hyperv_timer(struct platform_timesource *pts)
     return freq;
 }
 
-static uint64_t read_hyperv_timer(void)
+static uint64_t cf_check read_hyperv_timer(void)
 {
     uint64_t scale, ret, tsc;
     int64_t offset;
@@ -1721,7 +1722,7 @@ time_calibration_rendezvous_tail(const struct calibration_rendezvous *r,
  * Keep TSCs in sync when they run at the same rate, but may stop in
  * deep-sleep C states.
  */
-static void time_calibration_tsc_rendezvous(void *_r)
+static void cf_check time_calibration_tsc_rendezvous(void *_r)
 {
     int i;
     struct calibration_rendezvous *r = _r;
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:06:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:06:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271788.466531 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb4B-0008OS-IJ; Mon, 14 Feb 2022 13:06:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271788.466531; Mon, 14 Feb 2022 13:06:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb4A-0008H9-L3; Mon, 14 Feb 2022 13:06:54 +0000
Received: by outflank-mailman (input) for mailman id 271788;
 Mon, 14 Feb 2022 13:06:52 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJb2o-0008IH-Uv
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:05:31 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c85ef101-8d96-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 14:05:29 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c85ef101-8d96-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644843928;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=yHxT60mUhe/bdOaYInkxIEHjxisfTCydkooBUoIXm1M=;
  b=gu3Y0sILdPtKjus+ehUOkt+lF5AKqkB5fkeI2gOi8tzUwmbG1+fMq4yj
   ldeJ2IXcdVfRbcCuHCxNiR6eqvJmguWXNqPNr8uU4vnrHpOEkyWbetcoG
   mOX7QdW1rLSwGRomW9KArB443+V1X9JByHIlG9kvnMyQ+xPeibTMPrNlu
   8=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: IfyhiO4NRjvgMWsYVeStTCJbvfVis7VLr1QbwYda0dNdTcl8JdA14OmEJiDGvL5ZiRmL7+9iNz
 ybln7mX/b0K8VbX7oBwyIeHiwdD9+i2rHYZEH0/cI4VYouSJkZRWYhpdHUoMWqqvuNWny5ci+U
 W37+se8pJsY2NqMjkqd0kjDqsW3dq/J18HEttrVgZYT+TV6Wx/vbicZ4ekYURlmq8uEutugwUk
 3iKHGxZlQCwDZHYIvvpq4DI94oY/G8aEV3bgENtOey/lNSbOhE1EtbMsPcUdD/6vhz+m9SVfcG
 8ZOMzQDMBwZ9NZafczvi9Xnb
X-SBRS: 5.1
X-MesageID: 64149818
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Xwjk2a/KST9YhIf28+VrDrUDnnmTJUtcMsCJ2f8bNWPcYEJGY0x3x
 2QaXG/TMvfZMWb1c40gPtu/9UIF7J/dzoJlSgBt+yE8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhFWeIdA970Ug5w7Rg3tYx6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPh0k
 PUKqryOSDwNFYHSissDfURzMw5haPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguwKKsXxMZxZkXZn1TzDVt4tQIzZQrWM7thdtNs1rp4SRKqPN
 5NJAdZpRDL+cRNBJ24qMYw7rP66rHflUzZy+F3A8MLb5ECMlVcsgdABKuH9atGMAMlYgEucj
 mbH5HjiRAEXMsSFzjiI+W7qgfXA9R4XQ6pLSuf+rKQzxgTOmCpDU3X6SGdXv9G80m75RPJhK
 ncw0QYwv4cs2hGAbvbiCkjQTGG/gjYQXN9ZEusf4Q6Ly7bJ7wvxOlXoXgKte/R96pZoGGVCO
 kuh2oqwWGcx6OH9pWe1q+/MxQ5eLxT5OoPricUsaQIeq+fur4go5v4kZoYySfXl5jEZ9NyZ/
 txrkMTcr+hJ5SLo///ilbwiv95LjsKXJjPZHi2NAgqYAvpRPeZJnbCA51nB9upnJ42EVFSHt
 3Vss5HAsLxRXcHQyXTUG79l8FSVCxGtamO0vLKSN8N5q2TFF4CLIei8Hw2S1G82a51ZKFcFk
 WfYuB9L5Y87AZdZRfQfXm5FMOxzlfKIPY28Dpj8N4MSCrAsJF7v1Hw/Pia4gjGy+HXAZIliY
 P93h+73Vi1EYUmmpRLrL9ogPUgDmHxvmzOLHcqjp/lluJLHDEOopX4+GAPmRogEAGms+W05K
 v5TaJmHzQtxSur7bnWF+IIfNwlSf3M6GYr3u4pccevaelhqH2QoCvnwx7I9etM6w/QJx7mQp
 nztCFVFzFffhGHcLVnYYH5Ud76yD410qmg2PHJwMA/wiWQje4um8IwWa4AzIes87OVmwPMtF
 6sFdsyMD+5hUDPC/zhBP5DxoJY7LEaghB6UPjrjaz86JsYySwvM897iXw3u6ChRUXbn6Zpg+
 +Wtj1qJT4ACSgJuCNftRMiul17h72IAnO9SXlfTJoUBckvb74U3eTf6ieU6Ip9QJEyblCeaz
 QufHTwRufLJ/90u6NDMiK2J89WpHu95EhYIFmXX9+/rZyzT/27lyo5cSueYOzvaUTqsqqmlY
 OxUydD6MeEGwwkW49YtTe4zwPJs/cbrqp9b0h9gTSfCYFmcA799JmWLgJtUvapXy74F4Qa7V
 ypjIDWB1Wll7C89LGMsGQ==
IronPort-HdrOrdr: A9a23:UjVNE6/VeiQbj227Zatuk+DaI+orL9Y04lQ7vn2YSXRuHPBw9v
 re5cjzuiWVtN98Yh0dcJW7Scy9qBDnhPhICOsqTNSftWDd0QPCRuxfBMnZslnd8kXFh4lgPM
 xbEpSWZueeMbEDt7eZ3DWF
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="64149818"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v2 18/70] xsm/flask/ss: CFI hardening
Date: Mon, 14 Feb 2022 12:50:35 +0000
Message-ID: <20220214125127.17985-19-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

Control Flow Integrity schemes use toolchain and optionally hardware support
to help protect against call/jump/return oriented programming attacks.

Use cf_check to annotate function pointer targets for the toolchain.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Daniel P. Smith <dpsmith@apertussolutions.com>
---
 xen/xsm/flask/ss/avtab.c       |  4 ++--
 xen/xsm/flask/ss/conditional.c | 10 ++++----
 xen/xsm/flask/ss/conditional.h |  6 ++---
 xen/xsm/flask/ss/policydb.c    | 53 ++++++++++++++++++++++--------------------
 xen/xsm/flask/ss/services.c    |  6 ++---
 xen/xsm/flask/ss/symtab.c      |  5 ++--
 6 files changed, 44 insertions(+), 40 deletions(-)

diff --git a/xen/xsm/flask/ss/avtab.c b/xen/xsm/flask/ss/avtab.c
index bfc91c8b0c2c..55c2b4d8a46d 100644
--- a/xen/xsm/flask/ss/avtab.c
+++ b/xen/xsm/flask/ss/avtab.c
@@ -482,8 +482,8 @@ int avtab_read_item(struct avtab *a, void *fp, struct policydb *pol,
     return insertf(a, &key, &datum, p);
 }
 
-static int avtab_insertf(struct avtab *a, struct avtab_key *k,
-                                                struct avtab_datum *d, void *p)
+static int cf_check avtab_insertf(
+    struct avtab *a, struct avtab_key *k, struct avtab_datum *d, void *p)
 {
     return avtab_insert(a, k, d);
 }
diff --git a/xen/xsm/flask/ss/conditional.c b/xen/xsm/flask/ss/conditional.c
index 3e58aea55147..b4b116666cf7 100644
--- a/xen/xsm/flask/ss/conditional.c
+++ b/xen/xsm/flask/ss/conditional.c
@@ -189,14 +189,14 @@ int cond_init_bool_indexes(struct policydb *p)
     return 0;
 }
 
-int cond_destroy_bool(void *key, void *datum, void *p)
+int cf_check cond_destroy_bool(void *key, void *datum, void *p)
 {
     xfree(key);
     xfree(datum);
     return 0;
 }
 
-int cond_index_bool(void *key, void *datum, void *datap)
+int cf_check cond_index_bool(void *key, void *datum, void *datap)
 {
     struct policydb *p;
     struct cond_bool_datum *booldatum;
@@ -220,7 +220,7 @@ static int bool_isvalid(struct cond_bool_datum *b)
     return 1;
 }
 
-int cond_read_bool(struct policydb *p, struct hashtab *h, void *fp)
+int cf_check cond_read_bool(struct policydb *p, struct hashtab *h, void *fp)
 {
     char *key = NULL;
     struct cond_bool_datum *booldatum;
@@ -268,8 +268,8 @@ struct cond_insertf_data
     struct cond_av_list *tail;
 };
 
-static int cond_insertf(struct avtab *a, struct avtab_key *k, 
-                                            struct avtab_datum *d, void *ptr)
+static int cf_check cond_insertf(
+    struct avtab *a, struct avtab_key *k, struct avtab_datum *d, void *ptr)
 {
     struct cond_insertf_data *data = ptr;
     struct policydb *p = data->p;
diff --git a/xen/xsm/flask/ss/conditional.h b/xen/xsm/flask/ss/conditional.h
index 59ac6b4b57c1..500fe4305a03 100644
--- a/xen/xsm/flask/ss/conditional.h
+++ b/xen/xsm/flask/ss/conditional.h
@@ -63,11 +63,11 @@ int cond_policydb_init(struct policydb* p);
 void cond_policydb_destroy(struct policydb* p);
 
 int cond_init_bool_indexes(struct policydb* p);
-int cond_destroy_bool(void *key, void *datum, void *p);
+int cf_check cond_destroy_bool(void *key, void *datum, void *p);
 
-int cond_index_bool(void *key, void *datum, void *datap);
+int cf_check cond_index_bool(void *key, void *datum, void *datap);
 
-int cond_read_bool(struct policydb *p, struct hashtab *h, void *fp);
+int cf_check cond_read_bool(struct policydb *p, struct hashtab *h, void *fp);
 int cond_read_list(struct policydb *p, void *fp);
 
 void cond_compute_av(struct avtab *ctab, struct avtab_key *key, struct av_decision *avd);
diff --git a/xen/xsm/flask/ss/policydb.c b/xen/xsm/flask/ss/policydb.c
index 94261643532a..ff2103c63eab 100644
--- a/xen/xsm/flask/ss/policydb.c
+++ b/xen/xsm/flask/ss/policydb.c
@@ -257,12 +257,12 @@ static int policydb_init(struct policydb *p)
  * of a class, role, or user are needed.
  */
 
-static int common_index(void *key, void *datum, void *datap)
+static int cf_check common_index(void *key, void *datum, void *datap)
 {
     return 0;
 }
 
-static int class_index(void *key, void *datum, void *datap)
+static int cf_check class_index(void *key, void *datum, void *datap)
 {
     struct policydb *p;
     struct class_datum *cladatum;
@@ -276,7 +276,7 @@ static int class_index(void *key, void *datum, void *datap)
     return 0;
 }
 
-static int role_index(void *key, void *datum, void *datap)
+static int cf_check role_index(void *key, void *datum, void *datap)
 {
     struct policydb *p;
     struct role_datum *role;
@@ -292,7 +292,7 @@ static int role_index(void *key, void *datum, void *datap)
     return 0;
 }
 
-static int type_index(void *key, void *datum, void *datap)
+static int cf_check type_index(void *key, void *datum, void *datap)
 {
     struct policydb *p;
     struct type_datum *typdatum;
@@ -313,7 +313,7 @@ static int type_index(void *key, void *datum, void *datap)
     return 0;
 }
 
-static int user_index(void *key, void *datum, void *datap)
+static int cf_check user_index(void *key, void *datum, void *datap)
 {
     struct policydb *p;
     struct user_datum *usrdatum;
@@ -329,7 +329,7 @@ static int user_index(void *key, void *datum, void *datap)
     return 0;
 }
 
-static int sens_index(void *key, void *datum, void *datap)
+static int cf_check sens_index(void *key, void *datum, void *datap)
 {
     struct policydb *p;
     struct level_datum *levdatum;
@@ -348,7 +348,7 @@ static int sens_index(void *key, void *datum, void *datap)
     return 0;
 }
 
-static int cat_index(void *key, void *datum, void *datap)
+static int cf_check cat_index(void *key, void *datum, void *datap)
 {
     struct policydb *p;
     struct cat_datum *catdatum;
@@ -506,14 +506,14 @@ static int policydb_index_others(struct policydb *p)
  * symbol data in the policy database.
  */
 
-static int perm_destroy(void *key, void *datum, void *p)
+static int cf_check perm_destroy(void *key, void *datum, void *p)
 {
     xfree(key);
     xfree(datum);
     return 0;
 }
 
-static int common_destroy(void *key, void *datum, void *p)
+static int cf_check common_destroy(void *key, void *datum, void *p)
 {
     struct common_datum *comdatum;
 
@@ -525,7 +525,7 @@ static int common_destroy(void *key, void *datum, void *p)
     return 0;
 }
 
-static int class_destroy(void *key, void *datum, void *p)
+static int cf_check class_destroy(void *key, void *datum, void *p)
 {
     struct class_datum *cladatum;
     struct constraint_node *constraint, *ctemp;
@@ -572,7 +572,7 @@ static int class_destroy(void *key, void *datum, void *p)
     return 0;
 }
 
-static int role_destroy(void *key, void *datum, void *p)
+static int cf_check role_destroy(void *key, void *datum, void *p)
 {
     struct role_datum *role;
 
@@ -584,14 +584,14 @@ static int role_destroy(void *key, void *datum, void *p)
     return 0;
 }
 
-static int type_destroy(void *key, void *datum, void *p)
+static int cf_check type_destroy(void *key, void *datum, void *p)
 {
     xfree(key);
     xfree(datum);
     return 0;
 }
 
-static int user_destroy(void *key, void *datum, void *p)
+static int cf_check user_destroy(void *key, void *datum, void *p)
 {
     struct user_datum *usrdatum;
 
@@ -605,7 +605,7 @@ static int user_destroy(void *key, void *datum, void *p)
     return 0;
 }
 
-static int sens_destroy(void *key, void *datum, void *p)
+static int cf_check sens_destroy(void *key, void *datum, void *p)
 {
     struct level_datum *levdatum;
 
@@ -617,7 +617,7 @@ static int sens_destroy(void *key, void *datum, void *p)
     return 0;
 }
 
-static int cat_destroy(void *key, void *datum, void *p)
+static int cf_check cat_destroy(void *key, void *datum, void *p)
 {
     xfree(key);
     xfree(datum);
@@ -989,7 +989,7 @@ static int perm_read(struct policydb *p, struct hashtab *h, void *fp)
     goto out;
 }
 
-static int common_read(struct policydb *p, struct hashtab *h, void *fp)
+static int cf_check common_read(struct policydb *p, struct hashtab *h, void *fp)
 {
     char *key = NULL;
     struct common_datum *comdatum;
@@ -1151,7 +1151,7 @@ static int read_cons_helper(struct policydb *p, struct constraint_node **nodep,
     return 0;
 }
 
-static int class_read(struct policydb *p, struct hashtab *h, void *fp)
+static int cf_check class_read(struct policydb *p, struct hashtab *h, void *fp)
 {
     char *key = NULL;
     struct class_datum *cladatum;
@@ -1250,7 +1250,7 @@ static int class_read(struct policydb *p, struct hashtab *h, void *fp)
     goto out;
 }
 
-static int role_read(struct policydb *p, struct hashtab *h, void *fp)
+static int cf_check role_read(struct policydb *p, struct hashtab *h, void *fp)
 {
     char *key = NULL;
     struct role_datum *role;
@@ -1321,7 +1321,7 @@ static int role_read(struct policydb *p, struct hashtab *h, void *fp)
     goto out;
 }
 
-static int type_read(struct policydb *p, struct hashtab *h, void *fp)
+static int cf_check type_read(struct policydb *p, struct hashtab *h, void *fp)
 {
     char *key = NULL;
     struct type_datum *typdatum;
@@ -1415,7 +1415,7 @@ static int mls_read_level(struct mls_level *lp, void *fp)
     return -EINVAL;
 }
 
-static int user_read(struct policydb *p, struct hashtab *h, void *fp)
+static int cf_check user_read(struct policydb *p, struct hashtab *h, void *fp)
 {
     char *key = NULL;
     struct user_datum *usrdatum;
@@ -1479,7 +1479,7 @@ static int user_read(struct policydb *p, struct hashtab *h, void *fp)
     goto out;
 }
 
-static int sens_read(struct policydb *p, struct hashtab *h, void *fp)
+static int cf_check sens_read(struct policydb *p, struct hashtab *h, void *fp)
 {
     char *key = NULL;
     struct level_datum *levdatum;
@@ -1534,7 +1534,7 @@ static int sens_read(struct policydb *p, struct hashtab *h, void *fp)
     goto out;
 }
 
-static int cat_read(struct policydb *p, struct hashtab *h, void *fp)
+static int cf_check cat_read(struct policydb *p, struct hashtab *h, void *fp)
 {
     char *key = NULL;
     struct cat_datum *catdatum;
@@ -1591,7 +1591,8 @@ static int (*read_f[SYM_NUM]) (struct policydb *p, struct hashtab *h, void *fp)
     cat_read,
 };
 
-static int user_bounds_sanity_check(void *key, void *datum, void *datap)
+static int cf_check user_bounds_sanity_check(
+    void *key, void *datum, void *datap)
 {
     struct user_datum *upper, *user;
     struct policydb *p = datap;
@@ -1631,7 +1632,8 @@ static int user_bounds_sanity_check(void *key, void *datum, void *datap)
     return 0;
 }
 
-static int role_bounds_sanity_check(void *key, void *datum, void *datap)
+static int cf_check role_bounds_sanity_check(
+    void *key, void *datum, void *datap)
 {
     struct role_datum *upper, *role;
     struct policydb *p = datap;
@@ -1671,7 +1673,8 @@ static int role_bounds_sanity_check(void *key, void *datum, void *datap)
     return 0;
 }
 
-static int type_bounds_sanity_check(void *key, void *datum, void *datap)
+static int cf_check type_bounds_sanity_check(
+    void *key, void *datum, void *datap)
 {
     struct type_datum *upper, *type;
     struct policydb *p = datap;
diff --git a/xen/xsm/flask/ss/services.c b/xen/xsm/flask/ss/services.c
index 42686535f2c4..2f6d3d350d05 100644
--- a/xen/xsm/flask/ss/services.c
+++ b/xen/xsm/flask/ss/services.c
@@ -283,7 +283,7 @@ static int constraint_expr_eval(struct context *scontext,
  * security_dump_masked_av - dumps masked permissions during
  * security_compute_av due to RBAC, MLS/Constraint and Type bounds.
  */
-static int dump_masked_av_helper(void *k, void *d, void *args)
+static int cf_check dump_masked_av_helper(void *k, void *d, void *args)
 {
     struct perm_datum *pdatum = d;
     char **permission_names = args;
@@ -1240,7 +1240,7 @@ static int validate_classes(struct policydb *p)
 }
 
 /* Clone the SID into the new SID table. */
-static int clone_sid(u32 sid, struct context *context, void *arg)
+static int cf_check clone_sid(u32 sid, struct context *context, void *arg)
 {
     struct sidtab *s = arg;
 
@@ -1277,7 +1277,7 @@ struct convert_context_args {
  * in the policy `p->newp'.  Verify that the
  * context is valid under the new policy.
  */
-static int convert_context(u32 key, struct context *c, void *p)
+static int cf_check convert_context(u32 key, struct context *c, void *p)
 {
     struct convert_context_args *args;
     struct context oldc;
diff --git a/xen/xsm/flask/ss/symtab.c b/xen/xsm/flask/ss/symtab.c
index d98c116d5b97..0ce7e08c24ea 100644
--- a/xen/xsm/flask/ss/symtab.c
+++ b/xen/xsm/flask/ss/symtab.c
@@ -12,7 +12,7 @@
 #include <xen/errno.h>
 #include "symtab.h"
 
-static unsigned int symhash(struct hashtab *h, const void *key)
+static unsigned int cf_check symhash(struct hashtab *h, const void *key)
 {
     const char *p, *keyp;
     unsigned int size;
@@ -26,7 +26,8 @@ static unsigned int symhash(struct hashtab *h, const void *key)
     return val & (h->size - 1);
 }
 
-static int symcmp(struct hashtab *h, const void *key1, const void *key2)
+static int cf_check symcmp(
+    struct hashtab *h, const void *key1, const void *key2)
 {
     const char *keyp1, *keyp2;
 
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:10:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:10:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271856.466555 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb7z-000553-6G; Mon, 14 Feb 2022 13:10:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271856.466555; Mon, 14 Feb 2022 13:10:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb7z-00054w-3G; Mon, 14 Feb 2022 13:10:51 +0000
Received: by outflank-mailman (input) for mailman id 271856;
 Mon, 14 Feb 2022 13:10:49 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJb7x-00054q-De
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:10:49 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 85963637-8d97-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 14:10:47 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 85963637-8d97-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644844247;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=Gjteq4o6ekOhtftPo0iUqz/+mLLuuNCqewER07oN4P8=;
  b=a53yvlqlNNuF3NQ9SBZu8nVKdeBbuLAGYFXU0+KHaXkzjusyOpzoMHNC
   969ueDqus6pzq+UFjinLY6bHeNzi0kEs75PH9ThdeBVWUTkN1ehl/z5SG
   uATpycheoUPmqI4mDEpFUjzQwqklWSy4Qiep6QQXrfKsJTSx26Hs6HeSU
   Q=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: tHlTv38JLab9bUI9A+a6q9S+zbLJ6lUMZ7iVN/xfBWm6EKu0gblU1eEH8JJFMJbQxmvsHKfl0a
 jKDgHEJND+K1ZQdtSsaZZeRh69shZzoikndwHJ+exsUylcNMSiI/qc0ptAOTBPJclDpe1eQavP
 FPLJT/FXq3a0SulLYuVdg+xq/g1GBEvdQ7W+pD0ZdwdwMWKzeWMAWWYF28LEV7CaKplGyuN0Y4
 VOZOCXxpfg3r6q3XurFJq6DC1aKTRPMSrLLv38MJiJrc9lR718IJ63onRnj9aouytw/9iPXGSC
 qEEsfdX24C8OLMVSlmo1+kjF
X-SBRS: 5.1
X-MesageID: 64149892
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:H5wrZayFi0HmngOUiPR6t+d7wCrEfRIJ4+MujC+fZmUNrF6WrkUHm
 2dJCm6Fb/2NZzH2KN0nbI/noUNT75XSzNM3TgQ/riAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAhLeNYYH1500g7wbdl2tcAbeWRWGthh
 /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL
 wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt9t47
 d5IhIe6ciEgB5eSkbUxVTJHHAgraMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr
 6ZBbmlQMFbT3Ipaw5riIgVoru0lINPmI8U0vXZ4wCuCJf0nXYrCU+PB4towMDIY2JwXQaeON
 pBxhTxHZiXKXDplGQkrMLUSjsz1tEX0NB51kQfAzUYwyzeKl1EguFT3C/LXdcaNXt59hVuDq
 yTN+GGRKhMHMN2SzxKV/3TqgfXA9Qv+UZgXHae19dZrhkOS3W0ZDBAKVVq9ruK9g0T4UNVaQ
 2QY4jErrLQy3EWzQ8PhQgajp3qZoh8bXcEWGOo/gCmv4KfJ5weSBkAfUyVMLtchsaceVTEsk
 1OEgd7tLThuq6GOD2KQ8K+OqjG/MjRTKnUNDQcbSSMV7t+lp5s85jrUVcpqGqOxitzzGBnzz
 iqMoSx4gK8c5fPnzI3iowqB2Wj14MGUEEhlvW07Q15J8CtybauuYr2z42P95M96co/IYl+qo
 3ctzp32AP81MbmBkymEQeMoFb6v5uqYPDC0vWODD6XN5Bz2pSf9INk4DCVWYR4wb51aIWOBj
 Fr75FsJjKK/KkdGekOej2iZL80xhZbtGt3+Phw/RoofO8MhHONrEcwHWKJx44wPuBV2+U3cE
 c3CGSpJMZr9If45pAdav89HjdcWKtkWnAs/v6zTwRW9yqa5b3WIU7oDO1bmRrlnsP/b8FWIr
 o4GbJHiJ/BjvArWOHe/zGLuBQpScShT6W7e96S7idJv0iI5QTp8Wpc9MJsqepB/nrQ9qws71
 irVZ6Os83Km3SevAVzTMhhLMeqzNb4i/SNTFXF9Zj6Ahil8CbtDGY9CLvPbi5F8r7c9pRO1J
 tFYE/i97gNnFGiWpWRFNcOlxGGgHTzy7T+z0+OeSGFXV7ZrRhDT+8+ieQ3q9SIUCTGwu9d4q
 Lqlvj43i7JZL+i7JMqJOv+p0X2run0RxLB7U0fSe4EBc0Tw6ol6bSf2i6Zvcc0LLBzCwBqc1
 hqXXkhE9bWc/ddt/Ymbn72AoqeoD/B6QhhQEV7E4OvkLiLd5Gein9NNCb7aYTDHWWro06y+f
 uEJnerkOfgKkQ8S4YpxGrpm14wk4N7rq+MIxwhoBiyTPV+qFqlhMj+N2swW7v9BwbpQuA2XX
 EOT+4YFZeXVaZ29SFNIfVgrdOWO0/0QiwL+1/VtLRWo/jJz8ZqGTV5WY0uGhhtCIeYnK4gi2
 +og5pIbslTtlhowP9+apSlI7GDQfGcYWqAqu5xGUo/mjg0nlgNLbZDGU3Kk5ZiOb5NHM1UwI
 y/Sj63H3uwOyk3Hens1NH7MwesC2she5EEUlAcPdwaTh97Ipv4rxxkAoz04QzNcwghDz+8ua
 HNgMFd4JPnW8jpl7CSZs7tAx+2V6MWlx3HM
IronPort-HdrOrdr: A9a23:XFMRdKh3bdeGPvrg8W1JfGP4Q3BQXtgji2hC6mlwRA09TySZ//
 rBoB17726MtN9/YhEdcLy7VJVoBEmskKKdgrNhW4tKPjOW21dARbsKheCJrgEIWReOktK1vZ
 0QFJSWY+eQMbEVt6nHCXGDYrQd/OU=
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="64149892"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XJjqPJd+g8G4O16hgABXbx9yZKnsgx3Cl/7TeFdry+HEtmDu1Ms5fZTRw+Nn1XZIEc7yUl1JhYg20DWT0qUzN4b8T78r7/cWPGUp7zfsksmGJD43u9lu2+Vokkka+Gjo991zH8QuGADORXaJeVdKLpwHZSl+zOGLtNsEx3cNpwwQ7jEGGtihMWtGms5urRXK6Pv+rI40/0jfxPVF45ycWhX3kwqdL/Kv2CgHA+snzhFH3XSwES8pjbsN2BpqrAoIpZ37YSSscEmkO5NWi/UaU9ONQH2TL9kGjQnrf9s7pvVTbwOTjXEEZD9UHHF0CWZ7l1Lkz6y/tKhQ/5XQ5aeCDg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Gjteq4o6ekOhtftPo0iUqz/+mLLuuNCqewER07oN4P8=;
 b=hCXZhO1ZaFsw7D8isrfZfEqtiujvOXXKsm7Oeh9w39GkejNiDvZ3rdVpuikVE3gaRI+k1lq5fGYaRFlogbh6X6q3pjENhEeanvrLXVQct6rmfmqGmJSHhPbyNB9lD4JrUhdmdcug+aBTSpTAYEO30+eH7LLOu5ya1v3WqGGAu92p2y3TPm1Hpwmnk61MYRhNNzhYvTSAwU138KMBEAV0nFa0Bq/OPxD32/H359MVi5R6Sgw/rmm4u8Q2UIYdrGJE5LxlrWYoyocILKnU8efj4KBSUoFLWjDLA62WM2cLynD6BkHHydkWLb+fi6hTUl1ZbF691U/kXMMAcskjonmOtA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Gjteq4o6ekOhtftPo0iUqz/+mLLuuNCqewER07oN4P8=;
 b=HhwzBu53IxOrRmhODmQQbrUMTJdX+4Haxaq0rFo1J+GLw2LEFqe1xynngoC7V+GPcmKZ3HCCsapGFqKh8doUmSKcoGFO1v8cIBpJsGgpJY140yjwWOZcjnftrnbjPPeSyiVL7wl6mGl/1YwdyN0pUiJNF6sUe9qAz/j41Lewz2I=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Jan Beulich <JBeulich@suse.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Wei Liu <wl@xen.org>, Julien Grall
	<julien@xen.org>, Roger Pau Monne <roger.pau@citrix.com>, Juergen Gross
	<jgross@suse.com>, Daniel Smith <dpsmith@apertussolutions.com>,
	=?utf-8?B?TWFyZWsgTWFyY3p5a293c2tpLUfDs3JlY2tp?=
	<marmarek@invisiblethingslab.com>
Subject: Re: [PATCH v2 00/70] x86: Support for CET Indirect Branch Tracking
Thread-Topic: [PATCH v2 00/70] x86: Support for CET Indirect Branch Tracking
Thread-Index: AQHYIaGi+1XAXGQfKUGTLygtpBu/SKyTBUWA
Date: Mon, 14 Feb 2022 13:10:41 +0000
Message-ID: <c471dcc2-8a91-60b8-ba5d-58874752e4d7@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 42c2eea5-40c4-4d85-437b-08d9efbb673a
x-ms-traffictypediagnostic: CY1PR03MB2313:EE_
x-microsoft-antispam-prvs: <CY1PR03MB23138B312C7B3EA43E4DADC3BA339@CY1PR03MB2313.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:2043;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: HhALCAXDuP4Xjexs4nzH/EORrm5pafhN5IJPQnohuebDNFy8GVWox+a9Px40OtGGaFKel5HxvqwKWSxm6msu81rNyn6H4uIPIRRdI/28kLQu1WDh7BdKAjeW/pxhK98X+1GY1zfonl1ATWZZz2fIxzFhL5PQ0njx0R6TsORYihrelBaDaAlyLCIweR3ZWQOvEALPmfSzhryiOwmQyr19EvgsumlwJ5Scb9uHuPMptxO8lM193dx3IGUK/U3ytSG9jgDOUM56231q8KfAo9CwS1ZxZvOwTFhqSQ1fCtZLz+zwXljgxtZD49i/e4ICYwAt6ZEaK97+Uu1Z495oUkXlFaOAJ0WY5Ngo2PD9RT3Xz6/vzfZHtycQQp5TYfyNROq1GrX8G3qOyz4yXnyBk0pb6H1i5dVyHxDI00j0MiKV6Skk1ReW8uyrPT2jzgoTkC9Ua3TCoLvT6v5pXaYURzzDzbWHF18+vxq4ETXkV4yP9cHj3N+hlErdCB9/mHgvJKtFKSTTcyvh54Dhykz1Rwwygj+oOfBKRAJL29WDgMr59FrqAzxq88pCWQA2PVrIlvTifUI8trUNnP3yr/hdE4bAFLunCjjAhaWIQY9PYJVdBJtV2RbO9j913nwPLz3K8Grhoj7P1HXO2vY2MnP1ELaUq5dHm/qeapBc7yHHVPhW/1xvTugzpUmicwkdsafd3DOLpZIZ28YSYwey/TL4fAiDOnkLPyCatCtkhlwew/3nCem/GREuRvfhMaQO4nYmI1pRrE71UO291hSEA9TPhLT2V5HLs/AYoxM4uUAHg4xTctFmWoYQnIVejL5/aHXFFKj1GMiih13Gn4HAtKilhtU3oV0Mwjig0JQaDkP7iJxaey0kdh8Io7gf326huCFjtDqtsMYAbcVnp0sGQdAvqRTU7Q==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6506007)(2906002)(6486002)(53546011)(86362001)(966005)(31696002)(82960400001)(38070700005)(316002)(5660300002)(71200400001)(26005)(76116006)(31686004)(64756008)(66946007)(66556008)(66476007)(66446008)(91956017)(38100700002)(186003)(6916009)(8936002)(4326008)(8676002)(508600001)(6512007)(54906003)(2616005)(36756003)(122000001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?cmQyREhQeGlSS2lkQVk1ZFg0V1pOZWVocVQ2OXJ1eTBGSzhleU9oR2JBM0ZI?=
 =?utf-8?B?NFQ1Y1pKR1RCT201Kzh1RHdjNXVPR1FLSkZ5ZFk2UDgrdEpxQ08rczVUdGMr?=
 =?utf-8?B?cjI3L0dTMmM3OWlwLzRabjI2ZzRSVWdjcFQxWSsrRVpXMXNRaTNmTGJiWnA1?=
 =?utf-8?B?MWZaNHVKbDJ1OXRUc3RiYWlyNmhMQm54dWV1SEgzWnJudmwvQnNPaEpjbGdu?=
 =?utf-8?B?VWxuRUhjL0pQZU5MbnlyN3FzeEFGUXEyQUZ4bENVa1Body9YZFF2ZkMxOGxW?=
 =?utf-8?B?aEhZV0tWRUtzdzBYNnJxRFdMZDZwa2tVS1ZzTUxQWnVUQXJvVnZYenRjRnl5?=
 =?utf-8?B?MnlzWHRyOWYxeGFiT3JOc3ErL0ZtSnZWMExBSlQ2TitBYmNzOUdtb2NNbXpv?=
 =?utf-8?B?RjJSQ013ODkyL093WlBzMGtobEtyT3gvSkdZNjE1cExOb1pERXhZaWs3MGZq?=
 =?utf-8?B?anZ2NUFPdHFLeFZRUUcrRzk0c3ZReW9qQytPd0M0NWdrWk94UWtheEYrVmZG?=
 =?utf-8?B?RWdtSExWRVFaSS9LNHQrUDJNT211U0xUTE9DTUZ4WGwxQWl3Qks0SVFvdDYz?=
 =?utf-8?B?bzJKVDlGOVN4Z3plN09vR0hBejZ6a0hzZytJdXRZQUdibXE0dXd0clpFNW9m?=
 =?utf-8?B?UjZQc1FwV3grWXZpQ0xoR1dKNS9HR1JTWjY1RmpmbzExRU5Ganp3cG9MeHYr?=
 =?utf-8?B?aFVGQ1k4cUhIZGlFUEZJV2ttN1FINHQyU2RQR0tPYmdNdCtnbDhwR0ZrMnZ4?=
 =?utf-8?B?TDdPZjhLUGFYSlBaTlNYeTJYblR2MTNqakZSM1R2cnBDNi9wTXY4SHQrMGJo?=
 =?utf-8?B?d3JlamFVbGMrSlB5NUVvVDRuUGxUc1hoUjZuZHN1NUhBNmNuWXFtays0c2c3?=
 =?utf-8?B?UzY4RW5tdDhxcXpKVmxRMHBJWEdVdUtCbkcyM1dXZUN5RXpoVGV5UXNVMGVI?=
 =?utf-8?B?Q2ZRek8wdm96NDQzOTZua25KQVhZdC9NQlFFM3cyNVJDT24yY21VbGM2WnhN?=
 =?utf-8?B?SlJkbjdpTFE1eFlEUVZ1cnZzQmJJU2dncHhiaStYNmpUR3NpWDl5ZHpWb3R1?=
 =?utf-8?B?U2UreUt2dmZjQVFoc3hGcTZuL2FTdXV6T0g2aTh4dXFmb0FlSG9oaHFUU3Vp?=
 =?utf-8?B?QkxXT1U3QnlMeUJGNHRUQlo4ZlZ5NVlZWDErazBKNkZlb1Awa2F3SXpTNjRh?=
 =?utf-8?B?Q0MrSG03bVZJMU5vZ2Z6OGJpcVZ4MmxoblhraFZDR25UdFpTeXhTK1Z2eGVi?=
 =?utf-8?B?S3lDMWdLKzc5cWFNNi9LTW1BbmsyTEhQWkdad1RmVk10bk9GdFlNRGRVQXRK?=
 =?utf-8?B?ejJmenZZZ1BER21PSmZVbHVSZWE1ZTJBUU1tWjNRNlFhaHg2Wmw4VWVSSC9M?=
 =?utf-8?B?ZTZQMGYvcUhNSlhmN3cwTmNNQk9yU0M5VHRqUWpZQ1BHU3pnUGllZHUzOGNW?=
 =?utf-8?B?eStNR3NBK2FJdERBcEpJSWEvbWZXSVhFdzFxeStSZ1VNTy9IMEtxdWtsU0tx?=
 =?utf-8?B?TG5mL2p5K2UvUVhaUkt5eWxVV3NNN0J5UzlzY0xaSDJFVVVxRVJZalpGMVpk?=
 =?utf-8?B?VzladGtTb04vUlRBREl2RUkrOEpFK3c3SzN5VEk3MHdBMnVPOVlHY1A2NVJC?=
 =?utf-8?B?emc1bWM5QlRpWktUTkxtQUkxNWl0ekc2T1dlUTZsMGUyOXZYek9HSzJOMTRB?=
 =?utf-8?B?SGtrZkpUNXdTOU14N0NaaHJtWjB1Smh4QlJXd2xkcFJCTlAwc3ZTNzBxWUYy?=
 =?utf-8?B?S1gzS25CdXZhQmJtbTJJQ3V6R1hmWHdRV0dUbkhtWjB3RnpGYXoyZzhjaTEz?=
 =?utf-8?B?S1lWY0g3VlAvYzdsSk8zQTFNRWpaU3dpMWJTWm1jblZsN0x3UGdTSUVDVW80?=
 =?utf-8?B?MVNRU2pCR2NEQ1JreGdxQ0JsTGh0WXFTVktWZHJleUhEUEkvdk9DTS9BKzdG?=
 =?utf-8?B?eXZKZnhBbjl1WjBNRUdWN1ZSVS9MRlZxQVpBTFhlNXREQ3FvSzZaWW5zNVVm?=
 =?utf-8?B?TXgyVFhJVU9IZ0I5TjZpcjV1TW5GRTN6cXFlTCtEbUI3MDdXYmRja29MRUww?=
 =?utf-8?B?TkpZbVFjcnZPd0pqTkRlanYyVnR2ZDlFOVgrSHdUa3ZnRDdISE94c25iY3dx?=
 =?utf-8?B?TVdXSm1NZUhPZFVMVUZUMnlsTjNqSDIyTWc3SDVYK1JUNGFTYzVjeHVrVzF3?=
 =?utf-8?B?THVRcTdyOVVtMzRlMUJQMnZDZmdmWEgxMWZVVEZXYzdtM3lIVTZMSFNyU1lw?=
 =?utf-8?B?WnRFd1B3K3VHd1hhK2JSWWVmdE13PT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <653242B37BA05E4D9E4993B86E3E7F13@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 42c2eea5-40c4-4d85-437b-08d9efbb673a
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Feb 2022 13:10:41.6930
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 9fxuiVsV4zznkOILQOHd3ITvp/z8GE0rZHN09schussZ1XuYfbjG/rl8lSewntYqwWKvFHFsr1tRqWxiqscXT9HT1M9W8C4zQddnV7PiHKg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR03MB2313
X-OriginatorOrg: citrix.com

T24gMTQvMDIvMjAyMiAxMjo1MCwgQW5kcmV3IENvb3BlciB3cm90ZToNCj4gQ0VUIEluZGlyZWN0
IEJyYW5jaCBUcmFja2luZyBpcyBhIGhhcmR3YXJlIGZlYXR1cmUgZGVzaWduZWQgdG8gcHJvdGVj
dCBhZ2FpbnN0DQo+IGZvcndhcmQtZWRnZSBjb250cm9sIGZsb3cgaGlqYWNraW5nIChDYWxsL0p1
bXAgb3JpZW50ZWQgcHJvZ3JhbW1pbmcpLCBhbmQgaXMgYQ0KPiBjb21wYW5pb24gZmVhdHVyZSB0
byBDRVQgU2hhZG93IFN0YWNrcyBhZGRlZCBpbiBYZW4gNC4xNC4NCj4NCj4gUGF0Y2hlcyAxIHRo
cnUgNSBhcmUgcHJlcmVxdWlzaXRlcy4gIFBhdGNoZXMgNiB0aHJ1IDYwIGFyZSBmYWlybHkgbWVj
aGFuaWNhbA0KPiBhbm5vdGF0aW9ucyBvZiBmdW5jdGlvbiBwb2ludGVyIHRhcmdldHMuICBQYXRj
aGVzIDYxIHRocnUgNzAgYXJlIHRoZSBmaW5hbA0KPiBlbmFibGVtZW50IG9mIENFVC1JQlQuDQo+
DQo+IFRoaXMgc2VyaWVzIGZ1bmN0aW9ucyBjb3JyZWN0bHkgd2l0aCBHQ0MgOSBhbmQgbGF0ZXIs
IGFsdGhvdWdoIGFuIGV4cGVyaW1lbnRhbA0KPiBHQ0MgcGF0Y2ggaXMgcmVxdWlyZWQgdG8gZ2V0
IG1vcmUgaGVscGZ1bCB0eXBlY2hlY2tpbmcgYXQgYnVpbGQgdGltZS4NCj4NCj4gVGVzdGVkIG9u
IGEgVGlnZXJMYWtlIE5VQy4NCj4NCj4gQ0kgcGlwZWxpbmVzOg0KPiAgIGh0dHBzOi8vZ2l0bGFi
LmNvbS94ZW4tcHJvamVjdC9wZW9wbGUvYW5keWhocC94ZW4vLS9waXBlbGluZXMvNDcwNDUzNjUy
DQo+ICAgaHR0cHM6Ly9jaXJydXMtY2kuY29tL2J1aWxkLzQ5NjIzMDgzNjIzMzgzMDQNCj4NCj4g
TWFqb3IgY2hhbmdlcyBmcm9tIHYxOg0KPiAgKiBCb2lsZXJwbGF0ZSBmb3IgbWVjaGFuaWNhbCBj
b21taXRzDQo+ICAqIFVFRkkgcnVudGltZSBzZXJ2aWNlcyB1bmNvbmRpdGlvbmFsbHkgZGlzYWJs
ZSBJQlQNCj4gICogQ29tcHJlaGVuc2l2ZSBidWlsZCB0aW1lIGNoZWNrIGZvciBlbWJlZGRlZCBl
bmRicidzDQoNClRoZXJlJ3Mgb25lIHRoaW5nIEkgY29uc2lkZXJlZCwgYW5kIHdhbnRlZCB0byBk
aXNjdXNzLg0KDQpJJ20gdGVtcHRlZCB0byByZW5hbWUgY2ZfY2hlY2sgdG8gY2ZpIGZvciB0aGUg
ZnVuY3Rpb24gYW5ub3RhdGlvbiwgYXMNCml0J3Mgc2hvcnRlciB3aXRob3V0IHJlZHVjaW5nIGNs
YXJpdHkuDQoNCkNoYW5naW5nIG5vdyAoaS5lLiBiZWZvcmUgSSBjb21taXQpIGlzIGVhc3kuwqAg
T25jZSBjb21taXR0ZWQsIGNoYW5naW5nDQppcyBmYXIgaGFyZGVyLg0KDQp+QW5kcmV3DQo=


From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:11:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:11:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271857.466565 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb88-0005OI-HH; Mon, 14 Feb 2022 13:11:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271857.466565; Mon, 14 Feb 2022 13:11:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb88-0005OB-EI; Mon, 14 Feb 2022 13:11:00 +0000
Received: by outflank-mailman (input) for mailman id 271857;
 Mon, 14 Feb 2022 13:10:59 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KkXt=S5=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nJb86-00054q-Rh
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:10:58 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8c78580b-8d97-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 14:10:58 +0100 (CET)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2052.outbound.protection.outlook.com [104.47.13.52]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-12--a9CkPfXOnC_2A83FqRHNA-1; Mon, 14 Feb 2022 14:10:56 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM6PR04MB5302.eurprd04.prod.outlook.com (2603:10a6:20b:7::20) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Mon, 14 Feb
 2022 13:10:54 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4975.015; Mon, 14 Feb 2022
 13:10:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8c78580b-8d97-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644844257;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=jBhE8pdS0z6X5OGHjjYTQ2s9u5suaBp+9zliY5yvTy8=;
	b=I1emouU+Rq9SIolNCX0qPN/eOMledQ8i5s85iYebvmSmTjFEk/ouz/DHrS6oa3PaykrbHD
	HuNaoOYMesWBoLD0QP5poMfT0YCm4vA0IqC4gpqoMRM6Etx0EDWHYxWqxyxxH3E+GljMoO
	n01B314/nX5uSXDKxZHiZQoymagqkds=
X-MC-Unique: -a9CkPfXOnC_2A83FqRHNA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=hBRdkQOrxhH1JhAs1g1LZ0k0AkAbMWWODznuk03LVg2rFqkFfG7LqsRxIXyKwvdcgDl3A9INaq6BPvLZn+ZJh3HEALlCZtr6Y6v6Sg8+p3TC5veCnBKbBh3zMQQxRDdIk7VwSTQlW8vVyg404pr8CEf26+NJYvj+744xBjGN9rQ2TX8C9cg3RUfnGoJMAo4zIjqk1NBR4Ezg4UkDWSO704T0O8DsErwKtS68jCAqLk7hg6nbgbiPselj+Kry0RRw5CO+8cCkjQlZRsaUCRAeTtq7D7PoKfY61VuEzlW0qTkgVP+TlFFDPsZw//+7iDyGOd0bBp6Mvxfh6T/MVVtBeA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=jBhE8pdS0z6X5OGHjjYTQ2s9u5suaBp+9zliY5yvTy8=;
 b=Ubpky9QnI+z2AhfEoIYdKvx8cLx+pp23gsAvQ5cnZdjHaBMnZ31OBUkiWyivixkpn+DCef/GfPlPt7hAy8VrQQn9nXGlSO921hYTA5TH8qQIMpPGv1Jw8RkIOADfoCwkXbwOuzTs0Axpw/SeG4azFWkCyFpijh7pIxg0ttGxISdc8GUfbYevT0HgKyVW7yvW5jcuYSoaSLlZLgPcJZTQwZu6rNmjMZUu1AY0C0X48fE4RDVrOYIV9BgaRunKX0cpqeWR5lq27n+5qjpIHTQLb/ykuwtEE96BHVH1v/9bz82AT4lU4H4JaBMJs2POVoeOcjQKEaunHpEEM0irtCcUTw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <785653bd-db3a-df22-f2a0-c20b3f3bf8c1@suse.com>
Date: Mon, 14 Feb 2022 14:10:51 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH v2 5/7] x86/hvm: Use __initdata_cf_clobber for hvm_funcs
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20220214125632.24563-1-andrew.cooper3@citrix.com>
 <20220214125632.24563-6-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220214125632.24563-6-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P192CA0067.EURP192.PROD.OUTLOOK.COM
 (2603:10a6:209:82::44) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 8487f105-852f-4224-cf15-08d9efbb6e3c
X-MS-TrafficTypeDiagnostic: AM6PR04MB5302:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB53020F3E8F722C114ED731FFB3339@AM6PR04MB5302.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	l7PVAPRuPeXEu6S47QFt1Ep0CoYIABTWWkSig5wOoy+jfZXkiU4UMVtzPJp51cGWJ+kTfvZAH/Z+CPhfQGDk3CvJc7P6o/DCgVE1UiMpifMQufGlD6txEKPyMhQb+LSjSTR09xMqHBg8JjWlGdjJCcHKdECEkdZlt0WmrCw3GKBVlah3kMZA5w5uR+JMHVfCfqjUqatTXXUKFXgcku0eB5gd+fUzpm0dlmfdXK00rM/62XQOk9DmQJ4GLzI9cJqEp8kvwty7DddDmIc9Sp5S6WlmxtNLRCwTcrlPU0A3TRCZ4TxBNv5cjNsjsO9yplwYjABT//o7ZBvAXxdTGqExSnrTBfnYXF99RVg4e8dQaccc6ZaHJnJ3vLr/FT81hhZeV8PKNzvx0lSUm7vS/xus9dyKiu7ousCUh+7lYtLRxIrpLg3ZecmoVObRyQM9kjPzeSt0ViQ9tJzBIRhMsBORrjCqJiH+8E4MWkJTcFjeFdECNAhCO/+5UDY4i7hL5n4dERTa1khdulP9ZrlcrwA3hHTPVmrX3BhTrc/hU2ulxZjt63p3hz33lEA5+blPPHMIBbF7No4kG7hb0rw7stgtkAQWqXNwfX19k4LvPAJXyp0bDQfQjBJFuTmtPDdAmmKCN8NMJy8BF+e6wWYKXxV2EjHGg1j6y4wkdwbP4W7EUatDZuOVpq0/OSo70GX59RrllTmXrSMA0x4154tD9qjC3QNAKXpON/MUA27sNW2SePybR73NVrZD/FwGeaDDoMmE
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(86362001)(31696002)(38100700002)(54906003)(6916009)(316002)(5660300002)(8936002)(8676002)(6486002)(66946007)(2906002)(66556008)(66476007)(4326008)(2616005)(26005)(6512007)(36756003)(186003)(53546011)(6506007)(31686004)(508600001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZCtiMjdNNnV0MlNURS84YlJaQ2tQWW9EVXBhYnhZRyt6R1BXWnU4eVpRUzdC?=
 =?utf-8?B?Y01LTlR2VlB5dXhtUUluV3N6THJsTHBTNUNzSStuNlltaE9LaVJrVWZoS1hk?=
 =?utf-8?B?cC9qZ1hGR1FXZStwU2tuaVFlS1Y0TGx3SHdSVTRPd0Q1S2N5N0lPckJDNkhh?=
 =?utf-8?B?d2RXbUVBZzREZW5DZWUyS1U1QjNUMXJnYUdvakJhVU5lTDlHZ0YrMWRBWGw2?=
 =?utf-8?B?RWhGYklXcUZvR1V2V3lpZWZ1VlhGZ1ZsV3llcVZqNGVTSUN1RGoyUTZvTHZr?=
 =?utf-8?B?M1Yza2syWm9yVVBVRnFIalpHVXRwUHJOVy9YN1VZL003QlovSUV6WGN1M2xF?=
 =?utf-8?B?a0ZyNnF1cVJ2SmJHQVlwT3VLM0VxMm8rcWVqWG82ejdnQXFkckhQdTZPUGha?=
 =?utf-8?B?SGozZnlIbitKY3drSGZ2YUIwanFFc2UxT3RXVjZHY3JSUTVnR0U0MjBtdGt0?=
 =?utf-8?B?WU9iUzFaYThoS3R6NzJNNUo1QnUyNnMrdWZGWGVUbVFlRUxGeFZRSHRzM3Bh?=
 =?utf-8?B?SWxWOFBDaW1uUS8wTGdTYW5iYldQZ28zQ0p0MWtFaFhuOEJxVVRCUzMzUHpQ?=
 =?utf-8?B?YnBhdGJtdkE0djFlV05EUVl1b0pjbnlLWWNicTJhb1Zudy9JOFV6UHZFd28x?=
 =?utf-8?B?R2VTZ2xEdHFDYjQ3dW5iR2NlU21Yd1RrcGVkdkhTRy9SNEsyUzQwU3pzR2Zl?=
 =?utf-8?B?aklqNTIwTDRYYXliVW9Bc0xzaUp1Y0pLNUJHTlZrRm9oemhMUkxDOUxFSUx1?=
 =?utf-8?B?L240OTAxTzBIMEFScTlWWVdiaU1DWTEwNmR2ZmZ6Yk12OEw0ckUrTUtDNmFB?=
 =?utf-8?B?YURvODQyc0xKTVM4MDBnSWxSL25ZQi9WdEw4SzRuMk5JZVVnYnZiNDdHcmll?=
 =?utf-8?B?SThzV3JNSUZSN3BLSzNZaFh5UFdWRGlucFBBWlZTWTJqd255c2VJM0lmS1RR?=
 =?utf-8?B?OUY0bURvaXFBR21YOG1EVWVsZ1I0eUJhM3ZOaTFYY01sKzVHZEQ2MnhGVEgx?=
 =?utf-8?B?bUhlL0ZyR0k0WjFad1dReGZNdjVrTkpCREkyWE0xZ3JSdEZoaWg3Z1RUMTBV?=
 =?utf-8?B?djFZOWRMbmdZMWU3S09YOVVBMGtSWEEvdVBUSkJUcUp1RkdZL3lVSXRubkl3?=
 =?utf-8?B?R0lYaFROdlBia2M0L1hiTjQzYTMvMno0K3YvancrNHQ1SDQ5aHMyd0tVN1RG?=
 =?utf-8?B?ZFZoYzNYNmR5YUNMZmFGR2J5anJOL2dhaEhiWVZ3TGJCTnhXRHB5RHc5aXZj?=
 =?utf-8?B?WElDcGhERXRFNDVxNS93N2lEMG9STGs0WGc5MklSaG14eWhSVzZuVHFFMUJF?=
 =?utf-8?B?bG5QNFY5OFdMSDBWeEdFeTBLRnd1TEVFZldVWDFQRjV3MFg4MFF1ZVpER2dj?=
 =?utf-8?B?aVZBV2hYSFNybXFRZ2xFcHBtTVFKQysrNS9YU0VrUWJWWkZFWVFKbjB5QkJV?=
 =?utf-8?B?UUVrTUNJdHF5OE42aXRRK0lVanZweWpjdUdkbEdnR3cxdjFNT3JHYm5pRGd5?=
 =?utf-8?B?ejYrQW5IOFNvc1lvdTI3TTVycnpqczhrSElLNis4YUlRd3dQOCtOR2Q4UjQw?=
 =?utf-8?B?UFV5YjdOQXNnOUx3MStqWWVGbmlORHRQOVRBZlp6TDJWRDdTbitteFpHSmw1?=
 =?utf-8?B?U1hCSU9MMnBES05MSlo4VStCR2xpQTJEWm9CbndMUllFVk1TRWVUTnM4OTBw?=
 =?utf-8?B?R3JKQ0g5WkNtNFhXQmlMNitabExkcGNITjFVcmdrbVdrMXBGVmJjY3N3VWxx?=
 =?utf-8?B?ZTQ1c21HTzJ2MWMxTnl0UlZsQWlFZ2lIMXBnN1VDbzVjb2V0alF0a1lSS1RY?=
 =?utf-8?B?YmpZakhic1MxREhRaE84Q3VNK2Jpa2Uxb1FFWUszTzFMUUR3RWduWnIrd3R0?=
 =?utf-8?B?Nk9lc0pOemVDcUQwZWp2TG5uMVI1aDlXWFNrdGY4QXRndHdqQ1FETm80cGJq?=
 =?utf-8?B?SXNOOFg4WThtMFNzWkVqU2Vqa3QwaXl1NkYxUHRIUWUzTnBjb3krOGlyeStn?=
 =?utf-8?B?Mm9SZTNlQ1lWL0ZkeVc4WXNLMkMwL2xwakN5S1BCVmUzdGthUm9qTkxoY2xz?=
 =?utf-8?B?eWlHem9zUUozeUUxbTlLRnVxWE9nSzU2N3ZzeFBBeWVMaVMwY0NMY2hrR2Jt?=
 =?utf-8?B?UmlSK3MxcE1tT0pFWnpFR0ZDeExCUTJTaWJseVh5cmYvdWxUVm45c1NSZGRo?=
 =?utf-8?Q?Ns/cPjc1/fUnAeY1zDAYRWs=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8487f105-852f-4224-cf15-08d9efbb6e3c
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2022 13:10:53.8287
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jx4YrH+XfCfvPIjgx7LUv4BL5cQd9JQDiwccInkLoq8AgqR2CMH20gFtQTaXdW8ROWZCZXwpialyPUShBuk6bw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5302

On 14.02.2022 13:56, Andrew Cooper wrote:
> --- a/xen/arch/x86/hvm/hvm.c
> +++ b/xen/arch/x86/hvm/hvm.c
> @@ -88,7 +88,7 @@ unsigned int opt_hvm_debug_level __read_mostly;
>  integer_param("hvm_debug", opt_hvm_debug_level);
>  #endif
>  
> -struct hvm_function_table hvm_funcs __read_mostly;
> +struct hvm_function_table __ro_after_init hvm_funcs;

Strictly speaking this is an unrelated change. I'm fine with it living here,
but half a sentence would be nice in the description.

> --- a/xen/arch/x86/hvm/svm/svm.c
> +++ b/xen/arch/x86/hvm/svm/svm.c
> @@ -2513,7 +2513,7 @@ static void cf_check svm_set_reg(struct vcpu *v, unsigned int reg, uint64_t val)
>      }
>  }
>  
> -static struct hvm_function_table __initdata svm_function_table = {
> +static struct hvm_function_table __initdata_cf_clobber svm_function_table = {
>      .name                 = "SVM",
>      .cpu_up_prepare       = svm_cpu_up_prepare,
>      .cpu_dead             = svm_cpu_dead,
> diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c
> index 41db538a9e3d..758df3321884 100644
> --- a/xen/arch/x86/hvm/vmx/vmx.c
> +++ b/xen/arch/x86/hvm/vmx/vmx.c
> @@ -2473,7 +2473,7 @@ static void cf_check vmx_set_reg(struct vcpu *v, unsigned int reg, uint64_t val)
>      vmx_vmcs_exit(v);
>  }
>  
> -static struct hvm_function_table __initdata vmx_function_table = {
> +static struct hvm_function_table __initdata_cf_clobber vmx_function_table = {
>      .name                 = "VMX",
>      .cpu_up_prepare       = vmx_cpu_up_prepare,
>      .cpu_dead             = vmx_cpu_dead,

While I'd like to re-raise my concern regarding the non-pointer fields
in these structure instances (just consider a sequence of enough bool
bitfields, which effectively can express any value, including ones
which would appear like pointers into .text), since for now all is okay
afaict:
Reviewed-by: Jan Beulich <jbeulich@suse.com>

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:11:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:11:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271868.466576 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb8i-0006DG-QM; Mon, 14 Feb 2022 13:11:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271868.466576; Mon, 14 Feb 2022 13:11:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJb8i-0006D9-NF; Mon, 14 Feb 2022 13:11:36 +0000
Received: by outflank-mailman (input) for mailman id 271868;
 Mon, 14 Feb 2022 13:11:35 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5JaK=S5=citrix.com=Jane.Malalane@srs-se1.protection.inumbo.net>)
 id 1nJb8h-00054q-1x
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:11:35 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a1178fde-8d97-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 14:11:33 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a1178fde-8d97-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644844293;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=SYyEwrO5qN+yK+owPemfrBsDCca4abNLA3jdr2ADwsA=;
  b=XvZWUY/eJC9S/G2HDYRLT3xrIxwV9P6QcjqR3QFgQIyYCd7O5O4HLHTl
   uwf9/JQMtaRXVKfRPkiiOHVq7bgZXYFmz6nuM3IWlCQAOiOsuOhIeRoiO
   WWXbrskK2axmafXmFwc7Jw1x7vnYF+GmPImCHFJGi7JwaaNk02eqikQsL
   I=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: FxfMpApnkoabecJnNbYOLIDXnoawYdNv4S7H5YpZmWLGTYZDNCUr3d9S2NSdEue7wI4EAmUjB9
 vW4LjjyMVnkfXZUKc5SzY/BzRRkd7jqmKyqm9DEEW9VbBZPyDQfx5eTFxL7WOKOTGTqlU2NvWP
 1clgq6P92xJv1XDI29GPgtnzUV1ByMlHk6JeAu9ic3dEQF+zp5IfH2W9utZdOno/maBAH8XOVP
 fesjFCNbCJnoiqUHAABTnTNJPl20sb6CvnmNbA1Bkb3NRtlOj2wF28qqoCQ/RbDpyayzE5Xud7
 YTtSdPPyydZGbHQ3V0aGlnRs
X-SBRS: 5.1
X-MesageID: 63593121
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:6S7L9KCXkDqa2BVW/0Hlw5YqxClBgxIJ4kV8jS/XYbTApG5xg2APm
 mIYWziFb/2MMWakf4h1YYS39B4EuMLQyYBjQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMo/u1Si6FatANl1ElvU2zbue6WL6s1hxZH1c+En970E47wobVv6Yz6TSHK1LV0
 T/Ni5W31G+Ng1aY5UpNtspvADs21BjDkGtwUm4WPJinj3eH/5UhN7oNJLnZEpfNatI88thW5
 Qr05OrREmvxp3/BAz4++1rxWhVirrX6ZWBihpfKMkQLb9crSiEai84G2PQghUh/pA7Qjugyj
 +12jd+WUAU4fanzid8RTEwNe81+FfUuFL7vJHG+tYqYzlHccmuqyPJrZK00FdRGoKAtWzgIr
 KFGbmBWBvyAr7veLLaTaOBqi4IGJc3iOIoZt1lrzC3DDOZgSpfGK0nPzYEDgWZr35oXdRrYT
 8E1dAUscxnqWgdGImdICbQRl8CIoXaqJlW0r3rK/PFqsgA/1jdZ7r/pN9bEf82Qcu9clE2Yu
 2Hu8nzwB1cRM9n34SGe7numi+vLnCX6cIEfDru18rhtmlL77mYeEgEMXF235/ywkFejWsl3I
 lYRvCEpqMAa90G1T9+7QxyxplaFuAIRX5xbFOhSwAOQzOzS6gWQBGkBRxZAbsArsIk9QjlC/
 k+EmZblCCJitJWRSGmB7fGEoDWqIy8XIGQeIygeQmMt4dPuvYUyhRLnVct4Hei+ididMS706
 yCHqm45nbp7pcwW06S2+3jXjjTqoYLGJiY36R/QRXmN9R5iaciuYInA1LTAxa8edsDDFADH5
 SVa3ZjFhAwTMX2TvAO2GfQ1X/aR3M7GFiTekB1rIIga+yv4rhZPYrtsyD15IU5oNOMNdjnof
 FLftGtt2XNDAJe5RfQpOtzsUqzG2YClTI24Da6MMrKid7AsLFfvwc14WaKHM4kBemAImLp3B
 5qUeN3E4Z0yWfU+l2reqwvwPNYWKsECKYH7GMqTI/ePi+P2iJuppVAtagXmUwzBxPnYyDg5C
 v4GXydw9z1RUfflfg7c+pMJIFYBIBATXM6q95MHJrPeelM9QgnN7sM9Jpt7JeRYc1l9zL+Ur
 hlRpGcEoLYAuZE3AVrTMS0yAF8edZ1+sWg6LUQR0aWAgBAejXKUxP5HLfMfJOB/nMQ6lKIcZ
 6RVKq2oX6UUIhyaqmt1UHUIhNE7HPhdrVnVZHTNjflWV8MIejElDfe6IlqxpHFWVHLfWAlXi
 +TI6z43iKErHmxKJM3XdOiu3xW2u30ck/h1REzGPp9Yf0CEzWSgA3WZYiYfL55eJBPd6CGd0
 grKUx4UqfOU+90+8cXThLDCpICsSrMsEk1fFmjdzLC3KSiFoTbznd4eCL6FLWLHSWf52KS+f
 uEJnfvyB+IKwQRRuI1mHrc1ka9nv4nzp6VXxxhPFWnQawj5EatpJ3SLhJEdtqBEyrJDlxGxX
 0aDpotTNbmTYZu3G18NPgs1KO+E0KhMyDXV6P00JmT85TN2o+XbARkDYUHUhXUEfrVvMY4jz
 eMwg+Is6lSy2kgwL9KLriFI7GDQfHYOZLoq68MBC4jxhwt1llwbOc7ACjX76Y2kYslXNhV4O
 SedgafPiugOxkfGdHZvR3HB0fAE2MYLsRFOilQDO06IipzOgfpuhE9d9jE+TwJ0yBRb0r0sZ
 jg3ZhMtfajerS11gMVjXny3H1ATDRKUzUX91l8VmTCLVEKvTGHMcDUwNOvlEJr1KI6Akuy3J
 I2l9Vs=
IronPort-HdrOrdr: A9a23:dvBnTqkvl5DehPoCUwRrJt05lyPpDfIu3DAbv31ZSRFFG/Fxl6
 iV8sjztCWE8Qr5N0tBpTntAsW9qDbnhPtICOoqTNGftWvdyQiVxehZhOOIqVDd8m/Fh4pgPM
 9bAs9D4bbLbGSS4/yU3ODBKadD/OW6
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="63593121"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=BpgTcbmaiQxoWqCJ1rvCOLm2azAe6v4Jt9Cr7iIhZFNZ2Ixlkdsn8TKHqlb8gah6akUFPGXoGN2jFSNLIV6PS0qcc2qofBQ5smGSRUE9vJa/y2FatphArviHiyEDOa8EAPycY0eFTZ2GgLLSutBfZVOimsBZZ1ktGzYeZPbFMARz7McyuLwRgUTkxlPEexcoMHG3SkV+Bg+jCEDkmQ7o37Qm2GUfUfea6DIQ7OGCjn/N6q4JFe3BLnNt49EKTIqoEkMKjFtR7M+Al58+rEyCexyooMNkFVd1v/EShAx5d/7kwZjV+gsSV5XH5cs0WFftMfZPesCy+TNDBmdH53eHwQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=SYyEwrO5qN+yK+owPemfrBsDCca4abNLA3jdr2ADwsA=;
 b=CePfLdKc0z1X+MBq8if34DpEDOcp/DnF84ZkIKlmDOb9n+g5+K36wo7ebJKgU4MMVP5hXV2FK64Ld+Dr9v2L28I/M3PmUuSeYsWxR+Nl7Nu6B2DogLidg2L4MFQN9zIMwP+KfXancPVT+G5OwcWxdLdV2LP9KXtIBrwnf1mvW9zpHwtPaK5ZPvRhfPDn744iiUn/MdtdxKdoqKt+OFXmtRn38Aw02Lq0RhlNw4pCyIDc/wcfkmZtYcdOwcTAnTd7r5cfxCz5XsVjHb8TRLYaa/vwOCW0YXbYxTi20cactRHsC/9MrgjOjl61rXLiI1CIE+aX2lwic7YfH1z+RVzfLQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=SYyEwrO5qN+yK+owPemfrBsDCca4abNLA3jdr2ADwsA=;
 b=TCxam9rpYVpR1wu9kHcys3m81vO4ovqIUFq20BeKnAHRTZ14ithVrPt5+v3pBgnl3O/vSmJfp+4j7jAIXCoATIdwW8zuuqgkg/t6VnQ6NDxaoOXy5dG546gDYG69GLKEt1kjaZ0jvsaYFlTEhr7wp0kdLNm1u6qm/W2vGJGSqp0=
From: Jane Malalane <Jane.Malalane@citrix.com>
To: Jan Beulich <jbeulich@suse.com>, Roger Pau Monne <roger.pau@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>, "Anthony
 Perard" <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, "George
 Dunlap" <George.Dunlap@citrix.com>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>,
	Jun Nakajima <jun.nakajima@intel.com>, Kevin Tian <kevin.tian@intel.com>,
	Andrew Cooper <Andrew.Cooper3@citrix.com>
Subject: Re: [PATCH v2 1/2] xen+tools: Report Interrupt Controller
 Virtualization capabilities on x86
Thread-Topic: [PATCH v2 1/2] xen+tools: Report Interrupt Controller
 Virtualization capabilities on x86
Thread-Index: AQHYHE+TdJl64aH33EedeR0PZ4zblKyMkj6AgAGTLwCAABdDgIAABJKAgATOw4A=
Date: Mon, 14 Feb 2022 13:11:28 +0000
Message-ID: <6c9400b8-7c76-34c8-f69e-3fad1eb53b8c@citrix.com>
References: <20220207182101.31941-1-jane.malalane@citrix.com>
 <20220207182101.31941-2-jane.malalane@citrix.com>
 <YgTi6bzeojtcu0xL@Air-de-Roger>
 <dff9c5c0-7bee-ce0d-3288-91255a701c99@citrix.com>
 <YgZIo9VQktcqGHTD@Air-de-Roger>
 <6d924061-f2fd-5f3d-0f98-79e76398b908@suse.com>
In-Reply-To: <6d924061-f2fd-5f3d-0f98-79e76398b908@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: d1c0eeed-001c-4ffa-2905-08d9efbb8312
x-ms-traffictypediagnostic: SN6PR03MB3951:EE_
x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
x-microsoft-antispam-prvs: <SN6PR03MB39511A769066D39AEC3262CF81339@SN6PR03MB3951.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: VyFFk7PDcVWZ8olwkePC68DrMTsqzzWWB7gUouumKsfL+4PtJ94P8ojDgHFjoXZDn0K8zV1cvtxeFpk5Bpn4toY6gjmvkJdL0/sa6sIGpcDVGOLOJKDVPeB0SBW94pkQoXG3eUSNrA+je30IZc56/e/CmH9dEOszrVEoWBdPQ3thc8LYNPmlj9Fo1zLCh6Dm+3hIYWrGpetW+ZR+flfA+pM2eUKJjp4LSviBS+dMBXlKvwEYj/g069D1C8JKpn176aWKCfbK5+cGl0u3UsgmkZ+nZU6EAjQ/zr1L9QTKt885Fxan/ZMry0rY/RoT4p/Ol0NhZ87UCpduEhQAD9UYyDhRulQk25VIyKNx2lHyTzhcQtwCz4obkLN8SvzGlevT12il/roJzjxEsQYsJTe8r3rJFXlJnl3DEUNtYuMAWVdVgnUnccDCfpGdsJgKFRfIG0diw2YhmwzrmqXNghyGaSMEfsCgVn7tGZnu3zoBBizrFCF2zNPgB6frEeVKrFiDOMghRbBLy2XOjsvsYRuCMO9sNxnnWboIygcspRURhIirlXrY+gQ/gPcL5HQ3+0p7pBDtpzrXAgaMa5RVj2onkwhAgqtByu025vIhOfE0tji1ZOY/5NvRYw/aXxA3rSNNpFSnE1srj8Q6xQPb96mWJMsU0CDecZq0kpgQUbgjle2mOnnyfx4IDAXV4pw/LRzTycvYJWRftixfI50Uurcif9CkjIGWmfUA68Ue1fwqxq7/F8vlQlT98GtGKSonlewM
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR03MB3386.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(26005)(2616005)(6486002)(186003)(53546011)(31696002)(6506007)(86362001)(107886003)(508600001)(82960400001)(71200400001)(83380400001)(6512007)(8676002)(66556008)(38100700002)(122000001)(36756003)(54906003)(76116006)(64756008)(6636002)(316002)(91956017)(7416002)(2906002)(66946007)(31686004)(110136005)(66476007)(4326008)(8936002)(38070700005)(66446008)(5660300002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?azZCNjBtZ1hGcURJUVhLV2hmdTBRSUZMRmFCRDJ4em5VeUxMWmNjZUJWMytG?=
 =?utf-8?B?eGhJYVNBVWo2ZUZUYmNKWktjQkJCeEo3dCtzZ3F0YXNIQUVlYzQzTlVEMk5j?=
 =?utf-8?B?T1V3M0g4Sk9qL2htMGxwQXgrTlk2ZU9lR2ZTUkdNdW5xbk51Zjd6dmlkQ0pU?=
 =?utf-8?B?YTJHbHh3TEowMjVsbURRb2tyRG96S1VheTdqakZXMlMwRnZmaDRMK2VKRDEz?=
 =?utf-8?B?WHBnNk1COHBTOWhTbEF5dnR2K0xRUVNiL2xRNmF0dHpmOXl4ZGFJb0JLeVhz?=
 =?utf-8?B?OWNOc0dLVks1RkxMSHAyVkY2N2c5RVUvZTRSZmJDdW43L3JRVnFrYzRmWW9R?=
 =?utf-8?B?WitPd0RrU3Y0MU9ZWHRmTGJVamFqKy94ckRXY1RPZEYwQU5jNXFwTWNXL2I0?=
 =?utf-8?B?MDZoVE92WkxHNHdub1ZNWVJkeDNzUXFGak5GYTN6N3BzcElXTzZVbjkyOHh2?=
 =?utf-8?B?OUlUV1JVREtZcTEwNG5JRHJSMlplemgyWGQvOGFQSTV5QzZ3UU9nQU55Z2ZG?=
 =?utf-8?B?aGQ2Vkhud05xMWk3bmJUM1lsN1ErcHYyZFJXOUhrYzZqUmVJMks2M2ExM1g3?=
 =?utf-8?B?UFNRVy9jRlVKaFNKYnE0aENqR3hoMHZDUE5qcEJNaWNTSDhPVW40NUlOVUEy?=
 =?utf-8?B?NGwwc0VueFM4MUZPSklDWjVNZjlNbVJDQTdVS21FcExLQjV5Y1gyczNJcWpH?=
 =?utf-8?B?NDYrYU9PdUZhU3JqaG1ieGRUTFFFcFdzQzE2M1lOY2l6NVN5N2xQNlp3bzJQ?=
 =?utf-8?B?eGlSc3JNWWZXYmZPYU1WbnNOVUVxc0lGbS9XQnBheGwrUVJvckF0QUlIWlls?=
 =?utf-8?B?YmdQMnRFdldJR2VycVpLMHg2UXVIc3F6UDU4WnlwZ2RsN0dCRmJJWU1mK0Jl?=
 =?utf-8?B?WmlYRmxJSEQxRnY2UTZ5N08xN1laSXQxZEZPOStkZllvZk9DcFJKRDBRbnpo?=
 =?utf-8?B?bGJleWMxR21ZWi91c1ZaWGFBdVNWbXY4RmJoamR2NGt1aDJnSVBHZG1Td2NJ?=
 =?utf-8?B?U0syUG5uYUZmSm1kU0lLWkpPVTRGaFdBMlN3YytVYmc1aXhSa0VrR0VVWkts?=
 =?utf-8?B?di81K3QrNjFleHJ0bk8yUmRUbGJvS24wRGRwQm9SSDdHTFhaUTFRbEVBTGF3?=
 =?utf-8?B?dDkwb3lDOE1oSFhMUlNZdFVqRTJ0UGtxaDdkejNMclVmbExOak5LN1MvTE1u?=
 =?utf-8?B?K1R0WHpBdkVCTnlBZTVxRnc5dzlYSVVXNnlyUHRYUHdWU1VBelBBMkwwU25L?=
 =?utf-8?B?SzFGbU1FNU5qVDY3OW1pb2l0NUZCRGdZU3poN1BYZkx2WFk5eWhJQlZyRzBN?=
 =?utf-8?B?MWREMUhWbjIvTnpGWkFFSHI4UUlpMTZlRzNra3JDTEhWbTlRRHF1aEFjVjJi?=
 =?utf-8?B?NlhZK25xWm1nQVN1YXFjTXZxeDdzNldqMTlGWkJmTi9ROFl1VVpZMElmb3FU?=
 =?utf-8?B?Wm9CaU83ZFJmbVdCRE0zcWxPZkJPeUhlR1FyL3lxekE3TGJFaUNKd0FzUjRl?=
 =?utf-8?B?Z1didDF6Rm90ckc0bThLK2YraU9Cam9pakVnSkRTRzBzMFlweVRtN0NnR2lK?=
 =?utf-8?B?Uzg3L3RrNmkwWnZIMys2MjJNRWdDTnd1Vkt0WC9OOGVvQUJTU3crWTNrc0hI?=
 =?utf-8?B?akd1bDhremxNbzl2M25pdjJyNFNvY1B0ejR4bmdZeDArQmx4K2JIQlMrYmJW?=
 =?utf-8?B?TXVTSHFyT0JsV3FQV2s4L3BZMG1helJ3S0tLUjVoQ3RKQlc5WkJTUW1Xa1dT?=
 =?utf-8?B?akVJRk9ZNUJSd0JPTUFMWERLQW82dXZManljV1U1YXh2Mk16YmJqc24yZnpn?=
 =?utf-8?B?TUMvcVJnV0FyYlh6aXZPRGdSMDhoNjl0ck1vWmhPRGN6bEMwYXhyRHN2cTdx?=
 =?utf-8?B?enZ0cFYyclF1RW93b1lRdVoyckh2dFMxOW8zNWxpSzZVeFpKNC93QVVBTFpn?=
 =?utf-8?B?a3U4KzV1cGVWc2JJK2hxbjN0dTZIOGZqaUNtRm9pTTR6NzdoR3FNQldGRUdZ?=
 =?utf-8?B?R0U4YW1kM1R3eFNLOVMyUjJBOU1rcTZmU3E3cHZMTGQra3dOMTdseVpnN2xa?=
 =?utf-8?B?WEMxZXhnbGdTdDVvVG5iSG5pL09EWnRWc3JvYWVSaWNIWnhYV2V4d0tadENa?=
 =?utf-8?B?M1FBdmx6a2UzQmtISTdYTnh0c0t2eExqWGZwMGFwTE8rNFlydlVJbEdDckV2?=
 =?utf-8?B?dk9PVkVxVGhpckdUYlM2anB5TU83WERtaGpTVW1yL3g3aHRqUXhRZFBoQ2t2?=
 =?utf-8?Q?i8QoVm7e2x5dcIddIUW6rD6+hXMPD4X30g321JBJzo=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <1DC4424001B43747BAE928CEBE694BB4@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM5PR03MB3386.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d1c0eeed-001c-4ffa-2905-08d9efbb8312
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Feb 2022 13:11:28.6095
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: BBFMx+Wlo6eQDKlA0O2mpy8QaoRLf3I6vdQQXLTMkx1PQ39YixA7zQe/Oj6GM0rakFTKAB+GsQzeJvgcV0m6TMEEo76hYGNdQc86mldLgAk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR03MB3951
X-OriginatorOrg: citrix.com

T24gMTEvMDIvMjAyMiAxMTo0NiwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IFtDQVVUSU9OIC0gRVhU
RVJOQUwgRU1BSUxdIERPIE5PVCByZXBseSwgY2xpY2sgbGlua3MsIG9yIG9wZW4gYXR0YWNobWVu
dHMgdW5sZXNzIHlvdSBoYXZlIHZlcmlmaWVkIHRoZSBzZW5kZXIgYW5kIGtub3cgdGhlIGNvbnRl
bnQgaXMgc2FmZS4NCj4gDQo+IE9uIDExLjAyLjIwMjIgMTI6MjksIFJvZ2VyIFBhdSBNb25uw6kg
d3JvdGU6DQo+PiBPbiBGcmksIEZlYiAxMSwgMjAyMiBhdCAxMDowNjo0OEFNICswMDAwLCBKYW5l
IE1hbGFsYW5lIHdyb3RlOg0KPj4+IE9uIDEwLzAyLzIwMjIgMTA6MDMsIFJvZ2VyIFBhdSBNb25u
w6kgd3JvdGU6DQo+Pj4+IE9uIE1vbiwgRmViIDA3LCAyMDIyIGF0IDA2OjIxOjAwUE0gKzAwMDAs
IEphbmUgTWFsYWxhbmUgd3JvdGU6DQo+Pj4+PiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gveDg2L2h2
bS92bXgvdm1jcy5jIGIveGVuL2FyY2gveDg2L2h2bS92bXgvdm1jcy5jDQo+Pj4+PiBpbmRleCA3
YWIxNWUwN2EwLi40MDYwYWVmMWJkIDEwMDY0NA0KPj4+Pj4gLS0tIGEveGVuL2FyY2gveDg2L2h2
bS92bXgvdm1jcy5jDQo+Pj4+PiArKysgYi94ZW4vYXJjaC94ODYvaHZtL3ZteC92bWNzLmMNCj4+
Pj4+IEBAIC0zNDMsNiArMzQzLDE1IEBAIHN0YXRpYyBpbnQgdm14X2luaXRfdm1jc19jb25maWco
Ym9vbCBic3ApDQo+Pj4+PiAgICAgICAgICAgICAgICBNU1JfSUEzMl9WTVhfUFJPQ0JBU0VEX0NU
TFMyLCAmbWlzbWF0Y2gpOw0KPj4+Pj4gICAgICAgIH0NCj4+Pj4+ICAgIA0KPj4+Pj4gKyAgICAv
KiBDaGVjayB3aGV0aGVyIGhhcmR3YXJlIHN1cHBvcnRzIGFjY2VsZXJhdGVkIHhhcGljIGFuZCB4
MmFwaWMuICovDQo+Pj4+PiArICAgIGlmICggYnNwICkNCj4+Pj4+ICsgICAgew0KPj4+Pj4gKyAg
ICAgICAgYXNzaXN0ZWRfeGFwaWNfYXZhaWxhYmxlID0gY3B1X2hhc192bXhfdmlydHVhbGl6ZV9h
cGljX2FjY2Vzc2VzOw0KPj4+Pj4gKyAgICAgICAgYXNzaXN0ZWRfeDJhcGljX2F2YWlsYWJsZSA9
IChjcHVfaGFzX3ZteF9hcGljX3JlZ192aXJ0IHx8DQo+Pj4+PiArICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgIGNwdV9oYXNfdm14X3ZpcnR1YWxfaW50cl9kZWxpdmVyeSkgJiYN
Cj4+Pj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjcHVfaGFzX3ZteF92
aXJ0dWFsaXplX3gyYXBpY19tb2RlOw0KPj4+Pg0KPj4+PiBJJ3ZlIGJlZW4gdGhpbmsgYWJvdXQg
dGhpcywgYW5kIGl0IHNlZW1zIGtpbmQgb2YgYXN5bW1ldHJpYyB0aGF0IGZvcg0KPj4+PiB4QVBJ
QyBtb2RlIHdlIHJlcG9ydCBodyBhc3Npc3RlZCBzdXBwb3J0IG9ubHkgd2l0aA0KPj4+PiB2aXJ0
dWFsaXplX2FwaWNfYWNjZXNzZXMgYXZhaWxhYmxlLCB3aGlsZSBmb3IgeDJBUElDIHdlIHJlcXVp
cmUNCj4+Pj4gdmlydHVhbGl6ZV94MmFwaWNfbW9kZSBwbHVzIGVpdGhlciBhcGljX3JlZ192aXJ0
IG9yDQo+Pj4+IHZpcnR1YWxfaW50cl9kZWxpdmVyeS4NCj4+Pj4NCj4+Pj4gSSB0aGluayB3ZSBs
aWtlbHkgbmVlZCB0byBiZSBtb3JlIGNvbnNpc3RlbnQgaGVyZSwgYW5kIHJlcG9ydCBodw0KPj4+
PiBhc3Npc3RlZCB4MkFQSUMgc3VwcG9ydCBhcyBsb25nIGFzIHZpcnR1YWxpemVfeDJhcGljX21v
ZGUgaXMNCj4+Pj4gYXZhaWxhYmxlLg0KPj4+Pg0KPj4+PiBUaGlzIHdpbGwgbGlrZWx5IGhhdmUg
c29tZSBlZmZlY3Qgb24gcGF0Y2ggMiBhbHNvLCBhcyB5b3Ugd2lsbCBoYXZlIHRvDQo+Pj4+IGFk
anVzdCB2bXhfdmxhcGljX21zcl9jaGFuZ2VkLg0KPj4+Pg0KPj4+PiBUaGFua3MsIFJvZ2VyLg0K
Pj4+DQo+Pj4gQW55IG90aGVyIHRob3VnaHRzIG9uIHRoaXM/IEFzIG9uIG9uZSBoYW5kIGl0IGlz
IGFzeW1tZXRyaWMgYnV0IGFsc28NCj4+PiB0aGVyZSBpc24ndCBtdWNoIGFzc2lzdGFuY2Ugd2l0
aCBvbmx5IHZpcnR1YWxpemVfeDJhcGljX21vZGUgc2V0IGFzLCBpbg0KPj4+IHRoaXMgY2FzZSwg
YSBWTSBleGl0IHdpbGwgYmUgYXZvaWRlZCBvbmx5IHdoZW4gdHJ5aW5nIHRvIGFjY2VzcyB0aGUg
VFBSDQo+Pj4gcmVnaXN0ZXIuDQo+Pg0KPj4gSSd2ZSBiZWVuIHRoaW5raW5nIGFib3V0IHRoaXMs
IGFuZCByZXBvcnRpbmcgaGFyZHdhcmUgYXNzaXN0ZWQNCj4+IHh7Mn1BUElDIHZpcnR1YWxpemF0
aW9uIHdpdGgganVzdA0KPj4gU0VDT05EQVJZX0VYRUNfVklSVFVBTElaRV9BUElDX0FDQ0VTU0VT
IG9yDQo+PiBTRUNPTkRBUllfRVhFQ19WSVJUVUFMSVpFX1gyQVBJQ19NT0RFIGRvZXNuJ3Qgc2Vl
bSB2ZXJ5IGhlbHBmdWwuIFdoaWxlDQo+PiB0aG9zZSBwcm92aWRlIHNvbWUgYXNzaXN0YW5jZSB0
byB0aGUgVk1NIGluIG9yZGVyIHRvIGhhbmRsZSBBUElDDQo+PiBhY2Nlc3NlcywgaXQgd2lsbCBz
dGlsbCByZXF1aXJlIGEgdHJhcCBpbnRvIHRoZSBoeXBlcnZpc29yIHRvIGhhbmRsZQ0KPj4gbW9z
dCBvZiB0aGUgYWNjZXNzZXMuDQo+Pg0KPj4gU28gbWF5YmUgd2Ugc2hvdWxkIG9ubHkgcmVwb3J0
IGhhcmR3YXJlIGFzc2lzdGVkIHN1cHBvcnQgd2hlbiB0aGUNCj4+IG1lbnRpb25lZCBmZWF0dXJl
cyBhcmUgcHJlc2VudCB0b2dldGhlciB3aXRoDQo+PiBTRUNPTkRBUllfRVhFQ19BUElDX1JFR0lT
VEVSX1ZJUlQ/DQo+IA0KPiBOb3Qgc3VyZSAtICJzb21lIGFzc2lzdGFuY2UiIHNlZW1zIHN0aWxs
IGEgbGl0dGxlIGJldHRlciB0aGFuIG5vbmUgYXQgYWxsLg0KPiBXaGljaCByb3V0ZSB0byBnbyBk
ZXBlbmRzIG9uIHdoYXQgZXhhY3RseSB3ZSBpbnRlbmQgdGhlIGJpdCB0byBiZSB1c2VkIGZvci4N
Cj4gDQo+IEphbg0KPiANClRydWUuIEkgaW50ZW5kZWQgdGhpcyBiaXQgdG8gYmUgc3BlY2lmaWNh
bGx5IGZvciBlbmFibGluZyANCmFzc2lzdGVkX3h7Mn1hcGljLiBTbywgd291bGQgaXQgYmUgaW5j
b25zaXN0ZW50IHRvIHJlcG9ydCBoYXJkd2FyZSANCmFzc2lzdGFuY2Ugd2l0aCBqdXN0IFZJUlRV
QUxJWkVfQVBJQ19BQ0NFU1NFUyBvciBWSVJUVUFMSVpFX1gyQVBJQ19NT0RFIA0KYnV0IHN0aWxs
IGNsYWltIHRoYXQgeHsyfWFwaWMgaXMgdmlydHVhbGl6ZWQgaWYgbm8gTVNSIGFjY2Vzc2VzIGFy
ZSANCmludGVyY2VwdGVkIHdpdGggWEVOX0hWTV9DUFVJRF9YMkFQSUNfVklSVCAoaW4gdHJhcHMu
Yykgc28gdGhhdCwgYXMgeW91IA0Kc2F5LCB0aGUgZ3Vlc3QgZ2V0cyBhdCBsZWFzdCAic29tZSBh
c3Npc3RhbmNlIiBpbnN0ZWFkIG9mIG5vbmUgYnV0IHdlIA0Kc3RpbGwgY2xhaW0geHsyfWFwaWMg
dmlydHVhbGl6YXRpb24gd2hlbiBpdCBpcyBhY3R1YWxseSBjb21wbGV0ZT8gTWF5YmUgDQpJIGNv
dWxkIGFsc28gYWRkIGEgY29tbWVudCBhbGx1ZGluZyB0byB0aGlzIGluIHRoZSB4bCBkb2N1bWVu
dGF0aW9uLg0KDQpUaGFua3MsDQoNCkphbmUu


From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:13:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:13:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271878.466588 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbAK-0006tU-5r; Mon, 14 Feb 2022 13:13:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271878.466588; Mon, 14 Feb 2022 13:13:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbAK-0006tN-2r; Mon, 14 Feb 2022 13:13:16 +0000
Received: by outflank-mailman (input) for mailman id 271878;
 Mon, 14 Feb 2022 13:13:14 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=YsDI=S5=epam.com=prvs=4044e07e7c=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nJbAI-0006t9-NG
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:13:14 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id dc259c2e-8d97-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 14:13:12 +0100 (CET)
Received: from pps.filterd (m0174682.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 21ECmtv7023768;
 Mon, 14 Feb 2022 13:13:08 GMT
Received: from eur05-db8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2106.outbound.protection.outlook.com [104.47.17.106])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3e7q5h05fd-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Mon, 14 Feb 2022 13:13:08 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by DB7PR03MB5052.eurprd03.prod.outlook.com (2603:10a6:10:7e::30) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Mon, 14 Feb
 2022 13:13:05 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::fc4d:4749:5d1:eb73]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::fc4d:4749:5d1:eb73%4]) with mapi id 15.20.4975.018; Mon, 14 Feb 2022
 13:13:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dc259c2e-8d97-11ec-b215-9bbe72dcb22c
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=O4Cu/3Ep5Qlf3DuUFdTQUv81hJXu3HtAIgyQvYkEKMMYQAjj8oRwrxkwZRSEN6Fv42dzQTr9+8PGCYczhD+AHf5VTEfKNx2ZxRXBwTNYFM96XwIi+aHqv96s8QgEHXhK8Yx88JTHzAtiHfcGbp4qbj261ZHfS7lcwoKJfwXOhxZR0Je7weVSY+fzy0eCRndc8cv2ABTHx1AcKiPrLWPjLG4fMVmp/ZXu54WVXYdxKd/E17DYgRWnwbcN+6s6GAC3G2w6Zq+xF0CtzY3C/KBrePkaeZ5h8cft81tQBb3CR56Sed+xU7HcvuESJt5i/U6Z1fNPPSesg8BwmxeiVdsArg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ZtpnDP6mG53v9dhdVWrFUPfYugizhk9vgUfzjOG5g7k=;
 b=ZT8YdJGIXIXHs3d/FwY/yQLlJlo+doIyEiMJ93IhGMQH8hPIKdMT0AGTO1awF3QQebvyup2elEzx7UeXkFK3UTTEx+n9EpxkNt5QKE8FhBv+Xrjw03NNW96MK7Bpp6hUxeJPuSXeDQkFoPdq31u+ryXwW0fVGVc0LvmbOMTs3RjNteIhZct4gM6RoHm0ILjYKEJij8izcKBSGsfxmxWizsEVOb5Ahr5SEeqNbDlET5uVJUBawk504hdUTyHv7Bs6XvJdHYXEVXdI8rQaQLK8WHS7BEASqqT3r/eXOizVGPMs0jYfxmNzyrqqs3HB/VFrT3jz/6Lg39B2AQfEeqGEeQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ZtpnDP6mG53v9dhdVWrFUPfYugizhk9vgUfzjOG5g7k=;
 b=f5G6iChOO7r8NmboWmKpejommPKu2S5DA4A0SQDh6HkoUHHsBuzQh411gIItBUZuZI+2RbTNv/VbwEZYKg3dkXoxm7PviOlnaLXDO6R1HX1hK+MY9yyNJoYXpCk3qeocrm6fOBDBgKu03iHMKRcL+IuzkCSDs9LtXjGqC987OWcRpKSk1EYL5003S9UuXMA9CRH+xdkFf/LJrLZ1K/dSC8YAdlv8/MJqjLKJsp8UvOXjtG6a+aa6dQ5cufKpYG9rnHdqqY+fLKqXfyUyhuMwloRG2Ydlj8gaJS+zoQoYTcgzBgEMEOtrh3t6JYG0Yrc+xy9rE5YFhm+AkjeDkV/Vlg==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?=
	<roger.pau@citrix.com>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH] vpci: introduce per-domain lock to protect vpci structure
Thread-Topic: [PATCH] vpci: introduce per-domain lock to protect vpci
 structure
Thread-Index: 
 AQHYHboQT3cBWYI1/EGunE7hOwop6ayM95MAgAD+qQCAAEaDAIAElIcAgAAQEwCAAAV1AIAABOQAgAABMICAAALZgIAAAzmAgAAWXYCAAARtAA==
Date: Mon, 14 Feb 2022 13:13:05 +0000
Message-ID: <6ccc7add-c13e-555f-b341-ce37118746e5@epam.com>
References: <20220209133627.959649-1-andr2000@gmail.com>
 <YgU6Snk8GTytJXZp@Air-de-Roger>
 <c4666570-666e-6680-5ec2-adf1da51ad06@epam.com>
 <YgZLEMW9US9QjjYG@Air-de-Roger>
 <33fb1095-64ed-29ef-ba6b-cbde21d941f8@epam.com>
 <YgowIg5MvTaf2zsR@Air-de-Roger>
 <d8389a90-00c8-b34a-8488-b0f3fc5bde1b@epam.com>
 <Ygo40L4dMPJjZKRF@Air-de-Roger>
 <746860aa-c403-1eca-0a75-587c5d10c8c2@epam.com>
 <Ygo8M3Y6BLzljn15@Air-de-Roger>
 <114b8578-ee13-b67d-e282-d060187ef509@epam.com>
 <06baf0c8-d7d2-50b8-ea8f-1d422ceac728@suse.com>
In-Reply-To: <06baf0c8-d7d2-50b8-ea8f-1d422ceac728@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 0910f785-3592-4d51-6ce1-08d9efbbbcb5
x-ms-traffictypediagnostic: DB7PR03MB5052:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <DB7PR03MB50526A1B08886EBCCD4E2F18E7339@DB7PR03MB5052.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 lp5BRE7vlqdeOiray85JPlleec8frU4vsvIRXmulxLOY23xblscQa2wo+/DlC8zNhGHXka0RBWG2nvWKRGKeW9U92l9C/QxcW+efdSeX/NNXgNWnecn2ntJ6HUmD4x9EjwYy76euwwpvf3J1rfaqrjOJ7/634wj9b0HebMhq2DHUP/P9egUyyi+4KZmqlXJ7npllvogxIrZn6K6TfwwCjLECRGMmJDXckigB4R4ROFwKZjK8+bMfx8iIdx+BMNi3GLnkj+yQY9jFxXDFD8spORNEUXqVslZYr/dQBFkpL8yrsysoDHB9LJUujmsecVK4uKgHOYEinzGh3yELSzcICNmygMZkaP0l5AZxmx7XKdBiCvvQLqAC6x0dMia7jTBVEYAqTCOmf0lTCohByCOCuvDr/5RcecWmYbOMO6KBGjm2JEHKVfoGPgpjszBvzW7HnGte2mB+NvwPReChMQI2BKcBuA68Wds3pG+db05tJH3VJUNFF3u0lDNRvDDxUDjs7INyUm4hkDfwzSA08bPl0jHXCF0a6FOg1FzSpUrgm3Ty4nAIkTxh4XkJcp1tfGrRZzWcuCpV63s47d2fcSn1laS6suyzjW9DMz67beYzFhiL9y7J2EFTdmj9nrcFkPauEUT1BK4T+maH4wp5SSKc/nbw2RbOfxOcOE1BLDxHsXTelkxMc0eaM2wu2ip/9kQ3L1aSGzsnzuRadWLGd193EKqtvFOYASHaGCRTIfjL6qN51l73AJbSZ/5u6SnfZ85o
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(54906003)(66946007)(66446008)(38100700002)(5660300002)(76116006)(64756008)(66476007)(66556008)(6506007)(71200400001)(86362001)(26005)(6916009)(8936002)(8676002)(53546011)(38070700005)(91956017)(6486002)(508600001)(31696002)(186003)(4326008)(316002)(122000001)(36756003)(83380400001)(2616005)(107886003)(31686004)(55236004)(6512007)(2906002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?MlAxaWpVb3VwOEdiVVE3ck9maXpLbDc4M1dwakkvbFc0TnJIaitKZVNkZWx5?=
 =?utf-8?B?T2pnemVYd1Ezbi9VZHM1VS90eG9Dc1BWYWNRczNKQ1ErNkJ4a1dITFhyL1ZB?=
 =?utf-8?B?VGR6NzFxWWVxMjJnRGRSdHh5eklpdW1SYTlwR1NWNC9aNENWRFd2VURRM1ll?=
 =?utf-8?B?UDhNSDFTTEhveGhpWXVJTW9KT2k3QUhTT0ZGZFFYS2QrK1d6WWR2TWtGWDdx?=
 =?utf-8?B?ajgzVjAzbDN6dGxZeTd6VVlidUd2T0x5YnZLVVVZb1dxbTRIRlZYVHlWZU54?=
 =?utf-8?B?WDJwSWNDMjdjUTRnODJZbFBWTDhtaTVjVklqSnhzL2FjYTFJT2FTaW1Sb2xO?=
 =?utf-8?B?U09XZFh1cDFwZ2pZblJoQnAwY3BQdHQ2Yi82MjhORmhoQk4vQUJxQXhzc1FT?=
 =?utf-8?B?WWhkNzJIZ0dqYXdwTWVic0hIdUxyRStqRFpvaWo2YlZkRDRhQjhyMUxsRGNH?=
 =?utf-8?B?VjlhY2JxOC9ZR1hTc0VQUUROWGRtQkExSmFwcU9BbEpyYWFXV0NPaUUzWGsz?=
 =?utf-8?B?aFVHRmVrTlBnTEw0UUdESlVpVHFiZkE0d2E5bjhUSkxpZE5XNjdjRkx5M1BE?=
 =?utf-8?B?VE4vYlhLcUplT2RrRE9SbUFWbUpIb1hBVXhCa0ZFckl0dTcxaWpidmQ5TWt6?=
 =?utf-8?B?YnlVYzFtbjkrdEN5UXJmQmdnYVNQUUorZnN1QUxBOEQzcVZOTE5KWEpSZmp3?=
 =?utf-8?B?ME15T3k2cnJkMkh5MjNucTluZjc5MzlZcWdNQlBENDU2eDN0aGFNbFB4eUpU?=
 =?utf-8?B?ZHNWcXVWWXdYVlFKMmNzRDJXeFJNbnZhRnMwOFlMU3g0bWNvalErQ1U5aGlE?=
 =?utf-8?B?b0FiLzBtWGg5aXRxa2Y0NWlRaVJmcTNIK2pJM1RxK3pTbWtPQTNOZFIrZDVS?=
 =?utf-8?B?K1k0SzhpQkNCOEhraEYxdWRuMEkyVW5CdDFiQ2pkNm9nT1lOcFRROWRCWmFn?=
 =?utf-8?B?amxERXFmbC9FZnVnaU0yaUdySUNVMlN3V0RRT0J5Nm9FU3B0bWxTUUIzazBU?=
 =?utf-8?B?d01EUzlCYXhxOTN0VHhEanVxOXREMFVRRUpta3VOUXJpTjhhOVZodHlLL0lt?=
 =?utf-8?B?QzhWM0lrMjdMOStRa09EMEpCVWNkbDBQQ2NPb0ZocGk5MmpMVWVCbEtHWlBB?=
 =?utf-8?B?aVlrZzJtOUd1dE55ZlBLUWlrSkF5SnhRclZJS05zQk5jSzJ0UEhCT21Oa3Y0?=
 =?utf-8?B?aVo4Ymx2bWZJc0NSWExwamVRSmUrci8ycDQ0TnRNSk9WenY3Q1J6WjEyOGJS?=
 =?utf-8?B?aUpCb3h2WnMxMCtJQnNMQ1dGOHFjL2ljNnpENC9JVm5XaGlZaVRVbWxld1ZF?=
 =?utf-8?B?K2JMbmgwZElKZHdaZW9jTGtUK0pudmVmOTI4TEdtV1JjLzlsT0ZjOXR4L3pE?=
 =?utf-8?B?UXpScGs4SEpjZ1lDZnFoVnJUekYrNXREY1pFdWhoaGxRMFYwZ3hEd3VGOHFk?=
 =?utf-8?B?a0UrczN3K0RIZ0YybXpUcy9WODcvaWswdVIxZGN2Sk5LMnBNVlZtTE5idHJy?=
 =?utf-8?B?ZFVjbGNuSXJzR1NsSTBKSVRGVk5KSUNMYk1pWldQQjgyY3dqVm1pdis1UFNE?=
 =?utf-8?B?YytscEI0U29NU2dackdFR0NraitEby9pS3RtNGl2bWxhSGlXYXJGcmtvVzg2?=
 =?utf-8?B?bHMybUhvejRsNjAzTWFDTUI1MWV6V1BoUUZYYWRlaVE4T3pYQUF1MnhucUhY?=
 =?utf-8?B?TFJsQWVJYStXOHRqV3VZUzNieXpEWG96Q210VzVSa2NyTzNZNVIwRTJOaGRi?=
 =?utf-8?B?TytVRXFXL21wdndnZ3hwVUpsUE8zZlFmWnNCd0s1QTVxRHNiem1tMG1FUEIx?=
 =?utf-8?B?cXJ3aFpmVWM1Y3E4bC9Md2YrTWJ1OVRSYWhuc3BBN2N1MmNhajF5T0ZJckVP?=
 =?utf-8?B?ZnhsenJxRmlpN3lmejVIS1lmTGwrRjE4NitiTTVOZDBocWdDcWdKM1Vsdjh4?=
 =?utf-8?B?d25yWmRsNjFqNk5HSlZRMXh3MnBTdDRkK3llTHpHTEtXckZCSXRYcXZCWGw1?=
 =?utf-8?B?R3ZiNThvK2twMmw2eGVodGVxaWtnUDhXT0VzZ0p4ZWF5c1UwTjN2OU1OZnhM?=
 =?utf-8?B?Nk05K0hvYS9DRU0vV2o4V2E4VksxWC9wSDVoVXNqdGtvT3NzalhWSWNZVnMx?=
 =?utf-8?B?dld4RVh5MDNGT3hSOEJUQmJ6NEdsRmJHUXdjUUN4aTV0TmphSDU1eGNXSFRs?=
 =?utf-8?B?akhNQWh4R0l6YnM5M3FnT2RRQ2ExbWplN0VhNG5GK2d0MGhId0R6aDdYczIr?=
 =?utf-8?B?eGFtVXFoY2hQUENNMndnTm5tVjdjZFY2TzJKUjI2Tkp0NXVvK1d3cHViTG1o?=
 =?utf-8?B?azRtWnhCV3hucm9xYnFRREJpWlhYR3RXZmFmWmtoT3hnMFhxT3pWdz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <8BFDE3265BE7CB4D83FE3625B2623D6A@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0910f785-3592-4d51-6ce1-08d9efbbbcb5
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Feb 2022 13:13:05.1846
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 1Gh/vpGN+pdreNZDr4l1UQ89G0Qbo9D0ht/Y6rp4evsq4SiKSLCP6lx6Aos/vZ3c2VQJCu6YA5UfTXhe1S4yBv3wChDUQEAzgXrhsvyjc92xZj/fQ/15ZdJGlJ6nijif
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR03MB5052
X-Proofpoint-GUID: n0rfuGn5DvtMlYYmL6xZw_H-KpeXsZZ7
X-Proofpoint-ORIG-GUID: n0rfuGn5DvtMlYYmL6xZw_H-KpeXsZZ7
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-14_06,2022-02-14_03,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501
 suspectscore=0 malwarescore=0 mlxlogscore=999 clxscore=1015 bulkscore=0
 lowpriorityscore=0 phishscore=0 mlxscore=0 impostorscore=0 spamscore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202140081

DQoNCk9uIDE0LjAyLjIyIDE0OjU3LCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMTQuMDIuMjAy
MiAxMjozNywgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+Pg0KPj4gT24gMTQuMDIu
MjIgMTM6MjUsIFJvZ2VyIFBhdSBNb25uw6kgd3JvdGU6DQo+Pj4gT24gTW9uLCBGZWIgMTQsIDIw
MjIgYXQgMTE6MTU6MjdBTSArMDAwMCwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+
Pj4+IE9uIDE0LjAyLjIyIDEzOjExLCBSb2dlciBQYXUgTW9ubsOpIHdyb3RlOg0KPj4+Pj4gT24g
TW9uLCBGZWIgMTQsIDIwMjIgYXQgMTA6NTM6NDNBTSArMDAwMCwgT2xla3NhbmRyIEFuZHJ1c2hj
aGVua28gd3JvdGU6DQo+Pj4+Pj4gT24gMTQuMDIuMjIgMTI6MzQsIFJvZ2VyIFBhdSBNb25uw6kg
d3JvdGU6DQo+Pj4+Pj4+IE9uIE1vbiwgRmViIDE0LCAyMDIyIGF0IDA5OjM2OjM5QU0gKzAwMDAs
IE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4+Pj4+Pj4gT24gMTEuMDIuMjIgMTM6
NDAsIFJvZ2VyIFBhdSBNb25uw6kgd3JvdGU6DQo+Pj4+Pj4+Pj4gKw0KPj4+Pj4+Pj4+Pj4+ICAg
ICAgICAgICAgZm9yICggaSA9IDA7IGkgPCBtc2l4LT5tYXhfZW50cmllczsgaSsrICkNCj4+Pj4+
Pj4+Pj4+PiAgICAgICAgICAgIHsNCj4+Pj4+Pj4+Pj4+PiAgICAgICAgICAgICAgICBjb25zdCBz
dHJ1Y3QgdnBjaV9tc2l4X2VudHJ5ICplbnRyeSA9ICZtc2l4LT5lbnRyaWVzW2ldOw0KPj4+Pj4+
Pj4+Pj4gU2luY2UgdGhpcyBmdW5jdGlvbiBpcyBub3cgY2FsbGVkIHdpdGggdGhlIHBlci1kb21h
aW4gcndsb2NrIHJlYWQNCj4+Pj4+Pj4+Pj4+IGxvY2tlZCBpdCdzIGxpa2VseSBub3QgYXBwcm9w
cmlhdGUgdG8gY2FsbCBwcm9jZXNzX3BlbmRpbmdfc29mdGlycXMNCj4+Pj4+Pj4+Pj4+IHdoaWxl
IGhvbGRpbmcgc3VjaCBsb2NrIChjaGVjayBiZWxvdykuDQo+Pj4+Pj4+Pj4+IFlvdSBhcmUgcmln
aHQsIGFzIGl0IGlzIHBvc3NpYmxlIHRoYXQ6DQo+Pj4+Pj4+Pj4+DQo+Pj4+Pj4+Pj4+IHByb2Nl
c3NfcGVuZGluZ19zb2Z0aXJxcyAtPiB2cGNpX3Byb2Nlc3NfcGVuZGluZyAtPiByZWFkX2xvY2sN
Cj4+Pj4+Pj4+Pj4NCj4+Pj4+Pj4+Pj4gRXZlbiBtb3JlLCB2cGNpX3Byb2Nlc3NfcGVuZGluZyBt
YXkgYWxzbw0KPj4+Pj4+Pj4+Pg0KPj4+Pj4+Pj4+PiByZWFkX3VubG9jayAtPiB2cGNpX3JlbW92
ZV9kZXZpY2UgLT4gd3JpdGVfbG9jaw0KPj4+Pj4+Pj4+Pg0KPj4+Pj4+Pj4+PiBpbiBpdHMgZXJy
b3IgcGF0aC4gU28sIGFueSBpbnZvY2F0aW9uIG9mIHByb2Nlc3NfcGVuZGluZ19zb2Z0aXJxcw0K
Pj4+Pj4+Pj4+PiBtdXN0IG5vdCBob2xkIGQtPnZwY2lfcndsb2NrIGF0IGxlYXN0Lg0KPj4+Pj4+
Pj4+Pg0KPj4+Pj4+Pj4+PiBBbmQgYWxzbyB3ZSBuZWVkIHRvIGNoZWNrIHRoYXQgcGRldi0+dnBj
aSB3YXMgbm90IHJlbW92ZWQNCj4+Pj4+Pj4+Pj4gaW4gYmV0d2VlbiBvciAqcmUtY3JlYXRlZCoN
Cj4+Pj4+Pj4+Pj4+IFdlIHdpbGwgbGlrZWx5IG5lZWQgdG8gcmUtaXRlcmF0ZSBvdmVyIHRoZSBs
aXN0IG9mIHBkZXZzIGFzc2lnbmVkIHRvDQo+Pj4+Pj4+Pj4+PiB0aGUgZG9tYWluIGFuZCBhc3Nl
cnQgdGhhdCB0aGUgcGRldiBpcyBzdGlsbCBhc3NpZ25lZCB0byB0aGUgc2FtZQ0KPj4+Pj4+Pj4+
Pj4gZG9tYWluLg0KPj4+Pj4+Pj4+PiBTbywgZG8geW91IG1lYW4gYSBwYXR0ZXJuIGxpa2UgdGhl
IGJlbG93IHNob3VsZCBiZSB1c2VkIGF0IGFsbA0KPj4+Pj4+Pj4+PiBwbGFjZXMgd2hlcmUgd2Ug
bmVlZCB0byBjYWxsIHByb2Nlc3NfcGVuZGluZ19zb2Z0aXJxcz8NCj4+Pj4+Pj4+Pj4NCj4+Pj4+
Pj4+Pj4gcmVhZF91bmxvY2sNCj4+Pj4+Pj4+Pj4gcHJvY2Vzc19wZW5kaW5nX3NvZnRpcnFzDQo+
Pj4+Pj4+Pj4+IHJlYWRfbG9jaw0KPj4+Pj4+Pj4+PiBwZGV2ID0gcGNpX2dldF9wZGV2X2J5X2Rv
bWFpbihkLCBzYmRmLnNlZywgc2JkZi5idXMsIHNiZGYuZGV2Zm4pOw0KPj4+Pj4+Pj4+PiBpZiAo
IHBkZXYgJiYgcGRldi0+dnBjaSAmJiBpc190aGVfc2FtZV92cGNpKHBkZXYtPnZwY2kpICkNCj4+
Pj4+Pj4+Pj4gPGNvbnRpbnVlIHByb2Nlc3Npbmc+DQo+Pj4+Pj4+Pj4gU29tZXRoaW5nIGFsb25n
IHRob3NlIGxpbmVzLiBZb3UgbGlrZWx5IG5lZWQgdG8gY29udGludWUgaXRlcmF0ZSB1c2luZw0K
Pj4+Pj4+Pj4+IGZvcl9lYWNoX3BkZXYuDQo+Pj4+Pj4+PiBIb3cgZG8gd2UgdGVsbCBpZiBwZGV2
LT52cGNpIGlzIHRoZSBzYW1lPyBKYW4gaGFzIGFscmVhZHkgYnJvdWdodA0KPj4+Pj4+Pj4gdGhp
cyBxdWVzdGlvbiBiZWZvcmUgWzFdIGFuZCBJIHdhcyBhYm91dCB0byB1c2Ugc29tZSBJRCBmb3Ig
dGhhdCBwdXJwb3NlOg0KPj4+Pj4+Pj4gcGRldi0+dnBjaS0+aWQgPSBkLT52cGNpX2lkKysgYW5k
IHRoZW4gd2UgdXNlIHBkZXYtPnZwY2ktPmlkwqAgZm9yIGNoZWNrcw0KPj4+Pj4+PiBHaXZlbiB0
aGlzIGlzIGEgZGVidWcgbWVzc2FnZSBJIHdvdWxkIGJlIE9LIHdpdGgganVzdCBkb2luZyB0aGUN
Cj4+Pj4+Pj4gbWluaW1hbCBjaGVja3MgdG8gcHJldmVudCBYZW4gZnJvbSBjcmFzaGluZyAoaWU6
IHBkZXYtPnZwY2kgZXhpc3RzKQ0KPj4+Pj4+PiBhbmQgdGhhdCB0aGUgcmVzdW1lIE1TSSBlbnRy
eSBpcyBub3QgcGFzdCB0aGUgY3VycmVudCBsaW1pdC4gT3RoZXJ3aXNlDQo+Pj4+Pj4+IGp1c3Qg
cHJpbnQgYSBtZXNzYWdlIGFuZCBtb3ZlIG9uIHRvIHRoZSBuZXh0IGRldmljZS4NCj4+Pj4+PiBB
Z3JlZSwgSSBzZWUgbm8gYmlnIGlzc3VlIChwcm9iYWJseSkgaWYgd2UgYXJlIG5vdCBhYmxlIHRv
IHByaW50DQo+Pj4+Pj4NCj4+Pj4+PiBIb3cgYWJvdXQgdGhpcyBvbmU6DQo+Pj4+Pj4NCj4+Pj4+
PiBkaWZmIC0tZ2l0IGEveGVuL2RyaXZlcnMvdnBjaS9oZWFkZXIuYyBiL3hlbi9kcml2ZXJzL3Zw
Y2kvaGVhZGVyLmMNCj4+Pj4+PiBpbmRleCA4MDlhNmI0NzczZTEuLjUwMzczZjA0ZGE4MiAxMDA2
NDQNCj4+Pj4+PiAtLS0gYS94ZW4vZHJpdmVycy92cGNpL2hlYWRlci5jDQo+Pj4+Pj4gKysrIGIv
eGVuL2RyaXZlcnMvdnBjaS9oZWFkZXIuYw0KPj4+Pj4+IEBAIC0xNzEsMTAgKzE3MSwzMSBAQCBz
dGF0aWMgaW50IF9faW5pdCBhcHBseV9tYXAoc3RydWN0IGRvbWFpbiAqZCwgY29uc3Qgc3RydWN0
IHBjaV9kZXYgKnBkZXYsDQo+Pj4+Pj4gICAgIMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHN0cnVjdCByYW5nZXNldCAqbWVtLCB1aW50MTZf
dCBjbWQpDQo+Pj4+Pj4gICAgIMKgew0KPj4+Pj4+ICAgICDCoMKgwqDCoCBzdHJ1Y3QgbWFwX2Rh
dGEgZGF0YSA9IHsgLmQgPSBkLCAubWFwID0gdHJ1ZSB9Ow0KPj4+Pj4+ICvCoMKgwqAgcGNpX3Ni
ZGZfdCBzYmRmID0gcGRldi0+c2JkZjsNCj4+Pj4+PiAgICAgwqDCoMKgwqAgaW50IHJjOw0KPj4+
Pj4+DQo+Pj4+Pj4gKyBBU1NFUlQocndfaXNfd3JpdGVfbG9ja2VkKCZwZGV2LT5kb21haW4tPnZw
Y2lfcndsb2NrKSk7DQo+Pj4+Pj4gKw0KPj4+Pj4+ICAgICDCoMKgwqDCoCB3aGlsZSAoIChyYyA9
IHJhbmdlc2V0X2NvbnN1bWVfcmFuZ2VzKG1lbSwgbWFwX3JhbmdlLCAmZGF0YSkpID09IC1FUkVT
VEFSVCApDQo+Pj4+Pj4gK8KgwqDCoCB7DQo+Pj4+Pj4gKw0KPj4+Pj4+ICvCoMKgwqDCoMKgwqDC
oCAvKg0KPj4+Pj4+ICvCoMKgwqDCoMKgwqDCoMKgICogcHJvY2Vzc19wZW5kaW5nX3NvZnRpcnFz
IG1heSB0cmlnZ2VyIHZwY2lfcHJvY2Vzc19wZW5kaW5nIHdoaWNoDQo+Pj4+Pj4gK8KgwqDCoMKg
wqDCoMKgwqAgKiBtYXkgbmVlZCB0byBhY3F1aXJlIHBkZXYtPmRvbWFpbi0+dnBjaV9yd2xvY2sg
aW4gcmVhZCBtb2RlLg0KPj4+Pj4+ICvCoMKgwqDCoMKgwqDCoMKgICovDQo+Pj4+Pj4gK8KgwqDC
oMKgwqDCoMKgIHdyaXRlX3VubG9jaygmcGRldi0+ZG9tYWluLT52cGNpX3J3bG9jayk7DQo+Pj4+
Pj4gICAgIMKgwqDCoMKgwqDCoMKgwqAgcHJvY2Vzc19wZW5kaW5nX3NvZnRpcnFzKCk7DQo+Pj4+
Pj4gK8KgwqDCoMKgwqDCoMKgIHdyaXRlX2xvY2soJnBkZXYtPmRvbWFpbi0+dnBjaV9yd2xvY2sp
Ow0KPj4+Pj4+ICsNCj4+Pj4+PiArwqDCoMKgwqDCoMKgwqAgLyogQ2hlY2sgaWYgcGRldiBzdGls
bCBleGlzdHMgYW5kIHZQQ0kgd2FzIG5vdCByZW1vdmVkIG9yIHJlLWNyZWF0ZWQuICovDQo+Pj4+
Pj4gK8KgwqDCoMKgwqDCoMKgIGlmIChwY2lfZ2V0X3BkZXZfYnlfZG9tYWluKGQsIHNiZGYuc2Vn
LCBzYmRmLmJ1cywgc2JkZi5kZXZmbikgIT0gcGRldikNCj4+Pj4+PiArwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoCBpZiAoIHZwY2kgaXMgTk9UIHRoZSBzYW1lICkNCj4+Pj4+PiArwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoCB7DQo+Pj4+Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCByYyA9
IDA7DQo+Pj4+Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBicmVhazsNCj4+Pj4+
PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB9DQo+Pj4+Pj4gK8KgwqDCoCB9DQo+Pj4+Pj4gKw0K
Pj4+Pj4+ICAgICDCoMKgwqDCoCByYW5nZXNldF9kZXN0cm95KG1lbSk7DQo+Pj4+Pj4gICAgIMKg
wqDCoMKgIGlmICggIXJjICkNCj4+Pj4+PiAgICAgwqDCoMKgwqDCoMKgwqDCoCBtb2RpZnlfZGVj
b2RpbmcocGRldiwgY21kLCBmYWxzZSk7DQo+Pj4+Pj4NCj4+Pj4+PiBUaGlzIG9uZSBhbHNvIHdh
bnRzIHByb2Nlc3NfcGVuZGluZ19zb2Z0aXJxcyB0byBydW4gc28gaXQgKm1pZ2h0Kg0KPj4+Pj4+
IHdhbnQgcGRldiBhbmQgdnBjaSBjaGVja3MuIEJ1dCBhdCB0aGUgc2FtZSB0aW1lIGFwcGx5X21h
cCBydW5zDQo+Pj4+Pj4gYXQgKCBzeXN0ZW1fc3RhdGUgPCBTWVNfU1RBVEVfYWN0aXZlICksIHNv
IGRlZmVyX21hcCB3b24ndCBiZQ0KPj4+Pj4+IHJ1bm5pbmcgeWV0LCB0aHVzIG5vIHZwY2lfcHJv
Y2Vzc19wZW5kaW5nIGlzIHBvc3NpYmxlIHlldCAoaW4gdGVybXMNCj4+Pj4+PiBpdCBoYXMgc29t
ZXRoaW5nIHRvIGRvIHlldCkuIFNvLCBJIHRoaW5rIHdlIGp1c3QgbmVlZDoNCj4+Pj4+Pg0KPj4+
Pj4+ICAgICDCoMKgwqDCoMKgwqDCoCB3cml0ZV91bmxvY2soJnBkZXYtPmRvbWFpbi0+dnBjaV9y
d2xvY2spOw0KPj4+Pj4+ICAgICDCoMKgwqDCoMKgwqDCoCBwcm9jZXNzX3BlbmRpbmdfc29mdGly
cXMoKTsNCj4+Pj4+PiAgICAgwqDCoMKgwqDCoMKgwqAgd3JpdGVfbG9jaygmcGRldi0+ZG9tYWlu
LT52cGNpX3J3bG9jayk7DQo+Pj4+Pj4NCj4+Pj4+PiBhbmQgdGhpcyBzaG91bGQgYmUgZW5vdWdo
DQo+Pj4+PiBHaXZlbiB0aGUgY29udGV4dCBhcHBseV9tYXAgaXMgY2FsbGVkIGZyb20gKGRvbTAg
c3BlY2lmaWMgaW5pdCBjb2RlKSwNCj4+Pj4+IHRoZXJlJ3Mgbm8gbmVlZCB0byBjaGVjayBmb3Ig
dGhlIHBkZXYgdG8gc3RpbGwgZXhpdHMsIG9yIHdoZXRoZXIgdnBjaQ0KPj4+Pj4gaGFzIGJlZW4g
cmVjcmVhdGVkLCBhcyBpdCdzIG5vdCBwb3NzaWJsZS4gSnVzdCBhZGQgYSBjb21tZW50IHRvDQo+
Pj4+PiBleHBsaWNpdGx5IG5vdGUgdGhhdCB0aGUgY29udGV4dCBvZiB0aGUgZnVuY3Rpb24gaXMg
c3BlY2lhbCwgYW5kIHRodXMNCj4+Pj4+IHRoZXJlJ3Mgbm8gcG9zc2liaWxpdHkgb2YgZWl0aGVy
IHRoZSBkZXZpY2Ugb3IgdnBjaSBnb2luZyBhd2F5Lg0KPj4+PiBEb2VzIGl0IHJlYWxseSBuZWVk
IHdyaXRlX3VubG9jay93cml0ZV9sb2NrIGdpdmVuIHRoZSBjb250ZXh0Py4uLg0KPj4+IEkgdGhp
bmsgaXQncyBiYWQgcHJhY3RpY2UgdG8gY2FsbCBwcm9jZXNzX3BlbmRpbmdfc29mdGlycXMgd2hp
bGUNCj4+PiBob2xkaW5nIGFueSBsb2Nrcy4gVGhpcyBpcyBhIHZlcnkgc3BlY2lmaWMgY29udGV4
dCBzbyBpdCdzIGxpa2VseSBmaW5lDQo+Pj4gdG8gbm90IGRyb3AgdGhlIGxvY2ssIGJ1dCB3b3Vs
ZCBzdGlsbCBzZWVtIGluY29ycmVjdCB0byBtZS4NCj4+IE9rDQo+Pj4+IEkgdGhpbmsgaXQgZG9l
c24ndCBhcyB0aGVyZSBpcyBubyBjaGFuY2UgZGVmZXJfbWFwIGlzIGNhbGxlZCwgdGh1cw0KPj4+
PiBwcm9jZXNzX3BlbmRpbmdfc29mdGlycXMgLT4gdnBjaV9wcm9jZXNzX3BlbmRpbmcgLT4gcmVh
ZF9sb2NrDQo+Pj4gSW5kZWVkLCB0aGVyZSdzIG5vIGNoYW5jZSBvZiB0aGF0IGJlY2F1c2UgcHJv
Y2Vzc19wZW5kaW5nX3NvZnRpcnFzDQo+Pj4gd2lsbCBuZXZlciB0cnkgdG8gZG8gYSBzY2hlZHVs
aW5nIG9wZXJhdGlvbiB0aGF0IHdvdWxkIHJlc3VsdCBpbiBvdXINCj4+PiBjb250ZXh0IGJlaW5n
IHNjaGVkdWxlZCBvdXQuDQo+PiAgIMKgwqDCoCB3aGlsZSAoIChyYyA9IHJhbmdlc2V0X2NvbnN1
bWVfcmFuZ2VzKG1lbSwgbWFwX3JhbmdlLCAmZGF0YSkpID09IC1FUkVTVEFSVCApDQo+PiAgIMKg
wqDCoCB7DQo+PiAgIMKgwqDCoMKgwqDCoMKgIC8qDQo+PiAgIMKgwqDCoMKgwqDCoMKgwqAgKiBG
SVhNRTogR2l2ZW4gdGhlIGNvbnRleHQgYXBwbHlfbWFwIGlzIGNhbGxlZCBmcm9tIChkb20wIHNw
ZWNpZmljDQo+PiAgIMKgwqDCoMKgwqDCoMKgwqAgKiBpbml0IGNvZGUgYXQgc3lzdGVtX3N0YXRl
IDwgU1lTX1NUQVRFX2FjdGl2ZSkgaXQgaXMgbm90IHN0cmljdGx5DQo+PiAgIMKgwqDCoMKgwqDC
oMKgwqAgKiByZXF1aXJlZCB0aGF0IHBkZXYtPmRvbWFpbi0+dnBjaV9yd2xvY2sgaXMgdW5sb2Nr
ZWQgYmVmb3JlIGNhbGxpbmcNCj4+ICAgwqDCoMKgwqDCoMKgwqDCoCAqIHByb2Nlc3NfcGVuZGlu
Z19zb2Z0aXJxcyBhcyB0aGVyZSBpcyBubyBjb250ZW50aW9uIHBvc3NpYmxlIGJldHdlZW4NCj4+
ICAgwqDCoMKgwqDCoMKgwqDCoCAqIHRoaXMgY29kZSBhbmQgdnBjaV9wcm9jZXNzX3BlbmRpbmcg
dHJ5aW5nIHRvIGFjcXVpcmUgdGhlIGxvY2sgaW4NCj4+ICAgwqDCoMKgwqDCoMKgwqDCoCAqIHJl
YWQgbW9kZS4gQnV0IHJ1bm5pbmcgcHJvY2Vzc19wZW5kaW5nX3NvZnRpcnFzIHdpdGggYW55IGxv
Y2sgaGVsZA0KPj4gICDCoMKgwqDCoMKgwqDCoMKgICogZG9lc24ndCBzZWVtIHRvIGJlIGEgZ29v
ZCBwcmFjdGljZSwgc28gZHJvcCB0aGUgbG9jayBhbmQgcmUtYWNxdWlyZQ0KPj4gICDCoMKgwqDC
oMKgwqDCoMKgICogaXQgcmlnaHQgYWdhaW4uDQo+PiAgIMKgwqDCoMKgwqDCoMKgwqAgKi8NCj4+
ICAgwqDCoMKgwqDCoMKgwqAgd3JpdGVfdW5sb2NrKCZwZGV2LT5kb21haW4tPnZwY2lfcndsb2Nr
KTsNCj4+ICAgwqDCoMKgwqDCoMKgwqAgcHJvY2Vzc19wZW5kaW5nX3NvZnRpcnFzKCk7DQo+PiAg
IMKgwqDCoMKgwqDCoMKgIHdyaXRlX2xvY2soJnBkZXYtPmRvbWFpbi0+dnBjaV9yd2xvY2spOw0K
Pj4gICDCoMKgwqAgfQ0KPiBJJ20gYWZyYWlkIHRoYXQncyBtaXNsZWFkaW5nIGF0IGJlc3QuIGFw
cGx5X21hcCgpIGlzIG1lcmVseSBhIHNwZWNpZmljDQo+IGV4YW1wbGUgd2hlcmUgeW91IGtub3cg
dGhlIGxvY2sgaXMgZ29pbmcgdG8gYmUgdGFrZW4uIEJ1dCByZWFsbHkgYW55DQo+IHNvZnRpcnEg
aGFuZGxlciBjb3VsZCBiZSBhY3F1aXJpbmcgYW55IGxvY2ssIHNvIHJlcXVlc3RpbmcgdG8gcHJv
Y2Vzcw0KPiBzb2Z0aXJxcyBjYW5ub3QgZXZlciBiZSBkb25lIHdpdGggYW55IGxvY2sgaGVsZC4N
Cj4NCj4gV2hhdCB5b3UgaW5zdGVhZCB3YW50IHRvIGV4cGxhaW4gaXMgd2h5LCBhZnRlciByZS1h
Y3F1aXJpbmcgdGhlIGxvY2ssDQo+IG5vIGZ1cnRoZXIgY2hlY2tpbmcgaXMgbmVlZGVkIGZvciBw
b3RlbnRpYWxseSBjaGFuZ2VkIHN0YXRlLg0KSG93IGFib3V0Og0KDQovKg0KIMKgKiBGSVhNRTog
R2l2ZW4gdGhlIGNvbnRleHQgYXBwbHlfbWFwIGlzIGNhbGxlZCBmcm9tIChkb20wIHNwZWNpZmlj
DQogwqAqIGluaXQgY29kZSBhdCBzeXN0ZW1fc3RhdGUgPCBTWVNfU1RBVEVfYWN0aXZlKSB0aGVy
ZSBpcyBubyBjb250ZW50aW9uDQogwqAqIHBvc3NpYmxlIGJldHdlZW4gdGhpcyBjb2RlIGFuZCB2
cGNpX3Byb2Nlc3NfcGVuZGluZyB0cnlpbmcgdG8gYWNxdWlyZQ0KIMKgKiB0aGUgbG9jayBpbiBy
ZWFkIG1vZGUgYW5kIGRlc3Ryb3kgcGRldi0+dnBjaSBpbiBpdHMgZXJyb3IgcGF0aC4NCiDCoCog
TmVpdGhlciBwZGV2IG1heSBiZSBkaXNwb3NlZCB5ZXQsIHNvIGl0IGlzIG5vdCByZXF1aXJlZCB0
byBjaGVjayBpZiB0aGUNCiDCoCogcmVsZXZhbnQgcGRldiBzdGlsbCBleGlzdHMgYWZ0ZXIgcmUt
YWNxdWlyaW5nIHRoZSBsb2NrLg0KIMKgKi8NCg0KPg0KPiBKYW4NCj4NClRoYW5rIHlvdSwNCk9s
ZWtzYW5kcg==


From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:13:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:13:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271885.466598 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbAs-0007VA-Ia; Mon, 14 Feb 2022 13:13:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271885.466598; Mon, 14 Feb 2022 13:13:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbAs-0007V3-Fb; Mon, 14 Feb 2022 13:13:50 +0000
Received: by outflank-mailman (input) for mailman id 271885;
 Mon, 14 Feb 2022 13:13:49 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KkXt=S5=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nJbAr-0007Ul-3M
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:13:49 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f1dfcabd-8d97-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 14:13:48 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2058.outbound.protection.outlook.com [104.47.14.58]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-11-lixr1cFUMgijD8Ux3yzamw-1; Mon, 14 Feb 2022 14:13:46 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3406.eurprd04.prod.outlook.com (2603:10a6:803:c::27)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.15; Mon, 14 Feb
 2022 13:13:45 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4975.015; Mon, 14 Feb 2022
 13:13:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f1dfcabd-8d97-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644844427;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=4Fi8D62XABGeWjmxtlfo7U4bG6XfsuzWSsHMcCnfDOA=;
	b=X78p+WPnxfzHxlS6jKy1iIMRwUnKdytx8EPukOYB8L3ajmKH96A/FaFSJrssBy7LcqXTSl
	KaSgYXOCVd2nYUxwGYdcF2hgTkJDTNSKicSnNlzYRHvIFj85kvCScioCgA9Bki9eXIMMqu
	a0tzD+QatAb5vwp3z54EgjSZfieqYVs=
X-MC-Unique: lixr1cFUMgijD8Ux3yzamw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ctdBXAYTupgRdxIWOyViX0l/1EgT0qHMEfAOpssEwX7gU8TAmSqEM7sFqoconCRehBtkvDCB3ohlgA8qPfvVYykWasfXETslUDH3mjqhqrFNmoFY3obz++s1fpgzpOu6bBgUWNyzkaqUj6m1BoCNYyvCNl6sU9rGDHM84sl1bqd00//Ju7+j7Wh0Gxf9D8roGdCym+NAO+Yjwewv+4nerTeSr1Nfv8sXhTk5GV2k1qN9EXgdS1RbC65YRPIl5F/q4XoqwVtOKqXcgi6bPbRZjdWAy8GA59mVxFDZHGXAlTHCsoDiXpI5690cSjCQEbYjT5cxWXAmNwVUHHx3oIOSyQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=4Fi8D62XABGeWjmxtlfo7U4bG6XfsuzWSsHMcCnfDOA=;
 b=Vctq11h5Sn3lqyzKNLy8W3MDyZWZYKydSrAq/8tyyJ+0c7Syj+Kieqjenut5NnJi7DqEumb/99UtMi7aD5xX901q5+8opvDIfPlygz6r+aBDW9+5qH3EdeU/BcESJQYB8uUZ64VTLH9tQ6TteAl2meDmbaDHgyafXbk78DxoAh8gSpc/uKZ9dvmx7oEIWJyzFeyUsC0Bb8YLYGl3dPtOJ0OBV64vc24MXqGABS3JvGzzyzOrMoq0Qner5IhDtG+G0CwdvEDmfxe3t0Erx9DywrljWIwiZWiLKGv6o7KTXQMZxSuGL6poxjYc07bne1Jx5rT7y2tgsCO2Ymy9WY/SeA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <06407c26-a189-c4f4-a30b-3bf802be06ea@suse.com>
Date: Mon, 14 Feb 2022 14:13:44 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH v2 6/7] x86/ucode: Use altcall, and __initconst_cf_clobber
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20220214125632.24563-1-andrew.cooper3@citrix.com>
 <20220214125632.24563-7-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220214125632.24563-7-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0276.eurprd06.prod.outlook.com
 (2603:10a6:20b:45a::34) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5b17ed0b-1ca7-433f-fe48-08d9efbbd4b1
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3406:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB34065EB416A13820CAB7651DB3339@VI1PR0402MB3406.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3631;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	n0tYlBG0ahgqcsp9lIR+Uk9UDe6+pEGH1pClr/GyV/VY46pAL/wpu8s9kPoFsodotVv+8bFf5074XApPwBHv7JUJfBO0ofFAs3MeNbPXX7jkfxjATTQ+U7hQp9X4H0qn1joL2IAdv8x2d008MRXVI73NFWlayo2SorDZVy7fWVAezufkmwEeQkG+F2mCYRqxkEgr4x0XFQZf6YYPaIUtZFfHi7PuznPKVwmED5f6t3mSgStwgEH7gczedawU5AzpZYxOeCA9ZPVObWzolmAwpVtSiCPoZ1Xnajm137rkoa/dPgG0VHDOnbr6f8RJ3lBvJ1jU7bVQuycTDpnv6g2YnxnLy6faK4qP9/YmOwXZPovOPgUgbaHcWSBU93it/xPiJCOXYcZAqE9Z5pUjooQl4F/yEic0KQYU3HfljL0HumuEBzypREl5y/OOVurEAHV85lZn6KEzyKx/tXrH39atTyBmPG1pvz1lfohDOxbhs4doklVdQgUYQOjZzcG6V14FEO8gqkLfBLMmVZNJgD7HALtFxEBswn2jAgV1C6WdNfIJ9YyPdnbv3qwvvwFmlbA8+UCCtosEUR8B7cXkuXUPr2wEAh5ElqqToUzwdjPIiuqvpE1nFrNWxvjFiLxoIHtydwtPVJ0MvSs/nOkzBTEHc2d7gDV7/eke+s1nIkX9BBsm2pxnWaCJFPzLpZnU1riI+mOxtgAXovzAVuqUtfCBKH6L9X82xoWuotLudcq+E2E=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6506007)(5660300002)(53546011)(508600001)(36756003)(6916009)(316002)(38100700002)(54906003)(31686004)(31696002)(66476007)(66556008)(26005)(186003)(2616005)(6486002)(8936002)(8676002)(66946007)(2906002)(4744005)(6512007)(86362001)(4326008)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?d1Z5M1RpNTJsM09QKzQ4ZTVCamw1cFJQUFA2Qm8zbVkxREViTm9rSlRmTURq?=
 =?utf-8?B?TFl1QWw0dGtKM3F4bmJ5KzlDRUljN1pybkhoNkZDejNaWXpKNEFiWDlJN2di?=
 =?utf-8?B?ZStSVkhvWnRSU2xaaVNYMU9FbWYrVWp1M21yaVQrUHBlNG9DT3lFNnJjbG9l?=
 =?utf-8?B?dER4L29uMTV5b0d3enpLS29rS3lLU2lPK3Bsa2hWdU5YUnhFZXQrSlFNa1JG?=
 =?utf-8?B?K3JvQmZuOWpyWGNSU0Jua25WOVBOMjU1LzhxMEd3WnJrMzN1RllKQU50ZjZM?=
 =?utf-8?B?NW85N1A4SG91QzZOd0tXYTRscjI3Z1BSYnJMUjhha0F4ZjRCblRPZ1dhdDhk?=
 =?utf-8?B?QmFRQVp6amJzVkRQeE00aUFWVEpobHJSdmFGeW1pVXgxNW1wNmJLM081dDVF?=
 =?utf-8?B?cThUVWl1d1ZCeXhjcjJHZmdYK0tVUndSd2wwUGt4Und3ZVZhVTdJcE82SzN5?=
 =?utf-8?B?Rm4wVVVhNlpuTHBRc0R3VGw0V2ZlSXc5SU5BRjhaYlBnSlB0R21hV09LWHpl?=
 =?utf-8?B?ZmdqUEZSVnhjeW5UZ3ZOSjc5WkFST3VIMGFlcXY5bkZVUlFaNlh0b3M5bmph?=
 =?utf-8?B?TVA0WU5wdG4rVkxiSEpPQTlmK1A3cnNadHh2SnhxNFNOYjVPUi9rUzU1d1l4?=
 =?utf-8?B?SEtCclltNTF0Vk1naWtmVnhvOFpvTmlkaVRRK3pBcytiTVRQZkJKNk1vRFYx?=
 =?utf-8?B?aGJDbktZRGprZ2RSK09URXVjSWM5L3NPc2w1b3pkSkcxRmw3OVk4MmZHT0NK?=
 =?utf-8?B?R2NPS1FzeWlHeGpXMEZaZ3lTUmFyY1dva2hqampEYWh2VzdOR3l4cDgxODhq?=
 =?utf-8?B?ZzJGM2VYL3pKTXNySCtlYjRBWGxMaHNEa1lSYmZSWGZNZDBDanlsejlqTExu?=
 =?utf-8?B?Zzl4dVU3eUZDSk1rRFlZZVphTXJ3b1VtOE03Z0FzWkEySEFRNy9HS2plZFRQ?=
 =?utf-8?B?NVUwUTFRSXNNR0lGQ24wVzN0RUdDdmg4Ni8rclVzQ3BNeTczVkQrQ2xBYng2?=
 =?utf-8?B?QVZLTFh1Vy8vcEtGOThqR0xYMm5JTmYva3dlc21vYlBud1ZYczgyZnNKWFRs?=
 =?utf-8?B?dGVzZHdQWjVyRTQ3SCtFaGRjL1lBUGhHbFNWRGZOckhrdnJ6UDY2VGhLUm0z?=
 =?utf-8?B?VzFaV1RudzVPdGsyckNWc1NZVEFCRWR6TC93ckhEY1VZSkwvLzk5UmRCLzNR?=
 =?utf-8?B?ZHdGam1JWGREWkhFYVRJZGNsK0pFajMrRXdXeERCYjl6WlQ3UjNLOExtY3ZU?=
 =?utf-8?B?Nm92dVdJUGZncEhXb2UzMHhrVVBlUks3aldodEVRZUhLYkdmYnJkSXY0SGE2?=
 =?utf-8?B?ZWV4MnpBZ2ZiQWFPa21jTHdrQjRWNjMwZitIeUJFQXdkRmY5V3p2bFV4K0Vm?=
 =?utf-8?B?YncvSWhIbDR6NjV0VGVZUmFUcEozWlBpNlAya1FXVmd0cjRwdkM3NUpPTjhl?=
 =?utf-8?B?T1gxQSttSEFKTFY0bFlwQVF0SSt5eGRjTW8xTmlmb1lpRXd2b2NiWFV6NkNP?=
 =?utf-8?B?TVhMREpGbDVtZUxrd1lIc3hnUk1VTFl1SGJ0cjV4dmNwUDlURGttRWVPc1N5?=
 =?utf-8?B?UkpjeVNpK0ZJTys2N1R6cWRJSzlzYnE4K290aXU4MzNNcmh2WExjd0JSOEx4?=
 =?utf-8?B?WFByUTZzSzdaVFNpT2JLOVBLZTBiQVZCVkRpQkZjaDFCZlMyNHc4ZmFtZjVY?=
 =?utf-8?B?cFJVV29INUxudlRUOFVDVFlIblJ1UEdrcUt0QjFCQXVTbDU4TkEvOHFVV1hz?=
 =?utf-8?B?cE1Rb3E0dVBaS0FaeC8yQ2JaL0V3RlBDS3FQaTlEa2pCejlpRmpRR2lVYzRD?=
 =?utf-8?B?d2FhR1lXMWwvOTRJWVhZVUFDaGNmeXpPY3QrQmFnZWJvYzZ2N0xCTkR6VEFq?=
 =?utf-8?B?Rms0WEFQbmJqQlRNanFWMjVzZklwekV4bWdLL0tzOXRFYURuSmRyZ1lQV0ZX?=
 =?utf-8?B?dVo2MklNN2QvSW4xWnAvOEtNWlBBcm96NkwwbzI4a2YzTWZTRHdscEtuRysr?=
 =?utf-8?B?K0hwMmdvK0o2OWE1MThPT3FyNUdTeUtxbXlSNGViMTl1VnhXL3JRUllOZ1FB?=
 =?utf-8?B?RWltNFZaRW52T1V0OUhaaVlkMFRpNzR0ZlZ0Qm4zaERPZ3pjbThxTmkvaWdm?=
 =?utf-8?B?K3M3djd3cDB6VzdBSm4xa0R5aVMzODA2b053RWhQbUJBVVIwR0pING90OFFw?=
 =?utf-8?Q?Z2oq6azB2qaClteapbh8rUQ=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5b17ed0b-1ca7-433f-fe48-08d9efbbd4b1
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2022 13:13:45.7712
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AojWoxL5LqWOmxszyzp9QI+naRMMGEpz2oeok65AtBQntmQ1T67s24aQhrYLjLpUWYiyg7S7O7oCzZAOYqpwcg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3406

On 14.02.2022 13:56, Andrew Cooper wrote:
> Microcode loading is not a fastpath, but there are control flow integrity
> hardening benefits from using altcall, because it allows us to clobber the
> endbr64 instructions on all function pointer targets.
> 
> Convert the existing microcode_ops pointer into an __ro_after_init structure,
> and move {amd,intel}_ucode_ops into __initconst_cf_clobber.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:14:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:14:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271890.466610 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbB9-0007yR-Ql; Mon, 14 Feb 2022 13:14:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271890.466610; Mon, 14 Feb 2022 13:14:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbB9-0007yK-Nf; Mon, 14 Feb 2022 13:14:07 +0000
Received: by outflank-mailman (input) for mailman id 271890;
 Mon, 14 Feb 2022 13:14:07 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=gtPN=S5=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1nJbB8-0007Ul-NY
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:14:07 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05on2062c.outbound.protection.outlook.com
 [2a01:111:f400:7e1b::62c])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id fc5e7e16-8d97-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 14:14:05 +0100 (CET)
Received: from AM6PR0502CA0072.eurprd05.prod.outlook.com
 (2603:10a6:20b:56::49) by AS8PR08MB6947.eurprd08.prod.outlook.com
 (2603:10a6:20b:346::21) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.15; Mon, 14 Feb
 2022 13:14:03 +0000
Received: from AM5EUR03FT016.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:56:cafe::4b) by AM6PR0502CA0072.outlook.office365.com
 (2603:10a6:20b:56::49) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.18 via Frontend
 Transport; Mon, 14 Feb 2022 13:14:03 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT016.mail.protection.outlook.com (10.152.16.142) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4975.11 via Frontend Transport; Mon, 14 Feb 2022 13:14:02 +0000
Received: ("Tessian outbound 2877e54fe176:v113");
 Mon, 14 Feb 2022 13:14:02 +0000
Received: from af077a362695.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 49D34EA8-2974-41C6-AC10-F2F44D52D8EB.1; 
 Mon, 14 Feb 2022 13:13:56 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id af077a362695.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 14 Feb 2022 13:13:56 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by AM0PR08MB3233.eurprd08.prod.outlook.com (2603:10a6:208:60::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Mon, 14 Feb
 2022 13:13:54 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::aca7:79c4:fa65:dac6]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::aca7:79c4:fa65:dac6%5]) with mapi id 15.20.4975.019; Mon, 14 Feb 2022
 13:13:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fc5e7e16-8d97-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=olIGzV+p0Y8nNDif8TtwU+q9HZV6ntiPI7JyCWMm3no=;
 b=pVi+VRQKwvKDoJr1ARHxDNJcKmxCBYEhjVJkOrtp/bpUUUSP/J41WaAu2Y3/cG5cwaRKub6JDWiNORYS102qtyK+D6234RDbHvUznyyxYRMTQk7mrL7LA4X0/W6pCsd4WlY5zv54BnYHeHQmNAP4I0eNR7akxEEZICp9vO3X+aE=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: abb6e5cc35c59f7d
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=a8PmZoY2lh6q3FuV37ic5Evz2aepF7yuQF1eqgaJlp3ynCcSRYa9kJy1B/1HtllAK/B+xTECY4U299fcEIJwxv3XHfn9kT8NPlcxjNxkaADbP5Bn8Q9kyw4HRZ18zymu4mgG+dIKyPbeLCbp40CxpCB3U3jITNVYDo2MhkO0PaQaxeYnwGbuDZrnUmq6LztPMdV1TIa4S116wcaVB/aaeaBtS3MGIywcargxAIp7j6RBD8KF2U1mp5e1rcm1q/Rf/b4+RTq+jfZlfQToQfZhKA9AO/+H3NVbVghZMmzJ4Mc5zfWcX8g1SMZdtQe3Ou5+SNAsG+40UnVRyHu2oCrXbQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=olIGzV+p0Y8nNDif8TtwU+q9HZV6ntiPI7JyCWMm3no=;
 b=JeFe2khRLDKPmn04Ab6ZFerG6xWCvg1cBSRPR3+8Ybi1v2I3YgisKjNWO6+kgPOqbxsh1wHC4cjWpXnrqrfh87YdxjTzfG4895n3htnVHZd0fSkE+gtAhGSDRO7an7WwVzRUQW84H1CXDvDSj9UUz/hXOvIjRAM7bT6YGvgn9c7id4dWVq77JXNEg0v6KUqIIQbguOsGN2W5/QPf8M/cZSVHuvBSEgiBgCp5P26IIzBO/AYJJOB/avz+yaF5Yvx7tJKH9oMG2PQpdb/EgdrZL8ndoM3AZoclE0AU5ej0Z6YgGRUzXfCRRG4fzZF3FB6I3dSWzXPc09L/+L/9cA+Y8Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=olIGzV+p0Y8nNDif8TtwU+q9HZV6ntiPI7JyCWMm3no=;
 b=pVi+VRQKwvKDoJr1ARHxDNJcKmxCBYEhjVJkOrtp/bpUUUSP/J41WaAu2Y3/cG5cwaRKub6JDWiNORYS102qtyK+D6234RDbHvUznyyxYRMTQk7mrL7LA4X0/W6pCsd4WlY5zv54BnYHeHQmNAP4I0eNR7akxEEZICp9vO3X+aE=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Jan Beulich
	<JBeulich@suse.com>, =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v2 02/70] xen/sort: Switch to an extern inline
 implementation
Thread-Topic: [PATCH v2 02/70] xen/sort: Switch to an extern inline
 implementation
Thread-Index: AQHYIaGnBAePJgt7y0O7PyvIWQlKrKyTBimA
Date: Mon, 14 Feb 2022 13:13:54 +0000
Message-ID: <71997BED-096C-4168-AF40-D74C616D6A20@arm.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
 <20220214125127.17985-3-andrew.cooper3@citrix.com>
In-Reply-To: <20220214125127.17985-3-andrew.cooper3@citrix.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3693.60.0.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 71d127db-6a54-4f93-ca21-08d9efbbdeec
x-ms-traffictypediagnostic:
	AM0PR08MB3233:EE_|AM5EUR03FT016:EE_|AS8PR08MB6947:EE_
X-Microsoft-Antispam-PRVS:
	<AS8PR08MB6947020DC0FFC90C92E0C6EF9D339@AS8PR08MB6947.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:6430;OLM:6430;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 5dGWQaqB+FW+RXsQvTtkvuqPEtTBbgRX+VesBL5eGrMX6CDvzV6Lhfm5C6NsUeEE7Q3tPq/MpJiMb2AHwRc4Gi/QNnRG0jSmkPsCY0iV30J0WB6qLF4/a3A3umk/baG5DrA6ZVbs45uofHkg4PA7OqFzKWs2zCgXObfda1vW7Iw6aqAfu9CUzGBeDrewn8BN3OQAkQ7VIBXw8uitACJPY8RiuBbqpdVd1sKsWadMqUAS3+MasE9RXxmdXY9cbSpCHoF+kHK5OD69yfg79bGtkdzGVkARLclHnB0lIW9yLJBCmNUzBDSBsVahhCJ/VT5n2E1oR93/nkHzyd8niEyT+cosbk/73x5hL2n8t+PhHJnsJXaTJ//NJSme0tqvzuRU9XICTuGRAJAR1DGYF9k9Md++JIFfkJCyE3nt2z3TIwLoFoQpGVqXZ7qOJEm+7G/paq0+GOZvWnWuG70zru9NSpzCwIe2vxmjR1uatwc9xXjMpFI571tv48MQt+hyccPKOgCRKOWSphwcIr2PFj5EsMrisNpdd1fQhOpRUZBp5u3pYEeZQXb4/oqW7sXJ+mNoepA4vOFh0eJENSnObKPTFIGdu8Ed4/BDPebxHTxoizlJ9SQAZeqItEmfOTacTMDZXiHQtnY2EixQGiYI4tg4/H1e88MyG4qiJfNcT8gwIRv3i0E/RbwdwQFzVW9ZoPuqErpS7LaysHRfgWLAsMXJy9lPvXUbpYOyJrDex8KrG8/+1fF+Pbh+eSpNBBRJmMAY
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(316002)(64756008)(66446008)(66476007)(8676002)(66556008)(66946007)(76116006)(54906003)(4326008)(91956017)(2906002)(6916009)(122000001)(38100700002)(38070700005)(8936002)(5660300002)(6486002)(2616005)(26005)(186003)(6506007)(36756003)(508600001)(86362001)(53546011)(33656002)(83380400001)(6512007)(71200400001)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <A501DA476E530442B8BED8646D240675@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3233
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT016.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	fcaaf51f-75ef-43aa-9958-08d9efbbd9da
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	9hMbz7DxL+q8H9klrQhd6xWcI3Upm1F/M0gAQFr78EnIny0Ln8wjyoEwGcGvPyJMjb0T8t/ftX7j1QEaKhI4rkpWlxE7Khx/z9QF3FedvUZ7pmCtnAn9eDQ4ywrg31o4aW8undOVzan2VI7W+VT4mlxSghn58u8uxHnGxK1SqkPE043f0PnyO4ZWt6hcxFUKkYM5ZB6lPYDbxHi76Udr3Uoj1eHG6rVUO9tis4630vojVyDZTyeoFTZxV4RtYjzph3yaS7COXYfeSx4abDeJ9rVd/epVXwHzTvr8tEbwuzdgmsc8VhZCCgjKWLt2KZfwZcKGzSHD2qUX+Vgf2hesVu/aZcTXLOuWrjDKjKoGvG85X/MX3lkpjGti3SYG1SsOEYMqVgej0WSEFzkMg+6T4euQ/HeTit+RJd6HRqlOFZUf7UmoNyZAUe0I4UL5aPJhgHBbfO59ebYYUIuGHjd/l2R1QBXvUC0WuHBbHPatEiA5XoUPpSeAXm093I8eD0hRZRDDQUf/d2uhd92sqD1vwcYgWV0o09uNOiA5LaiNXCghnSalFHCT71KTLDodMavGgaGbB+mIIKlpncnYk9NdA2hjs7LFw+kJbglo6YES79FPLBnmnO2masCEBCsnQPFPpaNMkl8emkRMMskOFPscYiwpT5z5ISvvgOd29bXnMotY8VdiXrdkfhQQ3CS9eSwC
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(6486002)(53546011)(6506007)(36756003)(40460700003)(508600001)(356005)(81166007)(4326008)(6862004)(8676002)(70206006)(70586007)(86362001)(33656002)(54906003)(316002)(82310400004)(26005)(107886003)(2616005)(83380400001)(6512007)(186003)(5660300002)(8936002)(2906002)(336012)(47076005)(36860700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2022 13:14:02.6760
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 71d127db-6a54-4f93-ca21-08d9efbbdeec
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT016.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6947

SGkgQW5kcmV3LA0KDQo+IE9uIDE0IEZlYiAyMDIyLCBhdCAxMjo1MCwgQW5kcmV3IENvb3BlciA8
YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4gd3JvdGU6DQo+IA0KPiBUaGVyZSBhcmUgZXhhY3Rs
eSAzIGNhbGxlcnMgb2Ygc29ydCgpIGluIHRoZSBoeXBlcnZpc29yLiAgQ2FsbGJhY2tzIGluIGEg
dGlnaHQNCj4gbG9vcCBsaWtlIHRoaXMgYXJlIHByb2JsZW1hdGljIGZvciBwZXJmb3JtYW5jZSwg
ZXNwZWNpYWxseSB3aXRoIFNwZWN0cmUgdjINCj4gcHJvdGVjdGlvbnMsIHdoaWNoIGlzIHdoeSBl
eHRlcm4gaW5saW5lIGlzIHVzZWQgY29tbW9ubHkgYnkgbGlicmFyaWVzLg0KPiANCj4gQm90aCBB
Uk0gY2FsbGVycyBwYXNzIGluIE5VTEwgZm9yIHRoZSBzd2FwIGZ1bmN0aW9uLCBhbmQgd2hpbGUg
dGhpcyBtaWdodCBzZWVtDQo+IGxpa2UgYW4gYXR0cmFjdGl2ZSBvcHRpb24gYXQgZmlyc3QsIGl0
IGNhdXNlcyBnZW5lcmljX3N3YXAoKSB0byBiZSB1c2VkLCB3aGljaA0KPiBmb3JjZWQgYSBieXRl
LXdpc2UgY29weS4gIFByb3ZpZGUgcmVhbCBzd2FwIGZ1bmN0aW9ucyBzbyB0aGUgY29tcGlsZXIg
Y2FuDQo+IG9wdGltaXNlIHByb3Blcmx5LCB3aGljaCBpcyB2ZXJ5IGltcG9ydGFudCBmb3IgQVJN
IGRvd25zdHJlYW1zIHdoZXJlDQo+IG1pbGxpc2Vjb25kcyB1bnRpbCB0aGUgc3lzdGVtIGlzIHVw
IG1hdHRlcnMuDQo+IA0KPiBObyBmdW5jdGlvbmFsIGNoYW5nZS4NCj4gDQo+IFNpZ25lZC1vZmYt
Ynk6IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+DQo+IFJldmlld2Vk
LWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQoNCkp1c3Qgb25lIGNvbW1lbnQg
Zml4IGFmdGVyLCB3aXRoIGl0IGZpeGVkIGZvciB0aGUgYXJtIHBhcnQ6DQoNClJldmlld2VkLWJ5
OiBCZXJ0cmFuZCBNYXJxdWlzIDxiZXJ0cmFuZC5tYXJxdWlzQGFybS5jb20+DQoNCj4gLS0tDQo+
IENDOiBKYW4gQmV1bGljaCA8SkJldWxpY2hAc3VzZS5jb20+DQo+IENDOiBSb2dlciBQYXUgTW9u
bsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT4NCj4gQ0M6IFdlaSBMaXUgPHdsQHhlbi5vcmc+DQo+
IENDOiBTdGVmYW5vIFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+DQo+IENDOiBK
dWxpZW4gR3JhbGwgPGp1bGllbkB4ZW4ub3JnPg0KPiBDQzogVm9sb2R5bXlyIEJhYmNodWsgPFZv
bG9keW15cl9CYWJjaHVrQGVwYW0uY29tPg0KPiBDQzogQmVydHJhbmQgTWFycXVpcyA8YmVydHJh
bmQubWFycXVpc0Bhcm0uY29tPg0KPiANCj4gdjI6DQo+ICogQWRqdXN0IGNvbW1pdCBtZXNzYWdl
DQo+IC0tLQ0KPiB4ZW4vYXJjaC9hcm0vYm9vdGZkdC5jIHwgIDkgKysrKystDQo+IHhlbi9hcmNo
L2FybS9pby5jICAgICAgfCAgOSArKysrKy0NCj4geGVuL2luY2x1ZGUveGVuL3NvcnQuaCB8IDU1
ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0NCj4geGVuL2xpYi9zb3J0LmMgICAg
ICAgICB8IDgwICsrLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tDQo+IDQgZmlsZXMgY2hhbmdlZCwgNzIgaW5zZXJ0aW9ucygrKSwgODEgZGVsZXRpb25zKC0p
DQo+IA0KPiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL2Jvb3RmZHQuYyBiL3hlbi9hcmNoL2Fy
bS9ib290ZmR0LmMNCj4gaW5kZXggYWZhYTBlMjQ5YjcxLi5lMzE4ZWY5NjAzODYgMTAwNjQ0DQo+
IC0tLSBhL3hlbi9hcmNoL2FybS9ib290ZmR0LmMNCj4gKysrIGIveGVuL2FyY2gvYXJtL2Jvb3Rm
ZHQuYw0KPiBAQCAtNDQ4LDYgKzQ0OCwxMyBAQCBzdGF0aWMgaW50IF9faW5pdCBjbXBfbWVtb3J5
X25vZGUoY29uc3Qgdm9pZCAqa2V5LCBjb25zdCB2b2lkICplbGVtKQ0KPiAgICAgcmV0dXJuIDA7
DQo+IH0NCj4gDQo+ICtzdGF0aWMgdm9pZCBfX2luaXQgc3dhcF9tZW1vcnlfbm9kZSh2b2lkICpf
YSwgdm9pZCAqX2IsIHNpemVfdCBzaXplKQ0KPiArew0KPiArICAgIHN0cnVjdCBtZW1iYW5rICph
ID0gX2EsICpiID0gX2I7DQo+ICsNCj4gKyAgICBTV0FQKCphLCAqYik7DQo+ICt9DQo+ICsNCj4g
LyoqDQo+ICAqIGJvb3RfZmR0X2luZm8gLSBpbml0aWFsaXplIGJvb3RpbmZvIGZyb20gYSBEVEIN
Cj4gICogQGZkdDogZmxhdHRlbmVkIGRldmljZSB0cmVlIGJpbmFyeQ0KPiBAQCAtNDcyLDcgKzQ3
OSw3IEBAIHNpemVfdCBfX2luaXQgYm9vdF9mZHRfaW5mbyhjb25zdCB2b2lkICpmZHQsIHBhZGRy
X3QgcGFkZHIpDQo+ICAgICAgKiB0aGUgYmFua3Mgc29ydGVkIGluIGFzY2VuZGluZyBvcmRlci4g
U28gc29ydCB0aGVtIHRocm91Z2guDQo+ICAgICAgKi8NCj4gICAgIHNvcnQoYm9vdGluZm8ubWVt
LmJhbmssIGJvb3RpbmZvLm1lbS5ucl9iYW5rcywgc2l6ZW9mKHN0cnVjdCBtZW1iYW5rKSwNCj4g
LSAgICAgICAgIGNtcF9tZW1vcnlfbm9kZSwgTlVMTCk7DQo+ICsgICAgICAgICBjbXBfbWVtb3J5
X25vZGUsIHN3YXBfbWVtb3J5X25vZGUpOw0KPiANCj4gICAgIGVhcmx5X3ByaW50X2luZm8oKTsN
Cj4gDQo+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vaW8uYyBiL3hlbi9hcmNoL2FybS9pby5j
DQo+IGluZGV4IDcyOTI4N2UzN2M1OS4uMWEwNjZmOWFlNTAyIDEwMDY0NA0KPiAtLS0gYS94ZW4v
YXJjaC9hcm0vaW8uYw0KPiArKysgYi94ZW4vYXJjaC9hcm0vaW8uYw0KPiBAQCAtODAsNiArODAs
MTMgQEAgc3RhdGljIGludCBjbXBfbW1pb19oYW5kbGVyKGNvbnN0IHZvaWQgKmtleSwgY29uc3Qg
dm9pZCAqZWxlbSkNCj4gICAgIHJldHVybiAwOw0KPiB9DQo+IA0KPiArc3RhdGljIHZvaWQgc3dh
cF9tbWlvX2hhbmRsZXIodm9pZCAqX2EsIHZvaWQgKl9iLCBzaXplX3Qgc2l6ZSkNCj4gK3sNCj4g
KyAgICBzdHJ1Y3QgbW1pb19oYW5kbGVyICphID0gX2EsICpiID0gX2I7DQo+ICsNCj4gKyAgICBT
V0FQKCphLCAqYik7DQo+ICt9DQo+ICsNCj4gc3RhdGljIGNvbnN0IHN0cnVjdCBtbWlvX2hhbmRs
ZXIgKmZpbmRfbW1pb19oYW5kbGVyKHN0cnVjdCBkb21haW4gKmQsDQo+ICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwYWRkcl90IGdwYSkNCj4gew0K
PiBAQCAtMTcwLDcgKzE3Nyw3IEBAIHZvaWQgcmVnaXN0ZXJfbW1pb19oYW5kbGVyKHN0cnVjdCBk
b21haW4gKmQsDQo+IA0KPiAgICAgLyogU29ydCBtbWlvIGhhbmRsZXJzIGluIGFzY2VuZGluZyBv
cmRlciBiYXNlZCBvbiBiYXNlIGFkZHJlc3MgKi8NCj4gICAgIHNvcnQodm1taW8tPmhhbmRsZXJz
LCB2bW1pby0+bnVtX2VudHJpZXMsIHNpemVvZihzdHJ1Y3QgbW1pb19oYW5kbGVyKSwNCj4gLSAg
ICAgICAgIGNtcF9tbWlvX2hhbmRsZXIsIE5VTEwpOw0KPiArICAgICAgICAgY21wX21taW9faGFu
ZGxlciwgc3dhcF9tbWlvX2hhbmRsZXIpOw0KPiANCj4gICAgIHdyaXRlX3VubG9jaygmdm1taW8t
PmxvY2spOw0KPiB9DQo+IGRpZmYgLS1naXQgYS94ZW4vaW5jbHVkZS94ZW4vc29ydC5oIGIveGVu
L2luY2x1ZGUveGVuL3NvcnQuaA0KPiBpbmRleCBhNDAzNjUyOTQ4ZTcuLjAxNDc5ZWE0NDYwNiAx
MDA2NDQNCj4gLS0tIGEveGVuL2luY2x1ZGUveGVuL3NvcnQuaA0KPiArKysgYi94ZW4vaW5jbHVk
ZS94ZW4vc29ydC5oDQo+IEBAIC0zLDggKzMsNjEgQEANCj4gDQo+ICNpbmNsdWRlIDx4ZW4vdHlw
ZXMuaD4NCj4gDQo+ICsvKg0KPiArICogc29ydCAtIHNvcnQgYW4gYXJyYXkgb2YgZWxlbWVudHMN
Cj4gKyAqIEBiYXNlOiBwb2ludGVyIHRvIGRhdGEgdG8gc29ydA0KPiArICogQG51bTogbnVtYmVy
IG9mIGVsZW1lbnRzDQo+ICsgKiBAc2l6ZTogc2l6ZSBvZiBlYWNoIGVsZW1lbnQNCj4gKyAqIEBj
bXA6IHBvaW50ZXIgdG8gY29tcGFyaXNvbiBmdW5jdGlvbg0KPiArICogQHN3YXA6IHBvaW50ZXIg
dG8gc3dhcCBmdW5jdGlvbiBvciBOVUxMDQoNClRoZSBmdW5jdGlvbiBpcyBub3QgYWNjZXB0aW5n
IGFueW1vcmUgdG8gaGF2ZSBOVUxMIGFzIHBhcmFtZXRlci4NClRoZSBjb21tZW50IHNob3VsZCBi
ZSBmaXhlZCBoZXJlLg0KDQpCZXJ0cmFuZA0KDQo+ICsgKg0KPiArICogVGhpcyBmdW5jdGlvbiBk
b2VzIGEgaGVhcHNvcnQgb24gdGhlIGdpdmVuIGFycmF5LiBZb3UgbWF5IHByb3ZpZGUgYQ0KPiAr
ICogc3dhcCBmdW5jdGlvbiBvcHRpbWl6ZWQgdG8geW91ciBlbGVtZW50IHR5cGUuDQo+ICsgKg0K
PiArICogU29ydGluZyB0aW1lIGlzIE8obiBsb2cgbikgYm90aCBvbiBhdmVyYWdlIGFuZCB3b3Jz
dC1jYXNlLiBXaGlsZQ0KPiArICogcXNvcnQgaXMgYWJvdXQgMjAlIGZhc3RlciBvbiBhdmVyYWdl
LCBpdCBzdWZmZXJzIGZyb20gZXhwbG9pdGFibGUNCj4gKyAqIE8obipuKSB3b3JzdC1jYXNlIGJl
aGF2aW9yIGFuZCBleHRyYSBtZW1vcnkgcmVxdWlyZW1lbnRzIHRoYXQgbWFrZQ0KPiArICogaXQg
bGVzcyBzdWl0YWJsZSBmb3Iga2VybmVsIHVzZS4NCj4gKyAqLw0KPiArI2lmbmRlZiBTT1JUX0lN
UExFTUVOVEFUSU9ODQo+ICtleHRlcm4gZ251X2lubGluZQ0KPiArI2VuZGlmDQo+IHZvaWQgc29y
dCh2b2lkICpiYXNlLCBzaXplX3QgbnVtLCBzaXplX3Qgc2l6ZSwNCj4gICAgICAgICAgIGludCAo
KmNtcCkoY29uc3Qgdm9pZCAqLCBjb25zdCB2b2lkICopLA0KPiAtICAgICAgICAgIHZvaWQgKCpz
d2FwKSh2b2lkICosIHZvaWQgKiwgc2l6ZV90KSk7DQo+ICsgICAgICAgICAgdm9pZCAoKnN3YXAp
KHZvaWQgKiwgdm9pZCAqLCBzaXplX3QpKQ0KPiArew0KPiArICAgIC8qIHByZS1zY2FsZSBjb3Vu
dGVycyBmb3IgcGVyZm9ybWFuY2UgKi8NCj4gKyAgICBzaXplX3QgaSA9IChudW0gLyAyKSAqIHNp
emUsIG4gPSBudW0gKiBzaXplLCBjLCByOw0KPiArDQo+ICsgICAgLyogaGVhcGlmeSAqLw0KPiAr
ICAgIHdoaWxlICggaSA+IDAgKQ0KPiArICAgIHsNCj4gKyAgICAgICAgZm9yICggciA9IGkgLT0g
c2l6ZTsgciAqIDIgKyBzaXplIDwgbjsgciA9IGMgKQ0KPiArICAgICAgICB7DQo+ICsgICAgICAg
ICAgICBjID0gciAqIDIgKyBzaXplOw0KPiArICAgICAgICAgICAgaWYgKCAoYyA8IG4gLSBzaXpl
KSAmJiAoY21wKGJhc2UgKyBjLCBiYXNlICsgYyArIHNpemUpIDwgMCkgKQ0KPiArICAgICAgICAg
ICAgICAgIGMgKz0gc2l6ZTsNCj4gKyAgICAgICAgICAgIGlmICggY21wKGJhc2UgKyByLCBiYXNl
ICsgYykgPj0gMCApDQo+ICsgICAgICAgICAgICAgICAgYnJlYWs7DQo+ICsgICAgICAgICAgICBz
d2FwKGJhc2UgKyByLCBiYXNlICsgYywgc2l6ZSk7DQo+ICsgICAgICAgIH0NCj4gKyAgICB9DQo+
ICsNCj4gKyAgICAvKiBzb3J0ICovDQo+ICsgICAgZm9yICggaSA9IG47IGkgPiAwOyApDQo+ICsg
ICAgew0KPiArICAgICAgICBpIC09IHNpemU7DQo+ICsgICAgICAgIHN3YXAoYmFzZSwgYmFzZSAr
IGksIHNpemUpOw0KPiArICAgICAgICBmb3IgKCByID0gMDsgciAqIDIgKyBzaXplIDwgaTsgciA9
IGMgKQ0KPiArICAgICAgICB7DQo+ICsgICAgICAgICAgICBjID0gciAqIDIgKyBzaXplOw0KPiAr
ICAgICAgICAgICAgaWYgKCAoYyA8IGkgLSBzaXplKSAmJiAoY21wKGJhc2UgKyBjLCBiYXNlICsg
YyArIHNpemUpIDwgMCkgKQ0KPiArICAgICAgICAgICAgICAgIGMgKz0gc2l6ZTsNCj4gKyAgICAg
ICAgICAgIGlmICggY21wKGJhc2UgKyByLCBiYXNlICsgYykgPj0gMCApDQo+ICsgICAgICAgICAg
ICAgICAgYnJlYWs7DQo+ICsgICAgICAgICAgICBzd2FwKGJhc2UgKyByLCBiYXNlICsgYywgc2l6
ZSk7DQo+ICsgICAgICAgIH0NCj4gKyAgICB9DQo+ICt9DQo+IA0KPiAjZW5kaWYgLyogX19YRU5f
U09SVF9IX18gKi8NCj4gZGlmZiAtLWdpdCBhL3hlbi9saWIvc29ydC5jIGIveGVuL2xpYi9zb3J0
LmMNCj4gaW5kZXggMzVjZTBkN2FiZGVjLi5iN2U3OGNjMGU4ZDIgMTAwNjQ0DQo+IC0tLSBhL3hl
bi9saWIvc29ydC5jDQo+ICsrKyBiL3hlbi9saWIvc29ydC5jDQo+IEBAIC00LDgxICs0LDUgQEAN
Cj4gICogSmFuIDIzIDIwMDUgIE1hdHQgTWFja2FsbCA8bXBtQHNlbGVuaWMuY29tPg0KPiAgKi8N
Cj4gDQo+IC0jaW5jbHVkZSA8eGVuL3R5cGVzLmg+DQo+IC0NCj4gLXN0YXRpYyB2b2lkIHUzMl9z
d2FwKHZvaWQgKmEsIHZvaWQgKmIsIHNpemVfdCBzaXplKQ0KPiAtew0KPiAtICAgIHVpbnQzMl90
IHQgPSAqKHVpbnQzMl90ICopYTsNCj4gLQ0KPiAtICAgICoodWludDMyX3QgKilhID0gKih1aW50
MzJfdCAqKWI7DQo+IC0gICAgKih1aW50MzJfdCAqKWIgPSB0Ow0KPiAtfQ0KPiAtDQo+IC1zdGF0
aWMgdm9pZCBnZW5lcmljX3N3YXAodm9pZCAqYSwgdm9pZCAqYiwgc2l6ZV90IHNpemUpDQo+IC17
DQo+IC0gICAgY2hhciB0Ow0KPiAtDQo+IC0gICAgZG8gew0KPiAtICAgICAgICB0ID0gKihjaGFy
ICopYTsNCj4gLSAgICAgICAgKihjaGFyICopYSsrID0gKihjaGFyICopYjsNCj4gLSAgICAgICAg
KihjaGFyICopYisrID0gdDsNCj4gLSAgICB9IHdoaWxlICggLS1zaXplID4gMCApOw0KPiAtfQ0K
PiAtDQo+IC0vKg0KPiAtICogc29ydCAtIHNvcnQgYW4gYXJyYXkgb2YgZWxlbWVudHMNCj4gLSAq
IEBiYXNlOiBwb2ludGVyIHRvIGRhdGEgdG8gc29ydA0KPiAtICogQG51bTogbnVtYmVyIG9mIGVs
ZW1lbnRzDQo+IC0gKiBAc2l6ZTogc2l6ZSBvZiBlYWNoIGVsZW1lbnQNCj4gLSAqIEBjbXA6IHBv
aW50ZXIgdG8gY29tcGFyaXNvbiBmdW5jdGlvbg0KPiAtICogQHN3YXA6IHBvaW50ZXIgdG8gc3dh
cCBmdW5jdGlvbiBvciBOVUxMDQo+IC0gKg0KPiAtICogVGhpcyBmdW5jdGlvbiBkb2VzIGEgaGVh
cHNvcnQgb24gdGhlIGdpdmVuIGFycmF5LiBZb3UgbWF5IHByb3ZpZGUgYQ0KPiAtICogc3dhcCBm
dW5jdGlvbiBvcHRpbWl6ZWQgdG8geW91ciBlbGVtZW50IHR5cGUuDQo+IC0gKg0KPiAtICogU29y
dGluZyB0aW1lIGlzIE8obiBsb2cgbikgYm90aCBvbiBhdmVyYWdlIGFuZCB3b3JzdC1jYXNlLiBX
aGlsZQ0KPiAtICogcXNvcnQgaXMgYWJvdXQgMjAlIGZhc3RlciBvbiBhdmVyYWdlLCBpdCBzdWZm
ZXJzIGZyb20gZXhwbG9pdGFibGUNCj4gLSAqIE8obipuKSB3b3JzdC1jYXNlIGJlaGF2aW9yIGFu
ZCBleHRyYSBtZW1vcnkgcmVxdWlyZW1lbnRzIHRoYXQgbWFrZQ0KPiAtICogaXQgbGVzcyBzdWl0
YWJsZSBmb3Iga2VybmVsIHVzZS4NCj4gLSAqLw0KPiAtDQo+IC12b2lkIHNvcnQodm9pZCAqYmFz
ZSwgc2l6ZV90IG51bSwgc2l6ZV90IHNpemUsDQo+IC0gICAgICAgICAgaW50ICgqY21wKShjb25z
dCB2b2lkICosIGNvbnN0IHZvaWQgKiksDQo+IC0gICAgICAgICAgdm9pZCAoKnN3YXApKHZvaWQg
Kiwgdm9pZCAqLCBzaXplX3Qgc2l6ZSkpDQo+IC17DQo+IC0gICAgLyogcHJlLXNjYWxlIGNvdW50
ZXJzIGZvciBwZXJmb3JtYW5jZSAqLw0KPiAtICAgIHNpemVfdCBpID0gKG51bSAvIDIpICogc2l6
ZSwgbiA9IG51bSAqIHNpemUsIGMsIHI7DQo+IC0NCj4gLSAgICBpZiAoICFzd2FwICkNCj4gLSAg
ICAgICAgc3dhcCA9IChzaXplID09IDQgPyB1MzJfc3dhcCA6IGdlbmVyaWNfc3dhcCk7DQo+IC0N
Cj4gLSAgICAvKiBoZWFwaWZ5ICovDQo+IC0gICAgd2hpbGUgKCBpID4gMCApDQo+IC0gICAgew0K
PiAtICAgICAgICBmb3IgKCByID0gaSAtPSBzaXplOyByICogMiArIHNpemUgPCBuOyByID0gYyAp
DQo+IC0gICAgICAgIHsNCj4gLSAgICAgICAgICAgIGMgPSByICogMiArIHNpemU7DQo+IC0gICAg
ICAgICAgICBpZiAoIChjIDwgbiAtIHNpemUpICYmIChjbXAoYmFzZSArIGMsIGJhc2UgKyBjICsg
c2l6ZSkgPCAwKSApDQo+IC0gICAgICAgICAgICAgICAgYyArPSBzaXplOw0KPiAtICAgICAgICAg
ICAgaWYgKCBjbXAoYmFzZSArIHIsIGJhc2UgKyBjKSA+PSAwICkNCj4gLSAgICAgICAgICAgICAg
ICBicmVhazsNCj4gLSAgICAgICAgICAgIHN3YXAoYmFzZSArIHIsIGJhc2UgKyBjLCBzaXplKTsN
Cj4gLSAgICAgICAgfQ0KPiAtICAgIH0NCj4gLQ0KPiAtICAgIC8qIHNvcnQgKi8NCj4gLSAgICBm
b3IgKCBpID0gbjsgaSA+IDA7ICkNCj4gLSAgICB7DQo+IC0gICAgICAgIGkgLT0gc2l6ZTsNCj4g
LSAgICAgICAgc3dhcChiYXNlLCBiYXNlICsgaSwgc2l6ZSk7DQo+IC0gICAgICAgIGZvciAoIHIg
PSAwOyByICogMiArIHNpemUgPCBpOyByID0gYyApDQo+IC0gICAgICAgIHsNCj4gLSAgICAgICAg
ICAgIGMgPSByICogMiArIHNpemU7DQo+IC0gICAgICAgICAgICBpZiAoIChjIDwgaSAtIHNpemUp
ICYmIChjbXAoYmFzZSArIGMsIGJhc2UgKyBjICsgc2l6ZSkgPCAwKSApDQo+IC0gICAgICAgICAg
ICAgICAgYyArPSBzaXplOw0KPiAtICAgICAgICAgICAgaWYgKCBjbXAoYmFzZSArIHIsIGJhc2Ug
KyBjKSA+PSAwICkNCj4gLSAgICAgICAgICAgICAgICBicmVhazsNCj4gLSAgICAgICAgICAgIHN3
YXAoYmFzZSArIHIsIGJhc2UgKyBjLCBzaXplKTsNCj4gLSAgICAgICAgfQ0KPiAtICAgIH0NCj4g
LX0NCj4gKyNkZWZpbmUgU09SVF9JTVBMRU1FTlRBVElPTg0KPiArI2luY2x1ZGUgPHhlbi9zb3J0
Lmg+DQo+IC0tIA0KPiAyLjExLjANCj4gDQoNCg==


From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:14:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:14:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271898.466621 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbBU-00008A-7m; Mon, 14 Feb 2022 13:14:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271898.466621; Mon, 14 Feb 2022 13:14:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbBU-00007y-4L; Mon, 14 Feb 2022 13:14:28 +0000
Received: by outflank-mailman (input) for mailman id 271898;
 Mon, 14 Feb 2022 13:14:27 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KkXt=S5=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nJbBT-0006t9-2m
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:14:27 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 082cdb82-8d98-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 14:14:25 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2054.outbound.protection.outlook.com [104.47.14.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-13-bTiu4oxGPgukD7KFJgJSwg-1; Mon, 14 Feb 2022 14:14:25 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3406.eurprd04.prod.outlook.com (2603:10a6:803:c::27)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.15; Mon, 14 Feb
 2022 13:14:24 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4975.015; Mon, 14 Feb 2022
 13:14:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 082cdb82-8d98-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644844466;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=mSNiNRPDAp4FbHjWk5BNk2LUmOvr0nLZzbpMWULfGLw=;
	b=gaW7YzwwCAGN7YVcHue4UfcoRHVLvQYc45kFocSgr1dgOYC2boNPdbx/a4qguNqYEIIGiU
	IB5DU6Wp9vNRx7Ns/FjwaNr7XnVHRZktgnaFrcSOm6EVpWSbRBqB2YaKlAdec6e4BUpYy4
	ZTPjFLH3FjBXs2rox/TqO1a6iKcvmjI=
X-MC-Unique: bTiu4oxGPgukD7KFJgJSwg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=UjoPKIdxdU4wuyPMO4kEKye09SD9iXgaoGtqTahWQ4TKKo27+9EluxNPMvvVSdH06vvlA3Y/ry2LLuze4NqwOVBe9lQxZbUiBULqUhjJNIizR13J9N4m/SejVkGtHO/0NDjevJz1kObMpTkoKRlW2QWMNj3SQ7dog03YOx2nNsjTA+ACbBDmfNOtzTicWC/5el0cTc149PXVYCsWWNiR+3DEsiMCcXBom5syDY0dA5cwmBFYlpCo/TOJACaMTw8YOG2QEdzEgjuBDZ1gnHQLNZZoI/yXkhGd21b++nhNb90+7P0+NwI9svyQFmM1GGiwAEBzQSHn3rBbiCCg9aYfTA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=mSNiNRPDAp4FbHjWk5BNk2LUmOvr0nLZzbpMWULfGLw=;
 b=RSYE58E2ag+OB9FnTf6JwU7kwIOt7ykUS2g889Itxea3UvkkXFeiPvYIztv9faDIJsiUDLuqQzBE4HTVJetR2apmLQqsgzF/pRyMjc1x3HOqIB/3JFYd6o0d1qUPkZ6+hm3N7Y59714AC+ruP6/kBA46MwC1idGRLOnIAjgAB0QzNfxaPxVt3XPAZmzF3cLhiTiMem+g5VgE2eDCatKyfsO0grNkn6Ic41397roNTlhIh9sJfXuvSiVPRJFXn3B1/3SVQt46octu8FAMNoBp6OojSeG4Q60K/buoBkQlH0L8E2v1hCRBik9XDCGkkiqbmYxMnFPotuD/4evlJ9cxFw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <adccce7c-d697-20a4-ce23-5c6571e7290d@suse.com>
Date: Mon, 14 Feb 2022 14:14:22 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH v2 7/7] x86/vpmu: Harden indirect branches
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20220214125632.24563-1-andrew.cooper3@citrix.com>
 <20220214125632.24563-8-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220214125632.24563-8-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0277.eurprd06.prod.outlook.com
 (2603:10a6:20b:45a::33) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 683565f8-52b4-4e21-cc6d-08d9efbbebad
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3406:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB3406B430AA0B7BA189A4A392B3339@VI1PR0402MB3406.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1247;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	jKEKiLz49MAkh8H9tyCMVzYEDN3q7YgQVDiPT3k4wP9dbkb5aAGX788gwf9t6xC+7is/RRTxfINuIFQZ50c9jLpBjGaEM2eWqm/s+D62V1YhgK9EE/TeL2TYwc0CbVtHFarGYQsF3te7zznuN1XzQB4+M4tPLfM3gttQFBqcIj9EiqotYiS61clcKAJAGSoamqc1x4y4xTGAq7mNgtgk/brpfCZHePQpRWI6nwGYfHHuM+Z6er7AXbejdXDVIAnDWNP2ALv14MobpOM51kzWfJldirPJSBn/UUcta+4riafBzBCb5Q1eHL61SIMbyBN7AKC11rI0qYZGf3wDUuq/x8/gfog0Ky/roclmdROiVYeiVg9cOhMo+tBLUuNN87Pd3BXAVwwqd+ZJzQoN2/EjDtnKckDzpx7Vvp1Gl9px3Y1TG4iz+GIJNf/NJu1Xwyoxks2OZgKo66kQjS5TLEl4TTlbn+SvuzeZ1QBQapiaNv+FZDBj9HVy7MOGUhWMT7WqX2Pt6I9ib0WGTCw4mCXw7bo9foYzH7xp4UQduAYOGurLB/c1V6dJBgTEi+i4PCqbxtd2WI9IM4NNVZRz3MFnrHcDo/l0gLiyNdkI+g5KfOVn/vegGg3NMua3P7FJBSFCCMYG+VRBAhqRHwerWLxtBdb7RVTQel2Aq/M4fHmFrQhhIvkBoyibg5DUGGNxJbHOTfNJ0SBighyfp9vGvsp7Mz8ACLgDdDs2z10mgyN6FGR+5VEPWKqQ5Ux9PaJ5Icq0
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6506007)(5660300002)(53546011)(508600001)(36756003)(6916009)(316002)(38100700002)(54906003)(31686004)(31696002)(66476007)(66556008)(26005)(186003)(2616005)(6486002)(8936002)(8676002)(66946007)(2906002)(4744005)(6512007)(86362001)(4326008)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NFBBN3hlc3NENlVpQS9PeGExdGxpT3lXOEFlVGM0aWNvenBreWlsQjU0eTZa?=
 =?utf-8?B?UzdQUjJZWW51QWFwQmJUUE5ucUVsNW53ZXFVeXlCQ2R3WW1UWVVodnA3TEVE?=
 =?utf-8?B?WEZ6LzI4RjVGQjA4amU0MjREYjlPUTNtR3ZnT3djY2l0aWRMeWVRYVdKc3JM?=
 =?utf-8?B?eVBYeTBHSmVwZTRMaVpodHFaOWJIdWRmVjhIRmF6TktzQ2hYRTl1WVE5WW5m?=
 =?utf-8?B?OEFZRlZqek1EcU9ZeGhKbC9Cb2NuU08rb3JyeXNNZUhZT21wd1JyNEJLVG4z?=
 =?utf-8?B?VVkxS2ZtQWN0eG1vQmt5YUFNaEIzMjVWd1Aycy92WCtpYWpCZWJRVWJVV0FC?=
 =?utf-8?B?UW4rZGo4SVhNcXlwOTlDWHpNUERpVjlJZ2puRGJ5eDl5dHJPUElkL1VIQ0sw?=
 =?utf-8?B?N2c0dzNuTW14OUJSWGpFWWdaSnBwZzQ1bG1FTzRFeXVlR3JXTHhNR1VJWmI0?=
 =?utf-8?B?WEw3Rk9pOVhBM21hbVQ4Qko3WGF1UkhlV2hYbWpsKytRQ2ZaNWliMTVJRko4?=
 =?utf-8?B?RFlJTHZsNGNMNGc2ak9VSjNzUmgvMnVPaWRTNGxKK0NJYUxyRDBiOHY3S2wr?=
 =?utf-8?B?T1MxaXBkSXZLd291SGx2cGpQZmIyUnZnV3RBM1VsT2xIaVgwSndET0lMN3VB?=
 =?utf-8?B?Q2VXTE9tTk9UQ1EyT3VJZCtETjdhUG5XMHhlKy9FZWxCZHJQUnlFNktxN3ZI?=
 =?utf-8?B?eGxHOHhwMmpDQ3k3QS9XdWVqUCsyRzlnd0FjT3BGSHMzZnFzMVZIM1NteTZS?=
 =?utf-8?B?dEZqZUNvMVczNkY5NnVSeW0yUlp5L0xOTXBKaVczQVRFVWwzTHF3STlwTkJ1?=
 =?utf-8?B?U3Qvck1zYXVtdjRXdFQyMHVqSmd2TngrMi9WR1hnK2FpSnZEU1BCSHByRHRO?=
 =?utf-8?B?a0VjSHdGczJkcDFvUndxcTh2d1hpUU5PT2xLVVpZK1lBWThzZ0JVcDk5WnVs?=
 =?utf-8?B?R2o4YU84YlJHTVZPbnFuNkN1WmJZTGlGR2FxQzNPWVV3c0ZCb0ZRNk9JUVJ4?=
 =?utf-8?B?QWY2NGNGa1dRcnRSSEltbTJnOTQ3S0llZjQ4Mmw3OFMyb2tyRTlmNHJmSVVo?=
 =?utf-8?B?dVNFWDJScjNRVHhxTGpsMlo5cFpLejkrcWJudE95LzZvQnlSZkxaamc5NmVo?=
 =?utf-8?B?UEtMcnFYeWk3RnFVRGFFakNDeDd0UmlnWmlwTE5qZzFsNW9zT3p4ZUdjVVlL?=
 =?utf-8?B?MDdLTkdmb0lYYklHekZLeE1NS2QyK2xIU0JCbzRMOGJZUnR3aGlYbkN3aTdS?=
 =?utf-8?B?ek9YOTNPVGVlNFVmNVRoQzZBZzNVdGVFSVlvUnJkWlUvbERiV1EzaWw1cEpl?=
 =?utf-8?B?T3B6b2wrSjhNS2xmREJ0akFDOHN0bTVWZEFyd1M3UzJ3c0FUbkcwRFUwUVhr?=
 =?utf-8?B?ZE5GMEZTc2dCT0VWdXNqZE9aR1BiVjFhMlVKdXAvSmJyWlBsbEMyMkYveitl?=
 =?utf-8?B?YmRaQ0ZaT3JkRzB4NjVCdEV4WGUxZ29CWXQ2LzEwL3pTUi9JTHF0L054OTc4?=
 =?utf-8?B?dFQ1ME5HQ0U2YkpzbnYxUGo2b2lZVWNvWkI0UTZ0enJCa2NtOHAza1BzcDhT?=
 =?utf-8?B?d1dKYlg3a3ZxRkhpWEs1cEM1VDhoOVA0elZCdGlHbHBkb3VzSGxEQjlQNVdW?=
 =?utf-8?B?SlM4UFBndFhvNXJXaDdUQVNIZ3dSOGV2N1FPck81NnMwb1J1OHpLWXZTUTdZ?=
 =?utf-8?B?OXdBVEZ4Y0NUS3dSbnpuelB3SHhIN2NhVHhyY2x5OElzcEdvWmpPR3ZMZnV0?=
 =?utf-8?B?R09mY1JRaFVYSTV1Q2JPTmhoVXhqL3JlcTdzbjlLdUtsb0RpdFgrZ3FyY1hm?=
 =?utf-8?B?Tk83T3F5TXVuYlVqU1JYL3VWNm52Q2FhUlJSVzE5NllldFpqWUxmRlN2V1Fs?=
 =?utf-8?B?ajFQVGZBNDZndEYrUktRWE1WaWI3dUxHcXJacGtCQk83QXQzVGtPTnZFaEgw?=
 =?utf-8?B?ZmVyMWtXMkJNZGRyVHQvM25iYlkrS0k5ZDBLdXpIKzZ4dW8xakhnZXBrSHMr?=
 =?utf-8?B?Z1hoK2xsQnBiYllSclEwRS80bEU4MC9qWVEyMnJhTXVwc0h6T1h4NTZzRkdt?=
 =?utf-8?B?TzI0TzBXMXZQcDJRanFZRnBvZ0tYZWFUYzdEUkxhS1lsZzVkLzNBdW9nb3BX?=
 =?utf-8?B?N3lLTlUzeFd4NjEwenpoSkV5WVVSNkYvdFBUblo0aHBvUVBJdU8rTlFnMk5U?=
 =?utf-8?Q?6SNoj3v4aE1IGG6Xgs7iPts=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 683565f8-52b4-4e21-cc6d-08d9efbbebad
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2022 13:14:24.3469
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /MQmX1et3rxOtmrtOPGgcOwi434ohN7OVZWU2OVwWGlKHmyoCC8eMLFuPplHfvpI6vnyNsXXMmDuWILcEtoAeQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3406

On 14.02.2022 13:56, Andrew Cooper wrote:
> As all function pointer calls are resoved to direct calls on boot, clobber the
> endbr64 instructions too to make life harder for an attacker which has managed
> to hijack a function pointer.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:16:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:16:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271910.466632 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbD8-00012x-Kp; Mon, 14 Feb 2022 13:16:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271910.466632; Mon, 14 Feb 2022 13:16:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbD8-00012q-Fs; Mon, 14 Feb 2022 13:16:10 +0000
Received: by outflank-mailman (input) for mailman id 271910;
 Mon, 14 Feb 2022 13:16:09 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJb3i-0008IH-HG
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:06:26 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e951b73e-8d96-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 14:06:25 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e951b73e-8d96-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644843985;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=VDTB6pLtQwW15sO+arBQSOZrTwVU7NXtXfZ8CtNHRX8=;
  b=TxEYX1uObWL0FyPR/G3bKayqc59BmOSB3GcK4mgFj5OMBLH8F+fw1VDX
   mlm7JduY02jKHYybbZnAHpRFgjsc5/n+F04VwaFKgnfwx68rhp4oVIMXv
   dXhqSOU/cjQYiSIuU8LyX3OULLhehUBY3G0F9eH/0WGmCYlJXK/TdnluN
   I=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: ++CeWZB0+BNTzNsApzkSIN78zTJBzVpqspVucKLtkx8Nn8wwYLwMhAXdK9i0S/kjjiWTjQ4rln
 TgdYMFWA6r9PnvfS1D42xvK0RcDrNy7Yf/bVaP+EUz3ibL08gZj9vj9xa4oCYyfuxPIotZxCJ9
 4M4cI3RJpH05I/RgtGYkm7V9vhp6keGY1G9GlTv/5f62AA9D6kJDFAB4m/KBjUcG9ZlaTMjOrH
 CLcy7lkD2FMS04sboHJ1XcXBTLUcfQug5HPZ2rhI40WRL/siGeMeP1lZEyq/2B9AdNHnwnU+FU
 dvlXFI1Z2pI6EJt1fOKOgGfi
X-SBRS: 5.1
X-MesageID: 63592704
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:HunMRa1ROykz2ogr6vbD5ex2kn2cJEfYwER7XKvMYLTBsI5bpzAOx
 mJNWziCO6rbMGPyct11b4q39E9UuJXdn4BrG1RupC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkS5PE3oHJ9RGQ74nRLlbHILOCanAZqTNMEn9700o5wrJh2+aEvPDia++zk
 YKqyyHgEAfNNw5cagr4PIra9XuDFNyr0N8plgRWicJj5TcypFFMZH4rHomjLmOQf2VhNrXSq
 9Avbl2O1jixEx8FUrtJm1tgG6EAaua60QOm0hK6V0U+6/TrS+NbPqsTbZIhhUlrZzqhzulP1
 vVGtKaKVVkGN4/wnNhGdiMFKnQrVUFG0OevzXmXtMWSywvNcmf2wuUoB0YzVWEa0r8pWycUr
 6VecW1TKEDY7w616OvTpu1Er8IvNsT0eqgYvWlt12rxBvc6W5HTBa7N4Le02R9u3Z0fR6mGO
 6L1bxI1UDfbR0FGB2s8J5Y/o+Kxnl75Sh1x/Qf9Sa0fvDGIkV0ZPKLWGMXRUsyHQ4NShEnwj
 kDs8nn9AxoaHMeC0jfD+XWp7sffkCW+VI8MGbmQ8v9xnEbV1mEVEAcRV1awvb++kEHWZj5EA
 xVKoGx09/F0rRH1CImmN/GlnJKalk8lZcRwGOwA0h3T5aP23wKlXU0+EwcUPbTKq/QKbTAt0
 1aImfbgCjpurKCZRBqhy1uEkd+hEXNLdDFfPEfoWSNAuoC++99r0nojW/4+SPbdszHjJd3nL
 9lmRgAajq5bs8ME3r7TEbvv02P1/cihouLYC2zqsoOZAuFROdTNi2+AswGzARN8wGGxFAfpg
 ZT8s5LChN3i9LnU/MB3fM0DHauy+9GOOyDGjFhkEvEJrmrxpyHzLd0NuGglfi+F1/ronhezP
 ifuVf55vscPbBNGk4crC25ONyja5fe5Tom0PhwlRtFPfoJwZGe6ENJGPiatM5TWuBF0y8kXY
 M7DGe71VCpyIfk3nVKeGrZGuZd2l39W+I8mbc2ip/hR+eHFPyD9pHZsGAbmU93VG4va/FSLo
 44HbZPiJtc2eLSWXxQ7OLU7dTgiRUXXz7irwyCOXuLccAdgBk87DPrdneEod4B/xvwHnebU5
 HCtHERfzQOn13HALAyLbFFlaa/uAskj/S5qY3R0MAb6wWUnbKau8LwbK8k9c444+bEx1vVzV
 fQEJZmNW6wdVjTd9j0BRpDht4g+Jg+zjAeDMnP9MjgydpJtXSLT/drgcle9/SUCFHPv58A/v
 6ehxkXQRp9aH1ZuC8PfafSOyVKtvCdCxLIuDhWQetQKIRfi6olnLSD1n8QbGcBUJEWR3Cae2
 iaXHQwc+bvHrbgq/YSbnquDtYqoTbdzRxIIA2nB4L+qHiDG5W7/k5RYWeOFcD2BBmP5/KKuO
 bdcw/3maaBVmV9Lt8x3EqpxzLJ47Nzq/ucIwgNhFXTNTlKqFrI/fSXWgZgR7vVAlu1DpA+7e
 kOT4d0La7yGNfTsHEMVOAd4PP+I0usZm2WK4Pk4SKkgCPSbIFZTvZ1uAiSx
IronPort-HdrOrdr: A9a23:nbn1Oa4idQG2A6NCOAPXwMrXdLJyesId70hD6qhwISY6TiX4rb
 HWoB1173/JYVoqNE3I3OrwXZVoIkmsk6Kdg7NhXotKNTOO0ADDQb2Kr7GSpwEIcxeOkdK1vp
 0AT0ERMrLN5CBB/KTH3DU=
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="63592704"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>
Subject: [PATCH v2 69/70] x86/efi: Disable CET-IBT around Runtime Services calls
Date: Mon, 14 Feb 2022 12:51:26 +0000
Message-ID: <20220214125127.17985-70-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

UEFI Runtime services, at the time of writing, aren't CET-IBT compatible.
Work is ongoing to address this. In the meantime, unconditionally disable IBT.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>

https://bugzilla.tianocore.org/show_bug.cgi?id=3726 is the upstream tracking
ticket.

v2:
 * Rewrite to be an unconditional disable.
---
 xen/common/efi/runtime.c | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/xen/common/efi/runtime.c b/xen/common/efi/runtime.c
index e3ce85d118e4..13b0975866e3 100644
--- a/xen/common/efi/runtime.c
+++ b/xen/common/efi/runtime.c
@@ -21,6 +21,7 @@ struct efi_rs_state {
   * don't strictly need that.
   */
  unsigned long __aligned(32) cr3;
+    unsigned long msr_s_cet;
 #endif
 };
 
@@ -113,6 +114,19 @@ struct efi_rs_state efi_rs_enter(void)
 
     switch_cr3_cr4(mfn_to_maddr(efi_l4_mfn), read_cr4());
 
+    /*
+     * At the time of writing (2022), no UEFI firwmare is CET-IBT compatible.
+     * Work is under way to remedy this.
+     *
+     * Stash MSR_S_CET and clobber ENDBR_EN.  This is necessary because
+     * SHSTK_EN isn't configured until very late on the BSP.
+     */
+    if ( cpu_has_xen_ibt )
+    {
+        rdmsrl(MSR_S_CET, state.msr_s_cet);
+        wrmsrl(MSR_S_CET, state.msr_s_cet & ~CET_ENDBR_EN);
+    }
+
     return state;
 }
 
@@ -122,6 +136,10 @@ void efi_rs_leave(struct efi_rs_state *state)
 
     if ( !state->cr3 )
         return;
+
+    if ( state->msr_s_cet )
+        wrmsrl(MSR_S_CET, state->msr_s_cet);
+
     switch_cr3_cr4(state->cr3, read_cr4());
     if ( is_pv_vcpu(curr) && !is_idle_vcpu(curr) )
     {
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:16:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:16:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271911.466643 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbDB-0001JU-RP; Mon, 14 Feb 2022 13:16:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271911.466643; Mon, 14 Feb 2022 13:16:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbDB-0001JL-NZ; Mon, 14 Feb 2022 13:16:13 +0000
Received: by outflank-mailman (input) for mailman id 271911;
 Mon, 14 Feb 2022 13:16:12 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJb4l-0008IH-IZ
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:07:31 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 10903f77-8d97-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 14:07:30 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 10903f77-8d97-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644844050;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=qS6HhUKN86A8O5F/mJjxVhOAaZfp/FzJTL8mzLuXTEg=;
  b=Kjf/OXFWAfIAFA9XcKlg8eZUEOSiyWZYH/GtFkREA9K+HCbi5ilmhxx7
   7LvPauUBCcuE+cUHpi2x+UQBIknYIzksqVnc7HIJePU7L4SicftK2JHWL
   xxj+RvTZm7bmrDZgyje9aEonWVnVVV48YF+4+6HLdp1Xgo1bAoKYImgLN
   w=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: uSSGRCrGGWROjzd7XrtaTrhsfnXs5nikIijwlK+Rl6ZwFVbBzHkKT0hPoClM69p6DuRg4bGxbf
 iNePTXbFksnnZluH0HTDnKUeNKIJWBfbwxGojI11xQq4+Tl5jWQBWPyYsMQLQut2OIBER6hQXt
 ljKpl/643UWhWqu5wLwdbUsGJnB3ls2wbQ/5WSDaJZrCR7J3NbhNA5COIJljRjf/0f6bLfbo7D
 cM1bmQRRIKC/cAdfdWkjcsyYp8p4DOhR1r6MLSNn4NvB/VWvJtOs3D0sYSoZvt46EJ6GQ6ATKU
 At812VL6d/xvLUI/onkGRt0Q
X-SBRS: 5.1
X-MesageID: 64554515
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:X538yay202sG4MOGOyR6t+cvwSrEfRIJ4+MujC+fZmUNrF6WrkVVm
 zAXDWqAPP+JZGXze9txbN6xpEkFu8eGzNAyQFFt/iAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAhLeNYYH1500g7wbdl2tcAbeWRWGthh
 /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL
 wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt9NBk
 tdMtbGLdRcwY7f02880eERySD4raMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr
 6ZBbmlQMFbT3Ipaw5riIgVoru0lINPmI8U0vXZ4wCuCJf0nXYrCU+PB4towMDIY2JwTQKqDP
 pdxhTxHVQmHag8MZGguUqkwrb+DhUT/LWNgpwfAzUYwyzeKl1EguFT3C/LFd9rPSchLk0Kwo
 mPd43+/EhwcLMaYyzeO7jSrnOCnoM/gcNtMTvvirKcs2QDNgDxIYPELabelifqJ0Ey/W/9kF
 1wNpzAW7oMb3xGBFcaoCnVUv0W4lhIbXtNRFcgz5weM1rfY7m6lO4QUctJSQId47ZFrHFTGw
 nfMxoq0XmI37NV5XFrAru/8kN+kBcQCwYbujwcgRBBN3dTsqZpbYvnnHoc6S/7dYjEY9FjNL
 9G2QMoW2u97YS0jjfzTEbX7b9WE/Mahc+LNzl+LNl9JFysgDGJfW6Sm6ELA8dFLJ5uDQ1+Ks
 RAswpbCsL9eXczQzHXWGo3h+Y1FAN7fblXhbaNHRcF9p1xBBVb/FWyv3N2ODBgwaZtVEdMYS
 ETSpRlQ9Pdu0IiCNsdKj3aKI51yl8DITI29PtiNN4YmSsUhJWevoXA1DWbNjj+FraTZufxmU
 XttWZ33Vihy5GUO5GfeetrxJpd1mnFglTuLH8iTItbO+eP2WUN5gIwtaDOmBt3VJovd+Fi9H
 w93O5TYxhNBfvf5ZyWLo4cfIUpTdSowBIzsqtwRfemGe1I0FGYkAv7X4LUgZ406wPgFyraWp
 imwCh1C1V7ypXzbMgHWOHptX6ziAMRkpnUhMC1yYVvxgyo/YZyi5bs0focseeV17/RqyPN5F
 qFXe8iJDvlVZC7A/jARMcv0oIB4LUz5jgOSJSu1JjM4esc4FQDO/9bleCrp9TUPUXXr5Zdv/
 eX421qCE5QZRglkAMLHU96Vzgu87SoHheZ/f0rUOd0PKk/ix5dndn7qhfgtLsBSdRianmmG1
 xybCAszrPXWp9Nn68HAgK2Jotv7E+Z6GUYGTWDX4azvaHvf92unh4RBTPyJbXbWU2atoPeuY
 uBczvfdNvwbnQkV79ogQugzla9utcHyo7J6zxh/GCSZZlumPbpsP32a0JQdraZK3LJY5VO7V
 0/nFgO24llV1BcJyGIsGTc=
IronPort-HdrOrdr: A9a23:FzHS1aFzFpbBqtNipLqE6seALOsnbusQ8zAXP0AYc3Jom62j5r
 mTdZsgtSMc5Ax8ZJhko6HkBEDiewK7yXcW2/hzAV7KZmCP0wHEEGgh1/qH/9SJIVyYygc378
 ZdmsZFZ+EYdWIK7/rH3A==
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="64554515"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v2 15/70] xen: CFI hardening for call_rcu()
Date: Mon, 14 Feb 2022 12:50:32 +0000
Message-ID: <20220214125127.17985-16-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

Control Flow Integrity schemes use toolchain and optionally hardware support
to help protect against call/jump/return oriented programming attacks.

Use cf_check to annotate function pointer targets for the toolchain.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
 xen/arch/x86/hvm/mtrr.c       | 2 +-
 xen/arch/x86/hvm/vmsi.c       | 2 +-
 xen/arch/x86/mm/mem_sharing.c | 2 +-
 xen/arch/x86/percpu.c         | 2 +-
 xen/common/domain.c           | 4 ++--
 xen/common/radix-tree.c       | 2 +-
 xen/common/rcupdate.c         | 2 +-
 xen/common/sched/core.c       | 2 +-
 xen/xsm/flask/avc.c           | 2 +-
 9 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/xen/arch/x86/hvm/mtrr.c b/xen/arch/x86/hvm/mtrr.c
index b3ef1bf54133..42f3d8319296 100644
--- a/xen/arch/x86/hvm/mtrr.c
+++ b/xen/arch/x86/hvm/mtrr.c
@@ -586,7 +586,7 @@ int hvm_get_mem_pinned_cacheattr(struct domain *d, gfn_t gfn,
     return rc;
 }
 
-static void free_pinned_cacheattr_entry(struct rcu_head *rcu)
+static void cf_check free_pinned_cacheattr_entry(struct rcu_head *rcu)
 {
     xfree(container_of(rcu, struct hvm_mem_pinned_cacheattr_range, rcu));
 }
diff --git a/xen/arch/x86/hvm/vmsi.c b/xen/arch/x86/hvm/vmsi.c
index 13e2a190b439..2889575a2035 100644
--- a/xen/arch/x86/hvm/vmsi.c
+++ b/xen/arch/x86/hvm/vmsi.c
@@ -441,7 +441,7 @@ static void add_msixtbl_entry(struct domain *d,
     list_add_rcu(&entry->list, &d->arch.hvm.msixtbl_list);
 }
 
-static void free_msixtbl_entry(struct rcu_head *rcu)
+static void cf_check free_msixtbl_entry(struct rcu_head *rcu)
 {
     struct msixtbl_entry *entry;
 
diff --git a/xen/arch/x86/mm/mem_sharing.c b/xen/arch/x86/mm/mem_sharing.c
index 74d2869c0e6f..15e6a7ed814b 100644
--- a/xen/arch/x86/mm/mem_sharing.c
+++ b/xen/arch/x86/mm/mem_sharing.c
@@ -75,7 +75,7 @@ static DEFINE_SPINLOCK(shr_audit_lock);
 static DEFINE_RCU_READ_LOCK(shr_audit_read_lock);
 
 /* RCU delayed free of audit list entry */
-static void _free_pg_shared_info(struct rcu_head *head)
+static void cf_check _free_pg_shared_info(struct rcu_head *head)
 {
     xfree(container_of(head, struct page_sharing_info, rcu_head));
 }
diff --git a/xen/arch/x86/percpu.c b/xen/arch/x86/percpu.c
index eb3ba7bc8874..46460689b73d 100644
--- a/xen/arch/x86/percpu.c
+++ b/xen/arch/x86/percpu.c
@@ -45,7 +45,7 @@ struct free_info {
 };
 static DEFINE_PER_CPU(struct free_info, free_info);
 
-static void _free_percpu_area(struct rcu_head *head)
+static void cf_check _free_percpu_area(struct rcu_head *head)
 {
     struct free_info *info = container_of(head, struct free_info, rcu);
     unsigned int cpu = info->cpu;
diff --git a/xen/common/domain.c b/xen/common/domain.c
index 5df0d167537b..32ec156e6f6a 100644
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -365,7 +365,7 @@ static int __init cf_check parse_extra_guest_irqs(const char *s)
 }
 custom_param("extra_guest_irqs", parse_extra_guest_irqs);
 
-static void _free_pirq_struct(struct rcu_head *head)
+static void cf_check _free_pirq_struct(struct rcu_head *head)
 {
     xfree(container_of(head, struct pirq, rcu_head));
 }
@@ -1108,7 +1108,7 @@ void vcpu_end_shutdown_deferral(struct vcpu *v)
 }
 
 /* Complete domain destroy after RCU readers are not holding old references. */
-static void complete_domain_destroy(struct rcu_head *head)
+static void cf_check complete_domain_destroy(struct rcu_head *head)
 {
     struct domain *d = container_of(head, struct domain, rcu);
     struct vcpu *v;
diff --git a/xen/common/radix-tree.c b/xen/common/radix-tree.c
index 628a7e06988f..33b47748ae49 100644
--- a/xen/common/radix-tree.c
+++ b/xen/common/radix-tree.c
@@ -58,7 +58,7 @@ static struct radix_tree_node *rcu_node_alloc(void *arg)
 	return rcu_node ? &rcu_node->node : NULL;
 }
 
-static void _rcu_node_free(struct rcu_head *head)
+static void cf_check _rcu_node_free(struct rcu_head *head)
 {
 	struct rcu_node *rcu_node =
 		container_of(head, struct rcu_node, rcu_head);
diff --git a/xen/common/rcupdate.c b/xen/common/rcupdate.c
index f9dd2584a8b7..423d6b1d6d02 100644
--- a/xen/common/rcupdate.c
+++ b/xen/common/rcupdate.c
@@ -167,7 +167,7 @@ static int rsinterval = 1000;
 static atomic_t cpu_count = ATOMIC_INIT(0);
 static atomic_t pending_count = ATOMIC_INIT(0);
 
-static void rcu_barrier_callback(struct rcu_head *head)
+static void cf_check rcu_barrier_callback(struct rcu_head *head)
 {
     /*
      * We need a barrier making all previous writes visible to other cpus
diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c
index cf1ba01b4d87..285de9ee2a19 100644
--- a/xen/common/sched/core.c
+++ b/xen/common/sched/core.c
@@ -2798,7 +2798,7 @@ static int cpu_schedule_up(unsigned int cpu)
     return 0;
 }
 
-static void sched_res_free(struct rcu_head *head)
+static void cf_check sched_res_free(struct rcu_head *head)
 {
     struct sched_resource *sr = container_of(head, struct sched_resource, rcu);
 
diff --git a/xen/xsm/flask/avc.c b/xen/xsm/flask/avc.c
index 87ea38b7a0d0..e20c16504213 100644
--- a/xen/xsm/flask/avc.c
+++ b/xen/xsm/flask/avc.c
@@ -276,7 +276,7 @@ int avc_get_hash_stats(struct xen_flask_hash_stats *arg)
     return 0;
 }
 
-static void avc_node_free(struct rcu_head *rhead)
+static void cf_check avc_node_free(struct rcu_head *rhead)
 {
     struct avc_node *node = container_of(rhead, struct avc_node, rhead);
     xfree(node);
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:16:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:16:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271912.466654 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbDH-0001ev-31; Mon, 14 Feb 2022 13:16:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271912.466654; Mon, 14 Feb 2022 13:16:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbDG-0001em-WD; Mon, 14 Feb 2022 13:16:19 +0000
Received: by outflank-mailman (input) for mailman id 271912;
 Mon, 14 Feb 2022 13:16:17 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJb3U-00023t-II
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:06:12 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e0413ad2-8d96-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 14:06:10 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e0413ad2-8d96-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644843971;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=qZhvnjEBLt6HNiQInDJlsXjMWzuTPnZZsavbgdbb+Q8=;
  b=IGboPm52Xu/8RsyDY7+JM1YtWkKZ7aSLvl6CJwXdg/BzX8KLOu3BzgIP
   5qzndOF6dxURgrPPJEkelNht5XQdIPWK03gkgYq+5p6THn+sf6z18OWFR
   1PYx75PFpTgG95t5O33aW4zjv6Mo8C+X2eUzj+LDiTMaHEIh6vxcUApfG
   k=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: lyrDEo4OMsz6HcvoqhuRMiigziNljYEumekSe7hFU9ENYrAtYLSDI7IPzKXjU00SOpj327clsp
 xb0x1quFKSr6uFUphmruFhZZkYjpu1OdmSvDUF8j0xKkWRBUiqAOaGX+HcLqTbrFY44yeE8O7B
 k728GMPVi6dB4qJMjEN/8pIrgjTZcI3/ngRcIBJIIv1TwYHxJPl09pxoFgmRHBzoVOp01Gsoq4
 KiSozyMQD9WsbM4GHx+sIIC2RrHyDAE/FjuNdJSZnhvLleQDY6z8EIcLRNmRe3wdFkN2Ok+SJ1
 7EHa51g7zKu2QKwh717mcleh
X-SBRS: 5.1
X-MesageID: 64149447
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:5q+K6qhQNSBfGjsO5QoImiKyX161fxcKZh0ujC45NGQN5FlHY01je
 htvXGmCOqyKNzSgf95/PYi+80JUv5LWzdUwSwpt+SlgE38b9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oAMKRCQ7InQLlbGILes1htZGEk0GE/NtTo5w7Rj2tQx3YDga++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /1dlYKZdD4AIJfVp8A8Cj15PxFyAr9JreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHCOo8Ft24m5jbeFfs8GrjIQrnQ5M8e1zA17ixLNaiCP
 pZINWYwBPjGSxBLKEc4Go4CpcaTmGvBdyJYqnW5qaVitgA/yyQuieOwYbI5YOeiVchT20qVu
 G/C12D4GQ0BcsySzyKf9XChjfOJmjn0ML/+D5XhqKQs2gfKgDVOVltGDjNXvMVVlGaue8x2F
 nU95BA3kowTrWiKYunxYA+39SvsUgEnZ/JcFOgz6Qeow6XS4hqECmVscgOteODKp+dtG2V0i
 wbhc8fBQGU27ebLES71GqK88GvqURX5O1PucsPtoeEtx9D46L8+gRvUJjqIOP7k14alcd0cL
 t3jkcTfu1nxpZNRv0lY1Qqe695JmnQuZlRrjjg7pkr/smtEiHeNPuREE2Tz4/daN5q+RVKcp
 nUCkMX2xLlQUc3SxHzQHb1UR+vBCxO53Nr02wAHInXc3271py7LkX54vFmS23uFwu5bIGS0M
 Sc/SCta5YNJPWvCUEOES9nZNije9oC5TY6NfqmNNrJmO8EtHCfarHAGTRPBhAjFzRlz+ZzTz
 L/GKK5A+15BUv85pNd3Ls9AuYIWKtcWmz+NG8ChkkjPPHj3TCf9dIrp+WCmNogRhJ5oai2Pm
 zqGH8fVmRhZTsPkZSzbrdwaIVwQdCBpDpHqsc1HMOWEJ1M+Sm0mDvbQx5InepBkwPsJxruZo
 CnlVx8K0kf7iF3GNR6ONiJpZoTwUMsttnk8JyEtYwqlgiBxfYa14a4DXJIrZr17pvd7xPt5Q
 qBdKcWNC/hCUBrd/DEZYcWvpYBubk3z1wmPIzCkcH40eJs5H17F/drtfw3O8igSD3Xo6Zti8
 uP4jg6CGMgNXQVvCsrSecmD9VLpsChPgv92UmvJPsJXJBfm/r91JnGjlfQwOcwNd0nOn2PIy
 waMDB4EjuDRuItposLRjKWJoor1QetzGk1WQzvS4bqsbHSI+2OixclLUfqSfCCbX2Txof3wa
 eJQxvD6EfsGgFcV7NYsT+c1lfozt4n1urtX7gV4B3GaPV2kB4RpLmSCwcQS5LZGwaVUuFfuV
 0+CkjWA1W5l5C8x/IYtGTcY
IronPort-HdrOrdr: A9a23:XfeIua9x/dkPwzLbZNZuk+DaI+orL9Y04lQ7vn2YSXRuHPBw9v
 re5cjzuiWVtN98Yh0dcJW7Scy9qBDnhPhICOsqTNSftWDd0QPCRuxfBMnZslnd8kXFh4lgPM
 xbEpSWZueeMbEDt7eZ3DWF
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="64149447"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v2 25/70] xen/vpci: CFI hardening
Date: Mon, 14 Feb 2022 12:50:42 +0000
Message-ID: <20220214125127.17985-26-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

Control Flow Integrity schemes use toolchain and optionally hardware support
to help protect against call/jump/return oriented programming attacks.

Use cf_check to annotate function pointer targets for the toolchain.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
 xen/drivers/vpci/header.c | 18 +++++++++---------
 xen/drivers/vpci/msi.c    | 42 +++++++++++++++++++++---------------------
 xen/drivers/vpci/msix.c   | 20 ++++++++++----------
 xen/drivers/vpci/vpci.c   | 16 ++++++++--------
 xen/include/xen/vpci.h    |  8 ++++----
 5 files changed, 52 insertions(+), 52 deletions(-)

diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c
index 40ff79c33f8f..a1c928a0d26f 100644
--- a/xen/drivers/vpci/header.c
+++ b/xen/drivers/vpci/header.c
@@ -33,8 +33,8 @@ struct map_data {
     bool map;
 };
 
-static int map_range(unsigned long s, unsigned long e, void *data,
-                     unsigned long *c)
+static int cf_check map_range(
+    unsigned long s, unsigned long e, void *data, unsigned long *c)
 {
     const struct map_data *map = data;
     int rc;
@@ -332,8 +332,8 @@ static int modify_bars(const struct pci_dev *pdev, uint16_t cmd, bool rom_only)
     return 0;
 }
 
-static void cmd_write(const struct pci_dev *pdev, unsigned int reg,
-                      uint32_t cmd, void *data)
+static void cf_check cmd_write(
+    const struct pci_dev *pdev, unsigned int reg, uint32_t cmd, void *data)
 {
     uint16_t current_cmd = pci_conf_read16(pdev->sbdf, reg);
 
@@ -353,8 +353,8 @@ static void cmd_write(const struct pci_dev *pdev, unsigned int reg,
         pci_conf_write16(pdev->sbdf, reg, cmd);
 }
 
-static void bar_write(const struct pci_dev *pdev, unsigned int reg,
-                      uint32_t val, void *data)
+static void cf_check bar_write(
+    const struct pci_dev *pdev, unsigned int reg, uint32_t val, void *data)
 {
     struct vpci_bar *bar = data;
     bool hi = false;
@@ -397,8 +397,8 @@ static void bar_write(const struct pci_dev *pdev, unsigned int reg,
     pci_conf_write32(pdev->sbdf, reg, val);
 }
 
-static void rom_write(const struct pci_dev *pdev, unsigned int reg,
-                      uint32_t val, void *data)
+static void cf_check rom_write(
+    const struct pci_dev *pdev, unsigned int reg, uint32_t val, void *data)
 {
     struct vpci_header *header = &pdev->vpci->header;
     struct vpci_bar *rom = data;
@@ -445,7 +445,7 @@ static void rom_write(const struct pci_dev *pdev, unsigned int reg,
         rom->addr = val & PCI_ROM_ADDRESS_MASK;
 }
 
-static int init_bars(struct pci_dev *pdev)
+static int cf_check init_bars(struct pci_dev *pdev)
 {
     uint16_t cmd;
     uint64_t addr, size;
diff --git a/xen/drivers/vpci/msi.c b/xen/drivers/vpci/msi.c
index 5757a7aed20f..8f2b59e61aa4 100644
--- a/xen/drivers/vpci/msi.c
+++ b/xen/drivers/vpci/msi.c
@@ -22,8 +22,8 @@
 
 #include <asm/msi.h>
 
-static uint32_t control_read(const struct pci_dev *pdev, unsigned int reg,
-                             void *data)
+static uint32_t cf_check control_read(
+    const struct pci_dev *pdev, unsigned int reg, void *data)
 {
     const struct vpci_msi *msi = data;
 
@@ -34,8 +34,8 @@ static uint32_t control_read(const struct pci_dev *pdev, unsigned int reg,
            (msi->address64 ? PCI_MSI_FLAGS_64BIT : 0);
 }
 
-static void control_write(const struct pci_dev *pdev, unsigned int reg,
-                          uint32_t val, void *data)
+static void cf_check control_write(
+    const struct pci_dev *pdev, unsigned int reg, uint32_t val, void *data)
 {
     struct vpci_msi *msi = data;
     unsigned int vectors = min_t(uint8_t,
@@ -89,16 +89,16 @@ static void update_msi(const struct pci_dev *pdev, struct vpci_msi *msi)
 }
 
 /* Handlers for the address field (32bit or low part of a 64bit address). */
-static uint32_t address_read(const struct pci_dev *pdev, unsigned int reg,
-                             void *data)
+static uint32_t cf_check address_read(
+    const struct pci_dev *pdev, unsigned int reg, void *data)
 {
     const struct vpci_msi *msi = data;
 
     return msi->address;
 }
 
-static void address_write(const struct pci_dev *pdev, unsigned int reg,
-                          uint32_t val, void *data)
+static void cf_check address_write(
+    const struct pci_dev *pdev, unsigned int reg, uint32_t val, void *data)
 {
     struct vpci_msi *msi = data;
 
@@ -110,16 +110,16 @@ static void address_write(const struct pci_dev *pdev, unsigned int reg,
 }
 
 /* Handlers for the high part of a 64bit address field. */
-static uint32_t address_hi_read(const struct pci_dev *pdev, unsigned int reg,
-                                void *data)
+static uint32_t cf_check address_hi_read(
+    const struct pci_dev *pdev, unsigned int reg, void *data)
 {
     const struct vpci_msi *msi = data;
 
     return msi->address >> 32;
 }
 
-static void address_hi_write(const struct pci_dev *pdev, unsigned int reg,
-                             uint32_t val, void *data)
+static void cf_check address_hi_write(
+    const struct pci_dev *pdev, unsigned int reg, uint32_t val, void *data)
 {
     struct vpci_msi *msi = data;
 
@@ -131,16 +131,16 @@ static void address_hi_write(const struct pci_dev *pdev, unsigned int reg,
 }
 
 /* Handlers for the data field. */
-static uint32_t data_read(const struct pci_dev *pdev, unsigned int reg,
-                          void *data)
+static uint32_t cf_check data_read(
+    const struct pci_dev *pdev, unsigned int reg, void *data)
 {
     const struct vpci_msi *msi = data;
 
     return msi->data;
 }
 
-static void data_write(const struct pci_dev *pdev, unsigned int reg,
-                       uint32_t val, void *data)
+static void cf_check data_write(
+    const struct pci_dev *pdev, unsigned int reg, uint32_t val, void *data)
 {
     struct vpci_msi *msi = data;
 
@@ -150,16 +150,16 @@ static void data_write(const struct pci_dev *pdev, unsigned int reg,
 }
 
 /* Handlers for the MSI mask bits. */
-static uint32_t mask_read(const struct pci_dev *pdev, unsigned int reg,
-                          void *data)
+static uint32_t cf_check mask_read(
+    const struct pci_dev *pdev, unsigned int reg, void *data)
 {
     const struct vpci_msi *msi = data;
 
     return msi->mask;
 }
 
-static void mask_write(const struct pci_dev *pdev, unsigned int reg,
-                       uint32_t val, void *data)
+static void cf_check mask_write(
+    const struct pci_dev *pdev, unsigned int reg, uint32_t val, void *data)
 {
     struct vpci_msi *msi = data;
     uint32_t dmask = msi->mask ^ val;
@@ -182,7 +182,7 @@ static void mask_write(const struct pci_dev *pdev, unsigned int reg,
     msi->mask = val;
 }
 
-static int init_msi(struct pci_dev *pdev)
+static int cf_check init_msi(struct pci_dev *pdev)
 {
     uint8_t slot = PCI_SLOT(pdev->devfn), func = PCI_FUNC(pdev->devfn);
     unsigned int pos = pci_find_cap_offset(pdev->seg, pdev->bus, slot, func,
diff --git a/xen/drivers/vpci/msix.c b/xen/drivers/vpci/msix.c
index 846f1b8d7038..2ab4079412f2 100644
--- a/xen/drivers/vpci/msix.c
+++ b/xen/drivers/vpci/msix.c
@@ -27,8 +27,8 @@
     ((addr) >= vmsix_table_addr(vpci, nr) &&                              \
      (addr) < vmsix_table_addr(vpci, nr) + vmsix_table_size(vpci, nr))
 
-static uint32_t control_read(const struct pci_dev *pdev, unsigned int reg,
-                             void *data)
+static uint32_t cf_check control_read(
+    const struct pci_dev *pdev, unsigned int reg, void *data)
 {
     const struct vpci_msix *msix = data;
 
@@ -65,8 +65,8 @@ static void update_entry(struct vpci_msix_entry *entry,
     entry->updated = false;
 }
 
-static void control_write(const struct pci_dev *pdev, unsigned int reg,
-                          uint32_t val, void *data)
+static void cf_check control_write(
+    const struct pci_dev *pdev, unsigned int reg, uint32_t val, void *data)
 {
     struct vpci_msix *msix = data;
     bool new_masked = val & PCI_MSIX_FLAGS_MASKALL;
@@ -156,7 +156,7 @@ static struct vpci_msix *msix_find(const struct domain *d, unsigned long addr)
     return NULL;
 }
 
-static int msix_accept(struct vcpu *v, unsigned long addr)
+static int cf_check msix_accept(struct vcpu *v, unsigned long addr)
 {
     return !!msix_find(v->domain, addr);
 }
@@ -182,8 +182,8 @@ static struct vpci_msix_entry *get_entry(struct vpci_msix *msix,
     return &msix->entries[(addr - start) / PCI_MSIX_ENTRY_SIZE];
 }
 
-static int msix_read(struct vcpu *v, unsigned long addr, unsigned int len,
-                     unsigned long *data)
+static int cf_check msix_read(
+    struct vcpu *v, unsigned long addr, unsigned int len, unsigned long *data)
 {
     const struct domain *d = v->domain;
     struct vpci_msix *msix = msix_find(d, addr);
@@ -259,8 +259,8 @@ static int msix_read(struct vcpu *v, unsigned long addr, unsigned int len,
     return X86EMUL_OKAY;
 }
 
-static int msix_write(struct vcpu *v, unsigned long addr, unsigned int len,
-                      unsigned long data)
+static int cf_check msix_write(
+    struct vcpu *v, unsigned long addr, unsigned int len, unsigned long data)
 {
     const struct domain *d = v->domain;
     struct vpci_msix *msix = msix_find(d, addr);
@@ -428,7 +428,7 @@ int vpci_make_msix_hole(const struct pci_dev *pdev)
     return 0;
 }
 
-static int init_msix(struct pci_dev *pdev)
+static int cf_check init_msix(struct pci_dev *pdev)
 {
     struct domain *d = pdev->domain;
     uint8_t slot = PCI_SLOT(pdev->devfn), func = PCI_FUNC(pdev->devfn);
diff --git a/xen/drivers/vpci/vpci.c b/xen/drivers/vpci/vpci.c
index fb0947179b79..f3b32d66cb35 100644
--- a/xen/drivers/vpci/vpci.c
+++ b/xen/drivers/vpci/vpci.c
@@ -106,25 +106,25 @@ static int vpci_register_cmp(const struct vpci_register *r1,
 }
 
 /* Dummy hooks, writes are ignored, reads return 1's */
-static uint32_t vpci_ignored_read(const struct pci_dev *pdev, unsigned int reg,
-                                  void *data)
+static uint32_t cf_check vpci_ignored_read(
+    const struct pci_dev *pdev, unsigned int reg, void *data)
 {
     return ~(uint32_t)0;
 }
 
-static void vpci_ignored_write(const struct pci_dev *pdev, unsigned int reg,
-                               uint32_t val, void *data)
+static void cf_check vpci_ignored_write(
+    const struct pci_dev *pdev, unsigned int reg, uint32_t val, void *data)
 {
 }
 
-uint32_t vpci_hw_read16(const struct pci_dev *pdev, unsigned int reg,
-                        void *data)
+uint32_t cf_check vpci_hw_read16(
+    const struct pci_dev *pdev, unsigned int reg, void *data)
 {
     return pci_conf_read16(pdev->sbdf, reg);
 }
 
-uint32_t vpci_hw_read32(const struct pci_dev *pdev, unsigned int reg,
-                        void *data)
+uint32_t cf_check vpci_hw_read32(
+    const struct pci_dev *pdev, unsigned int reg, void *data)
 {
     return pci_conf_read32(pdev->sbdf, reg);
 }
diff --git a/xen/include/xen/vpci.h b/xen/include/xen/vpci.h
index e8ac1eb39513..bcad1516aee1 100644
--- a/xen/include/xen/vpci.h
+++ b/xen/include/xen/vpci.h
@@ -46,10 +46,10 @@ void vpci_write(pci_sbdf_t sbdf, unsigned int reg, unsigned int size,
                 uint32_t data);
 
 /* Passthrough handlers. */
-uint32_t vpci_hw_read16(const struct pci_dev *pdev, unsigned int reg,
-                        void *data);
-uint32_t vpci_hw_read32(const struct pci_dev *pdev, unsigned int reg,
-                        void *data);
+uint32_t cf_check vpci_hw_read16(
+    const struct pci_dev *pdev, unsigned int reg, void *data);
+uint32_t cf_check vpci_hw_read32(
+    const struct pci_dev *pdev, unsigned int reg, void *data);
 
 /*
  * Check for pending vPCI operations on this vcpu. Returns true if the vcpu
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:16:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:16:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271913.466665 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbDK-00020K-Iy; Mon, 14 Feb 2022 13:16:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271913.466665; Mon, 14 Feb 2022 13:16:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbDK-0001zy-F0; Mon, 14 Feb 2022 13:16:22 +0000
Received: by outflank-mailman (input) for mailman id 271913;
 Mon, 14 Feb 2022 13:16:19 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJb3W-0008IH-A5
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:06:14 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e168e7d9-8d96-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 14:06:12 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e168e7d9-8d96-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644843972;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=ZeH6O9XaSCM4nWzskGu9oWidhKAGbDFLn89nxDUkjLk=;
  b=QJZzM5oaZhi2xA2Zi89Y2xHTTFb08J+5kg3g51lyURuTTfHkyTqM+ldN
   MB40FNTexah9W2SHlfj2hz5FQ6TS0uRn0xUQO5vgrDCxP50MvMtW+OuS7
   4lJ+O9797EniZa0U9k+Z8Df2KId/udjvvMWVDK1cBmU0X2CUIi/D6X6h4
   Q=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: PgHkDbHah6iAFNUMu4uw1QH6AB+iOophm8YewS0rfzJp6aePwkzcxFz0t/hmEoM/+Jxxvzck7g
 LpNjFD83Q+8hHJlHJYJ8B+Nu3K+69PlUeh6vXnWQRIp9QUBHU4uCqbI54QitbuTDHNPqyDgkC9
 FWmMWo8uBygGhhpFuEJdBZ4CkJ3NHWNkvyBEQ8enZGdyXRHTpWAxDozFO0SkviYmbzk7QVa59H
 BcYk8w4f0JwsRK4J7oIr2eejvIa76ZG4PozqUAZGM6+tuNGHx470pUjbsnzie62WHwzNKgxUXL
 jY2T/Ti6Fh9CKX5IGGjgoT78
X-SBRS: 5.1
X-MesageID: 64149870
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:7+b3VK6m1Bog8IjFj4AnKQxRtCfAchMFZxGqfqrLsTDasY5as4F+v
 mVOD2qAaK2OYjH3Lox1bom39h4CvcXVnNE2HAI+/yBjHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FV8MpBsJ00o5wbZj29Iw2LBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zx
 I0SrbWAYwsSHrTv2/oHSidcHTNvMvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALBc/nJo4A/FpnyinUF60OSpHfWaTao9Rf2V/cg+gQQa+CN
 ppGMVKDajzRODpOYAkPV6sP37iupXn2dDpit1ua8P9fD2/7k1UqjemF3MDuUsyHQ4BZk1iVo
 krC/n/lGVcKOdqH0z2H/3mwwOjVkkvGtJk6TePisKQw2RvKmzJVWEZ+uUaHTeeRhhbhQ/tvA
 UAv2jMN7rYo7XKvQMvsUEjtyJKbhSI0V91VGuw8zQiCzKvI/gqUblQ5oi59hM8O75FvG2Fzv
 rOdt5awXGE07uXJIZ6I3urM9VuP1T4pwXjujMPuZS8M+JHdrY46lXojpf4zQffu3rUZ9dwdq
 g1mTRTSZZ1O16bnNI3hpDgrZg5AQbCTEGYICv3/BD7N0++ATNfNi3aUwVba9+1cC42SU0OMu
 nMJ8+DHsrxSUsHdyXHVGb5XdF1M2xpiGGeC6WOD4rF7r2j9k5JdVdw4DM5CyLdBbZ9fJG6Bj
 L77sgJN/p5DVEZGnocsC79d//8ClPC6ffy8D6i8RoMXPvBZKV/WlAkzNBX49z28zyARfVQXZ
 M7znTCEVi1BV8yKDVOeGo8g7FPc7n5imz2DH82np/lluJLHDEOopX4+GAPmRogEAGms+W05K
 v5TaJmHzQtxSur7bnWF+IIfNwlSf3M6GYr3u4pccevaelhqH2QoCvnwx7I9etM6w/QJx7mQp
 nztCFVFzFffhGHcLVnYYH5Ud76yD410qmg2PHJwMA/wiWQje4um8IwWa4AzIes87OVmwPMtF
 6sFdsyMD+5hUDPC/zhBP5DxoJY7LEaghB6UPjrjaz86JsYySwvM897iXw3u6ChRUXbn6Zpg+
 +Wtj1qJT4ACSgJuCNftRMiul17h72IAnO9SXlfTJoUBckvb74U3eTf6ieU6Ip9QJEyblCeaz
 QufHTwRufLJ/90u6NDMiK2J89WpHu95EhYIFmXX9+/rZyzT/27lyo5cSueYOzvaUTqsqqmlY
 OxUydD6MeEGwwkW49YtTe4zwPJs/cbrqp9b0h9gTSfCYFmcA799JmWLgJtUvapXy74F4Qa7V
 ypjIDWB1Wll7C89LGMsGQ==
IronPort-HdrOrdr: A9a23:6e+jBa8GOLnaHDB8X45uk+DaI+orL9Y04lQ7vn2YSXRuHPBw9v
 re5cjzuiWVtN98Yh0dcJW7Scy9qBDnhPhICOsqTNSftWDd0QPCRuxfBMnZslnd8kXFh4lgPM
 xbEpSWZueeMbEDt7eZ3DWF
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="64149870"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v2 42/70] x86/hvmsave: CFI hardening
Date: Mon, 14 Feb 2022 12:50:59 +0000
Message-ID: <20220214125127.17985-43-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

Control Flow Integrity schemes use toolchain and optionally hardware support
to help protect against call/jump/return oriented programming attacks.

Use cf_check to annotate function pointer targets for the toolchain.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
 xen/arch/x86/cpu/mcheck/vmce.c       |  4 ++--
 xen/arch/x86/emul-i8254.c            |  4 ++--
 xen/arch/x86/hvm/hpet.c              |  4 ++--
 xen/arch/x86/hvm/hvm.c               | 18 ++++++++++--------
 xen/arch/x86/hvm/irq.c               | 12 ++++++------
 xen/arch/x86/hvm/mtrr.c              |  4 ++--
 xen/arch/x86/hvm/pmtimer.c           |  4 ++--
 xen/arch/x86/hvm/rtc.c               |  4 ++--
 xen/arch/x86/hvm/vioapic.c           |  4 ++--
 xen/arch/x86/hvm/viridian/viridian.c | 15 ++++++++-------
 xen/arch/x86/hvm/vlapic.c            |  8 ++++----
 xen/arch/x86/hvm/vpic.c              |  4 ++--
 12 files changed, 44 insertions(+), 41 deletions(-)

diff --git a/xen/arch/x86/cpu/mcheck/vmce.c b/xen/arch/x86/cpu/mcheck/vmce.c
index eb6434a3ba20..458120f9ad8d 100644
--- a/xen/arch/x86/cpu/mcheck/vmce.c
+++ b/xen/arch/x86/cpu/mcheck/vmce.c
@@ -353,7 +353,7 @@ int vmce_wrmsr(uint32_t msr, uint64_t val)
 }
 
 #if CONFIG_HVM
-static int vmce_save_vcpu_ctxt(struct vcpu *v, hvm_domain_context_t *h)
+static int cf_check vmce_save_vcpu_ctxt(struct vcpu *v, hvm_domain_context_t *h)
 {
     struct hvm_vmce_vcpu ctxt = {
         .caps = v->arch.vmce.mcg_cap,
@@ -365,7 +365,7 @@ static int vmce_save_vcpu_ctxt(struct vcpu *v, hvm_domain_context_t *h)
     return hvm_save_entry(VMCE_VCPU, v->vcpu_id, h, &ctxt);
 }
 
-static int vmce_load_vcpu_ctxt(struct domain *d, hvm_domain_context_t *h)
+static int cf_check vmce_load_vcpu_ctxt(struct domain *d, hvm_domain_context_t *h)
 {
     unsigned int vcpuid = hvm_load_instance(h);
     struct vcpu *v;
diff --git a/xen/arch/x86/emul-i8254.c b/xen/arch/x86/emul-i8254.c
index 0e09a173187f..d170f464d966 100644
--- a/xen/arch/x86/emul-i8254.c
+++ b/xen/arch/x86/emul-i8254.c
@@ -391,7 +391,7 @@ void pit_stop_channel0_irq(PITState *pit)
     spin_unlock(&pit->lock);
 }
 
-static int pit_save(struct vcpu *v, hvm_domain_context_t *h)
+static int cf_check pit_save(struct vcpu *v, hvm_domain_context_t *h)
 {
     struct domain *d = v->domain;
     PITState *pit = domain_vpit(d);
@@ -409,7 +409,7 @@ static int pit_save(struct vcpu *v, hvm_domain_context_t *h)
     return rc;
 }
 
-static int pit_load(struct domain *d, hvm_domain_context_t *h)
+static int cf_check pit_load(struct domain *d, hvm_domain_context_t *h)
 {
     PITState *pit = domain_vpit(d);
     int i, rc = 0;
diff --git a/xen/arch/x86/hvm/hpet.c b/xen/arch/x86/hvm/hpet.c
index 7bdb51cfa1c4..ed512fa65b63 100644
--- a/xen/arch/x86/hvm/hpet.c
+++ b/xen/arch/x86/hvm/hpet.c
@@ -582,7 +582,7 @@ static const struct hvm_mmio_ops hpet_mmio_ops = {
 };
 
 
-static int hpet_save(struct vcpu *v, hvm_domain_context_t *h)
+static int cf_check hpet_save(struct vcpu *v, hvm_domain_context_t *h)
 {
     const struct domain *d = v->domain;
     HPETState *hp = domain_vhpet(d);
@@ -645,7 +645,7 @@ static int hpet_save(struct vcpu *v, hvm_domain_context_t *h)
     return rc;
 }
 
-static int hpet_load(struct domain *d, hvm_domain_context_t *h)
+static int cf_check hpet_load(struct domain *d, hvm_domain_context_t *h)
 {
     HPETState *hp = domain_vhpet(d);
     struct hvm_hw_hpet *rec;
diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c
index e87e809a945d..4cf313a0ad0a 100644
--- a/xen/arch/x86/hvm/hvm.c
+++ b/xen/arch/x86/hvm/hvm.c
@@ -756,7 +756,7 @@ void hvm_domain_destroy(struct domain *d)
     destroy_vpci_mmcfg(d);
 }
 
-static int hvm_save_tsc_adjust(struct vcpu *v, hvm_domain_context_t *h)
+static int cf_check hvm_save_tsc_adjust(struct vcpu *v, hvm_domain_context_t *h)
 {
     struct hvm_tsc_adjust ctxt = {
         .tsc_adjust = v->arch.hvm.msr_tsc_adjust,
@@ -765,7 +765,7 @@ static int hvm_save_tsc_adjust(struct vcpu *v, hvm_domain_context_t *h)
     return hvm_save_entry(TSC_ADJUST, v->vcpu_id, h, &ctxt);
 }
 
-static int hvm_load_tsc_adjust(struct domain *d, hvm_domain_context_t *h)
+static int cf_check hvm_load_tsc_adjust(struct domain *d, hvm_domain_context_t *h)
 {
     unsigned int vcpuid = hvm_load_instance(h);
     struct vcpu *v;
@@ -788,7 +788,7 @@ static int hvm_load_tsc_adjust(struct domain *d, hvm_domain_context_t *h)
 HVM_REGISTER_SAVE_RESTORE(TSC_ADJUST, hvm_save_tsc_adjust,
                           hvm_load_tsc_adjust, 1, HVMSR_PER_VCPU);
 
-static int hvm_save_cpu_ctxt(struct vcpu *v, hvm_domain_context_t *h)
+static int cf_check hvm_save_cpu_ctxt(struct vcpu *v, hvm_domain_context_t *h)
 {
     struct segment_register seg;
     struct hvm_hw_cpu ctxt = {
@@ -971,7 +971,7 @@ unsigned long hvm_cr4_guest_valid_bits(const struct domain *d)
             (cet              ? X86_CR4_CET               : 0));
 }
 
-static int hvm_load_cpu_ctxt(struct domain *d, hvm_domain_context_t *h)
+static int cf_check hvm_load_cpu_ctxt(struct domain *d, hvm_domain_context_t *h)
 {
     unsigned int vcpuid = hvm_load_instance(h);
     struct vcpu *v;
@@ -1172,7 +1172,8 @@ HVM_REGISTER_SAVE_RESTORE(CPU, hvm_save_cpu_ctxt, hvm_load_cpu_ctxt, 1,
                                            save_area) + \
                                   xstate_ctxt_size(xcr0))
 
-static int hvm_save_cpu_xsave_states(struct vcpu *v, hvm_domain_context_t *h)
+static int cf_check hvm_save_cpu_xsave_states(
+    struct vcpu *v, hvm_domain_context_t *h)
 {
     struct hvm_hw_cpu_xsave *ctxt;
     unsigned int size = HVM_CPU_XSAVE_SIZE(v->arch.xcr0_accum);
@@ -1210,7 +1211,8 @@ CHECK_FIELD_(struct, xsave_hdr, reserved);
 #undef compat_xsave_hdr
 #undef xen_xsave_hdr
 
-static int hvm_load_cpu_xsave_states(struct domain *d, hvm_domain_context_t *h)
+static int cf_check hvm_load_cpu_xsave_states(
+    struct domain *d, hvm_domain_context_t *h)
 {
     unsigned int vcpuid, size;
     int err;
@@ -1338,7 +1340,7 @@ static const uint32_t msrs_to_send[] = {
     MSR_AMD64_DR3_ADDRESS_MASK,
 };
 
-static int hvm_save_cpu_msrs(struct vcpu *v, hvm_domain_context_t *h)
+static int cf_check hvm_save_cpu_msrs(struct vcpu *v, hvm_domain_context_t *h)
 {
     const struct domain *d = v->domain;
     struct hvm_save_descriptor *desc = _p(&h->data[h->cur]);
@@ -1418,7 +1420,7 @@ static int hvm_save_cpu_msrs(struct vcpu *v, hvm_domain_context_t *h)
     return 0;
 }
 
-static int hvm_load_cpu_msrs(struct domain *d, hvm_domain_context_t *h)
+static int cf_check hvm_load_cpu_msrs(struct domain *d, hvm_domain_context_t *h)
 {
     unsigned int i, vcpuid = hvm_load_instance(h);
     struct vcpu *v;
diff --git a/xen/arch/x86/hvm/irq.c b/xen/arch/x86/hvm/irq.c
index a7f8991a7b84..5a7f39b54ff4 100644
--- a/xen/arch/x86/hvm/irq.c
+++ b/xen/arch/x86/hvm/irq.c
@@ -657,7 +657,7 @@ static int __init cf_check dump_irq_info_key_init(void)
 }
 __initcall(dump_irq_info_key_init);
 
-static int irq_save_pci(struct vcpu *v, hvm_domain_context_t *h)
+static int cf_check irq_save_pci(struct vcpu *v, hvm_domain_context_t *h)
 {
     struct domain *d = v->domain;
     struct hvm_irq *hvm_irq = hvm_domain_irq(d);
@@ -690,7 +690,7 @@ static int irq_save_pci(struct vcpu *v, hvm_domain_context_t *h)
     return rc;
 }
 
-static int irq_save_isa(struct vcpu *v, hvm_domain_context_t *h)
+static int cf_check irq_save_isa(struct vcpu *v, hvm_domain_context_t *h)
 {
     const struct domain *d = v->domain;
     struct hvm_irq *hvm_irq = hvm_domain_irq(d);
@@ -699,7 +699,7 @@ static int irq_save_isa(struct vcpu *v, hvm_domain_context_t *h)
     return hvm_save_entry(ISA_IRQ, 0, h, &hvm_irq->isa_irq);
 }
 
-static int irq_save_link(struct vcpu *v, hvm_domain_context_t *h)
+static int cf_check irq_save_link(struct vcpu *v, hvm_domain_context_t *h)
 {
     const struct domain *d = v->domain;
     struct hvm_irq *hvm_irq = hvm_domain_irq(d);
@@ -708,7 +708,7 @@ static int irq_save_link(struct vcpu *v, hvm_domain_context_t *h)
     return hvm_save_entry(PCI_LINK, 0, h, &hvm_irq->pci_link);
 }
 
-static int irq_load_pci(struct domain *d, hvm_domain_context_t *h)
+static int cf_check irq_load_pci(struct domain *d, hvm_domain_context_t *h)
 {
     struct hvm_irq *hvm_irq = hvm_domain_irq(d);
     int link, dev, intx, gsi;
@@ -741,7 +741,7 @@ static int irq_load_pci(struct domain *d, hvm_domain_context_t *h)
     return 0;
 }
 
-static int irq_load_isa(struct domain *d, hvm_domain_context_t *h)
+static int cf_check irq_load_isa(struct domain *d, hvm_domain_context_t *h)
 {
     struct hvm_irq *hvm_irq = hvm_domain_irq(d);
     int irq;
@@ -760,7 +760,7 @@ static int irq_load_isa(struct domain *d, hvm_domain_context_t *h)
 }
 
 
-static int irq_load_link(struct domain *d, hvm_domain_context_t *h)
+static int cf_check irq_load_link(struct domain *d, hvm_domain_context_t *h)
 {
     struct hvm_irq *hvm_irq = hvm_domain_irq(d);
     int link, gsi;
diff --git a/xen/arch/x86/hvm/mtrr.c b/xen/arch/x86/hvm/mtrr.c
index 42f3d8319296..4d2aa6def86d 100644
--- a/xen/arch/x86/hvm/mtrr.c
+++ b/xen/arch/x86/hvm/mtrr.c
@@ -687,7 +687,7 @@ int hvm_set_mem_pinned_cacheattr(struct domain *d, uint64_t gfn_start,
     return 0;
 }
 
-static int hvm_save_mtrr_msr(struct vcpu *v, hvm_domain_context_t *h)
+static int cf_check hvm_save_mtrr_msr(struct vcpu *v, hvm_domain_context_t *h)
 {
     const struct mtrr_state *mtrr_state = &v->arch.hvm.mtrr;
     struct hvm_hw_mtrr hw_mtrr = {
@@ -725,7 +725,7 @@ static int hvm_save_mtrr_msr(struct vcpu *v, hvm_domain_context_t *h)
     return hvm_save_entry(MTRR, v->vcpu_id, h, &hw_mtrr);
 }
 
-static int hvm_load_mtrr_msr(struct domain *d, hvm_domain_context_t *h)
+static int cf_check hvm_load_mtrr_msr(struct domain *d, hvm_domain_context_t *h)
 {
     unsigned int vcpuid, i;
     struct vcpu *v;
diff --git a/xen/arch/x86/hvm/pmtimer.c b/xen/arch/x86/hvm/pmtimer.c
index 60e3c8de4c6b..2a89bbdfa5b8 100644
--- a/xen/arch/x86/hvm/pmtimer.c
+++ b/xen/arch/x86/hvm/pmtimer.c
@@ -249,7 +249,7 @@ static int cf_check handle_pmt_io(
     return X86EMUL_OKAY;
 }
 
-static int acpi_save(struct vcpu *v, hvm_domain_context_t *h)
+static int cf_check acpi_save(struct vcpu *v, hvm_domain_context_t *h)
 {
     struct domain *d = v->domain;
     struct hvm_hw_acpi *acpi = &d->arch.hvm.acpi;
@@ -281,7 +281,7 @@ static int acpi_save(struct vcpu *v, hvm_domain_context_t *h)
     return rc;
 }
 
-static int acpi_load(struct domain *d, hvm_domain_context_t *h)
+static int cf_check acpi_load(struct domain *d, hvm_domain_context_t *h)
 {
     struct hvm_hw_acpi *acpi = &d->arch.hvm.acpi;
     PMTState *s = &d->arch.hvm.pl_time->vpmt;
diff --git a/xen/arch/x86/hvm/rtc.c b/xen/arch/x86/hvm/rtc.c
index bdc647e433e9..ed397276faa3 100644
--- a/xen/arch/x86/hvm/rtc.c
+++ b/xen/arch/x86/hvm/rtc.c
@@ -738,7 +738,7 @@ void rtc_migrate_timers(struct vcpu *v)
 }
 
 /* Save RTC hardware state */
-static int rtc_save(struct vcpu *v, hvm_domain_context_t *h)
+static int cf_check rtc_save(struct vcpu *v, hvm_domain_context_t *h)
 {
     const struct domain *d = v->domain;
     RTCState *s = domain_vrtc(d);
@@ -756,7 +756,7 @@ static int rtc_save(struct vcpu *v, hvm_domain_context_t *h)
 }
 
 /* Reload the hardware state from a saved domain */
-static int rtc_load(struct domain *d, hvm_domain_context_t *h)
+static int cf_check rtc_load(struct domain *d, hvm_domain_context_t *h)
 {
     RTCState *s = domain_vrtc(d);
 
diff --git a/xen/arch/x86/hvm/vioapic.c b/xen/arch/x86/hvm/vioapic.c
index b56549aa22d1..d5d5b02421e9 100644
--- a/xen/arch/x86/hvm/vioapic.c
+++ b/xen/arch/x86/hvm/vioapic.c
@@ -590,7 +590,7 @@ int vioapic_get_trigger_mode(const struct domain *d, unsigned int gsi)
     return vioapic->redirtbl[pin].fields.trig_mode;
 }
 
-static int ioapic_save(struct vcpu *v, hvm_domain_context_t *h)
+static int cf_check ioapic_save(struct vcpu *v, hvm_domain_context_t *h)
 {
     const struct domain *d = v->domain;
     struct hvm_vioapic *s;
@@ -607,7 +607,7 @@ static int ioapic_save(struct vcpu *v, hvm_domain_context_t *h)
     return hvm_save_entry(IOAPIC, 0, h, &s->domU);
 }
 
-static int ioapic_load(struct domain *d, hvm_domain_context_t *h)
+static int cf_check ioapic_load(struct domain *d, hvm_domain_context_t *h)
 {
     struct hvm_vioapic *s;
 
diff --git a/xen/arch/x86/hvm/viridian/viridian.c b/xen/arch/x86/hvm/viridian/viridian.c
index 7ebcaa1c899f..25dca93e8b71 100644
--- a/xen/arch/x86/hvm/viridian/viridian.c
+++ b/xen/arch/x86/hvm/viridian/viridian.c
@@ -1104,8 +1104,8 @@ void viridian_unmap_guest_page(struct viridian_page *vp)
     put_page_and_type(page);
 }
 
-static int viridian_save_domain_ctxt(struct vcpu *v,
-                                     hvm_domain_context_t *h)
+static int cf_check viridian_save_domain_ctxt(
+    struct vcpu *v, hvm_domain_context_t *h)
 {
     const struct domain *d = v->domain;
     const struct viridian_domain *vd = d->arch.hvm.viridian;
@@ -1123,8 +1123,8 @@ static int viridian_save_domain_ctxt(struct vcpu *v,
     return (hvm_save_entry(VIRIDIAN_DOMAIN, 0, h, &ctxt) != 0);
 }
 
-static int viridian_load_domain_ctxt(struct domain *d,
-                                     hvm_domain_context_t *h)
+static int cf_check viridian_load_domain_ctxt(
+    struct domain *d, hvm_domain_context_t *h)
 {
     struct viridian_domain *vd = d->arch.hvm.viridian;
     struct hvm_viridian_domain_context ctxt;
@@ -1144,7 +1144,8 @@ static int viridian_load_domain_ctxt(struct domain *d,
 HVM_REGISTER_SAVE_RESTORE(VIRIDIAN_DOMAIN, viridian_save_domain_ctxt,
                           viridian_load_domain_ctxt, 1, HVMSR_PER_DOM);
 
-static int viridian_save_vcpu_ctxt(struct vcpu *v, hvm_domain_context_t *h)
+static int cf_check viridian_save_vcpu_ctxt(
+    struct vcpu *v, hvm_domain_context_t *h)
 {
     struct hvm_viridian_vcpu_context ctxt = {};
 
@@ -1157,8 +1158,8 @@ static int viridian_save_vcpu_ctxt(struct vcpu *v, hvm_domain_context_t *h)
     return hvm_save_entry(VIRIDIAN_VCPU, v->vcpu_id, h, &ctxt);
 }
 
-static int viridian_load_vcpu_ctxt(struct domain *d,
-                                   hvm_domain_context_t *h)
+static int cf_check viridian_load_vcpu_ctxt(
+    struct domain *d, hvm_domain_context_t *h)
 {
     unsigned int vcpuid = hvm_load_instance(h);
     struct vcpu *v;
diff --git a/xen/arch/x86/hvm/vlapic.c b/xen/arch/x86/hvm/vlapic.c
index 652e3cb87f12..d4e29ef1ff1d 100644
--- a/xen/arch/x86/hvm/vlapic.c
+++ b/xen/arch/x86/hvm/vlapic.c
@@ -1482,7 +1482,7 @@ static void lapic_rearm(struct vlapic *s)
     s->timer_last_update = s->pt.last_plt_gtime;
 }
 
-static int lapic_save_hidden(struct vcpu *v, hvm_domain_context_t *h)
+static int cf_check lapic_save_hidden(struct vcpu *v, hvm_domain_context_t *h)
 {
     if ( !has_vlapic(v->domain) )
         return 0;
@@ -1490,7 +1490,7 @@ static int lapic_save_hidden(struct vcpu *v, hvm_domain_context_t *h)
     return hvm_save_entry(LAPIC, v->vcpu_id, h, &vcpu_vlapic(v)->hw);
 }
 
-static int lapic_save_regs(struct vcpu *v, hvm_domain_context_t *h)
+static int cf_check lapic_save_regs(struct vcpu *v, hvm_domain_context_t *h)
 {
     if ( !has_vlapic(v->domain) )
         return 0;
@@ -1529,7 +1529,7 @@ static void lapic_load_fixup(struct vlapic *vlapic)
     }
 }
 
-static int lapic_load_hidden(struct domain *d, hvm_domain_context_t *h)
+static int cf_check lapic_load_hidden(struct domain *d, hvm_domain_context_t *h)
 {
     unsigned int vcpuid = hvm_load_instance(h);
     struct vcpu *v;
@@ -1563,7 +1563,7 @@ static int lapic_load_hidden(struct domain *d, hvm_domain_context_t *h)
     return 0;
 }
 
-static int lapic_load_regs(struct domain *d, hvm_domain_context_t *h)
+static int cf_check lapic_load_regs(struct domain *d, hvm_domain_context_t *h)
 {
     unsigned int vcpuid = hvm_load_instance(h);
     struct vcpu *v;
diff --git a/xen/arch/x86/hvm/vpic.c b/xen/arch/x86/hvm/vpic.c
index 5d8ef259b710..b3cafaab8fad 100644
--- a/xen/arch/x86/hvm/vpic.c
+++ b/xen/arch/x86/hvm/vpic.c
@@ -400,7 +400,7 @@ static int cf_check vpic_intercept_elcr_io(
     return X86EMUL_OKAY;
 }
 
-static int vpic_save(struct vcpu *v, hvm_domain_context_t *h)
+static int cf_check vpic_save(struct vcpu *v, hvm_domain_context_t *h)
 {
     struct domain *d = v->domain;
     struct hvm_hw_vpic *s;
@@ -420,7 +420,7 @@ static int vpic_save(struct vcpu *v, hvm_domain_context_t *h)
     return 0;
 }
 
-static int vpic_load(struct domain *d, hvm_domain_context_t *h)
+static int cf_check vpic_load(struct domain *d, hvm_domain_context_t *h)
 {
     struct hvm_hw_vpic *s;
     unsigned int inst = hvm_load_instance(h);
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:16:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:16:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271923.466676 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbDW-0002tc-Ta; Mon, 14 Feb 2022 13:16:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271923.466676; Mon, 14 Feb 2022 13:16:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbDW-0002tR-Pk; Mon, 14 Feb 2022 13:16:34 +0000
Received: by outflank-mailman (input) for mailman id 271923;
 Mon, 14 Feb 2022 13:16:34 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJb4e-0008IH-R5
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:07:25 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0c38c0dc-8d97-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 14:07:23 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0c38c0dc-8d97-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644844042;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=9/V6nzRZ7VtFwWVXXCLQG4zjWKxi0K/Bd1I6aiIEiw4=;
  b=QwfDrd+KjLriMLTRD8JjDXaV2nHw8a8HueWc/3V+NCVzN7JvAH9/z7fH
   0xfqQffuljFd1DVxeL8XN+x7qPNZvzhm4F5Kw3LgdhWuZN5E/Tv0Vi03a
   QaU8WASpp4R7stoivLdlKqBdK854CMoOTenN8KKhlvrtl8zFHtSagrIO8
   Q=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: QoVcGhRi2qO89G0mlfsb3z4fJRpxrsWCEmF6IwH+yljjgQ6tmYJwawULIcQxB9vpa1O+JOptVA
 bKotuYX0SADBqbFVQiOG1r3zg9P2auTZSkj8pSLzYuyz4ZKERtSE20w/ElRbN5G+qa20yMck23
 xNHi1dgvhE8BswwY8rc5rUY6kfcp5nHN6UjGAnWQnhHs5zJ15/ShNok35B++zocRrf9hjy8Yqc
 RJm7x70n8A5ocJ6g0Cygzd7AeePFcmWYHMxkiFy0cNWWVVzTnO2/OEWhQMLOMhtNy7N5UbNLvV
 Pc0x15hKmHTsn35tqjzmlU8z
X-SBRS: 5.1
X-MesageID: 64554436
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:ylsxfa9MNE57VophY7JdDrUDmXmTJUtcMsCJ2f8bNWPcYEJGY0x3z
 mQZDW3UPPuOM2ejLYx/O9u+oExSu8PVz983SgVs/H08E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhFWeIdA970Ug5w7Rg3tYx6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhhx
 vUQr56/az4IM53ristGAiZBHSNXaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguwKKsXxMZxZkXZn1TzDVt4tQIzZQrWM7thdtNs1rp4SQKuCO
 5FHAdZpRC+cMjtyJVsZMc8dwbaUonbUTz5yuE3A8MLb5ECMlVcsgdABKuH9atGMAMlYgEucj
 mbH5HjiRAEXMsSFzjiI+W7qgfXA9R4XQ6pLSuf+rKQzxgTOmCpDU3X6SGdXv9GphG7jQdBQC
 XU19xoJv4dppXOyQNvUCkjQTGG/gjYQXN9ZEusf4Q6Ly7bJ7wvxOlXoXgKte/R96pZoGGVCO
 kuh2oqwWGcx6OH9pWe1q+/MxQ5eLxT5OoPricUsaQIeq+fur4go5v4kZoYySfXl5jEZ9NyZ/
 txrkMTcr+hJ5SLo///ilbwiv95LjsKXJjPZHi2NAgqYAvpRPeZJnbCA51nB9upnJ42EVFSHt
 3Vss5HAsLxRXcHQyXTUG79l8FSVCxGtamO0vLKSN8N5q2TFF4CLIei8Hw2S1G82a51ZKFcFk
 WfYuB9L5Y87AZdZRfQfXm5FMOxzlfKIPY28Dpj8N4MSCrAsJF7v1Hw/Pia4gjGy+HXAZIliY
 P93h+73Vi1EYUmmpRLrL9ogPUgDmHxgmzOJGMyTItbO+eP2WUN5gIwtaDOmBt3VJovd/Fy9H
 w93O5TYxhNBfvf5ZyWLo4cfIUpTdSowBIzsqtwRfemGe1I0FGYkAv7X4LUgZ406wPgFyraWp
 imwCh1C1V7ypXzbMgHWOHptX6ziAMRkpnUhMC1yYVvxgyo/YZyi5bs0focseeV17/RqyPN5F
 qFXe8iJDvlVZC7A/jARMcv0oIB4LUz5jgOSJSu1JjM4esc4FQDO/9bleCrp9TUPUXXr5Zdv/
 eX421qCE5QZRglkAMLHU96Vzgu87SoHheZ/f0rUOd0PKk/ix5dndn7qhfgtLsBSdRianmmG1
 xybCAszrPXWp9Nn68HAgK2Jotv7E+Z6GUYGTWDX4azvaHvf92unh4RBTPyJbXbWU2atoPeuY
 uBczvfdNvwbnQkV79ogQugzla9utcHyo7J6zxh/GCSZZlumPbpsP32a0JQdraZK3LJY5VO7V
 0/nFgO24llV1BcJyGIsGTc=
IronPort-HdrOrdr: A9a23:1Yj2jamh1rf49naRkJgShayoFFjpDfIu3DAbv31ZSRFFG/Fxl6
 iV8sjztCWE8Qr5N0tBpTntAsW9qDbnhPtICOoqTNGftWvdyQiVxehZhOOIqVDd8m/Fh4pgPM
 9bAs9D4bbLbGSS4/yU3ODBKadD/OW6
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="64554436"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v2 16/70] xen: CFI hardening for IPIs
Date: Mon, 14 Feb 2022 12:50:33 +0000
Message-ID: <20220214125127.17985-17-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

Control Flow Integrity schemes use toolchain and optionally hardware support
to help protect against call/jump/return oriented programming attacks.

Use cf_check to annotate function pointer targets for the toolchain.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
 xen/arch/x86/acpi/cpu_idle.c            |  2 +-
 xen/arch/x86/acpi/cpufreq/cpufreq.c     |  8 ++++----
 xen/arch/x86/acpi/cpufreq/powernow.c    |  6 +++---
 xen/arch/x86/acpi/lib.c                 |  2 +-
 xen/arch/x86/cpu/amd.c                  |  2 +-
 xen/arch/x86/cpu/mcheck/amd_nonfatal.c  |  2 +-
 xen/arch/x86/cpu/mcheck/mce.c           |  6 +++---
 xen/arch/x86/cpu/mcheck/mce_intel.c     |  2 +-
 xen/arch/x86/cpu/mcheck/non-fatal.c     |  2 +-
 xen/arch/x86/cpu/microcode/core.c       |  2 +-
 xen/arch/x86/cpu/mtrr/generic.c         |  2 +-
 xen/arch/x86/cpu/mtrr/main.c            |  2 +-
 xen/arch/x86/cpu/mwait-idle.c           |  6 +++---
 xen/arch/x86/cpu/vpmu.c                 |  4 ++--
 xen/arch/x86/guest/xen/xen.c            |  2 +-
 xen/arch/x86/hvm/nestedhvm.c            |  3 +--
 xen/arch/x86/hvm/vmx/vmcs.c             |  2 +-
 xen/arch/x86/include/asm/mtrr.h         |  2 +-
 xen/arch/x86/irq.c                      |  4 ++--
 xen/arch/x86/nmi.c                      |  2 +-
 xen/arch/x86/oprofile/nmi_int.c         | 10 +++++-----
 xen/arch/x86/oprofile/op_model_athlon.c |  2 +-
 xen/arch/x86/platform_hypercall.c       |  4 ++--
 xen/arch/x86/psr.c                      |  2 +-
 xen/arch/x86/shutdown.c                 |  4 ++--
 xen/arch/x86/smp.c                      |  2 +-
 xen/arch/x86/sysctl.c                   |  2 +-
 xen/arch/x86/time.c                     |  8 ++++----
 xen/common/cpu.c                        |  4 ++--
 xen/common/gdbstub.c                    |  2 +-
 xen/common/keyhandler.c                 |  2 +-
 xen/common/page_alloc.c                 |  2 +-
 32 files changed, 53 insertions(+), 54 deletions(-)

diff --git a/xen/arch/x86/acpi/cpu_idle.c b/xen/arch/x86/acpi/cpu_idle.c
index fb47eb9ad68e..22c8bb0c2d94 100644
--- a/xen/arch/x86/acpi/cpu_idle.c
+++ b/xen/arch/x86/acpi/cpu_idle.c
@@ -145,7 +145,7 @@ struct hw_residencies
     uint64_t cc7;
 };
 
-static void do_get_hw_residencies(void *arg)
+static void cf_check do_get_hw_residencies(void *arg)
 {
     struct cpuinfo_x86 *c = &current_cpu_data;
     struct hw_residencies *hw_res = arg;
diff --git a/xen/arch/x86/acpi/cpufreq/cpufreq.c b/xen/arch/x86/acpi/cpufreq/cpufreq.c
index 9510f05340aa..8133c2dd958c 100644
--- a/xen/arch/x86/acpi/cpufreq/cpufreq.c
+++ b/xen/arch/x86/acpi/cpufreq/cpufreq.c
@@ -129,7 +129,7 @@ struct drv_cmd {
     u32 val;
 };
 
-static void do_drv_read(void *drvcmd)
+static void cf_check do_drv_read(void *drvcmd)
 {
     struct drv_cmd *cmd;
 
@@ -148,7 +148,7 @@ static void do_drv_read(void *drvcmd)
     }
 }
 
-static void do_drv_write(void *drvcmd)
+static void cf_check do_drv_write(void *drvcmd)
 {
     struct drv_cmd *cmd;
     uint64_t msr_content;
@@ -244,7 +244,7 @@ struct perf_pair {
 static DEFINE_PER_CPU(struct perf_pair, gov_perf_pair);
 static DEFINE_PER_CPU(struct perf_pair, usr_perf_pair);
 
-static void read_measured_perf_ctrs(void *_readin)
+static void cf_check read_measured_perf_ctrs(void *_readin)
 {
     struct perf_pair *readin = _readin;
 
@@ -340,7 +340,7 @@ static unsigned int get_cur_freq_on_cpu(unsigned int cpu)
     return extract_freq(get_cur_val(cpumask_of(cpu)), data);
 }
 
-static void feature_detect(void *info)
+static void cf_check feature_detect(void *info)
 {
     struct cpufreq_policy *policy = info;
     unsigned int eax;
diff --git a/xen/arch/x86/acpi/cpufreq/powernow.c b/xen/arch/x86/acpi/cpufreq/powernow.c
index da8fc40b9a6f..ca71ecf72d67 100644
--- a/xen/arch/x86/acpi/cpufreq/powernow.c
+++ b/xen/arch/x86/acpi/cpufreq/powernow.c
@@ -44,12 +44,12 @@
 
 #define ARCH_CPU_FLAG_RESUME	1
 
-static void transition_pstate(void *pstate)
+static void cf_check transition_pstate(void *pstate)
 {
     wrmsrl(MSR_PSTATE_CTRL, *(unsigned int *)pstate);
 }
 
-static void update_cpb(void *data)
+static void cf_check update_cpb(void *data)
 {
     struct cpufreq_policy *policy = data;
 
@@ -165,7 +165,7 @@ struct amd_cpu_data {
     u32 max_hw_pstate;
 };
 
-static void get_cpu_data(void *arg)
+static void cf_check get_cpu_data(void *arg)
 {
     struct amd_cpu_data *data = arg;
     struct processor_performance *perf = data->perf;
diff --git a/xen/arch/x86/acpi/lib.c b/xen/arch/x86/acpi/lib.c
index b66e7338e74d..43831b92d132 100644
--- a/xen/arch/x86/acpi/lib.c
+++ b/xen/arch/x86/acpi/lib.c
@@ -99,7 +99,7 @@ unsigned int acpi_get_processor_id(unsigned int cpu)
 	return INVALID_ACPIID;
 }
 
-static void get_mwait_ecx(void *info)
+static void cf_check get_mwait_ecx(void *info)
 {
 	*(u32 *)info = cpuid_ecx(CPUID_MWAIT_LEAF);
 }
diff --git a/xen/arch/x86/cpu/amd.c b/xen/arch/x86/cpu/amd.c
index a8e37dbb1f5c..2d18223f20ef 100644
--- a/xen/arch/x86/cpu/amd.c
+++ b/xen/arch/x86/cpu/amd.c
@@ -430,7 +430,7 @@ static void disable_c1_ramping(void)
 	}
 }
 
-static void disable_c1e(void *unused)
+static void cf_check disable_c1e(void *unused)
 {
 	uint64_t msr_content;
 
diff --git a/xen/arch/x86/cpu/mcheck/amd_nonfatal.c b/xen/arch/x86/cpu/mcheck/amd_nonfatal.c
index da0bf85f0223..efb45c931e1f 100644
--- a/xen/arch/x86/cpu/mcheck/amd_nonfatal.c
+++ b/xen/arch/x86/cpu/mcheck/amd_nonfatal.c
@@ -79,7 +79,7 @@ static int variable_period = 1;
  * Collects information of correctable errors and notifies
  * Dom0 via an event.
  */
-static void mce_amd_checkregs(void *info)
+static void cf_check mce_amd_checkregs(void *info)
 {
 	mctelem_cookie_t mctc;
 	struct mca_summary bs;
diff --git a/xen/arch/x86/cpu/mcheck/mce.c b/xen/arch/x86/cpu/mcheck/mce.c
index a449fa0424ce..43f6c8471a90 100644
--- a/xen/arch/x86/cpu/mcheck/mce.c
+++ b/xen/arch/x86/cpu/mcheck/mce.c
@@ -961,7 +961,7 @@ void x86_mcinfo_dump(struct mc_info *mi)
     } while ( 1 );
 }
 
-static void do_mc_get_cpu_info(void *v)
+static void cf_check do_mc_get_cpu_info(void *v)
 {
     int cpu = smp_processor_id();
     int cindex, cpn;
@@ -1242,7 +1242,7 @@ static void x86_mc_hwcr_wren_restore(uint64_t hwcr)
         wrmsrl(MSR_K8_HWCR, hwcr);
 }
 
-static void x86_mc_msrinject(void *data)
+static void cf_check x86_mc_msrinject(void *data)
 {
     struct xen_mc_msrinject *mci = data;
     struct mcinfo_msr *msr;
@@ -1274,7 +1274,7 @@ static void x86_mc_msrinject(void *data)
 }
 
 /*ARGSUSED*/
-static void x86_mc_mceinject(void *data)
+static void cf_check x86_mc_mceinject(void *data)
 {
     printk("Simulating #MC on cpu %d\n", smp_processor_id());
     __asm__ __volatile__("int $0x12");
diff --git a/xen/arch/x86/cpu/mcheck/mce_intel.c b/xen/arch/x86/cpu/mcheck/mce_intel.c
index b6da8262e662..a691e10bdcd6 100644
--- a/xen/arch/x86/cpu/mcheck/mce_intel.c
+++ b/xen/arch/x86/cpu/mcheck/mce_intel.c
@@ -599,7 +599,7 @@ static void mce_set_owner(void)
     cmci_discover();
 }
 
-static void __cpu_mcheck_distribute_cmci(void *unused)
+static void cf_check __cpu_mcheck_distribute_cmci(void *unused)
 {
     cmci_discover();
 }
diff --git a/xen/arch/x86/cpu/mcheck/non-fatal.c b/xen/arch/x86/cpu/mcheck/non-fatal.c
index f7e411c0870e..1c0c32ba0821 100644
--- a/xen/arch/x86/cpu/mcheck/non-fatal.c
+++ b/xen/arch/x86/cpu/mcheck/non-fatal.c
@@ -32,7 +32,7 @@ static uint64_t period = MCE_PERIOD;
 static int adjust = 0;
 static int variable_period = 1;
 
-static void mce_checkregs (void *info)
+static void cf_check mce_checkregs(void *info)
 {
 	mctelem_cookie_t mctc;
 	struct mca_summary bs;
diff --git a/xen/arch/x86/cpu/microcode/core.c b/xen/arch/x86/cpu/microcode/core.c
index 9631042190ab..841364208053 100644
--- a/xen/arch/x86/cpu/microcode/core.c
+++ b/xen/arch/x86/cpu/microcode/core.c
@@ -533,7 +533,7 @@ static int control_thread_fn(const struct microcode_patch *patch)
     return ret;
 }
 
-static int do_microcode_update(void *patch)
+static int cf_check do_microcode_update(void *patch)
 {
     unsigned int cpu = smp_processor_id();
     int ret;
diff --git a/xen/arch/x86/cpu/mtrr/generic.c b/xen/arch/x86/cpu/mtrr/generic.c
index 883e3398ff71..7cf4cd01f3f6 100644
--- a/xen/arch/x86/cpu/mtrr/generic.c
+++ b/xen/arch/x86/cpu/mtrr/generic.c
@@ -84,7 +84,7 @@ bool is_var_mtrr_overlapped(const struct mtrr_state *m)
     return false;
 }
 
-void mtrr_save_fixed_ranges(void *info)
+void cf_check mtrr_save_fixed_ranges(void *info)
 {
 	get_fixed_ranges(mtrr_state.fixed_ranges);
 }
diff --git a/xen/arch/x86/cpu/mtrr/main.c b/xen/arch/x86/cpu/mtrr/main.c
index 428133100d46..4e01c8d6f9df 100644
--- a/xen/arch/x86/cpu/mtrr/main.c
+++ b/xen/arch/x86/cpu/mtrr/main.c
@@ -131,7 +131,7 @@ struct set_mtrr_data {
  */
 int hold_mtrr_updates_on_aps;
 
-static void ipi_handler(void *info)
+static void cf_check ipi_handler(void *info)
 /*  [SUMMARY] Synchronisation handler. Executed by "other" CPUs.
     [RETURNS] Nothing.
 */
diff --git a/xen/arch/x86/cpu/mwait-idle.c b/xen/arch/x86/cpu/mwait-idle.c
index fe1b7af25f01..927ce1b67aa5 100644
--- a/xen/arch/x86/cpu/mwait-idle.c
+++ b/xen/arch/x86/cpu/mwait-idle.c
@@ -877,7 +877,7 @@ static void mwait_idle(void)
 		cpuidle_current_governor->reflect(power);
 }
 
-static void auto_demotion_disable(void *dummy)
+static void cf_check auto_demotion_disable(void *dummy)
 {
 	u64 msr_bits;
 
@@ -886,13 +886,13 @@ static void auto_demotion_disable(void *dummy)
 	wrmsrl(MSR_PKG_CST_CONFIG_CONTROL, msr_bits);
 }
 
-static void byt_auto_demotion_disable(void *dummy)
+static void cf_check byt_auto_demotion_disable(void *dummy)
 {
 	wrmsrl(MSR_CC6_DEMOTION_POLICY_CONFIG, 0);
 	wrmsrl(MSR_MC6_DEMOTION_POLICY_CONFIG, 0);
 }
 
-static void c1e_promotion_disable(void *dummy)
+static void cf_check c1e_promotion_disable(void *dummy)
 {
 	u64 msr_bits;
 
diff --git a/xen/arch/x86/cpu/vpmu.c b/xen/arch/x86/cpu/vpmu.c
index df3c9201b2c1..4fedc7c57012 100644
--- a/xen/arch/x86/cpu/vpmu.c
+++ b/xen/arch/x86/cpu/vpmu.c
@@ -335,7 +335,7 @@ void vpmu_do_interrupt(struct cpu_user_regs *regs)
 #endif
 }
 
-static void vpmu_save_force(void *arg)
+static void cf_check vpmu_save_force(void *arg)
 {
     struct vcpu *v = arg;
     struct vpmu_struct *vpmu = vcpu_vpmu(v);
@@ -528,7 +528,7 @@ void vpmu_initialise(struct vcpu *v)
         put_vpmu(v);
 }
 
-static void vpmu_clear_last(void *arg)
+static void cf_check vpmu_clear_last(void *arg)
 {
     if ( this_cpu(last_vcpu) == arg )
         this_cpu(last_vcpu) = NULL;
diff --git a/xen/arch/x86/guest/xen/xen.c b/xen/arch/x86/guest/xen/xen.c
index 2ff63d370a8a..b2aa3a009b4a 100644
--- a/xen/arch/x86/guest/xen/xen.c
+++ b/xen/arch/x86/guest/xen/xen.c
@@ -289,7 +289,7 @@ int xg_free_unused_page(mfn_t mfn)
     return rangeset_remove_range(mem, mfn_x(mfn), mfn_x(mfn));
 }
 
-static void ap_resume(void *unused)
+static void cf_check ap_resume(void *unused)
 {
     BUG_ON(map_vcpuinfo());
     BUG_ON(init_evtchn());
diff --git a/xen/arch/x86/hvm/nestedhvm.c b/xen/arch/x86/hvm/nestedhvm.c
index 23516884482b..58370190ffc9 100644
--- a/xen/arch/x86/hvm/nestedhvm.c
+++ b/xen/arch/x86/hvm/nestedhvm.c
@@ -82,8 +82,7 @@ nestedhvm_vcpu_destroy(struct vcpu *v)
     alternative_vcall(hvm_funcs.nhvm_vcpu_destroy, v);
 }
 
-static void
-nestedhvm_flushtlb_ipi(void *info)
+static void cf_check nestedhvm_flushtlb_ipi(void *info)
 {
     struct vcpu *v = current;
     struct domain *d = info;
diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c
index f72a7db0453d..2b6bafe9d542 100644
--- a/xen/arch/x86/hvm/vmx/vmcs.c
+++ b/xen/arch/x86/hvm/vmx/vmcs.c
@@ -589,7 +589,7 @@ static void vmx_free_vmcs(paddr_t pa)
     free_domheap_page(maddr_to_page(pa));
 }
 
-static void __vmx_clear_vmcs(void *info)
+static void cf_check __vmx_clear_vmcs(void *info)
 {
     struct vcpu *v = info;
     struct vmx_vcpu *vmx = &v->arch.hvm.vmx;
diff --git a/xen/arch/x86/include/asm/mtrr.h b/xen/arch/x86/include/asm/mtrr.h
index e0fd1005ce72..7733800b798f 100644
--- a/xen/arch/x86/include/asm/mtrr.h
+++ b/xen/arch/x86/include/asm/mtrr.h
@@ -64,7 +64,7 @@ struct mtrr_state {
 };
 extern struct mtrr_state mtrr_state;
 
-extern void mtrr_save_fixed_ranges(void *);
+extern void cf_check mtrr_save_fixed_ranges(void *);
 extern void mtrr_save_state(void);
 extern int mtrr_add(unsigned long base, unsigned long size,
                     unsigned int type, char increment);
diff --git a/xen/arch/x86/irq.c b/xen/arch/x86/irq.c
index f9c808455535..d9bd355113d7 100644
--- a/xen/arch/x86/irq.c
+++ b/xen/arch/x86/irq.c
@@ -1127,7 +1127,7 @@ static inline void clear_pirq_eoi(struct domain *d, unsigned int irq)
     }
 }
 
-static void set_eoi_ready(void *data);
+static void cf_check set_eoi_ready(void *data);
 
 static void cf_check irq_guest_eoi_timer_fn(void *data)
 {
@@ -1398,7 +1398,7 @@ static void __set_eoi_ready(const struct irq_desc *desc)
 }
 
 /* Mark specified IRQ as ready-for-EOI (if it really is) and attempt to EOI. */
-static void set_eoi_ready(void *data)
+static void cf_check set_eoi_ready(void *data)
 {
     struct irq_desc *desc = data;
 
diff --git a/xen/arch/x86/nmi.c b/xen/arch/x86/nmi.c
index c8ae4a5d7460..e20d1393c881 100644
--- a/xen/arch/x86/nmi.c
+++ b/xen/arch/x86/nmi.c
@@ -149,7 +149,7 @@ int nmi_active;
     (P4_CCCR_OVF_PMI0|P4_CCCR_THRESHOLD(15)|P4_CCCR_COMPLEMENT| \
      P4_CCCR_COMPARE|P4_CCCR_REQUIRED|P4_CCCR_ESCR_SELECT(4)|P4_CCCR_ENABLE)
 
-static void __init wait_for_nmis(void *p)
+static void __init cf_check wait_for_nmis(void *p)
 {
     unsigned int start_count = this_cpu(nmi_count);
     unsigned long ticks = 10 * 1000 * cpu_khz / nmi_hz;
diff --git a/xen/arch/x86/oprofile/nmi_int.c b/xen/arch/x86/oprofile/nmi_int.c
index ba9c4b9804ca..6ebe20bd1d3e 100644
--- a/xen/arch/x86/oprofile/nmi_int.c
+++ b/xen/arch/x86/oprofile/nmi_int.c
@@ -131,7 +131,7 @@ static void nmi_cpu_save_registers(struct op_msrs *msrs)
 }
 
 
-static void nmi_save_registers(void * dummy)
+static void cf_check nmi_save_registers(void *dummy)
 {
 	int cpu = smp_processor_id();
 	struct op_msrs * msrs = &cpu_msrs[cpu];
@@ -179,7 +179,7 @@ static int allocate_msrs(void)
 }
 
 
-static void nmi_cpu_setup(void * dummy)
+static void cf_check nmi_cpu_setup(void *dummy)
 {
 	int cpu = smp_processor_id();
 	struct op_msrs * msrs = &cpu_msrs[cpu];
@@ -245,7 +245,7 @@ static void nmi_restore_registers(struct op_msrs * msrs)
 }
 
 
-static void nmi_cpu_shutdown(void * dummy)
+static void cf_check nmi_cpu_shutdown(void *dummy)
 {
 	int cpu = smp_processor_id();
 	struct op_msrs * msrs = &cpu_msrs[cpu];
@@ -261,7 +261,7 @@ void nmi_release_counters(void)
 }
 
 
-static void nmi_cpu_start(void * dummy)
+static void cf_check nmi_cpu_start(void *dummy)
 {
 	int cpu = smp_processor_id();
 	struct op_msrs const * msrs = &cpu_msrs[cpu];
@@ -278,7 +278,7 @@ int nmi_start(void)
 }
 
 
-static void nmi_cpu_stop(void * dummy)
+static void cf_check nmi_cpu_stop(void *dummy)
 {
 	unsigned int v;
 	int cpu = smp_processor_id();
diff --git a/xen/arch/x86/oprofile/op_model_athlon.c b/xen/arch/x86/oprofile/op_model_athlon.c
index ee6eb0ecae79..2177f02946e2 100644
--- a/xen/arch/x86/oprofile/op_model_athlon.c
+++ b/xen/arch/x86/oprofile/op_model_athlon.c
@@ -436,7 +436,7 @@ static void athlon_stop(struct op_msrs const * const msrs)
 #define APIC_EILVT_MSG_NMI              0x4
 #define APIC_EILVT_LVTOFF_IBS           1
 #define APIC_EILVTn(n)                  (0x500 + 0x10 * n)
-static inline void __init init_ibs_nmi_per_cpu(void *arg)
+static inline void __init cf_check init_ibs_nmi_per_cpu(void *arg)
 {
 	unsigned long reg;
 
diff --git a/xen/arch/x86/platform_hypercall.c b/xen/arch/x86/platform_hypercall.c
index f5d7adc1e802..b91ccff58900 100644
--- a/xen/arch/x86/platform_hypercall.c
+++ b/xen/arch/x86/platform_hypercall.c
@@ -47,7 +47,7 @@ struct resource_access {
 
 long cf_check cpu_frequency_change_helper(void *);
 void check_resource_access(struct resource_access *);
-void resource_access(void *);
+void cf_check resource_access(void *);
 
 #ifndef COMPAT
 typedef long ret_t;
@@ -149,7 +149,7 @@ void check_resource_access(struct resource_access *ra)
     ra->nr_done = i;
 }
 
-void resource_access(void *info)
+void cf_check resource_access(void *info)
 {
     struct resource_access *ra = info;
     unsigned int i;
diff --git a/xen/arch/x86/psr.c b/xen/arch/x86/psr.c
index 5b9991bd5b12..6c9cabf3843d 100644
--- a/xen/arch/x86/psr.c
+++ b/xen/arch/x86/psr.c
@@ -1247,7 +1247,7 @@ struct cos_write_info
     const uint32_t *val;
 };
 
-static void do_write_psr_msrs(void *data)
+static void cf_check do_write_psr_msrs(void *data)
 {
     const struct cos_write_info *info = data;
     unsigned int i, index, cos = info->cos;
diff --git a/xen/arch/x86/shutdown.c b/xen/arch/x86/shutdown.c
index ad3e3a76916f..30985d36a612 100644
--- a/xen/arch/x86/shutdown.c
+++ b/xen/arch/x86/shutdown.c
@@ -118,7 +118,7 @@ static inline void kb_wait(void)
             break;
 }
 
-static void noreturn __machine_halt(void *unused)
+static void noreturn cf_check __machine_halt(void *unused)
 {
     local_irq_disable();
 
@@ -548,7 +548,7 @@ static int __init cf_check reboot_init(void)
 }
 __initcall(reboot_init);
 
-static void noreturn __machine_restart(void *pdelay)
+static void cf_check noreturn __machine_restart(void *pdelay)
 {
     machine_restart(*(unsigned int *)pdelay);
 }
diff --git a/xen/arch/x86/smp.c b/xen/arch/x86/smp.c
index f4952a6bf9a5..f6fd7f95df58 100644
--- a/xen/arch/x86/smp.c
+++ b/xen/arch/x86/smp.c
@@ -339,7 +339,7 @@ void __stop_this_cpu(void)
     cpumask_clear_cpu(smp_processor_id(), &cpu_online_map);
 }
 
-static void stop_this_cpu(void *dummy)
+static void cf_check stop_this_cpu(void *dummy)
 {
     __stop_this_cpu();
     for ( ; ; )
diff --git a/xen/arch/x86/sysctl.c b/xen/arch/x86/sysctl.c
index 1772f51f8f6e..f82abc248885 100644
--- a/xen/arch/x86/sysctl.c
+++ b/xen/arch/x86/sysctl.c
@@ -69,7 +69,7 @@ struct l3_cache_info {
     unsigned long size;
 };
 
-static void l3_cache_get(void *arg)
+static void cf_check l3_cache_get(void *arg)
 {
     struct cpuid4_info info;
     struct l3_cache_info *l3_info = arg;
diff --git a/xen/arch/x86/time.c b/xen/arch/x86/time.c
index fac97023bf10..b444d6344e79 100644
--- a/xen/arch/x86/time.c
+++ b/xen/arch/x86/time.c
@@ -1661,7 +1661,7 @@ static void check_tsc_warp(unsigned long tsc_khz, unsigned long *max_warp)
 static unsigned long tsc_max_warp, tsc_check_count;
 static cpumask_t tsc_check_cpumask;
 
-static void tsc_check_slave(void *unused)
+static void cf_check tsc_check_slave(void *unused)
 {
     unsigned int cpu = smp_processor_id();
     local_irq_disable();
@@ -1809,7 +1809,7 @@ static void time_calibration_tsc_rendezvous(void *_r)
 }
 
 /* Ordinary rendezvous function which does not modify TSC values. */
-static void time_calibration_std_rendezvous(void *_r)
+static void cf_check time_calibration_std_rendezvous(void *_r)
 {
     struct calibration_rendezvous *r = _r;
     unsigned int total_cpus = cpumask_weight(&r->cpu_calibration_map);
@@ -1840,7 +1840,7 @@ static void time_calibration_std_rendezvous(void *_r)
  * Rendezvous function used when clocksource is TSC and
  * no CPU hotplug will be performed.
  */
-static void time_calibration_nop_rendezvous(void *rv)
+static void cf_check time_calibration_nop_rendezvous(void *rv)
 {
     const struct calibration_rendezvous *r = rv;
     struct cpu_time_stamp *c = &this_cpu(cpu_calibration);
@@ -2032,7 +2032,7 @@ static void __init tsc_check_writability(void)
     disable_tsc_sync = true;
 }
 
-static void __init reset_percpu_time(void *unused)
+static void __init cf_check reset_percpu_time(void *unused)
 {
     struct cpu_time *t = &this_cpu(cpu_time);
 
diff --git a/xen/common/cpu.c b/xen/common/cpu.c
index 1f976db0a51f..b0b63cdb3638 100644
--- a/xen/common/cpu.c
+++ b/xen/common/cpu.c
@@ -84,13 +84,13 @@ static int cpu_notifier_call_chain(unsigned int cpu, unsigned long action,
     return ret;
 }
 
-static void _take_cpu_down(void *unused)
+static void cf_check _take_cpu_down(void *unused)
 {
     cpu_notifier_call_chain(smp_processor_id(), CPU_DYING, NULL, true);
     __cpu_disable();
 }
 
-static int take_cpu_down(void *arg)
+static int cf_check take_cpu_down(void *arg)
 {
     _take_cpu_down(arg);
     return 0;
diff --git a/xen/common/gdbstub.c b/xen/common/gdbstub.c
index 99bfd9a654c9..079c3ca9616a 100644
--- a/xen/common/gdbstub.c
+++ b/xen/common/gdbstub.c
@@ -660,7 +660,7 @@ static int __init cf_check initialise_gdb(void)
 }
 presmp_initcall(initialise_gdb);
 
-static void gdb_pause_this_cpu(void *unused)
+static void cf_check gdb_pause_this_cpu(void *unused)
 {
     unsigned long flags;
 
diff --git a/xen/common/keyhandler.c b/xen/common/keyhandler.c
index 8b9f37837162..2c916d528ab2 100644
--- a/xen/common/keyhandler.c
+++ b/xen/common/keyhandler.c
@@ -360,7 +360,7 @@ static cpumask_t read_clocks_cpumask;
 static DEFINE_PER_CPU(s_time_t, read_clocks_time);
 static DEFINE_PER_CPU(u64, read_cycles_time);
 
-static void read_clocks_slave(void *unused)
+static void cf_check read_clocks_slave(void *unused)
 {
     unsigned int cpu = smp_processor_id();
     local_irq_disable();
diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c
index 561e238d2d6a..827617502e35 100644
--- a/xen/common/page_alloc.c
+++ b/xen/common/page_alloc.c
@@ -1898,7 +1898,7 @@ void __init end_boot_allocator(void)
     printk("\n");
 }
 
-static void __init smp_scrub_heap_pages(void *data)
+static void __init cf_check smp_scrub_heap_pages(void *data)
 {
     unsigned long mfn, start, end;
     struct page_info *pg;
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:16:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:16:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271930.466687 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbDb-0003Nf-D0; Mon, 14 Feb 2022 13:16:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271930.466687; Mon, 14 Feb 2022 13:16:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbDb-0003NT-9E; Mon, 14 Feb 2022 13:16:39 +0000
Received: by outflank-mailman (input) for mailman id 271930;
 Mon, 14 Feb 2022 13:16:37 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJb3m-0008IH-0Q
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:06:30 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id eb2b0ec9-8d96-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 14:06:27 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: eb2b0ec9-8d96-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644843987;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=GWauAq5Hi4t0sVZGrU3/q6tMpZvbMlc+nyZ6uD+AkRI=;
  b=Ay0CCB9Kz/uvcRFfhiLSB3FuZDpAMadFy6IrAJFC8UMVbsMpgeXyMube
   ZvsvsJb5xhRogwpn4PXuGdH878DFwAvEvZergm9mxrIiwf5bHIdV29+QM
   YNeBpuFUM8hpBErbvUWgoTOWR/IzkvWNxnkTwFim7DqRGu09B2XT9xQR0
   0=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: o4lSuCzDEusyVfSInkyFoHW4DgsPAKeUwFYa6tsXxSB0jgSnx/3zwHDm161r/7oMdBA0f212v0
 0sSY+qJAZRTzrax9S5ujZSAWaWtZjKM4PLDUDnejA6F6izTMDj3EwXkIHONTE4NMkMIW/j28Wl
 6/zwDaGnHAzxYHxsC4g65ZOyGUyBbCEVnGj+PD6DsqwP4QgXGwbtqXUlzBuy1SpmQ94IPUW/By
 oBvLqf4ZXIK5gajkxkkbu49X6G5shjOQnawJA+LofFqUMjAMqU+RtZt/s3uvNe2Wh5IJATPTGc
 yFnRCnF5ImrkU+N539g2xh3h
X-SBRS: 5.1
X-MesageID: 64050683
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Rn4lV65YTRTMTU2Ztge6hQxRtCHAchMFZxGqfqrLsTDasY5as4F+v
 mtJDG+HOvaPNzOjc40kbtyy/E0O68WAzt8yTAI+rygwHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FV8MpBsJ00o5wbZj29Iw2LBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z9
 /hXmMXrYiYSEaSVu8MhXzgBOCNmMvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALBc/nJo4A/FpnyinUF60OSpHfWaTao9Rf2V/cg+gQQa6DP
 5RJMlKDajyHTCxMHwoGMakDp7nxpynmVj8fpVaa8P9fD2/7k1UqjemF3MDuUsyHQ4BZk1iVo
 krC/n/lGVcKOdqH0z2H/3mwwOjVkkvGtJk6TePisKQw2RvKmzJVWEZ+uUaHTeeRtWOkdosEA
 G0v1SN3jo8O+G3yZdvlUEjtyJKbhSI0V91VGuw8zQiCzKvI/gqUblQ5oi59hM8O75FvG2Fzv
 rOdt5awXGE07uXJIZ6I3urM9VuP1T4pwXjujMPuZS8M+JHdrY46lXojpf4zQffu3rUZ9dwdq
 g1mTRTSZZ1O16bnNI3hpDgrZg5AQbCTEGYICv3/BD7N0++ATNfNi3aUwVba9+1cC42SU0OMu
 nMJ8+DHsrxSUsHdyXHVGb5XdF1M2xpiGGeC6WOD4rF7r2j9k5JdVdw4DM5CyLdBbZ9fJG6Bj
 L77sgJN/p5DVEZGnocsC79d//8ClPC6ffy8D6i8RoMXPvBZKV/WlAkzNBX49z28zyARfVQXZ
 M7znTCEVi1BV8yKDVOeGo8g7FPc7n5ilD2DHcihl3xKE9O2PRaodFvMC3PWBshR0U9OiF+Nm
 zqGH8fVmRhZTsPkZSzbrdwaIVwQdCBpDpHqsc1HMOWEJ1M+Sm0mDvbQx5InepBkwPsJxruZo
 CnlVx8K0kf7iF3GNR6ONiJpZoTwUMsttnk8JyEtYwqlgiBxfYa14a4DXJIrZr17pvd7xPt5Q
 qBdKcWNC/hCUBrd/DEZYcWvpYBubk3z1wmPIzCkcH40eJs5H17F/drtfw3O8igSD3Xo6Zti8
 uP4jg6CGMgNXQVvCsrSecmD9VLpsChPgv92UmvJPsJXJBfm/r91JnGjlfQwOcwNd0nOn2PIy
 waMDB4EjuDRuItposLRjKWJoor1QetzGk1WQzvS4bqsbHSI+2OixclLUfqSfCCbX2Txof3wa
 eJQxvD6EfsGgFcV7NYsT+c1lfozt4n1urtX7gV4B3GaPV2kB4RpLmSCwcQS5LZGwaVUuFfuV
 0+CkjWA1W5l5C8x/IYtGTcY
IronPort-HdrOrdr: A9a23:uUxSV6GC3MTHEZd/pLqE6seALOsnbusQ8zAXP0AYc3Jom62j5r
 mTdZsgtSMc5Ax8ZJhko6HkBEDiewK7yXcW2/hzAV7KZmCP0wHEEGgh1/qH/9SJIVyYygc378
 ZdmsZFZ+EYdWIK7/rH3A==
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="64050683"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v2 34/70] x86/emul: CFI hardening
Date: Mon, 14 Feb 2022 12:50:51 +0000
Message-ID: <20220214125127.17985-35-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

Control Flow Integrity schemes use toolchain and optionally hardware support
to help protect against call/jump/return oriented programming attacks.

Use cf_check to annotate function pointer targets for the toolchain.

pv_emul_is_mem_write() is only used in a single file.  Having it as a static
inline is pointless because it can't be inlined to begin with.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
v2:
 * Correct details in commit message.
---
 xen/arch/x86/hvm/emulate.c             | 72 +++++++++++++++++-----------------
 xen/arch/x86/hvm/hvm.c                 |  8 ++--
 xen/arch/x86/hvm/svm/svm.c             |  4 +-
 xen/arch/x86/include/asm/hvm/emulate.h |  8 ++--
 xen/arch/x86/include/asm/mm.h          | 16 +++-----
 xen/arch/x86/mm.c                      |  4 +-
 xen/arch/x86/mm/shadow/hvm.c           |  8 ++--
 xen/arch/x86/pv/emul-gate-op.c         |  9 +++--
 xen/arch/x86/pv/emul-priv-op.c         | 64 +++++++++++++++---------------
 xen/arch/x86/pv/emulate.h              |  7 ----
 xen/arch/x86/pv/ro-page-fault.c        | 31 +++++++++------
 xen/arch/x86/x86_emulate.c             | 21 +++++-----
 xen/arch/x86/x86_emulate/x86_emulate.c | 10 ++---
 xen/arch/x86/x86_emulate/x86_emulate.h | 33 ++++++++--------
 14 files changed, 148 insertions(+), 147 deletions(-)

diff --git a/xen/arch/x86/hvm/emulate.c b/xen/arch/x86/hvm/emulate.c
index 39dac7fd9d6d..e8d510e0be91 100644
--- a/xen/arch/x86/hvm/emulate.c
+++ b/xen/arch/x86/hvm/emulate.c
@@ -1272,7 +1272,7 @@ static int __hvmemul_read(
     return linear_read(addr, bytes, p_data, pfec, hvmemul_ctxt);
 }
 
-static int hvmemul_read(
+static int cf_check hvmemul_read(
     enum x86_segment seg,
     unsigned long offset,
     void *p_data,
@@ -1290,7 +1290,7 @@ static int hvmemul_read(
         container_of(ctxt, struct hvm_emulate_ctxt, ctxt));
 }
 
-int hvmemul_insn_fetch(
+int cf_check hvmemul_insn_fetch(
     unsigned long offset,
     void *p_data,
     unsigned int bytes,
@@ -1336,7 +1336,7 @@ int hvmemul_insn_fetch(
     return X86EMUL_OKAY;
 }
 
-static int hvmemul_write(
+static int cf_check hvmemul_write(
     enum x86_segment seg,
     unsigned long offset,
     void *p_data,
@@ -1384,7 +1384,7 @@ static int hvmemul_write(
     return X86EMUL_OKAY;
 }
 
-static int hvmemul_rmw(
+static int cf_check hvmemul_rmw(
     enum x86_segment seg,
     unsigned long offset,
     unsigned int bytes,
@@ -1437,7 +1437,7 @@ static int hvmemul_rmw(
     return rc;
 }
 
-static int hvmemul_blk(
+static int cf_check hvmemul_blk(
     enum x86_segment seg,
     unsigned long offset,
     void *p_data,
@@ -1478,7 +1478,7 @@ static int hvmemul_blk(
     return rc;
 }
 
-static int hvmemul_write_discard(
+static int cf_check hvmemul_write_discard(
     enum x86_segment seg,
     unsigned long offset,
     void *p_data,
@@ -1489,7 +1489,7 @@ static int hvmemul_write_discard(
     return X86EMUL_OKAY;
 }
 
-static int hvmemul_rep_ins_discard(
+static int cf_check hvmemul_rep_ins_discard(
     uint16_t src_port,
     enum x86_segment dst_seg,
     unsigned long dst_offset,
@@ -1500,7 +1500,7 @@ static int hvmemul_rep_ins_discard(
     return X86EMUL_OKAY;
 }
 
-static int hvmemul_rep_movs_discard(
+static int cf_check hvmemul_rep_movs_discard(
    enum x86_segment src_seg,
    unsigned long src_offset,
    enum x86_segment dst_seg,
@@ -1512,7 +1512,7 @@ static int hvmemul_rep_movs_discard(
     return X86EMUL_OKAY;
 }
 
-static int hvmemul_rep_stos_discard(
+static int cf_check hvmemul_rep_stos_discard(
     void *p_data,
     enum x86_segment seg,
     unsigned long offset,
@@ -1523,7 +1523,7 @@ static int hvmemul_rep_stos_discard(
     return X86EMUL_OKAY;
 }
 
-static int hvmemul_rep_outs_discard(
+static int cf_check hvmemul_rep_outs_discard(
     enum x86_segment src_seg,
     unsigned long src_offset,
     uint16_t dst_port,
@@ -1534,7 +1534,7 @@ static int hvmemul_rep_outs_discard(
     return X86EMUL_OKAY;
 }
 
-static int hvmemul_cmpxchg_discard(
+static int cf_check hvmemul_cmpxchg_discard(
     enum x86_segment seg,
     unsigned long offset,
     void *p_old,
@@ -1546,7 +1546,7 @@ static int hvmemul_cmpxchg_discard(
     return X86EMUL_OKAY;
 }
 
-static int hvmemul_read_io_discard(
+static int cf_check hvmemul_read_io_discard(
     unsigned int port,
     unsigned int bytes,
     unsigned long *val,
@@ -1555,7 +1555,7 @@ static int hvmemul_read_io_discard(
     return X86EMUL_OKAY;
 }
 
-static int hvmemul_write_io_discard(
+static int cf_check hvmemul_write_io_discard(
     unsigned int port,
     unsigned int bytes,
     unsigned long val,
@@ -1564,7 +1564,7 @@ static int hvmemul_write_io_discard(
     return X86EMUL_OKAY;
 }
 
-static int hvmemul_write_msr_discard(
+static int cf_check hvmemul_write_msr_discard(
     unsigned int reg,
     uint64_t val,
     struct x86_emulate_ctxt *ctxt)
@@ -1572,7 +1572,7 @@ static int hvmemul_write_msr_discard(
     return X86EMUL_OKAY;
 }
 
-static int hvmemul_cache_op_discard(
+static int cf_check hvmemul_cache_op_discard(
     enum x86emul_cache_op op,
     enum x86_segment seg,
     unsigned long offset,
@@ -1581,7 +1581,7 @@ static int hvmemul_cache_op_discard(
     return X86EMUL_OKAY;
 }
 
-static int hvmemul_cmpxchg(
+static int cf_check hvmemul_cmpxchg(
     enum x86_segment seg,
     unsigned long offset,
     void *p_old,
@@ -1675,7 +1675,7 @@ static int hvmemul_cmpxchg(
     return rc;
 }
 
-static int hvmemul_validate(
+static int cf_check hvmemul_validate(
     const struct x86_emulate_state *state,
     struct x86_emulate_ctxt *ctxt)
 {
@@ -1688,7 +1688,7 @@ static int hvmemul_validate(
            ? X86EMUL_OKAY : X86EMUL_UNHANDLEABLE;
 }
 
-static int hvmemul_rep_ins(
+static int cf_check hvmemul_rep_ins(
     uint16_t src_port,
     enum x86_segment dst_seg,
     unsigned long dst_offset,
@@ -1766,7 +1766,7 @@ static int hvmemul_rep_outs_set_context(
     return rc;
 }
 
-static int hvmemul_rep_outs(
+static int cf_check hvmemul_rep_outs(
     enum x86_segment src_seg,
     unsigned long src_offset,
     uint16_t dst_port,
@@ -1807,7 +1807,7 @@ static int hvmemul_rep_outs(
                                !!(ctxt->regs->eflags & X86_EFLAGS_DF), gpa);
 }
 
-static int hvmemul_rep_movs(
+static int cf_check hvmemul_rep_movs(
    enum x86_segment src_seg,
    unsigned long src_offset,
    enum x86_segment dst_seg,
@@ -1977,7 +1977,7 @@ static int hvmemul_rep_movs(
     return X86EMUL_UNHANDLEABLE;
 }
 
-static int hvmemul_rep_stos(
+static int cf_check hvmemul_rep_stos(
     void *p_data,
     enum x86_segment seg,
     unsigned long offset,
@@ -2105,7 +2105,7 @@ static int hvmemul_rep_stos(
     }
 }
 
-static int hvmemul_read_segment(
+static int cf_check hvmemul_read_segment(
     enum x86_segment seg,
     struct segment_register *reg,
     struct x86_emulate_ctxt *ctxt)
@@ -2122,7 +2122,7 @@ static int hvmemul_read_segment(
     return X86EMUL_OKAY;
 }
 
-static int hvmemul_write_segment(
+static int cf_check hvmemul_write_segment(
     enum x86_segment seg,
     const struct segment_register *reg,
     struct x86_emulate_ctxt *ctxt)
@@ -2141,7 +2141,7 @@ static int hvmemul_write_segment(
     return X86EMUL_OKAY;
 }
 
-static int hvmemul_read_io(
+static int cf_check hvmemul_read_io(
     unsigned int port,
     unsigned int bytes,
     unsigned long *val,
@@ -2158,7 +2158,7 @@ static int hvmemul_read_io(
     return hvmemul_do_pio_buffer(port, bytes, IOREQ_READ, val);
 }
 
-static int hvmemul_write_io(
+static int cf_check hvmemul_write_io(
     unsigned int port,
     unsigned int bytes,
     unsigned long val,
@@ -2167,7 +2167,7 @@ static int hvmemul_write_io(
     return hvmemul_do_pio_buffer(port, bytes, IOREQ_WRITE, &val);
 }
 
-static int hvmemul_read_cr(
+static int cf_check hvmemul_read_cr(
     unsigned int reg,
     unsigned long *val,
     struct x86_emulate_ctxt *ctxt)
@@ -2188,7 +2188,7 @@ static int hvmemul_read_cr(
     return X86EMUL_UNHANDLEABLE;
 }
 
-static int hvmemul_write_cr(
+static int cf_check hvmemul_write_cr(
     unsigned int reg,
     unsigned long val,
     struct x86_emulate_ctxt *ctxt)
@@ -2232,7 +2232,7 @@ static int hvmemul_write_cr(
     return rc;
 }
 
-static int hvmemul_read_xcr(
+static int cf_check hvmemul_read_xcr(
     unsigned int reg,
     uint64_t *val,
     struct x86_emulate_ctxt *ctxt)
@@ -2245,7 +2245,7 @@ static int hvmemul_read_xcr(
     return rc;
 }
 
-static int hvmemul_write_xcr(
+static int cf_check hvmemul_write_xcr(
     unsigned int reg,
     uint64_t val,
     struct x86_emulate_ctxt *ctxt)
@@ -2255,7 +2255,7 @@ static int hvmemul_write_xcr(
     return x86emul_write_xcr(reg, val, ctxt);
 }
 
-static int hvmemul_read_msr(
+static int cf_check hvmemul_read_msr(
     unsigned int reg,
     uint64_t *val,
     struct x86_emulate_ctxt *ctxt)
@@ -2268,7 +2268,7 @@ static int hvmemul_read_msr(
     return rc;
 }
 
-static int hvmemul_write_msr(
+static int cf_check hvmemul_write_msr(
     unsigned int reg,
     uint64_t val,
     struct x86_emulate_ctxt *ctxt)
@@ -2281,7 +2281,7 @@ static int hvmemul_write_msr(
     return rc;
 }
 
-static int hvmemul_cache_op(
+static int cf_check hvmemul_cache_op(
     enum x86emul_cache_op op,
     enum x86_segment seg,
     unsigned long offset,
@@ -2353,7 +2353,7 @@ static int hvmemul_cache_op(
     return X86EMUL_OKAY;
 }
 
-static int hvmemul_get_fpu(
+static int cf_check hvmemul_get_fpu(
     enum x86_emulate_fpu_type type,
     struct x86_emulate_ctxt *ctxt)
 {
@@ -2395,7 +2395,7 @@ static int hvmemul_get_fpu(
     return X86EMUL_OKAY;
 }
 
-static void hvmemul_put_fpu(
+static void cf_check hvmemul_put_fpu(
     struct x86_emulate_ctxt *ctxt,
     enum x86_emulate_fpu_type backout,
     const struct x86_emul_fpu_aux *aux)
@@ -2482,7 +2482,7 @@ static void hvmemul_put_fpu(
     }
 }
 
-static int hvmemul_tlb_op(
+static int cf_check hvmemul_tlb_op(
     enum x86emul_tlb_op op,
     unsigned long addr,
     unsigned long aux,
@@ -2539,7 +2539,7 @@ static int hvmemul_tlb_op(
     return rc;
 }
 
-static int hvmemul_vmfunc(
+static int cf_check hvmemul_vmfunc(
     struct x86_emulate_ctxt *ctxt)
 {
     int rc;
diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c
index 9e4924649077..e87e809a945d 100644
--- a/xen/arch/x86/hvm/hvm.c
+++ b/xen/arch/x86/hvm/hvm.c
@@ -3755,8 +3755,8 @@ void hvm_set_reg(struct vcpu *v, unsigned int reg, uint64_t val)
     }
 }
 
-static bool is_sysdesc_access(const struct x86_emulate_state *state,
-                              const struct x86_emulate_ctxt *ctxt)
+static bool cf_check is_sysdesc_access(
+    const struct x86_emulate_state *state, const struct x86_emulate_ctxt *ctxt)
 {
     unsigned int ext;
     int mode = x86_insn_modrm(state, NULL, &ext);
@@ -3796,8 +3796,8 @@ int hvm_descriptor_access_intercept(uint64_t exit_info,
     return X86EMUL_OKAY;
 }
 
-static bool is_cross_vendor(const struct x86_emulate_state *state,
-                            const struct x86_emulate_ctxt *ctxt)
+static bool cf_check is_cross_vendor(
+    const struct x86_emulate_state *state, const struct x86_emulate_ctxt *ctxt)
 {
     switch ( ctxt->opcode )
     {
diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c
index 4c4ebda5e6e4..dedb2848e6a1 100644
--- a/xen/arch/x86/hvm/svm/svm.c
+++ b/xen/arch/x86/hvm/svm/svm.c
@@ -2447,8 +2447,8 @@ static void svm_invlpg_intercept(unsigned long linear)
     paging_invlpg(current, linear);
 }
 
-static bool is_invlpg(const struct x86_emulate_state *state,
-                      const struct x86_emulate_ctxt *ctxt)
+static bool cf_check is_invlpg(
+    const struct x86_emulate_state *state, const struct x86_emulate_ctxt *ctxt)
 {
     unsigned int ext;
 
diff --git a/xen/arch/x86/include/asm/hvm/emulate.h b/xen/arch/x86/include/asm/hvm/emulate.h
index e67004060345..d8ba2df4e4a2 100644
--- a/xen/arch/x86/include/asm/hvm/emulate.h
+++ b/xen/arch/x86/include/asm/hvm/emulate.h
@@ -92,10 +92,10 @@ static inline bool handle_mmio(void)
     return hvm_emulate_one_insn(x86_insn_is_mem_access, "MMIO");
 }
 
-int hvmemul_insn_fetch(unsigned long offset,
-                       void *p_data,
-                       unsigned int bytes,
-                       struct x86_emulate_ctxt *ctxt);
+int cf_check hvmemul_insn_fetch(
+    unsigned long offset, void *p_data, unsigned int bytes,
+    struct x86_emulate_ctxt *ctxt);
+
 int hvmemul_do_pio_buffer(uint16_t port,
                           unsigned int size,
                           uint8_t dir,
diff --git a/xen/arch/x86/include/asm/mm.h b/xen/arch/x86/include/asm/mm.h
index 9b9de4c6bef7..a684ffabfaae 100644
--- a/xen/arch/x86/include/asm/mm.h
+++ b/xen/arch/x86/include/asm/mm.h
@@ -538,16 +538,12 @@ struct mmio_ro_emulate_ctxt {
         unsigned int seg, bdf;
 };
 
-extern int mmio_ro_emulated_write(enum x86_segment seg,
-                                  unsigned long offset,
-                                  void *p_data,
-                                  unsigned int bytes,
-                                  struct x86_emulate_ctxt *ctxt);
-extern int mmcfg_intercept_write(enum x86_segment seg,
-                                 unsigned long offset,
-                                 void *p_data,
-                                 unsigned int bytes,
-                                 struct x86_emulate_ctxt *ctxt);
+int cf_check mmio_ro_emulated_write(
+    enum x86_segment seg, unsigned long offset, void *p_data,
+    unsigned int bytes, struct x86_emulate_ctxt *ctxt);
+int cf_check mmcfg_intercept_write(
+    enum x86_segment seg, unsigned long offset, void *p_data,
+    unsigned int bytes, struct x86_emulate_ctxt *ctxt);
 
 int audit_adjust_pgtables(struct domain *d, int dir, int noisy);
 
diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c
index 4b6956c5be78..4d0bebbf8aab 100644
--- a/xen/arch/x86/mm.c
+++ b/xen/arch/x86/mm.c
@@ -4852,7 +4852,7 @@ long arch_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
     return 0;
 }
 
-int mmio_ro_emulated_write(
+int cf_check mmio_ro_emulated_write(
     enum x86_segment seg,
     unsigned long offset,
     void *p_data,
@@ -4873,7 +4873,7 @@ int mmio_ro_emulated_write(
     return X86EMUL_OKAY;
 }
 
-int mmcfg_intercept_write(
+int cf_check mmcfg_intercept_write(
     enum x86_segment seg,
     unsigned long offset,
     void *p_data,
diff --git a/xen/arch/x86/mm/shadow/hvm.c b/xen/arch/x86/mm/shadow/hvm.c
index f2991bc176f0..c90d326becb3 100644
--- a/xen/arch/x86/mm/shadow/hvm.c
+++ b/xen/arch/x86/mm/shadow/hvm.c
@@ -148,7 +148,7 @@ hvm_read(enum x86_segment seg,
     return X86EMUL_UNHANDLEABLE;
 }
 
-static int
+static int cf_check
 hvm_emulate_read(enum x86_segment seg,
                  unsigned long offset,
                  void *p_data,
@@ -161,7 +161,7 @@ hvm_emulate_read(enum x86_segment seg,
                     container_of(ctxt, struct sh_emulate_ctxt, ctxt));
 }
 
-static int
+static int cf_check
 hvm_emulate_insn_fetch(unsigned long offset,
                        void *p_data,
                        unsigned int bytes,
@@ -181,7 +181,7 @@ hvm_emulate_insn_fetch(unsigned long offset,
     return X86EMUL_OKAY;
 }
 
-static int
+static int cf_check
 hvm_emulate_write(enum x86_segment seg,
                   unsigned long offset,
                   void *p_data,
@@ -234,7 +234,7 @@ hvm_emulate_write(enum x86_segment seg,
     return X86EMUL_OKAY;
 }
 
-static int
+static int cf_check
 hvm_emulate_cmpxchg(enum x86_segment seg,
                     unsigned long offset,
                     void *p_old,
diff --git a/xen/arch/x86/pv/emul-gate-op.c b/xen/arch/x86/pv/emul-gate-op.c
index 68ec4d11f6bb..758a20ad9df4 100644
--- a/xen/arch/x86/pv/emul-gate-op.c
+++ b/xen/arch/x86/pv/emul-gate-op.c
@@ -96,8 +96,9 @@ struct gate_op_ctxt {
     bool insn_fetch;
 };
 
-static int read_mem(enum x86_segment seg, unsigned long offset, void *p_data,
-                    unsigned int bytes, struct x86_emulate_ctxt *ctxt)
+static int cf_check read_mem(
+    enum x86_segment seg, unsigned long offset, void *p_data,
+    unsigned int bytes, struct x86_emulate_ctxt *ctxt)
 {
     const struct gate_op_ctxt *goc =
         container_of(ctxt, struct gate_op_ctxt, ctxt);
@@ -163,8 +164,8 @@ static int read_mem(enum x86_segment seg, unsigned long offset, void *p_data,
     return X86EMUL_OKAY;
 }
 
-static int fetch(unsigned long offset, void *p_data,
-                 unsigned int bytes, struct x86_emulate_ctxt *ctxt)
+static int cf_check fetch(unsigned long offset, void *p_data,
+                          unsigned int bytes, struct x86_emulate_ctxt *ctxt)
 {
     return read_mem(x86_seg_cs, offset, p_data, bytes, ctxt);
 }
diff --git a/xen/arch/x86/pv/emul-priv-op.c b/xen/arch/x86/pv/emul-priv-op.c
index c78be6d92b21..c46c072f93db 100644
--- a/xen/arch/x86/pv/emul-priv-op.c
+++ b/xen/arch/x86/pv/emul-priv-op.c
@@ -358,8 +358,9 @@ static unsigned int check_guest_io_breakpoint(struct vcpu *v,
     return match;
 }
 
-static int read_io(unsigned int port, unsigned int bytes,
-                   unsigned long *val, struct x86_emulate_ctxt *ctxt)
+static int cf_check read_io(
+    unsigned int port, unsigned int bytes, unsigned long *val,
+    struct x86_emulate_ctxt *ctxt)
 {
     struct priv_op_ctxt *poc = container_of(ctxt, struct priv_op_ctxt, ctxt);
     struct vcpu *curr = current;
@@ -462,8 +463,9 @@ static void guest_io_write(unsigned int port, unsigned int bytes,
     }
 }
 
-static int write_io(unsigned int port, unsigned int bytes,
-                    unsigned long val, struct x86_emulate_ctxt *ctxt)
+static int cf_check write_io(
+    unsigned int port, unsigned int bytes, unsigned long val,
+    struct x86_emulate_ctxt *ctxt)
 {
     struct priv_op_ctxt *poc = container_of(ctxt, struct priv_op_ctxt, ctxt);
     struct vcpu *curr = current;
@@ -493,9 +495,9 @@ static int write_io(unsigned int port, unsigned int bytes,
     return X86EMUL_OKAY;
 }
 
-static int read_segment(enum x86_segment seg,
-                        struct segment_register *reg,
-                        struct x86_emulate_ctxt *ctxt)
+static int cf_check read_segment(
+    enum x86_segment seg, struct segment_register *reg,
+    struct x86_emulate_ctxt *ctxt)
 {
     /* Check if this is an attempt to access the I/O bitmap. */
     if ( seg == x86_seg_tr )
@@ -607,10 +609,10 @@ static int pv_emul_virt_to_linear(unsigned long base, unsigned long offset,
     return rc;
 }
 
-static int rep_ins(uint16_t port,
-                   enum x86_segment seg, unsigned long offset,
-                   unsigned int bytes_per_rep, unsigned long *reps,
-                   struct x86_emulate_ctxt *ctxt)
+static int cf_check rep_ins(
+    uint16_t port, enum x86_segment seg, unsigned long offset,
+    unsigned int bytes_per_rep, unsigned long *reps,
+    struct x86_emulate_ctxt *ctxt)
 {
     struct priv_op_ctxt *poc = container_of(ctxt, struct priv_op_ctxt, ctxt);
     struct vcpu *curr = current;
@@ -675,10 +677,10 @@ static int rep_ins(uint16_t port,
     return X86EMUL_OKAY;
 }
 
-static int rep_outs(enum x86_segment seg, unsigned long offset,
-                    uint16_t port,
-                    unsigned int bytes_per_rep, unsigned long *reps,
-                    struct x86_emulate_ctxt *ctxt)
+static int cf_check rep_outs(
+    enum x86_segment seg, unsigned long offset, uint16_t port,
+    unsigned int bytes_per_rep, unsigned long *reps,
+    struct x86_emulate_ctxt *ctxt)
 {
     struct priv_op_ctxt *poc = container_of(ctxt, struct priv_op_ctxt, ctxt);
     struct vcpu *curr = current;
@@ -744,8 +746,8 @@ static int rep_outs(enum x86_segment seg, unsigned long offset,
     return X86EMUL_OKAY;
 }
 
-static int read_cr(unsigned int reg, unsigned long *val,
-                   struct x86_emulate_ctxt *ctxt)
+static int cf_check read_cr(
+    unsigned int reg, unsigned long *val, struct x86_emulate_ctxt *ctxt)
 {
     const struct vcpu *curr = current;
 
@@ -787,8 +789,8 @@ static int read_cr(unsigned int reg, unsigned long *val,
     return X86EMUL_UNHANDLEABLE;
 }
 
-static int write_cr(unsigned int reg, unsigned long val,
-                    struct x86_emulate_ctxt *ctxt)
+static int cf_check write_cr(
+    unsigned int reg, unsigned long val, struct x86_emulate_ctxt *ctxt)
 {
     struct vcpu *curr = current;
 
@@ -871,8 +873,8 @@ static uint64_t guest_efer(const struct domain *d)
     return val;
 }
 
-static int read_msr(unsigned int reg, uint64_t *val,
-                    struct x86_emulate_ctxt *ctxt)
+static int cf_check read_msr(
+    unsigned int reg, uint64_t *val, struct x86_emulate_ctxt *ctxt)
 {
     struct vcpu *curr = current;
     const struct domain *currd = curr->domain;
@@ -1020,8 +1022,8 @@ static int read_msr(unsigned int reg, uint64_t *val,
     return ret;
 }
 
-static int write_msr(unsigned int reg, uint64_t val,
-                     struct x86_emulate_ctxt *ctxt)
+static int cf_check write_msr(
+    unsigned int reg, uint64_t val, struct x86_emulate_ctxt *ctxt)
 {
     struct vcpu *curr = current;
     const struct domain *currd = curr->domain;
@@ -1188,8 +1190,9 @@ static int write_msr(unsigned int reg, uint64_t val,
     return X86EMUL_UNHANDLEABLE;
 }
 
-static int cache_op(enum x86emul_cache_op op, enum x86_segment seg,
-                    unsigned long offset, struct x86_emulate_ctxt *ctxt)
+static int cf_check cache_op(
+    enum x86emul_cache_op op, enum x86_segment seg,
+    unsigned long offset, struct x86_emulate_ctxt *ctxt)
 {
     ASSERT(op == x86emul_wbinvd || op == x86emul_wbnoinvd);
 
@@ -1208,8 +1211,8 @@ static int cache_op(enum x86emul_cache_op op, enum x86_segment seg,
     return X86EMUL_OKAY;
 }
 
-static int validate(const struct x86_emulate_state *state,
-                    struct x86_emulate_ctxt *ctxt)
+static int cf_check validate(
+    const struct x86_emulate_state *state, struct x86_emulate_ctxt *ctxt)
 {
     switch ( ctxt->opcode )
     {
@@ -1258,10 +1261,9 @@ static int validate(const struct x86_emulate_state *state,
     return X86EMUL_UNHANDLEABLE;
 }
 
-static int insn_fetch(unsigned long offset,
-                      void *p_data,
-                      unsigned int bytes,
-                      struct x86_emulate_ctxt *ctxt)
+static int cf_check insn_fetch(
+    unsigned long offset, void *p_data, unsigned int bytes,
+    struct x86_emulate_ctxt *ctxt)
 {
     const struct priv_op_ctxt *poc =
         container_of(ctxt, struct priv_op_ctxt, ctxt);
diff --git a/xen/arch/x86/pv/emulate.h b/xen/arch/x86/pv/emulate.h
index 4b845b08e372..49a4d34832df 100644
--- a/xen/arch/x86/pv/emulate.h
+++ b/xen/arch/x86/pv/emulate.h
@@ -12,13 +12,6 @@ int pv_emul_read_descriptor(unsigned int sel, const struct vcpu *v,
 
 void pv_emul_instruction_done(struct cpu_user_regs *regs, unsigned long rip);
 
-static inline int pv_emul_is_mem_write(const struct x86_emulate_state *state,
-                                       struct x86_emulate_ctxt *ctxt)
-{
-    return x86_insn_is_mem_write(state, ctxt) ? X86EMUL_OKAY
-                                              : X86EMUL_UNHANDLEABLE;
-}
-
 /* Return a pointer to the GDT/LDT descriptor referenced by sel. */
 static inline const seg_desc_t *gdt_ldt_desc_ptr(unsigned int sel)
 {
diff --git a/xen/arch/x86/pv/ro-page-fault.c b/xen/arch/x86/pv/ro-page-fault.c
index ef4d146c1d9e..5963f5ee2d51 100644
--- a/xen/arch/x86/pv/ro-page-fault.c
+++ b/xen/arch/x86/pv/ro-page-fault.c
@@ -26,6 +26,13 @@
 #include "emulate.h"
 #include "mm.h"
 
+static int cf_check pv_emul_is_mem_write(
+    const struct x86_emulate_state *state, struct x86_emulate_ctxt *ctxt)
+{
+    return x86_insn_is_mem_write(state, ctxt) ? X86EMUL_OKAY
+                                              : X86EMUL_UNHANDLEABLE;
+}
+
 /*********************
  * Writable Pagetables
  */
@@ -35,9 +42,9 @@ struct ptwr_emulate_ctxt {
     l1_pgentry_t  pte;
 };
 
-static int ptwr_emulated_read(enum x86_segment seg, unsigned long offset,
-                              void *p_data, unsigned int bytes,
-                              struct x86_emulate_ctxt *ctxt)
+static int cf_check ptwr_emulated_read(
+    enum x86_segment seg, unsigned long offset, void *p_data,
+    unsigned int bytes, struct x86_emulate_ctxt *ctxt)
 {
     unsigned int rc = bytes;
     unsigned long addr = offset;
@@ -52,9 +59,9 @@ static int ptwr_emulated_read(enum x86_segment seg, unsigned long offset,
     return X86EMUL_OKAY;
 }
 
-static int ptwr_emulated_insn_fetch(unsigned long offset,
-                                    void *p_data, unsigned int bytes,
-                                    struct x86_emulate_ctxt *ctxt)
+static int cf_check ptwr_emulated_insn_fetch(
+    unsigned long offset, void *p_data, unsigned int bytes,
+    struct x86_emulate_ctxt *ctxt)
 {
     unsigned int rc = copy_from_guest_pv(p_data, (void *)offset, bytes);
 
@@ -218,9 +225,9 @@ static int ptwr_emulated_update(unsigned long addr, intpte_t *p_old,
     return X86EMUL_OKAY;
 }
 
-static int ptwr_emulated_write(enum x86_segment seg, unsigned long offset,
-                               void *p_data, unsigned int bytes,
-                               struct x86_emulate_ctxt *ctxt)
+static int cf_check ptwr_emulated_write(
+    enum x86_segment seg, unsigned long offset, void *p_data,
+    unsigned int bytes, struct x86_emulate_ctxt *ctxt)
 {
     intpte_t val = 0;
 
@@ -236,9 +243,9 @@ static int ptwr_emulated_write(enum x86_segment seg, unsigned long offset,
     return ptwr_emulated_update(offset, NULL, val, bytes, ctxt);
 }
 
-static int ptwr_emulated_cmpxchg(enum x86_segment seg, unsigned long offset,
-                                 void *p_old, void *p_new, unsigned int bytes,
-                                 bool lock, struct x86_emulate_ctxt *ctxt)
+static int cf_check ptwr_emulated_cmpxchg(
+    enum x86_segment seg, unsigned long offset, void *p_old, void *p_new,
+    unsigned int bytes, bool lock, struct x86_emulate_ctxt *ctxt)
 {
     intpte_t old = 0, new = 0;
     int rc;
diff --git a/xen/arch/x86/x86_emulate.c b/xen/arch/x86/x86_emulate.c
index 1e082e6f3b2d..60191a94dc18 100644
--- a/xen/arch/x86/x86_emulate.c
+++ b/xen/arch/x86/x86_emulate.c
@@ -53,8 +53,8 @@
 
 #include "x86_emulate/x86_emulate.c"
 
-int x86emul_read_xcr(unsigned int reg, uint64_t *val,
-                     struct x86_emulate_ctxt *ctxt)
+int cf_check x86emul_read_xcr(
+    unsigned int reg, uint64_t *val, struct x86_emulate_ctxt *ctxt)
 {
     switch ( reg )
     {
@@ -77,8 +77,8 @@ int x86emul_read_xcr(unsigned int reg, uint64_t *val,
 }
 
 /* Note: May be called with ctxt=NULL. */
-int x86emul_write_xcr(unsigned int reg, uint64_t val,
-                      struct x86_emulate_ctxt *ctxt)
+int cf_check x86emul_write_xcr(
+    unsigned int reg, uint64_t val, struct x86_emulate_ctxt *ctxt)
 {
     switch ( reg )
     {
@@ -100,8 +100,8 @@ int x86emul_write_xcr(unsigned int reg, uint64_t val,
 
 #ifdef CONFIG_PV
 /* Called with NULL ctxt in hypercall context. */
-int x86emul_read_dr(unsigned int reg, unsigned long *val,
-                    struct x86_emulate_ctxt *ctxt)
+int cf_check x86emul_read_dr(
+    unsigned int reg, unsigned long *val, struct x86_emulate_ctxt *ctxt)
 {
     struct vcpu *curr = current;
 
@@ -143,8 +143,8 @@ int x86emul_read_dr(unsigned int reg, unsigned long *val,
     return X86EMUL_OKAY;
 }
 
-int x86emul_write_dr(unsigned int reg, unsigned long val,
-                     struct x86_emulate_ctxt *ctxt)
+int cf_check x86emul_write_dr(
+    unsigned int reg, unsigned long val, struct x86_emulate_ctxt *ctxt)
 {
     struct vcpu *curr = current;
 
@@ -167,8 +167,9 @@ int x86emul_write_dr(unsigned int reg, unsigned long val,
 }
 #endif /* CONFIG_PV */
 
-int x86emul_cpuid(uint32_t leaf, uint32_t subleaf,
-                  struct cpuid_leaf *res, struct x86_emulate_ctxt *ctxt)
+int cf_check x86emul_cpuid(
+    uint32_t leaf, uint32_t subleaf, struct cpuid_leaf *res,
+    struct x86_emulate_ctxt *ctxt)
 {
     guest_cpuid(current, leaf, subleaf, res);
 
diff --git a/xen/arch/x86/x86_emulate/x86_emulate.c b/xen/arch/x86/x86_emulate/x86_emulate.c
index 824af9d899b5..5cdef535affd 100644
--- a/xen/arch/x86/x86_emulate/x86_emulate.c
+++ b/xen/arch/x86/x86_emulate/x86_emulate.c
@@ -2524,7 +2524,7 @@ static void adjust_bnd(struct x86_emulate_ctxt *ctxt,
  done:;
 }
 
-int x86emul_unhandleable_rw(
+int cf_check x86emul_unhandleable_rw(
     enum x86_segment seg,
     unsigned long offset,
     void *p_data,
@@ -12318,7 +12318,7 @@ x86_insn_operand_ea(const struct x86_emulate_state *state,
  * memory operand (like POP), but it does not mean e.g. segment selector
  * loads, where the descriptor table access is considered an implicit one.
  */
-bool
+bool cf_check
 x86_insn_is_mem_access(const struct x86_emulate_state *state,
                        const struct x86_emulate_ctxt *ctxt)
 {
@@ -12410,7 +12410,7 @@ x86_insn_is_mem_access(const struct x86_emulate_state *state,
  * loads, where the (possible) descriptor table write is considered an
  * implicit access.
  */
-bool
+bool cf_check
 x86_insn_is_mem_write(const struct x86_emulate_state *state,
                       const struct x86_emulate_ctxt *ctxt)
 {
@@ -12582,7 +12582,7 @@ x86_insn_is_mem_write(const struct x86_emulate_state *state,
     return false;
 }
 
-bool
+bool cf_check
 x86_insn_is_portio(const struct x86_emulate_state *state,
                    const struct x86_emulate_ctxt *ctxt)
 {
@@ -12597,7 +12597,7 @@ x86_insn_is_portio(const struct x86_emulate_state *state,
     return false;
 }
 
-bool
+bool cf_check
 x86_insn_is_cr_access(const struct x86_emulate_state *state,
                       const struct x86_emulate_ctxt *ctxt)
 {
diff --git a/xen/arch/x86/x86_emulate/x86_emulate.h b/xen/arch/x86/x86_emulate/x86_emulate.h
index 419def8790a0..4732855c40ed 100644
--- a/xen/arch/x86/x86_emulate/x86_emulate.h
+++ b/xen/arch/x86/x86_emulate/x86_emulate.h
@@ -737,7 +737,7 @@ static inline unsigned long *decode_gpr(struct cpu_user_regs *regs,
 }
 
 /* Unhandleable read, write or instruction fetch */
-int
+int cf_check
 x86emul_unhandleable_rw(
     enum x86_segment seg,
     unsigned long offset,
@@ -766,16 +766,16 @@ x86_insn_immediate(const struct x86_emulate_state *state,
 unsigned int
 x86_insn_length(const struct x86_emulate_state *state,
                 const struct x86_emulate_ctxt *ctxt);
-bool
+bool cf_check
 x86_insn_is_mem_access(const struct x86_emulate_state *state,
                        const struct x86_emulate_ctxt *ctxt);
-bool
+bool cf_check
 x86_insn_is_mem_write(const struct x86_emulate_state *state,
                       const struct x86_emulate_ctxt *ctxt);
-bool
+bool cf_check
 x86_insn_is_portio(const struct x86_emulate_state *state,
                    const struct x86_emulate_ctxt *ctxt);
-bool
+bool cf_check
 x86_insn_is_cr_access(const struct x86_emulate_state *state,
                       const struct x86_emulate_ctxt *ctxt);
 
@@ -787,17 +787,18 @@ void x86_emulate_free_state(struct x86_emulate_state *state);
 
 #ifdef __XEN__
 
-int x86emul_read_xcr(unsigned int reg, uint64_t *val,
-                     struct x86_emulate_ctxt *ctxt);
-int x86emul_write_xcr(unsigned int reg, uint64_t val,
-                      struct x86_emulate_ctxt *ctxt);
-
-int x86emul_read_dr(unsigned int reg, unsigned long *val,
-                    struct x86_emulate_ctxt *ctxt);
-int x86emul_write_dr(unsigned int reg, unsigned long val,
-                     struct x86_emulate_ctxt *ctxt);
-int x86emul_cpuid(uint32_t leaf, uint32_t subleaf,
-                  struct cpuid_leaf *res, struct x86_emulate_ctxt *ctxt);
+int cf_check x86emul_read_xcr(
+    unsigned int reg, uint64_t *val, struct x86_emulate_ctxt *ctxt);
+int cf_check x86emul_write_xcr(
+    unsigned int reg, uint64_t val, struct x86_emulate_ctxt *ctxt);
+
+int cf_check x86emul_read_dr(
+    unsigned int reg, unsigned long *val, struct x86_emulate_ctxt *ctxt);
+int cf_check x86emul_write_dr(
+    unsigned int reg, unsigned long val, struct x86_emulate_ctxt *ctxt);
+int cf_check x86emul_cpuid(
+    uint32_t leaf, uint32_t subleaf, struct cpuid_leaf *res,
+    struct x86_emulate_ctxt *ctxt);
 
 #endif
 
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:16:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:16:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271941.466698 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbDj-0003zP-SG; Mon, 14 Feb 2022 13:16:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271941.466698; Mon, 14 Feb 2022 13:16:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbDj-0003zG-NB; Mon, 14 Feb 2022 13:16:47 +0000
Received: by outflank-mailman (input) for mailman id 271941;
 Mon, 14 Feb 2022 13:16:46 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJb4F-0008IH-Cc
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:06:59 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id fb8b33b2-8d96-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 14:06:57 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fb8b33b2-8d96-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644844017;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=Mej6N2PECBXwwElk/AVZTwxR6YCdehxfIEnvABetLnE=;
  b=ddeI0GA2NG5fEWunYEzgTst/T8YrJGF9ORjC6WsJgcnZRIHmGnk1bsYf
   nX++QGlZTrF7JHs4C7gm0m7BNAOqiXX4R+hLJsWqLG+ZlCYJ8TS5hIqwN
   dL5jN2YgI/MCGUlAklebq7fl6ZWZ7s4ofnlzU10VNmK8KIIRBQagStXHq
   8=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: 4xuPf0XVUbXgWG0v6rS7g0s9+dMqxffyXCBK0hrLTCa9u6ylaVMULtaJR697DxZ6PVle1cTTxw
 TvPZ0va8h/gcdAZVeV0Xrf9VMKnAHJJ1pmGwIN1Gj1H3fMDV0XyP6XUqeqVaWOuVPHr/3qr4mM
 veLJ/OBXAePlVJQsIaSPCTBUUEmCxz2/Li/xfaJJnPv2fUAOdr/uNL0UMr1S4mEyMX4urIR/vT
 e4iESUp8TmMacNBHMQcSsLPUhTz0kX/LDFR8wPt+ktMnXRB4kU4aRR/f8IXzXf9ZITLFfIVrIY
 +beXpwySc4UuVvYd3FHWPpI7
X-SBRS: 5.1
X-MesageID: 64554298
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:qTxo7qpaha/Fuq7jhrFlBmk6T4leBmIAYhIvgKrLsJaIsI4StFCzt
 garIBmHO6yJZmunLtBxOY+zpBgFu8TXxoQyHlNprC03RntBp5uZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlZT4vE2xbuKU5NTsY0idfic5Dndx4f5fs7Rh2NQw24HlW1rlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCnbbqRw15FKeVoedDTisHOSVAPu5/qZaSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFKoZtmtt0nfyCvE+TIqYa67L+cVZzHE7gcUm8fP2O
 ZZENGY1PUSojxtnPVgGGI0UwvmTi0b5UQZF+WOJvvMNyj2GpOB2+Oe0a4eEEjCQfu1Fk0Ddq
 m/Y8mDRBhABKMfZ2TeD6mirhOLEgWX8Qo16KVGj3qc02hvJnDVVUUBIEwvgyRWktqKgc/gFJ
 UZE0CB3lKts6X70ZN3DXF6B8VfR63bwROFsO+E97QiMzI/d7ACYGnUIQ1Z9VTA2iCMlbWd0j
 wHUxrsFERQq6eTIEizFqt94uBvvYXB9EIMUWcMToeLpCfHHqZp7sB/AR80L/EWd3oysQmGYL
 9xnQUEDa1QvYSwjiv/TEbPv2WvESn31oukdvFu/Y45dxlklDLNJnqTxgbQh0d5OLZyCUn6Kt
 2Uels6V4YgmVM/RyHPdELhQROjyvZ5p1QEwZnY1QfEcG8mFoSb/Lei8HhkiTKuWDir0UWCwO
 xKC0e+gzJRSIGGrfcdKj3GZUKwXIVzbPY29DJj8N4MWCrAoLVPv1Hw+NCa4gjG2+GBxwP5XB
 HtuWZv1ZZrsIf88l2TeqiZ0+eJD+x3SMkuNGcGln0z/i+L2ibz8Ye5tDWZip9sRtMusyDg5O
 f4FbJPiJ8x3XLKsby/J35QUKFxWf3E3CYqv855cd/KZIxogE2YkUqeDzbQkco1jvqJUiuaXo
 S3tBh4GkALy1S/dNAGHSnF/c7ezD5xxmm02YH43NlGy1nl9PYv2tPUDd4E6dKUM/fB4yaImV
 OEMfsiNW6wdSjnO9zkHQ4P6qYhuKEaiiQ6UZnL3azkjZZ9wAQfO/4a8LAfo8SAPCAuxtNc//
 OL8hl+KH8JbSl07XsjMaf+pw1eghlQnmbp/DxnSP91eWETw64w2eSb/ueA6fpMXIhLZyzrEi
 wvPWUUEpfPAqpMe+cXSgfzWtJ+gFuZzExYIH2Tf6rrqZyDW8nD6nN1FWeeMOzvcSHn16OOpY
 uAMl6PwN/gOnVBrtYtgEuk0kfJitoW3/7IKnB55GHjrbkiwDuIyK3aL6sBDq6lRy+ILogCxQ
 E+OpoFXNLjh1BkJy7LNyN7Jtti+6Mw=
IronPort-HdrOrdr: A9a23:9CJNna6Vyk/F5eKSygPXwMrXdLJyesId70hD6qhwISY6TiX4rb
 HWoB1173/JYVoqNE3I3OrwXZVoIkmsk6Kdg7NhXotKNTOO0ADDQb2Kr7GSpwEIcxeOkdK1vp
 0AT0ERMrLN5CBB/KTH3DU=
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="64554298"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v2 30/70] xen/misc: CFI hardening
Date: Mon, 14 Feb 2022 12:50:47 +0000
Message-ID: <20220214125127.17985-31-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

Control Flow Integrity schemes use toolchain and optionally hardware support
to help protect against call/jump/return oriented programming attacks.

Use cf_check to annotate function pointer targets for the toolchain.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
 xen/arch/x86/mm.c                        | 6 ++++--
 xen/arch/x86/setup.c                     | 4 ++--
 xen/common/domain.c                      | 2 +-
 xen/common/gdbstub.c                     | 5 ++---
 xen/common/livepatch.c                   | 7 +++----
 xen/common/memory.c                      | 4 ++--
 xen/common/page_alloc.c                  | 2 +-
 xen/common/radix-tree.c                  | 4 ++--
 xen/common/rangeset.c                    | 2 +-
 xen/common/spinlock.c                    | 6 +++---
 xen/common/vm_event.c                    | 6 +++---
 xen/common/xmalloc_tlsf.c                | 4 ++--
 xen/drivers/passthrough/amd/iommu_init.c | 2 +-
 13 files changed, 27 insertions(+), 27 deletions(-)

diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c
index 3b8bc3dda977..4b6956c5be78 100644
--- a/xen/arch/x86/mm.c
+++ b/xen/arch/x86/mm.c
@@ -835,7 +835,8 @@ struct mmio_emul_range_ctxt {
     unsigned long mfn;
 };
 
-static int print_mmio_emul_range(unsigned long s, unsigned long e, void *arg)
+static int cf_check print_mmio_emul_range(
+    unsigned long s, unsigned long e, void *arg)
 {
     const struct mmio_emul_range_ctxt *ctxt = arg;
 
@@ -4606,7 +4607,8 @@ static int _handle_iomem_range(unsigned long s, unsigned long e,
     return 0;
 }
 
-static int handle_iomem_range(unsigned long s, unsigned long e, void *p)
+static int cf_check handle_iomem_range(
+    unsigned long s, unsigned long e, void *p)
 {
     int err = 0;
 
diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c
index eceff0a4e2b4..735f69d2cae8 100644
--- a/xen/arch/x86/setup.c
+++ b/xen/arch/x86/setup.c
@@ -2023,8 +2023,8 @@ int __hwdom_init xen_in_range(unsigned long mfn)
     return 0;
 }
 
-static int __hwdom_init io_bitmap_cb(unsigned long s, unsigned long e,
-                                     void *ctx)
+static int __hwdom_init cf_check io_bitmap_cb(
+    unsigned long s, unsigned long e, void *ctx)
 {
     struct domain *d = ctx;
     unsigned int i;
diff --git a/xen/common/domain.c b/xen/common/domain.c
index a49c26064601..a3614539e472 100644
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -370,7 +370,7 @@ static void cf_check _free_pirq_struct(struct rcu_head *head)
     xfree(container_of(head, struct pirq, rcu_head));
 }
 
-static void free_pirq_struct(void *ptr)
+static void cf_check free_pirq_struct(void *ptr)
 {
     struct pirq *pirq = ptr;
 
diff --git a/xen/common/gdbstub.c b/xen/common/gdbstub.c
index 079c3ca9616a..d6872721dc0d 100644
--- a/xen/common/gdbstub.c
+++ b/xen/common/gdbstub.c
@@ -69,7 +69,7 @@ static void gdb_smp_resume(void);
 static char __initdata opt_gdb[30];
 string_param("gdb", opt_gdb);
 
-static void gdbstub_console_puts(const char *str, size_t nr);
+static void cf_check gdbstub_console_puts(const char *str, size_t nr);
 
 /* value <-> char (de)serialzers */
 static char
@@ -546,8 +546,7 @@ __gdb_ctx = {
 };
 static struct gdb_context *gdb_ctx = &__gdb_ctx;
 
-static void
-gdbstub_console_puts(const char *str, size_t nr)
+static void cf_check gdbstub_console_puts(const char *str, size_t nr)
 {
     const char *p;
 
diff --git a/xen/common/livepatch.c b/xen/common/livepatch.c
index e8714920dc8f..ec301a9f120c 100644
--- a/xen/common/livepatch.c
+++ b/xen/common/livepatch.c
@@ -157,10 +157,9 @@ unsigned long livepatch_symbols_lookup_by_name(const char *symname)
     return 0;
 }
 
-static const char *livepatch_symbols_lookup(unsigned long addr,
-                                            unsigned long *symbolsize,
-                                            unsigned long *offset,
-                                            char *namebuf)
+static const char *cf_check livepatch_symbols_lookup(
+    unsigned long addr, unsigned long *symbolsize, unsigned long *offset,
+    char *namebuf)
 {
     const struct payload *data;
     unsigned int i, best;
diff --git a/xen/common/memory.c b/xen/common/memory.c
index ede45c4af9db..69b0cd1e50de 100644
--- a/xen/common/memory.c
+++ b/xen/common/memory.c
@@ -1051,8 +1051,8 @@ struct get_reserved_device_memory {
     unsigned int used_entries;
 };
 
-static int get_reserved_device_memory(xen_pfn_t start, xen_ulong_t nr,
-                                      u32 id, void *ctxt)
+static int cf_check get_reserved_device_memory(
+    xen_pfn_t start, xen_ulong_t nr, u32 id, void *ctxt)
 {
     struct get_reserved_device_memory *grdm = ctxt;
     uint32_t sbdf = PCI_SBDF3(grdm->map.dev.pci.seg, grdm->map.dev.pci.bus,
diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c
index 3caf5c954b24..46357182375a 100644
--- a/xen/common/page_alloc.c
+++ b/xen/common/page_alloc.c
@@ -1238,7 +1238,7 @@ struct scrub_wait_state {
     bool drop;
 };
 
-static void scrub_continue(void *data)
+static void cf_check scrub_continue(void *data)
 {
     struct scrub_wait_state *st = data;
 
diff --git a/xen/common/radix-tree.c b/xen/common/radix-tree.c
index 33b47748ae49..adc3034222dc 100644
--- a/xen/common/radix-tree.c
+++ b/xen/common/radix-tree.c
@@ -52,7 +52,7 @@ struct rcu_node {
 	struct rcu_head rcu_head;
 };
 
-static struct radix_tree_node *rcu_node_alloc(void *arg)
+static struct radix_tree_node *cf_check rcu_node_alloc(void *arg)
 {
 	struct rcu_node *rcu_node = xmalloc(struct rcu_node);
 	return rcu_node ? &rcu_node->node : NULL;
@@ -65,7 +65,7 @@ static void cf_check _rcu_node_free(struct rcu_head *head)
 	xfree(rcu_node);
 }
 
-static void rcu_node_free(struct radix_tree_node *node, void *arg)
+static void cf_check rcu_node_free(struct radix_tree_node *node, void *arg)
 {
 	struct rcu_node *rcu_node = container_of(node, struct rcu_node, node);
 	call_rcu(&rcu_node->rcu_head, _rcu_node_free);
diff --git a/xen/common/rangeset.c b/xen/common/rangeset.c
index 885b6b15c229..a6ef2640462a 100644
--- a/xen/common/rangeset.c
+++ b/xen/common/rangeset.c
@@ -384,7 +384,7 @@ int rangeset_consume_ranges(struct rangeset *r,
     return rc;
 }
 
-static int merge(unsigned long s, unsigned long e, void *data)
+static int cf_check merge(unsigned long s, unsigned long e, void *data)
 {
     struct rangeset *r = data;
 
diff --git a/xen/common/spinlock.c b/xen/common/spinlock.c
index 25bfbf3c47f7..62c83aaa6a73 100644
--- a/xen/common/spinlock.c
+++ b/xen/common/spinlock.c
@@ -375,7 +375,7 @@ static void spinlock_profile_iterate(lock_profile_subfunc *sub, void *par)
     spin_unlock(&lock_profile_lock);
 }
 
-static void spinlock_profile_print_elem(struct lock_profile *data,
+static void cf_check spinlock_profile_print_elem(struct lock_profile *data,
     int32_t type, int32_t idx, void *par)
 {
     struct spinlock *lock = data->lock;
@@ -404,7 +404,7 @@ void cf_check spinlock_profile_printall(unsigned char key)
     spinlock_profile_iterate(spinlock_profile_print_elem, NULL);
 }
 
-static void spinlock_profile_reset_elem(struct lock_profile *data,
+static void cf_check spinlock_profile_reset_elem(struct lock_profile *data,
     int32_t type, int32_t idx, void *par)
 {
     data->lock_cnt = 0;
@@ -428,7 +428,7 @@ typedef struct {
     int                      rc;
 } spinlock_profile_ucopy_t;
 
-static void spinlock_profile_ucopy_elem(struct lock_profile *data,
+static void cf_check spinlock_profile_ucopy_elem(struct lock_profile *data,
     int32_t type, int32_t idx, void *par)
 {
     spinlock_profile_ucopy_t *p = par;
diff --git a/xen/common/vm_event.c b/xen/common/vm_event.c
index 70ab3ba406ff..84cf52636bc4 100644
--- a/xen/common/vm_event.c
+++ b/xen/common/vm_event.c
@@ -523,21 +523,21 @@ int __vm_event_claim_slot(struct domain *d, struct vm_event_domain *ved,
 
 #ifdef CONFIG_MEM_PAGING
 /* Registered with Xen-bound event channel for incoming notifications. */
-static void mem_paging_notification(struct vcpu *v, unsigned int port)
+static void cf_check mem_paging_notification(struct vcpu *v, unsigned int port)
 {
     vm_event_resume(v->domain, v->domain->vm_event_paging);
 }
 #endif
 
 /* Registered with Xen-bound event channel for incoming notifications. */
-static void monitor_notification(struct vcpu *v, unsigned int port)
+static void cf_check monitor_notification(struct vcpu *v, unsigned int port)
 {
     vm_event_resume(v->domain, v->domain->vm_event_monitor);
 }
 
 #ifdef CONFIG_MEM_SHARING
 /* Registered with Xen-bound event channel for incoming notifications. */
-static void mem_sharing_notification(struct vcpu *v, unsigned int port)
+static void cf_check mem_sharing_notification(struct vcpu *v, unsigned int port)
 {
     vm_event_resume(v->domain, v->domain->vm_event_share);
 }
diff --git a/xen/common/xmalloc_tlsf.c b/xen/common/xmalloc_tlsf.c
index e3f6886e6b62..d2ad909502d0 100644
--- a/xen/common/xmalloc_tlsf.c
+++ b/xen/common/xmalloc_tlsf.c
@@ -512,13 +512,13 @@ int xmem_pool_maxalloc(struct xmem_pool *pool)
 
 static struct xmem_pool *xenpool;
 
-static void *xmalloc_pool_get(unsigned long size)
+static void *cf_check xmalloc_pool_get(unsigned long size)
 {
     ASSERT(size == PAGE_SIZE);
     return alloc_xenheap_page();
 }
 
-static void xmalloc_pool_put(void *p)
+static void cf_check xmalloc_pool_put(void *p)
 {
     free_xenheap_page(p);
 }
diff --git a/xen/drivers/passthrough/amd/iommu_init.c b/xen/drivers/passthrough/amd/iommu_init.c
index 06b4d2b1fea0..cebcd68a6c04 100644
--- a/xen/drivers/passthrough/amd/iommu_init.c
+++ b/xen/drivers/passthrough/amd/iommu_init.c
@@ -1073,7 +1073,7 @@ static void * __init allocate_ppr_log(struct amd_iommu *iommu)
 #define IVRS_MAPPINGS_DEVTAB(m) (m)[ivrs_bdf_entries].intremap_table
 
 /* Gets passed to radix_tree_destroy(), so its param needs to be void *. */
-static void __init free_ivrs_mapping_callback(void *ptr)
+static void __init cf_check free_ivrs_mapping_callback(void *ptr)
 {
     const struct ivrs_mappings *ivrs_mappings = ptr;
 
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:16:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:16:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271946.466709 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbDm-0004LE-5W; Mon, 14 Feb 2022 13:16:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271946.466709; Mon, 14 Feb 2022 13:16:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbDm-0004Kv-1S; Mon, 14 Feb 2022 13:16:50 +0000
Received: by outflank-mailman (input) for mailman id 271946;
 Mon, 14 Feb 2022 13:16:49 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJb4Y-0008IH-5d
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:07:18 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 07a6f83c-8d97-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 14:07:16 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 07a6f83c-8d97-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644844036;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=k8U/gxV+rj8X4mP8GQMoApxTfQmXJsHdNzSIbDiqWyI=;
  b=AuwxoD3Wf/wJWz+/9VAN+EUQc86BWO44hzhGsqyYjxLKI0NMcgDpj6f3
   VmKLT+C2+R99F9OKY3RYsIfGlh3Bl67dxM/uf5A/FPE0MYHSqIN9VLtV/
   RJd4RoN+I/BTsLmMtANgO3ycOo28j3KLzFEKU2zLOW3FEsuyW/NugIkiu
   I=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: h7a1MSeXC3XEmwgZ4ZAxmHOIfpWElDoESvzTEb5rO0ehdcGjxnQX1xouB/k5GmGjcJ2aN1gGSY
 pq42uQ9LcVOW6eUdpU/wN92HJqDb+3rD9sv/IgPIgtlEll7+4dc8qGv6lNw9RD9N1tke2cOO5d
 1mmF1T3Bqr04MCzFAZnyFhCT4Uy2f3daSV8spMgFgjbZKs/ql4Zp+ZMocfkt/QqC8ze4zK8T/+
 V59Asfpy2b57KzGWwnIWVEdl0mccn+WHAPmCUOOszRgR/LXLSjqauA2M3r7z3Bts4pcjVKHjJS
 YPV72dFa6E4S3rdr6t2FGpR7
X-SBRS: 5.1
X-MesageID: 64554396
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:xpfeua5lPQ20LX0YavtzrQxRtAHAchMFZxGqfqrLsTDasY5as4F+v
 mobWj2Ga//eZGH3fdAkOouypkgD6pPUn9U1SAY+qygxHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FV8MpBsJ00o5wbZj29Iw2LBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z5
 NNfmbm2UV8TY4LHiuISfzR5TSZTIvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALBc/nJo4A/FpnyinUF60OSpHfWaTao9Rf2V/cg+gQQauDO
 5FIN1KDajzjMz5LZVVGNKs+nbeWoGPnVCF9rm+K8P9fD2/7k1UqjemF3MDuUsOObdVYmACfv
 G2u10bTDwweNdef4SGY6X/qjejK9QvrVYRXGLCm+/pChFyI2ndVGBAQTUG8o/Sylgi5Qd03F
 qAP0nNw9+5orhXtF4SjGU3jyJKZgvICc/ZWAcEf7hnV8Pf76BSfCUQpb2BGRcNz4afaWgcW/
 lOOmtroAxlmv7uUVW+R+9+okN+iBcQGBTRcPHFZFGPp9/Gm+dhu1UyXEr6PBYbo1oWdJN3m/
 9ydQMHSbZ03hNVD6ai09Euvb9mE9smQFV5dCuk6swuYAuJFiGyNOtbABbvzt68owGOlor6p5
 iZspiRmxLpSZaxhbQTUKAn3IJmn5uyeLBrXikN1Ep8q+lyFoiD/Id8AsGwjfB4yaK7onAMFh
 2eJ52tsCGJ7ZiP2PcebnartYyjV8UQQPYu8Da2FBja/SpNwaBWG7ElTib24hAjQfLwXufhnY
 /+zKJ/0ZV5DUPgP5GfmFo81jO5wrghjlDy7eHwO50n+uVZoTCXOEult3ZrnRr1R0Z5oVy2Lr
 4cBZ5PSkU03vS+XSnC/zLP/5GsidRATba0aYeQOKL/rztNOFD5zBvnP76kmfoA5za1Zmv2Rp
 iO2W1NCyUq5jnrCcF3YZndmYbLpfJB+sXNkYnB8YQf2gyAuMdS18aMSV5orZr17puZt+uF5E
 qsecMKaD/URFjmeo2YBbYPwpZBJfQiwgV7cJDKsZTUyJsYyRwHA9tL+UBHo8S0CUni+ucck+
 uXy3QLHW5sTAQ9lCZ+OOv6oylqwu1kbmf5zABSUcoUCJh20/dEzeSLrj/IxL8UdEjn5x2OXh
 1SMHBMVhejRuItpotPHsr+J8tWyGOxkE0sEQ2SCteSqNTPX93aIyJNbVLraZijUUW759fnwZ
 ehRyP2gYvQLkEwT7th5Grdvi6k/+8Hut/lRyQE9RCfHaFGiC7VBJHia3JYQ6v0Rl+EB4QbmC
 FiS/tR6OKmSPJK3GVEcEwMpc+Cf2KxGgTLV9/k0fB336SIfEGBriqmO081gUBBgEYY=
IronPort-HdrOrdr: A9a23:PNCfPaysgKPtZIQE1C9cKrPwLr1zdoMgy1knxilNoRw8SKKlfq
 GV7Y0mPHDP6Ar5NEtNpTnEAtjkfZq+z+8S3WByB8bAYOCOggLBR+sO0WKh+UyFJ8SXzJ876U
 4KSclD4bPLYmSS9fyKgjWFLw==
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="64554396"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>
Subject: [PATCH v2 66/70] x86/entry: Make syscall/sysenter entrypoints CET-IBT compatible
Date: Mon, 14 Feb 2022 12:51:23 +0000
Message-ID: <20220214125127.17985-67-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

Each of MSR_{L,C}STAR and MSR_SYSENTER_EIP need to land on an endbr64
instruction.  For sysenter, this is easy.

Unfortunately for syscall, the stubs are already 29 byte long with a limit of
32.  endbr64 is 4 bytes.  Luckily, there is a 1 byte instruction which can
move from the stubs into the main handlers.

Move the push %rax out of the stub and into {l,c}star_entry(), allowing room
for the endbr64 instruction when appropriate.  Update the comment describing
the entry state.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>

v1.1:
 * Update to use endbr helpers.
---
 xen/arch/x86/x86_64/entry.S | 18 +++++++++---------
 xen/arch/x86/x86_64/traps.c | 11 +++++++----
 2 files changed, 16 insertions(+), 13 deletions(-)

diff --git a/xen/arch/x86/x86_64/entry.S b/xen/arch/x86/x86_64/entry.S
index 8494b97a54a2..9abcf95bd010 100644
--- a/xen/arch/x86/x86_64/entry.S
+++ b/xen/arch/x86/x86_64/entry.S
@@ -241,18 +241,17 @@ iret_exit_to_guest:
  * When entering SYSCALL from user mode:
  *  Vector directly to the registered arch.syscall_addr.
  *
- * Initial work is done by per-CPU trampolines. At this point %rsp has been
- * initialised to point at the correct Xen stack, %rsp has been saved, and
- * %rax needs to be restored from the %ss save slot. All other registers are
- * still to be saved onto the stack, starting with RFLAGS, and an appropriate
- * %ss must be saved into the space left by the trampoline.
+ * Initial work is done by per-CPU trampolines.
+ *  - Guest %rax stored in the %ss slot
+ *  - Guest %rsp stored in %rax
+ *  - Xen stack loaded, pointing at the %ss slot
  */
 ENTRY(lstar_enter)
 #ifdef CONFIG_XEN_SHSTK
         ALTERNATIVE "", "setssbsy", X86_FEATURE_XEN_SHSTK
 #endif
-        /* sti could live here when we don't switch page tables below. */
-        movq  8(%rsp),%rax /* Restore %rax. */
+        push  %rax          /* Guest %rsp */
+        movq  8(%rsp), %rax /* Restore guest %rax */
         movq  $FLAT_KERNEL_SS,8(%rsp)
         pushq %r11
         pushq $FLAT_KERNEL_CS64
@@ -288,9 +287,9 @@ ENTRY(cstar_enter)
 #ifdef CONFIG_XEN_SHSTK
         ALTERNATIVE "", "setssbsy", X86_FEATURE_XEN_SHSTK
 #endif
-        /* sti could live here when we don't switch page tables below. */
+        push  %rax          /* Guest %rsp */
         CR4_PV32_RESTORE
-        movq  8(%rsp), %rax /* Restore %rax. */
+        movq  8(%rsp), %rax /* Restore guest %rax. */
         movq  $FLAT_USER_SS32, 8(%rsp) /* Assume a 64bit domain.  Compat handled lower. */
         pushq %r11
         pushq $FLAT_USER_CS32
@@ -323,6 +322,7 @@ ENTRY(cstar_enter)
         jmp   switch_to_kernel
 
 ENTRY(sysenter_entry)
+        ENDBR64
 #ifdef CONFIG_XEN_SHSTK
         ALTERNATIVE "", "setssbsy", X86_FEATURE_XEN_SHSTK
 #endif
diff --git a/xen/arch/x86/x86_64/traps.c b/xen/arch/x86/x86_64/traps.c
index edc6820b85c7..fccfb7c17283 100644
--- a/xen/arch/x86/x86_64/traps.c
+++ b/xen/arch/x86/x86_64/traps.c
@@ -16,6 +16,7 @@
 #include <asm/current.h>
 #include <asm/flushtlb.h>
 #include <asm/traps.h>
+#include <asm/endbr.h>
 #include <asm/event.h>
 #include <asm/nmi.h>
 #include <asm/msr.h>
@@ -295,6 +296,12 @@ static unsigned int write_stub_trampoline(
 {
     unsigned char *p = stub;
 
+    if ( cpu_has_xen_ibt )
+    {
+        place_endbr64(p);
+        p += 4;
+    }
+
     /* Store guest %rax into %ss slot */
     /* movabsq %rax, stack_bottom - 8 */
     *p++ = 0x48;
@@ -315,10 +322,6 @@ static unsigned int write_stub_trampoline(
     *(uint64_t *)p = stack_bottom - 8;
     p += 8;
 
-    /* Store guest %rsp into %rsp slot */
-    /* pushq %rax */
-    *p++ = 0x50;
-
     /* jmp target_va */
     *p++ = 0xe9;
     *(int32_t *)p = target_va - (stub_va + (p - stub) + 4);
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:16:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:16:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271950.466720 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbDq-0004pp-Ff; Mon, 14 Feb 2022 13:16:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271950.466720; Mon, 14 Feb 2022 13:16:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbDq-0004pc-Bl; Mon, 14 Feb 2022 13:16:54 +0000
Received: by outflank-mailman (input) for mailman id 271950;
 Mon, 14 Feb 2022 13:16:52 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJb4S-0008IH-L9
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:07:12 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0480d88e-8d97-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 14:07:11 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0480d88e-8d97-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644844031;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=yEfJ1NphsqCcqUw8wV8ep+8qNFa6scIfTulHuJmrWCU=;
  b=BV6MgJgt1uxW3nHKsjmv5L56zukR6CjPzyP3m/uzCMfGqK34518N9EOq
   enD6Ny7puxpeXV+zGR33pjvqHFOMlR9R6krevpLCiDzVZrvJnQ6f8G65a
   zJIcDMwuQWlL/Z+vhSdPrYcgVe4f5VL+ELIJ3aUikIZuZck4fdaEr9fbU
   Q=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: eeE3LFTm9b8nkfrMlUyy4uZFO/R4lMxjDAfHhnrjeDnBJZud3NiZXxnsPOqcWXd+ZgMjWITqva
 eh5HcLAqsc6HKfVABc6qlCVqqZrkhoewaXy7qmvp/23vEotR8ErY6SwanUvzTtNxiq3JmKpjqP
 tAUpWzutLeLxeYYiOU5ZQF1KIQS8y7c+ls8eQce7w3nxC1X3hd6SuvTDOciTpR47kZd3NhUy+D
 PMqqgNT6CVcL3PzN1SI9D+uaIvwzqTvb26ucvVPFoaYg2Qu7SYLutkdjqXVDzjEOMCsPlTbHE5
 oHmYc33QS11WMmqwAGWUFrdD
X-SBRS: 5.1
X-MesageID: 64554366
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:05oBVq4mnwcOXuE8EroTCwxRtCDAchMFZxGqfqrLsTDasY5as4F+v
 jcYWG/Sb62PNGD8fox/b9zloEIA7JbQz9c2SVFkpC9jHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FV8MpBsJ00o5wbZj29Iw2LBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z5
 M5drreIbDwQJ7Dgt8UGQkNUFRB9FPgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALBc/nJo4A/FpnyinUF60OSpHfWaTao9Rf2V/cg+gQQauDO
 5FHN1KDajzQUgBjF2pJLqsDt7awtCShVTsE9G+88P9fD2/7k1UqjemF3MDuUsyHQ4BZk1iVo
 krC/n/lGVcKOdqH0z2H/3mwwOjVkkvGtJk6TePisKQw2RvKmzJVWEZ+uUaHTeeRplWuQPlnD
 nct4zcCgokp5RanSOj+dkjtyJKbhSI0V91VGuw8zQiCzKvI/gqUblQ5oi59hM8O75FvG2Fzv
 rOdt5awXGE07uXJIZ6I3urM9VuP1T4pwXjujMPuZS8M+JHdrY46lXojpf4zQffu3rUZ9dwdq
 g1mTRTSZZ1O16bnNI3hpDgrZg5AQbCTEGYICv3/BD7N0++ATNfNi3aUwVba9+1cC42SU0OMu
 nMJ8+DHsrxSUsHdyXHVGb5XdF1M2xpiGGeC6WOD4rF7r2j9k5JdVdw4DM5CyLdBbZ9fJG6Bj
 L77sgJN/p5DVEZGnocsC79d//8ClPC6ffy8D6i8RoMXPvBZKV/WlAkzNBX49z28zyARfVQXZ
 M7znTCEVi1BV8yKDVOeGo8g7FPc7n5ilD2DHcihl3xKE9O2PRaodFvMC3PWBshR0U9OiFyFq
 r6z7uOGlEdSVvPQeC7S/dJBJFwGNyFjV5v3t9ZWZqiIJQ8/QDMtDPrYwLUAfY15nvsKyreUr
 y/lAkIImkDigXDnKBmRbiwxYr3YQpsi/2kwOjYhPAj01iF7M5qv9qoWa7A+YaIjqL541fdxQ
 vRcI5eAD/1DRy7p4TMYaZWh/oVueA7y3VCFPja/YSh5dJllHlSb9tjhdwrp1S8PEivo6pdu/
 +z+jlvWGMNRSR5jAcDabOOU42mw5XVNyvhvW0boI8VIfBm++oZdNCGs3OQ8JNsBKEufy2LCh
 RqWGxoRucLEv5QxrIvSnamBooqkT7l+E05dEzWJ5Lq6L3CHrG+qwIsGW+eUZzHNEmjz/fz6N
 +lSyvj9NtwBnUpL7NUgQ+o6k/pm6ou9vaJewyRlAG7PPgaiBb5XK3Wb2dVC6/9WzbhDtArqA
 k+C97G241lS1B8JxLLJGDcYUw==
IronPort-HdrOrdr: A9a23:oCqK1qB25taa2f/lHemu55DYdb4zR+YMi2TC1yhKJyC9E/bo7v
 xG88566faZslossTQb6LW90cq7MBXhHPxOkOos1N6ZNWGM0gaVxcNZnO/fKlXbakrDH4VmtJ
 uIHZIQNDSJNykZsfrH
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="64554366"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v2 22/70] xen/hypfs: CFI hardening
Date: Mon, 14 Feb 2022 12:50:39 +0000
Message-ID: <20220214125127.17985-23-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

Control Flow Integrity schemes use toolchain and optionally hardware support
to help protect against call/jump/return oriented programming attacks.

Use cf_check to annotate function pointer targets for the toolchain.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Juergen Gross <jgross@suse.com>
---
 xen/common/hypfs.c         | 57 +++++++++++++++++++++++-----------------------
 xen/common/sched/cpupool.c | 25 ++++++++++----------
 xen/include/xen/hypfs.h    | 49 +++++++++++++++++++--------------------
 3 files changed, 65 insertions(+), 66 deletions(-)

diff --git a/xen/common/hypfs.c b/xen/common/hypfs.c
index 1526bcc52810..0d22396f5dd7 100644
--- a/xen/common/hypfs.c
+++ b/xen/common/hypfs.c
@@ -113,12 +113,13 @@ static void hypfs_unlock(void)
     }
 }
 
-const struct hypfs_entry *hypfs_node_enter(const struct hypfs_entry *entry)
+const struct hypfs_entry *cf_check hypfs_node_enter(
+    const struct hypfs_entry *entry)
 {
     return entry;
 }
 
-void hypfs_node_exit(const struct hypfs_entry *entry)
+void cf_check hypfs_node_exit(const struct hypfs_entry *entry)
 {
 }
 
@@ -289,16 +290,14 @@ static int hypfs_get_path_user(char *buf,
     return 0;
 }
 
-struct hypfs_entry *hypfs_leaf_findentry(const struct hypfs_entry_dir *dir,
-                                         const char *name,
-                                         unsigned int name_len)
+struct hypfs_entry *cf_check hypfs_leaf_findentry(
+    const struct hypfs_entry_dir *dir, const char *name, unsigned int name_len)
 {
     return ERR_PTR(-ENOTDIR);
 }
 
-struct hypfs_entry *hypfs_dir_findentry(const struct hypfs_entry_dir *dir,
-                                        const char *name,
-                                        unsigned int name_len)
+struct hypfs_entry *cf_check hypfs_dir_findentry(
+    const struct hypfs_entry_dir *dir, const char *name, unsigned int name_len)
 {
     struct hypfs_entry *entry;
 
@@ -360,7 +359,7 @@ static struct hypfs_entry *hypfs_get_entry(const char *path)
     return hypfs_get_entry_rel(&hypfs_root, path + 1);
 }
 
-unsigned int hypfs_getsize(const struct hypfs_entry *entry)
+unsigned int cf_check hypfs_getsize(const struct hypfs_entry *entry)
 {
     return entry->size;
 }
@@ -396,7 +395,7 @@ int hypfs_read_dyndir_id_entry(const struct hypfs_entry_dir *template,
     return 0;
 }
 
-static const struct hypfs_entry *hypfs_dyndir_enter(
+static const struct hypfs_entry *cf_check hypfs_dyndir_enter(
     const struct hypfs_entry *entry)
 {
     const struct hypfs_dyndir_id *data;
@@ -407,7 +406,7 @@ static const struct hypfs_entry *hypfs_dyndir_enter(
     return data->template->e.funcs->enter(&data->template->e);
 }
 
-static struct hypfs_entry *hypfs_dyndir_findentry(
+static struct hypfs_entry *cf_check hypfs_dyndir_findentry(
     const struct hypfs_entry_dir *dir, const char *name, unsigned int name_len)
 {
     const struct hypfs_dyndir_id *data;
@@ -418,8 +417,8 @@ static struct hypfs_entry *hypfs_dyndir_findentry(
     return data->template->e.funcs->findentry(data->template, name, name_len);
 }
 
-static int hypfs_read_dyndir(const struct hypfs_entry *entry,
-                             XEN_GUEST_HANDLE_PARAM(void) uaddr)
+static int cf_check hypfs_read_dyndir(
+    const struct hypfs_entry *entry, XEN_GUEST_HANDLE_PARAM(void) uaddr)
 {
     const struct hypfs_dyndir_id *data;
 
@@ -463,8 +462,8 @@ unsigned int hypfs_dynid_entry_size(const struct hypfs_entry *template,
     return DIRENTRY_SIZE(snprintf(NULL, 0, template->name, id));
 }
 
-int hypfs_read_dir(const struct hypfs_entry *entry,
-                   XEN_GUEST_HANDLE_PARAM(void) uaddr)
+int cf_check hypfs_read_dir(const struct hypfs_entry *entry,
+                            XEN_GUEST_HANDLE_PARAM(void) uaddr)
 {
     const struct hypfs_entry_dir *d;
     const struct hypfs_entry *e;
@@ -510,8 +509,8 @@ int hypfs_read_dir(const struct hypfs_entry *entry,
     return 0;
 }
 
-int hypfs_read_leaf(const struct hypfs_entry *entry,
-                    XEN_GUEST_HANDLE_PARAM(void) uaddr)
+int cf_check hypfs_read_leaf(
+    const struct hypfs_entry *entry, XEN_GUEST_HANDLE_PARAM(void) uaddr)
 {
     const struct hypfs_entry_leaf *l;
     unsigned int size = entry->funcs->getsize(entry);
@@ -555,9 +554,9 @@ static int hypfs_read(const struct hypfs_entry *entry,
     return ret;
 }
 
-int hypfs_write_leaf(struct hypfs_entry_leaf *leaf,
-                     XEN_GUEST_HANDLE_PARAM(const_void) uaddr,
-                     unsigned int ulen)
+int cf_check hypfs_write_leaf(
+    struct hypfs_entry_leaf *leaf, XEN_GUEST_HANDLE_PARAM(const_void) uaddr,
+    unsigned int ulen)
 {
     char *buf;
     int ret;
@@ -596,9 +595,9 @@ int hypfs_write_leaf(struct hypfs_entry_leaf *leaf,
     return ret;
 }
 
-int hypfs_write_bool(struct hypfs_entry_leaf *leaf,
-                     XEN_GUEST_HANDLE_PARAM(const_void) uaddr,
-                     unsigned int ulen)
+int cf_check hypfs_write_bool(
+    struct hypfs_entry_leaf *leaf, XEN_GUEST_HANDLE_PARAM(const_void) uaddr,
+    unsigned int ulen)
 {
     bool buf;
 
@@ -618,9 +617,9 @@ int hypfs_write_bool(struct hypfs_entry_leaf *leaf,
     return 0;
 }
 
-int hypfs_write_custom(struct hypfs_entry_leaf *leaf,
-                       XEN_GUEST_HANDLE_PARAM(const_void) uaddr,
-                       unsigned int ulen)
+int cf_check hypfs_write_custom(
+    struct hypfs_entry_leaf *leaf, XEN_GUEST_HANDLE_PARAM(const_void) uaddr,
+    unsigned int ulen)
 {
     struct param_hypfs *p;
     char *buf;
@@ -653,9 +652,9 @@ int hypfs_write_custom(struct hypfs_entry_leaf *leaf,
     return ret;
 }
 
-int hypfs_write_deny(struct hypfs_entry_leaf *leaf,
-                     XEN_GUEST_HANDLE_PARAM(const_void) uaddr,
-                     unsigned int ulen)
+int cf_check hypfs_write_deny(
+    struct hypfs_entry_leaf *leaf, XEN_GUEST_HANDLE_PARAM(const_void) uaddr,
+    unsigned int ulen)
 {
     return -EACCES;
 }
diff --git a/xen/common/sched/cpupool.c b/xen/common/sched/cpupool.c
index b9d4babd0d8a..07f984a659cd 100644
--- a/xen/common/sched/cpupool.c
+++ b/xen/common/sched/cpupool.c
@@ -1026,8 +1026,8 @@ static struct notifier_block cpu_nfb = {
 
 static HYPFS_DIR_INIT(cpupool_pooldir, "%u");
 
-static int cpupool_dir_read(const struct hypfs_entry *entry,
-                            XEN_GUEST_HANDLE_PARAM(void) uaddr)
+static int cf_check cpupool_dir_read(
+    const struct hypfs_entry *entry, XEN_GUEST_HANDLE_PARAM(void) uaddr)
 {
     int ret = 0;
     struct cpupool *c;
@@ -1050,7 +1050,8 @@ static int cpupool_dir_read(const struct hypfs_entry *entry,
     return ret;
 }
 
-static unsigned int cpupool_dir_getsize(const struct hypfs_entry *entry)
+static unsigned int cf_check cpupool_dir_getsize(
+    const struct hypfs_entry *entry)
 {
     const struct cpupool *c;
     unsigned int size = 0;
@@ -1061,7 +1062,7 @@ static unsigned int cpupool_dir_getsize(const struct hypfs_entry *entry)
     return size;
 }
 
-static const struct hypfs_entry *cpupool_dir_enter(
+static const struct hypfs_entry *cf_check cpupool_dir_enter(
     const struct hypfs_entry *entry)
 {
     struct hypfs_dyndir_id *data;
@@ -1076,14 +1077,14 @@ static const struct hypfs_entry *cpupool_dir_enter(
     return entry;
 }
 
-static void cpupool_dir_exit(const struct hypfs_entry *entry)
+static void cf_check cpupool_dir_exit(const struct hypfs_entry *entry)
 {
     spin_unlock(&cpupool_lock);
 
     hypfs_free_dyndata();
 }
 
-static struct hypfs_entry *cpupool_dir_findentry(
+static struct hypfs_entry *cf_check cpupool_dir_findentry(
     const struct hypfs_entry_dir *dir, const char *name, unsigned int name_len)
 {
     unsigned long id;
@@ -1102,8 +1103,8 @@ static struct hypfs_entry *cpupool_dir_findentry(
     return hypfs_gen_dyndir_id_entry(&cpupool_pooldir, id, cpupool);
 }
 
-static int cpupool_gran_read(const struct hypfs_entry *entry,
-                             XEN_GUEST_HANDLE_PARAM(void) uaddr)
+static int cf_check cpupool_gran_read(
+    const struct hypfs_entry *entry, XEN_GUEST_HANDLE_PARAM(void) uaddr)
 {
     const struct hypfs_dyndir_id *data;
     const struct cpupool *cpupool;
@@ -1121,7 +1122,7 @@ static int cpupool_gran_read(const struct hypfs_entry *entry,
     return copy_to_guest(uaddr, gran, strlen(gran) + 1) ? -EFAULT : 0;
 }
 
-static unsigned int hypfs_gran_getsize(const struct hypfs_entry *entry)
+static unsigned int cf_check hypfs_gran_getsize(const struct hypfs_entry *entry)
 {
     const struct hypfs_dyndir_id *data;
     const struct cpupool *cpupool;
@@ -1136,9 +1137,9 @@ static unsigned int hypfs_gran_getsize(const struct hypfs_entry *entry)
     return strlen(gran) + 1;
 }
 
-static int cpupool_gran_write(struct hypfs_entry_leaf *leaf,
-                              XEN_GUEST_HANDLE_PARAM(const_void) uaddr,
-                              unsigned int ulen)
+static int cf_check cpupool_gran_write(
+    struct hypfs_entry_leaf *leaf, XEN_GUEST_HANDLE_PARAM(const_void) uaddr,
+    unsigned int ulen)
 {
     const struct hypfs_dyndir_id *data;
     struct cpupool *cpupool;
diff --git a/xen/include/xen/hypfs.h b/xen/include/xen/hypfs.h
index e9d4c2555bd7..1b65a9188c6c 100644
--- a/xen/include/xen/hypfs.h
+++ b/xen/include/xen/hypfs.h
@@ -168,31 +168,30 @@ void hypfs_add_dyndir(struct hypfs_entry_dir *parent,
                       struct hypfs_entry_dir *template);
 int hypfs_add_leaf(struct hypfs_entry_dir *parent,
                    struct hypfs_entry_leaf *leaf, bool nofault);
-const struct hypfs_entry *hypfs_node_enter(const struct hypfs_entry *entry);
-void hypfs_node_exit(const struct hypfs_entry *entry);
-int hypfs_read_dir(const struct hypfs_entry *entry,
-                   XEN_GUEST_HANDLE_PARAM(void) uaddr);
-int hypfs_read_leaf(const struct hypfs_entry *entry,
-                    XEN_GUEST_HANDLE_PARAM(void) uaddr);
-int hypfs_write_deny(struct hypfs_entry_leaf *leaf,
-                     XEN_GUEST_HANDLE_PARAM(const_void) uaddr,
-                     unsigned int ulen);
-int hypfs_write_leaf(struct hypfs_entry_leaf *leaf,
-                     XEN_GUEST_HANDLE_PARAM(const_void) uaddr,
-                     unsigned int ulen);
-int hypfs_write_bool(struct hypfs_entry_leaf *leaf,
-                     XEN_GUEST_HANDLE_PARAM(const_void) uaddr,
-                     unsigned int ulen);
-int hypfs_write_custom(struct hypfs_entry_leaf *leaf,
-                       XEN_GUEST_HANDLE_PARAM(const_void) uaddr,
-                       unsigned int ulen);
-unsigned int hypfs_getsize(const struct hypfs_entry *entry);
-struct hypfs_entry *hypfs_leaf_findentry(const struct hypfs_entry_dir *dir,
-                                         const char *name,
-                                         unsigned int name_len);
-struct hypfs_entry *hypfs_dir_findentry(const struct hypfs_entry_dir *dir,
-                                        const char *name,
-                                        unsigned int name_len);
+const struct hypfs_entry *cf_check hypfs_node_enter(
+    const struct hypfs_entry *entry);
+void cf_check hypfs_node_exit(const struct hypfs_entry *entry);
+int cf_check hypfs_read_dir(const struct hypfs_entry *entry,
+                            XEN_GUEST_HANDLE_PARAM(void) uaddr);
+int cf_check hypfs_read_leaf(const struct hypfs_entry *entry,
+                             XEN_GUEST_HANDLE_PARAM(void) uaddr);
+int cf_check hypfs_write_deny(struct hypfs_entry_leaf *leaf,
+                              XEN_GUEST_HANDLE_PARAM(const_void) uaddr,
+                              unsigned int ulen);
+int cf_check hypfs_write_leaf(struct hypfs_entry_leaf *leaf,
+                              XEN_GUEST_HANDLE_PARAM(const_void) uaddr,
+                              unsigned int ulen);
+int cf_check hypfs_write_bool(struct hypfs_entry_leaf *leaf,
+                              XEN_GUEST_HANDLE_PARAM(const_void) uaddr,
+                              unsigned int ulen);
+int cf_check hypfs_write_custom(struct hypfs_entry_leaf *leaf,
+                                XEN_GUEST_HANDLE_PARAM(const_void) uaddr,
+                                unsigned int ulen);
+unsigned int cf_check hypfs_getsize(const struct hypfs_entry *entry);
+struct hypfs_entry *cf_check hypfs_leaf_findentry(
+    const struct hypfs_entry_dir *dir, const char *name, unsigned int name_len);
+struct hypfs_entry *cf_check hypfs_dir_findentry(
+    const struct hypfs_entry_dir *dir, const char *name, unsigned int name_len);
 void *hypfs_alloc_dyndata(unsigned long size);
 #define hypfs_alloc_dyndata(type) ((type *)hypfs_alloc_dyndata(sizeof(type)))
 void *hypfs_get_dyndata(void);
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:16:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:16:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271957.466731 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbDu-0005LI-6C; Mon, 14 Feb 2022 13:16:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271957.466731; Mon, 14 Feb 2022 13:16:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbDu-0005L3-1a; Mon, 14 Feb 2022 13:16:58 +0000
Received: by outflank-mailman (input) for mailman id 271957;
 Mon, 14 Feb 2022 13:16:57 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJb3b-0008IH-7q
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:06:19 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e5622eb6-8d96-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 14:06:17 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e5622eb6-8d96-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644843977;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=lw78qzzzuiYAtb4DaXkKqrMnrmW0OepdLJjLyhv/BGI=;
  b=W9n8TYnjPjjYwOzqjane4XyVrnSWiI/J32ZALF4kLtTR4fno/J6EzjxR
   L5wXZQ76dYH1hv22eqrDnZof/g2b8nN8KUqgd7TlZAMRag05o0GRjGNtG
   7SHbhu2EaK6k7f4SlQnCine7MTFP00nEI5hjLH2n5QXbkscNXlEXBnroV
   Y=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: GiZ73pqCSnaQswr4ErlANhPRz8vWxZokQs4C0FBQcFZXfCidf60HFdYdTd2usiV/4U3k7KkZj0
 ZgqndL5rtOQOTlLuIhZY2QgsYcO5ZKhsO+7sAoXzTqD8M+AiC05Nb1xzhjaNqL9sLm6F613k5p
 EutSoSYZ0Jn6/SJNiwdLvkFPKhywz3hQ0iQbUeaXNzQimGc7Z0oO9fFNmqYfIjGokplOGfNcgZ
 E7snI3yZJ3Atgy0EZf1Z+uL61s1RG2QibSY94225E2N1x369piJQhUsORPDztGDywMupsc9WXH
 U+db3yoTiU8ThmrKHa8ySRA1
X-SBRS: 5.1
X-MesageID: 64149893
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:fa50kqLNV0ODhaYOFE+Rz5IlxSXFcZb7ZxGr2PjKsXjdYENS1jcOz
 jQeXW7UO/aMajf0LdBxbo6+pxsPvsXWyIBgGgdlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokcxIn5BC5C5xZVG/fjgqoHUVaiUakideSc+EH170Ug6x7Zg6mJVqYPR7z2l6
 IuaT/L3YDdJ6xYsWo7Dw/vewP/HlK2aVAIw5jTSV9gS1LPtvyB94KYkDbOwNxPFrrx8RYZWc
 QphIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbrGvaUXe345iXMfwZ3u7hB2th45q8
 8xGtKfsEyYQY7H2t/QBaANXRnQW0a1uoNcrIFC6uM2XiUbHb2Ht07NlC0Re0Y8wo7gtRzsUr
 LpBdW5LPkvra+GemdpXTsFFgMg5IdatF4QYonx6lhnSDOo8QICFSKLPjTNd9Gls35wfTaeFD
 yYfQX00LwrHSg9qAAgwOoswk9+ZjHXjShQN/Tp5ooJoujOOnWSdyoPFINfTP9CHW8hRtkKZv
 X7duXT0BAkAM96SwibD9Wij7tIjhguiBthUTufhsKc33hvDnQT/FSH6S3OfuaeisVe1WukDc
 W0tpzYUgrguz1akG4yVswKDnFaIuRsVWtx1GuI86R2Qxqe83zt1FlToXRYaNoV46ZZeqSgCk
 wbQwoi3XWAHXKi9FCrFnop4uw9eLsT8wYUqQSYfBTUI7ND4yG3YpkKeF40zeEJZYzCcJN0R/
 9xohHVk71nwpZRSv0lewbwgq2jyzqUltiZvum3qspuNt2uVnrKNaY2y8kT85v1dNoufRVTpl
 CFax5TBvLBTUMnUz3blrAAx8FaBvajtDdEhqQQ3Q8lJG8qFpxZPgry8EBkhfRw0Y67oiBfiY
 VPJuBM52XOgFCDCUEODWKroU55C5fG5TbzND6mIBvITMskZXFLWp0lGOB/Pt10BZWBxyMnTz
 7/AKp3yZZvbYIw6pAeLqxA1j+N6mHBmnTmLLX05pjz+uYejiLeuYe9tGDOzgioRsctoeS3Zr
 IRSMdWk0RJaXLGsayXb69dLf1sLMWI6Fdb9rMkOLryPJQ9vGWcADf7NwOx+J9w5zvoNzuqYr
 GugXkJ4yUbkgSGVIwu9dX0+OqjkWoxyrCxnMHV0b0qowXUqfa2m8LwbK8ksZbAi+eE6lax0Q
 vAJdt+uGPNKTjibqT0RYYOk9N5pdQixhBLINC2gOWBtc5llTg3P29nlYgqwq3VeUnvp7ZMz+
 uTy2BnaTJwPQxVZIPzXMP//nUmsuXU9mf5pWxeaKNdkZ0ixopNhLDb8j6FrLphUewnD3DaTy
 y2fHQwc+bvWu4Yw/dTE2fKEooOuH7csF0ZWBTCGv7O/NC2c9Wu/245QFu2PeGmFBm/z/ayjY
 8RTzu39b6JbzAob7dIkHuY517866vvuu6Ren1ZtE3j8Zli2Dq9tfyud1s5Vu6wRnrJUtGNag
 K5UFgW27VlRBP7YLQ==
IronPort-HdrOrdr: A9a23:Qef3WKgwrG4UduGeoQJ/ya/4nnBQXtgji2hC6mlwRA09TySZ//
 rBoB17726MtN9/YhEdcLy7VJVoBEmskKKdgrNhW4tKPjOW21dARbsKheCJrgEIWReOktK1vZ
 0QFJSWY+eQMbEVt6nHCXGDYrQd/OU=
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="64149893"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v2 29/70] xen/console: CFI hardening
Date: Mon, 14 Feb 2022 12:50:46 +0000
Message-ID: <20220214125127.17985-30-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

Control Flow Integrity schemes use toolchain and optionally hardware support
to help protect against call/jump/return oriented programming attacks.

Use cf_check to annotate function pointer targets for the toolchain.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
 xen/drivers/char/console.c   |  4 ++--
 xen/drivers/char/ehci-dbgp.c | 24 +++++++++++++-----------
 xen/drivers/char/ns16550.c   | 26 +++++++++++++-------------
 3 files changed, 28 insertions(+), 26 deletions(-)

diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c
index 380765ab02fd..d9d6556c2293 100644
--- a/xen/drivers/char/console.c
+++ b/xen/drivers/char/console.c
@@ -552,7 +552,7 @@ static void __serial_rx(char c, struct cpu_user_regs *regs)
 #endif
 }
 
-static void serial_rx(char c, struct cpu_user_regs *regs)
+static void cf_check serial_rx(char c, struct cpu_user_regs *regs)
 {
     static int switch_code_count = 0;
 
@@ -1286,7 +1286,7 @@ void panic(const char *fmt, ...)
  * **************************************************************
  */
 
-static void suspend_steal_fn(const char *str, size_t nr) { }
+static void cf_check suspend_steal_fn(const char *str, size_t nr) { }
 static int suspend_steal_id;
 
 int console_suspend(void)
diff --git a/xen/drivers/char/ehci-dbgp.c b/xen/drivers/char/ehci-dbgp.c
index a6b57fdf2d19..e205c0da6a61 100644
--- a/xen/drivers/char/ehci-dbgp.c
+++ b/xen/drivers/char/ehci-dbgp.c
@@ -1000,13 +1000,15 @@ static int ehci_dbgp_external_startup(struct ehci_dbgp *dbgp)
 
 typedef void (*set_debug_port_t)(struct ehci_dbgp *, unsigned int);
 
-static void default_set_debug_port(struct ehci_dbgp *dbgp, unsigned int port)
+static void cf_check default_set_debug_port(
+    struct ehci_dbgp *dbgp, unsigned int port)
 {
 }
 
 static set_debug_port_t __read_mostly set_debug_port = default_set_debug_port;
 
-static void nvidia_set_debug_port(struct ehci_dbgp *dbgp, unsigned int port)
+static void cf_check nvidia_set_debug_port(
+    struct ehci_dbgp *dbgp, unsigned int port)
 {
     uint32_t dword = pci_conf_read32(PCI_SBDF(0, dbgp->bus, dbgp->slot,
                                               dbgp->func), 0x74);
@@ -1167,7 +1169,7 @@ static inline void _ehci_dbgp_flush(struct ehci_dbgp *dbgp)
     dbgp->out.chunk = 0;
 }
 
-static void ehci_dbgp_flush(struct serial_port *port)
+static void cf_check ehci_dbgp_flush(struct serial_port *port)
 {
     struct ehci_dbgp *dbgp = port->uart;
     s_time_t goal;
@@ -1196,7 +1198,7 @@ static void ehci_dbgp_flush(struct serial_port *port)
        set_timer(&dbgp->timer, goal);
 }
 
-static void ehci_dbgp_putc(struct serial_port *port, char c)
+static void cf_check ehci_dbgp_putc(struct serial_port *port, char c)
 {
     struct ehci_dbgp *dbgp = port->uart;
 
@@ -1209,7 +1211,7 @@ static void ehci_dbgp_putc(struct serial_port *port, char c)
         ehci_dbgp_flush(port);
 }
 
-static int ehci_dbgp_tx_ready(struct serial_port *port)
+static int cf_check ehci_dbgp_tx_ready(struct serial_port *port)
 {
     struct ehci_dbgp *dbgp = port->uart;
 
@@ -1228,7 +1230,7 @@ static int ehci_dbgp_tx_ready(struct serial_port *port)
            (dbgp->state == dbgp_idle) * DBGP_MAX_PACKET;
 }
 
-static int ehci_dbgp_getc(struct serial_port *port, char *pc)
+static int cf_check ehci_dbgp_getc(struct serial_port *port, char *pc)
 {
     struct ehci_dbgp *dbgp = port->uart;
 
@@ -1309,7 +1311,7 @@ static bool_t ehci_dbgp_setup_preirq(struct ehci_dbgp *dbgp)
     return 0;
 }
 
-static void __init ehci_dbgp_init_preirq(struct serial_port *port)
+static void __init cf_check ehci_dbgp_init_preirq(struct serial_port *port)
 {
     struct ehci_dbgp *dbgp = port->uart;
     u32 debug_port, offset;
@@ -1358,7 +1360,7 @@ static void ehci_dbgp_setup_postirq(struct ehci_dbgp *dbgp)
     set_timer(&dbgp->timer, NOW() + MILLISECS(1));
 }
 
-static void __init ehci_dbgp_init_postirq(struct serial_port *port)
+static void __init cf_check ehci_dbgp_init_postirq(struct serial_port *port)
 {
     struct ehci_dbgp *dbgp = port->uart;
 
@@ -1409,12 +1411,12 @@ static int ehci_dbgp_check_release(struct ehci_dbgp *dbgp)
     return 0;
 }
 
-static void __init ehci_dbgp_endboot(struct serial_port *port)
+static void __init cf_check ehci_dbgp_endboot(struct serial_port *port)
 {
     ehci_dbgp_check_release(port->uart);
 }
 
-static void ehci_dbgp_suspend(struct serial_port *port)
+static void cf_check ehci_dbgp_suspend(struct serial_port *port)
 {
     struct ehci_dbgp *dbgp = port->uart;
 
@@ -1431,7 +1433,7 @@ static void ehci_dbgp_suspend(struct serial_port *port)
     dbgp->state = dbgp_unsafe;
 }
 
-static void ehci_dbgp_resume(struct serial_port *port)
+static void cf_check ehci_dbgp_resume(struct serial_port *port)
 {
     struct ehci_dbgp *dbgp = port->uart;
 
diff --git a/xen/drivers/char/ns16550.c b/xen/drivers/char/ns16550.c
index 990cad39fe85..8df1ee4d5c2c 100644
--- a/xen/drivers/char/ns16550.c
+++ b/xen/drivers/char/ns16550.c
@@ -174,7 +174,7 @@ static void handle_dw_usr_busy_quirk(struct ns16550 *uart)
     }
 }
 
-static void ns16550_interrupt(
+static void cf_check ns16550_interrupt(
     int irq, void *dev_id, struct cpu_user_regs *regs)
 {
     struct serial_port *port = dev_id;
@@ -239,7 +239,7 @@ static void cf_check ns16550_poll(void *data)
 #endif
 }
 
-static int ns16550_tx_ready(struct serial_port *port)
+static int cf_check ns16550_tx_ready(struct serial_port *port)
 {
     struct ns16550 *uart = port->uart;
 
@@ -250,13 +250,13 @@ static int ns16550_tx_ready(struct serial_port *port)
               uart->lsr_mask ) == uart->lsr_mask ) ? uart->fifo_size : 0;
 }
 
-static void ns16550_putc(struct serial_port *port, char c)
+static void cf_check ns16550_putc(struct serial_port *port, char c)
 {
     struct ns16550 *uart = port->uart;
     ns_write_reg(uart, UART_THR, c);
 }
 
-static int ns16550_getc(struct serial_port *port, char *pc)
+static int cf_check ns16550_getc(struct serial_port *port, char *pc)
 {
     struct ns16550 *uart = port->uart;
 
@@ -344,7 +344,7 @@ static void ns16550_setup_preirq(struct ns16550 *uart)
                  UART_FCR_ENABLE | UART_FCR_CLRX | UART_FCR_CLTX | UART_FCR_TRG14);
 }
 
-static void __init ns16550_init_preirq(struct serial_port *port)
+static void __init cf_check ns16550_init_preirq(struct serial_port *port)
 {
     struct ns16550 *uart = port->uart;
 
@@ -373,7 +373,7 @@ static void __init ns16550_init_preirq(struct serial_port *port)
         uart->fifo_size = 16;
 }
 
-static void __init ns16550_init_irq(struct serial_port *port)
+static void __init cf_check ns16550_init_irq(struct serial_port *port)
 {
 #ifdef NS16550_PCI
     struct ns16550 *uart = port->uart;
@@ -399,7 +399,7 @@ static void ns16550_setup_postirq(struct ns16550 *uart)
         set_timer(&uart->timer, NOW() + MILLISECS(uart->timeout_ms));
 }
 
-static void __init ns16550_init_postirq(struct serial_port *port)
+static void __init cf_check ns16550_init_postirq(struct serial_port *port)
 {
     struct ns16550 *uart = port->uart;
     int rc, bits;
@@ -491,7 +491,7 @@ static void __init ns16550_init_postirq(struct serial_port *port)
     ns16550_setup_postirq(uart);
 }
 
-static void ns16550_suspend(struct serial_port *port)
+static void cf_check ns16550_suspend(struct serial_port *port)
 {
     struct ns16550 *uart = port->uart;
 
@@ -543,7 +543,7 @@ static void cf_check ns16550_delayed_resume(void *data)
         _ns16550_resume(port);
 }
 
-static void ns16550_resume(struct serial_port *port)
+static void cf_check ns16550_resume(struct serial_port *port)
 {
     struct ns16550 *uart = port->uart;
 
@@ -569,7 +569,7 @@ static void ns16550_resume(struct serial_port *port)
         _ns16550_resume(port);
 }
 
-static void __init ns16550_endboot(struct serial_port *port)
+static void __init cf_check ns16550_endboot(struct serial_port *port)
 {
 #ifdef CONFIG_HAS_IOPORTS
     struct ns16550 *uart = port->uart;
@@ -583,13 +583,13 @@ static void __init ns16550_endboot(struct serial_port *port)
 #endif
 }
 
-static int __init ns16550_irq(struct serial_port *port)
+static int __init cf_check ns16550_irq(struct serial_port *port)
 {
     struct ns16550 *uart = port->uart;
     return ((uart->irq > 0) ? uart->irq : -1);
 }
 
-static void ns16550_start_tx(struct serial_port *port)
+static void cf_check ns16550_start_tx(struct serial_port *port)
 {
     struct ns16550 *uart = port->uart;
     u8 ier = ns_read_reg(uart, UART_IER);
@@ -599,7 +599,7 @@ static void ns16550_start_tx(struct serial_port *port)
         ns_write_reg(uart, UART_IER, ier | UART_IER_ETHREI);
 }
 
-static void ns16550_stop_tx(struct serial_port *port)
+static void cf_check ns16550_stop_tx(struct serial_port *port)
 {
     struct ns16550 *uart = port->uart;
     u8 ier = ns_read_reg(uart, UART_IER);
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:17:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:17:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271967.466742 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbDx-0005rX-Fs; Mon, 14 Feb 2022 13:17:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271967.466742; Mon, 14 Feb 2022 13:17:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbDx-0005rK-Aw; Mon, 14 Feb 2022 13:17:01 +0000
Received: by outflank-mailman (input) for mailman id 271967;
 Mon, 14 Feb 2022 13:16:59 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJb3X-00023t-Jd
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:06:15 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e1f7365e-8d96-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 14:06:13 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e1f7365e-8d96-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644843973;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=DvkxBtgSCdVebD4VLLY7NY7aTsNOKJgA8KGiz3D+sSg=;
  b=eJhUdTZvvPYd/WrwQI3bWhTwZ10S20HPK3m9Goxbd4liaygh3v0UwdSm
   /N9g1sH+xQLRNT0/105XjBkOpOKWCwC4H7+P2Sg1qUL6B5MdEmS4+3+ms
   vM8ACionfM6LtMxR1SQD7953sQKAgG0uruCjutHUDIFL+VlQlzuOgtBno
   Q=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: uFd/8GjHXGZn2dw6P4h4cbueAJDEKi1MZmt9mLEP8k+l6RAKBQXr1MzE9QmMnkkpeDWJ08xksG
 yLK8BxkUldtzrwIthLtrOkRgAhmiwhnLDMysXkT69oarGUuU5/keO05v1LUZNnQd8bg8iwEoN5
 otcgzdMBjBAbDbXOqdEExE8U5R9n6XDqLbbA8bVsQZLWFV8x/TUmFdu5+2GEcS696Ui2MhiGdV
 5vIm+buc0r/Wg9VbRODd1gE7wAP+cKnaFQT3olvbo5a1EFOhvdqnvT0gNNSPQef70cd5gQ6T5U
 412AOROA4hzc2UKKK6WgToDp
X-SBRS: 5.1
X-MesageID: 66374944
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:UsFTTKKx31Cik8p2FE+RzpIlxSXFcZb7ZxGr2PjKsXjdYENS1WMDn
 WdLD26FPKuCYjegLY8ga4Wy8hhTv8TQyIBqSlZlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokcxIn5BC5C5xZVG/fjgqoHUVaiUakideSc+EH170Ug6x7Zg6mJVqYPR7z2l6
 IuaT/L3YDdJ6xYsWo7Dw/vewP/HlK2aVAIw5jTSV9gS1LPtvyB94KYkDbOwNxPFrrx8RYZWc
 QphIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbrGvaUXe345iXMfwZ3u7hB2Hn9J1l
 e1G5aC9SAYJHpXNvOo5egFxRnQW0a1uoNcrIFC6uM2XiUbHb2Ht07NlC0Re0Y8wo7gtRzsUr
 LpBdW5LPkvra+GemdpXTsFFgMg5IdatF4QYonx6lhnSDOo8QICFSKLPjTNd9Glu3Z8STKqCD
 yYfQRQ+PRXKfiFBAUoKK40Smuisoyb4YxQN/Tp5ooJoujOOnWSdyoPFINfTP9CHW8hRtkKZv
 X7duXT0BAkAM96SwibD9Wij7tIjhguiBthUTufhsKc33hvDnQT/FSH6S3O1ofu913a1C+5SK
 k002hIviaYW3VSCG4yVswKDnFaIuRsVWtx1GuI86R2Qxqe83zt1FlToXRYaNoV46ZZeqSgCk
 wbQwoi3XWAHXKi9FCrFnop4uw9eLsT8wYUqQSYfBTUI7ND4yG3YpkKeF40zeEJZYzCcJN0R/
 9xohHVk71nwpZRSv0lewbwgq2jyzqUltiZvum3qspuNt2uVnrKNaY2y8kT85v1dNoufRVTpl
 CFax5TBvLBTUMnUz3blrAAx8FaBvajtDdEhqQQ3Q8lJG8qFpxZPgry8EBkhfRw0Y67oiBfiY
 VPJuBM52XOgFCDCUEODWKroU55C5fG5TbzND6mIBvITMskZXFLWp0lGOB/Pt10BZWBxyMnTz
 7/AKp3yZZvbYIw6pAeLqxA1j+N1mHBkmD+7qFKS503P7IdyrUW9Ed8tWGZipMhghE9diAmKo
 dtZKeWQzBBTDL/3biXNqNZBJlEWN3krQ5vxrpUPJOKEJwNnHkAnCuPQnux9K9A0wfwNm7ea5
 Gy5V29Z1EH72S/NJzKVZy0xc7joR5t+8y42ZHR+IVay1nE/So+z96NDJYAvdLwq+bU7n/55R
 vUIYeuaBfFLRmiV8jgRd8Cl/odjaA6qlUSFOC/8OGozeJtpRgro/N74f1SwqHlSX3Tv7cZn+
 u+uzALWR5YHVj9ONseOZaL91U61sFgchPl2AxnCLO5MdRi+64NtMSHw0KM6epleNRXZyzKG/
 A+KGhNE9/LVqoo4/dSV16CJq4ClT7l3EkZARjSJ6L+3MW/R/3a5wJ8GW+GNJGiPWGTx8aSkR
 ONU0/Cjb6FXwAcU69JxQ+Rx0KYzx9rzvLsLnA1rEULCY0mvFr49cGKN2tNCt/EVy7JU0edst
 pljJjWO1W21Bf7Y
IronPort-HdrOrdr: A9a23:wU3Gn6DZKqzyMFblHemo55DYdb4zR+YMi2TC1yhKKCC9E/bo7/
 xG885rtiMc5Ax/ZJhko6HlBEDiewKkyXcW2/hyAV7KZmCP0wHEQL2Kr7GSpAEIcxeOkNK1vp
 0BT0ERMrPN5CBB/KPH3DU=
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="66374944"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v2 40/70] x86/idle: CFI hardening
Date: Mon, 14 Feb 2022 12:50:57 +0000
Message-ID: <20220214125127.17985-41-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

Control Flow Integrity schemes use toolchain and optionally hardware support
to help protect against call/jump/return oriented programming attacks.

Use cf_check to annotate function pointer targets for the toolchain.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
 xen/arch/x86/acpi/cpu_idle.c                 | 31 +++++++++++++++++++++-------
 xen/arch/x86/acpi/cpuidle_menu.c             |  6 +++---
 xen/arch/x86/cpu/mwait-idle.c                |  2 +-
 xen/arch/x86/domain.c                        |  6 +++---
 xen/arch/x86/hpet.c                          |  4 ++--
 xen/arch/x86/include/asm/cpuidle.h           |  4 ++--
 xen/arch/x86/include/asm/hpet.h              |  4 ++--
 xen/arch/x86/include/asm/time.h              |  6 +++---
 xen/arch/x86/time.c                          |  6 +++---
 xen/drivers/cpufreq/cpufreq_misc_governors.c | 14 ++++++-------
 10 files changed, 49 insertions(+), 34 deletions(-)

diff --git a/xen/arch/x86/acpi/cpu_idle.c b/xen/arch/x86/acpi/cpu_idle.c
index 0142671bb836..557bc6ef8642 100644
--- a/xen/arch/x86/acpi/cpu_idle.c
+++ b/xen/arch/x86/acpi/cpu_idle.c
@@ -75,7 +75,7 @@
 #define GET_CC7_RES(val)  GET_HW_RES_IN_NS(0x3FE, val) /* SNB onwards */
 #define PHI_CC6_RES(val)  GET_HW_RES_IN_NS(0x3FF, val) /* Xeon Phi only */
 
-static void lapic_timer_nop(void) { }
+static void cf_check lapic_timer_nop(void) { }
 void (*__read_mostly lapic_timer_off)(void);
 void (*__read_mostly lapic_timer_on)(void);
 
@@ -310,12 +310,27 @@ static char* acpi_cstate_method_name[] =
     "HALT"
 };
 
-static uint64_t get_stime_tick(void) { return (uint64_t)NOW(); }
-static uint64_t stime_ticks_elapsed(uint64_t t1, uint64_t t2) { return t2 - t1; }
-static uint64_t stime_tick_to_ns(uint64_t ticks) { return ticks; }
+static uint64_t cf_check get_stime_tick(void)
+{
+    return NOW();
+}
+
+static uint64_t cf_check stime_ticks_elapsed(uint64_t t1, uint64_t t2)
+{
+    return t2 - t1;
+}
+
+static uint64_t cf_check stime_tick_to_ns(uint64_t ticks)
+{
+    return ticks;
+}
+
+static uint64_t cf_check get_acpi_pm_tick(void)
+{
+    return inl(pmtmr_ioport);
+}
 
-static uint64_t get_acpi_pm_tick(void) { return (uint64_t)inl(pmtmr_ioport); }
-static uint64_t acpi_pm_ticks_elapsed(uint64_t t1, uint64_t t2)
+static uint64_t cf_check acpi_pm_ticks_elapsed(uint64_t t1, uint64_t t2)
 {
     if ( t2 >= t1 )
         return (t2 - t1);
@@ -664,7 +679,7 @@ void update_idle_stats(struct acpi_processor_power *power,
     spin_unlock(&power->stat_lock);
 }
 
-static void acpi_processor_idle(void)
+static void cf_check acpi_processor_idle(void)
 {
     unsigned int cpu = smp_processor_id();
     struct acpi_processor_power *power = processor_powers[cpu];
@@ -869,7 +884,7 @@ static void acpi_processor_idle(void)
         cpuidle_current_governor->reflect(power);
 }
 
-void acpi_dead_idle(void)
+void cf_check acpi_dead_idle(void)
 {
     struct acpi_processor_power *power;
     struct acpi_processor_cx *cx;
diff --git a/xen/arch/x86/acpi/cpuidle_menu.c b/xen/arch/x86/acpi/cpuidle_menu.c
index 6ff5fb8ff215..a275436d799c 100644
--- a/xen/arch/x86/acpi/cpuidle_menu.c
+++ b/xen/arch/x86/acpi/cpuidle_menu.c
@@ -185,7 +185,7 @@ static unsigned int get_sleep_length_us(void)
     return (us >> 32) ? (unsigned int)-2000 : (unsigned int)us;
 }
 
-static int menu_select(struct acpi_processor_power *power)
+static int cf_check menu_select(struct acpi_processor_power *power)
 {
     struct menu_device *data = &this_cpu(menu_devices);
     int i;
@@ -237,7 +237,7 @@ static int menu_select(struct acpi_processor_power *power)
     return data->last_state_idx;
 }
 
-static void menu_reflect(struct acpi_processor_power *power)
+static void cf_check menu_reflect(struct acpi_processor_power *power)
 {
     struct menu_device *data = &this_cpu(menu_devices);
     u64 new_factor;
@@ -275,7 +275,7 @@ static void menu_reflect(struct acpi_processor_power *power)
     data->correction_factor[data->bucket] = new_factor;
 }
 
-static int menu_enable_device(struct acpi_processor_power *power)
+static int cf_check menu_enable_device(struct acpi_processor_power *power)
 {
     memset(&per_cpu(menu_devices, power->cpu), 0, sizeof(struct menu_device));
 
diff --git a/xen/arch/x86/cpu/mwait-idle.c b/xen/arch/x86/cpu/mwait-idle.c
index 927ce1b67aa5..f76c64e04b20 100644
--- a/xen/arch/x86/cpu/mwait-idle.c
+++ b/xen/arch/x86/cpu/mwait-idle.c
@@ -773,7 +773,7 @@ static const struct cpuidle_state snr_cstates[] = {
 	{}
 };
 
-static void mwait_idle(void)
+static void cf_check mwait_idle(void)
 {
 	unsigned int cpu = smp_processor_id();
 	struct acpi_processor_power *power = processor_powers[cpu];
diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c
index 1c3a1ec2a080..ae7c88b51af1 100644
--- a/xen/arch/x86/domain.c
+++ b/xen/arch/x86/domain.c
@@ -74,11 +74,11 @@
 
 DEFINE_PER_CPU(struct vcpu *, curr_vcpu);
 
-static void default_idle(void);
+static void cf_check default_idle(void);
 void (*pm_idle) (void) __read_mostly = default_idle;
 void (*dead_idle) (void) __read_mostly = default_dead_idle;
 
-static void default_idle(void)
+static void cf_check default_idle(void)
 {
     struct cpu_info *info = get_cpu_info();
 
@@ -93,7 +93,7 @@ static void default_idle(void)
         local_irq_enable();
 }
 
-void default_dead_idle(void)
+void cf_check default_dead_idle(void)
 {
     /*
      * When going into S3, without flushing caches modified data may be
diff --git a/xen/arch/x86/hpet.c b/xen/arch/x86/hpet.c
index c31fd97579dc..20fca839907c 100644
--- a/xen/arch/x86/hpet.c
+++ b/xen/arch/x86/hpet.c
@@ -709,7 +709,7 @@ void hpet_disable_legacy_broadcast(void)
     smp_send_event_check_mask(&cpu_online_map);
 }
 
-void hpet_broadcast_enter(void)
+void cf_check hpet_broadcast_enter(void)
 {
     unsigned int cpu = smp_processor_id();
     struct hpet_event_channel *ch = per_cpu(cpu_bc_channel, cpu);
@@ -740,7 +740,7 @@ void hpet_broadcast_enter(void)
     spin_unlock(&ch->lock);
 }
 
-void hpet_broadcast_exit(void)
+void cf_check hpet_broadcast_exit(void)
 {
     unsigned int cpu = smp_processor_id();
     struct hpet_event_channel *ch = per_cpu(cpu_bc_channel, cpu);
diff --git a/xen/arch/x86/include/asm/cpuidle.h b/xen/arch/x86/include/asm/cpuidle.h
index 0981a8fd6417..3edd7a75d2ef 100644
--- a/xen/arch/x86/include/asm/cpuidle.h
+++ b/xen/arch/x86/include/asm/cpuidle.h
@@ -17,8 +17,8 @@ extern uint64_t (*cpuidle_get_tick)(void);
 
 int mwait_idle_init(struct notifier_block *);
 int cpuidle_init_cpu(unsigned int cpu);
-void default_dead_idle(void);
-void acpi_dead_idle(void);
+void cf_check default_dead_idle(void);
+void cf_check acpi_dead_idle(void);
 void play_dead(void);
 void trace_exit_reason(u32 *irq_traced);
 void update_idle_stats(struct acpi_processor_power *,
diff --git a/xen/arch/x86/include/asm/hpet.h b/xen/arch/x86/include/asm/hpet.h
index 8f9725a95e21..f343fe4740f1 100644
--- a/xen/arch/x86/include/asm/hpet.h
+++ b/xen/arch/x86/include/asm/hpet.h
@@ -91,8 +91,8 @@ void hpet_disable_legacy_replacement_mode(void);
  */
 void hpet_broadcast_init(void);
 void hpet_broadcast_resume(void);
-void hpet_broadcast_enter(void);
-void hpet_broadcast_exit(void);
+void cf_check hpet_broadcast_enter(void);
+void cf_check hpet_broadcast_exit(void);
 int hpet_broadcast_is_available(void);
 void hpet_disable_legacy_broadcast(void);
 
diff --git a/xen/arch/x86/include/asm/time.h b/xen/arch/x86/include/asm/time.h
index f06f2bfd8b8f..2a57d930ef30 100644
--- a/xen/arch/x86/include/asm/time.h
+++ b/xen/arch/x86/include/asm/time.h
@@ -43,11 +43,11 @@ int hwdom_pit_access(struct ioreq *ioreq);
 
 int cpu_frequency_change(u64 freq);
 
-void pit_broadcast_enter(void);
-void pit_broadcast_exit(void);
+void cf_check pit_broadcast_enter(void);
+void cf_check pit_broadcast_exit(void);
 int pit_broadcast_is_available(void);
 
-uint64_t acpi_pm_tick_to_ns(uint64_t ticks);
+uint64_t cf_check acpi_pm_tick_to_ns(uint64_t ticks);
 
 uint64_t tsc_ticks2ns(uint64_t ticks);
 
diff --git a/xen/arch/x86/time.c b/xen/arch/x86/time.c
index b6e690b76fab..043be2a8ec1a 100644
--- a/xen/arch/x86/time.c
+++ b/xen/arch/x86/time.c
@@ -545,7 +545,7 @@ static __init int cf_check init_pmtmr_scale(void)
 }
 __initcall(init_pmtmr_scale);
 
-uint64_t acpi_pm_tick_to_ns(uint64_t ticks)
+uint64_t cf_check acpi_pm_tick_to_ns(uint64_t ticks)
 {
     return scale_delta(ticks, &pmt_scale);
 }
@@ -2237,12 +2237,12 @@ static int __init cf_check disable_pit_irq(void)
 }
 __initcall(disable_pit_irq);
 
-void pit_broadcast_enter(void)
+void cf_check pit_broadcast_enter(void)
 {
     cpumask_set_cpu(smp_processor_id(), &pit_broadcast_mask);
 }
 
-void pit_broadcast_exit(void)
+void cf_check pit_broadcast_exit(void)
 {
     int cpu = smp_processor_id();
 
diff --git a/xen/drivers/cpufreq/cpufreq_misc_governors.c b/xen/drivers/cpufreq/cpufreq_misc_governors.c
index ad79d0f5d246..f5571f5486ab 100644
--- a/xen/drivers/cpufreq/cpufreq_misc_governors.c
+++ b/xen/drivers/cpufreq/cpufreq_misc_governors.c
@@ -26,8 +26,8 @@
 static unsigned int __read_mostly userspace_cmdline_freq;
 static DEFINE_PER_CPU(unsigned int, cpu_set_freq);
 
-static int cpufreq_governor_userspace(struct cpufreq_policy *policy,
-                                      unsigned int event)
+static int cf_check cpufreq_governor_userspace(
+    struct cpufreq_policy *policy, unsigned int event)
 {
     int ret = 0;
     unsigned int cpu;
@@ -81,7 +81,7 @@ int write_userspace_scaling_setspeed(unsigned int cpu, unsigned int freq)
     return __cpufreq_driver_target(policy, freq, CPUFREQ_RELATION_L);
 }
 
-static bool_t __init
+static bool __init cf_check
 cpufreq_userspace_handle_option(const char *name, const char *val)
 {
     if (!strcmp(name, "speed") && val) {
@@ -131,8 +131,8 @@ __initcall(cpufreq_gov_userspace_init);
 /*
  * cpufreq performance governor
  */
-static int cpufreq_governor_performance(struct cpufreq_policy *policy,
-                                      unsigned int event)
+static int cf_check cpufreq_governor_performance(
+    struct cpufreq_policy *policy, unsigned int event)
 {
     int ret = 0;
 
@@ -170,8 +170,8 @@ __initcall(cpufreq_gov_performance_init);
 /*
  * cpufreq powersave governor
  */
-static int cpufreq_governor_powersave(struct cpufreq_policy *policy,
-                                      unsigned int event)
+static int cf_check cpufreq_governor_powersave(
+    struct cpufreq_policy *policy, unsigned int event)
 {
     int ret = 0;
 
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:17:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:17:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271977.466753 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbE2-0006Vu-Pi; Mon, 14 Feb 2022 13:17:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271977.466753; Mon, 14 Feb 2022 13:17:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbE2-0006VW-K4; Mon, 14 Feb 2022 13:17:06 +0000
Received: by outflank-mailman (input) for mailman id 271977;
 Mon, 14 Feb 2022 13:17:04 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJb4d-0008IH-H1
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:07:23 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0b791dfc-8d97-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 14:07:21 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0b791dfc-8d97-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644844041;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=eqhKAymiA22/wB5PZk3BR4BeJKlUT2B+meSMBCt3MmU=;
  b=cpFSFB0Y6d6swQiujtITK9SsguSmgsaIDj9dd6Xpceg8NXh5iSw9viMS
   BwqVNgI5AC04Uz5BHTn7NXNkGBLiuzFdrlG45fB8OFN03xiBc3QJJN4Hg
   YeC9COwCJXP9HO4IB6CkOQp72n6SnGPx0REXQWqnL8twM8kB569LWyXOC
   0=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: +E6Enw6kwx7WWxt+vv6po0BIihZjUYHGHfpjS5XIMAvcmcdh12ggcmN2kZipUmE0QjWWe9i9j3
 HyJgdHhXRdaFYMK0qFjIlif5Bynr2nxfMpO8WZGSO2o4eZHUIOMIkIM+XGlLpTbo+1IHEytNNY
 +KaiB/akovSRepz1cbNPrWer1T+D82nSKjJW/huRNG3yV8syMoElL6Uv/fhp/zomF3xjqP/Hzb
 sPB0JGPk7aA7MJn1IlFwMwI6fzmK1wf0/+8PZzTGXt7gW2Aax7MpNontZL+mQ0A5bsPm+k3KrN
 q720fo+VRZGVn5Rx0DLjBfKf
X-SBRS: 5.1
X-MesageID: 64554438
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:SLMNT631puw+7FO/kfbD5cp2kn2cJEfYwER7XKvMYLTBsI5bpzIBz
 mIbCGyAMqneZWb0fI8kb9uzpEIG6MPXyNFjTQVqpC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkS5PE3oHJ9RGQ74nRLlbHILOCanAZqTNMEn9700o5wrJh2+aEvPDia++zk
 YKqyyHgEAfNNw5cagr4PIra9XuDFNyr0N8plgRWicJj5TcypFFMZH4rHomjLmOQf2VhNrXSq
 9Avbl2O1jixEx8FUrtJm1tgG6EAaua60QOm0hK6V0U+6/TrS+NbPqsTbZIhhUlrZzqhudIyw
 vlPqpeLbgo3Ooj2tfpDSkBHKnQrVUFG0OevzXmXtMWSywvNcmf2wuUoB0YzVWEa0r8pWycUr
 6VecW1TKEDY7w616OvTpu1Er8IvNsT0eqgYvWlt12rxBvc6W5HTBa7N4Le02R9u2p0TQaqFN
 6L1bxJ/TEiaIDkTNm47L585juOJmV3/KwJX/Qf9Sa0fvDGIkV0ZPKLWGMrYfJmGSNtYmm6cp
 3na5CLpDxcCLtudxDGZtHW2iYfycTjTAdxIUufir7gz3QPVljd75AAquUWTh/v6gGK8RNlkD
 EEK/g8UgLZs7RW0d4yoN/Gnm0KsshkZUttWNuQ17gCR16bZizqk6ng4oi1pM4J/6pJvLdA+/
 hrQxo6yW2Qz2FGAYS/Frt+pQSWO1T/5xIPoTQsNVkM77tbqu+nfZTqfH484QMZZYjAYcAwcI
 gxmTgBj3d3/buZRjs1XGGwrZBr2+PD0ovYdvFm/Y45cxloRiHSZT4Kp80PHyv1LMZyUSFKM1
 FBdxZTCs7BeUMzVzXfXKAnoIF1Oz6zbWAAwfHY1R8Vxn9hT0yLLkX9sDMFWex4yb5dslc7Ba
 07PowJBjKK/z1PxBZKbl7mZUpxwpYC5TIyNfqmNMrJmP8ggHCfarXoGTRPBgAjQfL0EzPhX1
 WGzKp33Ux73yM1PkVKLegvq+eF3mH5unz6PLX05pjz+uYejiLeuYe9tGDOzgioRtf/dyOkM2
 9oAZcaM1TtFV+jyPnve/YIJdAhYJnknH5Hm7cdQc7fbcAZhHWggDd7XwK8gJNM5z/gEyL+Q8
 yHvQFJcxXr+mWbDdVeAZEd8Ze69Rp14t386Y3AhZA76x3g5bI+zx64DbJ9rL6I//eluwKcsH
 fkIcsmNGNpVTTHD92hPZJXxttU6Jh+qmRiPL2yuZz1mJ8xsQAnA+9nFeArz9XZRUnrr5JVm+
 7D5j1HVW5sOQQhmHf36UvP3wgPjp2UZlcJzQ1DMfotZdnLz/dU4MCf2lPI2fZ0BcE2R2juA2
 g+KKh4Evu2R8ZQt+dzEiK3Y/YekF+xyQhhTE2XBtOvkMCDb+iyowJNaUfbOdjfYDTum9KKnb
 ORT7vf9LPxYwwoa79siS+5mnfAk+t/ih75G1QA1TnzEYmOiBq5kPnTbj9JEsbdAx+MBtAa7M
 q5VFgK25Vld1BvZLWMs
IronPort-HdrOrdr: A9a23:opt64K0SypVTil+K/JqNtAqjBLAkLtp133Aq2lEZdPRUGvb3qy
 nOpoVj6faaslYssR0b9exofZPwJE80lqQFh7X5X43SPzUO0VHAROoJgLcKgQeQfxEWntQtsp
 uIGJIeNDSfNzdHZL7BkWuFL+o=
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="64554438"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v2 28/70] xen/video: CFI hardening
Date: Mon, 14 Feb 2022 12:50:45 +0000
Message-ID: <20220214125127.17985-29-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

Control Flow Integrity schemes use toolchain and optionally hardware support
to help protect against call/jump/return oriented programming attacks.

Use cf_check to annotate function pointer targets for the toolchain.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
 xen/drivers/video/lfb.c  | 4 ++--
 xen/drivers/video/lfb.h  | 4 ++--
 xen/drivers/video/vesa.c | 4 ++--
 xen/drivers/video/vga.c  | 6 +++---
 4 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/xen/drivers/video/lfb.c b/xen/drivers/video/lfb.c
index 75b749b3303b..48c66f8acf10 100644
--- a/xen/drivers/video/lfb.c
+++ b/xen/drivers/video/lfb.c
@@ -53,7 +53,7 @@ static void lfb_show_line(
 }
 
 /* Fast mode which redraws all modified parts of a 2D text buffer. */
-void lfb_redraw_puts(const char *s, size_t nr)
+void cf_check lfb_redraw_puts(const char *s, size_t nr)
 {
     unsigned int i, min_redraw_y = lfb.ypos;
 
@@ -98,7 +98,7 @@ void lfb_redraw_puts(const char *s, size_t nr)
 }
 
 /* Slower line-based scroll mode which interacts better with dom0. */
-void lfb_scroll_puts(const char *s, size_t nr)
+void cf_check lfb_scroll_puts(const char *s, size_t nr)
 {
     unsigned int i;
 
diff --git a/xen/drivers/video/lfb.h b/xen/drivers/video/lfb.h
index e743ccdd6b11..42161402d611 100644
--- a/xen/drivers/video/lfb.h
+++ b/xen/drivers/video/lfb.h
@@ -35,8 +35,8 @@ struct lfb_prop {
     unsigned int text_rows;
 };
 
-void lfb_redraw_puts(const char *s, size_t nr);
-void lfb_scroll_puts(const char *s, size_t nr);
+void cf_check lfb_redraw_puts(const char *s, size_t nr);
+void cf_check lfb_scroll_puts(const char *s, size_t nr);
 void lfb_carriage_return(void);
 void lfb_free(void);
 
diff --git a/xen/drivers/video/vesa.c b/xen/drivers/video/vesa.c
index cb0e443be4dd..155bc09d3237 100644
--- a/xen/drivers/video/vesa.c
+++ b/xen/drivers/video/vesa.c
@@ -17,7 +17,7 @@
 
 #define vlfb_info    vga_console_info.u.vesa_lfb
 
-static void lfb_flush(void);
+static void cf_check lfb_flush(void);
 
 static unsigned char *lfb;
 static const struct font_desc *font;
@@ -177,7 +177,7 @@ void __init vesa_mtrr_init(void)
     } while ( (size_total >= PAGE_SIZE) && (rc == -EINVAL) );
 }
 
-static void lfb_flush(void)
+static void cf_check lfb_flush(void)
 {
     if ( vesa_mtrr == 3 )
         __asm__ __volatile__ ("sfence" : : : "memory");
diff --git a/xen/drivers/video/vga.c b/xen/drivers/video/vga.c
index b7f04d0d97f4..abe295e477b1 100644
--- a/xen/drivers/video/vga.c
+++ b/xen/drivers/video/vga.c
@@ -19,8 +19,8 @@ static int vgacon_keep;
 static unsigned int xpos, ypos;
 static unsigned char *video;
 
-static void vga_text_puts(const char *s, size_t nr);
-static void vga_noop_puts(const char *s, size_t nr) {}
+static void cf_check vga_text_puts(const char *s, size_t nr);
+static void cf_check vga_noop_puts(const char *s, size_t nr) {}
 void (*video_puts)(const char *, size_t nr) = vga_noop_puts;
 
 /*
@@ -175,7 +175,7 @@ void __init video_endboot(void)
     }
 }
 
-static void vga_text_puts(const char *s, size_t nr)
+static void cf_check vga_text_puts(const char *s, size_t nr)
 {
     for ( ; nr > 0; nr--, s++ )
     {
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:17:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:17:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271981.466763 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbE4-0006s8-Em; Mon, 14 Feb 2022 13:17:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271981.466763; Mon, 14 Feb 2022 13:17:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbE4-0006ra-8Z; Mon, 14 Feb 2022 13:17:08 +0000
Received: by outflank-mailman (input) for mailman id 271981;
 Mon, 14 Feb 2022 13:17:06 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJb3j-0008IH-HO
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:06:27 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e97f508c-8d96-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 14:06:26 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e97f508c-8d96-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644843986;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=nFVbC/4CTKrt9ePns4OmTby9fRX+JlbtvMjTI8nUB74=;
  b=G1ndp5xIyBMM1jx8qgAdJciOCeLvyMC7DK0peGismD3YL5hCMS35Eut3
   rq2x4xnJpHaKDkc1bcoC9WOV9ptsTBTYxqmckTH8qxynddPnIB6LC9QzO
   m5rjk/py9GlateWSD2xyMvtekAptnnpN+HqnNXPPlRVwsz1RqylRzY8Nc
   U=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: p1VJNay5+0TErJJlwhNVrDKyw911DBe46SFZfny+G1zGNcpra+QSgvbh3R4TpIu/E4DsDN95Fx
 nigN90rokMgW7BknA+b15rBCsGQsU4Cz2gCvzlq6s1PYwXtseCtQgH3kuspus9x2f/iMMUB7hF
 FQDtydm69u0mVPire4SFMveSYHRrwnJyEu+7IjDWtS4Thp3v8kW6OQja9FanHNmDbaWfluBkfa
 AoevsD/u/GXiq7iLu72VKJKIeF/sbQhT0XngIghxOGHmm3sS6A8uxwoxzELDvrV2tGLZh/muSR
 6w5kwkW8KO1Gfdh5I4YEw5Nd
X-SBRS: 5.1
X-MesageID: 64050671
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:T9o8dKj3gPBK031rkfVcT9nyX161XxcKZh0ujC45NGQN5FlHY01je
 htvWW6DOaqPZGanc91yb4nn8x5Q7MTTzoNhG1Y/pX1jFisb9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oAMKRCQ7InQLlbGILes1htZGEk0GE/NtTo5w7Rj2tQx3YDga++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /0RqsaCGAZuApfhhcgbbBgADjhfLfFZreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHCOo8Ft24m5jbeFfs8GrjIQrnQ5M8e1zA17ixLNaiCP
 5dBN2U2BPjGSxNTI3ASIrgApt3rqVjOSgIGmWCepZNitgA/yyQuieOwYbI5YOeiWsF9jkue4
 GXc8AzRIDsXKdiewjqt6W+3i6nEmiaTcJIfEvi0++BnhHWXx3cPE1sGWF2ju/67h0WiHdVFJ
 CQpFjEG9PZoshbxF5+kAkP+8CXsUgMgt8R4T/Jg2lCMjZbuzhu1AFcFFiNYScx6q5pjLdA17
 WOhk9TsDD1plbSaT3OB67uZxQ+P1TgpwXwqPnFdE1ZcizX3iMRq10+UEI4/eEKgpoCtQVnNL
 ya2QD/Sbln5peoCzO2F8F/OmFpATbCZH1dutm07so9Ihz6VhbJJhaT1szA3Dt4ade51q2VtW
 1BexaCjABgmV83lqcB0aLxl8EuVz/iEKibAplVkAoMs8T+gk1b6I9wMv2EueRoxa51eEdMMX
 KM0kVkPjKK/wVPwNfMnC25PI5hCIVfc+STNCamPM4smjmlZfw6b5iB+DXN8LEi2+HXAZZoXY
 M/BGe71VC5yIf0+kFKeGrdMuZd2l3tW7T6CGvjGI+GPjOP2iIi9EuxebjNjr4kRscu5neki2
 4gDaZXakUgDOAA8CwGOmbMuwZkxBSBTLfjLRwZ/L7DrztNOFD5zBvnP76kmfoA5za1Zmv2Rp
 iO2W1NCyUq5jnrCcF3YZndmYbLpfJB+sXNkYnB8YQf2gyAuMdS18aMSV5orZr17puZt+uF5E
 qsecMKaD/URFjmeo2YBbYPwpZBJfQiwgV7cJDKsZTUyJsYyRwHA9tL+UBHo8S0CUni+ucck+
 uXy3QLHW5sTAQ9lCZ+OOv6oylqwu1kbmf5zABSUcoUCJh20/dEzeSLrj/IxL8UdEjn5x2OXh
 1SMHBMVhejRuItpotPHsr+J8tWyGOxkE0sEQ2SCteSqNTPX93aIyJNbVLraZijUUW759fnwZ
 ehRyP2gYvQLkEwT7th5Grdvi6k/+8Hut/lRyQE9RCfHaFGiC7VBJHia3JYQ6v0Rl+EB4QbmC
 FiS/tR6OKmSPJK3GVEcEwMpc+Cf2KxGgTLV9/k0fB336SIfEGBriqmO081gUBBgEYY=
IronPort-HdrOrdr: A9a23:fKjZt6H6mGE1OkcApLqE0MeALOsnbusQ8zAXP0AYc3Jom6uj5r
 mTdZUgpHnJYVkqOE3I9ertBEDEewK4yXcX2/h3AV7BZniEhILAFugLhuGO/9SjIVybygc079
 YZT0EUMrzN5DZB4voSmDPIceod/A==
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="64050671"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>
Subject: [PATCH v2 63/70] x86/traps: Rework write_stub_trampoline() to not hardcode the jmp
Date: Mon, 14 Feb 2022 12:51:20 +0000
Message-ID: <20220214125127.17985-64-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

For CET-IBT, we will need to optionally insert an endbr64 instruction at the
start of the stub.  Don't hardcode the jmp displacement assuming that it
starts at byte 24 of the stub.

Also add extra comments describing what is going on.  The mix of %rax and %rsp
is far from trivial to follow.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>

v2:
 * Retain the rounding up to 16 bytes.
---
 xen/arch/x86/x86_64/traps.c | 35 ++++++++++++++++++++++-------------
 1 file changed, 22 insertions(+), 13 deletions(-)

diff --git a/xen/arch/x86/x86_64/traps.c b/xen/arch/x86/x86_64/traps.c
index d661d7ffcaaf..edc6820b85c7 100644
--- a/xen/arch/x86/x86_64/traps.c
+++ b/xen/arch/x86/x86_64/traps.c
@@ -293,30 +293,39 @@ static unsigned int write_stub_trampoline(
     unsigned char *stub, unsigned long stub_va,
     unsigned long stack_bottom, unsigned long target_va)
 {
+    unsigned char *p = stub;
+
+    /* Store guest %rax into %ss slot */
     /* movabsq %rax, stack_bottom - 8 */
-    stub[0] = 0x48;
-    stub[1] = 0xa3;
-    *(uint64_t *)&stub[2] = stack_bottom - 8;
+    *p++ = 0x48;
+    *p++ = 0xa3;
+    *(uint64_t *)p = stack_bottom - 8;
+    p += 8;
 
+    /* Store guest %rsp in %rax */
     /* movq %rsp, %rax */
-    stub[10] = 0x48;
-    stub[11] = 0x89;
-    stub[12] = 0xe0;
+    *p++ = 0x48;
+    *p++ = 0x89;
+    *p++ = 0xe0;
 
+    /* Switch to Xen stack */
     /* movabsq $stack_bottom - 8, %rsp */
-    stub[13] = 0x48;
-    stub[14] = 0xbc;
-    *(uint64_t *)&stub[15] = stack_bottom - 8;
+    *p++ = 0x48;
+    *p++ = 0xbc;
+    *(uint64_t *)p = stack_bottom - 8;
+    p += 8;
 
+    /* Store guest %rsp into %rsp slot */
     /* pushq %rax */
-    stub[23] = 0x50;
+    *p++ = 0x50;
 
     /* jmp target_va */
-    stub[24] = 0xe9;
-    *(int32_t *)&stub[25] = target_va - (stub_va + 29);
+    *p++ = 0xe9;
+    *(int32_t *)p = target_va - (stub_va + (p - stub) + 4);
+    p += 4;
 
     /* Round up to a multiple of 16 bytes. */
-    return 32;
+    return ROUNDUP(p - stub, 16);
 }
 
 DEFINE_PER_CPU(struct stubs, stubs);
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:17:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:17:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271983.466768 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbE5-0006xh-07; Mon, 14 Feb 2022 13:17:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271983.466768; Mon, 14 Feb 2022 13:17:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbE4-0006vj-Jh; Mon, 14 Feb 2022 13:17:08 +0000
Received: by outflank-mailman (input) for mailman id 271983;
 Mon, 14 Feb 2022 13:17:07 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJb4W-0008IH-3o
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:07:16 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 07836415-8d97-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 14:07:15 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 07836415-8d97-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644844035;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=jps309UDFtvBnS2vB6J17zehQG0mfCWoSwDISbfAtm8=;
  b=WkuQcdxDcNY2e0oa0OuLTpkOrEvR4Spbijk1YRlzjPkITWY2AXz69vCk
   Eu48qIUarVrFhHR8vBrxSHVtNrF2cWpxJf3tA8mox0OYqsd2qm6q8zemh
   lIiulFDG7ELVSB4V/ZXB35Ym4A7kISoUMAQ32vS0h+xtdEdcukV+2G0Li
   k=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: ko5IQb6bZCnugSJnIDF7eW4dHGG87aQ4j7t+iJ8PKixd8YXLxGStcqqRJ079tgSQbu1uCvS29m
 cmwCzXTcqn0BIlQ6fKCJNjAMPzVETEUYaIz0SS81HaCvT4E55eCrhZKHn95eAi7XhSIwoPIcyh
 DR+UWluqr0Bt9E4r+sq+WycE6ZMYUH2SnySRKW/eFfhSuEkXYw4TKl4Qp404/DPJOE4lAtNp9O
 EmovnB4DBZeS9BJdNLQ7YBEZR13yCi70pRJkxb0ALd3gKfZHWryp89un8+9/frkbEXXE/aPFQQ
 mjvCPs7YHaq64ntxY1DwCasM
X-SBRS: 5.1
X-MesageID: 64554392
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:FD0i26leoa/36sBGXLEXd0jo5gyZIURdPkR7XQ2eYbSJt1+Wr1Gzt
 xJJDWiOPPrfYjT8eYslboTi90sCscPWx4UySAtk+C0wFSMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BClVlxJVF/fngqoDUUYYoAQgsA180IMsdoUg7wbRh2Nc02YHR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 PMVjJ2tZiwiB5Hv3+A3VwZHDQZ3B7ITrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBODtMJkSpTdLyjbBAOx9aZvCX7/L9ZlT2zJYasVmQ6qDO
 pZCOGAHgBLoShllY3MFAYMFwfr4wXTBTid9q2+enP9ii4TU5FMoi+W8WDbPQfSaSMMQkkuGq
 2bu+2XiHgpcJNGZ0SCC8H+nmqnIhyyTZW4JPOTmrLgw2gTVnzFNTk1NPbemnRWnomjmYtNCB
 GcfwxYN6qwY8FO0UP70ZQLt9RZooSUgc9ZXFuQ77iSExazV/xuVCwA4c9JRVDA1nJRoHGJ3j
 zdli/usXGUy6+PNFRpx45/J9WvaBMQDEYMVicbopyMh6sKrnow8hwmnoj1LQP/s1Y2d9d0dL
 lm3QMkCa1c70JRjO0aTpwmvb9eQSn/hFFBd2+kvdjj5hj6Vnab8D2BS1XDV7OxbMKGSRUSbs
 X4PlqC2tb5SUc7dxHHQGLxWRtlFAspp1xWG3zZS82QJrWzxqxZPg6gMiN2BGKuZGpldImK4C
 KMikQhQ+IVSLBOXgVxfOOqM5zAR5fG4T7zND6mMBvIXO8QZXFLXrUlGOB/Lt0iwwRdErE3KE
 crCGSpaJS1BUvoPIfvfb7p17ILHMQhgmTKNFcijlUzPPHj3TCf9dIrp+WCmNogRhJ5oai2Mr
 I432xKix0oNXevgTDPQ9IJPf1kGIWJiXcL9qtBNd/7FKQ1jQTlzB/jUyLInWopkg6UKybuYo
 iDjAhdVmAjlmHnKCQSWcXQ/Ornhaoly8CAgNis2MFf2h3V6OdSz7L0SfoccdKU88LAx1uZ9S
 vQIIp3SAvlGRjnd1S4aaJ3x8N5reBix3FrcNCu5ejkvOZVnQlWRqNPjewLu8ggIDza26pRi8
 +HxiFuDTMNaFQp4DcvQZPa+9H+LvCAQyLBoQk/FAthPY0GwooJkHDP8060sKMYWJBSdmjbDj
 1SKAQ0VrPXmqpMu9IWbnriNqoqkHrcsHkdeGGWHv7+6OTODozimyI5EFu2JYSrcRCX//6D7P
 bdZyPT1MfsmmldWstUjT+Y3nPxmv9a/9aVHyglEHWnQawX5A7xtFXCKwM1Tu/Af3bReowa3B
 hqC99Qy1W9l4y85/Ir9/DYYU9k=
IronPort-HdrOrdr: A9a23:Dc6u8qGNS2/7soq6pLqE6seALOsnbusQ8zAXP0AYc3Jom62j5r
 mTdZsgtSMc5Ax8ZJhko6HkBEDiewK7yXcW2/hzAV7KZmCP0wHEEGgh1/qH/9SJIVyYygc378
 ZdmsZFZ+EYdWIK7/rH3A==
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="64554392"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v2 62/70] x86/alternatives: Clear CR4.CET when clearing CR0.WP
Date: Mon, 14 Feb 2022 12:51:19 +0000
Message-ID: <20220214125127.17985-63-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

This allows us to have CET active much earlier in boot.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
---
 xen/arch/x86/alternative.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/xen/arch/x86/alternative.c b/xen/arch/x86/alternative.c
index 436047abe021..ec24692e9595 100644
--- a/xen/arch/x86/alternative.c
+++ b/xen/arch/x86/alternative.c
@@ -333,9 +333,13 @@ static int __init cf_check nmi_apply_alternatives(
      */
     if ( !(alt_done & alt_todo) )
     {
-        unsigned long cr0;
+        unsigned long cr0, cr4;
 
         cr0 = read_cr0();
+        cr4 = read_cr4();
+
+        if ( cr4 & X86_CR4_CET )
+            write_cr4(cr4 & ~X86_CR4_CET);
 
         /* Disable WP to allow patching read-only pages. */
         write_cr0(cr0 & ~X86_CR0_WP);
@@ -345,6 +349,9 @@ static int __init cf_check nmi_apply_alternatives(
 
         write_cr0(cr0);
 
+        if ( cr4 & X86_CR4_CET )
+            write_cr4(cr4);
+
         alt_done |= alt_todo;
     }
 
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:17:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:17:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.271986.466780 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbE6-0007Tw-Gp; Mon, 14 Feb 2022 13:17:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 271986.466780; Mon, 14 Feb 2022 13:17:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbE6-0007Rq-8S; Mon, 14 Feb 2022 13:17:10 +0000
Received: by outflank-mailman (input) for mailman id 271986;
 Mon, 14 Feb 2022 13:17:08 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJb4a-0008IH-4W
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:07:20 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 095611f6-8d97-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 14:07:18 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 095611f6-8d97-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644844038;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=aoU1tlx3/7aKi+MsHLxvtpIMc2l5mgsFiREtPDfU0UA=;
  b=NknLRxWQTo0jT/I6xWYXDTnmbQ8+DINujBwbqTaJE8V75uoeeUoA4gJP
   Gaxe2t6ZDcoaGhlkGbhjMq9uEgr4Wb2s4oiUOzWjulfsA8e023O8nREts
   yGyk0zT1ERKa7rupWbsQdDVZTbumERexSZRP3IEpiGtEpkwJo1rl/pe7H
   o=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: yZ/WHagyhkmgZH6D/G6afvcrch+YSiqNBZREZVVz8msHnzsKLXfI+mDHdHRoVFlkGAZ1qjZFZx
 zQiokczxcLCoeLkhlx3zXBgvgQD4yow7vdsgzhrPAT3up8x0y0g7qOX2vcXKzKhhMDzXY6Ga6H
 h7U7OQqWIx1cVA7q/g2JwgSYMFxeXUudRzkNUH4rAita1abD//RYph06KlptLlM9f0cN2o+4Vf
 Rwb1MD3ZYNGiSuvo+QIEjA9AEp0LM7Iqx/VGSZ7xt2ZZfkbpA4aywwKAw3Fu5yLEXObOcNE3Cv
 f7IlpOmPvSKjGyAIJvnKCiMD
X-SBRS: 5.1
X-MesageID: 64554404
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Au+0GqtXFkkzplbLcH5d5PcgbufnVG9ZMUV32f8akzHdYApBsoF/q
 tZmKW6PO62IZmr3Lo1+b9i2pElS75PVztdlHgY6ryBmFX8X+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZQP0VOZigHtIQMsadUsxKbVIiGHdJZS5LwbZj2NYy2IThWmthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 Npl7rWaEgx4brT1lac/WTJzIRBdGZBWweqSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DFYUToHx/ixreCu4rW8vrSKTW/95Imjw3g6iiGN6AO
 5dENWY3MHwsZTUIF3QzDrVugt26qVfYaRZbhE+Nh4kOtj27IAtZj+G2bYu9lsaxbdpRtlaVo
 CTB5WuRKjMwOcGbyDGF2mmxneKJliT+MKoCGbv9+vN0jVm7wm0IFAZQRVa9ueO+iEO1R5RYM
 UN8x8Y1hfFsrgrxFIC7BkDm5i7f1vIBZzZOO7YTwlqGm/rN2gvaJGIvZQxwS/gbpPZjEFTGy
 WS1t9/uADVutpicRnSc6qqYoFuOBMQFEYMRTXRaFFVYurEPtKl210uSFYg7TMZZm/WoQWmY/
 tyckMQpa1z/Z+Yv3r7zw13IiinESnPhHl9svVW/so5IA2pEiG+Zi26AtAKzARVodt/xory9U
 J8swZb20Qz2JcvR/BFhuc1UdF1T296LMSfHnXlkFIQ7+jKm9haLJN4MvG4udBo0ap9fI1cFh
 XM/XisLuvdu0IaCN/crM+pd9ex2pUQfKTgVfq+NNYcfCnSAXASG4DtvdSatM5PFyyARfVUEE
 c7DK66EVC9CYYw+lWbeb7pNgNcDm3FlrUuOFM+T8vhS+efHDJJjYexeawXmgyFQxP7snTg5B
 P4Ba5rUm00HCrWWj+u+2dd7EG3m5EMTXfjew/G7vMbafFQO9LgJB6CDzLU/VZZimqgJxO7E8
 mvkAh1TyUblhG2BIgKPMygxZLTqVJd5jHQ6IS1zYgr4hyl9Od6ivPUFap86Xbg77+g/n/R6e
 OYIJpebCfNVRzWZpzlENcvhrJZvfQiAjB6VO3b3eyA2epNtHlSb+tLtcgb12jMJCy676Zk3r
 7G6j1uJSpsfXQVySs3Rbav3nV+2uHEcnsN0XlfJfYYPKBm9rtAyJnWo3PEtIswKJRHS/Reg1
 l6bUUUCuO3Ag44p692V16qKmJikTrllFU1AEmiFsbvvbXvG/nCuyJNrWfqTeWyPT3v9/aiva
 LkHz/z4N/Fbzl9Gv5AlTuRuxKM6odDuu6Vb3kJvG3CSNwanDbZpI3+n28hTt/ISmu8F6FXuA
 k/fqMNHPbipOd/+FA9DLQUoWe2PyPUIl2SA9v8yOkj7uHd68bfvvZ++5PVQZPix9IdIDb4=
IronPort-HdrOrdr: A9a23:6a/Zlao2AYSbUfE5zhv9VCgaV5opeYIsimQD101hICG8cqSj+f
 xG/c5rrCMc5wxwZJhNo7y90ey7MBbhHP1OkO8s1NWZLWrbUQKTRekIh+bfKn/baknDH4ZmpM
 BdmsNFaeEYY2IUsS+D2njbL+od
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="64554404"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>
Subject: [PATCH v2 65/70] x86/emul: Update emulation stubs to be CET-IBT compatible
Date: Mon, 14 Feb 2022 12:51:22 +0000
Message-ID: <20220214125127.17985-66-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

All indirect branches need to land on an endbr64 instruction.

For stub_selftests(), use endbr64 unconditionally for simplicity.  For ioport
and instruction emulation, add endbr64 conditionally.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>

v2:
 * Use local endbr64 define rather than raw opcodes in stub_selftest()
v1.1:
 * Update to use endbr helpers
---
 xen/arch/x86/extable.c         | 12 +++++++-----
 xen/arch/x86/pv/emul-priv-op.c |  7 +++++++
 xen/arch/x86/x86_emulate.c     | 13 +++++++++++--
 3 files changed, 25 insertions(+), 7 deletions(-)

diff --git a/xen/arch/x86/extable.c b/xen/arch/x86/extable.c
index 4d1875585f9d..4913c4a6dd5d 100644
--- a/xen/arch/x86/extable.c
+++ b/xen/arch/x86/extable.c
@@ -129,20 +129,22 @@ search_exception_table(const struct cpu_user_regs *regs)
 static int __init cf_check stub_selftest(void)
 {
     static const struct {
-        uint8_t opc[4];
+        uint8_t opc[8];
         uint64_t rax;
         union stub_exception_token res;
     } tests[] __initconst = {
-        { .opc = { 0x0f, 0xb9, 0xc3, 0xc3 }, /* ud1 */
+#define endbr64 0xf3, 0x0f, 0x1e, 0xfa
+        { .opc = { endbr64, 0x0f, 0xb9, 0xc3, 0xc3 }, /* ud1 */
           .res.fields.trapnr = TRAP_invalid_op },
-        { .opc = { 0x90, 0x02, 0x00, 0xc3 }, /* nop; add (%rax),%al */
+        { .opc = { endbr64, 0x90, 0x02, 0x00, 0xc3 }, /* nop; add (%rax),%al */
           .rax = 0x0123456789abcdef,
           .res.fields.trapnr = TRAP_gp_fault },
-        { .opc = { 0x02, 0x04, 0x04, 0xc3 }, /* add (%rsp,%rax),%al */
+        { .opc = { endbr64, 0x02, 0x04, 0x04, 0xc3 }, /* add (%rsp,%rax),%al */
           .rax = 0xfedcba9876543210,
           .res.fields.trapnr = TRAP_stack_error },
-        { .opc = { 0xcc, 0xc3, 0xc3, 0xc3 }, /* int3 */
+        { .opc = { endbr64, 0xcc, 0xc3, 0xc3, 0xc3 }, /* int3 */
           .res.fields.trapnr = TRAP_int3 },
+#undef endbr64
     };
     unsigned long addr = this_cpu(stubs.addr) + STUB_BUF_SIZE / 2;
     unsigned int i;
diff --git a/xen/arch/x86/pv/emul-priv-op.c b/xen/arch/x86/pv/emul-priv-op.c
index c46c072f93db..22b10dec2a6e 100644
--- a/xen/arch/x86/pv/emul-priv-op.c
+++ b/xen/arch/x86/pv/emul-priv-op.c
@@ -26,6 +26,7 @@
 
 #include <asm/amd.h>
 #include <asm/debugreg.h>
+#include <asm/endbr.h>
 #include <asm/hpet.h>
 #include <asm/hypercall.h>
 #include <asm/mc146818rtc.h>
@@ -111,6 +112,12 @@ static io_emul_stub_t *io_emul_stub_setup(struct priv_op_ctxt *ctxt, u8 opcode,
 
     p = ctxt->io_emul_stub;
 
+    if ( cpu_has_xen_ibt )
+    {
+        place_endbr64(p);
+        p += 4;
+    }
+
     APPEND_BUFF(prologue);
     APPEND_CALL(load_guest_gprs);
 
diff --git a/xen/arch/x86/x86_emulate.c b/xen/arch/x86/x86_emulate.c
index 60191a94dc18..720740f29b84 100644
--- a/xen/arch/x86/x86_emulate.c
+++ b/xen/arch/x86/x86_emulate.c
@@ -17,6 +17,7 @@
 #include <asm/xstate.h>
 #include <asm/amd.h> /* cpu_has_amd_erratum() */
 #include <asm/debugreg.h>
+#include <asm/endbr.h>
 
 /* Avoid namespace pollution. */
 #undef cmpxchg
@@ -29,11 +30,19 @@
         cpu_has_amd_erratum(&current_cpu_data, AMD_ERRATUM_##nr)
 
 #define get_stub(stb) ({                                        \
+    void *ptr;                                                  \
     BUILD_BUG_ON(STUB_BUF_SIZE / 2 < MAX_INST_LEN + 1);         \
     ASSERT(!(stb).ptr);                                         \
     (stb).addr = this_cpu(stubs.addr) + STUB_BUF_SIZE / 2;      \
-    memset(((stb).ptr = map_domain_page(_mfn(this_cpu(stubs.mfn)))) +  \
-           ((stb).addr & ~PAGE_MASK), 0xcc, STUB_BUF_SIZE / 2);        \
+    (stb).ptr = map_domain_page(_mfn(this_cpu(stubs.mfn))) +    \
+        ((stb).addr & ~PAGE_MASK);                              \
+    ptr = memset((stb).ptr, 0xcc, STUB_BUF_SIZE / 2);           \
+    if ( cpu_has_xen_ibt )                                      \
+    {                                                           \
+        place_endbr64(ptr);                                     \
+        ptr += 4;                                               \
+    }                                                           \
+    ptr;                                                        \
 })
 #define put_stub(stb) ({                                   \
     if ( (stb).ptr )                                       \
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:17:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:17:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272002.466797 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbEG-0000LP-Vw; Mon, 14 Feb 2022 13:17:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272002.466797; Mon, 14 Feb 2022 13:17:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbEG-0000Ka-Q0; Mon, 14 Feb 2022 13:17:20 +0000
Received: by outflank-mailman (input) for mailman id 272002;
 Mon, 14 Feb 2022 13:17:19 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nJbEF-0000HQ-Sy
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:17:19 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nJbEF-0004tZ-Ev; Mon, 14 Feb 2022 13:17:19 +0000
Received: from 54-240-197-238.amazon.com ([54.240.197.238]
 helo=[192.168.31.221]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nJbEF-0002rK-8m; Mon, 14 Feb 2022 13:17:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=5cLKPL0xqeIDc8awr8RsdixcIyQvbQ/S6Qn2BVWVwws=; b=pgc4VSEvALEJzJ1hXr/JOqf0s9
	wgP42FpvwOKHqyz4GP/g2SJ/W1ojjySPIklufsPubxCHMaXyIUFi8zwMSZ49GpjA3daYDmFjr5CO3
	dA6JnSXyFd+AJsPvC8WVgQUONpYDgCJyEOn5v5x+FvSEVR/8qaPROkswaMrbp+zhiCWk=;
Message-ID: <70824a0c-cc48-b064-695c-35c2d06c0ad1@xen.org>
Date: Mon, 14 Feb 2022 13:17:16 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.0
Subject: Re: [PATCH v2 02/70] xen/sort: Switch to an extern inline
 implementation
To: Andrew Cooper <andrew.cooper3@citrix.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
Cc: Jan Beulich <JBeulich@suse.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Wei Liu <wl@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
 <20220214125127.17985-3-andrew.cooper3@citrix.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220214125127.17985-3-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 14/02/2022 12:50, Andrew Cooper wrote:
> There are exactly 3 callers of sort() in the hypervisor.  Callbacks in a tight
> loop like this are problematic for performance, especially with Spectre v2
> protections, which is why extern inline is used commonly by libraries.
> 
> Both ARM callers pass in NULL for the swap function, and while this might seem
> like an attractive option at first, it causes generic_swap() to be used, which
> forced a byte-wise copy.  Provide real swap functions so the compiler can
> optimise properly, which is very important for ARM downstreams where
> milliseconds until the system is up matters.

Did you actually benchmark it? Both those lists will have < 128 elements 
in them. So I would be extremely surprised if you save more than a few 
hundreds microseconds with this approach.

So, my opinion on this approach hasn't changed. On v1, we discussed an 
approach that would suit both Stefano and I. Jan seemed to confirm that 
would also suit x86.

Therefore, for this approach:

Nacked-by: Julien Grall <jgrall@amazon.com>

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:17:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:17:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272035.466808 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbEg-0001x9-A1; Mon, 14 Feb 2022 13:17:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272035.466808; Mon, 14 Feb 2022 13:17:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbEg-0001wp-6E; Mon, 14 Feb 2022 13:17:46 +0000
Received: by outflank-mailman (input) for mailman id 272035;
 Mon, 14 Feb 2022 13:17:44 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJb4Z-0008IH-4W
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:07:19 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0890dc7a-8d97-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 14:07:16 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0890dc7a-8d97-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644844036;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=RYqgg8QK5itpM+XCRkfvVJsrwtwu9tubXMHtrNs746Q=;
  b=QK/0VjMuIxrS6x9Jav8P4J6khlt1ooWda58GbgwSGQ/qBpnibFNcQlEK
   wT07bd/rFDzEqFYFvGpjL+bcepQw9Pz7M09bOEj7PktBTLfVlH+Usl2go
   UTOjMmAcbZeQbOfk1IvgFS6x4KCoGLWkOlVEw1zkr8WKtFv0F8AOrvyFW
   Q=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: 3cxq+WvPrVyp8Ps5hBhq5AfaZE+hRs39an1GJ3H6OqM8n/SsUOrpp4PAwWf7q5/FqFGO8ay5+X
 2eeULrVFhDpRFlTXmnLPUyOHiyooK/R6rDoZ7mHgEnCVS+DNGaPBk3z+apMPELNdbd5WrSkoqi
 6WG0lZnvq0bjLHJDdQ79EbJ5YOloWoe7BQb7aTKpOUI7mGaK46mOKlVOSD3wVKefYM72SbrIl1
 6nUPFn7s0Ow9o1u2TmfMCrNeVEIHlHHjBOd9UJZDSVHuLfzLHm1NuFipUeAR0Cb9stq6il8ka9
 lfQogxRSDVrhvTe7zPqqZfwM
X-SBRS: 5.1
X-MesageID: 64554399
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:QPcKvqN3qyICkKDvrR29kMFynXyQoLVcMsEvi/4bfWQNrUoh0GRTx
 mAWUWuGM/2CYjenKIt/Ydm09koGsZCBmN5rSAto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6UUsxNbVU8En1500s/w7dRbrNA2rBVPSvc4
 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq
 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYoxykj+lD+
 NZBjrGXcF07Yq/KvbkMYxYNRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs
 6VFdnZdNXhvhMrvqF6/YsBqit4uM4/AO4QHt2s75TrYEewnUdbIRKCiCdpwgmtt25wVTKe2i
 8wxankwXTjaTkNzOk5OD7M0m+2Hhlr/bGgNwL6SjfVuuDWCpOBr65D9PdyQdtGUSMF9mkeDu
 nmA72n/GgsdNtGU1XyC6H3EuwPUtXqlAsRITuT+r6M0xg3IroAONPEIfXKWscCLuk2yYP94E
 hYGpigoiPUjxEP+G7ERQCaEiHKDuxcdXf9ZHOs79ByBx8Lo3uqJOoQXZmUfMYJ77afaURRvj
 wbUxI2xWVSDpZXIESr1y1uCkd+l1cH5x0cmbDRMcwYK6sKLTGob3kOWFYYL/EJYY7TI9dDML
 9Ki8XJWa1Y715djO0CHEbfv2WzEm3QxZlRpjjg7p0r8hu+DWKarZpaz9X/Q5utaIYCSQzGp5
 SZYx5fOvL1TVcjWzkRhpdnh+5nzuZ643MD02wYzT/HNCRzxk5JcQWygyG4nfxo4Wir1UTTof
 FXSqWtsCGx7ZxOXgVtMS9vpUawClPG4ffy8D6y8RoceM/BZKV7clAkzNBH44owYuBV1+U3JE
 czAKpjE4LdzIfkP8QdasM9Dje51lnhmnzu7qFKS503P7IdyrUW9Ed8tWGZipMhgsvPsTNz9/
 4kNOs2U5Q9YVeGiMCDb/ZRKdQIBLGQhBICwoMtSL7bRLg1jEWAnKvnQ3bJ+JNA1w/ULzr/Fr
 iOnR0tV6Fvjnnmbew+EXW9uNeH0VpFloHNlYSF1ZQS022IuaJqE5bsEc8dlZqEu8eFulKYmT
 /QMd8iaLO5ITzDLp2YUYZXn9dQwfxW3nwOeeSGiZWFnLZJnQgXI/P7ifxfuq3ZSXnbm65Nmr
 uT5hA3BQJcFSwBzN+rsaaqinwGroHwQuONuRE+UcNNdT1rhrdpxICvrg/5pf8xVcUffxiGX3
 hq9CAsDobWfuJc89dTEiPzWr4qtFOciTENWE3OCsOSzPCjeuGGi3ZVBQKCDejWEDDH4/6CrZ
 ON0yfDgMaJYwAYW4tQkS7s7n7gj49bPpqNBylU2FXrGWF2nF7d8LyTUxsJIrKBMmudUtAbet
 phjITWG1WFl4P/YLWM=
IronPort-HdrOrdr: A9a23:Tn1MEavEYcXo+qMACPcGz/BZ7skDdNV00zEX/kB9WHVpmszxra
 6TdZUgpGbJYVkqOE3I9ertBEDEewK4yXcX2/h2AV7BZniEhILAFugLhuGO/9SjIVybygc079
 YGT0EUMrzN5DZB4voSmDPIceod/A==
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="64554399"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v2 31/70] x86: CFI hardening for request_irq()
Date: Mon, 14 Feb 2022 12:50:48 +0000
Message-ID: <20220214125127.17985-32-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

... and friends; alloc_direct_apic_vector() and set_direct_apic_vector().

Control Flow Integrity schemes use toolchain and optionally hardware support
to help protect against call/jump/return oriented programming attacks.

Use cf_check to annotate function pointer targets for the toolchain.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
 xen/arch/x86/apic.c                      |  8 ++++----
 xen/arch/x86/cpu/mcheck/mce_intel.c      |  4 ++--
 xen/arch/x86/guest/xen/xen.c             |  2 +-
 xen/arch/x86/hpet.c                      |  4 ++--
 xen/arch/x86/hvm/vmx/vmx.c               |  4 ++--
 xen/arch/x86/include/asm/irq.h           | 16 ++++++++--------
 xen/arch/x86/irq.c                       |  2 +-
 xen/arch/x86/smp.c                       |  6 +++---
 xen/arch/x86/time.c                      |  3 ++-
 xen/drivers/passthrough/amd/iommu_init.c |  4 ++--
 xen/drivers/passthrough/vtd/iommu.c      |  4 ++--
 11 files changed, 29 insertions(+), 28 deletions(-)

diff --git a/xen/arch/x86/apic.c b/xen/arch/x86/apic.c
index 68e4d870c749..5a7a58dc9830 100644
--- a/xen/arch/x86/apic.c
+++ b/xen/arch/x86/apic.c
@@ -1361,7 +1361,7 @@ int reprogram_timer(s_time_t timeout)
     return apic_tmict || !timeout;
 }
 
-void apic_timer_interrupt(struct cpu_user_regs * regs)
+void cf_check apic_timer_interrupt(struct cpu_user_regs *regs)
 {
     ack_APIC_irq();
     perfc_incr(apic_timer);
@@ -1380,7 +1380,7 @@ void smp_send_state_dump(unsigned int cpu)
 /*
  * Spurious interrupts should _never_ happen with our APIC/SMP architecture.
  */
-void spurious_interrupt(struct cpu_user_regs *regs)
+void cf_check spurious_interrupt(struct cpu_user_regs *regs)
 {
     /*
      * Check if this is a vectored interrupt (most likely, as this is probably
@@ -1411,7 +1411,7 @@ void spurious_interrupt(struct cpu_user_regs *regs)
  * This interrupt should never happen with our APIC/SMP architecture
  */
 
-void error_interrupt(struct cpu_user_regs *regs)
+void cf_check error_interrupt(struct cpu_user_regs *regs)
 {
     static const char *const esr_fields[] = {
         "Send CS error",
@@ -1444,7 +1444,7 @@ void error_interrupt(struct cpu_user_regs *regs)
  * This interrupt handles performance counters interrupt
  */
 
-void pmu_apic_interrupt(struct cpu_user_regs *regs)
+void cf_check pmu_apic_interrupt(struct cpu_user_regs *regs)
 {
     ack_APIC_irq();
     vpmu_do_interrupt(regs);
diff --git a/xen/arch/x86/cpu/mcheck/mce_intel.c b/xen/arch/x86/cpu/mcheck/mce_intel.c
index a691e10bdcd6..7aaa56fd02eb 100644
--- a/xen/arch/x86/cpu/mcheck/mce_intel.c
+++ b/xen/arch/x86/cpu/mcheck/mce_intel.c
@@ -55,7 +55,7 @@ bool __read_mostly lmce_support;
 #define MCE_RING                0x1
 static DEFINE_PER_CPU(int, last_state);
 
-static void intel_thermal_interrupt(struct cpu_user_regs *regs)
+static void cf_check intel_thermal_interrupt(struct cpu_user_regs *regs)
 {
     uint64_t msr_content;
     unsigned int cpu = smp_processor_id();
@@ -639,7 +639,7 @@ static void cpu_mcheck_disable(void)
         clear_cmci();
 }
 
-static void cmci_interrupt(struct cpu_user_regs *regs)
+static void cf_check cmci_interrupt(struct cpu_user_regs *regs)
 {
     mctelem_cookie_t mctc;
     struct mca_summary bs;
diff --git a/xen/arch/x86/guest/xen/xen.c b/xen/arch/x86/guest/xen/xen.c
index b2aa3a009b4a..17807cdea688 100644
--- a/xen/arch/x86/guest/xen/xen.c
+++ b/xen/arch/x86/guest/xen/xen.c
@@ -170,7 +170,7 @@ static void __init init_memmap(void)
     }
 }
 
-static void xen_evtchn_upcall(struct cpu_user_regs *regs)
+static void cf_check xen_evtchn_upcall(struct cpu_user_regs *regs)
 {
     struct vcpu_info *vcpu_info = this_cpu(vcpu_info);
     unsigned long pending;
diff --git a/xen/arch/x86/hpet.c b/xen/arch/x86/hpet.c
index 7b009a930498..c31fd97579dc 100644
--- a/xen/arch/x86/hpet.c
+++ b/xen/arch/x86/hpet.c
@@ -240,8 +240,8 @@ static void handle_hpet_broadcast(struct hpet_event_channel *ch)
     }
 }
 
-static void hpet_interrupt_handler(int irq, void *data,
-        struct cpu_user_regs *regs)
+static void cf_check hpet_interrupt_handler(
+    int irq, void *data, struct cpu_user_regs *regs)
 {
     struct hpet_event_channel *ch = data;
 
diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c
index 36c8a12cfe7d..dade08f60279 100644
--- a/xen/arch/x86/hvm/vmx/vmx.c
+++ b/xen/arch/x86/hvm/vmx/vmx.c
@@ -2533,7 +2533,7 @@ static struct hvm_function_table __initdata vmx_function_table = {
 };
 
 /* Handle VT-d posted-interrupt when VCPU is blocked. */
-static void pi_wakeup_interrupt(struct cpu_user_regs *regs)
+static void cf_check pi_wakeup_interrupt(struct cpu_user_regs *regs)
 {
     struct vmx_vcpu *vmx, *tmp;
     spinlock_t *lock = &per_cpu(vmx_pi_blocking, smp_processor_id()).lock;
@@ -2565,7 +2565,7 @@ static void pi_wakeup_interrupt(struct cpu_user_regs *regs)
 }
 
 /* Handle VT-d posted-interrupt when VCPU is running. */
-static void pi_notification_interrupt(struct cpu_user_regs *regs)
+static void cf_check pi_notification_interrupt(struct cpu_user_regs *regs)
 {
     ack_APIC_irq();
     this_cpu(irq_count)++;
diff --git a/xen/arch/x86/include/asm/irq.h b/xen/arch/x86/include/asm/irq.h
index 7c825e9d9c0a..b3f49abc5556 100644
--- a/xen/arch/x86/include/asm/irq.h
+++ b/xen/arch/x86/include/asm/irq.h
@@ -93,14 +93,14 @@ static inline struct cpu_user_regs *set_irq_regs(struct cpu_user_regs *new_regs)
 
 #define platform_legacy_irq(irq)	((irq) < 16)
 
-void event_check_interrupt(struct cpu_user_regs *regs);
-void invalidate_interrupt(struct cpu_user_regs *regs);
-void call_function_interrupt(struct cpu_user_regs *regs);
-void apic_timer_interrupt(struct cpu_user_regs *regs);
-void error_interrupt(struct cpu_user_regs *regs);
-void pmu_apic_interrupt(struct cpu_user_regs *regs);
-void spurious_interrupt(struct cpu_user_regs *regs);
-void irq_move_cleanup_interrupt(struct cpu_user_regs *regs);
+void cf_check event_check_interrupt(struct cpu_user_regs *regs);
+void cf_check invalidate_interrupt(struct cpu_user_regs *regs);
+void cf_check call_function_interrupt(struct cpu_user_regs *regs);
+void cf_check apic_timer_interrupt(struct cpu_user_regs *regs);
+void cf_check error_interrupt(struct cpu_user_regs *regs);
+void cf_check pmu_apic_interrupt(struct cpu_user_regs *regs);
+void cf_check spurious_interrupt(struct cpu_user_regs *regs);
+void cf_check irq_move_cleanup_interrupt(struct cpu_user_regs *regs);
 
 uint8_t alloc_hipriority_vector(void);
 
diff --git a/xen/arch/x86/irq.c b/xen/arch/x86/irq.c
index f43b926ed26b..61e09a356f97 100644
--- a/xen/arch/x86/irq.c
+++ b/xen/arch/x86/irq.c
@@ -744,7 +744,7 @@ void move_native_irq(struct irq_desc *desc)
     desc->handler->enable(desc);
 }
 
-void irq_move_cleanup_interrupt(struct cpu_user_regs *regs)
+void cf_check irq_move_cleanup_interrupt(struct cpu_user_regs *regs)
 {
     unsigned vector, me;
 
diff --git a/xen/arch/x86/smp.c b/xen/arch/x86/smp.c
index b9a696f61963..33748e629a21 100644
--- a/xen/arch/x86/smp.c
+++ b/xen/arch/x86/smp.c
@@ -246,7 +246,7 @@ static cpumask_t flush_cpumask;
 static const void *flush_va;
 static unsigned int flush_flags;
 
-void invalidate_interrupt(struct cpu_user_regs *regs)
+void cf_check invalidate_interrupt(struct cpu_user_regs *regs)
 {
     unsigned int flags = flush_flags;
     ack_APIC_irq();
@@ -385,14 +385,14 @@ void smp_send_nmi_allbutself(void)
     send_IPI_mask(&cpu_online_map, APIC_DM_NMI);
 }
 
-void event_check_interrupt(struct cpu_user_regs *regs)
+void cf_check event_check_interrupt(struct cpu_user_regs *regs)
 {
     ack_APIC_irq();
     perfc_incr(ipis);
     this_cpu(irq_count)++;
 }
 
-void call_function_interrupt(struct cpu_user_regs *regs)
+void cf_check call_function_interrupt(struct cpu_user_regs *regs)
 {
     ack_APIC_irq();
     perfc_incr(ipis);
diff --git a/xen/arch/x86/time.c b/xen/arch/x86/time.c
index 3d767d70f61f..b6e690b76fab 100644
--- a/xen/arch/x86/time.c
+++ b/xen/arch/x86/time.c
@@ -196,7 +196,8 @@ static void smp_send_timer_broadcast_ipi(void)
     }
 }
 
-static void timer_interrupt(int irq, void *dev_id, struct cpu_user_regs *regs)
+static void cf_check timer_interrupt(
+    int irq, void *dev_id, struct cpu_user_regs *regs)
 {
     ASSERT(local_irq_is_enabled());
 
diff --git a/xen/drivers/passthrough/amd/iommu_init.c b/xen/drivers/passthrough/amd/iommu_init.c
index cebcd68a6c04..d2ad282e93d3 100644
--- a/xen/drivers/passthrough/amd/iommu_init.c
+++ b/xen/drivers/passthrough/amd/iommu_init.c
@@ -715,8 +715,8 @@ static void cf_check do_amd_iommu_irq(void *unused)
     }
 }
 
-static void iommu_interrupt_handler(int irq, void *dev_id,
-                                    struct cpu_user_regs *regs)
+static void cf_check iommu_interrupt_handler(
+    int irq, void *dev_id, struct cpu_user_regs *regs)
 {
     unsigned long flags;
     struct amd_iommu *iommu = dev_id;
diff --git a/xen/drivers/passthrough/vtd/iommu.c b/xen/drivers/passthrough/vtd/iommu.c
index 4d7703dd9a20..fc3ff064b692 100644
--- a/xen/drivers/passthrough/vtd/iommu.c
+++ b/xen/drivers/passthrough/vtd/iommu.c
@@ -1117,8 +1117,8 @@ static void cf_check do_iommu_page_fault(void *unused)
         __do_iommu_page_fault(drhd->iommu);
 }
 
-static void iommu_page_fault(int irq, void *dev_id,
-                             struct cpu_user_regs *regs)
+static void cf_check iommu_page_fault(
+    int irq, void *dev_id, struct cpu_user_regs *regs)
 {
     /*
      * Just flag the tasklet as runnable. This is fine, according to VT-d
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:17:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:17:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272036.466814 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbEg-00025A-TR; Mon, 14 Feb 2022 13:17:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272036.466814; Mon, 14 Feb 2022 13:17:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbEg-00023X-NL; Mon, 14 Feb 2022 13:17:46 +0000
Received: by outflank-mailman (input) for mailman id 272036;
 Mon, 14 Feb 2022 13:17:46 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJb4c-0008IH-OG
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:07:23 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0a73c9dc-8d97-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 14:07:20 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0a73c9dc-8d97-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644844040;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=LivTElKoKg6RGtpxx8XvSouEzTvppj+Csy+3sm8lMAU=;
  b=GquhXjR1NX390snx6hztGFyZvFKodtIme1F2Rk+2nGjMzkBJTIJVFanJ
   YRMRySx57C1+0Pj0EkkD8+AR1PluHOqnjG41OTdkfjuCykyz+xrh6If10
   RUc24kwCjBcUFpORYE0j5UdxJCpaX6uJ1k1I87pNULhX9c6qJlj4XtNuo
   A=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: AjsViK0O9s9wW1s3wOF5KfVi+35Mzoq5/gn4EZEajFTvwqvP8sjoFNRl8dnspl2VDvsYMdRlmk
 N0ajlrs1l3+cUO4VYIzoGAKsYwYOV/dCIKsE6YdxVY4jqNccRViR/SXpDFOfwynFmX0IrVR89R
 ws3awO7tNSBFIEcqMo0TwHRG2d0jH4NmorV4P1vt7008RQBHt9lJGcAmMz5cZxSu4YJyZYfLyG
 AK+wiVyVO61VAWJ1lQH5F4KABCvvVI4Pz1Olj/fc1X/MCqKv9JcueoYuo+xHtXi+TPR93UIw9M
 3jy5yXrYVq6RbwnRM3htyvqH
X-SBRS: 5.1
X-MesageID: 64554420
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:tniWyK/0TxnBGW6WYVleDrUDmHmTJUtcMsCJ2f8bNWPcYEJGY0x3z
 WoaXGjQbvaCZmanKY92a4+080wDup7Tz9BjHFFv+X88E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhFWeIdA970Ug5w7Rg3tYx6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPh11
 v9UjYO0EjwgZJaXqr8gChhEKX5xaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguwKKsXxMZxZkXZn1TzDVt4tQIzZQrWM7thdtNs1rp4SQKuCO
 5BBAdZpRCyeUQRFamsSMYs/jPj4jHCuLyxWtnvA8MLb5ECMlVcsgdABKuH9atGMAMlYgEucj
 mbH5HjiRAEXMsSFzjiI+W7qgfXA9R4XQ6pLSuf+rKQzxgTOmCpDU3X6SGdXv9G9lGSnY81bc
 HcdoBF1n/MPrU23dIbyCkjQTGG/gjYQXN9ZEusf4Q6Ly7bJ7wvxOlXoXgKte/R96pZoGGVCO
 kuh2oqwWGcx6OH9pWe1q+/MxQ5eLxT5OoPricUsaQIeq+fur4go5v4kZoYySfXl5jEZ9NyZ/
 txrkMTcr+hJ5SLo///ilbwiv95LjsKXJjPZHi2NAgqYAvpRPeZJnbCA51nB9upnJ42EVFSHt
 3Vss5HAsLxRXcHQyXTUG79l8FSVCxGtamO0vLKSN8N5q2TFF4CLIei8Hw2S1G82a51ZKFcFk
 WfYuB9L5Y87AZdZRfQfXm5FMOxzlfKIPY28Dpj8N4MSCrAsJF7v1Hw/Pia4gjGy+HXAZIliY
 P93h+73Vi1EYUmmpRLrL9ogPUgDmHxvmzOLHcqjp/lluJLHDEOopX4+GAPmRogEAGms+VmEm
 zqGH8fVmRhZTsPkZSzbrdwaIVwQdCBpDpHqsc1HMOWEJ1M+Sm0mDvbQx5InepBkwPsJxruZo
 CnlVx8K0kf7iF3GNR6ONiJpZoTwUMsttnk8JyEtYwqlgiBxfYa14a4DXJIrZr17pvd7xPt5Q
 qBdKcWNC/hCUBrd/DEZYcWvpYBubk3z1wmPIzCkcH40eJs5H17F/drtfw3O8igSD3Xo6Zti8
 uP4jg6CGMgNXQVvCsrSecmD9VLpsChPgv92UmvJPsJXJBfm/r91JnGjlfQwOcwNd0nOn2PIy
 waMDB4EjuDRuItposLRjKWJoor1QetzGk1WQzvS4bqsbHSI+2OixclLUfqSfCCbX2Txof3wa
 eJQxvD6EfsGgFcV7NYsT+c1lfozt4n1urtX7gV4B3GaPV2kB4RpLmSCwcQS5LZGwaVUuFfuV
 0+CkjWA1W5l5C8x/IYtGTcY
IronPort-HdrOrdr: A9a23:2PPMJK7gdMtNMyj7nwPXwMrXdLJyesId70hD6qhwISY6TiX4rb
 HWoB1173/JYVoqNE3I3OrwXZVoIkmsk6Kdg7NhXotKNTOO0ADDQb2Kr7GSpwEIcxeOkdK1vp
 0AT0ERMrLN5CBB/KTH3DU=
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="64554420"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v2 24/70] xen/keyhandler: CFI hardening
Date: Mon, 14 Feb 2022 12:50:41 +0000
Message-ID: <20220214125127.17985-25-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

Control Flow Integrity schemes use toolchain and optionally hardware support
to help protect against call/jump/return oriented programming attacks.

Use cf_check to annotate function pointer targets for the toolchain.

Tweak {IRQ_,}KEYHANDLER() to use a named initialiser instead of requiring a
pointer cast to compile in the IRQ case.

Reposition iommu_dump_page_tables() to avoid a forward declaration.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
 xen/arch/x86/acpi/cpu_idle.c             |  2 +-
 xen/arch/x86/hvm/irq.c                   |  2 +-
 xen/arch/x86/hvm/svm/vmcb.c              |  2 +-
 xen/arch/x86/hvm/vmx/vmcs.c              |  2 +-
 xen/arch/x86/io_apic.c                   |  2 +-
 xen/arch/x86/irq.c                       |  2 +-
 xen/arch/x86/mm/p2m-ept.c                |  2 +-
 xen/arch/x86/mm/shadow/common.c          |  4 +--
 xen/arch/x86/msi.c                       |  2 +-
 xen/arch/x86/nmi.c                       |  4 +--
 xen/arch/x86/numa.c                      |  2 +-
 xen/arch/x86/time.c                      |  2 +-
 xen/common/debugtrace.c                  |  2 +-
 xen/common/event_channel.c               |  2 +-
 xen/common/grant_table.c                 |  2 +-
 xen/common/kexec.c                       |  2 +-
 xen/common/keyhandler.c                  | 35 ++++++++++++---------
 xen/common/livepatch.c                   |  2 +-
 xen/common/page_alloc.c                  |  4 +--
 xen/common/perfc.c                       |  4 +--
 xen/common/sched/cpupool.c               |  2 +-
 xen/common/spinlock.c                    |  4 +--
 xen/common/timer.c                       |  2 +-
 xen/drivers/char/console.c               |  8 ++---
 xen/drivers/passthrough/amd/iommu.h      |  2 +-
 xen/drivers/passthrough/amd/iommu_intr.c |  2 +-
 xen/drivers/passthrough/iommu.c          | 52 +++++++++++++++-----------------
 xen/drivers/passthrough/pci.c            |  2 +-
 xen/drivers/passthrough/vtd/extern.h     |  2 +-
 xen/drivers/passthrough/vtd/utils.c      |  2 +-
 xen/include/xen/perfc.h                  |  4 +--
 xen/include/xen/sched.h                  |  2 +-
 xen/include/xen/spinlock.h               |  4 +--
 33 files changed, 86 insertions(+), 83 deletions(-)

diff --git a/xen/arch/x86/acpi/cpu_idle.c b/xen/arch/x86/acpi/cpu_idle.c
index 22c8bb0c2d94..0142671bb836 100644
--- a/xen/arch/x86/acpi/cpu_idle.c
+++ b/xen/arch/x86/acpi/cpu_idle.c
@@ -377,7 +377,7 @@ static void print_acpi_power(uint32_t cpu, struct acpi_processor_power *power)
     print_hw_residencies(cpu);
 }
 
-static void dump_cx(unsigned char key)
+static void cf_check dump_cx(unsigned char key)
 {
     unsigned int cpu;
 
diff --git a/xen/arch/x86/hvm/irq.c b/xen/arch/x86/hvm/irq.c
index 6045c9149bad..a7f8991a7b84 100644
--- a/xen/arch/x86/hvm/irq.c
+++ b/xen/arch/x86/hvm/irq.c
@@ -635,7 +635,7 @@ static void irq_dump(struct domain *d)
            hvm_irq->callback_via_asserted ? "" : " not");
 }
 
-static void dump_irq_info(unsigned char key)
+static void cf_check dump_irq_info(unsigned char key)
 {
     struct domain *d;
 
diff --git a/xen/arch/x86/hvm/svm/vmcb.c b/xen/arch/x86/hvm/svm/vmcb.c
index efa085032bb5..958309657799 100644
--- a/xen/arch/x86/hvm/svm/vmcb.c
+++ b/xen/arch/x86/hvm/svm/vmcb.c
@@ -226,7 +226,7 @@ void svm_destroy_vmcb(struct vcpu *v)
     svm->vmcb = NULL;
 }
 
-static void vmcb_dump(unsigned char ch)
+static void cf_check vmcb_dump(unsigned char ch)
 {
     struct domain *d;
     struct vcpu *v;
diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c
index 2b6bafe9d542..d2cafd8ca1c5 100644
--- a/xen/arch/x86/hvm/vmx/vmcs.c
+++ b/xen/arch/x86/hvm/vmx/vmcs.c
@@ -2117,7 +2117,7 @@ void vmcs_dump_vcpu(struct vcpu *v)
     vmx_vmcs_exit(v);
 }
 
-static void vmcs_dump(unsigned char ch)
+static void cf_check vmcs_dump(unsigned char ch)
 {
     struct domain *d;
     struct vcpu *v;
diff --git a/xen/arch/x86/io_apic.c b/xen/arch/x86/io_apic.c
index 4135a9c06052..4c5eaef86273 100644
--- a/xen/arch/x86/io_apic.c
+++ b/xen/arch/x86/io_apic.c
@@ -1268,7 +1268,7 @@ static void __init print_IO_APIC(void)
         __print_IO_APIC(1);
 }
 
-static void _print_IO_APIC_keyhandler(unsigned char key)
+static void cf_check _print_IO_APIC_keyhandler(unsigned char key)
 {
     __print_IO_APIC(0);
 }
diff --git a/xen/arch/x86/irq.c b/xen/arch/x86/irq.c
index d9bd355113d7..f43b926ed26b 100644
--- a/xen/arch/x86/irq.c
+++ b/xen/arch/x86/irq.c
@@ -2424,7 +2424,7 @@ void free_domain_pirqs(struct domain *d)
     pcidevs_unlock();
 }
 
-static void dump_irqs(unsigned char key)
+static void cf_check dump_irqs(unsigned char key)
 {
     int i, irq, pirq;
     struct irq_desc *desc;
diff --git a/xen/arch/x86/mm/p2m-ept.c b/xen/arch/x86/mm/p2m-ept.c
index b7ee441d4573..a8a6ad629528 100644
--- a/xen/arch/x86/mm/p2m-ept.c
+++ b/xen/arch/x86/mm/p2m-ept.c
@@ -1433,7 +1433,7 @@ static const char *memory_type_to_str(unsigned int x)
     return memory_types[x][0] ? memory_types[x] : "?";
 }
 
-static void ept_dump_p2m_table(unsigned char key)
+static void cf_check ept_dump_p2m_table(unsigned char key)
 {
     struct domain *d;
     ept_entry_t *table, *ept_entry;
diff --git a/xen/arch/x86/mm/shadow/common.c b/xen/arch/x86/mm/shadow/common.c
index fb370af90b5c..83dedc8870aa 100644
--- a/xen/arch/x86/mm/shadow/common.c
+++ b/xen/arch/x86/mm/shadow/common.c
@@ -98,7 +98,7 @@ void shadow_vcpu_init(struct vcpu *v)
 #if SHADOW_AUDIT
 int shadow_audit_enable = 0;
 
-static void shadow_audit_key(unsigned char key)
+static void cf_check shadow_audit_key(unsigned char key)
 {
     shadow_audit_enable = !shadow_audit_enable;
     printk("%s shadow_audit_enable=%d\n",
@@ -1046,7 +1046,7 @@ void shadow_blow_tables_per_domain(struct domain *d)
 /* Blow all shadows of all shadowed domains: this can be used to cause the
  * guest's pagetables to be re-shadowed if we suspect that the shadows
  * have somehow got out of sync */
-static void shadow_blow_all_tables(unsigned char c)
+static void cf_check shadow_blow_all_tables(unsigned char c)
 {
     struct domain *d;
     printk("'%c' pressed -> blowing all shadow tables\n", c);
diff --git a/xen/arch/x86/msi.c b/xen/arch/x86/msi.c
index d1497254b188..77a4fbf13f9f 100644
--- a/xen/arch/x86/msi.c
+++ b/xen/arch/x86/msi.c
@@ -1411,7 +1411,7 @@ void __init early_msi_init(void)
         return;
 }
 
-static void dump_msi(unsigned char key)
+static void cf_check dump_msi(unsigned char key)
 {
     unsigned int irq;
 
diff --git a/xen/arch/x86/nmi.c b/xen/arch/x86/nmi.c
index e20d1393c881..5c26e8785dfc 100644
--- a/xen/arch/x86/nmi.c
+++ b/xen/arch/x86/nmi.c
@@ -578,13 +578,13 @@ void self_nmi(void)
     local_irq_restore(flags);
 }
 
-static void do_nmi_trigger(unsigned char key)
+static void cf_check do_nmi_trigger(unsigned char key)
 {
     printk("Triggering NMI on APIC ID %x\n", get_apic_id());
     self_nmi();
 }
 
-static void do_nmi_stats(unsigned char key)
+static void cf_check do_nmi_stats(unsigned char key)
 {
     const struct vcpu *v;
     unsigned int cpu;
diff --git a/xen/arch/x86/numa.c b/xen/arch/x86/numa.c
index 5de9db4e9943..680b7d9002c5 100644
--- a/xen/arch/x86/numa.c
+++ b/xen/arch/x86/numa.c
@@ -369,7 +369,7 @@ unsigned int __init arch_get_dma_bitsize(void)
                  + PAGE_SHIFT, 32);
 }
 
-static void dump_numa(unsigned char key)
+static void cf_check dump_numa(unsigned char key)
 {
     s_time_t now = NOW();
     unsigned int i, j, n;
diff --git a/xen/arch/x86/time.c b/xen/arch/x86/time.c
index 5a72b66800e4..3d767d70f61f 100644
--- a/xen/arch/x86/time.c
+++ b/xen/arch/x86/time.c
@@ -2541,7 +2541,7 @@ int tsc_set_info(struct domain *d,
 }
 
 /* vtsc may incur measurable performance degradation, diagnose with this */
-static void dump_softtsc(unsigned char key)
+static void cf_check dump_softtsc(unsigned char key)
 {
     struct domain *d;
     int domcnt = 0;
diff --git a/xen/common/debugtrace.c b/xen/common/debugtrace.c
index 160d00b79607..a272e5e43761 100644
--- a/xen/common/debugtrace.c
+++ b/xen/common/debugtrace.c
@@ -233,7 +233,7 @@ void debugtrace_printk(const char *fmt, ...)
     spin_unlock_irqrestore(&debugtrace_lock, flags);
 }
 
-static void debugtrace_key(unsigned char key)
+static void cf_check debugtrace_key(unsigned char key)
 {
     debugtrace_toggle();
 }
diff --git a/xen/common/event_channel.c b/xen/common/event_channel.c
index 183e78ac17f1..ffb042a241a6 100644
--- a/xen/common/event_channel.c
+++ b/xen/common/event_channel.c
@@ -1629,7 +1629,7 @@ static void domain_dump_evtchn_info(struct domain *d)
     spin_unlock(&d->event_lock);
 }
 
-static void dump_evtchn_info(unsigned char key)
+static void cf_check dump_evtchn_info(unsigned char key)
 {
     struct domain *d;
 
diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c
index 1078e3e16cda..1e0762b064d7 100644
--- a/xen/common/grant_table.c
+++ b/xen/common/grant_table.c
@@ -4275,7 +4275,7 @@ static void gnttab_usage_print(struct domain *rd)
         printk("no active grant table entries\n");
 }
 
-static void gnttab_usage_print_all(unsigned char key)
+static void cf_check gnttab_usage_print_all(unsigned char key)
 {
     struct domain *d;
 
diff --git a/xen/common/kexec.c b/xen/common/kexec.c
index b222a5fd782e..a2ffb6530cff 100644
--- a/xen/common/kexec.c
+++ b/xen/common/kexec.c
@@ -408,7 +408,7 @@ static long cf_check kexec_reboot(void *_image)
     return 0;
 }
 
-static void do_crashdump_trigger(unsigned char key)
+static void cf_check do_crashdump_trigger(unsigned char key)
 {
     printk("'%c' pressed -> triggering crashdump\n", key);
     kexec_crash(CRASHREASON_DEBUGKEY);
diff --git a/xen/common/keyhandler.c b/xen/common/keyhandler.c
index b568484ca62c..5dc650a37c5c 100644
--- a/xen/common/keyhandler.c
+++ b/xen/common/keyhandler.c
@@ -26,10 +26,11 @@
 static unsigned char keypress_key;
 static bool_t alt_key_handling;
 
-static keyhandler_fn_t show_handlers, dump_hwdom_registers,
-    dump_domains, read_clocks;
-static irq_keyhandler_fn_t do_toggle_alt_key, dump_registers,
-    reboot_machine, run_all_keyhandlers, do_debug_key;
+static keyhandler_fn_t cf_check show_handlers, cf_check dump_hwdom_registers,
+    cf_check dump_domains, cf_check read_clocks;
+static irq_keyhandler_fn_t cf_check do_toggle_alt_key, cf_check dump_registers,
+    cf_check reboot_machine, cf_check run_all_keyhandlers,
+    cf_check do_debug_key;
 
 static struct keyhandler {
     union {
@@ -43,10 +44,10 @@ static struct keyhandler {
 } key_table[128] __read_mostly =
 {
 #define KEYHANDLER(k, f, desc, diag)            \
-    [k] = { { (f) }, desc, 0, diag }
+    [k] = { { .fn = (f) }, desc, 0, diag }
 
 #define IRQ_KEYHANDLER(k, f, desc, diag)        \
-    [k] = { { (keyhandler_fn_t *)(f) }, desc, 1, diag }
+    [k] = { { .irq_fn = (f) }, desc, 1, diag }
 
     IRQ_KEYHANDLER('A', do_toggle_alt_key, "toggle alternative key handling", 0),
     IRQ_KEYHANDLER('d', dump_registers, "dump registers", 1),
@@ -124,7 +125,7 @@ void register_irq_keyhandler(unsigned char key, irq_keyhandler_fn_t fn,
     key_table[key].diagnostic = diagnostic;
 }
 
-static void show_handlers(unsigned char key)
+static void cf_check show_handlers(unsigned char key)
 {
     unsigned int i;
 
@@ -170,7 +171,8 @@ void dump_execstate(struct cpu_user_regs *regs)
     watchdog_enable();
 }
 
-static void dump_registers(unsigned char key, struct cpu_user_regs *regs)
+static void cf_check dump_registers(
+    unsigned char key, struct cpu_user_regs *regs)
 {
     unsigned int cpu;
 
@@ -224,7 +226,7 @@ static void cf_check dump_hwdom_action(void *data)
     }
 }
 
-static void dump_hwdom_registers(unsigned char key)
+static void cf_check dump_hwdom_registers(unsigned char key)
 {
     struct vcpu *v;
 
@@ -246,13 +248,14 @@ static void dump_hwdom_registers(unsigned char key)
     }
 }
 
-static void reboot_machine(unsigned char key, struct cpu_user_regs *regs)
+static void cf_check reboot_machine(
+    unsigned char key, struct cpu_user_regs *regs)
 {
     printk("'%c' pressed -> rebooting machine\n", key);
     machine_restart(0);
 }
 
-static void dump_domains(unsigned char key)
+static void cf_check dump_domains(unsigned char key)
 {
     struct domain *d;
     const struct sched_unit *unit;
@@ -372,7 +375,7 @@ static void cf_check read_clocks_slave(void *unused)
     local_irq_enable();
 }
 
-static void read_clocks(unsigned char key)
+static void cf_check read_clocks(unsigned char key)
 {
     unsigned int cpu = smp_processor_id(), min_stime_cpu, max_stime_cpu;
     unsigned int min_cycles_cpu, max_cycles_cpu;
@@ -461,7 +464,8 @@ static void cf_check run_all_nonirq_keyhandlers(void *unused)
 static DECLARE_TASKLET(run_all_keyhandlers_tasklet,
                        run_all_nonirq_keyhandlers, NULL);
 
-static void run_all_keyhandlers(unsigned char key, struct cpu_user_regs *regs)
+static void cf_check run_all_keyhandlers(
+    unsigned char key, struct cpu_user_regs *regs)
 {
     struct keyhandler *h;
     unsigned int k;
@@ -494,7 +498,7 @@ static void do_debugger_trap_fatal(struct cpu_user_regs *regs)
     barrier();
 }
 
-static void do_debug_key(unsigned char key, struct cpu_user_regs *regs)
+static void cf_check do_debug_key(unsigned char key, struct cpu_user_regs *regs)
 {
     printk("'%c' pressed -> trapping into debugger\n", key);
     if ( regs )
@@ -503,7 +507,8 @@ static void do_debug_key(unsigned char key, struct cpu_user_regs *regs)
         run_in_exception_handler(do_debugger_trap_fatal);
 }
 
-static void do_toggle_alt_key(unsigned char key, struct cpu_user_regs *regs)
+static void cf_check do_toggle_alt_key(
+    unsigned char key, struct cpu_user_regs *regs)
 {
     alt_key_handling = !alt_key_handling;
     printk("'%c' pressed -> using %s key handling\n", key,
diff --git a/xen/common/livepatch.c b/xen/common/livepatch.c
index 4e1c29ab7879..e8714920dc8f 100644
--- a/xen/common/livepatch.c
+++ b/xen/common/livepatch.c
@@ -2068,7 +2068,7 @@ static const char *state2str(unsigned int state)
     return names[state];
 }
 
-static void livepatch_printall(unsigned char key)
+static void cf_check livepatch_printall(unsigned char key)
 {
     struct payload *data;
     const void *binary_id = NULL;
diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c
index 827617502e35..3caf5c954b24 100644
--- a/xen/common/page_alloc.c
+++ b/xen/common/page_alloc.c
@@ -2522,7 +2522,7 @@ unsigned long avail_node_heap_pages(unsigned int nodeid)
 }
 
 
-static void pagealloc_info(unsigned char key)
+static void cf_check pagealloc_info(unsigned char key)
 {
     unsigned int zone = MEMZONE_XEN;
     unsigned long n, total = 0;
@@ -2572,7 +2572,7 @@ void scrub_one_page(struct page_info *pg)
 #endif
 }
 
-static void dump_heap(unsigned char key)
+static void cf_check dump_heap(unsigned char key)
 {
     s_time_t      now = NOW();
     int           i, j;
diff --git a/xen/common/perfc.c b/xen/common/perfc.c
index 3abe35892a83..7400667bf0c4 100644
--- a/xen/common/perfc.c
+++ b/xen/common/perfc.c
@@ -28,7 +28,7 @@ static const struct {
 
 DEFINE_PER_CPU(perfc_t[NUM_PERFCOUNTERS], perfcounters);
 
-void perfc_printall(unsigned char key)
+void cf_check perfc_printall(unsigned char key)
 {
     unsigned int i, j;
     s_time_t now = NOW();
@@ -115,7 +115,7 @@ void perfc_printall(unsigned char key)
     }
 }
 
-void perfc_reset(unsigned char key)
+void cf_check perfc_reset(unsigned char key)
 {
     unsigned int i, j;
     s_time_t now = NOW();
diff --git a/xen/common/sched/cpupool.c b/xen/common/sched/cpupool.c
index 07f984a659cd..a6da4970506a 100644
--- a/xen/common/sched/cpupool.c
+++ b/xen/common/sched/cpupool.c
@@ -956,7 +956,7 @@ const cpumask_t *cpupool_valid_cpus(const struct cpupool *pool)
     return pool->cpu_valid;
 }
 
-void dump_runq(unsigned char key)
+void cf_check dump_runq(unsigned char key)
 {
     s_time_t         now = NOW();
     struct cpupool *c;
diff --git a/xen/common/spinlock.c b/xen/common/spinlock.c
index 5ce7e3363863..25bfbf3c47f7 100644
--- a/xen/common/spinlock.c
+++ b/xen/common/spinlock.c
@@ -393,7 +393,7 @@ static void spinlock_profile_print_elem(struct lock_profile *data,
            data->lock_cnt, data->time_hold, data->block_cnt, data->time_block);
 }
 
-void spinlock_profile_printall(unsigned char key)
+void cf_check spinlock_profile_printall(unsigned char key)
 {
     s_time_t now = NOW();
     s_time_t diff;
@@ -413,7 +413,7 @@ static void spinlock_profile_reset_elem(struct lock_profile *data,
     data->time_block = 0;
 }
 
-void spinlock_profile_reset(unsigned char key)
+void cf_check spinlock_profile_reset(unsigned char key)
 {
     s_time_t now = NOW();
 
diff --git a/xen/common/timer.c b/xen/common/timer.c
index 700f191a70b4..9b5016d5ed82 100644
--- a/xen/common/timer.c
+++ b/xen/common/timer.c
@@ -546,7 +546,7 @@ static void dump_timer(struct timer *t, s_time_t now)
            (t->expires - now) / 1000, t, t->function, t->data);
 }
 
-static void dump_timerq(unsigned char key)
+static void cf_check dump_timerq(unsigned char key)
 {
     struct timer  *t;
     struct timers *ts;
diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c
index d74b65f6bf23..380765ab02fd 100644
--- a/xen/drivers/char/console.c
+++ b/xen/drivers/char/console.c
@@ -280,7 +280,7 @@ static int *__read_mostly upper_thresh_adj = &xenlog_upper_thresh;
 static int *__read_mostly lower_thresh_adj = &xenlog_lower_thresh;
 static const char *__read_mostly thresh_adj = "standard";
 
-static void do_toggle_guest(unsigned char key, struct cpu_user_regs *regs)
+static void cf_check do_toggle_guest(unsigned char key, struct cpu_user_regs *regs)
 {
     if ( upper_thresh_adj == &xenlog_upper_thresh )
     {
@@ -307,13 +307,13 @@ static void do_adj_thresh(unsigned char key)
            loglvl_str(*upper_thresh_adj));
 }
 
-static void do_inc_thresh(unsigned char key, struct cpu_user_regs *regs)
+static void cf_check do_inc_thresh(unsigned char key, struct cpu_user_regs *regs)
 {
     ++*lower_thresh_adj;
     do_adj_thresh(key);
 }
 
-static void do_dec_thresh(unsigned char key, struct cpu_user_regs *regs)
+static void cf_check do_dec_thresh(unsigned char key, struct cpu_user_regs *regs)
 {
     if ( *lower_thresh_adj )
         --*lower_thresh_adj;
@@ -424,7 +424,7 @@ void console_serial_puts(const char *s, size_t nr)
     pv_console_puts(s, nr);
 }
 
-static void dump_console_ring_key(unsigned char key)
+static void cf_check dump_console_ring_key(unsigned char key)
 {
     uint32_t idx, len, sofar, c;
     unsigned int order;
diff --git a/xen/drivers/passthrough/amd/iommu.h b/xen/drivers/passthrough/amd/iommu.h
index 04517c1a024c..99be9aafcc53 100644
--- a/xen/drivers/passthrough/amd/iommu.h
+++ b/xen/drivers/passthrough/amd/iommu.h
@@ -297,7 +297,7 @@ unsigned int amd_iommu_read_ioapic_from_ire(
 int amd_iommu_msi_msg_update_ire(
     struct msi_desc *msi_desc, struct msi_msg *msg);
 int amd_setup_hpet_msi(struct msi_desc *msi_desc);
-void amd_iommu_dump_intremap_tables(unsigned char key);
+void cf_check amd_iommu_dump_intremap_tables(unsigned char key);
 
 extern struct ioapic_sbdf {
     u16 bdf, seg;
diff --git a/xen/drivers/passthrough/amd/iommu_intr.c b/xen/drivers/passthrough/amd/iommu_intr.c
index b166a0466654..e7804413c7f4 100644
--- a/xen/drivers/passthrough/amd/iommu_intr.c
+++ b/xen/drivers/passthrough/amd/iommu_intr.c
@@ -844,7 +844,7 @@ static int dump_intremap_mapping(const struct amd_iommu *iommu,
     return 0;
 }
 
-void amd_iommu_dump_intremap_tables(unsigned char key)
+void cf_check amd_iommu_dump_intremap_tables(unsigned char key)
 {
     if ( !shared_intremap_table )
     {
diff --git a/xen/drivers/passthrough/iommu.c b/xen/drivers/passthrough/iommu.c
index 6ee267d2bfd4..e220fea72c2f 100644
--- a/xen/drivers/passthrough/iommu.c
+++ b/xen/drivers/passthrough/iommu.c
@@ -22,8 +22,6 @@
 #include <xen/keyhandler.h>
 #include <xsm/xsm.h>
 
-static void iommu_dump_page_tables(unsigned char key);
-
 unsigned int __read_mostly iommu_dev_iotlb_timeout = 1000;
 integer_param("iommu_dev_iotlb_timeout", iommu_dev_iotlb_timeout);
 
@@ -224,6 +222,31 @@ int iommu_domain_init(struct domain *d, unsigned int opts)
     return 0;
 }
 
+static void cf_check iommu_dump_page_tables(unsigned char key)
+{
+    struct domain *d;
+
+    ASSERT(iommu_enabled);
+
+    rcu_read_lock(&domlist_read_lock);
+
+    for_each_domain(d)
+    {
+        if ( is_hardware_domain(d) || !is_iommu_enabled(d) )
+            continue;
+
+        if ( iommu_use_hap_pt(d) )
+        {
+            printk("%pd sharing page tables\n", d);
+            continue;
+        }
+
+        iommu_vcall(dom_iommu(d)->platform_ops, dump_page_tables, d);
+    }
+
+    rcu_read_unlock(&domlist_read_lock);
+}
+
 void __hwdom_init iommu_hwdom_init(struct domain *d)
 {
     struct domain_iommu *hd = dom_iommu(d);
@@ -584,31 +607,6 @@ bool_t iommu_has_feature(struct domain *d, enum iommu_feature feature)
     return is_iommu_enabled(d) && test_bit(feature, dom_iommu(d)->features);
 }
 
-static void iommu_dump_page_tables(unsigned char key)
-{
-    struct domain *d;
-
-    ASSERT(iommu_enabled);
-
-    rcu_read_lock(&domlist_read_lock);
-
-    for_each_domain(d)
-    {
-        if ( is_hardware_domain(d) || !is_iommu_enabled(d) )
-            continue;
-
-        if ( iommu_use_hap_pt(d) )
-        {
-            printk("%pd sharing page tables\n", d);
-            continue;
-        }
-
-        iommu_vcall(dom_iommu(d)->platform_ops, dump_page_tables, d);
-    }
-
-    rcu_read_unlock(&domlist_read_lock);
-}
-
 /*
  * Local variables:
  * mode: C
diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
index c170dd06ba51..79f49f0e6007 100644
--- a/xen/drivers/passthrough/pci.c
+++ b/xen/drivers/passthrough/pci.c
@@ -1351,7 +1351,7 @@ static int _dump_pci_devices(struct pci_seg *pseg, void *arg)
     return 0;
 }
 
-static void dump_pci_devices(unsigned char ch)
+static void cf_check dump_pci_devices(unsigned char ch)
 {
     printk("==== PCI devices ====\n");
     pcidevs_lock();
diff --git a/xen/drivers/passthrough/vtd/extern.h b/xen/drivers/passthrough/vtd/extern.h
index f97883a780a2..4595b65e5bce 100644
--- a/xen/drivers/passthrough/vtd/extern.h
+++ b/xen/drivers/passthrough/vtd/extern.h
@@ -31,7 +31,7 @@ extern const struct iommu_init_ops intel_iommu_init_ops;
 
 void print_iommu_regs(struct acpi_drhd_unit *drhd);
 void print_vtd_entries(struct vtd_iommu *iommu, int bus, int devfn, u64 gmfn);
-keyhandler_fn_t vtd_dump_iommu_info;
+keyhandler_fn_t cf_check vtd_dump_iommu_info;
 
 bool intel_iommu_supports_eim(void);
 int intel_iommu_enable_eim(void);
diff --git a/xen/drivers/passthrough/vtd/utils.c b/xen/drivers/passthrough/vtd/utils.c
index 56dfdff9bd0d..47922dc8e813 100644
--- a/xen/drivers/passthrough/vtd/utils.c
+++ b/xen/drivers/passthrough/vtd/utils.c
@@ -154,7 +154,7 @@ void print_vtd_entries(struct vtd_iommu *iommu, int bus, int devfn, u64 gmfn)
     } while ( --level );
 }
 
-void vtd_dump_iommu_info(unsigned char key)
+void cf_check vtd_dump_iommu_info(unsigned char key)
 {
     struct acpi_drhd_unit *drhd;
     struct vtd_iommu *iommu;
diff --git a/xen/include/xen/perfc.h b/xen/include/xen/perfc.h
index 6846e7119fa3..bb010b0aae93 100644
--- a/xen/include/xen/perfc.h
+++ b/xen/include/xen/perfc.h
@@ -96,8 +96,8 @@ DECLARE_PER_CPU(perfc_t[NUM_PERFCOUNTERS], perfcounters);
 struct xen_sysctl_perfc_op;
 int perfc_control(struct xen_sysctl_perfc_op *);
 
-extern void perfc_printall(unsigned char key);
-extern void perfc_reset(unsigned char key);
+extern void cf_check perfc_printall(unsigned char key);
+extern void cf_check perfc_reset(unsigned char key);
 
     
 #else /* CONFIG_PERF_COUNTERS */
diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
index 37f78cc4c4c9..67b0f6b86853 100644
--- a/xen/include/xen/sched.h
+++ b/xen/include/xen/sched.h
@@ -1145,7 +1145,7 @@ int cpupool_move_domain(struct domain *d, struct cpupool *c);
 int cpupool_do_sysctl(struct xen_sysctl_cpupool_op *op);
 unsigned int cpupool_get_id(const struct domain *d);
 const cpumask_t *cpupool_valid_cpus(const struct cpupool *pool);
-extern void dump_runq(unsigned char key);
+extern void cf_check dump_runq(unsigned char key);
 
 void arch_do_physinfo(struct xen_sysctl_physinfo *pi);
 
diff --git a/xen/include/xen/spinlock.h b/xen/include/xen/spinlock.h
index 9fa4e600c1f7..961891bea4d5 100644
--- a/xen/include/xen/spinlock.h
+++ b/xen/include/xen/spinlock.h
@@ -129,8 +129,8 @@ void _lock_profile_deregister_struct(int32_t, struct lock_profile_qhead *);
     _lock_profile_deregister_struct(type, &((ptr)->profile_head))
 
 extern int spinlock_profile_control(struct xen_sysctl_lockprof_op *pc);
-extern void spinlock_profile_printall(unsigned char key);
-extern void spinlock_profile_reset(unsigned char key);
+extern void cf_check spinlock_profile_printall(unsigned char key);
+extern void cf_check spinlock_profile_reset(unsigned char key);
 
 #else
 
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:17:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:17:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272042.466830 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbEm-0002ez-5Q; Mon, 14 Feb 2022 13:17:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272042.466830; Mon, 14 Feb 2022 13:17:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbEm-0002ek-1n; Mon, 14 Feb 2022 13:17:52 +0000
Received: by outflank-mailman (input) for mailman id 272042;
 Mon, 14 Feb 2022 13:17:50 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJb3R-0008IH-Dn
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:06:09 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id def9e9d4-8d96-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 14:06:08 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: def9e9d4-8d96-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644843968;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=mFvh8LG+XymZDQVBuCKArEEiktD2ZTkwHy0DqtzmEhk=;
  b=UVWEpIzyDoSzng5L+mIBPrePXtxu3PZoDGyrO7HPubasTzzHBkH9usbg
   l2ROrPT/QGEULeEok9JXh2gV2oGdrSA/L/LFGpctrS9jNf+h4ItUPRs/m
   vDEEHRxnEJbV8q0NcKb9dvCsUe2HQiaiDolLhvRYQ0JQNAHfytVw86jHX
   A=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: yT49laUGTy2FPkWCwaShby2MY0ToeoCCIQuyMvF44JSS9XAcDhMs+yZ8VRkS3Nd7NZucpcdiSL
 9vVdx6JPWeSgo8fPAuRrmIpklv/7kNnySqAD0r2v9+2rnpscPqc5fp104/qdqF8x6LqDjxauGt
 3Yw934Z8mDX3QmhBb4mopnokFI97vzquXHup/uP7TJwrJvntHF1Zveo48WhygRHUGBsfzhdGIC
 ipXkTj8xkPTsC/XyGfW+8o2n9gZlhzbDrCSg4gbCYYz8EHAg5cvs6fPdIg/mGMycIwcukHPOqU
 QwsTLaleUhH87CQRGznchgbT
X-SBRS: 5.1
X-MesageID: 64149443
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:xRFYU6AF6B/3ghVW/zfkw5YqxClBgxIJ4kV8jS/XYbTApDt2gmRVz
 DBOWW+EPf6NZGHyKot0PdzkoBkBv8OGx95kQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMo/u1Si6FatANl1ElvU2zbue6WL6s1hxZH1c+En970E47wobVv6Yz6TSHK1LV0
 T/Ni5W31G+Ng1aY5UpNtspvADs21BjDkGtwUm4WPJinj3eH/5UhN7oNJLnZEpfNatI88thW5
 Qr05OrREmvxp3/BAz4++1rxWhVirrX6ZWBihpfKMkQLb9crSiEai84G2PQghUh/ij+2gux3x
 Oh0q6PgWC0KFILStMYhekwNe81+FfUuFL7vJHG+tYqYzlHccmuqyPJrZK00FdRGoKAtWzgIr
 KFGbmBWBvyAr7veLLaTY+9gnMk8auLsO5sSoCpIxjDFF/c2B5vERs0m4PcGgG5s15wSRp4yY
 eJeeSNjfhLnSiEVAUw6M64Eg+KxhlzwJmgwRFW9+vNsvjm7IBZK+KjgNp/Zd8KHQe1Rn12Ev
 STW8mLhGBYYOdeDjz2f/RqRavTnxH2hHthITfvhq6As0Ab7KnEv5AM+VFGEvMW/hnOHRe0PO
 mY30AUwgYoO3Rn+JjXiZCGQrHmBtx8aftNfFewm9Q2AopbpDxal6nssFWAYNoF/3CMibXlzj
 wLSwYu1bdB6mODNERqgGqGoQSRe0MT/BUsLfmc6QAQM+LEPS6lj30uUHr6P/ENY5+AZ+A0cI
 RjX9kDSZJ1J1KbnMplXGnid3VqRSmDhFFJd2+kudjvNAvlFTICkfZe0zlPQ8OxNKo2UJnHY4
 iRYxJjOsb1WVMrX/MBofAnqNOv3j8tpzRWG2QI/d3Xf32jFF4GfkXB4v2gleRYB3jcscj71e
 k7D0T69F7cIVEZGmZRfOtrrY+xzlPCIPY28Cpj8M4ofCrAsJVTv1Hw/OiatM5XFzRFEfVcXY
 szAL65BzB8yVMxa8dZBb7lBgOF7nnhknQs+h/nTlnya7FZXX1bNIZ9tDbdERrpRAHqsrFqH/
 tBBGdGNzhkDAuTybjOOqdwYLEwQLGh9Dpfz8pQFeumGKwtgOWcgF/6Onu9xJ907x/xYxrXS4
 3Wwek5E016j13fJHhqHNyJ4Y7T1UJch8X9iZX4wPUyl0mQIaJq06PtNbIM+eLQqrbQxzfN9Q
 /QfVd+HB/BDFmbO9zgHNMGvp41+bhW7wwmJOnP9MjQ4epdhQS3P+8PlIVSzpHVfUHLvuJJn8
 bO61w7dTZ4SfChYDZ7bOKC10le8nXkBg+YuDUHGFcZeJRf3+49wJi2v0vJue5MQKQ/Ozyex3
 hqNBUtKvvHEpoI4/YWbha2AqIv1QeJyElADQjve5LeycyLb4nCi0clLV+PRJWLRU2b9+aODY
 +RJzq6jbK1bzQgS64csQax2ya8e5sf0o+4IxwtpK3zHclC3B+4yOXKBx8RO6vVAy7IxVdFag
 a5TFg224Ym0Bf4=
IronPort-HdrOrdr: A9a23:L+G3FKo5CUa6ZuEaM7ntZhsaV5opeYIsimQD101hICG8cqSj+f
 xG/c5rrCMc5wxwZJhNo7y90ey7MBbhHP1OkO8s1NWZLWrbUQKTRekIh+bfKn/baknDH4ZmpM
 BdmsNFaeEYY2IUsS+D2njbL+od
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="64149443"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v2 54/70] x86/dpci: CFI hardening
Date: Mon, 14 Feb 2022 12:51:11 +0000
Message-ID: <20220214125127.17985-55-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

Control Flow Integrity schemes use toolchain and optionally hardware support
to help protect against call/jump/return oriented programming attacks.

Use cf_check to annotate function pointer targets for the toolchain.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
 xen/arch/x86/hvm/hvm.c                | 4 ++--
 xen/drivers/passthrough/vtd/x86/hvm.c | 4 ++--
 xen/drivers/passthrough/x86/hvm.c     | 8 ++++----
 3 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c
index 4cf313a0ad0a..cdd1529014f2 100644
--- a/xen/arch/x86/hvm/hvm.c
+++ b/xen/arch/x86/hvm/hvm.c
@@ -474,8 +474,8 @@ void hvm_migrate_pirq(struct hvm_pirq_dpci *pirq_dpci, const struct vcpu *v)
     }
 }
 
-static int migrate_pirq(struct domain *d, struct hvm_pirq_dpci *pirq_dpci,
-                        void *arg)
+static int cf_check migrate_pirq(
+    struct domain *d, struct hvm_pirq_dpci *pirq_dpci, void *arg)
 {
     hvm_migrate_pirq(pirq_dpci, arg);
 
diff --git a/xen/drivers/passthrough/vtd/x86/hvm.c b/xen/drivers/passthrough/vtd/x86/hvm.c
index b531fe907a94..132d252d1cca 100644
--- a/xen/drivers/passthrough/vtd/x86/hvm.c
+++ b/xen/drivers/passthrough/vtd/x86/hvm.c
@@ -21,8 +21,8 @@
 #include <xen/irq.h>
 #include <xen/sched.h>
 
-static int _hvm_dpci_isairq_eoi(struct domain *d,
-                                struct hvm_pirq_dpci *pirq_dpci, void *arg)
+static int cf_check _hvm_dpci_isairq_eoi(
+    struct domain *d, struct hvm_pirq_dpci *pirq_dpci, void *arg)
 {
     struct hvm_irq *hvm_irq = hvm_domain_irq(d);
     unsigned int isairq = (long)arg;
diff --git a/xen/drivers/passthrough/x86/hvm.c b/xen/drivers/passthrough/x86/hvm.c
index 0e3c0f6aeed3..0f94203af817 100644
--- a/xen/drivers/passthrough/x86/hvm.c
+++ b/xen/drivers/passthrough/x86/hvm.c
@@ -777,8 +777,8 @@ static void __msi_pirq_eoi(struct hvm_pirq_dpci *pirq_dpci)
     }
 }
 
-static int _hvm_dpci_msi_eoi(struct domain *d,
-                             struct hvm_pirq_dpci *pirq_dpci, void *arg)
+static int cf_check _hvm_dpci_msi_eoi(
+    struct domain *d, struct hvm_pirq_dpci *pirq_dpci, void *arg)
 {
     int vector = (long)arg;
 
@@ -947,8 +947,8 @@ void hvm_dpci_eoi(struct domain *d, unsigned int guest_gsi)
     spin_unlock(&d->event_lock);
 }
 
-static int pci_clean_dpci_irq(struct domain *d,
-                              struct hvm_pirq_dpci *pirq_dpci, void *arg)
+static int cf_check pci_clean_dpci_irq(
+    struct domain *d, struct hvm_pirq_dpci *pirq_dpci, void *arg)
 {
     struct dev_intx_gsi_link *digl, *tmp;
 
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:17:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:17:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272043.466834 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbEm-0002iq-Hb; Mon, 14 Feb 2022 13:17:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272043.466834; Mon, 14 Feb 2022 13:17:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbEm-0002hL-9q; Mon, 14 Feb 2022 13:17:52 +0000
Received: by outflank-mailman (input) for mailman id 272043;
 Mon, 14 Feb 2022 13:17:50 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJb3Q-0008IH-DZ
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:06:08 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id de5ceaad-8d96-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 14:06:07 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: de5ceaad-8d96-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644843967;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=skVgVxLknOxv+80SVwWA5GN8E1fXIaaRgPjclkqsHNc=;
  b=dBDRWjBxD/GZz1XwKIHDYZLG1yUVtOSvRfIDuPkLZF8IA7aau5s7Mcpg
   CPjoJxhNVN7uK4sWVijJ8qTU3iRBuDZEjlaCxYEJOIp/RKtC5arHN2XL8
   WsBosF1Uv3Xt73fY8gI15wlpHeSGfZFbznQIoTSKpe6YofyXoPsCAHfLq
   k=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: NEp8paYwyA+te02yyWc1DX2MXpcq6Tifjfqu7zoJPEbMHXhfEW7a9tUwfSOgQKyPiqnAPD3sOM
 Yooc66J92E2/d3q0uF8CWYclirm25+Q1cghSJkLll13ysMNmjZapAXPLE9oy5QT/MKvpR0n/Lw
 kuUkBT61uexAaBvJ8KUaBVFVisFCFSILQpQtbu6vBrGK4ltZ+zcZZE5LiLktUHiPcWaCeZcO0O
 mCVFtuzPkQeeSia1mpPL2b+ZPKVPLcw4IMzUelyg6wmi99LeYSmxfmMqdB/cYRcqRH6/4zR0a5
 AbyHphPXe+ld+rS4SecsIa9y
X-SBRS: 5.1
X-MesageID: 64149440
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:MmuzEqnTwao9Eb2wHeTxu5To5gy+IURdPkR7XQ2eYbSJt1+Wr1Gzt
 xIfXWiBP63ZNmWjLt10PY21909T6sCAytQxHQI+/CAxECMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BClVlxJVF/fngqoDUUYYoAQgsA180IMsdoUg7wbRh2Nc02YHR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 M9Pp67uVTcJAqTzmsEFXjVjPwEiFoQTrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBODtMJkSpTdLyjbBAOx9aZvCX7/L9ZlT2zJYasVmQ6qHO
 5tFNWIHgBLoOURzI00pEa4EjdyOnWWuVwJGk1XIuv9ii4TU5FMoi+W8WDbPQfSVQe1Fk0Deo
 XjJl0zbKBwHMN2UyRKe72mhwOTImEvTSI8UUbG16PNuqFmS3XAITg0bU0Ohpvu0gVL4XMhQQ
 3H44QJ38/J0rhbyCICgAVvo+xZooyLwRfJKEf8Ith296pbd3AS8HmUodRJhNPcP4ZpeqSMR6
 neFmNbgBDpKubKTSG6A+rr8kQ5eKRT5PkdZO3ZaEFJtD83L5dhq00mRFooL/Lud04WtcQwc1
 Qxmu8TXa187qccQn5u28lnc695HjsiYF1Vljuk7s4/M0++YWGJHT9HygbQ4xawZRGp8crVml
 CJa8/VyFMhUUfmweNWlGY3h5o2B6fefKyH7ilVyBZQn/DnF0yf9IdwPsGEjeR8waZxsldrVj
 Kj741052XOuFCHyMf8fj3yZV6zGMpQM5fy6D6uJP7Kik7B6dROd/TEGWKJj9zuFraTYqolmY
 c3zWZ/1VR4yUP07pBLrF7Z1+eJ6nUgWmDKMLa0XOjz6iNJyklbOEuxbWLZPB8hkhJ65TPL9r
 YoOaZvSk08HOAA8CwGOmbMuwZkxBSBTLfjLRwZ/L4Zv+yJqRzMsDeH/27Qkd9A3lqhZjL6Qr
 Hq8RlVZ2Bz0gniecVeGbXVqabXOW5djrC1kYXxwbAjwg3VzM5yy6Ko/docseeV1/uJU0vMpH
 eIOfN+NA6oTR22fqSgdd5T0sKdraA+v2VCVJyOgbTVmJ8xgSgXF98XKZAzq8CVSXCO7udFn+
 ++r1x/BQIpFTANnVZ6EZPWqxlK3nH4chOMtABeYfogNIB3hqdE4JTbwg/k7J9A3BS/CnjbKh
 RyLBRo4pPXWp9Nn+tf+mq3Z/ZyiFPFzHxQGEjCDv6q2LyTT4kGq3ZREDLSTZTnYWW75pPeia
 OFSw62uOfELhg8X4Y91ErItxqMi/dr/4bRdy108TnnMal2qDJJmI2WHgpYT5vEcmOcBtFvkQ
 F+L9/lbJa6NaZHsH1MmLQY4aviOiKMPkT7I4PVpeEj36UebJlZcvZm+6/VUtBFgEQ==
IronPort-HdrOrdr: A9a23:GBdeXanfJnC84FfjKRr5d5fvhcPpDfIo3DAbv31ZSRFFG/Fxl6
 iV/cjztCWE8Ar5N0tQ+uxoVJPufZqYz+8Q3WBzB8baYOCFghrLEGgK1+KLqFeMdxEWtNQtsp
 uIG5IObuEYZmIbsS+V2meF+q4bsby6zJw=
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="64149440"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>
Subject: [PATCH v2 67/70] x86/entry: Make IDT entrypoints CET-IBT compatible
Date: Mon, 14 Feb 2022 12:51:24 +0000
Message-ID: <20220214125127.17985-68-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

Each IDT vector needs to land on an endbr64 instruction.  This is especially
important for the #CP handler, which will recurse indefinitely if the endbr64
is missing, eventually escalating to #DF if guard pages are active.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>

v2:
 * Extra newlines in asm
 * Reword commit message
---
 xen/arch/x86/x86_64/compat/entry.S |  1 +
 xen/arch/x86/x86_64/entry.S        | 30 ++++++++++++++++++++++++++++--
 2 files changed, 29 insertions(+), 2 deletions(-)

diff --git a/xen/arch/x86/x86_64/compat/entry.S b/xen/arch/x86/x86_64/compat/entry.S
index c84ff7ea6476..5fd6dbbd4513 100644
--- a/xen/arch/x86/x86_64/compat/entry.S
+++ b/xen/arch/x86/x86_64/compat/entry.S
@@ -12,6 +12,7 @@
 #include <irq_vectors.h>
 
 ENTRY(entry_int82)
+        ENDBR64
         ALTERNATIVE "", clac, X86_FEATURE_XEN_SMAP
         pushq $0
         movl  $HYPERCALL_VECTOR, 4(%rsp)
diff --git a/xen/arch/x86/x86_64/entry.S b/xen/arch/x86/x86_64/entry.S
index 9abcf95bd010..ea6f0afbc2b4 100644
--- a/xen/arch/x86/x86_64/entry.S
+++ b/xen/arch/x86/x86_64/entry.S
@@ -386,6 +386,7 @@ UNLIKELY_END(sysenter_gpf)
         jmp   .Lbounce_exception
 
 ENTRY(int80_direct_trap)
+        ENDBR64
         ALTERNATIVE "", clac, X86_FEATURE_XEN_SMAP
         pushq $0
         movl  $0x80, 4(%rsp)
@@ -698,6 +699,7 @@ ENTRY(common_interrupt)
         jmp ret_from_intr
 
 ENTRY(page_fault)
+        ENDBR64
         movl  $TRAP_page_fault,4(%rsp)
 /* No special register assumptions. */
 GLOBAL(handle_exception)
@@ -872,75 +874,91 @@ FATAL_exception_with_ints_disabled:
         BUG   /* fatal_trap() shouldn't return. */
 
 ENTRY(divide_error)
+        ENDBR64
         pushq $0
         movl  $TRAP_divide_error,4(%rsp)
         jmp   handle_exception
 
 ENTRY(coprocessor_error)
+        ENDBR64
         pushq $0
         movl  $TRAP_copro_error,4(%rsp)
         jmp   handle_exception
 
 ENTRY(simd_coprocessor_error)
+        ENDBR64
         pushq $0
         movl  $TRAP_simd_error,4(%rsp)
         jmp   handle_exception
 
 ENTRY(device_not_available)
+        ENDBR64
         pushq $0
         movl  $TRAP_no_device,4(%rsp)
         jmp   handle_exception
 
 ENTRY(debug)
+        ENDBR64
         pushq $0
         movl  $TRAP_debug,4(%rsp)
         jmp   handle_ist_exception
 
 ENTRY(int3)
+        ENDBR64
         pushq $0
         movl  $TRAP_int3,4(%rsp)
         jmp   handle_exception
 
 ENTRY(overflow)
+        ENDBR64
         pushq $0
         movl  $TRAP_overflow,4(%rsp)
         jmp   handle_exception
 
 ENTRY(bounds)
+        ENDBR64
         pushq $0
         movl  $TRAP_bounds,4(%rsp)
         jmp   handle_exception
 
 ENTRY(invalid_op)
+        ENDBR64
         pushq $0
         movl  $TRAP_invalid_op,4(%rsp)
         jmp   handle_exception
 
 ENTRY(invalid_TSS)
+        ENDBR64
         movl  $TRAP_invalid_tss,4(%rsp)
         jmp   handle_exception
 
 ENTRY(segment_not_present)
+        ENDBR64
         movl  $TRAP_no_segment,4(%rsp)
         jmp   handle_exception
 
 ENTRY(stack_segment)
+        ENDBR64
         movl  $TRAP_stack_error,4(%rsp)
         jmp   handle_exception
 
 ENTRY(general_protection)
+        ENDBR64
         movl  $TRAP_gp_fault,4(%rsp)
         jmp   handle_exception
 
 ENTRY(alignment_check)
+        ENDBR64
         movl  $TRAP_alignment_check,4(%rsp)
         jmp   handle_exception
 
 ENTRY(entry_CP)
+        ENDBR64
         movl  $X86_EXC_CP, 4(%rsp)
         jmp   handle_exception
 
 ENTRY(double_fault)
+        ENDBR64
         movl  $TRAP_double_fault,4(%rsp)
         /* Set AC to reduce chance of further SMAP faults */
         ALTERNATIVE "", stac, X86_FEATURE_XEN_SMAP
@@ -966,6 +984,7 @@ ENTRY(double_fault)
 
         .pushsection .init.text, "ax", @progbits
 ENTRY(early_page_fault)
+        ENDBR64
         movl  $TRAP_page_fault,4(%rsp)
         SAVE_ALL
         movq  %rsp,%rdi
@@ -974,6 +993,7 @@ ENTRY(early_page_fault)
         .popsection
 
 ENTRY(nmi)
+        ENDBR64
         pushq $0
         movl  $TRAP_nmi,4(%rsp)
 handle_ist_exception:
@@ -1102,12 +1122,14 @@ handle_ist_exception:
 #endif
 
 ENTRY(machine_check)
+        ENDBR64
         pushq $0
         movl  $TRAP_machine_check,4(%rsp)
         jmp   handle_ist_exception
 
 /* No op trap handler.  Required for kexec crash path. */
 GLOBAL(trap_nop)
+        ENDBR64
         iretq
 
 /* Table of automatically generated entry points.  One per vector. */
@@ -1136,7 +1158,9 @@ autogen_stubs: /* Automatically generated stubs. */
 #endif
 
         ALIGN
-1:      pushq $0
+1:
+        ENDBR64
+        pushq $0
         movb  $vec,4(%rsp)
         jmp   common_interrupt
 
@@ -1146,7 +1170,9 @@ autogen_stubs: /* Automatically generated stubs. */
         .elseif vec == X86_EXC_CSO || vec == X86_EXC_SPV || \
                 vec == X86_EXC_VE  || (vec > X86_EXC_CP && vec < TRAP_nr)
 
-1:      test  $8,%spl        /* 64bit exception frames are 16 byte aligned, but the word */
+1:
+        ENDBR64
+        test  $8,%spl        /* 64bit exception frames are 16 byte aligned, but the word */
         jz    2f             /* size is 8 bytes.  Check whether the processor gave us an */
         pushq $0             /* error code, and insert an empty one if not.              */
 2:      movb  $vec,4(%rsp)
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:17:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:17:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272051.466852 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbEs-0003V0-4j; Mon, 14 Feb 2022 13:17:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272051.466852; Mon, 14 Feb 2022 13:17:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbEr-0003UY-UI; Mon, 14 Feb 2022 13:17:57 +0000
Received: by outflank-mailman (input) for mailman id 272051;
 Mon, 14 Feb 2022 13:17:56 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJb4m-00023t-9Y
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:07:32 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0f868522-8d97-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 14:07:30 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0f868522-8d97-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644844050;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=s+Jt3kVFT6FeqRAFMyblKx1FZnX0D4ErdxbQ4UUEYAQ=;
  b=VHarnlgKoEuz+T/DcNbffAC3R15cP7vxCHcVh7ZMZzg9D1UNXKbnYH2Z
   DMPp3d4KVFy7W+nCbPf/kl1k5p2qmF5tq5Z0zQrXIvrLrwu4z2lExFH9R
   RyFz497djkvC/QkT44p/z+M1JsJ2MBxvBesfvZhBqmL3mXF77BF7LGO2h
   Q=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: sOXmjbQ9kP//HyRdi956wfUOuNX9Kjm/Wd+sZjKDp0SuqOAg0z0HsOt9ixom5wnyM8vkYkojxm
 bg1bRlH/iLWZwTl44lZzjUIM6HaSSyZtddniFaqScqOJ9q+pS0zonjOqRsxGmGyOOy/aNSFPgP
 vkIB70wKB6zyczGx+P3uqUU9k7EqyhxP16qRJ8HTuNYx7Rvp5TEgL0YWP4vl0PpalA09LiA4Lo
 eLtdmwn/rHgPR2gbceQ3xtzVZUEwAGn9ydpe/7O2873JfJRWjA+1r7aBT04ziTi8XziETD20BK
 E4+Fl/YUTZEBoeFHBoN22mqm
X-SBRS: 5.1
X-MesageID: 64554519
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:758jf61bnZxSwly59/bD5cp2kn2cJEfYwER7XKvMYLTBsI5bpzdSz
 mBJXTzVbP6JYWOhc951OYvjoUwC6pHTnNBjSAU6pC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkS5PE3oHJ9RGQ74nRLlbHILOCanAZqTNMEn9700o5wrJh2+aEvPDia++zk
 YKqyyHgEAfNNw5cagr4PIra9XuDFNyr0N8plgRWicJj5TcypFFMZH4rHomjLmOQf2VhNrXSq
 9Avbl2O1jixEx8FUrtJm1tgG6EAaua60QOm0hK6V0U+6/TrS+NbPqsTbZIhhUlrZzqhktBD7
 vlHt5OJGAIQMP3939Y/CyBzHHQrVUFG0OevzXmXtMWSywvNcmf2wuUoB0YzVWEa0r8pWycUr
 6VecW1TKEDY7w616OvTpu1Er8IvNsT0eqgYvWlt12rxBvc6W5HTBa7N4Le02R9u2p0TQauHN
 qL1bxJrYjXlYhB1fW1PBY8Ykd6xt36nfi9h/Qf9Sa0fvDGIkV0ZPKLWGMrYfJmGSNtYmm6cp
 3na5CLpDxcCLtudxDGZtHW2iYfycTjTAdxIUufir7gz3QPVljd75AAquUWTrPmLrGK0Wd1me
 kkt9Hof6poQrHWAQYyoN/Gnm0KsshkZUttWNuQ17gCR16bZizqk6ng4oi1pM4J/6pJvLdA+/
 hrQxo6yW2Qz2FGAYS/Frt+pQSWO1T/5xIPoTQsNVkM77tbqu+nfZTqfH484QMZZYjAYcAwcI
 gxmTgBj3d3/buZRjs1XGGwrZBr2+PD0ovYdvFm/Y45cxloRiHSZT4Kp80PHyv1LMZyUSFKM1
 FBdxZTCs7BeUMzVzXfXKAnoIF1Oz6zbWAAwfHY1R8Vxn9hT0yLLkX9sDMFWex4yb5dslc7Ba
 07PowJBjKK/z1PxBZKbl7mZUpxwpYC5TIyNfqmNMrJmP8ggHCfarXoGTRPBgAjQfL0EzPhX1
 WGzKp33Ux73yM1PkVKLegvq+eF3mH5unz6PLX05pjz+uYejiLeuYe9tGDOzgioRtfvYyOkM2
 9oAZcaM1TtFV+jyPnve/YIJdAhYJnknH5Hm7cdQc7fbcAZhHWggDd7XwK8gJNM5z/gEyL+Q8
 yHvQFJcxXr+mWbDdVeAZEd8Ze69Rp14t386Y3AhZA76x3g5bI+zx64DbJ9rL6I//eluwKcsH
 fkIcsmNGNpVTTHD92hPZJXxttU6Jh+qmRiPL2yuZz1mJ8xsQAnA+9nFeArz9XZRUnrr5JVm+
 7D5j1HVW5sOQQhmHf36UvP3wgPjp2UZlcJzQ1DMfotZdnLz/dU4MCf2lPI2fZ0BcE2R2juA2
 g+KKh4Evu2R8ZQt+dzEiK3Y/YekF+xyQhhTE2XBtOvkMCDb+iyowJNaUfbOdjfYDTum9KKnb
 ORT7vf9LPxYwwoa79siS+5mnfAk+t/ih75G1QA1TnzEYmOiBq5kPnTbj9JEsbdAx+MBtAa7M
 q5VFgK25Vld1BvZLWMs
IronPort-HdrOrdr: A9a23:y/CNiai7vN8Zi7SlCLHi2MtuB3BQXtgji2hC6mlwRA09TySZ//
 rBoB17726MtN9/YhEdcLy7VJVoBEmskKKdgrNhW4tKPjOW21dARbsKheCJrgEIWReOktK1vZ
 0QFJSWY+eQMbEVt6nHCXGDYrQd/OU=
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="64554519"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v2 21/70] xen/evtchn: CFI hardening
Date: Mon, 14 Feb 2022 12:50:38 +0000
Message-ID: <20220214125127.17985-22-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

Control Flow Integrity schemes use toolchain and optionally hardware support
to help protect against call/jump/return oriented programming attacks.

Use cf_check to annotate function pointer targets for the toolchain.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
 xen/common/event_2l.c      | 21 ++++++++++++---------
 xen/common/event_channel.c |  3 ++-
 xen/common/event_fifo.c    | 30 ++++++++++++++++--------------
 3 files changed, 30 insertions(+), 24 deletions(-)

diff --git a/xen/common/event_2l.c b/xen/common/event_2l.c
index 7424320e525a..d40dd51ab555 100644
--- a/xen/common/event_2l.c
+++ b/xen/common/event_2l.c
@@ -16,7 +16,8 @@
 
 #include <asm/guest_atomics.h>
 
-static void evtchn_2l_set_pending(struct vcpu *v, struct evtchn *evtchn)
+static void cf_check evtchn_2l_set_pending(
+    struct vcpu *v, struct evtchn *evtchn)
 {
     struct domain *d = v->domain;
     unsigned int port = evtchn->port;
@@ -41,12 +42,14 @@ static void evtchn_2l_set_pending(struct vcpu *v, struct evtchn *evtchn)
     evtchn_check_pollers(d, port);
 }
 
-static void evtchn_2l_clear_pending(struct domain *d, struct evtchn *evtchn)
+static void cf_check evtchn_2l_clear_pending(
+    struct domain *d, struct evtchn *evtchn)
 {
     guest_clear_bit(d, evtchn->port, &shared_info(d, evtchn_pending));
 }
 
-static void evtchn_2l_unmask(struct domain *d, struct evtchn *evtchn)
+static void cf_check evtchn_2l_unmask(
+    struct domain *d, struct evtchn *evtchn)
 {
     struct vcpu *v = d->vcpu[evtchn->notify_vcpu_id];
     unsigned int port = evtchn->port;
@@ -64,8 +67,8 @@ static void evtchn_2l_unmask(struct domain *d, struct evtchn *evtchn)
     }
 }
 
-static bool evtchn_2l_is_pending(const struct domain *d,
-                                 const struct evtchn *evtchn)
+static bool cf_check evtchn_2l_is_pending(
+    const struct domain *d, const struct evtchn *evtchn)
 {
     evtchn_port_t port = evtchn->port;
     unsigned int max_ports = BITS_PER_EVTCHN_WORD(d) * BITS_PER_EVTCHN_WORD(d);
@@ -75,8 +78,8 @@ static bool evtchn_2l_is_pending(const struct domain *d,
             guest_test_bit(d, port, &shared_info(d, evtchn_pending)));
 }
 
-static bool evtchn_2l_is_masked(const struct domain *d,
-                                const struct evtchn *evtchn)
+static bool cf_check evtchn_2l_is_masked(
+    const struct domain *d, const struct evtchn *evtchn)
 {
     evtchn_port_t port = evtchn->port;
     unsigned int max_ports = BITS_PER_EVTCHN_WORD(d) * BITS_PER_EVTCHN_WORD(d);
@@ -86,8 +89,8 @@ static bool evtchn_2l_is_masked(const struct domain *d,
             guest_test_bit(d, port, &shared_info(d, evtchn_mask)));
 }
 
-static void evtchn_2l_print_state(struct domain *d,
-                                  const struct evtchn *evtchn)
+static void cf_check evtchn_2l_print_state(
+    struct domain *d, const struct evtchn *evtchn)
 {
     struct vcpu *v = d->vcpu[evtchn->notify_vcpu_id];
 
diff --git a/xen/common/event_channel.c b/xen/common/event_channel.c
index 2026bc30dc95..183e78ac17f1 100644
--- a/xen/common/event_channel.c
+++ b/xen/common/event_channel.c
@@ -99,7 +99,8 @@ static xen_event_channel_notification_t __read_mostly
     xen_consumers[NR_XEN_CONSUMERS];
 
 /* Default notification action: wake up from wait_on_xen_event_channel(). */
-static void default_xen_notification_fn(struct vcpu *v, unsigned int port)
+static void cf_check default_xen_notification_fn(
+    struct vcpu *v, unsigned int port)
 {
     /* Consumer needs notification only if blocked. */
     if ( test_and_clear_bit(_VPF_blocked_in_xen, &v->pause_flags) )
diff --git a/xen/common/event_fifo.c b/xen/common/event_fifo.c
index 2fb01b82db84..ed4d3beb10f3 100644
--- a/xen/common/event_fifo.c
+++ b/xen/common/event_fifo.c
@@ -78,7 +78,7 @@ static inline event_word_t *evtchn_fifo_word_from_port(const struct domain *d,
     return d->evtchn_fifo->event_array[p] + w;
 }
 
-static void evtchn_fifo_init(struct domain *d, struct evtchn *evtchn)
+static void cf_check evtchn_fifo_init(struct domain *d, struct evtchn *evtchn)
 {
     event_word_t *word;
 
@@ -158,7 +158,8 @@ static bool_t evtchn_fifo_set_link(struct domain *d, event_word_t *word,
     return 1;
 }
 
-static void evtchn_fifo_set_pending(struct vcpu *v, struct evtchn *evtchn)
+static void cf_check evtchn_fifo_set_pending(
+    struct vcpu *v, struct evtchn *evtchn)
 {
     struct domain *d = v->domain;
     unsigned int port;
@@ -317,7 +318,8 @@ static void evtchn_fifo_set_pending(struct vcpu *v, struct evtchn *evtchn)
         evtchn_check_pollers(d, port);
 }
 
-static void evtchn_fifo_clear_pending(struct domain *d, struct evtchn *evtchn)
+static void cf_check evtchn_fifo_clear_pending(
+    struct domain *d, struct evtchn *evtchn)
 {
     event_word_t *word;
 
@@ -334,7 +336,7 @@ static void evtchn_fifo_clear_pending(struct domain *d, struct evtchn *evtchn)
     guest_clear_bit(d, EVTCHN_FIFO_PENDING, word);
 }
 
-static void evtchn_fifo_unmask(struct domain *d, struct evtchn *evtchn)
+static void cf_check evtchn_fifo_unmask(struct domain *d, struct evtchn *evtchn)
 {
     struct vcpu *v = d->vcpu[evtchn->notify_vcpu_id];
     event_word_t *word;
@@ -350,32 +352,32 @@ static void evtchn_fifo_unmask(struct domain *d, struct evtchn *evtchn)
         evtchn_fifo_set_pending(v, evtchn);
 }
 
-static bool evtchn_fifo_is_pending(const struct domain *d,
-                                   const struct evtchn *evtchn)
+static bool cf_check evtchn_fifo_is_pending(
+    const struct domain *d, const struct evtchn *evtchn)
 {
     const event_word_t *word = evtchn_fifo_word_from_port(d, evtchn->port);
 
     return word && guest_test_bit(d, EVTCHN_FIFO_PENDING, word);
 }
 
-static bool_t evtchn_fifo_is_masked(const struct domain *d,
-                                    const struct evtchn *evtchn)
+static bool cf_check evtchn_fifo_is_masked(
+    const struct domain *d, const struct evtchn *evtchn)
 {
     const event_word_t *word = evtchn_fifo_word_from_port(d, evtchn->port);
 
     return !word || guest_test_bit(d, EVTCHN_FIFO_MASKED, word);
 }
 
-static bool_t evtchn_fifo_is_busy(const struct domain *d,
-                                  const struct evtchn *evtchn)
+static bool cf_check evtchn_fifo_is_busy(
+    const struct domain *d, const struct evtchn *evtchn)
 {
     const event_word_t *word = evtchn_fifo_word_from_port(d, evtchn->port);
 
     return word && guest_test_bit(d, EVTCHN_FIFO_LINKED, word);
 }
 
-static int evtchn_fifo_set_priority(struct domain *d, struct evtchn *evtchn,
-                                    unsigned int priority)
+static int cf_check evtchn_fifo_set_priority(
+    struct domain *d, struct evtchn *evtchn, unsigned int priority)
 {
     if ( priority > EVTCHN_FIFO_PRIORITY_MIN )
         return -EINVAL;
@@ -390,8 +392,8 @@ static int evtchn_fifo_set_priority(struct domain *d, struct evtchn *evtchn,
     return 0;
 }
 
-static void evtchn_fifo_print_state(struct domain *d,
-                                    const struct evtchn *evtchn)
+static void cf_check evtchn_fifo_print_state(
+    struct domain *d, const struct evtchn *evtchn)
 {
     event_word_t *word;
 
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:18:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:18:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272055.466863 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbEu-0003xt-C8; Mon, 14 Feb 2022 13:18:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272055.466863; Mon, 14 Feb 2022 13:18:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbEu-0003xZ-7a; Mon, 14 Feb 2022 13:18:00 +0000
Received: by outflank-mailman (input) for mailman id 272055;
 Mon, 14 Feb 2022 13:17:59 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJb3o-00023t-R9
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:06:32 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ec7c1354-8d96-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 14:06:30 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ec7c1354-8d96-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644843991;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=Fi1axB5uLDN6sum8D3QAzPbry9w69HfPZE5bf+cwyeI=;
  b=PQQq7X46NRbXGvmVSBPosFHLgyw90NQKIivGXJkLPESi1dKWbHlOsYuO
   Ut7xsWEMdh/okBNM+wT8/klBZBIVkiS2MYur/JvsRLiSaAuS2bAWC9HhH
   +ybA+W3OZ4fCcHej6awBoIOEIb3T74M4qlNluPnOlGH3N5v6wJtMahQEI
   I=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: QN9REi7sea3NQjbnfqcCbTAgxLnQRXYY7nAJdw3CZLM2hEi06ARdRAbUibAOeWSUqe7/XDV3pH
 vqpyXkGofxjgc+6Y6lMZfrTB9dhuq1YqbFxAGpfmpJnOsv1HFwVJZ4S0ZBgfjYxZ14XyM6H/dz
 Hr/WHjh4kGddGmmpwhxMlEZ8SZ+X2mfRGJvysY5ZS+W8IKLDA2xprjL6iZU8eOjNAsB3Q9zBus
 2qzEUPciw2yKqK1+mweDSqkr1AkSI+tdxgDN9JKVGiLWt/5nFS5aWNY3AE/06RzuNoRpDjk1sZ
 2apg6rjJs6nTsXaJueJHjUkK
X-SBRS: 5.1
X-MesageID: 64149496
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:g4kxga3gJS4tdbjDWvbD5ex2kn2cJEfYwER7XKvMYLTBsI5bpzFVm
 jBMCj3QaancYDCmfYp3Oouw9BwO65WHmNNhHAs6pC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkS5PE3oHJ9RGQ74nRLlbHILOCanAZqTNMEn9700o5wrJh2+aEvPDia++zk
 YKqyyHgEAfNNw5cagr4PIra9XuDFNyr0N8plgRWicJj5TcypFFMZH4rHomjLmOQf2VhNrXSq
 9Avbl2O1jixEx8FUrtJm1tgG6EAaua60QOm0hK6V0U+6/TrS+NbPqsTbZIhhUlrZzqhuPBB5
 tVxrpCMURYWAa7et8MQVz1RHHQrVUFG0OevzXmXtMWSywvNcmf2wuUoB0YzVWEa0r8pWycUr
 6VecW1TKEDY7w616OvTpu1Er8IvNsT0eqgYvWlt12rxBvc6W5HTBa7N4Le02R9u2pkSTKqPO
 aL1bxJJURfFTScXIG0TJ7Aj28GugX3zV2FH/Qf9Sa0fvDGIkV0ZPKLWGMXRUsyHQ4NShEnwj
 kDs8nn9AxoaHMeC0jfD+XWp7sffkCW+VI8MGbmQ8v9xnEbV1mEVEAcRV1awvb++kEHWZj5EA
 xVKoGx09/F0rRH1CImmN/GlnJKaljk8a/RQL/Y21Bmc9ZXX8Sm+C2wgRzEUPbTKq/QKbTAt0
 1aImfbgCjpurKCZRBqhy1uEkd+hEXNLdDFfPEfoWSNAuoC++99r0nojW/4+SPbdszHjJd3nL
 9lmRgAajq5bs8ME3r7TEbvv02P1/cihouLYC2zqsoOZAuFROdTNi2+AswGzARN8wGGxFAfpg
 ZT8s5LChN3i9LnU/MB3fM0DHauy+9GOOyDGjFhkEvEJrmrxpyHzLd0NuGglfi+F1/ronhezP
 ifuVf55vscPbBNGk4crC25ONyja5fe5Tom0PhwlRtFPfoJwZGe6ENJGPiatM5TWuBF0y8kXY
 M7DGe71VCpyIfk3nVKeGrZGuZd2l39W+I8mbc2ip/hR+eHFPyD9pHZsGAbmU93VG4va/FSLo
 44HbZPiJtc2eLSWXxQ7OLU7dTgiRUXXz7iqwyCOXuLccAdgBk87DPrdneEod4B/xvwHnebU5
 HCtHERfzQOn13HALAyLbFFlaa/uAskj/S5qY3R0MAb6wWUnbKau8LwbK8k9c444+bEx1vVzV
 fQEJZmNW6wdVjTd9j0BRpDht4g+Jg+zjAeDMnP9MjgydpJtXSLT/drgcle9/SUCFHPv58A/v
 6ehxkXQRp9aH1ZuC8PfafSOyVKtvCdCxLIuDhWQetQKIRfi6olnLSD1n8QbGcBUJEWR3Cae2
 iaXHQwc+bvHrbgq/YSbnquDtYqoTbdzRxIIA2nB4L+qHiDG5W7/k5RYWeOFcD2BBmP5/KKuO
 bdcw/3maaBVmV9Lt8x3EqpxzLJ47Nzq/ucIwgNhFXTNTlKqFrI/fSXWgZgR7vVAlu1DpA+7e
 kOT4d0La7yGNfTsHEMVOAd4PP+I0usZm2WK4Pk4SKkgCPSbIFZTvZ1uAiSx
IronPort-HdrOrdr: A9a23:6y10gKrvUIhlEuZ8Jo6yMIkaV5opeYIsimQD101hICG8cqSj+f
 xG/c5rrCMc5wxwZJhNo7y90ey7MBbhHP1OkO8s1NWZLWrbUQKTRekIh+bfKn/baknDH4ZmpM
 BdmsNFaeEYY2IUsS+D2njbL+od
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="64149496"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>
Subject: [PATCH v2 70/70] x86: Enable CET Indirect Branch Tracking
Date: Mon, 14 Feb 2022 12:51:27 +0000
Message-ID: <20220214125127.17985-71-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

With all the pieces now in place, turn CET-IBT on when available.

MSR_S_CET, like SMEP/SMAP, controls Ring1 meaning that ENDBR_EN can't be
enabled for Xen independently of PV32 kernels.  As we already disable PV32 for
CET-SS, extend this to all CET, adjusting the documentation/comments as
appropriate.

Introduce a cet=no-ibt command line option to allow the admin to disable IBT
even when everything else is configured correctly.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>

v2:
 * Rebase over change to UEFI RS handling
---
 docs/misc/xen-command-line.pandoc | 16 +++++++++++----
 xen/arch/x86/cpu/common.c         |  1 +
 xen/arch/x86/setup.c              | 42 ++++++++++++++++++++++++++++++++++-----
 3 files changed, 50 insertions(+), 9 deletions(-)

diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc
index 1ca817f5e1b9..92891a856971 100644
--- a/docs/misc/xen-command-line.pandoc
+++ b/docs/misc/xen-command-line.pandoc
@@ -271,7 +271,7 @@ enough. Setting this to a high value may cause boot failure, particularly if
 the NMI watchdog is also enabled.
 
 ### cet
-    = List of [ shstk=<bool> ]
+    = List of [ shstk=<bool>, ibt=<bool> ]
 
     Applicability: x86
 
@@ -279,6 +279,10 @@ Controls for the use of Control-flow Enforcement Technology.  CET is group a
 of hardware features designed to combat Return-oriented Programming (ROP, also
 call/jmp COP/JOP) attacks.
 
+CET is incompatible with 32bit PV guests.  If any CET sub-options are active,
+they will override the `pv=32` boolean to `false`.  Backwards compatibility
+can be maintained with the pv-shim mechanism.
+
 *   The `shstk=` boolean controls whether Xen uses Shadow Stacks for its own
     protection.
 
@@ -287,9 +291,13 @@ call/jmp COP/JOP) attacks.
     `cet=no-shstk` will cause Xen not to use Shadow Stacks even when support
     is available in hardware.
 
-    Shadow Stacks are incompatible with 32bit PV guests.  This option will
-    override the `pv=32` boolean to false.  Backwards compatibility can be
-    maintained with the `pv-shim` mechanism.
+*   The `ibt=` boolean controls whether Xen uses Indirect Branch Tracking for
+    its own protection.
+
+    The option is available when `CONFIG_XEN_IBT` is compiled in, and defaults
+    to `true` on hardware supporting CET-IBT.  Specifying `cet=no-ibt` will
+    cause Xen not to use Indirect Branch Tracking even when support is
+    available in hardware.
 
 ### clocksource (x86)
 > `= pit | hpet | acpi | tsc`
diff --git a/xen/arch/x86/cpu/common.c b/xen/arch/x86/cpu/common.c
index 6b674bf15e8b..bfb8cf9f100b 100644
--- a/xen/arch/x86/cpu/common.c
+++ b/xen/arch/x86/cpu/common.c
@@ -345,6 +345,7 @@ void __init early_cpu_init(void)
 	if (c->cpuid_level >= 7) {
 		cpuid_count(7, 0, &eax, &ebx, &ecx, &edx);
 		c->x86_capability[cpufeat_word(X86_FEATURE_CET_SS)] = ecx;
+		c->x86_capability[cpufeat_word(X86_FEATURE_CET_IBT)] = edx;
 	}
 
 	eax = cpuid_eax(0x80000000);
diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c
index f6a59d5f0412..f5449c972825 100644
--- a/xen/arch/x86/setup.c
+++ b/xen/arch/x86/setup.c
@@ -102,6 +102,12 @@ static bool __initdata opt_xen_shstk = true;
 #define opt_xen_shstk false
 #endif
 
+#ifdef CONFIG_XEN_IBT
+static bool __initdata opt_xen_ibt = true;
+#else
+#define opt_xen_ibt false
+#endif
+
 static int __init cf_check parse_cet(const char *s)
 {
     const char *ss;
@@ -120,6 +126,14 @@ static int __init cf_check parse_cet(const char *s)
             no_config_param("XEN_SHSTK", "cet", s, ss);
 #endif
         }
+        else if ( (val = parse_boolean("ibt", s, ss)) >= 0 )
+        {
+#ifdef CONFIG_XEN_IBT
+            opt_xen_ibt = val;
+#else
+            no_config_param("XEN_IBT", "cet", s, ss);
+#endif
+        }
         else
             rc = -EINVAL;
 
@@ -1118,11 +1132,33 @@ void __init noreturn __start_xen(unsigned long mbi_p)
         printk("Enabling Supervisor Shadow Stacks\n");
 
         setup_force_cpu_cap(X86_FEATURE_XEN_SHSTK);
+    }
+
+    if ( opt_xen_ibt && boot_cpu_has(X86_FEATURE_CET_IBT) )
+    {
+        printk("Enabling Indirect Branch Tracking\n");
+
+        setup_force_cpu_cap(X86_FEATURE_XEN_IBT);
+
+        if ( efi_enabled(EFI_RS) )
+            printk("  - IBT disabled in UEFI Runtime Services\n");
+
+        /*
+         * Enable IBT now.  Only require the endbr64 on callees, which is
+         * entirely build-time arrangements.
+         */
+        wrmsrl(MSR_S_CET, CET_ENDBR_EN);
+    }
+
+    if ( cpu_has_xen_shstk || cpu_has_xen_ibt )
+    {
+        set_in_cr4(X86_CR4_CET);
+
 #ifdef CONFIG_PV32
         if ( opt_pv32 )
         {
             opt_pv32 = 0;
-            printk("  - Disabling PV32 due to Shadow Stacks\n");
+            printk("  - Disabling PV32 due to CET\n");
         }
 #endif
     }
@@ -1849,10 +1885,6 @@ void __init noreturn __start_xen(unsigned long mbi_p)
 
     alternative_branches();
 
-    /* Defer CR4.CET until alternatives have finished playing with CR0.WP */
-    if ( cpu_has_xen_shstk )
-        set_in_cr4(X86_CR4_CET);
-
     /*
      * NB: when running as a PV shim VCPUOP_up/down is wired to the shim
      * physical cpu_add/remove functions, so launch the guest with only
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:18:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:18:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272059.466874 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbEw-0004Jw-58; Mon, 14 Feb 2022 13:18:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272059.466874; Mon, 14 Feb 2022 13:18:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbEv-0004Iw-Tj; Mon, 14 Feb 2022 13:18:01 +0000
Received: by outflank-mailman (input) for mailman id 272059;
 Mon, 14 Feb 2022 13:17:59 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJb4b-0008IH-4e
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:07:21 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 09de4c78-8d97-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 14:07:19 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 09de4c78-8d97-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644844039;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=xssEdp0Svf1EAcyTm/CHU0ZkwIg2XP7+KI+3Pd9nxnc=;
  b=KpAQox58+qUhBW8s71bMVh0l4Ht1/xi8M2uGMBAcitomB4tTxR9wQSd7
   LMEfh1eOPwclnoP0m5PcwzUE44UcYCApLIQG93ma7GRG+cranoRRSs2kQ
   fdRvWpi2sWgd2qTThLn4VyjwXgVuNWuYP+e5b9fJud2VqFtp+xfXVniaM
   Q=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: qBoBnxQsU/3wdIOrqcmHNTR2j7JT7U1nrwwDNZuIrcxUm5kZaXWcX7/Pa8fyCZ1/Yey2y/C2PL
 P1F4aMLpN8iHj21GnmFWozEAB8Z9l2+kmf6iYRfN+0gtH/+SzeYhw1ZUmrl1moOcBrbFG5abKF
 z1gkwk1wldHbb862h7fzqbguRmS4dL56QAVqI3Ag3Ph+9nhVUlBkpqd99ibROi9ALSkyUYQDHs
 Hdeo7RFBiZzp84r94QoQWEWlOKutwoocVOGki8CPVpoUd2mDbPva9qVdI7YkMxTuhGts8F/EHp
 1bkFOjiaHiSsm7PngOHBwukl
X-SBRS: 5.1
X-MesageID: 64554412
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:8ISm1KCyz/lBqxVW/zHkw5YqxClBgxIJ4kV8jS/XYbTApD9whGcEm
 zcdUGiEaavYM2PzeNB+bIW19U5TuJ+GyYRjQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMo/u1Si6FatANl1ElvU2zbue6WL6s1hxZH1c+En970E47wobVv6Yz6TSHK1LV0
 T/Ni5W31G+Ng1aY5UpNtspvADs21BjDkGtwUm4WPJinj3eH/5UhN7oNJLnZEpfNatI88thW5
 Qr05OrREmvxp3/BAz4++1rxWhVirrX6ZWBihpfKMkQLb9crSiEai84G2PQghUh/rzjVk9Eu8
 uR0noGKeC50EbyTie0kakwNe81+FfUuFL7vJHG+tYqYzlHccmuqyPJrZK00FdRGoKAtWzgIr
 KFGbmBWBvyAr7veLLaTY+9gnMk8auLsO5sSoCpIxjDFF/c2B5vERs0m4PcGgGpt2pwXR54yY
 eIZYxBiUjflSiFEAXYNVaMjxeaV3lvgJmgwRFW9+vNsvjm7IBZK+KjgNp/Zd8KHQe1Rn12Ev
 STW8mLhGBYYOdeDjz2f/RqRavTnxH2hHthITfvhq6As0Ab7KnEv5AM+cVbnrfjmsH+HcM9lG
 mVJ1TtxvKELzRn+JjXiZCGQrHmBtx8aftNfFewm9Q2AopbpDxal6nssFWAYNoF/3CMibXlzj
 wLSwYu1bdB6mODNERqgGqGoQSRe0MT/BUsLfmc6QAQM+LEPS6lj30uUHr6P/ENY5+AZ+A0cI
 RjX9kDSZJ1J1KbnMplXGnid3VqRSmDhFFJd2+kudjvNAvlFTICkfZe0zlPQ8OxNKo2UJnHY4
 iRYxJjOsb1WVMrX/MBofAnqNOv3j8tpzRWG2QI/d3Xf32jFF4GfkXB4v2gleRYB3jcscj71e
 k7D0T69F7cIVEZGmZRfOtrrY+xzlPCIPY28Cpj8M4ofCrAsJVTv1Hw/OiatM5XFzRFEfVcXY
 szAL65BzB8yVMxa8dZBb7lBgOF7nnhknQs+h/nTlnya7FZXX1bNIZ9tDbdERrlksstoeS3Zr
 IRSMdWk0RJaXLGsayXb69dLf1sLMWI6Fdb9rMkOLryPJQ9vGWcADf7NwOx+J9w5zvoNzuqYr
 GugXkJ4yUbkgSGVIwu9dX0+OqjkWoxyrCxnMHV0b0qowXUqfa2m8LwbK8ksZbAi+eE6lax0Q
 vAJdt+uGPNKTjibqT0RYYOk9N5pdQixhBLINC2gOWBtc5llTg3P29nlYgqwq3VeUnvp7ZMz+
 uTy2BnaTJwPQxVZIPzXMP//nUmsuXU9mf5pWxeaKNdkZ0ixopNhLDb8j6FrLphUewnD3DaTy
 y2fHQwc+bvWu4Yw/dTE2fKEooOuH7csF0ZWBTCGv7O/NC2c9Wu/245QFu2PeGmFBm/z/ayjY
 8RTzu39b6JbzAob7dIkHuY517866vvuu6Ren1ZtE3j8Zli2Dq9tfyud1s5Vu6wRnrJUtGNag
 K5UFgW27VlRBP7YLQ==
IronPort-HdrOrdr: A9a23:9/AWbKlf9L53ofy0ilBXyWESM3jpDfIu3DAbv31ZSRFFG/Fxl6
 iV8sjztCWE8Qr5N0tBpTntAsW9qDbnhPtICOoqTNGftWvdyQiVxehZhOOIqVDd8m/Fh4pgPM
 9bAs9D4bbLbGSS4/yU3ODBKadD/OW6
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="64554412"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v2 61/70] x86/setup: Read CR4 earlier in __start_xen()
Date: Mon, 14 Feb 2022 12:51:18 +0000
Message-ID: <20220214125127.17985-62-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

This is necessary for read_cr4() to function correctly.  Move the EFER caching
at the same time.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
---
 xen/arch/x86/setup.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c
index 735f69d2cae8..2b1192d85b77 100644
--- a/xen/arch/x86/setup.c
+++ b/xen/arch/x86/setup.c
@@ -888,6 +888,9 @@ void __init noreturn __start_xen(unsigned long mbi_p)
 
     /* Full exception support from here on in. */
 
+    rdmsrl(MSR_EFER, this_cpu(efer));
+    asm volatile ( "mov %%cr4,%0" : "=r" (get_cpu_info()->cr4) );
+
     /* Enable NMIs.  Our loader (e.g. Tboot) may have left them disabled. */
     enable_nmis();
 
@@ -934,9 +937,6 @@ void __init noreturn __start_xen(unsigned long mbi_p)
 
     parse_video_info();
 
-    rdmsrl(MSR_EFER, this_cpu(efer));
-    asm volatile ( "mov %%cr4,%0" : "=r" (get_cpu_info()->cr4) );
-
     /* We initialise the serial devices very early so we can get debugging. */
     ns16550.io_base = 0x3f8;
     ns16550.irq     = 4;
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:18:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:18:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272060.466879 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbEw-0004Sp-Tr; Mon, 14 Feb 2022 13:18:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272060.466879; Mon, 14 Feb 2022 13:18:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbEw-0004QW-Iq; Mon, 14 Feb 2022 13:18:02 +0000
Received: by outflank-mailman (input) for mailman id 272060;
 Mon, 14 Feb 2022 13:18:00 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJb4C-0008IH-Pz
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:06:56 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id fac7a096-8d96-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 14:06:55 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fac7a096-8d96-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644844015;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=Iv+EtTL4QKtjYW+p8dU15rg4ZfKzEluz7BW9resL5q4=;
  b=MIOvzfYFH3hsCF5qV4kY75oZEsPT6fGIqSO/+yv/LTaLcslFABg07zGk
   OPSQfCGiQG97PSeqghe8oP9oYMjKP+rSz8JVLUkcvoM0pjsR4tpyn5m2S
   GPxsQJKz1dQ3H+9fjPQ9Xd4icrFYIGMdtlTVJIVmyzcXuYuoV0aUCaWHW
   I=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: 4EaJ4De7JaIZS5ouqAPgjsMWIRv7Tz8YCPfBzzjGG2hm3vLKYI77/wBKvgkkAx7dgJiAceWgB4
 gVXoeIrMqMwy/waTtI3ePBtcckKASl4bj7FBgTHgXNkXuJNFqP1HECQ1X3RxJQpHQjtpZ1Ebqq
 tqRbfVxQJgLCm1re2xDCF9YiD0oa2xbB6wnPxEj8ubeMlTupvxRBUx8asAbM1pMuj41IFWlcNt
 xw/Rs13y8AUdBqTZKtVqYacfatkAkosu9mhLVWlNGXneimFyn6OJkQXvmxf0PGBpmz9HThCEDm
 qeNqADK5gRAMTy2lSQX86kSw
X-SBRS: 5.1
X-MesageID: 64554292
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:/xJMjavt6chmy3R15TnBwqDhN+fnVE9ZMUV32f8akzHdYApBsoF/q
 tZmKT3UbKzbYmqkKd92Ot/i9U0GvJXWyYIxGlRorn83FiwS+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZQP0VOZigHtIQMsadUsxKbVIiGHdJZS5LwbZj2NYy2IThWmthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 Nplq7mybAIkOaP3kds/WDBzCQdQY6RJ5+qSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DFYUToHx/ixreCu4rW8vrSKTW/95Imjw3g6iiGN6AO
 5dENWA+NnwsZTUUGVMFU8g439v5xXOhaDZYg1y+poMOtj27IAtZj+G2bYu9lsaxbdVYmAOUq
 3zL+0z9AwoGL5qPxDyd6HWui+TT2yThV+ov+KaQr6AwxgfJnypKVUNQBQDTTeSFZlCWRfddD
 kkZ/SQVpJcQ/2WAVP/TARS3vyvR1vIDYOZ4H+o/4QCL76Pb5QeFG2QJJgJ8hMwaWNweHmJzi
 ALQ9z/9LXk26eDOFyrBnluBhW7qYUAowXk+iTjopOfvy/3qu8kNgx3GVb6P+4bl34SuSVkcL
 91nxRXSZon/b+ZWjc1XHnid2lpAQ6QlqSZvuG3qspqNtF8RWWJcT9XABaLnxfhBNp2FaVKKo
 WIJncOThMhXU83Ry3zdHbhVRerzjxpgDNE7qQQxd6TNChz3oyLzFWyuyG0WyLhV3jYsJmayP
 R67VfJ5755PJnq6BZKbkKrqY/nGOZPITIy/PtiNN4ImSsEoKGevoXE/DWbNjjuFuBV9zskC1
 WKzLJ/E4YAyUv88klJbho41jNcW+8zJ7T2PG86rlUn7uVdcDVbMIYo43JK1RrhRxMu5TM/9q
 YwOXydT4xkAAuD4fAfN9osfcQIDIXQhXMikoM1LbO+TZAFhHTh5WfPWxLogfa1jnrhUybiUr
 i3sBBcAxQqtn2DDJCWLdmtnNOHlU6FgoC9pJicrJ1uphSQuON798KcFepIrVrA77+g/n+VsR
 vwIdpzYUPRCQzjK4RoHapz5oNAwfRinn1vWbSGkfCI+b9hrQAmQoo3oeQ7m9S8vCCurtJRh/
 +38h12DGZdaHlZsFsfbbv6r3midh3lFlbIgRVbML/lSZF7orNpgJRvug6JlOMoLMxjCmGeXj
 l7EHRcCqODRiIYp692V17ucpoKkHuYiTEpXG27XseS/OSXApzfxxIZBVKCDfCzHVXOy86KnP
 L0Hw/b5OfwBvVBLr4sjTOo7kfNgv4Pi9+1A0wBpPHTXdFD6WLpvL06P0dRLqqAQlKRSvhG7W
 x7X99RXUVlT1BgJzLLFyNIZU9m+
IronPort-HdrOrdr: A9a23:k5pwYa0FptbJb7JbakFR2QqjBEgkLtp133Aq2lEZdPU0SKGlfg
 6V/MjztCWE7Ar5PUtLpTnuAsa9qB/nm6KdgrNhWItKPjOW21dARbsKheffKlXbcBEWndQtt5
 uIHZIeNDXxZ2IK8PoT4mODYqodKA/sytHWuQ/cpU0dMz2Dc8tbnmBE4p7wKDwMeOFBb6BJcq
 a01458iBeLX28YVci/DmltZZm4mzWa/KiWGCLvHnQcmXGzsQ8=
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="64554292"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v2 47/70] x86/logdirty: CFI hardening
Date: Mon, 14 Feb 2022 12:51:04 +0000
Message-ID: <20220214125127.17985-48-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

Control Flow Integrity schemes use toolchain and optionally hardware support
to help protect against call/jump/return oriented programming attacks.

Use cf_check to annotate function pointer targets for the toolchain.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
 xen/arch/x86/mm/hap/hap.c       |  6 +++---
 xen/arch/x86/mm/shadow/common.c | 12 ++++++------
 2 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/xen/arch/x86/mm/hap/hap.c b/xen/arch/x86/mm/hap/hap.c
index de4b13565ab4..ed5112b00b63 100644
--- a/xen/arch/x86/mm/hap/hap.c
+++ b/xen/arch/x86/mm/hap/hap.c
@@ -180,7 +180,7 @@ int hap_track_dirty_vram(struct domain *d,
  * NB: Domain that having device assigned should not set log_global. Because
  * there is no way to track the memory updating from device.
  */
-static int hap_enable_log_dirty(struct domain *d, bool_t log_global)
+static int cf_check hap_enable_log_dirty(struct domain *d, bool log_global)
 {
     struct p2m_domain *p2m = p2m_get_hostp2m(d);
 
@@ -211,7 +211,7 @@ static int hap_enable_log_dirty(struct domain *d, bool_t log_global)
     return 0;
 }
 
-static int hap_disable_log_dirty(struct domain *d)
+static int cf_check hap_disable_log_dirty(struct domain *d)
 {
     paging_lock(d);
     d->arch.paging.mode &= ~PG_log_dirty;
@@ -228,7 +228,7 @@ static int hap_disable_log_dirty(struct domain *d)
     return 0;
 }
 
-static void hap_clean_dirty_bitmap(struct domain *d)
+static void cf_check hap_clean_dirty_bitmap(struct domain *d)
 {
     /*
      * Switch to log-dirty mode, either by setting l1e entries of P2M table to
diff --git a/xen/arch/x86/mm/shadow/common.c b/xen/arch/x86/mm/shadow/common.c
index 83dedc8870aa..071a19adce82 100644
--- a/xen/arch/x86/mm/shadow/common.c
+++ b/xen/arch/x86/mm/shadow/common.c
@@ -40,9 +40,9 @@
 
 DEFINE_PER_CPU(uint32_t,trace_shadow_path_flags);
 
-static int sh_enable_log_dirty(struct domain *, bool log_global);
-static int sh_disable_log_dirty(struct domain *);
-static void sh_clean_dirty_bitmap(struct domain *);
+static int cf_check sh_enable_log_dirty(struct domain *, bool log_global);
+static int cf_check sh_disable_log_dirty(struct domain *);
+static void cf_check sh_clean_dirty_bitmap(struct domain *);
 
 /* Set up the shadow-specific parts of a domain struct at start of day.
  * Called for every domain from arch_domain_create() */
@@ -3016,7 +3016,7 @@ static int shadow_test_disable(struct domain *d)
 /* Shadow specific code which is called in paging_log_dirty_enable().
  * Return 0 if no problem found.
  */
-static int sh_enable_log_dirty(struct domain *d, bool log_global)
+static int cf_check sh_enable_log_dirty(struct domain *d, bool log_global)
 {
     int ret;
 
@@ -3044,7 +3044,7 @@ static int sh_enable_log_dirty(struct domain *d, bool log_global)
 }
 
 /* shadow specfic code which is called in paging_log_dirty_disable() */
-static int sh_disable_log_dirty(struct domain *d)
+static int cf_check sh_disable_log_dirty(struct domain *d)
 {
     int ret;
 
@@ -3058,7 +3058,7 @@ static int sh_disable_log_dirty(struct domain *d)
 /* This function is called when we CLEAN log dirty bitmap. See
  * paging_log_dirty_op() for details.
  */
-static void sh_clean_dirty_bitmap(struct domain *d)
+static void cf_check sh_clean_dirty_bitmap(struct domain *d)
 {
     paging_lock(d);
     /* Need to revoke write access to the domain's pages again.
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:18:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:18:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272071.466895 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbF4-0005iX-6d; Mon, 14 Feb 2022 13:18:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272071.466895; Mon, 14 Feb 2022 13:18:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbF4-0005hS-33; Mon, 14 Feb 2022 13:18:10 +0000
Received: by outflank-mailman (input) for mailman id 272071;
 Mon, 14 Feb 2022 13:18:08 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJb3l-0008IH-Ec
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:06:29 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id eadbca62-8d96-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 14:06:28 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: eadbca62-8d96-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644843988;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=h+vNUb1K3qAiOZwiXH80qTGxNUF4bFpNl76o3YyTOpc=;
  b=ZdeQ/hRJt896EmCTmguNr53p9h0tcZqPceGtp/Bav7CuTjfSCIHot6Mo
   ZU5igBCAoGN3oErOgyKFxHcouIvottesB7vUB8frBPnFg0SVxKZuqGSB/
   4eiiI9Ml9X/yV6XO045UU3rTeYdpSY743cEtOlCm9ccURuIHVE/WAQcRq
   E=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: KulfqVaK5LenOMOoXmgXYyGfQJJez7i9OkIgiVROgNMzcLpsHBgqp/5NBBOAJYY42wQdr78krW
 e9yWNpEzg+P9vLzUpn1zSLH9nmjSgdvgCAoDsWySONr2xE4wh++RyQttCTAFPESaO1WaqFw4he
 XTtQr0bJ4nTrbS4i/sKtDr7XMObdBUOrYBOknFiFT9Jl+Dctrh87JuTvi6CVlJEktOqEIaFde+
 EO2SIBLHPzxDo4zy6UhWzeVZKzcW5g7c2stmgKJcBfCyUe06pj8urkM80uSXiMHOxsBymKq2os
 g9hvjxtEvD8ln8+hzNoN8kdt
X-SBRS: 5.1
X-MesageID: 64050701
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:loj35q9Mz78BUR+WFwm7DrUDmXmTJUtcMsCJ2f8bNWPcYEJGY0x3y
 WseXW/TO67fZGLwL950bInjpEhU75OBnNNmHQU/pHg8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhFWeIdA970Ug5w7Rg3tYx6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhOy
 tJS7pDtGDwbL5/LqfojegBcMihHaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguwKKsXxMZxZkXZn1TzDVt4tQIzZQrWM7thdtNs1rp4SRauGO
 JJAAdZpRCb5UjpdHEgOMZgdgcel11j6aDgDuV3A8MLb5ECMlVcsgdABKuH9atGMAMlYgEucj
 mbH5HjiRAEXMsSFzjiI+W7qgfXA9R4XQ6pLSuf+rKQzxgTOmCpDU3X6SGdXv9GGiEmhAN4Ce
 ncm6xgpnLYM3VWvb9DECkjQTGG/gjYQXN9ZEusf4Q6Ly7bJ7wvxOlXoXgKte/R96pZoGGVCO
 kuh2oqwWGcx6OH9pWe1q+/MxQ5eLxT5OoPricUsaQIeq+fur4go5v4kZoYySfXl5jEZ9NyZ/
 txrkMTcr+hJ5SLo///ilbwiv95LjsKXJjPZHi2NAgqYAvpRPeZJnbCA51nB9upnJ42EVFSHt
 3Vss5HAsLxRXcHQyXTUG79l8FSVCxGtamO0vLKSN8N5q2TFF4CLIei8Hw2S1G82a51ZKFcFk
 WfYuB9L5Y87AZdZRfQfXm5FMOxzlfKIPY28Dpj8N4MSCrAsJF7v1Hw/Pia4gjGy+HXAZIliY
 P93h+73Vi1EYUmmpRLrL9ogPUgDmHxvmzOLHcqjp/lluJLHDEOopX4+GAPmRogEAGms+Vm9H
 w93O5TYxhNBfvf5ZyWLo4cfIUpTdSowBIzsqtwRfemGe1I0FGYkAv7X4LUgZ406wPgFyraWp
 imwCh1C1V7ypXzbMgHWOHptX6ziAMRkpnUhMC1yYVvxgyo/YZyi5bs0focseeV17/RqyPN5F
 qFXe8iJDvlVZC7A/jARMcv0oIB4LUz5jgOSJSu1JjM4esc4FQDO/9bleCrp9TUPUXXr5Zdv/
 eX421qCE5QZRglkAMLHU96Vzgu87SoHheZ/f0rUOd0PKk/ix5dndn7qhfgtLsBSdRianmmG1
 xybCAszrPXWp9Nn68HAgK2Jotv7E+Z6GUYGTWDX4azvaHvf92unh4RBTPyJbXbWU2atoPeuY
 uBczvfdNvwbnQkV79ogQugzla9utcHyo7J6zxh/GCSZZlumPbpsP32a0JQdraZK3LJY5VO7V
 0/nFgO24llV1BcJyGIsGTc=
IronPort-HdrOrdr: A9a23:jNMuyK97mfFpEJgvLhluk+DaI+orL9Y04lQ7vn2YSXRuHPBw9v
 re5cjzuiWVtN98Yh0dcJW7Scy9qBDnhPhICOsqTNSftWDd0QPCRuxfBMnZslnd8kXFh4lgPM
 xbEpSWZueeMbEDt7eZ3DWF
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="64050701"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v2 17/70] xen: CFI hardening for open_softirq()
Date: Mon, 14 Feb 2022 12:50:34 +0000
Message-ID: <20220214125127.17985-18-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

Control Flow Integrity schemes use toolchain and optionally hardware support
to help protect against call/jump/return oriented programming attacks.

Use cf_check to annotate function pointer targets for the toolchain.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
 xen/arch/x86/cpu/mcheck/mce.c       | 2 +-
 xen/arch/x86/domain.c               | 2 +-
 xen/arch/x86/include/asm/flushtlb.h | 2 +-
 xen/arch/x86/pv/traps.c             | 2 +-
 xen/arch/x86/smp.c                  | 2 +-
 xen/arch/x86/time.c                 | 2 +-
 xen/common/rcupdate.c               | 2 +-
 xen/common/sched/core.c             | 6 +++---
 xen/common/tasklet.c                | 2 +-
 xen/common/timer.c                  | 2 +-
 xen/drivers/passthrough/x86/hvm.c   | 2 +-
 11 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/xen/arch/x86/cpu/mcheck/mce.c b/xen/arch/x86/cpu/mcheck/mce.c
index 43f6c8471a90..3467e0f1a315 100644
--- a/xen/arch/x86/cpu/mcheck/mce.c
+++ b/xen/arch/x86/cpu/mcheck/mce.c
@@ -1837,7 +1837,7 @@ static int mce_delayed_action(mctelem_cookie_t mctc)
 }
 
 /* Softirq Handler for this MCE# processing */
-static void mce_softirq(void)
+static void cf_check mce_softirq(void)
 {
     static DEFINE_MCE_BARRIER(mce_inside_bar);
     static DEFINE_MCE_BARRIER(mce_severity_bar);
diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c
index f943283b2a88..1c3a1ec2a080 100644
--- a/xen/arch/x86/domain.c
+++ b/xen/arch/x86/domain.c
@@ -2523,7 +2523,7 @@ void vcpu_mark_events_pending(struct vcpu *v)
         vcpu_kick(v);
 }
 
-static void vcpu_kick_softirq(void)
+static void cf_check vcpu_kick_softirq(void)
 {
     /*
      * Nothing to do here: we merely prevent notifiers from racing with checks
diff --git a/xen/arch/x86/include/asm/flushtlb.h b/xen/arch/x86/include/asm/flushtlb.h
index 0be2273387ed..18777f1d4c00 100644
--- a/xen/arch/x86/include/asm/flushtlb.h
+++ b/xen/arch/x86/include/asm/flushtlb.h
@@ -87,7 +87,7 @@ static inline void tlbflush_filter(cpumask_t *mask, uint32_t page_timestamp)
             __cpumask_clear_cpu(cpu, mask);
 }
 
-void new_tlbflush_clock_period(void);
+void cf_check new_tlbflush_clock_period(void);
 
 /* Read pagetable base. */
 static inline unsigned long read_cr3(void)
diff --git a/xen/arch/x86/pv/traps.c b/xen/arch/x86/pv/traps.c
index 170e1030982b..97fe54b5ee5a 100644
--- a/xen/arch/x86/pv/traps.c
+++ b/xen/arch/x86/pv/traps.c
@@ -130,7 +130,7 @@ bool set_guest_nmi_trapbounce(void)
 
 static DEFINE_PER_CPU(struct vcpu *, softirq_nmi_vcpu);
 
-static void nmi_softirq(void)
+static void cf_check nmi_softirq(void)
 {
     struct vcpu **v_ptr = &this_cpu(softirq_nmi_vcpu);
 
diff --git a/xen/arch/x86/smp.c b/xen/arch/x86/smp.c
index f6fd7f95df58..b9a696f61963 100644
--- a/xen/arch/x86/smp.c
+++ b/xen/arch/x86/smp.c
@@ -290,7 +290,7 @@ void flush_area_mask(const cpumask_t *mask, const void *va, unsigned int flags)
 }
 
 /* Call with no locks held and interrupts enabled (e.g., softirq context). */
-void new_tlbflush_clock_period(void)
+void cf_check new_tlbflush_clock_period(void)
 {
     cpumask_t allbutself;
 
diff --git a/xen/arch/x86/time.c b/xen/arch/x86/time.c
index b444d6344e79..5a72b66800e4 100644
--- a/xen/arch/x86/time.c
+++ b/xen/arch/x86/time.c
@@ -1455,7 +1455,7 @@ int cpu_frequency_change(u64 freq)
 static DEFINE_PER_CPU(struct cpu_time_stamp, cpu_calibration);
 
 /* Softirq handler for per-CPU time calibration. */
-static void local_time_calibration(void)
+static void cf_check local_time_calibration(void)
 {
     struct cpu_time *t = &this_cpu(cpu_time);
     const struct cpu_time_stamp *c = &this_cpu(cpu_calibration);
diff --git a/xen/common/rcupdate.c b/xen/common/rcupdate.c
index 423d6b1d6d02..212a99acd8c8 100644
--- a/xen/common/rcupdate.c
+++ b/xen/common/rcupdate.c
@@ -466,7 +466,7 @@ static void __rcu_process_callbacks(struct rcu_ctrlblk *rcp,
         rcu_do_batch(rdp);
 }
 
-static void rcu_process_callbacks(void)
+static void cf_check rcu_process_callbacks(void)
 {
     struct rcu_data *rdp = &this_cpu(rcu_data);
 
diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c
index 285de9ee2a19..b1836b591c0a 100644
--- a/xen/common/sched/core.c
+++ b/xen/common/sched/core.c
@@ -2568,7 +2568,7 @@ static struct sched_unit *sched_wait_rendezvous_in(struct sched_unit *prev,
     return prev->next_task;
 }
 
-static void sched_slave(void)
+static void cf_check sched_slave(void)
 {
     struct vcpu          *v, *vprev = current;
     struct sched_unit    *prev = vprev->sched_unit, *next;
@@ -2632,7 +2632,7 @@ static void sched_slave(void)
  * - deschedule the current domain (scheduler independent).
  * - pick a new domain (scheduler dependent).
  */
-static void schedule(void)
+static void cf_check schedule(void)
 {
     struct vcpu          *vnext, *vprev = current;
     struct sched_unit    *prev = vprev->sched_unit, *next = NULL;
@@ -2928,7 +2928,7 @@ const cpumask_t *sched_get_opt_cpumask(enum sched_gran opt, unsigned int cpu)
     return mask;
 }
 
-static void schedule_dummy(void)
+static void cf_check schedule_dummy(void)
 {
     sched_tasklet_check_cpu(smp_processor_id());
 }
diff --git a/xen/common/tasklet.c b/xen/common/tasklet.c
index 1b16bbcdeb0b..3ad67b5c2493 100644
--- a/xen/common/tasklet.c
+++ b/xen/common/tasklet.c
@@ -135,7 +135,7 @@ void do_tasklet(void)
 }
 
 /* Softirq context work */
-static void tasklet_softirq_action(void)
+static void cf_check tasklet_softirq_action(void)
 {
     unsigned int cpu = smp_processor_id();
     struct list_head *list = &per_cpu(softirq_tasklet_list, cpu);
diff --git a/xen/common/timer.c b/xen/common/timer.c
index b788050ea1d8..700f191a70b4 100644
--- a/xen/common/timer.c
+++ b/xen/common/timer.c
@@ -450,7 +450,7 @@ static void execute_timer(struct timers *ts, struct timer *t)
 }
 
 
-static void timer_softirq_action(void)
+static void cf_check timer_softirq_action(void)
 {
     struct timer  *t, **heap, *next;
     struct timers *ts;
diff --git a/xen/drivers/passthrough/x86/hvm.c b/xen/drivers/passthrough/x86/hvm.c
index 527bd6a56d83..0e3c0f6aeed3 100644
--- a/xen/drivers/passthrough/x86/hvm.c
+++ b/xen/drivers/passthrough/x86/hvm.c
@@ -1003,7 +1003,7 @@ int arch_pci_clean_pirqs(struct domain *d)
  * Note: 'pt_pirq_softirq_reset' can clear the STATE_SCHED before we get to
  * doing it. If that is the case we let 'pt_pirq_softirq_reset' do ref-counting.
  */
-static void dpci_softirq(void)
+static void cf_check dpci_softirq(void)
 {
     unsigned int cpu = smp_processor_id();
     LIST_HEAD(our_list);
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:18:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:18:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272094.466907 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbFF-00071d-KF; Mon, 14 Feb 2022 13:18:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272094.466907; Mon, 14 Feb 2022 13:18:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbFF-00071G-GO; Mon, 14 Feb 2022 13:18:21 +0000
Received: by outflank-mailman (input) for mailman id 272094;
 Mon, 14 Feb 2022 13:18:20 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KkXt=S5=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nJb3X-00023t-1C
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:06:15 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e2d506b2-8d96-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 14:06:13 +0100 (CET)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2113.outbound.protection.outlook.com [104.47.17.113]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-15-g_p5hmWkNEqg-6-zvkGJCg-1; Mon, 14 Feb 2022 14:06:12 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5199.eurprd04.prod.outlook.com (2603:10a6:803:62::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.15; Mon, 14 Feb
 2022 13:06:11 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4975.015; Mon, 14 Feb 2022
 13:06:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e2d506b2-8d96-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644843973;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=4FVh8cPtI6Qx3JBUWvCzCxbP2jpQnDKqAq4oIJlIiI4=;
	b=mn6NzQgz8I54a8fpXxqLmJsV4yzeAY3kKr+i+UI8us4zyi5Ipboh9iWOcitAlLdA7n8kj/
	BdDFjOIuSFlEmoZSp4hCu4sBmEOFewGRiXQTjlXjf8ZBHSSIb5vKQZSUuc7E0k7r0JuJ1n
	RBk5y02M9JwanH3ZhX52qz+DvtVLbwo=
X-MC-Unique: g_p5hmWkNEqg-6-zvkGJCg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=fSrVERXDbLP5B1NZUaO56yeafgddpABbB5DnxoLqeCYCV3WB4lYMxOpju8AM3leQBUgda5yQ6s7CZsygweV/LkYEnFUTfKWZFqDMzCz3FSsBL4ujiv0xUlYWOcSCXFEzVxBPZc/6SLNzjwIwuYD84Xfkputf7xlLWeHC5KI+vnmfsbp6jrUILfk2Xo+8SCwktvtzEGjyH6EC8k7nk6fMrW74kTdE6ZTYhrbnAWzFj8i2GvUlrcLeonSB3MArV7n0IG+fp+WN/lQinI+Hh/hYxDepjqkLmvyzNGmU3GiH4kJacwUWtdrCs4EHz4FXsBYDOCiC5tDJspGUS2M/50aw7w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=4FVh8cPtI6Qx3JBUWvCzCxbP2jpQnDKqAq4oIJlIiI4=;
 b=JM30sCrm5MFJOV2NDn6W7AEKm+MUak8vZTIZeUeazom+klpVqVmrtelKbr7xScRb4yM6D+1kLZ37ksSZagH2sKPTyBJ1tA9znsgTP1kcyYpDdvYweJG4bFJEpY4NtbX4yrzGtnJoT5nicOQIiRpW9hZxG+AqeN7rW4E+euWMFzBrxo8Fw8XJCpbDcHlANPHWHZt1/7s9yevfLc5lDOohVH3dB7c9Me0lLyF0oPSaMuPPo+uxe6/w1ZyT9LcctZblnScExip2/v60vN9lCuMeCZ8pckd+UaDJ9nQaVpHEH2UyIFHn7VrK01u1/qMSl5Hn9QBmXh6q7IBVTK4jNKFbAA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <5d53c6f9-8d1a-3d48-6ea6-14a484d578a0@suse.com>
Date: Mon, 14 Feb 2022 14:06:09 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH v2 3/7] x86/altcall: Optimise away endbr64 instruction
 where possible
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20220214125632.24563-1-andrew.cooper3@citrix.com>
 <20220214125632.24563-4-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220214125632.24563-4-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR10CA0037.EURPRD10.PROD.OUTLOOK.COM
 (2603:10a6:209:80::14) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 51a1ad90-9478-4900-1a98-08d9efbac5b0
X-MS-TrafficTypeDiagnostic: VI1PR04MB5199:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB5199FD765B33D8B64AAB23F4B3339@VI1PR04MB5199.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	WId77kIrvDMgFcMuaYqBSEwJn3q/QCPPwdzfFvMKzyLq/xW270P8vvNzftsYxbMI1Rcla4gDNYDz4ppCnNlNGG1VH58ZoAvWv1wO671zTnCQEirPkAvjmmsG4Hyc+xQ1CFjyu1QppzHN+q3D2a4Sv/b/g6hgGl1viX6VBZOqBz2wGJrbGbhMySytE86onpFNkzIkp2n9Dn18pGnxjQnfFmhF6+RZtI4drTkXJKGNPXCyaAzxmW6hBpYiWCIZVjYVVQry3R4XOu/Ip84plUSlEiAtdagX6bmZ5JuUGagbHsQ90w8CRJLuC1xq/2C2Yu9+s81Mb0FRsI7zLZHZNTUDDbUPmVDJpB51Qlv/Cr5WXi1Xez9pqxJnuM8sz2F4X/swNphUw7GUealVVcvLqxZjugllllHCGKlPjEa0xN8ssgWv5Tf+C+MFh+A0IkI8V6QYZq64JJXfpgV8anr3lLgt3m4d+PargU99dL7DFeYhXhTMtKfrW2TWR/1jQZ9Y6NuZfteSf6TNSqSNjUAZD1qJ9vyIbJJf7RHxQTeDq22LFUMFpcjkrt3+1CjA4VTtyZN9Y1T0wCC2l9sGb8Th42wHJ1mWqrtfRbytngAJMVX1MCvuCsI7A3iiift091rFJgvZOuWLqQbeoROAjnk5Ttu7HD6XKNL4KbBR5KKhkpuVoPndTnk5jmXPDR0mim8lpYlMP3CL3f/FHF2rI0dsrNZO6juTmiUjcylHChgcunEGoAU=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(4326008)(31686004)(66946007)(83380400001)(36756003)(86362001)(2906002)(5660300002)(66556008)(66476007)(8936002)(8676002)(31696002)(508600001)(2616005)(54906003)(6512007)(6506007)(6486002)(6916009)(186003)(316002)(53546011)(38100700002)(26005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Y3BnckpCZDhxTG54Y2FkMURyWkxhYzdsL1ZxUFB3TkpYNjZMU3NFRTk5a1JZ?=
 =?utf-8?B?bDdMc29YZ3Y4L1VnT1N6QUQ1ZlFoZ0hyYjlMYTgyMWhHcEVGSW1xSWZGNjlw?=
 =?utf-8?B?bUErTWsxeS9leVQrQW5FRzlzZTErcFNtVWZURkg2VFlFSDQ3L08vODNiTjNp?=
 =?utf-8?B?YmhtTzV4WDFKQVkwS2cvY2tBUjV4YUxQTzZVSndsaXMvc0U3VnFrd20vL2NK?=
 =?utf-8?B?TEU4WFhKaTQ1NGhKME5WQThDYklPVHpFZjV2bnF6RnVXMjBvNGFLb3F5a0Fp?=
 =?utf-8?B?enFQZk03RnZ4MGcwT2twanFsOVV3QW05M29lT1l5UFdkSmZqWktRbUtzSExl?=
 =?utf-8?B?WGhJYUhuTnlZMjNBUmVLdVdyME9ES2hOVkllKzJKR0RxMFhadE04SWJHallE?=
 =?utf-8?B?MzVaRmRFMmMxZ2EyRCt2RU5zSGR1ZDFUNmF0eStoTHk2SEdjU1kvN3UxMjdR?=
 =?utf-8?B?YkVtdlFxOFp2dzhscHRzQVRLUnQxOW1wcEsrdHVJemQxVXRFc0JRZXVQVnJO?=
 =?utf-8?B?SVZxN2NDcWhrVjNJY1hiMWc2WjNZSXNoS00zMXNMQXN5STE4NXNFT3hhR0ZC?=
 =?utf-8?B?YnhmZGJlY1h6eWlScmpjZCs4T3dXWUtkWk05dk1FNFNyV3pUdW9TNDNzVmZR?=
 =?utf-8?B?RTB5TllPU3l4ZUFzQW5uYThpYUdzN1ZnNm91VmxEblBWUFlNWWlCSlEzNGRU?=
 =?utf-8?B?T0ZQdkFCOXJBeGpEeWRCTnNmNStUMjEwUkdUZElYbi9ZdThJc3ZiREVhVHJr?=
 =?utf-8?B?aitPcmdnSXpYNGdPTENGcmZ6cXBhQkZEVUU0RW9ucmQ4MSt4MnRXb1JyQ3d4?=
 =?utf-8?B?a2haSUF0YVROT25CUnZzQitKNXNNZU9sM3E4Qk1DYjlJQzFaYnpOUjN1L29a?=
 =?utf-8?B?T0s4VytwS0JHMFR6NytiRmJ0OW5ybDR3L1ZmUFBxTjF3VWZYV3RVYzBQNmRY?=
 =?utf-8?B?QStyeFJVOGt2NmdjYmlldXVzN0xjOHcvK2tscjVReURjbUM1YytBVWZOMTcw?=
 =?utf-8?B?a3lFQ0R3VTMvZWNCWGN3RXRWNDVYbzJ1OFN4RHNQblltc1V3aUJqSHo1NVBX?=
 =?utf-8?B?eDd4ekJiVkViZWxKRFZmWUc5SXpzajVuMzV6QS9meDIySWhIMXVXS2Z6R0hu?=
 =?utf-8?B?d1A2WlBxeDQ3Um16RlBhanc3VVIvVnVHRUM3Z3lJL1VLUlVmL2FTNzZKYjRH?=
 =?utf-8?B?NTlpZklJa0ZpSXlncUR6cVpFckZraXhrODZFNGJQYldCbW9NTnJ1QzVPWW15?=
 =?utf-8?B?U0htSlVYamJobjVxaldKUXhoRzI3ZXFiT0JrY0xQd3g5N3NZODFLZVp6dmtF?=
 =?utf-8?B?dmpLdnQxRHVaRkREV05sNEpvUW9YVGkrN1V0RUdMUEdUYzBmdUlXVUZJS0Rh?=
 =?utf-8?B?Nm83TWpsS1ZBVHgvSFhQaHZoVklBWWpzeGxiYzl5Um5WZzhjME1HQ3Vrcyth?=
 =?utf-8?B?ZFplTTFSV1EvRVZIOWFINVRTZDNwQ1lEMDJoZmNEMmU2MDZXa014WGc2YkYz?=
 =?utf-8?B?MnhGcVUvdmhFWElrOWZBYm91YURveGpjQmZoOSt0V0tsZFFGMzNJT2VyMktL?=
 =?utf-8?B?ZXJneUcvTXI1YjJrMFNsT09jU0JibzRWNnFHbjhhOHRscmRtYjQzbC9IbHdP?=
 =?utf-8?B?Q0RPeDArV3ViTi9Zcmx2NVluUkZLWTdNRFlXQzRsUklobEU3VWJXZmZ4T3ha?=
 =?utf-8?B?SDZoMVZkK1gxR3dYY2cxeHhlU1BqS3plYUdSdDhWeTMrNnZreUhISmlabEU1?=
 =?utf-8?B?RGwyUW5yemh6NVQySCtESW52TE10NEI1TUZ3cGg1SmNXZ0M4MENiUGY0Rk9y?=
 =?utf-8?B?cnFLWkh6N2F0czdZZ1JvdEdDM1FBRXdFVlN1OXRidkRDTW0veFlzWjlzUWZ4?=
 =?utf-8?B?WVhrbW44eGE0dnhvVFFIeUpIT05ybXNRd3VaWk5OZlcyaVgrcTRqcjVlV05i?=
 =?utf-8?B?dUJiY21GOEFnWUN1Q0dCOXlPUm1ZWERjUjVaRFlFUlpoTHpKeEhENnNmVDlj?=
 =?utf-8?B?TzB1dlkvem1nSlM3M3FSQTNkSDZMd2Vaemd5RkZBYi84ODg5c2g0eUdkT0p4?=
 =?utf-8?B?WW9rbnYvN05GTCtRL3NYY1QwZ0FwQ3dvUlNGc3k5Y1k0a0VUbGxkNUR3amxu?=
 =?utf-8?B?UTJBN3htNzkzejZNQVE4bDFiS0M1Z05raE0zamw1V0xZSFJsekwzcmZOdGJv?=
 =?utf-8?Q?eDSq/3b1njtGXSzwlOlF8nA=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 51a1ad90-9478-4900-1a98-08d9efbac5b0
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2022 13:06:11.0806
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8a5xpDeGBPjhmEGgxoGJksrWAI1mPMIR7fIMj5r7d6hhFn1jENsLJMSGeHqdViWj7sGuRCN+JyjY2mhUt6cqvA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5199

On 14.02.2022 13:56, Andrew Cooper wrote:
> With altcall, we convert indirect branches into direct ones.  With that
> complete, none of the potential targets need an endbr64 instruction.
> 
> Furthermore, removing the endbr64 instructions is a security defence-in-depth
> improvement, because it limits the options available to an attacker who has
> managed to hijack a function pointer.
> 
> Introduce new .init.{ro,}data.cf_clobber sections.  Have _apply_alternatives()
> walk over this, looking for any pointers into .text, and clobber an endbr64
> instruction if found.  This is some minor structure (ab)use but it works
> alarmingly well.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>
with two remarks, which ideally would be addressed by respective
small adjustments:

> @@ -330,6 +333,41 @@ static void init_or_livepatch _apply_alternatives(struct alt_instr *start,
>          add_nops(buf + a->repl_len, total_len - a->repl_len);
>          text_poke(orig, buf, total_len);
>      }
> +
> +    /*
> +     * Clobber endbr64 instructions now that altcall has finished optimising
> +     * all indirect branches to direct ones.
> +     */
> +    if ( force && cpu_has_xen_ibt )
> +    {
> +        void *const *val;
> +        unsigned int clobbered = 0;
> +
> +        /*
> +         * This is some minor structure (ab)use.  We walk the entire contents
> +         * of .init.{ro,}data.cf_clobber as if it were an array of pointers.
> +         *
> +         * If the pointer points into .text, and at an endbr64 instruction,
> +         * nop out the endbr64.  This causes the pointer to no longer be a
> +         * legal indirect branch target under CET-IBT.  This is a
> +         * defence-in-depth measure, to reduce the options available to an
> +         * adversary who has managed to hijack a function pointer.
> +         */
> +        for ( val = __initdata_cf_clobber_start;
> +              val < __initdata_cf_clobber_end;
> +              val++ )
> +        {
> +            void *ptr = *val;
> +
> +            if ( !is_kernel_text(ptr) || !is_endbr64(ptr) )
> +                continue;
> +
> +            add_nops(ptr, 4);

This literal 4 would be nice to have a #define next to where the ENDBR64
encoding has its central place.

> --- a/xen/arch/x86/xen.lds.S
> +++ b/xen/arch/x86/xen.lds.S
> @@ -221,6 +221,12 @@ SECTIONS
>         *(.initcall1.init)
>         __initcall_end = .;
>  
> +       . = ALIGN(POINTER_ALIGN);
> +       __initdata_cf_clobber_start = .;
> +       *(.init.data.cf_clobber)
> +       *(.init.rodata.cf_clobber)
> +       __initdata_cf_clobber_end = .;
> +
>         *(.init.data)
>         *(.init.data.rel)
>         *(.init.data.rel.*)

With r/o data ahead and r/w data following, may I suggest to flip the
order of the two section specifiers you add?

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:18:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:18:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272097.466918 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbFH-0007N6-5Z; Mon, 14 Feb 2022 13:18:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272097.466918; Mon, 14 Feb 2022 13:18:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbFH-0007MB-1A; Mon, 14 Feb 2022 13:18:23 +0000
Received: by outflank-mailman (input) for mailman id 272097;
 Mon, 14 Feb 2022 13:18:21 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJb4j-0008IH-Sa
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:07:30 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0e18c045-8d97-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 14:07:26 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0e18c045-8d97-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644844046;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=LtJo+RP7waNzs+O/em8BrBScnR7VYL3LyvaDnkUSQHU=;
  b=Rjh25R4g4/Hjy+5YLDHBsHixUq159uEw6MR5EXTMVs7ME+P9qIKRskPb
   3HGdReXkf4jbM+PS7YeBb+mb/Z2FNcNsVS1e8bywpNO2OKYdVy3ITpJql
   +SDXUcWN7J15CdXNkHSjFT9k0iUtwXnwwKJpCFDJgyEHT3kPTybiMbgEu
   k=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: JHmOLz3WTCcCK+Mlkx2/1s5a3W5ucwAGtEWS1O9nHaWkHNCnIuYmX04uzbDGFzFM+oSUl+IBV+
 txitSnxsmxLAkc++0xAhyeG7qGWdfRNkCxoUbL/KT25zgQurtKtmL1EHdm1XMa6O36iI1NwgBG
 fG+p8uKee+Fdfk5oI/zbno8Bxa6ezpGNodrfLe9Dubviye3BPZiXhq9NrxX7RsJNR420tYysIE
 /densTuIjbJnkkbUTxRaBEqP1e6hergHhP9Jt5UHFuyf/pdxpvLuJ1mte4KUGpMM+SB4BMmrQy
 EW0DmMu7AvwQ1x2Cr9hJiFLK
X-SBRS: 5.1
X-MesageID: 64554482
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:UjAjEaLg3RfVaszbFE+RyZIlxSXFcZb7ZxGr2PjKsXjdYENS3zUBm
 mBKX2vVO/iMZjf3KNgiPoSxoRxQusCAz4NhTQplqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokcxIn5BC5C5xZVG/fjgqoHUVaiUakideSc+EH170Ug6x7Zg6mJVqYPR7z2l6
 IuaT/L3YDdJ6xYsWo7Dw/vewP/HlK2aVAIw5jTSV9gS1LPtvyB94KYkDbOwNxPFrrx8RYZWc
 QphIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbrGvaUXe345iXMfwZ3u7hB2yxdB32
 PRvmqW2SAULMbzTwbsyYyZXRnQW0a1uoNcrIFC6uM2XiUbHb2Ht07NlC0Re0Y8wo7gtRzsUr
 LpBdW5LPkvra+GemdpXTsFFgMg5IdatF4QYonx6lhnSDOo8QICFSKLPjTNd9Gls250SQaaED
 yYfQX1BXDjBPzRgA1dNV8MGwOeImVjYbjIN/Tp5ooJoujOOnWSdyoPFINfTP9CHW8hRtkKZv
 X7duXT0BAkAM96SwibD9Wij7tIjhguiBthUTufhsKc33hvDnQT/FSH6S3OA+/m/mm+cdOtZK
 k429Tsx9PcdxHOkG4yVswKDnFaIuRsVWtx1GuI86R2Qxqe83zt1FlToXRYaNoV46ZZeqSgCk
 wbQwoi3XWAHXKi9FCrFnop4uw9eLsT8wYUqQSYfBTUI7ND4yG3YpkKeF40zeEJZYzCcJN0R/
 9xohHVk71nwpZRSv0lewbwgq2jyzqUltiZvum3qspuNt2uVnrKNaY2y8kT85v1dNoufRVTpl
 CFax5TBvLBTUMnUz3blrAAx8FaBvajtDdEhqQQ3Q8lJG8qFpxZPgry8EBkhfRw0Y67oiBfiY
 VPJuBM52XOgFCDCUEODWKroU55C5fG5TbzND6mIBvITMskZXFLWp0lGOB/Pt10BZWBxyMnTz
 7/AKp3yZZvbYIw6pAeLqxA1j+N6mHBmnTmLLX05pjz+uYejiLeuYe9tGDOzgioRtfnayOkM2
 9oAZcaM1TtFV+jyPnve/YIJdAhYJnknH5Hm7cdQc7fbcAZhHWggDd7XwK8gJNM5z/gEyL+Q8
 yHvQFJcxXr+mWbDdVeAZEd8Ze69Rp14t386Y3AhZA76x3g5bI+zx64DbJ9rL6I//eluwKcsH
 fkIcsmNGNpVTTHD92hPZJXxttU6Jh+qmRiPL2yuZz1mJ8xsQAnA+9nFeArz9XZRUnrr5JVm+
 7D5j1HVW5sOQQhmHf36UvP3wgPjp2UZlcJzQ1DMfotZdnLz/dU4MCf2lPI2fZ0BcE2R2juA2
 g+KKh4Evu2R8ZQt+dzEiK3Y/YekF+xyQhhTE2XBtOvkMCDb+iyowJNaUfbOdjfYDTum9KKnb
 ORT7vf9LPxYwwoa79siS+5mnfAk+t/ih75G1QA1TnzEYmOiBq5kPnTbj9JEsbdAx+MBtAa7M
 q5VFgK25Vld1BvZLWMs
IronPort-HdrOrdr: A9a23:9JZrPanj0MRPGmbv4hoe/P0odXXpDfIu3DAbv31ZSRFFG/Fxl6
 iV8sjztCWE8Qr5N0tBpTntAsW9qDbnhPtICOoqTNGftWvdyQiVxehZhOOIqVDd8m/Fh4pgPM
 9bAs9D4bbLbGSS4/yU3ODBKadD/OW6
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="64554482"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v2 19/70] xsm: CFI hardening
Date: Mon, 14 Feb 2022 12:50:36 +0000
Message-ID: <20220214125127.17985-20-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

Control Flow Integrity schemes use toolchain and optionally hardware support
to help protect against call/jump/return oriented programming attacks.

Use cf_check to annotate function pointer targets for the toolchain.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Daniel P. Smith <dpsmith@apertussolutions.com>
---
 xen/include/xsm/dummy.h  | 211 ++++++++++++++++++++++--------------------
 xen/xsm/flask/flask_op.c |   2 +-
 xen/xsm/flask/hooks.c    | 232 ++++++++++++++++++++++++++---------------------
 xen/xsm/flask/private.h  |   4 +-
 xen/xsm/silo.c           |  24 ++---
 5 files changed, 257 insertions(+), 216 deletions(-)

diff --git a/xen/include/xsm/dummy.h b/xen/include/xsm/dummy.h
index b024119896e6..58afc1d58973 100644
--- a/xen/include/xsm/dummy.h
+++ b/xen/include/xsm/dummy.h
@@ -101,46 +101,48 @@ static always_inline int xsm_default_action(
     }
 }
 
-static XSM_INLINE void xsm_security_domaininfo(
+static XSM_INLINE void cf_check xsm_security_domaininfo(
     struct domain *d, struct xen_domctl_getdomaininfo *info)
 {
     return;
 }
 
-static XSM_INLINE int xsm_domain_create(
+static XSM_INLINE int cf_check xsm_domain_create(
     XSM_DEFAULT_ARG struct domain *d, uint32_t ssidref)
 {
     XSM_ASSERT_ACTION(XSM_HOOK);
     return xsm_default_action(action, current->domain, d);
 }
 
-static XSM_INLINE int xsm_getdomaininfo(XSM_DEFAULT_ARG struct domain *d)
+static XSM_INLINE int cf_check xsm_getdomaininfo(
+    XSM_DEFAULT_ARG struct domain *d)
 {
     XSM_ASSERT_ACTION(XSM_HOOK);
     return xsm_default_action(action, current->domain, d);
 }
 
-static XSM_INLINE int xsm_domctl_scheduler_op(
+static XSM_INLINE int cf_check xsm_domctl_scheduler_op(
     XSM_DEFAULT_ARG struct domain *d, int cmd)
 {
     XSM_ASSERT_ACTION(XSM_HOOK);
     return xsm_default_action(action, current->domain, d);
 }
 
-static XSM_INLINE int xsm_sysctl_scheduler_op(XSM_DEFAULT_ARG int cmd)
+static XSM_INLINE int cf_check xsm_sysctl_scheduler_op(XSM_DEFAULT_ARG int cmd)
 {
     XSM_ASSERT_ACTION(XSM_HOOK);
     return xsm_default_action(action, current->domain, NULL);
 }
 
-static XSM_INLINE int xsm_set_target(
+static XSM_INLINE int cf_check xsm_set_target(
     XSM_DEFAULT_ARG struct domain *d, struct domain *e)
 {
     XSM_ASSERT_ACTION(XSM_HOOK);
     return xsm_default_action(action, current->domain, NULL);
 }
 
-static XSM_INLINE int xsm_domctl(XSM_DEFAULT_ARG struct domain *d, int cmd)
+static XSM_INLINE int cf_check xsm_domctl(
+    XSM_DEFAULT_ARG struct domain *d, int cmd)
 {
     XSM_ASSERT_ACTION(XSM_OTHER);
     switch ( cmd )
@@ -157,91 +159,93 @@ static XSM_INLINE int xsm_domctl(XSM_DEFAULT_ARG struct domain *d, int cmd)
     }
 }
 
-static XSM_INLINE int xsm_sysctl(XSM_DEFAULT_ARG int cmd)
+static XSM_INLINE int cf_check xsm_sysctl(XSM_DEFAULT_ARG int cmd)
 {
     XSM_ASSERT_ACTION(XSM_PRIV);
     return xsm_default_action(action, current->domain, NULL);
 }
 
-static XSM_INLINE int xsm_readconsole(XSM_DEFAULT_ARG uint32_t clear)
+static XSM_INLINE int cf_check xsm_readconsole(XSM_DEFAULT_ARG uint32_t clear)
 {
     XSM_ASSERT_ACTION(XSM_HOOK);
     return xsm_default_action(action, current->domain, NULL);
 }
 
-static XSM_INLINE int xsm_alloc_security_domain(struct domain *d)
+static XSM_INLINE int cf_check xsm_alloc_security_domain(struct domain *d)
 {
     return 0;
 }
 
-static XSM_INLINE void xsm_free_security_domain(struct domain *d)
+static XSM_INLINE void cf_check xsm_free_security_domain(struct domain *d)
 {
     return;
 }
 
-static XSM_INLINE int xsm_grant_mapref(
+static XSM_INLINE int cf_check xsm_grant_mapref(
     XSM_DEFAULT_ARG struct domain *d1, struct domain *d2, uint32_t flags)
 {
     XSM_ASSERT_ACTION(XSM_HOOK);
     return xsm_default_action(action, d1, d2);
 }
 
-static XSM_INLINE int xsm_grant_unmapref(
+static XSM_INLINE int cf_check xsm_grant_unmapref(
     XSM_DEFAULT_ARG struct domain *d1, struct domain *d2)
 {
     XSM_ASSERT_ACTION(XSM_HOOK);
     return xsm_default_action(action, d1, d2);
 }
 
-static XSM_INLINE int xsm_grant_setup(
+static XSM_INLINE int cf_check xsm_grant_setup(
     XSM_DEFAULT_ARG struct domain *d1, struct domain *d2)
 {
     XSM_ASSERT_ACTION(XSM_TARGET);
     return xsm_default_action(action, d1, d2);
 }
 
-static XSM_INLINE int xsm_grant_transfer(
+static XSM_INLINE int cf_check xsm_grant_transfer(
     XSM_DEFAULT_ARG struct domain *d1, struct domain *d2)
 {
     XSM_ASSERT_ACTION(XSM_HOOK);
     return xsm_default_action(action, d1, d2);
 }
 
-static XSM_INLINE int xsm_grant_copy(
+static XSM_INLINE int cf_check xsm_grant_copy(
     XSM_DEFAULT_ARG struct domain *d1, struct domain *d2)
 {
     XSM_ASSERT_ACTION(XSM_HOOK);
     return xsm_default_action(action, d1, d2);
 }
 
-static XSM_INLINE int xsm_grant_query_size(
+static XSM_INLINE int cf_check xsm_grant_query_size(
     XSM_DEFAULT_ARG struct domain *d1, struct domain *d2)
 {
     XSM_ASSERT_ACTION(XSM_TARGET);
     return xsm_default_action(action, d1, d2);
 }
 
-static XSM_INLINE int xsm_memory_exchange(XSM_DEFAULT_ARG struct domain *d)
+static XSM_INLINE int cf_check xsm_memory_exchange(
+    XSM_DEFAULT_ARG struct domain *d)
 {
     XSM_ASSERT_ACTION(XSM_TARGET);
     return xsm_default_action(action, current->domain, d);
 }
 
-static XSM_INLINE int xsm_memory_adjust_reservation(
+static XSM_INLINE int cf_check xsm_memory_adjust_reservation(
     XSM_DEFAULT_ARG struct domain *d1, struct domain *d2)
 {
     XSM_ASSERT_ACTION(XSM_TARGET);
     return xsm_default_action(action, d1, d2);
 }
 
-static XSM_INLINE int xsm_memory_stat_reservation(
+static XSM_INLINE int cf_check xsm_memory_stat_reservation(
     XSM_DEFAULT_ARG struct domain *d1, struct domain *d2)
 {
     XSM_ASSERT_ACTION(XSM_TARGET);
     return xsm_default_action(action, d1, d2);
 }
 
-static XSM_INLINE int xsm_console_io(XSM_DEFAULT_ARG struct domain *d, int cmd)
+static XSM_INLINE int cf_check xsm_console_io(
+    XSM_DEFAULT_ARG struct domain *d, int cmd)
 {
     XSM_ASSERT_ACTION(XSM_OTHER);
     if ( d->is_console )
@@ -253,26 +257,27 @@ static XSM_INLINE int xsm_console_io(XSM_DEFAULT_ARG struct domain *d, int cmd)
     return xsm_default_action(XSM_PRIV, d, NULL);
 }
 
-static XSM_INLINE int xsm_profile(XSM_DEFAULT_ARG struct domain *d, int op)
+static XSM_INLINE int cf_check xsm_profile(
+    XSM_DEFAULT_ARG struct domain *d, int op)
 {
     XSM_ASSERT_ACTION(XSM_HOOK);
     return xsm_default_action(action, d, NULL);
 }
 
-static XSM_INLINE int xsm_kexec(XSM_DEFAULT_VOID)
+static XSM_INLINE int cf_check xsm_kexec(XSM_DEFAULT_VOID)
 {
     XSM_ASSERT_ACTION(XSM_PRIV);
     return xsm_default_action(action, current->domain, NULL);
 }
 
-static XSM_INLINE int xsm_schedop_shutdown(
+static XSM_INLINE int cf_check xsm_schedop_shutdown(
     XSM_DEFAULT_ARG struct domain *d1, struct domain *d2)
 {
     XSM_ASSERT_ACTION(XSM_DM_PRIV);
     return xsm_default_action(action, d1, d2);
 }
 
-static XSM_INLINE int xsm_memory_pin_page(
+static XSM_INLINE int cf_check xsm_memory_pin_page(
     XSM_DEFAULT_ARG struct domain *d1, struct domain *d2,
     struct page_info *page)
 {
@@ -280,20 +285,20 @@ static XSM_INLINE int xsm_memory_pin_page(
     return xsm_default_action(action, d1, d2);
 }
 
-static XSM_INLINE int xsm_claim_pages(XSM_DEFAULT_ARG struct domain *d)
+static XSM_INLINE int cf_check xsm_claim_pages(XSM_DEFAULT_ARG struct domain *d)
 {
     XSM_ASSERT_ACTION(XSM_PRIV);
     return xsm_default_action(action, current->domain, d);
 }
 
-static XSM_INLINE int xsm_evtchn_unbound(
+static XSM_INLINE int cf_check xsm_evtchn_unbound(
     XSM_DEFAULT_ARG struct domain *d, struct evtchn *chn, domid_t id2)
 {
     XSM_ASSERT_ACTION(XSM_TARGET);
     return xsm_default_action(action, current->domain, d);
 }
 
-static XSM_INLINE int xsm_evtchn_interdomain(
+static XSM_INLINE int cf_check xsm_evtchn_interdomain(
     XSM_DEFAULT_ARG struct domain *d1, struct evtchn *chan1, struct domain *d2,
     struct evtchn *chan2)
 {
@@ -301,89 +306,94 @@ static XSM_INLINE int xsm_evtchn_interdomain(
     return xsm_default_action(action, d1, d2);
 }
 
-static XSM_INLINE void xsm_evtchn_close_post(struct evtchn *chn)
+static XSM_INLINE void cf_check xsm_evtchn_close_post(struct evtchn *chn)
 {
     return;
 }
 
-static XSM_INLINE int xsm_evtchn_send(
+static XSM_INLINE int cf_check xsm_evtchn_send(
     XSM_DEFAULT_ARG struct domain *d, struct evtchn *chn)
 {
     XSM_ASSERT_ACTION(XSM_HOOK);
     return xsm_default_action(action, d, NULL);
 }
 
-static XSM_INLINE int xsm_evtchn_status(
+static XSM_INLINE int cf_check xsm_evtchn_status(
     XSM_DEFAULT_ARG struct domain *d, struct evtchn *chn)
 {
     XSM_ASSERT_ACTION(XSM_TARGET);
     return xsm_default_action(action, current->domain, d);
 }
 
-static XSM_INLINE int xsm_evtchn_reset(
+static XSM_INLINE int cf_check xsm_evtchn_reset(
     XSM_DEFAULT_ARG struct domain *d1, struct domain *d2)
 {
     XSM_ASSERT_ACTION(XSM_TARGET);
     return xsm_default_action(action, d1, d2);
 }
 
-static XSM_INLINE int xsm_alloc_security_evtchns(
+static XSM_INLINE int cf_check xsm_alloc_security_evtchns(
     struct evtchn chn[], unsigned int nr)
 {
     return 0;
 }
 
-static XSM_INLINE void xsm_free_security_evtchns(
+static XSM_INLINE void cf_check xsm_free_security_evtchns(
     struct evtchn chn[], unsigned int nr)
 {
     return;
 }
 
-static XSM_INLINE char *xsm_show_security_evtchn(
+static XSM_INLINE char *cf_check xsm_show_security_evtchn(
     struct domain *d, const struct evtchn *chn)
 {
     return NULL;
 }
 
-static XSM_INLINE int xsm_init_hardware_domain(XSM_DEFAULT_ARG struct domain *d)
+static XSM_INLINE int cf_check xsm_init_hardware_domain(
+    XSM_DEFAULT_ARG struct domain *d)
 {
     XSM_ASSERT_ACTION(XSM_HOOK);
     return xsm_default_action(action, current->domain, d);
 }
 
-static XSM_INLINE int xsm_get_pod_target(XSM_DEFAULT_ARG struct domain *d)
+static XSM_INLINE int cf_check xsm_get_pod_target(
+    XSM_DEFAULT_ARG struct domain *d)
 {
     XSM_ASSERT_ACTION(XSM_PRIV);
     return xsm_default_action(action, current->domain, d);
 }
 
-static XSM_INLINE int xsm_set_pod_target(XSM_DEFAULT_ARG struct domain *d)
+static XSM_INLINE int cf_check xsm_set_pod_target(
+    XSM_DEFAULT_ARG struct domain *d)
 {
     XSM_ASSERT_ACTION(XSM_PRIV);
     return xsm_default_action(action, current->domain, d);
 }
 
-static XSM_INLINE int xsm_get_vnumainfo(XSM_DEFAULT_ARG struct domain *d)
+static XSM_INLINE int cf_check xsm_get_vnumainfo(
+    XSM_DEFAULT_ARG struct domain *d)
 {
     XSM_ASSERT_ACTION(XSM_TARGET);
     return xsm_default_action(action, current->domain, d);
 }
 
 #if defined(CONFIG_HAS_PASSTHROUGH) && defined(CONFIG_HAS_PCI)
-static XSM_INLINE int xsm_get_device_group(XSM_DEFAULT_ARG uint32_t machine_bdf)
+static XSM_INLINE int cf_check xsm_get_device_group(
+    XSM_DEFAULT_ARG uint32_t machine_bdf)
 {
     XSM_ASSERT_ACTION(XSM_HOOK);
     return xsm_default_action(action, current->domain, NULL);
 }
 
-static XSM_INLINE int xsm_assign_device(
+static XSM_INLINE int cf_check xsm_assign_device(
     XSM_DEFAULT_ARG struct domain *d, uint32_t machine_bdf)
 {
     XSM_ASSERT_ACTION(XSM_HOOK);
     return xsm_default_action(action, current->domain, d);
 }
 
-static XSM_INLINE int xsm_deassign_device(
+static XSM_INLINE int cf_check xsm_deassign_device(
     XSM_DEFAULT_ARG struct domain *d, uint32_t machine_bdf)
 {
     XSM_ASSERT_ACTION(XSM_HOOK);
@@ -393,14 +403,14 @@ static XSM_INLINE int xsm_deassign_device(
 #endif /* HAS_PASSTHROUGH && HAS_PCI */
 
 #if defined(CONFIG_HAS_PASSTHROUGH) && defined(CONFIG_HAS_DEVICE_TREE)
-static XSM_INLINE int xsm_assign_dtdevice(
+static XSM_INLINE int cf_check xsm_assign_dtdevice(
     XSM_DEFAULT_ARG struct domain *d, const char *dtpath)
 {
     XSM_ASSERT_ACTION(XSM_HOOK);
     return xsm_default_action(action, current->domain, d);
 }
 
-static XSM_INLINE int xsm_deassign_dtdevice(
+static XSM_INLINE int cf_check xsm_deassign_dtdevice(
     XSM_DEFAULT_ARG struct domain *d, const char *dtpath)
 {
     XSM_ASSERT_ACTION(XSM_HOOK);
@@ -409,142 +419,144 @@ static XSM_INLINE int xsm_deassign_dtdevice(
 
 #endif /* HAS_PASSTHROUGH && HAS_DEVICE_TREE */
 
-static XSM_INLINE int xsm_resource_plug_core(XSM_DEFAULT_VOID)
+static XSM_INLINE int cf_check xsm_resource_plug_core(XSM_DEFAULT_VOID)
 {
     XSM_ASSERT_ACTION(XSM_HOOK);
     return xsm_default_action(action, current->domain, NULL);
 }
 
-static XSM_INLINE int xsm_resource_unplug_core(XSM_DEFAULT_VOID)
+static XSM_INLINE int cf_check xsm_resource_unplug_core(XSM_DEFAULT_VOID)
 {
     XSM_ASSERT_ACTION(XSM_HOOK);
     return xsm_default_action(action, current->domain, NULL);
 }
 
-static XSM_INLINE int xsm_resource_plug_pci(
+static XSM_INLINE int cf_check xsm_resource_plug_pci(
     XSM_DEFAULT_ARG uint32_t machine_bdf)
 {
     XSM_ASSERT_ACTION(XSM_PRIV);
     return xsm_default_action(action, current->domain, NULL);
 }
 
-static XSM_INLINE int xsm_resource_unplug_pci(
+static XSM_INLINE int cf_check xsm_resource_unplug_pci(
     XSM_DEFAULT_ARG uint32_t machine_bdf)
 {
     XSM_ASSERT_ACTION(XSM_PRIV);
     return xsm_default_action(action, current->domain, NULL);
 }
 
-static XSM_INLINE int xsm_resource_setup_pci(
+static XSM_INLINE int cf_check xsm_resource_setup_pci(
     XSM_DEFAULT_ARG uint32_t machine_bdf)
 {
     XSM_ASSERT_ACTION(XSM_PRIV);
     return xsm_default_action(action, current->domain, NULL);
 }
 
-static XSM_INLINE int xsm_resource_setup_gsi(XSM_DEFAULT_ARG int gsi)
+static XSM_INLINE int cf_check xsm_resource_setup_gsi(XSM_DEFAULT_ARG int gsi)
 {
     XSM_ASSERT_ACTION(XSM_PRIV);
     return xsm_default_action(action, current->domain, NULL);
 }
 
-static XSM_INLINE int xsm_resource_setup_misc(XSM_DEFAULT_VOID)
+static XSM_INLINE int cf_check xsm_resource_setup_misc(XSM_DEFAULT_VOID)
 {
     XSM_ASSERT_ACTION(XSM_PRIV);
     return xsm_default_action(action, current->domain, NULL);
 }
 
-static XSM_INLINE int xsm_page_offline(XSM_DEFAULT_ARG uint32_t cmd)
+static XSM_INLINE int cf_check xsm_page_offline(XSM_DEFAULT_ARG uint32_t cmd)
 {
     XSM_ASSERT_ACTION(XSM_HOOK);
     return xsm_default_action(action, current->domain, NULL);
 }
 
-static XSM_INLINE int xsm_hypfs_op(XSM_DEFAULT_VOID)
+static XSM_INLINE int cf_check xsm_hypfs_op(XSM_DEFAULT_VOID)
 {
     XSM_ASSERT_ACTION(XSM_PRIV);
     return xsm_default_action(action, current->domain, NULL);
 }
 
-static XSM_INLINE long xsm_do_xsm_op(XEN_GUEST_HANDLE_PARAM(void) op)
+static XSM_INLINE long cf_check xsm_do_xsm_op(XEN_GUEST_HANDLE_PARAM(void) op)
 {
     return -ENOSYS;
 }
 
 #ifdef CONFIG_COMPAT
-static XSM_INLINE int xsm_do_compat_op(XEN_GUEST_HANDLE_PARAM(void) op)
+static XSM_INLINE int cf_check xsm_do_compat_op(XEN_GUEST_HANDLE_PARAM(void) op)
 {
     return -ENOSYS;
 }
 #endif
 
-static XSM_INLINE char *xsm_show_irq_sid(int irq)
+static XSM_INLINE char *cf_check xsm_show_irq_sid(int irq)
 {
     return NULL;
 }
 
-static XSM_INLINE int xsm_map_domain_pirq(XSM_DEFAULT_ARG struct domain *d)
+static XSM_INLINE int cf_check xsm_map_domain_pirq(
+    XSM_DEFAULT_ARG struct domain *d)
 {
     XSM_ASSERT_ACTION(XSM_DM_PRIV);
     return xsm_default_action(action, current->domain, d);
 }
 
-static XSM_INLINE int xsm_map_domain_irq(
+static XSM_INLINE int cf_check xsm_map_domain_irq(
     XSM_DEFAULT_ARG struct domain *d, int irq, const void *data)
 {
     XSM_ASSERT_ACTION(XSM_HOOK);
     return xsm_default_action(action, current->domain, d);
 }
 
-static XSM_INLINE int xsm_unmap_domain_pirq(XSM_DEFAULT_ARG struct domain *d)
+static XSM_INLINE int cf_check xsm_unmap_domain_pirq(
+    XSM_DEFAULT_ARG struct domain *d)
 {
     XSM_ASSERT_ACTION(XSM_DM_PRIV);
     return xsm_default_action(action, current->domain, d);
 }
 
-static XSM_INLINE int xsm_bind_pt_irq(
+static XSM_INLINE int cf_check xsm_bind_pt_irq(
     XSM_DEFAULT_ARG struct domain *d, struct xen_domctl_bind_pt_irq *bind)
 {
     XSM_ASSERT_ACTION(XSM_HOOK);
     return xsm_default_action(action, current->domain, d);
 }
 
-static XSM_INLINE int xsm_unbind_pt_irq(
+static XSM_INLINE int cf_check xsm_unbind_pt_irq(
     XSM_DEFAULT_ARG struct domain *d, struct xen_domctl_bind_pt_irq *bind)
 {
     XSM_ASSERT_ACTION(XSM_HOOK);
     return xsm_default_action(action, current->domain, d);
 }
 
-static XSM_INLINE int xsm_unmap_domain_irq(
+static XSM_INLINE int cf_check xsm_unmap_domain_irq(
     XSM_DEFAULT_ARG struct domain *d, int irq, const void *data)
 {
     XSM_ASSERT_ACTION(XSM_HOOK);
     return xsm_default_action(action, current->domain, d);
 }
 
-static XSM_INLINE int xsm_irq_permission(
+static XSM_INLINE int cf_check xsm_irq_permission(
     XSM_DEFAULT_ARG struct domain *d, int pirq, uint8_t allow)
 {
     XSM_ASSERT_ACTION(XSM_HOOK);
     return xsm_default_action(action, current->domain, d);
 }
 
-static XSM_INLINE int xsm_iomem_permission(
+static XSM_INLINE int cf_check xsm_iomem_permission(
     XSM_DEFAULT_ARG struct domain *d, uint64_t s, uint64_t e, uint8_t allow)
 {
     XSM_ASSERT_ACTION(XSM_HOOK);
     return xsm_default_action(action, current->domain, d);
 }
 
-static XSM_INLINE int xsm_iomem_mapping(
+static XSM_INLINE int cf_check xsm_iomem_mapping(
     XSM_DEFAULT_ARG struct domain *d, uint64_t s, uint64_t e, uint8_t allow)
 {
     XSM_ASSERT_ACTION(XSM_HOOK);
     return xsm_default_action(action, current->domain, d);
 }
 
-static XSM_INLINE int xsm_pci_config_permission(
+static XSM_INLINE int cf_check xsm_pci_config_permission(
     XSM_DEFAULT_ARG struct domain *d, uint32_t machine_bdf, uint16_t start,
     uint16_t end, uint8_t access)
 {
@@ -552,41 +564,42 @@ static XSM_INLINE int xsm_pci_config_permission(
     return xsm_default_action(action, current->domain, d);
 }
 
-static XSM_INLINE int xsm_add_to_physmap(
+static XSM_INLINE int cf_check xsm_add_to_physmap(
     XSM_DEFAULT_ARG struct domain *d1, struct domain *d2)
 {
     XSM_ASSERT_ACTION(XSM_TARGET);
     return xsm_default_action(action, d1, d2);
 }
 
-static XSM_INLINE int xsm_remove_from_physmap(
+static XSM_INLINE int cf_check xsm_remove_from_physmap(
     XSM_DEFAULT_ARG struct domain *d1, struct domain *d2)
 {
     XSM_ASSERT_ACTION(XSM_TARGET);
     return xsm_default_action(action, d1, d2);
 }
 
-static XSM_INLINE int xsm_map_gmfn_foreign(
+static XSM_INLINE int cf_check xsm_map_gmfn_foreign(
     XSM_DEFAULT_ARG struct domain *d, struct domain *t)
 {
     XSM_ASSERT_ACTION(XSM_TARGET);
     return xsm_default_action(action, d, t);
 }
 
-static XSM_INLINE int xsm_hvm_param(
+static XSM_INLINE int cf_check xsm_hvm_param(
     XSM_DEFAULT_ARG struct domain *d, unsigned long op)
 {
     XSM_ASSERT_ACTION(XSM_TARGET);
     return xsm_default_action(action, current->domain, d);
 }
 
-static XSM_INLINE int xsm_hvm_param_altp2mhvm(XSM_DEFAULT_ARG struct domain *d)
+static XSM_INLINE int cf_check xsm_hvm_param_altp2mhvm(
+    XSM_DEFAULT_ARG struct domain *d)
 {
     XSM_ASSERT_ACTION(XSM_PRIV);
     return xsm_default_action(action, current->domain, d);
 }
 
-static XSM_INLINE int xsm_hvm_altp2mhvm_op(
+static XSM_INLINE int cf_check xsm_hvm_altp2mhvm_op(
     XSM_DEFAULT_ARG struct domain *d, uint64_t mode, uint32_t op)
 {
     XSM_ASSERT_ACTION(XSM_OTHER);
@@ -606,7 +619,7 @@ static XSM_INLINE int xsm_hvm_altp2mhvm_op(
     }
 }
 
-static XSM_INLINE int xsm_vm_event_control(
+static XSM_INLINE int cf_check xsm_vm_event_control(
     XSM_DEFAULT_ARG struct domain *d, int mode, int op)
 {
     XSM_ASSERT_ACTION(XSM_PRIV);
@@ -614,7 +627,7 @@ static XSM_INLINE int xsm_vm_event_control(
 }
 
 #ifdef CONFIG_MEM_ACCESS
-static XSM_INLINE int xsm_mem_access(XSM_DEFAULT_ARG struct domain *d)
+static XSM_INLINE int cf_check xsm_mem_access(XSM_DEFAULT_ARG struct domain *d)
 {
     XSM_ASSERT_ACTION(XSM_DM_PRIV);
     return xsm_default_action(action, current->domain, d);
@@ -622,7 +635,7 @@ static XSM_INLINE int xsm_mem_access(XSM_DEFAULT_ARG struct domain *d)
 #endif
 
 #ifdef CONFIG_MEM_PAGING
-static XSM_INLINE int xsm_mem_paging(XSM_DEFAULT_ARG struct domain *d)
+static XSM_INLINE int cf_check xsm_mem_paging(XSM_DEFAULT_ARG struct domain *d)
 {
     XSM_ASSERT_ACTION(XSM_DM_PRIV);
     return xsm_default_action(action, current->domain, d);
@@ -630,59 +643,61 @@ static XSM_INLINE int xsm_mem_paging(XSM_DEFAULT_ARG struct domain *d)
 #endif
 
 #ifdef CONFIG_MEM_SHARING
-static XSM_INLINE int xsm_mem_sharing(XSM_DEFAULT_ARG struct domain *d)
+static XSM_INLINE int cf_check xsm_mem_sharing(XSM_DEFAULT_ARG struct domain *d)
 {
     XSM_ASSERT_ACTION(XSM_DM_PRIV);
     return xsm_default_action(action, current->domain, d);
 }
 #endif
 
-static XSM_INLINE int xsm_platform_op(XSM_DEFAULT_ARG uint32_t op)
+static XSM_INLINE int cf_check xsm_platform_op(XSM_DEFAULT_ARG uint32_t op)
 {
     XSM_ASSERT_ACTION(XSM_PRIV);
     return xsm_default_action(action, current->domain, NULL);
 }
 
 #ifdef CONFIG_X86
-static XSM_INLINE int xsm_do_mca(XSM_DEFAULT_VOID)
+static XSM_INLINE int cf_check xsm_do_mca(XSM_DEFAULT_VOID)
 {
     XSM_ASSERT_ACTION(XSM_PRIV);
     return xsm_default_action(action, current->domain, NULL);
 }
 
-static XSM_INLINE int xsm_shadow_control(
+static XSM_INLINE int cf_check xsm_shadow_control(
     XSM_DEFAULT_ARG struct domain *d, uint32_t op)
 {
     XSM_ASSERT_ACTION(XSM_HOOK);
     return xsm_default_action(action, current->domain, d);
 }
 
-static XSM_INLINE int xsm_mem_sharing_op(
+static XSM_INLINE int cf_check xsm_mem_sharing_op(
     XSM_DEFAULT_ARG struct domain *d, struct domain *cd, int op)
 {
     XSM_ASSERT_ACTION(XSM_DM_PRIV);
     return xsm_default_action(action, current->domain, cd);
 }
 
-static XSM_INLINE int xsm_apic(XSM_DEFAULT_ARG struct domain *d, int cmd)
+static XSM_INLINE int cf_check xsm_apic(
+    XSM_DEFAULT_ARG struct domain *d, int cmd)
 {
     XSM_ASSERT_ACTION(XSM_PRIV);
     return xsm_default_action(action, d, NULL);
 }
 
-static XSM_INLINE int xsm_machine_memory_map(XSM_DEFAULT_VOID)
+static XSM_INLINE int cf_check xsm_machine_memory_map(XSM_DEFAULT_VOID)
 {
     XSM_ASSERT_ACTION(XSM_PRIV);
     return xsm_default_action(action, current->domain, NULL);
 }
 
-static XSM_INLINE int xsm_domain_memory_map(XSM_DEFAULT_ARG struct domain *d)
+static XSM_INLINE int cf_check xsm_domain_memory_map(
+    XSM_DEFAULT_ARG struct domain *d)
 {
     XSM_ASSERT_ACTION(XSM_TARGET);
     return xsm_default_action(action, current->domain, d);
 }
 
-static XSM_INLINE int xsm_mmu_update(
+static XSM_INLINE int cf_check xsm_mmu_update(
     XSM_DEFAULT_ARG struct domain *d, struct domain *t, struct domain *f,
     uint32_t flags)
 {
@@ -695,42 +710,42 @@ static XSM_INLINE int xsm_mmu_update(
     return rc;
 }
 
-static XSM_INLINE int xsm_mmuext_op(
+static XSM_INLINE int cf_check xsm_mmuext_op(
     XSM_DEFAULT_ARG struct domain *d, struct domain *f)
 {
     XSM_ASSERT_ACTION(XSM_TARGET);
     return xsm_default_action(action, d, f);
 }
 
-static XSM_INLINE int xsm_update_va_mapping(
+static XSM_INLINE int cf_check xsm_update_va_mapping(
     XSM_DEFAULT_ARG struct domain *d, struct domain *f, l1_pgentry_t pte)
 {
     XSM_ASSERT_ACTION(XSM_TARGET);
     return xsm_default_action(action, d, f);
 }
 
-static XSM_INLINE int xsm_priv_mapping(
+static XSM_INLINE int cf_check xsm_priv_mapping(
     XSM_DEFAULT_ARG struct domain *d, struct domain *t)
 {
     XSM_ASSERT_ACTION(XSM_TARGET);
     return xsm_default_action(action, d, t);
 }
 
-static XSM_INLINE int xsm_ioport_permission(
+static XSM_INLINE int cf_check xsm_ioport_permission(
     XSM_DEFAULT_ARG struct domain *d, uint32_t s, uint32_t e, uint8_t allow)
 {
     XSM_ASSERT_ACTION(XSM_HOOK);
     return xsm_default_action(action, current->domain, d);
 }
 
-static XSM_INLINE int xsm_ioport_mapping(
+static XSM_INLINE int cf_check xsm_ioport_mapping(
     XSM_DEFAULT_ARG struct domain *d, uint32_t s, uint32_t e, uint8_t allow)
 {
     XSM_ASSERT_ACTION(XSM_HOOK);
     return xsm_default_action(action, current->domain, d);
 }
 
-static XSM_INLINE int xsm_pmu_op(
+static XSM_INLINE int cf_check xsm_pmu_op(
     XSM_DEFAULT_ARG struct domain *d, unsigned int op)
 {
     XSM_ASSERT_ACTION(XSM_OTHER);
@@ -748,30 +763,31 @@ static XSM_INLINE int xsm_pmu_op(
 
 #endif /* CONFIG_X86 */
 
-static XSM_INLINE int xsm_dm_op(XSM_DEFAULT_ARG struct domain *d)
+static XSM_INLINE int cf_check xsm_dm_op(XSM_DEFAULT_ARG struct domain *d)
 {
     XSM_ASSERT_ACTION(XSM_DM_PRIV);
     return xsm_default_action(action, current->domain, d);
 }
 
 #ifdef CONFIG_ARGO
-static XSM_INLINE int xsm_argo_enable(const struct domain *d)
+static XSM_INLINE int cf_check xsm_argo_enable(const struct domain *d)
 {
     return 0;
 }
 
-static XSM_INLINE int xsm_argo_register_single_source(
+static XSM_INLINE int cf_check xsm_argo_register_single_source(
     const struct domain *d, const struct domain *t)
 {
     return 0;
 }
 
-static XSM_INLINE int xsm_argo_register_any_source(const struct domain *d)
+static XSM_INLINE int cf_check xsm_argo_register_any_source(
+    const struct domain *d)
 {
     return 0;
 }
 
-static XSM_INLINE int xsm_argo_send(
+static XSM_INLINE int cf_check xsm_argo_send(
     const struct domain *d, const struct domain *t)
 {
     return 0;
@@ -780,7 +796,7 @@ static XSM_INLINE int xsm_argo_send(
 #endif /* CONFIG_ARGO */
 
 #include <public/version.h>
-static XSM_INLINE int xsm_xen_version(XSM_DEFAULT_ARG uint32_t op)
+static XSM_INLINE int cf_check xsm_xen_version(XSM_DEFAULT_ARG uint32_t op)
 {
     XSM_ASSERT_ACTION(XSM_OTHER);
     switch ( op )
@@ -804,7 +820,8 @@ static XSM_INLINE int xsm_xen_version(XSM_DEFAULT_ARG uint32_t op)
     }
 }
 
-static XSM_INLINE int xsm_domain_resource_map(XSM_DEFAULT_ARG struct domain *d)
+static XSM_INLINE int cf_check xsm_domain_resource_map(
+    XSM_DEFAULT_ARG struct domain *d)
 {
     XSM_ASSERT_ACTION(XSM_DM_PRIV);
     return xsm_default_action(action, current->domain, d);
diff --git a/xen/xsm/flask/flask_op.c b/xen/xsm/flask/flask_op.c
index 2d7ca3abaecd..707be72a3b96 100644
--- a/xen/xsm/flask/flask_op.c
+++ b/xen/xsm/flask/flask_op.c
@@ -607,7 +607,7 @@ static int flask_relabel_domain(struct xen_flask_relabel *arg)
 
 #endif /* !COMPAT */
 
-ret_t do_flask_op(XEN_GUEST_HANDLE_PARAM(void) u_flask_op)
+ret_t cf_check do_flask_op(XEN_GUEST_HANDLE_PARAM(void) u_flask_op)
 {
     xen_flask_op_t op;
     int rv;
diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c
index 6ff1be28e4a4..63484e323c09 100644
--- a/xen/xsm/flask/hooks.c
+++ b/xen/xsm/flask/hooks.c
@@ -157,7 +157,7 @@ static int avc_unknown_permission(const char *name, int id)
     return rc;
 }
 
-static int flask_domain_alloc_security(struct domain *d)
+static int cf_check flask_domain_alloc_security(struct domain *d)
 {
     struct domain_security_struct *dsec;
 
@@ -186,7 +186,7 @@ static int flask_domain_alloc_security(struct domain *d)
     return 0;
 }
 
-static void flask_domain_free_security(struct domain *d)
+static void cf_check flask_domain_free_security(struct domain *d)
 {
     struct domain_security_struct *dsec = d->ssid;
 
@@ -197,8 +197,8 @@ static void flask_domain_free_security(struct domain *d)
     xfree(dsec);
 }
 
-static int flask_evtchn_unbound(struct domain *d1, struct evtchn *chn, 
-                                domid_t id2)
+static int cf_check flask_evtchn_unbound(
+    struct domain *d1, struct evtchn *chn, domid_t id2)
 {
     u32 sid1, sid2, newsid;
     int rc;
@@ -230,8 +230,9 @@ static int flask_evtchn_unbound(struct domain *d1, struct evtchn *chn,
     return rc;
 }
 
-static int flask_evtchn_interdomain(struct domain *d1, struct evtchn *chn1, 
-                                    struct domain *d2, struct evtchn *chn2)
+static int cf_check flask_evtchn_interdomain(
+    struct domain *d1, struct evtchn *chn1,
+    struct domain *d2, struct evtchn *chn2)
 {
     u32 sid1, sid2, newsid, reverse_sid;
     int rc;
@@ -273,12 +274,12 @@ static int flask_evtchn_interdomain(struct domain *d1, struct evtchn *chn1,
     return rc;
 }
 
-static void flask_evtchn_close_post(struct evtchn *chn)
+static void cf_check flask_evtchn_close_post(struct evtchn *chn)
 {
     chn->ssid.flask_sid = SECINITSID_UNLABELED;
 }
 
-static int flask_evtchn_send(struct domain *d, struct evtchn *chn)
+static int cf_check flask_evtchn_send(struct domain *d, struct evtchn *chn)
 {
     int rc;
 
@@ -298,17 +299,18 @@ static int flask_evtchn_send(struct domain *d, struct evtchn *chn)
     return rc;
 }
 
-static int flask_evtchn_status(struct domain *d, struct evtchn *chn)
+static int cf_check flask_evtchn_status(struct domain *d, struct evtchn *chn)
 {
     return domain_has_evtchn(d, chn, EVENT__STATUS);
 }
 
-static int flask_evtchn_reset(struct domain *d1, struct domain *d2)
+static int cf_check flask_evtchn_reset(struct domain *d1, struct domain *d2)
 {
     return domain_has_perm(d1, d2, SECCLASS_EVENT, EVENT__RESET);
 }
 
-static int flask_alloc_security_evtchns(struct evtchn chn[], unsigned int nr)
+static int cf_check flask_alloc_security_evtchns(
+    struct evtchn chn[], unsigned int nr)
 {
     unsigned int i;
 
@@ -318,7 +320,8 @@ static int flask_alloc_security_evtchns(struct evtchn chn[], unsigned int nr)
     return 0;
 }
 
-static void flask_free_security_evtchns(struct evtchn chn[], unsigned int nr)
+static void cf_check flask_free_security_evtchns(
+    struct evtchn chn[], unsigned int nr)
 {
     unsigned int i;
 
@@ -329,7 +332,8 @@ static void flask_free_security_evtchns(struct evtchn chn[], unsigned int nr)
         chn[i].ssid.flask_sid = SECINITSID_UNLABELED;
 }
 
-static char *flask_show_security_evtchn(struct domain *d, const struct evtchn *chn)
+static char *cf_check flask_show_security_evtchn(
+    struct domain *d, const struct evtchn *chn)
 {
     int irq;
     u32 sid = 0;
@@ -355,13 +359,13 @@ static char *flask_show_security_evtchn(struct domain *d, const struct evtchn *c
     return ctx;
 }
 
-static int flask_init_hardware_domain(struct domain *d)
+static int cf_check flask_init_hardware_domain(struct domain *d)
 {
     return current_has_perm(d, SECCLASS_DOMAIN2, DOMAIN2__CREATE_HARDWARE_DOMAIN);
 }
 
-static int flask_grant_mapref(struct domain *d1, struct domain *d2, 
-                              uint32_t flags)
+static int cf_check flask_grant_mapref(
+    struct domain *d1, struct domain *d2, uint32_t flags)
 {
     u32 perms = GRANT__MAP_READ;
 
@@ -371,73 +375,75 @@ static int flask_grant_mapref(struct domain *d1, struct domain *d2,
     return domain_has_perm(d1, d2, SECCLASS_GRANT, perms);
 }
 
-static int flask_grant_unmapref(struct domain *d1, struct domain *d2)
+static int cf_check flask_grant_unmapref(struct domain *d1, struct domain *d2)
 {
     return domain_has_perm(d1, d2, SECCLASS_GRANT, GRANT__UNMAP);
 }
 
-static int flask_grant_setup(struct domain *d1, struct domain *d2)
+static int cf_check flask_grant_setup(struct domain *d1, struct domain *d2)
 {
     return domain_has_perm(d1, d2, SECCLASS_GRANT, GRANT__SETUP);
 }
 
-static int flask_grant_transfer(struct domain *d1, struct domain *d2)
+static int cf_check flask_grant_transfer(struct domain *d1, struct domain *d2)
 {
     return domain_has_perm(d1, d2, SECCLASS_GRANT, GRANT__TRANSFER);
 }
 
-static int flask_grant_copy(struct domain *d1, struct domain *d2)
+static int cf_check flask_grant_copy(struct domain *d1, struct domain *d2)
 {
     return domain_has_perm(d1, d2, SECCLASS_GRANT, GRANT__COPY);
 }
 
-static int flask_grant_query_size(struct domain *d1, struct domain *d2)
+static int cf_check flask_grant_query_size(struct domain *d1, struct domain *d2)
 {
     return domain_has_perm(d1, d2, SECCLASS_GRANT, GRANT__QUERY);
 }
 
-static int flask_get_pod_target(struct domain *d)
+static int cf_check flask_get_pod_target(struct domain *d)
 {
     return current_has_perm(d, SECCLASS_DOMAIN, DOMAIN__GETPODTARGET);
 }
 
-static int flask_set_pod_target(struct domain *d)
+static int cf_check flask_set_pod_target(struct domain *d)
 {
     return current_has_perm(d, SECCLASS_DOMAIN, DOMAIN__SETPODTARGET);
 }
 
-static int flask_memory_exchange(struct domain *d)
+static int cf_check flask_memory_exchange(struct domain *d)
 {
     return current_has_perm(d, SECCLASS_MMU, MMU__EXCHANGE);
 }
 
-static int flask_memory_adjust_reservation(struct domain *d1, struct domain *d2)
+static int cf_check flask_memory_adjust_reservation(
+    struct domain *d1, struct domain *d2)
 {
     return domain_has_perm(d1, d2, SECCLASS_MMU, MMU__ADJUST);
 }
 
-static int flask_memory_stat_reservation(struct domain *d1, struct domain *d2)
+static int cf_check flask_memory_stat_reservation(
+    struct domain *d1, struct domain *d2)
 {
     return domain_has_perm(d1, d2, SECCLASS_MMU, MMU__STAT);
 }
 
-static int flask_memory_pin_page(struct domain *d1, struct domain *d2,
-                                 struct page_info *page)
+static int cf_check flask_memory_pin_page(
+    struct domain *d1, struct domain *d2, struct page_info *page)
 {
     return domain_has_perm(d1, d2, SECCLASS_MMU, MMU__PINPAGE);
 }
 
-static int flask_claim_pages(struct domain *d)
+static int cf_check flask_claim_pages(struct domain *d)
 {
     return current_has_perm(d, SECCLASS_DOMAIN2, DOMAIN2__SETCLAIM);
 }
 
-static int flask_get_vnumainfo(struct domain *d)
+static int cf_check flask_get_vnumainfo(struct domain *d)
 {
     return current_has_perm(d, SECCLASS_DOMAIN2, DOMAIN2__GET_VNUMAINFO);
 }
 
-static int flask_console_io(struct domain *d, int cmd)
+static int cf_check flask_console_io(struct domain *d, int cmd)
 {
     u32 perm;
 
@@ -456,7 +462,7 @@ static int flask_console_io(struct domain *d, int cmd)
     return domain_has_xen(d, perm);
 }
 
-static int flask_profile(struct domain *d, int op)
+static int cf_check flask_profile(struct domain *d, int op)
 {
     u32 perm;
 
@@ -488,23 +494,23 @@ static int flask_profile(struct domain *d, int op)
     return domain_has_xen(d, perm);
 }
 
-static int flask_kexec(void)
+static int cf_check flask_kexec(void)
 {
     return domain_has_xen(current->domain, XEN__KEXEC);
 }
 
-static int flask_schedop_shutdown(struct domain *d1, struct domain *d2)
+static int cf_check flask_schedop_shutdown(struct domain *d1, struct domain *d2)
 {
     return domain_has_perm(d1, d2, SECCLASS_DOMAIN, DOMAIN__SHUTDOWN);
 }
 
-static void flask_security_domaininfo(struct domain *d, 
-                                      struct xen_domctl_getdomaininfo *info)
+static void cf_check flask_security_domaininfo(
+    struct domain *d, struct xen_domctl_getdomaininfo *info)
 {
     info->ssidref = domain_sid(d);
 }
 
-static int flask_domain_create(struct domain *d, u32 ssidref)
+static int cf_check flask_domain_create(struct domain *d, u32 ssidref)
 {
     int rc;
     struct domain_security_struct *dsec = d->ssid;
@@ -532,12 +538,12 @@ static int flask_domain_create(struct domain *d, u32 ssidref)
     return rc;
 }
 
-static int flask_getdomaininfo(struct domain *d)
+static int cf_check flask_getdomaininfo(struct domain *d)
 {
     return current_has_perm(d, SECCLASS_DOMAIN, DOMAIN__GETDOMAININFO);
 }
 
-static int flask_domctl_scheduler_op(struct domain *d, int op)
+static int cf_check flask_domctl_scheduler_op(struct domain *d, int op)
 {
     switch ( op )
     {
@@ -554,7 +560,7 @@ static int flask_domctl_scheduler_op(struct domain *d, int op)
     }
 }
 
-static int flask_sysctl_scheduler_op(int op)
+static int cf_check flask_sysctl_scheduler_op(int op)
 {
     switch ( op )
     {
@@ -569,7 +575,7 @@ static int flask_sysctl_scheduler_op(int op)
     }
 }
 
-static int flask_set_target(struct domain *d, struct domain *t)
+static int cf_check flask_set_target(struct domain *d, struct domain *t)
 {
     int rc;
     struct domain_security_struct *dsec, *tsec;
@@ -593,7 +599,7 @@ static int flask_set_target(struct domain *d, struct domain *t)
     return rc;
 }
 
-static int flask_domctl(struct domain *d, int cmd)
+static int cf_check flask_domctl(struct domain *d, int cmd)
 {
     switch ( cmd )
     {
@@ -757,7 +763,7 @@ static int flask_domctl(struct domain *d, int cmd)
     }
 }
 
-static int flask_sysctl(int cmd)
+static int cf_check flask_sysctl(int cmd)
 {
     switch ( cmd )
     {
@@ -835,7 +841,7 @@ static int flask_sysctl(int cmd)
     }
 }
 
-static int flask_readconsole(uint32_t clear)
+static int cf_check flask_readconsole(uint32_t clear)
 {
     u32 perms = XEN__READCONSOLE;
 
@@ -853,7 +859,7 @@ static inline u32 resource_to_perm(uint8_t access)
         return RESOURCE__REMOVE;
 }
 
-static char *flask_show_irq_sid (int irq)
+static char *cf_check flask_show_irq_sid(int irq)
 {
     u32 sid, ctx_len;
     char *ctx;
@@ -867,7 +873,7 @@ static char *flask_show_irq_sid (int irq)
     return ctx;
 }
 
-static int flask_map_domain_pirq (struct domain *d)
+static int cf_check flask_map_domain_pirq(struct domain *d)
 {
     return current_has_perm(d, SECCLASS_RESOURCE, RESOURCE__ADD);
 }
@@ -907,7 +913,7 @@ static u32 flask_iommu_resource_use_perm(const struct domain *d)
     return perm;
 }
 
-static int flask_map_domain_irq (struct domain *d, int irq, const void *data)
+static int cf_check flask_map_domain_irq(struct domain *d, int irq, const void *data)
 {
     u32 sid, dsid;
     int rc = -EPERM;
@@ -933,7 +939,7 @@ static int flask_map_domain_irq (struct domain *d, int irq, const void *data)
     return rc;
 }
 
-static int flask_unmap_domain_pirq (struct domain *d)
+static int cf_check flask_unmap_domain_pirq(struct domain *d)
 {
     return current_has_perm(d, SECCLASS_RESOURCE, RESOURCE__REMOVE);
 }
@@ -954,7 +960,8 @@ static int flask_unmap_domain_msi (struct domain *d, int irq, const void *data,
 #endif
 }
 
-static int flask_unmap_domain_irq (struct domain *d, int irq, const void *data)
+static int cf_check flask_unmap_domain_irq(
+    struct domain *d, int irq, const void *data)
 {
     u32 sid;
     int rc = -EPERM;
@@ -972,7 +979,8 @@ static int flask_unmap_domain_irq (struct domain *d, int irq, const void *data)
     return rc;
 }
 
-static int flask_bind_pt_irq (struct domain *d, struct xen_domctl_bind_pt_irq *bind)
+static int cf_check flask_bind_pt_irq(
+    struct domain *d, struct xen_domctl_bind_pt_irq *bind)
 {
     u32 dsid, rsid;
     int rc = -EPERM;
@@ -998,12 +1006,14 @@ static int flask_bind_pt_irq (struct domain *d, struct xen_domctl_bind_pt_irq *b
     return avc_has_perm(dsid, rsid, SECCLASS_RESOURCE, dperm, &ad);
 }
 
-static int flask_unbind_pt_irq (struct domain *d, struct xen_domctl_bind_pt_irq *bind)
+static int cf_check flask_unbind_pt_irq(
+    struct domain *d, struct xen_domctl_bind_pt_irq *bind)
 {
     return current_has_perm(d, SECCLASS_RESOURCE, RESOURCE__REMOVE);
 }
 
-static int flask_irq_permission (struct domain *d, int pirq, uint8_t access)
+static int cf_check flask_irq_permission(
+    struct domain *d, int pirq, uint8_t access)
 {
     /* the PIRQ number is not useful; real IRQ is checked during mapping */
     return current_has_perm(d, SECCLASS_RESOURCE, resource_to_perm(access));
@@ -1016,7 +1026,8 @@ struct iomem_has_perm_data {
     u32 use_perm;
 };
 
-static int _iomem_has_perm(void *v, u32 sid, unsigned long start, unsigned long end)
+static int cf_check _iomem_has_perm(
+    void *v, u32 sid, unsigned long start, unsigned long end)
 {
     struct iomem_has_perm_data *data = v;
     struct avc_audit_data ad;
@@ -1034,7 +1045,8 @@ static int _iomem_has_perm(void *v, u32 sid, unsigned long start, unsigned long
     return avc_has_perm(data->dsid, sid, SECCLASS_RESOURCE, data->use_perm, &ad);
 }
 
-static int flask_iomem_permission(struct domain *d, uint64_t start, uint64_t end, uint8_t access)
+static int cf_check flask_iomem_permission(
+    struct domain *d, uint64_t start, uint64_t end, uint8_t access)
 {
     struct iomem_has_perm_data data;
     int rc;
@@ -1056,12 +1068,14 @@ static int flask_iomem_permission(struct domain *d, uint64_t start, uint64_t end
     return security_iterate_iomem_sids(start, end, _iomem_has_perm, &data);
 }
 
-static int flask_iomem_mapping(struct domain *d, uint64_t start, uint64_t end, uint8_t access)
+static int cf_check flask_iomem_mapping(struct domain *d, uint64_t start, uint64_t end, uint8_t access)
 {
     return flask_iomem_permission(d, start, end, access);
 }
 
-static int flask_pci_config_permission(struct domain *d, uint32_t machine_bdf, uint16_t start, uint16_t end, uint8_t access)
+static int cf_check flask_pci_config_permission(
+    struct domain *d, uint32_t machine_bdf, uint16_t start, uint16_t end,
+    uint8_t access)
 {
     u32 dsid, rsid;
     int rc = -EPERM;
@@ -1085,12 +1099,12 @@ static int flask_pci_config_permission(struct domain *d, uint32_t machine_bdf, u
 
 }
 
-static int flask_resource_plug_core(void)
+static int cf_check flask_resource_plug_core(void)
 {
     return avc_current_has_perm(SECINITSID_DOMXEN, SECCLASS_RESOURCE, RESOURCE__PLUG, NULL);
 }
 
-static int flask_resource_unplug_core(void)
+static int cf_check flask_resource_unplug_core(void)
 {
     return avc_current_has_perm(SECINITSID_DOMXEN, SECCLASS_RESOURCE, RESOURCE__UNPLUG, NULL);
 }
@@ -1100,7 +1114,7 @@ static int flask_resource_use_core(void)
     return avc_current_has_perm(SECINITSID_DOMXEN, SECCLASS_RESOURCE, RESOURCE__USE, NULL);
 }
 
-static int flask_resource_plug_pci(uint32_t machine_bdf)
+static int cf_check flask_resource_plug_pci(uint32_t machine_bdf)
 {
     u32 rsid;
     int rc = -EPERM;
@@ -1115,7 +1129,7 @@ static int flask_resource_plug_pci(uint32_t machine_bdf)
     return avc_current_has_perm(rsid, SECCLASS_RESOURCE, RESOURCE__PLUG, &ad);
 }
 
-static int flask_resource_unplug_pci(uint32_t machine_bdf)
+static int cf_check flask_resource_unplug_pci(uint32_t machine_bdf)
 {
     u32 rsid;
     int rc = -EPERM;
@@ -1130,7 +1144,7 @@ static int flask_resource_unplug_pci(uint32_t machine_bdf)
     return avc_current_has_perm(rsid, SECCLASS_RESOURCE, RESOURCE__UNPLUG, &ad);
 }
 
-static int flask_resource_setup_pci(uint32_t machine_bdf)
+static int cf_check flask_resource_setup_pci(uint32_t machine_bdf)
 {
     u32 rsid;
     int rc = -EPERM;
@@ -1145,7 +1159,7 @@ static int flask_resource_setup_pci(uint32_t machine_bdf)
     return avc_current_has_perm(rsid, SECCLASS_RESOURCE, RESOURCE__SETUP, &ad);
 }
 
-static int flask_resource_setup_gsi(int gsi)
+static int cf_check flask_resource_setup_gsi(int gsi)
 {
     u32 rsid;
     int rc = -EPERM;
@@ -1158,12 +1172,12 @@ static int flask_resource_setup_gsi(int gsi)
     return avc_current_has_perm(rsid, SECCLASS_RESOURCE, RESOURCE__SETUP, &ad);
 }
 
-static int flask_resource_setup_misc(void)
+static int cf_check flask_resource_setup_misc(void)
 {
     return avc_current_has_perm(SECINITSID_XEN, SECCLASS_RESOURCE, RESOURCE__SETUP, NULL);
 }
 
-static inline int flask_page_offline(uint32_t cmd)
+static inline int cf_check flask_page_offline(uint32_t cmd)
 {
     switch (cmd) {
     case sysctl_page_offline:
@@ -1177,27 +1191,28 @@ static inline int flask_page_offline(uint32_t cmd)
     }
 }
 
-static inline int flask_hypfs_op(void)
+static inline int cf_check flask_hypfs_op(void)
 {
     return domain_has_xen(current->domain, XEN__HYPFS_OP);
 }
 
-static int flask_add_to_physmap(struct domain *d1, struct domain *d2)
+static int cf_check flask_add_to_physmap(struct domain *d1, struct domain *d2)
 {
     return domain_has_perm(d1, d2, SECCLASS_MMU, MMU__PHYSMAP);
 }
 
-static int flask_remove_from_physmap(struct domain *d1, struct domain *d2)
+static int cf_check flask_remove_from_physmap(
+    struct domain *d1, struct domain *d2)
 {
     return domain_has_perm(d1, d2, SECCLASS_MMU, MMU__PHYSMAP);
 }
 
-static int flask_map_gmfn_foreign(struct domain *d, struct domain *t)
+static int cf_check flask_map_gmfn_foreign(struct domain *d, struct domain *t)
 {
     return domain_has_perm(d, t, SECCLASS_MMU, MMU__MAP_READ | MMU__MAP_WRITE);
 }
 
-static int flask_hvm_param(struct domain *d, unsigned long op)
+static int cf_check flask_hvm_param(struct domain *d, unsigned long op)
 {
     u32 perm;
 
@@ -1216,12 +1231,12 @@ static int flask_hvm_param(struct domain *d, unsigned long op)
     return current_has_perm(d, SECCLASS_HVM, perm);
 }
 
-static int flask_hvm_param_altp2mhvm(struct domain *d)
+static int cf_check flask_hvm_param_altp2mhvm(struct domain *d)
 {
     return current_has_perm(d, SECCLASS_HVM, HVM__ALTP2MHVM);
 }
 
-static int flask_hvm_altp2mhvm_op(struct domain *d, uint64_t mode, uint32_t op)
+static int cf_check flask_hvm_altp2mhvm_op(struct domain *d, uint64_t mode, uint32_t op)
 {
     /*
      * Require both mode and XSM to allow the operation. Assume XSM rules
@@ -1245,34 +1260,34 @@ static int flask_hvm_altp2mhvm_op(struct domain *d, uint64_t mode, uint32_t op)
     return current_has_perm(d, SECCLASS_HVM, HVM__ALTP2MHVM_OP);
 }
 
-static int flask_vm_event_control(struct domain *d, int mode, int op)
+static int cf_check flask_vm_event_control(struct domain *d, int mode, int op)
 {
     return current_has_perm(d, SECCLASS_DOMAIN2, DOMAIN2__VM_EVENT);
 }
 
 #ifdef CONFIG_MEM_ACCESS
-static int flask_mem_access(struct domain *d)
+static int cf_check flask_mem_access(struct domain *d)
 {
     return current_has_perm(d, SECCLASS_DOMAIN2, DOMAIN2__MEM_ACCESS);
 }
 #endif
 
 #ifdef CONFIG_MEM_PAGING
-static int flask_mem_paging(struct domain *d)
+static int cf_check flask_mem_paging(struct domain *d)
 {
     return current_has_perm(d, SECCLASS_DOMAIN2, DOMAIN2__MEM_PAGING);
 }
 #endif
 
 #ifdef CONFIG_MEM_SHARING
-static int flask_mem_sharing(struct domain *d)
+static int cf_check flask_mem_sharing(struct domain *d)
 {
     return current_has_perm(d, SECCLASS_DOMAIN2, DOMAIN2__MEM_SHARING);
 }
 #endif
 
 #if defined(CONFIG_HAS_PASSTHROUGH) && defined(CONFIG_HAS_PCI)
-static int flask_get_device_group(uint32_t machine_bdf)
+static int cf_check flask_get_device_group(uint32_t machine_bdf)
 {
     u32 rsid;
     int rc = -EPERM;
@@ -1296,7 +1311,7 @@ static int flask_test_assign_device(uint32_t machine_bdf)
     return avc_current_has_perm(rsid, SECCLASS_RESOURCE, RESOURCE__STAT_DEVICE, NULL);
 }
 
-static int flask_assign_device(struct domain *d, uint32_t machine_bdf)
+static int cf_check flask_assign_device(struct domain *d, uint32_t machine_bdf)
 {
     u32 dsid, rsid;
     int rc = -EPERM;
@@ -1326,7 +1341,8 @@ static int flask_assign_device(struct domain *d, uint32_t machine_bdf)
     return avc_has_perm(dsid, rsid, SECCLASS_RESOURCE, dperm, &ad);
 }
 
-static int flask_deassign_device(struct domain *d, uint32_t machine_bdf)
+static int cf_check flask_deassign_device(
+    struct domain *d, uint32_t machine_bdf)
 {
     u32 rsid;
     int rc = -EPERM;
@@ -1357,7 +1373,7 @@ static int flask_test_assign_dtdevice(const char *dtpath)
                                 NULL);
 }
 
-static int flask_assign_dtdevice(struct domain *d, const char *dtpath)
+static int cf_check flask_assign_dtdevice(struct domain *d, const char *dtpath)
 {
     u32 dsid, rsid;
     int rc = -EPERM;
@@ -1387,7 +1403,8 @@ static int flask_assign_dtdevice(struct domain *d, const char *dtpath)
     return avc_has_perm(dsid, rsid, SECCLASS_RESOURCE, dperm, &ad);
 }
 
-static int flask_deassign_dtdevice(struct domain *d, const char *dtpath)
+static int cf_check flask_deassign_dtdevice(
+    struct domain *d, const char *dtpath)
 {
     u32 rsid;
     int rc = -EPERM;
@@ -1405,7 +1422,7 @@ static int flask_deassign_dtdevice(struct domain *d, const char *dtpath)
 }
 #endif /* HAS_PASSTHROUGH && HAS_DEVICE_TREE */
 
-static int flask_platform_op(uint32_t op)
+static int cf_check flask_platform_op(uint32_t op)
 {
     switch ( op )
     {
@@ -1474,12 +1491,12 @@ static int flask_platform_op(uint32_t op)
 }
 
 #ifdef CONFIG_X86
-static int flask_do_mca(void)
+static int cf_check flask_do_mca(void)
 {
     return domain_has_xen(current->domain, XEN__MCA_OP);
 }
 
-static int flask_shadow_control(struct domain *d, uint32_t op)
+static int cf_check flask_shadow_control(struct domain *d, uint32_t op)
 {
     u32 perm;
 
@@ -1513,7 +1530,8 @@ struct ioport_has_perm_data {
     u32 use_perm;
 };
 
-static int _ioport_has_perm(void *v, u32 sid, unsigned long start, unsigned long end)
+static int cf_check _ioport_has_perm(
+    void *v, u32 sid, unsigned long start, unsigned long end)
 {
     struct ioport_has_perm_data *data = v;
     struct avc_audit_data ad;
@@ -1531,7 +1549,8 @@ static int _ioport_has_perm(void *v, u32 sid, unsigned long start, unsigned long
     return avc_has_perm(data->dsid, sid, SECCLASS_RESOURCE, data->use_perm, &ad);
 }
 
-static int flask_ioport_permission(struct domain *d, uint32_t start, uint32_t end, uint8_t access)
+static int cf_check flask_ioport_permission(
+    struct domain *d, uint32_t start, uint32_t end, uint8_t access)
 {
     int rc;
     struct ioport_has_perm_data data;
@@ -1554,12 +1573,14 @@ static int flask_ioport_permission(struct domain *d, uint32_t start, uint32_t en
     return security_iterate_ioport_sids(start, end, _ioport_has_perm, &data);
 }
 
-static int flask_ioport_mapping(struct domain *d, uint32_t start, uint32_t end, uint8_t access)
+static int cf_check flask_ioport_mapping(
+    struct domain *d, uint32_t start, uint32_t end, uint8_t access)
 {
     return flask_ioport_permission(d, start, end, access);
 }
 
-static int flask_mem_sharing_op(struct domain *d, struct domain *cd, int op)
+static int cf_check flask_mem_sharing_op(
+    struct domain *d, struct domain *cd, int op)
 {
     int rc = current_has_perm(cd, SECCLASS_HVM, HVM__MEM_SHARING);
     if ( rc )
@@ -1567,7 +1588,7 @@ static int flask_mem_sharing_op(struct domain *d, struct domain *cd, int op)
     return domain_has_perm(d, cd, SECCLASS_HVM, HVM__SHARE_MEM);
 }
 
-static int flask_apic(struct domain *d, int cmd)
+static int cf_check flask_apic(struct domain *d, int cmd)
 {
     u32 perm;
 
@@ -1587,18 +1608,18 @@ static int flask_apic(struct domain *d, int cmd)
     return domain_has_xen(d, perm);
 }
 
-static int flask_machine_memory_map(void)
+static int cf_check flask_machine_memory_map(void)
 {
     return avc_current_has_perm(SECINITSID_XEN, SECCLASS_MMU, MMU__MEMORYMAP, NULL);
 }
 
-static int flask_domain_memory_map(struct domain *d)
+static int cf_check flask_domain_memory_map(struct domain *d)
 {
     return current_has_perm(d, SECCLASS_MMU, MMU__MEMORYMAP);
 }
 
-static int flask_mmu_update(struct domain *d, struct domain *t,
-                            struct domain *f, uint32_t flags)
+static int cf_check flask_mmu_update(
+    struct domain *d, struct domain *t, struct domain *f, uint32_t flags)
 {
     int rc = 0;
     u32 map_perms = 0;
@@ -1620,13 +1641,13 @@ static int flask_mmu_update(struct domain *d, struct domain *t,
     return rc;
 }
 
-static int flask_mmuext_op(struct domain *d, struct domain *f)
+static int cf_check flask_mmuext_op(struct domain *d, struct domain *f)
 {
     return domain_has_perm(d, f, SECCLASS_MMU, MMU__MMUEXT_OP);
 }
 
-static int flask_update_va_mapping(struct domain *d, struct domain *f,
-                                   l1_pgentry_t pte)
+static int cf_check flask_update_va_mapping(
+    struct domain *d, struct domain *f, l1_pgentry_t pte)
 {
     u32 map_perms = MMU__MAP_READ;
     if ( !(l1e_get_flags(pte) & _PAGE_PRESENT) )
@@ -1637,12 +1658,12 @@ static int flask_update_va_mapping(struct domain *d, struct domain *f,
     return domain_has_perm(d, f, SECCLASS_MMU, map_perms);
 }
 
-static int flask_priv_mapping(struct domain *d, struct domain *t)
+static int cf_check flask_priv_mapping(struct domain *d, struct domain *t)
 {
     return domain_has_perm(d, t, SECCLASS_MMU, MMU__TARGET_HACK);
 }
 
-static int flask_pmu_op (struct domain *d, unsigned int op)
+static int cf_check flask_pmu_op(struct domain *d, unsigned int op)
 {
     u32 dsid = domain_sid(d);
 
@@ -1666,12 +1687,12 @@ static int flask_pmu_op (struct domain *d, unsigned int op)
 }
 #endif /* CONFIG_X86 */
 
-static int flask_dm_op(struct domain *d)
+static int cf_check flask_dm_op(struct domain *d)
 {
     return current_has_perm(d, SECCLASS_HVM, HVM__DM);
 }
 
-static int flask_xen_version (uint32_t op)
+static int cf_check flask_xen_version(uint32_t op)
 {
     u32 dsid = domain_sid(current->domain);
 
@@ -1711,32 +1732,33 @@ static int flask_xen_version (uint32_t op)
     }
 }
 
-static int flask_domain_resource_map(struct domain *d)
+static int cf_check flask_domain_resource_map(struct domain *d)
 {
     return current_has_perm(d, SECCLASS_DOMAIN2, DOMAIN2__RESOURCE_MAP);
 }
 
 #ifdef CONFIG_ARGO
-static int flask_argo_enable(const struct domain *d)
+static int cf_check flask_argo_enable(const struct domain *d)
 {
     return avc_has_perm(domain_sid(d), SECINITSID_XEN, SECCLASS_ARGO,
                         ARGO__ENABLE, NULL);
 }
 
-static int flask_argo_register_single_source(const struct domain *d,
-                                             const struct domain *t)
+static int cf_check flask_argo_register_single_source(
+    const struct domain *d, const struct domain *t)
 {
     return domain_has_perm(d, t, SECCLASS_ARGO,
                            ARGO__REGISTER_SINGLE_SOURCE);
 }
 
-static int flask_argo_register_any_source(const struct domain *d)
+static int cf_check flask_argo_register_any_source(const struct domain *d)
 {
     return avc_has_perm(domain_sid(d), SECINITSID_XEN, SECCLASS_ARGO,
                         ARGO__REGISTER_ANY_SOURCE, NULL);
 }
 
-static int flask_argo_send(const struct domain *d, const struct domain *t)
+static int cf_check flask_argo_send(
+    const struct domain *d, const struct domain *t)
 {
     return domain_has_perm(d, t, SECCLASS_ARGO, ARGO__SEND);
 }
diff --git a/xen/xsm/flask/private.h b/xen/xsm/flask/private.h
index 73b0de87245a..429f213cce74 100644
--- a/xen/xsm/flask/private.h
+++ b/xen/xsm/flask/private.h
@@ -3,7 +3,7 @@
 
 #include <public/xen.h>
 
-long do_flask_op(XEN_GUEST_HANDLE_PARAM(void) u_flask_op);
-int compat_flask_op(XEN_GUEST_HANDLE_PARAM(void) u_flask_op);
+long cf_check do_flask_op(XEN_GUEST_HANDLE_PARAM(void) u_flask_op);
+int cf_check compat_flask_op(XEN_GUEST_HANDLE_PARAM(void) u_flask_op);
 
 #endif /* XSM_FLASK_PRIVATE */
diff --git a/xen/xsm/silo.c b/xen/xsm/silo.c
index 3550dded7b4e..4d5fc98e7e54 100644
--- a/xen/xsm/silo.c
+++ b/xen/xsm/silo.c
@@ -33,8 +33,8 @@ static bool silo_mode_dom_check(const struct domain *ldom,
             is_control_domain(rdom) || ldom == rdom);
 }
 
-static int silo_evtchn_unbound(struct domain *d1, struct evtchn *chn,
-                               domid_t id2)
+static int cf_check silo_evtchn_unbound(
+    struct domain *d1, struct evtchn *chn, domid_t id2)
 {
     int rc = -EPERM;
     struct domain *d2 = rcu_lock_domain_by_any_id(id2);
@@ -51,30 +51,31 @@ static int silo_evtchn_unbound(struct domain *d1, struct evtchn *chn,
     return rc;
 }
 
-static int silo_evtchn_interdomain(struct domain *d1, struct evtchn *chan1,
-                                   struct domain *d2, struct evtchn *chan2)
+static int cf_check silo_evtchn_interdomain(
+    struct domain *d1, struct evtchn *chan1,
+    struct domain *d2, struct evtchn *chan2)
 {
     if ( silo_mode_dom_check(d1, d2) )
         return xsm_evtchn_interdomain(d1, chan1, d2, chan2);
     return -EPERM;
 }
 
-static int silo_grant_mapref(struct domain *d1, struct domain *d2,
-                             uint32_t flags)
+static int cf_check silo_grant_mapref(
+    struct domain *d1, struct domain *d2, uint32_t flags)
 {
     if ( silo_mode_dom_check(d1, d2) )
         return xsm_grant_mapref(d1, d2, flags);
     return -EPERM;
 }
 
-static int silo_grant_transfer(struct domain *d1, struct domain *d2)
+static int cf_check silo_grant_transfer(struct domain *d1, struct domain *d2)
 {
     if ( silo_mode_dom_check(d1, d2) )
         return xsm_grant_transfer(d1, d2);
     return -EPERM;
 }
 
-static int silo_grant_copy(struct domain *d1, struct domain *d2)
+static int cf_check silo_grant_copy(struct domain *d1, struct domain *d2)
 {
     if ( silo_mode_dom_check(d1, d2) )
         return xsm_grant_copy(d1, d2);
@@ -83,15 +84,16 @@ static int silo_grant_copy(struct domain *d1, struct domain *d2)
 
 #ifdef CONFIG_ARGO
 
-static int silo_argo_register_single_source(const struct domain *d1,
-                                            const struct domain *d2)
+static int cf_check silo_argo_register_single_source(
+    const struct domain *d1, const struct domain *d2)
 {
     if ( silo_mode_dom_check(d1, d2) )
         return xsm_argo_register_single_source(d1, d2);
     return -EPERM;
 }
 
-static int silo_argo_send(const struct domain *d1, const struct domain *d2)
+static int cf_check silo_argo_send(
+    const struct domain *d1, const struct domain *d2)
 {
     if ( silo_mode_dom_check(d1, d2) )
         return xsm_argo_send(d1, d2);
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:18:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:18:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272107.466929 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbFM-0007yB-KW; Mon, 14 Feb 2022 13:18:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272107.466929; Mon, 14 Feb 2022 13:18:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbFM-0007y0-Gt; Mon, 14 Feb 2022 13:18:28 +0000
Received: by outflank-mailman (input) for mailman id 272107;
 Mon, 14 Feb 2022 13:18:27 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJb4f-0008IH-Jp
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:07:25 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0c8203ae-8d97-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 14:07:23 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0c8203ae-8d97-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644844043;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=50D+xAeRBi7l/rNYWw5qNsHZx6AmOYhKRxvgdKe98Q8=;
  b=P1qPBZ2pQj1qm6Yuqkb3kIQYKWRRcUf2y3LTX3T4gcfMsjOOx0FNM0C0
   O1cVFn2+thdotBF1TJhbd21K1o5Ejr1ibzYYQ94JyPH1ixxtEcIkamXrb
   EXNkPBhd5wDfvPpDIiyK15wW1RM0zOoJmVqaFUQBPnaFj8lXt5Elqu3WR
   E=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: mF2LEJABfwpSZn+t5sRoqTFHKf4A3rR44KKUo4Fj0EjvfnHaFz4SSMewpxCSkTqa+zh7fvzDrM
 AACnTSUqyHo693ghBv5CDbgw4jq/IGSLvuErrDz13pu68/VdgG5AYRarcx7v2ldDI2C0NM+ytw
 NVt4mNVwn1xBQRSNm0HSlq0WtpLeXmzi547Fk/xjrupKgsfjVkoT8codK8OqxXpqKB33afzWt2
 7zO/+S1o20N8gyOnYLffrQeJYwlbE9PaL6cPGl20yOpSrX+lo+dHUAzpMYvh1Pw48u26+kp4k9
 6Wug2SjvCovvG3aGfTj9i+SR
X-SBRS: 5.1
X-MesageID: 64554431
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:GHuABKlxs0zTCM0Sbv1HJYXo5gyZIURdPkR7XQ2eYbSJt1+Wr1Gzt
 xJKWzuOafuINGL8eNgga4+19BsHu5eAz9RjTQtu/i41FiMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BClVlxJVF/fngqoDUUYYoAQgsA180IMsdoUg7wbRh2Nc02YHR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 OcRqLLubDouApLJnd9eQTxRHA9kOKITrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBODtMJkSpTdLyjbBAOx9aZvCX7/L9ZlT2zJYasVmQ6qDO
 pZFMmMHgBLoMh1wGVYwGp4Hkfq6gCXxfDxgt2mVuv9ii4TU5FMoi+W8WDbPQfSaSMMQkkuGq
 2bu+2XiHgpcJNGZ0SCC8H+nmqnIhyyTZW4JPOTmrLgw2gTVnzFNTk1NPbemnRWnonziRvwBD
 nETxhUrqJNx5mmiQffnWhLt9RZooSUgc9ZXFuQ77iSExazV/xuVCwA4c9JRVDA1nJRoHGJ3j
 zdli/usXGUy6+PNFRpx45/J9WvaBMQDEYMVicbopyMh6sKrnow8hwmnoj1LQP/s1Y2d9d0dL
 lm3QMkCa1c70JRjO0aTpwmvb9eQSn/hFFBd2+kvdjj5hj6Vnab8D2BS1XDV7OxbMKGSRUSbs
 X4PlqC2tb5SUc7dxHHQGLxWRtlFAspp1xWG3zZS82QJrWzxqxZPg6gMiN2BGKuZGpldImK4C
 KMikQhQ+IVSLBOXgVxfOOqM5zAR5fG4T7zND6mMBvIXO8QZXFLXrUlGOB/Lt0iwwRdErE3KE
 crCGSpaJS1BUvoPIfvfb7p17ILHMQhgmTKNFcijlUzPPHj3TCf9dIrp+WCmNogRhJ5oai2Mr
 4k32xKix0oNXevgTDPQ9IJPf1kGIWJiXcL9qtBNd/7FKQ1jQTlzB/jUyLInWopkg6UKybuYo
 iDjAhdVmAjlmHnKCQSWcXQ/Ornhaoly8CAgNis2MFf2h3V6OdSz7L0SfoccdKU88LAx1uZ9S
 vQIIp3SAvlGRjnd1S4aaJ3x8N5reBix3FrcNCu5ejkvOZVnQlWRqNPjewLu8ggIDza26pRi8
 +HxiFuDTMNaFQp4DcvQZPa+9H+LvCAQyLBoQk/FAthPY0GwooJkHDP8060sKMYWJBSdmjbDj
 1SKAQ0VrPXmqpMu9IWbnriNqoqkHrcsHkdeGGWHv7+6OTODozimyI5EFu2JYSrcRCX//6D7P
 bdZyPT1MfsmmldWstUjT+Y3nPxmv9a/9aVHyglEHWnQawX5A7xtFXCKwM1Tu/Af3bReowa3B
 hqC99Qy1W9l4y85/Ir9/DYYU9k=
IronPort-HdrOrdr: A9a23:lkd4bq46E69fZZnnEwPXwMrXdLJyesId70hD6qhwISY6TiX4rb
 HWoB1173/JYVoqNE3I3OrwXZVoIkmsk6Kdg7NhXotKNTOO0ADDQb2Kr7GSpwEIcxeOkdK1vp
 0AT0ERMrLN5CBB/KTH3DU=
X-IronPort-AV: E=Sophos;i="5.88,367,1635220800"; 
   d="scan'208";a="64554431"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v2 12/70] xen: CFI hardening for acpi_table_parse()
Date: Mon, 14 Feb 2022 12:50:29 +0000
Message-ID: <20220214125127.17985-13-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

Control Flow Integrity schemes use toolchain and optionally hardware support
to help protect against call/jump/return oriented programming attacks.

Use cf_check to annotate function pointer targets for the toolchain.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
 xen/arch/x86/acpi/boot.c                 | 24 ++++++++++++------------
 xen/arch/x86/hvm/dom0_build.c            | 16 ++++++++--------
 xen/arch/x86/include/asm/tboot.h         |  2 +-
 xen/arch/x86/srat.c                      |  4 ++--
 xen/arch/x86/tboot.c                     |  2 +-
 xen/arch/x86/x86_64/acpi_mmcfg.c         |  2 +-
 xen/arch/x86/x86_64/mmconfig.h           |  2 +-
 xen/drivers/acpi/apei/hest.c             |  4 ++--
 xen/drivers/acpi/numa.c                  | 10 +++++-----
 xen/drivers/passthrough/amd/iommu_acpi.c |  9 +++++----
 xen/drivers/passthrough/pci.c            |  3 ++-
 xen/drivers/passthrough/vtd/dmar.c       |  2 +-
 xen/include/xen/acpi.h                   |  2 +-
 13 files changed, 42 insertions(+), 40 deletions(-)

diff --git a/xen/arch/x86/acpi/boot.c b/xen/arch/x86/acpi/boot.c
index cc4bbc0284fa..54b72d716bed 100644
--- a/xen/arch/x86/acpi/boot.c
+++ b/xen/arch/x86/acpi/boot.c
@@ -60,7 +60,7 @@ static u64 acpi_lapic_addr __initdata = APIC_DEFAULT_PHYS_BASE;
                               Boot-time Configuration
    -------------------------------------------------------------------------- */
 
-static int __init acpi_parse_madt(struct acpi_table_header *table)
+static int __init cf_check acpi_parse_madt(struct acpi_table_header *table)
 {
 	struct acpi_table_madt *madt =
 		container_of(table, struct acpi_table_madt, header);
@@ -77,7 +77,7 @@ static int __init acpi_parse_madt(struct acpi_table_header *table)
 	return 0;
 }
 
-static int __init
+static int __init cf_check
 acpi_parse_x2apic(struct acpi_subtable_header *header, const unsigned long end)
 {
 	struct acpi_madt_local_x2apic *processor =
@@ -133,7 +133,7 @@ acpi_parse_x2apic(struct acpi_subtable_header *header, const unsigned long end)
 	return 0;
 }
 
-static int __init
+static int __init cf_check
 acpi_parse_lapic(struct acpi_subtable_header * header, const unsigned long end)
 {
 	struct acpi_madt_local_apic *processor =
@@ -171,7 +171,7 @@ acpi_parse_lapic(struct acpi_subtable_header * header, const unsigned long end)
 	return 0;
 }
 
-static int __init
+static int __init cf_check
 acpi_parse_lapic_addr_ovr(struct acpi_subtable_header * header,
 			  const unsigned long end)
 {
@@ -187,7 +187,7 @@ acpi_parse_lapic_addr_ovr(struct acpi_subtable_header * header,
 	return 0;
 }
 
-static int __init
+static int __init cf_check
 acpi_parse_x2apic_nmi(struct acpi_subtable_header *header,
 		      const unsigned long end)
 {
@@ -206,7 +206,7 @@ acpi_parse_x2apic_nmi(struct acpi_subtable_header *header,
 	return 0;
 }
 
-static int __init
+static int __init cf_check
 acpi_parse_lapic_nmi(struct acpi_subtable_header * header, const unsigned long end)
 {
 	struct acpi_madt_local_apic_nmi *lapic_nmi =
@@ -223,7 +223,7 @@ acpi_parse_lapic_nmi(struct acpi_subtable_header * header, const unsigned long e
 	return 0;
 }
 
-static int __init
+static int __init cf_check
 acpi_parse_ioapic(struct acpi_subtable_header * header, const unsigned long end)
 {
 	struct acpi_madt_io_apic *ioapic =
@@ -240,7 +240,7 @@ acpi_parse_ioapic(struct acpi_subtable_header * header, const unsigned long end)
 	return 0;
 }
 
-static int __init
+static int __init cf_check
 acpi_parse_int_src_ovr(struct acpi_subtable_header * header,
 		       const unsigned long end)
 {
@@ -267,7 +267,7 @@ acpi_parse_int_src_ovr(struct acpi_subtable_header * header,
 	return 0;
 }
 
-static int __init
+static int __init cf_check
 acpi_parse_nmi_src(struct acpi_subtable_header * header, const unsigned long end)
 {
 	struct acpi_madt_nmi_source *nmi_src =
@@ -283,7 +283,7 @@ acpi_parse_nmi_src(struct acpi_subtable_header * header, const unsigned long end
 	return 0;
 }
 
-static int __init acpi_parse_hpet(struct acpi_table_header *table)
+static int __init cf_check acpi_parse_hpet(struct acpi_table_header *table)
 {
 	const struct acpi_table_hpet *hpet_tbl =
 		container_of(table, const struct acpi_table_hpet, header);
@@ -319,7 +319,7 @@ static int __init acpi_parse_hpet(struct acpi_table_header *table)
 	return 0;
 }
 
-static int __init acpi_invalidate_bgrt(struct acpi_table_header *table)
+static int __init cf_check acpi_invalidate_bgrt(struct acpi_table_header *table)
 {
 	struct acpi_table_bgrt *bgrt_tbl =
 		container_of(table, struct acpi_table_bgrt, header);
@@ -472,7 +472,7 @@ acpi_fadt_parse_sleep_info(const struct acpi_table_fadt *fadt)
 	       acpi_sinfo.wakeup_vector, acpi_sinfo.vector_width);
 }
 
-static int __init acpi_parse_fadt(struct acpi_table_header *table)
+static int __init cf_check acpi_parse_fadt(struct acpi_table_header *table)
 {
 	const struct acpi_table_fadt *fadt =
 		container_of(table, const struct acpi_table_fadt, header);
diff --git a/xen/arch/x86/hvm/dom0_build.c b/xen/arch/x86/hvm/dom0_build.c
index f9e17249dcda..25fb05a389df 100644
--- a/xen/arch/x86/hvm/dom0_build.c
+++ b/xen/arch/x86/hvm/dom0_build.c
@@ -745,15 +745,15 @@ static int __init pvh_setup_cpus(struct domain *d, paddr_t entry,
     return 0;
 }
 
-static int __init acpi_count_intr_ovr(struct acpi_subtable_header *header,
-                                     const unsigned long end)
+static int __init cf_check acpi_count_intr_ovr(
+    struct acpi_subtable_header *header, const unsigned long end)
 {
     acpi_intr_overrides++;
     return 0;
 }
 
-static int __init acpi_set_intr_ovr(struct acpi_subtable_header *header,
-                                    const unsigned long end)
+static int __init cf_check acpi_set_intr_ovr(
+    struct acpi_subtable_header *header, const unsigned long end)
 {
     const struct acpi_madt_interrupt_override *intr =
         container_of(header, struct acpi_madt_interrupt_override, header);
@@ -764,15 +764,15 @@ static int __init acpi_set_intr_ovr(struct acpi_subtable_header *header,
     return 0;
 }
 
-static int __init acpi_count_nmi_src(struct acpi_subtable_header *header,
-                                     const unsigned long end)
+static int __init cf_check acpi_count_nmi_src(
+    struct acpi_subtable_header *header, const unsigned long end)
 {
     acpi_nmi_sources++;
     return 0;
 }
 
-static int __init acpi_set_nmi_src(struct acpi_subtable_header *header,
-                                   const unsigned long end)
+static int __init cf_check acpi_set_nmi_src(
+    struct acpi_subtable_header *header, const unsigned long end)
 {
     const struct acpi_madt_nmi_source *src =
         container_of(header, struct acpi_madt_nmi_source, header);
diff --git a/xen/arch/x86/include/asm/tboot.h b/xen/arch/x86/include/asm/tboot.h
index bfeed1542fa3..818d5fa45132 100644
--- a/xen/arch/x86/include/asm/tboot.h
+++ b/xen/arch/x86/include/asm/tboot.h
@@ -124,7 +124,7 @@ void tboot_probe(void);
 void tboot_shutdown(uint32_t shutdown_type);
 int tboot_in_measured_env(void);
 int tboot_protect_mem_regions(void);
-int tboot_parse_dmar_table(acpi_table_handler dmar_handler);
+int cf_check tboot_parse_dmar_table(acpi_table_handler dmar_handler);
 int tboot_s3_resume(void);
 void tboot_s3_error(int error);
 int tboot_wake_ap(int apicid, unsigned long sipi_vec);
diff --git a/xen/arch/x86/srat.c b/xen/arch/x86/srat.c
index 6b77b9820195..cfe24c7e781c 100644
--- a/xen/arch/x86/srat.c
+++ b/xen/arch/x86/srat.c
@@ -407,8 +407,8 @@ void __init acpi_numa_arch_fixup(void) {}
 
 static uint64_t __initdata srat_region_mask;
 
-static int __init srat_parse_region(struct acpi_subtable_header *header,
-				    const unsigned long end)
+static int __init cf_check srat_parse_region(
+    struct acpi_subtable_header *header, const unsigned long end)
 {
 	struct acpi_srat_mem_affinity *ma;
 
diff --git a/xen/arch/x86/tboot.c b/xen/arch/x86/tboot.c
index 529367ed8167..fe1abfdf08ff 100644
--- a/xen/arch/x86/tboot.c
+++ b/xen/arch/x86/tboot.c
@@ -450,7 +450,7 @@ int __init tboot_protect_mem_regions(void)
     return 1;
 }
 
-int __init tboot_parse_dmar_table(acpi_table_handler dmar_handler)
+int __init cf_check tboot_parse_dmar_table(acpi_table_handler dmar_handler)
 {
     int rc;
     uint64_t size;
diff --git a/xen/arch/x86/x86_64/acpi_mmcfg.c b/xen/arch/x86/x86_64/acpi_mmcfg.c
index 0db8f57abbed..2159c68189e4 100644
--- a/xen/arch/x86/x86_64/acpi_mmcfg.c
+++ b/xen/arch/x86/x86_64/acpi_mmcfg.c
@@ -68,7 +68,7 @@ static int __init acpi_mcfg_check_entry(struct acpi_table_mcfg *mcfg,
     return -EINVAL;
 }
 
-int __init acpi_parse_mcfg(struct acpi_table_header *header)
+int __init cf_check acpi_parse_mcfg(struct acpi_table_header *header)
 {
     struct acpi_table_mcfg *mcfg;
     unsigned long i;
diff --git a/xen/arch/x86/x86_64/mmconfig.h b/xen/arch/x86/x86_64/mmconfig.h
index 4d3b9fcbdd3c..433046be663a 100644
--- a/xen/arch/x86/x86_64/mmconfig.h
+++ b/xen/arch/x86/x86_64/mmconfig.h
@@ -76,7 +76,7 @@ static inline void mmio_config_writel(void __iomem *pos, u32 val)
 
 /* function prototypes */
 struct acpi_table_header;
-int acpi_parse_mcfg(struct acpi_table_header *header);
+int cf_check acpi_parse_mcfg(struct acpi_table_header *header);
 int pci_mmcfg_reserved(uint64_t address, unsigned int segment,
                        unsigned int start_bus, unsigned int end_bus,
                        unsigned int flags);
diff --git a/xen/drivers/acpi/apei/hest.c b/xen/drivers/acpi/apei/hest.c
index c5f3aaab7c4e..5881275d2f37 100644
--- a/xen/drivers/acpi/apei/hest.c
+++ b/xen/drivers/acpi/apei/hest.c
@@ -128,8 +128,8 @@ int apei_hest_parse(apei_hest_func_t func, void *data)
  * Check if firmware advertises firmware first mode. We need FF bit to be set
  * along with a set of MC banks which work in FF mode.
  */
-static int __init hest_parse_cmc(const struct acpi_hest_header *hest_hdr,
-				 void *data)
+static int __init cf_check hest_parse_cmc(
+	const struct acpi_hest_header *hest_hdr, void *data)
 {
 #ifdef CONFIG_X86_MCE
 	unsigned int i;
diff --git a/xen/drivers/acpi/numa.c b/xen/drivers/acpi/numa.c
index 85f891757c21..bc6e888234e4 100644
--- a/xen/drivers/acpi/numa.c
+++ b/xen/drivers/acpi/numa.c
@@ -112,14 +112,14 @@ void __init acpi_table_print_srat_entry(struct acpi_subtable_header * header)
 	}
 }
 
-static int __init acpi_parse_slit(struct acpi_table_header *table)
+static int __init cf_check acpi_parse_slit(struct acpi_table_header *table)
 {
 	acpi_numa_slit_init((struct acpi_table_slit *)table);
 
 	return 0;
 }
 
-static int __init
+static int __init cf_check
 acpi_parse_x2apic_affinity(struct acpi_subtable_header *header,
 			   const unsigned long end)
 {
@@ -138,7 +138,7 @@ acpi_parse_x2apic_affinity(struct acpi_subtable_header *header,
 	return 0;
 }
 
-static int __init
+static int __init cf_check
 acpi_parse_processor_affinity(struct acpi_subtable_header *header,
 			      const unsigned long end)
 {
@@ -156,7 +156,7 @@ acpi_parse_processor_affinity(struct acpi_subtable_header *header,
 	return 0;
 }
 
-static int __init
+static int __init cf_check
 acpi_parse_memory_affinity(struct acpi_subtable_header *header,
 			   const unsigned long end)
 {
@@ -174,7 +174,7 @@ acpi_parse_memory_affinity(struct acpi_subtable_header *header,
 	return 0;
 }
 
-int __init acpi_parse_srat(struct acpi_table_header *table)
+int __init cf_check acpi_parse_srat(struct acpi_table_header *table)
 {
 	if (!table)
 		return -EINVAL;
diff --git a/xen/drivers/passthrough/amd/iommu_acpi.c b/xen/drivers/passthrough/amd/iommu_acpi.c
index 5ea227732821..3a7931458944 100644
--- a/xen/drivers/passthrough/amd/iommu_acpi.c
+++ b/xen/drivers/passthrough/amd/iommu_acpi.c
@@ -1078,7 +1078,7 @@ static inline bool_t is_ivmd_block(u8 type)
             type == ACPI_IVRS_TYPE_MEMORY_IOMMU);
 }
 
-static int __init parse_ivrs_table(struct acpi_table_header *table)
+static int __init cf_check parse_ivrs_table(struct acpi_table_header *table)
 {
     const struct acpi_ivrs_header *ivrs_block;
     unsigned long length;
@@ -1170,7 +1170,7 @@ static int __init parse_ivrs_table(struct acpi_table_header *table)
     return error;
 }
 
-static int __init detect_iommu_acpi(struct acpi_table_header *table)
+static int __init cf_check detect_iommu_acpi(struct acpi_table_header *table)
 {
     const struct acpi_ivrs_header *ivrs_block;
     unsigned long length = sizeof(struct acpi_table_ivrs);
@@ -1264,7 +1264,8 @@ static int __init get_last_bdf_ivhd(
     return last_bdf;
 }
 
-static int __init get_last_bdf_acpi(struct acpi_table_header *table)
+static int __init cf_check cf_check get_last_bdf_acpi(
+    struct acpi_table_header *table)
 {
     const struct acpi_ivrs_header *ivrs_block;
     unsigned long length = sizeof(struct acpi_table_ivrs);
@@ -1306,7 +1307,7 @@ int __init amd_iommu_update_ivrs_mapping_acpi(void)
     return acpi_table_parse(ACPI_SIG_IVRS, parse_ivrs_table);
 }
 
-static int __init
+static int __init cf_check
 get_supported_ivhd_type(struct acpi_table_header *table)
 {
     size_t length = sizeof(struct acpi_table_ivrs);
diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
index ed459f6409a8..c170dd06ba51 100644
--- a/xen/drivers/passthrough/pci.c
+++ b/xen/drivers/passthrough/pci.c
@@ -1287,7 +1287,8 @@ static bool_t hest_source_is_pcie_aer(const struct acpi_hest_header *hest_hdr)
     return 0;
 }
 
-static int aer_hest_parse(const struct acpi_hest_header *hest_hdr, void *data)
+static int cf_check aer_hest_parse(
+    const struct acpi_hest_header *hest_hdr, void *data)
 {
     struct aer_hest_parse_info *info = data;
     const struct acpi_hest_aer_common *p;
diff --git a/xen/drivers/passthrough/vtd/dmar.c b/xen/drivers/passthrough/vtd/dmar.c
index b152f3da916b..b8e91f5be1ae 100644
--- a/xen/drivers/passthrough/vtd/dmar.c
+++ b/xen/drivers/passthrough/vtd/dmar.c
@@ -767,7 +767,7 @@ acpi_parse_one_rhsa(struct acpi_dmar_header *header)
     return ret;
 }
 
-static int __init acpi_parse_dmar(struct acpi_table_header *table)
+static int __init cf_check acpi_parse_dmar(struct acpi_table_header *table)
 {
     struct acpi_table_dmar *dmar;
     struct acpi_dmar_header *entry_header;
diff --git a/xen/include/xen/acpi.h b/xen/include/xen/acpi.h
index 08834f140266..39d51fcd01dd 100644
--- a/xen/include/xen/acpi.h
+++ b/xen/include/xen/acpi.h
@@ -91,7 +91,7 @@ struct acpi_subtable_header *acpi_table_get_entry_madt(enum acpi_madt_type id,
 int acpi_table_parse_madt(enum acpi_madt_type id, acpi_table_entry_handler handler, unsigned int max_entries);
 int acpi_table_parse_srat(int id, acpi_madt_entry_handler handler,
 	unsigned int max_entries);
-int acpi_parse_srat(struct acpi_table_header *);
+int cf_check acpi_parse_srat(struct acpi_table_header *);
 void acpi_table_print (struct acpi_table_header *header, unsigned long phys_addr);
 void acpi_table_print_madt_entry (struct acpi_subtable_header *madt);
 void acpi_table_print_srat_entry (struct acpi_subtable_header *srat);
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:22:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:22:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272140.466940 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbIx-0002Dw-9P; Mon, 14 Feb 2022 13:22:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272140.466940; Mon, 14 Feb 2022 13:22:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbIx-0002Dp-67; Mon, 14 Feb 2022 13:22:11 +0000
Received: by outflank-mailman (input) for mailman id 272140;
 Mon, 14 Feb 2022 13:22:10 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KkXt=S5=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nJbIw-0002Dj-4p
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:22:10 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1c0a1c0d-8d99-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 14:22:08 +0100 (CET)
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2059.outbound.protection.outlook.com [104.47.1.59]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-26-QytLdc1NO5uGgtNaVylN7w-1; Mon, 14 Feb 2022 14:22:06 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM0PR0402MB3316.eurprd04.prod.outlook.com (2603:10a6:208:19::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.15; Mon, 14 Feb
 2022 13:22:04 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4975.015; Mon, 14 Feb 2022
 13:22:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1c0a1c0d-8d99-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644844928;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=tWRtGHI/S8dHaJhukNZ17wBTsp+lv3e7661CMsZcL28=;
	b=lTCDBC1ra+UKTBnFBpPt08jTiae+XV1qZrrZvpFSYj1c+VT5LrwsV1hCflJ2/zop86aRdR
	iu3xwUFytOpxvMY2UT3xS4m78ZG4gIcOu3vvEpMhNiHDhluMQyDg5u0KLs3nwkoM+Wtv4N
	M7UFy3xs08Gr/oT5OdSNRFQBCRwPJ1M=
X-MC-Unique: QytLdc1NO5uGgtNaVylN7w-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=K6vuYvZw2IodrHbt09+4OS+lpEsRiw0FV2WgKuAuQuJuLbIv+Cj0fgl40A/XH+nyHYLC2R7DUOLI3Rng3XIwg1Dvdc3oAit7towg9wZxLMHhSSh9t4VFTxZUvFNFPqfBBvppGPcg1AH7pP02EHYR7mFlL0gDtWS0QBTPaZb4r1RUiGVtqfQ82XUGFaGm8esfDIgWFLLIrhedth7jWdRXxBZaMY62XHGkiYo4DoIGXDI/Iw4W1Z2UD2pUjxy+aYYrnlIA7hWslcBC56sy3eqOXgX279nYtQCJ3VhVEYmL0bPya75QuZyPoXo485xpZDgl6U5sfPRMLyNisq0pqc6ZBA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=8zydRb0P0vZ2SfBvuiDPx/mbmRGQUZ1KeivECWm8RR8=;
 b=WbTr6F/auIDgNdSFlgka/kkPN8uEnAnbpn6rsXNPXrCX8A0HMZ42XUIvfuYCZJppUY/8WomYdIsounjWIAqz9F+H3itDwh5QAjsSriKo7qxmzQvOgXUfkIiyMMojimYbduHyT/BPWIFGAvTbTX+OCflZ/t2mtSbFAb1NCuXyLSyT9C6RMo4UECgfnHdGivJTiHVWVacMkqK9c6h4cKTa8EwRFeExLXZqdVvwFofzeCmg/M38hDhsrQo9DB0z9apQtLh8fKnmvnX1XgPkfZ03m4EutXM98qUGFkIO4ysh0vK30KqImVIievdpn43MF2gYHCHCI6hVgMVUInqxAPwDMQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <f0e202dd-1f6e-4aac-1381-a64a7fd12270@suse.com>
Date: Mon, 14 Feb 2022 14:22:02 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH] vpci: introduce per-domain lock to protect vpci structure
Content-Language: en-US
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "julien@xen.org" <julien@xen.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Artem Mygaiev <Artem_Mygaiev@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>
References: <20220209133627.959649-1-andr2000@gmail.com>
 <YgU6Snk8GTytJXZp@Air-de-Roger>
 <c4666570-666e-6680-5ec2-adf1da51ad06@epam.com>
 <YgZLEMW9US9QjjYG@Air-de-Roger>
 <33fb1095-64ed-29ef-ba6b-cbde21d941f8@epam.com>
 <YgowIg5MvTaf2zsR@Air-de-Roger>
 <d8389a90-00c8-b34a-8488-b0f3fc5bde1b@epam.com>
 <Ygo40L4dMPJjZKRF@Air-de-Roger>
 <746860aa-c403-1eca-0a75-587c5d10c8c2@epam.com>
 <Ygo8M3Y6BLzljn15@Air-de-Roger>
 <114b8578-ee13-b67d-e282-d060187ef509@epam.com>
 <06baf0c8-d7d2-50b8-ea8f-1d422ceac728@suse.com>
 <6ccc7add-c13e-555f-b341-ce37118746e5@epam.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <6ccc7add-c13e-555f-b341-ce37118746e5@epam.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6PR05CA0014.eurprd05.prod.outlook.com
 (2603:10a6:20b:2e::27) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ff8596c3-d05a-487f-2ea3-08d9efbcfdc7
X-MS-TrafficTypeDiagnostic: AM0PR0402MB3316:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR0402MB3316463793ECC9A5FD70D48AB3339@AM0PR0402MB3316.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	wc1henjc/diOf5qMJhC4DzQiAEN5fuG864+bF5lnxMSsczJxp5CVdjAUX+56pWt4lLHcuc8Hmx3g83hDWK1bUGOp4cR2h/0y9wCSFB7TnhxDzaCXBbuZPMexLjmUaUkioYycxFkMJVoDXB1qzUWm7QWNZ7Lsmc6WrhUrmf1lGo4V4Ia6np0a8dAtcI5vzW/0cCGS9uRIXmM/+QhIWWKDEF08kbiELJU4yvMdRTqOKEXbQ3pb/Iw8R3Vhqb3x2mEOuQENuxaBR8QQYZLSWFArDxNk9Z3zv/qsRQ5JiJ3+1NC8eS+pUVEPUEZcaPpxRtpn2QOQJGd22X18Bc/tvdIquLAHzrvyVxpuQXIsEKefn8rf4lbLvLSXaVWeqMR0SZAishHJR+Z+3Qt/LZevUGKar1lwNYUDe7PseLOrG89slok93KeEbRoiASn/FbcoAALz3cFtl5erPQH6O3m3ocs2KUyZlcQxybNxupJ7Y82MOr33uxoLGwZi4QMc/kzYjbRfrKGMBVDilk5skW2RRI+6Qi4DuiKWFqEMcWHLSS1JNUskjZQ5jCkiQSJlzCjM7clI+8RIuNHHCOznZK3U8bCrRD+taSGHnpDvZ9rZCt/1F90wgHnWLtfv0PZa/lBVrNw/05jAbMw3n3Q2lNhwgsCRVSV5MER4UIZMZIwd4wK4c+xgbjQQqMpGidOQcatplxz2VMCtKyLbf2zWFXuhq/jqwhqeNIjC3yZRifzgw+/4KjI0HuZYpxBPdrHOyD32hqe3
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(508600001)(8936002)(2616005)(6486002)(6916009)(86362001)(36756003)(316002)(2906002)(54906003)(31686004)(66946007)(53546011)(66556008)(4326008)(66476007)(8676002)(83380400001)(6512007)(38100700002)(31696002)(5660300002)(6506007)(26005)(186003)(7416002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?0ZIORJDwmMDit5TAdGrZmdy/HpEkB7hwFQ3msKnMHLgq+F+6iqe811gEmKGA?=
 =?us-ascii?Q?eoPpcJv+4Q/4tagSIDAVGmVP4EVGmuShSITYdF5LjRYm82/q2qoAW+by0Z3m?=
 =?us-ascii?Q?Fzg63L65pzUtGptZP1nBlaGZnrwKdLbkFXPEvaXxalGkX19SV9PMLbo9hWn+?=
 =?us-ascii?Q?6zUhmnnkvhlrJWtNK8PuQOPMEcXXVj9Es15ph+vPdTFwR+nDp8w3oDWav1+h?=
 =?us-ascii?Q?YscLMdICo2JRljIG9+6Le5982XpmHOCj/fN/Kw0MrodykOnttjcUrOeQ5SG4?=
 =?us-ascii?Q?v/YpVgQn6C7m94Fwn4x8PmuFGmj5WYfjTl3kIl8k2yAwfnoPbEEcudONwWJh?=
 =?us-ascii?Q?yYpP5zwA6vniZxhVpe0pwoG9KWOxFgtQc91NOyyCwqtKCKuVJIBPrmFlM9W8?=
 =?us-ascii?Q?suT+KyG8PvpJ8TmUgWfKvVLCRIuBJXJ1vzUX6y0BfOcEEJf/xSFGOeEWsfmH?=
 =?us-ascii?Q?Id0n4p+RfVyhiwo2y3m8Xn8eYhjBdNQF+VXGrld4woZMB5fnB11Fg0aNnX0+?=
 =?us-ascii?Q?bQk4BxaX+876vS4X44VR5WWmozc46YWhe8i4NRZOZaGlDrNnkCVNr6IWE1Sx?=
 =?us-ascii?Q?UCk6xJ6/xom0EBMlUmbkLbbDkdGoiVogsbYwYEzAXXGTXgrEMmBIb9OYMmMp?=
 =?us-ascii?Q?jy19s6TZ5BIRfduTjBU2ouhcRIu3FGi/zPvgHI/iamR0Wh5eSeqKcQWeNwqw?=
 =?us-ascii?Q?M20aIEAHf64FrIEdeVqLp6CtyEJknSi5tcazMKPqyvEvN7j0HlTQfRnjcxvs?=
 =?us-ascii?Q?fNdbYB5ORrSCkzMNutJvpz5wDxZjQVIQYjc8iygqpN5FEDnofY++IL0zXFVT?=
 =?us-ascii?Q?+a0EAKSv1KVofrpLSMBDtjpdK2Vk5zz/uGQBVWkxdeXUuzg0ycG1+cXPqDBW?=
 =?us-ascii?Q?TsVSgtCBtHwZdUewFOmFUW66KvfqWRy8UPc6PKqpnKZPlw7DIS0NgRC/LS5E?=
 =?us-ascii?Q?3boFLAXvMvEWH6tw7rftnxnT/yZhOCPDq+jKHyxDsAsC3tTM8clMDz0h/p7w?=
 =?us-ascii?Q?Qysk8Cj5rdKOw201x6gGoOuPEJw8dddmXbvr2PzmKJhrDxQsTyEPgPvhiVm9?=
 =?us-ascii?Q?d524n63oEnuQSXvqAe5Z2UXKipre+YwssWo3knFIBoYCrj97YOHgq1GyBfvp?=
 =?us-ascii?Q?RyJCeZahFGU++rXjGWB21BVZSa3dfCIULRArUAqehveKSNT4/6gjQh0wh4it?=
 =?us-ascii?Q?A7XoP7ViY6AwYJGVO4Edzrfp0O8ZpClaxnWzmPNJw48K/JnCYg4EfIqQ41DJ?=
 =?us-ascii?Q?1qZ+UusZHtRYNPyA42olEhqIM+3Yrazvuq+7DqDPjOrIU/0GjFS2pb2mCbH5?=
 =?us-ascii?Q?L/RT3z3QB7Pook2yCPWrGOZmJtKB309428SPaz9TmEpwgXkDq4lofZ4tjjRE?=
 =?us-ascii?Q?etiY03KlZpHSQv0A69XBsOX7KVL3UeoU3Ssg+S596L6ysplYvsh7ALuD3ahH?=
 =?us-ascii?Q?pPs6+s1SQKcc0Pjxgc3AZ070azHjFU10CFw2ErZLA+Gnyvw1s+IzIvE+6/S+?=
 =?us-ascii?Q?OHe0X5Amg3xkNgjF2juymDxyF7X+laLxX3HNtfFKuV6wWB22+dJkETeeBEuG?=
 =?us-ascii?Q?VxRHrwT5ZV4UH/o+Y9RRMqu5nM1B6WOwdzFP1waqt01WJv3jlkOEjcjZ0zEp?=
 =?us-ascii?Q?WKBZdg4uMduySqfTgXooiYQ=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ff8596c3-d05a-487f-2ea3-08d9efbcfdc7
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2022 13:22:04.1777
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: d0YbR4W6a5EQbpNq3V5GPFgqBXai6K2146zObGBtrkWLQIFU2iLFi0XI6dVuCgiJDCBtf46x/jVo6QeDsmWFKA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0402MB3316

On 14.02.2022 14:13, Oleksandr Andrushchenko wrote:
>=20
>=20
> On 14.02.22 14:57, Jan Beulich wrote:
>> On 14.02.2022 12:37, Oleksandr Andrushchenko wrote:
>>>
>>> On 14.02.22 13:25, Roger Pau Monn=C3=A9 wrote:
>>>> On Mon, Feb 14, 2022 at 11:15:27AM +0000, Oleksandr Andrushchenko wrot=
e:
>>>>> On 14.02.22 13:11, Roger Pau Monn=C3=A9 wrote:
>>>>>> On Mon, Feb 14, 2022 at 10:53:43AM +0000, Oleksandr Andrushchenko wr=
ote:
>>>>>>> On 14.02.22 12:34, Roger Pau Monn=C3=A9 wrote:
>>>>>>>> On Mon, Feb 14, 2022 at 09:36:39AM +0000, Oleksandr Andrushchenko =
wrote:
>>>>>>>>> On 11.02.22 13:40, Roger Pau Monn=C3=A9 wrote:
>>>>>>>>>> +
>>>>>>>>>>>>>            for ( i =3D 0; i < msix->max_entries; i++ )
>>>>>>>>>>>>>            {
>>>>>>>>>>>>>                const struct vpci_msix_entry *entry =3D &msix-=
>entries[i];
>>>>>>>>>>>> Since this function is now called with the per-domain rwlock r=
ead
>>>>>>>>>>>> locked it's likely not appropriate to call process_pending_sof=
tirqs
>>>>>>>>>>>> while holding such lock (check below).
>>>>>>>>>>> You are right, as it is possible that:
>>>>>>>>>>>
>>>>>>>>>>> process_pending_softirqs -> vpci_process_pending -> read_lock
>>>>>>>>>>>
>>>>>>>>>>> Even more, vpci_process_pending may also
>>>>>>>>>>>
>>>>>>>>>>> read_unlock -> vpci_remove_device -> write_lock
>>>>>>>>>>>
>>>>>>>>>>> in its error path. So, any invocation of process_pending_softir=
qs
>>>>>>>>>>> must not hold d->vpci_rwlock at least.
>>>>>>>>>>>
>>>>>>>>>>> And also we need to check that pdev->vpci was not removed
>>>>>>>>>>> in between or *re-created*
>>>>>>>>>>>> We will likely need to re-iterate over the list of pdevs assig=
ned to
>>>>>>>>>>>> the domain and assert that the pdev is still assigned to the s=
ame
>>>>>>>>>>>> domain.
>>>>>>>>>>> So, do you mean a pattern like the below should be used at all
>>>>>>>>>>> places where we need to call process_pending_softirqs?
>>>>>>>>>>>
>>>>>>>>>>> read_unlock
>>>>>>>>>>> process_pending_softirqs
>>>>>>>>>>> read_lock
>>>>>>>>>>> pdev =3D pci_get_pdev_by_domain(d, sbdf.seg, sbdf.bus, sbdf.dev=
fn);
>>>>>>>>>>> if ( pdev && pdev->vpci && is_the_same_vpci(pdev->vpci) )
>>>>>>>>>>> <continue processing>
>>>>>>>>>> Something along those lines. You likely need to continue iterate=
 using
>>>>>>>>>> for_each_pdev.
>>>>>>>>> How do we tell if pdev->vpci is the same? Jan has already brought
>>>>>>>>> this question before [1] and I was about to use some ID for that =
purpose:
>>>>>>>>> pdev->vpci->id =3D d->vpci_id++ and then we use pdev->vpci->id=C2=
=A0 for checks
>>>>>>>> Given this is a debug message I would be OK with just doing the
>>>>>>>> minimal checks to prevent Xen from crashing (ie: pdev->vpci exists=
)
>>>>>>>> and that the resume MSI entry is not past the current limit. Other=
wise
>>>>>>>> just print a message and move on to the next device.
>>>>>>> Agree, I see no big issue (probably) if we are not able to print
>>>>>>>
>>>>>>> How about this one:
>>>>>>>
>>>>>>> diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c
>>>>>>> index 809a6b4773e1..50373f04da82 100644
>>>>>>> --- a/xen/drivers/vpci/header.c
>>>>>>> +++ b/xen/drivers/vpci/header.c
>>>>>>> @@ -171,10 +171,31 @@ static int __init apply_map(struct domain *d,=
 const struct pci_dev *pdev,
>>>>>>>     =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 struct rangeset *mem, uint16_t cmd)
>>>>>>>     =C2=A0{
>>>>>>>     =C2=A0=C2=A0=C2=A0=C2=A0 struct map_data data =3D { .d =3D d, .=
map =3D true };
>>>>>>> +=C2=A0=C2=A0=C2=A0 pci_sbdf_t sbdf =3D pdev->sbdf;
>>>>>>>     =C2=A0=C2=A0=C2=A0=C2=A0 int rc;
>>>>>>>
>>>>>>> + ASSERT(rw_is_write_locked(&pdev->domain->vpci_rwlock));
>>>>>>> +
>>>>>>>     =C2=A0=C2=A0=C2=A0=C2=A0 while ( (rc =3D rangeset_consume_range=
s(mem, map_range, &data)) =3D=3D -ERESTART )
>>>>>>> +=C2=A0=C2=A0=C2=A0 {
>>>>>>> +
>>>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 /*
>>>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * process_pending=
_softirqs may trigger vpci_process_pending which
>>>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * may need to acq=
uire pdev->domain->vpci_rwlock in read mode.
>>>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 */
>>>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 write_unlock(&pdev->dom=
ain->vpci_rwlock);
>>>>>>>     =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 process_pendin=
g_softirqs();
>>>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 write_lock(&pdev->domai=
n->vpci_rwlock);
>>>>>>> +
>>>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 /* Check if pdev still =
exists and vPCI was not removed or re-created. */
>>>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (pci_get_pdev_by_dom=
ain(d, sbdf.seg, sbdf.bus, sbdf.devfn) !=3D pdev)
>>>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
 if ( vpci is NOT the same )
>>>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
 {
>>>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0 rc =3D 0;
>>>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0 break;
>>>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
 }
>>>>>>> +=C2=A0=C2=A0=C2=A0 }
>>>>>>> +
>>>>>>>     =C2=A0=C2=A0=C2=A0=C2=A0 rangeset_destroy(mem);
>>>>>>>     =C2=A0=C2=A0=C2=A0=C2=A0 if ( !rc )
>>>>>>>     =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 modify_decodin=
g(pdev, cmd, false);
>>>>>>>
>>>>>>> This one also wants process_pending_softirqs to run so it *might*
>>>>>>> want pdev and vpci checks. But at the same time apply_map runs
>>>>>>> at ( system_state < SYS_STATE_active ), so defer_map won't be
>>>>>>> running yet, thus no vpci_process_pending is possible yet (in terms
>>>>>>> it has something to do yet). So, I think we just need:
>>>>>>>
>>>>>>>     =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 write_unlock(&pdev->=
domain->vpci_rwlock);
>>>>>>>     =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 process_pending_soft=
irqs();
>>>>>>>     =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 write_lock(&pdev->do=
main->vpci_rwlock);
>>>>>>>
>>>>>>> and this should be enough
>>>>>> Given the context apply_map is called from (dom0 specific init code)=
,
>>>>>> there's no need to check for the pdev to still exits, or whether vpc=
i
>>>>>> has been recreated, as it's not possible. Just add a comment to
>>>>>> explicitly note that the context of the function is special, and thu=
s
>>>>>> there's no possibility of either the device or vpci going away.
>>>>> Does it really need write_unlock/write_lock given the context?...
>>>> I think it's bad practice to call process_pending_softirqs while
>>>> holding any locks. This is a very specific context so it's likely fine
>>>> to not drop the lock, but would still seem incorrect to me.
>>> Ok
>>>>> I think it doesn't as there is no chance defer_map is called, thus
>>>>> process_pending_softirqs -> vpci_process_pending -> read_lock
>>>> Indeed, there's no chance of that because process_pending_softirqs
>>>> will never try to do a scheduling operation that would result in our
>>>> context being scheduled out.
>>>   =C2=A0=C2=A0=C2=A0 while ( (rc =3D rangeset_consume_ranges(mem, map_r=
ange, &data)) =3D=3D -ERESTART )
>>>   =C2=A0=C2=A0=C2=A0 {
>>>   =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 /*
>>>   =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * FIXME: Given the c=
ontext apply_map is called from (dom0 specific
>>>   =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * init code at syste=
m_state < SYS_STATE_active) it is not strictly
>>>   =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * required that pdev=
->domain->vpci_rwlock is unlocked before calling
>>>   =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * process_pending_so=
ftirqs as there is no contention possible between
>>>   =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * this code and vpci=
_process_pending trying to acquire the lock in
>>>   =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * read mode. But run=
ning process_pending_softirqs with any lock held
>>>   =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * doesn't seem to be=
 a good practice, so drop the lock and re-acquire
>>>   =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * it right again.
>>>   =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 */
>>>   =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 write_unlock(&pdev->domain=
->vpci_rwlock);
>>>   =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 process_pending_softirqs()=
;
>>>   =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 write_lock(&pdev->domain->=
vpci_rwlock);
>>>   =C2=A0=C2=A0=C2=A0 }
>> I'm afraid that's misleading at best. apply_map() is merely a specific
>> example where you know the lock is going to be taken. But really any
>> softirq handler could be acquiring any lock, so requesting to process
>> softirqs cannot ever be done with any lock held.
>>
>> What you instead want to explain is why, after re-acquiring the lock,
>> no further checking is needed for potentially changed state.
> How about:
>=20
> /*
>  =C2=A0* FIXME: Given the context apply_map is called from (dom0 specific
>  =C2=A0* init code at system_state < SYS_STATE_active) there is no conten=
tion
>  =C2=A0* possible between this code and vpci_process_pending trying to ac=
quire
>  =C2=A0* the lock in read mode and destroy pdev->vpci in its error path.
>  =C2=A0* Neither pdev may be disposed yet, so it is not required to check=
 if the
>  =C2=A0* relevant pdev still exists after re-acquiring the lock.
>  =C2=A0*/

I'm not sure I follow the first sentence; I guess a comma or two may help,
and or using "as well as" in place of one of the two "and". I also don't
think you mean contention, but rather a race between the named entities?

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:26:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:26:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272151.466951 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbNR-0002xo-Vn; Mon, 14 Feb 2022 13:26:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272151.466951; Mon, 14 Feb 2022 13:26:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbNR-0002xh-Sm; Mon, 14 Feb 2022 13:26:49 +0000
Received: by outflank-mailman (input) for mailman id 272151;
 Mon, 14 Feb 2022 13:26:49 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KkXt=S5=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nJbFF-0002qS-LM
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:18:21 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 94672d69-8d98-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 14:18:20 +0100 (CET)
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2054.outbound.protection.outlook.com [104.47.8.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-23-pDiaXwnuMeeOp_Y7p74urQ-1; Mon, 14 Feb 2022 14:18:19 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by GV1PR04MB9197.eurprd04.prod.outlook.com (2603:10a6:150:28::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.18; Mon, 14 Feb
 2022 13:18:17 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4975.015; Mon, 14 Feb 2022
 13:18:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 94672d69-8d98-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644844700;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=OZJD/wOULmCc9InPJEL2dJQ1YMLNY8I9ZV4mWc9LIC4=;
	b=P6wS/UGCGnVmazT9utG/tT8c/44RE3z374v9Z1h4e+W57DoAVqooRfnLxVs8qjwpcQTgWI
	frrEXcTZsl5vc+j/et5A/AN06PJIi9L9abR+V6ZdC3NHIiOc7+h3yGZqewqQVbz/yE8Hsm
	joTp8IUskt/L1Bw+p0xT+QGqXVjKKh0=
X-MC-Unique: pDiaXwnuMeeOp_Y7p74urQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=krwDG7ka8S/B1u4MhwE0jGC3i+SVwVkB4m/1yIgAMQ2nXICPwmk8hqChBSu3tG6CDex9F7+vm+433glImsBJZaCmuRMjtMuKH6UAkdyi18McjmndPaSzDVakNCrG4hiWs0+eppI1FrxsD9nYkCHqzODzqRxg5m451bMWgFLEx2yZZ9W8lQMAKL23u+SDWH0EGiU/PfGAGvDFywWwrGJgmC+fraHeoMW23qHj2dmPy+U28GnAfOj5U0hm5+hTcfkXWjPIu7cUMHPV3Hl+LgSBtpLPWKTtVzW454PSNSNIVii3uzoBmMR67+Ah9OvUL2A8MdU6BjeQMH1hYZO5TNUl7A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=kUfT+uee7lkEeRwRu0M2jDvu9D5RBEzvexxm5xFV+08=;
 b=AD7jfpEIG6eJg+C5KJ/lZzLTMQFm79Ui3ioy8TRYH7cHbdnrCPXDalDo0lZwQCrPrkUtTQBMWCuoLnwgxFKw9YbOzC2IT/PFz21d0xMl8UmrjDTmcV/05z70+kC01tu5uymIejz/KboQ+S2u5R7xs1gExzm5ZGze1wu/fRl09ohYt4rL71kuBxEhbbw8wveNARXwXK8cLSUmRWylM/bHlJ4EP4R6klUFPsXAqrNzx4S6zuOLlVKMFqA9W3mhzidkNFCF5fYDD9StNXhlIagIedrsW++N1DBpsrEUxnMlQdidgIfI3nOjhrjKUk5BmXDJDpJTzW27+mBlkA0hY73/IQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <101b0950-b7f2-119b-b654-574a71cec3bc@suse.com>
Date: Mon, 14 Feb 2022 14:18:14 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH v2 1/2] xen+tools: Report Interrupt Controller
 Virtualization capabilities on x86
Content-Language: en-US
To: Jane Malalane <Jane.Malalane@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>,
 Anthony Perard <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 George Dunlap <George.Dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Jun Nakajima <jun.nakajima@intel.com>, Kevin Tian <kevin.tian@intel.com>,
 Andrew Cooper <Andrew.Cooper3@citrix.com>,
 Roger Pau Monne <roger.pau@citrix.com>
References: <20220207182101.31941-1-jane.malalane@citrix.com>
 <20220207182101.31941-2-jane.malalane@citrix.com>
 <YgTi6bzeojtcu0xL@Air-de-Roger>
 <dff9c5c0-7bee-ce0d-3288-91255a701c99@citrix.com>
 <YgZIo9VQktcqGHTD@Air-de-Roger>
 <6d924061-f2fd-5f3d-0f98-79e76398b908@suse.com>
 <6c9400b8-7c76-34c8-f69e-3fad1eb53b8c@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <6c9400b8-7c76-34c8-f69e-3fad1eb53b8c@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0285.eurprd06.prod.outlook.com
 (2603:10a6:20b:45a::31) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 898c0395-c262-4fcb-cf00-08d9efbc7668
X-MS-TrafficTypeDiagnostic: GV1PR04MB9197:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<GV1PR04MB919734D4EA962509A5BC45D0B3339@GV1PR04MB9197.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	zxFS4HG9tF+uXIE+el1M8fEEUbDmJYCB4dJGg7koYvkhIXbzULr52QghS4l1nVqPsNrQigUkSSmPWUNvh15HBjuL2V9pUsit70KTZCGnbR7qo3+jf661dHF1D/tswfMMz263RRKmIWV7QBNcg6S8Hint41jn1EIaDyyx6sQRPAmghAQkcCTEmlcwuMmwR2QKOav2kisgEjsWPybOS93q4LOE+43oFDbvDb/TVlyMS4JXJJ5dizGu2X9ri/TTwT2TnDG84URkyjh4BMzDpzoSe05/dHXtPtSJtNkNcSTRg3+oYLcyNVURqWMwB4qK9X+fhjZPpeorZ9mu7cIIDJ0GPhrSAb8ML8nZMhDnVKZKZE/xJEDKb4YXfDGIOn9liTBslL4RGWneuMDWM2Vr5QYRuYtqcSaeKdZyVKwf9JYtCFGgNkS3rOftQcktVRZYzfFiPye514GhwIr0qNqz5s8ay01YYtMvZYNTdpTR10SFNOppg7sbKUYomUNodWst+F3RAit4yLtedSegiLUvLoapS4KHvNNXH6eka+kJFCOjgFm8mH8xA7UuQCCJb4SVBy/cn+gNw1/rmzSyds2yJfhPvAPiFtFMXzeiOGqeFJIqDpYmLBMESkjel98sIgitveHfF3U1K0sZaFr7IeW5TV2GRbwczgnolm1uCt7sZJvP7CM2fa78hpCxRxP1jPnEvaPHH3TrgFM2wMcyTaUA2bLSIwYdMk0VcmLi6ZOExAjuwdazAxIrjdnqyuQo5oZhiIyO
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(86362001)(31696002)(38100700002)(66946007)(66556008)(66476007)(8676002)(4326008)(54906003)(316002)(6916009)(7416002)(8936002)(5660300002)(2906002)(2616005)(186003)(26005)(83380400001)(508600001)(6512007)(6486002)(53546011)(6666004)(31686004)(6506007)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?ULa+YXtSLjjVHdF2t/s72OhP2AT9yAAX/yZ42zNoGpa2R/Jx929U1/p1FMoz?=
 =?us-ascii?Q?Dw0RuFkmvf79eYm+GtjIaBagLaG3MXgycWmbSY1VjvpM+HAjPpboFZu7ik5D?=
 =?us-ascii?Q?hZg7mzLu3tJIYpb0Fn0RO4S8HczDdeFt6mjM2id2hyZHQBTJOqpRKbO1tKn+?=
 =?us-ascii?Q?ZjTVoOVwQfL/yeK5oAH6rCVf9hYGjAM+VRVux8XiZ82po0askgAU5FufJI4Y?=
 =?us-ascii?Q?3ide9PWslcCeEx8tqEOOm1SIZXU1YF1OJ58B5qq9qpoDnr6DG4PWtSa32pUp?=
 =?us-ascii?Q?IsaaiHes95PdV4satO1HwvJnKk7o8xjTBMfaXK3M9Ust0+D5a0M59w5rTmW3?=
 =?us-ascii?Q?GHfYx0VMhmXALPfHif9NiJqmzpW/5rqwcMoYcWQMOsiFSY3OGKk2LgZDtUce?=
 =?us-ascii?Q?fIZyCdaBHXmfKgLcBIQDznT3ZIa8Y682VMmJwr8Tiget3MUhe/Dd6nTntaBf?=
 =?us-ascii?Q?WMonm97Zupiyv8ZmJr/I2MpSoGk2aH48z1hZXE7heZZ59FcgZffsWVGdbWKp?=
 =?us-ascii?Q?vg/g8RQgcFhG1SKzgvcEWJSAAsTzjCz+SF5Q/QaneKrq7XubVnjIaX1wC88n?=
 =?us-ascii?Q?dxq2BqFQTF+kO79xiYQZiZmdwRwo36moa0jT3yBWoaYauES6Hfj+nt6P4R44?=
 =?us-ascii?Q?xOnGtvYTzT6jyxcB/a+O5XSf8hWHa5a9Z8mWQR09uhM5K7sQIFILC/91l9rV?=
 =?us-ascii?Q?D4zEvEFc1wPpIWQyaJdqMoPUq3TovBVXArkt0qPPD4+5PAY4RQrYFhSui5sj?=
 =?us-ascii?Q?HYHTQUbNqTN3JaTf+YdGN9t62vdzoDrEuAT0HjXM+EtB4HIWX8sPPj402gZb?=
 =?us-ascii?Q?M7nImHueaQTVaV+3G9w+pU4UAwrUBpnVLzFlUToQEmJaOjEKjD0kioLKWXeO?=
 =?us-ascii?Q?sgoG8YGMzcT3NehIbo/L9WRtc8SV8qVFWR5lF63s08Y1erG8IFz5HzMiB9tI?=
 =?us-ascii?Q?SJ0t7a7HFF7Uzpm5ZWXad2/TZ4cldpcDz+PgfdyVwTjcEq6NJ3hR5pHaKbNQ?=
 =?us-ascii?Q?m72tJFOB6WV5ZYlmVkoCkXlL8i9fSRFvRE8Vq6C7LukEkIi+ynsanludbc8U?=
 =?us-ascii?Q?4kLpSN5ScuOX7JQCo7ud1/v8x6XljNDBqmzRI+RdBptT4bYTdecjK1D7tZkS?=
 =?us-ascii?Q?er10njEx25fz4J0AESkfeIAqE4v/u0AMkGDPgTmTk3MikWElg2Hd6DOSO6TN?=
 =?us-ascii?Q?7DEkV2taBrPnuyAxlwRcBNOnfSH+e/6mo+g6Nwmlk3jsPZlXpOTXn5VMJCPr?=
 =?us-ascii?Q?a0Qr1sydBHDeuB4/fzrB0x+stLjjmHrVSGFnxDTQx7QmKoqOovq171tPngCB?=
 =?us-ascii?Q?SLiMgmXK5fe5ML1Ot96yOJEz+eu5PEhsEr8+OG0MEYygGezGqlqw6xzhWl54?=
 =?us-ascii?Q?+Vn6JSLCSyfpq+3U/0xuwt/TgcYN2/6HHgeFMmLTcoaZoJYoXL8/Y9wieS6p?=
 =?us-ascii?Q?SaS3H6LsVsq2DzODQojDudM+HUCnoGIXRhbwnutWM3Esi4ZNT4ILixFKCgQ7?=
 =?us-ascii?Q?YNLdA94WgMYCll6m9SMzMLBBoTnNRHUKM6/0I9Rwv1IkYrUhqidU8SRWpQMV?=
 =?us-ascii?Q?hafF3Phixdp/AfAx0j7g1qXq5wQmiIxC4yEVC6IJKtCWhCsdyAFtfiO3YusU?=
 =?us-ascii?Q?eb9WDe90H9L5GdLc/+1PRhY=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 898c0395-c262-4fcb-cf00-08d9efbc7668
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2022 13:18:17.0668
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rfKLuumB0DbcM6l1ytN6arRpLuI4CXnkKUt3f/1v1J9S43xCALqZeFUwEwV0AQ93FduFA7/vicLlqB2LGLgoAg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR04MB9197

On 14.02.2022 14:11, Jane Malalane wrote:
> On 11/02/2022 11:46, Jan Beulich wrote:
>> [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachment=
s unless you have verified the sender and know the content is safe.
>>
>> On 11.02.2022 12:29, Roger Pau Monn=C3=A9 wrote:
>>> On Fri, Feb 11, 2022 at 10:06:48AM +0000, Jane Malalane wrote:
>>>> On 10/02/2022 10:03, Roger Pau Monn=C3=A9 wrote:
>>>>> On Mon, Feb 07, 2022 at 06:21:00PM +0000, Jane Malalane wrote:
>>>>>> diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs=
.c
>>>>>> index 7ab15e07a0..4060aef1bd 100644
>>>>>> --- a/xen/arch/x86/hvm/vmx/vmcs.c
>>>>>> +++ b/xen/arch/x86/hvm/vmx/vmcs.c
>>>>>> @@ -343,6 +343,15 @@ static int vmx_init_vmcs_config(bool bsp)
>>>>>>                MSR_IA32_VMX_PROCBASED_CTLS2, &mismatch);
>>>>>>        }
>>>>>>   =20
>>>>>> +    /* Check whether hardware supports accelerated xapic and x2apic=
. */
>>>>>> +    if ( bsp )
>>>>>> +    {
>>>>>> +        assisted_xapic_available =3D cpu_has_vmx_virtualize_apic_ac=
cesses;
>>>>>> +        assisted_x2apic_available =3D (cpu_has_vmx_apic_reg_virt ||
>>>>>> +                                     cpu_has_vmx_virtual_intr_deliv=
ery) &&
>>>>>> +                                    cpu_has_vmx_virtualize_x2apic_m=
ode;
>>>>>
>>>>> I've been think about this, and it seems kind of asymmetric that for
>>>>> xAPIC mode we report hw assisted support only with
>>>>> virtualize_apic_accesses available, while for x2APIC we require
>>>>> virtualize_x2apic_mode plus either apic_reg_virt or
>>>>> virtual_intr_delivery.
>>>>>
>>>>> I think we likely need to be more consistent here, and report hw
>>>>> assisted x2APIC support as long as virtualize_x2apic_mode is
>>>>> available.
>>>>>
>>>>> This will likely have some effect on patch 2 also, as you will have t=
o
>>>>> adjust vmx_vlapic_msr_changed.
>>>>>
>>>>> Thanks, Roger.
>>>>
>>>> Any other thoughts on this? As on one hand it is asymmetric but also
>>>> there isn't much assistance with only virtualize_x2apic_mode set as, i=
n
>>>> this case, a VM exit will be avoided only when trying to access the TP=
R
>>>> register.
>>>
>>> I've been thinking about this, and reporting hardware assisted
>>> x{2}APIC virtualization with just
>>> SECONDARY_EXEC_VIRTUALIZE_APIC_ACCESSES or
>>> SECONDARY_EXEC_VIRTUALIZE_X2APIC_MODE doesn't seem very helpful. While
>>> those provide some assistance to the VMM in order to handle APIC
>>> accesses, it will still require a trap into the hypervisor to handle
>>> most of the accesses.
>>>
>>> So maybe we should only report hardware assisted support when the
>>> mentioned features are present together with
>>> SECONDARY_EXEC_APIC_REGISTER_VIRT?
>>
>> Not sure - "some assistance" seems still a little better than none at al=
l.
>> Which route to go depends on what exactly we intend the bit to be used f=
or.
>>
> True. I intended this bit to be specifically for enabling=20
> assisted_x{2}apic. So, would it be inconsistent to report hardware=20
> assistance with just VIRTUALIZE_APIC_ACCESSES or VIRTUALIZE_X2APIC_MODE=20
> but still claim that x{2}apic is virtualized if no MSR accesses are=20
> intercepted with XEN_HVM_CPUID_X2APIC_VIRT (in traps.c) so that, as you=20
> say, the guest gets at least "some assistance" instead of none but we=20
> still claim x{2}apic virtualization when it is actually complete? Maybe=20
> I could also add a comment alluding to this in the xl documentation.

To rephrase my earlier point: Which kind of decisions are the consumer(s)
of us reporting hardware assistance going to take? In how far is there a
risk that "some assistance" is overall going to lead to a loss of
performance? I guess I'd need to see comment and actual code all in one
place ...

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:28:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:28:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272165.466962 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbOi-0003br-Ay; Mon, 14 Feb 2022 13:28:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272165.466962; Mon, 14 Feb 2022 13:28:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbOi-0003bk-7H; Mon, 14 Feb 2022 13:28:08 +0000
Received: by outflank-mailman (input) for mailman id 272165;
 Mon, 14 Feb 2022 13:28:07 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=YsDI=S5=epam.com=prvs=4044e07e7c=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nJbOh-0003bc-9r
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:28:07 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f099c663-8d99-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 14:28:05 +0100 (CET)
Received: from pps.filterd (m0174682.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 21EDRi7X020678;
 Mon, 14 Feb 2022 13:28:01 GMT
Received: from eur05-db8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2111.outbound.protection.outlook.com [104.47.17.111])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3e7q5h0795-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Mon, 14 Feb 2022 13:28:00 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM0PR03MB4676.eurprd03.prod.outlook.com (2603:10a6:208:bf::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.15; Mon, 14 Feb
 2022 13:27:56 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::fc4d:4749:5d1:eb73]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::fc4d:4749:5d1:eb73%4]) with mapi id 15.20.4975.018; Mon, 14 Feb 2022
 13:27:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f099c663-8d99-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=kjAtXN8Hk/DTTq09w8NoMykrOFjFMga0Z/7CqYagJ56V6oz9r3yoqXt1AuMgf+7lDlDk+5wW7XAEB/LlXTUPs2AROGuYBvhhgJjuReoggVECt1JEXDk4+FMOWuYr+cCJaiM2t6UAcxLwNWhnwZJ6PC1wXZvF0Xy0CbVWEb7l/WrZ5y/3dwXYUG68nI6+goy2E0TWCkISdAg6DOTuaKZWNkbUIinUXJEZaKLpsXVgA0HtppJXpdGOEAyfSM/Z9A4/A5EIsWTUxL+BCRA2ruvoesM78mJSfNLhGAEUpcGYAtF3btDAVfTIXxkjpPdfGtk8/3CEQ3+A+wxN5QKF8TtroA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ubQF1YpH9OniJe0kqJ2IukTE0bZys3ZXuX5Sqx17TbA=;
 b=Q/THBrbvg5YEjMGUBjO8eJDBwBBmE8qVgrx2teEn/7/PP13Bjhq7CUVCdkJnPZS5tg1+8Ero3ESsgwhEMgowZhwvddQ6qbNCyRSqHbYN3loY22sW66CCj2d6gWZ6qk5ytpjny9UeXrCRiO0MkVEmaP7lBcRMItIxbV8/hddW7Yoa8q5RvogBj9UDUbocG6reBoMwYkw2VC5Zk9ptBKp1s9HNQ4CcTeqrHnrRvnha5RJoxxPafzalFX5sDSYGcjf/nPXCSenprrwyECLwLNxvhEGwQSW9gUhqbyCPCEgZ5+PPok+ekYK8vjUmZN023d5xttQ3iKt0Vpk46j7+9ww5yQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ubQF1YpH9OniJe0kqJ2IukTE0bZys3ZXuX5Sqx17TbA=;
 b=N/uA+LdiqAmRuMRo+vjWkyYiR6XndHs7j2JqVl2TeIhGuuaz5t6u+T7d5Myf2K0H4I7noUF+e6Xm+f6P1jiSZk/uAgiymVkjKrAE1HQ37+2VHI6fS7woHqTRDlPPO6pGH6xJT9gJd48tlMcWQDLsDjDMNEt4P1458rP6ih25RX4rTeYWa/D53xLHDG8crIeLYJqjnFeSWS/L2SCySTChCJ5P6rm7i/RBkELrYJF3qHzgFdO3+aiaLC9CNHOZm4pnqW7fixk9E7NUNzbbvJ38wpUXeRl3D6NMvmv20b5Wy/FwdMwWiTciTH4iXNBH+m+WG299Ky0NKRrIEw8Ig/S/VQ==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?=
	<roger.pau@citrix.com>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH] vpci: introduce per-domain lock to protect vpci structure
Thread-Topic: [PATCH] vpci: introduce per-domain lock to protect vpci
 structure
Thread-Index: 
 AQHYHboQT3cBWYI1/EGunE7hOwop6ayM95MAgAD+qQCAAEaDAIAElIcAgAAQEwCAAAV1AIAABOQAgAABMICAAALZgIAAAzmAgAAWXYCAAARtAIAAAoIAgAABpIA=
Date: Mon, 14 Feb 2022 13:27:56 +0000
Message-ID: <ba901778-ce63-12f2-0a54-d56998090200@epam.com>
References: <20220209133627.959649-1-andr2000@gmail.com>
 <YgU6Snk8GTytJXZp@Air-de-Roger>
 <c4666570-666e-6680-5ec2-adf1da51ad06@epam.com>
 <YgZLEMW9US9QjjYG@Air-de-Roger>
 <33fb1095-64ed-29ef-ba6b-cbde21d941f8@epam.com>
 <YgowIg5MvTaf2zsR@Air-de-Roger>
 <d8389a90-00c8-b34a-8488-b0f3fc5bde1b@epam.com>
 <Ygo40L4dMPJjZKRF@Air-de-Roger>
 <746860aa-c403-1eca-0a75-587c5d10c8c2@epam.com>
 <Ygo8M3Y6BLzljn15@Air-de-Roger>
 <114b8578-ee13-b67d-e282-d060187ef509@epam.com>
 <06baf0c8-d7d2-50b8-ea8f-1d422ceac728@suse.com>
 <6ccc7add-c13e-555f-b341-ce37118746e5@epam.com>
 <f0e202dd-1f6e-4aac-1381-a64a7fd12270@suse.com>
In-Reply-To: <f0e202dd-1f6e-4aac-1381-a64a7fd12270@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: e0496822-7f84-4e73-4385-08d9efbdd005
x-ms-traffictypediagnostic: AM0PR03MB4676:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM0PR03MB4676B1F018C98DFD1B4E8634E7339@AM0PR03MB4676.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 dNDf7jnl7bVPokk6nEHj006FZkFrre1eM4QhRhrCJx07QVxYDNpX42+NVEiRubQXsimXOVLrqmNf2LzUNKPuNFURclvuj2CdtNcDGvPw3ba//LMS1fBaA397igMShLaef3ZtqDEiaY5HlGrlSicFBBeOJJ01S+cMuRawkW78M8joClElHhDSEJKX202InPXfGTkeYRvy9xVb/awlLAbu26eQ6wWSrhwyDIl7zVVNwMIiPtDKOmWs7yH91TJ+tPjzYTDZyzlDJbVoNmFDfUyjhkGv6JE0xMEPuq2ii4X6DYeRaTxiVaZWzTDG+14ojbxMp9M7RAOkOKad7SmcnukRpJucRZGJRBa1qMh2HWCgT024hu7vmbSmvOWpEA40lGNQGlUzhamRseVlQNa2x3vEge1jL9iH6AkEl1gwtg7iXJPrnqf1owjhkMgRzC1mZzUkw9Ilb+bV2FRKzah7TOG85wswuhiB6QibhlNcmJjaN+R2ll2URTL+tq0nXKTknhMZzNkiBeqF4HYWWyNyTs7IMPYSdcl2jYRacgGTJFySaXQmHhEt9T8wCkkgkF+zGyicSvuPv0yjfPe8ec7hlpcUA7ijhKEioQd1RM5XNU7VATo830Fqb47a6Q529uTHnsZ1wK4RSVDC+rqac7Gkm12gYxMfxZT+RTqKrDkcT+f5NdTKLahxEMXB2yy+8InhSdUDj+RTVGwBzBfGenPfsST5DP4ZY5EN18GR5GshebVMHDs+vN+ljlXNpZIOFGuiIIqp
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6916009)(316002)(54906003)(186003)(55236004)(6512007)(83380400001)(53546011)(6506007)(107886003)(86362001)(2616005)(31696002)(6486002)(508600001)(71200400001)(26005)(36756003)(76116006)(64756008)(31686004)(66556008)(66476007)(66446008)(66946007)(91956017)(4326008)(122000001)(2906002)(5660300002)(8936002)(38100700002)(38070700005)(8676002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?d2RvQ0o5SFRseVNaakU4UEZpTDViRmkvZlVsK0wvQkJncDJKY282bjlnUXh0?=
 =?utf-8?B?YzB3S0ZaM2dIY3ZFWkNnd1hyQVR0bm1EQTErUXMwK3k0dnJQSnc4YjdtVjNP?=
 =?utf-8?B?YVpFc0JLZDFabkFnd0QrUEhRcVlLRzVYdTh4eW5IYm15UlkvMVFyaGI1T3dB?=
 =?utf-8?B?bm5ZVUpRQXVXMDdSQmwycVJyOHBEd2E1SlBzTkkyWHpmL0ZIYk9xYzUwYTNS?=
 =?utf-8?B?dmoySDgyWmNsV2lRbmZHUnBGeXMza05nVzRXNHZ6TlVzTXFVaFZUY1pYeU05?=
 =?utf-8?B?TEE3eFI4K2Y3UGhYOHlGNW1BY2ZCRWtLOEZNUWJabm5ZS3MwVVNvVTFxMkha?=
 =?utf-8?B?anVkZEQvSUlGalZOM0lLNjJOQk1odVJRaDZ1VXg4RmgweU8zTlEySDlGb1dl?=
 =?utf-8?B?UThESGEvNGxLOVJHNHNuRFFsYmhPSU8yT3RSdlNmUlEySnFsSE1OQnRZUEQv?=
 =?utf-8?B?UmZuVmxEWjU5a2hIMDBYNTl1UGJ1RHlpNGFmYTF1bUNsRGxwYnFtU2gyRGdD?=
 =?utf-8?B?SG9Rd0JLcjA3ZXVIVTRMdGZaWjZRSTlnakFIQ0l0TlRvRUZOUDdWYUgvMlBu?=
 =?utf-8?B?T2duY2NIeVJwTkRmZDN4V2FFNkg4YUxzVVErTUdlV3FvUEEyVFcwbmw1ZVFt?=
 =?utf-8?B?Rm40RWR5U2o5TGl0R0cvTnFUZ0tZMndOcHZFcXl6UHhsbkl6SjBiQ1hVV1pn?=
 =?utf-8?B?dWVBWUJ3U1BQNFdBSVphY2JlR2JwNmJESXMyaCtyeVNQMTFHSVdqeVlGUVcz?=
 =?utf-8?B?RCtCMzVsSGwzcVExdUVzWTBFcDdDMW5WZmpTODgyTGpGUEZ1dklZZEE1NFUx?=
 =?utf-8?B?WWRmb3BneHZ2V04walpQNCt0TmV2b1hUb1pCTWtPQ0NmMGRYVVV3eStOTkkw?=
 =?utf-8?B?REVucG44Q1owZlNhdWluMi9vSlVGalNCanRXNHVMMWVnSDA0a3FrRSt4VW9M?=
 =?utf-8?B?TDI5REFSTU1lLzdDS2RxNkRRdzQrOVRBVEhJc29tRTFRbldkaVhGK1NIL1ly?=
 =?utf-8?B?cStURjdiZytwVU9DWG9WTWtRc0FkUkdlTGMyT3pxZzE0MGg4OTJ5bGVQdUR4?=
 =?utf-8?B?dkNtRWw5V042Zmh3ZXhYTzRHYUdqeHRjbWYrQTBlVXMvSW5KMXNGZitsbVRh?=
 =?utf-8?B?WEk3Z2k2Q0JhZzhWb24vaEJIcVV4VzJJbDQ4WTZGQmhYc1pkQStuZ2s4SFZN?=
 =?utf-8?B?ZTRmb2ZDRjB5am13ZHExcXZWYmlVWHhXb2hiT1krUXJBYk91bmtMVUltYlJC?=
 =?utf-8?B?U1ZUMUppQWVUUldYVytrclNUaFloemY4cTZTTXd5K0dJVnl2R0YrRFNValdw?=
 =?utf-8?B?WFgwRjBZVzV2aUZiUERra2tpbk9YZDVCb1dLbEJzVXpISGF4TWhtYWNlYms3?=
 =?utf-8?B?bTlaSWQ5UmtwY282WFZEWGU5dXNNZjRTVmVTdUdQQUJaZ3F1djNHNXE4UWJs?=
 =?utf-8?B?eHBwWFZ4SVJyM3dLWEVBYzhGSVYzU2xXMlk1REFPUnZtb1NURlhWcEsyN1Rn?=
 =?utf-8?B?RzVYd1pNcUIxRHRtMlVFZVovZ1NxNGxMa1BjQ1d5RWJYbllJbjZtUFhrSFUw?=
 =?utf-8?B?WUdTM0hVYk9RMG5xejFTNFE5ZWt0Rm5jTno4T2NYdkJJVzN5MXE0SEpYQ2Qw?=
 =?utf-8?B?TkszT3lrUHlTclRFOVFMU05RcGpHYjlHSmdOZTB1blAxT3FlWVlibEgvSmRo?=
 =?utf-8?B?cFJhUzRlZEZKOHMxaks5ZjJXMlJxem82a1FYNE96Y09BaWtzNkltaGNkcnh1?=
 =?utf-8?B?bmF1bEFvNUhNT0g2SnI2Y3luc214aW1tckZpaDg0QnZWOW1IMjdpMHYyNzQ0?=
 =?utf-8?B?UzJacXVCSXhXQjlOUHRtV0tES2ppa1Vwa3BUZjBQeXJMWkF2NW9IWUZDQUFx?=
 =?utf-8?B?NVNJY3daT2JZRVlaODFLZFhkMFAxbTdsbTN1dGVRMmR3NmZVbEFDVWJ4L28r?=
 =?utf-8?B?WXZCSTM3bktmVG03U3pUc1daT0hDUm9wZEFEdFB4ZjRQL1JPdE9INmM2bWIx?=
 =?utf-8?B?NXlyVmlSUGo2bDgwQlZVaXhNOWVTQkdmU09OVnVVT1EyT3YyODRPRWhoaVJX?=
 =?utf-8?B?Vkk0aSs2dVJ3SHlVYlRYd3NiTjQxTmRuYWxjMVJ1NC9LQTNSb2hkM2QzTCtJ?=
 =?utf-8?B?eTliZ1I1WmNTdEN5VVBHVFRzVkV2TE45ZUFpaVFLcE5IRzc4b21UcHBnS3Fl?=
 =?utf-8?B?dGZKemtDYjJiS0NmTktTTTNDRUNreVprRTcyaXBCb253TktJSzdsMEVRVk1q?=
 =?utf-8?B?Nm9UbU5zaW50M1h0eDhQbWZMUC9RS01xT1JnV3p0WnZ1Mzc1RzNnNE53QXJB?=
 =?utf-8?B?a3NYQTFyUUtoWVYrb3lVNUVOazV2a1hXcEg3dHhqWGYxTUpjR0REdz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <B9DED8D43C3486469D90CF2B0896090C@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e0496822-7f84-4e73-4385-08d9efbdd005
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Feb 2022 13:27:56.6093
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 1GQMmUQ6DT0BhPAC17i9QXcC7Ba71KfhAJJed9h3vBwDTGAbwxXOG0Zt9IQRb0QSSjEa61R9CEF+qBH7Y6+j7HlIwqTcxfSwNBf3+Vcg4C3eKmg8To1EoDGTtgo2AQl2
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB4676
X-Proofpoint-GUID: oBmZmtH5vrlL8C3MuAferoqFsE9AQgcF
X-Proofpoint-ORIG-GUID: oBmZmtH5vrlL8C3MuAferoqFsE9AQgcF
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-14_06,2022-02-14_03,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501
 suspectscore=0 malwarescore=0 mlxlogscore=999 clxscore=1015 bulkscore=0
 lowpriorityscore=0 phishscore=0 mlxscore=0 impostorscore=0 spamscore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202140082

DQoNCk9uIDE0LjAyLjIyIDE1OjIyLCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMTQuMDIuMjAy
MiAxNDoxMywgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+Pg0KPj4gT24gMTQuMDIu
MjIgMTQ6NTcsIEphbiBCZXVsaWNoIHdyb3RlOg0KPj4+IE9uIDE0LjAyLjIwMjIgMTI6MzcsIE9s
ZWtzYW5kciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4+PiBPbiAxNC4wMi4yMiAxMzoyNSwgUm9n
ZXIgUGF1IE1vbm7DqSB3cm90ZToNCj4+Pj4+IE9uIE1vbiwgRmViIDE0LCAyMDIyIGF0IDExOjE1
OjI3QU0gKzAwMDAsIE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4+Pj4+IE9uIDE0
LjAyLjIyIDEzOjExLCBSb2dlciBQYXUgTW9ubsOpIHdyb3RlOg0KPj4+Pj4+PiBPbiBNb24sIEZl
YiAxNCwgMjAyMiBhdCAxMDo1Mzo0M0FNICswMDAwLCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyB3
cm90ZToNCj4+Pj4+Pj4+IE9uIDE0LjAyLjIyIDEyOjM0LCBSb2dlciBQYXUgTW9ubsOpIHdyb3Rl
Og0KPj4+Pj4+Pj4+IE9uIE1vbiwgRmViIDE0LCAyMDIyIGF0IDA5OjM2OjM5QU0gKzAwMDAsIE9s
ZWtzYW5kciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4+Pj4+Pj4+PiBPbiAxMS4wMi4yMiAxMzo0
MCwgUm9nZXIgUGF1IE1vbm7DqSB3cm90ZToNCj4+Pj4+Pj4+Pj4+ICsNCj4+Pj4+Pj4+Pj4+Pj4+
ICAgICAgICAgICAgIGZvciAoIGkgPSAwOyBpIDwgbXNpeC0+bWF4X2VudHJpZXM7IGkrKyApDQo+
Pj4+Pj4+Pj4+Pj4+PiAgICAgICAgICAgICB7DQo+Pj4+Pj4+Pj4+Pj4+PiAgICAgICAgICAgICAg
ICAgY29uc3Qgc3RydWN0IHZwY2lfbXNpeF9lbnRyeSAqZW50cnkgPSAmbXNpeC0+ZW50cmllc1tp
XTsNCj4+Pj4+Pj4+Pj4+Pj4gU2luY2UgdGhpcyBmdW5jdGlvbiBpcyBub3cgY2FsbGVkIHdpdGgg
dGhlIHBlci1kb21haW4gcndsb2NrIHJlYWQNCj4+Pj4+Pj4+Pj4+Pj4gbG9ja2VkIGl0J3MgbGlr
ZWx5IG5vdCBhcHByb3ByaWF0ZSB0byBjYWxsIHByb2Nlc3NfcGVuZGluZ19zb2Z0aXJxcw0KPj4+
Pj4+Pj4+Pj4+PiB3aGlsZSBob2xkaW5nIHN1Y2ggbG9jayAoY2hlY2sgYmVsb3cpLg0KPj4+Pj4+
Pj4+Pj4+IFlvdSBhcmUgcmlnaHQsIGFzIGl0IGlzIHBvc3NpYmxlIHRoYXQ6DQo+Pj4+Pj4+Pj4+
Pj4NCj4+Pj4+Pj4+Pj4+PiBwcm9jZXNzX3BlbmRpbmdfc29mdGlycXMgLT4gdnBjaV9wcm9jZXNz
X3BlbmRpbmcgLT4gcmVhZF9sb2NrDQo+Pj4+Pj4+Pj4+Pj4NCj4+Pj4+Pj4+Pj4+PiBFdmVuIG1v
cmUsIHZwY2lfcHJvY2Vzc19wZW5kaW5nIG1heSBhbHNvDQo+Pj4+Pj4+Pj4+Pj4NCj4+Pj4+Pj4+
Pj4+PiByZWFkX3VubG9jayAtPiB2cGNpX3JlbW92ZV9kZXZpY2UgLT4gd3JpdGVfbG9jaw0KPj4+
Pj4+Pj4+Pj4+DQo+Pj4+Pj4+Pj4+Pj4gaW4gaXRzIGVycm9yIHBhdGguIFNvLCBhbnkgaW52b2Nh
dGlvbiBvZiBwcm9jZXNzX3BlbmRpbmdfc29mdGlycXMNCj4+Pj4+Pj4+Pj4+PiBtdXN0IG5vdCBo
b2xkIGQtPnZwY2lfcndsb2NrIGF0IGxlYXN0Lg0KPj4+Pj4+Pj4+Pj4+DQo+Pj4+Pj4+Pj4+Pj4g
QW5kIGFsc28gd2UgbmVlZCB0byBjaGVjayB0aGF0IHBkZXYtPnZwY2kgd2FzIG5vdCByZW1vdmVk
DQo+Pj4+Pj4+Pj4+Pj4gaW4gYmV0d2VlbiBvciAqcmUtY3JlYXRlZCoNCj4+Pj4+Pj4+Pj4+Pj4g
V2Ugd2lsbCBsaWtlbHkgbmVlZCB0byByZS1pdGVyYXRlIG92ZXIgdGhlIGxpc3Qgb2YgcGRldnMg
YXNzaWduZWQgdG8NCj4+Pj4+Pj4+Pj4+Pj4gdGhlIGRvbWFpbiBhbmQgYXNzZXJ0IHRoYXQgdGhl
IHBkZXYgaXMgc3RpbGwgYXNzaWduZWQgdG8gdGhlIHNhbWUNCj4+Pj4+Pj4+Pj4+Pj4gZG9tYWlu
Lg0KPj4+Pj4+Pj4+Pj4+IFNvLCBkbyB5b3UgbWVhbiBhIHBhdHRlcm4gbGlrZSB0aGUgYmVsb3cg
c2hvdWxkIGJlIHVzZWQgYXQgYWxsDQo+Pj4+Pj4+Pj4+Pj4gcGxhY2VzIHdoZXJlIHdlIG5lZWQg
dG8gY2FsbCBwcm9jZXNzX3BlbmRpbmdfc29mdGlycXM/DQo+Pj4+Pj4+Pj4+Pj4NCj4+Pj4+Pj4+
Pj4+PiByZWFkX3VubG9jaw0KPj4+Pj4+Pj4+Pj4+IHByb2Nlc3NfcGVuZGluZ19zb2Z0aXJxcw0K
Pj4+Pj4+Pj4+Pj4+IHJlYWRfbG9jaw0KPj4+Pj4+Pj4+Pj4+IHBkZXYgPSBwY2lfZ2V0X3BkZXZf
YnlfZG9tYWluKGQsIHNiZGYuc2VnLCBzYmRmLmJ1cywgc2JkZi5kZXZmbik7DQo+Pj4+Pj4+Pj4+
Pj4gaWYgKCBwZGV2ICYmIHBkZXYtPnZwY2kgJiYgaXNfdGhlX3NhbWVfdnBjaShwZGV2LT52cGNp
KSApDQo+Pj4+Pj4+Pj4+Pj4gPGNvbnRpbnVlIHByb2Nlc3Npbmc+DQo+Pj4+Pj4+Pj4+PiBTb21l
dGhpbmcgYWxvbmcgdGhvc2UgbGluZXMuIFlvdSBsaWtlbHkgbmVlZCB0byBjb250aW51ZSBpdGVy
YXRlIHVzaW5nDQo+Pj4+Pj4+Pj4+PiBmb3JfZWFjaF9wZGV2Lg0KPj4+Pj4+Pj4+PiBIb3cgZG8g
d2UgdGVsbCBpZiBwZGV2LT52cGNpIGlzIHRoZSBzYW1lPyBKYW4gaGFzIGFscmVhZHkgYnJvdWdo
dA0KPj4+Pj4+Pj4+PiB0aGlzIHF1ZXN0aW9uIGJlZm9yZSBbMV0gYW5kIEkgd2FzIGFib3V0IHRv
IHVzZSBzb21lIElEIGZvciB0aGF0IHB1cnBvc2U6DQo+Pj4+Pj4+Pj4+IHBkZXYtPnZwY2ktPmlk
ID0gZC0+dnBjaV9pZCsrIGFuZCB0aGVuIHdlIHVzZSBwZGV2LT52cGNpLT5pZMKgIGZvciBjaGVj
a3MNCj4+Pj4+Pj4+PiBHaXZlbiB0aGlzIGlzIGEgZGVidWcgbWVzc2FnZSBJIHdvdWxkIGJlIE9L
IHdpdGgganVzdCBkb2luZyB0aGUNCj4+Pj4+Pj4+PiBtaW5pbWFsIGNoZWNrcyB0byBwcmV2ZW50
IFhlbiBmcm9tIGNyYXNoaW5nIChpZTogcGRldi0+dnBjaSBleGlzdHMpDQo+Pj4+Pj4+Pj4gYW5k
IHRoYXQgdGhlIHJlc3VtZSBNU0kgZW50cnkgaXMgbm90IHBhc3QgdGhlIGN1cnJlbnQgbGltaXQu
IE90aGVyd2lzZQ0KPj4+Pj4+Pj4+IGp1c3QgcHJpbnQgYSBtZXNzYWdlIGFuZCBtb3ZlIG9uIHRv
IHRoZSBuZXh0IGRldmljZS4NCj4+Pj4+Pj4+IEFncmVlLCBJIHNlZSBubyBiaWcgaXNzdWUgKHBy
b2JhYmx5KSBpZiB3ZSBhcmUgbm90IGFibGUgdG8gcHJpbnQNCj4+Pj4+Pj4+DQo+Pj4+Pj4+PiBI
b3cgYWJvdXQgdGhpcyBvbmU6DQo+Pj4+Pj4+Pg0KPj4+Pj4+Pj4gZGlmZiAtLWdpdCBhL3hlbi9k
cml2ZXJzL3ZwY2kvaGVhZGVyLmMgYi94ZW4vZHJpdmVycy92cGNpL2hlYWRlci5jDQo+Pj4+Pj4+
PiBpbmRleCA4MDlhNmI0NzczZTEuLjUwMzczZjA0ZGE4MiAxMDA2NDQNCj4+Pj4+Pj4+IC0tLSBh
L3hlbi9kcml2ZXJzL3ZwY2kvaGVhZGVyLmMNCj4+Pj4+Pj4+ICsrKyBiL3hlbi9kcml2ZXJzL3Zw
Y2kvaGVhZGVyLmMNCj4+Pj4+Pj4+IEBAIC0xNzEsMTAgKzE3MSwzMSBAQCBzdGF0aWMgaW50IF9f
aW5pdCBhcHBseV9tYXAoc3RydWN0IGRvbWFpbiAqZCwgY29uc3Qgc3RydWN0IHBjaV9kZXYgKnBk
ZXYsDQo+Pj4+Pj4+PiAgICAgIMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgIHN0cnVjdCByYW5nZXNldCAqbWVtLCB1aW50MTZfdCBjbWQpDQo+
Pj4+Pj4+PiAgICAgIMKgew0KPj4+Pj4+Pj4gICAgICDCoMKgwqDCoCBzdHJ1Y3QgbWFwX2RhdGEg
ZGF0YSA9IHsgLmQgPSBkLCAubWFwID0gdHJ1ZSB9Ow0KPj4+Pj4+Pj4gK8KgwqDCoCBwY2lfc2Jk
Zl90IHNiZGYgPSBwZGV2LT5zYmRmOw0KPj4+Pj4+Pj4gICAgICDCoMKgwqDCoCBpbnQgcmM7DQo+
Pj4+Pj4+Pg0KPj4+Pj4+Pj4gKyBBU1NFUlQocndfaXNfd3JpdGVfbG9ja2VkKCZwZGV2LT5kb21h
aW4tPnZwY2lfcndsb2NrKSk7DQo+Pj4+Pj4+PiArDQo+Pj4+Pj4+PiAgICAgIMKgwqDCoMKgIHdo
aWxlICggKHJjID0gcmFuZ2VzZXRfY29uc3VtZV9yYW5nZXMobWVtLCBtYXBfcmFuZ2UsICZkYXRh
KSkgPT0gLUVSRVNUQVJUICkNCj4+Pj4+Pj4+ICvCoMKgwqAgew0KPj4+Pj4+Pj4gKw0KPj4+Pj4+
Pj4gK8KgwqDCoMKgwqDCoMKgIC8qDQo+Pj4+Pj4+PiArwqDCoMKgwqDCoMKgwqDCoCAqIHByb2Nl
c3NfcGVuZGluZ19zb2Z0aXJxcyBtYXkgdHJpZ2dlciB2cGNpX3Byb2Nlc3NfcGVuZGluZyB3aGlj
aA0KPj4+Pj4+Pj4gK8KgwqDCoMKgwqDCoMKgwqAgKiBtYXkgbmVlZCB0byBhY3F1aXJlIHBkZXYt
PmRvbWFpbi0+dnBjaV9yd2xvY2sgaW4gcmVhZCBtb2RlLg0KPj4+Pj4+Pj4gK8KgwqDCoMKgwqDC
oMKgwqAgKi8NCj4+Pj4+Pj4+ICvCoMKgwqDCoMKgwqDCoCB3cml0ZV91bmxvY2soJnBkZXYtPmRv
bWFpbi0+dnBjaV9yd2xvY2spOw0KPj4+Pj4+Pj4gICAgICDCoMKgwqDCoMKgwqDCoMKgIHByb2Nl
c3NfcGVuZGluZ19zb2Z0aXJxcygpOw0KPj4+Pj4+Pj4gK8KgwqDCoMKgwqDCoMKgIHdyaXRlX2xv
Y2soJnBkZXYtPmRvbWFpbi0+dnBjaV9yd2xvY2spOw0KPj4+Pj4+Pj4gKw0KPj4+Pj4+Pj4gK8Kg
wqDCoMKgwqDCoMKgIC8qIENoZWNrIGlmIHBkZXYgc3RpbGwgZXhpc3RzIGFuZCB2UENJIHdhcyBu
b3QgcmVtb3ZlZCBvciByZS1jcmVhdGVkLiAqLw0KPj4+Pj4+Pj4gK8KgwqDCoMKgwqDCoMKgIGlm
IChwY2lfZ2V0X3BkZXZfYnlfZG9tYWluKGQsIHNiZGYuc2VnLCBzYmRmLmJ1cywgc2JkZi5kZXZm
bikgIT0gcGRldikNCj4+Pj4+Pj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGlmICggdnBjaSBp
cyBOT1QgdGhlIHNhbWUgKQ0KPj4+Pj4+Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgew0KPj4+
Pj4+Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCByYyA9IDA7DQo+Pj4+Pj4+PiAr
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGJyZWFrOw0KPj4+Pj4+Pj4gK8KgwqDCoMKg
wqDCoMKgwqDCoMKgwqAgfQ0KPj4+Pj4+Pj4gK8KgwqDCoCB9DQo+Pj4+Pj4+PiArDQo+Pj4+Pj4+
PiAgICAgIMKgwqDCoMKgIHJhbmdlc2V0X2Rlc3Ryb3kobWVtKTsNCj4+Pj4+Pj4+ICAgICAgwqDC
oMKgwqAgaWYgKCAhcmMgKQ0KPj4+Pj4+Pj4gICAgICDCoMKgwqDCoMKgwqDCoMKgIG1vZGlmeV9k
ZWNvZGluZyhwZGV2LCBjbWQsIGZhbHNlKTsNCj4+Pj4+Pj4+DQo+Pj4+Pj4+PiBUaGlzIG9uZSBh
bHNvIHdhbnRzIHByb2Nlc3NfcGVuZGluZ19zb2Z0aXJxcyB0byBydW4gc28gaXQgKm1pZ2h0Kg0K
Pj4+Pj4+Pj4gd2FudCBwZGV2IGFuZCB2cGNpIGNoZWNrcy4gQnV0IGF0IHRoZSBzYW1lIHRpbWUg
YXBwbHlfbWFwIHJ1bnMNCj4+Pj4+Pj4+IGF0ICggc3lzdGVtX3N0YXRlIDwgU1lTX1NUQVRFX2Fj
dGl2ZSApLCBzbyBkZWZlcl9tYXAgd29uJ3QgYmUNCj4+Pj4+Pj4+IHJ1bm5pbmcgeWV0LCB0aHVz
IG5vIHZwY2lfcHJvY2Vzc19wZW5kaW5nIGlzIHBvc3NpYmxlIHlldCAoaW4gdGVybXMNCj4+Pj4+
Pj4+IGl0IGhhcyBzb21ldGhpbmcgdG8gZG8geWV0KS4gU28sIEkgdGhpbmsgd2UganVzdCBuZWVk
Og0KPj4+Pj4+Pj4NCj4+Pj4+Pj4+ICAgICAgwqDCoMKgwqDCoMKgwqAgd3JpdGVfdW5sb2NrKCZw
ZGV2LT5kb21haW4tPnZwY2lfcndsb2NrKTsNCj4+Pj4+Pj4+ICAgICAgwqDCoMKgwqDCoMKgwqAg
cHJvY2Vzc19wZW5kaW5nX3NvZnRpcnFzKCk7DQo+Pj4+Pj4+PiAgICAgIMKgwqDCoMKgwqDCoMKg
IHdyaXRlX2xvY2soJnBkZXYtPmRvbWFpbi0+dnBjaV9yd2xvY2spOw0KPj4+Pj4+Pj4NCj4+Pj4+
Pj4+IGFuZCB0aGlzIHNob3VsZCBiZSBlbm91Z2gNCj4+Pj4+Pj4gR2l2ZW4gdGhlIGNvbnRleHQg
YXBwbHlfbWFwIGlzIGNhbGxlZCBmcm9tIChkb20wIHNwZWNpZmljIGluaXQgY29kZSksDQo+Pj4+
Pj4+IHRoZXJlJ3Mgbm8gbmVlZCB0byBjaGVjayBmb3IgdGhlIHBkZXYgdG8gc3RpbGwgZXhpdHMs
IG9yIHdoZXRoZXIgdnBjaQ0KPj4+Pj4+PiBoYXMgYmVlbiByZWNyZWF0ZWQsIGFzIGl0J3Mgbm90
IHBvc3NpYmxlLiBKdXN0IGFkZCBhIGNvbW1lbnQgdG8NCj4+Pj4+Pj4gZXhwbGljaXRseSBub3Rl
IHRoYXQgdGhlIGNvbnRleHQgb2YgdGhlIGZ1bmN0aW9uIGlzIHNwZWNpYWwsIGFuZCB0aHVzDQo+
Pj4+Pj4+IHRoZXJlJ3Mgbm8gcG9zc2liaWxpdHkgb2YgZWl0aGVyIHRoZSBkZXZpY2Ugb3IgdnBj
aSBnb2luZyBhd2F5Lg0KPj4+Pj4+IERvZXMgaXQgcmVhbGx5IG5lZWQgd3JpdGVfdW5sb2NrL3dy
aXRlX2xvY2sgZ2l2ZW4gdGhlIGNvbnRleHQ/Li4uDQo+Pj4+PiBJIHRoaW5rIGl0J3MgYmFkIHBy
YWN0aWNlIHRvIGNhbGwgcHJvY2Vzc19wZW5kaW5nX3NvZnRpcnFzIHdoaWxlDQo+Pj4+PiBob2xk
aW5nIGFueSBsb2Nrcy4gVGhpcyBpcyBhIHZlcnkgc3BlY2lmaWMgY29udGV4dCBzbyBpdCdzIGxp
a2VseSBmaW5lDQo+Pj4+PiB0byBub3QgZHJvcCB0aGUgbG9jaywgYnV0IHdvdWxkIHN0aWxsIHNl
ZW0gaW5jb3JyZWN0IHRvIG1lLg0KPj4+PiBPaw0KPj4+Pj4+IEkgdGhpbmsgaXQgZG9lc24ndCBh
cyB0aGVyZSBpcyBubyBjaGFuY2UgZGVmZXJfbWFwIGlzIGNhbGxlZCwgdGh1cw0KPj4+Pj4+IHBy
b2Nlc3NfcGVuZGluZ19zb2Z0aXJxcyAtPiB2cGNpX3Byb2Nlc3NfcGVuZGluZyAtPiByZWFkX2xv
Y2sNCj4+Pj4+IEluZGVlZCwgdGhlcmUncyBubyBjaGFuY2Ugb2YgdGhhdCBiZWNhdXNlIHByb2Nl
c3NfcGVuZGluZ19zb2Z0aXJxcw0KPj4+Pj4gd2lsbCBuZXZlciB0cnkgdG8gZG8gYSBzY2hlZHVs
aW5nIG9wZXJhdGlvbiB0aGF0IHdvdWxkIHJlc3VsdCBpbiBvdXINCj4+Pj4+IGNvbnRleHQgYmVp
bmcgc2NoZWR1bGVkIG91dC4NCj4+Pj4gICAgwqDCoMKgIHdoaWxlICggKHJjID0gcmFuZ2VzZXRf
Y29uc3VtZV9yYW5nZXMobWVtLCBtYXBfcmFuZ2UsICZkYXRhKSkgPT0gLUVSRVNUQVJUICkNCj4+
Pj4gICAgwqDCoMKgIHsNCj4+Pj4gICAgwqDCoMKgwqDCoMKgwqAgLyoNCj4+Pj4gICAgwqDCoMKg
wqDCoMKgwqDCoCAqIEZJWE1FOiBHaXZlbiB0aGUgY29udGV4dCBhcHBseV9tYXAgaXMgY2FsbGVk
IGZyb20gKGRvbTAgc3BlY2lmaWMNCj4+Pj4gICAgwqDCoMKgwqDCoMKgwqDCoCAqIGluaXQgY29k
ZSBhdCBzeXN0ZW1fc3RhdGUgPCBTWVNfU1RBVEVfYWN0aXZlKSBpdCBpcyBub3Qgc3RyaWN0bHkN
Cj4+Pj4gICAgwqDCoMKgwqDCoMKgwqDCoCAqIHJlcXVpcmVkIHRoYXQgcGRldi0+ZG9tYWluLT52
cGNpX3J3bG9jayBpcyB1bmxvY2tlZCBiZWZvcmUgY2FsbGluZw0KPj4+PiAgICDCoMKgwqDCoMKg
wqDCoMKgICogcHJvY2Vzc19wZW5kaW5nX3NvZnRpcnFzIGFzIHRoZXJlIGlzIG5vIGNvbnRlbnRp
b24gcG9zc2libGUgYmV0d2Vlbg0KPj4+PiAgICDCoMKgwqDCoMKgwqDCoMKgICogdGhpcyBjb2Rl
IGFuZCB2cGNpX3Byb2Nlc3NfcGVuZGluZyB0cnlpbmcgdG8gYWNxdWlyZSB0aGUgbG9jayBpbg0K
Pj4+PiAgICDCoMKgwqDCoMKgwqDCoMKgICogcmVhZCBtb2RlLiBCdXQgcnVubmluZyBwcm9jZXNz
X3BlbmRpbmdfc29mdGlycXMgd2l0aCBhbnkgbG9jayBoZWxkDQo+Pj4+ICAgIMKgwqDCoMKgwqDC
oMKgwqAgKiBkb2Vzbid0IHNlZW0gdG8gYmUgYSBnb29kIHByYWN0aWNlLCBzbyBkcm9wIHRoZSBs
b2NrIGFuZCByZS1hY3F1aXJlDQo+Pj4+ICAgIMKgwqDCoMKgwqDCoMKgwqAgKiBpdCByaWdodCBh
Z2Fpbi4NCj4+Pj4gICAgwqDCoMKgwqDCoMKgwqDCoCAqLw0KPj4+PiAgICDCoMKgwqDCoMKgwqDC
oCB3cml0ZV91bmxvY2soJnBkZXYtPmRvbWFpbi0+dnBjaV9yd2xvY2spOw0KPj4+PiAgICDCoMKg
wqDCoMKgwqDCoCBwcm9jZXNzX3BlbmRpbmdfc29mdGlycXMoKTsNCj4+Pj4gICAgwqDCoMKgwqDC
oMKgwqAgd3JpdGVfbG9jaygmcGRldi0+ZG9tYWluLT52cGNpX3J3bG9jayk7DQo+Pj4+ICAgIMKg
wqDCoCB9DQo+Pj4gSSdtIGFmcmFpZCB0aGF0J3MgbWlzbGVhZGluZyBhdCBiZXN0LiBhcHBseV9t
YXAoKSBpcyBtZXJlbHkgYSBzcGVjaWZpYw0KPj4+IGV4YW1wbGUgd2hlcmUgeW91IGtub3cgdGhl
IGxvY2sgaXMgZ29pbmcgdG8gYmUgdGFrZW4uIEJ1dCByZWFsbHkgYW55DQo+Pj4gc29mdGlycSBo
YW5kbGVyIGNvdWxkIGJlIGFjcXVpcmluZyBhbnkgbG9jaywgc28gcmVxdWVzdGluZyB0byBwcm9j
ZXNzDQo+Pj4gc29mdGlycXMgY2Fubm90IGV2ZXIgYmUgZG9uZSB3aXRoIGFueSBsb2NrIGhlbGQu
DQo+Pj4NCj4+PiBXaGF0IHlvdSBpbnN0ZWFkIHdhbnQgdG8gZXhwbGFpbiBpcyB3aHksIGFmdGVy
IHJlLWFjcXVpcmluZyB0aGUgbG9jaywNCj4+PiBubyBmdXJ0aGVyIGNoZWNraW5nIGlzIG5lZWRl
ZCBmb3IgcG90ZW50aWFsbHkgY2hhbmdlZCBzdGF0ZS4NCj4+IEhvdyBhYm91dDoNCj4+DQo+PiAv
Kg0KPj4gICDCoCogRklYTUU6IEdpdmVuIHRoZSBjb250ZXh0IGFwcGx5X21hcCBpcyBjYWxsZWQg
ZnJvbSAoZG9tMCBzcGVjaWZpYw0KPj4gICDCoCogaW5pdCBjb2RlIGF0IHN5c3RlbV9zdGF0ZSA8
IFNZU19TVEFURV9hY3RpdmUpIHRoZXJlIGlzIG5vIGNvbnRlbnRpb24NCj4+ICAgwqAqIHBvc3Np
YmxlIGJldHdlZW4gdGhpcyBjb2RlIGFuZCB2cGNpX3Byb2Nlc3NfcGVuZGluZyB0cnlpbmcgdG8g
YWNxdWlyZQ0KPj4gICDCoCogdGhlIGxvY2sgaW4gcmVhZCBtb2RlIGFuZCBkZXN0cm95IHBkZXYt
PnZwY2kgaW4gaXRzIGVycm9yIHBhdGguDQo+PiAgIMKgKiBOZWl0aGVyIHBkZXYgbWF5IGJlIGRp
c3Bvc2VkIHlldCwgc28gaXQgaXMgbm90IHJlcXVpcmVkIHRvIGNoZWNrIGlmIHRoZQ0KPj4gICDC
oCogcmVsZXZhbnQgcGRldiBzdGlsbCBleGlzdHMgYWZ0ZXIgcmUtYWNxdWlyaW5nIHRoZSBsb2Nr
Lg0KPj4gICDCoCovDQo+IEknbSBub3Qgc3VyZSBJIGZvbGxvdyB0aGUgZmlyc3Qgc2VudGVuY2U7
IEkgZ3Vlc3MgYSBjb21tYSBvciB0d28gbWF5IGhlbHAsDQo+IGFuZCBvciB1c2luZyAiYXMgd2Vs
bCBhcyIgaW4gcGxhY2Ugb2Ygb25lIG9mIHRoZSB0d28gImFuZCIuIEkgYWxzbyBkb24ndA0KPiB0
aGluayB5b3UgbWVhbiBjb250ZW50aW9uLCBidXQgcmF0aGVyIGEgcmFjZSBiZXR3ZWVuIHRoZSBu
YW1lZCBlbnRpdGllcz8NCiDCoC8qDQogwqAgKiBGSVhNRTogR2l2ZW4gdGhlIGNvbnRleHQgZnJv
bSB3aGljaCBhcHBseV9tYXAgaXMgY2FsbGVkIChkb20wIHNwZWNpZmljDQogwqAgKiBpbml0IGNv
ZGUgYXQgc3lzdGVtX3N0YXRlIDwgU1lTX1NUQVRFX2FjdGl2ZSkgdGhlcmUgaXMgbm8gcmFjZSBj
b25kaXRpb24NCiDCoCAqIHBvc3NpYmxlIGJldHdlZW4gdGhpcyBjb2RlIGFuZCB2cGNpX3Byb2Nl
c3NfcGVuZGluZyB3aGljaCBtYXkgdHJ5IHRvIGFjcXVpcmUNCiDCoCAqIHRoZSBsb2NrIGluIHJl
YWQgbW9kZSBhbmQgYWxzbyB0cnkgdG8gZGVzdHJveSBwZGV2LT52cGNpIGluIGl0cyBlcnJvciBw
YXRoLg0KIMKgICogTmVpdGhlciBwZGV2IG1heSBiZSBkaXNwb3NlZCB5ZXQsIHNvIGl0IGlzIG5v
dCByZXF1aXJlZCB0byBjaGVjayBpZiB0aGUNCiDCoCAqIHJlbGV2YW50IHBkZXYgc3RpbGwgZXhp
c3RzIGFmdGVyIHJlLWFjcXVpcmluZyB0aGUgbG9jay4NCiDCoCAqLw0KPg0KPiBKYW4NCj4NClRo
YW5rIHlvdSwNCk9sZWtzYW5kcg==


From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:28:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:28:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272173.466972 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbPU-0004Fd-No; Mon, 14 Feb 2022 13:28:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272173.466972; Mon, 14 Feb 2022 13:28:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbPU-0004FW-Ko; Mon, 14 Feb 2022 13:28:56 +0000
Received: by outflank-mailman (input) for mailman id 272173;
 Mon, 14 Feb 2022 13:28:55 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJbPT-0004FK-Rg; Mon, 14 Feb 2022 13:28:55 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJbPT-0005FA-PC; Mon, 14 Feb 2022 13:28:55 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJbPT-0001AQ-8o; Mon, 14 Feb 2022 13:28:55 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nJbPT-00011i-8N; Mon, 14 Feb 2022 13:28:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Tt8HxCmZH5HUbhZFDdHiQKiamQ0vaKDpNzqOUWxxilk=; b=IlnMaDMza2vJXIGAWKAHhLhTEW
	+N796zNpaL5S7tbMrbqe79ALnuTtNYtBJ9A/PmAa6RHJMwEfi2OI3MMvPkd5d4koHn8vsk4jFlB6t
	7ky2pJmqUNMRv2owgxmTjfX52Rk3uKbi3IJLSMv1k6Vuk2TYGBeTv2iLxiVnToOaD1WA=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168110-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 168110: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=94334d854bd358bd1d9c61d5e3306e4d903b120b
X-Osstest-Versions-That:
    xen=87319afb96973213ec0a76270d93696f3b8d6743
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 14 Feb 2022 13:28:55 +0000

flight 168110 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168110/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  94334d854bd358bd1d9c61d5e3306e4d903b120b
baseline version:
 xen                  87319afb96973213ec0a76270d93696f3b8d6743

Last test of basis   168071  2022-02-09 17:02:46 Z    4 days
Testing same since   168110  2022-02-14 10:00:43 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Jan Beulich <jbeulich@suse.com>
  Norbert Manthey <nmanthey@amazon.de>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   87319afb96..94334d854b  94334d854bd358bd1d9c61d5e3306e4d903b120b -> smoke


From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:31:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:31:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272189.466983 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbS4-0005j7-6V; Mon, 14 Feb 2022 13:31:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272189.466983; Mon, 14 Feb 2022 13:31:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbS4-0005j0-3T; Mon, 14 Feb 2022 13:31:36 +0000
Received: by outflank-mailman (input) for mailman id 272189;
 Mon, 14 Feb 2022 13:31:34 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJbS2-0005it-IK
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:31:34 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 693ded89-8d9a-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 14:31:32 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 693ded89-8d9a-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644845492;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=Z+cB0sqWlgdnGR5o8AFGcjMgr10K4PMs89dkpQ3ajkQ=;
  b=MYexF5d5iiPO9tY1Hu9rIBsjKDVWDHHe4ocDvrCweoEpkI1yYL0lgcO+
   zOFK16QHhIBbTujkPwemHYalTTMP3nBYJd+YUtX+BwHwkr2IUllRCBvey
   /oEtfbyLqgDps21nNpeBu7RSlj9o2HtBxO6MDbPFtNoFflJZH1GHCcT1J
   w=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: TE7x6ORfD0MEURW9mKjik0/+tKEU336540cdf0OjtjVsqZckuLMp0vPlq8ABUcrdfRW7jWr8uz
 PjQaGIyx+8eZ+QsTrVLUT8VI6grnSWiyuawBl9tIZo8O/V13GdoaCIRS+A3dx6ogZeFE+Lo51b
 rHqeYJTq6RpHQmAKnE/HNUBEp9egvH/qTJxg3BZ5/dAUDTH+CqP8bnar7xIsChSWpIsgsuR0r5
 lFB6YQsOsL42/7HfJSdAJxIOfrScuNeJKQ58/4twZTJfceejAX+Ii8RsnmVMFjjxN28/PxQfAM
 6sXn48W+mwPpMhDD0k95UiAR
X-SBRS: 5.1
X-MesageID: 64556697
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:m0OtxK/afDobQ1pCdAQEDrUDV3mTJUtcMsCJ2f8bNWPcYEJGY0x3x
 jdLWGGHaa6MYzb0eNBzOYiy8UpQsZbWyNRiHVNvqy08E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhFWeIdA970Ug5w7Rg3tYy6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhcx
 4lkp5qwTD0JAZHotcY9agQJTgNHaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguwKKsXxMZxZkXZn1TzDVt4tQIzZQrWM7thdtNs1rp4SQKuAO
 ZtGAdZpRBOeehAIE1wVMZsjzcew2XXyWWUClE3A8MLb5ECMlVcsgdABKuH9atGMAMlYgEucj
 mbH5HjiRAEXMsSFzjiI+W7qgfXA9QvkXKoCGbv+8eRl6HWRzGEODBwdVXOgvOK0zEW5Xrpix
 1c8o3R06/JorQryE4e7D0bQTGO4UgA0dtUMOv886AS36pXoxyu7JlEZH2NjUYlz3CMpfgAC2
 liMltLvIDVgtryJVH6QnoupQSOO1Ts9djFbO3JdJecRy5y6+dxo0EqTJjp2OPPt1rXI9SfML
 ydmRcTUr5EaloY12qqy5jgraBr898GSHmbZCug6N19JDz+Vhqb4PeRECnCBtJ6sybp1qXHb4
 hA5dzC2trxmMH10vHXlrB8xNL+o/e2ZFzbXnERiGZIsnxz0pSL/ItAAvWwmfRwzWirhRdMOS
 BWN0T69GbcJZCf6BUOJS97Z5zsWIVjISo2+C6G8gitmaZltbg6XlByClmbLt10BZHMEyPllU
 b/CKJ7EJS9DVcxPkWrnL89AgORD7n1vmgvuqWXTkk3PPUy2PyXOF9/o8TKmM4gE0U9ziFuJo
 ogPb5PQk32ykoTWO0HqzGLaFnhTRVATDpHqsc1HMOmFJwttAmY6DPHNh7gmfuRYc259yrigE
 qiVVhAKxVzhq2fALAnWOHlvZKm2BcR0rG4hPDxqNlGtgiBxbYGq5aYZVp02Ybh4q7Azka8qF
 6EIK5eaH/BCajXb4DBBP5Pzm5NvKUawjgWUMiv7PDVmJ8x8RxbE88PPdxf08HVcFTK+sMYz+
 uXy1g7STZcZaR5lCcLaNKCmw1+r5CBPk+NuRUrYZNJUfRy0ooRtLiXwiN4xIt0NdkqflmfLi
 V7ODE5B9+fXooIz/N3Yvoy+rt+kQ7lkA05XP2jH9rLqZyPUyXWunN1bW+GScDGDCG6toPe+Z
 f9Yxu3XOeEcmAoYqJJ1FrtmwP5s59broLMGnA1oEG+SMgauA7JkZHKHwdNOputGwboA4Vm6X
 UeG+997P7SVOZy6TA5NdVR9NunTh+sJnjTy7OguJBSo7SB6y7OLTEFOMkTekydaNrZ0bNsoz
 OpJVBT6MOBjZs7G6uq7sx0=
IronPort-HdrOrdr: A9a23:hL3YSa2XWPgRoHp2eYJFkAqjBRZyeYIsimQD101hICG9Lfb2qy
 n+ppgmPEHP5Qr5AEtQ5OxpOMG7MBbhHQYc2/heAV7QZnibhILOFvAi0WKC+UyuJ8SazIBgPM
 hbAtFD4bHLfDtHZIPBkXOF+rUbsZm6GcKT9J/jJh5WJGkAAcAB0+46MHfhLqQffngdOXNTLu
 v52iMznUvHRZ1hVLXdOpBqZZmgm/T70LbdJTIWDR8u7weDyRmy7qThLhSe1hACFxtS3LYL6w
 H+4k/Ez5Tml8v+5g7X1mfV4ZgTssDm0MF/CMuFjdVQAinwizyveJ9qV9S5zXIISaCUmRMXee
 v30lAd1vdImjXsl6aO0ELQMjzboXITArnZuAelaDXY0JfErXkBerV8bMpiA2XkAgwbzYxBOe
 twrhKkX9A8N2KwoA3to9fPTB1kjUyyvD4rlvMSlWVWVc8EZKZWtpF3xjIeLH4sJlOz1GkcKp
 gkMCgc3ocjTXqKK3TC+mV/yt2lWXo+Wh+AX0gZo8SQlzxbhmpwwUcUzNEW2i5ozuNwd7BUo+
 Dfdqh4nrBHScEbKap7GecaWMOyTmjAWwjFPm6eKUnuUKsHJ3XOoZjq56hd3pDmRLUYiJ8p3J
 jRWlJRsmA/P0roFM2VxZVOtgvARW2sNA6dg/22J6IJzIEUaICbQxFreWpe5PdI+c9vcfEzc8
 zDTa5rPw==
X-IronPort-AV: E=Sophos;i="5.88,368,1635220800"; 
   d="scan'208";a="64556697"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=TQv6jwnEJ+sNr7lIfHqyqyIwCuR5pgqxWkTeYNolqiXKDGETv6sYOPRhawYlU4s7gGEeBx3mf/vN8K/lEz2jyXffM2jAEkqBQf0uEezQE0urst83LWd9bX5l4xug+YP9N4wsVEcnUH3uTOi+0kJdOzFq1VcDdLmp8ZO87n3JOPL2CvOu93Zs/ifKe7+QSvcG/NdUvy9dfd2MojW69NLg8u/qcXTj86OBe6mpLYa9L9anAyc9/5arVmO1jUmWm1slkg72AnnUYeluFrK8CgrZWKPh/cx5q+0mGcxgdj4y41+V2K52fufGYBbKRazsFurNZOikp80I8Kt+BDPQIlbu4w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Z+cB0sqWlgdnGR5o8AFGcjMgr10K4PMs89dkpQ3ajkQ=;
 b=hqG1yb2+V9BwrrmJ37vGn5Qy5DkISGUS7wnavArg376IKqY+f8Ct2CAbbpWm3ui9lOxADk3hlrm+LHKLV/9Za5RVnIKAw6aERiLKyDVpfwTCMG4gliTO3pOklnPUa1ajMsjKb2SW0/UUhyhEz8O1duGg6kFwnJjjiAxkC7/r+L14f4X/eKWPZtTK/GqPJMPJiYcb6wwqEYfwlzxpG5nDyAUCaDxVF28OtRThidmaLkhuCS0ccuxh0aFQhIWge2mVchqgcFtVgpYR51so9KtDDX1NaMoPO9Ic+w4QcK6W2lbPiDXOEL2gQMYb5Pg2FOUdlWaY4VEkaJpmTQGubgEFkQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Z+cB0sqWlgdnGR5o8AFGcjMgr10K4PMs89dkpQ3ajkQ=;
 b=kCRZKjt/IBYpWC4iN/uS/4y+HTxgCW+mlEqpNy8m0DkCM5JUZuZ+RNpEWzPT5EmX9sfxFUelFqKpC/IJam4L56nbIzYoZssywXmceSiwBqQ1Fj0Fk+FU/yYN1jK4MrtIWFE1pUjixxlfpU0ZgVUsD8eav4kE0p3Mvv35PvPjzHo=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>, Xen-devel
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2 3/7] x86/altcall: Optimise away endbr64 instruction
 where possible
Thread-Topic: [PATCH v2 3/7] x86/altcall: Optimise away endbr64 instruction
 where possible
Thread-Index: AQHYIaJdlBm1laP+30eCBtzXO5xQTKyTA/+AgAAG84A=
Date: Mon, 14 Feb 2022 13:31:02 +0000
Message-ID: <cc4cf340-f02f-a547-08a0-1261bb506bcf@citrix.com>
References: <20220214125632.24563-1-andrew.cooper3@citrix.com>
 <20220214125632.24563-4-andrew.cooper3@citrix.com>
 <5d53c6f9-8d1a-3d48-6ea6-14a484d578a0@suse.com>
In-Reply-To: <5d53c6f9-8d1a-3d48-6ea6-14a484d578a0@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 0b3644ac-b6d9-42a1-ef54-08d9efbe3eaa
x-ms-traffictypediagnostic: MWHPR03MB2526:EE_
x-microsoft-antispam-prvs: <MWHPR03MB252649187ED703E3D3B3F6A8BA339@MWHPR03MB2526.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: EAbty/IN2KNWbrFydTKRlzAFvm3ksjqGIZvgj/wdVUIZZEDdKG+zwXQBw0bpiBfWKsFEmLM+/lSgD/bfvf7oS2D7i+rwHsY6sNyjqF0gRJ4n7rU5kUcuKDpgViSkujgadrlrguMyE9lUxtwci5lQYxmp735XVq5sW2YnQ6AN/iFLRtW7iYwO0F2GX4y4UKSAgdi4fN8MPGP7jjBih/QQRfMHxfZ1HNnYuP6JVlGwd7wUpef0oVU6NAXWJQLn7igeFFk0bG1PAlAHEMb85PNj6sUKlzD23Gm3B1v8lcWWUJasbcEpNxU6qrOlYxTbvvvHylCBCuT2iiEAUjn77y4O3G35Ts/2yfxXqRJ1u0ftGZDaEVAVxSIUs0A6oiVZJ/3UbcdAQIgC2Wn/z2bOCL7e5XKQd8zfZgiT2OKYTzq/dlGFBqNVpmIe1yWl4HUHoIJbIzUkQBDZHE4Bhh40otDuQTWiuqklLpwZabJtDZjaC2df0EhhiBzSPD47ZGn/3eKN0yi/j+MVzpRK82+euhaSwnYC63KeTNKjzu4n4EpwISGc3xsZQBYcfJOkljOBEtVe5P2OL7Y49wOi6PDGMvBq/tf30q4jULwcntlJnWZje6OZvx6LRmI3cFmaezx+l+QeIA9M7HjE+K4QqVK0JsMtmMIVOUHGvlOYTEqimbfsjUUIitgCOh0UV+9aaJtr7k9fupLt9OMT9d/3oLLmXMFTdUmHIu9J8mvZyCW/Qzp3zE+OvtCGoFIGx7nCvv/phcDU
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(71200400001)(6512007)(2906002)(86362001)(53546011)(31696002)(38070700005)(5660300002)(8936002)(83380400001)(6506007)(8676002)(54906003)(508600001)(31686004)(2616005)(6486002)(6916009)(122000001)(66556008)(66476007)(66446008)(64756008)(82960400001)(4326008)(36756003)(316002)(38100700002)(66946007)(91956017)(76116006)(186003)(26005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?TW1BZUhLdHBHTEVFb2hwcmt5WW9zWXdTWm1WQnFXNGl6TGpaYW9KZmI4eE9P?=
 =?utf-8?B?V0dFa3k1dGxjSGNRTEtGcWVLTENTN05wbGRYa1ZOQTd6SU5GU1B2MlpBeEdH?=
 =?utf-8?B?cG1tbit4RUtCV3VlcVVYMHE1S3dCeHg5TFdBS0JBd1NZcGpDVHFER2V0VmxS?=
 =?utf-8?B?WEtMNVhmSkprYUtjZ3BXbjg3MXdYYWcwb05EOGpjV2xYM0E3YmEyY3M1M0VP?=
 =?utf-8?B?K0s3K1ZyTE92dDUrVW1ZQ01rRTFDdVMyeTk1ckVzbkMwTENJcks4WUJGOS9T?=
 =?utf-8?B?QThQalZ5L1ExSkphaXRYTVFSRzJibjU5V3NydjE3aksrQzA5RUZGaERYRlJx?=
 =?utf-8?B?SFZ4a2NwdnJJLzBqSlBXSHgrRUxyOVcwTm83N3dmWC9DZXowV1NtaWpWU3hk?=
 =?utf-8?B?NGxnNHQ1VVB0M2RGVitra3E3WHY3TDVtWTNkS0MwR3h6SXBTUUN4ZWRXelhV?=
 =?utf-8?B?YTJ6UkZUQVlEQ2Njbzh5Q0NVSHJacEd4VlhoVFkrdzNKOXhOckg4cFFvTFZa?=
 =?utf-8?B?SVRmNVNaVEo2bDlSYVg4TkV2S1BzOFpCV0RxWStHL3dXa0k1MEVTcDZLR3NV?=
 =?utf-8?B?OVYrbEdBUmtUNUhDR3YwMU5YY2NOMXFCTUYvNko3TFNoQXpiZ2tOM3hteFcv?=
 =?utf-8?B?TThBM0JXMHdLdG9JWitpRnZEaW9Mbm5hZTZCUnE5d1ZjM2EwSFdadEx6b21F?=
 =?utf-8?B?MENzeGJWT3MwOFh6Z1c1VFY0V3pzdDl6SEI0NHJxZWwrcUQwZkVsUk92eVJC?=
 =?utf-8?B?dk12bzdFN3JES2JtSENVSStDRGxyUXE5VEdNMVFGWU1DYW8zdG5WZm82S0Rk?=
 =?utf-8?B?aTZCL29oN1ZFR2l4ZnhRdjBPZU5oSEgxN1ZHcDBEQ1U5UHU0T3lrK3h4dHdw?=
 =?utf-8?B?SVpmZEt1b2NIUE1lbHg3TlZtcktSYXJ5Wmx6dVhvWmNHcy9GT1Y4YjUybmlq?=
 =?utf-8?B?a3F1bTF2RWdEbWVwUlVEZTdUVkROODRoN1JqR3BzQ05iMUdNMFVWOWkxSm1U?=
 =?utf-8?B?aDQvWm5lWmZJZ3IvVURSTTFOdDRXbGs1QmxXRmVTQzNMejJETnpqL1FpWGor?=
 =?utf-8?B?NUY4ODJPV0E3ZDZqZ1JBRmt1SHNBVTQzcktBVDhhZVI5eEFSWkU0b1dGU1VM?=
 =?utf-8?B?UW5tdERud3hnS25IRGxGZTBMbEVIaE9nZG83U2oybCtOZWZHNituZnhaNmVF?=
 =?utf-8?B?WWN6WmRmMWpBZzNCR2hRbkFwMzJzR1BtZEJ6Nm9HdTNROEZKSmxraE1STDNk?=
 =?utf-8?B?RHliN016ZnJNVlNDMUc4NWZvT3R5UlRXaHFidTNoNGFzR1RLTmNvUkN1bVBY?=
 =?utf-8?B?N21yZHYzSzZTWGl2anJNUk4weUpwc3VRcmIrbWJUNFZKNDA4MFUyR2EvU3Iv?=
 =?utf-8?B?N1ErNmUwSS9SS2pBSk11Y1R5cW1CczZQOTY3OXlWM1BOT2FiQWxST2VBemdS?=
 =?utf-8?B?WjNUSWNNdnhrZ2xxN1lHV0lEa0JxSXQyNUlvZXlieGNvQWJuOS9EQVBWd2VQ?=
 =?utf-8?B?c0pYc1VwTXBRK2lGekU3OHk3RWFHL3dWQitVR0pyRHUvTjhHUW1vd1NKYS9n?=
 =?utf-8?B?cDV4SHhwemxLdmhHVHF4UVlYdzJzR1VXaDFsYmtRZ20vR0M4dTEwbGp2UjB5?=
 =?utf-8?B?bVVJZXBXczkwUEgzYjdxRERkQmdHc1FobHZpYkJpSWFRYi8rRENjNHhScDF4?=
 =?utf-8?B?aEYzWTJIYUh2VWNqNkpNc2x3M1ZDQmlNNXg0TVZMNTFzRHgvbFd3RUVkV0sv?=
 =?utf-8?B?WU9MamVhNGVFNlZHcjBrRHo2TkFuU25mYWxsZ2RsU0dZRktsd08zdk0xZ29Y?=
 =?utf-8?B?WmluSnI5RjV2Ukh0RUNPRlRKVDd5ODlvMk9ucmRUK1dNWUhDS2wvUDFhZTZn?=
 =?utf-8?B?TjJRZXV6MFB4SmVnQWV0dG16amY2T0ltbmY0ZStXT1J6d1ordGg5b2I2TGRJ?=
 =?utf-8?B?a2dGNkN5OXI0YTNPdm9wTm44bnI2RzN4elZrSHhlN0svY0JYbk1pUGdGSXZk?=
 =?utf-8?B?MXJjTVViamROQll2QXg1Y0lkTXltV1I3ZmtHN0NucHJoMC9rNkFQUzl1SG1r?=
 =?utf-8?B?NjNHN0I0eXVnS2t6Z0RpUkx3UXFmQzhLNEorTGwwd0hKRFJoM0U3bmhFclNl?=
 =?utf-8?B?SjVFbFRzVFF0S29iY3BabEZ6S3VTZ1RHa3MwdERrTUpXQ25EZVNnR2FQaTBM?=
 =?utf-8?B?eXdMdExmYlM2amF2cW9GTHFUMmYzTFJVaWlWeFhac1RyZ3d0SjNmU0FDVEc5?=
 =?utf-8?B?UU9tNWYyWndvVXRGVDVGMFRVZUN3PT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <ECFB555DA073E5419A70BB5881C01014@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0b3644ac-b6d9-42a1-ef54-08d9efbe3eaa
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Feb 2022 13:31:02.3225
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: dxFPikkd1sf8t6NIzwta6E3rVF1GvDKmUCdFJqv843bHCvPvwBxh72c5Buou8gGPrLz3YEw8nzkMmX0BoJYfRqcMZdNwtXcDAI0Pl0G+ygg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2526
X-OriginatorOrg: citrix.com

T24gMTQvMDIvMjAyMiAxMzowNiwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDE0LjAyLjIwMjIg
MTM6NTYsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBXaXRoIGFsdGNhbGwsIHdlIGNvbnZlcnQg
aW5kaXJlY3QgYnJhbmNoZXMgaW50byBkaXJlY3Qgb25lcy4gIFdpdGggdGhhdA0KPj4gY29tcGxl
dGUsIG5vbmUgb2YgdGhlIHBvdGVudGlhbCB0YXJnZXRzIG5lZWQgYW4gZW5kYnI2NCBpbnN0cnVj
dGlvbi4NCj4+DQo+PiBGdXJ0aGVybW9yZSwgcmVtb3ZpbmcgdGhlIGVuZGJyNjQgaW5zdHJ1Y3Rp
b25zIGlzIGEgc2VjdXJpdHkgZGVmZW5jZS1pbi1kZXB0aA0KPj4gaW1wcm92ZW1lbnQsIGJlY2F1
c2UgaXQgbGltaXRzIHRoZSBvcHRpb25zIGF2YWlsYWJsZSB0byBhbiBhdHRhY2tlciB3aG8gaGFz
DQo+PiBtYW5hZ2VkIHRvIGhpamFjayBhIGZ1bmN0aW9uIHBvaW50ZXIuDQo+Pg0KPj4gSW50cm9k
dWNlIG5ldyAuaW5pdC57cm8sfWRhdGEuY2ZfY2xvYmJlciBzZWN0aW9ucy4gIEhhdmUgX2FwcGx5
X2FsdGVybmF0aXZlcygpDQo+PiB3YWxrIG92ZXIgdGhpcywgbG9va2luZyBmb3IgYW55IHBvaW50
ZXJzIGludG8gLnRleHQsIGFuZCBjbG9iYmVyIGFuIGVuZGJyNjQNCj4+IGluc3RydWN0aW9uIGlm
IGZvdW5kLiAgVGhpcyBpcyBzb21lIG1pbm9yIHN0cnVjdHVyZSAoYWIpdXNlIGJ1dCBpdCB3b3Jr
cw0KPj4gYWxhcm1pbmdseSB3ZWxsLg0KPj4NCj4+IFNpZ25lZC1vZmYtYnk6IEFuZHJldyBDb29w
ZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+DQo+IFJldmlld2VkLWJ5OiBKYW4gQmV1bGlj
aCA8amJldWxpY2hAc3VzZS5jb20+DQoNClRoYW5rcywNCg0KPiB3aXRoIHR3byByZW1hcmtzLCB3
aGljaCBpZGVhbGx5IHdvdWxkIGJlIGFkZHJlc3NlZCBieSByZXNwZWN0aXZlDQo+IHNtYWxsIGFk
anVzdG1lbnRzOg0KPg0KPj4gQEAgLTMzMCw2ICszMzMsNDEgQEAgc3RhdGljIHZvaWQgaW5pdF9v
cl9saXZlcGF0Y2ggX2FwcGx5X2FsdGVybmF0aXZlcyhzdHJ1Y3QgYWx0X2luc3RyICpzdGFydCwN
Cj4+ICAgICAgICAgIGFkZF9ub3BzKGJ1ZiArIGEtPnJlcGxfbGVuLCB0b3RhbF9sZW4gLSBhLT5y
ZXBsX2xlbik7DQo+PiAgICAgICAgICB0ZXh0X3Bva2Uob3JpZywgYnVmLCB0b3RhbF9sZW4pOw0K
Pj4gICAgICB9DQo+PiArDQo+PiArICAgIC8qDQo+PiArICAgICAqIENsb2JiZXIgZW5kYnI2NCBp
bnN0cnVjdGlvbnMgbm93IHRoYXQgYWx0Y2FsbCBoYXMgZmluaXNoZWQgb3B0aW1pc2luZw0KPj4g
KyAgICAgKiBhbGwgaW5kaXJlY3QgYnJhbmNoZXMgdG8gZGlyZWN0IG9uZXMuDQo+PiArICAgICAq
Lw0KPj4gKyAgICBpZiAoIGZvcmNlICYmIGNwdV9oYXNfeGVuX2lidCApDQo+PiArICAgIHsNCj4+
ICsgICAgICAgIHZvaWQgKmNvbnN0ICp2YWw7DQo+PiArICAgICAgICB1bnNpZ25lZCBpbnQgY2xv
YmJlcmVkID0gMDsNCj4+ICsNCj4+ICsgICAgICAgIC8qDQo+PiArICAgICAgICAgKiBUaGlzIGlz
IHNvbWUgbWlub3Igc3RydWN0dXJlIChhYil1c2UuICBXZSB3YWxrIHRoZSBlbnRpcmUgY29udGVu
dHMNCj4+ICsgICAgICAgICAqIG9mIC5pbml0Lntybyx9ZGF0YS5jZl9jbG9iYmVyIGFzIGlmIGl0
IHdlcmUgYW4gYXJyYXkgb2YgcG9pbnRlcnMuDQo+PiArICAgICAgICAgKg0KPj4gKyAgICAgICAg
ICogSWYgdGhlIHBvaW50ZXIgcG9pbnRzIGludG8gLnRleHQsIGFuZCBhdCBhbiBlbmRicjY0IGlu
c3RydWN0aW9uLA0KPj4gKyAgICAgICAgICogbm9wIG91dCB0aGUgZW5kYnI2NC4gIFRoaXMgY2F1
c2VzIHRoZSBwb2ludGVyIHRvIG5vIGxvbmdlciBiZSBhDQo+PiArICAgICAgICAgKiBsZWdhbCBp
bmRpcmVjdCBicmFuY2ggdGFyZ2V0IHVuZGVyIENFVC1JQlQuICBUaGlzIGlzIGENCj4+ICsgICAg
ICAgICAqIGRlZmVuY2UtaW4tZGVwdGggbWVhc3VyZSwgdG8gcmVkdWNlIHRoZSBvcHRpb25zIGF2
YWlsYWJsZSB0byBhbg0KPj4gKyAgICAgICAgICogYWR2ZXJzYXJ5IHdobyBoYXMgbWFuYWdlZCB0
byBoaWphY2sgYSBmdW5jdGlvbiBwb2ludGVyLg0KPj4gKyAgICAgICAgICovDQo+PiArICAgICAg
ICBmb3IgKCB2YWwgPSBfX2luaXRkYXRhX2NmX2Nsb2JiZXJfc3RhcnQ7DQo+PiArICAgICAgICAg
ICAgICB2YWwgPCBfX2luaXRkYXRhX2NmX2Nsb2JiZXJfZW5kOw0KPj4gKyAgICAgICAgICAgICAg
dmFsKysgKQ0KPj4gKyAgICAgICAgew0KPj4gKyAgICAgICAgICAgIHZvaWQgKnB0ciA9ICp2YWw7
DQo+PiArDQo+PiArICAgICAgICAgICAgaWYgKCAhaXNfa2VybmVsX3RleHQocHRyKSB8fCAhaXNf
ZW5kYnI2NChwdHIpICkNCj4+ICsgICAgICAgICAgICAgICAgY29udGludWU7DQo+PiArDQo+PiAr
ICAgICAgICAgICAgYWRkX25vcHMocHRyLCA0KTsNCj4gVGhpcyBsaXRlcmFsIDQgd291bGQgYmUg
bmljZSB0byBoYXZlIGEgI2RlZmluZSBuZXh0IHRvIHdoZXJlIHRoZSBFTkRCUjY0DQo+IGVuY29k
aW5nIGhhcyBpdHMgY2VudHJhbCBwbGFjZS4NCg0KV2UgZG9uJ3QgaGF2ZSBhbiBlbmNvZGluZyBv
ZiBFTkRCUjY0IGluIGEgY2VudHJhbCBwbGFjZS4NCg0KVGhlIGJlc3QgeW91IGNhbiBwcm9iYWJs
eSBoYXZlIGlzDQoNCiNkZWZpbmUgRU5EQlI2NF9MRU4gNA0KDQppbiBlbmRici5oID8NCg0KPg0K
Pj4gLS0tIGEveGVuL2FyY2gveDg2L3hlbi5sZHMuUw0KPj4gKysrIGIveGVuL2FyY2gveDg2L3hl
bi5sZHMuUw0KPj4gQEAgLTIyMSw2ICsyMjEsMTIgQEAgU0VDVElPTlMNCj4+ICAgICAgICAgKigu
aW5pdGNhbGwxLmluaXQpDQo+PiAgICAgICAgIF9faW5pdGNhbGxfZW5kID0gLjsNCj4+ICANCj4+
ICsgICAgICAgLiA9IEFMSUdOKFBPSU5URVJfQUxJR04pOw0KPj4gKyAgICAgICBfX2luaXRkYXRh
X2NmX2Nsb2JiZXJfc3RhcnQgPSAuOw0KPj4gKyAgICAgICAqKC5pbml0LmRhdGEuY2ZfY2xvYmJl
cikNCj4+ICsgICAgICAgKiguaW5pdC5yb2RhdGEuY2ZfY2xvYmJlcikNCj4+ICsgICAgICAgX19p
bml0ZGF0YV9jZl9jbG9iYmVyX2VuZCA9IC47DQo+PiArDQo+PiAgICAgICAgICooLmluaXQuZGF0
YSkNCj4+ICAgICAgICAgKiguaW5pdC5kYXRhLnJlbCkNCj4+ICAgICAgICAgKiguaW5pdC5kYXRh
LnJlbC4qKQ0KPiBXaXRoIHIvbyBkYXRhIGFoZWFkIGFuZCByL3cgZGF0YSBmb2xsb3dpbmcsIG1h
eSBJIHN1Z2dlc3QgdG8gZmxpcCB0aGUNCj4gb3JkZXIgb2YgdGhlIHR3byBzZWN0aW9uIHNwZWNp
ZmllcnMgeW91IGFkZD8NCg0KSSBkb24ndCBmb2xsb3cuwqAgVGhpcyBpcyBhbGwgaW5pdGRhdGEg
d2hpY2ggaXMgbWVyZ2VkIHRvZ2V0aGVyIGludG8gYQ0Kc2luZ2xlIHNlY3Rpb24uDQoNClRoZSBv
bmx5IHJlYXNvbiBjb25zdCBkYXRhIGlzIHNwbGl0IG91dCBpbiB0aGUgZmlyc3QgcGxhY2UgaXMg
dG8gYXBwZWFzZQ0KdGhlIHRvb2xjaGFpbnMsIG5vdCBiZWNhdXNlIGl0IG1ha2VzIGEgZGlmZmVy
ZW5jZS4NCg0KfkFuZHJldw0K


From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:33:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:33:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272197.466995 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbTw-0006JJ-IG; Mon, 14 Feb 2022 13:33:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272197.466995; Mon, 14 Feb 2022 13:33:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbTw-0006JC-FN; Mon, 14 Feb 2022 13:33:32 +0000
Received: by outflank-mailman (input) for mailman id 272197;
 Mon, 14 Feb 2022 13:33:31 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KkXt=S5=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nJbTv-0006J6-4C
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:33:31 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b25852c5-8d9a-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 14:33:30 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2177.outbound.protection.outlook.com [104.47.17.177]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-13-oQ8TZFAzO4Gwq8Wwil_USQ-1; Mon, 14 Feb 2022 14:33:28 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VE1PR04MB6445.eurprd04.prod.outlook.com (2603:10a6:803:11c::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.18; Mon, 14 Feb
 2022 13:33:26 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4975.015; Mon, 14 Feb 2022
 13:33:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b25852c5-8d9a-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644845609;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=od79o+m2vjWcSzCbdZuilnVrhrD21+vrhrbvHqz7Pls=;
	b=Ju2jhmZhkJU1nldmXrbL4IJxzjMxwdVdTryRhFoGJPMe7rbirRKlx5M7ppiv1G+CQJDw5h
	nveZtNmTE8SJfaoFdVslB2UPIyNd24DiOezil1/2jyhk5lNmD5P/V48bN8bRKyICTv3Czs
	ji4TL6mxC2lMAPi496+bhoqwXxiz2v0=
X-MC-Unique: oQ8TZFAzO4Gwq8Wwil_USQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XjWlX9bFIMAdTG3CaUgt/WfQ6sKkx2sr75xcJGq3WIJfY+ZTLD9CpN+v0VFi5+moSie6GIHmZxy0VIzJ4bx3atDK6Lp5kmi83J9WEnFosHNw1ZqHuxh1a8qwHqIkBxDmzcYS5FVGwFtv1HB3t1Ial47yoSEoCpF7rdHhKs8U+hmHoyqkzxkp8Kr3Aby75/1fFbruBTqDPmlwG8j2lm0SZvabbipwFJpKod/j2MFiO8hnA//SpXy3fPIdhdnkG/GcjRMOsWN+cmtx3vg0EGbeWUmrQD1x+X6vzD0mkJZmX3QYo3BgiK4BUQFptcERNqs3yhcW94jQ/nspxOUsYbHxsg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Dr9WkXqtGYwxIT7piuJg17fN4Mt626Z5W09wOvRyZPo=;
 b=CQxWfOrPXTGLAvM2lX2cZ01px125THIlG728pZpcF2OeNJNYjGsLqThxZDi30TsNV4QAdCzgtNArMCjsFKfXghHNVn2h+6OTs57VJV9eKu9CBonaFW+CdfRr2560f8k3ZZiVfWv9a3SWqx+WZ4HYjLZBlKK9Qn8xwGHd5LDhh7Q4hkDSD7u0iKUSP8KMWEnFiUf7abgoLjhLqKBJqybwfgLtiGnqv1mh6nxVqxi+QbTu+GBZzhfywi8Mcv2Qr3iY5bBNzNPEFyI7C7lR30uBV04dAknhVtmsqoW2qljZ7a5+KWHrc03PodRGj5+poaoMRyuujG5JpsReZPxkNGoXRg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <4d8ab414-caf4-5a12-4cb7-a88c633cfd66@suse.com>
Date: Mon, 14 Feb 2022 14:33:24 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH v2 04/70] x86/pv-shim: Don't modify the hypercall table
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Juergen Gross <jgross@suse.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
 <20220214125127.17985-5-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220214125127.17985-5-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS8PR04CA0031.eurprd04.prod.outlook.com
 (2603:10a6:20b:312::6) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 34d447ff-af22-444e-d161-08d9efbe9448
X-MS-TrafficTypeDiagnostic: VE1PR04MB6445:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<VE1PR04MB64458AFCEB38B0F76CF178CDB3339@VE1PR04MB6445.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1923;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	VgndDCVaH8Ze++UXgK9QAAKDkHNTjKYWXupQ9Eae6aJUXLULno2fnpkQmqyGUXG66ahfgiuz5GklDn6MG3c+ySpmM/P/sHXiOolDTrF/hf4YudJYd2+VC9qT8Zm6z9jZ/8GoBSPFLvFzZ647ZLDHuRSIe6NgaZ6dW+YFYVA0Trs5HIOd9tt3cM4gzmbP+KeXbPSwtTzmKv2O2C31zp6hGWD5Hj9+BUQhI5XjmqmfJbIoqAlhkI87+6VrgPKiyVTcDp1+eHzj0UygVZAOPu+qK0cRnuH1h8c6rgrpXeP3/p2e0uriqs/mNexhVnUz6xSde2L6yrSuS5QecfX1HeVmSapjX1+MtiW0jLg7/nOpsh3GhGGsh0Q7D1Hh96bQJhC2vFIyGfpPtF9XR1OUOSH5LjKcm2qhBfWKLktv92d9MRgw+egFI9kWWDCBRzuPhMQEh5yAuqXoFEXo5hCqGkZAI50aXncHBrLgSeIO8NXoFxqXZdbXqGHFlBM/JyiBm/CDTH7OMXpMYZgjnwP8AxWnsb9AplyYfa3D0fPc0G7tFw2SD13BChl75MSqf/rN/6WwKD5fZF3OBNkaMNhXqGT1AdvR3RI0YkzR9fD3Iqzi/70EyUCxGPlZSykn3e33UfUFg543mWqEcgu8HJpMd5NCZoruSrapDD01wyYTloe1LqqAH8O8sTzI0uAAgq6mzMznJVNlGx0rJnaZkwI+7gUW/mAjZ6k/BOHOxnPfwd5ErlE=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(26005)(5660300002)(186003)(83380400001)(4326008)(316002)(6486002)(86362001)(66574015)(8676002)(66556008)(66476007)(66946007)(8936002)(2906002)(54906003)(36756003)(6506007)(6916009)(38100700002)(31696002)(6512007)(508600001)(2616005)(31686004)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?9XxOwktaaqBZP2Zi+YVLdWD38srbhZ1qiGXuFfcApEGVAYspvOOASrWAZG6R?=
 =?us-ascii?Q?1X4YM1p53UtyLIN/vfkaaetJFzdzZUtdPKQlBmpM6n6MuycV8ffKh58cLjIO?=
 =?us-ascii?Q?J8At5ZiIrUQBZiZngtYo9RN71PNUjf31Pay8vi+ywuR/Jh4/Q/KV4FANYi/1?=
 =?us-ascii?Q?/RP++3aRalDNrgi0EDrLCpMCPWTDrGwbYzJOxKC0649Dr/+U7sP3NDWuyjLe?=
 =?us-ascii?Q?2RyVVagmS3OcBPja81ESjfH8YIjbPDlzKQeVA688lC/ISaOo+SiIuQEfpdOX?=
 =?us-ascii?Q?0hMB2jF8o7F8dP0Li4SMT2HciFwgvk8MWodDaLmY+hPKl1d76d5jH4zuR9Uz?=
 =?us-ascii?Q?DpvlgZvRQTj5QoaeWOELe//oJ8Go03k8UwWAqgC5uP4UEchCB+Rr7t37hJET?=
 =?us-ascii?Q?g31TqSZWnQQ6FbMWqI3ReuOmvAt//IMJEwgdRgeo+rc6IN4oDGJ4gZlHPsnN?=
 =?us-ascii?Q?5O/q75NrYmcKGK5/iUzUeGVYftbieoXmf0bRYvo9gOjlR9a4oWyMnWnVpyAm?=
 =?us-ascii?Q?Wwh60KdUoOo+N7OvAKp9tIz02kBS60etpuwmbDHwmsGZnImfDf3TH9txOjOb?=
 =?us-ascii?Q?tZBoKp8QOOrHdcHvXqwNGPBsCnooc/MKDo8Vk+HbbfIMGQ+DM3pnpK6yQ3Or?=
 =?us-ascii?Q?mqbiFlG+nkdDR966fa8fGo0R2X6MLF/bW3tprI84/YXGbRoxsNZDtXh3N4Mt?=
 =?us-ascii?Q?Ozl2Shc0xNikW1BeTYaqZoPhhuLESoHKBhJnECJ+WNJCPYh7HxPoxjxKYJH4?=
 =?us-ascii?Q?pEIV1+o81sKpxjPxh1HUPaLlMxp/tIZFIHnQEL/LePYr3rQMxUNRSg2u8Tk4?=
 =?us-ascii?Q?ld+QA7QUxrxBZINVMKiqRd7jkoIQiCpPKKNURa98JjuSnb7LNqBpLJTD6IPT?=
 =?us-ascii?Q?w/dl6foUS3Am61z3I4ArF3QSZX2TsZMyGVATtlulMOyHpHPZC8m5MohNZAGd?=
 =?us-ascii?Q?C78Go8yw/5Iwf1Ly+F+RGnp5gz9LzuDvRVe5flxB+IbTGJ9dM696lkC9gJRZ?=
 =?us-ascii?Q?+TZSzH9fD+iFAQLi3SDZjOltck0hvufXXAiEYc+53Z1lWtdDtyujzJUZt1XB?=
 =?us-ascii?Q?HXhEs1+CBP4ye/DYHGyDzs7e26yhua2JdhjnhaERlm5ddviM+4hF6MLq7ZE0?=
 =?us-ascii?Q?v5V0VN9qg7Wuflkn461JtGUVB+5eMXcLk9CWAnnEs8tdu91bJzu47kknt887?=
 =?us-ascii?Q?dOagUBMJabC95CD488KhHDDoznPOS3ZS1BWgBUL4EL8OiHVa2yTKkComcHLI?=
 =?us-ascii?Q?N28tSCbkLkb1CqGRfYIMi9lKYSGkinV24+KBTDZt+kKaj1fNrjuRhu2ZMbkn?=
 =?us-ascii?Q?+070GpC7LjU347pkIdzn/2hZ2o3NL+1S4gzPoB3jfODi71kUM97LwgKcXhWB?=
 =?us-ascii?Q?mQsAAYDuYpU+Mh8tC42MbYcP5qkXSFV+PLaDvsTlD7UH4kE3J51rt+19YDOZ?=
 =?us-ascii?Q?4dcm38KR08ABRTDBBP24VxbgEnMfybQcdVn8LCV0kPEVZuYSKNewOwSmHl1m?=
 =?us-ascii?Q?0/h7JqctOLK/DBCxADDnnopUEMHwfUk52HKc1H2gFTzBnT7aREdCH7p2g9UO?=
 =?us-ascii?Q?52jwHG4GoJcTbKhRh/fpkc4RYdPvfk2MD6P8j/J3ddCoJ/3LDzKlxMFpZxvN?=
 =?us-ascii?Q?mSEnrbhI2v/I6V0S2uF5JgA=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 34d447ff-af22-444e-d161-08d9efbe9448
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2022 13:33:26.1510
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BGd8XNftFDguPPIuw+DOBlRX9BvBYiYaR4szgdRVZXNeidW8wqICd2EH2vy6GYYNwazrx7ZO/D2kczq9ENV+Bg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6445

On 14.02.2022 13:50, Andrew Cooper wrote:
> From: Juergen Gross <jgross@suse.com>
>=20
> When running as pv-shim the hypercall is modified today in order to
> replace the functions for __HYPERVISOR_event_channel_op and
> __HYPERVISOR_grant_table_op hypercalls.
>=20
> Change this to call the related functions from the normal handlers
> instead when running as shim. The performance implications are not
> really relevant, as a normal production hypervisor will not be
> configured to support shim mode, so the related calls will be dropped
> due to optimization of the compiler.
>=20
> Note that for the CONFIG_PV_SHIM_EXCLUSIVE case there is a dummy
> wrapper do_grant_table_op() needed, as in this case grant_table.c
> isn't being built.
>=20
> Signed-off-by: Juergen Gross <jgross@suse.com>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

I don't think you sync-ed this with J=C3=BCrgen's v3. There were only minor
changes but having a stale version sent two months later isn't very
nice.

> --- a/xen/common/compat/multicall.c
> +++ b/xen/common/compat/multicall.c
> @@ -5,7 +5,7 @@
>  EMIT_FILE;
> =20
>  #include <xen/types.h>
> -#include <xen/multicall.h>
> +#include <xen/hypercall.h>
>  #include <xen/trace.h>
> =20
>  #define COMPAT
> @@ -19,7 +19,6 @@ static inline void xlat_multicall_entry(struct mc_state=
 *mcs)
>          mcs->compat_call.args[i] =3D mcs->call.args[i];
>  }
> =20
> -DEFINE_XEN_GUEST_HANDLE(multicall_entry_compat_t);
>  #define multicall_entry      compat_multicall_entry
>  #define multicall_entry_t    multicall_entry_compat_t
>  #define do_multicall_call    compat_multicall_call

J=C3=BCrgen's patch doesn't have any change to this file, and I'm afraid I
also don't see how these adjustments are related here. The commit
message sadly also doesn't help ...

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:35:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:35:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272212.467005 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbVv-00074F-3g; Mon, 14 Feb 2022 13:35:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272212.467005; Mon, 14 Feb 2022 13:35:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbVv-000748-0I; Mon, 14 Feb 2022 13:35:35 +0000
Received: by outflank-mailman (input) for mailman id 272212;
 Mon, 14 Feb 2022 13:35:33 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJbVt-00073h-EG
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:35:33 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id fa59ae9b-8d9a-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 14:35:32 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fa59ae9b-8d9a-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644845732;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=oNwQtLuu98X4SQwPPIlMBgTUYnA+4NuDfMaIFjB1k3k=;
  b=H4/2O4W/BLd4ACJZ18hrKESmdFF8I4Mi1iy6dOQrhD4wbVTkLc153R1J
   HzD6jCOtsUK/1mpmu5dhaQmdmX0v5Dbtqeej/HlZRUuuZu9iwDTnIWQPM
   kYs0CboCetC1NtDEC6Cads6A9ZZ97jcaW3U0qL02sbhz3x1eufWtKfJ1n
   U=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: 4NFVUWzNbz1zl9wW0Cva4tIfHZqNhw5wHJG/jMORtFexvPxs2swAUCLT6xMGh1FhNt9HsNSaSt
 6CkAn6GG+4/JIM+2S64MS3ast4QCAj/MdoGZxQzXyjswE3QJQAdm869TCMjyzDsBO6DsMUTh1F
 CsOZ9X2KpV1T8RlwxeumHI6i1FPHRY4h+ywVVbmxNWYAJttLfMVkd03rsyS0BWgORApg7fUtGI
 DoXVRw6P/pVS2Dezh+ZUQuh8kWpFt+FqH3Ppw33wYxMZ0Dgh0NvQ+EeDkyhS5cwLO6M8OE+Sri
 KePF641MjcYRI5DXKoMmI4XL
X-SBRS: 5.1
X-MesageID: 63594975
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:HCGzc6mYkTY7zlpUF1aimnno5gxUIURdPkR7XQ2eYbSJt1+Wr1Gzt
 xIaXWuCP/mNN2bxetsiOoWxoEsB75CGxtRmT1RvrHszQSMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BClVlxJVF/fngqoDUUYYoAQgsA180IMsdoUg7wbRh2Nc02YLR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 IRtsKOfY14PB5L3gtQdXh9fSwxvI4QTrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBODtMJkSpTdLyjbBAOx9aZvCX7/L9ZlT2zJYasVmQ62DN
 pZINmcHgBLoTV4SIEceUJAE2+b1nHftVTF49XOZqv9ii4TU5FMoi+W8WDbPQfSaSMMQkkuGq
 2bu+2XiHgpcJNGZ0SCC8H+nmqnIhyyTcJ0WPK218LhtmlL77m4ZBQASVFC7ieKkkUP4UNVaQ
 3H44QJ38/J0rhbyCICgAVvo+xZooyLwRfIBM+gFxyvU7JPr2BypBmUCSWZsecIP4ZpeqSMR6
 neFmNbgBDpKubKTSG6A+rr8kQ5eKRT5PkdZO3ZaEFJtD83L5dhq00mRFooL/Lud04WtcQwc1
 Qxmu8TXa187qccQn5u28lnc695HjsiYF1Vljuk7s4/M0++YWGJHT9HygbQ4xawZRGp8crVml
 CJa8/VyFMhUUfmweNWlGY3h5o2B6fefKyH7ilVyBZQn/DnF0yf9IdwPsGEjeR8waZxsldrVj
 Kj741052XOuFCHyMf8fj3yZV6zGMpQM5fy6D6uJP7Kik7B6dROd/TEGWKJj9zuFraTYqolmY
 c3zWZ/1VR4yUP07pBLrF7Z1+eJ6nUgWmDKMLa0XOjz6iNJyklbOEuxbWLZPB8hkhJ65TPL9r
 YoBaZvQlkk3vS+XSnC/zLP/5GsidBATLZv3t9ZWZqiEJA9nE3smEPjf3fUqfIkNokifvrygE
 qiVVhAKxVzhq2fALAnWOHlvZKm2BcR0rG4hPDxqNlGtgiBxbYGq5aYZVp02Ybh4q7Azka8qF
 6EIK5eaH/BCajXb4DBBP5Pzm5NvKUawjgWUMiv7PDVmJ8x8RxbE88PPdxf08HVcFTK+sMYz+
 uXy1g7STZcZaR5lCcLaNKCmw1+r5CBPk+NuRUrYZNJUfRy0ooRtLiXwiN4xIt0NdkqflmfLi
 V7ODE5B9+fXooIz/N3Yvoy+rt+kQ7lkA05XP2jH9rLqZyPUyXWunN1bW+GScDGDCG6toPe+Z
 f9Yxu3XOeEcmAoYqJJ1FrtmwP5s59broLMGnA1oEG+SMgauA7JkZHKHwdNOputGwboA4Vm6X
 UeG+997P7SVOZy6TA5NdVR9NunTh+sJnjTy7OguJBSo7SB6y7OLTEFOMkTekydaNrZ0bNsoz
 OpJVBT6MOBjZs7G6uq7sx0=
IronPort-HdrOrdr: A9a23:Ust8WancpII7tEyAAB4q//ixv6rpDfOKimdD5ihNYBxZY6Wkfp
 +V8sjzhCWatN9OYh0dcIi7SdW9qXO1z+8Q3WGIVY3SHTUOy1HYU72KirGSgwEIeheOuNK1sJ
 0AT0EQMqyJMbEXt7eZ3OD8Kadc/DDlytHquQ699QYXcegCUcgJhG0Vanf5LqQ1fng9OXNQLu
 vA2iMtnUvGRZ1jVLXDOpBzZZmkmzSkruOCXTc2QzocrCWehzKh77D3VzKC2A0Fbj9JybA+tU
 DYjg3Q/MyYwrOG4y6Z81WWw4VdmdPnxNcGLteLkNIpJjLljRvtTJh9WoeFoCs+rIiUmRMXeZ
 j30lMd1vZImjXsl1KO0ELQMs7boW4TAkrZuBilaL3Y0JfErXwBepB8bMliA2XkAgIbzaBBOe
 Rwrj6kXtNsfGD9dG6W3am5azh60kWzunYsiugVkjhWVpYfcqZYqcgF8FpSC4poJlO21GkLKp
 gkMCjn3ocdTbpaVQGvgkB/hNi3GngjFBaPRUYP/sSTzjhNhXh8i08V3tYWkHsM/I80D8As3Z
 WKDo140LVVCsMGZ6N0A+kMBcOxF2zWWBrJdGafO07uGq0LM2/E75T3/LI27ue3f4Fg9up/pL
 3RFFdD8WIicUPnDsODmJVN7xDWWW24GS/gz8lPjqIJ8oEUhICbeBFrZGpe5vdIks9vdPEzAc
 zDSq6+K8WTWVfTJQ==
X-IronPort-AV: E=Sophos;i="5.88,368,1635220800"; 
   d="scan'208";a="63594975"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=C6TIlZenqg5KawbFShSAiukHuzygQYqESB0Z2bFj0X6HSH6Rm9FlVwJsyR0n++i70Ob4xea2CD79MtA0gRL8s3vD/llM7ad+Umsc1lt4boqWL9N6076RmkgrKz5sO3CGtyxhhaVbVb046fRO13BZy4uebh4v+IrmEgcA+SI0Zn/Ba8+09ZBfZxgs5cBpm0GzgggMnxStxVMpSlvObmiEOSkklKA5FcAEYAOdnoS5noF0EgZwVWAoRK7GoauwPteFa8M2r89BoBoFOap0+YFvEW3KHmfN2Be26YnDodjAM5nLcf7Rbpje/WHQA07QWYUojEawcKOUbNWsPfG/JMOulg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=oNwQtLuu98X4SQwPPIlMBgTUYnA+4NuDfMaIFjB1k3k=;
 b=Xa/qOlG0fVs7PO8BXySs/nTndbmM2JaGPOzWepQoDGAzeBBSIhDPRQziPeK5+zcIo6WjJNBNdIbzzFo366YW+F8sAWAlkO9KSkZQTAD81VPpfiA8u9KzQHSHVR4ggpJmOGGzoZcOVR6yro01Ou1dSG66jbXarqOioTchJKOVNU6nCRn9HOHvYkjiPQUIPXL/a5DvBEVXuBRUQkDsiWwHAQA33Cdc7Gcgtp4RsJbseLXZRo3zJCxbNUCCUTNu4CgP1ggI/xT5/V5O9IVRNwvRex3XzKc3cVH/6zFi3ngslSTZACJfasE514YP7lO02dFNnpqBYVS1Z+pw1a8gE5YdFA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=oNwQtLuu98X4SQwPPIlMBgTUYnA+4NuDfMaIFjB1k3k=;
 b=k014ji+RMTphOhA5RNHkMDhzOSaIM1CgpguwXaJOQzV0gSzISTgMe5q5k3KNTxQFho7xiM0nezeSBNSin2VQ6WsOWktfWCrppvSMNaSHxeIaVi5V1MekGO9mfTsbCrhh9lEsNugiJD40bFl4L4JXHuE2I3fVIyb++OKpca+A+v0=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>, Xen-devel
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2 5/7] x86/hvm: Use __initdata_cf_clobber for hvm_funcs
Thread-Topic: [PATCH v2 5/7] x86/hvm: Use __initdata_cf_clobber for hvm_funcs
Thread-Index: AQHYIaJjsOAx5ctsj06lom2YGua3HKyTBU+AgAAG24A=
Date: Mon, 14 Feb 2022 13:35:23 +0000
Message-ID: <2e28c474-6778-431a-9e40-8cc0668224c5@citrix.com>
References: <20220214125632.24563-1-andrew.cooper3@citrix.com>
 <20220214125632.24563-6-andrew.cooper3@citrix.com>
 <785653bd-db3a-df22-f2a0-c20b3f3bf8c1@suse.com>
In-Reply-To: <785653bd-db3a-df22-f2a0-c20b3f3bf8c1@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 17f893fb-916b-4e47-6795-08d9efbeda64
x-ms-traffictypediagnostic: CY4PR03MB2872:EE_
x-microsoft-antispam-prvs: <CY4PR03MB2872A147D5BB555939E87277BA339@CY4PR03MB2872.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: Yk49TnUHvpJhQB2pySXH/WSh+K27uvajrd/FFTBjVGknrr14axRnycTt+X7KLtWV2UJ4jmTPWn5SaLliod6dGvk9FYUkJR9LcVYHvA4sPNoUuJJzZJ3Im10IlfbJGfXVChzJHTi4eAHFCahJdmJpeuUtjFcv7Ep2S8bO7Zgfh/WeyIqdaNUii28MnrG3kMpjcz3P1KwECVi5v3q6DZAEUNnArJNuAIv9l04+zT9IVxvYDLhxa9uhWgZc9fkTbq/2kdD1/QmCB/YqBpSH9BEKho5FoSNr7hUcB51SIC00nOrd1HCQWgI7OFJUtEFwjuuHOgjphmYam6oqZsSy+UHdjf3Cnc0wi5isjQH2AxEfTbxcelyCAVKvYN0Zx3i2kxNblwXxPMU16T4HXUoulhfHr4fuKQV/8pxF4wb+9KNV3si/qRzECXa/2WOSg4Wr3wM+UIs9bmQvsjw9iOt1/GXsnJ7GVSApRhPt6pd0kJFXod7NCUx/Yh/0z1H94Ai5Rs18275xMeByOfMo7jcZYDc1R/b5qBTZMgCjVyLVSI+PnbPDDvFjpr7utrEHe9ZK8pJIp0p0zb4m45h4JEBT6uWhi3ps824Z+lcmr+IbjrqReZT4mf9wC0tGvyE+mQF2kggBsNV8P9h9Ty8WFdYwgQjzJWcvyByqjGAaRrDrOYuHNSHnI+mTY+/PoXonUEY5L9Fay94AugIIeADxRyDI0fqa+2Fy7nwtBGYpue5tNNgC+i8C3yMdSfCNG4MEWRrkh+zepOs/dzF5gaNRwYE9rO5YSg==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(36756003)(2616005)(5660300002)(31696002)(2906002)(186003)(26005)(8936002)(38070700005)(76116006)(66556008)(53546011)(4326008)(8676002)(64756008)(66446008)(66476007)(82960400001)(66946007)(122000001)(38100700002)(6506007)(508600001)(316002)(6916009)(54906003)(91956017)(86362001)(31686004)(6512007)(6486002)(71200400001)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?azZ5OC85SmV3cC9YSGlLUExGKzE1UUVVQWZkWlh5L0lTK3owcmE3MGhTNlhl?=
 =?utf-8?B?emg3NVRiYWFCek5OK01sbW5IV2VrUjNhYzRuYWRZNEs4RDJkSWt0b0I3cjJz?=
 =?utf-8?B?Z1Vaa3dwa0FHNXZ3alg5eVlOa2VVSWREc3hGSHhESW8xY1lDK3FlNXVFcEhw?=
 =?utf-8?B?VERvdjJETVJmQU0rKzBkcHlWcXlySVhZOThzaUJVcFRiUVhwdWpOYUc3a0tS?=
 =?utf-8?B?YXp0aXZMQmhUWS9lajB0Qk1RYUo5eXdWTjRPUUtjdnljeGErUEk1TnNYNHo2?=
 =?utf-8?B?OWg4SFk4K2lodG1zYkJ1VGpQSUtoU0ZqSUQ2aFdCRXRmR3JTZ2FRa2VqWnVy?=
 =?utf-8?B?a3g3SG95U1J6K1JTTFRGNlRFNUlBeFVPN2dRUzlmUGpsUmR1MnJBUTJ4T0lV?=
 =?utf-8?B?WlF5K3VUYUUvVEdSSURsTlFYRkNNNTdqejhNaXFFdWdzbS80YW95QzJPSnI4?=
 =?utf-8?B?Sno2NytjSzVMNGhqYjRQOUQwSUtKaXFUN3hMU0pmL2dYY3hya2l2dFMxcHY2?=
 =?utf-8?B?elZua3lsT0Zjc2FVVXFVSHdwOXlZUkhpVUo1clB5NkJRTmMxUTkvei9YaWdH?=
 =?utf-8?B?Q1VtZ1BZZlVsM2ovenJZTDY0K3kvbUhzZFlqMTRQRlB1dUMwVDZuNWsrd05v?=
 =?utf-8?B?K1kwbXI3aGVIWlhxa3dyamU5N3NwSjZoUCt1ZGRjdEY2MGNWaVRRZ0tML0h5?=
 =?utf-8?B?b2RhZy83STZrMlp6RjZYZnhLNTlFUlkyNmFqKzVHWFJJNUhqQXVNSDRYTmNU?=
 =?utf-8?B?R3FSemlsMEQxN205eEplbjhTQ0F6bTNrL2MxeE9SREdJQTdneGN4em54VFp3?=
 =?utf-8?B?TGY3L0JvRlZhUUdzaEtiazdRbHNTYXpqK3hNc25nNk1SMGdkdnpWMHZJdXdM?=
 =?utf-8?B?U2M5WFF3Tk5lcHNXNnRITUlzQjgySFFQbG9Zazd6S1l1QU1YRnFnenRWQml0?=
 =?utf-8?B?L3FEMkhoeUZXajRVVjQ0NHREaWtabEg1b2tBdThxemdaaWFPMkY5eEEzYXU0?=
 =?utf-8?B?TEdIWWZlZmRiT1RLM3hMbnBERS9CZjlUTWJlR3ZIVlZFbi95MkMrYXlsK1l0?=
 =?utf-8?B?bDMrcld3Mm40d0FERmliWXRSK0xKd2Z0UGo2UHozTXFaNmdrQjBDaGNsZTFk?=
 =?utf-8?B?aTRMeTJNKzhCdTc5SmpoNjdSWlZQdGtteXl0OHVyS3JIUWN6S0drRUlBd3Jq?=
 =?utf-8?B?bUc2bmFQTXRvZFY0a284Y0doUG9DSlA5S0ovbFlRNm5GUkRRNk1mS1JFcG1h?=
 =?utf-8?B?WW9kZXA5RFU5VU11UEZNYmdrVTRteGhxS1U0aEVJNERFUkRZWENjVHIyNGFR?=
 =?utf-8?B?S3ZSZ3o5NGViVEdjTEk4WDFSWFJwajAvZy9ocW44azNCay9td1AzK0JNeXBN?=
 =?utf-8?B?bTVBVEFDanQwWXBTSDgrMEN6L09odUNwZjFjZnByTHU3RVZzSzZXQjhFQlhE?=
 =?utf-8?B?Yi9HQURpTjN3bjVjUHZucEIrSEVzVnFHNGRtUlE2TEdDeWtZcGFUbXliY2hH?=
 =?utf-8?B?VHhWb1FLaUhHM0QvcTR6ZFpJdWZ1YmFUM004MWhHQjkyVTJJcTFkcVRnbmhh?=
 =?utf-8?B?VzRaOHdGMzl6cVg5NUs2WXc4bzBxZUFLZWZkUEk5bWhxcEVvUWYvTEN5K3Mz?=
 =?utf-8?B?Njd0VTRZWVNrdEQvenNucHpHaWI1TTBUZXVhWllUVE5pUjlieU9yMFhRSUZS?=
 =?utf-8?B?dXdjMjNidGQ0aTRid25xMUpFYnBKSVpOK3FJNVdmWGJLWkRDVE5nTngvNVpP?=
 =?utf-8?B?QVcralBIZXNvaFppWEhNYm5hVk1RSDlhTGdlcTJRcisxb3BiZUZiMW9UazV2?=
 =?utf-8?B?c09OYVViUksvSkJjN1hxdzBrOVh6cXpDMGlNOHFSc3h2VlR5bXVrcVNMMjRC?=
 =?utf-8?B?dDVwSzFRVHNwanhETlFwamxaY0ZaemJWKzZoUHlpN09kT1hMZk9yQkJZaE5h?=
 =?utf-8?B?SEdoRGtFZlQyNUZTb1pkNGRLdlhQSU55OTdzSU0zeW9YazBQQS9ubE1FL2pI?=
 =?utf-8?B?dS9uK1pFaVZjUVRwM2k3cG5qMnkvN0ZBWll6RWZMOHZIUzFzVnRhOE8zUW1R?=
 =?utf-8?B?VXc3UWg0aXB3MWNkeGVvVjhVcUhPa3QxNUFIdDZXZUNwWFN3RVpwcm55VVRl?=
 =?utf-8?B?RXlvWkM5Z0xsc1U2VmdiT0ZaQlBqOHBFTEZaSHNTQ0RLN2dTdEdaUEVIaUpG?=
 =?utf-8?B?UEltb2x4Nnp6bkhMRlBDT2xPVmovaG1YL2VKditPZ3ZlNk1SRng5Uk01N1dk?=
 =?utf-8?B?SmNFYUR0WWFGNVprbmRDTzRQdVJ3PT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <26A2254FBD64054290AD8F9DDD9DE962@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 17f893fb-916b-4e47-6795-08d9efbeda64
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Feb 2022 13:35:23.5848
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Z9i2QgF1a5U0hAWt6XsYM5yj9KuaOl2MUK+JaV463JsI/ZP7OdSQFFo3cyblBzttfZ3FQyj1CLMl0iF7mqLkIsS7QLl7GuR0dNTw4S19ksA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR03MB2872
X-OriginatorOrg: citrix.com

T24gMTQvMDIvMjAyMiAxMzoxMCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDE0LjAyLjIwMjIg
MTM6NTYsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiAtLS0gYS94ZW4vYXJjaC94ODYvaHZtL2h2
bS5jDQo+PiArKysgYi94ZW4vYXJjaC94ODYvaHZtL2h2bS5jDQo+PiBAQCAtODgsNyArODgsNyBA
QCB1bnNpZ25lZCBpbnQgb3B0X2h2bV9kZWJ1Z19sZXZlbCBfX3JlYWRfbW9zdGx5Ow0KPj4gIGlu
dGVnZXJfcGFyYW0oImh2bV9kZWJ1ZyIsIG9wdF9odm1fZGVidWdfbGV2ZWwpOw0KPj4gICNlbmRp
Zg0KPj4gIA0KPj4gLXN0cnVjdCBodm1fZnVuY3Rpb25fdGFibGUgaHZtX2Z1bmNzIF9fcmVhZF9t
b3N0bHk7DQo+PiArc3RydWN0IGh2bV9mdW5jdGlvbl90YWJsZSBfX3JvX2FmdGVyX2luaXQgaHZt
X2Z1bmNzOw0KPiBTdHJpY3RseSBzcGVha2luZyB0aGlzIGlzIGFuIHVucmVsYXRlZCBjaGFuZ2Uu
IEknbSBmaW5lIHdpdGggaXQgbGl2aW5nIGhlcmUsDQo+IGJ1dCBoYWxmIGEgc2VudGVuY2Ugd291
bGQgYmUgbmljZSBpbiB0aGUgZGVzY3JpcHRpb24uDQoNCkkgY291bGQgc3BsaXQgaXQgb3V0LCBi
dXQgd2UgY291bGQgcHJvYmFibHkgbWFrZSAyMDAgcGF0Y2hlcyBvZg0KInNwcmlua2xlIHNvbWUg
X19yb19hZnRlcl9pbml0IGFyb3VuZCwgbm93IHRoYXQgaXQgZXhpc3RzIi4NCg0KPg0KPj4gLS0t
IGEveGVuL2FyY2gveDg2L2h2bS9zdm0vc3ZtLmMNCj4+ICsrKyBiL3hlbi9hcmNoL3g4Ni9odm0v
c3ZtL3N2bS5jDQo+PiBAQCAtMjUxMyw3ICsyNTEzLDcgQEAgc3RhdGljIHZvaWQgY2ZfY2hlY2sg
c3ZtX3NldF9yZWcoc3RydWN0IHZjcHUgKnYsIHVuc2lnbmVkIGludCByZWcsIHVpbnQ2NF90IHZh
bCkNCj4+ICAgICAgfQ0KPj4gIH0NCj4+ICANCj4+IC1zdGF0aWMgc3RydWN0IGh2bV9mdW5jdGlv
bl90YWJsZSBfX2luaXRkYXRhIHN2bV9mdW5jdGlvbl90YWJsZSA9IHsNCj4+ICtzdGF0aWMgc3Ry
dWN0IGh2bV9mdW5jdGlvbl90YWJsZSBfX2luaXRkYXRhX2NmX2Nsb2JiZXIgc3ZtX2Z1bmN0aW9u
X3RhYmxlID0gew0KPj4gICAgICAubmFtZSAgICAgICAgICAgICAgICAgPSAiU1ZNIiwNCj4+ICAg
ICAgLmNwdV91cF9wcmVwYXJlICAgICAgID0gc3ZtX2NwdV91cF9wcmVwYXJlLA0KPj4gICAgICAu
Y3B1X2RlYWQgICAgICAgICAgICAgPSBzdm1fY3B1X2RlYWQsDQo+PiBkaWZmIC0tZ2l0IGEveGVu
L2FyY2gveDg2L2h2bS92bXgvdm14LmMgYi94ZW4vYXJjaC94ODYvaHZtL3ZteC92bXguYw0KPj4g
aW5kZXggNDFkYjUzOGE5ZTNkLi43NThkZjMzMjE4ODQgMTAwNjQ0DQo+PiAtLS0gYS94ZW4vYXJj
aC94ODYvaHZtL3ZteC92bXguYw0KPj4gKysrIGIveGVuL2FyY2gveDg2L2h2bS92bXgvdm14LmMN
Cj4+IEBAIC0yNDczLDcgKzI0NzMsNyBAQCBzdGF0aWMgdm9pZCBjZl9jaGVjayB2bXhfc2V0X3Jl
ZyhzdHJ1Y3QgdmNwdSAqdiwgdW5zaWduZWQgaW50IHJlZywgdWludDY0X3QgdmFsKQ0KPj4gICAg
ICB2bXhfdm1jc19leGl0KHYpOw0KPj4gIH0NCj4+ICANCj4+IC1zdGF0aWMgc3RydWN0IGh2bV9m
dW5jdGlvbl90YWJsZSBfX2luaXRkYXRhIHZteF9mdW5jdGlvbl90YWJsZSA9IHsNCj4+ICtzdGF0
aWMgc3RydWN0IGh2bV9mdW5jdGlvbl90YWJsZSBfX2luaXRkYXRhX2NmX2Nsb2JiZXIgdm14X2Z1
bmN0aW9uX3RhYmxlID0gew0KPj4gICAgICAubmFtZSAgICAgICAgICAgICAgICAgPSAiVk1YIiwN
Cj4+ICAgICAgLmNwdV91cF9wcmVwYXJlICAgICAgID0gdm14X2NwdV91cF9wcmVwYXJlLA0KPj4g
ICAgICAuY3B1X2RlYWQgICAgICAgICAgICAgPSB2bXhfY3B1X2RlYWQsDQo+IFdoaWxlIEknZCBs
aWtlIHRvIHJlLXJhaXNlIG15IGNvbmNlcm4gcmVnYXJkaW5nIHRoZSBub24tcG9pbnRlciBmaWVs
ZHMNCj4gaW4gdGhlc2Ugc3RydWN0dXJlIGluc3RhbmNlcyAoanVzdCBjb25zaWRlciBhIHNlcXVl
bmNlIG9mIGVub3VnaCBib29sDQo+IGJpdGZpZWxkcywgd2hpY2ggZWZmZWN0aXZlbHkgY2FuIGV4
cHJlc3MgYW55IHZhbHVlLCBpbmNsdWRpbmcgb25lcw0KPiB3aGljaCB3b3VsZCBhcHBlYXIgbGlr
ZSBwb2ludGVycyBpbnRvIC50ZXh0KSwgc2luY2UgZm9yIG5vdyBhbGwgaXMgb2theQ0KPiBhZmFp
Y3Q6DQo+IFJldmlld2VkLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQoNCkkg
c2hvdWxkIHByb2JhYmx5IHB1dCBzb21ldGhpbmcgaW4gdGhlIGNvbW1pdCBtZXNzYWdlIHRvby7C
oCBJdCBpcyBhDQp0aGVvcmV0aWNhbCByaXNrLCBidXQgbm90IChJTU8pIGEgcHJhY3RpY2FsIG9u
ZS4NCg0KfkFuZHJldw0K


From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:38:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:38:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272253.467017 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbYP-0007zV-HF; Mon, 14 Feb 2022 13:38:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272253.467017; Mon, 14 Feb 2022 13:38:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbYP-0007zO-E5; Mon, 14 Feb 2022 13:38:09 +0000
Received: by outflank-mailman (input) for mailman id 272253;
 Mon, 14 Feb 2022 13:38:08 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KkXt=S5=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nJbYN-0007zI-UG
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:38:08 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 573224e2-8d9b-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 14:38:06 +0100 (CET)
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur01lp2056.outbound.protection.outlook.com [104.47.0.56]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-30-usdHW8q0OfKHMs0ImxtQAA-1; Mon, 14 Feb 2022 14:38:05 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM0PR04MB6036.eurprd04.prod.outlook.com (2603:10a6:208:146::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.18; Mon, 14 Feb
 2022 13:38:03 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4975.015; Mon, 14 Feb 2022
 13:38:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 573224e2-8d9b-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644845886;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Z3f2t+XhwEtN4J8hpx0P3ybYg15Md7WRWj+4V2dsWfU=;
	b=DvtsuS4tBp1Xtu6+FOFbYeFqtz5SAj10lQEQROaOPCW2FinTujDl/eqWJMpTWzH5PockYO
	/uKp5EzxvwrVcinyeCBbJRPOJqFDdILiQj9crpfnmShUw97EawyaFWDl/dBxCnpLvQhGvM
	mRB19RWB3pFMJRP7syFVac2seNKoUn8=
X-MC-Unique: usdHW8q0OfKHMs0ImxtQAA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=egDAskVMfwBh1VfTdNfd/ISMgSxp4oJbxOkyqlmNHchTipJMEZ5scmsU7/8wNq5xtw7C7c7iCm2YSstCFLLiuO7mucrFIvEJZE8T7lvqyp3Bn0ZnSmSTD6Y4F/nPEBuB/+caEIA6DcXx1/wOA09DS0iA/qUTdk6xwC7ziiMP+Ks2fjAR8npH3QCudkJF4M6yOQNz/cZyN3zZxdhckUE5YFWHm5Le2ADor2IXQO07Uo487s4JK70B068sCk/QoGrdRvRZGyVGUb+ITSJz3qhKveHIadjoBqNl1xT2y6ajDvLOFfS1T2v9MJ1jEvuLZQ6KWOAs+FqCgPN2/PMHI+JKcQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Z3f2t+XhwEtN4J8hpx0P3ybYg15Md7WRWj+4V2dsWfU=;
 b=Tj/RlJuXMxTELeC5Sa6YBDMEDTgq18M2cXZVx5TkQfz0KiI7SepEhqZ6ASfMkzDXSpwTXIeMTg4Vs4CzLYRHQft/wVIblE0T6U9Unxb/67GmuYpMihkiNhsCi428fxAOaT5C1Q/Eeuwqs+Rak08cM4iE1UZd4gY+bN+MQ1EoXsNtwRVbuYDXVcCp9gqu1WqNdLTVGyrzpnHxy8A10UeOJXTB598Ii/p6RCWn2ThPraHZgupaVIYX7/roTeq+8CmESBBZU/aGcMVlgWwLQMiGOP0lzJpOveYANCZX4bWw8I2fqUyXyeFVrgIqa7WzXDYVwBsydpS/nfH/Z9o4QX0V+A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <2a5e1893-506e-e4fc-dbff-6001feec1e99@suse.com>
Date: Mon, 14 Feb 2022 14:38:01 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH v2 34/70] x86/emul: CFI hardening
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
 <20220214125127.17985-35-andrew.cooper3@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220214125127.17985-35-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0022.eurprd06.prod.outlook.com
 (2603:10a6:20b:462::14) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 217ba6f6-0b3d-47d4-7e4d-08d9efbf3995
X-MS-TrafficTypeDiagnostic: AM0PR04MB6036:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB6036C9680C78A10B332C2C3EB3339@AM0PR04MB6036.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7219;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	P87r0dfWyyO8nG8uuRIVHxbrbJMafKVmhJwarLGYGS8F7N/gY04FXvT8l+D9hF+oVKM1LBS5JqST/Ocs4fUeDPKmly1SeXidb06SG3gYGBsL3GpNRbbdzsdtnsbh1pW2khhL6h2RBu2SegRCR5NPRVINa2OGFnGiYEpBrSnT0oz3+LjbnNEq3/fXK/ITDx+gPQzBBGPkMFaFz6m+ns7WX/dAD5FHtbkJGIWutfgw8yfgS5KXe6P7+tJtM+nvMg5VJjhanwAtYWVgRqwoHkX160jOcnDTCvGWD38h61WKRFB2ayMhjQORoatxoybcow8VM9rmxbpMk427/BilV/hqUcIc776F6dNHuUbaLz30EGZfJdgMzjee7NKuYT/0rVMM8uxGZCIhPu9MM8JfQdLEyR9cIeWPGDGqDj9xCjEJ4pDYYpclywruwYlxCW6HVzPPRlR4GmSe+7XZRavX8yy19nP4r5JOvF0Xexwj03xEzzI/G8WXJ2GaNTK9kCxIO/mihUz8BWLY3rdanxcQZafxpHDH9/xrEEZ5mjOLnuytQbYjBb59pgjGBVDKmKzHtoY1yULwzmPG3Tres0vSMjCsVPI6N2pNfpZAr51mYbkp1oxf62L27CE2UWfb9i1u0Jp3B//iP3h4ULUm85W+igvoTgtWUHfkI4/DQmdm/WLFqIk2LbEqyFXDuKczKYWLr10s7KeH/mf2dBAdMoXBcj6zUPtzKzwCGPVqJkqxPYeLgaQ=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66946007)(66556008)(4326008)(66476007)(8936002)(2616005)(8676002)(2906002)(53546011)(38100700002)(6506007)(6512007)(5660300002)(4744005)(6916009)(186003)(26005)(31696002)(36756003)(6486002)(31686004)(86362001)(316002)(508600001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZEw1ODgyOFZmeEp3VC9TbGNOOE5SYm0rcGNEalNnRW5Jc1NTaEx0RVp4UXQ0?=
 =?utf-8?B?b1JTd0ZLckk3S0had0ZGNEs0TDFJVUJFMjlDVm40cjUwTG1GVnluUGxvUHNt?=
 =?utf-8?B?WVl0ODN3V3Q3Mk1EUTE5MHdFcjNZSk5GVTJ6STI0TWhHUlA4bThPMVJGK3Fh?=
 =?utf-8?B?Qi9mdDlPTmdHeXRsQUIxY0lqMURCWXJLeWJOT0U3b2VEc2N5cE85eWErVU1K?=
 =?utf-8?B?YUY4SlZsdzRjUGg2MVM4UTBteU12ZDZWQlk1WE8zc1ROQmdtQWlnU1ZPdGlK?=
 =?utf-8?B?VlM5d09KSldwdElyODJuZndRenZKTnA4cG0zQ0FJeHBwL3RxUUpmRG5EUEVQ?=
 =?utf-8?B?di9UaklxOWhDSmluMFdwTmFWVHNKKzFoUXMrOTNNMEJLcGFIUzVmNW4ra0ln?=
 =?utf-8?B?aFJ0UGhUbkoxZEdOenNOdTNMcVc1bjk2NVZDaUZ2dlJ0MmFMa1FGSEJJMXVn?=
 =?utf-8?B?REtXY1FyVjQ1RDh5NTJjU1hwNDhrSG0xQkpBTXpQZzA4d1pXQTZaNzRsVUdI?=
 =?utf-8?B?YlB1MjBaMDA5UXZtakxUWXVWNnhKUnhDQ3AwU25DdkpxeVVnUkpkSVRDZ1Ji?=
 =?utf-8?B?THlPVWtHK20xRXhBZDM2SWdiaWtKMEt0WWswOHk5SStzQys0bExFTlgvVW9y?=
 =?utf-8?B?MUY0OHFENFJzRzV1V3g3YkpEcVhScmVhVTd1WElLVmFYZnpnWVNUMDZhZ2FO?=
 =?utf-8?B?aUNFNUJ1eGdXbk9lZlU4TzFST3ZVV0FJc05OekFIZ21xeXpBY3FZMHRkNHBZ?=
 =?utf-8?B?aGt0R2ZHaFVHTjhvT2lLVEloc2ZWUTFVazNQbkh5d2lGZ2JnZE9GRDZUbDRo?=
 =?utf-8?B?NVNuKzhwZ0pRL3Q2Uit3UmczRVhSNFJWdUpaMDFnQTVqaW03T2M4ckdBbVpH?=
 =?utf-8?B?aVV3UktNWWhCVWxtaGxmNzdGbWtieGxTRzErZ3ZDdWdDRXlwUlphWUFmMDFl?=
 =?utf-8?B?MHhnaW44aHM5WVpzdFhWMTQ3YU5ueU8wVXhVK05TOEkzM2tzc3pKeExweWU4?=
 =?utf-8?B?Sk9ZWDkwWTd5TGV4eGsvWkJCdXJ2TUhVemtxRkdEdUFPT2R4YjI0RlIxVkht?=
 =?utf-8?B?WUhtT0dJN3JmVFBHQ2FxYUprYzNJdnNZZXZ2QkNzZFZhK3h0aHlLUDRIUkhj?=
 =?utf-8?B?NnhtbDFGOTZCR01LYU9YdGJUREtkc2JIQ2RMa2RMZkNHOUo5UnlEc2JKRk5K?=
 =?utf-8?B?c1ZQOHE2a2FrQnJWWjc0S0NyTW1qa1dtUldxUytPVjR2NUNTVXpYVVZqbGNs?=
 =?utf-8?B?SkoyWGpOc0h6STZCRkVqZjRNVFlhN01LRXBVOWs0OWlOR3pBc05ybDYxeEpY?=
 =?utf-8?B?NXM1QythT2x3Zy8xdXV3T1JON2EvRU4vYXZ6R2JxOXJ4Rk5wN3ZKZ1BzQVJY?=
 =?utf-8?B?WmdJR1A0dGhhdFh0YW1DM25pZU1FNEVJKytyRHpZZnEzTkF1V3VwNVJBbnRH?=
 =?utf-8?B?UEhXdHVoWHFiR0ZVQmszeXM4Tkl4bDRzSVFXdkRKeHBkc3pMWG5MWWhkbGIv?=
 =?utf-8?B?VENVKzJTMFV4MjJXQ2Fyc3BOQzFqS2ZIVjBBeVZ6ZGhpbnp1NlBCT1E0UmxY?=
 =?utf-8?B?Sjc1bzhtTGNRd3RnTGtCVUdSUk1EbUQwZXVuS2VJVGdKdWEzRE1GZEhBTjNH?=
 =?utf-8?B?Ky84MVJpa2VucUEyQlRxZVp5YVdRTXllQmJQZi80aWJCcGRHbWNybGhGZWVB?=
 =?utf-8?B?MVlBZXhGSzUvODRkb0kvQ3YwZis2eURmSVlyekMzZ1JzeVZ1a2t0YXh6L0Np?=
 =?utf-8?B?eVljWFVDbDd1WG1JbXlhZ3ZMKy9CdW5OdGtGUnlkUEdzQm9YQkhKNXhWdnlT?=
 =?utf-8?B?WlRaK0xxdWM1QVJ3QjRnZ0dpMjk4TE5namdQaHR6N3hPcEdGK1NCTXBXSFhW?=
 =?utf-8?B?YUliMUVMeVlkK3hFYlZ6ZlRESlcxeXNYdkZwZXNmLzdBNDRjRTNNZEVmTnh6?=
 =?utf-8?B?MDArdUVIY3VhUDBHYm9FZWNaN0RRNzFlTHVvaGR6L1E2SWJoOUh5STJIb2Na?=
 =?utf-8?B?TnExZ0tabjdXODcwQnVsR09tVThQdnBhRVpGeFMzQ1Q5dU01SjZsOWgrR1Ur?=
 =?utf-8?B?cU56UWZDY2xVMHJqcHVkK3pBZXJYN01YcERJSlFvdmplUExsTDM3aERISThv?=
 =?utf-8?B?Q2xaeFB2RnZmRndFVnRhMmZVa25pay9ndk5JM21aQ01XUk43MWhDSUY2T05M?=
 =?utf-8?Q?2E+fSxPsm6B42CZeiR1A4Vg=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 217ba6f6-0b3d-47d4-7e4d-08d9efbf3995
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2022 13:38:03.5557
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wPTS6Ioc3jOJ0VvcMZjo1jVZyX/rhHIXvN27uEfUpzWLGEcQifCV3+jKKNdMEVGc1cmNir3zocNCL21+Cc4Ftw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6036

On 14.02.2022 13:50, Andrew Cooper wrote:
> Control Flow Integrity schemes use toolchain and optionally hardware support
> to help protect against call/jump/return oriented programming attacks.
> 
> Use cf_check to annotate function pointer targets for the toolchain.
> 
> pv_emul_is_mem_write() is only used in a single file.  Having it as a static
> inline is pointless because it can't be inlined to begin with.

I'd like you to consider to re-word this: It being static inline was for
the case of there appearing a 2nd user. I don't view such as pointless.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:43:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:43:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272261.467028 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbdI-0000y1-4J; Mon, 14 Feb 2022 13:43:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272261.467028; Mon, 14 Feb 2022 13:43:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbdI-0000xu-1O; Mon, 14 Feb 2022 13:43:12 +0000
Received: by outflank-mailman (input) for mailman id 272261;
 Mon, 14 Feb 2022 13:43:10 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KkXt=S5=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nJbdG-0000xo-JL
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:43:10 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0bc4ce9e-8d9c-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 14:43:09 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2054.outbound.protection.outlook.com [104.47.14.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-2-SkjtdDXyOgi9PC3ifHHKbQ-1; Mon, 14 Feb 2022 14:43:08 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DB7PR04MB4892.eurprd04.prod.outlook.com (2603:10a6:10:14::24) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.16; Mon, 14 Feb
 2022 13:43:05 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4975.015; Mon, 14 Feb 2022
 13:43:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0bc4ce9e-8d9c-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644846189;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=rpjvohe7/2DY3uLEpHfm43hJQI2ASb+gesXx34lCGsQ=;
	b=fcblCHBS2FQG9ZIrP3grdHrMe0uyBec1Y91nL3CbaWbZk9QkgbX9uXqxGs8esTAqGFo8IX
	QzDXjxxPporfaZ6SW/ysysN+1cvDWft09jtpdbuvbb+ylK/N3cGVJDdAl7AJAy6ikXzMJv
	LrAOyyadLFOT47JBp+arL//KgPuv3Fw=
X-MC-Unique: SkjtdDXyOgi9PC3ifHHKbQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gHKefa2c73GIXz3YHpSEJaDMFQMga/B8t1IxV9jFkM4R1ll/nUK3gsrrVAsI8NSKfvy27rog+SEixqjfuuWHiKu6AvLKMn10JKKcGldhpDKUV6y2HxUBctYi8C9Uk7cfQsX2Q4HdjXkGhofgHRiw6D6rM7VZwmfrUCp6ZCd8+doB+fWiAkpqZcOS2I79Mc6P0UJ/vr5DWMtKD44VJ8eNGpShLCwPY1EaTashdyAzMc9YxI+CCXYH4jgoQVngKn3oGXbzwQIy94fvkRVFxIpC2EsbnbZxF57prkXk4mraEM9mFg/fxu5FUqvPOmUgpTrmzSFhzdxcbyNLFjdAKAXGsw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=rpjvohe7/2DY3uLEpHfm43hJQI2ASb+gesXx34lCGsQ=;
 b=D5x1aM7o34ZpCF73SMpXPoX48SuD23XrE6GTJjP9TkqEt/p5yk2HS6qbKa5j3iNFmG6bsiJB4a++SruYZZZY29MebrsVuaFhenwJNqBJkOEZToamtQUFV/1RTVkVInfGe4IVJo8gqWJeDxroTcsQKe11hxNzK4tZY8uHLKbgIlEajJ9B2UzkJv2FeziixLRBGDkB46+YBRaDu6QWmGo7HYQsa2tePTiiF/u+KtqAIrwUaozRvuI2Uc8sv9hwWqvPuorSOSG0FhgolWUjAFILVS0Yhl1KzNoSW7GoIRKlUvTkUrWLLV/Wtc2Vf/ArA0NSH1gOdAp9TTb9tIRFeGgE4w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <218de2dc-6dd8-4e13-3288-36448e47de7f@suse.com>
Date: Mon, 14 Feb 2022 14:43:03 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH v2 00/70] x86: Support for CET Indirect Branch Tracking
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Julien Grall <julien@xen.org>, Roger Pau Monne <roger.pau@citrix.com>,
 Juergen Gross <jgross@suse.com>, Daniel Smith
 <dpsmith@apertussolutions.com>,
 =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
 <c471dcc2-8a91-60b8-ba5d-58874752e4d7@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <c471dcc2-8a91-60b8-ba5d-58874752e4d7@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR0P281CA0075.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:1e::10) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5bd81eed-92c7-4ade-cec6-08d9efbfed53
X-MS-TrafficTypeDiagnostic: DB7PR04MB4892:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<DB7PR04MB48922BB0ADCC29862E0E1AEDB3339@DB7PR04MB4892.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	3b9UxjHBqKs5s+lo/Um7Ap+MLM5uVVEpN8Aor3or2CW7l8gbGMxgvlcfqpFQpxg4FtjIMKHeYiKnI5T3XfSgQg9IXXqCkd0JnqlrYmtov895LUKeeNFf/t/YBTctf+NHdtIoPREgBHhuZ2kAuNApjFfGEcAoP+9nzc+LkLJadLdt8DQEliGMzxe010GUfsgkuza5mBoMpHP3MsNZCGDEqnio/Qxn2771EIB9x+eyBfi/L/wBf2PIIhQdInjsx2gPnnQgVmpjtwcN3fZ1EGxtxThKN5VWlnPLHcYh/yuCqjbDv6dsV21DFy3x+zgiFb0cWgGwIm6m91QyhBN9skliyXK56EzzWQGCy07MvbAMenh6eBmnLDW9xsP2FXFiGPpaXM/LpyCunZQgBDX7qaFqTOkmOfVcOsl60L3M0CGdUkYXPWTkx2E/VtVnmtRap/yNA0vnpXT8rm4D91Vvxa74evuzo799GHyCC2c6krkMWEduoosO47i7SYPcifwT3PpK24mTrqc+8gRHmfNlKTWGBtGsAjbsH8cwtjPym9Q6ZSFk4waVV/5SRMl2WY6IMUVKp6otQ83gi2s5oJgLFby7yTehNhFm4h4a0+xzRYCrwopCm8LeK48mYtUE7EPHowlrIji/vOVLYO+jx+65bUCBdvCkwslJ1n6VrHgfeLfnpLi+Xp7zDdAR51cU+G8MkdMXc2aPrQsH/TGmy3TDtla7zEb2352nZ7T+Qrris650xsua5VXuPbcCzSafK9JEqCCQoGdSkOB/yqyoTUXcvcWYib3wWpruXzPu9ubV4dtEwuHQ9VNJsLJCVlipk4JkSNMZ
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(38100700002)(5660300002)(8936002)(316002)(66476007)(66556008)(2906002)(8676002)(66946007)(4326008)(36756003)(6486002)(31696002)(31686004)(86362001)(26005)(186003)(6512007)(6506007)(53546011)(2616005)(966005)(508600001)(6916009)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?V3NWS0d5VjlOM0pFR1lKTTRLNWdBQVdLZDNQSXg3UllyalFmUXBOZjlUaXlK?=
 =?utf-8?B?WitmMXFCT2gvdlhJai9tLzB2VGpxOHJCcU5PRDJNZGNhU0JTMDlEdzhXNzJJ?=
 =?utf-8?B?N1hLMEpTV2hON0RHTFhMS1dseEp0c1JCVkRWRGpOUWtWS2JOWDBkOG14dndT?=
 =?utf-8?B?WDFQMTJFYzhHRjJpb203L0ZObmZYT3RCdlpTY3pNcko1clUrUGxHZFkwTER1?=
 =?utf-8?B?Sm9PWXNuN1dRSW9naEVKeWFHeWpUcjI4d2lVbnorUldBaVBFempTQmt4UlhN?=
 =?utf-8?B?V2tmQmNjclNOOG9pTHIxY0ZZSzQrOEJ2TUxiU0puTHhHNVFqd05BTGJZUmdT?=
 =?utf-8?B?WlJldUw1YTBmTWltdFRlVE9yR2lEZ2VtTGI1Y255cUxTL3FKUmNBNVcwWldM?=
 =?utf-8?B?Zmx3eDV5N21vVmdhQlJRakpUNjVVUFc2anoyS2sxZFBjYkQ3c2hGelFDKzlv?=
 =?utf-8?B?bFNuUEo2TGluTzJxNjFsNHljMkFMSHBvYWhvZEVxVUVGR0xxaWR0MDVSbG9U?=
 =?utf-8?B?aWtNQVhGWGJHYmE0clQ5blc2ZWdkb1RiWWF2dkdUZ0lLZkkxTnJFRzlRSytn?=
 =?utf-8?B?UU9nMjNpYmZyY00xcHdlTFlNaHducVBmOEVHRVZsbFpUNlFtVWdXL1UzN2lH?=
 =?utf-8?B?RjdLKzQvTTZhMEVtRmRFZzJ0SWpxUjBsaEdKemVYOExWTTFJUC8vSm1vQmdr?=
 =?utf-8?B?RG0yUjNla1hFWUtaSytGM3NOY0R0UTFOZ2RrV2xxVk1YK3VIVHhUODU1TTlQ?=
 =?utf-8?B?bWRKL0FBV1VKbGdhRktrK1NwczAvNGhBbDBMMDlyWkVDUjFzZVYrbXUyUVFJ?=
 =?utf-8?B?RkVqd2RKSFV1SldvdEJWbzc5UUtDMWVaVWZRRXZKNTBrR3FlbytKTEg4a2E5?=
 =?utf-8?B?V0dieFJyZjkvS282QnduaVNlMjJRcTJNSGVoZWFrRFVEZVQ0b1oyRGlJeWFJ?=
 =?utf-8?B?eEltZkZjcExqaTlXQ2dBUksrNnZNNHZ4M09CbFVweW84S3dqVHBpSWlNTzJ3?=
 =?utf-8?B?ZWQzdVM4VENJYk4wekVuckN5NmlyYmZveGVkTVJlR3I1cFhESTd3T0l6NThh?=
 =?utf-8?B?U1dVVGVtNVZieFlZQ3piS01tSjc1SUMvL3ZsNnlrbERsVUxyZFRqODk3UUhQ?=
 =?utf-8?B?di9nYWxXRFNqSzhTV0JFd0NlaFBjRFR5SVgvZTN3S0JoR3BjVjVkWnV0MFo2?=
 =?utf-8?B?VzgvZW4zcVpiOVF6Sk9sSXpteWQwbk5URDh1T2RER0VOYm5GWjVhYmdwN0Fj?=
 =?utf-8?B?cXJ2K2xTZFc2SXI4V1k2b1B3QnpzOHFTcTlYbjBuTVh4VE9XcEhtTVFXQkY5?=
 =?utf-8?B?SGxtYzAzajZBVTN1ak1GQVBkOWZjMXNJUEd2STZJdkJxQ0xCdVI2eEgvNGJ6?=
 =?utf-8?B?NkpsdGJxU0xValpSS0FyOXpVY3c2THFPV1NOZnJUaElkS0xtZGlyN1FtaUZj?=
 =?utf-8?B?aGdNWkRoOUhZcFVRNEtuUC90eEp1RTBNeVl1cVZ5R0taNm9uRVJvTnhEL0h1?=
 =?utf-8?B?YWJtRTZkbWdsT00zZUtQRGRDWTh1T0JKeEtMdStaUjNOR2hweGh6NWUzMXY4?=
 =?utf-8?B?NzVJeDJsKzhSQmFUZkpqNjF2OW8rZ0tWbHVIeDdzYkJURzgrRXRvclErQnk1?=
 =?utf-8?B?K3I5SVNSU3N6U3F4U2dNcW5LL2tGdnRNelNyd2QxYkZRQ25HOWdWV1k0QTE5?=
 =?utf-8?B?bkUzc3F2QjRiNHZHYlVFOFBxRVArUS9ydURxSEVHNHFWMmNzNTE0WnFqaVds?=
 =?utf-8?B?UUVTZ0tvTHoyWFpXYzBZVnFJb3hPb2l5Y0pJQm43YzFEU2hZSDQyTjhGcGRL?=
 =?utf-8?B?K1VSQzNlRzE2UHRFNHFzK0wwTDhXN1ZxQTM4dmZyakt1UXd4TzErTlU2TTk5?=
 =?utf-8?B?YWpVMU8xQW9BTzQrWGU1L2l0bGtrWmUwQTQ1emlZNEM5RHluTVZkdS9PbUwy?=
 =?utf-8?B?UWZjZTUrekxMb0VjYTc1OFFKcDlOdDNXanJNVEhSWkpvblZJMFRibS9Ccitr?=
 =?utf-8?B?SzZVdFhOM0xMY1U3ZDAxako5Y3JSRGFlYm9neUtvVytaTmJOVTFYWUszUXVz?=
 =?utf-8?B?RkgvcHM3Skk3SnpTVnZDVUFKVXJ6dXFsUUpEZ2IwUE1vb2RKU29RWm9ERkpO?=
 =?utf-8?B?OGZ2ZUdWQ09MR1dVeXJyNXR6SFFzTEFzcnVkMXVkckJNQ29CdUVHOXhmUlZ0?=
 =?utf-8?Q?AwKOLBlwT2gnL89Y1xnqLmw=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5bd81eed-92c7-4ade-cec6-08d9efbfed53
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2022 13:43:05.0526
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wPNLTwYwyiSf2N8TnjySIuVK9VYASxWm6PeWL13pA8XSi5I7a7k3zWjWRw1y69pJ/Ko0fzDCFisyTi/U+MBGGw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4892

On 14.02.2022 14:10, Andrew Cooper wrote:
> On 14/02/2022 12:50, Andrew Cooper wrote:
>> CET Indirect Branch Tracking is a hardware feature designed to protect against
>> forward-edge control flow hijacking (Call/Jump oriented programming), and is a
>> companion feature to CET Shadow Stacks added in Xen 4.14.
>>
>> Patches 1 thru 5 are prerequisites.  Patches 6 thru 60 are fairly mechanical
>> annotations of function pointer targets.  Patches 61 thru 70 are the final
>> enablement of CET-IBT.
>>
>> This series functions correctly with GCC 9 and later, although an experimental
>> GCC patch is required to get more helpful typechecking at build time.
>>
>> Tested on a TigerLake NUC.
>>
>> CI pipelines:
>>   https://gitlab.com/xen-project/people/andyhhp/xen/-/pipelines/470453652
>>   https://cirrus-ci.com/build/4962308362338304
>>
>> Major changes from v1:
>>  * Boilerplate for mechanical commits
>>  * UEFI runtime services unconditionally disable IBT
>>  * Comprehensive build time check for embedded endbr's
> 
> There's one thing I considered, and wanted to discuss.
> 
> I'm tempted to rename cf_check to cfi for the function annotation, as
> it's shorter without reducing clarity.

What would the 'i' stand for in this acronym? Irrespective of the answer
I'd like to point out the name collision with the CFI directives at
assembler level. This isn't necessarily an objection (I'm certainly for
shortening), but we want to avoid introducing confusion.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:48:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:48:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272270.467039 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbiI-0001kj-Rq; Mon, 14 Feb 2022 13:48:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272270.467039; Mon, 14 Feb 2022 13:48:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbiI-0001kc-Oo; Mon, 14 Feb 2022 13:48:22 +0000
Received: by outflank-mailman (input) for mailman id 272270;
 Mon, 14 Feb 2022 13:48:22 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KkXt=S5=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nJbiI-0001kW-1Q
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:48:22 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c534d657-8d9c-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 14:48:20 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2051.outbound.protection.outlook.com [104.47.14.51]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-7-oqUv4supMeKZBijkJ5DqSg-1; Mon, 14 Feb 2022 14:48:19 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.18; Mon, 14 Feb
 2022 13:48:17 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4975.015; Mon, 14 Feb 2022
 13:48:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c534d657-8d9c-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644846500;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=F6JqSrWHMZvMDTzPmP/hOjpW6NL1qzExNrtnIz5p0gw=;
	b=lQzUzHrJTDKI2MqGQpvasycnTEnjDiaH2Gt8IgOzvXUoj1C0N57wJ0u3KePMcULRBxLV/Z
	yXuUO9EgBvYhjMXMz/B8gDaNPo/1LSGIPJhZHox1h4dqvMiFeP9VcZC8SWg9w0jo7qfUTw
	fNsPLjxA+6kc5aAtJ2GFxBsOU/gafGo=
X-MC-Unique: oqUv4supMeKZBijkJ5DqSg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=AWWLu25iB15bE2sdGy1YpSyvsUfuOqx3OKr4QuZIvtbYQwc5+oAxWtwBYgGuxIcsSGFqlmulmqm15DQ6SNW3AR7gCyIbE9yoJwcBTsTwE0XvUxTOuc9nIjRoBAJwtDSE0Y4GAuAhLKo2nEwnOqYzA7K6BRzqNSr/BEX8uG/CXo2fmi4S3pKB8kqjKLw72rTHVKvEgiJMusEPwmsgPqkW4gcuJ7mfNQ/D1F9TheXIKouhvw9/VY3CU2aYAk5ezgOlCqOG6be6duhzlKw6RsSLpL10UtJPyRCO2vBHJ9ILZFshdSYGZmIBh7uPP8pYjgTkzNmfLoqmx5DU99MaUyEiaw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=VQELOwE604JH34St9WSsVguW3L6k1ASB43q/zFgHawo=;
 b=GBLywyztdPMQrGzSBy8//xZ3poJ+8EVgebP645/VTRi59BHX06UZ7zrkr6a2a0pv5ryWkGSjC/WuSFTrnaRZLc6274DXmLBM1OX8BKzGoDMZbbTVDI/O457GcsgdKdyVFuA5Tq68NHAn0Gs0fL3erxPTpb67Ve8lto0I0sVGyKGsO+usml5LH/RJajXGjXohLzTzmarhBvxyvHOuoW/0k5HMOq2NgiBuwxyXwL05sSOMr0I/k4q6QOhUl7SSN/majymmL9K92NVAfqIr+Ib9/T3csedR8Lfat8ePy3ywpOC/C1AG6HecKd91oqvqpGbsT8Lq7p3VSKYUs2QHTWEiJg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <3538350c-0a63-59fb-7bba-fe460c0f1607@suse.com>
Date: Mon, 14 Feb 2022 14:48:15 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH] vpci: introduce per-domain lock to protect vpci structure
Content-Language: en-US
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "julien@xen.org" <julien@xen.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Artem Mygaiev <Artem_Mygaiev@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>
References: <20220209133627.959649-1-andr2000@gmail.com>
 <YgU6Snk8GTytJXZp@Air-de-Roger>
 <c4666570-666e-6680-5ec2-adf1da51ad06@epam.com>
 <YgZLEMW9US9QjjYG@Air-de-Roger>
 <33fb1095-64ed-29ef-ba6b-cbde21d941f8@epam.com>
 <YgowIg5MvTaf2zsR@Air-de-Roger>
 <d8389a90-00c8-b34a-8488-b0f3fc5bde1b@epam.com>
 <Ygo40L4dMPJjZKRF@Air-de-Roger>
 <746860aa-c403-1eca-0a75-587c5d10c8c2@epam.com>
 <Ygo8M3Y6BLzljn15@Air-de-Roger>
 <114b8578-ee13-b67d-e282-d060187ef509@epam.com>
 <06baf0c8-d7d2-50b8-ea8f-1d422ceac728@suse.com>
 <6ccc7add-c13e-555f-b341-ce37118746e5@epam.com>
 <f0e202dd-1f6e-4aac-1381-a64a7fd12270@suse.com>
 <ba901778-ce63-12f2-0a54-d56998090200@epam.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <ba901778-ce63-12f2-0a54-d56998090200@epam.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM5PR0502CA0006.eurprd05.prod.outlook.com
 (2603:10a6:203:91::16) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f5c66667-11c0-4b68-dc7c-08d9efc0a7c1
X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_
X-Microsoft-Antispam-PRVS:
	<PAXPR04MB8459876604080F3CF95BB0EDB3339@PAXPR04MB8459.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	dAtBs1dxVH52VchkUW+ZogAYLyBpWsVoaWYYUPiy/R1BqkIYhx27rVPRIpzH9NdJJNwbdE79gUTigZemfoXZRzsJvyj2PRGQZfrfKhqeQim6/ucQEBB6IecZWhYANH90drfeLjW70oLaQpgxtb63e8umKh1XftFi6w2i4pvdvBNrh+snuyKd8AJwRc7oVtHUq7Ga1VJPKlTC+0Dv7LuoInyMs/8aLTtRSflnIQKUf1CkbwGDGJvO32MQ42avZsZyBTMzCB8J3Y+0Zn9faw+d2UWG2FRJ5cihtrXhFXqQOnGN3bqkln7E5Q/c55O5hGhF7G/FQluSHAPXWkb3UMlJrH+ab9Qm8TAS2eXXfPpHF/5+ROU6STAL2kGliit/Mfda/9cdnf+PwU/KE5klwzLXXzkXDvx+R1P0+mRI6PJOFmQgK+yqO/2V3uoz3Zn92ePl+D7VZF5aVDRdq9yuBV4QAHffVCt8AKBcK3RJ1Fux1dk1igaxVrJiAtYLN4XKKp88T5RIy5UrO8+Dz6+gj/5mKPgLodL3pzH0oie2mmC7IlgeGh9hEsH+726bYwMaaCZcTUeoAHGIW97Rb6XvwCnCH2P5yIPsozSR3Ro+Fqiu8p54vh4ETT0Xq6DwddSWlvmtLG63K+gFEXTzQksb8IHvdzTGMlRtI6vbaBRRHr4hZYQydiSyl/3nyay+bO1/21+ixojR2DUB3q6xDcxBKi8KqLcJzqy0+utAZKvFA1vl9L0=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8676002)(6486002)(38100700002)(7416002)(83380400001)(5660300002)(508600001)(26005)(186003)(2616005)(8936002)(6512007)(2906002)(6506007)(54906003)(316002)(86362001)(31686004)(66946007)(36756003)(6916009)(4326008)(53546011)(66556008)(66476007)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?1rs8740IjyWQ/0ZS1vKqqyIJg16DlFYwekML7mmaz9u2euBYCkMNh37BZFWq?=
 =?us-ascii?Q?QNwPs2l9bkzLFhGvkIN6rrNE62w6jNAFrLg0xMV293oT9UhgnHOqwAOpCRvK?=
 =?us-ascii?Q?JhrnQUhYrFkLyiOiTByG4zILEjwjJDy0yY33pAUuIjN1EWn0mCBtPVXjLYVG?=
 =?us-ascii?Q?10xuUMG4Bd11jvIuXrC2sAaBv+Gp4ZPKjH+F4ogppHvfQx8umnAUcNcWfk80?=
 =?us-ascii?Q?IhTnivbDhofwttQW4cKz4Q6lSAUet3K/D1qSTsEBzSdoD20i8Uji7MU/8FLE?=
 =?us-ascii?Q?wPUiih7BCGLa8ID0VQ1Qo5vhLwzBxJr01JXn4YceLrPtDCGCdsr82e+MPC9s?=
 =?us-ascii?Q?YDJmqoudsW6inTi6m7QTM4YJp2INWl2GbXEw+Mq2GWBQ1JBx1hDx2erKFd8+?=
 =?us-ascii?Q?6VBouCO7i1StYoz6tF3aFAkVB7t5BFbWb3wpXnIwMS9oatjZReb6+BzdRij0?=
 =?us-ascii?Q?L+O4drjaRL9kOlWDmap98R3afJr+2A3DDUuW70/lv37j1qtYYaVjVTiIglTu?=
 =?us-ascii?Q?lzEXoAOQF0Aym+1F2SGq5k6kk3NDoaN1BadIcmvz5Z3WP6oZ9w8P4vRRElGc?=
 =?us-ascii?Q?/VWVPPqbNkMJzEf+5TymmjMafpN002K/IU1vCVmDBdkGwHh9rUKBplpZLLg/?=
 =?us-ascii?Q?C30HbI3y7IzUv4rUdC7Z/rm7SNTdSDaYv6MwUi+XZWV3cl/dq9n1MOAVY9QQ?=
 =?us-ascii?Q?GZtAnoOfjTCDst4p612bsKewJ8QJxWkvD9x7Ek2TbJCyVgfb8FiYM3gWtYVT?=
 =?us-ascii?Q?WGobXhLGtXjw+eL1gMOcnPtUeiXnscSZKluCd8vmOcxFs6TGm6Q5eQ+H/AOI?=
 =?us-ascii?Q?R3FtAk0ojQvSdM/YGgSnfNg10tUGXoz34g2OF3Ea+20ZiEHsszZybtNoSHKJ?=
 =?us-ascii?Q?gMbhhHXkjBhSJV918/C4XEXUZnscjx5oeO6LCS5+fV5KxLMX6aGQ9d/KQpu4?=
 =?us-ascii?Q?VdmgbzFqeChr/lhKpY270XxaOZn86OzXQvrjiQzR2HRyXK0g5GoPFz3mZspk?=
 =?us-ascii?Q?65cETHol+w6yPDpflmvRGa4+KalqfLtiXQ9qvWfwFMxWeMV6ftucDp7PAmgN?=
 =?us-ascii?Q?MWnVWxv7GaQcfAIky9cW9QOChaoxmJu3Pi0PT5z8sykad04zZoF9gdf78S7k?=
 =?us-ascii?Q?HsOk/XWam4LhOnTqyDHs5zKbQnDiGUR0Eg3riLUZxV8bQC3BKTOU938OSQGy?=
 =?us-ascii?Q?vfKRF/jI6SjtzH8U+ABX51Qy2IigTzUnUHphqq5HKQKpbnmgbh+ycx6kIcpr?=
 =?us-ascii?Q?8eZ/KF9nBhT37WPa6QNyocRU/NqgyFWgcrH7i40KvnJzF0LM+kk6RR2me4ch?=
 =?us-ascii?Q?4jG+o2HG3xuMu+91/pI+FEkXPNWPQzWij/J1AubCIs/1GM8hYZWLeCgkX7tJ?=
 =?us-ascii?Q?EPWDHd4rUebQezWWGFEC+DPF6V1Q5qvVjt48DczXpdUKeuNhmDqEQLtcxrUv?=
 =?us-ascii?Q?dZ9MfqZz6wqKmC/jPatIdgVAkYBsPuWsxwSCrXHY3I5BeX46TNEllDPhErFg?=
 =?us-ascii?Q?tqv8yoDw1RankGMfwGCHeOMu8Uvvvb50qRtZt1nHwncHW9zNyxvybkhgH10C?=
 =?us-ascii?Q?smfOapEabfV27lfaPtzHZRv2ifM/rFANBV9XINXVE1V7Z4JjegK4dF5mwrPN?=
 =?us-ascii?Q?m/aSuKy3tVD+7T/AvHu/Dt0=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f5c66667-11c0-4b68-dc7c-08d9efc0a7c1
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2022 13:48:17.8301
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4ZMHcb/UxL7YIiDxz4z5/9R4X72EDvPUIgJh1+/R0oHFbT5nJfQKuS6I+3V2+6as4DcnxCm3xm445WrUfenyCw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8459

On 14.02.2022 14:27, Oleksandr Andrushchenko wrote:
>=20
>=20
> On 14.02.22 15:22, Jan Beulich wrote:
>> On 14.02.2022 14:13, Oleksandr Andrushchenko wrote:
>>>
>>> On 14.02.22 14:57, Jan Beulich wrote:
>>>> On 14.02.2022 12:37, Oleksandr Andrushchenko wrote:
>>>>> On 14.02.22 13:25, Roger Pau Monn=C3=A9 wrote:
>>>>>> On Mon, Feb 14, 2022 at 11:15:27AM +0000, Oleksandr Andrushchenko wr=
ote:
>>>>>>> On 14.02.22 13:11, Roger Pau Monn=C3=A9 wrote:
>>>>>>>> On Mon, Feb 14, 2022 at 10:53:43AM +0000, Oleksandr Andrushchenko =
wrote:
>>>>>>>>> On 14.02.22 12:34, Roger Pau Monn=C3=A9 wrote:
>>>>>>>>>> On Mon, Feb 14, 2022 at 09:36:39AM +0000, Oleksandr Andrushchenk=
o wrote:
>>>>>>>>>>> On 11.02.22 13:40, Roger Pau Monn=C3=A9 wrote:
>>>>>>>>>>>> +
>>>>>>>>>>>>>>>             for ( i =3D 0; i < msix->max_entries; i++ )
>>>>>>>>>>>>>>>             {
>>>>>>>>>>>>>>>                 const struct vpci_msix_entry *entry =3D &ms=
ix->entries[i];
>>>>>>>>>>>>>> Since this function is now called with the per-domain rwlock=
 read
>>>>>>>>>>>>>> locked it's likely not appropriate to call process_pending_s=
oftirqs
>>>>>>>>>>>>>> while holding such lock (check below).
>>>>>>>>>>>>> You are right, as it is possible that:
>>>>>>>>>>>>>
>>>>>>>>>>>>> process_pending_softirqs -> vpci_process_pending -> read_lock
>>>>>>>>>>>>>
>>>>>>>>>>>>> Even more, vpci_process_pending may also
>>>>>>>>>>>>>
>>>>>>>>>>>>> read_unlock -> vpci_remove_device -> write_lock
>>>>>>>>>>>>>
>>>>>>>>>>>>> in its error path. So, any invocation of process_pending_soft=
irqs
>>>>>>>>>>>>> must not hold d->vpci_rwlock at least.
>>>>>>>>>>>>>
>>>>>>>>>>>>> And also we need to check that pdev->vpci was not removed
>>>>>>>>>>>>> in between or *re-created*
>>>>>>>>>>>>>> We will likely need to re-iterate over the list of pdevs ass=
igned to
>>>>>>>>>>>>>> the domain and assert that the pdev is still assigned to the=
 same
>>>>>>>>>>>>>> domain.
>>>>>>>>>>>>> So, do you mean a pattern like the below should be used at al=
l
>>>>>>>>>>>>> places where we need to call process_pending_softirqs?
>>>>>>>>>>>>>
>>>>>>>>>>>>> read_unlock
>>>>>>>>>>>>> process_pending_softirqs
>>>>>>>>>>>>> read_lock
>>>>>>>>>>>>> pdev =3D pci_get_pdev_by_domain(d, sbdf.seg, sbdf.bus, sbdf.d=
evfn);
>>>>>>>>>>>>> if ( pdev && pdev->vpci && is_the_same_vpci(pdev->vpci) )
>>>>>>>>>>>>> <continue processing>
>>>>>>>>>>>> Something along those lines. You likely need to continue itera=
te using
>>>>>>>>>>>> for_each_pdev.
>>>>>>>>>>> How do we tell if pdev->vpci is the same? Jan has already broug=
ht
>>>>>>>>>>> this question before [1] and I was about to use some ID for tha=
t purpose:
>>>>>>>>>>> pdev->vpci->id =3D d->vpci_id++ and then we use pdev->vpci->id=
=C2=A0 for checks
>>>>>>>>>> Given this is a debug message I would be OK with just doing the
>>>>>>>>>> minimal checks to prevent Xen from crashing (ie: pdev->vpci exis=
ts)
>>>>>>>>>> and that the resume MSI entry is not past the current limit. Oth=
erwise
>>>>>>>>>> just print a message and move on to the next device.
>>>>>>>>> Agree, I see no big issue (probably) if we are not able to print
>>>>>>>>>
>>>>>>>>> How about this one:
>>>>>>>>>
>>>>>>>>> diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.=
c
>>>>>>>>> index 809a6b4773e1..50373f04da82 100644
>>>>>>>>> --- a/xen/drivers/vpci/header.c
>>>>>>>>> +++ b/xen/drivers/vpci/header.c
>>>>>>>>> @@ -171,10 +171,31 @@ static int __init apply_map(struct domain *=
d, const struct pci_dev *pdev,
>>>>>>>>>      =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 struct rangeset *mem, uint16_t cmd)
>>>>>>>>>      =C2=A0{
>>>>>>>>>      =C2=A0=C2=A0=C2=A0=C2=A0 struct map_data data =3D { .d =3D d=
, .map =3D true };
>>>>>>>>> +=C2=A0=C2=A0=C2=A0 pci_sbdf_t sbdf =3D pdev->sbdf;
>>>>>>>>>      =C2=A0=C2=A0=C2=A0=C2=A0 int rc;
>>>>>>>>>
>>>>>>>>> + ASSERT(rw_is_write_locked(&pdev->domain->vpci_rwlock));
>>>>>>>>> +
>>>>>>>>>      =C2=A0=C2=A0=C2=A0=C2=A0 while ( (rc =3D rangeset_consume_ra=
nges(mem, map_range, &data)) =3D=3D -ERESTART )
>>>>>>>>> +=C2=A0=C2=A0=C2=A0 {
>>>>>>>>> +
>>>>>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 /*
>>>>>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * process_pendi=
ng_softirqs may trigger vpci_process_pending which
>>>>>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * may need to a=
cquire pdev->domain->vpci_rwlock in read mode.
>>>>>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 */
>>>>>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 write_unlock(&pdev->d=
omain->vpci_rwlock);
>>>>>>>>>      =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 process_pen=
ding_softirqs();
>>>>>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 write_lock(&pdev->dom=
ain->vpci_rwlock);
>>>>>>>>> +
>>>>>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 /* Check if pdev stil=
l exists and vPCI was not removed or re-created. */
>>>>>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (pci_get_pdev_by_d=
omain(d, sbdf.seg, sbdf.bus, sbdf.devfn) !=3D pdev)
>>>>>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0 if ( vpci is NOT the same )
>>>>>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0 {
>>>>>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0 rc =3D 0;
>>>>>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0 break;
>>>>>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0 }
>>>>>>>>> +=C2=A0=C2=A0=C2=A0 }
>>>>>>>>> +
>>>>>>>>>      =C2=A0=C2=A0=C2=A0=C2=A0 rangeset_destroy(mem);
>>>>>>>>>      =C2=A0=C2=A0=C2=A0=C2=A0 if ( !rc )
>>>>>>>>>      =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 modify_deco=
ding(pdev, cmd, false);
>>>>>>>>>
>>>>>>>>> This one also wants process_pending_softirqs to run so it *might*
>>>>>>>>> want pdev and vpci checks. But at the same time apply_map runs
>>>>>>>>> at ( system_state < SYS_STATE_active ), so defer_map won't be
>>>>>>>>> running yet, thus no vpci_process_pending is possible yet (in ter=
ms
>>>>>>>>> it has something to do yet). So, I think we just need:
>>>>>>>>>
>>>>>>>>>      =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 write_unlock(&pde=
v->domain->vpci_rwlock);
>>>>>>>>>      =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 process_pending_s=
oftirqs();
>>>>>>>>>      =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 write_lock(&pdev-=
>domain->vpci_rwlock);
>>>>>>>>>
>>>>>>>>> and this should be enough
>>>>>>>> Given the context apply_map is called from (dom0 specific init cod=
e),
>>>>>>>> there's no need to check for the pdev to still exits, or whether v=
pci
>>>>>>>> has been recreated, as it's not possible. Just add a comment to
>>>>>>>> explicitly note that the context of the function is special, and t=
hus
>>>>>>>> there's no possibility of either the device or vpci going away.
>>>>>>> Does it really need write_unlock/write_lock given the context?...
>>>>>> I think it's bad practice to call process_pending_softirqs while
>>>>>> holding any locks. This is a very specific context so it's likely fi=
ne
>>>>>> to not drop the lock, but would still seem incorrect to me.
>>>>> Ok
>>>>>>> I think it doesn't as there is no chance defer_map is called, thus
>>>>>>> process_pending_softirqs -> vpci_process_pending -> read_lock
>>>>>> Indeed, there's no chance of that because process_pending_softirqs
>>>>>> will never try to do a scheduling operation that would result in our
>>>>>> context being scheduled out.
>>>>>    =C2=A0=C2=A0=C2=A0 while ( (rc =3D rangeset_consume_ranges(mem, ma=
p_range, &data)) =3D=3D -ERESTART )
>>>>>    =C2=A0=C2=A0=C2=A0 {
>>>>>    =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 /*
>>>>>    =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * FIXME: Given th=
e context apply_map is called from (dom0 specific
>>>>>    =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * init code at sy=
stem_state < SYS_STATE_active) it is not strictly
>>>>>    =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * required that p=
dev->domain->vpci_rwlock is unlocked before calling
>>>>>    =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * process_pending=
_softirqs as there is no contention possible between
>>>>>    =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * this code and v=
pci_process_pending trying to acquire the lock in
>>>>>    =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * read mode. But =
running process_pending_softirqs with any lock held
>>>>>    =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * doesn't seem to=
 be a good practice, so drop the lock and re-acquire
>>>>>    =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * it right again.
>>>>>    =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 */
>>>>>    =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 write_unlock(&pdev->dom=
ain->vpci_rwlock);
>>>>>    =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 process_pending_softirq=
s();
>>>>>    =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 write_lock(&pdev->domai=
n->vpci_rwlock);
>>>>>    =C2=A0=C2=A0=C2=A0 }
>>>> I'm afraid that's misleading at best. apply_map() is merely a specific
>>>> example where you know the lock is going to be taken. But really any
>>>> softirq handler could be acquiring any lock, so requesting to process
>>>> softirqs cannot ever be done with any lock held.
>>>>
>>>> What you instead want to explain is why, after re-acquiring the lock,
>>>> no further checking is needed for potentially changed state.
>>> How about:
>>>
>>> /*
>>>   =C2=A0* FIXME: Given the context apply_map is called from (dom0 speci=
fic
>>>   =C2=A0* init code at system_state < SYS_STATE_active) there is no con=
tention
>>>   =C2=A0* possible between this code and vpci_process_pending trying to=
 acquire
>>>   =C2=A0* the lock in read mode and destroy pdev->vpci in its error pat=
h.
>>>   =C2=A0* Neither pdev may be disposed yet, so it is not required to ch=
eck if the
>>>   =C2=A0* relevant pdev still exists after re-acquiring the lock.
>>>   =C2=A0*/
>> I'm not sure I follow the first sentence; I guess a comma or two may hel=
p,
>> and or using "as well as" in place of one of the two "and". I also don't
>> think you mean contention, but rather a race between the named entities?
>  =C2=A0/*
>  =C2=A0 * FIXME: Given the context from which apply_map is called (dom0 s=
pecific
>  =C2=A0 * init code at system_state < SYS_STATE_active) there is no race =
condition
>  =C2=A0 * possible between this code and vpci_process_pending which may t=
ry to acquire
>  =C2=A0 * the lock in read mode and also try to destroy pdev->vpci in its=
 error path.
>  =C2=A0 * Neither pdev may be disposed yet, so it is not required to chec=
k if the
>  =C2=A0 * relevant pdev still exists after re-acquiring the lock.
>  =C2=A0 */

I'm still struggling with the language, sorry. You look to only have replac=
ed
"contention"? Reading it again I'd also like to mention that to me (not a
native speaker) "Neither pdev may be ..." expresses "None of the pdev-s may
be ...", when I think you mean "Nor may pdev be ..."

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:50:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:50:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272276.467049 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbk9-00036D-6j; Mon, 14 Feb 2022 13:50:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272276.467049; Mon, 14 Feb 2022 13:50:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbk9-000366-3r; Mon, 14 Feb 2022 13:50:17 +0000
Received: by outflank-mailman (input) for mailman id 272276;
 Mon, 14 Feb 2022 13:50:16 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=yQXP=S5=gmail.com=dunlapg@srs-se1.protection.inumbo.net>)
 id 1nJbk8-00035o-1f
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:50:16 +0000
Received: from mail-yb1-xb2f.google.com (mail-yb1-xb2f.google.com
 [2607:f8b0:4864:20::b2f])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 08dee25d-8d9d-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 14:50:14 +0100 (CET)
Received: by mail-yb1-xb2f.google.com with SMTP id p5so46057694ybd.13
 for <xen-devel@lists.xenproject.org>; Mon, 14 Feb 2022 05:50:14 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 08dee25d-8d9d-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=umich.edu; s=google-2016-06-03;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=1c0SH3jWUDFfTtN5hWJdEwGITkAnPbf45zrLxr5j/M0=;
        b=byE0iBaNr3JsnFQgcvHS1FkB1rD8ddasHv17b+Vy1jhn/gnyHdAx595rMreWSM0tKc
         hHfS23MQFGCBp2leMpmYaLY9zzA6CeyBJEm4UKl49Bx3eSxepg7/7EqGXkQThCUaEHPs
         u355WCZ3rmrDTaUoHixEnb7H28n9JOpTr4ojGVUZgfQa6omQRlaOZ0ZBxVqOjEDr1BL2
         OG57F6lKP7kgmVsWLrVvR8HcWsWFfVIJyhh48mHzA97WI7AYWbBn7Q5WDphUL2WEq+wF
         GEIk8DNdGIVFpsfaBPBzGh2kKudOkclXmL1hLiyDbBHNY78QpoXa8e2ZpohFv9QWq0v7
         FROg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=1c0SH3jWUDFfTtN5hWJdEwGITkAnPbf45zrLxr5j/M0=;
        b=MnhumPZ3qx5/XIksv53mYerUvA4wOutu79tzsM9H0IQBHCoe6HUHkUF8QLk8SAurc0
         DjQB/wnGT+v1y/o4i0TRCsUGrEsbfzyAoD42d+Rq3ac1fI+35c7XbautXdVHrQJJZp2C
         m0K4kzdxgY01HYit77w/49eyvGlaaRL6bEuY1ovL2PWgDP5Rkh1I8Acf5qsdHl8S48uj
         iw1jsj5akmSPcv7BJ2k0cLwNjbb5U82eqc6SqyKZCuOwEuHVgyX0NidDpxegKpwwl/F2
         p9GR7gZsF1LE32izu5NTcOMyuK5QZuCAaiOu1jfUaNWeBbfjV10DPwIXBqw4ZyZDWy/Y
         Vv8g==
X-Gm-Message-State: AOAM531/0Leb7UkL6eKPfOgWiJ3w111fTClkBiL+CbidAhN1wd/J8lGD
	4prso2p11KxbVzvB8U7kGGgdYbt5JRVEyzhb4eEASOcy
X-Google-Smtp-Source: ABdhPJwmOmlutN5cgAhRqxd89gJArANZFouJ3zhGvFXoBdaOUvCGUhjFY+hEvvsTCQbYt5Ngk2n9bnXj97413JSNcg0=
X-Received: by 2002:a25:40b:: with SMTP id 11mr8911838ybe.110.1644846613510;
 Mon, 14 Feb 2022 05:50:13 -0800 (PST)
MIME-Version: 1.0
References: <YgcRbq4yJlKSonzj@mattapan.m5p.com>
In-Reply-To: <YgcRbq4yJlKSonzj@mattapan.m5p.com>
From: George Dunlap <dunlapg@umich.edu>
Date: Mon, 14 Feb 2022 13:50:02 +0000
Message-ID: <CAFLBxZZ2BaoiaEVBevYwSjQdid4uSTFj9z1Nz21x+q5=x636rg@mail.gmail.com>
Subject: Re: Development Issue of Concern
To: Elliott Mitchell <ehem+xen@m5p.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>
Content-Type: multipart/alternative; boundary="0000000000001bbc4705d7fab27a"

--0000000000001bbc4705d7fab27a
Content-Type: text/plain; charset="UTF-8"

On Sat, Feb 12, 2022 at 1:46 AM Elliott Mitchell <ehem+xen@m5p.com> wrote:

> The tradition has been to name the active development branch in GIT has
> been named "master".  Quite a number of people object to the name due to
> its history.
>
> In light of such concerns, perhaps the Xen Project should join with other
> similar projects and move to have the active development branch renamed
> "main"?
>

There was a general intention to do that switch a few years ago, but there
were some technical pieces missing.  Probably time to take another look.

 -George

--0000000000001bbc4705d7fab27a
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><div class=3D"gmail_quote"><div=
 dir=3D"ltr" class=3D"gmail_attr">On Sat, Feb 12, 2022 at 1:46 AM Elliott M=
itchell &lt;<a href=3D"mailto:ehem%2Bxen@m5p.com">ehem+xen@m5p.com</a>&gt; =
wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0=
px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">The tradi=
tion has been to name the active development branch in GIT has<br>
been named &quot;master&quot;.=C2=A0 Quite a number of people object to the=
 name due to<br>
its history.<br>
<br>
In light of such concerns, perhaps the Xen Project should join with other<b=
r>
similar projects and move to have the active development branch renamed<br>
&quot;main&quot;?<br></blockquote><div><br></div>There was a general intent=
ion to do that switch a few years ago, but there were some technical pieces=
 missing.=C2=A0 Probably time to take another look.</div><div class=3D"gmai=
l_quote"><br></div><div class=3D"gmail_quote">=C2=A0-George<br></div></div>

--0000000000001bbc4705d7fab27a--


From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:50:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:50:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272283.467061 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbkm-0003e8-G3; Mon, 14 Feb 2022 13:50:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272283.467061; Mon, 14 Feb 2022 13:50:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbkm-0003e1-Cb; Mon, 14 Feb 2022 13:50:56 +0000
Received: by outflank-mailman (input) for mailman id 272283;
 Mon, 14 Feb 2022 13:50:55 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=R+2O=S5=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1nJbkk-0003Qt-VQ
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:50:54 +0000
Received: from ppsw-31.csi.cam.ac.uk (ppsw-31.csi.cam.ac.uk [131.111.8.131])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1f86c1c2-8d9d-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 14:50:53 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:55292)
 by ppsw-31.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.137]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1nJbkh-0010IO-Lp (Exim 4.95) (return-path <amc96@srcf.net>);
 Mon, 14 Feb 2022 13:50:51 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 918B01FB1C;
 Mon, 14 Feb 2022 13:50:51 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1f86c1c2-8d9d-11ec-8eb8-a37418f5ba1a
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <e18c0c5a-d00b-adf9-d4b0-28e702a18241@srcf.net>
Date: Mon, 14 Feb 2022 13:50:51 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Content-Language: en-GB
To: Jan Beulich <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Juergen Gross <jgross@suse.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
 <20220214125127.17985-5-andrew.cooper3@citrix.com>
 <4d8ab414-caf4-5a12-4cb7-a88c633cfd66@suse.com>
From: Andrew Cooper <amc96@srcf.net>
Subject: Re: [PATCH v2 04/70] x86/pv-shim: Don't modify the hypercall table
In-Reply-To: <4d8ab414-caf4-5a12-4cb7-a88c633cfd66@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 14/02/2022 13:33, Jan Beulich wrote:
> On 14.02.2022 13:50, Andrew Cooper wrote:
>> From: Juergen Gross <jgross@suse.com>
>>
>> When running as pv-shim the hypercall is modified today in order to
>> replace the functions for __HYPERVISOR_event_channel_op and
>> __HYPERVISOR_grant_table_op hypercalls.
>>
>> Change this to call the related functions from the normal handlers
>> instead when running as shim. The performance implications are not
>> really relevant, as a normal production hypervisor will not be
>> configured to support shim mode, so the related calls will be dropped
>> due to optimization of the compiler.
>>
>> Note that for the CONFIG_PV_SHIM_EXCLUSIVE case there is a dummy
>> wrapper do_grant_table_op() needed, as in this case grant_table.c
>> isn't being built.
>>
>> Signed-off-by: Juergen Gross <jgross@suse.com>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> I don't think you sync-ed this with Jürgen's v3. There were only minor
> changes but having a stale version sent two months later isn't very
> nice.

I did resync.  What do you think is missing?

>
>> --- a/xen/common/compat/multicall.c
>> +++ b/xen/common/compat/multicall.c
>> @@ -5,7 +5,7 @@
>>  EMIT_FILE;
>>  
>>  #include <xen/types.h>
>> -#include <xen/multicall.h>
>> +#include <xen/hypercall.h>
>>  #include <xen/trace.h>
>>  
>>  #define COMPAT
>> @@ -19,7 +19,6 @@ static inline void xlat_multicall_entry(struct mc_state *mcs)
>>          mcs->compat_call.args[i] = mcs->call.args[i];
>>  }
>>  
>> -DEFINE_XEN_GUEST_HANDLE(multicall_entry_compat_t);
>>  #define multicall_entry      compat_multicall_entry
>>  #define multicall_entry_t    multicall_entry_compat_t
>>  #define do_multicall_call    compat_multicall_call
> Jürgen's patch doesn't have any change to this file, and I'm afraid I
> also don't see how these adjustments are related here. The commit
> message sadly also doesn't help ...

The changes are very necessary to split it out of Juergen's series.

Without the adjustment, the correction of compat_platform_op()'s guest
handle type from void to compat_platform_op_t doesn't compile.

~Andrew


From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:51:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:51:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272291.467071 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJblU-0004Hp-Tv; Mon, 14 Feb 2022 13:51:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272291.467071; Mon, 14 Feb 2022 13:51:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJblU-0004Hi-Qs; Mon, 14 Feb 2022 13:51:40 +0000
Received: by outflank-mailman (input) for mailman id 272291;
 Mon, 14 Feb 2022 13:51:39 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KkXt=S5=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nJblT-0003Qt-I4
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:51:39 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 3b4b8a17-8d9d-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 14:51:38 +0100 (CET)
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur03lp2053.outbound.protection.outlook.com [104.47.10.53]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-5-iU3JxfesN_iSOvkNODJPTA-1; Mon, 14 Feb 2022 14:51:37 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM0PR04MB5396.eurprd04.prod.outlook.com (2603:10a6:208:116::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.18; Mon, 14 Feb
 2022 13:51:35 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4975.015; Mon, 14 Feb 2022
 13:51:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3b4b8a17-8d9d-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644846698;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=gR8aTK7xfMZ/A3HBtP43jD+wIrXcFomMIBb0861VdbI=;
	b=cTlRJe5SAx0xrm7GjmctHXQFwm8mJ83e1Im7Ilnt9vNZnyXVbHXX2g8BeqeXyIBX/BAJUw
	dgl6F4lPTVcDG6BoCYCDNBux2h0mq5Sm9b9RjODeRJEEECh8Ckmh+10G51iJyPMOi9xXCw
	sAtamwPOeWWpanV/rSEcSqeYd9Zk2lw=
X-MC-Unique: iU3JxfesN_iSOvkNODJPTA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ULCSO2ge5LaqYuXJIPq479ADpdlzOrOB/JTaL9jMHeShW/Qilb0nvrTYpODpoCTStCqJP2YeNPiNBcSaGqaZWRKjOxVj+/K6ySm020R2OglfUvQ06yWz0K7Cy7bcd+s3TKilqyR11ElG82D+YC1dCHQdaJGMbd2HAHZQLKBBRNQ9UwBsXeK8JAFthE3g638ApZe4kNbbNO4fFihohVr1H8YXvuGWfcNaiyyEg3YMIWfF0YlM2xnbfApsLxj4vAIsZxwxjybJW+orYgAImSvuowcOvYNtK5ubAOW57g+zAC0fT/qc2W0qiZh2ozwgMhN4M6ab9Fh6H9BpIj3qnHisjA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=gRSnmbdTEvVtgsmcwoV5R11ubrF0kgeLhDSS2e9TOYs=;
 b=ZpelGDVIPY30vZ0b8zxgBKERUEvIfCCsdt0sJ4hneJooV9MQKbXcBcBgxh317EYJ8Y+7OvaboRDAWkrOnk7bAir2yszckp0K++BUI/Ljpl4ZrpTBS3ZVAorkDl9PEhJF7VeOURDFUNNyAArZ5LYunLygfbwHsTU+OqYrHmx6DN0O52ArkFtstJXO/OvPO912+SDMnhsGLozfojWpQj1l/0kVMVKZcIukZhfRqneqp10eomK+2Job0O/PsyxyicA9hAuU+q6jr2i6uaNlqXLeTwXj1tPhgmnusaLEDuFaQ94x/cLLsntw7VAwbw/Eaj6uXjx3YJkcz+SKcmA12dVuog==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <adbd9ee8-46c5-9696-c3eb-3e18b2d60684@suse.com>
Date: Mon, 14 Feb 2022 14:51:34 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH v2 3/7] x86/altcall: Optimise away endbr64 instruction
 where possible
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
CC: Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20220214125632.24563-1-andrew.cooper3@citrix.com>
 <20220214125632.24563-4-andrew.cooper3@citrix.com>
 <5d53c6f9-8d1a-3d48-6ea6-14a484d578a0@suse.com>
 <cc4cf340-f02f-a547-08a0-1261bb506bcf@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <cc4cf340-f02f-a547-08a0-1261bb506bcf@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS8PR04CA0071.eurprd04.prod.outlook.com
 (2603:10a6:20b:313::16) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 58e5401c-7342-4973-776c-08d9efc11db8
X-MS-TrafficTypeDiagnostic: AM0PR04MB5396:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB5396CA38F673A1B8BB72C06FB3339@AM0PR04MB5396.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	uw2WnkOnQo81rI0hXTlWRFJpdLO66ul124njYxSkbA1lLYxlzPS2+NhhHOcV7/0zQ+zBAKZwJnGbWAf1zHv3RvmTvbRUI6lBOXEJ/+rKCZssrMm40MTinl0iUusc82VvPozDyi4wiUlEQFlbDrCRiPWYhPxNNcU+x3GRobnTJHoRTAh8fptWxUETG4RswPbY2pJiyWFf38bhoSYonukCM90M7yGWI9CehQdOMbdR2tUBqMzcbmZpE6+v71fEYIo4IniWN8Pi+hdHaiMj53UOcy5s8US1TNWiJDdvvtk4YNd+XG1xk4nnqXmUJwy8Lvk1J4AUpgOFFLalunnzvb3M344n8jsHeXCmUK1HACMqH5cS5L3KtyBWQp/sKxfZM7LHpgGFHCeg5dLQIgjXNVx3cposBt0zbpjX0hzdW4U18ith63IoH8U/djnhB7BpsbjIS0ySPDdH/2So2+oXpjFZX3TBd1fCTdpMN/Ul6ijSuxo4YzgF9Dd+JXUvlurvJpMvSc2YT94eoRiKaBTwnWoUest8kXIjHarrBinoS6HA5I3VxM1yOTScaO0+ZQ6b+WvpfN4N804X205Mfh5zes1JeRZ+JqgGh8eDwM/uIyKtdTvgLK6ldMkKgCMNVtWqjGBnl7Kt5KDpkyBBmkSwmKqnixHFwwZw1T6vJdpixVqhPUu5UQwjUaqOtXghAtHLdc3ND+acfHK0Z/gLfRVQE4SJBA==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2906002)(86362001)(31696002)(38100700002)(5660300002)(53546011)(8676002)(4326008)(66476007)(66556008)(66946007)(6512007)(8936002)(508600001)(6506007)(316002)(6486002)(36756003)(83380400001)(6916009)(2616005)(31686004)(54906003)(26005)(186003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?oxP9vAyN0BECRMvqho4e4R/qQs7GFQqCfdfp9dGoVg9lO9aB6jsvHY/tKh29?=
 =?us-ascii?Q?fZdWvyiLR/kjoKJs/w5eTqHRxOD0wmeVQiLWk1rXveL9u4qwDZXAW7v40LFa?=
 =?us-ascii?Q?hbKXeNzHtAGWDBe4kJUrTk7VApXUSlOfIyLUpDqRvEbYAgdblChSOoNpUvok?=
 =?us-ascii?Q?YNbd+4kbpg1stlvfrdMH2LWY3wNGWuvjmOM1NOEniX/vmjnIpUZUJmwGRw1T?=
 =?us-ascii?Q?k/1HQrde5Bd6YjDADX1Fswf/vU/69XmUmnpGOYm05clzLM0e3tBaeL7XuHoa?=
 =?us-ascii?Q?Pi7B6NlORjBRoOxwJ4aovRwIHXsenjMUQNvPgUkxmKwG9tJo/HBUYnDcyo6X?=
 =?us-ascii?Q?fuvRRcbf4/M3FXaiIiju6Hltbtyh48+JYkKl3AgoYgFAn27nyxgSdNbBZHbk?=
 =?us-ascii?Q?joLyzAZMCuKEd9Nnegl4OlWfWMajdNV0q+OwHephq/NKOLftD6ZLpuJkn2EV?=
 =?us-ascii?Q?gbUdd8tDAliRziyrPo2sK8tyPuIqJp6UccjdKpuoJpFx/b13uwHxYk8nRJLe?=
 =?us-ascii?Q?oixstHcvbSdNZ4ZNMLg32VRuZt4dLRpUmsrEdthdonenp3SomHbLAc5lN8VK?=
 =?us-ascii?Q?frJrdDTJ09q0Almuou733dv/l4AL668Cd+kZdtQXsSMgQeBX2Jz+T+0daXtZ?=
 =?us-ascii?Q?alOF/JcQTR5TSdDznt4T/LlxPhkPfeMrI9lrK2xKLaOVVlZaTu+MAYMh45NS?=
 =?us-ascii?Q?j04c4PscytIEOzZJSBYD3SsCMv7Zn4CEah9GodyBihrze4KFi+A2xfYTWldc?=
 =?us-ascii?Q?lXctPg5hTkcrPqWc4EiC021J12UeYQB6+vwGsf011eYT6yuLLjYhnKUBaNE9?=
 =?us-ascii?Q?0dvnPBwo2HnqjLBIW7QvYYLm0sid+oQ/mDn7qAF8orFffrTwm/A/kTbF3Eds?=
 =?us-ascii?Q?9VEGZhi38iWrp92JvmnqErs3YSV4s9fb+i+kLq+rU2TLx7613SNOdeV/t1hd?=
 =?us-ascii?Q?bDm8rgTUJSM5VFBQSJp/j7RUJ8X2oyXZbsHJuLiJnK6nxbze0tZ0vedXBlsA?=
 =?us-ascii?Q?2z+aO9ptAfy7FPIca0mriMaB+bMUw7NXDJcGLYhKGfZdTBDFhfVlGAS8vtHN?=
 =?us-ascii?Q?kpLtTb/xGWixCsKYWtDcoeHsat/o9Adm0a+60z59oDDjgfB7IByrb9sWVzHU?=
 =?us-ascii?Q?gvO8CMmN1mNqJYQdquC00OBvjjpcaB7ZVNg1oWIbdcOoPMCUqTAkY1/LxYX7?=
 =?us-ascii?Q?UW2yfXP02amXKa74U5SuM+ZZEo+U0eF9BIYugCqcxL4vpxi4SIx5BWWdcr9C?=
 =?us-ascii?Q?i3YLc9wtyDNEWqYv7i5TMYVyhyx8NNvD6IAcfKfH0hYS2/t9TGCPbmMGLI30?=
 =?us-ascii?Q?O7GIBrI2a013O2uwZurwNQmPm7n2HU3ne368t2ZfTj6f1a67mUv2UNEDM2mF?=
 =?us-ascii?Q?U5aYa/ZRCOXZufhUCvu94OcoxOKylXkh+iE0d7CSqwyiLS0JSAMmrB2/6Q8C?=
 =?us-ascii?Q?i3NBOs7mvLUbwBx5907Fixm1NzN+Q2s8EmR6D9Jv5Ss1Txxz2UQ//TKbn1/9?=
 =?us-ascii?Q?X8cnG1iyebDm9G74+NAZq6XTZ1BhMQc+aD72GDsGr9FhZZ41poHJlt0WmQ6A?=
 =?us-ascii?Q?2CdYq+Tz4LMMIlAE0jrAXXyQUu1OMOUxw2Ua+4It6S1s9H3wTqsIxW0eJopJ?=
 =?us-ascii?Q?+TTJr7JpgvB76ZmWWM8pbIA=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 58e5401c-7342-4973-776c-08d9efc11db8
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2022 13:51:35.7865
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gXbr6zHwTjcpH8JJB+uM9wvBy17IE/t6U69piIfW2K+bg3djo0qkOUeHATB7CuyuzimzBF6+bo3n5pgSPIaL5A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5396

On 14.02.2022 14:31, Andrew Cooper wrote:
> On 14/02/2022 13:06, Jan Beulich wrote:
>> On 14.02.2022 13:56, Andrew Cooper wrote:
>>> @@ -330,6 +333,41 @@ static void init_or_livepatch _apply_alternatives(=
struct alt_instr *start,
>>>          add_nops(buf + a->repl_len, total_len - a->repl_len);
>>>          text_poke(orig, buf, total_len);
>>>      }
>>> +
>>> +    /*
>>> +     * Clobber endbr64 instructions now that altcall has finished opti=
mising
>>> +     * all indirect branches to direct ones.
>>> +     */
>>> +    if ( force && cpu_has_xen_ibt )
>>> +    {
>>> +        void *const *val;
>>> +        unsigned int clobbered =3D 0;
>>> +
>>> +        /*
>>> +         * This is some minor structure (ab)use.  We walk the entire c=
ontents
>>> +         * of .init.{ro,}data.cf_clobber as if it were an array of poi=
nters.
>>> +         *
>>> +         * If the pointer points into .text, and at an endbr64 instruc=
tion,
>>> +         * nop out the endbr64.  This causes the pointer to no longer =
be a
>>> +         * legal indirect branch target under CET-IBT.  This is a
>>> +         * defence-in-depth measure, to reduce the options available t=
o an
>>> +         * adversary who has managed to hijack a function pointer.
>>> +         */
>>> +        for ( val =3D __initdata_cf_clobber_start;
>>> +              val < __initdata_cf_clobber_end;
>>> +              val++ )
>>> +        {
>>> +            void *ptr =3D *val;
>>> +
>>> +            if ( !is_kernel_text(ptr) || !is_endbr64(ptr) )
>>> +                continue;
>>> +
>>> +            add_nops(ptr, 4);
>> This literal 4 would be nice to have a #define next to where the ENDBR64
>> encoding has its central place.
>=20
> We don't have an encoding of ENDBR64 in a central place.
>=20
> The best you can probably have is
>=20
> #define ENDBR64_LEN 4
>=20
> in endbr.h ?

Perhaps. That's not in this series nor in staging already, so it's a little
hard to check. By "central place" I really meant is_enbr64() if that's the
only place where the encoding actually appears.

>>> --- a/xen/arch/x86/xen.lds.S
>>> +++ b/xen/arch/x86/xen.lds.S
>>> @@ -221,6 +221,12 @@ SECTIONS
>>>         *(.initcall1.init)
>>>         __initcall_end =3D .;
>>> =20
>>> +       . =3D ALIGN(POINTER_ALIGN);
>>> +       __initdata_cf_clobber_start =3D .;
>>> +       *(.init.data.cf_clobber)
>>> +       *(.init.rodata.cf_clobber)
>>> +       __initdata_cf_clobber_end =3D .;
>>> +
>>>         *(.init.data)
>>>         *(.init.data.rel)
>>>         *(.init.data.rel.*)
>> With r/o data ahead and r/w data following, may I suggest to flip the
>> order of the two section specifiers you add?
>=20
> I don't follow.=C2=A0 This is all initdata which is merged together into =
a
> single section.
>=20
> The only reason const data is split out in the first place is to appease
> the toolchains, not because it makes a difference.

It's marginal, I agree, but it would still seem more clean to me if all
(pseudo) r/o init data lived side by side.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 13:56:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 13:56:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272300.467083 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbpw-00054s-G7; Mon, 14 Feb 2022 13:56:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272300.467083; Mon, 14 Feb 2022 13:56:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbpw-00054l-CN; Mon, 14 Feb 2022 13:56:16 +0000
Received: by outflank-mailman (input) for mailman id 272300;
 Mon, 14 Feb 2022 13:56:14 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KkXt=S5=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nJbpu-00054f-Fd
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 13:56:14 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id df08ad46-8d9d-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 14:56:13 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2175.outbound.protection.outlook.com [104.47.17.175]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-29-2GyU24gKODKuWxC6FpdBWA-1; Mon, 14 Feb 2022 14:56:12 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM0PR04MB6978.eurprd04.prod.outlook.com (2603:10a6:208:17d::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.18; Mon, 14 Feb
 2022 13:56:10 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4975.015; Mon, 14 Feb 2022
 13:56:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: df08ad46-8d9d-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644846973;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Y6hvRHt39Hy+3o2g+gzhBSWx/lWMx4bZ7XwobQvzm38=;
	b=OpOIGNmsULQ/eA8yHhEatMK2QRN6Qvg7N5YH+y1Ksul7aeeuIqgty5JO2RjHjKxUwo1HWH
	c/xL7exFFvOXWPlkzfKLYrE5jbQnHLvSQHQ3QNWvp/4D/ElZvukxHe3nFG1ehOZGaxn7rL
	/PbnexV/JNa2CNBjO1+E9cbvHi6hsC0=
X-MC-Unique: 2GyU24gKODKuWxC6FpdBWA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=nLykGaT9eTadpRzGM4ALV8AW9R0W66DoULv8Jj6/Zpst9pO0RY/GzDq5JpRaaudTSIP2ExomQcULpRc2C42faGL1axZvxmAPDlk51KyyLc9q67uzr+mUCc5IZUVMleuPHOTojPlLy4svuvWmzkbzeeyHoFgZq+hitZR/9zNoZhMYXos5l76ilsHPfVZ2wmfikCHrftjsAhonPRbVVVhmTS2ZV1C6dVyB0jK1pR7KBKuJtftdDoVI9pqYNXMgl+ZA/NKuIvg+tDhYMntf2aeT6D4uT8CE+7qAzeTkYn1KEu9o0/tk3WT2SnJJkffybRjIKRP0DVy6vmWfi9v5iBom7Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=G3RnDTRuN0LOZ9KTsNssi8rwhMNqfVMlvZPFGWtpeS0=;
 b=lr998yDo1AhdZdrwcV7H/S7djuaqv2z6UMLz24jStYhfLO183p4g8GeVn/+VrpnhlGe54R/YGjG9m30gmlp8CKB6Unfy54NCcZX/mdGuhMwLSR1YdbO0g4EKtivfDSDE+WDpS6+vwF49st187WdwQDY7bT6JpfWvJazY4Ue8VvTXjR6msQvVY2qQi8nd421ImCjW7xwLBijrLZgigdpoi30bnQTbLu2XSRIY/IyVcyaHSBbOzv0RgVQC16jed+nOWWPoFOr6c8ffy+c074Rx+5hRkasGcVMegCznPHuQ4k+Tfga6sRYIeSk6i7fiHtxfFAVkqvQqTjAaV7BO7cpG4g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <6566bf52-58da-f804-f5c2-fca64c1f150c@suse.com>
Date: Mon, 14 Feb 2022 14:56:09 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH v2 04/70] x86/pv-shim: Don't modify the hypercall table
Content-Language: en-US
To: Andrew Cooper <amc96@srcf.net>, Andrew Cooper <andrew.cooper3@citrix.com>
CC: Juergen Gross <jgross@suse.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
 <20220214125127.17985-5-andrew.cooper3@citrix.com>
 <4d8ab414-caf4-5a12-4cb7-a88c633cfd66@suse.com>
 <e18c0c5a-d00b-adf9-d4b0-28e702a18241@srcf.net>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <e18c0c5a-d00b-adf9-d4b0-28e702a18241@srcf.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: FR0P281CA0075.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:1e::10) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 0be20ada-b587-4229-c4ad-08d9efc1c17b
X-MS-TrafficTypeDiagnostic: AM0PR04MB6978:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB69785A90ED8CBDD7296AF857B3339@AM0PR04MB6978.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	pt2WJlpy410n2yNgTYCT+mazZpvhNVurSqUCu29HmriiAkwvCwD9dqHT4KEqBgk/gLQGZEslp0tAxqwmbCWMshqiL3ROMj/yG8gTXogtlpI24gpquTbcDMxNBB9+V+AHKqmfnY5y9M17h5jDd00oxshRb5hw0BD08b/EBedWnTnma6vOyQl5BYdZDhJ0jAO0UEOHBv6Gd+ETVyEayu4JqtpnTtdfbdAmOqAiWb0hwFt/lzG83MtXAcvcvZnqMaY4wxgznyzzROpoySjOGr5q5HnXN3iPe5u67C0QtQAyFC5akH8489rNDq86h1Du62w0nIzI+EdEFIa3kS3erKbgOaDoBMYCMZaDLCUHl5YMwZPsv+j/vDczLjYFFxjzkLTrBTo8mTmUmi25nicXswjNeG0N49G8p7kZs2VirVDOZHaoS7REAUoRBUGGE1qgpJ/EoCD3DqWLGAxs4kvnb3xbEnlDZTd+9M6ovv0DXmhDEq1bs1TeA44zuQB/CMwmkK56QBe0pbcmTCkM5KWjx7AUDYiPzk5HMYjVrTyfWJYMguanbaOFN0iIpbmneKcdbb/UTQV5UDhEVCqho2btnVPq3jfGICURz1XUE5U9O51lnhYLXGRr/emV+2l58v6wQBq9Thfr5VSEhQCcrQrV325v+e/2/9etPH5TCuzA3+tFIM2tho/bUhmvGFMxntrugOqlfaaEZMJGpsVOGkd6a5PEsrOid7XBS4skw9LMD4W5HK4=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(86362001)(38100700002)(186003)(26005)(8936002)(53546011)(6506007)(2906002)(83380400001)(2616005)(36756003)(66574015)(31696002)(5660300002)(6512007)(4326008)(508600001)(6486002)(31686004)(54906003)(110136005)(316002)(66556008)(8676002)(66476007)(66946007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?bde8szUcnY+JJdkQ6re7oewHt2W4Mr+7QZpK1vBDlU2rz531hPpahmy/dL0C?=
 =?us-ascii?Q?Qj8fliGkuJNJJaZPR6y84YwvlkW1C0OLegY559Gufza04Wk20SZpMynrx9ti?=
 =?us-ascii?Q?At5hXdCuENfnLQjSI9078sR13I6RzooM+WDhwwpn4y08JOY1iYr5Xo91zghs?=
 =?us-ascii?Q?YZH7c/qtu9ra3fTFy75egA4zj88sQTpSNt4ql5WGbWwD/EFRWHI7vexLdTPM?=
 =?us-ascii?Q?wKUCEBgcmGaA6EIX9LjQXEm2hNJAKAvFLMEO84EXxCiOuj8N+vrwQPjv4fbz?=
 =?us-ascii?Q?OrQqmIwSwoGb7xwoT4mjihQ4neOZeVxyWmmUtRS7ThyFIOR24MMVnrWNOkk7?=
 =?us-ascii?Q?VYleJlmoKdgmpcBZ7kJY29vritQ2y5PmmoyKI35ueRLSzbUS3aVpe89ZZHu1?=
 =?us-ascii?Q?X8OXP5Yx99CZfCsD1woHVWdMhzyDqKtkZtow0AAhBY8/Gj+/0tks+UnjWlKu?=
 =?us-ascii?Q?Hf/tcYEE4KRxWzN7+cePetJIb8MXSEwXpQAj5oJxKEq7JmgRBgCTd6hJ1GYn?=
 =?us-ascii?Q?jxmjBwHHbvqe+rV1XVcok/GiaSs65mGX94JjtEGZxu8P0W+PuUAyq7Xapqz0?=
 =?us-ascii?Q?wPjFwPffEjyQy9eCVBewYFTX9ET+wR+y2OFd8obZUfmnFlEmIKpezh3nXVCM?=
 =?us-ascii?Q?1JtQMKR5+VK0PF4ITfJkdJHQAl8zyiJSm0YtrWbHhD8A9Gac5/Za8mwnUycB?=
 =?us-ascii?Q?UCSjQ6DfiKwQG6QNGH4u7GGY9baYH92C/3j8zzuMm5g15qd6ie75zLKnfeu7?=
 =?us-ascii?Q?ZE3CfRQizUdCiYgurRU8IbgYJMPR600SKwcqR+bOBnyAADhRPM/+Tk1/n7Gi?=
 =?us-ascii?Q?JIjBZujdDZNKUcGXuurFns2t5ucalA/QXWogCJZaF3kfn75Vt6TQWycckgD0?=
 =?us-ascii?Q?UH9vHKtcAf9DppjGjxShHkRokpAXKO7bpJuhv4EqpaiIZY7Hfv1SMITBOd/P?=
 =?us-ascii?Q?KO8Bf/NARoMbYTeR0hFiSjhSV+1wvIifHMwPFGanHrEnutfYXR5yVMxZ2wHd?=
 =?us-ascii?Q?DxnMG9H5dP9b0P4re6Ow6yzs/vSFNgkbxg0byV8Z9p41BhKSFvAnvN/FleDR?=
 =?us-ascii?Q?A360Zczv4W3Opm9joHPpXUJt14FfjYjqnUJDBQmvYZIRtFkHbJ2atKfyzZdK?=
 =?us-ascii?Q?oPZhsRyTOmaVMxwhEnVgy/5+f3MmK9/ZygYKZdFCCb21X3mlQJIhzsXkWCyG?=
 =?us-ascii?Q?RRW3eqqy0/ucckxEQIQpwkjAHx9NmWhlppxhsmHG4lNOH6SvTxSpLQGLgxHz?=
 =?us-ascii?Q?XkvqgyaMV9uROlkFByyEfELoqgdDhhikhA/K7k7Xj4TmYdhX5qg3CXcqry0Q?=
 =?us-ascii?Q?HYk9Bp7YEVp4HuOiMtTUpXyUsu1S8vPqNUdqJHgU2HOQfUBVT9ToTB4UuYi9?=
 =?us-ascii?Q?lnwF9JXI8Mz+MEjEqISynO0UJwQzgod8G+tx/3zavl4hdflbIr8dNZ4r3ICs?=
 =?us-ascii?Q?slRMHJU3vLVfNCBApU/SWMqMP30rf5Pmd6JMDD2brhQ8+ee+Bv9z2al9uEt2?=
 =?us-ascii?Q?qvGLrGewmIUnpPWquu1bi4xQFzDh8GS1N6KJychGGNCqZ1q4JQScThgle9pX?=
 =?us-ascii?Q?p/qUFtV2ndBhKe2frmIMYdPFbcXplp2iwS3RvG5rnH1gq7GurzkKg60Z331S?=
 =?us-ascii?Q?LD7ahG4cZABDHBqGd3n5CPc=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0be20ada-b587-4229-c4ad-08d9efc1c17b
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2022 13:56:10.4882
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /QHHTXW7F+fdKXRNiYRuvraK1CiMxk3bxiMKo38kNWtwRkH1MIWJNcXV0FUztahWhryxJiVveRK8xvH00xNOhQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6978

On 14.02.2022 14:50, Andrew Cooper wrote:
> On 14/02/2022 13:33, Jan Beulich wrote:
>> On 14.02.2022 13:50, Andrew Cooper wrote:
>>> From: Juergen Gross <jgross@suse.com>
>>>
>>> When running as pv-shim the hypercall is modified today in order to
>>> replace the functions for __HYPERVISOR_event_channel_op and
>>> __HYPERVISOR_grant_table_op hypercalls.
>>>
>>> Change this to call the related functions from the normal handlers
>>> instead when running as shim. The performance implications are not
>>> really relevant, as a normal production hypervisor will not be
>>> configured to support shim mode, so the related calls will be dropped
>>> due to optimization of the compiler.
>>>
>>> Note that for the CONFIG_PV_SHIM_EXCLUSIVE case there is a dummy
>>> wrapper do_grant_table_op() needed, as in this case grant_table.c
>>> isn't being built.
>>>
>>> Signed-off-by: Juergen Gross <jgross@suse.com>
>>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>> I don't think you sync-ed this with J=C3=BCrgen's v3. There were only mi=
nor
>> changes but having a stale version sent two months later isn't very
>> nice.
>=20
> I did resync.=C2=A0 What do you think is missing?

A few likely() / unlikely() as far as I could see.

>>> --- a/xen/common/compat/multicall.c
>>> +++ b/xen/common/compat/multicall.c
>>> @@ -5,7 +5,7 @@
>>>  EMIT_FILE;
>>> =20
>>>  #include <xen/types.h>
>>> -#include <xen/multicall.h>
>>> +#include <xen/hypercall.h>
>>>  #include <xen/trace.h>
>>> =20
>>>  #define COMPAT
>>> @@ -19,7 +19,6 @@ static inline void xlat_multicall_entry(struct mc_sta=
te *mcs)
>>>          mcs->compat_call.args[i] =3D mcs->call.args[i];
>>>  }
>>> =20
>>> -DEFINE_XEN_GUEST_HANDLE(multicall_entry_compat_t);
>>>  #define multicall_entry      compat_multicall_entry
>>>  #define multicall_entry_t    multicall_entry_compat_t
>>>  #define do_multicall_call    compat_multicall_call
>> J=C3=BCrgen's patch doesn't have any change to this file, and I'm afraid=
 I
>> also don't see how these adjustments are related here. The commit
>> message sadly also doesn't help ...
>=20
> The changes are very necessary to split it out of Juergen's series.
>=20
> Without the adjustment, the correction of compat_platform_op()'s guest
> handle type from void to compat_platform_op_t doesn't compile.

Interesting. That's quite far from obvious in this context, so clarifying
the purpose in the description would seem helpful.

Coming back to the syncing with v3: Was this change the reason then why
you did drop my R-b?

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 14:00:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 14:00:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272307.467094 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbuC-0006X4-1K; Mon, 14 Feb 2022 14:00:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272307.467094; Mon, 14 Feb 2022 14:00:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJbuB-0006Wx-UX; Mon, 14 Feb 2022 14:00:39 +0000
Received: by outflank-mailman (input) for mailman id 272307;
 Mon, 14 Feb 2022 14:00:38 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=YsDI=S5=epam.com=prvs=4044e07e7c=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nJbuA-0006Wr-Eh
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 14:00:38 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7b782664-8d9e-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 15:00:36 +0100 (CET)
Received: from pps.filterd (m0174680.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 21EDcTaE011125;
 Mon, 14 Feb 2022 14:00:30 GMT
Received: from eur04-vi1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2054.outbound.protection.outlook.com [104.47.14.54])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3e7r4vg31y-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Mon, 14 Feb 2022 14:00:30 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM6PR03MB4216.eurprd03.prod.outlook.com (2603:10a6:20b:d::26) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.18; Mon, 14 Feb
 2022 14:00:26 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::fc4d:4749:5d1:eb73]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::fc4d:4749:5d1:eb73%4]) with mapi id 15.20.4975.018; Mon, 14 Feb 2022
 14:00:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7b782664-8d9e-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ChaaMQMM2DOy+wBqYPdhMigZFVjLXhLAOnj9TCIZIvLX6j5snbJYfEMGaHZErQmfJNdXX+BQbcBqrclIX+aLs3kCytR3+Ve1hroaQYDtLF7eW7f+Ktnl/rlG49CxTYa4yvUP+JfF6FUkhqBAvuBIcYJSP0UmizpDzZpyX5fEvzpCHPQ9b9lJRwS3hpwFT9NgFwowRDNsFPom9RqnKWGz6J8CAvUkDAGlJQMd213M7ccpKx9dZ4t/cCuNrrDErDc1TbK0563dHemrJ8Qb3twxDQqiGmLY1YY8KsvxxKbkgWCGX/sLGGOWXZXH/ejQ1cw7GjAO8cNR4ynktdpED3NjZg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=LH5Kg4IJ83tOpbc0TwklnadUm1djlfTwaOViIpKjrbg=;
 b=dmiXBCkKaq7MkdJWpIHzlFQtUQ1USkh+4RVUNqBRxReC6rcTiG1Ra/HFV5OL/VtJTk9k9aa/CzU7cmebur2Cm8g7f9Id40io9A6j2ZW3zNrUJweUjmXU7jb0w8HzQkT2x56GL81+M+pcBJxf0JakvlT9bIe29YpNepX693IWGW05g0SfzaTjpjgQe/D6eNNTgMCA/0mLpiff1pDuoamLiNN9KdX/jspTikG62tAx7TCboHDRhbof/O9f1gayBOAA20oW4OhBL1W1lu7nUp71RxMe+kUN/otnGCfBKY2FNWxchMX0wBoORTXb7r21dfDqDF1JfQ26O9HZFfWrRJ5Kxw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=LH5Kg4IJ83tOpbc0TwklnadUm1djlfTwaOViIpKjrbg=;
 b=jHlDTv/T4C53OtlEcktiVF1Eyj4wNYFOSgYAEB5zZFw+cRCQWJ40ZAj/UAgTRlg+oHKxNJiRgB6UBoqOzvIqDHIAXjPrXk93VJm9MeycB93eFYjfpnpaFNZ/MWsQyaCtCh1dt3LMvQiX2YBkb34GS+u0mOYBjxw8z5gkmF2BNDNSXHnza9VYQRhUAYPDn7GbvfQqbtp1z5cjPBpgGeC1hEsrV3zuGCelHRc0OtemjzwSsTB/g+cPcucmuONIxSJLZhICeZyPj7WfJsWaMqq3zIsBQsN4Tu6it/q+abyyoEf0Ady3CmYp2cf9rPXzBwtEdkfa9pZ2Ov5UsHXhCKQvig==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?=
	<roger.pau@citrix.com>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH] vpci: introduce per-domain lock to protect vpci structure
Thread-Topic: [PATCH] vpci: introduce per-domain lock to protect vpci
 structure
Thread-Index: 
 AQHYHboQT3cBWYI1/EGunE7hOwop6ayM95MAgAD+qQCAAEaDAIAElIcAgAAQEwCAAAV1AIAABOQAgAABMICAAALZgIAAAzmAgAAWXYCAAARtAIAAAoIAgAABpICAAAWvgIAAA2aA
Date: Mon, 14 Feb 2022 14:00:26 +0000
Message-ID: <2a750ae8-9ca7-2e74-b878-11b98fcb4ca0@epam.com>
References: <20220209133627.959649-1-andr2000@gmail.com>
 <YgU6Snk8GTytJXZp@Air-de-Roger>
 <c4666570-666e-6680-5ec2-adf1da51ad06@epam.com>
 <YgZLEMW9US9QjjYG@Air-de-Roger>
 <33fb1095-64ed-29ef-ba6b-cbde21d941f8@epam.com>
 <YgowIg5MvTaf2zsR@Air-de-Roger>
 <d8389a90-00c8-b34a-8488-b0f3fc5bde1b@epam.com>
 <Ygo40L4dMPJjZKRF@Air-de-Roger>
 <746860aa-c403-1eca-0a75-587c5d10c8c2@epam.com>
 <Ygo8M3Y6BLzljn15@Air-de-Roger>
 <114b8578-ee13-b67d-e282-d060187ef509@epam.com>
 <06baf0c8-d7d2-50b8-ea8f-1d422ceac728@suse.com>
 <6ccc7add-c13e-555f-b341-ce37118746e5@epam.com>
 <f0e202dd-1f6e-4aac-1381-a64a7fd12270@suse.com>
 <ba901778-ce63-12f2-0a54-d56998090200@epam.com>
 <3538350c-0a63-59fb-7bba-fe460c0f1607@suse.com>
In-Reply-To: <3538350c-0a63-59fb-7bba-fe460c0f1607@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 366ee319-094a-4eba-f899-08d9efc25a24
x-ms-traffictypediagnostic: AM6PR03MB4216:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM6PR03MB42162B19B9DAC93B43AAEC82E7339@AM6PR03MB4216.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 ru2TSQjr0tTBKU/tVo1MqhT1DBkgTPaiPE3ndVKjsDFX3QX9CTJv2sIQoVNQmn4nRbdJg3xYKhWM3vJWOG4Kl/X30QBm9pktYPx3AEPZDU0MTYaQn1FyM9X6Z9EULfuSvBMghtQdoKV6MqZmFBi/35UCAklvPYokFMmNaRVA++SLplgxhqhktuR+ughQC5JEDs3q38bmJ6R6OnYSS1u2OrXjkDQBjgX+MYADrDRYfmsxm3KNFseIG2Vj3owJ/kWn0ojN20Ml7VT0LipvyYjfEUJvVEjeE+8fLJu6wvhrfsCxW9ih8p7VHcXdfP6Pk5NG2hiDquuyJisv/ZadA9hjjIFC0p7LTj7R9vcA1L+5tKVUrxhrpjWs1Vy0/Mve3YCFjMWzcfG9GER/7031IwIvQfwLQav8EEdIhOlLDldD6O2xD4OLFNW3lEJOd6F+iOs0PHpMka7W9NVKa51hXj9p7lmjQlUgNYvwWqM+eKd/5vvqX3lVLmdg+hHQd2DFAZASsFjGVLO2CFx+NTJ7km2fF0s6ya1WsQMcKoNxJqH0uBwXuuyLT5aeJM5rK51HdKZOE8rpEfoi4j4Jgufq0pKiWb84qJ3VUjcE5gEwjLHhG44rkltgMpq9CgN6ZpxjmnIwZjilU1e04j9bgCUqK4j++cciwwAO1nLwuQCmtI+qui2nGBQZnIS2uZ8gumiX8KJM/TQ1FzQkAr60E8qYVCdNC5lx5dwjPXJXi4lbr6TNLBp3AxP+joGNjel3kTh0vK6h
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(76116006)(66946007)(66556008)(91956017)(4326008)(64756008)(66476007)(66446008)(8936002)(107886003)(2616005)(8676002)(2906002)(53546011)(38100700002)(71200400001)(6506007)(55236004)(6512007)(5660300002)(6916009)(54906003)(83380400001)(186003)(26005)(31696002)(6486002)(122000001)(36756003)(31686004)(86362001)(38070700005)(316002)(508600001)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?dVlJeHdYVTZrenFGc2p4OFU5TUxSUmZpc1VxMktMOEpyZDlqc2w1a0ZTUm1V?=
 =?utf-8?B?WmVSR1BIWUZSanpzZS8vMVNCVU8yc3c2cWV4TXhiTTZEWU02ZG03OWhNM1lW?=
 =?utf-8?B?UmNGZlFrdkI3b1BRdEF1N0NyNzVZN0pORE5hMExFMncrTFV5SUNBRUJpb2F4?=
 =?utf-8?B?WGt6bThSQWRuWWJXeXRMamtzRHhKeDRwVnp2ZjVHUlhKdDJxOGNpMmsxT2c2?=
 =?utf-8?B?R0pFOVNuU2NRMkE4TFR2TDVCRHkySGJPd3piSWtzTVp0OHBiZTEvWWpqUjRz?=
 =?utf-8?B?MVdLQ0JtTzREUWtTRmo4TEorWTVwQTRxNXNDZnliWlVMeDh5aFo5SVY0K0oy?=
 =?utf-8?B?am1lcVFNUmlJS2hqQkhxVTQrNTZLejlDQ0hKaHFCNG1jNkx1bS9UQXplWW5P?=
 =?utf-8?B?ekRRRnFlZHVMYnR2MG9qRGpia2ZuVFlUS0E4T3RWa2xtQ1diRTQrY2V3U05X?=
 =?utf-8?B?ZzRadklxMHRURWJkR001Y1pJMEg5dCsvMnBxLzNSOXEzcUpqdXRYemF3WFEz?=
 =?utf-8?B?WFpyRXAyUWVkT25uWkJLU2gwUlUrZ1JtMVpWeVNTTUNBbllrR2h3RjFvZEJh?=
 =?utf-8?B?dmJyb0FpWHBYdlVZdFZwOUx5aEFpa0ZpM0VSRXF1T01GM0IxNEVHRno2YnFr?=
 =?utf-8?B?eEY1T1cramtWL2MwbXFjWVUvV2krQTVUSHQ0ekpBM3ZDeW9aOU5PWHluZDRC?=
 =?utf-8?B?eG40MHUzQ1ZVU3N3WjBRajRpUFV6cXF0c2h3Ym9mMkpJRDdLSXBJY21ZYnFD?=
 =?utf-8?B?UWtUS1poby82WWJMT3FBS25FdTJrWWlrOWg2cndESml2dFduTUxwUmQ4dXdN?=
 =?utf-8?B?alF6bkRZcXRzZXl5TC9ZT1A2WmJzMFdNNDJUaUVlT1NYQUtaeCs2SjV6Kytn?=
 =?utf-8?B?a1p4VUZtc01WUlNjd3NqTEQrdWEzaG5ldVU3ZjRmNXQvOXhDekY5b3FKeGtH?=
 =?utf-8?B?QzlKL1B4UDlRV2NkZWpxQTRzVURPUTNGQWJzcUdxTWFjWi9VTHdjZDdGRjY0?=
 =?utf-8?B?UzIrbS9Md1JyYzBhdmh0UjlGY2NzVGpvcXk2OGVGSUdPOGl6V2R0aEN0aGNX?=
 =?utf-8?B?VjUraGpHWTQvb1lpVnlvS1pmanUvNEx4UXQrYkk0aVJRTzVlVnZJeVFjWjBK?=
 =?utf-8?B?aUJaT3hEMG5pNEN4NDFrYjI3U3FjdW1XTVlWVjhlQzJsOWtlRjNsVUJrTXQz?=
 =?utf-8?B?OGF1L251ckNZbEdueDRNd3U3RGIxZmNSK1hHZWZvRHpQQnJtUjlyOURPckkv?=
 =?utf-8?B?aGlabzh4YUdIcitXUThFZUF6bS9Vazd4M0JPM1NvUHFJdk0xME5VQU5EeEox?=
 =?utf-8?B?bmo4cFVvZzdDOE04Q2dLcmNnOW5lY085UmtqMGNXbnV6US9DN21jOTNBSjAx?=
 =?utf-8?B?SXRzY1h1Mk5xbHBPS1dRNjE0OWV4a0Y0RENOU3BEY3BLYWFqNDIwUzcxVnkw?=
 =?utf-8?B?OEM1NDdPSFplOTgzdTNySHJuS0VBUG9laytuQjdJNThYSGJVcEI1VGd0ajY0?=
 =?utf-8?B?SzkwWTRtWVRTcHc2UCtEa2hEOUVWTFRVcW4vVC9Xa3RJNGFBMk5tYVk4Szc4?=
 =?utf-8?B?Zkt2VXM1ZEV3aWNxRWxTV3Y2SHd4RzZINmNuV0Fyd0ppQVpEZGRBeGhRWlQ0?=
 =?utf-8?B?WHdSQ3pnaWt3VU5MRzhXSURSODczODY0VVJvRTc1elhjQzYwNUhUZ3NiMWlr?=
 =?utf-8?B?a0F1Y0FkUEkrSHZPbXo5M0k3TTY3L3pwTUI2NmRpNm9VRCtqM2FhNmR5Y2Nx?=
 =?utf-8?B?YklzNWlJRjh4L2VBdWpaYngyRnhIVHJRQ2ZiNFdSTElWU2NVYmxRTGU4Yklw?=
 =?utf-8?B?RDZVRjBiSzNQZktKalEycUtGNjh5QmtjNzF4QlFKNnAzTktqTTR5cnFOc24w?=
 =?utf-8?B?Sitxb3AxeWs1VUJyQ0lCMnhTaCtRYWRoZi9jRXlubG94c1FIQVhka1Y4TU1J?=
 =?utf-8?B?M0ZBeWFmR2VLY2Nic21yMTJCRVlPdjUzK2pMK0hYaENYYmpwU013SS9WWXI1?=
 =?utf-8?B?cU5Fc1J4RDFaR2JXMjFCUXNuWEhsTDdlNFhXNDVRQ3hyVmR4eW9vcXRRVHNv?=
 =?utf-8?B?ZHpaT3p5UVp4bTNJS21odmFFNTYyaHZ5Z3hxY2xZaWVQcG1pbHppaWpkUmhw?=
 =?utf-8?B?R3ZWaVErWituQXRzM0xTVDZxcWVublFXOWVUbmt3Z3hLUy9CNXRFOW1hYW8r?=
 =?utf-8?B?Q0xkMFB3Z214R0pOMnhzWmR1L1FybkVXbGhvbUxSU1czOEx4a0s1NVIzc1lR?=
 =?utf-8?B?V1R1elhHaUZvUHZFS0hsRkNYNTBtL25xR05DMTZsd3hlYnROZDBzaCtud0d6?=
 =?utf-8?B?UXNTOXM2MUNveDk2dk9LR1ZiYk4yeWVKaGkwS2hXOVhIYmRONWxNZz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <A2F73FA56FE31042ACD61865E2FB39C7@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 366ee319-094a-4eba-f899-08d9efc25a24
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Feb 2022 14:00:26.3764
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: uSspYGqF9qWO4pbZWrroizYNTeBizDtnIx0YrzVTivAOFX9HpBk2C/B8JBsD7R9LFsiqZtVo8L8nLeE9JU18bP1RYawC5cEA+yHbPMvn/3d8X7tTGvEGWH9+reht0YP6
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR03MB4216
X-Proofpoint-ORIG-GUID: Dh4ySy6F4Q2_nMn_Cd0OMQ6Oklnf57iS
X-Proofpoint-GUID: Dh4ySy6F4Q2_nMn_Cd0OMQ6Oklnf57iS
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-14_06,2022-02-14_03,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0
 bulkscore=0 mlxlogscore=999 phishscore=0 mlxscore=0 lowpriorityscore=0
 priorityscore=1501 spamscore=0 impostorscore=0 adultscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2202140086

DQoNCk9uIDE0LjAyLjIyIDE1OjQ4LCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMTQuMDIuMjAy
MiAxNDoyNywgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+Pg0KPj4gT24gMTQuMDIu
MjIgMTU6MjIsIEphbiBCZXVsaWNoIHdyb3RlOg0KPj4+IE9uIDE0LjAyLjIwMjIgMTQ6MTMsIE9s
ZWtzYW5kciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4+PiBPbiAxNC4wMi4yMiAxNDo1NywgSmFu
IEJldWxpY2ggd3JvdGU6DQo+Pj4+PiBPbiAxNC4wMi4yMDIyIDEyOjM3LCBPbGVrc2FuZHIgQW5k
cnVzaGNoZW5rbyB3cm90ZToNCj4+Pj4+PiBPbiAxNC4wMi4yMiAxMzoyNSwgUm9nZXIgUGF1IE1v
bm7DqSB3cm90ZToNCj4+Pj4+Pj4gT24gTW9uLCBGZWIgMTQsIDIwMjIgYXQgMTE6MTU6MjdBTSAr
MDAwMCwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+Pj4+Pj4+PiBPbiAxNC4wMi4y
MiAxMzoxMSwgUm9nZXIgUGF1IE1vbm7DqSB3cm90ZToNCj4+Pj4+Pj4+PiBPbiBNb24sIEZlYiAx
NCwgMjAyMiBhdCAxMDo1Mzo0M0FNICswMDAwLCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyB3cm90
ZToNCj4+Pj4+Pj4+Pj4gT24gMTQuMDIuMjIgMTI6MzQsIFJvZ2VyIFBhdSBNb25uw6kgd3JvdGU6
DQo+Pj4+Pj4+Pj4+PiBPbiBNb24sIEZlYiAxNCwgMjAyMiBhdCAwOTozNjozOUFNICswMDAwLCBP
bGVrc2FuZHIgQW5kcnVzaGNoZW5rbyB3cm90ZToNCj4+Pj4+Pj4+Pj4+PiBPbiAxMS4wMi4yMiAx
Mzo0MCwgUm9nZXIgUGF1IE1vbm7DqSB3cm90ZToNCj4+Pj4+Pj4+Pj4+Pj4gKw0KPj4+Pj4+Pj4+
Pj4+Pj4+PiAgICAgICAgICAgICAgZm9yICggaSA9IDA7IGkgPCBtc2l4LT5tYXhfZW50cmllczsg
aSsrICkNCj4+Pj4+Pj4+Pj4+Pj4+Pj4gICAgICAgICAgICAgIHsNCj4+Pj4+Pj4+Pj4+Pj4+Pj4g
ICAgICAgICAgICAgICAgICBjb25zdCBzdHJ1Y3QgdnBjaV9tc2l4X2VudHJ5ICplbnRyeSA9ICZt
c2l4LT5lbnRyaWVzW2ldOw0KPj4+Pj4+Pj4+Pj4+Pj4+IFNpbmNlIHRoaXMgZnVuY3Rpb24gaXMg
bm93IGNhbGxlZCB3aXRoIHRoZSBwZXItZG9tYWluIHJ3bG9jayByZWFkDQo+Pj4+Pj4+Pj4+Pj4+
Pj4gbG9ja2VkIGl0J3MgbGlrZWx5IG5vdCBhcHByb3ByaWF0ZSB0byBjYWxsIHByb2Nlc3NfcGVu
ZGluZ19zb2Z0aXJxcw0KPj4+Pj4+Pj4+Pj4+Pj4+IHdoaWxlIGhvbGRpbmcgc3VjaCBsb2NrIChj
aGVjayBiZWxvdykuDQo+Pj4+Pj4+Pj4+Pj4+PiBZb3UgYXJlIHJpZ2h0LCBhcyBpdCBpcyBwb3Nz
aWJsZSB0aGF0Og0KPj4+Pj4+Pj4+Pj4+Pj4NCj4+Pj4+Pj4+Pj4+Pj4+IHByb2Nlc3NfcGVuZGlu
Z19zb2Z0aXJxcyAtPiB2cGNpX3Byb2Nlc3NfcGVuZGluZyAtPiByZWFkX2xvY2sNCj4+Pj4+Pj4+
Pj4+Pj4+DQo+Pj4+Pj4+Pj4+Pj4+PiBFdmVuIG1vcmUsIHZwY2lfcHJvY2Vzc19wZW5kaW5nIG1h
eSBhbHNvDQo+Pj4+Pj4+Pj4+Pj4+Pg0KPj4+Pj4+Pj4+Pj4+Pj4gcmVhZF91bmxvY2sgLT4gdnBj
aV9yZW1vdmVfZGV2aWNlIC0+IHdyaXRlX2xvY2sNCj4+Pj4+Pj4+Pj4+Pj4+DQo+Pj4+Pj4+Pj4+
Pj4+PiBpbiBpdHMgZXJyb3IgcGF0aC4gU28sIGFueSBpbnZvY2F0aW9uIG9mIHByb2Nlc3NfcGVu
ZGluZ19zb2Z0aXJxcw0KPj4+Pj4+Pj4+Pj4+Pj4gbXVzdCBub3QgaG9sZCBkLT52cGNpX3J3bG9j
ayBhdCBsZWFzdC4NCj4+Pj4+Pj4+Pj4+Pj4+DQo+Pj4+Pj4+Pj4+Pj4+PiBBbmQgYWxzbyB3ZSBu
ZWVkIHRvIGNoZWNrIHRoYXQgcGRldi0+dnBjaSB3YXMgbm90IHJlbW92ZWQNCj4+Pj4+Pj4+Pj4+
Pj4+IGluIGJldHdlZW4gb3IgKnJlLWNyZWF0ZWQqDQo+Pj4+Pj4+Pj4+Pj4+Pj4gV2Ugd2lsbCBs
aWtlbHkgbmVlZCB0byByZS1pdGVyYXRlIG92ZXIgdGhlIGxpc3Qgb2YgcGRldnMgYXNzaWduZWQg
dG8NCj4+Pj4+Pj4+Pj4+Pj4+PiB0aGUgZG9tYWluIGFuZCBhc3NlcnQgdGhhdCB0aGUgcGRldiBp
cyBzdGlsbCBhc3NpZ25lZCB0byB0aGUgc2FtZQ0KPj4+Pj4+Pj4+Pj4+Pj4+IGRvbWFpbi4NCj4+
Pj4+Pj4+Pj4+Pj4+IFNvLCBkbyB5b3UgbWVhbiBhIHBhdHRlcm4gbGlrZSB0aGUgYmVsb3cgc2hv
dWxkIGJlIHVzZWQgYXQgYWxsDQo+Pj4+Pj4+Pj4+Pj4+PiBwbGFjZXMgd2hlcmUgd2UgbmVlZCB0
byBjYWxsIHByb2Nlc3NfcGVuZGluZ19zb2Z0aXJxcz8NCj4+Pj4+Pj4+Pj4+Pj4+DQo+Pj4+Pj4+
Pj4+Pj4+PiByZWFkX3VubG9jaw0KPj4+Pj4+Pj4+Pj4+Pj4gcHJvY2Vzc19wZW5kaW5nX3NvZnRp
cnFzDQo+Pj4+Pj4+Pj4+Pj4+PiByZWFkX2xvY2sNCj4+Pj4+Pj4+Pj4+Pj4+IHBkZXYgPSBwY2lf
Z2V0X3BkZXZfYnlfZG9tYWluKGQsIHNiZGYuc2VnLCBzYmRmLmJ1cywgc2JkZi5kZXZmbik7DQo+
Pj4+Pj4+Pj4+Pj4+PiBpZiAoIHBkZXYgJiYgcGRldi0+dnBjaSAmJiBpc190aGVfc2FtZV92cGNp
KHBkZXYtPnZwY2kpICkNCj4+Pj4+Pj4+Pj4+Pj4+IDxjb250aW51ZSBwcm9jZXNzaW5nPg0KPj4+
Pj4+Pj4+Pj4+PiBTb21ldGhpbmcgYWxvbmcgdGhvc2UgbGluZXMuIFlvdSBsaWtlbHkgbmVlZCB0
byBjb250aW51ZSBpdGVyYXRlIHVzaW5nDQo+Pj4+Pj4+Pj4+Pj4+IGZvcl9lYWNoX3BkZXYuDQo+
Pj4+Pj4+Pj4+Pj4gSG93IGRvIHdlIHRlbGwgaWYgcGRldi0+dnBjaSBpcyB0aGUgc2FtZT8gSmFu
IGhhcyBhbHJlYWR5IGJyb3VnaHQNCj4+Pj4+Pj4+Pj4+PiB0aGlzIHF1ZXN0aW9uIGJlZm9yZSBb
MV0gYW5kIEkgd2FzIGFib3V0IHRvIHVzZSBzb21lIElEIGZvciB0aGF0IHB1cnBvc2U6DQo+Pj4+
Pj4+Pj4+Pj4gcGRldi0+dnBjaS0+aWQgPSBkLT52cGNpX2lkKysgYW5kIHRoZW4gd2UgdXNlIHBk
ZXYtPnZwY2ktPmlkwqAgZm9yIGNoZWNrcw0KPj4+Pj4+Pj4+Pj4gR2l2ZW4gdGhpcyBpcyBhIGRl
YnVnIG1lc3NhZ2UgSSB3b3VsZCBiZSBPSyB3aXRoIGp1c3QgZG9pbmcgdGhlDQo+Pj4+Pj4+Pj4+
PiBtaW5pbWFsIGNoZWNrcyB0byBwcmV2ZW50IFhlbiBmcm9tIGNyYXNoaW5nIChpZTogcGRldi0+
dnBjaSBleGlzdHMpDQo+Pj4+Pj4+Pj4+PiBhbmQgdGhhdCB0aGUgcmVzdW1lIE1TSSBlbnRyeSBp
cyBub3QgcGFzdCB0aGUgY3VycmVudCBsaW1pdC4gT3RoZXJ3aXNlDQo+Pj4+Pj4+Pj4+PiBqdXN0
IHByaW50IGEgbWVzc2FnZSBhbmQgbW92ZSBvbiB0byB0aGUgbmV4dCBkZXZpY2UuDQo+Pj4+Pj4+
Pj4+IEFncmVlLCBJIHNlZSBubyBiaWcgaXNzdWUgKHByb2JhYmx5KSBpZiB3ZSBhcmUgbm90IGFi
bGUgdG8gcHJpbnQNCj4+Pj4+Pj4+Pj4NCj4+Pj4+Pj4+Pj4gSG93IGFib3V0IHRoaXMgb25lOg0K
Pj4+Pj4+Pj4+Pg0KPj4+Pj4+Pj4+PiBkaWZmIC0tZ2l0IGEveGVuL2RyaXZlcnMvdnBjaS9oZWFk
ZXIuYyBiL3hlbi9kcml2ZXJzL3ZwY2kvaGVhZGVyLmMNCj4+Pj4+Pj4+Pj4gaW5kZXggODA5YTZi
NDc3M2UxLi41MDM3M2YwNGRhODIgMTAwNjQ0DQo+Pj4+Pj4+Pj4+IC0tLSBhL3hlbi9kcml2ZXJz
L3ZwY2kvaGVhZGVyLmMNCj4+Pj4+Pj4+Pj4gKysrIGIveGVuL2RyaXZlcnMvdnBjaS9oZWFkZXIu
Yw0KPj4+Pj4+Pj4+PiBAQCAtMTcxLDEwICsxNzEsMzEgQEAgc3RhdGljIGludCBfX2luaXQgYXBw
bHlfbWFwKHN0cnVjdCBkb21haW4gKmQsIGNvbnN0IHN0cnVjdCBwY2lfZGV2ICpwZGV2LA0KPj4+
Pj4+Pj4+PiAgICAgICDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoCBzdHJ1Y3QgcmFuZ2VzZXQgKm1lbSwgdWludDE2X3QgY21kKQ0KPj4+Pj4+
Pj4+PiAgICAgICDCoHsNCj4+Pj4+Pj4+Pj4gICAgICAgwqDCoMKgwqAgc3RydWN0IG1hcF9kYXRh
IGRhdGEgPSB7IC5kID0gZCwgLm1hcCA9IHRydWUgfTsNCj4+Pj4+Pj4+Pj4gK8KgwqDCoCBwY2lf
c2JkZl90IHNiZGYgPSBwZGV2LT5zYmRmOw0KPj4+Pj4+Pj4+PiAgICAgICDCoMKgwqDCoCBpbnQg
cmM7DQo+Pj4+Pj4+Pj4+DQo+Pj4+Pj4+Pj4+ICsgQVNTRVJUKHJ3X2lzX3dyaXRlX2xvY2tlZCgm
cGRldi0+ZG9tYWluLT52cGNpX3J3bG9jaykpOw0KPj4+Pj4+Pj4+PiArDQo+Pj4+Pj4+Pj4+ICAg
ICAgIMKgwqDCoMKgIHdoaWxlICggKHJjID0gcmFuZ2VzZXRfY29uc3VtZV9yYW5nZXMobWVtLCBt
YXBfcmFuZ2UsICZkYXRhKSkgPT0gLUVSRVNUQVJUICkNCj4+Pj4+Pj4+Pj4gK8KgwqDCoCB7DQo+
Pj4+Pj4+Pj4+ICsNCj4+Pj4+Pj4+Pj4gK8KgwqDCoMKgwqDCoMKgIC8qDQo+Pj4+Pj4+Pj4+ICvC
oMKgwqDCoMKgwqDCoMKgICogcHJvY2Vzc19wZW5kaW5nX3NvZnRpcnFzIG1heSB0cmlnZ2VyIHZw
Y2lfcHJvY2Vzc19wZW5kaW5nIHdoaWNoDQo+Pj4+Pj4+Pj4+ICvCoMKgwqDCoMKgwqDCoMKgICog
bWF5IG5lZWQgdG8gYWNxdWlyZSBwZGV2LT5kb21haW4tPnZwY2lfcndsb2NrIGluIHJlYWQgbW9k
ZS4NCj4+Pj4+Pj4+Pj4gK8KgwqDCoMKgwqDCoMKgwqAgKi8NCj4+Pj4+Pj4+Pj4gK8KgwqDCoMKg
wqDCoMKgIHdyaXRlX3VubG9jaygmcGRldi0+ZG9tYWluLT52cGNpX3J3bG9jayk7DQo+Pj4+Pj4+
Pj4+ICAgICAgIMKgwqDCoMKgwqDCoMKgwqAgcHJvY2Vzc19wZW5kaW5nX3NvZnRpcnFzKCk7DQo+
Pj4+Pj4+Pj4+ICvCoMKgwqDCoMKgwqDCoCB3cml0ZV9sb2NrKCZwZGV2LT5kb21haW4tPnZwY2lf
cndsb2NrKTsNCj4+Pj4+Pj4+Pj4gKw0KPj4+Pj4+Pj4+PiArwqDCoMKgwqDCoMKgwqAgLyogQ2hl
Y2sgaWYgcGRldiBzdGlsbCBleGlzdHMgYW5kIHZQQ0kgd2FzIG5vdCByZW1vdmVkIG9yIHJlLWNy
ZWF0ZWQuICovDQo+Pj4+Pj4+Pj4+ICvCoMKgwqDCoMKgwqDCoCBpZiAocGNpX2dldF9wZGV2X2J5
X2RvbWFpbihkLCBzYmRmLnNlZywgc2JkZi5idXMsIHNiZGYuZGV2Zm4pICE9IHBkZXYpDQo+Pj4+
Pj4+Pj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGlmICggdnBjaSBpcyBOT1QgdGhlIHNhbWUg
KQ0KPj4+Pj4+Pj4+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB7DQo+Pj4+Pj4+Pj4+ICvCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcmMgPSAwOw0KPj4+Pj4+Pj4+PiArwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgIGJyZWFrOw0KPj4+Pj4+Pj4+PiArwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoCB9DQo+Pj4+Pj4+Pj4+ICvCoMKgwqAgfQ0KPj4+Pj4+Pj4+PiArDQo+Pj4+Pj4+Pj4+
ICAgICAgIMKgwqDCoMKgIHJhbmdlc2V0X2Rlc3Ryb3kobWVtKTsNCj4+Pj4+Pj4+Pj4gICAgICAg
wqDCoMKgwqAgaWYgKCAhcmMgKQ0KPj4+Pj4+Pj4+PiAgICAgICDCoMKgwqDCoMKgwqDCoMKgIG1v
ZGlmeV9kZWNvZGluZyhwZGV2LCBjbWQsIGZhbHNlKTsNCj4+Pj4+Pj4+Pj4NCj4+Pj4+Pj4+Pj4g
VGhpcyBvbmUgYWxzbyB3YW50cyBwcm9jZXNzX3BlbmRpbmdfc29mdGlycXMgdG8gcnVuIHNvIGl0
ICptaWdodCoNCj4+Pj4+Pj4+Pj4gd2FudCBwZGV2IGFuZCB2cGNpIGNoZWNrcy4gQnV0IGF0IHRo
ZSBzYW1lIHRpbWUgYXBwbHlfbWFwIHJ1bnMNCj4+Pj4+Pj4+Pj4gYXQgKCBzeXN0ZW1fc3RhdGUg
PCBTWVNfU1RBVEVfYWN0aXZlICksIHNvIGRlZmVyX21hcCB3b24ndCBiZQ0KPj4+Pj4+Pj4+PiBy
dW5uaW5nIHlldCwgdGh1cyBubyB2cGNpX3Byb2Nlc3NfcGVuZGluZyBpcyBwb3NzaWJsZSB5ZXQg
KGluIHRlcm1zDQo+Pj4+Pj4+Pj4+IGl0IGhhcyBzb21ldGhpbmcgdG8gZG8geWV0KS4gU28sIEkg
dGhpbmsgd2UganVzdCBuZWVkOg0KPj4+Pj4+Pj4+Pg0KPj4+Pj4+Pj4+PiAgICAgICDCoMKgwqDC
oMKgwqDCoCB3cml0ZV91bmxvY2soJnBkZXYtPmRvbWFpbi0+dnBjaV9yd2xvY2spOw0KPj4+Pj4+
Pj4+PiAgICAgICDCoMKgwqDCoMKgwqDCoCBwcm9jZXNzX3BlbmRpbmdfc29mdGlycXMoKTsNCj4+
Pj4+Pj4+Pj4gICAgICAgwqDCoMKgwqDCoMKgwqAgd3JpdGVfbG9jaygmcGRldi0+ZG9tYWluLT52
cGNpX3J3bG9jayk7DQo+Pj4+Pj4+Pj4+DQo+Pj4+Pj4+Pj4+IGFuZCB0aGlzIHNob3VsZCBiZSBl
bm91Z2gNCj4+Pj4+Pj4+PiBHaXZlbiB0aGUgY29udGV4dCBhcHBseV9tYXAgaXMgY2FsbGVkIGZy
b20gKGRvbTAgc3BlY2lmaWMgaW5pdCBjb2RlKSwNCj4+Pj4+Pj4+PiB0aGVyZSdzIG5vIG5lZWQg
dG8gY2hlY2sgZm9yIHRoZSBwZGV2IHRvIHN0aWxsIGV4aXRzLCBvciB3aGV0aGVyIHZwY2kNCj4+
Pj4+Pj4+PiBoYXMgYmVlbiByZWNyZWF0ZWQsIGFzIGl0J3Mgbm90IHBvc3NpYmxlLiBKdXN0IGFk
ZCBhIGNvbW1lbnQgdG8NCj4+Pj4+Pj4+PiBleHBsaWNpdGx5IG5vdGUgdGhhdCB0aGUgY29udGV4
dCBvZiB0aGUgZnVuY3Rpb24gaXMgc3BlY2lhbCwgYW5kIHRodXMNCj4+Pj4+Pj4+PiB0aGVyZSdz
IG5vIHBvc3NpYmlsaXR5IG9mIGVpdGhlciB0aGUgZGV2aWNlIG9yIHZwY2kgZ29pbmcgYXdheS4N
Cj4+Pj4+Pj4+IERvZXMgaXQgcmVhbGx5IG5lZWQgd3JpdGVfdW5sb2NrL3dyaXRlX2xvY2sgZ2l2
ZW4gdGhlIGNvbnRleHQ/Li4uDQo+Pj4+Pj4+IEkgdGhpbmsgaXQncyBiYWQgcHJhY3RpY2UgdG8g
Y2FsbCBwcm9jZXNzX3BlbmRpbmdfc29mdGlycXMgd2hpbGUNCj4+Pj4+Pj4gaG9sZGluZyBhbnkg
bG9ja3MuIFRoaXMgaXMgYSB2ZXJ5IHNwZWNpZmljIGNvbnRleHQgc28gaXQncyBsaWtlbHkgZmlu
ZQ0KPj4+Pj4+PiB0byBub3QgZHJvcCB0aGUgbG9jaywgYnV0IHdvdWxkIHN0aWxsIHNlZW0gaW5j
b3JyZWN0IHRvIG1lLg0KPj4+Pj4+IE9rDQo+Pj4+Pj4+PiBJIHRoaW5rIGl0IGRvZXNuJ3QgYXMg
dGhlcmUgaXMgbm8gY2hhbmNlIGRlZmVyX21hcCBpcyBjYWxsZWQsIHRodXMNCj4+Pj4+Pj4+IHBy
b2Nlc3NfcGVuZGluZ19zb2Z0aXJxcyAtPiB2cGNpX3Byb2Nlc3NfcGVuZGluZyAtPiByZWFkX2xv
Y2sNCj4+Pj4+Pj4gSW5kZWVkLCB0aGVyZSdzIG5vIGNoYW5jZSBvZiB0aGF0IGJlY2F1c2UgcHJv
Y2Vzc19wZW5kaW5nX3NvZnRpcnFzDQo+Pj4+Pj4+IHdpbGwgbmV2ZXIgdHJ5IHRvIGRvIGEgc2No
ZWR1bGluZyBvcGVyYXRpb24gdGhhdCB3b3VsZCByZXN1bHQgaW4gb3VyDQo+Pj4+Pj4+IGNvbnRl
eHQgYmVpbmcgc2NoZWR1bGVkIG91dC4NCj4+Pj4+PiAgICAgwqDCoMKgIHdoaWxlICggKHJjID0g
cmFuZ2VzZXRfY29uc3VtZV9yYW5nZXMobWVtLCBtYXBfcmFuZ2UsICZkYXRhKSkgPT0gLUVSRVNU
QVJUICkNCj4+Pj4+PiAgICAgwqDCoMKgIHsNCj4+Pj4+PiAgICAgwqDCoMKgwqDCoMKgwqAgLyoN
Cj4+Pj4+PiAgICAgwqDCoMKgwqDCoMKgwqDCoCAqIEZJWE1FOiBHaXZlbiB0aGUgY29udGV4dCBh
cHBseV9tYXAgaXMgY2FsbGVkIGZyb20gKGRvbTAgc3BlY2lmaWMNCj4+Pj4+PiAgICAgwqDCoMKg
wqDCoMKgwqDCoCAqIGluaXQgY29kZSBhdCBzeXN0ZW1fc3RhdGUgPCBTWVNfU1RBVEVfYWN0aXZl
KSBpdCBpcyBub3Qgc3RyaWN0bHkNCj4+Pj4+PiAgICAgwqDCoMKgwqDCoMKgwqDCoCAqIHJlcXVp
cmVkIHRoYXQgcGRldi0+ZG9tYWluLT52cGNpX3J3bG9jayBpcyB1bmxvY2tlZCBiZWZvcmUgY2Fs
bGluZw0KPj4+Pj4+ICAgICDCoMKgwqDCoMKgwqDCoMKgICogcHJvY2Vzc19wZW5kaW5nX3NvZnRp
cnFzIGFzIHRoZXJlIGlzIG5vIGNvbnRlbnRpb24gcG9zc2libGUgYmV0d2Vlbg0KPj4+Pj4+ICAg
ICDCoMKgwqDCoMKgwqDCoMKgICogdGhpcyBjb2RlIGFuZCB2cGNpX3Byb2Nlc3NfcGVuZGluZyB0
cnlpbmcgdG8gYWNxdWlyZSB0aGUgbG9jayBpbg0KPj4+Pj4+ICAgICDCoMKgwqDCoMKgwqDCoMKg
ICogcmVhZCBtb2RlLiBCdXQgcnVubmluZyBwcm9jZXNzX3BlbmRpbmdfc29mdGlycXMgd2l0aCBh
bnkgbG9jayBoZWxkDQo+Pj4+Pj4gICAgIMKgwqDCoMKgwqDCoMKgwqAgKiBkb2Vzbid0IHNlZW0g
dG8gYmUgYSBnb29kIHByYWN0aWNlLCBzbyBkcm9wIHRoZSBsb2NrIGFuZCByZS1hY3F1aXJlDQo+
Pj4+Pj4gICAgIMKgwqDCoMKgwqDCoMKgwqAgKiBpdCByaWdodCBhZ2Fpbi4NCj4+Pj4+PiAgICAg
wqDCoMKgwqDCoMKgwqDCoCAqLw0KPj4+Pj4+ICAgICDCoMKgwqDCoMKgwqDCoCB3cml0ZV91bmxv
Y2soJnBkZXYtPmRvbWFpbi0+dnBjaV9yd2xvY2spOw0KPj4+Pj4+ICAgICDCoMKgwqDCoMKgwqDC
oCBwcm9jZXNzX3BlbmRpbmdfc29mdGlycXMoKTsNCj4+Pj4+PiAgICAgwqDCoMKgwqDCoMKgwqAg
d3JpdGVfbG9jaygmcGRldi0+ZG9tYWluLT52cGNpX3J3bG9jayk7DQo+Pj4+Pj4gICAgIMKgwqDC
oCB9DQo+Pj4+PiBJJ20gYWZyYWlkIHRoYXQncyBtaXNsZWFkaW5nIGF0IGJlc3QuIGFwcGx5X21h
cCgpIGlzIG1lcmVseSBhIHNwZWNpZmljDQo+Pj4+PiBleGFtcGxlIHdoZXJlIHlvdSBrbm93IHRo
ZSBsb2NrIGlzIGdvaW5nIHRvIGJlIHRha2VuLiBCdXQgcmVhbGx5IGFueQ0KPj4+Pj4gc29mdGly
cSBoYW5kbGVyIGNvdWxkIGJlIGFjcXVpcmluZyBhbnkgbG9jaywgc28gcmVxdWVzdGluZyB0byBw
cm9jZXNzDQo+Pj4+PiBzb2Z0aXJxcyBjYW5ub3QgZXZlciBiZSBkb25lIHdpdGggYW55IGxvY2sg
aGVsZC4NCj4+Pj4+DQo+Pj4+PiBXaGF0IHlvdSBpbnN0ZWFkIHdhbnQgdG8gZXhwbGFpbiBpcyB3
aHksIGFmdGVyIHJlLWFjcXVpcmluZyB0aGUgbG9jaywNCj4+Pj4+IG5vIGZ1cnRoZXIgY2hlY2tp
bmcgaXMgbmVlZGVkIGZvciBwb3RlbnRpYWxseSBjaGFuZ2VkIHN0YXRlLg0KPj4+PiBIb3cgYWJv
dXQ6DQo+Pj4+DQo+Pj4+IC8qDQo+Pj4+ICAgIMKgKiBGSVhNRTogR2l2ZW4gdGhlIGNvbnRleHQg
YXBwbHlfbWFwIGlzIGNhbGxlZCBmcm9tIChkb20wIHNwZWNpZmljDQo+Pj4+ICAgIMKgKiBpbml0
IGNvZGUgYXQgc3lzdGVtX3N0YXRlIDwgU1lTX1NUQVRFX2FjdGl2ZSkgdGhlcmUgaXMgbm8gY29u
dGVudGlvbg0KPj4+PiAgICDCoCogcG9zc2libGUgYmV0d2VlbiB0aGlzIGNvZGUgYW5kIHZwY2lf
cHJvY2Vzc19wZW5kaW5nIHRyeWluZyB0byBhY3F1aXJlDQo+Pj4+ICAgIMKgKiB0aGUgbG9jayBp
biByZWFkIG1vZGUgYW5kIGRlc3Ryb3kgcGRldi0+dnBjaSBpbiBpdHMgZXJyb3IgcGF0aC4NCj4+
Pj4gICAgwqAqIE5laXRoZXIgcGRldiBtYXkgYmUgZGlzcG9zZWQgeWV0LCBzbyBpdCBpcyBub3Qg
cmVxdWlyZWQgdG8gY2hlY2sgaWYgdGhlDQo+Pj4+ICAgIMKgKiByZWxldmFudCBwZGV2IHN0aWxs
IGV4aXN0cyBhZnRlciByZS1hY3F1aXJpbmcgdGhlIGxvY2suDQo+Pj4+ICAgIMKgKi8NCj4+PiBJ
J20gbm90IHN1cmUgSSBmb2xsb3cgdGhlIGZpcnN0IHNlbnRlbmNlOyBJIGd1ZXNzIGEgY29tbWEg
b3IgdHdvIG1heSBoZWxwLA0KPj4+IGFuZCBvciB1c2luZyAiYXMgd2VsbCBhcyIgaW4gcGxhY2Ug
b2Ygb25lIG9mIHRoZSB0d28gImFuZCIuIEkgYWxzbyBkb24ndA0KPj4+IHRoaW5rIHlvdSBtZWFu
IGNvbnRlbnRpb24sIGJ1dCByYXRoZXIgYSByYWNlIGJldHdlZW4gdGhlIG5hbWVkIGVudGl0aWVz
Pw0KPj4gICDCoC8qDQo+PiAgIMKgICogRklYTUU6IEdpdmVuIHRoZSBjb250ZXh0IGZyb20gd2hp
Y2ggYXBwbHlfbWFwIGlzIGNhbGxlZCAoZG9tMCBzcGVjaWZpYw0KPj4gICDCoCAqIGluaXQgY29k
ZSBhdCBzeXN0ZW1fc3RhdGUgPCBTWVNfU1RBVEVfYWN0aXZlKSB0aGVyZSBpcyBubyByYWNlIGNv
bmRpdGlvbg0KPj4gICDCoCAqIHBvc3NpYmxlIGJldHdlZW4gdGhpcyBjb2RlIGFuZCB2cGNpX3By
b2Nlc3NfcGVuZGluZyB3aGljaCBtYXkgdHJ5IHRvIGFjcXVpcmUNCj4+ICAgwqAgKiB0aGUgbG9j
ayBpbiByZWFkIG1vZGUgYW5kIGFsc28gdHJ5IHRvIGRlc3Ryb3kgcGRldi0+dnBjaSBpbiBpdHMg
ZXJyb3IgcGF0aC4NCj4+ICAgwqAgKiBOZWl0aGVyIHBkZXYgbWF5IGJlIGRpc3Bvc2VkIHlldCwg
c28gaXQgaXMgbm90IHJlcXVpcmVkIHRvIGNoZWNrIGlmIHRoZQ0KPj4gICDCoCAqIHJlbGV2YW50
IHBkZXYgc3RpbGwgZXhpc3RzIGFmdGVyIHJlLWFjcXVpcmluZyB0aGUgbG9jay4NCj4+ICAgwqAg
Ki8NCj4gSSdtIHN0aWxsIHN0cnVnZ2xpbmcgd2l0aCB0aGUgbGFuZ3VhZ2UsIHNvcnJ5LiBZb3Ug
bG9vayB0byBvbmx5IGhhdmUgcmVwbGFjZWQNCj4gImNvbnRlbnRpb24iPyBSZWFkaW5nIGl0IGFn
YWluIEknZCBhbHNvIGxpa2UgdG8gbWVudGlvbiB0aGF0IHRvIG1lIChub3QgYQ0KPiBuYXRpdmUg
c3BlYWtlcikgIk5laXRoZXIgcGRldiBtYXkgYmUgLi4uIiBleHByZXNzZXMgIk5vbmUgb2YgdGhl
IHBkZXYtcyBtYXkNCj4gYmUgLi4uIiwgd2hlbiBJIHRoaW5rIHlvdSBtZWFuICJOb3IgbWF5IHBk
ZXYgYmUgLi4uIg0KLyoNCiogRklYTUU6IGFwcGx5X21hcCBpcyBjYWxsZWQgZnJvbSBkb20wIHNw
ZWNpZmljIGluaXQgY29kZSB3aGVuDQoqIHN5c3RlbV9zdGF0ZSA8IFNZU19TVEFURV9hY3RpdmUs
IHNvIHRoZXJlIGlzIG5vIHJhY2UgY29uZGl0aW9uDQoqIHBvc3NpYmxlIGJldHdlZW4gdGhpcyBj
b2RlIGFuZCB2cGNpX3Byb2Nlc3NfcGVuZGluZy4gU28sIG5laXRoZXINCiogdnBjaV9wcm9jZXNz
X3BlbmRpbmcgbWF5IHRyeSB0byBhY3F1aXJlIHRoZSBsb2NrIGluIHJlYWQgbW9kZSBhbmQNCiog
YWxzbyBkZXN0cm95IHBkZXYtPnZwY2kgaW4gaXRzIGVycm9yIHBhdGggbm9yIHBkZXYgbWF5IGJl
IGRpc3Bvc2VkIHlldC4NCiogVGhpcyBtZWFucyB0aGF0IGl0IGlzIG5vdCByZXF1aXJlZCB0byBj
aGVjayBpZiB0aGUgcmVsZXZhbnQgcGRldg0KKiBzdGlsbCBleGlzdHMgYWZ0ZXIgcmUtYWNxdWly
aW5nIHRoZSBsb2NrLg0KKi8NCg0KPiBKYW4NCj4NCg0KVGhhbmsgeW91LA0KT2xla3NhbmRy


From xen-devel-bounces@lists.xenproject.org Mon Feb 14 14:09:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 14:09:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272317.467104 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJc2T-0007Lg-W9; Mon, 14 Feb 2022 14:09:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272317.467104; Mon, 14 Feb 2022 14:09:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJc2T-0007LZ-TH; Mon, 14 Feb 2022 14:09:13 +0000
Received: by outflank-mailman (input) for mailman id 272317;
 Mon, 14 Feb 2022 14:09:12 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KkXt=S5=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nJc2S-0007LT-DG
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 14:09:12 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ae7b4f7a-8d9f-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 15:09:11 +0100 (CET)
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur01lp2050.outbound.protection.outlook.com [104.47.0.50]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-7-t3T81VKkNA6UCAdb9gcibg-1; Mon, 14 Feb 2022 15:09:09 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM0PR04MB6836.eurprd04.prod.outlook.com (2603:10a6:208:187::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.18; Mon, 14 Feb
 2022 14:09:07 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4975.015; Mon, 14 Feb 2022
 14:09:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ae7b4f7a-8d9f-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644847750;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=T/Wg8UUDDKuFbkM3QvHxuum3jOuNYrYnWD02Zgbhh2Q=;
	b=lwaRnAw2RWVWoaP4C1/407LgS7Jj7ThEJwVv+WcTDNH263ACtD6HPNKWCWZRv11UTqBXwn
	aRCRQF0+Qk44gsmM1Vb24CZoud0sM0icV6ZKHURqL9xOxiMX1Tne0e0HF694XuCFKeWi5H
	UfvhXqOVP6ZDzb8Y7ESqXHGzO229rNY=
X-MC-Unique: t3T81VKkNA6UCAdb9gcibg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=bGydpSGFt4JB8LW6TzCV8JisJx8r0JCSvGVCgs6aG0l+V/9r1T1R0O4oSMW5HAp0NmCnWXE5mhgq3gf4t5mLU4DP4E63EafIHhHqaiMde6Tv1AeaS367GPXir+xHq8Mw58ZxHT84yHadRtjvwA2Xf1kOXsaA+zCFmjazhTq3qABkD3MaXzIPrGSJs6l7vsWyjblWlG+WpFAYNXSSO+8Y0AuzCv3ch1KGP4SZU9YuxBVEJGLFIbTANDfBySQi0ZZ+QL37u8Qcw8TCtAQG2l92h0hZ+KsvwkqGc3vxfp6dky7RBcg8kcJeaXHVUbb0Cw0uakAaZEb5MfMtHtedKKUq9w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=T/Wg8UUDDKuFbkM3QvHxuum3jOuNYrYnWD02Zgbhh2Q=;
 b=cfqF/HffRnWKvSjlicM2G34VZogELXRbaHknhYF6Sm2on6DX+nfBU011Xgpp8C7rmEOoI53VE8rCbCn0v01FHM90Zl0EpoMhIuvqaGls70zEAQM97nCLcfnVp8/bgdBAtyvVIDe3hjxWLFKA1KoeUh0d+WmaMs00jqpzx7XTfA3Qna6HstShusjM4T4WYVvXSCsj1l2UjkUCNh2UDp41bnEOXlN8d6R5mAvo8CWu3xoTZxAtdngMA/uuH68Tk0eDpx1EQIKPPpOEiiI08UTOlyxhNobrAooP0qgwJQGkNzEnd4Q2o1sK8xRYj9gRjTBohYA5b6mkh75fvrfHFzSFFw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <3390f69c-d3d8-92d0-b434-0d4902d0b478@suse.com>
Date: Mon, 14 Feb 2022 15:09:05 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH] vpci: introduce per-domain lock to protect vpci structure
Content-Language: en-US
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "julien@xen.org" <julien@xen.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Artem Mygaiev <Artem_Mygaiev@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>
References: <20220209133627.959649-1-andr2000@gmail.com>
 <YgU6Snk8GTytJXZp@Air-de-Roger>
 <c4666570-666e-6680-5ec2-adf1da51ad06@epam.com>
 <YgZLEMW9US9QjjYG@Air-de-Roger>
 <33fb1095-64ed-29ef-ba6b-cbde21d941f8@epam.com>
 <YgowIg5MvTaf2zsR@Air-de-Roger>
 <d8389a90-00c8-b34a-8488-b0f3fc5bde1b@epam.com>
 <Ygo40L4dMPJjZKRF@Air-de-Roger>
 <746860aa-c403-1eca-0a75-587c5d10c8c2@epam.com>
 <Ygo8M3Y6BLzljn15@Air-de-Roger>
 <114b8578-ee13-b67d-e282-d060187ef509@epam.com>
 <06baf0c8-d7d2-50b8-ea8f-1d422ceac728@suse.com>
 <6ccc7add-c13e-555f-b341-ce37118746e5@epam.com>
 <f0e202dd-1f6e-4aac-1381-a64a7fd12270@suse.com>
 <ba901778-ce63-12f2-0a54-d56998090200@epam.com>
 <3538350c-0a63-59fb-7bba-fe460c0f1607@suse.com>
 <2a750ae8-9ca7-2e74-b878-11b98fcb4ca0@epam.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <2a750ae8-9ca7-2e74-b878-11b98fcb4ca0@epam.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR04CA0015.eurprd04.prod.outlook.com
 (2603:10a6:206:1::28) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 1571a934-f857-4caa-e30b-08d9efc390c4
X-MS-TrafficTypeDiagnostic: AM0PR04MB6836:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB6836256A4349D81C55A912F0B3339@AM0PR04MB6836.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6430;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	HwHECRlf8p2j869/TwUHOI6UfJBMB6FJ0IpbxHBeCMg9HhkPhqCZedtnPkzXT9ZrMub1jZex5MCLg8tmAC7V1EioKhILa5HI2IByA0cURox/CicVACLSKFE0COqaUoDItpNIqbrVM4mY08sdgp3nzvON5PbJxt1RHVH3y93CR4cMWPvuceYhZq+qEo8cFYoBBArSd7ZiWqrf+Dz/k8rMU63NOvRGj/0c+dkKUIt4CP6N0G38cuQaB5mvnmfEwnIAX8jKyTMg5XMqcurZBJ/8P/7aKZKM10H/v/sbyuEDpcQkt5VunT8/prZHI6OSBtNOsoRMFF14XuBRWkiKNzNrbA/8LN62cCxWdg8lVyfk+m23SowcdqrpR7GDZp/sXLPt1xDuVh519udpzQUjE1B8Wx5o4vlQcFqYiTgRBWq0hDCv188ehy8xJtWXRNpDJaY8gEBHAxLVDjnjzaQk/uI78rXooHYbrslC0rQ2vYxmYQRO56fM0V7KBhs55YvqPkYyZEfHhF0GcNO6AEv+mC5ajjlPyJUXHnTNM2ZwRWUERxh+czQF5DFrwPjoX66vDfWhjLMHcW29r8l/70mCwRALxCsaMxCVfutFu+r5rFdHnUEwRwa8dkXbS0OUKm84220Tngu7cT5QpZ7o0/DV6F1m7v3bTQkC44xQQPjCty8FLBFAaAj9i4SZuv8rD3aWB5HybjrJqyyuDw7z+neNAyBfKiljX4o18YPgg8Kji57Ru54=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66556008)(66946007)(4326008)(66476007)(8936002)(8676002)(2616005)(2906002)(53546011)(38100700002)(6506007)(6512007)(7416002)(5660300002)(4744005)(6916009)(54906003)(83380400001)(26005)(186003)(31696002)(6486002)(36756003)(31686004)(86362001)(316002)(508600001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Vk1ZV0VRNGwxTVIzVis5c3ljamQzK3dHTXdFWWRZZWRwUStzTWRMOElMOGEy?=
 =?utf-8?B?UTRVUGZnenNmVU5XNVFZUVJrMmkzU2tVbE1WMFBqQ1R1dkMrTGZ6QXhCaWNx?=
 =?utf-8?B?UFBBYUNzdFBzNXRTaktTVU4xVnBybGkvbllYbWhCR0VRcTVQYldEK1k0N3dw?=
 =?utf-8?B?NDdhMHArQmJhV0pOUWxzUzQ2N1RyK0R2ckxMS0lpRHp3TWlCRFFzMnBMK1Za?=
 =?utf-8?B?Y0dJcVN5UnlIc1dDQjFBM1lrUFVsWGtCYmk3U0cweGd1emJPWkNCc1JNbC9w?=
 =?utf-8?B?bWFMSk4vWndFMUd0YmFleHFlaEcrQWRienpMNDM4bjBJYW9NTkJJenc1LzNr?=
 =?utf-8?B?YXVBd3Y4cnpVQ3krWVpxYVhOT2gwNlIrTlFiWDJrbEpIMStkTDVoU09JOFd5?=
 =?utf-8?B?QVBETlhiZ2lyZFl6S29WQWtOdFRIQVRkaHdRdDEyV2M3eWNJd1dmV1Rnei8w?=
 =?utf-8?B?aUxNS1hlbGpQaS8vd0YyRzhjaTR1dnB0UnBtYVU5RHBTQndQbkRFZnIwRXB3?=
 =?utf-8?B?VlFyMEk2Nm1QZnVyMVpBZlcrSkdveWlmR3A4OG12ZlB1VzJrbzVQSGpNOUNa?=
 =?utf-8?B?MldsVVJjZTZMSnZKejFNa0pCQVkybjM5eEJ5MkY3U1RKZzlHRDh0bU81L1U4?=
 =?utf-8?B?SnEwelZoNTNrbUNxMkkyK0paUkNmaHE5WTVrWklrcXZ2ckZDVTg2NFowVXJj?=
 =?utf-8?B?ZE43S0l0MnlBMXdXT2M5MzUxZWpqc2NGbU9Eb2VxVHNtZ0diSWxUb2pOajdI?=
 =?utf-8?B?dmprTFAzZVpaWHhrZnRtbi9qRjUxWkRGTytJZGUvSTZ5WnROc1dnUzJlZEMw?=
 =?utf-8?B?K3hoK08yRmtpcitjeDRPTlFQNmdzQXJOOGdSdVlSYkRINitqbG5ITzdkZW4r?=
 =?utf-8?B?MVhNMktORUROSFBaUVZoZFVxcGl6bDdyUzdvVXhLVVdpckR4dEtPOWpKWXpE?=
 =?utf-8?B?Q0NmczRjZ01UV0grQTRNbXhqbGV2M0J6OGtPVVVWdWpwVGRWRkxUS3FCSHZs?=
 =?utf-8?B?Y0N0dVJDRFZDQS94SzRna0pIRXZ0anNHMGkzVEJjQnRiYW9VMmo5Sisxanhl?=
 =?utf-8?B?aGhRdFYrSFNkc2xGTGF2SEkxVnR3eVpBRUdIZGFHM05RdENRUXVFckR2b2lN?=
 =?utf-8?B?aXY0cUJKcXJaTzZzM3g1RHhja0NTKzJWTDZ5bWpXdUJFMFN3VlFiTlpVKzRS?=
 =?utf-8?B?ZHY2WTluMDVZWE5qNkY4OFo0dmdFTDFDVFVFN2lacjBHVm9NelBUb2lrM01h?=
 =?utf-8?B?cDZXTE5aSDRTSUh0c1FmdEFUWWQzeklqM3BWKzZiRUxjL08yaUZDMzVJcjQv?=
 =?utf-8?B?Z0pnYlBuWW5qQ21oa0xhQ2UyTzNWZCtMb2N1OGdkM2w3TDk4d05RUnRXTUZk?=
 =?utf-8?B?MGVrYnpoeEFZclNwaXZUVldEMEV6TDlyUWd4RUw4d1ViMys3dmJoSjFCbzhr?=
 =?utf-8?B?VGhPV0JDQjhsa0YzTVhTMkRoMmVobHNhUWF5aUlGaEhaQUxtTDZUdFVOUkNX?=
 =?utf-8?B?NDd4Z0JmUzdObzBadElUNnNEM1RrYzlldVVseTMvb0VrNXZtRUd1emZ1ZUh4?=
 =?utf-8?B?Q2h4SmdKeExVcGt6V1ZNK2FtNTlNSzFGMG8zL1ZBQko0b2k5TW5zVVNTWUda?=
 =?utf-8?B?enkwK2IyaHpEaEhlV2VNUVBXVTFOaXkxejY3bDN2RzVvYnY1dlpFbzRvQi9w?=
 =?utf-8?B?ZWljWTh5bXJhaG5Uc3pkNllzeEtzSmVENTdzc0JEUDlVNW9HamY5WkF4OEZO?=
 =?utf-8?B?UnpMVWpNMlVvRnNuMHRmVFhXZVFuQTBZZHcvZ05rSE9ETlV1SjB6Y21iVTJr?=
 =?utf-8?B?RlVSdU9rbXpHVkJpcGMra1RSMTBPRUEvRFJmMWF4a2dueWMrZVY4NmFNZ1VE?=
 =?utf-8?B?eCtKV0s0STg4WTBKY0lKMnc5U1J0TnZIZ1FTZkx1TkRhbWUvU010Zyt6V3dh?=
 =?utf-8?B?a08wUjVFbEhLcDlpRFBiSjVWWC92ak0yb2lESjJjVVBZVmR3a1U1QjY4ZjdT?=
 =?utf-8?B?L2drMFg4UmE2aFFicWtuaCtObEY4UmhFT3BYSlZGTVJRdTRIN0pvQXZySDVU?=
 =?utf-8?B?R3ptRVdUekdzcmRDbWhoQ1JROC8yTnM4cE9vSkZXa1ZvZzhxMWdhVTNiWmU3?=
 =?utf-8?B?RWc1S3RjNXVsYi93bXpPbWpaYjYrWUVSWGZQdDhpZmRjTTd5Slo4eWhJWUQ0?=
 =?utf-8?Q?ZI1gTajVz2tX7O/yn7Y9jec=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1571a934-f857-4caa-e30b-08d9efc390c4
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2022 14:09:07.7525
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7aJ1E/M1biC8p6NENJ3FEkPj8AJ/uaO8cxFznfjsUwT46P27VDCdI93F0eSB3k3+zTxschpbX9pXBnRcHJ0trA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6836

On 14.02.2022 15:00, Oleksandr Andrushchenko wrote:
> /*
> * FIXME: apply_map is called from dom0 specific init code when
> * system_state < SYS_STATE_active, so there is no race condition
> * possible between this code and vpci_process_pending. So, neither
> * vpci_process_pending may try to acquire the lock in read mode and
> * also destroy pdev->vpci in its error path nor pdev may be disposed yet.
> * This means that it is not required to check if the relevant pdev
> * still exists after re-acquiring the lock.
> */

I think I'm okay with this variant, pending me seeing it in context.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 14:16:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 14:16:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272324.467116 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJc9F-0000NO-PC; Mon, 14 Feb 2022 14:16:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272324.467116; Mon, 14 Feb 2022 14:16:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJc9F-0000NH-Lw; Mon, 14 Feb 2022 14:16:13 +0000
Received: by outflank-mailman (input) for mailman id 272324;
 Mon, 14 Feb 2022 14:16:12 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJc9D-0000My-Tw
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 14:16:12 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a645b747-8da0-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 15:16:08 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a645b747-8da0-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644848167;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=+/M+up3u21H5aCWSuyMDsIZV5CyiRJCxmfayMhFC+LY=;
  b=a/tns2fjVYT+m/cuScLB1Sxy0XhaAc5d1y+tKijYNTZ10Zj//O1wV9Xp
   UhNmijtHr5plZ7kSrK3IbxT53mKL1YMnB5tRZGhWV27N+5oSYHzE+baxY
   T1WWJp9irpPVySXbAhm6Y+kApurXG3BLMtse3dRmoG5LuW2npGRXBUwBC
   A=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: ssp5zLyMpGHiFHZg68k1FMhQVjOexb27ZwAJydK4YOsVZybZ471Rmd4ovej8s9aCLJb0bPLNyw
 Zcm5IDYYi5sQ4Snf1iVdWStvxkwAtoxCkxdalY0NEmk8tbH3t1psYfOVyQLRPdV6dwmsaNirKg
 4TEsQSqcI7hgjar84wl8F+Ww89VojC0o4kSvzcPVuZ70VxVe2A2jsbrTrVY34lhcxG2te+hiEx
 7CSzrC7oKc5Amz1mRSPxJG9w9AhRoZysWn4ygqy8Y3SOZqQ41MIZNIaYzXfQ175HAidYI6+I4L
 ZBDVN7zjwTVT6Kw9nHj/cLBW
X-SBRS: 5.1
X-MesageID: 66381804
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:I4yj2qOVvHbVHgfvrR3zkcFynXyQoLVcMsEvi/4bfWQNrUp0hTxTy
 GYZWm3TbvmNYmemKdFwYdm1oENTscOGzIVjSQto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6UUsxNbVU8En1500s/w7RRbrNA2rBVPSvc4
 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq
 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYowSqzstX2
 tJpj7e9ZTUZH4mRlro+bjANRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs
 6VFdnZdNXhvhMrvqF6/YsBqit4uM4/AO4QHt2s75TrYEewnUdbIRKCiCdpwgmlr1pkeRaq2i
 8wxQB5FZw3jTxpzH0oNNM09vOr4qULQfGgNwL6SjfVuuDWCpOBr65DhKMHQe8CKbcxNk1yEu
 3nd+GDkHhAdMsfZwj2AmlquifXIhjjTQ58JGfuz8fsCqE2ewCkfBQMbUXO/oOKlkQiuVtRHM
 UsW9yEy668o+ySDS9DnWhSirX2svxgCWsFRGek39AGMzKXP5w+TQGMDS1Zpc8c6vcU7QTgr0
 F6hnN7zAzFr9rqPRhq19L2ZsDezMig9NnIZaGkPSg5ty9v+pIA+iDrfQ9AlF7S65vXqHRngz
 jbMqzIx74j/luZSif/9pwqexWvx+N6ZFWbZ+zk7QEqUzVJiQpyiQ7aD5HTp3ddkcYjHbWSo6
 S1sd9el0MgCCpSElSqoSeoLHa206/vtDAAwkWKDDLF6qW3zpifLkZR4pWgneRw3appslSrBP
 ReL0T698qO/K5dDgUVfR4uqQ/onwqH7fTgOfqCFN4EeCnSdmeLuwc2PWaJy9z23+KTPuftmU
 Xt+TSpLJSxEYZmLNBLsG48gPUUX7i4/33jPYpvw0g6q17GTDFbMF+tZbwveM71htfjeyOkwz
 zq4H5HUoyizrcWkOnWHmWLtBQxiwYcH6WDe9JUMK7/rzvtOE2A9Ef7BqY7NiKQ+95m5Ytzgp
 ynnMmcBkQKXrSSedW2iNyAyAJuyDM0XhS9qYkQR0aOAhiFLSZyx950Wa5ZfVeBhrISPO9YvF
 KJbEyhBa9wSIgn6F8M1M8Ws8tw6LE7z7e9MVgL8CAUCk1dbb1Wh0vfvfxf19TlICSyytMAkp
 Kan2B+dSp0GLzmOxu6NN5pDFnu94ioQnvxcRUzNLoUBcUng6tEyeSfwkuU2M4cHLhCanmmW0
 AOfABE5o+jRotBqrImV1P7c94r5QfFjGkd6HnXA6erkPyft4Wf+k5RLV/yFfG6BWTqsqrmif
 +hc09r1LOYDwARRq4N5HrsylfA+6tLjqqV01ANhGHmXPV2nBqk5eiuN3NVVt70Lzbhc4FPkV
 kWK89hcGLOIJMK6TwJBeFt7NryOjKhGlCPT4PI5JFTByBV2pLfXA19POxSsiTBGKOcnOo0S3
 up86tUd7Bayi0R2P4/e3DxU7WmFMlcJT74j6sMBGIbuhwcmlgNCbJjbBnOk6Z2DcYwRYEwjI
 zvSj6venbVMgEHFdiNrR3TK2ONcg7UIuQxLkwBedwjYxIKdi69lxgBV/BQ2Uh9Rn0dO3O9EM
 2R2M1F4ePeV9DByickfB22hFmmt3vFCFpAdH7fRqFDkcg==
IronPort-HdrOrdr: A9a23:csp9jK2fSwGHTjPY+aF5kAqjBRZyeYIsimQD101hICG9Lfb2qy
 n+ppgmPEHP5Qr5AEtQ5OxpOMG7MBbhHQYc2/heAV7QZnibhILOFvAi0WKC+UyuJ8SazIBgPM
 hbAtFD4bHLfDtHZIPBkXOF+rUbsZm6GcKT9J/jJh5WJGkAAcAB0+46MHfhLqQffngdOXNTLu
 v52iMznUvHRZ1hVLXdOpBqZZmgm/T70LbdJTIWDR8u7weDyRmy7qThLhSe1hACFxtS3LYL6w
 H+4k/Ez5Tml8v+5g7X1mfV4ZgTssDm0MF/CMuFjdVQAinwizyveJ9qV9S5zXIISaCUmRMXee
 v30lAd1vdImjXsl6aO0ELQMjzboXITArnZuAelaDXY0JfErXkBerV8bMpiA2XkAgwbzYxBOe
 twrhKkX9A8N2KwoA3to9fPTB1kjUyyvD4rlvMSlWVWVc8EZKZWtpF3xjIeLH4sJlOz1GkcKp
 gkMCgc3ocjTXqKK3TC+mV/yt2lWXo+Wh+AX0gZo8SQlzxbhmpwwUcUzNEW2i5ozuNwd7BUo+
 Dfdqh4nrBHScEbKap7GecaWMOyTmjAWwjFPm6eKUnuUKsHJ3XOoZjq56hd3pDmRLUYiJ8p3J
 jRWlJRsmA/P0roFM2VxZVOtgvARW2sNA6dg/22J6IJzIEUaICbQxFreWpe5PdI+c9vcfEzc8
 zDTa5rPw==
X-IronPort-AV: E=Sophos;i="5.88,368,1635220800"; 
   d="scan'208";a="66381804"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=KdUvfzn/gNDDTqISoKDgW/A1CyrjPk+6othe6DG6BPhWwPhrun34qF2S/1oGSSKMe9X4bASyiKHw4vq+gP82+dohs9RVGhck/xUYBSoucEX8vo1dFRO+aGWJoJlDNviEAqt1r+/QhgbT0Cpy2RQG8DA02+rcox8qhO1KzeDpmL+zi/aAtRLR825GU07eAtLT5oh4llk+OitRqEtiWw8BkB1+lLF5YtyfUnZodK1XEkNLjr9CEJeWkt8i5aT9MNLghuQJiXUpnJeW7vP5T1hgWD2UglDnRFuSyRmZx+2dOodPVqift1V3N6ApYiLbuX9Xh1UZ4QMvYtyoJ9EQF1jPhQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=+/M+up3u21H5aCWSuyMDsIZV5CyiRJCxmfayMhFC+LY=;
 b=DO77sHGifZ53GE7eClct7b60ybhRjwIAdJrU+u3okD4jZRHBvoU5j1dXIm23D6es3hkSp7Eng5LL05YEbIQ/g8KaNxU8U+obOGXlGQclzUeomTvRYAE9X1K1oeWpWJf4UtBowaDe+KLBbP4welGnTGh6P4mTORhxx/MPa+lL+d5RAced4LSYNcpszDw15BqnqplqWjlVk7x54fvP/LPqb3B1sY+RgnVfNBiRj8rCm35ep7De238Fmdvbk8S11+5lVvuGcs131yLrX62B/0+rpnh8MTyZWS/4CqSijwwFI51vMeefXlNsxTFPI59rvl8wJSmG1lKnE1wY3XGM65iwGA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=+/M+up3u21H5aCWSuyMDsIZV5CyiRJCxmfayMhFC+LY=;
 b=BqDO/E+qUXlU5U8gjkRvwipjNDcyesCLBn289aptZO/rvpMFlDQkOCaNxUI1BIWexzXOB7a/l8o1IDWkQJBc/6HMymVYG483N3JEkWhpYEZsUOMu2ncMNmxeYhsadhuUHD6KduMMS8oRMh2JcOAJicDy5CKXuQoh/9FWDh7mvSA=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>, "Julien
 Grall" <julien@xen.org>, Roger Pau Monne <roger.pau@citrix.com>, Juergen
 Gross <jgross@suse.com>, Daniel Smith <dpsmith@apertussolutions.com>,
	=?utf-8?B?TWFyZWsgTWFyY3p5a293c2tpLUfDs3JlY2tp?=
	<marmarek@invisiblethingslab.com>, Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2 00/70] x86: Support for CET Indirect Branch Tracking
Thread-Topic: [PATCH v2 00/70] x86: Support for CET Indirect Branch Tracking
Thread-Index: AQHYIaGi+1XAXGQfKUGTLygtpBu/SKyTBUWAgAAJC4CAAAkaAA==
Date: Mon, 14 Feb 2022 14:15:39 +0000
Message-ID: <8c6dd7d0-11e6-9b8a-66fc-f1a4998c074b@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
 <c471dcc2-8a91-60b8-ba5d-58874752e4d7@citrix.com>
 <218de2dc-6dd8-4e13-3288-36448e47de7f@suse.com>
In-Reply-To: <218de2dc-6dd8-4e13-3288-36448e47de7f@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 8d289064-e017-457c-1b34-08d9efc47a5f
x-ms-traffictypediagnostic: MW4PR03MB6396:EE_
x-microsoft-antispam-prvs: <MW4PR03MB6396967A8D7DD5BCF12AF868BA339@MW4PR03MB6396.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: WEGYfKZKm8BH13kCSNJ0YOJSi7qvMgoVwQEDqtw2A3bUG0JUqGThtsRw2oZR7j5e0l98hpvRPiQPSSHg4x772C75GJvK2qF+IjWZSvIS3a+y58+CHm7LD5rCo1iyILsfMpnVyxLGLt3krIhmxAA2o2Z3QIzwFbOsbtglDNneA2uly0x6Dvx18bozx2STBwVwPkYEOOM1fXJThwuKt+Vumu7pLlP4+PzUkvALtD4KGQEuUqr+dV1HiVPrjb3amRIiaBjHxx8H86bJH17BiPa5+XQ8EGpepRwmvD5YNzyGJiFIkjXvQLMNGBuQTfIls1N4l10L5a1pQvQMR/luFgkPrkWKjM/KaZ8Mt+9apzJBfe3S78XzV+yShhosm92pWddBf616pFFMEwBBR+y4TyzlvFKX/WDPVA/g9cIDQFAbqfWG0/UiyO5oGYVUtFdEZvNaEpcTOU3KuJ76yh8gN1BUtS9S9wQZufKdi0Mjig9MG/3TdwvyJz1zKNMdUHWM6TNS2gDq1dl46eRp5jDVV/j2r41waXCXLFO7LbLiHq/jMQwUexQ+RU+CC9E4S95mjKqGRdXV2ChqTOh9/GI++kHUrBgqFQnH8SoaDXVks55giRk4LMz+EiOyCPbu4mOHLyV+MQE0n8kp0q1SDLCazaHkAybpYtRhziChv63nZWg5JWZIPlNXMeNMbU+z6BRk9KzMxE6B6OaEkPxBSRlTrlo4ZpYDRRUgdWrv74vDRu1PnrUxULAKPhrKr07Fq2KhA2pZx7YviKUz3g8aK6UAS4GoPtzTu3o2PgM2kLGv1LNUWWNe3KWgawl9zK4hTXrfwNsGS8zpOLGsdDlWMtAcpC6raMxgnCy03PIct+LkSTjCcGI=
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(122000001)(82960400001)(2906002)(31686004)(6916009)(53546011)(5660300002)(71200400001)(316002)(36756003)(508600001)(6486002)(38070700005)(66556008)(4326008)(86362001)(54906003)(91956017)(38100700002)(6506007)(66946007)(2616005)(966005)(31696002)(186003)(66476007)(6512007)(76116006)(8936002)(8676002)(26005)(66446008)(64756008)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?ZWdLNTBGMGpTMkZiaWRvZUlkSTYveXZrZ1VoR3dXbGt6YXB1WHJqcU1tS2NW?=
 =?utf-8?B?c1JPY2p0U05GQzhjbHFmWVB6REFGYzBIYlZjanZTOTB3SjRxTHJYdDRTNzhM?=
 =?utf-8?B?YmRhYXNZa0RyRW9sNVp6Z2hSUUFxOXBLenlzT1E0dVdhck5aNEFaQmt1aWk5?=
 =?utf-8?B?Z0tvcGsvZE96ZTZQZHlrZnhPUFE3enBleEU4RElBTnZ5MTBSeUJMK3FpdHcz?=
 =?utf-8?B?N3hmSjQzYzRKWjhTc3RyOEc1a1dpTVdtZlBRU1hONjdYOVJhRHRVMFA5VTdP?=
 =?utf-8?B?UHNTQTUvdFEvUFJvNGtWM0QrVXRWQUVHNnJSdnk1V0xUZjhwR0tWWUlmRVhD?=
 =?utf-8?B?WGZjbG94ZFVHaUdtZGRjTXVJZDRHc2lpNFdJZTF0UURYeTUxVVNPTHFWVllB?=
 =?utf-8?B?anF5cW1CRjgwN1VSbUhCSnVzdWhIM0M0Wm5uUTg5VXBWYzlnOWVwNHVEYzF1?=
 =?utf-8?B?QnRWQ0ExQTFOK2JHR2c2RFk0UFJLZUdmelRhQjVUWE9Ua1FPQ2VJWDZYYzVN?=
 =?utf-8?B?TXFzQUcvMmJjWE9IaTY0RUtOWGpQbStHVWpZLzdQWVA3aDZKZVpxMUgza0Vt?=
 =?utf-8?B?ZGYxaWw5akVGV0luYk96SUg5ZlV4cUxKTXMrMWptOUZlUkp3YjUrOFJKYktP?=
 =?utf-8?B?dC9neEw3SDljL0hvVDhXZG84K3p4VnJKMEJPQ2JBLzAyS0lKMTIxY2ljbjhN?=
 =?utf-8?B?Z3NyNjQ5OUltUkNkdGFxYldTTGRQQlFVQzBGbkVaQkxzOUh0UzBkc0pIcjVl?=
 =?utf-8?B?cmFaZUFGSWdvMG1oS0poTFgwU1hxbHZMR2RXaDhGd0dJK3B6WldtU1dNN3o2?=
 =?utf-8?B?TVRFVFM5OEFXUUo3YmpXTEtwckt5R3owR0wvMElwV0VzL09rYldUdEl4OXpO?=
 =?utf-8?B?N1IzZXRKd2tLZitJQlNlN2lpWUt0M2EwQ0ROam82LzJKYjhxMEI4VFRxSEN0?=
 =?utf-8?B?aFZ2RjJzV0FBRTJQT25aWGdUTnFUSW9BbWZZck9VeWt1TVFiYnFUTWg4Mmhs?=
 =?utf-8?B?WnNrUkFqcTFrRHRoSVRZQTVzRXJ1VFRGZkdMLzNlbEh1NmVFdjhXRlZpL3Vy?=
 =?utf-8?B?ckg2L2NqbzFVMzQ2YitEY0ltMTArL0JxSWorUzFNMDR4UnhvbUFjTTBUZEpS?=
 =?utf-8?B?cmNFaWpiTHRUSnVhcXVKbHlJRnBoWExWeFFHbTBBdnpBRUdSWTB5NzY1MytV?=
 =?utf-8?B?RFc2RVRQaDA3U2hPWHIrWGp5ZHBIT1czaGl3UUtzb0M3cEhTM1EvTHk1QkpT?=
 =?utf-8?B?bGxZWExtRWpCNTZweFVpQnphL09STDdxU0R5U08wWUVuNUJYN1llU2Q0NTln?=
 =?utf-8?B?UWd4cnNqOTlacGw4Tjl3WE56N2k2OFUxZXRkVmNITUEvdnBmUTRIbCsrYmFr?=
 =?utf-8?B?YkdFc3A5Y0dYZnNnbG1FTVY1Q0dtNmh6WWVXQ2ZxMjQzVU1qSGdodlg1elNP?=
 =?utf-8?B?ZGdBd09reHVyMEtIOUxYUFJsY0k4YVhiVHZyZVlISW05WlY1OW9oZ0h1ekNr?=
 =?utf-8?B?SDVRWWI5clo5UFROUmwreDBSclNsRU5uNzY2ZDJwa2x6RGRaeWNaSGFkdDhW?=
 =?utf-8?B?UmdrYm1lTlJXemdON3lpY3JhME9hcXlodWF5MHY5c0dkQnB6RFduQWRVd25j?=
 =?utf-8?B?KzlTM20zVFZGRHRBOXFhRllNejlJNEhUZFc2N21Bb3BIS3ZQL3E2ZUNHYW1S?=
 =?utf-8?B?S2E3SElubDJ0cmZaS3BVdkV5dU5XL0daaVBDQUJvbXc4K0lUV1hkeVBmb091?=
 =?utf-8?B?c09zeGtoS25tTjhsTWxBd2tVRDV5Q0Y3VnFBMmtZMEtmb0RFbHFHU2ZuOU1B?=
 =?utf-8?B?WmQzd1lXN2EzK0F5c2JYem43bHVIdUsvQ2FiY2hiNW5IanVjOW1pSEFTeTA5?=
 =?utf-8?B?UTI3M0h3WWVsWUhMVDZBcS9sWHVmRTFxSjEwcWg0UmhVaklBY3pYN0tBSHQx?=
 =?utf-8?B?QTRsRXQ4S2VEbm0rb0VEdVUrT0hkelFqM214VWl6MFF3MDZmYWQ0WUd5STV0?=
 =?utf-8?B?Zzh4ZVo5STVIaU56VjRob1Q1TDkydVQ5QnczYjVOb2dFM3RvaTFhbEpXRndE?=
 =?utf-8?B?dVhxU1NjdFM5aVhqZmlrc0RsM3hmUzJzejVic1VoQnREMWszVUhySXYvNExH?=
 =?utf-8?B?QVlnUVZQQjF2VWpYZjlpM2xGeXR5eHFIYURiMEtjMmI3c1BRR01KeFU1K2p2?=
 =?utf-8?B?SWFyTEhBWjhFQ3RMVFViajN5MTE5ZXVLaVdLeTQ0cXVYVGZnWnJxeGhadnVo?=
 =?utf-8?B?S0ptRUc1S1J5L1pUcDJoQlJqUE9RPT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <3B8387694C45FD45AA55FEC266FB97DC@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8d289064-e017-457c-1b34-08d9efc47a5f
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Feb 2022 14:15:39.4380
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: nO78ET3FzyuYETCp78uCIo/AtUw23IShFblIq7uXzCOBd5/QUTzErAO1oyD33mLACSef01+9ObaXOPW4lShS56lqqq+TCbInSBxday8D1co=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR03MB6396
X-OriginatorOrg: citrix.com

T24gMTQvMDIvMjAyMiAxMzo0MywgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDE0LjAyLjIwMjIg
MTQ6MTAsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBPbiAxNC8wMi8yMDIyIDEyOjUwLCBBbmRy
ZXcgQ29vcGVyIHdyb3RlOg0KPj4+IENFVCBJbmRpcmVjdCBCcmFuY2ggVHJhY2tpbmcgaXMgYSBo
YXJkd2FyZSBmZWF0dXJlIGRlc2lnbmVkIHRvIHByb3RlY3QgYWdhaW5zdA0KPj4+IGZvcndhcmQt
ZWRnZSBjb250cm9sIGZsb3cgaGlqYWNraW5nIChDYWxsL0p1bXAgb3JpZW50ZWQgcHJvZ3JhbW1p
bmcpLCBhbmQgaXMgYQ0KPj4+IGNvbXBhbmlvbiBmZWF0dXJlIHRvIENFVCBTaGFkb3cgU3RhY2tz
IGFkZGVkIGluIFhlbiA0LjE0Lg0KPj4+DQo+Pj4gUGF0Y2hlcyAxIHRocnUgNSBhcmUgcHJlcmVx
dWlzaXRlcy4gIFBhdGNoZXMgNiB0aHJ1IDYwIGFyZSBmYWlybHkgbWVjaGFuaWNhbA0KPj4+IGFu
bm90YXRpb25zIG9mIGZ1bmN0aW9uIHBvaW50ZXIgdGFyZ2V0cy4gIFBhdGNoZXMgNjEgdGhydSA3
MCBhcmUgdGhlIGZpbmFsDQo+Pj4gZW5hYmxlbWVudCBvZiBDRVQtSUJULg0KPj4+DQo+Pj4gVGhp
cyBzZXJpZXMgZnVuY3Rpb25zIGNvcnJlY3RseSB3aXRoIEdDQyA5IGFuZCBsYXRlciwgYWx0aG91
Z2ggYW4gZXhwZXJpbWVudGFsDQo+Pj4gR0NDIHBhdGNoIGlzIHJlcXVpcmVkIHRvIGdldCBtb3Jl
IGhlbHBmdWwgdHlwZWNoZWNraW5nIGF0IGJ1aWxkIHRpbWUuDQo+Pj4NCj4+PiBUZXN0ZWQgb24g
YSBUaWdlckxha2UgTlVDLg0KPj4+DQo+Pj4gQ0kgcGlwZWxpbmVzOg0KPj4+ICAgaHR0cHM6Ly9n
aXRsYWIuY29tL3hlbi1wcm9qZWN0L3Blb3BsZS9hbmR5aGhwL3hlbi8tL3BpcGVsaW5lcy80NzA0
NTM2NTINCj4+PiAgIGh0dHBzOi8vY2lycnVzLWNpLmNvbS9idWlsZC80OTYyMzA4MzYyMzM4MzA0
DQo+Pj4NCj4+PiBNYWpvciBjaGFuZ2VzIGZyb20gdjE6DQo+Pj4gICogQm9pbGVycGxhdGUgZm9y
IG1lY2hhbmljYWwgY29tbWl0cw0KPj4+ICAqIFVFRkkgcnVudGltZSBzZXJ2aWNlcyB1bmNvbmRp
dGlvbmFsbHkgZGlzYWJsZSBJQlQNCj4+PiAgKiBDb21wcmVoZW5zaXZlIGJ1aWxkIHRpbWUgY2hl
Y2sgZm9yIGVtYmVkZGVkIGVuZGJyJ3MNCj4+IFRoZXJlJ3Mgb25lIHRoaW5nIEkgY29uc2lkZXJl
ZCwgYW5kIHdhbnRlZCB0byBkaXNjdXNzLg0KPj4NCj4+IEknbSB0ZW1wdGVkIHRvIHJlbmFtZSBj
Zl9jaGVjayB0byBjZmkgZm9yIHRoZSBmdW5jdGlvbiBhbm5vdGF0aW9uLCBhcw0KPj4gaXQncyBz
aG9ydGVyIHdpdGhvdXQgcmVkdWNpbmcgY2xhcml0eS4NCj4gV2hhdCB3b3VsZCB0aGUgJ2knIHN0
YW5kIGZvciBpbiB0aGlzIGFjcm9ueW0/DQoNClRoZSBjbGFzcyBvZiB0ZWNobmlxdWVzIGlzIGNh
bGxlZCBDb250cm9sIEZsb3cgSW50ZWdyaXR5Lg0KDQo+ICBJcnJlc3BlY3RpdmUgb2YgdGhlIGFu
c3dlcg0KPiBJJ2QgbGlrZSB0byBwb2ludCBvdXQgdGhlIG5hbWUgY29sbGlzaW9uIHdpdGggdGhl
IENGSSBkaXJlY3RpdmVzIGF0DQo+IGFzc2VtYmxlciBsZXZlbC4gVGhpcyBpc24ndCBuZWNlc3Nh
cmlseSBhbiBvYmplY3Rpb24gKEknbSBjZXJ0YWlubHkgZm9yDQo+IHNob3J0ZW5pbmcpLCBidXQg
d2Ugd2FudCB0byBhdm9pZCBpbnRyb2R1Y2luZyBjb25mdXNpb24uDQoNCkkgZG91YnQgdGhlcmUg
aXMgY29uZnVzaW9uIHRvIGJlIGhhZCBoZXJlLsKgIE9uZSBpcyBlbnRpcmVseSBhIGNvbXBpbGVy
DQpjb25zdHJ1Y3Qgd2hpY2ggdHVybnMgaW50byBFTkRCUjY0IGluc3RydWN0aW9ucyBpbiB0aGUg
YXNzZW1ibGVyLCBhbmQNCm9uZSBpcyBhIGdlbmVyYWwgdG9vbGNoYWluIGNvbnN0cnVjdCB3ZSBl
eHBsaWNpdGx5IGRpc2FibGUuDQoNCn5BbmRyZXcNCg==


From xen-devel-bounces@lists.xenproject.org Mon Feb 14 14:19:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 14:19:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272331.467127 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJcCs-00011h-AP; Mon, 14 Feb 2022 14:19:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272331.467127; Mon, 14 Feb 2022 14:19:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJcCs-00011a-6c; Mon, 14 Feb 2022 14:19:58 +0000
Received: by outflank-mailman (input) for mailman id 272331;
 Mon, 14 Feb 2022 14:19:57 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KkXt=S5=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nJcCr-00011U-6V
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 14:19:57 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2ed231fa-8da1-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 15:19:55 +0100 (CET)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2109.outbound.protection.outlook.com [104.47.18.109]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-26-4VP5IfGNNQW7i7v3lsNzcg-1; Mon, 14 Feb 2022 15:19:54 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM6PR04MB5832.eurprd04.prod.outlook.com (2603:10a6:20b:ad::32)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.18; Mon, 14 Feb
 2022 14:19:52 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4975.015; Mon, 14 Feb 2022
 14:19:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2ed231fa-8da1-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644848395;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=eIBMFJoRrQzjeSs7y+hAQfYO83nR9GrxY26fC53/D28=;
	b=Pj0jM6IMbdqc4SMBdomFu7UgTGcK8ROqgcHMA29faoVDI5Lq3rR3Eq2lECMaWOvmZEY40K
	mviqAu1k41tcU6GZ4eL6DoJe7P71gfLSfT5+F/o3ye0KYvCcH/r6ePaBHzF2wMYULbPqE+
	YncdpE/EXS1qQysyoZutXsBgporrhI8=
X-MC-Unique: 4VP5IfGNNQW7i7v3lsNzcg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=D2Ehfshwq3BtVCmJ8yCWnjWYHMftAqpKvHfFdjnBortp2DuZBykvnnB5AiPFu5yGhfgTaFVOyuGFeuK4TWGzGkVpXkXCy+G6n5OrinPavYmMKrVSRbIurbKEQeyDvFRkTbXMPixE7LfPse3xhjoRE1+eisK1B2EkjFIDq9edcp1BCtYqL62iUqVBVg0YsoRwIpagvqtjRXMlM0Obhgalq+vCtSNB9ojk212VU4bCZYZ78Vh9Z3sfXS0dUFI8KsRaWiZsT/qdy98HjyRD3FlbyFQTNeCKzm+hj+A6ZELEqbeqc9wk2SYZkkRelfBkDawS7vHvnQTrbQJznV0vDahpfQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=eIBMFJoRrQzjeSs7y+hAQfYO83nR9GrxY26fC53/D28=;
 b=Bgws0JRM60BRWckvRs3OFkDGaJ2dxcZ+8iFj013fYowUkEODD1YwJBRqpybmGdcVvUoVuVGa9DmzMWNIvn8it1ynXhFSu9KuURBFxu0vNa4L0IFEAJL73DMHx+/ueWuEjTINUm8KupAB6iTcO0Jj4Ph+S4rP+DviXelHfrWjJoa5Uu60Fli4VJ4wH+MFGAL4ChNS2x0vdUlnRh3xLACEUqIs7Ae437rKs9u1QG0W1bTDC8+hwfEsH4HygA0ONsixLPb4L4kGFlT5WGLbdTlJ9+0QH+jVtgKQNFQ/7BZt77ckenuQ6vuDBEJ667EKZZiBVKWPY3p+Zu6SqLcCjptX6Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <77f818a7-fe8a-20e5-3f1c-8fb7aef7984b@suse.com>
Date: Mon, 14 Feb 2022 15:19:50 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH] vpci: introduce per-domain lock to protect vpci structure
Content-Language: en-US
To: Oleksandr Andrushchenko <andr2000@gmail.com>
Cc: roger.pau@citrix.com, julien@xen.org, sstabellini@kernel.org,
 oleksandr_tyshchenko@epam.com, volodymyr_babchuk@epam.com,
 artem_mygaiev@epam.com, bertrand.marquis@arm.com, rahul.singh@arm.com,
 Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>,
 xen-devel@lists.xenproject.org
References: <20220209133627.959649-1-andr2000@gmail.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220209133627.959649-1-andr2000@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR0301CA0043.eurprd03.prod.outlook.com
 (2603:10a6:20b:469::35) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 98ef154d-a58c-4203-5c50-08d9efc51115
X-MS-TrafficTypeDiagnostic: AM6PR04MB5832:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB5832D38E86DAE5A0D50F38DAB3339@AM6PR04MB5832.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2958;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Hv/1rCVzUzHal6OKp/rPWypu7/CtQIeT/kDKajpDa6ILeAjYDA3w2ptaCqAI802XOkZBl7nDxN3yHWdwoDwZBSz6zyhCW6SMSo2MH5jTSlg7HZqAwV2+wUY2tkJhBvCwQe/I/1qPMOSDNdWRF33fOsnu/p3Q2p1pEs3tOd1skYavKYWxbX8e/pf6SJ99O8ZJSMmC+2L0xcyWWQe2yZLZtDovL4+JTd38zof3vqL0mw8Vneyq0efk2IFl6t4b409EAvHMYsW6zOHzbmJzZfO7BT3180eEV53DLMxGYwPtiARSkvlWuj4HRUskZKTCBiGJTYypCOwLzOtiYrsuwLL/ckWCq3aEQAw/3xGjXht0Kcu6Y8o2G4PzMD3vagvoUykgBM4xs4KDm3BmfyNVXHTxsFemNqwEzHmIiX/BKMDUmOjTHQY5Z90c38npaUX0dl4ZPoKoARoSCDXxAPHVw9pEPqpH9FqnfA7MLn2b2OFJAsjWr2dAYhDmReEI/QREPGo3qyIIOpPOlFJ2l6v+nlUQ+dIqojJsWEgZ6pmBZCHl98hLhcrTqF/1Fg2bmMAatbrXzUhlzQ2FUe/H1FaTPl4rYbFAg7BlFXiScKuzjAlTzkG3HT/VDeaJcRvsIgyz69PR/B6SBe4s2PuWOOsnA4injqafeAHxxnIyfy/n43Ga0bCdNXfLdqtjXUCxZ3EAph9Y76ZKvRsfjIwiKOf50fbs2kind6Q//qoVmCzh0YQ0kCU=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2906002)(6512007)(83380400001)(26005)(186003)(2616005)(8676002)(4326008)(66476007)(66556008)(86362001)(316002)(6486002)(66946007)(31686004)(6916009)(31696002)(508600001)(8936002)(36756003)(5660300002)(7416002)(53546011)(6506007)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NXNTcVlBREN0d2pFMk5GTzFkV0o1enNDZkZaOTZCWld1ZU81RThwWU5acnhM?=
 =?utf-8?B?aG5sSDlmNWV4RG1jbDNUbWV0Rk5vYjhKT0E3eGlTdU9NTWVoUHd4aEpqdjZt?=
 =?utf-8?B?aFAvYWdwdHhoeng3SUVUVUUxZS8yVmhVeFZGcVE5MS9lWHNNaTVuMy9mUWM2?=
 =?utf-8?B?NjlTME1McVJDc3FVZVlUWEJ3RXZuY2ZTeldrL3hLRzhubzA0ZUNNczhvYnQz?=
 =?utf-8?B?cTR3K2ZURUVxTmY0aEpHcGtqQmUwSTBOMXJrUDZYdDF2VHpuSmR5MlVybE1G?=
 =?utf-8?B?RmVBSjRTNlpQQUFQRVdnOVZHN2kxOGV2MzZnTXpvQU94SEEvaWZLQVVwa0VI?=
 =?utf-8?B?Zlc4YXNMbEdiSVdJOFlMdHAveVFzSEh0MHhqZVJzYkhBcDJ4VmkrN2xWMEts?=
 =?utf-8?B?N3U3WjZ5NTBJdndIRXFpN0ZNQmJ2SFREcmQyQllnMWMycVdRQWZaSjJNUVda?=
 =?utf-8?B?cGxtdnlQeWJOeDlMZUQ5Y0lLUlczZUl2amNtaVNxOEJwR3kwYnpsYkpmWXNv?=
 =?utf-8?B?cDBpdmpLL3Awejg4aStoVzFlRUxNa051UTJ5VlFhbW5Mbk00bSszNUZnTWhh?=
 =?utf-8?B?bm95YWQyOTVhUjNjOFFUbGdQRlMxNndZV2tsSi9FVy9JdTR5Y3hmTTQxNjd3?=
 =?utf-8?B?ejNxM3VlTWd4WUpxRFpRdW5BbXdyNnFuTHpnMmNrUE1EQU9Kbk9wWHN6QnRk?=
 =?utf-8?B?Y0lmUWxGcHRzWUNSaFMxNlhiVFpaanB0TlNkeVNrUjYxK3lWVzZacXhCUEtR?=
 =?utf-8?B?bmtCb1A5Z1BWRG1xNXB4NTJrQ0czem41OWtEdkNUT0RkbDJjMVhZMjYzNHJL?=
 =?utf-8?B?L0NKMGMyVjdUM0FudUE0Tk91UFA0UHU0eEgzdDJjdkl1emFaM2pJdHRsQnpv?=
 =?utf-8?B?U2tlRWlCSUxEbS8vUVQxSGlsK1BQUDh4RERLVFVaay9UOGR3My96N0plR3dS?=
 =?utf-8?B?TG9GSGl4bW1rY3BubEl5eUVlenQ5TW1qaEpPSlBSL2pvQXJyN3NxWXFNdjEz?=
 =?utf-8?B?Y0E0STl1c0k3U3RhMjBtcTNzc2ZOV2NKK2dESjA5N0U0cEtraEtSUkdhVFk4?=
 =?utf-8?B?aDdiRUgrclcvV29QbEJqc1RaNXFHK2tSMlhFYi9wL1NnTHZKT2ZZYm9pekU3?=
 =?utf-8?B?em4wTUc5NVlYUmNzZ0NwQ1NRSjAySXlHdXB4djAyWEY3S0l2R1dYeGl0cEN6?=
 =?utf-8?B?NnBDbElMZWFiNEJwYWpDR2dRSjhFZ1d0TnMyQW9lcnhHN1BhM2tNNHppR09W?=
 =?utf-8?B?OTNYMTlRNTUxaFNMZ3lBVW84STJ0Tk1HOUpCLzk3VlIwR01ORCswa1UvbGI5?=
 =?utf-8?B?K3dEVC9Edjkzd0dEdHlkZTIwMnl1Z2laOUZuK2xrOVdGSlkxRTNQM0tZS3Zm?=
 =?utf-8?B?NE9PTXIrZ0pManhQTHpLUkE4Y0tWbHQxaFNMbVJIYWFINEpwMnFYNi92TXVJ?=
 =?utf-8?B?STgvaXpYSXF5Z3pqUWF3cjNBd3dycU5QbUhUWWErTGtNK1lNUzB3RFRCUWVq?=
 =?utf-8?B?VWN6M0JRNWswYmVOZytvc3JPSEpKU2hUUEpySElUazZhcEd5Q21zTGV2SmRJ?=
 =?utf-8?B?bm1MY1Ayc1A1aW9mUzgyeGdQM0NuMEJ3UWxaUVdRZ2k1R29TN0NtZ21obkp3?=
 =?utf-8?B?SElMOTVod203N2lrSXloUCtIM1hCVTNEL2xwYm9xWVJlSjVrS0N1Y1A4WEpv?=
 =?utf-8?B?UUdORjIvait6Y3IwMjVoWDNTamlDNmhsOXZ3cVAvdGxLUWNyU0VqdlJuV1pU?=
 =?utf-8?B?b3ZKQTdQbUhoalIxVW82WlpzTFNPRjVmOFJ5R0FaNEx3dXZhK282T08veVor?=
 =?utf-8?B?c3JsdWp2MWVxU3Evd1dQZ3JJMmFHaXFhRW41YWFkMmxyOEMwMkZkNmZBSkpl?=
 =?utf-8?B?WTBWOXg5R1MwNTE3SnFIWSt1a0RhOVdzNVpIM1RLWFRVUnNoMUZEV09yNWRS?=
 =?utf-8?B?TEdDR0Z4VzdEZHZlaHNENlRiUlZYWmlYVGpQY3M3SGdKQ0htM05pQ2JuL2xq?=
 =?utf-8?B?M1RMN3BUSGNucUgzdEEwV2Y3VHB6aVFyNHhQUDhqU1M5b3M2U3hNV0hrK3Jm?=
 =?utf-8?B?cTRYUTZhdU45SkF5ZUg3S1pzOGpsSGZRUVUrQ1FIVHZoMk5id2psaEhuKzNC?=
 =?utf-8?B?MVkzOWdmME1sZTl3VnM2ellHMEc0T3d0TEkzZUhYeTBXWUc3RWE1Ny9Wd3I0?=
 =?utf-8?Q?dIJY1UR2T1dzeTyo9bJ0uY0=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 98ef154d-a58c-4203-5c50-08d9efc51115
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2022 14:19:52.6344
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UU85FUlWGcOQC315ugzAvXvfgpAGsaw+GXqHsdCWzocP/2+vVktswLD+cC2zba8ZF3Zhvger0pmSQaJv1kAkLQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5832

On 09.02.2022 14:36, Oleksandr Andrushchenko wrote:
> @@ -410,14 +428,37 @@ static void vpci_write_helper(const struct pci_dev *pdev,
>               r->private);
>  }
>  
> +static bool vpci_header_write_lock(const struct pci_dev *pdev,
> +                                   unsigned int start, unsigned int size)
> +{
> +    /*
> +     * Writing the command register and ROM BAR register may trigger
> +     * modify_bars to run which in turn may access multiple pdevs while
> +     * checking for the existing BAR's overlap. The overlapping check, if done
> +     * under the read lock, requires vpci->lock to be acquired on both devices
> +     * being compared, which may produce a deadlock. It is not possible to
> +     * upgrade read lock to write lock in such a case. So, in order to prevent
> +     * the deadlock, check which registers are going to be written and acquire
> +     * the lock in the appropriate mode from the beginning.
> +     */
> +    if ( !vpci_offset_cmp(start, size, PCI_COMMAND, 2) )
> +        return true;
> +
> +    if ( !vpci_offset_cmp(start, size, pdev->vpci->header.rom_reg, 4) )
> +        return true;
> +
> +    return false;
> +}

A function of this name gives (especially at the call site(s)) the
impression of acquiring a lock. Considering that of the prefixes
neither "vpci" nor "header" are really relevant here, may I suggest
to use need_write_lock()?

May I further suggest that you either split the comment or combine
the two if()-s (perhaps even straight into single return statement)?
Personally I'd prefer the single return statement approach here ...

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 14:26:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 14:26:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272340.467138 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJcIx-0002Ym-1w; Mon, 14 Feb 2022 14:26:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272340.467138; Mon, 14 Feb 2022 14:26:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJcIw-0002Yf-Uu; Mon, 14 Feb 2022 14:26:14 +0000
Received: by outflank-mailman (input) for mailman id 272340;
 Mon, 14 Feb 2022 14:26:13 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=YsDI=S5=epam.com=prvs=4044e07e7c=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nJcIv-0002Vp-8W
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 14:26:13 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0da54466-8da2-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 15:26:10 +0100 (CET)
Received: from pps.filterd (m0174679.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 21EENNuM001516;
 Mon, 14 Feb 2022 14:26:06 GMT
Received: from eur05-vi1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2168.outbound.protection.outlook.com [104.47.17.168])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e7rr1g0v4-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Mon, 14 Feb 2022 14:26:05 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by DB7PR03MB4604.eurprd03.prod.outlook.com (2603:10a6:10:14::23) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.18; Mon, 14 Feb
 2022 14:26:01 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::fc4d:4749:5d1:eb73]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::fc4d:4749:5d1:eb73%4]) with mapi id 15.20.4975.018; Mon, 14 Feb 2022
 14:26:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0da54466-8da2-11ec-b215-9bbe72dcb22c
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=WgQBvioz8Q9DoKPFITG/ZMC7J1hz0oxFTePwIegIGiGnmftn3h73pCSQEwJbYG+zWZ1QstuPdgDbhDPJmwa3IKpr1AoyZtgSPJI4eD0bYqHXT+E3w1uhMas9L962529/kI6Bklp51LnN7gajWpDZg7wB3woh0lgX7JSy10NwRqP9lt/3pvhFwC4DlIGqXeFqx9vJAjIUSOnGOMpfZKj5nm9R9K3iVN844c4uIiODmsgaqDItiCL8RJplWvnPwFDUpn7J+n3CBIJ9bb0XPZIifL1s2CceVdRCq9wDHOFmuo6FXCDTYiBaPDTmHn40v1ggkDX0XUS5pc1YzL7MUMO97Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=kglRE+Ltomp1uOqZzKumzA6w/VPuR7sg+jHMWcYKaDw=;
 b=bpAlwT5BC94oa3m2GtjuiVTZ7B+Fkgyqap+pJFB2DDtO2i6DE1BpvEH61GPI1wcDszvBXBwvSBENbWxDuzPWdn00e7/n3W2HoT/i2rbTkm4mdtf4LbSs5KG6GQaKqvOODoKhC5TL4SdV1MX8ChKxyb0tVhnv5cAmP4bsYHj7CduDNnTUcz0RuIpjFrconxkokfyowxmCV+Anlg3LdPTKXM596ZbZJn/jZ8ivC1eIwdK8Eg7odApyjEhOcuEY9CWANne5xIvHT/5FxL4GSX0hSfmhCBFDCRwNoNYzZiakGRLoex46VLQrjyA9Xj3iFy/V0IjMbEHicCFo1PV5/9x3qg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=kglRE+Ltomp1uOqZzKumzA6w/VPuR7sg+jHMWcYKaDw=;
 b=Wgw6LH8gE7dKMMUlJkg/Da3LUBnmH+zEzohwVeEk3mmm4n+IwPYy+7w6z+amtbxQ+nQAo8JSA0wzABvTy52d4ksVfdzmhk/FUXEYesO1yRF2HfOnXMB2TIgbVsd9R3vM/JO+bILGCFfmqzyp6KhdqzEjdb8jah3iPE/FxKRDSdu7QJ7X/EHp107lQHz2QeCMWk+h4ZauaYVYEF+q5lNXTu5lYcJYqTyvlfk95Zx1v/P/7UjZ213Wpi26nhCQdf/97p+ar7tWZqEA/WXJhUEJbFvj+RiG1LdR6OAqYVNLixfOiNO5mIYLKGTXmlAcMDvVIqnlFUQJiDy3l6nx2CMByg==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "roger.pau@citrix.com" <roger.pau@citrix.com>,
        "julien@xen.org"
	<julien@xen.org>,
        "sstabellini@kernel.org" <sstabellini@kernel.org>,
        Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH] vpci: introduce per-domain lock to protect vpci structure
Thread-Topic: [PATCH] vpci: introduce per-domain lock to protect vpci
 structure
Thread-Index: AQHYHboQT3cBWYI1/EGunE7hOwop6ayTIGYAgAABuQA=
Date: Mon, 14 Feb 2022 14:26:01 +0000
Message-ID: <40feb747-c459-2a2d-6ca1-ac9f8fea47e3@epam.com>
References: <20220209133627.959649-1-andr2000@gmail.com>
 <77f818a7-fe8a-20e5-3f1c-8fb7aef7984b@suse.com>
In-Reply-To: <77f818a7-fe8a-20e5-3f1c-8fb7aef7984b@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 63f77514-3d0c-4917-9200-08d9efc5ed0f
x-ms-traffictypediagnostic: DB7PR03MB4604:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <DB7PR03MB46045ABB215B1820A78311A6E7339@DB7PR03MB4604.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:6430;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 sC4Dez2JZSM8HeG7GZZKyXBkepfr4bK/qTqvT3pZySwv3aE5YRgc/DTRAAzGjeeyh08PPRGJFezzjb9phOkG31oW7aPYJB6MAYGdyRW+EFsKDg8HUu1xstFQRaCP/tjN74K55NKxogFSbFUZzu0Z9djkqIiuAIncaOMz+Qr5jV6Uz0gMeHICOjaGgvNJNduo2eBDCQytcMD+3d5JpQenIaHYRNZUyq1ehl1nekjIM0i+PlyNHHHUHO4iN1jhrSRBcUWPj+XvxULL4uPt7idftgryNEcJnkgYYdigzRWgN+RYJQrrGb0K4XmzxrpKNY0VDiPg9ORYEYCsLkBmURL29gZ4tIIZDKM9fZ9b/cMMYcDHb10b1R2zt02L84kU+DYIYl+sk9iqFZvV7k7Ld7dqVRKvU6v2umAeRZLGR756q3ZOuuWkWAvd8P5e/lugcLiamYbQ9NUsugSd0RKid/rKU5t7+rWS3LNoyhTaUNrLC5V51VBLplkmGxGazVXqdRCs5Wgwdb9dmO5CyP+/sA6ZDpbnKwVsStTKZ2HyEccaaeGQMTsl7jpo720pTR9693Rk+bUrQAG41TFEYkqAxXAWw4iFuzS2A0zZUTM0RV67RD29hDALKjmkKr6vCnuoVvTVRpa8vnYvLaE24caoGBiiffqbCydJpDLPVKdjE9rTrdqipcorv8EDqHshGic+PNQzk8EMv9mIOybtnkDWo7byNIs6pk5q+CaFBM7ZYIp0Bcf/LXquTMUa3CEy5Vxl1NAO
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66946007)(64756008)(66556008)(76116006)(66476007)(66446008)(38100700002)(6512007)(107886003)(31696002)(71200400001)(91956017)(5660300002)(8676002)(8936002)(6506007)(55236004)(53546011)(4326008)(122000001)(83380400001)(54906003)(2616005)(38070700005)(186003)(26005)(508600001)(86362001)(36756003)(2906002)(316002)(6486002)(6916009)(31686004)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?dEt6YVVGaXlkN2E2RGxyK0NwUWVRcFBnWmpDY3RIbFgxc0dYMU5VcUpCbk9h?=
 =?utf-8?B?SHIwQlFnRFZWeWZIaSsxbG1mUHpISXd2SGtDdkRBQjNHaUJaTWV6UmZvdWtJ?=
 =?utf-8?B?aEIxWHgrY1MzVFhuK25rWXdCKzNVU0FJTEIvZGd5MU5BMVh1dk1raEhsdHd4?=
 =?utf-8?B?TDZwaEpCVDVRamhJTk5OcVB1cnFSK2RqSEJJTEpnL01oTyt6NnM4dS85TFkw?=
 =?utf-8?B?c1RuRDJIWS9oTzR3TEV1eWZJYlRSME5zT0htbkJ4QkhucjA4Q1ZXZ3hkai9s?=
 =?utf-8?B?Z3dmSTJ3bzcya2xLQUV0UG5DV2I1LzgrM05tdUxEaUN4Um5zaFNVYmlqcVdN?=
 =?utf-8?B?bGlpRUlHMDVuWjN2VGJ2eEdaZjh3N3p1d3JnZ01WRHpCbmtQT09jbDFqaGlB?=
 =?utf-8?B?VVA5VTR0ZXZ5QTJRRUxaVTZPYVE5YjY2MCtNUzJ2dmQ2ZDczalV4V3FXbmUw?=
 =?utf-8?B?MW1wNXh3VmdLaTg5N2dwQjhnOXBkSmlqYXhRR0hvamR3cmgyWk9BemYwQzJu?=
 =?utf-8?B?a1p3a1lLNUI0Y1RXKzUxalZ3d2dwYWZkTUVSTTUvRW1BNVkxdVIrOEdQeGdk?=
 =?utf-8?B?dWVoSzBtVGpkSmhuRy8wSUFQRDdFbzU1bEVabDZoUi9OTis2MHNjUVhTZEZX?=
 =?utf-8?B?eEY1TUVHKzFyZHZXak9BeCt3YTFkMXc4NVlWUi9zcnZRTlE2MG00TnlNVllp?=
 =?utf-8?B?MWtZcGs2aWtRTit4dlpRcWswVExuWVNFUDdaRlAvMzVXb0NsNnl0cmIrZ3dX?=
 =?utf-8?B?N2sxSG9UQm8xVm9tQVRlM3FpUUhRdisrUGYvOHJNb3ZIeklEbGZ2M20rL1Bp?=
 =?utf-8?B?Y3hGVkhpNEFPbHZHN01qVkFYQU82a0w5V2lhWFpYOFpDYy9EMUJNMVl6VnVt?=
 =?utf-8?B?SWs5OHJWRUdaYjd0ZTdtWnpoQW5DMWdMYmJCRHpUb0c3d0E3TnljN09LTFNw?=
 =?utf-8?B?dnJWeGF5c2luczRaNmZCdGV4MEY5ZEY5UHZoTVd0WXZHSUpDZDUvQStobnlX?=
 =?utf-8?B?WXl6VnJsTGQrRkU4Y2NISVNtaGdncXF5R0RYSjZQVFFUWExmYUZJbEd3NmZF?=
 =?utf-8?B?Y1R6N0NMRitCWkZnaG9BTzJNNHNuMkpmcVlEeVZpR3cxcEZEak1qL1U2V0hW?=
 =?utf-8?B?dTZ0WE0yTzRxcm5DeFZTT2JjMTkxRm8waWdZenpUTGFsWHpCNjQ4WFluOEdu?=
 =?utf-8?B?b3huSmNBZ05LakQycEp3UmoyaGZCekpwdnpXNEU1dXoxK1JjTTVEWHN2OWFF?=
 =?utf-8?B?WW4vbVBaTXpVdzI4cWgySHBIUVFyMVVNVXpWb1NTdTNZUTJ2bFRQRFd6RHNC?=
 =?utf-8?B?QnZqa0N4QUpKS3FDY3dMM3hLZEQ0Vk9QT3Bjbi9ORkIxR0hqZUp3S0lhSWha?=
 =?utf-8?B?ZVNQS01rb2d4Nkk1TG51VW1ob0Zxd1liZkpVaHlXOUNyaHlubzZIWk8yY1Vq?=
 =?utf-8?B?OGpxSEs0RS9qVC9WZWQ5TElTL0JuTHgzcEVIRjNYRnFWSGY5VHFzc0lXMXA1?=
 =?utf-8?B?Rm9uRDFvYU1BcVVESWhlK3pJU3NSZWkwNWJCcjYyWk1qNnAxd3NZR1RsdGNs?=
 =?utf-8?B?S0poSWFYeDhDeVExNXM1eVVxVG5udHVzUHpiM2pHRGx6blZWazNYOGl3SXhT?=
 =?utf-8?B?MllIWC9JaitoS1h0V0c4MGR5R1QxeFVleGY4eHREdDdQYXE2M3YrWDAranZ0?=
 =?utf-8?B?OUNDSHQwNmhlRUdUMjUyR3M0YmZ4eTRXQlJPYmVsbE9yWlpGMjZuYURRT3pK?=
 =?utf-8?B?M3dDWEVkbnVaR0R4dVlHNG1mRy9iYmdvMVc4OWNTY2tNRWdpbEFKVkFDL3JM?=
 =?utf-8?B?ZU04bGQvTyt3Zk91NjZ4cmpVczdhcnFpT0JkOUQwd2h3YzN6ajdhcm1tdWN5?=
 =?utf-8?B?K1p3Z1liZUtUaEpKeXh5RkxoMXFxVktIYnpMd0tZejdWdG5UeEVlM2tPU05l?=
 =?utf-8?B?UDFvYXBDTDk5UnpHbEtDNnltNk5rKzZmTml5d0Z1L3NVMFpGNDViZnllTVhh?=
 =?utf-8?B?NVBXYWw5bHpFc3RWODloODUrWFhEcDd6a3hoZ21OcGdEaDRLajBzWm9PSGRo?=
 =?utf-8?B?a1doTmtpNmpyVTZ3b2VlVEVIb1A4WjVpRzlsVkpTV2gwTDZKYzUzQkZIQnBF?=
 =?utf-8?B?SzN3NTFhZG5WN0c5amxNNm1oWUlMVDVpOVZnVEtHczF1OG1qNllBWTFvQ2ZP?=
 =?utf-8?B?dmlpcEhFZDhmdDhtMFo1d0Y2Qkg4TkFOOFFtb296dWh4ZC9zTmt2U0lsYlFH?=
 =?utf-8?B?Z2pncUVpT0N3aWpYOFdFK1VSNTNCYzlmK3ZvV01EeUozc2Qva3lCbUM4OW9M?=
 =?utf-8?B?Y2ZDZnl2Y29EK0ZEamRuYlFaMjRMdjRCYWw3YUVCazBHUExjYUI5Zz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <EC18F2831D8136489A7238D8C1589C42@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 63f77514-3d0c-4917-9200-08d9efc5ed0f
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Feb 2022 14:26:01.3358
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: h53X5gssYExUlXuCBxgg6OPOm8KdLWXrrrufT2EzkLieIdzaOgudu53YeqsXxvkOtVOsTlcqup21FdxwCPkar9fifqBmLm7t0ploXss80SqfD1tZKf5osizgOXd7YDyW
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR03MB4604
X-Proofpoint-GUID: AYZxkk8Fk6jrxCbob78ESn48BnGrt57v
X-Proofpoint-ORIG-GUID: AYZxkk8Fk6jrxCbob78ESn48BnGrt57v
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-14_06,2022-02-14_03,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 malwarescore=0
 clxscore=1015 mlxscore=0 bulkscore=0 spamscore=0 impostorscore=0
 adultscore=0 suspectscore=0 priorityscore=1501 lowpriorityscore=0
 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202140088

DQoNCk9uIDE0LjAyLjIyIDE2OjE5LCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMDkuMDIuMjAy
MiAxNDozNiwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+PiBAQCAtNDEwLDE0ICs0
MjgsMzcgQEAgc3RhdGljIHZvaWQgdnBjaV93cml0ZV9oZWxwZXIoY29uc3Qgc3RydWN0IHBjaV9k
ZXYgKnBkZXYsDQo+PiAgICAgICAgICAgICAgICByLT5wcml2YXRlKTsNCj4+ICAgfQ0KPj4gICAN
Cj4+ICtzdGF0aWMgYm9vbCB2cGNpX2hlYWRlcl93cml0ZV9sb2NrKGNvbnN0IHN0cnVjdCBwY2lf
ZGV2ICpwZGV2LA0KPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWdu
ZWQgaW50IHN0YXJ0LCB1bnNpZ25lZCBpbnQgc2l6ZSkNCj4+ICt7DQo+PiArICAgIC8qDQo+PiAr
ICAgICAqIFdyaXRpbmcgdGhlIGNvbW1hbmQgcmVnaXN0ZXIgYW5kIFJPTSBCQVIgcmVnaXN0ZXIg
bWF5IHRyaWdnZXINCj4+ICsgICAgICogbW9kaWZ5X2JhcnMgdG8gcnVuIHdoaWNoIGluIHR1cm4g
bWF5IGFjY2VzcyBtdWx0aXBsZSBwZGV2cyB3aGlsZQ0KPj4gKyAgICAgKiBjaGVja2luZyBmb3Ig
dGhlIGV4aXN0aW5nIEJBUidzIG92ZXJsYXAuIFRoZSBvdmVybGFwcGluZyBjaGVjaywgaWYgZG9u
ZQ0KPj4gKyAgICAgKiB1bmRlciB0aGUgcmVhZCBsb2NrLCByZXF1aXJlcyB2cGNpLT5sb2NrIHRv
IGJlIGFjcXVpcmVkIG9uIGJvdGggZGV2aWNlcw0KPj4gKyAgICAgKiBiZWluZyBjb21wYXJlZCwg
d2hpY2ggbWF5IHByb2R1Y2UgYSBkZWFkbG9jay4gSXQgaXMgbm90IHBvc3NpYmxlIHRvDQo+PiAr
ICAgICAqIHVwZ3JhZGUgcmVhZCBsb2NrIHRvIHdyaXRlIGxvY2sgaW4gc3VjaCBhIGNhc2UuIFNv
LCBpbiBvcmRlciB0byBwcmV2ZW50DQo+PiArICAgICAqIHRoZSBkZWFkbG9jaywgY2hlY2sgd2hp
Y2ggcmVnaXN0ZXJzIGFyZSBnb2luZyB0byBiZSB3cml0dGVuIGFuZCBhY3F1aXJlDQo+PiArICAg
ICAqIHRoZSBsb2NrIGluIHRoZSBhcHByb3ByaWF0ZSBtb2RlIGZyb20gdGhlIGJlZ2lubmluZy4N
Cj4+ICsgICAgICovDQo+PiArICAgIGlmICggIXZwY2lfb2Zmc2V0X2NtcChzdGFydCwgc2l6ZSwg
UENJX0NPTU1BTkQsIDIpICkNCj4+ICsgICAgICAgIHJldHVybiB0cnVlOw0KPj4gKw0KPj4gKyAg
ICBpZiAoICF2cGNpX29mZnNldF9jbXAoc3RhcnQsIHNpemUsIHBkZXYtPnZwY2ktPmhlYWRlci5y
b21fcmVnLCA0KSApDQo+PiArICAgICAgICByZXR1cm4gdHJ1ZTsNCj4+ICsNCj4+ICsgICAgcmV0
dXJuIGZhbHNlOw0KPj4gK30NCj4gQSBmdW5jdGlvbiBvZiB0aGlzIG5hbWUgZ2l2ZXMgKGVzcGVj
aWFsbHkgYXQgdGhlIGNhbGwgc2l0ZShzKSkgdGhlDQo+IGltcHJlc3Npb24gb2YgYWNxdWlyaW5n
IGEgbG9jay4gQ29uc2lkZXJpbmcgdGhhdCBvZiB0aGUgcHJlZml4ZXMNCj4gbmVpdGhlciAidnBj
aSIgbm9yICJoZWFkZXIiIGFyZSByZWFsbHkgcmVsZXZhbnQgaGVyZSwgbWF5IEkgc3VnZ2VzdA0K
PiB0byB1c2UgbmVlZF93cml0ZV9sb2NrKCk/DQo+DQo+IE1heSBJIGZ1cnRoZXIgc3VnZ2VzdCB0
aGF0IHlvdSBlaXRoZXIgc3BsaXQgdGhlIGNvbW1lbnQgb3IgY29tYmluZQ0KPiB0aGUgdHdvIGlm
KCktcyAocGVyaGFwcyBldmVuIHN0cmFpZ2h0IGludG8gc2luZ2xlIHJldHVybiBzdGF0ZW1lbnQp
Pw0KPiBQZXJzb25hbGx5IEknZCBwcmVmZXIgdGhlIHNpbmdsZSByZXR1cm4gc3RhdGVtZW50IGFw
cHJvYWNoIGhlcmUgLi4uDQpUaGF0IHdhcyBhbHJlYWR5IHF1ZXN0aW9uZWQgYnkgUm9nZXIgYW5k
IG5vdyBpdCBsb29rcyBsaWtlOg0KDQpzdGF0aWMgYm9vbCBvdmVybGFwKHVuc2lnbmVkIGludCBy
MV9vZmZzZXQsIHVuc2lnbmVkIGludCByMV9zaXplLA0KIMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgIHVuc2lnbmVkIGludCByMl9vZmZzZXQsIHVuc2lnbmVkIGludCByMl9z
aXplKQ0Kew0KIMKgwqDCoCAvKiBSZXR1cm4gdHJ1ZSBpZiB0aGVyZSBpcyBhbiBvdmVybGFwLiAq
Lw0KIMKgwqDCoCByZXR1cm4gcjFfb2Zmc2V0IDwgcjJfb2Zmc2V0ICsgcjJfc2l6ZSAmJiByMl9v
ZmZzZXQgPCByMV9vZmZzZXQgKyByMV9zaXplOw0KfQ0KDQpib29sIHZwY2lfaGVhZGVyX3dyaXRl
X2xvY2soY29uc3Qgc3RydWN0IHBjaV9kZXYgKnBkZXYsDQogwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHVuc2lnbmVkIGludCBzdGFydCwgdW5z
aWduZWQgaW50IHNpemUpDQp7DQogwqDCoMKgIC8qDQogwqDCoMKgwqAgKiBXcml0aW5nIHRoZSBj
b21tYW5kIHJlZ2lzdGVyIGFuZCBST00gQkFSIHJlZ2lzdGVyIG1heSB0cmlnZ2VyDQogwqDCoMKg
wqAgKiBtb2RpZnlfYmFycyB0byBydW4gd2hpY2ggaW4gdHVybiBtYXkgYWNjZXNzIG11bHRpcGxl
IHBkZXZzIHdoaWxlDQogwqDCoMKgwqAgKiBjaGVja2luZyBmb3IgdGhlIGV4aXN0aW5nIEJBUidz
IG92ZXJsYXAuIFRoZSBvdmVybGFwcGluZyBjaGVjaywgaWYgZG9uZQ0KIMKgwqDCoMKgICogdW5k
ZXIgdGhlIHJlYWQgbG9jaywgcmVxdWlyZXMgdnBjaS0+bG9jayB0byBiZSBhY3F1aXJlZCBvbiBi
b3RoIGRldmljZXMNCiDCoMKgwqDCoCAqIGJlaW5nIGNvbXBhcmVkLCB3aGljaCBtYXkgcHJvZHVj
ZSBhIGRlYWRsb2NrLiBJdCBpcyBub3QgcG9zc2libGUgdG8NCiDCoMKgwqDCoCAqIHVwZ3JhZGUg
cmVhZCBsb2NrIHRvIHdyaXRlIGxvY2sgaW4gc3VjaCBhIGNhc2UuIFNvLCBpbiBvcmRlciB0byBw
cmV2ZW50DQogwqDCoMKgwqAgKiB0aGUgZGVhZGxvY2ssIGNoZWNrIHdoaWNoIHJlZ2lzdGVycyBh
cmUgZ29pbmcgdG8gYmUgd3JpdHRlbiBhbmQgYWNxdWlyZQ0KIMKgwqDCoMKgICogdGhlIGxvY2sg
aW4gdGhlIGFwcHJvcHJpYXRlIG1vZGUgZnJvbSB0aGUgYmVnaW5uaW5nLg0KIMKgwqDCoMKgICov
DQogwqDCoMKgIGlmICggb3ZlcmxhcChzdGFydCwgc2l6ZSwgUENJX0NPTU1BTkQsIDIpIHx8DQog
wqDCoMKgwqDCoMKgwqDCoCAocGRldi0+dnBjaS0+aGVhZGVyLnJvbV9yZWcgJiYNCiDCoMKgwqDC
oMKgwqDCoMKgwqAgb3ZlcmxhcChzdGFydCwgc2l6ZSwgcGRldi0+dnBjaS0+aGVhZGVyLnJvbV9y
ZWcsIDQpKSApDQogwqDCoMKgwqDCoMKgwqAgcmV0dXJuIHRydWU7DQoNCiDCoMKgwqAgcmV0dXJu
IGZhbHNlOw0KfQ0KDQp2cGNpX2hlYWRlcl93cml0ZV9sb2NrIG1vdmVkIHRvIGhlYWRlci5jIGFu
ZCBpcyBub3Qgc3RhdGljIGFueW1vcmUuDQpTbywgc2l0dGluZyBpbiBoZWFkZXIuYywgdGhlIG5h
bWUgc2VlbXMgdG8gYmUgYXBwcm9wcmlhdGUgbm93DQo+DQo+IEphbg0KPg0KVGhhbmsgeW91LA0K
T2xla3NhbmRy


From xen-devel-bounces@lists.xenproject.org Mon Feb 14 14:26:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 14:26:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272341.467149 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJcJ9-0002sC-A2; Mon, 14 Feb 2022 14:26:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272341.467149; Mon, 14 Feb 2022 14:26:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJcJ9-0002s4-73; Mon, 14 Feb 2022 14:26:27 +0000
Received: by outflank-mailman (input) for mailman id 272341;
 Mon, 14 Feb 2022 14:26:25 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qPn=S5=citrix.com=George.Dunlap@srs-se1.protection.inumbo.net>)
 id 1nJcJ7-0002Vp-Ix
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 14:26:25 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 156a2b21-8da2-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 15:26:24 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 156a2b21-8da2-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644848784;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:mime-version;
  bh=MumfUcd9JlwlU0tR66LjJ8OPcnkedrNNEXrmVPsYYjI=;
  b=AS1aWh0Ux+l4kALiZLQbuDV4NzLr/jl7HSTwlxjT6xxpYeD2B5SuVQEA
   w9tLxn9w5ciJe7XyE93AjcrcY+K+RsVm5dg72hhuzV3wmp8XOF6fzqIAK
   xFZ1y295u8/BkH83CR74j0EMEAaMrODWdFXk6NRxrFGOOZS1/57otSYVf
   A=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=hardfail (body hash did not verify [final]) header.i=@citrix.onmicrosoft.com
IronPort-SDR: 813hHJokbSRqHTfh8EeEciEKZA6EPn1V33YbsR1rGXlIfSf5Fa1CpwMFNLLyFyduRKAnlH25dw
 AddyKHruvnYjWs5Hjq4SQTybDsiNZRVMafAQF5bDomne0Wz/pVQBg37IlONdOJY850RaCBoeZq
 SajDUtuHmhn0J94eT34jVX4iiG1vwY4iBRSoX6fIgKVenhmIp9PRC6zRX8hPx66PS5jM/zznua
 JJm1E5hCl4r2hmNxH+oQNjzCVRfhFZREL97TeB2KOW5ZljCNoBNFfdqPJFikheDnhS9yyYBES1
 brEJvEfY5LPqi01GYb4OTrhQ
X-SBRS: 5.1
X-MesageID: 64561964
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:hSQgVa/DSkhzkHmbxHjHDrUDxXiTJUtcMsCJ2f8bNWPdYAuX7wSz/
 BJcAD7Ya7vPIDfrKpolWDmFhRsE656Ex9U3TlBv+Sg0Q38VopLPD42QfxurYHzPd8eSF044s
 J5ON4bOJZk/EnPVrBrzbbbrpyYliqjXTOehU7es1kydPeNBYH5JZUVLx75p6mIRveWEPu+th
 T/Ti5GBYwCug28tYzxNsq6N+R1l5Kn8s21I4FdjNKwVsQODxiUZVJ4RG/q8fiDyKmV28k9WZ
 AphIJWRpD6xE8IFU4v9+lrDn8ljrof6ZWBisFIPM0SZqkUE9nxaPpoTbqJGMx8N0mnRxbid9
 f0W3XCOYVZxVkHzsLx1vylwS0mS6oUfpdcriVDm2SCi5xWun0nEmp2CP2lvVWEswc5lAHkmy
 BAtAGtlgiZvJQ6B6OnTpuFE3qzPJSRwVW8VkikIITrxVZ7KTX1fKkljCBAxMDoY36hz8fjii
 8UxQxF3fgnlbiB1IgkHK74SruWFlmjAbGgNwL6VjfJfD2n7yQVw1P7mMcbPe8zMTsJQ9qqaj
 juYpSKjWEhcbYHBj2remp6vrrancSfTd48VDrK1sNJ3hlma3kQYCQEMVEv9qv684qK7c4wDd
 hJNq3RyxUQ03EGoCf/Cbi+bmXeJuzE9QtRbDMEC6SjYn8I45C7GXzNZH1atcucOq8seVTEsk
 FiTkLvBFTFp9bGYV3+Z3rOVti+pfzgYK3cYYi0JRhdD5MPsyKkRpB/SStdoEIauk8b4Xzr3x
 li3QDMW3utJy5RRjuPioA6B02nESoX1ohAdzC7PTH+A4z5DfNC1RKCE21r2/ed/M9PMJrWeh
 0Qsl8+b5eEIKJiCki2RXekAdI2UC+a53C702gA2QcR4n9i50zv6JN0LvmkiTKt8GptcIVfUj
 FnvVRS9DXO5FF+jdudJbo24EKzGJoCwRI2+Bpg4gjejC6WdlTNrHgkzPyZ8PEi3ySDAdJ3T3
 r/BL66R4Y4yU/gP8dZPb751PUUX7i4/33jPYpvw0g6q17GTDFbMF+tZbwveM71htfjeyOkwz
 zq4H5HUoyizrcWkOnWHmWLtBQxiwYcH6WDe9JUMK7/rzvtOE2A9Ef7BqY7NiKQ+95m5Ytzgp
 ynnMmcBkQKXrSSedW2iNyAyAJuyDM0XhS9qYkQR0aOAhiFLjXCHt/xEKfPavNAPqYRe8BKDZ
 6dZKpvQWqwVElwqOV01NPHAkWCrTzz27SqmNCu5ejkvOZlmQg3C4Nj/eQXzsiIJC0KKWQEW+
 dVMDyvXHsgOQRpMFsHTZK79xl+9pyFFyulzQ1HJMp9Yf0C1qNpmLCn4j/kWJcAQKEqcmmvGh
 ljOWRpI9/PQp4IV8cXSgfzWpYmeDOYjTFFRGHPW7OjqOHCCrHaj24JJTM2BYSvZCDHv4Kyna
 OgMl6P8PfQLkUxkqY15F7o3n6sy68G2/+1Rzxh+HWWNZFOuU+syLn6D1MhJl6tM2r4G5lfmB
 hPRooFXYOzbNtnkHVgdIBseQt6CjfxEyCPP6fkVIVnh4HMl9rSwTkgPbQKHjzZQLeUpPdp9k
 /shosMf9ye2lgEuboSdlilR+mmBci4AXqEgus1ICYPnkFN2mFRLYJiaAS7q+pCfLd5LNxByc
 DOTgaPDgZVax1bDLCVvRSScg7IFiMRcog1OwX8DO0+Ny4jMifIA1RFM9Sg6E1ZOxRJd3uMvY
 mVmOiWZ/0lVE+uEUCSbY12RJg==
IronPort-HdrOrdr: A9a23:2s7uIq+PVf6J4ske+X1uk+D9I+orL9Y04lQ7vn2ZLiYlCPBw9v
 re4cjzuiWE7wr5NEtQ/OxoW5PwIk80l6QFmLX5VI3KNGSL1wuVxa5ZnOnfKlbbakvDH4BmpM
 NdWpk7LJnVN3YSt62a3OHAeOxQuOVufMqT9JvjJyEHd3AQV4hQqzlCMEK6PyRNLmd7OaY=
X-IronPort-AV: E=Sophos;i="5.88,368,1635220800"; 
   d="asc'?scan'208";a="64561964"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=EW3d8mX1OVNzZRYpUtWP3x0FOvDVwFKWaorasqiwlTsIFDm+h8zwHq0vGzAEXVbGCP9Z+RuSif67YPukN+Z2CbgVUKF9ITPOsuvtd0RXTLrRsk7xsjhP36ygj+tW3xEKXYCg4wRMK7oC+UnL3YJlOAebSvd4vaWd/lz0u2apx2Uhi0zC3UPMk7xz+LSEqxEDaLW1UCj59TAULE/4wfwwGJztXIsx5alV7ktvEvC/Wpnn+do6HrtMnQRYQJJrTbEXFtY6FjGjVQTiBF2WcBrjIucxHc4bQEKU6e+Ee/1WqXBPjM2SnaycP+F+UM9k33YMWYTEXNmm9VZB+aEPTkzURg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=PLbeoozoNl88oHhTxblOUPVdiF+hItASCVrCU+5u7OI=;
 b=QdHBKXv8BaeVyfU9NIQvV3k8P1/tRRfxnzvZ+ntP78M3TQXkW/VjHez0ovBQ36iNpSiHJnwQq3KjLP/qiB5z4O025Nqy4cfLAsjx1fiaQe2sabdk6G6/QGRe0T+yxmNpz1JUSpDHLsWsbLcQs8vQ9MMrkg7K+7udFJiZrrOAVJwQHBBt0zVO7l48VIqbCT1nYt2Ek2GFQTY79BvjpnCNFoxbWpVcLHLBpjp9xwP32bb7Co/Rsv+P9HWZhqPQl1tk9WkIVbc33fxDT4Lu8ZQOwZkzs6fFUgTfLNo/lcYJ0Vj5j9wNeL1FFWeUVoCWiidjs/beJYYbXaQLI4pCLD429w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=PLbeoozoNl88oHhTxblOUPVdiF+hItASCVrCU+5u7OI=;
 b=F8dR05N+GC/5Rusoc+KGvx3JLGASd2xFXnbqvhITsD3tSyOI8DwaDop7jeauTkl/wcVqrmwJHKs2ZUjseUolr4kYfI9MGE8z2qa5n0U6+2Yu3e2QWhydFmOU8zI16arhBIZnibE1SieWeK8WwUkPBYieNGNHRhvnb+UnH1GJu0U=
From: George Dunlap <George.Dunlap@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Andrew
 Cooper" <Andrew.Cooper3@citrix.com>, Wei Liu <wl@xen.org>, Roger Pau Monne
	<roger.pau@citrix.com>
Subject: Re: [PATCH 10/16] x86/P2M: p2m_get_page_from_gfn() is HVM-only
Thread-Topic: [PATCH 10/16] x86/P2M: p2m_get_page_from_gfn() is HVM-only
Thread-Index: AQHXcbhq/OSzA1CQ40KMLkP1JktxTKyUejaA
Date: Mon, 14 Feb 2022 14:26:18 +0000
Message-ID: <95D687BA-6640-4786-8B73-3FBDF782401F@citrix.com>
References: <d1fd572d-5bfe-21d8-3b50-d9b0646ce2f0@suse.com>
 <06063948-65fb-1839-c10b-7cfb53d22b3b@suse.com>
In-Reply-To: <06063948-65fb-1839-c10b-7cfb53d22b3b@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3693.60.0.1.1)
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: f749098c-1316-4756-43b1-08d9efc5f746
x-ms-traffictypediagnostic: BN7PR03MB4449:EE_
x-microsoft-antispam-prvs: <BN7PR03MB44494C4E670FB8D962A1BF9899339@BN7PR03MB4449.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: GLYG9ixb38sJiprfcT0QyzILMsUp+oviEo8vFkvAXsf55suriTjeBquK2x7llLwLr1vBr/7rjecLEaiJCqy9dE0wKuAq09Z8lSt6aSLRa1GavKOnI/rfZjUvssJRFJ1sg5U2OI5XbD7agCp5OAhdqax/K10cgxXQbpO79AktR55Vezb6kLl14Ft0Xd+A1q8K1/0joYcbp0PCFZb3tpxvozuS+XBnK2hPXmyz4C5yl0ltjKF46CjEsjVJpRMFCwHrhq3l7K8lAMQRMpDFQiMknCJniALZ0AIA8eGj1K/tBpyhi9raAkRNCkIUrS+N+OmoJgD4GF3X3StQFM8f6sA8JaUNy/Et2iLqg/BdMs6brIU/aqVXNKt8iUSQbwmhtrQjiYfo20xl60XoVSjnsFSmlykVyvHFL6D8J+dGw6XZVMzFm0QMru9fMfPQCQL+t9KMW7JYCHRkkrJAnTgxjyknhRnP7+Z8qmLZQ2PHq8taRVYJ93ph1hgT0aqf7mPQJfuZffFvObxlkgZAlEEjLs5EqA0ysKitDjafuW5JFtJaV04/ZmwtYmHbA3Z/3pMJokW72VH7yXvUjqXqBupn9/33B3ImfBQTfRfjjcJAdNNyLPO3AfZtLB67bLXFG5ZXo2Zt7bPgk4eIHSUIsgO0zeEjcLFdBX122IsqekwlCo3tTyE5JPrgmIqUK4bzDy4H6fZcAjeXnZwhHqSLWHIgb0ZAmcD5viZTscquJUncUPyb6MAGqd5AZb89Vo4d4C0SP2RP
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(99936003)(82960400001)(508600001)(107886003)(2616005)(6506007)(71200400001)(6486002)(53546011)(6512007)(26005)(186003)(91956017)(4326008)(8676002)(86362001)(66946007)(64756008)(66446008)(66476007)(76116006)(4744005)(66556008)(8936002)(5660300002)(33656002)(2906002)(36756003)(38070700005)(316002)(122000001)(54906003)(6916009)(38100700002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?WebAp/Ic+ucju928QHajo89M1avXMdSMl1kD2H9Co8fs8B5kogb0H0PZ1mGQ?=
 =?us-ascii?Q?QsqMm+ujaBYhSoZJE/Z1Xr29L4smUVKuHkFUWUVdAOrrHtKqyBnlgiPbYU+n?=
 =?us-ascii?Q?kBEGtbfxM8udELLYKBrHDSlhG3oPA339wDSt1uekc6UZfaHojg94YN0G29uI?=
 =?us-ascii?Q?x7tm4UP1ZSVEEDjU06NLvZCaIjTfJ5txN8vzj4FGX+aiAj/xvp/jXA6ntDuL?=
 =?us-ascii?Q?k1y6qo1cvdwy7eB7gaNufTikpekq+lOWfzcNNwpisIubs3yPR1sEwLREsb5H?=
 =?us-ascii?Q?Q9ILkt5qTY6bt//qjl3/derTZV/g75atCJRmsM+xarQVK3BYtIfU2G2oTyie?=
 =?us-ascii?Q?W89xog0Gw7ctOodP8Rt5pIz3xKS6NNR6H3zP4T+Sh49/fhisv3i1g8GFmXb1?=
 =?us-ascii?Q?l/RYqMer7gjL/eXI6tGrfavkTBk6JGjfgRpPS+G2MxApAlwOnDsVH06kpG4i?=
 =?us-ascii?Q?d746iEWqEgMNLXr+rNPYxmGKVOjJjmfDffe5UC8v90b7e9tH7loBYMh6oqX4?=
 =?us-ascii?Q?rlYI3J2abBUCI8EeVkdYUNK/pPNg6508PSyfxU9vEpfBF7m0Rwx2hYaYi46V?=
 =?us-ascii?Q?syL1nkNfNIMdiRCusf0obcUwyp5Pb/gE+gLdkUcPzo/mlHvIqrFZQplQF8RY?=
 =?us-ascii?Q?pr5FBfiy1rBzio856lnd795ftHMNjIlyaxzXNVOQw3xpvrSrYpaoFStUQUX+?=
 =?us-ascii?Q?TWEq6HoNfh13pzSbIdxkw0mWl1u/47DPp0KowKP1AziPMadbjmc0P1rTomp2?=
 =?us-ascii?Q?IrwwDykxmYNLmsHBLVb13hvCVDcqiMJ+UMusE0P/4nvip6IsUh66o0YXKrAq?=
 =?us-ascii?Q?rhTIHv7GBAVywW4QqxMP1T7Wgu8vAxE/juZjd8rjhek4CA4SAw1cUF5z/3eO?=
 =?us-ascii?Q?T/BCoEgTOnKhbu1TH2Wtb+Fn7iGnIf7rwsG1hqM+qSityyf7Wu5e8wFL7ITr?=
 =?us-ascii?Q?mqxw6NCJyzJ0I4tnsScO28LcsHhJOop7vpzjrW7mIGcImrK+BJmdVrcZfoFz?=
 =?us-ascii?Q?OicxX0P5GwBFxTd3qmFmUlLRGdIuDx9TXB61uu60sHXAgePjYWBltXPzlEzm?=
 =?us-ascii?Q?pYDUIZBanj9g1AswkTfDvQqOHbpwH9Mvt6Qk5J/5vFRql5QOrYql7BeOO0jc?=
 =?us-ascii?Q?KSi8eJ6sFt6kYdtZ3CFAg//zx2hyAR4l329kKPO8KwUZFn/zMT1wAYpRxkDZ?=
 =?us-ascii?Q?e+V5jXDS507vb7trzJgguRcFi3JxdCG1GYpZee7WEQlRQzI2tamG48EixDXO?=
 =?us-ascii?Q?KO4pkTAujyBwBIL3PVyvR1cLPTfcb7XaE1ZrODQQot48sn5Q/ba4R1bK6jhh?=
 =?us-ascii?Q?ykQlondkdWMR7ldaxUci399uT2a/AhE5r6aoXXwMst4Dl49ExPbKhhzm7E19?=
 =?us-ascii?Q?Y0Ae75wx55hWXXtgrO5+8fW8sxNTSJk1OOKUgB4VhhuuQeNi1Zd8gpWnYCUE?=
 =?us-ascii?Q?cxL3rqBghJ/jS5VB/Eo9cAN6xwe4VD2NtNIZnIWlD0dCtoRPQxxFHuyxRG3K?=
 =?us-ascii?Q?HsH5CSfVlov3CwF6xLLvnQyHOCNY/lIwCaN9xshdfSoEdI/bnyY1SLEeu/ps?=
 =?us-ascii?Q?90EZ7/lhEjoB62x4YoSeY8uuSLkp25Tq7j9Cve0Be95evI2wSuUDI4NZmMOj?=
 =?us-ascii?Q?8LlFQb4Tiw2/AC1RiwYzpp1wE/JxpyGWYjxWGA9yZMZiRhXowWMKow3sWpLb?=
 =?us-ascii?Q?2bOk2l5dMfcOfZjnlAtfuo7QMkQ=3D?=
Content-Type: multipart/signed;
	boundary="Apple-Mail=_7CC07E38-E0BB-4FC2-BC04-B3245B5D2DC7";
	protocol="application/pgp-signature";
	micalg=pgp-sha512
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f749098c-1316-4756-43b1-08d9efc5f746
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Feb 2022 14:26:18.4715
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: OYBGw+9gmCMB7v/rbMDrsy+8Hv4396gSxd9Zc+/5gsb2Zf0LSm7ifIIwqLNO3QyPrmdv+m3ROm1gOrLKs16J602gJFwCDtN51eVS53Q0DoE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB4449
X-OriginatorOrg: citrix.com

--Apple-Mail=_7CC07E38-E0BB-4FC2-BC04-B3245B5D2DC7
Content-Transfer-Encoding: 7bit
Content-Type: text/plain;
	charset=us-ascii



> On Jul 5, 2021, at 5:10 PM, Jan Beulich <JBeulich@suse.com> wrote:
> 
> This function is the wrong layer to go through for PV guests. It happens
> to work, but produces results which aren't fully consistent with
> get_page_from_gfn(). The latter function, however, cannot be used in
> map_domain_gfn() as it may not be the host P2M we mean to act on.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: George Dunlap <george.dunlap@citrix.com>


--Apple-Mail=_7CC07E38-E0BB-4FC2-BC04-B3245B5D2DC7
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="signature.asc"
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEj3+7SZ4EDefWZFyCshXHp8eEG+0FAmIKZokACgkQshXHp8eE
G+1uJAgAw3WNR8HQG8w8ST9ICV5+Lz/+Ld47XFt+hOP2JvK8o+mM10onCQ7Soq8h
qqwfGKVcRBzytDgu+N22E0HsrSQa8fx5KQnkE72UQB2hR57OA79NIJC34a9Xv3dB
me/ta7Zgo1goG4Di0IhM7rW/zpVH13AkNOtyMrBKBeKxmTusW34fvgw7Li0P/KZH
TnTCy+fjH7QcPoHxqPW7Y6IMxPfldrfSTvSgwJIGiCq0CHqsxciT6czH3WCSTqaY
7Ci/3S/jC1gMiq4DNM0P7sUqGNUazvU2/MPv2ARUI3GV49/iEr1JuS0HeawvlWbu
oRoeaszb/NPhWtGVukk++FdDp56W+A==
=7ZYW
-----END PGP SIGNATURE-----

--Apple-Mail=_7CC07E38-E0BB-4FC2-BC04-B3245B5D2DC7--


From xen-devel-bounces@lists.xenproject.org Mon Feb 14 14:29:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 14:29:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272353.467159 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJcLy-0003jl-Q1; Mon, 14 Feb 2022 14:29:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272353.467159; Mon, 14 Feb 2022 14:29:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJcLy-0003je-N1; Mon, 14 Feb 2022 14:29:22 +0000
Received: by outflank-mailman (input) for mailman id 272353;
 Mon, 14 Feb 2022 14:29:21 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KkXt=S5=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nJcLx-0003jW-0k
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 14:29:21 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7f0660d5-8da2-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 15:29:19 +0100 (CET)
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur02lp2050.outbound.protection.outlook.com [104.47.5.50]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-8-VfYtNkhjNmSGPpGLGfsHsA-1; Mon, 14 Feb 2022 15:29:18 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM0PR04MB5459.eurprd04.prod.outlook.com (2603:10a6:208:116::24)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.18; Mon, 14 Feb
 2022 14:29:16 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4975.015; Mon, 14 Feb 2022
 14:29:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7f0660d5-8da2-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644848959;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=X6c2VvmCjoUnDipzgF/yaesQiubn3pS+lmse4WPKWYc=;
	b=bVTFFhQWRevl42fInWipes0nkQq5dZH55a7lborteLMi66kh6oHp5RFkGz3uJdzpbK0wNz
	SnndXa+fbME3ECTP2k99qhdMP09z8k+6fv3wL0uDWFvcEQBr3KhMyRIKb9aVwT5aBYECyI
	58G0n0SidjHPaXBOYIEFNYVttwtapc4=
X-MC-Unique: VfYtNkhjNmSGPpGLGfsHsA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=asbXfbwqwnNaR9QDxNPrtDzF1TLBrXk5UrYpE01kO5OKkSuDgi392zsNWcbvz8HvPrDv/rOgj37Zr0061Z/yKh7Qvknl0Xdce313rAi9Lzisf6MnlbOEWykLDpXbuaqd3sb66Zjqy6z2xHufxnuT1Ba/NWat+tPkh9DWoUmSSnRMYMAIF8nc6QmRwUyQoIyq6ssLqsWrkwlQdwvhZMl2ZKO8M1WqSYUfinupOG1Pfe61jFKK2HSYdULYi1cMTCEvfb7JnYvhnqfbAZ3Apr520Q5m5Lyci+vylP01NlIz1bmT6gpW0L7pIpXMHooRAzTeXRwdHPyNQV35hMQrmJTSPA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=0DhAdFIRQ7//ueyN6KriKfgTlylAZvihmnGTOEt9kgU=;
 b=HJkneKkhVppQJm0BZ63/R3F55vpd9i6kGyGZJ3ekE7LTdcbDj/saRYM2acWWVcke3NVPP0a3AwTeMlS2zYje/VpacAev9/y5oh3nzqztgtbLbd5InDIgiP/4okDYOS/DHr1flfkxnP6zMHwBYDHr5j15K6sTv9Ul/c5Db45XZOj0R6XiQWBSJQq/E0Q3jLs5oap5fzWEZ0mFDthKb6/qvQxsaeZ9+cG/SngrE3YcMEgS6vc+GAx4pGhB19TsbtSrt2Wv0MQwvVdoPuImbSIBIJdTBbDuy0T92+WA1ijOVjmjyBxy9gKzfbDB1C/mKIFZ+X3ZRJNdwxcCYB6224lKAw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <09069049-9b9b-2f74-eca3-fd17a766ba15@suse.com>
Date: Mon, 14 Feb 2022 15:29:14 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH v2 2/2] x86/xen: Allow per-domain usage of hardware
 virtualized APIC
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Jane Malalane <jane.malalane@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Christian Lindig <christian.lindig@citrix.com>, David Scott
 <dave@recoil.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20220207182101.31941-1-jane.malalane@citrix.com>
 <20220207182101.31941-3-jane.malalane@citrix.com>
 <YgKXrZ/U2XuECG3d@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YgKXrZ/U2XuECG3d@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0265.eurprd06.prod.outlook.com
 (2603:10a6:20b:45f::34) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: df00c56e-38e1-4ac6-f95b-08d9efc6613d
X-MS-TrafficTypeDiagnostic: AM0PR04MB5459:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB5459CF15EFC9E12E251D6CF1B3339@AM0PR04MB5459.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	AEnaC7hxGIyTc8H7uF+W3Bue3lvLgG2tV64g8fvO8ThjAV9UPfBQjwxTokGsaKJmCbgBjARNk7EriBwnbrCNuikyTPGM741Z+ZRxRKTGow7NQvtVC1pEDbKkEaAZXgeMZedDVUgjMh1Mk/hwvI5OxwumPFRmBeJCZsYy9PNDzobk8mF4dHGAWclsMVzMBb6rpAhp63kIyseLwAojjXvCswnH3EafGG64peW/OpCnEW4fZypMjLJrJ75UuzGggRowDj90M4y4LJds6DP6FvAR/D06McwcV8Wq8AGYwSKhyhpkjqziNDgoWV5pB192xzoEctIX4joNOLx3qkV75MbddKbzffuipZ1tcO2289wm+d0XiVjNk3/nnA2HE7RjW2rzvKoMrclhkI6w1ODqyqCpOo6UD0S4etspnnJ84rAt7xDCaLE5lcCNIOtcXWOnDxwTvNGnqqaJkJ2K/1E7rl0aNjfaR9LBQqaZIHhX1zUXyqOKWfjsSC4+SAmFdB84IqzIsEFtCyXowzcBDzbIW4/iAAVWl+gcdmIlRMHLLCgIbCxpLy2qNeFIUSUJIck5o817OM8n9jM1oLWi5dEhazjpx3UPIWMVZQL7L9kFwfZ/wbdyXX108lVPrexcNtmXpwV7C9yAfnZTdPJLAaQFp8pKLtZkBNtePSeY9X3H95VT/36EsMepkWEYyYFlr2a2VtGg1BORbuxYkYRtsJrD00SRFkU2fqily2OS4oqRuxIggWA=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(83380400001)(66946007)(31696002)(38100700002)(86362001)(66476007)(66556008)(8936002)(8676002)(4326008)(508600001)(6512007)(6486002)(6506007)(53546011)(2616005)(26005)(186003)(316002)(5660300002)(7416002)(31686004)(110136005)(2906002)(54906003)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?eeZcMyKcywstsiH6jWJPZuqCgl25+T05ZScnODYJykJcFtoFQ6bzbUMrAIJe?=
 =?us-ascii?Q?1vR/IQ6Q1rolhlmMyV1wEe2AA9VOLHHzseHT5JNqylHDppnZTFaJD9Z2w7ox?=
 =?us-ascii?Q?vmRnsyFBoLONYuAuPZ2bwTChFTIuszuWa3bMJQYtG8rRO5iONJkmBa1pi91B?=
 =?us-ascii?Q?EcF7EpBtqcCx1rd8vFag/km0cl9EcBDTkVLFywUSzuqI68/VH/wGBhUqicKg?=
 =?us-ascii?Q?3csTtQBks9z2BgLuC/iyymOlADCYJgQI1bVesbO4EA8Ot2AdLpnZbmsKqthg?=
 =?us-ascii?Q?oXrKNUW9Fh/OW+/o8CZWitjhf33hmNuPOXIe6T5I7IqDWwdA6xLAuZ7AfY+r?=
 =?us-ascii?Q?LTMXdc+JX4eSAgRf9JhQTqAscW+UsrpCXLwdXl20O6RXRqNWjPHGIE7xVBjA?=
 =?us-ascii?Q?3OEbhDxEPBG1gnshTzLkgJcaVtu7FryTfeay+K9Sh6tHG+QlPhCRJDkQE2uh?=
 =?us-ascii?Q?VzRYikUCVmYvcHxncpGSf5E0ZMn2OFcL3V7iI88vF5bSAyGNmnAAoFfX1i1B?=
 =?us-ascii?Q?7S4jGrumFgQdpbDUplTuF4aYmQ9tco1saXMOtd3FOQUlkYAwZ/EyohWb/kNb?=
 =?us-ascii?Q?coQFkSAobTIS5rmWFjfRJora45BboAysnRDIrDWKLlYwLUQ9pJb+OzHFrPR+?=
 =?us-ascii?Q?eRj/qP4DWL3cZBO/g/GGdLn77LmNAFGL1XxBN2OMSmhUXoaQjnH6BY9pWXPI?=
 =?us-ascii?Q?6PTOK5UlYuiWes+VlVwGTpOMHdtiENKzyFog7zMbeavG1m1E17RxYzKBRf4e?=
 =?us-ascii?Q?12GHTSZCRUqCQQHZ8SQmCyPtBLTwqpF+Y2xvrsVJPstq7i2LqBdwLxQlbtCs?=
 =?us-ascii?Q?KU4Fa4QZ630eVT1YX6O56vnYk2uZ1zplDFYM07G8Sti9f5laW2pvO8+yg6Ja?=
 =?us-ascii?Q?PmNV9N9Xft6BxeFyrW5jVvHnwo3qTF5pg5GhpNmtZPwaOWY/1A+x2PO2ANly?=
 =?us-ascii?Q?K98Ur4dEYGGShBYtmJ8gaDtLx2LIHXg7eNRaYyQfPcF7O+wNvPCFKLownbKK?=
 =?us-ascii?Q?OGefDeJI5p/IDSOsUoljfigsX8h7/2L8wUxmG3DZOOspJtBQS/Jlov5QWpMe?=
 =?us-ascii?Q?OguYtiHBu0V8jlc4cBwuBV2EkeUP6jZJ4EJWbgxq0PtlDzwlNzkmqTOnsUV5?=
 =?us-ascii?Q?oO/dpks1EI9UcdhiU8p0Nc+t2EUy3hx2sSTFF18B69T3/X4WuuePzamXM47k?=
 =?us-ascii?Q?w4ZHL3be6jAML/ejmEtQKRp6iFOdp/r/ljJFQICv+jPWQ7S3xMBUjAsfyvLY?=
 =?us-ascii?Q?L5x9D1UkjfEJDbf+6XdIN/dIyWJGWPFZpqYf7mJ5+v+MwnXcBVA3ZRB+fZ/u?=
 =?us-ascii?Q?z50x+qrhSUnq1djcqs+C91Wmq4wskx9YrjD/XFY0cArnaNWANchb16H8Wwmm?=
 =?us-ascii?Q?HYGMwC10gTREJVZzs2p0LjLElxkTSUleyv9L73qWAELuWyhdAc1yEPVZLfHp?=
 =?us-ascii?Q?QQoOsst+HVYW2OiZClBHlQz5d7uCvTPdxUJU4HxfRyGfldAkbMoxcG6VZJ4u?=
 =?us-ascii?Q?HfB2sHYie7DAhirzU2zyB5icRd1Mjr6+FN5o0nUNO+o0enxV8Fh2ffr0Pg/p?=
 =?us-ascii?Q?GWhk6y8cfr9BKx5loSaXtI8SVImI5KCe3q1Mjv8JfVC3kp36f7fdF9rJ6qzH?=
 =?us-ascii?Q?R9snaQp36+3/ItTnrmgOaZY=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: df00c56e-38e1-4ac6-f95b-08d9efc6613d
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2022 14:29:16.5212
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /+DI/x2cqabCaEOoMz9kf3CLfnTK0+nSntQlklvdZUpTuYdLc9lNyUUKJllfX84ZGBHPPSnjpeCEogEjPNWfwg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5459

On 08.02.2022 17:17, Roger Pau Monn=C3=A9 wrote:
> On Mon, Feb 07, 2022 at 06:21:01PM +0000, Jane Malalane wrote:
>> --- a/xen/arch/x86/traps.c
>> +++ b/xen/arch/x86/traps.c
>> @@ -1115,7 +1115,8 @@ void cpuid_hypervisor_leaves(const struct vcpu *v,=
 uint32_t leaf,
>>          if ( !is_hvm_domain(d) || subleaf !=3D 0 )
>>              break;
>> =20
>> -        if ( cpu_has_vmx_apic_reg_virt )
>> +        if ( cpu_has_vmx_apic_reg_virt &&
>=20
> You can drop the cpu_has_vmx_apic_reg_virt check here, if
> cpu_has_vmx_apic_reg_virt is false assisted_xapic won't be set to true.

Along these lines ...

>> +             v->domain->arch.hvm.assisted_xapic )
>>              res->a |=3D XEN_HVM_CPUID_APIC_ACCESS_VIRT;
>> =20
>>          /*
>> @@ -1124,9 +1125,8 @@ void cpuid_hypervisor_leaves(const struct vcpu *v,=
 uint32_t leaf,
>>           * and wrmsr in the guest will run without VMEXITs (see
>>           * vmx_vlapic_msr_changed()).
>>           */
>> -        if ( cpu_has_vmx_virtualize_x2apic_mode &&
>> -             cpu_has_vmx_apic_reg_virt &&
>> -             cpu_has_vmx_virtual_intr_delivery )
>> +        if ( (cpu_has_vmx_apic_reg_virt && cpu_has_vmx_virtual_intr_del=
ivery) &&
>                 ^ unneeded parentheses

... this also wants simplifying to just v->domain->arch.hvm.assisted_x2apic=
:
The apparently stray parentheses were, I think, added in reply to me pointi=
ng
out that the check here isn't in line with that put in place by patch 1 in
vmx_init_vmcs_config(). I.e. the inner && really was meant to be || as it
looks. Yet once the two are in line, the same simplification as above is
possible.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 14:31:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 14:31:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272362.467171 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJcNz-0005A1-A3; Mon, 14 Feb 2022 14:31:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272362.467171; Mon, 14 Feb 2022 14:31:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJcNz-00059u-6w; Mon, 14 Feb 2022 14:31:27 +0000
Received: by outflank-mailman (input) for mailman id 272362;
 Mon, 14 Feb 2022 14:31:26 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KkXt=S5=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nJcNy-00059e-1q
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 14:31:26 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c9591d17-8da2-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 15:31:24 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2057.outbound.protection.outlook.com [104.47.14.57]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-5-XS9JKTohNHygPYYJahPdEw-1; Mon, 14 Feb 2022 15:31:23 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by GV1PR04MB9199.eurprd04.prod.outlook.com (2603:10a6:150:2a::9) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.18; Mon, 14 Feb
 2022 14:31:20 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4975.015; Mon, 14 Feb 2022
 14:31:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c9591d17-8da2-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644849084;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=g49lSleL0N+LCM5o0WC5yqxYazkTD0zCKYRZ6P4Zzrg=;
	b=lpTAFbJQDYUxvyWbVZwZIKhC0duHDLbezUqzi0FwFCaFHJlB+0V3Kv5oSeaf5mK9AkHbw+
	hEG9j5kUCbSYqU1XNMEhmSZP+sc87dzYj5c5LWf2Fz2RelBUAfoUui71gNVZh+onBtyaum
	2qvvY4VNQ2WaBYGLSSSS2idee6cKTjU=
X-MC-Unique: XS9JKTohNHygPYYJahPdEw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=K/xUSclmp4gqg1inHyyZSSxRQ3C/mfSwAsPt8MVNj48ZR78HHpy8aiy6CRHICsP6rZ176saKbTsw7tVljGnCpbkJIGrtCZeqLq0Lj6+QoTvoqPmN2gIK3Dxh8pF3GJE8qSXGe86mWDKEAe/pWf0i66kXjXfGeZlTVYI8CvCh2R+Rr16w3vXlN4br1eLhPaGeUItcWTzht/hEjE2+VoaFhORQPNcubEFc88xqd4Ol29R1zqc+kusTGXlEAmJuQ/ortYz45AszfZFFky8YofTP0r3vY2idf+hsdYRdYnTvlgdgOAYOjzgoppAkhj8JmsyJXdWzo4HlGaTq8cHOQOV+Ug==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=9bX+Bm6Kq+UGImw8PzonFban3IJbCKjlxzEsURkdbNU=;
 b=WB2ahwc/jOwxo37OlT4Q0T4bOVq/ScBN0m5+hCFDSK3/8lluugCc0JyGSNveGLI22JK/nkCF08UILsDRefJW6k5wJps6Wh/tIXG9k8DDPJapjOE5RGLsqkzII2p5Mnvh987l5lNH0qnbxGkKJpempJdMJV3n5baB303N+jhNeNY0to1ukdbBfxApcJVCZQHIqe1qj68RQjgYEp8YW/sBegHI3Fi/9MqCNPN2EIVZqkjeDUDvisFyngtMi+s/5RcKqxk6wu06ebm9odfrAJ5rWRKZY5PFU/cjDLNp3REE9a5IvhomB3UaOW6u9LqQorRhD+HgsTKATB1mvHw9dD1wIQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <7a9c9ed1-3c10-247d-ee7b-c2f47dee1f38@suse.com>
Date: Mon, 14 Feb 2022 15:31:18 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH] vpci: introduce per-domain lock to protect vpci structure
Content-Language: en-US
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: "roger.pau@citrix.com" <roger.pau@citrix.com>,
 "julien@xen.org" <julien@xen.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Artem Mygaiev <Artem_Mygaiev@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <20220209133627.959649-1-andr2000@gmail.com>
 <77f818a7-fe8a-20e5-3f1c-8fb7aef7984b@suse.com>
 <40feb747-c459-2a2d-6ca1-ac9f8fea47e3@epam.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <40feb747-c459-2a2d-6ca1-ac9f8fea47e3@epam.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0136.eurprd06.prod.outlook.com
 (2603:10a6:20b:467::28) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: cab48b42-1145-4246-00ad-08d9efc6ab34
X-MS-TrafficTypeDiagnostic: GV1PR04MB9199:EE_
X-Microsoft-Antispam-PRVS:
	<GV1PR04MB919994468F972BAF1772C507B3339@GV1PR04MB9199.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6108;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	gSjG3Jw3yh+LxRp+g86S5e0VzPpL4Kv02CPm1wTE6K0vw2tlICEmvt+flrWtrBjMNfzpKcAp61wVyKCqiDORNPbFzhEeQEJBQgg0xpPeNI0aRS4YXcOBekfJv922jSq7/IY1xjVEhuGUVh4M4IL3UW8moeLLrQqPuMUjSfNyzVFlvQI6JGszwc63G1EKBY/0EwqhrfczGXQ/ocSAA+F1DyxVbBw04UPKGXCGGCy4I0aYATMb8sVY++1ps1dFkf+cKpN2HKaVfsy74AVanIAwW5vrrkCWsLHpVkaMMoCehJBZY2IGIumrYojU2snVJRwzmvfieJK/p/ghEILg5BFSdxr++e0bro/pWqnwhakzJXWjaSzgx37eHhrHSkPdgS7Dd6nUgBHcuT0bgU67aPpSSRxwBrkKcLgg8XPCvDS5ZyzyhmmTatCKtm3SjVl17Fd74zp4y0lFPWzrGrqgf9vGpE7lkA3QOXgHbtFZdOoCYTDTVx2adgUlNbGdZaryr0WAXZZuZfoTB+qui5lRQNO5erdTbvVY7PiBhZ+voYjisaromP3yKFS02sHy8QuGetL/f9DvWrGyAY+VtrmYdf4YLkO3ljgCeop5JIqJ9+xMzobYjgVljw847+1dt5qHTjJ5CScWLLZwsFfEzWh1i4Eyj6S7qW9uv+EVI3T8/gs+1V+8LfdWTucJgf2frNFZ2xSunRHPCi4cRDZB2DfCbnAITZlzxzw5X3LCI7xUBAV6ipw=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(31696002)(316002)(86362001)(6916009)(83380400001)(54906003)(66556008)(66946007)(8676002)(186003)(26005)(4326008)(66476007)(53546011)(2906002)(38100700002)(31686004)(6486002)(6506007)(7416002)(5660300002)(8936002)(2616005)(508600001)(6512007)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?GSYKQ4CiLv7mcp9Bc7Ih/D+SAoS5CqdRs3z7G8/8K+362kwyKkISjVeoO0TT?=
 =?us-ascii?Q?dJI1nU8lfNkVyr385jXuhMJp9bTMWw6JNdA7PftCpXCsXZBISKQbDlBAa/e9?=
 =?us-ascii?Q?xxiEaMTyOkOYYes+0CR5b4+TedBSOcEsW4/ZFm9qpF+rV6NuCBMLvoSeu/Zf?=
 =?us-ascii?Q?n39o52T20GbgXBUUd8vsrVJEjX6+lDNyfM3Eww6vozLxHKvLh8v8PWeI21uZ?=
 =?us-ascii?Q?o0I9sxEeh5pT+ZofNeeeLV4hg7Cu/q+tMAT7FoN/Au/1h9cmtxgkMRaTNfNM?=
 =?us-ascii?Q?WzFF7SZJvSi0DLAaFLawdgtzxTjNwweLzR2Qolj8dtLZih29el/xRloEvD92?=
 =?us-ascii?Q?9c/Gv7LPHiKbFQXy7HINl9qtYS0OMNfbWJfU3wSy9LWd98Qu5L8wW2GA7ZnQ?=
 =?us-ascii?Q?+2uqxDmSBpN5KDyRM15aPZ4CuzmSoA8zp56q8oOmvEXEafbs7qduSuFpjQK/?=
 =?us-ascii?Q?7glsCgrlY/psdQAn0xGBl8Hf0x9FTdiTkkjE80uoYsCfit2Bdqfyu5V9LkM/?=
 =?us-ascii?Q?R4cvm9uHr/SCZR6u2u9JroO2iKqf5hKhfSqSUkdbouq/BKVfM4EA8B5d1/U3?=
 =?us-ascii?Q?pQihO+cDxl34l5URl6FjrHTAgU4ZFwg5a3gTxQ2n2/ywYBoQmTFeuxGVa4FD?=
 =?us-ascii?Q?or5cHMGVZawC44z+x35i5VDDuUDEPBDE++vazJtiqJ8SEvxQzC/9Lm2+ty6j?=
 =?us-ascii?Q?QKVxhN2D4mDfHbAO/ouNjpsa8R5iwh26MQbUA+PoZqpbMB8a9vlybbrNGHTa?=
 =?us-ascii?Q?2sci1WnQ1G+Bv8tcRbncA2jghWc5CqExQZhtHEk1pSgrj9KVTXJ+4D7uf8o5?=
 =?us-ascii?Q?96P+xVISUlAV0kkpdFxRYqJTOGIka7V1N/ex4HELSfk2q6+EF0NBCGepTAGQ?=
 =?us-ascii?Q?wlpbz0TVCXHmC5KrruO1l3qXf3HWHY1zOwbcbJKC1RyRv+wepqssQCfJLzEE?=
 =?us-ascii?Q?jPWEvByNijkXeZ3u8HS6kcCYmj8x3b+7E/ZSGnLMVUDq7+yoj6EelBxQ3biE?=
 =?us-ascii?Q?X5MYNHy/q+vi9Nuvjyry0sOPBUHBDRB1qX/8Hj8nwyMxGSLOnN+CULnLKnZF?=
 =?us-ascii?Q?XHWVvag0kkFO33IazKKRrvg3NppwuGKFNaU1LFBRsz5injHNTHvHd/JMStii?=
 =?us-ascii?Q?VI+CmLxQBZW55rmdh4xWZZrDcG58NtH8LAkX6Ixa3ldCeWGllHzJvNG6lqa7?=
 =?us-ascii?Q?0KxHjoOGvr+WrQSHEJYG98OKuz2eGzxW4DGtNT1bv8dxCNzZ1o0M0v/b5krq?=
 =?us-ascii?Q?6FXX51/2ZQGAYBfDigQXg5Z/Lkwu3kJgW1pMwjPT5Nh9DoOJRBnvelKrQw1l?=
 =?us-ascii?Q?PEuOt1CwPOwHq/0gBF6/wE/GmuIhqX5elwuh+YJQG62iAHl6Vg/ZMpFbYoO4?=
 =?us-ascii?Q?lVVcMGwM/RimihTVFtdVErc85CBhfjbkYEozzQ1MExqY0UNkrP5CpE4N1jQn?=
 =?us-ascii?Q?4CBWx9KM8jjPn9cfO3f2yv3PFvxc75kDjNOgSh2Ynuunus6VolZtW9dQbPAm?=
 =?us-ascii?Q?VxP3zC8BvyyU7H+KK8eqaVplRmlSyT7yYBrd66ZWW2oPpasXxn2ITveRCPnV?=
 =?us-ascii?Q?nmWXkU8OHp6EkxZqxrx9KqFHcF0EHSUPUMv4c6yEmfKcZ3ljQ4Xb3/CVX/EB?=
 =?us-ascii?Q?SgKbX7DL1FrcF+YMIo8BVu0=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cab48b42-1145-4246-00ad-08d9efc6ab34
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2022 14:31:20.5760
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EqJNsvaWTHzi9zFUzv96XI4w6N5DOOMXV1jEvYbOG/uygsGUvB65QnDnYu2Fu8jLm+QzI1yVvQpA7IrsxpFkNQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR04MB9199

On 14.02.2022 15:26, Oleksandr Andrushchenko wrote:
>=20
>=20
> On 14.02.22 16:19, Jan Beulich wrote:
>> On 09.02.2022 14:36, Oleksandr Andrushchenko wrote:
>>> @@ -410,14 +428,37 @@ static void vpci_write_helper(const struct pci_de=
v *pdev,
>>>                r->private);
>>>   }
>>>  =20
>>> +static bool vpci_header_write_lock(const struct pci_dev *pdev,
>>> +                                   unsigned int start, unsigned int si=
ze)
>>> +{
>>> +    /*
>>> +     * Writing the command register and ROM BAR register may trigger
>>> +     * modify_bars to run which in turn may access multiple pdevs whil=
e
>>> +     * checking for the existing BAR's overlap. The overlapping check,=
 if done
>>> +     * under the read lock, requires vpci->lock to be acquired on both=
 devices
>>> +     * being compared, which may produce a deadlock. It is not possibl=
e to
>>> +     * upgrade read lock to write lock in such a case. So, in order to=
 prevent
>>> +     * the deadlock, check which registers are going to be written and=
 acquire
>>> +     * the lock in the appropriate mode from the beginning.
>>> +     */
>>> +    if ( !vpci_offset_cmp(start, size, PCI_COMMAND, 2) )
>>> +        return true;
>>> +
>>> +    if ( !vpci_offset_cmp(start, size, pdev->vpci->header.rom_reg, 4) =
)
>>> +        return true;
>>> +
>>> +    return false;
>>> +}
>> A function of this name gives (especially at the call site(s)) the
>> impression of acquiring a lock. Considering that of the prefixes
>> neither "vpci" nor "header" are really relevant here, may I suggest
>> to use need_write_lock()?
>>
>> May I further suggest that you either split the comment or combine
>> the two if()-s (perhaps even straight into single return statement)?
>> Personally I'd prefer the single return statement approach here ...
> That was already questioned by Roger and now it looks like:
>=20
> static bool overlap(unsigned int r1_offset, unsigned int r1_size,
>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 unsigned int r2_offset, unsigned=
 int r2_size)
> {
>  =C2=A0=C2=A0=C2=A0 /* Return true if there is an overlap. */
>  =C2=A0=C2=A0=C2=A0 return r1_offset < r2_offset + r2_size && r2_offset <=
 r1_offset + r1_size;
> }
>=20
> bool vpci_header_write_lock(const struct pci_dev *pdev,
>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0 unsigned int start, unsigned int size)
> {
>  =C2=A0=C2=A0=C2=A0 /*
>  =C2=A0=C2=A0=C2=A0=C2=A0 * Writing the command register and ROM BAR regi=
ster may trigger
>  =C2=A0=C2=A0=C2=A0=C2=A0 * modify_bars to run which in turn may access m=
ultiple pdevs while
>  =C2=A0=C2=A0=C2=A0=C2=A0 * checking for the existing BAR's overlap. The =
overlapping check, if done
>  =C2=A0=C2=A0=C2=A0=C2=A0 * under the read lock, requires vpci->lock to b=
e acquired on both devices
>  =C2=A0=C2=A0=C2=A0=C2=A0 * being compared, which may produce a deadlock.=
 It is not possible to
>  =C2=A0=C2=A0=C2=A0=C2=A0 * upgrade read lock to write lock in such a cas=
e. So, in order to prevent
>  =C2=A0=C2=A0=C2=A0=C2=A0 * the deadlock, check which registers are going=
 to be written and acquire
>  =C2=A0=C2=A0=C2=A0=C2=A0 * the lock in the appropriate mode from the beg=
inning.
>  =C2=A0=C2=A0=C2=A0=C2=A0 */
>  =C2=A0=C2=A0=C2=A0 if ( overlap(start, size, PCI_COMMAND, 2) ||
>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (pdev->vpci->header.rom=
_reg &&
>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 overlap(start, si=
ze, pdev->vpci->header.rom_reg, 4)) )
>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return true;
>=20
>  =C2=A0=C2=A0=C2=A0 return false;
> }
>=20
> vpci_header_write_lock moved to header.c and is not static anymore.
> So, sitting in header.c, the name seems to be appropriate now

The prefix of the name - yes. But as said, a function of this name looks
as if it would acquire a lock. Imo you want to insert "need" or some
such.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 14:34:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 14:34:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272370.467182 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJcQf-0005lf-OD; Mon, 14 Feb 2022 14:34:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272370.467182; Mon, 14 Feb 2022 14:34:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJcQf-0005lY-LB; Mon, 14 Feb 2022 14:34:13 +0000
Received: by outflank-mailman (input) for mailman id 272370;
 Mon, 14 Feb 2022 14:34:12 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=YsDI=S5=epam.com=prvs=4044e07e7c=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nJcQe-0005lQ-Q5
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 14:34:12 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2c5d91c4-8da3-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 15:34:11 +0100 (CET)
Received: from pps.filterd (m0174683.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 21EENPcg000662;
 Mon, 14 Feb 2022 14:34:07 GMT
Received: from eur04-he1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2057.outbound.protection.outlook.com [104.47.13.57])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3e7pbw0n4c-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Mon, 14 Feb 2022 14:34:06 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by DB7PR03MB4732.eurprd03.prod.outlook.com (2603:10a6:10:1d::17) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.18; Mon, 14 Feb
 2022 14:34:00 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::fc4d:4749:5d1:eb73]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::fc4d:4749:5d1:eb73%4]) with mapi id 15.20.4975.018; Mon, 14 Feb 2022
 14:34:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2c5d91c4-8da3-11ec-b215-9bbe72dcb22c
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jOPGNlz6dSyam11sigDBRakRIVCkK7ICkRYPqpKHKhJS6p2Q7g+eBodtHdx3e6hjlWMhwsg/5whyln7Zp6PV1nOq8qz9Ubhm47EqqzWNdolFMIdjNZmsC/5ImHTTaQ+AgiJImpZL+taNDSAzRdz3pmniBPkE5QCT8CyLhyn1IsgBMIrTsTFBgWNBIpwtbIZJghM1Y8ddpKhUSLZBzVPA72vIWS0pRIfQhTLDYmM/toK0YOyTVJ6K/RuxvzBj7xsNMJB85QnB4hX88r/Mvop3xP02UyZvjYxLbDiYSNVltQOmvzPZy58395iQ/HvXQlVsQ0Zgmh0MJpPxlsmquUS9Tg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=gTCJecP4i3IZaqOPE/2k9vTMhudYuakj3LcaND1YHb0=;
 b=hl9FY6ayft8ET6Q4BW2+OOmPdxrHwRm4sUpJEPC3lDf4EHHMOCnFYWRxgxL8LF6tKIGAQ5D22+sAwb3AX+S6jDNPekBwreJsXFvGF2Vf3ncWCJZORnPKAAJwkflI9z2VeXJ1J4c31ZFqYgJogV+Im++9OxCkdeWMdJfNA+qIJAD3W23n6hN5H/Zdh+feWxo9n9wXsuKeuZIcPOSEe9cMzCJKZFctOXlVQp6Hq6QaPhcmodxxB9ln7XruQW0B7j6LRGxR0GYYP7sfoyaqhtIScNRID/z2Azzot/ZGccvVy7nSwcldJhTHrCMylLqdAKB3MgyStgHcopLIDK7Nxl4kxA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=gTCJecP4i3IZaqOPE/2k9vTMhudYuakj3LcaND1YHb0=;
 b=T17obt2jLfGFJZCdiabSExM0OJX6qlNIUOJO5/HubjxeVcI4iDFrYt0Owv/dgNBEItWE5CJR7zG+oICVibDXjImBMs3xWWgwU0aemU3NYKO1wCXnTzF5oNHll9ia1jEsYEys1zfIbMiOc6aFkYSc6Dp/Dixk6HRhEmRpZ9lXw7Elce7h2VsKtL/hL9oD09J4RunZuSoLFaGagctNhQOPg3UdQQs4AT4duR0nC3rLactxJEBlTWoU6ED2hU1pXqSdhq9qSkzuJ7KwSB8ndIwrkL3k8X8Ez45sR64xEg9rrwJUOfWpfqpjXnjevnhfAmPW7PXZo064WH7l8cFukGK1kA==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "roger.pau@citrix.com" <roger.pau@citrix.com>,
        "julien@xen.org"
	<julien@xen.org>,
        "sstabellini@kernel.org" <sstabellini@kernel.org>,
        Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH] vpci: introduce per-domain lock to protect vpci structure
Thread-Topic: [PATCH] vpci: introduce per-domain lock to protect vpci
 structure
Thread-Index: AQHYHboQT3cBWYI1/EGunE7hOwop6ayTIGYAgAABuQCAAAF7AIAAAMCA
Date: Mon, 14 Feb 2022 14:34:00 +0000
Message-ID: <3afcee6e-221b-e3b2-2f7e-c7e9566d5dd1@epam.com>
References: <20220209133627.959649-1-andr2000@gmail.com>
 <77f818a7-fe8a-20e5-3f1c-8fb7aef7984b@suse.com>
 <40feb747-c459-2a2d-6ca1-ac9f8fea47e3@epam.com>
 <7a9c9ed1-3c10-247d-ee7b-c2f47dee1f38@suse.com>
In-Reply-To: <7a9c9ed1-3c10-247d-ee7b-c2f47dee1f38@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 5e5915f8-3072-485c-5743-08d9efc70a76
x-ms-traffictypediagnostic: DB7PR03MB4732:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <DB7PR03MB4732E7625BF5BABFEB1185E0E7339@DB7PR03MB4732.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:7219;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 94ZsI4q7fOg8dLLfMBRRzR6iSIz813cEd38dO5tz+wS5XZ35+lTHLf03oYZ4aGwXFgOIHE+t08CkMYkApZhIbdUTS/22bMnKA6g8Qz16FyOgvJHN2llPZveUenyqC/URYYV9m/2Lvs8leGoEfLZxnlaLhP3oZHNlFTcBB4AREaE7Mb6dUi2b0sPrN7EHDmHX4mupaItCwnPlWNOBhx265ApKvq1WnQxZTAwIlOCv+Qp5nJ2JTLUwHkE2W6CcE/A8DkBbrdjByG7/8ToOCaho/KECBC2PweoXNes3DaROoPAg9fGid3BArNa/ZIGJpAObsWFnbwz2HrAGp9EfPppj2jIegxpVeoohO8iboyQJ7j/c8ngVQCUQ5ZKqF8E5fU4SX740BeMBTSkKuEgK0UZRzBvhUMm7YIYNsB0KSPR0MybJ5dwfVZfwQsD/dYDulw7NdBFizY/3comoSrM3EDhSETZSQOPMfZs3TQw3D7FEMarQ2kDYYn0zOwFCLcReo4X8JA21HzZPU8BN5LmsM5qGxFytNwZ/NEKsF0KaAWYd7Ls7EW/DUwMhV2BGiRRz5V9X973uVLLTkYGMumfN6d6jci/6LNvVuuSz6IBumyx1zK3aFsVw9JKRegpg9Z0Ch5zeh2wyUJZWWOWv0QMpEIbyUYafVtKqXwvl/R6LO7VzrHFWySMkATg+agqHOtCiB+ZO152rkoJymiVGrblBRsjidPvemkpYGz2wsJtMhR7BqewaPRBq/VwgvGtLnLmQ6E/h
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(53546011)(71200400001)(6506007)(36756003)(83380400001)(6486002)(6512007)(508600001)(316002)(55236004)(6916009)(91956017)(31686004)(54906003)(31696002)(2906002)(122000001)(8936002)(38100700002)(86362001)(76116006)(66946007)(64756008)(66446008)(66556008)(66476007)(8676002)(26005)(186003)(2616005)(107886003)(38070700005)(4326008)(5660300002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?NW1Uck9TeU5rQ0M4MWVpK0lLcWh6QWE1WnZ4MGtJRWxEKzJmc3QrSCswclAr?=
 =?utf-8?B?L051dkFHM3FWTVFIVklCTUJreHVCazE2QTlIOU5YSkhIbG1zVkY2Vjh5NXJX?=
 =?utf-8?B?dlhaUlhYb3FVWGdvM04zM1FoT2dJam04VW8zd3NUOFU3NHAzU1BLTk5xbVpi?=
 =?utf-8?B?Y3ZnYWx3Vkd1T2VhQm83RC80dURSeEdUMU1ZOTlobG9rM0xHWmJCdDIzRzIy?=
 =?utf-8?B?b0pMQWc4TEszZkdQM3RFSitwQTZVc2VFQVNHdU9YOHM3cEErVlZjL3BvOVhU?=
 =?utf-8?B?WTIyRWRJTzRGa2FZNXZqZlQvYWY1QkkrVWZlbjZoUjVhQWNaUzNyZkc5eUFy?=
 =?utf-8?B?NllnNDJSZ3R1YW1Ka2JjcEJMTWJCbzVleGJCVUdYV3B4a0x6eGtuQkR1Qi9l?=
 =?utf-8?B?L1pjMUtHNE1UcHNCZHBlWFp0enE0QUdTVC9xTW8wbCtwb3RrNjhVUTdQU3FL?=
 =?utf-8?B?ejVVY2pnRmdGNXo1VkZJb21NUWdwNUpFQkFxZno2YkVNbWFScjFEV0thanNM?=
 =?utf-8?B?a1grcERGVVN6TW9xTG1uZ3pQQzNoQ09rOFl0QW45bUJuMFdEakVodHpKcUtM?=
 =?utf-8?B?M0V4L2htOGdGVnlRQlgwVkFyelBZSG9lM290VTl2bXJtaldPQTlILzJKTTVD?=
 =?utf-8?B?WlpGL1hWRitvbUpuRTQ3QlZiQXQ4VktSQzdoMXZXdjBuTkZHNjg5Wjd4MzBi?=
 =?utf-8?B?dzFvNEpzRXJRTlcwMDJ6UUcrQW9raFU4Sjh4ZmtYWk1KUlg4eklSWFJRK0Fw?=
 =?utf-8?B?V0dodGkxTWZMdGY0N1ZYV0ZwOUlHZDIyd3RwaTFiR1J3eUNwNDMwUGVMMVlS?=
 =?utf-8?B?c0hvS2g4NWlmbVJaUkZWcEtrVGZQbW0vbVhPcXpWOFpZa2FtRTNGUmFySXEx?=
 =?utf-8?B?Tys2L2pRbmE2N1h4WTJBbnlzVGs1NHJhNi92R1NMSzYxdXRVdzdhQmZOaUxG?=
 =?utf-8?B?SWY5NnVQWU9GTnFXdFlyZUhkUkZ4UGVhSU02ZDEzcVJWNEU1M1ZmWkFPcFAr?=
 =?utf-8?B?aWhZMWN0VlphN2tzUlJhTnMyaWFqTnpWdkRaTXlqSFRTVFB5T1FVZDJ0Y0VK?=
 =?utf-8?B?RG9ST0xEVEx4ejZrYjd4aFZ5VGIzSlR1ajdFanhNcFY5bVdENGlCZytLTUZz?=
 =?utf-8?B?RUt5VWhaandSSTFBeEtpTW9LSUduckdzdDJJMVQrRFYraHpML2hTZmJSVXlQ?=
 =?utf-8?B?b1oydkU5NEE5VVFsdGZ1WTdzYU5wSy9iV0NDcy9URjBPdldrdEtIdEdBYzRh?=
 =?utf-8?B?MnphQnFzTjNLK3Bib3NtMmlzcVZaM2JyMHNTSm1qd1N5N1Y5aU05YlFjSEdm?=
 =?utf-8?B?OTVqTC91c0FRWUIyZ3BaSzc5RWhGNnlkcVBCbVA4L2RxWlFzNzdYejVuVVdX?=
 =?utf-8?B?RGVhMU9YamlWSmtjWW5QTWdwVHhHSHJ4ZEpGVnpWdWFyNnQvaHYzREJhSWZ5?=
 =?utf-8?B?bWFGcjluTGM3c0RpTnBmUW9mTHV4dVRybnJYaWp5bG1LUzZNYytHcVN3MTFU?=
 =?utf-8?B?VjkvSTFLWTVtNFpSR3ZFUjY5TmlOelAvYVNXNkwrSXp6RjQ0amNXYVVqVjIx?=
 =?utf-8?B?c1JkY3pwL1g5bUtJYjd0WFZxZHZIUjJlT2xtOXp3ZFB2V3BFUVJmcHJQUzNJ?=
 =?utf-8?B?VG96b0lzOEk4NTdZNzFoQktWWUQ4aEpkeW9UNXdPeWZBU2VhTHNBVDdROEVm?=
 =?utf-8?B?WkdOT3VTbGtUWjZmMWFhYVlLd0xXNHJJcko2SHhmdmpWV3FzMy9IM2VvKzI5?=
 =?utf-8?B?Q3lLTTRvZ2lKa1JBSG9wOFVzTFhxZFZ1WjNXMkpoUldWZDBRR0R2RVFlS2R4?=
 =?utf-8?B?NHVNMG5tZkxFRzZZTkFncUNVQWJ2blpKa2NDRlJPTExvMFUzVFJ2bWtRWCtm?=
 =?utf-8?B?WFVvQy9JY0ppeWt4em1yMXEvZUZzdmx1MDRMVVZpTGl0NUo3bUNQbnRyL21P?=
 =?utf-8?B?NUowbks2NEJ1azkzSExoNnRVZ2JTNUpmUTZCaTJSZi9xb0pEd0ozYW43MnU3?=
 =?utf-8?B?NGZOY1ZjMmhoMU9JN0lLeDZ3YnFCRVNiRFJlTnZpbXczcmg0WE1TSjB2VjVH?=
 =?utf-8?B?VEFKN3BQcXdhS293UjIwRVdZK1lTazlCMUh3d1F0d1Q3MVU3YnJyK05tSmlQ?=
 =?utf-8?B?RWd3dG1LTlAyVEZiQzFJQkV4VlcvUVhJcHA5ZjhtRWZoM3hwL1VrS05wWWs2?=
 =?utf-8?B?b29FZlRpT08wallxaVVkb09ZZk9Ddm53ZFUzR1ltZ2dCV0FaL2NtN0YvYWx3?=
 =?utf-8?B?SDc5ZTV0cUtUL0JnNmNtQnliTFBTM3BVVHFWc1lrSlVKUHplczZadndNZXhC?=
 =?utf-8?B?NUdZRXJGR0JYZ1hPVUVCS1NKd0lYdkVBWXNZQ1ZRbGpyUHQwaXZ6OXFyNUxp?=
 =?utf-8?Q?aSYVZ1mhflNL75+w=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <1BE552D9021B8C40AD3A12031F5F945B@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5e5915f8-3072-485c-5743-08d9efc70a76
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Feb 2022 14:34:00.1600
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: bgaWNVFnG2h/ZzZutkXaX55Rg1ItcVcd0SgwJ69gwzSVSp139CXH0cvqko1piaA4EwOsugxJp8h+Pic54KcPBpy5XQppopkiHyqwtSHQWanCItuZfBvSxBODs3GWu2Sw
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR03MB4732
X-Proofpoint-GUID: WE-Scj8UjJGvEIQO-GGcRoEJg_UAaiOn
X-Proofpoint-ORIG-GUID: WE-Scj8UjJGvEIQO-GGcRoEJg_UAaiOn
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-14_06,2022-02-14_03,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501
 clxscore=1015 spamscore=0 mlxscore=0 bulkscore=0 adultscore=0
 lowpriorityscore=0 malwarescore=0 suspectscore=0 mlxlogscore=999
 phishscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2201110000 definitions=main-2202140089

DQoNCk9uIDE0LjAyLjIyIDE2OjMxLCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMTQuMDIuMjAy
MiAxNToyNiwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+Pg0KPj4gT24gMTQuMDIu
MjIgMTY6MTksIEphbiBCZXVsaWNoIHdyb3RlOg0KPj4+IE9uIDA5LjAyLjIwMjIgMTQ6MzYsIE9s
ZWtzYW5kciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4+PiBAQCAtNDEwLDE0ICs0MjgsMzcgQEAg
c3RhdGljIHZvaWQgdnBjaV93cml0ZV9oZWxwZXIoY29uc3Qgc3RydWN0IHBjaV9kZXYgKnBkZXYs
DQo+Pj4+ICAgICAgICAgICAgICAgICByLT5wcml2YXRlKTsNCj4+Pj4gICAgfQ0KPj4+PiAgICAN
Cj4+Pj4gK3N0YXRpYyBib29sIHZwY2lfaGVhZGVyX3dyaXRlX2xvY2soY29uc3Qgc3RydWN0IHBj
aV9kZXYgKnBkZXYsDQo+Pj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVu
c2lnbmVkIGludCBzdGFydCwgdW5zaWduZWQgaW50IHNpemUpDQo+Pj4+ICt7DQo+Pj4+ICsgICAg
LyoNCj4+Pj4gKyAgICAgKiBXcml0aW5nIHRoZSBjb21tYW5kIHJlZ2lzdGVyIGFuZCBST00gQkFS
IHJlZ2lzdGVyIG1heSB0cmlnZ2VyDQo+Pj4+ICsgICAgICogbW9kaWZ5X2JhcnMgdG8gcnVuIHdo
aWNoIGluIHR1cm4gbWF5IGFjY2VzcyBtdWx0aXBsZSBwZGV2cyB3aGlsZQ0KPj4+PiArICAgICAq
IGNoZWNraW5nIGZvciB0aGUgZXhpc3RpbmcgQkFSJ3Mgb3ZlcmxhcC4gVGhlIG92ZXJsYXBwaW5n
IGNoZWNrLCBpZiBkb25lDQo+Pj4+ICsgICAgICogdW5kZXIgdGhlIHJlYWQgbG9jaywgcmVxdWly
ZXMgdnBjaS0+bG9jayB0byBiZSBhY3F1aXJlZCBvbiBib3RoIGRldmljZXMNCj4+Pj4gKyAgICAg
KiBiZWluZyBjb21wYXJlZCwgd2hpY2ggbWF5IHByb2R1Y2UgYSBkZWFkbG9jay4gSXQgaXMgbm90
IHBvc3NpYmxlIHRvDQo+Pj4+ICsgICAgICogdXBncmFkZSByZWFkIGxvY2sgdG8gd3JpdGUgbG9j
ayBpbiBzdWNoIGEgY2FzZS4gU28sIGluIG9yZGVyIHRvIHByZXZlbnQNCj4+Pj4gKyAgICAgKiB0
aGUgZGVhZGxvY2ssIGNoZWNrIHdoaWNoIHJlZ2lzdGVycyBhcmUgZ29pbmcgdG8gYmUgd3JpdHRl
biBhbmQgYWNxdWlyZQ0KPj4+PiArICAgICAqIHRoZSBsb2NrIGluIHRoZSBhcHByb3ByaWF0ZSBt
b2RlIGZyb20gdGhlIGJlZ2lubmluZy4NCj4+Pj4gKyAgICAgKi8NCj4+Pj4gKyAgICBpZiAoICF2
cGNpX29mZnNldF9jbXAoc3RhcnQsIHNpemUsIFBDSV9DT01NQU5ELCAyKSApDQo+Pj4+ICsgICAg
ICAgIHJldHVybiB0cnVlOw0KPj4+PiArDQo+Pj4+ICsgICAgaWYgKCAhdnBjaV9vZmZzZXRfY21w
KHN0YXJ0LCBzaXplLCBwZGV2LT52cGNpLT5oZWFkZXIucm9tX3JlZywgNCkgKQ0KPj4+PiArICAg
ICAgICByZXR1cm4gdHJ1ZTsNCj4+Pj4gKw0KPj4+PiArICAgIHJldHVybiBmYWxzZTsNCj4+Pj4g
K30NCj4+PiBBIGZ1bmN0aW9uIG9mIHRoaXMgbmFtZSBnaXZlcyAoZXNwZWNpYWxseSBhdCB0aGUg
Y2FsbCBzaXRlKHMpKSB0aGUNCj4+PiBpbXByZXNzaW9uIG9mIGFjcXVpcmluZyBhIGxvY2suIENv
bnNpZGVyaW5nIHRoYXQgb2YgdGhlIHByZWZpeGVzDQo+Pj4gbmVpdGhlciAidnBjaSIgbm9yICJo
ZWFkZXIiIGFyZSByZWFsbHkgcmVsZXZhbnQgaGVyZSwgbWF5IEkgc3VnZ2VzdA0KPj4+IHRvIHVz
ZSBuZWVkX3dyaXRlX2xvY2soKT8NCj4+Pg0KPj4+IE1heSBJIGZ1cnRoZXIgc3VnZ2VzdCB0aGF0
IHlvdSBlaXRoZXIgc3BsaXQgdGhlIGNvbW1lbnQgb3IgY29tYmluZQ0KPj4+IHRoZSB0d28gaWYo
KS1zIChwZXJoYXBzIGV2ZW4gc3RyYWlnaHQgaW50byBzaW5nbGUgcmV0dXJuIHN0YXRlbWVudCk/
DQo+Pj4gUGVyc29uYWxseSBJJ2QgcHJlZmVyIHRoZSBzaW5nbGUgcmV0dXJuIHN0YXRlbWVudCBh
cHByb2FjaCBoZXJlIC4uLg0KPj4gVGhhdCB3YXMgYWxyZWFkeSBxdWVzdGlvbmVkIGJ5IFJvZ2Vy
IGFuZCBub3cgaXQgbG9va3MgbGlrZToNCj4+DQo+PiBzdGF0aWMgYm9vbCBvdmVybGFwKHVuc2ln
bmVkIGludCByMV9vZmZzZXQsIHVuc2lnbmVkIGludCByMV9zaXplLA0KPj4gICDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB1bnNpZ25lZCBpbnQgcjJfb2Zmc2V0LCB1bnNp
Z25lZCBpbnQgcjJfc2l6ZSkNCj4+IHsNCj4+ICAgwqDCoMKgIC8qIFJldHVybiB0cnVlIGlmIHRo
ZXJlIGlzIGFuIG92ZXJsYXAuICovDQo+PiAgIMKgwqDCoCByZXR1cm4gcjFfb2Zmc2V0IDwgcjJf
b2Zmc2V0ICsgcjJfc2l6ZSAmJiByMl9vZmZzZXQgPCByMV9vZmZzZXQgKyByMV9zaXplOw0KPj4g
fQ0KPj4NCj4+IGJvb2wgdnBjaV9oZWFkZXJfd3JpdGVfbG9jayhjb25zdCBzdHJ1Y3QgcGNpX2Rl
diAqcGRldiwNCj4+ICAgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgIHVuc2lnbmVkIGludCBzdGFydCwgdW5zaWduZWQgaW50IHNpemUpDQo+PiB7
DQo+PiAgIMKgwqDCoCAvKg0KPj4gICDCoMKgwqDCoCAqIFdyaXRpbmcgdGhlIGNvbW1hbmQgcmVn
aXN0ZXIgYW5kIFJPTSBCQVIgcmVnaXN0ZXIgbWF5IHRyaWdnZXINCj4+ICAgwqDCoMKgwqAgKiBt
b2RpZnlfYmFycyB0byBydW4gd2hpY2ggaW4gdHVybiBtYXkgYWNjZXNzIG11bHRpcGxlIHBkZXZz
IHdoaWxlDQo+PiAgIMKgwqDCoMKgICogY2hlY2tpbmcgZm9yIHRoZSBleGlzdGluZyBCQVIncyBv
dmVybGFwLiBUaGUgb3ZlcmxhcHBpbmcgY2hlY2ssIGlmIGRvbmUNCj4+ICAgwqDCoMKgwqAgKiB1
bmRlciB0aGUgcmVhZCBsb2NrLCByZXF1aXJlcyB2cGNpLT5sb2NrIHRvIGJlIGFjcXVpcmVkIG9u
IGJvdGggZGV2aWNlcw0KPj4gICDCoMKgwqDCoCAqIGJlaW5nIGNvbXBhcmVkLCB3aGljaCBtYXkg
cHJvZHVjZSBhIGRlYWRsb2NrLiBJdCBpcyBub3QgcG9zc2libGUgdG8NCj4+ICAgwqDCoMKgwqAg
KiB1cGdyYWRlIHJlYWQgbG9jayB0byB3cml0ZSBsb2NrIGluIHN1Y2ggYSBjYXNlLiBTbywgaW4g
b3JkZXIgdG8gcHJldmVudA0KPj4gICDCoMKgwqDCoCAqIHRoZSBkZWFkbG9jaywgY2hlY2sgd2hp
Y2ggcmVnaXN0ZXJzIGFyZSBnb2luZyB0byBiZSB3cml0dGVuIGFuZCBhY3F1aXJlDQo+PiAgIMKg
wqDCoMKgICogdGhlIGxvY2sgaW4gdGhlIGFwcHJvcHJpYXRlIG1vZGUgZnJvbSB0aGUgYmVnaW5u
aW5nLg0KPj4gICDCoMKgwqDCoCAqLw0KPj4gICDCoMKgwqAgaWYgKCBvdmVybGFwKHN0YXJ0LCBz
aXplLCBQQ0lfQ09NTUFORCwgMikgfHwNCj4+ICAgwqDCoMKgwqDCoMKgwqDCoCAocGRldi0+dnBj
aS0+aGVhZGVyLnJvbV9yZWcgJiYNCj4+ICAgwqDCoMKgwqDCoMKgwqDCoMKgIG92ZXJsYXAoc3Rh
cnQsIHNpemUsIHBkZXYtPnZwY2ktPmhlYWRlci5yb21fcmVnLCA0KSkgKQ0KPj4gICDCoMKgwqDC
oMKgwqDCoCByZXR1cm4gdHJ1ZTsNCj4+DQo+PiAgIMKgwqDCoCByZXR1cm4gZmFsc2U7DQo+PiB9
DQo+Pg0KPj4gdnBjaV9oZWFkZXJfd3JpdGVfbG9jayBtb3ZlZCB0byBoZWFkZXIuYyBhbmQgaXMg
bm90IHN0YXRpYyBhbnltb3JlLg0KPj4gU28sIHNpdHRpbmcgaW4gaGVhZGVyLmMsIHRoZSBuYW1l
IHNlZW1zIHRvIGJlIGFwcHJvcHJpYXRlIG5vdw0KPiBUaGUgcHJlZml4IG9mIHRoZSBuYW1lIC0g
eWVzLiBCdXQgYXMgc2FpZCwgYSBmdW5jdGlvbiBvZiB0aGlzIG5hbWUgbG9va3MNCj4gYXMgaWYg
aXQgd291bGQgYWNxdWlyZSBhIGxvY2suIEltbyB5b3Ugd2FudCB0byBpbnNlcnQgIm5lZWQiIG9y
IHNvbWUNCj4gc3VjaC4NCkFncmVlLiBUaGVuIHZwY2lfaGVhZGVyX25lZWRfd3JpdGVfbG9jay4N
Ckkgd2lsbCBhbHNvIHVwZGF0ZSB0aGUgY29tbWVudCBiZWNhdXNlIGl0IG1ha2VzIGFuIGltcHJl
c3Npb24gdGhhdA0KdGhlIGZ1bmN0aW9uIGFjcXVpcmVzIHRoZSBsb2NrDQo+DQo+IEphbg0KPg0K
VGhhbmsgeW91LA0KT2xla3NhbmRy


From xen-devel-bounces@lists.xenproject.org Mon Feb 14 14:38:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 14:38:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272379.467192 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJcUo-0006WG-DY; Mon, 14 Feb 2022 14:38:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272379.467192; Mon, 14 Feb 2022 14:38:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJcUo-0006W9-Ai; Mon, 14 Feb 2022 14:38:30 +0000
Received: by outflank-mailman (input) for mailman id 272379;
 Mon, 14 Feb 2022 14:38:29 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=fO+b=S5=apertussolutions.com=dpsmith@srs-se1.protection.inumbo.net>)
 id 1nJcUm-0006W3-VP
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 14:38:29 +0000
Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com
 [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c47dd424-8da3-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 15:38:27 +0100 (CET)
Received: from [10.10.1.138] (static-72-81-132-2.bltmmd.fios.verizon.net
 [72.81.132.2]) by mx.zohomail.com
 with SMTPS id 1644849500356743.2670791339187;
 Mon, 14 Feb 2022 06:38:20 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c47dd424-8da3-11ec-b215-9bbe72dcb22c
ARC-Seal: i=1; a=rsa-sha256; t=1644849503; cv=none; 
	d=zohomail.com; s=zohoarc; 
	b=OFyle/9yJTqW69R57Cyruh4yjQXrICtVXzm2duXfTQmH0Ptg79k77xA/LdfsTw4qv9qAJ6AMQbrjGCl4I3Tadh4XIKLWEwqFFK40Cpxc9ISxtI/V7Rp9GwYXAI7aqCkuqe8zBmAFFs5CBxx+qUIm63mvLG+dB4qedo6fpKpGpkA=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; 
	t=1644849503; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; 
	bh=YG491Nbb34JgRxwbYnH31xBaKwX7aA4GlBqr7Vr8GQY=; 
	b=R3uMJ/is1SZj0JCN56LiVp/1bw4lqIOrhcasVjfVlL/ra5a5pem5kb9jPoZlgIiSdaFkC+dc6IxUjMpzvAGMPeP0l8UN1Ma6vY83zaJ/RsgRhUrSDtmmba5QzoTbpvIfvbe3LTyRPI061tbK8UZ4qZEy1yy92Pqi5SekCCV/BNk=
ARC-Authentication-Results: i=1; mx.zohomail.com;
	dkim=pass  header.i=apertussolutions.com;
	spf=pass  smtp.mailfrom=dpsmith@apertussolutions.com;
	dmarc=pass header.from=<dpsmith@apertussolutions.com>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1644849503;
	s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com;
	h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Content-Type:Content-Transfer-Encoding;
	bh=YG491Nbb34JgRxwbYnH31xBaKwX7aA4GlBqr7Vr8GQY=;
	b=nIJr8jJpnLziW7xJ/d0SVcu+evfGtH1I6VCJa6tMwRxT4OuZqBKht1jDQS0TxSCX
	1bcyWGbkYCzJNl84A9He4rNJ2ayEbKxuIjmEdHMIUKk+3c3ihELrOHzAdgJuLk6TSPO
	hwhcnRkDmai8hHpHQusMYavr32vidxMqLL01g36o=
Message-ID: <8b493d22-9b07-8ecb-3579-53f50227ee12@apertussolutions.com>
Date: Mon, 14 Feb 2022 09:36:20 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v2 03/70] xen/xsm: Move {do,compat}_flask_op()
 declarations into a header
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
Cc: Daniel De Graaf <dgdegra@tycho.nsa.gov>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
 <20220214125127.17985-4-andrew.cooper3@citrix.com>
From: "Daniel P. Smith" <dpsmith@apertussolutions.com>
In-Reply-To: <20220214125127.17985-4-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ZohoMailClient: External

On 2/14/22 07:50, Andrew Cooper wrote:
> Declaring sideways like this is unsafe, because the compiler can't check that
> the implementaton in flask_op.c still has the same type.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> ---
> CC: Daniel De Graaf <dgdegra@tycho.nsa.gov>
> CC: Daniel Smith <dpsmith@apertussolutions.com>
> 
> v2:
>  * Rework in the face of no useful progress on the better fix.
> ---
>  xen/xsm/flask/flask_op.c | 1 +
>  xen/xsm/flask/hooks.c    | 4 +---
>  xen/xsm/flask/private.h  | 9 +++++++++
>  3 files changed, 11 insertions(+), 3 deletions(-)
>  create mode 100644 xen/xsm/flask/private.h
> 
> diff --git a/xen/xsm/flask/flask_op.c b/xen/xsm/flask/flask_op.c
> index 221ff00fd3cc..bb3bebc30e01 100644
> --- a/xen/xsm/flask/flask_op.c
> +++ b/xen/xsm/flask/flask_op.c
> @@ -21,6 +21,7 @@
>  #include <avc_ss.h>
>  #include <objsec.h>
>  #include <conditional.h>
> +#include "private.h"
>  
>  #define ret_t long
>  #define _copy_to_guest copy_to_guest
> diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c
> index 3b29f7fde372..6ff1be28e4a4 100644
> --- a/xen/xsm/flask/hooks.c
> +++ b/xen/xsm/flask/hooks.c
> @@ -36,6 +36,7 @@
>  #include <avc_ss.h>
>  #include <objsec.h>
>  #include <conditional.h>
> +#include "private.h"
>  
>  static u32 domain_sid(const struct domain *dom)
>  {
> @@ -1742,9 +1743,6 @@ static int flask_argo_send(const struct domain *d, const struct domain *t)
>  
>  #endif
>  
> -long do_flask_op(XEN_GUEST_HANDLE_PARAM(void) u_flask_op);
> -int compat_flask_op(XEN_GUEST_HANDLE_PARAM(void) u_flask_op);
> -
>  static const struct xsm_ops __initconstrel flask_ops = {
>      .security_domaininfo = flask_security_domaininfo,
>      .domain_create = flask_domain_create,
> diff --git a/xen/xsm/flask/private.h b/xen/xsm/flask/private.h
> new file mode 100644
> index 000000000000..73b0de87245a
> --- /dev/null
> +++ b/xen/xsm/flask/private.h
> @@ -0,0 +1,9 @@
> +#ifndef XSM_FLASK_PRIVATE
> +#define XSM_FLASK_PRIVATE
> +
> +#include <public/xen.h>
> +
> +long do_flask_op(XEN_GUEST_HANDLE_PARAM(void) u_flask_op);
> +int compat_flask_op(XEN_GUEST_HANDLE_PARAM(void) u_flask_op);
> +
> +#endif /* XSM_FLASK_PRIVATE */

Reviewed-by: Daniel P. Smith <dpsmith@apertussolutions.com>



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 14:39:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 14:39:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272383.467204 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJcVL-00070j-Mb; Mon, 14 Feb 2022 14:39:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272383.467204; Mon, 14 Feb 2022 14:39:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJcVL-00070c-JQ; Mon, 14 Feb 2022 14:39:03 +0000
Received: by outflank-mailman (input) for mailman id 272383;
 Mon, 14 Feb 2022 14:39:01 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KkXt=S5=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nJcVJ-00070L-Gr
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 14:39:01 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d8b769d7-8da3-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 15:38:59 +0100 (CET)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2113.outbound.protection.outlook.com [104.47.17.113]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-41-S3auIpQPMvutrH3u2J2FIA-2; Mon, 14 Feb 2022 15:38:58 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM8PR04MB7796.eurprd04.prod.outlook.com (2603:10a6:20b:243::6)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.18; Mon, 14 Feb
 2022 14:38:55 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4975.015; Mon, 14 Feb 2022
 14:38:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d8b769d7-8da3-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644849539;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=YsXDWh1/LX/yCotIya6tDIMr+1L8uDfwXUu8ABfr2oA=;
	b=I8ap613qYWa6v6Hp3QUoQbgLDK8fXdKe5sgzfqbuAmhc/U4ZqQXXBaMZPEQpomY6oE+HJq
	yYaG+kRsGNCX5xFJI+uXa9dcxB53FRdQTDOC9CtafJuCv88CxI/UZeCEqEeWcN9n8u6jHy
	uEPVEEtj2TKi05Q0QlnAqo2PQJEZ42E=
X-MC-Unique: S3auIpQPMvutrH3u2J2FIA-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=kfNVlg0tQUh0Cj/mxL0NymTtJYSL9IRusaC76Af1Zc3USbPcmUfkvWxp8eE/Gc/QOFGnaQWS/BHecn1UqwtJsRFa2plxZKj/65ZsVt68UgAqItswjdpsDEgMSbDNYQBp3yL6lv/R1vSeAqD1+gUMQTJvba/h4nn1MnA2ZQ5+gk63Qi69+5J+jkqwW51yVbVCF5pRFqh0DXyj5TCwO1MDjSwLb979s0uqiAj/itBIgr/CEEO+4SAmrXeeEYZ2JWJwSh1R7uNV693DdtxT7CZxVvOJCusjwIbVyQaIZq1c9qdX5jHSxE094v6HTywySrm2iJVM6sjUB+qwHj5MI6BcVw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=oW0R6CNu1PHJKhRVZskWODYz0c04fKeDGBd6HyYD2sU=;
 b=Dq0UW3MiN1EYjdiv8trX8KGaLCxgGb5Z+U2Az7eoK/6ctwEKzZtw2oY9TLXXdcBtzO4E0flxI86d75LEr2spUUnKJyxpCfgTpHXOraOZqTwuUueA1lFr7aOJc4cfwILsAx+BHut9lHvBwg8U1Et9UDOw+fYb8zGlNI/cE0TKaob2GFeMR3qSdK32NUmT6lY8/D5mhTwYoLcg+B4AYHKRC43N5npBLNBQ+6t7vaFTb+KLZNIMRoM/+e7l3VEmywQWbYTt1jSpiTetGchU1+YDd3LD1CsSjcinmm7vcaiYCOU9uvEA3PfKQi37cS3GOiZ7C/bjH/SrbYyXIU3l6jZw5Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <83e15c5d-f48b-a6f2-ebca-e416bdef1093@suse.com>
Date: Mon, 14 Feb 2022 15:38:52 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH v2 00/70] x86: Support for CET Indirect Branch Tracking
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>,
 Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>
CC: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
 <julien@xen.org>, Juergen Gross <jgross@suse.com>,
 Daniel Smith <dpsmith@apertussolutions.com>,
 =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
 <c471dcc2-8a91-60b8-ba5d-58874752e4d7@citrix.com>
 <218de2dc-6dd8-4e13-3288-36448e47de7f@suse.com>
 <8c6dd7d0-11e6-9b8a-66fc-f1a4998c074b@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <8c6dd7d0-11e6-9b8a-66fc-f1a4998c074b@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS8PR07CA0024.eurprd07.prod.outlook.com
 (2603:10a6:20b:451::7) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 31442264-b660-4bb4-abb1-08d9efc7b9fc
X-MS-TrafficTypeDiagnostic: AM8PR04MB7796:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<AM8PR04MB7796E31E30AD786A95DA1500B3339@AM8PR04MB7796.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	V8bANfzkxlTsT4iUCuBAB9lzwU54XWM5siLdf3AMiTDphpjreYLE2rkckaypXVbkffgPE6jt/HSWOGOwaOlBSAI0vXDNOAFtI3jY/w3y666cyUWBYZiOb9Bs2UH02Onzvp2BkPAt2IDuxc+ag1Jo29YOobQVrA6XFb8CWuB5qURVMa2SXyv+I379+2DXL3l+S3iD8D8OJzaqGw/Qgx90R5FEPYB1msJVkIPbwq3cMcrmzmBZC13ajIDqJQASJev9TnFO55dD4njt+SmIwTUQaWPfGJjJUTqRwE6TwlC9T4VcaiWDGuZF1jP2ueLgKHFgS04llHNnQq1qefPtlEb6tU0krzGtvG1SVmzFv+TgAdcF93mIKAA4491HUIzzd3SZAenwEs1gOuL+Uk4QtY1OTMxFUvDfUr7j5n8rFu7NHrEmp7rg4pYHZZr64flHQy4ov+3ora3zKu34reqQX2Ty5+3GE7epf8PHLZsBJ2tbjRVTIWlloGax0fO+ZrR/xoAtHkItvJwfD9lnyNg8T2OxkkFMiuaFs7Rau2PYS92YmK/qPDNjrR4KehZ7askgM4Rl8LbfFDY9L0dZRNhdF8hHVRdAMaiE4P3s2cn87QBj/3XIycVZk/5zWhqq0O+gUUi1BOpAb9+p/So9ZEL07G6KHWPFywe8vUwEgKSyy8o8/Yk1Vad7uYoP6gARXiTVREe3QKlnqPgPIF9Nkp12NVeeTfWtGjsRkRoFeCzALjCEgjRX/SkgYObVHwCvhhHxwwb04XpeIJr7kTmq4p2I8U4Pjle+4VJHlDAgLyyTCdBg5uHy9ytehImhS7jgrJo8MV4F
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(508600001)(36756003)(31686004)(110136005)(6666004)(54906003)(2616005)(2906002)(31696002)(86362001)(316002)(966005)(6486002)(6512007)(66476007)(66556008)(66946007)(8676002)(38100700002)(5660300002)(26005)(186003)(8936002)(53546011)(4326008)(6506007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?9/UwChijAU984aDmci27Mr1B/ceBn5qB8QvkAhHWnSrBXvztaBvTfXnoSA/0?=
 =?us-ascii?Q?nb1QWNvhpi06ouemYZaVXEOkJ5nhahz76G8dq8ikex00PCV1BMMvpd99XmtT?=
 =?us-ascii?Q?r6Plxw8I+5rYg6YsfDdbgryUiOtg5jylmI3Qt4x+0qAiNlUf/0qec6gnkKuL?=
 =?us-ascii?Q?nn+R0qgzhXfj2U0jIv1eb5qm7BhQbVFr3i+xPBxt/ol4mKVD2X0yFFetSos9?=
 =?us-ascii?Q?Brs7t4OeOx5KJ69xSFislVsGEY++pxb5FUmrzm/4WWbMsDcdNJYV0JIs4i9a?=
 =?us-ascii?Q?Y2X5kNKVfeazp8UIGO3uFlnhAlgqlMe15tfqgmobpx7UBW59UitZ5d/J/z4j?=
 =?us-ascii?Q?2cC5ez3diWVeyK3LfUK8dsIWpNoCCqkCiJaNNckMjXU1SEKmrMO5ktLLgYy+?=
 =?us-ascii?Q?WgB+6MjM7njEdfhqP9AtpBto6/I2pAPTeBILVHXdGvv6p2fX2pEAovNuUqRV?=
 =?us-ascii?Q?YXgvGNLZNuOAXOfGzSIjxl1cz/U0KgFtojdgejQ5KJa8HYUF0tQYTQBS/oPM?=
 =?us-ascii?Q?OZEc7VErFnap4kJHW0q9T5zitBB2HFyt2TwZxIjDp1AU8e0X5eNxhj10J6IF?=
 =?us-ascii?Q?5R5AXwjPCA7+R+efqPe0rJRhbku7/YfIbwE5pptv7FHXg6kwnXm+uGt/nHzY?=
 =?us-ascii?Q?qiXKcksN204U5ib/sTz/rdN6WFCGlGMP3M6vNEUgo9oEPUgH+sJ7mUH7N1YY?=
 =?us-ascii?Q?GMLRcmHMDsFNRnrKfS6jmQ3hw+E80Tw2TO6cfCld4kpjIcrGgsnJRIzLN9xm?=
 =?us-ascii?Q?VhNYfFtv4ljXD+pln+bTOzFubyt/BybV7A/vyK49VyrN5I1C8ihVS4bkChas?=
 =?us-ascii?Q?cdkKC7oK574+tUUzGH5BjHVaiKMSPQL8LOjD+XyKR8001U7a02J+wJ+f8MZj?=
 =?us-ascii?Q?hPyK+lqkLOQDXNuSjkFi0U0Md02m1vXoHeuwvRYL/g9Mw4Or+DG67ND27Eq7?=
 =?us-ascii?Q?8Qd31zZy0L+GNHQuBFW/0AayMyVzRlq5vhgPR9iaoFsDyiAAPwcQw1BjBbEQ?=
 =?us-ascii?Q?e9D2O3EmO8fJeOjlPeNRuxKWhuv9hRxbPFO72jMWshSN7GLNwZLAv4KXF3Uy?=
 =?us-ascii?Q?6dOVKwvXyESkV/KOrTJSkXNtcX3G+hiJZ9TM/zChnyHPgqsHLIZomVDrauOY?=
 =?us-ascii?Q?fuMhL87w4m5AAk1zBKEGz/OxR0n9ODms+ZoqZDvLmQYygN2Y18bta/+19/3s?=
 =?us-ascii?Q?LBQhYj1mv9HjdYBmJTYgq/Eus7OJCkHDteHIm7DASB3YYxwU1diIJjckfl+w?=
 =?us-ascii?Q?kNqOEH4QxHMdqsYyBn0ccX0u1xDQtr31jNiZFz5o8d6lCEfj7Ea5EN0kzDQP?=
 =?us-ascii?Q?PH0MmWjVF9BVa2qsFXqk04+5fNlT9NPaeOidO/JjS7+Yw+grc9I/hDJv3N0d?=
 =?us-ascii?Q?gHERmUEH9XrTZzrONeJRz2j3+Jb/JQEmWYH3P6Jv3Sw3Jq/UqutnEbe2DGwT?=
 =?us-ascii?Q?jWptsPpbVMdSfvadB30Qex7oujVIBzq722Gia6/4GMLPhgVE4fywlM0qcvKk?=
 =?us-ascii?Q?kBtKTCbeDaJOGxvPAoLMZyWCYpxV+fX6QSTL9FYs3lIDavZYd/zci8jX+wfw?=
 =?us-ascii?Q?C31fUoaZM/ked66LK1LNI7xw6loW+pvWs9ewsu/rmLg+kTuN/mndBpYK11Bo?=
 =?us-ascii?Q?A6epilWhBeZVgJV6JsHd+1E=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 31442264-b660-4bb4-abb1-08d9efc7b9fc
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2022 14:38:54.8916
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Uu2lrXZMVBTwqPmoPqnYK/bp/XnPi4Mantb3z2zvskaLznnyhwvMf8YcEBY1VWFro3u1zOXKG6YhD8qoxAcXYA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7796

On 14.02.2022 15:15, Andrew Cooper wrote:
> On 14/02/2022 13:43, Jan Beulich wrote:
>> On 14.02.2022 14:10, Andrew Cooper wrote:
>>> On 14/02/2022 12:50, Andrew Cooper wrote:
>>>> CET Indirect Branch Tracking is a hardware feature designed to protect=
 against
>>>> forward-edge control flow hijacking (Call/Jump oriented programming), =
and is a
>>>> companion feature to CET Shadow Stacks added in Xen 4.14.
>>>>
>>>> Patches 1 thru 5 are prerequisites.  Patches 6 thru 60 are fairly mech=
anical
>>>> annotations of function pointer targets.  Patches 61 thru 70 are the f=
inal
>>>> enablement of CET-IBT.
>>>>
>>>> This series functions correctly with GCC 9 and later, although an expe=
rimental
>>>> GCC patch is required to get more helpful typechecking at build time.
>>>>
>>>> Tested on a TigerLake NUC.
>>>>
>>>> CI pipelines:
>>>>   https://gitlab.com/xen-project/people/andyhhp/xen/-/pipelines/470453=
652
>>>>   https://cirrus-ci.com/build/4962308362338304
>>>>
>>>> Major changes from v1:
>>>>  * Boilerplate for mechanical commits
>>>>  * UEFI runtime services unconditionally disable IBT
>>>>  * Comprehensive build time check for embedded endbr's
>>> There's one thing I considered, and wanted to discuss.
>>>
>>> I'm tempted to rename cf_check to cfi for the function annotation, as
>>> it's shorter without reducing clarity.
>> What would the 'i' stand for in this acronym?
>=20
> The class of techniques is called Control Flow Integrity.
>=20
>>  Irrespective of the answer
>> I'd like to point out the name collision with the CFI directives at
>> assembler level. This isn't necessarily an objection (I'm certainly for
>> shortening), but we want to avoid introducing confusion.
>=20
> I doubt there is confusion to be had here.=C2=A0 One is entirely a compil=
er
> construct which turns into ENDBR64 instructions in the assembler, and
> one is a general toolchain construct we explicitly disable.

Hmm. I'm still at best half convinced. Plus we generally have been
naming our shorthands after the actual attribute names. By using
"cfi" such a connection would also be largely lost. Roger, Wei,
others - do you opinions either way?

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 15:03:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 15:03:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272393.467215 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJcsW-0001w0-L0; Mon, 14 Feb 2022 15:03:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272393.467215; Mon, 14 Feb 2022 15:03:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJcsW-0001vt-Gr; Mon, 14 Feb 2022 15:03:00 +0000
Received: by outflank-mailman (input) for mailman id 272393;
 Mon, 14 Feb 2022 15:02:59 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=fX6a=S5=suse.com=dfaggioli@srs-se1.protection.inumbo.net>)
 id 1nJcsV-0001vn-7s
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 15:02:59 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 31cbfbfa-8da7-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 16:02:58 +0100 (CET)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2059.outbound.protection.outlook.com [104.47.12.59]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-26-qdJexCgBN8eI4Ui_ZKo7ag-1; Mon, 14 Feb 2022 16:02:56 +0100
Received: from AM0PR04MB5826.eurprd04.prod.outlook.com (2603:10a6:208:134::22)
 by AM0PR04MB6435.eurprd04.prod.outlook.com (2603:10a6:208:176::30)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Mon, 14 Feb
 2022 15:02:54 +0000
Received: from AM0PR04MB5826.eurprd04.prod.outlook.com
 ([fe80::ccff:6c4a:d6fc:3b74]) by AM0PR04MB5826.eurprd04.prod.outlook.com
 ([fe80::ccff:6c4a:d6fc:3b74%7]) with mapi id 15.20.4975.018; Mon, 14 Feb 2022
 15:02:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 31cbfbfa-8da7-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644850977;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type;
	bh=UIox7dkw3kSLbAPAwaqHJJZcACHo1M82BL2Dud1K1n4=;
	b=KJsv23xI6afBbp5Nl7qmqbmPnlC/Kg5RKnEBmy6cqQmQ00VubhDGjVf9kLlYO4pDxgtADB
	0RUptty7Eu5EUJclGFn0VXGAWedDlCEeLWRdl/F7W0wvY3c0Pt6boFeqRPSPcMrbemin0P
	pWMPhadiBipVOqt4zY1CCEtWnAzNKAw=
X-MC-Unique: qdJexCgBN8eI4Ui_ZKo7ag-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ELWah6MMQO05hJg4BPah9Vzzwb4Mr1gW1V36pAXONDKqGL7kP/GMyWLljz0/vsrZ7j2Y5c3mJhjJESov1z7SYL7M6vtIeLYCqYTQSEuPkJIPOo7pmPi+jttF2NNYVrZaLBPxdWtvPSV+lnLELkjK289roeK6+NRbfql05gud6jmspv5GWrU6H0q3EOXCwWvgNIwkHlMW9ZyxY7A9tAdRhFvZuSGRjmy5i+HTYf2RZN3jgUjzuaM3HejeAJWK3my7SCvkWiiU6CSyxiARrMKacGd+PRorz2ordHwkj5v0yU7tKPAVa8XliDrJk+Akn54IKRio6I5CJFwtRfeASuQxNg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=UIox7dkw3kSLbAPAwaqHJJZcACHo1M82BL2Dud1K1n4=;
 b=ZOABoM9oti8ypj0hBANedlglXHOIuT24uxPKz9W17FWtZwpoqsSaZ8hRtcJJTEmrVBmhSuc1KhiFXp0PqRPlOczN5qPazH5n8+xvGWA+TVZ5E7EnqTC2u4Xfhlo/GIkkzUDXdctxo2laYIQ5UMgIiHZaUGLoUSo8VX36WGyNmsPPOgQgNELxyDH4x5D1nCGIKfYXoHk4e1yE9G9FSl/1vtd1WqDJFSd8MWFJ/P9sd5/rdmjjr9lHlNj0/v/Uc7E8KPpXVkhhsSrnrPhi4QLtXr8KJd1YbQh5dHeOhnzDq5BOYvwvPVyTUtjITPGt72lEXgpoVVeVXJ+6zjuYmDhjIA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
From: Dario Faggioli <dfaggioli@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: "sstabellini@kernel.org" <sstabellini@kernel.org>,
	"marmarek@invisiblethingslab.com" <marmarek@invisiblethingslab.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, "anthony.perard@citrix.com"
	<anthony.perard@citrix.com>
Subject: SecureBoot and PCI passthrough with kernel lockdown in place (on Xen)
Thread-Topic: SecureBoot and PCI passthrough with kernel lockdown in place (on
 Xen)
Thread-Index: AQHYIbPxFY5Kj3bRXE6t4z/dbeVrRw==
Date: Mon, 14 Feb 2022 15:02:53 +0000
Message-ID: <8daad0f6c623a57bc0b047fc2388e8b698135624.camel@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
user-agent: Evolution 3.42.4 (by Flathub.org)) 
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 5409a396-1777-485a-04c6-08d9efcb13db
x-ms-traffictypediagnostic: AM0PR04MB6435:EE_
x-microsoft-antispam-prvs:
 <AM0PR04MB6435DCEA2D691C8CA4A27B19C5339@AM0PR04MB6435.eurprd04.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:7219;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 IgTYsvdWuAncSEEELugARCzz9/oLkxNzCo4JsB/TAsvTGgWgqk+qUw+wa2mZwVSjuWDCxYmJjULHpTt7mkGkEaawxZ8gOeKZ1p1xOYqwQswU5qhZMNrDmFOPpzuhfjb4duJoInPU9LY6yLkqVC5bVqZspYtoeYXYuS6jPqhemlOwtfaIQBDaxlsNhLiuKQjmeWUiK5MEPuzE/2XymQJ9KCS8/oeKKO0flTBEiLN+UTUx0sifO+O7iuibwGFHIgjg+M2IIsSNN3VvG81okqFpxjuGknuEUZmT3Jsl00Xc6F+jm16PGSy3FwF+NrShkYmFbFwWm1Ph7Amv/kfOpHMzFKsWtDqKYj0FYipneY5Ge7oz5zvzJ/M5OrORTg720cZN1D/H7/86bpdY1n2xdRlzYtF2o3epUDhIe9bUyIO2DAD8FR8Z4fHks9PQ75xRe+kUaRIGmgDbi41KeIXOTN1fBOlaE/ZUYjT3rO0yRN1rrEb9eJAxdtJHOfubzdrRlnu3COhBdPIUSDoPofeiADN3gDkZ1TZ+PEk8+uw1PaLLmM4/Za+utZzgS0l9NNLjAreNJ9dY8LOBqKXydbvXU3ysK3QgsyUIjEthZ++Cp1juwfY7XOh5LnYbafJzCGWggYgC46cFcSrthJscKeSZ8Uk9y+mO3X74JwvRb2Zo5p4NNQipLvCzyUpL9CsuXXCuRcSu2uby/eNSSuaMk4RBow7vczUHj/9FKZpL3pl9NdAipgIq7y6VW7vmmW8dlmWKJB19fOgul1WxuM4SFIquDLhsXyJcZv1Cu0lDMzzTRIS4pI4H55uVCGggWWARTuj6czN+5XnHBR4WfSWkhmllS3UzIw==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR04MB5826.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(83380400001)(316002)(6512007)(91956017)(38070700005)(86362001)(54906003)(66946007)(64756008)(122000001)(66476007)(66556008)(66446008)(6506007)(8936002)(71200400001)(8676002)(4326008)(36756003)(6916009)(38100700002)(966005)(76116006)(26005)(5660300002)(2616005)(508600001)(99936003)(2906002)(186003)(6486002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?aDJwSUZUU2dXelBBdDBDaGhOYi9DMTlUaTVPVG1vV3IvdndpZWl2MzFKLys2?=
 =?utf-8?B?WmhyZ05oME1RRG9vT3FSMFVRUG5EdkNmU3lhY0h0N1NqcUluK29OV0N2N1R1?=
 =?utf-8?B?aTZZMG1iVnVZdjVJcDU0S0ROMnlScndEY0xqdFA3ZjVXTHdyUEdSRlVwR3Jk?=
 =?utf-8?B?VUdyazk2c3o1blM5eVBaaGxuTHUraklrL24xOVlhbDAvVEdIWlVGR0Y3VEYv?=
 =?utf-8?B?eHZNa09KZzkwTHZSZ1ZDN0JZb0lLNGZaMG9LTUlnRUNwN0Q4VER0ZTFEZUFS?=
 =?utf-8?B?cU5IUEVYa1hQUHFTTm02L3FpaUluZGN0NktZRE05VEY0UWlsek53b2d3dVFD?=
 =?utf-8?B?N2dvU1pXVERQWm9MQTl6aXJ2S0E2RmlGQ3BCUlF2dnpGVnBWR2p4alIreTB6?=
 =?utf-8?B?eUd3L0RtODJoT0UzVXp4SjJDYmRDaysyMVRRUm1SbXhRNTZOaklaSE85Q2tE?=
 =?utf-8?B?S1liSDE3ekVIbzQ5azJUeTlqMWJkQmt1a1JqSjFBSVpDa1JDTmpxQjFJcm5y?=
 =?utf-8?B?dXROQUxmdi9PdU9LQS9kN3Q1Uk55SUpkREhUK24zbERzY3JXSnZDRDJGMGZr?=
 =?utf-8?B?YlBlMmYyVVRPQjV2RTA3OFg3U0hoRFFBZVI4UFFXRjg2YUJwRWk0UjlHNXBW?=
 =?utf-8?B?bzRsSFpoZEJKbmlYSERGVmJTdGc3cWRXcUljQWlCN2tBTVkyOW1pekk3eFlw?=
 =?utf-8?B?MHBBcU1LNVRmbDZJZDdJWXlidk9MbTIxZzVqNlZtSWNVNVhwa3RUSmRLYlBX?=
 =?utf-8?B?MG1wRHpkWGhnRlNNY0xKTFgvNTNCQlZTbVBlVGFPek9yZjNjYllmK24yRHZj?=
 =?utf-8?B?WVhmN3VHaCtnL0JPZDNKK29QZWViU1NDRHRjZXNRaEVwd0Y1ZXJnR2Q4QjBK?=
 =?utf-8?B?ZVc0MEtTUzFMVkdFczk1TVJBSzNwSDFQaU1VNEFlZTZUbVI4ay9UcEp3WnBw?=
 =?utf-8?B?bncvT3BWcW1KMDYxR1gxalEvcU83NDlEQ29NbytvbjRSVDMxSENRbWNORjFS?=
 =?utf-8?B?am1qLzRvL016UWdOYUJoa3NiclVqU0VLVjlnbWg4NXNPOFFsZ0UvdTJvWmZD?=
 =?utf-8?B?ZmtsYlBxbldLU1IrY3dSYTFmTWh6RlJMTlVMQVUvWWpoeEMrR2NXc043aTJm?=
 =?utf-8?B?ZlRNRVRKdU82aTkrK2ZkbXU1SDRvZk5aa0FmRHhReFFNL3FHTHZ6MS8rSlJm?=
 =?utf-8?B?WmpORzVlZDNoZXdST2ZwWjk5blFrSVBTOWd1ekRLQkc3dkJQclRsUXBoVS92?=
 =?utf-8?B?U0dnMHZLdlR0M1F4TkYvTXRpdnM3SUsySmU3YkZTNUw1WDNQNzdwSWVGSTFW?=
 =?utf-8?B?NGViTERQME4rQ29XNWpNZjRGbklKMnl5ZEN2YkY0ckIrQXlwbDZ0UGVYdjlQ?=
 =?utf-8?B?UlBVbVZMVFh1NzI2Y0NRbmxuWUwzQmoySlgrZmMyR2FoWHlOZFhWbTZsRXlQ?=
 =?utf-8?B?bnE4NDcvbEV4TGhyeHd4bVZ2VXpFbU1uYm8yd3lYcnZVcmNwQUVGVy9JaUI3?=
 =?utf-8?B?UnVTcSt1RVROc1l4bnlhcXdCTFJDakdBdHVZT2tmUzR3YlNaTzg5S1BXOW13?=
 =?utf-8?B?SFQwUjdyQytxWmJWc2hJRkluN1dtUmpHbWcwRyt4Y0RwWWJ3eitRZHhnOS83?=
 =?utf-8?B?cVpoRnFma3FhaXg1WUVUZXNiOCt1SlY3WVd2VUx4bG9zOVFCaVcxTlZQWHJL?=
 =?utf-8?B?ek5nVnVvNS82UjQ2akZkNVdFNmxYUGdCUWw5cnRMeVFHMEFDVzA5a3VYOVY3?=
 =?utf-8?B?cUtSMzg5bFFKT05YNXdaZUVKa0xpT0d4SVJaWGYwTjh1cE0weUwvaXM3Mnda?=
 =?utf-8?B?a0dwSGVSWkFxUTBwTklCdDRyNU1tcVRJREFFZmgxWG1NOEJOMDd6R21hNG1B?=
 =?utf-8?B?N0Z2eDlpY0pSdVN0NGRhRjErSTExc1EyMzQvYXFKaVFsVzFRWFdFQmNDei9X?=
 =?utf-8?B?aFU2ckRaZmJleERib1hNOXY1L1p6VDdQdDdVcXowVHlPd3FOOGZPY3dEMC9W?=
 =?utf-8?B?YStkaWlmN1k5QTdzczJiM1JIOWVKanhJY3NvY1RXcUJDTVozZ1grcXd6eWtL?=
 =?utf-8?B?MlZUbWZPSnJVeHA1ekVzZi9ENjdXSDdmWW4zL3YvZzd5V0hTZzYzbENpOFdU?=
 =?utf-8?B?bWI5bk84WXB2VkN6NjVXaXhwVzltMkFBNEU4d21IcFNRU3FOSFV0cnZIbi8z?=
 =?utf-8?Q?WWc1yflUz8mJ6Yhqu7tdv84=3D?=
Content-Type: multipart/signed; micalg="pgp-sha256";
	protocol="application/pgp-signature"; boundary="=-o0+UXT5YZwxmdHu4aySw"
MIME-Version: 1.0
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB5826.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5409a396-1777-485a-04c6-08d9efcb13db
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Feb 2022 15:02:53.9218
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: c9fkIKhhkbRIvl+q8guT5FYD5LcOp0+dKlHgkRWTbuJdLeOa4d+osEfmp1+QVGzsuknxSUGUcdFUM12Bz/NRqw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6435

--=-o0+UXT5YZwxmdHu4aySw
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hello,

We have run into an issue when trying to use PCI passthrough for a Xen
VM running on an host where dom0 kernel is 5.14.21 (but we think it
could be any kernel > 5.4) and SecureBoot is enabled.

The error we get, when (for instance) trying to attach a device to an
(HVM) VM, on such system is:

# xl pci-attach 2-fv-sles15sp4beta2 0000:58:03.0=20
libxl: error: libxl_qmp.c:1838:qmp_ev_parse_error_messages: Domain 12:Faile=
d to initialize 12/15, type =3D 0x1, rc: -1
libxl: error: libxl_pci.c:1777:device_pci_add_done: Domain 12:libxl__device=
_pci_add failed for PCI device 0:58:3.0 (rc -28)
libxl: error: libxl_device.c:1420:device_addrm_aocomplete: unable to add de=
vice

QEMU, is telling us the following:

[00:04.0] xen_pt_msix_init: Error: Can't open /dev/mem: Operation not permi=
tted
[00:04.0] xen_pt_msix_size_init: Error: Internal error: Invalid xen_pt_msix=
_init.

And the kernel reports this:

Jan 27 16:20:53 narvi-sr860v2-bps-sles15sp4b2 kernel: Lockdown: qemu-system=
-i38: /dev/mem,kmem,port is restricted; see man kernel_lockdown.7

So, it's related to lockdown. Which AFAIUI it's consistent with the
fact that the problem only shows up when SecureBoot is enabled, as
that's implies lockdown. It's also consistent with the fact that we
don't seem to have any problems doing the same with a 5.3.x dom0
kernel... As there's no lockdown there!

Some digging revealed that QEMU tries to open /dev/mem in
xen_pt_msix_init():

    fd =3D open("/dev/mem", O_RDWR);
    ...
    msix->phys_iomem_base =3D
            mmap(NULL,
                 total_entries * PCI_MSIX_ENTRY_SIZE + msix->table_offset_a=
djust,
                 PROT_READ,
                 MAP_SHARED | MAP_LOCKED,
                 fd,
                 msix->table_base + table_off - msix->table_offset_adjust);
    close(fd);

This comes from commit:

commit 3854ca577dad92c4fe97b4a6ebce360e25407af7
Author: Jiang Yunhong <yunhong.jiang@intel.com>
Date:   Thu Jun 21 15:42:35 2012 +0000

    Introduce Xen PCI Passthrough, MSI
   =20
    A more complete history can be found here:
    git://xenbits.xensource.com/qemu-xen-unstable.git
   =20
    Signed-off-by: Jiang Yunhong <yunhong.jiang@intel.com>
    Signed-off-by: Shan Haitao <haitao.shan@intel.com>
    Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
    Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>

Now, the questions:
- is this (i.e., PCI-Passthrough with a locked-down dom0 kernel)=C2=A0
  working=C2=A0for=C2=A0anyone? I've Cc-ed Marek, because I think I've read=
 that=C2=A0
  QubesOS that it does on QubesOS, but I'm not sure if the situation=C2=A0
  is=C2=A0the=C2=A0same...
- if it's working, how?

Thanks and Regards
--=20
Dario Faggioli, Ph.D
http://about.me/dario.faggioli
Virtualization Software Engineer
SUSE Labs, SUSE https://www.suse.com/
-------------------------------------------------------------------
<<This happens because _I_ choose it to happen!>> (Raistlin Majere)

--=-o0+UXT5YZwxmdHu4aySw
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEES5ssOj3Vhr0WPnOLFkJ4iaW4c+4FAmIKbx0ACgkQFkJ4iaW4
c+4xDQ/+Lh9dkdFd5qg1dtn5INAZFK+0azmUPs/RVBrl1hrLRNlWZ80BvgLBDBIc
D8dhgC8m1ZW53XVLfETnlBWSut2EMNbwxMN2f8qL4PmrdCJiFcMVZcojzLTNfvqW
5KMQeB0VN4Up8ul/Ad7ESpjMBcKKgahOg1YwkAr8F2oNbH1pIIYq+FAwu+mVAlD+
WYsP/TfEkBbb0Pv8TxfJq/ai0AyNgVH0Ww/TfXRN6PGCg7LAWzIMtwDDaNy7JZk0
HQFVG7Qdxr8IVzKULcb166eCh62y5HRXcRGLijGgUCny/yHuZpA7CIp+uzSwqAoU
cBOttrh41TC8WdE7P6tMWWgWvqF+W5x+6EFpQKjxHOgT3ybYIvn5FvRxvP6Xa/TM
Nf9bJPXP8q4EDAshzUGlAvnVigZflN3L4OjtqlXcEsWXo9bRCtLpJNac5Mp3jn9s
pGL9r+y9hH8cvFeCvfoEecvu1kVnIeilyoiVSvO3Z6YRyAdci187tpTnOCa24ADr
awq5vq1FpKLI7zpIlWJ++2oK5yxo6wfEuxo/WSNGM00w2a/mqjFaZpFJbkZjn0rf
/CffPzmeDKnXR97Bcz1ghVCS5BsvVyuE6d3DbHa0uLvLIhR31uBsT/cw9edwEUTu
HIt+nQxbd8cr58MHJeIn8VdAXH9TfDAGaqNW/x73JcEKIH6/ANI=
=J9gk
-----END PGP SIGNATURE-----

--=-o0+UXT5YZwxmdHu4aySw--



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 15:07:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 15:07:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272402.467226 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJcwf-0002fW-BM; Mon, 14 Feb 2022 15:07:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272402.467226; Mon, 14 Feb 2022 15:07:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJcwf-0002fP-7n; Mon, 14 Feb 2022 15:07:17 +0000
Received: by outflank-mailman (input) for mailman id 272402;
 Mon, 14 Feb 2022 15:07:15 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KkXt=S5=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nJcwd-0002fJ-OC
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 15:07:15 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id cac7cc50-8da7-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 16:07:14 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2177.outbound.protection.outlook.com [104.47.17.177]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-9-GreIISL0OCKkiCRpqOyasg-1; Mon, 14 Feb 2022 16:07:13 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DBBPR04MB6042.eurprd04.prod.outlook.com (2603:10a6:10:c2::13) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.15; Mon, 14 Feb
 2022 15:07:11 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4975.015; Mon, 14 Feb 2022
 15:07:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cac7cc50-8da7-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644851234;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Pzk0tjXrAVW6CIJLvTgm+wl5lvjKLf+2s1odUlMiRco=;
	b=DwKqu1M12CI9AK/ZhBuwNbIcthtJGzeYiW8YoCS0hetXPzRiDMufRPlqC0j7/iQYImc0on
	l9e3wggpyWcCr4t4O2AAFy3jUGAqaE8Tn4W9EbPqq64cQBrbd2lNy0kTSDdZgonhsn5wTt
	GFYRNk5qgs9Sddka6VpUPxw1AHbbKC8=
X-MC-Unique: GreIISL0OCKkiCRpqOyasg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=dLcOncue5CbWmESgicSnWAtTv2M7TzBMANERfAMWdreYavzXkkXMn36MIYZ7k4ff6vjRnrlXu0jHUliHk1Tb5/GTRNtelildo1KGx0/Pike22pzAOGxaXdGjDGYHSvo/wjc1IphrWDNNzNBhOJIMP20IcqXmynqczkSYlkciZ8u82Gn7GTEtsuZT1iuPrVNMrnU8JQItwYWSk5E+cfna95zS6OPt6hrItIN5+GEs6VfS6ZJ7Mj6MtSApio01JpUxbOEAbkLWrWzyKrm7m6f5h/xXyrT3GPt7cjQcKj+/9GfKnVA/9O4iKM2Qb5tdIVN7zW0zh84CK4pIpLmMOHImkg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Pzk0tjXrAVW6CIJLvTgm+wl5lvjKLf+2s1odUlMiRco=;
 b=fkFb8lMGqNNBo6LdoXdQ6BiL/AKKQGE3giUnukEyHCSGIrNDUUSJQl1U/Hsu8/WqFNWBQeMgSmNeqyqrFGVcqakawu6SlafitUhQpDvW1J7G9UyRSL9py5i9OBPPzWoGdBm6LWrJMTTyaRqigqK2xDe3KHbKTSneCiWRoxnXxzrBXwsKtHSWCe45CoyrlaSQYcT6eEXIdfCXrB8enG21FqVjB/+hgK+PJxGWqFWwbHI20bqwVutDxhz4gY5PPrw+C+wIwNi7Jhds+VqUcluqvltxnUmwXuRH+qIyaDOhdBj60Wn6vXlpOcTT7qBbAMQ7jTdG6bEHIFsQ4ZU6jFzj0w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <8e7f3193-dee6-1ff4-0c68-081032e240d2@suse.com>
Date: Mon, 14 Feb 2022 16:07:09 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH 1/3] amd/msr: implement VIRT_SPEC_CTRL for HVM guests on
 top of SPEC_CTRL
Content-Language: en-US
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220201164651.6369-1-roger.pau@citrix.com>
 <20220201164651.6369-2-roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220201164651.6369-2-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0244.eurprd06.prod.outlook.com
 (2603:10a6:20b:45f::35) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4fd5d33f-2d09-490a-2593-08d9efcbad25
X-MS-TrafficTypeDiagnostic: DBBPR04MB6042:EE_
X-Microsoft-Antispam-PRVS:
	<DBBPR04MB604203D3D7C3FCBEA34C5594B3339@DBBPR04MB6042.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3513;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	fXI5wgQQHHxkOIx5ZlM7zJn3ucj68XrgBhJbhaoEXyoXil9XUUQzsb6amBS9NYiPuIv04cWWUh+eyDd3Fflm9Z89gubtcCEPPOLcRUM7WmkOByf44bTmHOkgdfQ7TQ5Yzl0M0xhF605bssCgkbwEa8vKCjDd7oSi0SvwOEWE/gpCM3I6hJDIl0xjuhvfl5STwnx7IUfExcMmOvYim9Yr/87d9RmBvjjlj+hdQjof9OuR87iidshFIY1U1t51kxFvoOf5z8p90MyrYUT++7Yu1JBmiG1UR9novQwnSAlSWXUvFcedfJul9fFx4JSjYdiyKRrYh/vK9iOVHT0roMPTmE1F+uHxC+dblBQE0eeh/aZjJI5zMSQ3Y/jEQc66WB6PImPeygOhtCgRYVsb5+4bWrBSIwlAntdxaQpyrSo8qwA3ObduIbnXIOi6fR3u6o9fzFwxuEw4lB7643nB6rBOHwYbJh5P5rAZ0Rz1+QiuPIsndLcCh99fRZydQXy+UT6gfBrPkVRkGhhwRR0BgJyn3fDN7hWveiIz5nTfMsMgKcMqJjla3wNCcUTZEuQOrKfkev9q2VOnoEwVLzTk3eiHrOaJ4xqdpo+Fp5WxDEFirwgfYvcmaQXGNH1X84q+TioUgcuKHHMjrWnRC3jDsz2MCJImr96TXoOsLi58VknBLVYIrhaaPY3yGo2UACMKc37F1HhGlEfWr1kvPWl34cqGrp/kWY3r4ccvaQZVpMz7ni4=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(53546011)(5660300002)(38100700002)(6506007)(6916009)(54906003)(316002)(36756003)(31686004)(6486002)(8676002)(66556008)(2616005)(8936002)(4326008)(31696002)(6512007)(508600001)(66946007)(186003)(26005)(2906002)(66476007)(86362001)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?K1JNaUYvYlJEOGI2MGovVkZXb2tZMER6ckFHSFlra0s4dnF1N29yZllpRk9L?=
 =?utf-8?B?YkQxYWx3N2svVG9LS0V3OG4reDZsM0VrbEZvaVlmS1VlTGJUQzRmeGFHSEJ2?=
 =?utf-8?B?QnR0cWFrNFg0aTl3R29IaHMvdkFuSnVYWWVLSE9PSmp3bFlrWmk0SHE3QkJI?=
 =?utf-8?B?czZQN0k1QzhEK21ZcWdTQWEwRzh4Um9qWmUwUWR1OXNaZmpndWlZS2JwQVRU?=
 =?utf-8?B?TXNXMGxwVGFyV1NUTTRNMVVaRXZmdHU4dWxsUWY5YXNIZWlnZUE4Yy9NZ3hL?=
 =?utf-8?B?RWtTWTU1SmtISlhtaG0zV0ZpV0dLbG51WG5TSXhDUytxeWFacG0zNndiTHpI?=
 =?utf-8?B?MVJWTk1iTTUyREF1YVdkVHE5b0ErTTFhUEdmRit4eGx2aVM4MER4cVZDZE14?=
 =?utf-8?B?cEVNTEZYdmtRcFlxMFJ1azBYNVZPTDFnMXM5REZrakFjNVh3a1NJQzlDcEc2?=
 =?utf-8?B?TjdXa3diRDMvMjJzNTJtRGJQeis2bEVaeFBYWnJIRWN5c2FFbnk1UHBIeWpz?=
 =?utf-8?B?Qy9EUW5IckpvNlJyZDZtUHJkaGFzSmQ0NWF2T096cGg3bVZreC9Ha1hyUytC?=
 =?utf-8?B?dS9qekxoRWtCcVR2SmxrZzdhS2l0QVFvT0JmOERpNDV3VndHajh1bVdBeCt4?=
 =?utf-8?B?dS91UWdoOVh4TkxqWVREdlNBYlYxc0VPVUp1OFlIWkMyTDd6U3djLzhEZWps?=
 =?utf-8?B?QnlrOGRxR0MreVBBSFJURzRZRDFXd3E0SmIvbmNsMEM5cmwxdTNadGRVcTMx?=
 =?utf-8?B?K2o4c1EzQlptK1c5RnQveUpwT2Y5NU41M0RDclRsQ3V2OWkxVzEzdzhkTHd0?=
 =?utf-8?B?S1lWNWdzVENkV0t2ZFdBMmlCTGRaMEJpb2pkYWNqV3ZZQUQySzJJL1ovajU2?=
 =?utf-8?B?MG4ycDZOZ1BTbGRSR0tpRkdaRmQ3MGhBVUZMbjZYMTNQVWZLajd6NGdQQU9I?=
 =?utf-8?B?VEZ4eEVsT0VPZ1JYc0ZCMGRoQnBUblJaMFFZdHRXSG5qdXFrS0s2bkt6akFs?=
 =?utf-8?B?RGp5Ky92bVRYeFBuR3AxaEVrNnl1K3RnUE5VdlpoWGRKWFB4dlVBMGtrc3VY?=
 =?utf-8?B?TWdwci83Q1pibWN0RUZjcHh1alV3Uk5XU0hjU2FVUXBBT3JaVG1jQVAxUXNw?=
 =?utf-8?B?bVJWanQ2ZFlzaE1sRDFhN004aGt5ZWpVSmtFd2xheUJBNVhicDVRcUFBMnBY?=
 =?utf-8?B?aGxKSEh6dEdmUDVqenJvZElVcGdIYVR2TWNaNlZpQVViRW9VbEd1aitpK2F1?=
 =?utf-8?B?c003b2ppM3E1VGxKd1BybzF5cDdoN1Nvd0xkSERoV2NTeWxhamNlMGdPUFVU?=
 =?utf-8?B?aHRHSVRjOWNNS01MaVVsUFB3RUR4RkpxUFJWMVQ4UFJSUkM5U3A3WElRaFJo?=
 =?utf-8?B?NzBQVm1ZUlYyQi9zenlqSGVoNDVqeGRnVldTZWVZR3Z0cVZES0E3cTA0Y0hN?=
 =?utf-8?B?cmdPWXFWejhDTElnTkF1bm5lc3FrVVRnekdBaUsyNEFPTkdaWHo1TXplaWtr?=
 =?utf-8?B?bi9WZjFKcE00ekVKQklZZUlvOTZoSWJVa1dWZVB4SExBYngrbTVkUGp3UXU5?=
 =?utf-8?B?bEx6TUVOMmpoL3RNRW1sUVR3WnFucmpuZlhuQ1NKd0hYWStJSDhDQ0diWElD?=
 =?utf-8?B?NWZFTG04Wmg0QklCcE5pQTlIL0xQV2xiWVpjdVVGdWQ4R0NIN2NQUEdLZnV2?=
 =?utf-8?B?Yi82Uk8xQTBZRE53TnY4UE1KV28zSy9pY3pEWDArL0YxMFVaZDRqSDVoQmRY?=
 =?utf-8?B?cmVtNE9rK1NKMVlzZU9Cc3dJU3lvR3NGVXJoN3piNENXQkZlZ3lzeDZkRHAz?=
 =?utf-8?B?UmhMU0xraEhKZFljVXl3MmxQWFRERVQ3d3J4bHlhWUdzTHMxT2ZLSEs5NXg1?=
 =?utf-8?B?N0FyRVdtNXFMS3ZaTW9DaFNoSGhnQ2RsRzdrN2FBVkduVGJ5Z0E3Qi9yZnpH?=
 =?utf-8?B?TzQ0NDN6dllscGhvMzY2ZGg5U283aVFhK3VSM3ZVUXFnU0dSTUtrbEFjb3lP?=
 =?utf-8?B?Mm8rKzJsV0JsVE1FT0FudnZsOVNrYkFXL1lCcVA2SG52eWdzQytsUWdwNjl0?=
 =?utf-8?B?ZVFXZFduaFpxL2p6RFZnV2hiMWF0VTFha3pxUnJyNjdsckZneUw2TFhMdkxW?=
 =?utf-8?B?bHBmdzBtcElUL1AwRndXbk13V1JjTThGRDdrQkhickNybjEvVGMrVjdJWE1r?=
 =?utf-8?Q?/p152F+otJ4r0LT86ZFdyVQ=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4fd5d33f-2d09-490a-2593-08d9efcbad25
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2022 15:07:11.3646
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VSMsEROMOly1nPImCCbwTRd5DwTqyDKNUh/bNbAnleDcUicRlmdtBQoEYwaYpPjOPUq56MzI6+rAVouLbdGiMw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB6042

On 01.02.2022 17:46, Roger Pau Monne wrote:
> Use the logic to set shadow SPEC_CTRL values in order to implement
> support for VIRT_SPEC_CTRL (signaled by VIRT_SSBD CPUID flag) for HVM
> guests. This includes using the spec_ctrl vCPU MSR variable to store
> the guest set value of VIRT_SPEC_CTRL.SSBD.

This leverages the guest running on the OR of host and guest values,
aiui. If so, this could do with spelling out.

> Note that VIRT_SSBD is only set in the HVM max CPUID policy, as the
> default should be to expose SPEC_CTRL only and support VIRT_SPEC_CTRL
> for migration compatibility.

I'm afraid I don't understand this last statement: How would this be
about migration compatibility? No guest so far can use VIRT_SPEC_CTRL,
and a future guest using it is unlikely to be able to cope with the
MSR "disappearing" during migration.

> --- a/docs/misc/xen-command-line.pandoc
> +++ b/docs/misc/xen-command-line.pandoc
> @@ -2273,8 +2273,9 @@ to use.
>  * `pv=` and `hvm=` offer control over all suboptions for PV and HVM guests
>    respectively.
>  * `msr-sc=` offers control over Xen's support for manipulating `MSR_SPEC_CTRL`
> -  on entry and exit.  These blocks are necessary to virtualise support for
> -  guests and if disabled, guests will be unable to use IBRS/STIBP/SSBD/etc.
> +  and/or `MSR_VIRT_SPEC_CTRL` on entry and exit.  These blocks are necessary to

Why would Xen be manipulating an MSR it only brings into existence for its
guests?

> --- a/xen/arch/x86/cpuid.c
> +++ b/xen/arch/x86/cpuid.c
> @@ -543,6 +543,13 @@ static void __init calculate_hvm_max_policy(void)
>          __clear_bit(X86_FEATURE_IBRSB, hvm_featureset);
>          __clear_bit(X86_FEATURE_IBRS, hvm_featureset);
>      }
> +    else
> +        /*
> +         * If SPEC_CTRL is available VIRT_SPEC_CTRL can also be implemented as
> +         * it's a subset of the controls exposed in SPEC_CTRL (SSBD only).
> +         * Expose in the max policy for compatibility migration.
> +         */
> +        __set_bit(X86_FEATURE_VIRT_SSBD, hvm_featureset);

This means even Intel guests can use the feature then? I thought it was
meanwhile deemed bad to offer such cross-vendor features?

Additionally, is SPEC_CTRL (i.e. IBRS) availability enough? Don't you
need AMD_SSBD as a prereq (which may want expressing in gen-cpuid.py)?

> --- a/xen/arch/x86/include/asm/msr.h
> +++ b/xen/arch/x86/include/asm/msr.h
> @@ -291,6 +291,7 @@ struct vcpu_msrs
>  {
>      /*
>       * 0x00000048 - MSR_SPEC_CTRL
> +     * 0xc001011f - MSR_VIRT_SPEC_CTRL
>       *
>       * For PV guests, this holds the guest kernel value.  It is accessed on
>       * every entry/exit path.
> @@ -301,7 +302,10 @@ struct vcpu_msrs
>       * For SVM, the guest value lives in the VMCB, and hardware saves/restores
>       * the host value automatically.  However, guests run with the OR of the
>       * host and guest value, which allows Xen to set protections behind the
> -     * guest's back.
> +     * guest's back.  Use such functionality in order to implement support for
> +     * VIRT_SPEC_CTRL as a shadow value of SPEC_CTRL and thus store the value
> +     * of VIRT_SPEC_CTRL in this field, taking advantage of both MSRs having
> +     * compatible layouts.

I guess "shadow value" means more like an alternative value, but
(see above) this is about setting for now just one bit behind the
guest's back.

> --- a/xen/arch/x86/spec_ctrl.c
> +++ b/xen/arch/x86/spec_ctrl.c
> @@ -395,12 +395,13 @@ static void __init print_details(enum ind_thunk thunk, uint64_t caps)
>       * mitigation support for guests.
>       */
>  #ifdef CONFIG_HVM
> -    printk("  Support for HVM VMs:%s%s%s%s%s\n",
> +    printk("  Support for HVM VMs:%s%s%s%s%s%s\n",
>             (boot_cpu_has(X86_FEATURE_SC_MSR_HVM) ||
>              boot_cpu_has(X86_FEATURE_SC_RSB_HVM) ||
>              boot_cpu_has(X86_FEATURE_MD_CLEAR)   ||
>              opt_eager_fpu)                           ? ""               : " None",
>             boot_cpu_has(X86_FEATURE_SC_MSR_HVM)      ? " MSR_SPEC_CTRL" : "",
> +           boot_cpu_has(X86_FEATURE_SC_MSR_HVM)      ? " MSR_VIRT_SPEC_CTRL" : "",
>             boot_cpu_has(X86_FEATURE_SC_RSB_HVM)      ? " RSB"           : "",
>             opt_eager_fpu                             ? " EAGER_FPU"     : "",
>             boot_cpu_has(X86_FEATURE_MD_CLEAR)        ? " MD_CLEAR"      : "");

The output getting longish, can the two SC_MSR_HVM dependent items
perhaps be folded, e.g. by making it "MSR_{,VIRT_}SPEC_CTRL"?

> --- a/xen/include/public/arch-x86/cpufeatureset.h
> +++ b/xen/include/public/arch-x86/cpufeatureset.h
> @@ -265,7 +265,7 @@ XEN_CPUFEATURE(IBRS_SAME_MODE, 8*32+19) /*S  IBRS provides same-mode protection
>  XEN_CPUFEATURE(NO_LMSL,       8*32+20) /*S  EFER.LMSLE no longer supported. */
>  XEN_CPUFEATURE(AMD_PPIN,      8*32+23) /*   Protected Processor Inventory Number */
>  XEN_CPUFEATURE(AMD_SSBD,      8*32+24) /*S  MSR_SPEC_CTRL.SSBD available */
> -XEN_CPUFEATURE(VIRT_SSBD,     8*32+25) /*   MSR_VIRT_SPEC_CTRL.SSBD */
> +XEN_CPUFEATURE(VIRT_SSBD,     8*32+25) /*!s MSR_VIRT_SPEC_CTRL.SSBD */

What is the ! intended to cover here? From guest perspective the
MSR acts entirely normally afaict.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 15:13:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 15:13:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272409.467237 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJd2C-000433-02; Mon, 14 Feb 2022 15:13:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272409.467237; Mon, 14 Feb 2022 15:12:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJd2B-00042w-T5; Mon, 14 Feb 2022 15:12:59 +0000
Received: by outflank-mailman (input) for mailman id 272409;
 Mon, 14 Feb 2022 15:12:58 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qPn=S5=citrix.com=George.Dunlap@srs-se1.protection.inumbo.net>)
 id 1nJd2A-00042q-Hn
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 15:12:58 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9615e956-8da8-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 16:12:56 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9615e956-8da8-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644851576;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:mime-version;
  bh=J4LMMZs8RpC/2S6kfTeWrHFU9i3oeHB3Ei77y1GUEos=;
  b=Zx1K5A8vgQU1E2es0fP5G549+u59/XGjljlBdVDW7IkuA2pc0ZZFNiTs
   QAo6nuK5E4oZfQH8xTlrlNIMs4FjVf0MT+mdvJo50K567CaCbkB11aE/T
   1ekB6sNjpky/RGt9zbn1ebaojSYaMCHk+5gdijnP/i81gYCjP1jQ8D6Ss
   I=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=hardfail (body hash did not verify [final]) header.i=@citrix.onmicrosoft.com
IronPort-SDR: /GTN7gG647DFo7IyS58RPp7v+teqANUNWKd2u0SCon/bvIhZCmmTB+5dTS2FbstEn470I9vgQ5
 pvwshnniEa78BOsB/PVWo78NRn0OF9U3dgJscvT9fbxhTas1tE4ShSCnYgODizkLY7PBKEgrv3
 aDhZfsrX45K6D9XtGkN68z9rWmK2udFJO+8hITJAZ48a0upZn5epXPFDkgCC6XaDpNfwwonB4n
 7CiNSUEnWCi40NZN5TuA+dqfVLU7+493Scd2vZDrHdLi0dSXjfu1TNdgB54d91Wq3ayUrs4JdO
 VEcQfiH6vLRsk2/MdVHquaZN
X-SBRS: 5.1
X-MesageID: 64568127
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:LIa7n6g1YbTBVrVYDNKV1RnRX161bxYKZh0ujC45NGQN5FlGYwSy9
 lOraxnFY6jUMyawOYxoOc7lxf41yZSGyNFrHQJr/n80EytEp5OaCdqQdhuqYCmfJMPJFhw6t
 cxOZtCccZpuQyPV+hn1PuSw8SZy2PjUGrCiA76cZioZqWOIMMsEoUsLd7kR3t446TTAPz6wh
 D/SnyH+EA/9h24raTlJ4fLa9Bk2t/qusmlD7lAzbq5F5wSFxiBJXc4Tfa2/ESD1E9JedgKYq
 0cv710bEkfxpUpF5gaNy+6jGqEyrzq70TGm0hK6YYD76vR5jnF0gvZT2MY0Mx8N0W3Txowpk
 r2hiLTrIesXFvyU8Agie0Ew/xFWZcWqL5eefBBTGeTKp6H3WyOEL8dGVSnaDqVBkgpDOklc9
 ORwFdw4Rkvra9RaYl6MYrIEaswLdKEHNW6E051q5Wmx4f0OGfgvT0hWjDPxMfhZas1mRJ7ji
 8QlhTVHRQ/cYDtpAWYuU9E4gsKyvnPfdgIftwfAzUY3yzC7IA1Z1bHsNJzee8CQRNUTlUGdz
 o7E1z2nWFdAboXZkGfbtCL37gPMtXqTtIY6O7C/7PFnxnGOwGgaEDUdVEehoOn/gUm7Mz5aA
 xJIp3R+9PJtnKCtZtj9bR+Z/yaDgkdCePdpH8kas1ynyIOBtm51AUBbF2UcObTKrvQeWTUv3
 0Shg9DtCDpgobCRD3ma89+8pDKpMCkRJEcIZDMIQAUI5dXuusc4iRenZs57EbS+h9n8EyzYy
 TGWoCUwirMfgNRN3KK+lXjlqT+xopnCTiYu+x7aGGmi62tRdIOjIoCl91XfxfJBN5qCCEmMu
 mAenMqT5/xICouC/ASSRM0dEbfv4OyKWAAwmnY2QcNnrW70vSf+I8YAu1mSOXuFLO4tYiPqR
 mnoiDoKp5lNGWGSZ49yXMWuXpFCIbfbKfzpUfXdb9xra5d3dROa8CwGWXN8z1wBg2B3z/hhZ
 M7zndKESC9DVP85lGbeq/I1jOdzrh3S018/UnwSI/6P9bOFLECYRr4eWLdlRrBotfjUyOk5H
 js2Cidr9/m9eLCkCsU02dRKRbzvEZTcLcqow/G7jsbZfmJb9JgJUpc9O48JdY1/hLhynezV5
 Hy7UUIw4AOh2SGYeVXXNyg6M+mHsXNDQZUTZ3JEALpV8yJ7PdbHAFk3K/PbgoXLBMQ8lKUpH
 pHpiu2LA+hVSySvxtjuRcKVkWCWTzzy3VjmF3P8OFAXJsc8LySUqo6MVla+r0EmU3vo3fbSV
 pX9j2s3t7JYHF88ZCsXAdryp26MUY81xr4jARuQeoMLEKgumaAzQxHMYjYMC5xkAT3IxyeA1
 hbQBhEdpOLXpJQy/sWPjqeBx7pF2cMndqaDN2WEv7uwKwfA+W+vnd1JXOqSJGiPX2Lo4qSyI
 +5SyqikYvEAmV9Ltat6Eqpqkv1it4e++ecCw1Q2BmjPYnSqFqhkfiuM0/5Qu/Af3bReowa3B
 B6Co4EIJbWTNcr5O1cNPw55PP+b3PQZl2CKv/Q4KUn3/gFt+7+DXRkANhWAknUFfrB0LJkk0
 aEqv8tPs16zjR8jM9CniCFI9jvTcixcAvt/7pxDWd3lkAsmzF1GcKfwMC6u7cHdcchIP2krP
 iSQ2PjIiYNDyxeQaHE0D3XMg7ZQ3MxcpBBQwVYeDF2Vgd6Z1OQv1Rhc/DlrHARYyhJLj7B6N
 mRxbhAnIKyP+3FjhdRZXnDqEAZEXUXL9kv0wloPtWvYU0j3CTCdcDxjYb6ArBID7mZRXjlH5
 7XJmm/qXAHjcNz1wiZvC1VurObuTIAp+wDP8Cx98x9pw3XujeLZv5KT
IronPort-HdrOrdr: A9a23:zcCeSqN/smnxucBcTsWjsMiBIKoaSvp037BN7TEXdfU1SL39qy
 nKpp8mPHDP5Ar5NEtOpTniAsm9qBHnm6KdiLN5Vd3OYOCMggqVBbAnwYz+wyDxXw3Sn9QtsJ
 uIqpIOa+EY22IK7/rH3A==
X-IronPort-AV: E=Sophos;i="5.88,368,1635220800"; 
   d="asc'?scan'208";a="64568127"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=QRVsAmopmxnOt+F73iGa0QKDz2M/zEsKXJM1dOEjmtokyy+X2h2+lDZhTJ/WqPImIJy6jPSULMBHlesT7onD/AE2gKnLr7AVYwj9ERDWGrQbB7aL6YYcA1vRbybcmucgugxCxqoyXK6OdPqKiApSERk7mEKf+CjeKxcAM/GhtrB3Eer0GlU1OXxpwGnucdv713Y1aM5SgmxVWjw9ghoCAQd21cnhGrMl+o7sRF7FYrIdPFyOTbfhlLW6bsxLwVQ5Y7Hv1rlttKwn1/iqcaS9ky5BpXCoKYiuQ02y8SFuZ3yF9n/sd4isqc3hfHr8+JaxECzGEyUOjtRhCHunJ2j/2A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ya0w5Pm8lt2K4enA1pVPf8WWJQx24SVk5IOLZ248c+8=;
 b=FwqCHiPpCxWbr2nwLxQkNvdH9nUj+whJe5s1rzq2b8ighvwubvYADFqnHZc1cLnEL93X2gqGe6eDNlFuHFOukOOYKFhYdjL49vtcUXVD3Zuu+7HKTwi5mx1uCIqFKu86IAOF5yU4kBkdykDXEbDOHstfAOOpzUiixhEzpyhZUWmknFnATuVoiZao8WQxFmSG74/HHTjDD/2WGS2cUz88Se02D5MoqNdRwZHxbpe3acQYeedEli6pqaHKFjSceOF4OD2ZI+0H5AakoMbB4FaPRxCku5yv63NCXU0E13p2gn05CrJ6WcvIpWwgZm7kETAIVLmH76CRPbViJqvz9pehBw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ya0w5Pm8lt2K4enA1pVPf8WWJQx24SVk5IOLZ248c+8=;
 b=uFoq7hXXqmLDmvUsEbKSlf5GzddU6/9bUX/vcexyJvsmP/3+BEl3t5OG8byji9hesNoDSuI8NUxPDo6y+P/7Lg0fs/kKfXvhRrnlWa+0wZ+PqZ7YgREEfxDOX7tAfeMDGJwBThEWFN5xN7B2R9GFJYGxpzXbqb4UGhu2+DcF4W4=
From: George Dunlap <George.Dunlap@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Andrew
 Cooper" <Andrew.Cooper3@citrix.com>, Wei Liu <wl@xen.org>, Roger Pau Monne
	<roger.pau@citrix.com>, Tamas K Lengyel <tamas@tklengyel.com>, "Alexandru
 Isaila" <aisaila@bitdefender.com>, Petre Pircalabu
	<ppircalabu@bitdefender.com>
Subject: Re: [PATCH 11/16] x86/P2M: derive a HVM-only variant from
 __get_gfn_type_access()
Thread-Topic: [PATCH 11/16] x86/P2M: derive a HVM-only variant from
 __get_gfn_type_access()
Thread-Index: AQHXcbiZRXYa712FeEi5bV+pycTuo6yUhy4A
Date: Mon, 14 Feb 2022 15:12:51 +0000
Message-ID: <1E368B6E-A3E4-4A43-8CBE-6213D302C6F1@citrix.com>
References: <d1fd572d-5bfe-21d8-3b50-d9b0646ce2f0@suse.com>
 <a940e734-75ae-2660-7b2a-9b426437c48a@suse.com>
In-Reply-To: <a940e734-75ae-2660-7b2a-9b426437c48a@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3693.60.0.1.1)
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: dc50b30c-20dd-4a08-36f5-08d9efcc7805
x-ms-traffictypediagnostic: BYAPR03MB3863:EE_
x-microsoft-antispam-prvs: <BYAPR03MB3863DBF6DF018157F58D82FE99339@BYAPR03MB3863.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8882;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: pjQ99VqkvfYqOrK/hYFhgBl5dbVQ7Z2wPHTyq5kCb0vW4pg+kgA9DA2ubqlZ84Eb6F1y23CDTlOoubluChSUaNRE57edqlAl0acyCQhV2p89FmyZ72dMzXw7HceeCaqWKoz2NDc59cajoAnsa7jtNitpC1GnJR9Js4bZUOlOo5BKAb4y7EA09+k0siOgV44gDC6qnKKgFF7WlWEQ1/U6rg6MMVXvj6ycC/pmuffPdsjVFabFAlXig/4xt45HZjVZEpvKuNnFQj59sj4fI7gjtfIr/4ATT8o7HSZtBL3ZIMGFaWqH/ec0NOiVKdAJG+qBWlP+FrT4uFsztvV7c/ZgyyYupLpl6YNtxplBzubnqVZyaLzOhN/PmWB1uByeANnPsDO4zKVcXZPNGUfUkfL4TN1/FJKe0B26sw2Z6O/IN8QRBRIAeynEYofcNnkPDIHdjjkC2TvulHTxnBuh51n8oexLLSte8/CquleCCx6HgyGcFiXXfUPrLUSRaMFz6QLm45qw/YeKJj9kIYVHeDb5KmIO43Edu/RMkiOEc60sm0jRNFW3pfSpUJQ6e15eEjtmGIlDqCtvhUOFkRDnDyd9HnZ7H19RTuKarYkfUthATezOC3aZgbgE0+fdM15HsJDUyIcgXyB3yjcPn4xdtpP5wMFUW3yOTN+nxBv4KYWaQbJQUu6SrXl/jWEkVJDCPS7BxfcYiN95/ejTeDobt/3m1FuSniMxQTCZRW5dtLoADAc4Oe+tHOskfCnIcR/MNQbU
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(99936003)(186003)(4744005)(4326008)(8936002)(66476007)(66946007)(66556008)(66446008)(64756008)(2906002)(5660300002)(38070700005)(76116006)(91956017)(33656002)(36756003)(86362001)(8676002)(82960400001)(122000001)(38100700002)(508600001)(83380400001)(71200400001)(6512007)(2616005)(26005)(6486002)(316002)(54906003)(6916009)(53546011)(6506007)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Y0ZETThYYVZIRXp2eGtEeHRKV3AvUk1WMUpEYVFvdlNmQkV6MVVLSEVjbC9U?=
 =?utf-8?B?ZWFsSzZ2NGI3Um9MVFhnb3Z3M2d3d3o2WTVFeUliLzlGTlloWGxVc3RLQTU5?=
 =?utf-8?B?WnpvK0RKc0VoOXNMSW5ac2tYUTVzZUdKdklPcEU3RzZXU2ZSZzZCTnc2WVY2?=
 =?utf-8?B?VFpYbm0xYUtINHdrSGc3NEowTVJISzY4Q3VweG1RTmZ0VElUV2xSczRGQTV3?=
 =?utf-8?B?akl2MFhucHpEQ2dlb0dvV2FRanNzVkE1bUc5MEdWcmMyWU52VWFWZjVEK0My?=
 =?utf-8?B?bkhQQmRtMmFFck5nTzc5ZFlIQ2VVcnNXQnRHU2RDZEhHWHVHdVRJOXJuUTRj?=
 =?utf-8?B?UUNMMEtjN2paK1ZNcHd2b2Rma0dKZzZxRm5LdU5sS3VXTkRyeUxVbG12QmtO?=
 =?utf-8?B?S1FYdTVWY25Fb2F5TVJWZ2xUY1RFcEFlVmZJbzkvdExCWWhxa3IvQndpVjZG?=
 =?utf-8?B?aFZrYTJYMzI3MW14eUZzRzJObVEyZjNmQ1l0VHdJNlgwYjFpbmdsQWlGV21U?=
 =?utf-8?B?QWkxdE13VDBjSTlkSERxemVTcThoclQzNHhQMWwwU1UxUmN1LzVxN3VUMlBW?=
 =?utf-8?B?bGFpN1ZPQy91SUJXbGY0UUhBUFpYamhHOStRa2R4bDlob3hnMmJQYWJFb2E3?=
 =?utf-8?B?RFZMTkxrWFFMOVNiWEtONVplbXZ3dm1acVVPYnhQVjF6N0JXMGIxeWE1OXIw?=
 =?utf-8?B?RjZHUUI5bEFGRjlsbjR3ZVhPL0kxVE45ZlNCR1ZtWHBrcVZmK0xYOGg0eWVR?=
 =?utf-8?B?NWo3NHE0Q0pVamZxMVFrN2lhUitjY254OHpLWGcvSm5vMHVXNStmeVNGNmYv?=
 =?utf-8?B?aUZ5d3ptQ3A3NXJzQy8xMUpTMFN1MnRnUFd6RmMzVTFHZk5rR0EwUUg1M3lp?=
 =?utf-8?B?djBybys1L1N1SEkrRlFHa3ZHUUI3ZS90ZnN2R2dXako4eitCcDBMWm1oRlhj?=
 =?utf-8?B?cFFDRG44ZmNhN2dEbVBhT21HRWEvd0EwRFNiTVhqS3d3NGJzakhWU3FWaEpv?=
 =?utf-8?B?TVdXVzFpMkJzRWMxNVY4MmJMNHlERlI5c0RIbm5yUERBcmdkTTdJRXpwaGdw?=
 =?utf-8?B?OUE2U0dzVVgxTUc5WVN0R3hid0sySi9XTmFObklPK0F1a3FtcnFKeHZTQ3NL?=
 =?utf-8?B?SG1pakhSbTRudDJSbVdaRkFKWlRkdGw5aWNRMllXSmJVUEM2bFVldHlUUWxK?=
 =?utf-8?B?dk5zYjNjN1kwSzVydDVTbHdtK3c0aHB2QzVNbXhyN2RHS3JHa25MamRKbXMz?=
 =?utf-8?B?cWp4T2hiMnJoV3FHUHZxYjVSYkVwZVFGNm1ML2h3TEtuRjFqNEF4ek1VZXJZ?=
 =?utf-8?B?TnRhZzB3WjBuZG1XVllZRVVWZElwK3o2U01oT0NnN3FGN0tySWViSTVuM1p0?=
 =?utf-8?B?UFFiTUVPZ29LeHZwZ09WenlRK0w0UkhPVUxjeXZUcXpTRThsSUM4eWxsaUNP?=
 =?utf-8?B?SFFBVkdqWWM5TDRxdUx3SCtpWXRMeFgxTXlmc1FNanpNc3NSNUFYVHR2TjUy?=
 =?utf-8?B?WWU5T0I4dXdHWEY2VWZMVHJQWUx5YVBDTXgwWFVyMHJOaDREWloyS0ovS0pB?=
 =?utf-8?B?c1FpaG5LKzlQQzJ5eXBHUUpLZnpXN3Yvd3BUU0F2cnRUZndKalhwcklQbDZu?=
 =?utf-8?B?ek5ZZ1RBQm4wTW5GSUFoVUVOYVRpVkZlK2dhZWJQbSsvMU1sdDh2ZVBOdG1T?=
 =?utf-8?B?WjVsQ3RsUS94SFhmVXpHUDZNL1EySnAvNTBaN240UkcvMW44MUtmWndDa3Fs?=
 =?utf-8?B?YjhDWVBTcEliMVVTcnMwaG9xTzk1ZEpwbjZxQ3hKS3dPYVNIY08yT0lLNXdz?=
 =?utf-8?B?bE96c212THFmdERKUi8xbzQwM21salZrektPYlBINE5PR2MyKzBOdW5wSFRP?=
 =?utf-8?B?VFh2bjZ0aDlmTUNjZUZ4Z0Y0Qk1CU09xS0tzSjJVdERXaEswMGtxTldYMCto?=
 =?utf-8?B?Z1ZaTUdoWWpFeUVDeDhQUEhOYVl4ZjR0b256T0FYWmZRS1E3MGpBTHhaaHds?=
 =?utf-8?B?Qk84RVA5ZTJYQzRlM0JYUnFweWZ6VG9HeGJHcnpMNFdkVjFaZHltUUR4dHRZ?=
 =?utf-8?B?aEJaaUVMOW5DY3NBbHBsREU0NklPUVVTZit4QXUyZldiZEk4TUgvWjdjQmhY?=
 =?utf-8?B?eXhhY3JUTkl5WHBLaFBud3g5cExrTWNpNWlzUDc3dTVTSlBaOHRHYkE3OGYz?=
 =?utf-8?B?UkMzL1psWGVXUnlTbUpOQjFzVk1CMkd5ZzRDK2pFR1V0NHltUDAwdWQ4bktJ?=
 =?utf-8?Q?/kaBdpgsXqzbODbhEsmvnLZAzZqv9zNuK8T100MSyI=3D?=
Content-Type: multipart/signed;
	boundary="Apple-Mail=_A0C6E35E-7A05-4186-86A8-B3E2BE053133";
	protocol="application/pgp-signature";
	micalg=pgp-sha512
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dc50b30c-20dd-4a08-36f5-08d9efcc7805
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Feb 2022 15:12:51.4204
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: WVKk6Fypd0Kg4A+d27cqy8yJh/Xyo+kPNanjY2+bz0+9nXPykmjqCVUAl7YlrWJcDXXJIM0IZm5CSHA+qGm6IxC7KGZhKyPofzZdgwCRft8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB3863
X-OriginatorOrg: citrix.com

--Apple-Mail=_A0C6E35E-7A05-4186-86A8-B3E2BE053133
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8



> On Jul 5, 2021, at 5:12 PM, Jan Beulich <JBeulich@suse.com> wrote:
>=20
> Introduce an inline wrapper dealing with the non-translated-domain =
case,
> while stripping that logic from the main function, which gets renamed =
to
> p2m_get_gfn_type_access(). HVM-only callers can then directly use the
> main function.
>=20
> Along with renaming the main function also make its and the new inline
> helper's GFN parameters type-safe.
>=20
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Nit in the title: I read =E2=80=9CHVM=E2=80=9D as =E2=80=9Caych vee =
emm=E2=80=9D, and so I use =E2=80=98an=E2=80=99 before it rather than =
=E2=80=98a=E2=80=99; i.e., =E2=80=9Cderive an HVM-only=E2=80=A6=E2=80=9D

I feel obligated to mention it but I=E2=80=99ll leave it to you whether =
you want to change it or not:

Reviewed-by: George Dunlap <george.dunlap@citrix.com>


--Apple-Mail=_A0C6E35E-7A05-4186-86A8-B3E2BE053133
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="signature.asc"
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEj3+7SZ4EDefWZFyCshXHp8eEG+0FAmIKcWoACgkQshXHp8eE
G+1Sagf/WBs6HEbDQXnFX6nC78dTkRaShDGlN/xALtYEeIgbDHmvL8nLB3RGOJ3n
EAWmIcWPXlKaGwBFPsJbOc9rQHXW4grTClBIZGYXrsoURl2kf1rDRo8fYIO1YtcJ
exMoxyeAs/5eEynOh1l2CyNS2cJxgEH6AhjbYQIBYHvXVs/WajYsgNGKecX+ILAf
/HBvu1B7kefQJlyAbyL6dRVH020rIWKqgHFCVhc4bQY83djsI6Ac4IxwMYxabL/1
CrTxlK9DqY5lsx9Y3WvcZ8HPtcim8mtVjJGqvxhaFbDfmRGIY10xyTdkaTmIDRN/
bwLm2QRHz3LC53WPIvpfxD/pF0zftA==
=5lJg
-----END PGP SIGNATURE-----

--Apple-Mail=_A0C6E35E-7A05-4186-86A8-B3E2BE053133--


From xen-devel-bounces@lists.xenproject.org Mon Feb 14 15:15:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 15:15:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272416.467248 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJd4k-0004eo-DS; Mon, 14 Feb 2022 15:15:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272416.467248; Mon, 14 Feb 2022 15:15:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJd4k-0004eh-AS; Mon, 14 Feb 2022 15:15:38 +0000
Received: by outflank-mailman (input) for mailman id 272416;
 Mon, 14 Feb 2022 15:15:36 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KkXt=S5=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nJd4i-0004eb-Au
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 15:15:36 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f52255b2-8da8-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 16:15:35 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2051.outbound.protection.outlook.com [104.47.14.51]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-22-hn29n2k-PYq4HChjpVap0Q-1; Mon, 14 Feb 2022 16:15:34 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM7PR04MB7160.eurprd04.prod.outlook.com (2603:10a6:20b:119::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.18; Mon, 14 Feb
 2022 15:15:30 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4975.015; Mon, 14 Feb 2022
 15:15:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f52255b2-8da8-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644851735;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=iEXMCj3DYSDyqC/ONxWqA1mSUSxmSKF3BwnJoReKvWM=;
	b=ll+mrCx91PZvFoWbZ7ElF/gleCbiaMvg0gwCxz8LweyFBBRT/rEMCOT6/t8mT04fbzaLLm
	D+uleISJdvTAmT3HD7fs7ETZx/iCMw+Eku9Ze9v6p0yiGy16dgZrhZeFDiifkkK2V7MD5/
	FacFz/FzQKttUPgKvxEERKYQZYitZ8k=
X-MC-Unique: hn29n2k-PYq4HChjpVap0Q-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=FsHL6IoSRczhgSeKozUKAbrPM7Nb67Kqwq0/MMsqkQwKU2ZvEGl5d6rJRvXsGOnl3kisyi0kU+iP+EVfTI+nIQcgHdJVFBhtw+y13+H2fNhqhBCqd9WR5jiIAlSw6F3O34xFG8mgkhOluySap7n7tNATVddjuLbYWlZWnI4f616BRPiw1Sfmf6Xs2MP2XM2/VzcARp865IWl8RN1rvh471SZqOkr42lcdaEGYU4tWWZ9cFqO8+b1c8WfVlMf09OKwtWGUeNKbZEQ2R3//CLSvRTRtpJY7NY8IZv4pcBmZpIYxcdluZbVSvMxzCGrPtKCHDWDeUHvl1fPnULlnGbdRg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=FLsVGs84Z5dydf1b5ztBFdYdbymEGxDfTpQ7HTwM0DE=;
 b=XG6ZltovLx3ZyNfS37iD1wrNyr4eXf8DD88RLIOj8+695+F+ioYXn9PkOZlYmuWORNeb7A2dSqNajMWRNEdbCWAMxv2JyC3XKyc9+D8zadXk7vEB0KnLlm6CChvne4CU1xWSqDPiVDUOIGRySOePNGD+PEyAZlcMo77KPjjTashNpDi2QtAIOFK28aXgUVEYbYORKHqTHB0Vu2EnYXDqyXs4ZZlQfgGWAUdka9m1TdWcFpUVflguNuCUj+SVcWIsFkvT1sLENnbQmkksrwMQ0In/ZvAhXAbJ+ZLdjyTLdLt/lG+8KblrFDTOgc+NTqjE0JgstkauYj7Ve7XOrDyZbg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <eea4e9ce-3629-62b4-4c93-efa78fcc5bfc@suse.com>
Date: Mon, 14 Feb 2022 16:15:27 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: SecureBoot and PCI passthrough with kernel lockdown in place (on
 Xen)
Content-Language: en-US
To: Dario Faggioli <dfaggioli@suse.com>
CC: "sstabellini@kernel.org" <sstabellini@kernel.org>,
 "marmarek@invisiblethingslab.com" <marmarek@invisiblethingslab.com>,
 "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
 "anthony.perard@citrix.com" <anthony.perard@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <8daad0f6c623a57bc0b047fc2388e8b698135624.camel@suse.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <8daad0f6c623a57bc0b047fc2388e8b698135624.camel@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6P194CA0002.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:209:90::15) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 11aacaa3-c20c-4d48-6903-08d9efccd64d
X-MS-TrafficTypeDiagnostic: AM7PR04MB7160:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<AM7PR04MB7160B2B32B1CFEB969106F90B3339@AM7PR04MB7160.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6790;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ePsL/quWb3HzQba+REARBu0vCw7jAHID1cIqyLJeruTupmwA+nej9kUJY/TvSqldSGrG/a39f0HYNVnHylK6URHAOc92TjZfa9+T4/J9iSZ6j7thjRzYAO1bnMLtQYp7vn4AXXG0MPa/eYj1F+BMYx0BAZ4aLo/hekv0L8w1zOVktGSdhVq8iCZEnhV4Ta1DLBn1vwX81JK+oHG3s0ng7iqhl5N0g+rGV/WLUXjjZAQux79RZ0vVWFS/81/NjzsxZaw7gBW6E7pbeDODGaSc/HwYZr781BofheIoPku2+/bM4pLwQ0Lx51ZZI1kplBbOfYkiAMGsszZ+XEie9rLye/wN+4FkVQAa80bWd9AyWJzqYcNoSihwL0OzFlech2JWIl/LL/qcH31kMrAhuBoHD1ei0C5AKNQ0NEnAzzG1cNh07HbTlkpit9xU7c10LkjtVA3xxWYDfaAAgBWEF6+TCsrIFxD/9U13/Y+/fPBe9K622WDNkOI2c4yZJ8HcGIY2VX1hQg+G5Et2ucqJSepL3DUewhXhRSgeLVl1FvBI5yNMZTbRvGSTcubaTEEA+A8A1IUuKtZOxmlXpHff1/Y/CDV+G4EtQqysGCbI9NlPv6ke31oOcwRLQZ/1mxk+8KcoZVYp8plm3b+R9UM6RLqO/mAQpmUwnN2+PmpC28GxiVDdPn/KYxbJS1t3ZYt+XAoNwuutz9kXLCgUc0DNPGbUb/rDWYT9q08WPq9CkS857wE=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66946007)(66556008)(66476007)(6512007)(38100700002)(31696002)(6862004)(5660300002)(8676002)(8936002)(6506007)(53546011)(4326008)(83380400001)(54906003)(37006003)(2616005)(186003)(26005)(508600001)(86362001)(36756003)(2906002)(316002)(6486002)(6636002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?gQZTdsT6gW7Leeru4i/p5v/lmNqiY+TGZo3qt9ix9VtkpdmC9CxlKnf/AJVZ?=
 =?us-ascii?Q?VogA1g+L7uTUuJ0wGxM7E4nQeV/I8MfB8VnYQyou4C1MjmwBeQXbid6MXEYt?=
 =?us-ascii?Q?szAFtLJ8W1qZu1dDAnj+Zojd0TuG0HbdJnzTsNxYb8BG+8W2L+0W2tijcThY?=
 =?us-ascii?Q?1R9O7ZfBW5W8llPcaWzxjO9xSyFRWCvI9KtTPYW03CrFGl1TbKj0wqoejqjo?=
 =?us-ascii?Q?835RxY/i2zIAGwerdfSqih5WMjYiGIUb0H/9872kAVV+6smEs/FO+JhzTDhI?=
 =?us-ascii?Q?qAZYxs0y+trJm+fyTSIVrKcQFAsvwx/qFGHVEcy2gOAn/0Pd8q2c/W/yFyDZ?=
 =?us-ascii?Q?/gDmVkHN/E2QeOaMUtyfD338ccHvRtwg2BwvYUPShCmGlsrBqltN6y7TgAT5?=
 =?us-ascii?Q?kaYMZNrXbR6g/naR0skxY3MX1xNGzJbqINpPVzuc6hfYlM1WyD4UOKudGOYo?=
 =?us-ascii?Q?NQD7oL+4yQaSEHtQfn0HrhTgd2QNBAyl72Mnaf9ayiRaGS6HMkDaqRTzcBDx?=
 =?us-ascii?Q?hWX+yhWX3PF3GcnZ9hfLCN4CjHsyPPC4TvnHLO6m0rpGZ0cE2X0qbPN/SaVt?=
 =?us-ascii?Q?m1ngu7mfcIAoDL2dTCZAHDBiW2VNKIW1l1tmjpaiwZV7aDqmgcGy1bbSELU1?=
 =?us-ascii?Q?XSk8DQsxM9ZfDPb2EEt6WHDtjVvucbNLm16AM+hEJn1i2Et813oRkMaSzcKS?=
 =?us-ascii?Q?hEZqhd41ozgxm4zbeSeqlL7EQlMP2sOJgck2Jo+nPqHl6ykRtj9VRsnYAYj1?=
 =?us-ascii?Q?fA9OOqAmGzAGgEe58MBQYwVFwd9IShNkrjnafYQSgaJAoPNo+7rGbFHImPs0?=
 =?us-ascii?Q?32Mw0bL6sAIXYE31Go9N/YwfdNBZCuG/PhlhXIHG3Yq44cdHkewpX0rTvarQ?=
 =?us-ascii?Q?tnnrr3M7LZE+DUgdaG+OM/3r8MFqeqwblBgasQSeKXnsmz1jhViER+dU7aEx?=
 =?us-ascii?Q?tcO8qMRKhR4FTjexf5EZR482N3kY0IJrqGACqIcF6Iva6WJpIGglzHpvEyse?=
 =?us-ascii?Q?jrBnmi3Kk/ue3Ji+bMe5dnJ2fbFt3plI8xRyD+89a8KozaWVPEc30SfXiD2o?=
 =?us-ascii?Q?JWvJl2zGQUP7EyVv29JPZhG7WiqP58K/ZF4761c14F8ET5SqeyBXJVMLhp26?=
 =?us-ascii?Q?B0UJfI8Zl/X8YQ/ZEOLu2/L87M4pEhKDx0sbuIVgkV4GQ99bSIaaJuEAE0To?=
 =?us-ascii?Q?t1sZfx/qdd3CIdQZqux8vp7sJa9C7RpQ3x8zllnVcUFjvPAQNdY6Jr2pU9Kl?=
 =?us-ascii?Q?EwumS8/e/UkzMwZtHOjGmdp0/BdsM3YP6Jn5KSIxI0Jq+YFL0LX8EMtVLKno?=
 =?us-ascii?Q?R1k8QSRRrE2QhFftNk12LShxIs1Sj36KGQ6XVdCla0YYZTr7GMeg5ucrH0Fb?=
 =?us-ascii?Q?kgKg1b4lgPMUmO7RSNkbtcOvaj5nXlzCz1MH6cV4xIuIVXtql1lidjWSHlp4?=
 =?us-ascii?Q?vdedfDrN7KMjLOB/6ahuWIziDQT4+flb4bNFKyNHFjEkCTwEvpxSwzXNBYBS?=
 =?us-ascii?Q?l8zIq93EJZnvGVYqgmvarpIdAxiHIJHHKI1uD3PHrPfjGCq7M+Gvk5Z8nRoQ?=
 =?us-ascii?Q?TamjkONNF0nqcwQLc/zKxjYNzH9jD2oSTGhXzF0XY9P93Yke/3XP5QRj9BHY?=
 =?us-ascii?Q?haT3YKuEb0dlXabSZMXzJS0=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 11aacaa3-c20c-4d48-6903-08d9efccd64d
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2022 15:15:29.9118
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ReOnZP3NYrV5JgPm8oY5ipHEs4Wj7hflorl4kdUgq2MriCMSUb3cxxIfd3zwbRnQKonjIMabmAJmKJdNncWRRQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB7160

On 14.02.2022 16:02, Dario Faggioli wrote:
> We have run into an issue when trying to use PCI passthrough for a Xen
> VM running on an host where dom0 kernel is 5.14.21 (but we think it
> could be any kernel > 5.4) and SecureBoot is enabled.
>=20
> The error we get, when (for instance) trying to attach a device to an
> (HVM) VM, on such system is:
>=20
> # xl pci-attach 2-fv-sles15sp4beta2 0000:58:03.0=20
> libxl: error: libxl_qmp.c:1838:qmp_ev_parse_error_messages: Domain 12:Fai=
led to initialize 12/15, type =3D 0x1, rc: -1
> libxl: error: libxl_pci.c:1777:device_pci_add_done: Domain 12:libxl__devi=
ce_pci_add failed for PCI device 0:58:3.0 (rc -28)
> libxl: error: libxl_device.c:1420:device_addrm_aocomplete: unable to add =
device
>=20
> QEMU, is telling us the following:
>=20
> [00:04.0] xen_pt_msix_init: Error: Can't open /dev/mem: Operation not per=
mitted
> [00:04.0] xen_pt_msix_size_init: Error: Internal error: Invalid xen_pt_ms=
ix_init.
>=20
> And the kernel reports this:
>=20
> Jan 27 16:20:53 narvi-sr860v2-bps-sles15sp4b2 kernel: Lockdown: qemu-syst=
em-i38: /dev/mem,kmem,port is restricted; see man kernel_lockdown.7
>=20
> So, it's related to lockdown. Which AFAIUI it's consistent with the
> fact that the problem only shows up when SecureBoot is enabled, as
> that's implies lockdown. It's also consistent with the fact that we
> don't seem to have any problems doing the same with a 5.3.x dom0
> kernel... As there's no lockdown there!
>=20
> Some digging revealed that QEMU tries to open /dev/mem in
> xen_pt_msix_init():
>=20
>     fd =3D open("/dev/mem", O_RDWR);
>     ...
>     msix->phys_iomem_base =3D
>             mmap(NULL,
>                  total_entries * PCI_MSIX_ENTRY_SIZE + msix->table_offset=
_adjust,
>                  PROT_READ,
>                  MAP_SHARED | MAP_LOCKED,
>                  fd,
>                  msix->table_base + table_off - msix->table_offset_adjust=
);
>     close(fd);

I think this is finally a clear indication that it has always been
wrong for qemu to access hardware directly like this. I see no way
around replacing this by something which isn't a bodge / layering
violation.

Jan

> This comes from commit:
>=20
> commit 3854ca577dad92c4fe97b4a6ebce360e25407af7
> Author: Jiang Yunhong <yunhong.jiang@intel.com>
> Date:   Thu Jun 21 15:42:35 2012 +0000
>=20
>     Introduce Xen PCI Passthrough, MSI
>    =20
>     A more complete history can be found here:
>     git://xenbits.xensource.com/qemu-xen-unstable.git
>    =20
>     Signed-off-by: Jiang Yunhong <yunhong.jiang@intel.com>
>     Signed-off-by: Shan Haitao <haitao.shan@intel.com>
>     Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
>     Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
>=20
> Now, the questions:
> - is this (i.e., PCI-Passthrough with a locked-down dom0 kernel)=C2=A0
>   working=C2=A0for=C2=A0anyone? I've Cc-ed Marek, because I think I've re=
ad that=C2=A0
>   QubesOS that it does on QubesOS, but I'm not sure if the situation=C2=
=A0
>   is=C2=A0the=C2=A0same...
> - if it's working, how?
>=20
> Thanks and Regards



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 15:17:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 15:17:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272425.467259 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJd6N-0005M9-TN; Mon, 14 Feb 2022 15:17:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272425.467259; Mon, 14 Feb 2022 15:17:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJd6N-0005M2-QA; Mon, 14 Feb 2022 15:17:19 +0000
Received: by outflank-mailman (input) for mailman id 272425;
 Mon, 14 Feb 2022 15:17:19 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qPn=S5=citrix.com=George.Dunlap@srs-se1.protection.inumbo.net>)
 id 1nJd6N-0005Lw-9b
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 15:17:19 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 31832514-8da9-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 16:17:17 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 31832514-8da9-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644851838;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:mime-version;
  bh=nJEXXGOIu7GTBpNx6WSSGGD8wujL8FeB7ue9x0gxe6A=;
  b=NhZrxDlgoO5twlwqHR4qSQ/iJFzYufRQKES+33zMo0/5DNkLEsG1Jdte
   AL5vqylJEM3nw8lTNSLiryRFU58uFgBH3RqTmvDsglLKunKhz0CTWsk1q
   ro4qyllsX6DEn1gkW2bbXN0CRyQTnKgyQE04gWM1McE54j7bEUjmsW5Fx
   g=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=hardfail (body hash did not verify [final]) header.i=@citrix.onmicrosoft.com
IronPort-SDR: kJ6PhcQhzJeHNRGLFtUBxsPTmMRAbODhrJX9CJxLzGoLfIIX6g+xmrhoNuNLn/xfeebpA8QFlx
 SlWPUpV+rqUEwP/iBLTfh6YKyNFzh01wkEJJPogjYnfbtyJ0f1CgNFra6ioF1gbMi0UAaB9/ad
 jKvCJUes+hokLedp9PzxN1w4a9R178OWpzzu5kE+d/F3cxP5dK0Xp+5nj6l9ibbyX84KFWi7yG
 8GBwg/sHEC7nuw0pQuRrXJVGRiLarI1FGoZ7oK0E4zyjB/l8QWL5CJ8zuLUcHj49awDKGdAlUs
 Me6FJnMsEI0dXOlAz3GKEjBL
X-SBRS: 5.1
X-MesageID: 66389482
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:RW7lB6144WFc6w+qO/bD5Z93kn2cJEfYwER7XKvMYbSIYQITYwd3j
 TtIBzjCf73ffDO2KOnCW/2yp0NVv8fTzt9qTQRr/ihmEygTo8PMVYvAdxr9MijCfseZFBk+s
 88SNtKddclrFCPWqkf8O+Sw/CQtivHZH7akYAKo1lidYCc9IMt2oU4zy4bV+7JVvOVVIz9hm
 Pv5+sDSZAD8gTUqOGhP5a7b8h0x5P2qtmlIt1ZvPa8R7A6CmyEZAqxEKPDqJRMUYGX18s1W5
 Qrn5Ovklo8M1051UrtJqlt/G6Ezaua60TKm0xK6YID/xEgSzsAO+vxjbqBEMx4L02/hc+1Zk
 72hi7ThEW/FAYWU8Agte0Ew//ZWZPAuFBfveBBTgOTLp6H0WyKEL8ZGVSnaCbYw6OdvaVyiw
 NRDQNw7grJvsMrtqF6zYrEEas3Ot6AHNqtH0p1r5Wmx4frL3fkv6kgFjDNV9G5YuyxAIRrRT
 5I7TgZhUxrpXwMRHG8LIbEOk8KComaqJlW0qHrNzUY2y23azQg327nxKtvFPNeNQK25nG7B+
 DiApT6gREhHaprPklJp8Vr17gPLtQz2X5gdGfuU6/huiUW7zW0PEhwGE1C8pJFVj2bgBYkPe
 hBEoELCq4AJ6xeQaoPkASGBsSCB/UcDRuRCCfADvVTlJq38vF/CWzlsoiR6QMMinN87Q3otz
 FDht8PkA3ljvaOYTVqZ96yItnWiNC4NN2gAaCQYCwwf7LHLgqs+kxbORdZLC7Oug5v+HjSY/
 tyRhHFg3fNJ15dNjvjluwCc696xmnTXZlYXwTnZYWyM0h0nQra5Tq+Y5n3xyekVee51UWK9l
 HQDnsGf6sUHApeMiDGBTY0xIV252xqWGGaC2AAyRvHN4xzooif+Jt4IvFmSMW80ap5sRNP/X
 KPEVeq9Drd3NWDiU6J4apnZ5y8Cnfm5ToSNuhw5g7NzjnlNmO2voXsGia24hTmFfK0QfUYXY
 8nzTCpUJSxGYZmLNgaeSeYHyqMMzSsj327VTp2T5035jebBNC7IFO9cawHmggUFAESs+lu9z
 jqiH5HSl0U3vBPWPkE7DrL/3XhVdCNmVPgaWuRcd/KZIxoOJY3SI6S5/F/VQKQ8x/49vr6Rp
 hmVAxYEoHKi1SyvAVjbMRhLNeKwNauTWFpmZEQEJ0iz4XE/bO6HteFHH3fBVeJ8r7ILID8dZ
 6RtRvhs9dwRFmWZq2xFN8GVQU4LXE3DuD9i9hGNPVAXV5VhWxbI6pnjeA7u/zMJFS25qY01p
 LjI6+8RacZrq91KAJmEZfSx4Um2uHRByut+U1GReotYeVn28ZgsICv016dlL8YJIBTF5z2by
 wfJXktI+biT+9c4oIvTmKSJj4a1CO8iTEBUKHbWsOStPi7A82v9nYIZCLSUfSrQXX/f8bm5Y
 bkH1On1NfAKxQ4Ys4d1H7tx47g54t/j++1Twgh+RS2ZZFW3ELJwZHKB2JAX5KFKw7ZYvyqwW
 16OpYYGaenYZpu9HQdIdgQ/b+mF2fUFoRXo7Kw4cBfg+St63LubSkEObROCvzNQceluO4Q/z
 OZ/5MNPs16jigAnO8qthzxP8zjeNWQJVqgqu81IAILvjQZ3mFhObYaFV33z6ZCLLd5NLlMrM
 nmfg6+b3+ZQwU/LcnwSE3nR3LUC2cRS6U4SlFJSdU6Untflh+Ms2EwD+Ds6eQ1Z0xFb3r8hI
 WNsLUB0ef2D8joAaBKvhIxw99Wt3CGkx3E=
IronPort-HdrOrdr: A9a23:L0T/Sq08J6Pl5yvszJaLkgqjBRtyeYIsimQD101hICG9Lfb3qy
 n+ppsmPEHP5Ar5AEtQ5expOMG7MBfhHO1OkPYs1NaZLUfbUQ6TTb2KgrGSuwEIdxeOlNK1kJ
 0QDpSWa+eATGSS7/yKmzVQeuxIqLLsncDY5ts2jU0dNz2CA5sQtDuRYTzrdXGeMTM2fKbRY6
 DsgPavyQDQHEg/X4CePD0oTuLDr9rEmNbNehgdHSMq7wGIkHeB9KP6OwLw5GZfbxp/hZMZtU
 TVmQ3w4auu99uhzAXH6mPV55NK3PP819p4AtCWgMR9EESutu/oXvUiZ1SxhkFwnAid0idsrD
 AKmWZnAy1H0QKVQohym2q15+Cv6kd315ao8y7nvZKqm72JeNt9MbsauWsRSGqr12Mw+N57y6
 5FxGSfqt5eCg7Bhj3045zSWwhtjVfcmwturQaC50YvIbf2RYUh5rD3xnklWqvo3RiKn7wPAa
 1rFoXR9fxWeVSVYzTQuXRu2sWlWjA2Eg2dSkYPt8SJ23wO9UoJgHcw1YgahDMN5Zg9Q55L66
 DNNblpjqhHSosTYbhmDOkMTMOrAijGQA7KMmiVPVP7fZt3d07lutry+vE49euqcJsHwN87n4
 nASkpRsSood0fnGaS1rdV2G9D2MSyAtBjWu7RjDqlCy8vBreDQQF++oXgV4r+dn8k=
X-IronPort-AV: E=Sophos;i="5.88,368,1635220800"; 
   d="asc'?scan'208";a="66389482"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ZkFcz1YxNAQEAPWDwlVD0X9riGZL2sAuQSXcu3FKrLqPI6xk7naG/3V2KHelaJ2ODG/VmBk3MfF6IqSOiuWzLVLvNJyR3vCfEGhacREx740ndDXmyb1HglqLLi6KtNlrT2qbcE54jYRWB42ePep3PWuZrli07mkIT7l0KmTQHCIPu5e8mNTZ0axUCg6KWj4+eHZjqLRguziXfyYCkhJS4NDwXh0qnn0XwKofAx/DjpO7O9IUF762ooCVPv5/ZwXVj+pwUIztiH7IL8Nss+twHmeFMJxsVtShHoyKPnNZSQQYUTTuvxipg5IuWxg24EgCng4ODuogiwrqzZ6XhWFodg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=0QDCjobhHRG4WvmAcU9SKx6bVChagoBEnZR9RONAsKs=;
 b=CRinQ8GcqoBQwr9pNSkqzC6uKpHMegYViCVFuGZCtHXnRL6ytBgmxF9Y+fepvqoQpvRGV0L/W38VHvZO/TCS0vBfGKMhKSO1KNIwByOA33XVEFBm62k9SBUyEi6NNjIa16p1hxowEMxHL5olFFPsMBBWqoPS3qXzJTRzgf6/xtLUG8G0/QwP2AFozlekQ4uKxWZTRVdYyB8AdmkQsKh1A1mgHxgpm55I/v5qbKt6NGm8MwLbpExgvsctFzOPvWdIFh9ljnBlA/U9GKZWxRChwULA2ukgL7rtN1lM/LJCRN6vzxOiURrXCITbDjVdFZ7ZxmrUjbvlf01Yvd4c2ztmMA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=0QDCjobhHRG4WvmAcU9SKx6bVChagoBEnZR9RONAsKs=;
 b=VQqogCFJ8LM3+Od4cJPwCFeouW2VWtlE+ywtAvd/LVLpXbuQjbPY9yIcSTy4hvjLWgUU7PVhrAGsyD+reBIBLW7ys7JQY0za3yw28V3FgR4jyLuA+BM4D+gS0SyvzoaaWUvB4QGriRyE2wu5+gIdsyvTR9pI9cMY5oPhbQbJr3Y=
From: George Dunlap <George.Dunlap@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Andrew
 Cooper" <Andrew.Cooper3@citrix.com>, Wei Liu <wl@xen.org>, Roger Pau Monne
	<roger.pau@citrix.com>
Subject: Re: [PATCH 12/16] x86/p2m: re-arrange {,__}put_gfn()
Thread-Topic: [PATCH 12/16] x86/p2m: re-arrange {,__}put_gfn()
Thread-Index: AQHXcbin3fzAUbYfoEmIVyqXxoG/7ayUiG0A
Date: Mon, 14 Feb 2022 15:17:11 +0000
Message-ID: <210E97D2-FFDE-49D9-B04C-1D001F1A4B3D@citrix.com>
References: <d1fd572d-5bfe-21d8-3b50-d9b0646ce2f0@suse.com>
 <61ea9272-c4ac-c2da-e1da-8b8930d85264@suse.com>
In-Reply-To: <61ea9272-c4ac-c2da-e1da-8b8930d85264@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3693.60.0.1.1)
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: b53cbe23-f699-47a5-3990-08d9efcd12f3
x-ms-traffictypediagnostic: MWHPR03MB3136:EE_
x-microsoft-antispam-prvs: <MWHPR03MB3136D135E82EEE2C5D3BC69C99339@MWHPR03MB3136.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:6108;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 4L4oWprF0zCrvXoaGXKOMKrP38tYF91oKVGW2pQMkMUMEHFM5d6GkatjsjdPOXcL1BXdlDVRI0Mtbt1FUKqzxd0iBZUhhgJPDrd63Y30IhaFRtD45zGwEuHerVh8V9oFgEF0ym5JobJYUKdghoJAH/9qDJ9P5ExFT+Zhr+sPK+tjkjPMajsEtMsHlAZXKLeZG5M4rJKdRISPTnXaDPBa0FGaKkxZgjzAmBtnN9k4sIJu9JosydkBR06ILBvjQMtWdCTIW3UWOy7K5hrSK8SAhBy8rSS7mR3UYH0Jc7Ba6aboOf1UGph6R8MtBxNpSjhoqdn412lTdLIre7AfoBeuaeCD8j4oB+QxKseCxcBa7GJC3PfeKyUll+6kAC8zKE/UHWvReNhNOFUK4SG9niz/raDyL1PHPFauMDX08giF6adkd6SEqbnE0Lp4ZefE62d8C1NSYY8YdUQkTnKaRjyEnDUHmr1qC0AbdCHoyla4CaY0Bc+QtcPubFH908J4O0YCejZmi6jKg7f1uxHdxRa0KP4eFUlJcmHGZjZz47B4qw9b1hzaJSHjEPmBAtwkbYNTXoLN3sA0gwtDn/NnNFHag7AvWKTyhbEspissIBa4AOmxYmugQyUjy2/QUYWdkQ+PUe37eQULJbYPSsDdLK9ai/+Dn8If7X9s3q+eTeLnwSIMLD+68lkKKK7+PCqAcYwY0MnCuMVhdNWCaZqBEPD8aDpdamfFckJK8kPD6C8CUhvJ7NUGCM90qieK7o23tuAa
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6506007)(66946007)(2616005)(107886003)(53546011)(6512007)(91956017)(66556008)(26005)(8676002)(76116006)(54906003)(6916009)(64756008)(66446008)(66476007)(508600001)(6486002)(86362001)(316002)(71200400001)(82960400001)(122000001)(99936003)(38070700005)(4326008)(38100700002)(8936002)(5660300002)(36756003)(33656002)(186003)(2906002)(4744005)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Dlx8pZhJX/0Ann/1ApSZkktC7kkhaya2UhUTIGTY+4CnEGcBY77s5SWpgE4b?=
 =?us-ascii?Q?Dj9Dt8qMJUX8oOfnnyTfkk0tH4Ivt3RFiUX/4Yq3Hu44AJGFmBCvVj/bkRe6?=
 =?us-ascii?Q?PazlQURC2EHXFrUwuEy2rdLwbrxlvMaM0XZ8+U1i6u84XNCdIDHIzueQ8FFx?=
 =?us-ascii?Q?D3Ygj5VaIpwaKAUGoIPitdMKoj10w/Rfa689o3ZMulN2w0ppzn3ILutPghj1?=
 =?us-ascii?Q?xicsDqmEU1j5KXT+drNrawUhTui1mVzWSC+6PEePOpA+XXAoErZqLLSpkneq?=
 =?us-ascii?Q?G0LeqE8WPq8oxzSS4dJhBHmTfWn1RKrzDqP+YQHAFx60hW25wCNKFQDyTyzm?=
 =?us-ascii?Q?1Y6BSdlxZAkw6p7v+vtjoSI47DlSFHU/d08bvagUnQOU+Ua7zCmst94Z9S47?=
 =?us-ascii?Q?yvt4c2CAEX4KiQUW8qSQ7GCCdoQWXAqwj2NUT6er+nkdfxVkQuq1lVZx04AT?=
 =?us-ascii?Q?WdujYLCwQihm/QgcK8Grv5ie7D8+AsQAzQDM1mLuIBGqsUEIs2dUK/dDcO+Z?=
 =?us-ascii?Q?UhdI39npQvHX9IuO3/pphY89GsFKGoljFvBgQ0ahyyxPLVulx23MhONmBohe?=
 =?us-ascii?Q?VmjPGIsCGfS6kFhVUFx+9cio1roV+gBVrH4kVqG/ol5ZeC1p4GCTHCOWoy4n?=
 =?us-ascii?Q?gNauYA/utZ/lPdcC4UG497RlMbbgQYkc10AW4FrmZ6CEMBBBRKtnVrOWQQOy?=
 =?us-ascii?Q?WqSdrCSAjYOW0vVC0WrRhAivB+57JlEioLAFUuDZ/UCnjnU6kLk1gCSZFbgk?=
 =?us-ascii?Q?/rU/h115lc8jeKXdU//rDI4l3GI6255JzfFrQMKe9YHZScHnVFXvxDLMTACM?=
 =?us-ascii?Q?5HndxsdBXuCL8VsDhOjd/KRR5PHT/broWQjWoJPHrqjHp3048OAl8Psk+gnT?=
 =?us-ascii?Q?phm0Kr+bMcJ3b5Kv06HyqbheYng2Js8lQeSi5Be9OmRjJU7NJtUXYZrsderF?=
 =?us-ascii?Q?pSYn4m9keC6k7H0f/0LWCM79lwIeYDAnZbRyKY9uZI1nvGbec+h+ZkqmmMgJ?=
 =?us-ascii?Q?s+I/sk41P0OSg6E0D0YMha350qHDArxobTqyA8Wyz2qhflKShLBIRSTY88dd?=
 =?us-ascii?Q?9RD9FZcJU/nxmi1s3q6t14bvRxQnzRgmHiVcmr2nPD9xp43tklJEGbN0qFlY?=
 =?us-ascii?Q?gzh8yx0zq5ZCBnf/5cFTITLvW9aR7RqpNNWdN2bwttjH/4pyPDTJsGh0U+Pv?=
 =?us-ascii?Q?Eyl5z5ESaVs8l1FWmeXIbZ6acfCS6nlljilhkrcofLuC0g4GstiN5JcTgZjH?=
 =?us-ascii?Q?VmeaH2rS0nqggsNMG7sHaNmwdiMhqG3kpv2YtzVCuUTSt+RvBu3xOJlGGqQ0?=
 =?us-ascii?Q?zhs6xfOB0GdQp+uRmoYYx67t8zs2FQQAC/JALHzRgnjXAuJXjDc/dtbny/gD?=
 =?us-ascii?Q?ig+MmrGMfxptTJz88XWYQAdpZIIn9jDUyt/9RSgQvP65mXMtJVulJ1ooTK5n?=
 =?us-ascii?Q?upPupp8+4Zi+WKh8y6cRdWLLEa27Vlsg2n4b8MxP8I7Q673maaK6pr06dsvi?=
 =?us-ascii?Q?zf3Io+G2rmOanT1yAWfqbSzYa3JZkaOeUs+VqhM5xPCM8jXXxjiNZmNvgCgx?=
 =?us-ascii?Q?7jl5i7FOJTcn27ZMfih2m1mGl60g8CVvRtmezVpjk7/L0YGwztBLzm+Y+GhC?=
 =?us-ascii?Q?8XSVaJKFjJ33TbaOhZXKTWP2J0TAEoYVQ/VpoKHOR6fBKhx/jBoWOQvRyiT2?=
 =?us-ascii?Q?28pa4CEo/f1dIu4QpB13QW0k1Rc=3D?=
Content-Type: multipart/signed;
	boundary="Apple-Mail=_673BA740-E3D6-48A0-87B1-FDF59DA24E59";
	protocol="application/pgp-signature";
	micalg=pgp-sha512
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b53cbe23-f699-47a5-3990-08d9efcd12f3
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Feb 2022 15:17:11.3649
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: qZXEvWiL1/Na4Y2PAj49ASm4xiaiHMHVZ2vBW8eg1A9VmKyFXq/1pXHPlfLotXZPF2s7Tj7FOGZCoe7t23SQvWK3wWQVT7RWpBtgOkxOewQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB3136
X-OriginatorOrg: citrix.com

--Apple-Mail=_673BA740-E3D6-48A0-87B1-FDF59DA24E59
Content-Transfer-Encoding: 7bit
Content-Type: text/plain;
	charset=us-ascii



> On Jul 5, 2021, at 5:12 PM, Jan Beulich <JBeulich@suse.com> wrote:
> 
> All explicit callers of __put_gfn() are in HVM-only code and hold a valid
> P2M pointer in their hands. Move the paging_mode_translate() check out of
> there into put_gfn(), renaming __put_gfn() and making its GFN parameter
> type-safe.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: George Dunlap <george.dunlap@citrix.com>


--Apple-Mail=_673BA740-E3D6-48A0-87B1-FDF59DA24E59
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="signature.asc"
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEj3+7SZ4EDefWZFyCshXHp8eEG+0FAmIKcnYACgkQshXHp8eE
G+1yTQgAgN21xcHxiNFqLivrunkopiFrBq4YU0++OyJAIfy3FwfKNza4ywPG0Ft/
MNRDBTIaZudpQt0ZloZHoo/PGl1nY6sWleudCIzsD7r6RUJVaQ8nkL6Nl4x6S9ll
2f5QW7feOlP0OVqmmLRlbAwqBpKUC21SjdMODlyPo11UGZLLzKy3KXcvdG+tmZHr
G/aX0wz2Ha4w8pbD2eZicq0Upnjr+g2nQzPvk/QGoMl/69tDR9GKIYUyXBEoE1Fl
E/qTHLy8i6ptY0E2+U1p1p9tvJQRVvQ9RkiFAWuqbw+tFVzQlVqSMunytOzB9Y7F
/7i5Pqzozi4kZ7eOgIKSWcPmtea4mA==
=ktOw
-----END PGP SIGNATURE-----

--Apple-Mail=_673BA740-E3D6-48A0-87B1-FDF59DA24E59--


From xen-devel-bounces@lists.xenproject.org Mon Feb 14 15:20:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 15:20:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272432.467270 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJd9C-0006jK-BC; Mon, 14 Feb 2022 15:20:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272432.467270; Mon, 14 Feb 2022 15:20:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJd9C-0006jD-7v; Mon, 14 Feb 2022 15:20:14 +0000
Received: by outflank-mailman (input) for mailman id 272432;
 Mon, 14 Feb 2022 15:20:12 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KkXt=S5=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nJd9A-0006j5-LT
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 15:20:12 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 99d39d90-8da9-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 16:20:11 +0100 (CET)
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur03lp2058.outbound.protection.outlook.com [104.47.9.58]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-16-hLf6BF8tMNKqUtH2Gs7dIQ-1; Mon, 14 Feb 2022 16:20:10 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by PAXPR04MB8719.eurprd04.prod.outlook.com (2603:10a6:102:21e::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.18; Mon, 14 Feb
 2022 15:20:09 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4975.015; Mon, 14 Feb 2022
 15:20:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 99d39d90-8da9-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644852011;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=zdjjyL3E94323xRAaDNAQjC/MZwuD4FOVoSraGxmtdE=;
	b=TWxPO06U8z+F+zbtxFBwIOPMbinnjmgQ/5b2v2PdAnYAiknGoSHAtCKxHJsvSdXf1fcYo7
	zeieZ9ruFozAkwJB313fLlpV29ubOkmYPfw3z6P/MfNfMy2ybBe47B9FHc+BokwboYv4b5
	fqJfQ7uwpe8SUZsCV0hheakOzs5rZhQ=
X-MC-Unique: hLf6BF8tMNKqUtH2Gs7dIQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=VVIAkVAkJgsOeo3o7criCj5XsA19b0lnNMAQFQstDxPqd1g4Lkvuw4584ggJe8jm2vhMYgYtJ/ksask8aUqAR0pvB1nYcmVnf1AcnPV3sUuxk5uHMGO6FEY3DnzQojTEfri0kHd1O/njXT8tPVIwymgiX/fQB104Em2PAyGCPzcDwzLFe9wl+IvjGWLqSljO1RXtVIghKTTeo4EbZUMAebbkwGmtB6UPcEyv2CBUrEBCucvT9zQ5ZrWKiF/plDgq2raxA79O2VAvS1L/EGtxb5AjVhACWmbq5nYHJ7C05kzO1zH0eljvd9Iy20W1Vvbw4IPh1xaT8ZXyg5zWoTNcLQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=PUErQLu02xx2/Pvr+vZNI6PGIhOoW+pkVjD63t1mMWM=;
 b=mRZRq1bQCev6F0+s7DXRI1hrQ9Wp8tVN4B8XxSE/LlsYB+GD71MPm7Rd219ndY0S/N0ErSNViP8v8JFrVIU3riMA1uuCKEondTaeS4E4U0FsduVBQjxzzVj5EdKWKcxkihlroVQMGKsyM6JkrnuWQBVfTtj/96xG7DJc2TF+aZBUkp5lR3qtEEtwkwz0hQbcDZ/9gqVDLO3482x6kKWriSsNWlkraV6QXZOrkcM0RDqzaGv0R319SBqXuCKkpIVsC4vnIJSMn3EwKoBEfhUUk4mpQThnxvL0iKsWoPboZHZzQ+G/Pb9TAFNBH7oIEr0AzuYUM5rf5xXpBzlQi9L6Tg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <2644fc70-612e-132a-c0d7-75aa9242fe8b@suse.com>
Date: Mon, 14 Feb 2022 16:20:06 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH 11/16] x86/P2M: derive a HVM-only variant from
 __get_gfn_type_access()
Content-Language: en-US
To: George Dunlap <George.Dunlap@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <Andrew.Cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 Roger Pau Monne <roger.pau@citrix.com>, Tamas K Lengyel
 <tamas@tklengyel.com>, Alexandru Isaila <aisaila@bitdefender.com>,
 Petre Pircalabu <ppircalabu@bitdefender.com>
References: <d1fd572d-5bfe-21d8-3b50-d9b0646ce2f0@suse.com>
 <a940e734-75ae-2660-7b2a-9b426437c48a@suse.com>
 <1E368B6E-A3E4-4A43-8CBE-6213D302C6F1@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <1E368B6E-A3E4-4A43-8CBE-6213D302C6F1@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS8PR04CA0147.eurprd04.prod.outlook.com
 (2603:10a6:20b:127::32) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 0ead1527-07ad-41bc-2cfb-08d9efcd7c99
X-MS-TrafficTypeDiagnostic: PAXPR04MB8719:EE_
X-Microsoft-Antispam-PRVS:
	<PAXPR04MB87192F93275F90B97980F1EAB3339@PAXPR04MB8719.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	KTquIhA35jciunuvcgTndWWxiotLq1Wjke6UhMYY+UZepzGfGXcvUlmoiB6Hb2e01q1Fl4lx0amkhJri97j7BBsJTLjnard5F4Rb3sqvVWifykrHFfKRa+e567wVq5naPeQByh2Roh9wp4uhVZcLPiajO72aHCdcNe7L0UfWsfORVzSE1UTiYURdhb2xhguxV593pKkVp8CFJ06Ym81dPoeoFy5849LUhzE0zQASmhSiLxMS7v0ZrTaYDmqkhyqnovYsvEGtTLsHea4PLN0r4xyLSK25bfVYIzan6zVZ7oTrSD6DtSjUzXVn9gZuu0QouqjhRSgNc1ZXi18fjwz9+qgvh8tMEenQt0L/I5gO2o7X2CQOYeWZRto5TkjmF9bgXC5uVp/ZmRw/kT2QMAQATrCFYrLSHPvAuXk79lfWorOZNZEoEMJeK3sVn0Zeb7xYAFRdcQv4VT6p9vptDKuyPNm7DMK8X+PC9hGbj9SN5qKs9wWgeSSbTgE9SiZYc+HsQ3dF8aeZ+16HMPTHn1kAfxp+pwX3lh92465jfh2gpEmKTsd4nEfWBSAdG7kJLD0pI+2SYrAQJr/trWuCSO9iSGDqdlozzu0SxrnWkFERguFey6IRQw0gqinPxekjnr0J3M3VVlYAyFcYj5KDqFPgzBO46Re9gMYBrmySkeFZ4A6WyQe0odb/i+q6tfP2cqwZeoQ6MT6t/j/z3TtKgD+EDFKhHhpSvc4wq5usbdumJGTAdRPS//JFZmzTJDe5pODy
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(31696002)(6666004)(316002)(66476007)(66946007)(66556008)(8676002)(4326008)(53546011)(6486002)(508600001)(38100700002)(83380400001)(6916009)(54906003)(6512007)(6506007)(36756003)(2616005)(5660300002)(26005)(186003)(31686004)(2906002)(86362001)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?1OeY4HRP0nbVhwhvEfa/9mC7SGhNpk1o2g8T7DDWyRC5V6OvAOplUYPUuTOf?=
 =?us-ascii?Q?D4aXSFkH09rFkztNcHTxE4U3D9tkuAjloRCMVwoIzP7DeT608j8Pqjq0BBGS?=
 =?us-ascii?Q?i4d+ckpFNL+TjD3XC3R0cPgxTlI4WatyrsCYQPwpAR+zCSBT0w0/+tvPaQc5?=
 =?us-ascii?Q?u/yFqmeOslwjMAF5T/MDZDppMEsla7iWYo+J/TP6lcfET+H63nOZ25tPINDV?=
 =?us-ascii?Q?zBgC188dyyDNgmeg0R1l4aYLBTZcWZ7ainRt97wNjcyT9Rdc+2um0cZ1WplE?=
 =?us-ascii?Q?KwAWS0A4HpvLLgv51+Chbj6Q1rUoRb5Af5OvMDLdZxq8XUt/hFno1c/nuIcT?=
 =?us-ascii?Q?fc4qQNSRQTKW23Z2edurQCTYm37tiTOg4LsRpNKdJeS2q9s3SNSr2hLOP+wW?=
 =?us-ascii?Q?dWjIQV/KNAR9LMsahHnnx0eR3/GgyHbGSTemsqI9pkk3Affvw4P0Lzg0Wk8L?=
 =?us-ascii?Q?DDR/mxP5QZDK07xcNTYEP3KLnE3Hv7gLMQoqdjv2vLvd6RshyG++PHll0BOL?=
 =?us-ascii?Q?IJftZqVLfoTnQXAPJIJRUiPqlYeDJYsQkq5QrmUtk9BSZwnlb/FjeKzvUVwU?=
 =?us-ascii?Q?KOg0I1OUogfvVLhlWuoQadqyOjXzXCc5Ir2eNN+Pf5/n1NYERlR24XOJUdFn?=
 =?us-ascii?Q?3fEusaxct/PuXiot7nBiC8gntzUJ8Wz070/M+RyZHJgjTQGLoAFvyV/NmeIJ?=
 =?us-ascii?Q?/ple3mkiZsNcXpMuVMU5zOVxPssjeEUTVTogRqyXPsMsg3yLVQRssd7AUOHF?=
 =?us-ascii?Q?4QCnRONGDGrYPcAG5itUKz6O2D3FaeMIFJT/EwWf4FRfv7FJlhSAiyG655Pv?=
 =?us-ascii?Q?/3lM/iwOSg/Vhsrm+kpE6Y4ITuogzAZctunmLFT3qa9uFJ/CPyEbLucduyXj?=
 =?us-ascii?Q?MkRBb+g+KExjinNbAd/Oh/5bl7so/hbhpfz58Ly+VjhXTMM3S7gCPNgjNaAJ?=
 =?us-ascii?Q?l7eTSQ0hTQsdr6lvfOQbsqgeLo69Q2rMGgXnewC9u14/WOjxL1Nnx5C8Zkd4?=
 =?us-ascii?Q?PBqh9MmWIj2gpuz1R+2DtW8iUxAETVGaf7Mg8eN/c3Opp/8uCu3rhgvZwHBE?=
 =?us-ascii?Q?VX1PmIAGyzzFDL47RELjcfXlsuUvJoaV4r7jzsSBS09JJih5FFF5Bf4Ntzwn?=
 =?us-ascii?Q?A+UjMZFaXgv2Npm6F2yjllYlhPmKusyVSApNodOApHjXQSoRq11ynqFIrras?=
 =?us-ascii?Q?Vln17bBNrv07Lnwh+xhDMuRwYkNxTdrB+se4JgWS7B/J+wtxVqAh1yDXskdG?=
 =?us-ascii?Q?DbIdYBg/EeRkQ32Csl2PLJY+F5ozSv0YPUrzFjlGID6DYUirU9SgViAys0Rh?=
 =?us-ascii?Q?1/6CWDp0iF2F7LRjCCUwI06TEnzDZ3o69EI/KPOEHMSqRDmj4nmmGRw48kUk?=
 =?us-ascii?Q?bS5K5hGxKw6Z0gGc/7E2FsEJkBjPivjNvyNyaQ8UeHnwZDPiCaJoS04ejApo?=
 =?us-ascii?Q?GVm/ACCxnWNgTD6hYCNN/lXSdoPW8ji9NqZQb+TzvTeYKjIBXF61I4iM97jF?=
 =?us-ascii?Q?d+7qjyyiJ67ADl4vZIxChxQrEcFJsEKwryxGe0HFKkhgxja0jzN6UrJkVVw+?=
 =?us-ascii?Q?sr2Y0cWesDGooBy0SPhtNcg8cUnocs6uL3kFyJ4zgC0ERG08iGQckSKBlyUf?=
 =?us-ascii?Q?jqQZB2fWDtoFmxqR44Ccv44=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0ead1527-07ad-41bc-2cfb-08d9efcd7c99
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2022 15:20:08.9258
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: v13M5BXPVSd5/iGfQhcubLBTv//SVDiXI7IfNSjsj1Q46Xw3L6lJhU0dKE5j2aC1RVKye5g/V7hxNqyPjBN0jg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8719

On 14.02.2022 16:12, George Dunlap wrote:
>> On Jul 5, 2021, at 5:12 PM, Jan Beulich <JBeulich@suse.com> wrote:
>>
>> Introduce an inline wrapper dealing with the non-translated-domain case,
>> while stripping that logic from the main function, which gets renamed to
>> p2m_get_gfn_type_access(). HVM-only callers can then directly use the
>> main function.
>>
>> Along with renaming the main function also make its and the new inline
>> helper's GFN parameters type-safe.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>=20
> Nit in the title: I read =E2=80=9CHVM=E2=80=9D as =E2=80=9Caych vee emm=
=E2=80=9D, and so I use =E2=80=98an=E2=80=99 before it rather than =E2=80=
=98a=E2=80=99; i.e., =E2=80=9Cderive an HVM-only=E2=80=A6=E2=80=9D
>=20
> I feel obligated to mention it but I=E2=80=99ll leave it to you whether y=
ou want to change it or not:

Thanks - I always appreciate clarification on my, frequently, improper
language use. In the case here, however, I know people saying "aych"
as well as ones saying "haych", so I'm always in trouble to judge
which one's right (and probably both are). I therefore decided to
simply drop the "a" from the title, which I think still leaves it be a
proper one.

> Reviewed-by: George Dunlap <george.dunlap@citrix.com>

And thanks again.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 15:25:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 15:25:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272439.467280 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJdES-0007Nd-V2; Mon, 14 Feb 2022 15:25:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272439.467280; Mon, 14 Feb 2022 15:25:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJdES-0007NW-Ry; Mon, 14 Feb 2022 15:25:40 +0000
Received: by outflank-mailman (input) for mailman id 272439;
 Mon, 14 Feb 2022 15:25:39 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJdER-0007NQ-DK
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 15:25:39 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5b5fe4a7-8daa-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 16:25:37 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5b5fe4a7-8daa-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644852337;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=3YvUr/pK2pqfjGebFFqZNorqgBjA0uiDIOid7t8n1/w=;
  b=Fd5HiM9NGEiQ0Qo1JXGjQmKGjlkdZ61So4JJaCYBhXq7ZgMyE424WuRA
   88xLA+P6w8mbSC1sZSZyt4rCQcHH436pnYNBVtRRmki83MKiWIWko5l0M
   E6Rq/qpsTmIit9ZvCJv60MR6QiQNa8Il/trctnbCUzo1CIzyTiNFi3VfZ
   s=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: O0K8izYdrO6/lyShJr2nIIkNcH2LDnw1lheTYhGd6dzlY6rPC1Q9joWmCmVGKa/tcuEbVWqArl
 4IOcQBoO6aNmRCDmu9S/ghdl/dvw1ik4EMPRcPvfQ1JsRAUXzsSZ7FoFo4fnWubYYmALb6iP5n
 NBFokdxPD/3+ITocTyfc5iUdYWqH970UU6iN80JmtI1+S6r5Nrpt2iAXZ06VhToBQ9lG2AQMr+
 Hm4sHPHr2ei8DOst3xE+r+KCXNYnQPqfuWTU/AGjCFPGM4lA/iaRiaRCZUtcTlDrQ8n45Sf7c/
 at1ijfwYqktxY7YW2gBC8YOR
X-SBRS: 5.1
X-MesageID: 63606711
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:uAa4RqjQHGJ6wG8QJWboDVZHX1618xcKZh0ujC45NGQN5FlHY01je
 htvWmzTPa7ZajSjeN51aoy//UhVvZPVxt9gG1c4/i43RXwb9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oAMKRCQ7InQLlbGILes1htZGEk0GE/NtTo5w7Rj2tQx3YDja++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /1BpMCCYj0KH5aXgcYUYyUBGiNFGPZZreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHCOo8Ft24m5jbeFfs8GrjIQrnQ5M8e1zA17ixLNaiFO
 ZJHNmM2BPjGSx4VCkkoM5x5peKHnlrcKhBU9UyFurVitgA/yyQuieOwYbI5YOeiQMxPm0+Cq
 2Hu/mLnAwobPtiS1TqE9H23gubF2yj8Xeo6DbC967tmjUOewkQVDxsZU0b9puO24malQM5WI
 UEQ/isorIAx+VatQ927WAe3yFaIsBcTVNtXF+wS8xyWx+zf5APxLngJSHtNZcIrsOcyRCc2z
 RmZktXxHzttvbaJD3WH+d+pQSiaYHZPazVYPGldEFVDs4KLTJwPYgznQsc/IoWPrfzOQijSy
 gC29SE8vJBIkptev0mkxmzvjzWpr5nPawc64ATLQ26ohj9EiJ6Zi5+AsgaCs6sZRGqNZhzY5
 SVfxZDChAwbJczVzESwrPMx8KZFDhpvGBnVmhZREpYo7FxBEFbzLNkLsFmSyKqEW/vomAMFg
 meO42u9B7cJZRNGiJObhKrrVawXIVDIT4iNaxwtRoMmjmJNXAGG5jpyQkWbwnrglkMh+YlmZ
 8vHLpb8UCtCUP89pNZTewv6+eV1rh3SOEuJHcyrp/hZ+eb2iIGppUctbwLVM7FRAFKsqwTJ6
 ddPX/ZmOD0EONASlhL/qNZJRXhTdCBTLcmv96R/K77SSiI7STpJI6KAntscl3lNwv09ehHgp
 SrmBCe1CTPX2BX6FOl9Qi4/Oe2/Bc4l9RrW/0UEZD6V5pTqWq72hI83fJorZ7g3sutlyP9/V
 f4efMucRP9IT1z6F/41NPERdaRuK0amgxygJS2gbGRtdpJsXVWRqNTlYhHu5G8FCS/u7Zkyp
 Lip1wX6R5sfRls9UJaKOaz3l17h72IAnO9SXlfTJoUBckvb74U3eTf6ieU6Ip9QJEyblCeaz
 QufHTwRufLJ/90u6NDMiK3d99WpHuJyE1B0BW7e6brqZyDW8nD6md1LUfqSfCCbX2Txof3wa
 eJQxvD6EfsGgFcV7NYsT+c1lfozvoK9qaVbwwJoGGTwQ26qUr4wcGOb2cRvt7FWwuMLswWBR
 U/SqMJRPq+EOZ25HQdJdhYldOmKydodhiLWsaYuOEz/6SJ6oOiHXEFVM0XegSBRNuIoYoYsw
 ONns88K8Q2vzBEtN4/e3CxT8m2NKF0GUrkm6c5GUNO61FJzxwEQe4HYBw/3/IqLOodFPUQdK
 zOJgLbP2uZHzU3YfntvTXXA0IKxX3jVVMymGLPaG2m0pw==
IronPort-HdrOrdr: A9a23:O+ZyDa0xpz3A67sGfKv5owqjBRZyeYIsimQD101hICG9Lfb2qy
 n+ppgmPEHP5Qr5AEtQ5OxpOMG7MBbhHQYc2/heAV7QZnibhILOFvAi0WKC+UyuJ8SazIBgPM
 hbAtFD4bHLfDtHZIPBkXOF+rUbsZm6GcKT9J/jJh5WJGkAAcAB0+46MHfhLqQffngdOXNTLu
 v52iMznUvHRZ1hVLXdOpBqZZmgm/T70LbdJTIWDR8u7weDyRmy7qThLhSe1hACFxtS3LYL6w
 H+4k/Ez5Tml8v+5g7X1mfV4ZgTssDm0MF/CMuFjdVQAinwizyveJ9qV9S5zXIISaCUmRMXee
 v30lAd1vdImjXsl6aO0ELQMjzboXITArnZuAelaDXY0JfErXkBerV8bMpiA2XkAgwbzYxBOe
 twrhKkX9A8N2KwoA3to9fPTB1kjUyyvD4rlvMSlWVWVc8EZKZWtpF3xjIeLH4sJlOz1GkcKp
 gkMCgc3ocjTXqKK3TC+mV/yt2lWXo+Wh+AX0gZo8SQlzxbhmpwwUcUzNEW2i5ozuNwd7BUo+
 Dfdqh4nrBHScEbKap7GecaWMOyTmjAWwjFPm6eKUnuUKsHJ3XOoZjq56hd3pDmRLUYiJ8p3J
 jRWlJRsmA/P0roFM2VxZVOtgvARW2sNA6dg/22J6IJzIEUaICbQxFreWpe5PdI+c9vcfEzc8
 zDTa5rPw==
X-IronPort-AV: E=Sophos;i="5.88,368,1635220800"; 
   d="scan'208";a="63606711"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=WKWXxLLkMbIxb+SboNm4dqJ+Gdu0ltLaGbwgMqXLbSPT6dIAYyPawNpAfx137q4btuZk7BWu9wplstOilV7Pea8lIZ8mcxxi28q4rlibf0Esec38jAgK4QCf5+2Fd4EkjIu8T5OfN6djOFfzbzd08u01iq6e2N5kgizbdweYIoLi4fIpfsLSh5UyT2EHIo29nMcJdCiYmA1/5HqYwsjYc6SrQ86XcbP/Akd16x42Xm8SVUvnzp+Bm8IgvdMNsuuCciaACgk1oPtOPF2wkcpB5Eicj8wRVwDtJLkah7+Ad/uYHgNlAj4baOSir6QTZZCtBO5QCPhQzO8JhocLLmee1g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=3YvUr/pK2pqfjGebFFqZNorqgBjA0uiDIOid7t8n1/w=;
 b=PbGs19KGKqGH6YM/nypFA6DV+o2dwt3qxO5dk5yDdJWF9F6e3YvvOyWgF4gwHQYcVz8AXwXzd5qP5+lGW0gOgKryaEYlGF9OJcB7LJhhXWB++7LKuhybmE0ZGORYUY5+SEO6hEEBah8gtUyle3WZHeNGSoNCQ/5VJZFrhh7DGkDKUQO17QWV/q0VvvI9fiT9Q8FhGXzLzNrEsaREs8hMuzhkKhcFwkfxeFQA2lpQby2AV7+/9yH+ZzUB4Te08hcHT0AewmEfcLWc2Ze8WXkTIYSGxDv/JriVqKNzP2uM+KoMCoRcsjeU50+J/GXUDzFGknms6k4to9PtDi7yQrvKXw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=3YvUr/pK2pqfjGebFFqZNorqgBjA0uiDIOid7t8n1/w=;
 b=NdFFdJFBOG4exJ1MvE61lb7PUdH4pj3pIsl73J3MsxWxC7+/OYPa3oH5dhpnUJSnILBEKhd/IqPxQAxCTyVDShvjTYhKXMijk0dgOqBk1WUwef/nhS4zAWPXPe9vfaIvRy/LHt7A/jf1mJlOSVvFkzsuJuu01hYxNGtMCUh96d4=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Dario Faggioli <dfaggioli@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: "sstabellini@kernel.org" <sstabellini@kernel.org>,
	"marmarek@invisiblethingslab.com" <marmarek@invisiblethingslab.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, Anthony Perard
	<anthony.perard@citrix.com>
Subject: Re: SecureBoot and PCI passthrough with kernel lockdown in place (on
 Xen)
Thread-Topic: SecureBoot and PCI passthrough with kernel lockdown in place (on
 Xen)
Thread-Index: AQHYIbPxFY5Kj3bRXE6t4z/dbeVrR6yTKssA
Date: Mon, 14 Feb 2022 15:25:31 +0000
Message-ID: <55436ceb-3c6b-beff-5cac-eb83cb1bc44d@citrix.com>
References: <8daad0f6c623a57bc0b047fc2388e8b698135624.camel@suse.com>
In-Reply-To: <8daad0f6c623a57bc0b047fc2388e8b698135624.camel@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 9b094890-24b2-4c57-57b9-08d9efce3ceb
x-ms-traffictypediagnostic: SN6PR03MB3917:EE_
x-microsoft-antispam-prvs: <SN6PR03MB3917E2F62D0592472AD6B95DBA339@SN6PR03MB3917.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: XoU8N4yIAVD000ZgIB2w0rEUFujD/7RCBxml+FjRgoduwqDWCg8/0PFe53ZCNaF4pSPAxzznFRKtCVSf+iSIYhSauMQ27RCGQcfUvBLKHuxcymB2pvbJccmzyRB4sggWbGyNZUf3oPqQEtftbRZoeX+TSRsCxjXbv2B0ZyTKiVjtgqe2iSVIWjWyvrINrEcqivABua2T5vwQsiPoEsuMPQIKoUc+LxXlbPJzn7ohbqNMgVtJu4Qd1u5nyzaQfgEmhkstuWgrA/Gwh3uzu5bhnp2IGND0MbsliS5JDXtSMB1Rv8pMxGDJmrB6Rit8fAY0q++BI0E/uQ2w7gnQRd+RVAvc/paewcDokBpwbp6jKQ0rxh8R5RoB4yj6RWgUhQ2bB/EWecSM4pWuzm5eVI47k6XhrZLgKS/jyK8AQQ5YYfZaJteTK6g2XhejT4chQwXdlrjrm2mC6JYb/WpHqll1tGary6+Lxw9c0g95RbDIWf0J3ILIocTiReHS8yqsEoxjt68u6Yhcr+owemjMWyJcSg1PIBLF0awE+OVRypZ2pvePSEABTxrbyRsmHN4FAdB9VJ5lp78G0quUY6JVv/t3DVsi0gqoVgoAoh3vLxeCnXMvcfYjwxMZt7FW90OzMdLiZf/NSZP1fT6zukIT1aDKwxXzfMLt+2U4y9uqHX4fEIWuZbtQ63z5kIYiNNV0qDK/M0BornJfcPOt6IRwhjWX92BKNAKl0Riq0yn/w9yUXG2JY4kaZXxlduY5PVugJcupXURDV3cqbeQu827rDPAL3Q==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(76116006)(66476007)(110136005)(38100700002)(4326008)(66556008)(5660300002)(86362001)(82960400001)(2906002)(91956017)(64756008)(31686004)(8676002)(31696002)(38070700005)(8936002)(316002)(66946007)(54906003)(6506007)(107886003)(26005)(2616005)(186003)(6512007)(122000001)(36756003)(66446008)(6486002)(71200400001)(53546011)(83380400001)(508600001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?bmg1ZFBMQ1hveTc0NjFzSGpIWm1ORC9vUFB4VW5wUzkreDlXK24wMkFUSXBV?=
 =?utf-8?B?VVJDbS9YZGNnYVU1cFEvd1pUdEpNZ09WRjJrTFh1amp2QkpyNmtxVEk3RE9W?=
 =?utf-8?B?WFE3cXVSeFpQQlJYaG9nSUJhYjJpNzhHZ3lOMWU1cmdjTXRucExRVmQxSmhk?=
 =?utf-8?B?Vi9VU3d2SUtlMXFrQlpZR0FGS1JNcUtPQ2paRWFjNE93cS9haFM3RHhGL3ZY?=
 =?utf-8?B?UHJZUjVNNitVL3U2TGdNaTdqL1haZjA1TEV4Y2hLdFBrd3FiVlh4OFdpQ2tu?=
 =?utf-8?B?WFJWV05ZSWxTOXhCV2pOUFFCUWNFaWxZVXh4RTVpa0I1eEpIckt2eUttakIy?=
 =?utf-8?B?ZzBtVjU1TTJUUzIxVTdkOWplcHBzNXhpZHNlRSs4eWFXcXMzenA0TXZ0V3FW?=
 =?utf-8?B?L2ZFa2VRV1RDd1lCaElKSXdMWkRsRmVodUlOQVlWMHY1a2E4a0VBRnppam9k?=
 =?utf-8?B?N3dwOHhITmRDUXlJMGpRdFVSdnJ1K1RTbHpiMzczeGxqZjRWSUxYVGcwd1Y5?=
 =?utf-8?B?UWhMQ21icit5N2FZelU2NUgwc0N2Rk9KZDVPendzTlQwWTkxWTNLUFFBcDFD?=
 =?utf-8?B?Q1dTVS83L0FxRUQ3VXZxblY5KzhINGZWeERQQ0ZoME9sOHpmN1BpZ2Q2OTFk?=
 =?utf-8?B?RFpncklEdDJGSEowdnYrWWhnZmRqVTVyZnc5ZS9kT1lrRWJJVHFyQmY3dENn?=
 =?utf-8?B?R0ZqVDZXQ0liV1VEQ2w0TVdzVE4rQXlUenM5Smw0aWRiQWZSSFpsV1Q2UFFJ?=
 =?utf-8?B?U1lzc2dhd25ybi95bC9NNnFmSXF4V0FWNmpvNHBxTFhweW5XL2tDMkY5Smkr?=
 =?utf-8?B?SGpwbDV5NEtQNEh0NGxUTHJrQlNtUWFzaS84NWFLR2hKTmZjRy95UzdUK0Fw?=
 =?utf-8?B?RjhtcHpXaWV0K2xnWVBqYVp0UWNsWFZRanNQMlIyc2ZYSkd6NmgyWUtrN0N0?=
 =?utf-8?B?YkRNYTR6SDRvVEZvSlp5VVRTOExidW5ab2xlZ0wrL2xmbmNZVUVkajVLbith?=
 =?utf-8?B?dkJUNjJPS2NwOWJjWkFhNVpCVU1QTnlvLzdqdC9WRVlkaUFIQWZycm5rSVpV?=
 =?utf-8?B?ZmZueHc5TTdhMCtVNVo3QnpKc3Z6bU5xMWcyTnpIK2xjN05zUmxZTjZUbG5X?=
 =?utf-8?B?UFlMOW5GamllSTRDeXQxbkZVaVd0U1hzWFFEdUlFclRaSEtuL3hST2M2WHh6?=
 =?utf-8?B?RVVHaWljTVVzQ242QTVrTGNicmlwTXJWV2ZTeXNSRzN5NFpWRXN6NW5PS0NG?=
 =?utf-8?B?QjBoQS9NemNZRVpFM1NBTklhOTM4aXFGejBzbGQwYzJtL3I2R3B5MWsvZTlp?=
 =?utf-8?B?NWgrQmYzcXVHaWpyNlZtTFFQQitiMmtsam1yVkdudE81bDBzcTFsR1NGNGxQ?=
 =?utf-8?B?VlliWmhHTFpXRHBLNWszVW52WGFhVkxCUXFzbkxvb0F2cVg0bThIdSsrRWFa?=
 =?utf-8?B?NkhQblJxemFSK2JKR2hLVndmQTY4NDMyR1ZrT3I3a3g3aXc0SUlSbk9JbGtq?=
 =?utf-8?B?R0hrZW9jdXdCTEdySHFET3FMcTFtaCtzdlVqV1BYYTFtYU14UnpLS0pMWjZV?=
 =?utf-8?B?VFNGUXRTZStsZnJhZ2ZMNFdMR2l5QnVqNlgrMW5GeC9MTlordlI5NnFFb1JJ?=
 =?utf-8?B?L0twNUVRcHZERDl4K1VFaCtDYVFjT21PYzJ0NDNvTk1wSmRObFFWWUZYdExz?=
 =?utf-8?B?L1kyV204cWNKN3A1aFQxSEd5UGdXMTZVanhjWS9naEdLcklYVkxJRmJJeTNY?=
 =?utf-8?B?QnRPQmJySVlKTXhPTGl2WHZwQWxHeWZtSjR4VlZUM2FDRC9GZDg1bUNvb0th?=
 =?utf-8?B?WXVYUVMxSlZJM3BBN2hqZXIySUUvRXE5bC9lRkZoYW9uK2svdnpFdDZnNmdk?=
 =?utf-8?B?Q2VGbjBXNVBJT04reC9uR1c1TDZrVlV3cWRDNm5RVlJXZnlXMGZEYUx5SWZH?=
 =?utf-8?B?WUkrZ2VCMHlNZXR4anYrRXE5ajZ5N25pNHdrT29aUzBGVkNKY3F3Z3Y4aTdR?=
 =?utf-8?B?U1Z3czJmcWFVQTFSMVhzSVZCc2FjeEN3SEMrMStmTXVoOFJvTjVKcmR2NjYy?=
 =?utf-8?B?Vm10MU1teStoSS9IL0d2Z2JRQ010cmlCQ3lxa2gxZGJPeWovcUl0UWl0UWJp?=
 =?utf-8?B?WDltaG1jWjJYL3AvQXdRSXo4YjN3anVudHczU2tNaEpaWkl6cys1VFJZa1Jy?=
 =?utf-8?B?UDdydnU3ZWcyUkJQdTVZNFM1L1AzSDNGMFhaTzJUZm1FUlkxTDNZNk91OWh2?=
 =?utf-8?B?QlFPRXEreW9qV2VOSGJ0RWw1VE5RPT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <532005749EF29E42803B1CF76E67C68D@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9b094890-24b2-4c57-57b9-08d9efce3ceb
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Feb 2022 15:25:31.3212
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: oCH+o5zwerIC9kI5/zfcRsf1hRcFmKOiqVBnq7shAiwqlCwtEnfGauXysEhsaFOZWWGEGincTxY3QGXIjAuM0sEAxG1bnHj27LecC6rxaGM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR03MB3917
X-OriginatorOrg: citrix.com

T24gMTQvMDIvMjAyMiAxNTowMiwgRGFyaW8gRmFnZ2lvbGkgd3JvdGU6DQo+IEhlbGxvLA0KPg0K
PiBXZSBoYXZlIHJ1biBpbnRvIGFuIGlzc3VlIHdoZW4gdHJ5aW5nIHRvIHVzZSBQQ0kgcGFzc3Ro
cm91Z2ggZm9yIGEgWGVuDQo+IFZNIHJ1bm5pbmcgb24gYW4gaG9zdCB3aGVyZSBkb20wIGtlcm5l
bCBpcyA1LjE0LjIxIChidXQgd2UgdGhpbmsgaXQNCj4gY291bGQgYmUgYW55IGtlcm5lbCA+IDUu
NCkgYW5kIFNlY3VyZUJvb3QgaXMgZW5hYmxlZC4NCg0KQmFjayB1cCBhIGJpdC4uLg0KDQpYZW4g
ZG9lc24ndCBzdXBwb3J0IFNlY3VyZUJvb3QgYW5kIHRoZXJlJ3MgYSBtYXNzaXZlIHBpbGUgb2Yg
d29yayB0bw0KbWFrZSBpdCBmdW5jdGlvbiwgbGV0IGFsb25lIHdvcmsgaW4gYSB3YXkgdGhhdCBN
U0ZUIGFyZW4ndCBsaWFibGUgdG8NCnJldm9rZSB5b3VyIGNlcnQgb24gMCBub3RpY2UuDQoNCj4N
Cj4gVGhlIGVycm9yIHdlIGdldCwgd2hlbiAoZm9yIGluc3RhbmNlKSB0cnlpbmcgdG8gYXR0YWNo
IGEgZGV2aWNlIHRvIGFuDQo+IChIVk0pIFZNLCBvbiBzdWNoIHN5c3RlbSBpczoNCj4NCj4gIyB4
bCBwY2ktYXR0YWNoIDItZnYtc2xlczE1c3A0YmV0YTIgMDAwMDo1ODowMy4wIA0KPiBsaWJ4bDog
ZXJyb3I6IGxpYnhsX3FtcC5jOjE4Mzg6cW1wX2V2X3BhcnNlX2Vycm9yX21lc3NhZ2VzOiBEb21h
aW4gMTI6RmFpbGVkIHRvIGluaXRpYWxpemUgMTIvMTUsIHR5cGUgPSAweDEsIHJjOiAtMQ0KPiBs
aWJ4bDogZXJyb3I6IGxpYnhsX3BjaS5jOjE3Nzc6ZGV2aWNlX3BjaV9hZGRfZG9uZTogRG9tYWlu
IDEyOmxpYnhsX19kZXZpY2VfcGNpX2FkZCBmYWlsZWQgZm9yIFBDSSBkZXZpY2UgMDo1ODozLjAg
KHJjIC0yOCkNCj4gbGlieGw6IGVycm9yOiBsaWJ4bF9kZXZpY2UuYzoxNDIwOmRldmljZV9hZGRy
bV9hb2NvbXBsZXRlOiB1bmFibGUgdG8gYWRkIGRldmljZQ0KPg0KPiBRRU1VLCBpcyB0ZWxsaW5n
IHVzIHRoZSBmb2xsb3dpbmc6DQo+DQo+IFswMDowNC4wXSB4ZW5fcHRfbXNpeF9pbml0OiBFcnJv
cjogQ2FuJ3Qgb3BlbiAvZGV2L21lbTogT3BlcmF0aW9uIG5vdCBwZXJtaXR0ZWQNCj4gWzAwOjA0
LjBdIHhlbl9wdF9tc2l4X3NpemVfaW5pdDogRXJyb3I6IEludGVybmFsIGVycm9yOiBJbnZhbGlk
IHhlbl9wdF9tc2l4X2luaXQuDQo+DQo+IEFuZCB0aGUga2VybmVsIHJlcG9ydHMgdGhpczoNCj4N
Cj4gSmFuIDI3IDE2OjIwOjUzIG5hcnZpLXNyODYwdjItYnBzLXNsZXMxNXNwNGIyIGtlcm5lbDog
TG9ja2Rvd246IHFlbXUtc3lzdGVtLWkzODogL2Rldi9tZW0sa21lbSxwb3J0IGlzIHJlc3RyaWN0
ZWQ7IHNlZSBtYW4ga2VybmVsX2xvY2tkb3duLjcNCj4NCj4gU28sIGl0J3MgcmVsYXRlZCB0byBs
b2NrZG93bi4gV2hpY2ggQUZBSVVJIGl0J3MgY29uc2lzdGVudCB3aXRoIHRoZQ0KPiBmYWN0IHRo
YXQgdGhlIHByb2JsZW0gb25seSBzaG93cyB1cCB3aGVuIFNlY3VyZUJvb3QgaXMgZW5hYmxlZCwg
YXMNCj4gdGhhdCdzIGltcGxpZXMgbG9ja2Rvd24uIEl0J3MgYWxzbyBjb25zaXN0ZW50IHdpdGgg
dGhlIGZhY3QgdGhhdCB3ZQ0KPiBkb24ndCBzZWVtIHRvIGhhdmUgYW55IHByb2JsZW1zIGRvaW5n
IHRoZSBzYW1lIHdpdGggYSA1LjMueCBkb20wDQo+IGtlcm5lbC4uLiBBcyB0aGVyZSdzIG5vIGxv
Y2tkb3duIHRoZXJlIQ0KPg0KPiBTb21lIGRpZ2dpbmcgcmV2ZWFsZWQgdGhhdCBRRU1VIHRyaWVz
IHRvIG9wZW4gL2Rldi9tZW0gaW4NCj4geGVuX3B0X21zaXhfaW5pdCgpOg0KPg0KPiAgICAgZmQg
PSBvcGVuKCIvZGV2L21lbSIsIE9fUkRXUik7DQo+ICAgICAuLi4NCj4gICAgIG1zaXgtPnBoeXNf
aW9tZW1fYmFzZSA9DQo+ICAgICAgICAgICAgIG1tYXAoTlVMTCwNCj4gICAgICAgICAgICAgICAg
ICB0b3RhbF9lbnRyaWVzICogUENJX01TSVhfRU5UUllfU0laRSArIG1zaXgtPnRhYmxlX29mZnNl
dF9hZGp1c3QsDQo+ICAgICAgICAgICAgICAgICAgUFJPVF9SRUFELA0KPiAgICAgICAgICAgICAg
ICAgIE1BUF9TSEFSRUQgfCBNQVBfTE9DS0VELA0KPiAgICAgICAgICAgICAgICAgIGZkLA0KPiAg
ICAgICAgICAgICAgICAgIG1zaXgtPnRhYmxlX2Jhc2UgKyB0YWJsZV9vZmYgLSBtc2l4LT50YWJs
ZV9vZmZzZXRfYWRqdXN0KTsNCj4gICAgIGNsb3NlKGZkKTsNCg0KWWVzLsKgIFVzZSBvZiAvZGV2
L21lbSBpcyBub3QgcGVybWl0dGVkIGluIGxvY2tkb3duIG1vZGUuwqAgVGhpcyB3YW50cw0KcmV3
b3JraW5nIGludG8gc29tZXRoaW5nIHdoaWNoIGlzIGxvY2tkb3duIGNvbXBhdGlibGUuDQoNClRo
ZSByZWFsIGVsZXBoYW50IGluIHRoZSByb29tIGlzIHRoYXQgcHJpdmNtZCBpcyBub3QgcmVtb3Rl
bHkgc2FmZSB0bw0KdXNlIGluIGEgU2VjdXJlQm9vdCBlbnZpcm9ubWVudCwgYmVjYXVzZSBpdCBs
ZXRzIGFueSByb290IHVzZXJzcGFjZQ0KdHJpdmlhbGx5IGVzY2FsYXRlIHByaXZpbGVnZSBpbnRv
IHRoZSBkb20wIGtlcm5lbCwgYnlwYXNzaW5nIHRoZQ0Kc3BlY2lmaWMgcHJvdGVjdGlvbiB0aGF0
IFNlY3VyZUJvb3QgaXMgdHJ5aW5nIHRvIGFjaGlldmUuDQoNCn5BbmRyZXcNCg==


From xen-devel-bounces@lists.xenproject.org Mon Feb 14 15:33:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 15:33:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272448.467292 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJdMD-0000S0-Uz; Mon, 14 Feb 2022 15:33:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272448.467292; Mon, 14 Feb 2022 15:33:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJdMD-0000Rt-QP; Mon, 14 Feb 2022 15:33:41 +0000
Received: by outflank-mailman (input) for mailman id 272448;
 Mon, 14 Feb 2022 15:33:39 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=gn9w=S5=invisiblethingslab.com=marmarek@srs-se1.protection.inumbo.net>)
 id 1nJdMB-0000Rn-Hi
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 15:33:39 +0000
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 79e0256c-8dab-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 16:33:37 +0100 (CET)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 3CAEB5C0246;
 Mon, 14 Feb 2022 10:33:36 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163])
 by compute1.internal (MEProxy); Mon, 14 Feb 2022 10:33:36 -0500
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon,
 14 Feb 2022 10:33:34 -0500 (EST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 79e0256c-8dab-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-type:date:date:from:from
	:in-reply-to:in-reply-to:message-id:mime-version:references
	:reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy
	:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=00sLYhy43u8dz4gqS
	AWPW2aSUeo4T6PTO9jyxileyR0=; b=gb1ZmJiaNxYX0944bJb8svuvXxfY9BQyP
	dFjM1sdJ2rbYdL3XlsdxXseXkcNsv7xnHX2zxAj9cwbcQaJi+drjlS1Bqo815R1V
	hcullekRjRX165X+IM3FyQrGJyzqRqABPH+Dog8+a/rvTOlOAFJ0Qbg5jzy+a89I
	PzputjVfcdEV0sF5wMeiW6flxKabD3RmkvYRJ8LEYR+AuAe6N3u2dQkZ1gylIPIm
	oVv2pe3ATlvu8XJFp1kzidaMV6c4jVa077aY3Ro1Le9plamrhSf8zMlohVPU4srQ
	E2grvB88H1J0TP5L3tMqGS5OtCvsahB1kKqG+G/SNUNToGRfOWQqA==
X-ME-Sender: <xms:T3YKYnzkjdrjCrcuRrEsfCWbwERlMRpPzJWvdLf2Veepv_w4SiEYuw>
    <xme:T3YKYvTM9_ujfvDkeT6uama7kmWmcfK4SqG-isJo7Fy7CT-_LQLhCpWHFqo4AI8lj
    S3bQIDvE6iUzw>
X-ME-Received: <xmr:T3YKYhXU9WoZ40K0bOiduG2JULfVACtJucTExDU7EdYY5PibxZxru7CtDchanzB5nl1eBjv39pkq37yf0pjJD1UIbqc80UAmhQ>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrjedvgdejfecutefuodetggdotefrodftvf
    curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
    uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
    fjughrpeffhffvuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepfdhmrghrmhgr
    rhgvkhesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmfdcuoehmrghrmhgrrh
    gvkhesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgv
    rhhnpeehveetfefhfedvtdeuuedvtddtvdeijeeuueejffduvefgvdekledtleduveffve
    enucffohhmrghinhepghhithhhuhgsrdgtohhmnecuvehluhhsthgvrhfuihiivgeptden
    ucfrrghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghrvghksehinhhvihhsihgslhgvth
    hhihhnghhslhgrsgdrtghomh
X-ME-Proxy: <xmx:UHYKYhiXdWXiI1i8X5qZLUxNJcAkB1kuYO578uY2OXoKDq2NVq9xcw>
    <xmx:UHYKYpCpNC97lcFFYwwmnO7IUeR4x2RuQtM7Rv1q7i7q6wZjWB7jPA>
    <xmx:UHYKYqIuahvsFO1d-MBElvmePwZHKXbZp-h67HZphKzHYXXDCBe-ig>
    <xmx:UHYKYoMGubzvHxGXuaPZTr-yfTnrwAGTTlt5RXsQXnNegzQewzkglg>
Date: Mon, 14 Feb 2022 16:33:31 +0100
From: "marmarek@invisiblethingslab.com" <marmarek@invisiblethingslab.com>
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
Cc: Dario Faggioli <dfaggioli@suse.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"sstabellini@kernel.org" <sstabellini@kernel.org>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	Anthony Perard <anthony.perard@citrix.com>
Subject: Re: SecureBoot and PCI passthrough with kernel lockdown in place (on
 Xen)
Message-ID: <Ygp2SxuxDTznDqyt@mail-itl>
References: <8daad0f6c623a57bc0b047fc2388e8b698135624.camel@suse.com>
 <55436ceb-3c6b-beff-5cac-eb83cb1bc44d@citrix.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="EoIB2nOmOXhg9dJ9"
Content-Disposition: inline
In-Reply-To: <55436ceb-3c6b-beff-5cac-eb83cb1bc44d@citrix.com>


--EoIB2nOmOXhg9dJ9
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Mon, 14 Feb 2022 16:33:31 +0100
From: "marmarek@invisiblethingslab.com" <marmarek@invisiblethingslab.com>
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
Cc: Dario Faggioli <dfaggioli@suse.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"sstabellini@kernel.org" <sstabellini@kernel.org>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	Anthony Perard <anthony.perard@citrix.com>
Subject: Re: SecureBoot and PCI passthrough with kernel lockdown in place (on
 Xen)

On Mon, Feb 14, 2022 at 03:25:31PM +0000, Andrew Cooper wrote:
> On 14/02/2022 15:02, Dario Faggioli wrote:
> > Hello,
> >
> > We have run into an issue when trying to use PCI passthrough for a Xen
> > VM running on an host where dom0 kernel is 5.14.21 (but we think it
> > could be any kernel > 5.4) and SecureBoot is enabled.
>=20
> Back up a bit...
>=20
> Xen doesn't support SecureBoot and there's a massive pile of work to
> make it function, let alone work in a way that MSFT aren't liable to
> revoke your cert on 0 notice.
>=20
> >
> > The error we get, when (for instance) trying to attach a device to an
> > (HVM) VM, on such system is:
> >
> > # xl pci-attach 2-fv-sles15sp4beta2 0000:58:03.0=20
> > libxl: error: libxl_qmp.c:1838:qmp_ev_parse_error_messages: Domain 12:F=
ailed to initialize 12/15, type =3D 0x1, rc: -1
> > libxl: error: libxl_pci.c:1777:device_pci_add_done: Domain 12:libxl__de=
vice_pci_add failed for PCI device 0:58:3.0 (rc -28)
> > libxl: error: libxl_device.c:1420:device_addrm_aocomplete: unable to ad=
d device
> >
> > QEMU, is telling us the following:
> >
> > [00:04.0] xen_pt_msix_init: Error: Can't open /dev/mem: Operation not p=
ermitted
> > [00:04.0] xen_pt_msix_size_init: Error: Internal error: Invalid xen_pt_=
msix_init.
> >
> > And the kernel reports this:
> >
> > Jan 27 16:20:53 narvi-sr860v2-bps-sles15sp4b2 kernel: Lockdown: qemu-sy=
stem-i38: /dev/mem,kmem,port is restricted; see man kernel_lockdown.7
> >
> > So, it's related to lockdown. Which AFAIUI it's consistent with the
> > fact that the problem only shows up when SecureBoot is enabled, as
> > that's implies lockdown. It's also consistent with the fact that we
> > don't seem to have any problems doing the same with a 5.3.x dom0
> > kernel... As there's no lockdown there!
> >
> > Some digging revealed that QEMU tries to open /dev/mem in
> > xen_pt_msix_init():
> >
> >     fd =3D open("/dev/mem", O_RDWR);
> >     ...
> >     msix->phys_iomem_base =3D
> >             mmap(NULL,
> >                  total_entries * PCI_MSIX_ENTRY_SIZE + msix->table_offs=
et_adjust,
> >                  PROT_READ,
> >                  MAP_SHARED | MAP_LOCKED,
> >                  fd,
> >                  msix->table_base + table_off - msix->table_offset_adju=
st);
> >     close(fd);
>=20
> Yes.=C2=A0 Use of /dev/mem is not permitted in lockdown mode.=C2=A0 This =
wants
> reworking into something which is lockdown compatible.

FWIW, Qubes has PCI passthrough working with qemu in stubdomain, which
works without access to /dev/mem in dom0. We do this, by disabling
MSI-X, including the above piece of code...

https://github.com/QubesOS/qubes-vmm-xen-stubdom-linux/blob/master/qemu/pat=
ches/0005-Disable-MSI-X-caps.patch

> The real elephant in the room is that privcmd is not remotely safe to
> use in a SecureBoot environment, because it lets any root userspace
> trivially escalate privilege into the dom0 kernel, bypassing the
> specific protection that SecureBoot is trying to achieve.

--=20
Best Regards,
Marek Marczykowski-G=C3=B3recki
Invisible Things Lab

--EoIB2nOmOXhg9dJ9
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmIKdkwACgkQ24/THMrX
1yzstwf9H9i1rJxKtby/dgBVYKyTYh9FFqy1q2Q+1hr/wYSrp7eg7+n+9CEPfSBn
Kys4MVk8LlUkl7XRXmJdPlV9A0jLJfjmZn/7P0OGBvBNWrOiUdU51P9ju9zL0zu4
nEKnJj2QwcAI8DjKksY9KQyK+ZS2ep2mzvKPWv4Sn0RtBiZOcF+t7i8mLlGKKrlz
KLf7jLIOLwHuFIGmu2fRloVW67rrCKdYZh8ZpVUImxdBtP/WMAoQHnJC0yyT0vJ3
ddbRJxF6FF0wz4vAzBpEJQpPHjCig7zOfeMJPCQbT9SU20UA6aIlZzr6FSsINfHK
OxL4DTusKg6S8McvgBSGAku5aGPDkw==
=cqqn
-----END PGP SIGNATURE-----

--EoIB2nOmOXhg9dJ9--


From xen-devel-bounces@lists.xenproject.org Mon Feb 14 15:36:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 15:36:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272455.467303 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJdOf-00014q-AZ; Mon, 14 Feb 2022 15:36:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272455.467303; Mon, 14 Feb 2022 15:36:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJdOf-00014j-77; Mon, 14 Feb 2022 15:36:13 +0000
Received: by outflank-mailman (input) for mailman id 272455;
 Mon, 14 Feb 2022 15:36:12 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qPn=S5=citrix.com=George.Dunlap@srs-se1.protection.inumbo.net>)
 id 1nJdOe-00014U-NW
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 15:36:12 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d4f29fba-8dab-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 16:36:11 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d4f29fba-8dab-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644852970;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:mime-version;
  bh=RFx7gPQ8zFQJy3ui2wSaA9ub02qInPINmmr4DkPN7Bw=;
  b=WmZuOMOuICutqjSUz8/glYUrsu2HQV8HhgToebsY2Ryhf7fivzDTdcSt
   yz+ftaB5Wt0+Ls9teqDdtCWzB7QS+kn24/5ppZAAYNEalpIn/OrbFBxuC
   WBXyOXGYaBknEsF7Azq/YUNe5eD5CpaecKtqXMVPr1Mbco3CgqLt9NkUO
   M=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=hardfail (body hash did not verify [final]) header.i=@citrix.onmicrosoft.com
IronPort-SDR: o9vyVlmjvUHj+3BNWYRy8TenAkXQ6tA/2GGtJFrzrigSXOXcwkMKZO0pV2vthwNTbQDsKskqNp
 60oYj8SVhS/JqjEx/UXFmIXvT73LJLLkD+ph6P/1MR78LOFDfMor/uVaYD+mUlcB2emMdFwD/d
 HxveQCnnzkq/2twTk5cSIuXOIbuwtPiUGzJCo4WJPt0pSB06acDsuQn9+e9vQnRl/bi5LpjiTm
 v3nUzi5TbzbIJPdcY+iWE97xzto1I5altoP+fLjf8wP5xNbEP0RsK9fzV+JHM50f8tGKqWBzoi
 PpxiSmBznsi9OcCp5V7LLcTH
X-SBRS: 5.1
X-MesageID: 64570459
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:CfMz/K4hlDDkVTlaCQTXMwxRtCzBchMFZxGqfqrLsTDasI4TYg02e
 lBvGjDRZK7OJyCgZYg1O70CxjoD75aAndAxTlc+/C42Q3tHo5ufC4rHIxauMX2fd5WYEkg/4
 stBZIefdJttQiGCqkb9P7S79nJ12fnYHrDwUufNUswdqXeIbQ944f40s7Jp0uaE+OSEPj5hm
 e8eguWBZA7+izB+bD5O4qmOo0gx46j/tWgUsAxkaflHt1aCmihJAMoTK5/qIiqjSOG4PAIbq
 8Uvbl2d1jmEl/v4Ior9yt4XSqCOK1LrFVDmZkB+AsBOuTAf4HxiukoHHKBEMx0P0WzVx4oZJ
 Ohl7vRcdy94ZsUgp8xFO/VoO3kW0XpuoeKvzdCX6KR//mWeG5fe66wG4HIeZOX0zt1fE2BWn
 cH0HRhWBvy1a0Ba95rgIgVkrpxLwMAGp+rzsFk4pd3SJa5OrZwu38wmTDKXtds9rpkmIBrQW
 yYWQQBEaEiHRSxBBm08ObEcmOi1u3fyfAQN/Tp5pYJvi4TS5Al40byrO9vJYN2aA85Smy50p
 EqfoT6/WEtDcoXCl3zVqRpAhceW9c//cK0fE6e3+7hGnVuXz3Q7AxwKT1qr5/K+jyZSXvoBd
 xFLonZz/MDe8mS7cfT7WRy4oEWgrx1HXNRfLPwH0w2Sn/+8DwGxWTFfE28phMYdnM0rQT0n0
 HeZktWvAiZg2JWOUm6U/LqQqTK0OAAWIHUEaCtCShEKi/H8pKkjgxSJScxseIa0kd/dCTz22
 yqNriU1m/MUl8Fj/4eR8E3DgjmsjoPUVQNz7QLSNkq14wU8aIO7aoiA7VnA8e0GPIufVkOGv
 nUPh46Z9u9mJY2EkSWWaPkOGLyv6OeINHvXhlsHInU6323zoTj5J9kWuWwgYhcyWioZRdP3S
 HX4vV8Wwq5dAEGBXIxVZ42sNsonwpG1QLwJScvoRtZJZ5FwciqO8ydveVOc0gjRraQ8rU0sE
 czFKJjxVB72HYwilWPrHLlFjdfH0whjnTu7eHzt8/iwPVNyjlaxQKxNDlaBZ/tRAEis8FSMq
 IY32ydnJnxivAzCjsv/rNR7wbMidyFT6XXKRyt/LLDrH+aeMDt9Y8I9OJt4E2Cfo4xbl/3T4
 la2UVJCxVz0iBXvcFvWNi8zOO6yBc8k9xrX2BDA2n7yhRAejXuHtv9DJ/Pbg5F7nACc8RKEZ
 6ZcIJjRahi+Yj/G5y4cffHAQH9KL3yWafa1F3P9OlAXJsc4LySQo4OMVla/pUEmU3vs3eNj8
 uLI6+8uacdaL+iUJJ2NM6zHIpLYlSV1pd+eqGOWfogNKB20qtACxu6YpqZfHvzg4C7rm1Oy/
 w2XHQ0Zta/KpYo0+8POnqeKs8GiFO4WI6aQNzOzAW+eOXaI82y975VHVerULznRWHmtoPepZ
 PlPzuG6O/oCxQ4Yv415Grdt7KQ/+9qw+OMKklU6RC3GPwaxF7dtAniaxs0T5KdD8aBU5FmtU
 UWV99gEZbjQYJH5EEQcLRYOZ/iY0a1GgSHb6Pk4eR2o5CJ+8Ledf19VOh2A1H5UILdvadt3y
 uY9os8GrQe4j0NyYNqBiylV8UWKL2ABDPp75s1LXtezh1NymF9YYJHaBivn2721ao1BYhswP
 zuZpKvenLAAlEDMRGU+SCrW1u1HiJVQ5B0TlA0eJ06Ek8buj+Ms2EED6iw+SwlYw0kV0+93P
 WQ3ZUR5Kb/XomVtjclHGWutBxtAFFuS/UmokwkFk2jQTk+JUG3RLTJiZbbRrR5Bq28MLCJG+
 Ly4yXr+VWe4dc786SI+REp5pqGxVtd27ADDxJiqEsnt80PWutY5bntCvVY1liY=
IronPort-HdrOrdr: A9a23:y8EJ66m83IFeR+MCRO3Mo0iHQ4fpDfOFimdD5ihNYBxZY6Wkfp
 +V8sjzhCWatN9OYh0dcIi7SdW9qXO1z+8Q3WBjB8bcYOCGghrnEGgG1+rfKlLbalXDH4JmpM
 Vdmu1FeaDN5DtB/IfHCWuDYq0dKbC8mcjC74q/vhRQpENRGttdBm9Ce12m+yZNNW577O8CZe
 OhD7181lydkBosH6GGL0hAe9KGi8zAlZrgbxJDLQUg8hOygTSh76O/OwSE3z8FOgk/gYsKwC
 zgqUjU96+ju/a0xlv3zGnI9albn9Pn159qGNGMsM4IMT/h4zzYJ7iJGofy/gzdktvfrGrCo+
 O85CvI+P4DrU85S1vF5CcFHTOQiQrGpUWSkWNwykGT3/ARDAhKevapw7gpKCcxonBQz+1Uwe
 ZF2XmUuIFQCg6FlCPh58LQXxUvjUasp2E++NRjwkC2weMlGc9sRKEkjQho+a07bWjHAUEcYZ
 5TJdCZ4OwTfUKRbnjfsGUqyNuwXm4rFhPDRkQZoMSa3zVfgXg8liIjtYMit2ZF8Ih4R4hP5u
 zCPKgtnLZSTtUOZaY4AOsaW8O4BmHEXBqJOmOPJlbsEr0BJhv22tLKyaRw4PvvdI0DzZM0lp
 iEWFREtXQqc0arEsGK1I0jyGGEfIx8Z0Wl9ihz3ekNhlTMfsucDcTYciFdryKJmYRqPvHm
X-IronPort-AV: E=Sophos;i="5.88,368,1635220800"; 
   d="asc'?scan'208";a="64570459"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=YYGvCdD8MPLurR+qbvmps2sQBDQ++/8gVjgTnrLr2TFDzsD9VMlWY8/adg+UkI9X3o1oOakFCtxlL9BD5cSuNWAkrmq2YA0hzxEc9SIHOmQfUdSLPJbS0RHXOWWUHXjqnRocKtONltzdoLddwaXo3VdS7Nwjvjz1kUB/aUZe41b50zMKddRJQNvP2ttlqyspbIoOAr+Ahsu9CL18lcxlp+XxDFk6Virmt9PmLfVVqMDjx0NZOW6FMRhXDxEDOcXQWNHSSoVt1lWgHLjBiEha1axz5pSNjyG+9+Y+c0xM6KL95sddw1+DY9dH4949462JK/a2G/rk4Z2dCJWmW/KHcg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=KtPux8MtF0qlE8SFqgbAGrfXqFA+XOtQMCO+QiG62eg=;
 b=J5rw7MV2YY6zh2iKtPPmm/UyikvnGko5eAGF+ZDPgblN3U9fu1yenk65zxIHgcbK7FDLc1RVhmUAHH2yPXqYbOPkc5zmVwY0ao1CISgaMU013b07Z9T6CEPAWiPAq784DWKsXCTZ0OiM8D68BJcrGq74j0l7/CdJpGdIi3AabRZ/F2JfwL7PLXPNXl6KXaxhb/KKjIEfQfdTUJrxPHXdgOcGVA+TIVwiXJvnoNqK94WAxRthlnT+ggNuVh+JUgbEZhtoa/VA7CJshesCrGbjeUoKZrxR5h/YpoOHdSQ4/n/RHE0yu3PaSWF5yPeZEwJvy+w/2wiy1Mke5MI46aaIIQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=KtPux8MtF0qlE8SFqgbAGrfXqFA+XOtQMCO+QiG62eg=;
 b=kuRbO5nQSljd2zKbYc73EZCeloG+kJOztlUENL3xX+dlunMCTPAeM+AbMymdtHQ0iPMSIvWMZRsZkYwBTaxyHLT6cr0sjB/NyVCZuDz49k/54MUD7emEkt3gdr/cuVYRQZoPH75JzY3OdwD2AkxSyu710zmZ+maqIJ91glcfq04=
From: George Dunlap <George.Dunlap@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Roger
 Pau Monne" <roger.pau@citrix.com>, Tamas K Lengyel <tamas@tklengyel.com>,
	Andrew Cooper <Andrew.Cooper3@citrix.com>, Ian Jackson <iwj@xenproject.org>,
	Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>
Subject: Re: [PATCH 13/16] shr_pages field is MEM_SHARING-only
Thread-Topic: [PATCH 13/16] shr_pages field is MEM_SHARING-only
Thread-Index: AQHXcbjK851LdePqFEqUaSPzO3BXl6yUjbMA
Date: Mon, 14 Feb 2022 15:36:02 +0000
Message-ID: <527BB238-450D-442B-BE94-91B5E64C6D2B@citrix.com>
References: <d1fd572d-5bfe-21d8-3b50-d9b0646ce2f0@suse.com>
 <ec21ca25-73bc-ddb7-8674-b7a59adb441c@suse.com>
In-Reply-To: <ec21ca25-73bc-ddb7-8674-b7a59adb441c@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3693.60.0.1.1)
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 2ad5835a-3d3c-4acc-175e-08d9efcfb571
x-ms-traffictypediagnostic: PH0PR03MB5719:EE_
x-microsoft-antispam-prvs: <PH0PR03MB57194DB79AB7D34C5B443ED499339@PH0PR03MB5719.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:6790;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: rAfE67x7darl1KGDJ3Vb22P28uhQoNfOpweF9bxj8Gb3yq4eamGAS+mIAQOuC+dDtCLmT8wduIoo8td6d3xAOneiQyY9iMUn6TPwqCnnsHlmUetp7aImt5CoXCwWmqaxV4vDQPBV4t3vQLlVDcpSP3n6AuWFiWgQbavPqnwAIptG+cy3bxHAh45eHhrmceEatdS6YswRCOb+MhfwmDXxWaWkTwPTNc2yilS7wIoV8fc77Zfhtpy6bozTziv44oHWnNDRXa8HyqbRzEAEQhgmFXnpiLrgR77q6fmT9lmkcEoirnLZxvCq1svTag2Ganql3vAWR+XmNCUCdVZ1rf/PAbiw77pYbeMFXCcMpUPwX8QbwEytjV2YdDx7Xsx223HJE1J9V0HGLC36yyQ1zrP3RBk/Dmvmu0JCgR4Mj5a2zC0KgOucmz/D1gcx/KpfRc8VDjzkMSlB5uFNVsZ8B+0PrDhIRaKK6yuj4pG16uuW/7b9eBA1MH+yVlzWLbMKEeBXBecFf4p+nXOzSLjclK5gaT9meuvInhD7Bz5pVnsrYSUFGPZpTd/QDRlbn6R5jucuuxwsZrz5hB19tVlRAUubVExH/0noc6kEQRwGUM4iphYBZoa377LBlwnmTDv3jrn/QGOcLWexH6LZ5h2w11wpb/rsoM+2kcQxcXX/uOWbQ0oD4afGfcMp5bOEoHHn39eE20O228j/qaUXyyJbhMfoAnfdqDs8vUex0VJt1yoUA0lb8lAOosgXOMGrDyjm39Bb
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6916009)(76116006)(4326008)(316002)(54906003)(2906002)(8936002)(5660300002)(4744005)(508600001)(91956017)(38070700005)(8676002)(66946007)(66556008)(6486002)(64756008)(66446008)(66476007)(33656002)(82960400001)(53546011)(26005)(186003)(71200400001)(38100700002)(2616005)(36756003)(99936003)(86362001)(6506007)(6512007)(83380400001)(122000001)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Sf+XK91DtLMA6K9XH6IyUixUb1RSjKnm28NLHL76+bLb5/pcOY/EuUp7M+CX?=
 =?us-ascii?Q?/2RqvdHAc1SxKpeZxE2izIYIU83sD3yn+q3/8uhOyXQ/C+jAALyYiXeHlEAN?=
 =?us-ascii?Q?YJSqEkFk3GCDWpVlrwq69wzQObvzBKHoxasf3s74NHI8mNfas2c5gMlzr6N5?=
 =?us-ascii?Q?EJ1xY8DW1ckFwCjELzNV5uM4t6EWG2zB1hFbdux9bajjpHoYr4Xkdl/OPYLg?=
 =?us-ascii?Q?5Vl+7WOnD1QQ13QJCQ9bK8ExRFmlRb1ss1gF0Zfs+xD6l7H66fHD/0S80w2h?=
 =?us-ascii?Q?jvUwR9BG1wG3Lae7SLJBA1ysQccoAJqZHwNdPi9VO6R3GS4fhc9zS2alVk8w?=
 =?us-ascii?Q?BFVm7y/7MDducowpg4g4b6Ibas+99B4tMV18aKzNxTahgAKFQ3P1N4BYEmdO?=
 =?us-ascii?Q?FZYk4G3Ym3G17Q+xIYRhDbWfy1w8v1KnROCo43FqnOnsgvb37AzmbnekV7ni?=
 =?us-ascii?Q?e7EmgcNLeJeSxXuHuO+4xtZpGWnYg3LLEJU1NTF0rjq5rgSu0INmQ0/6dEPv?=
 =?us-ascii?Q?W6/kqRtBPD+mc0ioc5EOZyEA6k0Cvwe3j3uSmtB2Rx5mcvC3IVGWyZtF2GA8?=
 =?us-ascii?Q?/uEIOBgXxHrNi8Yeo8u8Fp8BrEOs06FhmGR58Ty76RLriGh0XAP8GJ5WJXLr?=
 =?us-ascii?Q?JK/0H39tHYXCsY9WMNj70oVWVyQlaX8FW9s9NLNMJKq+TZQdDyk2/BhlvbSd?=
 =?us-ascii?Q?lzOR07KapKToz2J9m6nU/7Yvl3A5Wrx7nhfBIPjFVdKOqz0z/eKAhvJ4L2dz?=
 =?us-ascii?Q?f698bH6bXV5z4Jza9/BNYJDuOFOpZz6fmljjo3HsWv2eA1usJhnmQONsMM3k?=
 =?us-ascii?Q?y5D0kCh8FMTyYptjjEuNtYKg9czAOQdTNWq6RzBIuRKkEnHVeB37d34OEjEZ?=
 =?us-ascii?Q?gm/u4T4acUWrwX4gCoVytXI7nS9u1WIyx56WHhlXrRmH78rgpJi71Ka2frqB?=
 =?us-ascii?Q?r/320nWgjmSHYfyqN+SMGVCjdgMIz7yvKY7ikeSKruMBgaq+EzNti8L8IyEQ?=
 =?us-ascii?Q?blIGfdo23BlKsp1MnYFX3hkUecGVTKpxc4P5Vh6yRntgjwaQ62GJ7EWDwzfl?=
 =?us-ascii?Q?yVQe9SLSJFatwZkDS8JAiROSHofNyX9l6NdRfs0iIG+Wz+p8s5/qZPC3wdLQ?=
 =?us-ascii?Q?eONBcYx3s7xMbmeLvWO1LaU9n6QRPcqMqayg2wNLPl1XpLcq1Omo5J2Zdwwi?=
 =?us-ascii?Q?9NOWn4NzuW0hmSMG1p0XEnlh7rBn0e2s28eq7HdJyXqOaGuhdF7pWjdMHghj?=
 =?us-ascii?Q?rc+eh23O/ABxK/P7FkUVVtNCsrUOsSD95uppGa+Mq28jOt2KR2NzAmrtFAQO?=
 =?us-ascii?Q?EwgZ+w8GH2p3iQEtokSHuvtCcFfxB/lAvaOClcHSYHNJFSagT1MWOxtAl/aH?=
 =?us-ascii?Q?6IH+sKwaY998SzTtGEz+ytnpf4G/4YrG4OHI0ycfNB7OPfKWuxz3dGsluk+H?=
 =?us-ascii?Q?CiZuVM3xNx1BEhnNY72S/ZyjeL7uyibed4h4EW567EVfh402OfON3sQM4Xyz?=
 =?us-ascii?Q?NRSar01d0MgJiAYx1oEvx1ClBGxRnobaeg+HpjpP5VLnLobrFmE4JcEYfasJ?=
 =?us-ascii?Q?8s8wsxG57GwUyFB2TMZjclTpx6TLWiG1vhgGPve6z4dOHXmZTLgFQ/CfeGm8?=
 =?us-ascii?Q?8N2M1iIc6H7CNS8IvM8FQaksyRbtYiKHXpNwmRl5Rh2Xq8H9xP0EP0FoyuDz?=
 =?us-ascii?Q?IzI2fOXaNb2sWkrgKwr0vQPL6G4=3D?=
Content-Type: multipart/signed;
	boundary="Apple-Mail=_99BDEA2D-AC09-4244-BC91-E0716D861E74";
	protocol="application/pgp-signature";
	micalg=pgp-sha512
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2ad5835a-3d3c-4acc-175e-08d9efcfb571
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Feb 2022 15:36:02.9586
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 2c2WcEQUUrpwcBYrbpjCThH6AZ8g9XBDnf8lGYZhjCogYq0l5tVYXmRT4oE3VuRT1E2/mpJuRpMSa4IgzUfZ8pWKod9GI+8MYBHnmxsMb14=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB5719
X-OriginatorOrg: citrix.com

--Apple-Mail=_99BDEA2D-AC09-4244-BC91-E0716D861E74
Content-Transfer-Encoding: 7bit
Content-Type: text/plain;
	charset=us-ascii



> On Jul 5, 2021, at 5:13 PM, Jan Beulich <JBeulich@suse.com> wrote:
> 
> Conditionalize it and its uses accordingly. The main goal though is to
> demonstrate that x86's p2m_teardown() is now empty when !HVM, which in
> particular means the last remaining use of p2m_lock() in this cases goes
> away.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: George Dunlap <george.dunlap@citrix.com>


--Apple-Mail=_99BDEA2D-AC09-4244-BC91-E0716D861E74
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="signature.asc"
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEj3+7SZ4EDefWZFyCshXHp8eEG+0FAmIKduIACgkQshXHp8eE
G+1YdggAisUcrRHF+Q21kgJFzWHCT+AtmxeNiIFVOK+tqSfsSKu8s44KtdYefspY
ngDy2x97gOCN3me8XWoXXh9rbaWqgg/tzO4zn/MEIhQA+Qi9e4iuVrwPE2/20cFc
ljESCbUASbIj5PXrQ1P3o1gAL91sxie2toKiA2o2Yn9U0pZjRdmGEsuTdXNEzM3W
PTQhso/TTGo5uqfNnXVCQXlMOxCWtj4GAPhPC65DOC+5KeyOHNsqhC8ZkBtWyRi6
MtN6202vf8uaTj/Pwzj4g9EawTUtcrO7FtD/FiolhWylPd6dj/FPyvFOv6qXOcRX
sWR6BuuNBUc6o+8Xf4T0P1uTvzGZFA==
=9T6O
-----END PGP SIGNATURE-----

--Apple-Mail=_99BDEA2D-AC09-4244-BC91-E0716D861E74--


From xen-devel-bounces@lists.xenproject.org Mon Feb 14 15:39:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 15:39:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272462.467313 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJdRB-0001gX-Nk; Mon, 14 Feb 2022 15:38:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272462.467313; Mon, 14 Feb 2022 15:38:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJdRB-0001gQ-Kk; Mon, 14 Feb 2022 15:38:49 +0000
Received: by outflank-mailman (input) for mailman id 272462;
 Mon, 14 Feb 2022 15:38:48 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qPn=S5=citrix.com=George.Dunlap@srs-se1.protection.inumbo.net>)
 id 1nJdRA-0001gC-Ej
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 15:38:48 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 318cb99b-8dac-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 16:38:47 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 318cb99b-8dac-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644853126;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:mime-version;
  bh=3oSBNKou66fHFm8DM8EiEacYZyHygRmIblUnXFm8WaE=;
  b=KI+OOB0zrhirWX5ZochhZfOCzxi6mrWJZnaW6CMbVdJMB5I98KROqEZN
   5MQjVNaPkIvNykOtZNEoZHteePJB0EFKVBcqujt9KPolu3kbHaiiOAHPr
   /kzHzrmZTJbHLMMeOVg4gVGnRNoo6w7I98TTsOOp/iDE6QmJzPnNCFr3R
   w=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=hardfail (body hash did not verify [final]) header.i=@citrix.onmicrosoft.com
IronPort-SDR: jvKE7cPBcnscUzHn2tvOvpv0BHVOEdtT51gHUXd5LnE/w2R6b7bpTgPxSKpaGH0KDuAor+keo5
 zQmvZnV7rpCoQ+beL/xRueCy0lm0V6Dd/H6SA72gY1NXmGVbtnCMJcWhQrCOXKCbjTMGTd1P25
 bHjVvDljJ9tn6JbjjeEme05pe6Em7+aGr+Wi84zOIDWQC0YmWareqflPOUBe7KBcyyEYeThSil
 vYLnImcGjyC2j5KvDSMOnWzooGGs2jMWOPODR14PXQAfw/3NDc/fttyzJV8WMnjG3Po+H4o3Yl
 NYt+M87bE/AE9/stVsM3wGIP
X-SBRS: 5.1
X-MesageID: 63607896
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:iEVuF6NtFDCvvWfvrR2xkcFynXyQoLVcMsEvi/8bNLWB5Y4Qp3Zem
 TxOHSzEb+HbITHFz+oGPoy/oB4GvZWAyoBrS1Bp/n02Fnwb9sDJXt3Fdh2rYH/IcJTKEEtt5
 sxGMtXJfJ44E3GC9k71brW49CYti6zWGNIQZAK81gVZHGeIHw992UILd5cFv7NVbfiF7yKl4
 Y+vrseAYQSogGQraT1L4fOJpUM1tvj56DhFsA1gO6Ea4FOGm3crV59OfqvZw1kU42V38kxWY
 86ZkdlVK0uAp09F5utIFt8XS2VSKlLoFVHmZkF+Bu7y0nCumgRoivxhbKBFNR8N49m0t4sZJ
 Otl5MTYpTgBZsUgqMxFO/WPO3gjVUHu0OavzUmX6aR//WWfG5ff66wG4HUNFZ8Z4o5K7VRmr
 pT0Htyvgier3IpayJrjIgVla19KwMPDZOvzsVk4pd3V4GpPrTkujMwm6PcBtArciPyiEt6ZO
 9dDQzB9TS/jbjZiCE8YE5URtfm30yyXnz1w8Dp5pIIy6mnXigdwzKLsIJzefdniqcd9xxjC4
 DicpiKgX09cZIf3JTmtqxpAgsfgkCThV49UOKC+8vdyqFaS2nYSGFsdUl7TTfyR1BXgA40Pe
 hJ8FiwGio8I10COQefHQACGnm6isU5FedV0OrhvgO2K4vWNuFvIboQedRZDddgnuckeVTEsk
 FiTkLvBHidzubeYTXac8La8rj6oPyURa2gYakcsUg8t89Tl5oYpgXrnT8lhOL64iMXvHjP9y
 CzMqzIx750xp8MW06Sw/Xjcnimh4JPOS2Yd9gjRG26o8A59TIqkfJCzr0jW6+5aK4SURUXHu
 2IL8+CC5eUHFrmRlyiARuocEbXv7PGAWAAwmnY2QcNnrW70vSf+I8YAu1mSOXuFLO5DJSKzS
 kXBmDhy6bR+DmOldqhYSpyuXpFCIbfbKfzpUfXdb9xra5d3dROa8CwGWXN8z1wBg2B3z/hhZ
 M7zndKESC9DVP85lGbeq/I1jOdzrh3S018/UnwSI/6P9bOFLECYRr4eWLdlRrBotfjUyOk5H
 js2Cidr9/m9eLCkCsU02dRKRbzvEZTcLcqow/G7jsbZfmJb9JgJUpc9O48JdY1/hLhynezV5
 Hy7UUIw4AOh2SGYeVXXNyg6M+mHsXNDQZUTZ3JEALpV8yJ7PdbHAFk3K/PbgoXLBMQ8lKUpH
 pHpiu2LA+hVSySvxtjuRcKVkWCWTzzy3VjmF3P8OFAXJsc8LySUqo6MVla+r0EmU3vo3fbSV
 pX9j2s3t7JYHF88ZCsXAdryp26MUY81xr4jARuQeoMLEKgumaAzQxHMYjYMC5xkAT3IxyeA1
 hbQBhEdpOLXpJQy/sWPjqeBx7pF2cMkdqaDN2WEv7uwKwfA+W+vnd1JXOqSJGiPX2Lo4qSyI
 +5SyqikYvEAmV9Ltat6Eqpqkv1it4e++ecCw1Q2BmjPYnSqFqhkfiuM0/5Qu/Af3bReowa3B
 B6Co4EIJbWTNcr5O1cNPw55PP+b3PQZl2CKv/Q4KUn3/gFt+7+DXRkANhWAknUFfrB0LJkk0
 aEqv8tPs16zjR8jM9CniCFI9jvTcixcAvt/7pxDWd3lkAsmzF1GcKfwMC6u7cHdcchIP2krP
 iSQ2PjIiYNDyxeQaHE0D3XMg7ZQ3MxcpBBQwVYeDF2Vgd6Z1OQv1Rhc/DlrHARYyhJLj7B6N
 mRxbhAnIKyP+3FjhdRZXnDqEAZEXUXL9kv0wloPtWvYU0j3CTCdcDxjYb6ArBID7mZRXjlH5
 7XJmm/qXAHjcNz1wiZvC1VurObuTIAp+wDP8Cx98x9pw3XujeLZv5KT
IronPort-HdrOrdr: A9a23:fL+cJqsrqRYST39V7SezNgjb7skDFdV00zEX/kB9WHVpm62j9/
 xG+c5x6faaslsssR0b8+xoW5PgfZqjz/FICOAqVN+ftWLd1FdAQrsN0bff
X-IronPort-AV: E=Sophos;i="5.88,368,1635220800"; 
   d="asc'?scan'208";a="63607896"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=B4mLUh9nBo9LQIE9d4BPreoo7HHelQwMHeScuOeBAPRzlOSscZCNZM29ddHtpvuNWTyJZs9gBwg9RzsULWABp3540JmzieDs+I+9OUnvsT+jBBzHY56hZLarOqMYFsXgIRqvGbIvHjCFcYMm/mG6fpJHLDd2+Z3IZdq8RL8XA6bbt22m6dgzsP7BL9ZtrzD/o244FiiyUkckFkZPvo2YnWW6VhbTBnDkQWBaP/K60EFRUCrqfHhLAEDfJiMdw/x5+3QhGnmQd3ZFQU/RgtNYtF3UTszRUobL7t0OkY+2lVBo5VHNtrUVjv3pOxsPrrOG/BH7VmsEYsUfYjlt4JTuog==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=cnqExeOU8zdxFQsf/DLx8fidRLtrXMepj8Axlx2cv44=;
 b=MS+XdJcaZ4c+E2sr0RSJ2/jUa6mQzBgOeXAcKx5h6XoQJBtDmIZMmDkgz7PX+cLrpVUkUBW7KCErMw5fOqEqKnoznpM17oRyGazI8Tf4f3XQoesgihzikkEVwXAEgj2C1/HZ7PL+Q0Su1qWkam8RYBurEF3GsSz9KbI1e0AuRhhXxKGnjzae3CvSVAA7zKIKymy27EQyjO8+w8M44PURtmTSvoXt1nK7pfXarVYshNCFvmRogoGih1W86sbV6Wxxt1f9zLaqoDikS5L3yIeu8PWL2KyYz3X68nrBYgPVWTDMU6/GCGNqyt8Ivaj+qzxVtW22QVeUhrrrBu8JgXx49w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=cnqExeOU8zdxFQsf/DLx8fidRLtrXMepj8Axlx2cv44=;
 b=D+pmUc8ZhK1esWPr3c1DcT3KP8giD4RqfypEstDqRButc0FUXkVQsE0uK07x2H4fsU4AhFz8IG/lYx17GbB7y1fakapl4d7+nwJx59p33liFM1ChdyG/ciDqR7hOV1jOrDxxIO2lJrcg6bqcB2RL4RkOST6zUrkx+FZehGhQ6HI=
From: George Dunlap <George.Dunlap@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Roger
 Pau Monne" <roger.pau@citrix.com>, Tamas K Lengyel <tamas@tklengyel.com>,
	Andrew Cooper <Andrew.Cooper3@citrix.com>, Ian Jackson <iwj@xenproject.org>,
	Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>
Subject: Re: [PATCH 14/16] paged_pages field is MEM_PAGING-only
Thread-Topic: [PATCH 14/16] paged_pages field is MEM_PAGING-only
Thread-Index: AQHXcbjXAk59gab870CDDmzd/HViC6yUjm8A
Date: Mon, 14 Feb 2022 15:38:41 +0000
Message-ID: <A010DC27-7DF9-45EC-8A50-449C94516D86@citrix.com>
References: <d1fd572d-5bfe-21d8-3b50-d9b0646ce2f0@suse.com>
 <ab136038-0242-086c-9e67-02c47e1db3e0@suse.com>
In-Reply-To: <ab136038-0242-086c-9e67-02c47e1db3e0@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3693.60.0.1.1)
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: c3fb089f-b311-4305-02db-08d9efd013b2
x-ms-traffictypediagnostic: SJ0PR03MB5792:EE_
x-microsoft-antispam-prvs: <SJ0PR03MB5792469E5B002F0A53CBDDDD99339@SJ0PR03MB5792.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:820;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: tC6hIyTCfCA3Hw7TDiObFSBbPCpjp4pKRSRT0R/ft5rxi2BV5QPk7kIIpS4iy0kC911PcLsIxe98sseq3JZS6fGrr5MOGrqG6+LsgqHM4AxuXXpLZ8Vf6ZyMtYqMYPsDibP5WGqM+HhRWe+6+ROgVfl33CFlkLXmuTpLupibGr776AVgFdgzioZw2IpXDR/KpkyfOCCSR/ARC2MN9RqwgZNj3dNC7xj5SpbgyYo9FYHcyjPB2mJdZPc/CLgYgJ0JkkRG9UMv0+EHesHivcOVYe5REEk9Q2Bt9yPCBf8vGsPi1+YBcSJsOn85DGmC1A9qdqQi1W6yxuDzhGmN/Q1y3yQxFXmbj+0Ozj++WQ9Sfu6gbkyG++E8r4eX9k20YZRFVW1ww+xuJ18YWU2vOaYifDn0wW5qtmUUpxGGnMsWkCA4225+lEWQpxyk/BSySvzq3XCtv4XPUwuQDKVBpeGdaadqyZG5Uqe3J16SKLPWYX9d5bsoX3LEkNTMnGlyQC3orlGWefbHrQm96WHQdVDtooKC9ahhGdp5UWNO686nRZIdV1wjyDomOGU2uyisI1mGEgBmCKzyLoBZ37Rd8pV7w0y6RbPcIj8b4YZOQR3F1t37h+ou6CS4ZjS6gPlsXW2PDfH0NsMhiWCUUH//XQLbRcmZV3cKrWKCOJE0iuHYtHggjJjZf7Axc+LBd9uAsyZsvDVsJlJH2XaQQU9MlxkEUgKNPIZoefBnj6RgeAg/AdmFm7hi3ZICAH2WFPUj7s6K
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(508600001)(53546011)(38100700002)(4326008)(91956017)(76116006)(64756008)(66446008)(66476007)(66556008)(66946007)(8676002)(26005)(186003)(6486002)(6506007)(6512007)(54906003)(71200400001)(316002)(558084003)(36756003)(6916009)(2616005)(2906002)(38070700005)(33656002)(86362001)(8936002)(82960400001)(99936003)(5660300002)(122000001)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?okz5PkCrYqrvxSg4WvL7M8x7LXUpHoiAyZnY1oT+/SM6x1QdjTlWD8tzDiLy?=
 =?us-ascii?Q?ctQeXtY2PCIhIavvOy6+AlbRQJAqkWJyPiQ4P5Gtdvue/IB7hcWyRc+q+KH9?=
 =?us-ascii?Q?G8kVuJf32K3bFgCqlsw1YXwLCaE1ZxMbSvBg2pyspLCP84WSRTbCnCocgVmW?=
 =?us-ascii?Q?N+Y67yt3fTMH80Jjn6mz0hHyA1E2AvZLwySHehwfivIxmcsXadl4bkNstGnK?=
 =?us-ascii?Q?RekMNyARv+QJ9VBb0D0xhqjEC/Paa/124w3M6qrdJqTwjmMZeb6Xn/sma7Ob?=
 =?us-ascii?Q?W59doNRW66q3L2B74sX9RO0JrsJt8wix02wuzCU32PKEhwH4OedKjSy18Ebo?=
 =?us-ascii?Q?uWiac0Z1zuN8+TZbc6uZTqDmzOHGLva82ra5rDDwUWkEBWjety+j6AUh+Q8W?=
 =?us-ascii?Q?PTrRQUONe1Heaed2Go3NZvS0NnwujRVRwE0//tiOxOsZFSCiIK4gZbjKDyW4?=
 =?us-ascii?Q?xESTbBkDw1zlU7c+k0g60FllCxujdSfBhl07xqhiGY+xXLcNfPk9f5VrO4sY?=
 =?us-ascii?Q?ap4e/IQIbqznYNcl8Z6MgZyR7zmACmA+cbCvHbF1i5XEjv8tunNRe170dP/k?=
 =?us-ascii?Q?XbtPrPaLkqPKKj2hx788rJGnWcaQeY124AyKycHwaI0VeXOSnj7JLHQAJuJl?=
 =?us-ascii?Q?WpMHLHhBF5xfgiesU8rT9UEYEMVCp9du78L1jQKTLgoedUH6/w7tlkN1bhLz?=
 =?us-ascii?Q?X+xOqATGrW7zdamkwzsvfb4hn6H7+T5prlAfu5Hz6ne06vEtYHQwAgyc7XAt?=
 =?us-ascii?Q?Pown0GYuMepk3D9wuPehS7xkMVpqY1t8ROVMnCfnaLqKH3neyEyf13fYxGpW?=
 =?us-ascii?Q?/Da3yXg7hd8jMaOzc/6jNAtQSC3CQ83MNWn55oK/MBazXL9a721TehTPHxT6?=
 =?us-ascii?Q?tDXCsaoXqHt0W/xBjQRjtSdRQ4j2A/FQz9EBgMHBe8phfjWx1MOTMqv5OyXG?=
 =?us-ascii?Q?2nDLbz5K5smfjWOQ+P4IW9+70h0WJRgmBm/0BhmzuaTC1rXkyLjLjveNR2Xk?=
 =?us-ascii?Q?3dTUYLOZuLyBZlMEUR5iOWwUEKj/8z1P+rPbjoN4VfAdEe15Ex4B0l09hs6l?=
 =?us-ascii?Q?o5rjuMGuLBb5GED1PM9lk/VHQyQ32lY5qxnxmT5s85xIc+qiebaEsXT/iDvs?=
 =?us-ascii?Q?brNkq3I0dUfegmY16NrMFWpzDgzv+gPzLOVOWX7BdC346/+fw5Y9n9In/ARG?=
 =?us-ascii?Q?4KY39ZV57TVC2wbRGBXSiVWfVuLJidU0m3kedow5zGPemBCS62DIWsaPZmn8?=
 =?us-ascii?Q?zf1U6BuTioAOrkzol4g2DwbjuWj12BxZxVLNT7DRYoRtPcBhmy2DlCiqnlvQ?=
 =?us-ascii?Q?NxOtxbVQ6gBki3Fm+FduBSQz2iapbZzJrV3oG5i8w6jf8tQ9oMVcX1D+vubY?=
 =?us-ascii?Q?dH1wjuK1nNKDqAOelIPbMWLj9x/FnDQwlyWOEo7fk5U9oSNcd/G6Gv/Wny6K?=
 =?us-ascii?Q?fxhui7yQmBat2UqRjPYTglZJj7jng3/8ZO2uLjjia7cg2R5ujXboXTggTo39?=
 =?us-ascii?Q?TFvv1sIz42nDdln7EuVYibcfGcbfmEKrQwUqcUweDgpqy+UtMCC6JDEa/oHl?=
 =?us-ascii?Q?hAFABVjSTpXZ7JpEdBd7UPY96qiGry8/RmYSROtU94RmHRexs/+i3RZb+VxQ?=
 =?us-ascii?Q?DW9Inr6CqJ2uNAiHVTo2Bpvr9Q5rXITr6EO23imgG+4hRxH1J9N8dlBiA1YP?=
 =?us-ascii?Q?e1R41PbxBqAjlgTSbOs4Sf95+ok=3D?=
Content-Type: multipart/signed;
	boundary="Apple-Mail=_21C60BE4-85A4-4486-B441-ABC4FE3C6D69";
	protocol="application/pgp-signature";
	micalg=pgp-sha512
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c3fb089f-b311-4305-02db-08d9efd013b2
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Feb 2022 15:38:41.0899
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: O4I03x6xdeXBOREx/Hq/1g2PkmIN5WskjbSVnsA/s/6EFDj1ZguMWF4CMtqPaewbkupup75GXfTCi5uERlByCzdTlAROfZRvNSyUE3ZlLww=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5792
X-OriginatorOrg: citrix.com

--Apple-Mail=_21C60BE4-85A4-4486-B441-ABC4FE3C6D69
Content-Transfer-Encoding: 7bit
Content-Type: text/plain;
	charset=us-ascii



> On Jul 5, 2021, at 5:14 PM, Jan Beulich <JBeulich@suse.com> wrote:
> 
> Conditionalize it and its uses accordingly.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: George Dunlap <george.dunlap@citrix.com>


--Apple-Mail=_21C60BE4-85A4-4486-B441-ABC4FE3C6D69
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="signature.asc"
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEj3+7SZ4EDefWZFyCshXHp8eEG+0FAmIKd4AACgkQshXHp8eE
G+1F5Qf8CzKlePNIxSfy5Y5O40stzm8dNX/GcJ2GOmQZIZQacZTODtvVlW0sW+PJ
FGHfoIsGByheJ8d/KXGWzRomMCqKQc90bOcaVmTdfQdtbCvhsV5o51E9RuIaZPGT
CJ2tHu6mAUFF6pxgSVjxiX6FD641zFjlR/QwpHlKERl4nKcYdbckzD9wq+dlF36K
23ApzCC7EiyIf5bmbcZLzMMg6lNWHHq0A3wv2LIVQ+XQAAspbtuq6xAbdad5EKAP
UCIsaNn8j8hgvTdtYIYFFDtIybodrWmKxhE8+Mmd90kVG6NCFBdzFYJbPByXmT6z
0tcTMAIbWkf45jybSuSkXwORINpPWQ==
=zobG
-----END PGP SIGNATURE-----

--Apple-Mail=_21C60BE4-85A4-4486-B441-ABC4FE3C6D69--


From xen-devel-bounces@lists.xenproject.org Mon Feb 14 15:40:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 15:40:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272470.467325 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJdST-00035T-85; Mon, 14 Feb 2022 15:40:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272470.467325; Mon, 14 Feb 2022 15:40:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJdST-00035M-31; Mon, 14 Feb 2022 15:40:09 +0000
Received: by outflank-mailman (input) for mailman id 272470;
 Mon, 14 Feb 2022 15:40:07 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qPn=S5=citrix.com=George.Dunlap@srs-se1.protection.inumbo.net>)
 id 1nJdSR-00031p-NB
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 15:40:07 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 60bfc221-8dac-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 16:40:06 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 60bfc221-8dac-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644853205;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:mime-version;
  bh=vX6X4mvJ1o3sQayLH7VjW7RyiH3ENeeEMcSgtjrVuoc=;
  b=Cyiack4UqIE0gMDQ2R3HM8f2bA0dxxggqknnBPrPPS0kLv90QZwvE6zv
   KW38gB9imba6B+ygPox43zXWFnH2GDjeMF8gdFo5sfjnaiMMwm1H9YUeV
   qFDqi4X/0hRPKpEK72wIbaeSevSEIltakLJswxlEBf+ldD+J3aAAwEyQ9
   I=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=hardfail (body hash did not verify [final]) header.i=@citrix.onmicrosoft.com
IronPort-SDR: FCRoe1yuHMpiCOrNooWCjs2ymhMkpQN9R/ZG7Eujeze8V1t8C2ZOSmgMedFWqTUc/TeTxln195
 oF9+o2iZPwGJT/PA0mZVIsXyXks+EBu1dLR4MEQ8F7ri3kyPGNiNJAmEAAODHcwZxqPB0FklFs
 4XcXeNl1FnatM6BT+/XBXcJpeo04E9D/RAaxawUEuDc/RUWgUoM5awH54U+8ax4W5kSl1xWDhE
 nvZokQOM+674LXdSwwgDg16OA+w7sEUdMpMAzKo2ydjgLcvAarc4zy22BJvtAekUTc/40O/Dsf
 KJNrEANz7fjKvFQxcNSaT9Zd
X-SBRS: 5.1
X-MesageID: 64066256
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:1+EMmKJKa1fbEY8nFE+RlJMlxSXFcZb7ZxGr2PjLsTEM7AuW5UVEl
 zVBCC3DeKqUMyGmS21FGIvn/EgFusCGyoNmSQFo+X88FnhH8pqVCIzGcxqoNXKedJebFhk+4
 59DMNPNJZppH3OBr0j2Oeft8nIi3/jZGuGU5IIoQsxUbVYMpHAJ1UIz8wJAvrNVvDSZP++sk
 Yn++8SGZA78ijArPm9MsP3bokpitfii6W5D5gJvOKkW7QPSz3UbMskSdPq7R5farii4PQIYq
 8LrluzRErbxpk91Yj+dfzKSnnQiGtY+ByDX4pZtc/Xk0kgqShAaiP5hbqJGMBsP0V1lovgqo
 Dlznc3oIesWFvWkdNQ1C3G0xAknYMWqUJeeSZSOmZT7I3/uKhMA8N03ZK0CBqUK+/4fPI173
 adwxAbhzPy0r7neLLqTEoGAjym4RSXhFNt3VnpIlVk1ARu6KHxqrmqjCdJwhV8Nas5y8fn2N
 sUedCJKXBD6cyJLYXQwDb0OmOyVmSyqG9FYgAr9Sasf5mHSyEp60aT3McqTcduPLSlXth/G/
 CScpT2/W0xEcozEodaG2ivEauvnsi78Qo0fUpGl8PpjmHWYx3AJCQ1QXly+yRW8ohDiA4wBc
 RFKksYohbkP1mioRYXCZi+9rkaPuCxMcOENKuJvvWlhzYKLul3EVwDoVAVpd9gOpMIwAzsw2
 Tehj97vQDBirrCRYXac7auP6yO/PzAPKm0PbjNCShEKi/HBiowuihPETv54DbW4yNbyHFnNL
 yui9XZkwe9J1IhSivv9rQuvby+QSobhHwEy+x3ybmaf/jx9P62CYqOY7VPm8qMVRGqGdWWps
 H8BksmYyekBC5CRiSCAKNkw8KGVC+Wta2OF3wM2d3U133H0oiP4I9gMiN1rDBoxaq45lSnVj
 Fg/UO+7zLtaJzOUYKB+eOpd4Ox6nPG7RbwJuh05B+eig6SdlifapkmChmbKhggBdXTAdollZ
 /+mnT6EVypyNEie5GPeqx0h+bEq3Dsi4mjYWIr2yR+quZLHOiLJFudVbQbWN7tjhE9hnOky2
 4wBX/ZmNj0FCLGuCsUp2dJ7wa82wYgTWsmt9p0/mh+rKQt6AmAxY8I9Mpt6E7GJa599z7+Sl
 lnkAxcw4AOm2RXvdFXbAlg+OeiHdcsu8hoG0dkEYA/AN44LOt30ss/ytvIfINEayQCU5aAoH
 qdVI53aWpyiiF3volwgUHU0l6Q/HDyDjgOSJSu1Jj85ep9rXQvS/dH4OADo8UEz4uCf7KPSe
 pWsiVHWR4QtXQNnAJqEYf6j1Qrp73MchPhzTw3DJdwKIBfg941jKirQiP4rIp5TdUWfl2XCj
 wvGUw0FoeTtopMu9IWbj66zsIr0QfB1GVBXHjeH4O/uZzXa5Geq3aRJTP2MIWLGTGrx9aj7P
 bdVwvjwPecphlFPt4YgQb9nwbhnv4nkpqNAzxQiF3LONgz5BrRlK3iA/M9OqqwSmeMJ5VroA
 hqCo4AIN6+INcXpFE8qCDAkNunTh+sJnjTy7OguJBmo7iFA47faA15ZOAOBiXIBIeItYp8l2
 +oopOUf9xe71kgxKt+Dgy1ZqzaMI3gHX/l1v50WGta22A8iy1UEap3AEC7mppqIbowUYEUtJ
 zaVgovEhqhdmRWeIyZiSyCV0LoPn4kKtTBL0EQGdgaAldfyj/Mq2AFcrGYsRQNPwxQbi+9+N
 wCH7aGuyXliK9uwuPV+Yg==
IronPort-HdrOrdr: A9a23:3GdJla4rXsIc71wcngPXwKvXdLJyesId70hD6qkRc3xom6mj/P
 xG88536faZslwssRIb+OxoRpPufZq0z/cc3WB7B9uftWfd1leVEA==
X-IronPort-AV: E=Sophos;i="5.88,368,1635220800"; 
   d="asc'?scan'208";a="64066256"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=njsaKCBaA6TlEF6afIK0j10tE7TdevS5pmfC2I0h8CKR7QsaDzTZrgWTe+4NmAwaQXIuzhjrF94AQ7LKjUldsF33FKTIXOz0AhkwwK9HCzHJWOtBa/Vw6aq3TtPqhVj1v7U+aqmfFRFb2MQySWpPB2lkOnjcg7dDytdv7QMN+OVEcNGXpuEcNjwlF/V8N1bxesaSVjl4S5ud9EnoiLputZDnGis3FY3GwSVpc8mYqfaSDA6UMKhVMB1HSZ/d+2AfMVytx60Ne1S29qqAcdwm+LiP7UhZbWHCoKUOiCP6p7Bp1t3sUJDhcdyGKgoFCUA/D8L5Yx9zsQR4tHnC41Cw6Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=BlMsN2RU9LxbRIxnTeyZFF/hccJNs83z8eUAbO8saDQ=;
 b=DLm4UdoYY1ho2SwIB2x+rYcIG+x0r6YRLZwvCg0oaLAXGnzWraWeVcXv+Kid7+DDrDJ/bFAdTVhzh1jwrcQu8IOpBS4+aG8G2NzfEz7QIr+KkpfoZFci1hgUHsfzb9QnBQG/yVxEybgSIEFRJGdDf2X32aO6NNtQB4zh4oVZYYBsixfnERk2AMouzaAr7DeeR0mfkY+pOOQKKu8XIZgYrzuf+EKO0Ghc1paIXpS0T+xBx3r80yu3VzxtO1md+LQJzC4uliC11V0PNDwIFFZIMhBWPA2QpghwwIqyw5JAT9BxNIfznCdVP+NEc4CwEPO/twU3biYSclJfZbWM2v887Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=BlMsN2RU9LxbRIxnTeyZFF/hccJNs83z8eUAbO8saDQ=;
 b=wVuDoMVrzZV+eghAl5qOdnQxoG6YmhG9/xj5XTClnoSwaap4VEGQQJDM3n46T42+E8HTK89MhjrfmpI8n7VHqNeSpqF96bHBKlJXNjFC7zVsHXKtPIxC2/wuIDRMGBanMwnyynKx/AQk/5T8iC708tVFio0PLtdSUkcnC7s0IKA=
From: George Dunlap <George.Dunlap@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Andrew
 Cooper" <Andrew.Cooper3@citrix.com>, Wei Liu <wl@xen.org>, Roger Pau Monne
	<roger.pau@citrix.com>
Subject: Re: [PATCH 15/16] x86/P2M: p2m.c is HVM-only
Thread-Topic: [PATCH 15/16] x86/P2M: p2m.c is HVM-only
Thread-Index: AQHXcbjzd5/toOQYoUyjtEewKjWYIKyUjsqA
Date: Mon, 14 Feb 2022 15:39:58 +0000
Message-ID: <05E1C46A-5652-429A-AF95-7F6AB65A280E@citrix.com>
References: <d1fd572d-5bfe-21d8-3b50-d9b0646ce2f0@suse.com>
 <7f868820-20ac-4850-aec7-35bc843cab6e@suse.com>
In-Reply-To: <7f868820-20ac-4850-aec7-35bc843cab6e@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3693.60.0.1.1)
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: cbe87981-9da5-46d4-5a54-08d9efd041f4
x-ms-traffictypediagnostic: SJ0PR03MB5792:EE_
x-microsoft-antispam-prvs: <SJ0PR03MB57922B9970EE2854AC549FBF99339@SJ0PR03MB5792.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:2043;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 6kugJNhrHWIMbg2pKg5JI7kURut4944W0RQOQlCwzXuYaKIz3Ro+xSs9wqJbv3m0/N4NFOQCKwhMDOCPGlOD2pZzxonOflMZldQe5+2X2MygEEXNGnkq7fmFf7gj8yR7pckaGCG9QxUkeZNH8h2nFn0+Nso/3uuPvV+kUX6ZT3dlRghSIhdmC1ev+Kure3vtuJ3+Uc0Q64ArKQKEyabFGxw/I8TYY8tAe9oIL0MjoEl7Yy8GAMDH5kcNgAmLkT3rC43Mvj1Gg6ZizT7n/3xrWcMQVFD27n4J5evreWbIPQleLg8zV/Eyb/PDMX7mIeKCelAXBDlw3jOgD9LI1sv3n0qBg9hkwERUgXRqVVsMGVrB1F4sBEG5fZm/sB0FV7pRFpvuu+63Xq5vMyKz/jwPoghjO96oeJ8VnqrwyKW6cXZX3D01zYF0GzPq8TM+irtNUwmamsvBipB7ivtgOwxtNhvqcjk8g1gQE+cIFpmI3Uj/ntJ94fkzklgY/SgXTXwkPOYAydjAus8zwt6RzPkFX9gA6F0kkcYTBJm4iqsl6CT9yR5qU3D46X0jBKkbYNBogk/k9U7499jl09I06vUsHf/0rLhLktE0nzY/8+4vPEVzMKXNhU3DpquzDi0q2D1SV/SSt+vsAMHyiU7/Xv/dXRuHF/ZLsMBEZWjWzwESneSpSLFBglw0TaEFH9l7zwXsFkqwjW1mC5EdK5YR5sjsbvS2AclDRRuIwoMWpYHUGw6FWW15rpteAC2wrABaGyFh
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(508600001)(53546011)(38100700002)(4326008)(91956017)(76116006)(64756008)(66446008)(66476007)(66556008)(66946007)(8676002)(26005)(186003)(6486002)(6506007)(6512007)(54906003)(71200400001)(316002)(36756003)(6916009)(2616005)(83380400001)(2906002)(38070700005)(4744005)(33656002)(86362001)(8936002)(107886003)(82960400001)(99936003)(5660300002)(122000001)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?nfiwsE54V8WaXKHG73JDDlI6G55U6937jJe1THga0x172lA7RFpY2ZXdagpC?=
 =?us-ascii?Q?nGefsn6P5XzYP96kazOZGdz8BAHH19HCVLr6A4KKEQQYkFtZKlFZ/zhzlti/?=
 =?us-ascii?Q?rnhlUkeTByLqvVtVMtmhDh56jVGnPcbtS6WeqOaFBnngDkGoKF+KgifMZo5S?=
 =?us-ascii?Q?IOpuwBRZSKN1Zs+x4Hq+DHruDcMGXaG5jet3PzeFz0lCUBOmSiLlrissGJgd?=
 =?us-ascii?Q?l1WwfXYg34O+UuEUym7V4Ut61jFe9LhUEhwb1M41XJUSz9d2DdDZzCdNKmrs?=
 =?us-ascii?Q?YrVdqDjsNqgLxi94mvqAKdzkjfi5sTWU40OXaaTULm0TXmGrBDSLMniGmnOa?=
 =?us-ascii?Q?tseMcjIqj6Eau39POpe7wpN0QBfVu9EWXbvIr/Rkc7NxwM04jLMNjVvXtabG?=
 =?us-ascii?Q?okXe4Gb6WdDG1LpsltqkJru5GyKjLRWNWcbaMECqhfiiGK8o+do+oMuIFHye?=
 =?us-ascii?Q?bYhACG2KY8Ru8WcB0BpUg0fuNnULBigY50mnKVZmc+uJyZe8jk8cHWH6Je68?=
 =?us-ascii?Q?TDUG71OAkPu8EDI6/7s7W04SnLDJ/juVz7r4SwcNepzHIrdAVz32pmcTOSBI?=
 =?us-ascii?Q?HXYv24ZaDFMa4x2+x1k7Xpoc0iAVTjWoR1ImIJwNXQaUg8aP7kS/c4aqZZj8?=
 =?us-ascii?Q?OySE4qGzZjV7dqK0tsKuYx31Oqm8uzHLRjETLlf9oT4aElBK1lpvt1kqXEbS?=
 =?us-ascii?Q?/tO+LKYorjrDVzGDFPVOm78Z5cRRK0RzOcZbjzyRQpDSMaUf8f7FZ+s9/k8Q?=
 =?us-ascii?Q?zA16gXgs7D6IbE7g6OCzsS091Krrul/5EAx/nxXC7QkVcYaGZdCqAqYgCkJc?=
 =?us-ascii?Q?HeZkLD6uAsduvX2tQfdg2BUWXHE0PiIEVuVyph9E9dpvlagpl3jN5D93ccLB?=
 =?us-ascii?Q?AuNzMh/stSinzc2JXc/z2bdQ8pmbNmBdIQj6xmekL+09SXAfMNlN7HNUhtGl?=
 =?us-ascii?Q?hEjvyUs6RLqqFO1CXYeDFLvxNqa88t6zV9q0B0fwk93TdrItA8yVp283NMIG?=
 =?us-ascii?Q?5jMSUsGZyxpOGXxsePKqzGMaXrDX/GbkAcH14/A5af7GSE622FU84OeOdpiv?=
 =?us-ascii?Q?09AEdJZ7Th3BLh/SD98MqaJLso6BmLuQvpI8btQifJJPk8GSdO2eVf9nHeRg?=
 =?us-ascii?Q?kE8Up1wLCCQGHDj3TvXQcPXx76FDwQho8aCuqx0l3CxDybiGq95ahBdYHdVp?=
 =?us-ascii?Q?ZyYkntm5695EpoBt4l1kAwQVpoPK1MVtBv7wsAICqyKpvPl890UBbjvGRFc+?=
 =?us-ascii?Q?n8RAXDJlNmjBQrel2W3XLSZo/mg6jVKk56a6SzXqr5lbbbtNtmKyX0PZ2j3B?=
 =?us-ascii?Q?n0MI/M1/mK6QtIi0NvAVXbghh3ksX/jak4ELA+AmIUL2fKbR55uKifKYCTKw?=
 =?us-ascii?Q?l1WneD8BzFlkOyyDaBKS7WWvUAh90AK/CssDiF0anHMUiw2ZAc/dDWMRvWb9?=
 =?us-ascii?Q?wbD6txsVh30LfFfMhxD+AHzOda2kKW4nP80JumqD89VF05agbRgtgP1h10uG?=
 =?us-ascii?Q?VnsZ7/n4UqYRabE8uiDBuMPxQABstMvLVGiAp+asMsh5456LISMDNteYlwP5?=
 =?us-ascii?Q?r01ayjEJdZR79YJMmB9j/D1Tq99nPjzwG/oNDeddmIjWBF47R31/PbviTi4Q?=
 =?us-ascii?Q?8qyxWQQ8aeDKztKdMijyYRRdjft7vFtDgRzAUB/EZ1KCO8W+2DsCDqmabpEs?=
 =?us-ascii?Q?9im8wV5GHPGk+ocjcBjVsu8flAI=3D?=
Content-Type: multipart/signed;
	boundary="Apple-Mail=_73756F51-2A3A-4F02-9DD6-BB7A27600AA9";
	protocol="application/pgp-signature";
	micalg=pgp-sha512
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cbe87981-9da5-46d4-5a54-08d9efd041f4
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Feb 2022 15:39:58.7311
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: LesPYfbr/6GsSlbBdmuCxQ7q4DNQ4MfNRvnFQonXst2md1NnSawUwJgw7+W5U4zPzEmqN32myK5VHzhoON8HQY1OxuN1tS7Gl6gn3Rgct+0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5792
X-OriginatorOrg: citrix.com

--Apple-Mail=_73756F51-2A3A-4F02-9DD6-BB7A27600AA9
Content-Transfer-Encoding: 7bit
Content-Type: text/plain;
	charset=us-ascii



> On Jul 5, 2021, at 5:14 PM, Jan Beulich <JBeulich@suse.com> wrote:
> 
> This only requires moving p2m_percpu_rwlock elsewhere (ultimately I
> think all P2M locking should go away as well when !HVM, but this looks
> to require further code juggling). The two other unguarded functions are
> already unneeded (by virtue of DCE) when !HVM.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: George Dunlap <george.dunlap@citrix.com>


--Apple-Mail=_73756F51-2A3A-4F02-9DD6-BB7A27600AA9
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="signature.asc"
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEj3+7SZ4EDefWZFyCshXHp8eEG+0FAmIKd80ACgkQshXHp8eE
G+3A3wgAmKx3Tf98tj65jzxuW6T4sR6c2B/otgJy/t6z5jC3bpAbF8UUZg+cFr7z
9hTvoqGfTPgWUEuy3aq6aqgm7UGte09IAgAXQVUW+9ysJwI1oszfDq4dJoEGKeUm
GC61cazqOiezcYEAhJm4Gm6q2Zct8mA4UultpLHwqSDC5r8EwFXxBOo91iK5I0on
fV1yZX7xb4Y3WyNcIpCGlxyl/7xtATudbvoD4kYApLjHLknvz8j/rrK75mHNBKQ/
0ieEiu6SVnUEquPLdQb6y5wCAs1TY4TKsk09Z+MxWipTh2Qt5FNyKF/oqD7UptnI
99bdDkN+sr0QrQwLJ4bGhzBDMfwEbg==
=sbkD
-----END PGP SIGNATURE-----

--Apple-Mail=_73756F51-2A3A-4F02-9DD6-BB7A27600AA9--


From xen-devel-bounces@lists.xenproject.org Mon Feb 14 15:51:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 15:51:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272478.467335 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJddE-0004Zn-8c; Mon, 14 Feb 2022 15:51:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272478.467335; Mon, 14 Feb 2022 15:51:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJddE-0004Zg-5V; Mon, 14 Feb 2022 15:51:16 +0000
Received: by outflank-mailman (input) for mailman id 272478;
 Mon, 14 Feb 2022 15:51:15 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qPn=S5=citrix.com=George.Dunlap@srs-se1.protection.inumbo.net>)
 id 1nJddD-0004Za-2T
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 15:51:15 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ee93e8e9-8dad-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 16:51:13 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ee93e8e9-8dad-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644853873;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:mime-version;
  bh=SutkJp7Qv/FDXpdgLjdOfRBoEWD3vzIg0+w7gNS0eCc=;
  b=CmXgbsBqjHjujRy9VOLudxhiNK6tlM/8/lXsARPvxXlTJBBUAhVnVtmB
   V/Spks1F62ChtswPm3TCRlOr6IXmcOUlUVw1E/sDtBEu+DuiWis1LOcRD
   9xg9R3p8T+T3RyyN/2CZmIDJq0+f7PeI9wt8J3GQS/W56qHNh1YHa/2pX
   k=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=hardfail (body hash did not verify [final]) header.i=@citrix.onmicrosoft.com
IronPort-SDR: fNdyoszFqYwiESmChKSeIYHQwwAw0WY75x0Nm0wgsEFsqVmiIqmm9HEBMVakEM7fb7lE5gmhr5
 N35uXbiopTAK7pEMHEl0vLAxUKlmIpId/C0qixxfsP0QAWRHUhlIm4qFrQ97kimITX8luxSK6Z
 8urIHWjxl/AAViv62ynzwWxbKc1h/rQ0Ejn7E0kY85QrzjkOxVob6q8JzvSOufkR6meUZxP3Xa
 Tm4lWJztQe1t380vu8spov2KGRz9Rv3SE2kHp5p9JKXo5hrlovytW9XnLaOWZNB08P/UhnRzpJ
 dnIqqGul9cVBcae/IUgd4t4t
X-SBRS: 5.1
X-MesageID: 64166197
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:TsiRqa+R8wYioEUIcmlaDrUDyHiTJUtcMsCJ2f8bNWPdYAuX7wSz/
 BJcAD7Ya7vPIDfrKpolWDmFhUkE6sfTx95iGQJu/CAxHy8V8MGfD42VIkyrZHjOJJefQk5ts
 ZoVYNDOIJxoQiOB9xz1POm6piQljfDXGLStV7Ks1kydPeNBYH5JZUVLx75p6mIRveWEPu+th
 T/Ti8PTYQCsh2EoaGlE56zZ9Rk/tq2jsmxG4wcyPapH5w+PxiUZVJ4RG/q8fiDyKmV28k9WZ
 AphIJWRpD6xE8IFU4v9+lrDn8ljrof6ZWBisFIPM0SZqkUE9nxaPpoTbqJGMx8N0mnRxbid9
 f0W3XCOYVZxVkHzsLx1vylwS0mS6oUfpdcriVDm2SCi5xWun0nEmp2CP2lvVWEswc5lAHkmy
 BAtAGtlgiZvJQ6B6OnTpuFE3qzPJSRwVW8VkikIITrxVZ7KTX1fKkljCBAxMDoY36hz8fjii
 8UxUDxkURrQT0B2FnATDc8yoKSNln3jWmgNwL6VjfJfD2n7yQVw1P7mMcbPe8zMTsJQ9qqaj
 juYpSKjWEhcbYHBj2remp6vrrancSfTd48VDrK1sNJ3hlma3kQYCQEMVEv9qv684qK7c4wDc
 hJKo3txxUQ03ECFRYf4dhvmnFCv7zlHVNwOE/Ir8DjYn8I45C7GXzNZH1atcucOq8seVTEsk
 FiTkLvBHTVytJWFRHTb8a2bxRuQEyUIKW4JZQcfUBAIpdLkpekbnh/JC9puDqOxptn0Ai3rh
 SCHqjAkgLcehtJN0L+0lW0rmBr1+MKPFFRsoFyKACT1tWuVebJJeaSR71Pm4+Zscb+1aV2E4
 XQ42O2O6PwnWMTleDO2fM0BG7Sg5vCgOTLagEJyE5RJywlB60JPbqgLvmggeR4B3tIsPGawP
 RSN4V85CIp7YSPyBZKbdb5dHCjDIULIMd3+Hs7ZYdNVCnSaXF/WpXo+DaJ8Mo2EraTNrU3dE
 crBGSpPJSxDYUiC8NZRb71DuYLHPghkmQvuqWnTlnxLK4a2an+PUqsiO1CTdO0/567siFyLr
 4oAZ5vXlk0GC7eWjszrHWk7dw5iEJTGLcqu95w/mhCrfmKK513N+9eOmOh8KuSJboxel/vS/
 2HVZ6Or4AGXuJEzEi3TMioLQOq2Bf5X9CtnVQRxbQfA8yVyOu6HsfZAH6bbiJF6rYSPO9YvF
 KJbEyhBa9wSIgn6F8M1M8Wj8tw4KUjDaMDnF3PNXQXTtqVIGmTh0tTlYhHu5G8JCC+2vtE5u
 LquykXQRp9reuioJJy+hCuHwwzjsH4Dtvh1WkeUcNBfdF+1qNphKjDrj+9xKMYJcE2Ryjyf3
 geQIBEZueiS/NNlrIiX3fiJ/9WzDu9zPktGBG2Hv7y4AjbXozi4yohaXefWIT2EDDHo+L+vb
 Pl+xu3nNKFVh05DtodxSu45za8369b1iaVdywBoQCfCY1ixU+syKXiax8hf8KZKw+YB6wexX
 0uO/PhcOKmIZ5y5QAJAelJ9Y73ah/8OmzTU4fAkG2nA5Xd6rOidTEFfHxiQkygBfrF7B5won
 LU6s8kM5g3h1hdzaoSajjpZ/ninJ2AbV/l1rYkTBYLmh1Z5ylxGZpCAWCb67IvWNodJO0guZ
 DSVmLDDl/JXwU+bKyg/En3E3Ox8g5USuU8VkA9edgrRwteV1OUq2BBx8CgsSlUHxxpK5Ot/J
 2x3OhAnPq6J5Tpp2JBOUm3E99ut3/FFFpgdE2c0qVA=
IronPort-HdrOrdr: A9a23:+pwM8aNgf+d7+8BcT3b155DYdb4zR+YMi2TDiHofdfUFSKClfp
 6V8cjzjSWE9Qr4WBkb6LW90dq7MA/hHP9OkMYs1NKZMjUO11HYVb2KgbGSoAEIXheOjNK1tp
 0QPZSWaueAdWSS5PySiGLTcrYdKZu8gduVbI/lvi9QpGpRGsVdBnJCe2Cm+zpNNW577PQCZf
 ihz/sCgwDlVWUcb8y9CHVAdfPEvcf3mJXvZgNDLwI76SGV5AnYqYLSIly95FMzQjlPybAt/S
 zuiAri/JiutPm911v1y3LT1ZJLg9Hso+EzRPBky/JlaQkEuDzYIbiJaIfy+AzdZ9vfr2rCpe
 O84SvI+f4DrU85MFvF+CcFkDOQrwrGo0WSt2Nwx0GT+vARDQhKe/ZplMZXdADU5FEnu8w52K
 VX33iBv54SFh/Ymj/hjuK4HS2DBiKP0AsfeMMo/jRiuLElGfRsRE0kjTdoOYZFGDi/5JEsEe
 FoAs2Z7PFKcUmCZ3ScumV02tSjUnk6Ax/DGyE5y4Co+ikTmGo8w1oTxcQZkHtF/JUhS4Nc7+
 CBNqhzjrlBQsIfcKo4DuYcRsm8DHDLXHv3QS+vCEWiELtCN2PGqpbx7rlw7Oa2eIYQxJ93g5
 jFWEMwjx96R6svM7z54HRmyGG+fIyNZ0Wb9igF3ekLhlTVfsufDRG+
X-IronPort-AV: E=Sophos;i="5.88,368,1635220800"; 
   d="asc'?scan'208";a="64166197"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=hT77ElbcZt4pb34RSUmYpEogL6/NGtnyhR30LMDmR5pK/2VN48UuKAVkcrvTwny0S61qr5CEIAtDp46lBDuu0TnjxHEYC78LJN5URz5IG+OABs5A8QQJUKiDgflyDXvB+dVXj4RCmxZhhLio0si4NXjo1bZHN69EAXv0XuMGM0c0An9j60Yt7V3YvoJLk+nMjm4MDsob2UibfnOUiPwsdCRyQsWyoV5Z+RaTiZnzBCcA/PhmeUJBXjMPYtXz00pHQLRFv0bRHNzpQXScrzvSyGXJ1CrhBvYqOkqziAGXOAzPWLFp6ffz4ZXc2PJ3c3RQXP9+ubwNwC1i15a5hRUnWg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=elGlQAlg7fDvn4dAf9FrCnXLqY4nvIZCa8gxQpkBw7o=;
 b=VBjhgJ5suRnqDbkfhGTl3XaskzUGJofSOZ7WtNC1cMoYwJVRS8PLyt1bPINPMR9g8ltUjSV1iC3GHJaGcCEKxzwg3vBbiBVuLT5tZzEVRIyh6/mdZasqgfMkh3rPNC8C55/b9NGM9vQUMjfIgezL/eyaqeqveIl7ejfksLXib1itWH9mY/mvhQRGNpAGykE2DPqauq6XXelApnZmhLJqWp7xFtMBfj2bSQ5MOGL1AsM1EfbbOIDO+eqfj+0GbleH1OK/RsCVBjc7isoyPuvKjt2nmONPAw9LKAmIa0klEJlyB+W5uVzG/Tjl+nEa6t/xutIXguPEABhmqEUrHQTmtw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=elGlQAlg7fDvn4dAf9FrCnXLqY4nvIZCa8gxQpkBw7o=;
 b=vxz4zSgkA5kdLfYYDQd4gyO2KOwPwElvr3hHsAC0nk3sAGgkOfXNpLf308fLpFJLKxwLEiwqEVKDJ5pEbosQojwYbksk6Lpd9e+UMSVRVWqCpZ2RcSz8IQfaOTESNGQo08rj9h33hxsH74UTI/0oE3z1ozLm3ya8bWvsyphiNCU=
From: George Dunlap <George.Dunlap@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Andrew
 Cooper" <Andrew.Cooper3@citrix.com>, Wei Liu <wl@xen.org>, Roger Pau Monne
	<roger.pau@citrix.com>, Paul Durrant <paul@xen.org>
Subject: Re: [PATCH 16/16] x86/P2M: the majority for struct p2m_domain's
 fields are HVM-only
Thread-Topic: [PATCH 16/16] x86/P2M: the majority for struct p2m_domain's
 fields are HVM-only
Thread-Index: AQHXcbkF3MFLz+cgi0ab+9TF9ViU86yUkeSA
Date: Mon, 14 Feb 2022 15:51:03 +0000
Message-ID: <EFFE5241-CB1D-4173-87F9-16AC428902F7@citrix.com>
References: <d1fd572d-5bfe-21d8-3b50-d9b0646ce2f0@suse.com>
 <e5362b33-0f5b-ba2b-d033-ca0a09e5fd54@suse.com>
In-Reply-To: <e5362b33-0f5b-ba2b-d033-ca0a09e5fd54@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3693.60.0.1.1)
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: b9e6d844-2197-4666-c0ac-08d9efd1ce79
x-ms-traffictypediagnostic: SJ0PR03MB6674:EE_
x-microsoft-antispam-prvs: <SJ0PR03MB6674D81A1EBA4129460ECCCD99339@SJ0PR03MB6674.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: CQhLzy+VYu9CTSyysB9kBPZ2aFn48lF13KwSkJBCaVjJhVuu/Ttvve1FafebvDWJW/1vkPzPFdNIiaiKWBGNcYB0yZS6zomrXyOQRi/WBtjCVx6CtUmvnmainm6uax5U4Sb3YYeq4oY3UXygeuOv7g941tZJHvmpK4gTbO7348mqw8Yl4/k4pHETDhV0pynM9itPXAenUPb4coQU/mx61kzC/2H3DkGbXfrffIweOUwRGUNbYkqN4V8l2RftpQo5VW4MRZUazEb4iaaT9940KxOCw6MVteVvWKjHxQyzdkGZG7O8Jf0x3kehYRLxW5wiEyCLNF3N+vC34ii1eJ+UenJP9B/C1VaBGzE4Iq2E9Wbe9N0C+VunoaYofD42qo0L17dY0fKK10E9aLcDJFS/h6RBzgJP7VoLLvidn4XqsNS4k3uoNcFRFeanZwzaGF3kDxqCSRNUtGWVxbmRS5YkxDQmc9wBZslpIP4pyFpyJ1ZLQz7zsBGE/jb6SUnylHwjSUOVVqGUKC1m+erzutTD3HGByiSmyFV9/T10DPSfKdkwH7sW6U1X8ViVvtfsMl65bXKcb71yVKH0MmSXWSbLPc86TXr/mVI8ZX4L+GS1aqVcoldhvDUWUs3HcZv96QVjQQHZcsDpn/roeH50Wove2IRNkjJ1mwh6zcotfnqIuKNDHhfo+m9GfTyMMY6f4sMve/GUX+ei+LcoDE3rCITsxBit5mCuGg23W+tGWuuTtn2oOM9yOzGNa7nsKjnNPyaB
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38100700002)(122000001)(99936003)(86362001)(38070700005)(66476007)(66946007)(8676002)(4326008)(66446008)(64756008)(76116006)(66556008)(82960400001)(54906003)(91956017)(6916009)(316002)(8936002)(5660300002)(2906002)(2616005)(186003)(26005)(83380400001)(508600001)(6486002)(53546011)(6512007)(6506007)(33656002)(71200400001)(36756003)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?aGYyN0ZmWUIxODg3dG0ydlBiZzdhZU04bWozNjJqMlN5YmlMdEQ4VVhwN1Jz?=
 =?utf-8?B?SFMyT3E5UWdwVllkZzB0RGkyZkxUWkFtaEhDR1VRRzdaL1phck03VHpyYUVj?=
 =?utf-8?B?bGlGMU8yYlJ4UTRmcXFlWnF4V2N6VzlzWnFybXZUNGIvdkF0VGJxSk9NZHI4?=
 =?utf-8?B?b3pZRHA3c28wTGhNMXFaYndmRk1ZRElEUlViSVNYU1Z6dkRlZUJQZ0lZZ3BM?=
 =?utf-8?B?Y3dsZ1F1UGdZVldMT01PZW0vRFBGQnY4bzFVcEIrUXVSbzA4emI0SmxaRGEy?=
 =?utf-8?B?TnlGay9JRS9ockQ1YzQxRDRPNUd4MEduWWphak9oVE1vUHZRYmlRN3NTcFBr?=
 =?utf-8?B?Sm5WYnZzMEt2Q0toMTkzQ1I2Tk1XbmhFQ2c5RS9DVTM0VmIrekRtWlRCT3Fa?=
 =?utf-8?B?SmNyY2FIMlNQUHZkbXl6NnMxWlJiKy96czJsNXdOa0dndlZnZjg1YTk4bjQ2?=
 =?utf-8?B?M0ZMTTcvcVEvOFBPUHlKNUhOODQ2NDZsVGVSc21UZDcxYTNGSmV1ZC9LSERQ?=
 =?utf-8?B?NEhzYU85eVNVcjA4VjlEejlTRCtnUFZyT1NzeDlULytzUlVjamZkR1FZM0lj?=
 =?utf-8?B?VnhoNUZpSGpJWFpFQmltOGRibGlpVkFsSDhseE5nYkZxUlloSnl2NHNjcHZy?=
 =?utf-8?B?alBrR2dsTnNQQ1dRODhpYVYwejB0NlJBeEZDVzM4ZCtLQi9ZeHhMMDFzK3ZB?=
 =?utf-8?B?MTh2NzdPcWRCdnN5ditZU2tPSGFYeGxjMmVFNHBwak8vTUJRL1F5c01pSHND?=
 =?utf-8?B?bGt5Vmp1VnF0VUhwSlY3REtjakF0UDV3WjBtR0dZY0t2ZEt1TGFuM1NhY0Nn?=
 =?utf-8?B?cUtkLy9hNmcweGgzUndnZFMzYVN3MUkzOXRYZWlQRDUxV21DUmxxdE9HRk1v?=
 =?utf-8?B?RU9TYmltbDFtQ1l3UjRoTEJJaTVIUmUrdVcwSzB6MXhlT2VaREpON1Z2Ullx?=
 =?utf-8?B?YXQzVnI4aGRkMUo0OEQzTHE2YnBsclRqelUrdCszck5hdWY1QndPQVU1VGN1?=
 =?utf-8?B?R2d5cmErME8yN0VEOWpXbWs4SS9SdEpSZDBYOU9KRDlhdG5QYVc5cmlmVU1K?=
 =?utf-8?B?ZU5ib3pGYVpQT1dMQlByZjhyL3pzZmkzbUZXRmoxWHhRZThBTDdObTVZSFRX?=
 =?utf-8?B?Yk5zY2V5c1BTTGdVZU9TR2JWYndyMDBvMEpDalYwT0NTSDFHbHFtS1V2SHdj?=
 =?utf-8?B?OE53eU14eCsrVDUwUkJ3Nm10QzB1T051TEhVOGlnZEViMitPRFhuZFBWUGVU?=
 =?utf-8?B?d2QrMmdoK2YzY0owRTFRUG5mN1k2aTdIUWN5Sm9hRjV6aytOZ1g3TzdzeDZa?=
 =?utf-8?B?VThneFpmOVZCT3lzN3JWdEJWaUtsdnpmaVF6d3V6dXJZcTJBUnlHUUdFTVlP?=
 =?utf-8?B?TTUwY2RIczg2WThWNmo2YWFoZmZmOUVFcjJib2FOTUtabDRMNitFRU0zQXVY?=
 =?utf-8?B?SkQrLzRENDhORzIrRHk5M3VEbElEdGpWNFYvSnNGbGtrcW1NNFhibnd2dFAv?=
 =?utf-8?B?NmRZS0p5clJwd21icGdVMlBuZXdpVEcxdWd2QUd6TXhJYUZvSUd1L2FxUWlC?=
 =?utf-8?B?VXFlYUNETjVrbUpxWjdURWNsMnFTcjlnREZoaGt6dUpXVUZHMUt1c2NMTWl2?=
 =?utf-8?B?Q2VnMmJoTjhjb0hRcHRNTkVQL21OV1g0bnFEU1FkZ1I0MXpGQ1RRTys5QSty?=
 =?utf-8?B?SnU4bFVJVk1VVk9wWGxWM0l3d25TMmFBZUtmdW1LUHJ2NDhxMmgxWlh3OEFt?=
 =?utf-8?B?ZUxFQVZDUWFlaEdadGhnc2tpbG9KRVRWWDVnWkI1Q1ZzNk95R0dkN0pRK3lv?=
 =?utf-8?B?bVJXMEJHUDMvZ2N0Y010Rk1xOTJWeXhQOW5DM3pJUEo0WEVZenNkcjFsVzFL?=
 =?utf-8?B?T1BZdlM0eWNQUmh6SmNlT1hFd2hoM3FGN1hOZWZ6NFRsOVVJNXcwUEFJS2pV?=
 =?utf-8?B?cUVrQzVITVB2bjJOQTRTTit4cHdyQ0ZDaG4xQ0JadUsrYkdIbThRcW12MGF2?=
 =?utf-8?B?UGRTWU1TOGRNNk04U3lOb3VsczFlOUFPY3Y1ak84WGZQQm95Q0M1Y2ticmVo?=
 =?utf-8?B?SkdRVjN4a24wZkZCamdpckx2bVBSSEk0QllFZFBRT1ZKMzB2SzRsRms5TlRB?=
 =?utf-8?B?OGZnUkhRY3JXbDhmZ0dLSVpRUHdzbWhuL3FoRjZYNjF1dDlZdjJNTjg1blN2?=
 =?utf-8?B?WWptYVg5WWU2TFhMelhFOEViOWFsRXdtK2p0c1oxd29PRWJLTkwwTzdheWw2?=
 =?utf-8?Q?jB0pR6JyovR6QwVhulrDNCNMWZ2Yof/gvWER7CaWgM=3D?=
Content-Type: multipart/signed;
	boundary="Apple-Mail=_DA9CCC71-8509-495F-B26E-01E6C73B45DD";
	protocol="application/pgp-signature";
	micalg=pgp-sha512
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b9e6d844-2197-4666-c0ac-08d9efd1ce79
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Feb 2022 15:51:03.9831
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: RzvRjmEV+/SSzvTWT/X7SKrs9NaFZ+B3kEavXJSDjPxG7j+b4LjZfhroDXhPsTua289Mzw3fCZH79kzxI2kBANeUqNBHldOslvwl6Uoreu8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6674
X-OriginatorOrg: citrix.com

--Apple-Mail=_DA9CCC71-8509-495F-B26E-01E6C73B45DD
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8



> On Jul 5, 2021, at 5:15 PM, Jan Beulich <JBeulich@suse.com> wrote:
>=20
> ..., as are the majority of the locks involved. Conditionalize things
> accordingly.
>=20
> Also adjust the ioreq field's indentation at this occasion.
>=20
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: George Dunlap <george.dunlap@citrix.com>

With one question=E2=80=A6

> @@ -905,10 +917,10 @@ int p2m_altp2m_propagate_change(struct d
> /* Set a specific p2m view visibility */
> int p2m_set_altp2m_view_visibility(struct domain *d, unsigned int idx,
>                                    uint8_t visible);
> -#else
> +#else /* CONFIG_HVM */
> struct p2m_domain *p2m_get_altp2m(struct vcpu *v);
> static inline void p2m_altp2m_check(struct vcpu *v, uint16_t idx) {}
> -#endif
> +#endif /* CONFIG_HVM */

This is relatively minor, but what=E2=80=99s the normal for how to label =
#else macros here?  Wouldn=E2=80=99t you normally see =E2=80=9C#endif /* =
CONFIG_HVM */=E2=80=9C and think that the immediately preceding lines =
are compiled only if CONFIG_HVM is defined?  I.e., would this be more =
accurate to write =E2=80=9C!CONFIG_HVM=E2=80=9D here?

I realize in this case it=E2=80=99s not a big deal since the #else is =
just three lines above it, but since you took the time to add the =
comment in there, it seems like it=E2=80=99s worth the time to have a =
quick think about whether that=E2=80=99s the right thing to do.

 -George

--Apple-Mail=_DA9CCC71-8509-495F-B26E-01E6C73B45DD
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="signature.asc"
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEj3+7SZ4EDefWZFyCshXHp8eEG+0FAmIKemcACgkQshXHp8eE
G+0urwf9GViBDvq31ulAtAiWYI1CE7s9lNziWwfGSj84E1OaPvifdE4eNphozrqL
H2EQ/QaWfsZr00YhuJfN8RAw0CIBkFpIN7d/iusJXltugBS3A38khRSp9FRGiSFN
3uKf9nLjVK4p+JLwqnT9KxOC38lyOfvLXCgOT0RQ5mjAS+Oc35fUgG2y0EuiSzd4
Dx4MadPN/6ynmHLHU3Bw1oQntPTuaYl82/IKNZSYpOwObpbraDHUfkMzgAEGSSZI
aWnn6Aw7i1hXRDhjmkVIQlptA+4smM1/hKO67G8E1DO8wWna4YTdLpXYRN5S2pO5
3kEzbrI8qc/SPNKOgSJrUPgXr9MOiw==
=SXMk
-----END PGP SIGNATURE-----

--Apple-Mail=_DA9CCC71-8509-495F-B26E-01E6C73B45DD--


From xen-devel-bounces@lists.xenproject.org Mon Feb 14 16:03:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 16:03:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272485.467347 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJdoa-0006Z5-Co; Mon, 14 Feb 2022 16:03:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272485.467347; Mon, 14 Feb 2022 16:03:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJdoa-0006Yy-8b; Mon, 14 Feb 2022 16:03:00 +0000
Received: by outflank-mailman (input) for mailman id 272485;
 Mon, 14 Feb 2022 16:02:59 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KkXt=S5=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nJdoY-0006Ys-VX
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 16:02:58 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9378c640-8daf-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 17:02:57 +0100 (CET)
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2055.outbound.protection.outlook.com [104.47.1.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-2-YkrCbjy8N0-60A-n1oItvw-1; Mon, 14 Feb 2022 17:02:56 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by HE1PR0402MB2939.eurprd04.prod.outlook.com (2603:10a6:3:db::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.18; Mon, 14 Feb
 2022 16:02:54 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4975.015; Mon, 14 Feb 2022
 16:02:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9378c640-8daf-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644854577;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=aLXRdMyAMi502YtU1OXQwzwtcJOxQaIsusG0Q+2HtLU=;
	b=khEP2mB/sslJuE0YTvHLwf9pqtCqFF3IGfvdTfZjxr2NG81+9CE7qKbcRw3uC6jzFuO3I3
	FB0b7ieS5hOSm/uC6iNJY3dmdlLRAyqS7ofcfA7jLWVEdeGCkiYSxZRHV+Fey0gQWtjTIP
	I3IBxgdm90iMy2hEdPY3P22T78IyMWo=
X-MC-Unique: YkrCbjy8N0-60A-n1oItvw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=oYOfCTh/3E/wA85/rzn8eeVRLRedbEHe03SLBugrv0pgNuTVQXJ3Qr/zVfB/YiqYCfI4ay2Gc5wqgFe+LDQ+NO5ZHfMZJOcIGJSlXX/W9TqGXnUUxxG1Xvrc7LjgUA3O35ZEh3lncal07q7G9CzuqCIcQ8Ks3bvvGBKDNq8ojqvagm/N3ZnTqdnKE86oPvYaK//CRb1hFxRZtilsTysdfDZz4KYInBPli/Nepv/JPmgzd5B9rEIeNNAL2YYfVQKsUg8xx0CDTc2pLVZsOhuCaPZtjEscaJba1IEsrRM1BynF1NEpkaBotg6FjsFEnBpr+r1iqr4Nyqo2/NXjVExKSA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=aLXRdMyAMi502YtU1OXQwzwtcJOxQaIsusG0Q+2HtLU=;
 b=oWWsDbfmHa7tVEOB2m4EQPXhElctMKew2H5nZmvzikWyMg5Q9zgLJI7IHcPNHllCTZLu7OVLf4suymuYjST8MIs44UFYVqjFRurCvOCWuNfAiEWEOTsq1LKk+F8jc3tbTchn0AnRrBP/zxuzvVRFFLcFCz7ZalffKszqkMUS2v/Ezp1yGMO8NYo06A5NVshc+rD2hDzZ9tbNXzP/u11+AtlH0O2u5ausBe2XoVSajpJXfG8zUcz95RHeDJ3di0+xiF944HYejuGQ6X08eNI14o8axv/VXX2pwVBpSH9nZjxuqvvNTHRYJYW3AQOiLo41acEZCB/DtcKSRmALoJlzaQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <ea9c7232-a98b-7fb4-a151-0c1e3ce1e1db@suse.com>
Date: Mon, 14 Feb 2022 17:02:52 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH 2/3] amd/msr: allow passthrough of VIRT_SPEC_CTRL for HVM
 guests
Content-Language: en-US
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220201164651.6369-1-roger.pau@citrix.com>
 <20220201164651.6369-3-roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220201164651.6369-3-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR3P281CA0006.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:1d::16) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5fd23e26-e526-4167-8914-08d9efd3756d
X-MS-TrafficTypeDiagnostic: HE1PR0402MB2939:EE_
X-Microsoft-Antispam-PRVS:
	<HE1PR0402MB293901557E32D100A074B5D0B3339@HE1PR0402MB2939.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	7s63LR08y7l5VrEBjCAlc82Cq2ktxxi5hqumN3wtXDlnAEOevB2jLqIXorVzVYnwKyXz9k7XAtLmCn62l9eqkBvImKTMlzIkeyaFqdvD/N57BEj+KTyTkep+RP5ePrQcdmu7S0UAF8Jvdgcx6mxNlDxyoU4CvfYS/BHsoq2kjKftRdt7RfddxUk+XKn5RE0OxXyk6iTRH7FJgvlSazD9/K9rDyLufn1jlBFmDT7+eOOud/1u2szDLr6zuG3pFocALWYTAhBKaAf9r/Ohkvj5kg/rjd9c52+d+N1bpbYK6vtclbytAX/aagYNOUH7WY340gVqibifxBLeKKx9rPJ37IN1XeiUY80OD3Q83E6IEKBsV+NUmzY+ItoRDzD6qS1xG4nBfaCeTxFpuNppHMMje/NYCU1MV8mavZcnZUlsVU8YJtM1gsSLvG5IlZOcDGRpAZiJaUer/qSn8jsA0+uYUfQDo/XUyLdeRdylTD8aHk4noHWBLZ7LCv21tqq5Oatlou074UY5z4pzvROzq1cxaJC7IBrgXPC0281FjIzR383tebkmvo8uI+5bg0kHIcwWum2P93KbVVVdFHUXJrlWQIdbyhFePVRUftmE2lBSkRxBoe8FQMuiGSHtD41GhdmCQKMgw4I1QMudkti9I3tQXa7KOJHXMf5TpVSZ+2pFEE1FGUbTgdGQfMttdSKjHTZ64+b6JGQKPgj70w2OOj47EzGcYAcIyBip7rJNOiUwL1Y=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(5660300002)(8936002)(2906002)(38100700002)(31696002)(86362001)(36756003)(66946007)(2616005)(66476007)(8676002)(66556008)(6512007)(6916009)(54906003)(316002)(6506007)(6486002)(508600001)(31686004)(53546011)(83380400001)(4326008)(186003)(26005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TFVFYnhqeWc3OWp1K1VMcnBBMG9aVjNycC9hUlczeU9hQ3VhSnhyNVBhM1BY?=
 =?utf-8?B?V0lPNDQwMWZ1eWJGUElleGxvcHhsNzVrRmFWV3pERXFKR2RSVnhGdDlxZ2Ix?=
 =?utf-8?B?SnRHQkhodHN6MEJmVkRKcnZMSDV2VWlmcjZsU3ZsQ2FUeGM0cGxDK3JEdDRw?=
 =?utf-8?B?cnIvMFpnVUdLYS9GRlZvbEVyS1pOZWtRRnNmeFZvV1IxTDI0ZTVQVjdIYVFy?=
 =?utf-8?B?MHlZWkRJUXRkWkczQkVULzJhU05ERTUrMWZ3akJZU0c0MlVGc0RiQWJ6RjZy?=
 =?utf-8?B?Y2ZpamI5WFM2M3FnbHRxTW52azd5Y3NwS04vbitaWlZ3MmRNTTB2bjBxRW5y?=
 =?utf-8?B?WCsxMzBxNGZqeDE5cWhwNElyeURXNlErZUQxT3l3OWVvWi9tUlFCQm1ESzF4?=
 =?utf-8?B?aDZSVkt6ZnVBMGxNSEthM0swemg4dk1vdzBhMm56b055TTVLU1VnaGFEU0RM?=
 =?utf-8?B?c2V2cjhtemJBVmJpOXRqRGpxQmVaV3hvQ2tBNWp5MnZLLzBJWGZzQk9jZHpv?=
 =?utf-8?B?a054M1REVzM0OGtpQnRrVUx0T2pCSU9tb0xTOCszSGVLcXFvZms0OTdUV1Va?=
 =?utf-8?B?Rk01WjlRT3pwaEkrMmplWTFvc1BWREg4ZkZpeFRJejdzTHlPT0Vub2dqWVRD?=
 =?utf-8?B?bkR6eW9wSkxyc2c4aENSRUJES0loTzRkSndCcFY4Qk1JYU5SM1NiV3FqWXlJ?=
 =?utf-8?B?WE9KUUVlVVZucGpxRk9CcXJ3Nm85TGxiWENYTitCcjJ4MEo5dlp0WjMxSUgr?=
 =?utf-8?B?Y3VtRWZEbStjV0pjSkhmRGNrU3FmeWovV0laTUtZVFlQcmtQUGtNZjZ1UFpQ?=
 =?utf-8?B?SWxFb21VOXVhTktNNGFORkJBeWpkUURxS2tjQ09rdzhZYzZpb1puYlFlZVgx?=
 =?utf-8?B?bkcyWEQrV3dhcGErbVNXWXFnTURmU1g0TnVKNzYrUEhyK0VCV3Q4T29rbFhC?=
 =?utf-8?B?L3dFVDd1NStZdGR4M0QzaWJVVTdrV0tkN0tFVlpGWDdhRkNpYXRWWEhPcnBD?=
 =?utf-8?B?N2hKR0RyQVNLaW5JbERab0NUOFVRbnloK28rQ1laaGpGbG5hRU9YRlFkbXI1?=
 =?utf-8?B?Zjh5K2hIQ2tmaUMrdEVhQ2pPRFJXV3d1blNmSWVXKzJKajFrbFltVy9BTkpR?=
 =?utf-8?B?ZDRJL1FtMVRkY1ZNVUVwZyt2OHZocmwxMUZRajFITnNzYXRlbUZBSHNZWUhF?=
 =?utf-8?B?Tk1YdlRoNndjUWF1ZEx4T3pMdWRKMHlQVDlUaXVPZUYzUjQ1dnlOM0VaMDRy?=
 =?utf-8?B?V2xCRjFJSjJpZlhsSUdyK3QwOGtXenBhUzNDby9Db0pwK3VuUzFrdTRSd1o5?=
 =?utf-8?B?OHd1QU12QlZRbWgzQWhON0VIUnZiWXo3R1AvRHZJRzI3RXZvVkJ2WUJmRE5Z?=
 =?utf-8?B?eU5nM3lNNmlVeS95SVNMVHdsQndOQTBtVWY3U2llZkJFY2hpYStPWjBiQ1o4?=
 =?utf-8?B?TStVUzhwakxRRlYxZGY1NC9taDFSMGcvVUF6UGtBeEU2dGNTZ0c5RFVOL09O?=
 =?utf-8?B?KytiMnpnQ2lNT0EyUUVEZ1VHaklpQjc2SnRBTnN0bjd1elFUMUpmRTBUaUxq?=
 =?utf-8?B?QzJPMGJFcFpBZGQrY1dTa2l5TzlVKzNKT280akd4M1d1d29wdzVVS1EzZmxz?=
 =?utf-8?B?TTVCZFdzRE5KRUIrQ1p2TUhCNlhqcjBVUUNkUEFrcUdjKzV1NTMwSm8xcitJ?=
 =?utf-8?B?dExCVFpSSnoyeVlkblNtT3hEbzZJckJjNFhxaDJ6NlErV0xZdGltd2cxMXZH?=
 =?utf-8?B?bjlHeVJ3U3lsSXVaUHpCczJkMGMyR0xvSlJBK2dMU3hpTW9qNit3aUtGWnZh?=
 =?utf-8?B?SDNvRzVQdmwxeG1vMUo3dEVVMm5YWWhvSXozRTJoUFVyMWdvcnB2a0dINkg1?=
 =?utf-8?B?MzRORGg5K00yWllTdFVrdElQbGZ2Y0pzVW03dGsrS0N4bkI5anYyZzhNNzh1?=
 =?utf-8?B?cXdwUnI1UjF5Y0NXR0Z1MHJQMzJBNlltbHFscU8vRW5SelVqNWJKbm9iY0pP?=
 =?utf-8?B?V0VXRWpQODg3MWdQTXppUUU5M3B4NWxDVFpNRnlXemRLVkpIbW4vNzU5cWVT?=
 =?utf-8?B?TlA3YU50NzVlaCtYVzBOZG1HSXZSQkZxR2VYcVFKTG1hOVoyQ0NIUHVLWkVZ?=
 =?utf-8?B?eXZIRTJacDJSOTBTazVUYndhNnlYQmNYU0hGTmtWVmNrUXdYV3h3RTBmNVFm?=
 =?utf-8?Q?bUO1vYfjtRyFLftwLYdZIw0=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5fd23e26-e526-4167-8914-08d9efd3756d
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2022 16:02:53.8917
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DBdozjrlQu4EQPb9cGS4HlAFX9To8EpHx84o5H+nIArHyfS2+UWfk87j5cN+DYxuWXHx6aT87Yyt9M2Eu0d2OA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0402MB2939

On 01.02.2022 17:46, Roger Pau Monne wrote:
> Allow HVM guests untrapped access to MSR_VIRT_SPEC_CTRL if the
> hardware has support for it. This requires adding logic in the
> vm{entry,exit} paths for SVM in order to context switch between the
> hypervisor value and the guest one. The added handlers for context
> switch will also be used for the legacy SSBD support.

So by "hardware" you mean virtual hardware here, when we run
virtualized ourselves? While the wording in AMD's whitepaper suggests
hardware could exist with both MSRs implemented, so far it was my
understanding that VIRT_SPEC_CTRL was rather left for hypervisors to
implement. Maybe I'm wrong with this, in which case some of the
further comments may also be wrong.

> --- a/xen/arch/x86/cpu/amd.c
> +++ b/xen/arch/x86/cpu/amd.c
> @@ -687,6 +687,7 @@ void amd_init_lfence(struct cpuinfo_x86 *c)
>   */
>  void amd_init_ssbd(const struct cpuinfo_x86 *c)
>  {
> +	struct cpu_info *info = get_cpu_info();
>  	int bit = -1;
>  
>  	if (cpu_has_ssb_no)
> @@ -699,7 +700,7 @@ void amd_init_ssbd(const struct cpuinfo_x86 *c)
>  
>  	if (cpu_has_virt_ssbd) {
>  		wrmsrl(MSR_VIRT_SPEC_CTRL, opt_ssbd ? SPEC_CTRL_SSBD : 0);
> -		return;
> +		goto out;
>  	}
>  
>  	switch (c->x86) {
> @@ -729,6 +730,10 @@ void amd_init_ssbd(const struct cpuinfo_x86 *c)
>  
>  	if (bit < 0)
>  		printk_once(XENLOG_ERR "No SSBD controls available\n");
> +
> + out:
> +	info->last_spec_ctrl = info->xen_spec_ctrl = opt_ssbd ? SPEC_CTRL_SSBD
> +							      : 0;
>  }

Besides me being uncertain about the placement of these (preferably
the writes would be where the other similar writes are), this re-use
of the values suggests that you mean to prefer VIRT_SPEC_CTRL use
over that of SPEC_CTRL (see below).

Additionally - the value you store isn't necessarily the value you
wrote to the MSR. It only is if you cam here via the "goto out".

> --- a/xen/arch/x86/hvm/svm/entry.S
> +++ b/xen/arch/x86/hvm/svm/entry.S
> @@ -71,7 +71,9 @@ __UNLIKELY_END(nsvm_hap)
>              mov    %al, CPUINFO_last_spec_ctrl(%rsp)
>  1:          /* No Spectre v1 concerns.  Execution will hit VMRUN imminently. */
>          .endm
> -        ALTERNATIVE "", svm_vmentry_spec_ctrl, X86_FEATURE_SC_MSR_HVM
> +        ALTERNATIVE_2 "", STR(call vmentry_virt_spec_ctrl), \

I'm afraid this violates the "ret" part of the warning a few lines up,
while ...

> +                          X86_FEATURE_VIRT_SC_MSR_HVM, \
> +                      svm_vmentry_spec_ctrl, X86_FEATURE_SC_MSR_HVM
>  
>          pop  %r15
>          pop  %r14
> @@ -111,7 +113,9 @@ __UNLIKELY_END(nsvm_hap)
>              wrmsr
>              mov    %al, CPUINFO_last_spec_ctrl(%rsp)
>          .endm
> -        ALTERNATIVE "", svm_vmexit_spec_ctrl, X86_FEATURE_SC_MSR_HVM
> +        ALTERNATIVE_2 "", STR(call vmexit_virt_spec_ctrl), \

... this violates ...

> +                          X86_FEATURE_VIRT_SC_MSR_HVM, \
> +                      svm_vmexit_spec_ctrl, X86_FEATURE_SC_MSR_HVM
>          /* WARNING! `ret`, `call *`, `jmp *` not safe before this point. */

... the "ret" part of this warning.

Furthermore, opposite to what the change to amd_init_ssbd() suggests,
the ordering of the alternatives here means you prefer SPEC_CTRL over
VIRT_SPEC_CTRL; see the comment near the top of _apply_alternatives().
Unless I've missed logic guaranteeing that both of the keyed to
features can't be active at the same time.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 16:03:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 16:03:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272493.467358 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJdpU-0007Am-Qt; Mon, 14 Feb 2022 16:03:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272493.467358; Mon, 14 Feb 2022 16:03:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJdpU-0007Af-NE; Mon, 14 Feb 2022 16:03:56 +0000
Received: by outflank-mailman (input) for mailman id 272493;
 Mon, 14 Feb 2022 16:03:54 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJdpS-0007AS-LA
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 16:03:54 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b3a02283-8daf-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 17:03:52 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b3a02283-8daf-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644854632;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=StROPKuxRDWHKFtz/wutII19P4YWxQwb/TJitVL2oMI=;
  b=BExa9eCHs36u2LMyp9BzrABBogjuMxcPknHXd4ShaaVu2WbePrKqELE/
   xqTvbWnFxW2Ds3n+zBgLKYg1pRmFL3VeyldJCJNBiPVVmb9H4J7mObhYJ
   5VRBhzIYX2++LM9bAY3neJIB99lBrjKLPk9/0j5T/fS6SEmrreOJYmGBd
   Q=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: oJ0/g/ThcQyWzIl9twQR8eq5Km5nVpSLzQ+q4Kl4BF0j/W6wjiG+RILhvx8fEb4LoB2Jcj23Ln
 RNyvWXFWQTRhdtavlToX8PycVOpRg/P2UhXZSAcP/xV6ufc2sKGL/CH02w4CWIfANTYTWLIonv
 oc4eCsZFMbyr+UGG4vw2foaGsNrg9PKZFFj0wKHL9i+QRwje0v8Nt6PWHGkK1FTwms5qzsqki0
 TSX0/lJP0D13tFqEQkzKxVUJbgJqni2waSdaQk1WFRrSFkvh/jsmtUnYAV156bXUQrVMd6htOG
 1mjnf9FOAlR1bQvHs+GEXfeV
X-SBRS: 5.1
X-MesageID: 63610258
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:MqqHt6NVg0E/+trvrR1xkMFynXyQoLVcMsEvi/4bfWQNrUoqhTFRy
 WJNXzrVaPjbNDT8fY1zOt7k/ENV7JWAztdrTgto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6UUsxNbVU8En1500s/w7RRbrNA2rBVPSvc4
 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq
 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYo27UhIt8y
 etEj7itQ18qZInBuctAECANRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs
 6VFdnZdNXhvhMrvqF6/YsBqit4uM4/AO4QHt2s75TrYEewnUdbIRKCiCdpwgmxu35gUQKa2i
 8wxSyJhQTWQYx91Y3QTN50GgfjwhkDbWmgNwL6SjfVuuDWCpOBr65D9PdyQdtGUSMF9mkeDu
 nmA72n/GgsdNtGU1XyC6H3ErvDLtTP2XsQVDrLQ3vxgjUCXx2cTIAYLTlb9qv684nNSQPoGd
 RZSoHB36/Fvqgr7FbERQiFUvlbf4wVHVttuGtce9QvVyfDw7ie2Wys9G2sphMMdiOc6Qjkj1
 1msltzvBCByvLD9dU9x5ot4vhvpZ3FLcDZqiTssCFJcvoK9+N1bYgfnE447eJNZmOEZDt0ZL
 9qiiCElz4segscQv0lQ1QCW2mn8znQlo+Nc2+k2Yo5Hxl4jDGJGT9bxgbQ+0RqnBNzHJmRtR
 FBex6CjABkmVPlhbhClTuQXB62O7P2YKjDailMHN8B/q2jyqy7+INgJu2sWyKJV3iEsI2GBX
 aMukVkJuM870IWCMcebnL5d++x1lPO9RLwJp9jfb8ZUY4gZSeN01HoGWKJk5Ei0yBJEufhmY
 f+zKJ/wZV5HWfUP5GfnHI81jO50rh3SMEuOHPgXOTz8iuHADJNUIJ9YWGazghcRsv/V/lWNq
 4wHXyZIoj0GONDDjuDs2dd7BXgBLGQhBICwrMpSd+WZJRFhFn1nAPjUqY7NsaQ890iMvuuXr
 Hy7RGFCz1/z2S/OJQmQMygxY7LzR5dv63k8OHV0b1qv3nEiZ6ep7bseKMRrLeV2qrQ7wK4mV
 eQBduWBHu9LFmbN9QMCYMSvt4dlbhmq216DZnL3fDglcpd8bAXV4du4LBD3/SwDA3Pv58szq
 rGtzC3BRp8HS1gwBcracqv3nViwoWIciKR5WE6Reotff0Dl8Y5LLS3tj6Bof5FQeEubnjbDj
 lSYGxYVo+XJsrQZytiRiPDWtZqtHst/AlFeQzvR44GpOHSI5WGk24JBDrqFJGiPSGPu9ay+T
 uxJ1PWgYuYflVNHvocgQbZmyaUyu4nmq7NAl1k2GXzKaxKgC696I2nA1s5K7/UfyrhcsAqwe
 0SO5tgFZunZZJK7SAYcdFg/c+CO9fAIgT2Dv/06LXLz6DJz4LfaA15ZOAOBiXAFIbZ4WG//L
 TzNZCLCB9SDtycX
IronPort-HdrOrdr: A9a23:xbE/8KjeI9PU7xD8ZuGbuQVj6nBQX3513DAbv31ZSRFFG/FwyP
 rAoB1L73PJYWgqNU3IwerwRZVpQRvnhPtICRF4B8btYOCUghrVEGgE1/qi/9SAIVywygc578
 ldmsdFeaTN5DRB/KXHCUyDYqwdKbq8geCVbIXlvg9QpGhRAskKhWYYNu/YKDwMeOAvP+tiKH
 P23Lsim9PUQwVwUi3NPAhjYwGsnayoqLvWJTo9QzI34giHij2lrJTgFQKD4xsYWzRThZ8/7G
 nsiWXCl+aemsD+7iWZ+37Y7pxQltek4MBEHtawhs8cLSipohq0Zb5mR6aJsFkO0aOSARcR4Z
 zxSiUbToNOAkDqDyeISNzWqlDdOQMVmjvfIJmj8CPeSILCNWkH4oF69P1km1PimjQdVZdHof
 92Niuixupq5VmrplWN2/HYEx5tjUa6unwkjKoaiGFeS5IXbPtLoZUY5149KuZLIMvW0vFuLA
 BVNrCW2B+WSyLvU1nJ+m10hNC8VHU6GRmLBkAEp8yOyjBT2HR01VERysATlmoJsMtVcegJ28
 3UdqBz0L1eRM4faqxwQO8HXMusE2TIBRbBKnibL1jrHLwOf3jNt5n06rMo4/zCQu1E8LIi3J
 DaFF9Iv287fEzjTcWIwZ1Q6xjIBH6wWDz8o/surqSReoeMMoYDHRfzOmzGovHQ1Mn3WPerKM
 pbEKgmdsPeEQ==
X-IronPort-AV: E=Sophos;i="5.88,368,1635220800"; 
   d="scan'208";a="63610258"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=QIv5L6bdN1As3NPOqhgTXyY34aGrl5gh336Ba/XFBUtkF+THyiRcPoOCgkzxYoOPBRul8J+7uuidW+Coh70b1m7bnI55yj/Nz3uhALDXkCy2OosB8LuhWyLGzOk0Utb35g2y/uqMSbGT1apUmbEThGxs8wMLo6poYJz44+5ceSLekPc34IR5klclDowj5w6jMU+Xvh6SH442VImR/hJxuMCaEsIqRAtA0VG1+ItB/bSd1kOGLTUNuaxq05IioKsL6TxDVU8ipBGhlIghQ5Yt1faTO/L00DZ5bCQtsn6V2tjjHE6X2QB4UxLq3hhqZ3XVvSS2nCZDuELPyGuboXU4Yw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=StROPKuxRDWHKFtz/wutII19P4YWxQwb/TJitVL2oMI=;
 b=NYNI+72uipR6a4GTXx9ab8wEZ2LDfHyBVKBSuM9+2Ii7yGJOYkKWkaeHVs7r5kSBW3sixJ/0WFC+VtGQBHxn0W8GvTtbbXVMMN6U9xh77qxKoqt44uWnTZFin4ezQp/wlCENsh1XC0bwN9fEsgmiq0pnsBXnVUaxKPSSKWrRiBAYiSXToYVbxgipHmOhxROitWZkPkivE0zlHyHXG0A2+stNxG1TWoEzS0oHfEuIyhXMJAh60WnqeUK4+Z/4lj5U/M/rieGbP4r9iEDCz/1lR9ItjJbssuhj6DE7Aw55I9gAmncX2gzRmJnLYKxN018BOpA/+0G+KcRBgnz1U0Dqdg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=StROPKuxRDWHKFtz/wutII19P4YWxQwb/TJitVL2oMI=;
 b=tr7NuNAU3IOawsrVxkObCCqgURe+95iSzEL2nVycovqLvE9wp1b2qQ3AKUm9yPXQCmfXl2NhY5V2XbGMEHoo/kt+c5NzYQN9IANxYCoHDqpXB3mExItEH1/mkULIakmfBIpOpqBwgZO9EHVV8Su2zhQrRg2njfWVuDJfXa/BAKw=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>, Xen-devel
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2 3/7] x86/altcall: Optimise away endbr64 instruction
 where possible
Thread-Topic: [PATCH v2 3/7] x86/altcall: Optimise away endbr64 instruction
 where possible
Thread-Index: AQHYIaJdlBm1laP+30eCBtzXO5xQTKyTA/+AgAAG84CAAAW9AIAAJPGA
Date: Mon, 14 Feb 2022 16:03:47 +0000
Message-ID: <c053423d-e06f-b349-34bc-9509dc44bcd7@citrix.com>
References: <20220214125632.24563-1-andrew.cooper3@citrix.com>
 <20220214125632.24563-4-andrew.cooper3@citrix.com>
 <5d53c6f9-8d1a-3d48-6ea6-14a484d578a0@suse.com>
 <cc4cf340-f02f-a547-08a0-1261bb506bcf@citrix.com>
 <adbd9ee8-46c5-9696-c3eb-3e18b2d60684@suse.com>
In-Reply-To: <adbd9ee8-46c5-9696-c3eb-3e18b2d60684@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: b10190c8-8dfe-4a1f-e13c-08d9efd3957d
x-ms-traffictypediagnostic: DM5PR03MB3385:EE_
x-microsoft-antispam-prvs: <DM5PR03MB3385B6141B541337CC762DE8BA339@DM5PR03MB3385.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: OFHM66riLSRAlV8i8xgJd5hAQTH7mlKAw3m0qm8aJYtmCtO5sTeLZglm8X9SyHeS8DbwRFo6/azO4/ak+5FPlWAQHxmsNtGjVVhzosqFyOARY8TU27wrkFMHVUF1UaEa9Ux7+RFrqHJtvx90N5JyLUeJH6+LqeZNOPsRl9aFD4/mA4II2+qcP5gT5LQQXmYIQkACqx3iUaa2UPNBrTfJ1FshLBwcmvO37LDQcGw9yAilE983khxRaGtfdOMdYOYYKgcbAwYP6dur74IrtgC3VA7/V8wNaGYgOuT7MdyPE8NGuuV+gujNmOuFhbSLCYPJlX9lPuaTaIb2qyhtNt7AqT+NlOstuKbRPoJYfGxEjaezehHaf+5/2B/bWuwtPn6MXK3JxBXRWLBklrTf3CXjAEND5K6Hj/okTV6v/1LPradEo2rtm9isssLfZ3w5n1ORMTUz6li28Tlfc5zalt0gvmYufBHTha9VpsJa+wfdH0ifBfv37rJ3y0Z2AFtBWJJsuEpE8Lwi4GOx0XO0rYhzHNe7TgJEl/LXwtFOEmCFl71F2MJPwnyfMAyO+zflV9OrHsDvtUwxSuuIdhMZwiXWzymoFSH09R5QMVqQvSOycVj2HBVwjmdHokadGxBI0eZEngWoW4neE53g38d+bgIQdS2//PQi2AaYez7yr+JmobnmCn1l6qJ5TPUYwecXneuzdG+iizd7uM+YsDXjC1G5mtQcQRByHXCokyVieLgfw3z8Z+OY/HJ5mmklTdUo+l8n
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(508600001)(6486002)(8936002)(31686004)(122000001)(2906002)(38100700002)(82960400001)(36756003)(4326008)(5660300002)(8676002)(316002)(66556008)(31696002)(38070700005)(6916009)(26005)(64756008)(54906003)(76116006)(66946007)(66446008)(66476007)(53546011)(91956017)(71200400001)(6506007)(186003)(2616005)(6512007)(83380400001)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?d0dJckFyUlBKc3oyeEM4azNnTnFOVmErTUFuQVpkRDZlMHVJNDVOUk9IaUNh?=
 =?utf-8?B?ZnhHOHc4QitZNENPQllQRWR2Smc0Ny9jNXJxU3BCVlhVdjVvME40c3dVclUx?=
 =?utf-8?B?bGFMTWR2SlVrQnlkVkJVTUk1dkRFRDIrcmhIUWhOeVliUmxBdzA4eUZVMHJh?=
 =?utf-8?B?S0tPSEZCcDhiT0hEVVphc2N0cThzME5jTVdTaEVvbHZ3NzFVYVJWbTJIenNz?=
 =?utf-8?B?U0YwNTN1US8yZ081ZCtEMUUwQjlDTUtvS0xqTXl6YzNrMDNVR1dVWUNMcnBi?=
 =?utf-8?B?ZWsyVUplQzJEbnhaL0ZQdHhvVFNrM2ZSdi9hZU1XdXREWWlOV3BBUGRuUjNr?=
 =?utf-8?B?dHlTKyt3c1ZxOWJHaXZVNzh4bysvVUs0OW9CVFJ5alQ2bTl3cjh4MEIyS1py?=
 =?utf-8?B?bzJ4R0ttUWx0YnNGY29HeSsvRDNOMWdBZTdhZGM5S0NFVUpEWG9pNlRodUt5?=
 =?utf-8?B?WjdUMnlmYzdxZWtheHlXWjFFZm5RVHVTRDdBb2VlbTJOdzh0YmNLc1hQUHQy?=
 =?utf-8?B?YlRGRVBTK3MrU3IzMTlxQ2R0R2MrWGdRWHZVZWwybU9rc1ZWMkRMNCtPelQy?=
 =?utf-8?B?Sk9zUVpJdCtmMGEwR3l4T1dXRGthWTBMK2pXUDdIZzJRbkJ1ajNqcTNOdm1K?=
 =?utf-8?B?T05pUjlCeFkwUjkwZ2JPcjY0a2g2Qk9tTElUWUplUDJWRW9WbUUvNlVDcysr?=
 =?utf-8?B?SW50M2xCQ2t5UWpDWVVCL2FVdFcxUVRlWGVFN1lOUlBDNXBtQzcwczFOSVdq?=
 =?utf-8?B?RVF4NWhudWxMM1RFWEtBbzJDSkNhczRuQ09aNmVhUllXWksvek9MaElXRHdK?=
 =?utf-8?B?MjRqRUZVeDVBNUE3OUlWUkF0c1kwTVV2WlhoRDkrdll0NDYzYU5RcnVSeDhl?=
 =?utf-8?B?cSt4dUR6RzJoWXU3SnRJeTFrSnIxcEl5UzNNVmRSMjkrK0FPMTQySFMrUDB2?=
 =?utf-8?B?dTdueVE2Mm1YOGNFMEtYdkJTcGdvbmxxK0ZrZm9nYkV2ekVFRjdVUkxTQjhm?=
 =?utf-8?B?ai93dG5CNzZIWkJoZytLNkd4aGsza3AyWnE3bytST1VnSmdnZVg0d0lTK0I3?=
 =?utf-8?B?N01hSlhWamhwUTJXbmo1QWFBdUdSQnJTZTJ2S05mOVZCOSsvZ2xyNERlandC?=
 =?utf-8?B?ZWl0SjNKaWhpTy9vZGV1QVk0aWx2VVQxUkN6NWhZWFcxMldZR2dhVXFaNXo4?=
 =?utf-8?B?MEYzc0M3dytxajg3M1FRdmFtanBJbUlsVzhldXQrb0U1SG5RWkVOcnFjc1Fq?=
 =?utf-8?B?cm1RT2luM25JSTZRTzlvMEoxMm9SY3puT003NlcxTGVIQnJLb05hVnp4Q3J1?=
 =?utf-8?B?dVJLcTUzeXdLVGR5NVJIRXcxWjJPSmlCOUg2a05QWTNNc2NnVVdTaXA2bkJj?=
 =?utf-8?B?aUJOdWFlc2hpQUVqQVpPRkRtSzRST2xzaE1XZ3U0U3pIcEtBdEF2Tnh5bVhi?=
 =?utf-8?B?Qlh6TUQydVArZzlCNjlhMkVKaUlhcTczWjZlV0NmNUJzUjAxVXdzVlUrQldJ?=
 =?utf-8?B?UUQ1b0tZMzZNbFFnRXRYS2I3aFprRHRXUjFUbEhkZ3JIdkc0YTZoeUNKZjBz?=
 =?utf-8?B?OCsraDZYS045Um1Xa2liSFFIMVZzSG53eXJaWnFqVElKbVVTRzVSS2JEYjJ4?=
 =?utf-8?B?MEJuQVVlZzE2RDlFTXZCeHB2UG1QQjNCTGZBa0lxMmxiVEo5UEw2YnRRUFR1?=
 =?utf-8?B?Wlp0RUhIUFpucThrNHhsSkthOHovUktrUFNCS1l2MkRYRjFxWlRXNXhFVUk0?=
 =?utf-8?B?bVZOU3haSDIzeGh3R2p1ZjZ2cW9zSmJxbS95L2hNNENGUFR0eFg4eVpQUHVx?=
 =?utf-8?B?blpxMjg0Ly9lTEt3VTFPUGhMUW8vMElNNmN3SEZkTENlSzl3czdMaXcxZ0Nw?=
 =?utf-8?B?bVNEdG5EUFRmRUx3bkI4SGc5NVlFdzd1V3hXZ3cyZ1oweCs3UVlySE10T1Nu?=
 =?utf-8?B?R0dVV2dhaHdlcEJqNGpoa3dqM1NpTFVZT2sxK1ZQWGxoTTdjUjhHOUVmVkx0?=
 =?utf-8?B?MWZCWk0xS3I3RThtQVJEUm1EZHhHNEJ3YmJ4eW5ITDdmTXVBUS9RMlhUOHFN?=
 =?utf-8?B?aWloaXdKTzlyR1ZUckhJQ3RvZk55cXNCVGptMXRRenVCSG8zWElITVdwZlM3?=
 =?utf-8?B?bm9oQXdPbUkwNWlJQTZoSjUzRDBQaDQ5OWpxSC9ocHJiKzNPNFpCWWJWaG51?=
 =?utf-8?B?b3RRRWZNY2p5RVZTekcwMjlhaDBQTGxPU0ZEaUJ2aUJ4OVRvS0lIMm5TRDc3?=
 =?utf-8?B?dG96R1owQzhVUjBGdHZVbk9QSDJnPT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <B394ABA936C9D44CAA99CBFDA211740A@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b10190c8-8dfe-4a1f-e13c-08d9efd3957d
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Feb 2022 16:03:47.3891
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: jLEnW/2Fem/TO3QjFsFgKOuuL8XFPa/BF34/yBWrRb4brQaBwu3dxPiZjuI3hWk9ILG4bHwVxuCSyFPc/puGZnwY+3fBzXDO2xp2SPhysDM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB3385
X-OriginatorOrg: citrix.com

T24gMTQvMDIvMjAyMiAxMzo1MSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDE0LjAyLjIwMjIg
MTQ6MzEsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBPbiAxNC8wMi8yMDIyIDEzOjA2LCBKYW4g
QmV1bGljaCB3cm90ZToNCj4+PiBPbiAxNC4wMi4yMDIyIDEzOjU2LCBBbmRyZXcgQ29vcGVyIHdy
b3RlOg0KPj4+PiBAQCAtMzMwLDYgKzMzMyw0MSBAQCBzdGF0aWMgdm9pZCBpbml0X29yX2xpdmVw
YXRjaCBfYXBwbHlfYWx0ZXJuYXRpdmVzKHN0cnVjdCBhbHRfaW5zdHIgKnN0YXJ0LA0KPj4+PiAg
ICAgICAgICBhZGRfbm9wcyhidWYgKyBhLT5yZXBsX2xlbiwgdG90YWxfbGVuIC0gYS0+cmVwbF9s
ZW4pOw0KPj4+PiAgICAgICAgICB0ZXh0X3Bva2Uob3JpZywgYnVmLCB0b3RhbF9sZW4pOw0KPj4+
PiAgICAgIH0NCj4+Pj4gKw0KPj4+PiArICAgIC8qDQo+Pj4+ICsgICAgICogQ2xvYmJlciBlbmRi
cjY0IGluc3RydWN0aW9ucyBub3cgdGhhdCBhbHRjYWxsIGhhcyBmaW5pc2hlZCBvcHRpbWlzaW5n
DQo+Pj4+ICsgICAgICogYWxsIGluZGlyZWN0IGJyYW5jaGVzIHRvIGRpcmVjdCBvbmVzLg0KPj4+
PiArICAgICAqLw0KPj4+PiArICAgIGlmICggZm9yY2UgJiYgY3B1X2hhc194ZW5faWJ0ICkNCj4+
Pj4gKyAgICB7DQo+Pj4+ICsgICAgICAgIHZvaWQgKmNvbnN0ICp2YWw7DQo+Pj4+ICsgICAgICAg
IHVuc2lnbmVkIGludCBjbG9iYmVyZWQgPSAwOw0KPj4+PiArDQo+Pj4+ICsgICAgICAgIC8qDQo+
Pj4+ICsgICAgICAgICAqIFRoaXMgaXMgc29tZSBtaW5vciBzdHJ1Y3R1cmUgKGFiKXVzZS4gIFdl
IHdhbGsgdGhlIGVudGlyZSBjb250ZW50cw0KPj4+PiArICAgICAgICAgKiBvZiAuaW5pdC57cm8s
fWRhdGEuY2ZfY2xvYmJlciBhcyBpZiBpdCB3ZXJlIGFuIGFycmF5IG9mIHBvaW50ZXJzLg0KPj4+
PiArICAgICAgICAgKg0KPj4+PiArICAgICAgICAgKiBJZiB0aGUgcG9pbnRlciBwb2ludHMgaW50
byAudGV4dCwgYW5kIGF0IGFuIGVuZGJyNjQgaW5zdHJ1Y3Rpb24sDQo+Pj4+ICsgICAgICAgICAq
IG5vcCBvdXQgdGhlIGVuZGJyNjQuICBUaGlzIGNhdXNlcyB0aGUgcG9pbnRlciB0byBubyBsb25n
ZXIgYmUgYQ0KPj4+PiArICAgICAgICAgKiBsZWdhbCBpbmRpcmVjdCBicmFuY2ggdGFyZ2V0IHVu
ZGVyIENFVC1JQlQuICBUaGlzIGlzIGENCj4+Pj4gKyAgICAgICAgICogZGVmZW5jZS1pbi1kZXB0
aCBtZWFzdXJlLCB0byByZWR1Y2UgdGhlIG9wdGlvbnMgYXZhaWxhYmxlIHRvIGFuDQo+Pj4+ICsg
ICAgICAgICAqIGFkdmVyc2FyeSB3aG8gaGFzIG1hbmFnZWQgdG8gaGlqYWNrIGEgZnVuY3Rpb24g
cG9pbnRlci4NCj4+Pj4gKyAgICAgICAgICovDQo+Pj4+ICsgICAgICAgIGZvciAoIHZhbCA9IF9f
aW5pdGRhdGFfY2ZfY2xvYmJlcl9zdGFydDsNCj4+Pj4gKyAgICAgICAgICAgICAgdmFsIDwgX19p
bml0ZGF0YV9jZl9jbG9iYmVyX2VuZDsNCj4+Pj4gKyAgICAgICAgICAgICAgdmFsKysgKQ0KPj4+
PiArICAgICAgICB7DQo+Pj4+ICsgICAgICAgICAgICB2b2lkICpwdHIgPSAqdmFsOw0KPj4+PiAr
DQo+Pj4+ICsgICAgICAgICAgICBpZiAoICFpc19rZXJuZWxfdGV4dChwdHIpIHx8ICFpc19lbmRi
cjY0KHB0cikgKQ0KPj4+PiArICAgICAgICAgICAgICAgIGNvbnRpbnVlOw0KPj4+PiArDQo+Pj4+
ICsgICAgICAgICAgICBhZGRfbm9wcyhwdHIsIDQpOw0KPj4+IFRoaXMgbGl0ZXJhbCA0IHdvdWxk
IGJlIG5pY2UgdG8gaGF2ZSBhICNkZWZpbmUgbmV4dCB0byB3aGVyZSB0aGUgRU5EQlI2NA0KPj4+
IGVuY29kaW5nIGhhcyBpdHMgY2VudHJhbCBwbGFjZS4NCj4+IFdlIGRvbid0IGhhdmUgYW4gZW5j
b2Rpbmcgb2YgRU5EQlI2NCBpbiBhIGNlbnRyYWwgcGxhY2UuDQo+Pg0KPj4gVGhlIGJlc3QgeW91
IGNhbiBwcm9iYWJseSBoYXZlIGlzDQo+Pg0KPj4gI2RlZmluZSBFTkRCUjY0X0xFTiA0DQo+Pg0K
Pj4gaW4gZW5kYnIuaCA/DQo+IFBlcmhhcHMuIFRoYXQncyBub3QgaW4gdGhpcyBzZXJpZXMgbm9y
IGluIHN0YWdpbmcgYWxyZWFkeSwgc28gaXQncyBhIGxpdHRsZQ0KPiBoYXJkIHRvIGNoZWNrLiBC
eSAiY2VudHJhbCBwbGFjZSIgSSByZWFsbHkgbWVhbnQgaXNfZW5icjY0KCkgaWYgdGhhdCdzIHRo
ZQ0KPiBvbmx5IHBsYWNlIHdoZXJlIHRoZSBlbmNvZGluZyBhY3R1YWxseSBhcHBlYXJzLg0KDQpl
bmRici5oIGlzIHRoZSBoZWFkZXIgd2hpY2ggY29udGFpbnMgaXNfZW5kYnI2NCgpLCBhbmQgZGVs
aWJlcmF0ZWx5IGRvZXMNCm5vdCBjb250YWluIHRoZSByYXcgZW5jb2RpbmcuDQoNCj4NCj4+Pj4g
LS0tIGEveGVuL2FyY2gveDg2L3hlbi5sZHMuUw0KPj4+PiArKysgYi94ZW4vYXJjaC94ODYveGVu
Lmxkcy5TDQo+Pj4+IEBAIC0yMjEsNiArMjIxLDEyIEBAIFNFQ1RJT05TDQo+Pj4+ICAgICAgICAg
KiguaW5pdGNhbGwxLmluaXQpDQo+Pj4+ICAgICAgICAgX19pbml0Y2FsbF9lbmQgPSAuOw0KPj4+
PiAgDQo+Pj4+ICsgICAgICAgLiA9IEFMSUdOKFBPSU5URVJfQUxJR04pOw0KPj4+PiArICAgICAg
IF9faW5pdGRhdGFfY2ZfY2xvYmJlcl9zdGFydCA9IC47DQo+Pj4+ICsgICAgICAgKiguaW5pdC5k
YXRhLmNmX2Nsb2JiZXIpDQo+Pj4+ICsgICAgICAgKiguaW5pdC5yb2RhdGEuY2ZfY2xvYmJlcikN
Cj4+Pj4gKyAgICAgICBfX2luaXRkYXRhX2NmX2Nsb2JiZXJfZW5kID0gLjsNCj4+Pj4gKw0KPj4+
PiAgICAgICAgICooLmluaXQuZGF0YSkNCj4+Pj4gICAgICAgICAqKC5pbml0LmRhdGEucmVsKQ0K
Pj4+PiAgICAgICAgICooLmluaXQuZGF0YS5yZWwuKikNCj4+PiBXaXRoIHIvbyBkYXRhIGFoZWFk
IGFuZCByL3cgZGF0YSBmb2xsb3dpbmcsIG1heSBJIHN1Z2dlc3QgdG8gZmxpcCB0aGUNCj4+PiBv
cmRlciBvZiB0aGUgdHdvIHNlY3Rpb24gc3BlY2lmaWVycyB5b3UgYWRkPw0KPj4gSSBkb24ndCBm
b2xsb3cuwqAgVGhpcyBpcyBhbGwgaW5pdGRhdGEgd2hpY2ggaXMgbWVyZ2VkIHRvZ2V0aGVyIGlu
dG8gYQ0KPj4gc2luZ2xlIHNlY3Rpb24uDQo+Pg0KPj4gVGhlIG9ubHkgcmVhc29uIGNvbnN0IGRh
dGEgaXMgc3BsaXQgb3V0IGluIHRoZSBmaXJzdCBwbGFjZSBpcyB0byBhcHBlYXNlDQo+PiB0aGUg
dG9vbGNoYWlucywgbm90IGJlY2F1c2UgaXQgbWFrZXMgYSBkaWZmZXJlbmNlLg0KPiBJdCdzIG1h
cmdpbmFsLCBJIGFncmVlLCBidXQgaXQgd291bGQgc3RpbGwgc2VlbSBtb3JlIGNsZWFuIHRvIG1l
IGlmIGFsbA0KPiAocHNldWRvKSByL28gaW5pdCBkYXRhIGxpdmVkIHNpZGUgYnkgc2lkZS4NCg0K
SSBzdGlsbCBkb24ndCB1bmRlcnN0YW5kIHdoYXQgeW91J3JlIGFza2luZy4NCg0KVGhlcmUgaXMg
bm8gc3VjaCB0aGluZyBhcyBhY3R1YWxseSByZWFkLW9ubHkgaW5pdCBkYXRhLg0KDQpXaGVyZXZl
ciB0aGUgLmluaXQucm9kYXRhIGdvZXMgaW4gaGVyZSwgaXQncyBib3VuZGVkIGJ5IC5pbml0LmRh
dGEuDQoNCn5BbmRyZXcNCg==


From xen-devel-bounces@lists.xenproject.org Mon Feb 14 16:08:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 16:08:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272501.467369 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJdtW-0007rY-BX; Mon, 14 Feb 2022 16:08:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272501.467369; Mon, 14 Feb 2022 16:08:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJdtW-0007rR-7F; Mon, 14 Feb 2022 16:08:06 +0000
Received: by outflank-mailman (input) for mailman id 272501;
 Mon, 14 Feb 2022 16:08:04 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KkXt=S5=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nJdtU-0007rL-OX
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 16:08:04 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 49cdfc01-8db0-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 17:08:03 +0100 (CET)
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2057.outbound.protection.outlook.com [104.47.1.57]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-27-Itk0yU7ANimHtrBLHx28fw-1; Mon, 14 Feb 2022 17:08:02 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB2926.eurprd04.prod.outlook.com (2603:10a6:800:b0::7)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.18; Mon, 14 Feb
 2022 16:08:01 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4975.015; Mon, 14 Feb 2022
 16:08:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 49cdfc01-8db0-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644854883;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Nbq4sQnmqk3MsN0OZY5mRXiNBWgdOrNm8u8zqAKKpsA=;
	b=TDLwA84bqFmdrBVa3D+zuCK/mf0nUOp80mLQlpj/2P9VEA9FslIy0Q/6kb4x+pbEKMccxM
	aJELW84HFZcCkfl3X1vuN6LJtiaQv+fAhY+iB3g24xe3NDWLLfk/kBCUOjoDwFd95PUV4A
	jqHxLmTBbU+uqR3mIqJut6bk2RcpDpo=
X-MC-Unique: Itk0yU7ANimHtrBLHx28fw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Fvq4mZ6o5e8SyLw6aXs1rIgQ+k3IewY/H/d4QOhmeo/Q23ZYwHeBYFvkIL7kHPD5/N+yX29LAkgKYuV2auj68uBWJl+ZamEsX3sroPKDbt7rwOTtF7xrGpOpYNUa1IhY5AtHldc78HYsG6IApGWdcavFH0DNVPHhHGGAUNcVH2t1uPkXWfoAlef2WdAibZIrbJvNAyoBiQc53JYpQMCLKxYaVz9xlr3i9rb+hqhB8kBRxTTVqZk9tnQ8iO9B664NQw1efMsx/OuR4dSgzhDgFBNJHZaj9kJJRCzcD41x4oHZCoYFqIWUO9T8G9ameY+ydjDpTu0hV0KgLHkt5ZM5+Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=EhY03lxHPMCG6Jq0lSqJfOp+8hAqqZYyfYrGfCPZ/c4=;
 b=hhZmA6i3Xa0R1mbZx5wdpEtDwQRlHRV0rpBIRZNnmYzw03l4n4qeKxxd0yFlQT3kn/shI0mrQo1JMQG8X+T0vZoKkMfGVkywggr6MYrlzNyZzb+PwRFjZRon8lU67BQuuu9f/xLvKKWsAQKSzv5H1tBd+z6duWeiKWK1QrsjabLvfM0jVQdJZyB/BWD+B4+wy8A57AUfPWKivEF5ob4gzg8MJxjZr1gKvGokcbAFLucvAPQwGjJa9kjTdnSQoX++B6AGGFZ2+DOhjgsxqCYK5D3Ioq2UQAWZD0v/EnJzvZ8tq2stZ7eAA+gGw2torYILWJ2nFT7UPDfSxVuwhP1Ntw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <c9fc136c-e7cb-e15d-869c-a952b5b6dc31@suse.com>
Date: Mon, 14 Feb 2022 17:07:59 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH 16/16] x86/P2M: the majority for struct p2m_domain's
 fields are HVM-only
Content-Language: en-US
To: George Dunlap <George.Dunlap@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <Andrew.Cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 Roger Pau Monne <roger.pau@citrix.com>, Paul Durrant <paul@xen.org>
References: <d1fd572d-5bfe-21d8-3b50-d9b0646ce2f0@suse.com>
 <e5362b33-0f5b-ba2b-d033-ca0a09e5fd54@suse.com>
 <EFFE5241-CB1D-4173-87F9-16AC428902F7@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <EFFE5241-CB1D-4173-87F9-16AC428902F7@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM5PR0301CA0017.eurprd03.prod.outlook.com
 (2603:10a6:206:14::30) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5b00563d-0d19-4b42-8fd9-08d9efd42c9b
X-MS-TrafficTypeDiagnostic: VI1PR0402MB2926:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB29265648D52A70D8D644EA9FB3339@VI1PR0402MB2926.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Q4s7iug46xJCCkJPDNmfuGy7zQrHl24+qswpYrXYrBe3GtGMfTWR+cup+Zx3ZrJf+rGYgwEmRAbmEOfH4t+ZK3/aNVdU2Ig5Unm0Q4K7kv33KYjjz4gas7fOOSOL9WYTX2DrIMGgrHNUC9OukG243l0NGNRvQmrkQdAW9SiGsVP6dd8OKVB94ds+9iK9Vkp0oA9vCMXkM4Sctj2g/8OEkUtFFL7fgzeT5X9F1fBc0e577/U+UY7/55DsgN78VRc3Nn4RQOVQf7SUMUUCzZGxtC6yYZ/g5zWwxOCXeJz5kKDz4EPXGPG5Tqvebddxr1zaFUzHqOewriLTSkrZOiZzjR5W6hsVBHswbCdGKAICaQetlyGPpSH3AoHbOyAgFifi/tGz4JhzdHT/nDemRK1LtMSQHLq8GDZ+CxDQZiCftje27twcu/e/jPMjuVx/YBF+AHdS5JHJNhkeX0m6XGrvzboVyNJ5fNW7y85klJSDlQ7bPXJY77A+F+JGUQHiglBxjvzf/vsLTdc++d9wFC5N5wEm1OQGX3ub5PnA3G31h4M6WmRTRlkDUt0Sgp+UnQKIsXcFcBc1uH8/OSh8qe6KaALcqgjzQbvkKPVti0sg4Z7ePGqDxRlTQdurq/4bP3vY/ZL8OLRTLTq5wqc6R51jTqqYTingFOwH9iEYZQHSNqpHjlA4MB1vvVf1jClIQX8xgajdkghxOU88bSM8Y8td3MLIpOnqTBH3Jgy2ku8q0dedYj5hqmFdHW1dbOZqJMAz
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8676002)(6486002)(38100700002)(8936002)(83380400001)(5660300002)(508600001)(26005)(186003)(2616005)(6916009)(6512007)(2906002)(316002)(54906003)(86362001)(31686004)(66946007)(6506007)(36756003)(4326008)(53546011)(66476007)(66556008)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?e6Ob7s5XyPdP/npyC+X+0wJABS5MabAzI760ysF7o6XWQqJXQ1o/TvpSft+N?=
 =?us-ascii?Q?CvY+kqZIRoTociyH6s1AwACKioZeIO0aNsUIXRc6jkX2f2jDkic7fVu0pOeZ?=
 =?us-ascii?Q?T91qjkoXT/N1N9/gYMiiw+YxEG0ZR1Rw/TB3H+z4SsQr2qKidcLniUV4y6BQ?=
 =?us-ascii?Q?rzTs1ApylXpuJKz5NZN43l/XXhDGw707dAuasAe9pjzhViqVCa1FuJLLP1F6?=
 =?us-ascii?Q?Pjbo13CK7sRmsqR6QrfF01x+crPiJ15Pm4jwMcq2nZfA3vUKLxywlYkpiDNV?=
 =?us-ascii?Q?TtgZkwF2di7iRLRnqmLB/3sWqwrlc1J1Aro2xyM9dMkHwjFD4x2/fo7X9ico?=
 =?us-ascii?Q?F66IY7IDK4ZY1NMz6aH0Zzp2RmR6JbeIV1k5kkTkacii0bXL7N9DIxLvbM/N?=
 =?us-ascii?Q?HM5AsRAyaeIcts898cespI0j0gw+OsP2hPC/QLQ4h1IIgkDoT59DrZ2hhAL7?=
 =?us-ascii?Q?yEHn1pDjKKh6GPEi1K/TeUj3l6dLWCBP1iybobloof23nduI3tMP7bHxY0OQ?=
 =?us-ascii?Q?tHw3w/PUk2J8/SDvmtWY/QQMO7vg3qET42sEQ9a8E/NER2sB/7lWIZCOFOTu?=
 =?us-ascii?Q?drn9PRZHOcsLlgWGIyczdFTUC9MTqu40PxUJ2exkhS7LIpVRMHOsMEsAPvdx?=
 =?us-ascii?Q?h5GmjV3ZnQjyNctcSKWtBXat+oW5hRnhUy1fxj1GfB+yA2rTej+6UerL5Rlr?=
 =?us-ascii?Q?0ky9cS3Kz1aIvRqiIYNoQgh84x6WM17dbJUOkcYEVXYf9zf1IIZkXBDUXK+F?=
 =?us-ascii?Q?voeKo2VBeav+DYJESdqiA/GDi5dUoy5C4/iK7K0xDiLLZG1ElfSXEhfBOwsr?=
 =?us-ascii?Q?rKcJt/2rzCfbjfQsGoHtIYzY4QtDkVIwLe+iifa0axwFaOTeUsYqFtEHTUvS?=
 =?us-ascii?Q?Xo31flrImKFLQPxHbRv1JQVoMSseFlzQjouKmXBtFync6VUEtZSaVFNMZjM3?=
 =?us-ascii?Q?ELkTsJodN2quTsfxiqZBTwBHMgETFj6KyObrlXGO2aGEt5fxe4kTJ4/NH3Sl?=
 =?us-ascii?Q?0eKGCKSw8XXU45CwaXIzHFoGSbxKM5gad3AEqHO0zU2/SKSU+k19R2Kgd7C/?=
 =?us-ascii?Q?vSzGBFE5gzYf8bLaGiDrEHxxIr3/i4QDoCONbaXN0hvpG5ov0kWpXwJohyqh?=
 =?us-ascii?Q?qreo43kge/Mx4PKjAqANrbi2WgNijgFcqBaUz1kgfT74ae0RcOxcCu/9oh2B?=
 =?us-ascii?Q?yNMOAbm2pBAAXuR5UJMboWbTxgepxspFpdaXZ68Zjgz78fp048mfo8v9Lfum?=
 =?us-ascii?Q?E3lmGyJaLRLtdUl5rGSEflqByj2oDb90jwWeyrUc7Paq0AdO+Zi/QQv+iYCm?=
 =?us-ascii?Q?Pu/foIsHxggA7fQsigst+Dq3dBGzdZ8+e9wqMbfKzhRlcTRRoyavLYCqujdD?=
 =?us-ascii?Q?+Bqiu0wJ9ZWz1qBec0+bqI1ic0Lbku19kpDI3w83QMo2byIkFwE2WDT6Q/wr?=
 =?us-ascii?Q?qUuVpTJf7YcsKe1IaQwegIrevZt5D4ssheXPX5ZEMbagtBs7eBMDSf69koCl?=
 =?us-ascii?Q?RlVXM8pMLiTyYpNfDgI0W+PpqSjodbe2L79qddjLVZR1nD9zrHnT3RFvnoGx?=
 =?us-ascii?Q?Tb/JBp+qXVVUQia/gM498E+8ru3svfKfhhFWpWHqfkFFa2WjSfJnLD3oTZoA?=
 =?us-ascii?Q?alRHV6iHGyodGoIpE47ztbA=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5b00563d-0d19-4b42-8fd9-08d9efd42c9b
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2022 16:08:01.1539
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LTNH2SlG9Zk/DP510RArdBwosfr/cqdAGTA7slFLqEGqWZ9jcfrVChp/R3RyROdVJwXQGWz8Qfv3StUOV7DPpw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB2926

On 14.02.2022 16:51, George Dunlap wrote:
>=20
>=20
>> On Jul 5, 2021, at 5:15 PM, Jan Beulich <JBeulich@suse.com> wrote:
>>
>> ..., as are the majority of the locks involved. Conditionalize things
>> accordingly.
>>
>> Also adjust the ioreq field's indentation at this occasion.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>=20
> Reviewed-by: George Dunlap <george.dunlap@citrix.com>

Thanks.

> With one question=E2=80=A6
>=20
>> @@ -905,10 +917,10 @@ int p2m_altp2m_propagate_change(struct d
>> /* Set a specific p2m view visibility */
>> int p2m_set_altp2m_view_visibility(struct domain *d, unsigned int idx,
>>                                    uint8_t visible);
>> -#else
>> +#else /* CONFIG_HVM */
>> struct p2m_domain *p2m_get_altp2m(struct vcpu *v);
>> static inline void p2m_altp2m_check(struct vcpu *v, uint16_t idx) {}
>> -#endif
>> +#endif /* CONFIG_HVM */
>=20
> This is relatively minor, but what=E2=80=99s the normal for how to label =
#else macros here?  Wouldn=E2=80=99t you normally see =E2=80=9C#endif /* CO=
NFIG_HVM */=E2=80=9C and think that the immediately preceding lines are com=
piled only if CONFIG_HVM is defined?  I.e., would this be more accurate to =
write =E2=80=9C!CONFIG_HVM=E2=80=9D here?
>=20
> I realize in this case it=E2=80=99s not a big deal since the #else is jus=
t three lines above it, but since you took the time to add the comment in t=
here, it seems like it=E2=80=99s worth the time to have a quick think about=
 whether that=E2=80=99s the right thing to do.

Hmm, yes, let me make this !CONFIG_HVM. I think we're not really
consistent with this, but I agree it's more natural like you say.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 16:14:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 16:14:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272508.467380 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJdzr-0000qu-16; Mon, 14 Feb 2022 16:14:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272508.467380; Mon, 14 Feb 2022 16:14:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJdzq-0000qn-UL; Mon, 14 Feb 2022 16:14:38 +0000
Received: by outflank-mailman (input) for mailman id 272508;
 Mon, 14 Feb 2022 16:14:37 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJdzp-0000qg-SV
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 16:14:37 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 330cac24-8db1-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 17:14:36 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 330cac24-8db1-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644855276;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=6ZUhc558dYqqKBxXFYYF99xbrqlYedR5rtYnwiG/5sI=;
  b=MtUsK5zK7J7KDT5g3rrwr3PfyxS8ennmAG7ftWU5zACKqlP/1x5jWkD7
   tNvNhSoX38Hy39N/WRb0+dURpbT1NWbRGpgvbtC/wH4rX27qWMpzJL0vC
   9jEwRoWxwzVkfqQIoRaq6rwRKvpv03X6YjU76bPsm3G8POa8IJ0a1nZql
   s=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: N+hj6CHZVqAW5BVOQ5DfXGxKwOAL8RsJylwdm1VVjx5UCayWUTLQQJRgm36XLIYkkXnYR55Gil
 vowS0eVsX+3gW2Nel3riJF8BNt0BHgwo9G0p7rjZiLVL8X8eUB50dtUnkeAyavy0tQQMMcASN/
 Ohe47BySMS0jhr20Whd0P8R8GwRZbgYDIG2nTVcAEamsRUu9qbntCLp6FpElwN1slJXNdMAZuN
 eh6Z+uX1k228x6xHCIlsAFHiIxskjefHsp3/sv8A8isyHEXL5OVDuhpoEGzXqt5eHIcA8onn55
 ipPXs4cYCBSJnI8JP28MwElg
X-SBRS: 5.1
X-MesageID: 66395426
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:5GawTqrGlDXj8XB+2N24F3ew6p5eBmLMYhIvgKrLsJaIsI4StFCzt
 garIBmOaKncN2rxc9F/bo/j8B8PuMSHx9BjSAVt+H83EygW9puZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlZT4vE2xbuKU5NTsY0idfic5Dndx4f5fs7Rh2NQw24HlW1nlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCna2gRj4DJqLcpO0QWEBDOBlwOvRj+JaSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFKoZtmtt0nfyCvE+TIqYa67L+cVZzHE7gcUm8fP2O
 ZRCOGczNkqojxtnMUYsCpNmx8yRrV7wXjobiky8n5on2j2GpOB2+Oe0a4eEEjCQfu1Kmm6Iq
 2SA+H72ajk4HtGCzTuO8lq3m/TC2yj8Xeo6BLC+s/JnnlCX7mgSEwENE0u2p+GjjUyzUM4ZL
 FYbkhfCtoBrqhbtFIOkGUTl/jjU5XbwRua8DcUL+A604LLb8zqQC2NdVRV5Ztt/kc8fEGlCO
 kCyo/vlAjlmsbuwQH2b96uJoT7aBRX5PVPudgdfE1JbvoCLTJUby0uWE409SPLdYsjdRGmoq
 w1muhTSkFn6YSQj86ygtW7KjDu3znQiZl5kv16HNo5JA+4QWWJEW2BKwQWBhRqjBNzAJrVkg
 JTjs5LAhN3i9bnXyESwrBwlRdlFHcqtPjzGmkJIFJI87Tmr8HPLVdkOvG0hdBc0b55dImWBj
 KrvVeR5vsE7AZdXRfUvP9LZ5zoCkcAM6ugJptiLN4ETM/CdhSeM/T10ZF744oweuBNErE3LA
 r/CKZzEJS9DUcxPlWPqL89Age5D7n1vngv7GMGkpylLJJLDPRZ5v59eawDQBg34hYvZyDjoH
 yF3aZfblUUHCLemCsQVmKZKRW03wbEALcmeg+Rcd/KZIxogH2ckCvTLxqgmdZAjlKNQ/tokN
 FnnMqOB4Fag13DBNyuQbXVvNOHmUZpl9CppNi0wJ1e4nXMkZN/3vqsYcpI2e5gh9fBikqEoH
 6VUJZ3YD6QdUCnD9hQccYL58N5oeiO0iF/cJCGiejU+IcJtHlSb5t/+cwLz3yASFS7r59Amq
 rit21qDE5oOTghvFujMb/erww/jtHQRgrsqDUDJPsNSaAPn940zc379ifo+IsctLxTfx2TFi
 1bKUElA/eSU+t076tjEg6yAvryFKeomExoIBXTf4Ja3KTLeojipz7hfXbvaZjvaTm71pvmvP
 L0H0/HmPfQbt19WqI4gQa1zxKcz6taz9b9XygNoQCfCY1ixU+4yJ3CH2Y9Et7FXx68fsgyzA
 xrd9t5fMLSPGcXkDF9Oe1Z1MrXdjakZymvI8PA4AETm/ysmrrOIXHJbMwSIlCEAfqB+N5kow
 Lt5tcMbg+BlZsHG7jpSYvhoylmx
IronPort-HdrOrdr: A9a23:BVHqs6gHc2xKq29vpu1EtWmdCXBQX3513DAbv31ZSRFFG/FwyP
 rAoB1L73PJYWgqNU3IwerwRZVpQRvnhPtICRF4B8btYOCUghrVEGgE1/qi/9SAIVywygc578
 ldmsdFeaTN5DRB/KXHCUyDYqwdKbq8geCVbIXlvg9QpGhRAskKhWYYNu/YKDwMeOAvP+tiKH
 P23Lsim9PUQwVwUi3NPAhjYwGsnayoqLvWJTo9QzI34giHij2lrJTgFQKD4xsYWzRThZ8/7G
 nsiWXCl+aemsD+7iWZ+37Y7pxQltek4MBEHtawhs8cLSipohq0Zb5mR6aJsFkO0aOSARcR4Z
 zxSiUbToNOAkDqDyeISNzWqlDdOQMVmjvfIJmj8CPeSILCNWkH4oF69P1km1PimjQdVZdHof
 92Niuixupq5VmrplWN2/HYEx5tjUa6unwkjKoaiGFeS5IXbPtLoZUY5149KuZLIMvW0vFuLA
 BVNrCW2B+WSyLvU1nJ+m10hNC8VHU6GRmLBkAEp8yOyjBT2HR01VERysATlmoJsMtVcegJ28
 3UdqBz0L1eRM4faqxwQO8HXMusE2TIBRbBKnibL1jrHLwOf3jNt5n06rMo4/zCQu1E8LIi3J
 DaFF9Iv287fEzjTcWIwZ1Q6xjIBH6wWDz8o/surqSReoeMMoYDHRfzOmzGovHQ1Mn3WPerKM
 pbEKgmdsPeEQ==
X-IronPort-AV: E=Sophos;i="5.88,368,1635220800"; 
   d="scan'208";a="66395426"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=eNHgUAc+q7W4kG9GlbCQSXxXydMryq5a8GG2S0F9Ds/SS51iQ90U97K007cisnpBJ2bJ7uUvgylz4zARGBMORMfsW7aANMspKELoDaYSiYA7ibAQ2goc7sgBOHdyRJfkpUMcW2jM7x9GYkJFlWknAkItlja+aQLgk0N1vBSiNCBryTq2a0e3XBoauY4Lsj839Yxh7mzp9KODSCNBqGYLn7tuRm9bRRkLAyNL0OS3Mc1DymqzgBK7ajL1uGLOiAfFHOjdCtp/aZB+6UmPfLudht5h2DalcpgqfBkeHxX5FldgJN1qlhINF84U4ELqR6PsvDnyWlQyyuKQdpsnE9Fg9w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=6ZUhc558dYqqKBxXFYYF99xbrqlYedR5rtYnwiG/5sI=;
 b=M532WbzVvqnWn4jJRKPab5WRyImXCgPg3YozvXyc5sQVFtbgE5pjcp0QNpgb8XR/b++xEGPvuVsJpudL+WUPMWEs6fqlR6fluvqan5DSfRKxZssaweKxRJzXSE1D+GIes6bD6esoBW7fPVc9nti0Z/PX3MgHXNNoqorvbT6yg3IvVDx6pUZr6RAxFYWMYuYQNllHpyG3O/2v3VyMwFQrunu1i/tdmfpIixUjxOIkflcZaQxzT70ztBvPHeOUwFyPVToNIYvqx0cdiHQEgx6V904j4OJePl6As1qoZstm/sEpgzgJNPcBHIA+xWCTySoVMfHFnx5UT0E4zj5W+E8XlQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=6ZUhc558dYqqKBxXFYYF99xbrqlYedR5rtYnwiG/5sI=;
 b=xJwEk93vn8Dff3bPzqDCv9yDTLy+lhjxHe+2+yeoQyzPfcV429ltmW4BKmAG1r/6FakyLqDTRuV5rvnUibrxjQBXT9UJOZ0zyALlYAcyZUIbfaZSauZguo16xRTBWGsVp5XtcVHuP49Rxr20trUQelsxLkl9EhOak2Jvrzp4CuM=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Jan Beulich <JBeulich@suse.com>, Roger Pau Monne <roger.pau@citrix.com>,
	Wei Liu <wl@xen.org>
Subject: Re: [PATCH v2 64/70] x86: Introduce helpers/checks for endbr64
 instructions
Thread-Topic: [PATCH v2 64/70] x86: Introduce helpers/checks for endbr64
 instructions
Thread-Index: AQHYIaOdYBbjG8K/30i9NfK2lLyWE6yTOJwA
Date: Mon, 14 Feb 2022 16:14:30 +0000
Message-ID: <6a4eea6f-bd77-cb13-b476-b281b80c6413@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
 <20220214125127.17985-65-andrew.cooper3@citrix.com>
In-Reply-To: <20220214125127.17985-65-andrew.cooper3@citrix.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 7d66f5f1-ef15-473f-bdb6-08d9efd514d7
x-ms-traffictypediagnostic: MWHPR03MB2525:EE_
x-microsoft-antispam-prvs: <MWHPR03MB252578CC7C641741A46DE6FFBA339@MWHPR03MB2525.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:6108;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: D5mGcFEesY6v3ivcqx+TlA6lAAwRsacXr4pVBl2Xs0PU2wpl+LZG48PmBfhyrL2HUW+YIGc1UmfT1n6t4D6qxS5qRPt8gJ4JU66QveJ44K0hPxPgVunWRQUGBNosLmIF44/GmCl7dvqVgVhdfkYZr9jxuIYmdHhtMp/AznD4TbIn+pEyDP0XqAN0yvJrQwhC1WPLl5MkOq+UxQA6tGaxv7bmJZFe4f8S2OqA8mMdOUQeInZIVkTNqNIhUBKJDtpPj7gBn13VIsqCK+Iv/UJK99eGk5QTtOVNjpKqKDAyjpzb0OmB3yS/BED4uo61bHC/n9tbIZOsYMLhhv7z5E+WcKeoxcWfjXqy0IpAH40wq7xStgGdeve+6zFJZVhTRz4zaAQNgNxFwjCS2sVuu+tn8sgkIazF8uHiYhzwNzxnjuijPhJVtkPSHjvl/DP7ePhYHqRW2aEdv677VFlLnhDT7+tDd4HPP/oi+L+DmoYp1KYR+LNjgrMV98PvppWZqSARI23J8fovlTkpl5t++AG7HO6mORisemSCw72aQZCuMgfipMS+johueGXEZHGLIp20igdDN3fp7j8FfZC43vkFriuyBBFNTSVHKDgAqUenG1XX5AceLrAIOk10hrdyo/9L8eJLgPFDTbm8s8s8bxJPldvlpnC7u+kbM4Qg8iR5svypaRNJioEwAmoEZCTOBrq5wihOgims5kazNf5sS8wogjaHwiVJvNE0EULltdCeZHy/btg8yRFmGDRnaJt+JVMo6HchNLB0u3ioXOVbtSrkWQ==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(5660300002)(53546011)(26005)(6506007)(122000001)(36756003)(6512007)(186003)(31696002)(38100700002)(4326008)(82960400001)(86362001)(2906002)(8676002)(38070700005)(8936002)(4744005)(66476007)(508600001)(31686004)(54906003)(316002)(2616005)(91956017)(76116006)(66946007)(66556008)(64756008)(71200400001)(66446008)(6486002)(6916009)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?bURnQW9mQkhacWRRWjJ5czRVRlNRQkJ3aHVpcVNkYk12ZmdHOE5JZnpyRmFX?=
 =?utf-8?B?cElKanFYdHo3d29mYlJoWlNDTGRuWEhJV0hNQWNsZ2tXZG9jbUx3b3BJckl1?=
 =?utf-8?B?bk1keHdDTlV5cDFOOUhEWUFYbC8xcVB3ZTB6UzgvK2E2SkNIOG5sdmRzanB0?=
 =?utf-8?B?K05vVWxHd2VQMUN6Qkc1VW9NSitwWG1wWWxPWG5ITXVPd3pjYUhlajFyOWdw?=
 =?utf-8?B?ZkVDQU5KY3FQUVo1eDJFVEdKWDROcHVtU2M5bklwZHFlU2NuL2k4dGpiaHFv?=
 =?utf-8?B?cEQ3b2xHbnd1YUw5UVpzRi9rcWxZRDlIeWZlSnVEOU9TRkFlWGpLdWRydWpi?=
 =?utf-8?B?R1lZbU5tTi85L05XS2FsRzZmZUlyZVhlQ2hUdGZ6Z3hKNGxFT2VKS1BFT1gx?=
 =?utf-8?B?d0J5Vmsza094bnJKb1JCc3ZuQTNBMFl5WlZJdDJhUVUxWDlkSExQcXg5Zm4y?=
 =?utf-8?B?MDJFQlJHVWE5dzNoZGlYRVVHMEJDUS9LZ3huZGZsNjduQ0tPeFArRnVYM04r?=
 =?utf-8?B?Y1ZWanpsUnBuMUF4Vm56bXF0bFFZUGJOT003M3Z3ODcvVUZYNm11WWNTSWNF?=
 =?utf-8?B?Q3JSSWNTdDV0dGdNUW1GV0ROTTlpWUJlVDFzZlRGZWo2NXRZS0gwSFJRb2hh?=
 =?utf-8?B?bUdLVWJaU1pISGFPM0hwKzBCOS9iNys5WWNrZFJiQzFiSUg2QzJZaGQ0YWJ0?=
 =?utf-8?B?TzQxaVBDZlpkeEJ5dDh1eWhSWUxRTWk2VWg2NDdSWkRjZlk2M3BpRGROVW1J?=
 =?utf-8?B?L2t1SkNURUNFSE5MVitqOUt0MjM4T1V4ZG9NV1hOYi9OOHpvZk9VVUZRYjN6?=
 =?utf-8?B?R3d6ZExpZmJ2ZW5UOVVzaGZWWmdyZ3Y2eXQwU0xCTSt3amxHMUwxTWxreVpt?=
 =?utf-8?B?bjh4M3dGYXR3K1E3cE50SEljL0tWS1d1ODJuSjBwTTc5SGhvblVGQUlNMExk?=
 =?utf-8?B?WHFjVjQrOHBPQlBBSDg0UlZJMk1ieStpZVVpMUgzZUtuSmJUTUhoSGFQbGh5?=
 =?utf-8?B?ZzZOajhUSWNPT0JndFhCZTN6cU11YjNPaHJJYjZoQkFBcE5EM25taEhZQ2Jy?=
 =?utf-8?B?dWpkbGQyVkw3MkVvMVBGVGhwY25oYkJQMDRWbTdlRG9zNTVhaHFmL1V0Sm9M?=
 =?utf-8?B?VXBGREE1aCtsc2g0Z0d6cTdQdE9UNFhXWkpzU2RYQ1hTZnBIUityWExzYmxj?=
 =?utf-8?B?RjJsUzZTSEIvSGVkcWdSaW1BWVZENEdKQzVWN2pzaTE0RXBGTFp2a0NCTW51?=
 =?utf-8?B?QzkxZEdlR0NjUzdYY0VJUjRQV3hzSzBxZ2VVOWhxYWJqN2ZiS0xXTy9iVDFB?=
 =?utf-8?B?cDdCbWRtemlVTTZiTEloY0d3OTNpNzMvbnN3Vm9UTVhJblMrRjBNNTJKK245?=
 =?utf-8?B?T3doWGNPMXhsV3FGeDlxTmZOSjhyR0pyN2JTcmNadnpjaHhkNWlKSldlK3h5?=
 =?utf-8?B?TTNaMHFuMzBjSGhyRXNMS1RNL1lubDI5YnZ2d3B3R3hoczRXUHhhQ2R2WDlj?=
 =?utf-8?B?aHl5cUN5ZzdaZkNJMkFKcENqQ3psMGJuRndTc2JKaGp1dFMrVVliVkN5c2l4?=
 =?utf-8?B?Umg4SkNMRU1kVS85NUxTVkJqazlTd0RZL3FYblZvMEt3ckJlNk4xUCsrWlFQ?=
 =?utf-8?B?ZE1ockpmV0xUMFM0dlJPTTR2OWlVUU1rSmFNZENMZm95UU1FcEhFaVJoY1pE?=
 =?utf-8?B?eXZxeGFzWEJSRFY2QWhLc1Z1OW1hOUk2b0l0OVFWME1lSTB1Q1BVNHRWdWs0?=
 =?utf-8?B?OVlFRUFRbVlMMTZRV2JLWUxhNzZFWnhYV3lXMXpyL3J0NS8rbThvbzJIRytr?=
 =?utf-8?B?eUNnYWVic1gzN0M0NlRuRTkreENaZ2NJTWsxaE5nTjlWRndhQ1V0aE5Zancr?=
 =?utf-8?B?RXVPRHdmN1cvTElwcEF4ckJhdTh2cndJaUl4WDd0SmQwbEdUMDRscWNrQ29j?=
 =?utf-8?B?RkpTVzd2U0Z4YjFGYTc0QUFMUTI0YmFhWlk2Rm1kZzFzSkkvY3NIditZRExi?=
 =?utf-8?B?NUVJSitWdmJKdmxrOGhpdlNHdWJZd2d4cm9Gd1l6QllONjFQL09pSW5DZHhJ?=
 =?utf-8?B?UXZkYXhwU1JVV255TjAwTEFNWWVVS3ZtZmU4c1R3TGpta2prclFubWVpdGx5?=
 =?utf-8?B?NEFIeURhb1o1dk9SZjJqSEFjMEFORDh5SEpXOTkzNyt4SGtqOVdFOVBkeCtC?=
 =?utf-8?B?MC9HV1VJYTh2dWR6WmdWTjM1SVM2L0xDcVJMNzJnRW1uUFZMcXlGamxYQzRF?=
 =?utf-8?B?VUdoWkxDTlNqSXpLMnJZNTBTdzh3PT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <5513CE8F3CBE33479FB97D5FC4F4ECF9@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7d66f5f1-ef15-473f-bdb6-08d9efd514d7
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Feb 2022 16:14:30.5610
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: IciGUof1qJhQG8tKDwHClq8daQ9k0QA44Em4b6Xcf4tJ2czbFIiW6cUO4k7nU4dVTMab0AwLbUwLE+4xZfbAFbBMbfqfSFHJ0+Hgx8N8D3c=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2525
X-OriginatorOrg: citrix.com

T24gMTQvMDIvMjAyMiAxMjo1MSwgQW5kcmV3IENvb3BlciB3cm90ZToNCj4gLi4uIHRvIHByZXZl
bnQgdGhlIG9wdGltaXNlciBjcmVhdGluZyB1bnNhZmUgY29kZS4gIFNlZSB0aGUgY29kZSBjb21t
ZW50IGZvcg0KPiBmdWxsIGRldGFpbHMuDQo+DQo+IFNpZ25lZC1vZmYtYnk6IEFuZHJldyBDb29w
ZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+DQoNCkZyb20gcmV2aWV3IGluIHRoZSBmb2xs
b3ctdXAgc2VyaWVzLCBJJ3ZlIG1lcmdlZCB0aGlzIGRlbHRhOg0KDQpkaWZmIC0tZ2l0IGEveGVu
L2FyY2gveDg2L2luY2x1ZGUvYXNtL2VuZGJyLmgNCmIveGVuL2FyY2gveDg2L2luY2x1ZGUvYXNt
L2VuZGJyLmgNCmluZGV4IDZiNmY0NmFmYWYyOS4uNjA5MGFmZWIwYmQ4IDEwMDY0NA0KLS0tIGEv
eGVuL2FyY2gveDg2L2luY2x1ZGUvYXNtL2VuZGJyLmgNCisrKyBiL3hlbi9hcmNoL3g4Ni9pbmNs
dWRlL2FzbS9lbmRici5oDQpAQCAtMTksNiArMTksOCBAQA0KwqANCsKgI2luY2x1ZGUgPHhlbi90
eXBlcy5oPg0KwqANCisjZGVmaW5lIEVOREJSNjRfTEVOIDQNCisNCsKgLyoNCsKgICogSW4gc29t
ZSBjYXNlcyB3ZSBuZWVkIHRvIGluc3BlY3QvaW5zZXJ0IGVuZGJyNjQgaW5zdHJ1Y3Rpb25zLg0K
wqAgKg0KDQppbiwgdG8gcmVwbGFjZSBzb21lIHJhdyA0J3MuDQoNCn5BbmRyZXcNCg==


From xen-devel-bounces@lists.xenproject.org Mon Feb 14 16:16:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 16:16:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272515.467390 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJe1Z-0001XB-Gn; Mon, 14 Feb 2022 16:16:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272515.467390; Mon, 14 Feb 2022 16:16:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJe1Z-0001X4-Co; Mon, 14 Feb 2022 16:16:25 +0000
Received: by outflank-mailman (input) for mailman id 272515;
 Mon, 14 Feb 2022 16:16:23 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KkXt=S5=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nJe1X-0001Ww-MC
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 16:16:23 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 72fdf581-8db1-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 17:16:22 +0100 (CET)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2050.outbound.protection.outlook.com [104.47.12.50]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-37-WqMDYmapNruKcnVUGsD8Ew-1; Mon, 14 Feb 2022 17:16:20 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB3024.eurprd04.prod.outlook.com (2603:10a6:802:d::21) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.18; Mon, 14 Feb
 2022 16:16:19 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4975.015; Mon, 14 Feb 2022
 16:16:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 72fdf581-8db1-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644855381;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=xszT0i6/P2FB+LJwvdUspE1ZMOlAsz+hUdCvxvLt+E4=;
	b=abpBsh6YST9Sn3O+JHaNiyegb1z0rAgDtVQhszlGua74eewGeiL0wor1N29zYvYZ+11Uwq
	PoQqLUeanxEE2jfOKHK7UMRGKllEkicyM4QTMGe+upbwfUeZMdAKvgMppbh2Q8XVkNeRYZ
	dCYjs35KW4e+W7wd50x9TDNePMwY/lI=
X-MC-Unique: WqMDYmapNruKcnVUGsD8Ew-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=huvZy9v7JSIxPNnaq1b01CGzZjaiMxu8G1+B+LkrsCdW0rA6wqJBokrNLNz8oIkhbed8ereJimIs+htPyMjW2ija1PEvgFhOrziJ+ladwee9GPQaY05eB3LGJBqCAtEkgfO6hvbE+Q7d38cqwUOW23bG5ww2mrgijZsU0QlGVne7gBaRBZuh5bYh/lwEWBBaMOG0qpk6+N8qI4w9a49ONcXa7QoFwKGywIu5rDgyWv3/zAQACwJiIFDyv5pD90M187YP8xY/s5QiAOkMkCe7O/aH7mcU8Kmy8iDWQuolbHLJgBOA2GQ6MRH9RPf7O7xRrSu9HGJWWDzxBjPAxZrgWA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=OvZ1Hsbafmn8mdBKKTMNfbLt7J6kHZgqQ5YFa+tjGqs=;
 b=QpwhI+xPmzZn9rGkKBbmKeSsS8qSvSFOTmZUJc3wzB9Bc7+76NcccTr9pZwx+iouCcm20AMV3aeHiNTcNZ3K6X6G4ue8XvNfEJ32JhHCNXxhJRvQT7DpVG2iutO4mj1gSLwtyrwX5osfPEt2hjQHaNN7xUjZNNuIll1vpeGJMEXubI1hpUZ+NHLmikteyUsnWgu5se8oEv0f/ImA55AX78aIPA1MiGqknjDP004Qkkqzv9TcNfhRObh0ZXUt9rSEpVSJzc3w+LPBXB5La7JqKNRlgC17gpzc60P5ofDVTj6X3y5fnnhXp3kfUCGVYwtL3eJOMV7XkO3z4/RV3IsSEA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <0a50ad1c-7366-46d3-7cd3-f1d88ac31b89@suse.com>
Date: Mon, 14 Feb 2022 17:16:17 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH v2 3/7] x86/altcall: Optimise away endbr64 instruction
 where possible
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
CC: Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20220214125632.24563-1-andrew.cooper3@citrix.com>
 <20220214125632.24563-4-andrew.cooper3@citrix.com>
 <5d53c6f9-8d1a-3d48-6ea6-14a484d578a0@suse.com>
 <cc4cf340-f02f-a547-08a0-1261bb506bcf@citrix.com>
 <adbd9ee8-46c5-9696-c3eb-3e18b2d60684@suse.com>
 <c053423d-e06f-b349-34bc-9509dc44bcd7@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <c053423d-e06f-b349-34bc-9509dc44bcd7@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0318.eurprd06.prod.outlook.com
 (2603:10a6:20b:45b::18) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2c63022f-9255-4f9a-8af4-08d9efd55577
X-MS-TrafficTypeDiagnostic: VI1PR04MB3024:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB3024E90B261AAF79CDD4B442B3339@VI1PR04MB3024.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	7hXM3pIcLCQsHB75BLohA7kNda2hBvJFCM6xQntAcFgxK3Gn9YusKL82aWSA9L7W1RnkJImq1GZ30TaejGMg39BDgg+X5XgOqjohuxdHzEy0hnJjpIiP1qKfiJkxKfABVnSJc4i42UKo0OorzEyIJeT70HCzbZ8ojbbE/rpPsxrr12cRvRuK3W+0k2GivLtDzej6Nn5J32D3Wx82I/Gq45n8z+9JU6qW0oVEJ2Z5iwYXtbFKpDXgI/1lL1JeRiMenKO6VgrJP+PXXj46405hdoH0sChsFlAAM+OyXM48Duvh+/k6WT4OMMtTHJt7QM/FQmD0YxJd6wmGsA+3iWcjK9SMzKSdnxKHv4m1NEkHJ+GmYuyFzxV+7DXhm7re83x1SwYuNu81MXZN16SKOwLVsvkjikqRIg1VB645VaBQ/9fDUGKlBaxHtD9tM+5uNvpXDY4BT9e7WzvFcbOPhdAMv0SCpifTO+Q7wz+ghmfvQPCEf873Nz7nqqI1oEwk+m93uymqKS1qRtcFM1IyVdU1ay/bHpzUhOHDBzkzX56BzEYzJRkCMzl4Nh9I2BEm8V9hxu+krvUelrD2Mebdu7A3Cq7hjpN9aZ57jzmLCz6Jsx6RlaQDqIQ42sCeGP8Z4UbLw9nU/ZL+8jhC8gUcxUYy6AvtP3xR+jMOFZmIOfcvAsXTAGu6/CjbQORPmQYkKJxjZnls3tBxet/BBg82zgjhxvhyQZi39bPr8vFCieHKrmY=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6506007)(2906002)(6916009)(316002)(54906003)(38100700002)(8676002)(4326008)(66476007)(66946007)(66556008)(5660300002)(508600001)(6486002)(86362001)(6512007)(8936002)(31696002)(2616005)(31686004)(83380400001)(36756003)(26005)(186003)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?MbcNliTgYaZkUIH0fplZkp6UsfuB6sfIlIEetsM5ABgoje9fnjW5nLiF6LgB?=
 =?us-ascii?Q?V5X0C+V8uljpBguoserIUit6z6TXnHeEfPP5ipZaKUoMPEVYedfR3Ibvzu7c?=
 =?us-ascii?Q?kO8iUYSeWUwJevsv1F7RqOs7v6Sui/k5uM90ihPUbe0WRkC1Glqle9kui+SV?=
 =?us-ascii?Q?kvhVRlv4X3Vpxe6erzE7SEryDKvcjdsBg35BjmBy7o3PGACshos88TgOfWvf?=
 =?us-ascii?Q?m+xcPn2FrHITVjuUy4az4626/LmAxQjoArRQjRSSoV+82eICANbyW50I5+qA?=
 =?us-ascii?Q?WGmwXDc9xcJg5Y8kCVRMHJ2iw2qaLy2Cr9bG2UxAvh7M2P3ymE1OAcrPMTDO?=
 =?us-ascii?Q?5r9kLhEijkg6qvpwQPLIqCFCXJ4yPONV0Mx+QuZEbp9XtsUgnMESBGvmpruk?=
 =?us-ascii?Q?hsmNk57QeC4yS1s2fnKcj5JgPyDH8jjFg0wZLBLwiM03IJ7tjD8PubbTMVUd?=
 =?us-ascii?Q?ioyBdogcAGWZVolm8OBxv6O6NERWtFSxjVLodAp6HgcUolqfIJZv2Atscyhy?=
 =?us-ascii?Q?3T/1QGWyiVWPRroUf/veKsGgxr6Ra1Mm9q6yaSu71iAJNCrA2+WILx/xFYlN?=
 =?us-ascii?Q?e1mqB3lwBruKVbEqBQWNLD7Dl/0z1RFbkgNbV9XcQFEtd64aJ9UWMbglJBme?=
 =?us-ascii?Q?U3gwXM1LkxGKIggEG+KL2hFq3taZVJ+7gh5taIY0BPAKvyH4HlAFhlU/U8Dq?=
 =?us-ascii?Q?ReyPDR46JxXEI5VZgdssz96XUP3KusAGU6fLyAoXap+SK8yTA5a1OiR85XYt?=
 =?us-ascii?Q?3EjwQUVoaiUoGhimZIqLCVHFTQE6RItiQeu6gAZFn1T1sgcXGrBewCGxzZZ3?=
 =?us-ascii?Q?e8amKk6EbzlhMhQMboEp0X6OVpraR1Rgbktz29TwZmmJ7pW/tE15WzZ9FXRg?=
 =?us-ascii?Q?DJbjqiBEdUlCQyIo43LT6B9ZMpHnK+zW4NUCMwdpI159E/Ak+WT+9uGu2qY/?=
 =?us-ascii?Q?4ba3J1q3eFHIf8yLoJRYSywS6oaBlibOIrajEklo5xe5iLGpvGADrm2TnDIa?=
 =?us-ascii?Q?sKWaJcUoUTvMW2X5ow78ewjn2sTniboPEsVTkV9WFI5i2Nz3SLijdVNfXeht?=
 =?us-ascii?Q?9GfwnZG3dA46CElzuWobBqbRBbZRYI8RWw5CIk/pYRtJ/6gdoeHVZuIQ4HPw?=
 =?us-ascii?Q?KDDVl1nSrHk/j0es1nALHfIBz3CBo8pGVRl0NFwSo6/nRHHyaVp6mJQslvyr?=
 =?us-ascii?Q?eD00kv9Gsn636jZZLYJuKhipMsk+ykXx8n0TO81vbq0CwlqhoSxoDP72p3my?=
 =?us-ascii?Q?43kA0pf7fbRA3yV5+CZDlRaDnoQQDSZA0GinsKRlIvfek6JslaehtS2B6WsX?=
 =?us-ascii?Q?XuQv1pn5bRe/oszJJVmPXH863NatJDC+I8lr/JOxgPlzKDtFm3Ob5zFwF/2A?=
 =?us-ascii?Q?A8iXgz/9u48ICOb1iYWuzy8BclDkCt/T3CGlN8VDhAuhTBsIvDEYsCNWMosa?=
 =?us-ascii?Q?KSbi9mUpmk2ka6CRviTQ/xj1QoBFMJIP/3IO6upGWtMwukd13f6NxdLyf7MK?=
 =?us-ascii?Q?hlPvukD2peA0YjI+p+qa8qmMzUK2Qu0iXqqNIf0EkaguE+21ukcJLElzI57E?=
 =?us-ascii?Q?l/BTCo0E7MC15BQO/cxModbJRECQdDE6w1h2aOwgsmqsXY5L12mSmUejRjRn?=
 =?us-ascii?Q?EzfjvSe3fqjrLLCevPFvCKE=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2c63022f-9255-4f9a-8af4-08d9efd55577
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2022 16:16:19.1855
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 83TAtqv8eYc2lLDYpNfjPyMGQMCRn2CpAmaaId5UbDlVv54kHyfICJ9AN/iyMgAlTRazLGSqBXf70XeFvGfAhg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3024

On 14.02.2022 17:03, Andrew Cooper wrote:
> On 14/02/2022 13:51, Jan Beulich wrote:
>> On 14.02.2022 14:31, Andrew Cooper wrote:
>>> On 14/02/2022 13:06, Jan Beulich wrote:
>>>> On 14.02.2022 13:56, Andrew Cooper wrote:
>>>>> @@ -330,6 +333,41 @@ static void init_or_livepatch _apply_alternative=
s(struct alt_instr *start,
>>>>>          add_nops(buf + a->repl_len, total_len - a->repl_len);
>>>>>          text_poke(orig, buf, total_len);
>>>>>      }
>>>>> +
>>>>> +    /*
>>>>> +     * Clobber endbr64 instructions now that altcall has finished op=
timising
>>>>> +     * all indirect branches to direct ones.
>>>>> +     */
>>>>> +    if ( force && cpu_has_xen_ibt )
>>>>> +    {
>>>>> +        void *const *val;
>>>>> +        unsigned int clobbered =3D 0;
>>>>> +
>>>>> +        /*
>>>>> +         * This is some minor structure (ab)use.  We walk the entire=
 contents
>>>>> +         * of .init.{ro,}data.cf_clobber as if it were an array of p=
ointers.
>>>>> +         *
>>>>> +         * If the pointer points into .text, and at an endbr64 instr=
uction,
>>>>> +         * nop out the endbr64.  This causes the pointer to no longe=
r be a
>>>>> +         * legal indirect branch target under CET-IBT.  This is a
>>>>> +         * defence-in-depth measure, to reduce the options available=
 to an
>>>>> +         * adversary who has managed to hijack a function pointer.
>>>>> +         */
>>>>> +        for ( val =3D __initdata_cf_clobber_start;
>>>>> +              val < __initdata_cf_clobber_end;
>>>>> +              val++ )
>>>>> +        {
>>>>> +            void *ptr =3D *val;
>>>>> +
>>>>> +            if ( !is_kernel_text(ptr) || !is_endbr64(ptr) )
>>>>> +                continue;
>>>>> +
>>>>> +            add_nops(ptr, 4);
>>>> This literal 4 would be nice to have a #define next to where the ENDBR=
64
>>>> encoding has its central place.
>>> We don't have an encoding of ENDBR64 in a central place.
>>>
>>> The best you can probably have is
>>>
>>> #define ENDBR64_LEN 4
>>>
>>> in endbr.h ?
>> Perhaps. That's not in this series nor in staging already, so it's a lit=
tle
>> hard to check. By "central place" I really meant is_enbr64() if that's t=
he
>> only place where the encoding actually appears.
>=20
> endbr.h is the header which contains is_endbr64(), and deliberately does
> not contain the raw encoding.

Well, yes, it's intentionally the inverted encoding, but I thought
you would get the point.

>>>>> --- a/xen/arch/x86/xen.lds.S
>>>>> +++ b/xen/arch/x86/xen.lds.S
>>>>> @@ -221,6 +221,12 @@ SECTIONS
>>>>>         *(.initcall1.init)
>>>>>         __initcall_end =3D .;
>>>>> =20
>>>>> +       . =3D ALIGN(POINTER_ALIGN);
>>>>> +       __initdata_cf_clobber_start =3D .;
>>>>> +       *(.init.data.cf_clobber)
>>>>> +       *(.init.rodata.cf_clobber)
>>>>> +       __initdata_cf_clobber_end =3D .;
>>>>> +
>>>>>         *(.init.data)
>>>>>         *(.init.data.rel)
>>>>>         *(.init.data.rel.*)
>>>> With r/o data ahead and r/w data following, may I suggest to flip the
>>>> order of the two section specifiers you add?
>>> I don't follow.=C2=A0 This is all initdata which is merged together int=
o a
>>> single section.
>>>
>>> The only reason const data is split out in the first place is to appeas=
e
>>> the toolchains, not because it makes a difference.
>> It's marginal, I agree, but it would still seem more clean to me if all
>> (pseudo) r/o init data lived side by side.
>=20
> I still don't understand what you're asking.
>=20
> There is no such thing as actually read-only init data.
>=20
> Wherever the .init.rodata goes in here, it's bounded by .init.data.

Well, looking at the linker script again I notice that while r/o items
like .init.setup and .initcall*.init come first, some further ones
(.init_array etc) come quite late. Personally I'd prefer if all r/o
items sat side by side, no matter that currently we munge them all
into a single section. Then, if we decided to stop this practice, all
it would take would be to insert an output section closing and re-
opening. (Or it would have been so until now; with your addition it
wouldn't be as simple anymore anyway.)

But anyway, if at this point I still didn't get my point across, then
please leave things as you have them.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 16:39:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 16:39:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272524.467402 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJeO9-0003tT-Ag; Mon, 14 Feb 2022 16:39:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272524.467402; Mon, 14 Feb 2022 16:39:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJeO9-0003tM-7e; Mon, 14 Feb 2022 16:39:45 +0000
Received: by outflank-mailman (input) for mailman id 272524;
 Mon, 14 Feb 2022 16:39:43 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJeO7-0003tG-Dg
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 16:39:43 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b3815c81-8db4-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 17:39:40 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b3815c81-8db4-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644856780;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=TTsxX9IjVpKowN5pxW2wJvRpTcecF/0IS8QbS5eubNg=;
  b=a3NJ6E8ZRdDadm1Tao7S5fEbFxTBh93t9Z0+AEcDUBP/wT31IlFVNc1s
   HUSpPvcdNe5+TubNZbxq8gD3FoHN7JSNtRU1hsc2yiUEsyhlcFplBWMv1
   sNXjiOqoBNbvhBJRvmA2CumJNrqKJUG9N7RTTfNy/KHa47MnC5rf6mrQE
   U=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: ofsXPqblO46VrdGotSxv10KtYFzqIZJJxi2XD8ZDKELxFl/kLg5DiBmrmX4w0GeLsV11A6V6Hn
 P2JEWuFRDNmkLqG6zfCOIZkptajK/pwU2m5HrjboBmnbuydCw1ANH5UmOKElV7RMyIlkoWzb62
 IVK+kPfZXsZLipb/HAC537cctrrd0V3Acm0Gv1YHrEsTBI6E2PmnPvybr2uEmUzHgiWjvVNyFi
 nN06SKpU5vPGtQoHdytOLhcTpL4YKiP5+XLZsOrNufUmbmCZh+tRY4l/UGGktnVEiG93dvDVi1
 HiwZ5RCfQqE/pYZOHz5aziVK
X-SBRS: 5.1
X-MesageID: 66397890
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:jPHy5qL2osV6lVYgFE+RBZIlxSXFcZb7ZxGr2PjKsXjdYENSgzxTm
 mUZW2rTaK2LNzT9c4xxa4zioEJX65PVmIVnGwJlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokcxIn5BC5C5xZVG/fjgqoHUVaiUakideSc+EH170Ug6x7Zj6mJVqYPR7z2l6
 IuaT/L3YDdJ6xYsWo7Dw/vewP/HlK2aVAIw5jTSV9gS1LPtvyB94KYkDbOwNxPFrrx8RYZWc
 QphIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbrGvaUXe345iXMfwZ3u7hB3Rvdop5
 /BSpKC7YgApF7DdnekdWTdHRnQW0a1uoNcrIFC6uM2XiUbHb2Ht07NlC0Re0Y8wo7gtRzsUr
 LpBdW5LPkvra+GemdpXTsFFgMg5IdatF4QYonx6lhnSDOo8QICFSKLPjTNd9Glu3ZERTaeGD
 yYfQTNucjrtbS1dBlkWEIM6jL2Sn2DjeRQN/Tp5ooJoujOOnWSdyoPFINfTP9CHW8hRtkKZv
 X7duXT0BAkAM96SwibD9Wij7sfQmQvrVYRUE6e3ntZoilCOwm0YCDUNSEC25/K+jyaDt8l3c
 hJOvHB09O5rqRLtHoKVswCETGCs5jwWA/V1DPwG4yqKyoPJ8gOUBmIqUWsUADA5j/MeSTsv3
 16PutrmAz1zrbGYIU6gGqeoQSCaYnZMczJbDcMQZU5cuoS4/tlv5v7aZos7SMaIYsvJ9SYcK
 txghAw3nP0tgMECzM1XFniX0mv39vAlouPYjzg7v15JDCskPuZJhKTysDA3CMqsy67DEDG8U
 IAswZT20Qz3JcjleNaxaOsMBqq1wP2OLSfRh1Vid7F4qWjxpC7zIN0IuWokTKuMDirjUWW3C
 HI/RCsLvMMDVJdURfMfj32N5zQCkvG7SIWNugH8ZdtSeJlhHDJrDwk1DXN8K1vFyRB2+YlmY
 M/zWZ/1UR4yVPQ2pBLrFrx1+eJ6mUgDKZb7GMmTI+KPiuHFOhZ4iN4tbTOzUwzOxP3Y8VuFq
 44Fb6NnCXx3CYXDX8UeyqZKRXgiJnknH5Hm7ctRc++IOA19H289TfTWxNscl0ZNxsy5T8/Eo
 SOwXFF20l36iSGVIAmGcCk7OrjuQYx+vTQwOil1ZQSk3H0qYICO6qYDdsRoIel7pbI7lfMkH
 eMYf8igA+hUTmiV8ToqcpSg/pdpcw6mhFzSMnP9MiQ/ZZNpWyfA5sTgIln07CALAyfu7Zk+r
 rSs2xn1W50GQwg+Xs/aZOj2lwG6vGQHmfI0VEzNe4EBdELp+YlsCirwkv5ofJ1cdUSdnmOXj
 l/EDw0ZqO/Bp54O3OPI3a3U/Z20F+ZeH1ZBGzWJ57iBKiSHrHGoxpVNUbjUcGmFBn/04qire
 c5c0+r4bK8chF9PvodxT+RrwKY564e9rrNW1F05TnDCblDtAbJ8OHiWm8JIs/QVlLNevAK3X
 GOJ+8VbZurVaJ+0TgZJKVp3dPmH2NEVhiLWvKY8L0jN7SNq+KaKDBdJNB6WhS0BdLZ4PevJG
 wv6VBL6P+BnticXDw==
IronPort-HdrOrdr: A9a23:M/xzJaE7qbroUZvdpLqFTJHXdLJyesId70hD6qkvc3Nom52j+/
 xGws536fatskdtZJkh8erwXZVp2RvnhNBICPoqTMuftW7dySqVxeBZnMTfKljbdREWmdQtrJ
 uIH5IOa+EYSGIK9/oSgzPIU+rIouP3iJxA7N22pxwGLGFXguNbnnxE426gYxdLrWJ9dP4E/e
 +nl6x6Tk2bCBMqh6qAdxs4dtmGg+eOuIPtYBYACRJiwhKJlymU5LnzFAXd9gsCUhtUqI1Ssl
 Ttokjc3OGOovu7whjT2yv49JJNgubszdNFGYilltUVEDPxkQylDb4RGYFq/QpF5d1H2mxa1+
 UkkC1QefibLEmhJ11dlCGdnzUIFgxes0MKh2Xo2kcL6vaJOw7SQ/Ax+76xNCGptnbI9esMoJ
 6ilQiixutqJAKFkyLn69fSURZ20kKyvHo5iOYWy2dSSI0EddZq3MYiFW5uYd899RjBmcsa+S
 hVfbXhzecTdUnfY2HSv2FpztDpVnMvHg2eSkxHvsCOyTBZkH1w0kNdnaUk7zs93YN4T4MB6/
 XPM6xumr0LRsgKbbhlDONERcesEGTCTR/FLWrXK1X6E6MMPW7LtvfMkfgIzfDvfIZNwIo5mZ
 zHXl8dvWkue1j2AcnLx5FP+gClehT1Yd0s8LAp23FUgMyPeFPbC1z1dLl1qbrSnxw2OLyvZ8
 qO
X-IronPort-AV: E=Sophos;i="5.88,368,1635220800"; 
   d="scan'208";a="66397890"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=LFDt8Fmjzv7BMI5uFSOH+tMoIrYjh3lIRMUI/HslU0WdxD85shbkcc8nDOZFclGQrLVt958HZkfXRRF/wqJj/MhQo8PSUsPwJFgHo6/wzsfRJ7JIiFchVmstATqqadlHqSrME8GMzuU8mkVPZH8HK1gBnWI4wyeYtrksRmT2WWBKw8jfgSr7KxBim+M81UmzJfIOeet3oOZKajqz/tRBYAQW1EPOAeRm9SzM6j5DF+Hnd6sDjCKKiCEB9fAtMJC5uaoztCuTl6sZv1XuFk0mPPdi1o9bgqX0A/iCU4vD3ByKrKWQcAenJDvBBUvftSMV0tHToVwrkgf89rMPPNPzQA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=TTsxX9IjVpKowN5pxW2wJvRpTcecF/0IS8QbS5eubNg=;
 b=SNVdQkEvnEceukvmJ3D9/eMnbU+yGurt60cn17DE8v1qF6X9rxWSaXGaawYzZ3VTbzN5vqXP7Z4TD4e57SZ5jkAT8Fo3DuQQU99LXoso8n7T8wJuMXak/8Xyhas916w477AKsEjKDva8yrERT/l1rNCChsko1i1rxiCXJz49VTqz0814PjMdtD7JrCB7KWVQDZkQm0QF1O0YzPxjhrzMsowgKx3lvYa/2LRqohL9cVvctNDUfAYCdbRtwmxEakwiM4fLhsBn3ttNTo/zL6Ulp95Y/PW4QUTGUXxpRc9k9sIINh0Dkr71S/Bf+Y1xuX0uWN/Ltbum3Xn2fLON8gQpkQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=TTsxX9IjVpKowN5pxW2wJvRpTcecF/0IS8QbS5eubNg=;
 b=dV+Th2gFtcLL+O10lXPYWjeZ6Nvv65ywgbiLpEnjaIAZkM3/+iRd0MtCObLq8Rm4bnmB5aUPrwNasPqEUnJHNxXKVvwJdCjsd8Z3jhzMHcnDBoZsthSgzqK+aarHOUmnQ2f3Gc/Gu2DOVca4HCnQq4ikZUwXNtiCFCecM3pJ1/I=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>, Xen-devel
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2 5/7] x86/hvm: Use __initdata_cf_clobber for hvm_funcs
Thread-Topic: [PATCH v2 5/7] x86/hvm: Use __initdata_cf_clobber for hvm_funcs
Thread-Index: AQHYIaJjsOAx5ctsj06lom2YGua3HKyTBU+AgAAG24CAADN0gA==
Date: Mon, 14 Feb 2022 16:39:35 +0000
Message-ID: <73208a54-0271-9abe-9042-500d3d5d51b4@citrix.com>
References: <20220214125632.24563-1-andrew.cooper3@citrix.com>
 <20220214125632.24563-6-andrew.cooper3@citrix.com>
 <785653bd-db3a-df22-f2a0-c20b3f3bf8c1@suse.com>
 <2e28c474-6778-431a-9e40-8cc0668224c5@citrix.com>
In-Reply-To: <2e28c474-6778-431a-9e40-8cc0668224c5@citrix.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 21e63810-276c-4216-8517-08d9efd895b2
x-ms-traffictypediagnostic: DM6PR03MB4554:EE_
x-microsoft-antispam-prvs: <DM6PR03MB45546F489EF573341CBCFCF7BA339@DM6PR03MB4554.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: cUudV3tvscoXLU5Ay8ANS3qDc5AWAxD+mlMiuj63HrJwcmDSGpZsZ8Y/l+gAuQrtTfyxGUffmAqEh6Vmx69N25XaY5NE+7Pu8AhMGjuwTuRkx9mGFJ8iT/2J0jWa2qdM+tGmwvMDjM8F1DepOHwPJIvKC26TyGhSeYprU7ew0oKB5eRRa4FZl66JJvuqH6Kg5SLgh76cWw+dk1fzXecKalqkhZF81CiQul90yWJSgjA0rgYVrDzPuWPut4tL7wpNIhLm9GZ2SKoX8kCsIm7RbWhQUvg3VyGNz5V1Sk/wEGNKpwuXTyQYlixtV7rPf/cKoBPzHbpOqtvWrKfN2qqeRWkAgoHM9uBEvwF0ENGZeSRSvoCnP37eHgnukiHUAcrr3ioEQbF/Jq+AfFO2tBH692a0Ku/9/9c8EUQuqD8+ERwBJ0y2N7JXoJ0cZp8lNHj+2BcMSPNiYTUFh8lxKsNNzLAYJKBlqumQIw4MGYH8yhVTPQHvoK1C5FpwVimiPOc3v6XXmYIPv1ctn8H1Ee2mckyQcRE2GUSl/eLwPrzu2hMIa0SaKEyFWb3tzoRIcrafUoo1tG07QpFND5QCOwGUpzLeylgYINLm0qCpM4+WNhn0roG6TGWwAh6rYGa8S8YYSlvic7PAfNJzblo5YJ/GH1b7FkKXHifDnBUKVTwDeK9k2kYs8ujITJUgPPmUE4mm8XQ6kZMdHsZTuv6GGKWZAOKOh3mNZzwjWnFlfz7SaSLtdKAdb96aGsJAD/T7CYg+0XqCC0Ux2E0bHl2eWGzHKA==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(71200400001)(316002)(31696002)(86362001)(38100700002)(2616005)(6916009)(54906003)(26005)(82960400001)(53546011)(186003)(6506007)(36756003)(6512007)(83380400001)(6486002)(122000001)(76116006)(66946007)(8676002)(2906002)(66476007)(8936002)(5660300002)(66556008)(4326008)(66446008)(31686004)(64756008)(38070700005)(508600001)(91956017)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Sjd4UmR5c0s1MEdwQzZaUEp4T3JsdlV2YlhpYVQwK0d2NFNJeG4yV1pkc1Fi?=
 =?utf-8?B?dkcwNjR0enBuTXp0T04xWWFwVEh4bWxFWFE4ZkVLRFdOYnU1akdPMEFBSjJT?=
 =?utf-8?B?QzJGbklhMnB4Yy90RHpTcHorR0Q2eFdoU2h6MTBkYnZTVW1XSklZK25wSlRR?=
 =?utf-8?B?UmZHbHF1UnpNM3h5ejczSDZKMWFrelpyM0E2dzNZam13Z25uVFhBM3FpWU5z?=
 =?utf-8?B?VHFMNlF6Y1U1SU9ObU5sRzFRVFZrMzR1M2x5Q2NKNUNIeG51M1ZUY0o5VzZP?=
 =?utf-8?B?V3NQd1lYQXdlRXZEaVdwTUxQd29iUXlGUUdPY2o2QTVyb0pVRlgrSGxQbW8r?=
 =?utf-8?B?NlEzVnRRd2ZEdVpNcGZhbitzRS9FM2FOM0U4VTRDUEVaNFdNRGRoNVB0WmJX?=
 =?utf-8?B?T0U5UjJCVWJOWUl3MUJraXg0TVFqTHBqRHpnZ2xaS3BDNzRadnJ6UFV1RVhG?=
 =?utf-8?B?MTlnZ3hhaDRCb0FSS3RSaW1acWRPNyt4a2x3bG9pKzlrdUx1VTg3aFUyUWlH?=
 =?utf-8?B?cDlTeENvaWM5YzhodklhUmN6T1ZqekV3RU1iM3plSGorbjg0WC9FRGRrVUQ1?=
 =?utf-8?B?QWFUT1d4WHg5R2RPL1BvTFhzZGoyZERXSWFIQ0FtQXhMTlVFT0ZTMFN2dTc4?=
 =?utf-8?B?RTJjak9HR09sMnYxaEI2OVJzOUFzL01ZZjlKSC9NUGxONWpRMFhhNVR2b3Y5?=
 =?utf-8?B?Z3l3VVVaRHRBWkl1L1lFSGpZN25rZFV2Q21iQ0pzL1RRWlUrM1cyWFpDWWQz?=
 =?utf-8?B?VUsya25GTC9BNmJYZDg3Sm9ZVVF0Wk9pZENSUWIzancxdlZqbE9sUy9iWEtU?=
 =?utf-8?B?cHpkbkUyL2xaZHNWRmFRa0Z2Q1pINjBETW9yenUwWkZHTEF1M2dEcGtra042?=
 =?utf-8?B?V3FCK2cvL1NRV3dHUVZJL1l6VC9wdFBlblE5Y1daZlZxY1I0dGlpdWZvVUla?=
 =?utf-8?B?R2x4b0VRY3RuaXQzMmpOT2pHS0FBWWdCZGRYcE9HQVZpRmNlbXNuUkIxeVNU?=
 =?utf-8?B?WW5HdFV5ZkN0aS9nZHJVM1ptU3BXZ1BSTE5YSXFQaFNSQUZGMlUyMVNlSkF4?=
 =?utf-8?B?S25ZdlV6ZDdCbjdzOTM0YkNTbkJWMXVIY2djQ3pqWlhMbjdoTGtpbmNBaVRE?=
 =?utf-8?B?Z2JIb2ViWTk2RjY4ZkI3dEIydkYydXkyYVQ5SWxMMjAzMXVodXlSNEVERk1u?=
 =?utf-8?B?aG5JbXJaVnk1ZXdsWTFQSFNvNG43bUFWOXVQU3ZibEROUnhVUy9zOGxxMDFQ?=
 =?utf-8?B?YktXbEwwaXMvZmlPNzgwUFQzTUp2UFg3bG1MZUcyOS9GK3NZU2VuS3BhZ0g0?=
 =?utf-8?B?eW1YWnROQkNOd29VUjNJaWNVYnB2OUdQQmtjZUdpbTBsbDNneEFUY1JLSlpo?=
 =?utf-8?B?bzlXc2NuREhuZVpoMjRmOFFVTGJxRWx1MVFwdlVUb0hkTXBtUGRHOS9hbEpi?=
 =?utf-8?B?RFRYMjhpaXY5dDY5Z2Fkc25WNWhNLzhtVTB1Z0hSSUdzVG1OZUdtZjA4dURC?=
 =?utf-8?B?czZVT0JYNzZqNHQxbkttRXUyaWFhMmJyUjIrN09wd2Fia0ZqUHoydUxaRi9K?=
 =?utf-8?B?M2hUL2lJTkg1YjBMY013RVVnVWRzZHhMcTAzdWtUamFEOTVjQlNQS2RkYWJk?=
 =?utf-8?B?Tm1UQWJjNXZYNStIb0FvaWY5SlRPZ1lVMDR3VEhFWHhVSHNOcWRYbVE0cm9w?=
 =?utf-8?B?WHN3RjRSOG8raHhycTc4OEFhZGpaeko4WE12cXdHaWVWODVicEpMUEh6MjBK?=
 =?utf-8?B?RkYxYjA4UFJNUTZsYVAvTjkyc214dmFRdmxkK21JeXlaanQ4bWFNU0x6aWJx?=
 =?utf-8?B?d1FVTTZzQWJCRTBaYU5GeHdPTlg2ekJwSWpoanAvaER2cmo2Y3BrZW54bVhG?=
 =?utf-8?B?R3JJU3greDN4U1BYazB0RkdmaWI1QlA2a3BlOUpZVkdTaUtVSDZDandMdmtI?=
 =?utf-8?B?WHpqS1FQaWdxTnR1MlZMMjlmdGVwU293em40aFVmR1VPc3Y4SStOQ1ZsY3o3?=
 =?utf-8?B?Z0pUbkRKRndrejNaamJCMm9MNWNhWDNyYVhLL205WFFlRFhWbWJpbmRRTEJH?=
 =?utf-8?B?R2ZPR1hyRzBxUXZYazlVcVRDOTRPZENFU3NSeERJeGVFd3ZTT2FWTW9mZ1Zj?=
 =?utf-8?B?VmcwYkxKUUdHQ3dRd21nWHdxempGZEFUelQzM1lnd21YMHJxQnZjTXIwUjk1?=
 =?utf-8?B?S1hKaVdmSXhpc2tjT1pEK3luZEhqZjNtRU1mcXNwSWtjZ25XV0Y0VHdRU09K?=
 =?utf-8?B?ZFJlOUdFWTJsVFpEMDhlSjkyVHBRPT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <7FA0C60625C1C04484CC121B14D197E5@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 21e63810-276c-4216-8517-08d9efd895b2
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Feb 2022 16:39:35.1864
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Qnytz+WAA95ybeXF8YKbEv1QmXJO9CB8lqyiDufh00dD3G2WBbLfj28EkcxqDodCiYifhdvuB7WzDm0QYOOmwW4ttHfdMYFzDSTKqpmugwY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4554
X-OriginatorOrg: citrix.com

T24gMTQvMDIvMjAyMiAxMzozNSwgQW5kcmV3IENvb3BlciB3cm90ZToNCj4gT24gMTQvMDIvMjAy
MiAxMzoxMCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+PiBPbiAxNC4wMi4yMDIyIDEzOjU2LCBBbmRy
ZXcgQ29vcGVyIHdyb3RlOg0KPj4+IC0tLSBhL3hlbi9hcmNoL3g4Ni9odm0vaHZtLmMNCj4+PiAr
KysgYi94ZW4vYXJjaC94ODYvaHZtL2h2bS5jDQo+Pj4gQEAgLTg4LDcgKzg4LDcgQEAgdW5zaWdu
ZWQgaW50IG9wdF9odm1fZGVidWdfbGV2ZWwgX19yZWFkX21vc3RseTsNCj4+PiAgaW50ZWdlcl9w
YXJhbSgiaHZtX2RlYnVnIiwgb3B0X2h2bV9kZWJ1Z19sZXZlbCk7DQo+Pj4gICNlbmRpZg0KPj4+
ICANCj4+PiAtc3RydWN0IGh2bV9mdW5jdGlvbl90YWJsZSBodm1fZnVuY3MgX19yZWFkX21vc3Rs
eTsNCj4+PiArc3RydWN0IGh2bV9mdW5jdGlvbl90YWJsZSBfX3JvX2FmdGVyX2luaXQgaHZtX2Z1
bmNzOw0KPj4gU3RyaWN0bHkgc3BlYWtpbmcgdGhpcyBpcyBhbiB1bnJlbGF0ZWQgY2hhbmdlLiBJ
J20gZmluZSB3aXRoIGl0IGxpdmluZyBoZXJlLA0KPj4gYnV0IGhhbGYgYSBzZW50ZW5jZSB3b3Vs
ZCBiZSBuaWNlIGluIHRoZSBkZXNjcmlwdGlvbi4NCj4gSSBjb3VsZCBzcGxpdCBpdCBvdXQsIGJ1
dCB3ZSBjb3VsZCBwcm9iYWJseSBtYWtlIDIwMCBwYXRjaGVzIG9mDQo+ICJzcHJpbmtsZSBzb21l
IF9fcm9fYWZ0ZXJfaW5pdCBhcm91bmQsIG5vdyB0aGF0IGl0IGV4aXN0cyIuDQo+DQo+Pj4gLS0t
IGEveGVuL2FyY2gveDg2L2h2bS9zdm0vc3ZtLmMNCj4+PiArKysgYi94ZW4vYXJjaC94ODYvaHZt
L3N2bS9zdm0uYw0KPj4+IEBAIC0yNTEzLDcgKzI1MTMsNyBAQCBzdGF0aWMgdm9pZCBjZl9jaGVj
ayBzdm1fc2V0X3JlZyhzdHJ1Y3QgdmNwdSAqdiwgdW5zaWduZWQgaW50IHJlZywgdWludDY0X3Qg
dmFsKQ0KPj4+ICAgICAgfQ0KPj4+ICB9DQo+Pj4gIA0KPj4+IC1zdGF0aWMgc3RydWN0IGh2bV9m
dW5jdGlvbl90YWJsZSBfX2luaXRkYXRhIHN2bV9mdW5jdGlvbl90YWJsZSA9IHsNCj4+PiArc3Rh
dGljIHN0cnVjdCBodm1fZnVuY3Rpb25fdGFibGUgX19pbml0ZGF0YV9jZl9jbG9iYmVyIHN2bV9m
dW5jdGlvbl90YWJsZSA9IHsNCj4+PiAgICAgIC5uYW1lICAgICAgICAgICAgICAgICA9ICJTVk0i
LA0KPj4+ICAgICAgLmNwdV91cF9wcmVwYXJlICAgICAgID0gc3ZtX2NwdV91cF9wcmVwYXJlLA0K
Pj4+ICAgICAgLmNwdV9kZWFkICAgICAgICAgICAgID0gc3ZtX2NwdV9kZWFkLA0KPj4+IGRpZmYg
LS1naXQgYS94ZW4vYXJjaC94ODYvaHZtL3ZteC92bXguYyBiL3hlbi9hcmNoL3g4Ni9odm0vdm14
L3ZteC5jDQo+Pj4gaW5kZXggNDFkYjUzOGE5ZTNkLi43NThkZjMzMjE4ODQgMTAwNjQ0DQo+Pj4g
LS0tIGEveGVuL2FyY2gveDg2L2h2bS92bXgvdm14LmMNCj4+PiArKysgYi94ZW4vYXJjaC94ODYv
aHZtL3ZteC92bXguYw0KPj4+IEBAIC0yNDczLDcgKzI0NzMsNyBAQCBzdGF0aWMgdm9pZCBjZl9j
aGVjayB2bXhfc2V0X3JlZyhzdHJ1Y3QgdmNwdSAqdiwgdW5zaWduZWQgaW50IHJlZywgdWludDY0
X3QgdmFsKQ0KPj4+ICAgICAgdm14X3ZtY3NfZXhpdCh2KTsNCj4+PiAgfQ0KPj4+ICANCj4+PiAt
c3RhdGljIHN0cnVjdCBodm1fZnVuY3Rpb25fdGFibGUgX19pbml0ZGF0YSB2bXhfZnVuY3Rpb25f
dGFibGUgPSB7DQo+Pj4gK3N0YXRpYyBzdHJ1Y3QgaHZtX2Z1bmN0aW9uX3RhYmxlIF9faW5pdGRh
dGFfY2ZfY2xvYmJlciB2bXhfZnVuY3Rpb25fdGFibGUgPSB7DQo+Pj4gICAgICAubmFtZSAgICAg
ICAgICAgICAgICAgPSAiVk1YIiwNCj4+PiAgICAgIC5jcHVfdXBfcHJlcGFyZSAgICAgICA9IHZt
eF9jcHVfdXBfcHJlcGFyZSwNCj4+PiAgICAgIC5jcHVfZGVhZCAgICAgICAgICAgICA9IHZteF9j
cHVfZGVhZCwNCj4+IFdoaWxlIEknZCBsaWtlIHRvIHJlLXJhaXNlIG15IGNvbmNlcm4gcmVnYXJk
aW5nIHRoZSBub24tcG9pbnRlciBmaWVsZHMNCj4+IGluIHRoZXNlIHN0cnVjdHVyZSBpbnN0YW5j
ZXMgKGp1c3QgY29uc2lkZXIgYSBzZXF1ZW5jZSBvZiBlbm91Z2ggYm9vbA0KPj4gYml0ZmllbGRz
LCB3aGljaCBlZmZlY3RpdmVseSBjYW4gZXhwcmVzcyBhbnkgdmFsdWUsIGluY2x1ZGluZyBvbmVz
DQo+PiB3aGljaCB3b3VsZCBhcHBlYXIgbGlrZSBwb2ludGVycyBpbnRvIC50ZXh0KSwgc2luY2Ug
Zm9yIG5vdyBhbGwgaXMgb2theQ0KPj4gYWZhaWN0Og0KPj4gUmV2aWV3ZWQtYnk6IEphbiBCZXVs
aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gSSBzaG91bGQgcHJvYmFibHkgcHV0IHNvbWV0aGlu
ZyBpbiB0aGUgY29tbWl0IG1lc3NhZ2UgdG9vLsKgIEl0IGlzIGENCj4gdGhlb3JldGljYWwgcmlz
aywgYnV0IG5vdCAoSU1PKSBhIHByYWN0aWNhbCBvbmUuDQoNClVwZGF0ZWQgY29tbWl0IG1lc3Nh
Z2U6DQoNCng4Ni9odm06IFVzZSBfX2luaXRkYXRhX2NmX2Nsb2JiZXIgZm9yIGh2bV9mdW5jcw0K
DQpOb3cgdGhhdCBhbGwgY2FsbHMgdGhyb3VnaCBodm1fZnVuY3MgYXJlIGZ1bGx5IGFsdGNhbGwn
ZCwgaGFyZGVuIGFsbCB0aGUgc3ZtDQphbmQgdm14IGZ1bmN0aW9uIHBvaW50ZXIgdGFyZ2V0cy7C
oCBUaGlzIGRyb3BzIDEwNiBlbmRicjY0IGluc3RydWN0aW9ucy4NCg0KQ2xvYmJlcmluZyBkb2Vz
IGNvbWUgd2l0aCBhIHRoZW9yZXRpY2FsIHJpc2suwqAgVGhlIG5vbi1wb2ludGVyIGZpZWxkcyBv
Zg0Ke3N2bSx2bXh9X2Z1bmN0aW9uX3RhYmxlIGNhbiBpbiB0aGVvcnkgaGFwcGVuIHRvIGZvcm0g
YSBiaXQgcGF0dGVybg0KbWF0Y2hpbmcgYQ0KcG9pbnRlciBpbnRvIC50ZXh0IGF0IGEgbGVnYWwg
ZW5kYnI2NCBpbnN0cnVjdGlvbiwgYnV0IHRoaXMgaXMgZXhwZWN0ZWQNCnRvIGJlDQppbXBsYXVz
aWJsZSBmb3IgYW55dGhpbmcgbGlhYmxlIHRvIHBhc3MgY29kZSByZXZpZXcuDQoNCldoaWxlIGF0
IGl0LCBtb3ZlIGh2bV9mdW5jcyBpbnRvIF9fcm9fYWZ0ZXJfaW5pdCBub3cgdGhhdCB0aGlzIGV4
aXN0cy4NCg0KfkFuZHJldw0K


From xen-devel-bounces@lists.xenproject.org Mon Feb 14 16:44:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 16:44:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272533.467413 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJeSP-0005Kx-0I; Mon, 14 Feb 2022 16:44:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272533.467413; Mon, 14 Feb 2022 16:44:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJeSO-0005Kq-TF; Mon, 14 Feb 2022 16:44:08 +0000
Received: by outflank-mailman (input) for mailman id 272533;
 Mon, 14 Feb 2022 16:44:08 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KkXt=S5=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nJeSO-0005KP-3U
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 16:44:08 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 532cb538-8db5-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 17:44:06 +0100 (CET)
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur01lp2052.outbound.protection.outlook.com [104.47.0.52]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-6-7zfxyVZDPuKQ662Z7mkf5g-1; Mon, 14 Feb 2022 17:44:05 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM0PR0402MB3571.eurprd04.prod.outlook.com (2603:10a6:208:18::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.15; Mon, 14 Feb
 2022 16:44:03 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4975.015; Mon, 14 Feb 2022
 16:44:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 532cb538-8db5-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644857046;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=bff7v+lpgspQyUld7FOjCTcfFtIh5sKSqb7POcarn3g=;
	b=IsP27eCYqDR6JF+xOsUU1hxsHwBE/MT3bou1SLaakVqsDytAzxP4doozGoV2Imw4kdKbZ/
	q8uktsDdo3VpklbuqyXMpQMhjdwfrKdHOysw+LLGcJWYxF3Rg+2GsSiTsDw4xCPXufyYe4
	+W0CaIqK5Y1rN8eiNpiyMoFItFyaWB0=
X-MC-Unique: 7zfxyVZDPuKQ662Z7mkf5g-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=nCJKGAkpYL5GfMUU/ACYAY/nk4doy8FsH+Zjywfddx0fKXno8dhUFhcOTD3gTLTh6obVNg/ZFuvx8ImOrH9VQkeh9JZwJPBXUxAQyWETeJQ+ElSsYAKJhmp3iq8uTug/u1tbid1mOrJb1Y+JeRyPmnhsAnPj7ecK9PjOnJ2ROEYR0ODIb6agb6hLuldAGDavmpTOhfnytj2OIY14CTyFUAxtmVs8Lwmh9ZGvBihh0i2KVHaYw4SnvACH1KbxZgVyklw4//OzdTnsgJBtU6/b3isvZy8f/mM+WgnlLWO8KH+rayQBA3atUQMzehHNjbe1J0k7XQnyVAf24KjN5MsJjQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=bff7v+lpgspQyUld7FOjCTcfFtIh5sKSqb7POcarn3g=;
 b=DZ4v5z5eFKDOVpSnzDH7kfA9m+3vC8KLWNRMfEeRaCT1Ew2VfdGSu0k2RiEZIE74djkPYcYxMVEMQ/SGYnGhdfVvyJnNs0lbSHUSpfhgMBITNt7enXnFTZnbUYuKEkWiyDKMnT+DEmSs5X/XwtEQLWBctGKWxdg+yXVGRJsJsraqT0hV4Fln9CzUFoiWZsG1zCmlaDMtIdiDSbP8D1kJh1yRWODncVsCsgM6iTZk886xYYc26b/B30f6vMnCEO879k0rpCNxndfKZyQTL2MtY3ElN2mxYbP+l7j7bsTB+vk9YAos5R1bucFmOaRtPzgvng1pA3QZVy60sCtNzvQpWw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <63da71fb-820f-bab5-4cec-f9ec54ffbce1@suse.com>
Date: Mon, 14 Feb 2022 17:44:01 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH 3/3] amd/msr: implement VIRT_SPEC_CTRL for HVM guests
 using legacy SSBD
Content-Language: en-US
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220201164651.6369-1-roger.pau@citrix.com>
 <20220201164651.6369-4-roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220201164651.6369-4-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P195CA0099.EURP195.PROD.OUTLOOK.COM
 (2603:10a6:209:86::40) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5a8abef5-4521-4e46-b867-08d9efd9354a
X-MS-TrafficTypeDiagnostic: AM0PR0402MB3571:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR0402MB3571C6FB7777504046991725B3339@AM0PR0402MB3571.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	FVL/94z0j7/LmqwQV3nyfKgB+YxmIeBisRDozgljp0UYlNQPSi1lmzp1dEjmqHkPxYjAIA3KVxYCWZsAOo2HYXMfbGs8r86c9UQyoblsKrGIWz38M8qGsv5fSK89MFT4iWP/t7qknDaiGp2AIGXTF4o7VQE2PbO7Kjgx5hee1ptR6N4WRWqQImvm3h9cfIXvZ4uQvkH4m7GihWXjHtizyrZkQ2NhacHtLvoKJDdowDkl+/DV3QrHLLBebQvo5PT4rHZ5NK7B6PeHcuOTCCp1g1EW5bXa61qaFJnvHoIyLv+/O2HWDOpvyBq9Sz/+/xVmVsaQd5Gu6kRWMDZFpk8vIv5ZdH+dxlSxQWt76YQydgs3zIQV2z6fj9uo9ytP7CG9ck2Q0UyCqgA/58OjKbSMZvoSGDzi6miO7zQznnpkYj9tJ0ShZ6eQ+h1UI+YKLBNtndFV6gdEdRP8Gjgrt2AGuJsLWE1rTmA/d7uYzmaGJ5C2vA8alKbTP0uEgi+iTQZQR8/84qxKZuw1QsyIR8JokKOYcm4Hglt/m5Ih0CaiB2OFqFeSdE8pMfckmwwOfOSRCxZo93Vl1Vb6HFOwm7FNzUUAN1gjIFiHqRSND7IoICu8RiX7/J1hK6jpblJG41IrDuu4V9u3fddlDyU49bhlciYJM0ilWvEZozVc2C1ejpUyzGzeUQfJvryXp0khU+6MP6xEoDPtHCG9iI4mSV9OFlx7OSMJfyaQCLRPcbSED3M=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6506007)(53546011)(8936002)(83380400001)(31686004)(86362001)(36756003)(5660300002)(31696002)(2616005)(66556008)(8676002)(66946007)(6486002)(26005)(186003)(6916009)(54906003)(316002)(4326008)(6512007)(2906002)(38100700002)(508600001)(66476007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?YTlBZmN4My8zNE5FY1NRMm9vRFZHTFJSanBCTFdlMUtMZ1NPM0tLV3pLcXJW?=
 =?utf-8?B?Z1I3cStRNGhJVTgvdVpMUDVvaE5YM2JTN1B0UFZKbHdQVDB1Uy9FVHF0WHd0?=
 =?utf-8?B?cE1MMjB2bmg3YkZ6MHQ1Rk5mWGNRVW9rMktGR09LNDRPQzVSQnpMcGE2UE56?=
 =?utf-8?B?dU5pKytpdUttbXBWcFVxaHEyRlRNTENMUEt0aFNQUjQ0TVk5cUxGdHFxcGt5?=
 =?utf-8?B?aHJQbDdxMWpTT3I1bThLSVVBVmMyQjNYTWpvTjVUcEhjWE9CN0dSSmlQeVFH?=
 =?utf-8?B?YSt0anJDY3hRWWp3REhrM3dVRjJzVTRhUkQ2S1dvWVg5MDFzUmdWZndRNElO?=
 =?utf-8?B?L0pNcmpTN25CT0U4b1FzWkhFSmcvMGhpQXkzSkRFSHlqZlJnaW54VDd5Vnl3?=
 =?utf-8?B?SkVrRkU0VkJ2ZlFuVjlWcU0za1l4Z2hiNHN4UHlkand6VmFBSEJIQ1FVSUxt?=
 =?utf-8?B?SWxvM0pVUDFMZ3JSenpsQjNFVXcwR1hPdzdaMWFJSWp4ajFjTFlwODllbm9p?=
 =?utf-8?B?ci9xRThHdEljMzVQYyt1RkpkQVNEeUFvK0tQdjU2YzlhaUlFNEMrT0FUOFEx?=
 =?utf-8?B?QzJlOXBXcE1BTHN4YWJ6d0dJTTViUlErKzVUV0Jja2diUnFyd1kxbWVUU1Nl?=
 =?utf-8?B?UFFKdS82ajExOXNuVDdob25kb2JXRU5mV3lucmxIaXhzSVNQVFN6bVgxcllp?=
 =?utf-8?B?K3c2Ry95SkswaEp1YStrQkRXa2x1cVdnRzQxRlhGQzFCZ0NRRkZnSEE0Q2NN?=
 =?utf-8?B?VU1mQkczUy9tZFU3M3hvVGNKcFFJNWh6QXpJQlQ2MU5CVlpndldwTWFOaXBV?=
 =?utf-8?B?SDdsTDdOUmZCcUFsdVlJRE8vTS8wS0JTSXZxVXgySzlVNzIzYm5Yb1daT2xn?=
 =?utf-8?B?Tzc0cGVSNXhFWXZsS010Y0JTUklJTWdMOXR0RVU1eWJ5aThxNGNMTjh5VkQz?=
 =?utf-8?B?VC8vYVE0TlBQSjlzVWRVRWdtU1llb2g2RFR1Rk9CT2p2NnhmNXdUKy9uSGp4?=
 =?utf-8?B?Q3lUMy9qaTF0TnZhdEpza253dmdMa3QyLzJ2MWtvSzFCdnRZY2FYYSt1SXl4?=
 =?utf-8?B?Rk15c1BoWE9qK1hiUFVtQ1drMTZ6aEhsZ2VWc1VYMis4Q2tPN2ExVVlKODFI?=
 =?utf-8?B?cXgvK1VHZW1MZmo3M1h4S2l4NTliYzhZdlp1TGdiOXR6YVN0eUJldWd1Um5O?=
 =?utf-8?B?QjZ5SGRpaG82N1BLRVl6L3JnS2hyd3d4UWk3SCtDY3YzcUg3VnA0RmhPRmdR?=
 =?utf-8?B?TDJ2SHRwNFdYcHhBYWo0a1FSeG9pdyt4YkRFNVFuUmxyVDUwTVhGVVdYQ2FR?=
 =?utf-8?B?US9CK2ZWZUhGM2tWVStheHI1clN4aGlvTDl5NEt1VFFsbmlBeThKeUpIY29R?=
 =?utf-8?B?T285OUtKUS9wbVpJU0QyUGFKL3RIRTM0cUlpYnliMTFsdDhBQ3FoU3BvUmxU?=
 =?utf-8?B?OWJJcVJoRmwyQ2V4djVLejRJa2ZYODQvWHo1Wlo2YlpNbm9aNVg2U1lNUVY4?=
 =?utf-8?B?ZHlTQkVuNVgxTXdPV3RkeHZRZ3BBVURCMkE2dGFRY3hHc1VWN2F1NDRvbnJz?=
 =?utf-8?B?ZUMwNTM3WTBNMXJXZjVYYkdmLzU3dGIwbk0wcDAzT0JPMjA5MmgyemZRWUU3?=
 =?utf-8?B?eUYvQ2IvU1FvcDcvM1pLQWZaeHBTam1pVUJOYlFMNEVKS2VDYjdIUFhxZU8x?=
 =?utf-8?B?Rjg5cjlUSm9wTS9rOWV4Q0FOQ3JHT2JxZXRoUmhVR21RUTd2UHlpMUw4VFkx?=
 =?utf-8?B?eUlybkF5aXpBYW1ia3ZsV0krazRsbjVibHZ5eE9xS1R0Y2NVaENyZmpBMnho?=
 =?utf-8?B?a05Deks3UU9DMG9wS1ZDeFJrNkt0eVpORHZ1UFBrdHowQXYvZC81aGVNTndw?=
 =?utf-8?B?Q1A2NkE1M0x1VUVnZXAxZm5wWFNxN0prcDZyaXBmbzlMYzc1VlNxNyt1Vjl6?=
 =?utf-8?B?ZVZHQ2U4MjM1UnI5bmRkN3hKd29IdGZDeEZsNlZHRmZNTzdvaWUrRnlsQ0JR?=
 =?utf-8?B?RlpzSnZXTzVENEVzWHFHV1NNZVE0OUpZT3JvN0M1dFh4ZWFwVDZ6VkpZT2tO?=
 =?utf-8?B?LytlcUpWZWxNZHptREVDRjJMMlpxNndHbWovemhRek1va3J4dXdGaGFsdTVo?=
 =?utf-8?B?endkZWNQcjI4b24rQ1VxUVp2NmJ1cTlodWlmdHFRNjE0K2xWUWRLNG80aEpa?=
 =?utf-8?Q?KkZwmftmoYi+sFMlFzkipd8=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5a8abef5-4521-4e46-b867-08d9efd9354a
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2022 16:44:03.1760
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pFkz1k04f+5uH5m6AadDO0BG2coYBDCc3USqkRjPTedO2wwgG5P5yfAs2ALXyKm1XOU7AN5w3d4K2zQNGTKrww==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0402MB3571

On 01.02.2022 17:46, Roger Pau Monne wrote:
> @@ -716,26 +702,117 @@ void amd_init_ssbd(const struct cpuinfo_x86 *c)
>  		if (rdmsr_safe(MSR_AMD64_LS_CFG, val) ||
>  		    ({
>  			    val &= ~mask;
> -			    if (opt_ssbd)
> +			    if (enable)
>  				    val |= mask;
>  			    false;
>  		    }) ||
>  		    wrmsr_safe(MSR_AMD64_LS_CFG, val) ||
>  		    ({
>  			    rdmsrl(MSR_AMD64_LS_CFG, val);
> -			    (val & mask) != (opt_ssbd * mask);
> +			    (val & mask) != (enable * mask);
>  		    }))
>  			bit = -1;
>  	}
>  
> -	if (bit < 0)
> +	return bit >= 0;
> +}
> +
> +void amd_init_ssbd(const struct cpuinfo_x86 *c)
> +{
> +	struct cpu_info *info = get_cpu_info();
> +
> +	if (cpu_has_ssb_no)
> +		return;
> +
> +	if (cpu_has_amd_ssbd) {
> +		/* Handled by common MSR_SPEC_CTRL logic */
> +		return;
> +	}
> +
> +	if (cpu_has_virt_ssbd) {
> +		wrmsrl(MSR_VIRT_SPEC_CTRL, opt_ssbd ? SPEC_CTRL_SSBD : 0);
> +		goto out;
> +	}
> +
> +	if (!set_legacy_ssbd(c, opt_ssbd)) {
>  		printk_once(XENLOG_ERR "No SSBD controls available\n");
> +		return;
> +	}
> +
> +	if (!smp_processor_id())
> +		setup_force_cpu_cap(X86_FEATURE_LEGACY_SSBD);

I don't think you need a new feature flag here: You only ever use it
with boot_cpu_has() and there's no alternatives patching keyed to it,
so a single global flag will likely do.

>   out:
>  	info->last_spec_ctrl = info->xen_spec_ctrl = opt_ssbd ? SPEC_CTRL_SSBD
>  							      : 0;
>  }
>  
> +static struct ssbd_core {
> +    spinlock_t lock;
> +    unsigned int count;
> +} *ssbd_core;
> +static unsigned int __read_mostly ssbd_max_cores;

__ro_after_init?

> +bool __init amd_setup_legacy_ssbd(void)
> +{
> +	unsigned int i;
> +
> +	if (boot_cpu_data.x86 != 0x17 || boot_cpu_data.x86_num_siblings == 1)

Maybe better "<= 1", not the least ...

> +		return true;
> +
> +	/*
> +	 * One could be forgiven for thinking that c->x86_max_cores is the
> +	 * correct value to use here.
> +	 *
> +	 * However, that value is derived from the current configuration, and
> +	 * c->cpu_core_id is sparse on all but the top end CPUs.  Derive
> +	 * max_cpus from ApicIdCoreIdSize which will cover any sparseness.
> +	 */
> +	if (boot_cpu_data.extended_cpuid_level >= 0x80000008) {
> +		ssbd_max_cores = 1u << MASK_EXTR(cpuid_ecx(0x80000008), 0xf000);
> +		ssbd_max_cores /= boot_cpu_data.x86_num_siblings;

... because of this division. I don't know whether we're also susceptible
to this, but I've seen Linux (on top of Xen) being confused enough about
the topology related CPUID data we expose that it ended up running with
the value set to zero (and then exploding e.g. on a similar use).

> +	}
> +	if (!ssbd_max_cores)
> +		return false;
> +
> +	/* Max is two sockets for Fam17h hardware. */
> +	ssbd_core = xzalloc_array(struct ssbd_core, ssbd_max_cores * 2);
> +	if (!ssbd_core)
> +		return false;
> +
> +	for (i = 0; i < ssbd_max_cores * 2; i++) {
> +		spin_lock_init(&ssbd_core[i].lock);
> +		/* Record the current state. */
> +		ssbd_core[i].count = opt_ssbd ?
> +				     boot_cpu_data.x86_num_siblings : 0;
> +	}
> +
> +	return true;
> +}
> +
> +void amd_set_legacy_ssbd(bool enable)
> +{
> +	const struct cpuinfo_x86 *c = &current_cpu_data;
> +	struct ssbd_core *core;
> +	unsigned long flags;
> +
> +	if (c->x86 != 0x17 || c->x86_num_siblings == 1) {
> +		set_legacy_ssbd(c, enable);
> +		return;
> +	}
> +
> +	ASSERT(c->phys_proc_id < 2);
> +	ASSERT(c->cpu_core_id < ssbd_max_cores);
> +	core = &ssbd_core[c->phys_proc_id * ssbd_max_cores + c->cpu_core_id];
> +	spin_lock_irqsave(&core->lock, flags);

May I suggest a brief comment on the irqsave aspect here? Aiui when
called from vmexit_virt_spec_ctrl() while we're still in a GIF=0
section, IF is 1 and hence check_lock() would be unhappy (albeit in
a false positive way).

> +	core->count += enable ? 1 : -1;
> +	ASSERT(core->count <= c->x86_num_siblings);
> +	if ((enable  && core->count == 1) ||
> +	    (!enable && core->count == 0))

Maybe simply "if ( core->count == enable )"? Or do compilers not like
comparisons with booleans?

> --- a/xen/arch/x86/spec_ctrl.c
> +++ b/xen/arch/x86/spec_ctrl.c
> @@ -22,6 +22,7 @@
>  #include <xen/param.h>
>  #include <xen/warning.h>
>  
> +#include <asm/amd.h>
>  #include <asm/hvm/svm/svm.h>
>  #include <asm/microcode.h>
>  #include <asm/msr.h>
> @@ -1056,7 +1057,8 @@ void __init init_speculation_mitigations(void)
>              setup_force_cpu_cap(X86_FEATURE_SC_MSR_HVM);
>      }
>  
> -    if ( opt_msr_sc_hvm && cpu_has_virt_ssbd )
> +    if ( opt_msr_sc_hvm && (cpu_has_virt_ssbd ||
> +         (boot_cpu_has(X86_FEATURE_LEGACY_SSBD) && amd_setup_legacy_ssbd())) )

Nit: I think such expressions are better wrapped such that
indentation expresses the number of pending open parentheses.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 16:45:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 16:45:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272538.467424 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJeTq-0005w3-Cl; Mon, 14 Feb 2022 16:45:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272538.467424; Mon, 14 Feb 2022 16:45:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJeTq-0005vw-8u; Mon, 14 Feb 2022 16:45:38 +0000
Received: by outflank-mailman (input) for mailman id 272538;
 Mon, 14 Feb 2022 16:45:37 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=KkXt=S5=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nJeTp-0005vh-6h
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 16:45:37 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 887d9cea-8db5-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 17:45:36 +0100 (CET)
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur01lp2056.outbound.protection.outlook.com [104.47.0.56]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-16-EmjGsry6PCexD-izzAX-ow-1; Mon, 14 Feb 2022 17:45:34 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM0PR0402MB3571.eurprd04.prod.outlook.com (2603:10a6:208:18::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.15; Mon, 14 Feb
 2022 16:45:33 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4975.015; Mon, 14 Feb 2022
 16:45:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 887d9cea-8db5-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644857135;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=6A1OdROMUr8kxckkn35la8FSnSTj74Db9nH6B3R9g0o=;
	b=LTUUb7K1GI+BhV7C3zzPfUrmtTq53F7Dp5+BK3jby4bOkPsb6m82dvhc0EAaLHJ99unY0y
	vREiM3Aet/BlzmzuCuzElzJbusyJFYN7VN7eerH7BIeE3Y01Pk00rCefj0Ld5RJoN3ZLKF
	7s4T8TGcMtL0hiepe8vnH0L1Zm1jg2s=
X-MC-Unique: EmjGsry6PCexD-izzAX-ow-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=UDnye8mkd8dCGit6DGGxeLD/4j/RW3BgxVvusionCnWIOBA3lb2I48WlT/ERTDTbT2dpfHjR1YTShHZzpnQHtKjkFvIDeBWgLxRPVHEgUz9UGxflok8WEwqkualXQYOz7p6hWDJacO4gi1RIIx2zv606o2KhUKwbTeJwkvPlnyYwL1zbVE15nYA+ukJgPHM4CcjnxNEWe10iI03eYRBkxxxSeiI6nCBuY0wzY1Fb+cxGK1xBEHkHnaDKs3dmmxhvBtOicTaat+I2SryvSkZCYzKK1WRtBSWGqwInBXROniR8j6hkpZD8GDfvVifqVT/S3Qwfg5h/tm7OEzBB+yqrPg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=SBqG0o0ccUoGoRUSVbm/1h4dLPQ0BEQ75PV3ykVZmd4=;
 b=GtsZzgt9R+op3u1H08UDEnUQYlDEb+dGFnv2LLnAPPXM2tSvFYHP8HGV41+SW7mp/6JEAQljEwD3ffF0I1I9Eu9yCIgOAOA1/t0ebHYXqq9rTRoQrj0cuOsMZMePV7Ndl0/NwVxWA/IYVzxFMh3tDkIBx+WlMP/LvrMrns7dIkLWzzplhmo4mf4pNqeBgFqXhrBo2CJznUBVUlDlwXPBgqSHLBHcn6GDq80iEeKnOhS4G7Xua7G+LWIufQyIFZesIk+D9UlUH63JIvp0+m7qAtwIcdyDJNXqd52watCo8eElQhTVi5Wad1nEmhQ0yAiaLDyvZ5ZC1PylGbkIVB9OhA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <b391202c-7746-5549-6b49-1f38eb2721c4@suse.com>
Date: Mon, 14 Feb 2022 17:45:31 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH v2 5/7] x86/hvm: Use __initdata_cf_clobber for hvm_funcs
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
CC: Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20220214125632.24563-1-andrew.cooper3@citrix.com>
 <20220214125632.24563-6-andrew.cooper3@citrix.com>
 <785653bd-db3a-df22-f2a0-c20b3f3bf8c1@suse.com>
 <2e28c474-6778-431a-9e40-8cc0668224c5@citrix.com>
 <73208a54-0271-9abe-9042-500d3d5d51b4@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <73208a54-0271-9abe-9042-500d3d5d51b4@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6P192CA0100.EURP192.PROD.OUTLOOK.COM
 (2603:10a6:209:8d::41) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 929856db-6107-4442-0069-08d9efd96b09
X-MS-TrafficTypeDiagnostic: AM0PR0402MB3571:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR0402MB35714E344AA8AAF30532F97EB3339@AM0PR0402MB3571.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	2F5sQ2UXe3OpOSgV31p5Oi7cYiKXOXncpdpS7F0rzzhncBupIZBN5gfrwB3pTdc67Mgjz1dz/SnHiKEMunj3OS5JWx0ReApk8DxFQZ/grUePmYRrmPGhFEHo+sSaWIi744oEYXKdx8UMyYRWKSwoIrzZwJtWz+gM800dcuXLOffqu5QPo/+v+dPcSI8hLVglbARpFPxpXCbUfdmJ0IK+xj/n63H0u1p+/ASuhuC4igzPOZxPaI1OQAKC8be69LH0ICuSW3ny+0+Kb0lMScNJBLIfgJEr3gPAlb1THQyKtrZRhTuRWawpVTQAvSP4tQxLKKdGz1J4o5s5mqkQtpWOJfWDnRD3nebDGyhepADxa0KUtJ+ZoOh+i1fWCt0fInYVfJIauge6K5A3sgk53S0DH5qjS1z7jRrda3r+1SFY9wgtDjwTl9QxXavNczFBGm1OJz0VL8Pd/T8bVYCpT26GOcqMOZEgQcxKPwECMpOIClSlnnpbO9hYz/iVJaCQuN9267noIUMFMnhv6yclyjaFcc3Os0fNuyRDIjJEsLvHKmDtLUUDDV4l7pmYVxjQHh5LHbN1dGmJSEn2KtM9D5vPqMUdicvslAxkErfyTNxpwCWiBYgmXzdEGQ8WvFJ823PxSBw8roi2J6LarBL5zFVxhDrFIO2ssdlVg6VDhQmOTTeVOpWBcZ+Gyl+hEpcZECIPNTPCEYbWn1TvwFK/S/RYvpAnHRcOAPzLDiV6h26M+xK7YWDiT+pXej/2AQcr1gOx
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6506007)(53546011)(8936002)(83380400001)(31686004)(86362001)(36756003)(5660300002)(31696002)(2616005)(66556008)(8676002)(66946007)(6486002)(26005)(186003)(6916009)(54906003)(316002)(4326008)(6512007)(2906002)(38100700002)(508600001)(66476007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?DYbOJZY2b0yVdrd+eM+r/rw19gQs1kRw3QMqA9Zjbbg03AjyitZbbl8azErN?=
 =?us-ascii?Q?DLxM/c8C3zxiHMsjzMcpRPD8Kiqvlcma1Yx5J33j7aAmKeEndqlf6hAQ8Cg/?=
 =?us-ascii?Q?EUYeUViZODHlTBXCvFbgmY5Vz6zFgqNZ9ibOCYf4HAZxEMPQpvWr1GIaB7AZ?=
 =?us-ascii?Q?NHgz/HjBH/wjroEMuO8nxA8JCHQ1jCPBdSaHl+xPs9m+sTHQk7gHla7k4Wp0?=
 =?us-ascii?Q?FCHn9WivTODZsbuI+5MqlkT3UiCWWryhq8L4bC3rSrbgzL1QOk7oWRg1+X5b?=
 =?us-ascii?Q?VMZwvKOD/a6Z0ICmJYpgnTfP+PPraJQb67xuD2C04Zhj2Q2Pk7S3l+IZkQ3n?=
 =?us-ascii?Q?wXG0y3JP1iCQjZwIlTE8WU4V/iLXnTlYNzI60FVEl0QtdBr1OS+eDonLbBeF?=
 =?us-ascii?Q?sZu/1bkgm3og5ijtac1CkDKXi0lvs/zIelgiu3VWXlHp3C1mXMnVdtqj3vQB?=
 =?us-ascii?Q?hQDbmmuWXem0nzokpLcAlxDu+HRwEgZ88xbs718WsJrbnhPx5IKZxJnX9IvB?=
 =?us-ascii?Q?Xlg9FSSdeXNBzDCpLZfIlj2QaxZVToQnX5FitZPfx1/E3AuGVACsl2lAz5tS?=
 =?us-ascii?Q?1e6C0Eu7oYkWUoc9Clxq3BWgCSfkP0kaVIfQ70r+vH48B17ZPF5aeLDAUbmI?=
 =?us-ascii?Q?DBETFcY94uvO1mXDza2w2yimrmw0SPXfj80UgrwxJPKzkykwh7tO4kOv2jp+?=
 =?us-ascii?Q?FM+R/UkjNXpYa68V83UOAFjO5zs/Fy5/7qUWYBcazU4llfxJdIn5+i4l2VvL?=
 =?us-ascii?Q?UNfE1mysN8TnRhEtI3Ch435IdFT9r6EFDBgibw1P56Ff7mA1TxOSS7ObD3+F?=
 =?us-ascii?Q?/qyfvEceNVltE2xtrK9YwUH/4XNZRdXVPASVgt6cyWMabE3SxlyMJoBq3ekq?=
 =?us-ascii?Q?qpAZ6kO0DwWGxe/6zNFzFpQ6sVQtqWDDU3ekD+1DY7GiRtTjELRlWN/cIzcj?=
 =?us-ascii?Q?NdibKFn0KCB/anFraECVBZSzUVa5+hucKsRwNWneQdTR+UKqFobJxBKV/9FW?=
 =?us-ascii?Q?UK6JvhdNX0tlIqvmogXgfdmUUW+WkhAWG7CYN/+7V8bNgl+nN+La+PncYIjF?=
 =?us-ascii?Q?8gU9y+40Vsw2sJzxjjFHGCKDmkir7wmTU/MQbkB1wy4AJ2GpdwSJgcDuoUt4?=
 =?us-ascii?Q?Gi/ggf8mTxLzqVrEvMd5rj652djqAMdWq7bDNq7Lw5UMyk0qfnAn7MDeIlws?=
 =?us-ascii?Q?dxvOEpqtW1Y0ySdjAWEkgTsHbmhGZgKzMnxSc2qZqVoGR38Q89pBwbphYx6T?=
 =?us-ascii?Q?pDTYf1NyQiSV+ZGyOx3jigmpweaXefa0NMxhqlsmN2aWgzOQtlSqb9LqD125?=
 =?us-ascii?Q?xtb+EwHLKlnG0++7ccSxnJ8reyovD145tKnEz7Pw/OdRlxMzOih0ccEgBQBi?=
 =?us-ascii?Q?J+1k7BaiLQ0E2xhM80ER1+ZGz6O1ZzrXv0IaQPEfzzITID1tm2Vydc563ZQX?=
 =?us-ascii?Q?VunrlrY4VUX8nhd76GKrJipFjl1ACmHNAV8lJ+7y5K0bqFhFAsFIVTnECI8t?=
 =?us-ascii?Q?6OQWB81dfDM63MlDsGv+zKZKLjtNSERCjJA1c3IAFDQmNvFytzWGgb+MOP6S?=
 =?us-ascii?Q?SPMYLI1hW8oH5zHnQlYuI5BnxdZ++Jzhs9PEFaEMAkcfFj8BVf3hbAuFKNkt?=
 =?us-ascii?Q?aJnKIojSeXKD94tcJ5UNRuw=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 929856db-6107-4442-0069-08d9efd96b09
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2022 16:45:33.3423
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iEik8C4zVO+yvaQRVm5C2/GcTjiSjyDka/PpGYw4URdM7bo4ccDWbhf72l/BZ4/BWE6cJn2QBcb0zPyIYgCuDw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0402MB3571

On 14.02.2022 17:39, Andrew Cooper wrote:
> On 14/02/2022 13:35, Andrew Cooper wrote:
>> On 14/02/2022 13:10, Jan Beulich wrote:
>>> On 14.02.2022 13:56, Andrew Cooper wrote:
>>>> --- a/xen/arch/x86/hvm/hvm.c
>>>> +++ b/xen/arch/x86/hvm/hvm.c
>>>> @@ -88,7 +88,7 @@ unsigned int opt_hvm_debug_level __read_mostly;
>>>>  integer_param("hvm_debug", opt_hvm_debug_level);
>>>>  #endif
>>>> =20
>>>> -struct hvm_function_table hvm_funcs __read_mostly;
>>>> +struct hvm_function_table __ro_after_init hvm_funcs;
>>> Strictly speaking this is an unrelated change. I'm fine with it living =
here,
>>> but half a sentence would be nice in the description.
>> I could split it out, but we could probably make 200 patches of
>> "sprinkle some __ro_after_init around, now that it exists".
>>
>>>> --- a/xen/arch/x86/hvm/svm/svm.c
>>>> +++ b/xen/arch/x86/hvm/svm/svm.c
>>>> @@ -2513,7 +2513,7 @@ static void cf_check svm_set_reg(struct vcpu *v,=
 unsigned int reg, uint64_t val)
>>>>      }
>>>>  }
>>>> =20
>>>> -static struct hvm_function_table __initdata svm_function_table =3D {
>>>> +static struct hvm_function_table __initdata_cf_clobber svm_function_t=
able =3D {
>>>>      .name                 =3D "SVM",
>>>>      .cpu_up_prepare       =3D svm_cpu_up_prepare,
>>>>      .cpu_dead             =3D svm_cpu_dead,
>>>> diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c
>>>> index 41db538a9e3d..758df3321884 100644
>>>> --- a/xen/arch/x86/hvm/vmx/vmx.c
>>>> +++ b/xen/arch/x86/hvm/vmx/vmx.c
>>>> @@ -2473,7 +2473,7 @@ static void cf_check vmx_set_reg(struct vcpu *v,=
 unsigned int reg, uint64_t val)
>>>>      vmx_vmcs_exit(v);
>>>>  }
>>>> =20
>>>> -static struct hvm_function_table __initdata vmx_function_table =3D {
>>>> +static struct hvm_function_table __initdata_cf_clobber vmx_function_t=
able =3D {
>>>>      .name                 =3D "VMX",
>>>>      .cpu_up_prepare       =3D vmx_cpu_up_prepare,
>>>>      .cpu_dead             =3D vmx_cpu_dead,
>>> While I'd like to re-raise my concern regarding the non-pointer fields
>>> in these structure instances (just consider a sequence of enough bool
>>> bitfields, which effectively can express any value, including ones
>>> which would appear like pointers into .text), since for now all is okay
>>> afaict:
>>> Reviewed-by: Jan Beulich <jbeulich@suse.com>
>> I should probably put something in the commit message too.=C2=A0 It is a
>> theoretical risk, but not (IMO) a practical one.
>=20
> Updated commit message:
>=20
> x86/hvm: Use __initdata_cf_clobber for hvm_funcs
>=20
> Now that all calls through hvm_funcs are fully altcall'd, harden all the =
svm
> and vmx function pointer targets.=C2=A0 This drops 106 endbr64 instructio=
ns.
>=20
> Clobbering does come with a theoretical risk.=C2=A0 The non-pointer field=
s of
> {svm,vmx}_function_table can in theory happen to form a bit pattern
> matching a
> pointer into .text at a legal endbr64 instruction, but this is expected
> to be
> implausible for anything liable to pass code review.
>=20
> While at it, move hvm_funcs into __ro_after_init now that this exists.

SGTM, thanks.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 16:54:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 16:54:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272547.467435 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJec3-0007Mv-1z; Mon, 14 Feb 2022 16:54:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272547.467435; Mon, 14 Feb 2022 16:54:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJec2-0007Mo-VC; Mon, 14 Feb 2022 16:54:06 +0000
Received: by outflank-mailman (input) for mailman id 272547;
 Mon, 14 Feb 2022 16:54:05 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=jv2p=S5=cantab.net=dvrabel@srs-se1.protection.inumbo.net>)
 id 1nJec1-0007Mi-JE
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 16:54:05 +0000
Received: from smarthost01b.sbp.mail.zen.net.uk
 (smarthost01b.sbp.mail.zen.net.uk [212.23.1.3])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b70914ee-8db6-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 17:54:04 +0100 (CET)
Received: from [82.70.146.41] (helo=pear.davidvrabel.org.uk)
 by smarthost01b.sbp.mail.zen.net.uk with esmtps
 (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1)
 (envelope-from <dvrabel@cantab.net>)
 id 1nJebz-0001CO-A7; Mon, 14 Feb 2022 16:54:03 +0000
Received: from apple.davidvrabel.org.uk ([82.70.146.43])
 by pear.davidvrabel.org.uk with esmtp (Exim 4.92)
 (envelope-from <dvrabel@cantab.net>)
 id 1nJebq-0003SX-V9; Mon, 14 Feb 2022 16:54:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b70914ee-8db6-11ec-b215-9bbe72dcb22c
Message-ID: <71b7ebd1-5cc8-54f4-f45d-5da71f2298f6@cantab.net>
Date: Mon, 14 Feb 2022 16:53:56 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Content-Language: en-GB
To: Andrew Cooper <andrew.cooper3@citrix.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
 <20220214125127.17985-22-andrew.cooper3@citrix.com>
From: David Vrabel <dvrabel@cantab.net>
In-Reply-To: <20220214125127.17985-22-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-SA-Exim-Connect-IP: 82.70.146.43
X-SA-Exim-Mail-From: dvrabel@cantab.net
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
	pear.davidvrabel.org.uk
X-Spam-Level: 
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,SPF_SOFTFAIL
	autolearn=no autolearn_force=no version=3.4.2
Subject: Re: [PATCH v2 21/70] xen/evtchn: CFI hardening
X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000)
X-SA-Exim-Scanned: Yes (on pear.davidvrabel.org.uk)
X-Originating-smarthost01b-IP: [82.70.146.41]
Feedback-ID: 82.70.146.41

On 14/02/2022 12:50, Andrew Cooper wrote:
> Control Flow Integrity schemes use toolchain and optionally hardware support
> to help protect against call/jump/return oriented programming attacks.
> 
> Use cf_check to annotate function pointer targets for the toolchain.
[...]
> -static void evtchn_2l_set_pending(struct vcpu *v, struct evtchn *evtchn)
> +static void cf_check evtchn_2l_set_pending(
> +    struct vcpu *v, struct evtchn *evtchn)

Why manually annotate functions instead of getting the compiler to 
automatically work it out?

David


From xen-devel-bounces@lists.xenproject.org Mon Feb 14 16:59:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 16:59:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272556.467445 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJeh6-00085w-PF; Mon, 14 Feb 2022 16:59:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272556.467445; Mon, 14 Feb 2022 16:59:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJeh6-00085p-MS; Mon, 14 Feb 2022 16:59:20 +0000
Received: by outflank-mailman (input) for mailman id 272556;
 Mon, 14 Feb 2022 16:59:18 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=R+2O=S5=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1nJeh4-00085i-O0
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 16:59:18 +0000
Received: from ppsw-40.csi.cam.ac.uk (ppsw-40.csi.cam.ac.uk [131.111.8.140])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 715a940a-8db7-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 17:59:16 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:54906)
 by ppsw-40.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.138]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1nJeh0-000KBC-jA (Exim 4.95) (return-path <amc96@srcf.net>);
 Mon, 14 Feb 2022 16:59:14 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id D25391FB34;
 Mon, 14 Feb 2022 16:59:13 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 715a940a-8db7-11ec-b215-9bbe72dcb22c
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <5295e10c-d145-b6e3-d9a9-d345dc6cc93e@srcf.net>
Date: Mon, 14 Feb 2022 16:59:13 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH v2 21/70] xen/evtchn: CFI hardening
Content-Language: en-GB
To: David Vrabel <dvrabel@cantab.net>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
 <20220214125127.17985-22-andrew.cooper3@citrix.com>
 <71b7ebd1-5cc8-54f4-f45d-5da71f2298f6@cantab.net>
From: Andrew Cooper <amc96@srcf.net>
In-Reply-To: <71b7ebd1-5cc8-54f4-f45d-5da71f2298f6@cantab.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 14/02/2022 16:53, David Vrabel wrote:
> On 14/02/2022 12:50, Andrew Cooper wrote:
>> Control Flow Integrity schemes use toolchain and optionally hardware
>> support
>> to help protect against call/jump/return oriented programming attacks.
>>
>> Use cf_check to annotate function pointer targets for the toolchain.
> [...]
>> -static void evtchn_2l_set_pending(struct vcpu *v, struct evtchn
>> *evtchn)
>> +static void cf_check evtchn_2l_set_pending(
>> +    struct vcpu *v, struct evtchn *evtchn)
>
> Why manually annotate functions instead of getting the compiler to
> automatically work it out?

Because the compilers are not currently capable of working it out
automatically.

~Andrew


From xen-devel-bounces@lists.xenproject.org Mon Feb 14 17:10:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 17:10:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272565.467457 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJerP-0001AW-SP; Mon, 14 Feb 2022 17:09:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272565.467457; Mon, 14 Feb 2022 17:09:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJerP-0001AP-OI; Mon, 14 Feb 2022 17:09:59 +0000
Received: by outflank-mailman (input) for mailman id 272565;
 Mon, 14 Feb 2022 17:09:58 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5JaK=S5=citrix.com=Jane.Malalane@srs-se1.protection.inumbo.net>)
 id 1nJerN-0001AJ-Nh
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 17:09:57 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id eda4c854-8db8-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 18:09:55 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: eda4c854-8db8-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644858595;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=6mBhT/QHqsrJau3daLLYBELJyyfB2AO7EiWvjjjskAo=;
  b=A/mxqXfGACWZt6tLVRAmjwb0oZ0SMT6RCT+STG/2e5c3zX/EEZkSxv/H
   t21f5XE9y01ZM4cqGOU2OwyXThnz5L7DtFkCCzTgQus/ZEZD6yY8NPrDf
   ycfS+RvUebIxMQmef1AFVpDpwm3MMnp102zqNMkEOr1lYLRnppPbbkBJd
   E=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: 8zTy8LQrqf3VLyyxjyEMmTin4I8FVSJ6qiJS7LgAGz9hIMlvL4V0I2EGzYNK4FfswPv6Kjr7jM
 w5wQNha/tspL6xZSTS0GM0ZU6bNukWAPRWMH2G8kLW+eUaq6JjKLbeP1MBnODku+pD0svANOHH
 aju69g67oHgYK+gNwnlNN6sKd+U36rPRBvwdYPcdmIU8nP5GH9zN8OyqSxeWbbaXROX0OkD0DH
 QohWHFo1KJruB3DJnsTXI/Pg+NQAWQ8RQk1tlyDFHLXshF7UknMRDoEQgmGLNMthgWGdfkJ16v
 +SVcusWISyx4KYR+xH0rym5c
X-SBRS: 5.1
X-MesageID: 64175853
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:wGVF9KO6i1F9U/nvrR3MkcFynXyQoLVcMsEvi/4bfWQNrUor0zQCz
 zNNXWuFaa2MM2SjfN53aN6w8htQ7ZTVytUxQQto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6UUsxNbVU8En1500s/w7RRbrNA2rBVPSvc4
 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq
 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYoxqSouhf2
 dlVjK65ZT0nYYiLuacfUwYNRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs
 6VFdnZdNXhvhMrvqF6/YstlgMllCcDvNYcWvHxIxjDFF/c2B5vERs0m4PcGgG5v25ATRp4yY
 eIpcRhoNlfLTSZkN3UnEJZkkfqWl2fgJmgwRFW9+vNsvjm7IBZK+IbqNN3Za9mbX/J/l0yTp
 n/F12nhCxRcP9uaoRKe6W6ljOLLmSL9WaoRGae++/osh0ecrkQZBQcKT1K9rb+8g1SnRtNEA
 0UO/2wlqq1a3E+mUNj7GQG5qXisvxgAVt4WGOo/gCmP16yS5Q+aD2oFSzdpado6uctwTjsvv
 neZktWsCTFxvbm9TXOG6qzSvT60ITISL2IJeWkDVwRty9vprZw3jxnPZs1+C6PzhdrwcRnvx
 xiaoS54gK8c5eYJyqG68Fbvkz+q4J/TQWYd5ArNWXm+xhhkf4PjbIutgWU39t4ZctzfFAPY+
 iFZxY7Ot4jiEK1higSiW9g1MqCl/8+3ORHmjwFKWLhi9TSyrivLkZ9r3BlyI0JgM8AhcDDvY
 VPOtQ452KK/LEdGfocsPdvvVp1CIbzIUI28C6uKNoYmjo1ZKVfflByCc3J8yIwEfKIEtagkc
 amWfs+3ZZrxIfQ2lWHmLwvxPFJC+8zf+Y8xbc2hp/hE+eDHDJJwdVviGAHQBt3VFIve/G3oH
 y93bqNmMSl3XuzkeTXw+oUON10MJnVTLcmo95AIJr7ef1I/QztJ5xrtLVQJIdINokiovr2Qo
 iHVtrFwlDITekEr2S3VMys+OdsDrL50rG4hPDxEALpb8yNLXGpb149GL8FfVeB+rIRLlKcoJ
 9FYK5ToKqkeEVzvpmVCBaQRWaQ/LXxHcyrVZHH7CNX+FrY9LzH0FijMIFexqnlUU3bfWAlXi
 +TI6z43iKErHmxKJM3XdOiu3xW2u30ck/h1REzGPp9Yf0CEzWSgA3aZYiYfL55eJBPd6CGd0
 grKUx4UqfOU+90+8cXThLDCpICsSrMsEk1fFmjdzLC3KSiFoTbznd4eCL6FLWLHSWf52KS+f
 uEJnfvyB+IKwQRRuI1mHrc1ka9nv4nzp6VXxxhPFWnQawj5EatpJ3SLhJEdtqBEyrJDlxGxX
 0aDpotTNbmTYZu3G18NPgs1KO+E0KhMyDXV6P00JmT85TN2o+XbARkDYUHUhXUEfrVvMY4jz
 eMwg+Is6lSy2kgwL9KLriFI7GDQfHYOZLoq68MBC4jxhwt1llwbOc7ACjX76Y2kYslXNhV4O
 SedgafPiugOxkfGdHZvR3HB0fAE2MYLsRFOilQDO06IipzOgfpuhE9d9jE+TwJ0yBRb0r0sZ
 jg3ZhMtfajerS11gMVjXny3H1ATDRKUzUX91l8VmTCLVEKvTGHMcDUwNOvlEJr1KI6Akuy3J
 I2l9Vs=
IronPort-HdrOrdr: A9a23:Deylc6+/AUy76/sGf9huk+F7db1zdoMgy1knxilNoENuHfBwxv
 rDoB1E73LJYW4qKQwdcdDpAtjkfZtFnaQFr7X5To3SIDUO31HYbb2KjLGSjAEIfheRygcz79
 YYT0ETMqySMbE+t7eB3ODaKadh/DDkytHRuQ629R4EJmsKC52IrT0JcTpzencGHjWubqBJcK
 Z0k/A3wQZIDk5nCfhTaEN1PdTrlpnurtbLcBQGDxko5E2lljWz8oP3FBCew1M3Ty5P6a1Kyx
 mHryXJooGY992rwB7V0GHeq75MnsH699dFDMuQzuAINzTXjBqybogJYczBgNl1mpDr1L8Zqq
 iKn/4SBbU015oXRBDtnfLZ4Xil7N/p0Q679bbXuwq5nSWzfkNENyMIv/MmTvKe0Tt8gDg06t
 M740uJ85VQFh/OhyL7+pzBUAxrjFO9pT44nfcUlGE3a/pVVFb/l/1rwKp5KuZJIMvB0vFtLA
 CuNrCp2N9GNVeBK3zJtGhmx9KhGnw1AxedW0AH/siYySJfknx1x1YRgJV3pAZNyLstD51fo+
 jUOKVhk79DCscQcKJmHe8EBc+6EHbETx7AOH+bZV7nCKYEMXTQrIOf2sR52Mi6PJgTiJcikp
 XIV11V8WY0ZkL1EMWLmIZG9xjcKV/NFAgFCvsukaSRloeMN4YDABfzP2zGyfHQ08n3KverKc
 qOBA==
X-IronPort-AV: E=Sophos;i="5.88,368,1635220800"; 
   d="scan'208";a="64175853"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Ya113249/637716lcJDH3T/wygO/R2LJ2yJ2lIPoaGP6pvDlHun1akfXjuwGbakKMj0KzPv7Ib1xxPFySWxoXPivCqTo5Uqim+H2yjcOor2tW4wvGJ3uM/+z+brhNxeRA+zDig1ZY6+6Lg6c4ve+lgkirBAdl5xa/w+J2FXTUh8a86BGmenKZmQPHot/QCDRyWR+cTQJQd3bgSJqmDEqTwp4uHM4dMnXM46ABAS0r4OvWbk4YhDJkBM1prpHpnWZPg3JcEYguy46QfrX8dBU/RjnSK3SDnkUkGrPUfKYoe4COeuLABVgilvB/sXqAFqPnEUN2q1PmbIEOk903wWSzg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=6mBhT/QHqsrJau3daLLYBELJyyfB2AO7EiWvjjjskAo=;
 b=YlOAVX1ZvlJ9TecUXbSwcqzsfesi26v7wlKgH7kSmkS186zWS1usCuL5AO+SkZXG5Gzu2Kk1okX3nMfnZeTHTrB21mjQl+tqsZ6Nbk3GX8M4uwPrZexqxxaD5zAhojV9kZjv5FR/qkqVTPcgi/agk0zyHHDKqiw6K6lNdytMZNsdgGOpwBkjOYIiLxQ+dj4QChK/9X3Eh0B+lLBrn4GbuWG9xFgamo5NuItm046qGzsFhIY5NCFXWYhLMV1EvSj33ofiZtiMv9lo1Sjc3xT5nuIuqb5D+Y0HAf7TiGrii612bi+5VK6XzuRDdKU2HRdiefy1rgYdAYm1MkpuEDeTCw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=6mBhT/QHqsrJau3daLLYBELJyyfB2AO7EiWvjjjskAo=;
 b=gJM5I9i9wP+AazIgLKNBjKDWtjZMgVmdxY4abhKLAoVR2fyjQh96ar1BYZ/8PzWIgaqqYodsWWpzUhxe9hykfPnMH4+NuxKWQ+uS4ck+wmlktM7Wx3b78sZAJ8WFwgHJ1zsMSwHOGGM3vP4fj9ElBbOfWmnglhqugFg9kpBlSsA=
From: Jane Malalane <Jane.Malalane@citrix.com>
To: Jan Beulich <jbeulich@suse.com>, Roger Pau Monne <roger.pau@citrix.com>,
	Andrew Cooper <Andrew.Cooper3@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>, "Anthony
 Perard" <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, "George
 Dunlap" <George.Dunlap@citrix.com>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>,
	Jun Nakajima <jun.nakajima@intel.com>, Kevin Tian <kevin.tian@intel.com>,
	Andrew Cooper <Andrew.Cooper3@citrix.com>, Roger Pau Monne
	<roger.pau@citrix.com>
Subject: Re: [PATCH v2 1/2] xen+tools: Report Interrupt Controller
 Virtualization capabilities on x86
Thread-Topic: [PATCH v2 1/2] xen+tools: Report Interrupt Controller
 Virtualization capabilities on x86
Thread-Index: AQHYHE+TdJl64aH33EedeR0PZ4zblKyMkj6AgAGTLwCAABdDgIAABJKAgATOw4CAAAIAAIAAQJgA
Date: Mon, 14 Feb 2022 17:09:49 +0000
Message-ID: <1bac0507-9420-f0b9-f846-f1c73bf9678d@citrix.com>
References: <20220207182101.31941-1-jane.malalane@citrix.com>
 <20220207182101.31941-2-jane.malalane@citrix.com>
 <YgTi6bzeojtcu0xL@Air-de-Roger>
 <dff9c5c0-7bee-ce0d-3288-91255a701c99@citrix.com>
 <YgZIo9VQktcqGHTD@Air-de-Roger>
 <6d924061-f2fd-5f3d-0f98-79e76398b908@suse.com>
 <6c9400b8-7c76-34c8-f69e-3fad1eb53b8c@citrix.com>
 <101b0950-b7f2-119b-b654-574a71cec3bc@suse.com>
In-Reply-To: <101b0950-b7f2-119b-b654-574a71cec3bc@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 041e4341-9f6b-4320-f096-08d9efdccf6a
x-ms-traffictypediagnostic: SA1PR03MB6609:EE_
x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
x-microsoft-antispam-prvs: <SA1PR03MB660916B48251B3C175585EBD81339@SA1PR03MB6609.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: goc0RZG20J8GPxDPgBAkfjjWF5f1rKMsqMaOUwyT2QzIKSV+HG4rvspyDd4gH4fGN5BDfcmf9YbGK2JeXIJDQSOuechsekzaoKk6ioKBb7OTeMHjYJA89NgN6+05W5OrTJajaFJ2gNRAbUr+2U9hzYF7uWba80WQqfPqk9MEyH9dfgDJky2jF1bt1TpzcH8EiUI6jY9f4Wm8lZioLjVyfpHf29cUOQzMBpVaClgcumcYsX2PCqaPi7eK82F/4H6tlzBqCp+cDSSbT7YQSXUGiYwTSW3QXzrqiABumLjCE8uZZeChm1eoUFYjVvC7RnrXC5wcqa4th7lfkPKSKH1Idi2t3jxC2IWtltjpYJTWPu38z89t6UISRb1jHZdI4guaBL2ZJDHXeARVDHLeEvysyeQgbLnZNik15jwGH6KpdhN8ZxgWh8o/LTC6LXW0Qf07A8FOOQe05kkdhxvVcDk5R6bq4mvS5Ts4l+2NDdZTvSNxUYeFkcBnQs9x73++i29xTSdZBLNC93JjCaAyy5vd/+rybuFnNYxA59ad7qrWUUQ7WSd317iKeYnMtnO7JpX/1uz6nwZkwlf3AQNofd6lpQiZ+fjrOIIWgXZtW18Ptz5omv1pEK36H7cVT2Zq/cNh8Xag3CbaqqWQmbA53j7fxHehUDs0IRY4oAKXLzodVJpFWbKU7pRabsiXj4Bi09FWozATp7a1goRA6bVPAINzqxcS6tX7cnE04vMsGVfIpZqAG4dnPn7TP9xn1TukI/2j
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR03MB3386.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(110136005)(6636002)(54906003)(38070700005)(316002)(76116006)(8936002)(66946007)(66476007)(66446008)(64756008)(86362001)(66556008)(8676002)(4326008)(38100700002)(91956017)(26005)(107886003)(53546011)(6506007)(31696002)(2616005)(6512007)(122000001)(186003)(82960400001)(508600001)(2906002)(6486002)(71200400001)(83380400001)(36756003)(31686004)(7416002)(5660300002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?amtMOThmaUxtaTVhT0ZzdUJCeXhtRnRhSDB5RTZDUHhxbDd0NnVyaEhQR0dT?=
 =?utf-8?B?UVJvVGVsRnpwVmVLbnE2NVpNSDhEb2JyL0VpRHJxOXFJYzNreVNMWFY5SXNz?=
 =?utf-8?B?Wkhha1Q4RWpNdStRcEVCZGw4R2ovMjhoMS9TeVNEY1ZDeEFHMjVuNDd6RE5N?=
 =?utf-8?B?SUxocDI4VWptYWl6NndtUmZEUlN6eGc0bzVEdDdEZUxyN1ZzdVVSNTdrNzNk?=
 =?utf-8?B?MzdzcHQzZzU0MktQeWNyN0FILzRnQlZXaEw1K1pGVW8vWTBvcHhkd29jZzVW?=
 =?utf-8?B?VnV1Ky9oTDhlSHFReHFTb3NrWitMcVhVakRLWDVBbi9WU01wcXkzNS83VFN5?=
 =?utf-8?B?TlRFYXJDNzNEWkZ0TnNCSHpzRmpxamlaNnQ1VWxSQXlJTExnenZTSloxSWI1?=
 =?utf-8?B?eGQzS2U0Q1lhbnRQU0RzY29wbVpPTWRWMjd5T0FNRnZVMmRRdkhncTJLVWhC?=
 =?utf-8?B?OVVzaCtYeEpRamJ0M3FuWFlJdks2ZzVyenUrSGpQZ1o3bTJ5SnVTMEh1UFlD?=
 =?utf-8?B?b1ZmWC83Uyt4b3o0UmxlVWJSS2N1RFlYbm1aUXBQTW5SenVoRFlRdXl6OC9H?=
 =?utf-8?B?RGt2RUs3T0dKMHRWRVJWeWg1cmlMeDM2aXZXaTZoVHFFdHo1KzBOZFlWQmR2?=
 =?utf-8?B?eXF2dUxQUmVvZHRzd2s0M3B3cEJaSUFUd3J1cnVDREovSUFkeGNIMFo1S3Vn?=
 =?utf-8?B?VVhiRGdyOU1SUU5veUdmYUk3VVBHNHkxQW1RWjV2WVFWNUFTT2ltYUR0d2x5?=
 =?utf-8?B?UlFzSXVjTXpIay9Ccm9lTFVaNWxBL2pzclBGQ3gzMC9JdzFDbzRHbkdOS1Av?=
 =?utf-8?B?eTFOc0NLNGNjOS9yeHBzcGhPcDhUdWVpTk1hRDMybDlWQng2QkZoUi8reU10?=
 =?utf-8?B?eVJhT1JISUJWQkR4b0VyQmhqK0Q0dFdnSmJwQkpCWlp1Z1Z4RTB6UHl1bytB?=
 =?utf-8?B?d1ZSSEdTTnNhdXpXc2VKaTV2alJ1RTA1bVFPZERJb3U3cE9iVnhNYmF0MUx6?=
 =?utf-8?B?VHlycjZiSm9LRytNL3BBeDZvdW16TmJhUUNMS0c1WktzczdSUW5wSzNNRnpk?=
 =?utf-8?B?ZnR2VjBXTGFzSWRRK1FpTXRPSUpTc3hyeWtob3RVRFdSaHBkUnNVTTZPNGNh?=
 =?utf-8?B?VnBXVUhUTWtVZmZMdU9mUDhnU2pYY0RQb0IyaTV2RFZldlNuYUJJeXFVWG13?=
 =?utf-8?B?bXRzTTJrV2ExTWkwUUxDSlowRldFRWlzTldvbEVCZ2YwejZJR2FTTTh3dWlK?=
 =?utf-8?B?VmNDS09SSlMwdFNTVXBzako2VEZpVlhDZHFLRnVSRE45YnBlalpSYnl0aUta?=
 =?utf-8?B?R3BGK2tEZ2hmSEVGTFljZDQyRWp4MTBnODZMY2JVaFhHQ0ovc3BxNjk4bUhS?=
 =?utf-8?B?YXQwdmVOVU81NXJsaElUeitrZTVhcWExV1JsZWZJK1FkY3Uxb2g2YnJhQWpj?=
 =?utf-8?B?bEhyY1VpS3ZuSzJEalNkdGRmbmtGaHdwTzhCYUorcTNqZGFjVktIWTdRMzRy?=
 =?utf-8?B?K0wxdDAzbTFuc0l5bGNkb0pxUVliSyszZ2ZZenNwOWwvY01JR0hXYVNKbk9v?=
 =?utf-8?B?QkYvNGdOVU1CbFd4bmJiNy9lR3hZTDZlZWhQTDZtdndNc01mRGFBaUNncUpQ?=
 =?utf-8?B?Ulp3RURUQmJCSU5QclRpaHpqbEhDMjBpMW1Sd3pIVmJmeStselhrS1kwYjVn?=
 =?utf-8?B?dTRtL0tINUsxYk45Y2o0K1k5Ym5ZMGxvNS9QcXVGYWlRZnJWNGtrbVNrU0pD?=
 =?utf-8?B?WGIvRTAzOUxMVDdoV2RiSHY3anB6ZXZiSTJpdDl3elZwSFJBTDNCc0tKbVJ2?=
 =?utf-8?B?RjVDZlNtNXpnOFE3OFA1YldvbkxuRS9TNW5SUS8yV2dOMWRVUzR3cy85QnA4?=
 =?utf-8?B?ZkVDWTZOOVdrVDh2cUJZa0tjNnRNSzhnakV1VHRMeEI5VS84SloxZ2pJYnha?=
 =?utf-8?B?SkFkMlJwSkMwZUNUYmcvT2cwUXBFdjZjUUh0aDhPWHNBa1Rtc0dsWFIyazIx?=
 =?utf-8?B?RC9jZWJ2Q08xbUc1YWpybHVJUCs0aDIxV0tOMWJlVUM3UHBMWEVhZmdzYjFY?=
 =?utf-8?B?Zk43NFdxVGYxMWNtU2VDd09aTVZqQ3BUWkFiUnd6Vm9XcS81aVBGOEtINFMr?=
 =?utf-8?B?dW51bjFUeFR6VVQvWGpkSnNiWFBYQ2t4WkxqS2diUkxacW1XbkVZRTlzWjdC?=
 =?utf-8?B?dnB1R0VaRFl1MWsxbDNNUzRnaXpYYzQ1VGdSOW16SmZNMkp5N1haZFNoQjVF?=
 =?utf-8?Q?A7CbzwHQ8ftZy6JOlOlQhfNE+jG3uGz5eBHeaEqQM0=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <549E9A66D9B6DF4C95052FDBBD1EDCAF@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM5PR03MB3386.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 041e4341-9f6b-4320-f096-08d9efdccf6a
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Feb 2022 17:09:50.0590
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: XXIIzb9Gl5bcAEGLERX2xLFInl/p66zPtNzXMrEX9RkToEioTJ/LJL8WLOzTjf8dxOtbWmVtAZ6ZnKoGnatwlZkVVRAIedIBwM53xwJJKio=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR03MB6609
X-OriginatorOrg: citrix.com

T24gMTQvMDIvMjAyMiAxMzoxOCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IFtDQVVUSU9OIC0gRVhU
RVJOQUwgRU1BSUxdIERPIE5PVCByZXBseSwgY2xpY2sgbGlua3MsIG9yIG9wZW4gYXR0YWNobWVu
dHMgdW5sZXNzIHlvdSBoYXZlIHZlcmlmaWVkIHRoZSBzZW5kZXIgYW5kIGtub3cgdGhlIGNvbnRl
bnQgaXMgc2FmZS4NCj4gDQo+IE9uIDE0LjAyLjIwMjIgMTQ6MTEsIEphbmUgTWFsYWxhbmUgd3Jv
dGU6DQo+PiBPbiAxMS8wMi8yMDIyIDExOjQ2LCBKYW4gQmV1bGljaCB3cm90ZToNCj4+PiBbQ0FV
VElPTiAtIEVYVEVSTkFMIEVNQUlMXSBETyBOT1QgcmVwbHksIGNsaWNrIGxpbmtzLCBvciBvcGVu
IGF0dGFjaG1lbnRzIHVubGVzcyB5b3UgaGF2ZSB2ZXJpZmllZCB0aGUgc2VuZGVyIGFuZCBrbm93
IHRoZSBjb250ZW50IGlzIHNhZmUuDQo+Pj4NCj4+PiBPbiAxMS4wMi4yMDIyIDEyOjI5LCBSb2dl
ciBQYXUgTW9ubsOpIHdyb3RlOg0KPj4+PiBPbiBGcmksIEZlYiAxMSwgMjAyMiBhdCAxMDowNjo0
OEFNICswMDAwLCBKYW5lIE1hbGFsYW5lIHdyb3RlOg0KPj4+Pj4gT24gMTAvMDIvMjAyMiAxMDow
MywgUm9nZXIgUGF1IE1vbm7DqSB3cm90ZToNCj4+Pj4+PiBPbiBNb24sIEZlYiAwNywgMjAyMiBh
dCAwNjoyMTowMFBNICswMDAwLCBKYW5lIE1hbGFsYW5lIHdyb3RlOg0KPj4+Pj4+PiBkaWZmIC0t
Z2l0IGEveGVuL2FyY2gveDg2L2h2bS92bXgvdm1jcy5jIGIveGVuL2FyY2gveDg2L2h2bS92bXgv
dm1jcy5jDQo+Pj4+Pj4+IGluZGV4IDdhYjE1ZTA3YTAuLjQwNjBhZWYxYmQgMTAwNjQ0DQo+Pj4+
Pj4+IC0tLSBhL3hlbi9hcmNoL3g4Ni9odm0vdm14L3ZtY3MuYw0KPj4+Pj4+PiArKysgYi94ZW4v
YXJjaC94ODYvaHZtL3ZteC92bWNzLmMNCj4+Pj4+Pj4gQEAgLTM0Myw2ICszNDMsMTUgQEAgc3Rh
dGljIGludCB2bXhfaW5pdF92bWNzX2NvbmZpZyhib29sIGJzcCkNCj4+Pj4+Pj4gICAgICAgICAg
ICAgICAgIE1TUl9JQTMyX1ZNWF9QUk9DQkFTRURfQ1RMUzIsICZtaXNtYXRjaCk7DQo+Pj4+Pj4+
ICAgICAgICAgfQ0KPj4+Pj4+PiAgICAgDQo+Pj4+Pj4+ICsgICAgLyogQ2hlY2sgd2hldGhlciBo
YXJkd2FyZSBzdXBwb3J0cyBhY2NlbGVyYXRlZCB4YXBpYyBhbmQgeDJhcGljLiAqLw0KPj4+Pj4+
PiArICAgIGlmICggYnNwICkNCj4+Pj4+Pj4gKyAgICB7DQo+Pj4+Pj4+ICsgICAgICAgIGFzc2lz
dGVkX3hhcGljX2F2YWlsYWJsZSA9IGNwdV9oYXNfdm14X3ZpcnR1YWxpemVfYXBpY19hY2Nlc3Nl
czsNCj4+Pj4+Pj4gKyAgICAgICAgYXNzaXN0ZWRfeDJhcGljX2F2YWlsYWJsZSA9IChjcHVfaGFz
X3ZteF9hcGljX3JlZ192aXJ0IHx8DQo+Pj4+Pj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgY3B1X2hhc192bXhfdmlydHVhbF9pbnRyX2RlbGl2ZXJ5KSAmJg0KPj4+Pj4+
PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY3B1X2hhc192bXhfdmlydHVh
bGl6ZV94MmFwaWNfbW9kZTsNCj4+Pj4+Pg0KPj4+Pj4+IEkndmUgYmVlbiB0aGluayBhYm91dCB0
aGlzLCBhbmQgaXQgc2VlbXMga2luZCBvZiBhc3ltbWV0cmljIHRoYXQgZm9yDQo+Pj4+Pj4geEFQ
SUMgbW9kZSB3ZSByZXBvcnQgaHcgYXNzaXN0ZWQgc3VwcG9ydCBvbmx5IHdpdGgNCj4+Pj4+PiB2
aXJ0dWFsaXplX2FwaWNfYWNjZXNzZXMgYXZhaWxhYmxlLCB3aGlsZSBmb3IgeDJBUElDIHdlIHJl
cXVpcmUNCj4+Pj4+PiB2aXJ0dWFsaXplX3gyYXBpY19tb2RlIHBsdXMgZWl0aGVyIGFwaWNfcmVn
X3ZpcnQgb3INCj4+Pj4+PiB2aXJ0dWFsX2ludHJfZGVsaXZlcnkuDQo+Pj4+Pj4NCj4+Pj4+PiBJ
IHRoaW5rIHdlIGxpa2VseSBuZWVkIHRvIGJlIG1vcmUgY29uc2lzdGVudCBoZXJlLCBhbmQgcmVw
b3J0IGh3DQo+Pj4+Pj4gYXNzaXN0ZWQgeDJBUElDIHN1cHBvcnQgYXMgbG9uZyBhcyB2aXJ0dWFs
aXplX3gyYXBpY19tb2RlIGlzDQo+Pj4+Pj4gYXZhaWxhYmxlLg0KPj4+Pj4+DQo+Pj4+Pj4gVGhp
cyB3aWxsIGxpa2VseSBoYXZlIHNvbWUgZWZmZWN0IG9uIHBhdGNoIDIgYWxzbywgYXMgeW91IHdp
bGwgaGF2ZSB0bw0KPj4+Pj4+IGFkanVzdCB2bXhfdmxhcGljX21zcl9jaGFuZ2VkLg0KPj4+Pj4+
DQo+Pj4+Pj4gVGhhbmtzLCBSb2dlci4NCj4+Pj4+DQo+Pj4+PiBBbnkgb3RoZXIgdGhvdWdodHMg
b24gdGhpcz8gQXMgb24gb25lIGhhbmQgaXQgaXMgYXN5bW1ldHJpYyBidXQgYWxzbw0KPj4+Pj4g
dGhlcmUgaXNuJ3QgbXVjaCBhc3Npc3RhbmNlIHdpdGggb25seSB2aXJ0dWFsaXplX3gyYXBpY19t
b2RlIHNldCBhcywgaW4NCj4+Pj4+IHRoaXMgY2FzZSwgYSBWTSBleGl0IHdpbGwgYmUgYXZvaWRl
ZCBvbmx5IHdoZW4gdHJ5aW5nIHRvIGFjY2VzcyB0aGUgVFBSDQo+Pj4+PiByZWdpc3Rlci4NCj4+
Pj4NCj4+Pj4gSSd2ZSBiZWVuIHRoaW5raW5nIGFib3V0IHRoaXMsIGFuZCByZXBvcnRpbmcgaGFy
ZHdhcmUgYXNzaXN0ZWQNCj4+Pj4geHsyfUFQSUMgdmlydHVhbGl6YXRpb24gd2l0aCBqdXN0DQo+
Pj4+IFNFQ09OREFSWV9FWEVDX1ZJUlRVQUxJWkVfQVBJQ19BQ0NFU1NFUyBvcg0KPj4+PiBTRUNP
TkRBUllfRVhFQ19WSVJUVUFMSVpFX1gyQVBJQ19NT0RFIGRvZXNuJ3Qgc2VlbSB2ZXJ5IGhlbHBm
dWwuIFdoaWxlDQo+Pj4+IHRob3NlIHByb3ZpZGUgc29tZSBhc3Npc3RhbmNlIHRvIHRoZSBWTU0g
aW4gb3JkZXIgdG8gaGFuZGxlIEFQSUMNCj4+Pj4gYWNjZXNzZXMsIGl0IHdpbGwgc3RpbGwgcmVx
dWlyZSBhIHRyYXAgaW50byB0aGUgaHlwZXJ2aXNvciB0byBoYW5kbGUNCj4+Pj4gbW9zdCBvZiB0
aGUgYWNjZXNzZXMuDQo+Pj4+DQo+Pj4+IFNvIG1heWJlIHdlIHNob3VsZCBvbmx5IHJlcG9ydCBo
YXJkd2FyZSBhc3Npc3RlZCBzdXBwb3J0IHdoZW4gdGhlDQo+Pj4+IG1lbnRpb25lZCBmZWF0dXJl
cyBhcmUgcHJlc2VudCB0b2dldGhlciB3aXRoDQo+Pj4+IFNFQ09OREFSWV9FWEVDX0FQSUNfUkVH
SVNURVJfVklSVD8NCj4+Pg0KPj4+IE5vdCBzdXJlIC0gInNvbWUgYXNzaXN0YW5jZSIgc2VlbXMg
c3RpbGwgYSBsaXR0bGUgYmV0dGVyIHRoYW4gbm9uZSBhdCBhbGwuDQo+Pj4gV2hpY2ggcm91dGUg
dG8gZ28gZGVwZW5kcyBvbiB3aGF0IGV4YWN0bHkgd2UgaW50ZW5kIHRoZSBiaXQgdG8gYmUgdXNl
ZCBmb3IuDQo+Pj4NCj4+IFRydWUuIEkgaW50ZW5kZWQgdGhpcyBiaXQgdG8gYmUgc3BlY2lmaWNh
bGx5IGZvciBlbmFibGluZw0KPj4gYXNzaXN0ZWRfeHsyfWFwaWMuIFNvLCB3b3VsZCBpdCBiZSBp
bmNvbnNpc3RlbnQgdG8gcmVwb3J0IGhhcmR3YXJlDQo+PiBhc3Npc3RhbmNlIHdpdGgganVzdCBW
SVJUVUFMSVpFX0FQSUNfQUNDRVNTRVMgb3IgVklSVFVBTElaRV9YMkFQSUNfTU9ERQ0KPj4gYnV0
IHN0aWxsIGNsYWltIHRoYXQgeHsyfWFwaWMgaXMgdmlydHVhbGl6ZWQgaWYgbm8gTVNSIGFjY2Vz
c2VzIGFyZQ0KPj4gaW50ZXJjZXB0ZWQgd2l0aCBYRU5fSFZNX0NQVUlEX1gyQVBJQ19WSVJUIChp
biB0cmFwcy5jKSBzbyB0aGF0LCBhcyB5b3UNCj4+IHNheSwgdGhlIGd1ZXN0IGdldHMgYXQgbGVh
c3QgInNvbWUgYXNzaXN0YW5jZSIgaW5zdGVhZCBvZiBub25lIGJ1dCB3ZQ0KPj4gc3RpbGwgY2xh
aW0geHsyfWFwaWMgdmlydHVhbGl6YXRpb24gd2hlbiBpdCBpcyBhY3R1YWxseSBjb21wbGV0ZT8g
TWF5YmUNCj4+IEkgY291bGQgYWxzbyBhZGQgYSBjb21tZW50IGFsbHVkaW5nIHRvIHRoaXMgaW4g
dGhlIHhsIGRvY3VtZW50YXRpb24uDQo+IA0KPiBUbyByZXBocmFzZSBteSBlYXJsaWVyIHBvaW50
OiBXaGljaCBraW5kIG9mIGRlY2lzaW9ucyBhcmUgdGhlIGNvbnN1bWVyKHMpDQo+IG9mIHVzIHJl
cG9ydGluZyBoYXJkd2FyZSBhc3Npc3RhbmNlIGdvaW5nIHRvIHRha2U/IEluIGhvdyBmYXIgaXMg
dGhlcmUgYQ0KPiByaXNrIHRoYXQgInNvbWUgYXNzaXN0YW5jZSIgaXMgb3ZlcmFsbCBnb2luZyB0
byBsZWFkIHRvIGEgbG9zcyBvZg0KPiBwZXJmb3JtYW5jZT8gSSBndWVzcyBJJ2QgbmVlZCB0byBz
ZWUgY29tbWVudCBhbmQgYWN0dWFsIGNvZGUgYWxsIGluIG9uZQ0KPiBwbGFjZSAuLi4NCj4gDQpT
bywgSSB3YXMgdGhpbmtpbmcgb2YgYWRkaW5nIHNvbWV0aGluZyBhbG9uZyB0aGUgbGluZXMgb2Y6
DQoNCis9aXRlbSBCPGFzc2lzdGVkX3hhcGljPUJPT0xFQU4+IEI8KHg4NiBvbmx5KT4NCitFbmFi
bGVzIG9yIGRpc2FibGVzIGhhcmR3YXJlIGFzc2lzdGVkIHZpcnR1YWxpemF0aW9uIGZvciB4QVBJ
Qy4gVGhpcw0KK2FsbG93cyBhY2Nlc3NpbmcgQVBJQyByZWdpc3RlcnMgd2l0aG91dCBhIFZNLWV4
aXQuIE5vdGljZSBlbmFibGluZw0KK3RoaXMgZG9lcyBub3QgZ3VhcmFudGVlIGZ1bGwgdmlydHVh
bGl6YXRpb24gZm9yIHhBUElDLCBhcyB0aGlzIGNhbg0KK29ubHkgYmUgYWNoaWV2ZWQgaWYgaGFy
ZHdhcmUgc3VwcG9ydHMg4oCcQVBJQy1yZWdpc3RlciB2aXJ0dWFsaXphdGlvbuKAnQ0KK2FuZCDi
gJx2aXJ0dWFsLWludGVycnVwdCBkZWxpdmVyeeKAnS4gVGhlIGRlZmF1bHQgaXMgc2V0dGFibGUg
dmlhDQorTDx4bC5jb25mKDUpPi4NCg0KYW5kIGdvaW5nIGZvciBhc3Npc3RlZF94MmFwaWNfYXZh
aWxhYmxlID0gDQpjcHVfaGFzX3ZteF92aXJ0dWFsaXplX3gyYXBpY19tb2RlLg0KDQpUaGlzIHdv
dWxkIHByZXZlbnQgdGhlIGN1c3RvbWVyIGZyb20gZXhwZWN0aW5nIGZ1bGwgYWNjZWxlcmF0aW9u
IHdoZW4gDQphcGljX3JlZ2lzdGVyX3ZpcnQgYW5kL29yIHZpcnR1YWxfaW50cl9kZWxpdmVyeSBh
cmVuJ3QgYXZhaWxhYmxlIHdoaWxzdCANCnN0aWxsIG9mZmVyaW5nIHNvbWUgaWYgdGhleSBhcmUg
bm90IGF2YWlsYWJsZSBhcyBYZW4gY3VycmVudGx5IGRvZXMuIEluIA0KYSBmdXR1cmUgcGF0Y2gs
IHdlIGNvdWxkIGFsc28gZXhwb3NlIGFuZCBhZGQgY29uZmlnIG9wdGlvbnMgZm9yIHRoZXNlIA0K
Y29udHJvbHMgaWYgd2Ugd2FudGVkIHRvLg0KDQpUaGFuayB5b3UgZm9yIHlvdXIgaGVscCwNCg0K
SmFuZS4=


From xen-devel-bounces@lists.xenproject.org Mon Feb 14 17:21:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 17:21:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272572.467468 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJf2R-0003PD-T4; Mon, 14 Feb 2022 17:21:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272572.467468; Mon, 14 Feb 2022 17:21:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJf2R-0003P6-Pa; Mon, 14 Feb 2022 17:21:23 +0000
Received: by outflank-mailman (input) for mailman id 272572;
 Mon, 14 Feb 2022 17:21:22 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2GqZ=S5=arm.com=Luca.Fancellu@srs-se1.protection.inumbo.net>)
 id 1nJf2Q-0003P0-NT
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 17:21:22 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04on061e.outbound.protection.outlook.com
 [2a01:111:f400:fe0e::61e])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8720b23c-8dba-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 18:21:21 +0100 (CET)
Received: from AM6PR0202CA0068.eurprd02.prod.outlook.com
 (2603:10a6:20b:3a::45) by DB7PR08MB3564.eurprd08.prod.outlook.com
 (2603:10a6:10:4f::13) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Mon, 14 Feb
 2022 17:21:09 +0000
Received: from VE1EUR03FT021.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:3a:cafe::66) by AM6PR0202CA0068.outlook.office365.com
 (2603:10a6:20b:3a::45) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.18 via Frontend
 Transport; Mon, 14 Feb 2022 17:21:09 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT021.mail.protection.outlook.com (10.152.18.117) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4975.11 via Frontend Transport; Mon, 14 Feb 2022 17:21:08 +0000
Received: ("Tessian outbound 2877e54fe176:v113");
 Mon, 14 Feb 2022 17:21:08 +0000
Received: from 755a325212aa.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 793AE71C-781D-4887-BA9D-504BA0BB2216.1; 
 Mon, 14 Feb 2022 17:20:57 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 755a325212aa.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 14 Feb 2022 17:20:57 +0000
Received: from VI1PR0801MB2125.eurprd08.prod.outlook.com
 (2603:10a6:800:5b::23) by AM9PR08MB6179.eurprd08.prod.outlook.com
 (2603:10a6:20b:2da::9) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Mon, 14 Feb
 2022 17:20:51 +0000
Received: from VI1PR0801MB2125.eurprd08.prod.outlook.com
 ([fe80::5531:4c33:a50c:ea0e]) by VI1PR0801MB2125.eurprd08.prod.outlook.com
 ([fe80::5531:4c33:a50c:ea0e%9]) with mapi id 15.20.4975.018; Mon, 14 Feb 2022
 17:20:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8720b23c-8dba-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Q6ZTdptpjxbueCCMPaeWDSOHT05I9wowCjQfbNjENNY=;
 b=kKdGHFr6y+gZBuu8TRYGlgDVOSPY/zQy4Bq96r95gVbGpvwabXtky1r5yBJ0oozXoZpck1cdlZVGgtysCJ75nmz1PnB80xF/HIGcRGicDcdkTvxogP2jh3ZcxD7K5JRqvU6cxKhye8f0+MiARK1yECXwOXPug6rkzHS1MyXt4yA=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 888d03b1199be590
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=LvBSVbByvZnadRpd3yDhNFARwOZy/XbG/RcabkZvzIGqNac+agLOulBgEEM1dy2GWckFecDqP7/ZVekpMZnrJ7Z8Cgh8CGCs0EjhT4e5gWEWe8qOxKpf/Rxiymgpa13oM/K54V/FfsrPId7YncI+qx0TLtCc0KXeANpH5AyLgKKE8wcoYXZOtipKW8Y9K/GDw17JtxiVm2HTW7Z7yibzMslwp5+yUjYejFiLmEkVTU1Z6L9ejgiKaVECWo0mRMG+1LhSnGPTfC9xJaj17c5F+YZ+7+BYvGFw8/XecnZs4NT+YRXHK81CSS7klvxjE1GkXF9abUzllJ+IHU86hpJxKg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Q6ZTdptpjxbueCCMPaeWDSOHT05I9wowCjQfbNjENNY=;
 b=GLJzNU2qziNpg++c37XAnSvmGI0BwIaxWm0GWl+vkQqFiKERjR+ETwcZ9GyTkcWsOTSGvflJ6Tw12KSf+WaT25n1XCT4hYbIJuRur2UbazBl15PiEPWSI2BKRjUDspkiGDm6+3XLxCbHblRTB78NCxTTvAo7XyzGibtlfDcj8ruUNzzAs8fUVRuilbgYWV8mXmbn7LcyjqufeOLO86MQwUaj4DsfGlbekaebBZ2CffIhMKr8VGaEf6yG09y+oef9O2HdYKWZAVxd6o+NJJvIYTZQrZgPM2LqTrGAPyOY5h7LVnX+PFMkR8KU/B+qCpUqlze4gu/gKV0BuLMm28YneA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Q6ZTdptpjxbueCCMPaeWDSOHT05I9wowCjQfbNjENNY=;
 b=kKdGHFr6y+gZBuu8TRYGlgDVOSPY/zQy4Bq96r95gVbGpvwabXtky1r5yBJ0oozXoZpck1cdlZVGgtysCJ75nmz1PnB80xF/HIGcRGicDcdkTvxogP2jh3ZcxD7K5JRqvU6cxKhye8f0+MiARK1yECXwOXPug6rkzHS1MyXt4yA=
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
Content-Type: text/plain;
	charset=utf-8
Subject: Re: [RFC PATCH] arm/vgic-v3: provide custom callbacks for
 pend_lpi_tree radix tree
From: Luca Fancellu <luca.fancellu@arm.com>
In-Reply-To: <9eb5072b-6c55-7df1-75a3-c96594d64277@xen.org>
Date: Mon, 14 Feb 2022 17:20:46 +0000
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
 wei.chen@arm.com,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <54B5A035-086E-4912-B12F-AB3F7BF56164@arm.com>
References: <20220211150042.11972-1-luca.fancellu@arm.com>
 <81a2f978-9337-2e58-c8b2-86dc7defc2ec@xen.org>
 <1A16E009-F34C-4C6B-ABF6-FC08E395EABE@arm.com>
 <9eb5072b-6c55-7df1-75a3-c96594d64277@xen.org>
To: Julien Grall <julien@xen.org>
X-Mailer: Apple Mail (2.3693.60.0.1.1)
X-ClientProxiedBy: LO2P265CA0405.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:f::33) To VI1PR0801MB2125.eurprd08.prod.outlook.com
 (2603:10a6:800:5b::23)
MIME-Version: 1.0
X-MS-Office365-Filtering-Correlation-Id: 2c86073c-3374-4ab6-abf9-08d9efde63cc
X-MS-TrafficTypeDiagnostic:
	AM9PR08MB6179:EE_|VE1EUR03FT021:EE_|DB7PR08MB3564:EE_
X-Microsoft-Antispam-PRVS:
	<DB7PR08MB356425172F5B5764CC12B712E4339@DB7PR08MB3564.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 dpo69Cg+2luy+5zS4yzR6onZ7Kz9P0HC/Etuj0+k2sEk9YXzpCYJD44/h8ZLH8epSwGJEs3LwLtuPj3ytDnFCcY05f0HWMFQ6fM3oHu42vd+wTj/SNUMwXMutc+BqyRa4CoOkBmWSKCIeQy9OW5aXtheZItCyuKzdDViy5qlgiYcmFOX1mgFZOuEMA57JHC1yd+bMskLjguICQDQ8J/qQx6RczTuXSWfzIGNaJhULI3L0R3xNARZxQDNXfBzU9L3bFd2kMrPLpa0QJQ3b3y8GXbWtNXP3DwsOzp4F6rafACHE4srO96I9IWeyMAGYu7SoSloEqpHF+8V+H/7GNqdVcqp8KJdjw2rlFUQvqJza1WQhNSgghunbmi/WlxlkPl7f3U3JvBR4Adr/Gbtic9cly2397a7g9QsNudsE5K9U3iUHjaN3j79ykEbLbVvPULjETukPUZ/oEyPVkeESXxiCYryjvkswk/YmM2K4MhcJ09+IU3T9N6ph+Uey/6dqa+5S0D6/ykbW4lFUDZvM6YYHCda+dCIcpDnnEnqvW11N3JrhULd3bpOMB+3bPi3UQxiGyI3ixC/HI0ebt9rkx0Hc+6RIuD6+hCKk/MgtAWbFc1Nsr/iQeBveWyXSobM1rXnwGdXpa/YiM8miRHnx1OAOUUeTXTkcKzclM6zCW7WHSsu2rUEQB63uSAap0+0uqlodloVVYlG2A2zSx3uaE0y0ao/EWGD84N7m4z1Te0S9aE=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR0801MB2125.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(316002)(66476007)(54906003)(6916009)(83380400001)(66556008)(36756003)(33656002)(8676002)(5660300002)(2906002)(66946007)(2616005)(38100700002)(38350700002)(6506007)(186003)(26005)(8936002)(44832011)(86362001)(6486002)(6666004)(4326008)(6512007)(52116002)(53546011)(508600001)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6179
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT021.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	dbb3ead0-807b-461d-bcfb-08d9efde5923
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	J2tZQwy3q4WD/YJ0oBTwYigPVxXDyGrSeA+ec3B2eIXUt3f2pA1P2KOLUCuS25U4RjSoqORD7fhQf9VmUoFvhvhW+31jDxruO3uwCS3cGqerNPSd6GPOSVpUu5DL+hfskTRjGw+sazZwl086e0d1P+MMKYT45ikHkC70T+k6YMLLpdpud5rHqQbhkLU8QkNW+V9NhSCjKZlEfhZ5dR0bsckqMhe13nhyIM0Xz1tVRhLrCe49UsTRhCq+8JddhZUtOkveQ8QJNOY7igOeCMMFR6HTAp9hYsYK+JPGJKYiCqBYv8u6Y8dd9G9kq90+WAGsIhb93A76QbCs9pilYAOxzRCRzjznWKFCuoPg2JkEYpKlAMCtdlyoTfIIBQBGX1yAHVYxy9eL0GG5AXQRDFM2Cwgs7wgvDrQFvj2g4UTePsOfOj8lk0Y3/yH/A4hFUAxCTTvYO0YLdDHo8hkqRHh861I3f3txatSmLt1axerZ9nrx7mO/1HOSkX0VsBKvaUazPkNEZVgat4m3eoQBtn6Bs+a9xl4LOI1lQoUp2LlawX/+jgYa6yzynnDMmBS/a/BGVZi5b4JgfCcWYtrL/6ynTSHICuIK2MxPL8oa9NT11o7Smlrd8tA+B7CyQGCbMkkcFEuVG7OebHIc7Cdbinq4kVkCDfXcQrJrnKjLIPohoMzX6i61+iXa5I7u3t67YTx2
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(47076005)(2616005)(83380400001)(36756003)(508600001)(336012)(86362001)(6486002)(36860700001)(2906002)(40460700003)(33656002)(54906003)(6666004)(316002)(53546011)(6506007)(5660300002)(6862004)(356005)(8676002)(186003)(81166007)(6512007)(4326008)(82310400004)(70206006)(44832011)(26005)(8936002)(70586007);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2022 17:21:08.4733
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 2c86073c-3374-4ab6-abf9-08d9efde63cc
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT021.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3564



> On 11 Feb 2022, at 16:12, Julien Grall <julien@xen.org> wrote:
>=20
>=20
>=20
> On 11/02/2022 15:45, Luca Fancellu wrote:
>>> On 11 Feb 2022, at 15:26, Julien Grall <julien@xen.org> wrote:
>>>=20
>>> Hi Luca,
>>>=20
>>> On 11/02/2022 15:00, Luca Fancellu wrote:
>>>> pend_lpi_tree is a radix tree used to store pending irqs, the tree is
>>>> protected by a lock for read/write operations.
>>>> Currently the radix tree default function to free items uses the
>>>> RCU mechanism, calling call_rcu and deferring the operation.
>>>> However every access to the structure is protected by the lock so we
>>>> can avoid using the default free function that, by using RCU,
>>>> increases memory usage and impacts the predictability of the system.
>>>=20
>>> I understand goal but looking at the implementation of vgic_v3_lpi_to_p=
ending() (Copied below for convenience). We would release the lock as soon =
as the look-up finish, yet the element is returned.
>>>=20
>>> static struct pending_irq *vgic_v3_lpi_to_pending(struct domain *d,
>>>                                                  unsigned int lpi)
>>> {
>>>    struct pending_irq *pirq;
>>>=20
>>>    read_lock(&d->arch.vgic.pend_lpi_tree_lock);
>>>    pirq =3D radix_tree_lookup(&d->arch.vgic.pend_lpi_tree, lpi);
>>>    read_unlock(&d->arch.vgic.pend_lpi_tree_lock);
>>>=20
>>>    return pirq;
>>> }
>>>=20
>>> So the lock will not protect us against removal. If you want to drop th=
e RCU, you will need to ensure the structure pending_irq is suitably protec=
ted. I haven't check whether there are other locks that may suit us here.
>>>=20
>> Hi Julien,
>> Yes you are right! I missed that, sorry for the noise.
>=20
> Actually,... I think I am wrong :/.
>=20
> I thought the lock pend_lpi_tre_lock would protect pending_irq, but it on=
ly protects the radix tree element (not the value).
>=20
> The use in its_discard_event() seems to confirm that because the
> pending_irq is re-initialized as soon as it gets destroyed.
>=20
> I would like a second opinion though.
>=20

Hi Julien,

I think you are right, the structure itself is protected but the usage of t=
he element not. I guess now it=E2=80=99s safe because RCU
is freeing it when no cpus are using it anymore.

 - radix_tree_lookup
   - vgic_v3_lpi_to_pending (return pointer to item)
     - lpi_to_pending (function pointer to vgic_v3_lpi_to_pending)
       - irq_to_pending (return pointer to item if it is lpi -> is_lpi(irq)=
)

         - vgic_vcpu_inject_lpi
           - gicv3_do_LPI (rcu_lock_domain_by_id on domain)
             - gic_interrupt (do_LPI function pointer)
               - do_trap_irq
               - do_trap_fiq
           - its_handle_int
             - vgic_its_handle_cmds
               - vgic_v3_its_mmio_write
                 - handle_write
                   - try_handle_mmio
                     - do_trap_stage2_abort_guest
                       - do_trap_guest_sync

         - vgic_get_hw_irq_desc=20
           - release_guest_irq=20
             - arch_do_domctl (XEN_DOMCTL_unbind_pt_irq)
               - do_domctl
             - domain_vgic_free
               - arch_domain_destroy

         - gic_raise_inflight_irq (assert v->arch.vgic.lock)
         - gic_raise_guest_irq (assert v->arch.vgic.lock)
         - gic_update_one_lr (assert v->arch.vgic.lock, irq are disabled)
         - vgic_connect_hw_irq
           - gic_route_irq_to_guest (Assert !is_lpi)
           - gic_remove_irq_from_guest (Assert !is_lpi(virq))
         - vgic_migrate_irq (lock old->arch.vgic.lock)
         - arch_move_irqs (Assert not lpi in loop)
         - vgic_disable_irqs (lock v_target->arch.vgic.lock)
         - vgic_enable_irqs (lock v_target->arch.vgic.lock)
         - vgic_inject_irq (lock v->arch.vgic.lock)
         - vgic_evtchn_irq_pending (assert !is_lpi(v->domain->arch.evtchn_i=
rq))
         - vgic_check_inflight_irqs_pending (lock v_target->arch.vgic.lock)

   - vgic_v3_lpi_get_priority (return value from pointer)
     - lpi_get_priority (function pointer to vgic_v3_lpi_get_priority)

 - radix_tree_delete
   - its_discard_event (lock vcpu->arch.vgic.lock)

>From a quick analysis I see there are path using that pointer who doesn=E2=
=80=99t share any lock.

I will put on hold this patch.

Cheers,
Luca


> Cheers,
>=20
> --=20
> Julien Grall



From xen-devel-bounces@lists.xenproject.org Mon Feb 14 17:43:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 17:43:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272581.467479 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJfNy-0005nX-GP; Mon, 14 Feb 2022 17:43:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272581.467479; Mon, 14 Feb 2022 17:43:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJfNy-0005nQ-Cv; Mon, 14 Feb 2022 17:43:38 +0000
Received: by outflank-mailman (input) for mailman id 272581;
 Mon, 14 Feb 2022 17:43:38 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJfNy-0005nG-18; Mon, 14 Feb 2022 17:43:38 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJfNx-00029B-UC; Mon, 14 Feb 2022 17:43:37 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJfNx-0005iL-Eb; Mon, 14 Feb 2022 17:43:37 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nJfNx-0007Vh-E1; Mon, 14 Feb 2022 17:43:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=VHNKEbCJ0hOFv0Dnvo88djAU/l/BKOEiDSKUNLoOpg0=; b=k0c43FKVmp7ZUR0VrbuRQzYEQc
	CQBpOhq8XW63AMCoP0/oxgJ3nSD17GxQRYKb/whIrBpJ8D0PWIXG5ELZr+X5EYw4SK3bpfcJUdCcC
	hpqtr3bvP2hSDsi0xXo0AYEft/v2/zbEm2pO4eii485O9MlijSU1yG2MlFMQ9EJFsN30=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168106-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-5.4 test] 168106: trouble: blocked/broken/fail/pass
X-Osstest-Failures:
    linux-5.4:build-arm64:<job status>:broken:regression
    linux-5.4:build-arm64-pvops:<job status>:broken:regression
    linux-5.4:build-arm64-xsm:<job status>:broken:regression
    linux-5.4:build-arm64-xsm:host-install(4):broken:regression
    linux-5.4:build-arm64-pvops:host-install(4):broken:regression
    linux-5.4:build-arm64:host-install(4):broken:regression
    linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-armhf-armhf-xl-credit1:xen-boot:fail:heisenbug
    linux-5.4:test-arm64-arm64-examine:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-xl:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking
    linux-5.4:build-arm64-libvirt:build-check(1):blocked:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=52871671099d1bb3fca5ed076029e4b937bfc053
X-Osstest-Versions-That:
    linux=76fd334f07cc11e047c2237a19b2cf8b1f653ba2
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 14 Feb 2022 17:43:37 +0000

flight 168106 linux-5.4 real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168106/

Failures and problems with tests :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-arm64                     <job status>                 broken
 build-arm64-pvops               <job status>                 broken
 build-arm64-xsm                 <job status>                 broken
 build-arm64-xsm               4 host-install(4)        broken REGR. vs. 168060
 build-arm64-pvops             4 host-install(4)        broken REGR. vs. 168060
 build-arm64                   4 host-install(4)        broken REGR. vs. 168060

Tests which are failing intermittently (not blocking):
 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 168102 pass in 168106
 test-armhf-armhf-xl-credit1   8 xen-boot                   fail pass in 168102

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-examine      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl           1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit1   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit2   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-seattle   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-thunderx  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-vhd       1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-xsm       1 build-check(1)               blocked  n/a
 build-arm64-libvirt           1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit1 15 migrate-support-check fail in 168102 never pass
 test-armhf-armhf-xl-credit1 16 saverestore-support-check fail in 168102 never pass
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168060
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168060
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168060
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168060
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168060
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168060
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168060
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168060
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168060
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168060
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168060
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168060
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                52871671099d1bb3fca5ed076029e4b937bfc053
baseline version:
 linux                76fd334f07cc11e047c2237a19b2cf8b1f653ba2

Last test of basis   168060  2022-02-08 17:43:16 Z    5 days
Testing same since   168084  2022-02-11 08:43:38 Z    3 days    8 attempts

------------------------------------------------------------
People who touched revisions under test:
  Florian Fainelli <f.fainelli@gmail.com>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Guenter Roeck <linux@roeck-us.net>
  Jon Hunter <jonathanh@nvidia.com>
  Jon Maloy <jmaloy@redhat.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Linux Kernel Functional Testing <lkft@linaro.org>
  Shuah Khan <skhan@linuxfoundation.org>
  Slade Watkins <slade@sladewatkins.com>
  Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
  Ulf Hansson <ulf.hansson@linaro.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              broken  
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  broken  
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          blocked 
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            broken  
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          blocked 
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      blocked 
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  blocked 
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  blocked 
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     blocked 
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 blocked 
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      blocked 
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary

broken-job build-arm64 broken
broken-job build-arm64-pvops broken
broken-job build-arm64-xsm broken
broken-step build-arm64-xsm host-install(4)
broken-step build-arm64-pvops host-install(4)
broken-step build-arm64 host-install(4)
broken-job build-arm64-xsm broken
broken-job build-arm64-pvops broken
broken-job build-arm64 broken

Not pushing.

------------------------------------------------------------
commit 52871671099d1bb3fca5ed076029e4b937bfc053
Author: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date:   Fri Feb 11 09:07:52 2022 +0100

    Linux 5.4.179
    
    Link: https://lore.kernel.org/r/20220209191248.688351316@linuxfoundation.org
    Tested-by: Shuah Khan <skhan@linuxfoundation.org>
    Tested-by: Florian Fainelli <f.fainelli@gmail.com>
    Tested-by: Jon Hunter <jonathanh@nvidia.com>
    Tested-by: Linux Kernel Functional Testing <lkft@linaro.org>
    Tested-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
    Tested-by: Slade Watkins <slade@sladewatkins.com>
    Tested-by: Guenter Roeck <linux@roeck-us.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

commit d692e3406e052dbf9f6d9da0cba36cb763272529
Author: Jon Maloy <jmaloy@redhat.com>
Date:   Sat Feb 5 14:11:18 2022 -0500

    tipc: improve size validations for received domain records
    
    commit 9aa422ad326634b76309e8ff342c246800621216 upstream.
    
    The function tipc_mon_rcv() allows a node to receive and process
    domain_record structs from peer nodes to track their views of the
    network topology.
    
    This patch verifies that the number of members in a received domain
    record does not exceed the limit defined by MAX_MON_DOMAIN, something
    that may otherwise lead to a stack overflow.
    
    tipc_mon_rcv() is called from the function tipc_link_proto_rcv(), where
    we are reading a 32 bit message data length field into a uint16.  To
    avert any risk of bit overflow, we add an extra sanity check for this in
    that function.  We cannot see that happen with the current code, but
    future designers being unaware of this risk, may introduce it by
    allowing delivery of very large (> 64k) sk buffers from the bearer
    layer.  This potential problem was identified by Eric Dumazet.
    
    This fixes CVE-2022-0435
    
    Reported-by: Samuel Page <samuel.page@appgate.com>
    Reported-by: Eric Dumazet <edumazet@google.com>
    Fixes: 35c55c9877f8 ("tipc: add neighbor monitoring framework")
    Signed-off-by: Jon Maloy <jmaloy@redhat.com>
    Reviewed-by: Xin Long <lucien.xin@gmail.com>
    Reviewed-by: Samuel Page <samuel.page@appgate.com>
    Reviewed-by: Eric Dumazet <edumazet@google.com>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

commit 3a0a7ec5574b510b067cfc734b8bdb6564b31d4e
Author: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date:   Thu Jan 27 08:16:38 2022 +0100

    moxart: fix potential use-after-free on remove path
    
    commit bd2db32e7c3e35bd4d9b8bbff689434a50893546 upstream.
    
    It was reported that the mmc host structure could be accessed after it
    was freed in moxart_remove(), so fix this by saving the base register of
    the device and using it instead of the pointer dereference.
    
    Cc: Ulf Hansson <ulf.hansson@linaro.org>
    Cc: Xiyu Yang <xiyuyang19@fudan.edu.cn>
    Cc: Xin Xiong <xiongx18@fudan.edu.cn>
    Cc: Xin Tan <tanxin.ctf@gmail.com>
    Cc: Tony Lindgren <tony@atomide.com>
    Cc: Yang Li <yang.lee@linux.alibaba.com>
    Cc: linux-mmc@vger.kernel.org
    Cc: stable <stable@vger.kernel.org>
    Reported-by: whitehat002 <hackyzh002@gmail.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Link: https://lore.kernel.org/r/20220127071638.4057899-1-gregkh@linuxfoundation.org
    Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>


From xen-devel-bounces@lists.xenproject.org Mon Feb 14 18:30:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 18:30:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272592.467490 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJg73-0002O6-1F; Mon, 14 Feb 2022 18:30:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272592.467490; Mon, 14 Feb 2022 18:30:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJg72-0002Nx-Tm; Mon, 14 Feb 2022 18:30:12 +0000
Received: by outflank-mailman (input) for mailman id 272592;
 Mon, 14 Feb 2022 18:30:12 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJg71-0002No-Or
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 18:30:11 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 22b9b7ee-8dc4-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 19:30:09 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 22b9b7ee-8dc4-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644863409;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=YPnGa282D4mKyNWlBkK6JjxN5uCYIvCYfYALP0WFong=;
  b=BvBcB0KVbwTxRYoQINFuT6Y1cO5hOq/e98L0CoGWq68FFfl8hygoD9uB
   Wnlu+VsxrQ5QdGzdSArptpglHWZ6IOWVPSUt2r/OdZw6VmB2B1hoSzMsy
   GTxqbkcGM2ihvzNMDj9R+1DcpRIhJb7/wNAO2LHMSNd/5lnWb10hXIz2Z
   U=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: cR/SG5TTGVBnjhNKlyM0VJjOAuOYiU7RVN+sDRV7EfpHY8XyUihdy1jaLtYbjeEplDWDCfI2/N
 bYsoe8e6zhIOYo7LYpJI6PVaMiWkbIaUHtsG3ZVcN3kynpNX2Df6uHcKaUEHilt2/zMbiXss41
 rsH247g5Q+7KMx9LqEE5nFF4kgSho1laGfSPW9jXUUUGGx7QVcMGgQTqK94TqjSas781Po2ycl
 68uNSusYsI+hSHHoalBAHiXYW7P2UAHvIa+ZWLF7KNRsSamx991kmec6+6QGwaxNiXv9bHFks7
 TaKs3AXtCEVBh+OOIJ9hk4ZX
X-SBRS: 5.1
X-MesageID: 64586811
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:5TIALqzPp4scsGmIoud6t+edwSrEfRIJ4+MujC+fZmUNrF6WrkUEy
 jYbCGGFPq3fYDSkctsiOdm3pk5Uv8eBzYdiSwZu+yAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAhLeNYYH1500g7wbdl2tQAbeWRWGthh
 /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL
 wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt49P+
 PNWt4LpcwMGDpfBssIGah1xQz4raMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr
 6ZBbmlQMFbT3Ipaw5riIgVoru0lINPmI8U0vXZ4wCuCJf0nXYrCU+PB4towMDIY2JwTTaiOP
 pNxhTxHd0vtYkB9I1QrCswmn8yupUbBdzFcgQfAzUYwyzeKl1EguFT3C/LOYcCDT8hRmkeep
 0rF8n7/DxVcM8aQoRKH73ati+nnjS79HoUIG9WQyPluh1GCw30JPzcfX1C7vPqRh1a3XpRUL
 El80jUqhbg/8gqsVNaVdze1umKetxgQHf9ZCfQn6Rqlw7DRpQ2eAwAsXjNHLdArqsIybTgrz
 UOS2cPkAyR1t7+YQm7b8a2bxRuQEyUIKW4JZQcfUBAIpdLkpekOYgnnF4g5VvTv15usRG+2k
 2viQDUCa6s70vA78b654wn9hx2cnJXjaBUM4iyHQTfwhu9mX7KNa4ut4FndyP9PKoeFU1WM1
 EQ5d9iiAPMmVs/UynHUKAkZNPTwvqvebmWA6bJ6N8R5r1yQF2ifkZe8Cd2UDGNgKY46dDDge
 yc/UisBtcYIbBNGgUKaCr9d6vjGL4C9T7wJtdiON7Kih6SdkyfdoklTiba4hTyFraTVufhX1
 W2nWcitF20GLq9s0SC7QewQuZdymHximjODGM2jlk/9uVZ7WJJyYe1bWGZik8hjtP/UyOkr2
 4o32zS2J+V3D7SlP3i/HX87JlEWN3krba0aWOQMHtNv1jFOQTl7Y9eImOtJU9U8w8x9y7eZl
 lngCxQw4Aeu2hX6xfCiNykLhEXHBs0k8xrW/EUEYD6V5pTUSdjzvflPL8NtJdHKNoVLlJZJc
 hXMQO3ZatxnQTXb4TUNK577qY1pbhOwggySeSGiZVACk1RIHmQlI/foIVni8jcgFC2yuZdsq
 rGszFqDE5ECWx5jHIDdb/f2lwG9un0UmeRTWUrUI4YMJBWwodYycyGh3OUqJ8wsKAnYwmfI3
 QihHhpF9/LGpJU48YeViPnc/ZupCeZ3AmFTA3LfseStLSDf82f6md1AXe+EcCrzTmTx/Kn+N
 +xZw+ulaK8MnUpQspo6GLFulPps69zqrr5c7wJlAHSUMAj7VuI+eiGLhJAduLdMy7lVvRqNd
 niOotQKa6+UPM7FEUIKIFZ3ZOq0yvxJyCLZ6u44IRum6XYvrqaHS0hbIzKFlDdZcOluKIogz
 Oos5JwW5gi4hkZ4O9qKlHkJpWGFL3hGWKQ7rJAKRoTsj1NzmF1FZJXdDA7w4Y2ONIoQYhV7f
 GfMifqQnalYy2rDb2E3RCrE0udqjJgTvAxHkQ0ZLFOTl9uZ3vI60XW9K9jsoti5Gvmf799OB
 w==
IronPort-HdrOrdr: A9a23:d+Rna6veOFlrW6K9CJoHLktv7skC0IMji2hC6mlwRA09TyXGra
 6TdaUguiMc1gx8ZJh5o6H9BEGBKUmskaKceeEqTPaftXrdyRSVxeZZnMvfKlzbamPDH4tmtJ
 uIHJIOcOEYYWIK7/oSpTPIburIo+P3s5xA592utEuFJDsCA8oLgmcJaTpzUHcGPjWubaBJSa
 Z0jfA3wAZIDE5nF/hTcUN1OdQryee78a7OUFojPVoK+QOOhTSn5PrRCB6DxCoTVDtJ3PML7X
 XFuxaR3NTgj9iLjjvnk0PD5ZVfn9XsjvFZAtaXt8QTIjLwzi61eYVaXaGYtjxdmpDr1L9qqq
 iJn/4TBbU015rjRBDtnfIr4Xi57N8a0Q6k9bZfuwq5nSW2fkNhNyMLv/MmTvKQ0TtQgDg76t
 MW44vRjeslMfuL9h6Nl+TgRlVkkFG5rmEllvNWh3tDUZEGYLsUtoAH+lhJea1wUR4SxbpXW9
 WGNvusrsq+sGnqGEzxry1q2pihT34zFhCJTgwLvdGUySFfmDR8w1EDzMISk38c/NZlIqM0qN
 jsI+BtjvVDX8UWZaVyCKMIRta2EHXERVbJPHiJKVrqGakbMzbGqoLx4r8y+Oa2EaZ4gKcaid
 DEShdVpGQyc0XhBYmH24BK6AnERCGnUTHk2qhlltBEU33HNfPW2AG4OSUTevqb0oMi65fgKo
 SO0bptcoveEVc=
X-IronPort-AV: E=Sophos;i="5.88,368,1635220800"; 
   d="scan'208";a="64586811"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=PxZMmZro3wZedzWnztg9gGwMD6Wmy3/rdEJF50aXb6tv6EujOWUxKLznHzmeVyMetl1ZrTCVfEBUIPYdPLbcEm+dUxontgHtsG9fFlUdlvY5oREq/7VaGKnsk8HYXClbAv5RVW40V+miWU0s0oAzLdfKOzkMnlVdP5cHeEuI1oqEWQcj2ZQWzZ35evraJjK2D+++3FFEZcp8YYXbbC2Th2EjB/RBYaObN5MZ+L1uYo0/xvEkCHJ+9eA6lQL5tAjcX3gH9/DHW8Iok6nKnb9mboEkJAdYuDjNMJ3TJ8Iub6J1v5djo04F4PpICD1f65zHYMURLyGXIooqni4F7SJiGg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=YPnGa282D4mKyNWlBkK6JjxN5uCYIvCYfYALP0WFong=;
 b=gU8a5se3XB1WEqag94fnug7GoR3oq/jROSPuL1FpTuyfV40I17n3hP1Xm32PrXbFBG2rKV4JxkTVZgMkQaNhHllaQB6NFfEqPR4tmVOQdDVjYdAPtNR+Q/wJKDydoCVIcFnAgy7+BH1gh0hkAPdIXl2R3jVKoFLeSEE0bGD3kcYj3IG8z+FipwEpaa+1ToKjY2PpARsQ6JMw8FIM8aYyOvT/P74aARDOLNxGVE75BDFekq4MjFrKksenGswnEndJy+ZXiWk8agr0VgfL8/WG3KZy6xTdvQbWF+WcCfHX/WfZmUxbddMgFOgOBZvfkdJcDdKaL0YJoabAeUCAkd/v5g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=YPnGa282D4mKyNWlBkK6JjxN5uCYIvCYfYALP0WFong=;
 b=xeJJi4jladeBn1Qjif6pInXqD6P1w+baMzpaWJRiYjUhEBwIljgiCY5lMoHODAxqMUKsNKYjYNrK+Ofwk+atRUv3EYHwOpuLak/57tYHqbpJZTsWQI6Ad0KHfeFnTmVY0OsE/fNC9zosk/snE3O0JFydHRdfgfoojN/E+RRJ1l4=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Jan Beulich
	<JBeulich@suse.com>, Roger Pau Monne <roger.pau@citrix.com>, Wei Liu
	<wl@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
	<julien@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v2 02/70] xen/sort: Switch to an extern inline
 implementation
Thread-Topic: [PATCH v2 02/70] xen/sort: Switch to an extern inline
 implementation
Thread-Index: AQHYIaGjy/wpq8SdQkKdLl3UHHKbD6yTBisAgABYUoA=
Date: Mon, 14 Feb 2022 18:30:01 +0000
Message-ID: <364d47c4-4436-8111-0019-aa3ab37ffcb2@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
 <20220214125127.17985-3-andrew.cooper3@citrix.com>
 <71997BED-096C-4168-AF40-D74C616D6A20@arm.com>
In-Reply-To: <71997BED-096C-4168-AF40-D74C616D6A20@arm.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: b0608f4c-8df8-4a76-af84-08d9efe8038f
x-ms-traffictypediagnostic: BN7PR03MB4561:EE_
x-microsoft-antispam-prvs: <BN7PR03MB4561A21CE0B3D5022030C1DFBA339@BN7PR03MB4561.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8882;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: +VgJkqnlgPcaotD3/u1huSfEU3rFJuiWdAqL7I8YTXwMrm2or1W9OuzkL4+xrEKga3sjtTvrOGmCV14yAuTY2UGHhro+RR/n+v+7J14sCDe4g4lyDdhC9vBuM7cJ6rtLtVJLBh5E+CVUnzF82Heapp0Kl8a3hshhr2iknG2z0u8Q16LTnYIQz/Kjd4Gr0EBNAX6gfomTHEa93lq4I6ARHeoOlT0yBWcLwsFeaZ9iTzWjnboAQfdajIcoTOuU6KTBnhBR78886STzUyCdSJo7gKVvMpfG8sR+ZWfjn2wAPQuaThnuSCcpMzbUPM/HG9cpGOWBocsLnHL/PLBzyxvqf5yJABq1G4IQwjT1NGrmKI9onMvbuo69UI3NUTWPcUjWM8YSedjX74xjG0K+O0VfPhq+ncMZFrR1I05m03Bu00waxxnYvKUY1HbbMzX61jxZkz7XwWK9RlTddhr1WnRhcF6If31r+yAx4ntRoFsKsRFWdmioJmsyptoo0HdAB8lO23hl9bd7+yuF6dqWNnxcuchkVuzD6yEx1nC5BOjrLSOxxyNbowgVLfeAQQwUzLcOOybVJEY0I0VtTHCwEJ/KbO714TDkRwnGPdYvNBZYVlzaQI6YKp1ImRreqwIuH7Bg4/uoVaKWCaFfyTO4hGKCbsT3gRXqNDXn7RkJFVKlVlqXjggohEyMWisTIiMIZvV3PM/RJPfvZQ/zgNu89HReVU6QA+LHUQMtCbRgKGSsmdLDkAnJxE9pKZgz/xKjOBf+iEWHvFhgfWRaK5wIYdUnFA==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6916009)(53546011)(91956017)(86362001)(31696002)(54906003)(6486002)(2616005)(31686004)(316002)(36756003)(6512007)(508600001)(122000001)(82960400001)(66476007)(2906002)(66446008)(38070700005)(66946007)(6506007)(76116006)(66556008)(71200400001)(64756008)(8936002)(8676002)(4326008)(5660300002)(186003)(26005)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?YWEzeGNBVUwvWjVuQWU2VFd5a3JvNmJFWmYwdFBzNmxWUFljVkk0ektyZUVM?=
 =?utf-8?B?YWdPbUFiQXV1N1c0NCtzek1XOEpDL0NQL2t5bGU1LzRTeXhQUWVVMUNmWUlV?=
 =?utf-8?B?bG0waytyUFRQQWxuNHIxUGFYdGR4ZTVXYlNKSXhVZmUwVFlBTy9veVRXWXJl?=
 =?utf-8?B?aDFpSXN1ak1XaGVZZzVOQ3ZrbHF3b0dJbFVUVXBHNm5KaENjdHJlWWJFcFND?=
 =?utf-8?B?b0RqM0ZWVFBEUDlad291Ym4rVVFnWnd3Z1RWK2tPek9yekJKTERoKy95Y040?=
 =?utf-8?B?b2xaMjNBeTNxNitHcVcxRHdPRHM4dnpzbm0raXBqdmtIRjFHQ2NHcGM0b3Ay?=
 =?utf-8?B?SmVPSGplVmJPbjZxMW5hcWxqNmtkOVZiTVVyUEpOSzdjKzBnOXdwTHRRa2Rt?=
 =?utf-8?B?NnhzMThjMzBmWGQ3Skd2OFNFYVYrREVDWkJ1SnREUm1CWlIvMmVkVDlDZEtW?=
 =?utf-8?B?RHY2OTVHVFcvVERtZDRZS0lmUWF5aVBhekJWdTdnRlFCK05FNWFsbkhseW1U?=
 =?utf-8?B?WDVXWXZjYzMwRnpsNG9oK3UxL1BEeC9CN0ZvUExsTmhpMEx5TlhkaXpwUnJu?=
 =?utf-8?B?RFUyblUzRU9xWFkrT0RvOFVTdFRHYzQweCsyRkRLTHQ2MFZjSkVUTm9HKzZt?=
 =?utf-8?B?UGtpNGJmMGpNSVhZRFBDTEp0b3QrblQyeGdraFVQelZXbjJKMTRPQWJUeWtV?=
 =?utf-8?B?bHlpMW9lRW1WN3JYQXhNeUI5b2xBODJhdkh4R2tIVmFpVVNDOVUxU2psd0xn?=
 =?utf-8?B?QytLTUE2Tm1hWjZqN0NTYjRSb013bUZnT1N6Y0lIMGpPaXIxbkY2ZlhaSkVk?=
 =?utf-8?B?ekhLaGFpNFA0cnRwYTN3VnIyQnBXTlBwWkE4RTJXcjFJcVhXS3lXaXF1c3Y0?=
 =?utf-8?B?U1JhZW9IaGlHMVFkTDlnbGVVMFN1TkxhcmYzVzJnN2E1OWdLTzhWeE85R3E2?=
 =?utf-8?B?ZzhZQUdhZzVwYncrdTV4S1ErMktzZGtmYWV5TmIxWFpidUtwYnRLWFBjMW5Q?=
 =?utf-8?B?NEtSRE04bnpINktjeC9KNHNBdHRKTjhWcTRrdmRNYUlRbXFjb1Z3NjF5bmRl?=
 =?utf-8?B?R1RJZUNWdllSQmw1Y0JjK3d6QlVhU3ZqRUpKOTFkd25HOVB3MndBWFIxOXJU?=
 =?utf-8?B?ZkkzdlV4QmZ3cGg1d0I1L2prSXROaTNQR3lGa29lZlhhVVlhRHZKT2ZaaTkv?=
 =?utf-8?B?VEszYjVDSXhLbjhGUWpSeTVMd0VybEFaV2U4Q2tlN1Y2V2s2ZndoazBlS1BJ?=
 =?utf-8?B?bnZIM25GSzNDeEl6YVJKUERjbmRuYzRtc2w4WUt2U1pSNmora1J5bE4xWi80?=
 =?utf-8?B?U0IzWHNjMDFNNk84QlA4K3c5YThQWWpvNEo4M0dBcm5MbC9hVHNRUHoxSXh5?=
 =?utf-8?B?a2NLakgyQlBEbzNaUnVCcHZCbmRGaGhLSUF6LzFTaGZsdjE2SHIwOStJRW5o?=
 =?utf-8?B?YXFHSFJFVG1FNmhwMmRZVmNFRkFjUzdYQncyTmpmcVF0VjlnSHl4aVZPQk1x?=
 =?utf-8?B?T3lydGpHUVBJaVR6NTl5ZlZXV3FYd0kvaFR1dWIxRW12a1VDR2ZvZDlTVGNn?=
 =?utf-8?B?ZHBrOGwvcFF2TUJrd213dDhhUFJDQnFYakR5Q1gxdkVSdHI4N0pQeHdQOGkx?=
 =?utf-8?B?Sm1oK2hoY1d1b09Uc1Uva21ranp6VXVBZ3FRQ0IyN1k2bHJZOXg3MnRwcTBQ?=
 =?utf-8?B?blhFWncxODRpdVdlNkhqeldtTXB3UUFrYkwvWWtlNUxoU1AvUTRraGNTQ21p?=
 =?utf-8?B?QUJqWXlIU1VGYmcwTk11ejVCOFhqUmtnR0R6dGJqMnZIcUpiOG9yd3BhcGFE?=
 =?utf-8?B?Q2RpZ3VsSlc0cWJ3ckhOMk1aeG0vajU2MXVvRVkzZTZLbzB3T0VGaG5NdEFx?=
 =?utf-8?B?bTZkZXRYSFNQdkd3QUg0V2UwZ0xCLzRpcVp4b2N1VWcxL3FwM1luU3VHWU5C?=
 =?utf-8?B?RlhXRm9CUGRUNzhkNC9RRnJvS1lPUzdSV1F1M0VXR01PQUp3NnI1SW9NUDJy?=
 =?utf-8?B?RWRWam4vU1ZQVHEvbW9vbFRubUpJT0pObmp3N3N4VERyUE8yWkdsdHNNbkM1?=
 =?utf-8?B?Vm56MXJJZ1lqN2VxUVhBZTVJVUE5UDdsZnl6VXUxaFRDZ0NJeXcrN1pDdXh6?=
 =?utf-8?B?RDIwdEZlZ0ZTTnRXeFlla0YvaDFsVGh1elZ3ZVEyMFJ5akd6RXhRS0RxeHBn?=
 =?utf-8?B?SlY1TWpYcFAxUGJsQkdPQWxwZklEbGZtSlZKc1hpUW1lNnVtckNvUHdnell6?=
 =?utf-8?B?VU5vUGg1N0NmZjFrbCtvemx1R1dRPT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <AC5E2CD6EF8FD146B6F40F77BF103DB3@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b0608f4c-8df8-4a76-af84-08d9efe8038f
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Feb 2022 18:30:02.0054
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: kMN1EH+7WnmS8qlBcUVSoyX0xkpoCiYxI0XRRILVrWAcVfIP+c1R91IRhliqQGm3xSr1pyJ24bq8pOXQI7HcDyWBjigmu7CPd0R1cJDMhTE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB4561
X-OriginatorOrg: citrix.com

T24gMTQvMDIvMjAyMiAxMzoxMywgQmVydHJhbmQgTWFycXVpcyB3cm90ZToNCj4gSGkgQW5kcmV3
LA0KPg0KPj4gT24gMTQgRmViIDIwMjIsIGF0IDEyOjUwLCBBbmRyZXcgQ29vcGVyIDxhbmRyZXcu
Y29vcGVyM0BjaXRyaXguY29tPiB3cm90ZToNCj4+DQo+PiBUaGVyZSBhcmUgZXhhY3RseSAzIGNh
bGxlcnMgb2Ygc29ydCgpIGluIHRoZSBoeXBlcnZpc29yLiAgQ2FsbGJhY2tzIGluIGEgdGlnaHQN
Cj4+IGxvb3AgbGlrZSB0aGlzIGFyZSBwcm9ibGVtYXRpYyBmb3IgcGVyZm9ybWFuY2UsIGVzcGVj
aWFsbHkgd2l0aCBTcGVjdHJlIHYyDQo+PiBwcm90ZWN0aW9ucywgd2hpY2ggaXMgd2h5IGV4dGVy
biBpbmxpbmUgaXMgdXNlZCBjb21tb25seSBieSBsaWJyYXJpZXMuDQo+Pg0KPj4gQm90aCBBUk0g
Y2FsbGVycyBwYXNzIGluIE5VTEwgZm9yIHRoZSBzd2FwIGZ1bmN0aW9uLCBhbmQgd2hpbGUgdGhp
cyBtaWdodCBzZWVtDQo+PiBsaWtlIGFuIGF0dHJhY3RpdmUgb3B0aW9uIGF0IGZpcnN0LCBpdCBj
YXVzZXMgZ2VuZXJpY19zd2FwKCkgdG8gYmUgdXNlZCwgd2hpY2gNCj4+IGZvcmNlZCBhIGJ5dGUt
d2lzZSBjb3B5LiAgUHJvdmlkZSByZWFsIHN3YXAgZnVuY3Rpb25zIHNvIHRoZSBjb21waWxlciBj
YW4NCj4+IG9wdGltaXNlIHByb3Blcmx5LCB3aGljaCBpcyB2ZXJ5IGltcG9ydGFudCBmb3IgQVJN
IGRvd25zdHJlYW1zIHdoZXJlDQo+PiBtaWxsaXNlY29uZHMgdW50aWwgdGhlIHN5c3RlbSBpcyB1
cCBtYXR0ZXJzLg0KPj4NCj4+IE5vIGZ1bmN0aW9uYWwgY2hhbmdlLg0KPj4NCj4+IFNpZ25lZC1v
ZmYtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+DQo+PiBSZXZp
ZXdlZC1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KPiBKdXN0IG9uZSBjb21t
ZW50IGZpeCBhZnRlciwgd2l0aCBpdCBmaXhlZCBmb3IgdGhlIGFybSBwYXJ0Og0KPg0KPiBSZXZp
ZXdlZC1ieTogQmVydHJhbmQgTWFycXVpcyA8YmVydHJhbmQubWFycXVpc0Bhcm0uY29tPg0KDQpU
aGFua3MuDQoNCj4+IGRpZmYgLS1naXQgYS94ZW4vaW5jbHVkZS94ZW4vc29ydC5oIGIveGVuL2lu
Y2x1ZGUveGVuL3NvcnQuaA0KPj4gaW5kZXggYTQwMzY1Mjk0OGU3Li4wMTQ3OWVhNDQ2MDYgMTAw
NjQ0DQo+PiAtLS0gYS94ZW4vaW5jbHVkZS94ZW4vc29ydC5oDQo+PiArKysgYi94ZW4vaW5jbHVk
ZS94ZW4vc29ydC5oDQo+PiBAQCAtMyw4ICszLDYxIEBADQo+Pg0KPj4gI2luY2x1ZGUgPHhlbi90
eXBlcy5oPg0KPj4NCj4+ICsvKg0KPj4gKyAqIHNvcnQgLSBzb3J0IGFuIGFycmF5IG9mIGVsZW1l
bnRzDQo+PiArICogQGJhc2U6IHBvaW50ZXIgdG8gZGF0YSB0byBzb3J0DQo+PiArICogQG51bTog
bnVtYmVyIG9mIGVsZW1lbnRzDQo+PiArICogQHNpemU6IHNpemUgb2YgZWFjaCBlbGVtZW50DQo+
PiArICogQGNtcDogcG9pbnRlciB0byBjb21wYXJpc29uIGZ1bmN0aW9uDQo+PiArICogQHN3YXA6
IHBvaW50ZXIgdG8gc3dhcCBmdW5jdGlvbiBvciBOVUxMDQo+IFRoZSBmdW5jdGlvbiBpcyBub3Qg
YWNjZXB0aW5nIGFueW1vcmUgdG8gaGF2ZSBOVUxMIGFzIHBhcmFtZXRlci4NCj4gVGhlIGNvbW1l
bnQgc2hvdWxkIGJlIGZpeGVkIGhlcmUuDQoNCldpbGwgZml4Lg0KDQp+QW5kcmV3DQo=


From xen-devel-bounces@lists.xenproject.org Mon Feb 14 18:48:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 18:48:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272602.467501 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJgOQ-000412-Nn; Mon, 14 Feb 2022 18:48:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272602.467501; Mon, 14 Feb 2022 18:48:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJgOQ-00040v-KM; Mon, 14 Feb 2022 18:48:10 +0000
Received: by outflank-mailman (input) for mailman id 272602;
 Mon, 14 Feb 2022 18:48:09 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJgOP-00040S-5k; Mon, 14 Feb 2022 18:48:09 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJgOP-0003Oo-1n; Mon, 14 Feb 2022 18:48:09 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJgOO-0008TS-Gq; Mon, 14 Feb 2022 18:48:08 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nJgOO-00064D-GR; Mon, 14 Feb 2022 18:48:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=emBSw/gNLgupLx7JLxxVA6OSH4vJ/UzPfshjuaO3EEE=; b=2Ru/Bv6kSquGtrKJny7uuXpXt+
	f9A52P53hEgx9ss+RK4a2/Xvl+Bsiz8ZzuvOdePe0XhyxlW9TsW66X/UsC2ripzMrh39sWdSKgWy1
	VQDyAFnzBP75umnAtKfqjwVx3x/IJyyiV/9A+YTGHwD+WAsEZRFDxMq64YoyrH2qefko=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168108-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 168108: regressions - trouble: blocked/broken/fail/pass
X-Osstest-Failures:
    linux-linus:build-arm64:<job status>:broken:regression
    linux-linus:build-arm64-pvops:<job status>:broken:regression
    linux-linus:build-arm64-xsm:<job status>:broken:regression
    linux-linus:build-arm64-xsm:host-install(4):broken:regression
    linux-linus:build-arm64:host-install(4):broken:regression
    linux-linus:build-arm64-pvops:host-install(4):broken:regression
    linux-linus:test-armhf-armhf-libvirt-qcow2:<job status>:broken:regression
    linux-linus:test-armhf-armhf-libvirt-qcow2:host-ping-check-xen:fail:regression
    linux-linus:test-armhf-armhf-libvirt-qcow2:host-install(5):broken:heisenbug
    linux-linus:test-amd64-amd64-xl-rtds:guest-localmigrate:fail:heisenbug
    linux-linus:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable
    linux-linus:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:allowable
    linux-linus:test-arm64-arm64-examine:build-check(1):blocked:nonblocking
    linux-linus:build-arm64-libvirt:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=754e0b0e35608ed5206d6a67a791563c631cec07
X-Osstest-Versions-That:
    linux=f1baf68e1383f6ed93eb9cff2866d46562607a43
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 14 Feb 2022 18:48:08 +0000

flight 168108 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168108/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-arm64                     <job status>                 broken
 build-arm64-pvops               <job status>                 broken
 build-arm64-xsm                 <job status>                 broken
 build-arm64-xsm               4 host-install(4)        broken REGR. vs. 168080
 build-arm64                   4 host-install(4)        broken REGR. vs. 168080
 build-arm64-pvops             4 host-install(4)        broken REGR. vs. 168080
 test-armhf-armhf-libvirt-qcow2    <job status>                broken in 168103
 test-armhf-armhf-libvirt-qcow2 10 host-ping-check-xen    fail REGR. vs. 168080

Tests which are failing intermittently (not blocking):
 test-armhf-armhf-libvirt-qcow2 5 host-install(5) broken in 168103 pass in 168108
 test-amd64-amd64-xl-rtds     18 guest-localmigrate         fail pass in 168103

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds    18 guest-start/debian.repeat fail REGR. vs. 168080
 test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail in 168103 REGR. vs. 168080

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-examine      1 build-check(1)               blocked  n/a
 build-arm64-libvirt           1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl           1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit1   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit2   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-seattle   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-thunderx  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-vhd       1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-xsm       1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168080
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168080
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168080
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168080
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168080
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168080
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168080
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                754e0b0e35608ed5206d6a67a791563c631cec07
baseline version:
 linux                f1baf68e1383f6ed93eb9cff2866d46562607a43

Last test of basis   168080  2022-02-11 00:09:22 Z    3 days
Failing since        168086  2022-02-11 20:11:19 Z    2 days    7 attempts
Testing same since   168103  2022-02-13 21:41:20 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Aaron Liu <aaron.liu@amd.com>
  Adam Ford <aford173@gmail.com>
  Al Cooper <alcooperx@gmail.com>
  Alex Deucher <alexander.deucher@amd.com>
  Alexander Egorenkov <egorenar@linux.ibm.com>
  Alexander Gordeev <agordeev@linux.ibm.com>
  Alexander Stein <alexander.stein@ew.tq-group.com>
  Alexandre Ghiti <alexandre.ghiti@canonical.com>
  Alim Akhtar <alim.akhtar@samsung.com>
  Alviro Iskandar Setiawan <alviro.iskandar@gmail.com>
  Ammar Faizi <ammarfaizi2@gnuweeb.org>
  Andreas Gruenbacher <agruenba@redhat.com>
  Andrew Morton <akpm@linux-foundation.org>
  Andrey Konovalov <andreyknvl@gmail.com>
  Andrzej Pietrasiewicz <andrzej.p@collabora.com>
  Andy Shevchenko <andriy.shevchenko@linux.intel.com>
  Arnd Bergmann <arnd@arndb.de>
  Aswath Govindraju <a-govindraju@ti.com>
  Aurelien Jarno <aurelien@aurel32.net>
  Bartosz Golaszewski <brgl@bgdev.pl>
  Bean Huo <beanhuo@micron.com>
  Benjamin Gaignard <benjamin.gaignard@collabora.com>
  Bjorn Helgaas <bhelgaas@google.com>
  Bob Peterson <rpeterso@redhat.com>
  Brenda Streiff <brenda.streiff@ni.com>
  Brian Johannesmeyer <bjohannesmeyer@gmail.com>
  Brian Norris <briannorris@chromium.org>
  Cai Huoqing <cai.huoqing@linux.dev>
  Cameron Williams <cang1@live.co.uk>
  Catalin Marinas <catalin.marinas@arm.com>
  Changbin Du <changbin.du@gmail.com>
  Chia-Wei Wang <chiawei_wang@aspeedtech.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Borntraeger <borntraeger@linux.ibm.com>
  Christian Hewitt <christianshewitt@gmail.com>
  Christian König <christian.koenig@amd.com>
  Christoph Hellwig <hch@lst.de>
  Christoph Niedermaier <cniedermaier@dh-electronics.com>
  Christophe JAILLET <christophe.jaillet@wanadoo.fr>
  Chunfeng Yun <chunfeng.yun@mediatek.com>
  Damien Le Moal <damien.lemoal@opensource.wdc.com>
  Dan Carpenter <dan.carpenter@oracle.com>
  Daniel Bristot de Oliveira <bristot@kernel.org>
  Daniel Stone <daniels@collabora.com>
  Daniel Vetter <daniel.vetter@ffwll.ch>
  Daniel Vetter <daniel.vetter@intel.com>
  Daniel Wheeler <daniel.wheeler@amd.com>
  Dave Airlie <airlied@redhat.com>
  Dave Hansen <dave.hansen@linux.intel.com>
  Dave Stevenson <dave.stevenson@raspberrypi.com>
  David Hildenbrand <david@redhat.com>
  David Rientjes <rientjes@google.com>
  Dinh Nguyen <dinguyen@kernel.org>
  Dmytro Laktyushkin <Dmytro.Laktyushkin@amd.com>
  Dongjin Kim <tobetter@gmail.com>
  Fabio Estevam <festevam@gmail.com>
  Fabio M. De Francesco <fmdefrancesco@gmail.com>
  Fabrice Gasnier <fabrice.gasnier@foss.st.com>
  Florian Fainelli <f.fainelli@gmail.com>
  Geert Uytterhoeven <geert+renesas@glider.be>
  Geert Uytterhoeven <geert@linux-m68k.org>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>Cc: Dave Airlie <airlied@gmail.com>
  Guido Günther <agx@sigxcpu.org> # Librem 5 (imx8mq) with it's rather picky panel
  Guo Ren <guoren@linux.alibaba.com>
  Hans de Goede <hdegoede@redhat.com>
  Hector Martin <marcan@marcan.st>
  Heiko Carstens <hca@linux.ibm.com>
  Heiko Stuebner <heiko@sntech.de>
  Helge Deller <deller@gmx.de>
  Ilya Leoshkevich <iii@linux.ibm.com>
  Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
  JaeSang Yoo <js.yoo.5b@gmail.com>
  JaeSang Yoo <jsyoo5b@gmail.com>
  Jakob Koschel <jakobkoschel@gmail.com>
  James Smart <jsmart2021@gmail.com>
  Jan Beulich <jbeulich@suse.com>
  Jan Kara <jack@suse.cz>
  Jani Nikula <jani.nikula@intel.com>
  Jann Horn <jannh@google.com>
  Jarkko Nikula <jarkko.nikula@bitmer.com>
  Jarkko Sakkinen <jarkko@kernel.org>  (kselftest as sanity check)
  Jasdeep Dhillon <jdhillon@amd.com>
  Jayesh Choudhary <j-choudhary@ti.com>
  Jens Axboe <axboe@kernel.dk>
  Jens Wiklander <jens.wiklander@linaro.org>
  Jeremy Linton <jeremy.linton@arm.com>
  Jerome Forissier <jerome@forissier.org>
  Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
  Jing Leng <jleng@ambarella.com>
  Jisheng Zhang <jszhang@kernel.org>
  Joel Stanley <joel@jms.id.au>
  Johan Hovold <johan@kernel.org>
  Jonas Malaco <jonas@protocubo.io>
  Josh Poimboeuf <jpoimboe@redhat.com>
  Juergen Gross <jgross@suse.com>
  Kai-Heng Feng <kai.heng.feng@canonical.com>
  Kees Cook <keescook@chromium.org>
  Kishon Vijay Abraham I <kishon@ti.com>
  Kosuke Tatsukawa <tatsu-ab1@nec.com>
  Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Linus Walleij <linus.walleij@linaro.org>
  Liu Ying <victor.liu@nxp.com>
  Liu Ying <victor.liu@nxp.com> # RM67191 DSI panel on i.MX8mq EVK
  Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
  Lucas De Marchi <lucas.demarchi@intel.com>
  Lutz Koschorreck <theleks@ko-hh.de>
  Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
  Marc Zyngier <maz@kernel.org>
  Marek Vasut <marex@denx.de>
  Mario Limonciello <mario.limonciello@amd.com>
  Mark Brown <broonie@kernel.org>
  Martin Blumenstingl <martin.blumenstingl@googlemail.com>
  Martin K. Petersen <martin.petersen@oracle.com>
  Martin Kepplinger <martin.kepplinger@puri.sm>
  Masahiro Yamada <masahiroy@kernel.org>
  Mathias Krause <minipli@grsecurity.net>
  Maxime Ripard <maxime@cerno.tech>
  Mel Gorman <mgorman@suse.de>
  Michael Walle <michael@walle.cc>
  Michal Hocko <mhocko@suse.com>
  Michal Simek <michal.simek@xilinx.com>
  Mike Rapoport <rppt@linux.ibm.com>
  Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>
  Myrtle Shah <gatecat@ds0.me>
  Nathan Chancellor <nathan@kernel.org>
  Neil Armstrong <narmstrong@baylibre.com>
  Neil Armstrong <narmstrong@baylibre.com> # for phy-meson-axg-mipi-dphy.c
  Nick Desaulniers <ndesaulniers@google.com>
  Niklas Cassel <niklas.cassel@wdc.com>
  Nishanth Menon <nm@ti.com>
  Padmanabha Srinivasaiah <treasure4paddy@gmail.com>
  Palmer Dabbelt <palmer@rivosinc.com>
  Pavel Hofman <pavel.hofman@ivitera.com>
  Pawel Dembicki <paweldembicki@gmail.com>
  Peng Liu <liupeng256@huawei.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Philippe Cornu <philippe.cornu@foss.st.com>
  Pingfan Liu <kernelfans@gmail.com>
  Pratham Pratap <quic_ppratap@quicinc.com>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Rafał Miłecki <rafal@milecki.pl>
  Reinette Chatre <reinette.chatre@intel.com>
  Rob Herring <robh@kernel.org>
  Robert Hancock <robert.hancock@calian.com>
  Robin Murphy <robin.murphy@arm.com>
  Roger Pau Monne <roger.pau@citrix.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Roman Gushchin <guro@fb.com>
  Roman Li <Roman.Li@amd.com>
  Rui Salvaterra <rsalvaterra@gmail.com>
  Sagi Grimberg <sagi@grimberg.me>
  Sam Protsenko <semen.protsenko@linaro.org>
  Sam Ravnborg <sam@ravnborg.org>
  Samuel Holland <samuel@sholland.org>
  Samuel Thibault <samuel.thibault@ens-lyon.org>
  Sascha Hauer <s.hauer@pengutronix.de>
  Sean Anderson <sean.anderson@seco.com>
  Shakeel Butt <shakeelb@google.com>
  Shawn Guo <shawnguo@kernel.org>
  Shyam Prasad N <sprasad@microsoft.com>
  Slark Xiao <slark_xiao@163.com>
  Song Liu <song@kernel.org>
  Steev Klimaszewski <steev@kali.org>
  Stefan Wahren <stefan.wahren@i2se.com>
  Stephan Brunner <s.brunner@stephan-brunner.net>
  Steve French <stfrench@microsoft.com>
  Steven Rostedt (Google) <rostedt@goodmis.org>
  Sven Peter <sven@svenpeter.dev>
  Sven Schnelle <svens@linux.ibm.com>
  Sylwester Nawrocki <s.nawrocki@samsung.com>
  Szymon Heidrich <szymon.heidrich@gmail.com>
  Tadeusz Struk <tadeusz.struk@linaro.org>
  TATSUKAWA KOSUKE (立川 江介) <tatsu-ab1@nec.com>
  Tejun Heo <tj@kernel.org>
  Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
  Thomas Gleixner <tglx@linutronix.de>
  Thomas Hellström <thomas.hellstrom@linux.intel.com>
  Thomas Zimmermann <tzimmermann@suse.de>
  Tim Harvey <tharvey@gateworks.com>
  Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
  Tommaso Merciai <tomm.merciai@gmail.com>
  Tony Lindgren <tony@atomide.com>
  Tvrtko Ursulin <tvrtko.ursulin@intel.com>
  Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
  Udipto Goswami <quic_ugoswami@quicinc.com>
  Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
  Vasily Gorbik <gor@linux.ibm.com>
  Vignesh Raghavendra <vigneshr@ti.com>
  Ville Syrjälä <ville.syrjala@linux.intel.com>
  Vineeth Vijayan <vneethv@linux.ibm.com>
  Vinod Koul <vkoul@kernel.org>
  Vlastimil Babka <vbabka@suse.cz>
  Wan Jiabing <wanjiabing@vivo.com>
  Yang Shi <shy828301@gmail.com>
  Yang Wang <KevinYang.Wang@amd.com>
  Ye Guojin <ye.guojin@zte.com.cn>
  Yizhuo Zhai <yzhai003@ucr.edu>
  Zhan Liu <Zhan.Liu@amd.com>
  Zoltán Böszörményi <zboszor@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              broken  
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  broken  
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          blocked 
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            broken  
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          blocked 
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      blocked 
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  blocked 
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  blocked 
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     blocked 
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 blocked 
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      blocked 
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary

broken-job build-arm64 broken
broken-job build-arm64-pvops broken
broken-job build-arm64-xsm broken
broken-step build-arm64-xsm host-install(4)
broken-step build-arm64 host-install(4)
broken-step build-arm64-pvops host-install(4)
broken-job test-armhf-armhf-libvirt-qcow2 broken
broken-job build-arm64-xsm broken
broken-job build-arm64-pvops broken
broken-job build-arm64 broken

Not pushing.

(No revision log; it would be 5152 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Feb 14 20:47:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 20:47:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272619.467511 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJiFR-0006ye-PG; Mon, 14 Feb 2022 20:47:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272619.467511; Mon, 14 Feb 2022 20:47:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJiFR-0006yX-MF; Mon, 14 Feb 2022 20:47:01 +0000
Received: by outflank-mailman (input) for mailman id 272619;
 Mon, 14 Feb 2022 20:47:00 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HcNt=S5=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nJiFP-0006yR-RI
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 20:47:00 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 3e6c489b-8dd7-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 21:46:57 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3e6c489b-8dd7-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644871617;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=n+xWnoUlh9HhJ3fEOyjvhXYRWmXKU2+lJ/KUpHfQ6/g=;
  b=OSdr2Y9Z81JU4eXnfASwX+GZ5X/GvEj/cgQjaxvCu9zqZnHFyrQU4oFD
   Wb8T101uzX3tSaYFHJNWpO3M8M955AE4J6Vgt4+u36GFEhfl0MzQGbGnz
   LJOZxatv1wg+JgZy05oO4BEw5X5RkFR7NiOTPZgkkvF03ysBhWz0JiOwL
   w=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: /WxbFVkmZxQI759Z3mJhL164W/hao9IRZsk42iAJXTgtmNZgasIi1uSXpLHPv0FZmUMLn+BNRz
 h+SscJGXqF2XS3M73/2OzSwNDPCV2HKfkZKUQn6Lo4Uehc1TWI0lh1+jYa7WQrVzaLP0CQD929
 FjpuK/kSIRMaKSolh2MNg1oJvjTM238BENDeARNdEmRPtO1vgycUQW+HUZ5UefGaJpz45clRvo
 eYFxeLpR7xjfcZhYqVwRV9p5TTtvCB7O3GpUXjKqDepERjMzNQBTUte2iRPQvFUGx6pFqDR3Wa
 2tgNxJiv9a70JSxZJbhv0vxN
X-SBRS: 5.1
X-MesageID: 66418031
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:EWqY4Ku2FHaxDuuA5XcAg9AqF+fnVKpZMUV32f8akzHdYApBsoF/q
 tZmKT3QP/zYNmKne9x1Oo209B9U6J/cxoViSQJp/iwyFSoR+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZQP0VOZigHtIQMsadUsxKbVIiGHdJZS5LwbZj2NYy2IThWWthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 Npl7IaCVFZ3IqH1l8sQbRJZKSpuNK8a9+qSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DFYUToHx/ixreCu4rW8vrSKTW/95Imjw3g6iiGN6AO
 ZZAOWI0NXwsZTUUGUg9T4hhvt6om0fPWCRdhmKLvqwetj27IAtZj+G2bYu9lsaxbd5Ogk+Sq
 2bC/mL4KhIXLtqSzXyC6H3ErvDLtTP2XsQVDrLQ3vx3hFyewEQDBRtQUkG0ydGph0j7V99BJ
 kg8/is1sbN05EGtVsP6XRCzvDiDpBF0c9haHvA+6QqN4rHJ+AvfDW8BJgOtc/R/6pVwH2Zzk
 AbUwZW5XlSDrYF5V1rE7IWJ/G2uNREaAmI8bi4+RhsM4YXs9dRbYg30cv5vF6u8j9vQED72w
 iyXoCVWu4j/nfLnxI3gowmZ3mvESozhC1dsu16JBj7NAhZROdb9D7FE/2Q3+hqpwGyxalCa9
 EYJlMGFhAzlJcHczXfdKAnh8VzA2hpkDNE+qQM1d3XC3270k5JGQWy3yGsgTHqFyu5eJVfUj
 Lb74Gu9HqN7MnqwdrNQaImsEcksxqWIPY27CqyLPooTP8AoL1XvEMRSiam4hT6FraTRuftnZ
 cfznTiEUR729piLPBLpHrxAgNfHNwg1xH/JRICT8vhU+eH2WZJhcp9caAHmRrlgtMus+VyJm
 /4CZ5ri40gOC4XWP3iImbP/2HhXdBDX87it8JcJHgNCSyI7cFwc5wj5n+9wJdw9x/4N/goKl
 1nkMnJlJJPErSSvAS2Ba2x5aaOpWpB6rHkhOjcrM0ru0H8mCbtDJo9FH3fuVbV4puFl09BuS
 PwJJ5eJDvhVE2yV8DUBd5jt6odlcU3z1w6JOiOkZhk5foJhGFOVqoO1IFO3+XlcFDezuOs/v
 6akilHRT60cSlkwF83Rcv+ukQ+85CBPhOJoUkLUCdBPY0GwopNyIin8g6ZvccEBIBnO3BWA0
 AOSDUtKrOXBudZtotLImbqFv8GiFO4nRhhWGGzS7LCXMyjG/zX8nd8cAbjQJT2EDTH64qSvY
 +lR3srQCvxfkQYYqZd4HpZq0bk6u4nlqYhFw1k2B37MdVmqVO9teyHUwclVu6RR7bZFog/qC
 FmX89xXNLjVasPoFFkdeFgsYuiZjKxGnzDT6bI+IVng5T8x972CCB0AMx6JgS1bDb10LIJ6n
 rtx5J9Is1Sy2kgwL9KLriFI7GDdfHUPXpIuuoweHIK22BEgzUtPYMCEByL7iH1Vhw6g7qX+z
 ueouZf/
IronPort-HdrOrdr: A9a23:FKQiP6pGlUGH+z4Dfrq827gaV5uNL9V00zEX/kB9WHVpm5Oj+f
 xGzc516farslossSkb6Ky90KnpewK5yXbsibNhfItKLzOWx1dAS7sSrbcKogeQVREWk9Q96U
 4OSdkHNDSdNykZsS++2njELz9C+qjFzEnLv5ak854Fd2gDAMsMj3YbNu/YKDwNeOAvP+tlKH
 P23Lshm9PUQwVvUi3NPAhiYwGsnayvqLvWJTo9QzI34giHij2lrJTgFQKD4xsYWzRThZ8/7G
 nsiWXCl+eemsD+7iWZ+37Y7pxQltek4MBEHtawhs8cLSipohq0Zb5mR6aJsFkO0aSSARcR4Z
 3xSiUbToJOAkDqDziISNzWqlHdOQMVmjjfIJmj8CDeSILCNWgH4oF69Pxkm1PimjsdVZdHof
 52Niuixulq5VmrplWM2/HYEx5tjUa6unwkjKoaiGFeS5IXbPtLoZUY5149KuZMIMvW0vFtLA
 BVNrCX2B+WSyLsU1nJ+m10hNC8VHU6GRmLBkAEp8yOyjBT2HR01VERysATlmoJsMtVcegK28
 3UdqBz0L1eRM4faqxwQO8HXMusE2TIBRbBKnibL1jrHLwOf3jNt5n06rMo4/zCQu1F8LIi3J
 DaFF9Iv287fEzjTcWIwZ1Q6xjIBH6wWDz8o/sur6SReoeMDYYDHRfzPWzGovHQ1cn3WPerKc
 pbEKgmd8PeEQ==
X-IronPort-AV: E=Sophos;i="5.88,368,1635220800"; 
   d="scan'208";a="66418031"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=lMgwoSPPev/ih3XYABGdPfxyFL5M1918941WpFKWtl4mcRiWxykyYUyu748FVDSddwUvZAJY9040Yspl7n/UZoJK42zKotf7bf7Lvjfcle1FPZaQOhkCygTolqSlmgLiXZmY2qfpWFdP3EZiBNWXnhjG8Txoz+43VATs8jCrENbmoCvqDXtIP9vktPnGAhsT+lvPm72dj88LCbrB5wr3oZ2KlrhS1qjMw32/wf9PdeKEdrrNOzkbHrL2kvZJxBMnjvi4kmRxKgweAWVck4oVnKHoidMXcDtkq7BTEo1AUGTKnJ+l+yfHeJiaIocAd+/v1Y45kdAAV0F2NzX8NpG8sQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=n+xWnoUlh9HhJ3fEOyjvhXYRWmXKU2+lJ/KUpHfQ6/g=;
 b=Mw5kFr2F5uFcyOdBwqQ2L75jjYEafGsBa1xeQ2KMhf2j7SRLRC5RJvR51mnwoCH2UMVP5CHKY/bpjTNhPVSRZoMTnvUNULdTaiVitNk0Irofzqw3KbdWWPGixrY3ClLpSZSeceNVdDNWM+KUvGUhZZ3SVnSfOxM1i9lq1+wA0pffcifhtPmTCCkK5t111Hrntf5xQLQ+QfElex03y+n+UcYJCuJUDU9+sQB8ByoQSSgtHuFEYIZMU8kFLFrl0XmN8efgNO5HegZu4oGnfVejLAJ8KA+hXcs5e8d3J1Kfw2Z9HwZeouF6yRWj4E4NKc+VfEafD4eMLBNXsdO+6rvt9Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=n+xWnoUlh9HhJ3fEOyjvhXYRWmXKU2+lJ/KUpHfQ6/g=;
 b=G+iOBeicZ/leMHQXMxnQ5ZRtIdRiCKg7UVPDjFhuSgVgvZEWAx4nxhRHWWGtlUAPUG98fDZ8MMmzdFcjlt3FPk5puqvcKonJql46gVBbPA1lz9oxPQAeE3S20sVM1LLma2wXrjbb3+gEpojovVVsH8J84W25fSJQMrxpeOdEUDA=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: George Dunlap <George.Dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>
Subject: Re: [PATCH 0/3] amd/msr: implement MSR_VIRT_SPEC_CTRL for HVM guests
Thread-Topic: [PATCH 0/3] amd/msr: implement MSR_VIRT_SPEC_CTRL for HVM guests
Thread-Index: AQHYF4thsK6t/XxLoUS9M7m4X3UCsayTmOKA
Date: Mon, 14 Feb 2022 20:46:50 +0000
Message-ID: <4457dcd5-6a64-355a-b794-6b404cf90335@citrix.com>
References: <20220201164651.6369-1-roger.pau@citrix.com>
In-Reply-To: <20220201164651.6369-1-roger.pau@citrix.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: bb21219b-25c4-41d2-af11-08d9effb200e
x-ms-traffictypediagnostic: DM6PR03MB5242:EE_
x-microsoft-antispam-prvs: <DM6PR03MB5242C00BB559F0EDB2CE8510BA339@DM6PR03MB5242.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: KsMChuWU15GiRBm36PnoWUJLpLeStr5l7SXA65+2K9j9QjTkcp70aSjsotxjcIUGD5ehWoeOMLUyoNRU+0gqJmvTxFeQ7bteZSCPOnbNn7OvUiwP8d617w1rWJ0ad7DPREx4O0UuDWbr3IQr0HdvCNA7H2VDA/OatK0gj/E6FfbM1gMs7j7sHVC9sRt8h285l8WPX1a5TTCNn80e5+AJNUbKygNsaiTD2Tkd3tyTZR7dCGLvcaeqo1Uz2oNhcMmHjaYY8hz74Tz4XEBjNaBf5NM5ZKAi5NBRlzuolPfogAbKitjY4QtXJmOOj6414a8hVTqyERFl7pyfmYnKJCiTr76/DTuXUoozRvypINZVKLxfqcgR2iUCPXbIpOaYcv60y6JDVlsE0F8+bCI7J2JxCok4+cGgL6RM0aZLIb2zZ4N5Gswe4VSP5O8tBr12rUWQCIMMKgFVjbBL3u2N6TyFUh/1RgF+3+P7JU844hN/s78hmzON1XUjntcb/cO6T6Fbhbiuch1CbLk9GNJcZYHm1q7a0/edHkWaes5gdz3h7PB0Gvgzjhe0UWTPfRPtHwmVa6qgthsqW1GgoMCgR14Vg/L4359KKjbVQgz48GzKRtLGZJO+9z4l4HrUS9uunzyjVg8DFqUoVasIUFohsbdXr6F68eKZHc3iZnmwms4yykBWwHgVne1UZKT7nZK8js5TOIaze68XiVP8nl3yMDUpysMgsthOjwP/8/UGGKgC/vwHyA4kALNfIB0aW8RullsMPMTn610F/LbK5EUzi+tjew==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(36756003)(2616005)(5660300002)(66946007)(2906002)(31696002)(186003)(8936002)(38100700002)(26005)(38070700005)(76116006)(66556008)(53546011)(8676002)(4326008)(64756008)(66446008)(66476007)(82960400001)(122000001)(110136005)(6506007)(316002)(508600001)(54906003)(91956017)(86362001)(31686004)(6512007)(6486002)(71200400001)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?SzBnMGRKVDJFeVY3aVhtTkdkd0tXOG1WUjFZSmM0eGNqSmJiMTc5KzZueVVG?=
 =?utf-8?B?MUVQVG1HRmxZcWJhaVNBbmN4VUgwOTQwMGg4eDdUTE9JWUtkVVNFVmtENk0w?=
 =?utf-8?B?MHhuYmpSSVF2NWR6c0RlQTQ1azlVN3laYmVDeExiSGxCTmdIZFZEVlJOU25V?=
 =?utf-8?B?NEZUQzBjV1d6VU91Uktpai9LMXJiTzlDYVphZkViM1ZoVGlJaU5rVktDTjcv?=
 =?utf-8?B?TDNteHBpck96OEtJeHV2WXNZTVVHOWNvbWNjanJ6Nm1vWXB6dGdoMWVMTXJl?=
 =?utf-8?B?QWt0ZnRGWUVTZzdZNDJZMllSYys2S09zcmJaOFNtM1ROL2hnOXhFdXY2ekJX?=
 =?utf-8?B?VElZSjVtQ1ozdnZxYjR1ZmQ4YWZOeDNoNksxYzlzZzlEcmQraVg2TmthZmYz?=
 =?utf-8?B?Z2h4QklPaW1BZE9LdmxWZk8ybDdJQmwyUnM4aGhaRzFCbXZ3QU9RR0J3RzZ3?=
 =?utf-8?B?bjlteDZJM0orZWs5c3IrM2xGVHpFNDZ2TE9Pd0t5a3JWaTZ2Qjdtc1ZJLy9Q?=
 =?utf-8?B?bGpzU0xBaWV4c1M1QSs2cVdQUW0vRVZpZmV0c3dXaUxTUlY2SjdZdHJBWitX?=
 =?utf-8?B?cVBNK2Ewb0RXMkRXWFg0cGVXdWNqVlpwQmNZS1FCc3NGME5hbnBldUVvdjBH?=
 =?utf-8?B?QUlwWWsxRlplZ1BmQzJSMjUxN2ZEQmtjU0pmaGFMK3Q2QmNyVE1qYXljM0Fx?=
 =?utf-8?B?dGdId1pVak9OK0Y4M29HL0NqOCs4c0xFN0NmQ0VkK0dRQmRYV0lPRU9HVVA1?=
 =?utf-8?B?WGI3NkJINytPb2pXV2orTkU2N3F3VjZyMU9xWjBvTVlPa0tNR1ZrTmlUQnZC?=
 =?utf-8?B?MXBiRDR1a2ZHR0h0amgxME90RFRweWJlakdUYzJPeGo0RnRmL0EvM1hib3Q4?=
 =?utf-8?B?b1hrNEFEVFBzRFNHdWg5UVVSZ3M4emsvbis2VHNVYlJrSVdRUFFhNGhsMlpK?=
 =?utf-8?B?UGdEU2FEZ3lONTJIaG5vNmoreEZlV01uajRBN1lBS3hLNU1ZTERKTGlsdjl5?=
 =?utf-8?B?TzhFZ0h4WmtHb0tRb2ZtSGtqVzR0azlEY1pCUHVIbS8rZ1pZeUsyUzcrSU43?=
 =?utf-8?B?NWg5MlFlSjJzY21tV0ZpRzJXdmNjalJrY3JzU2QvNXd6MGpybCtWTjlGbHhk?=
 =?utf-8?B?d3dQNVRXbERJSTRhckR6Q0hjdmNmRnRkKzNKd1RRREtHbzViUXFxblJKc1Ni?=
 =?utf-8?B?NHRlanhkNS82dHhvV0pnYWJob094SWFBakkramhHZ3Ava1pVcy9JWnhYVFAx?=
 =?utf-8?B?TjEySUd5QkFNR0tVYU4vQUNZSitseUU2V2xHcVpZaWVnbXNzSXhNNTdaMFVS?=
 =?utf-8?B?MnBzaGp0VmJxbERmV1lzWHpZTS92OGo0bk5rcVRlUUhTZDNOaG5PdnNjWmph?=
 =?utf-8?B?YjgwVnF1K2J6VEZ1YjRzcnRKU3RjcC9CM1FLR29rYkd5elJBMEl3dVNFd0NX?=
 =?utf-8?B?YUthUW1iMHlBQU5xdWNKY3pzUkxmSDZCTW1kQ0J0cHU0NnI1YjUvQmpmdVYv?=
 =?utf-8?B?QmIyK0h3MlZSd3pqQmZkdHVkekRDZVVUbjNldXJZWnhUMVdVSitCc2Rrbk1X?=
 =?utf-8?B?dGpkUXkvSHZUemlqQVBINll2VU94aTRXbEVQbjdOaWNNcG8wYUFLY3d3NTlE?=
 =?utf-8?B?bzV1NGg3ZHYrbkR5Q01KRm1TNitQS0RQRFVITjBJWnFqSmxpVWNGRkNvTnJm?=
 =?utf-8?B?S0dEdUpMSkViSzlQUlI0S01NZ1pwemVZUUhEVWVtVFFYOFJRTkM5a2RRc2VO?=
 =?utf-8?B?bVZpaG1ndWQvMkJ5S05NeWh1aG1FZHJoRzR4cnpSZENqNDFVbG83R3dQNU1Z?=
 =?utf-8?B?SmY1cWNYM3dualpPM1piaHZrZlB6RlNDQlVTK1duRlNZVTdSU2lUY0YyOG1I?=
 =?utf-8?B?cUExWTdiZ0Jwa2c4NlVFMDdWdXpkUmdkMUlaZTdCZVM3a1RiUFVXd3oza2Rx?=
 =?utf-8?B?RlRLWjZiLzN1UGloc3FPNEhqaGlJVTZCRUxFb1ZtdkxpRkwvS3VaWmtSeFJL?=
 =?utf-8?B?L1pQZnBnTEJRYndyNHMyRUpWQzJhSUNheDdLMWhqeE0zWldkWnM5TlROeFdt?=
 =?utf-8?B?aEJVRDlva29ML0VXVHdlQWNtYXhVSXZuRWgvTEZyb1VmRE5qT0lmaHJTUjhM?=
 =?utf-8?B?UWZCbGZRcmY0ZFFFSTJJdnJYYUZrRUZTeWZjR3I2SnpvN0N1NUVtQlVkMWN5?=
 =?utf-8?B?bS8vM1g4R2piR0RhRmtCcmk5di9DdXlDNXhGdDNuVEdDeXJqMmNuMkttTXVL?=
 =?utf-8?B?emdqOVNhMDdFKzZBRVBVK3cxcitBPT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <495E3C2D08351342B62993CD134270FA@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bb21219b-25c4-41d2-af11-08d9effb200e
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Feb 2022 20:46:50.1736
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: CX59d+WtizBw7ygDwbK3c5XLxcRGBUmukHXj4cyNBXNWM/erzh1Dcr2XgTDXqEgPNLNCsIiZIevHAO568Znz5wRB6py2snU4ynovs+xnG0o=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5242
X-OriginatorOrg: citrix.com

T24gMDEvMDIvMjAyMiAxNjo0NiwgUm9nZXIgUGF1IE1vbm5lIHdyb3RlOg0KPiBIZWxsbywNCj4N
Cj4gVGhlIGZvbGxvd2luZyBzZXJpZXMgaW1wbGVtZW50cyBzdXBwb3J0IGZvciBNU1JfVklSVF9T
UEVDX0NUUkwgb24NCj4gZGlmZmVyZW50IEFNRCBDUFUgZmFtaWxpZXMuDQo+DQo+IE5vdGUgdGhh
dCB0aGUgc3VwcG9ydCBpcyBhZGRlZCBiYWNrd2FyZHMsIHN0YXJ0aW5nIHdpdGggdGhlIG5ld2Vy
IENQVXMNCj4gdGhhdCBzdXBwb3J0IE1TUl9TUEVDX0NUUkwgYW5kIG1vdmluZyB0byB0aGUgb2xk
ZXIgb25lcyBlaXRoZXIgdXNpbmcNCj4gTVNSX1ZJUlRfU1BFQ19DVFJMIG9yIHRoZSBTU0JEIGJp
dCBpbiBMU19DRkcuDQo+DQo+IEZpcnN0IHBhdGNoIGlzIHF1aXRlIGNsZWFuLCBhcyBpdCB1c2Vz
IHRoZSBzaGFkb3cgU1BFQ19DVFJMIGluIG9yZGVyIHRvDQo+IHNldCB0aGUgU1NCRCBiaXQgYW5k
IGhhdmUgaXQgY29udGV4dCBzd2l0Y2hlZCBieSBYZW4gdXNpbmcgdGhlIGV4aXN0aW5nDQo+IGxv
Z2ljIHJlY2VudGx5IGFkZGVkLg0KPg0KPiBUaGUgbmV4dCB0d28gcGF0Y2hlcyBpbnRyb2R1Y2Ug
YSBkaWZmZXJlbnQgd2F5IHRvIGNvbnRleHQgc3dpdGNoIFNTQkQNCj4gZWl0aGVyIGRlcGVuZGlu
ZyBvbiB0aGUgdW5kZXJseWluZyBTU0JEIHN1cHBvcnQsIHNvIGl0J3MgZWl0aGVyIHVzaW5nDQo+
IFZJUlRfU1BFQ19DVFJMIG9yIHRoZSBMU19DRkcgTVNSLiBUaGV5IGFsc28ga2luZCBvZiBvdmVy
bG9hZCB0aGUgdXNhZ2Ugb2YNCj4gc2V2ZXJhbCBzcGVjX2N0cmwgdmFyaWFibGVzIGluIHRoZSBo
eXBlcnZpc29yIGluIG9yZGVyIHRvIHN0b3JlIHRoZQ0KPiBzdGF0dXMgb2YgU1NCRCBldmVuIHdo
ZW4gbm90IHVzaW5nIE1TUl9TUEVDX0NUUkwgaXRzZWxmLiBJJ3ZlIHRyaWVkIHRvDQo+IGRvY3Vt
ZW50IHRob3NlIGluIHRoZSBjb21taXQgbWVzc2FnZXMsIGJ1dCBpdCBjb3VsZCBiZSBjb250cm92
ZXJzaWFsLg0KPg0KPiBUaGFua3MsIFJvZ2VyLg0KDQpJIHN1c3BlY3QgaXQgd291bGQgaGVscCBy
ZXZpZXdpbmcgdGhpbmdzIHRvIHN0YXRlIHdoYXQgdGhlIGVuZCByZXN1bHQgaXMNCmludGVuZGVk
IHRvIGJlLg0KDQoxKSBYZW4gc2hvdWxkIHVzZSB0aGUgQU1EIHByb3ZpZGVkIGFsZ29yaXRobSBm
b3IgZW5nYWdpbmcgU1NCRCBpdHNlbGYuwqANClRoaXMgaW5jbHVkZXMgdXNpbmcgTVNSX1ZJUlRf
U1BFQ19DVFJMIGlmIFhlbiBpcyBuZXN0ZWQgdW5kZXIgYW5vdGhlcg0KaHlwZXJ2aXNvci7CoCBJ
biB0aGUgY3VycmVudCBjb2RlLCB0aGlzIGlzIGltcGxlbWVudGVkIGJ5IGFtZF9pbml0X3NzYmQo
KQ0KZXZlbiBpZiBvbmx5IGxpbWl0ZWQgdG8gYm9vdCBwYXRocyBmb3Igc2ltcGxpY2l0eS4NCg0K
MikgT24gRmFtMTVoIHRocnUgWmVuMSwgWGVuIHNob3VsZCBleHBvc2UgTVNSX1ZJUlRfU1BFQ19D
VFJMIHRvIGd1ZXN0cw0KYnkgZGVmYXVsdCB0byBhYnN0cmFjdCBhd2F5IHRoZSBtb2RlbCBhbmQv
b3IgaHlwZXJ2aXNvciBzcGVjaWZpYw0KZGlmZmVyZW5jZXMgYXdheSBpbiBNU1JfTFNfQ0ZHL01T
Ul9WSVJUX1NQRUNfQ1RSTC4NCg0KMykgT24gWmVuMiBhbmQgbGF0ZXIsIE1TUl9TUEVDX0NUUkwg
ZXhpc3RzIGFuZCBzaG91bGQgYmUgdXNlZCBpbg0KcHJlZmVyZW5jZS7CoCBIb3dldmVyLCBmb3Ig
bWlncmF0aW9uIGNvbXBhdGliaWxpdHksIFhlbiBzaG91bGQgYmUgY2FwYWJsZQ0Kb2Ygb2ZmZXJp
bmcgTVNSX1ZJUlRfU1BFQ19DVFJMIHRvIGd1ZXN0cyAobWF4LCBub3QgZGVmYXVsdCkgaW1wbGVt
ZW50ZWQNCmluIHRlcm1zIG9mIE1TUl9TUEVDX0NUUkwuDQoNClRoaXMgd2F5LCBhIFZNIGxldmVs
bGVkIHRvIHJ1biBvbiBaZW4xIGFuZCBaZW4yIHNlZXMgTVNSX1ZJUlRfU1BFQ19DVFJMDQphbmQg
Y2FuIHVzZSBpdCBvbiBib3RoIGhvc3RzLCB3aGVyZWFzIGEgVk0gb25seSBpbnRlbmRpbmcgdG8g
cnVuIG9uIFplbjINCmdldHMgTVNSX1NQRUNfQ1RSTCBieSBkZWZhdWx0Lg0KDQpPYnZpb3VzbHkg
dGhpcyBtZWFucyB0aGF0IGEgVk0gb24gWmVuMiBjYW4gb3B0IGluIHRvIE1TUl9WSVJUX1NQRUNf
Q1RSTA0KYmVjYXVzZSBvZiBob3cgbWF4IHZzIGRlZmF1bHQgd29ya3MgYW5kIHRoaXMgaXMgYSBs
ZWdhbCBjb25maWd1cmF0aW9uLA0KZXZlbiBpZiBpdCdzIG5vdCBvbmUgeW91J2QgZXhwZWN0IHRv
IHNlZSBvdXRzaWRlIG9mIHRlc3Rpbmcgc2NlbmFyaW9zLg0KDQp+QW5kcmV3DQo=


From xen-devel-bounces@lists.xenproject.org Mon Feb 14 21:31:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 21:31:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272629.467522 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJiwJ-0003dw-11; Mon, 14 Feb 2022 21:31:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272629.467522; Mon, 14 Feb 2022 21:31:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJiwI-0003dp-UN; Mon, 14 Feb 2022 21:31:18 +0000
Received: by outflank-mailman (input) for mailman id 272629;
 Mon, 14 Feb 2022 21:31:17 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qPn=S5=citrix.com=George.Dunlap@srs-se1.protection.inumbo.net>)
 id 1nJiwH-0003dj-Do
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 21:31:17 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6f2f2b69-8ddd-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 22:31:15 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6f2f2b69-8ddd-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644874275;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:mime-version;
  bh=CDfkRo9tfiDg+IG+bGq+AYSj/W3U3Qi0b3q7MpT1dz4=;
  b=DiDTD9L39wGSpXXFoHNYXPXGoebQZ4bxN5Es1KixKmyv5GdroZDSX2Dd
   IMabUklhJMojx1T4boiKzA2IzAmRwkwybLg9Pwkcd7Xs+zlROK5K0Mawq
   S89I7uJAijnDRRZoQYRBp24iUj6k6rTFTgHsKRTGiYV/EAlPz8m4ayGQ0
   g=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=hardfail (body hash did not verify [final]) header.i=@citrix.onmicrosoft.com
IronPort-SDR: VpamOoaS6BoOMszqgHq2+itJ/Yp6++HoKiAYQ9pPHGXsx99HeOUygDK9IWkED5/1WBROnqUaFL
 5TabfW4NV+rYX6PAixq303sw+krwI302R5fyNYfFNSSttFeQGkv3F7LWkdbMrmdZ6uApEClprI
 bNv1jaTjkRDSTTj9ePmEq7jmdGalHz9szhfP0tdnYTakE6K9OW37qS9r/pqg9FoSYELjdZSMCT
 SimIBMHTcqZiVWuaj8dnJHYRkCrvouaiVrjOjwE/EcSY/+AGH3sm9CrBxmI/9iAUIW3im2bwWI
 u9fh75bdS1wpJ9yTDKtd9lBX
X-SBRS: 5.1
X-MesageID: 64093813
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:lBjkW6JHqlD8YlJDFE+RFZMlxSXFcZb7ZxGr2PjLsTEM7AuW5UVEl
 zVBCC3DeKqUMyGmS21FGIu/oEpSvcTTyYNhSFBr+y4yHygQo5LJDovGckygYijKc8eYEkhsv
 5RHOoOYc5loFS/WrUf2PObqoCQk2PHUS+aU5IIoQsxUbVYMpHAJ1UIz8wJAvrNVvDSZP++sk
 YOu/MfSaQD6gG4sO29I5fjY9hk/7KupsT9E41dvO/4S7QPSz3UbMskSdPq7R5farii4PQIYq
 8LrluzRErbxpk91Yj+dfzKSnnQiGtY+ByDX4pZtc/Xk0kgqShAaiP5hbqJGMBsP0V1lovgqo
 Dlznc3oIesWFvWkdNQ1C3G0xAknYMWqUJeeSZSOmZT7I3/uKhMA8N03ZK0CBqUK+/4fPI173
 adwxAbhzPy0r7neLLqTEoGAjym4RSXhFNt3VnpIlVk1ARu6KHxqrmqjCdJwhV8Nas5y8fn2I
 JAhYitsSEv5QgR/BX0nGa8vsbqxryyqG9FYgAr9Sasf5mHSyEp60aT3McqTcduPLSlXth/G/
 CScpT2/W0xEcozEodaG2ivEauvnsi78Qo0fUpGl8PpjmHWYx3AJCQ1QXly+yRW8ohDiA4MEe
 xVPksYohYgQpReMXuvEZgaf/VSWuQJAVNRdL+JvvWlhzYKLul3EVwDoVAVpc8c6vcU7QTgr0
 F6hnN7zAzFr9rqPRhq19KqQrD60ETgYKykFfyBsZQAC5tzivJ0+lAnnXttlCLSyjND+BXf32
 T/ihDc6r6Uei4gMzarT1VHYgRq8q57RVAk36w7LGGW/4WtRYYe/YoWy5Fvz7PBeLZ2YRF2Mo
 HgFnceF6OkES5qKkUSlQu8AAbWo7PatKyDHjBhkGJxJ3ySg/TuvcJ5d5Bl6JVx1KYAUdDnxe
 kjRtAhNophJMxOXgbRfOtzrTZ5wlO65SIqjBqu8gsdyjoZZM1W/9zBtQRGp/nndr2IcgJwuF
 MqCWJP5ZZoFMphPwD2zTuYb9LYkwCEi2G/eLazGIwSbPam2PyDMF+pcWLeaRqVgtf7f/l2Jm
 zpKH5bSk31ivPvCjj47GGL5BXQDNjAFCJ//sKS7ncbTc1M9SAnN5xI8qI7NmrCJfYwIzI8kH
 VnnAye0LWYTYlWdd223hohLMu+HYHqFkVo1PDY3IXGj0GU5bICk4c83LsVrIeZ3pLE+lacvF
 ZHpnvls5dwVFFz6F8k1N8Gh/OSOijz37e5xA8ZVSGdmJMMxL+A40tTlYhHu5EEz4tmf7qMDT
 0mb/lqDG/IrHl06ZO6PMa7H5w7h7BA1xbMpN2OVc4Y7RakZ2NUzQwTrkOQNKt0BQT2agGPyO
 /C+WkxD+4EgYuYdrbH0uExzh9n1QrUuRhIARwE2L9+ebEHnw4Zq+qcdOM6gdjHBTmLkvqKkY
 ORe1fbnN/Mb2l1NtuJB/3xDl8rSPvPj+O1XyBpKBnLOYwj5A79sOCDej8JOqrdM1vlSvg7vA
 hCD/dxTOLOoPsL5EQFOeFp5P7rbjfxEyCPP6fkVIVnh4HMl9rSwTkgPbQKHjzZQLeUpPdp9k
 /shosMf9ye2lgEuboSdlilR+mnVdi4AXqwru4s0GojujgZ3mFhObYaFUn394Y2VasUKOU4ve
 2fGiK3HjrVa50zDb3tsSiSdgbsD3cwD4UkYwkUDKlKFnsv+qsU2hBABoy4qSgl1zwlc174hM
 GZcKEAod76F+C1lhZYfUjn0SR1BHhCQ5mf410ANyD/CV0CtW2HAcD89NOKK8BxL+m5QZGEGr
 rSRyWKjWjf2ZsDhmCA1XBc9+fDkSNVw8CzEmdymQJvZT8VrP2K9j//8f3cMpjvmHdg11R/Oq
 uRd9eptbbH2aHwLqKohBojGjbkdRXho/oCZrS2NKE/RIVzhRQ==
IronPort-HdrOrdr: A9a23:nB4zR6mMVxG98QDeN59Es/kLrazpDfObimdD5ihNYBxZY6Wkfp
 +V88jzhCWZtN9OYhwdcIi7SdS9qXO1z+8R3WBjB8bfYOCGghrmEGgG1+XfKlLbalTDH4JmpM
 Rdmu1FeafN5DtB/IjHCWuDYq4dKbC8mcjC74a/854ud3AQV0gJ1XYgNu/xKDwTeOAyP+teKH
 Pq3Lshm9PPQwV0Uu2LQl0+G8TTrdzCk5zrJTQcAQQ81QWIhTS0rJbnDhmxxH4lInJy6IZn1V
 KAvx3y562lvf3+4ATbzXXv45Nfn8ak4sdfBfaLltMeJlzX+0aVjcVaKv6/VQIO0aSSAWUR4Z
 3xStAbToNOAkbqDyOISN3Wqk/dOXgVmibfIBSj8ATeSITCNUwH4ox69Nlkm1LimjodlcA536
 RR022DsZ1LSRvGgSTm/tDNEwpnj0yuvBMZ4KQuZ+w2a/puVFZ9l/1WwKpuKuZKIMs60vFSLM
 B+SMXHoPpGe1KTaH7U+mFp3dy3R3w2WhOLWFILtMCZ2yVf2CkR9TpV+OUP2nMbsJ4tQZhN4O
 rJdqxuibFVV8cTKaZwHv0IT8e7AnHEBRjMLGWRK1L6E7xvAQOBl7fnpLEuoO26cp0By5U/3J
 zHTVNDrGY3P1njDMWftac7uywlgF/NKwgF5vsulaSRi4eMM4YDaxfzO2zGu/HQ1skiPg==
X-IronPort-AV: E=Sophos;i="5.88,368,1635220800"; 
   d="asc'?scan'208";a="64093813"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ZJ340nc+21kDQLSfE5ywywusYnzLYLj58W8O2MYCYo9v0oW60+hXnv2g4JHQUfylkFNKH+y0pxvtRKEFffH5cDdmMSd+ZOZ7OwizHQHS5XgvBGQLaRjHPM/vAOjwtqC8FdvrKvA2DRug03tFka74Jy9vGx+2JCaddHU3mIJtYIpRVEidQ5RS2LjEBEti/BxELevXKFaigpzt8t5zBPFVpDi5ve1piQUl7b0ZwmcIm9kFIxnA4nbJAoWex+ZHpJIVvuqlSWcbNKtgei4mgRJ6T6fTZu2vCaZpNKsmxFioJAcS1tGzNKC7pdwuv2/2UU+6xJUzfeU91FkrWPZk9aYYCw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=AcJI9aolRJt2kqZTiLW+R2cEOacMt6seQj0BePZvVcY=;
 b=DysxIMDMeVL5T8HXhNLE8Gfezom7f1eJ5a5lU6KPmBCEPI+zdF0phtmP6YIWTwjUNr1/fX729dwYEwBM7D2gAoBeX4803vePoE7z1+3BqPV7rLi6Cw4E+bsvK084eiYbi5p4fvTFQhl2OB1is0VsGlA7UUgfIOwV/vrjSaTagIX8QTJpTwxSnVH7dxzuk7gf+lws0dfIL5q69fyuDirDfyIRH2i9eT593/lPASomitipcqDROmLJWhl0EwC15nyBTJfo9XrIpBi7fqFy+uVeghehxhQZNnhMYcPgkkp+7ersvRM5PFGS7iVqX8Lkg+9XlcFAVgHjIYqzgCCgFPN/tQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=AcJI9aolRJt2kqZTiLW+R2cEOacMt6seQj0BePZvVcY=;
 b=frOfN6zpet+7/LfqRC0Q71BFeZ/9AwNiybKwmw7/NZXQzAUDG49SCcaBsqREn2cT6owoSHG5jgWgQkDndWi9/rGknYLZXHJpPF+UYCO41h8BFm8/8eJJSeDT8pqpK1W141CTjLdo6q7HfEtvbbDGd3Vrb5RaVgooOHSQI4zotLo=
From: George Dunlap <George.Dunlap@citrix.com>
To: =?utf-8?B?TWFyZWsgTWFyY3p5a293c2tpLUfDs3JlY2tp?=
	<marmarek@invisiblethingslab.com>
CC: Ian Jackson <iwj@xenproject.org>, xen-devel
	<xen-devel@lists.xenproject.org>, Andrew Cooper <Andrew.Cooper3@citrix.com>,
	Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
	"committers@xenproject.org" <committers@xenproject.org>
Subject: Re: [PATCH] RFC: Version support policy
Thread-Topic: [PATCH] RFC: Version support policy
Thread-Index: AQHXkDev9/QrG+8IgUOEs2JU9EeShqt5JH4AgRuPbIA=
Date: Mon, 14 Feb 2022 21:31:08 +0000
Message-ID: <2C342C85-8CBF-43EF-A6AC-9781D62EAB8E@citrix.com>
References: <20210813113727.6028-1-iwj@xenproject.org>
 <YRzsAvOU5G2O1X2+@mail-itl>
In-Reply-To: <YRzsAvOU5G2O1X2+@mail-itl>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3693.60.0.1.1)
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 9ef43d5e-fb92-467a-4f34-08d9f00150ce
x-ms-traffictypediagnostic: DS7PR03MB5655:EE_
x-microsoft-antispam-prvs: <DS7PR03MB5655A0C56C191B99832C254199339@DS7PR03MB5655.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:3968;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: RMRF5HxiDBBABtf3O1ijhFwJ6PLP9QWMGyNKLItTqI9UgMPa7ZGvH7gpxvsIGJc5lE4HAFuXvFSJIkm/dJV55Jh1nmWr3MxVMvfEeAoSb4efkI1OLXwKEClG7yt4xQg+3v3x2mbYx6FPsWo/bOkaa8uIEMauKxEXMLgmveczEquBKrMpQJxVMrUcs77xZOFIKMFeAusddYrzNtGmehCdXZWOIWDq4cvbeB2MxoF8lJeed2rrOp/0Fdjj9f6qu2ZcOUKrtsDNyO5FQkLyj/nFOQUE+fi+543ylexed9BnbgdLNhEMqWoKpKGsWAoeQ0W/81DaaM4UeHdij+ZjsHDh4qVp7wMVh8USAyP0/g6ZYVFgrNP+I1JUCVgcyZXqLRVHJ4pB4h93+iAte5YgvS+AHVDXlhdoflRl3rCNp/0V+OUGtEBJWi1FWnlCDTFWCOMsVJwRE+AVwne5mWD7xcOC2YQxLMoXVh4oQVw/HeotPAt/JZnuqSgTAlFkYuTHZ2ueaz2d1ingBBFex9ieipRdf5JqWOumhx4U6l/r5o/8RjLz+49LEMjpAK8QmKxWh5yNmqcvARX0W2trDcsHMuCpNFafn9Wdk7ahpXA624OX6cqcC8DhIKNUuf60DblVcwBotO2ZGe+m5W8XtCIlQo7/+EKv8bT5KWwlrfmaSAwt0mnddRiithRFBaAgKsTYclgZmu8GFuNO5vn5crsohmz94d/Bi5Zm10WrGKm7PJHfR5uZsyFXsfrvsh6gncuyDkuL
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(2906002)(6512007)(53546011)(6506007)(2616005)(26005)(186003)(66574015)(33656002)(508600001)(4326008)(8676002)(66946007)(66556008)(66476007)(316002)(36756003)(54906003)(8936002)(64756008)(66446008)(86362001)(6916009)(6486002)(91956017)(38070700005)(71200400001)(99936003)(76116006)(5660300002)(38100700002)(122000001)(82960400001)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?WkR4L0h1ZTVXbnYyWVZpK29MWURxbEw0cGg5WkpLc0RlL3lhMHlIZ2gyM3Mx?=
 =?utf-8?B?QjBMZndWMnVwTkF2L0R1eHh0RktIeUNQRHExaWRGS2dNK05DVWJhN0g3dXgv?=
 =?utf-8?B?cDAva0k1RHhnMitPVDdPdkhMVUt1enZnZ2dDdTIvYWl5dU5PVVYzWFYrRGpR?=
 =?utf-8?B?VTVVQTVMcXZSZmpsRWZaNEpEc0tub1dFN0J3T3ZVc252UW5HSHlxTVVtZ3Qv?=
 =?utf-8?B?K2dyVlA3SDIzMExxMXdVQlNzVnZyeTZqQW5oWU54NEY4QWt5R2JVU1FkNUc5?=
 =?utf-8?B?WGpLblhYUldPZ3p1elhKelFRRy9HQlVYeW1GWW9yR0x6WVhxV01aTUZRMDRP?=
 =?utf-8?B?NGp0ZUxoa25wRnZKdFd0SXV2ckdSSEtneXZSUVArS29HM2tUemk5RWlNVE5j?=
 =?utf-8?B?M0F6Z0lXZzVUN1k5L1RuTWtNRUwrSk1JWXFHN0xQemw4SGRTMGE4U1hydFpy?=
 =?utf-8?B?YUQ3QVpUY0FmZERvNzhHWmhsU0ZpUDR0U3J2VXJhck9NR1dkYVdQVHZRNHNo?=
 =?utf-8?B?QnV1OGI4RnhxMmxCVDVXOFRpdndRaG96S2NUMGRYVW1rR3lQV1dGWDc3Ry9G?=
 =?utf-8?B?MVEyVHBBTnM5Vm9rUDhCOUdmVmNLQks4QnI5ZTZ5bHFmaUwxQ08zZUUrU2Vt?=
 =?utf-8?B?ZlUrVmF3dEJBdzEzeTNRcU5pbVlHbmdjVGZXWmtxQ3V3dGk3YUlVdVRXZEQy?=
 =?utf-8?B?a2xkbWtMTGZMRUpHYnRqZjcrdG82elh1ZmlCOWhHekVrV29nVmYwMXdvV3k2?=
 =?utf-8?B?bGZSRVlHa3NkbDZzbm9iUFNQQlRVZ1pqRmlDM2YxQkxXdFFncDRlc1lxS3Zr?=
 =?utf-8?B?TWtXeHpRclhpeUg0VHZtZGV4OGNTVkVrUTc2cWF0WnR3YkxwNmttbWQrTHlI?=
 =?utf-8?B?bVExUUpCVGpYcXM0QkxLOGVhRUYvNlFHaVdmM3pOMGVUc3ArdFQwU2xDS3hq?=
 =?utf-8?B?bFI1QitpbG5hZWExL0dHdTRObmJpckg0aGdPblFaTjZvemF0R2N2ZlRGZTUr?=
 =?utf-8?B?Vno5L255SXpDZkhISm5OTmdkU3RQZ3hudDYyd0lpNnE1NWdhZmZ4dDZ1aXdT?=
 =?utf-8?B?RzhtcitsczlRYTFiNFJCTmNmc3lLS045WG5obHNxblQvdnhJdWlZNkxGa29r?=
 =?utf-8?B?L25sL2I4T20xVzk3RDBkeVM4YkRXSXduSTFJdlY4KzQxTS9SaDZqaHI2VjAw?=
 =?utf-8?B?cVFMbGsxZTJCdzBrc0NvalpNeWtsK2tnRU5UWlh1QXRBaVRBckNCZVNDWDky?=
 =?utf-8?B?NmdkdlJrVjRIcWV5ck9SUWVLcFNOeUcrYmQzTmxGSkxaMVZCQlBhN3VpY0o0?=
 =?utf-8?B?eklsdy9SVmxZeUVFeitrRFlUK3JKNVJ1Y1N3L2RlaHJsOFRXdXNKSWZqSWhr?=
 =?utf-8?B?OXZBVDJrdDVjUjJxQ053dzFZMXkwU21IZXRISUYvLzZDcmg1VVRaelhSZkhC?=
 =?utf-8?B?eVFhcDU2MWd6QWpOOTliU21KcnYxQU5KcGVoSlp6Q0cyRi95MjRsSWNyU3h1?=
 =?utf-8?B?dW83YnExekJvNGg2ZzdJNjd3V2MrMWtlNEEzbkkvcWQ1V3NBMnV5REkvU3RT?=
 =?utf-8?B?V0ZPaFVPTHhtdWk3eUU3L0Zqbk5LODJMS1NQZzJSTmU5UTJxelhTaXUwd3pl?=
 =?utf-8?B?VkZYbHM1UUhIRDdLRjcxdnFOUm16Tkl1OWdieExheGdFQmd1L2ovSzN4Mzh3?=
 =?utf-8?B?ZEU4N204THkzV2ZmMThqazFNMEZvUVJxZDZjb3l6MlZzQnhWVytyYm8xL0ZD?=
 =?utf-8?B?MjZiWUZnVUY2d2prazJlZUF0L0ZlODdXSFNTTlg5VzJVNjdJR1dVc1gxSGR4?=
 =?utf-8?B?NXpWUk5Bd0k5TFpFZ0YweTMrdTVqK2xVeUpod0RRc2c3dC9iRjRub24wWlFC?=
 =?utf-8?B?eXh5NUZnbDNacjk1eDdvd2x6YmpNWURNRmtnU1NEUUpHZ25Qa3BMY1ovbnRT?=
 =?utf-8?B?MG1JK2J1T3E3amV5YnV0SytzVlZQMVpkZytyWjJDb3BkaFNoa2FsaEhja0Fi?=
 =?utf-8?B?STVudXRqSllQcGhPcTdUclZXR0QxbThxcHJRK0YrUEJ1NWlYWkZVRGUyeXhN?=
 =?utf-8?B?MkpmQmZRZEV0dlJZRUJlV1F4UlZaKysxQ3JjZyt6V21ieHMzZTc5QTczUSta?=
 =?utf-8?B?OWRzNG1ud1BmY3Q1TTE3TlE5UWxoUmJxOUx1MUVYTUJBOXVaaFNua2RjRDFm?=
 =?utf-8?B?SVRBbktiSlljZXBRSjRoY3Y5MUd1dTg2QjlMRWZ6UU4zYlBXTG1SUWdqaWl5?=
 =?utf-8?Q?m8QhyFmaNmKxzX1+ySd0c2Oe+dp8xT5xY4abV8TX9o=3D?=
Content-Type: multipart/signed;
	boundary="Apple-Mail=_D97B7FE4-B590-46A8-AEDF-7570EF923B61";
	protocol="application/pgp-signature";
	micalg=pgp-sha512
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9ef43d5e-fb92-467a-4f34-08d9f00150ce
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Feb 2022 21:31:08.9873
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: opoSZgCuNoPfCf2vqJZ/BKu0VNBSwDgz+7bEHiGJGIqYYvlpOVEeOrLiN2CSXdCwBAfnVRMcIaPMaehsTySwqzrN/gfTkl+/I4LteCbBkV8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5655
X-OriginatorOrg: citrix.com

--Apple-Mail=_D97B7FE4-B590-46A8-AEDF-7570EF923B61
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8



> On Aug 18, 2021, at 12:16 PM, Marek Marczykowski-G=C3=B3recki =
<marmarek@invisiblethingslab.com> wrote:
>=20
> On Fri, Aug 13, 2021 at 12:37:27PM +0100, Ian Jackson wrote:
>> The current policy for minimum supported versions of tools, =
compilers,
>> etc. is unsatisfactory: For many dependencies no minimum version is
>> specified.  For those where a version is stated, updating it is a
>> decision that has to be explicitly taken for that tool.
>>=20
>> The result is persistent debates over what is good to support,
>> conducted in detail in the context of individual patches.
>>=20
>> Decisions about support involve tradeoffs, often tradeoffs between =
the
>> interests of different people.  Currently we don't have anything
>> resembling a guideline.  The result is that the individual debates =
are
>> inconclusive; and also, this framework does not lead to good feelings
>> amongst participants.
>>=20
>> I suggest instead that we adopt a date-based policy: we define a
>> maximum *age* of dependencies that we will support.
>=20
> I wonder about another approach: specify supported toolchain =
version(s)
> based on environments we choose to care about. That would be things =
like
> "Debian, including LTS (or even ELTS) one", "RHEL/CentOS until X...",
> etc. Based on this, it's easy to derive what's the oldest version that
> needs to be supported.
> This would be also much friendlier for testing - a clear definition
> what environments should be used (in gitlab-ci, I guess).

This is in fact what I=E2=80=99ve been thinking and talking about =
proposing for a very long time.  As far as an open-source offering, what =
we really want is for the newest version of Xen to build on all =
currently-supported distros.  If the distro maintainers themselves no =
longer want to support a distro, I don=E2=80=99t see why we should make =
the effort to do so.

As you say, this should make testing super easy as well: All we have to =
do is have docker images on gitlab for all the supported distros.

 -George



--Apple-Mail=_D97B7FE4-B590-46A8-AEDF-7570EF923B61
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="signature.asc"
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEj3+7SZ4EDefWZFyCshXHp8eEG+0FAmIKyhsACgkQshXHp8eE
G+0uHQf+In1It+p6T7dLqQV10xi4Y0HMavI4yG8aSgdhcDk4PZZWdcz49HKXNa+i
auzu9AS215XRGuRCENAcWETmlCEW9wju2Bk6pxpcwEPNIto285lkMCgWaaiq7dDI
mvhRzyPIFk+Aqre9hgk6f+PDEtownpmdbHq0WaC6rFn+rw0KwhElBtshvOlJ5v/f
vMTPV05GkA0nA9C+TajTwQ6PHluQcLuqmM2N+6Eotx9oQ8l+ceznHH1WeA6aU6Hs
WfYb1UxHKOFveMJdq81oYKUjDybua5xWTLNQkkR4fHNyU493eOS3SlPmUEar+4he
mR1Ya6crBBk7PlzgP4UUEFmx52S7+A==
=32c/
-----END PGP SIGNATURE-----

--Apple-Mail=_D97B7FE4-B590-46A8-AEDF-7570EF923B61--


From xen-devel-bounces@lists.xenproject.org Mon Feb 14 21:50:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 21:50:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272636.467534 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJjF1-0005xe-OD; Mon, 14 Feb 2022 21:50:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272636.467534; Mon, 14 Feb 2022 21:50:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJjF1-0005xX-Kb; Mon, 14 Feb 2022 21:50:39 +0000
Received: by outflank-mailman (input) for mailman id 272636;
 Mon, 14 Feb 2022 21:50:38 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qPn=S5=citrix.com=George.Dunlap@srs-se1.protection.inumbo.net>)
 id 1nJjEz-0005xR-Tx
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 21:50:38 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2280418e-8de0-11ec-b215-9bbe72dcb22c;
 Mon, 14 Feb 2022 22:50:34 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2280418e-8de0-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644875434;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:mime-version;
  bh=lg0hbfwraGfcpQbbOpX7DUPkWiXRlmd+67pZbGWWy+Q=;
  b=GC3s/vxGywh4mQRwZZQqzZISF4B0S/G2o6GBVPu7hKskCcaRJDU6eEUq
   Y2hRqO5ncVRAfQDszgBKw6NsAiTeamPV1VUKoKyHxeBxyni8Hc1hr9OZc
   Effrc95lvHJF9vhnuy/NWX6+9QLb2GjXgN2ipe1bLeKFsTdpz/iwAmta4
   c=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=hardfail (body hash did not verify [final]) header.i=@citrix.onmicrosoft.com
IronPort-SDR: /ZIE1ghS0LgyVTFRSmLzh47HLayE30b3HDfQalyiK9Ydj4keoncyoOxH6GCIgB0A8zJFlB8NAQ
 3ML5DdQwthxQmP+m2OQxmLu68KEsTWPXoOLrzcCy5VU1gNbJDC7gZUQcI1XxVImvGOHflMq/fN
 mgin/KKfGXRovYGP0js4VxcIRXDwuSxH8LLldVhO0HcH7sZJ9YeJuFGu1kB+kjbjxnsPHBXPF0
 JewaweRR8qP156x7Rin3Pm0WxVy+k7IoAWAbtgQW0rikMgtJWUYvGvDrqalQT43o89ihHH5Xre
 9Mhdf92gbhBgoVGNg72GgxJ1
X-SBRS: 5.1
X-MesageID: 63637255
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:RLgyYqPwp5XQenTvrR23kcFynXyQoLVcMsEvi/8bNLWB5Y4Qp3Zem
 TxOHSzEb+HbITHFz+oGPom0/B8Pvp7Wx9cxTwJtpC0xFS0W8pHJXYTEJUqqMijOf5SdHRg85
 J1DNYiQcJs5ESLX/U71POPv8nVx2a3TTdIQZAK81gVZHGeIHw992UILd5cFv7NVbfiF7yKls
 4+or8SBYgT10GN5OT8Z5//e8x00sq/7tm8Sslc3Pa0a4FOGm3crV59OfqvZw1kU42V38kxWY
 86ZkdlVK0uAp09F5utIFt8XS2VSKlLoFVHmZkF+Bu7y0nCumgRoivxhbKBFNR8N49m0t4sZJ
 Otl5MTYpTgBZsUgqMxFO/WPO3gjVUHu0OavzUmX6aR//WWfG5ff66wG4HUNFZ8Z4o5K7VRmr
 pT0Htyvgier3IpayJrjIgVla19KwMPDZOvzsVk4pd3V4GpPrTkujMwm6PcBtArciPyiEt6EP
 cMlMSReKy3pRCFqBXQQKopnofqn0yyXnz1w8Dp5pIIy6mnXigdwzKLsIJzefdniqcd9xxjC4
 DicpiKgX09cZIf3JTmtqxpAgsfgkCThV49UOKC+8vdyqFaS2nYSGFsdUl7TTfyR1BXgAI0Fd
 hF8FiwGnJJp1h2tDdDHexj7p0O5rkEzd8gBHLhvgO2K4vWNuFvIboQedRZDddgnuckeVTEsk
 FiTkLvBHidzubeYTXac8La8rj6oPyURa2gYakcsUg8t89Tl5oYpgXrnXttlVaK4kNDxMTXx2
 CyR6jgzga0JiswG3Ln9+krI6xqOjJXUSg8+5i3MQ3moqAh+YeaNZpOqwUjW6+5aK4SURUXHu
 2IL8+CV6+ULDI2RmTaWaPUAGqmz4PSIOyGahkRgd6TN7Bz0pSTlJ9oJpmgjegE5aa7oZAMFf
 meJ4wptvIFie0KDSpNSXKG2Kdxz8LXvQIGNuu/vUvJCZZ14dQmi9S5oZFKN022FrHXAgZ3TK
 r/AL5/yUC9y5bBPiWPvGrxDieNDKjUWmDuLLa0X2ShLxlZ3iJS9bb4eeGWDYekihE9viFWEq
 o0PXydmJvg2bQEfXsU12dNJRbzpBSJibXwTlyCwXrTdSjeK4El7V5fsLUoJIuSJZZh9mObS5
 W2aUURF0lf5jnCvAVzUNiw8OOOyAM4m9ihT0ckQ0bGAgSZLXGpSxP1HK8tfkUcPqISPMsKYv
 9FaIp7dU5yjuxzM+igHbImVkWCRXE/DuO56BAL8OGJXV8c5H2Tho4a4FiOypHhmJnfm7qMW/
 uz/vj43tLJeHmyO+u6NM6nxp75w1FBA8N9Ps7zgfIUCJhW0qNIyQ8Ez59duS/wxxdz47mby/
 y6dAAsCpPmLpIkw8dLTgruDoZvvGOx7dne21UGBhVpvHSWFrGel36FaV+OEIWLUWG/uof3wb
 uRJ1fDsdvYAmQ8S4YZ7Fr9qy4M45sfu+OAGnlg1Qi2TYgT5EK5kL1mHwdJL6v9HyIhGtFbkQ
 UmI4NRbZ+mEYZu3DF4LKQM5Re2fzvVIyCLK5PE4LRyiti969baKS2tIOByIhHAPJbd5Ktp9k
 +wgpNQX+0q0jR9zaoSKiSVd9mKtKH0cUvp46sFGUdGz0gdykwNMe53RDCPy8aqjUdQUPxl4O
 CKQiYrDm69YmhjIfU0sGCWfxuFan5kP5kxHlQdQO1STl9PZrfYrxxkNoy8vRwFYwxgbgeJ+P
 m9nax98KamUpmo6gcFCWyanGh1bBQ3f8Uv0kgNbmGrcRkiud2rMMGxiZrrdoBFHqzpRLmpB4
 bWV6Gf5SjK7Lsj+0xw7VVNht/G+H8d68RfPmZz/EsmId3XgjeEJXkN6ibI0liba
IronPort-HdrOrdr: A9a23:sG4e3KqtoFBGC8Jcm4uMaAMaV5uCL9V00zEX/kB9WHVpm5Oj+f
 xGzc516farslossSkb6Ky90KnpewK5yXcH2/hvAV7CZniphILMFuBfBOTZskXd8kHFh4xgPO
 JbAtVD4b7LfBlHZKTBkXKF+r8bqbHtms3J9ITjJjVWPHtXgslbnlxE422gYypLrXx9dOME/e
 2nl6x6TlSbCBEqR/X+IkNAc/nIptXNmp6jSwUBHQQb5A6Hii7twKLmEjCDty1uEw9n8PMHyy
 zoggb57qKsv7WQ0RnHzVLe6JxQhZ/I1sZDPsqRkcIYQw+cyTpAJb4RGYFqjgpF5N1H22xa1+
 UkZC1Qefib3kmhO11dZyGdgjUIngxes0MKgmXo/0cL6faJNQ7STfAx376xOyGpmHYIrZVy1r
 lG0HmesIcSBRTcnD7l79yNTB1ykFGoyEBS3NL6HxRkIPsjgZJq3MciFXluYd099ePBmfcaOf
 grCNuZ6OddcFucYXyctm5zwMa0VnB2GhudWEANtsGczjATxRlCvgQl7d1amm1F+IM2SpFC6e
 iBOqN0lKtWRstTaa5mHu8OTca+F2SISxPRN2CZJ0jhCcg8Sj7wgo+y5K9w6PCheZQOwpd3kJ
 PdUElAvWp3YE7qAd3m5uwCzvkMehT1Yd3A8LAq23FJgMyLeFOwC1zwdLkHqbrVn8ki
X-IronPort-AV: E=Sophos;i="5.88,368,1635220800"; 
   d="asc'?scan'208";a="63637255"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=GR9VWVX0/eaLY8GqMsljOODl/oKn+ZPf8S8O9mRvXg/cRV6ymEtW8aiPC6NGJd+4MKDeSZlI24GNZYkzh1UsmlI2zZeQ69RZ664ksDMaZrw+sIsiYICA1tr/UXC1pundIVzgYlCOOdvdP9a3U6IY3SO04W4e4WUEv6ofXXSFwcVrRrnuJtyY+dzyxB/cgo+fDEfqK4lL/XGwP0HRiPOqQqaopg5pBfVbX5Y1dIF1Sk6ZpGdeGGra0wNUy2FAzuKcLMGk15/zAs0gWrC4kb1xiWJX0VFvFXn+BG5JsQqjb4lmr7Lm6+sBbt+cmY9ccW6MQcfFJqVRGE6K8VbCoFdB7g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=vyKRvuY235g2ngjiayH53KjXiBat3qTohVyvFKiEqmo=;
 b=PTYjFqoYRwXFQA5gJAFfBPd2RSemgFFJiWA+1wJBeSvHVZhgDgb4ACQ2Vn/vF70dMUnq97EZ1+kPS5Q9d3wXRWPqOxelyuPzPoJoJ1IfggOBWP2mhPloZITu2D18c9kn7/IxaJZoo3bx1sO3BnU3dVRpF5XUPCDsofEhdIMk1Q5cDT1n8LJsGeSo7u9LRdXJWEVyQu9x+K1jjGzoem5Y7kgWjFrYnx0UCrU2M0k87bpsXPcHAwkAHnWx+WJeenbkgh5IKVj0oBQDj6dNJilU87weWIa6wGv4Hh9drrkB+uAmUTGQ/ycj5xyzyXoCxcYHOyFJZlxSmzfzK7thoFJJdg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=vyKRvuY235g2ngjiayH53KjXiBat3qTohVyvFKiEqmo=;
 b=ebl+atBiPcpTp9H2zUjzfbD1XqMioybdp4vUOgNzalJ1ywKjvZvTUhrEuHMLXEl2GADrgI82P7we+C4/Vuvt9fCdGbbsjr0tRviwkJbDm3ovc/0YDSgTZqw4GLDcM+vY2uA+tKdzN4yiAUwiero1XQzzEnHRGufq9riMD9zRrAk=
From: George Dunlap <George.Dunlap@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
CC: Ian Jackson <iwj@xenproject.org>, Committers <committers@xenproject.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Andrew
 Cooper" <Andrew.Cooper3@citrix.com>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH] RFC: Version support policy
Thread-Topic: [PATCH] RFC: Version support policy
Thread-Index: AQHXkDev9/QrG+8IgUOEs2JU9EeShqt6ldOAgRojewA=
Date: Mon, 14 Feb 2022 21:50:25 +0000
Message-ID: <C6A7B444-4CFB-43A7-8FA8-AD1049F83912@citrix.com>
References: <20210813113727.6028-1-iwj@xenproject.org>
 <de32c6c4-5ad5-862e-3988-0e7310ec3ecb@suse.com>
In-Reply-To: <de32c6c4-5ad5-862e-3988-0e7310ec3ecb@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3693.60.0.1.1)
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: f13f1b4b-b39b-4b93-5671-08d9f004026d
x-ms-traffictypediagnostic: SJ0PR03MB6732:EE_
x-microsoft-antispam-prvs: <SJ0PR03MB67327622B268EABBE30A0B4999339@SJ0PR03MB6732.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8273;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: zlKZNqizPoyfvaEsD6OQTqZvm3GU5AWS+zCRXfA+0D7ktcp0MM6w0YGGEf4GrCJlYisdGrtOGguKTgT5uy5ns449aNCYZM9gW4zZOJCxuscTHN5Q6GFXqpIgl3MVJY25t/Sm7aS6YuXcPb0Dm7/7ICnYh1cNIAUxozZdWFEyFVezl6k9RmPw7vJ7CbPbGtb70JPiWq56qQeBdbkIRpVgwtr0tFPV5Na1o9iVzPEFcsAS/06eSox+17ofLJL9eIKQMupNb/2gwZyDdcbrsMIEhbxVnZfHUt6EY7jm7EEZuFhTZO9km6x/riwFtVPCzOWqnUDbRd/KgPdtXQfv4negvgHNaJaPdccZJMBIh3o3I9O6eVjX8voZltT1DwZFxkSInNU6b01lUIbJn+4I7x4Jd8I/eupq3+Uu1AE5GvQ11zqPTInF+SWraOzTGZkvweqi5rp1iFAhxPokQkyvB7cdtMAojZL4OX1wpr+0DNqqjXSsUiuU19KkA0++trE2wiSTaw55kcnSC8YtnS5rZTGPc1nAtUs1Ln+lL7O0HMjk8csp1n4YuIKUegySUxHvLZvROpyzd+OvS+mvQW38oX7zMhJHSQNSW8LD8SAzxrU6INkBtonyMLnzrfRJ44bGPwfX1eemhZGzj6qOxp+IbqV+V+9Ct/WcJLlU47X6c54NARFgwzUNDNQIC5c5X75Mpaf1OgrWVysQ1ZAi30/LImfSn05vwHAzJAiZEuu2/ZUGZNBjop3v/11xJSpFayH+k2aP
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(4326008)(8936002)(8676002)(5660300002)(6486002)(71200400001)(54906003)(6512007)(508600001)(6506007)(53546011)(2616005)(91956017)(26005)(186003)(38070700005)(316002)(6916009)(2906002)(82960400001)(83380400001)(64756008)(33656002)(86362001)(122000001)(99936003)(36756003)(38100700002)(76116006)(66446008)(66946007)(66556008)(66476007)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?cWRnbW12TnRWRjlrcVplRlVJS0EzaitYbnMrVVp1aXhVTTNQWDZvb01LQU1j?=
 =?utf-8?B?V3BLVFJ1dWxyK3VsSzdxeENwTE9TUFArM3BBWXpNSGVQUEMzUm1ZakZYdzFO?=
 =?utf-8?B?NFUwYnRwSmUwazBNUzZaOW5pUVBmV0o0aTE1dGhMWTV5bm1xL2NKV0JDemIr?=
 =?utf-8?B?ZTVVZ2NZOFNSS3gwd1hXNmNsZk5yN2lIYnczek8wUC92WWtFWjhjaVZTbzQ1?=
 =?utf-8?B?UnhrQitsRTc2c3BhNDEwQjVqNE5FSldQYXFXWEgvNm4yVkFrWWRNdUZsYXBI?=
 =?utf-8?B?NEhsbmVZUWlFV0ZTRHBVV1VzcVNHRHRVTHEyWTJSalpjdmpQLzRETEJMV29R?=
 =?utf-8?B?citBWUQ1UkYzRlI4RTJPV2lYOWRvYlhhaEcreDBURnJZMi84eStpS09UbkZO?=
 =?utf-8?B?NEg4ZEZEeSt1NjNnMnJYb0xUbHlQZDNuVjhaYXRpTXl4RGF0Y1BTU3F0MURF?=
 =?utf-8?B?YStiSWxoR05UVy9HTW1uTjVodHltM2FYdWNnRCtrZ1F6WWhzdVhvc0xuU2Uv?=
 =?utf-8?B?a0tJNm9JWlNnZDkxb1ZlZGhNdlc2Sjl1ek5CVmwxTkk3aGYrTitvbllLUXNU?=
 =?utf-8?B?dmE2WnN2eTRYaTFXdUttNVRzTmFJMjA5UG44dDNraVZhWHBrZm1sdkt4RC9E?=
 =?utf-8?B?NGNKbWdQVkE1TTlPUzFWb01nSE9DQ2xueDhIRnl1UnN6akZPWXZXaGgzcVVV?=
 =?utf-8?B?dGNhNkEzRmlqV2F1dVo4Q2ZqVmNxeWN0V2xWVjB2bnJVMFRZQ1A5Rk05enYz?=
 =?utf-8?B?am1QZnF5R1d4bWhXR0E2dDVsajdBV2dCa0VDVG5UU2t4OHBiYndYWnUrTEYv?=
 =?utf-8?B?NTlmTDNUK0FMVjlOTXN3Q0svUVR1N0Y1NDA1M0JGZFZMV0ZGK015L3drMU01?=
 =?utf-8?B?MURsWlNwbXZHZnFCekRhYjFhS0dQeVFlUmlIYlBwdEMvUnBVUk5rSW1WV0sv?=
 =?utf-8?B?dE9pUWtVcjVOYTRJaXRsNW5ZcVZMNWJXVWM5aGZqS3ZxN1FpNjNEL2lZVDBP?=
 =?utf-8?B?Q3JITDVqVW1xcEhKK0VBTkk1bGpaaWJWRXNadFZaQ3pRd1Rtdm9iY2w5ZmJx?=
 =?utf-8?B?Sm1EanhFaVEvL1VHZlpSQWxRcWRaNkZEbGt6RzVLMERjN21sV0tJdDFEMzZ2?=
 =?utf-8?B?ZzdRQWl0ZGtZVEJsUDVyd3lyVGxER3Irb09SVW9xbFZUMzRNQzBUYlAyOENz?=
 =?utf-8?B?YVYycFRJQ0VaaHZyaUFDcHFIM0kwdUxWSktRbnlqMGxIaTJBZDlWMTZBc29a?=
 =?utf-8?B?MllhWjBCRlVJNkxaTjlmSUc5ZWJ6azQ5dFFUdWxnekZZV0V2TXU1QVBjMmRV?=
 =?utf-8?B?YUk1S3drdTFoTWsvM0xNOWpYaFNSMlZVcnFZdWxVcFFnQUJKaW9sT0lLMk45?=
 =?utf-8?B?eUJsdWZoZGNxV1lyZEhqcklkR01ha1o5Z3grVTdlU0RNeVlselMzdFcyN3hU?=
 =?utf-8?B?M3gxTGJtUjlBbkxDV2NqbTRxdjVNb1ZpblUvSS94UXlDZW85L09HMFp0UFFJ?=
 =?utf-8?B?N1hVbWMySzhxVE1ac3VIZk5ndlZBcmltQXQ2ZVNOQTJJRno2cXFqTXN0S3VD?=
 =?utf-8?B?YnpjUWpDd1lhMkdZdlJYbTROTllMcDVoaTJyZWgvRlpHZUJMZ2RFZURRRGlr?=
 =?utf-8?B?VkhxOWhDcTN2N2FRc0FMSmI4VXJJKzJUcUtlRG5FZldnOFB2c2ZMV3BKSUx6?=
 =?utf-8?B?Y0pjQXV4NFN1dTU2T0hCY09NN0loTDJKUnZOS0lMcDZHOEx0eGo5VldVQ1Fm?=
 =?utf-8?B?N0Z1QWVkRjRYODFUUnBYTjU1MmsrdFM3RnN6S1ZLdkpoVXFiT3lnQzM2c3BV?=
 =?utf-8?B?QS82elphZXIrWjNFQlZSZnYrZWo1YUtCQStuM1N3R3UyL3BtTUtxM1NkSXBW?=
 =?utf-8?B?QnlkQW9IalB3TkpHVjZ0S2lIc1hDVW9JcytVVEtxcEhmZGNHV2pMeUwwQzcr?=
 =?utf-8?B?cVdEVEExTWNXdjB3NnFPS1hpclRGSmpxWVpJVVlQb1RMNDJ3eWxoY1RKVmxq?=
 =?utf-8?B?b2VXdGV6TWQwdU5oRUdrQlFhQk1wbFlxQ3lBMVNmRXZmNzZSNFFJb0Nyb29u?=
 =?utf-8?B?NmkvY2crVGp2RjR1bEFUVmFsWGlmYkZpd1BZZnQ0VlFRRFhIUGsxVnNrQkFu?=
 =?utf-8?B?ckhRRU0yYStiKy9xV2M4Ynd3ZE1YT3dlcUk2dE5rK1V3d0gzU01QMG9UZ1Z5?=
 =?utf-8?B?Q0twc1VySnc1UVBkV0NsVzNsbisrZ2t0bFh6Vk4zVUpLRVlGVGt4SGV0a011?=
 =?utf-8?Q?tPKY8YFSm0uLEo+fLJ81SZ15Nt7vej6JfRugeJWUo8=3D?=
Content-Type: multipart/signed;
	boundary="Apple-Mail=_3163DCB9-49A2-4603-B0F8-6E908A92B805";
	protocol="application/pgp-signature";
	micalg=pgp-sha512
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f13f1b4b-b39b-4b93-5671-08d9f004026d
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Feb 2022 21:50:26.0109
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: AhuKgO6ZIiQvMDoJrQAB6pL2SuNUqhgKNLeqdWnKx19is+wiIN6VwIgzMy6WOTZd9f1HutBglorOe2f3BxxXfYLHpzgheyfYhlvoikzstNo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6732
X-OriginatorOrg: citrix.com

--Apple-Mail=_3163DCB9-49A2-4603-B0F8-6E908A92B805
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8



> On Aug 19, 2021, at 10:18 AM, Jan Beulich <JBeulich@suse.com> wrote:
>=20
> On 13.08.2021 13:37, Ian Jackson wrote:
>> The current policy for minimum supported versions of tools, =
compilers,
>> etc. is unsatisfactory: For many dependencies no minimum version is
>> specified.  For those where a version is stated, updating it is a
>> decision that has to be explicitly taken for that tool.
>=20
> Considering your submission of this having been close to a glibc
> version issue you and I have been discussing, I wonder whether
> "etc" above includes library dependencies as well.
>=20
> In any event the precise scope of what is meant to be covered is
> quite important to me: There are affected entities that I'm happy
> to replace on older distros (binutils, gcc). There are potentially
> affected entities that I'm less happy to replace, but at the time
> I did work my way through it for example for Python (to still be
> able to build qemu, the community of which doesn't appear to care
> at all to have their stuff buildable in older environments). The
> point where I'd be really in trouble would be when base platform
> libraries like glibc are required to be a certain minimum version:
> I'd then be (potentially severely) restricted in what systems I
> can actually test stuff on.

The question here is, why would someone running a 10-year-old distro =
that=E2=80=99s been out of support for 6 years want to run a bleeding =
edge version of Xen?  I understand wanting to run Xen 4.16 on (say) =
Ubuntu 18.04, but who on earth would want to run Xen 4.16 on Ubuntu =
14.04, and why?  If such people exist, is it really worth the effort to =
try to support them?

> In addition I see a difference between actively breaking e.g.
> building with older tool chains vs (like you have it in your
> README adjustment) merely a statement about what we believe
> things may work with, leaving room for people to fix issues with
> their (older) environments, and such changes then not getting
> rejected simply because of policy.

Yes; I think the principle should be that we *promise* to keep it =
working on the currently-supported releases of a specific set of distros =
(e.g., Debian, Ubuntu, Fedora, SUSE, RHEL).  Working on older versions =
can be best-effort; if simple changes make it compatible with older =
versions, and aren=E2=80=99t too burdensome from a code complexity point =
of view, they can be accepted.

One of the issues however is build-time checks.  If we have a build-time =
check for version X, but only test it on X+10 or later, then the build =
may break in strange ways when someone tries it on something in between.

I think it=E2=80=99s too much effort to ask developers to try to find =
the actual minimum version of each individual dependency as things =
evolve.

> While generally I find Marek's proposal better to tie the baseline
> to distros of interest, in a way it only shifts the issue, I'm
> afraid.

What do you mean =E2=80=9Cshifts the issue=E2=80=9D?  You mean shifts it =
from versions of individual components to versions of distros?

That=E2=80=99s why I think we should support only currently-supported =
distros.  If the distro=E2=80=99s maintainers don=E2=80=99t consider the =
distro worth supporting any more, I don=E2=80=99t see why we should make =
the effort to do so.

 -George

--Apple-Mail=_3163DCB9-49A2-4603-B0F8-6E908A92B805
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="signature.asc"
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEj3+7SZ4EDefWZFyCshXHp8eEG+0FAmIKzqAACgkQshXHp8eE
G+3phgf/QFEPoxuZHLUAVXSjo/zAeqgQoVNXc5qZsSyiiGcT/Hom1x4sNlsonSnh
4BR4ePvkw4J1wDzyNeeQgeeDg3sgpwhHy+YtBLbNWfwgy+efbIezd9yDJxo+C0Wf
62IVo1Tnmup5WmDXT4s3ogxKMOZ1jDkyAvcTYHhoSW67TtMuHLW1r5HiWQMfRddW
uyb9FdEqK6XN5S+8jY1eKIkeC2XUeSkPfr023L0wq70F5rpE3XufngxWDD6yekIy
HI/L09aMRlS/QqwWV52HzBpDHZBDjBGUe4dyssDHaTE++f/Kr+yIRSabyGM32XWx
0htxmhCKYXho4dsHaenf/YXnFZbUSw==
=6suW
-----END PGP SIGNATURE-----

--Apple-Mail=_3163DCB9-49A2-4603-B0F8-6E908A92B805--


From xen-devel-bounces@lists.xenproject.org Mon Feb 14 22:05:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 22:05:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272645.467545 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJjTI-0007ZB-5Q; Mon, 14 Feb 2022 22:05:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272645.467545; Mon, 14 Feb 2022 22:05:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJjTI-0007Z4-0m; Mon, 14 Feb 2022 22:05:24 +0000
Received: by outflank-mailman (input) for mailman id 272645;
 Mon, 14 Feb 2022 22:05:22 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=pHWl=S5=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nJjTG-0007Yy-RE
 for xen-devel@lists.xenproject.org; Mon, 14 Feb 2022 22:05:22 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 33989a61-8de2-11ec-8eb8-a37418f5ba1a;
 Mon, 14 Feb 2022 23:05:21 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 5D759B81670;
 Mon, 14 Feb 2022 22:05:20 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8CB89C340E9;
 Mon, 14 Feb 2022 22:05:18 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 33989a61-8de2-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1644876318;
	bh=GyWt1ZhBon7J6cCAQ3nuHkfRgzKuUIr3j+ONXYhCWb0=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=HUCp3jYZrhBTw7x7O3P4JAR9HTomIx3dVpyTtzVC8rin+wMGf5cHZc4vUtYXLbzSH
	 Zy6srR1WjeU5Ure9H6CNKZB+Bu5iYpOL96hziuErDWRAipm5kIFivAbf2d1mOeEMcG
	 hK1DQKcK1Fj1UcK+kRpHQ4dNE9jrvn5LTU50Vc5dpifXOwNVBd3T71Ept2W8kuZWZz
	 vAIxvoMzq0y482UObnt5ZWRIMn6NqnwNCr5s5wWKpsab+7fA+GxwDRKxNHpf+Z9z/5
	 RTT9p2NResGSJqlKEfgsqxV4bn5pg/sAzdCbkLdxRPdnaAD4pe6PyYPTxh7iraXvrU
	 OOTeAAa0teGyg==
Date: Mon, 14 Feb 2022 14:05:18 -0800 (PST)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
cc: Bertrand Marquis <bertrand.marquis@arm.com>, Julien Grall <julien@xen.org>, 
    "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [RFC v2 5/8] xen/arm: introduce SCMI-SMC mediator driver
In-Reply-To: <20220214115127.GA3637134@EPUAKYIW015D>
Message-ID: <alpine.DEB.2.22.394.2202141355150.4183037@ubuntu-linux-20-04-desktop>
References: <cover.1644341635.git.oleksii_moisieiev@epam.com> <cb1493f5d9b5c3437268054b4a8e345cb35c8708.1644341635.git.oleksii_moisieiev@epam.com> <F9811680-C6EC-4372-A451-5C1DA279E35E@arm.com> <20220211104403.GA2291814@EPUAKYIW015D>
 <A9FF3FBC-C29D-4A17-8737-EBABEF240BA2@arm.com> <c13f6312-3922-4504-3248-e2e4701b1a10@xen.org> <20220214111300.GA3615313@EPUAKYIW015D> <E78206B4-3793-498E-A580-F0561DF6D4AC@arm.com> <20220214115127.GA3637134@EPUAKYIW015D>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Mon, 14 Feb 2022, Oleksii Moisieiev wrote:
> Hi Bertrand,
> 
> On Mon, Feb 14, 2022 at 11:27:21AM +0000, Bertrand Marquis wrote:
> > Hi Oleksii,
> > 
> > > On 14 Feb 2022, at 11:13, Oleksii Moisieiev <Oleksii_Moisieiev@epam.com> wrote:
> > > 
> > > Hi Julien,
> > > 
> > > On Sat, Feb 12, 2022 at 12:43:56PM +0000, Julien Grall wrote:
> > >> Hi,
> > >> 
> > >> On 11/02/2022 11:18, Bertrand Marquis wrote:
> > >>> Do you plan to add support for other boards ?
> > >>> 
> > >>> Did you discuss more in general with the linux kernel guys to see if this
> > >>> approach was agreed and will be adopted by other manufacturers ?
> > >>> 
> > >>> All in all I think this is a good idea but I fear that all this will actually only
> > >>> be used by one board or one manufacturer and other might use a different
> > >>> strategy, I would like to unrisk this before merging this in Xen.
> > >> 
> > >> In the past we merged code that would only benefits one vendor (i.e. EEMI).
> > >> That said, this was a vendor specific protocol. I believe the situation is
> > >> different here because the spec is meant to be generic.
> > >> 
> > >>> @julien and Stefano: what is your view here ?
> > >> 
> > >> I share the same concerns as you. I think we need to make sure all the
> > >> pieces we rely on (e.g. firmware, DT bindings) have been agreed before we
> > >> can merge such code in Xen.
> > >> 
> > >> The first step is to have all the pieces available in public so they can be
> > >> reviewed and tested together.
> > >>
> > >> Oleksii, on a separate e-mail, you said you made change for ATF. How much of
> > >> those changes was related to support for Xen? If they are some, then I think
> > >> they should be upstreamed first.
> > >> 
> > > 
> > > Let me share changes, that were done to AT-F and Linux kernel
> > > device-tree in terms of the SCMI mediator POC.
> > > Changes to the Linux kernel:
> > > https://urldefense.com/v3/__https://github.com/oleksiimoisieiev/arm-trusted-firmware/pull/4__;!!GF_29dbcQIUBPA!je9Cu0n0498Yn76OLWjxxVaB7jWJtyWycHX0YARezTnc7aYHpGRJ8tSxHqIC0fTMUUSV$ [github[.]com]
> > > Based on renesas-rcar linux-bsp, branch v5.10/rcar-5.0.0.rc5
> > > 
> > > Changes to AT-F:
> > > https://urldefense.com/v3/__https://github.com/oleksiimoisieiev/linux-bsp/pull/3__;!!GF_29dbcQIUBPA!je9Cu0n0498Yn76OLWjxxVaB7jWJtyWycHX0YARezTnc7aYHpGRJ8tSxHqIC0eDKS3ge$ [github[.]com]
> > > Based on renesas-rcar/arm-trusted-firmware branch rcar_gen3_v2.5.
> > 
> > You inverted the links but thanks this is really useful.
> > 
> 
> That's strange. Links looks good from xen.markmail.org interface.
> 
> > Did you push the ATF changes to mainstream ATF or discuss those with
> > the maintainers ?
> 
> No. We did changes in ATF as a proof of concept.
> 
> > 
> > The strategy overall is nice but we need to make sure this is accepted and
> >  merged by all parties (ATF and Linux) to make sure the support for this will
> > not only be available in Xen and for one board.

+1


> I've prepared patch to Linux kernel, which is introducing scmi_devid
> binding, needed to set device permissions via SCMI. I've contacted
> Sudeep Holla <sudeep.holla@arm.com>, who is the maintainer of the SCMI protocol
> drivers. Waiting for the response.
> 
> Changes to ATF are not Xen specific and were done in terms of POC. We do
> not have plans to upstream those changes right now.

If this work relies on a new interface in ATF, and the interface is not
vendor-specific, then at least the interface (if not the code) should be
reviewed and accepted by ATF.

Otherwise we risk ending up with an upstream SCMI implementation in Xen
that cannot be used anywhere, except the PoC. To make things worse, this
could happen:

- we upstream the SCMI mediator to Xen
- we upstream any required changes to Linux
- ATF rejects the SCMI-related interface changes
- ATF comes up with a difference interface

At this point we would have to deprecate the implementation in Xen. It
might also be difficult to do so due to versioning issues. We would
need to be able to detect which version of ATF we are running on, to
distinguish the ATF PoC version that works with the old interface from
the new ATF version that supports a different interface.

To avoid this kind of issues we typically expect that all relevant
communities agree on the public interfaces before upstreaming the code.


From xen-devel-bounces@lists.xenproject.org Mon Feb 14 23:05:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 14 Feb 2022 23:05:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272653.467556 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJkPQ-0004zF-ME; Mon, 14 Feb 2022 23:05:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272653.467556; Mon, 14 Feb 2022 23:05:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJkPQ-0004z8-IG; Mon, 14 Feb 2022 23:05:28 +0000
Received: by outflank-mailman (input) for mailman id 272653;
 Mon, 14 Feb 2022 23:05:27 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJkPP-0004yy-CU; Mon, 14 Feb 2022 23:05:27 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJkPP-00083h-8s; Mon, 14 Feb 2022 23:05:27 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJkPO-0005wu-Pl; Mon, 14 Feb 2022 23:05:26 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nJkPO-0003BN-P0; Mon, 14 Feb 2022 23:05:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=o7vQBqh4/q8hdk+O93HFYhnEDJrXk3lKuNMm8ffwjSQ=; b=GoVLNbDel38kXmqMdtMkMHnvWR
	2dF87xObM+uA+J9aePswxB7W0SEclA6STbpJmOpJWSE63zbasSu1ytBr8DaBPHZCXzlil81U/9u0C
	52rOOc/gHeKPQH9KzNlIJdhI4cbC4LU8nAaek5P0pFONbhmuHHVQkcENsYNx4eonmP+g=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168109-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 168109: FAIL
X-Osstest-Failures:
    qemu-mainline:build-arm64-xsm:<job status>:broken:regression
    qemu-mainline:build-arm64:<job status>:broken:regression
    qemu-mainline:build-arm64-pvops:<job status>:broken:regression
    qemu-mainline:build-arm64-pvops:host-install(4):broken:regression
    qemu-mainline:build-arm64-xsm:host-install(4):broken:regression
    qemu-mainline:build-arm64:host-install(4):broken:regression
    qemu-mainline:test-armhf-armhf-libvirt:xen-boot:fail:heisenbug
    qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    qemu-mainline:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking
    qemu-mainline:test-arm64-arm64-xl:build-check(1):blocked:nonblocking
    qemu-mainline:build-arm64-libvirt:build-check(1):blocked:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=48033ad678ae2def43bf0d543a2c4c3d2a93feaf
X-Osstest-Versions-That:
    qemuu=0a301624c2f4ced3331ffd5bce85b4274fe132af
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 14 Feb 2022 23:05:26 +0000

flight 168109 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168109/

Failures and problems with tests :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-arm64-xsm                 <job status>                 broken  in 168104
 build-arm64                     <job status>                 broken  in 168104
 build-arm64-pvops               <job status>                 broken  in 168104
 build-arm64-pvops          4 host-install(4) broken in 168104 REGR. vs. 168059
 build-arm64-xsm            4 host-install(4) broken in 168104 REGR. vs. 168059
 build-arm64                4 host-install(4) broken in 168104 REGR. vs. 168059

Tests which are failing intermittently (not blocking):
 test-armhf-armhf-libvirt      8 xen-boot         fail in 168104 pass in 168109
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 168104

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-libvirt-raw  1 build-check(1)           blocked in 168104 n/a
 test-arm64-arm64-xl-thunderx  1 build-check(1)           blocked in 168104 n/a
 test-arm64-arm64-xl-seattle   1 build-check(1)           blocked in 168104 n/a
 test-arm64-arm64-xl-credit1   1 build-check(1)           blocked in 168104 n/a
 test-arm64-arm64-xl-xsm       1 build-check(1)           blocked in 168104 n/a
 test-arm64-arm64-xl-credit2   1 build-check(1)           blocked in 168104 n/a
 test-arm64-arm64-xl           1 build-check(1)           blocked in 168104 n/a
 build-arm64-libvirt           1 build-check(1)           blocked in 168104 n/a
 test-arm64-arm64-xl-vhd       1 build-check(1)           blocked in 168104 n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)           blocked in 168104 n/a
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168059
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168059
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168059
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168059
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168059
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168059
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168059
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168059
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 qemuu                48033ad678ae2def43bf0d543a2c4c3d2a93feaf
baseline version:
 qemuu                0a301624c2f4ced3331ffd5bce85b4274fe132af

Last test of basis   168059  2022-02-08 15:36:56 Z    6 days
Failing since        168095  2022-02-12 22:37:11 Z    2 days    4 attempts
Testing same since   168104  2022-02-13 23:39:38 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alex Bennée <alex.bennee@linaro.org>
  Cédric Le Goater <clg@kaod.org>
  Hanna Reitz <hreitz@redhat.com>
  Ivanov Arkady <arkadiy.ivanov@ispras.ru>
  Michael Tokarev <mjt@tls.msk.ru>
  Peter Maydell <peter.maydell@linaro.org>
  Philippe Mathieu-Daudé <f4bug@amsat.org>
  Stefan Hajnoczi <stefanha@redhat.com>
  Thomas Huth <thuth@redhat.com>
  Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary

broken-job build-arm64-xsm broken
broken-job build-arm64 broken
broken-job build-arm64-pvops broken

Not pushing.

(No revision log; it would be 768 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Feb 15 01:56:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 01:56:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272669.467600 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJn4z-00077R-68; Tue, 15 Feb 2022 01:56:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272669.467600; Tue, 15 Feb 2022 01:56:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJn4z-00077I-2M; Tue, 15 Feb 2022 01:56:33 +0000
Received: by outflank-mailman (input) for mailman id 272669;
 Tue, 15 Feb 2022 01:56:31 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=A2Di=S6=vivo.com=wangqing@srs-se1.protection.inumbo.net>)
 id 1nJn4x-0006If-1v
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 01:56:31 +0000
Received: from APC01-PSA-obe.outbound.protection.outlook.com
 (mail-psaapc01on2071f.outbound.protection.outlook.com
 [2a01:111:f400:feae::71f])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7e2ba4b7-8e02-11ec-b215-9bbe72dcb22c;
 Tue, 15 Feb 2022 02:56:30 +0100 (CET)
Received: from SL2PR06MB3082.apcprd06.prod.outlook.com (2603:1096:100:37::17)
 by TY2PR06MB2767.apcprd06.prod.outlook.com (2603:1096:404:3b::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Tue, 15 Feb
 2022 01:56:28 +0000
Received: from SL2PR06MB3082.apcprd06.prod.outlook.com
 ([fe80::80b4:e787:47a9:41bb]) by SL2PR06MB3082.apcprd06.prod.outlook.com
 ([fe80::80b4:e787:47a9:41bb%4]) with mapi id 15.20.4975.019; Tue, 15 Feb 2022
 01:56:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7e2ba4b7-8e02-11ec-b215-9bbe72dcb22c
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=YzVJ1wgt2XfqVE9jlYnPwy9sZbneAHUgf+nIh12eurTbrKMdtAoKpl+nUCSrRxw8fhQfh2yhvGMdBl7bIOTdyJTDDV/gb3CihLz2CH1hfuX9xJUsimUJsnYBYpcH28KWLdveM7FILiTgXQ1lsDvILwGIQ7lcE28v/iKR7TLfnrC1sIPm307T8Oe8XFf30ax5wjtrITsO/MwbmvJhjjPghDKivwC+aFJt9ShtM4oI+GL4rmVZW9SHIUdW1bazJEe6dzeAiXtRZ8/b6Sio+mX5BHV8wcHge44zig3qFUokbO9bVb3l+QSegYK9D2Vx0aM2S7lpXvPSLXpo1zHLZbsYBQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=AZUJwShf2lcm2N/QCaj1MTobvEH4aRge/LsFZHd/sYI=;
 b=h49A1UpTgxVYzFDaujO3gPt2ofrw9iQAaxBAbkeApu0EZTSmB2NRfVzlAApfnaEgkz14UNHdXQz0dZBYylvxxOR8nLRPal1XGOb9yyx3+OlGx62wb+zoK7V2MDJVkmn3hjy0E6d5c9lRscmam/7yxnjCOw5iViudgu+Pmr1oUCLpEe4f9t2tr/KSMLwQHsKs7qnyWB+388aHVQvxvI7EYkRF0Mt8O4fNrNf1tpttk82hN3rtwMpAGIz5ES4QLSrlqs+FgireZXtEJZHcdNgRDKXkGSPi8dZwGYesf3EnmwMN+NUZBulpSAytpKg4zqy5fUm7QSeXH+bFsGIApFbO9w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo0.onmicrosoft.com;
 s=selector2-vivo0-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=AZUJwShf2lcm2N/QCaj1MTobvEH4aRge/LsFZHd/sYI=;
 b=b3ld5n6uZA1gTknnE/iIyJApOQJ2CFr6SlaR67v5FVteLqWokfhLH1PS+J9efXvFBD/6r+VYC9qbVWziOToq5CsSWejnzjwCNk99QtfdidIRTDZmq+IQgWL9ZqgjibFdzGu+bUSAz5NkG52k0kPY5fnf3OrMNcmo0AKvA5CJFzc=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=vivo.com;
From: Qing Wang <wangqing@vivo.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Jens Axboe <axboe@kernel.dk>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel@ffwll.ch>,
	Alex Deucher <alexander.deucher@amd.com>,
	=?UTF-8?q?Christian=20K=C3=B6nig?= <christian.koenig@amd.com>,
	"Pan, Xinhui" <Xinhui.Pan@amd.com>,
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Alasdair Kergon <agk@redhat.com>,
	Mike Snitzer <snitzer@redhat.com>,
	dm-devel@redhat.com,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Hans Verkuil <hverkuil@xs4all.nl>,
	xen-devel@lists.xenproject.org,
	linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-clk@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-input@vger.kernel.org,
	linux-media@vger.kernel.org
Cc: Wang Qing <wangqing@vivo.com>
Subject: [PATCH V3 3/13] gpu: drm: i915: use time_is_after_jiffies() instead of open coding it
Date: Mon, 14 Feb 2022 17:55:40 -0800
Message-Id: <1644890154-64915-4-git-send-email-wangqing@vivo.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1644890154-64915-1-git-send-email-wangqing@vivo.com>
References: <1644890154-64915-1-git-send-email-wangqing@vivo.com>
Content-Type: text/plain
X-ClientProxiedBy: HK2PR06CA0012.apcprd06.prod.outlook.com
 (2603:1096:202:2e::24) To SL2PR06MB3082.apcprd06.prod.outlook.com
 (2603:1096:100:37::17)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 350c5fef-b405-474c-85dd-08d9f0266127
X-MS-TrafficTypeDiagnostic: TY2PR06MB2767:EE_
X-Microsoft-Antispam-PRVS:
	<TY2PR06MB2767CEA2486227939D0AC07EBD349@TY2PR06MB2767.apcprd06.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2512;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ePSXhaPcXg4FCtC68F2lY8InSV29A9B0X7537mP4RBGWHZP5mXN708htS4S4u7wWqKMhSwagUCUhji/QcJ2mvFsxZEm/2pLfUvwFb8b3AKZJwlXAh5UPQIPL2fZ75nO1NxEBaQPqlmFXvngc53/CfB5o2pm5rl/xMvTVxPLK+4v8e1IdOnVmEDaD9lxdw43v9MBTu5b4oIS3prUue4WUwqwiNF2zoGo3VejapXFNxDPt1X2HQ/utN7+aRFJVz+nB4rI0dWys6BfO/JaT1uGVYDyhTnWC2tvI36H6NHU2Bjf3f7uFgEdaN8ZWcCqSKu0cAcksL8QDeDVlJU56i6Vz/LLqL6610jEIqsYwVYEXzM1EnKIKAnNx16JNoMsww0xBAhRwG2WO0VgNvPJXJ3CP/J4hndR7/WaSNYQUEdFQeNcDEYei3vFdEDuGW4BexNCsa8KPsUJ7o2ngxEcsVrCGxWgVBCLvsi8y3dVhDHO1ODvi9QJa9mFK5+MHgQHCdDcIL/vbNt9ALSS5CzoEHTArCcTnblAdRCEPkvWRlqj1w+QKxCgvMAEZWBoi8ygkPtETPoFbvNS9JGh/VIJZ2EoZaDSclGDFQS3MHmQp2Eon9Z0xRk34KkBfCwASiyyW68/uxjLyAQf4iZbxEXn+kjM9eOeeHiWTe7BrqPLtmjIxOQwUty26WwAfZPp5oloO94IY5HdO4tUsdbkpSy22+M7sLvlSq0k2Dtr/kq+JTu1sfL8=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SL2PR06MB3082.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38100700002)(38350700002)(7406005)(7416002)(4744005)(110136005)(107886003)(921005)(316002)(26005)(186003)(2906002)(52116002)(5660300002)(8936002)(6506007)(2616005)(6512007)(6666004)(4326008)(508600001)(86362001)(83380400001)(36756003)(66476007)(66556008)(66946007)(6486002)(8676002);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?BaK9tJZZgUm1KrBqZG1H+LXOYbJWVBMNHl3eqdFRkRBZtvWoWGVDQB0LHTcP?=
 =?us-ascii?Q?/vO4YjfcTYv3yBzT2DhJeOwVLJgtU4HkOV2NEL/GCzB0igWhnmNvADiBz0al?=
 =?us-ascii?Q?kPjYnD+4hZ24hQuDjTdPyTFq3th9Ch1WqMz3FJLrZadNlkX8etXdTDiN6ydK?=
 =?us-ascii?Q?cw81cetwlw9rCF8fTPY9YrJi5LjBCyeimc54nI0jauWuwKTZEo3MTt9AbVPw?=
 =?us-ascii?Q?aoWcy9tsE3NbknUJQlqIIZYSWTuY4Sk+jx8gzxO0oeSBaSfYyxADwBgOrbux?=
 =?us-ascii?Q?dyHB7XAk1zd1zdYkZFsRIA7MNwr75/e3d2iFUeOas4BgWLYmXAweKGVSjN+K?=
 =?us-ascii?Q?A3M41pRDd+77FeILsbxw0302PEYLs5Q2ibxkOHjivAV+ZyHyF09Jo908tKOg?=
 =?us-ascii?Q?w+CDMLH8kUAM1UYezrQ96nOZEzVvAOMcN+KhPKJ29ZVtK8bcPvCf5uFEuksb?=
 =?us-ascii?Q?2UH8jNDqHrLwg9EUh6IqYtY2ZXgFrssd20XQ1yvgRXVTHdDU6T+ngVtSUe6r?=
 =?us-ascii?Q?E54na1IRaVDQNv3xwFWr5ngEifny/G5xmH1oWMMLcdj2lguw3K35VVgVMYVf?=
 =?us-ascii?Q?84rU3ynyEU8ufYKi4OMdO7++HKAFXDa5VInWyMwkTpqchRJ/DeVZqObrZKPa?=
 =?us-ascii?Q?acUGADNZUJirsyY0QKVjUADNRxQgW0/3JhW7xahw0e8A5kLcS7DyZiO2kusn?=
 =?us-ascii?Q?szrkuao7lfYlKIQ+NyD/PdPNxE8p3GKv4in62yLwoHdVo/9rk9McVyQvqNLc?=
 =?us-ascii?Q?ZpsXnHk21VIcMDHHtwmLZP/IYCiI3fDUXbYHblM869HOzRbJamnssPYRms0J?=
 =?us-ascii?Q?jtG2fBogijS6aeRcQWEAIbRN/j0NdqHHBv2tmGZRhHl2kwm3EEXd0S4JO7jO?=
 =?us-ascii?Q?sWMTTzmkCI0toHbmXePzLnW93VmXzoAwa6JnLV8JL/tdlu81OUSnHyEU2asx?=
 =?us-ascii?Q?zbEjoXfFbEVedkE+us9ZHKuw59JkU4SRspI7U7/K3+sg96M7rmWS0Jk0EFuX?=
 =?us-ascii?Q?ldmoeyEJCME2RZvWzSrDmSlcT5wzybdIFV7+PC5H8ALkc6PiXtlFNCPyMt+4?=
 =?us-ascii?Q?ayz8RAE8IbAcQxuSwOU4GNC5cKU8FdE/Xt0vfIOWDenGo2p3m5SQ6RGCvksX?=
 =?us-ascii?Q?E8H/mQs3INUt8ra38KeMjQmJT1wBT0vd6IscFqLk0M9zUpgWUkBwkfgDhARr?=
 =?us-ascii?Q?o2PKQjbUmGfN8hi1xzgVr95IKLvFcJQzx9tpoIuJ7VOIGkd0R6x8g+uVbofu?=
 =?us-ascii?Q?/msxkTcPl+dg4qIvUptQ/R/cvEOm2eoeeKM0MVvxy0rwmyB4gOJRqGMmNTDA?=
 =?us-ascii?Q?NlOMBov3RAgqCov1ij6msEh0GFA/KlkAkOUkQu0nR8EGWmbS2dvT17/Dnc+H?=
 =?us-ascii?Q?s9Kzb9urW+kTfMbNadciL4cLn/blUhsOTjxwYYW/pvZWMZRk8YldPp63Vb2j?=
 =?us-ascii?Q?z4hVNXwRcKoXOfbQoixyk1R72BMo6K3lqYlH3oFlpLeDoz7TnWm5urzYKQYA?=
 =?us-ascii?Q?gIzqw0Nw/aUihezEGE599AA5XOxFV5LRnGf2ak5hTr2CsZj4wW1xkOnEKhGz?=
 =?us-ascii?Q?DouxcTwsbYr1m3U1uhAmFvb4r7MgTuZru+1Z+YtuM5jYn02V53iiNwycDPJp?=
 =?us-ascii?Q?XRgTXEvfBh9L5Zp7AwXEXU4=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 350c5fef-b405-474c-85dd-08d9f0266127
X-MS-Exchange-CrossTenant-AuthSource: SL2PR06MB3082.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 01:56:28.1851
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MesX6WPaJ56e7udwMc5quBO9Bo++SBp9oZSEvycwae7SZxjgXI1hb0rilNxKSpPKAc5JKBC38ib/K74jMaT0Pg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY2PR06MB2767

From: Wang Qing <wangqing@vivo.com>

Use the helper function time_is_{before,after}_jiffies() to improve
code readability.

Signed-off-by: Wang Qing <wangqing@vivo.com>
---
 drivers/gpu/drm/i915/gt/intel_gt_buffer_pool.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/gt/intel_gt_buffer_pool.c b/drivers/gpu/drm/i915/gt/intel_gt_buffer_pool.c
index 9db3dcb..b289abb
--- a/drivers/gpu/drm/i915/gt/intel_gt_buffer_pool.c
+++ b/drivers/gpu/drm/i915/gt/intel_gt_buffer_pool.c
@@ -56,7 +56,7 @@ static bool pool_free_older_than(struct intel_gt_buffer_pool *pool, long keep)
 				node = list_entry(pos, typeof(*node), link);
 
 				age = READ_ONCE(node->age);
-				if (!age || jiffies - age < keep)
+				if (!age || time_is_after_jiffies(age + keep))
 					break;
 
 				/* Check we are the first to claim this node */
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Tue Feb 15 01:56:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 01:56:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272666.467567 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJn4r-0006JH-CQ; Tue, 15 Feb 2022 01:56:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272666.467567; Tue, 15 Feb 2022 01:56:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJn4r-0006Ip-4v; Tue, 15 Feb 2022 01:56:25 +0000
Received: by outflank-mailman (input) for mailman id 272666;
 Tue, 15 Feb 2022 01:56:24 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=A2Di=S6=vivo.com=wangqing@srs-se1.protection.inumbo.net>)
 id 1nJn4q-0006If-8S
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 01:56:24 +0000
Received: from APC01-PSA-obe.outbound.protection.outlook.com
 (mail-psaapc01on20725.outbound.protection.outlook.com
 [2a01:111:f400:feae::725])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7774c637-8e02-11ec-b215-9bbe72dcb22c;
 Tue, 15 Feb 2022 02:56:21 +0100 (CET)
Received: from SL2PR06MB3082.apcprd06.prod.outlook.com (2603:1096:100:37::17)
 by PS1PR06MB2742.apcprd06.prod.outlook.com (2603:1096:803:44::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.17; Tue, 15 Feb
 2022 01:56:14 +0000
Received: from SL2PR06MB3082.apcprd06.prod.outlook.com
 ([fe80::80b4:e787:47a9:41bb]) by SL2PR06MB3082.apcprd06.prod.outlook.com
 ([fe80::80b4:e787:47a9:41bb%4]) with mapi id 15.20.4975.019; Tue, 15 Feb 2022
 01:56:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7774c637-8e02-11ec-b215-9bbe72dcb22c
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jpBhjiCt+TR1oD+9SisslBFxuxAzwP3RmV1SRP2G35tgwo3R8fP4B9vzyGNa4CXV8TJzmAPqnAUKZpl2Xu54jNM2zh8RVy/ccZxhfw4Rk+PS2s2WS9im5Tuge5eS18YtijToo3lcSi96fEE7kO/OfYjAodylEiGL3YpJ7hHAeDuvGAOX8LK/NOBIST9pBIs5AnNeCCxPeHizn6a6/pSOzHnFnzMgckyaf16pYdwnfya9NvN2RE53MQ7zKULQlYT7Dro9BMzONtBqoJAg5dVPNHgjELhKhgsY5KseFRPpwCXi0M8sVojwkDpcy8oM+FC7TAMdwJpMOoq5cpZq8q1nRA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=cVSv4id1XvIEsR0JQdTE4jLw7iNsPW85tN4HhR4261s=;
 b=nkElgxMN/UGeiy+TNa1IpvRPTSijX06B9X34/RBnWhhWtWs7/8uk9Ey6Sy3ZrSDROP8IP7ZvRbHhqxDYYTCBtiMM5826UfGHvyzDvg7JwEaTScq85nKY8hMfgMxmJtKJvICyYHqWeKQbBffzh+07ObzmWUwiXTs/IaThnhIxivZJ27nL1zGT5hkdV9loo5RG684YJmY5UQS5bZWSUrIOHxf0XemLHNleQnsd6Q2MMdJHc7HWcKsd1TPbQKF64Y4rrvHSqAcsk7O3p5lXWOw/Oq9KhqOLUkJY523lq0/r9CCHEINJb6klbTakDo3BN9yjfbi5tEKSTGwneaL/tLgpew==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo0.onmicrosoft.com;
 s=selector2-vivo0-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=cVSv4id1XvIEsR0JQdTE4jLw7iNsPW85tN4HhR4261s=;
 b=ddeIggz159DjpX/qqvxxJYqJtFtsN43d6T9NtxuKvj68eYi+qLHLsuFfwuAYqqNwtMJWWvUaUMM3fPfgYUscS1qeI788JtE/gJNxsLTOZdi/fKedL4RSJSf5qN5X0113yXBL7HGeT+Cnd8ceU+4fSUG9L1CwGVvfFzqATsWgG0w=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=vivo.com;
From: Qing Wang <wangqing@vivo.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Jens Axboe <axboe@kernel.dk>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel@ffwll.ch>,
	Alex Deucher <alexander.deucher@amd.com>,
	=?UTF-8?q?Christian=20K=C3=B6nig?= <christian.koenig@amd.com>,
	"Pan, Xinhui" <Xinhui.Pan@amd.com>,
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Alasdair Kergon <agk@redhat.com>,
	Mike Snitzer <snitzer@redhat.com>,
	dm-devel@redhat.com,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Hans Verkuil <hverkuil@xs4all.nl>,
	xen-devel@lists.xenproject.org,
	linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-clk@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-input@vger.kernel.org,
	linux-media@vger.kernel.org
Cc: Wang Qing <wangqing@vivo.com>
Subject: [PATCH V3 00/13] use time_is_{before,after}_jiffies() instead of open coding it
Date: Mon, 14 Feb 2022 17:55:37 -0800
Message-Id: <1644890154-64915-1-git-send-email-wangqing@vivo.com>
X-Mailer: git-send-email 2.7.4
Content-Type: text/plain
X-ClientProxiedBy: HK2PR06CA0012.apcprd06.prod.outlook.com
 (2603:1096:202:2e::24) To SL2PR06MB3082.apcprd06.prod.outlook.com
 (2603:1096:100:37::17)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 065ee1a7-5587-4384-3f5f-08d9f0265906
X-MS-TrafficTypeDiagnostic: PS1PR06MB2742:EE_
X-Microsoft-Antispam-PRVS:
	<PS1PR06MB274236C9FD5C5DEA7D6B7C36BD349@PS1PR06MB2742.apcprd06.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3276;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	9FIrSayWKZ8j6bJaLnXRVXkxeeoaz+2X+fZyNQFaN2kAW+pPY/0SPu6gBiWhwkTARxPQYDMiLe7MDAlnDaK9iwA6DRW7gnvyXovboKtpHm8pLj52x86aGG0bObeKgRoYNhGdsEIbC8SykF4gclyrpz1Me95ioEx6fgC+f7IeoqW2S8ZKzyMiN2KqFWOBJT3pdxbLP7f82Om51xkL84/3ZHlEr3ycdBKj8vOuaDoyARYD+GYYFqehvDjMsRaorDvdIRDD5tmheAft+0JH4MniHMzLGU5KUXUXGAII3RYwRJVbCKUOADLDK73l5PVvy1ecateULtyFx4fNppHpT9tp374A42+QdGhPaQjAbnMUNKq3/QS6J9KZzKExKOoaUXCsw9q3ETf1emX/KqP/rPptzrrTblp+ME8t5szEDZSFGdy6Qx9JqAosvQXcU8dQ+B66GG9Fy0WDRONz20q6y74ZHN6z7ZF7zQxWsyBDMuICdsHUFlTZYNsZorIP6vR9U8dZvrOew/f0Wfxr+A/Jgiz/n2VYBd8qz/8cJsVYjTJamhEKqncdho/8uOowl49POqBccEicoLsbHdGcSeALavTLX4QvUKbB/lMKcpyvWyb8URypSBvEqfyqxM0OalztZvQFH9nFKQFkGIPhZWnT2my4bw/w0k//BJRCkXn38klTTYjP9epuJFrCKfwl1R1VdgMB+7lVXiRJpl2oPpEVTigTUyi1uHHRqfvkxP8q5YdvZe4a5taTmNQj1gZ7PNGdCvU0
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SL2PR06MB3082.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(7406005)(66476007)(66556008)(6512007)(6506007)(6666004)(110136005)(8936002)(66946007)(508600001)(52116002)(6486002)(8676002)(316002)(86362001)(4326008)(36756003)(921005)(83380400001)(107886003)(26005)(5660300002)(7416002)(38350700002)(186003)(2616005)(2906002)(38100700002)(21314003);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?Q0EMyZeaFN8KzbL3iUiyuXPn4zqLctRDhl2oM5AW81nmgOD27y6wA7I4jWFQ?=
 =?us-ascii?Q?L/JmXvMM7fXf9FIBfT8clFjwl2ObyWCRjD082rlUj7fY5v5UW99lf17J5K2/?=
 =?us-ascii?Q?6C522xph54B69Iv086pvlvD/LIW31Ub5rZAweDorV+ArkNO4A8631QKXOZwR?=
 =?us-ascii?Q?+Z4em4VVp0eI5Y7of7plCtAXS6fv12u7Uw15BDQJQIlzbxx1ltsmro9HRX3O?=
 =?us-ascii?Q?G75/yk/Uy4vTPpGmQSOZ9Mos80QWLZjvjXs7v+05yTWa80Nxm5y2G6LQxpaU?=
 =?us-ascii?Q?4CJ0/bcAhAWwBXtOzoIG9lp7wZm1vZXUVjUtmkiPBcsoWN0I2zgGHBtzwJDA?=
 =?us-ascii?Q?HG8fIEu/RNd7XoiblVt0lElA+/l4ycyIUfoaKrSwzJfeTJCDp/ozPbEXCqlP?=
 =?us-ascii?Q?p6OnIUSEOAcUFan4XGYJFE8QNnsw5BQ0zFnnXa0SSMR0WeRm2kUoB7NCFcNK?=
 =?us-ascii?Q?loJux/gTqUKclmp3Y/Qd4kN6IfATycXhVZlME67YogTSgipOdXzftv1vewL5?=
 =?us-ascii?Q?TMuw9GrkCXMvgjuWpnNLzI8TrzDDZEjk9zBuan6vSROm5cLkJFShVlM50CQN?=
 =?us-ascii?Q?7s/Zji0QPKLBKN/Ym1TLhw/C+y8g+yTcrJta2rLpVa7jpB5cWIu4FrXewQaa?=
 =?us-ascii?Q?Zu5U/p7f8B7qM0vu340BWF6h914Zx4E0AXkJ+Ktf9Y70NLWWnTWr4Yg178YG?=
 =?us-ascii?Q?Ao44D6aBw8WvrCz2JYaU3s04jLPgg750gEnQbMPU6DgN6kwZW0PH++HNyKpX?=
 =?us-ascii?Q?EUrGDUbmDk09CeKg4QVKEkZ54a/CoPjWa6xAXN69rbUY5q5nK79qUvlhJ1Ii?=
 =?us-ascii?Q?amvnKiO1w+Q2nVfQOznlRnizCBvaaarVIsyYCM1umbhU9VJYbTeloNdzaKCj?=
 =?us-ascii?Q?yu4KokjHBflkqOrZuOXcFo34eM80O/Opn8Y3ZErXMKfPZ4oDKOfd8oErQDIb?=
 =?us-ascii?Q?m9J2LrQYQeA/22B4bmdWDgbeBVNZDs/YKpmc8tZ14dNCWUBFk6IUO7HGsJwM?=
 =?us-ascii?Q?w3+07a62+MwaBwTCPZiV8t0ZIB3/Bk+elgvS9/HgYjQVfOJzsbjBLBEUQ1dM?=
 =?us-ascii?Q?xCt+xBR6GqeLUwTC+kSiFbxcurTN8p0CO44zccVd+S5r/K1zCVclEWcq8ooq?=
 =?us-ascii?Q?M68U+WXMet0TcDXTg1b21vB7zgSX76mzz7+uMvuKSFRltiSmjRCHfAgCZWip?=
 =?us-ascii?Q?SMTu2CLkcwsogr1KKjGobV0THR1qErMZTaPAuukgM9DyCPAPIH2iLL6/CkDy?=
 =?us-ascii?Q?bHMV2FLqtNpYrs1Pg5DhgAdTj977S6rxjzxxHvPbdJpa7yafdzPFJxpdW3/w?=
 =?us-ascii?Q?WzGNnzm0bxYlpx6KeouswMDEO3OpP+CAIUoVsAikPUgCIpNLK2WuYBg/I0iX?=
 =?us-ascii?Q?k7NOFXfYi6tBRHOJIOQ0wzvfc9TNEu3NuWfcDFHUtw60v++Ki2raC0MxihKV?=
 =?us-ascii?Q?qkE2EeOgmMJpCLF8t2cQOAEVppaXY9Kb+9hpBWodqJx8aKCXkNgaPPHvV1fr?=
 =?us-ascii?Q?jCDj0jzgYwfG+BscxhhqGbMyJJvXw+ScPdOUNrE3hkTk49CVkB4doNZ0RCin?=
 =?us-ascii?Q?w5VgF4OhvN9xLBUH9LBkYElj9+/Q4f+giXNum49N1ORdUIG7cFIZSa0bJhJd?=
 =?us-ascii?Q?c9m71z/pz9iCb0mjbni885k=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 065ee1a7-5587-4384-3f5f-08d9f0265906
X-MS-Exchange-CrossTenant-AuthSource: SL2PR06MB3082.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 01:56:14.6859
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FwX9eHgjgcKWIuhu3mKyHYT0zeOt0HhV6v9Ys1mfhzViOMm3Ws3VRWJM56jBXfEPoJeNw+K7OVowG0jYVHi6CA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PS1PR06MB2742

From: Wang Qing <wangqing@vivo.com>

Use the helper function time_is_{before,after}_jiffies() to improve
code readability.

V2:
Batch them in a series suggested by Joe.
Use time_xxx_jiffies() instead of time_xxx() suggested by Kieran.

V3:
Fix subject and description suggested by Ted.

Wang Qing (14):
  block: xen: use time_is_before_eq_jiffies() instead of open coding it
  clk: mvebu: use time_is_before_eq_jiffies() instead of open coding it
  gpu: drm: i915: use time_is_after_jiffies() instead of open coding it
  gpu: drm: radeon: use time_is_before_jiffies() instead open coding it
  hid: use time_is_after_jiffies() instead of open coding it
  input: serio: use time_is_before_jiffies() instead of open coding it
  md: use time_is_before_jiffies(() instead of open coding it
  md: use time_is_before_eq_jiffies() instead of open coding it
  media: si21xx: use time_is_before_jiffies() instead of open coding it
  media: stv0299: use time_is_before_jiffies() instead of open coding it
  media: tda8083: use time_is_after_jiffies() instead of open coding it
  media: wl128x: use time_is_before_jiffies() instead of open coding it
  media: vivid: use time_is_after_jiffies() instead of open coding it

 drivers/block/xen-blkback/blkback.c                    | 5 +++--
 drivers/clk/mvebu/armada-37xx-periph.c                 | 3 ++-
 drivers/gpu/drm/i915/gt/intel_gt_buffer_pool.c         | 2 +-
 drivers/gpu/drm/radeon/radeon_pm.c                     | 3 ++-
 drivers/hid/intel-ish-hid/ipc/ipc.c                    | 2 +-
 drivers/input/serio/ps2-gpio.c                         | 4 ++--
 drivers/md/dm-thin.c                                   | 2 +-
 drivers/md/dm-writecache.c                             | 5 +++--
 drivers/media/dvb-frontends/si21xx.c                   | 2 +-
 drivers/media/dvb-frontends/stv0299.c                  | 4 ++--
 drivers/media/dvb-frontends/tda8083.c                  | 2 +-
 drivers/media/radio/wl128x/fmdrv_common.c              | 3 ++-
 drivers/media/test-drivers/vivid/vivid-kthread-cap.c   | 3 ++-
 drivers/media/test-drivers/vivid/vivid-kthread-out.c   | 3 ++-
 drivers/media/test-drivers/vivid/vivid-kthread-touch.c | 3 ++-
 drivers/media/test-drivers/vivid/vivid-sdr-cap.c       | 3 ++-
 17 files changed, 31 insertions(+), 22 deletions(-)

-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Tue Feb 15 01:56:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 01:56:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272670.467611 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJn54-0007VJ-Je; Tue, 15 Feb 2022 01:56:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272670.467611; Tue, 15 Feb 2022 01:56:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJn54-0007V4-Fv; Tue, 15 Feb 2022 01:56:38 +0000
Received: by outflank-mailman (input) for mailman id 272670;
 Tue, 15 Feb 2022 01:56:37 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=A2Di=S6=vivo.com=wangqing@srs-se1.protection.inumbo.net>)
 id 1nJn53-0006If-JT
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 01:56:37 +0000
Received: from APC01-PSA-obe.outbound.protection.outlook.com
 (mail-psaapc01on2070e.outbound.protection.outlook.com
 [2a01:111:f400:feae::70e])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 813161d0-8e02-11ec-b215-9bbe72dcb22c;
 Tue, 15 Feb 2022 02:56:36 +0100 (CET)
Received: from SL2PR06MB3082.apcprd06.prod.outlook.com (2603:1096:100:37::17)
 by TY2PR06MB2767.apcprd06.prod.outlook.com (2603:1096:404:3b::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Tue, 15 Feb
 2022 01:56:32 +0000
Received: from SL2PR06MB3082.apcprd06.prod.outlook.com
 ([fe80::80b4:e787:47a9:41bb]) by SL2PR06MB3082.apcprd06.prod.outlook.com
 ([fe80::80b4:e787:47a9:41bb%4]) with mapi id 15.20.4975.019; Tue, 15 Feb 2022
 01:56:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 813161d0-8e02-11ec-b215-9bbe72dcb22c
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=j8HsjUAuDiZGrS+c5lMaeW/BUR04OhMOIiaHpwcXilk67d042aYhjL4MTFhbM8/Gu2Cnl4yGuLV3EjS0tbgN3DMepNqz5TdP8UazPNtWfWp4o8eHPREV5vVE7KmwyK4/pPOFFcORr1kML7pZQce3QbUdWmWpxzSWwcdo2AmwWgmqnQGpxyOh+XMp/gGGlDgsWkxHimTTN2ccP4nvb+QtKcJi53FnN60cdiKe45AQMPtoya13t2CIfCwtFPP84efasEY/xd6ngzeRJeBQvM8/nlmbUZM+YziQ2fVjvw6LXoL3J/0OYzJpvoKTAIGWfYsq5FyLeNkcJEmyV8T88gdwXA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=RSlH34ordkui5eg5FB2b69b904l/QW4ClOKj8NHGi60=;
 b=V3PNVDh9GnraROZp6RiPBqnDj9FFMnQUshnDib0a8KZSwlZ4aPObJd//POXWqx4WZpOBxA3U3FOcQ45CsPbKFFxJm7gdU+lCNSR6OaYwUwbj3yw7IpF/9vPEZlhvycR/2HS5B3qKhVyQNlQsjwEISP5xFkbvmRXzLk8jf41wAOqnVHsEh6214k3BfTQQhty1oAn+jeTjsJ44SsvkIHfA/pg8KSY4Wxr+Qxb/QvvhEsBsLrefWN82TIZmUCPfOWuPAZf2Ognp7VS8+g4RUQBUhL3EeGPMGZqg8dgKxhFHzJ6tJ6UGdLtNirb9ZrAU1j3rjSUbM4FVOnWsLV33EiCsDQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo0.onmicrosoft.com;
 s=selector2-vivo0-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=RSlH34ordkui5eg5FB2b69b904l/QW4ClOKj8NHGi60=;
 b=W+3TM2uxcaMpxt2um+Mpvzt5vPu6uK3hkzpD5sfwGd6feNFiPYJOHMckmcMQo9XMXc9memZPp9G4yBCRI7LNwSsya0FlheOscKN2NIcj85FV26ja7ck5Fc4bgMj4aYzSlnb8nuWh/2HqeY0HVYpldwCpMZN10mUy+0L1HNrL2oM=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=vivo.com;
From: Qing Wang <wangqing@vivo.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Jens Axboe <axboe@kernel.dk>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel@ffwll.ch>,
	Alex Deucher <alexander.deucher@amd.com>,
	=?UTF-8?q?Christian=20K=C3=B6nig?= <christian.koenig@amd.com>,
	"Pan, Xinhui" <Xinhui.Pan@amd.com>,
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Alasdair Kergon <agk@redhat.com>,
	Mike Snitzer <snitzer@redhat.com>,
	dm-devel@redhat.com,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Hans Verkuil <hverkuil@xs4all.nl>,
	xen-devel@lists.xenproject.org,
	linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-clk@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-input@vger.kernel.org,
	linux-media@vger.kernel.org
Cc: Wang Qing <wangqing@vivo.com>
Subject: [PATCH V3 4/13] gpu: drm: radeon: use time_is_before_jiffies() instead of open coding it
Date: Mon, 14 Feb 2022 17:55:41 -0800
Message-Id: <1644890154-64915-5-git-send-email-wangqing@vivo.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1644890154-64915-1-git-send-email-wangqing@vivo.com>
References: <1644890154-64915-1-git-send-email-wangqing@vivo.com>
Content-Type: text/plain
X-ClientProxiedBy: HK2PR06CA0012.apcprd06.prod.outlook.com
 (2603:1096:202:2e::24) To SL2PR06MB3082.apcprd06.prod.outlook.com
 (2603:1096:100:37::17)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 38200d9f-f936-4add-fa38-08d9f02663ce
X-MS-TrafficTypeDiagnostic: TY2PR06MB2767:EE_
X-Microsoft-Antispam-PRVS:
	<TY2PR06MB27678FA9AA8B49BF44E6AB2FBD349@TY2PR06MB2767.apcprd06.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4714;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	cg3mXU7BWZZX2gpu1DeSE9r1QeOTrZaWzbXV9fQQE3vaPQlXUz3BZdNXCkoNksIl5vTozGlD8Gj2+CmYAyyXcHBYd8DkT+7NUb8oRLO6thvDkhbgh/Zan/ZryZuskYi6YuoW2Xg6E07AtVQeDCBgWb+ww6qIvZWQBROk0933tOHA1JmERHyCVNXKNb0jDvi4Q5w4tnCVyPKRlGCgk8s0QxAjKXQiddkYA3DYJrkl6r9okpDj2hTbHzOaWy8ffqc4QzasHEg0uZLmKx38zGpStlJDuhSZmgAZ+VdJ8F+5z0yomWBck5miPzz1dRg9xwU/glpv8RyzUm+CGYvGru6JDqgGIDDuK0U2ksW6ksyZy43wGFShyqB0b763MsZSezAZCHd7Rwf/P6fw37zHvbJtoy6h+AfRG0DvrYr3NzpO4/4tbzm4qDcGCqz75/DDY91ixbS7h0ctOVe9p6V2QGfVlDtj4yx3XjpJb89RC9MOU3cbZZlmfUWSe3DLCrPJkn1hhx98B/GAZgxRQ7xJ2MfRS5X5F2xgaej7wHfIPceFe3cOH4o60C1EHA9ufsBD3mUXPrTWUEkZ2+ZooDdsp3hgHZtcdkKLftlHQIkbX8hE/ydLDomCujLgAUp2+n/aNCp0Pca0D940P4Vqf7ar5TCxzK7kVa5GFk71uHEADgNSZst1KZscU5sy/EFZxx8HFszIlVlvJ63hsLI1Q1vM0SY2ObLLjx4JmVGqtW/WyJ8aKGA=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SL2PR06MB3082.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38100700002)(38350700002)(7406005)(7416002)(4744005)(110136005)(107886003)(921005)(316002)(26005)(186003)(2906002)(52116002)(5660300002)(8936002)(6506007)(2616005)(6512007)(6666004)(4326008)(508600001)(86362001)(83380400001)(36756003)(66476007)(66556008)(66946007)(6486002)(8676002);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?Omh3Yx//sPFK4LbBNvrYl+g310Vjw96sOgDDxTpNoa0z94woUqmxXw2cXufq?=
 =?us-ascii?Q?YNW7NMqgImOnL3vjUfqr6wpZDac3CV3wLwjaPy3Bk4jpxnSHj/Ze0A8E1BUc?=
 =?us-ascii?Q?B6WaNlIFq5bgHa4HMpZyWStgPVNUk2UrbhtoQK2COJvvgyNe9TgD/TEQLAI+?=
 =?us-ascii?Q?mMMeyPGfvEn5TpW2Jc5B+/Q2IZuFhn13i4b4wkuOqipgIQF9tHwZz7j/QJ61?=
 =?us-ascii?Q?UTy1AC+bUFMCEARaW74LGLBrwRi4e+tuEMUvXapESmMJMYF52sRM4GcYD7rb?=
 =?us-ascii?Q?yfPPB0mq7/U86MVeRRGosvIDrjJtnV7hJCvBROHD3Qy8G7meUeaAH9TWj3PX?=
 =?us-ascii?Q?MB2LYhLRLS16qwCQug6wcPoun4ncnj7OBrtGUexCIBHWs39JqPBtZbR3JSbe?=
 =?us-ascii?Q?xNbgAaU0breJ0U0/5w0lkwQdSNKk/7WIECo8y77rGpbW3fdZknljz2fKPeBU?=
 =?us-ascii?Q?QufXnf9jYQ2NneVmG38FJB2dutp0oZeu8ACPSOI0PFdrBmTdVBdx+8YITHTG?=
 =?us-ascii?Q?pCdoIbhid8isjuftnY+mHO26uQL+AKj1kLZvqdDyFg5VzRApqTquQlmyZ8LT?=
 =?us-ascii?Q?TAehL2LALTzBiT2P5WpiW18Twgf2Eiw21Z4Gy9+q964mgwLWROZnF3GO2sS2?=
 =?us-ascii?Q?l+NKe24FoIJH1CGx0gRTS5SvMI+Y4PAviPHGqtKKghOdmbfXv9jTM6cAS2c6?=
 =?us-ascii?Q?t2MuiUq8F4eyF28XPcD9B0xL2/KdIwj7W0ahQrYZtI65KaMG7ZooIwqt/g8i?=
 =?us-ascii?Q?NEJJfHSlg7D5w2M3SblxHwfJLnmfVlWhHkELudfxlvYBRcqQs3d/N2lUYXQO?=
 =?us-ascii?Q?ZTZmo5FF317novBRHUNtyq4ep9b99OiFHaEA4GbpOfZQis4wCffpAtWlJiWT?=
 =?us-ascii?Q?XRgr5ILc7gdXgFMMNfA4jpbOzCtYmoecMUvm/M1TPKjSA/05W+QT6o1vHxeU?=
 =?us-ascii?Q?RFlptPShqGCHgsJx1WldLuR24YaIUKATHlDLo8F9s3ZGV8ybTzc9ndwJRWiz?=
 =?us-ascii?Q?+6ys0W8Iih//fZuWTsxkWbH6aJV7l+AZEU7iQ59f9LN5a5IPpYQ0cFWgAOzn?=
 =?us-ascii?Q?HHeOeLdoDSFMU+Qu1H6YFESId0q3UZ7KqkNPCdnUpZSNXGGw07zWZJp1jttm?=
 =?us-ascii?Q?x0UkcrFtyjbsZw/riF31hpKd0xKJfpETcOjnpVg1IQEGeAXL0ujwfdjvyhyI?=
 =?us-ascii?Q?nFt/anRfOq4/+RD2/jEzHjMny5Kmc8/SHHhsntELHDsQJ7I0Mb/+gSZzJLyo?=
 =?us-ascii?Q?9A+UwWnf3AstXAY+AQKzCapssWAXB2YKKEWLhjGvFlUA8nAI/Zz9AwKZ5onz?=
 =?us-ascii?Q?0em5NDe+992CkefbFXJgiRgENNhu4tp/yOhsuA+6mVCbQYNq3Ptp7Ze/B2Z3?=
 =?us-ascii?Q?nDzAk2zeeQ73B8FrK/UwtMOV2GsV/oFeyiexqJ9pXXuFsAc18VNRk5sULrpT?=
 =?us-ascii?Q?O47d3nZXttoggk0mmnY/di0oBJe7PYYuESPHYw6d+K8F/mB5F6hlBVp4/BnV?=
 =?us-ascii?Q?0yicqMVQ7S3Cq4F1fEdvDrmJ2EJqJ3Jco8qszuSJsuw92mJY9Y9m7unOtP3S?=
 =?us-ascii?Q?XaTVf2jge8xu0I3IA2luGsyvOEBuDnx1q823S3Ar2TdxFtrsOZ5vraCBI5xE?=
 =?us-ascii?Q?wva1BjD8btIX4jqpW32gXnY=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 38200d9f-f936-4add-fa38-08d9f02663ce
X-MS-Exchange-CrossTenant-AuthSource: SL2PR06MB3082.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 01:56:32.5443
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hIn5iwj1EgCSFXWVwDmfDj2iBmBLasb9+7fAuSjo2wPX/x7UYTBLiuJ5wl+rG5+uSU+IidQrC2kqnHPKNtXtwA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY2PR06MB2767

From: Wang Qing <wangqing@vivo.com>

Use the helper function time_is_{before,after}_jiffies() to improve
code readability.

Signed-off-by: Wang Qing <wangqing@vivo.com>
---
 drivers/gpu/drm/radeon/radeon_pm.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/radeon/radeon_pm.c b/drivers/gpu/drm/radeon/radeon_pm.c
index c67b6dd..53d536a
--- a/drivers/gpu/drm/radeon/radeon_pm.c
+++ b/drivers/gpu/drm/radeon/radeon_pm.c
@@ -25,6 +25,7 @@
 #include <linux/hwmon.h>
 #include <linux/pci.h>
 #include <linux/power_supply.h>
+#include <linux/jiffies.h>
 
 #include <drm/drm_vblank.h>
 
@@ -1899,7 +1900,7 @@ static void radeon_dynpm_idle_work_handler(struct work_struct *work)
 		 * to false since we want to wait for vbl to avoid flicker.
 		 */
 		if (rdev->pm.dynpm_planned_action != DYNPM_ACTION_NONE &&
-		    jiffies > rdev->pm.dynpm_action_timeout) {
+		    time_is_before_jiffies(rdev->pm.dynpm_action_timeout)) {
 			radeon_pm_get_dynpm_state(rdev);
 			radeon_pm_set_clocks(rdev);
 		}
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Tue Feb 15 01:56:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 01:56:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272667.467578 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJn4s-0006Yf-Kt; Tue, 15 Feb 2022 01:56:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272667.467578; Tue, 15 Feb 2022 01:56:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJn4s-0006YY-HD; Tue, 15 Feb 2022 01:56:26 +0000
Received: by outflank-mailman (input) for mailman id 272667;
 Tue, 15 Feb 2022 01:56:25 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=A2Di=S6=vivo.com=wangqing@srs-se1.protection.inumbo.net>)
 id 1nJn4q-0006If-Uv
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 01:56:24 +0000
Received: from APC01-PSA-obe.outbound.protection.outlook.com
 (mail-psaapc01on20725.outbound.protection.outlook.com
 [2a01:111:f400:feae::725])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7997fce5-8e02-11ec-b215-9bbe72dcb22c;
 Tue, 15 Feb 2022 02:56:22 +0100 (CET)
Received: from SL2PR06MB3082.apcprd06.prod.outlook.com (2603:1096:100:37::17)
 by PS1PR06MB2742.apcprd06.prod.outlook.com (2603:1096:803:44::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.17; Tue, 15 Feb
 2022 01:56:19 +0000
Received: from SL2PR06MB3082.apcprd06.prod.outlook.com
 ([fe80::80b4:e787:47a9:41bb]) by SL2PR06MB3082.apcprd06.prod.outlook.com
 ([fe80::80b4:e787:47a9:41bb%4]) with mapi id 15.20.4975.019; Tue, 15 Feb 2022
 01:56:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7997fce5-8e02-11ec-b215-9bbe72dcb22c
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=hxyekOn0xd0uRDjnw1EIkkk/TVW22iJ9jUBd7X/zYE80yhB9wdYFd7p6L+jNm7o4nmMSRQUH/zzdBEy3logJYTJbDU7bPeNkTgZ5P61r6h+5cKxMD057v5KFwXbI8RPrOCvD8WAUt2hKlnYIRMWvLDcEMiDceRXW9ZfrbAMmyMwty00ADqiRz3vbP0hJPBVe70dabU+QPWuE/xcmuLVtLp5i1msrdTYAdPhOWfLCKqc/iPvYrDPpxvavHIi1liEumNlrDWhqSX6FwtuAap1/Ucy8fBH/XbA7noygUIa0LPyU8eIUZ0jhMNVu4RGnSSIk6Rcb83uuiEGlIzWCSdfCvA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Bemy+Gq7ABlPwIU++P44NvR//lf8OkN3Np/nSYUmUPU=;
 b=BYU1E91EIYLKq2q0ugclQNVMVovtsuuVZ2TANYrpY6kGyvOVIECfhGd5udaua9M6SqJpDEAND0CEu9JFt/TaiQw8gSUXLynSC2zE/yhOZc4DhGb08doE5dIjRJsKygLzEm2I6XTCfRjy7xrufHZfYLQRa3d5b5+jXJF5ADTsu2G5Q1LNhTBECr3orzFi6qZfICYLHag2HjaMqhJ/zc7i2gfahLMbOpExDozhzJo4C0MeczAJBcpO2y+l4l47MzowVWcjOT/KLY2Y7qUgcp6i+xrlOCVd1IbLm3uNer/3/fc6YTz6e14rXYHw2Af0hAS08/0EZNUx3EdCPG0iyyM9xw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo0.onmicrosoft.com;
 s=selector2-vivo0-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Bemy+Gq7ABlPwIU++P44NvR//lf8OkN3Np/nSYUmUPU=;
 b=gH8/KWPf+iZDwo2egUH/t5w3xd0OppjMijYZda1yVspD77clE/jzO+F6NIPEY3uEM4mNzx+mDB+96YpDvuKNdmcvCNjzEpT2riGdpHyUVIFa9Rs6Lc2pbnMhsXmY7motHOctWjKSs3caBNvYYwfIkVRzUL6EvUVKoTx2P2n+zxM=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=vivo.com;
From: Qing Wang <wangqing@vivo.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Jens Axboe <axboe@kernel.dk>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel@ffwll.ch>,
	Alex Deucher <alexander.deucher@amd.com>,
	=?UTF-8?q?Christian=20K=C3=B6nig?= <christian.koenig@amd.com>,
	"Pan, Xinhui" <Xinhui.Pan@amd.com>,
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Alasdair Kergon <agk@redhat.com>,
	Mike Snitzer <snitzer@redhat.com>,
	dm-devel@redhat.com,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Hans Verkuil <hverkuil@xs4all.nl>,
	xen-devel@lists.xenproject.org,
	linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-clk@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-input@vger.kernel.org,
	linux-media@vger.kernel.org
Cc: Wang Qing <wangqing@vivo.com>
Subject: [PATCH V3 1/13] block: xen: use time_is_before_eq_jiffies() instead of open coding it
Date: Mon, 14 Feb 2022 17:55:38 -0800
Message-Id: <1644890154-64915-2-git-send-email-wangqing@vivo.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1644890154-64915-1-git-send-email-wangqing@vivo.com>
References: <1644890154-64915-1-git-send-email-wangqing@vivo.com>
Content-Type: text/plain
X-ClientProxiedBy: HK2PR06CA0012.apcprd06.prod.outlook.com
 (2603:1096:202:2e::24) To SL2PR06MB3082.apcprd06.prod.outlook.com
 (2603:1096:100:37::17)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: bb48ae59-c9b7-4af7-8709-08d9f0265c03
X-MS-TrafficTypeDiagnostic: PS1PR06MB2742:EE_
X-Microsoft-Antispam-PRVS:
	<PS1PR06MB27423EC36C6F9582DAF639D1BD349@PS1PR06MB2742.apcprd06.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:663;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ehW9dcRQCl7K0OMhzYVyylPcjX6nmo4VnlZxjXHT/Hbn7cG/CjXh2qgz1JMDO7YB3r12scgWD2Bdr92pIAh42huOKciVe14TRT1jHAM7qzCJoA/wFKQaaK5lqsvkXJTOIFWhuiCSX8FigPl7Kehj9sLOnbeeBcpPY6zUwiKLs0xATy3fyWIa+1ZRBDrrkW0ePTHr/xppkjVcdb8J6oXrut22PlWGvH9hg//n0oLDMiR6H2qNe8nyXrrOZLQWWk8OC0CN+koj3CS0wCox/DACsxYBPIOyO4SYFN45QMHIASPy9o46ynzISosljwFHLGi8TTS6ZzCphElgic+aV7rMe+HWU5EeoAhKYrxuBBlwpEfOuzaDlr3atqzQEPKf7C3XBeJDNqkESpsHbXjmSY8ccp1Khac9mwM4QxJ5PMKYvRuExwa0mZVP6C6r28k+tKe1oBueGivJHpXDb0/1KElGF1QOumDv2hRZYQ1LDzHNSYulOAOFwhpt9r0N8qi+/YIyR2Ni2FcYcn+fVeYn6lQvY2bRiYdYuauWaSsk9Qelr3P+gPi1Q80ySgUi9uOuPaCMN725/O+Fx+A/Swct/igciicCB2rTc9lsL6nNysWADFTQlGZjrhRHh1eZkZPx2S9ZliVj3ZwP1fVDXV3/6n8FAd5PvSH4rPKO16xYSyNy3G8x50qsh5QHz/UYtBxSYxpmjQ1kHor1irQW4lI+j1T0kvr5EBO8w/HWg7flFW7lVeQ=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SL2PR06MB3082.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(7406005)(66476007)(66556008)(6512007)(6506007)(6666004)(110136005)(8936002)(66946007)(508600001)(52116002)(6486002)(8676002)(316002)(86362001)(4326008)(36756003)(921005)(83380400001)(107886003)(26005)(5660300002)(7416002)(38350700002)(186003)(2616005)(2906002)(38100700002);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?Q3S7zj+RBCohZ7GKUMLGIIoYe0d8605t5V57WjF7+5w8/WSiyKZSLbPBIHus?=
 =?us-ascii?Q?aRVX1K74LqbDqCEJrGGcVmakino4+ECanyPXwF5eQrINE4uehvMyV+FJbG6I?=
 =?us-ascii?Q?yUdIkz9QOd1PrU2bUKf8KGiJF9pVB5s+IZxriRzyfkeDufC4StTtp8IQres6?=
 =?us-ascii?Q?savaBhbOKzdhK64Lbv6TP7g+r/SSThIDN11w3cOgx+O9v/RaPHOCUuQsrvjy?=
 =?us-ascii?Q?aiJgxJvi51Ex0BwIuVRfkVjPMfpg+HbsH30T0qzcgIjmZziBETOhr59mciqL?=
 =?us-ascii?Q?dtjugoPVj2luJSrbSN4uThUdLJtxVTpovm+6NHaU7PeDG2bbtnjUtqcl0Nna?=
 =?us-ascii?Q?PytWGUz4kZQ2gv3tddmoKACWnRqEXyYqznENhIyeDPASw6pRUXt/fyayZ//l?=
 =?us-ascii?Q?yRLC1b/5Py74FMgy8uZErYunte7FqsJmF+Lh7FAVbm8GnU4JtJ1hgyvkOnMr?=
 =?us-ascii?Q?hyU32Fk+hxocwrQ3aH/arLboiITlGeeYtWDKCvHeqFgXFyDKFCkRhd4jb6j2?=
 =?us-ascii?Q?4Oy+ZljnPAcEHMoTvRaw9HTOff77umac9Rq4XjnuzBta9lbMuCRbP+42WPR6?=
 =?us-ascii?Q?1ivCrJsDk/QYfVOOjDyEVFeJYpZJkdD9Lcrusc87UDcutoSxolL9HuaClr6I?=
 =?us-ascii?Q?1sMQIPhzHsyz2p5KjAbWUj+FDNLvmzXU9W8aamD0rKzGwG/T/tcxCSM2lXiK?=
 =?us-ascii?Q?bs/F+0AoTlkrqw7U2phqGfzet5eU4qiNWsglBOhFFCOjos5gGT1O8yW4ru3w?=
 =?us-ascii?Q?dpxhLx0bbp0dfDnKM+373j7xdU2tGbrJi9FMwp+B8EAFPmG6jW3KY23OR9+J?=
 =?us-ascii?Q?7t0YPkVhmPeeBbsFZGyOLPSJfF4Gk4WrGk4xdHWlmfEC/EIklvkNT4vXAto3?=
 =?us-ascii?Q?YFJw8LZgMEz4m7gNTmuyMp0lUySKog99xDUJ73dYKbSmJjKebtQpwQBatG3e?=
 =?us-ascii?Q?vIpMs63Y2qcVLmwBIVFTZP6BGlyl24YskItviO7/0eFd5G28cQRrK3SDHy27?=
 =?us-ascii?Q?TmNxBbiDr+pNQYimRo6mWH3HqnCqXWeYJCeRICNnCJ3WVEXFd/cxlNpjEqvb?=
 =?us-ascii?Q?K2IWhdjNb+hEYw/rvV7uXQAbBGUuR0aUnz9Rz621K4dWtqHRWENKKaL9U8fB?=
 =?us-ascii?Q?esX9T+oJVWZXA26j1ZhMt8JHt8XMhuriGIfWpX2WLM/vYAaqX8n3BXWQ+Z6m?=
 =?us-ascii?Q?hCnpG0JWpSWvo9byfGlut8MSJMORQ3aICn8OxC7+5Db8JmgLfz1T2WqQsUHh?=
 =?us-ascii?Q?KwstSFOeKrm+pWD4GSTHz8JOcy+l1dIbSEb0PcAylN+Uwsv7spBOhhFTMM+3?=
 =?us-ascii?Q?JNSKlIIRhMpt9npGDIFB2VZh5tELPLIsVW8mC5Aigy4R9LOm/sjlKbzccvEz?=
 =?us-ascii?Q?yVfK8Vcg6a/wF8pv2Dy93pz5yQvBM91dcCmmqbRzYshkR4pMtPRZ0z5ZFi1f?=
 =?us-ascii?Q?KGkSO1H6HIRLjTUv+CTF5E2BG25NI8JYMmt9CniFVJfpfHRZDz2ldFjaVYU/?=
 =?us-ascii?Q?cYAeYnA6UwsRVF/R9ZxLrFRsOEzWRKh2o/qd2SZrQbCYsZ3brOeWJmDW8F/2?=
 =?us-ascii?Q?eq6o2YgMFyXc6+4HJIP7xe7nUNXbWuQdJncP0C+TOyIXp8XUf9n+ME84NM8v?=
 =?us-ascii?Q?dHH30FU76winpYAxatJhhH8=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bb48ae59-c9b7-4af7-8709-08d9f0265c03
X-MS-Exchange-CrossTenant-AuthSource: SL2PR06MB3082.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 01:56:19.5294
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IM6S87sQg7cP78QKhQf2JR+tZXuodYcczaGXperdxW2+QNWMAMXRGKpMD+CVex5j8J/w7BJXOtbIkzGfqsHx8w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PS1PR06MB2742

From: Wang Qing <wangqing@vivo.com>

Use the helper function time_is_{before,after}_jiffies() to improve
code readability.

Signed-off-by: Wang Qing <wangqing@vivo.com>
---
 drivers/block/xen-blkback/blkback.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/block/xen-blkback/blkback.c b/drivers/block/xen-blkback/blkback.c
index d1e2646..aecc1f4
--- a/drivers/block/xen-blkback/blkback.c
+++ b/drivers/block/xen-blkback/blkback.c
@@ -42,6 +42,7 @@
 #include <linux/delay.h>
 #include <linux/freezer.h>
 #include <linux/bitmap.h>
+#include <linux/jiffies.h>
 
 #include <xen/events.h>
 #include <xen/page.h>
@@ -134,8 +135,8 @@ module_param(log_stats, int, 0644);
 
 static inline bool persistent_gnt_timeout(struct persistent_gnt *persistent_gnt)
 {
-	return pgrant_timeout && (jiffies - persistent_gnt->last_used >=
-			HZ * pgrant_timeout);
+	return pgrant_timeout && time_is_before_eq_jiffies(
+			persistent_gnt->last_used + HZ * pgrant_timeout);
 }
 
 #define vaddr(page) ((unsigned long)pfn_to_kaddr(page_to_pfn(page)))
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Tue Feb 15 01:56:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 01:56:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272668.467589 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJn4x-0006qa-UM; Tue, 15 Feb 2022 01:56:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272668.467589; Tue, 15 Feb 2022 01:56:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJn4x-0006qP-PC; Tue, 15 Feb 2022 01:56:31 +0000
Received: by outflank-mailman (input) for mailman id 272668;
 Tue, 15 Feb 2022 01:56:30 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=A2Di=S6=vivo.com=wangqing@srs-se1.protection.inumbo.net>)
 id 1nJn4w-0006If-1s
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 01:56:30 +0000
Received: from APC01-PSA-obe.outbound.protection.outlook.com
 (mail-psaapc01on2071f.outbound.protection.outlook.com
 [2a01:111:f400:feae::71f])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7c5c6840-8e02-11ec-b215-9bbe72dcb22c;
 Tue, 15 Feb 2022 02:56:28 +0100 (CET)
Received: from SL2PR06MB3082.apcprd06.prod.outlook.com (2603:1096:100:37::17)
 by TY2PR06MB2767.apcprd06.prod.outlook.com (2603:1096:404:3b::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Tue, 15 Feb
 2022 01:56:24 +0000
Received: from SL2PR06MB3082.apcprd06.prod.outlook.com
 ([fe80::80b4:e787:47a9:41bb]) by SL2PR06MB3082.apcprd06.prod.outlook.com
 ([fe80::80b4:e787:47a9:41bb%4]) with mapi id 15.20.4975.019; Tue, 15 Feb 2022
 01:56:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7c5c6840-8e02-11ec-b215-9bbe72dcb22c
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=a9zNVsqDZpeU5VqBbaE+1mGkTeZOJcRIIyunzWYApUBozzIJ9dc+nAgY2VcWP6OuJuQNbIMo3T5M8r4+cosZe1qlzVvCTpjw5tTuMUFYxnp1DX/pwqFuupR1cya9v73JMWOR9YBM/QDPhJC7hbuz08V3e56dVCiyAz2oc+3BPxo1wFuGRJEAjisMFMkwFDfCfZ7/ik1K3bJpddhp/GyCi1Vt4pFMbcKONsz7p0vz9EARIz1cRZ/KrPBks/dh+6USZa9Uptrvn6h/WvWbBgCmVqwjVdWCxRMFi5zEMoVac/b7TjxwZARZqawMdFixtduYFeZkxpliJ3iXh2eALujZrg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=plqEMFlTcQNTzi1qhffG46kETCuLRyfOsTN8Bkig3pc=;
 b=Z7UjIN31QjRJqbM9D1ke38hm4/MYMEpCoeoeOS9n0CW/iYHamGBUE6Lko+VoRwu7NIvRA9NlWPBN4IqHh5g2o3Cs9APCbk/kTnUC3Po0fHLCSpXPlF0vp52PwQ6XXDzaRovUM2Cy6H87eT03+Kqaf8DctL3f7N4yqFhnrac9QUCJAvIE231FUURMVLY29rLC6sHBR8lFXnjwr2zEWcrNu9x7saI4YrKoOegeVpEviFr0cXOh5JGN2P0VeRS8b0JQ4hzryBHx8EebO9ZOQyxBhXfy0eUWaNHI8FAovcom0YJ3F7A20IOEu2ix+whWlGoppyQdshS7schazfDvJHxp6w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo0.onmicrosoft.com;
 s=selector2-vivo0-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=plqEMFlTcQNTzi1qhffG46kETCuLRyfOsTN8Bkig3pc=;
 b=gOwFV/bnab2QOaRAgDx1p01oFAOsL82Umui1UxURpbpbswG2GHT7WQnq7YjF2IiNZyfY1fb34Ac9skSZ/vIDRETzRn74gIpVlOhR72lNLQ4Czi9BBTqnL4Puz8gDXZG4Ey8rse2OWWsL5d6gcbsY4Siy12hEhGeSUXMSpqxMAZI=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=vivo.com;
From: Qing Wang <wangqing@vivo.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Jens Axboe <axboe@kernel.dk>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel@ffwll.ch>,
	Alex Deucher <alexander.deucher@amd.com>,
	=?UTF-8?q?Christian=20K=C3=B6nig?= <christian.koenig@amd.com>,
	"Pan, Xinhui" <Xinhui.Pan@amd.com>,
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Alasdair Kergon <agk@redhat.com>,
	Mike Snitzer <snitzer@redhat.com>,
	dm-devel@redhat.com,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Hans Verkuil <hverkuil@xs4all.nl>,
	xen-devel@lists.xenproject.org,
	linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-clk@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-input@vger.kernel.org,
	linux-media@vger.kernel.org
Cc: Wang Qing <wangqing@vivo.com>
Subject: [PATCH V3 2/13] clk: mvebu: use time_is_before_eq_jiffies() instead of open coding it
Date: Mon, 14 Feb 2022 17:55:39 -0800
Message-Id: <1644890154-64915-3-git-send-email-wangqing@vivo.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1644890154-64915-1-git-send-email-wangqing@vivo.com>
References: <1644890154-64915-1-git-send-email-wangqing@vivo.com>
Content-Type: text/plain
X-ClientProxiedBy: HK2PR06CA0012.apcprd06.prod.outlook.com
 (2603:1096:202:2e::24) To SL2PR06MB3082.apcprd06.prod.outlook.com
 (2603:1096:100:37::17)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a592c175-08d4-4018-d460-08d9f0265ea3
X-MS-TrafficTypeDiagnostic: TY2PR06MB2767:EE_
X-Microsoft-Antispam-PRVS:
	<TY2PR06MB2767351B13A2B13D4B513FE3BD349@TY2PR06MB2767.apcprd06.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6790;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	zX2WoqF7MNdOKgvoqDvJhcCDh4FqMCBpHKSG0rNS5d0U+wfBxtQaDuQvl2Hiu1iAu8sUtj8UvfwKNAoaVBhkUUPMnrPHGdx8PIsfUNqxJkdGO2IYtGZ3L9XZR3h+FYFlcEtpceVk+KByzXWpiJEelUxepRgviV9UwUT/4vru1LDbp0ILVrDonHfeNbxbVAhM8fbVAC2dUK8uA7YBRTTwT59hS13MUTqvpLY2pW3POiM1hhiBYw02MCO3skFt18GK3vmcCCnskhLws6ioMXilv5GBRXiKF9UPI5XdDIBCaT97lAH5gWduNHdfSfyv/GjybSM/qWGyZ2UbMxeWa99WZtZtIKcMudJcOQr6CXdrwS1hWyANXWFLp0/qMVsoTLFGLrCrAsQ6MhLMd75+FvkTvparPFv15z3TiPWQxIXK/xrUdOtUkjlUhHLdfrFhCrVtUKDeUzTEjJII8xoKcwM7qehlR9ET+kpyMcJqR8IxsizFZaYJgxYcclNcJBJIxeLnmG7g5Ax0p36SIfhDft9AIiXlLSRJzES8LSdltQfuYBE5vvIojX99YZCoyiGJpy7Ns1xd6O22/7N8R4n6dS3Ny+LYr3hSUt/DPh9XiapEDBdUhCx0jkinrkQAKEO2vWCHgU2txvTdZ2KkoUQl5eQzIlXQMiuNZ+4kL7K0iyRBYEJ/yYL+08Te02m/HJSTM+0JJUBuI10lhiJCpSwMIfCvoMmjL0Etsf9zIQ+E5TPGeaU=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SL2PR06MB3082.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38100700002)(38350700002)(7406005)(7416002)(110136005)(107886003)(921005)(316002)(26005)(186003)(2906002)(52116002)(5660300002)(8936002)(6506007)(2616005)(6512007)(6666004)(4326008)(508600001)(86362001)(83380400001)(36756003)(66476007)(66556008)(66946007)(6486002)(8676002);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?Wpw5/l7FKXOSWvAniOTgrmDA7O0YmEK3cu9ebJT2n7gDSmUwwYsI9grkdQj+?=
 =?us-ascii?Q?vtwlJvrlPqOtYPeYGTA+EiC+m+Y4RSpIEMp6AyL0pRiH4c2RYUCUXVN73oQ7?=
 =?us-ascii?Q?BDWpKO/0+k4xYHfQ8GIXoylYLO++eVRpGrr1RE2bomQMplb1O4zPF8gfqNx/?=
 =?us-ascii?Q?qIwQ9XwA/rRmzmCplmTLnn14JqeC+rb8yS92pYyIcMV7LBmHYoRYV3Iz3E4i?=
 =?us-ascii?Q?M56X6HOyPvTj0EpQXlPrEc+vwpMWEzDyfBRvPaTuauaPzrY5xsi/ngsidFd8?=
 =?us-ascii?Q?i43p+utDVYBqBjpcGRJ5meXl4f3gh5lghVJdN0ma1ZdOx1nLI1fPrU4+81S9?=
 =?us-ascii?Q?QVVhEmquiYxU1pmm172XWG6WkSs02rcFzvD+7/63vC5CQnk0o4osGxdQwHpb?=
 =?us-ascii?Q?uU0HZ/uRFcI2BWjeFONl9/6DBpRupYo/XCJWFRraAh/+PvVvBIecIbfnA57L?=
 =?us-ascii?Q?Z7X57AkkIl/sFasRRHDkV6+QeWNXLFGqx5fHWUgQqu3NzccKJiSbPfnhk/cs?=
 =?us-ascii?Q?dYDCKT4IC59H9UylRXsaBmS8NPeboXKbcPzKevy4gONKgSy8Wp2+mqp2jwAh?=
 =?us-ascii?Q?pRFHdrGOqLdJxYHyk6C07BJiF/8QWU5TU0+5CV291WlEe6lwPaQm86FMl//s?=
 =?us-ascii?Q?FRKnocqxAyr3xh5d+bOp4yYMSmbEC0RYppm2hANCkLXhmuwB5Rgz3CHOSN+Z?=
 =?us-ascii?Q?I1NXRPXtb+UOspRKqZLAZcDbeXW1Br7nfk0z+KzFKYaLgLeDOW4bHY60D0j4?=
 =?us-ascii?Q?IuERPVqvGXWQy5rSYbU6p4QALOu2uHMpLNF/9u/syhN3cYZVM+nlmfU1zn89?=
 =?us-ascii?Q?XR9I60V1a1aUWhwIFPkRglJxrcWLsnEOC39bZlJXEVkQxhDzVeeDOUns01V7?=
 =?us-ascii?Q?zI64pmtancpCjbT7L952oHi7i4JXQx0hrWmH+XyWos3JhVNIyzVuUjBVJcy/?=
 =?us-ascii?Q?rakcshLNC1FdvSl5VU2/ZsM5V1GuLY7I7J0UCvYb2pz02m27vlba7eJD2xCm?=
 =?us-ascii?Q?M5vjCe7a0eLkRYfS7n2nP42BB9kWUkSWxTpN1zCBLL2aWBFliraNvEK9fm94?=
 =?us-ascii?Q?NPbMW4veEOKufI9SR/tU8VB/xAV8NBOIGw9gkLMci83S4kgayd5zRGxfJt4N?=
 =?us-ascii?Q?e8WlpLoE2ggE7Tr/dY2Y6waUUavn9GfpuyX1yYu3FuNjot1lmewLCQ+uuBBB?=
 =?us-ascii?Q?bBHVBag0ugRmL+XtIF/DVfuylRwz9zB/9kqJd7/fkp60VPvZhjd85Sof+i5Z?=
 =?us-ascii?Q?aDTOOXU8q47n0KZALH5ywnl3DHe4Serv7jV6yROXugz4il7Q8doUMfSpZbRl?=
 =?us-ascii?Q?C2HHjm3nRe5fLB26e/cN46qJFC/LZvFC7qWE0l4yPbdoY4D6xzY5NP6E24BC?=
 =?us-ascii?Q?YEnXUSsOv3hnOAe9iWTkfoUhNCp5dDbcfLjw5lyOR5zZwRN3kh0lIkbUznE2?=
 =?us-ascii?Q?UxaoNmMhJIy7EhMQ0gsSM2ovIdhr5v1bJSAW8C0JigSUtY7nd4PV5+0NcdBS?=
 =?us-ascii?Q?qEFfUtS59ee6kAkDO1QKbSLBidp5a5WtH3dCc1HGuY0AeqiuDjsWK2Q/Lf59?=
 =?us-ascii?Q?aOPLIl07l/mAqmbPG5Ei8xxLZ9svR1ldKDWn2wraTtw4kMDh04jkKI4u+ao7?=
 =?us-ascii?Q?B0f2RuwH/p/cqJ4BlqIDWHU=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a592c175-08d4-4018-d460-08d9f0265ea3
X-MS-Exchange-CrossTenant-AuthSource: SL2PR06MB3082.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 01:56:23.9354
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Edh6wThjQcu9bBPcnAQQNuMw2s0Y/99k5LlcNHPrjrGpOlLqbeF1aegTWK9AI/RhKFCCkax1Oz7ajkvWdmyf1w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY2PR06MB2767

From: Wang Qing <wangqing@vivo.com>

Use the helper function time_is_{before,after}_jiffies() to improve
code readability.

Signed-off-by: Wang Qing <wangqing@vivo.com>
---
 drivers/clk/mvebu/armada-37xx-periph.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/clk/mvebu/armada-37xx-periph.c b/drivers/clk/mvebu/armada-37xx-periph.c
index 32ac6b6..14d73f8
--- a/drivers/clk/mvebu/armada-37xx-periph.c
+++ b/drivers/clk/mvebu/armada-37xx-periph.c
@@ -25,6 +25,7 @@
 #include <linux/platform_device.h>
 #include <linux/regmap.h>
 #include <linux/slab.h>
+#include <linux/jiffies.h>
 
 #define TBG_SEL		0x0
 #define DIV_SEL0	0x4
@@ -541,7 +542,7 @@ static void clk_pm_cpu_set_rate_wa(struct clk_pm_cpu *pm_cpu,
 	 * We are going to L0 with rate >= 1GHz. Check whether we have been at
 	 * L1 for long enough time. If not, go to L1 for 20ms.
 	 */
-	if (pm_cpu->l1_expiration && jiffies >= pm_cpu->l1_expiration)
+	if (pm_cpu->l1_expiration && time_is_before_eq_jiffies(pm_cpu->l1_expiration))
 		goto invalidate_l1_exp;
 
 	regmap_update_bits(base, ARMADA_37XX_NB_CPU_LOAD,
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Tue Feb 15 01:56:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 01:56:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272675.467622 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJn5D-0008Af-TK; Tue, 15 Feb 2022 01:56:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272675.467622; Tue, 15 Feb 2022 01:56:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJn5D-0008AV-PQ; Tue, 15 Feb 2022 01:56:47 +0000
Received: by outflank-mailman (input) for mailman id 272675;
 Tue, 15 Feb 2022 01:56:46 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=A2Di=S6=vivo.com=wangqing@srs-se1.protection.inumbo.net>)
 id 1nJn5C-0007s9-4z
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 01:56:46 +0000
Received: from APC01-HK2-obe.outbound.protection.outlook.com
 (mail-hk2apc01on070e.outbound.protection.outlook.com
 [2a01:111:f400:febc::70e])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 856f7c61-8e02-11ec-8eb8-a37418f5ba1a;
 Tue, 15 Feb 2022 02:56:44 +0100 (CET)
Received: from SL2PR06MB3082.apcprd06.prod.outlook.com (2603:1096:100:37::17)
 by PS1PR0601MB1866.apcprd06.prod.outlook.com (2603:1096:803:6::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.15; Tue, 15 Feb
 2022 01:56:37 +0000
Received: from SL2PR06MB3082.apcprd06.prod.outlook.com
 ([fe80::80b4:e787:47a9:41bb]) by SL2PR06MB3082.apcprd06.prod.outlook.com
 ([fe80::80b4:e787:47a9:41bb%4]) with mapi id 15.20.4975.019; Tue, 15 Feb 2022
 01:56:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 856f7c61-8e02-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=e6UQWV4bqEDJDGfdCFd6Pkg7SdRTh6+CSZJpFaA7F4MRkZi7s8vXECdwYSpLY0Q8sHcLhE98L3nSKrkcTW2sHh0T0cM9BJLECcsSaYeBxuXVZthTml4peUxptH3hnStvK0c62nO4R+w6ur8cvNT1pqRlqne2gHo9PBPq1ZojJaDhwxf4Lr3eHx8Vtw89h8VDDFMyFc0rBZQkrmJZKjmYEXCGS++fuvUyL5HIWUcYKD7TNmXuMMUphXNUKAZ0aZRcjpdBMGofxNX3Zl5hV88pYaWKRlhZrYZNnZW0XCuNawPYAyhm8dB38dJx9BBJWCL4o6qUC1WEacZnA5x3I+bR8g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=yrGpKWbmRp/53st+CREaW7lUNhmT8V/Jkoa0ucLI3So=;
 b=A9ZNuTRG6C9jWDrPfbPeHSv+G2PAf1WG+1xfeiIBJfYVGLTFJEsQBxVKQVFbVZaq8S8riNedShGZqhXQ4rVweXJOEgEhWoAxaD6VZP8ujchjC46fooRSwbXesKUjAhM3j7y9Y6sN9uJ5dF03QUvCGHYY0m546Mmn3SGbXX2ZRNj9E1pdGWhH6usstRJdqPxrGpP2a8N2tGebRihfVPK4zUZbso0iFbgApzDyhdg6JsHLruUdA/SQ+w5EKzJPwxeLdaxDKKPAENlOt0YKHmXojkvyrRQYB9pDM4mv9T6DaOh4JM00HJCQBWGeeyoG+tPDF3MJu469ZgVRuuJGXBFhDQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo0.onmicrosoft.com;
 s=selector2-vivo0-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=yrGpKWbmRp/53st+CREaW7lUNhmT8V/Jkoa0ucLI3So=;
 b=RsEPiHO8X6r80bTwPLzwXmsIYsMUKr/BMrD5n1U5+KWQIxEKEm0skCqdtifp9wL6Y0WvIsWI7G19VuSaS5rUQQYWrNHX0/ml4ZFjN0vwKlscJk4VyH7rqMlk2lrjFZqIL5/Vd52BNVXYbdOkqttynGb+VzoZieJGLttFlIKU+Nc=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=vivo.com;
From: Qing Wang <wangqing@vivo.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Jens Axboe <axboe@kernel.dk>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel@ffwll.ch>,
	Alex Deucher <alexander.deucher@amd.com>,
	=?UTF-8?q?Christian=20K=C3=B6nig?= <christian.koenig@amd.com>,
	"Pan, Xinhui" <Xinhui.Pan@amd.com>,
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Alasdair Kergon <agk@redhat.com>,
	Mike Snitzer <snitzer@redhat.com>,
	dm-devel@redhat.com,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Hans Verkuil <hverkuil@xs4all.nl>,
	xen-devel@lists.xenproject.org,
	linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-clk@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-input@vger.kernel.org,
	linux-media@vger.kernel.org
Cc: Wang Qing <wangqing@vivo.com>
Subject: [PATCH V3 5/13] hid: use time_is_after_jiffies() instead of open coding it
Date: Mon, 14 Feb 2022 17:55:42 -0800
Message-Id: <1644890154-64915-6-git-send-email-wangqing@vivo.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1644890154-64915-1-git-send-email-wangqing@vivo.com>
References: <1644890154-64915-1-git-send-email-wangqing@vivo.com>
Content-Type: text/plain
X-ClientProxiedBy: HK2PR06CA0012.apcprd06.prod.outlook.com
 (2603:1096:202:2e::24) To SL2PR06MB3082.apcprd06.prod.outlook.com
 (2603:1096:100:37::17)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: eadfbac3-950b-4e51-be2f-08d9f0266665
X-MS-TrafficTypeDiagnostic: PS1PR0601MB1866:EE_
X-Microsoft-Antispam-PRVS:
	<PS1PR0601MB18668268A528DD80828EFBA2BD349@PS1PR0601MB1866.apcprd06.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1051;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	sIoEfQemArsyulB5SoveymUgtCUx2xxzYy8UevUrqedCT7AVUtfGLKgvtMBl0B/j0EFZtGoiarNcH0PsWYj2P+d8+4QAJNKvHrhdlYWVdbc4ixPwQ1jgMreZmSC46pFJccm8h+uCIABXQnQjBDyEod3T9odut8IXpDteejFmeIShKCNcxGrOBoiUa2lyIk7HdzLaQFOoryvMWaKvIzf9sgCVpk/wduHsDQztJD/vhbPWtmuw1UAkiO+6V4gmhZhrjcizlPcNipi/GK4cmFP126zxjn+M3c3Td+PVzFZxS3uec3CDqfVXn4k10jQKHIqrFpnVit1cY6ilZYbqopl9t2P0lz8q4iNK1cPdle6dEHVWChAkoukdmkqW7VnBBXlMe5fT2CCyUQGbMCyXMOtquTaVZfXthJFjT69L5ImDDcsqx6xx1lJ/t8H+HRsDojEe1rsmL0iTwWmMqW83OWJUQuV4DP5tEgAg6J7XFG89MDCuTXKw1sw6EPJ0cTNrxaRjJuPQ+cbh9J5drX4jIP6kDFycWDx3Zwq7XDlA6bNoph+ddqV5CPk0RLIvPfFpRDDiTtVOqnV0mai7+5iyBHerM+utD9M02oxH3OccGhwNLYXoNELDpNuWLwse00MdUTJtpQR71T3cE5Gk2zvu8oQ7U18+4zXsAw6tj4XZzm5mvtOe/R2xGYBtEDsvZXHItmfxXZclirnMiuGLBAXQsW1mh7tJ5Ye0VfTD0GZ3MTqn8C0=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SL2PR06MB3082.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(36756003)(2906002)(921005)(38350700002)(38100700002)(8936002)(7416002)(7406005)(4744005)(5660300002)(52116002)(6506007)(6666004)(86362001)(66476007)(66556008)(66946007)(8676002)(4326008)(6512007)(107886003)(26005)(110136005)(316002)(186003)(6486002)(2616005)(83380400001)(508600001);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?nuOoN1v5NxJXTwYzMrN0x3sqYLMRiw/LDRy6bOyD0Xsr4hYf8pMsWd+inzLm?=
 =?us-ascii?Q?tvk7emt5UWTwEK1BYfBu657jBKYwT3hnG7o24Rw5CGrlDae2canOwzEsfMs2?=
 =?us-ascii?Q?OLn1tVQR9ETMgGZINxuV+11W7xj5S+Uj4PDDvtQgeXePr+wuXBK7RgzFIdSr?=
 =?us-ascii?Q?JFdgolr7HdX9GSam0zA5nqM13feALzh2IOdiOgULRVFcGsVphYLKfFcu57L4?=
 =?us-ascii?Q?T3PuTvvZe8BXGBozZVPEf6j9Fyz2O0FteBASssgec2qwRmD2EuHxjFPCdcsr?=
 =?us-ascii?Q?zFQTAjFJLvX74qJPfOr0yq0x8ili8Yxt2vDqr+g2LTDQDoK6ClrVm63xxmrK?=
 =?us-ascii?Q?6GpP0PWLfZ+1+CVgGn9eIlRrbxWpOMsY0Bcd/Q8k0phlll+OG8ExcSrUSoAt?=
 =?us-ascii?Q?v4XAK95RND+V+n8sAM61bXuWa1MBIoiB8MPPN6v1NceIYCOqmVhXki8V4han?=
 =?us-ascii?Q?k0w+5PfiCR+q0gbTtzYl46sHlmjyOR2TCNwiExb/YgufOuq4vPnsSop8oJIC?=
 =?us-ascii?Q?0LgZ1RPqqKEDPqEyuQ45zCZB7eYAm+XuR2NxCjCx/rMfR0UkFaIbUXo7mRXn?=
 =?us-ascii?Q?PTtiGmQ9ANpqv2aGpCx3TXQGxNG5uvgYCPJ9Lr7LgFW8tyBqA3VZNjOICK8O?=
 =?us-ascii?Q?6oWfxJlp+E9vMdpPmQk768BLNoaeHP98r40/+U7H0YJu1/0abQrPzgFQuZaO?=
 =?us-ascii?Q?loc4gPoOS6h23+tRLoCmGwtnj6ucRCKeFdIdc+i+KPpzGNCALStkRFiOC8wO?=
 =?us-ascii?Q?klQ7z4/VCNeNGO0zdlywx6Ebq7IUVCCpCP248MxBk2rIuVf05MrM8BCyN1Ze?=
 =?us-ascii?Q?AoL7g+Ts5PFs5TehO/5I92XP+DYEwBMu1ZYsBpOLpa0HxVv69kZld9gyICcc?=
 =?us-ascii?Q?7oLAfv7YdTSIl/gr6u+VBEpqBNNX6q/p5p0U/+KvC3U4/QgCR5/uuRBQ66nJ?=
 =?us-ascii?Q?XMz1PNmarEmtqkkGw22G5OwNeP8v7361cY82qfQDQn5F+ZqQ3u8skqg9+16P?=
 =?us-ascii?Q?Q8Zo1aVdKUkEyySe51etV+ROMLe3bbNx3VWvfMdDoXpsmTHgvHX3/wuAOPdm?=
 =?us-ascii?Q?g/6q6CbmkfT7EP85+nqYZsCiMJMBOKztJByzJWBZy5iI9Sh2q0tDEhoow9bj?=
 =?us-ascii?Q?PplkxGUyMZMyXCRGpMWexmIo2Nom4pUSe8NcMEK9naPbj7KtM20i6J6Hlz9N?=
 =?us-ascii?Q?z0ZxR5E0HD05Es2SL4oO3+Y5au8zBAATmfsAqIB5hCumnRWlDri53SeakIjf?=
 =?us-ascii?Q?qThLforE339HXCtiXDuiLtQZBuoQjG8KEJjZgMchct6s0jchxTiVWKFm6D9U?=
 =?us-ascii?Q?jdXgFQPmUr8bZ47cdbxrvqmLjpo7etnZf23c0PWmOUuEp+8sOy7/L+oI5Uoo?=
 =?us-ascii?Q?VgqcBpkT7PSKX/XNXHknyb/dSnQCiSmcHeKm21MbplM8ivg0IRYGxcECiPUg?=
 =?us-ascii?Q?Y1GzzRYkWWjbaw6XinqqZpbvNMtYIoqTs63d6yTq6RTzRODnYlkvTUs/MA4y?=
 =?us-ascii?Q?eUM2fyH9I3kE+2JWxMmL3xVZ9z4JbJwIMThYHxS+NbOcpW8wBMfam7y1Ze16?=
 =?us-ascii?Q?Gi4aDemijDKIF1eyGtYcCIDe3WPSESgmdpxzQ2vuAMmhcG5srwt+MMqnI9Dc?=
 =?us-ascii?Q?+n0kvf3Zho0xCPx5La9Ka1s=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: eadfbac3-950b-4e51-be2f-08d9f0266665
X-MS-Exchange-CrossTenant-AuthSource: SL2PR06MB3082.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 01:56:36.8565
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iBSGzwX/ZNVxWcftvmwAeS99h7MtCcwLH0F2V0ZE6zOpA7y9IDcAuvx1RaxR1CS0yG68ht/dIJrg6qqRZNiB4g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PS1PR0601MB1866

From: Wang Qing <wangqing@vivo.com>

Use the helper function time_is_{before,after}_jiffies() to improve
code readability.

Signed-off-by: Wang Qing <wangqing@vivo.com>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
---
 drivers/hid/intel-ish-hid/ipc/ipc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hid/intel-ish-hid/ipc/ipc.c b/drivers/hid/intel-ish-hid/ipc/ipc.c
index 8ccb246..15e1423
--- a/drivers/hid/intel-ish-hid/ipc/ipc.c
+++ b/drivers/hid/intel-ish-hid/ipc/ipc.c
@@ -578,7 +578,7 @@ static void _ish_sync_fw_clock(struct ishtp_device *dev)
 	static unsigned long	prev_sync;
 	uint64_t	usec;
 
-	if (prev_sync && jiffies - prev_sync < 20 * HZ)
+	if (prev_sync && time_is_after_jiffies(prev_sync + 20 * HZ))
 		return;
 
 	prev_sync = jiffies;
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Tue Feb 15 01:57:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 01:57:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272694.467633 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJn5S-0000ho-7R; Tue, 15 Feb 2022 01:57:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272694.467633; Tue, 15 Feb 2022 01:57:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJn5S-0000hc-3i; Tue, 15 Feb 2022 01:57:02 +0000
Received: by outflank-mailman (input) for mailman id 272694;
 Tue, 15 Feb 2022 01:57:00 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=A2Di=S6=vivo.com=wangqing@srs-se1.protection.inumbo.net>)
 id 1nJn5Q-0006If-6y
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 01:57:00 +0000
Received: from APC01-SG2-obe.outbound.protection.outlook.com
 (mail-sgaapc01on2071e.outbound.protection.outlook.com
 [2a01:111:f400:feab::71e])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8e7db020-8e02-11ec-b215-9bbe72dcb22c;
 Tue, 15 Feb 2022 02:56:59 +0100 (CET)
Received: from SL2PR06MB3082.apcprd06.prod.outlook.com (2603:1096:100:37::17)
 by HK0PR06MB2771.apcprd06.prod.outlook.com (2603:1096:203:58::9) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Tue, 15 Feb
 2022 01:56:46 +0000
Received: from SL2PR06MB3082.apcprd06.prod.outlook.com
 ([fe80::80b4:e787:47a9:41bb]) by SL2PR06MB3082.apcprd06.prod.outlook.com
 ([fe80::80b4:e787:47a9:41bb%4]) with mapi id 15.20.4975.019; Tue, 15 Feb 2022
 01:56:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8e7db020-8e02-11ec-b215-9bbe72dcb22c
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=knZyCcYAGtawopZ82sMpDMmMuw8/GbquUhS1Hq+t915/MYnbkOHTAsr12hRpPHPzaFHsZQNn2IJx75mgZKSpGfPcYKJ7PzUdx07cRPbENYrSWr2F7k3+KeR8ucEft9LbTMzsdG2m19LKc+EUkK/2sO8J4LHwoqU7/m2pUP86B4TUTnq3nT5hnU7yN05MNJ4/ZqroFhwZ14n0oxtRLq71m+7WiI9YRxFmp5V2+esxZmrYxCdHGyqMm7s2lbHpu/IJ8orQZdJu8X4CAminScgWObbAD4EmWbHGlRLsV0/N03DExGjRHF031zgwXXUCZnnG16FLxGqUDnyOxao7Md84kg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ZBp6QqgcxBqUyzlzcSCesk/OaHoOl/yHBure7Y2N9iU=;
 b=lw6oTQEaTxMaX/n24R19QNnFReSWLzNilpJdYOldEDpFjJOcoQb7LVjI2LzkjfaeJtCcYydfZHuDQHT34dGBvnKG6iQU5wU0wKvhly3Nv6fTRjts6RwyHHWDVFK3CVCwvEGHuATI6QfLlevR3e+J7R0N13dyUxkUHBZQwpghMLq19/YGfniIBmrtjN6+FhdZQpKL/LxzB4R8YjXecnwXnmBul1sYEVjMbRgJsm1QKgmMlDf/co/wyHh+uRXt39ua2BfN+7rvuiGkjw8TD9S2WnqFaBgxZDrl/mz7KZDS810Rmtx76Ew3CS9AHlwGrQfwSKWeHNX85wFtH4VUmYH4tg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo0.onmicrosoft.com;
 s=selector2-vivo0-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ZBp6QqgcxBqUyzlzcSCesk/OaHoOl/yHBure7Y2N9iU=;
 b=SaQynrlL3YPQnz22upp514fER/TyXj7Bho8VRGxYrvkwbrHKoZQpeq4Vng77oeI3yMpY8KYHMinDxLEDVx4fcj5HEf8LhmlNu2K5ZKwtAHDUvxMUgXUIRQTI/bQTQYT1qX/OKsmaWXOyjyHiVUTdtIISVk0LTzxI/75b9lsPqzo=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=vivo.com;
From: Qing Wang <wangqing@vivo.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Jens Axboe <axboe@kernel.dk>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel@ffwll.ch>,
	Alex Deucher <alexander.deucher@amd.com>,
	=?UTF-8?q?Christian=20K=C3=B6nig?= <christian.koenig@amd.com>,
	"Pan, Xinhui" <Xinhui.Pan@amd.com>,
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Alasdair Kergon <agk@redhat.com>,
	Mike Snitzer <snitzer@redhat.com>,
	dm-devel@redhat.com,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Hans Verkuil <hverkuil@xs4all.nl>,
	xen-devel@lists.xenproject.org,
	linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-clk@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-input@vger.kernel.org,
	linux-media@vger.kernel.org
Cc: Wang Qing <wangqing@vivo.com>
Subject: [PATCH V3 7/13] md: use time_is_before_jiffies(() instead of open coding it
Date: Mon, 14 Feb 2022 17:55:44 -0800
Message-Id: <1644890154-64915-8-git-send-email-wangqing@vivo.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1644890154-64915-1-git-send-email-wangqing@vivo.com>
References: <1644890154-64915-1-git-send-email-wangqing@vivo.com>
Content-Type: text/plain
X-ClientProxiedBy: HK2PR06CA0012.apcprd06.prod.outlook.com
 (2603:1096:202:2e::24) To SL2PR06MB3082.apcprd06.prod.outlook.com
 (2603:1096:100:37::17)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4d1b7eae-3c35-4b24-eef9-08d9f0266c1f
X-MS-TrafficTypeDiagnostic: HK0PR06MB2771:EE_
X-Microsoft-Antispam-PRVS:
	<HK0PR06MB27714B8A27E9EFD13292E88DBD349@HK0PR06MB2771.apcprd06.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1051;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	9umtK72So+HOJMJynAoNcqIKtzt8h6WC+lj/eowtVzatDO2oyReLR1Hix0xDIsU1sFqF08DqIOfCCqfX6TYO4B3mpvaup1hC46JJFx7mM21PlNybWqUqYku9K2XyJmoQjd2+PaInkHvTl5BJUjCLTf77VbgxqiPdzsfnrpyN4+pUnROQ3V/DR1va09Qz5Udej5Ct63iAYR366Y6MMHb2wU9wKxwJaWfPiwQ4eDfWYA/Py64voQLBmWR7TxKvinU+SBH5oU3qfU3ergN1fyyBzwHGEIp3Zhd2PyS+7hT+HF0zDr66ZHtCy7Klv1phAXTXN5DuNWStGnQltaYmRdZ84SXzz5vvXEj99opE/TUT9jAMRIUnE6Md9FuirbNy3KeL8ka5j6w33zm7BoXy3GwVrZFH4Nztx8Ij+WqNx5GsSt23DRol9ZOqORxF9Lz3gNgPBS2YDgNByZPluY6PNruGWIdsn3xR+jNGKC6z7ejBJ2qrGa80YEow7mhl/fk2zCoop7k5H04SCo6VJuHeA+0N/lOTzyukEgzbpm7fsiXDXd4Mu1ov/oet7kRltQbK3J4OFOa+xGDQJcXa5JKOByCMO7NvwGOXCRQZNfFYcgVpndi1WXBsiBFoe27CW1IQNY0P4yLb8F+HIT4xcJHIpaNus30HBx6JlUZuUgZOd6s1CJil7+rizoC0dY5iJ+n3L8P1rwbiPDncS9Hwf6HVNWVM80aceDzpruN06ZP3YjSfl58=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SL2PR06MB3082.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(8936002)(83380400001)(26005)(186003)(6486002)(508600001)(107886003)(5660300002)(4744005)(2906002)(7416002)(7406005)(921005)(110136005)(316002)(66476007)(8676002)(36756003)(66946007)(4326008)(66556008)(6506007)(6512007)(52116002)(86362001)(2616005)(38100700002)(38350700002);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?Qr7w/D3OwuPzFuWkRZasFmrqocTl0pOHW++Bqrc3lcdxzjB/q5XVEUCRe37w?=
 =?us-ascii?Q?QNTIS3R0DZxIHiV7QJYqRq/olod9AdUGZqlbJDMEQPXgTMevhNZgsfhLGtH5?=
 =?us-ascii?Q?5UX6Rtsi9GYDecsPwJ/Eq1x47R+NF9mGL5Do1u5hxR+lBofLxh18b6lGX/2k?=
 =?us-ascii?Q?9YpRWMsTRBO0ynv+np15xuEQDx9Eym4+wpeWXaSASsEkR83/JgZsuvBrHcpW?=
 =?us-ascii?Q?Z6BH2D9kbP2c0qYB+thkeW5lIEkpGngkDvGwFvdkqXHivG/yJ+B2KwKy9PEh?=
 =?us-ascii?Q?se9nYvuiwfyMbzWMehmXw8AO88Hw4/9HIu2VXPH+QTPkIwa5zd8HCCAVJISd?=
 =?us-ascii?Q?5AIf6rzDhTEEs8aoaCA14d3av9OU8NKf+LQiYch7a6woHKswUxirMKaS34lf?=
 =?us-ascii?Q?bmEDlzeaWgxcQjQB0CMgKLmbo29rgQGgm9WE4QN+XynqS/Z969xr7N7cUQZt?=
 =?us-ascii?Q?MMcJayibm1zG2M/5DOqAImRri1aftADciPBPd38xdMI7Hfku5Cvnp91sGgtk?=
 =?us-ascii?Q?odHzdjh1Gjt6ZZiLe9G7Z746TAK2BR0wQnrH3m98yADwQzSP/p7oELzgQoEr?=
 =?us-ascii?Q?8mOX+J6TmZd++8iwRltk+BMYLU2tWqix7L5UL7WgR0PCzNf+FjpRdBWNsRmt?=
 =?us-ascii?Q?C31TM3KTZGVh3tRxYEd8lzKaqLZJLDGUeDV12Ft7bbYjsEvziaZBhFT4unsd?=
 =?us-ascii?Q?Qw4C4jPFWhZ5w2CJDVZsLVy84/DYgZFwpF8+qt1ie2LRSaHdexsbzB98Qx9m?=
 =?us-ascii?Q?QGuaPf+kLWyB0MUOjW5LiljKqo0+hRGHju+MDINcJ4rVefJq8XnV6kEh5wn7?=
 =?us-ascii?Q?RW4Pm7tYery9HWxsevbGRh4OxnnL9NoGKl/f95nxJGoWehOHoB9RTNjmBH12?=
 =?us-ascii?Q?IQyR9OzTTCHZPqaZbR0Er7aOj532vq4JfzPp1jfkYLYI9briowSGCuV5j+el?=
 =?us-ascii?Q?FBwkxfa3suvijWLh0QUv9R/fQKQWrkgoixd1TMTRyk+jq4W9i64iDprtKbWa?=
 =?us-ascii?Q?UGZ/9XIfuLj7c5DDylnQ93wr0+FPUDgn08Dk83cwX1J9vfHj3ncxVxX1jMI0?=
 =?us-ascii?Q?FNcc/MCoGaAlMRcKkRUahXVj0MjB92/RwUR9wLaU+VaznKomzy6ZQk/AwdFz?=
 =?us-ascii?Q?aCGndkgjgvUlWohre4GDNAPDg+F5tOoYqtOMjaSALxhrXQ0HWloTfIFl8vRL?=
 =?us-ascii?Q?cid3sQWtxr9GNtbaIeLa/NX+o+jYO6VuKLtbYvz+TgUvIRoFPiFzz7xgXWsL?=
 =?us-ascii?Q?bFhdk7V9yhXCZayLZ3PoPYK/srI+WHEC5x0RVEWfHF4cuvARhnxxm0TZiAoF?=
 =?us-ascii?Q?Ej1180RLRoZb7LiEg0dKOFyJqrgBTv05ApySLW9FiUFB6Fva98r7+qPhBZNA?=
 =?us-ascii?Q?2gpgQvtbo6chMBrNPSsjeyQ2nuzhlU+MeBi3ysnv7ptrcH1VXkWE0jGdLCV4?=
 =?us-ascii?Q?fyupduk9WGDZU4cN/hfitMbDRYeYs8fbSUojPgCwLd2SjlzpC4VdibE1Az9u?=
 =?us-ascii?Q?tiVhd3n4aZtddVZYLr/0Sjc4hrTNcvAimoc+hmrwoYVlKi1F8pdUllIJo5KF?=
 =?us-ascii?Q?5dHWkfSMacLeAxl5nhEOurkudAMyOUD6A7pKp9VERvIsXv6sMloX+sx5mHuu?=
 =?us-ascii?Q?7ZDVQNaDA48h3I/V+WoZY3A=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4d1b7eae-3c35-4b24-eef9-08d9f0266c1f
X-MS-Exchange-CrossTenant-AuthSource: SL2PR06MB3082.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 01:56:46.5435
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CuQkkncIquAWowsVFvIAcUne9uogjwEjTI2rzMIdX/1OvIIRW1Yo0U53H2jqSYhEesX6mA/XB5q98w+hWzCkuQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK0PR06MB2771

From: Wang Qing <wangqing@vivo.com>

Use the helper function time_is_{before,after}_jiffies() to improve
code readability.

Signed-off-by: Wang Qing <wangqing@vivo.com>
---
 drivers/md/dm-thin.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/md/dm-thin.c b/drivers/md/dm-thin.c
index f4234d6..dced764
--- a/drivers/md/dm-thin.c
+++ b/drivers/md/dm-thin.c
@@ -161,7 +161,7 @@ static void throttle_work_start(struct throttle *t)
 
 static void throttle_work_update(struct throttle *t)
 {
-	if (!t->throttle_applied && jiffies > t->threshold) {
+	if (!t->throttle_applied && time_is_before_jiffies(t->threshold)) {
 		down_write(&t->lock);
 		t->throttle_applied = true;
 	}
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Tue Feb 15 01:57:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 01:57:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272705.467644 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJn5m-0001i6-Lw; Tue, 15 Feb 2022 01:57:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272705.467644; Tue, 15 Feb 2022 01:57:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJn5m-0001hR-Gv; Tue, 15 Feb 2022 01:57:22 +0000
Received: by outflank-mailman (input) for mailman id 272705;
 Tue, 15 Feb 2022 01:57:21 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=A2Di=S6=vivo.com=wangqing@srs-se1.protection.inumbo.net>)
 id 1nJn5k-0007s9-Vx
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 01:57:21 +0000
Received: from APC01-HK2-obe.outbound.protection.outlook.com
 (mail-hk2apc01on0729.outbound.protection.outlook.com
 [2a01:111:f400:febc::729])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9aceee25-8e02-11ec-8eb8-a37418f5ba1a;
 Tue, 15 Feb 2022 02:57:20 +0100 (CET)
Received: from SL2PR06MB3082.apcprd06.prod.outlook.com (2603:1096:100:37::17)
 by HK0PR06MB2771.apcprd06.prod.outlook.com (2603:1096:203:58::9) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Tue, 15 Feb
 2022 01:57:14 +0000
Received: from SL2PR06MB3082.apcprd06.prod.outlook.com
 ([fe80::80b4:e787:47a9:41bb]) by SL2PR06MB3082.apcprd06.prod.outlook.com
 ([fe80::80b4:e787:47a9:41bb%4]) with mapi id 15.20.4975.019; Tue, 15 Feb 2022
 01:57:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9aceee25-8e02-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=e/BPnwY+ZdxxyPyIPnN7em1ZZrfniVeiNlO7hnPdm1ldxYX1feoUux15m3UKOTr0sXh9NoaKecRINMiKYJ+CrwIWTsPX+vCqdyNSC4rjhx5kZAriEeuhJkIQOALiGvJQGEj4agH2lQCgjcia9UoegqBrJpRRnpe38I9Hj5DwICjK+67vdGrwMfG8Gh7dap/bdMb69s+gO2uQVNZU89FCJVB3qikv9wMPhuZLWY+LjpmKm/z3uNKWaobExfakXLE0Z8ohacKWg6gUKBm4pwe9jdTKJg31jsnuy/ZIjbaSZ4T/jgHX0UPboPkoXzsezF2AqzpIVIt6jvXptYpNvsbXYA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=/5nzH//PBKk0+joZfpDWq2saS2oSjNrVp/U+ZGSXe3c=;
 b=oPrRBxdhTtRkJW3Gij8/hsBhbcnno+UatYccov9bO0iJnBp7xk1hN3Rxbaefp+QQQ0forR0V6nvwQEVDV05dQm5aYJWIx8FhMOKu3fawTdPrV9JfaHdNifd9hNa/zYUfGkSSQBhQlKMHZOeJrZP7hDwxtsTyFzei8uoqWJun2JV95EfsyyMLoBCnL97AISNjvXOp3ONesp7Ocv28ZTpg4jyDNvjM/IKcS0mkOqcMX6/T/gdG3QrmyHnW3Qt1GAX8IuSPemuVBLuFOUH+/XSBUCgtlNeWs9noSRHR1ZxjMb51SlpR2506PyMcbezEXIKB0r/Ew5osN1vK8jw95TsUVg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo0.onmicrosoft.com;
 s=selector2-vivo0-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=/5nzH//PBKk0+joZfpDWq2saS2oSjNrVp/U+ZGSXe3c=;
 b=Xb5egVe6Qv70vT8lhPbHIt9VrBVhH3BwkIDYAkPe5y6nrBXwLUZbG4tjOZAb2wnlzdW7lb2rpuhIGCwDGOLgBmp8Nz1t6MJUvD37UDDpbrTSZdrsBRhZ6iI9VET1/K2gRnpxpKm013fB7pOy33QQ5FYddoDzz6st8RB63X+Mmok=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=vivo.com;
From: Qing Wang <wangqing@vivo.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Jens Axboe <axboe@kernel.dk>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel@ffwll.ch>,
	Alex Deucher <alexander.deucher@amd.com>,
	=?UTF-8?q?Christian=20K=C3=B6nig?= <christian.koenig@amd.com>,
	"Pan, Xinhui" <Xinhui.Pan@amd.com>,
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Alasdair Kergon <agk@redhat.com>,
	Mike Snitzer <snitzer@redhat.com>,
	dm-devel@redhat.com,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Hans Verkuil <hverkuil@xs4all.nl>,
	xen-devel@lists.xenproject.org,
	linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-clk@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-input@vger.kernel.org,
	linux-media@vger.kernel.org
Cc: Wang Qing <wangqing@vivo.com>
Subject: [PATCH V3 13/13] media: vivid: use time_is_after_jiffies() instead of open coding it
Date: Mon, 14 Feb 2022 17:55:50 -0800
Message-Id: <1644890154-64915-14-git-send-email-wangqing@vivo.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1644890154-64915-1-git-send-email-wangqing@vivo.com>
References: <1644890154-64915-1-git-send-email-wangqing@vivo.com>
Content-Type: text/plain
X-ClientProxiedBy: HK2PR06CA0012.apcprd06.prod.outlook.com
 (2603:1096:202:2e::24) To SL2PR06MB3082.apcprd06.prod.outlook.com
 (2603:1096:100:37::17)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7b832f5a-dcb1-4e65-5aaa-08d9f0267bfe
X-MS-TrafficTypeDiagnostic: HK0PR06MB2771:EE_
X-Microsoft-Antispam-PRVS:
	<HK0PR06MB2771D9FC8FCE2704409599B8BD349@HK0PR06MB2771.apcprd06.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:590;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	H/4bqIzmoJrpbSPGOKQFg3STl7pNYuYY7HyAxnoNBYmHT+1a0htC4+KZF4nwpycZ1/W4Ctxzyx/PTvG3N36pMzTrkwSMNUzF0eUxAwl/1rlecctY7zsoP2L9SvhyRdcRzpjhlch2M5M7XpQvoZMKh3HDdA2KuLfI2jIInkjIyZpJvcAv8EwliaBDXBzCoOTQcOsr+HBcV27t+G/srcgQdCQEO5z32g6Mb8n+3eBGcZXac/IEc1tk+5fX6hHvOILfg26RgtWlnK84Uae7R4C7zu50/JvXvt6dDOeuKSsyKuTnrdXUeNToguNafjyllSS1g21/q7jTp1j3dxuvHafZTl3z/6qUQJ69+xXsYaAC2JHjtZvQ25BVpldPtExoa4xHj+jLPRg/7qLfrffdM0zMxI3lFePj20ysi1vRUAQkRIGpchPE7xvv1LD9F09v0tfSMppv98XwLX7xDgXiaI0CRk6ciSNtosf/CfVu2y2Awx53M2z5rmBP3GbGRyO72dVVzSpJxNzgnmqG1fn0DJtYOJSuWiQizCnY26Js+nXAWNIJ06euzmYCW/ncuyuQjZjaha9PlxiMUg5Bh1v7N8bQ+GmH3xQRqDnVBMKYpEzlaCJIrqM0Pp2Ze9cY7qgurZBMVHLi7cz8NNRhhXhg39xgy/3fmUR1GgJImDyuMo0WJz8Kpy+aTQNRzKhxeupYM5otuAJslYIxdxixFCxsrIz/AA==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SL2PR06MB3082.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6666004)(8936002)(83380400001)(26005)(186003)(6486002)(508600001)(107886003)(5660300002)(2906002)(7416002)(7406005)(921005)(110136005)(316002)(66476007)(8676002)(36756003)(66946007)(4326008)(66556008)(6506007)(6512007)(52116002)(86362001)(2616005)(38100700002)(38350700002);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?bK0nz8C1sAOMe2uEktKzSvPsIyfDKfV9FcSqR+eBqcWsshGvBa4WTZxU9KiE?=
 =?us-ascii?Q?3Vav+GqZW7U69B2v4SW8UW71GSYl2UGRPwB+hEPoa2P2v1HPRTk6E+yeY03a?=
 =?us-ascii?Q?Zoe51jzCRekRNgd0Zfa8LyGJpeKJ4J2ZGHEYxlUKVyHUICMKKOxn3LAcS54i?=
 =?us-ascii?Q?3JWXhM5Ir/j1SPSAB2BtSxLERl6DJc2MkRkLRNieotOIfArJ8Dg/wOBaK48R?=
 =?us-ascii?Q?acOhO5vW1kEdBIcih9bnKLFZDSo5wJmnd5lkB0ifef38Kot8n6fXzT4Ewij/?=
 =?us-ascii?Q?JQGE8ompPz3xAZBs1vqFipu7WwWzHS5n6pvKprgGGYJKuXToTGtkEt1Te7Hc?=
 =?us-ascii?Q?ihh4zgPRlEB3B1cr9nh4AHp4ZmkWsdEvMIdgyoR5JW4eEsXsUnq4GtPjRk5F?=
 =?us-ascii?Q?PPJsjU3jNOUVWrO7ZBiiY4yOoppLLknRub8sfYbIebgTdg6BgwGcfS8g13vw?=
 =?us-ascii?Q?CO2+jBzLb9uIGEU33ENOq6QjZdKzUElFbkPw6Jbk4MbPmDtn1yqVtVxQ125l?=
 =?us-ascii?Q?Yw9SdR743VUpRRldl/IRLoKC0E5j5bXfzANnIypQGtL5w7J3WvaRe8oMQ5m5?=
 =?us-ascii?Q?y13uChO8xNvh975DtaOg4HrLP5fh1jbkYVllm4TauZ0y0GnTbCOLU4J7WXTV?=
 =?us-ascii?Q?IDTyuyJW6Wg3VMD3j1XxNPFzK/3gYbttE/35o2wL+JYP3R7SPYHa+OLoX5nG?=
 =?us-ascii?Q?IZgz6347m+JC/13n7BgJ+/TfttoWX9IdRx2GAQg60lEJaTEtoXeeANjD0vip?=
 =?us-ascii?Q?ZNmtR81KhQ3WzvrJ0tyBEdTE9iqt58cX/sv/g+juJ72n8gnDYN66DdpWjI1w?=
 =?us-ascii?Q?h241ziU2Edw4OqKVceCI6yBL+p+GB8gFLCXdqya1ULuLjOsHPFA8UYofJANG?=
 =?us-ascii?Q?Kk3/NyVWwJ5nnnQQWnNxoDsTnIwX1gs8GEf/arv+/g8LqEzOjVj9m4axF1PB?=
 =?us-ascii?Q?dR0Jwr2eQkB2fT6v9YeC1G6zh6Efj50kJyhItTSTlX+ZYDjw/LIWK81p1D/Y?=
 =?us-ascii?Q?UZCRzvN30HUG6BCTdpEJjElEphkrzSIASJM0AVgMV65nnibnCJnr/d5qvNbd?=
 =?us-ascii?Q?9HiIspZG586oGk+B8kHhl0lXnB4682W3u+806BQog5YIwFTjeo6A9vExY3l2?=
 =?us-ascii?Q?+Y22bHHUZ29d1oLocAYelNLv2MGfYnYEhU55KvO3zG/tqMSwBOlTbKCLJQ5v?=
 =?us-ascii?Q?/PyrIviFHhht/Xwfy/FXURBEzA40RzTK2yMDZVZTBeLcTXeNqu6WPuUg0ZMp?=
 =?us-ascii?Q?TlrVTzO3GwXhSpDqBqfqCNxL4OWWGcVQf1sdoDTdt3bCKoH6c3Jdf3sGbDDX?=
 =?us-ascii?Q?Lwv1ovGhvyWvJa+FkrnrGMNJOGJBEywV5XyU5XmEfqyvoZRgTQeSqifwD6ik?=
 =?us-ascii?Q?hfJaCXJas1GH5OcoaI2G1QoxCcqScLz4dceDs705ftneXbQ9Zx5HgB0urOgi?=
 =?us-ascii?Q?145/5Jaf9b51bo95nqOZglW8AxsfiTJcsur99k7xj2FVC38wF4II1TAlbbiA?=
 =?us-ascii?Q?QvF1XxxLoBN5AkOGhBI9Fq21+tmTXulegOcY5MySIWm3MJ4EUGX+Rxr1vr7r?=
 =?us-ascii?Q?1wKNCzV5xjDjpzYNYlJSI3EgvGYl9cx/48GLboYyfKvjmCpzN8r0fbMuIfxg?=
 =?us-ascii?Q?JRkfz4pmTNqX4/+9vBRbhOI=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7b832f5a-dcb1-4e65-5aaa-08d9f0267bfe
X-MS-Exchange-CrossTenant-AuthSource: SL2PR06MB3082.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 01:57:13.0888
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uyZdUVP+2fWY+yORosp2bLfqv4Z5+NzGfn3oDk/tXxeEcEmDE7T6Y895G6GWUbvVkpnX9VDalim26j+6jFRLMA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK0PR06MB2771

From: Wang Qing <wangqing@vivo.com>

Use the helper function time_is_{before,after}_jiffies() to improve
code readability.

Signed-off-by: Wang Qing <wangqing@vivo.com>
---
 drivers/media/test-drivers/vivid/vivid-kthread-cap.c   | 3 ++-
 drivers/media/test-drivers/vivid/vivid-kthread-out.c   | 3 ++-
 drivers/media/test-drivers/vivid/vivid-kthread-touch.c | 3 ++-
 drivers/media/test-drivers/vivid/vivid-sdr-cap.c       | 3 ++-
 4 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/drivers/media/test-drivers/vivid/vivid-kthread-cap.c b/drivers/media/test-drivers/vivid/vivid-kthread-cap.c
index 6baa046..295f4a3
--- a/drivers/media/test-drivers/vivid/vivid-kthread-cap.c
+++ b/drivers/media/test-drivers/vivid/vivid-kthread-cap.c
@@ -18,6 +18,7 @@
 #include <linux/freezer.h>
 #include <linux/random.h>
 #include <linux/v4l2-dv-timings.h>
+#include <linux/jiffies.h>
 #include <asm/div64.h>
 #include <media/videobuf2-vmalloc.h>
 #include <media/v4l2-dv-timings.h>
@@ -893,7 +894,7 @@ static int vivid_thread_vid_cap(void *data)
 			next_jiffies_since_start = jiffies_since_start;
 
 		wait_jiffies = next_jiffies_since_start - jiffies_since_start;
-		while (jiffies - cur_jiffies < wait_jiffies &&
+		while (time_is_after_jiffies(cur_jiffies + wait_jiffies) &&
 		       !kthread_should_stop())
 			schedule();
 	}
diff --git a/drivers/media/test-drivers/vivid/vivid-kthread-out.c b/drivers/media/test-drivers/vivid/vivid-kthread-out.c
index b6d4316..13f737e
--- a/drivers/media/test-drivers/vivid/vivid-kthread-out.c
+++ b/drivers/media/test-drivers/vivid/vivid-kthread-out.c
@@ -18,6 +18,7 @@
 #include <linux/freezer.h>
 #include <linux/random.h>
 #include <linux/v4l2-dv-timings.h>
+#include <linux/jiffies.h>
 #include <asm/div64.h>
 #include <media/videobuf2-vmalloc.h>
 #include <media/v4l2-dv-timings.h>
@@ -234,7 +235,7 @@ static int vivid_thread_vid_out(void *data)
 			next_jiffies_since_start = jiffies_since_start;
 
 		wait_jiffies = next_jiffies_since_start - jiffies_since_start;
-		while (jiffies - cur_jiffies < wait_jiffies &&
+		while (time_is_after_jiffies(cur_jiffies + wait_jiffies) &&
 		       !kthread_should_stop())
 			schedule();
 	}
diff --git a/drivers/media/test-drivers/vivid/vivid-kthread-touch.c b/drivers/media/test-drivers/vivid/vivid-kthread-touch.c
index f065faae..8828243
--- a/drivers/media/test-drivers/vivid/vivid-kthread-touch.c
+++ b/drivers/media/test-drivers/vivid/vivid-kthread-touch.c
@@ -5,6 +5,7 @@
  */
 
 #include <linux/freezer.h>
+#include <linux/jiffies.h>
 #include "vivid-core.h"
 #include "vivid-kthread-touch.h"
 #include "vivid-touch-cap.h"
@@ -134,7 +135,7 @@ static int vivid_thread_touch_cap(void *data)
 			next_jiffies_since_start = jiffies_since_start;
 
 		wait_jiffies = next_jiffies_since_start - jiffies_since_start;
-		while (jiffies - cur_jiffies < wait_jiffies &&
+		while (time_is_after_jiffies(cur_jiffies + wait_jiffies) &&
 		       !kthread_should_stop())
 			schedule();
 	}
diff --git a/drivers/media/test-drivers/vivid/vivid-sdr-cap.c b/drivers/media/test-drivers/vivid/vivid-sdr-cap.c
index 59fd508..f82856b
--- a/drivers/media/test-drivers/vivid/vivid-sdr-cap.c
+++ b/drivers/media/test-drivers/vivid/vivid-sdr-cap.c
@@ -17,6 +17,7 @@
 #include <media/v4l2-event.h>
 #include <media/v4l2-dv-timings.h>
 #include <linux/fixp-arith.h>
+#include <linux/jiffies.h>
 
 #include "vivid-core.h"
 #include "vivid-ctrls.h"
@@ -205,7 +206,7 @@ static int vivid_thread_sdr_cap(void *data)
 			next_jiffies_since_start = jiffies_since_start;
 
 		wait_jiffies = next_jiffies_since_start - jiffies_since_start;
-		while (jiffies - cur_jiffies < wait_jiffies &&
+		while (time_is_after_jiffies(cur_jiffies + wait_jiffies) &&
 		       !kthread_should_stop())
 			schedule();
 	}
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Tue Feb 15 02:06:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 02:06:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272719.467654 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJnEI-0003xE-Fp; Tue, 15 Feb 2022 02:06:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272719.467654; Tue, 15 Feb 2022 02:06:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJnEI-0003x7-Cd; Tue, 15 Feb 2022 02:06:10 +0000
Received: by outflank-mailman (input) for mailman id 272719;
 Tue, 15 Feb 2022 02:06:09 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=A2Di=S6=vivo.com=wangqing@srs-se1.protection.inumbo.net>)
 id 1nJn5S-0006If-7W
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 01:57:02 +0000
Received: from APC01-SG2-obe.outbound.protection.outlook.com
 (mail-sgaapc01on2071e.outbound.protection.outlook.com
 [2a01:111:f400:feab::71e])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9093a397-8e02-11ec-b215-9bbe72dcb22c;
 Tue, 15 Feb 2022 02:57:01 +0100 (CET)
Received: from SL2PR06MB3082.apcprd06.prod.outlook.com (2603:1096:100:37::17)
 by HK0PR06MB2771.apcprd06.prod.outlook.com (2603:1096:203:58::9) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Tue, 15 Feb
 2022 01:56:50 +0000
Received: from SL2PR06MB3082.apcprd06.prod.outlook.com
 ([fe80::80b4:e787:47a9:41bb]) by SL2PR06MB3082.apcprd06.prod.outlook.com
 ([fe80::80b4:e787:47a9:41bb%4]) with mapi id 15.20.4975.019; Tue, 15 Feb 2022
 01:56:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9093a397-8e02-11ec-b215-9bbe72dcb22c
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=kpP2y20MYGOxSEPc0GcMSozyevJPDMsBxdqncEMYFHZUXIqHOQUm3U6zc6bX08gaWINByP0mgLWcyEolNUIbMZUeVR96jnNGOS+3qKNK+yAFcoz0I0QHsQ1q3zhvUWmGVn08pviy2JxcOgV1kSzDnz/WcGizMamgwuDG40BMa3sE3Lg0eqG7lojfUpm0W0DBqkxn5Z1byrPwJmzkfXPTcQHaoea4iNsETG6/gzEI59iABrXLCsIUODhVzFT6LRDzqTqLCxNgijfHbaF7okxJiNSs5Lztfkk2abY0vsd/odOXWeDhGEffamBtN1iKHJ6cwpUJtnUhFbyxfzLRfI6RRA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=vnUOhbL312WydrIZGtqkVI+fDJEpdEbLKHZMp2nzkhA=;
 b=D1RYtJG1lkD9GW/NYymXmdEiW2jdSVEIIn2KMRY/hA9qYrNP4vgCeZ3xhQBGhmojpAzoA6x9EFUv4Bs6XcTekRDrjf1WRc9M+k2zLsIVwP75PQbukCQMn78Vye1NOShtL4PVSzb1IK2Z9iSsGYo5kYd3DZbCvqlXZScvpo2BVVmYAG0J+RGE987ZbCA7MuZ5iM7Frn/ooh0HA/wgjoELLQ8JC+qric+6xM9d+AxioqQhehszvk4X3VBEdaBP1prb3KnVuadVjhlVNbsE3w78LWOlsqguietVUT1TlxU1TEypxwGQZ4UnQ8yn7P8p0i2uXVdYwnE/j3LEjCTKeJMZZg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo0.onmicrosoft.com;
 s=selector2-vivo0-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=vnUOhbL312WydrIZGtqkVI+fDJEpdEbLKHZMp2nzkhA=;
 b=GqIiQDLhuwcAXjWmqE+Zqk8WJ6EWQNe17U22epLF/Taq6SR7LyNVqeiDYrifXWhE6Kih08KhndBdwUzfXFhvo2gzZ2wdYFnC9f9GnNpVgKYxMKR+TjXg5wVlAHteb+FZKYnYOeU5tE/AuGwA8p5TUuuJ9ha81r51sD0n38p/J1Y=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=vivo.com;
From: Qing Wang <wangqing@vivo.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Jens Axboe <axboe@kernel.dk>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel@ffwll.ch>,
	Alex Deucher <alexander.deucher@amd.com>,
	=?UTF-8?q?Christian=20K=C3=B6nig?= <christian.koenig@amd.com>,
	"Pan, Xinhui" <Xinhui.Pan@amd.com>,
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Alasdair Kergon <agk@redhat.com>,
	Mike Snitzer <snitzer@redhat.com>,
	dm-devel@redhat.com,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Hans Verkuil <hverkuil@xs4all.nl>,
	xen-devel@lists.xenproject.org,
	linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-clk@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-input@vger.kernel.org,
	linux-media@vger.kernel.org
Cc: Wang Qing <wangqing@vivo.com>
Subject: [PATCH V3 10/13] md: use time_is_before_eq_jiffies() instead of open coding it
Date: Mon, 14 Feb 2022 17:55:45 -0800
Message-Id: <1644890154-64915-9-git-send-email-wangqing@vivo.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1644890154-64915-1-git-send-email-wangqing@vivo.com>
References: <1644890154-64915-1-git-send-email-wangqing@vivo.com>
Content-Type: text/plain
X-ClientProxiedBy: HK2PR06CA0012.apcprd06.prod.outlook.com
 (2603:1096:202:2e::24) To SL2PR06MB3082.apcprd06.prod.outlook.com
 (2603:1096:100:37::17)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: bc486b2e-0c4b-42c7-dbe7-08d9f0266e9e
X-MS-TrafficTypeDiagnostic: HK0PR06MB2771:EE_
X-Microsoft-Antispam-PRVS:
	<HK0PR06MB2771BEC0CF4E3EFFBC004F06BD349@HK0PR06MB2771.apcprd06.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1148;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	QCWO2F/w7eHbPOL0e0e9xQNZ3K7Xw38kdf5QuAOps+fk4Qcyo4C93c+aP8pDzbFZqheTj3ekgZGi/KEmlKhO2hsT4HRpBrVAuDZtGAA/7+AhyggclMFAiPWcNsA85irQz1bxTwY4PAmsNiAwaQ7U5Spvdh/RaA08wsakr0eXNmjSl0CdZH2L7u52GJYQ+dB8pnl1cXqlAAk5se8p/5iZHmzeUUX1/TPuhcLcqUzRk2Eeo16YhX3yIkbFJ99sKMhYD2+1kDbpuUZct0ntXKZAy7BcLIGijpcXw0Y6emoKi4BJDB5WcD0wrbuEmvkgfGgyFwom4EhwUeuFZTyP1kHt35Ik673k2CMg80JKoPspYnxTcI2o5Xik5vtOOMqx/eT9W/9H8SZvl2hIT0dF3Wq5m0q+k7tNOi24kWszEVv9suEW8przc+tNA6lbAigv+gB8vbkfrg7QqsER7o9iPLvqpJTmdX2gUoNzdjHT6tCUiyLZQAvPLNgteDYd1Dzkg4eTX70lexMX35irUPEM2RmPi0t2FAljly1zKbkzhvyAl36WulZgHESjauZzgep/bb5v/rCPUyHKd8bgsMfHtFUXthTtzyD9BWd4ajwAsRRZbgQU05R+VhaLX38K/km+TYJ0bayJRFx9pzwfXH1M8z9nUyxmTz21Ial9TeG9T4gHHsfvkQSskZ4H6FJ81jCQZ9P6/CoG+ox2E6Dwdcz2v2DYxiJtDjHnbDQrDqcOOvtT8h4=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SL2PR06MB3082.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6666004)(8936002)(83380400001)(26005)(186003)(6486002)(508600001)(107886003)(5660300002)(2906002)(7416002)(7406005)(921005)(110136005)(316002)(66476007)(8676002)(36756003)(66946007)(4326008)(66556008)(6506007)(6512007)(52116002)(86362001)(2616005)(38100700002)(38350700002);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?OcTsoEukQ+WkoN81aeNCUVTtA/p+y9SYnPvIhqVkCOJ9JSD22yIhnJ75M5XE?=
 =?us-ascii?Q?n1Q4ZkQbaUON6f4JhZ5u52/RF/0lL9DGkR2VdAFmwZ7gbTKvT7PynwlXP0Sj?=
 =?us-ascii?Q?vYMWATYITfIVvjjwBQs+QxLhR0zB8XQ/iq78eCj4TYCPdttxNVqr8S4J5Krt?=
 =?us-ascii?Q?L9Zxsj0cXdrtrvCIcr46hltG7mlz+KPHoF2zHRCFoLDMr52n6gbLaF8wzJ3K?=
 =?us-ascii?Q?2InTyLh+JIhF+HH28Pr1pKUvCFwooMpQxcfalNpV/gPowcgYE5jmr9mk2nE5?=
 =?us-ascii?Q?ilzdTc0KFh5COYqtoWV0rBnOlNbOtrOJEIlV6QM8D8TU0UZpUZxmQkC2jd9P?=
 =?us-ascii?Q?AfL2IeaLgjV3AwyMjvD25DjleeiAC/CxM2g8KGW+4ExcNLMEgvFVVMPEZ+KC?=
 =?us-ascii?Q?KhLpNU+/05zcGqmMhuSBLgb19vIqEsQy0QxKp2TbqB++U5FpQErjW6q9oyU2?=
 =?us-ascii?Q?zv7iIanbMDFBDUQguUWX/ERXS6lfk4MdXNjfnyEAnALVBHhsbd7tCOzo0glj?=
 =?us-ascii?Q?vGfxQwyoZSX+Ew6rI9vupdC29l8bA9ElFFLxb5sHOO9THvvx19MUzgby6HnC?=
 =?us-ascii?Q?qIUsGJy1ZnNJI3RBMcN6PBJRbfNGmTh/+ltPTrQW6cF8qTl1ij7i8BC4oaW+?=
 =?us-ascii?Q?DzDJA8X0vlfP+HYOpo6xn3OkZiY+4PIxo/oIHsoYIRzTm+vJZEFeGEggF6U+?=
 =?us-ascii?Q?Kk/XMD84YTzQpLJ4J15NuhHdGqLejgr9F5ZkpNv8A6SPmDEv7N4/KEL9RmR3?=
 =?us-ascii?Q?sssQ4cKyyiaKsJYrcZd8QPNzgiJiMCafib0OQuI44eC93V+uqVglogDPRyVd?=
 =?us-ascii?Q?3l3RvfAHjE0PC3S03f9pYHQlxYaZnn8JotaFCD8vcaXmerI1CF+4qnd+nOaY?=
 =?us-ascii?Q?BYf0BkKZIJTr6od28EU8QMVMLVZXRrPY40XOYX+x0AzMYstmE9zTyUyiIsWO?=
 =?us-ascii?Q?YV/6U3z/A9F7+0CYe14WCbQyYTQ5H8+BosKseJCVFyjSuSeGI06TnWDyaT8S?=
 =?us-ascii?Q?TedbubTINWAXQ1EGqIomyQ2nL5wpZMvI5SpBiWo3yr0/onds5rh//9fIpiu6?=
 =?us-ascii?Q?8vRLvF7QXRtLJdIBF79KfPw+Oj3lqe6saxXgSYx2y630EiT3ll0KLFi2kYMc?=
 =?us-ascii?Q?yod2o2L7hp48sEXqisDoBVWeoVbGUmPlZM/f6wnG2WesR4A2DK+GGlhqbBMY?=
 =?us-ascii?Q?S01mGc0wkRazG72SFuP5RjTwFEdqJ+jaRTlMx2gSARnvcG9cxJeRhIsIYZHz?=
 =?us-ascii?Q?vXQ6oe5jmGF9GGtRSsxTT6gW+VKjtZT/xpVMYw0cA7jrD6Fo/BtEPgR61ueP?=
 =?us-ascii?Q?qnDevb8DlIdYexCFURi6YX5aVdQTCijIT2SeKV0D8NgIgbyKIebVF5Ig89LV?=
 =?us-ascii?Q?KC8/fSMejiS3bwajXrLzv0dNXTJGsSx8oLVGFcaolZRNbGi6+JhZpsBIBqY4?=
 =?us-ascii?Q?lFyBkAdQ3bpSCr9Rvk+7T2K68fUaVC9ryHb7xWFpB8NMG/yYbxGTVNoUtaxQ?=
 =?us-ascii?Q?qVHbF5DIgAwlsnIoFv7dGrWtY3/i7VolntJhqo5JtSAi38QA2b9HhMJjY63j?=
 =?us-ascii?Q?sfbOhvCrzqV5bsjbSeml63n/PoRUV1knUfBzS+nz/JcBuzxJoW2O4wAS2s9D?=
 =?us-ascii?Q?37807mfgId4FgCldTVMHQ74=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bc486b2e-0c4b-42c7-dbe7-08d9f0266e9e
X-MS-Exchange-CrossTenant-AuthSource: SL2PR06MB3082.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 01:56:50.7151
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zDKERJZpmV9cVwhCSBeq6+6IG4Ar72+JGr5GCs+hxdBhDvlX4ABHT2cnopQws+WWqunLrTbVc5vaE8NzrOjsrw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK0PR06MB2771

From: Wang Qing <wangqing@vivo.com>

Use the helper function time_is_{before,after}_jiffies() to improve
code readability.

Signed-off-by: Wang Qing <wangqing@vivo.com>
---
 drivers/md/dm-writecache.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/md/dm-writecache.c b/drivers/md/dm-writecache.c
index 5630b47..125bb5d
--- a/drivers/md/dm-writecache.c
+++ b/drivers/md/dm-writecache.c
@@ -16,6 +16,7 @@
 #include <linux/pfn_t.h>
 #include <linux/libnvdimm.h>
 #include <linux/delay.h>
+#include <linux/jiffies.h>
 #include "dm-io-tracker.h"
 
 #define DM_MSG_PREFIX "writecache"
@@ -1971,8 +1972,8 @@ static void writecache_writeback(struct work_struct *work)
 	while (!list_empty(&wc->lru) &&
 	       (wc->writeback_all ||
 		wc->freelist_size + wc->writeback_size <= wc->freelist_low_watermark ||
-		(jiffies - container_of(wc->lru.prev, struct wc_entry, lru)->age >=
-		 wc->max_age - wc->max_age / MAX_AGE_DIV))) {
+		time_is_before_eq_jiffies(container_of(wc->lru.prev, struct wc_entry, lru)->age
+		  + wc->max_age - wc->max_age / MAX_AGE_DIV)) {
 
 		n_walked++;
 		if (unlikely(n_walked > WRITEBACK_LATENCY) &&
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Tue Feb 15 02:06:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 02:06:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272722.467677 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJnEL-0004Tj-7a; Tue, 15 Feb 2022 02:06:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272722.467677; Tue, 15 Feb 2022 02:06:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJnEL-0004Ta-1j; Tue, 15 Feb 2022 02:06:13 +0000
Received: by outflank-mailman (input) for mailman id 272722;
 Tue, 15 Feb 2022 02:06:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=A2Di=S6=vivo.com=wangqing@srs-se1.protection.inumbo.net>)
 id 1nJn5R-0006If-AK
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 01:57:01 +0000
Received: from APC01-SG2-obe.outbound.protection.outlook.com
 (mail-sgaapc01on2071e.outbound.protection.outlook.com
 [2a01:111:f400:feab::71e])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 901ddf92-8e02-11ec-b215-9bbe72dcb22c;
 Tue, 15 Feb 2022 02:57:00 +0100 (CET)
Received: from SL2PR06MB3082.apcprd06.prod.outlook.com (2603:1096:100:37::17)
 by HK0PR06MB2771.apcprd06.prod.outlook.com (2603:1096:203:58::9) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Tue, 15 Feb
 2022 01:56:41 +0000
Received: from SL2PR06MB3082.apcprd06.prod.outlook.com
 ([fe80::80b4:e787:47a9:41bb]) by SL2PR06MB3082.apcprd06.prod.outlook.com
 ([fe80::80b4:e787:47a9:41bb%4]) with mapi id 15.20.4975.019; Tue, 15 Feb 2022
 01:56:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 901ddf92-8e02-11ec-b215-9bbe72dcb22c
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=MxA1FYlZRTfHHcOF7CgxsgWWUo1k8b5FiN30TeKrsLsOWhIlaqO3Ti/dkmbLoLB7bAiPE0W9UZxVhAl+Jnsj2hd3n+thtMBCJqJyj+LPhr3FpAaasrfUsf6iIpUmBSM8sb3uIclxxUSRNlq4B9Z5VPYqHLN4kqXGhASZCCkxj7XjL1scOV3ii2McT6CxrllRndvOy9ZDBepS6vI7TktQcU9fITKSat57t7g5vRZbgVANrKUqA8L8yIKnqflRohi6LX2EY34zaazvfyaUgRR8Se+ys7ScRkiRr6heE99RBNAXf35IKJZgNYHaaSOpUK4/RFzWg9Ff3tF56oZ2cvWLpw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Gil4quij7qcTMvszTKjOs9aSAoYCJFZ2VUFmpkKPVQo=;
 b=LzmwAhHbFyr919Yuyc8qKzovA+u8YdMFxf62k6o651Ig/sGH7L3oOQa/oqGV7u4SynMzlO3C1dpbueBVB9JeKmBx1Ms/ye3AXyxuouVHM7BwlqBJ5SXGmoMbOjyWhVniomFaGHXjpHksIDReizbjmygyR7KJozAdJZYrEhIjTIrRGDG052P/A/zNt/eG393kLOqBXZESFhULOh+L8OSB4mFW+EE36JeKd2nZsFB9hH4ddTmuVyqHR3rrbmpzHyZWGmd8Gd9y9OEicDCIFegTHFMwJHbud0q3rf0qyW/8blspcr6nlNlXWYUR/u3u/vbIHQH5ZZ5sV9uW63/VENNaBA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo0.onmicrosoft.com;
 s=selector2-vivo0-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Gil4quij7qcTMvszTKjOs9aSAoYCJFZ2VUFmpkKPVQo=;
 b=n+wiVQk3Zy+KKpr19yc14kwIla5guhnQIjDr0SK8pmXIapT7m89WTmxGqeZb/OcOTiQbiF6i/R/rwRQ5oSQWWuSEwupVS5XZIKUaUzGSQlRcgoW/T89tsLSuXTPp0jUG4JAi5fd8x9dx9iZOtnx4nlXGDswtqKVTJk9jnV8M/nY=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=vivo.com;
From: Qing Wang <wangqing@vivo.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Jens Axboe <axboe@kernel.dk>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel@ffwll.ch>,
	Alex Deucher <alexander.deucher@amd.com>,
	=?UTF-8?q?Christian=20K=C3=B6nig?= <christian.koenig@amd.com>,
	"Pan, Xinhui" <Xinhui.Pan@amd.com>,
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Alasdair Kergon <agk@redhat.com>,
	Mike Snitzer <snitzer@redhat.com>,
	dm-devel@redhat.com,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Hans Verkuil <hverkuil@xs4all.nl>,
	xen-devel@lists.xenproject.org,
	linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-clk@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-input@vger.kernel.org,
	linux-media@vger.kernel.org
Cc: Wang Qing <wangqing@vivo.com>
Subject: [PATCH V3 6/13] input: serio: use time_is_before_jiffies() instead of open coding it
Date: Mon, 14 Feb 2022 17:55:43 -0800
Message-Id: <1644890154-64915-7-git-send-email-wangqing@vivo.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1644890154-64915-1-git-send-email-wangqing@vivo.com>
References: <1644890154-64915-1-git-send-email-wangqing@vivo.com>
Content-Type: text/plain
X-ClientProxiedBy: HK2PR06CA0012.apcprd06.prod.outlook.com
 (2603:1096:202:2e::24) To SL2PR06MB3082.apcprd06.prod.outlook.com
 (2603:1096:100:37::17)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 223ce6e0-9445-4c31-3457-08d9f02668ee
X-MS-TrafficTypeDiagnostic: HK0PR06MB2771:EE_
X-Microsoft-Antispam-PRVS:
	<HK0PR06MB2771C3D0F113D3DA4472A8D3BD349@HK0PR06MB2771.apcprd06.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1751;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	cDMxHup5yWOHw8mFcFUIaQfoxyQKud4jrkTMFg0CUJIXPvP58tsdTdGcIPk6yl2u0h3zsSGhDm59qTDw1/o+vkc5hLhThbG+y8cUIRSBF4zBFbj4JTj4r0Ryq8RTF6prBUlIBAsXDYTtcK5jq0oUUaPm1SJi8uVupnocTn33UXOvKQOcNF4kH31q1XkG2vl1qev+hzrXLR9VxrJ1KVh1rd4e53A/iuAR23UZU7V9qPI9XFaJ+8I/3Zeg7wG4S7HaBtJXjiIdoRnVbIMoMy51/WiMdEaMEmY7uD4/uza6Ea0bgj+01tm3mOEScGl8Qj4nEi2euZtMfeVr68/6pgY74Wngu4Vm4y/QrNGWYHZ8P8ZXklpGJF0hEYlZCdOObcyOGKGduZczot8wEs7b7100+D6I3eqzSwex303n/63KCjeGBo8d8PCPORcic8FZwyzuqi99yT2n1xmIhqxpsPIs5bQkY2792VFGr1AT+k2O5q4j8tuwROSGkQIEZEmMTqIDsLaglNeKbtpIMVI2AA9plEMwQURwJZs0INhcCkZxFja4Y5C+WmTFiW/ytBTVwCsUNLnk68k3lbn7SWYnVJH0UfiV1iq82wofwKcxaBfMJlUwycgzL8u01S7pBZlqKHK84uHHo7QLSauT8PZNX63zosBVkCBgWMZ5SUHjaeLSp/IYhJwkFLHHT+qyeuYMd07i2++Wi8wYtdMmNXcDSpmDOxinS+DDxJCgNXzlPYzTRho=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SL2PR06MB3082.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(8936002)(83380400001)(26005)(186003)(6486002)(508600001)(107886003)(5660300002)(2906002)(7416002)(7406005)(921005)(110136005)(316002)(66476007)(8676002)(36756003)(66946007)(4326008)(66556008)(6506007)(6512007)(52116002)(86362001)(2616005)(38100700002)(38350700002);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?/hNMObMNqtwdyZN+b6AB7PMwEkk/ZcXye09kWae6WhE+yHoUl9Og9KQwn+um?=
 =?us-ascii?Q?p69J/+02qfDjjMtfbZTJ+7qmPm4+sfTDBW5WszpyAdBt8tpcb+/Uilh8YLb1?=
 =?us-ascii?Q?ZfDGpFwdHwEuOLZMMHgcGZJZwYeseT8iqRidtMx+YJcw1nS1EQJv8MwJt82Y?=
 =?us-ascii?Q?nE/75Ib7WEdeOtZZn7R/7qiYlPm1oSx5xarIC9FphLxn7tFlwBURQfMMSIx0?=
 =?us-ascii?Q?L6S9EtQNkPa6nSs9Vid/eUrEO4uQFTai8yf4WCRXJNwZILUaVfQyxLJDwJ0r?=
 =?us-ascii?Q?+vWUuE2h79Bnl+ikhlQmeuDhJkQAWsBENQf0BQ/Tk41kUSe8hjSccMba5dvB?=
 =?us-ascii?Q?1/LkpNf3prN+1BhNe6cYvTvplggzF+TmwaN/8Oon/RD/s8ub7mNrFw+6GWJe?=
 =?us-ascii?Q?WaIWsbnVqaXgfTJQEfY8Qe0IVDAjVlGIKaJOJ4APCeMo65VlASSMLkxkSSpA?=
 =?us-ascii?Q?9I0B09poREZyCN13zM+AGYHU20po3ZLu/E2Tzm/CiI2iLbRoW/UtvlYExXa/?=
 =?us-ascii?Q?MGFdRNNm8as0FSAhp6QV7kzpXugurT5bXRr/kJC+zoXt14EEzL1JPWbtLZzW?=
 =?us-ascii?Q?ySOjdo2jFaJKbgnSiCbn9ymIy4IIsX3EFMqJ3qxvBPu94MdW8VKse7MMcmdz?=
 =?us-ascii?Q?+0WQ3PR/xFAprd6Rs8nYHX6kbQUBt8KvFhDn4S08X8+yC1sZ3gm//xkArc6D?=
 =?us-ascii?Q?aFQL5omXkj1dogbyz8AdqtZeIOz9yS/o0+EDbikm+jrBAVRyWZf6JS13Xj6M?=
 =?us-ascii?Q?xB2zwBdyyguCeimCO+detEuLS3ueLQJm4RusdxCttplqZcd9AYkkU7MSV0S4?=
 =?us-ascii?Q?cOupaSmB9wDwIgrY0U4GTbpIwIJXSqV/iVUMdAQdY0Tm9rGhyPRiM6NnuyXt?=
 =?us-ascii?Q?cJyXSflP8+eb3/oPEmVUzyVm0j2a0YyBLTodxUudr7wQpHLF38g+mMIiJtzz?=
 =?us-ascii?Q?DQO9gPfn0zM8f3HU+S8hhXBlql2p/vb2SaQ4l0N9YLnkTRTv48gPblxKRmy2?=
 =?us-ascii?Q?bjf3cOAsYmRRAZO6lwx5TpXT7Pjf8NY3aG4f/FfmZ9cM3Lj0s7AIvH1qhYfF?=
 =?us-ascii?Q?znSwef88plc5VWdwzuPGIoASNK/cA0zF58aBA5ORjsY8/jM84VnlVibQ4XAu?=
 =?us-ascii?Q?6WZKwyrQL4acUhcBhbUdhRAWWlfQIbSgRKxANboe9zhCVgQemb0jRnYlZv+i?=
 =?us-ascii?Q?5b3v8leeD/rUZVFDVsxk8j5e/n13FPYmrlRObxpaJEY0WroB9v7tS6Uhc/O4?=
 =?us-ascii?Q?vdSoJT9f+1rEQwYaoC0Q759b5yMtht1/BDjcO0B8j2l86QZNVlnrchlGyrxA?=
 =?us-ascii?Q?bxHk4NDGk+taU67w62VNRHeZKQkeyGgQCKXnQw3trcmhXLrcBAdZKiiLbdK4?=
 =?us-ascii?Q?o59tRU+2es5UaEe6y5qn53dnlOFv2HUM1Yc6//VKm1G1GJAA+bTsbkUDdYFS?=
 =?us-ascii?Q?PLgwUyE9/Rlnmk3Jplmyw1RyEjCDLdJmNSHuC2DQBLklc26boLSZ+QqV2VgS?=
 =?us-ascii?Q?1Y6EhFeXNAFCTllsecc2Hdq3oJ3tYjL4UOwgBeFLr5Nxg41mSs3/UOc2SuDV?=
 =?us-ascii?Q?X7mWIjKLMI8Ts+RIQ9ZMkZO07PbE/RWxPj1cBpRlgvEEyi1KuVrUWrr89j1+?=
 =?us-ascii?Q?BzOD0j2m0Nov7hSAX3g5+GM=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 223ce6e0-9445-4c31-3457-08d9f02668ee
X-MS-Exchange-CrossTenant-AuthSource: SL2PR06MB3082.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 01:56:41.3563
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tDMorbaPLABqnTTpOwm40CBkcz4dtMZpZlZYde5e3nsJXS1ZDx0+p2Hseebj67OCT6NIyc0pHCU7ReC2G7pQNA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK0PR06MB2771

From: Wang Qing <wangqing@vivo.com>

Use the helper function time_is_{before,after}_jiffies() to improve
code readability.

Signed-off-by: Wang Qing <wangqing@vivo.com>
---
 drivers/input/serio/ps2-gpio.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/input/serio/ps2-gpio.c b/drivers/input/serio/ps2-gpio.c
index 8970b49..7834296
--- a/drivers/input/serio/ps2-gpio.c
+++ b/drivers/input/serio/ps2-gpio.c
@@ -136,7 +136,7 @@ static irqreturn_t ps2_gpio_irq_rx(struct ps2_gpio_data *drvdata)
 	if (old_jiffies == 0)
 		old_jiffies = jiffies;
 
-	if ((jiffies - old_jiffies) > usecs_to_jiffies(100)) {
+	if (time_is_before_jiffies(old_jiffies + usecs_to_jiffies(100))) {
 		dev_err(drvdata->dev,
 			"RX: timeout, probably we missed an interrupt\n");
 		goto err;
@@ -237,7 +237,7 @@ static irqreturn_t ps2_gpio_irq_tx(struct ps2_gpio_data *drvdata)
 	if (old_jiffies == 0)
 		old_jiffies = jiffies;
 
-	if ((jiffies - old_jiffies) > usecs_to_jiffies(100)) {
+	if (time_is_before_jiffies(old_jiffies + usecs_to_jiffies(100))) {
 		dev_err(drvdata->dev,
 			"TX: timeout, probably we missed an interrupt\n");
 		goto err;
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Tue Feb 15 02:06:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 02:06:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272720.467666 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJnEJ-0004Cz-Nz; Tue, 15 Feb 2022 02:06:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272720.467666; Tue, 15 Feb 2022 02:06:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJnEJ-0004Cs-KS; Tue, 15 Feb 2022 02:06:11 +0000
Received: by outflank-mailman (input) for mailman id 272720;
 Tue, 15 Feb 2022 02:06:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=A2Di=S6=vivo.com=wangqing@srs-se1.protection.inumbo.net>)
 id 1nJn5V-0006If-81
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 01:57:05 +0000
Received: from APC01-SG2-obe.outbound.protection.outlook.com
 (mail-sgaapc01on2071e.outbound.protection.outlook.com
 [2a01:111:f400:feab::71e])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 917e2323-8e02-11ec-b215-9bbe72dcb22c;
 Tue, 15 Feb 2022 02:57:02 +0100 (CET)
Received: from SL2PR06MB3082.apcprd06.prod.outlook.com (2603:1096:100:37::17)
 by HK0PR06MB2771.apcprd06.prod.outlook.com (2603:1096:203:58::9) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Tue, 15 Feb
 2022 01:56:59 +0000
Received: from SL2PR06MB3082.apcprd06.prod.outlook.com
 ([fe80::80b4:e787:47a9:41bb]) by SL2PR06MB3082.apcprd06.prod.outlook.com
 ([fe80::80b4:e787:47a9:41bb%4]) with mapi id 15.20.4975.019; Tue, 15 Feb 2022
 01:56:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 917e2323-8e02-11ec-b215-9bbe72dcb22c
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=BVfjWBmQtKQJXl7TOSOAQCSssQSbdTSGuaZMsEfZwscG/ggHtlB/qkq2QUObB5Tdqfhu9jUrFSezPeLyr5CIH4ejzqjDdzoJ7IPFvHPm1RlJU+VjY0vApmRCjhOkMRsoASCIN5sHzpE13SoRCyC8hYPZ3vniHDw7NtRVv2Bq4+sfBYXfl4E8akiJkE8R9tQBUzgylVraeTURPoP1EAbkWU3GbkKLyTCYMhA+NhqMNzbc8YZ7LpdtMRrTyRJMmDW8z8deJCUa5NKJ0RSFTJZl0PJaQWU5vA3DjEV6x0KhT9GGXgaXa+yIcECg2143IGdbTZDjaMVEe/ma5T4Z3GcOiQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Gh/qI8QopXtn0x+RwYHfuUdkWJEd+DGxXAMqbqRKSsk=;
 b=ZJlB3hMmRH/H1LqXpnZjVVsc8ekv+ZClRMM+YYx8M0r6B4CeXN73RXZpEJ3m2aNobfLC2zF+66q363wqjZS+m40+wvnLROP0pYm5aI29VtVQ/GX6WbvRslJjBxTPP686z+EaVIKCLvdI6yaFwg4l+o1fW0tMIvrOTvKvUevNObT6xHV+/k5ea42OHgpmslKIItGDdWpDMzy2D9sDRpL70w6x8mK29L3NUIIqTyJ09HVHACppVzZ7nYEWkG3P2Hh6xfx4g4R7o+CZDiZIn44hk+Z7rq0e/d19yd+yaNU1HdKkSOX+JIgSDs16taZOaNLS2paLHFkucJijD+yYp3rYPw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo0.onmicrosoft.com;
 s=selector2-vivo0-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Gh/qI8QopXtn0x+RwYHfuUdkWJEd+DGxXAMqbqRKSsk=;
 b=LiA+yX7iNHLdsveP+SxrimHpe5Z+1AodD/9sOSKnvY7U1OBsmFCNsZiOPnixArG1P1o1nrqWrjFXi3PZhth9XxTm8Qku+0cCSHMyjSKQbXNQAmPNF9BbxePqOqsV1lYNFquZj7jSZ3w19mDqlDZJYnTfRbd3ztjGpJbBC48jzHc=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=vivo.com;
From: Qing Wang <wangqing@vivo.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Jens Axboe <axboe@kernel.dk>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel@ffwll.ch>,
	Alex Deucher <alexander.deucher@amd.com>,
	=?UTF-8?q?Christian=20K=C3=B6nig?= <christian.koenig@amd.com>,
	"Pan, Xinhui" <Xinhui.Pan@amd.com>,
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Alasdair Kergon <agk@redhat.com>,
	Mike Snitzer <snitzer@redhat.com>,
	dm-devel@redhat.com,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Hans Verkuil <hverkuil@xs4all.nl>,
	xen-devel@lists.xenproject.org,
	linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-clk@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-input@vger.kernel.org,
	linux-media@vger.kernel.org
Cc: Wang Qing <wangqing@vivo.com>
Subject: [PATCH V3 10/13] media: stv0299: use time_is_before_jiffies() instead of open coding it
Date: Mon, 14 Feb 2022 17:55:47 -0800
Message-Id: <1644890154-64915-11-git-send-email-wangqing@vivo.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1644890154-64915-1-git-send-email-wangqing@vivo.com>
References: <1644890154-64915-1-git-send-email-wangqing@vivo.com>
Content-Type: text/plain
X-ClientProxiedBy: HK2PR06CA0012.apcprd06.prod.outlook.com
 (2603:1096:202:2e::24) To SL2PR06MB3082.apcprd06.prod.outlook.com
 (2603:1096:100:37::17)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 34b35900-c3a8-4b8c-3d01-08d9f02673c5
X-MS-TrafficTypeDiagnostic: HK0PR06MB2771:EE_
X-Microsoft-Antispam-PRVS:
	<HK0PR06MB2771ECC9B5E197E44E6691A1BD349@HK0PR06MB2771.apcprd06.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:161;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Z/1ZKpi0U80UNY1LFIrHjKtGH7NFlMoGYEVe7u7lBBCiRn4454SvlfYCgUjw9ICl4Grrh/m8sk+Yvb/J18L2ZrsqbCrnmVyrt0wyzY3GX2FDBbycOy39yxJx4pDHii94IQp4nKMnFsxrKXSrWBvNJYCfbf8ZAxbcgqPusg48djQCQubUul5+/5qQnUPk3P44c7Oyv76uXRMhzWQcWSukl1pKe/udgcvghS7Ux5T5qrObwE6T4XkLbW0XwbE53UQrlf/96+REHPYdER0c/v7crnxhGubS7HwzV3bIia1djM3keDiv1gY4B7KFLsPERvH+vlAkyerspKTCf/Goc18u9bpcA38hBRA/E6pwLloxidpPSzpwjSWPVOlmuiTmETxZ6tg+QGNXIWJ/hdBDglS2TL/i2CKR0lSp88r966/7Ys0LZRhARrSQJDMN5D2ow0NSSz8fIxfZmIagRTJkZXeB09XBR9a5En9uyfJaWyMoRO4XSaaAG2B8XbNl71TaWfZCewz0w1KWssjzgLrxJi7qzzUUoSE4XsplLg3/uYSGTHcz0hwSbDw6Z8Xxo/M44l1h2+vA7KjItXld/jy6Kh0YeTAwAvwCvKQMV+z318Kisqp/iUZb46TdA3A0xtdt3clpdWvG2VpZv7QFAhsdXQApVRLihg4w9b+s/7+QUfmpOEyBy6KfyY5YMMSRBIOZouwOYctgLcok8PVdtfRhmsA/PH5dGz++Geze1+5WQDhSNto=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SL2PR06MB3082.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6666004)(8936002)(83380400001)(26005)(186003)(6486002)(508600001)(107886003)(5660300002)(2906002)(7416002)(7406005)(921005)(110136005)(316002)(66476007)(8676002)(36756003)(66946007)(4326008)(66556008)(6506007)(6512007)(52116002)(86362001)(2616005)(38100700002)(38350700002);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?JegvUsNVsaXfcZGlbG8Z7mFCnaU7BQ0BsQylFhFuPqaCXKuVghWUmQPSpxsm?=
 =?us-ascii?Q?CRMKukZ/tzUkTKR+dUozO3hMTTv/LuohDFWwWqvN9HR67qBmOAf7dcTzOTaS?=
 =?us-ascii?Q?OBLFRuQ2cgq7cWeP+rG+IyzSQzARrRq9VsgJmVkkHnA1pD/peagLLZSJbccz?=
 =?us-ascii?Q?xNpUn0PIZltTzqroWhcxDzUEi907QFlR0X05/ouP6QWrLsxKvqFcebqBg2yB?=
 =?us-ascii?Q?ACvaOIEdyD7SA3eh380RnwDYFICe+aGDIuTb9t66ct1JJ9AiLTKSAgr3docn?=
 =?us-ascii?Q?8UdsgrRnMgbl+m/gKQV+MAcPMrCaWql/GAqzw3Vy0yJ1qxVUeC0AT5Ee6K2Y?=
 =?us-ascii?Q?I7QaOR3pYZFSU/2Cj114eekfStRWwlqt1t+VxkEiOEdq7yyvLzfBRe4/oTXq?=
 =?us-ascii?Q?nJ5f9IvvSPuBSwb7bxYN3LJGfJg1KCPrhYZ0S1lWxFZJ+yVeBsXWb7wJ7Vx/?=
 =?us-ascii?Q?LmcWSjban4FlmShR57hVbt75C7/KqFS1nbM5/RjYsbHzrDr/GRZDxUMTgthb?=
 =?us-ascii?Q?7EGpYU7ykr58OYsBQH+ouiTUJQlWNa6YT452eIN13Ndc4S+krHAR013u5EgQ?=
 =?us-ascii?Q?eG63S4WXiMaRBCjwrrQS5iUH7rsYYQsuz/bdJARU4O5cGu2LAlsbJ0beju01?=
 =?us-ascii?Q?6ZcLgvM6dL/2kd9Y5KAG/iGQhJZtw7jx1Kdm9T3g61fzjAbqUGx6pF/yJOcx?=
 =?us-ascii?Q?psCLql7cyZddIAh/vpJgnI8VZHsvaKUsJlzLk+aOkNSjFlUKMp9layqtVv6j?=
 =?us-ascii?Q?q4hjaNr+HaCSe1uq0osa6TFtiSNcDfdwyhJwoXaPgohHYkIFSiB8OO/nfoGt?=
 =?us-ascii?Q?bX1vyOJj9q3VXXnJCCcwuhPMpI5MQkPR3sjci6vxgLIdTOhAZhuByV1bDM6v?=
 =?us-ascii?Q?kP8qzxvTthWrRL7UMbXx4zUv0zgg0F1vey1iZh08imuEvj1rpVgzAiuC7KXX?=
 =?us-ascii?Q?NTJOvlI2jQpzKa9t/42FIx6FDj3Eg2mlFZ7r/LCxd5PA98p465KlVzwmkgFF?=
 =?us-ascii?Q?6/6EYOAvMIJCxeC154EBsG3SrLUvOtcUNXRRsWNxAqqUJk0JdvnP3AW51fzE?=
 =?us-ascii?Q?O2xfumQKf+Tl0ruOsYWm0c4rtx0fW6+//PpWp7ku6mkIBPCysF/Pkzz3Wlqz?=
 =?us-ascii?Q?BHWjaUXiNSiXiXAtcWKZrkuyOf3QNPsUH9EXtIdRy9OPlaKELuVpnYUGg7J5?=
 =?us-ascii?Q?+fHY8T0KpHvdAaHOhosNcyhNkxMiXN7J6mOtKm1uWBkRWJ3EKmSJ0l7djgKf?=
 =?us-ascii?Q?IeEDbGBmBfy+irCmr6wPVCdxvKMN+aYomWsUm+fopiIpdRU/OQPPAqGty5nS?=
 =?us-ascii?Q?VyJ4vytvKLA0euM8aVgV2W9v5R48PIK+L7nCagEo8Nitnzc2tYDG5Q7PgCjc?=
 =?us-ascii?Q?2nMKGasOVGgi6Ny3jQTSX+8qD9OBLW3ElCrKpru3KV5yJ1zikAaqmw8j9m3j?=
 =?us-ascii?Q?AMPwAItRX1dM9EEbk+5ksn/1OzqaxzjL9Jh0Dqeak0n0ghhQnSa29NhZf6Kt?=
 =?us-ascii?Q?6rlq4ATiqiHJYQlDB4g/nT8f331psS6xKiiLE6IUwyRvvUfHuJt0lHBE/o4K?=
 =?us-ascii?Q?e6gcuask47AEJ8Y219txFb4sNiIpTQCy75vf573mpTyIjCBYup089lC/EKH7?=
 =?us-ascii?Q?rw3ewQFdDfehBjZc3myYxRI=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 34b35900-c3a8-4b8c-3d01-08d9f02673c5
X-MS-Exchange-CrossTenant-AuthSource: SL2PR06MB3082.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 01:56:59.3865
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6JrLm+M6mSEBLFYeLGu3LqaQ+wmgbyZRt1lWiKI+vI4p/tuj4r8sAEpelBecCUckxJ7lzICMVuprAbVV8Nj7Jw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK0PR06MB2771

From: Wang Qing <wangqing@vivo.com>

Use the helper function time_is_{before,after}_jiffies() to improve
code readability.

Signed-off-by: Wang Qing <wangqing@vivo.com>
---
 drivers/media/dvb-frontends/stv0299.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/media/dvb-frontends/stv0299.c b/drivers/media/dvb-frontends/stv0299.c
index 421395e..867ae04
--- a/drivers/media/dvb-frontends/stv0299.c
+++ b/drivers/media/dvb-frontends/stv0299.c
@@ -183,7 +183,7 @@ static int stv0299_wait_diseqc_fifo (struct stv0299_state* state, int timeout)
 	dprintk ("%s\n", __func__);
 
 	while (stv0299_readreg(state, 0x0a) & 1) {
-		if (jiffies - start > timeout) {
+		if (time_is_before_jiffies(start + timeout)) {
 			dprintk ("%s: timeout!!\n", __func__);
 			return -ETIMEDOUT;
 		}
@@ -200,7 +200,7 @@ static int stv0299_wait_diseqc_idle (struct stv0299_state* state, int timeout)
 	dprintk ("%s\n", __func__);
 
 	while ((stv0299_readreg(state, 0x0a) & 3) != 2 ) {
-		if (jiffies - start > timeout) {
+		if (time_is_before_jiffies(start + timeout)) {
 			dprintk ("%s: timeout!!\n", __func__);
 			return -ETIMEDOUT;
 		}
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Tue Feb 15 02:06:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 02:06:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272729.467688 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJnEW-000523-Ii; Tue, 15 Feb 2022 02:06:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272729.467688; Tue, 15 Feb 2022 02:06:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJnEW-00051o-D2; Tue, 15 Feb 2022 02:06:24 +0000
Received: by outflank-mailman (input) for mailman id 272729;
 Tue, 15 Feb 2022 02:06:23 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=A2Di=S6=vivo.com=wangqing@srs-se1.protection.inumbo.net>)
 id 1nJn5U-0006If-7k
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 01:57:04 +0000
Received: from APC01-SG2-obe.outbound.protection.outlook.com
 (mail-sgaapc01on2071e.outbound.protection.outlook.com
 [2a01:111:f400:feab::71e])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 91099821-8e02-11ec-b215-9bbe72dcb22c;
 Tue, 15 Feb 2022 02:57:01 +0100 (CET)
Received: from SL2PR06MB3082.apcprd06.prod.outlook.com (2603:1096:100:37::17)
 by HK0PR06MB2771.apcprd06.prod.outlook.com (2603:1096:203:58::9) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Tue, 15 Feb
 2022 01:56:57 +0000
Received: from SL2PR06MB3082.apcprd06.prod.outlook.com
 ([fe80::80b4:e787:47a9:41bb]) by SL2PR06MB3082.apcprd06.prod.outlook.com
 ([fe80::80b4:e787:47a9:41bb%4]) with mapi id 15.20.4975.019; Tue, 15 Feb 2022
 01:56:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 91099821-8e02-11ec-b215-9bbe72dcb22c
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=LUoDun5NGiSjISY5ivuzLbm1D8sOs5FrFwgK/p4e/DGTha5s5ocViPpjXVm2CEUxvnClstfGYYc2fyZywt+6Quuu64sJYJwx3Ln0tQxLjoBJkpbeLJThRenVjq9xXrSq4KRi65Jw2c4y9LCEbOspEam9u7oPhD29GzBkvBvv5oV5DuFlwFrnUxi8F1D6jMJiK4CN1DdF04nGCtCwrQ7QsR20azykkxkhq8AjG35eL+4ywnPCg239BhR7931qPpH5VLyu0mcP1RHD2nhMt9mGW4pbWyHXd3t9msi4DqawyZCZrlVkR2g+7Ozt/l0ev1KtF+JB+ZWnlQNucicATXHKcA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=kGZeuYGXyeAgcClI3wwE48MNOwGa8NGTXiURAfe/zbQ=;
 b=CE8ljgke7KO+nqn/dQu5NmRVl7EFnnOpcR7/4yo929YshXt12HRWiZG+NX5wW1+t1VQvDvqFwKnTKngkd5Y3Lxdcgw/uchZs5Qv0b+K0AZu+e53vlgBusb8BeYoSolkZ98pASlt7PgRYhQglnfKxg7ZwRAV6A3aSvEU1hCweYHTaBhVDU57PNzBDXemM1Et1Bs+CDwlnZKvFiygsy3Iz6HjhBZCWjHszmybasEFTfp2UivGVoY45Jt+1xm7v8FKMw+iTyjXD8uGVgbcgPSskrKcdk+Gb4dTyP3qzgMUaNsy33XPDiznjKEF8qYhVVeefkX0c4UDhAM/gfqDCRtxbCw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo0.onmicrosoft.com;
 s=selector2-vivo0-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=kGZeuYGXyeAgcClI3wwE48MNOwGa8NGTXiURAfe/zbQ=;
 b=iANhwTSzcDZNQAh46sy8MA5t0Tm7sOrPbpiotfOcNFxSh/5wKaN/BuHbPbneRlKd4PT4Gbudt2P4bW2Z+Ra4Ixd6QUJLTHrOCZPQgsikRrZyo/1rqahCcnVOIvKb2A9pZNlepDaZdOHVDZlBxoN4+lF762dDm4Kr+cqlv4oQFVY=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=vivo.com;
From: Qing Wang <wangqing@vivo.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Jens Axboe <axboe@kernel.dk>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel@ffwll.ch>,
	Alex Deucher <alexander.deucher@amd.com>,
	=?UTF-8?q?Christian=20K=C3=B6nig?= <christian.koenig@amd.com>,
	"Pan, Xinhui" <Xinhui.Pan@amd.com>,
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Alasdair Kergon <agk@redhat.com>,
	Mike Snitzer <snitzer@redhat.com>,
	dm-devel@redhat.com,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Hans Verkuil <hverkuil@xs4all.nl>,
	xen-devel@lists.xenproject.org,
	linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-clk@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-input@vger.kernel.org,
	linux-media@vger.kernel.org
Cc: Wang Qing <wangqing@vivo.com>
Subject: [PATCH V3 9/13] media: si21xx: use time_is_before_jiffies() instead of open coding it
Date: Mon, 14 Feb 2022 17:55:46 -0800
Message-Id: <1644890154-64915-10-git-send-email-wangqing@vivo.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1644890154-64915-1-git-send-email-wangqing@vivo.com>
References: <1644890154-64915-1-git-send-email-wangqing@vivo.com>
Content-Type: text/plain
X-ClientProxiedBy: HK2PR06CA0012.apcprd06.prod.outlook.com
 (2603:1096:202:2e::24) To SL2PR06MB3082.apcprd06.prod.outlook.com
 (2603:1096:100:37::17)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 0eca22f0-7a4d-40e8-7914-08d9f026712e
X-MS-TrafficTypeDiagnostic: HK0PR06MB2771:EE_
X-Microsoft-Antispam-PRVS:
	<HK0PR06MB277188E6101087AF9235D086BD349@HK0PR06MB2771.apcprd06.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:161;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Zcr4PVFb8yBmpl3ocaDvIF+2MN9J/vXB/CtUB6IOeyqRFToL+6Sv+aHpZnulkJjDqw8mT4QFXz2MZMt7vlO6lHXcEmTgPHn9mR0fIIkozVUMaNaKsgCsrWlDjBt6pvZHIefPbwWFVRRJkc6LnkoyDC337SyEZTrP7bXKuIRY3CJ6obcoC/cHd/Uopx+nVj3hBbKZblY7J/7/0rNV9xJvXHezWiv4IX8ov+WjqLzVAfU7jQi4tjRXAaQ4t7YyQ81aOdePBvy+Pgn/pNIrPP/j2FB6sDwffbv6JjEIYUVDWVU7YL7pfoLwlm5Uwq5/fev9FkauDwN4F7vInplEthZlAMGTbhMbwHLdkdoqdI93rPB40eB60pGo8oI6rgtky92Co9cEt0cbPNbHo1fl4ivKSQmIdEWuEwCh4wDE3DSiZvVkQHcxBo7JcFo0v1LzY/xsTlgX7QZkIvYrUHXDDR0XN4wY68zGamgkeCFI0abyV5157K/wtIoqdCFvjtJx6a2fvH9puGR/jDzOpl9qzV6EbZY/WkxCe7xi9hfZNZizMAViGwUtSp1+z/6PA/+MOoKriv0b1K9aiZnEVS9YDsNZDidZO3ws0YJLrQxQ+7QtE0xmnQA8e8W5juxb88RAUHAaxTok9ZxLfxiYEnhaTEvPA1F2Vo4azT7EGHwWl5YX52Bxn4oD60zEC3ycTaqC+2/Mzy6GdTgMGt+hgHM/JiuQ9Y6juTsuM10f5oRJugatg+I=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SL2PR06MB3082.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6666004)(8936002)(83380400001)(26005)(186003)(6486002)(508600001)(107886003)(5660300002)(4744005)(2906002)(7416002)(7406005)(921005)(110136005)(316002)(66476007)(8676002)(36756003)(66946007)(4326008)(66556008)(6506007)(6512007)(52116002)(86362001)(2616005)(38100700002)(38350700002);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?kvvvXYfY3SAz0fQ9bdPKkWwlseYrmsnnNXiKA6wvTFgdPbGpEpATtSEhOssr?=
 =?us-ascii?Q?QlRASukWmlcLYqBRGOFNNNK4w/V+ngXI1xag6H8zRzDxQrPUrjZ9W6MnNg3q?=
 =?us-ascii?Q?pFbtJcXzspJsA2abO+qTZMQG9SIQW0qn8Ne0SD4UM0x4ciWf2bDZSFwbdfXh?=
 =?us-ascii?Q?cs2PTH+5miWioUgV/xyqs7Va1FhtjT7sCq3cjKOipQ08RJ6TbapWnsAAj5uE?=
 =?us-ascii?Q?2EILgNocOgNkv35E06TC8KMCPyTlALhakB65xvyMqnR14gZVJzbxNIG4/xRS?=
 =?us-ascii?Q?/zGEBY9t9C0lBRHliJTokvqbnXNa6SCePt3wzejdqotwYiNwXk+cTLluVXPl?=
 =?us-ascii?Q?OQr+4QI1bofV9PVUDcKe+6QLCPcvEi3L6oxhi7R6/aij6Wbz2nz/1hGmW5Mp?=
 =?us-ascii?Q?kOfk3BDjRmjvLpQUMAbX/dhXwcTmFTyAAWvvEjJTjhnY8IbXYUBymb+8no7f?=
 =?us-ascii?Q?JEJcv4RMScCJ6KDoy6IbO+DobeBeACuMVXQ3uDH1ugN0C76r3DtFfUfaCG7U?=
 =?us-ascii?Q?3ECBaxjx+3VNKEU62+7QK3EdpuQOX8xVM2YRf4A4tCa5QlZm0vEETiRN+aTM?=
 =?us-ascii?Q?Ssp6Hsyq99dcLxRo2VCewp1/29iGwgIpdLgI+Rlx/wlBj0byLtp8SQKf6pcg?=
 =?us-ascii?Q?2GIVADcrpKH4bP2miyD45/KFg4Own0OY/iGh9aPKp0XR2dXACaMcnhs3UoTD?=
 =?us-ascii?Q?CcRDW8SW2bfEpr6M1T04LSPUf5qIq0k6GMaaKZDiwq/U9Moyl0Y2Uq1Uk/Ei?=
 =?us-ascii?Q?GhLUImQMqvU4whOPH9rj+4D+ZCdCdxOjm0X6wsEhLhM/+J2nPDlr3NPp7bRV?=
 =?us-ascii?Q?2FcTbVjYmn15s7Bdn6GKP8ZhOCuQ9/BdGCsGtImuNuCrmnYeFvi20PNhXwmV?=
 =?us-ascii?Q?3nPQ/ArLuuFuSsY0AlMRmHrw5unISCLDGfOJecHNr3pBv3qyFr8Mx2SbH42d?=
 =?us-ascii?Q?eYfEiFjZpmp9FzOhh8HdTPy0US5tt4Y9HtDxjy2G1TK9N6sUgfdZ2q21bsoo?=
 =?us-ascii?Q?RKseRe/BukyoibNAP0jclUFoSmIarhuBnp1HIlVvM9JkJgsCmEV7ZXG/3E7v?=
 =?us-ascii?Q?QFzkPKoLQl+U+I5cWR1wJ2tN4cNoGxQIPGUE2srDyezmTx3XYlrtexurw4I0?=
 =?us-ascii?Q?yVE2ZL8JRpVqjRSa0qlARtkcrySi6QURVfSAPvJY4LpYng4OHsUH1P95gkDb?=
 =?us-ascii?Q?6/9uS4aZPGpgppkcSf7myWhFfbF/pHMXDp8Y/yTBWHhXfem09LowM6/ZP4kO?=
 =?us-ascii?Q?8JgRLFh9QPaoiM8eDMnaC9Ep5D/MEAIwx509TTWswmx+UUjQZD025Z5LMpuK?=
 =?us-ascii?Q?ksVCJGc+j4tBioHZJjt6cGWAF3M5WQn7bstF4eoGWO/8AvzKWQbavaFYCn19?=
 =?us-ascii?Q?le+LZWVf47LShfnlJcMUI7Eiow7kqEaC4kSb9A1zT4TQE6C+qH90Ol421q5I?=
 =?us-ascii?Q?Q3NLK7IQm3biXnc7UCJNPhOn72OYI1wFGJTw2Zg3rc66lQ87OTURCmAUKlRd?=
 =?us-ascii?Q?BKwzuH9yL3ux6fS7DyC5O3m5ynichBH7gd/GsGSi9v8mbYYHiX3DfzZMjGxl?=
 =?us-ascii?Q?FN3nTH+szzB7dkCduacK0SzjkGcNqxQ6/VK40kSSGXROCwAM5PxX/JSqx+L1?=
 =?us-ascii?Q?BIqCa9hQvYDnHEU6b9AXadA=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0eca22f0-7a4d-40e8-7914-08d9f026712e
X-MS-Exchange-CrossTenant-AuthSource: SL2PR06MB3082.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 01:56:55.0742
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qdL8lKhc7PkTAFDvkPlXyy4TydiXOxyB804HOKylwE/yyvZufo6UIyoDiyPNIrvNv8DSmBi8AE5pkUsS+m8X6g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK0PR06MB2771

From: Wang Qing <wangqing@vivo.com>

Use the helper function time_is_{before,after}_jiffies() to improve
code readability.

Signed-off-by: Wang Qing <wangqing@vivo.com>
---
 drivers/media/dvb-frontends/si21xx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/dvb-frontends/si21xx.c b/drivers/media/dvb-frontends/si21xx.c
index 001b235..1c6cf76
--- a/drivers/media/dvb-frontends/si21xx.c
+++ b/drivers/media/dvb-frontends/si21xx.c
@@ -336,7 +336,7 @@ static int si21xx_wait_diseqc_idle(struct si21xx_state *state, int timeout)
 	dprintk("%s\n", __func__);
 
 	while ((si21_readreg(state, LNB_CTRL_REG_1) & 0x8) == 8) {
-		if (jiffies - start > timeout) {
+		if (time_is_before_jiffies(start + timeout)) {
 			dprintk("%s: timeout!!\n", __func__);
 			return -ETIMEDOUT;
 		}
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Tue Feb 15 02:06:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 02:06:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272731.467699 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJnEY-0005OU-RK; Tue, 15 Feb 2022 02:06:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272731.467699; Tue, 15 Feb 2022 02:06:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJnEY-0005OK-N1; Tue, 15 Feb 2022 02:06:26 +0000
Received: by outflank-mailman (input) for mailman id 272731;
 Tue, 15 Feb 2022 02:06:25 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=A2Di=S6=vivo.com=wangqing@srs-se1.protection.inumbo.net>)
 id 1nJn5f-0006If-Kq
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 01:57:15 +0000
Received: from APC01-SG2-obe.outbound.protection.outlook.com
 (mail-sgaapc01on20728.outbound.protection.outlook.com
 [2a01:111:f400:feab::728])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 977e8dc5-8e02-11ec-b215-9bbe72dcb22c;
 Tue, 15 Feb 2022 02:57:14 +0100 (CET)
Received: from SL2PR06MB3082.apcprd06.prod.outlook.com (2603:1096:100:37::17)
 by HK0PR06MB2771.apcprd06.prod.outlook.com (2603:1096:203:58::9) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Tue, 15 Feb
 2022 01:57:08 +0000
Received: from SL2PR06MB3082.apcprd06.prod.outlook.com
 ([fe80::80b4:e787:47a9:41bb]) by SL2PR06MB3082.apcprd06.prod.outlook.com
 ([fe80::80b4:e787:47a9:41bb%4]) with mapi id 15.20.4975.019; Tue, 15 Feb 2022
 01:57:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 977e8dc5-8e02-11ec-b215-9bbe72dcb22c
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=dDQX/hEsHJxF5/lqLvlvQWVFnfxcVzalF2MOEQk9WAOky4Zy58o2P8w/HIYNSPnaZgQ0j6YAuR0hFOBULYXQg4jJEOh42EVAyECyaNxLG/XP3FTR+oouzW+v+KEA+j2d0ipmds/eu41YEvbg+xpysI3y3Z/R3hEocadj6eU3unR717lX6ExfGYvh0NYCvI5nEwEwJsVs2bXRBV5csw6vTaAUSPJ3pafoINzPgvTbKDDkbpdimk0WjjhzXK13+IYlqIEzff2ubnpFt2X5FIKFFxOVJAbi0QzVnKQj5FAq+KsbxgXeUxTisGoxFerNxq4IfslApDD9A2npyD1yG5jP2A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=USQtAH68lHNFd3aYmSwp/cn7GBKkIYnpqmGQauOL91M=;
 b=UvHJDA+jXMtoEsBh0+NRbfgfb4F+QUqdWZMt/8tG1HbdRc5ppCgOzwIZ9iDQI+eK9o1jn/VZhRR72c11usrzchFONpuYsxeWJFpS75rJCYvQ7JlFKYTkJutuiRwgd/CMl0U+Aj/oxXW7SQthZn6dFCU1MuydpzMQ1+FwixA1y0oG2s3G5nwEiUva+EHw/5yzFmyt6Oy2/wsgJ5fl7U4VnQOK68if5UhIiFPsC/FqtlO8CxaSicjO7tA0r5Dp5ffZgsomAHcTli2WwBFN0pdlJhBsnu/wKE8ydQ0NkFqBxY3nasB1GtsoNoSgXqW6HaBdcEppOGP3IN+/QMOyYgcVtw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo0.onmicrosoft.com;
 s=selector2-vivo0-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=USQtAH68lHNFd3aYmSwp/cn7GBKkIYnpqmGQauOL91M=;
 b=aD7znasnxuncrTApwoFimee0bVRQBhdOTCGj13m5201OThul4vY0qmJSew9JgNrjQPetc86yHlDs/v0Li9UsSqnMFG22JhvixYTUBGxVdiTVuNNJvTx6ER0Snysgyr2Owf5YoxyVz1XeVbotW0FF0iMPsOt7aB6nfSjf64OReL0=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=vivo.com;
From: Qing Wang <wangqing@vivo.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Jens Axboe <axboe@kernel.dk>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel@ffwll.ch>,
	Alex Deucher <alexander.deucher@amd.com>,
	=?UTF-8?q?Christian=20K=C3=B6nig?= <christian.koenig@amd.com>,
	"Pan, Xinhui" <Xinhui.Pan@amd.com>,
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Alasdair Kergon <agk@redhat.com>,
	Mike Snitzer <snitzer@redhat.com>,
	dm-devel@redhat.com,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Hans Verkuil <hverkuil@xs4all.nl>,
	xen-devel@lists.xenproject.org,
	linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-clk@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-input@vger.kernel.org,
	linux-media@vger.kernel.org
Cc: Wang Qing <wangqing@vivo.com>
Subject: [PATCH V3 12/13] media: wl128x: use time_is_before_jiffies() instead of open coding it
Date: Mon, 14 Feb 2022 17:55:49 -0800
Message-Id: <1644890154-64915-13-git-send-email-wangqing@vivo.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1644890154-64915-1-git-send-email-wangqing@vivo.com>
References: <1644890154-64915-1-git-send-email-wangqing@vivo.com>
Content-Type: text/plain
X-ClientProxiedBy: HK2PR06CA0012.apcprd06.prod.outlook.com
 (2603:1096:202:2e::24) To SL2PR06MB3082.apcprd06.prod.outlook.com
 (2603:1096:100:37::17)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 6296c2c9-2fb7-4819-0f42-08d9f026793f
X-MS-TrafficTypeDiagnostic: HK0PR06MB2771:EE_
X-Microsoft-Antispam-PRVS:
	<HK0PR06MB2771C677E22165241E79FC93BD349@HK0PR06MB2771.apcprd06.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2150;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	qSjKbwTeUefY/5XfnMzQWYZgsd45DfT8L6x6Klg3SnsN1cieMmLcMaWkL4xYkeLO7W0x3iSqkVTk5khQ2XrDoAAw8tIwQj1hQw+hbkc3oYFQ4tumhkZQd20Muyvh6xRWy71DAfkr+z9tRqzGPAX3rF5qXLAn88hJsTu4F8Bg+Qh03pBatNcKD8zWhWr9QwKenkblxg0RpG/uaAUmMQ11DFqY+kGPyqMtYOMukqt90XCYThQuO3Xlxp1diCO8QcJo48PgjQ7kikry7VEjKOY4/iCwju6LBew5PGHh94abvrpIUzzp+YFRF5oRp0RtMGbGgLfV7+UlQb8VfFcqVQTJia033kQXr05fh+CPxnR5gK94KnqKLTeGpsu7ufOt7PhhmsFk7FfarnTNcsCj/vAXINrDiYimDTJskKjYzRXfh33EDNBJytnv9HhHBRYqBbjtWFH2EPsovF3jQhBPDESxoyIgZeKryIw28JtKEn1Awzbh/URMnC8gRsTWtU+hoUP5o+l/J8pxs7PuNJr3SzJYbdSpOUkAP5m0PtnZCCk0OHzsBKRSODbvATPDmunC0Ifo4Sk54bRPDpnABrdVAb4nzBJK0Ixb8wKZ48KHS41d1KOhwfsmXz7tY+kkaRwmxL0F0IDUmC5RPAPHhSjkAv754GZSGxzHtnLNyYYw8aa7fl8GgJ+Cw62svRUVFvCxRlutSV6/WgbN4U8n88eE+glQ4vZ46yFh/3TRmid7v8lAlUo=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SL2PR06MB3082.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6666004)(8936002)(83380400001)(26005)(186003)(6486002)(508600001)(107886003)(5660300002)(2906002)(7416002)(7406005)(921005)(110136005)(316002)(66476007)(8676002)(36756003)(66946007)(4326008)(66556008)(6506007)(6512007)(52116002)(86362001)(2616005)(38100700002)(38350700002);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?fEdToDFzbgvbvN7qWxtjGGi+QazY9e97o1YF7YbhRPDsHggHUFqbf9v2tSy0?=
 =?us-ascii?Q?d2ZGrpigbm0f2NJZv8hrs3xIIpSq4defvWJ5m/jKqSluy1qRFLyf7WZTkxgK?=
 =?us-ascii?Q?1kpJZhJnVAUOJVC7cOdGF9BQMpwylJk30xJO/cotOM8z12sJo/6htGgZI1M7?=
 =?us-ascii?Q?KnoNAbBPqNEk+1m4aMhLXaSya/i7/2kmoBEGkNzTZS6S0Ym2eOBZ46y/VIgq?=
 =?us-ascii?Q?OZ6WH8Xeazc/ug7gipHmHIw0lIeYV9zTTkFvxH9vnsWcTynmBPHGYIBVEQLl?=
 =?us-ascii?Q?chPR+ez21rlfD0QIGSpc25+HUDb+4Rky2UiwNGKSf4y0uNtoH1IfZkYyHif5?=
 =?us-ascii?Q?NPOnTjBiCqRVloVgsnF/ZkgW7j/yuMq6miQCEYA0UBao568Egiyy/fXuc9ST?=
 =?us-ascii?Q?ntu4Y5NmqZNWysp2NOMtiHWhPEehR5lREWlPqauiZgMHQIbmEklbZ9IOIJE3?=
 =?us-ascii?Q?HRxcH6eeGLAfGs3kM/m1aSPfsGuz/AXgQboEJDiGHCOstX2n2arLJWEdZk47?=
 =?us-ascii?Q?gOnHXIbgdlrNtvBuT273N5GMnbqaaRXX0gc6U5AGxf8zJA0uN/5/8MWQHV8U?=
 =?us-ascii?Q?+1EHaF6ChDy0SLN9BHn6jYH/Q5Ot6TFZf2/6uq0U/yCPTKbXfsGpnRp2xud0?=
 =?us-ascii?Q?cpPWBuXs+xagybrMbZQlBAqa22pozi0oJvIrUuRHOsd8rLk2Zy9T5ttMSC/W?=
 =?us-ascii?Q?Rp0I7cgA4siVVzFd9nIOXR/tb/njBnQ2rzOdRXY5Aoy3dzKMOwBf6ujAMKFV?=
 =?us-ascii?Q?0tWb/sjiMR4uAi2bN0nNFbrc5lZbQ8bGCMdRsBFMKZwfHRYPOfGzbFlkKVNH?=
 =?us-ascii?Q?vkH0559fck0kRQQA2oQCOwnqyc8Y9T/ewAv/hiRyWaZO2lP1V0OmZhdUUPIi?=
 =?us-ascii?Q?/HAj6gT9WrA693LTWyVwjLanMYeh+bgmd0Drgi0TN4AZIQGq49skb0f+H0CD?=
 =?us-ascii?Q?1ugVpJJZY6si8TRkwuPXYNHmvZjZuhsKNyRJwROZvt3ud9qpA3bnBOyqOcYW?=
 =?us-ascii?Q?wPsABG5MyRt4I57cYHU1e9bfnPRtzuAvxlsaKuD1Y0kOSvnBdadn3Qsq3ILw?=
 =?us-ascii?Q?lCYZOGZJnb6jSo65CdWTJYpwWkP3B9ayXxd7f2DO1IQq7wxSHAw5vZoiAZb1?=
 =?us-ascii?Q?4fEwE76LG45UYaHqpzE4WRLqe2fvhZTMOrphwU+KfHetNBnkE6e+MQ3qB+Qz?=
 =?us-ascii?Q?293af7kMgOSEgXpViCWBwzmmJYm8m3OKjAzQ2M0HE2AhRaIV6oy8xqbSY2+a?=
 =?us-ascii?Q?0oKHPKZ2IBuRkelqeyOnG3OlGWOxmoXRp1ojFTcLt3h+emJbIrH9Q19pl/qu?=
 =?us-ascii?Q?ymHx/B+sp3By1upwlc9MNyBIvXKA0qjk7a502R6ECmjbIYZ6us9G/PQU2YLb?=
 =?us-ascii?Q?mTDgMdHNEUqHoOUzIvn0JZZZN0SSIxhAvSlkT8v8tjlKNccNa6aRohJcLcuY?=
 =?us-ascii?Q?aumtCEyaQczqIH49OyUXAJAT55x+uxs93P1DNwvHkbkJlxdnPzVC4gKMJA4y?=
 =?us-ascii?Q?xCSNkacsN0noFqG9IlNI+4r2irT5eoICIQjMNyG5gIzNBNCurke5DNW9gtbG?=
 =?us-ascii?Q?nDlx7B/sSQVeii6pRBkbjgOEm6YnyedmWaIVRw/C/kAZWr1wpBpBkIxAg1KR?=
 =?us-ascii?Q?mK45CnaeHOrIaYoivIWnXNY=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6296c2c9-2fb7-4819-0f42-08d9f026793f
X-MS-Exchange-CrossTenant-AuthSource: SL2PR06MB3082.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 01:57:08.5734
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SZUQJ3DpGBlABktVULOZhxTm+OFwKEbGKvDe4gjCg8LI6oJ6aIWEVBqVVBcDqxwPhShvhFs7+tS0SH5zdQOGTw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK0PR06MB2771

From: Wang Qing <wangqing@vivo.com>

Use the helper function time_is_{before,after}_jiffies() to improve
code readability.

Signed-off-by: Wang Qing <wangqing@vivo.com>
---
 drivers/media/radio/wl128x/fmdrv_common.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/media/radio/wl128x/fmdrv_common.c b/drivers/media/radio/wl128x/fmdrv_common.c
index 6142484d..a599d08
--- a/drivers/media/radio/wl128x/fmdrv_common.c
+++ b/drivers/media/radio/wl128x/fmdrv_common.c
@@ -23,6 +23,7 @@
 #include <linux/firmware.h>
 #include <linux/module.h>
 #include <linux/nospec.h>
+#include <linux/jiffies.h>
 
 #include "fmdrv.h"
 #include "fmdrv_v4l2.h"
@@ -342,7 +343,7 @@ static void send_tasklet(struct tasklet_struct *t)
 		return;
 
 	/* Check, is there any timeout happened to last transmitted packet */
-	if ((jiffies - fmdev->last_tx_jiffies) > FM_DRV_TX_TIMEOUT) {
+	if (time_is_before_jiffies(fmdev->last_tx_jiffies + FM_DRV_TX_TIMEOUT)) {
 		fmerr("TX timeout occurred\n");
 		atomic_set(&fmdev->tx_cnt, 1);
 	}
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Tue Feb 15 02:06:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 02:06:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272742.467710 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJnEe-0005yb-8t; Tue, 15 Feb 2022 02:06:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272742.467710; Tue, 15 Feb 2022 02:06:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJnEe-0005yM-5N; Tue, 15 Feb 2022 02:06:32 +0000
Received: by outflank-mailman (input) for mailman id 272742;
 Tue, 15 Feb 2022 02:06:30 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=A2Di=S6=vivo.com=wangqing@srs-se1.protection.inumbo.net>)
 id 1nJn5Z-0006If-Cr
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 01:57:09 +0000
Received: from APC01-SG2-obe.outbound.protection.outlook.com
 (mail-sgaapc01on2070a.outbound.protection.outlook.com
 [2a01:111:f400:feab::70a])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 94551c06-8e02-11ec-b215-9bbe72dcb22c;
 Tue, 15 Feb 2022 02:57:08 +0100 (CET)
Received: from SL2PR06MB3082.apcprd06.prod.outlook.com (2603:1096:100:37::17)
 by HK0PR06MB2771.apcprd06.prod.outlook.com (2603:1096:203:58::9) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Tue, 15 Feb
 2022 01:57:03 +0000
Received: from SL2PR06MB3082.apcprd06.prod.outlook.com
 ([fe80::80b4:e787:47a9:41bb]) by SL2PR06MB3082.apcprd06.prod.outlook.com
 ([fe80::80b4:e787:47a9:41bb%4]) with mapi id 15.20.4975.019; Tue, 15 Feb 2022
 01:57:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 94551c06-8e02-11ec-b215-9bbe72dcb22c
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=RqMzXTCvREqgvmRJE8BFHSMTClFr/mMKiTA396izTqlCirA3knCZgR0LSvqz4ncx5esm0uyXM9goC0lDhU3QNWhxAFFnFoAcEP/W97rOwMVrF8tINIqu9VMi4g4/laPYb2UQWSktkH89VA4IyTP2iHaafyKUWnG7kiqUL46A/XRnJurfd0YLDuE3XPksDFbOzdaoi18ip5tKIrTKWM8bZ7X9tXaatKWOQbbDRMO5nhkodi+9lk4NAr5UvXDtFqFxC0eiABDkcGSDiNS5bpM9letHPZ3ML9hr5Nmal3s8KWrlF5izgztSZaPcSKAUsje5tYooXuwD531itaHqjABoSA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=cC6buop/OtXmLD1AULbZQIagQssITz/oNl9j3S0vE4I=;
 b=gWkBJc+pPWhDXM2BOpIMcljgkFKg6NqhNx2IT35NIHdKKqdYinssJ5UsQRMgLBNDuZgiuhUS0COceGSABKHH+njvy1tbnUtoxb95zqQC5tcVJ3otZ30cm+9OZmpCwWXbBCDfGMM3tW3cypjWGErBYwgUgVs+iN2JPtrQcFPcXDPULgfEYnAuVZBPOcQ6GT+2N94m9CntYE4C0UKJWYX4xi/bB5im+auD2iLvusqYK/iEcNBsI6ZFZfvoj7VtfU/YmUxkmxRoy7A1t+GF7oG0Cs7FocM7Lx6Sr3QtGkl//PjBbDrZDCPX6cl1U5idlTqX+fFpnKx4A9qy/mqxTRvw2g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo0.onmicrosoft.com;
 s=selector2-vivo0-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=cC6buop/OtXmLD1AULbZQIagQssITz/oNl9j3S0vE4I=;
 b=CBZ9XKmimrLI5a5Bm4sVwboiickFbQ8A3dOB0fQPU3JPtPOG/Cm7ArTeJb7uJwf1Tsc/2rfkJ2IdIiCN8bwtuptnEogLe+9bzPoJ8IX2G/UnHhH2zZRGvGUA1VoO5C7wEAuFi65clE7+pDTOBPZVxq4ZDe05Ag2Ib3DHtVZ0hc4=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=vivo.com;
From: Qing Wang <wangqing@vivo.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Jens Axboe <axboe@kernel.dk>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel@ffwll.ch>,
	Alex Deucher <alexander.deucher@amd.com>,
	=?UTF-8?q?Christian=20K=C3=B6nig?= <christian.koenig@amd.com>,
	"Pan, Xinhui" <Xinhui.Pan@amd.com>,
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Alasdair Kergon <agk@redhat.com>,
	Mike Snitzer <snitzer@redhat.com>,
	dm-devel@redhat.com,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Hans Verkuil <hverkuil@xs4all.nl>,
	xen-devel@lists.xenproject.org,
	linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-clk@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-input@vger.kernel.org,
	linux-media@vger.kernel.org
Cc: Wang Qing <wangqing@vivo.com>
Subject: [PATCH V3 11/13] media: tda8083: use time_is_after_jiffies() instead of open coding it
Date: Mon, 14 Feb 2022 17:55:48 -0800
Message-Id: <1644890154-64915-12-git-send-email-wangqing@vivo.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1644890154-64915-1-git-send-email-wangqing@vivo.com>
References: <1644890154-64915-1-git-send-email-wangqing@vivo.com>
Content-Type: text/plain
X-ClientProxiedBy: HK2PR06CA0012.apcprd06.prod.outlook.com
 (2603:1096:202:2e::24) To SL2PR06MB3082.apcprd06.prod.outlook.com
 (2603:1096:100:37::17)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 94ca7f55-53b8-4f22-77cf-08d9f0267652
X-MS-TrafficTypeDiagnostic: HK0PR06MB2771:EE_
X-Microsoft-Antispam-PRVS:
	<HK0PR06MB27712D4B9B1228657612CF57BD349@HK0PR06MB2771.apcprd06.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:849;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	gV2oF/OyYcAeAm3Z/ywQFp3c16XzzbH9iWeVLunxe43SBoP/9cDeHIVvXGFrbl5hyT9qw6wb9GTJ6p5LeyeWYmqPnQ+zLWuflUnNBv/4424U5jg8T2xxqcp3mrhNcxfd5rSpzqaY5Rwscvfb7eRHwch0DpK4wozaZKYqm1tfbD1/cTBHKDs8NZc/gzC7jnJi5YZxQm7mKEt5RAJ2M10E3RvuIyL6lSM3Bwi63xsUUDEngg/cGCX1112Lwk7k5Vk+2lKkOvaciLuNfaJ57e7k+cODf4I5nNvNxiTmdkYhJdLAysmjrFWn4x+O8FBAROaqqp8fqBUejYXCCBnptKwCGAcZR388X3FAsnFHHe/cw2KEIpXslrwP8qh8CuZpTLHgUlciy34lsTQi2m0TnDsMk0jK2KIJBnQg3kDfSxCREokOLWlxOdIXiVAvutyCDogNTbIwdGt446x1kbCGnTcrogKXrfQViqpN5Ief7SdhqhqZBdhfbYbBYYSnTwxkxtJjclRfbzitHpDb0C2X0LDRAdj3A4txuQsihLT+6GNsoGo7MRWPYWL2HjeaBlvNZyEJZTs2hLtAk/eidy5JhCNzkY6bRXc9mncdXZvsEHGDveox7yFQsA6kYpufdfd+XjY4h1P4lnFV5NMwyheCnCR7MU0SpXaXedHQ/3mOCz1lAPLxWCJe3eemodj6x2LfWgBVE83pigXnP9rl7jw4RDj09gdbIliXFMdn78bn4cSQGQI=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SL2PR06MB3082.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6666004)(8936002)(83380400001)(26005)(186003)(6486002)(508600001)(107886003)(5660300002)(4744005)(2906002)(7416002)(7406005)(921005)(110136005)(316002)(66476007)(8676002)(36756003)(66946007)(4326008)(66556008)(6506007)(6512007)(52116002)(86362001)(2616005)(38100700002)(38350700002);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?5MercmGQ9TFzLOeFladCcko3hYvfU5SNs9NOw2+9D7L7k6I0GqVFlOmmJrgq?=
 =?us-ascii?Q?OeLdEejvjAOM9iQNatT/3Ul4EuLFDAPSGEGNRCMPPrbEl4ZtSEEoHvJbGX5d?=
 =?us-ascii?Q?4dTVyLK8fWRpfESUPAtM58keC90j3x+tJ2ovvZIiKR5QcrYiY29J7XsB5V8E?=
 =?us-ascii?Q?ZYyWDoR6BSamZKMmp74V6WqjUm89eqmJN/MT8fqzl0VEay4ItxpbpKUYVgbB?=
 =?us-ascii?Q?2VaNG71bB7BXNzAYY0BhbOCLRcveSC/amCp6DN1Gbs+UQMFhkIpAXWMlLbgP?=
 =?us-ascii?Q?Nk9tgcELRWyuDHqkgy9+H87IqJEHslRUN2X+ykP5NCXvdiicVpNc0g1WzKr1?=
 =?us-ascii?Q?wb7aQa0wTxlgA7XXtLnUzXC/cvi5QObIx2NN81Lh4076pRBm27AQ36bCVJiV?=
 =?us-ascii?Q?EibGe3I+zx6XShezN9vLMRRmOo2XkI3MyNNEFaCQXsKI52aMDLDrttscU3W5?=
 =?us-ascii?Q?p3pquY0GGWfsV06wkhjI9vDvg/nvoQrwoOzmO5XwcUTdsYt/3E20HX58CZzz?=
 =?us-ascii?Q?rWuwk1uEEr5CXT9S5ZM/O8C8N5EQaHYbZM1IXB86S/bBsDYYXNZr0oiUrZAQ?=
 =?us-ascii?Q?5bebvLKa9VJZf1N4UwRQxuJjq5MPuFrmTrzLNEtJ8COwCAzQ93RearXg9xIg?=
 =?us-ascii?Q?j+Ksnmj3xxmMUHmyHg61nmPV7gKHTV+nHhDL+3Ge+BHgJZMUg8FURTmo6npM?=
 =?us-ascii?Q?6VOHlgLBAF2XX1bWMzYV4XUsPjduRipv2yauRp8ApM/4M17R4/YWTQCbs533?=
 =?us-ascii?Q?6caxhl3xrflEJOa1dDdmMIPjvbOuDSrG2DT5rHM9NoTFwsHOJKa4TQVTFtpj?=
 =?us-ascii?Q?nwqNZR3GomhjHPAMmZpj1gGjPUBwCTpuxnd8oeCQt+mhv3FEhsNQWfIPN8IU?=
 =?us-ascii?Q?FWYFIrMyd9FhJJ+c52wEBfgsoOT/HQH9txgCtUP/T4baq2+70aKIsGDyq2+9?=
 =?us-ascii?Q?TfjP/8yrkQAEVeBRoKBHJPIAxDlpeC/B6x6v1g0AMqqZrnxFDPGMNkHYhwMc?=
 =?us-ascii?Q?XeNCxwg4xaC0p3D5nwY8NxydR4y6kXO0EagMa8nVy4q2GYx+R/GzaKPmjaA7?=
 =?us-ascii?Q?xd7I1lSBfjWrizETDcezgnUZT55SgJ+ZSmBtmU50cjPtGaaDmZCfSpj9GFmW?=
 =?us-ascii?Q?ypBWARMZI2UK5YsR7rB6TA72Pu0ubN1pllG1W6A0dGIdCowHCfGiEDvTda2I?=
 =?us-ascii?Q?1WFBQ2eSLYPAvYIuQfV2cnb4ku6eSk2aKAOoXkfHjr88hr7V6Tvuzla1adIv?=
 =?us-ascii?Q?J46sXCKnmkHbKiRx4x14JcR/684RrDlQwWJeq1M9H6hBEOnKVyaFWmV/51fX?=
 =?us-ascii?Q?OZYD4yognVtd+e4sqC2zDpeEioWawPl2tmkIL5uWsTBovrH7tcKzBks8R48M?=
 =?us-ascii?Q?DLgqOBJcZyHCUEI+1LWR7tIOeI5OmmZBTJwVxZqeSZAB+tYnoE43YwlcTLiM?=
 =?us-ascii?Q?R7TDbKvO7nZGR/aj5Ejyx/8DwDADM26HxVjaFK9Wgfq426C9nVyLStuq5H4c?=
 =?us-ascii?Q?+fKQf0vzM9+tFxvxV+f4e7CDzWq5E/7qBCFRAZ7M2UPOC1BMH8mZ4s0rHAzw?=
 =?us-ascii?Q?gWw4undedslAcO+oTr172k07AGApDuAhaJO03dt4Ha8Je/C8zSuCZFWJvLw6?=
 =?us-ascii?Q?R1okkSX3eJUUoB7jqtLR7B4=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 94ca7f55-53b8-4f22-77cf-08d9f0267652
X-MS-Exchange-CrossTenant-AuthSource: SL2PR06MB3082.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 01:57:03.6675
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mFEuzil0urqptxkdME+hbidqRFKNvjpaAGKOrzHhgbeiM5Ro7os/lGC86t2nJ/h1Bal4xr+JCTkBo3sNx60XYg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK0PR06MB2771

From: Wang Qing <wangqing@vivo.com>

Use the helper function time_is_{before,after}_jiffies() to improve
code readability.

Signed-off-by: Wang Qing <wangqing@vivo.com>
---
 drivers/media/dvb-frontends/tda8083.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/dvb-frontends/tda8083.c b/drivers/media/dvb-frontends/tda8083.c
index 5be11fd..49c4fe1
--- a/drivers/media/dvb-frontends/tda8083.c
+++ b/drivers/media/dvb-frontends/tda8083.c
@@ -162,7 +162,7 @@ static void tda8083_wait_diseqc_fifo (struct tda8083_state* state, int timeout)
 {
 	unsigned long start = jiffies;
 
-	while (jiffies - start < timeout &&
+	while (time_is_after_jiffies(start + timeout) &&
 	       !(tda8083_readreg(state, 0x02) & 0x80))
 	{
 		msleep(50);
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Tue Feb 15 05:08:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 05:08:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272775.467721 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJq4A-0007HR-Py; Tue, 15 Feb 2022 05:07:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272775.467721; Tue, 15 Feb 2022 05:07:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJq4A-0007HK-Mq; Tue, 15 Feb 2022 05:07:54 +0000
Received: by outflank-mailman (input) for mailman id 272775;
 Tue, 15 Feb 2022 05:07:53 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJq48-0007HA-Vv; Tue, 15 Feb 2022 05:07:52 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJq48-0000Vm-Ro; Tue, 15 Feb 2022 05:07:52 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJq48-0000hj-91; Tue, 15 Feb 2022 05:07:52 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nJq48-0008Kg-6N; Tue, 15 Feb 2022 05:07:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=w29D+kSSBXvZ704fTfHeWmcyfzX7e6pdRKJHh1rZ1O8=; b=aA4f9FTy2QU4pToKTu3e219VeW
	H+GsxVEpEziqtCFcRbV3cq7SZVPdDcstd3iwylLbjhZcIJIBO3Yq7i+a/Jbe4G1IfPorB0ASRJRBY
	IomZgYvRmCP88qR4wKWqNUm/rt0VMwekg99x2mntupZEgiQRx8o6p7A5/x9VSwxwnKoM=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168111-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 168111: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:windows-install:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=94334d854bd358bd1d9c61d5e3306e4d903b120b
X-Osstest-Versions-That:
    xen=87319afb96973213ec0a76270d93696f3b8d6743
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 15 Feb 2022 05:07:52 +0000

flight 168111 xen-unstable real [real]
flight 168116 xen-unstable real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/168111/
http://logs.test-lab.xenproject.org/osstest/logs/168116/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-qemuu-win7-amd64 12 windows-install fail pass in 168116-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop  fail in 168116 like 168105
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168105
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168105
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168105
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168105
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168105
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168105
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168105
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168105
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168105
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168105
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168105
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  94334d854bd358bd1d9c61d5e3306e4d903b120b
baseline version:
 xen                  87319afb96973213ec0a76270d93696f3b8d6743

Last test of basis   168105  2022-02-14 01:51:55 Z    1 days
Testing same since   168111  2022-02-14 13:40:16 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Jan Beulich <jbeulich@suse.com>
  Norbert Manthey <nmanthey@amazon.de>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   87319afb96..94334d854b  94334d854bd358bd1d9c61d5e3306e4d903b120b -> master


From xen-devel-bounces@lists.xenproject.org Tue Feb 15 07:10:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 07:10:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272796.467760 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJryI-0002Dl-PH; Tue, 15 Feb 2022 07:09:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272796.467760; Tue, 15 Feb 2022 07:09:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJryI-0002De-MB; Tue, 15 Feb 2022 07:09:58 +0000
Received: by outflank-mailman (input) for mailman id 272796;
 Tue, 15 Feb 2022 07:09:57 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=p95L=S6=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nJryG-0002DW-Ra
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 07:09:57 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 46b792d6-8e2e-11ec-b215-9bbe72dcb22c;
 Tue, 15 Feb 2022 08:09:55 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2176.outbound.protection.outlook.com [104.47.17.176]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-41-m1OuiyIQMZyZcsIbUQGhlw-2; Tue, 15 Feb 2022 08:09:53 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB3230.eurprd04.prod.outlook.com (2603:10a6:802:6::27) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.19; Tue, 15 Feb
 2022 07:09:49 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4975.015; Tue, 15 Feb 2022
 07:09:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 46b792d6-8e2e-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644908994;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=8kKIihStcUVH+xcWxHahG+1jFaWxyJVKgfrL8wEgptw=;
	b=kJw0MCsg9RS+bRxT3UxWNQWMJAJcGZmhaljIRwrqrCDrxQghiQoj4dVjYEJPZpuZYHAgKQ
	y2WICeV47F+7gA8HCz/NxG+L14Ari2y2XpLosdQa84NvuXtwO4mhrKUpmJ28iW4v52wtHP
	40HGcfLl4OEhq+5s9uIrOLdJmVJm91M=
X-MC-Unique: m1OuiyIQMZyZcsIbUQGhlw-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=P8tjlZZ1vnr5s02UWkNfl5JV06eWUR9UrqgbhwXTMlbsDq3f/nyzSlwhTwjawch4DASlVMt0gYVkZAIuitWkRBQ61vQ00+qm9Ud3kLoIh43duIIPZ5ZnoiVdAbIwI/P6vC7vfIJJEH9xJo1sxS98hRhK/1MzJ/kEk4qDDcl4oWFqy7lyycGopzvVeeCmMJshpJPN+QqN1O9hhpEekRNxD3nRGxtdNTU5qQvjH579Gveupzc8zp36cHCBrfbzbjo3rfBvMw2W7o/CAPNBqWP0ypSf1JqoyCXszVna/dp3+MPMMBTsAMSRK8VlDQ2XC6PEUYINH1tcgwGN6m2qnvMCDw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Do+/CNe2wWfLWK1zsQR5/Pkxi+lTgmSc56obCjZ1g9Y=;
 b=MwL801hz3CKf5vUZWLYCpcWHgz1HUwW9oemRXrtzIrw1qsaV54qFP+9mIZsDC5TgyPYbieqIO7avHayd9b2bXx8mpA7Ws7y2BsWXGGAlmQCyBVoAKoxn5adySZead2Ezk6r8+6MAyzPPHg0ZaTuaAKkCQNqsTzEjfnZjT5+FVc4uKFYsOFPdp2Sk8pCWcpoKQNbgSMw56nTdEgknM9AopR25rfRqDdqNhRs2j7zq1NAFsKuoB4mEureKnbkH8VYHI435GYTNA0D1i9m3F7ST5N16QVJfoZmfvPZQg1X8YCUcvLH3b16gV+ShpcBthXUIZ6KHniVg74+rw4I0Q1Vd9Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <42fb3257-0c36-c156-c81b-f70dd5f247aa@suse.com>
Date: Tue, 15 Feb 2022 08:09:46 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH v2 1/2] xen+tools: Report Interrupt Controller
 Virtualization capabilities on x86
Content-Language: en-US
To: Jane Malalane <Jane.Malalane@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>,
 Anthony Perard <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 George Dunlap <George.Dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Jun Nakajima <jun.nakajima@intel.com>, Kevin Tian <kevin.tian@intel.com>,
 Roger Pau Monne <roger.pau@citrix.com>,
 Andrew Cooper <Andrew.Cooper3@citrix.com>
References: <20220207182101.31941-1-jane.malalane@citrix.com>
 <20220207182101.31941-2-jane.malalane@citrix.com>
 <YgTi6bzeojtcu0xL@Air-de-Roger>
 <dff9c5c0-7bee-ce0d-3288-91255a701c99@citrix.com>
 <YgZIo9VQktcqGHTD@Air-de-Roger>
 <6d924061-f2fd-5f3d-0f98-79e76398b908@suse.com>
 <6c9400b8-7c76-34c8-f69e-3fad1eb53b8c@citrix.com>
 <101b0950-b7f2-119b-b654-574a71cec3bc@suse.com>
 <1bac0507-9420-f0b9-f846-f1c73bf9678d@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <1bac0507-9420-f0b9-f846-f1c73bf9678d@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS8PR04CA0203.eurprd04.prod.outlook.com
 (2603:10a6:20b:2f3::28) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5ffaad1d-8f4c-4766-9b0d-08d9f052279e
X-MS-TrafficTypeDiagnostic: VI1PR04MB3230:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB3230F0A3334B101AF8FF03C5B3349@VI1PR04MB3230.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	oPg9HOYDOUbEuZaWovuPLxl7KedvdwSllw7tpySb2JO+RgVI1/vPW3JI2o0JmYfZhnXUioX4ntmFpbg3MsA6k2aTkYolRFf1Ysqn8CWarobRHfVolQG57KG+/X3f/ez0FwfAGan5pt6+Q5Bqb8k4YSp06DTFbxHF9Z5jpf95o+TefTKy9D90I5M5NT3R+9VK/UjIW7myvipGG5QbilcIDUJFOAyXyh7+AwwyGWCDUbELCjPwhu1rJbN5aw3pU65XrsAkjQCf7859j1igoYI4i4J8ceUlSw3bYQRh7tAx6Euptv6Eeff8MKpOVoy+O0nJDKbvs8OcStltcerAav5j3aRwrRbQeXSuNi3B2r5IbmWH+smcTSDHoMpNEtjHOjYQs//BhgObnLChShWU02KhfFsb3WgDF6k4cGeQ7AKj1z2HfO3PcpsmQ/NoBZzFuCulTr4fNrYv41Al1P1HPy+OaJWvme2/J8TUe2lJZaiWwq9djSfY8X+fa6K9veeGxA+nd5GQTNXVhs0auo+WuDLQPzTtBqG1NSsjZEU8HN+9iG6dBd/dHhpD+oTktuF2E39vtKPgZrLHGP2ZToNNmqiUHPYgagrCeYt3ftBGWiI3CqElUXVMbfqOkOfB0OtZuK3sPvQupE7xFO5TlDpDlBvO812d/5jk0RpSd6qIusIj3McMGci52bPPVeWgS1RFA/y+L9bb0eIB7eriR9FF58yQkBKklqmpGDCPl2RhrhgN3SM=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(5660300002)(2906002)(38100700002)(83380400001)(66556008)(66946007)(66476007)(8936002)(8676002)(6666004)(7416002)(4326008)(2616005)(6486002)(36756003)(186003)(31686004)(508600001)(86362001)(26005)(31696002)(53546011)(6512007)(316002)(6916009)(54906003)(6506007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?Z9DjMQhgzPPgxbskbahxhLwnw1qGlN3eRD8k6nYlTs9AlRW4qqTIJQsdLxl3?=
 =?us-ascii?Q?W9xC08KipbitlJxkFJ99y/cSVZJtaIy0H6Df+kHzS3JSLVn/++wmX2jk1s+F?=
 =?us-ascii?Q?dlUnAq+2iDX4jybsFIf0z3lOMA9b0CLDZqS+pykNJ4Fhfd5I64I4wvo26Zdc?=
 =?us-ascii?Q?7ZWf9NqOqQ9eyfgGwzGPVio2ZPxR771h+4NnJs8EwX+nxJa2wXRLEkNjthRJ?=
 =?us-ascii?Q?LpO/7FW5U0BZmGMT8WTnq35rj/JYIVBoJW75PMJQMe2qu0/vvtg81WA48kNH?=
 =?us-ascii?Q?uqSqq8basOkDWZTw9bH+PQLjOTAaT6ZYpQ6pU85bO3y1emSBqoHZJ/nJUlcm?=
 =?us-ascii?Q?+9Ra98gZ4YDC/P3n+Hl7u6w9cVw9Fq5LtMkcApasT2yYh2a5/jh+wSGORPQE?=
 =?us-ascii?Q?d2t6FyYIi6oyZfpOC7sPPB6773Y0GeIRNjLkpX1mJSsyYGZw4yeDriTYQP3w?=
 =?us-ascii?Q?YP7551gVh9DIrxOgWz+PeM3zI1/2w8Lr/14MN4zB2369PiHjVDwpzCmwieSh?=
 =?us-ascii?Q?KBNc4W9JzGLqs9mP4WPZC7Kkw0lASaXcQ1yXJV7+a7RE+gWam/usE3KpW9as?=
 =?us-ascii?Q?3JYK5vxwkC1ucKxXdR0LPws4AdeA35UP24zn4hkbXFCw8d8xKFclDYI119n1?=
 =?us-ascii?Q?Mh8rp+BGDZhIm8ZvAlC3/n7GWfQxDlUpasQbnA9NOiIlz2/MZV1Of3rqe8j4?=
 =?us-ascii?Q?an2D8OIgyb+rAf7bxxqaSXhs2c7nwVzypXOON51lqYJ3Pgbbq9CSZiTDG3/P?=
 =?us-ascii?Q?l0VUERvI/gtipbTIfgUvfu26A9IwGPRIp7sTJvNbpPq22IhiGxDU4zdcQd/N?=
 =?us-ascii?Q?iyerL6jlr9Zd3sxG58sFBu2ytTUt86K9bJU5IBD6CbVY6A0J9O/Csv9VO/hF?=
 =?us-ascii?Q?tp46r0VE7NtQ9fqNBDnIpOsDNZp0t4nAQw41880oLL5a4cgl/x9alMxKWdH+?=
 =?us-ascii?Q?1c3a5wCmDp6b+rf6j92tojYgRZ03w0yziHJQGLL9UkJURvoAh7cGSK48xi4U?=
 =?us-ascii?Q?xtv7bkjE+IAtm6aa1dJRLUuCLauqMrRWYsCHHzagTrIxIpQRdDO66lWpEB0e?=
 =?us-ascii?Q?iWe7V8IVkwF02ZjZ2N0U2gw8OQ08iU6hp1QmsBpRki+l94xuiEekjG5KvMOp?=
 =?us-ascii?Q?9MttYTlxijQl8pv0CkvJs1iiX4iGdUkYozSQv+I6uN/L7nbWU00y1p/CY9lQ?=
 =?us-ascii?Q?D2j2PJEqHW4aidZ01Ja8TClO7vY2vSCmsaUMCvmXMBpQN31++KlLDq4GK8w7?=
 =?us-ascii?Q?ORlNKNvVnNCh4g5SVVHb1p8wTakswbMbfyB1UVHHOPGSMLgGtFtvqZC2KEpN?=
 =?us-ascii?Q?unJBUsaW8GypUd20IM9LP8dxZ/RFO33tQX9cd3tOOcMYjRzy13ONnRdNh9Pp?=
 =?us-ascii?Q?FGGF/Ksm+bqw23K2NMVdrV0YbNqzRcJfWHQTfs8wzdsDtjI+SkNN8ctz2gMs?=
 =?us-ascii?Q?xlihiohM1RaAMXYBbS4PT0TxDH6389AORjMhGFwfAr4xsHGaCs2rh8fnEQhW?=
 =?us-ascii?Q?hSqNnXM3bHz4dmIWKV7RjFFkFnEM/mlS8pRNH8m4+joCNEDA6T4sSIaeY2wi?=
 =?us-ascii?Q?M9Qxywul2sCog2lJB9VCbJEuoX+vEHib6c8smicUiuJ+3ZmNQHHPqeuyYIB8?=
 =?us-ascii?Q?2pL08ZKDwOHDOWFlorKssPA=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5ffaad1d-8f4c-4766-9b0d-08d9f052279e
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 07:09:49.6544
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: c+Zsdvgr98jW77eKWTrcziBFKF5zll2WDff8QCWs6Sf4nCKr1hlYX4cCInNCeYlACLrEDWPOT9310N9gIZSICw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3230

On 14.02.2022 18:09, Jane Malalane wrote:
> On 14/02/2022 13:18, Jan Beulich wrote:
>> [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachment=
s unless you have verified the sender and know the content is safe.
>>
>> On 14.02.2022 14:11, Jane Malalane wrote:
>>> On 11/02/2022 11:46, Jan Beulich wrote:
>>>> [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachme=
nts unless you have verified the sender and know the content is safe.
>>>>
>>>> On 11.02.2022 12:29, Roger Pau Monn=C3=A9 wrote:
>>>>> On Fri, Feb 11, 2022 at 10:06:48AM +0000, Jane Malalane wrote:
>>>>>> On 10/02/2022 10:03, Roger Pau Monn=C3=A9 wrote:
>>>>>>> On Mon, Feb 07, 2022 at 06:21:00PM +0000, Jane Malalane wrote:
>>>>>>>> diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vm=
cs.c
>>>>>>>> index 7ab15e07a0..4060aef1bd 100644
>>>>>>>> --- a/xen/arch/x86/hvm/vmx/vmcs.c
>>>>>>>> +++ b/xen/arch/x86/hvm/vmx/vmcs.c
>>>>>>>> @@ -343,6 +343,15 @@ static int vmx_init_vmcs_config(bool bsp)
>>>>>>>>                 MSR_IA32_VMX_PROCBASED_CTLS2, &mismatch);
>>>>>>>>         }
>>>>>>>>    =20
>>>>>>>> +    /* Check whether hardware supports accelerated xapic and x2ap=
ic. */
>>>>>>>> +    if ( bsp )
>>>>>>>> +    {
>>>>>>>> +        assisted_xapic_available =3D cpu_has_vmx_virtualize_apic_=
accesses;
>>>>>>>> +        assisted_x2apic_available =3D (cpu_has_vmx_apic_reg_virt =
||
>>>>>>>> +                                     cpu_has_vmx_virtual_intr_del=
ivery) &&
>>>>>>>> +                                    cpu_has_vmx_virtualize_x2apic=
_mode;
>>>>>>>
>>>>>>> I've been think about this, and it seems kind of asymmetric that fo=
r
>>>>>>> xAPIC mode we report hw assisted support only with
>>>>>>> virtualize_apic_accesses available, while for x2APIC we require
>>>>>>> virtualize_x2apic_mode plus either apic_reg_virt or
>>>>>>> virtual_intr_delivery.
>>>>>>>
>>>>>>> I think we likely need to be more consistent here, and report hw
>>>>>>> assisted x2APIC support as long as virtualize_x2apic_mode is
>>>>>>> available.
>>>>>>>
>>>>>>> This will likely have some effect on patch 2 also, as you will have=
 to
>>>>>>> adjust vmx_vlapic_msr_changed.
>>>>>>>
>>>>>>> Thanks, Roger.
>>>>>>
>>>>>> Any other thoughts on this? As on one hand it is asymmetric but also
>>>>>> there isn't much assistance with only virtualize_x2apic_mode set as,=
 in
>>>>>> this case, a VM exit will be avoided only when trying to access the =
TPR
>>>>>> register.
>>>>>
>>>>> I've been thinking about this, and reporting hardware assisted
>>>>> x{2}APIC virtualization with just
>>>>> SECONDARY_EXEC_VIRTUALIZE_APIC_ACCESSES or
>>>>> SECONDARY_EXEC_VIRTUALIZE_X2APIC_MODE doesn't seem very helpful. Whil=
e
>>>>> those provide some assistance to the VMM in order to handle APIC
>>>>> accesses, it will still require a trap into the hypervisor to handle
>>>>> most of the accesses.
>>>>>
>>>>> So maybe we should only report hardware assisted support when the
>>>>> mentioned features are present together with
>>>>> SECONDARY_EXEC_APIC_REGISTER_VIRT?
>>>>
>>>> Not sure - "some assistance" seems still a little better than none at =
all.
>>>> Which route to go depends on what exactly we intend the bit to be used=
 for.
>>>>
>>> True. I intended this bit to be specifically for enabling
>>> assisted_x{2}apic. So, would it be inconsistent to report hardware
>>> assistance with just VIRTUALIZE_APIC_ACCESSES or VIRTUALIZE_X2APIC_MODE
>>> but still claim that x{2}apic is virtualized if no MSR accesses are
>>> intercepted with XEN_HVM_CPUID_X2APIC_VIRT (in traps.c) so that, as you
>>> say, the guest gets at least "some assistance" instead of none but we
>>> still claim x{2}apic virtualization when it is actually complete? Maybe
>>> I could also add a comment alluding to this in the xl documentation.
>>
>> To rephrase my earlier point: Which kind of decisions are the consumer(s=
)
>> of us reporting hardware assistance going to take? In how far is there a
>> risk that "some assistance" is overall going to lead to a loss of
>> performance? I guess I'd need to see comment and actual code all in one
>> place ...
>>
> So, I was thinking of adding something along the lines of:
>=20
> +=3Ditem B<assisted_xapic=3DBOOLEAN> B<(x86 only)>
> +Enables or disables hardware assisted virtualization for xAPIC. This
> +allows accessing APIC registers without a VM-exit. Notice enabling
> +this does not guarantee full virtualization for xAPIC, as this can
> +only be achieved if hardware supports =E2=80=9CAPIC-register virtualizat=
ion=E2=80=9D
> +and =E2=80=9Cvirtual-interrupt delivery=E2=80=9D. The default is settabl=
e via
> +L<xl.conf(5)>.

But isn't this contradictory? Doesn't lack of APIC-register virtualization
mean VM exits upon (most) accesses?

Jan

> and going for assisted_x2apic_available =3D=20
> cpu_has_vmx_virtualize_x2apic_mode.
>=20
> This would prevent the customer from expecting full acceleration when=20
> apic_register_virt and/or virtual_intr_delivery aren't available whilst=20
> still offering some if they are not available as Xen currently does. In=20
> a future patch, we could also expose and add config options for these=20
> controls if we wanted to.
>=20
> Thank you for your help,
>=20
> Jane.



From xen-devel-bounces@lists.xenproject.org Tue Feb 15 08:12:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 08:12:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272812.467771 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJsw2-0000zU-BQ; Tue, 15 Feb 2022 08:11:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272812.467771; Tue, 15 Feb 2022 08:11:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJsw2-0000zN-7e; Tue, 15 Feb 2022 08:11:42 +0000
Received: by outflank-mailman (input) for mailman id 272812;
 Tue, 15 Feb 2022 08:11:41 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=i+nY=S6=gmail.com=andr2000@srs-se1.protection.inumbo.net>)
 id 1nJsw1-0000zH-FO
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 08:11:41 +0000
Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com
 [2a00:1450:4864:20::133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e6b9bc4a-8e36-11ec-8eb8-a37418f5ba1a;
 Tue, 15 Feb 2022 09:11:39 +0100 (CET)
Received: by mail-lf1-x133.google.com with SMTP id b9so11155571lfv.7
 for <xen-devel@lists.xenproject.org>; Tue, 15 Feb 2022 00:11:39 -0800 (PST)
Received: from localhost.localdomain (host-176-36-245-220.b024.la.net.ua.
 [176.36.245.220])
 by smtp.gmail.com with ESMTPSA id o2sm1314543lfr.31.2022.02.15.00.11.36
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 15 Feb 2022 00:11:36 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e6b9bc4a-8e36-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=ZF1B9rIAPx61ZY1fKj9JXTDoSUJ4I9hy3WNShA/lFu8=;
        b=kXiC35QtWZHI3xzisD8UHMXTIT9qC84t5U2O0h/CLHPweKNL/A1Ar/OxC7oaZGXbdx
         eS87tSaKE/QIrNDNYgiv699UojOb9qCRgmrOC0uEfTwekGPhAJ9mQNLVZ/CHCJVCo6nX
         OwEfyVh2zaran0EfpBLtTTNJreBSV2JSlajDPIFMv5L4hhg7Vwn9ycicuCBKg2Q7RQDf
         kJDBGzRtGBN5dlfq2fY8um7chAZBEYEgSfeqI+1mBRBMfpkG9Sk2pHBB0pHk6b2d/OyM
         n2hiY3IFnX3zXyOELOV7SoApfhgdTNPAF9dPNQA9bRFTaK0ub/GJPNg37aaXQIEM7x/1
         u/gg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=ZF1B9rIAPx61ZY1fKj9JXTDoSUJ4I9hy3WNShA/lFu8=;
        b=e+00wCu9xRZCYK9EijLTrgv0Ys5pz5/xUhtL5+WjWtzDGevwDyztCUqRSasjo2hf3H
         7Riilc4PFtO2iT7hOADezKiiU0fB7hUblcS8gaD5LoxAGiQ8K0mDrHySR54luUbK9f96
         JnT0lKOVaBCO9bvLCTQPVnODEWtHQcqOJdtfo67hPqIEQAtzti8lkFO8rMkFJflvli6O
         xT42ZNGBiN9PDHpTkM93KaLDc1szWTHJLdLm4RFGBGy2gR2rpwrKFjHxeNTvfsoDHeg1
         RF9RgM8shpNYrnz38iVbecswE41VWrS/5jlcdbY5wyE4n1afHS06ozpZy5rlytKQzAb4
         NrWg==
X-Gm-Message-State: AOAM531MztHDGM6TgepF+PXswfn9guMaod9UFXqEoEBCuQc2IbV1+Vlm
	+OPyKYKtpxZluxbvx0LNRckNvh0wj6E=
X-Google-Smtp-Source: ABdhPJymnsLcP5/sLAPVYw2RjyfY7zPovopXxavsixGDGxaEfTNOJrY2vqsvbhaVkqA/j8dTU+/ITg==
X-Received: by 2002:a05:6512:3da2:: with SMTP id k34mr2229684lfv.217.1644912698031;
        Tue, 15 Feb 2022 00:11:38 -0800 (PST)
From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: roger.pau@citrix.com,
	jbeulich@suse.com,
	julien@xen.org,
	sstabellini@kernel.org,
	oleksandr_tyshchenko@epam.com,
	volodymyr_babchuk@epam.com,
	artem_mygaiev@epam.com,
	bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: [PATCH v2] vpci: introduce per-domain lock to protect vpci structure
Date: Tue, 15 Feb 2022 10:11:35 +0200
Message-Id: <20220215081135.1497470-1-andr2000@gmail.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

Introduce a per-domain read/write lock to check whether vpci is present,
so we are sure there are no accesses to the contents of the vpci struct
if not. This lock can be used (and in a few cases is used right away)
so that vpci removal can be performed while holding the lock in write
mode. Previously such removal could race with vpci_read for example.

1. Per-domain's vpci_rwlock is used to protect pdev->vpci structure
from being removed.

2. Writing the command register and ROM BAR register may trigger
modify_bars to run, which in turn may access multiple pdevs while
checking for the existing BAR's overlap. The overlapping check, if done
under the read lock, requires vpci->lock to be acquired on both devices
being compared, which may produce a deadlock. It is not possible to
upgrade read lock to write lock in such a case. So, in order to prevent
the deadlock, check which registers are going to be written and acquire
the lock in the appropriate mode from the beginning.

All other code, which doesn't lead to pdev->vpci destruction and does not
access multiple pdevs at the same time, can still use a combination of the
read lock and pdev->vpci->lock.

3. Optimize if ROM BAR write lock required detection by caching offset
of the ROM BAR register in vpci->header->rom_reg which depends on
header's type.

4. Reduce locked region in vpci_remove_device as it is now possible
to set pdev->vpci to NULL early right after the write lock is acquired.

5. Reduce locked region in vpci_add_handlers as it is possible to
initialize many more fields of the struct vpci before assigning it to
pdev->vpci.

6. vpci_{add|remove}_register are required to be called with the write lock
held, but it is not feasible to add an assert there as it requires
struct domain to be passed for that. So, add a comment about this requirement
to these and other functions with the equivalent constraints.

7. Drop const qualifier where the new rwlock is used and this is appropriate.

8. Do not call process_pending_softirqs with any locks held. For that unlock
prior the call and re-acquire the locks after. After re-acquiring the
lock there is no need to check if pdev->vpci exists:
 - in apply_map because of the context it is called (no race condition
   possible)
 - for MSI/MSI-X debug code because it is called at the end of
   pdev->vpci access and no further access to pdev->vpci is made

9. Check for !pdev->vpci in vpci_{read|write} after acquiring the lock
and if so, allow reading or writing the hardware register directly. This is
acceptable as we only deal with Dom0 as of now. Once DomU support is
added the write will need to be ignored and read return all 0's for the
guests, while Dom0 can still access the registers directly.

10. Introduce pcidevs_trylock, so there is a possibility to try locking
the pcidev's lock.

11. Use pcidev's lock around for_each_pdev and pci_get_pdev_by_domain
while accessing pdevs in vpci code.

12. This is based on the discussion at [1].

[1] https://lore.kernel.org/all/20220204063459.680961-4-andr2000@gmail.com/

Suggested-by: Roger Pau Monné <roger.pau@citrix.com>
Suggested-by: Jan Beulich <jbeulich@suse.com>
Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

---
This was checked on x86: with and without PVH Dom0.

Since v1:
- s/ASSERT(!!/ASSERT(
- move vpci_header_write_lock to vpci.c and rename to
  vpci_header_need_write_lock
- use a simple static overlap function instead of vpci_offset_cmp
- signal no ROM BAR with rom_reg == 0
- msix_accept: new line before return
- do not run process_pending_softirqs with locks held
- in-code comments update
- move rom_reg before rom_enabled in struct vpci. Roger, it is not
  possible to move it after 'type' as in this case it becomes per BAR
  and we need it per vpci
- add !pdev->vpci checks to vpci_{read|write}
- move ASSERT(pdev->vpci) in add_handlers under the write lock
- introduce pcidevs_trylock
- protect for_each_pdev with pcidevs lock
---
 xen/arch/x86/hvm/vmsi.c       |   7 +++
 xen/common/domain.c           |   3 +
 xen/drivers/passthrough/pci.c |   5 ++
 xen/drivers/vpci/header.c     |  56 +++++++++++++++++++
 xen/drivers/vpci/msi.c        |  25 ++++++++-
 xen/drivers/vpci/msix.c       |  41 ++++++++++++--
 xen/drivers/vpci/vpci.c       | 100 ++++++++++++++++++++++++++--------
 xen/include/xen/pci.h         |   1 +
 xen/include/xen/sched.h       |   3 +
 xen/include/xen/vpci.h        |   6 ++
 10 files changed, 215 insertions(+), 32 deletions(-)

diff --git a/xen/arch/x86/hvm/vmsi.c b/xen/arch/x86/hvm/vmsi.c
index 13e2a190b439..2a13c6581345 100644
--- a/xen/arch/x86/hvm/vmsi.c
+++ b/xen/arch/x86/hvm/vmsi.c
@@ -893,6 +893,9 @@ int vpci_msix_arch_print(const struct vpci_msix *msix)
 {
     unsigned int i;
 
+    ASSERT(rw_is_locked(&msix->pdev->domain->vpci_rwlock));
+    ASSERT(pcidevs_locked());
+
     for ( i = 0; i < msix->max_entries; i++ )
     {
         const struct vpci_msix_entry *entry = &msix->entries[i];
@@ -911,7 +914,11 @@ int vpci_msix_arch_print(const struct vpci_msix *msix)
             struct pci_dev *pdev = msix->pdev;
 
             spin_unlock(&msix->pdev->vpci->lock);
+            pcidevs_unlock();
+            read_unlock(&pdev->domain->vpci_rwlock);
             process_pending_softirqs();
+            read_lock(&pdev->domain->vpci_rwlock);
+            pcidevs_lock();
             /* NB: we assume that pdev cannot go away for an alive domain. */
             if ( !pdev->vpci || !spin_trylock(&pdev->vpci->lock) )
                 return -EBUSY;
diff --git a/xen/common/domain.c b/xen/common/domain.c
index 2048ebad86ff..10558c22285d 100644
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -616,6 +616,9 @@ struct domain *domain_create(domid_t domid,
 
 #ifdef CONFIG_HAS_PCI
     INIT_LIST_HEAD(&d->pdev_list);
+#ifdef CONFIG_HAS_VPCI
+    rwlock_init(&d->vpci_rwlock);
+#endif
 #endif
 
     /* All error paths can depend on the above setup. */
diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
index e8b09d77d880..57077dd52d10 100644
--- a/xen/drivers/passthrough/pci.c
+++ b/xen/drivers/passthrough/pci.c
@@ -57,6 +57,11 @@ void pcidevs_lock(void)
     spin_lock_recursive(&_pcidevs_lock);
 }
 
+int pcidevs_trylock(void)
+{
+    return spin_trylock_recursive(&_pcidevs_lock);
+}
+
 void pcidevs_unlock(void)
 {
     spin_unlock_recursive(&_pcidevs_lock);
diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c
index 40ff79c33f8f..8736da95af86 100644
--- a/xen/drivers/vpci/header.c
+++ b/xen/drivers/vpci/header.c
@@ -142,12 +142,14 @@ bool vpci_process_pending(struct vcpu *v)
         if ( rc == -ERESTART )
             return true;
 
+        read_lock(&v->domain->vpci_rwlock);
         spin_lock(&v->vpci.pdev->vpci->lock);
         /* Disable memory decoding unconditionally on failure. */
         modify_decoding(v->vpci.pdev,
                         rc ? v->vpci.cmd & ~PCI_COMMAND_MEMORY : v->vpci.cmd,
                         !rc && v->vpci.rom_only);
         spin_unlock(&v->vpci.pdev->vpci->lock);
+        read_unlock(&v->domain->vpci_rwlock);
 
         rangeset_destroy(v->vpci.mem);
         v->vpci.mem = NULL;
@@ -171,8 +173,24 @@ static int __init apply_map(struct domain *d, const struct pci_dev *pdev,
     struct map_data data = { .d = d, .map = true };
     int rc;
 
+    ASSERT(rw_is_write_locked(&d->vpci_rwlock));
+
     while ( (rc = rangeset_consume_ranges(mem, map_range, &data)) == -ERESTART )
+    {
+        /*
+         * FIXME: apply_map is called from dom0 specific init code when
+         * system_state < SYS_STATE_active, so there is no race condition
+         * possible between this code and vpci_process_pending. So, neither
+         * vpci_process_pending may try to acquire the lock in read mode and
+         * also destroy pdev->vpci in its error path nor pdev may be disposed
+         * yet. This means that it is not required to check if the relevant
+         * pdev->vpci still exists after re-acquiring the lock.
+         */
+        write_unlock(&d->vpci_rwlock);
         process_pending_softirqs();
+        write_lock(&d->vpci_rwlock);
+    }
+
     rangeset_destroy(mem);
     if ( !rc )
         modify_decoding(pdev, cmd, false);
@@ -203,6 +221,7 @@ static void defer_map(struct domain *d, struct pci_dev *pdev,
     raise_softirq(SCHEDULE_SOFTIRQ);
 }
 
+/* This must hold domain's vpci_rwlock in write mode. */
 static int modify_bars(const struct pci_dev *pdev, uint16_t cmd, bool rom_only)
 {
     struct vpci_header *header = &pdev->vpci->header;
@@ -267,6 +286,7 @@ static int modify_bars(const struct pci_dev *pdev, uint16_t cmd, bool rom_only)
      * Check for overlaps with other BARs. Note that only BARs that are
      * currently mapped (enabled) are checked for overlaps.
      */
+    pcidevs_lock();
     for_each_pdev ( pdev->domain, tmp )
     {
         if ( tmp == pdev )
@@ -306,10 +326,12 @@ static int modify_bars(const struct pci_dev *pdev, uint16_t cmd, bool rom_only)
                 printk(XENLOG_G_WARNING "Failed to remove [%lx, %lx]: %d\n",
                        start, end, rc);
                 rangeset_destroy(mem);
+                pcidevs_unlock();
                 return rc;
             }
         }
     }
+    pcidevs_unlock();
 
     ASSERT(dev);
 
@@ -454,6 +476,8 @@ static int init_bars(struct pci_dev *pdev)
     struct vpci_bar *bars = header->bars;
     int rc;
 
+    ASSERT(rw_is_write_locked(&pdev->domain->vpci_rwlock));
+
     switch ( pci_conf_read8(pdev->sbdf, PCI_HEADER_TYPE) & 0x7f )
     {
     case PCI_HEADER_TYPE_NORMAL:
@@ -542,6 +566,8 @@ static int init_bars(struct pci_dev *pdev)
         }
     }
 
+    ASSERT(!header->rom_reg);
+
     /* Check expansion ROM. */
     rc = pci_size_mem_bar(pdev->sbdf, rom_reg, &addr, &size, PCI_BAR_ROM);
     if ( rc > 0 && size )
@@ -558,12 +584,42 @@ static int init_bars(struct pci_dev *pdev)
                                4, rom);
         if ( rc )
             rom->type = VPCI_BAR_EMPTY;
+
+        header->rom_reg = rom_reg;
     }
 
     return (cmd & PCI_COMMAND_MEMORY) ? modify_bars(pdev, cmd, false) : 0;
 }
 REGISTER_VPCI_INIT(init_bars, VPCI_PRIORITY_MIDDLE);
 
+static bool overlap(unsigned int r1_offset, unsigned int r1_size,
+                    unsigned int r2_offset, unsigned int r2_size)
+{
+    /* Return true if there is an overlap. */
+    return r1_offset < r2_offset + r2_size && r2_offset < r1_offset + r1_size;
+}
+
+bool vpci_header_need_write_lock(const struct pci_dev *pdev,
+                                 unsigned int start, unsigned int size)
+{
+    /*
+     * Writing the command register and ROM BAR register may trigger
+     * modify_bars to run, which in turn may access multiple pdevs while
+     * checking for the existing BAR's overlap. The overlapping check, if done
+     * under the read lock, requires vpci->lock to be acquired on both devices
+     * being compared, which may produce a deadlock. At the same time it is not
+     * possible to upgrade read lock to write lock in such a case.
+     * Check which registers are going to be written and return true if lock
+     * needs to be acquired in write mode.
+     */
+    if ( overlap(start, size, PCI_COMMAND, 2) ||
+         (pdev->vpci->header.rom_reg &&
+          overlap(start, size, pdev->vpci->header.rom_reg, 4)) )
+        return true;
+
+    return false;
+}
+
 /*
  * Local variables:
  * mode: C
diff --git a/xen/drivers/vpci/msi.c b/xen/drivers/vpci/msi.c
index 5757a7aed20f..396f336fd330 100644
--- a/xen/drivers/vpci/msi.c
+++ b/xen/drivers/vpci/msi.c
@@ -190,6 +190,8 @@ static int init_msi(struct pci_dev *pdev)
     uint16_t control;
     int ret;
 
+    ASSERT(rw_is_write_locked(&pdev->domain->vpci_rwlock));
+
     if ( !pos )
         return 0;
 
@@ -265,7 +267,7 @@ REGISTER_VPCI_INIT(init_msi, VPCI_PRIORITY_LOW);
 
 void vpci_dump_msi(void)
 {
-    const struct domain *d;
+    struct domain *d;
 
     rcu_read_lock(&domlist_read_lock);
     for_each_domain ( d )
@@ -277,6 +279,15 @@ void vpci_dump_msi(void)
 
         printk("vPCI MSI/MSI-X d%d\n", d->domain_id);
 
+        if ( !read_trylock(&d->vpci_rwlock) )
+            continue;
+
+        if ( !pcidevs_trylock() )
+        {
+            read_unlock(&d->vpci_rwlock);
+            continue;
+        }
+
         for_each_pdev ( d, pdev )
         {
             const struct vpci_msi *msi;
@@ -318,14 +329,22 @@ void vpci_dump_msi(void)
                      * holding the lock.
                      */
                     printk("unable to print all MSI-X entries: %d\n", rc);
-                    process_pending_softirqs();
-                    continue;
+                    goto pdev_done;
                 }
             }
 
             spin_unlock(&pdev->vpci->lock);
+ pdev_done:
+            pcidevs_unlock();
+            read_unlock(&d->vpci_rwlock);
+
             process_pending_softirqs();
+
+            read_lock(&d->vpci_rwlock);
+            pcidevs_lock();
         }
+        pcidevs_unlock();
+        read_unlock(&d->vpci_rwlock);
     }
     rcu_read_unlock(&domlist_read_lock);
 }
diff --git a/xen/drivers/vpci/msix.c b/xen/drivers/vpci/msix.c
index 846f1b8d7038..0d473bfbe3a5 100644
--- a/xen/drivers/vpci/msix.c
+++ b/xen/drivers/vpci/msix.c
@@ -138,6 +138,7 @@ static void control_write(const struct pci_dev *pdev, unsigned int reg,
         pci_conf_write16(pdev->sbdf, reg, val);
 }
 
+/* This must hold domain's vpci_rwlock in write mode. */
 static struct vpci_msix *msix_find(const struct domain *d, unsigned long addr)
 {
     struct vpci_msix *msix;
@@ -158,7 +159,13 @@ static struct vpci_msix *msix_find(const struct domain *d, unsigned long addr)
 
 static int msix_accept(struct vcpu *v, unsigned long addr)
 {
-    return !!msix_find(v->domain, addr);
+    int rc;
+
+    read_lock(&v->domain->vpci_rwlock);
+    rc = !!msix_find(v->domain, addr);
+    read_unlock(&v->domain->vpci_rwlock);
+
+    return rc;
 }
 
 static bool access_allowed(const struct pci_dev *pdev, unsigned long addr,
@@ -185,18 +192,27 @@ static struct vpci_msix_entry *get_entry(struct vpci_msix *msix,
 static int msix_read(struct vcpu *v, unsigned long addr, unsigned int len,
                      unsigned long *data)
 {
-    const struct domain *d = v->domain;
-    struct vpci_msix *msix = msix_find(d, addr);
+    struct domain *d = v->domain;
+    struct vpci_msix *msix;
     const struct vpci_msix_entry *entry;
     unsigned int offset;
 
     *data = ~0ul;
 
+    read_lock(&d->vpci_rwlock);
+
+    msix = msix_find(d, addr);
     if ( !msix )
+    {
+        read_unlock(&d->vpci_rwlock);
         return X86EMUL_RETRY;
+    }
 
     if ( !access_allowed(msix->pdev, addr, len) )
+    {
+        read_unlock(&d->vpci_rwlock);
         return X86EMUL_OKAY;
+    }
 
     if ( VMSIX_ADDR_IN_RANGE(addr, msix->pdev->vpci, VPCI_MSIX_PBA) )
     {
@@ -222,6 +238,7 @@ static int msix_read(struct vcpu *v, unsigned long addr, unsigned int len,
             break;
         }
 
+        read_unlock(&d->vpci_rwlock);
         return X86EMUL_OKAY;
     }
 
@@ -255,6 +272,7 @@ static int msix_read(struct vcpu *v, unsigned long addr, unsigned int len,
         break;
     }
     spin_unlock(&msix->pdev->vpci->lock);
+    read_unlock(&d->vpci_rwlock);
 
     return X86EMUL_OKAY;
 }
@@ -262,16 +280,25 @@ static int msix_read(struct vcpu *v, unsigned long addr, unsigned int len,
 static int msix_write(struct vcpu *v, unsigned long addr, unsigned int len,
                       unsigned long data)
 {
-    const struct domain *d = v->domain;
-    struct vpci_msix *msix = msix_find(d, addr);
+    struct domain *d = v->domain;
+    struct vpci_msix *msix;
     struct vpci_msix_entry *entry;
     unsigned int offset;
 
+    read_lock(&d->vpci_rwlock);
+
+    msix = msix_find(d, addr);
     if ( !msix )
+    {
+        read_unlock(&d->vpci_rwlock);
         return X86EMUL_RETRY;
+    }
 
     if ( !access_allowed(msix->pdev, addr, len) )
+    {
+        read_unlock(&d->vpci_rwlock);
         return X86EMUL_OKAY;
+    }
 
     if ( VMSIX_ADDR_IN_RANGE(addr, msix->pdev->vpci, VPCI_MSIX_PBA) )
     {
@@ -294,6 +321,7 @@ static int msix_write(struct vcpu *v, unsigned long addr, unsigned int len,
             }
         }
 
+        read_unlock(&d->vpci_rwlock);
         return X86EMUL_OKAY;
     }
 
@@ -371,6 +399,7 @@ static int msix_write(struct vcpu *v, unsigned long addr, unsigned int len,
         break;
     }
     spin_unlock(&msix->pdev->vpci->lock);
+    read_unlock(&d->vpci_rwlock);
 
     return X86EMUL_OKAY;
 }
@@ -437,6 +466,8 @@ static int init_msix(struct pci_dev *pdev)
     struct vpci_msix *msix;
     int rc;
 
+    ASSERT(rw_is_write_locked(&pdev->domain->vpci_rwlock));
+
     msix_offset = pci_find_cap_offset(pdev->seg, pdev->bus, slot, func,
                                       PCI_CAP_ID_MSIX);
     if ( !msix_offset )
diff --git a/xen/drivers/vpci/vpci.c b/xen/drivers/vpci/vpci.c
index fb0947179b79..68e9f0ac8c3e 100644
--- a/xen/drivers/vpci/vpci.c
+++ b/xen/drivers/vpci/vpci.c
@@ -37,43 +37,58 @@ extern vpci_register_init_t *const __end_vpci_array[];
 
 void vpci_remove_device(struct pci_dev *pdev)
 {
+    struct vpci *vpci;
+
     if ( !has_vpci(pdev->domain) )
         return;
 
-    spin_lock(&pdev->vpci->lock);
+    write_lock(&pdev->domain->vpci_rwlock);
+    if ( !pdev->vpci )
+    {
+        write_unlock(&pdev->domain->vpci_rwlock);
+        return;
+    }
+
+    vpci = pdev->vpci;
+    pdev->vpci = NULL;
+    write_unlock(&pdev->domain->vpci_rwlock);
+
     while ( !list_empty(&pdev->vpci->handlers) )
     {
-        struct vpci_register *r = list_first_entry(&pdev->vpci->handlers,
+        struct vpci_register *r = list_first_entry(&vpci->handlers,
                                                    struct vpci_register,
                                                    node);
 
         list_del(&r->node);
         xfree(r);
     }
-    spin_unlock(&pdev->vpci->lock);
-    xfree(pdev->vpci->msix);
-    xfree(pdev->vpci->msi);
-    xfree(pdev->vpci);
-    pdev->vpci = NULL;
+    xfree(vpci->msix);
+    xfree(vpci->msi);
+    xfree(vpci);
 }
 
 int vpci_add_handlers(struct pci_dev *pdev)
 {
+    struct vpci *vpci;
     unsigned int i;
     int rc = 0;
 
     if ( !has_vpci(pdev->domain) )
         return 0;
 
+    vpci = xzalloc(struct vpci);
+    if ( !vpci )
+        return -ENOMEM;
+
+    INIT_LIST_HEAD(&vpci->handlers);
+    spin_lock_init(&vpci->lock);
+
+    write_lock(&pdev->domain->vpci_rwlock);
+
     /* We should not get here twice for the same device. */
     ASSERT(!pdev->vpci);
 
-    pdev->vpci = xzalloc(struct vpci);
-    if ( !pdev->vpci )
-        return -ENOMEM;
-
-    INIT_LIST_HEAD(&pdev->vpci->handlers);
-    spin_lock_init(&pdev->vpci->lock);
+    pdev->vpci = vpci;
 
     for ( i = 0; i < NUM_VPCI_INIT; i++ )
     {
@@ -81,6 +96,7 @@ int vpci_add_handlers(struct pci_dev *pdev)
         if ( rc )
             break;
     }
+    write_unlock(&pdev->domain->vpci_rwlock);
 
     if ( rc )
         vpci_remove_device(pdev);
@@ -129,6 +145,7 @@ uint32_t vpci_hw_read32(const struct pci_dev *pdev, unsigned int reg,
     return pci_conf_read32(pdev->sbdf, reg);
 }
 
+/* This must hold domain's vpci_rwlock in write mode. */
 int vpci_add_register(struct vpci *vpci, vpci_read_t *read_handler,
                       vpci_write_t *write_handler, unsigned int offset,
                       unsigned int size, void *data)
@@ -152,8 +169,6 @@ int vpci_add_register(struct vpci *vpci, vpci_read_t *read_handler,
     r->offset = offset;
     r->private = data;
 
-    spin_lock(&vpci->lock);
-
     /* The list of handlers must be kept sorted at all times. */
     list_for_each ( prev, &vpci->handlers )
     {
@@ -165,25 +180,23 @@ int vpci_add_register(struct vpci *vpci, vpci_read_t *read_handler,
             break;
         if ( cmp == 0 )
         {
-            spin_unlock(&vpci->lock);
             xfree(r);
             return -EEXIST;
         }
     }
 
     list_add_tail(&r->node, prev);
-    spin_unlock(&vpci->lock);
 
     return 0;
 }
 
+/* This must hold domain's vpci_rwlock in write mode. */
 int vpci_remove_register(struct vpci *vpci, unsigned int offset,
                          unsigned int size)
 {
     const struct vpci_register r = { .offset = offset, .size = size };
     struct vpci_register *rm;
 
-    spin_lock(&vpci->lock);
     list_for_each_entry ( rm, &vpci->handlers, node )
     {
         int cmp = vpci_register_cmp(&r, rm);
@@ -195,14 +208,12 @@ int vpci_remove_register(struct vpci *vpci, unsigned int offset,
         if ( !cmp && rm->offset == offset && rm->size == size )
         {
             list_del(&rm->node);
-            spin_unlock(&vpci->lock);
             xfree(rm);
             return 0;
         }
         if ( cmp <= 0 )
             break;
     }
-    spin_unlock(&vpci->lock);
 
     return -ENOENT;
 }
@@ -310,7 +321,7 @@ static uint32_t merge_result(uint32_t data, uint32_t new, unsigned int size,
 
 uint32_t vpci_read(pci_sbdf_t sbdf, unsigned int reg, unsigned int size)
 {
-    const struct domain *d = current->domain;
+    struct domain *d = current->domain;
     const struct pci_dev *pdev;
     const struct vpci_register *r;
     unsigned int data_offset = 0;
@@ -323,10 +334,18 @@ uint32_t vpci_read(pci_sbdf_t sbdf, unsigned int reg, unsigned int size)
     }
 
     /* Find the PCI dev matching the address. */
+    pcidevs_lock();
     pdev = pci_get_pdev_by_domain(d, sbdf.seg, sbdf.bus, sbdf.devfn);
+    pcidevs_unlock();
     if ( !pdev )
         return vpci_read_hw(sbdf, reg, size);
 
+    read_lock(&d->vpci_rwlock);
+    if ( !pdev->vpci )
+    {
+        read_unlock(&d->vpci_rwlock);
+        return vpci_read_hw(sbdf, reg, size);
+    }
     spin_lock(&pdev->vpci->lock);
 
     /* Read from the hardware or the emulated register handlers. */
@@ -371,6 +390,7 @@ uint32_t vpci_read(pci_sbdf_t sbdf, unsigned int reg, unsigned int size)
         ASSERT(data_offset < size);
     }
     spin_unlock(&pdev->vpci->lock);
+    read_unlock(&d->vpci_rwlock);
 
     if ( data_offset < size )
     {
@@ -413,11 +433,12 @@ static void vpci_write_helper(const struct pci_dev *pdev,
 void vpci_write(pci_sbdf_t sbdf, unsigned int reg, unsigned int size,
                 uint32_t data)
 {
-    const struct domain *d = current->domain;
+    struct domain *d = current->domain;
     const struct pci_dev *pdev;
     const struct vpci_register *r;
     unsigned int data_offset = 0;
     const unsigned long *ro_map = pci_get_ro_map(sbdf.seg);
+    bool write_locked = false;
 
     if ( !size )
     {
@@ -433,14 +454,38 @@ void vpci_write(pci_sbdf_t sbdf, unsigned int reg, unsigned int size,
      * Find the PCI dev matching the address.
      * Passthrough everything that's not trapped.
      */
+    pcidevs_lock();
     pdev = pci_get_pdev_by_domain(d, sbdf.seg, sbdf.bus, sbdf.devfn);
+    pcidevs_unlock();
     if ( !pdev )
     {
         vpci_write_hw(sbdf, reg, size, data);
         return;
     }
 
-    spin_lock(&pdev->vpci->lock);
+    if ( vpci_header_need_write_lock(pdev, reg, size) )
+    {
+        /* Gain exclusive access to all of the domain pdevs vpci. */
+        write_lock(&d->vpci_rwlock);
+        if ( !pdev->vpci )
+        {
+            write_unlock(&d->vpci_rwlock);
+            vpci_write_hw(sbdf, reg, size, data);
+            return;
+        }
+        write_locked = true;
+    }
+    else
+    {
+        read_lock(&d->vpci_rwlock);
+        if ( !pdev->vpci )
+        {
+            read_unlock(&d->vpci_rwlock);
+            vpci_write_hw(sbdf, reg, size, data);
+            return;
+        }
+        spin_lock(&pdev->vpci->lock);
+    }
 
     /* Write the value to the hardware or emulated registers. */
     list_for_each_entry ( r, &pdev->vpci->handlers, node )
@@ -475,7 +520,14 @@ void vpci_write(pci_sbdf_t sbdf, unsigned int reg, unsigned int size,
             break;
         ASSERT(data_offset < size);
     }
-    spin_unlock(&pdev->vpci->lock);
+
+    if ( write_locked )
+        write_unlock(&d->vpci_rwlock);
+    else
+    {
+        spin_unlock(&pdev->vpci->lock);
+        read_unlock(&d->vpci_rwlock);
+    }
 
     if ( data_offset < size )
         /* Tailing gap, write the remaining. */
diff --git a/xen/include/xen/pci.h b/xen/include/xen/pci.h
index b6d7e454f814..bb916433cce4 100644
--- a/xen/include/xen/pci.h
+++ b/xen/include/xen/pci.h
@@ -149,6 +149,7 @@ struct pci_dev {
  */
 
 void pcidevs_lock(void);
+int pcidevs_trylock(void);
 void pcidevs_unlock(void);
 bool_t __must_check pcidevs_locked(void);
 
diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
index 37f78cc4c4c9..ecd34481a7af 100644
--- a/xen/include/xen/sched.h
+++ b/xen/include/xen/sched.h
@@ -444,6 +444,9 @@ struct domain
 
 #ifdef CONFIG_HAS_PCI
     struct list_head pdev_list;
+#ifdef CONFIG_HAS_VPCI
+    rwlock_t vpci_rwlock;
+#endif
 #endif
 
 #ifdef CONFIG_HAS_PASSTHROUGH
diff --git a/xen/include/xen/vpci.h b/xen/include/xen/vpci.h
index e8ac1eb39513..be388e14bfb3 100644
--- a/xen/include/xen/vpci.h
+++ b/xen/include/xen/vpci.h
@@ -57,6 +57,9 @@ uint32_t vpci_hw_read32(const struct pci_dev *pdev, unsigned int reg,
  */
 bool __must_check vpci_process_pending(struct vcpu *v);
 
+bool vpci_header_need_write_lock(const struct pci_dev *pdev,
+                                 unsigned int start, unsigned int size);
+
 struct vpci {
     /* List of vPCI handlers for a device. */
     struct list_head handlers;
@@ -83,6 +86,9 @@ struct vpci {
         } bars[PCI_HEADER_NORMAL_NR_BARS + 1];
         /* At most 6 BARS + 1 expansion ROM BAR. */
 
+        /* Offset to the ROM BAR register if any. */
+        unsigned int rom_reg;
+
         /*
          * Store whether the ROM enable bit is set (doesn't imply ROM BAR
          * is mapped into guest p2m) if there's a ROM BAR on the device.
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Tue Feb 15 08:21:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 08:21:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272821.467782 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJt5C-0002W0-CO; Tue, 15 Feb 2022 08:21:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272821.467782; Tue, 15 Feb 2022 08:21:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJt5C-0002Vt-7g; Tue, 15 Feb 2022 08:21:10 +0000
Received: by outflank-mailman (input) for mailman id 272821;
 Tue, 15 Feb 2022 08:21:09 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=p95L=S6=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nJt5A-0002Vn-Sk
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 08:21:09 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 37b9e69c-8e38-11ec-8eb8-a37418f5ba1a;
 Tue, 15 Feb 2022 09:21:04 +0100 (CET)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2050.outbound.protection.outlook.com [104.47.13.50]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-10-PRsB4F-vPz2H7CfvJ6Nllg-1; Tue, 15 Feb 2022 09:21:02 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DBBPR04MB6218.eurprd04.prod.outlook.com (2603:10a6:10:d0::17) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Tue, 15 Feb
 2022 08:20:59 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4975.015; Tue, 15 Feb 2022
 08:20:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 37b9e69c-8e38-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644913264;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=SdWll0s2w6gn4R868nKe436TBPCowh3uC9PzT9pyfFM=;
	b=ncy6nuIxJPKVqvHjJ6OHZaGJs+MfWL32b1mWDz1Dh348gSlGC8L81mke1FY6Y11ibOFKp8
	WIKwD91N1lZpVPDvL88tjLb4mBk9APJc+mhEHgJ9Bkuonzm+OOLXJxFzt6AKPuaf+sRwdK
	vzs5HXQijnRorE+8YfAOTr3WGinDFBs=
X-MC-Unique: PRsB4F-vPz2H7CfvJ6Nllg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jbnFEE3xMRsgrxiFgairOMhn0mbdpOQH2Oek+3RLF6MFSxciEE9YdW2xMl2UkqwJF3D0VtwbW3ThbEoru0sJ/DHRrispkQFcKtYmcWQprVeXWCd7e+S+DkZW4J+rrOaxvUe90r2qKLqiJYCycXp3k56K3bms49M+K1zrpA5dzsMWJMEokGNQ9JPoEKYBJD6PrqOSKgCR4mLCTiUz/+Lfnce1UhAqTGN1JYr1aaQqM4Qr3yvjWyZTlBhzVJTbWIDptHcpOHlC+yP7Tmz1sfoi/nKkWaintYWesbT/g9ISy7vxtjkL1hk3ecWkyZcWkGrR6RuXDlJgUY4659t/mJvMSA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=6F4Vp0W9+D1r9cTHm9jz9B/KGprdwL6D5iCqew7qx7M=;
 b=OveUZyWIL/Zg85ZrEFEj7xVUeKMfhzzomZB3u0/DJ6mJ5e+Lxn6Udh3pIkZcPsihrztv+BB7109rAS6Xqyt1qXwG90SwsgAQRi19SCDbFbvN9PZwD3uGmx8Xp7ODF9bZaW+1n6iGpiVE3UVTHd6faOTtJcHu1wOq825zNaAVTEGoQ4EXTYvYJg72HAe+I4T1AQIGTYsRjz1A9XzZqowSajmKEbb+Oap/RMuPZ1KMjnyPfpnacjXSu9f4SE6ZPBgm4B8pbPgHarw/Z3kL0w851aj4t4xbNFQ6zP7GnKR8zoxi00Hpw+esEs1AVZL2Exr7gbHhMhqpsHarMEB6zQNNhQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <0bfdf348-8ce3-0f22-d28b-993ddc7242d2@suse.com>
Date: Tue, 15 Feb 2022 09:20:57 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH] RFC: Version support policy
Content-Language: en-US
To: George Dunlap <George.Dunlap@citrix.com>
CC: Ian Jackson <iwj@xenproject.org>, Committers <committers@xenproject.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <Andrew.Cooper3@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
References: <20210813113727.6028-1-iwj@xenproject.org>
 <de32c6c4-5ad5-862e-3988-0e7310ec3ecb@suse.com>
 <C6A7B444-4CFB-43A7-8FA8-AD1049F83912@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <C6A7B444-4CFB-43A7-8FA8-AD1049F83912@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6PR10CA0085.EURPRD10.PROD.OUTLOOK.COM
 (2603:10a6:209:8c::26) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 8744999a-700a-472e-e2ae-08d9f05c18c8
X-MS-TrafficTypeDiagnostic: DBBPR04MB6218:EE_
X-Microsoft-Antispam-PRVS:
	<DBBPR04MB621890DB43F96366CFBB4CF7B3349@DBBPR04MB6218.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2733;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	UN1uMsYHyvd1LcczBvpH/irg/M+HklbQTVatI/3PvjUfHC3UHcRuUoJL/wtSwCdpRUtR/iEeGgrbCMWUteMcAS8gPjzBbfDcUxu+mpC32JI8oTm2ljAerOs55v2p3+xDw/IWbPmiubbjxGtI+SoTOoudh269Gwm04uIS0kbG3HO79qE19jwGh979I2rr9gHACPLQaixLE0eILQboZviw+6m76iCaXPo7qyBdX7A/Hj5hWHi086HaKc/0W8uC5YptPolmmLl3/grKtZG+zcflKWaTrEF89ILCIWgHtk2WZj+12SwmZbVfDPTubM5NjxXCHnhnamQulXEIeSEgcYFbZbGA9VLyL5RKAsJ86gC2tppr0du45tmjV28E2Scz7RK98wQU04LuGnID6Vg0A9C0JDON9cL5WwL1pzlbbBq13/05WAFpIgn5mIH8WRWam48Zg3SKfxUYIEw/tkZGqup+NhQz3N2hOVpzPPww4O1QwImjDWyGnevD/rxu0snwi1udkq79Q8DcJLOp9fQPjdnkm7MgnIpiveNuGBM+EEeEDFmuTs6hENzP/xcrxBsdW1Qg1kC1J+MrImqleqsJLHietsoEWqdQ8rbR/7rLtI/UkFXXg3UJpGzcpYqC2IaEVzHecnD10hemGZK43Mf8GfurIxmdCEo3yxVFM0J3ncg8+roDY4zSv0HYaYJu5b9SXWmCagpa7Fna0NTw3ZkHRqnwOkN09aM74y7Xi6RA7x2wdtw=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(508600001)(8936002)(86362001)(53546011)(316002)(6486002)(54906003)(6916009)(6506007)(4326008)(66946007)(8676002)(66476007)(66556008)(2906002)(186003)(6512007)(83380400001)(38100700002)(31696002)(2616005)(36756003)(31686004)(5660300002)(26005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?Iv3zzhmu3thxwdvUj4L/KP8AvLJYeVOSmNi5Ou3EdnKC1VtsuC7hmGeLh/8y?=
 =?us-ascii?Q?0dE0moRtFN70or7Y0IDpNYgAGLevdDesLJNyqDXrkBEmYje/XCUVPRFQsGmc?=
 =?us-ascii?Q?zCqmUvK+lqXbLU4tJZKFjX2qtSEzctBnHyCDqzp5nZun4aqs0u8dVLmuiw+H?=
 =?us-ascii?Q?nycNT2IGpDFshYa/zIo/bOZKcMRmgGDLCZ7v3BdV15LW8auTHPZk60qPrWjC?=
 =?us-ascii?Q?+M5z94HRByhZyFWLZC5yOY484mgHcCEZnR9C1Y2Bnj3M90oHtR458om0SweE?=
 =?us-ascii?Q?kyYegv5ROAohCwiyTNM3RYd4Nc1zq7ohP9ib7rp0KWz69/pQCOXF/wiOvemn?=
 =?us-ascii?Q?ZBHHdqTrd+FQEwi9bYudbMfys212R/HxhJT7C1DXAWdV2SboJ5ldtvVaYx+Z?=
 =?us-ascii?Q?VVOCEe9oeUBMhdWY54m4+or6W4o/1AjWotME9sRnaR8/nN4+/A6WMc4GRhg9?=
 =?us-ascii?Q?0TLziAKKjryYhUZBtJubuagecPjyQDf7oeZSKf0MHUSoea8NJxSB22XmSZYl?=
 =?us-ascii?Q?kxy8c3ObwpgAH8waYfdimVBj40o8YG2HzpIvwwQdxL0lKmJz5Ef2Oy4vm1Vj?=
 =?us-ascii?Q?joiNYgzUr8fhSbVqEaM4tEPvXCJLsakjIWe/iYkQqqe0uk0MmQIV42cGC4aI?=
 =?us-ascii?Q?gI7lnVVJFdK54MERzbBumDyf+ZK2wuEp9xoYr9odPxIwj3/gr6ZyaBnkhsVS?=
 =?us-ascii?Q?QGH/caZLfV84XZwLnfOgHbdRJwhZraX2LDaAYzbwy+QggBFTCuTnqjAVzwJr?=
 =?us-ascii?Q?/C6BUadOG1/W4AT/x6cABYgXEYA5tr458NBaltPn9MMc3n+CIWiqpIXum3Uo?=
 =?us-ascii?Q?Xr4a/9D4gmRbnO4Gf5UR7KBSjel/pVKe/YZlWxAJcTZlrtrdvBqzhmyesPSR?=
 =?us-ascii?Q?BQMpheJmxyDbJCcmy6Q5DUObyeauCQLsdhLzJPU1JxEzD3dlsNu47sqNiOIT?=
 =?us-ascii?Q?D2Ec9oBSKFW8sODN7XIIdsuYd810MQzJuXakeBA6AGgq9khkF3gl42lrZy/J?=
 =?us-ascii?Q?qmzlFVnmYzAE1MC+o7t9JGjzCSduQNBXsEl4friga9ZqTvNvDVhyJ3eokjG5?=
 =?us-ascii?Q?6UgrSTVLdJofvS+lu18oQDz4WoLWRw2+n7Nzf76BRMD7BcSEeMjc89b8vyji?=
 =?us-ascii?Q?fuvABO7HkQ0wpIWDwoaFJ0s8+jDMdOTs/sw/GfTBWIX9eCjkydZQEtYzU1Fw?=
 =?us-ascii?Q?2ZqKM7vsQMbJShRN/E0JuBJSA27zkHqxhWQCtKjDBCPDzyrljSVAjAh3LlCv?=
 =?us-ascii?Q?W0n1bfZ2BbyY1w0Anv0+sW6M0rHQmTNPBcZBnqn6BmFsXGS7zkoNKXpMOBsh?=
 =?us-ascii?Q?XhVfYzeNiIUOGeau84KPv/ZeHJFx4ZWZTlj/gl+ar/tLQQBwXD74ZGqAVkrI?=
 =?us-ascii?Q?+vUY2lT1XMWRKB/DrRzfJdK5SPY3XWVYJDiN+U6jjFBvGqKlXTE36thOPn7s?=
 =?us-ascii?Q?X9RxJGLMNOLgLD7hNKeaSnBgBvIaC4KaLx6nHJ0ZC3G3Pl7ExIlH+X1AU8J1?=
 =?us-ascii?Q?ROCC6hJvD2aphFHe6x91votxWs56ckxx0LBbnoCg47cUix8hXLgQFnNhnePj?=
 =?us-ascii?Q?ofalNIrN2/WR7ogYnUvKR0byk4fBVUgcRjEqTjSl0swEXH3obeqXLPmgBKDV?=
 =?us-ascii?Q?eAnq71l3/WcllGmOdx38nS4=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8744999a-700a-472e-e2ae-08d9f05c18c8
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 08:20:59.4361
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7p82ZFkfBTAgnjIDSp8anh1ark+iVA++A+sjgycSviiro6XqJPZ//TiL/glPOxun34yKvZmjnUBSnASmGyCPLA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB6218

On 14.02.2022 22:50, George Dunlap wrote:
>> On Aug 19, 2021, at 10:18 AM, Jan Beulich <JBeulich@suse.com> wrote:
>> On 13.08.2021 13:37, Ian Jackson wrote:
>>> The current policy for minimum supported versions of tools, compilers,
>>> etc. is unsatisfactory: For many dependencies no minimum version is
>>> specified.  For those where a version is stated, updating it is a
>>> decision that has to be explicitly taken for that tool.
>>
>> Considering your submission of this having been close to a glibc
>> version issue you and I have been discussing, I wonder whether
>> "etc" above includes library dependencies as well.
>>
>> In any event the precise scope of what is meant to be covered is
>> quite important to me: There are affected entities that I'm happy
>> to replace on older distros (binutils, gcc). There are potentially
>> affected entities that I'm less happy to replace, but at the time
>> I did work my way through it for example for Python (to still be
>> able to build qemu, the community of which doesn't appear to care
>> at all to have their stuff buildable in older environments). The
>> point where I'd be really in trouble would be when base platform
>> libraries like glibc are required to be a certain minimum version:
>> I'd then be (potentially severely) restricted in what systems I
>> can actually test stuff on.
>=20
> The question here is, why would someone running a 10-year-old distro that=
=E2=80=99s been out of support for 6 years want to run a bleeding edge vers=
ion of Xen?  I understand wanting to run Xen 4.16 on (say) Ubuntu 18.04, bu=
t who on earth would want to run Xen 4.16 on Ubuntu 14.04, and why?  If suc=
h people exist, is it really worth the effort to try to support them?

I do this, for the very simple reason of wanting (needing) to be able
to test a large range of Xen versions all on the same small set of
hardware. Internally we're still maintaining versions back to at least
4.4; upon customer request we (I) may end up needing to even play with
4.0.

>> In addition I see a difference between actively breaking e.g.
>> building with older tool chains vs (like you have it in your
>> README adjustment) merely a statement about what we believe
>> things may work with, leaving room for people to fix issues with
>> their (older) environments, and such changes then not getting
>> rejected simply because of policy.
>=20
> Yes; I think the principle should be that we *promise* to keep it working=
 on the currently-supported releases of a specific set of distros (e.g., De=
bian, Ubuntu, Fedora, SUSE, RHEL).  Working on older versions can be best-e=
ffort; if simple changes make it compatible with older versions, and aren=
=E2=80=99t too burdensome from a code complexity point of view, they can be=
 accepted.
>=20
> One of the issues however is build-time checks.  If we have a build-time =
check for version X, but only test it on X+10 or later, then the build may =
break in strange ways when someone tries it on something in between.

Well, because most people only test on "X+10 or later", is has been
frequently me to run into issues with, in particular, old gcc versions.
And I've been making fixes / workarounds for those. Hence I wouldn't
consider the full range entirely untested. Obviously not every version
in the range would see testing, unless we specifically arranged for
doing so in, say, CI.

> I think it=E2=80=99s too much effort to ask developers to try to find the=
 actual minimum version of each individual dependency as things evolve.

Hmm. On one hand I agree that it may be a lot to ask for. Otoh I
generally take the position that it is okay for advanced functionality
to be unavailable unless certain dependencies are met, but that base
functionality should be provided (almost) indefinitely far backwards.
I did add "(almost)" because I think it is fair for a project to draw
a baseline at the time it is founded. No-one would expect Xen to be
possible to be built with K&R C compilers.

Beyond that raising the baseline for any component needed for building
needs to consider how difficult it is for people to meet that new
requirement. Speaking for myself, I find it acceptable to build certain
leaf components (binutils, gcc, make, etc, and I've even worked my way
through building newer Python), but things get more hairy when e.g. a
shared library needs replacement. (Prime example of the latter would be
libelf, which Linux'es objtool depends upon being a half way recent
version.)

>> While generally I find Marek's proposal better to tie the baseline
>> to distros of interest, in a way it only shifts the issue, I'm
>> afraid.
>=20
> What do you mean =E2=80=9Cshifts the issue=E2=80=9D?  You mean shifts it =
from versions of individual components to versions of distros?

(Half a year later I first had to go back and check Marek's reply.)
Yes. Individual component versions would then be inferred from distro
versions. While I don't know how other distros handle this, in ours
parts of the tool chain also used to get updated during the lifetime
of a distro version (where I already mean to limit "version" to e.g.
service packs). For binutils typically by simple replacing the older
version, while for gcc typically by making a newer major version
available as an option. In such cases it then of course becomes fuzzy
what the "distro =3D> component" mapping would be.

> That=E2=80=99s why I think we should support only currently-supported dis=
tros.  If the distro=E2=80=99s maintainers don=E2=80=99t consider the distr=
o worth supporting any more, I don=E2=80=99t see why we should make the eff=
ort to do so.

And "currently supported" ends when? After "normal" EOL, or at the
end of what's often called LTS / LTSS? For the latter case: I've
recently learned that we've gained further sub-classes of LTSS, with
different life times.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Feb 15 08:30:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 08:30:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272828.467793 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJtEH-0003xt-8R; Tue, 15 Feb 2022 08:30:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272828.467793; Tue, 15 Feb 2022 08:30:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJtEH-0003xm-5X; Tue, 15 Feb 2022 08:30:33 +0000
Received: by outflank-mailman (input) for mailman id 272828;
 Tue, 15 Feb 2022 08:30:32 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=vySV=S6=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nJtEF-0003xg-V6
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 08:30:32 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 87980c30-8e39-11ec-b215-9bbe72dcb22c;
 Tue, 15 Feb 2022 09:30:30 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 87980c30-8e39-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644913829;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=tDllKgtO2htz+ZZHLYCR6A0+9x4NhEnUsKsvjNLx9go=;
  b=WOUzZC97fSA++qsCJgmMw+SRin0471dnGNTybUO2w2Tk8hO/v5BRWwMR
   sPPEvpbyPg7wuyYhTxybKCdh4mOJKr4bgw6sfflB006qpCedmv50QcT22
   TGERRU6G/rfFSuMJjiBdFkJFRRju8Syo73eS+6bnXpnih/wF6APoAg64J
   4=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: JfIZVh2G5jJgY+68ig1bYOe/tOWHVYTQneVklUb6cZL7osaif+ZxT4JJrLsGFYUMM8TERaLrY/
 6s9ctO8TUsg2ypJDwekYZr3wMxbr/gj6wxvelsiHC3eO7RK7MHbwrml/ccYjczgRjkQMFWudap
 +LJOrf+2/CJNAW4ry+VcMY3r69kRHJ1NdE6DvyZaZuCibKWo2aau5G01nKVCtIeMWW7u4v/7ur
 qiXE1t59uoZG4jcwup3vpfw86KuucT+fMi2RsDfKvzMcHOmq4NCA7sZDMvai6GRb6lDogJUq32
 gCQkRvX0DuFSM3ETFqQFdpc5
X-SBRS: 5.1
X-MesageID: 64121692
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:8bbmTa1CDG3V9vRRJfbD5dt3kn2cJEfYwER7XKvMYLTBsI5bp2MPx
 jBOUGmFbvveNjD2ft1/PoSzpxwEsJbcmIJnQABkpC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkS5PE3oHJ9RGQ74nRLlbHILOCanAZqTNMEn9700o5wrNh2OaEvPDia++zk
 YKqyyHgEAfNNw5cagr4PIra9XuDFNyr0N8plgRWicJj5TcypFFMZH4rHomjLmOQf2VhNrXSq
 9Avbl2O1jixEx8FUrtJm1tgG6EAaua60QOm0hK6V0U+6/TrS+NbPqsTbZIhhUlrZzqhusBjz
 9tGlaSJbB4JD5XqwvUTTAFFOnQrVUFG0OevzXmXtMWSywvNcmf2wuUoB0YzVWEa0r8pWycUr
 6VecW1TKEDY7w616OvTpu1EnMMsIdOtJIoCknph0SvYHbAtRpWrr6Diu4MBhm5u15om8fD2a
 s5HbzZ1aDr5eQx9Gmw9MJIUsd2FiSyqG9FfgA3M/vdmi4TJ9yRP17zqPMvQa8a9b8xflUaFp
 UrL5238RBodMbS37j6I8WmlgOPVqh/qQ4IZFLC+9flCjUWawyoYDxh+fXKhvfS8vWuvVNteJ
 lI89zInqO4580nDZsP0XwC85mWFuBEcc9NKFqsx7wTl4qDZ+RqDD24ICDtIcsU7tdQeTCYvk
 FSOmrvBBzZirbmUQnK17aqPoHW5Pi19BUgGaCwfRA0J+e7Kpo0pkwnPRdZuFq2yptDtEDS2y
 DePxAAuirNWgcMV2qGT+VHcnynqtpXPVhQy5AjcQiSi9AwRTJW+e4Wi5Fzf7PBBBIWUVF+Mu
 D4Dgcf2xOITCZCAkgSdTeNLG6umj8tpKxWF3wQpRcN4sW3wpTjzJui8/Q2SOm9MItQDdzTJW
 Hb2oCNg3LkJLXW1dbJeNtfZ59sR8YDsEtHsV/bxZ9VIY4RseALvwByCdXJ8zEi2zhFyzPhX1
 YOzNJ/1UC1EUfgPIC+eGr9FuYLH0BzS0o86qXrT6x28mYSTa3eOIVvuGAvfN7tphE9oTei8z
 jq+Cydo40gFOAEdSnOOmWL2EbztBSJlba0aU+QNKoa+zvNOQQnN8cP5z7I7YJBClK9IjOrO9
 XzVchYGlAag1S2adF3TMSoLhFbTsXFX9yxTAMDRFQzwhyhLjXiHsM/ziKfbjZF4rbc+nJaYv
 tEOetmaA+Qnd9g00291UHUJl6Q7LE7DrVvXZ0KNOWFjF7Y9F12h0oK1JWPHqXhRZhdbQONj+
 tVMICuAGsFdL+mjZe6LAM+SI6SZ5CNDxrsqBhGQfbG+uizEqeBXFsA4tdduS+kkIhTf3DqKk
 QGQBBYTv+7WpIEpttLOgMi5Q02BSoOSx2JWQDvW66iYLy7f8jbxyINMSr/QLzvcSHn16OOpY
 uAMl6PwN/gOnVBrtYtgEuk0kfJitoW3/7IKnB55GHjrbkiwDu8yKHexwsQS5LZGwaVUuFXqV
 xvXqMVaI7iAJOjsDEUVeFg+du2G2PxNwmvS4P05LV/U/ihy+LbbA0xeMwPV0H5WLadvMZNjy
 uAk4ZZE5wu6gxssE9CHkiELqDjcci1eC/0q78hIDpXqhwwnzkB5TabdUiKmsouSb9hsM1UxJ
 mPGjqT1mLkBlFHJdGA+FCaR0LMF14gOoh1D0HQLO0+NxojenvYy0RBcrWY3QwBSwkkV2u5/I
 DE2ZUh8JKHI9DZ0nslTGWurHlgZVhGe/0XwzXoPlXHYEBb0BjCccjVlNLbf5l0d/kJdYiNfr
 eORx2vSWDr3eN38g3kpUkl/pv2/FdF8+2UuQix88xhpy3XiXQfYvw==
IronPort-HdrOrdr: A9a23:kSfH9a1WODI2eLdjJh2bVgqjBVByeYIsimQD101hICG9Lfb2qy
 n+ppgmPEHP5Qr5OEtApTiBUJPwJk800aQFm7X5XI3SJzUO3VHHEGgM1/qB/9SNIVyaygcZ79
 YcT0EcMqyPMbEZt7eC3ODQKb9Jq7PmgcOVbKXlvg9QpGlRGt5dBmxCe2Cm+yNNNW177c1TLu
 vh2iMLnUvpRV0nKuCAQlUVVenKoNPG0LrgfB49HhYirC2Dlymh5rLWGwWRmk52aUIE/Z4StU
 z+1yDp7KSqtP+2jjfaym/o9pxT3P/s0MFKCsCggtUcbh/slgGrToJ8XKDqhkF/nMifrHIR1P
 XcqRYpOMp+r1vXY2GOuBPonzLt1T4/gkWSvmOwsD/Gm4jUVTg6A81OicZyaR3C8Xctu9l6ze
 Ziw3+Zn4A/N2KOoA3No/zzEz16nEu9pnQv1cQJiWZEbIcYYLhN6aQC4UJuFosaFi6S0vFqLA
 BXNrCc2B9qSyLbU5iA1VMfg+BEH05DUytue3Jy9PB8iFNt7TJEJ0hx/r1qop5PzuN5d3B+3Z
 W1Dk1frsA6ciYnV9MNOA4/e7rFNoXse2O7DIvAGyWvKEk4U0i92aIfpo9FoN2XRA==
X-IronPort-AV: E=Sophos;i="5.88,370,1635220800"; 
   d="scan'208";a="64121692"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=mqpfXmareJtaIOketMri8T5y3/h/EKv+3P9Z3UxO8OjQAXiZRzw4e+RdMA+WzvTq9tS3/+bXKW3xZ6/QHKcfzd0BzkGJkng9/pB9/occJmfqF/exS+VI4KHjWLaUsM5kBoB+Y6d/wnGr4/2tPKUX2OShTuwSABHPbfaoY9E5ltOPtTmmf3fm1UD8uOgPtneh6/fP9PAAqcrySGGIzyv4mB2JIVy76DO5Vjq5IiEVrWoEeiiNsNevklutQP3VVgtgPfwfZxgUseoaKcZD8mr7HQXguPN7Y3Yg/fxD6kNR8RKnnwAnpor2KA+S27eoyo8v7ucoNR1lEYWgTho+VocURg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=tDllKgtO2htz+ZZHLYCR6A0+9x4NhEnUsKsvjNLx9go=;
 b=CWAlmNA5BR2EjgReYeNyB6FbSprY7BQDpGcl7nVpaZSk0oc0jaZL+dgFQknTi4pkmJyufiaBdZd6m7Fc/86EwUQjaXmrm+dYqtUbSh9EBn0HzsyI3vop2TCfGDzAfvqVhjseBb9sb8+0RJdl5hOoqPDUoJ7IpmSFCR905q5op+TOWYgXfVfvlA946hwglpTw84O1ibZBXRZnQjkJHBXwLm9UsNsnvsZk2dP8I7AuV/gNK/GAgpmROJVj3kXcRbwR8nWnt4FB2rlSlazYPnm2wcD8Pndvhp1y3MPNPrBX5ApmIiEJ6O5y92+1fFgW5OVr7E7rUe4bs1vsuum5e/GEiQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=tDllKgtO2htz+ZZHLYCR6A0+9x4NhEnUsKsvjNLx9go=;
 b=Gc2q5VeWE++X3qHgCX0P15isIWmupe43qbqcTfnY57M3rl/0Xs/cFR0pCKraaVDBvlCj4H9t+V44mr4XJNDW3KIjdYCGjoeyhuLM8MSgQZY1pdjgYPejwE2grtIJcmwxKT/Dbx42CS/Qvn/sDiRATsNivy1IHqYUHAhWUObM+A4=
Date: Tue, 15 Feb 2022 09:30:08 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "julien@xen.org" <julien@xen.org>,
	"sstabellini@kernel.org" <sstabellini@kernel.org>, Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Artem Mygaiev <Artem_Mygaiev@epam.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>, Rahul Singh
	<rahul.singh@arm.com>
Subject: Re: [PATCH] vpci: introduce per-domain lock to protect vpci structure
Message-ID: <YgtkkAoYZ3MZsygD@Air-de-Roger>
References: <Ygo40L4dMPJjZKRF@Air-de-Roger>
 <746860aa-c403-1eca-0a75-587c5d10c8c2@epam.com>
 <Ygo8M3Y6BLzljn15@Air-de-Roger>
 <114b8578-ee13-b67d-e282-d060187ef509@epam.com>
 <06baf0c8-d7d2-50b8-ea8f-1d422ceac728@suse.com>
 <6ccc7add-c13e-555f-b341-ce37118746e5@epam.com>
 <f0e202dd-1f6e-4aac-1381-a64a7fd12270@suse.com>
 <ba901778-ce63-12f2-0a54-d56998090200@epam.com>
 <3538350c-0a63-59fb-7bba-fe460c0f1607@suse.com>
 <2a750ae8-9ca7-2e74-b878-11b98fcb4ca0@epam.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <2a750ae8-9ca7-2e74-b878-11b98fcb4ca0@epam.com>
X-ClientProxiedBy: MR2P264CA0087.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:500:32::27) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7273e851-974a-4bfa-f9a3-08d9f05d637e
X-MS-TrafficTypeDiagnostic: MWHPR03MB3086:EE_
X-Microsoft-Antispam-PRVS: <MWHPR03MB30860A52777E6076DBE6CFBC8F349@MWHPR03MB3086.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: igkuHcnu7PbpjaLj14PfakIxbpX35U1kcRmlbMPd/UakmA/Au7AIXyQdTHMQ22xvML3oKFqqmZCK1mOJdas1uozO+d0sMt+SatbwZL/A7vuQDNJNlL+LS3a+lrXxpKO0ZGi2uxnnOOyS/HNuuspE+OGwJAbkf02weoJ/PmpMnIPT83CnzcPAK9wIZJ0s3cX7Zr2YvUkbC4I6BUGJZeoLOT5OLaSL6MOR8ep0Ulrc9gmXoYWcKZ9XHP8MD5a4qOKOGfXW3EbZyB0ilr/XBfALJt+XxBTgAdBec+mrTYKR+osKypVUEkA214K09qxqYFRhxEj+zTGJw/QKm4ldPJH1lsC1NRewTAYUA/o2XqKEKmzv4ovySM7Sk/CkNNwrPalQv+1Phnn8ejzt54veoXgGzcm5JpE35mwjbGl+evXDz+0ABnnwT2VI3F3sauOchI/F3kAF0b8w/a8V4OE2+3wJj45tr5Vp/9jFQB+6s31aCZ7XEgCF0iXq5+ReVRtNCECoGNfVdKlUeqr7MeYoKl9tkmC7mpYzph5kYmkZvMTT7VYtYie1JSyUUxp+kh/YANScYqeCmYBE/QmRZiY4ypM146qD/OLh/m4Gpl/4m4lnAxhRfsoqkfjFmT4d4wXPk6g4PSbsxeUdshNdn1rEJP3Lvw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(6916009)(186003)(508600001)(26005)(6506007)(6512007)(9686003)(83380400001)(85182001)(54906003)(33716001)(4326008)(2906002)(82960400001)(38100700002)(6666004)(316002)(66476007)(5660300002)(86362001)(7416002)(66946007)(66556008)(8676002)(6486002)(8936002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TVU0ckxGYVdhMHBnZHZyNSt3QXJQN05DKy8yNk5CVDRVSWVyR3hyYnljektx?=
 =?utf-8?B?U3I0T0lLMG1HN2RRQ0U4cmY2NzJEempnVmpoaktOY0o1WHhRNk5FL000U3c4?=
 =?utf-8?B?YVdBZzhLeDRJK2RaUlJzeDFIL3JNRTlHZGIrQjNjbTdRR09PLzEvR2ZBSzBa?=
 =?utf-8?B?NkpjMlp4L1NkK295WTZ5bDVTL0ZIeEM3SjdwYVJ5ZGJxYktCRFRoSkxWT1hZ?=
 =?utf-8?B?L3NSd0NXQU11anhEZkVMYTYzY0NsWkdYN2oyNmY1cU5Pd1Q1eW1CbnNzQkZ6?=
 =?utf-8?B?eklya2xPQVdIY2x4T1VnVzRUYWRsV3ZtYjhQeHJKL1ZVVFdJN1VYL0VHeCtY?=
 =?utf-8?B?YzF3alpwa29XR3hBZFhRL3huRVVhaUh3WlowdG5aMHN1Q1ZXaGtBMENaamZr?=
 =?utf-8?B?K1RRakk4S2lMUjdJcXR3WTdybE1VdHg5WFNoMEZGQ3NGaWtUdWs1M3lhTEpT?=
 =?utf-8?B?cTBWeG1NRmtoeXh3QXg1cVNoNmpsaGNzY3lGU2NKcjBOWTY1U2FsaVpNVnVm?=
 =?utf-8?B?T09rQU9iYW4xbkRZaXFuYnpiNk9zaU41VysxYTl0Uk12TDZuRkhiRzduOG93?=
 =?utf-8?B?YmpJR3oxaXZ5MHlnV3ArQ1lYbk9OcnNqS2lnOU83d2t3Uzl5ZUEwbVF0QlpU?=
 =?utf-8?B?ekxtUzM2dGR2N3p2SU9EK0pWZzZQY2ZsZ0VjYzFiRzc1dUVtRm1iUTB5UWVE?=
 =?utf-8?B?R08zUC9IWGZmRFBZS3NiQjRjMWtaN0FFMGYxN1NFUGl0SVR2TUV3VmtHbkM3?=
 =?utf-8?B?ZUNha1d5RHdyVnZQb3JnZ3ZvSzQvZ293QkVOV0NCT1VvOUxvNnZmWkRPcXZ2?=
 =?utf-8?B?WENhMUgrSjdXZzlYZlRSSytvdkhCejBiNGg0M2NuOW9xRTVQVlJpNHJwMytR?=
 =?utf-8?B?bzdrTk9CaEw1aE8zdkdKN3dkOGUyZTV1RWwvK2xSTXZpdEhhT0NUcWd2SE1m?=
 =?utf-8?B?cFY3dXVlbnlvY3A1cWVuUW1JUVFDSytuNXNla0xxN2ZwNElsRDFIL0VnTnRO?=
 =?utf-8?B?TWNSZ2pnQTQ4eDcvc2pPYkhJT1RDNXhwd1pGeVhTcFJnKytDTkJqTGNyMG0r?=
 =?utf-8?B?ZHVybGg4b1dUbE9HY3pJVTBGenFPZnIwV1pnMVVIMDRZc0pwK09nbHVoRjZY?=
 =?utf-8?B?c3BOMzcrcUd0SW1hYkhJQ2R1Z0JFSVR0L2xweHpuKys0Q3gybWhOejRyTE5T?=
 =?utf-8?B?RUlhNElibEZ3V0h5R2ZVcG5yTlRZODlOV05WUXdUekN6RUZLN1pCM0tLcGxq?=
 =?utf-8?B?RzRWZnB0WWJnU05EdndxbnFNVjJPWWQ4RFJuQkJsUzA5WXJYeXYvc1QwVG5C?=
 =?utf-8?B?MlR3cGdVeHVld3EzUEgxakVSRkk4QTY2RGg3KzZsQk5wbW5BWGdnNXRNdTZ0?=
 =?utf-8?B?RkxQQVFnekdFaU16eUpGQVNtOU5BU3hXT3R4YnM1WWI1UGtwQ29JS0Y0SG11?=
 =?utf-8?B?a2dTOTBVNUNCT1pyUkEweXJjeVJJWm5SSDdqODhwWm9rZktJVEJLaXQwejl1?=
 =?utf-8?B?b0hOc2lYMGN1QWhnaGppNlhoUHNXbXVsb0tFZFMxdkNIa0RDYWhVNDRRbnRR?=
 =?utf-8?B?ZDJ2WTRIT0F3ekFLVmMxNjI1RVhtTzl4UGd2Smc2UTV4WGdsUUp1UUo4WVpU?=
 =?utf-8?B?bDZEYTV5UGVnc1ppU1BmNDREb1dBYXVpeEdXcE9BQm52UHZ2NXBFcTJwNVRD?=
 =?utf-8?B?U2lJYVR1bHVFSDRVNEFWeE1oakNaaTVTWEZWM2JqYnNpN3Z0WHVMbVIvMWM5?=
 =?utf-8?B?NS92WlpLMjhwdkVWbFFXbXdheHkzSjJkbThqYjZWRTRXNkVONDhDQjdRRU9Y?=
 =?utf-8?B?YWpweDVXaU80UGhwdVgzV3VyYm9qZUlLV0pqczZLVldPbFJHWjZVOVA3emsx?=
 =?utf-8?B?MjE2aS9ocmJZZGdUMzltV2lzNll0TlQ5Q3ljaVl3Slh6S1c1V2lIK3VWWGJF?=
 =?utf-8?B?K0ZRbVFFTXpLckZqUHBNNVFuKy83VGxWeGk3M08xeGpnNGRPZnpzeENON2hV?=
 =?utf-8?B?a0Fkb2UvbExnVnBpaGVBaWpXdDQyd3o3Y0R0ckwrS1d2M3lBb2JTRmlLWGQ3?=
 =?utf-8?B?cHRUVkJyVWttWUNnTGlQL1RiQjk3cmxDZ0Q5Q3NZL0RXVmlKeXBuNjZVYjhI?=
 =?utf-8?B?VjJMblNreEkrUkgrdkNkeTFPcWx2RVlubEl5aWRQSW80dGx2TGZWU2tsL3cw?=
 =?utf-8?Q?VPmEsPdCAIXfDyd19DfAnOU=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7273e851-974a-4bfa-f9a3-08d9f05d637e
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 08:30:14.4807
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CH+kmumB26JD+47pkUgL7UY0CHX/6aUoHLfPQSlLGMl9dGS3oKFia/NZVBc6wVdIW5YlIuqpHDgYnl6AAC5rPQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB3086
X-OriginatorOrg: citrix.com

On Mon, Feb 14, 2022 at 02:00:26PM +0000, Oleksandr Andrushchenko wrote:
> /*
> * FIXME: apply_map is called from dom0 specific init code when
> * system_state < SYS_STATE_active, so there is no race condition
> * possible between this code and vpci_process_pending. So, neither
> * vpci_process_pending may try to acquire the lock in read mode and
> * also destroy pdev->vpci in its error path nor pdev may be disposed yet.
> * This means that it is not required to check if the relevant pdev
> * still exists after re-acquiring the lock.

I'm not sure why you need to mention vpci_process_pending here:
apply_map and defer_map are mutually exclusive, so given the current
code it's impossible to get in a situation where apply_map is called
while there's pending work on the vCPU (ie: v->vpci.mem != NULL).

Also there's no need for a FIXME tag: the current approach doesn't
require any fixes unless we start using apply_map in a different
context.

Hence I think the comment should be along the lines of:

/*
 * It's safe to drop and reacquire the lock in this context without
 * risking pdev disappearing because devices cannot be removed until the
 * initial domain has been started.
 */

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Feb 15 08:40:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 08:40:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272835.467804 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJtNQ-0004ds-4W; Tue, 15 Feb 2022 08:40:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272835.467804; Tue, 15 Feb 2022 08:40:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJtNQ-0004dl-1Q; Tue, 15 Feb 2022 08:40:00 +0000
Received: by outflank-mailman (input) for mailman id 272835;
 Tue, 15 Feb 2022 08:39:58 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=xOiq=S6=epam.com=prvs=4045782cdb=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nJtNO-0004df-HM
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 08:39:58 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id da0e68cc-8e3a-11ec-b215-9bbe72dcb22c;
 Tue, 15 Feb 2022 09:39:56 +0100 (CET)
Received: from pps.filterd (m0174680.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 21F8dB8J009294;
 Tue, 15 Feb 2022 08:39:45 GMT
Received: from eur04-db3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2050.outbound.protection.outlook.com [104.47.12.50])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3e87n3ra77-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Tue, 15 Feb 2022 08:39:45 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by VI1PR03MB4272.eurprd03.prod.outlook.com (2603:10a6:803:5b::32)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Tue, 15 Feb
 2022 08:39:10 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::fc4d:4749:5d1:eb73]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::fc4d:4749:5d1:eb73%4]) with mapi id 15.20.4975.019; Tue, 15 Feb 2022
 08:39:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: da0e68cc-8e3a-11ec-b215-9bbe72dcb22c
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=RitoJCT30OOU6dbbw/cVLY6gmnL8N23GOVmoxKORYdlVtJr7Gth4/wISZ+D8waSHuLh3DBCkrRVRUUdiwM4TE4wKV85APqsgjm1DxeumQjLca4+QFL3fvUozzyrppSEcQ201pnYu3XydHcqds4UJmw1axV1OwZb2nhAyO6Pe+qC5uoVIlzi89KBMjnWHiUsA7yvw19+77IpUWBEFoNiTAuOvQ7x16SSq5h6xVES3/TOz4CMlha7rf4vrqyJfUkd81NVfSOkTulHVt08RYD+W3vQ/khH2e/3dNZQkdQ7McEcV3NDtMimUW511G1xW3i/oMbAJ5/2MvBu2BxsQi43GwA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=AGzOZK3P9jyQlgkJZoxGfV7/9NOsCNN2B0DcYqsZgPA=;
 b=EsCCn8zV4p3h/TkJEF28yuQa51tGKFLW+SqDCEBzCAcqLBeQSAh6RmyVukcIbcfWhLMIxssa9L7tTiU04RFX0Hqk98G8PMVSEqC4844DJ388z+whInotEiuO14HI9/wEIuqdVeZWNT5QNMglA3gaWefcWNLvKdsYdKd0DJ8HllZUAzCKAqmZl0+9uKJP882gS9sfcOWidJtgYKlxyrwHJ27Rg1wRKR2Qa/SmYnJR9YTcNyeaBKRu0Y+eQLQizLonKjJjGACC0mktEQbeOxj+2QPIc3nZZGksMFUlKjrUBKc76l2P+nimmSpq7fYACJBARL2+mzga0hmhnHoQ9gYbag==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=AGzOZK3P9jyQlgkJZoxGfV7/9NOsCNN2B0DcYqsZgPA=;
 b=PosxUT+NqX3vBEt+csLFqtEH0Zx0UjUhZuJuN21HjgNqs9obODxeAkUFf1BM2QDefFbumJkNu6mji7dbc8PiWDNmrm0miLd2TrDeEQOG5lOMsSE5QZ3R2V4730GG4OErOVXn0NGU1Md03GNqRoWKNeBCJFZmi/6rrpP29D4o8bMAnQBJq77odsLUvfiynbhIh3V7Vfav2RgNwU2BYztFGyenX3ORDFWPowyVaWIPiX8jnA5Mom+PhGrQYzZhw4ME1+Vy4fK3ENUHU/Nlp/GskMBWKk17Gaz9ZNbw4BYYEYN6sRcx2/Pk+YrK0pFdsGLxbv2QiplSFfS5azDNi1qegQ==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: Jan Beulich <jbeulich@suse.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org" <sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH] vpci: introduce per-domain lock to protect vpci structure
Thread-Topic: [PATCH] vpci: introduce per-domain lock to protect vpci
 structure
Thread-Index: 
 AQHYHboQT3cBWYI1/EGunE7hOwop6ayM95MAgAD+qQCAAEaDAIAElIcAgAAQEwCAAAV1AIAABOQAgAABMICAAALZgIAAAzmAgAAWXYCAAARtAIAAAoIAgAABpICAAAWvgIAAA2aAgAE2DQCAAAKFgA==
Date: Tue, 15 Feb 2022 08:39:09 +0000
Message-ID: <ec0c24f5-911b-e347-ba5b-6535e1f92aaa@epam.com>
References: <Ygo40L4dMPJjZKRF@Air-de-Roger>
 <746860aa-c403-1eca-0a75-587c5d10c8c2@epam.com>
 <Ygo8M3Y6BLzljn15@Air-de-Roger>
 <114b8578-ee13-b67d-e282-d060187ef509@epam.com>
 <06baf0c8-d7d2-50b8-ea8f-1d422ceac728@suse.com>
 <6ccc7add-c13e-555f-b341-ce37118746e5@epam.com>
 <f0e202dd-1f6e-4aac-1381-a64a7fd12270@suse.com>
 <ba901778-ce63-12f2-0a54-d56998090200@epam.com>
 <3538350c-0a63-59fb-7bba-fe460c0f1607@suse.com>
 <2a750ae8-9ca7-2e74-b878-11b98fcb4ca0@epam.com>
 <YgtkkAoYZ3MZsygD@Air-de-Roger>
In-Reply-To: <YgtkkAoYZ3MZsygD@Air-de-Roger>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: e7e5936c-5e16-4791-c2a8-08d9f05ea2eb
x-ms-traffictypediagnostic: VI1PR03MB4272:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <VI1PR03MB427231E4272C59189835EFACE7349@VI1PR03MB4272.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 mrviGQ0c4qg2ZWWsInIGNrdkOPDCqziSTi/sE8joFMVDo5iw6+oBgv4dxmFYnSUheOCds8EsxNDwFHuC8pRsN7kV0qi/wTiPDCr9/nwBpA6pFm/vyY1Y0/HjWsETJapkzRc46VeCoTeOB7kfm7vD99LFHbqs/EoSkgkFsQeFBNid/gF/fWHWl7i++riURiZgdGbcvmWJrkd0hUFf2UEkpNbWrUJ3dpTs7UsAyimUVcAqsSpVCH62TGw7BxeaLAigZcXBJNChiU4h6OsGo98sQrAPjJugSBZRMTivmSz7SWH9lwvtZcEaO57+RddVu548xuPQIfsmAL4Kp7twEjmfkRG98s8XDYnwg/wcH8NiKlYYEj227QE9jML/MJpFt2yJnFuRuK51XI3lcR0rdFOcnKPQttVusEItcGI8Xq0UaLdg2M1aT+H3xJvXT/oWqajWEaWIGcaUTGqO+cwMPtpg0t6uqLazVzPZKyYT2TTkzD/ujquCbk6QFSgu1vFt3fq8Z2UGTn7IHMx9aniZG8nn9GgJNA+SMUs6YaYGJV3PCVTBmS6J0rvF0TouPml2bkLQtqPMI3ep+FgImJk1FjKzvUATq8IQiyPsyfVsaRvyXtR/jVFSqdxatVgw7l7SroyABUC0PfJNt8XIXrJx5OEt+vaxT3BVFvs19S5KvrEcVWRTUqdrN+dyAGI8/KL2fIVmqEx7hBbMwMcbKBKMuXqBrkEp5XR4YzuzSgnjLFbMZaw=
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(55236004)(38070700005)(53546011)(186003)(31696002)(2616005)(26005)(71200400001)(6506007)(6512007)(54906003)(508600001)(6916009)(86362001)(6486002)(316002)(66946007)(66556008)(4326008)(107886003)(76116006)(122000001)(83380400001)(38100700002)(8936002)(36756003)(31686004)(8676002)(2906002)(66476007)(66446008)(5660300002)(64756008)(91956017)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?cTdNUHBpVHpYL1duWG5IaDllTG5lcU0rRWR5MWdVRU5COGFHanNJejlpSXBM?=
 =?utf-8?B?MGo1dTYxc0dMVys1em9xTFQwVWJKMW1OcG11NWxmRDA2cGgrbkpSay9pQnhO?=
 =?utf-8?B?L205WkVYT0hyZENFNzJBcG9oUkZkeFFoUmdSTjlsNWZtMHM1L2ZCR3ZPRWw3?=
 =?utf-8?B?MjRsQTR1d0s0SG4wb1NZckVVQm1UTEJ1aGhONWd1ZHpUUE4rSGxBbDYyeVlM?=
 =?utf-8?B?MVczRzhzRW1rcXdhUWFYbExxVDJiWDB6UjQrblM0M2tIYWZSUFFZUkMrZDM5?=
 =?utf-8?B?emY5U3A4ckxVdkMyTWliT2FuS0VyaWRlT1B1Mm53blRYdTlEbXBoQkZHRXFL?=
 =?utf-8?B?UXpVZDBvSUlCWVkxQXdFN044SEVIVkpiTlYrT0QxYlU1TG1XY3FFZG1sbTVG?=
 =?utf-8?B?Wjh4Nyt0K09jcm54S2drRzcra1k5eE9TcCt4MG4xWkFqQWxLMVFpYzQzYzQx?=
 =?utf-8?B?TXV4ZDhQQTJ1WmFHSkcyVXVvVGhmWWtrRVpCM1k0TlI4c2Q2ZFp4Z1JSS2JK?=
 =?utf-8?B?SytCV3dPMnVmWW5VQm5ycHpleVJxbitTZWh2cUtHOHI2L1dsejd2eXhzd3Y2?=
 =?utf-8?B?SUVzUEY1OXlNdGI3MDBYMlVaajdBWGRhSDVXUW9TZVltQ0RCTk83cWtGdTRG?=
 =?utf-8?B?RDg4cmF0YlRZSHBZN2tTMlN3K09tS2QyRjArUHUxTzR5MXVsSnIwRkUyZFFh?=
 =?utf-8?B?SWRieitEMVd6UGV3V1FrTTJIZWtkWERuQWpDY0ZFWVh3MlhuWDBLUnpEMlFU?=
 =?utf-8?B?VEdCSFQ0NmVUVm5tcnc2TFFWQlhKamc1SzlDRytVUUNlTTZxTXZ1WURUSnRI?=
 =?utf-8?B?R1pJbGFYdEJRdytCNFRIcVpRdkx3Q2kvcjJJbm1tWGFpWU1RWVpBS0F0Mzlo?=
 =?utf-8?B?dG9BczFPbmRzRUEyd2JlSlVVZllvUDh4M1JVelZVakNpaWVGS251VE5WOVov?=
 =?utf-8?B?Z2ZBK0g2OHNJT1dzM2ZhSEJoM1V6SnROUzlSOEdtZ0hWVEczUU1jaW9KVldk?=
 =?utf-8?B?OTVIeU1NZG04S3llei9hMm1KSW50TGpYdEpsWW9lZjZBODNRN0pRQVRjVUdD?=
 =?utf-8?B?RmlQNGFZa3VoRFpEQm4wN054Y29LVGxjMXUyOGFXRTZNSGt3MTVPTjF0Wk9M?=
 =?utf-8?B?UE5QSGoxMlBaUVpYdmkrUERlaktTOHR6Mlp6eXI3L1VPb3k1TTZXaGpDbWo2?=
 =?utf-8?B?QXV5ZUVRemwyOExXM2VVQTQwcFRzUGxrdm5SY1YxcjlWV3dnT0tYRmlRTTBz?=
 =?utf-8?B?Y092dFhyZ2VIcHBCL3pzY0ExQVpCcHJZUHVITU00RUdxalVqSCtpNk9velNa?=
 =?utf-8?B?OEYyS1Bpb2xXajdqN3VJSmZxY0tBS0ErQ05VYWlYSGRkcVloUnF4d1ZwZm45?=
 =?utf-8?B?N1NQVWFiS2Jub3kybDdKUnZiYU9na2ZRdXo5VDJEam1OQjh3ZEFwd0FsWDdH?=
 =?utf-8?B?aDFGUE5IczFmSWpHZm1EYnMra0NpdlhwU0xNRkRJMGtrc20zZW9SNXBZVWFL?=
 =?utf-8?B?WVJibzZwOE5CR2krSmtNOGhNWDJUaWpsTjBXSmhFbG5jMkhDbEJwbjdEL2sv?=
 =?utf-8?B?SDJ3ME1Bd1ByenB2ZDUxbWFORk43UWxGRU1YaWNtOURrUlJUUWNkYzczdnpW?=
 =?utf-8?B?Y2tjK3FUcVF1L1haMmdXam5CT3kyN0l0ZlFlVklwejFOSG9UMVZDQitFb0xY?=
 =?utf-8?B?dllOM2pLNGYrTU1MUG9lL0JCaVVwNXF0Vjd5dnVCY0hYcXN2YkpzQzI5czVs?=
 =?utf-8?B?VjlsUzBGZ1hpNkx2UWZUeXlhL2doUEVFU2xYd1JhNHBHbzFxSm9lQmgzTFFN?=
 =?utf-8?B?U1JlYmlGMitsTXdvUElraTRLR0tIY3dsTWFoY1hyZXU2L2VPcGlYQklwRC92?=
 =?utf-8?B?VERhNk51ZlhTUHl3NU1XRHJDZGZPTkhqV1RMK1FTRW5YeVBYR29NR1FydjRV?=
 =?utf-8?B?elBTdlJBTDVQTktJWWZEcklVM24wOU1xT1V5d3pVbjQzdzE0SjZMNVpLVDJP?=
 =?utf-8?B?NENxcGZnVStES0lLZFRhMmZTU1BwYWdTL0MxU2V5dW5TeGFGS2h3L2diRGxp?=
 =?utf-8?B?N0ZiTXl2QmtYT3Z5Q1NWQVFTR3JLL0hHd0EyUDhrd2VxMEcrdlNBbVAxaG9U?=
 =?utf-8?B?U2N0MTdkcndiTVEzdTRIV3Z6MmNUL0JENUpQN1ZTd2p4ZEhuOTR5cG1ETFV6?=
 =?utf-8?B?RUIrS2tJakovaFBVWWd2RE1xQ3pFb0o0SGF6NUtqaVF2TXBDc3d1elNRTTc5?=
 =?utf-8?B?RzBEZyt4SHk3NkdxYVJPaS80Y0lBa0Nibllubyt5NmUvUmE5VmE5d0dxOHcr?=
 =?utf-8?B?eERhUnZEV2VaVEE5SXkyU1VWMURPVVhkTzdIQ0czOEZsb2V0RGNpUT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <AA01CB8AE28AF6418E04FD4AA5A44BEC@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e7e5936c-5e16-4791-c2a8-08d9f05ea2eb
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Feb 2022 08:39:09.9337
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: TGN3tqOQlhbHiUqVJ9ivKaJFXf34NlTjALo4j1XSdeUoZ2dQwu0X5btO+9XpBxs4yDA5EiazH5o/hHHSnKwnBqYpjH48IA4y3/SpfO0+1DoGOOZ2WI5qU3HnW3enIYIV
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR03MB4272
X-Proofpoint-ORIG-GUID: asvTaAbnhKRBLkOY_tfghPfg6xu-rB3Z
X-Proofpoint-GUID: asvTaAbnhKRBLkOY_tfghPfg6xu-rB3Z
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-15_03,2022-02-14_04,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0
 mlxlogscore=849 spamscore=0 bulkscore=0 impostorscore=0 mlxscore=0
 malwarescore=0 phishscore=0 lowpriorityscore=0 clxscore=1015 adultscore=0
 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202150049

DQoNCk9uIDE1LjAyLjIyIDEwOjMwLCBSb2dlciBQYXUgTW9ubsOpIHdyb3RlOg0KPiBPbiBNb24s
IEZlYiAxNCwgMjAyMiBhdCAwMjowMDoyNlBNICswMDAwLCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5r
byB3cm90ZToNCj4+IC8qDQo+PiAqIEZJWE1FOiBhcHBseV9tYXAgaXMgY2FsbGVkIGZyb20gZG9t
MCBzcGVjaWZpYyBpbml0IGNvZGUgd2hlbg0KPj4gKiBzeXN0ZW1fc3RhdGUgPCBTWVNfU1RBVEVf
YWN0aXZlLCBzbyB0aGVyZSBpcyBubyByYWNlIGNvbmRpdGlvbg0KPj4gKiBwb3NzaWJsZSBiZXR3
ZWVuIHRoaXMgY29kZSBhbmQgdnBjaV9wcm9jZXNzX3BlbmRpbmcuIFNvLCBuZWl0aGVyDQo+PiAq
IHZwY2lfcHJvY2Vzc19wZW5kaW5nIG1heSB0cnkgdG8gYWNxdWlyZSB0aGUgbG9jayBpbiByZWFk
IG1vZGUgYW5kDQo+PiAqIGFsc28gZGVzdHJveSBwZGV2LT52cGNpIGluIGl0cyBlcnJvciBwYXRo
IG5vciBwZGV2IG1heSBiZSBkaXNwb3NlZCB5ZXQuDQo+PiAqIFRoaXMgbWVhbnMgdGhhdCBpdCBp
cyBub3QgcmVxdWlyZWQgdG8gY2hlY2sgaWYgdGhlIHJlbGV2YW50IHBkZXYNCj4+ICogc3RpbGwg
ZXhpc3RzIGFmdGVyIHJlLWFjcXVpcmluZyB0aGUgbG9jay4NCj4gSSdtIG5vdCBzdXJlIHdoeSB5
b3UgbmVlZCB0byBtZW50aW9uIHZwY2lfcHJvY2Vzc19wZW5kaW5nIGhlcmU6DQo+IGFwcGx5X21h
cCBhbmQgZGVmZXJfbWFwIGFyZSBtdXR1YWxseSBleGNsdXNpdmUsIHNvIGdpdmVuIHRoZSBjdXJy
ZW50DQo+IGNvZGUgaXQncyBpbXBvc3NpYmxlIHRvIGdldCBpbiBhIHNpdHVhdGlvbiB3aGVyZSBh
cHBseV9tYXAgaXMgY2FsbGVkDQo+IHdoaWxlIHRoZXJlJ3MgcGVuZGluZyB3b3JrIG9uIHRoZSB2
Q1BVIChpZTogdi0+dnBjaS5tZW0gIT0gTlVMTCkuDQo+DQo+IEFsc28gdGhlcmUncyBubyBuZWVk
IGZvciBhIEZJWE1FIHRhZzogdGhlIGN1cnJlbnQgYXBwcm9hY2ggZG9lc24ndA0KPiByZXF1aXJl
IGFueSBmaXhlcyB1bmxlc3Mgd2Ugc3RhcnQgdXNpbmcgYXBwbHlfbWFwIGluIGEgZGlmZmVyZW50
DQo+IGNvbnRleHQuDQo+DQo+IEhlbmNlIEkgdGhpbmsgdGhlIGNvbW1lbnQgc2hvdWxkIGJlIGFs
b25nIHRoZSBsaW5lcyBvZjoNCj4NCj4gLyoNCj4gICAqIEl0J3Mgc2FmZSB0byBkcm9wIGFuZCBy
ZWFjcXVpcmUgdGhlIGxvY2sgaW4gdGhpcyBjb250ZXh0IHdpdGhvdXQNCj4gICAqIHJpc2tpbmcg
cGRldiBkaXNhcHBlYXJpbmcgYmVjYXVzZSBkZXZpY2VzIGNhbm5vdCBiZSByZW1vdmVkIHVudGls
IHRoZQ0KPiAgICogaW5pdGlhbCBkb21haW4gaGFzIGJlZW4gc3RhcnRlZC4NCj4gICAqLw0KVXJn
aCwgSSd2ZSBqdXN0IHNlbnQgdjIuIEknbGwgbW92ZSB0aGlzIHRoZXJlIGFuZCBhbnN3ZXINCj4N
Cj4gVGhhbmtzLCBSb2dlci4NCj4NClRoYW5rIHlvdSwNCk9sZWtzYW5kcg==


From xen-devel-bounces@lists.xenproject.org Tue Feb 15 08:41:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 08:41:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272843.467814 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJtPB-00063Z-Jd; Tue, 15 Feb 2022 08:41:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272843.467814; Tue, 15 Feb 2022 08:41:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJtPB-00063S-Ga; Tue, 15 Feb 2022 08:41:49 +0000
Received: by outflank-mailman (input) for mailman id 272843;
 Tue, 15 Feb 2022 08:41:48 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=xOiq=S6=epam.com=prvs=4045782cdb=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nJtPA-00063M-Lj
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 08:41:48 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1bb5e6b3-8e3b-11ec-8eb8-a37418f5ba1a;
 Tue, 15 Feb 2022 09:41:47 +0100 (CET)
Received: from pps.filterd (m0174679.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 21F8Ys7j013269;
 Tue, 15 Feb 2022 08:41:37 GMT
Received: from eur05-am6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2104.outbound.protection.outlook.com [104.47.18.104])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e886fr74c-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Tue, 15 Feb 2022 08:41:36 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by PA4PR03MB7359.eurprd03.prod.outlook.com (2603:10a6:102:108::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.19; Tue, 15 Feb
 2022 08:41:28 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::fc4d:4749:5d1:eb73]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::fc4d:4749:5d1:eb73%4]) with mapi id 15.20.4975.019; Tue, 15 Feb 2022
 08:41:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1bb5e6b3-8e3b-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=P0Ce/8sX+S6isvf37kzvBq46YnK9vpM12tIUR0XNu5Es/vi/DTyqS0LaYBUgVKprKaNO1Gjv79P2xhz+jp1NEqjbI8Gv9qwrsMBn6zZQDHgO9HqyiZvIEpD1WOjUdsafObpakbw7vCOhg8X/YhrCERLW2bAbl8aNa416d/GLsDRjiESoviiPGyw3pVH2DN/RuIt8OJ78HcDqBQY8cIOC6xnUW6Rz/LYMcvpkpQWHs8TcolUTAWg//tIMowUI2z/S3VxU53lAzbWH+V04AVb7nIIG3Nzi+ikNTCly4uCDDjtPzO/beagZk3OJ5pHUIlosSAQoHNhqnq9hbPJP/GwQCg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=C7bIRe9UwptJsB5+qL2+PuymXXE7ASuNAow3USbPVHc=;
 b=ltEoJAXlue+s9ViShoP3509CiF1fknNcNJigCAxySSmae5rxIWewxqlpQaTNSxjB1KmRDP/lSM5a6zBWE3oKdExLKKPM8WzVovQgLQcVsGreZtRZNPZGi/cVN2UrFtv/TKbZcimdejbs+elPBHo4UPkMk7GQiwdwL1HcuqoGIAH7V0aEf1ow/PMvZ24Zb+Pxf/LqJReZZ0sZYHsOTG5So1W/IziPu7o5ccrj+tRi+FTYGxyAMTzAlMCLbhZTIlnls8CA9KXC73++/WD9Tuak/1Cy7gf9yoJ8qJ8V+JqOrISPEKC9/JxM5vwcP+hSamDt1TjnOINx/th3D2f5Op7gNQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=C7bIRe9UwptJsB5+qL2+PuymXXE7ASuNAow3USbPVHc=;
 b=linoGtcmyq/EINhhO1E3txyfbGahqhP4GF3WVqz+AuBBlnt+o/Q7ofbWFiobQwijtBG4TAOTua1G3TN8TxxJaNl+ZXB6t83zCDfzcMCZOJv6MgdfYBfa+sy3Sk9rxxAVnc6vDse6awTnNWVL1jsVDCOatmdIsHB1x/1GJvMdA8/16K9btEZtEVnmFPlw//j91WSEbZSJFHlbdayTrFwdKkY21hXVKpI4J3+EYxNM6tFDMtt1kI0+sex/PwclUd1BL5Zt8j9Qq6xINvf010MQ+JCEgnCDcfvQG6GeAYUiikkCRJhpChedGsqJzrOJhQJWDKM7lqZloPCHaKtUDwIWWg==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: "roger.pau@citrix.com" <roger.pau@citrix.com>
CC: "jbeulich@suse.com" <jbeulich@suse.com>,
        "julien@xen.org"
	<julien@xen.org>,
        "sstabellini@kernel.org" <sstabellini@kernel.org>,
        Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2] vpci: introduce per-domain lock to protect vpci
 structure
Thread-Topic: [PATCH v2] vpci: introduce per-domain lock to protect vpci
 structure
Thread-Index: AQHYIkOs9pmsZb0l5kefj1m3qdTVCayUSxyA
Date: Tue, 15 Feb 2022 08:41:28 +0000
Message-ID: <00a41464-3652-7976-51a9-8bbcbb2ab702@epam.com>
References: <20220215081135.1497470-1-andr2000@gmail.com>
In-Reply-To: <20220215081135.1497470-1-andr2000@gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 965dac35-a3ed-4d48-8b38-08d9f05ef558
x-ms-traffictypediagnostic: PA4PR03MB7359:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <PA4PR03MB7359F04C1241969C32A8F02AE7349@PA4PR03MB7359.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8882;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 vCnoMOCJXmeTwwPwxopM3xKbtclAvVhMA5lD6DGXpBXwb/0tRGR/cxFWy5/AhRk69Tm7Bb+jCYGFy6B+fmkk890XwFuu2O8xNucRiCMne4VxhECenr+FH4pqNlOUIFE6d3+PTr/wKgsudu55ViqFkw6XsBuAE2OBWMNNKXwlgRQ9YL9yo5Q14lOs7O15oX3w2BlPqyBBWPk5Aqa0dsmeoh8EXw22zYXIuquenhqBLgEDDAfVbNRnEIaMpUnIlf2OvjlKdRXb3DDjn6d+gKyupgjEdtf2bsltBXUnFO54QrZ8vp4fqrwJPfADgcpxDckb9zgflzYr/XQiDBSwIZO+Cw8GBrOU8zclOwYlpfDYOkRfoBUvrA0YCkG2+5czt3ZzNpWiGhFT7Q9gUAf/RqApPMdC9D/mr7dgMPqJFqkaQzjpFMQO31GIpvnmG6LD/zwtz/6rJWGbG/FSgKDpemrfNYHXMBj1TdRfsdv5B7/oA351zvmqKaUxM+EzpImbFWrhi2fbkyADqdbL4YLAVLzLYOG3sPNVFn9SHTETfkfNwO/igQUf7usuuaQWe5x/Ffzpe4HneHqCSfyWu3ei1H+zWHbTGLpzfKYi2rWLaXVtrxw3QyZg24vWlDaOpi0JM8Rs3EsZbpLJfAVrWmvJ7DFDIog87Z79eTj1LaOg9je/LjftUcelrXQthEW9MlvdHQsWvBWIPdnGnCQC+q77GPP3eEMzMShBdNa2VkDV4JdT14D1YGOOo123SvVg90DZjRUb
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(4326008)(83380400001)(8936002)(36756003)(31686004)(186003)(5660300002)(2616005)(26005)(76116006)(6512007)(53546011)(55236004)(6506007)(66946007)(508600001)(64756008)(8676002)(316002)(66446008)(54906003)(6916009)(66556008)(86362001)(31696002)(71200400001)(66476007)(6486002)(38070700005)(91956017)(122000001)(38100700002)(2906002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?dGhHaUVJYVl3bEY4dTdtZ0ZYbTN6eVZYc2F6bjlMK3ovdWNnMW03YzdqSjUy?=
 =?utf-8?B?eVRMZ01DaTlVRTM1eW84T0tMcmVqZXhwN2NwbUo1TkFxc09PNExnT3F0SUhi?=
 =?utf-8?B?Q1lNSlQ1MjhicVd4aVlIZmliVm1BdnprM285WWtWL04vZlliNkQvODlCQVBz?=
 =?utf-8?B?VEprQjFMTlhzQ0ZiNkw2cnBvTEwvREhtekpLOXNoemswQkNPVlE2bjRJT0Vy?=
 =?utf-8?B?UGpOcGI2WFRTbHF5QWplRjJmS1lIK09LZGVkNkEwQTBwMnZiUlU2SUpsZVJ1?=
 =?utf-8?B?S0UxSDh0OE1ibVlYS3o3WG15QVIxVWxXanNvZU1KTmF6cHgwWEtYMFNGdndj?=
 =?utf-8?B?QUNYaS9VbVRWL0FkdHY5UDhHMFpFTWlUTGNPZWx6dG9od2traEJPSHlQb2Q4?=
 =?utf-8?B?QXV3OTFpTXQ3NEJGQ2tqUm04K0ErTkVJM0VKaTh6M2hqbStCQVE2NnlyQ0tp?=
 =?utf-8?B?VHptREIydkNYK05kWlB0T0d1OGNTK0N5Zit6amlHREloYk5QRUdjT25iQnhh?=
 =?utf-8?B?RkJkRFJpUTdoRWlHTVcyQXlEZ2V6QTV0OUoxNy90RjRuOFBJYzlpQ0VnL3lS?=
 =?utf-8?B?dmxsZWgwdGo0NjJzc3phaWZiSlM0UDJPdmN3WlB3cytyMi9DWGV6Z0tYZWx4?=
 =?utf-8?B?eWk5bVVIZ00vQi9SUHZiUjRaRFJTY3dJM1d5VlhrVC8wNTIxZUQ4WDFsemlL?=
 =?utf-8?B?cXFLUFkxQUw1R29Fdk9UOW9sakNDV3cwTXIvV0YxNkM4UGs5bTY4UlBSZDA1?=
 =?utf-8?B?dFRSSmNzM0tRTXFQTkVwcGlPWkc2TnF4MVFQQUtjT0FreEpDU0ZEMlA4TXhh?=
 =?utf-8?B?WW1wR1JWS1RiK1d6MXVOQ3pyaU1qQVhOQ2tkNzAwcFFaanVubHRpRENQa1FY?=
 =?utf-8?B?cCtYaDdBQ0JJbHlReHBIUmpIVVlkb3pTUGdvYm9nVU5MUzZwNFd0QkZWcC93?=
 =?utf-8?B?bUtjYlhWVDJBZEl3TFZKRGtBVFd3bk1pMnVEbFd6SFVWS2hrc3VEWkJ4Zjh4?=
 =?utf-8?B?ZUVrQ2xQN1lmMjdtOVduTm8vRDRkc0JOM0JoQWpoOHE4T0xHZkJFMXBzTUR3?=
 =?utf-8?B?bzJkNS94Ykl4b0R2b200OHRjaUF1REg5VnBVdGxZN3J1MVlBVy9DNkxPRWxI?=
 =?utf-8?B?azhkM0lBMHBNTjdUTFFMZ0tCUHpJYlNldHBoQ1JjaUF5NExBK2RIVHVJdDAz?=
 =?utf-8?B?YW9tN0tVQzVNWDBUWkN6dHhnc2Nmd1ZhdUlCendBYWFkcFczeWtyNzlKMzdV?=
 =?utf-8?B?SDV2eWxXVjRoWXZGUjNrZzFTSW1sL25wbXovK2tlTXBVM2o2SmE2NmVsbVFJ?=
 =?utf-8?B?M2xGcXVmbXhSR2xCdFRqN0c1blhtQlR2dnBHYWRmMjlsQlZ2QldXcnhqampL?=
 =?utf-8?B?MDRMRHRJUzI3a1Zwd2MvRTRnNDNvd1NWYTZKUnpXRHBDL0VWbVgvOVFIUFRC?=
 =?utf-8?B?Qy9BUXg5L1R6YVRmRk5TVU5qRStETFZsUDh1OERDTE8rcHd6eEFzWDNaNGo0?=
 =?utf-8?B?bGlUVnFEWktkanZWR3IyazZTc3RYQWhzWnlKbmVIbzgyQjJMT1RXZmQzbGp5?=
 =?utf-8?B?WEFuZit0NDkyMExNVWlDRnpJbFYvcWhtREJwU2szTU1VZWtXQVE2bkxVTCtP?=
 =?utf-8?B?TlFNSnNoejZNYlI0dnY4S1ZmZ3A0WTBmZy9CeEFYcGNYQ0NNVVZJc1FpY1NT?=
 =?utf-8?B?c0hCUzl3enBRNlNuVDBZZ2pmajY0RmlSblc2QklLcDc3azZYUi9sWlBQZ1hI?=
 =?utf-8?B?dXM0ZVdYTTc4WE1FNzJnMkVXQ0JQYkFtT0xrZGcwSEJzbFFseTRMUy9sL1Vm?=
 =?utf-8?B?SUphaFBZTkRBUG9tVGlUV1docVhnRnJobGZuSWpkTkZEbTlTZzVwMHpkTndU?=
 =?utf-8?B?dElUS3JwTmQ2Njg1RG1LRng0TmdYSlNQYUw2Ym9pN1Zlbks2NUsyODV2MlRX?=
 =?utf-8?B?bU52NEx3Q1ZxczQrUUFTUVRGRW1vRUY3YWpGNUZlTjIxUGdybGlWVnhmeU1N?=
 =?utf-8?B?SDBhTDhsYjZFK2tmbWlndWg4Ym51eENxSlQwU3YzOTY4MzE2NGlnQnNFem9h?=
 =?utf-8?B?Z0ZQNmU4Tko0NzgxL3I5UTdxYjlnKy9PTTNBNnBIa3JodUdUekVCYmw0ZDRE?=
 =?utf-8?B?bGNaaVVrRVIzMStZaXczQXdOYXJJSWJhaTRENmdDeHJ1eEt3NWliYlR3bmNP?=
 =?utf-8?B?eTl5cnF4cUVvQ1RYdVhLVm5hbW5xeE1TQmJzMGFlYWZWMUszRTk4Ym5rMThW?=
 =?utf-8?B?MnpCbThvRXV6bEZ6OWgwVkNyNk96OGJQVEhZNkFLbmN4ZmdtSzAvalNrUjUv?=
 =?utf-8?B?VWhRT01RdUx5WWpzZUhZMzd6eWsyWWMyNDZieUlUYzhabXkxMXZXbWRBdlhP?=
 =?utf-8?Q?38JlM9Mea/h6MD3w=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <2A3FFA7F0DB0D147BBC4FB5A3EFAE9DC@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 965dac35-a3ed-4d48-8b38-08d9f05ef558
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Feb 2022 08:41:28.2198
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 1xZojZciX6aVL/qQlOq4ZYOcw3XMfKY6abZRqyczNcNII/U1V+lKGDDvolT1Izd00pVbPEEYD9Ewu5GKdnUg6G3nR9FzmegDLFKTfsdmOsS5b7phC6+nNXw2pdXwzbPR
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR03MB7359
X-Proofpoint-ORIG-GUID: 9PAsNAC1NTUqC8GsKvNrgvVpufyyN343
X-Proofpoint-GUID: 9PAsNAC1NTUqC8GsKvNrgvVpufyyN343
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-15_03,2022-02-14_04,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0
 malwarescore=0 mlxlogscore=924 impostorscore=0 mlxscore=0 adultscore=0
 suspectscore=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202150049

DQoNCk9uIDE1LjAyLjIyIDEwOjExLCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyB3cm90ZToNCj4g
RnJvbTogT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gPG9sZWtzYW5kcl9hbmRydXNoY2hlbmtvQGVw
YW0uY29tPg0KPg0KPiBAQCAtMTcxLDggKzE3MywyNCBAQCBzdGF0aWMgaW50IF9faW5pdCBhcHBs
eV9tYXAoc3RydWN0IGRvbWFpbiAqZCwgY29uc3Qgc3RydWN0IHBjaV9kZXYgKnBkZXYsDQo+ICAg
ICAgIHN0cnVjdCBtYXBfZGF0YSBkYXRhID0geyAuZCA9IGQsIC5tYXAgPSB0cnVlIH07DQo+ICAg
ICAgIGludCByYzsNCj4gICANCj4gKyAgICBBU1NFUlQocndfaXNfd3JpdGVfbG9ja2VkKCZkLT52
cGNpX3J3bG9jaykpOw0KPiArDQo+ICAgICAgIHdoaWxlICggKHJjID0gcmFuZ2VzZXRfY29uc3Vt
ZV9yYW5nZXMobWVtLCBtYXBfcmFuZ2UsICZkYXRhKSkgPT0gLUVSRVNUQVJUICkNCj4gKyAgICB7
DQo+ICsgICAgICAgIC8qDQo+ICsgICAgICAgICAqIEZJWE1FOiBhcHBseV9tYXAgaXMgY2FsbGVk
IGZyb20gZG9tMCBzcGVjaWZpYyBpbml0IGNvZGUgd2hlbg0KPiArICAgICAgICAgKiBzeXN0ZW1f
c3RhdGUgPCBTWVNfU1RBVEVfYWN0aXZlLCBzbyB0aGVyZSBpcyBubyByYWNlIGNvbmRpdGlvbg0K
PiArICAgICAgICAgKiBwb3NzaWJsZSBiZXR3ZWVuIHRoaXMgY29kZSBhbmQgdnBjaV9wcm9jZXNz
X3BlbmRpbmcuIFNvLCBuZWl0aGVyDQo+ICsgICAgICAgICAqIHZwY2lfcHJvY2Vzc19wZW5kaW5n
IG1heSB0cnkgdG8gYWNxdWlyZSB0aGUgbG9jayBpbiByZWFkIG1vZGUgYW5kDQo+ICsgICAgICAg
ICAqIGFsc28gZGVzdHJveSBwZGV2LT52cGNpIGluIGl0cyBlcnJvciBwYXRoIG5vciBwZGV2IG1h
eSBiZSBkaXNwb3NlZA0KPiArICAgICAgICAgKiB5ZXQuIFRoaXMgbWVhbnMgdGhhdCBpdCBpcyBu
b3QgcmVxdWlyZWQgdG8gY2hlY2sgaWYgdGhlIHJlbGV2YW50DQo+ICsgICAgICAgICAqIHBkZXYt
PnZwY2kgc3RpbGwgZXhpc3RzIGFmdGVyIHJlLWFjcXVpcmluZyB0aGUgbG9jay4NCj4gKyAgICAg
ICAgICovDQoNCj4gSSdtIG5vdCBzdXJlIHdoeSB5b3UgbmVlZCB0byBtZW50aW9uIHZwY2lfcHJv
Y2Vzc19wZW5kaW5nIGhlcmU6DQo+IGFwcGx5X21hcCBhbmQgZGVmZXJfbWFwIGFyZSBtdXR1YWxs
eSBleGNsdXNpdmUsIHNvIGdpdmVuIHRoZSBjdXJyZW50DQo+IGNvZGUgaXQncyBpbXBvc3NpYmxl
IHRvIGdldCBpbiBhIHNpdHVhdGlvbiB3aGVyZSBhcHBseV9tYXAgaXMgY2FsbGVkDQo+IHdoaWxl
IHRoZXJlJ3MgcGVuZGluZyB3b3JrIG9uIHRoZSB2Q1BVIChpZTogdi0+dnBjaS5tZW0gIT0gTlVM
TCkuDQo+DQo+IEFsc28gdGhlcmUncyBubyBuZWVkIGZvciBhIEZJWE1FIHRhZzogdGhlIGN1cnJl
bnQgYXBwcm9hY2ggZG9lc24ndA0KPiByZXF1aXJlIGFueSBmaXhlcyB1bmxlc3Mgd2Ugc3RhcnQg
dXNpbmcgYXBwbHlfbWFwIGluIGEgZGlmZmVyZW50DQo+IGNvbnRleHQuDQo+DQo+IEhlbmNlIEkg
dGhpbmsgdGhlIGNvbW1lbnQgc2hvdWxkIGJlIGFsb25nIHRoZSBsaW5lcyBvZjoNCj4NCj4gLyoN
Cj4gICogSXQncyBzYWZlIHRvIGRyb3AgYW5kIHJlYWNxdWlyZSB0aGUgbG9jayBpbiB0aGlzIGNv
bnRleHQgd2l0aG91dA0KPiAgKiByaXNraW5nIHBkZXYgZGlzYXBwZWFyaW5nIGJlY2F1c2UgZGV2
aWNlcyBjYW5ub3QgYmUgcmVtb3ZlZCB1bnRpbCB0aGUNCj4gICogaW5pdGlhbCBkb21haW4gaGFz
IGJlZW4gc3RhcnRlZC4NCj4gICovDQpUaGlzIHNvdW5kcyBnb29kLCB3aWxsIHVzZSB0aGlzDQo+
IA0KPiBUaGFua3MsIFJvZ2VyLg0KDQo=


From xen-devel-bounces@lists.xenproject.org Tue Feb 15 08:48:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 08:48:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272851.467825 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJtVH-0006jW-9O; Tue, 15 Feb 2022 08:48:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272851.467825; Tue, 15 Feb 2022 08:48:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJtVH-0006jP-6I; Tue, 15 Feb 2022 08:48:07 +0000
Received: by outflank-mailman (input) for mailman id 272851;
 Tue, 15 Feb 2022 08:48:05 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=svD9=S6=redhat.com=btissoir@srs-se1.protection.inumbo.net>)
 id 1nJtVF-0006jJ-Fb
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 08:48:05 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id fc0f5a1b-8e3b-11ec-b215-9bbe72dcb22c;
 Tue, 15 Feb 2022 09:48:03 +0100 (CET)
Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com
 [209.85.216.72]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-591-Xv9UxChINSCUe8FjjZU_LQ-1; Tue, 15 Feb 2022 03:47:55 -0500
Received: by mail-pj1-f72.google.com with SMTP id
 hi22-20020a17090b30d600b001b8b33cf0efso1375518pjb.1
 for <xen-devel@lists.xenproject.org>; Tue, 15 Feb 2022 00:47:55 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fc0f5a1b-8e3b-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1644914882;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=+0eleqiUVBeAPaQGD2Q6ihFW/Z9JIAN0Kj0GeNRsLaA=;
	b=FtsXq3pqFP6C86hGYM3a5DcVL1YghIVkq6/nCkdEs0oom8VudsWWDHUNp4m0bIEN8g8Zq4
	3lS+yHAvHIrtMJKVP5E+HrK5MoXGaxcO+YatICi5t5SyehpRw+8WcIHocGyfmoBCW7IBbT
	+ATa1Lkw59C36iExAKDQ7DTPTnh5Uk0=
X-MC-Unique: Xv9UxChINSCUe8FjjZU_LQ-1
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=+0eleqiUVBeAPaQGD2Q6ihFW/Z9JIAN0Kj0GeNRsLaA=;
        b=JvZuvLxFO6+NpMp8XCn+KRfn5gPCWoxKBn3l+HWAHSRmiQ2+cGM/bCEByrrpYIaExB
         mMF5lXCSoxRGfAlKxC0NzAhapRYzqLbNWzPz+c2rLxrc1rvP9AYmErk5436k47L6vzdg
         oj193TtSV9H9T0uI5/Y4FCGRW0SSqYhifSHq9+I+3AyxjcGjW0eK845D3YVJ70ekY2gP
         zWJhfEV/KziChJHQFfB1t9yHU+LmrVx0cDUqxw59y1eT77BTTk7NZD+0k8NSGsaGNe3g
         i9reUf/JVCevXWrCpXCpu/d1FJYMTgVbuqY0Y2Sdv+6MogPiXVkPQcOGJo7c85ex1Bq/
         uXig==
X-Gm-Message-State: AOAM533PGlfrQVhPRZBYfviZLtKK7dTBvolbvj6tKKNwT2vVKmefnbaG
	NSICKOD9tOi1LSbbFad8wMfY4wvRLutMhaLBBwMkdQQrqXB5InaykDPiI/rP9WlBrR63LX5oLGv
	uCLrVDJb5PSZZXDJVZCNbeh7oDYjxE0zmDv4N0tJR2MM=
X-Received: by 2002:a05:6a00:9a9:: with SMTP id u41mr3233715pfg.83.1644914874678;
        Tue, 15 Feb 2022 00:47:54 -0800 (PST)
X-Google-Smtp-Source: ABdhPJy1RXfHqGKUOwHiOd9TXDCmkRfLOApnv8+NP4UBdUIs2zHseVmQ3Z770IwhZgE/Zg1NSmgYeteqUdN9fAOzix8=
X-Received: by 2002:a05:6a00:9a9:: with SMTP id u41mr3233676pfg.83.1644914874405;
 Tue, 15 Feb 2022 00:47:54 -0800 (PST)
MIME-Version: 1.0
References: <1644890154-64915-1-git-send-email-wangqing@vivo.com> <1644890154-64915-6-git-send-email-wangqing@vivo.com>
In-Reply-To: <1644890154-64915-6-git-send-email-wangqing@vivo.com>
From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Date: Tue, 15 Feb 2022 09:47:43 +0100
Message-ID: <CAO-hwJJK5yeW+K_vLpWV9t3TsEdk0xCO-ETxeJsXM2c117JzNw@mail.gmail.com>
Subject: Re: [PATCH V3 5/13] hid: use time_is_after_jiffies() instead of open
 coding it
To: Qing Wang <wangqing@vivo.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>, =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>, 
	Jens Axboe <axboe@kernel.dk>, Michael Turquette <mturquette@baylibre.com>, 
	Stephen Boyd <sboyd@kernel.org>, Jani Nikula <jani.nikula@linux.intel.com>, 
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>, Rodrigo Vivi <rodrigo.vivi@intel.com>, 
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, 
	Alex Deucher <alexander.deucher@amd.com>, =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>, 
	"Pan, Xinhui" <Xinhui.Pan@amd.com>, 
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>, Jiri Kosina <jikos@kernel.org>, 
	Dmitry Torokhov <dmitry.torokhov@gmail.com>, Alasdair Kergon <agk@redhat.com>, 
	Mike Snitzer <snitzer@redhat.com>, dm-devel@redhat.com, 
	Mauro Carvalho Chehab <mchehab@kernel.org>, Hans Verkuil <hverkuil@xs4all.nl>, xen-devel@lists.xenproject.org, 
	linux-block@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>, 
	linux-clk@vger.kernel.org, intel-gfx@lists.freedesktop.org, 
	dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, 
	"open list:HID CORE LAYER" <linux-input@vger.kernel.org>, linux-media@vger.kernel.org
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=btissoir@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset="UTF-8"

On Tue, Feb 15, 2022 at 2:56 AM Qing Wang <wangqing@vivo.com> wrote:
>
> From: Wang Qing <wangqing@vivo.com>
>
> Use the helper function time_is_{before,after}_jiffies() to improve
> code readability.
>
> Signed-off-by: Wang Qing <wangqing@vivo.com>
> Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>

FWIW, this one is
Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>

Wang, is there any plan to take this series through the trivial tree
or should each maintainer take the matching patches?

Cheers,
Benjamin

> ---
>  drivers/hid/intel-ish-hid/ipc/ipc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/intel-ish-hid/ipc/ipc.c b/drivers/hid/intel-ish-hid/ipc/ipc.c
> index 8ccb246..15e1423
> --- a/drivers/hid/intel-ish-hid/ipc/ipc.c
> +++ b/drivers/hid/intel-ish-hid/ipc/ipc.c
> @@ -578,7 +578,7 @@ static void _ish_sync_fw_clock(struct ishtp_device *dev)
>         static unsigned long    prev_sync;
>         uint64_t        usec;
>
> -       if (prev_sync && jiffies - prev_sync < 20 * HZ)
> +       if (prev_sync && time_is_after_jiffies(prev_sync + 20 * HZ))
>                 return;
>
>         prev_sync = jiffies;
> --
> 2.7.4
>



From xen-devel-bounces@lists.xenproject.org Tue Feb 15 08:48:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 08:48:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272855.467837 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJtVr-0007F2-If; Tue, 15 Feb 2022 08:48:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272855.467837; Tue, 15 Feb 2022 08:48:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJtVr-0007Ev-Fj; Tue, 15 Feb 2022 08:48:43 +0000
Received: by outflank-mailman (input) for mailman id 272855;
 Tue, 15 Feb 2022 08:48:42 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=svD9=S6=redhat.com=btissoir@srs-se1.protection.inumbo.net>)
 id 1nJtVq-0006jJ-JW
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 08:48:42 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 124e367b-8e3c-11ec-b215-9bbe72dcb22c;
 Tue, 15 Feb 2022 09:48:41 +0100 (CET)
Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com
 [209.85.216.71]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-147-ldGX96ePNJqNM7dk4ItkEw-1; Tue, 15 Feb 2022 03:48:36 -0500
Received: by mail-pj1-f71.google.com with SMTP id
 fh23-20020a17090b035700b001b9a9045bceso1358641pjb.8
 for <xen-devel@lists.xenproject.org>; Tue, 15 Feb 2022 00:48:36 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 124e367b-8e3c-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1644914919;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=cAghCw6nMXIP8DbPC2ZTmMjVdzgtfdV0Q4rDuIo9NkY=;
	b=DSqmbLSAwCAJVngxiscPK3AI83fBvtKyU1g0AilU1+5l1HWqSms+MFHSUGa0sZO/SfGwjz
	MTARKord6OnXu1SikYooOuoDXp45WeVwP+NSyH7Y/dELylzZWdS76PxZnMHKfa6/B5mtm0
	Kk9NNo2FFnT7z/6lrYWi3bCEQd9gsF4=
X-MC-Unique: ldGX96ePNJqNM7dk4ItkEw-1
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=cAghCw6nMXIP8DbPC2ZTmMjVdzgtfdV0Q4rDuIo9NkY=;
        b=WCWacFNw/pagzl4A2W37lrdS2tBc/clMPTDFakB84VXYJX/JucOa9MzMVXqPvAB0Au
         mAlETX1BkYqnfzKK6cevLzKHWev/xDb3VG6C8OtUgXZ/BWb0pqNRRGsWHeoff8LlFYJl
         /e2+zUjqAsU9VDynxur4HtRswzeKZXh1XXch+8P9a7+QDOHyjvUXcBV/A2tg1vR1o8yh
         S1qHULWUu/Dh2Zo6LAPhuxjfToi4eL6dBs4Z/qn99uxqVSpwm7nRkRMHiQFIhoa9mGML
         CcIfaFW7BFwP94SSlPYBtqDRIamx0veyDYTcvxIhwDSQO8iLz9YwtFRzUncbsYAKjixS
         NCfA==
X-Gm-Message-State: AOAM530fTKAIttB/SediBRmH3KBWEaI0+WZfK7PWN6hlU21E/btsMfdG
	whKXAdkP2yiKGjEpXacnFR9qb2UbtV4dOkIuEK1wn2shmHz1C2pjUpopofubFQByBlz7kHmBqWj
	HBfdvZyhl6+ts26wzCbYvOVgQgCCVgizhXKQk/AX8RTE=
X-Received: by 2002:a63:2bc5:: with SMTP id r188mr2644616pgr.363.1644914915615;
        Tue, 15 Feb 2022 00:48:35 -0800 (PST)
X-Google-Smtp-Source: ABdhPJxNykZwzg4bf+5n8EbXDkY7JRsdOTnLNDPgNJlOcTDejNQ8sWs8DiYpM4W3ztHYleOanIdgFMhO3Rj6Rj63QAs=
X-Received: by 2002:a63:2bc5:: with SMTP id r188mr2644575pgr.363.1644914915393;
 Tue, 15 Feb 2022 00:48:35 -0800 (PST)
MIME-Version: 1.0
References: <1644890154-64915-1-git-send-email-wangqing@vivo.com> <1644890154-64915-7-git-send-email-wangqing@vivo.com>
In-Reply-To: <1644890154-64915-7-git-send-email-wangqing@vivo.com>
From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Date: Tue, 15 Feb 2022 09:48:24 +0100
Message-ID: <CAO-hwJLwomyHyjza8x3cEhR97HkK7Z7yPWVXwA4-1jmM=WKqeQ@mail.gmail.com>
Subject: Re: [PATCH V3 6/13] input: serio: use time_is_before_jiffies()
 instead of open coding it
To: Qing Wang <wangqing@vivo.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>, =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>, 
	Jens Axboe <axboe@kernel.dk>, Michael Turquette <mturquette@baylibre.com>, 
	Stephen Boyd <sboyd@kernel.org>, Jani Nikula <jani.nikula@linux.intel.com>, 
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>, Rodrigo Vivi <rodrigo.vivi@intel.com>, 
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, 
	Alex Deucher <alexander.deucher@amd.com>, =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>, 
	"Pan, Xinhui" <Xinhui.Pan@amd.com>, 
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>, Jiri Kosina <jikos@kernel.org>, 
	Dmitry Torokhov <dmitry.torokhov@gmail.com>, Alasdair Kergon <agk@redhat.com>, 
	Mike Snitzer <snitzer@redhat.com>, dm-devel@redhat.com, 
	Mauro Carvalho Chehab <mchehab@kernel.org>, Hans Verkuil <hverkuil@xs4all.nl>, xen-devel@lists.xenproject.org, 
	linux-block@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>, 
	linux-clk@vger.kernel.org, intel-gfx@lists.freedesktop.org, 
	dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, 
	"open list:HID CORE LAYER" <linux-input@vger.kernel.org>, linux-media@vger.kernel.org
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=btissoir@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset="UTF-8"

On Tue, Feb 15, 2022 at 2:57 AM Qing Wang <wangqing@vivo.com> wrote:
>
> From: Wang Qing <wangqing@vivo.com>
>
> Use the helper function time_is_{before,after}_jiffies() to improve
> code readability.
>
> Signed-off-by: Wang Qing <wangqing@vivo.com>
> ---

Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>

Cheers,
Benjamin

>  drivers/input/serio/ps2-gpio.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/input/serio/ps2-gpio.c b/drivers/input/serio/ps2-gpio.c
> index 8970b49..7834296
> --- a/drivers/input/serio/ps2-gpio.c
> +++ b/drivers/input/serio/ps2-gpio.c
> @@ -136,7 +136,7 @@ static irqreturn_t ps2_gpio_irq_rx(struct ps2_gpio_data *drvdata)
>         if (old_jiffies == 0)
>                 old_jiffies = jiffies;
>
> -       if ((jiffies - old_jiffies) > usecs_to_jiffies(100)) {
> +       if (time_is_before_jiffies(old_jiffies + usecs_to_jiffies(100))) {
>                 dev_err(drvdata->dev,
>                         "RX: timeout, probably we missed an interrupt\n");
>                 goto err;
> @@ -237,7 +237,7 @@ static irqreturn_t ps2_gpio_irq_tx(struct ps2_gpio_data *drvdata)
>         if (old_jiffies == 0)
>                 old_jiffies = jiffies;
>
> -       if ((jiffies - old_jiffies) > usecs_to_jiffies(100)) {
> +       if (time_is_before_jiffies(old_jiffies + usecs_to_jiffies(100))) {
>                 dev_err(drvdata->dev,
>                         "TX: timeout, probably we missed an interrupt\n");
>                 goto err;
> --
> 2.7.4
>



From xen-devel-bounces@lists.xenproject.org Tue Feb 15 09:03:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 09:03:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272865.467847 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJtkQ-0001DS-T5; Tue, 15 Feb 2022 09:03:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272865.467847; Tue, 15 Feb 2022 09:03:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJtkQ-0001DL-Pm; Tue, 15 Feb 2022 09:03:46 +0000
Received: by outflank-mailman (input) for mailman id 272865;
 Tue, 15 Feb 2022 09:03:45 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=A2Di=S6=vivo.com=wangqing@srs-se1.protection.inumbo.net>)
 id 1nJtkP-0001DE-Di
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 09:03:45 +0000
Received: from APC01-SG2-obe.outbound.protection.outlook.com
 (mail-sgaapc01on20708.outbound.protection.outlook.com
 [2a01:111:f400:feab::708])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2b5e6184-8e3e-11ec-b215-9bbe72dcb22c;
 Tue, 15 Feb 2022 10:03:42 +0100 (CET)
Received: from SL2PR06MB3082.apcprd06.prod.outlook.com (2603:1096:100:37::17)
 by HK0PR06MB2482.apcprd06.prod.outlook.com (2603:1096:203:6c::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.15; Tue, 15 Feb
 2022 09:03:36 +0000
Received: from SL2PR06MB3082.apcprd06.prod.outlook.com
 ([fe80::80b4:e787:47a9:41bb]) by SL2PR06MB3082.apcprd06.prod.outlook.com
 ([fe80::80b4:e787:47a9:41bb%4]) with mapi id 15.20.4975.019; Tue, 15 Feb 2022
 09:03:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2b5e6184-8e3e-11ec-b215-9bbe72dcb22c
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ZPpPmNNC0M3vPAJnM3PxwLd3sSup3c704w/t6rAZG9tY1fy4ORCIl0rzGjO3jqBzM3jcwzHUFSyLBTvfXOQMI4r7Jm8JSRWbC3g1uISbR1RFdMUkww4ZK37+Fvpqv/7/51x0NGSAvPVw9BdYEt0Psw7OrY+4mxoHUxEEEL5zj+zf5UUu9S3h4J8VEd7PWSYKpdOvTlOSiYL/CiUy+7tvKaitzl22zZHQd+jEcrAemS6z0Xf09mmauziiilzdR+PCPm9WaY1jwLadrRFrym5RadF7rSKofjWIQhSlPNqiZsEurieyTFV7b0HhyeSKSg++K3YquRHnIfZNoUZYhzW2wA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=pGZ8vVYEdGEeFqa/5tb4dZHPb8IWs83sz1PdBYLJQ9M=;
 b=eWoc+VgYrgtPL2eSRSh0Nxu84taTPW2q2g8+501S/gENFvlFjTCRY4tg29JReY+01Kp1mpJJ13N7lUG3iuvhWK7rlhr8OuvPyfRZMWi/5ZqtgfuSl7vyA2pT8PSofU9FfVYJ1t+zTxIH4KthMTD0cZ2fqqOqpaRAMiXmw2CnMeKSHA2mZL4C8EM+2JofJlbbvI8s1YI/KdqIwf2PSKFdkkxHFi/EXD7Cg6XcQgr5ktP2DSwVujn9zUz0PBD0A44qvBan/IS5SjpTwwf/50wJ2rZrJSmznbG9HlGDF/5xzVmL52nLKmFon03pArFkYU9MhXf+Gu1brAjptpllpLxccg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo0.onmicrosoft.com;
 s=selector2-vivo0-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=pGZ8vVYEdGEeFqa/5tb4dZHPb8IWs83sz1PdBYLJQ9M=;
 b=Hl5XTdSAOM4j48RCB6XexixtVR3prG5OpcU6+u0kam9wdxe3BLwYvln4Nq4MLsUI8NhiiCCMxAZBINv4GTbGiEPA8fe850k3F2BFRT3tz4zqOUE3xPNhhcdUEI0yAIBeGPzaRBwWoVeAit8+fKYOrSh0EgXG9wUENlrse+waD3Y=
From: =?utf-8?B?546L5pOO?= <wangqing@vivo.com>
To: Benjamin Tissoires <benjamin.tissoires@redhat.com>
CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	=?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>, Jens Axboe
	<axboe@kernel.dk>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd
	<sboyd@kernel.org>, Jani Nikula <jani.nikula@linux.intel.com>, Joonas
 Lahtinen <joonas.lahtinen@linux.intel.com>, Rodrigo Vivi
	<rodrigo.vivi@intel.com>, David Airlie <airlied@linux.ie>, Daniel Vetter
	<daniel@ffwll.ch>, Alex Deucher <alexander.deucher@amd.com>,
	=?utf-8?B?Q2hyaXN0aWFuIEvDtm5pZw==?= <christian.koenig@amd.com>, "Pan,
 Xinhui" <Xinhui.Pan@amd.com>, Srinivas Pandruvada
	<srinivas.pandruvada@linux.intel.com>, Jiri Kosina <jikos@kernel.org>, Dmitry
 Torokhov <dmitry.torokhov@gmail.com>, Alasdair Kergon <agk@redhat.com>, Mike
 Snitzer <snitzer@redhat.com>, "dm-devel@redhat.com" <dm-devel@redhat.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>, Hans Verkuil
	<hverkuil@xs4all.nl>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "linux-block@vger.kernel.org"
	<linux-block@vger.kernel.org>, lkml <linux-kernel@vger.kernel.org>,
	"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
	"intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>,
	"dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
	"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>, "open
 list:HID CORE LAYER" <linux-input@vger.kernel.org>,
	"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>
Subject: RE: [PATCH V3 5/13] hid: use time_is_after_jiffies() instead of open
 coding it
Thread-Topic: [PATCH V3 5/13] hid: use time_is_after_jiffies() instead of open
 coding it
Thread-Index: AQHYIg9EnfxyFxjNWkWg98nJO/5UWayUTUWAgAABLl4=
Date: Tue, 15 Feb 2022 09:03:35 +0000
Message-ID:
 <SL2PR06MB30825E9679FD33F7F8E71075BD349@SL2PR06MB3082.apcprd06.prod.outlook.com>
References: <1644890154-64915-1-git-send-email-wangqing@vivo.com>
 <1644890154-64915-6-git-send-email-wangqing@vivo.com>
 <AFkA4QAPE2Ol9ndmGVhdHKpl.9.1644914882392.Hmail.wangqing@vivo.com.@PENBTy1od0pKSzV5ZVcrS192THBXVjl0M1RzRWRrMHhDTy1FVHhlSnNYTTJjMTE3SnpOd0BtYWlsLmdtYWlsLmNvbT4=>
In-Reply-To:
 <AFkA4QAPE2Ol9ndmGVhdHKpl.9.1644914882392.Hmail.wangqing@vivo.com.@PENBTy1od0pKSzV5ZVcrS192THBXVjl0M1RzRWRrMHhDTy1FVHhlSnNYTTJjMTE3SnpOd0BtYWlsLmdtYWlsLmNvbT4=>
Accept-Language: zh-CN, en-US
Content-Language: zh-CN
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
suggested_attachment_session_id: cadb0166-f93d-29f7-b7a3-f209084af4ce
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=vivo.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: f91fe3ab-97fa-44c3-d80b-08d9f0620cae
x-ms-traffictypediagnostic: HK0PR06MB2482:EE_
x-microsoft-antispam-prvs:
 <HK0PR06MB2482905E315D173D3EB3B34CBD349@HK0PR06MB2482.apcprd06.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:6790;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 WHJdenequLjlJ752zdjZ57L24J0fYp70RJhGS6PyM5/LMoiNwh9lxJ9kxEXf/LUdeaKfHDBXETTClt7rLr/HAdF3HuY/yi5jbGex4RQf/9KWY9cxbvYSxORL9O/pau4Z9kGl40/NrJTCdp9YWJGEq07BlLzoVnkCQWNHSSPYlzhjrguv67pkq27f6TPcGGkqyaPnHpd8dVgEPI+0U1Xh1RPfL/KZ9HLmopk0kHHa2wl3QaqlnDqEDmLd1WkWyuCPYJAMK1lLNVgcfE8WthJaDZCq6z7DOql9XGWkQqUTsiinu53ljXbLALCPWgd855h7DcK8bopKfn1UoVlMHp+pEsCQReREZGanD1RjpjFyl4NN1ejwYU890Cg7Q54pBc6IxrmiKNKzzoGxA4pST/XZaSoMsannqj8YDA7bdRf486qAIEOeRb0KaSOYUwf5kHTjff8E09Bpk3+1Zh0xRrdassPDY5SAjUcyFFHuFVRA5dVGlND6rwYB6DmT+FpewRctdmkFls8xQcoo7jlSBcYPxYYqeUP9AeoAFSeX2v6XRPiJFnrcN5rTEV8GORU18O4i0RvcB7hoY/wYMn9Eu+uFCoK5W0zOAHaBwVuQJ9bzotdZCv9XnzEnBfZ9hRd0q0WtZNxndSVnChMZHnRhfF4FCW+pH0pt9EJqrWnVlyhPBbrzbGxKWITqDPtELRRREkSW87wBXVZ5mV0HVAIVyHbAQA==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SL2PR06MB3082.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(4326008)(122000001)(64756008)(66946007)(7696005)(7406005)(55016003)(508600001)(6506007)(91956017)(5660300002)(9686003)(76116006)(66556008)(66446008)(83380400001)(7416002)(66476007)(86362001)(52536014)(71200400001)(8676002)(8936002)(2906002)(38100700002)(6916009)(85182001)(316002)(33656002)(38070700005)(54906003)(186003)(26005);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?SU50dlArcGdlOEc4OXFINDRpdDlGdTVVYkg4RlVtWkJoYUxZNW5IL3FNUVNP?=
 =?utf-8?B?cmVQb3c0WXU2UkpqeGhJdjNjYTV3RHJOTDFJQjRCSEt5MjdjWHVKV1V5TUVE?=
 =?utf-8?B?K1BjdzNCUzhxdnBCVkZYRE9KSnY5Q0ZzeGdwTTljeEpwb3NMNTZXRE0rZGRD?=
 =?utf-8?B?Ungxa2VUR3UyTUNSdHFueXlyMXFYemRkakhraFl0am5IaHAzd1VhQnlkbnA5?=
 =?utf-8?B?QnRlTy91R081QzVRd0ZEcTczcXpDbmpiL21vM3NWOXl1NVU1bDR2aFNWdlVS?=
 =?utf-8?B?UDBxV0VhbG5lenV2ZEpuT205K3ZOOUFVL2JKNlI0OUo5SzVuOHpONExEd2x1?=
 =?utf-8?B?NWRMNys4ZkxQQ005bXI1dEtESEZiUGs0dk5hOExpRXF6NkYyVkdxTFJWZ3J1?=
 =?utf-8?B?WXowS2pxdlYwNzU0YXl0bHVFWjhqZDVSS3psclgwdXljRnR0MDFRL2k5Z25C?=
 =?utf-8?B?dmJweGc5aFZSRTVORzBtNUc3Q1hMYnRXSXFxWnMwSndIVWpYRDJvelJPWGNS?=
 =?utf-8?B?cC9yTUVUVzFaODVocXRzNElIVnlsVUdPZmVySUh5Sk5TVVV0eG5oY2dVdi8x?=
 =?utf-8?B?THFuTVpWVWJuNkZ0dStjYmRDdWFWNWh3TVlFRDdveFByc0graWVpNklwRFl6?=
 =?utf-8?B?TGhuTnhRcHR3TmhPY0Yvem5aSFRwZHl5T3NCZnkwZndjTUI1cW9MVThwZ296?=
 =?utf-8?B?bmdoV0FqQ0ZZMVg2MkFGZGZFODdqQXhSU3c5TXRUZVg2VmpBOThaYytpeG5G?=
 =?utf-8?B?OUVFL3NXMXp2UjROV1lINUsyV1VmZDhlbjNFZU1jaFJ3bWJ4c3hISS9UMXZx?=
 =?utf-8?B?c1JyNWFPbWZ1YXNXQnpxbVJ6NVRGZzVrL0Jrb0dlblZOTE1HbENMNU44ZFN5?=
 =?utf-8?B?WUJMRDBHakVQUVAvMHQvQXdSR3YrcU9YYUJXR1RhR1dLV1hPUHQxS2pSVVdC?=
 =?utf-8?B?N0V5R0h5QTRvbWtSQTdRanF1YjlQekt2R1NPVTg1TGlYSCtDMW16QzM5OGdk?=
 =?utf-8?B?aHNJenoxbkp3V0NvS28yenV6cmUzU2hmdkVvQ3NRS1V2OTZHQUhKYk85dTBw?=
 =?utf-8?B?YXA5aFJwcGtLVEVnQ2x6TUNLVTJDdDZJRWlsZWF6RW1wV3cvSGZnQzUxbzdR?=
 =?utf-8?B?b3ZRSXpIcGozUExEWGVlYTYweFE0a3dPdGNlS0MrK2xjL1VTcW5CMU9ndDNw?=
 =?utf-8?B?QzlXNHdTVXVzRjEzWTJkTDZiMDZadjVCVmNkU3dMS0RKZlppeWJ6QjdOSCt0?=
 =?utf-8?B?K1kxRUJkYUlYczY3Q2g3UHJINk5RTG5sOVpFTURoRi9FSmxKL0FiYzBCTmx6?=
 =?utf-8?B?QlpIMlBOVXhzVDIvWnVxUXoxS1hnTzVadVg1ZUFhd2lFUThJQ056R0RCbHJj?=
 =?utf-8?B?ekNicElla0N0enFKWTFVeTJnTnVWMkR2OUxHRmFrTUdsQi9sbnBiSU4wZEJZ?=
 =?utf-8?B?YTZjKy93RWlMY1JZRzBwaHZubzJ1OTI0VUNKTk9ZNHR2TU95aTBuN3FhZ3Ux?=
 =?utf-8?B?Y21CZGNobHFUNE5LdlJleUduMGZxRHRORUp3SG5yalNWSkpDWjFzNWs3NHBx?=
 =?utf-8?B?Y3B0eU1jYUtCdkMxWVdncGZpemx4MnMrT20xd2I4ZzcwY3M3THJMQnpBZmQ3?=
 =?utf-8?B?dncwNDA4ZmVLdmR3ZWIxRHBlQWJ6Y25BcDlEWm9yMmQ3YWFCOU9lVmZaeEcz?=
 =?utf-8?B?cjBoSi91d1hoUUxBSVZ3cTNCRko2MGk5SVkwcDd4MWI2Z3V6ZDVwMkVNNHBn?=
 =?utf-8?B?MDJteGxwSDdEMEE4c2I5czNyd2FsNis3RCtTRnNIWHBxaHhyQnAxY29OWVZE?=
 =?utf-8?B?ODJMb3ZENXNZeHc5UXh5OFpTVmplSG0wbDllVHJHTFgzSExPcjEwRWR3WXNj?=
 =?utf-8?B?V2wxOEZZZjJ5VmlSanZSMWV4MnVNYnBEWGd3T3hTMmNhL2ErRldHSEx1bkQw?=
 =?utf-8?B?NXlPaXlPR0pHdVRjVk5LS01mdmZPaTBSNXBFMzVRTjNKWmhxQ2dXdEF3dFRC?=
 =?utf-8?B?UnY1ZXVWdng0YVhhTk9CYzJIb0tGNmExRGhzTC9zV1lXc0dBN0NyQUFaTHMv?=
 =?utf-8?B?K3JRSUQ5ZUhqNVBQUUtrTWR0RkFpaU5ybU9kUWhqc1dkOXVxOEpzdUJQMmRv?=
 =?utf-8?B?WVJJZEdDdnFDSHBjQmg0NWVXNXVzdHZhS01POWdaYnpYcmFtRmdwRzZvRllr?=
 =?utf-8?B?dmc9PQ==?=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SL2PR06MB3082.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f91fe3ab-97fa-44c3-d80b-08d9f0620cae
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Feb 2022 09:03:35.8007
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 9wH0npR8CluoPGqmP2HJeFXUqq67lGSukIp+nLBWT0mWvc3/bUKXy4rkOv2bNsLCCOZBvjtIrs5GYJoR0Ftwaw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK0PR06MB2482

wqAKPj5PbiBUdWUsIEZlYiAxNSwgMjAyMiBhdCAyOjU2IEFNIFFpbmcgV2FuZyA8d2FuZ3FpbmdA
dml2by5jb20+IHdyb3RlOgo+Pgo+PiBGcm9tOiBXYW5nIFFpbmcgPHdhbmdxaW5nQHZpdm8uY29t
Pgo+Pgo+PiBVc2UgdGhlIGhlbHBlciBmdW5jdGlvbiB0aW1lX2lzX3tiZWZvcmUsYWZ0ZXJ9X2pp
ZmZpZXMoKSB0byBpbXByb3ZlCj4+IGNvZGUgcmVhZGFiaWxpdHkuCj4+Cj4+IFNpZ25lZC1vZmYt
Ynk6IFdhbmcgUWluZyA8d2FuZ3FpbmdAdml2by5jb20+Cj4+IEFja2VkLWJ5OiBTcmluaXZhcyBQ
YW5kcnV2YWRhIDxzcmluaXZhcy5wYW5kcnV2YWRhQGxpbnV4LmludGVsLmNvbT4KPgo+RldJVywg
dGhpcyBvbmUgaXMKPkFja2VkLWJ5OiBCZW5qYW1pbiBUaXNzb2lyZXMgPGJlbmphbWluLnRpc3Nv
aXJlc0ByZWRoYXQuY29tPgo+Cj5XYW5nLCBpcyB0aGVyZSBhbnkgcGxhbiB0byB0YWtlIHRoaXMg
c2VyaWVzIHRocm91Z2ggdGhlIHRyaXZpYWwgdHJlZQoKVGhhdCdzIHdoeSBJIGJhdGNoIHRoZW0g
aW4gYSBzZXJpZXMsIGJ1dCBJIGRvbid0IGtub3cgaG93IHRvIHRha2UgCnRoaXMgc2VyaWVzIHRo
cm91Z2ggdGhlIHRyaXZpYWwgdHJlZSBkaXJlY3RseS4KCkkgd291bGQgYXBwcmVjaWF0ZSBpZiB5
b3UgY291bGQgaGVscC4KClRoYW5rcywKV2FuZwoKPm9yIHNob3VsZCBlYWNoIG1haW50YWluZXIg
dGFrZSB0aGUgbWF0Y2hpbmcgcGF0Y2hlcz8KPgo+Q2hlZXJzLAo+QmVuamFtaW4KPgo+PiAtLS0K
Pj7CoCBkcml2ZXJzL2hpZC9pbnRlbC1pc2gtaGlkL2lwYy9pcGMuYyB8IDIgKy0KPj7CoCAxIGZp
bGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKPj4KPj4gZGlmZiAtLWdp
dCBhL2RyaXZlcnMvaGlkL2ludGVsLWlzaC1oaWQvaXBjL2lwYy5jIGIvZHJpdmVycy9oaWQvaW50
ZWwtaXNoLWhpZC9pcGMvaXBjLmMKPj4gaW5kZXggOGNjYjI0Ni4uMTVlMTQyMwo+PiAtLS0gYS9k
cml2ZXJzL2hpZC9pbnRlbC1pc2gtaGlkL2lwYy9pcGMuYwo+PiArKysgYi9kcml2ZXJzL2hpZC9p
bnRlbC1pc2gtaGlkL2lwYy9pcGMuYwo+PiBAQCAtNTc4LDcgKzU3OCw3IEBAIHN0YXRpYyB2b2lk
IF9pc2hfc3luY19md19jbG9jayhzdHJ1Y3QgaXNodHBfZGV2aWNlICpkZXYpCj4+wqDCoMKgwqDC
oMKgwqDCoCBzdGF0aWMgdW5zaWduZWQgbG9uZ8KgwqDCoCBwcmV2X3N5bmM7Cj4+wqDCoMKgwqDC
oMKgwqDCoCB1aW50NjRfdMKgwqDCoMKgwqDCoMKgIHVzZWM7Cj4+Cj4+IC3CoMKgwqDCoMKgwqAg
aWYgKHByZXZfc3luYyAmJiBqaWZmaWVzIC0gcHJldl9zeW5jIDwgMjAgKiBIWikKPj4gK8KgwqDC
oMKgwqDCoCBpZiAocHJldl9zeW5jICYmIHRpbWVfaXNfYWZ0ZXJfamlmZmllcyhwcmV2X3N5bmMg
KyAyMCAqIEhaKSkKPj7CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCByZXR1cm47Cj4+
Cj4+wqDCoMKgwqDCoMKgwqDCoCBwcmV2X3N5bmMgPSBqaWZmaWVzOwo+PiAtLQo+PiAyLjcuNAo+
Pgo=


From xen-devel-bounces@lists.xenproject.org Tue Feb 15 09:12:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 09:12:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272874.467859 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJtsT-0002lD-RT; Tue, 15 Feb 2022 09:12:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272874.467859; Tue, 15 Feb 2022 09:12:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJtsT-0002l6-NT; Tue, 15 Feb 2022 09:12:05 +0000
Received: by outflank-mailman (input) for mailman id 272874;
 Tue, 15 Feb 2022 09:12:03 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJtsR-0002kw-JS; Tue, 15 Feb 2022 09:12:03 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJtsR-0005Lg-FY; Tue, 15 Feb 2022 09:12:03 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJtsQ-00034r-V0; Tue, 15 Feb 2022 09:12:03 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nJtsQ-0006ZP-UG; Tue, 15 Feb 2022 09:12:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=7iLdEYusF3GX20oRExRXvj8jISujOgVUjrZZI4ZCPtA=; b=UKu+dMW/EtUvf2iKuOBVMidoTz
	FFNPObRQJQgQuLfWe0vQgDnCClIxCFFJV6scWsMehfh7mRXQ+lJ7TiuxUJxZt3W776Tjx0VTmcLTo
	Wm3dhdY2kWtPHuI/YQCAwTTc51KUwjiN7EbJZDcnP4xCrcpSkw799nPTqWiT52B9DRLo=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168112-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-5.4 test] 168112: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=52871671099d1bb3fca5ed076029e4b937bfc053
X-Osstest-Versions-That:
    linux=76fd334f07cc11e047c2237a19b2cf8b1f653ba2
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 15 Feb 2022 09:12:02 +0000

flight 168112 linux-5.4 real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168112/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168060
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168060
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168060
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168060
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168060
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168060
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168060
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168060
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168060
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168060
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168060
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168060
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                52871671099d1bb3fca5ed076029e4b937bfc053
baseline version:
 linux                76fd334f07cc11e047c2237a19b2cf8b1f653ba2

Last test of basis   168060  2022-02-08 17:43:16 Z    6 days
Testing same since   168084  2022-02-11 08:43:38 Z    4 days    9 attempts

------------------------------------------------------------
People who touched revisions under test:
  Florian Fainelli <f.fainelli@gmail.com>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Guenter Roeck <linux@roeck-us.net>
  Jon Hunter <jonathanh@nvidia.com>
  Jon Maloy <jmaloy@redhat.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Linux Kernel Functional Testing <lkft@linaro.org>
  Shuah Khan <skhan@linuxfoundation.org>
  Slade Watkins <slade@sladewatkins.com>
  Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
  Ulf Hansson <ulf.hansson@linaro.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   76fd334f07cc..52871671099d  52871671099d1bb3fca5ed076029e4b937bfc053 -> tested/linux-5.4


From xen-devel-bounces@lists.xenproject.org Tue Feb 15 09:41:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 09:41:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272885.467870 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJuKf-00064H-5u; Tue, 15 Feb 2022 09:41:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272885.467870; Tue, 15 Feb 2022 09:41:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJuKf-00064A-2d; Tue, 15 Feb 2022 09:41:13 +0000
Received: by outflank-mailman (input) for mailman id 272885;
 Tue, 15 Feb 2022 09:41:12 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=vySV=S6=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nJuKe-000644-E7
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 09:41:12 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 66ce1062-8e43-11ec-8eb8-a37418f5ba1a;
 Tue, 15 Feb 2022 10:41:09 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 66ce1062-8e43-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644918069;
  h=from:to:cc:subject:date:message-id:
   content-transfer-encoding:mime-version;
  bh=RSuhqeY7HnlBNNGy2i65XswlJ+o1LeiKifGwJsqnO9I=;
  b=TGGciAchI0JT3K26DKLSlr4eeuEpj1OJkol2+LdSPLnYZxh2FM9mwnaD
   7GuRikBJrBallVjIoLbd4bpzvu6eAFtvirsn7aG/pe8c49wkEh61Rasbo
   ozZ2GwEuKGWFnJuSPpOPTHnKwlyJDQjS/wBNDCVmO3og90zvGbTB9AY6N
   Y=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: jZnQ9vxquUa/lqTDun32g+48I7XEqHw2ypSqd76V/sjyL1TZ2vMl3dXfQPctXZI/gk/lCJ7ZU2
 YtBKlctHcc2EefzGZKwb5npl3MHFyVhPMMQAWQLwmflSSp3kHiFELZ55jrsFZCg/Vwy/A4bia/
 wiEsFBlhpdfYM/wgvIHD6h9mbue3mKohpvNpoEWI6x2/fkqgIfjSzU4DMq1Au3znkYN+L5Ljud
 4jp5lQCYRhA5PrvdL+/wF0zteS0BykkGd4yBVvgTqWA7Gmp2xkY+YbB1ZPMCo9lt/9gZYMJIsx
 ybmMrWWAu5+YE7WJ1zRdCl70
X-SBRS: 5.1
X-MesageID: 64125897
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:pzHk+6traEmnsSPD24xBCP9MR+fnVKZZMUV32f8akzHdYApBsoF/q
 tZmKW+EM/jeMzGkf9kjPt+/9xgGscOGz4A3SVBu+S5hEC0S+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZQP0VOZigHtIQMsadUsxKbVIiGHdJZS5LwbZj2NYy2IXhWWthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 Npl9p6OF14xJv32sv1BYQBjEChFDYtJ9+qSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DJoQQt2sm1TjEJf0nXYrCU+PB4towMDIY2JwXR6uON
 pVxhTxHSBuZXUB2AgkuBKkPrMLvrCXDKAJ1twfAzUYwyzeKl1EguFT3C/LOYcCDT8hRmkeep
 0rF8n7/DxVcM8aQoRKa9lq8i+mJmjn0MKoQCbm5+/hCkFCVgGsJB3U+RVa95PW0lEO6c9ZeM
 FAPvDojq7Ao806mRcW7WAe3yFaGtBMBX9tbE8Uh9RqAjKHT5m6k6nMsF2AbLoZ87YlvGGJsh
 gThc87V6SJH87+rFyuF7ueuhyruCzEuLmY5VQkLQl5QizX8m70bghXKR9dlNae6iNzpBD39q
 wy3QDgCa6Y71pBSifjilbzTq3f1/8WSEFZpjunCdj/9tmtEiJiZi5tEALQxxdJJN86nQ1aIp
 xDocODOvblVXflheMFgKdjh/Y1FBd7YalUwYnY1RvHNEghBHFb5I+htDMlWfhsBDyr9UWaBj
 LXvkQ1Q/oRPG3ChcLV6ZYm8Y+xzk/S8SoS1C62MN4EUCnSUSONg1HswDXN8Iki3yBR8+U3BE
 cvznTmQ4YYyVv08kWveqxY12r433CEurV4/trigpylLJYG2PSbPIZ9caQPmRrlgsMus/VWEm
 /4CZpDi40gOD4XDjtz/rNd7waYidiNgW/gbaqV/K4a+H+aRMDh6VaGImep7I9MNcmY8vr6gw
 0xRk3RwkTLXrXbGNR+LejZkbrbuVox4tnU1IWonOlPA5pTpSd/HAH43e8RlcL852vZkyPIoH
 fAJd9/ZWqZESyjd+iRbZp749dQweBOujAOIHiykfDlgIMIwG12XoofpLln16S0DLiurrs9i8
 beu4RzWHMgYTAN4AceINP/2lwGtvWIQkf5ZVlfTJoUBY13l9YVncnSjjvI+L8wWBw/Ewz+Wi
 1SfDRsC/LGfqI4p6tjZw6uDqt7xQed5G0NbGUjd7Kq3anaGrjbyn9cYXb/RLz7HVW7y9KGzX
 slvzqnxYK8dgVJHk4tgCLI3n6gw0MTi+u1BxQN+EXSVM1nyUuF8ImOL1NVkv7FWwuMLohO/X
 0+C94UIObiNP8+5QlcdKBB8M7aG3PAQ3DLT8e40MAPx4youpOiLVkBbPh+tji1BLeQqbNN5k
 Ll54MNGuRaijhcKM8qdinEG/muBGXUMTqE7u8xIG4TskAcqlglPbJG05vUaO31ThwGg6nUXH
 wI=
IronPort-HdrOrdr: A9a23:iOLetKh0TQSe/SnvaEWa2XZF1nBQXzZ13DAbv31ZSRFFG/FwyP
 rAoB1L73PJYWgqNU3I+ergBEGBKUmskaKdhrNhR4tKPTOWw1dASbsN0WKM+UyHJ8STzJ8+6U
 4CSdkANDSTNykCsS+S2mDReLxBsbq6GciT9JvjJhxWPGZXgs9bnmJE4lHxKDwKeOAKP+txKL
 Osou584xawc3Ueacq2QlEDQuj4vtXO0LbrewQPCRIL4BSHyWrA0s+wLzGomjMlFx9fy7Yr9m
 bI1yT/+6WYqvm+jjvRzXXa4Zh6kMbojvFDGMuPoM4ILSiEsHfhWK1RH5m5+BwlquCm71gn1P
 HKvhcbJsx2r0jce2mkyCGdrzXI4XIL0TvP2FWYiXzsrYjSXzQhEfdMgopfb1/w91cglMsU6t
 MG40up875sST/QliX04NbFEztwkFCvnHYkmekPy1RCTIolbqNLp4B3xjIZLH45JlO11GkbKp
 guMCmFj8wmMW9yLkqp9FWH+ebcEUjaRXy9Mws/Us/86UkioJk29Tpb+CUlpAZwyHsKceg32w
 31CNUXqFhwdL5nUUsEPpZ4fSKWMB27ffueChPlHbzYfJt3SE4l7aSHpYkI2A==
X-IronPort-AV: E=Sophos;i="5.88,370,1635220800"; 
   d="scan'208";a="64125897"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=nzHbdYxIhbTOnoaaEJWEVPBYKNwl0Awp9OzPqQnrH14pcyyu0FRRkE66uiHmduhYC6qOoVdzTmZnqNMSiglWAlBJl3JuIpnNXTBPWQi+Z4GRkfBaDXUffDtbd1+QW8PDgjFUVVnCHbNs9U6/T3HudhlYa4EwJzyExRa2vlB3B7WneN0SQow5MpQ71F6kGlrqTwBREiHGXmmvqdV2WWuGqn3DGbgyXuM2z+1bgDPflUACov9qgv+uEib+SAseZjcFgwVp/+TfOuWXDCHCGaT5oh6h1MTp5EMuJLdPcHuv9kb4D9XuWgAHkxnRYX0WRmCipUQEAao3bG4ynuc4GuUEnA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=SGQ+PEr0Xkvv6f6pzW4fFhaM/PSZBG+XpUJ/niOegzw=;
 b=flrLG3/D4vbxIySzDkGWW2clgHp5GB51qpYbs+N3UqBzQDAl0v/gZFtaQGVp6sw7/V4LP5RNdQhDuzzbroXCdDWZY97ZbcciT09f6wUMVXol6II4wGcXTN3qVPMjU5Gk+vPcbyl7GNaDaJXExJp3UzEbciq/xoG0UEfSlg5bgDqYSrl45NzW3f5KnyXuDM7xnqh+XWztiqEKRApYt0qD2gckaE059U5nS9JBmxIrJi45pYt2mGKcrdxHnECFcy1mr+SAxZheGUt+9MK6mpibkJIcnl8mX22rcu0aMRXF6uf7c71AylXmAT872sFfUCsKmDr0nP1YgVuWDXZ/9tt+SA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=SGQ+PEr0Xkvv6f6pzW4fFhaM/PSZBG+XpUJ/niOegzw=;
 b=BdV7f8CF8GWhLTz23mYSJ2vz/1EKX5AL/6KNpsBkhel4iABcIAlY3QFPqDS5tVwfTeO0XPTDNBvWWSvaCWiVkP9tkt4JhW4Fl3Sr921no2h3IBHuJueXjWrKYieKpu37aVOBzXtJ7uUS0ufIgbNblJj+5AUyxwBSvvozA1VoAow=
From: Roger Pau Monne <roger.pau@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Roger Pau Monne <roger.pau@citrix.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, Jan
 Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>, Stefano
 Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Subject: [PATCH] rwlock: remove unneeded subtraction
Date: Tue, 15 Feb 2022 10:39:51 +0100
Message-ID: <20220215093951.97830-1-roger.pau@citrix.com>
X-Mailer: git-send-email 2.34.1
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO4P123CA0487.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1ab::6) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e6df0cf1-0558-4ad5-c11e-08d9f06747b2
X-MS-TrafficTypeDiagnostic: MWHPR03MB3053:EE_
X-Microsoft-Antispam-PRVS: <MWHPR03MB3053D60CF7CD61FA2059FF688F349@MWHPR03MB3053.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6430;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: wGxWcQzMa6smYIyXYAkdIjeJrLBtcQRANPkq2iiyARE5nlCl9lvzsPjrBPCNkje0tJ4I+5iGPNuKBMMPdz21qNhiRPm+EbGRoCUfXoW9OhLudZ3wwRAhqdelq42rAkmvA3QCjqnBQ7bemf72lfKjO4cpuDNWtFAYUKRDMG+RM+WbNDZ+AowDlMLYaXwsd8TBCXfywXUfeyg9F5QsZRhOGCfecvixiY8kpuVR5sxAC4VUHEJvI1oTaQtfQAYZ5wD+IbqPQR6pDouBNV/A2J7MgwMiCS1VByPfDrWxgjUtvArNBGYwhjC4dLiIvSsjDKPVGW99+FclXFEs5v0uIquaA0mUfQ8FswyER3qy5poGVeA7r2v8TDU/0viutFCQ1/sh/ZK4gZohWEFAzTlpQtt3exoUxDKLlhay970svlMQRsU/uJ+himYHLmudCZ74mn4r4g8GzppnGat2Yw7mUEWta6qXoSJnt6boTXJn1aOuuXIAEsf3drTiq/oeYodmQ2RXlgzTgwuFnfPBzI8PIQvPeB4yuxyN+0BDYx01EqRd6QCvajmfMoOf4dqDi1MjZ2mUQn5SqVYPc0lUD03ATWvGnYM4NXa2bUDH8rYW7uZ5lflVXWCOZZHlTUZkglEi6QcAwp5WhgbTNuquLCORfBWNZg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(8676002)(66476007)(66556008)(4326008)(83380400001)(6512007)(6666004)(86362001)(66946007)(36756003)(2616005)(508600001)(1076003)(8936002)(6506007)(5660300002)(6486002)(4744005)(316002)(26005)(186003)(38100700002)(6916009)(82960400001)(2906002)(54906003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R25jNGNHNitCRG9TYnpOSFpyMTRuMTJqYmR0QkxHWjl6bjZCNHZzSytmOTBa?=
 =?utf-8?B?M1cvU2l6NHdxbFFNUU5kTmVWZHRQRDBmdnh2NjJiVUYyZk16M2ozNEtSd3B0?=
 =?utf-8?B?SHUrbjZnWkFkcm9DL01Ia0s0eFVqRi9PTWVxcmlsYnBWWmpuSWM0OFZhblMw?=
 =?utf-8?B?aU5yOXlPanB4ZnhXQm1aVjJYZE1NMVJMd0lXZktYMkRHbTMvYVdVdzVBL2c4?=
 =?utf-8?B?VjFkdjlxZXA5UFBsTXliWllaangvWGpOWC83U3ZBa2xUYkU2Vm96SEU1KytN?=
 =?utf-8?B?U2FsMmxxdU9IZC9mQkJHYVNibkNpQnpoeVpnam5UOHRNYnltMDlqTGIvT0tC?=
 =?utf-8?B?aGpoN3VnanZxbVo1ZDM3VFhwbTZ6a0FjQmRuREdyTWtlNG5SU2FVMEVNU1RH?=
 =?utf-8?B?U0FTZnFkRTBUSnhwRFRtSml2OWpJa2VjUTdIQ2NGT3VZN2IyelF4T0FBSnJr?=
 =?utf-8?B?OVU1MGNZWkRWSVhsODV0b3d0RkFRZG5jeUFsc1BNKzhxOVNoTWl5T29ZQTBE?=
 =?utf-8?B?SmhqUGJMek5uQVRSOVRkN295d1JLdEVpeENQMThPNytBVVc1K25JR0NJYURQ?=
 =?utf-8?B?TWgva2N6eHpVeXRXNXVYeE1Bdkg3K01NRjJLUXk5TzZBWmp2aEFEaFhPQ08x?=
 =?utf-8?B?bEY3VFl3U05OelZUNnRITE9NM0ZMblJiTFBFM3p3QWkyM2RxdktaQWZRUkY5?=
 =?utf-8?B?dE43Sjd5bjNBUWxXWWtxTTNpMlpuc0o4WjU1bTM0K3l5Wm92UzNoT1pDRWpl?=
 =?utf-8?B?c0tyUUxwZmlqTzIwcDZsOGowZURmbHFDK3FHZmZkY0NJejUwOEtFeDc5RHB3?=
 =?utf-8?B?Mnl6WjQwdElHbXRteEtSa2VMOG5rNGhMQVJnUEQ2VkdYSUcvT0QxVkM3dkFh?=
 =?utf-8?B?bFplR0JwMzVrRy9MaU1aY2dNQkNCMCt3ZGFtMkNXekYxUzFXL0FYbXRPMEhT?=
 =?utf-8?B?RlZrdmlmZFkvMHREdEJkMVl6Nnl6WStQTFNhT2t4NW1ERUFyNytudUl6L2tu?=
 =?utf-8?B?aXNoMVdXMmo5dmxoYVdTNGtmVTlKNnBlSlgyR2pabWlhbVpJNFNVemtLUTZ3?=
 =?utf-8?B?Rnd3WmRMRFNSdmVZUFVGWXIxS2pOQUUwb2k2eWlNS2Q4ZnIrMTZRdnFWZm04?=
 =?utf-8?B?SWM4TVNoMEk4dFdkSC9Ba3A2QStySEFGUFV3UUt6aEsxK1hMQVFuc2U4N2M4?=
 =?utf-8?B?Q0hTbmFUMHlhbkdwNUlqZi81YkVSYllNRmw0M0JoL1QzMWhUVlZlNTlhL3I4?=
 =?utf-8?B?VWZMcmp6UklBZGZDeVdWcHJaNmFFbHdPZ0pZcUFPSTczdWFncXJJa2VpZnAy?=
 =?utf-8?B?VmNEQ2srZ1dZWlFaaXVhT3dXQWFKbEFZejFtQVdtcS9QSVJzTWI0Tkx2VG5O?=
 =?utf-8?B?eU9ZWkRlblRTbkJVbEVwekpUSDlUZG00bjhOR3VIVHdHaEVBZmxFMXNMdzY5?=
 =?utf-8?B?TG9vN01DMTkxVFRLRWlBSnF5ZFBFSkpkekhDOHU0N1ZRaHVFMGN2bytmcyty?=
 =?utf-8?B?RThKeWFhTUQ4dmpmOEU5eEc3RlhTeTVoRFJUSVBiZWFUQVpuMHBLbE1nVVJO?=
 =?utf-8?B?SnNBK1lnZmp4dU0zR0JNcnprRnF3b3RKdTczemVnOWNURmVCNkZSeWdQVWth?=
 =?utf-8?B?Z1RRcVVIRnkrTjZidXEzcFlxWXBCZjlkVkZjK3JlVUhrcUhpczFvemJtQlRE?=
 =?utf-8?B?STNQVmxESXVJYVhpRlNrTnhiaFBQaTdlOGwvdWJGS0dXdU13UklNczhEMjUy?=
 =?utf-8?B?d3YrTTVuSFBZYVNDMy9NblZEd0h0T1Axamp1VHJGaDd3UDJpUHUzbC91WXh5?=
 =?utf-8?B?SVk3NGRJTElNUFl4MExUdks3SkNDNmJOM2VMSEsxdEhOaE1FRUorMlB5K0xo?=
 =?utf-8?B?K1VpMGladW56R1N5YVlVY1d1OWVDNWFGbTJCLzE3aFpqUzRiMFNkSjA0bGwy?=
 =?utf-8?B?QzRiVEdGZXJybmJIaGhiSkxsWGZ1a3B4bUhCWWRNcTBWL2Q0UXpabFR3ZlFS?=
 =?utf-8?B?QlpINUl3dXlOSVJhZnVXNjBYTnFLSnJLZVY1VGdVeFhJVzRCZWlxNE4rQTVk?=
 =?utf-8?B?ZlNQRnVOekpMZkdvVUl4ZlVIRThEV1daM2tiNFlrRUowL3dhbUZTSER2MWZT?=
 =?utf-8?B?ZFlXeHgrWnpYOU1pczJhZ2g2Wkd6bEVvUWcyaHlzUlc1ZmMwWUJUMS8xVVhG?=
 =?utf-8?Q?P5R7Kt2X9CRvJ4lXrljYTAI=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e6df0cf1-0558-4ad5-c11e-08d9f06747b2
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 09:41:02.5768
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kCKdK+D90pCOBMmZnvgHT6V/weArGTHIOG0KD7oHIhg0kJWihL4xgMkJ7EUfyrK9oH4dpRhnBc2VLQXi7PS/vg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB3053
X-OriginatorOrg: citrix.com

There's no need to subtract _QR_BIAS from the lock value for storing
in the local cnts variable in the read lock slow path: the users of
the value in cnts only care about the writer-related bits and use a
mask to get the value.

Note that further setting of cnts in rspin_until_writer_unlock already
do not subtract _QR_BIAS.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
 xen/common/rwlock.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/common/rwlock.c b/xen/common/rwlock.c
index dadab372b5..aa15529bbe 100644
--- a/xen/common/rwlock.c
+++ b/xen/common/rwlock.c
@@ -47,7 +47,7 @@ void queue_read_lock_slowpath(rwlock_t *lock)
     while ( atomic_read(&lock->cnts) & _QW_WMASK )
         cpu_relax();
 
-    cnts = atomic_add_return(_QR_BIAS, &lock->cnts) - _QR_BIAS;
+    cnts = atomic_add_return(_QR_BIAS, &lock->cnts);
     rspin_until_writer_unlock(lock, cnts);
 
     /*
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Tue Feb 15 09:45:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 09:45:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272894.467881 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJuP5-0006mq-RB; Tue, 15 Feb 2022 09:45:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272894.467881; Tue, 15 Feb 2022 09:45:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJuP5-0006mj-O9; Tue, 15 Feb 2022 09:45:47 +0000
Received: by outflank-mailman (input) for mailman id 272894;
 Tue, 15 Feb 2022 09:45:46 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=vySV=S6=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nJuP4-0006md-N8
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 09:45:46 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0b08655f-8e44-11ec-8eb8-a37418f5ba1a;
 Tue, 15 Feb 2022 10:45:45 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0b08655f-8e44-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644918345;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=iw8WzCaDfNAox61c1XTlHvprnyEm93V7Mqc/NxaYPBw=;
  b=IxliJv5vl/drwFWN+IVNqzH8V12c9mxm/rzonCJAzAgNOgYJHotMzuc3
   suDbD00KLZalLdkLlKqrC8LSSj2PvPs2+w6+zfZFcOjsbTKnCwuzlo9LO
   XyNkDbokGT7H8AL5nkjHsVaehANmziTPiBcJAZcAMTVKCK7KMALwY6kvE
   0=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: Wy0OJLz6BuLKyYyzm2UoNMMOAxz6G/3neQcF9aSpcIkhlg978QlODMMVsPPe3DjUQ6eUeSIp/n
 QCthxswFYy1Li6iyC2ZtdJHyNrkEtlM/dJ0mZo+66T22pj6nB9njXhj83O6ONETK/QicZW5wlU
 opmuewDGpJvhcKVUKcG73ea1cuyrrUmc8Oet+JEl0zRkXdWBKLXmJo94XBUDUJudcj5rt8BtvF
 GHjdDsFOUt9K3t/++aa6dj2bPfJTHQwcNP3FvGRMMHD6Z8J9WbzVRwNVJL4cgkHj2UAE6Ds4s+
 6Tm7v4IVEWwyQ4Vi2lgpkYS8
X-SBRS: 5.1
X-MesageID: 64225888
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:tZEQHKA8LLgQLhVW/zbnw5YqxClBgxIJ4kV8jS/XYbTApDh3gTMPz
 jRNC2DQPavcYmuhKoh/PNmz9E0AsMCGzIBmQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMo/u1Si6FatANl1ElvU2zbue6WL6s1hxZH1c+En970E87wYbVv6Yz6TSHK1LV0
 T/Ni5W31G+Ng1aY5UpNtspvADs21BjDkGtwUm4WPJinj3eH/5UhN7oNJLnZEpfNatI88thW5
 Qr05OrREmvxp3/BAz4++1rxWhVirrX6ZWBihpfKMkQLb9crSiEai84G2PQghUh/jG/Yxf1Q4
 tl39pGrYBkFMfaStMs9akwNe81+FfUuFL7vJHG+tYqYzlHccmuqyPJrZK00FdRGoKAtWzgIr
 KFGbmBWBvyAr7veLLaTUO5ji95lNMD2FIgepmth3XfSCvNOrZXrHfmQv4IIjGdYasZmItDdR
 OpeQGFVZw3vPjpoPEg7M79ltbL97pX4W2IB8w/EzUYt2EDfxQpw3bzFPtTKftjMTsU9tk+Zv
 GbH8mjRBhAcKczZyDft2mirivXOkiS9RoMMFZW58OJnhBuYwWl7IBQSWEuyp/W0kAiyVs9UK
 0EO0iMroe4580nDZsLnXhu5vnef+AYVXdZKDvMz5AilzqvS/hbfB24YQzoHY9sj3OcGRDoqy
 17Pp9rvLTVqvPueTnf13ryUtzKpJSkcKykBYiICTAQt6tzv5oo0i3rnTNFkFqeuyNn8GS3xx
 T2MhCw/gagDy88Ny6i/u1vAhlqEpZ/PVAc5oBrWWmGN6Rlwb4qoIYev7DDz7/dDK52xTVSbu
 nUA3c+E44gmCZCLiTzIRegBHbiB+fmIKnvfjERpEp1n8C6ik1aqbYpX7Rl9KV1vP8JCdTyBS
 E3avwIX4p5QIX+jRat2ZZ+hTcUs0aXkU9/iU5j8ddBJc5RZdwKd+ixqI0mK0AjFlVQxi7giN
 IuHfO6mBGceCK59wXy9QOJ1+bUmwCI3wGLVA4z61A+g0KCTf1aPRLsFOUfIZec8hIuAoQPI4
 5NUM8ii1RpSSqv9bzPR/IpVKkoFRVA/BJbru4lUe/SFLw5OBm4sEbnSzKkndogjmL5a/s/M/
 3egSgpSzF30hlXZJgiQLHNucrXiWdB4t31TFS0qIVusnnctca6r7bwDbN05Z7Qq+OF4zuJzV
 78CYcroKutGTDve+jISRYf8soskfxOu7SqHOibgbzYvV5phXBDSvNH+cwbj+TINEi2v88wkr
 NWI2hnaBJYOWQlmJMLXc+60iV2rsHURlflxQ0zQZN5Jdy3E4IVsbiD8kPIzC8UNMgnYgCuX0
 R6MBhUVrvWLpJU6mPHAiqOstYqlE+JiWEFdGgHz4bO3KTPLuHak24hDUOGWVT/YXWLwvq6lY
 I19y/D6Le1CnVBSrpZUDblm1+Q96sHpqrscyR5rdF3QaVW3GL56CmOL0clGqutGwboxkQuoV
 1iM59heEaWSZMrhFBgXIGINa++D2PEdkBHR4O4zLUG84zV4lJKLVABeMgeBjARHIbd1OZ9jy
 uAk0PP68CTm1EBsaIzfyHkJqSLcdRTsTpnLqLkdWt6xpysBxmsBbIf1FAP5u8+jRPV1ZxxCz
 iCvuILOgLFVx0znenU1FGTQ0ec1uaniqCym33dZeQ3Xx4OtausfmUQIrG9pFlg9IgBvjrorU
 lWHIXGZMklnE91AoMFYF16hFAhabPFy0hygkgBZ/IE1oqTBa4AsEIHfEbvXlKz62zgFFtS+w
 F1/4Dy7OQsGhOmrgkMPtbdN8pQPt+BZ+AzYg9yAFM+YBZQ8ajeNqvbwOTZX+0u6XJto3xevS
 QxWEAFYM/OTCMLti/djV9nyOUo4FHho21Cusdk+pfhUTAkwiRm52CSUKlDZRy++D6eizKNMM
 OQ3fpgnf03njE6m92lHbYZRc+4ctKN4v7IqJ+K0TVPqRpPC91KFRrqLrXOg7ILqKv0z+fsAx
 nT5LmncTDXI3CEMxAcgbqBsYwKFXDXNXyWltMid++QVDZMT9uZqdEA5yLyvuHuJdgBg+nqpU
 MnrPcc6FsRultZhmZXCCKJGC1nmIN//Tr3Qoguyr85PfZXENsKX71EZrVzuPgJ3O7oNWosoy
 eTR4YCvhE6V7qwrV235moWaE/Ub78uFQ+cKYNn8K2NXnHXeVZa0sQcD4W2xNbdAjMhZupu8X
 wK9ZcbpLYwVVt5RyWd7cS9bFxpBWa37Yr25/XG2ruiWCwhb2gvCdYv1+XjsZGBdVykJJ5yhV
 VOk56fwvohV9d0eCgUFCvdqB45DDGXiAaZ2JcfssTS4D3Wzhg/QsLXVihd9uyrADWOJEZim7
 MudFAT+bhm7pIrB0Mpd795pphQSAXtw3bswc0Ya94Ikgjy2Fjdbf+EUMJFAAZBIiC3ikpr/Y
 WiVPmclDCz8WxVCcAn9v4u/DlvOWLRWN4erPCEt8mOVdzyyVdGJD7ZW/yt952t7J2n4x+a9J
 NBConD9M3BdGH2yqTr/MhBjvdpa+w==
IronPort-HdrOrdr: A9a23:W5eZqKtRS/7uml8SUMgj8fDR7skC7oMji2hC6mlwRA09TyXGra
 +TdaUguSMc1gx9ZJhBo7G90KnpewK6yXdQ2/hqAV7EZniahILIFvAY0WKG+VPd8kLFh4xgPM
 tbAs1D4ZjLfCRHZKXBkXiF+rQbsaC6GcmT7I+0pRcdLj2CKZsQlzuRYjzrbHGeLzM2Y6bReq
 Dsgvau8FGbCAsqh4mAdzI4dtmGg+eOuIPtYBYACRJiwA6SjQmw4Lq/NxSDxB8RXx5G3L9nqA
 H+4kHEz5Tml8v+5g7X1mfV4ZgTsNz9yuFbDMjJrsQOMD3jhiuheYwkcbyfuzIepv2p9T8R4Z
 PxiiZlG/42x2Laf2mzrxeo8w780Aw243un8lOciWuLm72OeBsKT+56wa5JeBrQ7EQt+Ptm1r
 hQ4m6fv51LSTvdgSXU/bHzJl9Xv3vxhUBnvf8YjnRZX4dbQqRWt5Yj8ERcF4pFND7m6bogDP
 JlAKjnlblrmGuhHjDkV1RUsZ+RtixZJGbFfqFCgL3Y79FupgE586NCr/Zv20vp9/oGOu55Dq
 r/Q+BVfYp1P7wrhJRGdZM8qPuMexzwqC33QRCvyHTcZeg60iH22tbKCItc3pDeRHVP9up0pK
 j8
X-IronPort-AV: E=Sophos;i="5.88,370,1635220800"; 
   d="scan'208";a="64225888"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ilaZ4q+uZdIfts/UFRJeZaM0CaSfhaUI5TOPze+hbufN+hwg5iWKU+RMjTQULAQhBl99p2QyPToVJweQ/2ilYug59c0JmprjOLhZQDG3ejuxIG3vDoO0TxH0SaQ7yxEQUOyLKzn+g3tF9cpUGtvN39RVhZB0k4Bn6TaPQYvfReDO92Mm3wU89wkzKZM5UHWITDAoRioOk6YKm9ad92P2EEW1CRQvEXwPwvrp3TQpF8GLXF/DYX0A/fiv8r59VxMGtizra6BUFqJMriKPpsMKvytZTVuuJKyyn/BIQHU9Pn4Dsqql31vGLQN6XmAN/jFRqCVGbmcWhsovVEp5APThpg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ZGfL1e1bMDpYfkGiAfrTfHC/8z7eJZ5Kbc5EER5I8Tw=;
 b=g8+HFMAudfrhF88CIlb9USB4nGjlF4auwIeYzZnxFXCbg4+gjWXDgsLiW9mvxTxKAEODZFjcJKVOuXG/mF3DCc7SCg1VEcDmUELS2FfIxT8QnTqBPzAKehh4uJaOe2+JRGiwEwsl83tEXLkmZfZ1UVKZI3aFbEBTwUYI0VaFPSy8z44kxcHyi1KIMWk5JOyMQDbw3ytlnrJxtt2P0Ak+nfRHoQGM0P/y6k6GkeXE/yIZVVjNDuAfd7IwCCExqvi/PqougbcOZOoylnhjhZiEDYZh3XXTUg9NGy7ixAEK4As9so8okofMIfEnghM1FKJ8wDzzGnaHEY3AKmQLzKp0Sg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ZGfL1e1bMDpYfkGiAfrTfHC/8z7eJZ5Kbc5EER5I8Tw=;
 b=LNgn9kWhTFP+qaoGPYjaMJr97wkw5aM0jbMVOU7Zv52knzicKXInSAw1GEuD41okAti8/upRUcKLszQsdhK0QdJnyaldk8J2RyLbEgygJkEHUHc948p5HPE44gTp7XPKG4mvavfpk18SKQZVCkGgxiQynn4n3GQQdGMc3DnvsYg=
Date: Tue, 15 Feb 2022 10:45:34 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Qing Wang <wangqing@vivo.com>
CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>, Jens Axboe
	<axboe@kernel.dk>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd
	<sboyd@kernel.org>, Jani Nikula <jani.nikula@linux.intel.com>, Joonas
 Lahtinen <joonas.lahtinen@linux.intel.com>, Rodrigo Vivi
	<rodrigo.vivi@intel.com>, David Airlie <airlied@linux.ie>, Daniel Vetter
	<daniel@ffwll.ch>, Alex Deucher <alexander.deucher@amd.com>, Christian
 =?utf-8?B?S8O2bmln?= <christian.koenig@amd.com>, "Pan, Xinhui"
	<Xinhui.Pan@amd.com>, Srinivas Pandruvada
	<srinivas.pandruvada@linux.intel.com>, Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>, Dmitry Torokhov
	<dmitry.torokhov@gmail.com>, Alasdair Kergon <agk@redhat.com>, Mike Snitzer
	<snitzer@redhat.com>, <dm-devel@redhat.com>, Mauro Carvalho Chehab
	<mchehab@kernel.org>, Hans Verkuil <hverkuil@xs4all.nl>,
	<xen-devel@lists.xenproject.org>, <linux-block@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-clk@vger.kernel.org>,
	<intel-gfx@lists.freedesktop.org>, <dri-devel@lists.freedesktop.org>,
	<amd-gfx@lists.freedesktop.org>, <linux-input@vger.kernel.org>,
	<linux-media@vger.kernel.org>
Subject: Re: [PATCH V3 1/13] block: xen: use time_is_before_eq_jiffies()
 instead of open coding it
Message-ID: <Ygt2Pr26MHOMGgR1@Air-de-Roger>
References: <1644890154-64915-1-git-send-email-wangqing@vivo.com>
 <1644890154-64915-2-git-send-email-wangqing@vivo.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1644890154-64915-2-git-send-email-wangqing@vivo.com>
X-ClientProxiedBy: LO3P265CA0004.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:bb::9) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 32826cc3-a767-4fe8-891b-08d9f067ec86
X-MS-TrafficTypeDiagnostic: MWHPR03MB3053:EE_
X-Microsoft-Antispam-PRVS: <MWHPR03MB3053FA0087E2C31570D06F3F8F349@MWHPR03MB3053.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2276;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: XwIKyJ1rEAvRB1r6HE88BUpHD6Uz5+G+3zSYNOGigqz7NUTie21YXIqvuU92NqBmDn1nEe6TixP1P9GtV9kGSmnT8Vwgc19Z2lp3C4QZ6/CjCW59WUnCC45bousTjDOBRst8ivXWUQzhtLh35raiJeMPVuhETHIRYjwMsGFYAqcpzk4mHMkhYh4BM41r3YSHn81+32lkPMR8hfMfpv9TGrljmgUFDf9LjzTsKggo3sGJX1sw7aKO27JkXUWgVJghQ7JdIzLPYk+6xRJ1fQggmAEygybuwCCmWXUgCm17rAoi/5cP9XIT/1fxDEWXHqkJml+tMDNRXFTkgkYw+HZRfyXM5fHpZSNaaOyakz9OrexvvD9kHh7aRZefDTkBvUVEpbunNo1Vx2iJ/4jRRbcodDeOi5y44NK+xRwMAiOtVj4dRdvAH3ADF69BndhDJlfK6AUZ4708oRQIQLpFj4jdHSIWgPzy6pfn2A4ZGn/2q5lg39/1u4llA3xZrWUCszX0SaDzb5nZjppoq0bHWESPRtGwqBIpiqKf5lLczaJnAQk1VFU1D6Go3axvQa1KAIDY0Fp12NNs8kw5rkQLTF94F3BJQ2ZRH4Hy6AmY/9nOcwHQ6lx8eMfqJjl2XCUxqxowKpwaYYEp6NaUnEJSSKDJHQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(8676002)(66476007)(66556008)(4326008)(558084003)(9686003)(33716001)(6512007)(6666004)(86362001)(85182001)(66946007)(508600001)(8936002)(6506007)(5660300002)(7416002)(6486002)(7406005)(316002)(26005)(186003)(38100700002)(6916009)(82960400001)(2906002)(54906003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q09ReHgwWUdvalprSjFvZXhkNTBSNkl1azRTa2ZUZTBZVWNEdzhYNmtuSWxX?=
 =?utf-8?B?UWR5U2owVUUySG02WlNTdUpuRjVvNnVPdTZkMzF2MWw2QUZFWWZsT0NJakJ6?=
 =?utf-8?B?bkRpNURuYXlpQXZaWTRwQUVIa2pKTEtWOGMvbWNkcmZHNkdSK3ZaYm80UE1n?=
 =?utf-8?B?T0hwRlF4L1BpNlR3bmNDUmRYTkJUMzdGM3cxbmY5UmllUGE0M0tnSTVYNUNa?=
 =?utf-8?B?YTdLa2tNdXVmNG5JQlBQV1ZkUmRHaStOc0hEc3lpVENTd0dVYXFPbnlJbkN1?=
 =?utf-8?B?eWNNbVN2SWZPSkl0SGZEb2h3c1J5MEdMWnVRbDdtcVgvVENNRjdWMlhtZHpZ?=
 =?utf-8?B?V1RFQUI2RjNjc3lBR0pyVnRHZ01SRjBLU25GUjIzR2RPMWtvZk92Vi9tZTFR?=
 =?utf-8?B?UHNDYzExdjdrN3RjUG9pSUxFWHpXL1pQcVJJRVFVa0hUTXBEdGFyRTFkdmIv?=
 =?utf-8?B?bm9pMmt4bWdENEtwdWZMRUc4a21QR1hqbGpjS2JJbktYV3IvbVZod0NaRHFI?=
 =?utf-8?B?QUpjSk80WFlPbUlHUi9icURicW5uMGp6bkJRcDhPVjRQeklnUFBFU1A0TUcw?=
 =?utf-8?B?ZlBPd0U0RGhKUFBnb0g1TEVPajVQTERrb2hwUmZ0T2F1eVQ2VE1nYnZYWFph?=
 =?utf-8?B?b2RreDZHVEJrbjN6OEg5WVZKZW9LVTNMcVhqV2NTTWNVdHpqckU2WGJjYkNC?=
 =?utf-8?B?TzlXdCtGNmk2N05VakVPM1NJZ00yRG1meEVGOVZiNElERGxuUitIWTFDekJx?=
 =?utf-8?B?aDloV0RtUEVvWVVHVDg4QVF3L09mQlY1b1k2MmtjOWJwN0NRVWc2VC8zc2wr?=
 =?utf-8?B?S0xiOXlYK284WmJrRloyUXZZSHFYYkE4OE1TVmtRRHhNbHo0L2NnK1puOUVC?=
 =?utf-8?B?TmZWSm8wVVdhY0g5WjVnUnJkWFBJOGhsaHlOWG1hSm1MOUUwbE1XVEZ6bzVs?=
 =?utf-8?B?OCt0UGN6Umd0Q1lXM25RSTdoT0lkcUl4NklvVjFsbVk1TGk1dW95ZlZyQnc4?=
 =?utf-8?B?MzQycXFZbjBIbEZtcXRtV0pzSFk2NnRHOFpLa3pFTEFuYzdVWmF2VTRiYVZ6?=
 =?utf-8?B?Y1dNaXdORnBDSFlBa3FwdGZQSFFOL0Q5MGs1c0lMbTkxL0xwSEJiNngwV25q?=
 =?utf-8?B?am1ZNVQyUEZUNlYrZjA0OFRHenVZamlZVjd1TUVNVFZ5aEdEQ3M2UGZmZk9B?=
 =?utf-8?B?R1AzZUVqYVV5eW1kTDF0d1pJZmZ3a3NhcmMwREprWnVxOWpNRGwvbW5NcWVi?=
 =?utf-8?B?dWU3UlU2WkExSW5KR2tQMTkvVU42MnlmZ01XWGU3RGhIZUMycnJYNG96aURv?=
 =?utf-8?B?Vktxcmp0YzVaTUJhV0swRUFpUHdIbk9seG0zQlRvbWVKdldYK216THpTU2tz?=
 =?utf-8?B?REEwOHcrb0RHcXNMbkF4Nm9iQmNkMERjTi9kV1NidG4xSVVaL3gweVFmclNu?=
 =?utf-8?B?MXpla0hmU3lEVzNSLzcvdU1zNXV0cUplOHhQbmk0aHMzdS91aDBqaUk5R25o?=
 =?utf-8?B?RWNUVWtiTGVDOEZmempoV3NPMUVsS2JYbmVPaVdIK1JMaEtLbDFJaUt1NHN6?=
 =?utf-8?B?QTNoTUk0K3NCdlV3TkVrU2g1SzFLRnhkODMrVFJGcWYwT3ZwUUpwSlBmbTVB?=
 =?utf-8?B?TkQwd1Q3TFhtWHJqbTZkMWVDMEFzWEhUbUc5S3gwbkphT1ZCdkVRVnVrbk9C?=
 =?utf-8?B?b1crS1lmWlhaSjUxZG43N1ZHZTdPZ1l0d1RTQThvS2JtVGxmSmtRZXdRUDRB?=
 =?utf-8?B?T0xtNXFUWGtON2tlM05FZ25VcmdjblpaelozRnpydU0vU0F0R3BCSEFZdHY5?=
 =?utf-8?B?ay8wZzRrQ3NyZU1TL3FFVGwxeEphSzhicW1aTUUxbi9Ec042cERpSERsNkNn?=
 =?utf-8?B?YW8vOStLOWRuWStJSzYzVCt0dWk4cFpveDJnMmxDeDZjbytOb0NHOTlLUDZn?=
 =?utf-8?B?TkVoL2dRTzlHd3JON0cvV0kyck1GZlM4TEdpYnpOMjlNL29BQmRQdkdkU3lo?=
 =?utf-8?B?T2U4SEpGeDBxa1FGYUlBTjgvVXhQQndFOVVhckdDVzdFenRaMk9MSzRZMGtK?=
 =?utf-8?B?RW9EUlpZeWhIVzI3c0Yxb2JNZ2FOMUMzbG1Od2l2ZWJTYm9kMm1yNHBMR3h0?=
 =?utf-8?B?UGUxeW9TRGRPL2JaaC96L05qSCsrR09tZkxEWWVuUU5RRjlPTU5KNVBNWFM5?=
 =?utf-8?Q?RgJs9iDivClS1Q9nXOcWIRM=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 32826cc3-a767-4fe8-891b-08d9f067ec86
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 09:45:39.1735
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pCZULRE0ypM1MYAFyBxumnnbHYB9R4P24gzY44d0kV4TkZA/k/jKXVcffojdAGeVleKqo682MpIuIeFVQsferg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB3053
X-OriginatorOrg: citrix.com

On Mon, Feb 14, 2022 at 05:55:38PM -0800, Qing Wang wrote:
> From: Wang Qing <wangqing@vivo.com>
> 
> Use the helper function time_is_{before,after}_jiffies() to improve
> code readability.
> 
> Signed-off-by: Wang Qing <wangqing@vivo.com>

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Feb 15 10:15:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 10:15:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272902.467892 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJur8-0001gC-68; Tue, 15 Feb 2022 10:14:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272902.467892; Tue, 15 Feb 2022 10:14:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJur8-0001g5-32; Tue, 15 Feb 2022 10:14:46 +0000
Received: by outflank-mailman (input) for mailman id 272902;
 Tue, 15 Feb 2022 10:14:45 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=sIVK=S6=citrix.com=Jane.Malalane@srs-se1.protection.inumbo.net>)
 id 1nJur6-0001fz-Qg
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 10:14:45 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1603c97b-8e48-11ec-8eb8-a37418f5ba1a;
 Tue, 15 Feb 2022 11:14:41 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1603c97b-8e48-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644920081;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=BwzIscPox8/N2tAa2yzOWEg+AYTY49WwOs1HdsrcVSg=;
  b=FujwDTl/ue3wPc0U4lgykA2PbvxPm46c6F6i8HgGDOUIGIJG0AmjvKI+
   wxttRL0H3NwST2bAOXr5g3DK/fl+CXvNW/bPZn7u47LwMKmMy3FxhMH+Q
   0dmuiTBJaKNDKnlhRpujbi1gKyTB0mFcsc+MBmqIr5ObxoQcWblezpDTC
   o=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: 6OnrZt0EahQqPKzPGOlPJ9MKa5iJ6BAxoP8UE0SAx/JuqotcbS1nLoa90jNWVwmaZGPfTCy17c
 2+8FZgPtP3r7Q6MT88KA7LwDPgWuqVXFowMGwgBoO+4zNfFMwarUVTb5dA2RcZ9Z5EpkgkIQYI
 S94MIx06tRFWYWVPpKrdADfAex7Q1TLFV6RAFlJ+Swj6XEbjghAXxtotLpCCsI42JPfz4ZYDh1
 W/M9EIgpZnoX8BYRChA9T/Nb7YskVy9Xwx0j12uCzri7Fzn0/7o4k8mDdnbUojVzdoSp2eb6rQ
 dorwc+6recciuzq9ehUSFDOZ
X-SBRS: 5.1
X-MesageID: 63670515
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:PaMv9a+85AvMKaHba2HqDrUD63iTJUtcMsCJ2f8bNWPcYEJGY0x3m
 mMbDTqFOviOYGv0c4t2O96x/RtSsJbQyNYxTApu/yo8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhFWeIdA970Ug5w7Rg39Yy6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPgr+
 fAOqMC2FTsXO6/Hv+oWVDIGCHxHaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguwBJc/meqYWvnhkxDfUJf0nXYrCU+PB4towMDIY2JsQQq6DP
 pdxhTxHaQbRWkxVE30tD48ng+r1qWembRB6pwfAzUYwyzeKl1EguFT3C/LrfdiNSdRQj1yvj
 GvM9GTkATkXLNWajzGC9xqEnfTTlCn2XIYTEryQ9fNwhlCXgGsJB3U+X1ahveOwjEL4XttFM
 lEV4QInt610/0uuJvH+UgO5pjiYvxcac9tWD+A+rgqKz8L84RufQG4NTTdDadkvnM4wWTEuk
 FSOmrvBFTFp9bGYV3+Z3rOVti+pfzgYK3cYYi0JRhdD5MPsyKkxhB/SStdoEIauk8b4Xzr3x
 liisywWl7gVy8kR2M2T/03Dgj+qjojESEgy/Aq/dmCq9ARif6a+epelr1Pc6J59wJ2xFwfb+
 iJewo7Hsb5IXcrleDGxrPslRoCMpOvZNmHgv1ttFL4v/DOGpWX+RNUFiN1hH3tBPsEBcD7vR
 UbcvwJN+ZNeVEeXgb9Lj5GZUJpzk/W5fTjxfrWNN4cVPMAtHOOS1Hw2PSatM3bRfF/AeE3VE
 bOSao6SAHkTEsyLJxLmFr5GgdfHKs3TrF4/pKwXLTz6i9Jyh1bPEN/p1Wdiichjssu5TP39q
 Yo3Cidz40w3vBfCSifW65UPClsBMGI2A5v7w+QOKLLffVo2RTx5UqSLqV/ER2CCt/4L/tokA
 1nnAhMIoLYBrSGvxfq2hoBLN+q0AMcXQYMTNi0wJ1e4s0XPkq70hJrzg6AfJOF9nMQ6lKYcZ
 6BcJ62oX6QeIhyaqm91RcSs8+RfmOGD2Fvm09yNO2NkIfaNhmXhp7fZQ+cY3HBVUHTu7ZJk+
 +LIO8GyacNrejmOxf3+MZqH51iwoWIciKR1WU7JKcNUY0Li7M5hLCmZsxP9C5hkxczrymTI2
 gCILw0foOWR8YY5/MOQ3fKPrpuzEvs4FU1fRjGJ4bGzPCjc32yi3Y4fD7rYIWGDDDv5qPe4e
 OFY7/DgK/lbzlxEhJVxTuRwxqUk6tqx+7IDllZ4HG/GZkiAA697JiXUxtFGs6BAn+cLuQa/V
 k+V1MNdPLGFZJHsHFILfVJ3ZeWfz/AE3DLV6K1tckn94SZ2+puBUFlTYEbQ2HAMcuMtPdp8k
 +k7ucMQ5wiusTYQM46L3nJO6mCBDn0cSKF75JsUN5Dm11gwwVZYbJ2CViKvuMOTa89BO1UBK
 yOPgPaQnKxVw0fPfiZhFXXJ2uYB150CtAoTkQ0HLlWN3NHEmuU2zFta9jFuFlZZyRBO0uRSP
 Gl3NhIqefXSrmkw3MUTDXqxHwxhBQGC/h2jwlQEo2TVUk20WzGfN2Y6I+uMoBgU/m80kuK3J
 11EJLIJiQrXQfw=
IronPort-HdrOrdr: A9a23:C0EV9q6+K4BoiKGqigPXwWuBI+orL9Y04lQ7vn2ZFiY7TiXIra
 yTdaoguCMc0AxhJU3Jmbi7Scy9qeu1z+863WBjB8bfYOCAghroEGgC1/qs/9SEIUPDH4FmpN
 5dmsRFeb7N5B1B/LzHCWqDYpYdKbu8gdiVbI7lph8HJ2ALV0gj1XYDNu/yKDwteOAsP+tcKH
 Po3Lsgm9PWQwVxUi3UPAhmY8Hz4/nw0L72ax8PABAqrCOUiymz1bL8Gx+Emj8DTjJm294ZgC
 v4uj28wp/mn+Cwyxfa2WOWxY9RgsHdxtxKA9HJotQJKw/rlh2jaO1aKv+/VXEO0aSSAWQR4Z
 7xSiQbToJOArTqDziISC7Wqk3dOfAVmiffIBGj8CDeSIfCNU0H4oJ69Pxkm13imhcdVZhHod
 N29nPcuJxNARzamiPho9DOShFxj0Kx5WEviOgJkhVkIMEjgRBq3PkiFW5uYd899RjBmcsa+S
 hVfbXhzecTdUnfY2HSv2FpztDpVnMvHg2eSkxHvsCOyTBZkH1w0kNdnaUk7zs93YN4T4MB6/
 XPM6xumr0LRsgKbbhlDONERcesEGTCTR/FLWrXK1X6E6MMPW7LtvfMkfgIzfDvfIZNwIo5mZ
 zHXl8dvWkue1j2AcnLx5FP+gClehT1Yd0s8LAp23FUgMyOeFPbC1z1dLl1qbrRnxw2OLyoZ8
 qO
X-IronPort-AV: E=Sophos;i="5.88,370,1635220800"; 
   d="scan'208";a="63670515"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=FhiH94mjWObNpJesh8H3wDSPNNSZ+OppS1QO/X8ToIgTJFaHnSnzDJ0veIJI6G2SSZCRx9n6v6RNJPXVu0hU+nmi/kUfpk9R1pj99hC1bVztl6+aDrdfHTP45Zb5++gk/jslqWuwQcr1B3aJjewt+OvQDlmah2x/7U79TOGAPjPWrhAnnkfD1a7fRvzLibisi67lRJa2PHxtAY927uePHRl+dz8B0Aag8tSDhx66Rg2aoBTr9PITnko/6RajYqN2wE8TNmE/k2KC4ULA4oJ7kNZyQbSDfkowo7VUiRUv+aPj6ypuQ5X7/MmpfxUwI2b7cCkjCHd0t27zUIuU8PZUdQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=BwzIscPox8/N2tAa2yzOWEg+AYTY49WwOs1HdsrcVSg=;
 b=Yn+RF8kN6/DtAzpi7nr740CJrEAudnZ5CMuAfv6tK40YPCH/8ZvVsmEIwRbLcs8h3o0WbAwW4UPXO9gCixYoHuMmUtG4SnwUwVinadqUaxmrPSdbV6TIvSfulgdpYIEfH94TdNprt+9mIKC5Xcz/0vBkhrlvyosAn6nmZX0fgd7tzP+5KmqOSPnmxOZEetmIqhco6dVZys2ZssIxAwo8NsKPv0otdloG1p1cT+PH+oqBwzhi+y/mu708jBXfpqJXLg/JqByt+8O+2zdzJstguOfLU78Hospoc/P8sWpG9u1t4G0/9eJuLlArjUkpi/G3KXt2m6WHYaUTkk27lxgfuA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=BwzIscPox8/N2tAa2yzOWEg+AYTY49WwOs1HdsrcVSg=;
 b=d/hFPH5yvDQ5U6iIc/IMesLwtxoQp7Ydk4fjoreF/cz+oIN4oppUPjvd/qTEoht8aKN8cKXGFDH6xTWNQhduAtK2iFXqsQ9Kauz60gKSEo+PHnlJV0M6R0GPaq4J5bdzuwnC9+qJ4699T2Yu2KCpKomBRFE5Nd2mt+FyTp7ukNE=
From: Jane Malalane <Jane.Malalane@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>, "Anthony
 Perard" <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, "George
 Dunlap" <George.Dunlap@citrix.com>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>,
	Jun Nakajima <jun.nakajima@intel.com>, Kevin Tian <kevin.tian@intel.com>,
	Roger Pau Monne <roger.pau@citrix.com>, Andrew Cooper
	<Andrew.Cooper3@citrix.com>
Subject: Re: [PATCH v2 1/2] xen+tools: Report Interrupt Controller
 Virtualization capabilities on x86
Thread-Topic: [PATCH v2 1/2] xen+tools: Report Interrupt Controller
 Virtualization capabilities on x86
Thread-Index: AQHYHE+TdJl64aH33EedeR0PZ4zblKyMkj6AgAGTLwCAABdDgIAABJKAgATOw4CAAAIAAIAAQJgAgADqygCAADOdAA==
Date: Tue, 15 Feb 2022 10:14:32 +0000
Message-ID: <9721222d-1c0d-ddaf-fbc6-801f5d9445f5@citrix.com>
References: <20220207182101.31941-1-jane.malalane@citrix.com>
 <20220207182101.31941-2-jane.malalane@citrix.com>
 <YgTi6bzeojtcu0xL@Air-de-Roger>
 <dff9c5c0-7bee-ce0d-3288-91255a701c99@citrix.com>
 <YgZIo9VQktcqGHTD@Air-de-Roger>
 <6d924061-f2fd-5f3d-0f98-79e76398b908@suse.com>
 <6c9400b8-7c76-34c8-f69e-3fad1eb53b8c@citrix.com>
 <101b0950-b7f2-119b-b654-574a71cec3bc@suse.com>
 <1bac0507-9420-f0b9-f846-f1c73bf9678d@citrix.com>
 <42fb3257-0c36-c156-c81b-f70dd5f247aa@suse.com>
In-Reply-To: <42fb3257-0c36-c156-c81b-f70dd5f247aa@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 8f04d1dd-a0e6-47f6-bd7f-08d9f06bf5e0
x-ms-traffictypediagnostic: DM6PR03MB4809:EE_
x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
x-microsoft-antispam-prvs: <DM6PR03MB4809B3346885CE3A1D705DC481349@DM6PR03MB4809.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: vvnOaEiCm5QulmmOPGZwrEvuDi62ErHmK0gS45IA5WaWbdSuIDSQmwW2yPrWHNjR/hVGUroSrvQMMAToDosV3Htr7WFu15ss1H/N357fI4vMVtxqQAFp85izmj92kwU+jtrYtMvWn5tjoi2MphdTT04/JVjGv8jwsYVs3ADIQtVk8sfVZv4biXpP+GZYzhwJk5IwsVRt4OomJqcSrB1QInmmyrwZubv8YhWw6sUPcD8Wp73fHSPFqGhiZuSOSU1G689+7Vdh+zCQKqzJeLsVx6B20GvawrC1WzNWpJDyLw9Al0GCGdD0gAAN2qKZyor7g1pfnZlctuxyPJNeQd8GSha8mfI9V91AvwpQ0fAQbDptsbVKYYI19Jmtc2D8GIy6I+KqEwy5QyRRDaKH34AzYhmaBmnWB8d6ZdzWJEvExUg2u/G4qQzfPxgoe0NUWrn2SxT61+yeG/OoXjomupAcGzwiV2huLxYTwB5K/igMv3YIA2Qmzk7Umdnlhx/cO4bf+fkaDm+Vl8fCyU2LvongDAyodB102Hit68zh++hPJdJfCySbEhOWSryh9Bl1g5a2ApzfpbV5Lq1gALQzrwDi2xEw645o6gXSwL6KleQSdDB8QEsZ8908RJdAyQbBclDzUvTSCXE1qaXRKRrm9rPIddOkcwBklqiKuP1pzzFLA3kii7r0StvkTR2rPt/a34X7IKHn0fuOHY9jpH2J5MxV+9IUGKGrpQ0t1Pf6pBPWPs83DkZ5escdx4eCmMEaLR1B
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR03MB3386.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(54906003)(6916009)(91956017)(316002)(508600001)(86362001)(83380400001)(71200400001)(6486002)(6512007)(6506007)(31686004)(26005)(7416002)(31696002)(186003)(2906002)(36756003)(5660300002)(2616005)(107886003)(8676002)(4326008)(66476007)(66556008)(53546011)(64756008)(122000001)(66446008)(76116006)(82960400001)(66946007)(8936002)(38100700002)(38070700005)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?ZFFvekZoRkQwVTJ4RWttREhNZG5VVklNd2VPZis2VHoxYVFNN0NzNEZxVGFq?=
 =?utf-8?B?UG1DeWQ2L3BKSkNkaGppOU8xZU8zbnVmc0Z6eUczeXdvNmNDRUJ6U3ZzQmdO?=
 =?utf-8?B?SEd6VXNWR1k1bTkzZGFBbkc0QVB3eXZIU2kxaG5sRDZlYXdkK0w0ekJIZzB6?=
 =?utf-8?B?OS9sUEV3b0tIcG1xd2REVTlKa29NWmJPb1drbTYrOWQvZ2VUYmUvWkFadnFL?=
 =?utf-8?B?ZEQwdXZGVUhIMjVsanNwU0xROGVSemhlaFlSay9wQkhRS09BK3JrK0FnNnV3?=
 =?utf-8?B?K3ZhMFQ5NUpPNjA1OHMyUFlacnBodzR4QnVLZXRhSTdWbHowOWVQVks1ZlE0?=
 =?utf-8?B?bjFwaWhaanNjOFZnNE92T3M4Z0Q2aEFYeWlTVy9RRk1NMXRsOGd5dHR1dy92?=
 =?utf-8?B?ZE5YbDVLVDJsZUd2NlhIOFRHTTV3TGN6NnpHN1hUR3JXK3FpNDQzS3N4MmZP?=
 =?utf-8?B?aWtpdWxiTG9ieWkyc01xYzdsSHJudTQxYXJBR1VJNFVJcmFTcWFiS1JNREoz?=
 =?utf-8?B?YUtuaTJYTVp1N3RoanVhRjk3NUIvQytmQ0VFblJpT1hyUmhuVmtKTmlUc25G?=
 =?utf-8?B?UlFDdG1PTVU3YjNWWUdsUFZBcTRSR2hRaXE4dVdxUVAvMzFJc1ZkWmlJQWZk?=
 =?utf-8?B?N01wei9MOGJLaU0ydEFPbGxpOUd5M2NaeEdRTGR3Z0dkVUthcHh0OU90b1Bq?=
 =?utf-8?B?dDhrYnk4dEhLbEFUK0QvOUY3VlZ1QjVPd0huZ2g3RXZqMk1lWmNZS21SRm91?=
 =?utf-8?B?Qi8wa0w5TEtwcVUzTXU4NWNYdmJTK25PaTJna2NuYjJmUmRFT2NHd05yZ2tQ?=
 =?utf-8?B?SFBhQkRWZXV1cEh5Q2d5bTZDcjBBbVJic2pPZStZVHZic1lxZFlINjc5b09Y?=
 =?utf-8?B?NWYyZWJtZnI5REljNkZPZklLVmNyN0gvSDFsRTU0SldtVDdtb2RyTmQvQUdl?=
 =?utf-8?B?blNFdlhzM1ZYOFFyQUhrTGFBSWVIbHpMVjRoMXl2WkVMSitUVTVXTmxWT2pN?=
 =?utf-8?B?WWhXYmxlZmhrVDl5T1JlZlNhTm1WZ3lmMW9jNllESVl2MzZiNUdLeUwwMnNl?=
 =?utf-8?B?SGV1VE40MGpkeFhVeUljMVBEU1M1UlM1WVhZZ2FPaEY5aWp0Z2Vmdm92VjFj?=
 =?utf-8?B?R0Y4VGdpY21kNTdoK0I1MDlHRGI2MnEzOFF1TXNKY25Da1V4Zk9DK3BoUkJm?=
 =?utf-8?B?cHZ0ZFZxQkdIcS93L1gydkw0ZGpRTHpOTG8yZ1dzSE5tZEY1VmR5SWdXamZ3?=
 =?utf-8?B?ZFVhMVBmbFl1VHZYZ1NGZjFGVDlwQUQrRUlGejA2YzFwL0hEN1Mrak1QWFNS?=
 =?utf-8?B?T2tIMUFXZWdOTWxsLzFBejBsb0tqRGJSRnNEV21xMjdjUkpPNmdmUVV4cTJB?=
 =?utf-8?B?UmNvQzd5UXBaWDhwNWdEdG5JVFpRSGRpeTMxWU54aDZ2UllqUmNpaTBtZU05?=
 =?utf-8?B?c1lsRGR5SS9TNUpBaG4wTGd6NUM3WEM0Nk1yc1lEdWNnNllJY2xhbU04SEZq?=
 =?utf-8?B?R05hM3ZDMit4KzFQRzJvSzRrakhzeHRTZGJ2R0FVNi9GOXNpbGxDQTJIQ2NL?=
 =?utf-8?B?bHZ0d05GdzQzeDY4R3FtKzlJOFpSb3pSdjdaVEs4azYrSkoyY1c1OS9SV1Fh?=
 =?utf-8?B?OEMva21RVlZPbk9pYkhuWW5OUm9kbzl0VGlDR2NycGVqVE1LeDdGby9QbG9F?=
 =?utf-8?B?ejc3RytEQ3JnaTNhMXBOSDBRWEdtdzIwNnBNSWZwa2d4Y2FzUXRGVnVoMnhh?=
 =?utf-8?B?UjNsVUp3SUx0cUtXREQ3Unl6cGdsWm51ZGtzL3MvaVRqS0FjOUJXWCtoQS9v?=
 =?utf-8?B?OXFVSEVHanBlRzlnVXFCc3ZaR0tzbmNlY2pVRzdlR3VPb0VCeHpUQzlWaEdY?=
 =?utf-8?B?WlBvTXY3RmpucDdxL25DZG9hd1FwTnVuOEo5aFE1a1QwZkJPajFCY09haFBz?=
 =?utf-8?B?MDd4bFQxZFBXUnd1MlpUMWN2MGlyRytNb0J0Tm9mRzdMWkhWbWljM2gvYllY?=
 =?utf-8?B?NUZQeFY2OHRXUTVrMlhhUExFMndTY2Uzc2JUMGRMaVhEM1ZYVno2Szk3V013?=
 =?utf-8?B?NjlKK3VXaUNiRitXLzkyL1pwZDl6ZG9Tek1sa2Q4bjlWdExTaklhZlZ4SUQ3?=
 =?utf-8?B?bXRoYnEzWk1RbmpPdGJWeWJHRXpBdmsrNGMwK09scmpGQS84eGZYVnFYRVBi?=
 =?utf-8?B?MDQySEdyOUNpNjNOdnZMZVpIazA5c0RUTE5wWVYrUDNiTnBtT3hGQzFVdkVv?=
 =?utf-8?Q?Lpw6oSf1Imztq2ya0+YvZjdmfGt88kbuUukkT0nQWg=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <6F7D5E9541164847BFEB702A260A8FBB@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM5PR03MB3386.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8f04d1dd-a0e6-47f6-bd7f-08d9f06bf5e0
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Feb 2022 10:14:32.5386
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: hb2++IPhvOm4NwDobolj9nLdN3DfoDyOYRPUepG64Jx26w3WRrEgKppQuTkR/vH7gRARCZOAuEwgwQo5u3OC7CbnFqXW2cIyqS+vM+lP86k=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4809
X-OriginatorOrg: citrix.com

T24gMTUvMDIvMjAyMiAwNzowOSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IFtDQVVUSU9OIC0gRVhU
RVJOQUwgRU1BSUxdIERPIE5PVCByZXBseSwgY2xpY2sgbGlua3MsIG9yIG9wZW4gYXR0YWNobWVu
dHMgdW5sZXNzIHlvdSBoYXZlIHZlcmlmaWVkIHRoZSBzZW5kZXIgYW5kIGtub3cgdGhlIGNvbnRl
bnQgaXMgc2FmZS4NCj4gDQo+IE9uIDE0LjAyLjIwMjIgMTg6MDksIEphbmUgTWFsYWxhbmUgd3Jv
dGU6DQo+PiBPbiAxNC8wMi8yMDIyIDEzOjE4LCBKYW4gQmV1bGljaCB3cm90ZToNCj4+PiBbQ0FV
VElPTiAtIEVYVEVSTkFMIEVNQUlMXSBETyBOT1QgcmVwbHksIGNsaWNrIGxpbmtzLCBvciBvcGVu
IGF0dGFjaG1lbnRzIHVubGVzcyB5b3UgaGF2ZSB2ZXJpZmllZCB0aGUgc2VuZGVyIGFuZCBrbm93
IHRoZSBjb250ZW50IGlzIHNhZmUuDQo+Pj4NCj4+PiBPbiAxNC4wMi4yMDIyIDE0OjExLCBKYW5l
IE1hbGFsYW5lIHdyb3RlOg0KPj4+PiBPbiAxMS8wMi8yMDIyIDExOjQ2LCBKYW4gQmV1bGljaCB3
cm90ZToNCj4+Pj4+IFtDQVVUSU9OIC0gRVhURVJOQUwgRU1BSUxdIERPIE5PVCByZXBseSwgY2xp
Y2sgbGlua3MsIG9yIG9wZW4gYXR0YWNobWVudHMgdW5sZXNzIHlvdSBoYXZlIHZlcmlmaWVkIHRo
ZSBzZW5kZXIgYW5kIGtub3cgdGhlIGNvbnRlbnQgaXMgc2FmZS4NCj4+Pj4+DQo+Pj4+PiBPbiAx
MS4wMi4yMDIyIDEyOjI5LCBSb2dlciBQYXUgTW9ubsOpIHdyb3RlOg0KPj4+Pj4+IE9uIEZyaSwg
RmViIDExLCAyMDIyIGF0IDEwOjA2OjQ4QU0gKzAwMDAsIEphbmUgTWFsYWxhbmUgd3JvdGU6DQo+
Pj4+Pj4+IE9uIDEwLzAyLzIwMjIgMTA6MDMsIFJvZ2VyIFBhdSBNb25uw6kgd3JvdGU6DQo+Pj4+
Pj4+PiBPbiBNb24sIEZlYiAwNywgMjAyMiBhdCAwNjoyMTowMFBNICswMDAwLCBKYW5lIE1hbGFs
YW5lIHdyb3RlOg0KPj4+Pj4+Pj4+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC94ODYvaHZtL3ZteC92
bWNzLmMgYi94ZW4vYXJjaC94ODYvaHZtL3ZteC92bWNzLmMNCj4+Pj4+Pj4+PiBpbmRleCA3YWIx
NWUwN2EwLi40MDYwYWVmMWJkIDEwMDY0NA0KPj4+Pj4+Pj4+IC0tLSBhL3hlbi9hcmNoL3g4Ni9o
dm0vdm14L3ZtY3MuYw0KPj4+Pj4+Pj4+ICsrKyBiL3hlbi9hcmNoL3g4Ni9odm0vdm14L3ZtY3Mu
Yw0KPj4+Pj4+Pj4+IEBAIC0zNDMsNiArMzQzLDE1IEBAIHN0YXRpYyBpbnQgdm14X2luaXRfdm1j
c19jb25maWcoYm9vbCBic3ApDQo+Pj4+Pj4+Pj4gICAgICAgICAgICAgICAgICBNU1JfSUEzMl9W
TVhfUFJPQ0JBU0VEX0NUTFMyLCAmbWlzbWF0Y2gpOw0KPj4+Pj4+Pj4+ICAgICAgICAgIH0NCj4+
Pj4+Pj4+PiAgICAgIA0KPj4+Pj4+Pj4+ICsgICAgLyogQ2hlY2sgd2hldGhlciBoYXJkd2FyZSBz
dXBwb3J0cyBhY2NlbGVyYXRlZCB4YXBpYyBhbmQgeDJhcGljLiAqLw0KPj4+Pj4+Pj4+ICsgICAg
aWYgKCBic3AgKQ0KPj4+Pj4+Pj4+ICsgICAgew0KPj4+Pj4+Pj4+ICsgICAgICAgIGFzc2lzdGVk
X3hhcGljX2F2YWlsYWJsZSA9IGNwdV9oYXNfdm14X3ZpcnR1YWxpemVfYXBpY19hY2Nlc3NlczsN
Cj4+Pj4+Pj4+PiArICAgICAgICBhc3Npc3RlZF94MmFwaWNfYXZhaWxhYmxlID0gKGNwdV9oYXNf
dm14X2FwaWNfcmVnX3ZpcnQgfHwNCj4+Pj4+Pj4+PiArICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgIGNwdV9oYXNfdm14X3ZpcnR1YWxfaW50cl9kZWxpdmVyeSkgJiYNCj4+Pj4+
Pj4+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY3B1X2hhc192bXhfdmly
dHVhbGl6ZV94MmFwaWNfbW9kZTsNCj4+Pj4+Pj4+DQo+Pj4+Pj4+PiBJJ3ZlIGJlZW4gdGhpbmsg
YWJvdXQgdGhpcywgYW5kIGl0IHNlZW1zIGtpbmQgb2YgYXN5bW1ldHJpYyB0aGF0IGZvcg0KPj4+
Pj4+Pj4geEFQSUMgbW9kZSB3ZSByZXBvcnQgaHcgYXNzaXN0ZWQgc3VwcG9ydCBvbmx5IHdpdGgN
Cj4+Pj4+Pj4+IHZpcnR1YWxpemVfYXBpY19hY2Nlc3NlcyBhdmFpbGFibGUsIHdoaWxlIGZvciB4
MkFQSUMgd2UgcmVxdWlyZQ0KPj4+Pj4+Pj4gdmlydHVhbGl6ZV94MmFwaWNfbW9kZSBwbHVzIGVp
dGhlciBhcGljX3JlZ192aXJ0IG9yDQo+Pj4+Pj4+PiB2aXJ0dWFsX2ludHJfZGVsaXZlcnkuDQo+
Pj4+Pj4+Pg0KPj4+Pj4+Pj4gSSB0aGluayB3ZSBsaWtlbHkgbmVlZCB0byBiZSBtb3JlIGNvbnNp
c3RlbnQgaGVyZSwgYW5kIHJlcG9ydCBodw0KPj4+Pj4+Pj4gYXNzaXN0ZWQgeDJBUElDIHN1cHBv
cnQgYXMgbG9uZyBhcyB2aXJ0dWFsaXplX3gyYXBpY19tb2RlIGlzDQo+Pj4+Pj4+PiBhdmFpbGFi
bGUuDQo+Pj4+Pj4+Pg0KPj4+Pj4+Pj4gVGhpcyB3aWxsIGxpa2VseSBoYXZlIHNvbWUgZWZmZWN0
IG9uIHBhdGNoIDIgYWxzbywgYXMgeW91IHdpbGwgaGF2ZSB0bw0KPj4+Pj4+Pj4gYWRqdXN0IHZt
eF92bGFwaWNfbXNyX2NoYW5nZWQuDQo+Pj4+Pj4+Pg0KPj4+Pj4+Pj4gVGhhbmtzLCBSb2dlci4N
Cj4+Pj4+Pj4NCj4+Pj4+Pj4gQW55IG90aGVyIHRob3VnaHRzIG9uIHRoaXM/IEFzIG9uIG9uZSBo
YW5kIGl0IGlzIGFzeW1tZXRyaWMgYnV0IGFsc28NCj4+Pj4+Pj4gdGhlcmUgaXNuJ3QgbXVjaCBh
c3Npc3RhbmNlIHdpdGggb25seSB2aXJ0dWFsaXplX3gyYXBpY19tb2RlIHNldCBhcywgaW4NCj4+
Pj4+Pj4gdGhpcyBjYXNlLCBhIFZNIGV4aXQgd2lsbCBiZSBhdm9pZGVkIG9ubHkgd2hlbiB0cnlp
bmcgdG8gYWNjZXNzIHRoZSBUUFINCj4+Pj4+Pj4gcmVnaXN0ZXIuDQo+Pj4+Pj4NCj4+Pj4+PiBJ
J3ZlIGJlZW4gdGhpbmtpbmcgYWJvdXQgdGhpcywgYW5kIHJlcG9ydGluZyBoYXJkd2FyZSBhc3Np
c3RlZA0KPj4+Pj4+IHh7Mn1BUElDIHZpcnR1YWxpemF0aW9uIHdpdGgganVzdA0KPj4+Pj4+IFNF
Q09OREFSWV9FWEVDX1ZJUlRVQUxJWkVfQVBJQ19BQ0NFU1NFUyBvcg0KPj4+Pj4+IFNFQ09OREFS
WV9FWEVDX1ZJUlRVQUxJWkVfWDJBUElDX01PREUgZG9lc24ndCBzZWVtIHZlcnkgaGVscGZ1bC4g
V2hpbGUNCj4+Pj4+PiB0aG9zZSBwcm92aWRlIHNvbWUgYXNzaXN0YW5jZSB0byB0aGUgVk1NIGlu
IG9yZGVyIHRvIGhhbmRsZSBBUElDDQo+Pj4+Pj4gYWNjZXNzZXMsIGl0IHdpbGwgc3RpbGwgcmVx
dWlyZSBhIHRyYXAgaW50byB0aGUgaHlwZXJ2aXNvciB0byBoYW5kbGUNCj4+Pj4+PiBtb3N0IG9m
IHRoZSBhY2Nlc3Nlcy4NCj4+Pj4+Pg0KPj4+Pj4+IFNvIG1heWJlIHdlIHNob3VsZCBvbmx5IHJl
cG9ydCBoYXJkd2FyZSBhc3Npc3RlZCBzdXBwb3J0IHdoZW4gdGhlDQo+Pj4+Pj4gbWVudGlvbmVk
IGZlYXR1cmVzIGFyZSBwcmVzZW50IHRvZ2V0aGVyIHdpdGgNCj4+Pj4+PiBTRUNPTkRBUllfRVhF
Q19BUElDX1JFR0lTVEVSX1ZJUlQ/DQo+Pj4+Pg0KPj4+Pj4gTm90IHN1cmUgLSAic29tZSBhc3Np
c3RhbmNlIiBzZWVtcyBzdGlsbCBhIGxpdHRsZSBiZXR0ZXIgdGhhbiBub25lIGF0IGFsbC4NCj4+
Pj4+IFdoaWNoIHJvdXRlIHRvIGdvIGRlcGVuZHMgb24gd2hhdCBleGFjdGx5IHdlIGludGVuZCB0
aGUgYml0IHRvIGJlIHVzZWQgZm9yLg0KPj4+Pj4NCj4+Pj4gVHJ1ZS4gSSBpbnRlbmRlZCB0aGlz
IGJpdCB0byBiZSBzcGVjaWZpY2FsbHkgZm9yIGVuYWJsaW5nDQo+Pj4+IGFzc2lzdGVkX3h7Mn1h
cGljLiBTbywgd291bGQgaXQgYmUgaW5jb25zaXN0ZW50IHRvIHJlcG9ydCBoYXJkd2FyZQ0KPj4+
PiBhc3Npc3RhbmNlIHdpdGgganVzdCBWSVJUVUFMSVpFX0FQSUNfQUNDRVNTRVMgb3IgVklSVFVB
TElaRV9YMkFQSUNfTU9ERQ0KPj4+PiBidXQgc3RpbGwgY2xhaW0gdGhhdCB4ezJ9YXBpYyBpcyB2
aXJ0dWFsaXplZCBpZiBubyBNU1IgYWNjZXNzZXMgYXJlDQo+Pj4+IGludGVyY2VwdGVkIHdpdGgg
WEVOX0hWTV9DUFVJRF9YMkFQSUNfVklSVCAoaW4gdHJhcHMuYykgc28gdGhhdCwgYXMgeW91DQo+
Pj4+IHNheSwgdGhlIGd1ZXN0IGdldHMgYXQgbGVhc3QgInNvbWUgYXNzaXN0YW5jZSIgaW5zdGVh
ZCBvZiBub25lIGJ1dCB3ZQ0KPj4+PiBzdGlsbCBjbGFpbSB4ezJ9YXBpYyB2aXJ0dWFsaXphdGlv
biB3aGVuIGl0IGlzIGFjdHVhbGx5IGNvbXBsZXRlPyBNYXliZQ0KPj4+PiBJIGNvdWxkIGFsc28g
YWRkIGEgY29tbWVudCBhbGx1ZGluZyB0byB0aGlzIGluIHRoZSB4bCBkb2N1bWVudGF0aW9uLg0K
Pj4+DQo+Pj4gVG8gcmVwaHJhc2UgbXkgZWFybGllciBwb2ludDogV2hpY2gga2luZCBvZiBkZWNp
c2lvbnMgYXJlIHRoZSBjb25zdW1lcihzKQ0KPj4+IG9mIHVzIHJlcG9ydGluZyBoYXJkd2FyZSBh
c3Npc3RhbmNlIGdvaW5nIHRvIHRha2U/IEluIGhvdyBmYXIgaXMgdGhlcmUgYQ0KPj4+IHJpc2sg
dGhhdCAic29tZSBhc3Npc3RhbmNlIiBpcyBvdmVyYWxsIGdvaW5nIHRvIGxlYWQgdG8gYSBsb3Nz
IG9mDQo+Pj4gcGVyZm9ybWFuY2U/IEkgZ3Vlc3MgSSdkIG5lZWQgdG8gc2VlIGNvbW1lbnQgYW5k
IGFjdHVhbCBjb2RlIGFsbCBpbiBvbmUNCj4+PiBwbGFjZSAuLi4NCj4+Pg0KPj4gU28sIEkgd2Fz
IHRoaW5raW5nIG9mIGFkZGluZyBzb21ldGhpbmcgYWxvbmcgdGhlIGxpbmVzIG9mOg0KPj4NCj4+
ICs9aXRlbSBCPGFzc2lzdGVkX3hhcGljPUJPT0xFQU4+IEI8KHg4NiBvbmx5KT4NCj4+ICtFbmFi
bGVzIG9yIGRpc2FibGVzIGhhcmR3YXJlIGFzc2lzdGVkIHZpcnR1YWxpemF0aW9uIGZvciB4QVBJ
Qy4gVGhpcw0KPj4gK2FsbG93cyBhY2Nlc3NpbmcgQVBJQyByZWdpc3RlcnMgd2l0aG91dCBhIFZN
LWV4aXQuIE5vdGljZSBlbmFibGluZw0KPj4gK3RoaXMgZG9lcyBub3QgZ3VhcmFudGVlIGZ1bGwg
dmlydHVhbGl6YXRpb24gZm9yIHhBUElDLCBhcyB0aGlzIGNhbg0KPj4gK29ubHkgYmUgYWNoaWV2
ZWQgaWYgaGFyZHdhcmUgc3VwcG9ydHMg4oCcQVBJQy1yZWdpc3RlciB2aXJ0dWFsaXphdGlvbuKA
nQ0KPj4gK2FuZCDigJx2aXJ0dWFsLWludGVycnVwdCBkZWxpdmVyeeKAnS4gVGhlIGRlZmF1bHQg
aXMgc2V0dGFibGUgdmlhDQo+PiArTDx4bC5jb25mKDUpPi4NCj4gDQo+IEJ1dCBpc24ndCB0aGlz
IGNvbnRyYWRpY3Rvcnk/IERvZXNuJ3QgbGFjayBvZiBBUElDLXJlZ2lzdGVyIHZpcnR1YWxpemF0
aW9uDQo+IG1lYW4gVk0gZXhpdHMgdXBvbiAobW9zdCkgYWNjZXNzZXM/DQoNClllcywgaXQgZG9l
cyBtZWFuLiBJIGd1ZXNzIHRoZSBhbHRlcm5hdGl2ZSB3b3V1bGQgYmUgdGhlbiB0byByZXF1aXJl
IA0KQVBJQy1yZWdpc3RlciB2aXJ0dWFsaXphdGlvbiBmb3IgZW5hYmxpbmcgeEFQSUMuIEJ1dCBh
bHNvLCBhbHRob3VnaCB0aGlzIA0KZG9lc24ndCBwcm92aWRlIG11Y2ggYWNjZWxlcmF0aW9uLCBl
dmVuIGdldHRpbmcgYSBWTSBleGl0IGlzIHNvbWUgDQphc3Npc3RhbmNlIGlmIGNvbXBhcmVkIHRv
IGluc3RlYWQgZ2V0dGluZyBhbiBFUFQgZmF1bHQgYW5kIGhhdmluZyB0byANCmRlY29kZSB0aGUg
YWNjZXNzLg0KDQpUaGFua3MsDQoNCkphbmUu


From xen-devel-bounces@lists.xenproject.org Tue Feb 15 10:15:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 10:15:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272904.467903 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJurV-00027R-IJ; Tue, 15 Feb 2022 10:15:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272904.467903; Tue, 15 Feb 2022 10:15:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJurV-00027K-F9; Tue, 15 Feb 2022 10:15:09 +0000
Received: by outflank-mailman (input) for mailman id 272904;
 Tue, 15 Feb 2022 10:15:07 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJurT-00025Y-HH; Tue, 15 Feb 2022 10:15:07 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJurT-0006VO-Ez; Tue, 15 Feb 2022 10:15:07 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJurT-0006la-3b; Tue, 15 Feb 2022 10:15:07 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nJurT-0006ba-3B; Tue, 15 Feb 2022 10:15:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=xeKMV1vCVCCmM84bzkMS6dW9oZWc2+QVAsgQLCt5tRk=; b=XtWE+HYEWaDm0RFijCcVRFCvgh
	oLwnMGCCXCnTB9osffOYDt79b6o0dFPRUMQ+BJ4EvZhgCaWU+rOEApUui55S1N8tMt17O/8sni3jc
	Wky6pIUPPcS6Iu4qDyn/byue9Vk5xZBC+GB2tT91f1Zh808+0QNvnSCuNRrUxUE48wRA=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168115-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 168115: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=1193aa2dfbbd11fa7191d000a0cc166d03a249d2
X-Osstest-Versions-That:
    ovmf=c9b7c6e0cc7da76b74bcdd8c90cef956d5ae971c
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 15 Feb 2022 10:15:07 +0000

flight 168115 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168115/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 1193aa2dfbbd11fa7191d000a0cc166d03a249d2
baseline version:
 ovmf                 c9b7c6e0cc7da76b74bcdd8c90cef956d5ae971c

Last test of basis   168074  2022-02-10 02:10:25 Z    5 days
Testing same since   168115  2022-02-15 02:41:41 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Bob Feng <bob.c.feng@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   c9b7c6e0cc..1193aa2dfb  1193aa2dfbbd11fa7191d000a0cc166d03a249d2 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Tue Feb 15 10:16:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 10:16:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272920.467913 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJusP-0002sS-Ub; Tue, 15 Feb 2022 10:16:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272920.467913; Tue, 15 Feb 2022 10:16:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJusP-0002sL-RP; Tue, 15 Feb 2022 10:16:05 +0000
Received: by outflank-mailman (input) for mailman id 272920;
 Tue, 15 Feb 2022 10:16:04 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=h622=S6=arm.com=luca.fancellu@srs-se1.protection.inumbo.net>)
 id 1nJusO-0002aj-JD
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 10:16:04 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 47b5351e-8e48-11ec-b215-9bbe72dcb22c;
 Tue, 15 Feb 2022 11:16:03 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id ED08E13D5;
 Tue, 15 Feb 2022 02:16:02 -0800 (PST)
Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com
 [10.1.195.16])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2D2E83F66F;
 Tue, 15 Feb 2022 02:16:02 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 47b5351e-8e48-11ec-b215-9bbe72dcb22c
From: Luca Fancellu <luca.fancellu@arm.com>
To: xen-devel@lists.xenproject.org
Cc: wei.chen@arm.com,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH 1/5] tools/cpupools: Give a name to unnamed cpupools
Date: Tue, 15 Feb 2022 10:15:47 +0000
Message-Id: <20220215101551.23101-2-luca.fancellu@arm.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20220215101551.23101-1-luca.fancellu@arm.com>
References: <20220215101551.23101-1-luca.fancellu@arm.com>

With the introduction of boot time cpupools, Xen can create many
different cpupools at boot time other than cpupool with id 0.

Since these newly created cpupools can't have an
entry in Xenstore, create the entry using xen-init-dom0
helper with the usual convention: Pool-<cpupool id>.

Given the change, remove the check for poolid == 0 from
libxl_cpupoolid_to_name(...).

Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
---
 tools/helpers/xen-init-dom0.c  | 26 +++++++++++++++++++++++++-
 tools/libs/light/libxl_utils.c |  3 +--
 2 files changed, 26 insertions(+), 3 deletions(-)

diff --git a/tools/helpers/xen-init-dom0.c b/tools/helpers/xen-init-dom0.c
index c99224a4b607..3539f56faeb0 100644
--- a/tools/helpers/xen-init-dom0.c
+++ b/tools/helpers/xen-init-dom0.c
@@ -43,7 +43,10 @@ int main(int argc, char **argv)
     int rc;
     struct xs_handle *xsh = NULL;
     xc_interface *xch = NULL;
-    char *domname_string = NULL, *domid_string = NULL;
+    char *domname_string = NULL, *domid_string = NULL, *pool_string = NULL;
+    char pool_path[strlen("/local/pool") + 12], pool_name[strlen("Pool-") + 5];
+    xc_cpupoolinfo_t *xcinfo;
+    unsigned int pool_id = 0;
     libxl_uuid uuid;
 
     /* Accept 0 or 1 argument */
@@ -114,6 +117,27 @@ int main(int argc, char **argv)
         goto out;
     }
 
+    /* Create an entry in xenstore for each cpupool on the system */
+    do {
+        xcinfo = xc_cpupool_getinfo(xch, pool_id);
+        if (xcinfo != NULL) {
+            if (xcinfo->cpupool_id != pool_id)
+                pool_id = xcinfo->cpupool_id;
+            snprintf(pool_path, sizeof(pool_path), "/local/pool/%d/name",
+                     pool_id);
+            snprintf(pool_name, sizeof(pool_name), "Pool-%d", pool_id);
+            pool_id++;
+            if (!xs_write(xsh, XBT_NULL, pool_path, pool_name,
+                          strlen(pool_name))) {
+                fprintf(stderr, "cannot set pool name\n");
+                rc = 1;
+            }
+            xc_cpupool_infofree(xch, xcinfo);
+            if (rc)
+                goto out;
+        }
+    } while(xcinfo != NULL);
+
     printf("Done setting up Dom0\n");
 
 out:
diff --git a/tools/libs/light/libxl_utils.c b/tools/libs/light/libxl_utils.c
index b91c2cafa223..81780da3ff40 100644
--- a/tools/libs/light/libxl_utils.c
+++ b/tools/libs/light/libxl_utils.c
@@ -151,8 +151,7 @@ char *libxl_cpupoolid_to_name(libxl_ctx *ctx, uint32_t poolid)
 
     snprintf(path, sizeof(path), "/local/pool/%d/name", poolid);
     s = xs_read(ctx->xsh, XBT_NULL, path, &len);
-    if (!s && (poolid == 0))
-        return strdup("Pool-0");
+
     return s;
 }
 
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Tue Feb 15 10:16:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 10:16:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272921.467924 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJusR-00038S-5b; Tue, 15 Feb 2022 10:16:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272921.467924; Tue, 15 Feb 2022 10:16:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJusR-00038H-2M; Tue, 15 Feb 2022 10:16:07 +0000
Received: by outflank-mailman (input) for mailman id 272921;
 Tue, 15 Feb 2022 10:16:05 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=h622=S6=arm.com=luca.fancellu@srs-se1.protection.inumbo.net>)
 id 1nJusP-0002aj-JW
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 10:16:05 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 47180bb0-8e48-11ec-b215-9bbe72dcb22c;
 Tue, 15 Feb 2022 11:16:03 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F10141063;
 Tue, 15 Feb 2022 02:16:01 -0800 (PST)
Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com
 [10.1.195.16])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2FF323F66F;
 Tue, 15 Feb 2022 02:16:00 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 47180bb0-8e48-11ec-b215-9bbe72dcb22c
From: Luca Fancellu <luca.fancellu@arm.com>
To: xen-devel@lists.xenproject.org
Cc: wei.chen@arm.com,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>,
	Dario Faggioli <dfaggioli@suse.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>
Subject: [PATCH 0/5] Boot time cpupools
Date: Tue, 15 Feb 2022 10:15:46 +0000
Message-Id: <20220215101551.23101-1-luca.fancellu@arm.com>
X-Mailer: git-send-email 2.17.1

This serie introduces a feature for Xen to create cpu pools at boot time, the
feature is enabled using a configurable that is disabled by default.
The boot time cpupool feature relies on the device tree to describe the cpu
pools.
Another feature is introduced by the serie, the possibility to assign a
dom0less guest to a cpupool at boot time.

Here follows an example, Xen is built with CONFIG_BOOT_TIME_CPUPOOLS=y.

>From the DT:

  [...]

  a72_0: cpu@0 {
    compatible = "arm,cortex-a72";
    reg = <0x0 0x0>;
    device_type = "cpu";
    [...]
  };

  a72_1: cpu@1 {
    compatible = "arm,cortex-a72";
    reg = <0x0 0x1>;
    device_type = "cpu";
    [...]
  };

  a53_0: cpu@100 {
    compatible = "arm,cortex-a53";
    reg = <0x0 0x100>;
    device_type = "cpu";
    [...]
  };

  a53_1: cpu@101 {
    compatible = "arm,cortex-a53";
    reg = <0x0 0x101>;
    device_type = "cpu";
    [...]
  };

  a53_2: cpu@102 {
    compatible = "arm,cortex-a53";
    reg = <0x0 0x102>;
    device_type = "cpu";
    [...]
  };

  a53_3: cpu@103 {
    compatible = "arm,cortex-a53";
    reg = <0x0 0x103>;
    device_type = "cpu";
    [...]
  };

  chosen {
    #size-cells = <0x1>;
    #address-cells = <0x1>;
    xen,dom0-bootargs = "...";
    xen,xen-bootargs = "...";

    cpupool0 {
      compatible = "xen,cpupool";
      cpupool-id = <0>;
      cpupool-cpus = <&a72_0 &a72_1>;
    };

    cp1: cpupool1 {
      compatible = "xen,cpupool";
      cpupool-id = <1>;
      cpupool-cpus = <&a53_0 &a53_1 &a53_2 &a53_3>;
      cpupool-sched = "null";
    };

    module@0 {
      reg = <0x80080000 0x1300000>;
      compatible = "multiboot,module";
    };

    domU1 {
      #size-cells = <0x1>;
      #address-cells = <0x1>;
      compatible = "xen,domain";
      cpus = <1>;
      memory = <0 0xC0000>;
      vpl011;
      domain-cpupool = <&cp1>;

      module@92000000 {
        compatible = "multiboot,kernel", "multiboot,module";
        reg = <0x92000000 0x1ffffff>;
        bootargs = "...";
      };
    };
  };

  [...]

The example DT is instructing Xen to have two cpu pools, the one with id 0
having two phisical cpus and the one with id 1 having 4 phisical cpu, the
second cpu pool uses the null scheduler and from the /chosen node we can see
that a dom0less guest will be started on that cpu pool.

In this particular case Xen must boot with different type of cpus, so the
boot argument hmp_unsafe must be enabled.

Luca Fancellu (5):
  tools/cpupools: Give a name to unnamed cpupools
  xen/sched: create public function for cpupools creation
  xen/sched: retrieve scheduler id by name
  xen/cpupool: Create different cpupools at boot time
  arm/dom0less: assign dom0less guests to cpupools

 docs/misc/arm/device-tree/booting.txt  |   5 ++
 docs/misc/arm/device-tree/cpupools.txt | 118 +++++++++++++++++++++++++
 tools/helpers/xen-init-dom0.c          |  26 +++++-
 tools/libs/light/libxl_utils.c         |   3 +-
 xen/arch/arm/Kconfig                   |   9 ++
 xen/arch/arm/Makefile                  |   1 +
 xen/arch/arm/cpupool.c                 | 118 +++++++++++++++++++++++++
 xen/arch/arm/domain.c                  |   6 ++
 xen/arch/arm/domain_build.c            |   9 +-
 xen/arch/x86/domain.c                  |   6 ++
 xen/common/domain.c                    |   5 +-
 xen/common/sched/core.c                |  11 +++
 xen/common/sched/cpupool.c             |  30 ++++++-
 xen/include/public/arch-arm.h          |   2 +
 xen/include/public/domctl.h            |   2 +-
 xen/include/xen/domain.h               |   3 +
 xen/include/xen/sched.h                |  39 ++++++++
 17 files changed, 386 insertions(+), 7 deletions(-)
 create mode 100644 docs/misc/arm/device-tree/cpupools.txt
 create mode 100644 xen/arch/arm/cpupool.c

-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Tue Feb 15 10:16:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 10:16:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272922.467936 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJusS-0003Qs-GX; Tue, 15 Feb 2022 10:16:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272922.467936; Tue, 15 Feb 2022 10:16:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJusS-0003Qj-Br; Tue, 15 Feb 2022 10:16:08 +0000
Received: by outflank-mailman (input) for mailman id 272922;
 Tue, 15 Feb 2022 10:16:06 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=h622=S6=arm.com=luca.fancellu@srs-se1.protection.inumbo.net>)
 id 1nJusQ-0002aj-Jf
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 10:16:06 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 4894bf6c-8e48-11ec-b215-9bbe72dcb22c;
 Tue, 15 Feb 2022 11:16:05 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 772011424;
 Tue, 15 Feb 2022 02:16:04 -0800 (PST)
Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com
 [10.1.195.16])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2B9473F66F;
 Tue, 15 Feb 2022 02:16:03 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4894bf6c-8e48-11ec-b215-9bbe72dcb22c
From: Luca Fancellu <luca.fancellu@arm.com>
To: xen-devel@lists.xenproject.org
Cc: wei.chen@arm.com,
	Juergen Gross <jgross@suse.com>,
	Dario Faggioli <dfaggioli@suse.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>
Subject: [PATCH 2/5] xen/sched: create public function for cpupools creation
Date: Tue, 15 Feb 2022 10:15:48 +0000
Message-Id: <20220215101551.23101-3-luca.fancellu@arm.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20220215101551.23101-1-luca.fancellu@arm.com>
References: <20220215101551.23101-1-luca.fancellu@arm.com>

Create new public function to create cpupools, it checks for pool id
uniqueness before creating the pool and can take a scheduler id or
a negative value that means the default Xen scheduler will be used.

Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
---
 xen/common/sched/cpupool.c | 26 ++++++++++++++++++++++++++
 xen/include/xen/sched.h    | 17 +++++++++++++++++
 2 files changed, 43 insertions(+)

diff --git a/xen/common/sched/cpupool.c b/xen/common/sched/cpupool.c
index 8c6e6eb9ccd5..4da12528d6b9 100644
--- a/xen/common/sched/cpupool.c
+++ b/xen/common/sched/cpupool.c
@@ -1218,6 +1218,32 @@ static void cpupool_hypfs_init(void)
 
 #endif /* CONFIG_HYPFS */
 
+struct cpupool *__init cpupool_create_pool(unsigned int pool_id, int sched_id)
+{
+    struct cpupool *pool;
+
+    ASSERT(!spin_is_locked(&cpupool_lock));
+
+    spin_lock(&cpupool_lock);
+    /* Check if a cpupool with pool_id exists */
+    pool = __cpupool_find_by_id(pool_id, true);
+    spin_unlock(&cpupool_lock);
+
+    /* Pool exists, return an error */
+    if ( pool )
+        return NULL;
+
+    if ( sched_id < 0 )
+        sched_id = scheduler_get_default()->sched_id;
+
+    pool = cpupool_create(pool_id, sched_id);
+
+    BUG_ON(IS_ERR(pool));
+    cpupool_put(pool);
+
+    return pool;
+}
+
 static int __init cpupool_init(void)
 {
     unsigned int cpu;
diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
index 37f78cc4c4c9..a50df1bccdc0 100644
--- a/xen/include/xen/sched.h
+++ b/xen/include/xen/sched.h
@@ -1145,6 +1145,23 @@ int cpupool_move_domain(struct domain *d, struct cpupool *c);
 int cpupool_do_sysctl(struct xen_sysctl_cpupool_op *op);
 unsigned int cpupool_get_id(const struct domain *d);
 const cpumask_t *cpupool_valid_cpus(const struct cpupool *pool);
+
+/*
+ * cpupool_create_pool - Creates a cpupool
+ * @pool_id: id of the pool to be created
+ * @sched_id: id of the scheduler to be used for the pool
+ *
+ * Creates a cpupool with pool_id id, the id must be unique and the function
+ * will return an error if the pool id exists.
+ * The sched_id parameter identifies the scheduler to be used, if it is
+ * negative, the default scheduler of Xen will be used.
+ *
+ * returns:
+ *     pointer to the struct cpupool just created, on success
+ *     NULL, on cpupool creation error
+ */
+struct cpupool *cpupool_create_pool(unsigned int pool_id, int sched_id);
+
 extern void dump_runq(unsigned char key);
 
 void arch_do_physinfo(struct xen_sysctl_physinfo *pi);
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Tue Feb 15 10:16:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 10:16:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272924.467947 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJusT-0003if-RO; Tue, 15 Feb 2022 10:16:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272924.467947; Tue, 15 Feb 2022 10:16:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJusT-0003iR-Nc; Tue, 15 Feb 2022 10:16:09 +0000
Received: by outflank-mailman (input) for mailman id 272924;
 Tue, 15 Feb 2022 10:16:07 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=h622=S6=arm.com=luca.fancellu@srs-se1.protection.inumbo.net>)
 id 1nJusR-0002aj-Js
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 10:16:07 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 49757801-8e48-11ec-b215-9bbe72dcb22c;
 Tue, 15 Feb 2022 11:16:06 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0D7F11063;
 Tue, 15 Feb 2022 02:16:06 -0800 (PST)
Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com
 [10.1.195.16])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id ACF783F66F;
 Tue, 15 Feb 2022 02:16:04 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 49757801-8e48-11ec-b215-9bbe72dcb22c
From: Luca Fancellu <luca.fancellu@arm.com>
To: xen-devel@lists.xenproject.org
Cc: wei.chen@arm.com,
	George Dunlap <george.dunlap@citrix.com>,
	Dario Faggioli <dfaggioli@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>
Subject: [PATCH 3/5] xen/sched: retrieve scheduler id by name
Date: Tue, 15 Feb 2022 10:15:49 +0000
Message-Id: <20220215101551.23101-4-luca.fancellu@arm.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20220215101551.23101-1-luca.fancellu@arm.com>
References: <20220215101551.23101-1-luca.fancellu@arm.com>

Add a public function to retrieve the scheduler id by the scheduler
name.

Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
---
 xen/common/sched/core.c | 11 +++++++++++
 xen/include/xen/sched.h | 11 +++++++++++
 2 files changed, 22 insertions(+)

diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c
index 8f4b1ca10d1c..9696d3c1d769 100644
--- a/xen/common/sched/core.c
+++ b/xen/common/sched/core.c
@@ -2947,6 +2947,17 @@ void scheduler_enable(void)
     scheduler_active = true;
 }
 
+int __init sched_get_id_by_name(const char *sched_name)
+{
+    unsigned int i;
+
+    for ( i = 0; i < NUM_SCHEDULERS; i++ )
+        if ( schedulers[i] && !strcmp(schedulers[i]->opt_name, sched_name) )
+            return schedulers[i]->sched_id;
+
+    return -1;
+}
+
 /* Initialise the data structures. */
 void __init scheduler_init(void)
 {
diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
index a50df1bccdc0..a67a9eb2fe9d 100644
--- a/xen/include/xen/sched.h
+++ b/xen/include/xen/sched.h
@@ -756,6 +756,17 @@ void sched_destroy_domain(struct domain *d);
 long sched_adjust(struct domain *, struct xen_domctl_scheduler_op *);
 long sched_adjust_global(struct xen_sysctl_scheduler_op *);
 int  sched_id(void);
+
+/*
+ * sched_get_id_by_name - retrieves a scheduler id given a scheduler name
+ * @sched_name: scheduler name as a string
+ *
+ * returns:
+ *     positive value being the scheduler id, on success
+ *     negative value if the scheduler name is not found.
+ */
+int sched_get_id_by_name(const char *sched_name);
+
 void vcpu_wake(struct vcpu *v);
 long vcpu_yield(void);
 void vcpu_sleep_nosync(struct vcpu *v);
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Tue Feb 15 10:16:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 10:16:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272925.467958 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJusV-000404-5Q; Tue, 15 Feb 2022 10:16:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272925.467958; Tue, 15 Feb 2022 10:16:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJusV-0003zm-0H; Tue, 15 Feb 2022 10:16:11 +0000
Received: by outflank-mailman (input) for mailman id 272925;
 Tue, 15 Feb 2022 10:16:10 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=h622=S6=arm.com=luca.fancellu@srs-se1.protection.inumbo.net>)
 id 1nJusU-0003iX-4j
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 10:16:10 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id 4ab89378-8e48-11ec-8eb8-a37418f5ba1a;
 Tue, 15 Feb 2022 11:16:08 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 13B5B13D5;
 Tue, 15 Feb 2022 02:16:08 -0800 (PST)
Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com
 [10.1.195.16])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4872E3F66F;
 Tue, 15 Feb 2022 02:16:06 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4ab89378-8e48-11ec-8eb8-a37418f5ba1a
From: Luca Fancellu <luca.fancellu@arm.com>
To: xen-devel@lists.xenproject.org
Cc: wei.chen@arm.com,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Wei Liu <wl@xen.org>,
	Juergen Gross <jgross@suse.com>,
	Dario Faggioli <dfaggioli@suse.com>
Subject: [PATCH 4/5] xen/cpupool: Create different cpupools at boot time
Date: Tue, 15 Feb 2022 10:15:50 +0000
Message-Id: <20220215101551.23101-5-luca.fancellu@arm.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20220215101551.23101-1-luca.fancellu@arm.com>
References: <20220215101551.23101-1-luca.fancellu@arm.com>

Introduce an architecture specific way to create different cpupools
at boot time, this is particularly useful on ARM big.LITTLE system
where there might be the need to have different cpupools for each type
of core, but also systems using NUMA can have different cpu pools for
each node.

The feature on arm relies on a specification of the cpupools from the
device tree to build pools and assign cpus to them.

Documentation is created to explain the feature.

Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
---
 docs/misc/arm/device-tree/cpupools.txt | 118 +++++++++++++++++++++++++
 xen/arch/arm/Kconfig                   |   9 ++
 xen/arch/arm/Makefile                  |   1 +
 xen/arch/arm/cpupool.c                 | 118 +++++++++++++++++++++++++
 xen/common/sched/cpupool.c             |   4 +-
 xen/include/xen/sched.h                |  11 +++
 6 files changed, 260 insertions(+), 1 deletion(-)
 create mode 100644 docs/misc/arm/device-tree/cpupools.txt
 create mode 100644 xen/arch/arm/cpupool.c

diff --git a/docs/misc/arm/device-tree/cpupools.txt b/docs/misc/arm/device-tree/cpupools.txt
new file mode 100644
index 000000000000..7298b6394332
--- /dev/null
+++ b/docs/misc/arm/device-tree/cpupools.txt
@@ -0,0 +1,118 @@
+Boot time cpupools
+==================
+
+On arm, when BOOT_TIME_CPUPOOLS is enabled in the Xen configuration, it is
+possible to create cpupools during boot phase by specifying them in the device
+tree.
+
+Cpupools specification nodes shall be direct childs of /chosen node.
+Each cpupool node contains the following properties:
+
+- compatible (mandatory)
+
+    Must always include the compatiblity string: "xen,cpupool".
+
+- cpupool-id (mandatory)
+
+    Must be a positive integer number.
+
+- cpupool-cpus (mandatory)
+
+    Must be a list of device tree phandle to nodes describing cpus (e.g. having
+    device_type = "cpu"), it can't be empty.
+
+- cpupool-sched (optional)
+
+    Must be a string having the name of a Xen scheduler, it has no effect when
+    used in conjunction of a cpupool-id equal to zero, in that case the
+    default Xen scheduler is selected (sched=<...> boot argument).
+
+
+Constraints
+===========
+
+The cpupool with id zero is implicitly created even if not specified, that pool
+must have at least one cpu assigned, otherwise Xen will stop.
+
+Every cpu brought up by Xen will be assigned to the cpupool with id zero if it's
+not assigned to any other cpupool.
+
+If a cpu is assigned to a cpupool, but it's not brought up correctly, Xen will
+stop.
+
+
+Examples
+========
+
+A system having two types of core, the following device tree specification will
+instruct Xen to have two cpupools:
+
+- The cpupool with id 0 will have 4 cpus assigned.
+- The cpupool with id 1 will have 2 cpus assigned.
+
+As can be seen from the example, cpupool_a has only two cpus assigned, but since
+there are two cpus unassigned, they are automatically assigned to cpupool with
+id zero. The following example can work only if hmp-unsafe=1 is passed to Xen
+boot arguments, otherwise not all cores will be brought up by Xen and the
+cpupool creation process will stop Xen.
+
+
+a72_1: cpu@0 {
+        compatible = "arm,cortex-a72";
+        reg = <0x0 0x0>;
+        device_type = "cpu";
+        [...]
+};
+
+a72_2: cpu@1 {
+        compatible = "arm,cortex-a72";
+        reg = <0x0 0x1>;
+        device_type = "cpu";
+        [...]
+};
+
+a53_1: cpu@100 {
+        compatible = "arm,cortex-a53";
+        reg = <0x0 0x100>;
+        device_type = "cpu";
+        [...]
+};
+
+a53_2: cpu@101 {
+        compatible = "arm,cortex-a53";
+        reg = <0x0 0x101>;
+        device_type = "cpu";
+        [...]
+};
+
+cpu@102 {
+        compatible = "arm,cortex-a53";
+        reg = <0x0 0x102>;
+        device_type = "cpu";
+        [...]
+};
+
+cpu@103 {
+        compatible = "arm,cortex-a53";
+        reg = <0x0 0x103>;
+        device_type = "cpu";
+        [...]
+};
+
+chosen {
+
+    cpupool_a {
+        compatible = "xen,cpupool";
+        cpupool-id = <0>;
+        cpupool-cpus = <&a53_1 &a53_2>;
+    };
+    cpupool_b {
+        compatible = "xen,cpupool";
+        cpupool-id = <1>;
+        cpupool-cpus = <&a72_1 &a72_2>;
+        cpupool-sched = "credit2";
+    };
+
+    [...]
+
+};
diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
index ecfa6822e4d3..64c2879513b7 100644
--- a/xen/arch/arm/Kconfig
+++ b/xen/arch/arm/Kconfig
@@ -33,6 +33,15 @@ config ACPI
 	  Advanced Configuration and Power Interface (ACPI) support for Xen is
 	  an alternative to device tree on ARM64.
 
+config BOOT_TIME_CPUPOOLS
+	bool "Create cpupools at boot time"
+	depends on ARM
+	default n
+	help
+
+	  Creates cpupools during boot time and assigns cpus to them. Cpupools
+	  options can be specified in the device tree.
+
 config GICV3
 	bool "GICv3 driver"
 	depends on ARM_64 && !NEW_VGIC
diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile
index d0dee10102b6..6165da4e77b4 100644
--- a/xen/arch/arm/Makefile
+++ b/xen/arch/arm/Makefile
@@ -13,6 +13,7 @@ obj-$(CONFIG_HAS_ALTERNATIVE) += alternative.o
 obj-y += bootfdt.init.o
 obj-y += cpuerrata.o
 obj-y += cpufeature.o
+obj-$(CONFIG_BOOT_TIME_CPUPOOLS) += cpupool.o
 obj-y += decode.o
 obj-y += device.o
 obj-$(CONFIG_IOREQ_SERVER) += dm.o
diff --git a/xen/arch/arm/cpupool.c b/xen/arch/arm/cpupool.c
new file mode 100644
index 000000000000..a9d5b94635b9
--- /dev/null
+++ b/xen/arch/arm/cpupool.c
@@ -0,0 +1,118 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * xen/arch/arm/cpupool.c
+ *
+ * Code to create cpupools at boot time for arm architecture.
+ *
+ * Copyright (C) 2022 Arm Ltd.
+ */
+
+#include <xen/sched.h>
+
+static struct cpupool *__initdata pool_cpu_map[NR_CPUS];
+
+void __init arch_allocate_cpupools(const cpumask_t *cpu_online_map)
+{
+    const struct dt_device_node *chosen, *node;
+    unsigned int cpu_num, cpupool0_cpu_count = 0;
+    cpumask_t cpus_to_assign;
+
+    chosen = dt_find_node_by_path("/chosen");
+    if ( !chosen )
+        return;
+
+    cpumask_copy(&cpus_to_assign, cpu_online_map);
+
+    dt_for_each_child_node(chosen, node)
+    {
+        const struct dt_device_node *cpu_node;
+        unsigned int pool_id;
+        int i = 0, sched_id = -1;
+        const char* scheduler_name;
+        struct cpupool *pool = cpupool0;
+
+        if ( !dt_device_is_compatible(node, "xen,cpupool") )
+            continue;
+
+        if ( !dt_property_read_u32(node, "cpupool-id", &pool_id) )
+            panic("Missing cpupool-id property!\n");
+
+        if ( !dt_property_read_string(node, "cpupool-sched", &scheduler_name) )
+        {
+            sched_id = sched_get_id_by_name(scheduler_name);
+            if ( sched_id < 0 )
+                panic("Scheduler %s does not exists!\n", scheduler_name);
+        }
+
+        if ( pool_id )
+        {
+            pool = cpupool_create_pool(pool_id, sched_id);
+            if ( !pool )
+                panic("Error creating pool id %u!\n", pool_id);
+        }
+
+        cpu_node = dt_parse_phandle(node, "cpupool-cpus", 0);
+        if ( !cpu_node )
+            panic("Missing or empty cpupool-cpus property!\n");
+
+        while ( cpu_node )
+        {
+            register_t cpu_reg;
+            const __be32 *prop;
+
+            prop = dt_get_property(cpu_node, "reg", NULL);
+            if ( !prop )
+                panic("cpupool-cpus pointed node has no reg property!\n");
+
+            cpu_reg = dt_read_number(prop, dt_n_addr_cells(cpu_node));
+
+            /* Check if the cpu is online and in the set to be assigned */
+            for_each_cpu ( cpu_num, &cpus_to_assign )
+                if ( cpu_logical_map(cpu_num) == cpu_reg )
+                    break;
+
+            if ( cpu_num >= nr_cpu_ids )
+                panic("Cpu found in %s is not online or it's assigned twice!\n",
+                      dt_node_name(node));
+
+            pool_cpu_map[cpu_num] = pool;
+            cpumask_clear_cpu(cpu_num, &cpus_to_assign);
+
+            printk(XENLOG_INFO "CPU with MPIDR %"PRIregister" in Pool-%u.\n",
+                   cpu_reg, pool_id);
+
+            /* Keep track of how many cpus are assigned to Pool-0 */
+            if ( !pool_id )
+                cpupool0_cpu_count++;
+
+            cpu_node = dt_parse_phandle(node, "cpupool-cpus", ++i);
+        }
+    }
+
+    /* Assign every non assigned cpu to Pool-0 */
+    for_each_cpu ( cpu_num, &cpus_to_assign )
+    {
+        pool_cpu_map[cpu_num] = cpupool0;
+        cpupool0_cpu_count++;
+        printk(XENLOG_INFO "CPU with MPIDR %"PRIregister" in Pool-0.\n",
+               cpu_logical_map(cpu_num));
+    }
+
+    if ( !cpupool0_cpu_count )
+        panic("No cpu assigned to cpupool0!\n");
+}
+
+struct cpupool *__init arch_get_cpupool(unsigned int cpu)
+{
+    return pool_cpu_map[cpu];
+}
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * tab-width: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
diff --git a/xen/common/sched/cpupool.c b/xen/common/sched/cpupool.c
index 4da12528d6b9..6013d75e2edd 100644
--- a/xen/common/sched/cpupool.c
+++ b/xen/common/sched/cpupool.c
@@ -1257,12 +1257,14 @@ static int __init cpupool_init(void)
     cpupool_put(cpupool0);
     register_cpu_notifier(&cpu_nfb);
 
+    arch_allocate_cpupools(&cpu_online_map);
+
     spin_lock(&cpupool_lock);
 
     cpumask_copy(&cpupool_free_cpus, &cpu_online_map);
 
     for_each_cpu ( cpu, &cpupool_free_cpus )
-        cpupool_assign_cpu_locked(cpupool0, cpu);
+        cpupool_assign_cpu_locked(arch_get_cpupool(cpu), cpu);
 
     spin_unlock(&cpupool_lock);
 
diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
index a67a9eb2fe9d..dda7db2ba51f 100644
--- a/xen/include/xen/sched.h
+++ b/xen/include/xen/sched.h
@@ -1177,6 +1177,17 @@ extern void dump_runq(unsigned char key);
 
 void arch_do_physinfo(struct xen_sysctl_physinfo *pi);
 
+#ifdef CONFIG_BOOT_TIME_CPUPOOLS
+void arch_allocate_cpupools(const cpumask_t *cpu_online_map);
+struct cpupool *arch_get_cpupool(unsigned int cpu);
+#else
+static inline void arch_allocate_cpupools(const cpumask_t *cpu_online_map) {}
+static inline struct cpupool *arch_get_cpupool(unsigned int cpu)
+{
+    return cpupool0;
+}
+#endif
+
 #endif /* __SCHED_H__ */
 
 /*
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Tue Feb 15 10:16:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 10:16:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272926.467967 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJusW-0004Jk-JK; Tue, 15 Feb 2022 10:16:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272926.467967; Tue, 15 Feb 2022 10:16:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJusW-0004Ie-EY; Tue, 15 Feb 2022 10:16:12 +0000
Received: by outflank-mailman (input) for mailman id 272926;
 Tue, 15 Feb 2022 10:16:11 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=h622=S6=arm.com=luca.fancellu@srs-se1.protection.inumbo.net>)
 id 1nJusV-0003iX-BH
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 10:16:11 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id 4bb02719-8e48-11ec-8eb8-a37418f5ba1a;
 Tue, 15 Feb 2022 11:16:10 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AEDBD1063;
 Tue, 15 Feb 2022 02:16:09 -0800 (PST)
Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com
 [10.1.195.16])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 44AAE3F66F;
 Tue, 15 Feb 2022 02:16:08 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4bb02719-8e48-11ec-8eb8-a37418f5ba1a
From: Luca Fancellu <luca.fancellu@arm.com>
To: xen-devel@lists.xenproject.org
Cc: wei.chen@arm.com,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Wei Liu <wl@xen.org>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>
Subject: [PATCH 5/5] arm/dom0less: assign dom0less guests to cpupools
Date: Tue, 15 Feb 2022 10:15:51 +0000
Message-Id: <20220215101551.23101-6-luca.fancellu@arm.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20220215101551.23101-1-luca.fancellu@arm.com>
References: <20220215101551.23101-1-luca.fancellu@arm.com>

Introduce domain-cpupool property of a xen,domain device tree node,
that specifies the cpupool device tree handle of a xen,cpupool node
that identifies a cpupool created at boot time where the guest will
be assigned on creation.

Add member to the xen_arch_domainconfig public interface so the
XEN_DOMCTL_INTERFACE_VERSION version is bumped.

Update documentation about the property.

Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
---
 docs/misc/arm/device-tree/booting.txt | 5 +++++
 xen/arch/arm/domain.c                 | 6 ++++++
 xen/arch/arm/domain_build.c           | 9 ++++++++-
 xen/arch/x86/domain.c                 | 6 ++++++
 xen/common/domain.c                   | 5 ++++-
 xen/include/public/arch-arm.h         | 2 ++
 xen/include/public/domctl.h           | 2 +-
 xen/include/xen/domain.h              | 3 +++
 8 files changed, 35 insertions(+), 3 deletions(-)

diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt
index 71895663a4de..0f1f210fa449 100644
--- a/docs/misc/arm/device-tree/booting.txt
+++ b/docs/misc/arm/device-tree/booting.txt
@@ -182,6 +182,11 @@ with the following properties:
     Both #address-cells and #size-cells need to be specified because
     both sub-nodes (described shortly) have reg properties.
 
+- domain-cpupool
+
+    Optional. Handle to a xen,cpupool device tree node that identifies the
+    cpupool where the guest will be started at boot.
+
 Under the "xen,domain" compatible node, one or more sub-nodes are present
 for the DomU kernel and ramdisk.
 
diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
index 92a6c509e5c5..be350b28b588 100644
--- a/xen/arch/arm/domain.c
+++ b/xen/arch/arm/domain.c
@@ -788,6 +788,12 @@ fail:
     return rc;
 }
 
+unsigned int
+arch_get_domain_cpupool_id(const struct xen_domctl_createdomain *config)
+{
+    return config->arch.cpupool_id;
+}
+
 void arch_domain_destroy(struct domain *d)
 {
     /* IOMMU page table is shared with P2M, always call
diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index 6931c022a2e8..4f239e756775 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -3015,7 +3015,8 @@ static int __init construct_domU(struct domain *d,
 void __init create_domUs(void)
 {
     struct dt_device_node *node;
-    const struct dt_device_node *chosen = dt_find_node_by_path("/chosen");
+    const struct dt_device_node *cpupool_node,
+                                *chosen = dt_find_node_by_path("/chosen");
 
     BUG_ON(chosen == NULL);
     dt_for_each_child_node(chosen, node)
@@ -3053,6 +3054,12 @@ void __init create_domUs(void)
                                          GUEST_VPL011_SPI - 32 + 1);
         }
 
+        /* Get the optional property domain-cpupool */
+        cpupool_node = dt_parse_phandle(node, "domain-cpupool", 0);
+        if ( cpupool_node )
+            dt_property_read_u32(cpupool_node, "cpupool-id",
+                                 &d_cfg.arch.cpupool_id);
+
         /*
          * The variable max_init_domid is initialized with zero, so here it's
          * very important to use the pre-increment operator to call
diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c
index ef1812dc1402..3e3cf88c9c82 100644
--- a/xen/arch/x86/domain.c
+++ b/xen/arch/x86/domain.c
@@ -880,6 +880,12 @@ int arch_domain_create(struct domain *d,
     return rc;
 }
 
+unsigned int
+arch_get_domain_cpupool_id(const struct xen_domctl_createdomain *config)
+{
+    return 0;
+}
+
 void arch_domain_destroy(struct domain *d)
 {
     if ( is_hvm_domain(d) )
diff --git a/xen/common/domain.c b/xen/common/domain.c
index 2048ebad86ff..d42ca8292025 100644
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -665,6 +665,8 @@ struct domain *domain_create(domid_t domid,
 
     if ( !is_idle_domain(d) )
     {
+        unsigned int domain_cpupool_id;
+
         watchdog_domain_init(d);
         init_status |= INIT_watchdog;
 
@@ -698,7 +700,8 @@ struct domain *domain_create(domid_t domid,
         if ( !d->pbuf )
             goto fail;
 
-        if ( (err = sched_init_domain(d, 0)) != 0 )
+        domain_cpupool_id = arch_get_domain_cpupool_id(config);
+        if ( (err = sched_init_domain(d, domain_cpupool_id)) != 0 )
             goto fail;
 
         if ( (err = late_hwdom_init(d)) != 0 )
diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
index 94b31511ddea..2c5d1ea7f01a 100644
--- a/xen/include/public/arch-arm.h
+++ b/xen/include/public/arch-arm.h
@@ -321,6 +321,8 @@ struct xen_arch_domainconfig {
     uint16_t tee_type;
     /* IN */
     uint32_t nr_spis;
+    /* IN */
+    unsigned int cpupool_id;
     /*
      * OUT
      * Based on the property clock-frequency in the DT timer node.
diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
index b85e6170b0aa..31ec083cb06e 100644
--- a/xen/include/public/domctl.h
+++ b/xen/include/public/domctl.h
@@ -38,7 +38,7 @@
 #include "hvm/save.h"
 #include "memory.h"
 
-#define XEN_DOMCTL_INTERFACE_VERSION 0x00000014
+#define XEN_DOMCTL_INTERFACE_VERSION 0x00000015
 
 /*
  * NB. xen_domctl.domain is an IN/OUT parameter for this operation.
diff --git a/xen/include/xen/domain.h b/xen/include/xen/domain.h
index 160c8dbdab33..fb018871bc17 100644
--- a/xen/include/xen/domain.h
+++ b/xen/include/xen/domain.h
@@ -63,6 +63,9 @@ void unmap_vcpu_info(struct vcpu *v);
 int arch_domain_create(struct domain *d,
                        struct xen_domctl_createdomain *config);
 
+unsigned int
+arch_get_domain_cpupool_id(const struct xen_domctl_createdomain *config);
+
 void arch_domain_destroy(struct domain *d);
 
 void arch_domain_shutdown(struct domain *d);
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Tue Feb 15 10:20:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 10:20:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272963.467980 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJuwK-0007KU-4Z; Tue, 15 Feb 2022 10:20:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272963.467980; Tue, 15 Feb 2022 10:20:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJuwK-0007KN-1N; Tue, 15 Feb 2022 10:20:08 +0000
Received: by outflank-mailman (input) for mailman id 272963;
 Tue, 15 Feb 2022 10:20:07 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=p95L=S6=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nJuwI-0007G5-TA
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 10:20:07 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d808a9e0-8e48-11ec-8eb8-a37418f5ba1a;
 Tue, 15 Feb 2022 11:20:05 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2059.outbound.protection.outlook.com [104.47.14.59]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-10-iMvULkZ1OVyDQHLTxCFgfA-1; Tue, 15 Feb 2022 11:20:03 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4541.eurprd04.prod.outlook.com (2603:10a6:803:76::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Tue, 15 Feb
 2022 10:20:01 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4975.015; Tue, 15 Feb 2022
 10:20:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d808a9e0-8e48-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644920405;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=nb+0quDZ/iEf1j/BvtqT5iXTvAOuxWVhO59lxJ6gkHQ=;
	b=E5Iw46dp0gPNnQADroyPN/zKQXvONoc+iRHiat3yH2Nx75o8DeRy3RhuKoPQAhEXn6ft3F
	xmgaENs6xUP2BqUUFDsKg7CbPJTMnhQHyPd/OlYdZyv5Wukd3LTmsf2U9oWe49zyc76zua
	5bQjq/Kc2XKQQI5K8T5yS4v+s+3Tr30=
X-MC-Unique: iMvULkZ1OVyDQHLTxCFgfA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=G28vJjAsWS7JUJ3xVHwmQZ4L5is0zgZXdSP4Scm/+MKsjXYEbX7dWhaJ6CJqC7/XNosLV49FbAzRryuLajoyoUNh24JDoG4G1xoxUNNLhJaFr/3nJoOSMNJViVTr4Ml03IDiHwGA+ndPL4waWgFS9wi8TwaP0ThOwYh6rccSqKyVW6IpxyaYIBbnFC8lZch6mA/X3n/uGvWiG0PIn/4Vp3zkDLrj3Ikp0/3x8dweQDMipy//ewOFlFjyq95EnaxkbRKf3uuRoQ4w0Aw4XVcpxlm99uyoNgkZzOatrFZcsisLH/rqEYthG3EMq83slZTlpfzZOcxKTKNqBY7o1G3nBQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=oRTZ0+tteJn/CeuVX7mzrpS/X1skiRvMyLiLGsTDhNo=;
 b=jl+p9D6HLv7nzMwbCQQMMl62PUguS7s4x/xrPUgd0On8e7sxlwd3yPLkOhlvEFRes2s0fF4WSMJvMsNkPWrbQ8cjiE1IcXwkFpR9GG0WfIFGxBZUHFF/sstMxZW/Vbiru3M1iUjgfr/NggdVUpcIXrO8vnU6CkXRD69ghjhucjHo6HO+nzF9sIZB7ppJ1YeA/5FWHZ9Hl+ewJ9iDT3D3jtyvm4zMkK0Ah8xiA+NkGU3Ux313e9nVafYRvrWbiNzYL6iz1FZ1aMEBu/Mx/LP8VlCvzu5Qk1LdGyIrwtxrTx7IQRtOZVtP+56uSkYwZSCb6pUTQ0LUWm7UZ03CLf6fdg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <12727658-68f4-1785-9b37-c948eb2cba71@suse.com>
Date: Tue, 15 Feb 2022 11:19:59 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH v2 1/2] xen+tools: Report Interrupt Controller
 Virtualization capabilities on x86
Content-Language: en-US
To: Jane Malalane <Jane.Malalane@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>,
 Anthony Perard <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 George Dunlap <George.Dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Jun Nakajima <jun.nakajima@intel.com>, Kevin Tian <kevin.tian@intel.com>,
 Roger Pau Monne <roger.pau@citrix.com>,
 Andrew Cooper <Andrew.Cooper3@citrix.com>
References: <20220207182101.31941-1-jane.malalane@citrix.com>
 <20220207182101.31941-2-jane.malalane@citrix.com>
 <YgTi6bzeojtcu0xL@Air-de-Roger>
 <dff9c5c0-7bee-ce0d-3288-91255a701c99@citrix.com>
 <YgZIo9VQktcqGHTD@Air-de-Roger>
 <6d924061-f2fd-5f3d-0f98-79e76398b908@suse.com>
 <6c9400b8-7c76-34c8-f69e-3fad1eb53b8c@citrix.com>
 <101b0950-b7f2-119b-b654-574a71cec3bc@suse.com>
 <1bac0507-9420-f0b9-f846-f1c73bf9678d@citrix.com>
 <42fb3257-0c36-c156-c81b-f70dd5f247aa@suse.com>
 <9721222d-1c0d-ddaf-fbc6-801f5d9445f5@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <9721222d-1c0d-ddaf-fbc6-801f5d9445f5@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6P192CA0092.EURP192.PROD.OUTLOOK.COM
 (2603:10a6:209:8d::33) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7791c558-2397-4bf1-874b-08d9f06cba01
X-MS-TrafficTypeDiagnostic: VI1PR04MB4541:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB454181411B3F998E36A4FB47B3349@VI1PR04MB4541.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ok+gkuLAcIMc4m390c6PZpb5t3kDzl3ZX7+Cu1DbELInknXhRtXXsEv32/59ykocwysR+TvUq86SZfwbY/mqRHkYnUDi5RcMHLW23sOH0R3dmYDuBDeOHLmlxQtzTQvjTgRYPLR+dhgbxSeWSf97iRMOeEp/FJPET3MZt5v8ae6dlorlAcw7i3XqyV4Nsk17hFLgmzAfL+ll0W3p7ROMTEe7zeP2w/xSk418y8DP8GJfOkdxPb+dOoo3ibIU4PcdGTtlTtZlgsWUG2RuiAso4gortshZgp5yHqggHkgwcc4CiLGL7HAbyCNlRRme9cM1yCXXtS4towzoYmcZ6P0nc+DMMlztD/1RkK4tYY9nOSbiZNY4kU96KKZ9Peps7UTH74B3I87JHrCF0iZd92PikJsPCu2qHl0aCk97Zwj6AkqgNkOvGqL/s6Zli/UT9mgWsEGf6gLu+U1UOpWv/Yfz15W8T7XwaB0fXyZvdJIzB8PLztOWaVB4UpaDvtuWrih00KCMzB1s+FGH1PbFIEuzoEEdLgqDJ8lg+ZBkPJII0pj2npW9+7hOgjd0o0UsSHRJZc6NL2o7meIs1AFrcw52miD945prQqKBQ7jXuUfu0CMP1AN9QC1/zWwGd+jLd0/20cxgmeVYLzhfp8e9OXyUPzJw32tE9rmKBFhyngcYBbOWXaLDfcvjlGLaSRiq0vFL0hksIXt/OIW5jZyKs9MNIinMs8NK8un59igqwhOQQSv7C4t6kBQPREAdBb23wdGe
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(5660300002)(6486002)(31686004)(508600001)(36756003)(2906002)(31696002)(86362001)(7416002)(83380400001)(6916009)(53546011)(26005)(66556008)(66476007)(66946007)(38100700002)(6506007)(186003)(4326008)(6512007)(2616005)(8936002)(8676002)(54906003)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?jJrDTsD6ZDsH7q0RxMYZjMtcj+Ek/460cYOcVqckbwcCJX393h3FnpNVDKXZ?=
 =?us-ascii?Q?h+S+10u/yZ9Z1Be1Tu6HLc0G2CbEywjvnf0KiruPS3GURkGw0ZRMsbOKtnLv?=
 =?us-ascii?Q?7VjBV6lrxypVhmZvFZbBn9BCNuW1LqPSCClTJdnyMhpscKto+D5Ad4bn6/VV?=
 =?us-ascii?Q?kR5otID/1aDhWGXPVvLMdpOFcurJHyUSIrGdOeGMuYpllwHzVRAVG+RA8pVe?=
 =?us-ascii?Q?cHQY2M6h+Nx+Tl52GX8b/9EYI2VekZ5H1K8mRtYHHTn0md7//s8bjYuduM11?=
 =?us-ascii?Q?lb97MZdJdluCSHlg82kL5Rn5b6ktZBdkNU5NvNE/z6TwZ0+3u6pP3js2NlmU?=
 =?us-ascii?Q?sgTzCxlCsKTc90ICoI7wnwWNeN7DgYoTGWMdbp00peXJe08V0yt7Gmf7DduS?=
 =?us-ascii?Q?d3XdMvp5WuOII3yqneScZKoUYMlaiIj+/J0bKBj1WgQEbckNpH/MDwApfZVM?=
 =?us-ascii?Q?fi+g95xS3d4uJ61ereCw6zqrJw4QVhnAbHCCj5jPg19/V2wWY0ymCWwe6LaQ?=
 =?us-ascii?Q?AWWk0SvbC6wtTqpeXvJfQq3SQgw09Lq9JSAWif911clxQO6EAQLFMrJkmEJs?=
 =?us-ascii?Q?7mi3pY4DkwKKZTGKcJWmq0DIKq7MWnkF29ahl2JuG8Qi+w72o0JkMkth0tpk?=
 =?us-ascii?Q?yNw6XgNSv8gpgvRHvfsSQo0lDC2MeFsMp+W6hOY9WrGcIHi5InbRB1sCmqFm?=
 =?us-ascii?Q?P1XItErYK2jHJr5qE1ALxPYy4CSxD+/LyjlWFB33lj2x5ePqPh73kKuhYXJ5?=
 =?us-ascii?Q?LrTRH1IjmRhUesk+mooy3ncYDIPTiPcyiLu1yS2kjLqIJSUDHLs1xzE2q9/t?=
 =?us-ascii?Q?8aJ1FvFeZU4L88usMDK9KHGSnst1HC7gVrh7qZBNwpYFmgw0PSheCQcBCvbB?=
 =?us-ascii?Q?CYq1F/5ocKijlvllww35tdAkpE1yC8wxYU2iweoXB3nx/0VzzGF97ikf34Mf?=
 =?us-ascii?Q?fHcXkQY19eINWkjQSdVOBAoKJvLcScTAqHHzTdZ+l20DXEtRLpwP1TE+uCZJ?=
 =?us-ascii?Q?I6WZuV6AjmzW2wmZs9+qwVuTs8H6lecaWh7cSVr9Cl+jAV6p3QQI+IJ/oH7c?=
 =?us-ascii?Q?S7TuSV7QIyHDApsQwVwVZ7kuiBeQdBJBsYjBpNKMDbPbvOp/xMXp3UFidjj/?=
 =?us-ascii?Q?vUQfMBX6/xEqqyXVzUMPUPGnpi3Qrb8haS1upRRkj2eAHybOMljUQ9GWoUZ4?=
 =?us-ascii?Q?kTuSAViPepwoibjy67T519awbcHjkCtf2gU0Ygh7xSFZyZUDqpsHmKNLMMPb?=
 =?us-ascii?Q?bmuFOv+BuVJwvfX2wGP6hdu3nopDFFSgl41ThDgpkVpn0gkYFtE+r1eZaKGU?=
 =?us-ascii?Q?G1NDU2jDtQ2aWnACsp4m327ZQ0QsYyTMZtS+bfncjeKy7oZKVSIcx/yMYc7m?=
 =?us-ascii?Q?HDhlrMH9E6b4pOpywmPj7c//YmqaInc3TJQutg3QtVNck2MlnGJQpsSFJKfb?=
 =?us-ascii?Q?fd9DStZ5uhpXWxRrgx8xBqK3QD9vKC2y4zpInnrF3JWdkWto2Swh+5s0AGy8?=
 =?us-ascii?Q?yrSZlZTQFiuCk/LWFbsz+/e8ee1gTpUeAYKVBtoPYXTSN/Cu43LaDhRvaJFS?=
 =?us-ascii?Q?3lqsHUncy8ARLnKUIeojuJG221IlAG+ENeBAEUwlruK32ten3hG8kvwTM6n5?=
 =?us-ascii?Q?XlMKtsiIz2myTo7tAImUwek=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7791c558-2397-4bf1-874b-08d9f06cba01
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 10:20:01.8526
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TiaBk2dvcIdiBOFdxUNEQ2HQFcE42Vud/5NljG/5noexnlOk8gQSNSraf56w2eMzkKAtDXjf4+UB5cvP9ooRyg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4541

On 15.02.2022 11:14, Jane Malalane wrote:
> On 15/02/2022 07:09, Jan Beulich wrote:
>> [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachment=
s unless you have verified the sender and know the content is safe.
>>
>> On 14.02.2022 18:09, Jane Malalane wrote:
>>> On 14/02/2022 13:18, Jan Beulich wrote:
>>>> [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachme=
nts unless you have verified the sender and know the content is safe.
>>>>
>>>> On 14.02.2022 14:11, Jane Malalane wrote:
>>>>> On 11/02/2022 11:46, Jan Beulich wrote:
>>>>>> [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attach=
ments unless you have verified the sender and know the content is safe.
>>>>>>
>>>>>> On 11.02.2022 12:29, Roger Pau Monn=C3=A9 wrote:
>>>>>>> On Fri, Feb 11, 2022 at 10:06:48AM +0000, Jane Malalane wrote:
>>>>>>>> On 10/02/2022 10:03, Roger Pau Monn=C3=A9 wrote:
>>>>>>>>> On Mon, Feb 07, 2022 at 06:21:00PM +0000, Jane Malalane wrote:
>>>>>>>>>> diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/=
vmcs.c
>>>>>>>>>> index 7ab15e07a0..4060aef1bd 100644
>>>>>>>>>> --- a/xen/arch/x86/hvm/vmx/vmcs.c
>>>>>>>>>> +++ b/xen/arch/x86/hvm/vmx/vmcs.c
>>>>>>>>>> @@ -343,6 +343,15 @@ static int vmx_init_vmcs_config(bool bsp)
>>>>>>>>>>                  MSR_IA32_VMX_PROCBASED_CTLS2, &mismatch);
>>>>>>>>>>          }
>>>>>>>>>>     =20
>>>>>>>>>> +    /* Check whether hardware supports accelerated xapic and x2=
apic. */
>>>>>>>>>> +    if ( bsp )
>>>>>>>>>> +    {
>>>>>>>>>> +        assisted_xapic_available =3D cpu_has_vmx_virtualize_api=
c_accesses;
>>>>>>>>>> +        assisted_x2apic_available =3D (cpu_has_vmx_apic_reg_vir=
t ||
>>>>>>>>>> +                                     cpu_has_vmx_virtual_intr_d=
elivery) &&
>>>>>>>>>> +                                    cpu_has_vmx_virtualize_x2ap=
ic_mode;
>>>>>>>>>
>>>>>>>>> I've been think about this, and it seems kind of asymmetric that =
for
>>>>>>>>> xAPIC mode we report hw assisted support only with
>>>>>>>>> virtualize_apic_accesses available, while for x2APIC we require
>>>>>>>>> virtualize_x2apic_mode plus either apic_reg_virt or
>>>>>>>>> virtual_intr_delivery.
>>>>>>>>>
>>>>>>>>> I think we likely need to be more consistent here, and report hw
>>>>>>>>> assisted x2APIC support as long as virtualize_x2apic_mode is
>>>>>>>>> available.
>>>>>>>>>
>>>>>>>>> This will likely have some effect on patch 2 also, as you will ha=
ve to
>>>>>>>>> adjust vmx_vlapic_msr_changed.
>>>>>>>>>
>>>>>>>>> Thanks, Roger.
>>>>>>>>
>>>>>>>> Any other thoughts on this? As on one hand it is asymmetric but al=
so
>>>>>>>> there isn't much assistance with only virtualize_x2apic_mode set a=
s, in
>>>>>>>> this case, a VM exit will be avoided only when trying to access th=
e TPR
>>>>>>>> register.
>>>>>>>
>>>>>>> I've been thinking about this, and reporting hardware assisted
>>>>>>> x{2}APIC virtualization with just
>>>>>>> SECONDARY_EXEC_VIRTUALIZE_APIC_ACCESSES or
>>>>>>> SECONDARY_EXEC_VIRTUALIZE_X2APIC_MODE doesn't seem very helpful. Wh=
ile
>>>>>>> those provide some assistance to the VMM in order to handle APIC
>>>>>>> accesses, it will still require a trap into the hypervisor to handl=
e
>>>>>>> most of the accesses.
>>>>>>>
>>>>>>> So maybe we should only report hardware assisted support when the
>>>>>>> mentioned features are present together with
>>>>>>> SECONDARY_EXEC_APIC_REGISTER_VIRT?
>>>>>>
>>>>>> Not sure - "some assistance" seems still a little better than none a=
t all.
>>>>>> Which route to go depends on what exactly we intend the bit to be us=
ed for.
>>>>>>
>>>>> True. I intended this bit to be specifically for enabling
>>>>> assisted_x{2}apic. So, would it be inconsistent to report hardware
>>>>> assistance with just VIRTUALIZE_APIC_ACCESSES or VIRTUALIZE_X2APIC_MO=
DE
>>>>> but still claim that x{2}apic is virtualized if no MSR accesses are
>>>>> intercepted with XEN_HVM_CPUID_X2APIC_VIRT (in traps.c) so that, as y=
ou
>>>>> say, the guest gets at least "some assistance" instead of none but we
>>>>> still claim x{2}apic virtualization when it is actually complete? May=
be
>>>>> I could also add a comment alluding to this in the xl documentation.
>>>>
>>>> To rephrase my earlier point: Which kind of decisions are the consumer=
(s)
>>>> of us reporting hardware assistance going to take? In how far is there=
 a
>>>> risk that "some assistance" is overall going to lead to a loss of
>>>> performance? I guess I'd need to see comment and actual code all in on=
e
>>>> place ...
>>>>
>>> So, I was thinking of adding something along the lines of:
>>>
>>> +=3Ditem B<assisted_xapic=3DBOOLEAN> B<(x86 only)>
>>> +Enables or disables hardware assisted virtualization for xAPIC. This
>>> +allows accessing APIC registers without a VM-exit. Notice enabling
>>> +this does not guarantee full virtualization for xAPIC, as this can
>>> +only be achieved if hardware supports =E2=80=9CAPIC-register virtualiz=
ation=E2=80=9D
>>> +and =E2=80=9Cvirtual-interrupt delivery=E2=80=9D. The default is setta=
ble via
>>> +L<xl.conf(5)>.
>>
>> But isn't this contradictory? Doesn't lack of APIC-register virtualizati=
on
>> mean VM exits upon (most) accesses?
>=20
> Yes, it does mean. I guess the alternative wouuld be then to require=20
> APIC-register virtualization for enabling xAPIC. But also, although this=
=20
> doesn't provide much acceleration, even getting a VM exit is some=20
> assistance if compared to instead getting an EPT fault and having to=20
> decode the access.

I agree here, albeit I'd like to mention that EPT faults are also VM
exits. All my earlier comment was about is that this piece of doc
wants to express reality, whichever way it is that things end up
being implemented.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Feb 15 10:34:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 10:34:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272975.467990 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJv9n-0000OQ-CH; Tue, 15 Feb 2022 10:34:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272975.467990; Tue, 15 Feb 2022 10:34:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJv9n-0000OJ-9P; Tue, 15 Feb 2022 10:34:03 +0000
Received: by outflank-mailman (input) for mailman id 272975;
 Tue, 15 Feb 2022 10:34:01 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=az2O=S6=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nJv9l-0000OC-Hq
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 10:34:01 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c92574a2-8e4a-11ec-b215-9bbe72dcb22c;
 Tue, 15 Feb 2022 11:33:59 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 4CFB5210EC;
 Tue, 15 Feb 2022 10:33:59 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 12E1313C16;
 Tue, 15 Feb 2022 10:33:59 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id FDcZApeBC2JWIgAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 15 Feb 2022 10:33:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c92574a2-8e4a-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1644921239; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=pVja1UqqFM1W0cLK8QOShkZ+lCVnih9Wb4q2wyaOr+k=;
	b=F+T2mOAn+WIJEeU5BGFY3j9z6pRQ67CwxSDNd0CuwCo+vfb0DeJGJZZgLHviuO9nUkFKSQ
	AdvcJz84FDjOBtHHS8dPK0ogw2NDweQDoYz2cHVk9VLhdx6jKTJ0Lj0PGzYrRHi7yH/Q7V
	KyY1B2lcAOyaoH7sSaf95R3v6SU8AQY=
Message-ID: <efd968bb-e3f6-9e16-3826-4cab25127718@suse.com>
Date: Tue, 15 Feb 2022 11:33:58 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Content-Language: en-US
To: Luca Fancellu <luca.fancellu@arm.com>, xen-devel@lists.xenproject.org
Cc: wei.chen@arm.com, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>
References: <20220215101551.23101-1-luca.fancellu@arm.com>
 <20220215101551.23101-2-luca.fancellu@arm.com>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH 1/5] tools/cpupools: Give a name to unnamed cpupools
In-Reply-To: <20220215101551.23101-2-luca.fancellu@arm.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------sriHtO36xC09mYCYC9x41a3o"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------sriHtO36xC09mYCYC9x41a3o
Content-Type: multipart/mixed; boundary="------------60GwdNqEHkJ18tNLYn7Yegn9";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Luca Fancellu <luca.fancellu@arm.com>, xen-devel@lists.xenproject.org
Cc: wei.chen@arm.com, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>
Message-ID: <efd968bb-e3f6-9e16-3826-4cab25127718@suse.com>
Subject: Re: [PATCH 1/5] tools/cpupools: Give a name to unnamed cpupools
References: <20220215101551.23101-1-luca.fancellu@arm.com>
 <20220215101551.23101-2-luca.fancellu@arm.com>
In-Reply-To: <20220215101551.23101-2-luca.fancellu@arm.com>

--------------60GwdNqEHkJ18tNLYn7Yegn9
Content-Type: multipart/mixed; boundary="------------3l0rYN46bNsgHZAMZVLZIi2s"

--------------3l0rYN46bNsgHZAMZVLZIi2s
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMTUuMDIuMjIgMTE6MTUsIEx1Y2EgRmFuY2VsbHUgd3JvdGU6DQo+IFdpdGggdGhlIGlu
dHJvZHVjdGlvbiBvZiBib290IHRpbWUgY3B1cG9vbHMsIFhlbiBjYW4gY3JlYXRlIG1hbnkN
Cj4gZGlmZmVyZW50IGNwdXBvb2xzIGF0IGJvb3QgdGltZSBvdGhlciB0aGFuIGNwdXBvb2wg
d2l0aCBpZCAwLg0KPiANCj4gU2luY2UgdGhlc2UgbmV3bHkgY3JlYXRlZCBjcHVwb29scyBj
YW4ndCBoYXZlIGFuDQo+IGVudHJ5IGluIFhlbnN0b3JlLCBjcmVhdGUgdGhlIGVudHJ5IHVz
aW5nIHhlbi1pbml0LWRvbTANCj4gaGVscGVyIHdpdGggdGhlIHVzdWFsIGNvbnZlbnRpb246
IFBvb2wtPGNwdXBvb2wgaWQ+Lg0KPiANCj4gR2l2ZW4gdGhlIGNoYW5nZSwgcmVtb3ZlIHRo
ZSBjaGVjayBmb3IgcG9vbGlkID09IDAgZnJvbQ0KPiBsaWJ4bF9jcHVwb29saWRfdG9fbmFt
ZSguLi4pLg0KPiANCj4gU2lnbmVkLW9mZi1ieTogTHVjYSBGYW5jZWxsdSA8bHVjYS5mYW5j
ZWxsdUBhcm0uY29tPg0KPiAtLS0NCj4gICB0b29scy9oZWxwZXJzL3hlbi1pbml0LWRvbTAu
YyAgfCAyNiArKysrKysrKysrKysrKysrKysrKysrKysrLQ0KPiAgIHRvb2xzL2xpYnMvbGln
aHQvbGlieGxfdXRpbHMuYyB8ICAzICstLQ0KPiAgIDIgZmlsZXMgY2hhbmdlZCwgMjYgaW5z
ZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkNCj4gDQo+IGRpZmYgLS1naXQgYS90b29scy9o
ZWxwZXJzL3hlbi1pbml0LWRvbTAuYyBiL3Rvb2xzL2hlbHBlcnMveGVuLWluaXQtZG9tMC5j
DQo+IGluZGV4IGM5OTIyNGE0YjYwNy4uMzUzOWY1NmZhZWIwIDEwMDY0NA0KPiAtLS0gYS90
b29scy9oZWxwZXJzL3hlbi1pbml0LWRvbTAuYw0KPiArKysgYi90b29scy9oZWxwZXJzL3hl
bi1pbml0LWRvbTAuYw0KPiBAQCAtNDMsNyArNDMsMTAgQEAgaW50IG1haW4oaW50IGFyZ2Ms
IGNoYXIgKiphcmd2KQ0KPiAgICAgICBpbnQgcmM7DQo+ICAgICAgIHN0cnVjdCB4c19oYW5k
bGUgKnhzaCA9IE5VTEw7DQo+ICAgICAgIHhjX2ludGVyZmFjZSAqeGNoID0gTlVMTDsNCj4g
LSAgICBjaGFyICpkb21uYW1lX3N0cmluZyA9IE5VTEwsICpkb21pZF9zdHJpbmcgPSBOVUxM
Ow0KPiArICAgIGNoYXIgKmRvbW5hbWVfc3RyaW5nID0gTlVMTCwgKmRvbWlkX3N0cmluZyA9
IE5VTEwsICpwb29sX3N0cmluZyA9IE5VTEw7DQoNCnBvb2xfc3RyaW5nIHNlZW1zIHRvIGJl
IHVudXNlZC4NCg0KPiArICAgIGNoYXIgcG9vbF9wYXRoW3N0cmxlbigiL2xvY2FsL3Bvb2wi
KSArIDEyXSwgcG9vbF9uYW1lW3N0cmxlbigiUG9vbC0iKSArIDVdOw0KDQpJIGRvbid0IGxp
a2UgdGhhdC4gV2h5IGRvbid0IHlvdSB1c2UgcG9pbnRlcnMgYW5kIC4uLg0KDQo+ICsgICAg
eGNfY3B1cG9vbGluZm9fdCAqeGNpbmZvOw0KPiArICAgIHVuc2lnbmVkIGludCBwb29sX2lk
ID0gMDsNCj4gICAgICAgbGlieGxfdXVpZCB1dWlkOw0KPiAgIA0KPiAgICAgICAvKiBBY2Nl
cHQgMCBvciAxIGFyZ3VtZW50ICovDQo+IEBAIC0xMTQsNiArMTE3LDI3IEBAIGludCBtYWlu
KGludCBhcmdjLCBjaGFyICoqYXJndikNCj4gICAgICAgICAgIGdvdG8gb3V0Ow0KPiAgICAg
ICB9DQo+ICAgDQo+ICsgICAgLyogQ3JlYXRlIGFuIGVudHJ5IGluIHhlbnN0b3JlIGZvciBl
YWNoIGNwdXBvb2wgb24gdGhlIHN5c3RlbSAqLw0KPiArICAgIGRvIHsNCj4gKyAgICAgICAg
eGNpbmZvID0geGNfY3B1cG9vbF9nZXRpbmZvKHhjaCwgcG9vbF9pZCk7DQo+ICsgICAgICAg
IGlmICh4Y2luZm8gIT0gTlVMTCkgew0KPiArICAgICAgICAgICAgaWYgKHhjaW5mby0+Y3B1
cG9vbF9pZCAhPSBwb29sX2lkKQ0KPiArICAgICAgICAgICAgICAgIHBvb2xfaWQgPSB4Y2lu
Zm8tPmNwdXBvb2xfaWQ7DQo+ICsgICAgICAgICAgICBzbnByaW50Zihwb29sX3BhdGgsIHNp
emVvZihwb29sX3BhdGgpLCAiL2xvY2FsL3Bvb2wvJWQvbmFtZSIsDQo+ICsgICAgICAgICAg
ICAgICAgICAgICBwb29sX2lkKTsNCj4gKyAgICAgICAgICAgIHNucHJpbnRmKHBvb2xfbmFt
ZSwgc2l6ZW9mKHBvb2xfbmFtZSksICJQb29sLSVkIiwgcG9vbF9pZCk7DQoNCi4uLiB1c2Ug
YXNwcmludGYoKSBoZXJlIGZvciBhbGxvY2F0aW5nIHRoZSBzdHJpbmdzIGluIHRoZSBuZWVk
ZWQgc2l6ZT8NCg0KPiArICAgICAgICAgICAgcG9vbF9pZCsrOw0KPiArICAgICAgICAgICAg
aWYgKCF4c193cml0ZSh4c2gsIFhCVF9OVUxMLCBwb29sX3BhdGgsIHBvb2xfbmFtZSwNCj4g
KyAgICAgICAgICAgICAgICAgICAgICAgICAgc3RybGVuKHBvb2xfbmFtZSkpKSB7DQo+ICsg
ICAgICAgICAgICAgICAgZnByaW50ZihzdGRlcnIsICJjYW5ub3Qgc2V0IHBvb2wgbmFtZVxu
Iik7DQo+ICsgICAgICAgICAgICAgICAgcmMgPSAxOw0KPiArICAgICAgICAgICAgfQ0KPiAr
ICAgICAgICAgICAgeGNfY3B1cG9vbF9pbmZvZnJlZSh4Y2gsIHhjaW5mbyk7DQo+ICsgICAg
ICAgICAgICBpZiAocmMpDQo+ICsgICAgICAgICAgICAgICAgZ290byBvdXQ7DQoNCk1vdmlu
ZyB0aGUgY2FsbCBvZiB4Y19jcHVwb29sX2luZm9mcmVlKCkgYWhlYWQgb2YgdGhlIGNhbGwg
b2YgeHNfd3JpdGUoKQ0Kd291bGQgZHJvcCB0aGUgbmVlZCBmb3IgdGhpcyBsYXN0IGlmIHN0
YXRlbWVudCwgYXMgeW91IGNvdWxkIGFkZCB0aGUNCmdvdG8gdG8gdGhlIHVwcGVyIGlmLg0K
DQo+ICsgICAgICAgIH0NCj4gKyAgICB9IHdoaWxlKHhjaW5mbyAhPSBOVUxMKTsNCj4gKw0K
DQpXaXRoIGRvaW5nIGFsbCBvZiB0aGlzIGZvciBiZWluZyBhYmxlIHRvIGFzc2lnbiBvdGhl
ciBkb21haW5zIGNyZWF0ZWQNCmF0IGJvb3QgdG8gY3B1cG9vbHMsIHNob3VsZG4ndCB5b3Ug
YWRkIG5hbWVzIGZvciBvdGhlciBkb21haW5zIHRoYW4gZG9tMA0KaGVyZSwgdG9vPw0KDQoN
Ckp1ZXJnZW4NCg==
--------------3l0rYN46bNsgHZAMZVLZIi2s
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------3l0rYN46bNsgHZAMZVLZIi2s--

--------------60GwdNqEHkJ18tNLYn7Yegn9--

--------------sriHtO36xC09mYCYC9x41a3o
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmILgZYFAwAAAAAACgkQsN6d1ii/Ey9N
Gwf/Yr3vTwVYWvOeKVC6puMJU1+L6CL+1LUHewSXromDW0kj1Ep86IeEs7vlVVy4Qr3E2ZURxvNv
wFX/0Js9IMwSxoseyeGl4ehJEnq/KkGcRwXMg/M2AYQsQaVrHEeQ5t1NHPxEhHB6enSbhNzDLG7i
ddEi+4mPgJE6PY4O//fuyHcB4aF47FOBO0LyXhGcXuCNB21jI9D9aO2aiRTWXBS13uIKp0oNJFIe
echM/saePGn0ZjB4R+p9R9gg+EvN3fxUl8CJ9G68y1rijdzdQzzXpkKjpOyzQFrDxpHzwKEhUHhC
PSApeR6KayYPHHmgxdqzEl46QRmYDONfBGETXUyI0g==
=jWpi
-----END PGP SIGNATURE-----

--------------sriHtO36xC09mYCYC9x41a3o--


From xen-devel-bounces@lists.xenproject.org Tue Feb 15 10:37:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 10:37:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272983.468002 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJvDU-00016g-1b; Tue, 15 Feb 2022 10:37:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272983.468002; Tue, 15 Feb 2022 10:37:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJvDT-00016Z-Uh; Tue, 15 Feb 2022 10:37:51 +0000
Received: by outflank-mailman (input) for mailman id 272983;
 Tue, 15 Feb 2022 10:37:51 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=p95L=S6=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nJvDT-00016T-Ci
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 10:37:51 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 526a7a2f-8e4b-11ec-8eb8-a37418f5ba1a;
 Tue, 15 Feb 2022 11:37:50 +0100 (CET)
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur03lp2054.outbound.protection.outlook.com [104.47.9.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-40-JgBmfRZeM16V7e8PS496Lg-1; Tue, 15 Feb 2022 11:37:48 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by PR3PR04MB7273.eurprd04.prod.outlook.com (2603:10a6:102:89::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Tue, 15 Feb
 2022 10:37:47 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4975.015; Tue, 15 Feb 2022
 10:37:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 526a7a2f-8e4b-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644921469;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=FvPe/8TzSMezKQGJz7riI9NTcryy8w8WsG7xpVK4Q+A=;
	b=Z5dUxVsiyUtMalJziXNYyV76caoyGmx5Je8155kpzfFkB36RyyIDK8PB+6TM8kCa0PO8+2
	oLqUXeTov6X85PrNaMGNR5tk44OcHwQ+IVyTQq2lUZjravDKnOpIOi5pNt7nrEN1BLJsV6
	dJokT7lRVOWNcl5gPcPjxiHN3Mh+/IU=
X-MC-Unique: JgBmfRZeM16V7e8PS496Lg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=HTZAAIwX7fMi4n6jz5SUy31bQwawseazrN1nK6x+jE7c3+ExQe5+5In+NpEBClhgQQ66ZCDrRsptZHYrUnxRnXSue8GZlHeEMWZ0psz3HD6urwel6qVrZ6gXLiFS7pw8a1WGkg4TBa9zX6OL/lW/q4wLkFAXfVeqZtjWXIIH1m3CHNS4nCqxuA/XbfPw7Qja7K2LbJ2h2u/9OyTtqprPg6NpXak6hxoeHvGLT+agadfoEUG6lEv3WBgPdJ3eYm7Co5VM/5W3MzZVazW/NVXzNZKovugqbBgEPtBHT2LUsTZygTKrhNj7C2Bz/0AB+tNTSmArglbr9vPTNlJoaY6RDg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=cWHDm4fAwdAOKXWCUFrNOk5+vDZiGDKTmavTJpL7dbM=;
 b=kTVvYq6F3HxhVzZ/yWGhRMdCt8y2fK1mES9vFtqLHJAe/3KLTTAtsb3tLNOwkT5++ti4RTzvWqmAvLYP9aa0AgV8Zc+F6rjICaIdXXyDciHhvrxCQGDsy4ujdX7iYkJPr5PhW1R0kuidyoYVysqvneM7GrEOdttIs3LdrxLd89xvLRqPKnWnWiVfS6qM+7buM0ikkf7DXK3xJQA/My1IKafgmu8FjLDX/Ad6thqeyQuReu8/LmLvnmHkzJctG0cqVtrUX/giFJmji70kOl2LQ8qLZYGAjm6MVr0YFo5muZqzNBIIgWBPTL9AqXBKr7/4T71i/cXt0GthqXDXW7BxCw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <8106ab49-c1b2-a2d4-536b-cd0e17c05b3a@suse.com>
Date: Tue, 15 Feb 2022 11:37:45 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH] rwlock: remove unneeded subtraction
Content-Language: en-US
To: Roger Pau Monne <roger.pau@citrix.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220215093951.97830-1-roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220215093951.97830-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6P195CA0079.EURP195.PROD.OUTLOOK.COM
 (2603:10a6:209:86::20) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5bc7acf8-a447-4293-b1c0-08d9f06f3506
X-MS-TrafficTypeDiagnostic: PR3PR04MB7273:EE_
X-Microsoft-Antispam-PRVS:
	<PR3PR04MB72737FEBE9A5959AB54B0348B3349@PR3PR04MB7273.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6430;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	TQmaHc6NUaZqjBXwSV+x7p1TYFj3k9ljEdQ2Rt2sX1oTvyp6zkTCWe0AEqlg3mnG1opv+CQEgQbYSU/vcHzUCQAG/wTYh4HZL5CVDUxXT8d0x46BkvxyCokEAYIuYg75MBnJ8y8eq/2wD6IfAmFOVILjrc7O1tZJ3qMBgY2W0Xj9lNSMF7HZrOxu0rcg2wido8GE2dVg53LRXQd2e1pVYoQNw7+hcJFZEwCum78UJu8xzXd0doqvcd7d3Ai6jV/WuMjY+8aeCLuboJH+mnbHHSDvVyU6QLBOYOdgsRh7Zq+mJKFgDiXQ8s92ek6Vrkojxtoja8ZAXV0ywyR+udaEmsIR9JTn/KKQ3KkAXS1MW+R7x8gbc4zlmD6xMi/n2vYbxVg4Rj0bsAcVMThKJVHvhZC54E7FLWGmn3yn9TGLib0LRgV1GZn6Rd7T4pE79VI/TeRG9CRBFfeVWwD/3Ec9tPFns3B5bHcAU2vJryjBYjZ9E7+rDirRATAkyHscRAMTxkV2YQS47m830IWCdfYwPkeSTuUPtv+gyjsfx4dL69Po4+Sd7sGPyL7FiKBRC/2oC6UgVcoBurmH3TBP3nFpkLPecNIfvAip1mFDmdkXghwfqkiuL8FC1Ai5HnMhxqnzwW8ar8tb4sQ0Zr0A/Twn59kpuXkOfcU9Y7rKGr0HgDX05l9V8uz+SacPdHjt7GMOObgCiCUDDhwz8wZE/tUy1Pq4hbyzo43nXYUbR+DDBgs=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(186003)(36756003)(8676002)(6506007)(4326008)(38100700002)(6512007)(26005)(8936002)(4744005)(83380400001)(5660300002)(53546011)(2616005)(54906003)(2906002)(66476007)(508600001)(316002)(66946007)(6486002)(6916009)(31696002)(31686004)(86362001)(66556008)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?IGU49M+9C8/QdFHlNzdvPCnzibjPT4tkKd9917ANMa3ssjslJk+oNjCOAuzN?=
 =?us-ascii?Q?SrWSG1ZrHJUlJZUcdymlldZpRSc2rFnGrQnzkzWAIESETcC6Z1WLqLy9MbUx?=
 =?us-ascii?Q?Yejp/HX3gtePwdKn3Pur7edR0FStlgSzMsnfXmKf9X2k1Qk6oz998nqi6wnj?=
 =?us-ascii?Q?VKwIbt3J6QKN+POED1otzRqefGFo21osUXyV4MliSxmVp+OONlgSkgKeHc3l?=
 =?us-ascii?Q?ld7QrChDjxlmraSmF2IazFL95ubi+Cw3JI69JKtnFHP3zOeA41ahu/iJGbWd?=
 =?us-ascii?Q?CBh6t5CM2SebXu7uDkIAzQs8XfY+ttbP9KKLwRMrtmXj1vkFid3uPo4yZ0M5?=
 =?us-ascii?Q?ebUrPfaUeXe5lJqGa3cbnmidcTKVsGVy7ktN0B8kjMM7LXKU1DjRXNWQ3Lzz?=
 =?us-ascii?Q?rsFhAsPvHfEElz2RVCbIcnHWzOKY9DtlvznAb/KTdynsFLeh0zUz3HsuqUy5?=
 =?us-ascii?Q?zMgq38RH2X/Qt2FF6PTsGL3CfaBPvOrnN12LYLyIvOfN77ZrxbcMSHcsZwvj?=
 =?us-ascii?Q?OsqM47/IOMkGX/9p/FVEejxC/33woIiBSOrUWekZfy2Ba+cmXdK2UPwMLwBi?=
 =?us-ascii?Q?F1lpD9GbymORknTkRA9RzVQCS12R63P8caGitymWuNXR4mavD6IEAodty4Qy?=
 =?us-ascii?Q?LXYPds3F+fEU3ydpjAgB5NgCgWffTPnHHIufW5d0peby7J9w1m6MojXT2Xnc?=
 =?us-ascii?Q?A565MdOI/NWSZr06PF67ypShS3JHbjCMhUGya5UJsWfispzOUcbtIBncmfEf?=
 =?us-ascii?Q?CX10LDO13X5+ymIhrE4GFqdp7ZBHw2xZ1VxwwgLFxatZw1Jpu8tWngnZ6djs?=
 =?us-ascii?Q?fOqid2+VH08jhoM0UUkgABWtbRenzmO2PMQjdCwJsue3vKu9GtgfdHSssnEc?=
 =?us-ascii?Q?L4hgtwJbWBkZCSt9LDJPz0GhKAQsve0U6aspVNEwi1tYbweq5DFAjpGpPyMB?=
 =?us-ascii?Q?kw1xwtlOFR46cEqbpHDJ0XTnhFo3iAcD8vVokCRKjoiVQ42xftQ7ud3zUiT5?=
 =?us-ascii?Q?byqj7+vnX/YmnTsRXcZncJcK6QUNvsEz7vbA1V/5BHEwMfkRQOCFxUupBnrH?=
 =?us-ascii?Q?VLK8Zns9DC+WTOVFhfsyJaQA99lA03ybN5zSXmemD60+IDd3jNDSr3FkanLJ?=
 =?us-ascii?Q?CwUfgsjhT+7MkM+BTiNx80W/vOi9/MplnQf0xaICdS4e+xaI1P4yagDhhS2b?=
 =?us-ascii?Q?6Uij7W9EooLJonq+BHZzQpgVgmMtKDxLHNlZd1hbBUOz2T9cEdFGGJLW76JH?=
 =?us-ascii?Q?LMz9xsouxBl8A1Pm3mqnxenqQanFHOqbvV3yujIXN5tpY/Vx4c1eVz/BJbCE?=
 =?us-ascii?Q?Ly48brWzHAWygrQQKZ93HYP4roap8t3hsxnPVg+RL79MhN+nf1XadbSqvvW7?=
 =?us-ascii?Q?BWeowD1o0X6/eJ9xcpamyp0zQTbY89XrpYKMZFhW9ymYVga8vZfNIkrQ8hKc?=
 =?us-ascii?Q?8xhdPrHrxjko56ftwNokrjJ04NBBvb6ARKYyaCHWL64z9DclAmMAHRKhNgzF?=
 =?us-ascii?Q?yhPYpLm9t5pAcygG0zGjqOVGn/n3HvgNyrLiIlggohhIo9nd9qylSIKj4FAI?=
 =?us-ascii?Q?dJJHfPG/PpALugRozPI7TH8JljnoS4w/Heky1HAm54SRyr805LcgW7N42On6?=
 =?us-ascii?Q?VlmaEkbxekpTRL4e32KbXBk=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5bc7acf8-a447-4293-b1c0-08d9f06f3506
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 10:37:47.2865
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: F0WmDmxomx0FrdYfm36MWr4QTeup0yKj+O7y2HyYsvqzkXM5HCSvXncuDa95wsl2sonnno/PvAkzrIGNkvvHUQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7273

On 15.02.2022 10:39, Roger Pau Monne wrote:
> There's no need to subtract _QR_BIAS from the lock value for storing
> in the local cnts variable in the read lock slow path: the users of
> the value in cnts only care about the writer-related bits and use a
> mask to get the value.
>=20
> Note that further setting of cnts in rspin_until_writer_unlock already
> do not subtract _QR_BIAS.
>=20
> Signed-off-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Tue Feb 15 10:38:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 10:38:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272986.468013 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJvDn-0001Vz-A3; Tue, 15 Feb 2022 10:38:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272986.468013; Tue, 15 Feb 2022 10:38:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJvDn-0001Vq-71; Tue, 15 Feb 2022 10:38:11 +0000
Received: by outflank-mailman (input) for mailman id 272986;
 Tue, 15 Feb 2022 10:38:10 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=az2O=S6=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nJvDm-00016T-33
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 10:38:10 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5dd24353-8e4b-11ec-8eb8-a37418f5ba1a;
 Tue, 15 Feb 2022 11:38:09 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id CC9EC1F382;
 Tue, 15 Feb 2022 10:38:08 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8285913C16;
 Tue, 15 Feb 2022 10:38:08 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id j7NgHpCCC2JIJAAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 15 Feb 2022 10:38:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5dd24353-8e4b-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1644921488; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=UUxz44fXHY1YhJ4uMsOzrYaHA8lkCajNpMN7GQHVJLs=;
	b=bxrmgDQwRtuGk1LBEEFeZTE6b9bUSDzIRRrTCifATAOU+D+Qnus6F7+aCybDaa95pSX4A8
	JFRWfCQYCeFqn/bXQ4qJNdAYOECCm/5rScdQrU7ukRa2YYtbpYpyDLd4k7+tP7DsuSlVN5
	+j7pjV8t4TIG1/wdmTNqOzRgjaI2Yk0=
Message-ID: <50ad5e74-c8b6-bdb3-2a9b-fa118610d07d@suse.com>
Date: Tue, 15 Feb 2022 11:38:07 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Subject: Re: [PATCH 2/5] xen/sched: create public function for cpupools
 creation
Content-Language: en-US
To: Luca Fancellu <luca.fancellu@arm.com>, xen-devel@lists.xenproject.org
Cc: wei.chen@arm.com, Dario Faggioli <dfaggioli@suse.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>
References: <20220215101551.23101-1-luca.fancellu@arm.com>
 <20220215101551.23101-3-luca.fancellu@arm.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <20220215101551.23101-3-luca.fancellu@arm.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------NXIEBuOpEn5CvRJ0wGQQybuA"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------NXIEBuOpEn5CvRJ0wGQQybuA
Content-Type: multipart/mixed; boundary="------------Qmamk0acbO3E45URuxSq96DY";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Luca Fancellu <luca.fancellu@arm.com>, xen-devel@lists.xenproject.org
Cc: wei.chen@arm.com, Dario Faggioli <dfaggioli@suse.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>
Message-ID: <50ad5e74-c8b6-bdb3-2a9b-fa118610d07d@suse.com>
Subject: Re: [PATCH 2/5] xen/sched: create public function for cpupools
 creation
References: <20220215101551.23101-1-luca.fancellu@arm.com>
 <20220215101551.23101-3-luca.fancellu@arm.com>
In-Reply-To: <20220215101551.23101-3-luca.fancellu@arm.com>

--------------Qmamk0acbO3E45URuxSq96DY
Content-Type: multipart/mixed; boundary="------------boJ67b1AzTTw1KmSUsxlYva0"

--------------boJ67b1AzTTw1KmSUsxlYva0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMTUuMDIuMjIgMTE6MTUsIEx1Y2EgRmFuY2VsbHUgd3JvdGU6DQo+IENyZWF0ZSBuZXcg
cHVibGljIGZ1bmN0aW9uIHRvIGNyZWF0ZSBjcHVwb29scywgaXQgY2hlY2tzIGZvciBwb29s
IGlkDQo+IHVuaXF1ZW5lc3MgYmVmb3JlIGNyZWF0aW5nIHRoZSBwb29sIGFuZCBjYW4gdGFr
ZSBhIHNjaGVkdWxlciBpZCBvcg0KPiBhIG5lZ2F0aXZlIHZhbHVlIHRoYXQgbWVhbnMgdGhl
IGRlZmF1bHQgWGVuIHNjaGVkdWxlciB3aWxsIGJlIHVzZWQuDQo+IA0KPiBTaWduZWQtb2Zm
LWJ5OiBMdWNhIEZhbmNlbGx1IDxsdWNhLmZhbmNlbGx1QGFybS5jb20+DQoNClJldmlld2Vk
LWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+DQoNCndpdGggb25lIGZ1cnRo
ZXIgcXVlc3Rpb246IHlvdSBhcmUgYWxsb3dpbmcgdG8gdXNlIGFub3RoZXIgc2NoZWR1bGVy
LA0KYnV0IHdoYXQgaWYgc29tZW9uZSB3YW50cyB0byBzZXQgbm9uLXN0YW5kYXJkIHNjaGVk
dWxpbmcgcGFyYW1ldGVycw0KKGUuZy4gYW5vdGhlciB0aW1lIHNsaWNlKT8NCg0KDQpKdWVy
Z2VuDQo=
--------------boJ67b1AzTTw1KmSUsxlYva0
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------boJ67b1AzTTw1KmSUsxlYva0--

--------------Qmamk0acbO3E45URuxSq96DY--

--------------NXIEBuOpEn5CvRJ0wGQQybuA
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmILgo8FAwAAAAAACgkQsN6d1ii/Ey8n
NAf+O9N6NhA2uAL5zjjMQF6gnYDWOyXZeMAhy7EyXSKxCCBlNrCw4Ke14eU4q4b5kfx6ACzkAzo4
0YZrs0Ml4jzr8jRE5LDScImgIPqDgILiL/kAus03G0SpC00IJEmtloA9kVpTz9XOXoqPK6gwdxRS
hn/TDvURsw1dEtVkkrsAoQnWC9+4XfeiGChar/WBED7qpvSzbKhEHSNKpJ2E7hc5kNpUaBru1RjG
bPanDad1tS6nzVy4F92Jy/jH2MylZVluwCAPoq3MifcyDlloJqfP9hz/jYGxFSKwbIqGvMlqjh36
qf9sO4ZQX/3wun9IV+BcZ+6McMBaAT8F9wysK8qfJg==
=cqlB
-----END PGP SIGNATURE-----

--------------NXIEBuOpEn5CvRJ0wGQQybuA--


From xen-devel-bounces@lists.xenproject.org Tue Feb 15 10:41:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 10:41:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.272995.468024 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJvGW-00033u-O5; Tue, 15 Feb 2022 10:41:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 272995.468024; Tue, 15 Feb 2022 10:41:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJvGW-00033n-L5; Tue, 15 Feb 2022 10:41:00 +0000
Received: by outflank-mailman (input) for mailman id 272995;
 Tue, 15 Feb 2022 10:40:59 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=az2O=S6=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nJvGV-00033h-Mp
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 10:40:59 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c2c98d55-8e4b-11ec-8eb8-a37418f5ba1a;
 Tue, 15 Feb 2022 11:40:58 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 1D4011F38A;
 Tue, 15 Feb 2022 10:40:58 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id AB05713C16;
 Tue, 15 Feb 2022 10:40:57 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id RecLKDmDC2LbJQAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 15 Feb 2022 10:40:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c2c98d55-8e4b-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1644921658; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=BbO/aayJKv3Edm7OrsXCQNm2PQ9c9b2VI12YMdtOxDQ=;
	b=fjU3hXf82yGKyDHm0TBKa6EWnw3FMFPeAy5R0OVTxMXVHbYBEDbjd3tlyilEqV3OsEKp4P
	ATEd1XYPF1WEsF+wQBWeeUU59wKi2Q7JjZPfI5ZW61+ZAbhCjrv12YQfew4WZzsPM7Bgb+
	bZwsOntmEW6ZIN4oW0hdyliaNBIg9ng=
Message-ID: <5207b025-5b92-682e-5904-4e5014f76d7c@suse.com>
Date: Tue, 15 Feb 2022 11:40:57 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Subject: Re: [PATCH 3/5] xen/sched: retrieve scheduler id by name
Content-Language: en-US
To: Luca Fancellu <luca.fancellu@arm.com>, xen-devel@lists.xenproject.org
Cc: wei.chen@arm.com, George Dunlap <george.dunlap@citrix.com>,
 Dario Faggioli <dfaggioli@suse.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>
References: <20220215101551.23101-1-luca.fancellu@arm.com>
 <20220215101551.23101-4-luca.fancellu@arm.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <20220215101551.23101-4-luca.fancellu@arm.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------NPpFmFhxoc0w4u0zo0wi0lZM"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------NPpFmFhxoc0w4u0zo0wi0lZM
Content-Type: multipart/mixed; boundary="------------IbhXjPvjkeV2iY1PMQFN536w";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Luca Fancellu <luca.fancellu@arm.com>, xen-devel@lists.xenproject.org
Cc: wei.chen@arm.com, George Dunlap <george.dunlap@citrix.com>,
 Dario Faggioli <dfaggioli@suse.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>
Message-ID: <5207b025-5b92-682e-5904-4e5014f76d7c@suse.com>
Subject: Re: [PATCH 3/5] xen/sched: retrieve scheduler id by name
References: <20220215101551.23101-1-luca.fancellu@arm.com>
 <20220215101551.23101-4-luca.fancellu@arm.com>
In-Reply-To: <20220215101551.23101-4-luca.fancellu@arm.com>

--------------IbhXjPvjkeV2iY1PMQFN536w
Content-Type: multipart/mixed; boundary="------------BoNXMU0BuUrcqVs0mAx688c0"

--------------BoNXMU0BuUrcqVs0mAx688c0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMTUuMDIuMjIgMTE6MTUsIEx1Y2EgRmFuY2VsbHUgd3JvdGU6DQo+IEFkZCBhIHB1Ymxp
YyBmdW5jdGlvbiB0byByZXRyaWV2ZSB0aGUgc2NoZWR1bGVyIGlkIGJ5IHRoZSBzY2hlZHVs
ZXINCj4gbmFtZS4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IEx1Y2EgRmFuY2VsbHUgPGx1Y2Eu
ZmFuY2VsbHVAYXJtLmNvbT4NCj4gLS0tDQo+ICAgeGVuL2NvbW1vbi9zY2hlZC9jb3JlLmMg
fCAxMSArKysrKysrKysrKw0KPiAgIHhlbi9pbmNsdWRlL3hlbi9zY2hlZC5oIHwgMTEgKysr
KysrKysrKysNCj4gICAyIGZpbGVzIGNoYW5nZWQsIDIyIGluc2VydGlvbnMoKykNCj4gDQo+
IGRpZmYgLS1naXQgYS94ZW4vY29tbW9uL3NjaGVkL2NvcmUuYyBiL3hlbi9jb21tb24vc2No
ZWQvY29yZS5jDQo+IGluZGV4IDhmNGIxY2ExMGQxYy4uOTY5NmQzYzFkNzY5IDEwMDY0NA0K
PiAtLS0gYS94ZW4vY29tbW9uL3NjaGVkL2NvcmUuYw0KPiArKysgYi94ZW4vY29tbW9uL3Nj
aGVkL2NvcmUuYw0KPiBAQCAtMjk0Nyw2ICsyOTQ3LDE3IEBAIHZvaWQgc2NoZWR1bGVyX2Vu
YWJsZSh2b2lkKQ0KPiAgICAgICBzY2hlZHVsZXJfYWN0aXZlID0gdHJ1ZTsNCj4gICB9DQo+
ICAgDQo+ICtpbnQgX19pbml0IHNjaGVkX2dldF9pZF9ieV9uYW1lKGNvbnN0IGNoYXIgKnNj
aGVkX25hbWUpDQo+ICt7DQo+ICsgICAgdW5zaWduZWQgaW50IGk7DQo+ICsNCj4gKyAgICBm
b3IgKCBpID0gMDsgaSA8IE5VTV9TQ0hFRFVMRVJTOyBpKysgKQ0KPiArICAgICAgICBpZiAo
IHNjaGVkdWxlcnNbaV0gJiYgIXN0cmNtcChzY2hlZHVsZXJzW2ldLT5vcHRfbmFtZSwgc2No
ZWRfbmFtZSkgKQ0KPiArICAgICAgICAgICAgcmV0dXJuIHNjaGVkdWxlcnNbaV0tPnNjaGVk
X2lkOw0KPiArDQo+ICsgICAgcmV0dXJuIC0xOw0KPiArfQ0KPiArDQoNClBsZWFzZSBtYWtl
IHVzZSBvZiB0aGlzIGZ1bmN0aW9uIGluIHNjaGVkdWxlcl9pbml0KCksIGFzIHRoaXMNCmZ1
bmN0aW9uYWxpdHkgaXMgb3BlbiBjb2RlZCB0aGVyZSwgdG9vLg0KDQoNCkp1ZXJnZW4NCg==

--------------BoNXMU0BuUrcqVs0mAx688c0
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------BoNXMU0BuUrcqVs0mAx688c0--

--------------IbhXjPvjkeV2iY1PMQFN536w--

--------------NPpFmFhxoc0w4u0zo0wi0lZM
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmILgzkFAwAAAAAACgkQsN6d1ii/Ey8u
hgf+IPOj1pOB4hA63+QYio8Qi4x5h7Sks3WXWfk2NLcVTjpy7z3JqMyZk2dNZsgVakM5PSnLJx/h
bOGVlsVt5GonFpE3b14SumGQCO81tXY3Uf04nsWq7XDRrlSTGiMzZIm6xOuC2MB2J4nvptlEQE6C
NwE4vqSIFOdEwlZL3G0vLsZ4MtEtMmf/aMmvJTWNKsJh7cgPS1PF2mgDhi/OtQRmreVFuws+NnqI
2PxbHIdv9NsgT5rNgOMmBGnqhehMLkdbJ/fZ5y5DHti73hYuJdz+KUUxMgeWjwJFxSvZ9Dst386a
EXNTAv/uxcFfQARqnJKY8kTkUHR+HG/klVOCjfD9fw==
=c5dQ
-----END PGP SIGNATURE-----

--------------NPpFmFhxoc0w4u0zo0wi0lZM--


From xen-devel-bounces@lists.xenproject.org Tue Feb 15 10:48:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 10:48:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273005.468035 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJvNh-0003jy-Ht; Tue, 15 Feb 2022 10:48:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273005.468035; Tue, 15 Feb 2022 10:48:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJvNh-0003jr-Do; Tue, 15 Feb 2022 10:48:25 +0000
Received: by outflank-mailman (input) for mailman id 273005;
 Tue, 15 Feb 2022 10:48:24 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=az2O=S6=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nJvNg-0003jl-51
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 10:48:24 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id cb9ce62b-8e4c-11ec-b215-9bbe72dcb22c;
 Tue, 15 Feb 2022 11:48:22 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 5ACE71F38A;
 Tue, 15 Feb 2022 10:48:22 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E82C813C51;
 Tue, 15 Feb 2022 10:48:21 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id Jm+JNvWEC2KAKQAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 15 Feb 2022 10:48:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cb9ce62b-8e4c-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1644922102; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=ZuvSLSxwbmb5A6tlfi9Q8ctChVdW6o0Yygd+0MI1wis=;
	b=SSLfzZ9YeZ3R3p8U7V5NkhNupHaJLItsDqpAtOeLYHauXrxnH65QpIgZ4i61yai1eu1UD5
	WDz/KC30pspAL/ryGSGxGRnnLmwl1P04oug77+/nWT8gCg4e3/eKXDZlumyUCsO75ffhkC
	GvJ0aWpcIl09J0LToUFLNX4+/RUIgvI=
Message-ID: <d6f36774-ecb5-15f4-b0c0-6114724060e6@suse.com>
Date: Tue, 15 Feb 2022 11:48:21 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Subject: Re: [PATCH 4/5] xen/cpupool: Create different cpupools at boot time
Content-Language: en-US
To: Luca Fancellu <luca.fancellu@arm.com>, xen-devel@lists.xenproject.org
Cc: wei.chen@arm.com, Stefano Stabellini <sstabellini@kernel.org>,
 Julien Grall <julien@xen.org>, Volodymyr Babchuk
 <Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>, Dario Faggioli <dfaggioli@suse.com>
References: <20220215101551.23101-1-luca.fancellu@arm.com>
 <20220215101551.23101-5-luca.fancellu@arm.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <20220215101551.23101-5-luca.fancellu@arm.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------IH1xSgiRHrgOw810U9nQXYMh"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------IH1xSgiRHrgOw810U9nQXYMh
Content-Type: multipart/mixed; boundary="------------F2Md6mPTv1jnNv9QytnN2Bf6";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Luca Fancellu <luca.fancellu@arm.com>, xen-devel@lists.xenproject.org
Cc: wei.chen@arm.com, Stefano Stabellini <sstabellini@kernel.org>,
 Julien Grall <julien@xen.org>, Volodymyr Babchuk
 <Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>, Dario Faggioli <dfaggioli@suse.com>
Message-ID: <d6f36774-ecb5-15f4-b0c0-6114724060e6@suse.com>
Subject: Re: [PATCH 4/5] xen/cpupool: Create different cpupools at boot time
References: <20220215101551.23101-1-luca.fancellu@arm.com>
 <20220215101551.23101-5-luca.fancellu@arm.com>
In-Reply-To: <20220215101551.23101-5-luca.fancellu@arm.com>

--------------F2Md6mPTv1jnNv9QytnN2Bf6
Content-Type: multipart/mixed; boundary="------------gycSYTcWkOrVZhXQy1o5Sqoe"

--------------gycSYTcWkOrVZhXQy1o5Sqoe
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMTUuMDIuMjIgMTE6MTUsIEx1Y2EgRmFuY2VsbHUgd3JvdGU6DQo+IEludHJvZHVjZSBh
biBhcmNoaXRlY3R1cmUgc3BlY2lmaWMgd2F5IHRvIGNyZWF0ZSBkaWZmZXJlbnQgY3B1cG9v
bHMNCj4gYXQgYm9vdCB0aW1lLCB0aGlzIGlzIHBhcnRpY3VsYXJseSB1c2VmdWwgb24gQVJN
IGJpZy5MSVRUTEUgc3lzdGVtDQo+IHdoZXJlIHRoZXJlIG1pZ2h0IGJlIHRoZSBuZWVkIHRv
IGhhdmUgZGlmZmVyZW50IGNwdXBvb2xzIGZvciBlYWNoIHR5cGUNCj4gb2YgY29yZSwgYnV0
IGFsc28gc3lzdGVtcyB1c2luZyBOVU1BIGNhbiBoYXZlIGRpZmZlcmVudCBjcHUgcG9vbHMg
Zm9yDQo+IGVhY2ggbm9kZS4NCj4gDQo+IFRoZSBmZWF0dXJlIG9uIGFybSByZWxpZXMgb24g
YSBzcGVjaWZpY2F0aW9uIG9mIHRoZSBjcHVwb29scyBmcm9tIHRoZQ0KPiBkZXZpY2UgdHJl
ZSB0byBidWlsZCBwb29scyBhbmQgYXNzaWduIGNwdXMgdG8gdGhlbS4NCj4gDQo+IERvY3Vt
ZW50YXRpb24gaXMgY3JlYXRlZCB0byBleHBsYWluIHRoZSBmZWF0dXJlLg0KPiANCj4gU2ln
bmVkLW9mZi1ieTogTHVjYSBGYW5jZWxsdSA8bHVjYS5mYW5jZWxsdUBhcm0uY29tPg0KDQpJ
SVJDIEkgc3VnZ2VzdGVkIHRvIGhhdmUgdGhlIGNvcmUgZnVuY3Rpb25hbGl0eSBpbiBjb21t
b24gY29kZSBpbiBvcmRlcg0KdG8gYWxsb3cgdXNpbmcgYm9vdCB0aW1lIGNwdXBvb2wgY3Jl
YXRpb24gZS5nLiB2aWEgY29tbWFuZGxpbmUgZm9yIHg4NiwNCnRvby4NCg0KDQpKdWVyZ2Vu
DQo=
--------------gycSYTcWkOrVZhXQy1o5Sqoe
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------gycSYTcWkOrVZhXQy1o5Sqoe--

--------------F2Md6mPTv1jnNv9QytnN2Bf6--

--------------IH1xSgiRHrgOw810U9nQXYMh
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmILhPUFAwAAAAAACgkQsN6d1ii/Ey85
7wgAlWjfkno+W1GlGSLhlpfi433RqQYOTngZk01HkvI1L8H/ZTzpofqXQvGBwfi5JnH6hxHNzmmi
ZYlAdcLdf/7UMDoYBxXo/2UP2OQVf4ikjw9xD7F8TkFc1zGfCmh2AZZmhOGywjxjQ0HzMSrnTWF4
f8CfoSz8I0LuyINpB+g5Hl9MJrN1+ydDB+iGYqTUQY1w0icNv5I/tNL5D2hpzxsD+4O2xgpPr/ur
y9nUUqTN7ZgKrQkMduISWo5KEFdNwGZJddmPQF416Du0SyPTBb4tHbCoQkgUGy7rgjSrZitiMuKQ
VRSaxfBijUmI0lXEeFJggPOw9kQ7cd5fhG7y1Gs1Gw==
=boQB
-----END PGP SIGNATURE-----

--------------IH1xSgiRHrgOw810U9nQXYMh--


From xen-devel-bounces@lists.xenproject.org Tue Feb 15 10:48:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 10:48:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273006.468046 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJvNo-00042H-Tn; Tue, 15 Feb 2022 10:48:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273006.468046; Tue, 15 Feb 2022 10:48:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJvNo-00042A-QQ; Tue, 15 Feb 2022 10:48:32 +0000
Received: by outflank-mailman (input) for mailman id 273006;
 Tue, 15 Feb 2022 10:48:32 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=vySV=S6=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nJvNo-00041M-0f
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 10:48:32 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ce82436f-8e4c-11ec-8eb8-a37418f5ba1a;
 Tue, 15 Feb 2022 11:48:29 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ce82436f-8e4c-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644922109;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=1HNuaJYL/+PWrTgXUd5wTUGMEHgYaDO4rQEq/OnxnUE=;
  b=We2ZcCOkEZC2FDUQkj7Qbfhpw99N+LdzlqmdA/5AMkuSLlLPG1EfoE2v
   zL/9J1ja5vV6bzYlW3pE38hor/bGQS+XhPATW6n78qXM3sR0G1Ik0gKRq
   g9ksxPLZW1qh6X1619ZKefm/N6QtZsdcUKf6bljdWD28FrkDc5cXVYI40
   4=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: EQ3/F/6IYS7t1jyANOxBKtTUTCW0lUUnmCXWXTV1ChmyRXXrJW9sZW3OD+eR+eudmA/wHtvh1a
 e8DLddyd/1KOM8CqBA9XN6yK6+fmL/Cm0jfHC2sTp/XdilBE3QCCU63MAvK2pETOJMX2VkX0V5
 MhXvsmdzEnsBFy6W3Wj0e3p9sEznojpJVtl62F0D9bZlkLiDye6mggiFwQ1QiBR6CqMIep0hO5
 Rg4RemRYdrQMZC1tt8fASZOm6Txh9tjHtv9aSuzWF7AmPlsmkFeUXs0AqhYCfsnxMobXiEBUpt
 FjcPG0XmQBvR04g85ybkMw5S
X-SBRS: 5.1
X-MesageID: 63672312
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:aVWNlK8D7sFsrhbna2WkDrUDpHiTJUtcMsCJ2f8bNWPcYEJGY0x3y
 zYZXzyAM/mINGP2L4hyYYi2pk5SvJDRyocyTQpl/no8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhFWeIdA970Ug5w7Rg39Yy6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhVx
 t5crJycZTx5HZD8qMgNYQkAAX1HaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguw5K8bmJsUHs2xIxjDFF/c2B5vERs0m4PcGh2lv3JsXR54yY
 eIbWzFLcgb4OidsM3I4VbMBgsCLuCbWJmgwRFW9+vNsvjm7IBZK+LH3LNfQTdmbSsxUk1iwq
 3rP+iLyBRRyHMKYzT2J43e9nNjFlCnwWJ8RPLCg//ssi1qWrkQZBQcKT1K9rb+8g1SnRtNEA
 0UO/2wlqq1a3EuvQ9rmVhu0ukmNuBIGRsFQGO037gKK4qfM6gPfDW8BJhZbYdw7sIktRDol1
 neAhdavDjtq2JWSTX+e7b6SoSmFJTkOLWQCaCkHSiMI+9Dm5oo0i3rnXttlVaK4kNDxMTXx2
 CyR6jgzga0JiswG3Ln9+krI6xqloJTTFFZtvi3YW2uk6kVyY4vNT46i5EXf7P1ABJ2EVVTHt
 38B8+CF9/wHB5yJkC2LQc0OEauv6vLDNyfT6XZtAp0g+jKF63OlO4dK71lDyFxBa5heP2WzO
 QmK5F0XtMQ70GaWgbFfR4y6Gt0q4YTbRffYZsD4fuheOootTVrSlM1xXnK402fomUkqtKgwP
 5aHbMqhZUon5bRbICmeHLlEj+Jyrswq7SaKHM2gkUz7uVaLTCPNEd843E2ygvfVBU9uiCHc6
 J5hOsSD0H2zu8WuM3CMoeb/wb3nREXX5KwaSeQKLIZvwSI8QQnN7sM9Jpt7JeRYc1x9zLugw
 51EchYwJKDDrXPGMx6WTXtodaniW51yxVpiY3BwYgb4hiV7ON31hEv6S3fQVeN5nNGPMNYuF
 6VVEyl+Kqgnpsv7F8Q1MsCm8d0KmOWDjgOSJSu1CAXTjLY7LzElDuTMJ1O1nAFXV3LfnZJn/
 9WIi1OKKbJeFl8KJJuHN5qSI6aZ4CF1dBRaBBCTfLG+uSzEreBXFsAGpqZsfZ9VcUyZnmTyO
 sT/KU5wmNQharQdqbHhrauFs52oA615GE9bFHPc9rG4KW/R+W/L/GOKeL/gken1WDym9aO8S
 /9Syv2gYvQLkEwT69h3EqpxzLJ47Nzq/ucIwgNhFXTNTlKqFrI/fSXWgZgR7vVAlu1DpA+7e
 kOT4d0Ga7+HD9zoTQwKLw0/Y+XdifxNwmvO7e44KVnR7TNs+ObVSl1bOhSB0XQPLLZ8PI4/7
 /0mvcoat162hhYwa47UhSFI7WWcaHcHVvx/5J0dBYbqjCsty01DPsOAWnOnvsnXZowVYEcwI
 zKSiK7TvJhmxxLPIygpCHzA/etBnpBS6hpE+0APegaSkd3fi/5pgBAIqWYrTh5Yxwls2v5oP
 jQ5LFV8IKiD8ms6hMVHWGzwSQhNCAfApx70wloN0mbYU1OpRirGK2hkYbSB+0UQ8mR9eDlH/
 e7HlDa5AGiyJMyhjDEvXUNFquD4SY0j/wLPr8mrAsCZEsRoejHimKKvOTIFphaP7RndX6EbS
 T2GJNpNVJA=
IronPort-HdrOrdr: A9a23:AX4FI6q/rdB1lxg9y7qNZm8aV5uzL9V00zEX/kB9WHVpm5Oj+P
 xGzc526farslsssREb+OxpOMG7MBThHLpOkPMs1NCZLXTbUQqTXfpfBO7ZrQEIdBeOlNK1uZ
 0QFpSWTeeAcWSS7vyKkTVQcexQueVvmZrA7Yy1rwYPcegpUdAZ0+4QMHfkLqQcfnghOXNWLu
 v52iIRzADQBkj/I/7LTUUtbqzmnZnmhZjmaRkJC1oO7xSPtyqh7PrfHwKD1hkTfjtTyfN6mF
 K13jDR1+GGibWW2xXc32jc49B/n8bg8MJKAIiphtIOIjvhpw60bMBKWqGEvhoyvOazgWxa2u
 XkklMFBYBe+nnRdma6rV/E3BTh6i8n7zvYxVqRkRLY0LrEbQN/L/AEqZNScxPf5UZllsp7yr
 h302WQsIcSJQ/cnQzmjuK4GS1Cpw6Rmz4PgOQTh3tQXc81c7lKt7ES+0tTDdMpAD/60oY6C+
 NjZfusq8q+SWnqL0wxg1Mfg+BFBh8Ib1W7qwk5y4CoOgFt7TFEJxBy/r1bop8CnKhNPKWsqd
 60dpiAr4s+PfP+W5gNcNvpcfHHelAlfii8Ql56AW6XXZ3vaEi946Ie3t0OlZSXkdozvdwPpK
 g=
X-IronPort-AV: E=Sophos;i="5.88,370,1635220800"; 
   d="scan'208";a="63672312"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=bJ+X3kSd7ZEa4X9Hy2sOEn+mrCrgxvC5NdugLImThLv/D7K+XNzn1SK7FkcUNfaH+kHhUunIriaKPKx/aB347ufY0xWH8wtF6azMgh2zEccryanRNdLbi/Xy8wbP4/9WVKzz+d6Y8o1UB166Cv3akiPvVpVnIjDxtym19HYbjuUrJMCDgu0Y+cFFoEQlJTYpzWDvXOLoOqxrB6tjChjQ6PDxysRAbY0gwKSiVAfPrAs2GRmy5wAeGc42GbWa1ltx6GNPr1ZJg1dCim+EwW+YiDbgp6nRwfiy1gWW++COTrRKkAqk7SLEnp7s2q6pduiEDHgJRpYCLXMwaWdF373p/Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Z/GsZZ/tQMpm7fhOCkl8fdHVdjaleBvvxnZSdZgItSI=;
 b=OAud1JuyFf6ygju20Ffvv7twbPj67CoXTcxvZs9Whb6MYvt9qJdBF/Dq7QT9LfawJCmh0CaOAQVWjGqKVPMrF/cLL6mNwmfti8xlHxi7VxUtF8eeEoJre1wLBLtQTaRZex9B7n4ag+S9RtK+xsR2n4FphSomVJAyZYIbsEO0Jnx8h1+mbWNSv9CgMwz6sPJRO/YQM4zJiSO5LaAWLqwmu1N82kh3KhzgH5vpvYs7QZ/4E31ftsNsK4scWZdsUNMTcPz3zkdGM8Ey/30ZrQn2b03JEP+P8UIGnddZO6ZNL6qFAKDzCGto3U+S2ElQdOAoWyqcHJz8tBMd53ROyt3igg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Z/GsZZ/tQMpm7fhOCkl8fdHVdjaleBvvxnZSdZgItSI=;
 b=foa/GJn/tDRKExbVeqSvkojP/QZdsZrmw318y0mVKFL+9zJTQ8SR8/hekkoK8BArwpriJfCpMhMihScXwBYwTnTfrxXQ3MuaUly7JBFtzDltZLCMnWYCS9EdQXz1l4qQ+Qmam2uqkqOyU3K+LfMHWN/FbzKKkRXTinxIxVykjDg=
Date: Tue, 15 Feb 2022 11:48:13 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Oleksandr Andrushchenko <andr2000@gmail.com>
CC: <xen-devel@lists.xenproject.org>, <jbeulich@suse.com>, <julien@xen.org>,
	<sstabellini@kernel.org>, <oleksandr_tyshchenko@epam.com>,
	<volodymyr_babchuk@epam.com>, <artem_mygaiev@epam.com>,
	<bertrand.marquis@arm.com>, <rahul.singh@arm.com>, Oleksandr Andrushchenko
	<oleksandr_andrushchenko@epam.com>
Subject: Re: [PATCH v2] vpci: introduce per-domain lock to protect vpci
 structure
Message-ID: <YguE7RWOteSnvVNY@Air-de-Roger>
References: <20220215081135.1497470-1-andr2000@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220215081135.1497470-1-andr2000@gmail.com>
X-ClientProxiedBy: LNXP265CA0076.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:76::16) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 28b57949-54bb-4c5e-1f0b-08d9f070acc4
X-MS-TrafficTypeDiagnostic: BYAPR03MB3800:EE_
X-Microsoft-Antispam-PRVS: <BYAPR03MB3800756E539C21B77BBD71BB8F349@BYAPR03MB3800.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: tNpZIjamx+kN97vqV8DKZQtKAyaOlgzWUOoQSqe+df7PlghcR5hKSYv+w/E4B3AUsSzOfeqtspWgqqF0+ew1wJ1zO6kqMIXs5p2ZiGStWxL3q8uO9ZjUIhUZRgv6p1usftQsRup6h9b+uw84WjsebflgxDvjOFA9laeSz153+2srSvyn0GqCHpY/FK5TnAzDA1Fuuvn4LPnO+mxSbQ4iLEtPPcoIGi++ig87kVX6m/aCpP5u9qjpSmtsfuJ2T2O/LJeDr/e7Q5XSBKuc0ymfRWEZ180S6C848vqxzvMcXMF8raDLtRJ2k1a3JwQANFctR1EjIZfjgsW6LT5bKXTXi+qemBIlbHoPJE8aIvBK9D4RNFnLT+ieDfY6w9CFZGn8jG9Bs96RHKNdfnRUWpHcBwkqgFHHI2G1/4lhigaAV2uvc04r+SzwQ0kQtKLEk+ofg1aLvO50Bz2CLsVSqjshFgE46GnV1aL8tMMpOL43lmVyisbNngzw9POYpbhlTeo0ZU5Y6o4fKv0miUIw9eeY8b+lsvIhmCUYGYbJTZpjiapjZlhxb70FPvRdlkRhAjdAHBtPvle+S9YcVTvrF73RpDYc0mT55QJFi/ESjKm6bRuuvCPKuhygDH7xI1WOdUX3VoovxuENY+EfWf2FVvmGWzMPnqEZvZHuKWN0GGTCmz59u6cnZiF4PiY8TxAmvVZ4Jw2caRMsqZlUf/8ayCF/NiPRUFgnmIu86Xn6rQrm2g8=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(6486002)(9686003)(6512007)(85182001)(508600001)(83380400001)(6506007)(966005)(33716001)(6666004)(316002)(6916009)(86362001)(66946007)(5660300002)(2906002)(38100700002)(8936002)(8676002)(66556008)(66476007)(186003)(82960400001)(26005)(4326008)(7416002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZU5IRGJqSllGS0dDL1VWeDZRaSttRGZaMG5BYnNJL0Z6RXJQeXlDOTVZMVlv?=
 =?utf-8?B?UnBFbmNFVkx1TWZOU0pMa3lXOHZIWVRRQ0FrS213dmZpbGptSnRxYnVmMFNZ?=
 =?utf-8?B?cUt6eE9LN1JBSTcxeVRVNXlzZUVMZUNQa3hqQTBQMDNiemRjbG5CVlJGVGV4?=
 =?utf-8?B?ckVtSDlOZko1TFB6VEYzcjQrSllxcm9wSnRSdzJwTVVnQ3hDOUNyV1B6NXox?=
 =?utf-8?B?M2w4eVN4Mm1iUU9UWUhYc1RVZzlrdHhaWnhUai9DU0d6YTJBRXZpWG94anly?=
 =?utf-8?B?ZkszSWw4ZUpnUHBwcUZ6M2J0V1BuZ0l6Z2JVYnRVbHdLZThEUDd3Y2ljaGlr?=
 =?utf-8?B?OFJyQTk2OVdzbXlzSFFweHc5Q2E3cHorQTFOQXNzdTZrYk5ySGcyd2pCQnNj?=
 =?utf-8?B?NWtMUFlCYUJta2puRUdCdURSMEpKOFZubUUzRFZ1c1luWmcrZHRlUzRQZ2tm?=
 =?utf-8?B?NEFTcTdEUjVyRThHWE5XQllPc3k0S3dtMWxSVkdIcEswbEhROWRNc0xQTDhX?=
 =?utf-8?B?QlAxaTZCNlN3ekZrRmRCQlEzL3dhL01ldWtOU3NTanpYakt0SGpGNkhqcDY3?=
 =?utf-8?B?cnBIaFMzZDhVeXZIVE9tWG01OStoekdDQkdlenRTMThOSVVTVFlGRmpSQnh6?=
 =?utf-8?B?TFcyclppQzBDeWltNDlKT09adUtDaldUcEk3RjBNZHVaSHAxT0UvR2l4bWg4?=
 =?utf-8?B?YlZkZExwSUJLZDJ2SU50QmRKaVZWcVUrUXR6dU1TMjZNRkpjbit6SmpDUVl0?=
 =?utf-8?B?S1EydVNvSmlpS0VmZGYwOUc3cjlBcXFGSW9HbWZPZG81N0V0cThzdnFadXIx?=
 =?utf-8?B?ZUVWNGhtZkJOWk5ra3dCN3ozWFZULzZQeERjMHFwRWsxQzBGQnFVUEwvWUJI?=
 =?utf-8?B?STlxL0dPNlp5RGRtMHZaazFQRmhJVlJCdzN0Z0UvRXZ3UWdRc3NORUdGbzYv?=
 =?utf-8?B?R0dyQ1ZwYUFiU0JjZ1grRmNmY3VYRmhUNmUxR3UyODI2U2FySjJNUVZtY01V?=
 =?utf-8?B?TWZHb0h5UFZFbnNlMVcvYVhxakZBeUdVY0prMHFwaTE0MHR3YVdsM2wvL1pm?=
 =?utf-8?B?V2R1UEIrL2JMeHVGTjB6SEVhMlBjVVBOWjVGeFl3TDVSbk4wL2UyZUZPdUxR?=
 =?utf-8?B?WHhZSnR5ZEVVREswNUJ6OVRlQlBoTUNoUW1HMnR5TzFoSmRvbmtKOGttTWs2?=
 =?utf-8?B?VkhmeVMxUTgraGZvTnZ2UTRRNnA3QzNHUGp5VldJVyt6WXhMSVl3QlovYlBR?=
 =?utf-8?B?T2cyLzlwdVcxS2ZNdGJjNUNoZjdldzJjMVQwZmRoYTRUVTAxWUV2ay9pTExm?=
 =?utf-8?B?VnlYM240VnhhczZCT2lJdDVNOUJGNVFDUWY4NS9zbWdLdnhMVjFJV1Bnc3ZV?=
 =?utf-8?B?UTl0VWdXd0szSDR0RUZaZjRCdXJLZHNDY2pzbHpNUEZjamYvckljVDlHNW5L?=
 =?utf-8?B?MFZQVDQ1U0FGb1oxWGVSbVkxQU5Makh4TzdiL25nSmdVWGNaYVpTdjZQaFNR?=
 =?utf-8?B?ZmJmMGtIb2EyM1UrZEVZcmlSSURyL3RpRmZaRlZSaW0yVVU3aEplMUkvdy96?=
 =?utf-8?B?aXgxVDVHeDk4dkRvU0FiVlFzbnRXdEZ2L1RlM0VEOUJBQnlaMTdRcDFnSCtk?=
 =?utf-8?B?cGFVYXdORG9maWxlWTR2Vi80QXhaSWNnU01xUkJRWTRDTm9SMWkzREU3bmgr?=
 =?utf-8?B?MzV4TVUwZlhIcytMdTZ3K0RGL1MrT1JlaW5KbGFTVURGYkN4clJCeFZNZys0?=
 =?utf-8?B?Wi82cVZuRzJaYkxKcjBpelFtZmZuSGtwZThwajZjMkpmMXBGWWlTdHlJWEsy?=
 =?utf-8?B?bG8yUFg0U296WDBSeGFJdXhvUVZnU1plM0U0L1d6OXd0OHEwbFlRQW11ajVi?=
 =?utf-8?B?ZElwS0lSblhQbzBjM3V6UkcyeEJoU0VkZTd4YjFJLzR1MUtXV1FYZzF4UWcz?=
 =?utf-8?B?bVdnOTNIRVNoN1o2Z3JXb3Fkd01pWXpKU2x1UnY4em1QYmRXSWdteENROW0y?=
 =?utf-8?B?N0pxMzZzaDgxWkwwUE14aGg0S2VuSUtwb3VBNjduQ3YvaXNqV1pjaWtuUnJN?=
 =?utf-8?B?aGdBUWxrZ09MTUVRdXNoWHB6bkdaNUo1Y2orUlBWTnh2TzZKdGkraXU2b0dG?=
 =?utf-8?B?bUZvSCtadFRNMmJIeTBkcm1CZTBtSnNNQUh0WnBia1Z6V2NiT2FjQ0s4Q2pF?=
 =?utf-8?Q?YblSAVUpgG9Jh6TWxmgoEYI=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 28b57949-54bb-4c5e-1f0b-08d9f070acc4
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 10:48:17.7360
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: m9nrnPe4TWG3oefQK3Yp6wblRB/4VYF3oPh1t7Mr6MrGe5plOxnkphE55j34U8qclRF6lKtCvE8pAYGf3gPOYQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB3800
X-OriginatorOrg: citrix.com

On Tue, Feb 15, 2022 at 10:11:35AM +0200, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> Introduce a per-domain read/write lock to check whether vpci is present,
> so we are sure there are no accesses to the contents of the vpci struct
> if not. This lock can be used (and in a few cases is used right away)
> so that vpci removal can be performed while holding the lock in write
> mode. Previously such removal could race with vpci_read for example.
> 
> 1. Per-domain's vpci_rwlock is used to protect pdev->vpci structure
> from being removed.
> 
> 2. Writing the command register and ROM BAR register may trigger
> modify_bars to run, which in turn may access multiple pdevs while
> checking for the existing BAR's overlap. The overlapping check, if done
> under the read lock, requires vpci->lock to be acquired on both devices
> being compared, which may produce a deadlock. It is not possible to
> upgrade read lock to write lock in such a case. So, in order to prevent
> the deadlock, check which registers are going to be written and acquire
> the lock in the appropriate mode from the beginning.
> 
> All other code, which doesn't lead to pdev->vpci destruction and does not
> access multiple pdevs at the same time, can still use a combination of the
> read lock and pdev->vpci->lock.
> 
> 3. Optimize if ROM BAR write lock required detection by caching offset
> of the ROM BAR register in vpci->header->rom_reg which depends on
> header's type.
> 
> 4. Reduce locked region in vpci_remove_device as it is now possible
> to set pdev->vpci to NULL early right after the write lock is acquired.
> 
> 5. Reduce locked region in vpci_add_handlers as it is possible to
> initialize many more fields of the struct vpci before assigning it to
> pdev->vpci.
> 
> 6. vpci_{add|remove}_register are required to be called with the write lock
> held, but it is not feasible to add an assert there as it requires
> struct domain to be passed for that. So, add a comment about this requirement
> to these and other functions with the equivalent constraints.
> 
> 7. Drop const qualifier where the new rwlock is used and this is appropriate.
> 
> 8. Do not call process_pending_softirqs with any locks held. For that unlock
> prior the call and re-acquire the locks after. After re-acquiring the
> lock there is no need to check if pdev->vpci exists:
>  - in apply_map because of the context it is called (no race condition
>    possible)
>  - for MSI/MSI-X debug code because it is called at the end of
>    pdev->vpci access and no further access to pdev->vpci is made
> 
> 9. Check for !pdev->vpci in vpci_{read|write} after acquiring the lock
> and if so, allow reading or writing the hardware register directly. This is
> acceptable as we only deal with Dom0 as of now. Once DomU support is
> added the write will need to be ignored and read return all 0's for the
> guests, while Dom0 can still access the registers directly.
> 
> 10. Introduce pcidevs_trylock, so there is a possibility to try locking
> the pcidev's lock.
> 
> 11. Use pcidev's lock around for_each_pdev and pci_get_pdev_by_domain
> while accessing pdevs in vpci code.

So if you use the pcidevs_lock then it's impossible for the pdev or
pdev->vpci to be removed or recreated, as the pcidevs lock protects
any device operations (add, remove, assign, deassign).

It's however not OK to use the pcidevs lock in vpci_{read,write}
as-is, as the introduced contention is IMO not acceptable.

The only viable option I see here is to:

 1. Make the pcidevs lock a rwlock: switch current callers to take the
    lock in write mode, detect and fixup any issues that could arise
    from the lock not being recursive anymore.
 2. Take the lock in read mode around vpci_{read,write} sections that
    rely on pdev (including the handlers).

These items should be at least two separate patches. Let's not mix the
conversion of pcidevs locks with the addition of vPCI support.

I think with that we could get away without requiring a per-domain
rwlock? Just doing lock ordering in modify_bars regarding
tmp->vpci->lock vs pdev->vpci->lock. Neither pdev or vpci can go away
while holding the pcidevs lock.

Sorting the situation in modify_bars should also be done as a separate
patch on top of 1. and 2.

> 
> 12. This is based on the discussion at [1].
> 
> [1] https://lore.kernel.org/all/20220204063459.680961-4-andr2000@gmail.com/
> 
> Suggested-by: Roger Pau Monné <roger.pau@citrix.com>
> Suggested-by: Jan Beulich <jbeulich@suse.com>
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

I've made some small comments below, but given my proposal above I
think the code would change a great deal if we decide to use pcidevs
lock.

> 
> ---
> This was checked on x86: with and without PVH Dom0.
> 
> Since v1:
> - s/ASSERT(!!/ASSERT(
> - move vpci_header_write_lock to vpci.c and rename to
>   vpci_header_need_write_lock
> - use a simple static overlap function instead of vpci_offset_cmp
> - signal no ROM BAR with rom_reg == 0
> - msix_accept: new line before return
> - do not run process_pending_softirqs with locks held
> - in-code comments update
> - move rom_reg before rom_enabled in struct vpci. Roger, it is not
>   possible to move it after 'type' as in this case it becomes per BAR
>   and we need it per vpci
> - add !pdev->vpci checks to vpci_{read|write}
> - move ASSERT(pdev->vpci) in add_handlers under the write lock
> - introduce pcidevs_trylock
> - protect for_each_pdev with pcidevs lock
> ---
>  xen/arch/x86/hvm/vmsi.c       |   7 +++
>  xen/common/domain.c           |   3 +
>  xen/drivers/passthrough/pci.c |   5 ++
>  xen/drivers/vpci/header.c     |  56 +++++++++++++++++++
>  xen/drivers/vpci/msi.c        |  25 ++++++++-
>  xen/drivers/vpci/msix.c       |  41 ++++++++++++--
>  xen/drivers/vpci/vpci.c       | 100 ++++++++++++++++++++++++++--------
>  xen/include/xen/pci.h         |   1 +
>  xen/include/xen/sched.h       |   3 +
>  xen/include/xen/vpci.h        |   6 ++
>  10 files changed, 215 insertions(+), 32 deletions(-)
> 
> diff --git a/xen/arch/x86/hvm/vmsi.c b/xen/arch/x86/hvm/vmsi.c
> index 13e2a190b439..2a13c6581345 100644
> --- a/xen/arch/x86/hvm/vmsi.c
> +++ b/xen/arch/x86/hvm/vmsi.c
> @@ -893,6 +893,9 @@ int vpci_msix_arch_print(const struct vpci_msix *msix)
>  {
>      unsigned int i;
>  
> +    ASSERT(rw_is_locked(&msix->pdev->domain->vpci_rwlock));
> +    ASSERT(pcidevs_locked());
> +
>      for ( i = 0; i < msix->max_entries; i++ )
>      {
>          const struct vpci_msix_entry *entry = &msix->entries[i];
> @@ -911,7 +914,11 @@ int vpci_msix_arch_print(const struct vpci_msix *msix)
>              struct pci_dev *pdev = msix->pdev;
>  
>              spin_unlock(&msix->pdev->vpci->lock);
> +            pcidevs_unlock();
> +            read_unlock(&pdev->domain->vpci_rwlock);
>              process_pending_softirqs();
> +            read_lock(&pdev->domain->vpci_rwlock);
> +            pcidevs_lock();

This is again an ABBA situation: vpci_add_handlers will get called
with pci_devs locked, and it will try to acquire the per-domain vpci
lock (so pcidevs -> vpci_rwlock) while here and in other places in the
patch to you have inverse locking order (vpci_rwlock -> pcidevs).

>              /* NB: we assume that pdev cannot go away for an alive domain. */
>              if ( !pdev->vpci || !spin_trylock(&pdev->vpci->lock) )
>                  return -EBUSY;
> @@ -323,10 +334,18 @@ uint32_t vpci_read(pci_sbdf_t sbdf, unsigned int reg, unsigned int size)
>      }
>  
>      /* Find the PCI dev matching the address. */
> +    pcidevs_lock();
>      pdev = pci_get_pdev_by_domain(d, sbdf.seg, sbdf.bus, sbdf.devfn);
> +    pcidevs_unlock();
>      if ( !pdev )
>          return vpci_read_hw(sbdf, reg, size);

There's a window here (between dropping the pcidevs lock and acquiring
the vpci_rwlock where either the pdev or pdev->vpci could be removed
or recreated.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Feb 15 10:57:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 10:57:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273021.468056 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJvVz-0005q5-P1; Tue, 15 Feb 2022 10:56:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273021.468056; Tue, 15 Feb 2022 10:56:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJvVz-0005py-M2; Tue, 15 Feb 2022 10:56:59 +0000
Received: by outflank-mailman (input) for mailman id 273021;
 Tue, 15 Feb 2022 10:56:58 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=az2O=S6=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nJvVy-0005ps-Ai
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 10:56:58 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id fe32ff06-8e4d-11ec-8eb8-a37418f5ba1a;
 Tue, 15 Feb 2022 11:56:57 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id CA03B1F391;
 Tue, 15 Feb 2022 10:56:56 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5196213C51;
 Tue, 15 Feb 2022 10:56:56 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id ZrjgEfiGC2LiLQAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 15 Feb 2022 10:56:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fe32ff06-8e4d-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1644922616; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=ZBFecVMiidsBtQmzL01/lbLwNM5bY0txYko2q4tETJE=;
	b=hnE9hBBojrboGEy/4b/f8elDNaEfsqXRxyRa8Ku1Zw21pIm+Xgn/jxWbpLnnzcVJ/lliG+
	yWLyH+A00yKsfyoaxXLciwi14IhAqajk+TPosh8+bm8Dg+t7+j9hwrLw/Bwkj2/kVuY6kt
	AaoO3KzhR5ocfHk94sfEQKx3HhVCq5g=
Message-ID: <812858d6-3f39-87ed-b495-a15d34f6e930@suse.com>
Date: Tue, 15 Feb 2022 11:56:55 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Content-Language: en-US
To: Luca Fancellu <luca.fancellu@arm.com>, xen-devel@lists.xenproject.org
Cc: wei.chen@arm.com, Stefano Stabellini <sstabellini@kernel.org>,
 Julien Grall <julien@xen.org>, Volodymyr Babchuk
 <Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <20220215101551.23101-1-luca.fancellu@arm.com>
 <20220215101551.23101-6-luca.fancellu@arm.com>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH 5/5] arm/dom0less: assign dom0less guests to cpupools
In-Reply-To: <20220215101551.23101-6-luca.fancellu@arm.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------sXbYd4uAD0j500VcPyIWXPS3"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------sXbYd4uAD0j500VcPyIWXPS3
Content-Type: multipart/mixed; boundary="------------wsR7P9fTHrsPlrF6ZT9c6yQj";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Luca Fancellu <luca.fancellu@arm.com>, xen-devel@lists.xenproject.org
Cc: wei.chen@arm.com, Stefano Stabellini <sstabellini@kernel.org>,
 Julien Grall <julien@xen.org>, Volodymyr Babchuk
 <Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Message-ID: <812858d6-3f39-87ed-b495-a15d34f6e930@suse.com>
Subject: Re: [PATCH 5/5] arm/dom0less: assign dom0less guests to cpupools
References: <20220215101551.23101-1-luca.fancellu@arm.com>
 <20220215101551.23101-6-luca.fancellu@arm.com>
In-Reply-To: <20220215101551.23101-6-luca.fancellu@arm.com>

--------------wsR7P9fTHrsPlrF6ZT9c6yQj
Content-Type: multipart/mixed; boundary="------------D659Q4h09ZboVdOfQisu0DX1"

--------------D659Q4h09ZboVdOfQisu0DX1
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMTUuMDIuMjIgMTE6MTUsIEx1Y2EgRmFuY2VsbHUgd3JvdGU6DQo+IEludHJvZHVjZSBk
b21haW4tY3B1cG9vbCBwcm9wZXJ0eSBvZiBhIHhlbixkb21haW4gZGV2aWNlIHRyZWUgbm9k
ZSwNCj4gdGhhdCBzcGVjaWZpZXMgdGhlIGNwdXBvb2wgZGV2aWNlIHRyZWUgaGFuZGxlIG9m
IGEgeGVuLGNwdXBvb2wgbm9kZQ0KPiB0aGF0IGlkZW50aWZpZXMgYSBjcHVwb29sIGNyZWF0
ZWQgYXQgYm9vdCB0aW1lIHdoZXJlIHRoZSBndWVzdCB3aWxsDQo+IGJlIGFzc2lnbmVkIG9u
IGNyZWF0aW9uLg0KPiANCj4gQWRkIG1lbWJlciB0byB0aGUgeGVuX2FyY2hfZG9tYWluY29u
ZmlnIHB1YmxpYyBpbnRlcmZhY2Ugc28gdGhlDQo+IFhFTl9ET01DVExfSU5URVJGQUNFX1ZF
UlNJT04gdmVyc2lvbiBpcyBidW1wZWQuDQo+IA0KPiBVcGRhdGUgZG9jdW1lbnRhdGlvbiBh
Ym91dCB0aGUgcHJvcGVydHkuDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBMdWNhIEZhbmNlbGx1
IDxsdWNhLmZhbmNlbGx1QGFybS5jb20+DQo+IC0tLQ0KPiAgIGRvY3MvbWlzYy9hcm0vZGV2
aWNlLXRyZWUvYm9vdGluZy50eHQgfCA1ICsrKysrDQo+ICAgeGVuL2FyY2gvYXJtL2RvbWFp
bi5jICAgICAgICAgICAgICAgICB8IDYgKysrKysrDQo+ICAgeGVuL2FyY2gvYXJtL2RvbWFp
bl9idWlsZC5jICAgICAgICAgICB8IDkgKysrKysrKystDQo+ICAgeGVuL2FyY2gveDg2L2Rv
bWFpbi5jICAgICAgICAgICAgICAgICB8IDYgKysrKysrDQo+ICAgeGVuL2NvbW1vbi9kb21h
aW4uYyAgICAgICAgICAgICAgICAgICB8IDUgKysrKy0NCj4gICB4ZW4vaW5jbHVkZS9wdWJs
aWMvYXJjaC1hcm0uaCAgICAgICAgIHwgMiArKw0KPiAgIHhlbi9pbmNsdWRlL3B1YmxpYy9k
b21jdGwuaCAgICAgICAgICAgfCAyICstDQo+ICAgeGVuL2luY2x1ZGUveGVuL2RvbWFpbi5o
ICAgICAgICAgICAgICB8IDMgKysrDQo+ICAgOCBmaWxlcyBjaGFuZ2VkLCAzNSBpbnNlcnRp
b25zKCspLCAzIGRlbGV0aW9ucygtKQ0KPiANCj4gZGlmZiAtLWdpdCBhL2RvY3MvbWlzYy9h
cm0vZGV2aWNlLXRyZWUvYm9vdGluZy50eHQgYi9kb2NzL21pc2MvYXJtL2RldmljZS10cmVl
L2Jvb3RpbmcudHh0DQo+IGluZGV4IDcxODk1NjYzYTRkZS4uMGYxZjIxMGZhNDQ5IDEwMDY0
NA0KPiAtLS0gYS9kb2NzL21pc2MvYXJtL2RldmljZS10cmVlL2Jvb3RpbmcudHh0DQo+ICsr
KyBiL2RvY3MvbWlzYy9hcm0vZGV2aWNlLXRyZWUvYm9vdGluZy50eHQNCj4gQEAgLTE4Miw2
ICsxODIsMTEgQEAgd2l0aCB0aGUgZm9sbG93aW5nIHByb3BlcnRpZXM6DQo+ICAgICAgIEJv
dGggI2FkZHJlc3MtY2VsbHMgYW5kICNzaXplLWNlbGxzIG5lZWQgdG8gYmUgc3BlY2lmaWVk
IGJlY2F1c2UNCj4gICAgICAgYm90aCBzdWItbm9kZXMgKGRlc2NyaWJlZCBzaG9ydGx5KSBo
YXZlIHJlZyBwcm9wZXJ0aWVzLg0KPiAgIA0KPiArLSBkb21haW4tY3B1cG9vbA0KPiArDQo+
ICsgICAgT3B0aW9uYWwuIEhhbmRsZSB0byBhIHhlbixjcHVwb29sIGRldmljZSB0cmVlIG5v
ZGUgdGhhdCBpZGVudGlmaWVzIHRoZQ0KPiArICAgIGNwdXBvb2wgd2hlcmUgdGhlIGd1ZXN0
IHdpbGwgYmUgc3RhcnRlZCBhdCBib290Lg0KPiArDQo+ICAgVW5kZXIgdGhlICJ4ZW4sZG9t
YWluIiBjb21wYXRpYmxlIG5vZGUsIG9uZSBvciBtb3JlIHN1Yi1ub2RlcyBhcmUgcHJlc2Vu
dA0KPiAgIGZvciB0aGUgRG9tVSBrZXJuZWwgYW5kIHJhbWRpc2suDQo+ICAgDQo+IGRpZmYg
LS1naXQgYS94ZW4vYXJjaC9hcm0vZG9tYWluLmMgYi94ZW4vYXJjaC9hcm0vZG9tYWluLmMN
Cj4gaW5kZXggOTJhNmM1MDllNWM1Li5iZTM1MGIyOGI1ODggMTAwNjQ0DQo+IC0tLSBhL3hl
bi9hcmNoL2FybS9kb21haW4uYw0KPiArKysgYi94ZW4vYXJjaC9hcm0vZG9tYWluLmMNCj4g
QEAgLTc4OCw2ICs3ODgsMTIgQEAgZmFpbDoNCj4gICAgICAgcmV0dXJuIHJjOw0KPiAgIH0N
Cj4gICANCj4gK3Vuc2lnbmVkIGludA0KPiArYXJjaF9nZXRfZG9tYWluX2NwdXBvb2xfaWQo
Y29uc3Qgc3RydWN0IHhlbl9kb21jdGxfY3JlYXRlZG9tYWluICpjb25maWcpDQo+ICt7DQo+
ICsgICAgcmV0dXJuIGNvbmZpZy0+YXJjaC5jcHVwb29sX2lkOw0KPiArfQ0KPiArDQoNCkkg
ZG9uJ3Qgc2VlIHdoeSB0aGlzIHNob3VsZCBiZSBhcmNoIHNwZWNpZmljLg0KDQo+ICAgdm9p
ZCBhcmNoX2RvbWFpbl9kZXN0cm95KHN0cnVjdCBkb21haW4gKmQpDQo+ICAgew0KPiAgICAg
ICAvKiBJT01NVSBwYWdlIHRhYmxlIGlzIHNoYXJlZCB3aXRoIFAyTSwgYWx3YXlzIGNhbGwN
Cj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9kb21haW5fYnVpbGQuYyBiL3hlbi9hcmNo
L2FybS9kb21haW5fYnVpbGQuYw0KPiBpbmRleCA2OTMxYzAyMmEyZTguLjRmMjM5ZTc1Njc3
NSAxMDA2NDQNCj4gLS0tIGEveGVuL2FyY2gvYXJtL2RvbWFpbl9idWlsZC5jDQo+ICsrKyBi
L3hlbi9hcmNoL2FybS9kb21haW5fYnVpbGQuYw0KPiBAQCAtMzAxNSw3ICszMDE1LDggQEAg
c3RhdGljIGludCBfX2luaXQgY29uc3RydWN0X2RvbVUoc3RydWN0IGRvbWFpbiAqZCwNCj4g
ICB2b2lkIF9faW5pdCBjcmVhdGVfZG9tVXModm9pZCkNCj4gICB7DQo+ICAgICAgIHN0cnVj
dCBkdF9kZXZpY2Vfbm9kZSAqbm9kZTsNCj4gLSAgICBjb25zdCBzdHJ1Y3QgZHRfZGV2aWNl
X25vZGUgKmNob3NlbiA9IGR0X2ZpbmRfbm9kZV9ieV9wYXRoKCIvY2hvc2VuIik7DQo+ICsg
ICAgY29uc3Qgc3RydWN0IGR0X2RldmljZV9ub2RlICpjcHVwb29sX25vZGUsDQo+ICsgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICpjaG9zZW4gPSBkdF9maW5kX25vZGVfYnlf
cGF0aCgiL2Nob3NlbiIpOw0KPiAgIA0KPiAgICAgICBCVUdfT04oY2hvc2VuID09IE5VTEwp
Ow0KPiAgICAgICBkdF9mb3JfZWFjaF9jaGlsZF9ub2RlKGNob3Nlbiwgbm9kZSkNCj4gQEAg
LTMwNTMsNiArMzA1NCwxMiBAQCB2b2lkIF9faW5pdCBjcmVhdGVfZG9tVXModm9pZCkNCj4g
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIEdVRVNUX1ZQTDAx
MV9TUEkgLSAzMiArIDEpOw0KPiAgICAgICAgICAgfQ0KPiAgIA0KPiArICAgICAgICAvKiBH
ZXQgdGhlIG9wdGlvbmFsIHByb3BlcnR5IGRvbWFpbi1jcHVwb29sICovDQo+ICsgICAgICAg
IGNwdXBvb2xfbm9kZSA9IGR0X3BhcnNlX3BoYW5kbGUobm9kZSwgImRvbWFpbi1jcHVwb29s
IiwgMCk7DQo+ICsgICAgICAgIGlmICggY3B1cG9vbF9ub2RlICkNCj4gKyAgICAgICAgICAg
IGR0X3Byb3BlcnR5X3JlYWRfdTMyKGNwdXBvb2xfbm9kZSwgImNwdXBvb2wtaWQiLA0KPiAr
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJmRfY2ZnLmFyY2guY3B1cG9vbF9p
ZCk7DQo+ICsNCj4gICAgICAgICAgIC8qDQo+ICAgICAgICAgICAgKiBUaGUgdmFyaWFibGUg
bWF4X2luaXRfZG9taWQgaXMgaW5pdGlhbGl6ZWQgd2l0aCB6ZXJvLCBzbyBoZXJlIGl0J3MN
Cj4gICAgICAgICAgICAqIHZlcnkgaW1wb3J0YW50IHRvIHVzZSB0aGUgcHJlLWluY3JlbWVu
dCBvcGVyYXRvciB0byBjYWxsDQo+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC94ODYvZG9tYWlu
LmMgYi94ZW4vYXJjaC94ODYvZG9tYWluLmMNCj4gaW5kZXggZWYxODEyZGMxNDAyLi4zZTNj
Zjg4YzljODIgMTAwNjQ0DQo+IC0tLSBhL3hlbi9hcmNoL3g4Ni9kb21haW4uYw0KPiArKysg
Yi94ZW4vYXJjaC94ODYvZG9tYWluLmMNCj4gQEAgLTg4MCw2ICs4ODAsMTIgQEAgaW50IGFy
Y2hfZG9tYWluX2NyZWF0ZShzdHJ1Y3QgZG9tYWluICpkLA0KPiAgICAgICByZXR1cm4gcmM7
DQo+ICAgfQ0KPiAgIA0KPiArdW5zaWduZWQgaW50DQo+ICthcmNoX2dldF9kb21haW5fY3B1
cG9vbF9pZChjb25zdCBzdHJ1Y3QgeGVuX2RvbWN0bF9jcmVhdGVkb21haW4gKmNvbmZpZykN
Cj4gK3sNCj4gKyAgICByZXR1cm4gMDsNCj4gK30NCj4gKw0KPiAgIHZvaWQgYXJjaF9kb21h
aW5fZGVzdHJveShzdHJ1Y3QgZG9tYWluICpkKQ0KPiAgIHsNCj4gICAgICAgaWYgKCBpc19o
dm1fZG9tYWluKGQpICkNCj4gZGlmZiAtLWdpdCBhL3hlbi9jb21tb24vZG9tYWluLmMgYi94
ZW4vY29tbW9uL2RvbWFpbi5jDQo+IGluZGV4IDIwNDhlYmFkODZmZi4uZDQyY2E4MjkyMDI1
IDEwMDY0NA0KPiAtLS0gYS94ZW4vY29tbW9uL2RvbWFpbi5jDQo+ICsrKyBiL3hlbi9jb21t
b24vZG9tYWluLmMNCj4gQEAgLTY2NSw2ICs2NjUsOCBAQCBzdHJ1Y3QgZG9tYWluICpkb21h
aW5fY3JlYXRlKGRvbWlkX3QgZG9taWQsDQo+ICAgDQo+ICAgICAgIGlmICggIWlzX2lkbGVf
ZG9tYWluKGQpICkNCj4gICAgICAgew0KPiArICAgICAgICB1bnNpZ25lZCBpbnQgZG9tYWlu
X2NwdXBvb2xfaWQ7DQo+ICsNCj4gICAgICAgICAgIHdhdGNoZG9nX2RvbWFpbl9pbml0KGQp
Ow0KPiAgICAgICAgICAgaW5pdF9zdGF0dXMgfD0gSU5JVF93YXRjaGRvZzsNCj4gICANCj4g
QEAgLTY5OCw3ICs3MDAsOCBAQCBzdHJ1Y3QgZG9tYWluICpkb21haW5fY3JlYXRlKGRvbWlk
X3QgZG9taWQsDQo+ICAgICAgICAgICBpZiAoICFkLT5wYnVmICkNCj4gICAgICAgICAgICAg
ICBnb3RvIGZhaWw7DQo+ICAgDQo+IC0gICAgICAgIGlmICggKGVyciA9IHNjaGVkX2luaXRf
ZG9tYWluKGQsIDApKSAhPSAwICkNCj4gKyAgICAgICAgZG9tYWluX2NwdXBvb2xfaWQgPSBh
cmNoX2dldF9kb21haW5fY3B1cG9vbF9pZChjb25maWcpOw0KPiArICAgICAgICBpZiAoIChl
cnIgPSBzY2hlZF9pbml0X2RvbWFpbihkLCBkb21haW5fY3B1cG9vbF9pZCkpICE9IDAgKQ0K
PiAgICAgICAgICAgICAgIGdvdG8gZmFpbDsNCj4gICANCj4gICAgICAgICAgIGlmICggKGVy
ciA9IGxhdGVfaHdkb21faW5pdChkKSkgIT0gMCApDQo+IGRpZmYgLS1naXQgYS94ZW4vaW5j
bHVkZS9wdWJsaWMvYXJjaC1hcm0uaCBiL3hlbi9pbmNsdWRlL3B1YmxpYy9hcmNoLWFybS5o
DQo+IGluZGV4IDk0YjMxNTExZGRlYS4uMmM1ZDFlYTdmMDFhIDEwMDY0NA0KPiAtLS0gYS94
ZW4vaW5jbHVkZS9wdWJsaWMvYXJjaC1hcm0uaA0KPiArKysgYi94ZW4vaW5jbHVkZS9wdWJs
aWMvYXJjaC1hcm0uaA0KPiBAQCAtMzIxLDYgKzMyMSw4IEBAIHN0cnVjdCB4ZW5fYXJjaF9k
b21haW5jb25maWcgew0KPiAgICAgICB1aW50MTZfdCB0ZWVfdHlwZTsNCj4gICAgICAgLyog
SU4gKi8NCj4gICAgICAgdWludDMyX3QgbnJfc3BpczsNCj4gKyAgICAvKiBJTiAqLw0KPiAr
ICAgIHVuc2lnbmVkIGludCBjcHVwb29sX2lkOw0KDQpBcyBzYWlkIGFib3ZlOiB3aHkgaXMg
dGhpcyBhcmNoIHNwZWNpZmljPyBNb3ZpbmcgaXQgdG8gdGhlIGNvbW1vbiBwYXJ0DQp3b3Vs
ZCBlbmFibGUgbGlieGwgdG8gZ2V0IHJpZCBvZiBoYXZpbmcgdG8gY2FsbCB4Y19jcHVwb29s
X21vdmVkb21haW4oKQ0KaW4gbGlieGxfX2RvbWFpbl9tYWtlKCkuDQoNCg0KSnVlcmdlbg0K

--------------D659Q4h09ZboVdOfQisu0DX1
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------D659Q4h09ZboVdOfQisu0DX1--

--------------wsR7P9fTHrsPlrF6ZT9c6yQj--

--------------sXbYd4uAD0j500VcPyIWXPS3
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmILhvcFAwAAAAAACgkQsN6d1ii/Ey/s
6Af/XTtRR6pij8LgrJYf/C5KpzaslYH2tRbmKhyafs9P4tkESFkVZd2hM1AW4UpJpjku1VjBrG2L
QCLx7K/NgTtjtobkrmHSmgjebE4Mv+N7j7KRRAcPfjMbt6raAN3tnkeJMM9TV1FR2NLNn7G5cxkE
SDIT2Gk+AOPpLhYuVwRBVxLdO6mClnxB5dQwIsLMpNEsahQMJL5HKsUxYhe0R6KISzpi8wwUNcvS
HXZ66ROBA0X7vYSoE1+CjTrACqqpRm0A0wCUCnObNqz/1297H/BePN1/gaHungpEBuUPZN5UeFz1
/sz1js9C2yW+EKRPKgI31nJXu6ywf+RNO28NcS9zXw==
=TFoi
-----END PGP SIGNATURE-----

--------------sXbYd4uAD0j500VcPyIWXPS3--


From xen-devel-bounces@lists.xenproject.org Tue Feb 15 10:57:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 10:57:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273027.468068 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJvWW-0006Mi-6F; Tue, 15 Feb 2022 10:57:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273027.468068; Tue, 15 Feb 2022 10:57:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJvWW-0006MZ-3A; Tue, 15 Feb 2022 10:57:32 +0000
Received: by outflank-mailman (input) for mailman id 273027;
 Tue, 15 Feb 2022 10:57:30 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=xOiq=S6=epam.com=prvs=4045782cdb=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nJvWU-0005ps-E2
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 10:57:30 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 105add5b-8e4e-11ec-8eb8-a37418f5ba1a;
 Tue, 15 Feb 2022 11:57:29 +0100 (CET)
Received: from pps.filterd (m0174676.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 21FAk7ku031453;
 Tue, 15 Feb 2022 10:57:24 GMT
Received: from eur04-he1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2056.outbound.protection.outlook.com [104.47.13.56])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e89njg8yw-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Tue, 15 Feb 2022 10:57:23 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM6PR03MB3736.eurprd03.prod.outlook.com (2603:10a6:209:2d::33)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.15; Tue, 15 Feb
 2022 10:57:18 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::fc4d:4749:5d1:eb73]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::fc4d:4749:5d1:eb73%4]) with mapi id 15.20.4975.019; Tue, 15 Feb 2022
 10:57:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 105add5b-8e4e-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=a8FBanfp5qEurTvx3l3qX/3WTsVDKAHl60YTTT9ZiX6wjFYQ+iJSSlr8Ndmv0W5q6hJ7gxX03rCkX+ZF8OlDhIcUddDL1w2VdaUHCLmY5nzEMsDMyGJNj5VG1YBYLjm3gsuhq6facJaqmxQfFngsTOat46Ub27jSKhc2gwfc+bSaVeQoqU60CDWBydPGo3eNw9YnU+5caxTPaHPxRAXDoOOk+jtxwta1Fq0AM7F27iLZWQEbxbmagjN4lDYLwtB+SIjtFO2PYjegoLDV/xkLO4mW5W04nvllPYeimyBmpitjdz8fl1/IZaTyvTVtm4XBUi7Gc6ZWIZfxfkuR+Gi7jg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=cFK5m9+VxwITfMlXzjygmB9ipTvuiWJCSP5a1hzhxvM=;
 b=D0wYGoYrx5T/3e3QNrAyLDflcUQ0RbhY0FfKZsS6govbQWqITYfQ2HNSWpyakygNWNEOZp9TtZGT7sZEf4fID4RfOvtMueGbnSm0wErlzLLY7Ffsa8ByXKW15Ap+8jRt8MY2COKhJ1WpfTzgO2vthCXEzzz/hc9zSrQZG/nSxgJ+ulhH8j7JY0KhiMRarUEHNcbfaiT68GaFJUvui2wN2Q9SxJI+mXnZQVog12P1BkgnMJbbYoKaMogvjj2Q/m8W8IQke3ZEWZLzaS1bE0+p4+8Mw9ZekUJlfWyQvtMGbmvX4ktP1fQZ+Ozz40n9G/zZDh56GjHZroZprokjVsc3nw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=cFK5m9+VxwITfMlXzjygmB9ipTvuiWJCSP5a1hzhxvM=;
 b=QkKgO2ZnOwIHZkCmpYXt9horrLuSNvazQ4d+gxzSv1WfI84/26jRXsuHqKjpKQeQhQlfM0ONMY6taJQCR+I0xAJ5pIK5OlWmGCvkPtV169vvJjFKtbd4+omcW/WFsbHhNUS1o0NcGIcCSZ327/QFBmhAioI7cStdVnzxCmJRbxxYRl2OW5H7ifA5EuSOizjKtxUXKiRbjFDD8S1Y2wOExP1s17/YdaHKSILLoNPFq2kDb7VtwE1D6cVE4Hct6aCoLXeJL5UyURhMS2tMhrJBzzJ6LCzChmqTgMnrHiX3lTR4enVkC6vorVidi+o0AIHhKNmojr1k7XqZ3DVN0YICXA==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "jbeulich@suse.com" <jbeulich@suse.com>,
        "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org" <sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v2] vpci: introduce per-domain lock to protect vpci
 structure
Thread-Topic: [PATCH v2] vpci: introduce per-domain lock to protect vpci
 structure
Thread-Index: AQHYIkOs9pmsZb0l5kefj1m3qdTVCayUboeAgAACiYA=
Date: Tue, 15 Feb 2022 10:57:18 +0000
Message-ID: <516c4fef-2a3f-7358-8997-5dfdc11292ea@epam.com>
References: <20220215081135.1497470-1-andr2000@gmail.com>
 <YguE7RWOteSnvVNY@Air-de-Roger>
In-Reply-To: <YguE7RWOteSnvVNY@Air-de-Roger>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 23e9e70a-ee8b-4050-1166-08d9f071ef0f
x-ms-traffictypediagnostic: AM6PR03MB3736:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM6PR03MB37363BB1461322882DFF8CC1E7349@AM6PR03MB3736.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8882;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 839innFHo/71q8UukC5VR4Rct03Re/0LmQSlJFmG1AOWY4OfAmlfSoK23bOz0Tu2v5ospgwArBt5Wkb4sD+KXGkPH5tfSrSVLNwWBQaow9feSxboUZ05PvBvgO+ea3ojfTkcoQ0F+hu/0VcJkA8F0UOpwFTJ1+psTjvRiPYHbyxx4+DiSuuVK4QKudNUVDSlp25agVirKwnVqzSH076mmsilv+Q8lReDRL9PH1Er0u6xs8LAG5utkMXeK3pP4TZeWpnFzur33gheonnA5eYenQvcqqVatIRsS5HDascFURSSanKVjI4oJ/o4N+jLya9H1Nb20mKzoCz35JmHBnC0YpPLFcRgw6sDE5M2AqfHg98aQ1CkEaxk/nO3ZgbyF5QAMISzhc21liwlLRfkp+5QLFSb6p0ZxH0Zr8iN/u94Iq3V6jtJ+dJ4JmHWmLW77Jx2HsbfUcjuV9//2EiJm7jdcvhDwANKiQjViOiF6yzqYDeTy64kJnqL4Uuo9iw9tXT+Wos0AOzGXgJfR5CQg/2NSVUpBgnNirxINQIfS1X1ov9DGLADmmJ8uiKfrzFxWycv7jb7HZ6NxuIs7YQVOZgmamCWaTa0bbW/evz+44lCX8igW2p6Td8EfyZRUdkghjb1X/VAoLH8gweJF4H1oci9idHxQLjIFKRmo6M/AhAsCTC9btW7W6dzyOnjK1LDuYLOyDh9UXMUKcA6UOsYh9wyazjo8yP8if5CrtlGRC+IZHW51M6YnS2H/jcdvi7+nvnp
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(186003)(71200400001)(55236004)(53546011)(508600001)(6486002)(6512007)(54906003)(6506007)(38100700002)(26005)(316002)(122000001)(6916009)(2616005)(38070700005)(4326008)(66946007)(107886003)(83380400001)(86362001)(31686004)(66446008)(5660300002)(66556008)(8936002)(31696002)(36756003)(76116006)(8676002)(2906002)(64756008)(91956017)(66476007)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?bDZuVENDK3BsOVloQkNQWGxSZTN4U1dadHo2eVU0TGVjSHR4MWJlWGd6eFli?=
 =?utf-8?B?RjJVVTVSd2FWdkpMeUdEVzAzSlZRRDJNRENJNUdwY3MxT2tjMDc5NktVblFQ?=
 =?utf-8?B?blNJbEJXYXVEVjVaYm9MdG1obEIwSXh4eXc2b0ZTekpIRzBaRnlkMEcxcUx2?=
 =?utf-8?B?dnNxbEt4bFJzMUFTUmRmNEwvWFlBYjU5ZHk3Vit1ZFdqMGJwUCt4VlovQ3dG?=
 =?utf-8?B?bk5rM0xmY2NLOUFTSGV1a1ZzeXpFYzMrMzgvMUxHUHN1aU1ReUdYNVBuNC81?=
 =?utf-8?B?STJwOTZWc3lGNjVQeUU0R0JRaTU3STUweDlUOGlrcmN5cHovREFBNlkrVFo5?=
 =?utf-8?B?YXpCajBiTStrVllscjlMODEwNmlOekxNUnJlaWpMWkVoMVlHcmthNnJobVp5?=
 =?utf-8?B?M3FFYzdVd2JjMm5xUXJZV09RNWNLMmhYc21kNFF5VGtjMXRMeThaTTcxdktl?=
 =?utf-8?B?STI3cHdBR1Y3V05Xbk1mTFZyTTMzNEpvTUhxOGQvK3lPWERvdzJuV1J4dU9Q?=
 =?utf-8?B?ckd4ZUNTRjlWd0Jsb200Ky8yckIxbW9wNmUvdlkxYUtyR3NBZXhkdkNtSUV5?=
 =?utf-8?B?V1dwTVNYUDQrT2lncjd6NlJZVS9nT2ZmQmF4REMxOU1WcWJQUDlNa2tPbmdB?=
 =?utf-8?B?Vnp1NWQybXNyZUFDWHlQU0dRWFJpTGZhM1Bjak5JTnE0WDJ2OXFWR20raW1w?=
 =?utf-8?B?TFZodDBuZUtjSWFOaUJCUDRUY3l5M21uZkdhRTZNZmZzK3FwbzBaWVhzZmpH?=
 =?utf-8?B?Mm5sWUEwYU1KNm0vcFZIUVpLc1JOTC9nRnlTamc3Qm9iZVR1V0hSalNJbEs3?=
 =?utf-8?B?dURkSmZEUGsxdTU2NG91TWJCVlQzVXVncktWRThFRkg4cFRUK2V0d0hYWmRU?=
 =?utf-8?B?NHYxRnJRellDa0pjU2hBTjVoOXdNME8vSGFtR3pBdVk1eGtWWEZUaE4xUW5t?=
 =?utf-8?B?bGZudmxHZEhYaHM2amEyMDZ2eHRmSW8rd0lsV0d1a3VITUpveXNrUUo5dmpJ?=
 =?utf-8?B?bXlYTmNOV1JRdHNlaTRQd1lWZE50dDdBc3hXdkNWcGRycmRMMVdtdENrYlFR?=
 =?utf-8?B?TDY5bnNkU3FYenFBTTFJakhHM2JWR29KWGNaWkZEbU4rdkFMVGJHSG5MV2R1?=
 =?utf-8?B?UkVvVWpnazcwc0hJU3NXQklOaTB1NCtJQnVuS3VleU9tYkxrZk00ZGVFTlRV?=
 =?utf-8?B?d0MxK1U3Z0h6S0ZxSFErRlVjWGEvejBjQUNIWEZpT3Z0dDZXWnZBRS9YTkJ3?=
 =?utf-8?B?R3RSa0xpYTBqbUxIejd3QVV1bHBQWTJMcjcyWXNwVy9TaEplSzZQdENFekJ2?=
 =?utf-8?B?cFlhK1lYTzVZdStKU01xREZSNEdKV0VvTXBGc0tWbVIvZVRIUmxVU0dwM0hV?=
 =?utf-8?B?SFdlbEFNVHoyeS9EaTFUbzVGWEZaZDBybCtTWjJrZjRxREwvYUdmVU1hMlhO?=
 =?utf-8?B?S3F1cERicnF2cTAxRFpVa2RvUEZyQmRXRzJ2eVh0U0xOSXFSOVhUcjdjY3Ur?=
 =?utf-8?B?K0hQbG5RRWpLOGVrWmNKYTU4MnJYRVU2ZXE5dVpjeWRLeUwxVS9mSWIrZnVs?=
 =?utf-8?B?eUFJbE56Y1dHMFpqZEw0SCt5aEhMU2FXUHEvZndZbHNtOHVrRWRQWEl0YnZs?=
 =?utf-8?B?RzF2RlkrVlI4aEZDTXZxL25hUVZjQmFuK1FIYjRNWWZVNmdCc0dTQkNjSGRq?=
 =?utf-8?B?MEhQVlNySDg4WjFBeVFCcU1ad2pMbUVOTUxqNVJDVkw0dnh3S0I1VDJUckhU?=
 =?utf-8?B?NE5tRHVyM05PYktPQlVmb0tQMnV1VHdvN0FPandmSnhIY3NreVlHRWFlRFhp?=
 =?utf-8?B?M0h2dllLMXZVVnhqcG1TVXRNMTZLNkpIMTgyOUpXSnd2amhmOTJxZEpqTFN2?=
 =?utf-8?B?S3UrRGMrZVhvOWZLT3NXZ3dzS3luazV1aTJNRW9TblJyTXJtUHdNVTZjVmox?=
 =?utf-8?B?cXZHcUY3SFR5WTRwdjA2WWVZdWR5dXBkclRoTnpaa1ZENXAvN0R6QzFVMGVT?=
 =?utf-8?B?NWkycklaN0NENnVCN2YxOTkzWGNjTkRNOXY4NHpPVkh6UHdReWkyUmMrekZJ?=
 =?utf-8?B?cHA2aWtUMkFwWEJHUjR0d3NUS0ZGL016K1cvWlR4MHZkNlJBWWUrSlhJVmNl?=
 =?utf-8?B?TGVJbVIvaWNoWFdodlNoYmZFR2czUUNoTGR3ZTVqZ081TFBFbjB4S0laMDNO?=
 =?utf-8?B?UWp5UUp6OS85aDVMVVBxVE9TTk1kMTBlbU5jSC9RZ2JyLzIrY2owcGxFc0Za?=
 =?utf-8?B?QnpQU0hPZ2RFT3hRSTNhSk9kWWxZZ3pLbEFibTVEVG1hSjMvaGZZU0pBN0Na?=
 =?utf-8?B?SDBGTStDM3dFM0FvZHBFUEp6ZHRYQUlZVHlhcEcrYVVGc1FzTWtFUT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <FB1EF6B1EC2F4E4E98FD62AE0D2F537B@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 23e9e70a-ee8b-4050-1166-08d9f071ef0f
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Feb 2022 10:57:18.1255
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: SQc2LUuT1Q68KKTElzm679tLXqRglqYqe9uhNZK6MwckzMpmb4Lj4o0qrzsdLgbNejXtrvxffw48z9EDysWVIcqtKLCkrhKzwDaUlD6Ho73yC/35w024ENx0+axHfiSP
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR03MB3736
X-Proofpoint-ORIG-GUID: u7wZc7gwzmuPEV-1393EeQieJmBeKuye
X-Proofpoint-GUID: u7wZc7gwzmuPEV-1393EeQieJmBeKuye
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-15_04,2022-02-14_04,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501
 malwarescore=0 spamscore=0 impostorscore=0 phishscore=0 adultscore=0
 suspectscore=0 mlxscore=0 mlxlogscore=923 clxscore=1015 bulkscore=0
 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202150062

DQoNCk9uIDE1LjAyLjIyIDEyOjQ4LCBSb2dlciBQYXUgTW9ubsOpIHdyb3RlOg0KPiBPbiBUdWUs
IEZlYiAxNSwgMjAyMiBhdCAxMDoxMTozNUFNICswMjAwLCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5r
byB3cm90ZToNCj4gQEAgLTkxMSw3ICs5MTQsMTEgQEAgaW50IHZwY2lfbXNpeF9hcmNoX3ByaW50
KGNvbnN0IHN0cnVjdCB2cGNpX21zaXggKm1zaXgpDQo+PiAgICAgICAgICAgICAgIHN0cnVjdCBw
Y2lfZGV2ICpwZGV2ID0gbXNpeC0+cGRldjsNCj4+ICAgDQo+PiAgICAgICAgICAgICAgIHNwaW5f
dW5sb2NrKCZtc2l4LT5wZGV2LT52cGNpLT5sb2NrKTsNCj4+ICsgICAgICAgICAgICBwY2lkZXZz
X3VubG9jaygpOw0KPj4gKyAgICAgICAgICAgIHJlYWRfdW5sb2NrKCZwZGV2LT5kb21haW4tPnZw
Y2lfcndsb2NrKTsNCj4+ICAgICAgICAgICAgICAgcHJvY2Vzc19wZW5kaW5nX3NvZnRpcnFzKCk7
DQo+PiArICAgICAgICAgICAgcmVhZF9sb2NrKCZwZGV2LT5kb21haW4tPnZwY2lfcndsb2NrKTsN
Cj4+ICsgICAgICAgICAgICBwY2lkZXZzX2xvY2soKTsNCj4gVGhpcyBpcyBhZ2FpbiBhbiBBQkJB
IHNpdHVhdGlvbjogdnBjaV9hZGRfaGFuZGxlcnMgd2lsbCBnZXQgY2FsbGVkDQo+IHdpdGggcGNp
X2RldnMgbG9ja2VkLCBhbmQgaXQgd2lsbCB0cnkgdG8gYWNxdWlyZSB0aGUgcGVyLWRvbWFpbiB2
cGNpDQo+IGxvY2sgKHNvIHBjaWRldnMgLT4gdnBjaV9yd2xvY2spIHdoaWxlIGhlcmUgYW5kIGlu
IG90aGVyIHBsYWNlcyBpbiB0aGUNCj4gcGF0Y2ggdG8geW91IGhhdmUgaW52ZXJzZSBsb2NraW5n
IG9yZGVyICh2cGNpX3J3bG9jayAtPiBwY2lkZXZzKS4NCkluZGVlZCwgSSBuZWVkIHRvIGFsd2F5
cyBsb2NrIGluIHRoaXMgb3JkZXI6IHBjaWRldnMgLT4gdnBjaV9yd2xvY2sNCnRvIHByZXZlbnQg
QUJCQSwgZ29vZCBjYXRjaA0KPg0KPj4gICAgICAgICAgICAgICAvKiBOQjogd2UgYXNzdW1lIHRo
YXQgcGRldiBjYW5ub3QgZ28gYXdheSBmb3IgYW4gYWxpdmUgZG9tYWluLiAqLw0KPj4gICAgICAg
ICAgICAgICBpZiAoICFwZGV2LT52cGNpIHx8ICFzcGluX3RyeWxvY2soJnBkZXYtPnZwY2ktPmxv
Y2spICkNCj4+ICAgICAgICAgICAgICAgICAgIHJldHVybiAtRUJVU1k7DQo+PiBAQCAtMzIzLDEw
ICszMzQsMTggQEAgdWludDMyX3QgdnBjaV9yZWFkKHBjaV9zYmRmX3Qgc2JkZiwgdW5zaWduZWQg
aW50IHJlZywgdW5zaWduZWQgaW50IHNpemUpDQo+PiAgICAgICB9DQo+PiAgIA0KPj4gICAgICAg
LyogRmluZCB0aGUgUENJIGRldiBtYXRjaGluZyB0aGUgYWRkcmVzcy4gKi8NCj4+ICsgICAgcGNp
ZGV2c19sb2NrKCk7DQo+PiAgICAgICBwZGV2ID0gcGNpX2dldF9wZGV2X2J5X2RvbWFpbihkLCBz
YmRmLnNlZywgc2JkZi5idXMsIHNiZGYuZGV2Zm4pOw0KPj4gKyAgICBwY2lkZXZzX3VubG9jaygp
Ow0KPj4gICAgICAgaWYgKCAhcGRldiApDQo+PiAgICAgICAgICAgcmV0dXJuIHZwY2lfcmVhZF9o
dyhzYmRmLCByZWcsIHNpemUpOw0KPiBUaGVyZSdzIGEgd2luZG93IGhlcmUgKGJldHdlZW4gZHJv
cHBpbmcgdGhlIHBjaWRldnMgbG9jayBhbmQgYWNxdWlyaW5nDQo+IHRoZSB2cGNpX3J3bG9jayB3
aGVyZSBlaXRoZXIgdGhlIHBkZXYgb3IgcGRldi0+dnBjaSBjb3VsZCBiZSByZW1vdmVkDQo+IG9y
IHJlY3JlYXRlZC4NClllcywgSSBrbm93IHRoYXQuIEJ1dCB0aGlzIGlzIHRoZSBiZXN0IEkgY2Ft
ZSB1cCB3aXRoLi4uDQo+DQo+IFRoYW5rcywgUm9nZXIuDQpUaGFuayB5b3UsDQpPbGVrc2FuZHI=


From xen-devel-bounces@lists.xenproject.org Tue Feb 15 11:12:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 11:12:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273037.468078 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJvl7-0000Mm-H2; Tue, 15 Feb 2022 11:12:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273037.468078; Tue, 15 Feb 2022 11:12:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJvl7-0000Mf-Do; Tue, 15 Feb 2022 11:12:37 +0000
Received: by outflank-mailman (input) for mailman id 273037;
 Tue, 15 Feb 2022 11:12:35 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=xOiq=S6=epam.com=prvs=4045782cdb=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nJvl5-0000M4-L6
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 11:12:35 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2c4550cd-8e50-11ec-8eb8-a37418f5ba1a;
 Tue, 15 Feb 2022 12:12:34 +0100 (CET)
Received: from pps.filterd (m0174683.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 21FBCNsr021300;
 Tue, 15 Feb 2022 11:12:29 GMT
Received: from eur02-am5-obe.outbound.protection.outlook.com
 (mail-am5eur02lp2050.outbound.protection.outlook.com [104.47.4.50])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3e89uc08fm-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Tue, 15 Feb 2022 11:12:29 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM6PR03MB3861.eurprd03.prod.outlook.com (2603:10a6:20b:22::24)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.15; Tue, 15 Feb
 2022 11:12:24 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::fc4d:4749:5d1:eb73]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::fc4d:4749:5d1:eb73%4]) with mapi id 15.20.4975.019; Tue, 15 Feb 2022
 11:12:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2c4550cd-8e50-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gIW29/VRX27Xk2HT6xmg6/DxQrdxKZI4TMX3z2YxmN3NTJRsrCi1+BRw7WfTvlc11oOUIMxBh0KxbrfHAy2q7PZ1zmbvS4zAu6kLJA29Cvk7NzWRSQulnFyfqjwxoEDDRkd0miHdOQwlBsRastRnjj+tcmornH/vBhAr4P2x0pFxp5DlVltFdFNsCgBbzBggpa12P6xk4satgPsdWdqN3De36/jagDzd3H+oo6ULGEPaC1m2E2dR90qhe66e/VMoDVHfUTugM69HhGNbtgurOM1d+BhL7n6zAyw0icIX+z1f3HCXWgYYMQfT2sSEh4xx8Rci0W5ZZnpcXzXi6r5MQg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=71C3rfhDqF1ZAbUsu6sLgnzo8FjBJBXJh2rFodq2QT8=;
 b=cSjU3mdMxAjRdGgAyQKcxjCWda0xnAKrZ8x+AT8MDKGs+4vgyJLCgnlqwmhkAiM9WKXMHe0XTUxM5EcIX8wAswHccnfToC2Dm3wFKoKBSHUPHuLT1EdClJMjerkJkdbA5kkPqBGVZ4GZh06ve+2m6/G8bOgqG2+QrNaYq//2IMAh0eGgi35IeuK7tgU7wzLEo7DizZsmQhi9zODuJnMDZM/8JXW0SrBKsIYTST752RCwlsoxPtlPIzuNaR3x1adzuUnWSOvzk6OGu6xh6gfa8fqfPwuuemaw4gbEJt+6LAUycrqMO1LZhSVmREFCw4NeFOlRvpjPhHkIPNYKwiPgsQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=71C3rfhDqF1ZAbUsu6sLgnzo8FjBJBXJh2rFodq2QT8=;
 b=DsA2AlruqSVWKNQ8CPTsIwBPwiEm93dSPNJS0zNjqypD/xpX173+3NWYQyT+yy7sCIAEnfvlm2s2C/HMF1KknDR1eP54y1Wdm2O5NNdTR4u5/EFJJ3oyJo5RIj5NxlL3rUgpAtmqjG8RCS5LOM2zpZozHn3K2mO+B3IcSPPmKLPLrIO4yP7HrR21RonJTW+4Ri7ApeqjFIXu95UL70pUwGFs9k5pFNoRi9U2ESBVekA17IOBcZfasRNgsLkz2KiHUXXDw0Lg6vrlgWGiADcAAB4EuxLCA0LCF+ZP1S4iFkDUgjjws7sWflfHpNcfHFfkgMNZzlOm64/0T+5OOmnv4g==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "jbeulich@suse.com" <jbeulich@suse.com>,
        "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org" <sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v2] vpci: introduce per-domain lock to protect vpci
 structure
Thread-Topic: [PATCH v2] vpci: introduce per-domain lock to protect vpci
 structure
Thread-Index: AQHYIkOs9pmsZb0l5kefj1m3qdTVCayUboeAgAAGwYA=
Date: Tue, 15 Feb 2022 11:12:23 +0000
Message-ID: <c5b9b02c-93f8-d018-6048-9abf2e7de4dc@epam.com>
References: <20220215081135.1497470-1-andr2000@gmail.com>
 <YguE7RWOteSnvVNY@Air-de-Roger>
In-Reply-To: <YguE7RWOteSnvVNY@Air-de-Roger>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 3a4744e6-1d72-4fb0-0bfd-08d9f0740ae0
x-ms-traffictypediagnostic: AM6PR03MB3861:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM6PR03MB3861F82097A171E1909EB458E7349@AM6PR03MB3861.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 ok6hWzkF3cpD69NETX06XIaT6P1YkpwxH/++WMH8HNJHfBGtuY5ClNKPT6OwUo4Lbqw276tPk2+UsxbC9RpHXlXroacAapInepyOsC2EHQiML54XA9jmsYMJrg189XkDaTmDTgmFm3Apl1XPVECDUIydQhEa7QXUQHtCeVfM6GwDT5s4vauH76NoJZclwuXtx+PHvPlEKwiRFjngaVxvJu1IostosLiZQAI69fJgL1wBwCisMkMfnmGodb73UXN4jsJN8NuhSI8zuc5BhRGW0StLNa7EXaiIsEDDIkM9i5KqmypWirQLlpCoP4N1Ikj9qeAJOnr0KY42GIPEI50jSpHpQ7y/zSWbRh+FQZIjsOeliG/IlkunhL5TXAKovv8SUNDtD5iXj0WIxandJLb3+kkPzdDv48YKSBjgA1cYjWmVLbcwWV0+3JnG4UkvJyKQDVnpCfo0PKab55F8mUQLLibrW1/mkNqOpePZm3i8PrHOQ9wEco5ZCFTFMbu8VCRP3AWKI5fntNzSmzu6Dcl6dKrvUPl8fv6C5VOHU9/k1QStJHJ7kLCh1olsN8dGqYaoZhzAWbsbGTRAUEvM68UqLmwRl9Fh4l/XXz4NWXQ8XKN64j+03ze0pavQGi0sU1QJ3y6THERACkWMSnkXx2OQblc4Z6U0XAZqWvfW/J1YmjdfukZUvW8m2aG2e6BiEZCwbNI0y2tJJWGqseeZxA1ZcF8tTj1ei+Bt2DvBNt+8zHiZBKtB7kwF+9MIeJQS9oOC
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(5660300002)(76116006)(122000001)(83380400001)(38070700005)(316002)(38100700002)(4326008)(64756008)(66446008)(91956017)(66476007)(66556008)(2906002)(8676002)(66946007)(8936002)(71200400001)(86362001)(55236004)(508600001)(31686004)(31696002)(36756003)(107886003)(6486002)(26005)(186003)(6512007)(2616005)(6506007)(53546011)(54906003)(6916009)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?VTZ4QjJ0M2hMVzBTQXMzbE1zWUd4QVZmZ2lPWmoxcm1SRzc0ZXdHaXFLRzRJ?=
 =?utf-8?B?U2cxMTlyL0I0OTR5VXRrNmU5YndlTjdXR0hhcmI5LzRieUFwQytrZ0IvbkFR?=
 =?utf-8?B?T1MxYlRMQzVvS3JUdE51SEV1K3BVUHZ6SUplSXpLV3Y0N0duZHJYV2RYY3Z2?=
 =?utf-8?B?bW1IcmVZd2c3dVJzR2QrUDR1K2ZpVitaei9HaUUrNEUzMTVvTXlDdU5abjVt?=
 =?utf-8?B?bnNUNUtoeS9Pb3MxazNDWklDOElicHU0aXVnNmpWSTRJNUlSUjNsenNEcGNZ?=
 =?utf-8?B?TmNkY1pMNjNyRlpjMjZkVW9Eb2gvQ0FwTk90UHRrM3RpbVdZSGl6OHc2aGUr?=
 =?utf-8?B?YUZTU0FiT09sRmhLdjZ5K0kwa1NESDdEY0xsQ2tNbXdyKzMwWnFJVko2QnVq?=
 =?utf-8?B?RmRFdXdHbVBMeTlvNUFvVHFsLzZlRmI0RXRuY0s4ZzNjSGRoTCtMalZza2RU?=
 =?utf-8?B?c2o2K3puZk5OSVFKRUd4U1UvQXJTUmdQb2kzT21NWmlKR25HTVNWNHpxeGdY?=
 =?utf-8?B?a2w1U2ZEckJreFNoc0RzS2taaXpjMWgxb2ZrTlNuQWRyaUdmU2pQYS9vOXVH?=
 =?utf-8?B?VjV3am1vY2RFMXk1eVNmUmR2cEtJQUZoTFpPVFpOZ3VSZ3NkRFM5L1pQWEp5?=
 =?utf-8?B?ME0rMkxvWUMrKzg3TDg0bVRuSldxQlI2cDh3Y2w2R3VWMHpRZzJzNUhJQmk2?=
 =?utf-8?B?RGZBTWR3L09mT2Y2R1JCTTRwb01pVURCQnQybmlKcExhaGdVUFg3SmVRQWdI?=
 =?utf-8?B?TVpXOGpwT1BCb2lZZG5BakFYWExyUDJTWGl6NHVYOC9YWExMVzEybVRsTm5v?=
 =?utf-8?B?Q05XZ3FhcmM2VUtkVmNRMWZ0ZUpaT2p3dFAySy9XTFJtMzlOeGlydG5nSEtr?=
 =?utf-8?B?U0hBY3NqNkYvaXdzM3BDUzRlN3BSekZlZmhpcTJUUFllZmJZVGEvdm84SDlL?=
 =?utf-8?B?SDhKSW9kcERvU0dSa1ZybUxpUEgwWFdnZUhYbUVyMDluRTN2ckZtd2J0OUtn?=
 =?utf-8?B?akNKSWpteHZ3aWlqWGtqSWJScDlheFpOcUlyZVE1cnM3c09Icm5Db2FBZkJz?=
 =?utf-8?B?Mi9OckZvMHFRekpac2VxKzA0QXk1WWliTjFSekpRRUpVOXdIcDZ5RzE5NnZP?=
 =?utf-8?B?a1JkczJ4cXh2S3JJcitJNUs2cWVhN3FLSHZpVlk1c0RCekRBUEFNWURtbnZn?=
 =?utf-8?B?bUpPTDZEQkdTZFJHa24yc2NBV0RoSnZ4L1ZubWxubEc5YVg2TFFlN0NXWUVw?=
 =?utf-8?B?bk9mUXZaYWw0S2h4ZDlwS3hKMk9zV2syVXFMcVNvSm1TL0laVS9iVEpTdTRy?=
 =?utf-8?B?cWRCbkNJNWlucm4veDJNVzZHZkJ2aUZVRnVidDJzbGJMSlBBVkxHNjBrT2pv?=
 =?utf-8?B?dXVucVdxMm92N3p2M2p2VVBucmV6M21DVHFLYXFmWWdmZ2xBdDgxWXhSbWNu?=
 =?utf-8?B?S0tZQi90Zm82NzY5Ti9CbjU5WS9PNEF6Y2pnYldTek5ybTVrWTc4bjlZRUVa?=
 =?utf-8?B?Q2crdTc2YTYzaHU2K1kvd3dudGFJWlpuREhrWUw3d2pBeGJlUzJSVS9TRld6?=
 =?utf-8?B?UUkwRTFRbTJRUmUvSENGRFpZck40Sk1OTmlPa1lvY2hnSVJOOHZXVW9oSHJ1?=
 =?utf-8?B?aHBFQWpDMmdmMy9vSjZaeVBxYzdieWdkNHZhaEg0b2U2cWxWM3JWcmZFV081?=
 =?utf-8?B?UW01TzVidy9CNEFtNVowRWQ3NDFtT01xd2pTUlJHaTB6SjA5WWJ5MW91SnlU?=
 =?utf-8?B?WXl0aUl0b0hpM1lHMFZpemNTVEFqNWJHaEh3U0trbXRHRmo5eHZrSXFKVGlh?=
 =?utf-8?B?aHREdUp4cTJrRlpWZ0R1MEtMZjhRZkNyT05na1ZGL0Y2UTJ0NTFiL2VseHhU?=
 =?utf-8?B?TDdOUmoxS1lEbjZLREZNTDNRVzNnUnN5YVdqenFtVFp0NUhiVndHdWRVTm0x?=
 =?utf-8?B?aFBBMlk2YTBDR2FCWW9ZcERZYm1kWGhxOEUvV0ZsT0swWkxyQ1g0NXg0blVZ?=
 =?utf-8?B?WTJqazc1clo2eWdPVmFGVHRObFI3NDVINHNjVkRKZjJnc2hEeW01c2VOK1Rs?=
 =?utf-8?B?dUcvRkFSVEZDY2FzbUU2ZXRiZnI4My94cUZySzJJY3BpSGFSbllUby9zY0x5?=
 =?utf-8?B?aUo3WEdESnBDcWhsN0hCc291Y3g3bm50QllSS01pbExXUWd3aXU4bWhsaDcy?=
 =?utf-8?B?S3poR0Z2N08valFRRHpzRG01NXoyZ3dRa0dQVjJtYjBVMkFvSlhuUTU2WWhl?=
 =?utf-8?B?VFlJRzRzTGI4MjZxWG54R09oUGRXeUZBMkIyek5qUlFRcDF2US9BTlRNMm9C?=
 =?utf-8?B?Y1BINXR6NWswd0ROYUsvRlE1eEhQWkplZmRRaDg0R25lTXl3Y013dz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <25AE91D5EF35A847ACD3C37EA3537A3F@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3a4744e6-1d72-4fb0-0bfd-08d9f0740ae0
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Feb 2022 11:12:23.7870
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: gUqw+fDD3QKVm6GY08mQY+lFVa1hSrMza8CuT3Cbzb5HKV17hp+N64Q9vj9WGy82PK1slzrdiCeMwAwJUn+Bx9hSkr7izY8lz4lkKRhF+DleAgnkzpfns8sTdYs1O4X/
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR03MB3861
X-Proofpoint-GUID: q0jWNBErK4rS5YRkxsvlD5MKs1WRuApz
X-Proofpoint-ORIG-GUID: q0jWNBErK4rS5YRkxsvlD5MKs1WRuApz
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-15_04,2022-02-14_04,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0
 impostorscore=0 bulkscore=0 clxscore=1015 priorityscore=1501 adultscore=0
 phishscore=0 malwarescore=0 mlxlogscore=999 lowpriorityscore=0 mlxscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202150063

DQoNCk9uIDE1LjAyLjIyIDEyOjQ4LCBSb2dlciBQYXUgTW9ubsOpIHdyb3RlOg0KPiBPbiBUdWUs
IEZlYiAxNSwgMjAyMiBhdCAxMDoxMTozNUFNICswMjAwLCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5r
byB3cm90ZToNCj4+IEZyb206IE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIDxvbGVrc2FuZHJfYW5k
cnVzaGNoZW5rb0BlcGFtLmNvbT4NCj4+DQo+PiBJbnRyb2R1Y2UgYSBwZXItZG9tYWluIHJlYWQv
d3JpdGUgbG9jayB0byBjaGVjayB3aGV0aGVyIHZwY2kgaXMgcHJlc2VudCwNCj4+IHNvIHdlIGFy
ZSBzdXJlIHRoZXJlIGFyZSBubyBhY2Nlc3NlcyB0byB0aGUgY29udGVudHMgb2YgdGhlIHZwY2kg
c3RydWN0DQo+PiBpZiBub3QuIFRoaXMgbG9jayBjYW4gYmUgdXNlZCAoYW5kIGluIGEgZmV3IGNh
c2VzIGlzIHVzZWQgcmlnaHQgYXdheSkNCj4+IHNvIHRoYXQgdnBjaSByZW1vdmFsIGNhbiBiZSBw
ZXJmb3JtZWQgd2hpbGUgaG9sZGluZyB0aGUgbG9jayBpbiB3cml0ZQ0KPj4gbW9kZS4gUHJldmlv
dXNseSBzdWNoIHJlbW92YWwgY291bGQgcmFjZSB3aXRoIHZwY2lfcmVhZCBmb3IgZXhhbXBsZS4N
Cj4+DQo+PiAxLiBQZXItZG9tYWluJ3MgdnBjaV9yd2xvY2sgaXMgdXNlZCB0byBwcm90ZWN0IHBk
ZXYtPnZwY2kgc3RydWN0dXJlDQo+PiBmcm9tIGJlaW5nIHJlbW92ZWQuDQo+Pg0KPj4gMi4gV3Jp
dGluZyB0aGUgY29tbWFuZCByZWdpc3RlciBhbmQgUk9NIEJBUiByZWdpc3RlciBtYXkgdHJpZ2dl
cg0KPj4gbW9kaWZ5X2JhcnMgdG8gcnVuLCB3aGljaCBpbiB0dXJuIG1heSBhY2Nlc3MgbXVsdGlw
bGUgcGRldnMgd2hpbGUNCj4+IGNoZWNraW5nIGZvciB0aGUgZXhpc3RpbmcgQkFSJ3Mgb3Zlcmxh
cC4gVGhlIG92ZXJsYXBwaW5nIGNoZWNrLCBpZiBkb25lDQo+PiB1bmRlciB0aGUgcmVhZCBsb2Nr
LCByZXF1aXJlcyB2cGNpLT5sb2NrIHRvIGJlIGFjcXVpcmVkIG9uIGJvdGggZGV2aWNlcw0KPj4g
YmVpbmcgY29tcGFyZWQsIHdoaWNoIG1heSBwcm9kdWNlIGEgZGVhZGxvY2suIEl0IGlzIG5vdCBw
b3NzaWJsZSB0bw0KPj4gdXBncmFkZSByZWFkIGxvY2sgdG8gd3JpdGUgbG9jayBpbiBzdWNoIGEg
Y2FzZS4gU28sIGluIG9yZGVyIHRvIHByZXZlbnQNCj4+IHRoZSBkZWFkbG9jaywgY2hlY2sgd2hp
Y2ggcmVnaXN0ZXJzIGFyZSBnb2luZyB0byBiZSB3cml0dGVuIGFuZCBhY3F1aXJlDQo+PiB0aGUg
bG9jayBpbiB0aGUgYXBwcm9wcmlhdGUgbW9kZSBmcm9tIHRoZSBiZWdpbm5pbmcuDQo+Pg0KPj4g
QWxsIG90aGVyIGNvZGUsIHdoaWNoIGRvZXNuJ3QgbGVhZCB0byBwZGV2LT52cGNpIGRlc3RydWN0
aW9uIGFuZCBkb2VzIG5vdA0KPj4gYWNjZXNzIG11bHRpcGxlIHBkZXZzIGF0IHRoZSBzYW1lIHRp
bWUsIGNhbiBzdGlsbCB1c2UgYSBjb21iaW5hdGlvbiBvZiB0aGUNCj4+IHJlYWQgbG9jayBhbmQg
cGRldi0+dnBjaS0+bG9jay4NCj4+DQo+PiAzLiBPcHRpbWl6ZSBpZiBST00gQkFSIHdyaXRlIGxv
Y2sgcmVxdWlyZWQgZGV0ZWN0aW9uIGJ5IGNhY2hpbmcgb2Zmc2V0DQo+PiBvZiB0aGUgUk9NIEJB
UiByZWdpc3RlciBpbiB2cGNpLT5oZWFkZXItPnJvbV9yZWcgd2hpY2ggZGVwZW5kcyBvbg0KPj4g
aGVhZGVyJ3MgdHlwZS4NCj4+DQo+PiA0LiBSZWR1Y2UgbG9ja2VkIHJlZ2lvbiBpbiB2cGNpX3Jl
bW92ZV9kZXZpY2UgYXMgaXQgaXMgbm93IHBvc3NpYmxlDQo+PiB0byBzZXQgcGRldi0+dnBjaSB0
byBOVUxMIGVhcmx5IHJpZ2h0IGFmdGVyIHRoZSB3cml0ZSBsb2NrIGlzIGFjcXVpcmVkLg0KPj4N
Cj4+IDUuIFJlZHVjZSBsb2NrZWQgcmVnaW9uIGluIHZwY2lfYWRkX2hhbmRsZXJzIGFzIGl0IGlz
IHBvc3NpYmxlIHRvDQo+PiBpbml0aWFsaXplIG1hbnkgbW9yZSBmaWVsZHMgb2YgdGhlIHN0cnVj
dCB2cGNpIGJlZm9yZSBhc3NpZ25pbmcgaXQgdG8NCj4+IHBkZXYtPnZwY2kuDQo+Pg0KPj4gNi4g
dnBjaV97YWRkfHJlbW92ZX1fcmVnaXN0ZXIgYXJlIHJlcXVpcmVkIHRvIGJlIGNhbGxlZCB3aXRo
IHRoZSB3cml0ZSBsb2NrDQo+PiBoZWxkLCBidXQgaXQgaXMgbm90IGZlYXNpYmxlIHRvIGFkZCBh
biBhc3NlcnQgdGhlcmUgYXMgaXQgcmVxdWlyZXMNCj4+IHN0cnVjdCBkb21haW4gdG8gYmUgcGFz
c2VkIGZvciB0aGF0LiBTbywgYWRkIGEgY29tbWVudCBhYm91dCB0aGlzIHJlcXVpcmVtZW50DQo+
PiB0byB0aGVzZSBhbmQgb3RoZXIgZnVuY3Rpb25zIHdpdGggdGhlIGVxdWl2YWxlbnQgY29uc3Ry
YWludHMuDQo+Pg0KPj4gNy4gRHJvcCBjb25zdCBxdWFsaWZpZXIgd2hlcmUgdGhlIG5ldyByd2xv
Y2sgaXMgdXNlZCBhbmQgdGhpcyBpcyBhcHByb3ByaWF0ZS4NCj4+DQo+PiA4LiBEbyBub3QgY2Fs
bCBwcm9jZXNzX3BlbmRpbmdfc29mdGlycXMgd2l0aCBhbnkgbG9ja3MgaGVsZC4gRm9yIHRoYXQg
dW5sb2NrDQo+PiBwcmlvciB0aGUgY2FsbCBhbmQgcmUtYWNxdWlyZSB0aGUgbG9ja3MgYWZ0ZXIu
IEFmdGVyIHJlLWFjcXVpcmluZyB0aGUNCj4+IGxvY2sgdGhlcmUgaXMgbm8gbmVlZCB0byBjaGVj
ayBpZiBwZGV2LT52cGNpIGV4aXN0czoNCj4+ICAgLSBpbiBhcHBseV9tYXAgYmVjYXVzZSBvZiB0
aGUgY29udGV4dCBpdCBpcyBjYWxsZWQgKG5vIHJhY2UgY29uZGl0aW9uDQo+PiAgICAgcG9zc2li
bGUpDQo+PiAgIC0gZm9yIE1TSS9NU0ktWCBkZWJ1ZyBjb2RlIGJlY2F1c2UgaXQgaXMgY2FsbGVk
IGF0IHRoZSBlbmQgb2YNCj4+ICAgICBwZGV2LT52cGNpIGFjY2VzcyBhbmQgbm8gZnVydGhlciBh
Y2Nlc3MgdG8gcGRldi0+dnBjaSBpcyBtYWRlDQo+Pg0KPj4gOS4gQ2hlY2sgZm9yICFwZGV2LT52
cGNpIGluIHZwY2lfe3JlYWR8d3JpdGV9IGFmdGVyIGFjcXVpcmluZyB0aGUgbG9jaw0KPj4gYW5k
IGlmIHNvLCBhbGxvdyByZWFkaW5nIG9yIHdyaXRpbmcgdGhlIGhhcmR3YXJlIHJlZ2lzdGVyIGRp
cmVjdGx5LiBUaGlzIGlzDQo+PiBhY2NlcHRhYmxlIGFzIHdlIG9ubHkgZGVhbCB3aXRoIERvbTAg
YXMgb2Ygbm93LiBPbmNlIERvbVUgc3VwcG9ydCBpcw0KPj4gYWRkZWQgdGhlIHdyaXRlIHdpbGwg
bmVlZCB0byBiZSBpZ25vcmVkIGFuZCByZWFkIHJldHVybiBhbGwgMCdzIGZvciB0aGUNCj4+IGd1
ZXN0cywgd2hpbGUgRG9tMCBjYW4gc3RpbGwgYWNjZXNzIHRoZSByZWdpc3RlcnMgZGlyZWN0bHku
DQo+Pg0KPj4gMTAuIEludHJvZHVjZSBwY2lkZXZzX3RyeWxvY2ssIHNvIHRoZXJlIGlzIGEgcG9z
c2liaWxpdHkgdG8gdHJ5IGxvY2tpbmcNCj4+IHRoZSBwY2lkZXYncyBsb2NrLg0KPj4NCj4+IDEx
LiBVc2UgcGNpZGV2J3MgbG9jayBhcm91bmQgZm9yX2VhY2hfcGRldiBhbmQgcGNpX2dldF9wZGV2
X2J5X2RvbWFpbg0KPj4gd2hpbGUgYWNjZXNzaW5nIHBkZXZzIGluIHZwY2kgY29kZS4NCj4gU28g
aWYgeW91IHVzZSB0aGUgcGNpZGV2c19sb2NrIHRoZW4gaXQncyBpbXBvc3NpYmxlIGZvciB0aGUg
cGRldiBvcg0KPiBwZGV2LT52cGNpIHRvIGJlIHJlbW92ZWQgb3IgcmVjcmVhdGVkLCBhcyB0aGUg
cGNpZGV2cyBsb2NrIHByb3RlY3RzDQo+IGFueSBkZXZpY2Ugb3BlcmF0aW9ucyAoYWRkLCByZW1v
dmUsIGFzc2lnbiwgZGVhc3NpZ24pLg0KPg0KPiBJdCdzIGhvd2V2ZXIgbm90IE9LIHRvIHVzZSB0
aGUgcGNpZGV2cyBsb2NrIGluIHZwY2lfe3JlYWQsd3JpdGV9DQo+IGFzLWlzLCBhcyB0aGUgaW50
cm9kdWNlZCBjb250ZW50aW9uIGlzIElNTyBub3QgYWNjZXB0YWJsZS4NCj4NCj4gVGhlIG9ubHkg
dmlhYmxlIG9wdGlvbiBJIHNlZSBoZXJlIGlzIHRvOg0KPg0KPiAgIDEuIE1ha2UgdGhlIHBjaWRl
dnMgbG9jayBhIHJ3bG9jazogc3dpdGNoIGN1cnJlbnQgY2FsbGVycyB0byB0YWtlIHRoZQ0KPiAg
ICAgIGxvY2sgaW4gd3JpdGUgbW9kZSwgZGV0ZWN0IGFuZCBmaXh1cCBhbnkgaXNzdWVzIHRoYXQg
Y291bGQgYXJpc2UNCj4gICAgICBmcm9tIHRoZSBsb2NrIG5vdCBiZWluZyByZWN1cnNpdmUgYW55
bW9yZS4NCj4gICAyLiBUYWtlIHRoZSBsb2NrIGluIHJlYWQgbW9kZSBhcm91bmQgdnBjaV97cmVh
ZCx3cml0ZX0gc2VjdGlvbnMgdGhhdA0KPiAgICAgIHJlbHkgb24gcGRldiAoaW5jbHVkaW5nIHRo
ZSBoYW5kbGVycykuDQo+DQo+IFRoZXNlIGl0ZW1zIHNob3VsZCBiZSBhdCBsZWFzdCB0d28gc2Vw
YXJhdGUgcGF0Y2hlcy4gTGV0J3Mgbm90IG1peCB0aGUNCj4gY29udmVyc2lvbiBvZiBwY2lkZXZz
IGxvY2tzIHdpdGggdGhlIGFkZGl0aW9uIG9mIHZQQ0kgc3VwcG9ydC4NCj4NCj4gSSB0aGluayB3
aXRoIHRoYXQgd2UgY291bGQgZ2V0IGF3YXkgd2l0aG91dCByZXF1aXJpbmcgYSBwZXItZG9tYWlu
DQo+IHJ3bG9jaz8gSnVzdCBkb2luZyBsb2NrIG9yZGVyaW5nIGluIG1vZGlmeV9iYXJzIHJlZ2Fy
ZGluZw0KPiB0bXAtPnZwY2ktPmxvY2sgdnMgcGRldi0+dnBjaS0+bG9jay4gTmVpdGhlciBwZGV2
IG9yIHZwY2kgY2FuIGdvIGF3YXkNCj4gd2hpbGUgaG9sZGluZyB0aGUgcGNpZGV2cyBsb2NrLg0K
Pg0KPiBTb3J0aW5nIHRoZSBzaXR1YXRpb24gaW4gbW9kaWZ5X2JhcnMgc2hvdWxkIGFsc28gYmUg
ZG9uZSBhcyBhIHNlcGFyYXRlDQo+IHBhdGNoIG9uIHRvcCBvZiAxLiBhbmQgMi4NClNvLCB0byBt
YWtlIGl0IGNyeXN0YWwgY2xlYXI6IHdlIGNhbiBkbyB3aXRoIHRoZSBsb2NraW5nIGFzIGluIHRo
aXMNCnBhdGNoIGFuZCBpbnN0ZWFkIHdlIG5lZWQgdG8gY29udmVydCBwY2lkZXZzIGxvY2sgaW50
byByd2xvY2suDQpNZWFuaW5nIHRoYXQgSSBuZWVkIHRvIGRyb3AgdGhpcyBwYXRjaC4NCg0KVGhl
biwgMyBwYXRjaGVzIHRvIGZvbGxvdzoNCjEuIHBjaWRldnMgYXMgcndsb2NrDQoyLiB2cGNpX3ty
ZWFkfHdyaXRlfSBhbmQgdGhlIHJlc3QgdXNpbmcgbmV3IHBjaWRldnMgcndsb2NrDQozLiBsb2Nr
IG9yZGVyaW5nIGluIG1vZGlmeV9iYXJzDQoNCklzIGl0IHdoYXQgd2Ugd2FudD8NCg0KVGhhbmsg
eW91LA0KT2xla3NhbmRy


From xen-devel-bounces@lists.xenproject.org Tue Feb 15 11:29:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 11:29:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273046.468089 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJw0q-00020Q-3G; Tue, 15 Feb 2022 11:28:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273046.468089; Tue, 15 Feb 2022 11:28:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJw0q-00020J-0C; Tue, 15 Feb 2022 11:28:52 +0000
Received: by outflank-mailman (input) for mailman id 273046;
 Tue, 15 Feb 2022 11:28:50 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=vySV=S6=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nJw0o-000209-AI
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 11:28:50 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6ff8d711-8e52-11ec-8eb8-a37418f5ba1a;
 Tue, 15 Feb 2022 12:28:47 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6ff8d711-8e52-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644924527;
  h=from:to:cc:subject:date:message-id:
   content-transfer-encoding:mime-version;
  bh=cvKieyjM2SAPbaGogA/jzsoswbD55afhl8IwBBSwHUQ=;
  b=dmzawsEvwO8Lyq/Z3oPA2m+QiEjZmRK8pa4logg6rYrCHobpJzYFpVzO
   rVXNXs/mrC+TUtT9U9qo/ZOBHitRVnwaxh3TV4xh4Gu47FY3O1O2FCUNI
   1u694YxnuOa+4cYM8ibn9LZcoGNzQwwou3pTNyqGIa/KQrDuftY6uGQkZ
   E=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: dGa1dvm2qB/b8vpmNDeN2gCgUG0Gj2WBbn4PN1OFZXpuIICXpD/dvSR2nu4oHpjJJFGtWhkqJG
 OqfBRpjfXka8pfQm5uc7cCtXy0QRU8cEFPzSpSkycvn04pnokJnP20TgwdrFihPUC0Yy1BDq6U
 /KNFVCCuRK1m87NOdmqTOG9v6TPaw1dU3yWUF1D/95Lrjkajo/aAqIOFfGMHN+XVQprmpjC9ZB
 1XQEdgPA/fhlEehyDlSRIkxGpMrPxkwZNx0ZKdptB+B+Dx6IDWRxJiD6FCwdmAPrqr/m1EumlF
 ZB8tC0Eu0MQE9gIZrmXy1Wwp
X-SBRS: 5.1
X-MesageID: 64233069
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:KUKjGalABBs8Lfkaiudjn7/o5gx/IURdPkR7XQ2eYbSJt1+Wr1Gzt
 xIeUWnUMqyIZ2D8KNB+bYm39BgC7ZCGx9RqQAZo/n1gQyMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BClVlxJVF/fngqoDUUYYoAQgsA180IMsdoUg7wbRh2Nc12YLR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 OptlsLqcQ4vArTvocIBdh55Eg9cPrITrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBNPsM44F/Glp0BnSDOo8QICFSKLPjTNd9Gls3JsVRaiPD
 yYfQTtPdC6aUzwMAWc0Is0yofeBvEvWeQQN/Tp5ooJoujOOnWSdyoPFMtDYZ9iLTsV9hVuDq
 yTN+GGRKg4eHMySz3yC6H3EruzCgyL9Hp4THbuQ9/h2jVnVzWsWYDUGWF3+rfSnh0qWX9NEN
 1dS6icotbI19kGgUp/6RRLQiHyZuFgaUtlZEew/4SmMzLbZ50CSAW1sc9JaQIV47olsH2Vsj
 wLX2YOybdByjFGLYU291enOlTq0BTE2FEkeQCglTCUn4Ma29enfkSnzZtpkFae0iPj8Fjfx3
 y2GoUACulkDsSIY//7lpA6a2lpAsrCMF1dovVuPAgpJ+yskPNbNWmC+1bTMAR+sxq69R0LJg
 nULktP2AAsmXcDUz3zlrAng8diUCxe53N/03AQH83oJrW3FF5ufkWd4um8WGauRGpxYEQIFm
 WeK0e+r2LddPWGxcYh8aJ+rBsIhwMDITIq5Cq+EPocTOsEqLmdrGR2CgmbKgQjQfLUEy/lja
 f93j+7wZZrlNUiX5GXvHLpMuVPa7is/2XnSVfjGI+ePitKjiIquYe5dajOmN7lhhIvd+Vm92
 4sPZqOilkQEOMWjM3a/zGLmBQ1TRZTNLcut8JI/my/qClcOJVzN/NeImu1/ItQ8xfwK/goKl
 1nkMnJlJJPErSSvAS2Ba2x5aaOpWpB6rHkhOjcrM0ru0H8mCbtDJo9GH3fuVbV4puFl09BuS
 PwJJ5eJDvhVE2yV8DUBd5jt6odlcU3z1w6JOiOkZhk5foJhGFOVqoO1IFO3+XlcFDezuOs/v
 6akilHRT60cSlkwF83Rcv+ukQ+85CBPhOJoUkLUCdBPY0GwopNyIin8g6ZvccEBIBnO3BWA0
 AOSDUtKrOXBudZtotLImbqFv8GiFO4nRhhWGGzS7LCXMyjG/zX8nd8cAbjQJT2EDTH64qSvY
 +lR3srQCvxfkQYYqZd4HpZq0bk6u4nlqYhFw1k2B37MdVmqVO9teyHUwclVu6RR7bZFog/qC
 FmX89xXNLjVasPoFFkdeFgsYuiZjKxGnzDT6bI+IVng5T8x972CCB0AMx6JgS1bDb10LIJ6n
 rtx5J9Is1Sy2kgwL9KLriFI7GDdfHUPXpIuuoweHIK22BEgzUtPYMCEByL7iH1Vhw6g7qX+z
 ueouZf/
IronPort-HdrOrdr: A9a23:YbpmM61Z6R5RX6utSkZ7ggqjBIckLtp133Aq2lEZdPUMSL38qy
 ncpoV+6faUskdoZJhOo7G90cW7K080sKQFg7X5Xo3SJzUO2lHJEGgK1+KLqAEIWReOldK1vp
 0NT0EKMrPN5C9B4voSjjPULz9q+qjhzEnhv5a5855Cd3ASV51d
X-IronPort-AV: E=Sophos;i="5.88,370,1635220800"; 
   d="scan'208";a="64233069"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gANDWWIlaOhj2ED5LGcLvYmYWeFmX0XNJDDtHURKoI37YtqPaqzYvl9ndtR/r4b1SEl5svPaznaIpqyQv5xLPB5ec5q44cbzIGnxjIgqpGH8AvRfIW9a/Vsn/MlfkdtsYy6G/fewV3n+lOdJy3XUTXQhFnj3hjytqpujTkgXndd9vgaMdMjwygMJlcqAUjsdJ9Ci9Gq4l/bQQBZvvymraF7QFza8YU9d32QXEgsO8sddCp8k0mq30qkBc4WYPAVU2Uz5M90aaZiQ9ce+mFh+/dzEeXVoTorAzksv3vIfVE7KQMv+yfxPwfyWC/Nb/KxO3wlIw7aFtONDFk7/UVXJag==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=mSr8Z0lH9cOgDLnRQ/ZeXDRRLeFk+M9X/cjQ9dZMbPE=;
 b=YhIsDO82oI8bqoROWDKcu1SPxq9PowqODA2oDnUrTzlkkGZm52Xa2mSRqI6kHahLOCtP0GpRc8SVXJAj3p8kScKijy2FVB3g4R+0gNPIUTamPoqJ9cIy+MBWy0/Jqe7x26tkwtEzyeIXXCiNe4h5RgeWvPXMEzzJnrQfO63r1tY5ZGdp3AV8pvsFO5jyBVKBi+GWiJ9YKcS2hF1pVzoqvnikP8N2d+KKFZvPt11qF78EPXs8xvD3JyjRF/EI1q/ucUJK1VIkAxzkLuCx3MzczI8K1wOnK3IMhgnxFmuzY4/iwX2Rj8nuywvVQsWIGTLu1ZGHqcqFnF+dK9nVQz+8Nw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=mSr8Z0lH9cOgDLnRQ/ZeXDRRLeFk+M9X/cjQ9dZMbPE=;
 b=b+hEAmt3rVEly2/unSXttrDcT5NJL1ouqzdvUDI1850p4pVbfwzce4ZHQZGxE6ynrHrRx+j85g+OEwJyorHt1ThUcX3KLeLZISCkMLL66Qrt2iyl9c2JIlv/O6TPdHL52Hcn1O53Kr0RyhXxdbqFr6bCNAEmnXf3Ylho/9K85y4=
From: Roger Pau Monne <roger.pau@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Roger Pau Monne <roger.pau@citrix.com>, Jun Nakajima
	<jun.nakajima@intel.com>, Kevin Tian <kevin.tian@intel.com>, Jan Beulich
	<jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu
	<wl@xen.org>
Subject: [PATCH] x86/vmx: remove dead code to create domains without a vLAPIC
Date: Tue, 15 Feb 2022 12:28:35 +0100
Message-ID: <20220215112835.99230-1-roger.pau@citrix.com>
X-Mailer: git-send-email 2.34.1
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO4P265CA0094.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:2bc::9) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 0940c8b5-5449-48f9-1e24-08d9f0765186
X-MS-TrafficTypeDiagnostic: PH0PR03MB6721:EE_
X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
X-Microsoft-Antispam-PRVS: <PH0PR03MB6721166F05C85EB88029B5388F349@PH0PR03MB6721.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5236;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 7hxTaC2/Cm5LGZiGzwswiDA21SZ0hErZ0WSHHUxzMV+SwDeR9vX5MO7CnjRRl26PNAnlO/88jrBwcBudkZxxjWpbJoF2lxQp3IRaetFWy8sefE2ZC7P3eaDx7I4p/ZmAKC41G/2b+70CUfgLD4l8UMyNVHUscTW0FnTYaM9oY6tWTLI6HWctn3Ua4qQiSTPAIPsbLbpUlLygP9GDbj+wkM012sVaRhntBKDur0OCktP+neH62pqFwMK7stvSURbATMLIYbHbZRTkxtWvuPKVa0IkQwIQWWkUaPI8QsBPeefQS8jRdBHy7WytDf0npI5uLaLYXmEen7n0EXW2ZLy29kGkTraNRMM6/pgYqwdnQBYj9chEL06B6Wsy2VOX1zN9VLtvrxlfe3R7q3Hi3X+90naYecyFSpTC02HwbIbZl33zIUZd++55P/izNPE8KwN0dthFu9nJ7M+4ZIh67UyDnu4BEUIqYueLnAesrM/avbN/uOiJ1kF9Cmi6RbU3b2++gXkRXKTDFP5/NpgoP/+UscU3tXRwEXiXIDCpKIvACS7fY7i97EfVMxcsaRhdq7pnhOg9HOv+uRVqlVUuRX1RwZquj3vV1TwM5v6kgvIh5A3m2Kaq81co17b6naXm3tFGA9R8fuvMxFIyDYGBwR+kBQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(2616005)(5660300002)(82960400001)(36756003)(83380400001)(26005)(2906002)(1076003)(186003)(38100700002)(6916009)(6486002)(86362001)(508600001)(6666004)(6512007)(66556008)(8676002)(66476007)(4326008)(54906003)(316002)(66946007)(6506007)(8936002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y2pIRXBNTitwVFRVNHJrL1pQWW40c1JuTVlyYVBvakFFM1N0MVphK01kMG1R?=
 =?utf-8?B?RE0xTDBtaUYrZDlGa2hMSUg0cExxRzhKai93MW5MSnJ0TThJOExsZU4vdlo5?=
 =?utf-8?B?ajhxMy9JZjhNNWpJSnJDNEFiM2JxNHJPREhHVXN5aWxINjBmNWdhL0dESDBj?=
 =?utf-8?B?c2FlOHMzRkF4SUZ6V2tzZFNRcWVUNEhWMndYaEtKOXQ1bDh3NkdOdTRmYlNk?=
 =?utf-8?B?YlBEZ0xDMWYrQVJjaFpMa0dPNjVuRXBMZmMrRGk4alJqNXNtdEkwQTdGY3l4?=
 =?utf-8?B?UjVvYTdySG1QV3ZxK1FObzVUdncwRUJKTDhpN3hKaXMxTk9nQzdIUldacGtz?=
 =?utf-8?B?MmQ0VUNpTXFqMHFsU284Z2ZlditjbjRGc0FGVzJRcktkZmRZcFZXQkxaRVE4?=
 =?utf-8?B?WCs1aW5vcXd3dDZvL3hpalpma2FYNUVpTjd6YVFSTm1vdW9Reld5bnN1Mzh2?=
 =?utf-8?B?UFlWOXZJM3dFV3RsMXE1ZG9pVzdOenpGVXljVWpINHRMMitWYmt2Zk1GS2Vj?=
 =?utf-8?B?b1kyS3JsYjE0bDNlYjhERDZlMW1IRFVORWZVWW83OENVU2daSXhMaFh5ek1G?=
 =?utf-8?B?cDBOZEpMTkxmTVdVeENRUzB0ckNWdFB3b2dtZXliaUJ6WDZRL0RKTnNEZi9T?=
 =?utf-8?B?ZlBmSWxoUkFGaER4T3NlNEIzdW0rd21nZXJqVUpSOXJTbXo3d3RDTU0wVlBV?=
 =?utf-8?B?ZzgwbTVXMExkN1p3dDNLamc4NzRRWDlYNTUwaXE2RFdsdEt1cnVsNnhiY0hz?=
 =?utf-8?B?UzRlUG5KZytVVmw2ajhVTGVoejU1Q3JMY0ZFblIzdS80TWpsQVEvUGdUMU4v?=
 =?utf-8?B?VldienZmMDhMZW83V0R6VFR4dGNSNzZ5aVhNUXczRnNoaDI0VTJZYm42SFhF?=
 =?utf-8?B?MEVYRDUrakVqQ3ZUbGFpMGtzOERYdnF5aXRZeDdFVGNMWml6NVFCUmxnbGtk?=
 =?utf-8?B?aU1hWVZqMU1ISGxSS3QyRzU2Q1QrYisyaTc3MGF4NGZVd1ljRVZEWlB6Zkdu?=
 =?utf-8?B?L21VVFJkM2dwQ0pkNzdZeERLWG9GOWJtaTV4c0E5RzZ3QUoweTF1Y1NmcnJ1?=
 =?utf-8?B?VDBmVHkvZ3RlUTBXYWxBUVNzcjlrWmQ1OU9kanF3NTQzUGN5MGVZN0V0cW1F?=
 =?utf-8?B?cWhnQk9JenFWNG9vRWMrcUc4STN1YjBDMHBKaDZpaG96eGNXR2RtTFFLOUdr?=
 =?utf-8?B?V0lhWVRiTVdxcE50eWhCWjFoT1RZbFp5UHN6Y05rOUdFSmVaTXRNQllXSlRa?=
 =?utf-8?B?ZHVBMXF6dGJrUExPU1JldWhqcEpnZFlaclZndFhJQnZIQXJXQnZwalhSeHE1?=
 =?utf-8?B?ejRhUk5SYVU1S3JQOHVqa1k4WUFKZ3dlZHhKZE1UTHhsdUlsaFZCalowc3dW?=
 =?utf-8?B?V05aVTQ3ekdLM1VkQzU0NU1ybGY0eDlNenJrbC9MZTM4bHpTOWk3SUlzTndq?=
 =?utf-8?B?dzFPeHRyNHFqNmdsWTNMVkRtSW1NQkpZL2htcml6bFpIQnA1SVBGWHl5eU1U?=
 =?utf-8?B?ZHl2VVRNaDBTNlliRVNJaWN2NUpYOUZLekV0WXNkZkI1VlpPdWd4N0ZUeHNv?=
 =?utf-8?B?dXBkaEJmSmd3TytEV2tFSlU3WVlLSE1uMnFwZ2M4SjloRHAzaWNkT2dBMm92?=
 =?utf-8?B?OGM4ZkoySmRBKzB6WHZYYXkvQU5NaTJlREZsU3JUS1phSXZNUGtwMWJHV0w2?=
 =?utf-8?B?eTdGVFFnaUgwNVdhUjBaeXRxZ1F3c2RQajdScVNCZ0xvSWVLMUFqN0RudHZT?=
 =?utf-8?B?M2hoYW1hWjhKd3p0Rk5IeXk5cVB6YnRrWnJ6WnlVSEFmb2NNUndVTC9Kb2Zh?=
 =?utf-8?B?eVc5RG9qbFNGK0Y5VCtHUUNRZEJkUk54d2lUUlJtMEUzS2d4WjBrZlVwdS85?=
 =?utf-8?B?YkcycHpDWmcrYkR5dEhMb0VYYkQ3UVN4TVYwYlZCRTZZdmIxa09TTWF2T0hn?=
 =?utf-8?B?WEtoZkJvMU8yTGdyUjFUK1VWOERGSVBiRnhsbUd4Tit3ZXNOMC85Y1FPZTFt?=
 =?utf-8?B?VlhxbmJTeS95MFh6VzE4UWNDQ2ZBdmgraXd0d1J0bTJIM2g2S0tTcmNLQkpi?=
 =?utf-8?B?UWxUUUhVb1RiTitBaWhOSkZ3TWdIcXVvTDBJNTdveWVPZHF1M1Y2U0YwdEdy?=
 =?utf-8?B?c01kbWhLYVFxTnJqY0syR21MRXJ4dDczemRpcW9xT2Z2NGFWTnQ2L2NzUHp5?=
 =?utf-8?Q?2E1t7wp4LkjKsltLkuTv2qc=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0940c8b5-5449-48f9-1e24-08d9f0765186
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 11:28:41.6530
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vTdkAE/OtR6jlqTPbhyNLkRrRoMYK4JruGX8OOnN0j9G2WNUiIvzNxHjrCzren2xI335sZt9fwtTjIGkOyYB8w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6721
X-OriginatorOrg: citrix.com

After the removal of PVHv1 it's no longer supported to create a domain
using hardware virtualization extensions and without a local APIC:
PVHv2 mandates domains to always have a LAPIC. Remove some stale code
in VMCS construction and related helpers that catered for that
use-case.

No functional change.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
 xen/arch/x86/hvm/vmx/vmcs.c | 14 --------------
 xen/arch/x86/hvm/vmx/vmx.c  |  4 ++--
 2 files changed, 2 insertions(+), 16 deletions(-)

diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c
index 7ab15e07a0..9eda8a5f0f 100644
--- a/xen/arch/x86/hvm/vmx/vmcs.c
+++ b/xen/arch/x86/hvm/vmx/vmcs.c
@@ -1123,20 +1123,6 @@ static int construct_vmcs(struct vcpu *v)
     /* Do not enable Monitor Trap Flag unless start single step debug */
     v->arch.hvm.vmx.exec_control &= ~CPU_BASED_MONITOR_TRAP_FLAG;
 
-    if ( !has_vlapic(d) )
-    {
-        /* Disable virtual apics, TPR */
-        v->arch.hvm.vmx.secondary_exec_control &=
-            ~(SECONDARY_EXEC_VIRTUALIZE_APIC_ACCESSES
-              | SECONDARY_EXEC_APIC_REGISTER_VIRT
-              | SECONDARY_EXEC_VIRTUAL_INTR_DELIVERY);
-        v->arch.hvm.vmx.exec_control &= ~CPU_BASED_TPR_SHADOW;
-
-        /* In turn, disable posted interrupts. */
-        __vmwrite(PIN_BASED_VM_EXEC_CONTROL,
-                  vmx_pin_based_exec_control & ~PIN_BASED_POSTED_INTERRUPT);
-    }
-
     vmx_update_cpu_exec_control(v);
 
     __vmwrite(VM_EXIT_CONTROLS, vmexit_ctl);
diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c
index 36c8a12cfe..0f98fb4f29 100644
--- a/xen/arch/x86/hvm/vmx/vmx.c
+++ b/xen/arch/x86/hvm/vmx/vmx.c
@@ -419,7 +419,7 @@ static void domain_creation_finished(struct domain *d)
     gfn_t gfn = gaddr_to_gfn(APIC_DEFAULT_PHYS_BASE);
     bool ipat;
 
-    if ( !has_vlapic(d) || mfn_eq(apic_access_mfn, INVALID_MFN) )
+    if ( mfn_eq(apic_access_mfn, INVALID_MFN) )
         return;
 
     ASSERT(epte_get_entry_emt(d, gfn, apic_access_mfn, 0, &ipat,
@@ -3317,7 +3317,7 @@ static void vmx_install_vlapic_mapping(struct vcpu *v)
 {
     paddr_t virt_page_ma, apic_page_ma;
 
-    if ( !has_vlapic(v->domain) || mfn_eq(apic_access_mfn, INVALID_MFN) )
+    if ( mfn_eq(apic_access_mfn, INVALID_MFN) )
         return;
 
     ASSERT(cpu_has_vmx_virtualize_apic_accesses);
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Tue Feb 15 11:30:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 11:30:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273051.468101 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJw2Z-0003Lq-Gb; Tue, 15 Feb 2022 11:30:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273051.468101; Tue, 15 Feb 2022 11:30:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJw2Z-0003Lj-DU; Tue, 15 Feb 2022 11:30:39 +0000
Received: by outflank-mailman (input) for mailman id 273051;
 Tue, 15 Feb 2022 11:30:37 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=xOiq=S6=epam.com=prvs=4045782cdb=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nJw2X-0003LV-Go
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 11:30:37 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b13eea2a-8e52-11ec-b215-9bbe72dcb22c;
 Tue, 15 Feb 2022 12:30:36 +0100 (CET)
Received: from pps.filterd (m0174681.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 21FBPrxb006717;
 Tue, 15 Feb 2022 11:30:33 GMT
Received: from eur05-vi1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2169.outbound.protection.outlook.com [104.47.17.169])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3e8b9yr0ux-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Tue, 15 Feb 2022 11:30:31 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM0PR03MB4081.eurprd03.prod.outlook.com (2603:10a6:208:7a::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.19; Tue, 15 Feb
 2022 11:30:15 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::fc4d:4749:5d1:eb73]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::fc4d:4749:5d1:eb73%4]) with mapi id 15.20.4975.019; Tue, 15 Feb 2022
 11:30:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b13eea2a-8e52-11ec-b215-9bbe72dcb22c
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Cq1XW1xTQLIeQ2z2+RWP10ULhy9e+VrifKStoD+bjZfEDCmNAJ3R83/S3jJ+eb2q4jzOMUHtAHGUiUSB3eknTLGDqvpaVCzMjR5NObLJa2vbEtiZ4LaqGeDbDkvG9URhdIiAexz3W6KPFSbG+eUH1GmVacX/LTp8u9zxnAESQEJq6l36Lcx1zbGu9rZwEXTn7ZS8XTE+fGkHnH0tFm5TZjJbBNvBCCSXE4fPlli/9rNSHKQSqWLvSwQwRrIxZaCVEOR09LCDITVE9XnpeisgurJP1bEXi3QYynce5UMkTeu+4PGTynal4ceh3EETfhD4hDFciMaVaSpagF7lkJk7iA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=742Cnv8Lj8ogmhysj6T2IvuwDHMG6TjprE6oM5U6oPU=;
 b=K61go//pwqQuIzAYDgKugVi3Q4jjl8LMCNtSkH32DSWWGMtNIUHihavT8v5XSFuErxYYbefd9VE3GMAIaShPPNS7s2L6ONbT3xe6HBchVyxMy8AYgIYMVDimrTLAjcL011H1N2PTJuoFkxT2elBITc7XD8nTlhsQUTKUIKVflfoQKf/X3uYPg0MWfLBlkqFXDg7dTztKu5ppwtLsM9TVZVySWt5KdaiY9wNS9YK4vZjRUt8AOjHxwScsGzxEIsJP4ihKgRWAB9BWwLIxu7J9RJYVU/Vtkyql1trXTcd8yBGgxW5fUo8PA/TGf5a/M9chW71wczWPoQjfGO/CDgnJtA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=742Cnv8Lj8ogmhysj6T2IvuwDHMG6TjprE6oM5U6oPU=;
 b=KyAYE6XPzqD8//n2fRzOq6XeU/5ZxB7KC4K9psPM0n75oL7uX6gY0xM3FJJ5oD5y2fkxZUvLs9s072f6n0hN07vgfytH+OEGoz7BV9pVjTYmNuo7KFKzlCZplJcGAhFHhqoYWBz7Qno0qjD1vycJtWjvOo1wI7VuzJ7OHYF0MBhh3DcAlf5x4UkZ1McjZylVipM2+7fmuCpVEISTpzi4T1VhKQRN/6JRFGcxLa9VHr/5GTubhHQ6GZVCOAVd8sS5pTc5PxIZhWHHyG0MFKEZ5QX+oqgBZKZBGdegQs0otvqDlRtyrOO2z1UThK9H6qIbp/c0pOvi/tsOvABuEoB3Eg==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: "anthony.perard@citrix.com" <anthony.perard@citrix.com>
CC: "wl@xen.org" <wl@xen.org>, "jgross@suse.com" <jgross@suse.com>,
        Oleksandr
 Andrushchenko <Oleksandr_Andrushchenko@epam.com>,
        "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] tools: remove xenstore entries on vchan server closure
Thread-Topic: [PATCH] tools: remove xenstore entries on vchan server closure
Thread-Index: AQHX7cJnOJurcgYme0yvunOBFlJKtayU40cA
Date: Tue, 15 Feb 2022 11:30:14 +0000
Message-ID: <d9432327-24ae-366d-5d56-cc076445fca0@epam.com>
References: <20211210123519.595163-1-andr2000@gmail.com>
In-Reply-To: <20211210123519.595163-1-andr2000@gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: d0db4dae-8db1-4c63-859c-08d9f0768957
x-ms-traffictypediagnostic: AM0PR03MB4081:EE_
x-microsoft-antispam-prvs: 
 <AM0PR03MB408177082D16ED3422709321E7349@AM0PR03MB4081.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 6UAflzRMEpfkrJILucJxZE2dFzejuc3wCnEvRJUBfYWLIXUO+HxE6sNR00ZNqSpp7L4eEhLl0/svh0siC7oh+FvwJVvv1Cl/le2XlNjD9mYh0Pd5yzNx4VEE2DMHDlIio55cgGp2HiVSqh+cy2uRwyNQpEdF6NSza6nTitOLU0X3+osrWoQRdBVR6iRkM2KTGK17NBBsakImpmTrwQUx9KbughxaSNP314wsD8ZXJPp3Soo+Pqc7FY9n2FyRmVt9j5aFUMPPz+eDIe50n8eFC+eVcC4c66I0m6mrf3rEvfOKToSV1ufZ4YitZXsTn2A5C3qSq++G6q4k9bo4wSrMBPvNSTsGtKsBPyBQuLAMov+3FgNhdwbBTRBGE46re7I17ewA/ZMIwsM35tgk+R5oXW5gglQ1w5M4TaUnwxXVpr9CxkxTj/LZlvEXTRqyY4RkTinNhdSbt+1pRJVtT4QfNhTD52vsxT/4rfFRtcaAOGbTQFNgVhPMtIauzwfh8Gy1xzNvhVx/ubesjTzxf312mblZdmPAweS2Cm46tWQYXEvIENTdREhooHFmnqNWQqYDGOaJG/3N/cmxU7odovZMH2BHUafsGNWw1kJwydnDFnH0F6vccu5L/ItKncqiKDbwOGkpR7942LqINC/G8C0Uy4ajKZaMzm23pLWphNs9rgP1zW9rdTijl5jVL3AWxSfhq3FPYTgDsRinkMvdUitAesd5AFt9Y+13ztwCwhJ6BagJAqkU3xGQp8Aki2jtixirenRFkAjf5AEbv/cJCoWP5iJ2ZVUDfYowd+0qYOOPL7PfgbmjMAacgA/n6o8H3awRmJQFJfuqUZL/QktDGIFuwQ==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(2616005)(64756008)(38100700002)(66476007)(66446008)(76116006)(66556008)(8676002)(122000001)(66946007)(91956017)(86362001)(31686004)(38070700005)(36756003)(31696002)(2906002)(8936002)(54906003)(186003)(5660300002)(83380400001)(71200400001)(6486002)(508600001)(26005)(53546011)(55236004)(6506007)(6512007)(316002)(6916009)(4326008)(2004002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?OWFNRG5MNXkzZ2lwa1FpYjRHRXZvbGxxK1AvMXFpZDBCT2IxUkRuMVV6dnFL?=
 =?utf-8?B?MmRMd2dUeThSMTNkQXBZcDFlOFBLSUVQaTU3ZXNCWndXVjRKUGozOGl1RXlR?=
 =?utf-8?B?dzBqeEVQZEpYVDR2bFpySUtZWkhhRDZ3UHFpY2JLNTZxNHRlTXFUN1puaWg0?=
 =?utf-8?B?clBYcTFjUmhJVXI1U0p6RmNvRUZOMHAxaDZlTG9hN1ZIZ0k3YS93MGVrZFhh?=
 =?utf-8?B?aEZwQTVyN2JscUtBc2huV0ZrZkdNUmg5YnM3ZjVDVkNqUm5WZytPZXM5T1Fp?=
 =?utf-8?B?MlorM2F5QmRSN1c0YXhJS0p6bmRpTnhFWTFDU0RHc2ZCVHlUY2ZtU3I5blAv?=
 =?utf-8?B?N0NCYStSYStEcTZMRW82OVk4WW5TVEExcDlHV2tKcTYvZzU5ajB5NXJMQlND?=
 =?utf-8?B?TVFGeVpzZWtmS1pWaEVLSE1Bb3hnNitNMG5wVktqUDJSZjNUWFVtWGZERyts?=
 =?utf-8?B?WUVrYXUvV3UzTndKQ00rbkVHdDJ5OVNZbngySjRsQllUcWJIRlIzN01TaWE4?=
 =?utf-8?B?OWx0ZVNoaWt4VmRvM0poL1k5TkJIRnhJQ3loeUgxRGlKVjF1bHJtYkp0eVFh?=
 =?utf-8?B?cVdLUEdQanlqbmNlcnJURC9hOS9NVDRGbWUvRjhLZW9ndVB0clpRK2ZsanVy?=
 =?utf-8?B?a3U4WXJhazZZdTNLWjlrbm05MVdhMFBkVnFPelRCdTZWYzAvTEZpdDdmaU9M?=
 =?utf-8?B?V2FDMGxEWFdnMWswdWRtL1NTTnJQRHV6b0dlczNhT2V3MmdkeUVmQk53RFNE?=
 =?utf-8?B?enpmallsZStaTmhOWHU0V3NYdDRiUC82cDkxOXF5R0tPTWQwczVPZDN5Z1dM?=
 =?utf-8?B?S2E4T3FPK3JWZmFVZDR0aXRWZmNadldLTTZGOG9ST0JUcG1RbUducEdFSis4?=
 =?utf-8?B?eU9BVWszaDI4NTlTSERRVnk4KzBuSXBjOXZnbWJLbXZCL2lyNm1HMTloejJ6?=
 =?utf-8?B?NFV0WHdLYmowR1lObTJySmJLdjVyTy9aQ0NJd3hCaXpWM3NBZ1ZscG8yS3ZI?=
 =?utf-8?B?TnNhQkZzMW03UG04Z0tMd2g5V3BjSkpNTmJnaGExdFU3a2QwU3hNTGdOQ2Vz?=
 =?utf-8?B?S3ZJWEdMYkRyTmhmeTF4dXdBREJiR01Bb2lNc0UzdEtzODhFSFAvMmw4Q21p?=
 =?utf-8?B?aFZ3MS9YS2NrZ3JPMm1TaUVoZUZmMk0rWFk0K1ViUTRMTVdNUlZvUXVlSXJ6?=
 =?utf-8?B?UVdzL3RSam95c29YOC90OW9zYXNlQzhVQUdYajI1cEUwb3RhNXloOFp1dklN?=
 =?utf-8?B?ejZQMlA2MUNET3BhQnpQQnp5K0REZFlOLzhJTjEyM1hnVTIxZ3Y5Yi9kMFl1?=
 =?utf-8?B?R1Z2Mmk2YmxSV0FBaVlHNHZJTlVDd0hSS3VDemNsdFlYOWxTOEF3OVlNU3Bh?=
 =?utf-8?B?Nk9HSmRFNmM3ZmZQMUkrQ05pUVNkcUpnQnNXenR3MmJSZ3NtSWc0Mm5GM0RP?=
 =?utf-8?B?MUdLbzZIOW1hQ213VW51cXVINDBtNnk3ZzZXL015SzFyc01mN1FpYXBqckQ0?=
 =?utf-8?B?NnRqQ2dHdkRCS0JweCtNS1IyY2swSHd4dlRTY3FBUkpWTW5oU1dXSUZTc0gy?=
 =?utf-8?B?WUp5a0VUZ0t1b1RwUHJBak9TdnJPcVFtdzI3bkN3TXgwTGQ5dUVHYkpoc3Bj?=
 =?utf-8?B?WTQ0VFRPd0I5RDVTcEc5UlNYWXVGaGFXSUgwb1d5UXR1OFZ5d2p4ZEFEcmp6?=
 =?utf-8?B?TzQzUU5FdWx6NWFVc2JkUmVPOGNGMmcvd1p2c29SK3JrWms5VjMrcytmMjN0?=
 =?utf-8?B?NXpSZnJpcDJwZUlobE5lSU1KSHlyTmFKMkxRbitlcUJXQlBzNWNzdmsrdXZr?=
 =?utf-8?B?Zlp6a3Z5STR4Y1p3cWVqQVVjUW9ORWxjdXJYZGxWM3g1SDV5UzZjaHlwTWFR?=
 =?utf-8?B?dk9JYks3YXNCZERmRHdpMTBIbUtxUGRaRFNqekcvNTBVRGVWa2FjdElMdnJ2?=
 =?utf-8?B?bmc1VXhXRTh1YzRySDl1VHZFS1BVbEZ2S1ZmOFQrZWhibkRmLytpcFpRTE0r?=
 =?utf-8?B?Q3hMR29Gbko0WUlKamxvT1dDK0RneTlGVjJQek55a2tydmkzTUdKNXNISzly?=
 =?utf-8?B?Mm5hOWJzdHNaMHNkZFdWZVNLR1FnaWFTaElmSmJRY3czSTc1L1drT0dBMUZK?=
 =?utf-8?B?dGQ3U213N1lMb1owU3ZJZWx4YmdwRjBMTlJSczZ2UDh5aUUrYXMzcmhDUUR5?=
 =?utf-8?B?NWRVN2NMMHkxaHVqTkJobWVOR2ZlVytnZVB5SXFSdjBJK3N5TlRaQjc1bUUx?=
 =?utf-8?B?MzM5Nk9SNjFnZm5nWXd1bzZNWHBZWFlhYk5LT0tTQ2ZpZHNUT0szMkZJNng5?=
 =?utf-8?B?ZGpHMzg0VDhyVnJ3aStvbVBjS3I1VVljQzhCTytRdDFnWTVCN3pQUT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <264AC9453FBE894FBCBB1FD27703AD0A@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d0db4dae-8db1-4c63-859c-08d9f0768957
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Feb 2022 11:30:15.0188
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: xn3quL2K3H80CIashF32AZWJPbG5uUkTZmh9Dt28e3Qsy1GXKM3dyZoBmobENeIrcrD88uDQE81jPjbDt8v8O+M8fDliN8kUZCtgHmZCq41yfXE00HpzQOh5g59Uf3iU
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB4081
X-Proofpoint-GUID: 3MCS6p1MoAcvUFJaS2pc4iR8GtLV6Ho9
X-Proofpoint-ORIG-GUID: 3MCS6p1MoAcvUFJaS2pc4iR8GtLV6Ho9
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-15_04,2022-02-14_04,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 mlxlogscore=999
 phishscore=0 malwarescore=0 adultscore=0 lowpriorityscore=0
 priorityscore=1501 suspectscore=0 impostorscore=0 spamscore=0
 clxscore=1011 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202150065

QW50aG9ueSwgY291bGQgeW91IHBsZWFzZSB0YWtlIGEgbG9vaz8NCg0KVGhhbmsgeW91IGluIGFk
dmFuY2UsDQpPbGVrc2FuZHINCg0KT24gMTAuMTIuMjEgMTQ6MzUsIE9sZWtzYW5kciBBbmRydXNo
Y2hlbmtvIHdyb3RlOg0KPiBGcm9tOiBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyA8b2xla3NhbmRy
X2FuZHJ1c2hjaGVua29AZXBhbS5jb20+DQo+DQo+IHZjaGFuIHNlcnZlciBjcmVhdGVzIFhlblN0
b3JlIGVudHJpZXMgdG8gYWR2ZXJ0aXNlIGl0cyBldmVudCBjaGFubmVsIGFuZA0KPiByaW5nLCBi
dXQgdGhvc2UgYXJlIG5vdCByZW1vdmVkIGFmdGVyIHRoZSBzZXJ2ZXIgcXVpdHMuDQo+IEFkZCBh
ZGRpdGlvbmFsIGNsZWFudXAgc3RlcCwgc28gdGhvc2UgYXJlIHJlbW92ZWQsIHNvIGNsaWVudHMg
ZG8gbm90IHRyeQ0KPiB0byBjb25uZWN0IHRvIGEgbm9uLWV4aXN0aW5nIHNlcnZlci4NCj4NCj4g
U2lnbmVkLW9mZi1ieTogT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gPG9sZWtzYW5kcl9hbmRydXNo
Y2hlbmtvQGVwYW0uY29tPg0KPiAtLS0NCj4gICB0b29scy9pbmNsdWRlL2xpYnhlbnZjaGFuLmgg
fCAgNSArKysrKw0KPiAgIHRvb2xzL2xpYnMvdmNoYW4vaW5pdC5jICAgICB8IDIzICsrKysrKysr
KysrKysrKysrKysrKysrDQo+ICAgdG9vbHMvbGlicy92Y2hhbi9pby5jICAgICAgIHwgIDQgKysr
Kw0KPiAgIHRvb2xzL2xpYnMvdmNoYW4vdmNoYW4uaCAgICB8IDMxICsrKysrKysrKysrKysrKysr
KysrKysrKysrKysrKysNCj4gICA0IGZpbGVzIGNoYW5nZWQsIDYzIGluc2VydGlvbnMoKykNCj4g
ICBjcmVhdGUgbW9kZSAxMDA2NDQgdG9vbHMvbGlicy92Y2hhbi92Y2hhbi5oDQo+DQo+IGRpZmYg
LS1naXQgYS90b29scy9pbmNsdWRlL2xpYnhlbnZjaGFuLmggYi90b29scy9pbmNsdWRlL2xpYnhl
bnZjaGFuLmgNCj4gaW5kZXggZDYwMTBiMTQ1ZGYyLi4zMGNjNzNjZjk3ZTMgMTAwNjQ0DQo+IC0t
LSBhL3Rvb2xzL2luY2x1ZGUvbGlieGVudmNoYW4uaA0KPiArKysgYi90b29scy9pbmNsdWRlL2xp
YnhlbnZjaGFuLmgNCj4gQEAgLTg2LDYgKzg2LDExIEBAIHN0cnVjdCBsaWJ4ZW52Y2hhbiB7DQo+
ICAgCWludCBibG9ja2luZzoxOw0KPiAgIAkvKiBjb21tdW5pY2F0aW9uIHJpbmdzICovDQo+ICAg
CXN0cnVjdCBsaWJ4ZW52Y2hhbl9yaW5nIHJlYWQsIHdyaXRlOw0KPiArCS8qKg0KPiArCSAqIEJh
c2UgeGVuc3RvcmUgcGF0aCBmb3Igc3RvcmluZyByaW5nL2V2ZW50IGRhdGEgdXNlZCBieSB0aGUg
c2VydmVyDQo+ICsJICogZHVyaW5nIGNsZWFudXAuDQo+ICsJICogKi8NCj4gKwljaGFyICp4c19w
YXRoOw0KPiAgIH07DQo+ICAgDQo+ICAgLyoqDQo+IGRpZmYgLS1naXQgYS90b29scy9saWJzL3Zj
aGFuL2luaXQuYyBiL3Rvb2xzL2xpYnMvdmNoYW4vaW5pdC5jDQo+IGluZGV4IGM4NTEwZTZjZTk4
YS4uYzZiODY3NGVmNTQxIDEwMDY0NA0KPiAtLS0gYS90b29scy9saWJzL3ZjaGFuL2luaXQuYw0K
PiArKysgYi90b29scy9saWJzL3ZjaGFuL2luaXQuYw0KPiBAQCAtNDYsNiArNDYsOCBAQA0KPiAg
ICNpbmNsdWRlIDx4ZW4vc3lzL2dudGRldi5oPg0KPiAgICNpbmNsdWRlIDxsaWJ4ZW52Y2hhbi5o
Pg0KPiAgIA0KPiArI2luY2x1ZGUgInZjaGFuLmgiDQo+ICsNCj4gICAjaWZuZGVmIFBBR0VfU0hJ
RlQNCj4gICAjZGVmaW5lIFBBR0VfU0hJRlQgMTINCj4gICAjZW5kaWYNCj4gQEAgLTI1MSw2ICsy
NTMsMTAgQEAgc3RhdGljIGludCBpbml0X3hzX3NydihzdHJ1Y3QgbGlieGVudmNoYW4gKmN0cmws
IGludCBkb21haW4sIGNvbnN0IGNoYXIqIHhzX2Jhc2UNCj4gICAJY2hhciByZWZbMTZdOw0KPiAg
IAljaGFyKiBkb21pZF9zdHIgPSBOVUxMOw0KPiAgIAl4c190cmFuc2FjdGlvbl90IHhzX3RyYW5z
ID0gWEJUX05VTEw7DQo+ICsNCj4gKwkvLyBzdG9yZSB0aGUgYmFzZSBwYXRoIHNvIHdlIGNhbiBj
bGVhbiB1cCBvbiBzZXJ2ZXIgY2xvc3VyZQ0KPiArCWN0cmwtPnhzX3BhdGggPSBzdHJkdXAoeHNf
YmFzZSk7DQo+ICsNCj4gICAJeHMgPSB4c19vcGVuKDApOw0KPiAgIAlpZiAoIXhzKQ0KPiAgIAkJ
Z290byBmYWlsOw0KPiBAQCAtMjk4LDYgKzMwNCwyMyBAQCByZXRyeV90cmFuc2FjdGlvbjoNCj4g
ICAJcmV0dXJuIHJldDsNCj4gICB9DQo+ICAgDQo+ICt2b2lkIGNsb3NlX3hzX3NydihzdHJ1Y3Qg
bGlieGVudmNoYW4gKmN0cmwpDQo+ICt7DQo+ICsJc3RydWN0IHhzX2hhbmRsZSAqeHM7DQo+ICsN
Cj4gKwlpZiAoIWN0cmwtPnhzX3BhdGgpDQo+ICsJCXJldHVybjsNCj4gKw0KPiArCXhzID0geHNf
b3BlbigwKTsNCj4gKwlpZiAoIXhzKQ0KPiArCQlnb3RvIGZhaWw7DQo+ICsNCj4gKwl4c19ybSh4
cywgWEJUX05VTEwsIGN0cmwtPnhzX3BhdGgpOw0KPiArDQo+ICtmYWlsOg0KPiArCWZyZWUoY3Ry
bC0+eHNfcGF0aCk7DQo+ICt9DQo+ICsNCj4gICBzdGF0aWMgaW50IG1pbl9vcmRlcihzaXplX3Qg
c2l6KQ0KPiAgIHsNCj4gICAJaW50IHJ2ID0gUEFHRV9TSElGVDsNCj4gZGlmZiAtLWdpdCBhL3Rv
b2xzL2xpYnMvdmNoYW4vaW8uYyBiL3Rvb2xzL2xpYnMvdmNoYW4vaW8uYw0KPiBpbmRleCBkYTMw
M2ZiYzAxY2EuLjFmMjAxYWQ1NTRmMiAxMDA2NDQNCj4gLS0tIGEvdG9vbHMvbGlicy92Y2hhbi9p
by5jDQo+ICsrKyBiL3Rvb2xzL2xpYnMvdmNoYW4vaW8uYw0KPiBAQCAtNDAsNiArNDAsOCBAQA0K
PiAgICNpbmNsdWRlIDx4ZW5jdHJsLmg+DQo+ICAgI2luY2x1ZGUgPGxpYnhlbnZjaGFuLmg+DQo+
ICAgDQo+ICsjaW5jbHVkZSAidmNoYW4uaCINCj4gKw0KPiAgICNpZm5kZWYgUEFHRV9TSElGVA0K
PiAgICNkZWZpbmUgUEFHRV9TSElGVCAxMg0KPiAgICNlbmRpZg0KPiBAQCAtMzg0LDUgKzM4Niw3
IEBAIHZvaWQgbGlieGVudmNoYW5fY2xvc2Uoc3RydWN0IGxpYnhlbnZjaGFuICpjdHJsKQ0KPiAg
IAkJaWYgKGN0cmwtPmdudHRhYikNCj4gICAJCQl4ZW5nbnR0YWJfY2xvc2UoY3RybC0+Z250dGFi
KTsNCj4gICAJfQ0KPiArCWlmIChjdHJsLT5pc19zZXJ2ZXIpDQo+ICsJCWNsb3NlX3hzX3Nydihj
dHJsKTsNCj4gICAJZnJlZShjdHJsKTsNCj4gICB9DQo+IGRpZmYgLS1naXQgYS90b29scy9saWJz
L3ZjaGFuL3ZjaGFuLmggYi90b29scy9saWJzL3ZjaGFuL3ZjaGFuLmgNCj4gbmV3IGZpbGUgbW9k
ZSAxMDA2NDQNCj4gaW5kZXggMDAwMDAwMDAwMDAwLi42MjEwMTZlZjQyZTUNCj4gLS0tIC9kZXYv
bnVsbA0KPiArKysgYi90b29scy9saWJzL3ZjaGFuL3ZjaGFuLmgNCj4gQEAgLTAsMCArMSwzMSBA
QA0KPiArLyoqDQo+ICsgKiBAZmlsZQ0KPiArICogQHNlY3Rpb24gQVVUSE9SUw0KPiArICoNCj4g
KyAqIENvcHlyaWdodCAoQykgMjAyMSBFUEFNIFN5c3RlbXMgSW5jLg0KPiArICoNCj4gKyAqIEBz
ZWN0aW9uIExJQ0VOU0UNCj4gKyAqDQo+ICsgKiAgVGhpcyBsaWJyYXJ5IGlzIGZyZWUgc29mdHdh
cmU7IHlvdSBjYW4gcmVkaXN0cmlidXRlIGl0IGFuZC9vcg0KPiArICogIG1vZGlmeSBpdCB1bmRl
ciB0aGUgdGVybXMgb2YgdGhlIEdOVSBMZXNzZXIgR2VuZXJhbCBQdWJsaWMNCj4gKyAqICBMaWNl
bnNlIGFzIHB1Ymxpc2hlZCBieSB0aGUgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uOyBlaXRoZXIN
Cj4gKyAqICB2ZXJzaW9uIDIuMSBvZiB0aGUgTGljZW5zZSwgb3IgKGF0IHlvdXIgb3B0aW9uKSBh
bnkgbGF0ZXIgdmVyc2lvbi4NCj4gKyAqDQo+ICsgKiAgVGhpcyBsaWJyYXJ5IGlzIGRpc3RyaWJ1
dGVkIGluIHRoZSBob3BlIHRoYXQgaXQgd2lsbCBiZSB1c2VmdWwsDQo+ICsgKiAgYnV0IFdJVEhP
VVQgQU5ZIFdBUlJBTlRZOyB3aXRob3V0IGV2ZW4gdGhlIGltcGxpZWQgd2FycmFudHkgb2YNCj4g
KyAqICBNRVJDSEFOVEFCSUxJVFkgb3IgRklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSIFBVUlBPU0Uu
ICBTZWUgdGhlIEdOVQ0KPiArICogIExlc3NlciBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGZvciBt
b3JlIGRldGFpbHMuDQo+ICsgKg0KPiArICogIFlvdSBzaG91bGQgaGF2ZSByZWNlaXZlZCBhIGNv
cHkgb2YgdGhlIEdOVSBMZXNzZXIgR2VuZXJhbCBQdWJsaWMNCj4gKyAqICBMaWNlbnNlIGFsb25n
IHdpdGggdGhpcyBsaWJyYXJ5OyBJZiBub3QsIHNlZSA8aHR0cDovL3d3dy5nbnUub3JnL2xpY2Vu
c2VzLz4uDQo+ICsgKg0KPiArICogQHNlY3Rpb24gREVTQ1JJUFRJT04NCj4gKyAqDQo+ICsgKiAg
VGhpcyBmaWxlIGNvbnRhaW5zIGNvbW1vbiBsaWJ4ZW52Y2hhbiBkZWNsYXJhdGlvbnMuDQo+ICsg
Ki8NCj4gKyNpZm5kZWYgTElCVkNIQU5fSA0KPiArI2RlZmluZSBMSUJWQ0hBTl9IDQo+ICsNCj4g
K3ZvaWQgY2xvc2VfeHNfc3J2KHN0cnVjdCBsaWJ4ZW52Y2hhbiAqY3RybCk7DQo+ICsNCj4gKyNl
bmRpZiAvKiBMSUJWQ0hBTl9IICovDQo=


From xen-devel-bounces@lists.xenproject.org Tue Feb 15 11:39:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 11:39:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273062.468112 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJwBP-000486-C5; Tue, 15 Feb 2022 11:39:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273062.468112; Tue, 15 Feb 2022 11:39:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJwBP-00047z-8v; Tue, 15 Feb 2022 11:39:47 +0000
Received: by outflank-mailman (input) for mailman id 273062;
 Tue, 15 Feb 2022 11:39:45 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=vySV=S6=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nJwBN-00047t-2r
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 11:39:45 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f6a4e2f2-8e53-11ec-8eb8-a37418f5ba1a;
 Tue, 15 Feb 2022 12:39:43 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f6a4e2f2-8e53-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644925183;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=b9Zb2AIRk3432QZbm3gTgbK7cxVzH1UzfbjbtiJ+KUM=;
  b=OZAFTWDxTBp3IFhV4eNjzGJqDGdsvQP/lparg0V+onTJ7WrVYlOmrRFB
   ZQcv0W8bFKd1Wg37KWU0fjK4TKOaKlk2xGe9xOkfYtEJ0MwzykTD6OxhC
   ydfOrL06ScmuziUStEtuaSmrSPPPs/8W7QYuw4ocOUK0SSr00dG90KlF7
   w=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: ApMsiIAStKa0/G+hG3CGxy750D7lPymXhNp5kM61EPn3/vchRXL7kSIMmADuhpyxv1eJYHPaj6
 +FSajBBGUBhm2P2gQjf2DCiCD7sjBddEd+xkpr/ntH9PEj9pRBPJaXAk6iGESq3nNZfH5IJouc
 ZVT/7kkFFlmn8y1jPlcCk4Y4J9KEBqnDH7KDucCLpOIWPKVPD5SSN98EjMwaBg2XjYJEFXECFa
 Zk5lhNdS8Dpcl1mya4DJprnt3PkpyTGfZNzdOnH1jCqnvRTj9HJT+G29dFzaDa9AbafHXpM+gu
 5ZrACyA8zJ0c7wFHa5skKcIe
X-SBRS: 5.1
X-MesageID: 66462108
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:AMRbRKu+vSv1X9DIcMOrbDyxSOfnVF5YMUV32f8akzHdYApBsoF/q
 tZmKWjQaKmLYjSkeo1xOY2woBhQv8fUmtU1HVBvqHgyFiMb+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZQP0VOZigHtIQMsadUsxKbVIiGHdJZS5LwbZj2NYy2IXhWWthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 NpltrGXcER3ALDwpL4sSDBpTy15Eo1B5+qSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DJoQQt2sm1TjEJf0nXYrCU+PB4towMDIY2J4SQ6yHP
 5pxhTxHNQ/gWzhGZk0tJZM0gtinlGXTKm1FkQfAzUYwyzeKl1EguFT3C/LrfdiNSdRQj1yvj
 GvM9GTkATkXLNWajzGC9xqEoevCnjjyXo4II4Gp7f5hgFCVxWs7BQUfUB2wpvzRomekR99aH
 GkF9SMvoLYa+VSiS5/2WBjQiGSNvgMYHcFRFeI6wAiXz+zf5APxLmIJVCJbYdoq8so/XyU31
 0ShlsnsQzdotdW9WX+bs7uZsz62ESwUNnMZIz8JSxMf5Nvuq511iQjAJv5EFKO2ldTzFSvH6
 jaGtjUlh74TgMgI0I225VnCxTmro/DhTAQ4+wHWVWKN9R5iaciuYInAwUPA8f9KIYKdT1+Al
 HsJgc6T6KYJF57lvC6QROQAGpm56vDDNyfT6WODBLF4qW7roST6O9kNvncufy+FL/roZxfqT
 Wjq+l1v+aNvZkqxRJ4rb4WeK8M1mP2I+cveatjYad9HY55UfQCB/T1zaUP4410BgHTAgolkZ
 87FLJ/E4WIyTP0+kWHoH7t1PaoDm3hmrV4/U6wX2PhOPVC2QHeOAYkIP1KVBgzSxPPV+V6Fm
 zqz2ibj9vm+bAEcSnSNmWLwBQpTRZTeOXwRg5YJHtNv2iI8RAkc5wb5mNvNgbBNkaVPjfvv9
 XqgQEJew1eXrSSZdVnVOiA+Neu2BswXQZcH0csEZwjA5pTeSdz3sPd3m2UfIdHLC9CPPdYrF
 qJYKq1s89xESyjd+iR1UHUOhNcKSfhfvirXZ3DNSGFmJ/ZIHlWVkve5LlqH3HRfVUKf6Jphy
 4BMIyuGGPLvsSw5V52IAB9upnvs1UUgdBVaBhCWfIALIR+0r+CH6UXZ15cKHi3FEj2arhOy3
 AeKGxYI4+7Lpo4+6t7Sgq6Y6YyuFoND8oByQwE3NJ66anvX+HSN24hFXLradDzRTjqsqq6je
 f9U37f3N/hexARGtI91ErBKy6Mi5oSw++8Gn1o8RHibPU62Dr5AI2Wd2ZUdvKN62bIE6xC9X
 ViC+4cGNOzRat/lClMYOCEscv+HiaMPgjDX4PlseBf66SZ78aCpS0JXOxXQ2iVRIKEsaNEuw
 Ps7ud5Q4Au600J4PtGDhyFS1mKNMn1fDPl36sBEWNfm01N5xEtDbJrQDj7NzKuOM9gcYFM3J
 jK0hbbZg+gOzET1bHduR2PG2vBQhMpStUkSnkMCPVmAhvHMmuQzgE9K6T0yQwlYkkdH3uZ0N
 jQ5PkF5P/zTrTJhhcwFVGGwAQBRQhae/xWpmVcOkWTYSWiuV3DMczJhabrcohhB/jIOZCVf8
 ZGZ1H3hAGTjc8zG1ycvXVJo9q74Rttr+wyewM2qEqxpxXXhjeYJVkN2WVc1lg==
IronPort-HdrOrdr: A9a23:E+yarqxZRHUuNyQFcOWIKrPxtOskLtp133Aq2lEZdPULSKOlfp
 GV8MjziyWYtN9wYhAdcdDpAtjmfZr5z+8O3WB3B8beYOCGghrSEGgG1+XfKlLbak/DH4JmpM
 Jdmu1FeaHN5DtB/LfHCWuDYq8dKbC8mcjC74eurEuFDzsaE52Ihz0JdDpzeXcGIjWua6BJcK
 Z1saF81kWdkDksH4+GL0hAe9KGi8zAlZrgbxJDLxk76DOWhTftzLLhCRCX0joXTjsKmN4ZgC
 X4uj28wp/mn+Cwyxfa2WOWx5NKmOH5wt8GIMCXkMAaJhjllw7tToV8XL+puiwzvYiUmRwXue
 iJhy1lE9V46nvXcG3wiRzx2zP42DJr0HPmwU/wuwqUneXJABYBT+ZRj4NQdRXUr2A6ustn7a
 5N12WF87JKEBLphk3Glpb1fiAvsnDxjWspkOYVgXAae5AZcqVtoYsW+14QOIscHRj99JssHI
 BVfY7hDc5tABOnhk3izypSKITGZAVwIv7GeDlPhiWt6UkWoJgjpHFogfD2nR87heUAotd/lq
 D5259T5cJzp/ktHNZA7dc6MLuK41P2MGDx2UKpUB3a/fI8SjrwQ6Ce2sRB2AjtQu1O8KcP
X-IronPort-AV: E=Sophos;i="5.88,370,1635220800"; 
   d="scan'208";a="66462108"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Db9oXkxLMixTr4fd4bkFUTCtMVxpHJt1MgRErMtCp3FVD8cN4e4wyr6ewSnpzadSCDvUHaUuUnJPTbtyMUAdtXDv6cbLKYowBPSFhXQVGHYRmqodFX04Am9XDtp7MaEGEDhsbE7NyhhctOKhRQmvs16zckaY9W3Uz4c39qgHMZtWbzxZi8RON7Gia8sKXEmggtdn3NQ+6Si097i0ikqoYc/1MHNl3OZyO4ByMcla3YRyBWXI5TbqzB9jcIQXgUMdyCIWxwU5UV3yV+qhYMhnTaHr1FT5lqBJGcW4d2qXtXFvDJo3VaWQrOmDJsd9EfcKUMyfPXaqVZ16nDZ57W4XLw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=OHohejBKFp1uIYSaKF+87manGwACtmUZAC6ONm0/1J8=;
 b=GINDLA+5InJ7mmI6lCUjd0IEDMEllK3COrkQN6l4UbimSRVH+1P47PwsJ7+aZulmeLKfSkid9i+vqA0V/6pDtX9UfYk4UidqxmDLLtvF2EntqVMB9VdF1BLxfClnEMNzgsabGgcyd6sVmi1yx5Sd6Mjoe+Z7B7lAHsG9TdWXkZKti11zMLRGoM27JucbsuLYlxZDxIev+bnRAf8x6w1oEFCBTRUTfbslcWWG0J4HTbpvO08y6jkgoec213ji5cD/PFgQyCocdit1MH/4HajfuDScqGSi0DhkeoEeyiTOqTwzW8IsL16sWtbBjQMSRVykQ04tSOkGXbzpbti5H7Wq3Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=OHohejBKFp1uIYSaKF+87manGwACtmUZAC6ONm0/1J8=;
 b=Scv9dmH/q5o9Y2tS43uOJzbBzWsDeCaToF4xoWXwet47bTDMH79jSwG157bg13LvCrXJdwslb8h4NM4qlAWqPVm+JIzIKN3BLKiBVHEWQ9WWnO3c3Zoj+9Ca2ZFISQjswXK1JjSSF2sJnqG5NnVzDnigCaJIff3e0gKofYpeBhY=
Date: Tue, 15 Feb 2022 12:39:31 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"jbeulich@suse.com" <jbeulich@suse.com>, "julien@xen.org" <julien@xen.org>,
	"sstabellini@kernel.org" <sstabellini@kernel.org>, Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Artem Mygaiev <Artem_Mygaiev@epam.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>, Rahul Singh
	<rahul.singh@arm.com>
Subject: Re: [PATCH v2] vpci: introduce per-domain lock to protect vpci
 structure
Message-ID: <YguQ8wfhfYFXTWSU@Air-de-Roger>
References: <20220215081135.1497470-1-andr2000@gmail.com>
 <YguE7RWOteSnvVNY@Air-de-Roger>
 <c5b9b02c-93f8-d018-6048-9abf2e7de4dc@epam.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <c5b9b02c-93f8-d018-6048-9abf2e7de4dc@epam.com>
X-ClientProxiedBy: LO2P123CA0023.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:a6::35) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e5ebf36e-30c2-4ae4-cb45-08d9f077d7b7
X-MS-TrafficTypeDiagnostic: CY4PR03MB3030:EE_
X-Microsoft-Antispam-PRVS: <CY4PR03MB30306819710D83C8E856AAEA8F349@CY4PR03MB3030.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: JM+wfecFrBvW7T5oXMlP0r13lv1aoPvelTyaNR+oYPcqA/+nGNDS1dCon57f9rAreCaGIp7DCpCpijjrf9UHYsQlkWKMAwgBohunJa8/nTkABOHfGHPhi8IpJiPYNh/jyN3/NGxcu7JPG9QC7twqzJsrIft8fmAyv2t+sdLTjNZ7QV3r6fXSPrdJb6avAKgSGyBdgXfOUyNGKsEt3fyRlqVEEasCp5U6ZG3QrdfGOBzAfrTT/hnRLlUbWZqmMQRa+TanscAAuHppLHQKvvKmKLYhk+iIyuUq66PdvsL7Vmzd6cACsO55af8Ow0za2RqnP/fgXC8JD4o3KkRJDpIYx2OIRr427QXPQ77WkSZL7uoacAvpw6SwVfj9GdvEfYIliOGe2bGJJvKlOAupY9uYs/URRq4Y7bzadzDIEUxeWDMGb55Sth9GWEbba9Zek6lOGhxeO0+4929Jbwyht1kGOwfotfIDf3CyEYtQcJplZ5KJEQ559w7JFD2UTD0Zzme3yuFPWeO9FKZyky4pAVyt/+GNl4QXeo6uni5c457QxkGW2vWIP9TKAAsQ1y3c++6V2OeevzfKGGOzfGKHGUXUNaKV2PaZFTzS3JGsgrXhMkU50AjMZABwuOZmeHPfFE+462hXaU6hgR+658v4Z6TnIw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(508600001)(82960400001)(86362001)(9686003)(83380400001)(33716001)(26005)(186003)(6512007)(8676002)(6486002)(316002)(2906002)(53546011)(7416002)(85182001)(54906003)(6916009)(5660300002)(8936002)(66556008)(4326008)(66476007)(38100700002)(6506007)(6666004)(66946007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Ykd4SVcvcUJLZmFHajZQaEFUWENCSEd3UTF3UnlFTklwaUtlYnNta2dGR0lz?=
 =?utf-8?B?QmtlNkxadDJ5UUVRR1puQzJPYXFDVWFtRmI5ZzBPMVZmbjJhOXpYTDBmTXZ3?=
 =?utf-8?B?M1hJZWZLSkpJRFFSckhqMDVhZUlzZGJGSXZ0bHVteXBVWUJpeWE1WVRkQUFt?=
 =?utf-8?B?dU1PVnJrdzlzM0d0YmNQNVRlbFkzTTRIWTlrUVVvVWpvV3JleUFQclhnVi9m?=
 =?utf-8?B?ZjNwNDFHVU9EQTNuRGRqZitKaXJFZnoxN2ZUeStSUkVxZkIrSkVBNitaK1Vy?=
 =?utf-8?B?eHZkYk55NVN0YjdkMGhYTHpXbWc2Q24vUnE2QWNmbjEva1QvNk9OTzJZaThp?=
 =?utf-8?B?M1doYWhsOU1nRG01QysyZmYwcUhUQ1oxNlF1TXFhSEhCdG5KRHhCTnVoVExZ?=
 =?utf-8?B?MWs1LzBpZjNiM0R6UnhxUW0zT0xDK3UzamVQR0tVSm9pYmFIRGtEMm9UdVZR?=
 =?utf-8?B?aVBpemw1a290Q29GUkg1UVlJUE8xQmxkZEQwejlzbE1UNkpnMThTRVAwK29M?=
 =?utf-8?B?Y3hjYzFqSlRzVE1CQ3MyaVQvbzljY0dZNU9uOFdTYk1Dcm9QYUZvOFNLTFNH?=
 =?utf-8?B?SUk4QXAxRDkvb2NxdGp2SkE0UWZUcWtxNzNwd21ackw5eDBxS0VTTGVIUExS?=
 =?utf-8?B?SFVKZ2ZCS1lUM2JKQzhOSlJRdm9HV1gwOGVKZnZFSkZUK2JuNEpuMlhsNWN2?=
 =?utf-8?B?eWZUMHRxWXRTNEJCdXRscVljQmtLNkN2YTRTTnBuTnc2dWd5QjdLN3JqZGU5?=
 =?utf-8?B?Q2pKK0ZETFZOVDFSc2VMSklRRGFjOE14WUhER1lGbXJ1T0FTb1FuV3QzU1NV?=
 =?utf-8?B?WDRLVk95RlN4ck5nL0lsN2V0QW8yTDYwbmNuV291NWhFelBHbTBqaXZ0WGhV?=
 =?utf-8?B?QUNINlprTld2T2F3aytLWk9NUnpSUkZhb2VZM2VzNmFYYU5sODVEcjhZOXY4?=
 =?utf-8?B?V0JNdjB6TlNrQmNUNlRLY0cwenlQVHhWNEdVVkdVNy9Tamt2SW83MFdRTTVC?=
 =?utf-8?B?RTRVZDhNcDRTbHdYMHkyQVk2SE9YRnJZWG90enhxdms0UjRsRnAycHdkM3hz?=
 =?utf-8?B?OTlkVk9GYjRET3crNE9vY0txTms2d0ZLVE9QMEdmMElJRU84cXo4QVBKWDEv?=
 =?utf-8?B?MmYxYkYzZ2hLK0NKS2ZDSk9GL0NSZEIwSFlpN0RPaTRra0Z0eUxoV1MwUmU1?=
 =?utf-8?B?Q3ZKN3k1QkhnR1Q2OU1pbmRmWS9FWnMvbVNUNVFpL2VINmlESXpkY3FoVHJM?=
 =?utf-8?B?S25NL2VFbk5XSzEwWHNBNHpCSU12K1lwNU1CT1lKeTAyNFVqM2wzZncwK1Rr?=
 =?utf-8?B?MGw3SW95QUt3cGdDLzFJanhKQkFOQlBEd2thQUE1d2Y1dHZ5ZFdZQXE1QWxt?=
 =?utf-8?B?NldqUkw4ajQ2OEw0VDE0YlZZRmNuWjFua052MHVwcTgza2hMeGRsTzYvaEZW?=
 =?utf-8?B?aU5GMmNtdytjY2tpRVp6MEU1Mi83ejhzYjRNcHVDdWNuREc4MDVNWjFoMkxW?=
 =?utf-8?B?dlV0cVlxRW55bFZaK3pBUzVYaWg0ZGxmMmJrbjdSRkVQdzBTOWxlb2JOVHQw?=
 =?utf-8?B?b213NlVDN1JmMGpMcE94dWg3VVEwSGlhMDlHYW13VkhjeEV6OGtUeFhxdFZR?=
 =?utf-8?B?d3Z1NVRZcFM0NXAwZTJPTXQvT0RPc0lHSGdQditkdzR4b0p5ZWplNnJzK3NR?=
 =?utf-8?B?MmhiNDQrMGZVTUlLYjNOMks5TWdWYncwYnFuUnJkbGxDZ3czcm5qZm5PQjIr?=
 =?utf-8?B?cGVlc015Y00xSUlkNm5hcEhRSmd2Y3pmNWRJdmNYb1BOWHZjNmhJZVpHdDAx?=
 =?utf-8?B?QTdENUs4TkVkMnQwNEw3UEZQRUNyMm1CQ2tvTUVFS0lmMmhTNUs1bDBrZWJn?=
 =?utf-8?B?Wmp5SWRob2Y5ajdxU0pQb0VwckY2blFHbjhzRC9SejJmS3d1b2U0Z2R4UEpS?=
 =?utf-8?B?bkVwMzVqQjNadkZHYXFWSWs4MlFUcXF0MzNlTWRRdi9FamUxWWNHNksyaUtO?=
 =?utf-8?B?ZlJFNDVyazU3THRZVVRuUWJheWIzbUxyZXNDei9YY2tlUVdRZmdhZ0pmU2E2?=
 =?utf-8?B?MzliQXNLNDJhcVMrK3lwWW8zT0tkZVFxeUdpQkhwRmR6aWRCNE9LbHlJYUFI?=
 =?utf-8?B?RDdzRHhxUWg3dXVSbDFCNGc2R3lHMm95MHIrSFlaTWdXSkJXalBYM3A1dVBn?=
 =?utf-8?Q?GrDTf2wEWw7rpd3vJad2t44=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e5ebf36e-30c2-4ae4-cb45-08d9f077d7b7
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 11:39:36.2431
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2uNKZrtXudglwwLcPEdWC2mu4oBg4xivAXQHTzyluXaTclyui5/g/gSqy8/UV9EtLUwKCCZ838WnMUS0v8Jz9w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR03MB3030
X-OriginatorOrg: citrix.com

On Tue, Feb 15, 2022 at 11:12:23AM +0000, Oleksandr Andrushchenko wrote:
> 
> 
> On 15.02.22 12:48, Roger Pau Monné wrote:
> > On Tue, Feb 15, 2022 at 10:11:35AM +0200, Oleksandr Andrushchenko wrote:
> >> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> >>
> >> Introduce a per-domain read/write lock to check whether vpci is present,
> >> so we are sure there are no accesses to the contents of the vpci struct
> >> if not. This lock can be used (and in a few cases is used right away)
> >> so that vpci removal can be performed while holding the lock in write
> >> mode. Previously such removal could race with vpci_read for example.
> >>
> >> 1. Per-domain's vpci_rwlock is used to protect pdev->vpci structure
> >> from being removed.
> >>
> >> 2. Writing the command register and ROM BAR register may trigger
> >> modify_bars to run, which in turn may access multiple pdevs while
> >> checking for the existing BAR's overlap. The overlapping check, if done
> >> under the read lock, requires vpci->lock to be acquired on both devices
> >> being compared, which may produce a deadlock. It is not possible to
> >> upgrade read lock to write lock in such a case. So, in order to prevent
> >> the deadlock, check which registers are going to be written and acquire
> >> the lock in the appropriate mode from the beginning.
> >>
> >> All other code, which doesn't lead to pdev->vpci destruction and does not
> >> access multiple pdevs at the same time, can still use a combination of the
> >> read lock and pdev->vpci->lock.
> >>
> >> 3. Optimize if ROM BAR write lock required detection by caching offset
> >> of the ROM BAR register in vpci->header->rom_reg which depends on
> >> header's type.
> >>
> >> 4. Reduce locked region in vpci_remove_device as it is now possible
> >> to set pdev->vpci to NULL early right after the write lock is acquired.
> >>
> >> 5. Reduce locked region in vpci_add_handlers as it is possible to
> >> initialize many more fields of the struct vpci before assigning it to
> >> pdev->vpci.
> >>
> >> 6. vpci_{add|remove}_register are required to be called with the write lock
> >> held, but it is not feasible to add an assert there as it requires
> >> struct domain to be passed for that. So, add a comment about this requirement
> >> to these and other functions with the equivalent constraints.
> >>
> >> 7. Drop const qualifier where the new rwlock is used and this is appropriate.
> >>
> >> 8. Do not call process_pending_softirqs with any locks held. For that unlock
> >> prior the call and re-acquire the locks after. After re-acquiring the
> >> lock there is no need to check if pdev->vpci exists:
> >>   - in apply_map because of the context it is called (no race condition
> >>     possible)
> >>   - for MSI/MSI-X debug code because it is called at the end of
> >>     pdev->vpci access and no further access to pdev->vpci is made
> >>
> >> 9. Check for !pdev->vpci in vpci_{read|write} after acquiring the lock
> >> and if so, allow reading or writing the hardware register directly. This is
> >> acceptable as we only deal with Dom0 as of now. Once DomU support is
> >> added the write will need to be ignored and read return all 0's for the
> >> guests, while Dom0 can still access the registers directly.
> >>
> >> 10. Introduce pcidevs_trylock, so there is a possibility to try locking
> >> the pcidev's lock.
> >>
> >> 11. Use pcidev's lock around for_each_pdev and pci_get_pdev_by_domain
> >> while accessing pdevs in vpci code.
> > So if you use the pcidevs_lock then it's impossible for the pdev or
> > pdev->vpci to be removed or recreated, as the pcidevs lock protects
> > any device operations (add, remove, assign, deassign).
> >
> > It's however not OK to use the pcidevs lock in vpci_{read,write}
> > as-is, as the introduced contention is IMO not acceptable.
> >
> > The only viable option I see here is to:
> >
> >   1. Make the pcidevs lock a rwlock: switch current callers to take the
> >      lock in write mode, detect and fixup any issues that could arise
> >      from the lock not being recursive anymore.
> >   2. Take the lock in read mode around vpci_{read,write} sections that
> >      rely on pdev (including the handlers).
> >
> > These items should be at least two separate patches. Let's not mix the
> > conversion of pcidevs locks with the addition of vPCI support.
> >
> > I think with that we could get away without requiring a per-domain
> > rwlock? Just doing lock ordering in modify_bars regarding
> > tmp->vpci->lock vs pdev->vpci->lock. Neither pdev or vpci can go away
> > while holding the pcidevs lock.
> >
> > Sorting the situation in modify_bars should also be done as a separate
> > patch on top of 1. and 2.
> So, to make it crystal clear: we can do with the locking as in this
> patch and instead we need to convert pcidevs lock into rwlock.
> Meaning that I need to drop this patch.
> 
> Then, 3 patches to follow:
> 1. pcidevs as rwlock
> 2. vpci_{read|write} and the rest using new pcidevs rwlock
> 3. lock ordering in modify_bars
> 
> Is it what we want?

Likely? The current approach of the per-domain rwlock still leaves us
with a window between pci_get_pdev_by_domain and taking such lock
where the device could be removed.

We also need a safe way to use pci_get_pdev_by_domain without the
devices being removed while using them, so it would seem we need the
pcidevs lock anyway, in which case it seems possible to avoid having
to introduce a per-domain rwlock.

I'm happy with any approach that solves the issues we have at hand,
but this proposal has a fundamental flaw of leaving a window after
pci_get_pdev_by_domain where the device could be removed. I'm OK to
have this fixed in a different way if there's one, but if the pcidevs
lock is used in vpci_{read,write} it needs to be converted into a
rwlock.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Feb 15 11:45:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 11:45:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273069.468123 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJwGq-0005YL-0g; Tue, 15 Feb 2022 11:45:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273069.468123; Tue, 15 Feb 2022 11:45:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJwGp-0005YE-T0; Tue, 15 Feb 2022 11:45:23 +0000
Received: by outflank-mailman (input) for mailman id 273069;
 Tue, 15 Feb 2022 11:45:22 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=xOiq=S6=epam.com=prvs=4045782cdb=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nJwGo-0005Y7-MT
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 11:45:22 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c06122aa-8e54-11ec-8eb8-a37418f5ba1a;
 Tue, 15 Feb 2022 12:45:21 +0100 (CET)
Received: from pps.filterd (m0174676.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 21FBbBuV021881;
 Tue, 15 Feb 2022 11:45:16 GMT
Received: from eur05-db8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2111.outbound.protection.outlook.com [104.47.17.111])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e89njgend-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Tue, 15 Feb 2022 11:45:16 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by VI1PR03MB4301.eurprd03.prod.outlook.com (2603:10a6:803:5e::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.18; Tue, 15 Feb
 2022 11:45:11 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::fc4d:4749:5d1:eb73]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::fc4d:4749:5d1:eb73%4]) with mapi id 15.20.4975.019; Tue, 15 Feb 2022
 11:45:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c06122aa-8e54-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=J2Rgt8WY0KM4Y/5kVd5Hd5q1vONmD5/0c92w4bYjwEgVsQ/5FQyr44mXc1YzJr4o3usm3CwGzTvSYVESbBjltICFCu7h0JgF8D+skW8BFTb+qHkE2Z2EYZHTK2KFOiNhOEpry8zWLB/gYT/n845oauj8B+IWOek6ZUxfXV9DW7HriZkMHFVYsASWaqHotRAAY1oLC7B376urmBoAJ4vxAn4vy+p0pmT+p2LoDLUOcSJ9N6Hv4JP7aFc3zLXIz94zqg43l1gC3LhQFSlTE5BO+N7XnyBBKi/02eNmJvacQ1llr2S+zx+/rRp5g96o3DrGqdD+yX40jh7D2zq3Z7NJ/Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=6guLOEroULM9IKHWLhN0puwOFHN5Z3jUhE3Y1oJbSyM=;
 b=U+H0HxojelU1ZIIPt0wpvjhHc7Qe8dAY6QNfSyVbKBKRFDcvceOVNKoLvJMwsquQ4Dqyhr63PWQqHGqP/ycxb/4ljGo0f6wc40N+UNHZnfKUJPwA24uFowU7yrRyLSOIoolmiJjE8Ul9fRAmODP+IA9FIMSxvmYRw6xswpFZGBuyAZwBxiJJ4Ns5g6SAKwfqsdEIk+7zVQd31YtwWBiG+lcZBKZ56653VJBlSDTF29XeZIQRzMTkdpChXi1dbnjepX+L/2C3oT9uBr3XSK9ETeLpqTd6rn+61wJnTAhuBlJMhGbizKALtDriSAaHfmFHW1a1e5c1LWV7E3zqrcbVFw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=6guLOEroULM9IKHWLhN0puwOFHN5Z3jUhE3Y1oJbSyM=;
 b=Fa4ThfGTC2wxGZU2FAxq7WXH3LK0L4fS7sXcWlmkwe0A7ysECxmuZcE4a7/jO9t3wSP7ebH2abeF90R7nzR4g6StFW70/yQPVWuStSP/z9WRa3BfJB3rbwmRsTW6gAWKmlbQCExa1SSdWgn60HPvYMInNHf0D9wb2OuYrMqLj+F2PYsEMPYx+CCm9p9r+pIlMkLbS/MZQSupMv+k0IJxqUOh7NYO9Te9tfm8AflupgpneN6D1vQPq75KwbMrPNdPcr3A3w2nmr1y8ofvzQYiSncyr3hUt/lq7EjdwLZ40jWDGqYI6OHC+QzKMp7gaP+3oann0NHExfk9m8x9SgOK/g==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "jbeulich@suse.com" <jbeulich@suse.com>,
        "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org" <sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>,
        Rahul Singh <rahul.singh@arm.com>
Subject: Re: [PATCH v2] vpci: introduce per-domain lock to protect vpci
 structure
Thread-Topic: [PATCH v2] vpci: introduce per-domain lock to protect vpci
 structure
Thread-Index: AQHYIkOs9pmsZb0l5kefj1m3qdTVCayUboeAgAAGwYCAAAeVgIAAAZQA
Date: Tue, 15 Feb 2022 11:45:11 +0000
Message-ID: <70dbd7fd-3f74-d0d3-6e30-c1e1e24fc279@epam.com>
References: <20220215081135.1497470-1-andr2000@gmail.com>
 <YguE7RWOteSnvVNY@Air-de-Roger>
 <c5b9b02c-93f8-d018-6048-9abf2e7de4dc@epam.com>
 <YguQ8wfhfYFXTWSU@Air-de-Roger>
In-Reply-To: <YguQ8wfhfYFXTWSU@Air-de-Roger>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 0e19a421-969f-4ba5-96cc-08d9f0789f9e
x-ms-traffictypediagnostic: VI1PR03MB4301:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <VI1PR03MB4301F4E9044315AE9CC7E1DFE7349@VI1PR03MB4301.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 cM6ngiRTuDlN1/WTQcG8OImiRPCjXJu6sUoUzibdwg8Fb9+cTzePQeVzDMXlh2Dt+mz+qG78WoIqqrBs10QMOfePV1cDsHuH4smh/ZiR3MDAsjetKKFLc+FTRIhD3vGZwDKhF2nTQ6Te5q8Wk4UrHUaQ2aM/0tOjGu1H0a6MzfUPgGxULBgzBkIgqt9tixYV5lwpxZgAqmzwL+BYmnCPOWc/p2jY+3i8sAHzpFd7lggtcb5/irpvZyUNMwwIqINzh+1xqayYYF1JFDYBMlBq7rRGZ3uw989jOL+eAYYbposNDyNo8srx2s0ZQGLXpgBhobDeG1LBozcEFxH+/+cChOh0hG+fyO0vOpcAFqpIIqvzAzIlVdHJtioBxvGS1hNCkv/RTH0x2CHo0JTWcYHQeuW3XzrpaTI+LaiA7tvV2hsbZ9f6Cbs2HmniWgjvB+VBAkSvMBhy1aESxJPOJLlkAbhfCMR3LW7zLSdWdS9ntJZsIyaFQ2i57Cy8F9dHA9F9zkphi5XnxQvT5S/lqzz33d+3pN47qwzmF8zjjsk1dE1ZUQfgx0QGm/J5pwhB6/H+iYHWx1haGk84/pAVRFpNG80I4ECK8dlhxu0Mpj4KHz+7IVwQv8wWfVik+lJgr4pR5krn8b+GVu+oF55NXPIWE9e/KENGlZc6H+FU+J9xKrkd41FuRTPsRb4Dle823jdjify4xYBB5tIWsw/URVAWzKixrehfCzZyW1upjzY2HHohj3huValohwrHuqMUkFd4
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(53546011)(4326008)(66556008)(86362001)(55236004)(66946007)(31696002)(6512007)(54906003)(316002)(6916009)(71200400001)(8676002)(6506007)(66446008)(66476007)(64756008)(6486002)(91956017)(76116006)(508600001)(83380400001)(38070700005)(8936002)(26005)(5660300002)(31686004)(122000001)(2906002)(186003)(36756003)(38100700002)(2616005)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?R0g5Z3oybnhheFZaMnExbEYxVG1jMHRUeHJhVks0YmNmeE1MdFpneDkvWUFp?=
 =?utf-8?B?T08wR1RSZ291SW52dm1uMUZiZE1HMG5rM3lncmJyaE1NUjdwWUtyV3h1OEdq?=
 =?utf-8?B?OVhqY2NhNCs4SkM4L3IyRXgrUnFqSndDelFKODZNQjF2Qk1hTmd6aldnMzZx?=
 =?utf-8?B?SGpPbk5NbjZncVIybURwVXVmUjAxeGx6RG9Nd1lKSU4vemwrTkdyd3hTaWNZ?=
 =?utf-8?B?YzJPZEk2QUY3bWdTK0xNTjI1dTNXVE96cEdQSzh1R0tJZllndTFiYU91R1Uy?=
 =?utf-8?B?WTZCcjlIQ1hScTFFK1FLc0U2UDBoUVVRdlZEbFZzcmV4RDIyWlVMT21CeWpK?=
 =?utf-8?B?NHl3MklwMXhaUC9iemhsVlpydDRmVTdsTUNXSWJQSUdRaHVpTlRWemI5VlRr?=
 =?utf-8?B?c2pMTS9Rd0ZIVVZmTGpBZS9ORlVMZ1BDU3g4YnFRQ1p0SmVqRFNHTXV2OTNz?=
 =?utf-8?B?eU1PNGxEZ2RIRWpqdDJPSk44TGpaanpNajF3cWFmWEVMVEM2NVIvN3NnWTBG?=
 =?utf-8?B?aWtUSWVnTFdoT0tYMGdxanduaVhoc1pRNGNLSy9ORTRRSVEwSFB3OEkxSUVC?=
 =?utf-8?B?N3hMVVdYY1pmZ3Y0aXJvclpudWxZbzBIRjc3b0dPNVZJa2VQd1h5UjV0OFFB?=
 =?utf-8?B?OHZMajcwMHJKS0ZqR0JCMUNZc2pOMEdER1l1djRoa3VPRUtDNTEvZ21CMlh4?=
 =?utf-8?B?aWtMemJzcDRLMy90UlRSNEtBclR5YXlrcVFRRVpMOUJvYWk5dytkT09RYkU4?=
 =?utf-8?B?RTk1VGxHbVRxNnU0OG50eEhTRzhGN3o2Ykd2cUwwWWU1STlQeUNUZDlLTWF4?=
 =?utf-8?B?MURPYjJ6anRkYWFzTE9jSVB5KzU0a1F3WTdaMVQ2WDBvSWxyMlgwS1lObVNW?=
 =?utf-8?B?U2tqZ2szY0xydnBRQ2dCdHJMWEZNRWFpV29VM0VtTWZ5VUdCL2p2YytmV2d6?=
 =?utf-8?B?TlBiMVI5M2hVeHRhMEFmemJrRWdTNnM0ajBWSE5jb1pXS1l0ejFWVDM4UjJl?=
 =?utf-8?B?U3dJMEhmT3BDSENYWWs4d2dHb0xiQjVadnVtMTJmY2RVYU9SaHZiY2djTVlq?=
 =?utf-8?B?WFJDQitNSHBhSEoyVTNkL2l2QjRBcm5XdWlqalp0b3dRZGdFSmFrdFZFV1c0?=
 =?utf-8?B?TVFGMEp4R3pXMlprbXYxZ01wZThnRE1Tc0F2SjNqbjVZbnlSU2R1Y3ZOb21l?=
 =?utf-8?B?Zno5ZVlDakFYYzMveEdtbFBpUXhwMndMMXdYOXVzcUFHQVNyOFhVcXlWQzBC?=
 =?utf-8?B?Nks1TU9CUXhLSlVoMzNpVjU3azhGUlE5TlcxVUswMG9nUnJGUjE5b0N1UkdK?=
 =?utf-8?B?c3FXZW1YZE0xbzVnTzg4aFZ5LzdQcTVUVGZDQTJXQzlWSG5zakdsdVpBTHlu?=
 =?utf-8?B?cVpvakN1Q1JjaHpTOEQxWVcwKzRVU2llbUx5NDJaVG1lQ2hyaVQ4WFZ2R2dP?=
 =?utf-8?B?T05nTzVwZ1JBS1hDWTRxcVdWbU5aZG9nY1d1OTZuQVNsT00rWjhMR0U0QmNW?=
 =?utf-8?B?YXlBOXowWDRkOGVyYzhuaDdva2xObW5XOTJYc1EzcUUxZEdJZkZDVDJtbjFD?=
 =?utf-8?B?NU5FTDhXUUFyaUdnWDFtTk1MbGROcnV6TTJQNWJIL1VPSXVscXdxWXVyQXJx?=
 =?utf-8?B?cTNqV3RJWktzeG1US1Vkby8yaFpiM2c4YTJjN3FnbWtxcWNzMDlIVjNwMnVU?=
 =?utf-8?B?bEFGTkdQczRaQnZqY3JWOWF1elFCV2xDemRKUjFvVjY4RE51SjNwdmp6SVpt?=
 =?utf-8?B?cTlZb3NPcklNMVU2WDB2Wjd0MmptWmNPdHVSa0lzdS8xc0VNWkVsZ2xKL3Jy?=
 =?utf-8?B?MWtYcWp5QXYyRWlNbnhnVFpFdEJWNXNXTVhaYWQrb1N4TEZRUTFKSzllQU5s?=
 =?utf-8?B?QjkvMndiM0pKVEJaYjF3Nm9weFVyQ1c0eXRXNHdlc1NMODZWUDE5OWFndm5M?=
 =?utf-8?B?cW14cnZOeTNvTDBOMGhqeHJKTmN5ajNPSEhDaU1Lc0Vpczd1VFQxOGppay84?=
 =?utf-8?B?MllmakM4TTkyUWdZTzdFeDNsMnIzSWh3Q2RuQ1hnT1ZMMkpCQ2hvTUlNWlUx?=
 =?utf-8?B?a0pQekwvSnhWbllHVXpUTll2TGJSY2x0aFJaNEZ5M3FQcStVNG1ORTFjK1Zk?=
 =?utf-8?B?ZTNxeXFkd0NJRFNHZE1ZMGRETEhxQjMwMTBBUzlEcnFUT2hQZ0VuTC8wV0VG?=
 =?utf-8?B?OHpldGxXS3hHS2YzNEhwc3dYR3ZhUnU3S0UvR0VjdGM5VTNxZDM1N3FEaklv?=
 =?utf-8?B?Wkdqd3Jyb2xsRFRvRkJWcFprOHo3V2w0YUY2UXlnV0lKMWpQUHo1cENDeFhC?=
 =?utf-8?B?a0F5NGx3aHhsWmFxZGJxTlRZUmQ2VTlCMUZOMGoyYWU5VkRGbjBCTllOYmtZ?=
 =?utf-8?Q?j2fPAPWGvEugwa+4=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <4A9536609D2A014CB07ABBE492005FB4@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0e19a421-969f-4ba5-96cc-08d9f0789f9e
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Feb 2022 11:45:11.2167
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 4pBYawPKTNfaqQxXY5wWvFC0GYTlTqutVK05sb6BSAvHvfA4xY5sq1YooRkwBYLAvNQie8AIOq5KznlZ2e6qKc/LYROwIRYZH5nftq87tiPrRNkCdcdZUE6ljklGU35L
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR03MB4301
X-Proofpoint-ORIG-GUID: ojx-S932iXt1o_4R68xkClRPvOL-kcz9
X-Proofpoint-GUID: ojx-S932iXt1o_4R68xkClRPvOL-kcz9
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-15_04,2022-02-14_04,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501
 malwarescore=0 spamscore=0 impostorscore=0 phishscore=0 adultscore=0
 suspectscore=0 mlxscore=0 mlxlogscore=999 clxscore=1015 bulkscore=0
 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202150066

DQoNCk9uIDE1LjAyLjIyIDEzOjM5LCBSb2dlciBQYXUgTW9ubsOpIHdyb3RlOg0KPiBPbiBUdWUs
IEZlYiAxNSwgMjAyMiBhdCAxMToxMjoyM0FNICswMDAwLCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5r
byB3cm90ZToNCj4+DQo+PiBPbiAxNS4wMi4yMiAxMjo0OCwgUm9nZXIgUGF1IE1vbm7DqSB3cm90
ZToNCj4+PiBPbiBUdWUsIEZlYiAxNSwgMjAyMiBhdCAxMDoxMTozNUFNICswMjAwLCBPbGVrc2Fu
ZHIgQW5kcnVzaGNoZW5rbyB3cm90ZToNCj4+Pj4gRnJvbTogT2xla3NhbmRyIEFuZHJ1c2hjaGVu
a28gPG9sZWtzYW5kcl9hbmRydXNoY2hlbmtvQGVwYW0uY29tPg0KPj4+Pg0KPj4+PiBJbnRyb2R1
Y2UgYSBwZXItZG9tYWluIHJlYWQvd3JpdGUgbG9jayB0byBjaGVjayB3aGV0aGVyIHZwY2kgaXMg
cHJlc2VudCwNCj4+Pj4gc28gd2UgYXJlIHN1cmUgdGhlcmUgYXJlIG5vIGFjY2Vzc2VzIHRvIHRo
ZSBjb250ZW50cyBvZiB0aGUgdnBjaSBzdHJ1Y3QNCj4+Pj4gaWYgbm90LiBUaGlzIGxvY2sgY2Fu
IGJlIHVzZWQgKGFuZCBpbiBhIGZldyBjYXNlcyBpcyB1c2VkIHJpZ2h0IGF3YXkpDQo+Pj4+IHNv
IHRoYXQgdnBjaSByZW1vdmFsIGNhbiBiZSBwZXJmb3JtZWQgd2hpbGUgaG9sZGluZyB0aGUgbG9j
ayBpbiB3cml0ZQ0KPj4+PiBtb2RlLiBQcmV2aW91c2x5IHN1Y2ggcmVtb3ZhbCBjb3VsZCByYWNl
IHdpdGggdnBjaV9yZWFkIGZvciBleGFtcGxlLg0KPj4+Pg0KPj4+PiAxLiBQZXItZG9tYWluJ3Mg
dnBjaV9yd2xvY2sgaXMgdXNlZCB0byBwcm90ZWN0IHBkZXYtPnZwY2kgc3RydWN0dXJlDQo+Pj4+
IGZyb20gYmVpbmcgcmVtb3ZlZC4NCj4+Pj4NCj4+Pj4gMi4gV3JpdGluZyB0aGUgY29tbWFuZCBy
ZWdpc3RlciBhbmQgUk9NIEJBUiByZWdpc3RlciBtYXkgdHJpZ2dlcg0KPj4+PiBtb2RpZnlfYmFy
cyB0byBydW4sIHdoaWNoIGluIHR1cm4gbWF5IGFjY2VzcyBtdWx0aXBsZSBwZGV2cyB3aGlsZQ0K
Pj4+PiBjaGVja2luZyBmb3IgdGhlIGV4aXN0aW5nIEJBUidzIG92ZXJsYXAuIFRoZSBvdmVybGFw
cGluZyBjaGVjaywgaWYgZG9uZQ0KPj4+PiB1bmRlciB0aGUgcmVhZCBsb2NrLCByZXF1aXJlcyB2
cGNpLT5sb2NrIHRvIGJlIGFjcXVpcmVkIG9uIGJvdGggZGV2aWNlcw0KPj4+PiBiZWluZyBjb21w
YXJlZCwgd2hpY2ggbWF5IHByb2R1Y2UgYSBkZWFkbG9jay4gSXQgaXMgbm90IHBvc3NpYmxlIHRv
DQo+Pj4+IHVwZ3JhZGUgcmVhZCBsb2NrIHRvIHdyaXRlIGxvY2sgaW4gc3VjaCBhIGNhc2UuIFNv
LCBpbiBvcmRlciB0byBwcmV2ZW50DQo+Pj4+IHRoZSBkZWFkbG9jaywgY2hlY2sgd2hpY2ggcmVn
aXN0ZXJzIGFyZSBnb2luZyB0byBiZSB3cml0dGVuIGFuZCBhY3F1aXJlDQo+Pj4+IHRoZSBsb2Nr
IGluIHRoZSBhcHByb3ByaWF0ZSBtb2RlIGZyb20gdGhlIGJlZ2lubmluZy4NCj4+Pj4NCj4+Pj4g
QWxsIG90aGVyIGNvZGUsIHdoaWNoIGRvZXNuJ3QgbGVhZCB0byBwZGV2LT52cGNpIGRlc3RydWN0
aW9uIGFuZCBkb2VzIG5vdA0KPj4+PiBhY2Nlc3MgbXVsdGlwbGUgcGRldnMgYXQgdGhlIHNhbWUg
dGltZSwgY2FuIHN0aWxsIHVzZSBhIGNvbWJpbmF0aW9uIG9mIHRoZQ0KPj4+PiByZWFkIGxvY2sg
YW5kIHBkZXYtPnZwY2ktPmxvY2suDQo+Pj4+DQo+Pj4+IDMuIE9wdGltaXplIGlmIFJPTSBCQVIg
d3JpdGUgbG9jayByZXF1aXJlZCBkZXRlY3Rpb24gYnkgY2FjaGluZyBvZmZzZXQNCj4+Pj4gb2Yg
dGhlIFJPTSBCQVIgcmVnaXN0ZXIgaW4gdnBjaS0+aGVhZGVyLT5yb21fcmVnIHdoaWNoIGRlcGVu
ZHMgb24NCj4+Pj4gaGVhZGVyJ3MgdHlwZS4NCj4+Pj4NCj4+Pj4gNC4gUmVkdWNlIGxvY2tlZCBy
ZWdpb24gaW4gdnBjaV9yZW1vdmVfZGV2aWNlIGFzIGl0IGlzIG5vdyBwb3NzaWJsZQ0KPj4+PiB0
byBzZXQgcGRldi0+dnBjaSB0byBOVUxMIGVhcmx5IHJpZ2h0IGFmdGVyIHRoZSB3cml0ZSBsb2Nr
IGlzIGFjcXVpcmVkLg0KPj4+Pg0KPj4+PiA1LiBSZWR1Y2UgbG9ja2VkIHJlZ2lvbiBpbiB2cGNp
X2FkZF9oYW5kbGVycyBhcyBpdCBpcyBwb3NzaWJsZSB0bw0KPj4+PiBpbml0aWFsaXplIG1hbnkg
bW9yZSBmaWVsZHMgb2YgdGhlIHN0cnVjdCB2cGNpIGJlZm9yZSBhc3NpZ25pbmcgaXQgdG8NCj4+
Pj4gcGRldi0+dnBjaS4NCj4+Pj4NCj4+Pj4gNi4gdnBjaV97YWRkfHJlbW92ZX1fcmVnaXN0ZXIg
YXJlIHJlcXVpcmVkIHRvIGJlIGNhbGxlZCB3aXRoIHRoZSB3cml0ZSBsb2NrDQo+Pj4+IGhlbGQs
IGJ1dCBpdCBpcyBub3QgZmVhc2libGUgdG8gYWRkIGFuIGFzc2VydCB0aGVyZSBhcyBpdCByZXF1
aXJlcw0KPj4+PiBzdHJ1Y3QgZG9tYWluIHRvIGJlIHBhc3NlZCBmb3IgdGhhdC4gU28sIGFkZCBh
IGNvbW1lbnQgYWJvdXQgdGhpcyByZXF1aXJlbWVudA0KPj4+PiB0byB0aGVzZSBhbmQgb3RoZXIg
ZnVuY3Rpb25zIHdpdGggdGhlIGVxdWl2YWxlbnQgY29uc3RyYWludHMuDQo+Pj4+DQo+Pj4+IDcu
IERyb3AgY29uc3QgcXVhbGlmaWVyIHdoZXJlIHRoZSBuZXcgcndsb2NrIGlzIHVzZWQgYW5kIHRo
aXMgaXMgYXBwcm9wcmlhdGUuDQo+Pj4+DQo+Pj4+IDguIERvIG5vdCBjYWxsIHByb2Nlc3NfcGVu
ZGluZ19zb2Z0aXJxcyB3aXRoIGFueSBsb2NrcyBoZWxkLiBGb3IgdGhhdCB1bmxvY2sNCj4+Pj4g
cHJpb3IgdGhlIGNhbGwgYW5kIHJlLWFjcXVpcmUgdGhlIGxvY2tzIGFmdGVyLiBBZnRlciByZS1h
Y3F1aXJpbmcgdGhlDQo+Pj4+IGxvY2sgdGhlcmUgaXMgbm8gbmVlZCB0byBjaGVjayBpZiBwZGV2
LT52cGNpIGV4aXN0czoNCj4+Pj4gICAgLSBpbiBhcHBseV9tYXAgYmVjYXVzZSBvZiB0aGUgY29u
dGV4dCBpdCBpcyBjYWxsZWQgKG5vIHJhY2UgY29uZGl0aW9uDQo+Pj4+ICAgICAgcG9zc2libGUp
DQo+Pj4+ICAgIC0gZm9yIE1TSS9NU0ktWCBkZWJ1ZyBjb2RlIGJlY2F1c2UgaXQgaXMgY2FsbGVk
IGF0IHRoZSBlbmQgb2YNCj4+Pj4gICAgICBwZGV2LT52cGNpIGFjY2VzcyBhbmQgbm8gZnVydGhl
ciBhY2Nlc3MgdG8gcGRldi0+dnBjaSBpcyBtYWRlDQo+Pj4+DQo+Pj4+IDkuIENoZWNrIGZvciAh
cGRldi0+dnBjaSBpbiB2cGNpX3tyZWFkfHdyaXRlfSBhZnRlciBhY3F1aXJpbmcgdGhlIGxvY2sN
Cj4+Pj4gYW5kIGlmIHNvLCBhbGxvdyByZWFkaW5nIG9yIHdyaXRpbmcgdGhlIGhhcmR3YXJlIHJl
Z2lzdGVyIGRpcmVjdGx5LiBUaGlzIGlzDQo+Pj4+IGFjY2VwdGFibGUgYXMgd2Ugb25seSBkZWFs
IHdpdGggRG9tMCBhcyBvZiBub3cuIE9uY2UgRG9tVSBzdXBwb3J0IGlzDQo+Pj4+IGFkZGVkIHRo
ZSB3cml0ZSB3aWxsIG5lZWQgdG8gYmUgaWdub3JlZCBhbmQgcmVhZCByZXR1cm4gYWxsIDAncyBm
b3IgdGhlDQo+Pj4+IGd1ZXN0cywgd2hpbGUgRG9tMCBjYW4gc3RpbGwgYWNjZXNzIHRoZSByZWdp
c3RlcnMgZGlyZWN0bHkuDQo+Pj4+DQo+Pj4+IDEwLiBJbnRyb2R1Y2UgcGNpZGV2c190cnlsb2Nr
LCBzbyB0aGVyZSBpcyBhIHBvc3NpYmlsaXR5IHRvIHRyeSBsb2NraW5nDQo+Pj4+IHRoZSBwY2lk
ZXYncyBsb2NrLg0KPj4+Pg0KPj4+PiAxMS4gVXNlIHBjaWRldidzIGxvY2sgYXJvdW5kIGZvcl9l
YWNoX3BkZXYgYW5kIHBjaV9nZXRfcGRldl9ieV9kb21haW4NCj4+Pj4gd2hpbGUgYWNjZXNzaW5n
IHBkZXZzIGluIHZwY2kgY29kZS4NCj4+PiBTbyBpZiB5b3UgdXNlIHRoZSBwY2lkZXZzX2xvY2sg
dGhlbiBpdCdzIGltcG9zc2libGUgZm9yIHRoZSBwZGV2IG9yDQo+Pj4gcGRldi0+dnBjaSB0byBi
ZSByZW1vdmVkIG9yIHJlY3JlYXRlZCwgYXMgdGhlIHBjaWRldnMgbG9jayBwcm90ZWN0cw0KPj4+
IGFueSBkZXZpY2Ugb3BlcmF0aW9ucyAoYWRkLCByZW1vdmUsIGFzc2lnbiwgZGVhc3NpZ24pLg0K
Pj4+DQo+Pj4gSXQncyBob3dldmVyIG5vdCBPSyB0byB1c2UgdGhlIHBjaWRldnMgbG9jayBpbiB2
cGNpX3tyZWFkLHdyaXRlfQ0KPj4+IGFzLWlzLCBhcyB0aGUgaW50cm9kdWNlZCBjb250ZW50aW9u
IGlzIElNTyBub3QgYWNjZXB0YWJsZS4NCj4+Pg0KPj4+IFRoZSBvbmx5IHZpYWJsZSBvcHRpb24g
SSBzZWUgaGVyZSBpcyB0bzoNCj4+Pg0KPj4+ICAgIDEuIE1ha2UgdGhlIHBjaWRldnMgbG9jayBh
IHJ3bG9jazogc3dpdGNoIGN1cnJlbnQgY2FsbGVycyB0byB0YWtlIHRoZQ0KPj4+ICAgICAgIGxv
Y2sgaW4gd3JpdGUgbW9kZSwgZGV0ZWN0IGFuZCBmaXh1cCBhbnkgaXNzdWVzIHRoYXQgY291bGQg
YXJpc2UNCj4+PiAgICAgICBmcm9tIHRoZSBsb2NrIG5vdCBiZWluZyByZWN1cnNpdmUgYW55bW9y
ZS4NCj4+PiAgICAyLiBUYWtlIHRoZSBsb2NrIGluIHJlYWQgbW9kZSBhcm91bmQgdnBjaV97cmVh
ZCx3cml0ZX0gc2VjdGlvbnMgdGhhdA0KPj4+ICAgICAgIHJlbHkgb24gcGRldiAoaW5jbHVkaW5n
IHRoZSBoYW5kbGVycykuDQo+Pj4NCj4+PiBUaGVzZSBpdGVtcyBzaG91bGQgYmUgYXQgbGVhc3Qg
dHdvIHNlcGFyYXRlIHBhdGNoZXMuIExldCdzIG5vdCBtaXggdGhlDQo+Pj4gY29udmVyc2lvbiBv
ZiBwY2lkZXZzIGxvY2tzIHdpdGggdGhlIGFkZGl0aW9uIG9mIHZQQ0kgc3VwcG9ydC4NCj4+Pg0K
Pj4+IEkgdGhpbmsgd2l0aCB0aGF0IHdlIGNvdWxkIGdldCBhd2F5IHdpdGhvdXQgcmVxdWlyaW5n
IGEgcGVyLWRvbWFpbg0KPj4+IHJ3bG9jaz8gSnVzdCBkb2luZyBsb2NrIG9yZGVyaW5nIGluIG1v
ZGlmeV9iYXJzIHJlZ2FyZGluZw0KPj4+IHRtcC0+dnBjaS0+bG9jayB2cyBwZGV2LT52cGNpLT5s
b2NrLiBOZWl0aGVyIHBkZXYgb3IgdnBjaSBjYW4gZ28gYXdheQ0KPj4+IHdoaWxlIGhvbGRpbmcg
dGhlIHBjaWRldnMgbG9jay4NCj4+Pg0KPj4+IFNvcnRpbmcgdGhlIHNpdHVhdGlvbiBpbiBtb2Rp
ZnlfYmFycyBzaG91bGQgYWxzbyBiZSBkb25lIGFzIGEgc2VwYXJhdGUNCj4+PiBwYXRjaCBvbiB0
b3Agb2YgMS4gYW5kIDIuDQo+PiBTbywgdG8gbWFrZSBpdCBjcnlzdGFsIGNsZWFyOiB3ZSBjYW4g
ZG8gd2l0aCB0aGUgbG9ja2luZyBhcyBpbiB0aGlzDQo+PiBwYXRjaCBhbmQgaW5zdGVhZCB3ZSBu
ZWVkIHRvIGNvbnZlcnQgcGNpZGV2cyBsb2NrIGludG8gcndsb2NrLg0KPj4gTWVhbmluZyB0aGF0
IEkgbmVlZCB0byBkcm9wIHRoaXMgcGF0Y2guDQo+Pg0KPj4gVGhlbiwgMyBwYXRjaGVzIHRvIGZv
bGxvdzoNCj4+IDEuIHBjaWRldnMgYXMgcndsb2NrDQo+PiAyLiB2cGNpX3tyZWFkfHdyaXRlfSBh
bmQgdGhlIHJlc3QgdXNpbmcgbmV3IHBjaWRldnMgcndsb2NrDQo+PiAzLiBsb2NrIG9yZGVyaW5n
IGluIG1vZGlmeV9iYXJzDQo+Pg0KPj4gSXMgaXQgd2hhdCB3ZSB3YW50Pw0KPiBMaWtlbHk/IFRo
ZSBjdXJyZW50IGFwcHJvYWNoIG9mIHRoZSBwZXItZG9tYWluIHJ3bG9jayBzdGlsbCBsZWF2ZXMg
dXMNCj4gd2l0aCBhIHdpbmRvdyBiZXR3ZWVuIHBjaV9nZXRfcGRldl9ieV9kb21haW4gYW5kIHRh
a2luZyBzdWNoIGxvY2sNCj4gd2hlcmUgdGhlIGRldmljZSBjb3VsZCBiZSByZW1vdmVkLg0KPg0K
PiBXZSBhbHNvIG5lZWQgYSBzYWZlIHdheSB0byB1c2UgcGNpX2dldF9wZGV2X2J5X2RvbWFpbiB3
aXRob3V0IHRoZQ0KPiBkZXZpY2VzIGJlaW5nIHJlbW92ZWQgd2hpbGUgdXNpbmcgdGhlbSwgc28g
aXQgd291bGQgc2VlbSB3ZSBuZWVkIHRoZQ0KPiBwY2lkZXZzIGxvY2sgYW55d2F5LCBpbiB3aGlj
aCBjYXNlIGl0IHNlZW1zIHBvc3NpYmxlIHRvIGF2b2lkIGhhdmluZw0KPiB0byBpbnRyb2R1Y2Ug
YSBwZXItZG9tYWluIHJ3bG9jay4NCj4NCj4gSSdtIGhhcHB5IHdpdGggYW55IGFwcHJvYWNoIHRo
YXQgc29sdmVzIHRoZSBpc3N1ZXMgd2UgaGF2ZSBhdCBoYW5kLA0KPiBidXQgdGhpcyBwcm9wb3Nh
bCBoYXMgYSBmdW5kYW1lbnRhbCBmbGF3IG9mIGxlYXZpbmcgYSB3aW5kb3cgYWZ0ZXINCj4gcGNp
X2dldF9wZGV2X2J5X2RvbWFpbiB3aGVyZSB0aGUgZGV2aWNlIGNvdWxkIGJlIHJlbW92ZWQuIEkn
bSBPSyB0bw0KPiBoYXZlIHRoaXMgZml4ZWQgaW4gYSBkaWZmZXJlbnQgd2F5IGlmIHRoZXJlJ3Mg
b25lLCBidXQgaWYgdGhlIHBjaWRldnMNCj4gbG9jayBpcyB1c2VkIGluIHZwY2lfe3JlYWQsd3Jp
dGV9IGl0IG5lZWRzIHRvIGJlIGNvbnZlcnRlZCBpbnRvIGENCj4gcndsb2NrLg0KSSdtIG9uIHlv
dXIgc2lkZSwgSSBqdXN0IHdhbnQgdG8gaGVhciB0aGF0IHdlIGFsbCBhZ3JlZSBwY2lkZXZzDQpu
ZWVkcyB0byBiZSBjb252ZXJ0ZWQgaW50byByd2xvY2sgYWNjb3JkaW5nIHdpdGggdGhlIHBsYW4g
eW91DQpzdWdnZXN0ZWQgYW5kIGF0IGxlYXN0IG5vdyBpdCBzZWVtcyB0byBiZSBhbiBhY2NlcHRh
YmxlIHNvbHV0aW9uLg0KDQpUaGlzIGlzIGdvaW5nIHRvIGJlIHRoZSAzcmQgYXR0ZW1wdCB0byBt
YWtlIHVwIHRoZSBsb2NraW5nIGFuZA0KaXQgYWxsIHRha2VzIHF1aXRlIHNvbWUgdGltZSwgdW5m
b3J0dW5hdGVseS4uLg0KPg0KPiBUaGFua3MsIFJvZ2VyLg0KPg0KVGhhbmsgeW91LA0KT2xla3Nh
bmRy


From xen-devel-bounces@lists.xenproject.org Tue Feb 15 11:51:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 11:51:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273078.468134 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJwMG-00071m-Ov; Tue, 15 Feb 2022 11:51:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273078.468134; Tue, 15 Feb 2022 11:51:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJwMG-00071f-KJ; Tue, 15 Feb 2022 11:51:00 +0000
Received: by outflank-mailman (input) for mailman id 273078;
 Tue, 15 Feb 2022 11:50:59 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=p95L=S6=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nJwMF-00071Z-F4
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 11:50:59 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8a18af28-8e55-11ec-b215-9bbe72dcb22c;
 Tue, 15 Feb 2022 12:50:58 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2172.outbound.protection.outlook.com [104.47.17.172]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-17-YtUtqz2SNOCekyh5614uKQ-1; Tue, 15 Feb 2022 12:50:56 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AS8PR04MB8962.eurprd04.prod.outlook.com (2603:10a6:20b:42d::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.19; Tue, 15 Feb
 2022 11:50:55 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4975.015; Tue, 15 Feb 2022
 11:50:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8a18af28-8e55-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644925858;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=t3j3LjBOIjJKgkBeEafZZ+4j10yND+CJiSEmZBQ8QXo=;
	b=DaGhEHyodqsskCnMDZWSO5N04m3oIh0lYdzqLcuHIAP6crf+FsaYlABjPY7RUkoRSRZSys
	+257/Zg3namU5cOQRGGwBguEw8FqO1z7H0UNmV2WHQD44NtYWAvT/mGpSBQ/aVaY1ITt0q
	EBNe7PqcEZy1DKBVN4/2M2ZzD1TL+68=
X-MC-Unique: YtUtqz2SNOCekyh5614uKQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=AILOX5iGFArmQMgl91pGxkL2cxF2ZPh0IPU06RcUjXDfWBRJqe4eN1OKsu34OuGxK8a4r4kSO9fCZv6TzZf2lpPi0QqBChfSNcMuQKaOwhY1KdfvK8r/G2CuDEkvHkk1H4WXxmWoBnS3ZvPClgbux8B1ppQllUpen9YkP4PCfgrfubJObl5exGrjRyagCIFDbp3EOhNYeZVJ38yNWi//vQHoPVtfMAhYKZp0Cao2G/n9DLgWlC3DhMxjnZM0Wa3relsqC5uAeYinK0AABXK5SDmFNEp94Bp/+LmQyDwvBsUk3xy6vUTl1LRSJKmX0zPKgqYpI4VtX5EhuPXgKR9WjQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=t3j3LjBOIjJKgkBeEafZZ+4j10yND+CJiSEmZBQ8QXo=;
 b=nTfItv+PUG9gmBoaK/rp1MFz7bOdOvzuuwSt2PfQbS5fH3m7nhHdTNabSOLoz2NKK2ZnGBBy6o5F/sSMRhCdxvpRl/bUlmsr0XD4Lt8fVn8sMm1yJiRza4+qmqiAqJ5yyvpKMf+ztJ8QKLPVPtZ7RBxocPv1b7t4GjfvXE3qLSYkZhOKS/frmvzNlOttQmZyrwS4ME3GhlQUMQdi7QEyyxkyGGEZzaPPkgIdz6QVG2i10wglHBW7PXqcvuPldVj1enlqEC0u9mmUvUiJrbpXsd2CICAyPI+SBnJ6jGPNDJ5+49I8/qJKE7mON3rH+LFvCcM0WH6Ua7j+uzw1r1vPzQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <0d8f01b2-b015-a08e-dd49-e9c688ff7245@suse.com>
Date: Tue, 15 Feb 2022 12:50:52 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH v2] vpci: introduce per-domain lock to protect vpci
 structure
Content-Language: en-US
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "julien@xen.org" <julien@xen.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Artem Mygaiev <Artem_Mygaiev@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>
References: <20220215081135.1497470-1-andr2000@gmail.com>
 <YguE7RWOteSnvVNY@Air-de-Roger>
 <c5b9b02c-93f8-d018-6048-9abf2e7de4dc@epam.com>
 <YguQ8wfhfYFXTWSU@Air-de-Roger>
 <70dbd7fd-3f74-d0d3-6e30-c1e1e24fc279@epam.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <70dbd7fd-3f74-d0d3-6e30-c1e1e24fc279@epam.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR0502CA0046.eurprd05.prod.outlook.com
 (2603:10a6:20b:56::23) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a8713544-45d9-45a3-ec8d-08d9f0796c44
X-MS-TrafficTypeDiagnostic: AS8PR04MB8962:EE_
X-Microsoft-Antispam-PRVS:
	<AS8PR04MB8962E5BFC1B54B8ED0AA7594B3349@AS8PR04MB8962.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7219;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	KzQmelbj/gxdlxeOy1JCsy3+FT0hYA13EM2CYh9XldJq6+bVBqql7PwZV3NTxF1Ppn0lBnHMzKjZxxsKZrl8ifqCeBe7dIhVmSZYGuowZNiAjjjBn+V/mWkjQmc9OiP0J/VU6giPlLvFlkBtUAnYuYo/ZIxb0vHGwovGW6YDGRUsJ+SUGWlY/u3yOLSAE3I3zORqpjCJQ4tP6+o5cpE20uEnJMq/kAh4SPpou6UCU45WaasrN5PQzK3WeuSaBV8uJDczP079wx+4EqRxvIyuFD6oZ+EAZvS9B6sOF43gxT+xHAJNC4hUh35Cww/jCvnWkxl/54IqXIRHrD5KDDhunYpVvvPWdIhuOZJKJsFVcigTapCFCB/mPT99FUicV3bhGuQUOp638HZy7BJn19lnszJAg0PpawR0f8jLT4LUQmW4K4o5JcoGqgbhkgq1ATIXn4hXHXjxZFrBaRfEQ6xhmzsk0jY5UMg4jJZsZUadnLQiU7ExZ/ljs6JOkcQC9/L9cJexwXq81tUwXhLnrUcT47J7h4noE7HVVIKdoGBYGvO4GPVokol7Ak7rML00fc8iGLr4qlbTSfP6a7rEETQOkcId//7/ysHsu+0IP9Psyvt/Q8o9w8InDhtaRAlkByF30v0mDxXgnUE0zuB3jnTB6sPPiIYpebBdbmkM9ZGx8Y8octSTmz7+EymmXlGYbqzUwduC7AkMIkiLnwX7Ew94TPX1M/bpuAnWwrsePE4XbcU=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8936002)(83380400001)(36756003)(31686004)(186003)(2616005)(7416002)(5660300002)(26005)(6512007)(53546011)(6506007)(6486002)(508600001)(66476007)(8676002)(316002)(66556008)(6916009)(31696002)(54906003)(4326008)(4744005)(86362001)(2906002)(66946007)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?OUVaN21WRlFJTzJWRlJOTWxmYUtGOTdySVdDU24zS2ZMRE93UklwZHFqdHg4?=
 =?utf-8?B?Q2FXdlhWcmwySW5UY3Ziazk1cjh1WURjQmJXVk9mRXpxUWt3dzJxNzdSOCs1?=
 =?utf-8?B?SitpaXZKajN3eGhremNaeUpjV0cyR2R2UVI5MUtmMGhoZHAyeDgrT09jbmIw?=
 =?utf-8?B?VmoreHpaV0xDYVp1WXprbkpkM3ZzOUp3OHFnZVg5Uzh1VzIxVTByYjFPdDFG?=
 =?utf-8?B?d3o1bjVEVjQ5MjZNNmtGa2l1bFMrLzVJVTZTY1hSeGswQXFINUhNTzI1WVB0?=
 =?utf-8?B?dzhKSzN6VTF1NWJ2RFd0WDlPYmt5OG5sdXVWSklnNTVsSlNDZnpJQmtJa3dE?=
 =?utf-8?B?dnI4bEdNV094THF1ay8xL1g4b1NteWJCRDdNWmZBQlpLN0RoZ2pQdElIdHZQ?=
 =?utf-8?B?WVM5RENFL0FJY0NGQVFrZzVBTzNOMFYwUlhVTWJ4MHlzeDlvRDZSNWE2MFVT?=
 =?utf-8?B?UnV1RzBwWjVNMXdIWVEwekNPcVVHc0s2anpBbWk2c3pNMVN1emx1d3RUK1BG?=
 =?utf-8?B?V0xrelVIOHQ1Ukl1bkxiMUUzM0ZWd1BDa3NYaTFTRkN5U2EyYzgxZE96d0dJ?=
 =?utf-8?B?QndZOW41amVHTUh1TUFaSkhVWW80TWxRV1BxNzNwL0puS3BuUVF6ZTIvdFhX?=
 =?utf-8?B?KzhJSlNMeUhRNWdncm9RMU5HdFhnd1hEU1RMSFc5WXJEY2FNRUZFM1loWFNU?=
 =?utf-8?B?eHpSZjl0a1hTcVE3Mi9ldnNwWjJQNnZMNnU5L3l1VlB0UkpuSlJDclV1clVH?=
 =?utf-8?B?QTRMbStKS2VVY0t0QVJWY0llRGl4cGh3OC9PRFB2azFyQWJ0M2wxZGVuZ2hZ?=
 =?utf-8?B?WUFCd2YvL2ZtK1g1VklXU0Y4enNXR1hSby95Z3dNUVlFUHFFVmhEdEFqd1Fk?=
 =?utf-8?B?WXBPU0JQR1MrUG5zYmwzaWlESVJueG4zRlZRSklXVnJFVHZrMEtDUmg4QVJZ?=
 =?utf-8?B?aWRDa1k0c0tWaG5mcHJYbWpLbW0rM1prUFNaQU5ESEd2eGg4eEYxVGxNZ01M?=
 =?utf-8?B?VHBOdmRCZUR2ZlgyaGJyQ0JodldHdkNoNkd1aG8vbnJFMnhrSTZtTW81VzM1?=
 =?utf-8?B?eUtmSUxOQzU5Y29yd2VQZ2NpTGE0UWhMVVF2b1FpZ20zcWRReVdaa25XTWNT?=
 =?utf-8?B?N1NxMmszMWJHNENSUHh1ckRtWCt4OGxsdVlBdkUwZDhXYWJNYmFkVk5sVmds?=
 =?utf-8?B?elUzZFF0UlJyaXZWZEVuUW54RG5zc2srMVkveFBFWUN3OUdxQk1rTXlyV1lo?=
 =?utf-8?B?dHJtZ3c3NnJPNnFodEVmR2U4ZU4vU0x4TWIyT1ExdktNQWhTTTV4QUZXSW1h?=
 =?utf-8?B?Y1BmVE90SUZKMy9BSGJRdXluenB3QnNlSTJwYXl6Qm5lR0NXZU9WUE44R0FF?=
 =?utf-8?B?aTVsaTZzTDdweFVtSXR0WmJTVnZJNmJPcnFkNzVScWRoL3E0UE8zTlJJMkZD?=
 =?utf-8?B?UGY2ajZBS3R6eStzSmErbmwraWVqd1JGWmZ5cS9VZDIxY2ppTzZtck1TTHA2?=
 =?utf-8?B?VXN0R1M3eW1mRWFUUWdsVmt0MXZyVWhwSml4VFNWNlU5eTRVeHFDclpmemg2?=
 =?utf-8?B?QWs1dUVielFkT2lPT2hKZy9lMnQrUHptZmV6ZGVveWxqSTJuRUJXY3RkRWo1?=
 =?utf-8?B?U3BHVzQ4TzBkSXRiM0VEc0hqVHhwdlYyVmozQ3NrNU5PN0IxU0RPaXpldHRW?=
 =?utf-8?B?anBPSlhGdjZIdUFLaXZTZWUwYmZSTjJRaGppL0FOdjcvSkpJVGU2cU1ueTM5?=
 =?utf-8?B?QnJVTFpQMVlvbGs3Q1ZmZDBQdWlKeENJVG54QVFKSHBLQ0JLWjJITVBhWm1m?=
 =?utf-8?B?OWU2Vk14aXlxdkFvRmNZV0lKTWZOWkNVcGR4VVVVbHRSaWUxL1lBMEIxODlw?=
 =?utf-8?B?bWh5emlTYk9nYVZJN2k2NnBhMmoyWWJlUXlFOXg2YkhqMHN1ajNzdENrekxn?=
 =?utf-8?B?TUQ2eDU5andHZkJ0T29ObmV4Mi9Ha3g0aG04cUpqbzI4NndOTzRPUGdsTWor?=
 =?utf-8?B?K0NqK2pmWnZ2eVJqdk5zVHlGV2RNcjFyTWw0TW43NG9kNEs4ZEM2QnlOS3hm?=
 =?utf-8?B?TUQ2cDZlY2dTYzQvbUZrWjBJSHROSEtYdVRzd1Z3OVlSZWhLS1BrSVo4SlZY?=
 =?utf-8?B?T0dTYnpYQjlPUTNrQjVnS2dPMTNLazc3cUJPNlgwTDhnVVdGanpHK2JMemNL?=
 =?utf-8?Q?oktipJ7ql5EjpbPFMXa7dpA=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a8713544-45d9-45a3-ec8d-08d9f0796c44
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 11:50:54.9207
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1BtGzbxdtjkRqA1wnpc7eeJ8z2vgRnUX7lTUJsfWbvB1/mf3pvxvFZB+58afGGNQDcoB3kGNeME30J+wEtIrvA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8962

On 15.02.2022 12:45, Oleksandr Andrushchenko wrote:
> I'm on your side, I just want to hear that we all agree pcidevs
> needs to be converted into rwlock according with the plan you
> suggested and at least now it seems to be an acceptable solution.

I'd like to express worries though about the conversion of this
recursive lock into an r/w one.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Feb 15 11:54:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 11:54:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273085.468144 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJwPf-0007dx-7R; Tue, 15 Feb 2022 11:54:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273085.468144; Tue, 15 Feb 2022 11:54:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJwPf-0007dq-4S; Tue, 15 Feb 2022 11:54:31 +0000
Received: by outflank-mailman (input) for mailman id 273085;
 Tue, 15 Feb 2022 11:54:29 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=h622=S6=arm.com=Luca.Fancellu@srs-se1.protection.inumbo.net>)
 id 1nJwPd-0007dj-GW
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 11:54:29 +0000
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur01on061f.outbound.protection.outlook.com
 [2a01:111:f400:fe1e::61f])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 07639aa1-8e56-11ec-b215-9bbe72dcb22c;
 Tue, 15 Feb 2022 12:54:28 +0100 (CET)
Received: from AM6P192CA0040.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:82::17)
 by VI1PR08MB4301.eurprd08.prod.outlook.com (2603:10a6:803:f7::13) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.17; Tue, 15 Feb
 2022 11:54:25 +0000
Received: from VE1EUR03FT017.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:82:cafe::9a) by AM6P192CA0040.outlook.office365.com
 (2603:10a6:209:82::17) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.12 via Frontend
 Transport; Tue, 15 Feb 2022 11:54:25 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT017.mail.protection.outlook.com (10.152.18.90) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4975.11 via Frontend Transport; Tue, 15 Feb 2022 11:54:24 +0000
Received: ("Tessian outbound 741ca6c82739:v113");
 Tue, 15 Feb 2022 11:54:23 +0000
Received: from d445312d71a2.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 327D080A-390F-4CE5-B015-1DA417FC1BE3.1; 
 Tue, 15 Feb 2022 11:54:17 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d445312d71a2.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 15 Feb 2022 11:54:17 +0000
Received: from VI1PR0801MB2125.eurprd08.prod.outlook.com
 (2603:10a6:800:5b::23) by HE1PR0802MB2458.eurprd08.prod.outlook.com
 (2603:10a6:3:de::19) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.17; Tue, 15 Feb
 2022 11:54:11 +0000
Received: from VI1PR0801MB2125.eurprd08.prod.outlook.com
 ([fe80::5531:4c33:a50c:ea0e]) by VI1PR0801MB2125.eurprd08.prod.outlook.com
 ([fe80::5531:4c33:a50c:ea0e%9]) with mapi id 15.20.4975.018; Tue, 15 Feb 2022
 11:54:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 07639aa1-8e56-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=wKcKXhoTx+igdbWMHJsiKM/50GDGJ8kddRW1k4iP5L0=;
 b=mbFLt10xZe+p/Vu7BBffq1R2ZSCZitiWEnQLJ5h9izZlpGkRdp+MXjlu5iQeDzwauRHt5ijIeQ4cL6zYshIOH0a7Qgdg7mX9oy4tRuRDavDJTTjdVXw6TPn3DVNrfzZCjsiqJ0iuDCoOpcCIitNn8clyiKty3Dl9r2iB+yM/GqM=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: e6500358317fef29
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=CGJRKN420fmEnqwGkQaevLuNNLPm+LDsQYt0c4IIOOCaByJtv/19w2cKd0DjwuB3rU39hb7Zc4HhHXiSpLE0hhBVdFZcQsyyLsYDacnq3b/pCEMHEo7pAFwbt1QNpBeK7Uk5Ec6ld7o29O4tqep9Qtt5fkVxg5MtV7NTqY5XDzSVfRnPJC2/GNawUfbn0MtX7O2RpshzY2x7Jl9ysBz6s6tYuM0ou5ORnVMBgPTC3B0eRj1RsooXWeQc9NYTAyNuZkv2jy1IV174N74iptXROj9P5G13mRCeAE++9e8237OQOHEm1ORsAcGznIOvCFFxcmJ8ziYowy/6ZhhSxghSoA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=wKcKXhoTx+igdbWMHJsiKM/50GDGJ8kddRW1k4iP5L0=;
 b=UXc82k/d4dC+Wf18dvtqEQ2GvTNprxAZR5GOvcgAQoKrDnwroLILmeOUswZ3Qur2QOUhVj19YEq1EnY9/Bk1fUauun9fOG+U0u2S4K6hMglP1v6byaA7TOiy4slKHywZvrvw0C5tPc6zhqZIcz5wUxgaqz3v8dA83tQi1ER4oLig2q6yYh78jb8kuhbRQr7TzqWnsafueO56IHfp81hcwJIT01khcCCJfnHmpcvuPrCDTdm4rXqaM5wtpKgrlHIcvEbfSm1PyvSCMig5NHJC4A6Ap1hyM4jMY4F0cBpbLTzUSw08sFoUKCu3vct2YE8VxNmDx/BAUdWZICQ4C7lagw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=wKcKXhoTx+igdbWMHJsiKM/50GDGJ8kddRW1k4iP5L0=;
 b=mbFLt10xZe+p/Vu7BBffq1R2ZSCZitiWEnQLJ5h9izZlpGkRdp+MXjlu5iQeDzwauRHt5ijIeQ4cL6zYshIOH0a7Qgdg7mX9oy4tRuRDavDJTTjdVXw6TPn3DVNrfzZCjsiqJ0iuDCoOpcCIitNn8clyiKty3Dl9r2iB+yM/GqM=
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
Content-Type: text/plain;
	charset=utf-8
Subject: Re: [PATCH] rwlock: remove unneeded subtraction
From: Luca Fancellu <luca.fancellu@arm.com>
In-Reply-To: <20220215093951.97830-1-roger.pau@citrix.com>
Date: Tue, 15 Feb 2022 11:54:07 +0000
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Jan Beulich <jbeulich@suse.com>,
 Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <41CEACA2-9FB7-49C2-B773-01A21ACE8EE0@arm.com>
References: <20220215093951.97830-1-roger.pau@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>
X-Mailer: Apple Mail (2.3693.60.0.1.1)
X-ClientProxiedBy: LO4P265CA0054.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:2ac::10) To VI1PR0801MB2125.eurprd08.prod.outlook.com
 (2603:10a6:800:5b::23)
MIME-Version: 1.0
X-MS-Office365-Filtering-Correlation-Id: 2f0de57e-5bb7-47f5-f605-08d9f079e934
X-MS-TrafficTypeDiagnostic:
	HE1PR0802MB2458:EE_|VE1EUR03FT017:EE_|VI1PR08MB4301:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR08MB43010AF53C1356431C26154CE4349@VI1PR08MB4301.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:7219;OLM:7219;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 PVpjno16z6SrFSH/YUEAeI3Il9dO8owSGpCt1hD0LK5AZxo1BPmm9QgjsyyoyxUJHRUxEcVxYTrgHs20qWwuyu8feGJvdoTn3R9QOWK2nd+lf2DzDpndAVb5JosllmX4pF/N2Sg+5XCB8Yzpk1Jd9wbuI1zw/mienJpv7XVhz8NWz5NesjwT1HmtRHwrVUXzw7LPnPt93uBxS+9ssFODFt0E0OeP7TL/nk45THczVhPCicpxbDWMi1avenpmHYa+vD4QPxJ7WvX83/nZb09jFgx5EI6URrDUJTnvJ2lcKLoWezi6bMMNok11tY201ZvOFSMZdG77ma6OLEoCNwWYm21IyPtSJmkrtYcC3ctIzZedbsaitse2Hwvwscp+7KuYulJof0o7+h8nOZhhRdZZsWocOjJOfoAan4W88DOj+7qgo+cdUn77gz7QCNpfL7fXNDaECRmepIwJCEYG6lWbTs0GNxBbhSOik6dfGGLKTYeQPEJMqv3ILiJgiL5zdMs5TBFKfesF0ApeFx3d7BgXEuyGKik8w2DV+AWMzAVrahjGA9YE/wrOQz6LT0sYGd8edW47LD/IgOPK/50S/i70y0Vf9nuFKOKKeluORwXBAYR5U+nLnWGahbyg7qbbgHo+hK8XGpxMI84sLQG/ntNvznrYtmR7B09wezeQOofg0dQQ1x9AT8tFL6PMVwpxNtMplV69vpTvcA73e3KF6SHiFRmKGAOP/SgfBqd/lzoerAM=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR0801MB2125.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(86362001)(66476007)(38350700002)(83380400001)(66946007)(6486002)(508600001)(66556008)(316002)(54906003)(6916009)(8676002)(4326008)(36756003)(6666004)(2906002)(33656002)(38100700002)(26005)(186003)(5660300002)(6512007)(8936002)(52116002)(6506007)(2616005)(44832011)(53546011)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0802MB2458
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT017.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	b40840a6-a849-4762-96b4-08d9f079e110
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	BdNW+OwcNw56GweX62E2LYvutFLViEAx6u7Z+cO3fIs0/bVFsHzsZmIlTZVAAVFKxvfktJFX45ZWsHuHJ6swlme8tS1+MwVMhRTQyikf0jRwWRXaaq/e4Kz2ZqAxsCqBNMLH8ZUqZ16mz51mHx8WmWhV8Ft4uxloOuP8g43a65bxaRpnN+Y+qwWKgyObY8/gvrJxgMUCU2HK/FO3Opjk4zrZ2QyQXF6EcnMUxh0XLWTNYtsxRJo7CP1aItZVhxgEaM7ys2xykSqIelJodQF5/yLMteyolLJzJVxExQSRZ/UcA6TVg5ygRcLpe2ty31HDn4ABIP9IF71C29l3Jt0P4/L8vZN0vuZOtwSnLfnAYluPR8zVGBPB8hTomEhd845oTlpFsAkLsI4JH/LnEU9Vsv0OGKzrCgx1R7qsTlV1Y3g423U9NPMRvA3o4bsMujqP0MGaS8qMIakJrDwlUyQQsmHE/6WnO6QOIi+0+wl+Zuqnyfw8w3+IAYxpp2xIKq3B0aHNAlxqeauROZXXTLwNWORmm/WlQ1OXYTPWnu1C6N15Iq+05kQfYEtz73m7vGE0qDXlZJBJ+/oW/IYuGB8A2rj7pFYnh16b/dBOpCs3YEBr2xkFQugDEgrxOr1LPQcAppKE5+ZWIobL1ZLYC12xx6LLd12FsEKcJ4JoXZYRU0R4aO4ymI64tgC+aC/nPy8U
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(53546011)(6506007)(36756003)(2616005)(4326008)(6666004)(2906002)(86362001)(316002)(44832011)(6486002)(508600001)(54906003)(8936002)(5660300002)(33656002)(336012)(186003)(8676002)(70206006)(6862004)(26005)(70586007)(82310400004)(40460700003)(356005)(36860700001)(47076005)(83380400001)(6512007)(81166007);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 11:54:24.2858
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 2f0de57e-5bb7-47f5-f605-08d9f079e934
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT017.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4301



> On 15 Feb 2022, at 09:39, Roger Pau Monne <roger.pau@citrix.com> wrote:
>=20
> There's no need to subtract _QR_BIAS from the lock value for storing
> in the local cnts variable in the read lock slow path: the users of
> the value in cnts only care about the writer-related bits and use a
> mask to get the value.
>=20
> Note that further setting of cnts in rspin_until_writer_unlock already
> do not subtract _QR_BIAS.
>=20
> Signed-off-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>

Reviewed-by: Luca Fancellu <luca.fancellu@arm.com>

> ---
> xen/common/rwlock.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/xen/common/rwlock.c b/xen/common/rwlock.c
> index dadab372b5..aa15529bbe 100644
> --- a/xen/common/rwlock.c
> +++ b/xen/common/rwlock.c
> @@ -47,7 +47,7 @@ void queue_read_lock_slowpath(rwlock_t *lock)
>     while ( atomic_read(&lock->cnts) & _QW_WMASK )
>         cpu_relax();
>=20
> -    cnts =3D atomic_add_return(_QR_BIAS, &lock->cnts) - _QR_BIAS;
> +    cnts =3D atomic_add_return(_QR_BIAS, &lock->cnts);
>     rspin_until_writer_unlock(lock, cnts);
>=20
>     /*
> --=20
> 2.34.1
>=20
>=20



From xen-devel-bounces@lists.xenproject.org Tue Feb 15 11:55:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 11:55:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273090.468156 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJwQI-0008Cy-Ib; Tue, 15 Feb 2022 11:55:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273090.468156; Tue, 15 Feb 2022 11:55:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJwQI-0008Cr-Dt; Tue, 15 Feb 2022 11:55:10 +0000
Received: by outflank-mailman (input) for mailman id 273090;
 Tue, 15 Feb 2022 11:55:08 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=xOiq=S6=epam.com=prvs=4045782cdb=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nJwQG-0007dj-HP
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 11:55:08 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1e1e59ac-8e56-11ec-b215-9bbe72dcb22c;
 Tue, 15 Feb 2022 12:55:07 +0100 (CET)
Received: from pps.filterd (m0174676.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 21FBsUuQ027425;
 Tue, 15 Feb 2022 11:55:04 GMT
Received: from eur04-db3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2059.outbound.protection.outlook.com [104.47.12.59])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e89njgfry-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Tue, 15 Feb 2022 11:55:04 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM7PR03MB6515.eurprd03.prod.outlook.com (2603:10a6:20b:1c0::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.14; Tue, 15 Feb
 2022 11:54:45 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::fc4d:4749:5d1:eb73]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::fc4d:4749:5d1:eb73%4]) with mapi id 15.20.4975.019; Tue, 15 Feb 2022
 11:54:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1e1e59ac-8e56-11ec-b215-9bbe72dcb22c
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=No+1nukHTKlCZYrcZGsHhq+ykuPBgDmjFWEJAGQ9ytIGdQy8wvFE89l9SbNzNJwhH2O8hNYgBGx+flyUB+oIBGJELKh0AjLv4yMSyALaas6MmwL1nuV/0gXiYvd1OC3OCBTVZw4tnAy5XThbq/XJZr2SP0sw6/yQJNOSiNL1m2vd36gS3hdcD6mpg08a7adzX51kxXWvgEuAE6YEB7ngXu28+8je/hXrL9KOQ4nr1S5bTAPJOBUluyu0f7TU+IEzP8MWu9Z5KEl5gUfxeRH04qpVUL8hoJpTO8fibZssT6yo+FfrJzWkWYJV4eNulzG3Ihoy642Xf7xDpa68Mw/84Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=JeEK6ZVKFqMjlnptiVa6DRdaqcO6QXH9hI6IYd9A/Yg=;
 b=FHBHPHvdFiNzmamfZ0mz21Razl1ois6NpAW5SmPWvP0q9HX05c9dt+PltlqRFGdxTKfwWUYTif1P87nC5DcaBXafjyohMs6BDu9Jt2fmFQBpg3O0JWMAOD6qilbHOVxMfVmBRLGUgqHbVdclHqCEycgTt7MyWLnzCvPQafsKl/shLeAymHCK6vIRHBXVkOO37I5eOuwKPpkMx4NVs66NzOZiOg6SIWBsRrOWXIg6Kravv0BBpU0ykaEnOeBSVKLBNrQtaOjXPAbRfNs7krZrmX08JlvMGdEuY8T8O2k4RHXVitq8p6UpI61Xh/ZToMyqpjejehuyh632AwjWgXmX/g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=JeEK6ZVKFqMjlnptiVa6DRdaqcO6QXH9hI6IYd9A/Yg=;
 b=fKH96M7URwtNqiKT9KBs+AbsQCEq3LqcUIrm+vTAFaRVsVWIgoWEW2KXrCnw45YZmKpEuVwFZ8oXTeU9GqOm0v3fiGZt6CfQhXjn8tj+ZAUb9y2dGmPJTlVaFA8wqulFZ8DaJ4yk1buMFSgx+TNtIONTE6UQuNtbGZPiaav5RTjfPJpYAo2+boUmM1U0IFUwf0lYt3YIy0dqABg4AwyPKoP/MQqOcMZO5USspe/EkGRPwpCBLVkXS3lTvYhdGO47gJI3rP9XnqKhf/ttPrmDHOpO6dUNT5dOVnDwfu/g9a/nTHv4o8i58WHPAaJcdwiEyyvdvsb7aWWoCTKdnKXYtA==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?=
	<roger.pau@citrix.com>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v2] vpci: introduce per-domain lock to protect vpci
 structure
Thread-Topic: [PATCH v2] vpci: introduce per-domain lock to protect vpci
 structure
Thread-Index: 
 AQHYIkOs9pmsZb0l5kefj1m3qdTVCayUboeAgAAGwYCAAAeVgIAAAZQAgAABlwCAAAEVAA==
Date: Tue, 15 Feb 2022 11:54:44 +0000
Message-ID: <bbb36ebc-de66-297d-f82f-abc0e63f20a2@epam.com>
References: <20220215081135.1497470-1-andr2000@gmail.com>
 <YguE7RWOteSnvVNY@Air-de-Roger>
 <c5b9b02c-93f8-d018-6048-9abf2e7de4dc@epam.com>
 <YguQ8wfhfYFXTWSU@Air-de-Roger>
 <70dbd7fd-3f74-d0d3-6e30-c1e1e24fc279@epam.com>
 <0d8f01b2-b015-a08e-dd49-e9c688ff7245@suse.com>
In-Reply-To: <0d8f01b2-b015-a08e-dd49-e9c688ff7245@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 9f2f62b3-f735-48a9-3aff-08d9f079f599
x-ms-traffictypediagnostic: AM7PR03MB6515:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM7PR03MB651578D32BA18D958B59C53CE7349@AM7PR03MB6515.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 fvrNTNv9fXK/ucwQDJtzCDl34SvqKtsDAfpNxmJGl+7yh11NGLVzP1dw0edjFYkpQYCZr3K19d7Vbdn8NVtmF6GTbVZoNS+OxzXG8C+N8Kk2hoqsdWd8mMu9/cV7G+nM0DBOXoxLE9gvvdUWtvL5sz6sXDqNKFxzRTR3d3oOs2x7ikahCzle+uYjsxof7UKsx4R4te893PrmKbxIdEC+5c+GRXk4BL8/8KIBn40VZfwAEaIh9FEB6gydlLaFvHYYPd4nN4CS+xU6ozVr0+8q/MTTcd262REplbVaVI3v12FlCOcFs5ZAKgVt8TjFlw+ic12BVMnSyvReiGdXJ7jP7ZTKQVylR+qZ8AcuhtNtL30KsYgZYEJIkt18giR9uiWSvYXLJ710P+cNN8qhjH1OEK/GZWdIMnb7s7BAylMosby69hDfeleqlMaGSYEQXrJrFszK4io8X/bISpkUfbsptMFcAcb+cW6lVQYbSiP+RAvmwfcP6ET/yb4zctZYZHHfmyOppooNCYag5zz+Yv0SWSJiJsf7d5VGEG0YmL1B8+Ltc6EgAlNxVg+nZ/c4mPyqrzwjBZNNNiIXOEgq+ZGr5WGirldXvKA7CiPE2kgp8yur3hrqWmiCct5SzIdW8tdzUPrbKGEj4viXYg2SfU7XfnfXBZVLjTv0X3VOKuD5yMhHiTQkV/3UDtnruKKQ61aZIUcFWXojyRv9v97EVUbp3thSsxNr634LZy3o8WFt0Ow=
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(4744005)(6512007)(71200400001)(508600001)(8936002)(6506007)(91956017)(53546011)(55236004)(5660300002)(8676002)(86362001)(66946007)(64756008)(66556008)(26005)(66446008)(186003)(66476007)(4326008)(2616005)(76116006)(107886003)(2906002)(31696002)(38100700002)(83380400001)(31686004)(6916009)(316002)(122000001)(54906003)(36756003)(38070700005)(6486002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?b2tFcDNjRzRzYmUzQk1KcFR5dGQ5ZDNwZGx2Q0t2aTdJcFpyWWpTRUdCYVM4?=
 =?utf-8?B?bHJHdkJUdHlGRVlDY2hkQWpjU2RqWk5va0oxYmJqS25URTFDOWk4dnZUWFU4?=
 =?utf-8?B?UEZjV2RndW5DNnNIck4zbFNralFrWkxUWG4xRTZSMW1DNlJKTFZyRWw0UW1J?=
 =?utf-8?B?SEtaQ2JnRFVnTWQ5UGk3UVNJQkZpRXZjVXFRc3ZweFRnem1uZ3BGM28wbkp4?=
 =?utf-8?B?blEyUkQyRldHa0FwVkVNbnVFQ1M4b3hPSVpRWkRZQmN6WTlncWE4bDZPZTg1?=
 =?utf-8?B?RjRKbkQ2dmZ3QndjUS9IQlBRRmJDNVU2dWhGZk9lN05CWUd3NnpGMWpKYU9s?=
 =?utf-8?B?K0RScjVwZ3c0Wk14Mi9xaml5cE0wWitTUWtWeWRLa0F1LzNQdXIrY09aYzln?=
 =?utf-8?B?MkNQc0dJR1NBbzR4Mkc2Mm5NVXB0bmhWUDN4N283MHNkSVNxNTZEbS9aR0lp?=
 =?utf-8?B?NDVvQ0V5MVBSYkxRanVJOEVtMHBpdjBWaG1iWE8xc1JxNndXdXpkTXpHb00w?=
 =?utf-8?B?WHdQcXEzQmRPdGRhQndrMzRoSnkvdytrU0VNeGFmaXhKaDFnQi9qU3JQUE9X?=
 =?utf-8?B?ZVlXNUFpY3JJQkFVTXdUcUM0TmVZK0N2MjQ0ajVJLy9WczE1V1BHRlArc0Ns?=
 =?utf-8?B?aHpTOG9XWlNudDV3TFcvS2grYmcwMzZud240bVJGcWFwY3BXMEFnUWtRTHk4?=
 =?utf-8?B?d1F6cU1zUDFsb296SWNQb2E2MlJjZXFvM0gwTy9NQUQ2b28xdWZvdlNlZzFN?=
 =?utf-8?B?c2M0a0NoWXh0RnFJQmpjdWtWV0hjcDRBeHBJK0hWcmJQMnZmZ045ZU5vQlFH?=
 =?utf-8?B?VDhQUCthaG5kbnRlVmpxWi84OVYvZ0JaNWR2Z25WdElVTnNpbDVoQmkycEhj?=
 =?utf-8?B?bjc3b0Z4dWc2cWtmNU9SN0MxQXVTTVZVcVNTK21DV3BqR0FpWXRaWVZPMzhn?=
 =?utf-8?B?d2cybHR6cEpkWmRuQUU3R3ZVb2VFOUZDOGV1TkUwcVZlVnNQZWNPa1Fzb1Mx?=
 =?utf-8?B?MDl1SWpvcWxqQ1NDRHY5VGRhWDBrVlcwMU5EY2NlQmtWZGhCR2ZpcEpqM1Zy?=
 =?utf-8?B?aU4xemdsTjdPRHluU1EweUhNVUV5eWc1c2I3amQvOVFPUmtqYnh4V0xRSG52?=
 =?utf-8?B?T0dBbkljd0tzSmZzcG92QnVLc1FEM2NkYmgvZC9kZEs1anhWUkdhUDlVOGxn?=
 =?utf-8?B?enFmMEpXY1E5OXdMdGVFaTFNa0NXQ0lPbTQ5Z1hMTCt4TXd5aVlRTEx4SVpl?=
 =?utf-8?B?L3dmeDVKWHI4TmRBa203M1VMM2M3QnhpMTlGYVhEeGFMQkhZNkNGMXNKUlM5?=
 =?utf-8?B?ZzVRVDdsK2QvTUp3NHZvbU5LNVpxRSs0R1AxdXJpRFhYMU9LWFBJV3VUTmNm?=
 =?utf-8?B?WHZJeWlQb3Bhdy90VGhyc2VRajZrMWw0TXQ5aXg0dW12bjZBaUVGL0ZIbDgy?=
 =?utf-8?B?QVZjUlpyeXJTT2x4bTdqQjBaamtDMkRNTXJ3SVh2UFVBSHZkV3VKLzJSRkx3?=
 =?utf-8?B?bTBEMXV3b3d0bE1iRjdlaGhXWmsvek8yME5pMEJtQ041YTJjRTRwZkZ2SE9L?=
 =?utf-8?B?MmxoU2VjbXdPTjMyTDlORloxYmkvZ0RFemdQajN0SXFQemd1ZnRWajZIUnBt?=
 =?utf-8?B?cnE3UlFyZENlODRSQUNpeEdNS3d0Z3N3aUJRWnhuQUZXZU5mVGxIdUxXamZh?=
 =?utf-8?B?aDNDWUVManYxNUJjT2lGMDN5UUpFOURGU3hKSE9IbnBlVkluU3VzK2svTE9Y?=
 =?utf-8?B?bUM0cHoyQktYaXBCU0JOSzdaMVB0TTV4UkorMmc0aGhlVWJzVGpGOFNZb1Az?=
 =?utf-8?B?VFMzQjM3WG8rVENVeVpWS01scXd2bFJPR0oyN3ArOVNaRVZGSk1qNEpBa0pZ?=
 =?utf-8?B?dkY3cm5EMlh4M3BpcmlwZ1NxUEo1MnUrbUdtV1RWNXdmYWNPclpOWnFpNmpP?=
 =?utf-8?B?cjZNeWcxTzNHTmR6Qmx1U3Nvak5CeFNvOFk2OFZYdXV6VHdYSERiNWJ6cjVl?=
 =?utf-8?B?Qko4TktsUHRlY2ltWmNDK2cyWHltRDRzWVFyOVIwRXdpUVgxTWxPZ3BQNWEr?=
 =?utf-8?B?U3FBTFAzMk45Uk5KaFlQeFZjbWtBendKdHpqeWpyUGZOWTlOWkovei8yQktP?=
 =?utf-8?B?ME1KSGNIYTFVMTQxZWZrSHcvR2s2MXV1bFgycFZwcHpHVERNbkc1eHhXMzNM?=
 =?utf-8?B?UjNUejZwN3BaQzV3TGhLNHhhSjBWZzFTdmRsalp3VUtiUlp5bmhJbVRReDJM?=
 =?utf-8?B?OThXR2ZMK3ZnOXQxZGN4Z0VBNENPc0pIS0tWMFdhSjE1em14SVlhRkY2eTlX?=
 =?utf-8?B?ZDJLWTlMWjNpOE9TRDdGRkE0ZEx6cTlhOWV5QWNaNmxUQ1Z4Mnloc21UWWpM?=
 =?utf-8?Q?ytDH38taYZiBHIRI=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <36AA1DA688675A469314B1633AAA7E81@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9f2f62b3-f735-48a9-3aff-08d9f079f599
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Feb 2022 11:54:45.0242
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: X2CP6JgPeaFyta8FPae5pc06hFsZoMuetr2qXhViHxgiWLeVBui+IqGMEL7k9gwKyOyYPSYCicLRXNrGQXg2yCVj1QtGnilrFXbuVGlj1AQeVe6NTHAcpS4gjM3rm9/G
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR03MB6515
X-Proofpoint-ORIG-GUID: Qr8fVHOn83VHniB4AGceeM19soQpM6FP
X-Proofpoint-GUID: Qr8fVHOn83VHniB4AGceeM19soQpM6FP
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-15_04,2022-02-14_04,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501
 malwarescore=0 spamscore=0 impostorscore=0 phishscore=0 adultscore=0
 suspectscore=0 mlxscore=0 mlxlogscore=988 clxscore=1015 bulkscore=0
 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202150068

DQoNCk9uIDE1LjAyLjIyIDEzOjUwLCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMTUuMDIuMjAy
MiAxMjo0NSwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+PiBJJ20gb24geW91ciBz
aWRlLCBJIGp1c3Qgd2FudCB0byBoZWFyIHRoYXQgd2UgYWxsIGFncmVlIHBjaWRldnMNCj4+IG5l
ZWRzIHRvIGJlIGNvbnZlcnRlZCBpbnRvIHJ3bG9jayBhY2NvcmRpbmcgd2l0aCB0aGUgcGxhbiB5
b3UNCj4+IHN1Z2dlc3RlZCBhbmQgYXQgbGVhc3Qgbm93IGl0IHNlZW1zIHRvIGJlIGFuIGFjY2Vw
dGFibGUgc29sdXRpb24uDQo+IEknZCBsaWtlIHRvIGV4cHJlc3Mgd29ycmllcyB0aG91Z2ggYWJv
dXQgdGhlIGNvbnZlcnNpb24gb2YgdGhpcw0KPiByZWN1cnNpdmUgbG9jayBpbnRvIGFuIHIvdyBv
bmUuDQpDb3VsZCB5b3UgcGxlYXNlIGVsYWJvcmF0ZSBtb3JlIG9uIHRoaXM/DQpJIHdvdWxkIGxv
dmUgbm90IHRvIGhhdmUgNHRoIGFwcHJvYWNoIHJlcXVlc3RlZCB0byBiZSBpbXBsZW1lbnRlZCA7
KQ0KPiBKYW4NCj4NClRoYW5rIHlvdSBpbiBhZHZhbmNlLA0KT2xla3NhbmRy


From xen-devel-bounces@lists.xenproject.org Tue Feb 15 12:00:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 12:00:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273101.468166 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJwVV-0001NM-AM; Tue, 15 Feb 2022 12:00:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273101.468166; Tue, 15 Feb 2022 12:00:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJwVV-0001NF-7B; Tue, 15 Feb 2022 12:00:33 +0000
Received: by outflank-mailman (input) for mailman id 273101;
 Tue, 15 Feb 2022 12:00:32 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJwVU-0001N5-D1; Tue, 15 Feb 2022 12:00:32 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJwVU-00004v-9k; Tue, 15 Feb 2022 12:00:32 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJwVT-0004RS-NU; Tue, 15 Feb 2022 12:00:31 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nJwVT-0007BD-N2; Tue, 15 Feb 2022 12:00:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=l0FOX4uWb6ewbWaY/apQENy+hZUki9BugP8xIGr4O64=; b=Ff7qccol8JYVA7FBnmSZwzcx7y
	au65nDM4R0BrPt5CaRYFxFTiLR1FF32VhAhOP5YlYK5qoj54Pjm1M7Nx6K26NzxEVdjfe30/BEDv2
	DEak79FmN0hrXmrsaa3vyEjNtKgVWAz6ylP4fziOw0KjOezGQ+P8TXRyu9cqUqtcEbl0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168113-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 168113: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:allowable
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=d567f5db412ed52de0b3b3efca4a451263de6108
X-Osstest-Versions-That:
    linux=f1baf68e1383f6ed93eb9cff2866d46562607a43
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 15 Feb 2022 12:00:31 +0000

flight 168113 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168113/

Failures :-/ but no regressions.

Regressions which are regarded as allowable (not blocking):
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10   fail REGR. vs. 168080

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168080
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168080
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168080
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168080
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168080
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168080
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168080
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168080
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                d567f5db412ed52de0b3b3efca4a451263de6108
baseline version:
 linux                f1baf68e1383f6ed93eb9cff2866d46562607a43

Last test of basis   168080  2022-02-11 00:09:22 Z    4 days
Failing since        168086  2022-02-11 20:11:19 Z    3 days    8 attempts
Testing same since   168113  2022-02-14 19:11:17 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Aaron Liu <aaron.liu@amd.com>
  Adam Ford <aford173@gmail.com>
  Al Cooper <alcooperx@gmail.com>
  Alex Deucher <alexander.deucher@amd.com>
  Alexander Egorenkov <egorenar@linux.ibm.com>
  Alexander Gordeev <agordeev@linux.ibm.com>
  Alexander Stein <alexander.stein@ew.tq-group.com>
  Alexandre Ghiti <alexandre.ghiti@canonical.com>
  Alim Akhtar <alim.akhtar@samsung.com>
  Alviro Iskandar Setiawan <alviro.iskandar@gmail.com>
  Ammar Faizi <ammarfaizi2@gnuweeb.org>
  Andreas Gruenbacher <agruenba@redhat.com>
  Andrew Morton <akpm@linux-foundation.org>
  Andrey Konovalov <andreyknvl@gmail.com>
  Andrzej Pietrasiewicz <andrzej.p@collabora.com>
  Andy Shevchenko <andriy.shevchenko@linux.intel.com>
  Arnd Bergmann <arnd@arndb.de>
  Aswath Govindraju <a-govindraju@ti.com>
  Aurelien Jarno <aurelien@aurel32.net>
  Bartosz Golaszewski <brgl@bgdev.pl>
  Bean Huo <beanhuo@micron.com>
  Benjamin Gaignard <benjamin.gaignard@collabora.com>
  Bjorn Helgaas <bhelgaas@google.com>
  Bob Peterson <rpeterso@redhat.com>
  Brenda Streiff <brenda.streiff@ni.com>
  Brian Johannesmeyer <bjohannesmeyer@gmail.com>
  Brian Norris <briannorris@chromium.org>
  Cai Huoqing <cai.huoqing@linux.dev>
  Cameron Williams <cang1@live.co.uk>
  Catalin Marinas <catalin.marinas@arm.com>
  Changbin Du <changbin.du@gmail.com>
  Chia-Wei Wang <chiawei_wang@aspeedtech.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Borntraeger <borntraeger@linux.ibm.com>
  Christian Hewitt <christianshewitt@gmail.com>
  Christian König <christian.koenig@amd.com>
  Christoph Hellwig <hch@lst.de>
  Christoph Niedermaier <cniedermaier@dh-electronics.com>
  Christophe JAILLET <christophe.jaillet@wanadoo.fr>
  Chunfeng Yun <chunfeng.yun@mediatek.com>
  Damien Le Moal <damien.lemoal@opensource.wdc.com>
  Dan Carpenter <dan.carpenter@oracle.com>
  Daniel Bristot de Oliveira <bristot@kernel.org>
  Daniel Stone <daniels@collabora.com>
  Daniel Vetter <daniel.vetter@ffwll.ch>
  Daniel Vetter <daniel.vetter@intel.com>
  Daniel Wheeler <daniel.wheeler@amd.com>
  Dave Airlie <airlied@redhat.com>
  Dave Hansen <dave.hansen@linux.intel.com>
  Dave Stevenson <dave.stevenson@raspberrypi.com>
  David Hildenbrand <david@redhat.com>
  David Rientjes <rientjes@google.com>
  Dinh Nguyen <dinguyen@kernel.org>
  Dmytro Laktyushkin <Dmytro.Laktyushkin@amd.com>
  Dongjin Kim <tobetter@gmail.com>
  Fabio Estevam <festevam@gmail.com>
  Fabio M. De Francesco <fmdefrancesco@gmail.com>
  Fabrice Gasnier <fabrice.gasnier@foss.st.com>
  Florian Fainelli <f.fainelli@gmail.com>
  Geert Uytterhoeven <geert+renesas@glider.be>
  Geert Uytterhoeven <geert@linux-m68k.org>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>Cc: Dave Airlie <airlied@gmail.com>
  Guido Günther <agx@sigxcpu.org> # Librem 5 (imx8mq) with it's rather picky panel
  Guo Ren <guoren@linux.alibaba.com>
  Hans de Goede <hdegoede@redhat.com>
  Hector Martin <marcan@marcan.st>
  Heiko Carstens <hca@linux.ibm.com>
  Heiko Stuebner <heiko@sntech.de>
  Helge Deller <deller@gmx.de>
  Ilya Leoshkevich <iii@linux.ibm.com>
  Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
  JaeSang Yoo <js.yoo.5b@gmail.com>
  JaeSang Yoo <jsyoo5b@gmail.com>
  Jakob Koschel <jakobkoschel@gmail.com>
  James Smart <jsmart2021@gmail.com>
  Jan Beulich <jbeulich@suse.com>
  Jan Kara <jack@suse.cz>
  Jani Nikula <jani.nikula@intel.com>
  Jann Horn <jannh@google.com>
  Jarkko Nikula <jarkko.nikula@bitmer.com>
  Jarkko Sakkinen <jarkko@kernel.org>  (kselftest as sanity check)
  Jasdeep Dhillon <jdhillon@amd.com>
  Jayesh Choudhary <j-choudhary@ti.com>
  Jens Axboe <axboe@kernel.dk>
  Jens Wiklander <jens.wiklander@linaro.org>
  Jeremy Linton <jeremy.linton@arm.com>
  Jerome Forissier <jerome@forissier.org>
  Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
  Jing Leng <jleng@ambarella.com>
  Jisheng Zhang <jszhang@kernel.org>
  Joel Stanley <joel@jms.id.au>
  Johan Hovold <johan@kernel.org>
  Jonas Malaco <jonas@protocubo.io>
  Josh Poimboeuf <jpoimboe@redhat.com>
  Juergen Gross <jgross@suse.com>
  Kai-Heng Feng <kai.heng.feng@canonical.com>
  Kees Cook <keescook@chromium.org>
  Kishon Vijay Abraham I <kishon@ti.com>
  Kosuke Tatsukawa <tatsu-ab1@nec.com>
  Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Linus Walleij <linus.walleij@linaro.org>
  Liu Ying <victor.liu@nxp.com>
  Liu Ying <victor.liu@nxp.com> # RM67191 DSI panel on i.MX8mq EVK
  Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
  Lucas De Marchi <lucas.demarchi@intel.com>
  Lutz Koschorreck <theleks@ko-hh.de>
  Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
  Marc Zyngier <maz@kernel.org>
  Marek Vasut <marex@denx.de>
  Mario Limonciello <mario.limonciello@amd.com>
  Mark Brown <broonie@kernel.org>
  Martin Blumenstingl <martin.blumenstingl@googlemail.com>
  Martin K. Petersen <martin.petersen@oracle.com>
  Martin Kepplinger <martin.kepplinger@puri.sm>
  Masahiro Yamada <masahiroy@kernel.org>
  Mathias Krause <minipli@grsecurity.net>
  Maxime Ripard <maxime@cerno.tech>
  Mel Gorman <mgorman@suse.de>
  Michael Walle <michael@walle.cc>
  Michal Hocko <mhocko@suse.com>
  Michal Simek <michal.simek@xilinx.com>
  Mike Rapoport <rppt@linux.ibm.com>
  Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>
  Myrtle Shah <gatecat@ds0.me>
  Nathan Chancellor <nathan@kernel.org>
  Neil Armstrong <narmstrong@baylibre.com>
  Neil Armstrong <narmstrong@baylibre.com> # for phy-meson-axg-mipi-dphy.c
  Nick Desaulniers <ndesaulniers@google.com>
  Niklas Cassel <niklas.cassel@wdc.com>
  Nishanth Menon <nm@ti.com>
  Oliver Barta <oliver.barta@aptiv.com>
  Padmanabha Srinivasaiah <treasure4paddy@gmail.com>
  Palmer Dabbelt <palmer@rivosinc.com>
  Pavel Hofman <pavel.hofman@ivitera.com>
  Pawel Dembicki <paweldembicki@gmail.com>
  Peng Liu <liupeng256@huawei.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Philippe Cornu <philippe.cornu@foss.st.com>
  Pingfan Liu <kernelfans@gmail.com>
  Pratham Pratap <quic_ppratap@quicinc.com>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Rafał Miłecki <rafal@milecki.pl>
  Reinette Chatre <reinette.chatre@intel.com>
  Rob Herring <robh@kernel.org>
  Robert Hancock <robert.hancock@calian.com>
  Robin Murphy <robin.murphy@arm.com>
  Roger Pau Monne <roger.pau@citrix.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Roman Gushchin <guro@fb.com>
  Roman Li <Roman.Li@amd.com>
  Rui Salvaterra <rsalvaterra@gmail.com>
  Sagi Grimberg <sagi@grimberg.me>
  Sam Protsenko <semen.protsenko@linaro.org>
  Sam Ravnborg <sam@ravnborg.org>
  Samuel Holland <samuel@sholland.org>
  Samuel Thibault <samuel.thibault@ens-lyon.org>
  Sascha Hauer <s.hauer@pengutronix.de>
  Sean Anderson <sean.anderson@seco.com>
  Shakeel Butt <shakeelb@google.com>
  Shawn Guo <shawnguo@kernel.org>
  Shyam Prasad N <sprasad@microsoft.com>
  Slark Xiao <slark_xiao@163.com>
  Song Liu <song@kernel.org>
  Steev Klimaszewski <steev@kali.org>
  Stefan Wahren <stefan.wahren@i2se.com>
  Stephan Brunner <s.brunner@stephan-brunner.net>
  Steve French <stfrench@microsoft.com>
  Steven Rostedt (Google) <rostedt@goodmis.org>
  Sven Peter <sven@svenpeter.dev>
  Sven Schnelle <svens@linux.ibm.com>
  Sylwester Nawrocki <s.nawrocki@samsung.com>
  Szymon Heidrich <szymon.heidrich@gmail.com>
  Tadeusz Struk <tadeusz.struk@linaro.org>
  TATSUKAWA KOSUKE (立川 江介) <tatsu-ab1@nec.com>
  Tejun Heo <tj@kernel.org>
  Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
  Thomas Gleixner <tglx@linutronix.de>
  Thomas Hellström <thomas.hellstrom@linux.intel.com>
  Thomas Zimmermann <tzimmermann@suse.de>
  Tim Harvey <tharvey@gateworks.com>
  Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
  Tommaso Merciai <tomm.merciai@gmail.com>
  Tony Lindgren <tony@atomide.com>
  Tvrtko Ursulin <tvrtko.ursulin@intel.com>
  Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
  Udipto Goswami <quic_ugoswami@quicinc.com>
  Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
  Vasily Gorbik <gor@linux.ibm.com>
  Vignesh Raghavendra <vigneshr@ti.com>
  Ville Syrjälä <ville.syrjala@linux.intel.com>
  Vineeth Vijayan <vneethv@linux.ibm.com>
  Vinod Koul <vkoul@kernel.org>
  Vlastimil Babka <vbabka@suse.cz>
  Wan Jiabing <wanjiabing@vivo.com>
  Yang Shi <shy828301@gmail.com>
  Yang Wang <KevinYang.Wang@amd.com>
  Ye Guojin <ye.guojin@zte.com.cn>
  Yizhuo Zhai <yzhai003@ucr.edu>
  Zhan Liu <Zhan.Liu@amd.com>
  Zoltán Böszörményi <zboszor@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   f1baf68e1383..d567f5db412e  d567f5db412ed52de0b3b3efca4a451263de6108 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Tue Feb 15 12:45:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 12:45:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273112.468178 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJxCK-0005Y9-L0; Tue, 15 Feb 2022 12:44:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273112.468178; Tue, 15 Feb 2022 12:44:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJxCK-0005Y2-Hk; Tue, 15 Feb 2022 12:44:48 +0000
Received: by outflank-mailman (input) for mailman id 273112;
 Tue, 15 Feb 2022 12:44:47 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=xOiq=S6=epam.com=prvs=4045782cdb=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nJxCJ-0005Xw-0Y
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 12:44:47 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0c9b7ca1-8e5d-11ec-8eb8-a37418f5ba1a;
 Tue, 15 Feb 2022 13:44:45 +0100 (CET)
Received: from pps.filterd (m0174681.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 21FCLhJi000540;
 Tue, 15 Feb 2022 12:44:40 GMT
Received: from eur04-he1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2050.outbound.protection.outlook.com [104.47.13.50])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3e8c44g2w6-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Tue, 15 Feb 2022 12:44:39 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM0PR03MB3970.eurprd03.prod.outlook.com (2603:10a6:208:73::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.18; Tue, 15 Feb
 2022 12:44:35 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::fc4d:4749:5d1:eb73]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::fc4d:4749:5d1:eb73%4]) with mapi id 15.20.4975.019; Tue, 15 Feb 2022
 12:44:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0c9b7ca1-8e5d-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=aY5GIhPUlEuQJfbGZsALbBEw4zp/rTd2GUQQ92MgaJX848N05jV0EYsxSbJp8D/IjlPkh9pGM+V7AZVnjBPJG97GlpuWVmyRTzD0AKnohD8SMYpQ9/Ozyih59L/tj8JPKon6MEjGV6ywR3QohuvAT+V8tSSvgAi+/WztVxC9qXpYwmJnQ4IbJ8I+MdHhXUPziKzt9rodTf26I+3mID6Zk9XS6E1CcGeCnSerDc+VnKBPxIRiyodV0krAkMkyAi6aOz3TIspIAVQa7PpklnvX1LwCuQb3WnIo0mOplf7hYotmkoioqGt7NfRY7L4Mj3GSwNZJc/3WoFSMLf2dqenKGQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=e/8wOfS7JIg+pQSfbhLxI/OXivap1yWICDnRSbbQeU0=;
 b=SIEDZ5uvWLBNyG3jDvYOP59ECCZdTVdF30LrLZif9O53I+WzNU0SseHLXB1zF9OW6ECMX6Za0JacU8WALHjGlFKwcaFfxvdkTmKqUkuj2YMbQMEqk5snkiiUe2ISGnILNb+4xIyktWaIms1MIGsRcLPsU551gOzJyegq6G8bxthcOMT8ZYNQaPPtYBdtEjtLBG2CU4X+YjtXSEot+78EE2crsCt+KnmIEp8sM/Wh2bZg+h7Ms4vbLHm4zfQ/TmSAhyVfWApBQB7XwceUa1w+4mf5SZzmsrPqk79ltiQ4xG1pTUKREL5jSTzDpNXMbiwHMDMhNB55V1H0lrtay1QEXw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=e/8wOfS7JIg+pQSfbhLxI/OXivap1yWICDnRSbbQeU0=;
 b=qHMsJNnL3IdhLym3n3ddsN4XKZuqBVlCSXnC+1piJuU8dPeDcVReLdvW7rFLHEImU1Czy30UBg0CYBDl83HprNG52pwF8wpv3PXVEz+a/j1HNTpmWwV+uASL6DnOGzUxE6x1jmVq8+g/06G5NzsQfmgIKE2B2chAJkafsT6Dqwtw2zuVTVhyJ7mMedlcMmZ/aUBoC89RPk2daoaYpZGOtaZcANaGirnJ4Uhnc4luI+QC3ltcnCFDLwlZhNl6WbR7MOheF7blqBcS8rJ9g1fQOcgF0x/n50KT4hA7W24J3B1e0qe9AIdR2L+ray1ShXOfN3f5iVbsrNS38au6KbDRuw==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>,
        Rahul Singh <rahul.singh@arm.com>,
        =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
Subject: Re: [PATCH v2] vpci: introduce per-domain lock to protect vpci
 structure
Thread-Topic: [PATCH v2] vpci: introduce per-domain lock to protect vpci
 structure
Thread-Index: 
 AQHYIkOs9pmsZb0l5kefj1m3qdTVCayUboeAgAAGwYCAAAeVgIAAAZQAgAABlwCAAAEVAIAADewA
Date: Tue, 15 Feb 2022 12:44:35 +0000
Message-ID: <22d25499-cab0-00c1-3ad3-bddd74c97a55@epam.com>
References: <20220215081135.1497470-1-andr2000@gmail.com>
 <YguE7RWOteSnvVNY@Air-de-Roger>
 <c5b9b02c-93f8-d018-6048-9abf2e7de4dc@epam.com>
 <YguQ8wfhfYFXTWSU@Air-de-Roger>
 <70dbd7fd-3f74-d0d3-6e30-c1e1e24fc279@epam.com>
 <0d8f01b2-b015-a08e-dd49-e9c688ff7245@suse.com>
 <bbb36ebc-de66-297d-f82f-abc0e63f20a2@epam.com>
In-Reply-To: <bbb36ebc-de66-297d-f82f-abc0e63f20a2@epam.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: ad176782-c802-4c33-47fe-08d9f080ebf6
x-ms-traffictypediagnostic: AM0PR03MB3970:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM0PR03MB3970BC7D4689A27F5AA1143CE7349@AM0PR03MB3970.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 AOngDir5mKROe3f+rKbxXxTWJ6YsxrtNZTktAHYFRO6l2rapL3R0yN89+Sbc3RR7l+RWEGEgiR79H988Zr0yORXndKTw277Z88GvoQOPZ018n5Yq0a61CYpcHyQPqqQAN49tQY25tQeTsJNyiVxD+8ATOayo1PUTdaDmxf3Dhvp1eCstMM+Xjrw0xk73UvTOaqCRtvlWaKlMzVi7bU5zEMpGOAz1XlDaeThH5wkPabmHxoO6d91U6X941GEdvrDwm08atiGM20AOHCgXC8efObYPodHSI90iYfbwdsCdhv+MTrR+i9KZEqDYlpDrKVqoN1A338yQKsleofwOIRWG2oncNlT/MGcxPYR9Setqr+cJEVD9DWoRl6vBv+xwW4rGehrfvushoFI+IaO3U6stUgR97tOpd46orxKzlK60f1jvsJT9HVx0l5A4F7gnq2K0wRf7FHAUkhoEELXziwVKi/zpEmt90XmflJuSnq0w1V4d0d/QTtQOseMgUbAv30Qa0JXfS/q1fzbrHMxTaxnVcrmCO7CUPGOtNLQJ+gzbEKXnskevAGs2DfJXjDZiVvhC0XDx1SCCgY9nr2QZyh/OE5NIYbeJbjZrnAJCJtiLDp+PtB6b/udy/I9gEFqV8mlKtXXAwStcLt11zdVfYj3wE8Y2szVB2Pr9OcpqjZbpxfcFUKgptycoSWvd9l3/w2Y120J7sygPkq9k0O6wQzL7v8Ez0C63XY0+0zUSxWY6Pbp06Hsdz+50+OyQxA13Qv6O
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(83380400001)(31686004)(6916009)(26005)(186003)(54906003)(36756003)(316002)(31696002)(86362001)(2616005)(66556008)(5660300002)(2906002)(38070700005)(66476007)(55236004)(53546011)(91956017)(8676002)(64756008)(76116006)(6512007)(66446008)(4326008)(508600001)(6486002)(38100700002)(8936002)(66946007)(71200400001)(6506007)(122000001)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?NTNsQnVkZkIxT0tRSXZwb2NsbTdtQStzc2lzc3JEVmxvSmxtV1FNZ2Z4RENn?=
 =?utf-8?B?bjloRkNZTXRIY2pMclcxaEpoQXBoWjdXUTVaNDZzKzhVQUZ4UWY3OTc4RU9D?=
 =?utf-8?B?MkVYUk5zdzd3MS9xVFdaaDNuWlF4dUdzMnk0SGhxWi84OEVjV3ZoNVFJRWtH?=
 =?utf-8?B?RitYUUhkZnNvNGtNZU5KNytuSVo4SWREQWRwNm1VT0JaQXdoMyt5NHNxc2xL?=
 =?utf-8?B?eDcrN25EUjArcVdMU1c0cEU2dnBFOXJPQyt1USt4TytqcWkrcFBQc2FpSCsr?=
 =?utf-8?B?MEQzRVJhWVFYL1ZRYXU0Q2xpTDFVZWVKWXZmTTZFUmRhaG8xS2Z2eVZ3dTRu?=
 =?utf-8?B?UW5Ra1lJcXdRZHZYQ2FmVmJQWHg1TzBDVHp6NnRKc245bjAxNDhPMTQ4Q3NR?=
 =?utf-8?B?OXdPeVhRSUtMeUY5MVJVK3d1eWVlRmdISnNtajEycWMrZ0hRQnJMSVg3VndX?=
 =?utf-8?B?QjQ3RHNET2hyaW9rMUVXVVVHK0wxNDhlQ2dTOEpBUG5idFNaTE9QYkkwOVJO?=
 =?utf-8?B?OHRWMjVTY1J5ZkdQY0lyYXZsbHB6WW91Um8zL1k1LzBmeHM3YU56aGROM1JM?=
 =?utf-8?B?NTUxSjFZbWdFaU1MN1BJT1Y4U0QvVU84MkI5Yk1JN0FCNzlVQTlVR2pld0dj?=
 =?utf-8?B?b3V5SkZzanlYWEpFR1cya1A4UHJnN2FIT3VLRlJiQXRublB3YlEyUUFRWElu?=
 =?utf-8?B?dWVhUHNZT2pyYU4xZkUwcmtyVWJHenk1OTZTY1A5K2YzOE9HYkJFNGFxWmor?=
 =?utf-8?B?M3BtcWJxV2lkQVZRdndkM0pSUVRtdXVXUmphVVlqY3MwR1kxVjJabG01b3dv?=
 =?utf-8?B?QldZUGNsZEFzRGdxT29KWnpjM1dURkYybisvcjZiVDVWZXVhcjdnVjFQMmla?=
 =?utf-8?B?QjExcEhROUFnZ3ExcUdES0F6eFd2a3VFcW5BRFJ6M3cxRFNiSGxOTzRNdmZH?=
 =?utf-8?B?L1daSmZBYjBzY2RXcFQwOHdzTEthR29rMHQvRTZ4VHdiMmtsUmxwUFVuQTVG?=
 =?utf-8?B?eFdJSmk3djUzbERESWNROEU0MktXMDRoekJYTlhIZmVub0JucGJ0VFRZbW9U?=
 =?utf-8?B?dGRVVjIwYk9ueGJ6TlREeXZ4T1VLKy9lUjVNYkZ6QXl0YTQxUm5uSGtsOWV6?=
 =?utf-8?B?U1B2Vkh2TVhCbkhqd1pNdHcxbktqcHdFM0hrVVFFUitQZGhtTW1TTzlCdTJR?=
 =?utf-8?B?T2pvekNtUVhmQWtoK1dLdTBjQzJWbjJidzR3WGtqR1ZKTHVPS21CbEo0OFNB?=
 =?utf-8?B?Zy82VzRZNTRFL2RabXF2WWI2azc5bXJVby9xVFFCU085NjYwdmZjK3YyVmNS?=
 =?utf-8?B?dlVkdHdTVjdIRFRuZTQwUmNjdUd6VDVXNGRwMHNBMFZvQjM1VDFIbndRajYx?=
 =?utf-8?B?R1QwZHhtM0MzVkxGV0NzYnhoRE9JekJSMWNSNTRJSHRxNVFNYnlCNGQ0NjRU?=
 =?utf-8?B?cGZSMEZ3dkswVTFvUjV3eWhkeFZlUHd5Qmg0SEhCNEMwUjFkeDBJTUt6Uyth?=
 =?utf-8?B?ZjhlWTRaZ1hLQnhTamFZb2FzNzJVT3d5L1dqSnJsUlc5OVorMi9Ja2RySmM3?=
 =?utf-8?B?OXM4RWRlTWJ3a2lLSkNEekpKZWpnSUZwT2cwcmJmSkNhWXdWckNEOTZNSlRz?=
 =?utf-8?B?SWJtaDJKVG9PbEhoQU5ER1FSSDlxYi9sb2VNdFJlaUI5MjNRbzQ4cUdQZWcz?=
 =?utf-8?B?MldhNUwzaU5jMXI4UmxwR0NpNVQ3T1VoQyt3eVJ1WUhFVlhoa0RBZHcxN3Zo?=
 =?utf-8?B?d3VBNmFwUmZ0dk1OdHVnbVJlelBXN09sNDBaaG5HYW9HQWJRQmVYTFZqSHUx?=
 =?utf-8?B?NTF2RE9scU5jWE9KM1JmYVplSDhkY2lFYllMcWFXZWxwTkE5eVIwbzVyR0J5?=
 =?utf-8?B?SDlMU1dWcUhBelhJVzh2YXc2WTRtbGJzZzRsdnI5Uk5hSTJLek5ySTJYb3E0?=
 =?utf-8?B?ZVBTU2w5VXl4OGo3VzRrOVcxQkdMcmVFRGY1NWhlUlltK2p1L2hyamFLUFRo?=
 =?utf-8?B?NHA1NHlEUlVvYzdEbmczUk9nRERoYVJSRDhWVDFsYUhRemwwTWNEa0QydXEz?=
 =?utf-8?B?NnAzOFhialE4eGxCQmd6Z2dsUmZGV3YyVlZIOXcxeXpXQ2N6US9qNXdtVUVo?=
 =?utf-8?B?aVl1UUptUG1ibWxrRFZxdUw4cWVkVTIwOEFOVGhPTWljVDFpMjV1RUxBcjNJ?=
 =?utf-8?B?bGpwSjIwYzVCRzVveEhHaURnMXlKOTlhazN6c0ZIRzYzLzI5OVU2MmVDUzlh?=
 =?utf-8?B?V3pOU1NHN3dVZWxRaXdSTzJUUVMyMCt2eHZBZEczNTk3eTI0WlBod0tOZ1FQ?=
 =?utf-8?B?a1hOU3R4T0l2MWhLbk1DK0Nab1RSVVhDaUdXcHVXQnFpdkZnQ0tiaFpTNlAr?=
 =?utf-8?Q?9rEP+vlrPyK508yM=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <AE3CB83E5B61814C81BEBAFF6176ED72@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ad176782-c802-4c33-47fe-08d9f080ebf6
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Feb 2022 12:44:35.3808
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: DxwK4XHTa0q1pFMw3fnDhyT85k/h27TguXkDN6rcr1Rz3AaHv55lomZSFOZPbCcpI8kshkhUYQ2fDlmRxcuwXyQ1ORGXmUnsxMdaL0lV12MoUgJ2kbjdEYmPKjgol0eU
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB3970
X-Proofpoint-ORIG-GUID: tPgPBExVioJw2vdhcadGCqhqxcG3bKZ2
X-Proofpoint-GUID: tPgPBExVioJw2vdhcadGCqhqxcG3bKZ2
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-15_04,2022-02-14_04,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501
 clxscore=1015 mlxscore=0 phishscore=0 mlxlogscore=991 lowpriorityscore=0
 impostorscore=0 spamscore=0 bulkscore=0 adultscore=0 malwarescore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202150073

DQoNCk9uIDE1LjAyLjIyIDEzOjU0LCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyB3cm90ZToNCj4N
Cj4gT24gMTUuMDIuMjIgMTM6NTAsIEphbiBCZXVsaWNoIHdyb3RlOg0KPj4gT24gMTUuMDIuMjAy
MiAxMjo0NSwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+Pj4gSSdtIG9uIHlvdXIg
c2lkZSwgSSBqdXN0IHdhbnQgdG8gaGVhciB0aGF0IHdlIGFsbCBhZ3JlZSBwY2lkZXZzDQo+Pj4g
bmVlZHMgdG8gYmUgY29udmVydGVkIGludG8gcndsb2NrIGFjY29yZGluZyB3aXRoIHRoZSBwbGFu
IHlvdQ0KPj4+IHN1Z2dlc3RlZCBhbmQgYXQgbGVhc3Qgbm93IGl0IHNlZW1zIHRvIGJlIGFuIGFj
Y2VwdGFibGUgc29sdXRpb24uDQo+PiBJJ2QgbGlrZSB0byBleHByZXNzIHdvcnJpZXMgdGhvdWdo
IGFib3V0IHRoZSBjb252ZXJzaW9uIG9mIHRoaXMNCj4+IHJlY3Vyc2l2ZSBsb2NrIGludG8gYW4g
ci93IG9uZS4NCj4gQ291bGQgeW91IHBsZWFzZSBlbGFib3JhdGUgbW9yZSBvbiB0aGlzPw0KV2hh
dCBpZiB3ZSBqdXN0IGRvIHRoZSBmb2xsb3dpbmc6DQoNCnN0YXRpYyBzcGlubG9ja190IF9wY2lk
ZXZzX2xvY2sgPSBTUElOX0xPQ0tfVU5MT0NLRUQ7DQpzdGF0aWMgcndsb2NrX3QgREVGSU5FX1JX
TE9DSyhfcGNpZGV2c19yd2xvY2spOw0KDQp2b2lkIHBjaWRldnNfbG9jayh2b2lkKQ0Kew0KIMKg
wqDCoCByZWFkX2xvY2soJl9wY2lkZXZzX3J3bG9jayk7DQogwqDCoMKgIHNwaW5fbG9ja19yZWN1
cnNpdmUoJl9wY2lkZXZzX2xvY2spOw0KfQ0KDQp2b2lkIHBjaWRldnNfdW5sb2NrKHZvaWQpDQp7
DQogwqDCoMKgIHNwaW5fdW5sb2NrX3JlY3Vyc2l2ZSgmX3BjaWRldnNfbG9jayk7DQogwqDCoMKg
IHJlYWRfdW5sb2NrKCZfcGNpZGV2c19yd2xvY2spOw0KfQ0KDQp2b2lkIHBjaWRldnNfcmVhZF9s
b2NrKHZvaWQpDQp7DQogwqDCoMKgIHJlYWRfbG9jaygmX3BjaWRldnNfcndsb2NrKTsNCn0NCg0K
dm9pZCBwY2lkZXZzX3JlYWRfdW5sb2NrKHZvaWQpDQp7DQogwqDCoMKgIHJlYWRfdW5sb2NrKCZf
cGNpZGV2c19yd2xvY2spOw0KfQ0KDQp2b2lkIHBjaWRldnNfd3JpdGVfbG9jayh2b2lkKQ0Kew0K
IMKgwqDCoCB3cml0ZV9sb2NrKCZfcGNpZGV2c19yd2xvY2spOw0KfQ0KDQp2b2lkIHBjaWRldnNf
d3JpdGVfdW5sb2NrKHZvaWQpDQp7DQogwqDCoMKgIHdyaXRlX3VubG9jaygmX3BjaWRldnNfcnds
b2NrKTsNCn0NCg0KMS4gVGhpcyB3YXkgbW9zdCBvZiB0aGUgY29kZSBjb250aW51ZXMgdG8gdXNl
IHBjaWRldnNfe2xvY2t8dW5sb2NrfS4NCjIuIFdlIG5lZWQgdG8gY2hhbmdlIHdyaXRlcnMsIHRo
b3NlIHdoaWNoIGNhbiBhZGQgL3JlbW92ZSBwZGV2LCB0byB1c2UNCnBjaWRldnNfd3JpdGVfe3Vu
fWxvY2sNCjMuIFRob3NlLCB3aGljaCBkbyBub3QgbW9kaWZ5IHBkZXZzICh2cGNpX3tyZWFkfHdy
aXRlfSksIHdpbGwgdXNlDQpwY2lkZXZzX3JlYWRfbG9jaw0KNC4gV2UgZG8gbm90IGludHJvZHVj
ZSBkLT52cGNpX3J3bG9jayBhbmQgdXNlIHBjaWRldnNfe3JlYWR8d3JpdGV9X2xvY2sNCmFzIHZw
Y2kgZG9lc24ndCBzZWVtIHRvIG5lZWQgdG8gYWNxdWlyZSBfcGNpZGV2c19sb2NrICsgd2UgdXNl
IHBkZXYtPnZwY2ktPmxvY2sNCmFzIGl0IGlzIG5vdw0KDQpJcyB0aGlzIHNvbWV0aGluZyB3aGlj
aCBtYXkgYWRkcmVzcyB5b3VyIHdvcnJpZXM/DQoNClRoYW5rIHlvdSwNCk9sZWtzYW5kcg==


From xen-devel-bounces@lists.xenproject.org Tue Feb 15 12:49:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 12:49:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273121.468189 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJxGN-0006GC-9g; Tue, 15 Feb 2022 12:48:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273121.468189; Tue, 15 Feb 2022 12:48:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJxGN-0006G5-6V; Tue, 15 Feb 2022 12:48:59 +0000
Received: by outflank-mailman (input) for mailman id 273121;
 Tue, 15 Feb 2022 12:48:58 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJxGM-0006Fs-1U; Tue, 15 Feb 2022 12:48:58 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJxGL-0000vJ-Tf; Tue, 15 Feb 2022 12:48:57 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJxGL-0006bM-GK; Tue, 15 Feb 2022 12:48:57 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nJxGL-0000jQ-Fr; Tue, 15 Feb 2022 12:48:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=CSzwitQ0M2AprMMHTSZAdbMI5R5Xl0SLrfLayCiNZ1s=; b=BFYMQL8Aj7i2rQ0l7hIqhbTSlQ
	cQLb0yVFWIUoY4j9VhnjBjxvSeCynfNxdXRbZAuETjbJcxNpN599sCXy4MVov9iSVjLKA+Fc9kn4z
	KNKVerL+tqrrYLbyxOVZ3ZGeyV2yIBg5wycpGmJ35h8Bz7+62UuZH/FQv/asNMczgcCc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168114-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 168114: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=2d88a3a595f1094e3ecc6cd2fd1e804634c84b0f
X-Osstest-Versions-That:
    qemuu=0a301624c2f4ced3331ffd5bce85b4274fe132af
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 15 Feb 2022 12:48:57 +0000

flight 168114 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168114/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168059
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168059
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168059
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168059
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168059
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168059
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168059
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168059
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 qemuu                2d88a3a595f1094e3ecc6cd2fd1e804634c84b0f
baseline version:
 qemuu                0a301624c2f4ced3331ffd5bce85b4274fe132af

Last test of basis   168059  2022-02-08 15:36:56 Z    6 days
Failing since        168095  2022-02-12 22:37:11 Z    2 days    5 attempts
Testing same since   168114  2022-02-14 23:09:51 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alex Bennée <alex.bennee@linaro.org>
  Alexey Kardashevskiy <aik@ozlabs.ru>
  Bernhard Beschow <shentey@gmail.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Le Goater <clg@kaod.org>
  Fabiano Rosas <farosas@linux.ibm.com>
  Hanna Reitz <hreitz@redhat.com>
  Idan Horowitz <idan.horowitz@gmail.com>
  Ivanov Arkady <arkadiy.ivanov@ispras.ru>
  Jiaxun Yang <jiaxun.yang@flygoat.com>
  Kevin Wolf <kwolf@redhat.com>
  Michael Tokarev <mjt@tls.msk.ru>
  Pavel Dovgalyuk <Pavel.Dovgalyuk@ispras.ru>
  Peter Maydell <peter.maydell@linaro.org>
  Philippe Mathieu-Daudé <f4bug@amsat.org>
  Richard Henderson <richard.henderson@linaro.org>
  Stefan Hajnoczi <stefanha@redhat.com>
  Thomas Huth <thuth@redhat.com>
  Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
  Víctor Colombo <victor.colombo@eldorado.org.br>
  WANG Xuerui <git@xen0n.name>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   0a301624c2..2d88a3a595  2d88a3a595f1094e3ecc6cd2fd1e804634c84b0f -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Tue Feb 15 12:49:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 12:49:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273130.468200 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJxGp-0006l0-KQ; Tue, 15 Feb 2022 12:49:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273130.468200; Tue, 15 Feb 2022 12:49:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJxGp-0006kr-GW; Tue, 15 Feb 2022 12:49:27 +0000
Received: by outflank-mailman (input) for mailman id 273130;
 Tue, 15 Feb 2022 12:49:25 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=p95L=S6=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nJxGn-0006gH-Pa
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 12:49:25 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b402a812-8e5d-11ec-8eb8-a37418f5ba1a;
 Tue, 15 Feb 2022 13:49:24 +0100 (CET)
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur02lp2055.outbound.protection.outlook.com [104.47.4.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-34-n1EzV4T3OBmOPGZu6QCiog-1; Tue, 15 Feb 2022 13:49:23 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM8PR04MB7475.eurprd04.prod.outlook.com (2603:10a6:20b:1d4::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.14; Tue, 15 Feb
 2022 12:49:22 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4975.015; Tue, 15 Feb 2022
 12:49:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b402a812-8e5d-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644929364;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=ks5G3+K9agsJFJ8Q5UpQ/uwTa+dFY0jG4w2XFjRM/Ng=;
	b=UeuwINtENgZdmnR+VEhi37oEkDL5NaLLJG9XC+f8zX58TB/5/0EvMy+7hM3lKgzB1HCIYl
	H8YAKpD3oVGN//EHAsmEftaSzwwWD7yrYLoaefgWhSX00Jmwa+3YCXmt0LQiMazWe1b/aK
	lSTEmlZgNXsJslSlHdAaIY/TErJ8M+A=
X-MC-Unique: n1EzV4T3OBmOPGZu6QCiog-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=LwhzS2HsKDHOTwaBU2fyNTd//PrJfJfLmOGkGYzjgnj66CBS/SXHf1WGfkODvcA57xqBeQODjwxYHcQepDvPHV8a/LxBng1Y14T/ECeyBtr4G+i1I7LDdvFW2hKjaPdrG3idkO4DWPYPq9cb3SlqsT6lC6SCqDCbRM1CzB4qmlRvzVdz7B4VLRsMhxVAgqHwUeILhJpb/sRJGnEZQBQReT5v2UbMvsfn2rvp6wcTdeP7CgHXoVjoE5RyCNSgcWnIphJLE/Joz1JN7rVu0Nx6znEVcNQR12so0Fop7/C2Z+xbjoEv5xjOSiddEJRU5bLHM6skHAlEj1qmKRgSwFkgzQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ks5G3+K9agsJFJ8Q5UpQ/uwTa+dFY0jG4w2XFjRM/Ng=;
 b=UYVI4G/H+BNT29Q5cknS8TRihhEmhUgwmd+wks7Z2ntBbefLyFD8QYwPtbHNcHkvh7+Es0vV4KUY5D7t6RMeF02DgsiP23bfc7gg24o6T+ajQrk0/bgC3XpXePrswjYfxsN5Q8GGRTlJ6zHEthKkfNLskBmDNLhX7Ln8ud7Oq3IDxa0LPBw7DH9OP9nkRGW3shBztBHfSzDcgHUsyXC6vOPCMADC7HlESxB7b4cmucU2f/wjszRX+lQ3WcJI00QRRHvukC2wyrbEj/2eY54XuviUyDKey4ueCz6vtICpyShO5j4nipsNRBHZb5iYc3C1fmHGEahdaO+4/pTgQ/kWDQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <34832b7b-c1c0-06e9-9214-6c434cfb1282@suse.com>
Date: Tue, 15 Feb 2022 13:49:19 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH v2] vpci: introduce per-domain lock to protect vpci
 structure
Content-Language: en-US
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "julien@xen.org" <julien@xen.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Artem Mygaiev <Artem_Mygaiev@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>
References: <20220215081135.1497470-1-andr2000@gmail.com>
 <YguE7RWOteSnvVNY@Air-de-Roger>
 <c5b9b02c-93f8-d018-6048-9abf2e7de4dc@epam.com>
 <YguQ8wfhfYFXTWSU@Air-de-Roger>
 <70dbd7fd-3f74-d0d3-6e30-c1e1e24fc279@epam.com>
 <0d8f01b2-b015-a08e-dd49-e9c688ff7245@suse.com>
 <bbb36ebc-de66-297d-f82f-abc0e63f20a2@epam.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <bbb36ebc-de66-297d-f82f-abc0e63f20a2@epam.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR04CA0040.eurprd04.prod.outlook.com
 (2603:10a6:20b:46a::32) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4b5e5def-d5ba-4b10-ca1e-08d9f081969a
X-MS-TrafficTypeDiagnostic: AM8PR04MB7475:EE_
X-Microsoft-Antispam-PRVS:
	<AM8PR04MB7475AB007FEF2724100DCD12B3349@AM8PR04MB7475.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	KMPFsZ3ED89ARuP/FmMGR8/s0qmfZWldVJBoVIIfAwyGCFSfaqRh4+vcm8oMmrAU8luXC/+60TucLlE9FPgYX/TQ3HikPF3V14VSHo3EuS4nXVgRbqJGBF847HFhIZ+ZOVL3196G9805H262Zel7b6+JyP7ry6g8lWUETLvxUVCMbwexYUvLYBtNp+C0DjVff43B0TwM765zCQaTB9nnP2AoDKxV5o3nn9Eq+DMUgkGTgGpku5bSoywcqPe8pvaSk6fiH2bLqKFZBMPOdEZZM1fNor91uQ+LnU7ztblBzqbYxnoKWm82CgjKxe+yxaoo9TinJhnwo0P7kUER2PrNdaUaQHghVy4fmrR6fjlgFLIPYswC3/YI7UUEYc2Dv5CY/4ydwmBdLMHqx+9/RfBX/Ax7ZgfV8bHHmYYUkQiHckRTC3Flp0blJTUiQ6jRVVVXSfcdMX1t5b5GkR/uSFTg0dcPS3n4S/MZlFpAgZQ68xZr5WiU2RVCQLJa2s6PdN2mqK4LmIKycv5+L20GA823XpC945Zq73mAu3INiNBf19ir4SznrKmtdjsBXvm72p14hT8aR+K7FsBW6YU07bK8CL1/Zgtz7AUPMUzL1wLgRzZzAQbB1nXhedM51oaXbH1vymOX/D2Tx53Dot3Bx8pP/WPYwK3wyyZ8NYS7h6wCpOjTqss4li9CGts0WM0Ro/qmLfZgBsr9xbKviSMmVL+GHIbLbB0L7lw1G9BlnSU7mtI=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(31686004)(8676002)(4326008)(6506007)(4744005)(7416002)(26005)(8936002)(36756003)(186003)(53546011)(6666004)(6512007)(2616005)(86362001)(6486002)(83380400001)(38100700002)(316002)(2906002)(6916009)(66946007)(66476007)(66556008)(31696002)(508600001)(5660300002)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?SGlZcUNUS2dCTjAxeTZVTUhWM3hPOE5vdVI5dnFVVWUwYWVLakg3YVA1dEpL?=
 =?utf-8?B?OWJVRS9tVkY3Tnd5ZzZuZnJPUjJ3NXN1WnFSVGlHY0psOC8zOHpGTW42UW1x?=
 =?utf-8?B?b1I4TFBxOTNISDhnMlh0eHJJQVBSSUpUL0luWUg4M0U4VytLSUFsOFBiQlVJ?=
 =?utf-8?B?dExSNHBZcjY5d2VhRHk4SmhQNUxDcnRTemJIZC8vMG1GSDhEdFB2b1VBTWo5?=
 =?utf-8?B?cnQzbTJOMmFSK1hKRVNOSGFnQVRpdTRvaTlmZUJxSEt2TUptNUVMd1VDQ0tP?=
 =?utf-8?B?b3NKVllnL0FMNmZBUlozR1kzMzZGVDJnbkpmSjVKVmZ6a0ZIR3l4WWVFc3Rx?=
 =?utf-8?B?TTdQbzlDV3ZhTXM1OHA4eGFUa1pCL01iTzd1b2xTa1VKVDJuZktaSGNvT0E0?=
 =?utf-8?B?VVA0NUZjYTBGeHRjM3lHZXNtNll3c0JzNW0yamppakNlZnRWa0VVT1JYa0JZ?=
 =?utf-8?B?UnZ3aU41VXMwcU96Zk9xdVQ5Sk91b1R1UHVLVFFvWHVZQkxzNVErTmxkNkFq?=
 =?utf-8?B?cnZhZ0JMdTZ5MCtGenJEZU95NkJoTC83dTBhS3l6Q3AyVUJxdHZ0bGFBblJ5?=
 =?utf-8?B?ZkdOcjdnWWRybFdERUJZcU9UY1ZUQmxXU3NsSDRHRytYNUZlK2NHQy8xeExu?=
 =?utf-8?B?RzFYTXREczIwcjkxdlBvZ1hESEREakdFdzdKUzRUZ0J4MVJGT2p3cXp2NzBD?=
 =?utf-8?B?UUpNY2ptTnhrUHlubEpueTQ5ZWVoTmxtYTB2SVNTTnNjbGhsSndYNWVLU2JB?=
 =?utf-8?B?V0N0SjFGOXpodGhJMEhnNkJRWGxMMEtSWkgwc0h5Rjhxc1ZoVkUxenpWdDRY?=
 =?utf-8?B?RW9VV3BvUGd1Wnl5RTU3Vkh4RFhmVnFsaU1VVFpvR1VzWnprL2RSamRlQTQ4?=
 =?utf-8?B?dXFNZWFvM1owdGc0REpqUHlZY01ocGhPSXVEbTZwKzdNd2o5SEZFckFWWlhW?=
 =?utf-8?B?Qm5kT1JETXBOL29XVkZFMkJjOURtOW5Dd2ROYWFkWk43anhYWTQ4S1Jnd3ps?=
 =?utf-8?B?eGFWdDZMVkpaMDREaW1zVGRVYVlta0U5eWFQbzFzZytvM3orajlZS3FQZTR4?=
 =?utf-8?B?RkNLdmx1UjNhR01NWm5QWVhYa2JYZU4yTlZwSFJYRThSQmlKaFprby9jZTE1?=
 =?utf-8?B?QXg5bXVCMnRRcXBoeGJPOFZwcVNQZEJsSEZWZWFqa3ZXaVBOVTJTYzVCekZC?=
 =?utf-8?B?S294ZVlzekZCNzBlRmhuUEx5Wmlsb3YySWtKbk1wbjF3bzlZeDlGTG9DTjNV?=
 =?utf-8?B?M2o5YXpiNjk5WksvNUtWYXl1ZldZUGZrdjc3ZGx4K093T0lXVkhrcTNPR0hl?=
 =?utf-8?B?M3FWdjJzWlhDbnBkMkdTS1JyK2Zsc0hXeG1mU1IrYXUvSVFTblZRVndGUEdK?=
 =?utf-8?B?aTk0S205Sk1JT2JRZk9kVmZEQ0h4Z0l4eFV3THk5QUtNNjF0YzNzaUo3Y251?=
 =?utf-8?B?Y3NlMTZkeEFhVUhNRE0wN3gyYXI0NW4wc2NZZ2xid0c3MThuT3R5WC9nVU96?=
 =?utf-8?B?ZFRtcitoYUdFSXlJMFJIMUhJcy82RE9heFNpZTZrNDg5SUpEYXYvcjBIWlN5?=
 =?utf-8?B?NHJPd3E5ZnpVb05HbmRzR1FwZXdza2xiS0hhRTFiYkRFY0xvcitDeitSNDU4?=
 =?utf-8?B?OW1Cem5maGVOQ0NSeld5TkZVL1JHRU42UEp6QlI4SjAvWjRPQUlwYzk4QXFn?=
 =?utf-8?B?Y21KTVlZM2ZFdi9vSXZzMlJFbWszQTFQd0RVT1pCTDBqN21RVi9oMmJHSDBV?=
 =?utf-8?B?TVdSd3JCUUdFRDFYSFo5OUpwQ1IzNG0xV0ZIQjF6c2FFbFFuSWtNUXk5aDh1?=
 =?utf-8?B?Qjg3SGFOT1hHVDRpQVlJU3psS29UR25vZmRFb3dOTkxsOE0yciswb2VUZFAv?=
 =?utf-8?B?blYveUloeHZ3aEFWMGRSeWZuSWZVS0wzYXE3WXdTNGpaTjRpdmxFU0NLUm5z?=
 =?utf-8?B?bHNIbklwOXZiWDN6OEZVRmN4RkNMNXhCYTllUS9SVEswcllZNmFFR0twMUlC?=
 =?utf-8?B?SHJiUkJ2NHpZRVZRTzhwdy9vcHNpcVd2dG5ZdGgvWS95a0UrYUdnNjJ5VStS?=
 =?utf-8?B?Zi8vdVJyd0hOeGRmalFhV2VFVEg1YVFTQXptU1d2T3F3NmhCbjBKMk0vZzQw?=
 =?utf-8?B?Z3A2ckl4RnZ3YjRVdGc0ZFRQd0Qzc2VwdTF6VG9Fa3V3MElBbDNDQndUTUlY?=
 =?utf-8?Q?jeLImo4P6+e5t1xDIiH4QDs=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4b5e5def-d5ba-4b10-ca1e-08d9f081969a
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 12:49:22.0153
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UPq2xNMIuuhrVHNxgfoz1oFri8bO9pXZGODdze0ptp+jGkcRAZVSAlNb2Dgg9omzhM1o24rgHgebgk7gC11vWA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7475

On 15.02.2022 12:54, Oleksandr Andrushchenko wrote:
> On 15.02.22 13:50, Jan Beulich wrote:
>> On 15.02.2022 12:45, Oleksandr Andrushchenko wrote:
>>> I'm on your side, I just want to hear that we all agree pcidevs
>>> needs to be converted into rwlock according with the plan you
>>> suggested and at least now it seems to be an acceptable solution.
>> I'd like to express worries though about the conversion of this
>> recursive lock into an r/w one.
> Could you please elaborate more on this?

Not sure what to say beyond the obvious: At the time of the conversion,
there certainly was an issue to be solved. You'd need to solve this
issue differently then. Plus you'd need to make sure that no further
incarnations of the original issue had been there or have been added in
the meantime.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Feb 15 12:57:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 12:57:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273142.468217 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJxOC-0008Qk-Tl; Tue, 15 Feb 2022 12:57:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273142.468217; Tue, 15 Feb 2022 12:57:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJxOC-0008QL-O3; Tue, 15 Feb 2022 12:57:04 +0000
Received: by outflank-mailman (input) for mailman id 273142;
 Tue, 15 Feb 2022 12:57:03 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=xOiq=S6=epam.com=prvs=4045782cdb=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nJxOB-0008Ms-Cw
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 12:57:03 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c44441c2-8e5e-11ec-8eb8-a37418f5ba1a;
 Tue, 15 Feb 2022 13:57:02 +0100 (CET)
Received: from pps.filterd (m0174682.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 21FCpm6v002326;
 Tue, 15 Feb 2022 12:56:58 GMT
Received: from eur04-vi1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2057.outbound.protection.outlook.com [104.47.14.57])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3e8apa8hu0-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Tue, 15 Feb 2022 12:56:57 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM6PR03MB5235.eurprd03.prod.outlook.com (2603:10a6:20b:c6::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.18; Tue, 15 Feb
 2022 12:56:54 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::fc4d:4749:5d1:eb73]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::fc4d:4749:5d1:eb73%4]) with mapi id 15.20.4975.019; Tue, 15 Feb 2022
 12:56:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c44441c2-8e5e-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=YIMy1RqA0bpPgbKnVaCXOW9Qc5EoqaatsCm4E6ZheZ5x6eKu/gRvawY9r/fEhnxwrbiNylCcCJtMdLQWb0ndvWwY168amord4eOw15CjkePqniyNrifadYwvXXj4OGV4J3/fl9FkDlnn33cQBa+wZUeGq2kSjaUpokxzPyjMGOuhPNRbVc3JvAVo/Yx4nyFFbGSenv+QAxb1daot9t17dXGW5S1L3cRxUw2FaR0g4QU7ilV13dK5YB+bFtoV73fR6G1d/m5nPy8te7Bmgntn/FP4oILl+2sldV5BoJFPU0vlq3N6BC6kUTsNnauPtii8IQb24bZI8n8TX7zJJF5NOQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=0qU4sQkyqUjQnwqBOMm9sNau7Cji4hxy1oJP7CcMdoE=;
 b=i8/nGRTsRRY8q6LONUPOvTvXuFJ3HwQmaBRJfwOkOQTDtxxDp49Xf5dq7ReW3iiMDe81ti2bbtQcAQ5QZ8eoRu+5N18ehhYUQjBdQSQVfYxGlFx+loTsk5ZccTbQ2Q7UuGgXbh3KO90cU7XbC2q9zFFSacQ8eEBWEKsxI06cdpJbTl5Awbm5qifvs/xYcwA4FJPRtfrzP99IUqGYl8sP/WCobzSdokTs0+4TGvxrSUCL9NgonUjE3Suj2QqfH1CsxL1CLBVx/Ltk0LSqFFmBm56RU2U9JFI5c4poQ8a4sXer6UlghDT5Pqrv4jmEJFr6/MHNVqpsVNa2RW08WB/FxQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=0qU4sQkyqUjQnwqBOMm9sNau7Cji4hxy1oJP7CcMdoE=;
 b=RIZb+KFlAx5MGAaHhdtmso+wC5aMudr5aMWoiKVuQ28HUn5dya6DoodKxlSZQx32CpGDc9RWUgWyyxf2IMwf+q2l3DuX9m7fG0HViShdonOOIOwzW4hZtpcPqxbfPdYI/I4FEPXf+3Gm7Wsbi7GV18c2+KEf1pQZtCTp9TTrcN4qpkJpKeqsCNT0H6O7rzo9cek13/e4XUJwP7f3cUUoHZCT0N1nqDUD2tz/T9YCfkebCpUOm5GJR+nEzg3zNx0wHbdVPBuLT5PdPVDkLH+JS/0CPVSWk+BhokIegp822pcsnaf8vhmpOPShpmzQtJRlNgA0M9nOVoHLwCtKnVtWKA==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?=
	<roger.pau@citrix.com>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v2] vpci: introduce per-domain lock to protect vpci
 structure
Thread-Topic: [PATCH v2] vpci: introduce per-domain lock to protect vpci
 structure
Thread-Index: 
 AQHYIkOs9pmsZb0l5kefj1m3qdTVCayUboeAgAAGwYCAAAeVgIAAAZQAgAABlwCAAAEVAIAAD0CAgAACHAA=
Date: Tue, 15 Feb 2022 12:56:54 +0000
Message-ID: <9f4e7308-6ede-302d-35c1-6fa824df69bd@epam.com>
References: <20220215081135.1497470-1-andr2000@gmail.com>
 <YguE7RWOteSnvVNY@Air-de-Roger>
 <c5b9b02c-93f8-d018-6048-9abf2e7de4dc@epam.com>
 <YguQ8wfhfYFXTWSU@Air-de-Roger>
 <70dbd7fd-3f74-d0d3-6e30-c1e1e24fc279@epam.com>
 <0d8f01b2-b015-a08e-dd49-e9c688ff7245@suse.com>
 <bbb36ebc-de66-297d-f82f-abc0e63f20a2@epam.com>
 <34832b7b-c1c0-06e9-9214-6c434cfb1282@suse.com>
In-Reply-To: <34832b7b-c1c0-06e9-9214-6c434cfb1282@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 41022b7c-a9d2-4672-9d00-08d9f082a474
x-ms-traffictypediagnostic: AM6PR03MB5235:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM6PR03MB523500BAEFF602AB76559689E7349@AM6PR03MB5235.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 yPMs7YN1W1uVIM7wyjSYAn12RZ2JoPdnaCQo49ygtAGd4V2AppC/E2v+NpuyayXgpmf6Vrj7Qvwm2XkyX7+v+nt43qWIrDCZn5cfZJk2+80sxHpZTScLEuWOyel3R7D1ZUXG3brJLGpvlVsWAX3S5NlVAqF7b6J7nGLQEUkQBdlOhOqws3eQn9ULtn0Bi0nXSydLi7yZ/qUizKytyBHyAiEBTd1INkl9/TBmTd5rrP8y1AYu+OU1Of1QkC8dqzvcDlXRxSBToYgHsHSs2DxyW4AuCf2lyvceN3G0QErEb5q64kdvSciAyKJeRb4Tev21xahMB7IMmb4evTvy9XqGuG7W3C2eG0CfaYJW41MR1pGhsP/yBCVPOKRk/Xhm8TH2M2yP3wFA8540SiROaaOUPosSNaLIGEs2gfhrkHRxz0t4YJqGsYvT8zDwODZ2cE4uYivL9iZXtrmkPg6YN/rwhGCZBMTuasaX6MUkGYh0Bgtmgivkyv4OHP9FnUtRi9x6bYjSButeJW4u8oUgsse5W97Ejn0WutaDHNdqjf69swGToBwSFXiPmvqhSp/CbnLnLYCgkoyFEGScasIP/njBSoXrRhID3BkXXJkkHtojXOQowW0cOwhxoWvFahwNWc+rimxIMzqh+MSrUfl346LvH+RXqofmlDi9xfBGsqlJTpK44plowhiS7LnJQThJfCZptbhIp263MNVg827d+BIaKTs40FDoLfevKBIBA1VGjJE=
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(2616005)(107886003)(26005)(186003)(31686004)(6512007)(2906002)(5660300002)(4744005)(8936002)(55236004)(53546011)(71200400001)(83380400001)(6486002)(36756003)(508600001)(6506007)(31696002)(66476007)(122000001)(38100700002)(76116006)(86362001)(38070700005)(54906003)(91956017)(4326008)(6916009)(64756008)(8676002)(66446008)(66946007)(316002)(66556008)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?MDlhR3BHd2tlcURjeTdtZG11TmJKUVRxRkdwZHc5RkFpZWZqNXA2OVhZNklN?=
 =?utf-8?B?ZWJBWUNibmh1anFSUVh0dlovYzVQcWJNS05xQ3RoRGRGUVE2MkJIZXp6Zmdw?=
 =?utf-8?B?dUVUcktPM0NtMTZ4YkN1OTVtRUNCK0VUZUZBNjFwSDJob0dzV0MyV2hKL25w?=
 =?utf-8?B?L0ltaDNMZkxuNEhKNWYzMGhOcWZOVVIwYUlqTFNCcTdtR3BzdEFiY1BpWkYw?=
 =?utf-8?B?VEhRdkdnU09jbmpBQXgvcHZ6WVN3YVU4R01vT0V5K3lVdkNGSjhyc2lSNGlC?=
 =?utf-8?B?SVAzcmdjYWhIMitXb3pPZEtPQmhreXpjc0Q4cDVMVmFhbnpmaUZZWm1jbStz?=
 =?utf-8?B?OWhMM2txUGt4cXJLVXY3OTFTTEsxdmp1Y3NSdWUvd0FPMFRmZVBxcTd1WHFu?=
 =?utf-8?B?TmdKZmhGaEZDOXE5M3dGWGNxRURUakIzY0xreE1XUmhIdSt0OGl5eHMzUHVj?=
 =?utf-8?B?eWtjdDA4Q2s1SURpeU5qaTBPeExxZ0cwY01KdjlGYzU4aUdlWUtDSE51d1JQ?=
 =?utf-8?B?NnFVaks4ZkRCU29BWjlMN3RCRkNDc05td2lvTU81czd1Sm4wRlI0K1ZPamNO?=
 =?utf-8?B?UFlMdDVnTU9MLzByd0hYNytRNmxEMjB2b1luMng5TVZYb1NMaGhkOU92UG84?=
 =?utf-8?B?MmgyYXlqdGIyOTJVNkRuekRjM0ltQTllMi9GQ0pvcXhaMDdLaC9QcDlaMThP?=
 =?utf-8?B?YnZ3Vk9rWjlLdjJxQ1lFRzJKWW0weTFreWZPc0lkck9mckI0K3pmZkZYNkdj?=
 =?utf-8?B?ZEdzRWZMeHEyWnlLODNXSU5tUkhlL25IeEJ4SjdyWG5JV0V5aVV1M21GK05K?=
 =?utf-8?B?TzJDN21VQmxZUDMzSEFVUm1WeVFJUmc4V2JvOU9DRWRKTk9OZ3U4bkFYdDNk?=
 =?utf-8?B?MFN1V1lKbDMvdmFDRVpSTlFIaUgwczhJd2kvOEhHK0NNSDRKUEN3QVR5QW12?=
 =?utf-8?B?VTR1d0MxMUdCVnVDNUIwZmtCMUVyNmtnaTZxdFFsR2pYOTdrS09iVlc2VmRw?=
 =?utf-8?B?bGpqdVRmSFlBSi9TOW5nRU9xNWdyZEVqeUNWdG9sWUlxTnd3ZWwxdGI4Y3Nv?=
 =?utf-8?B?eUpXdEJpK2ZXczlteTBKYUdMcnV6T2MyYldMTVRpWnUraGdRZ3BPOFNVem41?=
 =?utf-8?B?eFJGdTBhNDZEZzcrcmZySlNNTjBqNXBnWWZSMVhpVnI1aDR4MFlpYmprc0V0?=
 =?utf-8?B?RFRjenNFSndWRTNndEg0bFgvWEViNjdlV2RleGRCOHlISEl4emJBa1hyRGNj?=
 =?utf-8?B?cU5MRHE2OFpWeEJVYVBEcDkxcWJwNFdFc2hNNzVScVMwanJwTExIUG1CT01Z?=
 =?utf-8?B?ZTYrNXFrUU9LblA2ODVJZ0kySmFVYjVnSnZXQzVZWjNKazZaYzhqRjg0eGNz?=
 =?utf-8?B?dnJyYkd1OGNMUndLb0dDWDd5VkNLbnhMekcvSXFOYjUvUHdWWWIyOVQ3Qy8y?=
 =?utf-8?B?UWNSVzlUSWxSRHRidXVraUZCNGpQcEh3cmlzYXlvMTRIQzQ4bCtwTmIxRndr?=
 =?utf-8?B?V0ZwdGxablpRd0srRkZPdHJ5TzNlMitKQjBhNU9QalFUeEthT0xzS3NQSmhp?=
 =?utf-8?B?YkptQjcvc2xxTlpYQ2pLT3F6MEtabzU3ZWxaTnR2TVd1VEpDRFViZnJFY1pF?=
 =?utf-8?B?VmpVcGsxOElUUWpZVmdtbDd6OG05UkpoRVVUZHViekZpdFZxalpCQUpLWi9U?=
 =?utf-8?B?L21aUjcrNTJHY3RhbEJzSTh2YnZJMVJETVFza204OGFpQXZHV1pvUTZJNTM3?=
 =?utf-8?B?cXc3WmdNRFZoaGxKK24xNVJ6SElYT3JLYnhYQUFmRTcyYVBQM3pPZDUrS2ZM?=
 =?utf-8?B?WGxYTUlvcEw3eWVRT3FlZGxOaTFQUjhCd0JIOVgzVXdEeldWUHEveW9rUXZG?=
 =?utf-8?B?OXJrcWk2WjhjYk84Y0YrTXhGcFhUbFdlakE3cENCL2xWaEhNOGRlV1lqbTJv?=
 =?utf-8?B?Y29odWlYNE1iQ0oxRWJCYnJoSlhvaEo5bjRtZGhZalFIL1o2b1BXcHlSdk8y?=
 =?utf-8?B?Z3ZtNEEvVUcyVHdEdFM3ZEJBdEUvNUxmZmpEa0pud2h5QUhSaFNvVkdNVFA1?=
 =?utf-8?B?Mk9kNXNOajc3cFRTVktNTDlZNnUwUEdLZWZXcDBYeDJWa1QyeVRKUlByWEN4?=
 =?utf-8?B?RlJ6S2dGSHdqRjVLSGpjY1oxT1Y3T1ZNR2xxV3BjdFBKWW0weEVjZTRva1BV?=
 =?utf-8?B?WGZVdVdibE1FZGpPNjF1NFRUTXQvMWNkaDBtNUhhU3NQNm9ZMnF0MUFTaGFH?=
 =?utf-8?B?VzQ1K3JaSnNHOVNnWEd5MENvRTRHQTV1dFpld1QrTEFhSUo2K0pML0lLaUpL?=
 =?utf-8?B?NGNmWFpxdDk3ZFFraXlDcEw5Qm9mSnpOK0hXTHdtc01DcUczTm5zNVBxcWNS?=
 =?utf-8?Q?B+KrN5Lv5iHlaYHQ=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <1FC0F05EBF73554C92FFF94E178D637E@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 41022b7c-a9d2-4672-9d00-08d9f082a474
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Feb 2022 12:56:54.3594
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: NKwSessZyWwPVDcnZn8IOjHxjXAyeHJa2/JwAAln8Yo0gVq8IUoXxbuYTYodZYcASuk/v5PDgHqs31EFUrZ3cNPR513qIGreitQxYb78a8jbWoGGRkDg+jEJ8TrQP+zt
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR03MB5235
X-Proofpoint-ORIG-GUID: wShCf-yNj8J6zw3LKHFe3A0YasgsAOlq
X-Proofpoint-GUID: wShCf-yNj8J6zw3LKHFe3A0YasgsAOlq
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-15_04,2022-02-14_04,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0
 bulkscore=0 lowpriorityscore=0 adultscore=0 spamscore=0 impostorscore=0
 priorityscore=1501 mlxlogscore=999 suspectscore=0 mlxscore=0 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2202150074

DQoNCk9uIDE1LjAyLjIyIDE0OjQ5LCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMTUuMDIuMjAy
MiAxMjo1NCwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+PiBPbiAxNS4wMi4yMiAx
Mzo1MCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+Pj4gT24gMTUuMDIuMjAyMiAxMjo0NSwgT2xla3Nh
bmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+Pj4+IEknbSBvbiB5b3VyIHNpZGUsIEkganVzdCB3
YW50IHRvIGhlYXIgdGhhdCB3ZSBhbGwgYWdyZWUgcGNpZGV2cw0KPj4+PiBuZWVkcyB0byBiZSBj
b252ZXJ0ZWQgaW50byByd2xvY2sgYWNjb3JkaW5nIHdpdGggdGhlIHBsYW4geW91DQo+Pj4+IHN1
Z2dlc3RlZCBhbmQgYXQgbGVhc3Qgbm93IGl0IHNlZW1zIHRvIGJlIGFuIGFjY2VwdGFibGUgc29s
dXRpb24uDQo+Pj4gSSdkIGxpa2UgdG8gZXhwcmVzcyB3b3JyaWVzIHRob3VnaCBhYm91dCB0aGUg
Y29udmVyc2lvbiBvZiB0aGlzDQo+Pj4gcmVjdXJzaXZlIGxvY2sgaW50byBhbiByL3cgb25lLg0K
Pj4gQ291bGQgeW91IHBsZWFzZSBlbGFib3JhdGUgbW9yZSBvbiB0aGlzPw0KPiBOb3Qgc3VyZSB3
aGF0IHRvIHNheSBiZXlvbmQgdGhlIG9idmlvdXM6DQpJIHRob3VnaHQgeW91IGhhdmUgc29tZXRo
aW5nIHNwZWNpZmljIGluIHlvdXIgbWluZCB0aGF0IHdvcnJpZXMNCnlvdSBhbmQgeW91IGNhbiB0
ZWxsIHdoYXQgaXQgaXMuIFRodXMgdGhlIHF1c3Rpb24NCj4gICBBdCB0aGUgdGltZSBvZiB0aGUg
Y29udmVyc2lvbiwNCj4gdGhlcmUgY2VydGFpbmx5IHdhcyBhbiBpc3N1ZSB0byBiZSBzb2x2ZWQu
IFlvdSdkIG5lZWQgdG8gc29sdmUgdGhpcw0KPiBpc3N1ZSBkaWZmZXJlbnRseSB0aGVuLiBQbHVz
IHlvdSdkIG5lZWQgdG8gbWFrZSBzdXJlIHRoYXQgbm8gZnVydGhlcg0KPiBpbmNhcm5hdGlvbnMg
b2YgdGhlIG9yaWdpbmFsIGlzc3VlIGhhZCBiZWVuIHRoZXJlIG9yIGhhdmUgYmVlbiBhZGRlZCBp
bg0KPiB0aGUgbWVhbnRpbWUuDQo+DQo+IEphbg0KPg0KVGhhbmsgeW91LA0KT2xla3NhbmRy


From xen-devel-bounces@lists.xenproject.org Tue Feb 15 12:57:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 12:57:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273141.468211 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJxOC-0008NC-JW; Tue, 15 Feb 2022 12:57:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273141.468211; Tue, 15 Feb 2022 12:57:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJxOC-0008N5-Fg; Tue, 15 Feb 2022 12:57:04 +0000
Received: by outflank-mailman (input) for mailman id 273141;
 Tue, 15 Feb 2022 12:57:03 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=p95L=S6=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nJxOB-0008Mr-59
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 12:57:03 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c4335ff1-8e5e-11ec-b215-9bbe72dcb22c;
 Tue, 15 Feb 2022 13:57:01 +0100 (CET)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2051.outbound.protection.outlook.com [104.47.13.51]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-14-gSVUx481N8qIdHcenJnjqw-1; Tue, 15 Feb 2022 13:57:00 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM6PR04MB4567.eurprd04.prod.outlook.com (2603:10a6:20b:19::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.19; Tue, 15 Feb
 2022 12:56:57 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4975.015; Tue, 15 Feb 2022
 12:56:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c4335ff1-8e5e-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644929821;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=go+4JVL+XMxFCvrmlyw7wy8tS7nQ7lqr2Sy72F2wM0w=;
	b=VvpuxiClt16VCfuJnhjCYenjDVGpXXyDbMhv6VGsF1d3rpL8FQeuROkdndAscKLyTWo6S1
	LC8FpTGV4b8YcLvOsJmWtK7IU6D86Ba4hrYydaIrYHPGy8l6EWaLU6yCLK6uvXhA5hcbii
	q/sEBWVOXhvpS/bVAnjKiLburbTceC4=
X-MC-Unique: gSVUx481N8qIdHcenJnjqw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=WE4sA1ZBoT2AmRbF4gvI9XOM/Yb+/JslQ0A2/H6SIxDdAurLXfOi+YIU2Ysfnmqjd5GrR7StzD1oYkWYhZScaX3DJtmkPef7zmc2k0/zV8uq/UV8VqIs42aSFnRrK0fnv6SiJDz2RSA+5wbVLGEUGdJQaIpaDRg1Cb6MpdjRUyNtCnIHCHYmBeJlSgdrDlzIcDWmb24XYXeDO/L62tHShnqLYyQbW1E511ypPJFoI6xg4wuaKJqyNfWGXuD22jKZkkhROCL8mRr3t75Xi9fdHQ+k8GY6ZXpGgYC971XEKVOBuCio7payTLH/v8sN3Be1dlwSx+eN5YFG+Tj/4iHq+Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Xdf5Z8VRt6KiPSDfUeY7PKAWUyi1LeDNdm/nayjz20o=;
 b=JQ6vWq9HAudmQelJ3rDaKvD0uLs6DDv2f3s78e3aFXaEnrUAMIpE6xjlfu5BvbJdrL3k8ED33EHQkXE/wgg0pLzx1aLC4k6wtzeAzbZQoImfo2Pq7mrFD1OOmHEXKjkCADEIKES41MzhlabgIHYGsrMF+9GyX83zkumkNxE4dQO8nBBkI3Rs6xI0jEbj5O31YSuzqbUaB1nJHCaN2e5iJJrp5CDSywnWAyVCwBTm+krdV2c1c5kL5FOMknE4xuw0ZDpySP/5/6ECAJ/1QolwVTZH7EKOoxrURusp8tddVbBVGfO9VOnQhvNm6UNtthvENFeGC2T4ccvYsu5n4Otzuw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <772eb410-be1a-3b5f-3b51-e363c43bc3c6@suse.com>
Date: Tue, 15 Feb 2022 13:56:55 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH v2] vpci: introduce per-domain lock to protect vpci
 structure
Content-Language: en-US
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "julien@xen.org" <julien@xen.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Artem Mygaiev <Artem_Mygaiev@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>
References: <20220215081135.1497470-1-andr2000@gmail.com>
 <YguE7RWOteSnvVNY@Air-de-Roger>
 <c5b9b02c-93f8-d018-6048-9abf2e7de4dc@epam.com>
 <YguQ8wfhfYFXTWSU@Air-de-Roger>
 <70dbd7fd-3f74-d0d3-6e30-c1e1e24fc279@epam.com>
 <0d8f01b2-b015-a08e-dd49-e9c688ff7245@suse.com>
 <bbb36ebc-de66-297d-f82f-abc0e63f20a2@epam.com>
 <22d25499-cab0-00c1-3ad3-bddd74c97a55@epam.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <22d25499-cab0-00c1-3ad3-bddd74c97a55@epam.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6PR0502CA0042.eurprd05.prod.outlook.com
 (2603:10a6:20b:56::19) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: dad0a25a-6dd5-4bee-dc7d-08d9f082a651
X-MS-TrafficTypeDiagnostic: AM6PR04MB4567:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB456740B2C6CFBF9A8A9360BFB3349@AM6PR04MB4567.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	qIzcWVGBO5BAk70H4CJ0Fq8ZrgTAc1U/DZ9N/UOLbtG96BtkiVqRHT+qTuTRjwwM9D+sCnKCfJATVGbEA6IyCOroXHDt80/jUAoM1m0DKbXFe6vAS6krDffKSkXDpg2mustEIS19d2p4RSRuI9iuEf4EKSKS+pdaX+VrmNdMJgZ4h0l6SFLIHWWZyuvgJLIr+aM65wQtstOn1jLfI0jInU0WpCm+k7DcKFR9XsbIXr+uC0NkbR3WQZEZaDfUTF3lmbffGFT3WUIstYnvv85dYZ0GEkKdNME4dU9O/COgrjgiuG5RSm7Gxv2ooZCqWH2BFjVLtncyb/YFrd9BclJOUW+wopsH3qjCdBV/5UTJzH6JU3u6RvpZLBPNHvlSvrNWx46X1y7+NHBXZhmJe3Zt57NmgaLIyWCmPjSRn0jC83m9QQbTyUBThBC/l3Dx7v9W/v+ZFp662NcWGihO21Aurhf9B0UnTnisp4H8iY0t58y9miZk3Ze5nSzwIFelDQrKVvx0kTLoOMFIjgB25Zuq2beIhcBy1dsZgzx0QS5piGtaaRmTnsY2tW9JXu1U4J0aexY2IoOjJ9/ZKj3jQ05UvPw/qWl+aqYbl7kFPJB/4WOl9x6gta4wWI01OV+V0TAXj11P5YStO6XCu6JQma6aGRKKetRVOhZCgasnIm9HzQATSknhKDOCSvr/aqG3+NbzRzNglAvpEkvfyXPOzPAKyi6hM6O1Wh0n+a7n+Fh66Lg80SEhjCS5V5qmIIfZj2tt
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(53546011)(2906002)(36756003)(86362001)(2616005)(66556008)(6506007)(316002)(508600001)(6486002)(66946007)(7416002)(6916009)(54906003)(5660300002)(8936002)(31686004)(8676002)(26005)(186003)(66476007)(38100700002)(83380400001)(4326008)(6512007)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?9vRv/5sBrFATTwrRDnRS3caxk3CYO3qYchLUnPovxhlX9XNn0ziVcqiBbpwf?=
 =?us-ascii?Q?FYygfnDys0nl3DtDGgCDeUjcYnnmBFCy4QieLVEUpG6AUgWZaqAIWu0meZlZ?=
 =?us-ascii?Q?A4hpXtJ0eqgmJgdM+V0ujqIW5cCB9VyiZHFYmzkoq58OxUeXQq5Rl4y9gQM2?=
 =?us-ascii?Q?CbKsnzWzT5h8GwKRq1C3PeDWoidfcUcMYD1wa5WK3wgYRwziCka4Z9lrNDgL?=
 =?us-ascii?Q?LvFgsuKTroGGRzlL8STYobv65mTnMckfD7eTqIahVWHh7Qr5CWV1mYwJyRGY?=
 =?us-ascii?Q?zuXgveXcGKVPu+Kcuuuka6DbUGLgI6xvgpXiEgI/A6Mr3Gava9dvlNBF9tuX?=
 =?us-ascii?Q?tP9we7tbWMAZZD6Gbj/CtFzpDbUogU3/pfwO7vF/w5WWR078lRBDDMd/waV8?=
 =?us-ascii?Q?NxmhIREzFk9MjyNT7cJEhDpSIVDaN1lh4xUykMKb6/DP75YZe3glU5z7TbjY?=
 =?us-ascii?Q?JHwvNddQUEYeM29mrX8owj7788qVyJ8BaQjMGznGjj3vBfXbJr2oAe7sDchV?=
 =?us-ascii?Q?a+Y5PEMOytxA9GSVnQKMeMKY2+sq1XsZIA9QOlQMYF2tnb2a2RLAnpiNbcWO?=
 =?us-ascii?Q?Wkr48N/uKXT027gCAAyGYRkguVaD5MCwNiuNSKt9GHvwFm4IuJhBOdtCXU4U?=
 =?us-ascii?Q?Vi0e8TfcJI0I39aWquE7v7TNYnPx0nkSn3SAZyTcZZsPjNt7LfjZMKtxdrFV?=
 =?us-ascii?Q?EdWe80XwGRUgfqf8zjLeKOfRU+fXS8e+dNDLAzQcG3eykpfKIuidUHk1oawD?=
 =?us-ascii?Q?SeLWP2U+ihUVFfRd1Ddb1kP+HNwNl2OXubK8CE9m4S1D2FqOLORPHfzYWWwm?=
 =?us-ascii?Q?0nVbh9wYluieOuHA9xNSxFVQbcAag0edD5q3xbK3OS1ibei9TcrhwHYyFA7Z?=
 =?us-ascii?Q?/XXQNmeyrApkYeIVsAnE0lE4zD3TdCUvLOcGOaeLKKrTobv5Nrd/QL8WP6mD?=
 =?us-ascii?Q?RxzQyqxFuLJQoK40EhnvZboC6fy0pU7a0XlMuyiJ9lhV3UyU0CYdBHtpIen8?=
 =?us-ascii?Q?aGsQ44Fa+IWKNuEEVYUAdVuMbS0cEnu55R1DT7av/YVh+LfeK3/bKofqq42s?=
 =?us-ascii?Q?nR4sf+8taYuj6pSKe4MOCrSUISH0lTeKo6S6DCvH8t7ocS5XkIciHsAKlZr2?=
 =?us-ascii?Q?LX/4P0N0S5ZtxDb9y1kJ6dOxTpuZhmSy5E8iW4wuj8ulDZcCKtfKB3UXR1Dv?=
 =?us-ascii?Q?Ms1AjNLBnWsxhVD3a4pGGN6hqt3aMjO/UUzWJyApnfV4jpln+89NIKTX8X4V?=
 =?us-ascii?Q?b5AJ2xZZMXMcY0cw1m95HLcZuskhtMk8YWBjXenU+7Skzi8gDYF1qGw96o5E?=
 =?us-ascii?Q?geFNw80HvcZc/3h0j1J/AofVRvx8ed9G7UOobGyMB+vHAxzPrrNVAC4xlGyU?=
 =?us-ascii?Q?h4e6f1JcZ+zeetqIAUzRM1/iFqEFAqcxv/L+PDlKSMZYyG3/YO5dtdKo9vMI?=
 =?us-ascii?Q?sTeFRD07FcNn0s2MqR9zAxFqDUW3x5woYhDnUaWnVa35f0sEAMPRIs/5F0Lx?=
 =?us-ascii?Q?Fo7s7H4py1dVg6XRHB05NPBrOoljvQfp0a99J2bIcfERJXKU4cgCa423h5iP?=
 =?us-ascii?Q?3zM7EdqMskuLNqLzHrHhqCxdZ4hRs3+4YitDT+ETgCLeliu3yqKh0OFv+q7p?=
 =?us-ascii?Q?VwHRkjfhFrd1/1WlNaxEsCA=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dad0a25a-6dd5-4bee-dc7d-08d9f082a651
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 12:56:57.8151
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: f9xsAqU0BqcsXKaE20AoDu168XTTaSTEhXY2Rbaaxwz/i7X9G3z3dn7mes5ZE51jMDpgqmbZc9XZYR3reHJjFw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4567

On 15.02.2022 13:44, Oleksandr Andrushchenko wrote:
> On 15.02.22 13:54, Oleksandr Andrushchenko wrote:
>> On 15.02.22 13:50, Jan Beulich wrote:
>>> On 15.02.2022 12:45, Oleksandr Andrushchenko wrote:
>>>> I'm on your side, I just want to hear that we all agree pcidevs
>>>> needs to be converted into rwlock according with the plan you
>>>> suggested and at least now it seems to be an acceptable solution.
>>> I'd like to express worries though about the conversion of this
>>> recursive lock into an r/w one.
>> Could you please elaborate more on this?
> What if we just do the following:
>=20
> static spinlock_t _pcidevs_lock =3D SPIN_LOCK_UNLOCKED;
> static rwlock_t DEFINE_RWLOCK(_pcidevs_rwlock);
>=20
> void pcidevs_lock(void)
> {
>  =C2=A0=C2=A0=C2=A0 read_lock(&_pcidevs_rwlock);
>  =C2=A0=C2=A0=C2=A0 spin_lock_recursive(&_pcidevs_lock);
> }
>=20
> void pcidevs_unlock(void)
> {
>  =C2=A0=C2=A0=C2=A0 spin_unlock_recursive(&_pcidevs_lock);
>  =C2=A0=C2=A0=C2=A0 read_unlock(&_pcidevs_rwlock);
> }
>=20
> void pcidevs_read_lock(void)
> {
>  =C2=A0=C2=A0=C2=A0 read_lock(&_pcidevs_rwlock);
> }
>=20
> void pcidevs_read_unlock(void)
> {
>  =C2=A0=C2=A0=C2=A0 read_unlock(&_pcidevs_rwlock);
> }
>=20
> void pcidevs_write_lock(void)
> {
>  =C2=A0=C2=A0=C2=A0 write_lock(&_pcidevs_rwlock);
> }
>=20
> void pcidevs_write_unlock(void)
> {
>  =C2=A0=C2=A0=C2=A0 write_unlock(&_pcidevs_rwlock);
> }

Hmm, this is an interesting idea. Except that I'm not sure in how
far it'll be suitable: read_lock() won't lock out users of just
lock(), so the solution looks tailored to your vPCI use case. Yet
obviously (I think) read_lock() would want to become usable for
e.g. simple list traversal as well, down the road.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Feb 15 12:59:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 12:59:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273155.468232 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJxQ6-00018a-6z; Tue, 15 Feb 2022 12:59:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273155.468232; Tue, 15 Feb 2022 12:59:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJxQ6-00018T-3h; Tue, 15 Feb 2022 12:59:02 +0000
Received: by outflank-mailman (input) for mailman id 273155;
 Tue, 15 Feb 2022 12:59:00 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=p95L=S6=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nJxQ4-00018L-Au
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 12:59:00 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0a8f77f1-8e5f-11ec-8eb8-a37418f5ba1a;
 Tue, 15 Feb 2022 13:58:59 +0100 (CET)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2113.outbound.protection.outlook.com [104.47.17.113]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-14-DnuWeuIAOH-BCpdWZ5CS3w-1; Tue, 15 Feb 2022 13:58:57 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VE1PR04MB7422.eurprd04.prod.outlook.com (2603:10a6:800:1af::5)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.19; Tue, 15 Feb
 2022 12:58:56 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4975.015; Tue, 15 Feb 2022
 12:58:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0a8f77f1-8e5f-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644929939;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=sLA0klsYTsXa2vmsfpAANZAbvcx4dXmZfiwpT0pkI+w=;
	b=HFzKdDEU0PDKv585FeL/YzdQz9u2BpC+DrxBqU2xKwaIp1rLeOa0/e8XOP3rmJEr1Q++4h
	Pp1u25W9feStfGWSWXOXVksgMMyoEbkwINZLHX07TdaVt6kQkTPvEZov7NckZIX5sWYct2
	5GWTTpC2M8puTfx0uPNit+8cpeaT08A=
X-MC-Unique: DnuWeuIAOH-BCpdWZ5CS3w-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=nal3DJCPPIEM+z2u/wcxlAyxcJ820JKeJxrx6wGixn5xMqYdSQbC0EWu8wXMAlBQwwn4yTKwnQOFIg+/DfGat7WsHG2YBHx76fpCWR1JZzk06VHgodMMGe/mlobjTZreTe+zV3Tvaro3HM6jCwuKy3rTeP7pFJqR2NqeAimKxy5pjyUW3ob3tUldrAxAmM/4kcUBrL2Md4UpCG+Apcltj8LXVDxbhXemQAbO6m2iqaNwWjhOeoUEPXGx9nlrHEBNXU4y0gC84YCGcmB+zIwke/Ezpu6xwVNvhE/KLjFVFs1h4KgHxco+k7SqDHs4rQBuIVxrLhyZyil17Pz0TvA7sQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=sLA0klsYTsXa2vmsfpAANZAbvcx4dXmZfiwpT0pkI+w=;
 b=Q4TRbKmqCWAzO6xb4hCwWFqcOjZKMt1BmCTisfx+kTBv51a0tDgEvz4IF8cVk4Ro4IZGr/bCAntEqWIy2BOroGUbgOPjaxGAl4/7CflShs3OY4sRU9vxEco4jJrij+VVFf+kXYv6X+wC5E319JmVKfL0TO3ZBX1Kbvxdv07aBLt5uZpUvQfbrbfc9Wtact+OokrjB3/bjtfX92BHXfRX+eXCAv6K+YWQ/AAZKW9OlukVj05kHnnQFH1FykHJTWcKgwfHnoWUOql0z8K4Fcg7j/1lU5TQ3DKwxxcnMrOoxus0wNCACJB9wfvVGxLPXnhGH7TFzYG4lHF3Ly3PRzWabQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <30a2c373-1ed0-bd27-f264-5b26aa55e286@suse.com>
Date: Tue, 15 Feb 2022 13:58:53 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH v2] vpci: introduce per-domain lock to protect vpci
 structure
Content-Language: en-US
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "julien@xen.org" <julien@xen.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Artem Mygaiev <Artem_Mygaiev@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>
References: <20220215081135.1497470-1-andr2000@gmail.com>
 <YguE7RWOteSnvVNY@Air-de-Roger>
 <c5b9b02c-93f8-d018-6048-9abf2e7de4dc@epam.com>
 <YguQ8wfhfYFXTWSU@Air-de-Roger>
 <70dbd7fd-3f74-d0d3-6e30-c1e1e24fc279@epam.com>
 <0d8f01b2-b015-a08e-dd49-e9c688ff7245@suse.com>
 <bbb36ebc-de66-297d-f82f-abc0e63f20a2@epam.com>
 <34832b7b-c1c0-06e9-9214-6c434cfb1282@suse.com>
 <9f4e7308-6ede-302d-35c1-6fa824df69bd@epam.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <9f4e7308-6ede-302d-35c1-6fa824df69bd@epam.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0193.eurprd06.prod.outlook.com
 (2603:10a6:20b:45d::11) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d60c3efc-1458-46e5-677e-08d9f082ecf2
X-MS-TrafficTypeDiagnostic: VE1PR04MB7422:EE_
X-Microsoft-Antispam-PRVS:
	<VE1PR04MB7422A096A6841856C7BA5375B3349@VE1PR04MB7422.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	KiqrD9VBl0hL8mhg5MWBhAFXupoN3Tk+weAHHUdKK3rxY5V64cvGVevrFPGyFOqkj8upDOdH1qtECDDE8h6MGT0Xk6BPbGgJIrthYpGgetomhE/A0O2TpuKYsmdLI+DDJYExV4Yg83OflRleM+ygYyNQKOmSOOnREPQmEN4ZX7RKnX5CBdIxYtjo11yN8I0b2xQCUhGbTQZvtJ9kmqIdTY3ANBjiZH6xdniDxF8uOkwE+IqZou7aF74CFnyVNdOXePy2c77EX5XNFt5LFEa5tYbig+YgVCNUCbYt7jOhHJ2nU3zz4kN8TVbs+N7d7YyJNEmgQwUJ9OeIEzPTuH9df65felBsTAF+IpSxLQVVeFrQo7x47BD5EIJanBpSPPESZt1WUS8/gQ0IpBwjQLo5LrVfLsTo1ZRNf4vFkaP6wUstjPdqLTh/8ccxVow9h2Erynjvx2XFMeyv596iBTDGBq33J0T5fDb+O+K2CA6q8N2zHMhrexRBp49oPNj1wTqvYU4oIwayoCN0kinqCY1REWHE2CveEIh/S6g+m4RfiEPq7ny4wexae8bqsUK1K9Ld3t/kvcDXuPnNaxwKxkv6ySyF8uk7NzneWEZIt851ek+9zv6zrY/BVtv3J3XbvVY+KHLihpsvPCnQ4DLIGw/nSZmpWgC8ruJ/a8odU5ms13sskO7IR3hmbDH233C3QK2co4I6dEtU9o12hAaUCeiBNpetfonS/pTT4AKHE96mmyNWpQN7BSc9xwpmkksPVud2
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66556008)(86362001)(66476007)(66946007)(2906002)(4326008)(8676002)(83380400001)(8936002)(7416002)(2616005)(5660300002)(53546011)(6506007)(6512007)(6666004)(31696002)(4744005)(36756003)(54906003)(186003)(508600001)(38100700002)(316002)(26005)(6486002)(31686004)(6916009)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VHB1em5FYzNGZkpIR0JZdWdoWUoxZ1ZPcXFJSXpqakhjUTEyMXFvWjVMaFBj?=
 =?utf-8?B?M2hJRHhjQjd1eTJZUE1oNWpRcUpXa1Nrb0ZVZFRQRDdEZVFoR3FaRmVFeE9s?=
 =?utf-8?B?N0FFMkk1b3V6dCtuRHdod1hDa1NSQUkvNUk3S0JabTNzbHY5QU9OMmlxS3RV?=
 =?utf-8?B?WlJ5QlorYUdvZ0NKSHM4ZjZST1k1aXNHR2c0SFNhQWU5TGdNaFhSRXJWa1A3?=
 =?utf-8?B?enFHeVdWR3gvQUo3ZnpiektmZXFjQkNZaUxJbUlrYkFVaEo2anB2T1pKWTlN?=
 =?utf-8?B?UjZRVjMrWVRhRUtRMWJjMXB0Q2VBdTAvUVJBb0doRGtaV2Y3V2hjc3c1N1V6?=
 =?utf-8?B?RThLWmVkUmdENEdYejN2aU43RHZabUhGNktYYTN1WDg4dG5qNjJHU1pRd0VI?=
 =?utf-8?B?eUVyWkN2NU4vQ1VyLzRmNXovRFJxeWJ2VFhmWFFJUmZXY2h6alRpUytDOXRZ?=
 =?utf-8?B?eklLUVEzRTNPWlJDUlVNWS85WEpaSzl4RERQWDlzY3A2RTgzTFpHNVBiZWVM?=
 =?utf-8?B?MVo0S1UzY2R2N3NTTVkyTFJyQlgxNDdhNzlsb1hTUWZ2Mnp5L2RaMkczUHcx?=
 =?utf-8?B?T1VCRUk4TzcyeVo1YWNGS1hxc3pCaHJ4N2tNS2hhUUdtQk01NXordzdoS1Jp?=
 =?utf-8?B?UXFKbFRwNmVYYU1qVkptaW12M0c4bXIzUHpuaDdlaHdrK2VYT2Y3VnZYMmFG?=
 =?utf-8?B?TENhb1VsaG5pUzBxcFZmWlpITnlZVXFBb3ZTT3Q5b1B5bTNpSzJId3dPRTNU?=
 =?utf-8?B?aFBlbHpKQTFHelJHRGdVUEtmNThXZGxFTmhwRXhoekNIOUgyYWlMMlZLdUNQ?=
 =?utf-8?B?d2hUckYrYWp4STgzdWVJYlkrM0ZnQnFOUEZBOFYyN05lbnZ4ekVEcExoNlNQ?=
 =?utf-8?B?RDk3NmkzWTNQaTRXd3J4QWlLNkFOT1dtZXpWUTdBV1NZcC92Z3NCV2NQZWl5?=
 =?utf-8?B?V2UwQ1lBRmFsZzdvaVJaNWptSHFOVmVjU1pwcnA4OGxzL2tZdHVGZEtHRWxY?=
 =?utf-8?B?b1gyM3hSaksrNUU3dk0wN3I3Y2xWUTJlOTlVN3JBem5kZmFtRU02aDNaMlUx?=
 =?utf-8?B?UXc1QVpsNFF6SHMyTFRCOVRKYjhnVUxuZXhvZTF4TGFwcDExM2l5eDRpZ1VP?=
 =?utf-8?B?YkdwYVpIYkl0WEhnMDEzdmNuRVBSZ05LOXJvNUNERitxQmFQRkQxVXJyQ3Ns?=
 =?utf-8?B?MncrbEVha1E3R09pMVNWSEVaUWxjVXF3VklaQ2xGUzd1aXpkdXRKbkkvdGls?=
 =?utf-8?B?RVpYVHJMaWI0Nzc2MEx5dk1NbWJ5bzNIQkpNNlVRSkxrTDVxelh3R2E2aU42?=
 =?utf-8?B?dTljRlRxVDE4UVJkdHg3eHN3UmQyNXlqZW5hc1ZxZFBhS09TSDJHZWRJbUp6?=
 =?utf-8?B?S2lIUGk5aWc0UFRleUxvVE5KME5zRHdid3RSWm5NWTlOUWpoMldKa3RFWEph?=
 =?utf-8?B?ZTN5S0pxRFJrcmpHZW1FSXRqUHNyNVdoQ2lOUjdiYWpaL1plakVDMU16VzNS?=
 =?utf-8?B?VnAwRnBjRUV6aCtBSE4wWlRHbFI3LzhMdFNRWmd0TE0yRndpN2lFOXI2WEtX?=
 =?utf-8?B?SE5Pa1ordUEvcjVvWmdKM2xoMTlKczBSVURmVTNyd2Q4VjBaWnhpcCsvL2pl?=
 =?utf-8?B?WEhYaXVoditYQnlUeG5XcFRXRnAxZXdHcGRsNWRnbDZTQjlSYkVlWEJkbDhM?=
 =?utf-8?B?OTZJUXVxT2NTM1JKaDdmK0kyNUdpM3hJampFUjJxcnNMZXNzZitFbWEvTytH?=
 =?utf-8?B?eVM5NXdCSW03aFVYVW1icUtJd3QzcVc4aGdOU1l1WStDSE8zbGsxakVHeXpJ?=
 =?utf-8?B?ZEViNWlKcFQ3eHZJUG5oQzNCMm56TlZBbzdLSHpTdmhZYi85eVVYZ1F3Zk5j?=
 =?utf-8?B?OW5GVktINDE2WXZPN0xubG1uQXpVTnhkcFg3VmJtaTE5b0svTTQzQUlZSkdy?=
 =?utf-8?B?d3l2VFF3MUZ4NzhKcTBwNm5WS3luRWpuNndEOURGcUNHRC9BQkd0Z1BYZ2Zo?=
 =?utf-8?B?Z1FkelhmT3lESDBlb2dwajBuWXAydDlSYThxSTFsdFBoSjFtK1pvQzdFMmFO?=
 =?utf-8?B?NkVPUVYvVUsveXRnQWdPMUk3aEtua0laRVhGTEp3eWovM2UweTVlaEtnYi96?=
 =?utf-8?B?WGU1bTJCKytScWpaTjdBODhEbzRWdEJzcnZMaERXRTRTZTJmaUVGVlluOUVj?=
 =?utf-8?Q?vEat471hGpZJGF6ONoyc9jw=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d60c3efc-1458-46e5-677e-08d9f082ecf2
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 12:58:56.3234
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uEsq4hiaYEZFoXUsf4kV5beRAWd/b2PMNdywV52mIzeTY560ZTtnAcBt83ZL/S2W97PXcAQBXcgjW0Iq6LV2IA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7422

On 15.02.2022 13:56, Oleksandr Andrushchenko wrote:
> On 15.02.22 14:49, Jan Beulich wrote:
>> On 15.02.2022 12:54, Oleksandr Andrushchenko wrote:
>>> On 15.02.22 13:50, Jan Beulich wrote:
>>>> On 15.02.2022 12:45, Oleksandr Andrushchenko wrote:
>>>>> I'm on your side, I just want to hear that we all agree pcidevs
>>>>> needs to be converted into rwlock according with the plan you
>>>>> suggested and at least now it seems to be an acceptable solution.
>>>> I'd like to express worries though about the conversion of this
>>>> recursive lock into an r/w one.
>>> Could you please elaborate more on this?
>> Not sure what to say beyond the obvious:
> I thought you have something specific in your mind that worries
> you and you can tell what it is. Thus the qustion

Well, the "specific" thing I had in mind was: You'll need to prove
correctness, and we'll need to understand the proof.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Feb 15 13:13:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 13:13:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273165.468243 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJxdj-0003VX-In; Tue, 15 Feb 2022 13:13:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273165.468243; Tue, 15 Feb 2022 13:13:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJxdj-0003VQ-FN; Tue, 15 Feb 2022 13:13:07 +0000
Received: by outflank-mailman (input) for mailman id 273165;
 Tue, 15 Feb 2022 13:13:05 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nJxdh-0003VK-Cd
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 13:13:05 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nJxdh-0001MW-2e; Tue, 15 Feb 2022 13:13:05 +0000
Received: from 54-240-197-239.amazon.com ([54.240.197.239] helo=[192.168.8.20])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nJxdg-0006Sp-SN; Tue, 15 Feb 2022 13:13:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=6J7psP7Iy28BwTvT7zC1AKnRAyiW2NFGFhyAnXSj0OI=; b=Afo/+ctLAhv/W74/kIZZ64JXQ9
	EUR13Yx0P0CHwTc4z/IPYH4V7LmiqxL+kQd9c2Js9EVvdPb3Y2AlHRO+2htrqWhxAbdto33JFY2za
	IxusRXtmCAzz45B/eQ0brm+r8n0a0ZznR+MPh62QYO25UYEC8e9mzIeccbcYwzuuxrbI=;
Message-ID: <7710f137-7123-ca70-3a58-3dba1981b2c2@xen.org>
Date: Tue, 15 Feb 2022 13:13:02 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.0
Subject: Re: [PATCH] rwlock: remove unneeded subtraction
To: Roger Pau Monne <roger.pau@citrix.com>, xen-devel@lists.xenproject.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
References: <20220215093951.97830-1-roger.pau@citrix.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220215093951.97830-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 15/02/2022 09:39, Roger Pau Monne wrote:
> There's no need to subtract _QR_BIAS from the lock value for storing
> in the local cnts variable in the read lock slow path: the users of
> the value in cnts only care about the writer-related bits and use a
> mask to get the value.
> 
> Note that further setting of cnts in rspin_until_writer_unlock already
> do not subtract _QR_BIAS.

The rwlock is a copy of the Linux implementation. So I looked at the 
history to find out why _QR_BIAS was substracted.

It looks like this was done to get better assembly on x86:

commit f9852b74bec0117b888da39d070c323ea1cb7f4c
Author: Peter Zijlstra <peterz@infradead.org>
Date:   Mon Apr 18 01:27:03 2016 +0200

     locking/atomic, arch/qrwlock: Employ atomic_fetch_add_acquire()

     The only reason for the current code is to make GCC emit only the
     "LOCK XADD" instruction on x86 (and not do a pointless extra ADD on
     the result), do so nicer.

     Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
     Acked-by: Waiman Long <waiman.long@hpe.com>
     Cc: Andrew Morton <akpm@linux-foundation.org>
     Cc: Linus Torvalds <torvalds@linux-foundation.org>
     Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
     Cc: Peter Zijlstra <peterz@infradead.org>
     Cc: Thomas Gleixner <tglx@linutronix.de>
     Cc: linux-arch@vger.kernel.org
     Cc: linux-kernel@vger.kernel.org
     Signed-off-by: Ingo Molnar <mingo@kernel.org>

diff --git a/kernel/locking/qrwlock.c b/kernel/locking/qrwlock.c
index fec082338668..19248ddf37ce 100644
--- a/kernel/locking/qrwlock.c
+++ b/kernel/locking/qrwlock.c
@@ -93,7 +93,7 @@ void queued_read_lock_slowpath(struct qrwlock *lock, 
u32 cnts)
          * that accesses can't leak upwards out of our subsequent critical
          * section in the case that the lock is currently held for write.
          */
-       cnts = atomic_add_return_acquire(_QR_BIAS, &lock->cnts) - _QR_BIAS;
+       cnts = atomic_fetch_add_acquire(_QR_BIAS, &lock->cnts);
         rspin_until_writer_unlock(lock, cnts);

         /*

This is a slowpath, so probably not a concern. But I thought I would 
double check whether the x86 folks are still happy to proceed with that 
in mind.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Feb 15 13:22:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 13:22:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273172.468255 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJxmT-0004xJ-FT; Tue, 15 Feb 2022 13:22:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273172.468255; Tue, 15 Feb 2022 13:22:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJxmT-0004xC-BR; Tue, 15 Feb 2022 13:22:09 +0000
Received: by outflank-mailman (input) for mailman id 273172;
 Tue, 15 Feb 2022 13:22:08 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=p95L=S6=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nJxmS-0004x6-0Q
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 13:22:08 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 453a8dbb-8e62-11ec-b215-9bbe72dcb22c;
 Tue, 15 Feb 2022 14:22:06 +0100 (CET)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2109.outbound.protection.outlook.com [104.47.17.109]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-18-ulufjs2mP1K17xBuPp_xlQ-1; Tue, 15 Feb 2022 14:22:05 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM8PR04MB7970.eurprd04.prod.outlook.com (2603:10a6:20b:24f::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.19; Tue, 15 Feb
 2022 13:22:04 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4975.015; Tue, 15 Feb 2022
 13:22:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 453a8dbb-8e62-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644931326;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=rJBQZ+Ux1WL+WjXUaL0a6qz5XGjP6Fl33toIGOB7zvs=;
	b=NqHpjMbLaemMghPKB26MljVbgsHUaEDUJSt9k/MqZQM8mxmL8Y5rH6mME7UoWYkEhCH1zi
	bb2hWAy+Koi4vSn8Ezs3Plu3R3AAxJEPzSvc4QOlxATDMeTg8gqDLdEDMeY6L6a6FTKlU4
	lgqCMFVxzGS+KS886ydbUiDk1cj2tUY=
X-MC-Unique: ulufjs2mP1K17xBuPp_xlQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=KaQg8f9J6Kv31SSvoREstDRjZgBp6ETTtyqZOoMOHdpzcCWUkhCM+IpxZ4qBwueh+oPls4gC8yWF7kniCJi+Y8YpRpd3W86s90Fp6vP3U6L4n9/ZKgjRwglrX5MU3U1+hbmEH7Zlmci2tZa6Gkbpt5L5AqRPD/KOR2K7JRzRGDmmZkTwlqCDEXrtMyi4Z2XBveAXaMEXLIHU2z5Qn3ErqJNHAui1T0WyZE9T+7bdUxUfqfCgHxWgQ2b4w2vZb1Dmz+VSIUIQd0u/kwLDWV4hotXSZkPxjzYkKA2NC4ip6jL11+7t6t2JcuGBssslpEbu0sZQEEv/LJTRa87JE9b30w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=rJBQZ+Ux1WL+WjXUaL0a6qz5XGjP6Fl33toIGOB7zvs=;
 b=mtuighdwkfAvKA1fdfNw6JBjEgF5f38oeKzUrjZyYM08kM2W/Vo/EEYQSOFIV9CQRupjSmAMvYIHaP/aEEmx9OSSjbISn8HAs+Tt9oOo9ibpHyF+6V4+CVZaBBRCeEH3SVpOY1UGYNdP+XTtbISWBVAZPzEev3cyTno5K8nttl3SP5WzUHnzSlC7Pkt1u6YDZ9NR+JOYgLSn6R3q0mcX/neiFyfAQV4ll7Q4/sWSV00sf2gHY3xKwlpqDBoiYx+S5NbCKL6afg/vZdiT5vI7Egd0ThwcPLmmaWghKiuLBOD8pegH8ZuAray6gwCwb7itQP+c2oSZzyjLbqxcWa9JEQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <dfc3ab95-f2ca-bf03-98c1-5d77ebcdb048@suse.com>
Date: Tue, 15 Feb 2022 14:22:02 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH] rwlock: remove unneeded subtraction
Content-Language: en-US
To: Julien Grall <julien@xen.org>, Roger Pau Monne <roger.pau@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220215093951.97830-1-roger.pau@citrix.com>
 <7710f137-7123-ca70-3a58-3dba1981b2c2@xen.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <7710f137-7123-ca70-3a58-3dba1981b2c2@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR07CA0005.eurprd07.prod.outlook.com
 (2603:10a6:20b:46c::28) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ab9f0105-3fab-4948-dffd-08d9f0862832
X-MS-TrafficTypeDiagnostic: AM8PR04MB7970:EE_
X-Microsoft-Antispam-PRVS:
	<AM8PR04MB7970AD5F73E74166F79A9D63B3349@AM8PR04MB7970.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	vQSKqPtDeQryHDajZ2mhWxvBsv+H/yppL8865R+5JgjK9jJ6dH/lX/jhzvbXR/bbRbVH9HJYEKMwNXV3Wb3tnZhezy2fPFoSEtSGsntxd8rrL47Lpqx68thYTc3DypmvlSTdt553WL8K/YvcpSdZ8ynMCsFCymCHf5lfFnEYO0azNSC88sVojJCw9zgvH1SKrJgLBPVhj1qVnGQ5Fp5RgDFHD/Xv2cS6XQty2RVQtvOrmLPiOPTVukThfdIof01pXQEvzFy1t2ggow9CONMhsiSp0591RscDsHGvBPhuWOd+85me3Z4xcVmW+l56AnTu3ppXW+SLK9t+D7F/mNe3Fs9O7pAXV0GnmVAxIYAz9yaDf169FFYzxAn9TN82b/67a/BdZx9UmC7Mg5ztGcJt2hJDjTp1W4Dv8j9OKcgggNrU8/wAgvjJK9yNOTThjOcUwa4QZyXkPxE+rPUVIFPs6i55pgaHzSVWOTLC9xpbTkHuYixBzqWDAcqYS23eQJFDLA28GtvE9U4h7KeSjiN1ecinuOqhSR60VhTVvo4Dqx6H40Ir7SCnKU8ioXNnSSQy5reL00qBBfgiGl/OG5Iu8/SWtjZDoNaaJ2ywPd+oSE2r9MmDJbKc7pSTeXp7HzRanElB7Lox+KarmBMYH9q7w7il97+jwqv4IjUaNwJstKYjPZ9TnSBhUeDWjpI/Ah47R7ftGae3Vey9ZCcxjug5F1VHvr1zQcbx6RjZ10htXLs=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6506007)(186003)(36756003)(53546011)(2906002)(83380400001)(2616005)(6512007)(31686004)(8936002)(31696002)(86362001)(5660300002)(110136005)(6486002)(54906003)(66946007)(66556008)(66476007)(508600001)(26005)(8676002)(38100700002)(316002)(4326008)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?OXZoQ0NJdzIrU2l6K0FlZ1Y4UU9iTVMrN0txL1N4RmJKRnRWb3pLUGp2c3Fz?=
 =?utf-8?B?S0Y4ZG44bzE5V1JNaExQSGh1ZWp5clNxS2R0MEFFbG40cDNlb0pzMG5UT0t4?=
 =?utf-8?B?a0FoSTdoNkgrOTZramd5VVQ0U2JlSzZPNTdlVkp0SHR3Y3oydjRPa1hjaGJu?=
 =?utf-8?B?YkxNQ3JWUzdKQmx4WWxQL1dvTHZXSzRvcVRFbVBGelFOTDFvRUJSczFsZWRn?=
 =?utf-8?B?aW9SQjhKd0I2aHNLUGJaRHBacnFqdnVhY29WZkFGcThWRCtISU5yaFc0UUhD?=
 =?utf-8?B?OW5TTVphbTlmVnk0WUxjVlRMY2pLZ0w0MmY2UitmcTJOUXFLZ0NGS05uNmFT?=
 =?utf-8?B?dDZjRlZ1RXhvSkd3VHJHczZ3c1RlaW9lN3JWK3ZYa1g4REhHSFREelJBVWJ2?=
 =?utf-8?B?R3hOWUtyU2Q5NGNWUVFJNllZRkZqVkE5WE9BUUF4TjEyZUxFQWlWOFdvZ0FI?=
 =?utf-8?B?SDMzdmo5WjIySVVXY2dtUTJFT3lUQk9BK1dvNUtCMGNBRTJxempQOW85TWUr?=
 =?utf-8?B?UDBMbmJta0pxMGJBR2pnMHZLTy9WUWxGRC9ZN3BuQk9BeCtDeUJrb25FUW56?=
 =?utf-8?B?Zk1oeUUxcXUrZTNlWHZyTFlmZkZyb0lUbUpKdmU5MW1rM1dpTUJEaE95aHF2?=
 =?utf-8?B?eFU4cUR5UXdDRVVoa1hoWmxodkhjbEZxVDFvUy8rblN5SEZtcktIaUM5eVpu?=
 =?utf-8?B?WUhMK2VMTUNJUUVycGJZVm12d0NUeXF3VXZaakpiR3FGRkN5RE1kZkpiL1R2?=
 =?utf-8?B?YVFzTjJSaGhZSkEyTmFhNzN6MUNUS1FOMUZ3elhiZVMvQjVIc1NHM0JtTW1K?=
 =?utf-8?B?Z050WWpWRjJLcUlERVJrREVOdFc5NVFwamVZR2Z6QU5LZDN1aGhSRWtsOGFp?=
 =?utf-8?B?cEhQMHEyZzhpZnBIcm8yT08xcVU2cDdpQkRJdXVJOHNVN0tad2IweG4vRVBt?=
 =?utf-8?B?RGhsLzNUdi9ndFBkOTk4S2R1TmJzVjVjNWJYZGZWOWo2bi9NaHhqRmhraG9K?=
 =?utf-8?B?TXJWcTFMWUVFNmphSFU5TDVvRnFMZ2Q3SGcvVVY3S3RXY0VHTXJMVkxwVjZL?=
 =?utf-8?B?TVpDZkhxTjUrSFVJT0plK0dGaHJiYTNIWTJsT0VEWk9uR3ZGS0h4aGYyeVdO?=
 =?utf-8?B?ZS8wakFwWmJ3dkFVTVhralkrN3ZHOTBtNlpzMHBtWHVoSUJHS0dqRldjZFdx?=
 =?utf-8?B?R3ViU1hOU2VFY2FhSmJxM2pkUWI0U01adng5b1dUQTR5YjgvNHNaSFVGWkg5?=
 =?utf-8?B?OGs4ZjdmL21XcDhhNElNTHhLMmd0dUVwbzJPcXFhaVdyT3htbDFCNEJZR0o3?=
 =?utf-8?B?M0JHL3h4Qzc1NFVKMEcwRzMyTG5Ma1laN21rcnEzbmlUY05OdDBJczdPUVJa?=
 =?utf-8?B?WXNaQW5ycmo5bmhTOE04TU40TG83c0dYVzdoTFpZS1FESTdXNm9vbnlSdEZP?=
 =?utf-8?B?V0piQUxxamhycWpXajB1akQwdVNSNDRUMTAveS9uZzJDU3QzWnArSVg4Tjk5?=
 =?utf-8?B?Y0ZBWVhLSnJVamZPQ0gvb1dDUUVoNmlHbDdhb3U2dlRMaG1zTjFYM01XdERN?=
 =?utf-8?B?dTh5NU9NVEdCVGdyUDZtMmk4Mjd6Wi9Xd2hsMVJ5UVR5a09wN2V5TVAvTVFI?=
 =?utf-8?B?c2lvckRsRXZnSEdpTnRualJKbmQvdzU2dTlGZkxITVdTYkFyM212STUreDNL?=
 =?utf-8?B?Z3didTRFTzA2SnVzT3lXcDNuOG01MVFwTGFnU1ZIa202Nk1BdTRpbFlvK2t6?=
 =?utf-8?B?Nkl0TU12OVBRRUZ4T3VXQ1ZZZjlZV3pLeVhteXdLNTRHVzdhZkZBK1JuTDho?=
 =?utf-8?B?YkdkRVpteVBONS9yM2VuZEdkblIwWHdPL3dQSDAwUVBRWnBaK3JaM1BscDdW?=
 =?utf-8?B?OG5meXhNS25wOS9ZR1BvaEFvTGdBemlSVzFFb2F4VzJtajZDN0lZQWVaNjc1?=
 =?utf-8?B?L2g0Q3hlMHNnNXA0RlRtaWZ0UjVnQi9zbXlqOUV2L2FnS1pYUjJzVHUyUUM4?=
 =?utf-8?B?WHpkY291d0MrbzEybURld3ZaT0FJRTNMOTRDNzRsZXNNNXJCbS9TWm80V3Vi?=
 =?utf-8?B?aFNDdDlnNlluWWpYS01SdUQyTWlPbXUwRXVtMHdnVGJYUkJWcHgzYk5RbCtp?=
 =?utf-8?B?aDJWYWZwU3lmSGlhZEhCTFhzdTY4MTJEV28wcTF6cnRna3RzSlJzMnl5M3hi?=
 =?utf-8?Q?W/a5SVkldMlCijQQ523Zk1I=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ab9f0105-3fab-4948-dffd-08d9f0862832
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 13:22:04.1748
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Yu4l1ydUhOWAOccaSWoFFlESMrFmaNG41iXPGk8FD7jEIReKiuC+rl6vXoB3X0AyJ/ssJuygd4YbErxIRWngHg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7970

On 15.02.2022 14:13, Julien Grall wrote:
> On 15/02/2022 09:39, Roger Pau Monne wrote:
>> There's no need to subtract _QR_BIAS from the lock value for storing
>> in the local cnts variable in the read lock slow path: the users of
>> the value in cnts only care about the writer-related bits and use a
>> mask to get the value.
>>
>> Note that further setting of cnts in rspin_until_writer_unlock already
>> do not subtract _QR_BIAS.
> 
> The rwlock is a copy of the Linux implementation. So I looked at the 
> history to find out why _QR_BIAS was substracted.
> 
> It looks like this was done to get better assembly on x86:
> 
> commit f9852b74bec0117b888da39d070c323ea1cb7f4c
> Author: Peter Zijlstra <peterz@infradead.org>
> Date:   Mon Apr 18 01:27:03 2016 +0200
> 
>      locking/atomic, arch/qrwlock: Employ atomic_fetch_add_acquire()
> 
>      The only reason for the current code is to make GCC emit only the
>      "LOCK XADD" instruction on x86 (and not do a pointless extra ADD on
>      the result), do so nicer.
> 
>      Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
>      Acked-by: Waiman Long <waiman.long@hpe.com>
>      Cc: Andrew Morton <akpm@linux-foundation.org>
>      Cc: Linus Torvalds <torvalds@linux-foundation.org>
>      Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
>      Cc: Peter Zijlstra <peterz@infradead.org>
>      Cc: Thomas Gleixner <tglx@linutronix.de>
>      Cc: linux-arch@vger.kernel.org
>      Cc: linux-kernel@vger.kernel.org
>      Signed-off-by: Ingo Molnar <mingo@kernel.org>
> 
> diff --git a/kernel/locking/qrwlock.c b/kernel/locking/qrwlock.c
> index fec082338668..19248ddf37ce 100644
> --- a/kernel/locking/qrwlock.c
> +++ b/kernel/locking/qrwlock.c
> @@ -93,7 +93,7 @@ void queued_read_lock_slowpath(struct qrwlock *lock, 
> u32 cnts)
>           * that accesses can't leak upwards out of our subsequent critical
>           * section in the case that the lock is currently held for write.
>           */
> -       cnts = atomic_add_return_acquire(_QR_BIAS, &lock->cnts) - _QR_BIAS;
> +       cnts = atomic_fetch_add_acquire(_QR_BIAS, &lock->cnts);
>          rspin_until_writer_unlock(lock, cnts);
> 
>          /*
> 
> This is a slowpath, so probably not a concern. But I thought I would 
> double check whether the x86 folks are still happy to proceed with that 
> in mind.

Hmm, that's an interesting observation. Roger - did you inspect the
generated code? At the very least the description may want amending.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Feb 15 13:27:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 13:27:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273179.468266 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJxrP-0005eR-3I; Tue, 15 Feb 2022 13:27:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273179.468266; Tue, 15 Feb 2022 13:27:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJxrO-0005eK-Vg; Tue, 15 Feb 2022 13:27:14 +0000
Received: by outflank-mailman (input) for mailman id 273179;
 Tue, 15 Feb 2022 13:27:13 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=p95L=S6=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nJxrN-0005eE-K5
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 13:27:13 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id fbb31f2e-8e62-11ec-b215-9bbe72dcb22c;
 Tue, 15 Feb 2022 14:27:12 +0100 (CET)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2109.outbound.protection.outlook.com [104.47.18.109]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-41-QPKjZAOZMmmgykC0khjo4g-1; Tue, 15 Feb 2022 14:27:11 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM6PR04MB6136.eurprd04.prod.outlook.com (2603:10a6:20b:b9::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.19; Tue, 15 Feb
 2022 13:27:09 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4975.015; Tue, 15 Feb 2022
 13:27:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fbb31f2e-8e62-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644931632;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=jYq7aUrzgzpmsolmfJyPbc99v+gIpc64qMdVS+ZMwfQ=;
	b=H4p6zX1KMW0MKlp0hoenadIiv594m1Hi9by55le6DdY7Ox26Kk3qqAl/uqk0BrUMTYW1bw
	87xU8vLSDp0Pnxss4eAK8Ieona3EZF7RR+5y0zgs6ZLv/jbHzS2vR4Ie7CLIfUAH0itq7Y
	5rfTOG82GiY51o/zaw/soD14erq3deY=
X-MC-Unique: QPKjZAOZMmmgykC0khjo4g-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=NH5ZvlSHP20jec6o4BnjKMQLA7dGgIbBYvY63D9kLNdeYZz5Hp7ceOzSlxx0neYwWmTqKA0JsPRCItCYcCpKGMgIJ/XFBusM1GBufMKh+ZOon/7eSiOFSgrqL099D2zIwCUbGY4Zwiaf2CzR5NTe3P4XhQNLCaiqYs2YmKtneOdw/LC5vsFm0N1xLfv2mQm/m34CBKsLT+EliApQ5PcTjBF1Ht/g5fLeqhW04VJmKbXcO8PYJ98yux/UMfd6qGn9uosJOu5E+/9jaj/1xnGDcgczGKciH2FQUXtugD0gf95vRtZYRefp1xvqFrRpNvSWQwAYRAdJdqGaAL7xrelLKw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=6Afwp3MJaiCv2u3+xI34I5714rqRhtEykHH/+zGcWUM=;
 b=bJ6y6GzsRhq38ywly63DGLdlUXqsv3U2ssVo5+40eBIJQ1GNmiMFXkf+ZrwH7ajFAxvLal/ZJdLUlrhZDfeHRiNOD37i/DK00D5iqBgWaxp157lzNaiChml/a2h5sgIXl1k5ft3ICTD2qIO2/TQjmajonGN6fUXd3tbfp4QhK84RnUeVHlUEyyduutPbV0r5iI2Wc1jZcmlGTN7V+gVyKCmsPzk2cI73gPiH5R7YB+NZaXLOiVQZlPCBwsz27HSKK13JMVUCpJa5Nur0bnNTAd1FbDMg65+/QB1e65jRGn5Kz8nW1HZv29qQN5CwsXmaSwMGWlFZ5M+OyHNMYV8oyw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <b254d8ac-8bdd-af65-f9d3-e2fe69ffdde9@suse.com>
Date: Tue, 15 Feb 2022 14:27:06 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH] x86/vmx: remove dead code to create domains without a
 vLAPIC
Content-Language: en-US
To: Roger Pau Monne <roger.pau@citrix.com>
CC: Jun Nakajima <jun.nakajima@intel.com>, Kevin Tian <kevin.tian@intel.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220215112835.99230-1-roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220215112835.99230-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6PR08CA0010.eurprd08.prod.outlook.com
 (2603:10a6:20b:b2::22) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ed198f64-9617-4d06-ab7b-08d9f086de1c
X-MS-TrafficTypeDiagnostic: AM6PR04MB6136:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB61364F7A62C790170105654AB3349@AM6PR04MB6136.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4125;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	tDZo1s6PIOqDQgPP9zQs7eRBy7081cDfaOopxZRIe3bNoGbxDqg2kmyUlmKoQkLM1H4OvWtAWjZVc7BqdHlhA5K2GgotddP3OMd3Q4fJHqtotFWiL1LIcXVw6iwWsVpSeDPDJes3QMXTprSLu/JywbFA3/fRNdYmhJwXXV8OI+Cj50m1sGl0xe443tmEuvYmuWigy03iZRt+yVKSgxPGiKMzy0tEdnGP11Mf7Tw3D29h6V9xVluBHHh2C4ityopp7BKfKY+PAexh2Eq1Ml+7Ln7SImvM6LhVFPlaqht43vgmS448FyKA71SqQ1dT2AtTsexHcr4GqxGytKpBSDsgWLMtTCkT/QeLQPz84aHRkfpZdkHeIfAMUjpHVQVxoNhcxp6nyvWF93xXbPoAIiInWwYcPLUn3E9LpzzMrBqMtY+SXZTmAHUZjJQjfbdZd0F4AUuh831zKAO3Y3BKalf2N70bhzFpBE24gMH+SSMNd2ZzOJZjRyfRVrZJsiZ3S4hTszPuA+/p2YPE5xUV6M4wpE7IACEDO9cZVSeMwU8ttWa96YhWtccIxeDXEpqxh3yla2kCUjSw3G6Y8AXW3FsNwZy/qYOMvsC6WUaMqC4aRa6wyKRuhZKerOwsXfBzZ2EvmTQ0BwI7CrjdCWgwTKM3uWYGnvqL1HnnBYpbWGudEYGvijx0/G5VDrgy336nPEK25rcQdo25FrUiL/zHXqh2lY44G/tE7hB9KUj+4e7KmhA=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(38100700002)(31696002)(6512007)(4744005)(6506007)(36756003)(2616005)(31686004)(508600001)(6666004)(316002)(53546011)(6486002)(2906002)(86362001)(186003)(26005)(8936002)(6916009)(8676002)(66476007)(66556008)(66946007)(4326008)(54906003)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?NSqT6J2m/jeBCW0DKjKqB2v1QzBg1qt78ZU+lv2iaPfM98YLYKASbaDGnFWP?=
 =?us-ascii?Q?oMWNFQn6u9CzfWsjeBMKrOXsR5ffy8t7OJiPAnZdsP+xBAHUnvoBA1AqzsbR?=
 =?us-ascii?Q?+5eWT0poC/psejfJsS33HzF9crdsf3nzK9hK7H72tIe5I48N8mb2RdTFxFpd?=
 =?us-ascii?Q?mgZHKbrPexFBV0U6WFCg7NpJBn5Dtza3nsr5VrDAHggwuihZfxIPVbcAUBq7?=
 =?us-ascii?Q?qBng7EOS4/Ez8BgvJt5O4b6OFuBwCAzhMxL8te3erj9U7RG9eapxahqYAQfJ?=
 =?us-ascii?Q?ydtMnjvv4NGawIociLzNaKSSKQCt5WsxLok3ewEtyrJh0O/fxRxrSX/hKSv8?=
 =?us-ascii?Q?Cio9nHS+K4kLJ04n/cV3mbDUeRB8+HcvTNs+fmW33grvKAHEYCcBuWKpSL2Y?=
 =?us-ascii?Q?r3fk+vx1cgvpOiOe43vejWHBbovZmxgBHRAmcN0OTkRpx7N1MWQV6zMCVey1?=
 =?us-ascii?Q?m4+nJZVV/fIn/rJjO4dlJl/fkDqI0IodT82Nyi6iePcIQ0D3ZN4yCksH0o9M?=
 =?us-ascii?Q?sWKiCfNwuDn2tXXYoHXzAMPONjENYCUsQYTDuYJL+rcTfA16+qpElAJxdlM/?=
 =?us-ascii?Q?9iKADsbw3wfu3HLieatlmvttHljNwbsqAezqutXRHNL1QCYXdncsfd4xaVvx?=
 =?us-ascii?Q?kNg9QTdQHGKi7F1FEgx+WAGyzTVnIVZpElq1u7wN8QBST0IbAdYfT1dPtcH+?=
 =?us-ascii?Q?NYpu6i5bu83nEmYfyrByEyaUoqmbP8Dt39VHxYT730jJFF4fs8To1YhcUq3L?=
 =?us-ascii?Q?6Dg2c3Ro71MhZom5ezKdamrOkdN4ZkdXGc5T65SgDKX1+fUrvKXxc9035fZ9?=
 =?us-ascii?Q?goSxil7Wxf9C6IqashZ+pHS8r56mCb9OyVxe/E+mYd36ppeHQTgQZO2zbaHJ?=
 =?us-ascii?Q?E4w2AUURmuFrOWis85/J2pBidIGff70tOygdC23Mfciq486tbBbPz3FUzZq/?=
 =?us-ascii?Q?MEMedypzPYXit2NClGz38ZNmvmMFzIloLC8WBLefO3FpqDidO3u4R2HXLOdj?=
 =?us-ascii?Q?5LUDFayKJAv6Uwayl/mr+SlNzeLJLl1miKq2+bqsiw7pVWhRTJlXJue8+Z17?=
 =?us-ascii?Q?7zPUCxI70iCSw8su2Df6cry6QPl23vSGDYee8/2U158KIr4FzIsmK1bAe7E1?=
 =?us-ascii?Q?txm/laWsdszo+RFNqo3V7uo4xQQuVkbUCv17HGLwm6PiXOidisC6Oxmox5RE?=
 =?us-ascii?Q?Rt+41FFq+3Ayfpj9Og7SSgaruttTPR0EKQHtIp4WFzoZArIbIXWV9+aWq4d8?=
 =?us-ascii?Q?i79t6zB1A3pEuQehddBZTwgyJr8nejfMqUYjA+Ro+i8rrOzD2m/XsAXdVjoR?=
 =?us-ascii?Q?lPtudYuWSeVJ2q7DViuulLFW+oHh0r0vHbvqIc0bbzisCfFehVuUhRgRdOhH?=
 =?us-ascii?Q?M3t4g8z6m735oE60YgjQZoXVUNEjB6aPEdqsJ6bfV1uDA8bnZDf3FsVFIPY8?=
 =?us-ascii?Q?IhtY9ktEq+hK0RGmjUMuTjvQ/QbPlYtWQGArdl4mycIuJevQ9v4CJEeszMbd?=
 =?us-ascii?Q?XOp23lbsoOMcnr+ujDHPDHHl9kwgkcc9uWlL+jI4r8aMFXcAZzmE7ZjIOm4a?=
 =?us-ascii?Q?KsSjlY9EAFAA47Tq4yBhDrlxnNeJRH7yTKAjfhAn33q2lD9iPxVwO4AqCf2I?=
 =?us-ascii?Q?514pHmjoBeRT9xo2nc+3Cys=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ed198f64-9617-4d06-ab7b-08d9f086de1c
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 13:27:09.4371
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DriN0o1l4RSenkU7T8eLZTFIbM3a4iYQzrvwOg44Ce2VtC29n0hmcXZ/6n+gjfregLv++fKPHrpURYsmk+wQHw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB6136

On 15.02.2022 12:28, Roger Pau Monne wrote:
> After the removal of PVHv1 it's no longer supported to create a domain
> using hardware virtualization extensions and without a local APIC:
> PVHv2 mandates domains to always have a LAPIC. Remove some stale code
> in VMCS construction and related helpers that catered for that
> use-case.
>=20
> No functional change.
>=20
> Signed-off-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Tue Feb 15 13:44:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 13:44:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273186.468277 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJy7a-0007ub-Cw; Tue, 15 Feb 2022 13:43:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273186.468277; Tue, 15 Feb 2022 13:43:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJy7a-0007uU-9Z; Tue, 15 Feb 2022 13:43:58 +0000
Received: by outflank-mailman (input) for mailman id 273186;
 Tue, 15 Feb 2022 13:43:57 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1FBm=S6=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1nJy7Z-0007uO-Ev
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 13:43:57 +0000
Received: from ppsw-40.csi.cam.ac.uk (ppsw-40.csi.cam.ac.uk [131.111.8.140])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 50e84f98-8e65-11ec-b215-9bbe72dcb22c;
 Tue, 15 Feb 2022 14:43:55 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:55400)
 by ppsw-40.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.138]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1nJy7W-00033V-lI (Exim 4.95) (return-path <amc96@srcf.net>);
 Tue, 15 Feb 2022 13:43:54 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 614E61FB0D;
 Tue, 15 Feb 2022 13:43:54 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 50e84f98-8e65-11ec-b215-9bbe72dcb22c
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <d62fddef-5cae-7334-ed0b-cc2c9313f040@srcf.net>
Date: Tue, 15 Feb 2022 13:43:53 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Content-Language: en-GB
To: Jan Beulich <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
 <20220214125127.17985-35-andrew.cooper3@citrix.com>
 <2a5e1893-506e-e4fc-dbff-6001feec1e99@suse.com>
From: Andrew Cooper <amc96@srcf.net>
Subject: Re: [PATCH v2 34/70] x86/emul: CFI hardening
In-Reply-To: <2a5e1893-506e-e4fc-dbff-6001feec1e99@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 14/02/2022 13:38, Jan Beulich wrote:
> On 14.02.2022 13:50, Andrew Cooper wrote:
>> Control Flow Integrity schemes use toolchain and optionally hardware support
>> to help protect against call/jump/return oriented programming attacks.
>>
>> Use cf_check to annotate function pointer targets for the toolchain.
>>
>> pv_emul_is_mem_write() is only used in a single file.  Having it as a static
>> inline is pointless because it can't be inlined to begin with.
> I'd like you to consider to re-word this:

This is the reworded version.

> It being static inline was for
> the case of there appearing a 2nd user. I don't view such as pointless.

I find that impossible to reconcile with your normal review feedback.

It is unconditionally forced out of line because of how it's used,
meaning that if it ever got used in a second translation unit we'd end
up with a duplicate function, at which point it would need to be
non-static and exported to pass review.  (And sanity.)

~Andrew


From xen-devel-bounces@lists.xenproject.org Tue Feb 15 14:02:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 14:02:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273195.468288 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJyOu-0001wi-W6; Tue, 15 Feb 2022 14:01:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273195.468288; Tue, 15 Feb 2022 14:01:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJyOu-0001wb-Su; Tue, 15 Feb 2022 14:01:52 +0000
Received: by outflank-mailman (input) for mailman id 273195;
 Tue, 15 Feb 2022 14:01:51 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=p95L=S6=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nJyOs-0001wU-RU
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 14:01:50 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id cfc751e4-8e67-11ec-b215-9bbe72dcb22c;
 Tue, 15 Feb 2022 15:01:46 +0100 (CET)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2055.outbound.protection.outlook.com [104.47.12.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-38-Z7dIUmiOOTu3pPl_zdg3TQ-1; Tue, 15 Feb 2022 15:01:45 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DB7PR04MB4937.eurprd04.prod.outlook.com (2603:10a6:10:18::32) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.14; Tue, 15 Feb
 2022 14:01:44 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4975.015; Tue, 15 Feb 2022
 14:01:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cfc751e4-8e67-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644933706;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=HHsgt/pCVOD8X4+s5UZ1Dj1Y4nRKXR4uUA1dt6XbSfY=;
	b=F8Zxhjw1Mh8kYZYbhL4Ka5Ie70Z7Lvi1IoI+4d1eftSmQfuKNv9le5dzKbXiA4GGPVPdnE
	XqUucy3sFIixatj1A3CW1yxGQ9qlPnzAwiVtaO85Hp/SORa/hMeusgOjG7YFiY9xYnB5O0
	qLW8gRwVgHvxu3byGZomGVQtdBMq1go=
X-MC-Unique: Z7dIUmiOOTu3pPl_zdg3TQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=RY9jKxhT6nP1ubwZ9g9jjkWsOvLo8oLoj00ogOjXei7RHoCHC5dYmdpu4J/RkOrMmrzbYdiv2SFSdUZsLkRRlt/I3o3FtioAV/iXzFgR66eW0lT/xFr8j6kchjCxGTfKunJNPFLk6+yfvCXp01GLWKEgLHSJ+h5jrN6hqVWnyPcB8Kvjar43iAUQx92LRlYb6bJPcnwiVUMKplkvJ8fRKC60OO+aKBwdiaFgB4a70XBQz3L8U9djKLSaUxfp3EawOlBtOaRKUvLxIR9IdggMXBK/ncY/NquhbkCN90JzlYq1rKIIV9K0e6isq0WxayKXtX0V5Vq2xTa/8te1vp0ORw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=HHsgt/pCVOD8X4+s5UZ1Dj1Y4nRKXR4uUA1dt6XbSfY=;
 b=cAp9uG1VLhkPFIxGm19hulH0XhAroKWNzn61zT/1h4YLM4Ok8n1iFn2uR/cGGYOJELIOATl7lZy/nWczx1sFImz0dtLSKVesl9tvIJWskpD1WhC5nApgoDNLR3MnOQLPxFkOza1c4WEu+8ZuqBPv1cVPibEP9Hwow1oMxatbmL4QeMiykFkAI3IVYf2/c6vqQHaiXJJVq0iuCcOO+e/gz6xK24a0qum/w6gC3MfQ7EWOPaJtIy2gVoozCgCVC3yqSCM7KMOO/VlK1crv2k8zw187v3gqcKW/D2A5aDWFFdt4DmHL6pMPP6rVHjzghZn13sFbL5fM3SQIGOZGvLeyTQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <26bc666b-e9c3-7f12-6d8d-256311846233@suse.com>
Date: Tue, 15 Feb 2022 15:01:42 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH v2 06/70] x86: Introduce support for CET-IBT
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
 <20220214125127.17985-7-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220214125127.17985-7-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0601CA0025.eurprd06.prod.outlook.com
 (2603:10a6:203:68::11) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: bd3a96c2-67a8-4dd5-34da-08d9f08bb2e3
X-MS-TrafficTypeDiagnostic: DB7PR04MB4937:EE_
X-Microsoft-Antispam-PRVS:
	<DB7PR04MB4937B46E0141B0C540648620B3349@DB7PR04MB4937.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	v4Qab6UF3PyBQLhlkZ9mGRo4b1DJffb479pcqGe+LxdpA56L3mfeEaLV9Xzi6QuxqSuBxtqwG2xJsAIMz2pIX3VI7wPZ9yaFSCm9Kg6kHbt7Fsds+uRlxraJVD8qZUmkkROW+JAHdTBhPYsRiNjYxEFX7aeD4JWmYTETxtQAmq8a+OWKHvyYr9uiXaRBU6e65m3WXw0gHFGR6K48JZlLaar1Crf/hODCDLlaSkZYYeo/4RsABAdT0LAGKPxgGRf/MRggsdc0n6gobTqEPpdvCB2qTZcHaP/5n21Yxmpasyatjo7ZUr/8bGv0RT/hycXnFyovEHd35iRffHAIg1VBMY/90dSpI9I2JNMfa1raPYIzuZ6r+CKua2XnTtW7azLUpSBasIpVdtZfKuakE/ABM7fRDvACcH81tca6JAp3nH38Bl2UdOFwUlgWlNGYYqmoc01lq2qbcuwAIXlUuhIXybZRz+oGdH2rbAu4cO2Rv8V+uhRwK1Q8+g3AXldVe9N7nF7AOCoErhrL3yv+vuKEi5KKAqUVZMhFD4TQofeDyPK6OFxHurAEtfCwfZ6dgppgJGNHqxzSN8yUL+o2fBheSzOCimD5L4uP24/AVRDmdbiMA3hELxmK6V/aIbqmNnzW0ZgI8HLgYt7hdpsLLlQRQMrH5Oapk4M30dn+aOtrbixHwUrkYQLb/80IvcMFsPjZUXohDVvwy8YCzIESuDKEM2NAwsunyB0Axw51goJZsEziC0wJ/JcluL3lgdRIEb+Goi/Gh3mp5G7rGjCotvhA/y5Aq6tzfRvsOB9wp1qsLRoYLdXv9vdM03fZSwC1Vwyh
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66476007)(4326008)(8676002)(508600001)(66946007)(66556008)(2616005)(6512007)(31686004)(2906002)(86362001)(53546011)(6506007)(54906003)(6916009)(316002)(5660300002)(186003)(31696002)(38100700002)(26005)(8936002)(36756003)(966005)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dW0zYTFsSHh0L2I5ZVRUU3BOdEQxWXIxN1V0aTJ5OVhTdjhjZWdRUThjMmtY?=
 =?utf-8?B?SE94U0UzMjRKSlJlTktNSFdKOVltREhtSVJYQk83RGpsMGRxRVBYYWRvdGdG?=
 =?utf-8?B?dVgxdXZaVzVWTFVLU2hmZXZwSVAyMUJLS01LNFZmNkpKRnM5eTI5S2x0TFlj?=
 =?utf-8?B?NTZVT1Y1Y0sxb3h5S0JxZ291WVhabC9uM3JaWko3Ly9DSFQ3TGFtTWk5NHRl?=
 =?utf-8?B?UTdnNGtRbDExcmZzcVF6eUlSaWRlM3RuOE1tTUdtYlp6cy9QL1BhUHBYWnNC?=
 =?utf-8?B?UnB2MVlsRU5wdnMyQkFBcjZCa0RybU14MnRRSERiUDNKVUZKd2RqTWVEY1Fn?=
 =?utf-8?B?OWxMWlhtMFZWNDlwc0V0WTVCOFpJSFphOXJEc3cvUCtkSXV0TXYreTgyMDMy?=
 =?utf-8?B?WkxMemQzRTJuMWVjczcyaURGT3pYSGExQUlxUTRvcGN3Z0VuVzlSbkJ2dkIv?=
 =?utf-8?B?cTBaS1BISHhwZjFUMFd4ZE5tTkphdFl1TCtaYnpVeWhhbnFwdWpHNmd0MCtm?=
 =?utf-8?B?VTF2WkNTL1VvNVEwMFdnYUU3elpRazlMSU1SQjdEdUFQaERsV1JRR3RKS2tV?=
 =?utf-8?B?UUsrYzllZjd1bjZpRDlaVWtDWkd1SzZyTnc3ZlhXRlJ1Y2pjQS9TQ1kxQVg1?=
 =?utf-8?B?RUJ5S1p6ek40M1J4RjAvbklpeW5DVEQ0QkYzSWZ1M2ZrUFJSTnBnTlFTYkNl?=
 =?utf-8?B?NlE3Zit6c0VFOEJ5aVU2d3YxL01jZ3BjS1I1Y0g1Znl0MUtXN3N6UWRUQ2ZF?=
 =?utf-8?B?ZzhBL3VTUXBOczY5ZUZNN1cra0U3Rk01TTdud2l2K1o2Y0V6WHc2a0hqZXhs?=
 =?utf-8?B?d1Q0dDFzZGt5dVF5bHdCa2l6NUIrUHc4Zmk5U3dLb0JiK1Rma2RVVUdGd1dy?=
 =?utf-8?B?bWVkMDdGaFdJa3h4a2llMWplMThONDViMHRFekxPbDM0VGU2eDhMYmdvelh5?=
 =?utf-8?B?RmZEZnFIeHp2RG5HTE1BelI4bW84TWRzVGh1UjJjSFkxdnYvTUxiTGpTOWc5?=
 =?utf-8?B?akpkbkhnSHdaN3NGcG5mTlI1YkR2QUE4R3dpRjZBeU8yekxqbi94Uk83SGxa?=
 =?utf-8?B?Y2tQYkJ2L2gyc3EwMGQ0SXNHU2pwWkJ3dnMxUEcxVWZYUGVHTnZ5Y3NhMlk3?=
 =?utf-8?B?THlhOFVUMmtQM0xxbmtxbUZlZnJLQ2xXWnJQOVJLMzBwVDNmcjFnZGkyTGhi?=
 =?utf-8?B?YTJzc3NRbkFQeFJsMms5Q0p5cENFd1Fjc21DQ3hVWm9uWHQxTitQb2FxVXRv?=
 =?utf-8?B?ZVdrNXJlYkF0bzdMcXE1LzZ6NkJOVXNNaDFkaExFOXorQlVQM3VNcTJybnN6?=
 =?utf-8?B?TnlxdWhFRjVXYXVOSkUrak9tRU9KZmRDQ0VZNlNveW9oWGxJczBGQ21jQ0Vi?=
 =?utf-8?B?VXd2MmFXT3VrS3pQcDlQSTB2M0pYV1NaV3lJZGUxVStNUUU1THhGL2hSQUxt?=
 =?utf-8?B?UHNsZEk5K3RsTnBKRkZ6M3hBSDdqdnVNTUlWZm9CV2VhWU9ieVIybDQ3TlhU?=
 =?utf-8?B?MXlQS24zOUhMcTZxRmk1T0lqQml2M2Q4TDVmUjJFZE41R3F4dHV1a2hDQjFY?=
 =?utf-8?B?MkZ1WHVBK3BTM09QNUxPQnI3ZHFCalZPb295NXNxNkV6N0FTYjM2T3VtZlY4?=
 =?utf-8?B?Rit0TEtzWFNsNTNvRXgyWkpqWm1tME5sL0VlWnVDRlUwUDlzK1RDeUJaZ3cr?=
 =?utf-8?B?Vm83ZkxXSnIvTXpuL1BaQjFWZjEwUkc4WDVaMzdIVE03bXNsOVFWQWg5UlJl?=
 =?utf-8?B?ZEhjb1EyYWY1dmlzWFVnTk95ZDdWbTBuRXM5ZDBOOHFBT2F3NnkyVWwzeE4v?=
 =?utf-8?B?SElmc055Z0UvTVc5R2h4RHRZeWRwcFF4Mlc2c3dsa3l2SVNTdElyZllDUnJD?=
 =?utf-8?B?M200cGlxWmZ5UjRYMENHQTEwMURsbXdPcHVxbUZjU0lmR1JGUDdjVnpuY0Zx?=
 =?utf-8?B?bC9SYm9mQVpEcnFuUndvQTNPTHk0bnpwaUZxSEZjc2VmN3JXeFBYNUtHN1Zl?=
 =?utf-8?B?QXhjTFNBOVAxNUQ0TWRzc0twTEdjTmpvOGF2dkhaQUh1cm4yYm1aMzdWWU0y?=
 =?utf-8?B?N3hhaDg0cmNkeXRMUE9oT3FVMDNLbWcwcStvWkFkRERUZXFVaXZoUlc2YmE2?=
 =?utf-8?B?U0hNdDFqZ0Vsb1dPN3RBaDA0b0dtemgwYWFGTWJsNzV4U25helYvVGJRemZq?=
 =?utf-8?Q?yMsS6hMAHASlMXIql5WRFA0=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bd3a96c2-67a8-4dd5-34da-08d9f08bb2e3
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 14:01:44.4334
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DpXMfnvSwL0hlx+RTq856ysQupsppTIUrYTDJV6sWoe4GjxmaYrJSe04eQT8rPRFsEFK7iHffSEAeea0sNM2eg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4937

On 14.02.2022 13:50, Andrew Cooper wrote:
> --- a/xen/arch/x86/Kconfig
> +++ b/xen/arch/x86/Kconfig
> @@ -39,6 +39,11 @@ config HAS_AS_CET_SS
>  	# binutils >= 2.29 or LLVM >= 6
>  	def_bool $(as-instr,wrssq %rax$(comma)0;setssbsy)
>  
> +config HAS_CC_CET_IBT
> +	# GCC >= 9 and binutils >= 2.29
> +	# Retpoline check to work around https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93654
> +	def_bool $(cc-option,-fcf-protection=branch -mmanual-endbr -mindirect-branch=thunk-extern) && $(as-instr,endbr64)

At the top of asm-defns.h we have a number of similarly operand-less
instructions expressed via .macro expanding to .byte. I don't see why
we couldn't do so here as well, eliminating the need for the
$(as-instr ...). In fact ...

> --- a/xen/arch/x86/include/asm/asm-defns.h
> +++ b/xen/arch/x86/include/asm/asm-defns.h
> @@ -57,6 +57,12 @@
>      INDIRECT_BRANCH jmp \arg
>  .endm
>  
> +#ifdef CONFIG_XEN_IBT
> +# define ENDBR64 endbr64
> +#else
> +# define ENDBR64
> +#endif

... it could also be this macro which ends up conditionally empty,
but would then want expressing as an assembler macro. Albeit no, the
lower case form would probably still be needed to deal with compiler
emitted insns, as the compiler doesn't appear to make recognition of
the command line option dependent on the underlying assembler's
capabilities.

> --- a/xen/arch/x86/include/asm/cpufeatures.h
> +++ b/xen/arch/x86/include/asm/cpufeatures.h
> @@ -39,6 +39,7 @@ XEN_CPUFEATURE(SC_VERW_PV,        X86_SYNTH(23)) /* VERW used by Xen for PV */
>  XEN_CPUFEATURE(SC_VERW_HVM,       X86_SYNTH(24)) /* VERW used by Xen for HVM */
>  XEN_CPUFEATURE(SC_VERW_IDLE,      X86_SYNTH(25)) /* VERW used by Xen for idle */
>  XEN_CPUFEATURE(XEN_SHSTK,         X86_SYNTH(26)) /* Xen uses CET Shadow Stacks */
> +XEN_CPUFEATURE(XEN_IBT,           X86_SYNTH(27)) /* Xen uses CET Indirect Branch Tracking */

Is a feature flag actually warranted here, rather than a single
global boolean? You don't key any alternatives patching to this
bit, unlike was the case for XEN_SHSTK. And the only consumer is
cpu_has_xen_ibt, expanding to the boot CPU's instance of the bit.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Feb 15 14:10:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 14:10:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273202.468299 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJyWs-0003KG-R0; Tue, 15 Feb 2022 14:10:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273202.468299; Tue, 15 Feb 2022 14:10:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJyWs-0003K9-NY; Tue, 15 Feb 2022 14:10:06 +0000
Received: by outflank-mailman (input) for mailman id 273202;
 Tue, 15 Feb 2022 14:10:05 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ZAEc=S6=linaro.org=vincent.guittot@srs-se1.protection.inumbo.net>)
 id 1nJyWr-00031S-1s
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 14:10:05 +0000
Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com
 [2a00:1450:4864:20::22f])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f7d13fe7-8e68-11ec-8eb8-a37418f5ba1a;
 Tue, 15 Feb 2022 15:10:03 +0100 (CET)
Received: by mail-lj1-x22f.google.com with SMTP id be32so8403788ljb.7
 for <xen-devel@lists.xenproject.org>; Tue, 15 Feb 2022 06:10:02 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f7d13fe7-8e68-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc:content-transfer-encoding;
        bh=IGTljEiet/h8+/EkX92WrZJaQ1iS0XGH8pAVnyiGdDM=;
        b=KY6QVZ7HvRyaQ1QHYuusag+3GfgOGK5EBcnz0eb4wuKfg/8+7o3tXkfMB1DL4K/xCT
         G5E/QnJP9b4RG4K55Hby0N6I8RJJA9rIYbCVZSNZJzjbXdhl6Lv42HOjk1wKbPuawoSJ
         TtnEGaln1n4zHzAFT1QsEf5uIEfPESbAh3Ik6yCrODsPVOgycIKPFMjKJ8fVVpDpvTIF
         kpYaLBp0OWkA3eSaYTEeC2H359etyg4+Dwra8IfMchY4mj+0g+6AXvjgTkO5mfJLrN4e
         qQdoY0jUFgi/ELIMf1R1dpTqyAgZOIRb1VinjO2+zx1i9Inq/uZTpU1b0WmvIwozcrBL
         tQHQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc:content-transfer-encoding;
        bh=IGTljEiet/h8+/EkX92WrZJaQ1iS0XGH8pAVnyiGdDM=;
        b=sUM/GMa12Vo7drLHQKNbEVcgf8vnLiUBXMdlvNf+KfWZm2ZS42Tvm4jz2DsyBMaPya
         KniKC2zvCo+9rMVSpmXe5BFxaWu0e+zjDff7iUkcreSCvLLQKLJyIQMPOpwDSuwhNSlx
         nR48s3amh+9aPeYZMHFa4HtUMrnDV3/zkbRpjU7B1MOO97o355wReLU/tf0OOeOPf9sa
         MqXZ8vx86zo7XERUni3DOYf1GR4RUjSy1YMkxm888czx1Snj0M88qsSSChIy3WMIC751
         N/y8EO4CdyqYudfNQHgiARrgq1aBSRpUZW28HIXAVlBGQEr+Q6KChNt80lRPM0yE3p/0
         kTRw==
X-Gm-Message-State: AOAM533M0sR9YiF5FovTF65Uahg/pdJ0vWD2rr5pmMxllWO9uipvjSPl
	2Gd5525xBLm3F/fy/MxTlQJoZx58W5MGVAySmP0XZQ==
X-Google-Smtp-Source: ABdhPJzvPz6sdAiQq4+CkHFSa4QaI/v9q+BS7Iy7k43HlhuMeIrPRBXB/RR/JBRWnWScJdTbEtiKFRx84ckdGy+uAME=
X-Received: by 2002:a2e:6e0c:: with SMTP id j12mr562890ljc.92.1644934202134;
 Tue, 15 Feb 2022 06:10:02 -0800 (PST)
MIME-Version: 1.0
References: <87h79bgd1m.fsf@linaro.org>
In-Reply-To: <87h79bgd1m.fsf@linaro.org>
From: Vincent Guittot <vincent.guittot@linaro.org>
Date: Tue, 15 Feb 2022 15:09:43 +0100
Message-ID: <CAKfTPtDADbQfe2_mQQObgRL-BnakXvpK2EMDTTbok0V8b1bd-A@mail.gmail.com>
Subject: Re: Metadata and signalling channels for Zephyr virtio-backends on Xen
To: =?UTF-8?B?QWxleCBCZW5uw6ll?= <alex.bennee@linaro.org>
Cc: Stefano Stabellini <stefano.stabellini@xilinx.com>, stratos-dev@op-lists.linaro.org, 
	xen-devel@lists.xenproject.org, AKASHI Takahiro <takahiro.akashi@linaro.org>, 
	Arnd Bergmann <arnd.bergmann@linaro.org>, 
	Christopher Clark <christopher.w.clark@gmail.com>, Dmytro Firsov <dmytro_firsov@epam.com>, 
	Julien Grall <julien@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi All,

Sorry for the late reply but I was off last week. I will go through
the thread and try to answer open point

On Mon, 7 Feb 2022 at 11:56, Alex Benn=C3=A9e <alex.bennee@linaro.org> wrot=
e:
>
>
> Hi Stefano,
>
> Vincent gave an update on his virtio-scmi work at the last Stratos sync
> call and the discussion moved onto next steps. Currently the demo setup
> is intermediated by a double-ended vhost-user daemon running on the
> devbox acting as a go between a number of QEMU instances representing
> the front and back-ends. You can view the architecture with Vincents
> diagram here:
>
>   https://docs.google.com/drawings/d/1YSuJUSjEdTi2oEUq4oG4A9pBKSEJTAp6hhc=
HKKhmYHs/edit?usp=3Dsharing
>
> The key virtq handling is done over the special carve outs of shared
> memory between the front end and guest. However the signalling is
> currently over a virtio device on the backend. This is useful for the
> PoC but obviously in a real system we don't have a hidden POSIX system
> acting as a go between not to mention the additional latency it causes
> with all those context switches.
>
> I was hoping we could get some more of the Xen experts to the next
> Stratos sync (17th Feb) to go over approaches for a properly hosted on
> Xen approach. From my recollection (Vincent please correct me if I'm
> wrong) of last week the issues that need solving are:
>
>  * How to handle configuration steps as FE guests come up
>
> The SCMI server will be a long running persistent backend because it is
> managing real HW resources. However the guests may be ephemeral (or just
> restarted) so we can't just hard-code everything in a DTB. While the
> virtio-negotiation in the config space covers most things we still need
> information like where in the guests address space the shared memory
> lives and at what offset into that the queues are created. As far as I'm
> aware the canonical source of domain information is XenStore
> (https://wiki.xenproject.org/wiki/XenStore) but this relies on a Dom0
> type approach. Is there an alternative for dom0less systems or do we
> need a dom0-light approach, for example using STR-21 (Ensure Zephyr can
> run cleanly as a Dom0 guest) providing just enough services for FE's to
> register metadata and BE's to read it?
>
>  * How to handle mapping of memory
>
> AIUI the Xen model is the FE guest explicitly makes grant table requests
> to expose portions of it's memory to other domains. Can the BE query the
> hypervisor itself to discover the available grants or does it require
> coordination with Dom0/XenStore for that information to be available to
> the BE domain?

I have noticed that it was possible to share memory between VMs in the
VM config file which seem to be quite similar to what is done with
qemu to share memory object between VMs
>
>  * How to handle signalling
>
> I guess this requires a minimal implementation of the IOREQ calls for
> Zephyr so we can register the handler in the backend? Does the IOREQ API
> allow for a IPI style notifications using the global GIC IRQs?
>
> Forgive the incomplete notes from the Stratos sync, I was trying to type
> while participating in the discussion so hopefully this email captures
> what was missed:
>
>   https://linaro.atlassian.net/wiki/spaces/STR/pages/28682518685/2022-02-=
03+Project+Stratos+Sync+Meeting+Notes
>
> Vincent, anything to add?

I want to use an interface that is not tied to an hypervisor that's
why i have reused the virtio_mmio to emulate the device side where the
backend can get virtqueue description

>
> --
> Alex Benn=C3=A9e


From xen-devel-bounces@lists.xenproject.org Tue Feb 15 14:14:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 14:14:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273209.468310 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJyaf-000404-BS; Tue, 15 Feb 2022 14:14:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273209.468310; Tue, 15 Feb 2022 14:14:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJyaf-0003zx-8D; Tue, 15 Feb 2022 14:14:01 +0000
Received: by outflank-mailman (input) for mailman id 273209;
 Tue, 15 Feb 2022 14:14:00 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=p95L=S6=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nJyae-0003zr-0h
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 14:14:00 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 83ec60c7-8e69-11ec-b215-9bbe72dcb22c;
 Tue, 15 Feb 2022 15:13:58 +0100 (CET)
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2058.outbound.protection.outlook.com [104.47.2.58]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-39-rBoJEjRqOG22AoAVWLazyw-1; Tue, 15 Feb 2022 15:13:57 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by HE1PR04MB2972.eurprd04.prod.outlook.com (2603:10a6:7:1e::23) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.18; Tue, 15 Feb
 2022 14:13:56 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4975.015; Tue, 15 Feb 2022
 14:13:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 83ec60c7-8e69-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644934438;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=vITAXfpxMsWQ19MluGR+K2xujRwAEOMY+Wd2yCKgqfw=;
	b=XCx8hLlaTEPGz1ymT3D0qYJHRG6L4HdbqdG3IyVgHKntQirx/XlBHJQ0jIaSfbjTcIGAQw
	htxH/QDGcc6osyPGjHB8d21VhxhiDlUFTjMnxK4TH6qE9C2pRl4/l6ZS3d2Ti84ixRArCQ
	c0d5OkJI7swxonSU1fiIqubA0qNW38E=
X-MC-Unique: rBoJEjRqOG22AoAVWLazyw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=AFtAFNiqgNYa4vfI11jTGM0YZ42E564If/ze1PWc56NHab+N2nyngyD5CoO6JhfOQ5xF999STUdDTzOuHK+xHUP/4SkjWj1V95+ELK0gDuWg2wAzRytNy3Q4m68jm20XkQtIbCVjREx1O3IF7IYZDCqDyd/QpnElX4sQdCUibfwCFsjD92BUxRT4Ul5hKOfRH9CQd/YwaUJM8FSMjlxms4uwvQ0JdRX5YDH4nzPmcc5aEH01sBnauPGYbQR5jOTfguoaKbrNzIS3MEuuDNe85H81mvrTlK+WnSo+QEkfOSEET9J/rgSht/TFyvwsQwOtNus/w/3ShPWEbGCgCaUozQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=RZR6gVge5Kk8yqJ9+685L/Ewmkuay5svUTOsyY0vD1Y=;
 b=gAxfqJ+MFkKx+D4p40q298tpbjotWPAR6TQ4RuLm0/xVU9m30J0uwH0Fl57Ln+OPLmAeA7u1NQDjo4JqUALNSlBwlzYQibsPWOhNbRPPOVhZLuRK6e7eWW6hQlSFnkRpnBaazhrHovuBOLt5O58v9HUpcCh9woLCU21XHImgb6213LaASkmnh1uwpHAuvb7D1AdTfHepQv/ui+V2XRc9GtR6C3kWI3I6kap1VZPS54UTtiMspAeUUHXaBgrGXtwYDZjPDCkDs4K2/+4yYT+fdZskwxUZs0qKRzj7IHcdI4I2dWZu7k7P193/SSayZPaNvzaCBpkZrX5KoEhUx8sA2A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <21e40ac1-277a-8675-1299-54561ab3d2d6@suse.com>
Date: Tue, 15 Feb 2022 15:13:53 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH v2 34/70] x86/emul: CFI hardening
Content-Language: en-US
To: Andrew Cooper <amc96@srcf.net>, Andrew Cooper <andrew.cooper3@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
 <20220214125127.17985-35-andrew.cooper3@citrix.com>
 <2a5e1893-506e-e4fc-dbff-6001feec1e99@suse.com>
 <d62fddef-5cae-7334-ed0b-cc2c9313f040@srcf.net>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <d62fddef-5cae-7334-ed0b-cc2c9313f040@srcf.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6PR02CA0005.eurprd02.prod.outlook.com
 (2603:10a6:20b:6e::18) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4a4ef642-7e73-4792-9005-08d9f08d66f8
X-MS-TrafficTypeDiagnostic: HE1PR04MB2972:EE_
X-Microsoft-Antispam-PRVS:
	<HE1PR04MB297297DC6B5253ECF277DD0DB3349@HE1PR04MB2972.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	KKVD15b/1yhdQYceZnimw48SUNO07kwZmfVJ8H8eVsjrE74pBBEZ5iNfi4i1MCUXBNOQniW67ty5qiZ43NH75rO8U62Jco6bH2E2lDJj96QW/Nzg/fzB4e4gIxL8QL9Pv3FG1lH4A1JcimPMtHvrhXj3ZSgSwwUsQmtExz1s15coaW0UWT1qdr+EEkcOeLoIh+K8JTV3aLoBY8aYoDoDcqyyYijCbh4f7D/1IJGfplmr4c99CtQOYz7QV/1bEX6FQCS/AmAv5V0bbi8GWhkpKWL0vAZ7VEgU0XhfBxpkWnqvtcI+DoFA7/7nYFTuorVD+1jlvocPFy4wfVDoHHJ92T2vTTa9gNCpDvqYKZuxmwBd5+IS6wF5BzCM84epHPXU3u9fpEMi3Mwjq+OTBvRCh9f+3zWwZICK8BsZG4JCVa7HbTAniTK1CAa084huI1OkeqQUtem7P67y/wcEez87P/Ocx4mxGI2ZE7DpxfqMnw8OkRw6xRBx//0SL5SP942eCFm8sxqEVibOX5yeppHsqMoRsIg0aLPdK6LUbAzMROWTpeFH5Yp3NZsBtTs5k3SVVQeuJV0QdpcloHEOC+XQ49H6C+iyQBA94fdretQh1bS7zW2VP5EWIJ+z1GyAqY6JMd3GjEH20Tzy13cJLz1TiJw70F6pFGdPJUBTP+z8GDnQ2OcdLJ+KrHrEIlRjxRtt77BhJiQPnrrkk7sn3RuSDfpK8doIgmxXtrmHyOYl5pnRwDcsebUantZY4RJ/PneE/HcZhMre2u5Mm4q+ed0NVLVSu6+WYR0pLj41/8vNoRA=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(316002)(86362001)(26005)(31696002)(110136005)(66946007)(66556008)(66476007)(8676002)(4326008)(186003)(508600001)(6486002)(2906002)(38100700002)(31686004)(5660300002)(6506007)(8936002)(53546011)(6666004)(2616005)(36756003)(6512007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?hMso/lAElN7xyR0MUsP6jt+fgVZu/lhs18pDX+cUCbs76ePQUo1xb0wQYmvQ?=
 =?us-ascii?Q?9XDeZMxEq8IJNiPp6dAPcLALQPDv7QfkZXBZPTVs5k2UhlYHSQIoo0A0jqhb?=
 =?us-ascii?Q?n6USYLdG56sgi/fcO4DvIQKtr8xHwrzClOdj22ypvyp5fda2eTYOohQuGAr2?=
 =?us-ascii?Q?KPwhnbjkNjIBsTEglit748AssBxX011NSA4ppjkxq3QfKxTWqEgalWaLW4Fs?=
 =?us-ascii?Q?+sQeKQO7GvkPigSTPGeTA8EzUwPd2NxBvn0QTJynNcPbjnT0WfsOcNAO/gNG?=
 =?us-ascii?Q?GIoUkSBGKb4ASR1FW9qCae6PHfXX5wH5DFMHNQFYOViF1MJwMy/WZWfw4krV?=
 =?us-ascii?Q?OcYJETds0eBQC7UzsdTBHFjs6HnIwMLnFJSDQ1+IyWvx4NilXMrok4fqbbqN?=
 =?us-ascii?Q?Sq1HMUJGSHZF8g4923bUQh4Dc5Nk2bzq5Iqny6h2BXuY1lQDJJRO9X3Qhs4l?=
 =?us-ascii?Q?d/vqdQedKERkgnhd3R6R3CS0QXaR0Z+s+rom9p+OsoekFVYqdxePRx/i6rzO?=
 =?us-ascii?Q?yg/KK8mFdFdjia23gCIAE2JErmT0Emzqaq6dtXB8qBWHGUVq2Sj9vagXV03c?=
 =?us-ascii?Q?h8gBCc6xvHAWFOyQ43a4KNX5gkL0F5fHmpu1x7LnzpmQlYQq0wv5W1nm1o2b?=
 =?us-ascii?Q?veApJJXOYFR6F5B35FtW18cG4w0IzvFjoiwJNcjdu8fQDiIW925z5YoCVyz1?=
 =?us-ascii?Q?G4aE0ENQFa5tCKYXy77xVAgKqTRDwj7N2JV9T6GKTg0LQ3SHv7Ig4cNowQON?=
 =?us-ascii?Q?GXO1gxnQuKkPMbK5cLMsbDLJ5IJLBkReVD1/NTkRLZQm9SGsR6w9/MjBHudt?=
 =?us-ascii?Q?+OjzwYGm7c5P/3go+woin1rvv2Piigt7+Evz/tzIq/PU3hKKCWKysG8i0Zfn?=
 =?us-ascii?Q?Of1Xm9402fnRiDhB7059htavEygixkPQCnzC/LF6jkpC6V9UVOxaA9XQ+AI2?=
 =?us-ascii?Q?9fCIHWsfYH+2Q3Peg4+F/EzmSXoU8JrXN9q1Q5oWLKqQ2Irk5g54+oM6YSFj?=
 =?us-ascii?Q?JuXZyuIWdjVmmQywjYLKLVyB8cKkhIUIQZnXg9X42yLbSj1wpC/AgwCkWTAE?=
 =?us-ascii?Q?KjTHMZ6Tu6Sa7SM8gqX4w+LDHmGmTn2DWSSFkp+oleG76HL1HpWAfTjvxQkY?=
 =?us-ascii?Q?YMTKFCBxjVuSgJEm6IE40dWUT/v14v6YbtVpW6e3cjAR8EyfupyGzsm5NiU/?=
 =?us-ascii?Q?5um/kEtkRjhCXrc1Q+vF9s+V23eDCxCuAHM+XuSZXj3oHCty2yBgycv3eM0+?=
 =?us-ascii?Q?l+pRPXea8SjWO85FbZ4xtkU3qCmmuLq4CKQhh9gjMv9Cx+WZsPpvo+mQtF0C?=
 =?us-ascii?Q?2wsycQINdyeXsz2ZFUQsTTzNpoVyvoC8J1zftQ17Lp4ejPIVzauMF6VnyaqK?=
 =?us-ascii?Q?mMQhgbzVNCag+/YAs98Lvi0kTPTnERZwMK5S6bll7oaQmhJmWLQL/pWx3ZCe?=
 =?us-ascii?Q?aQidvdoqVIhA6qFPwGzLP6sWC+PL77hU95tiJViwYJqV4/nOO/RT/b6quILF?=
 =?us-ascii?Q?1View0M6G2rvVantmtLAZsXjo0JEHfqdnQalLMf6Q24KPfaHmZbW60xVAr1a?=
 =?us-ascii?Q?OfUTJQy8AMElfq2TkMFijWuAPa0C1Ud112giHhssZP4eQmxjhtjPQ83tb2y7?=
 =?us-ascii?Q?h+vhyv0k4TB10mHlnLLXKYU=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4a4ef642-7e73-4792-9005-08d9f08d66f8
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 14:13:55.9819
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WX457fUJLjmXrjnZgp+pVBGG8esJAFG7Qu1behaeVOqtvsRmkBD5fsVG2boB6ZTk52lqQsXGvr55yvnJIw8Vdw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR04MB2972

On 15.02.2022 14:43, Andrew Cooper wrote:
> On 14/02/2022 13:38, Jan Beulich wrote:
>> On 14.02.2022 13:50, Andrew Cooper wrote:
>>> Control Flow Integrity schemes use toolchain and optionally hardware su=
pport
>>> to help protect against call/jump/return oriented programming attacks.
>>>
>>> Use cf_check to annotate function pointer targets for the toolchain.
>>>
>>> pv_emul_is_mem_write() is only used in a single file.  Having it as a s=
tatic
>>> inline is pointless because it can't be inlined to begin with.
>> I'd like you to consider to re-word this:
>=20
> This is the reworded version.
>=20
>> It being static inline was for
>> the case of there appearing a 2nd user. I don't view such as pointless.
>=20
> I find that impossible to reconcile with your normal review feedback.

Interesting. I don't think I would have objected to something like
this, if it was conceivable that a 2nd user may appear. I don't
think this is the only inline function we've got with just a single
user. I also don't think this is the only inline function we've got
with its address taken, and hence having an out-of-line instantiation.

> It is unconditionally forced out of line because of how it's used,
> meaning that if it ever got used in a second translation unit we'd end
> up with a duplicate function, at which point it would need to be
> non-static and exported to pass review.=C2=A0 (And sanity.)

I'm afraid you've lost me here. What duplicate function? Before and
after the patch the function is static; what changes is merely the
"inline". Two CUs can have identically named static functions, can't
they? Or if that's not the point you try to make, then I have no idea
what it is that you're trying to tell me.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Feb 15 14:16:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 14:16:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273217.468321 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJyd7-0004hf-RZ; Tue, 15 Feb 2022 14:16:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273217.468321; Tue, 15 Feb 2022 14:16:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJyd7-0004hY-Od; Tue, 15 Feb 2022 14:16:33 +0000
Received: by outflank-mailman (input) for mailman id 273217;
 Tue, 15 Feb 2022 14:16:32 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=vySV=S6=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nJyd6-0004hS-6H
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 14:16:32 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id dde46f3f-8e69-11ec-8eb8-a37418f5ba1a;
 Tue, 15 Feb 2022 15:16:30 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dde46f3f-8e69-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644934590;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=fHYFumZUSEv8GHLg4KX2/xVq5AlxmvgxOIW/G7sGDLk=;
  b=NH9W26U8JvC/BcdrVocX0SRzdPonlc2wuXKBxL+u5Ee3LDY1OBssWPOK
   QmepP20s6EZRnPmL9nD6NfpdIYn3N38Tx0cGAjW7mk5tub8984FDX3U/w
   ToXGnP8N0ZeolL0dSBmiY4xWNXjscfzkjql7dk1kWYQ4NFY16PYlATXBk
   0=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: QgDxyYAXWi4CzPlDKkTZtmMlV6X3pAURUY6/aA1k1Dqm2jqnLzPaz0bYSkfXKch5JmuNmxJqmj
 EJO2L/sUSZwqxtAOcAUaC8THBXLYIWU32IglQyQOlaBcjDJ0doP16zF7XUZunBg04woLcYWQPe
 qODYo0GPE1yMKmd38Y7uNg/aaUufyGm2ZzWo0mJk91sF3YS6y5y634l+vZXhOadObfskyy1XRB
 hHfo+h5zVJ7bp81phwpdX2TUd9t+hVAuV/eTol3DwSUOtf/eC0nHzn/VgQyUPc2FWUeqAeIvzM
 LGfVwd57+wXhJ3RV1VrgbZrM
X-SBRS: 5.1
X-MesageID: 64146537
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:IGsTbqr26iux4cjfYg/VwxyNwJdeBmLoYhIvgKrLsJaIsI4StFCzt
 garIBnUa/uDNGSgfdh0Od+y8kJTvMLcnYNhQQA4qCo9FykRpJuZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlZT4vE2xbuKU5NTsY0idfic5Dndx4f5fs7Rh2NQw24HkW1jlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCnb3zVAp2fa70pOg6DBMfDQdlEZFhwqCSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFJkYtXx6iynQEN4tQIzZQrWM7thdtNs1rp4SRKqAO
 pFGAdZpRAbeWT5/KnU6Mc4FkeuIt3TAYxxIqGvA8MLb5ECMlVcsgdABKuH9ZdiiVchT2EGCq
 Qru72n/Rx0XKtGb4T6E6W63wP/CmzvhX4AfH6H+8eRl6HWI3XAaAhASUVq9oNG6h1S4VtYZL
 FYbkgIsp6Uv8E2gTvHmQga15nWDu3Y0WcdUEuA8wBGAzOzT+QnxO4QfZmcfMpp87pZwHGF0k
 A/S9z/0OdBxmJzWVH/CtbSskT+VZiJSM0kZSRMjdxRQtrEPv7oPph7IS99iFou8gdv0BSz8z
 li2kcQuu1kApZVVjvvmpDgrlxrp/8GUFVBtum07S0r4tlsRWWKzW2C/BbE3B95kJZ3RcFSOt
 WNsdyO2vLFXVsHleMBgrYww8FCVCxStbWe0bb1HRcBJG9GRF5mLJ9443d2GDB01WvvogBewC
 KMphStf5YVIIFyhZrJtboS6BqwClPa8SYu1Bq2JNoMVOPCdkTNrGwk0OyatM53FyhBwwcnTx
 7/HGSpTMZrqIfs+l2fnLwvs+bQq2jo/1QvuqWPTlHyaPU6lTCfNE98taQLWBshgtf/siFiFo
 r53aprRoz0CAbKWX8Ui2dNKRbz8BSNgXs6eRg0+XrPrHzeK70l4UKGPmOt4IdQ690mX/8+Rl
 kyAtoZj4AOXrVXMKBmQa2Alb7XqXJ1lqmk8MzBqNlGts0XPq671hEvGX5doL7Qh6sJ5yvt4E
 6sMd8maW6wdQTXb4TUNK5L6qdU6JhisgAuPOQujYSQ+IME8F1CYpIe8c1u97jQKAwq2qdA6/
 ++q2DTETMdRXA9lFsvXNq6ilgvjoXgHletudELUOd0PKl70+Y1nJnWp3P86Ks0BMzvZwT6e2
 1rECBsUv7CV8YQ07MPIleaPqILwS7lyGU9THm/667eqNHaFojr/kNEYCOvRJGLTTmL5/qmmd
 N559fCkPa1VhktOvqp9D61vkfA06ezwquII1Q9jBnjKMQimU+syPnmc0MBTnaRR3bsF6xCuU
 0eC99QGa7WEPMTpTAwYKAY/N7nR0PgVnn/Z7OgvIVW87yhypeLVXUJXNhiKqSpcMLoqb991n
 bZ/4JYbu16llx4nEtealSQFpW2DI0sJX7gjqpxHUpTgjRAmyw0abJHRYsMsDEpjtzmY3pEWH
 wKp
IronPort-HdrOrdr: A9a23:I0PCXK8X5cIN9TiIcfxuk+DcI+orL9Y04lQ7vn2ZLiYlFfBw9v
 re+MjzsCWetN9/Yh0dcLy7V5VoIkm9yXcW2+cs1N6ZNWGN1VdAR7sC0aLShxHmBi3i5qp8+M
 5bAs1D4QTLfDtHZBDBkWuFL+o=
X-IronPort-AV: E=Sophos;i="5.88,371,1635220800"; 
   d="scan'208";a="64146537"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=g1FFy+CGkZbdgQlTL27wKyXhvF79yxksgLI88XCgmkYYbeQupRoIDfcpDQKKfwwxa+tymAVEScdBTusFD6UfwDZI9t5BGmfkC0sJUFBCXpocorushHzM7ipJ+CzHR8wifC+TRnQIW88rd98jwFWAhNua3PuIznjguboq74gZP+2ZJFfO47BSY1JwnH42lqhDQSnj6IyYe7dpJKC7TSQxTSGeFp3PaGtjx3/TzARk0xtBab9z7Gnd/JSJMqS+0YSd8W2NJei+ALOv1EJxpylBt0PItYETOzWdkW9D5e4JcOAjAAlBeLkJcsBRmL2V4XC25IRAanPo9hjF8uBdolqfDQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=kGV0L+/KnQNwueDBMZXeET0IfGjUwvWawy+o5cWbojI=;
 b=dUkho0VYIXMPgTnuRvHZOlRyEnPevx8o6Y8nugiSmrRUxQc6fqLlmcKllbPPC75tP0W+jIxppVkM3IazEcpvRJLvW6GPuPgyGjEv2roqPMEnuk+DVNiyCeEGO7d7IMNBQPLUqG5nwPje6PluI2mzUNidg3oiK0JpAmrI1I/seaVVB68XOeQ/KxASgCZULAhfgJh0zwwt2H7mENsONxWvbdS9TsAV1H6VL+r3wbQTFxvQHqHKVzfWY56d7U5vERWUesk7e8xASBE1ESwRrir/eJPUB34N4+LWf9UR/c1zdOQEtE61oCppDdZrWmudyFMdQHr790fTfSNsSNixviY/sg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=kGV0L+/KnQNwueDBMZXeET0IfGjUwvWawy+o5cWbojI=;
 b=ku8hCZb934EI1qLAHOGdFTx/b/X2WP6Mn1cdsGC5Yxm6V6JaPoZ5aRAz2n/RE405LRy4xCUV9Eg8Jbtwwxb+3fQtfg5e0mUnqvlug5jzMmNKlEdO1WlX26fsf/8hWoZhEnnxXblw3vCKpGQt6m67HC5zq7zZWWXFK+9Set/480U=
Date: Tue, 15 Feb 2022 15:16:18 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Julien Grall <julien@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] rwlock: remove unneeded subtraction
Message-ID: <Ygu1si+HEiPB8vGz@Air-de-Roger>
References: <20220215093951.97830-1-roger.pau@citrix.com>
 <7710f137-7123-ca70-3a58-3dba1981b2c2@xen.org>
 <dfc3ab95-f2ca-bf03-98c1-5d77ebcdb048@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <dfc3ab95-f2ca-bf03-98c1-5d77ebcdb048@suse.com>
X-ClientProxiedBy: LO4P123CA0071.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:153::22) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 8c7707f4-b912-4660-7c79-08d9f08dbee5
X-MS-TrafficTypeDiagnostic: SJ0PR03MB5488:EE_
X-Microsoft-Antispam-PRVS: <SJ0PR03MB54880CE3AD9AB2D4E1CAF7118F349@SJ0PR03MB5488.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: TkrKiRACK6NRSt49WSX4Xr8byiCgpqD4cE991hkgjR7WogKYTpKjv1ersM2x2MCx0sYelpU+ahZCuyv6jpNrcB5fi/mvjP0jKGAEDqsOrePol6gYiyBJM6mNclyVRRUgNNZ1h5oeA2Nj/XFR8IyM4imlVBYk12LGJlSjm2PH1iveVX5yEoWWNFyzEnDouTCDBxeGMLTvkxvPShuS5Ti2LHftfJtD6H8u5bpN+NG7sCjFcUmP8iayKIfNItKRjq6wVX0GzjjSwazEURyYkyxm7mQtc2KyjgMGV9YkGxM8ByJd1zHcIPfnVvjxXaGXxi2xPQizF32Hpljyp/vePWCemRGZUDPkcEF3a8OCPzuPKCvNSmLWFYGN2M1MY5/42iRLNHkN5ANiOkfiJK8MavOKULHQRNfU2Nl9UR2NZ3a7YmI5QdZGzMKosEKI5qhRHvB45FqRBIsI3i13L4fMla7Jc+lzgqBZJcDhp1xL1aKSeICkm0SJFITnSDP9WkQPpzQ0ngdm3r4hOV6fNBlVZaedsbPFIqil1sXfC8EOxBw1sOxFQmSjUREr0MAUFBtI2ywMzGJMRXUv1I8cJdMxPDsl1BaELv0bDNG0xwQ5iTC7zLSrlOcoqV6GbxHjQUgksoFDS1VsWI3Wxpwc8ZnZsExNVfSgi8FPVCxsOrvWDaNq6StDcu+DZAfFf5odl+1WVTJ7PMwyn5ddmBTRioRpRBFfag==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(86362001)(82960400001)(4326008)(8676002)(6486002)(54906003)(8936002)(6916009)(85182001)(38100700002)(5660300002)(66556008)(316002)(6666004)(66946007)(66476007)(53546011)(83380400001)(6506007)(6512007)(2906002)(9686003)(508600001)(33716001)(26005)(186003)(67856001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?REVKdjZWNHVGZHRoYkt1dkZ2Y0dFOWNTYjlVZ2tlaTJwOWVVTlRkZkRUVEEr?=
 =?utf-8?B?QkRlRHRweGxIeTNjMmZkNG9UUEk0d3Q3Z1pxcVpWZ010SGZydEZ6MWoyUXM3?=
 =?utf-8?B?MjBFamdVcVZBVGJRWm9aOWpDd2NRZWs3ZWdkQlYweTJPWGk1bWFjQjE2TnF1?=
 =?utf-8?B?MGx2TFdubWhZTzE0aXQ4WjdsQjk1ak9mRy9lSUlyZWV4R2lTZ1c2TDJlOGxn?=
 =?utf-8?B?Q21FNWVPR3VYUG5zL1dYWk92emZXbmRyaS80WlZWOFdqU2dkdDBmbTVCTUVZ?=
 =?utf-8?B?RnpnZTNLTVRQWHlQOFF6Wi9jNTBNRUpBOXU0Vkltc01sbHRqbzJIcGkvVGg3?=
 =?utf-8?B?MFQwTUo1ZW5mb2lvTnZBYWFxVDRIaHpXbEx2N0gwVzVSWWZJNXlpR1l4aTVa?=
 =?utf-8?B?bjMzdjRzQzNITjZ1TC9NNHVDSUNhK2VTQjRKK1JaRWM0dHNzc1ZlNjNpRS9U?=
 =?utf-8?B?QmZ5WkZ5MjFkOTNoTk9aVGd2YklwdW5lWC9vRE53SGdnR2NOTmhveDlldTZj?=
 =?utf-8?B?ekFkNnF4QjViQURuUkhEUERHMWgxdEsvakFlZmZIWGszcSttdVZRcEpIVkZU?=
 =?utf-8?B?WTJTdTB4M0lqamt5Yk5XaE9mUVo2Vlg0MWs1c09BcytoNDVXV1lvbVVaZmxO?=
 =?utf-8?B?bi9mM2lxdVJMempnc2U4d1NtczcyNWpGZFBhTjUwcENuYzdGR1J0aEhFVDNS?=
 =?utf-8?B?OE5HSTNDekNIcldmYm5pRFpWVXBmLzlwYlBtLzFudWY3V1VVUWU5REszR2Vt?=
 =?utf-8?B?TDFTTkVGWTFXb2FXbXJ2QS9WTHdkeFZXUDdTQmswdXhiK2hKSVVCK2JBWDg4?=
 =?utf-8?B?V1hrZmZiVTNkV2duNlAzcjZmdUFMLzhyREI0Z0pxM1h1WHJQeVBydWZEMmZ4?=
 =?utf-8?B?b3BySlJ4Z1htNmt2RnVucmVXUUhIek56NitaZHl3VjgzdnpmVGl6MTQ5MUk5?=
 =?utf-8?B?eGE0MVErZVY1SUx1WUxwMnc2OVUvUXZDcEVXRGVKaW5aYzVWWnh0ZGc4YWZz?=
 =?utf-8?B?d1NxNlFwOHNsL2szSmJVeGdJb0VhOERBVGdqbHFHZWQvb3B4S2hCdkhkV05j?=
 =?utf-8?B?VXlZZjhBYUdwK0hpeVNDT1E3SG55djQzdi96NVlFanEwWnNnVWk5WnBwb0FF?=
 =?utf-8?B?WHM1YnAxanphK1pYbG5SaWVrbzFXUTFDR1A4QjJveEpXS2ZMMENCWVA2SXkx?=
 =?utf-8?B?WXhGbnE1R3dxdzFiNnZtRGxRMjg1YjNSaXRIOTlJYWVwbWJFbmEvcG0zbUNa?=
 =?utf-8?B?L1pieDNONGdlNTM2T09xQ042cXA0aDk3L05taG44WnkzVUpQZXcyQ3FZNUV0?=
 =?utf-8?B?Z1J3aTBWU2ZWRnUwN3VVUGtialg4NVNrL25nZVBmckk3TjVkaFUrSEdILzl3?=
 =?utf-8?B?YlU0cFV6aEdaRCtRV3ppdFFYK3I2Z2ozT0JGSHFyM29icXptU1Y4ek9WUWVH?=
 =?utf-8?B?QXVpMnpvZmNyQXBUNzNJSlhzaTlBT1d5NDhMMjd5ZHVvdmhFTlkwMDJIL28v?=
 =?utf-8?B?Z09MNGlXMXAyTVpRc1A2dTIvLytWTzE0N0wrT0JBbVR1V3k1dEw3RC9hcmJL?=
 =?utf-8?B?UVIyQS9yaUNaYmNxU3VwOGtMdDRUNWRwSG43NUdWVk8yaERlK0lDYlhlMVVk?=
 =?utf-8?B?dDRFMFFTMy9uemJLTjVqc2d5QTJXSmxGR09NM2NLUnNYaVpiaWRlQVh5ek5o?=
 =?utf-8?B?amZlUnNGMEdCcXVvM2U0Tkg4WXpXTlJoeHFZeXlsVHhrR0xLQzZWK010aTVX?=
 =?utf-8?B?cHlMTU1VZEhBYVJvams3dVdjT252dlFQM0lpUTN5SVkxYlkwcGMxR0QxaVJL?=
 =?utf-8?B?Unl3MExaVFNEMk02WXNyckVhUDQwVHV2Qm9kbURDWjA4RUIzcmYxWWpJY2pF?=
 =?utf-8?B?THBzYVRCcHZOdVR4bUdNQ1BGZTFvT3dMdFNBM3JKOUd5aVRsVGs1dlFsdjNm?=
 =?utf-8?B?OHlVUkkwNm5jRlRnMGZEajZuL1lJcmFsVnBCRDgxR21jWk9HUE9CWVVNVWht?=
 =?utf-8?B?S0I1VVZTYXJ0cytSaGQ5a1ErckFVOUhaQ0tKbXNCcThkMzdFWkVRTlhtUThj?=
 =?utf-8?B?MWwzRnNlQURJeDlJQTNjZEF0NTZhZ0xzSjB0aU56RTUzc21DUWlxT1U3eHZB?=
 =?utf-8?B?eVFSWHhjc1N1WXpteWtBRmRpQm8xcHp5QnRLaEFDaEJQK1kzWmJIT0dEWTFk?=
 =?utf-8?Q?O7BE4vcIykla3fIvwDQVjN0=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8c7707f4-b912-4660-7c79-08d9f08dbee5
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 14:16:23.5588
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sI/uZbO5mm4hgfOF6rTshnRM4JnCtBqibBnJzM3V/MEh08dBuUHeJDOk4P4lF6pztDC0zPdiBBtfdb1tppu25Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5488
X-OriginatorOrg: citrix.com

On Tue, Feb 15, 2022 at 02:22:02PM +0100, Jan Beulich wrote:
> On 15.02.2022 14:13, Julien Grall wrote:
> > On 15/02/2022 09:39, Roger Pau Monne wrote:
> >> There's no need to subtract _QR_BIAS from the lock value for storing
> >> in the local cnts variable in the read lock slow path: the users of
> >> the value in cnts only care about the writer-related bits and use a
> >> mask to get the value.
> >>
> >> Note that further setting of cnts in rspin_until_writer_unlock already
> >> do not subtract _QR_BIAS.
> > 
> > The rwlock is a copy of the Linux implementation. So I looked at the 
> > history to find out why _QR_BIAS was substracted.
> > 
> > It looks like this was done to get better assembly on x86:
> > 
> > commit f9852b74bec0117b888da39d070c323ea1cb7f4c
> > Author: Peter Zijlstra <peterz@infradead.org>
> > Date:   Mon Apr 18 01:27:03 2016 +0200
> > 
> >      locking/atomic, arch/qrwlock: Employ atomic_fetch_add_acquire()
> > 
> >      The only reason for the current code is to make GCC emit only the
> >      "LOCK XADD" instruction on x86 (and not do a pointless extra ADD on
> >      the result), do so nicer.
> > 
> >      Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> >      Acked-by: Waiman Long <waiman.long@hpe.com>
> >      Cc: Andrew Morton <akpm@linux-foundation.org>
> >      Cc: Linus Torvalds <torvalds@linux-foundation.org>
> >      Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> >      Cc: Peter Zijlstra <peterz@infradead.org>
> >      Cc: Thomas Gleixner <tglx@linutronix.de>
> >      Cc: linux-arch@vger.kernel.org
> >      Cc: linux-kernel@vger.kernel.org
> >      Signed-off-by: Ingo Molnar <mingo@kernel.org>
> > 
> > diff --git a/kernel/locking/qrwlock.c b/kernel/locking/qrwlock.c
> > index fec082338668..19248ddf37ce 100644
> > --- a/kernel/locking/qrwlock.c
> > +++ b/kernel/locking/qrwlock.c
> > @@ -93,7 +93,7 @@ void queued_read_lock_slowpath(struct qrwlock *lock, 
> > u32 cnts)
> >           * that accesses can't leak upwards out of our subsequent critical
> >           * section in the case that the lock is currently held for write.
> >           */
> > -       cnts = atomic_add_return_acquire(_QR_BIAS, &lock->cnts) - _QR_BIAS;
> > +       cnts = atomic_fetch_add_acquire(_QR_BIAS, &lock->cnts);
> >          rspin_until_writer_unlock(lock, cnts);
> > 
> >          /*
> > 
> > This is a slowpath, so probably not a concern. But I thought I would 
> > double check whether the x86 folks are still happy to proceed with that 
> > in mind.
> 
> Hmm, that's an interesting observation. Roger - did you inspect the
> generated code? At the very least the description may want amending.

It seems to always generate the same code for me when using gcc 8.3,
I even tried using arch_fetch_and_add directly, it always results
in:

ffff82d04022d983:       f0 0f c1 03             lock xadd %eax,(%rbx)
ffff82d04022d987:       25 00 30 00 00          and    $0x3000,%eax

Similarly clang 13.0.0 seem to always generate:

ffff82d0402085de:       f0 0f c1 03             lock xadd %eax,(%rbx)
ffff82d0402085e2:       89 c1                   mov    %eax,%ecx
ffff82d0402085e4:       81 e1 00 30 00 00       and    $0x3000,%ecx

Maybe I'm missing something, but I don't see a difference in the
generated code.

I could add to the commit message:

"Originally _QR_BIAS was subtracted from the result of
atomic_add_return_acquire in order to prevent GCC from emitting an
unneeded ADD instruction. This being in the lock slow path such
optimizations don't seem likely to make any relevant performance
difference. Also modern GCC and CLANG versions will already avoid
emitting the ADD instruction."

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Feb 15 14:31:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 14:31:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273226.468332 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJyrE-0006xp-3T; Tue, 15 Feb 2022 14:31:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273226.468332; Tue, 15 Feb 2022 14:31:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJyrE-0006xi-0T; Tue, 15 Feb 2022 14:31:08 +0000
Received: by outflank-mailman (input) for mailman id 273226;
 Tue, 15 Feb 2022 14:31:06 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJyrC-0006xY-Lt; Tue, 15 Feb 2022 14:31:06 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJyrC-0002s9-Ie; Tue, 15 Feb 2022 14:31:06 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nJyrC-0003Er-48; Tue, 15 Feb 2022 14:31:06 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nJyrC-0004bX-3i; Tue, 15 Feb 2022 14:31:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=rUfSumyk9VNRqrPIjmLPgAp2aQbR0VApC10LWXqZJRM=; b=N285caHa/DfcZPWsVMBsA0yIdw
	e0EZLqLj/g4IqOBfiAAtNWsy90IiwxrQmjjiqB1HhhlWQLSFQVt8hz77GtQckVaJMwwBvBNCvxKWb
	1ogBbPKZCEk1MgsDiu/tJQTowG6YqBI56kmYfjYuqOAL2rCKE6H4esGUA62ZDvxMKLm4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168117-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 168117: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=f92362003104d72ac3545fac34d7d2972449a2c1
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 15 Feb 2022 14:31:06 +0000

flight 168117 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168117/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              f92362003104d72ac3545fac34d7d2972449a2c1
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  585 days
Failing since        151818  2020-07-11 04:18:52 Z  584 days  566 attempts
Testing same since   168117  2022-02-15 04:19:00 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brad Laue <brad@brad-x.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Christophe Fergeau <cfergeau@redhat.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Divya Garg <divya.garg@nutanix.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Emilio Herrera <ehespinosa57@gmail.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Ivan Teterevkov <ivan.teterevkov@nutanix.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jing Qi <jinqi@redhat.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Lubomir Rintel <lkundrak@v3.sk>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nicolas Lécureuil <neoclust@mageia.org>
  Nicolas Lécureuil <nicolas.lecureuil@siveo.net>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Rohit Kumar <rohit.kumar3@nutanix.com>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  shenjiatong <yshxxsjt715@gmail.com>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tu Qiang <tu.qiang35@zte.com.cn>
  Tuguoyi <tu.guoyi@h3c.com>
  tuqiang <tu.qiang35@zte.com.cn>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Vineeth Pillai <viremana@linux.microsoft.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yasuhiko Kamata <belphegor@belbel.or.jp>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 97929 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Feb 15 14:33:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 14:33:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273239.468343 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJyt6-0007ca-L8; Tue, 15 Feb 2022 14:33:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273239.468343; Tue, 15 Feb 2022 14:33:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJyt6-0007cT-HN; Tue, 15 Feb 2022 14:33:04 +0000
Received: by outflank-mailman (input) for mailman id 273239;
 Tue, 15 Feb 2022 14:33:02 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ZAEc=S6=linaro.org=vincent.guittot@srs-se1.protection.inumbo.net>)
 id 1nJyt4-0007cJ-CS
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 14:33:02 +0000
Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com
 [2a00:1450:4864:20::234])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2d54d249-8e6c-11ec-8eb8-a37418f5ba1a;
 Tue, 15 Feb 2022 15:33:01 +0100 (CET)
Received: by mail-lj1-x234.google.com with SMTP id r20so1420966ljj.1
 for <xen-devel@lists.xenproject.org>; Tue, 15 Feb 2022 06:33:01 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2d54d249-8e6c-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc:content-transfer-encoding;
        bh=HrHSQ3nTYehA0h9uNSx7m9elOEWCoHpUSrruiXVY27g=;
        b=LM2yFePKdmzF7JQFBE06YEaKWxWcHBD740QCyI2TlM2aPr4Ox+6JjZUrlqCq4o20rS
         SMIAEx8BUqLs3RQEGE64DD2YxpEai8q89XbPFJGBI2BzqSGkgYpSzw+OuRiBEsNFnSlo
         wrkdEYvgO1P/FbrEbT7jzaro6JLXCTq5PO0Y4IZvdXc6ekadgkTq4z1jBKFAFXVkfQds
         B++nRCrMqNYBbrqq2Hz+GoGQXy0S5Bet+3Ya5S+iKvy0dBaYpeAEs0d7TNg77FXMTVE9
         f2Wyl/Ns30pkd0FK+F3SxeKDwmEwrlFesCBVnZfvTu4V0MxFqXlwLSk7QSTWmzDzplii
         e8EQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc:content-transfer-encoding;
        bh=HrHSQ3nTYehA0h9uNSx7m9elOEWCoHpUSrruiXVY27g=;
        b=a9Juvx6FoFabAKKdptiK9FcYmcPLTBB1F8m+IuH+dpIA0f4MJ4RMgqDioyweL2PdcU
         JtgIyHv4neYOcxRneD/USMYGT7N2im1AOmakHj6qPNlFwD4xW4fCoiRO9ErNpSHyMKmJ
         2e9ZN7TydDbVEcDyU8ayE9jNcg9gJ6kdDsWxrsSEiNStrHETOFycBxt2cebfL2sJUB3y
         6PnMk4FZ9ZeElM649xiV99FhY/vGiHCO9BAZmq1O/hGeznwOm8Yi+4xXrbg/+NRFFVms
         652mVy7j2zKgkfnlU1ZQZZu6MaXISmYuwtPynFqvOjXQcM65dB0ZT4+YAxwMWNJqJdTN
         ISbg==
X-Gm-Message-State: AOAM531py0ivphXd/TGEkJG1e6js/FsTgx3pZsI1PAzfW+Ddx/PFXRmT
	op4uC0ON0Ish35GnFRkolphGcWdR5533OMDgMqo/CQ==
X-Google-Smtp-Source: ABdhPJxIJIf+iUPRUnKiaWp7NYCsg3V9hISC8jr8evbeUYGek/drbWuaaTfez4YjoAzWOLKPjRy6n2jWFR+qxjU7ewk=
X-Received: by 2002:a2e:6e0c:: with SMTP id j12mr625564ljc.92.1644935580518;
 Tue, 15 Feb 2022 06:33:00 -0800 (PST)
MIME-Version: 1.0
References: <87h79bgd1m.fsf@linaro.org> <alpine.DEB.2.22.394.2202071419270.2091381@ubuntu-linux-20-04-desktop>
In-Reply-To: <alpine.DEB.2.22.394.2202071419270.2091381@ubuntu-linux-20-04-desktop>
From: Vincent Guittot <vincent.guittot@linaro.org>
Date: Tue, 15 Feb 2022 15:32:48 +0100
Message-ID: <CAKfTPtB1ONsxA1Rch8AO+UrPRZsHrCgF1_-F-kh9U_Xu2M47aA@mail.gmail.com>
Subject: Re: Metadata and signalling channels for Zephyr virtio-backends on Xen
To: Stefano Stabellini <stefano.stabellini@xilinx.com>
Cc: =?UTF-8?B?QWxleCBCZW5uw6ll?= <alex.bennee@linaro.org>, 
	stratos-dev@op-lists.linaro.org, xen-devel@lists.xenproject.org, 
	AKASHI Takahiro <takahiro.akashi@linaro.org>, Arnd Bergmann <arnd.bergmann@linaro.org>, 
	Christopher Clark <christopher.w.clark@gmail.com>, Dmytro Firsov <dmytro_firsov@epam.com>, 
	Julien Grall <julien@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
	Oleksandr_Tyshchenko@epam.com, Artem_Mygaiev@epam.com, 
	bertrand.marquis@arm.com, Wei.Chen@arm.com, Ed.Doxat@arm.com, 
	Oleksii_Moisieiev@epam.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Stefano,

On Tue, 8 Feb 2022 at 01:16, Stefano Stabellini
<stefano.stabellini@xilinx.com> wrote:
>
> On Mon, 7 Feb 2022, Alex Benn=C3=A9e wrote:
> > Hi Stefano,
> >
> > Vincent gave an update on his virtio-scmi work at the last Stratos sync
> > call and the discussion moved onto next steps.
>
> Hi Alex,
>
> I don't know the specifics of virtio-scmi, but if it is about power,
> clocks, reset, etc. like the original SCMI protocol, then virtio-scmi is

virtio-scmi is one transport channel that support SCMI protocol

> likely going to be very different from all the other virtio frontends

The virtio-scmi front-end is merged mainline

> and backends. That's because SCMI requires a full view of the system,
> which is different from something like virtio-net that is limited to the
> emulation of 1 device. For this reason, it is likely that the
> virtio-scmi backend would be a better fit in Xen itself, rather than run
> in userspace inside a VM.

Not sure what you mean when you say that SCMI requires a full view of
the system. If you are referring to the system wide resources which
reset or power up/down the whole SoC, this is not really what we are
targeting here. Those system wide resources should already be handled
by a dedicated power coprocessor. In our case, the IPs of the SoC will
be handled by different VMs but those IPs are usually sharing common
resources like a parent PLL , a power domain or a clock gating reg as
few examples. Because all those VMs can't directly set these resources
without taking into account others and because the power coprocessor
doesn't have an unlimited number of channels, we add an SCMI backend
that will gather and proxy the VM request before accessing the
register that gates some clocks IP as an example or before powering
down an external regulator shared between the camera and another
device. This SCMI backend will most probably also send request with
OSPM permission access to the power coprocessor once aggregating all
the VMs ' request
We are using virtio-cmi protocol because it has the main advantage of
not being tied to an hypervisor

In our PoC, the SCMI backend is running with zehyr and reuse the same
software that can run in the power coprocessor which helps splitting
what is critical and must be handled by power coprocessor and what is
not critical for the system (what is usually managed by linux directly
when their no hypervisor involved typically)

>
> FYI, a good and promising approach to handle both SCMI and SCPI is the
> series recently submitted by EPAM to mediate SCMI and SCPI requests in
> Xen: https://marc.info/?l=3Dxen-devel&m=3D163947444032590
>
> (Another "special" virtio backend is virtio-iommu for similar reasons:
> the guest p2m address mappings and also the IOMMU drivers are in Xen.
> It is not immediately clear whether a virtio-iommu backend would need to
> be in Xen or run as a process in dom0/domU.)
>
> On the other hand, for all the other "normal" protocols (e.g.
> virtio-net, virtio-block, etc.) the backend would naturally run as a
> process in dom0 or domU (e.g. QEMU in Dom0) as one would expect.
>
>
> > Currently the demo setup
> > is intermediated by a double-ended vhost-user daemon running on the
> > devbox acting as a go between a number of QEMU instances representing
> > the front and back-ends. You can view the architecture with Vincents
> > diagram here:
> >
> >   https://docs.google.com/drawings/d/1YSuJUSjEdTi2oEUq4oG4A9pBKSEJTAp6h=
hcHKKhmYHs/edit?usp=3Dsharing
> >
> > The key virtq handling is done over the special carve outs of shared
> > memory between the front end and guest. However the signalling is
> > currently over a virtio device on the backend. This is useful for the
> > PoC but obviously in a real system we don't have a hidden POSIX system
> > acting as a go between not to mention the additional latency it causes
> > with all those context switches.
> >
> > I was hoping we could get some more of the Xen experts to the next
> > Stratos sync (17th Feb) to go over approaches for a properly hosted on
> > Xen approach. From my recollection (Vincent please correct me if I'm
> > wrong) of last week the issues that need solving are:
>
> Unfortunately I have a regular conflict which prevents me from being
> able to join the Stratos calls. However, I can certainly make myself
> available for one call (unless something unexpected comes up).
>
>
> >  * How to handle configuration steps as FE guests come up
> >
> > The SCMI server will be a long running persistent backend because it is
> > managing real HW resources. However the guests may be ephemeral (or jus=
t
> > restarted) so we can't just hard-code everything in a DTB. While the
> > virtio-negotiation in the config space covers most things we still need
> > information like where in the guests address space the shared memory
> > lives and at what offset into that the queues are created. As far as I'=
m
> > aware the canonical source of domain information is XenStore
> > (https://wiki.xenproject.org/wiki/XenStore) but this relies on a Dom0
> > type approach. Is there an alternative for dom0less systems or do we
> > need a dom0-light approach, for example using STR-21 (Ensure Zephyr can
> > run cleanly as a Dom0 guest) providing just enough services for FE's to
> > register metadata and BE's to read it?
>
> I'll try to answer the question for a generic virtio frontend and
> backend instead (not SCMI because SCMI is unique due to the reasons
> above.)
>
> Yes, xenstore is the easiest way to exchange configuration information
> between domains. I think EPAM used xenstore to exchange the
> configuration information in their virtio-block demo. There is a way to
> use xenstore even between dom0less VMs:
> https://marc.info/?l=3Dxen-devel&m=3D164340547602391 Not just xenstore bu=
t
> full PV drivers too. However, in the dom0less case xenstore is going to
> become available some time after boot, not immediately at startup time.
> That's because you need to wait until xenstored is up and running.
>
> There are other ways to send data from one VM to another which are
> available immediately at boot, such as Argo and static shared memory.
>
> But dom0less is all about static partitioning, so it makes sense to
> exploit the build-time tools to the fullest. In the dom0less case, we
> already know what is going to run on the target before it is even turned
> on. As an example, we might have already prepared an environment with 3
> VMs using Yocto and ImageBuilder. We could also generate all
> configurations needed and place them inside each VMs using Yocto's
> standard tools and ImageBuilder. So for dom0less, I recommend to go via
> a different route and pre-generate the configuration directly where
> needed instead of doing dynamic discovery.
>
>
> >  * How to handle mapping of memory
> >
> > AIUI the Xen model is the FE guest explicitly makes grant table request=
s
> > to expose portions of it's memory to other domains. Can the BE query th=
e
> > hypervisor itself to discover the available grants or does it require
> > coordination with Dom0/XenStore for that information to be available to
> > the BE domain?
>
> Typically the frontend passes grant table references to the backend
> (i.e. instead of plain guest physical addresses on the virtio ring.)
> Then, the backend maps the grants; Xen checks that the mapping is
> allowed.
>
> We might be able to use the same model with virtio devices. A special
> pseudo-IOMMU driver in Linux would return a grant table reference and an
> offset as "DMA address". The "DMA address" is passed to the virtio
> backend over the virtio ring. The backend would map the grant table
> reference using the regular grant table hypercalls.
>
>
> >  * How to handle signalling
> >
> > I guess this requires a minimal implementation of the IOREQ calls for
> > Zephyr so we can register the handler in the backend? Does the IOREQ AP=
I
> > allow for a IPI style notifications using the global GIC IRQs?
> >
> > Forgive the incomplete notes from the Stratos sync, I was trying to typ=
e
> > while participating in the discussion so hopefully this email captures
> > what was missed:
> >
> >   https://linaro.atlassian.net/wiki/spaces/STR/pages/28682518685/2022-0=
2-03+Project+Stratos+Sync+Meeting+Notes
>
> Yes, any emulation backend (including virtio backends) would require an
> IOREQ implementation, which includes notifications via event channels.
> Event channels are delivered as a GIC PPI interrupt to the Linux kernel.
> Then, the kernel sends the notification to userspace via a file
> descriptor.


From xen-devel-bounces@lists.xenproject.org Tue Feb 15 14:41:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 14:41:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273246.468354 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJz1H-0000ew-Gq; Tue, 15 Feb 2022 14:41:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273246.468354; Tue, 15 Feb 2022 14:41:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJz1H-0000ep-Dm; Tue, 15 Feb 2022 14:41:31 +0000
Received: by outflank-mailman (input) for mailman id 273246;
 Tue, 15 Feb 2022 14:41:30 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=AO6W=S6=gmail.com=jandryuk@srs-se1.protection.inumbo.net>)
 id 1nJz1G-0000ej-RR
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 14:41:30 +0000
Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com
 [2a00:1450:4864:20::229])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5c916c0e-8e6d-11ec-b215-9bbe72dcb22c;
 Tue, 15 Feb 2022 15:41:29 +0100 (CET)
Received: by mail-lj1-x229.google.com with SMTP id o9so22174829ljq.4
 for <xen-devel@lists.xenproject.org>; Tue, 15 Feb 2022 06:41:29 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5c916c0e-8e6d-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=U0jlo6Lko7wheVsvJwCSUaiFQq9FjjfJB4EYUap77RY=;
        b=mhTlTTwZHYhzkn023LIo3DeW87VfXC7hFgQnWT/QrVP4+JgaQm2z0KgTJeyXnMGfK2
         zFv7ywV+ZuoClKZoQHIE9YVf9NebTJzkdA9IuszZuI9+dRA/tsnlUQGregyHV30b3oF8
         Qyi3Qw1j08SoeNFGO7kJILf5/Zd3mNk9NCfWcWDx3BZ4reMnTPp2vOVeV9t3xY1FBtf2
         /MJmRgKSxTGMt1/ixpFaI7cJ3O9nRwRdbDTBvQXq5U3yaRG9sn0nfWbHFLQejsyAR1tt
         84iPqWut+Bowk72HJl3XaOFrxPfKTh2SJ/LdpOKsWp7JQec4NRTTXSmsvwcMt2qCH9i4
         koyg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=U0jlo6Lko7wheVsvJwCSUaiFQq9FjjfJB4EYUap77RY=;
        b=Ps7mTJ99HvC7kBpThsRsPL4BaJVjUYHNIY3Qo/c+JiIKLmJaIdtLGo9YZ7oKKu8Cdc
         RnWGBGsXJ0JzlypV1WLVzBWgOhNflBcu5j/c0L+/G7NLtGyMz0q5KQYdvGzSjtnQcVZQ
         q1NPnyBF0M9zQlJUqFFDZQmsQAyWUX2C2/Q6Ji5CI+u/JQ7N4yOmvApVAs7IB7nlaRmJ
         LgkMesPSOdwPK7hYhEofyzTp6WG5cSANhVWHuHkbb1v7Do0PT6HZccuG/ZUIXiHwR2se
         Hvj7oQfzUCrsa7YAbxz0PfwMEVdBWOycBfHAk+pMLkAP7RCCUdr/XbinPcoiP/cGGjg4
         ABFA==
X-Gm-Message-State: AOAM531W+ofA2i7JXSF/pYfzHSrvczU3skRTNADdpbkxhxahmztry2U0
	a3qmk7MMikdHILVNj6c6inXr51H6BmtA1lgfx64=
X-Google-Smtp-Source: ABdhPJwWfwRt5iAF0XIxi/vqtn/flxGS2i1UTUG69/NGurYf2AqeYSsqen0vhT8/Qp0MgqKgoCWkItVSD/0Nx7DVudY=
X-Received: by 2002:a2e:9995:: with SMTP id w21mr2687010lji.168.1644936089289;
 Tue, 15 Feb 2022 06:41:29 -0800 (PST)
MIME-Version: 1.0
References: <20211210123519.595163-1-andr2000@gmail.com>
In-Reply-To: <20211210123519.595163-1-andr2000@gmail.com>
From: Jason Andryuk <jandryuk@gmail.com>
Date: Tue, 15 Feb 2022 09:41:17 -0500
Message-ID: <CAKf6xpu76umJXWJm2FyG2ST6fm0_iU7RSGGQkTt7_uG_HLi-iw@mail.gmail.com>
Subject: Re: [PATCH] tools: remove xenstore entries on vchan server closure
To: Oleksandr Andrushchenko <andr2000@gmail.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>, 
	Juergen Gross <jgross@suse.com>, Anthony PERARD <anthony.perard@citrix.com>, 
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Content-Type: text/plain; charset="UTF-8"

On Fri, Dec 10, 2021 at 7:35 AM Oleksandr Andrushchenko
<andr2000@gmail.com> wrote:
>
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>
> vchan server creates XenStore entries to advertise its event channel and
> ring, but those are not removed after the server quits.
> Add additional cleanup step, so those are removed, so clients do not try
> to connect to a non-existing server.
>
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> ---
>  tools/include/libxenvchan.h |  5 +++++
>  tools/libs/vchan/init.c     | 23 +++++++++++++++++++++++
>  tools/libs/vchan/io.c       |  4 ++++
>  tools/libs/vchan/vchan.h    | 31 +++++++++++++++++++++++++++++++
>  4 files changed, 63 insertions(+)
>  create mode 100644 tools/libs/vchan/vchan.h
>
> diff --git a/tools/include/libxenvchan.h b/tools/include/libxenvchan.h
> index d6010b145df2..30cc73cf97e3 100644
> --- a/tools/include/libxenvchan.h
> +++ b/tools/include/libxenvchan.h
> @@ -86,6 +86,11 @@ struct libxenvchan {
>         int blocking:1;
>         /* communication rings */
>         struct libxenvchan_ring read, write;
> +       /**
> +        * Base xenstore path for storing ring/event data used by the server
> +        * during cleanup.
> +        * */
> +       char *xs_path;
>  };
>
>  /**
> diff --git a/tools/libs/vchan/init.c b/tools/libs/vchan/init.c
> index c8510e6ce98a..c6b8674ef541 100644
> --- a/tools/libs/vchan/init.c
> +++ b/tools/libs/vchan/init.c
> @@ -46,6 +46,8 @@
>  #include <xen/sys/gntdev.h>
>  #include <libxenvchan.h>
>
> +#include "vchan.h"
> +
>  #ifndef PAGE_SHIFT
>  #define PAGE_SHIFT 12
>  #endif
> @@ -251,6 +253,10 @@ static int init_xs_srv(struct libxenvchan *ctrl, int domain, const char* xs_base
>         char ref[16];
>         char* domid_str = NULL;
>         xs_transaction_t xs_trans = XBT_NULL;
> +
> +       // store the base path so we can clean up on server closure
> +       ctrl->xs_path = strdup(xs_base);

You don't check for NULL here, but you do check for NULL in
close_xs_srv().  I guess it's okay, since it does the right thing.
But I think it would be more robust to check for NULL here.  Is there
a specific reason you wrote it this way?  Otherwise it looks good.

Regards,
Jason


From xen-devel-bounces@lists.xenproject.org Tue Feb 15 14:45:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 14:45:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273252.468365 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJz4m-0001Hq-1m; Tue, 15 Feb 2022 14:45:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273252.468365; Tue, 15 Feb 2022 14:45:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJz4l-0001Hj-UG; Tue, 15 Feb 2022 14:45:07 +0000
Received: by outflank-mailman (input) for mailman id 273252;
 Tue, 15 Feb 2022 14:45:06 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=p95L=S6=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nJz4k-0001Hd-Db
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 14:45:06 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id dcd38707-8e6d-11ec-8eb8-a37418f5ba1a;
 Tue, 15 Feb 2022 15:45:05 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2169.outbound.protection.outlook.com [104.47.17.169]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-20-4-8sQTT5M06q73_z77qm5A-1; Tue, 15 Feb 2022 15:45:03 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM0PR04MB4196.eurprd04.prod.outlook.com (2603:10a6:208:56::28)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Tue, 15 Feb
 2022 14:45:02 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4975.015; Tue, 15 Feb 2022
 14:45:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dcd38707-8e6d-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644936304;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=mvcwRS/2kTL6JKXjdjAteMCyvoPmIncNGSvsR1a29Tg=;
	b=I9DuZtK3J861NoNc8tmudDE1yMuMqpu9f6+EcNmK6zMZmaoBpZU0FVBhHo3XpEoVlDDyqh
	+QrTo7PWNJpU2QxeqPygqN1f2m4/Cpnu/V4tczwTrZ56FCiI/zyqQ145DdoGx0iUdhoNlj
	eoQYIT2Kn5J1bjGBsq+OgRtmtbJhj5k=
X-MC-Unique: 4-8sQTT5M06q73_z77qm5A-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=HGPa7WUX3UeWjpE1W0/XisSSiUlFYCmd52G9D986Ij4m//qSAyrYMHob+nD8l61M8LGx9USj5Rs3ZxTRFpFlywER++ZO1eTZMkIO11xxUycO+AZERU8fp7PDgNYob9C6Q2c/0VvixpTrUV9rYqV/2oTR95boWKdYut1t0II+YToOuC2ctDEZkanZt5TgVq6eXidJ9PqJo4zKd49AK4T18eMwqRC3RElEjrzXGcE6WX67hvsyrhJoUi9QF9Xq6p/ANkxLAut0MWvGLQzI57CEhaoFHaLvujHIux3QJUnh9Yd0g2/0xeWzYMwJiKohQRto3D/1ArKpkbYG+OkoSJcycA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=/YUQRnu7FAeGZcxpUphTiHuUlTf3kZQccc3Fm3/StxY=;
 b=GkMXJcLpzucr/C4ptqEFF66MyDAwvliFeEiijxP1wP56q0AVdSd2Dd8scLqWWoGiSeR2Sg3w3Nbtzm00BY/VGdE7fQqC9Se7K0QkN1/Z5vlpvLhJDqYqFL6e6bzIrA+4bK0Oy7+JeiTDZ1i5mdOR3gKlgestOy4FMcvfauNdji6uosqTmDx3+9pmIsHDFo3KcZwSB2x6iUHjXkxfvszluNVHtFj9njqtkNdM72JJvcb3eh/hGrKL/UeyAys4NFoONUl4yjSKBW9fifxFU6Zlpl4MQb6l05QqiF7rBGHeER8dP6lh3yQAKfvC6gj9wbbFw7KtIKlttJaaE6RNiHV4OQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <493bf9e6-7f75-7f90-0c5b-a4a3e30cfb34@suse.com>
Date: Tue, 15 Feb 2022 15:45:00 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH] rwlock: remove unneeded subtraction
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: Julien Grall <julien@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220215093951.97830-1-roger.pau@citrix.com>
 <7710f137-7123-ca70-3a58-3dba1981b2c2@xen.org>
 <dfc3ab95-f2ca-bf03-98c1-5d77ebcdb048@suse.com>
 <Ygu1si+HEiPB8vGz@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Ygu1si+HEiPB8vGz@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0245.eurprd06.prod.outlook.com
 (2603:10a6:20b:45f::13) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 0109170b-5cdf-4f61-6891-08d9f091bf35
X-MS-TrafficTypeDiagnostic: AM0PR04MB4196:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB41967DA82362F3AD912F68F8B3349@AM0PR04MB4196.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	2bfBQl0zkapymzKZnJDAKiC/8kpn3xnju0FYMOmJOjNMmfp7C2ovf/8A3SpUM2dvIVlHtkq6GF87C/7HfLxefiwLl4AvjKx+Uf9gyVCKNxnsamcz2bdx9w49/qV6uykFJ5ep52FzjELuUbCsF26vPeclrE3W9H7EZfu30ajoLzneAPZATawtJA84ElF4Pikb1NVC5gMQ6KpxtFzVLWul0JmFfIw2hV41dw+nbuF0Pd0RUCedJt29QLzGfp6M/4UzVpPos48YxmU45XQBU9ZwNm4SykNdILVDoZv0QDFj4Zs3A2jlJuLXeXwMC60dgQy/lfh60kcXY3BO4hoxVQ0MDli/7gR4JtqP+X/xpFs4ln4bOxCPmz8kgOuOC09KXTfCZBZlk4mo/esLI8RydixynxfgDrmRmCI5b512D8/SCq5G9TCvMjsDCTT0QzETJtjwILsoUJGd0QfbHJ3iPPZcRlCRIiQZmlJPe+/Ss71jfEqmkpgqJxTJ19ZjdDff2GDYICR+RFmNBrY5oEXb8Y+ErGsw7ycppgO3982GXKSVG4ro0nBeRNSt2r/sV9LiSYqBJrZv90XyKk6JPoIOgJjiaHy5wpBbajiud27mSKcyPH0yJoUrLFoNnjEeHoL2mkRYZaNJ4HxwKXZsk3gwp1M7x/RdzoUxJijt2tz8RAUR31t37xKf6l0TDIYO4y1tzXLd0x20CFRdl0VyKdrhxRxUmIHXgtpvqsgAIcnJiWvPUo0=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(36756003)(6506007)(6916009)(316002)(6486002)(6512007)(53546011)(508600001)(54906003)(38100700002)(86362001)(66556008)(8676002)(31686004)(83380400001)(5660300002)(4326008)(66476007)(8936002)(66946007)(2616005)(26005)(31696002)(186003)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?lHzAu49IQa+vE6+56LdKdYIqK/0qWJDqRSK05gcBjQ/gmXZd/8u/IVycxpBf?=
 =?us-ascii?Q?gqeNf5M5R4MWEDGp7UZS0K/QD6IKe+47ZaME72NjzWv570wT0ORXUFtRvWRK?=
 =?us-ascii?Q?JVCSiBin1vXaZG0tBx1sMZsbv2nwl8s9SJuxY6sdos3Ww4W2rlFGMxvBUu74?=
 =?us-ascii?Q?a1mupa8E7CHE/7azXF0WkPJQmiqh4+5S+xF5REGFwaZIIhMRpRHmHBbJF9Wc?=
 =?us-ascii?Q?bR7yNSLKqlGupCmcz/orHHHdJ6grRCBE8MzKr6udNKj5bLD6M3oF1iIxL8J4?=
 =?us-ascii?Q?r6E06qnEEobaFSviagOlhnjn4UbIMr5LoJdUdP4DhYUWSfFSSzDP4GZnr3Lr?=
 =?us-ascii?Q?DT/sI2Nzw4tCJMgd4K2PB7YFxCImYckLVZYkUlPvi68nUKcaJwWjSCPAksjx?=
 =?us-ascii?Q?rpxl2aHLiBU8PLhVrWddaQquHrYkOjHmlesxLhPsSVYctAelke/ejeU5ruE7?=
 =?us-ascii?Q?xI89Qh+HYPRlKyHv7D5ax3GOFSo8l9M6coKdA/BXGjssAQ5IyqWREGKxT5Zl?=
 =?us-ascii?Q?xMwC8uJ/bZXH4M6uhFqXKyLjIdYJeQ81MlKE2vwQATZiX630wWW/QDv9h6y3?=
 =?us-ascii?Q?Sk/G5zGP0F+tXfkHUQbf7FwAlnby97TIeslWlvLxQTyI2BMMfSB4MRaeJDSF?=
 =?us-ascii?Q?9+utK1MHiC8CfFOXP5ruRsp0esUSb2mfV/vn3QSLMIsdYlMmyo97BGn9aw9x?=
 =?us-ascii?Q?Bmw0XsSSKAn2Adn+dvSH52+5BpkuBH6KMLcZlhgu1uJ5G7GgceEaHNdRwhrh?=
 =?us-ascii?Q?pYX6INy5KzCn7IXrSjK8fTOZuD/bvbmIDOn9Ie9F3UfBy0lxDor4r1bji5Or?=
 =?us-ascii?Q?P3fw4qH5q2ncWGcDHW49wmkrwX5JzAKJ2X9Dr7MwVE5P2Amoh4xI++9u92WS?=
 =?us-ascii?Q?1QqGiHT+v3pY00LuWjDkA2bGfJc8LQxwOKvAPpN6w/BcWadtm2IdoIUE3isa?=
 =?us-ascii?Q?Rv8gCbMtk1u3TGxwll76Ym8sI8ziR9hR1M0WP1eFmB+h4kCifwr1NK4cikev?=
 =?us-ascii?Q?2tWkNUN+PXwPJn5xeVijtuxgqxAd40maOnHKL0/yzWcLwXyY0Tkk4B70SQzV?=
 =?us-ascii?Q?EFQfrJZ1pLixFJsDTkDiH0NA8+4CX4c8Q5sP3MZ/wOXw9Z2wNbV88JtEbGrJ?=
 =?us-ascii?Q?AH4GZUII5Y2rDY17TTsr7rFESgwB5Zf0wtIdW8YbRXtQDcGmWltM5Mf/3Q3e?=
 =?us-ascii?Q?JxFL+2z+gBX7JpzDgViXXqTjWozoJg5/iQV3/rFTFsWF/SqFJzqBH9yvugZ6?=
 =?us-ascii?Q?Cm6VN2+qz77oUEn/bvXp8KgQweabM2CfJrISVluQRp1wEWPxgzkbrZngDAKx?=
 =?us-ascii?Q?60NIELCgbvfP6gSNEJZt3lTQqcS8PLueUuZHRyed/dKFOp/xET2xwsavv94d?=
 =?us-ascii?Q?IN4HXHwWjA+GCJJgY7HFC6R9Hkd86hFOb5ZKJPC+naKd/s9vsijEzlZ6Med1?=
 =?us-ascii?Q?Iv8lM2ztW/gHJdv64ONj1qwHjLibY4Cs7LfaECYY7rX7/gQIj4xXF48UjEPP?=
 =?us-ascii?Q?MRJKSnqEdthWfgU6NwzPFX4SkNrA15xumGAuGonXtLdAs8T/UMI53QV8LIvT?=
 =?us-ascii?Q?zvgeDxJ0kTu7Hg8Ye/xFbeEqo+WAqZ55J9Pq0DHrUOVznG48Wcgt/OZX42ac?=
 =?us-ascii?Q?D/zQVRgTogPvOMZsNLci2ko=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0109170b-5cdf-4f61-6891-08d9f091bf35
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 14:45:02.0070
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7RlWh6eoAYtrStKqDoJpUsmCd9cb3d+1AejXlEaY1KaVJ/ZIq5jDVeWECypTKkTtgTPlH37UaGiTrD2IGRQcQQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4196

On 15.02.2022 15:16, Roger Pau Monn=C3=A9 wrote:
> On Tue, Feb 15, 2022 at 02:22:02PM +0100, Jan Beulich wrote:
>> On 15.02.2022 14:13, Julien Grall wrote:
>>> On 15/02/2022 09:39, Roger Pau Monne wrote:
>>>> There's no need to subtract _QR_BIAS from the lock value for storing
>>>> in the local cnts variable in the read lock slow path: the users of
>>>> the value in cnts only care about the writer-related bits and use a
>>>> mask to get the value.
>>>>
>>>> Note that further setting of cnts in rspin_until_writer_unlock already
>>>> do not subtract _QR_BIAS.
>>>
>>> The rwlock is a copy of the Linux implementation. So I looked at the=20
>>> history to find out why _QR_BIAS was substracted.
>>>
>>> It looks like this was done to get better assembly on x86:
>>>
>>> commit f9852b74bec0117b888da39d070c323ea1cb7f4c
>>> Author: Peter Zijlstra <peterz@infradead.org>
>>> Date:   Mon Apr 18 01:27:03 2016 +0200
>>>
>>>      locking/atomic, arch/qrwlock: Employ atomic_fetch_add_acquire()
>>>
>>>      The only reason for the current code is to make GCC emit only the
>>>      "LOCK XADD" instruction on x86 (and not do a pointless extra ADD o=
n
>>>      the result), do so nicer.
>>>
>>>      Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
>>>      Acked-by: Waiman Long <waiman.long@hpe.com>
>>>      Cc: Andrew Morton <akpm@linux-foundation.org>
>>>      Cc: Linus Torvalds <torvalds@linux-foundation.org>
>>>      Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
>>>      Cc: Peter Zijlstra <peterz@infradead.org>
>>>      Cc: Thomas Gleixner <tglx@linutronix.de>
>>>      Cc: linux-arch@vger.kernel.org
>>>      Cc: linux-kernel@vger.kernel.org
>>>      Signed-off-by: Ingo Molnar <mingo@kernel.org>
>>>
>>> diff --git a/kernel/locking/qrwlock.c b/kernel/locking/qrwlock.c
>>> index fec082338668..19248ddf37ce 100644
>>> --- a/kernel/locking/qrwlock.c
>>> +++ b/kernel/locking/qrwlock.c
>>> @@ -93,7 +93,7 @@ void queued_read_lock_slowpath(struct qrwlock *lock,=
=20
>>> u32 cnts)
>>>           * that accesses can't leak upwards out of our subsequent crit=
ical
>>>           * section in the case that the lock is currently held for wri=
te.
>>>           */
>>> -       cnts =3D atomic_add_return_acquire(_QR_BIAS, &lock->cnts) - _QR=
_BIAS;
>>> +       cnts =3D atomic_fetch_add_acquire(_QR_BIAS, &lock->cnts);
>>>          rspin_until_writer_unlock(lock, cnts);
>>>
>>>          /*
>>>
>>> This is a slowpath, so probably not a concern. But I thought I would=20
>>> double check whether the x86 folks are still happy to proceed with that=
=20
>>> in mind.
>>
>> Hmm, that's an interesting observation. Roger - did you inspect the
>> generated code? At the very least the description may want amending.
>=20
> It seems to always generate the same code for me when using gcc 8.3,
> I even tried using arch_fetch_and_add directly, it always results
> in:
>=20
> ffff82d04022d983:       f0 0f c1 03             lock xadd %eax,(%rbx)
> ffff82d04022d987:       25 00 30 00 00          and    $0x3000,%eax
>=20
> Similarly clang 13.0.0 seem to always generate:
>=20
> ffff82d0402085de:       f0 0f c1 03             lock xadd %eax,(%rbx)
> ffff82d0402085e2:       89 c1                   mov    %eax,%ecx
> ffff82d0402085e4:       81 e1 00 30 00 00       and    $0x3000,%ecx
>=20
> Maybe I'm missing something, but I don't see a difference in the
> generated code.

I've looked myself in the meantime, and I can largely confirm this.
Clang 5 doesn't eliminate the "add" (or really "lea") though. But
nevertheless ...

> I could add to the commit message:
>=20
> "Originally _QR_BIAS was subtracted from the result of
> atomic_add_return_acquire in order to prevent GCC from emitting an
> unneeded ADD instruction. This being in the lock slow path such
> optimizations don't seem likely to make any relevant performance
> difference. Also modern GCC and CLANG versions will already avoid
> emitting the ADD instruction."

... I'm fine with this as explanation; I'd also be fine adding
this to the description while committing.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Feb 15 14:47:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 14:47:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273262.468376 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJz6t-0001xI-Hi; Tue, 15 Feb 2022 14:47:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273262.468376; Tue, 15 Feb 2022 14:47:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJz6t-0001xB-Eg; Tue, 15 Feb 2022 14:47:19 +0000
Received: by outflank-mailman (input) for mailman id 273262;
 Tue, 15 Feb 2022 14:47:17 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ZAEc=S6=linaro.org=vincent.guittot@srs-se1.protection.inumbo.net>)
 id 1nJz6r-0001x3-QA
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 14:47:17 +0000
Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com
 [2a00:1450:4864:20::22f])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2af3f7c1-8e6e-11ec-b215-9bbe72dcb22c;
 Tue, 15 Feb 2022 15:47:16 +0100 (CET)
Received: by mail-lj1-x22f.google.com with SMTP id bx31so27102120ljb.0
 for <xen-devel@lists.xenproject.org>; Tue, 15 Feb 2022 06:47:16 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2af3f7c1-8e6e-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc:content-transfer-encoding;
        bh=W5iOUrZtFrbQaKazLZbRabBpASAbmezehphNEpzXizc=;
        b=JNOLFM6W3xrljvhnC5uCXJipvSeM9PI+wTtkMxZ3lDp+rfeUGd1bCUDdoR3vhtl3cq
         w0LQC7XqGyCdEOD1TdJeeQ0c6NuHzLZ/qDOzWSLLLDCwwtF9j+L7RDrpWASWyaL0pWiC
         /t3+JN7CKczk+wFHo9DM7ymbEYt7axIUysImxgkavobP/MDb/ACQgGR8syhBHNd2qJYF
         MGfyP9xErialFjPIWJ5qU5Ne97vDTIGz3vkxTbz3OCZmEKap1vcIHFUEDBTapLe7eBpR
         y0wiXs9NceAr9LT2jMvMfUPqAnSmDJdhONmnHkh8S6c2V+oiaEKDYZ7cZ0QiksXn4O5s
         Q0Kg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc:content-transfer-encoding;
        bh=W5iOUrZtFrbQaKazLZbRabBpASAbmezehphNEpzXizc=;
        b=784fTg+HPRj/aV8qE8p0zrJEN7YtMzHbBM+KU4LKUySHBZq1L9CoywfWyol5auQKxp
         4pmsBgA1zuaeUlwr/Z392FEyifw127ukKIzwnO5WTdHT4eY1BGqYoqR9zD89vcpDUga4
         jVWWsaa+iV70AKWnQYjjD8N7yAGujTn5eysKah24Ub4yEnt9TgCFNU0/tTD8u05tkgI7
         Xpk1cgANtAboGmJ64T7ifHVPN45uYCEhwHCredXvw3KTO+ALnpRBpbjD08vhpGeEHQdx
         bKxpswUcyn4Z/P5OMvn2uHAup6afmR+N6EvmH/4nn7iqSGYmnrox5DVQ/LlXbzdSvhrl
         Ml6g==
X-Gm-Message-State: AOAM533IPOUBjZFv3eZw1ix3NjwOzAWKXXovbQiCN+s6DUIn8ekf9Y+l
	Bxwf8YofY4JocRONIsx8HSl18BF+Go8ZjTTVZJlGmA==
X-Google-Smtp-Source: ABdhPJwEPtcWn43YJVDmZMlG3/CWc2insrNdIBPl/s1xka5NlSjPeJUfyd8Tuob4baIzLRqkXdgRJkzr44zGMZgVzNc=
X-Received: by 2002:a05:651c:154a:: with SMTP id y10mr2769324ljp.383.1644936435401;
 Tue, 15 Feb 2022 06:47:15 -0800 (PST)
MIME-Version: 1.0
References: <87h79bgd1m.fsf@linaro.org> <alpine.DEB.2.22.394.2202071419270.2091381@ubuntu-linux-20-04-desktop>
 <87k0e1cl9z.fsf@linaro.org> <alpine.DEB.2.22.394.2202111445290.2091381@ubuntu-linux-20-04-desktop>
In-Reply-To: <alpine.DEB.2.22.394.2202111445290.2091381@ubuntu-linux-20-04-desktop>
From: Vincent Guittot <vincent.guittot@linaro.org>
Date: Tue, 15 Feb 2022 15:47:04 +0100
Message-ID: <CAKfTPtCSo0kDwnZyBhRtjaQ9ao+mc5Rzjq=H6jGUpapM-=bRiA@mail.gmail.com>
Subject: Re: Metadata and signalling channels for Zephyr virtio-backends on Xen
To: Stefano Stabellini <stefano.stabellini@xilinx.com>
Cc: =?UTF-8?B?QWxleCBCZW5uw6ll?= <alex.bennee@linaro.org>, 
	stratos-dev@op-lists.linaro.org, xen-devel@lists.xenproject.org, 
	AKASHI Takahiro <takahiro.akashi@linaro.org>, Arnd Bergmann <arnd.bergmann@linaro.org>, 
	Christopher Clark <christopher.w.clark@gmail.com>, Dmytro Firsov <dmytro_firsov@epam.com>, 
	Julien Grall <julien@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
	Oleksandr_Tyshchenko@epam.com, Artem_Mygaiev@epam.com, 
	bertrand.marquis@arm.com, Wei.Chen@arm.com, Ed.Doxat@arm.com, 
	Oleksii_Moisieiev@epam.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sat, 12 Feb 2022 at 00:34, Stefano Stabellini
<stefano.stabellini@xilinx.com> wrote:
>
> On Fri, 11 Feb 2022, Alex Benn=C3=A9e wrote:
> > > FYI, a good and promising approach to handle both SCMI and SCPI is th=
e
> > > series recently submitted by EPAM to mediate SCMI and SCPI requests i=
n
> > > Xen: https://marc.info/?l=3Dxen-devel&m=3D163947444032590
> > >
> > > (Another "special" virtio backend is virtio-iommu for similar reasons=
:
> > > the guest p2m address mappings and also the IOMMU drivers are in Xen.
> > > It is not immediately clear whether a virtio-iommu backend would need=
 to
> > > be in Xen or run as a process in dom0/domU.)
> > >
> > > On the other hand, for all the other "normal" protocols (e.g.
> > > virtio-net, virtio-block, etc.) the backend would naturally run as a
> > > process in dom0 or domU (e.g. QEMU in Dom0) as one would expect.
> >
> > Can domU's not be given particular access to HW they might want to
> > tweak? I assume at some point a block device backend needs to actually
> > talk to real HW to store the blocks (even if in most cases it would be =
a
> > kernel doing the HW access on it's behalf).
>
> Yes, it would. Block and network are subsystems with limited visibility,
> access, and harmful capabilities (assuming IOMMU).
>
> If the block device goes down or is misused, block might not work but
> everything else is expected to work. Block only requires visibility of
> the block device for it to work. The same is true for network, GPU, USB,
> etc.
>
> SCMI is different. If SCMI is misused the whole platform is affected.
> SCMI implies visibility of everything in the system. It is not much
> about emulating SCMI but more about mediating SCMI calls.
>
> In other words, SCMI is not a device, it is a core interface. In a Xen
> model, Xen virtualizes CPU and memory and other core features/interfaces
> (timers, interrupt controller, IOMMU, etc). The PCI root complex is
> handled by Xen too. Individual (PCI and non-PCI) devices are assigned to
> guests.
>
> These are the reasons why I think the best way to enable SCMI in
> upstream Xen is with a mediator in the hypervisor as it is currently in
> development. Any chances you could combine your efforts with EPAM's
> outstanding series? You might be able to spot gaps if any, and might
> even have already code to fill those gaps. It would be fantastic to have
> your reviews and/or contributions on xen-devel.
>
> Otherwise, if you have to run the virtio-scmi backend in userspace, why

Just to clarify, this goal is not to run the scmi backend as a linux
userspace app but to run a virtual power coprocessor that will handle
everything which is not system critical and will change from one
product to another which make it quite hard to maintain in the
hypervisor.

I have only looked at the cover letter which mentions the use of SMC
call which will be trapped by Xen before being modified and forward to
ATF. AFAICT, the ATF execution context is quite simple and synchronous
with the request. In our case, we want to be able to manage to I2C
device as an example or to notifies VMs with aynshorous event like
sensor or performance change which virtio-scmi support


> not try to get it to work on Xen :-) It might not be the ideal solution,
> but it could be a good learning experience and pave the way for the
> other virtio backends which definitely will be in userspace
> (virtio-block, virtio-gpu, etc).
>
>
> > >> Currently the demo setup
> > >> is intermediated by a double-ended vhost-user daemon running on the
> > >> devbox acting as a go between a number of QEMU instances representin=
g
> > >> the front and back-ends. You can view the architecture with Vincents
> > >> diagram here:
> > >>
> > >>   https://docs.google.com/drawings/d/1YSuJUSjEdTi2oEUq4oG4A9pBKSEJTA=
p6hhcHKKhmYHs/edit?usp=3Dsharing
> > >>
> > >> The key virtq handling is done over the special carve outs of shared
> > >> memory between the front end and guest. However the signalling is
> > >> currently over a virtio device on the backend. This is useful for th=
e
> > >> PoC but obviously in a real system we don't have a hidden POSIX syst=
em
> > >> acting as a go between not to mention the additional latency it caus=
es
> > >> with all those context switches.
> > >>
> > >> I was hoping we could get some more of the Xen experts to the next
> > >> Stratos sync (17th Feb) to go over approaches for a properly hosted =
on
> > >> Xen approach. From my recollection (Vincent please correct me if I'm
> > >> wrong) of last week the issues that need solving are:
> > >
> > > Unfortunately I have a regular conflict which prevents me from being
> > > able to join the Stratos calls. However, I can certainly make myself
> > > available for one call (unless something unexpected comes up).
> > >
> > >
> > >>  * How to handle configuration steps as FE guests come up
> > >>
> > >> The SCMI server will be a long running persistent backend because it=
 is
> > >> managing real HW resources. However the guests may be ephemeral (or =
just
> > >> restarted) so we can't just hard-code everything in a DTB. While the
> > >> virtio-negotiation in the config space covers most things we still n=
eed
> > >> information like where in the guests address space the shared memory
> > >> lives and at what offset into that the queues are created. As far as=
 I'm
> > >> aware the canonical source of domain information is XenStore
> > >> (https://wiki.xenproject.org/wiki/XenStore) but this relies on a Dom=
0
> > >> type approach. Is there an alternative for dom0less systems or do we
> > >> need a dom0-light approach, for example using STR-21 (Ensure Zephyr =
can
> > >> run cleanly as a Dom0 guest) providing just enough services for FE's=
 to
> > >> register metadata and BE's to read it?
> > >
> > > I'll try to answer the question for a generic virtio frontend and
> > > backend instead (not SCMI because SCMI is unique due to the reasons
> > > above.)
> > >
> > > Yes, xenstore is the easiest way to exchange configuration informatio=
n
> > > between domains. I think EPAM used xenstore to exchange the
> > > configuration information in their virtio-block demo. There is a way =
to
> > > use xenstore even between dom0less VMs:
> > > https://marc.info/?l=3Dxen-devel&m=3D164340547602391 Not just xenstor=
e but
> > > full PV drivers too. However, in the dom0less case xenstore is going =
to
> > > become available some time after boot, not immediately at startup tim=
e.
> > > That's because you need to wait until xenstored is up and running.
> > >
> > > There are other ways to send data from one VM to another which are
> > > available immediately at boot, such as Argo and static shared memory.
> > >
> > > But dom0less is all about static partitioning, so it makes sense to
> > > exploit the build-time tools to the fullest. In the dom0less case, we
> > > already know what is going to run on the target before it is even tur=
ned
> > > on. As an example, we might have already prepared an environment with=
 3
> > > VMs using Yocto and ImageBuilder. We could also generate all
> > > configurations needed and place them inside each VMs using Yocto's
> > > standard tools and ImageBuilder. So for dom0less, I recommend to go v=
ia
> > > a different route and pre-generate the configuration directly where
> > > needed instead of doing dynamic discovery.
> >
> > Even in a full dom0less setup you still need to manage lifetimes someho=
w
> > if a guest reboots.
>
> Sure but that's not a problem: all the info and configuration related to
> rebooting the guest can also be pre-generated in Yocto or ImageBuilder.
>
> As an example, it is already possible (although rudimental) in
> ImageBuilder to generate the dom0less configuration and also the domU xl
> config file for the same domU with passthrough devices.


From xen-devel-bounces@lists.xenproject.org Tue Feb 15 14:54:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 14:54:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273269.468387 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJzDo-0003N2-Aa; Tue, 15 Feb 2022 14:54:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273269.468387; Tue, 15 Feb 2022 14:54:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJzDo-0003Mv-5n; Tue, 15 Feb 2022 14:54:28 +0000
Received: by outflank-mailman (input) for mailman id 273269;
 Tue, 15 Feb 2022 14:54:26 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=xOiq=S6=epam.com=prvs=4045782cdb=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nJzDm-0003Mp-68
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 14:54:26 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 297c73db-8e6f-11ec-b215-9bbe72dcb22c;
 Tue, 15 Feb 2022 15:54:24 +0100 (CET)
Received: from pps.filterd (m0174678.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 21FEjLHo030307;
 Tue, 15 Feb 2022 14:54:20 GMT
Received: from eur05-db8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2110.outbound.protection.outlook.com [104.47.17.110])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e8dky86j2-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Tue, 15 Feb 2022 14:54:20 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by VI1PR03MB2958.eurprd03.prod.outlook.com (2603:10a6:802:2d::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.14; Tue, 15 Feb
 2022 14:54:16 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::fc4d:4749:5d1:eb73]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::fc4d:4749:5d1:eb73%4]) with mapi id 15.20.4975.019; Tue, 15 Feb 2022
 14:54:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 297c73db-8e6f-11ec-b215-9bbe72dcb22c
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=SZJBzpPAZgDVRdQ+Rhx8khYagEPiY19wzqgl5VOyX53E7Z1X2N56XlFKDKPK9bHaO1P2xhUKsPfK/CEc5rEhHj0XYXZ+JigQ6HvLJ6/uHF+4M4D8u2XcOXGuy2MYSO4DB2fuuz6CW/8lS/9aNj/B7BQcPGSJdg4KDoxoN2d1M0c7SjbxlGHKfSanJgbnd6Ad1Jgb7Q2iHYJ6QmWOqNxssrurHJtQCw0K48DDqgbiE9w1Q/6SaIQlfukvtCqCpbRy/LHck47QBIOd4OPpvpznIoPSyHiyiJeGtl+nZjTXSFAlF3Sy1DGNsmQex5n1xmXapgT/ienUdGQK+UHTgXmNfQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=grJ8uqXQhD6KACc2B+omCmEyqZdwimffM0KIj5QAK9I=;
 b=bGUJdkei/JsXYvG06l84FauzMpVD+SnWqDYwDUa+XxOV00WwxYO0MJh0WxcLdncsDV7EAKOaLxW476A+WwUDU/Q6sAuCoxkc5EYJb+ksfRPOBGoT8YbWbBgfMWEDTXSl7bs6+RYCkzVyRikQgLBGy9nIxAoGEDPXMVRT95RJrccduep5has/sGk4VmoWK9EdNjTpo78OEg4G2t5KM72SPxNCpcWtqDePWK7QmGq8lRFdhJ6S5JAXN1IoeYGfsCVWhjzlLw39Owz6y5pdcZ3Bsb6WO23J1/m/EIxrolFct8JXlmAlwfQc226c9oVFu+MCVrWMvl3awKXNcRCtJa6IBw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=grJ8uqXQhD6KACc2B+omCmEyqZdwimffM0KIj5QAK9I=;
 b=IfXDy8a88b4We674ogEPkfmUY/dmCshyN0psV8Np+slHms1IHdPsJLTEoVA1LkzRz6HJxIJzTOVfAfdSpLY6N5giXtn75K4dQLfDCaxIftjdTe3AqkuikYLeWwZdV55Fo6MY7z/gZ0rxQp9Jg4mwlJ64RCif5Ry4zkjO3J6mahjqMHktqNLE++3zDCiP4cz5gkJjqGl79mcY/fugOX8BacOPMLTzqL6oGh77S3EHDb1iEl7KTE/kLTB/+qg2bR7c67vJdCylDBsTiTNDyz6RMK7CsmqXXzfkCfUiZVNOf9E89l9mwqlkGtvajyBwsWqAEKYKGe8ynCrUDyYmc5wl8Q==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jason Andryuk <jandryuk@gmail.com>
CC: xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>,
        Juergen
 Gross <jgross@suse.com>,
        Anthony PERARD <anthony.perard@citrix.com>,
        Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH] tools: remove xenstore entries on vchan server closure
Thread-Topic: [PATCH] tools: remove xenstore entries on vchan server closure
Thread-Index: AQHX7cJnOJurcgYme0yvunOBFlJKtayVGKiAgAADoIA=
Date: Tue, 15 Feb 2022 14:54:16 +0000
Message-ID: <bc1ab993-0316-89d9-0f20-921b2931a0e3@epam.com>
References: <20211210123519.595163-1-andr2000@gmail.com>
 <CAKf6xpu76umJXWJm2FyG2ST6fm0_iU7RSGGQkTt7_uG_HLi-iw@mail.gmail.com>
In-Reply-To: 
 <CAKf6xpu76umJXWJm2FyG2ST6fm0_iU7RSGGQkTt7_uG_HLi-iw@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 01752adb-555d-49f6-3b45-08d9f093099e
x-ms-traffictypediagnostic: VI1PR03MB2958:EE_
x-microsoft-antispam-prvs: 
 <VI1PR03MB2958D1D214AF22DE1519C68FE7349@VI1PR03MB2958.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 /UqVeP1VaIbaKHevN4Ve+tcyUFA5cD3rV4PUKxR9Tar90fwvgW2A8Av4heaqlpui7geERQ0sKGhG/ysCnnchoDasgKgRmDqBJqxLZlzGEwEFdQjJ9yie0xOb+ziBOss8AGpyblaHpi4olA8EPbey0nSQGBO77axoLhQBDetu3pnUTc30Ue0kmkY74uNqc2eHl9skOECknBLkDfa4f4T2KjAiHBjlVg7BH3uDcgS/N9nlTFzrhNR9M0O3vAghUhlq6RaGx2S3lKBErP9EiEiMlAgqKq6HGtFP+6Kn9EcssKPFe3UhU3snGQXi4tbrjgcFGhnfRw+GBw5a1vXBznkC7ZyahhRn28WGA7oSVS0F11tCdnfjLpKkHQ64LjoWFPoKkHFv+uclw+E452GLPVvH9+JrGxmdtmgrg0Ph6cwPlLu5eS8bnFZyTgurFDc88BH1Njwu1R/XwhcmSWlRjEdakkW5aL/2dEHThRwUm8SbQkhQ2jUSGFMuyFsbTe3rgDtJWmAJA50n5hH2QGscBA+yC8CCiDj2DPEUjVvkA+y+4q8x8nkTe5dwzylc3J4EpGHjpzjVmO4Hd1TAa1ehqBQGUrRfqFtH93d+1KQDrQid5cRttgF2DsaxmlscAlqB1N9zOCeFGXbqVazuhp+v4gq2E9lDf3lOFwiAEJoxQwslmGRosTZflJYjk3QeMYm2Nv/RXE/1W/cLgqPoj1p0/0H7KPDijNtBppTIL86DPcLmC+7XEAsRHa7NvgIRkcpzhILp
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(31686004)(8936002)(508600001)(2616005)(76116006)(36756003)(53546011)(6512007)(66946007)(107886003)(86362001)(6506007)(26005)(186003)(122000001)(54906003)(2906002)(38100700002)(6916009)(91956017)(316002)(6486002)(5660300002)(38070700005)(66556008)(66476007)(64756008)(66446008)(8676002)(4326008)(31696002)(71200400001)(83380400001)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?VEpreFQ4ekN1ZXNhVVcvMXdmWGlRYnJHek5XemtxQzBKcHEremJoMWdRcmZh?=
 =?utf-8?B?NGR5bHRvaFcvV2lGZy9TOVY1ZTVSZkVLdU9JL2hyRWlSMHpvRllxQjJ5dkxU?=
 =?utf-8?B?UDAzZVNBbXBFdFRKYmlNL2pVaTFwZHM1QXBGWFR3WitteHFYV0g4REg4NEFS?=
 =?utf-8?B?SEUxdUtxaS9EZE5oZVY2ais2dERmMFQzSEVuOHJRelpPemRtOFZZVHhEYzRz?=
 =?utf-8?B?RlpzRkwvc05VRDUrQjU3ZVE2L0xSU2FLQkkwMWlGMitDeWhDUDluZGFvakts?=
 =?utf-8?B?SXhqNDhjc0FKK0NTMTdOS0FYVFc0bWV6dzVQWUpPbEJtZ0FRc1Y0Z2tLSEtp?=
 =?utf-8?B?OEFoZFl2T2tsdHUwVW84NjYxNUMwOGpITG5Xa2dSRTZJaFZkcytlODFEWXFs?=
 =?utf-8?B?THlMeUpmeW1VODBjdmZyMjNTUW9mTFp1dTRZMURPa3hLcWdXT1c2VzBUaVFk?=
 =?utf-8?B?bzdZNzMxYnY3WTVyUzJoNTN3MDhFejNWKzFPS1dyVzhTMU5HMGRLM1lJR0N6?=
 =?utf-8?B?eit5SFBPQXZ2ZXBHSFNDeWZiVVoveGdPTzVocEhBVzBrSXhLeXNSSWdsOVRS?=
 =?utf-8?B?RkFrUkpZUktpblRoemJ3NmN0VlNIZVVFbFd0c1Y4UGlrOVVzMGRmRzRJaUtP?=
 =?utf-8?B?SXhlZVJpYnc1cnlmWGJuYnhkNkRZSmlUVHdVUkl5cGdEcHJqb3g5UkdWYkRm?=
 =?utf-8?B?RDlXQ2FLcXBHTmVUa2FpRnlQNVBHOGZ4SWtUcDhLcW0vZjdzVGxzU2ZTU0NV?=
 =?utf-8?B?c2g2aXJ1UkkvY1NhMXpTNDQ3V3lGa05YRHl6T2Zad09pSHdURnBkRHJwZU4v?=
 =?utf-8?B?L05ocVFjOXpXczlrZGFKZHdYUmJYOHBIWkRZdjllU1BHam10cE55UFJuRG9i?=
 =?utf-8?B?aTN2d1B6Wlg1OTRNWlRPdm4rWDZ6OHNPclVPaVJ0c2VGeGMza0dPOVpmeERY?=
 =?utf-8?B?WEUrdHh2RzdjWkQxc0ViSTlsUG1HMTJ0NnhFblYxWEkrYW9sSEQyWGxoMEwx?=
 =?utf-8?B?N1Jvb3pEZFdxYmlGVFZacHpDZnQrZnNLZ092OEwvcWRGdnFRUmd5VjFqUlRF?=
 =?utf-8?B?amoxbkFtclZTRTBjeVZaSkxza25oUVhaM2s0Rll2Y3EzYkh6V2lTU0Fidk5y?=
 =?utf-8?B?VFIrZUJsT05MUENiSTFENVVhaVR2OCs5Q0hCOGxqVHU5REdoVVBkOEU3Vnd0?=
 =?utf-8?B?d1hIK1ZjKzM1L0tRN2dzVnRvNVFzWThHZDlNeWI4YmNuNWV2enhRbGg3RUdm?=
 =?utf-8?B?Q3Vsdjk2L0h6Ty80UFhLTHdqdE42YXVZcXFmNmtSSmNIM3N1WldEZFN3MDdM?=
 =?utf-8?B?RHFpVVFVcE4xbnpBUVNGN1o1RjkxczVNbVZtcDFEcWpFb0JtVVdsSmtVRitj?=
 =?utf-8?B?VEVDYlhGcXBYb3ZKQ3UvZkRHeVBsR3VHaEdPbXA0ckJwVUlhQm9Zampma3pP?=
 =?utf-8?B?ZXB1S3VVZ1NJNFErYlNoYVBWcEoyWXQ5cWN1Z0hrQkJqb0sweEpZT0EwN0VU?=
 =?utf-8?B?akp5U2VwdXIrMkp4alJlQUxXMkxKM2RJbk81MlROTDVQNTVjOVZ1TGJNV3A1?=
 =?utf-8?B?dExVdnRKQy9adlp2Ymk3VVFnbGNJcGFWQU1ySFQ2UHNBTHZpcVc2cG5Qd0hT?=
 =?utf-8?B?WkJBM0hqdnRHelZGa1NXSnAwait0TmQvYkxZK3JjM25Ea2JHcW1ucnBTU3Br?=
 =?utf-8?B?cC9EeDZBYk5PVEVMbDdqMFZld3VxS2RTZmxjck03dWs1bDVscGhJb1pjSlpM?=
 =?utf-8?B?QzYxcVdQai9mbG0yTi8wdlF3Qmt4cHMzN25KdEdsY3EyTDRXL05MRVNKMWRN?=
 =?utf-8?B?NFBHNXVYOUhmZE9ZbkJIRVJjWlhiRU5yRXUzYWhhMGZTM1paUDVXdVQwUXU4?=
 =?utf-8?B?SFZJU05ZSmh0d0czRFkvckdEY25QWFVSYjZ5MEc3ZXpER1AzZmozbXFxZ2dt?=
 =?utf-8?B?Umg3aFlJM2EvbHpoc2NuQjJYN3VjalNsL0UyRjJDU2dBTytjVUozNjI2QXl1?=
 =?utf-8?B?bUVjSklHRzJ0aUZCMDY3LzAwZ2REUE1xbllmRisycVJXWjNaU1NsamJJSXg1?=
 =?utf-8?B?b3k4WjNtcVhGT1h1MnBxeWpSM0NGVVJTM1l3VE13bUpPRDQvd0NRNzA1T285?=
 =?utf-8?B?UDBkdjlRcWVMN2hLSk1vcWFhV3dYaURMNlQ5M05pTVMxbUFRYkFMVmVsN0pj?=
 =?utf-8?B?UFhaMUgzbEU4aXYxK0JBRzdTYUpqZ0pESFZudU10bk1LSG45YlBSSU8zYjNw?=
 =?utf-8?B?TWg2SmlDUkdRMkVBS0ptRVdTdTQyM3JwVkRRcnZGOG10VHRCVjM3bjVBOGIx?=
 =?utf-8?B?Y00xMmh5Y29XVGtrR1ZPSW5zeGtUNW9nNWcvcFg0TnF3U1gvdmo5dz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <116C96751329824D8972F9C751BE90D8@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 01752adb-555d-49f6-3b45-08d9f093099e
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Feb 2022 14:54:16.0922
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: iTgKQISvC82AfVB/JG4SBi3TXmU+k6MrHAaQiQ7abjHSVFrmLXKPtePprivwuRQN0Qw3G01Yu7e2NhPvYZFN4k35V93zusAvyoOtAbhigTc0naC+wHDQyHA2unHqXHQg
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR03MB2958
X-Proofpoint-ORIG-GUID: NshA4DnjmfOZVtcFyeEyTSY72qRWsBhM
X-Proofpoint-GUID: NshA4DnjmfOZVtcFyeEyTSY72qRWsBhM
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-15_04,2022-02-14_04,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1011 adultscore=0
 mlxscore=0 priorityscore=1501 phishscore=0 malwarescore=0 impostorscore=0
 mlxlogscore=894 lowpriorityscore=0 spamscore=0 suspectscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2202150087

DQoNCk9uIDE1LjAyLjIyIDE2OjQxLCBKYXNvbiBBbmRyeXVrIHdyb3RlOg0KPiBPbiBGcmksIERl
YyAxMCwgMjAyMSBhdCA3OjM1IEFNIE9sZWtzYW5kciBBbmRydXNoY2hlbmtvDQo+IDxhbmRyMjAw
MEBnbWFpbC5jb20+IHdyb3RlOg0KPj4gRnJvbTogT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gPG9s
ZWtzYW5kcl9hbmRydXNoY2hlbmtvQGVwYW0uY29tPg0KPj4NCj4+IHZjaGFuIHNlcnZlciBjcmVh
dGVzIFhlblN0b3JlIGVudHJpZXMgdG8gYWR2ZXJ0aXNlIGl0cyBldmVudCBjaGFubmVsIGFuZA0K
Pj4gcmluZywgYnV0IHRob3NlIGFyZSBub3QgcmVtb3ZlZCBhZnRlciB0aGUgc2VydmVyIHF1aXRz
Lg0KPj4gQWRkIGFkZGl0aW9uYWwgY2xlYW51cCBzdGVwLCBzbyB0aG9zZSBhcmUgcmVtb3ZlZCwg
c28gY2xpZW50cyBkbyBub3QgdHJ5DQo+PiB0byBjb25uZWN0IHRvIGEgbm9uLWV4aXN0aW5nIHNl
cnZlci4NCj4+DQo+PiBTaWduZWQtb2ZmLWJ5OiBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyA8b2xl
a3NhbmRyX2FuZHJ1c2hjaGVua29AZXBhbS5jb20+DQo+PiAtLS0NCj4+ICAgdG9vbHMvaW5jbHVk
ZS9saWJ4ZW52Y2hhbi5oIHwgIDUgKysrKysNCj4+ICAgdG9vbHMvbGlicy92Y2hhbi9pbml0LmMg
ICAgIHwgMjMgKysrKysrKysrKysrKysrKysrKysrKysNCj4+ICAgdG9vbHMvbGlicy92Y2hhbi9p
by5jICAgICAgIHwgIDQgKysrKw0KPj4gICB0b29scy9saWJzL3ZjaGFuL3ZjaGFuLmggICAgfCAz
MSArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrDQo+PiAgIDQgZmlsZXMgY2hhbmdlZCwg
NjMgaW5zZXJ0aW9ucygrKQ0KPj4gICBjcmVhdGUgbW9kZSAxMDA2NDQgdG9vbHMvbGlicy92Y2hh
bi92Y2hhbi5oDQo+Pg0KPj4gZGlmZiAtLWdpdCBhL3Rvb2xzL2luY2x1ZGUvbGlieGVudmNoYW4u
aCBiL3Rvb2xzL2luY2x1ZGUvbGlieGVudmNoYW4uaA0KPj4gaW5kZXggZDYwMTBiMTQ1ZGYyLi4z
MGNjNzNjZjk3ZTMgMTAwNjQ0DQo+PiAtLS0gYS90b29scy9pbmNsdWRlL2xpYnhlbnZjaGFuLmgN
Cj4+ICsrKyBiL3Rvb2xzL2luY2x1ZGUvbGlieGVudmNoYW4uaA0KPj4gQEAgLTg2LDYgKzg2LDEx
IEBAIHN0cnVjdCBsaWJ4ZW52Y2hhbiB7DQo+PiAgICAgICAgICBpbnQgYmxvY2tpbmc6MTsNCj4+
ICAgICAgICAgIC8qIGNvbW11bmljYXRpb24gcmluZ3MgKi8NCj4+ICAgICAgICAgIHN0cnVjdCBs
aWJ4ZW52Y2hhbl9yaW5nIHJlYWQsIHdyaXRlOw0KPj4gKyAgICAgICAvKioNCj4+ICsgICAgICAg
ICogQmFzZSB4ZW5zdG9yZSBwYXRoIGZvciBzdG9yaW5nIHJpbmcvZXZlbnQgZGF0YSB1c2VkIGJ5
IHRoZSBzZXJ2ZXINCj4+ICsgICAgICAgICogZHVyaW5nIGNsZWFudXAuDQo+PiArICAgICAgICAq
ICovDQo+PiArICAgICAgIGNoYXIgKnhzX3BhdGg7DQo+PiAgIH07DQo+Pg0KPj4gICAvKioNCj4+
IGRpZmYgLS1naXQgYS90b29scy9saWJzL3ZjaGFuL2luaXQuYyBiL3Rvb2xzL2xpYnMvdmNoYW4v
aW5pdC5jDQo+PiBpbmRleCBjODUxMGU2Y2U5OGEuLmM2Yjg2NzRlZjU0MSAxMDA2NDQNCj4+IC0t
LSBhL3Rvb2xzL2xpYnMvdmNoYW4vaW5pdC5jDQo+PiArKysgYi90b29scy9saWJzL3ZjaGFuL2lu
aXQuYw0KPj4gQEAgLTQ2LDYgKzQ2LDggQEANCj4+ICAgI2luY2x1ZGUgPHhlbi9zeXMvZ250ZGV2
Lmg+DQo+PiAgICNpbmNsdWRlIDxsaWJ4ZW52Y2hhbi5oPg0KPj4NCj4+ICsjaW5jbHVkZSAidmNo
YW4uaCINCj4+ICsNCj4+ICAgI2lmbmRlZiBQQUdFX1NISUZUDQo+PiAgICNkZWZpbmUgUEFHRV9T
SElGVCAxMg0KPj4gICAjZW5kaWYNCj4+IEBAIC0yNTEsNiArMjUzLDEwIEBAIHN0YXRpYyBpbnQg
aW5pdF94c19zcnYoc3RydWN0IGxpYnhlbnZjaGFuICpjdHJsLCBpbnQgZG9tYWluLCBjb25zdCBj
aGFyKiB4c19iYXNlDQo+PiAgICAgICAgICBjaGFyIHJlZlsxNl07DQo+PiAgICAgICAgICBjaGFy
KiBkb21pZF9zdHIgPSBOVUxMOw0KPj4gICAgICAgICAgeHNfdHJhbnNhY3Rpb25fdCB4c190cmFu
cyA9IFhCVF9OVUxMOw0KPj4gKw0KPj4gKyAgICAgICAvLyBzdG9yZSB0aGUgYmFzZSBwYXRoIHNv
IHdlIGNhbiBjbGVhbiB1cCBvbiBzZXJ2ZXIgY2xvc3VyZQ0KPj4gKyAgICAgICBjdHJsLT54c19w
YXRoID0gc3RyZHVwKHhzX2Jhc2UpOw0KPiBZb3UgZG9uJ3QgY2hlY2sgZm9yIE5VTEwgaGVyZSwg
YnV0IHlvdSBkbyBjaGVjayBmb3IgTlVMTCBpbg0KPiBjbG9zZV94c19zcnYoKS4gIEkgZ3Vlc3Mg
aXQncyBva2F5LCBzaW5jZSBpdCBkb2VzIHRoZSByaWdodCB0aGluZy4NCj4gQnV0IEkgdGhpbmsg
aXQgd291bGQgYmUgbW9yZSByb2J1c3QgdG8gY2hlY2sgZm9yIE5VTEwgaGVyZS4gIElzIHRoZXJl
DQo+IGEgc3BlY2lmaWMgcmVhc29uIHlvdSB3cm90ZSBpdCB0aGlzIHdheT8gIE90aGVyd2lzZSBp
dCBsb29rcyBnb29kLg0KSXQgZG9lcyBuZWVkIGEgTlVMTCBjaGVjaywgdGhhbmtzDQpJdCBpcyBh
ZnRlciB3cml0aW5nIGNvZGUgd2l0aCBhbGwgdGhvc2UgYWxsb2NhdGlvbnMgYW5kIGdhcmJhZ2Ug
Y29sbGVjdG9yDQppbiB0aGUgdG9vbHMgc3RhY2sgd2hlbiBhbGxvY2F0aW9ucyAiZG9uJ3QgZmFp
bCIgOykNCkJ1dCB0aGlzIGlzIGluZGVlZCBub3QgdGhlIGNhc2UgaGVyZSBhbmQgbmVlZHMgYSBw
cm9wZXIgY2hlY2sNCkknbGwgd2FpdCBmb3Igb3RoZXIgY29tbWVudHMgYW5kIHNlbmQgdjINCj4N
Cj4gUmVnYXJkcywNCj4gSmFzb24NClRoYW5rIHlvdSwNCk9sZWtzYW5kcg==


From xen-devel-bounces@lists.xenproject.org Tue Feb 15 15:08:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 15:08:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273277.468398 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJzRO-0004uh-H9; Tue, 15 Feb 2022 15:08:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273277.468398; Tue, 15 Feb 2022 15:08:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJzRO-0004ua-DO; Tue, 15 Feb 2022 15:08:30 +0000
Received: by outflank-mailman (input) for mailman id 273277;
 Tue, 15 Feb 2022 15:08:29 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=tLD3=S6=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nJzRN-0004uU-KY
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 15:08:29 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1f7f1f6c-8e71-11ec-b215-9bbe72dcb22c;
 Tue, 15 Feb 2022 16:08:27 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1f7f1f6c-8e71-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644937706;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=T6Cmc2UF9qAZ0HddVrLmRZ0QxBVtdYwX4C+ZrpISl+s=;
  b=Rd7PNZfmBESX0hc1fS+U2RmMNZs80Ak1gsqM8IM67to2jxmI75/VrdNF
   NJ13W9nz/xeFu/e0jiXOn4Y51z8wgJeG/k3nvpuD1PtLwHaDjz9pKiKwt
   Qo5kvW5sozVDAp7oVjTqVSaQxYnRKEupV/oKKuKtBqGBWqGOJRZUXrKA2
   k=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: VBcXdPfDXzfmj6yDhyMaQSNYkGdx2qWKM4NRlWJMXGpiQG1EzKV/DkCa4LQIAC+s7iwsEQB+b8
 PhhD4Wag5Gkg/cQKrEdJ0/7KwBvTTJSjNv7lnonUfibJrVHWUISLzqUS1YWMmd8opgsTKdt0kc
 aMo37LaaxwzlT1uR4QG4XUSiERfP309QMBgJhONHFcDvacQRpSIQoFrIBYJqbbrqtnWh5t1mZ2
 2PibI/0eaapXdfanefzJkyjSpvUILg/pCMvWhsXxzZsRJFIVjYTVoNhe4CLqugR3flWRrdu3nn
 BCD8v3xwgUTO5a092ejNQyQc
X-SBRS: 5.1
X-MesageID: 66481582
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:zjOKJqPhYfu9QEDvrR1skMFynXyQoLVcMsEvi/4bfWQNrUp31GZSz
 WVNUWDVOfvYYGHyfdgkYY228ktSupXWzYM1HAto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6UUsxNbVU8En1500s+w7VRbrNA2rBVPSvc4
 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq
 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYowiUxcJsx
 ZZQibmtYhU1IredgsE3UDANRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs
 6VFdnZdNXhvhMrvqF6/YuBqmsQkKtitJI4Fs2ts5TrYEewnUdbIRKCiCdpwgmls1pkTTay2i
 8wxNWVDYUTqYRp2HhQNM8MZxOL3wV/ebGgNwL6SjfVuuDWCpOBr65DvP8DSYceiXthOkwCTo
 Weu12bzDwweNdef4SGY6X/qjejK9QvrVYRXGLCm+/pChFyI2ndVGBAQTUG8o/Sylgi5Qd03A
 1MQ0jojq+417kPDczXmd0Tm+jje5EdaAocOVb1hgO2Q9kbKyzuEXHoZQ31cVPk7n90qWSZ7z
 HqjnPq8UFSDr4apYX6a876Vqxa7Ni4UMXIOaEc4cOcV3zXwiNpt10ySF76PBIbw14SoQm+on
 1hmuQBj3+17sCId60msEbkraRqIr4OBcAM67x6/somNvlIgP97Ni2BFBDHmARd8wGSxEwPpU
 JsswZH2AAUy4XalznLlfQn1NOv1j8tpyRWF6bKVI7Ev9i6251modp1K7Td1KS9Ba5hYJWC5M
 BKO4VoKvve/2UdGioctPeqM5zkCl/C8RbwJqNiIBjaxXnSBXFDep3w/DaJh92vsjFItgckC1
 WSzKq6R4YIhIf0/llKeHr5FuZdyn3xW7T6DFPjTkkX8uZLDNSH9dFvwGAbXBgzPxPjf+1u9H
 hc2H5bi9iizp8WnOXeJqNZKdwhVRZX5bLivw/Fqmie4ClIOMAkc5zX5mtvNoqRpwPZYkPnm5
 Ha4VhMKwVbznySfew6LdmpiePXkWpMm9SA3OiklPFCJ3Xk/YNnwsPdDJsVvJbR3pvZ+yfNUT
 uUef5nSCPp4VTmaqS8WaoPwrdI+eU3z1x6OJSesfBM2Y4VkG17S4tbhcwa2rHsOAyO7uNEQu
 bql0g+HE5MPSx47VJTdae61zkP3tn8YwbogU0zNK9hVWUPt7Ik1dHCh0q5pe5kBcEyRyCGb2
 gCaBQYjidPM+4JlosPUga2krpuyF7csFERtAGSGv629MjPX/zT/zNYYAvqIZz3USEj95L6mO
 bdO1/j5PfAKwARKvo57H+o5xK4y/YKy9bpTzwAiF3TXdVW7TLhnJyDej8VIs6RMwJ5fuBe3B
 R3TqoULZ+3RNZO3CkMVKSokcv+HhKMdlTTl5PgoJFn3uX1s972dXEQOZxSBhUSx9leu3F/JF
 Qv5hPMr1g==
IronPort-HdrOrdr: A9a23:ZaIcKaoi/RjLZEbmgCS+N0IaV5oveYIsimQD101hICG9Ffbo8P
 xG/c5rsSMc7Qx7ZJhOo7y90cW7Lk80lqQU3WByB9mftWDd0QPDQb2KhrGC/xTQXwH46+5Bxe
 NBXsFFebjN5IFB/KXHCd+DYrQd/OU=
X-IronPort-AV: E=Sophos;i="5.88,371,1635220800"; 
   d="scan'208";a="66481582"
Date: Tue, 15 Feb 2022 15:08:21 +0000
From: Anthony PERARD <anthony.perard@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>
CC: <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>, Juergen Gross
	<jgross@suse.com>, Jan Beulich <jbeulich@suse.com>
Subject: Re: [PATCH v2] tools/libxl: don't allow IOMMU usage with PoD
Message-ID: <YgvB5UtyC29m8zbo@perard.uk.xensource.com>
References: <20220203143211.18967-1-roger.pau@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220203143211.18967-1-roger.pau@citrix.com>

On Thu, Feb 03, 2022 at 03:32:11PM +0100, Roger Pau Monne wrote:
>      if (d_config->c_info.type != LIBXL_DOMAIN_TYPE_PV &&
> -        d_config->num_pcidevs && pod_enabled) {
> +        d_config->c_info.passthrough != LIBXL_PASSTHROUGH_DISABLED &&
> +        pod_enabled) {
>          ret = ERROR_INVAL;
> -        LOGD(ERROR, domid,
> -             "PCI device assignment for HVM guest failed due to PoD enabled");
> +        LOGD(ERROR, domid, "IOMMU not supported together with PoD");

I'm not sure that this new error message is going to be good enough to
point out configuration issue for the guest.

One is going to set 'pci=["foo"]' or 'dtdev=["bar"]', which will enable
passthrough. Then they may get en error about IOMMU or PoD.
Should we maybe write something like this instead?

   "IOMMU or device passthrough not supported together with PoD"

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Tue Feb 15 15:11:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 15:11:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273286.468409 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJzU6-0006L7-1e; Tue, 15 Feb 2022 15:11:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273286.468409; Tue, 15 Feb 2022 15:11:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJzU5-0006L0-To; Tue, 15 Feb 2022 15:11:17 +0000
Received: by outflank-mailman (input) for mailman id 273286;
 Tue, 15 Feb 2022 15:11:16 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=sIVK=S6=citrix.com=Jane.Malalane@srs-se1.protection.inumbo.net>)
 id 1nJzU4-0006Ks-6x
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 15:11:16 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8318f353-8e71-11ec-b215-9bbe72dcb22c;
 Tue, 15 Feb 2022 16:11:14 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8318f353-8e71-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644937874;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=NAciJSRGBb0vj8FMIKyXdz5GBr8tGa2PK4Zswn6qXI4=;
  b=c/jyadQUCkf52ih9hkQoRpVWQgDy+BtpAPhWVN++cjcKC5tOtBFgvLlA
   /yQHotjFoKFfRiP9si6+HIgpR5qTbFd5gW8arfOxE65yh07NKcfqwrKHZ
   v5esmU9uUSrwiA9phWSIB4tMRxloUrCWMxXTDCZtzNvk0C5x2wiBrGfHX
   U=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: r1xgwaAdAPJkYMUDGS8RoQpExJ8/lHVTvr0dv20BGr7CVYCZOB0sP3MJ82BVte5hRZIcuAvRbY
 Brj8BSqwo5FiuQ2R1UOhDe5l64J8sjD3nNNn7kbIMjwybWvAPZt2E4m8gqhGtQKWSMlGdYDMV0
 tUeX9kq2tHeBPvaR9GcOB3SevTQgRw30dCUM+1KtNvRzfyJTCLxzu5x8ttW8i4irq9DzCZJSKT
 K7r68XAgRkDJCTWQk3zuvPLCsr1W9IpUMzNreJ+Pp2huRUiu6VVuFmqADEIIq0UlEyrcF9/jzo
 ORLXCdG+/63g0RzPoxS0q3zo
X-SBRS: 5.1
X-MesageID: 64251459
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:8EvIWqNr0yChyvDvrR3PkcFynXyQoLVcMsEvi/4bfWQNrUp2gjIOm
 2EfXzqGMv2DZGajfYhzaYTjoEwC6MfRzIBgHQto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6UUsxNbVU8En1500s+w7VRbrNA2rBVPSvc4
 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq
 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYoxiMwf1by
 85njoHuWxc3PbGUmqMvCTANRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs
 6VFdnZdNXhvhMrvqF6/YstlgMllCcDvNYcWvHxIxjDFF/c2B5vERs0m4PcGgG1t35wTTJ4yY
 eIQYzFPRS2HYyFAI1gdVrAHwMiLnUDGJmgwRFW9+vNsvjm7IBZK+IbqNN3Za9mbX/J/l0yTp
 n/F12nhCxRcP9uaoRKe6W6ljOLLmSL9WaoRGae++/osh0ecrkQZBQcKT1K9rb+8g1SnRtNEA
 0UO/2wlqq1a3E+mUNj7GQG5qXisvxgAVt4WGOo/gCmP16yS5Q+aD2oFSzdpado6uctwTjsvv
 neZktWsCTFxvbm9TXOG6qzSvT60ITISL2IJeWkDVwRty9vprZw3jxnPZs1+C6PzhdrwcRnvx
 xiaoS54gK8c5eYJyqG68Fbvkz+q4J/TQWYd5ArNWXm+xhhkf4PjbIutgWU39t4ZctzfFAPY+
 iFZxY7Ot4jiEK1higSgRbsgNrKyzc2Ybi/Mn11zR5tmxW6ErivLkZ9r3BlyI0JgM8AhcDDvY
 VPOtQ452KK/LEdGfocsPdvvVp1CIbzIUI28C6uKNoYmjo1ZKVfflByCc3J8yIwEfKIEtagkc
 amWfs+3ZZrxIfQ2lWHmLwvxPFJC+8zf+Y8xbc2hp/hE+eDHDJJwdVviGAHQBt3VFIve/G3oH
 y93bqNmMSl3XuzkeTXw+oUON10MJnVTLcmo95AIJr7ef1I/QztJ5xrtLVQJIdINokiovr2Qo
 iHVtrFwlDITekEr2S3VMys+OdsDrL50rG4hPDxEALpb8yNLXGpb149GL8FfVeB+rIRLlKcoJ
 9FYK5ToKqkeEVzvpmVCBaQRWaQ/LXxHcyrVZHH7CNX+FrY9LzH0FijMJ1CxqnBWV3Dv6qPTY
 dSIj2vmfHbKfCw7ZO7+Y/Oz1VKh+38bneN5RUzTJddPPk7r9eBXx+bZ1aRfzxgkJUqRyz2E+
 RyRBBtE9+DBr5VsqIvChLyerpfvGOx7RxIIE27e5LewFC/b4mv8ntMQDLfWJWjQBDHu5aGvR
 eRJ1PWgYvcJq0lH7thnGLFxwKNgu9a2/+1Gzh5pFWngZkiwDu8yOWGP2MRC7/UfxrJQtQasd
 FiI/91WZeeANM//SQZDLws5dOWTk/oTn2CKv/gyJUz74g5x/aaGDhoOb0Xd1nQFIeIsYo0/w
 OontMoH0CCFi0InYoSckyRZ12WQNXhcAa8pgY4XXd3wgQ0xx1AcPZGFUn3q4IuCYslnO1UxJ
 mPGn7LLgrlRyxaQc3c3EnSRj+NRiY5X5UJPxV4GYV+IhsDElrk82xgIqWY7SQFczxNm1eNvO
 zc0ax0pdPvWpzo41tJeW22MGh1aAEzL80P8/FIFiWnFQhT6TWfKNmA8Zb6A8U1xH7iwpdSHE
 GV0EFrYbAs=
IronPort-HdrOrdr: A9a23:lS63ravaBTy7gooC+PQCB57u7skC1YMji2hC6mlwRA09TyXGra
 +TdaUguSMc1gx9ZJh5o6H8BEGBKUmskKKceeEqTPmftXrdyReVxeZZnMrfKlzbamLDH4tmu5
 uIHJIOceEYYWIK7voSpTPIaerIo+P3sJxA592ut0uFJDsCA8oLjmdE40SgYzZLrWF9dMAE/f
 Gnl656Tk+bCBIqh7OAdx44tob41r/2vaOjRSRDKw8s6QGIgz/twqX9CQKk0hAXVC4K6as+8E
 De+jaJpZmLgrWe8FvxxmXT55NZlJ/K0d1YHvGBjcATN3HFlhuoXoJ8QLeP1QpF4t1HqWxa1e
 UkkS1QePib2EmhOF1dZiGdgjUI5Qxer0MKD2Xo2UcL7/aJHw7SQPAx+r6xOiGplXbI+usMjZ
 6jlljpxqZ/HFfOmj/w6MPPUAwvnk2ooWA6mepWlHBHV5ACAYUh57D3U3klZavoMRiKoLzPKt
 MeR/00JcwmBW+yfjTcpC1i0dasVnM8ElOPRVUDoNWc13xTkGpix0UVycQDljNYnahNB6Vs9q
 DBKOBlhbtORsgZYeZ0A/oAW9K+DijITQjXOGyfLFz7HOUMOm7LqZTw/LIpjdvaNaAg3d83gt
 DMQVlYvWk9dwbnDtCPxoRC9lTXTGC0TV3Wu4hjDlhCy8vBrZbQQF6+oWEV4rydSq8kc73mst
 6ISeBrP8M=
X-IronPort-AV: E=Sophos;i="5.88,371,1635220800"; 
   d="scan'208";a="64251459"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=HO3BrKuqdpknqNYiACbkZXPfBxQBiDrfMxLTem9ThG1dJbFWkNb1OxMqgse4YbRdgBhZu6vnSofx7wzUJM7fK/0pJjy23hhy8NG+2kJI+YTDBvAl5pNV/9ZD2lkVCQ3BADMp8WfNbgstakTHJAdE8KgTlX49PvjjQZVGszdHexLhyDe+9MLaQIAr408t9YPYetaG6vSAIGQLIH5eis10zCdvt+x6u8nyUaPjSPeZhdlf0VrUEGT+3J8jzmV6DHP7XByckH5+PKwXSonNUkp5og9stANd9tLMyHA1m+HTBZvfJxuUP7UQlI9MZSXDDYbUIyEexvtOO7j8K8vbS48QEg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=NAciJSRGBb0vj8FMIKyXdz5GBr8tGa2PK4Zswn6qXI4=;
 b=i8bFxXYZhfN2OQLlyXQmhVkvlmoJcSiV9AZGigkxV0ZnUMuL18WDoQ2BId0NmGB2l0ggkhJx1shD2zteYIJkYTq1+YP9mKJywG8JOBnOjwDj1Avri6js2N1sOr2aXCcREkhUz/5cCMk5VHPaKaKT80Fi5cLHqS6Q0NUTt7H9RJI6WcNT5qfum8vx3oHu8fPE8Ywe15Tfov47FPgDXp5RpGD22VCXv1sS2ZInkiLAXWKrUAaYMGIHwHHarT8cBwZ587cAog8+6ObjvDmTDKKsWaJ93mxPrutJ7jp+dQuBFjKPYITqLbb6wpITjgbJrXSq6y8F5YBrdbBLWNfvZsFNeg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=NAciJSRGBb0vj8FMIKyXdz5GBr8tGa2PK4Zswn6qXI4=;
 b=pbugK/dH+c2mxuk1VSFwMyA2zCeArzr7Ys9eDj0/pRtR/lTj/E21Ne+7TsLY7OIaxfkgEftCMA0AB0VKcRhEhGpLSdZlV4Db6XHipqKpEFmznOfn3DtI40+kS28YEFh5E/R7pd4t1DYriVB2hAp8RTWqkwHe98wq1pu3TS1DdU0=
From: Jane Malalane <Jane.Malalane@citrix.com>
To: Jan Beulich <jbeulich@suse.com>, Roger Pau Monne <roger.pau@citrix.com>,
	Andrew Cooper <Andrew.Cooper3@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>, "Anthony
 Perard" <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, "George
 Dunlap" <George.Dunlap@citrix.com>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>,
	Jun Nakajima <jun.nakajima@intel.com>, Kevin Tian <kevin.tian@intel.com>,
	Roger Pau Monne <roger.pau@citrix.com>, Andrew Cooper
	<Andrew.Cooper3@citrix.com>
Subject: Re: [PATCH v2 1/2] xen+tools: Report Interrupt Controller
 Virtualization capabilities on x86
Thread-Topic: [PATCH v2 1/2] xen+tools: Report Interrupt Controller
 Virtualization capabilities on x86
Thread-Index: AQHYHE+TdJl64aH33EedeR0PZ4zblKyMkj6AgAGTLwCAABdDgIAABJKAgATOw4CAAAIAAIAAQJgAgADqygCAADOdAIAAAYiAgABRRgA=
Date: Tue, 15 Feb 2022 15:10:57 +0000
Message-ID: <9ed50d7a-23c7-2405-ff5e-15cc02b0c67f@citrix.com>
References: <20220207182101.31941-1-jane.malalane@citrix.com>
 <20220207182101.31941-2-jane.malalane@citrix.com>
 <YgTi6bzeojtcu0xL@Air-de-Roger>
 <dff9c5c0-7bee-ce0d-3288-91255a701c99@citrix.com>
 <YgZIo9VQktcqGHTD@Air-de-Roger>
 <6d924061-f2fd-5f3d-0f98-79e76398b908@suse.com>
 <6c9400b8-7c76-34c8-f69e-3fad1eb53b8c@citrix.com>
 <101b0950-b7f2-119b-b654-574a71cec3bc@suse.com>
 <1bac0507-9420-f0b9-f846-f1c73bf9678d@citrix.com>
 <42fb3257-0c36-c156-c81b-f70dd5f247aa@suse.com>
 <9721222d-1c0d-ddaf-fbc6-801f5d9445f5@citrix.com>
 <12727658-68f4-1785-9b37-c948eb2cba71@suse.com>
In-Reply-To: <12727658-68f4-1785-9b37-c948eb2cba71@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: befac315-2a5c-4396-9437-08d9f0955e7a
x-ms-traffictypediagnostic: BN3PR03MB2386:EE_
x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
x-microsoft-antispam-prvs: <BN3PR03MB23869E171223D23242BA557A81349@BN3PR03MB2386.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: UiuDIy/NARsHla9z8EV4N6nMqou2QJXYbHLec7Q6WvlJplo9B5XdncMmB1g09vew2I4oGFpUhQOsqy1tNV2BliEvaVy9WYy5s+PWw8IUbjHJsEZxgdSYDtuq1813G/XjXnnxKNBqQNbpglZZD6zErLoACYNcHtZbyEz4Sk9ac1yqsrF4DYl9myoy3bET1/TXF8YTTos1FuGqo6gDFAXiTwF/YCWkA5tixcrXrdLDJxU9JKaT3FVvveXHO+DbZ1ixMCHkqzytLw0glz5FmZ6z8YCdPOwn8lJphqsUXxLAkfspd/ylfXiDv9vMDLTZq5x34uDzL762apc0ih2TPG4ZkUw/6IdUQjsaFIuUFkR/N8QoJAl4w6MOUun66iDYVhwLMpZFYFvaf/d5cXIrTT93IlKlNK9dRLU4h9Z4TLcj75ag3rpsdpgieHoV39BbXo4dkSaMJ8waW2B+NRBVQfH2eMUYSaeyaQeaDFoJiEHVWOsnkQDxvDa2g8l/0QtNS6/aqGWuBIUbaNRgymzupS8wf+Pizo8fcJ+mmnKD6Fkd33woDsCzsGY9KAkulOfHObfkYV2n9DJsZgO8+ibGRDZe4L2OJRbiaXsyYrrFldl2T8DA3kuUIID2YuhhNl806/rUC9Oa+9bSiz3bMWyPUspPqbwuCegcTEt0XC5h3kyH8RGkHUp1geqU8TLdkMcqK8O/9slSIw1lLsledscKEo6YPMv3qX3iM+WsAamgjgRwUGDJoDmcSMHk0wHQbRrq7mpo
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR03MB3391.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(122000001)(66446008)(66946007)(110136005)(91956017)(6486002)(8676002)(107886003)(4326008)(2906002)(38070700005)(66556008)(66476007)(38100700002)(54906003)(26005)(6636002)(186003)(82960400001)(2616005)(316002)(76116006)(508600001)(64756008)(6512007)(83380400001)(7416002)(31686004)(6506007)(53546011)(31696002)(71200400001)(86362001)(5660300002)(8936002)(36756003)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?bDlRZnNIeTY4SzIxNVQvTmpaTVYxREZSeHRJcFRsSy9BMDR6ZFVOYkQ2VEds?=
 =?utf-8?B?eG5BZzhWUXV4THlVZnNuVU5zL0JVVWJoQmVWcjZraFpKVFlBd2x1TklxOGV6?=
 =?utf-8?B?V09qYm1MWjRWTHV5WTAwVlRwaEhvaFg1Q3prZ1M0Z3BFcTVOb09RTlVEVmpT?=
 =?utf-8?B?bFgzYWliMkk5MTRacVFHbm9vQjBBOG5JYm5Wa1RhMnczSmdWWk5NTWJNejhl?=
 =?utf-8?B?ekZGbjRuei9BcjJ5TmRYWnNOb3JGM2dLa044bnRmLzdIajFERjZnRzFGQ1lo?=
 =?utf-8?B?YnI1Sm00UDJmTFBhNHd0OFV2dUl0bmlzSXpNRlBUS1p3YkY2Y3R0TWdxMmQz?=
 =?utf-8?B?cVRGUWsrdGp2MGNMTGx2dG5YY0pqdDdTbXZxa1pVV2dDemJsS3FSSnA3TTda?=
 =?utf-8?B?ZGtTMWc3MDUrcWppVGlkSXhKY2M0cUVKK2tCS1NPY0VHaUlIaHVZVkFlOEkv?=
 =?utf-8?B?dXNMc2RyaGtveE9TTm5qMHNYWXBEN0w3YlBndzNFdXl4Rk1Oc3RTTEpHeFNt?=
 =?utf-8?B?bCtJWkh1U0FWSjkyMXVqZGpxWHdRY2NQTkdXcXdUOXFnaStUb0owVmVVQ1FR?=
 =?utf-8?B?SjdyeEZXN1duTm5DcE9SSTYvRUFnQkpEYUxDV3l5TmxMYkR0TCtBTkNhYlk2?=
 =?utf-8?B?alovT2cycXBpZTV6c2tNNDRNNURnWXM1bUVrUnpmMHlvazRqd2lYSlRzMWJX?=
 =?utf-8?B?VjZXYkw2eUl1R1JFckUxdk5vK2dZZEZKVGtXUkEwTWxJQm9jUjNZT3R6ZVZQ?=
 =?utf-8?B?b2NZaVptQ0NJaGgwVDdaaStzNkI1OU9qelNxV2p5aVh6cXpmeEdMUWYyaTky?=
 =?utf-8?B?WHAydlpucFhzTjJTbm4ycHlraDRoc3A5L2gvWlVMbS93Y2xnYkNZUW1YNDNx?=
 =?utf-8?B?RUNUczBRZXF3MTZxaUgxMC9zeDRkdFN6V2toN2ZtUFZqcTM3c2VEZWh1WEw5?=
 =?utf-8?B?Nzd3Q0c4MGlNeUpKaHN5TFA0dlordmNQdG9OMVpFMWlNUm1KOVZlOXhzME1D?=
 =?utf-8?B?bDRsYlUxYjFrNUxiQnNsNEZQS3N6TlZ0dGFKU2hBZk50VFAxTHc1RUtNb05C?=
 =?utf-8?B?SlRMWnNPcFZpbGtmTUZjTmljN3hPRW5RZWNVN2dmbFVQK3NEYlpmLzhJMkFH?=
 =?utf-8?B?dzVuZEpUTGpjQk05Y3ZUeHlkd3JiSWNxanlMcFZGcFBncy9hYnVoNUgyUm9W?=
 =?utf-8?B?dXMwVHcxc1krOVFHRDBXWmh3NGlIbFJtZWYvRnppaVFQcDVKc0hDTDgxL2t0?=
 =?utf-8?B?MmtkSGxwRUF1YW1yaTgzUU9SM3l5VThFOW96WG9sNG8wdVZXdFlCWUtGVkQ4?=
 =?utf-8?B?TXBxY3lLaVAvTUlGckVOZjlqcXJOS0JaTDF2QmNydWJkQVRXRGpzZE5oV2s4?=
 =?utf-8?B?TS9qVkFoSkg2VEhYL3hBUE45RzBvZnkzOGM5UjJia3RRMFFQcWpPcmhIc25N?=
 =?utf-8?B?YVJTU2ZHZVhsdzRoenBBK3lhVDE4MjVsWVgzZFhMdlpJc2FpQTVvYWZDdXMx?=
 =?utf-8?B?R0FpcG9ndGc1b0NTaGVmNnJwQjVWZU9kVGUwRDBkVVJRTC9sc2pMbFVhWlVo?=
 =?utf-8?B?eXJrRUJaMUpyR1NQeU5BU3Ewd2U4NEZ5d2k1MzBLdGl6NnM3WVNOazFQVXI4?=
 =?utf-8?B?L0wxVDZBNEhNS1VaMG9vaW9jT3c1UGliR3d3d1FMUWVQeGhUdlR5Uk42WEJV?=
 =?utf-8?B?YzZ1NmJwUkdOYXR3cnBwWCtDT1NVTm5QaTVsMElrUXJNREFTd2k4czMvVTIr?=
 =?utf-8?B?cmNLOU9Cc2RpdTlKaG9QSXNIb1BDd2J0NlN0ZzQ1bm5aQndtTXVUOGFLNjE1?=
 =?utf-8?B?YjlQa0FnWkpHTmtnQTlpdGxrK21LdndudDZreWZuRDl5VGJBeGxPN2ZCTngz?=
 =?utf-8?B?V2NRcUpqWlQxbHdVSkpNSjRDQnZPMmE4QWlqM2VHZlBVVEZFdzBVZmxZZXFj?=
 =?utf-8?B?Sm1mMnZjTGZucmwwU3BYZSsvNkJTdnhHNHV2dzhtNEhYbG0zd0pPZ2FmeWFu?=
 =?utf-8?B?L2JjUW5lZVcxWnRPVnFsbUx0bjhiTUtHUWVnVk1hUWVLZnJ6SjJMZ1dScWc5?=
 =?utf-8?B?VFRQZHVNRHkxRHpFcUs2QytXSituU3FjNXVnTG1sUXd2WUtXaFVBS0lwUlNE?=
 =?utf-8?B?Tk5qU2lQeFI2Y3NOa01XMnd0M1NEQ3pnelVSOXZFRnlOZXkwU2RQYit4d21v?=
 =?utf-8?B?ZXE3bFlrNUJPRE9VdDkvc0M4RFdGRUgxdnFIUGRQSGV5R2xTNHB5b1dydnZm?=
 =?utf-8?Q?ZH8/Ew9TsxFqFjx/ZFx83f9pbnrr4KthDb4xWlqy7E=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <94844C5B153867468CF690ACBEBFBDE4@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MWHPR03MB3391.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: befac315-2a5c-4396-9437-08d9f0955e7a
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Feb 2022 15:10:57.4895
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 323Jw7JY5d5kbkAiWwMAA1lGYaEafH774dHVtFuwvCvoN6DVvfAl+3kMs4SHGRBtpQWjAxW0ZWCgX1nk6mFNB7YtUv2XqzZr7/ml1XxFKQA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB2386
X-OriginatorOrg: citrix.com

T24gMTUvMDIvMjAyMiAxMDoxOSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IFtDQVVUSU9OIC0gRVhU
RVJOQUwgRU1BSUxdIERPIE5PVCByZXBseSwgY2xpY2sgbGlua3MsIG9yIG9wZW4gYXR0YWNobWVu
dHMgdW5sZXNzIHlvdSBoYXZlIHZlcmlmaWVkIHRoZSBzZW5kZXIgYW5kIGtub3cgdGhlIGNvbnRl
bnQgaXMgc2FmZS4NCj4gDQo+IE9uIDE1LjAyLjIwMjIgMTE6MTQsIEphbmUgTWFsYWxhbmUgd3Jv
dGU6DQo+PiBPbiAxNS8wMi8yMDIyIDA3OjA5LCBKYW4gQmV1bGljaCB3cm90ZToNCj4+PiBbQ0FV
VElPTiAtIEVYVEVSTkFMIEVNQUlMXSBETyBOT1QgcmVwbHksIGNsaWNrIGxpbmtzLCBvciBvcGVu
IGF0dGFjaG1lbnRzIHVubGVzcyB5b3UgaGF2ZSB2ZXJpZmllZCB0aGUgc2VuZGVyIGFuZCBrbm93
IHRoZSBjb250ZW50IGlzIHNhZmUuDQo+Pj4NCj4+PiBPbiAxNC4wMi4yMDIyIDE4OjA5LCBKYW5l
IE1hbGFsYW5lIHdyb3RlOg0KPj4+PiBPbiAxNC8wMi8yMDIyIDEzOjE4LCBKYW4gQmV1bGljaCB3
cm90ZToNCj4+Pj4+IFtDQVVUSU9OIC0gRVhURVJOQUwgRU1BSUxdIERPIE5PVCByZXBseSwgY2xp
Y2sgbGlua3MsIG9yIG9wZW4gYXR0YWNobWVudHMgdW5sZXNzIHlvdSBoYXZlIHZlcmlmaWVkIHRo
ZSBzZW5kZXIgYW5kIGtub3cgdGhlIGNvbnRlbnQgaXMgc2FmZS4NCj4+Pj4+DQo+Pj4+PiBPbiAx
NC4wMi4yMDIyIDE0OjExLCBKYW5lIE1hbGFsYW5lIHdyb3RlOg0KPj4+Pj4+IE9uIDExLzAyLzIw
MjIgMTE6NDYsIEphbiBCZXVsaWNoIHdyb3RlOg0KPj4+Pj4+PiBbQ0FVVElPTiAtIEVYVEVSTkFM
IEVNQUlMXSBETyBOT1QgcmVwbHksIGNsaWNrIGxpbmtzLCBvciBvcGVuIGF0dGFjaG1lbnRzIHVu
bGVzcyB5b3UgaGF2ZSB2ZXJpZmllZCB0aGUgc2VuZGVyIGFuZCBrbm93IHRoZSBjb250ZW50IGlz
IHNhZmUuDQo+Pj4+Pj4+DQo+Pj4+Pj4+IE9uIDExLjAyLjIwMjIgMTI6MjksIFJvZ2VyIFBhdSBN
b25uw6kgd3JvdGU6DQo+Pj4+Pj4+PiBPbiBGcmksIEZlYiAxMSwgMjAyMiBhdCAxMDowNjo0OEFN
ICswMDAwLCBKYW5lIE1hbGFsYW5lIHdyb3RlOg0KPj4+Pj4+Pj4+IE9uIDEwLzAyLzIwMjIgMTA6
MDMsIFJvZ2VyIFBhdSBNb25uw6kgd3JvdGU6DQo+Pj4+Pj4+Pj4+IE9uIE1vbiwgRmViIDA3LCAy
MDIyIGF0IDA2OjIxOjAwUE0gKzAwMDAsIEphbmUgTWFsYWxhbmUgd3JvdGU6DQo+Pj4+Pj4+Pj4+
PiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gveDg2L2h2bS92bXgvdm1jcy5jIGIveGVuL2FyY2gveDg2
L2h2bS92bXgvdm1jcy5jDQo+Pj4+Pj4+Pj4+PiBpbmRleCA3YWIxNWUwN2EwLi40MDYwYWVmMWJk
IDEwMDY0NA0KPj4+Pj4+Pj4+Pj4gLS0tIGEveGVuL2FyY2gveDg2L2h2bS92bXgvdm1jcy5jDQo+
Pj4+Pj4+Pj4+PiArKysgYi94ZW4vYXJjaC94ODYvaHZtL3ZteC92bWNzLmMNCj4+Pj4+Pj4+Pj4+
IEBAIC0zNDMsNiArMzQzLDE1IEBAIHN0YXRpYyBpbnQgdm14X2luaXRfdm1jc19jb25maWcoYm9v
bCBic3ApDQo+Pj4+Pj4+Pj4+PiAgICAgICAgICAgICAgICAgICBNU1JfSUEzMl9WTVhfUFJPQ0JB
U0VEX0NUTFMyLCAmbWlzbWF0Y2gpOw0KPj4+Pj4+Pj4+Pj4gICAgICAgICAgIH0NCj4+Pj4+Pj4+
Pj4+ICAgICAgIA0KPj4+Pj4+Pj4+Pj4gKyAgICAvKiBDaGVjayB3aGV0aGVyIGhhcmR3YXJlIHN1
cHBvcnRzIGFjY2VsZXJhdGVkIHhhcGljIGFuZCB4MmFwaWMuICovDQo+Pj4+Pj4+Pj4+PiArICAg
IGlmICggYnNwICkNCj4+Pj4+Pj4+Pj4+ICsgICAgew0KPj4+Pj4+Pj4+Pj4gKyAgICAgICAgYXNz
aXN0ZWRfeGFwaWNfYXZhaWxhYmxlID0gY3B1X2hhc192bXhfdmlydHVhbGl6ZV9hcGljX2FjY2Vz
c2VzOw0KPj4+Pj4+Pj4+Pj4gKyAgICAgICAgYXNzaXN0ZWRfeDJhcGljX2F2YWlsYWJsZSA9IChj
cHVfaGFzX3ZteF9hcGljX3JlZ192aXJ0IHx8DQo+Pj4+Pj4+Pj4+PiArICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgIGNwdV9oYXNfdm14X3ZpcnR1YWxfaW50cl9kZWxpdmVyeSkg
JiYNCj4+Pj4+Pj4+Pj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjcHVf
aGFzX3ZteF92aXJ0dWFsaXplX3gyYXBpY19tb2RlOw0KPj4+Pj4+Pj4+Pg0KPj4+Pj4+Pj4+PiBJ
J3ZlIGJlZW4gdGhpbmsgYWJvdXQgdGhpcywgYW5kIGl0IHNlZW1zIGtpbmQgb2YgYXN5bW1ldHJp
YyB0aGF0IGZvcg0KPj4+Pj4+Pj4+PiB4QVBJQyBtb2RlIHdlIHJlcG9ydCBodyBhc3Npc3RlZCBz
dXBwb3J0IG9ubHkgd2l0aA0KPj4+Pj4+Pj4+PiB2aXJ0dWFsaXplX2FwaWNfYWNjZXNzZXMgYXZh
aWxhYmxlLCB3aGlsZSBmb3IgeDJBUElDIHdlIHJlcXVpcmUNCj4+Pj4+Pj4+Pj4gdmlydHVhbGl6
ZV94MmFwaWNfbW9kZSBwbHVzIGVpdGhlciBhcGljX3JlZ192aXJ0IG9yDQo+Pj4+Pj4+Pj4+IHZp
cnR1YWxfaW50cl9kZWxpdmVyeS4NCj4+Pj4+Pj4+Pj4NCj4+Pj4+Pj4+Pj4gSSB0aGluayB3ZSBs
aWtlbHkgbmVlZCB0byBiZSBtb3JlIGNvbnNpc3RlbnQgaGVyZSwgYW5kIHJlcG9ydCBodw0KPj4+
Pj4+Pj4+PiBhc3Npc3RlZCB4MkFQSUMgc3VwcG9ydCBhcyBsb25nIGFzIHZpcnR1YWxpemVfeDJh
cGljX21vZGUgaXMNCj4+Pj4+Pj4+Pj4gYXZhaWxhYmxlLg0KPj4+Pj4+Pj4+Pg0KPj4+Pj4+Pj4+
PiBUaGlzIHdpbGwgbGlrZWx5IGhhdmUgc29tZSBlZmZlY3Qgb24gcGF0Y2ggMiBhbHNvLCBhcyB5
b3Ugd2lsbCBoYXZlIHRvDQo+Pj4+Pj4+Pj4+IGFkanVzdCB2bXhfdmxhcGljX21zcl9jaGFuZ2Vk
Lg0KPj4+Pj4+Pj4+Pg0KPj4+Pj4+Pj4+PiBUaGFua3MsIFJvZ2VyLg0KPj4+Pj4+Pj4+DQo+Pj4+
Pj4+Pj4gQW55IG90aGVyIHRob3VnaHRzIG9uIHRoaXM/IEFzIG9uIG9uZSBoYW5kIGl0IGlzIGFz
eW1tZXRyaWMgYnV0IGFsc28NCj4+Pj4+Pj4+PiB0aGVyZSBpc24ndCBtdWNoIGFzc2lzdGFuY2Ug
d2l0aCBvbmx5IHZpcnR1YWxpemVfeDJhcGljX21vZGUgc2V0IGFzLCBpbg0KPj4+Pj4+Pj4+IHRo
aXMgY2FzZSwgYSBWTSBleGl0IHdpbGwgYmUgYXZvaWRlZCBvbmx5IHdoZW4gdHJ5aW5nIHRvIGFj
Y2VzcyB0aGUgVFBSDQo+Pj4+Pj4+Pj4gcmVnaXN0ZXIuDQo+Pj4+Pj4+Pg0KPj4+Pj4+Pj4gSSd2
ZSBiZWVuIHRoaW5raW5nIGFib3V0IHRoaXMsIGFuZCByZXBvcnRpbmcgaGFyZHdhcmUgYXNzaXN0
ZWQNCj4+Pj4+Pj4+IHh7Mn1BUElDIHZpcnR1YWxpemF0aW9uIHdpdGgganVzdA0KPj4+Pj4+Pj4g
U0VDT05EQVJZX0VYRUNfVklSVFVBTElaRV9BUElDX0FDQ0VTU0VTIG9yDQo+Pj4+Pj4+PiBTRUNP
TkRBUllfRVhFQ19WSVJUVUFMSVpFX1gyQVBJQ19NT0RFIGRvZXNuJ3Qgc2VlbSB2ZXJ5IGhlbHBm
dWwuIFdoaWxlDQo+Pj4+Pj4+PiB0aG9zZSBwcm92aWRlIHNvbWUgYXNzaXN0YW5jZSB0byB0aGUg
Vk1NIGluIG9yZGVyIHRvIGhhbmRsZSBBUElDDQo+Pj4+Pj4+PiBhY2Nlc3NlcywgaXQgd2lsbCBz
dGlsbCByZXF1aXJlIGEgdHJhcCBpbnRvIHRoZSBoeXBlcnZpc29yIHRvIGhhbmRsZQ0KPj4+Pj4+
Pj4gbW9zdCBvZiB0aGUgYWNjZXNzZXMuDQo+Pj4+Pj4+Pg0KPj4+Pj4+Pj4gU28gbWF5YmUgd2Ug
c2hvdWxkIG9ubHkgcmVwb3J0IGhhcmR3YXJlIGFzc2lzdGVkIHN1cHBvcnQgd2hlbiB0aGUNCj4+
Pj4+Pj4+IG1lbnRpb25lZCBmZWF0dXJlcyBhcmUgcHJlc2VudCB0b2dldGhlciB3aXRoDQo+Pj4+
Pj4+PiBTRUNPTkRBUllfRVhFQ19BUElDX1JFR0lTVEVSX1ZJUlQ/DQo+Pj4+Pj4+DQo+Pj4+Pj4+
IE5vdCBzdXJlIC0gInNvbWUgYXNzaXN0YW5jZSIgc2VlbXMgc3RpbGwgYSBsaXR0bGUgYmV0dGVy
IHRoYW4gbm9uZSBhdCBhbGwuDQo+Pj4+Pj4+IFdoaWNoIHJvdXRlIHRvIGdvIGRlcGVuZHMgb24g
d2hhdCBleGFjdGx5IHdlIGludGVuZCB0aGUgYml0IHRvIGJlIHVzZWQgZm9yLg0KPj4+Pj4+Pg0K
Pj4+Pj4+IFRydWUuIEkgaW50ZW5kZWQgdGhpcyBiaXQgdG8gYmUgc3BlY2lmaWNhbGx5IGZvciBl
bmFibGluZw0KPj4+Pj4+IGFzc2lzdGVkX3h7Mn1hcGljLiBTbywgd291bGQgaXQgYmUgaW5jb25z
aXN0ZW50IHRvIHJlcG9ydCBoYXJkd2FyZQ0KPj4+Pj4+IGFzc2lzdGFuY2Ugd2l0aCBqdXN0IFZJ
UlRVQUxJWkVfQVBJQ19BQ0NFU1NFUyBvciBWSVJUVUFMSVpFX1gyQVBJQ19NT0RFDQo+Pj4+Pj4g
YnV0IHN0aWxsIGNsYWltIHRoYXQgeHsyfWFwaWMgaXMgdmlydHVhbGl6ZWQgaWYgbm8gTVNSIGFj
Y2Vzc2VzIGFyZQ0KPj4+Pj4+IGludGVyY2VwdGVkIHdpdGggWEVOX0hWTV9DUFVJRF9YMkFQSUNf
VklSVCAoaW4gdHJhcHMuYykgc28gdGhhdCwgYXMgeW91DQo+Pj4+Pj4gc2F5LCB0aGUgZ3Vlc3Qg
Z2V0cyBhdCBsZWFzdCAic29tZSBhc3Npc3RhbmNlIiBpbnN0ZWFkIG9mIG5vbmUgYnV0IHdlDQo+
Pj4+Pj4gc3RpbGwgY2xhaW0geHsyfWFwaWMgdmlydHVhbGl6YXRpb24gd2hlbiBpdCBpcyBhY3R1
YWxseSBjb21wbGV0ZT8gTWF5YmUNCj4+Pj4+PiBJIGNvdWxkIGFsc28gYWRkIGEgY29tbWVudCBh
bGx1ZGluZyB0byB0aGlzIGluIHRoZSB4bCBkb2N1bWVudGF0aW9uLg0KPj4+Pj4NCj4+Pj4+IFRv
IHJlcGhyYXNlIG15IGVhcmxpZXIgcG9pbnQ6IFdoaWNoIGtpbmQgb2YgZGVjaXNpb25zIGFyZSB0
aGUgY29uc3VtZXIocykNCj4+Pj4+IG9mIHVzIHJlcG9ydGluZyBoYXJkd2FyZSBhc3Npc3RhbmNl
IGdvaW5nIHRvIHRha2U/IEluIGhvdyBmYXIgaXMgdGhlcmUgYQ0KPj4+Pj4gcmlzayB0aGF0ICJz
b21lIGFzc2lzdGFuY2UiIGlzIG92ZXJhbGwgZ29pbmcgdG8gbGVhZCB0byBhIGxvc3Mgb2YNCj4+
Pj4+IHBlcmZvcm1hbmNlPyBJIGd1ZXNzIEknZCBuZWVkIHRvIHNlZSBjb21tZW50IGFuZCBhY3R1
YWwgY29kZSBhbGwgaW4gb25lDQo+Pj4+PiBwbGFjZSAuLi4NCj4+Pj4+DQo+Pj4+IFNvLCBJIHdh
cyB0aGlua2luZyBvZiBhZGRpbmcgc29tZXRoaW5nIGFsb25nIHRoZSBsaW5lcyBvZjoNCj4+Pj4N
Cj4+Pj4gKz1pdGVtIEI8YXNzaXN0ZWRfeGFwaWM9Qk9PTEVBTj4gQjwoeDg2IG9ubHkpPg0KPj4+
PiArRW5hYmxlcyBvciBkaXNhYmxlcyBoYXJkd2FyZSBhc3Npc3RlZCB2aXJ0dWFsaXphdGlvbiBm
b3IgeEFQSUMuIFRoaXMNCj4+Pj4gK2FsbG93cyBhY2Nlc3NpbmcgQVBJQyByZWdpc3RlcnMgd2l0
aG91dCBhIFZNLWV4aXQuIE5vdGljZSBlbmFibGluZw0KPj4+PiArdGhpcyBkb2VzIG5vdCBndWFy
YW50ZWUgZnVsbCB2aXJ0dWFsaXphdGlvbiBmb3IgeEFQSUMsIGFzIHRoaXMgY2FuDQo+Pj4+ICtv
bmx5IGJlIGFjaGlldmVkIGlmIGhhcmR3YXJlIHN1cHBvcnRzIOKAnEFQSUMtcmVnaXN0ZXIgdmly
dHVhbGl6YXRpb27igJ0NCj4+Pj4gK2FuZCDigJx2aXJ0dWFsLWludGVycnVwdCBkZWxpdmVyeeKA
nS4gVGhlIGRlZmF1bHQgaXMgc2V0dGFibGUgdmlhDQo+Pj4+ICtMPHhsLmNvbmYoNSk+Lg0KPj4+
DQo+Pj4gQnV0IGlzbid0IHRoaXMgY29udHJhZGljdG9yeT8gRG9lc24ndCBsYWNrIG9mIEFQSUMt
cmVnaXN0ZXIgdmlydHVhbGl6YXRpb24NCj4+PiBtZWFuIFZNIGV4aXRzIHVwb24gKG1vc3QpIGFj
Y2Vzc2VzPw0KPj4NCj4+IFllcywgaXQgZG9lcyBtZWFuLiBJIGd1ZXNzIHRoZSBhbHRlcm5hdGl2
ZSB3b3V1bGQgYmUgdGhlbiB0byByZXF1aXJlDQo+PiBBUElDLXJlZ2lzdGVyIHZpcnR1YWxpemF0
aW9uIGZvciBlbmFibGluZyB4QVBJQy4gQnV0IGFsc28sIGFsdGhvdWdoIHRoaXMNCj4+IGRvZXNu
J3QgcHJvdmlkZSBtdWNoIGFjY2VsZXJhdGlvbiwgZXZlbiBnZXR0aW5nIGEgVk0gZXhpdCBpcyBz
b21lDQo+PiBhc3Npc3RhbmNlIGlmIGNvbXBhcmVkIHRvIGluc3RlYWQgZ2V0dGluZyBhbiBFUFQg
ZmF1bHQgYW5kIGhhdmluZyB0bw0KPj4gZGVjb2RlIHRoZSBhY2Nlc3MuDQo+IA0KPiBJIGFncmVl
IGhlcmUsIGFsYmVpdCBJJ2QgbGlrZSB0byBtZW50aW9uIHRoYXQgRVBUIGZhdWx0cyBhcmUgYWxz
byBWTQ0KPiBleGl0cy4gQWxsIG15IGVhcmxpZXIgY29tbWVudCB3YXMgYWJvdXQgaXMgdGhhdCB0
aGlzIHBpZWNlIG9mIGRvYw0KPiB3YW50cyB0byBleHByZXNzIHJlYWxpdHksIHdoaWNoZXZlciB3
YXkgaXQgaXMgdGhhdCB0aGluZ3MgZW5kIHVwDQo+IGJlaW5nIGltcGxlbWVudGVkLg0KDQpPaCB5
ZXMuIFJpZ2h0LCBJIHNlZSBob3cgdGhpcyBpbmZvIGNvdWxkIGJlIG1pc2xlYWRpbmcuDQoNCkhv
dyBhYm91dCB0aGlzPy4uLg0KDQorPWl0ZW0gQjxhc3Npc3RlZF94YXBpYz1CT09MRUFOPiBCPCh4
ODYgb25seSk+DQorDQorQjwoeDg2IG9ubHkpPiBFbmFibGVzIG9yIGRpc2FibGVzIGhhcmR3YXJl
IGFzc2lzdGVkIHZpcnR1YWxpemF0aW9uIGZvcg0KK3hBUElDLiBXaXRoIHRoaXMgb3B0aW9uIGVu
YWJsZWQsIGEgbWVtb3J5LW1hcHBlZCBBUElDIGFjY2VzcyB3aWxsIGJlDQorZGVjb2RlZCBieSBo
YXJkd2FyZSBhbmQgZWl0aGVyIGlzc3VlIGEgVk0gZXhpdCB3aXRoIGFuIGV4aXQgcmVhc29uDQor
aW5zdGVhZCBvZiBhbiBFUFQgZmF1bHQgb3IgYWx0b2dldGhlciBhdm9pZCBhIFZNIGV4aXQuIE5v
dGljZQ0KK2Z1bGwgdmlydHVhbGl6YXRpb24gZm9yIHhBUElDIGNhbiBvbmx5IGJlIGFjaGlldmVk
IGlmIGhhcmR3YXJlDQorc3VwcG9ydHMg4oCcQVBJQy1yZWdpc3RlciB2aXJ0dWFsaXphdGlvbuKA
nSBhbmQg4oCcdmlydHVhbC1pbnRlcnJ1cHQNCitkZWxpdmVyeeKAnS4gVGhlIGRlZmF1bHQgaXMg
c2V0dGFibGUgdmlhIEw8eGwuY29uZig1KT4uDQoNCis9aXRlbSBCPGFzc2lzdGVkX3gyYXBpYz1C
T09MRUFOPg0KKw0KK0I8KHg4NiBvbmx5KT4gRW5hYmxlcyBvciBkaXNhYmxlcyBoYXJkd2FyZSBh
c3Npc3RlZCB2aXJ0dWFsaXphdGlvbiBmb3INCit4MkFQSUMuIFdpdGggdGhpcyBvcHRpb24gZW5h
YmxlZCwgYW4gTVNSLUJhc2VkIEFQSUMgYWNjZXNzIHdpbGwgZWl0aGVyDQoraXNzdWUgYSBWTSBl
eGl0IG9yIGFsdG9nZXRoZXIgYXZvaWQgb25lLiBOb3RpY2UgZnVsbCB2aXJ0dWFsaXphdGlvbg0K
K2ZvciB4MkFQSUMgY2FuIG9ubHkgYmUgYWNoaWV2ZWQgaWYgaGFyZHdhcmUgc3VwcG9ydHMg4oCc
QVBJQy1yZWdpc3Rlcg0KK3ZpcnR1YWxpemF0aW9u4oCdIGFuZCDigJx2aXJ0dWFsLWludGVycnVw
dCBkZWxpdmVyeeKAnS4gVGhlIGRlZmF1bHQgaXMNCitzZXR0YWJsZSB2aWEgTDx4bC5jb25mKDUp
Pi4NCg0KDQouLi5iZWNhdXNlIHdpdGggb25seSBWSVJUVUFMSVpFX0FQSUNfQUNDRVNTRVMgZW5h
YmxlZCwgaGFyZHdhcmUgZGVjb2RlcyANCmFjY2Vzc2VzIHRvIHRoZSB4QVBJQyBwYWdlIGFuZCB0
aGUgVk0gZXhpdCBnaXZlcyBhbiBleGl0IHJlYXNvbi4NCkFuZCBpZiBWSVJUVUFMSVpFX1gyQVBJ
Q19NT0RFIGlzIHNldCwgYWx0aG91Z2ggbm8gYXNzaXN0YW5jZSBpcyBwcm92aWRlZCANCncuci50
LiB0byBkZWNvZGluZyB4MkFQSUMgYWNjZXNzZXMgYXMgdGhlIE1TUiB0aGF0IHRoZSBWTSB0cmll
ZCB0byANCmFjY2VzcyBpcyBhbHJlYWR5IHBhcnQgb2YgdGhlIHZtZXhpdCBpbmZvcm1hdGlvbiwg
Vk0gZXhpdHMgZm9yIGFjY2Vzc2VzIA0KdG8gdGhlIFRQUiBNU1IgYXJlIGF2b2lkZWQsIHJlZ2Fy
ZGxlc3Mgb2Ygd2hldGhlciBzaGFkb3cgVFBSIGlzIHNldCBvciANCm5vdCBmb3IgZS5nLg0KDQpJ
IGhvcGUgdGhpcyBtYWtlcyBzZW5zZSBidXQgSSB3ZWxjb21lIGFueSBvdGhlciBzdWdnZXN0aW9u
cy9jb3JyZWN0aW9ucy4NCg0KVGhhbmsgeW91LA0KDQpKYW5lLg==


From xen-devel-bounces@lists.xenproject.org Tue Feb 15 15:12:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 15:12:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273291.468419 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJzVB-0006uf-Bu; Tue, 15 Feb 2022 15:12:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273291.468419; Tue, 15 Feb 2022 15:12:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJzVB-0006uW-8b; Tue, 15 Feb 2022 15:12:25 +0000
Received: by outflank-mailman (input) for mailman id 273291;
 Tue, 15 Feb 2022 15:12:23 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=p95L=S6=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nJzV9-0006u3-S8
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 15:12:23 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id acc5d41f-8e71-11ec-b215-9bbe72dcb22c;
 Tue, 15 Feb 2022 16:12:22 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2173.outbound.protection.outlook.com [104.47.17.173]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-17-DBko5ycjNwSKjeImIMk7zQ-1; Tue, 15 Feb 2022 16:12:21 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM6PR04MB6726.eurprd04.prod.outlook.com (2603:10a6:20b:fb::26)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.19; Tue, 15 Feb
 2022 15:12:18 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4975.015; Tue, 15 Feb 2022
 15:12:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: acc5d41f-8e71-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644937942;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=DC8CGbIVjiAu6uvxiyZ9QaOrQAizhVbxqCr/Ont0Wes=;
	b=IrvxQZCNGD8A5xXljt0QIX65Yj2jxE/qUfovYC7aWyfWFHtnz9TkOiDoky//VYfZ4uEOow
	Wu1d49YHXOmZDaywrf6/AXkdj7+B2khx3RcS+2Eg6urSqUW0l8RFGDe9fXQ4CoDLtwvyPG
	0rotIZ/e3702XxeWMjJXIpzO0+VPI/8=
X-MC-Unique: DBko5ycjNwSKjeImIMk7zQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=V9mDwBip2wo/I5dmBug1JoZNP/u+P5ylj85dxvhZCwsDkMC0Sy/PdxCjqMME2uAzkC05wnFUz47eRepsKWCAnydsFxu4IpRQ/21r6oM706zdGirSajw9XL1lpoTs+S9OLZXizPbBWKejm8kWsDAaK/z+4LnR9wpQ3EE1mqoP7UERXI81OHb/wdHbfrn9U1oSIzaL5qqrLajW/0brSU5qmACDmQKSLVqmzQUGCtx9EE4MX47R7PeFs5TmWYswijf33PatChLab700CtmnxdHEBAgvbosvot0KUYZkZX7kSBgHjlu4klrQ/GKAkMu60pG2JxDsywBq+euocOHLFnNLzw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=6OjA9TshIMqhKI2zeFdrZMHMll3Ah9QhgOmXJszO66I=;
 b=O2QatNcZkvceJqhu6CASAzpn7oxM3DuG3F6JR/T5YjA/CJfdyhgGHzs3Si2CSgk6JqzDYmiWHc8Lf+tkva08mqpWQkrAGUjM0EpKxMDWor9DZuLyXeE1it5FYyiNqXMdtbXWM0GWiOlvwzjt2w5JJr4P+9PmOuS11J0VLohlZp0uBCpA1yA8rGMjAtrhoQJv6UroHm4s62tdLorpMzn4LU2sISfQme1FAgNDU0FRAjbTGZua1sKkycQBLNolSpubbHCJUrsUPxMt2hk/TeSMix/zuzmSjb3J30eHTlVpG1HtAbYFIkt3NyVDfK+5DyFTlPWwT36KegTdIApWdZ3/Fw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <95c29039-302c-256b-d381-2b5b8b9c1a4a@suse.com>
Date: Tue, 15 Feb 2022 16:12:16 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH v2 07/70] x86: Build check for embedded endbr64
 instructions
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= <marmarek@invisiblethingslab.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
 <20220214125127.17985-8-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220214125127.17985-8-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR04CA0054.eurprd04.prod.outlook.com
 (2603:10a6:20b:46a::12) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 6e1226b5-e0fb-4159-9644-08d9f0958e9d
X-MS-TrafficTypeDiagnostic: AM6PR04MB6726:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB6726A8BCC84A3EAB406E1F7DB3349@AM6PR04MB6726.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:138;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	8cODcs/8w2pMEwdd3labD4w2XX3L6vT2zZirNYftleuMpIdkheBCASukY8l7A7GIu78a2Cg6nJskiyYXxoPMNvp1XNIhx6gTTu8Gi/jpLU/ELdlFYw22ExWM6sXplnL9med1zxhj6wrh3eT1eH9NKFNrH5Tv+IxA9Xp6EuZTRTQZWz6YdV/3dOXmQpcyOnMRbd6F5FLgToDdZPn3BzHnz3/9xuEFr/qYj27NlVeCIwUNlLIoMaQYdrCN1LaSPkFID4M2EOC6gO9f+ZJC7UlUYHAMJZzZ8XR8RAH1gAs7+AW1vf3zih3CHXcgQ4O1cvHoQco87tlqd6gmOpy29p2+eqMHfq9S9Z7bVMvBUwReQ9PhfJ4HRpSg+XsTEN7LknIxz2Vzt5UueYBrE3B+dckbWkiPMxxzzoFzHTox8IaPwcJhof8ebcCgQj0V1ea/hxT3CRmwu0NRlblya5K8sGQPtkV5OYEZeI2GRnMhmDkpKm8Fh7Tb4M7pPZhqAJOJ+XffKkYDh08SuZRvJz7WGXeEttU1RC3J3gn6U2uebBhLS9EAm1hfmPfHfgI1eYDsi7IlzPAiLz8gZYZcr70CjrGGqE0mI8HuPBFcvClCHe7chvg9agLc4c6a6+IsGM8YHu4FNPLcA1CkIpm3HDw+hrwwjvYDkHdYqebUcyOo09nDQ5vBXlTndNheUhQsORlF9isNhF/I4Mb5ANHd4mJeKEge3PgWHo5KMQYpE2hSm3gYfTg=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(26005)(186003)(508600001)(110136005)(2616005)(316002)(38100700002)(5660300002)(53546011)(86362001)(31696002)(6506007)(8936002)(6486002)(66946007)(83380400001)(8676002)(4326008)(66476007)(6512007)(2906002)(66556008)(31686004)(66574015)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?MBtHWAwUET1UU/O7Qqr6YjvnO/a+FabQ1rqP6FBfs4YD+gQywcoT2FfmFATA?=
 =?us-ascii?Q?smH11dlBPV1HL7L29JZacn7xDaqsdJOuafquRZ/iUcWzoBEGKl/w8fQVjx0q?=
 =?us-ascii?Q?52E7lTMK7cFyYFKhme3KEVbesDdoGrp1Iwa4cnZrnJ88U19GM3Wl8BUwfA8O?=
 =?us-ascii?Q?MRTD2uqLJQhD7v3B6aeIVWnJte9hcPbilUkk1fhVdP22sOciCNCuF0LHUpuZ?=
 =?us-ascii?Q?oElEy82K0ODwbJUoTLlufx0xy64j/xU3XiCylxgQsoDXz1OAtZJ2VyWxsM0U?=
 =?us-ascii?Q?Yw7ekzPfWgchKxsLXrm8vcaudt95y28Rz/aMR/Jlq7kELltr1Z8IW5LGczzi?=
 =?us-ascii?Q?Qu/xtsjKm11VZxBj9CZ8ATsmnA68GGSyiT79rCFvwFvtYD59lVYlasjM13qI?=
 =?us-ascii?Q?O5oPMfpIedZxegHA6roG+6qCnZO7LBUTzuXoxNHmhOJhhOS2Dji33x/b7d1T?=
 =?us-ascii?Q?iLNdTKsupIXIIjlh3HyrXdk81df1pO/x5EhO4ON2aqep3djach8Jms9kKrvx?=
 =?us-ascii?Q?IZjMCEx+zMEvg0NJpoPJ7cx8+iFzBYxmS5d3vjgByO2ThioGf4LN8hCpI47Z?=
 =?us-ascii?Q?zdNyeoZdc5N9Fmngw+CfPQjTTE6CiJS3c+sLZIouyKQXrwvHClvQHbKECua2?=
 =?us-ascii?Q?eahdTauYBdOz4XMOsTOBt3K53Y3J2xxYPcHGGSr2CPTHp+i3KPuR1rnMkVS2?=
 =?us-ascii?Q?tSVfjKqw/h+qng1YAYv7c4DGmoPNk7VlWhZSLCvY4YTuayQ8/kUGcGaLcAmB?=
 =?us-ascii?Q?OyaaPH7DQENedGjnAqw9klMPQyViJxsrrkgXbrrxbpc/jP77T1mjuq4hnTG1?=
 =?us-ascii?Q?Mnst9Pmdd0ux53oe9ZSWNhN0yxK6fNJzG0T4y3AaJC9bBHP01kW+9N6jGxYW?=
 =?us-ascii?Q?yoveyfOgSW41Vq0pOzP3PklvNjhOB9ffDcRG9SfLYGa1knv/umiEI1r5OVHH?=
 =?us-ascii?Q?NO8GNTN5d+lMf/j33uwflBlUy8QgO1cf0bty8LAOyP1YueXBlGhhrjPxD2pX?=
 =?us-ascii?Q?mBvqELKS9LuNwfAJ4tIGairLQCDcq43VM32knuxbcLpRkgXSCmoF0LErpe4W?=
 =?us-ascii?Q?9zbqu0X8VPiu/Fu0uQudKSkR9f9su/6NGxhrGnVlOYUfBi19ymLuApxa77xo?=
 =?us-ascii?Q?L9Y3HMjYerDSChrShjhGzqJWPgBxn3XKZ5gd+N7eDKv50kVZEEwJd4+uag88?=
 =?us-ascii?Q?gtXa0iuDdMLjPyG1/YKcacQoEGQSmqCPgdHtRs/6GMfWmcP2+0EO/yJsRZFF?=
 =?us-ascii?Q?6l6nCOw483ldaTxL9eWzeO1eA1B5sbiWfKEld0xI1ZBFciaeY8x1YkLEiVQa?=
 =?us-ascii?Q?cJTkh6E7U0AV1eRnn59dtNFf0KmpFAEf+CMu9bXLnK/0DRQZMmzLnLzOl++t?=
 =?us-ascii?Q?wjaVv1PDAUS88jfAK3/kGCWNOmQ9F1tu0u38rEPpPtEw8WTMZjcO2ojU+ac0?=
 =?us-ascii?Q?bt/WsdtgA3WPVGWinShYISx4WT2HoDFPwyf8CtEz2ljUnTmZk+JTFHGh2TYR?=
 =?us-ascii?Q?ns6LkFnlItnmqw8ztUGmE4E8RWGGUDiE3BkZSaHF4WWfUsakTmyrfB6DlSP5?=
 =?us-ascii?Q?Sh6byO/De0oxHIQH8BHhFTbh/wLSzWpJ8b8RYci+mpZESYSZvVc9VzEFfhNK?=
 =?us-ascii?Q?x7tl7TLtz5LrTku9I90GFho=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6e1226b5-e0fb-4159-9644-08d9f0958e9d
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 15:12:18.4683
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: okuYcMN9+bZsO/irNNFF0S0Xp83lu3uBvKjMdMxaTmnQ6zBWsb6s3zYWSxxdF0tan6fnp8YzVPN2Cgr1yi/Xcg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB6726

On 14.02.2022 13:50, Andrew Cooper wrote:
> From: Marek Marczykowski-G=C3=B3recki <marmarek@invisiblethingslab.com>
>=20
> Embedded endbr64 instructions mark legal indirect branches as far as the =
CPU
> is concerned, which aren't legal as far as the logic is concerned.

I think it would help if it was clarified what "embedded" actually means
here.

> --- a/xen/arch/x86/Makefile
> +++ b/xen/arch/x86/Makefile
> @@ -155,6 +155,9 @@ $(TARGET)-syms: prelink.o xen.lds
>  	$(MAKE) -f $(BASEDIR)/Rules.mk $(@D)/.$(@F).1.o
>  	$(LD) $(XEN_LDFLAGS) -T xen.lds -N prelink.o $(build_id_linker) \
>  	    $(@D)/.$(@F).1.o -o $@
> +ifeq ($(CONFIG_XEN_IBT),y)
> +	$(SHELL) $(BASEDIR)/tools/check-endbr.sh $@
> +endif
>  	$(NM) -pa --format=3Dsysv $(@D)/$(@F) \
>  		| $(BASEDIR)/tools/symbols --all-symbols --xensyms --sysv --sort \
>  		>$(@D)/$(@F).map

The same wants doing on xen.efi, I guess?

> --- /dev/null
> +++ b/xen/tools/check-endbr.sh
> @@ -0,0 +1,76 @@
> +#!/bin/sh
> +
> +#
> +# Usage ./$0 xen-syms
> +#
> +
> +set -e
> +
> +OBJCOPY=3D"${OBJCOPY:-objcopy} -j .text $1"
> +OBJDUMP=3D"${OBJDUMP:-objdump} -j .text $1"
> +
> +D=3D$(mktemp -d)
> +trap "rm -rf $D" EXIT
> +
> +TEXT_BIN=3D$D/xen-syms.text
> +VALID=3D$D/valid-addrs
> +ALL=3D$D/all-addrs
> +BAD=3D$D/bad-addrs
> +
> +#
> +# First, look for all the valid endbr64 instructions.
> +# A worst-case disassembly, viewed through cat -A, may look like:
> +#
> +# ffff82d040337bd4 <endbr64>:$
> +# ffff82d040337bd4:^If3 0f 1e fa          ^Iendbr64 $
> +# ffff82d040337bd8:^Ieb fe                ^Ijmp    ffff82d040337bd8 <end=
br64+0x4>$
> +# ffff82d040337bda:^Ib8 f3 0f 1e fa       ^Imov    $0xfa1e0ff3,%eax$
> +#
> +# Want to grab the address of endbr64 instructions only, ignoring functi=
on
> +# names/jump labels/etc, so look for 'endbr64' preceeded by a tab and wi=
th any
> +# number of trailing spaces before the end of the line.
> +#
> +${OBJDUMP} -d | grep '	endbr64 *$' | cut -f 1 -d ':' > $VALID &

Since you look at only .text the risk of the disassembler coming
out of sync with the actual instruction stream is lower than when
32- and 16-bit code was also part of what is disassembled, but it's
not zero. Any zero-padding inserted anywhere by the linker can
result in an immediately following ENDBR to be missed (because
sequences of zeros resemble 2-byte insns). While this risk may be
acceptable, I think it wants mentioning at least in the description,
maybe even at the top of the script (where one would likely look
first after it spitting out an error).

Do you perhaps want to also pass -w to objdump, to eliminate the
risk of getting confused by split lines?

> +#
> +# Second, look for any endbr64 byte sequence
> +# This has a couple of complications:
> +#
> +# 1) Grep binary search isn't VMA aware.  Copy .text out as binary, caus=
ing
> +#    the grep offset to be from the start of .text.
> +#
> +# 2) AWK can't add 64bit integers, because internally all numbers are do=
ubles.
> +#    When the upper bits are set, the exponents worth of precision is lo=
st in
> +#    the lower bits, rounding integers to the nearest 4k.
> +#
> +#    Instead, use the fact that Xen's .text is within a 1G aligned regio=
n, and
> +#    split the VMA in half so AWK's numeric addition is only working on =
32 bit
> +#    numbers, which don't lose precision.
> +#
> +eval $(${OBJDUMP} -h | awk '$2 =3D=3D ".text" {printf "vma_hi=3D%s\nvma_=
lo=3D%s\n", substr($4, 1, 8), substr($4, 9, 16)}')
> +
> +${OBJCOPY} -O binary $TEXT_BIN
> +grep -aob "$(printf '\363\17\36\372')" $TEXT_BIN |
> +    awk -F':' '{printf "%s%x\n", "'$vma_hi'", strtonum(0x'$vma_lo') + $1=
}' > $ALL

None of the three options passed to grep look to be standardized.
Is this going to cause problems on non-Linux systems? Should this
checking perhaps be put behind a separate Kconfig option?

> +# Wait for $VALID to become complete
> +wait
> +
> +# Sanity check $VALID and $ALL, in case the string parsing bitrots
> +val_sz=3D$(stat -c '%s' $VALID)
> +all_sz=3D$(stat -c '%s' $ALL)
> +[ "$val_sz" -eq 0 ]         && { echo "Error: Empty valid-addrs" >&2; ex=
it 1; }
> +[ "$all_sz" -eq 0 ]         && { echo "Error: Empty all-addrs" >&2; exit=
 1; }
> +[ "$all_sz" -lt "$val_sz" ] && { echo "Error: More valid-addrs than all-=
addrs" >&2; exit 1; }
> +
> +# $BAD =3D $ALL - $VALID
> +join -v 2 $VALID $ALL > $BAD
> +nr_bad=3D$(wc -l < $BAD)
> +
> +# Success
> +[ "$nr_bad" -eq 0 ] && exit 0
> +
> +# Failure
> +echo "Fail: Found ${nr_bad} embedded endbr64 instructions" >&2
> +addr2line -afip -e $1 < $BAD >&2

There probably also wants to be an ADDR2LINE variable then. If
one overrides objdump and objcopy, one would likely want/need to
override this one as well.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Feb 15 15:21:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 15:21:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273302.468431 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJzdm-0008Rz-Co; Tue, 15 Feb 2022 15:21:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273302.468431; Tue, 15 Feb 2022 15:21:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJzdm-0008Rs-9X; Tue, 15 Feb 2022 15:21:18 +0000
Received: by outflank-mailman (input) for mailman id 273302;
 Tue, 15 Feb 2022 15:21:17 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=p95L=S6=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nJzdl-0008Rm-LW
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 15:21:17 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id eaac2518-8e72-11ec-b215-9bbe72dcb22c;
 Tue, 15 Feb 2022 16:21:15 +0100 (CET)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2106.outbound.protection.outlook.com [104.47.18.106]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-38-txbCxrkNOIinvfSL7Ydjcw-1; Tue, 15 Feb 2022 16:21:14 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM9PR04MB8146.eurprd04.prod.outlook.com (2603:10a6:20b:3ea::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.19; Tue, 15 Feb
 2022 15:21:11 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4975.015; Tue, 15 Feb 2022
 15:21:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: eaac2518-8e72-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644938475;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=mVYyXNlz+eUTKUaImCCi+2YvqtL+8wAtJKZF8Z58ZAM=;
	b=WsCBCo9a8ssvssn96Kv+HMnLRtRGvKoyrJFEO87tAfOVmE+jVmtsegsd0euLBk++vJmQUR
	GDOYENCRGmBRl+8ab6Q4VL4jZgxNFvTw5l/XY1V53+UOz2Yelfo1mFMuahLOQ3nbkMLN5/
	MnmSpce27QZPxMhXsVXfDNH2RAOP3iI=
X-MC-Unique: txbCxrkNOIinvfSL7Ydjcw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Xq4jI+Gmr2+f/0RNwS1T3APPlPk+kghLtIbMCZ7N2aMmU7qTs7+aHMVdWpitxDKAZnEmDB8GFKpYZNvjfsKUe53v4V8/CROJXrjO7+pYKbQLgFwHAdEwWbICiDsjkMuSTJtPWURaaanN+f+4rjdc8Ig3WxWQJZ80iBvFw1PLqsJxpbpOL9UpNRFCoTKIpRZt9kXe56WALQMXyjp0ZYI+ZaGZNnZrXl+yXSagtdxzgUSdt/hQCAh8C8f9e8Teho5VKQw4dN6j3REyvUu8RNtNQUa4H3b2L4WdXQryeZq1USXwpzDV7F/Brr1AD4RAExJyrvBk71Z7Fpn5AYAKAhYp0w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=pT/s0DHryS9jpcUeZjhi23fefi2zohL4auKOBEk71DA=;
 b=WxCikzkUfA1tiykBvKXnvF0kw30UxYyjnFW2NzPd03diWQuN7fbsaGAX7eXi8WF9/c03BXMSh85FtC1KgZ53X9z8jbXfLr3Wy0JMHC+BKxgRsiVcUPYG4i0ty92IQMw0AOARYqlSlYkotORbXCrIl5Fwy4Z3C4nJzH2CblVtH964+OaIutkT8e4jtk8zxg+GNMXKKcWXh11Jol/HQ1pWet4n92n/HSdxTOfOB86ecAbA9aa6o1Zo5n+iQsh3BTPcMP6AragrIlB7MhYXem4gZ6EHXWn6V8NnKNpUaZjat9I+nwH+jC2pmXRd4D0pMbGDdSo10cln6QMHXX0wApILnw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <7fbc16f6-4175-06e8-742c-9aa8c7eb3e91@suse.com>
Date: Tue, 15 Feb 2022 16:21:09 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH v2 1/2] xen+tools: Report Interrupt Controller
 Virtualization capabilities on x86
Content-Language: en-US
To: Jane Malalane <Jane.Malalane@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>,
 Anthony Perard <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 George Dunlap <George.Dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Jun Nakajima <jun.nakajima@intel.com>, Kevin Tian <kevin.tian@intel.com>,
 Roger Pau Monne <roger.pau@citrix.com>,
 Andrew Cooper <Andrew.Cooper3@citrix.com>
References: <20220207182101.31941-1-jane.malalane@citrix.com>
 <20220207182101.31941-2-jane.malalane@citrix.com>
 <YgTi6bzeojtcu0xL@Air-de-Roger>
 <dff9c5c0-7bee-ce0d-3288-91255a701c99@citrix.com>
 <YgZIo9VQktcqGHTD@Air-de-Roger>
 <6d924061-f2fd-5f3d-0f98-79e76398b908@suse.com>
 <6c9400b8-7c76-34c8-f69e-3fad1eb53b8c@citrix.com>
 <101b0950-b7f2-119b-b654-574a71cec3bc@suse.com>
 <1bac0507-9420-f0b9-f846-f1c73bf9678d@citrix.com>
 <42fb3257-0c36-c156-c81b-f70dd5f247aa@suse.com>
 <9721222d-1c0d-ddaf-fbc6-801f5d9445f5@citrix.com>
 <12727658-68f4-1785-9b37-c948eb2cba71@suse.com>
 <9ed50d7a-23c7-2405-ff5e-15cc02b0c67f@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <9ed50d7a-23c7-2405-ff5e-15cc02b0c67f@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0252.eurprd06.prod.outlook.com
 (2603:10a6:20b:45f::27) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d0dbc66b-33d1-4bb3-5869-08d9f096cc7e
X-MS-TrafficTypeDiagnostic: AM9PR04MB8146:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<AM9PR04MB8146712AB4FCC302CE29309EB3349@AM9PR04MB8146.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	wXVPetlkPiiFcpAPZNFw/lz+tKZHP4bpNUCUqBo4li33QO1CKo59975R1xGfyajZoZkCOANWCnYx33O6cJtbDvIDBtUL9Y0+YjmBbH/TD/CGCkSFp9xBkRNfKY7vp3U/xapqPqncKpetzmHtfHSg/f613I2ekMuxV4T+c8xyrX3RtpqApWsfNqK45O5xvQ69wo96nmrYRVq+m856JP6H2VKrzCh8gNCH9jYuHhPGjJ+XzI2KBGdHeJZMF2mL+OQmbtwUwDZkeq4EKsY7HzuvKv9hQZo3vj/0Jcdj7XdVZZxvMnbgbtsjfFkw0Lp7p+Px1fm0FoK1NEzUaGG6uyeRPhey5sAUIVdgH1PNqidstN8zdDpuv5gJPNEyEmWeFvN7xdF4QmvnEOv74HTzbvApeyvFLmOVe4Kg1dMAgFvuZWEARv3rU9Jtw1prtXfjQjlb9X4nR/7GITRSa19m1n1ZuCL+3rQ27eA3DXQcGkmN/NhpFTacUyNdOQF3itsiPmdPbHSszweZKe/EnpVDHWD1Uz4RszU1Dl6Mm9WulLL9phHKgG86mzrExqNSdbBsVmTLYwFPPYnAbMxHCEuduMq+9P2uymnh170jaFEcU4Yr54nJNqYU5DIMzl6WWUtAiq0A/W0D3nU7p9MVMVOGt7rD+KN8ydc+OS1tkrNLhsMz3kvrML2YpFBKEU/eMxhdRBtyeJTB6keg6QBQihkn8O/9xzAV2G6EKnDOjjzgGzwTep9kBwfKM8/3AxiU+FA7X+MQ
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(54906003)(66946007)(6486002)(6916009)(5660300002)(31696002)(86362001)(8936002)(38100700002)(8676002)(4326008)(316002)(7416002)(66556008)(66476007)(508600001)(26005)(83380400001)(53546011)(186003)(6506007)(2616005)(6512007)(31686004)(36756003)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?YTyqmuCnf9ywMB4aqIP96k7Bmq1xwoSw0A11MkiFITs0iBueQLIF3VNQcPPQ?=
 =?us-ascii?Q?h0NVemhbtoHX3KWQb/7yR4lYnVU4CnJ9mWcvoD6Fkw9XoAuKhe9xT62pzF4W?=
 =?us-ascii?Q?T6kSPWWja+aF4eqFac3dzEocX9b8vGUY/OWDar/eDYBg77Gk3xkZDup0ihEM?=
 =?us-ascii?Q?oC8xerVQg4HRWgJGhHeQ+nKT2PgEvUtLaYZDfPl/SmFzLeXyYxOH5w/f+58d?=
 =?us-ascii?Q?SIgotBSdcD4bz/I5mTPdwa3jFx+Mg1MeoSjoABYgSeyDPAL0nD7Cu5hdsBp9?=
 =?us-ascii?Q?r8rqVv+JeUnNP4KqGltDMTT3s43/heMZZ9OREnT1fzKGIbyyEYrNWz3be5Ax?=
 =?us-ascii?Q?nx+FC1xjkPwHd5qHFhya94F/lhu3sv5czpsNDbNycv6JxdiAaxFOqbjA6kdY?=
 =?us-ascii?Q?kFwi7HeO6dbxLBIAVcbsGFSYnvrmvNgBEBqGzGeBQjXbnfbKK5TKUf81RzN1?=
 =?us-ascii?Q?NFOK0sELktrbhXh5cKYF+6HzohF5VR5iZjtqX3hIYovI29Id5wa5fsPEz+h5?=
 =?us-ascii?Q?NvTv6fX0/VyboPibL4CLXhgSe/DCrIEDAP43027lW1mjPYGhpZTyU+L5Pln4?=
 =?us-ascii?Q?HfAlcAErsJERrJWUO/QWIZA6jk4rxtV8B5HNdZz3pDfxU9t5tn1AlzCn3H9t?=
 =?us-ascii?Q?616tYs8SEfjeOW97+PxUD5ZSyJjDnnrNvbkMlEDNDAV0e0mAABQowpqo6cXC?=
 =?us-ascii?Q?F6fkSkic1tZ2ZuB0UILt+Xz56lo2WWgkTKX5HWN4kO6Oj7We9UfWy70GecT2?=
 =?us-ascii?Q?ZurCy4NBsZDReW/zcTuCcVJfBuDvjVFZGF9TObSGdcnuDdqPprVqPPW5Spp7?=
 =?us-ascii?Q?p/rTug2cmoXFPX3THD9lgk2ELEI8na2WclN0OKEEDUSM8USADpHJWmfJEyIl?=
 =?us-ascii?Q?yYwOxCebbJQBL84mv8IWUsiCw42hCh8zz4DW5mlPOXtWJVO8u1EYlJUGEiuZ?=
 =?us-ascii?Q?UW8WwTLoqI0C+qpwgCQpLKWWdepTHLMuai2/QjqC2MLbh0qJ0aoj+JqG8H5X?=
 =?us-ascii?Q?ugwAUQVdX28TTSQpq3iryMeHQ9XdVW/TF6PHrsqwQ8nKRZJez/iycn77Zasi?=
 =?us-ascii?Q?F3eBaRpTGketLxfp7dJE5Uog7NoKaOR3zmS9dkYpLEacMqGa9NFmykzeGoVs?=
 =?us-ascii?Q?yHPDEsF2vectNF9RNhKyRIj61S7bw/mj6/bLd2JLaff4VoNn7wLmHW8+ebh+?=
 =?us-ascii?Q?Z0NJMBqwSYw6BkhMcOPRU+ApSkfxHDRmoD9Lm79gUrJccNaEag43ksv0Tp8T?=
 =?us-ascii?Q?imVLFg2wqSExO7BkxGCTdDqt1ZxQBu4Gk6f/MbK9iKCKWvbPhTUQXUE19gvA?=
 =?us-ascii?Q?4iBXZgYQLY1oBqmf7wwU36QqhBuo9IW/OuOo/V+98lNfpJzJF18vFeEq3UUs?=
 =?us-ascii?Q?LTo475qfQ5jBb636BEIbVnp7wFjVvq/7kSAy4FWxZJ0+4Z8p4sq2MPimBVW2?=
 =?us-ascii?Q?SrUvXoVO5PxJgnh1+79pgzlY0IbKEBd/0m/EVxr5Pip3sHadYLj1rpv+pU9J?=
 =?us-ascii?Q?WE+mOvASwnBj6aG0txSKKUkoJGxO8DqNdYgMPO3BzUFKgqVfnydbfExUHV45?=
 =?us-ascii?Q?HGnsY5n0DHviwuDMIEaxrj07zOvRfJyInNYgwHnUHnBpIeH5PjlaRC7oYXWH?=
 =?us-ascii?Q?7MVCbJnCURkmdfSfcUji+To=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d0dbc66b-33d1-4bb3-5869-08d9f096cc7e
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 15:21:11.7478
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ex1ib9trXZ2FY+Vsrz/ePG/l0ObkSZTAXzB4iV1WcyYz5y/8W4ESgUV0Hack4dajEZ/YVsVD//onZOpR6LjfYw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8146

On 15.02.2022 16:10, Jane Malalane wrote:
> On 15/02/2022 10:19, Jan Beulich wrote:
>> [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachment=
s unless you have verified the sender and know the content is safe.
>>
>> On 15.02.2022 11:14, Jane Malalane wrote:
>>> On 15/02/2022 07:09, Jan Beulich wrote:
>>>> [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachme=
nts unless you have verified the sender and know the content is safe.
>>>>
>>>> On 14.02.2022 18:09, Jane Malalane wrote:
>>>>> On 14/02/2022 13:18, Jan Beulich wrote:
>>>>>> [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attach=
ments unless you have verified the sender and know the content is safe.
>>>>>>
>>>>>> On 14.02.2022 14:11, Jane Malalane wrote:
>>>>>>> On 11/02/2022 11:46, Jan Beulich wrote:
>>>>>>>> [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open atta=
chments unless you have verified the sender and know the content is safe.
>>>>>>>>
>>>>>>>> On 11.02.2022 12:29, Roger Pau Monn=C3=A9 wrote:
>>>>>>>>> On Fri, Feb 11, 2022 at 10:06:48AM +0000, Jane Malalane wrote:
>>>>>>>>>> On 10/02/2022 10:03, Roger Pau Monn=C3=A9 wrote:
>>>>>>>>>>> On Mon, Feb 07, 2022 at 06:21:00PM +0000, Jane Malalane wrote:
>>>>>>>>>>>> diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vm=
x/vmcs.c
>>>>>>>>>>>> index 7ab15e07a0..4060aef1bd 100644
>>>>>>>>>>>> --- a/xen/arch/x86/hvm/vmx/vmcs.c
>>>>>>>>>>>> +++ b/xen/arch/x86/hvm/vmx/vmcs.c
>>>>>>>>>>>> @@ -343,6 +343,15 @@ static int vmx_init_vmcs_config(bool bsp)
>>>>>>>>>>>>                   MSR_IA32_VMX_PROCBASED_CTLS2, &mismatch);
>>>>>>>>>>>>           }
>>>>>>>>>>>>      =20
>>>>>>>>>>>> +    /* Check whether hardware supports accelerated xapic and =
x2apic. */
>>>>>>>>>>>> +    if ( bsp )
>>>>>>>>>>>> +    {
>>>>>>>>>>>> +        assisted_xapic_available =3D cpu_has_vmx_virtualize_a=
pic_accesses;
>>>>>>>>>>>> +        assisted_x2apic_available =3D (cpu_has_vmx_apic_reg_v=
irt ||
>>>>>>>>>>>> +                                     cpu_has_vmx_virtual_intr=
_delivery) &&
>>>>>>>>>>>> +                                    cpu_has_vmx_virtualize_x2=
apic_mode;
>>>>>>>>>>>
>>>>>>>>>>> I've been think about this, and it seems kind of asymmetric tha=
t for
>>>>>>>>>>> xAPIC mode we report hw assisted support only with
>>>>>>>>>>> virtualize_apic_accesses available, while for x2APIC we require
>>>>>>>>>>> virtualize_x2apic_mode plus either apic_reg_virt or
>>>>>>>>>>> virtual_intr_delivery.
>>>>>>>>>>>
>>>>>>>>>>> I think we likely need to be more consistent here, and report h=
w
>>>>>>>>>>> assisted x2APIC support as long as virtualize_x2apic_mode is
>>>>>>>>>>> available.
>>>>>>>>>>>
>>>>>>>>>>> This will likely have some effect on patch 2 also, as you will =
have to
>>>>>>>>>>> adjust vmx_vlapic_msr_changed.
>>>>>>>>>>>
>>>>>>>>>>> Thanks, Roger.
>>>>>>>>>>
>>>>>>>>>> Any other thoughts on this? As on one hand it is asymmetric but =
also
>>>>>>>>>> there isn't much assistance with only virtualize_x2apic_mode set=
 as, in
>>>>>>>>>> this case, a VM exit will be avoided only when trying to access =
the TPR
>>>>>>>>>> register.
>>>>>>>>>
>>>>>>>>> I've been thinking about this, and reporting hardware assisted
>>>>>>>>> x{2}APIC virtualization with just
>>>>>>>>> SECONDARY_EXEC_VIRTUALIZE_APIC_ACCESSES or
>>>>>>>>> SECONDARY_EXEC_VIRTUALIZE_X2APIC_MODE doesn't seem very helpful. =
While
>>>>>>>>> those provide some assistance to the VMM in order to handle APIC
>>>>>>>>> accesses, it will still require a trap into the hypervisor to han=
dle
>>>>>>>>> most of the accesses.
>>>>>>>>>
>>>>>>>>> So maybe we should only report hardware assisted support when the
>>>>>>>>> mentioned features are present together with
>>>>>>>>> SECONDARY_EXEC_APIC_REGISTER_VIRT?
>>>>>>>>
>>>>>>>> Not sure - "some assistance" seems still a little better than none=
 at all.
>>>>>>>> Which route to go depends on what exactly we intend the bit to be =
used for.
>>>>>>>>
>>>>>>> True. I intended this bit to be specifically for enabling
>>>>>>> assisted_x{2}apic. So, would it be inconsistent to report hardware
>>>>>>> assistance with just VIRTUALIZE_APIC_ACCESSES or VIRTUALIZE_X2APIC_=
MODE
>>>>>>> but still claim that x{2}apic is virtualized if no MSR accesses are
>>>>>>> intercepted with XEN_HVM_CPUID_X2APIC_VIRT (in traps.c) so that, as=
 you
>>>>>>> say, the guest gets at least "some assistance" instead of none but =
we
>>>>>>> still claim x{2}apic virtualization when it is actually complete? M=
aybe
>>>>>>> I could also add a comment alluding to this in the xl documentation=
.
>>>>>>
>>>>>> To rephrase my earlier point: Which kind of decisions are the consum=
er(s)
>>>>>> of us reporting hardware assistance going to take? In how far is the=
re a
>>>>>> risk that "some assistance" is overall going to lead to a loss of
>>>>>> performance? I guess I'd need to see comment and actual code all in =
one
>>>>>> place ...
>>>>>>
>>>>> So, I was thinking of adding something along the lines of:
>>>>>
>>>>> +=3Ditem B<assisted_xapic=3DBOOLEAN> B<(x86 only)>
>>>>> +Enables or disables hardware assisted virtualization for xAPIC. This
>>>>> +allows accessing APIC registers without a VM-exit. Notice enabling
>>>>> +this does not guarantee full virtualization for xAPIC, as this can
>>>>> +only be achieved if hardware supports =E2=80=9CAPIC-register virtual=
ization=E2=80=9D
>>>>> +and =E2=80=9Cvirtual-interrupt delivery=E2=80=9D. The default is set=
table via
>>>>> +L<xl.conf(5)>.
>>>>
>>>> But isn't this contradictory? Doesn't lack of APIC-register virtualiza=
tion
>>>> mean VM exits upon (most) accesses?
>>>
>>> Yes, it does mean. I guess the alternative wouuld be then to require
>>> APIC-register virtualization for enabling xAPIC. But also, although thi=
s
>>> doesn't provide much acceleration, even getting a VM exit is some
>>> assistance if compared to instead getting an EPT fault and having to
>>> decode the access.
>>
>> I agree here, albeit I'd like to mention that EPT faults are also VM
>> exits. All my earlier comment was about is that this piece of doc
>> wants to express reality, whichever way it is that things end up
>> being implemented.
>=20
> Oh yes. Right, I see how this info could be misleading.
>=20
> How about this?...

Getting close. The thing I can't judge is whether this level of technical
detail is suitable for this doc. Just one further remark:

> +=3Ditem B<assisted_xapic=3DBOOLEAN> B<(x86 only)>
> +
> +B<(x86 only)> Enables or disables hardware assisted virtualization for
> +xAPIC. With this option enabled, a memory-mapped APIC access will be
> +decoded by hardware and either issue a VM exit with an exit reason
> +instead of an EPT fault or altogether avoid a VM exit. Notice

As said before, EPT faults also are VM exits and also provide an exit
reason. Therefore maybe "... and either issue a VM exit with a more
specific exit reason than an EPT fault would provide, or altogether
avoid a VM exit" or "... and either issue a more specific VM exit than
just an EPT fault, or altogether avoid a VM exit"?

Jan

> +full virtualization for xAPIC can only be achieved if hardware
> +supports =E2=80=9CAPIC-register virtualization=E2=80=9D and =E2=80=9Cvir=
tual-interrupt
> +delivery=E2=80=9D. The default is settable via L<xl.conf(5)>.
>=20
> +=3Ditem B<assisted_x2apic=3DBOOLEAN>
> +
> +B<(x86 only)> Enables or disables hardware assisted virtualization for
> +x2APIC. With this option enabled, an MSR-Based APIC access will either
> +issue a VM exit or altogether avoid one. Notice full virtualization
> +for x2APIC can only be achieved if hardware supports =E2=80=9CAPIC-regis=
ter
> +virtualization=E2=80=9D and =E2=80=9Cvirtual-interrupt delivery=E2=80=9D=
. The default is
> +settable via L<xl.conf(5)>.
>=20
>=20
> ...because with only VIRTUALIZE_APIC_ACCESSES enabled, hardware decodes=20
> accesses to the xAPIC page and the VM exit gives an exit reason.
> And if VIRTUALIZE_X2APIC_MODE is set, although no assistance is provided=
=20
> w.r.t. to decoding x2APIC accesses as the MSR that the VM tried to=20
> access is already part of the vmexit information, VM exits for accesses=20
> to the TPR MSR are avoided, regardless of whether shadow TPR is set or=20
> not for e.g.
>=20
> I hope this makes sense but I welcome any other suggestions/corrections.
>=20
> Thank you,
>=20
> Jane.



From xen-devel-bounces@lists.xenproject.org Tue Feb 15 15:25:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 15:25:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273309.468442 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJzhu-0000fe-VC; Tue, 15 Feb 2022 15:25:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273309.468442; Tue, 15 Feb 2022 15:25:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJzhu-0000fX-R1; Tue, 15 Feb 2022 15:25:34 +0000
Received: by outflank-mailman (input) for mailman id 273309;
 Tue, 15 Feb 2022 15:25:33 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=FJ8a=S6=arm.com=rahul.singh@srs-se1.protection.inumbo.net>)
 id 1nJzht-0000fR-HH
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 15:25:33 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id 834485fc-8e73-11ec-8eb8-a37418f5ba1a;
 Tue, 15 Feb 2022 16:25:32 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 305511396;
 Tue, 15 Feb 2022 07:25:31 -0800 (PST)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E06133F66F;
 Tue, 15 Feb 2022 07:25:29 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 834485fc-8e73-11ec-8eb8-a37418f5ba1a
From: Rahul Singh <rahul.singh@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Wei Liu <wl@xen.org>,
	George Dunlap <george.dunlap@citrix.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: [PATCH v2 0/3] xen/vpci: msix: Make VPCI MSI-X code non-x86 specific
Date: Tue, 15 Feb 2022 15:25:15 +0000
Message-Id: <cover.1644937405.git.rahul.singh@arm.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

This patch series is v2 of preparatory work to make VPCI MSI-X code non-x86
specific.

Rahul Singh (3):
  xen/vpci: msix: move x86 specific code to x86 file
  xen/vpci: msix: change return value of vpci_msix_{read,write}
  xen/vpci: msix: move read/write call to MSI-X PBA entry to arch file

 xen/arch/x86/hvm/vmsi.c             | 155 +++++++++++++++++++++++++++
 xen/arch/x86/include/asm/msi.h      |  28 -----
 xen/arch/x86/msi.c                  |   2 +-
 xen/drivers/passthrough/amd/iommu.h |   1 +
 xen/drivers/vpci/msi.c              |   3 +-
 xen/drivers/vpci/msix.c             | 158 +++-------------------------
 xen/include/xen/msi.h               |  28 +++++
 xen/include/xen/vpci.h              |  19 ++++
 8 files changed, 222 insertions(+), 172 deletions(-)

-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Tue Feb 15 15:26:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 15:26:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273314.468452 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJzia-0001CQ-6c; Tue, 15 Feb 2022 15:26:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273314.468452; Tue, 15 Feb 2022 15:26:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJzia-0001CJ-3I; Tue, 15 Feb 2022 15:26:16 +0000
Received: by outflank-mailman (input) for mailman id 273314;
 Tue, 15 Feb 2022 15:26:14 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=FJ8a=S6=arm.com=rahul.singh@srs-se1.protection.inumbo.net>)
 id 1nJziY-00014w-CS
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 15:26:14 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 9bb87121-8e73-11ec-b215-9bbe72dcb22c;
 Tue, 15 Feb 2022 16:26:12 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2ABBE1396;
 Tue, 15 Feb 2022 07:26:12 -0800 (PST)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C4CA13F66F;
 Tue, 15 Feb 2022 07:26:10 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9bb87121-8e73-11ec-b215-9bbe72dcb22c
From: Rahul Singh <rahul.singh@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Wei Liu <wl@xen.org>,
	George Dunlap <george.dunlap@citrix.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: [PATCH v2 1/3] xen/vpci: msix: move x86 specific code to x86 file
Date: Tue, 15 Feb 2022 15:25:16 +0000
Message-Id: <4d2a727ba218468e4f347dc12ca051a0534fe205.1644937405.git.rahul.singh@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <cover.1644937405.git.rahul.singh@arm.com>
References: <cover.1644937405.git.rahul.singh@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

vpci/msix.c file will be used for arm architecture when vpci msix
support will be added to ARM, but there is x86 specific code in this
file.

Move x86 specific code to the x86/hvm/vmsi.c file to make sure common
code will be used for other architecture.

No functional change intended.

Signed-off-by: Rahul Singh <rahul.singh@arm.com>
---
Changes since v1:
 - Split return value of vpci_msix_{read,write} to separate patch.
 - Fix the {read,write}{l,q} call in common code to move to arch specific file. 
---
 xen/arch/x86/hvm/vmsi.c             | 102 ++++++++++++++++++++++++++++
 xen/arch/x86/include/asm/msi.h      |  28 --------
 xen/arch/x86/msi.c                  |   2 +-
 xen/drivers/passthrough/amd/iommu.h |   1 +
 xen/drivers/vpci/msi.c              |   3 +-
 xen/drivers/vpci/msix.c             | 101 +++------------------------
 xen/include/xen/msi.h               |  28 ++++++++
 xen/include/xen/vpci.h              |  13 ++++
 8 files changed, 154 insertions(+), 124 deletions(-)

diff --git a/xen/arch/x86/hvm/vmsi.c b/xen/arch/x86/hvm/vmsi.c
index 13e2a190b4..17426f238c 100644
--- a/xen/arch/x86/hvm/vmsi.c
+++ b/xen/arch/x86/hvm/vmsi.c
@@ -925,4 +925,106 @@ int vpci_msix_arch_print(const struct vpci_msix *msix)
 
     return 0;
 }
+
+int vpci_make_msix_hole(const struct pci_dev *pdev)
+{
+    struct domain *d = pdev->domain;
+    unsigned int i;
+
+    if ( !pdev->vpci->msix )
+        return 0;
+
+    /* Make sure there's a hole for the MSIX table/PBA in the p2m. */
+    for ( i = 0; i < ARRAY_SIZE(pdev->vpci->msix->tables); i++ )
+    {
+        unsigned long start = PFN_DOWN(vmsix_table_addr(pdev->vpci, i));
+        unsigned long end = PFN_DOWN(vmsix_table_addr(pdev->vpci, i) +
+                                     vmsix_table_size(pdev->vpci, i) - 1);
+
+        for ( ; start <= end; start++ )
+        {
+            p2m_type_t t;
+            mfn_t mfn = get_gfn_query(d, start, &t);
+
+            switch ( t )
+            {
+            case p2m_mmio_dm:
+            case p2m_invalid:
+                break;
+            case p2m_mmio_direct:
+                if ( mfn_x(mfn) == start )
+                {
+                    clear_identity_p2m_entry(d, start);
+                    break;
+                }
+                /* fallthrough. */
+            default:
+                put_gfn(d, start);
+                gprintk(XENLOG_WARNING,
+                        "%pp: existing mapping (mfn: %" PRI_mfn
+                        "type: %d) at %#lx clobbers MSIX MMIO area\n",
+                        &pdev->sbdf, mfn_x(mfn), t, start);
+                return -EEXIST;
+            }
+            put_gfn(d, start);
+        }
+    }
+
+    return 0;
+}
+
+struct vpci_msix *vpci_msix_find(const struct domain *d, unsigned long addr)
+{
+    struct vpci_msix *msix;
+
+    list_for_each_entry ( msix, &d->arch.hvm.msix_tables, next )
+    {
+        const struct vpci_bar *bars = msix->pdev->vpci->header.bars;
+        unsigned int i;
+
+        for ( i = 0; i < ARRAY_SIZE(msix->tables); i++ )
+            if ( bars[msix->tables[i] & PCI_MSIX_BIRMASK].enabled &&
+                 VMSIX_ADDR_IN_RANGE(addr, msix->pdev->vpci, i) )
+                return msix;
+    }
+
+    return NULL;
+}
+
+static int x86_msix_accept(struct vcpu *v, unsigned long addr)
+{
+    return !!vpci_msix_find(v->domain, addr);
+}
+
+static int x86_msix_write(struct vcpu *v, unsigned long addr, unsigned int len,
+                          unsigned long data)
+{
+    const struct domain *d = v->domain;
+    struct vpci_msix *msix = vpci_msix_find(d, addr);
+
+    return vpci_msix_write(msix, addr, len, data);
+}
+
+static int x86_msix_read(struct vcpu *v, unsigned long addr, unsigned int len,
+                         unsigned long *data)
+{
+    const struct domain *d = v->domain;
+    struct vpci_msix *msix = vpci_msix_find(d, addr);
+
+    return vpci_msix_read(msix, addr, len, data);
+}
+
+static const struct hvm_mmio_ops vpci_msix_table_ops = {
+    .check = x86_msix_accept,
+    .read = x86_msix_read,
+    .write = x86_msix_write,
+};
+
+void vpci_msix_arch_register(struct vpci_msix *msix, struct domain *d)
+{
+    if ( list_empty(&d->arch.hvm.msix_tables) )
+        register_mmio_handler(d, &vpci_msix_table_ops);
+
+    list_add(&msix->next, &d->arch.hvm.msix_tables);
+}
 #endif /* CONFIG_HAS_VPCI */
diff --git a/xen/arch/x86/include/asm/msi.h b/xen/arch/x86/include/asm/msi.h
index e228b0f3f3..0a7912e9be 100644
--- a/xen/arch/x86/include/asm/msi.h
+++ b/xen/arch/x86/include/asm/msi.h
@@ -148,34 +148,6 @@ int msi_free_irq(struct msi_desc *entry);
  */
 #define NR_HP_RESERVED_VECTORS 	20
 
-#define msi_control_reg(base)		(base + PCI_MSI_FLAGS)
-#define msi_lower_address_reg(base)	(base + PCI_MSI_ADDRESS_LO)
-#define msi_upper_address_reg(base)	(base + PCI_MSI_ADDRESS_HI)
-#define msi_data_reg(base, is64bit)	\
-	( (is64bit == 1) ? base+PCI_MSI_DATA_64 : base+PCI_MSI_DATA_32 )
-#define msi_mask_bits_reg(base, is64bit) \
-	( (is64bit == 1) ? base+PCI_MSI_MASK_BIT : base+PCI_MSI_MASK_BIT-4)
-#define msi_pending_bits_reg(base, is64bit) \
-	((base) + PCI_MSI_MASK_BIT + ((is64bit) ? 4 : 0))
-#define msi_disable(control)		control &= ~PCI_MSI_FLAGS_ENABLE
-#define multi_msi_capable(control) \
-	(1 << ((control & PCI_MSI_FLAGS_QMASK) >> 1))
-#define multi_msi_enable(control, num) \
-	control |= (((fls(num) - 1) << 4) & PCI_MSI_FLAGS_QSIZE);
-#define is_64bit_address(control)	(!!(control & PCI_MSI_FLAGS_64BIT))
-#define is_mask_bit_support(control)	(!!(control & PCI_MSI_FLAGS_MASKBIT))
-#define msi_enable(control, num) multi_msi_enable(control, num); \
-	control |= PCI_MSI_FLAGS_ENABLE
-
-#define msix_control_reg(base)		(base + PCI_MSIX_FLAGS)
-#define msix_table_offset_reg(base)	(base + PCI_MSIX_TABLE)
-#define msix_pba_offset_reg(base)	(base + PCI_MSIX_PBA)
-#define msix_enable(control)	 	control |= PCI_MSIX_FLAGS_ENABLE
-#define msix_disable(control)	 	control &= ~PCI_MSIX_FLAGS_ENABLE
-#define msix_table_size(control) 	((control & PCI_MSIX_FLAGS_QSIZE)+1)
-#define msix_unmask(address)	 	(address & ~PCI_MSIX_VECTOR_BITMASK)
-#define msix_mask(address)		(address | PCI_MSIX_VECTOR_BITMASK)
-
 /*
  * MSI Defined Data Structures
  */
diff --git a/xen/arch/x86/msi.c b/xen/arch/x86/msi.c
index 5febc0ea4b..62fd7351dd 100644
--- a/xen/arch/x86/msi.c
+++ b/xen/arch/x86/msi.c
@@ -20,10 +20,10 @@
 #include <xen/iocap.h>
 #include <xen/keyhandler.h>
 #include <xen/pfn.h>
+#include <xen/msi.h>
 #include <asm/io.h>
 #include <asm/smp.h>
 #include <asm/desc.h>
-#include <asm/msi.h>
 #include <asm/fixmap.h>
 #include <asm/p2m.h>
 #include <mach_apic.h>
diff --git a/xen/drivers/passthrough/amd/iommu.h b/xen/drivers/passthrough/amd/iommu.h
index 93243424e8..f007a0c083 100644
--- a/xen/drivers/passthrough/amd/iommu.h
+++ b/xen/drivers/passthrough/amd/iommu.h
@@ -26,6 +26,7 @@
 #include <xen/tasklet.h>
 #include <xen/sched.h>
 #include <xen/domain_page.h>
+#include <xen/msi.h>
 
 #include <asm/msi.h>
 #include <asm/apicdef.h>
diff --git a/xen/drivers/vpci/msi.c b/xen/drivers/vpci/msi.c
index 5757a7aed2..8fc82a9b8d 100644
--- a/xen/drivers/vpci/msi.c
+++ b/xen/drivers/vpci/msi.c
@@ -16,12 +16,11 @@
  * License along with this program; If not, see <http://www.gnu.org/licenses/>.
  */
 
+#include <xen/msi.h>
 #include <xen/sched.h>
 #include <xen/softirq.h>
 #include <xen/vpci.h>
 
-#include <asm/msi.h>
-
 static uint32_t control_read(const struct pci_dev *pdev, unsigned int reg,
                              void *data)
 {
diff --git a/xen/drivers/vpci/msix.c b/xen/drivers/vpci/msix.c
index 846f1b8d70..d89396a3b4 100644
--- a/xen/drivers/vpci/msix.c
+++ b/xen/drivers/vpci/msix.c
@@ -17,16 +17,12 @@
  * License along with this program; If not, see <http://www.gnu.org/licenses/>.
  */
 
+#include <xen/msi.h>
 #include <xen/sched.h>
 #include <xen/vpci.h>
 
-#include <asm/msi.h>
 #include <asm/p2m.h>
 
-#define VMSIX_ADDR_IN_RANGE(addr, vpci, nr)                               \
-    ((addr) >= vmsix_table_addr(vpci, nr) &&                              \
-     (addr) < vmsix_table_addr(vpci, nr) + vmsix_table_size(vpci, nr))
-
 static uint32_t control_read(const struct pci_dev *pdev, unsigned int reg,
                              void *data)
 {
@@ -138,29 +134,6 @@ static void control_write(const struct pci_dev *pdev, unsigned int reg,
         pci_conf_write16(pdev->sbdf, reg, val);
 }
 
-static struct vpci_msix *msix_find(const struct domain *d, unsigned long addr)
-{
-    struct vpci_msix *msix;
-
-    list_for_each_entry ( msix, &d->arch.hvm.msix_tables, next )
-    {
-        const struct vpci_bar *bars = msix->pdev->vpci->header.bars;
-        unsigned int i;
-
-        for ( i = 0; i < ARRAY_SIZE(msix->tables); i++ )
-            if ( bars[msix->tables[i] & PCI_MSIX_BIRMASK].enabled &&
-                 VMSIX_ADDR_IN_RANGE(addr, msix->pdev->vpci, i) )
-                return msix;
-    }
-
-    return NULL;
-}
-
-static int msix_accept(struct vcpu *v, unsigned long addr)
-{
-    return !!msix_find(v->domain, addr);
-}
-
 static bool access_allowed(const struct pci_dev *pdev, unsigned long addr,
                            unsigned int len)
 {
@@ -182,11 +155,9 @@ static struct vpci_msix_entry *get_entry(struct vpci_msix *msix,
     return &msix->entries[(addr - start) / PCI_MSIX_ENTRY_SIZE];
 }
 
-static int msix_read(struct vcpu *v, unsigned long addr, unsigned int len,
-                     unsigned long *data)
+int vpci_msix_read(struct vpci_msix *msix, unsigned long addr,
+                   unsigned int len, unsigned long *data)
 {
-    const struct domain *d = v->domain;
-    struct vpci_msix *msix = msix_find(d, addr);
     const struct vpci_msix_entry *entry;
     unsigned int offset;
 
@@ -259,11 +230,10 @@ static int msix_read(struct vcpu *v, unsigned long addr, unsigned int len,
     return X86EMUL_OKAY;
 }
 
-static int msix_write(struct vcpu *v, unsigned long addr, unsigned int len,
-                      unsigned long data)
+int vpci_msix_write(struct vpci_msix *msix, unsigned long addr,
+                    unsigned int len, unsigned long data)
 {
-    const struct domain *d = v->domain;
-    struct vpci_msix *msix = msix_find(d, addr);
+    const struct domain *d = msix->pdev->domain;
     struct vpci_msix_entry *entry;
     unsigned int offset;
 
@@ -375,59 +345,6 @@ static int msix_write(struct vcpu *v, unsigned long addr, unsigned int len,
     return X86EMUL_OKAY;
 }
 
-static const struct hvm_mmio_ops vpci_msix_table_ops = {
-    .check = msix_accept,
-    .read = msix_read,
-    .write = msix_write,
-};
-
-int vpci_make_msix_hole(const struct pci_dev *pdev)
-{
-    struct domain *d = pdev->domain;
-    unsigned int i;
-
-    if ( !pdev->vpci->msix )
-        return 0;
-
-    /* Make sure there's a hole for the MSIX table/PBA in the p2m. */
-    for ( i = 0; i < ARRAY_SIZE(pdev->vpci->msix->tables); i++ )
-    {
-        unsigned long start = PFN_DOWN(vmsix_table_addr(pdev->vpci, i));
-        unsigned long end = PFN_DOWN(vmsix_table_addr(pdev->vpci, i) +
-                                     vmsix_table_size(pdev->vpci, i) - 1);
-
-        for ( ; start <= end; start++ )
-        {
-            p2m_type_t t;
-            mfn_t mfn = get_gfn_query(d, start, &t);
-
-            switch ( t )
-            {
-            case p2m_mmio_dm:
-            case p2m_invalid:
-                break;
-            case p2m_mmio_direct:
-                if ( mfn_x(mfn) == start )
-                {
-                    clear_identity_p2m_entry(d, start);
-                    break;
-                }
-                /* fallthrough. */
-            default:
-                put_gfn(d, start);
-                gprintk(XENLOG_WARNING,
-                        "%pp: existing mapping (mfn: %" PRI_mfn
-                        "type: %d) at %#lx clobbers MSIX MMIO area\n",
-                        &pdev->sbdf, mfn_x(mfn), t, start);
-                return -EEXIST;
-            }
-            put_gfn(d, start);
-        }
-    }
-
-    return 0;
-}
-
 static int init_msix(struct pci_dev *pdev)
 {
     struct domain *d = pdev->domain;
@@ -472,11 +389,9 @@ static int init_msix(struct pci_dev *pdev)
         vpci_msix_arch_init_entry(&msix->entries[i]);
     }
 
-    if ( list_empty(&d->arch.hvm.msix_tables) )
-        register_mmio_handler(d, &vpci_msix_table_ops);
-
     pdev->vpci->msix = msix;
-    list_add(&msix->next, &d->arch.hvm.msix_tables);
+
+    vpci_msix_arch_register(msix, d);
 
     return 0;
 }
diff --git a/xen/include/xen/msi.h b/xen/include/xen/msi.h
index c903d0050c..c5c8e65feb 100644
--- a/xen/include/xen/msi.h
+++ b/xen/include/xen/msi.h
@@ -3,6 +3,34 @@
 
 #include <xen/pci.h>
 
+#define msi_control_reg(base)       (base + PCI_MSI_FLAGS)
+#define msi_lower_address_reg(base) (base + PCI_MSI_ADDRESS_LO)
+#define msi_upper_address_reg(base) (base + PCI_MSI_ADDRESS_HI)
+#define msi_data_reg(base, is64bit) \
+	( (is64bit) ? (base) + PCI_MSI_DATA_64 : (base) + PCI_MSI_DATA_32 )
+#define msi_mask_bits_reg(base, is64bit) \
+	( (is64bit) ? (base) + PCI_MSI_MASK_BIT : (base) + PCI_MSI_MASK_BIT - 4)
+#define msi_pending_bits_reg(base, is64bit) \
+	( (is64bit) ? (base) + PCI_MSI_MASK_BIT + 4 : (base) + PCI_MSI_MASK_BIT)
+#define msi_disable(control)        control &= ~PCI_MSI_FLAGS_ENABLE
+#define multi_msi_capable(control) \
+	(1 << ((control & PCI_MSI_FLAGS_QMASK) >> 1))
+#define multi_msi_enable(control, num) \
+	control |= (((fls(num) - 1) << 4) & PCI_MSI_FLAGS_QSIZE);
+#define is_64bit_address(control)   (!!(control & PCI_MSI_FLAGS_64BIT))
+#define is_mask_bit_support(control)    (!!(control & PCI_MSI_FLAGS_MASKBIT))
+#define msi_enable(control, num) multi_msi_enable(control, num); \
+	control |= PCI_MSI_FLAGS_ENABLE
+
+#define msix_control_reg(base)      (base + PCI_MSIX_FLAGS)
+#define msix_table_offset_reg(base) (base + PCI_MSIX_TABLE)
+#define msix_pba_offset_reg(base)   (base + PCI_MSIX_PBA)
+#define msix_enable(control)        control |= PCI_MSIX_FLAGS_ENABLE
+#define msix_disable(control)       control &= ~PCI_MSIX_FLAGS_ENABLE
+#define msix_table_size(control)    ((control & PCI_MSIX_FLAGS_QSIZE)+1)
+#define msix_unmask(address)        (address & ~PCI_MSIX_VECTOR_BITMASK)
+#define msix_mask(address)          (address | PCI_MSIX_VECTOR_BITMASK)
+
 #ifdef CONFIG_HAS_PCI_MSI
 
 #include <asm/msi.h>
diff --git a/xen/include/xen/vpci.h b/xen/include/xen/vpci.h
index e8ac1eb395..0381a2c911 100644
--- a/xen/include/xen/vpci.h
+++ b/xen/include/xen/vpci.h
@@ -148,6 +148,11 @@ struct vpci_vcpu {
 };
 
 #ifdef __XEN__
+
+#define VMSIX_ADDR_IN_RANGE(addr, vpci, nr)                               \
+    ((addr) >= vmsix_table_addr(vpci, nr) &&                              \
+     (addr) < vmsix_table_addr(vpci, nr) + vmsix_table_size(vpci, nr))
+
 void vpci_dump_msi(void);
 
 /* Make sure there's a hole in the p2m for the MSIX mmio areas. */
@@ -218,6 +223,14 @@ bool vpci_ecam_write(pci_sbdf_t sbdf, unsigned int reg, unsigned int len,
 bool vpci_ecam_read(pci_sbdf_t sbdf, unsigned int reg, unsigned int len,
                     unsigned long *data);
 
+void vpci_msix_arch_register(struct vpci_msix *msix, struct domain *d);
+
+int vpci_msix_write(struct vpci_msix *msix, unsigned long addr,
+                    unsigned int len, unsigned long data);
+
+int vpci_msix_read(struct vpci_msix *msix, unsigned long addr,
+                   unsigned int len, unsigned long *data);
+
 #endif /* __XEN__ */
 
 #else /* !CONFIG_HAS_VPCI */
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Tue Feb 15 15:27:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 15:27:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273323.468463 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJzjS-0001qh-LD; Tue, 15 Feb 2022 15:27:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273323.468463; Tue, 15 Feb 2022 15:27:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJzjS-0001qa-IA; Tue, 15 Feb 2022 15:27:10 +0000
Received: by outflank-mailman (input) for mailman id 273323;
 Tue, 15 Feb 2022 15:27:09 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=FJ8a=S6=arm.com=rahul.singh@srs-se1.protection.inumbo.net>)
 id 1nJzjR-0001qG-67
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 15:27:09 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id bc8d6a1d-8e73-11ec-b215-9bbe72dcb22c;
 Tue, 15 Feb 2022 16:27:08 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 545621396;
 Tue, 15 Feb 2022 07:27:07 -0800 (PST)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 609393F66F;
 Tue, 15 Feb 2022 07:27:06 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bc8d6a1d-8e73-11ec-b215-9bbe72dcb22c
From: Rahul Singh <rahul.singh@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Wei Liu <wl@xen.org>
Subject: [PATCH v2 2/3] xen/vpci: msix: change return value of vpci_msix_{read,write}
Date: Tue, 15 Feb 2022 15:25:17 +0000
Message-Id: <a17cd73b221aaeaf6ab449f83aa7918d83642e54.1644937405.git.rahul.singh@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <cover.1644937405.git.rahul.singh@arm.com>
References: <cover.1644937405.git.rahul.singh@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Return value is different for the MMIO handler on ARM and x86
architecture.

To make the code common for both architectures change the return value
of vpci_msix_{read, write} to bool. Architecture-specific return value
will be handled in arch code.

Signed-off-by: Rahul Singh <rahul.singh@arm.com>
---
Changes since v1:
 - Added in this version
---
 xen/arch/x86/hvm/vmsi.c | 10 ++++++++--
 xen/drivers/vpci/msix.c | 24 ++++++++++++------------
 xen/include/xen/vpci.h  |  8 ++++----
 3 files changed, 24 insertions(+), 18 deletions(-)

diff --git a/xen/arch/x86/hvm/vmsi.c b/xen/arch/x86/hvm/vmsi.c
index 17426f238c..761ce674d7 100644
--- a/xen/arch/x86/hvm/vmsi.c
+++ b/xen/arch/x86/hvm/vmsi.c
@@ -1002,7 +1002,10 @@ static int x86_msix_write(struct vcpu *v, unsigned long addr, unsigned int len,
     const struct domain *d = v->domain;
     struct vpci_msix *msix = vpci_msix_find(d, addr);
 
-    return vpci_msix_write(msix, addr, len, data);
+    if( !vpci_msix_write(msix, addr, len, data) )
+        return X86EMUL_RETRY;
+
+    return X86EMUL_OKAY;
 }
 
 static int x86_msix_read(struct vcpu *v, unsigned long addr, unsigned int len,
@@ -1011,7 +1014,10 @@ static int x86_msix_read(struct vcpu *v, unsigned long addr, unsigned int len,
     const struct domain *d = v->domain;
     struct vpci_msix *msix = vpci_msix_find(d, addr);
 
-    return vpci_msix_read(msix, addr, len, data);
+    if ( !vpci_msix_read(msix, addr, len, data) )
+        return X86EMUL_RETRY;
+
+    return X86EMUL_OKAY;
 }
 
 static const struct hvm_mmio_ops vpci_msix_table_ops = {
diff --git a/xen/drivers/vpci/msix.c b/xen/drivers/vpci/msix.c
index d89396a3b4..5b315757ef 100644
--- a/xen/drivers/vpci/msix.c
+++ b/xen/drivers/vpci/msix.c
@@ -155,8 +155,8 @@ static struct vpci_msix_entry *get_entry(struct vpci_msix *msix,
     return &msix->entries[(addr - start) / PCI_MSIX_ENTRY_SIZE];
 }
 
-int vpci_msix_read(struct vpci_msix *msix, unsigned long addr,
-                   unsigned int len, unsigned long *data)
+bool vpci_msix_read(struct vpci_msix *msix, unsigned long addr,
+                    unsigned int len, unsigned long *data)
 {
     const struct vpci_msix_entry *entry;
     unsigned int offset;
@@ -164,10 +164,10 @@ int vpci_msix_read(struct vpci_msix *msix, unsigned long addr,
     *data = ~0ul;
 
     if ( !msix )
-        return X86EMUL_RETRY;
+        return false;
 
     if ( !access_allowed(msix->pdev, addr, len) )
-        return X86EMUL_OKAY;
+        return true;
 
     if ( VMSIX_ADDR_IN_RANGE(addr, msix->pdev->vpci, VPCI_MSIX_PBA) )
     {
@@ -193,7 +193,7 @@ int vpci_msix_read(struct vpci_msix *msix, unsigned long addr,
             break;
         }
 
-        return X86EMUL_OKAY;
+        return true;
     }
 
     spin_lock(&msix->pdev->vpci->lock);
@@ -227,21 +227,21 @@ int vpci_msix_read(struct vpci_msix *msix, unsigned long addr,
     }
     spin_unlock(&msix->pdev->vpci->lock);
 
-    return X86EMUL_OKAY;
+    return true;
 }
 
-int vpci_msix_write(struct vpci_msix *msix, unsigned long addr,
-                    unsigned int len, unsigned long data)
+bool vpci_msix_write(struct vpci_msix *msix, unsigned long addr,
+                     unsigned int len, unsigned long data)
 {
     const struct domain *d = msix->pdev->domain;
     struct vpci_msix_entry *entry;
     unsigned int offset;
 
     if ( !msix )
-        return X86EMUL_RETRY;
+        return false;
 
     if ( !access_allowed(msix->pdev, addr, len) )
-        return X86EMUL_OKAY;
+        return true;
 
     if ( VMSIX_ADDR_IN_RANGE(addr, msix->pdev->vpci, VPCI_MSIX_PBA) )
     {
@@ -264,7 +264,7 @@ int vpci_msix_write(struct vpci_msix *msix, unsigned long addr,
             }
         }
 
-        return X86EMUL_OKAY;
+        return true;
     }
 
     spin_lock(&msix->pdev->vpci->lock);
@@ -342,7 +342,7 @@ int vpci_msix_write(struct vpci_msix *msix, unsigned long addr,
     }
     spin_unlock(&msix->pdev->vpci->lock);
 
-    return X86EMUL_OKAY;
+    return true;
 }
 
 static int init_msix(struct pci_dev *pdev)
diff --git a/xen/include/xen/vpci.h b/xen/include/xen/vpci.h
index 0381a2c911..1c36845abf 100644
--- a/xen/include/xen/vpci.h
+++ b/xen/include/xen/vpci.h
@@ -225,11 +225,11 @@ bool vpci_ecam_read(pci_sbdf_t sbdf, unsigned int reg, unsigned int len,
 
 void vpci_msix_arch_register(struct vpci_msix *msix, struct domain *d);
 
-int vpci_msix_write(struct vpci_msix *msix, unsigned long addr,
-                    unsigned int len, unsigned long data);
+bool vpci_msix_write(struct vpci_msix *msix, unsigned long addr,
+                     unsigned int len, unsigned long data);
 
-int vpci_msix_read(struct vpci_msix *msix, unsigned long addr,
-                   unsigned int len, unsigned long *data);
+bool vpci_msix_read(struct vpci_msix *msix, unsigned long addr,
+                    unsigned int len, unsigned long *data);
 
 #endif /* __XEN__ */
 
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Tue Feb 15 15:27:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 15:27:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273328.468475 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJzjp-0002PX-Ty; Tue, 15 Feb 2022 15:27:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273328.468475; Tue, 15 Feb 2022 15:27:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJzjp-0002PQ-Qq; Tue, 15 Feb 2022 15:27:33 +0000
Received: by outflank-mailman (input) for mailman id 273328;
 Tue, 15 Feb 2022 15:27:33 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=FJ8a=S6=arm.com=rahul.singh@srs-se1.protection.inumbo.net>)
 id 1nJzjo-0002Eg-UI
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 15:27:33 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id cabc574d-8e73-11ec-8eb8-a37418f5ba1a;
 Tue, 15 Feb 2022 16:27:31 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2450A1396;
 Tue, 15 Feb 2022 07:27:31 -0800 (PST)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2FD3A3F66F;
 Tue, 15 Feb 2022 07:27:30 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cabc574d-8e73-11ec-8eb8-a37418f5ba1a
From: Rahul Singh <rahul.singh@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Wei Liu <wl@xen.org>
Subject: [PATCH v2 3/3] xen/vpci: msix: move read/write call to MSI-X PBA entry to arch file
Date: Tue, 15 Feb 2022 15:25:18 +0000
Message-Id: <3e47316052dce3c85bde04ab6b72ba4f48fa0bb8.1644937405.git.rahul.singh@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <cover.1644937405.git.rahul.singh@arm.com>
References: <cover.1644937405.git.rahul.singh@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

{read,write}{l,q} function argument is different for ARM and x86.
ARM {read,wrie}(l,q} function argument is pointer whereas X86
{read,wrie}(l,q} function argument is address itself.

{read,write}{l,q} is only used in common file to access the MSI-X PBA
structure. To avoid impacting other x86 code and to make the code common
move the read/write call to MSI-X PBA to arch specific file.

Signed-off-by: Rahul Singh <rahul.singh@arm.com>
---
Changes since v1:
 - Added in this version
---
 xen/arch/x86/hvm/vmsi.c | 47 +++++++++++++++++++++++++++++++++++++++++
 xen/drivers/vpci/msix.c | 43 ++-----------------------------------
 xen/include/xen/vpci.h  |  6 ++++++
 3 files changed, 55 insertions(+), 41 deletions(-)

diff --git a/xen/arch/x86/hvm/vmsi.c b/xen/arch/x86/hvm/vmsi.c
index 761ce674d7..f124a1d07d 100644
--- a/xen/arch/x86/hvm/vmsi.c
+++ b/xen/arch/x86/hvm/vmsi.c
@@ -1033,4 +1033,51 @@ void vpci_msix_arch_register(struct vpci_msix *msix, struct domain *d)
 
     list_add(&msix->next, &d->arch.hvm.msix_tables);
 }
+
+bool vpci_msix_arch_pba_read(unsigned long addr, unsigned int len,
+                             unsigned long *data)
+{
+    /*
+     * Access to PBA.
+     *
+     * TODO: note that this relies on having the PBA identity mapped to the
+     * guest address space. If this changes the address will need to be
+     * translated.
+     */
+    switch ( len )
+    {
+    case 4:
+        *data = readl(addr);
+        break;
+
+    case 8:
+        *data = readq(addr);
+        break;
+
+    default:
+        ASSERT_UNREACHABLE();
+        break;
+    }
+
+    return true;
+}
+
+void vpci_msix_arch_pba_write(unsigned long addr, unsigned int len,
+                              unsigned long data)
+{
+    switch ( len )
+    {
+    case 4:
+        writel(data, addr);
+        break;
+
+    case 8:
+        writeq(data, addr);
+        break;
+
+    default:
+        ASSERT_UNREACHABLE();
+        break;
+    }
+}
 #endif /* CONFIG_HAS_VPCI */
diff --git a/xen/drivers/vpci/msix.c b/xen/drivers/vpci/msix.c
index 5b315757ef..b6720f1a1a 100644
--- a/xen/drivers/vpci/msix.c
+++ b/xen/drivers/vpci/msix.c
@@ -170,31 +170,7 @@ bool vpci_msix_read(struct vpci_msix *msix, unsigned long addr,
         return true;
 
     if ( VMSIX_ADDR_IN_RANGE(addr, msix->pdev->vpci, VPCI_MSIX_PBA) )
-    {
-        /*
-         * Access to PBA.
-         *
-         * TODO: note that this relies on having the PBA identity mapped to the
-         * guest address space. If this changes the address will need to be
-         * translated.
-         */
-        switch ( len )
-        {
-        case 4:
-            *data = readl(addr);
-            break;
-
-        case 8:
-            *data = readq(addr);
-            break;
-
-        default:
-            ASSERT_UNREACHABLE();
-            break;
-        }
-
-        return true;
-    }
+        return vpci_msix_arch_pba_read(addr, len, data);
 
     spin_lock(&msix->pdev->vpci->lock);
     entry = get_entry(msix, addr);
@@ -247,22 +223,7 @@ bool vpci_msix_write(struct vpci_msix *msix, unsigned long addr,
     {
         /* Ignore writes to PBA for DomUs, it's behavior is undefined. */
         if ( is_hardware_domain(d) )
-        {
-            switch ( len )
-            {
-            case 4:
-                writel(data, addr);
-                break;
-
-            case 8:
-                writeq(data, addr);
-                break;
-
-            default:
-                ASSERT_UNREACHABLE();
-                break;
-            }
-        }
+            vpci_msix_arch_pba_write(addr, len, data);
 
         return true;
     }
diff --git a/xen/include/xen/vpci.h b/xen/include/xen/vpci.h
index 1c36845abf..a61daf9d53 100644
--- a/xen/include/xen/vpci.h
+++ b/xen/include/xen/vpci.h
@@ -231,6 +231,12 @@ bool vpci_msix_write(struct vpci_msix *msix, unsigned long addr,
 bool vpci_msix_read(struct vpci_msix *msix, unsigned long addr,
                     unsigned int len, unsigned long *data);
 
+bool vpci_msix_arch_pba_read(unsigned long addr, unsigned int len,
+                             unsigned long *data);
+
+void vpci_msix_arch_pba_write(unsigned long addr, unsigned int len,
+                              unsigned long data);
+
 #endif /* __XEN__ */
 
 #else /* !CONFIG_HAS_VPCI */
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Tue Feb 15 15:36:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 15:36:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273339.468486 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJzsi-0003xl-Qz; Tue, 15 Feb 2022 15:36:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273339.468486; Tue, 15 Feb 2022 15:36:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJzsi-0003xe-Nn; Tue, 15 Feb 2022 15:36:44 +0000
Received: by outflank-mailman (input) for mailman id 273339;
 Tue, 15 Feb 2022 15:36:43 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=FJ8a=S6=arm.com=rahul.singh@srs-se1.protection.inumbo.net>)
 id 1nJzsh-0003xY-Kt
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 15:36:43 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 128d41e4-8e75-11ec-b215-9bbe72dcb22c;
 Tue, 15 Feb 2022 16:36:41 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 133091396;
 Tue, 15 Feb 2022 07:36:41 -0800 (PST)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 365B33F66F;
 Tue, 15 Feb 2022 07:36:40 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 128d41e4-8e75-11ec-b215-9bbe72dcb22c
From: Rahul Singh <rahul.singh@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH v2] xen/arm: vpci: remove PCI I/O ranges property value
Date: Tue, 15 Feb 2022 15:36:32 +0000
Message-Id: <8ea25f00c8641bfd95a4d8444b82ca2ac3ee5ce0.1644939115.git.rahul.singh@arm.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

PCI I/O space are not mapped to dom0 when PCI passthrough is enabled,
also there is no vpci trap handler register for IO bar.

Remove PCI I/O ranges property value from dom0 device tree node so that
dom0 linux will not allocate I/O space for PCI devices if
pci-passthrough is enabled.

Signed-off-by: Rahul Singh <rahul.singh@arm.com>
---
 xen/arch/arm/domain_build.c   | 29 +++++++++++++++
 xen/common/device_tree.c      | 69 +++++++++++++++++++++++++++++++++++
 xen/include/xen/device_tree.h | 10 +++++
 3 files changed, 108 insertions(+)

diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index 6931c022a2..7cfe64fe97 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -648,6 +648,31 @@ static void __init allocate_static_memory(struct domain *d,
 }
 #endif
 
+/*
+ * PCI IO bar are not mapped to dom0 when PCI passthrough is enabled, also
+ * there is no trap handler registered for IO bar, therefore remove the IO
+ * range property from the device tree node for dom0.
+ */
+static int handle_linux_pci_io_ranges(struct kernel_info *kinfo,
+                                      const struct dt_device_node *node)
+{
+    if ( !is_pci_passthrough_enabled() )
+        return 0;
+
+    if ( !dt_device_type_is_equal(node, "pci") )
+        return 0;
+
+    /*
+     * The current heuristic assumes that a device is a host bridge
+     * if the type is "pci" and then parent type is not "pci".
+     */
+    if ( node->parent && dt_device_type_is_equal(node->parent, "pci") )
+        return 0;
+
+    return dt_pci_remove_io_ranges(kinfo->fdt, node);
+}
+
+
 /*
  * When PCI passthrough is available we want to keep the
  * "linux,pci-domain" in sync for every host bridge.
@@ -723,6 +748,10 @@ static int __init write_properties(struct domain *d, struct kernel_info *kinfo,
     if ( iommu_node && device_get_class(iommu_node) != DEVICE_IOMMU )
         iommu_node = NULL;
 
+    res = handle_linux_pci_io_ranges(kinfo, node);
+    if ( res )
+        return res;
+
     dt_for_each_property_node (node, prop)
     {
         const void *prop_data = prop->value;
diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c
index 4aae281e89..55a883e0f6 100644
--- a/xen/common/device_tree.c
+++ b/xen/common/device_tree.c
@@ -2195,6 +2195,75 @@ int dt_get_pci_domain_nr(struct dt_device_node *node)
     return (u16)domain;
 }
 
+int dt_pci_remove_io_ranges(void *fdt, const struct dt_device_node *dev)
+{
+    const struct dt_device_node *parent = NULL;
+    const struct dt_bus *bus, *pbus;
+    unsigned int rlen;
+    int na, ns, pna, pns, rone;
+    const __be32 *ranges;
+    __be32 regs[((GUEST_ROOT_ADDRESS_CELLS * 2) + GUEST_ROOT_SIZE_CELLS + 1)
+               * 2];
+    __be32 *addr = &regs[0];
+
+    bus = dt_match_bus(dev);
+    if ( !bus )
+        return 0; /* device is not a bus */
+
+    parent = dt_get_parent(dev);
+    if ( !parent )
+        return -EINVAL;
+
+    ranges = dt_get_property(dev, "ranges", &rlen);
+    if ( !ranges )
+    {
+        printk(XENLOG_ERR "DT: no ranges; cannot enumerate %s\n",
+               dev->full_name);
+        return -EINVAL;
+    }
+    if ( !rlen ) /* Nothing to do */
+        return 0;
+
+    bus->count_cells(dev, &na, &ns);
+    if ( !DT_CHECK_COUNTS(na, ns) )
+    {
+        printk(XENLOG_ERR "dt_parse: Bad cell count for device %s\n",
+               dev->full_name);
+        return -EINVAL;
+    }
+
+    pbus = dt_match_bus(parent);
+    if ( !pbus )
+    {
+        printk(XENLOG_ERR "DT: %s is not a valid bus\n", parent->full_name);
+        return -EINVAL;
+    }
+
+    pbus->count_cells(dev, &pna, &pns);
+    if ( !DT_CHECK_COUNTS(pna, pns) )
+    {
+        printk(XENLOG_ERR "dt_parse: Bad cell count for parent %s\n",
+               dev->full_name);
+        return -EINVAL;
+    }
+
+    /* Now walk through the ranges */
+    rlen /= 4;
+    rone = na + pna + ns;
+    for ( ; rlen >= rone; rlen -= rone, ranges += rone )
+    {
+        unsigned int flags = bus->get_flags(ranges);
+        if ( flags & IORESOURCE_IO )
+            continue;
+
+        memcpy(addr, ranges, 4 * rone);
+
+        addr += rone;
+    }
+
+    return fdt_property(fdt, "ranges", regs, sizeof(regs));
+}
+
 /*
  * Local variables:
  * mode: C
diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h
index fd6cd00b43..580231f872 100644
--- a/xen/include/xen/device_tree.h
+++ b/xen/include/xen/device_tree.h
@@ -849,6 +849,16 @@ int dt_count_phandle_with_args(const struct dt_device_node *np,
  */
 int dt_get_pci_domain_nr(struct dt_device_node *node);
 
+/**
+ * dt_pci_remove_io_range - Remove the PCI I/O range property value.
+ * @fdt: Pointer to the file descriptor tree.
+ * @node: Device tree node.
+ *
+ * This function will remove the PCI IO range property from the PCI device tree
+ * node.
+ */
+int dt_pci_remove_io_ranges(void *fdt, const struct dt_device_node *node);
+
 struct dt_device_node *dt_find_node_by_phandle(dt_phandle handle);
 
 #ifdef CONFIG_DEVICE_TREE_DEBUG
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Tue Feb 15 15:40:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 15:40:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273346.468497 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJzwF-0005LD-Bg; Tue, 15 Feb 2022 15:40:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273346.468497; Tue, 15 Feb 2022 15:40:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJzwF-0005L6-7b; Tue, 15 Feb 2022 15:40:23 +0000
Received: by outflank-mailman (input) for mailman id 273346;
 Tue, 15 Feb 2022 15:40:21 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=vySV=S6=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nJzwD-0005L0-Ca
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 15:40:21 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 93a75bd2-8e75-11ec-b215-9bbe72dcb22c;
 Tue, 15 Feb 2022 16:40:20 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 93a75bd2-8e75-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644939620;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=O0HD0Ve1RTy45p9c87j+J6TLa6Skcri5TG+tjxzDiAI=;
  b=ctbvswzfX4qYudwiW9aOjMVwrUeu0EXP6G5e1UFpdRAFjBqiyeVuPYUp
   TroE/K+jTtPrzE0zdRhtTc31AM+RkGB1I9btCmwIs+Vo/kK3wZxdPk9Nw
   MjEt7xiY23hZUVz7MfdgJ21Vqh8slaNAGFN4puiaH7eC6o7C/5/pONOQ8
   A=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: 59SwxqVfKx53CEv5IFg/HAVPZgv/32SVVWgMvVSfYMoCnUONH29DjZuRS4W+NvVtfPcqChIa+V
 yPJnOiK0wqFyEn/azpJ4guS5HZ0NfrfqL65blbJZbb1z5R+6M2qsbuoWUDiBRL6ibZnW2UJtKz
 NUKo8pITIDE08ry6pMX0h9z6/Vy0F/eYi+HM+HntNNtOH1ihCyUjQ7KLAjNIr9tCZiALm7et26
 73OozCkDRUJsZ1oIpGASfuvZuqpIaabH3eRXRO01oooxd0Fn9mC6Vpxr4nU+61d83pUjTuCsP9
 WVx0YR3hJ2euQqwNH1MGeWxc
X-SBRS: 5.1
X-MesageID: 64661971
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:xzKCw6yYfWmdoqpeuC96t+fHwSrEfRIJ4+MujC+fZmUNrF6WrkUHz
 TYcDWjQb/yNMDPwLtBzPYq090NVsJOBx4Q2GVQ6qiAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAhLeNYYH1500g7wbdk2tUAbeWRWGthh
 /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL
 wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt/xhm
 fpTnq65cyQ0OrDpyPg8ChJ6Ny4raMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr
 6ZBbmlQMFbT3Ipaw5riIgVort4kI8TxepsWp1lrzC3DDOZgSpfGK0nPzYEEgmlp158XdRrYT
 /Yzbzt3Z1PMWkdWJXNUCaBkl+i0rHaqJlW0r3rK/PFqsgA/1jdZz7zFINfTPNuQSq19jkue4
 27L4Wn9KhUbL8CEjyqI9Gq2ge3Clj+9X5gdfJWj7eJjilCXwm0VCTUVWEG9rP3/jVSxM/pdI
 UEJ/islrYAp6VemCNL6WnWQomOAvxMac8pdFas98g7l90bPy1/HXC5eFGcHMYF48p9tLdA36
 rOXt//5VBNxm4+cc1GA8qqx/S+TYCM3CWBXMEfoUjA5y9XkpYgyiDfGQdBiDLO5g7XJJN3g/
 9yZhHNg3utO1Kbnw43+pAma2Gz0+vAlWyZovl2/Y46z0u9uiGdJjaSM4EOT0/tPJZ3xorKp7
 CldwJj2AAzj4PiweM2xrAclQevBCxWtamS0bbtT834JrWrFxpJbVdoMiAyS3W8wWir+RRfnY
 VXIpSRa74JJMX2hYMdfOtztV5t6nfW9TY2+DJg4i+aihbArKme6ENxGPxbMjwgBbmBw+U3AB
 XtrWZn1VitLYUiW5DG3W/0cwdcWKtMWngvuqWTA503/i9K2PSfNIZ9caQfmRr1pvcus/VSOm
 /4CZpTi9vmqeLCnCsUh2dVIdg5iwLlSLc2elvG7gcbaeVQ4QTl4UaeOqV7jEqQ895loei7z1
 ijVcmdTyUblhG2BLgOPa3t5b6joU4o5pnU+VRHA937xs5T6SYrwvqoZabUterwrqL5qwfJuF
 qFXcMScGPVfDD/A/m1FP5X6qYVjcjWthB6PYHX5MGRuIcY4Slyb4MLgcyvu6DIKUni9u/whr
 uDyzQjcW5cCGVhvVZ6EdPK1wlqtlnEBg+YuDVDQK9xedRy0oohnIiD8lNEtJMQIJUmRzzeWz
 V/OUxwZufPMs8k+99yQ3fKIqIKgEu1fGEtGHjaEsebqZHeCpmf6mN1OSueFezzZRVjYwqT6a
 LUH1ez4Pd0GgE1O79h2HYF0wP9s/NDovbJbkFhpRS2Zc1SxB7p8CXCaxs0T5LZVz7pUtAbqC
 EKC/t5WZeeANM//SQNDIQMkaqKI1O0OmymU5vMweR2o6Chy9buBcENTIxjT13ANcOoraNsok
 bU7pcobyw2jkR57YN+Jgxdd+3mIMnFdAb4ssYsXAdOzhwcmor2YjUcw1sMiDEmzVuhx
IronPort-HdrOrdr: A9a23:JlZXlKCK/k0aylzlHeg2sceALOsnbusQ8zAXPh9KJyC9I/b2qy
 nxppgmPH/P6Ar4WBkb6La90Y27MA7hHPlOkPUs1NaZLXPbUQ6TTb2KgrGSpgEIdxeOktK1kJ
 0QDJSWa+eAfWSS7/yKmDVQeuxIqLLsndHK9IXjJjVWPHpXgslbnnZE422gYzRLrWd9dP0E/M
 323Ls4m9PsQwVcUu2LQl0+G8TTrdzCk5zrJTYAGh4c8QGLyRel8qTzHRS01goXF2on+8ZvzU
 H11yjCoomzufCyzRHRk0fV8pRtgdPkjv9OHtaFhMQ5IijlziyoeINicbufuy1dmpDj1H8a1P
 335zswNcV67H3cOkmzvBvWwgHllA0j7nfzoGXoyEfLkIjcfnYXGsBBjYVWfl/y8Ew7puxx16
 pNwiawq4dXJQmoplW92/H4EzVR0makq3srluAey1ZFV5EFVbNXpYsDuGtIDZY7Gj7g4oxPKp
 ghMCjl3ocUTbqmVQGagoE2q+bcG0jbXy32DXTqg/blkwS/xxtCvg8lLM92pAZ3yHtycegC2w
 3+CNUbqFh5dL5gUUtMPpZzfSKJMB25ffvtChPbHb21LtBNB5ryw6SHlIndotvaPqA18A==
X-IronPort-AV: E=Sophos;i="5.88,371,1635220800"; 
   d="scan'208";a="64661971"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=igT3/cM1x5Qikbq1vxcB5dhmMAFGLgS9dfwfDoR0LiRwNmCFDrku9Lk20b+u8YY7hMNdhCH8TCGJ5Ao9Y4prnrQswKdSd7hVQu48L9TGm4T1ifGQPHwWX5hhYl1leQd4rfmZxqXx99do9l/1dE7gPy6Ql6wozPezv8kpb0xIn4nLY+C6DaiSCdIJNqWRbHnP6nMxEr2Fd1Zf/vDxENmdGTBnFmK7sENpze1uvDDt+9Q1u4UIKZHOCuIhPdkuIL9ZqkGMA0DGQJLtLtiAKYwGM7uajBOUTQEAH5kraJ4ZCf9KvmUG+L1TfVPiMGRzoSLvkd1U5719emKXWQ4629HKeQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=yuRqmTWbUjTjuX5plPEf1g4P3C3FUUOPNwt8Hbq16j8=;
 b=cFfnjZmQdCoRR56Z6EP7uiA8ox9haLQyQp4eT+ZPmqitsq2b0YaoSufLrRf8y1UzaAI+u3XGHn2HogEOLBf0CPoBstOzyXLmWN0WETxqekdI6PLieaoe8ua7Rpx2mIDCzxgte4Oshl9qGhsah3BkrEgI5BHbnpgMRHEUdPq148hLtolHT7l3t6syCPinokHB9q0WP90t/08t22zrOBrSad3vApqvWd22znVeI5v5CaD1vuXfpEwUeENloTLdEniERkqvGUzQ/tBXfk6Bn1ieKgSCY4nhrUTkYEX4jz1Z95pbHBOGJzPmGUujqg+Z5eO/W4JUB0/dElbT/vH+k1NXtA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=yuRqmTWbUjTjuX5plPEf1g4P3C3FUUOPNwt8Hbq16j8=;
 b=g8AuPxIrpjAZyQLKIGCaHzpuXjWqzdlJ7M62fROUlJxiIXjvgR0QyhgM4GMAlfZjPDNYp7A401IY3i4eWD1v2cbp3nnNQGxegxufs1WqUOwaGVOuABlwh8F2txbiZkQlVDlbt32vmQp9k/7XJm7BoK60x3/tvsTqfM0eauFVwGI=
Date: Tue, 15 Feb 2022 16:40:08 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Julien Grall <julien@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] rwlock: remove unneeded subtraction
Message-ID: <YgvJWJftVfyEWY2b@Air-de-Roger>
References: <20220215093951.97830-1-roger.pau@citrix.com>
 <7710f137-7123-ca70-3a58-3dba1981b2c2@xen.org>
 <dfc3ab95-f2ca-bf03-98c1-5d77ebcdb048@suse.com>
 <Ygu1si+HEiPB8vGz@Air-de-Roger>
 <493bf9e6-7f75-7f90-0c5b-a4a3e30cfb34@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <493bf9e6-7f75-7f90-0c5b-a4a3e30cfb34@suse.com>
X-ClientProxiedBy: LO4P123CA0062.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:153::13) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c88ad8f1-054e-410a-73c8-08d9f099751a
X-MS-TrafficTypeDiagnostic: BN6PR03MB2545:EE_
X-Microsoft-Antispam-PRVS: <BN6PR03MB2545F02B7849F12DF397B39B8F349@BN6PR03MB2545.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4303;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 9yGPG847weSiRQfFOX8iOMhBn2wXtAk4Thw95eDFmNrRApIvrlCi+vd1xpvyRK2kqug5I7/9IiydcyPS0P7S7Jv7ARjrI6C9YKtcMZWN++oA4lZUYNYXGKLat9r3mhvQjGa+gg3OBmTyyCCeL1CIRDnFduO76LNIA9PA88dan49mKB4SbInrDQxqD0V8wdvIERmbhrqHa2U9SzVh/nvsICRX/69oEcHborraAnALAaneZNoAB7wV52Fm3lLAn0dbSF09SrllUvw+W1ZRH/ddR/f2ajSrc8UVAP64SFxyX0gsHcErbVwQzM95s6yoeCwl7FQQsmvXYWtMOsZVaCRTkM6r0HpcC9RteNUVaFy6YsEf7m5OBPKl9Rn9ZZ1HzmKmewFVfzxTa8u6+5VG+/tWDS9TugxCkg/l1psHpxDXffK31hRviWAu/+BQDp4th4TZbjaCHSqwAoQ3zzftCwlOSnsA6ti0os7TQKbPRnvYQF+L3vtVy3+4SmbaWd6IjsnHOKtvSDyXFNWMK/ROtwCXRXpTTl6bnZNk0mhSQYWjUuwnwNfrN15l8lqeQQQ5A3CDyifrIssga071glogwFAJELQETJ5cBvO4hxxvUKUQvu0nSHESU4e+Jxru854PJrFkLYuGD67knNvXi7W9ndGxog==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(8676002)(6512007)(26005)(6916009)(508600001)(316002)(54906003)(66556008)(66476007)(4326008)(82960400001)(186003)(5660300002)(66946007)(6486002)(85182001)(83380400001)(2906002)(86362001)(53546011)(9686003)(33716001)(6506007)(38100700002)(4744005)(6666004)(8936002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c0lUQUhqRVdDdmtvQ1IwWjBkUmYyUnZWZDhZTFYyOE9zcENBYUJWNXdZTnRW?=
 =?utf-8?B?N3YrbGdRaElYYVp2eTFOZnNWRzlxWm8yemRvZWsvMGFlbjEvdVVieEw5NmNF?=
 =?utf-8?B?UUN4Z0JYSk9wUTA4dVZ2a0lXbi93UHdjaUZoSjl4dHVWR0xJdElVNytnU2xW?=
 =?utf-8?B?aHptalZkU1diSFNGS1RRU2RmNU9TUkUzdlp5RFp5c1Z5WTl4cGkzaVo1Risx?=
 =?utf-8?B?dUNDUHR2N25TQjgyZmFZRkwyTUF3MGVpQXhkM3YrSHNWYzhQYWI1ck1JWHdU?=
 =?utf-8?B?M0Qyd0l0cjNRcDltWk4wM3VNU2NuY0tCMlJJLzdGM0VCQUpvV0NTc0Jyb2ND?=
 =?utf-8?B?dWoyaUtlUmdUOUlFYnIxaUNLcndkdWVsSktMVUdaeGU1amQ1SXlzd0xXNTEy?=
 =?utf-8?B?TG92QWZIVFZvekNCTkdVbzB6eEVEK3VjVHZNS1phL3FMcEhPdjJxWkJXR3Iw?=
 =?utf-8?B?a3FNRkpOQTE3ZFVkeVRpQ1NQbE8rNFRxQ2JNd3dQQVlMV09CRDd2a1JRNEt4?=
 =?utf-8?B?R29CS1dPZ2VFRFltM0ZjV2lKbytHMVNKeFB1UlFLRFh1cTJGNGZCS0FTcTN0?=
 =?utf-8?B?UjNmazlKUzlldFBiYUxqYyswWUFsME1tblByV0srRGtYZTJFUUVsalMzU0JM?=
 =?utf-8?B?MmVPR0RHZlppOWtnbUZ3MmxIOEdnYXlXNkVoMVRBOEhCYzV4dWFrRnY5dURj?=
 =?utf-8?B?MXhIaFljdVVONzEzV2s1dEdGTkxwUXZSWGpNVG9IQ1Z0NU5YL1I2c2k4elFV?=
 =?utf-8?B?emtZNlNLblpiNmIvNi84dXBJZlVRNDFpMm5qVTVrYWlVRTVhVUw2cmNlZjRE?=
 =?utf-8?B?RFhxWjFna3krUjI2bmRFbklsRC9qZnIvVFRGZnhyTWZYTnRab3FZT1Rwd2JR?=
 =?utf-8?B?R0daS2U2UkRtU0hzVHh0eldqcUJPSUkrRFhFRHMxd0VqVU1uUktvUElCSEVy?=
 =?utf-8?B?TmE2SEc3Wjk5Q2dFZURQblRLQnRIMDJSSklreFB1MklzOTZVdWhSZ0FNOGE3?=
 =?utf-8?B?WTlIVmhDZEtlMXRiNlBzVEk0Nkh3RUh2OHRHeExBbFpKemxrc0NmNE9PbmpM?=
 =?utf-8?B?MW41YnVHRFVHWnVjMVVPTDl1R0lwMThPWm1mbUViajJkZzhneG03T21ZU0JH?=
 =?utf-8?B?RmVQekhLa1dmbnFNdVM1dkpNM3VxLzIzcWgxMUFjdzFlOTJVQUVkTjY2aE4v?=
 =?utf-8?B?WVBDeG13ZWo5MjYxUmxrYjU2dVUvK2VBRklKNDRMdnVwbkhxNnJ2SVVGS212?=
 =?utf-8?B?aXVySHkzMzkycEV2cnM0QXdBUldrMGdCRWJUY2U1bGlEaUZJY3c3MUsvVWlH?=
 =?utf-8?B?ZVNoM1IxYlV6enUvbTdXdXJWOTZQSVJiVkN5S21VekxRZU1vTGp6NlRTRXVM?=
 =?utf-8?B?cjBDeHh0VDRoeVlQMlVyY2hNZ2d0UlpvVzhqVGFUWVN0akVBWWU5bEhPRkxV?=
 =?utf-8?B?YWtDbEtHNEYyc082TDA0VENKL3h4blErNUVsbENCM2twdXNxa1JKc0xPUHo3?=
 =?utf-8?B?c2RjMERMc1RFaGJhbGh3K041ZXliUFJaYjYzNlVGaDY2NS9EQ25tUmZ1UVRE?=
 =?utf-8?B?cU12K3ZqR0h5RXBabGtxblhNQlhyaUg0MmZCR1NmMFVVVWNhT1laSjhlOS85?=
 =?utf-8?B?UlYzeEcyR29Qb2UzM1hNSjNoYlAzTXFoWFk2bGxTbkxhYTNhSFlQTS9KTVRT?=
 =?utf-8?B?MGVEbmJRK3FXMG5ydTY1aXZUK3djU0pRMGVXbW10UUEvenJ3WXhldDFpeFlB?=
 =?utf-8?B?YlZON3htdHJZZ2FFKzRDL2NaWHdsZzN5N1E2TGZhUUlZNlQvbko1Q3Z6bGIv?=
 =?utf-8?B?cUw3ZENDN2p5ZkZJVXcxTmdJRHZTSGh6L0Z3MHQzZWVLUDFZYVdGWUZBVHho?=
 =?utf-8?B?Y2tFZ1VJQnB5TlllL1FzZnFxK2N3cTBnYmRySU9ybi9IY3RYQUpSa3pPcEdr?=
 =?utf-8?B?dnBIcWtocElkZWdvaDlXRnZNbk5oemhWWllkR2ZWd1p0ZEV6Q0R1RlhqSlpS?=
 =?utf-8?B?RzB0OThQTmZtN0FFZEJLaEphMzhRbWtKYjJYT2dUTlczMVZuazFtdzZCY3VS?=
 =?utf-8?B?WW1HdWVDSG8vcFpvTWNUQ0xyRytUVVhRVW5OdGw1b2hRUzVLK0NZcVg0UkI0?=
 =?utf-8?B?Y2ExRXRwTmpTNUtFVzNUcHRzTlJXUG95bHB4UmZlSkFOU2V0RzZDVEhCMzNU?=
 =?utf-8?Q?8I4IBKwmNeKlgdH85caEW7M=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c88ad8f1-054e-410a-73c8-08d9f099751a
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 15:40:13.7153
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ns9wi1o2aKQDEYZDNLkoecMb6fZ/2t3/hPi93hLCqWqhA8gmszP4/3rXYO2k6psOFkTZYg/6SY//Mstyo5m8DA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2545
X-OriginatorOrg: citrix.com

On Tue, Feb 15, 2022 at 03:45:00PM +0100, Jan Beulich wrote:
> On 15.02.2022 15:16, Roger Pau Monné wrote:
> > I could add to the commit message:
> > 
> > "Originally _QR_BIAS was subtracted from the result of
> > atomic_add_return_acquire in order to prevent GCC from emitting an
> > unneeded ADD instruction. This being in the lock slow path such
> > optimizations don't seem likely to make any relevant performance
> > difference. Also modern GCC and CLANG versions will already avoid
> > emitting the ADD instruction."
> 
> ... I'm fine with this as explanation; I'd also be fine adding
> this to the description while committing.

Sure, thanks.

Roger.


From xen-devel-bounces@lists.xenproject.org Tue Feb 15 15:42:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 15:42:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273355.468507 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJzy0-0005zQ-QB; Tue, 15 Feb 2022 15:42:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273355.468507; Tue, 15 Feb 2022 15:42:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nJzy0-0005zJ-ND; Tue, 15 Feb 2022 15:42:12 +0000
Received: by outflank-mailman (input) for mailman id 273355;
 Tue, 15 Feb 2022 15:42:11 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=tLD3=S6=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nJzxz-0005z7-4F
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 15:42:11 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d5514165-8e75-11ec-b215-9bbe72dcb22c;
 Tue, 15 Feb 2022 16:42:10 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d5514165-8e75-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644939729;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=Kzs71HOKX4l7M6cP7lSwLADhlZsH6L7230tJbZbvKZ0=;
  b=ScZ7e8mQKnsRpL4jYF2CZ8QbS4YTZMnRl6X7vx2lMvCHXgWAu2VQpFWP
   HuMwQ00CVeubtqJcMB8lAX4rn/B6JBgUIZiAtkJ9BrqCjYBEkj7PH6Q1J
   yppYBDGYvD7NRA0+/yQp3SQV2hqhmwtOldLyGednpNSLmWd/VchfrjJPl
   U=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: XDpTUGLLQ2qIMvdedmXgCHDqhDwZZVegsV4qYBRYRVwb6kHJv95Dxjs5hUxG4Gx8r7ZfLVaRWP
 ejw3I240mJWteDFcAAXfS8CIrHAH/5k81tZ25n3O2OYUQneudD9kubrXZNcDcOpfmRNXh5ZX79
 TZ2eYqJU//0fh/eahUTXigzErfu5Gfm7geRsMfnCujPQEw/gV/Ik1/Uk8YoZKvzSmBwasiTgDm
 1Ot8WGNCvU0SslgJGAvpKdivqQWH5Hf+pwwvvSfnxdL19l160znyZco6X17cmvb3rwheE9PmDr
 KNOaLGcT+MJexvWVLIG9UdeD
X-SBRS: 5.1
X-MesageID: 64662123
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:twX6gKKSJ3cu5yYqFE+RIJIlxSXFcZb7ZxGr2PjKsXjdYENS1mYHn
 WdNWmHXOqzcYzSkLdpzboW2oB5Vu57WmNNkGQdlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokcxIn5BC5C5xZVG/fjgqoHUVaiUakideSc+EH170Ug6xrZi6mJVqYPR7z2l6
 IuaT/L3YDdJ6xYsWo7Dw/vewP/HlK2aVAIw5jTSV9gS1LPtvyB94KYkDbOwNxPFrrx8RYZWc
 QphIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbrGvaUXe345iXMfwZ3u7hB2ikeBSl
 vwTmqeyWAJxPfDXmb8AWh1xRnQW0a1uoNcrIFC6uM2XiUbHb2Ht07NlC0Re0Y8wo7gtRzsUr
 LpBdW5LPkvra+GemdpXTsFlgNgjK8/6epsSoHh6wRnSDOo8QICFSKLPjTNd9Gls2J4URKyFD
 yYfQQp/aUrKehZNAHAsA75l39v23jqucDIN/Tp5ooJoujOOnWSdyoPFMsfRe9GMbdVYmACfv
 G2u13/iHhgQOdibyDyE2nGhnOnCmWX8Qo16PKK83u5nhhuU3GN7IB8ZT1ygutGil1WzHdlYL
 iQ86ico6KQ/6kGvZt38RAGj5m6JuAYGXNhdGPF87xuCooLW6QuEAmkPThZadccr8sQxQFQXO
 kShxo2zQ2Y16fvMFCzbpuz8QS6O1TY9BmEyRnEtEyQ+4cjm+IJulROUU99nOfvg5jHqIg3Yz
 zePpSk4orwci88Xyqm2lWz6byKQSovhFVBsuFiONo6xxkYgPdP+OdT0gbTOxasYdO6kok+9U
 G/ociR0xMQHFtmzmSOEW43h95n5tq/eYFUwbbOCdqTNFghBGVb+J+i8AxkkfS+F1/ronhezP
 ifuVft5vsM7AZdTRfYfj3iNI8or17P8Mt/uS+rZaNFDCrAoKlPbo3E+OBPIhju3+KTJrU3YE
 c3FGftA8F5AUfg3pNZIb7t1PUAXKtAWmjqIGMGTI+WP2ruCfn+FIYrpw3PVBt3VGJis+V2Pm
 /4GbpPi40wGDIXWP3mGmaZOfAtiBSVqWvjLRzl/K7frzvxOQzp6VZc8ANoJJuRYokiivr6To
 C/kAhYCkAWXaL+uAVziV02PoYjHBf5XxU/X9wR3Vbpx83R8M4up8okFcJ47Iesu+OB5lKYmR
 PgZYcSQRP9IT22fqTgaaJD8qq1kdQiq2l3Sb3b0PmBncs4yXRHN9//lYhDrqHsEAB2ouJZsu
 LanzA7aH8YOHlwwEMbMZfuz5FqtpnxByvlqVk7FL4ALKkXh+YRnMQLrifozL51eIBnP3GLCh
 Q2XHQ0Zta/GpIpsqIvFgqWNroGIFepiHxUFQzmHvOjubSSDpzit245NVuqMbAvxbmKs9fXwf
 /hRwtH9LOYDwARAvb1jHus51qk5/dbu+eNXl1w2AHXRYl23Ibp8OX3aj9JXv6hAy7IF6wu7X
 kWDpotTNbmTYZ63FVcQIEwub/iZ1OFSkT7XtKxnLEL/7S5x3byGTUQNYEXc1H0DdON4YNE/3
 OMsmM8K8Aju2BMlP+GPgj1Q62nRfGcLVL8qt81CDYLm4ubxJoquvXAI5vfK3ayy
IronPort-HdrOrdr: A9a23:qaSeUqloG7jAIzLUJuB7d94BnZjpDfIu3DAbv31ZSRFFG/Fxl6
 iV/cjz8SWE7wr5OUtQ/exoV5PtfZqxz/FICMwqTNGftWrdyQ6VxeNZnOjfKlTbckWUnINgPO
 VbAspD4bXLfCFHZK3BgDVQfexP/OW6
X-IronPort-AV: E=Sophos;i="5.88,371,1635220800"; 
   d="scan'208";a="64662123"
Date: Tue, 15 Feb 2022 15:42:02 +0000
From: Anthony PERARD <anthony.perard@citrix.com>
To: Juergen Gross <jgross@suse.com>
CC: <xen-devel@lists.xenproject.org>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, "Jan
 Beulich" <jbeulich@suse.com>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH] tools/xenstore: add error indicator to ring page
Message-ID: <YgvJyt5Jpvsb2Jws@perard.uk.xensource.com>
References: <20220210111620.5256-1-jgross@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220210111620.5256-1-jgross@suse.com>

On Thu, Feb 10, 2022 at 12:16:20PM +0100, Juergen Gross wrote:
> +The "Connection error indicator" is used to let the server indicate it has
> +detected some error that led to deactivation of the connection by the server.
> +If the feature has been advertised then the "Connection error indicator" may
> +take the following values:
> +
> +Value   Description
> +-----------------------------------------------------------------
> +0       No error, connection is valid
> +1       Communication problems (event channel not functional)
> +2       Inconsistent producer or consumer offset
> +3       Protocol violation (client data package too long)

Is this meant to be the only possible error value? If in the future we
want to add more possible error, does it going to need a new feature
bit and maybe a new error field?

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Tue Feb 15 15:45:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 15:45:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273362.468518 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nK01E-0006dF-8h; Tue, 15 Feb 2022 15:45:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273362.468518; Tue, 15 Feb 2022 15:45:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nK01E-0006d8-5q; Tue, 15 Feb 2022 15:45:32 +0000
Received: by outflank-mailman (input) for mailman id 273362;
 Tue, 15 Feb 2022 15:45:30 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=az2O=S6=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nK01C-0006d2-UV
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 15:45:30 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4d60bf38-8e76-11ec-8eb8-a37418f5ba1a;
 Tue, 15 Feb 2022 16:45:30 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 79D8B1F37B;
 Tue, 15 Feb 2022 15:45:29 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3EE8D13C96;
 Tue, 15 Feb 2022 15:45:29 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id PwcODpnKC2IjTwAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 15 Feb 2022 15:45:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4d60bf38-8e76-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1644939929; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=bx7iozxsbrgZUNO9o0t54rHCxDQLvX1k2zoI6oQ1rpk=;
	b=gj0z6WajwMh5j5GGvc8zDw9R0fpZPHgbLEwtqjtWJilyDtH6lqe8cGpOvu6ZjbxWiNmGl0
	oikbxsxYhyRSqeb9286jk+tKTQOji9gzu8T5opjw3ZnH10nofnTwaAiUXO23BAC5PFRc13
	RQKKTzEkwQNd0a0EixGd/7RhisP4ero=
Message-ID: <8891ed69-2ad2-2842-e34e-8252860b71d9@suse.com>
Date: Tue, 15 Feb 2022 16:45:28 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Subject: Re: [PATCH] tools/xenstore: add error indicator to ring page
Content-Language: en-US
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: xen-devel@lists.xenproject.org, Andrew Cooper
 <andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>,
 Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
References: <20220210111620.5256-1-jgross@suse.com>
 <YgvJyt5Jpvsb2Jws@perard.uk.xensource.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <YgvJyt5Jpvsb2Jws@perard.uk.xensource.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------jM2uX0ZAdAgVliFxjyKxO0iz"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------jM2uX0ZAdAgVliFxjyKxO0iz
Content-Type: multipart/mixed; boundary="------------k2QtBf1P8l1ffGBSTBGUEmRy";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: xen-devel@lists.xenproject.org, Andrew Cooper
 <andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>,
 Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Message-ID: <8891ed69-2ad2-2842-e34e-8252860b71d9@suse.com>
Subject: Re: [PATCH] tools/xenstore: add error indicator to ring page
References: <20220210111620.5256-1-jgross@suse.com>
 <YgvJyt5Jpvsb2Jws@perard.uk.xensource.com>
In-Reply-To: <YgvJyt5Jpvsb2Jws@perard.uk.xensource.com>

--------------k2QtBf1P8l1ffGBSTBGUEmRy
Content-Type: multipart/mixed; boundary="------------T0y3kQCNviUlbupCaY0WwuEj"

--------------T0y3kQCNviUlbupCaY0WwuEj
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMTUuMDIuMjIgMTY6NDIsIEFudGhvbnkgUEVSQVJEIHdyb3RlOg0KPiBPbiBUaHUsIEZl
YiAxMCwgMjAyMiBhdCAxMjoxNjoyMFBNICswMTAwLCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0K
Pj4gK1RoZSAiQ29ubmVjdGlvbiBlcnJvciBpbmRpY2F0b3IiIGlzIHVzZWQgdG8gbGV0IHRo
ZSBzZXJ2ZXIgaW5kaWNhdGUgaXQgaGFzDQo+PiArZGV0ZWN0ZWQgc29tZSBlcnJvciB0aGF0
IGxlZCB0byBkZWFjdGl2YXRpb24gb2YgdGhlIGNvbm5lY3Rpb24gYnkgdGhlIHNlcnZlci4N
Cj4+ICtJZiB0aGUgZmVhdHVyZSBoYXMgYmVlbiBhZHZlcnRpc2VkIHRoZW4gdGhlICJDb25u
ZWN0aW9uIGVycm9yIGluZGljYXRvciIgbWF5DQo+PiArdGFrZSB0aGUgZm9sbG93aW5nIHZh
bHVlczoNCj4+ICsNCj4+ICtWYWx1ZSAgIERlc2NyaXB0aW9uDQo+PiArLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0N
Cj4+ICswICAgICAgIE5vIGVycm9yLCBjb25uZWN0aW9uIGlzIHZhbGlkDQo+PiArMSAgICAg
ICBDb21tdW5pY2F0aW9uIHByb2JsZW1zIChldmVudCBjaGFubmVsIG5vdCBmdW5jdGlvbmFs
KQ0KPj4gKzIgICAgICAgSW5jb25zaXN0ZW50IHByb2R1Y2VyIG9yIGNvbnN1bWVyIG9mZnNl
dA0KPj4gKzMgICAgICAgUHJvdG9jb2wgdmlvbGF0aW9uIChjbGllbnQgZGF0YSBwYWNrYWdl
IHRvbyBsb25nKQ0KPiANCj4gSXMgdGhpcyBtZWFudCB0byBiZSB0aGUgb25seSBwb3NzaWJs
ZSBlcnJvciB2YWx1ZT8gSWYgaW4gdGhlIGZ1dHVyZSB3ZQ0KPiB3YW50IHRvIGFkZCBtb3Jl
IHBvc3NpYmxlIGVycm9yLCBkb2VzIGl0IGdvaW5nIHRvIG5lZWQgYSBuZXcgZmVhdHVyZQ0K
PiBiaXQgYW5kIG1heWJlIGEgbmV3IGVycm9yIGZpZWxkPw0KDQpObywgYXMgdGhlIGd1ZXN0
IGlzIG5vdCBvcHRpbmcgaW50byB0aGlzIGZlYXR1cmUsIGJ1dCBqdXN0IGdldHMgaXQNCnBy
ZXNlbnRlZCwgdGhlcmUgaXMgbm8gbmVlZCB0byBoYXZlIGFub3RoZXIgYml0IGZvciBuZXcg
ZXJyb3IgdmFsdWVzLg0KDQpOb3RlIHRoYXQgdGhpcyBpcyBhIHB1cmVseSBpbmZvcm1hdGlv
bmFsIGludGVyZmFjZS4gVGhlIGVycm9yIHZhbHVlDQoob3RoZXIgdGhhbiAwKSBpcyBvbmx5
IGZvciBkaWFnbm9zdGljIHB1cnBvc2VzLCB0aGVyZSBpcyBubyB3YXkgYQ0KZ3Vlc3QgY291
bGQgcmVhY3QgaW4gYSBzYW5lIHdheSB0byBhIHNwZWNpZmljIGVycm9yIGNhc2UuDQoNCg0K
SnVlcmdlbg0K
--------------T0y3kQCNviUlbupCaY0WwuEj
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------T0y3kQCNviUlbupCaY0WwuEj--

--------------k2QtBf1P8l1ffGBSTBGUEmRy--

--------------jM2uX0ZAdAgVliFxjyKxO0iz
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmILypgFAwAAAAAACgkQsN6d1ii/Ey89
kQf9GnC4ZL3nSpMDk8vZsAHLLPQLMDMKbdKyDCc/KiUghJ4LrTNLJUB5Hdr+Rsxd+5EpeL5nZIld
a4hHbwQJHYsxJX/EH/bpdXew/Pm1STjrhIueDgwH4yXKYkBpKvviSn+396fQAljt6y3Hr9vIRSRm
srS49/gqHW4DfKTZBlKEjEJne+lnFHXU61tuplrDho/OnUkf07+Glj0KfaEyUqr64GKhXXMmdGpL
Dx8tJhWJ8xfv+zj6OCYskodONDDkSNgD+/BQEcjz6kicUfDtySbsYalEOTdzhKb2tMXjb+fLVYOd
u4zl/moqogDsQ741L77/jWUUwmKLJ6Wcq5jJoPO0NA==
=dDd0
-----END PGP SIGNATURE-----

--------------jM2uX0ZAdAgVliFxjyKxO0iz--


From xen-devel-bounces@lists.xenproject.org Tue Feb 15 15:46:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 15:46:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273367.468529 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nK021-00079H-Iz; Tue, 15 Feb 2022 15:46:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273367.468529; Tue, 15 Feb 2022 15:46:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nK021-00079A-FI; Tue, 15 Feb 2022 15:46:21 +0000
Received: by outflank-mailman (input) for mailman id 273367;
 Tue, 15 Feb 2022 15:46:20 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=xOiq=S6=epam.com=prvs=4045782cdb=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nK020-00072q-6n
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 15:46:20 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6a1b05ac-8e76-11ec-b215-9bbe72dcb22c;
 Tue, 15 Feb 2022 16:46:19 +0100 (CET)
Received: from pps.filterd (m0174676.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 21FFX1rH012208;
 Tue, 15 Feb 2022 15:46:15 GMT
Received: from eur04-db3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2050.outbound.protection.outlook.com [104.47.12.50])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3e8ewmg2dg-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Tue, 15 Feb 2022 15:46:15 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM0PR03MB6307.eurprd03.prod.outlook.com (2603:10a6:20b:15b::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Tue, 15 Feb
 2022 15:46:11 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::fc4d:4749:5d1:eb73]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::fc4d:4749:5d1:eb73%4]) with mapi id 15.20.4975.019; Tue, 15 Feb 2022
 15:46:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6a1b05ac-8e76-11ec-b215-9bbe72dcb22c
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=H8fjpl0AdHJP0uH4w9QhZy2wHLnTiJU/wstWts54Vp/UdK3zcaRuHnSqK61S48wxMUwxlXjLZrZJkz34Y7er77v2D6eGFed5NSqb4pjJhEs1xcWio1bw+4uFPgo/C5jOpZSLhSdSCE5F3J7skgqjQHtWPwxqdswFNf24lC6BBF6AIhDHALA7zZNfpwjpJv5ty8ma3ulfsg1QU4EjlrYE4IvWiYfBqI0HBRFo1TTMgiBj25KXQ+4VoipMtENxFMXTm8SVfP8oQTIRdAEMuhxstxhqhG5jcMYijEJDrAibNQbgZOITMEYpTvZJUvcOpCDumEorJz3QpvlCnwMfH8yqsw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=KR/c4C5HT2qw5x0YQj8/gbUUTWmkgqFpBI44XSRY1gM=;
 b=AH8XcMqMBToZ7KhsW98346H2X8eXbtktTGfGqVsdq4ZHCZJRgKFi+mf1v5tH3IOJJxvWrh/+aFzUFBG8aRuWjIxQhNdZ51wMSXs7og/DMcXrWRHZpoNp9HkX0J3dnn+HFfAscPr88kkgYVdMJ00GqEEabQfURVtoAe0uQP9qiYisvf0oe2JOS79axtTkAicd0zZCz8w6OWRbHjCKGprs3SE33afMtKiqDT6iJM916W/xoRLfq2F9XMsVE8z7vIon+v1Vxfu6JYoksEe35z+xJqEBV9SLz2M7FCdMtJNcLgQQ6PqrzrlnQ+/U+oDPc/YEEiR6ojj1EvKrNoihrz1xuA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=KR/c4C5HT2qw5x0YQj8/gbUUTWmkgqFpBI44XSRY1gM=;
 b=CnB6Bl2YCGSxxpzDBFkDrqhC4Z23dnYgW9T7930e46GiejpwvSB/CPj42FFwTCEcmSheXKwb2BetNuJWzjBAlgFodZuICX4wC+p64koQWy+d08mDY2jNZaXBJGSK0bxHabN1316F8m6Bxh9A/islL9kIJ3D07QmMrtc5OQkNgcha63kMsazqQdHILqaQux6WvUWiESMPClqHXOPTDpGgwswqDtWnryrMwdLAk/dE4vreVBuZginoEon5SoK2sGZj2AGtbuwMWV01SMhgekChpYtwuYQQcisCE6gPbSIjkQuqefTaB/Aa9C5LasqacyxXzRk20e7urry5SRzlExuErg==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?=
	<roger.pau@citrix.com>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v2] vpci: introduce per-domain lock to protect vpci
 structure
Thread-Topic: [PATCH v2] vpci: introduce per-domain lock to protect vpci
 structure
Thread-Index: 
 AQHYIkOs9pmsZb0l5kefj1m3qdTVCayUboeAgAAGwYCAAAeVgIAAAZQAgAABlwCAAAEVAIAADewAgAADdICAAC9JAA==
Date: Tue, 15 Feb 2022 15:46:11 +0000
Message-ID: <504327d2-0d82-7f88-e155-e6a45ba11a74@epam.com>
References: <20220215081135.1497470-1-andr2000@gmail.com>
 <YguE7RWOteSnvVNY@Air-de-Roger>
 <c5b9b02c-93f8-d018-6048-9abf2e7de4dc@epam.com>
 <YguQ8wfhfYFXTWSU@Air-de-Roger>
 <70dbd7fd-3f74-d0d3-6e30-c1e1e24fc279@epam.com>
 <0d8f01b2-b015-a08e-dd49-e9c688ff7245@suse.com>
 <bbb36ebc-de66-297d-f82f-abc0e63f20a2@epam.com>
 <22d25499-cab0-00c1-3ad3-bddd74c97a55@epam.com>
 <772eb410-be1a-3b5f-3b51-e363c43bc3c6@suse.com>
In-Reply-To: <772eb410-be1a-3b5f-3b51-e363c43bc3c6@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 5f06fb27-84d4-401f-81a8-08d9f09a4a94
x-ms-traffictypediagnostic: AM0PR03MB6307:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM0PR03MB630742C7197C5E2D90CE878EE7349@AM0PR03MB6307.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 q1m1ItnwW+o7Vc2i18PfCU/Pfe02w1qum6rVdzFEcvjHl9PhHZew8N6o5NGY3nwyT5i+5OJPNQwo5ey2degug6LpObI/OuDGz/g/mMQpEm7dNJAn4VY2hRRqYS5i3p9tR5jKFqN5ZUtYuS5rW9vXUod6zhpAG7B3Ct8PTBB9TMTtBLt21lZ7KxmOMsm6XUgTN2CIguvt0zo36KK0swzzCCTkEPzbb9aXm1cAApbPgpUFd+BV1GvW2DB/X0tvJbbHy5fW9j0d/bhQZNjGRFX8x33BEvxoIPlMBPdkTU7Ob05rsVf4YTCnNOSuwoMd1ehmeVtHQbhZvLSwIkCz6oDDxd4XkHhPlL2oQRXxLQZ3KUyFuW7JuMYmo/udbkphXTb4kTIuGPees5dzQ29X9+3WTWlVhVjuPMwwgHFFZ59unRDJOFel2jGccjucqYzc/VntPmAPpKrNCElh1R8XFXcS2bCb6RxVpiogp0nrqlgOTU8MFy8IhDq9v7ks11VwsfoDFeCC8yzSxj8H5eh2paO2bcupAnRqb3PQIZZhZ95P3m17thNTGqJ5wk6dKJloTxoUsHUtPq4heqbRwSemAIsur+coPtvCZs/RxCzupy/pke/QdM+21bhrFxbRhJH5zH+VxHPFh5JazJ6zSPaeEvO5fd+S8mTkkpkSvrGuSd16ZY+GOyqIoUZ44iyzHJdd8LCZT9Dw7Xt2MnAgAVcdRIsvfXL7XqOB+63bTtF+LPvpMlnJFet5NADfGzeQMLGFMOGx
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(2616005)(107886003)(5660300002)(83380400001)(8936002)(53546011)(6486002)(26005)(186003)(6506007)(38070700005)(508600001)(91956017)(8676002)(66476007)(122000001)(38100700002)(71200400001)(31696002)(2906002)(54906003)(316002)(31686004)(66946007)(86362001)(6916009)(64756008)(66446008)(4326008)(76116006)(6512007)(66556008)(36756003)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?dS9uVUtrUXVtbDBlRjg0eXNUQ0NmQlRhbmgrKzRtZzJMdkpERDg4RnJoaTRR?=
 =?utf-8?B?c2NSKy9xUnl3RUlLWXl1SytTbXVxZkl4Z1l5dGZQd05SNklZNGp2bVRrOS9i?=
 =?utf-8?B?R3czNElIWWpWOXdwOW9zMHlZYjEvUlpkSGI2RmZxd2pwWUx0ckg4eXhxZkFS?=
 =?utf-8?B?K0NEVUxaem9VbEZoR1ZIT1hwemhBWUJOd1pNQk5pTXlmdi9OYlczQmxqY1Bk?=
 =?utf-8?B?eHR1QW1uM3lnMDNONVYyUm55ZjlMZGl5b0JtZ0dDeHMwd2h4RXZ2WHEwOCtF?=
 =?utf-8?B?NUZYam16LzdadmNWcGdvaW11VVRWM09YUHpPU3BLa3hNenlLZFQxVW1vVEc0?=
 =?utf-8?B?RlR1SEpEL1o0a0t2R3MxV3pzQU9QVVJwa1diKy9hUWNzLzZXS3VnOEhkdFN2?=
 =?utf-8?B?elVSd3RXMVFNamsvVlFxYytKSlZveU13VHpnMVYrVTU3cy82S21hbGZaK1h6?=
 =?utf-8?B?WTRsUDRzTWlkQXlnZEN0Q1BlOXRUcDB5RHc0bHJHckxWZFE3L3FTMU1admc4?=
 =?utf-8?B?QkJFWmNmVGJHcFdxeEZvbVh4dXJOSXJJUVZ1QVQwOFhRTGMzanNqZjNmVU1U?=
 =?utf-8?B?Uzd6ZWYrNnJmbkJjZ3NoSlJ5Y1B6Y0NJQzd0cWlpNDFjY3hHenk5UVBTMklP?=
 =?utf-8?B?dVlwNnNic0JiWGNtbVVrQXhuQlM3UnRpbWR4WGFBSVJBb1M4V3NkQnBQTmgy?=
 =?utf-8?B?ODFvRkx6blprd3pyV3R2V3pGNlBkM1VCOWwrZGVtd01pRXlWdFRsSzVjbmxm?=
 =?utf-8?B?akRkTmI0dGUya2FZTHN6KzF4cUYvNHlMR2VSdGNHa3FEUThNVXRmZHhZMDBW?=
 =?utf-8?B?TC8vQlJucGZtckFleUhDclJhQXQ5TExnb2FleThxekJreEYrclZQRFc4UDVV?=
 =?utf-8?B?Zm54SGVBa21ja3BwbEJYZzhWUGpIUVgzNVU3ZUk0MDI3OXV2OGltai91SnN3?=
 =?utf-8?B?b0YxWG45NXVWbEtCd2JyS3JjVHJpWllmNEU4WDk3YytmQTVCYVBaN3pRTEFM?=
 =?utf-8?B?bGRlVWkxLzVjR2RidnpueWZrTjk2dzVqVTFjdXFSRkxna21oekpLd2szZjZM?=
 =?utf-8?B?bmRjVmdCTjV5d1RmR3N4cUx3N1BNSmMwVWFCRVRJM1hkQS9oM2pWaDdDVjkz?=
 =?utf-8?B?MkQycWhsaDVSRS9ySEIycmE5TkRwQklYZTU4cEhnV1Y3aHlKZHpuMm5Ya3JI?=
 =?utf-8?B?MEc3bm9sQ1NhR2p0SzhYR3ZqNmUrVTVud3gvdTVEMkVzTG5tWTM4RGNiMmJl?=
 =?utf-8?B?REQ1MXBEMER2RXVUVndKMG10WFZ1OVFKQXN0RVFnckhpRzlYRHNRV0llc0th?=
 =?utf-8?B?ZklxUzRwWXBrbmpQMmgvQy9CcWJhNEladUloZ2Y4Yk5yQUMwVXVienR0dUxK?=
 =?utf-8?B?am5MVjNtWHQySDFTeFRpRlBTdnlkY0c1VzdBNE1YMlplYitHZktoMnA5OXNJ?=
 =?utf-8?B?WEZKNHkrTDhaNlY5aWFqNXpYSWwrbjFNV09lU1pScmNoYkV6YURKOU4wZ2NL?=
 =?utf-8?B?Wml2RDZwcy9zWXZiNUJBaTVQTThyNjhiYWJGUVEybzh4NXYwNWZ3SWtOdXU4?=
 =?utf-8?B?U25kVFZSRXZVZnUrSEM1VFBQb1V0TC9EbFVVRXViOUM3N2tKb050ektNL0o2?=
 =?utf-8?B?NDZFcFZoWVJ5RWRGTjdkQlRQaWlnNWZaWmFySjVTcWcwSDlwdDJtenBxSmNM?=
 =?utf-8?B?azRaZDVVNGQzV0Z5OW9Uamk3VEVtcWxDamkrbWJLWlhwUUdna0FkUnBIblEr?=
 =?utf-8?B?MjljTG1pNnJSQ2orRExBQ3pCeS9semJ5Uks0UGVRbzZ5OEZRQzl2NnpjQitj?=
 =?utf-8?B?aGxWcHZuRG45ZENrVXc1L0wzUHo4cE1ZUGNWcDNEU1pVQmpQNVB4ZnRMd2pm?=
 =?utf-8?B?dlkwckYzNXhpRDE5YnM5cjlyYVlBWi8vTUFxVllqYlFsQzVCSXF1TnBSb0xz?=
 =?utf-8?B?ZGQ5UEpXODhwN1h3enVKZGRsR3NmdjM5R3piUEhkYTV2bXZxSVk2QmhwNmQx?=
 =?utf-8?B?VmFkNUxMS0YzeUdvOUt5bEF2M3hqbFlYaGdYdjdJSFlQQ0MvZVQxQ2Z4VkhB?=
 =?utf-8?B?M1JuTFhGSnN4YklSSlkzbkdXa24rUnBtVkJ2L1E3M05zYXN5MHdvQzZEOTZM?=
 =?utf-8?B?UVVKT3FHK2xRWHBFVDdIMVFvRGVFZFlCQTExQ1ZxdlVxQ0ZTQUtiVG5idzJQ?=
 =?utf-8?B?VmJHWnF0YlN5MW5ZMHJ1SnE4alZKT1FFTm1yTzNuN0x5TVRqWHc3ejJpYVZn?=
 =?utf-8?B?TmRNUXkxWVlhekZJYmNtQ0kvT2FET3QvQlFhYXRoVzdpektsdXZleWsyV2tS?=
 =?utf-8?B?c2NZd0htVGJURFJSSFdTbjdkL3NKZUlGcFA2eU9KWlBaMnkvZVJKQT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <14FBCFF1403D0C4A96329BFB50B5B30C@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5f06fb27-84d4-401f-81a8-08d9f09a4a94
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Feb 2022 15:46:11.5575
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: JYp43IuWUJ4tgWxK2YHcQBHOprRoJGFAryYHBhASckczxSt1NX5Ok0YPjQBKFh1wo6Iw3dFW9+kt5nyXyoolswy+aRSWFvRfFy5gCFszX0PHbuXdmvb5wHxqVSaESwya
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB6307
X-Proofpoint-GUID: eTuLysNqJyrYnl4bHs9khPlWEZJlgn3A
X-Proofpoint-ORIG-GUID: eTuLysNqJyrYnl4bHs9khPlWEZJlgn3A
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-15_04,2022-02-14_04,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 mlxscore=0
 malwarescore=0 suspectscore=0 bulkscore=0 lowpriorityscore=0 adultscore=0
 clxscore=1015 priorityscore=1501 spamscore=0 mlxlogscore=999 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2202150092

DQoNCk9uIDE1LjAyLjIyIDE0OjU2LCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMTUuMDIuMjAy
MiAxMzo0NCwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+PiBPbiAxNS4wMi4yMiAx
Mzo1NCwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+Pj4gT24gMTUuMDIuMjIgMTM6
NTAsIEphbiBCZXVsaWNoIHdyb3RlOg0KPj4+PiBPbiAxNS4wMi4yMDIyIDEyOjQ1LCBPbGVrc2Fu
ZHIgQW5kcnVzaGNoZW5rbyB3cm90ZToNCj4+Pj4+IEknbSBvbiB5b3VyIHNpZGUsIEkganVzdCB3
YW50IHRvIGhlYXIgdGhhdCB3ZSBhbGwgYWdyZWUgcGNpZGV2cw0KPj4+Pj4gbmVlZHMgdG8gYmUg
Y29udmVydGVkIGludG8gcndsb2NrIGFjY29yZGluZyB3aXRoIHRoZSBwbGFuIHlvdQ0KPj4+Pj4g
c3VnZ2VzdGVkIGFuZCBhdCBsZWFzdCBub3cgaXQgc2VlbXMgdG8gYmUgYW4gYWNjZXB0YWJsZSBz
b2x1dGlvbi4NCj4+Pj4gSSdkIGxpa2UgdG8gZXhwcmVzcyB3b3JyaWVzIHRob3VnaCBhYm91dCB0
aGUgY29udmVyc2lvbiBvZiB0aGlzDQo+Pj4+IHJlY3Vyc2l2ZSBsb2NrIGludG8gYW4gci93IG9u
ZS4NCj4+PiBDb3VsZCB5b3UgcGxlYXNlIGVsYWJvcmF0ZSBtb3JlIG9uIHRoaXM/DQo+PiBXaGF0
IGlmIHdlIGp1c3QgZG8gdGhlIGZvbGxvd2luZzoNCj4+DQo+PiBzdGF0aWMgc3BpbmxvY2tfdCBf
cGNpZGV2c19sb2NrID0gU1BJTl9MT0NLX1VOTE9DS0VEOw0KPj4gc3RhdGljIHJ3bG9ja190IERF
RklORV9SV0xPQ0soX3BjaWRldnNfcndsb2NrKTsNCj4+DQo+PiB2b2lkIHBjaWRldnNfbG9jayh2
b2lkKQ0KPj4gew0KPj4gICDCoMKgwqAgcmVhZF9sb2NrKCZfcGNpZGV2c19yd2xvY2spOw0KPj4g
ICDCoMKgwqAgc3Bpbl9sb2NrX3JlY3Vyc2l2ZSgmX3BjaWRldnNfbG9jayk7DQo+PiB9DQo+Pg0K
Pj4gdm9pZCBwY2lkZXZzX3VubG9jayh2b2lkKQ0KPj4gew0KPj4gICDCoMKgwqAgc3Bpbl91bmxv
Y2tfcmVjdXJzaXZlKCZfcGNpZGV2c19sb2NrKTsNCj4+ICAgwqDCoMKgIHJlYWRfdW5sb2NrKCZf
cGNpZGV2c19yd2xvY2spOw0KPj4gfQ0KPj4NCj4+IHZvaWQgcGNpZGV2c19yZWFkX2xvY2sodm9p
ZCkNCj4+IHsNCj4+ICAgwqDCoMKgIHJlYWRfbG9jaygmX3BjaWRldnNfcndsb2NrKTsNCj4+IH0N
Cj4+DQo+PiB2b2lkIHBjaWRldnNfcmVhZF91bmxvY2sodm9pZCkNCj4+IHsNCj4+ICAgwqDCoMKg
IHJlYWRfdW5sb2NrKCZfcGNpZGV2c19yd2xvY2spOw0KPj4gfQ0KPj4NCj4+IHZvaWQgcGNpZGV2
c193cml0ZV9sb2NrKHZvaWQpDQo+PiB7DQo+PiAgIMKgwqDCoCB3cml0ZV9sb2NrKCZfcGNpZGV2
c19yd2xvY2spOw0KPj4gfQ0KPj4NCj4+IHZvaWQgcGNpZGV2c193cml0ZV91bmxvY2sodm9pZCkN
Cj4+IHsNCj4+ICAgwqDCoMKgIHdyaXRlX3VubG9jaygmX3BjaWRldnNfcndsb2NrKTsNCj4+IH0N
Cj4gSG1tLCB0aGlzIGlzIGFuIGludGVyZXN0aW5nIGlkZWEuIEV4Y2VwdCB0aGF0IEknbSBub3Qg
c3VyZSBpbiBob3cNCj4gZmFyIGl0J2xsIGJlIHN1aXRhYmxlOiByZWFkX2xvY2soKSB3b24ndCBs
b2NrIG91dCB1c2VycyBvZiBqdXN0DQo+IGxvY2soKSwgc28gdGhlIHNvbHV0aW9uIGxvb2tzIHRh
aWxvcmVkIHRvIHlvdXIgdlBDSSB1c2UgY2FzZS4gWWV0DQo+IG9idmlvdXNseSAoSSB0aGluaykg
cmVhZF9sb2NrKCkgd291bGQgd2FudCB0byBiZWNvbWUgdXNhYmxlIGZvcg0KPiBlLmcuIHNpbXBs
ZSBsaXN0IHRyYXZlcnNhbCBhcyB3ZWxsLCBkb3duIHRoZSByb2FkLg0KDQoxLiBBc3N1bXB0aW9u
OiBfcGNpZGV2c19yd2xvY2sgaXMgdXNlZCB0byBwcm90ZWN0IHBkZXYNCnN0cnVjdHVyZSBpdHNl
bGYsIHNvIGFmdGVyIGNhbGxpbmcgcGNpZGV2c19sb2NrKCksIHBjaWRldnNfcmVhZF9sb2NrKCkN
CmFuZCBwY2lkZXZzX3dyaXRlX2xvY2soKSB3ZSBuZWVkIHRvIGNoZWNrIGlmIHBkZXYgIT0gTlVM
TA0KYXQgYWxsIHNpdGVzDQoNCjIuIF9wY2lkZXZzX3J3bG9jayBpcyBub3QgbWVhbnQgdG8gcHJv
dGVjdCB0aGUgY29udGVudHMgb2YgcGRldjoNCi0gZm9yIHRoYXQgX3BjaWRldnNfbG9jayBpcyB1
c2VkDQotIF9wY2lkZXZzX2xvY2sgZG9lc24ndCBwcm90ZWN0IHBkZXYtPnZwY2k6IGZvciB0aGF0
DQogwqAgcGRldi0+dnBjaS0+bG9jayBpcyB1c2VkLg0KDQozLiBDdXJyZW50IGNvZGUgd2lsbCBj
b250aW51ZSB1c2luZyBwY2lkZXZzX2xvY2soKSBhcyBpdCBpcyBub3cuDQpXaXRoIHRoZSBleGNl
cHRpb24gb2YgdGhlIHdyaXRlcnM6IHBjaV97YWRkfHJlbW92ZX1fZGV2aWNlLg0KVGhlc2Ugd2ls
bCB1c2UgcGNpZGV2c193cml0ZV9sb2NrKCkgaW5zdGVhZC4NCg0KNC4gdlBDSSBjb2RlLCBzdWNo
IGFzIHZwY2lfe3JlYWR8d3JpdGV9IHdpbGwgdXNlDQpwY2lkZXZzX3tyZWFkfHdyaXRlfV9sb2Nr
ICh3cml0ZSBtb2RlIGZvciBtb2RpZnlfYmFycykNCmFuZCBwZGV2LT52cGNpLT5sb2NrIHRvIHBy
b3RlY3QgYW5kL29yIG1vZGlmeSBwZGV2LT52cGNpLg0KVGhpcyBzaG91bGQgYmUgc2FmZSBiZWNh
dXNlIHVuZGVyIHRoZSByd2xvY2sgd2UgYXJlDQpndWFyYW50ZWVkIHRoYXQgcGRldiBleGlzdHMg
YW5kIG5vIG90aGVyIGNvZGUsIGJ1dCB2UENJIGNhbg0KcmVtb3ZlIHBkZXYtPnZwY2kuDQoNCmZv
cl9lYWNoX3BkZXYgYW5kIHBjaV9nZXRfcGRldl9ieV9kb21haW4sIHdoZW4gdXNlZCBieSB2UENJ
LA0Kd2UgdXNlIHBjaWRldnNfcmVhZF9sb2NrIGV4cGVjdGluZyB3ZSBvbmx5IG5lZWQgdG8gYWNj
ZXNzDQpwZGV2LT52cGNpLiBJZiB0aGlzIGlzIG5vdCB0aGUgY2FzZSBhbmQgd2UgbmVlZCB0byBt
b2RpZnkNCmNvbnRlbnRzIG9mIHBkZXYgd2UgbmVlZCB0byBhY3F1aXJlDQogwqDCoMKgIHNwaW5f
bG9ja19yZWN1cnNpdmUoJl9wY2lkZXZzX2xvY2spOw0Kd2l0aCBhIG5ldyBoZWxwZXIgNSkNCg0K
NS4gQSBuZXcgaGVscGVyIGlzIG5lZWRlZCB0byBhY3F1aXJlIHNwaW5fbG9ja19yZWN1cnNpdmUo
Jl9wY2lkZXZzX2xvY2spOw0KVGhpcyB3aWxsIGJlIHVzZWQgYnkgYXQgbGVhc3QgdlBDSSBjb2Rl
IGlmIGl0IG5lZWRzIG1vZGlmeWluZw0Kc29tZXRoaW5nIGluIHBkZXYgb3RoZXIgdGhhbiBwZGV2
LT52cGNpLiBJbiB0aGF0IGNhc2UNCndlICJ1cGdyYWRlIiBwY2lkZXZzX3JlYWRfbG9jaygpIHRv
IHBjaWRldnNfbG9jaygpDQoNClF1ZXN0aW9uOiBjYW4gYW55b25lIHBsZWFzZSBleHBsYWluIHdo
eSBwY2lkZXZzIGlzIGEgcmVjdXJzaXZlIGxvY2s/DQoNCj4NCj4gSmFuDQo+DQpUaGFuayB5b3Ug
YW5kIGhvcGUgdG8gaGVhciB5b3VyIHRob3VnaHQgb24gdGhlIGFib3ZlLA0KT2xla3NhbmRy


From xen-devel-bounces@lists.xenproject.org Tue Feb 15 16:09:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 16:09:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273378.468540 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nK0OK-0001nQ-Hi; Tue, 15 Feb 2022 16:09:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273378.468540; Tue, 15 Feb 2022 16:09:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nK0OK-0001nJ-Ea; Tue, 15 Feb 2022 16:09:24 +0000
Received: by outflank-mailman (input) for mailman id 273378;
 Tue, 15 Feb 2022 16:09:23 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nK0OJ-0001mt-5D; Tue, 15 Feb 2022 16:09:23 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nK0OJ-0005Bn-2d; Tue, 15 Feb 2022 16:09:23 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nK0OI-0007Li-Gm; Tue, 15 Feb 2022 16:09:22 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nK0OI-0003dg-Fu; Tue, 15 Feb 2022 16:09:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=AC3Ze8mf98BvSZkva9eN0UymUnZ3yBmmMzEaHGRMyV0=; b=42859O3LFNUutvMnOzEMBqRLQF
	fHkGVctt/hejMGBbPM4238NuYMWdSnvpDUGfIPFXwRyV4rIFSXraT1yKxrUWNdYua4uN42+TgQ4t0
	bTuWHm9VQjOUJLVYzd6bCrchiHbTuA5h/bU22NTIIWTFhSiVRI4q/ZIvmPQ25tR1SJyI=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168119-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 168119: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=85589ddbf6f8c6dc75f73aa32e484e3cfd439e7a
X-Osstest-Versions-That:
    ovmf=1193aa2dfbbd11fa7191d000a0cc166d03a249d2
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 15 Feb 2022 16:09:22 +0000

flight 168119 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168119/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 85589ddbf6f8c6dc75f73aa32e484e3cfd439e7a
baseline version:
 ovmf                 1193aa2dfbbd11fa7191d000a0cc166d03a249d2

Last test of basis   168115  2022-02-15 02:41:41 Z    0 days
Testing same since   168119  2022-02-15 10:43:01 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Rebecca Cran <quic_rcran@quicinc.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   1193aa2dfb..85589ddbf6  85589ddbf6f8c6dc75f73aa32e484e3cfd439e7a -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Tue Feb 15 16:13:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 16:13:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273389.468552 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nK0SJ-0003BO-3y; Tue, 15 Feb 2022 16:13:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273389.468552; Tue, 15 Feb 2022 16:13:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nK0SJ-0003BH-0C; Tue, 15 Feb 2022 16:13:31 +0000
Received: by outflank-mailman (input) for mailman id 273389;
 Tue, 15 Feb 2022 16:13:29 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=tLD3=S6=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nK0SH-0003BB-Qj
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 16:13:29 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 34b5809c-8e7a-11ec-8eb8-a37418f5ba1a;
 Tue, 15 Feb 2022 17:13:28 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 34b5809c-8e7a-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644941607;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=ovKE4XIz8gE4XZcO9a9G34fbK7KOG2SOPsUDCGOpP5o=;
  b=H5U1c+dC30Fap2g5gDgVDSidqG20fIbJ+5Zlu+BMZIFpE9GYbBZcKB/C
   3pvwXFQyt7/RNWSDl9Q8925ud4EAhupfXkqZe6uBrevfFbvQc36idQQpQ
   K2y6ebpq5We2wpsVRpSwk3JmQjktZKDgi+2yF2VJSRTFieyWa2sS/aROx
   M=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: HlZlE89tZQ1DGqZo6cQ2qZWp5fAscMbhlk7cgFRug8sb6D7UlMgNmnHpCUm+gboYmWYRY9AdZj
 UlzplqMLjuNfZ6kaHZ0MQ/b5QtMoKRdyzBfdzsXsV9Kh/vLCseMwNSNDoCEmgMH8/EDZ8+rjN4
 Z1tGHakLDyErwFwqKe2w1P91eixmvePSbyJxixs9p8RPQzVw8j7/+W9T9krMPSxxmbjeXf1cH9
 ZH/r4O4AniExz746ZIj0FZHGlY/nd/9T32EvNHq5F7WGhh+67O8btSWasMa2xwUYHMGa8TBm6o
 IWWwO/iHLjXel7SDRKseR0SR
X-SBRS: 5.1
X-MesageID: 64260135
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:KFtb6a4pjJ+2dJt/Dv2PwgxRtBLAchMFZxGqfqrLsTDasY5as4F+v
 mQYDG3SMvyCZjDweNsgYdy/pxxQvpTRzNJqS1ds/y5hHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FV8MpBsJ00o5wbZj29Mw2rBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zx
 uhA6aCXFSsVIqDBpdQxWBd+SB5nFPgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALJc/3PIQZqzd4wCvQF/oOSpHfWaTao9Rf2V/cg+gQQayAP
 5NCNFKDajyRbiYUEGcmB6hvs8GJhkj1Imdl+VaK8P9fD2/7k1UqjemF3MDuUsyHQ4BZk1iVo
 krC/n/lGVcKOdqH0z2H/3mwwOjVkkvTWogfCbm5/f5Cm0CIyyoYDxh+aLegiaDn0AjkAYsZc
 hFKvHp1xUQvyKC1ZtfAUkGEhyKoggIRVudgP+Y0zlqy04OBtm51GVM4ZjJGbdUnsuo/Sjory
 kKFkrvVONB/jFGGYSnDr+nJ9FteLQBQdDZfPnFcEWPp9vG++Nlbs/7Zcjp0/EdZZPXRECq4/
 T2FpTNWa1473Z9SjPXTEbwqbluRSnn1ouwdu1+/soGNtFoRiGuZi2uAswaz0Bq4BNzFJmRtR
 VBd8yRk0MgADIuWiAuGS/gXEbei6p6taWOA3QE/T8R8r232oRZPmLy8Bxkkei9U3jssI2e1M
 Cc/RysNjHOsAJdaRfAuON/gYyjb5aPhCc7kRpjpgilmOfBMmPu81Hg2Pya4hjm1+GB1yP1XE
 crLIK6EUCdBYYw6nWXeegvo+eJyrszI7TiIHs6TItXO+ef2WUN5vp9cawXQN7hgtvvbyOgXm
 v4GX/a3J9xkeLWWSkHqHUQ7djjm9FA3WsL7rdJ5bOmGLlY0EW0tEaaJk7ggZ5Zkj+JekeKRp
 iOxXUpRyVzeg3zbKFrVNiA/Oe23BZsv/2gmOSEMPEqz3yRxa4iY86pCJYA8eqMq9bI/wKcsH
 eUFYciJHt9GVi/Dp2YGdZD4oYE7LEariAuCMjCLej86e5I8FQXF9sW9Jlnk9TUUDzrxvsw7+
 uXy2gTeSJsFZgJjEMeJN67/kwLv5SAQwbsgUVHJL99ffFTX3LJrcyGh3OUqJ8wsKAnYwmfI3
 QihHhpF9/LGpJU48YeViPnc/ZupCeZ3AmFTA3LfseStLSDf82eund1AXeKPcWyPXW/44vz/N
 +BczvW6O/wbhlda9YF7Fu8zn6454tLuoZ5czxhlQyqXPwj6VOs4LynUx9RLu41M2qRd6Fm/V
 U+489VHPamEZZH+G1kLKQt5NumO2Jn4QNUJASjZ9Kki2BJKwQ==
IronPort-HdrOrdr: A9a23:ek4CqqudMiPMRsR2SAJhCF+O7skDjNV00zEX/kB9WHVpm6yj+v
 xGUs566faUskd0ZJhEo7q90ca7Lk80maQa3WBzB8bGYOCFghrKEGgK1+KLrwEIcxeUygc379
 YDT0ERMrzN5VgRt7eG3OG7eexQvOVuJsqT9JjjJ3QGd3AVV0l5hT0JbTpyiidNNXJ77ZxSLu
 v72uN34wCOVF4wdcqBCnwMT4H41qf2fMKPW29+O/Y/gjP+9Q+V1A==
X-IronPort-AV: E=Sophos;i="5.88,371,1635220800"; 
   d="scan'208";a="64260135"
Date: Tue, 15 Feb 2022 16:13:22 +0000
From: Anthony PERARD <anthony.perard@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: tools backports
Message-ID: <YgvRIszzjM/UB3Hh@perard.uk.xensource.com>
References: <710fd687-16d5-c088-d3be-749851e6eab3@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <710fd687-16d5-c088-d3be-749851e6eab3@suse.com>

On Mon, Feb 14, 2022 at 11:18:44AM +0100, Jan Beulich wrote:
> I have a couple of simple tool stack backports queued, which - with your
> agreement - I would want to put onto the stable tree whenever I get
> around to applying the next batch of backports:
> 
> d9d3496e817a tools/libs/light: don't touch nr_vcpus_out if listing vcpus and returning NULL
> e62cc29f9b6c tools/libs: Fix build dependencies
> 
> For 4.15 additionally
> 
> dd6c062a7a4a tools/libxl: Correctly align the ACPI tables
> 
> Please let me know if that's okay with you.

All looks good to go.

Thanks,


-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Tue Feb 15 16:14:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 16:14:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273394.468563 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nK0Sw-0003fy-CW; Tue, 15 Feb 2022 16:14:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273394.468563; Tue, 15 Feb 2022 16:14:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nK0Sw-0003fr-9A; Tue, 15 Feb 2022 16:14:10 +0000
Received: by outflank-mailman (input) for mailman id 273394;
 Tue, 15 Feb 2022 16:14:08 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=tLD3=S6=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nK0Su-0003BB-3p
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 16:14:08 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4c28c028-8e7a-11ec-8eb8-a37418f5ba1a;
 Tue, 15 Feb 2022 17:14:07 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4c28c028-8e7a-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644941646;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:content-transfer-encoding:in-reply-to;
  bh=Y/jaHwtNL/OjbjUcd0ZP5dRh8I3SPFyPOoEntw5YDac=;
  b=HFTq1Pa/cFChtTaa3r1gjRHGBxcLpHXqjMSTmqkQ/IO5kzwZbdILsZgj
   bVTeGS51iuLJ3PcZ1nvY5VgBxjNhReTMo1b7+1vgIRHd7efQjftmOeJUX
   PIBmOvWaZEZWYD/YdgqhLdiIobW2e0w/VAv8iR51JApOy+MziYF0yuSXh
   Y=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: 2w+Q22UDzKXMDI+Rpo8rpp3yWfiGdtl0y4JyFgyZ+LF8LG/CBA7Y77kG8Q/OAdzN6lHWbAFRWd
 T5jjj5bjGMC1MyqJ79q+G1h/XU8jfBRva/+lY2uu3EtP8kyUJVAg06F1mCCUJOgn5cm53SvajX
 nq4jYyMQWeqY8gRI1KL/pbegDnzWyN91BfdbBU0BNmArdmlvZVeNsIkCqus/Uq+GNoWbZByKmn
 cT0gHe9R6Fd6d1M//A3Uf41oOTF8N1rNGUFF2XR7hmqBXmQw9cbGLwsySGtWuk/6pX3bvklt22
 TnkLI2hkY18EYlb0tE6xSvZV
X-SBRS: 5.1
X-MesageID: 64260215
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:1Fy6lqNQ5atS2zPvrR2PkMFynXyQoLVcMsEvi/4bfWQNrUol12dSm
 jcYWGGHOarfNmGjLdknb4vj8UNSvZHQnNcwSAto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6UUsxNbVU8En1500s+w7VRbrNA2rBVPSvc4
 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq
 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYozyKm9Bu+
 NhPjJ+1VVoXB7PmssEEDBYNRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs
 6VFdnZdNXhvhMrvqF6/YuBqmsQkKtitJI4Fs2ts5TrYEewnUdbIRKCiCdpwgmtq2JgURKu2i
 8wxUzRINEzvOEN2Mw1NFI9muKCyiX/QSmgNwL6SjfVuuDWCpOBr65D9PdyQdtGUSMF9mkeDu
 nmA72n/GgsdNtGU1XyC6H3Eru3FkD7/WYkSPKal7fMsi1qWrlH/EzVPCwH9+6PgzBfjBZQPc
 CT45xbCs4A790irUenwXSS7pWLZgCcCcfB1CrI1vVTlJrXv3y6VAW0NTzhkYdMgtdMrSTFC6
 mJlj+8FFhQ07uTLFCv1GqO86GrrZHNLdTNqiTosEFNdi+QPtr3fmf4mojxLNKeuxuP4Fjjrq
 9xhhHhv3u5D5SLnOkjSwLwmv95OjsWTJuLWzl+ONo5A0u+eTNT7D7FEEXCBsZ59wH+xFzFtR
 kQslcmE9/wpBpqQjiGLS+hlNOj3u6raYG2B3AY2RMNJG9GRF5mLJ9443d2DDB0xbpZslcHBP
 Cc/Rj+9FLcMZSD3PMebkqq6CtgwzLiIKDgWfqu8Uza6WbAoLFXv1Hg3PSa4hjmx+GBxwfBXE
 crKKq6EUCdFYZmLORLrHo/xJ5dwnXtgrY4SLLimpymaPU22PSXLF+5daQHWMYjULsqs+W3oz
 jqWDOPSoz03bQE0SnK/HVc7IQ9YIH4lK4rxrsALJOePLhA/QDMqCuPLwKNncItgxvwHmuDN9
 3C7e0lZ1Fug2iGXdVTUMihuOOH1QJJyjXMnJihwb1ym7GcuPNS056AFepppIbR+rL5/zeR5R
 uUuctmbBqgdUSzO/jkQNMGvrIFreBmxqxiJOi6pPGo2c5J6HlSb8d74ZAr/siIJC3Pv58c5p
 rSh0CLdQIYCGFs+XJqHNqr3wgro73YHme90U0/ZGfVpeR3hoNpwNij8rv4rOMVQex/N8SSXi
 lSNChACqOiT/4JsqIvVhbqJppuCGvdlGhYIBHHS6Lu7OHWI/menxoMcAu+EcSqECTHx8aSmI
 +5U0+v9ILsMm1MT69hwFLNizKQf4drzpuAFklQ4TSuTN1n7WKl9JnSm3NVUsvwfz7BUjgK6R
 0aT94QIIr6OIs7kTAYcKQdNgj5vDh3Idu0+NcgIHXg=
IronPort-HdrOrdr: A9a23:2PIcVK4+U4y7jruZhAPXwM7XdLJyesId70hD6qhwISY6TiW9rb
 HLoB19726StN9xYgBEpTnuAsS9qB/nmaKdpLNhW4tKPzOW2ldATrsD0WKK+VSJcEfDH6xmpM
 RdmsBFeaTN5DNB7PoSjjPWL+od
X-IronPort-AV: E=Sophos;i="5.88,371,1635220800"; 
   d="scan'208";a="64260215"
Date: Tue, 15 Feb 2022 16:14:01 +0000
From: Anthony PERARD <anthony.perard@citrix.com>
To: Roger Pau =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>
CC: Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: Re: tools backports
Message-ID: <YgvRSZnDqO1CAWzV@perard.uk.xensource.com>
References: <710fd687-16d5-c088-d3be-749851e6eab3@suse.com>
 <Ygo1Hh8RoZfmPOjo@Air-de-Roger>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <Ygo1Hh8RoZfmPOjo@Air-de-Roger>

On Mon, Feb 14, 2022 at 11:55:26AM +0100, Roger Pau Monn� wrote:
> On Mon, Feb 14, 2022 at 11:18:44AM +0100, Jan Beulich wrote:
> > Anthony,
> > 
> > I have a couple of simple tool stack backports queued, which - with your
> > agreement - I would want to put onto the stable tree whenever I get
> > around to applying the next batch of backports:
> > 
> > d9d3496e817a tools/libs/light: don't touch nr_vcpus_out if listing vcpus and returning NULL
> > e62cc29f9b6c tools/libs: Fix build dependencies
> 
> I would also like to request:
> 
> 0bdc43c8de libxl: force netback to wait for hotplug execution before connecting

Looks good to be backported as well.

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Tue Feb 15 16:19:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 16:19:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273403.468574 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nK0Xi-0004QL-Vt; Tue, 15 Feb 2022 16:19:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273403.468574; Tue, 15 Feb 2022 16:19:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nK0Xi-0004QE-SP; Tue, 15 Feb 2022 16:19:06 +0000
Received: by outflank-mailman (input) for mailman id 273403;
 Tue, 15 Feb 2022 16:19:06 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=p95L=S6=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nK0Xi-0004Q8-Ck
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 16:19:06 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id fe867e47-8e7a-11ec-8eb8-a37418f5ba1a;
 Tue, 15 Feb 2022 17:19:05 +0100 (CET)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2051.outbound.protection.outlook.com [104.47.12.51]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-29-EMcPiap5NiuZiPPeZVSr0w-1; Tue, 15 Feb 2022 17:19:03 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DB6PR0401MB2598.eurprd04.prod.outlook.com (2603:10a6:4:39::7) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Tue, 15 Feb
 2022 16:19:01 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4975.015; Tue, 15 Feb 2022
 16:19:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fe867e47-8e7a-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644941944;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Ioi/htouuhSZmkaVTDshvz4D/moGu2rMwb80FkDpNE8=;
	b=QFPyg221VR3YqNPO4jUoJ4LgU2PdGRT+SR/mMR0BZG65LJLTa5QvosOuTP7La3UeF7pJ40
	P3UoF9mOVKGrfCLIeyh+Phq0WswC6MwhF1xMZyc1Bjv7GnD440phwDlDwaVuE3StumPFLZ
	9H3BujuVLyCszMYcK5TZBK50+wbyWCE=
X-MC-Unique: EMcPiap5NiuZiPPeZVSr0w-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Bq2riRRsWv8CzNne7c+nl8ELBbZkPP9279yn0ByKXQbnJQAXTvyT4vaxO3ee3kx5KKHdHlBTEeouKyCDUCRNseJb7W5WmCH5B/guX9xJi2jO9hfDna0Z145v9NAw2Dnt9CicvPnnnl3V8eKniYI/cmRRicPAF2GtlQfWBtFXbxAjXuxOw6X/uatHxugKF+4QZSgduBv7Tg/U6QTlDx06uTm2sxxpT60aY25jpe9STQ2P7B5Huq5slMQPFvlwfx4vq1PMIyRxAMQhnBq7n2R3teo2Xj1/VGyMw0dZ2jEZmB30fh4y6zgUZfdvvVEwESorxP7Dbxn1S3E1CLaapicK2Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Ioi/htouuhSZmkaVTDshvz4D/moGu2rMwb80FkDpNE8=;
 b=h842nNtrgcO0bEWqlFAHyUdzvWHjxkm3kS/rPbu9T9pxSHpgIOywz8MQCt8zVbhrfxCMLWM3N+b9TxDXayHSd6Ee/zWMvPFnb0RvW912tMg5R4t81lO7cNlgEeKF/Sq6SXr9+wLFv0mbumsI7eNV6dBYL5KCsMO0sgvI+z3IrK5a0IR6AdSCrPruJRZGjLyHrRc8x/Rn4rp8qOY1jVRC7mcWH8q3rxFfdalO0wPqbVpIacMmy+Pi6ylXtG8Rj8mkCW3SkVR93Z98nVz0JL4R1MFjVMghrmD+uFaGV/tibvaZfZPIuqs4jYeMbJBDenDF7bloE/4YH6683zEhXxPOnw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <0c7aa17a-1735-1d9c-9cec-fa3693025256@suse.com>
Date: Tue, 15 Feb 2022 17:18:59 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH v2] vpci: introduce per-domain lock to protect vpci
 structure
Content-Language: en-US
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "julien@xen.org" <julien@xen.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Artem Mygaiev <Artem_Mygaiev@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>
References: <20220215081135.1497470-1-andr2000@gmail.com>
 <YguE7RWOteSnvVNY@Air-de-Roger>
 <c5b9b02c-93f8-d018-6048-9abf2e7de4dc@epam.com>
 <YguQ8wfhfYFXTWSU@Air-de-Roger>
 <70dbd7fd-3f74-d0d3-6e30-c1e1e24fc279@epam.com>
 <0d8f01b2-b015-a08e-dd49-e9c688ff7245@suse.com>
 <bbb36ebc-de66-297d-f82f-abc0e63f20a2@epam.com>
 <22d25499-cab0-00c1-3ad3-bddd74c97a55@epam.com>
 <772eb410-be1a-3b5f-3b51-e363c43bc3c6@suse.com>
 <504327d2-0d82-7f88-e155-e6a45ba11a74@epam.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <504327d2-0d82-7f88-e155-e6a45ba11a74@epam.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR2P281CA0015.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:a::25) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 974fa0d6-ad75-4043-dac5-08d9f09ee056
X-MS-TrafficTypeDiagnostic: DB6PR0401MB2598:EE_
X-Microsoft-Antispam-PRVS:
	<DB6PR0401MB2598109FA7D301C3547E5E9FB3349@DB6PR0401MB2598.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7219;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	fsx3qjDNfj2G+mPamhLZrgZMgy26UIjzJ3SPqpr6VhMSnufSheumxFyCaOWdAQ0Qbsc7f4fw2cHyJEea0OoG26sSX8ayJ6jSq+rmt+tSOLp8pSpGxV/F1DKVOw9US2Kyljwcx37IWtdmnm+55RMdPNWQ4zMOU4CyH6tvTM0+75MCkoV4oz0zUevozMBmPmtd0PaqING1cWxG2rbkByg/CmPgZtyHcs69l2GuhVpZPY++DZiv4h044pJEYEBjZBbZ6be+mZ2X6/5mhNiqbTymGiCmzxqyljydqQcqR+fONI9bHybMUv1+J3Ns62rvOdTeLp7hu4+OtLu+RdYdEMEeP3tEDGaRgarHGTjcwxA7wlHEJt1g9WPL+HF7ErUbl+juJeU5RDBWfW0haewo5Hn/+CK1swwp5XYXjfj1NNEneuogNIXpXfcUJfOKnCUpEP7FuABDw+GkQXyUPyZ0d2fDFuxUJ9BqOKe5Uzei0zKKBF2hlJLD//NTB+4fLMK8133521xYev0nTNGnXaP6208h4e4dcx5DI/MIRzI+b647r2CzKPNmdcVS7AAA/XbtPDJofnTgiaVEhKgWnDBgqAYXsNywnSaoM4uKIi6BvOtnK0TPnCj3Qyd7VO3p3rELPcprsyLjfEq7Yl+JLfGP5RSZsDAoCT3PFd/oMnlUo1FjFSHSzYQBrG9xDPtn1hCcRjqn1EWaLRENypBVCTI9no/I3DxkDCrPY1+pwSdJRb1oTLP001LtSVUMRX3lCtssQKs/
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(36756003)(5660300002)(2616005)(7416002)(316002)(6506007)(2906002)(83380400001)(54906003)(31686004)(186003)(4744005)(53546011)(6512007)(26005)(38100700002)(6916009)(66476007)(66946007)(31696002)(86362001)(8936002)(66556008)(508600001)(6486002)(4326008)(8676002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ckZyYXlpZ3RTcWx5SWd6Q0tQUUMwaGZRbjAvc0JFaDlWZEtkTnM5TGs3NWZp?=
 =?utf-8?B?N0JZaGZMSVhMeG0xcGZ2Q1dxNnowZVpHb0lUdTc1TE5QOHByUHEvZ21LcWhX?=
 =?utf-8?B?aDVDNHpBUmR1Si90VnFyWkVpMys4RjhTV1RacnJ0VkNROGt0NkdRRE1zWHR6?=
 =?utf-8?B?aXh1UHBWb3ZSL1lQandJa0hRa3Q0NEE1dzgxMk85VU1PQXFhSStiL3Vlc1o1?=
 =?utf-8?B?clU2S3JUbXNpdWpTTVJRRFNRWnJWUWN0cjBOR1o5RDZtYVBBVmlZTUJUNENW?=
 =?utf-8?B?c1pCM3ZsUHp1Y1c4YkVtNllTQ2hvOUkzQ1hUYXZXWjB2NTBXQThwN0dnRm9i?=
 =?utf-8?B?KzRWWU84UjdRd1J6bm1GNkQzWFErQ2svRDI3K1ExbXZ4MVprVG84QXphV3Nh?=
 =?utf-8?B?SXZRM2dJYWNTNlNEdWlMbCsydW5ORUN5ZWZuQ1luQ3dnTjdoNDdkR1g3WmJC?=
 =?utf-8?B?Nzh6a0RUZlV6N29pOHJXb2hKVU9rcVdaZjRVdE9VMjJ5OXNZOExhT0ZFK0Yv?=
 =?utf-8?B?azdockwzdmxhSXVYOGQ5MXdHR29jSnp0MjJjdTlVdjFlaHN5RWJiRENhV3BF?=
 =?utf-8?B?WkpmbEl5eVEvcHFiaU9KVHNzS1dWUTBqNHdGcnV3OGlENE1HUWJVRTJ2MEJo?=
 =?utf-8?B?eFJlWmpQYjAxYnBuZVg4Y2NLRXBFMWhkVWRjd0ZLdmNGcVFuMEFqQUJSQVR1?=
 =?utf-8?B?UzM3bUMzakRBQmtDVVdBdjU5elc5VmhNVEVoYUxnYVVVaEhJWG0zZDdqQkp4?=
 =?utf-8?B?WHUzdE9FMytEaERhUnAvUWxlNHRwbHNFMzJaeXZRazUrdU9USENqRVJOL1JW?=
 =?utf-8?B?cHdXcTc0a1V1RS94RWF0L3p3UXFBbmk4bDVhTThrUHFqQ3dPdVJKRlp5NDdZ?=
 =?utf-8?B?REIxMmZjcXoxbTVVZ2dHRVdvdUh3Z3JVcGY0STBYYzhGQWhnOXlCQUR3RTdI?=
 =?utf-8?B?WUp2bHVtUndGSzFTWGFrd0VqQVo2VGNKQVQ3TDNWRk1uZExwaU9yS21xdzRU?=
 =?utf-8?B?RlAwdjBvWDdhTVg3Z1l3ZVJlSWx5THViOHdobTVqTVZJem0wOHRlZkhOeW1T?=
 =?utf-8?B?eVAvUEx1MXNmZ0JRa0tSeE9CRWdhV1dnYkhBbXppeGNkRVdFRy9FbU45YXJD?=
 =?utf-8?B?Si9PVnlqSWxEYklZYWhpMzdnRzd6aDlJSi81NThkeDhMdmI5U2V1MFFZQkRH?=
 =?utf-8?B?dFJ6RSsrTTRydmdwZG9mZ3Z6dEZxNVRJb2NRRkUyYUd1UnIzaFhPMml2QmpZ?=
 =?utf-8?B?MWNIUlA3NmhJdGdiU1duRzRzc1RVOGFGUXo0Njh3NTRDUFhBYjBNdHBab1JC?=
 =?utf-8?B?NTJiN3Eyb01wY1A0WExIcDRvT2JuTFMrVnZFN2tmK2IydEFwNHVodEFXb2RB?=
 =?utf-8?B?ZU1SeVg5dXA4WE9YOEZkWEpvaFFBSlBRbFgva2tjYTNwaWZSRFJ4M1NGb2k4?=
 =?utf-8?B?M1hZTy9ONENSTi9ZckNYOERuYWhpSytBMFpTTUQ4aEk0UnVoUm1jbGgrc05L?=
 =?utf-8?B?dWlpemllWXpGWVlKQVVrbUZncU9lK3FuN0tzK2JhbFZmaEd4bGpPbjkwajBG?=
 =?utf-8?B?dVRPSmFXWUFvOEdlcEttL3FaZnFwVGdLYXBUclZOcGRCOENoOU5HTTE4eWRF?=
 =?utf-8?B?QWpyZ0ZJK28vQXZMR3YwdmNubVZtblBEa3hkUjBybVVpV1NPWDl0Umh1L2hI?=
 =?utf-8?B?dFhiSjVXa095Uk1CQmlEUFkxNk1ZaWg5UXFLQ2lZaTJ4cE1kcUxsYzVsSXpE?=
 =?utf-8?B?STM5RExuWEZpOUZvUGV2UWdiUGtMTlBZNXRjTDZ6Tm1Hc3pCRVowY1dTMVMy?=
 =?utf-8?B?WC81MVFJRStETTJKbG9HMkhKMUJsYWNLMzYzN1ZndThNWDlBVjdWUy9meGRW?=
 =?utf-8?B?YkxVQkVSTjg5SzRFdnQ5SzdOSlBSZFpuS01XRExmcEVMdTN0WlRLR2xKcTdI?=
 =?utf-8?B?WDdUSWNBRGJzTUlmQXpScG9DNkIvdDFsVWpkVGVKdVJkYzBkejlWeUdJdUhV?=
 =?utf-8?B?MDdHeTduWGw5c1c1UlVNRE8rakJMdDdmZzFNRUtxNDNjY0ErUXg2TU5IdWh6?=
 =?utf-8?B?Q0gra3VQNzBjNGt3bEZnUFp6TUtXbElvaWJjclNObHl3V0pSNFdMbFh6Nk9B?=
 =?utf-8?B?OHdPd3BWVkVNbzAwUDI1dVVjbXJYVlNwMFlmcUpRajdldVpuNi84NHpCM0Y4?=
 =?utf-8?Q?dMt28JHeSSoIXOKt2N5Se5M=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 974fa0d6-ad75-4043-dac5-08d9f09ee056
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 16:19:01.1891
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kNsQ+SFe/hwUpP5bEH8TEYoBIrx9eILSp6vgMJRlzCI1yU5j5gkDToLASWG8mx8SF3IirOlc64yYUavc7YqRNw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0401MB2598

On 15.02.2022 16:46, Oleksandr Andrushchenko wrote:
> Question: can anyone please explain why pcidevs is a recursive lock?

Well, assuming you did look at the change making it so, can you be a
little more specific with your question? Are you perhaps suggesting
the original reason has disappeared, and no new one has appeared? I'm
afraid I have to repeat what I did say before: If you want to remove
the recursive nature of the lock, then it is all on you to prove that
there's no code path where the lock is taken recursively. IOW even if
no-one knew of a reason, you'd still need to provide this proof.
Unless of course we'd all agree we're okay to take the risk; I don't
see us doing so, though.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Feb 15 16:26:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 16:26:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273410.468585 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nK0em-0005rp-QG; Tue, 15 Feb 2022 16:26:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273410.468585; Tue, 15 Feb 2022 16:26:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nK0em-0005ri-Lv; Tue, 15 Feb 2022 16:26:24 +0000
Received: by outflank-mailman (input) for mailman id 273410;
 Tue, 15 Feb 2022 16:26:23 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=p95L=S6=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nK0el-0005rJ-U0
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 16:26:23 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 038460a6-8e7c-11ec-b215-9bbe72dcb22c;
 Tue, 15 Feb 2022 17:26:22 +0100 (CET)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2107.outbound.protection.outlook.com [104.47.17.107]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-5-8-W6kcDFO8aOSVdNv3RMdg-1; Tue, 15 Feb 2022 17:26:21 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB6781.eurprd04.prod.outlook.com (2603:10a6:803:13d::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.14; Tue, 15 Feb
 2022 16:26:19 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4975.015; Tue, 15 Feb 2022
 16:26:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 038460a6-8e7c-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644942382;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=/zGc6lomqXVQqe4hZn5voJRbGLdcElvRtfDbDBIQRUk=;
	b=fut90U8bxvWcCIg4f/zXDZaSANHDC0QY5BQZ9IO/2//Bmz5NnX7stLzteDbkiO7UeNzECT
	MizxqEM9QgLc7fzxUcd0koKY8JBcTkGijW94w0ZpkLsmOfbULmUJ/NiX72HLuzx8uTeoGE
	ES7xrgARNckB/LMQi2ilf6Wp/XAvLPM=
X-MC-Unique: 8-W6kcDFO8aOSVdNv3RMdg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ZWTczykSh8C+cZ0V/+MoqOXhnWuRxe7OBZ8uLZXBP0V7TffAzXheND4m/Tq1VmLNdO3h6Ac33iW9Blq/DFotxfPRQlWpXc9UV7Qgb+iAN2qVZkSDovl+GfQYpoxO65cCA2sI6zzXcK/GQ9AizDT+bZDtdbs202ehgAhfaa69yRm6Nb9Oe6Grg1p+LIGpReJ/y/SUL6JC3AX5dbLnMWtbp4y//dRTwepsHs8A9lPJOMpcoJ9Q9ozf/8CBoDpQcEZPasM9Q/8PEp7SVhBKJr1vn9i5sm1hR5sVRWP2i2NRetSj7o7nHU/0214LSvORRfZxJU/r0iFSUwH0AL+IjinbOQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=IZ14uvQIH2tniGvqaJVWY+ZYrk/pOz7yPpFUjPkXGSM=;
 b=TKb6I8xlC9U4hUiA10/lPdRudEM2LlD/lTKOtIQQWdd0c2XwXimQExOWeY2W5iA2p9SbXiwK0yd4qmH/cvvzf0Mbf4nGd72XfWpWlohFE0lGfHKFXOvoOcS3lw3JCtHVKMhI8VRDE4zrhzsLolt09KeUsL5LWk2oLSzVTN8Db1UBoVwwcj92I6pjyFa+hAOGjtj5hxcPz+9KHUoUJHo4AkUVC/MBRz5elCe4lQSMHP40rToyRBG1FMVS0W8kXZ+TkX8jN5vtfQZWaqmH1LLOEJAuGy+MyJeblV3PKlwqIaIGQU6DpwSx8jHbdn1mKnN+le/KNNPDBqUVd6eyTaOpLg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <2734ca9b-44dc-60a1-7027-924881c376aa@suse.com>
Date: Tue, 15 Feb 2022 17:26:17 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH v2 60/70] x86: Use control flow typechecking where
 possible
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
CC: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
 <20220214125127.17985-61-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220214125127.17985-61-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6PR05CA0011.eurprd05.prod.outlook.com
 (2603:10a6:20b:2e::24) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4f7eab21-a7d2-4b6e-1add-08d9f09fe5cd
X-MS-TrafficTypeDiagnostic: VI1PR04MB6781:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB6781F0855F8060C6F6FE0235B3349@VI1PR04MB6781.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7219;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	x+tcA/5UGvlIsGointZIBvm4khIq5/+8PenrXvAQC/WuhJq25lwJQ0ipO4Dm09vEjwrW0moNr5veKEtRCDPjANVBvoom5jNJtzufFvn6kexy2zukyfm5R2+g8seth+/EJb6J1TmwU8w9uoZEwK5Pu7clkvuJ+EyqMH/4YX/00U1LTtgr6sGtgv5t9P21tNlDdpq4uuIE+UFLV4zSqWN2IVEnFeOdsZr6u7X8vb+s5PM1E46a4IXtu6ZSPIrzDALZsMHPTOlYtrEjp5FtOORHNULf95AuwAGCL2G1DCFDCwQxdVi1xZ+GvKJdJzrEXp2aoDEhSCTsmHiQwdPsVRjqkuGg5Fhbk6rUNRcKMrXGGqzIow416uxZF4JFhXUadnx4Gpxq0JXvh4ZdB8jlDqvcNjQ+x5I4m3da0Dl0Bo7fVToNS/q7a1WIybMl9kmufRquZZcfbwtWrMcPBvOPP/1utgUywOyKuXR3hgWgZV4nRnmEVBFj7uDv4XV8h557BlEFOrmsyQ9qjeXYAYbQ58PJWwjydPZ/faNhMIBMNfDe3hbnSL83kEWSoQ+eplEa47I69j0wDrHeKBTO5l7i6NohWoWEAA1Oo0EAMb/RekZe/4a/6gY1g4ZOH/mg/tbE0mc5jucE8CvW5kniV4jIUqqFtC+vn8bqQkyuZxxk84WI2CvbhbNwILkZqF1LKtJEY34ykXspdMTrKjFP+jhmnrWIb4uuTMy/38Uch58qP7BkMAy2kZ1pIdlvgcOw4BCSgSrrNakv4ELIq5DTYodxvxIdPo2HJjjISHHOUUHuDqzXIjGB+lXZ4VaBu5XSjsquRwTQXoerGpopP7x2z51wSg4Fiw==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66476007)(4326008)(508600001)(66946007)(66556008)(8676002)(2906002)(6512007)(2616005)(31686004)(186003)(4744005)(5660300002)(53546011)(86362001)(83380400001)(6506007)(6916009)(54906003)(26005)(8936002)(31696002)(316002)(36756003)(966005)(6486002)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?M8AIKVv7tzFPn3Wt8HjCVNVBWPXRS0hUfzozdDieyFmDkQfZcjZD/qzPJDjt?=
 =?us-ascii?Q?ugaCb/joq9i2xwd8cd+o/VeBexRK4ciBh/fskGM6AYsjEejt5V4AZP/P8pnv?=
 =?us-ascii?Q?DprZ9rik5RdyBb+Myc3qYQEWo02BjWb+82jZf6eA6sMoh3rLlFpFv4BCa7bF?=
 =?us-ascii?Q?jVHw8RDDDgQkJhHQUfp53zQMU/GcGFvEABPWuUiiJADtZYpTpKnFKO545X3n?=
 =?us-ascii?Q?B0Ij0tH6dhmi65pVm0HuHb8f98g73vpjTmcV+RcxN5hE3G79+DqURDlLj2ff?=
 =?us-ascii?Q?l+SsOfFRm5wM/oqXUBvSwkdK5TS3fJmwTv10iCdWJhgl0S41B8pQRqHrejnZ?=
 =?us-ascii?Q?13U2WwS1iAC54oEOvQkI/JOHZzEKdd0XQyWmR9xL9cg1Wm/t+4KipDfoAnqB?=
 =?us-ascii?Q?vX38eTMi4QSlBAy8WTOiyXEPBF4wQLZK+Yq6qme7x6QgOicPRKVSHLq4djnK?=
 =?us-ascii?Q?S/aTritJEjNftT35zBrPzUxZvlLvNFchKnpPjIqgfigs+//4kzApM22lLmb5?=
 =?us-ascii?Q?7HFbt+Ac8eGRvOD9lhjTopOkDV+AAyzlPlC+88iwgCDUku50zcue2CoGBzee?=
 =?us-ascii?Q?3Q+umWNgnMcUJLybUZg1BkT028V+LLsujzG6+Pu0jsVIqNQSyRJO8cWQDfwT?=
 =?us-ascii?Q?3sD7dK+UelJ97hbuRm+kPnMK85NzRQT806enENsG2nYcAlT03XE3ueCDyQzd?=
 =?us-ascii?Q?RY+BAY4vLheFIWPFaTnXehhbiOLTZy+2DhAP6LH5nKr2Fb77Z0QhrDZEVrir?=
 =?us-ascii?Q?QbxS0LlAteVj3dCCHuY4qrZbd8syPFGFJJWk856dC9hhbHq52qRyGnbhJOKT?=
 =?us-ascii?Q?v7/+kWZycWc9tuPonkwGG1s5bQ2FLFnb1YUfWFJLGNj4Fov70HKay3++2VVx?=
 =?us-ascii?Q?DDCayRTDAZjmBP3sstQKyQOzkGOR6+XrdWpjzkGTrn2FmXgudUYmTun3wEdb?=
 =?us-ascii?Q?ad5gFjWITEqLuty1jCFrvWCjj5L1nO6kwtoMe+JTEUEQHrFZRW7nxp5BFVlF?=
 =?us-ascii?Q?amepoP16KeRaGI0IqrfFcyxgFWojmowgVhoLYRyYXcKJqz6EeDhVvFHeOPvN?=
 =?us-ascii?Q?m3UldMVHAiG51bf20WX6OmafqCTSJn07eTlekw3DpTY/OyCr32lAZX1PEaGo?=
 =?us-ascii?Q?5SnEaqdsxrCYdWW4XyWTIGWte1T7hrHGo2HrQhn/BK+bJcnXsGoYSecmxftT?=
 =?us-ascii?Q?4UxahxVB18GzulRADRuAN8w6/3ANGTPw/CeMrbracg3Xtcy7zemexMtX8yln?=
 =?us-ascii?Q?ojdtXk1Z+7slvprvTi4uYLb15soFRHVIoBkuQqiJiLxCBGUxnR1YIlO6cuiq?=
 =?us-ascii?Q?ct87X6u75sv/nygxIkZezHAknLnxrGqUPe9M8ur0z3N00s9TND7/KRkAhbKq?=
 =?us-ascii?Q?lXy1Z0+qa1yyWfnw7PFRxOb55ZlKA9j258WSrE20M2/s0bi44gpStdL8T06v?=
 =?us-ascii?Q?YO4j3VTXseZyeBcI5Ep911HocURZXKSEGlCQseCawzwXoW2X/wXXL8VAZJEE?=
 =?us-ascii?Q?Dz3ANOag/FJacd7noHXUjUTsRG2ZHIT7g4aESP+Yaf4Sr9TgAD3IxyqAij+e?=
 =?us-ascii?Q?U3qjMxENUMuhk/wC/v8lGjGEepPHleDFZdbnknDcuiAPCWPP3zGMRbfoO+4H?=
 =?us-ascii?Q?j2brkMeCnnz8bAji3CIcKzY=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4f7eab21-a7d2-4b6e-1add-08d9f09fe5cd
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 16:26:19.6932
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IsClXqFHQp+zyhdHb/O4IvgT+2sQlitvhzZGGIvJ49qAvHLioT2ZoaI1ITTQnw/90CV3Phftrz3Mot6jdyKTDQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6781

On 14.02.2022 13:51, Andrew Cooper wrote:
> Now all callees have been annotated, turn on typechecking to catch issues=
 in
> the future.
>=20
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> ---
> CC: Jan Beulich <JBeulich@suse.com>
> CC: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>
> CC: Wei Liu <wl@xen.org>
>=20
> RFC.  This is still an experimental compiler extention
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D102953

Hmm, the last update to that bugzilla entry was in November. I'm not
sure it is a good idea to carry code for something which hasn't even
reached gcc's master branch yet.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Feb 15 16:28:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 16:28:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273418.468596 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nK0gY-0006VK-9H; Tue, 15 Feb 2022 16:28:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273418.468596; Tue, 15 Feb 2022 16:28:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nK0gY-0006VB-5w; Tue, 15 Feb 2022 16:28:14 +0000
Received: by outflank-mailman (input) for mailman id 273418;
 Tue, 15 Feb 2022 16:28:13 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=xOiq=S6=epam.com=prvs=4045782cdb=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1nK0gX-0006V3-26
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 16:28:13 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 43c15f8c-8e7c-11ec-8eb8-a37418f5ba1a;
 Tue, 15 Feb 2022 17:28:11 +0100 (CET)
Received: from pps.filterd (m0174681.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 21FG7J3t001754;
 Tue, 15 Feb 2022 16:28:06 GMT
Received: from eur02-am5-obe.outbound.protection.outlook.com
 (mail-am5eur02lp2054.outbound.protection.outlook.com [104.47.4.54])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3e8ede8ham-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Tue, 15 Feb 2022 16:28:06 +0000
Received: from AM7PR03MB6325.eurprd03.prod.outlook.com (2603:10a6:20b:13c::18)
 by PAXPR03MB7665.eurprd03.prod.outlook.com (2603:10a6:102:200::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.19; Tue, 15 Feb
 2022 16:28:02 +0000
Received: from AM7PR03MB6325.eurprd03.prod.outlook.com
 ([fe80::1161:703b:9ce9:8e34]) by AM7PR03MB6325.eurprd03.prod.outlook.com
 ([fe80::1161:703b:9ce9:8e34%5]) with mapi id 15.20.4975.019; Tue, 15 Feb 2022
 16:28:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 43c15f8c-8e7c-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=MiPpVqF1nh/aazzzcQTdWvPc7FgLCxNUGA5FPRAgSs0d5wJOK99CQQyhvP5SJ9GygvQ9mxKu3GpYxGskb7Ye2OAI0i8p9Lh5iQWX+yXZFmyKl3XFYc/oTUKK4VIr9HH2pAxVhv+YzpELrIKFBNlItL+uwsGtczuNdnnvXhZtF3fYAzDm5DiEw3UqmJnBzGBmGH2FsBqufTgnesZa6HhL6nfo9Nfu3l1s2uZ3KXJifAaLL7aYB8PYiAwb5v5KyvMeQ6RfxVJmeYxCefsnPeOLNKoK1426lJjVybDPthzhe9uY617ukZt2XjvOltCNQKbvgUUPZedLycRbVpxnWArz+Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=VgZOaJt+FH67mQt3LsTqeHmCsVVjuzwlxt8mtpFdPQ4=;
 b=nGCkEWwqcRvRijvqher5pvMNojryGc99hZNtWAwGVocuv3eHuakr0atTYL3S85PdmXJ0IGN0Q6ZZYx0tPMkNlAjweQUR48WAQb1xOdE9SyR+r91CyMVDIoV5u+WqWvimNJBv8qqSzn8P3TsjcMy+ETNMKdl7ckuJFkQE8WJtat4A1FgtLxBqds+gjr0nCWPTbRwnz+xKRlqmIjekUMMUekER6bgVDPMyc13ZEWRpuv5XjJr0i8sjpgEb9YTj39RnAOcRxKRMrPwPKJSlSUFMXr0AszLyUs3gdQeV3VeEU2XHep/zBEjH1xDuE3Do0opKT7t/shon+ljCJFosKy7cVg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=VgZOaJt+FH67mQt3LsTqeHmCsVVjuzwlxt8mtpFdPQ4=;
 b=dvnaJQIfUPelv6Ltrx3BtAxLbWdQX99sIG4FDTWuWwt4YoPsRwwEjuQkrQVnxc+tL2aLZB1QMHFjZbR4c5JF0oBYqQ9HJrjjD4KkXjR5GTLX7E+/1d+VkeOCtnxC9eW48jPUfk8Uijnl3pKMH8xoKbw+B1JT1IHlF5UqnZGoQZg51MFjWkhCtHOWQtlwMQ8GvItj4fTxEF0icR9uVFovTi212VhdW0/AVv2A+o3URzwF/l80+kofvtEdVoQOv8hRldNg/CFL77l0A4w1570jloiSNTTuGhpgi1o5S+DMdEM7PAsDrrs1XOUHE/HLuJ/93Nkm2shkO5uuWnogB7W/mA==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>,
        =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?=
	<roger.pau@citrix.com>
Subject: Re: [PATCH v2] vpci: introduce per-domain lock to protect vpci
 structure
Thread-Topic: [PATCH v2] vpci: introduce per-domain lock to protect vpci
 structure
Thread-Index: 
 AQHYIkOs9pmsZb0l5kefj1m3qdTVCayUboeAgAAGwYCAAAeVgIAAAZQAgAABlwCAAAEVAIAADewAgAADdICAAC9JAIAACSyAgAAChoA=
Date: Tue, 15 Feb 2022 16:28:01 +0000
Message-ID: <8781c4ad-52c7-2e04-0901-b5b9a36c1904@epam.com>
References: <20220215081135.1497470-1-andr2000@gmail.com>
 <YguE7RWOteSnvVNY@Air-de-Roger>
 <c5b9b02c-93f8-d018-6048-9abf2e7de4dc@epam.com>
 <YguQ8wfhfYFXTWSU@Air-de-Roger>
 <70dbd7fd-3f74-d0d3-6e30-c1e1e24fc279@epam.com>
 <0d8f01b2-b015-a08e-dd49-e9c688ff7245@suse.com>
 <bbb36ebc-de66-297d-f82f-abc0e63f20a2@epam.com>
 <22d25499-cab0-00c1-3ad3-bddd74c97a55@epam.com>
 <772eb410-be1a-3b5f-3b51-e363c43bc3c6@suse.com>
 <504327d2-0d82-7f88-e155-e6a45ba11a74@epam.com>
 <0c7aa17a-1735-1d9c-9cec-fa3693025256@suse.com>
In-Reply-To: <0c7aa17a-1735-1d9c-9cec-fa3693025256@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 37c1814d-a932-498f-2e5e-08d9f0a022de
x-ms-traffictypediagnostic: PAXPR03MB7665:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <PAXPR03MB7665F05376ADD03EA1E32450E7349@PAXPR03MB7665.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 X+Hh8Gc4qOe47pht7h0rQPyjLfcn/ybf+kCEGgDvTutv8zv5jc+E/a856DRuavqFblSX2Z4odAsG27SPnivRMQXdqJgq4u1OiJEdezbGAYrGR7ekaweAI544hTxKHg2POFjMZQUQgQnzyBOcRZP68cbllMzscckQ4obP7q19jk3KDYla2NYfEGDadmu6B6e13WF7O3JsDjEtVL0w506wMGqqBX4smwKadUxdnhpjyLs6PoElayIwd5/focZhnQXZpJ+zqxqUJmjhQHySLTMKikk+MGhw2emFb1z3tzAJVdVBz18+soSA+5UFsmN1AsF+uPZZzRJX/ZXFdwg4rHXbLX3rWtZnaPxNZb135tyYVFh2Z0hXJszxKK/oTILJR/if9oWBEwP2zcP3iiPZAOOswbCvvbhOeQ/fUkXM/I9zhElHOPt/Fdinz2+EUBIentek23YZsL8e6oEnQQdmW/PMsKb6IKw3HUcYO1UZaPX2ebRCPh/xHfoMAPEUC0/26TD6N5EPRgOk+XYRfUWA7Jm1hFATOWMWQJoK69sw69LpFRYWi7c424SCjCNSKHqOdNZBvXobqko0FX3SuAQ13qvhlSuAxvAkKY2Oh9FUZz33CNC258DJvflQslkrrXIcss44LKn4YIAKBENqRu0h69xGAaq/CZ/2Fz8fe12BmVvF38XbWdTX418bAGfcFsKf4Ea7LT1bVnqwgBH/Cr6VfMj4bDuiqMegqnGrU/hAOnlrTZBi0t9LKQT0VHf7OH3TfQbkdSXWtIGeuxI7PcFQbCpypA==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM7PR03MB6325.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6486002)(6506007)(6512007)(53546011)(2616005)(83380400001)(8936002)(186003)(26005)(2906002)(71200400001)(508600001)(38100700002)(54906003)(6916009)(76116006)(122000001)(38070700005)(8676002)(86362001)(4326008)(64756008)(31696002)(36756003)(66556008)(316002)(31686004)(66446008)(66476007)(5660300002)(66946007)(21314003)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?cHdnYXlKdUlJci9tQjhDZS9jaDlKUjUxd3drc09IUE1zUFJtR3lhWFVjY2xu?=
 =?utf-8?B?MlVMNElVQ0dxWXF0NjNuZHFFWXMwSlpWYmFMOWd6VEw0ZVlRcnBPRGJqbU1Q?=
 =?utf-8?B?SWc2MkxWY0tsNUw0UWYzSUY1OGt0ZUlRQnFZL3dVT2Y1YzRqakJLTWYrekVL?=
 =?utf-8?B?cUlLSlpEbmhzam9XRHdtZ29MY1FGbGwyMmltcWZMcm1TUHViNUoxSzJzSDhO?=
 =?utf-8?B?aXBqZXd4RTJZQXZOOVliQWNoN2dvckZFTlh0N1Nod0ZWb1NhZ0FmN085NERt?=
 =?utf-8?B?bzllNWs1Nm1TL2NaeTdtK3l0cUs3UEQzRUNjd2RKRkpNaHRmNWprSzdwWXlH?=
 =?utf-8?B?R2RtQ2F6SUpjaE1VMHVHZEIvY1MvUHpqZUxsc045RWtPMExJYlJMSnIrVSt5?=
 =?utf-8?B?NFlEanRUUHhndURtVXVXQlBHcXNrMGlIYWFDWHJvU3lTSXNWbks0Nkgwbm4y?=
 =?utf-8?B?Qm12VklUVFZvU2FBWk14NmtoczNMMHo0cWhMNVhxYkhaTDkyMmdPQ1JjQXZV?=
 =?utf-8?B?SVJVSk9KcWpnZVk3OVNveUJPRm5pSmtnc1JxaTNrV0t0Q0pXbkx6eG02OFJ4?=
 =?utf-8?B?YkM2a050SGRWbE5mSERsblpxbmFYbVB0MTcvNGI1aTJscFVkeWJKOWJhUm9x?=
 =?utf-8?B?Y1dMazkrL09UeXJoOU0rOFFEellwK21JQnlGR2FEWkVWVXJMZXhhcW5HZDUz?=
 =?utf-8?B?bFY4NnlINHppYURZdG9RYTFvZGlVbXJYbFFPcnhhL1dMNHU4WndCdHhvOEU1?=
 =?utf-8?B?ZzNkcWhsK1VvQWVQbk9tenV2YXBxZ3dxRWZ3WE9hcXY1akd4ZXVmTm5sYndp?=
 =?utf-8?B?cmUzOGJmQ3dQWTZRSHREZk9pY3QyT0JhTnFBS2JWaVo1WGZLNnJWVDQvTEJS?=
 =?utf-8?B?ZVFNNnJvYmlqQUp3K2IvN1luaklYdHdsRFovaUlRK29pdkcvdGk1Ti8zTlB5?=
 =?utf-8?B?empJMG10WUN2dDQ4QUdVRVpuaTRTSS8vSUtlMkdEWmFBVnNOaGJqZVNsWDhM?=
 =?utf-8?B?eis2Y2dPcGtUVnV3WlhNVTA4U1FPZXJsak9mTFJKWjdOcjhTd0lja0dFL3hI?=
 =?utf-8?B?cmJIUDM1UElGajdWU3ZlczVuLy9YRDlpVkhpSDJrUWIyby9ibGlqQjU2RXZ3?=
 =?utf-8?B?ZTQwbTVQaFFxZllRKzFTWGRMUGdseXJ3WmNvNUxjUE9TZlpoRCtJUFAzOGRB?=
 =?utf-8?B?eFFBUWV0R1ljWTZGWWQ2eXV2OWVyVm1leXM5RW9WSUxERVMyeG4zdis1UHlk?=
 =?utf-8?B?NlA4SVY1VGVueDBTd0tUOVY0cXJONXNkNXFzM3Mxd0x2V3lPN0FibmVMQ2ZX?=
 =?utf-8?B?TW5NTTFoZUhEZ0R1dGR3TlY2OFpMQU55Y1M5Q095WEpaK04renpzbzlnMVp3?=
 =?utf-8?B?TTFEVmpWSUtnY1pUUnpSb2dJY05lU3ZCTWowWDJLL2oxMjFtRGtNODBRNW1h?=
 =?utf-8?B?cXRVazc4UlJBSFVlT00rbVJBZ3NnYVltT242eFp1cUNnSWg4TlJ1YzNhSUNi?=
 =?utf-8?B?ZWV6RlY1Ri94dng1eGJLbWo5RlpmTEpHNGNudDlrZjAwU2psbVRLTDFNQmlH?=
 =?utf-8?B?dHgrK2lUTUdyUjBRVVBKUTJib2RCVGlyTmpaNTBXZkx4czBneDdwTlpJRzNH?=
 =?utf-8?B?YUF4TjZFemZNNFR3RXpmM1kyMGpxL3MxQWh3L3hhdWdQaUYwUG9hL2xsemJ2?=
 =?utf-8?B?Y1dwaXRrOW5ucTZHUWEzUGhzVnFVQXcxWjE3NmNoaDBJNk4vY1VkZDBrc0pz?=
 =?utf-8?B?a2s4RHRpRTJsU3lVMkVrWkVxWUpFdHU5WUIyWDllN0VCb1FreE9TNDZRZkEz?=
 =?utf-8?B?WUZ6U2VBcjdmWDc0WnRvSUI4V0xLNnZ3N2V0b1JaTHQyTmpoSERCZjFDVTk2?=
 =?utf-8?B?NFN0SlRiV1owTkxsQ3htZ0F1d1hMRHhyRVU1Q0FKbGRuZjN5d28zT2c5Ky9Q?=
 =?utf-8?B?MWozc2cxbFppWlpHOXB5K2NKZk4xdWFTSzh3Rkx0Y1k0cmtTRDNDT1VaSHhN?=
 =?utf-8?B?eG1ZWXRNY04wWWUyOS9GOEpsSDVmUEVkclZ6MTZ5dzMrbytsZ0FKU0ptV3hp?=
 =?utf-8?B?cWFOc1BUZ3cwRGYxWVc2eCsrcUxLSndNck5kM3ovWjRiR1hwWWNxTEZFY2tW?=
 =?utf-8?B?N09qSVl3YnpPVXZoWjNYSXpjaVlPck11dFVsMVZzWWNnK0dMV2Vyc0xXUDF2?=
 =?utf-8?B?TmtCeVZsQ1RScXlhMUE4bFhXajJYT293VXdXUzRxU1VoRVNFenE3ZzFFT0Z1?=
 =?utf-8?B?RG9mRytpQVN6cFR5NmhXVUM4cGlRMkRaR2tERDVsaHRUUGhYZy9uLzdHR00z?=
 =?utf-8?B?aG1vOG9qRUlDZVovM2NlUHRBWFhnb05JM2YxSEViS3djUjM0T3cxUT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <7471F7BF7FA6B34EB3FF05463A450F5E@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM7PR03MB6325.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 37c1814d-a932-498f-2e5e-08d9f0a022de
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Feb 2022 16:28:01.8494
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 1JMPDibn9YbjWe14tC0dlzethwGHnLcavIbpvUP/+DB62ZL8DkVc2FxP6WM3RIC1MDFKqhQa0N37sYFvoh8qiEbMtz8p5sdMyTsYqhHhn7K5Ead2hXBBBfH6gvHa6Bsi
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR03MB7665
X-Proofpoint-GUID: RG2gtI7eFVMVEirT3TmUCuo-RSQ3Ignq
X-Proofpoint-ORIG-GUID: RG2gtI7eFVMVEirT3TmUCuo-RSQ3Ignq
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-15_04,2022-02-14_04,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501
 adultscore=0 mlxscore=0 mlxlogscore=837 bulkscore=0 malwarescore=0
 phishscore=0 clxscore=1015 spamscore=0 lowpriorityscore=0 suspectscore=0
 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202150097

DQoNCk9uIDE1LjAyLjIyIDE4OjE4LCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMTUuMDIuMjAy
MiAxNjo0NiwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+PiBRdWVzdGlvbjogY2Fu
IGFueW9uZSBwbGVhc2UgZXhwbGFpbiB3aHkgcGNpZGV2cyBpcyBhIHJlY3Vyc2l2ZSBsb2NrPw0K
PiBXZWxsLCBhc3N1bWluZyB5b3UgZGlkIGxvb2sgYXQgdGhlIGNoYW5nZSBtYWtpbmcgaXQgc28s
IGNhbiB5b3UgYmUgYQ0KPiBsaXR0bGUgbW9yZSBzcGVjaWZpYyB3aXRoIHlvdXIgcXVlc3Rpb24/
IEFyZSB5b3UgcGVyaGFwcyBzdWdnZXN0aW5nDQo+IHRoZSBvcmlnaW5hbCByZWFzb24gaGFzIGRp
c2FwcGVhcmVkLCBhbmQgbm8gbmV3IG9uZSBoYXMgYXBwZWFyZWQ/IEknbQ0KPiBhZnJhaWQgSSBo
YXZlIHRvIHJlcGVhdCB3aGF0IEkgZGlkIHNheSBiZWZvcmU6IElmIHlvdSB3YW50IHRvIHJlbW92
ZQ0KPiB0aGUgcmVjdXJzaXZlIG5hdHVyZSBvZiB0aGUgbG9jaywgdGhlbiBpdCBpcyBhbGwgb24g
eW91IHRvIHByb3ZlIHRoYXQNCj4gdGhlcmUncyBubyBjb2RlIHBhdGggd2hlcmUgdGhlIGxvY2sg
aXMgdGFrZW4gcmVjdXJzaXZlbHkuIElPVyBldmVuIGlmDQo+IG5vLW9uZSBrbmV3IG9mIGEgcmVh
c29uLCB5b3UnZCBzdGlsbCBuZWVkIHRvIHByb3ZpZGUgdGhpcyBwcm9vZi4NCj4gVW5sZXNzIG9m
IGNvdXJzZSB3ZSdkIGFsbCBhZ3JlZSB3ZSdyZSBva2F5IHRvIHRha2UgdGhlIHJpc2s7IEkgZG9u
J3QNCj4gc2VlIHVzIGRvaW5nIHNvLCB0aG91Z2guDQpUaGUgcXVlc3Rpb24gd2FzIGV4YWN0bHkg
YXMgYXNrZWQ6IEkgZG9uJ3QgdW5kZXJzdGFuZCB3aHkgaXQgaXMNCnJlY3Vyc2l2ZSBhbmQgZm9y
IHdoYXQgcmVhc29uLiBJIGFtIG5vdCBzdWdnZXN0aW5nIHdlIGJsaW5kbHkNCmNoYW5nZSBpdCB0
byBhIG5vcm1hbCBzcGlubG9jay4NCg0KTXkgaW1wcmVzc2lvbiB3YXMgdGhhdCB0aGUgY29kZSBp
cyBzdHJ1Y3R1cmVkIGluIGEgd2F5DQp0aGF0IHRoZSBzYW1lIGZ1bmN0aW9uYWxpdHkgaXMgY29k
ZWQgc3VjaCBhcyBmdW5jdGlvbnMsDQp3aGljaCBhbHJlYWR5IGhvbGQgdGhlIGxvY2ssIGNhbiBj
YWxsIG90aGVycyB3aGljaCBhcmUNCmFib3V0IHRvIGFjcXVpcmUgdGhlIHNhbWUuIFNvLCB0aGF0
IGFsbG93ZWQgbm90IGludHJvZHVjaW5nDQpYWFggYW5kIFhYWF91bmxvY2tlZCBmdW5jdGlvbiBw
YWlycyB3aGljaCBjYW4gYmUgZG9uZQ0KZm9yIG1hbnkgcmVhc29ucy4NCg0KVGhhdCdzIGl0DQoN
Cj4gSmFuDQo+DQo+DQpUaGFuayB5b3UsDQpPbGVrc2FuZHI=


From xen-devel-bounces@lists.xenproject.org Tue Feb 15 16:31:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 16:31:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273425.468607 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nK0ju-0007tK-Ph; Tue, 15 Feb 2022 16:31:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273425.468607; Tue, 15 Feb 2022 16:31:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nK0ju-0007tD-LW; Tue, 15 Feb 2022 16:31:42 +0000
Received: by outflank-mailman (input) for mailman id 273425;
 Tue, 15 Feb 2022 16:31:41 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=p95L=S6=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nK0jt-0007t7-5c
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 16:31:41 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c081c288-8e7c-11ec-b215-9bbe72dcb22c;
 Tue, 15 Feb 2022 17:31:40 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2169.outbound.protection.outlook.com [104.47.17.169]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-12-pcIB0EvtNmejYy2KTLnlJA-2; Tue, 15 Feb 2022 17:31:38 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by PA4PR04MB7552.eurprd04.prod.outlook.com (2603:10a6:102:ec::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.14; Tue, 15 Feb
 2022 16:31:37 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4975.015; Tue, 15 Feb 2022
 16:31:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c081c288-8e7c-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644942699;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=RrkKbgHIc2TJb3YDwe7Ap1m9A+vP/nGIA1Zn3ce45jY=;
	b=iGQNAJOB1iL0rXQFPBaI/C8MrJJ5D/GrD+FFtMG5cfuR5Qp7OfBDj4MRypA3vEGqp+a0C1
	fFAiEVVbM9JiWBQvcq71xJYbchJ8XrL9aZmFDGC7nRnpekRDoLPaf5iIbWXJlf31PF/vbK
	7mhfOs3XC+yMQiVxY7MwpseyR7cQlCk=
X-MC-Unique: pcIB0EvtNmejYy2KTLnlJA-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=nLaUdXysdkQb3IAfcs7uZADVf+LJUUy3lLzk0+lPIISoH2YQDXXx9QCURphGFVfTt7+4yRelore85kvZIu1Dvalc9vl4rknXLdKkazNSvClPPp84FrQTQRCGQaVXlHlQ+XJDhWKJ9J4RBnCHxgocMlwCuYZSiIIJWzWLFO8XklULpklnGR1q/HmL36qWdCVVr3phV+ASetKBDypAS8VotC7poLHbOHB8v4p2x+yUkHYTM2OWCvosQJDILF9JGH2hwgP1ztfpRgwiDrOUegfI1OhPgeMKeDpV1kIOdA9nfmRcAO9z31LX1/zudLi7OGzmH3XviTUUZ5K331P6T9rf0w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=RrkKbgHIc2TJb3YDwe7Ap1m9A+vP/nGIA1Zn3ce45jY=;
 b=g4bHWK4I3LqCEJ3KnqTW5mwmEf5ccQRLKioC6MGSU1k/++ZkpZ8J/YBjLD1kb57pAcPpZSP4Lmj7CVGjhqPj22yTXDJjsmBu8/B9/Ok23xQcK6cdaWZ4EJ3j+FiGSszicYNo4H3L9AzbAsD9UGsStz91f2tHiboWAbXfYwxSi9eIpKPPKlkuN2mrwb3pmvTOi5IlAW3OrCnEdSJW46EeVrW50ok0WcR53yGGyWT/Ca+M2IxFSjWBzhbA9+B35ER1mpSJ/53GCyZS7NcNSWxYIut03Vpjjfeml8Ir3XKNhsA56cy5yVMszqeH/nZLp3bv2PQI8EOxShDHRh3QJR28RA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <9f0bc5dd-8599-faa1-ac29-3ffc8250b162@suse.com>
Date: Tue, 15 Feb 2022 17:31:35 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH v2 64/70] x86: Introduce helpers/checks for endbr64
 instructions
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
 <20220214125127.17985-65-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220214125127.17985-65-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR07CA0002.eurprd07.prod.outlook.com
 (2603:10a6:20b:46c::20) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f163cdf6-a21e-4730-d572-08d9f0a0a2fc
X-MS-TrafficTypeDiagnostic: PA4PR04MB7552:EE_
X-Microsoft-Antispam-PRVS:
	<PA4PR04MB7552911DBFCFA0CA2AF21C18B3349@PA4PR04MB7552.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4125;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	JKsksosBcdeimtz0SQVXTJys40Y5RBBRWyGR12gqRrTAjodDZj2nH92ScrCYVGSq6jazu9EYQx+q1pveY1sFOeP2IixjNIvc/Rrq0QP25KKDFu+3jmAsHZYMnoTMzBrBnntDNp+FCWUWsIRL1Y1Nd/1JFFBmxXsuMA0FiDhAnIuYmvgQ1WO1XHHtIMcXnJNOTXK7GMJzKley5Q9q/5UXDY2PyzONj/wC245BD6wmzyswcl/h2NHdGJXNNAZ3f7+MG4BKUY8U6AuJJO1/5aRZI9qG5tJ7bq5ce/wEXOiO2XHzQDpLQ/cHjyHqU3wIkfcN8W6H0DLh+r3jgjxVg4OVCKEwPG8UVlU4xcwPG2+0aRvLWMJvJeKu7fyuXJVFf4yBgcN1okBtuPi3CTKvM6Yibm3Tv0ph5enxrqvO2AmOjiXboCrHfg2O/mcanMQOFXEUuMGgFpSXOrEja1mdPsSqTsidEtaTbDPQSwZNkrTonEEReUk4g4UOh5JFpKHJmk7wLg55UT+2iKCvRlLsI/h5lsR0iiXhAzisBTYv6z1ewTfK3AUdWV9BWtj349E3CcvPl2ldz7xHqVrK6fsK9Q6Y1+Rd+nb32BvgdpQ8G+jDZ8XmFQvq6p17olBpr9c6vyfq/wjbAXCpduA8hpPkG8N3vuePgkwB3a0M6m19diwOzG5Pl4eWwa9UmJoMwVu+YNWa9PYZDrqQta45ctBqr8P7ogMzC9NO/DLetxc/OD76F7nJqwUloq2Iih85eZDowJig
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6512007)(8936002)(6506007)(4326008)(508600001)(53546011)(5660300002)(8676002)(86362001)(66476007)(66556008)(66946007)(558084003)(186003)(2616005)(31696002)(26005)(2906002)(38100700002)(31686004)(6486002)(6916009)(54906003)(316002)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZGdjSEpMWWttT3hXUko4MUJRK2h4b0krQzRXNXdVRkRCVTNrdnZkeVU3Q1hS?=
 =?utf-8?B?Q082TUZYSFFZTVI5VzBrdXFacTBPR0hWSzhpbnVaRk4vckxZb1kxVitweGZI?=
 =?utf-8?B?N05hTHUrTU9YNGdKREllSG95UXBaYzFUSkFkZTQvOXovWUdQMG1zR3NjTUtI?=
 =?utf-8?B?Lys2eGxtWXZXczZTVHVJWVQxdUxwS0FyekNaTnJYVmZ3RjRWejZSTnIxVDVK?=
 =?utf-8?B?bS9ScWxWcm1QcjQ4QWRSL1F1K0o2UFg4UmVFRzVMeEdUbjRFemFReFlBd3g2?=
 =?utf-8?B?ekhCYkNrempNOGJHdFhaODRFTGNuK1d5eDc2TStaRXM2U1krM0ZVSHJuSnVl?=
 =?utf-8?B?SXZpL2ZZRWYyUkY1SHlYenlWTDk2dVpMclBMWkpGQ2xtNG84U2pUeG9mdGtk?=
 =?utf-8?B?N04zWDF0ZCt0dGEvYXpDcjM4eGxXR2RCKzVQUHI0Tnd3dDFJQXNVTTM0UUxI?=
 =?utf-8?B?b0dBcHdNa3R5c05vUGIxWm5qZjBVZnBxZU01d1JkeFdiK3pwTHIvUFM5MzRq?=
 =?utf-8?B?dkgwbEk0MUVtOXM1eW9RRVdXUFg0VXNTaTd0alkxQWQzdnUzcDl0RVpzZjdy?=
 =?utf-8?B?enhsVGhhOUNxZjZrRU1zNm9tVW5HNFptbUgzeXpSVTdvQXhNUGdDQUtmYkc1?=
 =?utf-8?B?aWRKM2Nzc3Zid2ZmMXFEMUpIUW15QWVuK3ZHRTljYXFVUU1uVG5FcFZkTjF0?=
 =?utf-8?B?YS9DSFY2TExFUmhGL0tvRWhvWmRieUN0Sml3cDQ2VUlZZFhuWE16cEdMUjI0?=
 =?utf-8?B?aDE2ZDlqNlFSOWo1aUpUYS9LbEp3MkV4VURXQmpGeEhSZTdsODJxR0dHM2Vy?=
 =?utf-8?B?alNIc3NGa1FkeTZCbmo0c1FxaHNoWlBUTnFxSGRESjhSRnFmUlpoQk0ybHFZ?=
 =?utf-8?B?R0FnOEtZbzhtYko0UGNiU2tIOTZNbHNpd1Z3R0ZNejhSZ3VHMlNzdnJiY3dW?=
 =?utf-8?B?cjNtMndwN0UrQ2ZnaTF3NkdaY2V4VElNR3pWS21ndW03eTVBelBzV1BwTXRL?=
 =?utf-8?B?bExic29JbXoxczJMcjBNV0VlRGJWN01ERzRRZ05NcGNScTd1R1lmc1p0eE9C?=
 =?utf-8?B?U1FCbnorb2hrVDJZKzdHNFlvWjBFb2JLVzE2ZXFLVGVONVdvNlR0MzNmek9O?=
 =?utf-8?B?NTJyRE1KekMwaGNLVzVxVFQ4c2NrUm0yTjlXcjV0QmtORDdJNE9sQmc5dHB5?=
 =?utf-8?B?aGc0TWNYT3liY0oreXYrY3Q0Ykp4SE14MmUzdGxTYkFSZ0dwM05xRmt4S0JE?=
 =?utf-8?B?T0RxRUthYVFoeEhWdjEyNy94UFFmamVwRUNnTklOQVBwWWNKK0VQTXBDa2Qy?=
 =?utf-8?B?UlBmSXhCaGRGMzY4M3pXMm9ITXJEamYrQTlMY2c0Z3pBcFFwTlNXaXdGeXlj?=
 =?utf-8?B?WGZTV3M5VGNiVEE1RUhoMTlRQmhLRVAyY1BiTnNLRGdYYlFXRlNEbmFLWXg4?=
 =?utf-8?B?aEZ4MGl2MGlqUTJidzl4bzBNYmxlNTBkV056Rms1YUdXUmVxYXY0Y3ZwS09o?=
 =?utf-8?B?d29MOXY3VmFZUW56QnlhNGZIeFgwMzJ5eGhOM3pKKzZTYUtPTUI4M25ITmZ4?=
 =?utf-8?B?TDdhSmhkTUtJR29kU0piQmFnbVJwL0tUTWIrZlA2bmdiNU5naGdObGIzZ2lS?=
 =?utf-8?B?R09uR0hSc0krQnNVTXhEelZFREdTVjZFbUx3NmJnWmUzdmMwYml1Slc1aDVI?=
 =?utf-8?B?MjI1akFUWURMTzBYdndXb0wxNXh0bm81eEFLRUZmbnBXSFFCOWx0amRHS0Vx?=
 =?utf-8?B?WTluMjlFTEVDL3pNM0EzTFdTTFJpMkkvL2c1SG5ta0tJbHBJVTVjak9RS3lv?=
 =?utf-8?B?c2paQXUyTzdzQml3YWVtbzNKZEgrNk40bzBQbVFDYzVhTk1rS3Z0RTZxUEp6?=
 =?utf-8?B?QnpUY1lydm92cVhVNmNqOWxiaGlqV1hHdXhnL3c0TEFhUUx1VkNjaXJCNnVG?=
 =?utf-8?B?TVRGbU5FZDlIeXlUMmNYTGF3eWlNY2lGRmJOUy9scHZ0aXgvbkd3Qm9JTHZt?=
 =?utf-8?B?VjNteDcxU2hhNThZL0NpL2NWSlJKbkxKYjNVdW1tbXdEY1dBVzg0SHdkNnVz?=
 =?utf-8?B?RDMzb2ZteTdUMzVGTlVwVEVPM2g5Ni9SaGhQckMvOUplMjFKMmhzRDVYQVl3?=
 =?utf-8?B?Tm1SR2hzbVhWM2hmMDVuMm84c2tINHR1dXh4UHltVW43TUdTUVdvZTNPOEtk?=
 =?utf-8?Q?+aZszRywEn1LQ7He6ghBtJ0=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f163cdf6-a21e-4730-d572-08d9f0a0a2fc
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 16:31:37.1423
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mfVBm+LcjAHp1UtNkby3ISEzwiyCi44zybrLY6yE1ECA7ncPX3MertEseukC+zZpLJteC7aAV/Xya+mVV5vfbA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7552

On 14.02.2022 13:51, Andrew Cooper wrote:
> ... to prevent the optimiser creating unsafe code.  See the code comment for
> full details.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Tue Feb 15 16:33:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 16:33:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273433.468617 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nK0lc-0008Tg-3h; Tue, 15 Feb 2022 16:33:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273433.468617; Tue, 15 Feb 2022 16:33:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nK0lc-0008TZ-0a; Tue, 15 Feb 2022 16:33:28 +0000
Received: by outflank-mailman (input) for mailman id 273433;
 Tue, 15 Feb 2022 16:33:25 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=sIVK=S6=citrix.com=Jane.Malalane@srs-se1.protection.inumbo.net>)
 id 1nK0lZ-0008TR-QF
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 16:33:25 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id fcd3b462-8e7c-11ec-8eb8-a37418f5ba1a;
 Tue, 15 Feb 2022 17:33:23 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fcd3b462-8e7c-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644942803;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=LRjKM8olk6HBnkJWLXgrzrwMBSbHlR+uBcK19SFdVD4=;
  b=e32r0Q7gQd9QZ9BCYr3+EjKlfN4VUlMx+Lg9V6LK/rV+O/EE2X5Qhen6
   pbg4SFT9fRyQ1G+SLHkXlgwCwE6rCL3d0SxLRmdL8Uy5lPSQ+Hwjt1s8E
   c3lfTjopzCaNuyDVTCzSKRg8Y09RdoAW9Bq0++15na/KA5R4stoRlXclU
   M=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: sbeiUBLXvB3iQuXgs81ByylMzozm0IgrXeZa/jgVuVJb9d9v6rMWU4/UPUOUcOeu+SGPkw2ZyC
 QxNi4yew2O/izK9FmxrS/zMR2uo3YfClSDelXDRlFn1vp+3I5IAj65dLajsy9p7tFAScUCBYsk
 QCjORdHhBD2IBN6tMQBsdCaRz4BJhxHIseV4QMgpGXptOWA/xA6EB0pycvdI2faDy5oKy+qV3O
 pTuiaQOqFy7Ej1de++ufgU08vHYWsn0nhfLHfduEoTb1IzYnnnlYKfzi4Y0zYut1iljvXY6Bu4
 9egW8JCbIZIQLm1gndZOYOhX
X-SBRS: 5.1
X-MesageID: 64261680
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:KUl+AK3zfjfhwgG9+vbD5bh3kn2cJEfYwER7XKvMYLTBsI5bp2MPm
 2cYWmCGPPvYYzCneNF+PY3i8kMHvpLUmN9kQFdspC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkS5PE3oHJ9RGQ74nRLlbHILOCanAZqTNMEn9700o5wrNh2eaEvPDia++zk
 YKqyyHgEAfNNw5cagr4PIra9XuDFNyr0N8plgRWicJj5TcypFFMZH4rHomjLmOQf2VhNrXSq
 9Avbl2O1jixEx8FUrtJm1tgG6EAaua60QOm0hK6V0U+6/TrS+NbPqsTbZIhhUlrZzqhrYwy6
 /pLpIeJUSwGJqDtpM4nUF5gHHQrVUFG0OevzXmXtMWSywvNcmf2wuUoB0YzVWEa0r8pWycUr
 6VecW1TKEDY7w616OvTpu1EpM0lIY/ONYcWvnhmwBnSDOo8QICFSKLPjTNd9Gls3J4XQ6aGD
 yYfQT43by7jQzFrAU4wA6Bjs+W513LFdyIN/Tp5ooJoujOOnWSdyoPFDt3RfdCbQNRPqWyRr
 GnG4mfRDwkTMZqUzj/t2mm3mubFkCf/WYQTPL617PhnhBuU3GN7IBcbT0ehqP+1zEu3QctCK
 lc88zAr66M18SSDTdTjXhv+vH+NuDYdXcZdF6sx7wTl4qjJ5UCfD2sNTD9EYfQnstM7QXoh0
 Vrht8PkA3ljvaOYTVqZ96yItnWiNC4NN2gAaCQYCwwf7LHLoos+kxbORdZLC7Oug5v+HjSY6
 y+OhDgzgfMUl8Fj/6em+VHKhRq8q56PSRQ6ji3VUXii9RhRf5O+asqj7l2z0BpbBN/HFB/b5
 iFCwpXAqrBVZX2QqMCTaNdRX5KG4eeeCSX3rkZiPqULzTfqw3H2KOi8/wpCDEtuN88Ffxrgb
 0nSpR5d6fdvAZe6UUNkS9nvUpp3lMAMAfygD6mJNYQWPvCdYSfapHkGWKKG44z6fKHAe4kbM
 IzTT8ujBG1y5U9PnGvvHLd1PVPGK0kDKYLvqXLTkk7PPVm2Pif9pVI53LymNL5R0U98iF+Jm
 +uzzuPTo/mlbMXwYzPM7akYJk0QIH4wCPje8pILKrHTclc7QDh6UZc9JI/NnKQ/wcxoehrgp
 CnhCie0NnKj7ZE4Fel6Qi86M+6+NXqOhXk6ITYtLT6VN4sLOu6SAFMkX8JvJ9EPrbU7pdYtF
 qVtU5jQU5xnF2WckxxAPMaVkWCXXEny7e54F3H+O2ZXkl8Jb1Ghx+IIiSO2r3dQV3Lu75Nhy
 1BivyuCKac+q81ZJJ++QNqkzk+rvGhbn+R3XkDSJcJUdlmq+49vQxEdRNdtSy3VARmclDacy
 SiMBhIU+bvEr4MvqYGbjqGYtYa5VeB5GxMCTWXc6L+3Mwjc/3aintAcALrZI2iFWTOm4rima
 MVU0+r4bK8NkmFVvtcuCL1s168/uYfi/ucI0gR+EXzXRF23Ebc8cGKe1MxCu/QVlL9UsAe7Q
 GyV/dxeNenbMc/pCgdJdgEkcv6CxbcfnTyLtaY5J0Dz5SlW+rubUBoNY0nQ2XIFdLYsadEr2
 +YsvsIS+jeTsBtyP4bUlD1Q+kSNMmcED/ctuKYFDdK5kQEs0FxDP8DRU3ek/JGVZtxQGUA2O
 TvI1rHajrFRy0eeIXo+EX/BgbhUiZgU4U0YyVYDIxKCm8bfh+9x1xpUqGxlQgNQxxRB8uRyJ
 mk0aBElefTQp29l1JpZQmShOwBdHxnIqEX+xmwAmHDdU0T1BHfGK3cwOLrV8U0Um46GkuO3I
 F1MJL7ZbAvX
IronPort-HdrOrdr: A9a23:C+JlraNZUqvc18BcT2T155DYdb4zR+YMi2TDiHoedfUFSKOlfp
 6V8MjzjSWE9Ar4WBkb6LS90DHpewKcyXcH2/hvAV7EZninhILIFvAt0WKG+Vzd8kLFh5ZgPM
 tbAspD4ZjLfCVHZKXBkUqF+rQbsaK6GcmT7I+0pRoMPGJXguNbnn1E426gYxBLrWJ9dP0E/e
 +nl7N6Tk2bCBIqh6qAdxw4dtmGg+eOuIPtYBYACRJiwhKJlymU5LnzFAXd9gsCUhtUqI1Ss1
 Ttokjc3OGOovu7whjT2yv49JJNgubszdNFGYilltUVEDPxkQylDb4RHoFq/QpF5N1H2mxa1u
 UkkC1QZvibLEmhJl1dlCGdnDUIFgxesEMKh2Xo20cL6vaJOg7SQ/Ax9L6xNCGpt3bI9esMoJ
 5jziaXsYFaAgjHmzm479/UVwtynk7xunY6l/UP5kYvHLf2x4Uh2bD30XklW6voJhiKorzP0d
 Mee/309bJTaxeXfnrZtm5gzJilWWkyBA6PRgwHttaO2zZbkXhlxw9ArfZv0Uso5dY4Ud1J9u
 7EOqNnmPVHSdIXd7t0AKMETdGsAmLATBrQOCaZIEjhFqsAJ3XRwqSHrIkd9aWvYtgF3ZEykJ
 POXBdRsnMzYVvnDYmU0JhC4nn2MS2AtPTWu4hjDrRCy8/BrYvQQFu+oQoV4ridSt0kc7jmZ8
 o=
X-IronPort-AV: E=Sophos;i="5.88,371,1635220800"; 
   d="scan'208";a="64261680"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Gj1ihSJ4ZUfXaQu6Gh2oSaSzCXQvzyt8RUnbc5tE9m0vybi4aorjvlyAf9+SC2vH6nLn8prYVgymjOaFHrMUTmsK0lJIlFyJ6WsnVwXOpqpJjjnVp8VxoYVeEGzeAyC5vM1daixYA04+2yD2kH5UkFiNynGcRE2g/gy4k0DEB1UA2P0sbaR3iTSI+Km6CTSssX5ioA3u3KyxXtCW0ofGmmfg6A+U6Iqa1tPeZa5JZIC+zsH7p1e79twqg6hJqlZseoenEVi1B+BiWjSFBO3J63VUzSun4C4DADrN/pmCgzFhPgeFoUEr++YrbXS7wgBOECNoAPJAa0Ww2XbL2QwpFA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=LRjKM8olk6HBnkJWLXgrzrwMBSbHlR+uBcK19SFdVD4=;
 b=W140MHVrHpj31pv9iJCk62CwBuT0I74PzA/RHGexevwN2UEekmlDupKbSQ3dP+WsHZYH8rW7jlA+lT4e7iK73m28TOuB5ogLJ07KJtI87kIZyIKqV/gwKVjKSwPsNO65TKVdSmgcYMnRw8nLtjoHmbxfmCsYg8Pbwd0xoMAf5wrf/iQM6ni0aZWSQc3D8so5gEMkS63/UHk2NL7BkgoJOXOuXmobP+NgA+CJzr30g9P0ye2u3JWkXQIh4ISUrKX3sRddHvDlyesalWJP0NxCwHZJbCGGfRWrGez8lYjf2cW0jz+FyKjG+IsI1ytebV/hAQur64WjrCLtWcqG+g7e8A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=LRjKM8olk6HBnkJWLXgrzrwMBSbHlR+uBcK19SFdVD4=;
 b=j3mjjo4gmE8PSkTfOI7knCQcJFloZWwRkf+GXv3IYLZxC/lH7F9VKRou//eoME09iqyQSCR+nroGXIdnI8UsdEtj2gXQFtglukp+WMuO5C/c9ViJ7JVL1uDQGznqi7/MRwr6w2MVxWaJafwDJ2RblAwmNS8d3BrJvUaYkzE7cg0=
From: Jane Malalane <Jane.Malalane@citrix.com>
To: Jan Beulich <jbeulich@suse.com>, Roger Pau Monne <roger.pau@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>, "Anthony
 Perard" <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, "George
 Dunlap" <George.Dunlap@citrix.com>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>,
	Jun Nakajima <jun.nakajima@intel.com>, Kevin Tian <kevin.tian@intel.com>,
	Roger Pau Monne <roger.pau@citrix.com>, Andrew Cooper
	<Andrew.Cooper3@citrix.com>
Subject: Re: [PATCH v2 1/2] xen+tools: Report Interrupt Controller
 Virtualization capabilities on x86
Thread-Topic: [PATCH v2 1/2] xen+tools: Report Interrupt Controller
 Virtualization capabilities on x86
Thread-Index: AQHYHE+TdJl64aH33EedeR0PZ4zblKyMkj6AgAGTLwCAABdDgIAABJKAgATOw4CAAAIAAIAAQJgAgADqygCAADOdAIAAAYiAgABRRgCAAALfgIAAFCIA
Date: Tue, 15 Feb 2022 16:33:15 +0000
Message-ID: <c548b7cb-dc83-b591-d82e-0c70490a38d2@citrix.com>
References: <20220207182101.31941-1-jane.malalane@citrix.com>
 <20220207182101.31941-2-jane.malalane@citrix.com>
 <YgTi6bzeojtcu0xL@Air-de-Roger>
 <dff9c5c0-7bee-ce0d-3288-91255a701c99@citrix.com>
 <YgZIo9VQktcqGHTD@Air-de-Roger>
 <6d924061-f2fd-5f3d-0f98-79e76398b908@suse.com>
 <6c9400b8-7c76-34c8-f69e-3fad1eb53b8c@citrix.com>
 <101b0950-b7f2-119b-b654-574a71cec3bc@suse.com>
 <1bac0507-9420-f0b9-f846-f1c73bf9678d@citrix.com>
 <42fb3257-0c36-c156-c81b-f70dd5f247aa@suse.com>
 <9721222d-1c0d-ddaf-fbc6-801f5d9445f5@citrix.com>
 <12727658-68f4-1785-9b37-c948eb2cba71@suse.com>
 <9ed50d7a-23c7-2405-ff5e-15cc02b0c67f@citrix.com>
 <7fbc16f6-4175-06e8-742c-9aa8c7eb3e91@suse.com>
In-Reply-To: <7fbc16f6-4175-06e8-742c-9aa8c7eb3e91@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: b523016b-a162-46c4-9d79-08d9f0a0dd9a
x-ms-traffictypediagnostic: BN7PR03MB3539:EE_
x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
x-microsoft-antispam-prvs: <BN7PR03MB353918E50F6036E8C3F387E981349@BN7PR03MB3539.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 2BZuS6gUXBbvfDIwb0RyVJO6YlsprD7lbLa3SdZMeFMTGpYGrwaCwjpZncCYfzuAAgiFBlNPC/hho3qS7pGtpJE+g7iKdzRFk17lUfVN55DXZUS/uirB1pDI9iJ29fDyLJQ6ANIgf1hK1TDOtQjlYIFP1g6chg7jGR7yz2RzAV5GOQ+mx6Fjm1BOfGeP6fnArXpZuOfpdbYNZERZK9pWfpvi4s10CFYNKj4YiAuPiCsI5N7iS3u2ALZIAEiuzQfDm3iUXOY8QmYvHqHMTaZqvNpNyAsfkQpuhPF2Q+fZS48pPpKNp3tQ9XbtzvKUo3xO9nB/VymWMEjD6+LRvwe3ecglSIkzpohqqtQl+Ltm7J/7UfEKOukjSr44NJ4gHCX3gt8U8yZjKTB8M/UB8+FjgOR64xBpceje7f3697ERGfhQiALBsZFoaK3Xg4BF4AcilC21vXqbjDw3e8lzhcOvq00DYakyo/As/wgnyVR5mDLzshDT0xO59HCwehvszVrPLMRSwRssXICGKTFbBtD9tAvDCbs8XDnpQ8Fg9NLQjwdxFG30ayBg+gi1b4ZdI2F6mvWOh5pEkKrpTpFufk+HIGeovvpdnsEvgc8+1fzrRDJsoQLnBW5Y2yt+Jq01KfKGGjD5n/Fe3IJ+fw1C8B0+2WxoDsViq6QjsmbF7DYOt4vy8uuuNnTXlzLmXQThIv08nkMUHupFQ9EA4Gun4W18F8Fk8J6hWpJtt5rG5VbFAt9bWpip5HR2vrL1WB8JAVhZ
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR03MB3391.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(36756003)(107886003)(186003)(26005)(2616005)(5660300002)(2906002)(7416002)(8936002)(6512007)(53546011)(71200400001)(6506007)(83380400001)(6486002)(508600001)(122000001)(8676002)(31686004)(4326008)(38100700002)(86362001)(76116006)(54906003)(110136005)(6636002)(91956017)(38070700005)(31696002)(82960400001)(66556008)(66476007)(64756008)(66446008)(66946007)(316002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?L3laNDh3ZHZhTG9kU2tZOXhmWmRTck1YQndyNnZlY1lsb3JveXA2MU9SK0wv?=
 =?utf-8?B?M3FUbjh6TkpUZUJxSEhwSWVTQ0xOMkxtTzRGczQ4ckJielVvZXNyWFlhaEJj?=
 =?utf-8?B?M29ZRnhqdWtoRWFNQ1FTVnQ0TW56cUx4b0ZvaW9DSGg4TmgrWDNRTS9nOXdx?=
 =?utf-8?B?TEJIemdTR2VDQ0c5Z21kRUhyc0MxZ1hzb1Ftekd0dmZWK01Sak5WRXFHRzRK?=
 =?utf-8?B?b3VscDluTHFMNG43QnZnU1BROEp3WGM2Vk80cEViakJJbTRXcnlyUkdYZ1lS?=
 =?utf-8?B?WmpKcjFKVUZIU1V6YkhzeDhQN2I2OXZGVWN4ZG5HbXc5aTk2aXNKWkxQaWpQ?=
 =?utf-8?B?VkFGRnI1R04vV2NRTDBmOForN0VZdnZxUzhpU0tlandTUFpUbWtBNHpJcDE0?=
 =?utf-8?B?Z2RHclR0UjdQU0NqNkdjYjU0K25TZlRaclVoV0lRRG52WnFjU0FVVVR4SjhV?=
 =?utf-8?B?eUJZWm8zbmd6ZFdWRFFOeTFobkNhYkpwcWN2dWFkZjlyeFI2ekE4ZlhOQmsv?=
 =?utf-8?B?cGQyVGx2Wmw2L2lTRmN0Q09GbnFpOFZwRE5JK3dWYmZBbWNZUGVvRWpOSU0v?=
 =?utf-8?B?U3h1REc1bGxQU21oWmphS0lOdEtJUXpzZ0VMdWFoT3VpOGh0djdBL2JyS1Y4?=
 =?utf-8?B?R1R0WEczTkVuTDV3bGpiWHpDUzhZMERyekc3UlpLNUNDRmlSTkJPUjlpRFlC?=
 =?utf-8?B?NWZPSm90UUJmdm1OcnJSWEZNcUtSU1FyMDZ0dUpGQVMvQVdlRDFPYys5VnJs?=
 =?utf-8?B?a3ZEbXRqODk0OXdPeEFvNDQ4NDJodm90MVdlQi9hL21ZREpGU2NGUnNwMERZ?=
 =?utf-8?B?Sms0R0J6dDgxVStJbHNyS3hPM0E2ZEo2c1BpRmpFVDJPRUl1dXQ4MTZLZ0Vr?=
 =?utf-8?B?KzJ0Ukl1QVhVdHg1T1N6Y0NGeG1ubEtyQ0s4cnhEY3BOdWZoSFpvRGhVejho?=
 =?utf-8?B?d3d5VFh2SmpKUVdCcEdpQVNkdnh1Nm14R20raFYzNCtqK21nVGd3ZE90Y0FZ?=
 =?utf-8?B?K2h3cEN3eE01TTdkY3VqNjA0N3FpeTJkRmtDR2pocGFqV3hwenY0a05YaGtn?=
 =?utf-8?B?Zk5CT0R1RWszV09Nd0M1ZFZrbFBKRHgrd2tyb1lGNW9VMzRrcTVxNlVRVkRO?=
 =?utf-8?B?R2Mrc0t0dmZIY2ZkSDNrc2U2dXllYmVqOTBnazNoeU9wSjdnWEJOZ2JEdzZW?=
 =?utf-8?B?QlQ0ZHNrTVkvN3luajY4eHVoU25EcUR4YzhUWnVyOHZUdGpSM2JLVzRkTmlL?=
 =?utf-8?B?M1dDZGsvenhVK3hSUExlZjJGWTdVWXN1M0xGSDFoTW81NDMxem03cWZMTnVI?=
 =?utf-8?B?ZFlyMzZ3dFlTYTFZV1JXejgzTDMrVXc1TjMyS3RjaG03bVV0cmU2RUN5SlR1?=
 =?utf-8?B?a1FmTlhiNnhsczZvSVZsdFJwM2pnOU1NalVZSVArL200T0RtS21DRGlsVjkz?=
 =?utf-8?B?cDJ2eGgxa2YxQ1VGVDkrWk9RS3hnOS9aUlpuVDFVZC9wdmhuTlNEODhaWkJX?=
 =?utf-8?B?bURnemZoL0xuWmZPSUEzNjZYVzlpNFBkTXhhb2h0VGtUN1M0U29yV1g3aDFv?=
 =?utf-8?B?S25RRUtueGpUekpCR0dncWlWeHJLaG1aMlJYdld5ZDlWbmMzTWpGZDl6TnBO?=
 =?utf-8?B?VHpkcHRoMFZ3NWF0YmZPdDBiaCtyc1gzVi83MjY4K3VPNnlKanUxS2NVR2RV?=
 =?utf-8?B?dysyMXVBZnNoOUFyNmgvYzM5TUhuN1RBZms0a2pyL1BDbi9zOUkzVG1ob2Y5?=
 =?utf-8?B?RjFQR3RGendBZk9VTDZaeURmaVR2VFdPK0RiSWk0eGZZY1N4azVwWE0wam5I?=
 =?utf-8?B?Q0EzR2R6dmxUekx4OTNZS3JXRUovVXBFcWlNdExFd25UeHRzUk8yRzVRNUpB?=
 =?utf-8?B?UUJNOXczMWEvVDFPelN1NXhHUDltUUdiMzY0Zys3dzJCa1V1Q0tJejZKdmll?=
 =?utf-8?B?YzN1OVphNjlVbGFEUWRSZExDWG5FZS9EYklHUkVSZnplaDlrRVdqVjNLdUZy?=
 =?utf-8?B?NVo5am90T3hweFRWWmtPcWt3ZUROeDFaME9NUDh1b2J4T1dHUmVJOU1VT0RW?=
 =?utf-8?B?akdaeGhWZ2RZM3ZsRXc2SEFkcGJwc2RoQVo5UVVDZFdtRllFZHVqcUt6ZTJY?=
 =?utf-8?B?aForTkVwNk9nSlVCdU9BTElVOHJ0VGdoQUhHM05vWGtrVFE0UlR6OENrbEIx?=
 =?utf-8?B?SkpLM1o2Z2VxaEVva0FlMDJ6ekQ5bEhDeWFOZzBNb2RuMCszcUUyTVdUM0JY?=
 =?utf-8?Q?PuveBNot4FEMok4XWZrRVGgAhtA17WZsgnZH8R0qlw=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <94411495C640F44298DE344FB64A77C6@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MWHPR03MB3391.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b523016b-a162-46c4-9d79-08d9f0a0dd9a
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Feb 2022 16:33:15.2185
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: VM+06Ly+w1/EbQhSnWC/4ijQyrcHy9BHfDRfbPZ27xlLxUK5mpEB2FzY38zGEuXHlbhSy/6q6AUmrYT8HoMD+wE/Wojz46YxklCmFRVWEHU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB3539
X-OriginatorOrg: citrix.com

T24gMTUvMDIvMjAyMiAxNToyMSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IFtDQVVUSU9OIC0gRVhU
RVJOQUwgRU1BSUxdIERPIE5PVCByZXBseSwgY2xpY2sgbGlua3MsIG9yIG9wZW4gYXR0YWNobWVu
dHMgdW5sZXNzIHlvdSBoYXZlIHZlcmlmaWVkIHRoZSBzZW5kZXIgYW5kIGtub3cgdGhlIGNvbnRl
bnQgaXMgc2FmZS4NCj4gDQo+IE9uIDE1LjAyLjIwMjIgMTY6MTAsIEphbmUgTWFsYWxhbmUgd3Jv
dGU6DQo+PiBPbiAxNS8wMi8yMDIyIDEwOjE5LCBKYW4gQmV1bGljaCB3cm90ZToNCj4+PiBbQ0FV
VElPTiAtIEVYVEVSTkFMIEVNQUlMXSBETyBOT1QgcmVwbHksIGNsaWNrIGxpbmtzLCBvciBvcGVu
IGF0dGFjaG1lbnRzIHVubGVzcyB5b3UgaGF2ZSB2ZXJpZmllZCB0aGUgc2VuZGVyIGFuZCBrbm93
IHRoZSBjb250ZW50IGlzIHNhZmUuDQo+Pj4NCj4+PiBPbiAxNS4wMi4yMDIyIDExOjE0LCBKYW5l
IE1hbGFsYW5lIHdyb3RlOg0KPj4+PiBPbiAxNS8wMi8yMDIyIDA3OjA5LCBKYW4gQmV1bGljaCB3
cm90ZToNCj4+Pj4+IFtDQVVUSU9OIC0gRVhURVJOQUwgRU1BSUxdIERPIE5PVCByZXBseSwgY2xp
Y2sgbGlua3MsIG9yIG9wZW4gYXR0YWNobWVudHMgdW5sZXNzIHlvdSBoYXZlIHZlcmlmaWVkIHRo
ZSBzZW5kZXIgYW5kIGtub3cgdGhlIGNvbnRlbnQgaXMgc2FmZS4NCj4+Pj4+DQo+Pj4+PiBPbiAx
NC4wMi4yMDIyIDE4OjA5LCBKYW5lIE1hbGFsYW5lIHdyb3RlOg0KPj4+Pj4+IE9uIDE0LzAyLzIw
MjIgMTM6MTgsIEphbiBCZXVsaWNoIHdyb3RlOg0KPj4+Pj4+PiBbQ0FVVElPTiAtIEVYVEVSTkFM
IEVNQUlMXSBETyBOT1QgcmVwbHksIGNsaWNrIGxpbmtzLCBvciBvcGVuIGF0dGFjaG1lbnRzIHVu
bGVzcyB5b3UgaGF2ZSB2ZXJpZmllZCB0aGUgc2VuZGVyIGFuZCBrbm93IHRoZSBjb250ZW50IGlz
IHNhZmUuDQo+Pj4+Pj4+DQo+Pj4+Pj4+IE9uIDE0LjAyLjIwMjIgMTQ6MTEsIEphbmUgTWFsYWxh
bmUgd3JvdGU6DQo+Pj4+Pj4+PiBPbiAxMS8wMi8yMDIyIDExOjQ2LCBKYW4gQmV1bGljaCB3cm90
ZToNCj4+Pj4+Pj4+PiBbQ0FVVElPTiAtIEVYVEVSTkFMIEVNQUlMXSBETyBOT1QgcmVwbHksIGNs
aWNrIGxpbmtzLCBvciBvcGVuIGF0dGFjaG1lbnRzIHVubGVzcyB5b3UgaGF2ZSB2ZXJpZmllZCB0
aGUgc2VuZGVyIGFuZCBrbm93IHRoZSBjb250ZW50IGlzIHNhZmUuDQo+Pj4+Pj4+Pj4NCj4+Pj4+
Pj4+PiBPbiAxMS4wMi4yMDIyIDEyOjI5LCBSb2dlciBQYXUgTW9ubsOpIHdyb3RlOg0KPj4+Pj4+
Pj4+PiBPbiBGcmksIEZlYiAxMSwgMjAyMiBhdCAxMDowNjo0OEFNICswMDAwLCBKYW5lIE1hbGFs
YW5lIHdyb3RlOg0KPj4+Pj4+Pj4+Pj4gT24gMTAvMDIvMjAyMiAxMDowMywgUm9nZXIgUGF1IE1v
bm7DqSB3cm90ZToNCj4+Pj4+Pj4+Pj4+PiBPbiBNb24sIEZlYiAwNywgMjAyMiBhdCAwNjoyMTow
MFBNICswMDAwLCBKYW5lIE1hbGFsYW5lIHdyb3RlOg0KPj4+Pj4+Pj4+Pj4+PiBkaWZmIC0tZ2l0
IGEveGVuL2FyY2gveDg2L2h2bS92bXgvdm1jcy5jIGIveGVuL2FyY2gveDg2L2h2bS92bXgvdm1j
cy5jDQo+Pj4+Pj4+Pj4+Pj4+IGluZGV4IDdhYjE1ZTA3YTAuLjQwNjBhZWYxYmQgMTAwNjQ0DQo+
Pj4+Pj4+Pj4+Pj4+IC0tLSBhL3hlbi9hcmNoL3g4Ni9odm0vdm14L3ZtY3MuYw0KPj4+Pj4+Pj4+
Pj4+PiArKysgYi94ZW4vYXJjaC94ODYvaHZtL3ZteC92bWNzLmMNCj4+Pj4+Pj4+Pj4+Pj4gQEAg
LTM0Myw2ICszNDMsMTUgQEAgc3RhdGljIGludCB2bXhfaW5pdF92bWNzX2NvbmZpZyhib29sIGJz
cCkNCj4+Pj4+Pj4+Pj4+Pj4gICAgICAgICAgICAgICAgICAgIE1TUl9JQTMyX1ZNWF9QUk9DQkFT
RURfQ1RMUzIsICZtaXNtYXRjaCk7DQo+Pj4+Pj4+Pj4+Pj4+ICAgICAgICAgICAgfQ0KPj4+Pj4+
Pj4+Pj4+PiAgICAgICAgDQo+Pj4+Pj4+Pj4+Pj4+ICsgICAgLyogQ2hlY2sgd2hldGhlciBoYXJk
d2FyZSBzdXBwb3J0cyBhY2NlbGVyYXRlZCB4YXBpYyBhbmQgeDJhcGljLiAqLw0KPj4+Pj4+Pj4+
Pj4+PiArICAgIGlmICggYnNwICkNCj4+Pj4+Pj4+Pj4+Pj4gKyAgICB7DQo+Pj4+Pj4+Pj4+Pj4+
ICsgICAgICAgIGFzc2lzdGVkX3hhcGljX2F2YWlsYWJsZSA9IGNwdV9oYXNfdm14X3ZpcnR1YWxp
emVfYXBpY19hY2Nlc3NlczsNCj4+Pj4+Pj4+Pj4+Pj4gKyAgICAgICAgYXNzaXN0ZWRfeDJhcGlj
X2F2YWlsYWJsZSA9IChjcHVfaGFzX3ZteF9hcGljX3JlZ192aXJ0IHx8DQo+Pj4+Pj4+Pj4+Pj4+
ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY3B1X2hhc192bXhfdmlydHVh
bF9pbnRyX2RlbGl2ZXJ5KSAmJg0KPj4+Pj4+Pj4+Pj4+PiArICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgY3B1X2hhc192bXhfdmlydHVhbGl6ZV94MmFwaWNfbW9kZTsNCj4+Pj4+
Pj4+Pj4+Pg0KPj4+Pj4+Pj4+Pj4+IEkndmUgYmVlbiB0aGluayBhYm91dCB0aGlzLCBhbmQgaXQg
c2VlbXMga2luZCBvZiBhc3ltbWV0cmljIHRoYXQgZm9yDQo+Pj4+Pj4+Pj4+Pj4geEFQSUMgbW9k
ZSB3ZSByZXBvcnQgaHcgYXNzaXN0ZWQgc3VwcG9ydCBvbmx5IHdpdGgNCj4+Pj4+Pj4+Pj4+PiB2
aXJ0dWFsaXplX2FwaWNfYWNjZXNzZXMgYXZhaWxhYmxlLCB3aGlsZSBmb3IgeDJBUElDIHdlIHJl
cXVpcmUNCj4+Pj4+Pj4+Pj4+PiB2aXJ0dWFsaXplX3gyYXBpY19tb2RlIHBsdXMgZWl0aGVyIGFw
aWNfcmVnX3ZpcnQgb3INCj4+Pj4+Pj4+Pj4+PiB2aXJ0dWFsX2ludHJfZGVsaXZlcnkuDQo+Pj4+
Pj4+Pj4+Pj4NCj4+Pj4+Pj4+Pj4+PiBJIHRoaW5rIHdlIGxpa2VseSBuZWVkIHRvIGJlIG1vcmUg
Y29uc2lzdGVudCBoZXJlLCBhbmQgcmVwb3J0IGh3DQo+Pj4+Pj4+Pj4+Pj4gYXNzaXN0ZWQgeDJB
UElDIHN1cHBvcnQgYXMgbG9uZyBhcyB2aXJ0dWFsaXplX3gyYXBpY19tb2RlIGlzDQo+Pj4+Pj4+
Pj4+Pj4gYXZhaWxhYmxlLg0KPj4+Pj4+Pj4+Pj4+DQo+Pj4+Pj4+Pj4+Pj4gVGhpcyB3aWxsIGxp
a2VseSBoYXZlIHNvbWUgZWZmZWN0IG9uIHBhdGNoIDIgYWxzbywgYXMgeW91IHdpbGwgaGF2ZSB0
bw0KPj4+Pj4+Pj4+Pj4+IGFkanVzdCB2bXhfdmxhcGljX21zcl9jaGFuZ2VkLg0KPj4+Pj4+Pj4+
Pj4+DQo+Pj4+Pj4+Pj4+Pj4gVGhhbmtzLCBSb2dlci4NCj4+Pj4+Pj4+Pj4+DQo+Pj4+Pj4+Pj4+
PiBBbnkgb3RoZXIgdGhvdWdodHMgb24gdGhpcz8gQXMgb24gb25lIGhhbmQgaXQgaXMgYXN5bW1l
dHJpYyBidXQgYWxzbw0KPj4+Pj4+Pj4+Pj4gdGhlcmUgaXNuJ3QgbXVjaCBhc3Npc3RhbmNlIHdp
dGggb25seSB2aXJ0dWFsaXplX3gyYXBpY19tb2RlIHNldCBhcywgaW4NCj4+Pj4+Pj4+Pj4+IHRo
aXMgY2FzZSwgYSBWTSBleGl0IHdpbGwgYmUgYXZvaWRlZCBvbmx5IHdoZW4gdHJ5aW5nIHRvIGFj
Y2VzcyB0aGUgVFBSDQo+Pj4+Pj4+Pj4+PiByZWdpc3Rlci4NCj4+Pj4+Pj4+Pj4NCj4+Pj4+Pj4+
Pj4gSSd2ZSBiZWVuIHRoaW5raW5nIGFib3V0IHRoaXMsIGFuZCByZXBvcnRpbmcgaGFyZHdhcmUg
YXNzaXN0ZWQNCj4+Pj4+Pj4+Pj4geHsyfUFQSUMgdmlydHVhbGl6YXRpb24gd2l0aCBqdXN0DQo+
Pj4+Pj4+Pj4+IFNFQ09OREFSWV9FWEVDX1ZJUlRVQUxJWkVfQVBJQ19BQ0NFU1NFUyBvcg0KPj4+
Pj4+Pj4+PiBTRUNPTkRBUllfRVhFQ19WSVJUVUFMSVpFX1gyQVBJQ19NT0RFIGRvZXNuJ3Qgc2Vl
bSB2ZXJ5IGhlbHBmdWwuIFdoaWxlDQo+Pj4+Pj4+Pj4+IHRob3NlIHByb3ZpZGUgc29tZSBhc3Np
c3RhbmNlIHRvIHRoZSBWTU0gaW4gb3JkZXIgdG8gaGFuZGxlIEFQSUMNCj4+Pj4+Pj4+Pj4gYWNj
ZXNzZXMsIGl0IHdpbGwgc3RpbGwgcmVxdWlyZSBhIHRyYXAgaW50byB0aGUgaHlwZXJ2aXNvciB0
byBoYW5kbGUNCj4+Pj4+Pj4+Pj4gbW9zdCBvZiB0aGUgYWNjZXNzZXMuDQo+Pj4+Pj4+Pj4+DQo+
Pj4+Pj4+Pj4+IFNvIG1heWJlIHdlIHNob3VsZCBvbmx5IHJlcG9ydCBoYXJkd2FyZSBhc3Npc3Rl
ZCBzdXBwb3J0IHdoZW4gdGhlDQo+Pj4+Pj4+Pj4+IG1lbnRpb25lZCBmZWF0dXJlcyBhcmUgcHJl
c2VudCB0b2dldGhlciB3aXRoDQo+Pj4+Pj4+Pj4+IFNFQ09OREFSWV9FWEVDX0FQSUNfUkVHSVNU
RVJfVklSVD8NCj4+Pj4+Pj4+Pg0KPj4+Pj4+Pj4+IE5vdCBzdXJlIC0gInNvbWUgYXNzaXN0YW5j
ZSIgc2VlbXMgc3RpbGwgYSBsaXR0bGUgYmV0dGVyIHRoYW4gbm9uZSBhdCBhbGwuDQo+Pj4+Pj4+
Pj4gV2hpY2ggcm91dGUgdG8gZ28gZGVwZW5kcyBvbiB3aGF0IGV4YWN0bHkgd2UgaW50ZW5kIHRo
ZSBiaXQgdG8gYmUgdXNlZCBmb3IuDQo+Pj4+Pj4+Pj4NCj4+Pj4+Pj4+IFRydWUuIEkgaW50ZW5k
ZWQgdGhpcyBiaXQgdG8gYmUgc3BlY2lmaWNhbGx5IGZvciBlbmFibGluZw0KPj4+Pj4+Pj4gYXNz
aXN0ZWRfeHsyfWFwaWMuIFNvLCB3b3VsZCBpdCBiZSBpbmNvbnNpc3RlbnQgdG8gcmVwb3J0IGhh
cmR3YXJlDQo+Pj4+Pj4+PiBhc3Npc3RhbmNlIHdpdGgganVzdCBWSVJUVUFMSVpFX0FQSUNfQUND
RVNTRVMgb3IgVklSVFVBTElaRV9YMkFQSUNfTU9ERQ0KPj4+Pj4+Pj4gYnV0IHN0aWxsIGNsYWlt
IHRoYXQgeHsyfWFwaWMgaXMgdmlydHVhbGl6ZWQgaWYgbm8gTVNSIGFjY2Vzc2VzIGFyZQ0KPj4+
Pj4+Pj4gaW50ZXJjZXB0ZWQgd2l0aCBYRU5fSFZNX0NQVUlEX1gyQVBJQ19WSVJUIChpbiB0cmFw
cy5jKSBzbyB0aGF0LCBhcyB5b3UNCj4+Pj4+Pj4+IHNheSwgdGhlIGd1ZXN0IGdldHMgYXQgbGVh
c3QgInNvbWUgYXNzaXN0YW5jZSIgaW5zdGVhZCBvZiBub25lIGJ1dCB3ZQ0KPj4+Pj4+Pj4gc3Rp
bGwgY2xhaW0geHsyfWFwaWMgdmlydHVhbGl6YXRpb24gd2hlbiBpdCBpcyBhY3R1YWxseSBjb21w
bGV0ZT8gTWF5YmUNCj4+Pj4+Pj4+IEkgY291bGQgYWxzbyBhZGQgYSBjb21tZW50IGFsbHVkaW5n
IHRvIHRoaXMgaW4gdGhlIHhsIGRvY3VtZW50YXRpb24uDQo+Pj4+Pj4+DQo+Pj4+Pj4+IFRvIHJl
cGhyYXNlIG15IGVhcmxpZXIgcG9pbnQ6IFdoaWNoIGtpbmQgb2YgZGVjaXNpb25zIGFyZSB0aGUg
Y29uc3VtZXIocykNCj4+Pj4+Pj4gb2YgdXMgcmVwb3J0aW5nIGhhcmR3YXJlIGFzc2lzdGFuY2Ug
Z29pbmcgdG8gdGFrZT8gSW4gaG93IGZhciBpcyB0aGVyZSBhDQo+Pj4+Pj4+IHJpc2sgdGhhdCAi
c29tZSBhc3Npc3RhbmNlIiBpcyBvdmVyYWxsIGdvaW5nIHRvIGxlYWQgdG8gYSBsb3NzIG9mDQo+
Pj4+Pj4+IHBlcmZvcm1hbmNlPyBJIGd1ZXNzIEknZCBuZWVkIHRvIHNlZSBjb21tZW50IGFuZCBh
Y3R1YWwgY29kZSBhbGwgaW4gb25lDQo+Pj4+Pj4+IHBsYWNlIC4uLg0KPj4+Pj4+Pg0KPj4+Pj4+
IFNvLCBJIHdhcyB0aGlua2luZyBvZiBhZGRpbmcgc29tZXRoaW5nIGFsb25nIHRoZSBsaW5lcyBv
ZjoNCj4+Pj4+Pg0KPj4+Pj4+ICs9aXRlbSBCPGFzc2lzdGVkX3hhcGljPUJPT0xFQU4+IEI8KHg4
NiBvbmx5KT4NCj4+Pj4+PiArRW5hYmxlcyBvciBkaXNhYmxlcyBoYXJkd2FyZSBhc3Npc3RlZCB2
aXJ0dWFsaXphdGlvbiBmb3IgeEFQSUMuIFRoaXMNCj4+Pj4+PiArYWxsb3dzIGFjY2Vzc2luZyBB
UElDIHJlZ2lzdGVycyB3aXRob3V0IGEgVk0tZXhpdC4gTm90aWNlIGVuYWJsaW5nDQo+Pj4+Pj4g
K3RoaXMgZG9lcyBub3QgZ3VhcmFudGVlIGZ1bGwgdmlydHVhbGl6YXRpb24gZm9yIHhBUElDLCBh
cyB0aGlzIGNhbg0KPj4+Pj4+ICtvbmx5IGJlIGFjaGlldmVkIGlmIGhhcmR3YXJlIHN1cHBvcnRz
IOKAnEFQSUMtcmVnaXN0ZXIgdmlydHVhbGl6YXRpb27igJ0NCj4+Pj4+PiArYW5kIOKAnHZpcnR1
YWwtaW50ZXJydXB0IGRlbGl2ZXJ54oCdLiBUaGUgZGVmYXVsdCBpcyBzZXR0YWJsZSB2aWENCj4+
Pj4+PiArTDx4bC5jb25mKDUpPi4NCj4+Pj4+DQo+Pj4+PiBCdXQgaXNuJ3QgdGhpcyBjb250cmFk
aWN0b3J5PyBEb2Vzbid0IGxhY2sgb2YgQVBJQy1yZWdpc3RlciB2aXJ0dWFsaXphdGlvbg0KPj4+
Pj4gbWVhbiBWTSBleGl0cyB1cG9uIChtb3N0KSBhY2Nlc3Nlcz8NCj4+Pj4NCj4+Pj4gWWVzLCBp
dCBkb2VzIG1lYW4uIEkgZ3Vlc3MgdGhlIGFsdGVybmF0aXZlIHdvdXVsZCBiZSB0aGVuIHRvIHJl
cXVpcmUNCj4+Pj4gQVBJQy1yZWdpc3RlciB2aXJ0dWFsaXphdGlvbiBmb3IgZW5hYmxpbmcgeEFQ
SUMuIEJ1dCBhbHNvLCBhbHRob3VnaCB0aGlzDQo+Pj4+IGRvZXNuJ3QgcHJvdmlkZSBtdWNoIGFj
Y2VsZXJhdGlvbiwgZXZlbiBnZXR0aW5nIGEgVk0gZXhpdCBpcyBzb21lDQo+Pj4+IGFzc2lzdGFu
Y2UgaWYgY29tcGFyZWQgdG8gaW5zdGVhZCBnZXR0aW5nIGFuIEVQVCBmYXVsdCBhbmQgaGF2aW5n
IHRvDQo+Pj4+IGRlY29kZSB0aGUgYWNjZXNzLg0KPj4+DQo+Pj4gSSBhZ3JlZSBoZXJlLCBhbGJl
aXQgSSdkIGxpa2UgdG8gbWVudGlvbiB0aGF0IEVQVCBmYXVsdHMgYXJlIGFsc28gVk0NCj4+PiBl
eGl0cy4gQWxsIG15IGVhcmxpZXIgY29tbWVudCB3YXMgYWJvdXQgaXMgdGhhdCB0aGlzIHBpZWNl
IG9mIGRvYw0KPj4+IHdhbnRzIHRvIGV4cHJlc3MgcmVhbGl0eSwgd2hpY2hldmVyIHdheSBpdCBp
cyB0aGF0IHRoaW5ncyBlbmQgdXANCj4+PiBiZWluZyBpbXBsZW1lbnRlZC4NCj4+DQo+PiBPaCB5
ZXMuIFJpZ2h0LCBJIHNlZSBob3cgdGhpcyBpbmZvIGNvdWxkIGJlIG1pc2xlYWRpbmcuDQo+Pg0K
Pj4gSG93IGFib3V0IHRoaXM/Li4uDQo+IA0KPiBHZXR0aW5nIGNsb3NlLiBUaGUgdGhpbmcgSSBj
YW4ndCBqdWRnZSBpcyB3aGV0aGVyIHRoaXMgbGV2ZWwgb2YgdGVjaG5pY2FsDQo+IGRldGFpbCBp
cyBzdWl0YWJsZSBmb3IgdGhpcyBkb2MuIEp1c3Qgb25lIGZ1cnRoZXIgcmVtYXJrOg0KDQpVbnN1
cmUgdG9vLg0KDQo+PiArPWl0ZW0gQjxhc3Npc3RlZF94YXBpYz1CT09MRUFOPiBCPCh4ODYgb25s
eSk+DQo+PiArDQo+PiArQjwoeDg2IG9ubHkpPiBFbmFibGVzIG9yIGRpc2FibGVzIGhhcmR3YXJl
IGFzc2lzdGVkIHZpcnR1YWxpemF0aW9uIGZvcg0KPj4gK3hBUElDLiBXaXRoIHRoaXMgb3B0aW9u
IGVuYWJsZWQsIGEgbWVtb3J5LW1hcHBlZCBBUElDIGFjY2VzcyB3aWxsIGJlDQo+PiArZGVjb2Rl
ZCBieSBoYXJkd2FyZSBhbmQgZWl0aGVyIGlzc3VlIGEgVk0gZXhpdCB3aXRoIGFuIGV4aXQgcmVh
c29uDQo+PiAraW5zdGVhZCBvZiBhbiBFUFQgZmF1bHQgb3IgYWx0b2dldGhlciBhdm9pZCBhIFZN
IGV4aXQuIE5vdGljZQ0KPiANCj4gQXMgc2FpZCBiZWZvcmUsIEVQVCBmYXVsdHMgYWxzbyBhcmUg
Vk0gZXhpdHMgYW5kIGFsc28gcHJvdmlkZSBhbiBleGl0DQo+IHJlYXNvbi4gVGhlcmVmb3JlIG1h
eWJlICIuLi4gYW5kIGVpdGhlciBpc3N1ZSBhIFZNIGV4aXQgd2l0aCBhIG1vcmUNCj4gc3BlY2lm
aWMgZXhpdCByZWFzb24gdGhhbiBhbiBFUFQgZmF1bHQgd291bGQgcHJvdmlkZSwgb3IgYWx0b2dl
dGhlcg0KPiBhdm9pZCBhIFZNIGV4aXQiIG9yICIuLi4gYW5kIGVpdGhlciBpc3N1ZSBhIG1vcmUg
c3BlY2lmaWMgVk0gZXhpdCB0aGFuDQo+IGp1c3QgYW4gRVBUIGZhdWx0LCBvciBhbHRvZ2V0aGVy
IGF2b2lkIGEgVk0gZXhpdCI/DQoNClllcywgdGhhdCdzIGJldHRlci4NCg0KVGhhbmsgeW91LA0K
DQpKYW5lLg==


From xen-devel-bounces@lists.xenproject.org Tue Feb 15 16:36:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 16:36:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273442.468629 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nK0oP-0000lj-NA; Tue, 15 Feb 2022 16:36:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273442.468629; Tue, 15 Feb 2022 16:36:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nK0oP-0000lc-JM; Tue, 15 Feb 2022 16:36:21 +0000
Received: by outflank-mailman (input) for mailman id 273442;
 Tue, 15 Feb 2022 16:36:20 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=p95L=S6=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nK0oO-0000lW-KU
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 16:36:20 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 673e13f1-8e7d-11ec-b215-9bbe72dcb22c;
 Tue, 15 Feb 2022 17:36:19 +0100 (CET)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2110.outbound.protection.outlook.com [104.47.17.110]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-28-QpAO_WhFP1qVo0YpY8FgqA-1; Tue, 15 Feb 2022 17:36:18 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AS8PR04MB8023.eurprd04.prod.outlook.com (2603:10a6:20b:2a9::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.19; Tue, 15 Feb
 2022 16:36:16 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4975.015; Tue, 15 Feb 2022
 16:36:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 673e13f1-8e7d-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644942979;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=uV3nTGQYjOfjOMMfqv/mHtHSTE3as+B393c9kSW8YQA=;
	b=IZbf5mFhKzopEQKK5xbgNjYIQYPxvndTqk8XnA0s2BBW1HrS10Mxl6pk1ssbtmro3U5Baq
	ok2HephLfpUzhKPy1tODxLhoXxIBkqZtVkb8MxKyqfqgY7V55BHdZ2UMdsVrfmHnRv7MxZ
	5odjcCqsl5zGc1+WkQPV6h4l8AZ/0y4=
X-MC-Unique: QpAO_WhFP1qVo0YpY8FgqA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=AezeqDoMgXViZFgCdJLAhb8MDQP3LYInokYYbY3PQlgCuYdOC7ZGeS8E21m+AP0oG5Cx+B7+e0DjSo6mo6vRkVmLebJS7utvioyHTFr13uDqDVcWoDAfsTcfuV0Blw3Wt6Gmg17oHkBHmOmW4GcSYeVkocnlgw6ImkPMSuefv96VO5dukp9/uUbtg4SF4Ou24W4fbEyfFSgPtKKdhLulObLRy9x/q/vxEUzNPfJLtfCwqf2lpv+8c8fUoSS3u3txbkiR8lu+CRwOAkOd04kAD619gRisESmctC/kIGdw5D54SnOvzNn+FlXKF6kLNAauW694KUxJh4/oQmiaF2kNUg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=uV3nTGQYjOfjOMMfqv/mHtHSTE3as+B393c9kSW8YQA=;
 b=XyPv0UybqaQUYd3Fk5nIbJfJ2t+KIGy66TndWSJ94D/RbARG4tiOKQlGmQJXRMlYcPjTseqI+kALyteQ6wqXt7MXpcDbWNGwA3l3zakw+msr25QaLcKXSkaHltc5ACje7/MsyX06iBZGCx1o68Unl/vUzQDDD6Tr4aRw+vEqLWRszevYyfImOJn4EV/qCOYtvVlReoPjRlvwdfJLbClkNYvBpUHziqNsu8Lzzm0WiLNtFIof37uBB6DsRTSZkbOtf8BRvq5A3PMeOZhXfBNzbFGzfUXe7OkrjXtcfUJ9aobJqKY2mUJIFS7bP+UE/U/epaTv6Al0/qKVoAMobJAcmg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <eda87797-ceb5-29cc-e9c9-612f32b64880@suse.com>
Date: Tue, 15 Feb 2022 17:36:13 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH v2] vpci: introduce per-domain lock to protect vpci
 structure
Content-Language: en-US
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "julien@xen.org" <julien@xen.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Artem Mygaiev <Artem_Mygaiev@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>
References: <20220215081135.1497470-1-andr2000@gmail.com>
 <YguE7RWOteSnvVNY@Air-de-Roger>
 <c5b9b02c-93f8-d018-6048-9abf2e7de4dc@epam.com>
 <YguQ8wfhfYFXTWSU@Air-de-Roger>
 <70dbd7fd-3f74-d0d3-6e30-c1e1e24fc279@epam.com>
 <0d8f01b2-b015-a08e-dd49-e9c688ff7245@suse.com>
 <bbb36ebc-de66-297d-f82f-abc0e63f20a2@epam.com>
 <22d25499-cab0-00c1-3ad3-bddd74c97a55@epam.com>
 <772eb410-be1a-3b5f-3b51-e363c43bc3c6@suse.com>
 <504327d2-0d82-7f88-e155-e6a45ba11a74@epam.com>
 <0c7aa17a-1735-1d9c-9cec-fa3693025256@suse.com>
 <8781c4ad-52c7-2e04-0901-b5b9a36c1904@epam.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <8781c4ad-52c7-2e04-0901-b5b9a36c1904@epam.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5P194CA0018.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:203:8f::28) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b9f99f85-eb6c-422a-e619-08d9f0a14956
X-MS-TrafficTypeDiagnostic: AS8PR04MB8023:EE_
X-Microsoft-Antispam-PRVS:
	<AS8PR04MB8023C0BD0B56E430987ABF47B3349@AS8PR04MB8023.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	6qCncbf4nJmkER0o0Cd1eLeAzfXZAJINsyMuaEXx5X3GZq/9kQ8zUTGPjhjXDYz6PIUWO1cD/jmSyfYVUgl+ILGaEsV96hnd8y4mBmgCBLu1B1+REnOgj7fNGRMdHKPx3kskg4BwXPSU3GFTBpwytqWdscsU2gFt433SlLgp1gpApkyG8OpfSRoU69tV82Npdf1/uvh1PfVQ1oHRBLuB1hZZozSjn51hYfPcCjPrhofy9wfPbIF0qx0U5o5ieB2ytlaWlUk8Ac88EYWViXU2SB/AGc29lAgbR8kV0+/ekt+skWzgQaD9fU1WTwAE5evLcjoZnKEABX5YnSgqLjidhxmdJUaXnssmxgN4gCIXtgsN5nT6atvnJ53oC4qtJLAtgmysR1SHvhiW+bMWFg+BVkZUS2slz7oaOZzAoVzJfelh6NgK3n612shKl9aSdFvDzal8GsNu17QuBQ5UNzEpx1ycljKjaXDvvZEVZ6KRgnXRakQim/uFLKc59QwN5kJHQhF+R0IapRGIz66a4eYP8vQxY89B4VdDnywKya6H45oInBH7LmtPmvzsKRH+Ozhf02y7kkB2RhtWECJyENvkaRg0W2JcyvLN+W+tdWDWX0Wg7ufjjSbMQGsa5YsTORKwyqlicUwSKGEoQbskZ2r3Uc2iLL6ttLnGEoqAYXQvIpVsZZFvGA80HNexZFwm6cEa3w9i/Q5aV9OS2L5q7ar73oSqioGBtktuTPwJGybAuDFFM8QRgfLZ3Bxmc8Ep9WqW
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6666004)(31696002)(508600001)(316002)(2906002)(38100700002)(6916009)(6486002)(54906003)(66556008)(66476007)(8676002)(66946007)(86362001)(4326008)(26005)(36756003)(31686004)(8936002)(83380400001)(6512007)(53546011)(6506007)(7416002)(5660300002)(2616005)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?OSs5S3QxSDRYelVJanZFb25EV0RJbEp1VzBLbm5mOG9DM0ZEM0k4MnZjeHU4?=
 =?utf-8?B?WWZHT2xZT2VRV1g4MG5JZmtKNzFFZUtmMmgxLzZhUkRQd21EcWFOV3RLNGY1?=
 =?utf-8?B?Z0g0b3gzRWtJZ0tsOEdBQUlYeVRETkhUTlJlL01Qc21TdHdxL1NtL2h1WktC?=
 =?utf-8?B?YktFdVEyK1oxVkVxZG8vakVrZjNVcDdRZjRZNVBwU1l6eGJ5R291aXliNFRS?=
 =?utf-8?B?V2dzeTh3VWM1emtkZUY1SlZhUjRrZ0VhSkppSDB5NFA3QzZLY2Qydzc4MUtK?=
 =?utf-8?B?aHNPeGQrTVlrYWM2eUtUYXlFRnh0NEJxRE8yYVNFTE5SWmpDZVQ5SVV6VGF4?=
 =?utf-8?B?ekN2Z3V2RVhBVGxlRW1RbVFoeFgwQVZRUmNyWHFpZ1hrMDRjNk93M3hsZ29w?=
 =?utf-8?B?Tytrb2V6d0dvV25pWURPaFFzZmk3NndmenkzVWEyaUdIbktVSFV6Y3VjWThT?=
 =?utf-8?B?bjZ6L3pqTVM1TEdUTitHTEdOaUd1cFJnUVppV1A3LzdDVm5Ndm9hYm84YWtk?=
 =?utf-8?B?OTJFNFFSZ05jcUlSdkRrT3d0dUlabWxSUHRYNlluUjV6RkdLb2tjSEM1YTFw?=
 =?utf-8?B?NGdrbUxSdmdTWGV6bHlOOG5YZm84RXZobGdaMGpGM2hEaFE1Z0N2MUJBekpo?=
 =?utf-8?B?ZzMvdGlVYVRKY3BGWHdOZi9GOUhVaTBidEZyR3d6QTVxdTE3MEhIVXpza01L?=
 =?utf-8?B?eWtjNUNta1NYOHd1cHo0cGkxYVFoNHRIditaT2ZUSmlDdUJRQ0p5RUEvbDdx?=
 =?utf-8?B?dkdYSW11K0ZwVm9lU2Jia0NhY1ZBaFgycEpqNk5GSno5dTlPK3BZUHcyS0JI?=
 =?utf-8?B?N2J2N0E2QXdiUUdKZ2JEbzFscEtETC93QUd5eFdSdkxUb2JseXJ0M1lML0NU?=
 =?utf-8?B?V0R0enZibEJUdHlEbTlTVHllTlFQeWtXaFhSSnJ5RktDS0tvaFlRem15aHda?=
 =?utf-8?B?R2MrbXZNd2xWMUVTUkFTcHdoaXg3b0M4b2VNTFMyMFdIYktBWnJMRUl5SThN?=
 =?utf-8?B?UUl6a3E3bFRPZzZ4RS8xbFpyanZRSzNkbERaMFVsRnQ5WGFBT2dtSC95TDVX?=
 =?utf-8?B?MXg5WG1Eb3JIZnBvQTk2MTY0S2ZtZkNCUTBVZlpENWZ2YUUwbDd4cnlqb2xs?=
 =?utf-8?B?K0M5WXBZMmx2Z0thT0xRMGFNODk5Y3htd245dVJxbng4Y3ROSXR4SVhMZmtG?=
 =?utf-8?B?UkhpK1FQbGczK093c24wUDMwVndUdkdUVzJtSXNudG1UbUQrekVwV29oKzJ0?=
 =?utf-8?B?U3JWNkt6OWp1UnFCaUtaSVZxcENXQmlXZnBjUGhKNUNiNXZKTEpWOXhXd0lI?=
 =?utf-8?B?bktQQzNROG91YjJCMUM4NnNzVDdRdXQ4WE53WCt5N1IvdUxuZExRTHVPUEJy?=
 =?utf-8?B?dlpkZDVQZndrUFk3MHhXamJrOUdhNkhUL0duYzgwdkFBVU84WmF3d3dyZVJJ?=
 =?utf-8?B?K0NoNWVtaGk2STFZSlgxL1V2YnpmdVZvM1Z1VFhRRHpkaGljb0l2d1VEaEVl?=
 =?utf-8?B?cStGdE5salhHenZSMFVCYWxNUmlSZGlOTEx4NnJDemJoV3JNS0txQVdQYUN2?=
 =?utf-8?B?c1FrMWpIVXUzWnpzU01FQjN1QWQ3Sk54ZnY2MlE2NStwY0pJZFI3WmVJRnor?=
 =?utf-8?B?aHJ5bkNBQmY0aXdvcVROUDRHOXVlR05JQk9tM29TRjRvbWU2bEgyZU5UbkxW?=
 =?utf-8?B?WDJtVy8wMk5jTW93WWVYNFU0V0lNVWd2YmkvcTE1S21NaXFQRHJPV05FdWxs?=
 =?utf-8?B?dnlJMDJkWDhyUEFldWtkUlphQUNpa1Q2a3Rqb1JvdWlseHFMM05IMGJHUW03?=
 =?utf-8?B?UGNlN2lZQXI5MVgrdE8rd25RYmR5eE5oRHFzcmNWbXZpbys0ZTVHMGlHNEQx?=
 =?utf-8?B?bC8yayt4UzFDNW1nSlBtMWZKR1dpN1ZPaEY3cm91cnJUZ29JZWNJWGRsakdo?=
 =?utf-8?B?cVRSOG0yMEF3UHNxQ2xDYW5ibU1iWnY0WUd1Z3BlVlIxS3k1TU9peEZTZ2hy?=
 =?utf-8?B?TEN5eWNpMlFUcWM0SHZqS2dLSVJxSkZtejZQQkNjeWt1U2EycXRDTjl0elky?=
 =?utf-8?B?cHFHWlZHakRFR09DV3BRMFV4ZXhobzdpQTR0UlJrZGdmUzlIVGtnam5ZMjlk?=
 =?utf-8?B?WXB2aWZ5cEI2SVJlait6MkQ5eFJMdTVrcXVMTytTM21paFd6ejN0NjdhcldL?=
 =?utf-8?Q?LwEZanymKxjX0V4iqZPoHMA=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b9f99f85-eb6c-422a-e619-08d9f0a14956
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 16:36:16.1562
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KBrcLkLiLp+Lfq/x8M4+jqQSR01pV9euWT97xVxKPed83CUB6qImGhBJfR/42jNJErGFGO82ijD1bImZ4q8zRw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8023

On 15.02.2022 17:28, Oleksandr Andrushchenko wrote:
> On 15.02.22 18:18, Jan Beulich wrote:
>> On 15.02.2022 16:46, Oleksandr Andrushchenko wrote:
>>> Question: can anyone please explain why pcidevs is a recursive lock?
>> Well, assuming you did look at the change making it so, can you be a
>> little more specific with your question? Are you perhaps suggesting
>> the original reason has disappeared, and no new one has appeared? I'm
>> afraid I have to repeat what I did say before: If you want to remove
>> the recursive nature of the lock, then it is all on you to prove that
>> there's no code path where the lock is taken recursively. IOW even if
>> no-one knew of a reason, you'd still need to provide this proof.
>> Unless of course we'd all agree we're okay to take the risk; I don't
>> see us doing so, though.
> The question was exactly as asked: I don't understand why it is
> recursive and for what reason. I am not suggesting we blindly
> change it to a normal spinlock.

But the reason for changing it to be recursive is stated in the
description of the respective commit bfa493f52e89:

IOMMU: make the pcidevs_lock a recursive one

The pcidevs_lock is going to be recursively taken for hiding ATS
device, when VT-d Device-TLB flush timed out.

Before asking such a question, I would have assumed that you looked
up that very commit. Hence my asking to be more specific.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Feb 15 16:46:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 16:46:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273449.468640 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nK0yS-0002Ec-ND; Tue, 15 Feb 2022 16:46:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273449.468640; Tue, 15 Feb 2022 16:46:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nK0yS-0002EV-JO; Tue, 15 Feb 2022 16:46:44 +0000
Received: by outflank-mailman (input) for mailman id 273449;
 Tue, 15 Feb 2022 16:46:43 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=p95L=S6=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nK0yR-0002EP-6C
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 16:46:43 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d9f4209e-8e7e-11ec-b215-9bbe72dcb22c;
 Tue, 15 Feb 2022 17:46:41 +0100 (CET)
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2054.outbound.protection.outlook.com [104.47.8.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-3-czT-rb2aPdyUCBZ_VEyYIA-1; Tue, 15 Feb 2022 17:46:39 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DB7PR04MB5212.eurprd04.prod.outlook.com (2603:10a6:10:20::32) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.15; Tue, 15 Feb
 2022 16:46:38 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4975.015; Tue, 15 Feb 2022
 16:46:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d9f4209e-8e7e-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644943601;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=U8inlhwNEt2P04YrXuqFHUIjMp/G8CmrvHaCp+hNFLU=;
	b=VdbPrghS4vlJOGxgo+gVTdGTuEI32B98S2Tpelmbbr1aeNyuddl3jqYkT+qeIV3HIYgt36
	Mq2iJAqlvKKCSKehHdCuDO5Or4KrJxugB1J8WkAC2M7Js6ApShalOyfVKZZPK66PlAJA4k
	UX9/oRU/BGKg4rne/i2BF3A73U+m9HE=
X-MC-Unique: czT-rb2aPdyUCBZ_VEyYIA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XA5uwhJPWHJYEH5PJaASoAZ30tweUiNtLkWTu9a0Nl+NQtSRxfLprUZsny77qeeCNuy6P1v5EgLpMfkqT+TLrmpaXS35xhhtvtL/TFbmemT7yO3FqkhbFBo/DlCV2/zQuv1WSUjWmEbcs6b9adQCwftbihDlj9ypTufMe2IMZZDaMQFVV4B2xZaKqjimYJ5n6tdVP67VrlVllZYr7UKc8hmz7xZpFGte9rzfzZYPwE2JEGQUzM/oo7BRubDct5Or+NUXn9FTdYS3VEFFUtXn3m+ZuB7drsSXa0ojAk6fVk9PGfcmKKW4V4I033NglIaf1mB0ilLri+hbVKDwZEZ7+g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=U8inlhwNEt2P04YrXuqFHUIjMp/G8CmrvHaCp+hNFLU=;
 b=oE03AeRfXlXuARz7YyeVEgRP9UbwRognXldrjoamoDzlJVKJNLjAo9bqAbb1Vqtjq1iRO6hC6F1P2dd9w2qclV2H/K89YphkaOGEbZnUlwkFW62J+doDCYdGE/EjLTB4aaoSmRFB1b1qALFx/biXmFR/lm8mfybdC6VXZ65cB50XyuNdAQGBN9Ytj5VpHMoAg1Mgm3tGBbDb368JJ5ttQ1b1KEAwXEUTIv4cpxlSanOZklXR5n6ZkjGByBW6waolE70NsWSIzDT5pwyqTCCGCrvjBn94A0Il/hGH70Fviv2SBKdEn4YNfA9D+poOMGxbbmno3cVfDD7fJN25vSpa4w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <79617697-307e-b19b-71a9-7c8554aec481@suse.com>
Date: Tue, 15 Feb 2022 17:46:36 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH v2 68/70] x86/setup: Rework MSR_S_CET handling for CET-IBT
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
 <20220214125127.17985-69-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220214125127.17985-69-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0025.eurprd04.prod.outlook.com
 (2603:10a6:20b:310::30) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 6e692ada-8383-49cc-094e-08d9f0a2bc6e
X-MS-TrafficTypeDiagnostic: DB7PR04MB5212:EE_
X-Microsoft-Antispam-PRVS:
	<DB7PR04MB521214340C0331BA96BD4E0EB3349@DB7PR04MB5212.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4303;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	/W9rRYlWABQZyAJ3xRNUZdEXhafxVL2PkBKHh8S42tzYo0KRW5lt0sxvKfra1Zaf95jrKPN+jZDgeF+ELMY69WH22G6ttATX8mBzvPTz399nLdoWRIAAMpwJxa64Z12fUII0xkQqf3sTjOx4U9hlF69goBePaNpJiWUDkY8h396kSiZ/hCtlRjYECUN+EUWINpyjDUwBRn1MjwMMSFCVFVG7EhIZc/HnRMWFtoJtUntPYzOyVtgFuWrecjdTe4VWQ8NNlJO953T3rH7FAsswE59n8Tjz4yaFkA6Agw9EmgP7Vd8yOlgc1KRjGcbbkkdKQFqRi9LO05xdopTfzo4Y/sv2VDcymiUqw22wiKUv0FevxOTXYqkmvSWvEKiwmX2oXN/U+qWcCyo+ibp8FIqtYYRT6Lsa8FRw5gOG7/Wkc7cQql8qVG+iCYwWY5Tr18QHxDrrp61obSowTX0EvS+CfC6iO9jh8iQmIE2vB+lwUGXZElETynnHI3TOSASV6Uii3XAHOX8Dnq88xzVeqoag3qIfMKLAuoR7cvEkvUcix1VvUmHKNTPtfSFtOgtPrk+r+Gzq+zpbKQ5SUjLiMVW+3csJsTZSHSL+ct9V1F2+G+bUPD0SK5W6N4Gftie+CBKs+6d4l12ylaIKxb3w9iGLnbXHduOC+wuirfL3t/cYdVQTQwOX+tSgoqKlEnpaEvp3UWFescloKo7ytt1MRBFCvh3Q7AdAEDngVwTZjJzVnBtvsw4RLxMjuwH0Hj1SjM7h
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66946007)(66476007)(66556008)(4326008)(6486002)(86362001)(316002)(508600001)(6506007)(53546011)(5660300002)(8936002)(8676002)(83380400001)(31696002)(36756003)(2616005)(2906002)(6512007)(26005)(186003)(38100700002)(6916009)(31686004)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ajArNTZESUVpUFVtNXViWStSeGk2aDB6Wnl5VkN2ZU5UdklPQkd2ZGU4WmFV?=
 =?utf-8?B?R2s0TFQyTGExdnFpRFdaVmNzRldLdlBaSjlRNm04RklQdC93WXJkWlVBR201?=
 =?utf-8?B?bVdpcnJSQnlqMVpHSXVybm9JWDloNTdmd0RzMTNEakhDMXhTcWRHTW5BTUl5?=
 =?utf-8?B?WGtnZ1pENDhVVFhic2VsZTZibmpQTXJWNUlNQnh4WVZOMHNNd21xMEhBZjda?=
 =?utf-8?B?US82eTJ1OUQ4c0JmN1haYmVkdEZ5UGNqYzJXeG55VnQ3U0hNZFFTVTlNOFRO?=
 =?utf-8?B?Q0pZZEdmN09YVnUyOXg3R3c5UUlhc1hlbWdOM3JOa1Q5NHJtMzVsTHRicXlw?=
 =?utf-8?B?S3JCSmdTekxsZnJoRldNUVJjNG1OZzNQeXVocEdWTjAxa3hZV2k5cm1ZUHdJ?=
 =?utf-8?B?ZHhETnR2ZXpUbFR3R0svQjJyRUZOZStTSjUxdmJBNlErL3BEMGQrQVhTVzNO?=
 =?utf-8?B?Skp5ZlF3YnR4Uy9uT042b0x6WVpSU2x3RmZGNUloVDdncWM0cFdVMmtKVWRV?=
 =?utf-8?B?VUt5V0JyMFhHMWwyYkhpcHZaelhENFNFUVpyYzV4M010L3A1RkN1VWRCbWV1?=
 =?utf-8?B?VHFrT3hmRFlOV1BrTFcyMEEwQmoxeHRObXdiM2syS3A5MjJJV2JISjUzYnJt?=
 =?utf-8?B?MzdFYmtGTEp4dHl6U3o5VFFJRHFhSlRkOXVrT2hUV1B2dXU3SWRjM29WeFRQ?=
 =?utf-8?B?bmNMQy81NWZJZ0lNcUk1S0dscEFwUHVnbzNVQ1cxWERsSUYvT1dYVERoNXpZ?=
 =?utf-8?B?b3VWeGhwY1JIcm9pL2xhTUpPamUyaXAyR3ZRdjVucVAxRjQxYjJJYXBOM0h1?=
 =?utf-8?B?OXFiZ0Y0NUFQYkU1RTBPeFI4dUlPdHM0Tm80RnFJNHMyby9UVGlBbWpnMExl?=
 =?utf-8?B?ZjIvcHNzdlhRbXJIanY3ZGNmdXlJZC9sZDhVSHE3UVFEZ21HQmFGN3k2WnVo?=
 =?utf-8?B?TWZIeGdtWDdLL3MrRWpUY1lINHk1MTd5QmVMbFR3NEoraVR1V3hqZkwxNkRq?=
 =?utf-8?B?WDQ5V0tWR3ZNV3diWU1VTENRdzN3dWJVYTJTRVdoMGlMcWhWL0NDYnNzNUp3?=
 =?utf-8?B?RTE3c1g5dEVYTkx4SDFQWmdrdXIxRHZIYXNKbHA3UmVjSW5XcVA2YXY4TWZ3?=
 =?utf-8?B?V2VuLzB4aVNRNFRWdG8vY2hCQVdKUFZrUTA4dk05c21rSk1FSnQvcHp0cHp5?=
 =?utf-8?B?WHRSZy9HOXFwckkyeGZTdDV4R3FmVGN2WFdkZC84dkRQWllXRVo2djZEWERq?=
 =?utf-8?B?c0dVcWFoenFPV2FFcnliOWpMaGlSSnVIY0ZZTmFZMlByZUlhSEdKM3dMcXZX?=
 =?utf-8?B?K1NRbHczNVg2bWZvSlgwWXZvSU9WaDhDdmozMHF1WEtLK0hiaWZpNlQrVnhF?=
 =?utf-8?B?Qkd1Tk54T1lra3lRZERRUmJhRzh2RzVubkpEUnhFR0liS1NXY1UvOUJGZ253?=
 =?utf-8?B?UkFzUnI3N0VNbWVjdElvOUllbXowTTloSEh2ODdlSmk2VUJVSkprY2FGUjdO?=
 =?utf-8?B?dlIyMkRSa2hhMUZtRk1uV0FnM0pjUWJOb3BiMWNZbnZLVjVBNWhjR2xHVCta?=
 =?utf-8?B?SzM2cmlxSUhvdFM5aHZoQ3NPdkdSb2V5NXdUNEV2eHlLOWQ2UEd6OHJZOUlF?=
 =?utf-8?B?Nlg2WHZSZ3VGTlNYTjVEMVVUcXRFQWl1T2Z0WDdCeHYzM1c4ZkF4TUdxK2pn?=
 =?utf-8?B?N3YxYUh4WU85VHVGdkNjajE4Rk5UVFRyTWFPNjh6THpOc0FPS09vMmVHOGd6?=
 =?utf-8?B?Z01lUFZ2TjFoNEZKTkJtanBna0JkSU5mRjE3M25nWTRwTzlNMmF4VXhBeW00?=
 =?utf-8?B?dlNPYUxLb2YrK3BKWUxwQTRMbW1BWGxXc0xRYU1rYWszNUNTRnZKS0VRbHFa?=
 =?utf-8?B?YWRQU0hnUFNvQXJZS0xvOTlHL0JCdWhzR1RSYzVRalliTlNrKzVkMDlIODJh?=
 =?utf-8?B?aVZlMjJmNndkdDZyTitLS2hWNzVOSnVjT3owK2N6WHI5Q012S2t0VVpkd0hq?=
 =?utf-8?B?STFIWk43d0s5eHdiYU9aNTN2c2VYdnlxcUNKanpYT2FKMnp1YjViTjVBWHlH?=
 =?utf-8?B?MHVKckw5RHFKeURNRDFLdGtybFpHTGFWMGJqYmoxUWUyU2ZneWFkT0NiMlUy?=
 =?utf-8?B?UUpSRFROYkt6Um1WNDIwenBRTFErWG5HUFlwN1RuNGJxaUlkWWZsdTB2MlpM?=
 =?utf-8?Q?DNYyBv3EHSMEqynOIibpLTw=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6e692ada-8383-49cc-094e-08d9f0a2bc6e
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 16:46:38.7269
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TMoo25gyrE4OyW+Bj7oWwKPKuqhi0tLrf6BPYicChjiJcoH7NuGftxb03uJkAEvSAPFiapBoRax9Hjkmwmqm3g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB5212

On 14.02.2022 13:51, Andrew Cooper wrote:
> CET-SS and CET-IBT can be independently controlled, so the configuration of
> MSR_S_CET can't be constant any more.
> 
> Introduce xen_msr_s_cet_value(), mostly because I don't fancy
> writing/maintaining that logic in assembly.  Use this in the 3 paths which
> alter MSR_S_CET when both features are potentially active.
> 
> To active CET-IBT, we only need CR4.CET and MSR_S_CET.ENDBR_EN.  This is
> common with the CET-SS setup, so reorder the operations to set up CR4 and
> MSR_S_CET for any nonzero result from xen_msr_s_cet_value(), and set up
> MSR_PL0_SSP and SSP if SHSTK_EN was also set.
> 
> Adjust the crash path to disable CET-IBT too.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>
albeit with a nit and a remark:

> --- a/xen/arch/x86/acpi/wakeup_prot.S
> +++ b/xen/arch/x86/acpi/wakeup_prot.S
> @@ -63,7 +63,26 @@ ENTRY(s3_resume)
>          pushq   %rax
>          lretq
>  1:
> -#ifdef CONFIG_XEN_SHSTK
> +#if defined(CONFIG_XEN_SHSTK) || defined(CONFIG_XEN_IBT)
> +        call    xen_msr_s_cet_value
> +        test    %eax, %eax
> +        jz      .L_cet_done
> +
> +        /* Set up MSR_S_CET. */
> +        mov     $MSR_S_CET, %ecx
> +        xor     %edx, %edx
> +        wrmsr
> +
> +        /* Enable CR4.CET. */
> +        mov     $XEN_MINIMAL_CR4 | X86_CR4_CET, %ecx
> +        mov     %rcx, %cr4
> +
> +        /* WARNING! call/ret now fatal (iff SHSTK) until SETSSBSY loads SSP */
> +
> +#if defined(CONFIG_XEN_SHSTK)

Just #ifdef, as it was before?

> @@ -90,10 +101,6 @@ ENTRY(s3_resume)
>          mov     %edi, %eax
>          wrmsr
>  
> -        /* Enable CET.  MSR_INTERRUPT_SSP_TABLE is set up later in load_system_tables(). */
> -        mov     $XEN_MINIMAL_CR4 | X86_CR4_CET, %ebx
> -        mov     %rbx, %cr4

The latter part of this comment could do with retaining.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Feb 15 16:53:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 16:53:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273456.468650 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nK15C-0003cx-Dy; Tue, 15 Feb 2022 16:53:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273456.468650; Tue, 15 Feb 2022 16:53:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nK15C-0003cq-B4; Tue, 15 Feb 2022 16:53:42 +0000
Received: by outflank-mailman (input) for mailman id 273456;
 Tue, 15 Feb 2022 16:53:40 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=p95L=S6=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nK15A-0003ck-Nj
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 16:53:40 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d32d0b97-8e7f-11ec-b215-9bbe72dcb22c;
 Tue, 15 Feb 2022 17:53:39 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2059.outbound.protection.outlook.com [104.47.14.59]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-7-Axr6iLwCN3GN8gERyOydHw-1; Tue, 15 Feb 2022 17:53:38 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM0PR0402MB3906.eurprd04.prod.outlook.com (2603:10a6:208:e::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.14; Tue, 15 Feb
 2022 16:53:37 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4975.015; Tue, 15 Feb 2022
 16:53:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d32d0b97-8e7f-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644944019;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=b8F0MgvW7RpJXh1waPLI80VrIznjq+BPIlelFky06mU=;
	b=WlTPlTtY9PQlOFDIO4syA7wR+SeORec+DC/brHCFeIvOHGeZSOcqy23IvPmI1D3GSrhngF
	bjaIdDDEXoICH/m2X5NRAb22n4ZqPSK8HILRORuyWEQeS0XG0HdrKBdPzGKknhhK+lFO6O
	RH8SOhSyZroAocmJC1khX9WDgAo5DZM=
X-MC-Unique: Axr6iLwCN3GN8gERyOydHw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=NVZlorzwaXExJYQ6AKnQujOVqjdkpiNsdNi++avTUAWLxKHqK9WtYAwIuWsIR0kp8NESl6me90eIbm25U8JspSQQlhl4BMcSzbL37QSjJ0tnrG8tM2rNNq6bfO6nv+INsAteG1gI0YZKCYsai69daI1N/YAKjvm+D1iYKuRZSfpkjepWKAhXY7CACpuMEn+pYWqgBuOaEPOMOozi80vTUl6Yw3rvCTqmdTLEIz0ZPR/8PinEoO+m3Un7ZsG8fCEqF8XLyELrYzC2DVczLJuWF6ch9F/eei9BtBY7573evzJf5OrxLcE9DuIxJv4+ToleLqqf5ljFBWEPZRvL4xxyPw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=b8F0MgvW7RpJXh1waPLI80VrIznjq+BPIlelFky06mU=;
 b=nO1WrzzaGiYxfEF29OskjXxhuRNOmZAsKopYJxj5oLKCtRduPehJiXls7PP8bNH7+rmdomyj+qLtMeyEmHrgMSRwLq0Q0Sicjg9mKwj2zbmu4O/UpcOrS916fTwBaNTxXnh9bF8leNXBtRL6heu4IRFw5shivImo7GA5dAwWcs7QDufP4bsF5RpeVgxZmxBCqxryFNZI3ulGPdVbmCfNmHsu0X8Pohw2RrGrXiOktJRQY6GR4B+T5XutvS9QveXldQGJlOU97LVdr2J4MMfkWZNLej5E2l+TIQW4zI/BJBCCEwD9z/KlZfgSEdtJJ/lLQxnXSP7QIAWwlmcv5p6zMA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <0eede8ae-c2a2-cc87-d4cd-47ceffd4e488@suse.com>
Date: Tue, 15 Feb 2022 17:53:35 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH v2 69/70] x86/efi: Disable CET-IBT around Runtime Services
 calls
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
 <20220214125127.17985-70-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220214125127.17985-70-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR0P281CA0049.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:48::15) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 13f71bfd-4db8-47a4-1d5a-08d9f0a3b5dc
X-MS-TrafficTypeDiagnostic: AM0PR0402MB3906:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR0402MB39062304FA2DB17A30B09F18B3349@AM0PR0402MB3906.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3826;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	PlYKTWV+H4Bc5qfZYx7nPLk7R7QQbER1sEGPQbpCa9NeRvaYzCJgKXUYd1Rh3gmhyRIIFb6KzUakZGTa4JsTo4HrJY2uu/Qh5RCbd9Ul9jjbHhFE+X5K36PSdMd+r0wlxuw37c1KE/zQPNnpgpgUrHTQNcATeUEeAZcN17Z+PK9XvOwCyvHNaQvfUaygPL5p8NNUX42RFmb8JVY67yqlisFmh2sRgUQL88RipCyTZ8F506x4Ge1JPjwp6XFpWa29Yoq8+IjPfmUYIvwsgKGAygYdpg7/eZDORnOweoBZ3LzQAPzN7EraCW3O8HGb5e8ldLROgvqR/Yex1W4c4g8IQ/5fC6UfJBaFA96zqrwS7Nd789YFAJOfni4qSiGH7FYcWZ+Ze1s+rhVD2aITqRNc9N7r7RNS467q1m2NTCm/Y6XTfeYAmLYZ3Lc3mfXi/xW68XDsKa++A20J3aRst/HpwnBMBd/AmPKTlur+V9FdTbttafHAy1e3fMIx03TKJl25CAGazW4C5HIyamiyv632Z4EJd3lJEHqj4JQHYTnvTCU4JwO9SyWzYV+o4QX/uy5FbKiEZ4zYHAAT9Meo6Wxs4uVsEFOf73YEnfn8F4FPcAuAFgQOPY6c8ct1U5gmVZUTaWAKIc/G+14Pn2/Ga7wGTEMy7BTjf1XP/1roGrJT+91yebi0R4ZIo3jAMCLC/tUNuoeXSY4FuKPxv9qbF7AUau4lB3qj0a+tp0nhxxY4MUnbVEemsCws5NckkTCNnpGd
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6512007)(186003)(26005)(6506007)(508600001)(2616005)(66946007)(5660300002)(54906003)(38100700002)(4744005)(6916009)(31686004)(6486002)(8936002)(66476007)(36756003)(53546011)(31696002)(316002)(2906002)(86362001)(8676002)(4326008)(66556008)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UHNWRzVPL2NlTUxjZm8wUXovU1V2YnluVDdaWGVtejhHcFcvR1hXSU1uVHVX?=
 =?utf-8?B?OEliM0JrMG52d0Z6T0tIMnZBTTJDQU9uS3lZdCt1N1lKVTdzTk5JekVYdDVK?=
 =?utf-8?B?UnhLTnJ4cnhNWVR2YnFIZC9MMTZPZkpoeXRYQjg0UE9YUnRoR0F2d3VDTTVU?=
 =?utf-8?B?cUVlWXJiS2V6ZDJoRnlpMmZiYjRSUDZYV1RmTG1aaVp4cUlXdTgxa29VS3BH?=
 =?utf-8?B?Z0lnVmhDR3p6OFVFQkdqSHFQNVdISlNaSmVPcGNXdWpqd1lmR3B3d3lvYkUx?=
 =?utf-8?B?d2g0djFMRXBPLzBzejk3OGFzanozYVFhSHdxTm5VM0tvY0tiSUpFZWlSa1Z0?=
 =?utf-8?B?TFZYdWtrdk42N08raFRZZFRvQTQzSllNTjJLUzdyTU5WcnpCNnNKMlJIb1hB?=
 =?utf-8?B?WW4vdXhSWUtNUnJHMkx2OTBRRm5KNzNIYTZvSGxFSE9zTVNQTXdGL05QWlJX?=
 =?utf-8?B?T21aQTdhdnZ6VzVIWUpSMDBXUStZeEdSTGxrTGdPT2tzekIzZGNBenBvR1Fy?=
 =?utf-8?B?c2MwbUZBYStlTDQ4VGt0TFE1d201cytkMndBN1pnK3h5a1pPNmpEQTMxOFpV?=
 =?utf-8?B?OEFLQTNXMzJXQmQvZTVvM25tU1B4OHhVZEtlUmd3WC85TGZYQlkyTzRTbDlk?=
 =?utf-8?B?a0p5a1QzSjZndlpZai83cjIwTlpqTzBpV1lkQytCWlZXK0dmRVpRdWFGQW9y?=
 =?utf-8?B?amRwYllQTnNhUk41V2hsR3V1cU53UkdENEpMZlBFOFpxWks4QUZ1V0V1NWU1?=
 =?utf-8?B?WGdJWkduUm1NUTRkbVZmY1F4VlBZMHNEaHlWOFp2OXZHbzNHbExwaGNQWkNV?=
 =?utf-8?B?bk5EVkthNWtlUzJ3a0wzUldmWXRabW1OeFN4YzVMMVR0Z1ZNVUxDZzZDdEVx?=
 =?utf-8?B?U2xPUnZmMFBKZTVUZFk5RVNCbVNIVmwyK0tMWDFNaWZpV2o5UGFYYlh6VWVY?=
 =?utf-8?B?dXdMdk9oMnZ2d2lmeXdWN0owVnVTTUZtRCt0WkpXVDdudlhTSmMrTUZoNHhv?=
 =?utf-8?B?dXA0bEFOYmJtTTlyeC9YR0doV1pjci94YjlNYkIxRDNiUTBZcmpZR0sycWl5?=
 =?utf-8?B?UDhJUGV3UXRZRmFVczFFdDlOV2U2SzNuK2tjbElMZlMvWitMM0c5ZFZWOVl1?=
 =?utf-8?B?VGxZWlBvSExWdGd4aGlqa1JWa3RKZzdOZXp4UkdNY3pYV0lEWFc2VkFpU1V3?=
 =?utf-8?B?QUxpZFBKTUNpVHhjQys2ZmVIMko1TFZsU0tyamg0cXVBK1FTUUNLNUxaRk43?=
 =?utf-8?B?RWxQVm1uLzRFOWZwSUQ0bmZmS1hsRVZVU1BaY3ZyT2V2eEZQaVVhK3lPTmdP?=
 =?utf-8?B?SDZtTk1ObEE5bDZZd1ZmUmhFTzJqVVF2cmFtazkxYUxiMG5IYlZuRGZDaDd6?=
 =?utf-8?B?WFBJRStjK2dndVRpTHhTbEU0cUFQaklJMTB4bVVncTZUenFiUkNQZTJFbEI1?=
 =?utf-8?B?b2pFS1hVU2pVcmlmVGJEYVI4bzRISjVSMnEwT3VSNHpWRm5oZS9tQmhhVjRj?=
 =?utf-8?B?d2pXQ1ZKamxESVh6L0oxbjdMU0paMVE5NEFMODV2TjRrWlpCYUFGazRpeVM5?=
 =?utf-8?B?a0twUUNYKzJjM2RZVGcrTjQ1NlZTVXFHQ0hKUGE5WU9JN2twZitOU3FoSUZq?=
 =?utf-8?B?OXVYNytSRjA3cjJaMHlodlpaYXpJMnZhS3lLNTEwVmJCM0FlSTRXZHVVYTFK?=
 =?utf-8?B?UEVVOFRFWURsdGpzYWl0NlFOc1dIZ0lTZEh3ZEpxWjNBU0VHazY1U3JwU1RK?=
 =?utf-8?B?RnpsNDY5YXBsK1UrUGVEdE5NQWlqU0RGclh4V2VKVGNycUhpUFErMzNJaUl6?=
 =?utf-8?B?RG8veUk3OU1DdTB2RnFwNVpLQUZZcnVldlBIL0pHUmV6UE5UYnh1Uk9YUUxR?=
 =?utf-8?B?M0lkTDduK2pwRXBHbXhQaDhrUWZmSXpwdFF5VjR2bGU1OFZYVEQ0amJIbzln?=
 =?utf-8?B?L2VuKytqTXF4bWNLbzZPRDRuSkdjVkVYd2s5VFNKemdjNytRR2NqQTQ2MktT?=
 =?utf-8?B?RjZQR1BEVytEY096YTZsMWJNMjlzVFZFbVMvRFY4RngrTVI1azRHRGU1K2I1?=
 =?utf-8?B?WGZKY3JwVFZqaURPNTgxNlZmUTBzMmZVQTBzT1hqTG9DcG9McjF1Rm1LazFY?=
 =?utf-8?B?eGhKckVCMWxHS2phcDJhZjFVOVN0NGc3NmgxU0F4VTdNS1RnQytaUGtiWXpS?=
 =?utf-8?Q?sm79TLJsk4/xObfaL01vGCc=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 13f71bfd-4db8-47a4-1d5a-08d9f0a3b5dc
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 16:53:37.1854
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: viLmgAX6ATDpToEh8YJk5oTCtweuFsIhTR+D2Gs21c5DyUspcj55AQ1gA/0UtHtsTJE2mxM4qtED5N9KYcorYg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0402MB3906

On 14.02.2022 13:51, Andrew Cooper wrote:
> UEFI Runtime services, at the time of writing, aren't CET-IBT compatible.
> Work is ongoing to address this. In the meantime, unconditionally disable IBT.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>

> --- a/xen/common/efi/runtime.c
> +++ b/xen/common/efi/runtime.c
> @@ -21,6 +21,7 @@ struct efi_rs_state {
>    * don't strictly need that.
>    */
>   unsigned long __aligned(32) cr3;
> +    unsigned long msr_s_cet;
>  #endif
>  };

The latest with the next addition here we will probably want to ...

> @@ -113,6 +114,19 @@ struct efi_rs_state efi_rs_enter(void)

... no longer have this be the function's return type.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Feb 15 17:07:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 17:07:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273465.468661 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nK1Ig-0005FW-Pd; Tue, 15 Feb 2022 17:07:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273465.468661; Tue, 15 Feb 2022 17:07:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nK1Ig-0005FP-MZ; Tue, 15 Feb 2022 17:07:38 +0000
Received: by outflank-mailman (input) for mailman id 273465;
 Tue, 15 Feb 2022 17:07:37 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nK1If-0005FF-MI; Tue, 15 Feb 2022 17:07:37 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nK1If-0006Fe-J4; Tue, 15 Feb 2022 17:07:37 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nK1If-0001ak-3r; Tue, 15 Feb 2022 17:07:37 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nK1If-0001JZ-3Q; Tue, 15 Feb 2022 17:07:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ZANTauOoFoMyx7bYuyUA9bEWkd/M6w7mGwvUIsL3SpI=; b=B93paCkB9MwMpYErUWEL+D/+lE
	GjERDQnXBKRO5TWVQsREIMDWSkecpNVaUWrsfSMWDFMhVeEsmb5WJs7YngQNqbSOoZD1RqJByUnSa
	SdiTjI2Pzzmh4CTvwBg0PRIWc9PsHDfGPujt/ZzX7YuUJ5Ziz/LxAo8Ot5zsgvMi2+kw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168118-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 168118: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:windows-install:fail:heisenbug
    xen-unstable:test-arm64-arm64-xl-thunderx:xen-boot:fail:heisenbug
    xen-unstable:test-amd64-i386-qemuu-rhel6hvm-amd:guest-start/redhat.repeat:fail:heisenbug
    xen-unstable:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=94334d854bd358bd1d9c61d5e3306e4d903b120b
X-Osstest-Versions-That:
    xen=94334d854bd358bd1d9c61d5e3306e4d903b120b
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 15 Feb 2022 17:07:37 +0000

flight 168118 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168118/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-qemuu-win7-amd64 12 windows-install fail in 168111 pass in 168118
 test-arm64-arm64-xl-thunderx  8 xen-boot                   fail pass in 168111
 test-amd64-i386-qemuu-rhel6hvm-amd 14 guest-start/redhat.repeat fail pass in 168111
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 168111
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 18 guest-start/debianhvm.repeat fail pass in 168111

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop      fail blocked in 168111
 test-arm64-arm64-xl-thunderx 15 migrate-support-check fail in 168111 never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail in 168111 never pass
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168111
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168111
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168111
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168111
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168111
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168111
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168111
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168111
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168111
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168111
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168111
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  94334d854bd358bd1d9c61d5e3306e4d903b120b
baseline version:
 xen                  94334d854bd358bd1d9c61d5e3306e4d903b120b

Last test of basis   168118  2022-02-15 05:10:35 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            fail    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           fail    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 fail    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Tue Feb 15 17:49:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 17:49:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273476.468673 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nK1wZ-0000ue-Sx; Tue, 15 Feb 2022 17:48:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273476.468673; Tue, 15 Feb 2022 17:48:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nK1wZ-0000uX-PH; Tue, 15 Feb 2022 17:48:51 +0000
Received: by outflank-mailman (input) for mailman id 273476;
 Tue, 15 Feb 2022 17:48:50 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=h622=S6=arm.com=Luca.Fancellu@srs-se1.protection.inumbo.net>)
 id 1nK1wY-0000uN-De
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 17:48:50 +0000
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur02on0624.outbound.protection.outlook.com
 [2a01:111:f400:fe05::624])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8625bc4a-8e87-11ec-b215-9bbe72dcb22c;
 Tue, 15 Feb 2022 18:48:47 +0100 (CET)
Received: from DB6PR0202CA0011.eurprd02.prod.outlook.com (2603:10a6:4:29::21)
 by DB6PR0801MB2007.eurprd08.prod.outlook.com (2603:10a6:4:78::9) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.14; Tue, 15 Feb
 2022 17:48:43 +0000
Received: from DB5EUR03FT034.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:4:29:cafe::ed) by DB6PR0202CA0011.outlook.office365.com
 (2603:10a6:4:29::21) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19 via Frontend
 Transport; Tue, 15 Feb 2022 17:48:43 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT034.mail.protection.outlook.com (10.152.20.87) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4975.11 via Frontend Transport; Tue, 15 Feb 2022 17:48:43 +0000
Received: ("Tessian outbound 18e50a6f0513:v113");
 Tue, 15 Feb 2022 17:48:43 +0000
Received: from bb77d64df5ab.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 09D6C916-4C27-493C-853F-886484CAB7A6.1; 
 Tue, 15 Feb 2022 17:48:32 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id bb77d64df5ab.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 15 Feb 2022 17:48:32 +0000
Received: from VI1PR0801MB2125.eurprd08.prod.outlook.com
 (2603:10a6:800:5b::23) by DB6PR0802MB2424.eurprd08.prod.outlook.com
 (2603:10a6:4:a0::8) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.14; Tue, 15 Feb
 2022 17:48:30 +0000
Received: from VI1PR0801MB2125.eurprd08.prod.outlook.com
 ([fe80::5531:4c33:a50c:ea0e]) by VI1PR0801MB2125.eurprd08.prod.outlook.com
 ([fe80::5531:4c33:a50c:ea0e%9]) with mapi id 15.20.4975.018; Tue, 15 Feb 2022
 17:48:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8625bc4a-8e87-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=+qKkaHHmKKIJajO827U52gAvCWMeX/xn59bD2EEt4u8=;
 b=6Rmk4LlMtd4Rce/Nx0p+RftNroihdiyykWfx175sRPJStN3bLIMvB1zJWEiPFAFaoQ8kZ/LdYhFYTmG/hr7MbWHscKnePxMcsHoS4UUjJ8B0YNr2VpUdrm08TJplJQXdU6PmmfLYAZ0xl2FYmvInrxwhCZpWbUWvx2DD63TSuEs=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 006e210cd753c964
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=AVtVYSnyJ6guxjqivDp8lL6r2tFk7FJfHmtWZD4FypBM3ls+poidLplr4AWzGia9vY8T1oLkuubviQfAXBwaYKrg8Hw3l+eWP5XcSdYfveg2gMLDHsZOG7Y0DqPmSnMxZ9niZHpCee/EYnw7BoTcooPrOWjLvKFjYNbaxXlkN/3lXMbTp/lIFDowHmb3dsran2zgZyQTMeWZcJnmuocJnSgbbRdpZFplymUX44aE9Mj7jkZRyzVhsEVuu+LfjrLhvizCjuZ4BCa+zgX4KwvrYQTZl34kcfzXuq/SIlduUT3+a1yRRyYEAUrfles06Vx2bKplA2z9N21IpXef9StQYQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=+qKkaHHmKKIJajO827U52gAvCWMeX/xn59bD2EEt4u8=;
 b=VLhgKhR3Pt8iH846A2yJqxr4kq7Tmklvn7qhBhm95JeiT/eLS5vClnAiN9PsYDgr7D1hlQ/gZZ6RRQXqf0d+Xda9tAhYsyR5wqv76pgLllBjh8cYRErwCwWJiIMar9l7uKKyv4KPie+ZNf9WginbG1CAGmLMapZokCRtte8EuoQo20LT/MNnpB3rfZIL44/sXxyd3Z8UXC+mk4efIHMST1hDUPHW7knev3hzn/8ffXEZd5ZE+tg0FdPUEwsRG4KG161y2aSFMv1xjtFuoMykpNXMB3MVQxfoYMZewp2Z/XN7WWCfok10jzrmkLP0KjK5frakvQsa/gdAkLnaadF1eg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=+qKkaHHmKKIJajO827U52gAvCWMeX/xn59bD2EEt4u8=;
 b=6Rmk4LlMtd4Rce/Nx0p+RftNroihdiyykWfx175sRPJStN3bLIMvB1zJWEiPFAFaoQ8kZ/LdYhFYTmG/hr7MbWHscKnePxMcsHoS4UUjJ8B0YNr2VpUdrm08TJplJQXdU6PmmfLYAZ0xl2FYmvInrxwhCZpWbUWvx2DD63TSuEs=
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
Content-Type: text/plain;
	charset=utf-8
Subject: Re: [PATCH 1/5] tools/cpupools: Give a name to unnamed cpupools
From: Luca Fancellu <luca.fancellu@arm.com>
In-Reply-To: <efd968bb-e3f6-9e16-3826-4cab25127718@suse.com>
Date: Tue, 15 Feb 2022 17:48:26 +0000
Cc: xen-devel@lists.xenproject.org,
 wei.chen@arm.com,
 Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <71460E15-5D09-4CE6-99ED-4858147BB0D0@arm.com>
References: <20220215101551.23101-1-luca.fancellu@arm.com>
 <20220215101551.23101-2-luca.fancellu@arm.com>
 <efd968bb-e3f6-9e16-3826-4cab25127718@suse.com>
To: Juergen Gross <jgross@suse.com>
X-Mailer: Apple Mail (2.3693.60.0.1.1)
X-ClientProxiedBy: LO4P123CA0300.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:196::17) To VI1PR0801MB2125.eurprd08.prod.outlook.com
 (2603:10a6:800:5b::23)
MIME-Version: 1.0
X-MS-Office365-Filtering-Correlation-Id: e593d41f-5a06-4549-eae0-08d9f0ab68b5
X-MS-TrafficTypeDiagnostic:
	DB6PR0802MB2424:EE_|DB5EUR03FT034:EE_|DB6PR0801MB2007:EE_
X-Microsoft-Antispam-PRVS:
	<DB6PR0801MB20076E95575BA3ACC39AD979E4349@DB6PR0801MB2007.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 nLoXcHkXySoyN37qC9p93zOPmj5/pquV0UKXC4WF53Uo52CJyNugwpzJmtv+uuBJof1PrkgEUJdkavCqb+unys9LCrhWtJNNxcLm95cSbOtpt+o6rJZIprpJPIs0nNpJI5AqTeq1L68KSPO/UXdTx1kbLhQQvsda+kmlHZI4Lyc/2QfBgPjgDk3DNjpGLMNi6tz4W7IwpIerXq0yrpXVxYSnpZ66HfhusfxZzYqXKmCykwijXI2TO3Alp826gx+WAiqlSziQOAfkf8Q4wzfuw2jY9Gh466dh1ROq9tFq2E8k2gX0fx8qNsNl3CBkI7izTTbABL7K78QbWtmv0MP57subqbm/rF56ls1eobKcr89WIPG8N4tn00NWs8QymHnk9L9yT3no7r94z1vXYG7nb/wmXjcAzyhNFdTVX2jb+5useOvMG0BLpO0uKOJnWrl3Fqy2si8d2O8DIBsTh9AfjE9A0kIx3IUJTpKQqKsq585On38hJpBELGgQQ0vWLQKurJIDiKBY69F2jtq6/oIMPbrBsk0Am/dSWGULEcvutFVoCTMlBqnHcHiOdTHJeozdeN7yRyxylxoLB6UxNa1G3cK4ZMH5I/997y056eKZcE8GQKM7ExY9E2YQhLchm7eg/8n4i4JwSnZ2fMwGL2OaVfVXcR76yieHIsx+NQ7IS8RG+oQv4iy0i5U9tg6vTK7pT5j0tNNljMapx/v0YT62+L2x4mXrgXwQkiK6xDPgxDo=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR0801MB2125.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6512007)(26005)(83380400001)(186003)(2616005)(5660300002)(44832011)(2906002)(8936002)(53546011)(508600001)(6506007)(6486002)(52116002)(6666004)(4326008)(8676002)(66476007)(66556008)(66946007)(316002)(6916009)(38350700002)(86362001)(33656002)(36756003)(38100700002)(54906003)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2424
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT034.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	be81d8c0-54c3-4932-454f-08d9f0ab609f
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	FayZxx0ypRFpQNrYkdD52VM2pIrCov9H6PYkU7QYl6r4ZjP9JF/XjCsgRKRJgZbBzRhmMVThu7VJnlMKqMck2luoBJ84e8QwrazN8WJ4+j+PL0B2fcAFblIiJR2ERPyS786BPp0jyfBGOGBB77H4aEB4L041fay8hyC+yTuP/Mk4RMHquNuAARNVWKRFZ5Ftl01AMsMkulJ9u8qhOFSu3kvNYHw02jwTRuTwTtreCIum9Y44fS5AbYgShB0K3bsvvvuq5Kn6/3HQlTSUxifvdKvAMKrpYVcC/2qOaj5XBd9cEadobjAXKClzCEPS6n1xnsZVero0QRo/pPH38IYrxDYJzJT2u4LPEErvBm4HadpJzg/MjZX1x0y3V03TIm9kIKNec1z6L0tquzciMEe3BzOZl2PqlMz4BR1R0X/ixT+06gxNWwr/7odClyyZ4VpFjqxrXh+IWleF1zIN/IM+EATo4yJ1UfO1BNPiWoO0b395JAqnA3DvvevBHTR8MtbOX4nHZxaHv/aKTKti52bd93MTQW+SKNaxd/JIpGmIuiWWYlc7AySMkTFoOW06hjCQec4YBELshh7v4PyuskoIoC2rStTJI2J8AAYk2gLkPCs3yVMMcMGHUG9hNqvJeSqKt05kTOAe1LqjKxtEYtRiVnp84um180IytGqvhWMTUbEdgnyAXAReI/XuvS8rV0Rq
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(356005)(6486002)(36860700001)(47076005)(316002)(54906003)(36756003)(83380400001)(81166007)(40460700003)(6862004)(5660300002)(53546011)(33656002)(6512007)(508600001)(6506007)(8936002)(44832011)(107886003)(2906002)(82310400004)(70586007)(6666004)(26005)(186003)(8676002)(86362001)(70206006)(336012)(2616005)(4326008);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 17:48:43.6387
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: e593d41f-5a06-4549-eae0-08d9f0ab68b5
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT034.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB2007



> On 15 Feb 2022, at 10:33, Juergen Gross <jgross@suse.com> wrote:
>=20
> On 15.02.22 11:15, Luca Fancellu wrote:
>> With the introduction of boot time cpupools, Xen can create many
>> different cpupools at boot time other than cpupool with id 0.
>> Since these newly created cpupools can't have an
>> entry in Xenstore, create the entry using xen-init-dom0
>> helper with the usual convention: Pool-<cpupool id>.
>> Given the change, remove the check for poolid =3D=3D 0 from
>> libxl_cpupoolid_to_name(...).
>> Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
>> ---
>>  tools/helpers/xen-init-dom0.c  | 26 +++++++++++++++++++++++++-
>>  tools/libs/light/libxl_utils.c |  3 +--
>>  2 files changed, 26 insertions(+), 3 deletions(-)
>> diff --git a/tools/helpers/xen-init-dom0.c b/tools/helpers/xen-init-dom0=
.c
>> index c99224a4b607..3539f56faeb0 100644
>> --- a/tools/helpers/xen-init-dom0.c
>> +++ b/tools/helpers/xen-init-dom0.c
>> @@ -43,7 +43,10 @@ int main(int argc, char **argv)
>>      int rc;
>>      struct xs_handle *xsh =3D NULL;
>>      xc_interface *xch =3D NULL;
>> -    char *domname_string =3D NULL, *domid_string =3D NULL;
>> +    char *domname_string =3D NULL, *domid_string =3D NULL, *pool_string=
 =3D NULL;

Hi Juergen,

>=20
> pool_string seems to be unused.

I will remove it

>=20
>> +    char pool_path[strlen("/local/pool") + 12], pool_name[strlen("Pool-=
") + 5];
>=20
> I don't like that. Why don't you use pointers and ...
>=20
>> +    xc_cpupoolinfo_t *xcinfo;
>> +    unsigned int pool_id =3D 0;
>>      libxl_uuid uuid;
>>        /* Accept 0 or 1 argument */
>> @@ -114,6 +117,27 @@ int main(int argc, char **argv)
>>          goto out;
>>      }
>>  +    /* Create an entry in xenstore for each cpupool on the system */
>> +    do {
>> +        xcinfo =3D xc_cpupool_getinfo(xch, pool_id);
>> +        if (xcinfo !=3D NULL) {
>> +            if (xcinfo->cpupool_id !=3D pool_id)
>> +                pool_id =3D xcinfo->cpupool_id;
>> +            snprintf(pool_path, sizeof(pool_path), "/local/pool/%d/name=
",
>> +                     pool_id);
>> +            snprintf(pool_name, sizeof(pool_name), "Pool-%d", pool_id);
>=20
> ... use asprintf() here for allocating the strings in the needed size?

Why would you like more this approach? I was trying to avoid allocation/fre=
e
operations in a loop that would need also more code to check cases in which
memory is not allocated. Instead with the buffers in the stack we don=E2=80=
=99t have problems.

>=20
>> +            pool_id++;
>> +            if (!xs_write(xsh, XBT_NULL, pool_path, pool_name,
>> +                          strlen(pool_name))) {
>> +                fprintf(stderr, "cannot set pool name\n");
>> +                rc =3D 1;
>> +            }
>> +            xc_cpupool_infofree(xch, xcinfo);
>> +            if (rc)
>> +                goto out;
>=20
> Moving the call of xc_cpupool_infofree() ahead of the call of xs_write()
> would drop the need for this last if statement, as you could add the
> goto to the upper if.

Yes you are right, it would simplify the code

>=20
>> +        }
>> +    } while(xcinfo !=3D NULL);
>> +
>=20
> With doing all of this for being able to assign other domains created
> at boot to cpupools, shouldn't you add names for other domains than dom0
> here, too?

This serie is more about cpupools, maybe I can do that in another commit ou=
t
of this serie.

Thanks for your review.

Cheers,
Luca

>=20
>=20
> Juergen
> <OpenPGP_0xB0DE9DD628BF132F.asc>



From xen-devel-bounces@lists.xenproject.org Tue Feb 15 17:50:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 17:50:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273485.468684 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nK1yN-0002K7-C0; Tue, 15 Feb 2022 17:50:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273485.468684; Tue, 15 Feb 2022 17:50:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nK1yN-0002K0-8i; Tue, 15 Feb 2022 17:50:43 +0000
Received: by outflank-mailman (input) for mailman id 273485;
 Tue, 15 Feb 2022 17:50:42 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=h622=S6=arm.com=Luca.Fancellu@srs-se1.protection.inumbo.net>)
 id 1nK1yM-0002Jp-4w
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 17:50:42 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04on061e.outbound.protection.outlook.com
 [2a01:111:f400:fe0d::61e])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ca43770f-8e87-11ec-b215-9bbe72dcb22c;
 Tue, 15 Feb 2022 18:50:41 +0100 (CET)
Received: from FR3P281CA0019.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c::6) by
 AM6PR08MB3224.eurprd08.prod.outlook.com (2603:10a6:209:47::13) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4975.18; Tue, 15 Feb 2022 17:50:37 +0000
Received: from VE1EUR03FT021.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:d10:1c:cafe::9b) by FR3P281CA0019.outlook.office365.com
 (2603:10a6:d10:1c::6) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.8 via Frontend
 Transport; Tue, 15 Feb 2022 17:50:37 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT021.mail.protection.outlook.com (10.152.18.117) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4975.11 via Frontend Transport; Tue, 15 Feb 2022 17:50:36 +0000
Received: ("Tessian outbound 63bb5eb69ee8:v113");
 Tue, 15 Feb 2022 17:50:36 +0000
Received: from c1ec6550b558.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 1833A4B7-99C9-4052-B4EA-2E194DF0913C.1; 
 Tue, 15 Feb 2022 17:50:26 +0000
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c1ec6550b558.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 15 Feb 2022 17:50:26 +0000
Received: from VI1PR0801MB2125.eurprd08.prod.outlook.com
 (2603:10a6:800:5b::23) by DB7PR08MB3467.eurprd08.prod.outlook.com
 (2603:10a6:10:48::22) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.15; Tue, 15 Feb
 2022 17:50:24 +0000
Received: from VI1PR0801MB2125.eurprd08.prod.outlook.com
 ([fe80::5531:4c33:a50c:ea0e]) by VI1PR0801MB2125.eurprd08.prod.outlook.com
 ([fe80::5531:4c33:a50c:ea0e%9]) with mapi id 15.20.4975.018; Tue, 15 Feb 2022
 17:50:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ca43770f-8e87-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Ne5DhximP25m0nxT5RWvd303HKEY0pT0i+RqLpcnIDI=;
 b=PRev5fxpRtVey7WNlyQKTO5CWDNBd5O1AJWuM326TQJnYtgtcMUprMxTMl/YFfaaG7XX0XVHSVrHimLXlBk6hlYQsbd7Oyw7Viwz02QUvzXxM82/Z8lkeadi1vcNGUfShXrzXoUH+UTRHyWDfh73eJ6LewXm6pOspZvlTKpCXys=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 2e0798f6cc577667
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=KVDrF5EXt2pgxqAGqEisaSuYKXDFfzZDQ1whDjdOg8foBacx07cpDhoADrZqDIzkno6r0gD31g7hQobVwPtlBYn1wQzJ4KMcf/gkNFK+wSQwlzPTmZ+LebA5gVEnhXl73GmPncGXsRND3uY199UCoy5qw/GsvclLwPxf9Ym821ezmcxHHTcr+7sEpVQoq6P788V9q8VMEpRjsJR7VVeqz5PbnfCgESRDQhXgBMDZxrbBddUnGasqLgn6XbKFCZtV789dxUZhngWlMV9f7ARNkBWvSYZQgUXcqagZRJOblNVqqX5/lUoXvpdbOR6rl52hiKkTn4FNB5KlyngUtfKUmw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Ne5DhximP25m0nxT5RWvd303HKEY0pT0i+RqLpcnIDI=;
 b=UoMMe7+FoGe5KmqZhZiWa6UB/oljI8bVhqTglKAOhIsNL/Kp9iQ4ldBxttcWNBrEacOrGMfAPele0THyCsBlsgmOv6ANXIP6WpYOXrUtrsZdgn9J2K1QKL3M54P+EOrHyTRJcVoZF6o5QzDuUtv6JAG51qdqpTVBNexw456ykmrM3aT0PHmZFRET7xJAQE5lCiOjaoBABwEq/5wvSj7pIcZyQfDMtnFgvlDrAT59Gkh++z2Uv/OXxfrhfnE6LyffX0JJAUKDcWc0F1Mmh/TgenYt5LkGD/EBWpJ3y7traJf2dD+NiH+6yEacvkxwxlP/EmezdkffqTizLKSTFjbIZw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Ne5DhximP25m0nxT5RWvd303HKEY0pT0i+RqLpcnIDI=;
 b=PRev5fxpRtVey7WNlyQKTO5CWDNBd5O1AJWuM326TQJnYtgtcMUprMxTMl/YFfaaG7XX0XVHSVrHimLXlBk6hlYQsbd7Oyw7Viwz02QUvzXxM82/Z8lkeadi1vcNGUfShXrzXoUH+UTRHyWDfh73eJ6LewXm6pOspZvlTKpCXys=
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
Content-Type: text/plain;
	charset=us-ascii
Subject: Re: [PATCH 2/5] xen/sched: create public function for cpupools
 creation
From: Luca Fancellu <luca.fancellu@arm.com>
In-Reply-To: <50ad5e74-c8b6-bdb3-2a9b-fa118610d07d@suse.com>
Date: Tue, 15 Feb 2022 17:50:19 +0000
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
 Wei Chen <wei.chen@arm.com>,
 Dario Faggioli <dfaggioli@suse.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 Jan Beulich <jbeulich@suse.com>,
 Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>
Content-Transfer-Encoding: 7bit
Message-Id: <3E27F91F-F97A-443D-BBA8-8400FA3FF377@arm.com>
References: <20220215101551.23101-1-luca.fancellu@arm.com>
 <20220215101551.23101-3-luca.fancellu@arm.com>
 <50ad5e74-c8b6-bdb3-2a9b-fa118610d07d@suse.com>
To: Juergen Gross <jgross@suse.com>
X-Mailer: Apple Mail (2.3693.60.0.1.1)
X-ClientProxiedBy: LO4P123CA0021.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:151::8) To VI1PR0801MB2125.eurprd08.prod.outlook.com
 (2603:10a6:800:5b::23)
MIME-Version: 1.0
X-MS-Office365-Filtering-Correlation-Id: f3db0eff-fe64-4e51-f584-08d9f0abac3d
X-MS-TrafficTypeDiagnostic:
	DB7PR08MB3467:EE_|VE1EUR03FT021:EE_|AM6PR08MB3224:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR08MB3224700B8EE683E60FEB6672E4349@AM6PR08MB3224.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 LN/9GwGF3wnXkA8zyeck7iRNFDCea7Iif9RLCOEO6ObzfTy2UTqaauxbYD2XWYPbPeF8j4O4WHuIQCwd63Zshr1izekWi0fOGBZmLOxJlgoNwnsZatNydLSbTIH7b2KQjvg/2DPNrL1rWt8vbQVSNT7l4VbDllf6VI5nEp1c3+SDxHQRJBAVN8PynIYfkmi8vsXVlSkLJzw+HaBItkXoyOWMK+eJhbsjTxrNIufbACPJOHbcbwo5WmcMXf1V0nv14DS1+sC83X0e4nh8VZaH6lBsJ1pIJwxATFEJYoaGL5QGJNFslHEYzZHfG7fjWxC3QYI89MvQPkkWp/KApj7EpIljyqYPvVw5aJ45z43aKHUT/CcQg+8U37EORkC38BMeTMQ0vw7nyE03Fzy6PSBUqFySwSqsUTo2KGncRD2yhJFDiOm1rwcys+V79yr2PGxmbDKdMxHoCNk9BLqkXXwSacGto/qGRJJfzc+E+1o85jRVC6KVDlEer+267Q/IwcmEeZbvo5lVEhhpspy+xOxt0j/iObU0B9rOus+KsHkc2D5YovCkGnTyS5mAyDIK4oXZzVOzGsf+w72pQolM5XY2rt+EYiIRc/ANdFAbwzO70+BhN0+vYmLut8uAQWpas/nPd1YCqDCXaadXjwC9lD1REifBGNnAgN940W92rYMHcROtHcx2ztKh/nzifF3arkIUWD8mYGbLPBcXF3dzODlvVamDuzAQRIPIoVPHPYj0Ri8=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR0801MB2125.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(186003)(6512007)(6506007)(6666004)(38100700002)(38350700002)(52116002)(53546011)(66476007)(66556008)(66946007)(2906002)(2616005)(26005)(8936002)(4326008)(36756003)(4744005)(5660300002)(44832011)(8676002)(54906003)(508600001)(33656002)(6916009)(316002)(6486002)(86362001)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3467
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT021.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	09ddcd74-d37a-4f77-0fe8-08d9f0aba490
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	djMZONIg4VQj4GvxAYnUxgt9Z2UzCxtr8UmivazmzDgkdIGf3jyn0CRwMFjHDwN2Lu9oDeghAUcBnvIMOoAg3ggg1UvkPE4q+3Qwk96nlWqo1U1yJTEBW0H67pIZNOrh+gRT8k5VuCmGcVxRfl4P9hbxrTKfzXWEc95Y1fta2vQLz5vri6MLXBWO8+lgm7f/dUoKApfEk8GaDw/ajXr/gljTBNHFbUlkf+AQQQ/IZrC6O3pmvpx1DYx8yKdsdxRbfHlOFNm1/UtN/au8g3LBXq6Kg/CuKLOgYsmSoOxPIfW6VWwkaHD8iVVf0F0OE/QYe9FzFaxZIC/P+4hhZgor+/NtP5l4VfDC2ydzL7ZbJUXW7z4275Rh2jlQXhwl4TQ+qAQbLajaKlbhC5O3MXkpI8/7Ycsglo76DbdHE+YCJDQBopWzykJPP7aN6BZmZ1THAiL0fUci9jfnM/3gg9Dl+5e20nWplk4utx7xIGgwTNkO/AC8MsOVhbwyBGlXA0jSwI3DlufXTtuauu4WUHKUzqfvCQQBgUWDpmnZNV/j6aB8WS9O1NB49FxIVi4ToU5SLDqn71IMx5t+BrByPO7P3YocEYWdYOMpLP0eUrXsob1wKB/qFETCEfbQUCiGn07wTEh8yO+Odzita33ZYtKMtY2G2TfHfcMsJv0QdUIZWYncN8YJ2kOkt7ZbeHgKauLv
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(53546011)(36756003)(508600001)(6512007)(6506007)(6486002)(54906003)(33656002)(36860700001)(40460700003)(316002)(6666004)(47076005)(86362001)(4744005)(82310400004)(8936002)(81166007)(70206006)(70586007)(5660300002)(356005)(8676002)(186003)(26005)(4326008)(2616005)(336012)(2906002)(6862004)(44832011);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 17:50:36.8378
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: f3db0eff-fe64-4e51-f584-08d9f0abac3d
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT021.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3224



> On 15 Feb 2022, at 10:38, Juergen Gross <jgross@suse.com> wrote:
> 
> On 15.02.22 11:15, Luca Fancellu wrote:
>> Create new public function to create cpupools, it checks for pool id
>> uniqueness before creating the pool and can take a scheduler id or
>> a negative value that means the default Xen scheduler will be used.
>> Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
> 
> Reviewed-by: Juergen Gross <jgross@suse.com>
> 
> with one further question: you are allowing to use another scheduler,
> but what if someone wants to set non-standard scheduling parameters
> (e.g. another time slice)?

I guess for now parameters can be tuned only by xl tool, however it would
be possible as future work to allow parameters in the device tree for each
scheduler.

Cheers,
Luca

> 
> 
> Juergen
> <OpenPGP_0xB0DE9DD628BF132F.asc>



From xen-devel-bounces@lists.xenproject.org Tue Feb 15 17:52:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 17:52:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273491.468695 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nK1zx-0002vI-O7; Tue, 15 Feb 2022 17:52:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273491.468695; Tue, 15 Feb 2022 17:52:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nK1zx-0002vB-Ks; Tue, 15 Feb 2022 17:52:21 +0000
Received: by outflank-mailman (input) for mailman id 273491;
 Tue, 15 Feb 2022 17:52:20 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1FBm=S6=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1nK1zw-0002v5-7c
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 17:52:20 +0000
Received: from ppsw-31.csi.cam.ac.uk (ppsw-31.csi.cam.ac.uk [131.111.8.131])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 03f8aa0d-8e88-11ec-8eb8-a37418f5ba1a;
 Tue, 15 Feb 2022 18:52:18 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:56038)
 by ppsw-31.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.137]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1nK1zq-000AtD-L3 (Exim 4.95) (return-path <amc96@srcf.net>);
 Tue, 15 Feb 2022 17:52:14 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 1E02D1FA96;
 Tue, 15 Feb 2022 17:52:14 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 03f8aa0d-8e88-11ec-8eb8-a37418f5ba1a
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <8c6d9714-7e45-1603-a5ad-d49fc060304e@srcf.net>
Date: Tue, 15 Feb 2022 17:52:13 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Content-Language: en-GB
To: Jan Beulich <jbeulich@suse.com>, Andrew Cooper
 <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= <marmarek@invisiblethingslab.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
 <20220214125127.17985-8-andrew.cooper3@citrix.com>
 <95c29039-302c-256b-d381-2b5b8b9c1a4a@suse.com>
From: Andrew Cooper <amc96@srcf.net>
Subject: Re: [PATCH v2 07/70] x86: Build check for embedded endbr64
 instructions
In-Reply-To: <95c29039-302c-256b-d381-2b5b8b9c1a4a@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 15/02/2022 15:12, Jan Beulich wrote:
> On 14.02.2022 13:50, Andrew Cooper wrote:
>> From: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
>>
>> Embedded endbr64 instructions mark legal indirect branches as far as the CPU
>> is concerned, which aren't legal as far as the logic is concerned.
> I think it would help if it was clarified what "embedded" actually means
> here.

Oh yeah, that's lost a bit of context now I've split it out of the patch
introducing endbr.h

>
>> --- a/xen/arch/x86/Makefile
>> +++ b/xen/arch/x86/Makefile
>> @@ -155,6 +155,9 @@ $(TARGET)-syms: prelink.o xen.lds
>>  	$(MAKE) -f $(BASEDIR)/Rules.mk $(@D)/.$(@F).1.o
>>  	$(LD) $(XEN_LDFLAGS) -T xen.lds -N prelink.o $(build_id_linker) \
>>  	    $(@D)/.$(@F).1.o -o $@
>> +ifeq ($(CONFIG_XEN_IBT),y)
>> +	$(SHELL) $(BASEDIR)/tools/check-endbr.sh $@
>> +endif
>>  	$(NM) -pa --format=sysv $(@D)/$(@F) \
>>  		| $(BASEDIR)/tools/symbols --all-symbols --xensyms --sysv --sort \
>>  		>$(@D)/$(@F).map
> The same wants doing on xen.efi, I guess?

Probably.

>
>> --- /dev/null
>> +++ b/xen/tools/check-endbr.sh
>> @@ -0,0 +1,76 @@
>> +#!/bin/sh
>> +
>> +#
>> +# Usage ./$0 xen-syms
>> +#
>> +
>> +set -e
>> +
>> +OBJCOPY="${OBJCOPY:-objcopy} -j .text $1"
>> +OBJDUMP="${OBJDUMP:-objdump} -j .text $1"
>> +
>> +D=$(mktemp -d)
>> +trap "rm -rf $D" EXIT
>> +
>> +TEXT_BIN=$D/xen-syms.text
>> +VALID=$D/valid-addrs
>> +ALL=$D/all-addrs
>> +BAD=$D/bad-addrs
>> +
>> +#
>> +# First, look for all the valid endbr64 instructions.
>> +# A worst-case disassembly, viewed through cat -A, may look like:
>> +#
>> +# ffff82d040337bd4 <endbr64>:$
>> +# ffff82d040337bd4:^If3 0f 1e fa          ^Iendbr64 $
>> +# ffff82d040337bd8:^Ieb fe                ^Ijmp    ffff82d040337bd8 <endbr64+0x4>$
>> +# ffff82d040337bda:^Ib8 f3 0f 1e fa       ^Imov    $0xfa1e0ff3,%eax$
>> +#
>> +# Want to grab the address of endbr64 instructions only, ignoring function
>> +# names/jump labels/etc, so look for 'endbr64' preceeded by a tab and with any
>> +# number of trailing spaces before the end of the line.
>> +#
>> +${OBJDUMP} -d | grep '	endbr64 *$' | cut -f 1 -d ':' > $VALID &
> Since you look at only .text the risk of the disassembler coming
> out of sync with the actual instruction stream is lower than when
> 32- and 16-bit code was also part of what is disassembled, but it's
> not zero.

I'm not sure that we have any interesting non-64bit code at all in .text.

_start is technically 32bit but is mode-invariant as far as decoding goes.

The kexec trampoline is here too, but when I dust off my cleanup patch,
there will no longer be data or mode-dependent things to disassemble.

Everything else I can think of is in .init.text.

> Any zero-padding inserted anywhere by the linker can
> result in an immediately following ENDBR to be missed (because
> sequences of zeros resemble 2-byte insns).

I'm not sure this is a problem.  This pass is looking for everything
that objdump thinks is a legal endbr64 instruction, and it splits at labels.

Only the hand-written stubs can legitimately have an endbr64 without a
symbol pointing at it.

We also don't have any 0 padding.  It's specified as 0x90 in the linker
file, although I've been debating switching this to 0xcc for a while now
already.

>  While this risk may be
> acceptable, I think it wants mentioning at least in the description,
> maybe even at the top of the script (where one would likely look
> first after it spitting out an error).
>
> Do you perhaps want to also pass -w to objdump, to eliminate the
> risk of getting confused by split lines?

I think that's probably a good move irrespective.  This particular pipe
is the longest single task in the script which is why I backgrounded it
while the second scan occurs.  -w means fewer lines so hopefully a minor
speedup.

>> +#
>> +# Second, look for any endbr64 byte sequence
>> +# This has a couple of complications:
>> +#
>> +# 1) Grep binary search isn't VMA aware.  Copy .text out as binary, causing
>> +#    the grep offset to be from the start of .text.
>> +#
>> +# 2) AWK can't add 64bit integers, because internally all numbers are doubles.
>> +#    When the upper bits are set, the exponents worth of precision is lost in
>> +#    the lower bits, rounding integers to the nearest 4k.
>> +#
>> +#    Instead, use the fact that Xen's .text is within a 1G aligned region, and
>> +#    split the VMA in half so AWK's numeric addition is only working on 32 bit
>> +#    numbers, which don't lose precision.
>> +#
>> +eval $(${OBJDUMP} -h | awk '$2 == ".text" {printf "vma_hi=%s\nvma_lo=%s\n", substr($4, 1, 8), substr($4, 9, 16)}')
>> +
>> +${OBJCOPY} -O binary $TEXT_BIN
>> +grep -aob "$(printf '\363\17\36\372')" $TEXT_BIN |
>> +    awk -F':' '{printf "%s%x\n", "'$vma_hi'", strtonum(0x'$vma_lo') + $1}' > $ALL
> None of the three options passed to grep look to be standardized.
> Is this going to cause problems on non-Linux systems? Should this
> checking perhaps be put behind a separate Kconfig option?

CI says that FreeBSD is entirely happy, while Alpine Linux isn't.  This
is because Alpine has busybox's grep unless you install the GNU grep
package, and I'm doing a fix to our container.

My plan to fix this is to just declare a "grep capable of binary
searching" a conditional build requirement for Xen.  I don't think this
is onerous, and there no other plausible alternatives here.

The other option is to detect the absence of support an skip the check. 
It is after all a defence in depth scheme, and anything liable to cause
a problem would be caught in CI anyway.

>> +# Wait for $VALID to become complete
>> +wait
>> +
>> +# Sanity check $VALID and $ALL, in case the string parsing bitrots
>> +val_sz=$(stat -c '%s' $VALID)
>> +all_sz=$(stat -c '%s' $ALL)
>> +[ "$val_sz" -eq 0 ]         && { echo "Error: Empty valid-addrs" >&2; exit 1; }
>> +[ "$all_sz" -eq 0 ]         && { echo "Error: Empty all-addrs" >&2; exit 1; }
>> +[ "$all_sz" -lt "$val_sz" ] && { echo "Error: More valid-addrs than all-addrs" >&2; exit 1; }
>> +
>> +# $BAD = $ALL - $VALID
>> +join -v 2 $VALID $ALL > $BAD
>> +nr_bad=$(wc -l < $BAD)
>> +
>> +# Success
>> +[ "$nr_bad" -eq 0 ] && exit 0
>> +
>> +# Failure
>> +echo "Fail: Found ${nr_bad} embedded endbr64 instructions" >&2
>> +addr2line -afip -e $1 < $BAD >&2
> There probably also wants to be an ADDR2LINE variable then. If
> one overrides objdump and objcopy, one would likely want/need to
> override this one as well.

Ah yes.  Will fix.

~Andrew




From xen-devel-bounces@lists.xenproject.org Tue Feb 15 17:53:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 17:53:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273497.468706 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nK20e-0003Tm-1N; Tue, 15 Feb 2022 17:53:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273497.468706; Tue, 15 Feb 2022 17:53:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nK20d-0003Tf-Tj; Tue, 15 Feb 2022 17:53:03 +0000
Received: by outflank-mailman (input) for mailman id 273497;
 Tue, 15 Feb 2022 17:53:02 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=h622=S6=arm.com=Luca.Fancellu@srs-se1.protection.inumbo.net>)
 id 1nK20c-0003TO-UV
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 17:53:02 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05on2061c.outbound.protection.outlook.com
 [2a01:111:f400:7e1a::61c])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1e4c5d01-8e88-11ec-8eb8-a37418f5ba1a;
 Tue, 15 Feb 2022 18:53:02 +0100 (CET)
Received: from DU2PR04CA0311.eurprd04.prod.outlook.com (2603:10a6:10:2b5::16)
 by AM6PR08MB4657.eurprd08.prod.outlook.com (2603:10a6:20b:cf::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.14; Tue, 15 Feb
 2022 17:53:00 +0000
Received: from DB5EUR03FT058.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:2b5:cafe::5d) by DU2PR04CA0311.outlook.office365.com
 (2603:10a6:10:2b5::16) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.15 via Frontend
 Transport; Tue, 15 Feb 2022 17:53:00 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT058.mail.protection.outlook.com (10.152.20.255) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4975.11 via Frontend Transport; Tue, 15 Feb 2022 17:52:59 +0000
Received: ("Tessian outbound 1f399c739551:v113");
 Tue, 15 Feb 2022 17:52:59 +0000
Received: from 35bd68bbd38d.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 2C1421D5-5932-4739-A8EA-9D6EA4966962.1; 
 Tue, 15 Feb 2022 17:52:54 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 35bd68bbd38d.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 15 Feb 2022 17:52:54 +0000
Received: from VI1PR0801MB2125.eurprd08.prod.outlook.com
 (2603:10a6:800:5b::23) by DB7PR08MB3467.eurprd08.prod.outlook.com
 (2603:10a6:10:48::22) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.15; Tue, 15 Feb
 2022 17:52:52 +0000
Received: from VI1PR0801MB2125.eurprd08.prod.outlook.com
 ([fe80::5531:4c33:a50c:ea0e]) by VI1PR0801MB2125.eurprd08.prod.outlook.com
 ([fe80::5531:4c33:a50c:ea0e%9]) with mapi id 15.20.4975.018; Tue, 15 Feb 2022
 17:52:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1e4c5d01-8e88-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=un3rfBjBA+/TDycrQBT+tXIqPcY944i6C8CUpv3E6dE=;
 b=r/pe+lgcAsobXTqFuBLnhjO8unQCy/yPa5rh5LINW/IF5n3kR35f1aMl3WazmqOeqzIvKFnlUx+sGt+Eg/DyoFCm4NguUd1fNFqndhY1LSNbM0sezPtcmlx7A/VlNTQ3ZS9CTeLeSs11G1APO0q/hsrrMOZF3joxQsy32Iljrtg=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 75298232c1e41de1
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=eR3+ZijK0MilGoYOh00BwRG8rxE+hVjN39b22vUg2RdwTITMj1XN61LuWhv4RIC/deR9uXK1auAxHsWi7F8G01fznq95lYrA97VZ3435NyLL8uJ92k/lASa9DSKHiKDxlwbpo+Zu55HjKsqqimZ9o6t+hdkQ+q7lPLPEEP5gnKHJq3ca8Oj1J3FnvQ3INgu1evrFYd0kXdHAdyO9tVTzl8c4dpFd68hDMm4FSpto0mJtxJfFuW3uWgSaYQHm6Mm1bYW98mruIFnolPLOHZpTMHhJDJn8pUc1dYx7j4ZSaLKsVaJA5bwczPB7alNGsORxwyKFfC1giKFBzTkyLDDo4g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=un3rfBjBA+/TDycrQBT+tXIqPcY944i6C8CUpv3E6dE=;
 b=Fa4VuP/qFe76TT7Jz6mO3mbCy7bbZCLpKIjKxNDMzHIYXQ6SXSzHdbL4Oj8b7M9GkBwRtIOEHeN3IkkgxvmuG5tth69d8SzIAqQDpvHd/DfsYx5QOijImyx5fSKHSSm4LpPITd0XfL0DAUC3lltDcvE2YSxyckK4SdPUdTVEfUMdSt+eVIOamxtTlq2skcq+VUkW3dJskyd7VAJ1KXRNg+zs0ByHAeS7TAP5MUc4LOQKn7dZ8Q7tB5NtyPHnQe0xvXQGpyVGsSTCpX/X1+Tce2M/WL/Le5UxrBA2I/869OfdHjOSKlh+VEaPSnIjJNSV8DeA95rZIYi1ZtPdoHH7Ow==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=un3rfBjBA+/TDycrQBT+tXIqPcY944i6C8CUpv3E6dE=;
 b=r/pe+lgcAsobXTqFuBLnhjO8unQCy/yPa5rh5LINW/IF5n3kR35f1aMl3WazmqOeqzIvKFnlUx+sGt+Eg/DyoFCm4NguUd1fNFqndhY1LSNbM0sezPtcmlx7A/VlNTQ3ZS9CTeLeSs11G1APO0q/hsrrMOZF3joxQsy32Iljrtg=
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
Content-Type: text/plain;
	charset=us-ascii
Subject: Re: [PATCH 3/5] xen/sched: retrieve scheduler id by name
From: Luca Fancellu <luca.fancellu@arm.com>
In-Reply-To: <5207b025-5b92-682e-5904-4e5014f76d7c@suse.com>
Date: Tue, 15 Feb 2022 17:52:48 +0000
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
 Wei Chen <wei.chen@arm.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Dario Faggioli <dfaggioli@suse.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 Jan Beulich <jbeulich@suse.com>,
 Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <0524AA92-FACD-4F24-BE0E-42B4AA8FA80E@arm.com>
References: <20220215101551.23101-1-luca.fancellu@arm.com>
 <20220215101551.23101-4-luca.fancellu@arm.com>
 <5207b025-5b92-682e-5904-4e5014f76d7c@suse.com>
To: Juergen Gross <jgross@suse.com>
X-Mailer: Apple Mail (2.3693.60.0.1.1)
X-ClientProxiedBy: LO4P123CA0295.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:196::12) To VI1PR0801MB2125.eurprd08.prod.outlook.com
 (2603:10a6:800:5b::23)
MIME-Version: 1.0
X-MS-Office365-Filtering-Correlation-Id: 0d13f9e7-8f3b-45ea-f8bd-08d9f0ac017e
X-MS-TrafficTypeDiagnostic:
	DB7PR08MB3467:EE_|DB5EUR03FT058:EE_|AM6PR08MB4657:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR08MB46574F242671DAD7AF5F3041E4349@AM6PR08MB4657.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 HvM9hoJrNkqpPTTDe+RJLmBzw1VXai4WJpH/0OtL4G64J191yV/dSCqahOHS5msQj1OzsNaiBbpoAHq7uqDRRETCS6dxOhYfSJnydHil9TXySO6K16566USRClhVfp95ybw28b449f5PRZ96L8uX6lrDIPKTqvpzalw5YIEanCr3yeG4RTrqae5/99SwKrwgj0M7/hLc6XcNxRJYZHzE0/BnELmFPGv18lecTII6N3krVneqWYL/0kue3mzau+OxP7BDx3ViHKnX8nIDCQls2HYAzazdA/Ui0b6Fv6+YQWLTC5F55Qkaj1YHuEN9/710sA+ou9+IxcJsk9HBXAXJfuVsqYx98u311GV7Pv7LetiGIevPm35up74Mq1YLP+QhTUyrCSATZqMQ+oq+PmWDtkU69ixd5Bs/5HDMco42TQsl1O29sd6S/tyEnXFupDIVxPGadlfOpGsesvJrOiH/dPqJ/gZdT3iGAVBYxLqV8k9jP7/OEbaGA4T+rfaKzS006TXzRa/AB4Fga/nK0zFKsd54SqFkBHW/MWoqcxykn8tLrbrkTBr/3LnpOy0Z6VDwPorev0PYGNfHWCycvLuRRWIsu8hNrDAExmBpoji/xj1ffkr9EAJ9VH0E773v+1PdLzq7PWIbiNSUdn6bbxnTc7uRvq0Up8dRP9+tRGi6CyiqsYC4q8rCHegowS+PKqQdn9X1M3PiZAek6XlXNI04s6ihjH/yY213teH1OfkAnlI=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR0801MB2125.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(186003)(6512007)(6506007)(6666004)(38100700002)(38350700002)(52116002)(53546011)(66476007)(66556008)(66946007)(2906002)(2616005)(26005)(8936002)(4326008)(36756003)(5660300002)(44832011)(8676002)(54906003)(508600001)(33656002)(6916009)(316002)(6486002)(86362001)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3467
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT058.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	bdf2c7ba-b52a-4f7a-cea5-08d9f0abfcd0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	3B+PnCcyetw3PzQO8llwZsJJNbJcFSuHYO7l3Pi38Ox/T6KMRmTUWgcqM5DpTtkVDS5IWyvrDX4cFXHjlR/rO8s0ZwH9YHtVu+9zbeP6f1+aTL52JqgAJOHWD+9BI2aiSHA1DMBZ3WB2zlvdsa1ASUlkDGxcaeKTuQdXAL+jKHmvFwVI9M32ce8lMEpo2YuGreJnS/wnehFCdFal5Y8liiv0IIqnURXeno3F47ZhAJlWqbNBp1xHoJqjsq6jKVNK8n2s5+DOVvvXlZVGn32eqJlpYcw453z9YpjBMnnQo+ma8Q4BOdgYI16E38MMFZSlon+uL4rq5UaoDimWsApxP6jWn6bWZ3Ng6UnpHNL7O56Cx1LIrBfkmqOvCbbyleXmabVMYQJOjBoD2fSj4KOo6FxCWCNaAwaSBy8h0hSN4aCr/Of2GEhgnVfu7n12/L5NKN8B2/M3Nd7lsxqp24Tw8ULktbkJdxTH+Z16gcMMFks5Epw0cKc4hGOFhlLOqrlNVgcHMMC/bouIoyM1CrvJAxeBHJLZ+oearfgo+HKhCEETcEHVSCB4ehCqfDVjr1g5EflVZiXB0wI96vf5CAiDxsPidMCuk6qvlK3/qiFmWPBpr/jNpJGa0zT2wzN+S3V43ue/smyrnuRu2SK5m1j1r1V2hY32xdOyrldo0v163XWuS7/h9NEKL7VnNshK2BPJ
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(336012)(8676002)(4326008)(44832011)(6862004)(36860700001)(6506007)(26005)(8936002)(36756003)(186003)(53546011)(6512007)(2616005)(81166007)(356005)(6666004)(86362001)(6486002)(33656002)(82310400004)(316002)(70206006)(47076005)(2906002)(70586007)(508600001)(40460700003)(5660300002)(54906003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 17:52:59.9775
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 0d13f9e7-8f3b-45ea-f8bd-08d9f0ac017e
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT058.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4657



> On 15 Feb 2022, at 10:40, Juergen Gross <jgross@suse.com> wrote:
>=20
> On 15.02.22 11:15, Luca Fancellu wrote:
>> Add a public function to retrieve the scheduler id by the scheduler
>> name.
>> Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
>> ---
>>  xen/common/sched/core.c | 11 +++++++++++
>>  xen/include/xen/sched.h | 11 +++++++++++
>>  2 files changed, 22 insertions(+)
>> diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c
>> index 8f4b1ca10d1c..9696d3c1d769 100644
>> --- a/xen/common/sched/core.c
>> +++ b/xen/common/sched/core.c
>> @@ -2947,6 +2947,17 @@ void scheduler_enable(void)
>>      scheduler_active =3D true;
>>  }
>>  +int __init sched_get_id_by_name(const char *sched_name)
>> +{
>> +    unsigned int i;
>> +
>> +    for ( i =3D 0; i < NUM_SCHEDULERS; i++ )
>> +        if ( schedulers[i] && !strcmp(schedulers[i]->opt_name, sched_na=
me) )
>> +            return schedulers[i]->sched_id;
>> +
>> +    return -1;
>> +}
>> +
>=20
> Please make use of this function in scheduler_init(), as this
> functionality is open coded there, too.
>=20

Ok I will change the code in scheduler_init to use the new function.

Cheers,
Luca

>=20
> Juergen
> <OpenPGP_0xB0DE9DD628BF132F.asc>



From xen-devel-bounces@lists.xenproject.org Tue Feb 15 17:57:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 17:57:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273509.468717 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nK24d-0004FL-Lr; Tue, 15 Feb 2022 17:57:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273509.468717; Tue, 15 Feb 2022 17:57:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nK24d-0004FE-Iq; Tue, 15 Feb 2022 17:57:11 +0000
Received: by outflank-mailman (input) for mailman id 273509;
 Tue, 15 Feb 2022 17:57:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=h622=S6=arm.com=Luca.Fancellu@srs-se1.protection.inumbo.net>)
 id 1nK24c-0004F8-5B
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 17:57:10 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on20613.outbound.protection.outlook.com
 [2a01:111:f400:7d00::613])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b177001e-8e88-11ec-b215-9bbe72dcb22c;
 Tue, 15 Feb 2022 18:57:09 +0100 (CET)
Received: from AS9PR05CA0034.eurprd05.prod.outlook.com (2603:10a6:20b:489::7)
 by PAXPR08MB6766.eurprd08.prod.outlook.com (2603:10a6:102:136::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.12; Tue, 15 Feb
 2022 17:57:05 +0000
Received: from AM5EUR03FT048.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:489:cafe::ae) by AS9PR05CA0034.outlook.office365.com
 (2603:10a6:20b:489::7) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.15 via Frontend
 Transport; Tue, 15 Feb 2022 17:57:05 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT048.mail.protection.outlook.com (10.152.17.177) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4975.11 via Frontend Transport; Tue, 15 Feb 2022 17:57:04 +0000
Received: ("Tessian outbound 826a6d8e58c3:v113");
 Tue, 15 Feb 2022 17:57:04 +0000
Received: from fcf553dbd6df.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 0DDA7614-D8BD-4B79-943E-D3899A7B94ED.1; 
 Tue, 15 Feb 2022 17:56:54 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id fcf553dbd6df.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 15 Feb 2022 17:56:54 +0000
Received: from VI1PR0801MB2125.eurprd08.prod.outlook.com
 (2603:10a6:800:5b::23) by VI1PR08MB3616.eurprd08.prod.outlook.com
 (2603:10a6:803:7f::16) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.18; Tue, 15 Feb
 2022 17:56:51 +0000
Received: from VI1PR0801MB2125.eurprd08.prod.outlook.com
 ([fe80::5531:4c33:a50c:ea0e]) by VI1PR0801MB2125.eurprd08.prod.outlook.com
 ([fe80::5531:4c33:a50c:ea0e%9]) with mapi id 15.20.4975.018; Tue, 15 Feb 2022
 17:56:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b177001e-8e88-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=zOQsaqlE5PeDQaANSbG7W5ZFK1FQeQi88BOq4vaUGwA=;
 b=XRgTNOZhExsOtZcgMbPQDw8nR5CXVxOBpuVUBo6Vchtpde7oxac2gxYE7n4MFD28i2gxqUkycjar3UQ8DgKQ6ri+eGDYXmwaap9GWdNhcYOvanZT/CYl7AIrqbR5wmXPaxuINIMOPmkLWA1zbmUUV+OGtZgdmK8RUn4CLzdnLlc=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 42b1c2db601cdfdd
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=JXMuLnKQ0tFABBCfy+H4doIqV6nvD1anuqRXpl3dghQNpIYDoTiVElpwqaEgUHfky9o0nPVr/UpGNSH1bH6K2f5m1VDjt4kMAdfu3eCF+F9C4KwUlt5IrEwMIbCpX5xd9I2ch1IbjBcd719FXrn/e8k4nPlyU1ngzxO0ovK5VuTSGByg570KOEyLQR+Y9CQL7A/rX43NDDMG2LrTT30LlhW+DiiS/w6yPSu47GnAvhLmU9FK7rjJkJae138Usiv5dFEtlP/7Elo0/4oL4PvBU6lKaTRIlwbUSDw9BFY2jTMvmMQLomojvSUlhUqu9AgJlRwlfnfSCze5KOhfM4Wkuw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=zOQsaqlE5PeDQaANSbG7W5ZFK1FQeQi88BOq4vaUGwA=;
 b=KQozMf3BisBcGUp2IJop7rkq4UK9prsYkHiapTXAAln+XxvoNENRA6GwGbYBxgf5Zh/MlcOs85CY5FnUXOFyhk8vf67nzQlz+/cPDP1+Y4fUdv8wwiUTbv1oQ5sU1CZMuEJCKRcJx6ezAcEOXqWeOZI9RFBSXlNzZUclbVgowlj5xP3Wim5ue0WLYgFlEVEsiLMTlfehYCIMbAgNXjHaW3cjufIUxuo6ixajTyTkOBeEJnKP+I5r4HlJ3j53E5ywEuuCIuCKHUwGHIbq4Qs8s1/IfVAKJeQxGtBvtNj5ABqaQrJ0hUxm+lqu2Z1Z5TJzYiKXsqWHNSScePQMe9MpBw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=zOQsaqlE5PeDQaANSbG7W5ZFK1FQeQi88BOq4vaUGwA=;
 b=XRgTNOZhExsOtZcgMbPQDw8nR5CXVxOBpuVUBo6Vchtpde7oxac2gxYE7n4MFD28i2gxqUkycjar3UQ8DgKQ6ri+eGDYXmwaap9GWdNhcYOvanZT/CYl7AIrqbR5wmXPaxuINIMOPmkLWA1zbmUUV+OGtZgdmK8RUn4CLzdnLlc=
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
Content-Type: text/plain;
	charset=us-ascii
Subject: Re: [PATCH 4/5] xen/cpupool: Create different cpupools at boot time
From: Luca Fancellu <luca.fancellu@arm.com>
In-Reply-To: <d6f36774-ecb5-15f4-b0c0-6114724060e6@suse.com>
Date: Tue, 15 Feb 2022 17:56:48 +0000
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
 Wei Chen <wei.chen@arm.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>,
 Dario Faggioli <dfaggioli@suse.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <AC1B6659-FDCF-49A0-AB6E-EF2196C46D8C@arm.com>
References: <20220215101551.23101-1-luca.fancellu@arm.com>
 <20220215101551.23101-5-luca.fancellu@arm.com>
 <d6f36774-ecb5-15f4-b0c0-6114724060e6@suse.com>
To: Juergen Gross <jgross@suse.com>
X-Mailer: Apple Mail (2.3693.60.0.1.1)
X-ClientProxiedBy: LO4P123CA0065.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:153::16) To VI1PR0801MB2125.eurprd08.prod.outlook.com
 (2603:10a6:800:5b::23)
MIME-Version: 1.0
X-MS-Office365-Filtering-Correlation-Id: 4d98638e-d69c-4259-10a7-08d9f0ac9387
X-MS-TrafficTypeDiagnostic:
	VI1PR08MB3616:EE_|AM5EUR03FT048:EE_|PAXPR08MB6766:EE_
X-Microsoft-Antispam-PRVS:
	<PAXPR08MB67664C0CA9EBD82506DF9AACE4349@PAXPR08MB6766.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 rDIpDnql1iaCd2bBOgTVtSBptuty0gVfuoUwFAfScG7FbqZToQb5v6OfkL6k6c8C4BsgWHmYR9dha6fNmlDiGoZBSTVmZM6decAaElAOqoet2TKsgm/bDONODHIvXtlNbgHRR97sOnxk7vFBp+al4Vn/i7YuhLhdJFSIhlYF82EUG0dNEB1opjPuqmAVL0xk55+2/W7CElRReVmXQBUpzkPIdr4ylIZTkwd1JdT8NI6NmFuBQRXxjonuaOI2pqtcX+nh/+SVQltREbDEscb+rmXK80QZrqsURKRoTiQ7gVVdL8VnYBRrtwcnQrVGmobfzrGyBhm/X/oge9ko9aIszJdNyICFnR6NFfoi7HCrOSMT6X1gg/raEcTlWxuxriMkbuZx2g3jpJgnaVZVWZZQofZOpik1/O5Tp1OBIlGT5Iez9TTpRwo85xloszEuXP7ZoX5YseJ3g/BuLZNvtWX/o2m7yZZWhfFh8wYAwLB09ZAeHweyVSKNFXr+a2AdiIkfgUbKTrQuYpZcRLm0RgsmLfWB2odwhac6uoBP/cZ1Ko+yCISohCRqaqUew6b8svhfNo9oCzhcnIfCg6UQ2VddBDJaTRjGtiHHQvkhTWN+Ug9chdF/1WcZukLRg1ZI84E9m5g4eSMr4zB0ic9B7Shg+i6BYyk0nclwNrD+k8h0hQWmOwD9H52YaMGrM0c1vTPsQ8KdiNOiTxc7KQ798G5fcp/7+0lPKDLGRvaYUAk7go4=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR0801MB2125.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66946007)(26005)(66556008)(86362001)(83380400001)(66476007)(186003)(38100700002)(38350700002)(54906003)(6916009)(33656002)(6666004)(53546011)(6512007)(6506007)(52116002)(2906002)(2616005)(36756003)(8676002)(4326008)(8936002)(508600001)(6486002)(44832011)(5660300002)(316002)(7416002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3616
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT048.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	20f4ecef-53b7-43cd-3c20-08d9f0ac8b11
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	SxMbLs/c0H7xdtRRQCcwNhDO3GF2MSRtOzDgJ8afiOP6qr82S4IBTLHWrrnM9qi23z8upvP3Mf+Bjrz3qa6dUvHuJlj+43SB2/0O15JByS+6zf++apQcbq+UNqXmO09+PAIhV33o3L1/y9vLcAIqonlleus3VPVr1su7v+v7iQ65PPmHDS8Kcala1k/M1VuSI964pdaK6O9EwduMyLS8L7Cf6LkHq7ONxguCvuLZKobqU9CG76nqKZxjOMW3166T81Xcv/CAV8uxPzXlkDbkRH9rp/lU/nMShtUesxDYDiUuc1sXP+VkNXeavePA0AioCkglRNOZy5Jmc7Z1aR99tiUNh76M1Xaa9TU/05HTZxOy9JBGNbZBa+TmFnsEkJ5/XxNF7GXiTQt93D6treeHdXTEwIsRmUKNpxp2aaEPive6Me4/ukMjh8DPGSDozQ+3oCAY1p5p4qD535IGqHBQ5gE6vv5PC1XE0d5i5qkyFMqpGrQWRiwb/JuKxCo/iXUqQZ+9yu6nhKtGojd1v4DDypreO3PX0mXlntDczqFsAxi8Wlb1ja3yGsDlpd1O8BJHZxs0FxGqKD2FCTV6zH84MC/jjwJ8MeGsVPdzyLyIbiUY/FBrhQ+ucVzjGyuNC1B7YQP8gMnCZbhUlAd1QJKG2QLwAHBQzquWgsHr1zfrvEYDGRElxydWjLh9S3VaT4Vo
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(508600001)(6486002)(82310400004)(54906003)(6506007)(8936002)(53546011)(70586007)(316002)(86362001)(6666004)(70206006)(47076005)(4326008)(6862004)(8676002)(33656002)(83380400001)(107886003)(36860700001)(2616005)(6512007)(81166007)(26005)(356005)(186003)(336012)(40460700003)(5660300002)(2906002)(36756003)(44832011);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 17:57:04.9245
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 4d98638e-d69c-4259-10a7-08d9f0ac9387
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT048.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6766



> On 15 Feb 2022, at 10:48, Juergen Gross <jgross@suse.com> wrote:
>=20
> On 15.02.22 11:15, Luca Fancellu wrote:
>> Introduce an architecture specific way to create different cpupools
>> at boot time, this is particularly useful on ARM big.LITTLE system
>> where there might be the need to have different cpupools for each type
>> of core, but also systems using NUMA can have different cpu pools for
>> each node.
>> The feature on arm relies on a specification of the cpupools from the
>> device tree to build pools and assign cpus to them.
>> Documentation is created to explain the feature.
>> Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
>=20
> IIRC I suggested to have the core functionality in common code in order
> to allow using boot time cpupool creation e.g. via commandline for x86,
> too.

Yes, however I think the parser to handle everything by command line would
be huge due to input sanitisation and not easy enough as the DT, however
I see Hyperlaunch has plans to use DT on x86 so I guess it would be ok to m=
ake
this feature common once the DT is available also on x86.

Cheers,
Luca

>=20
>=20
> Juergen
> <OpenPGP_0xB0DE9DD628BF132F.asc>



From xen-devel-bounces@lists.xenproject.org Tue Feb 15 18:07:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 18:07:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273516.468728 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nK2Eu-0005nD-Na; Tue, 15 Feb 2022 18:07:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273516.468728; Tue, 15 Feb 2022 18:07:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nK2Eu-0005n6-KO; Tue, 15 Feb 2022 18:07:48 +0000
Received: by outflank-mailman (input) for mailman id 273516;
 Tue, 15 Feb 2022 18:07:47 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=h622=S6=arm.com=Luca.Fancellu@srs-se1.protection.inumbo.net>)
 id 1nK2Et-0005n0-0r
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 18:07:47 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04on0615.outbound.protection.outlook.com
 [2a01:111:f400:fe0d::615])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2c802dbe-8e8a-11ec-b215-9bbe72dcb22c;
 Tue, 15 Feb 2022 19:07:45 +0100 (CET)
Received: from DB6PR0601CA0043.eurprd06.prod.outlook.com (2603:10a6:4:17::29)
 by AM0PR08MB3313.eurprd08.prod.outlook.com (2603:10a6:208:5b::28)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Tue, 15 Feb
 2022 18:07:42 +0000
Received: from DB5EUR03FT028.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:4:17:cafe::55) by DB6PR0601CA0043.outlook.office365.com
 (2603:10a6:4:17::29) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.14 via Frontend
 Transport; Tue, 15 Feb 2022 18:07:42 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT028.mail.protection.outlook.com (10.152.20.99) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4975.11 via Frontend Transport; Tue, 15 Feb 2022 18:07:42 +0000
Received: ("Tessian outbound 18e50a6f0513:v113");
 Tue, 15 Feb 2022 18:07:42 +0000
Received: from 4766961b5fc3.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 E78D100C-7772-4F25-AB0C-4DF61E4E8629.1; 
 Tue, 15 Feb 2022 18:07:35 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 4766961b5fc3.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 15 Feb 2022 18:07:35 +0000
Received: from VI1PR0801MB2125.eurprd08.prod.outlook.com
 (2603:10a6:800:5b::23) by DB8PR08MB5401.eurprd08.prod.outlook.com
 (2603:10a6:10:f9::13) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.14; Tue, 15 Feb
 2022 18:07:04 +0000
Received: from VI1PR0801MB2125.eurprd08.prod.outlook.com
 ([fe80::5531:4c33:a50c:ea0e]) by VI1PR0801MB2125.eurprd08.prod.outlook.com
 ([fe80::5531:4c33:a50c:ea0e%9]) with mapi id 15.20.4975.018; Tue, 15 Feb 2022
 18:07:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2c802dbe-8e8a-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=szVxqRYqApVF4U9mQMR3Hj8x4A4y+hkIF5dfR//gidc=;
 b=2N3FQwLGts9kaQCzkmK+fLUYqRI8HHcXs4fS0+HIAEuwgEdE1Vcc6l/tjUCLytJeUkivyTcePvbYlwVy7jxcb0b94MFLcVczdv76lP0rOIG1iJzru2W1/2M8l6TrTYC2sGVAB7/njOCjiDW6QzOoHHlyVvNHVa0vPtcaEg8qpjI=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: ca4dd0c44a9648d1
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=WzxnvNHfRjF5KzRj599BAEfIO3tdpfO39vERQCU6YC42FuFekt6eWdkHyNUAW5+3LLknXv8IbwlCFEepqXrvDenIvYZRs3tPF1dNqpgshXMt3Z2dGbbZG1xOUDqH2n+3ekyXaDKUvTJQvkzMfA0c3UViH4M0L+1yRS93xe+FuYkHL56zN1tg+vTBAp/tYhW+3qoWUsPU7yp/x6DZ9NbkUTJMi0zm59PPajrF8YH61JHSkWp1ejN+sE8V2HNyLTL8aqx9oZXvyVAPmTTGiLZH8ifHqgOOpiBW9obGHWqEE10ukVnGTtTd+h+Fj48TOO/RpNy/+F6HxE1KMSVm0U1w0w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=szVxqRYqApVF4U9mQMR3Hj8x4A4y+hkIF5dfR//gidc=;
 b=bfN+EKoSTl1mvfBR9TdG7Rl1sj6X8CLFxE4kSCA5ahokln8QzeYIVEZZcHf21Z51PknwYcH5NLbnDWTWrSgpInNq5UTkQgy8p0rXIJRldVVuc+g4VbagCZfbjX5cLcS+2UyeRXr0y2x9Y6yDEQDiFl/CtucXJeCpOWQOtbVBi0wU5lx3XhJvyCRYguvmIQLqZ5lxegdoWA/xgliw0NossdvVPsb03gP9ftnbIPOzWaDBU6x8Wt0Y1dDSSrBQBQQKacvcfVVNr4L/H/i5p8AtpSZVv2sGQiLmcwGFBeZH8tHX+HhSdM25VifOxkefWo7pdGn8yZqcnIpYXxbgDjLo9w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=szVxqRYqApVF4U9mQMR3Hj8x4A4y+hkIF5dfR//gidc=;
 b=2N3FQwLGts9kaQCzkmK+fLUYqRI8HHcXs4fS0+HIAEuwgEdE1Vcc6l/tjUCLytJeUkivyTcePvbYlwVy7jxcb0b94MFLcVczdv76lP0rOIG1iJzru2W1/2M8l6TrTYC2sGVAB7/njOCjiDW6QzOoHHlyVvNHVa0vPtcaEg8qpjI=
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
Content-Type: text/plain;
	charset=utf-8
Subject: Re: [PATCH 5/5] arm/dom0less: assign dom0less guests to cpupools
From: Luca Fancellu <luca.fancellu@arm.com>
In-Reply-To: <812858d6-3f39-87ed-b495-a15d34f6e930@suse.com>
Date: Tue, 15 Feb 2022 18:06:58 +0000
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
 Wei Chen <wei.chen@arm.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>,
 =?utf-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <C5131247-1F1D-49EB-8D4C-CD7998479ACC@arm.com>
References: <20220215101551.23101-1-luca.fancellu@arm.com>
 <20220215101551.23101-6-luca.fancellu@arm.com>
 <812858d6-3f39-87ed-b495-a15d34f6e930@suse.com>
To: Juergen Gross <jgross@suse.com>
X-Mailer: Apple Mail (2.3693.60.0.1.1)
X-ClientProxiedBy: LO2P265CA0031.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:61::19) To VI1PR0801MB2125.eurprd08.prod.outlook.com
 (2603:10a6:800:5b::23)
MIME-Version: 1.0
X-MS-Office365-Filtering-Correlation-Id: 310c6a3e-60e8-4f26-5b38-08d9f0ae0f52
X-MS-TrafficTypeDiagnostic:
	DB8PR08MB5401:EE_|DB5EUR03FT028:EE_|AM0PR08MB3313:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR08MB3313903E0B475F0ECB1E6799E4349@AM0PR08MB3313.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:3173;OLM:3173;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 ELSmZz6PsE4xRxAuK5m59YAYWPu0p0vhySebPOwjV5n5RneNYFlCVC8sbtRhgL1zg6BxYeMh9nqtqPQSuarc44CisSyLkA7f84593GB8XhG5qVvqn5wA7Xo656mG4PTdf1peqXIqTcnS17a0PU6omOh/X/fKvXUljfCsHE5ybXbSvBjuZkkMeRkbSpD+Gtlfa3n3KhGw0Txrhre4SwQF1wJYrzEQp5bg3w3zk4Zlhnsy1I1dpz351lf8Zg3o8tahRkvnB8IaK1GOpwlKrdtzNn0LVyGbpGnkDXmguXWhyNXl3OREPClw+JlqAn/uK0G0x9uQe0weTaHOvTA2Y3qLI4pn0uNT398sDn43KLME9ZRF7wBdHhqCKFqSIcucUKiy2vwvrCj7nm2iwNy0lucEYwLeWZUHjK3C10cxQIe4XzmHkLpwQ4HolVr5nz1chflxBWhdl30IwzLK8En4+OyTw9Uf6LL1GmoQE4jU0K18hrUvMSOTzlqdRjmFRi9DKzlm2jaq9zE6C78L/xYd7Mjbebf7Gr8g7WvyLdU03Go48qeuca6UXwE0CuI18wn7Px4ZNlEO44PFLmoTJR7JzhRQ3Tm38lG/0QxlWRaiT2cTk3E1aJ/jrV8xgfhKRy/MQDPHxfdU447S2xgOt5QawHdBfvynMFDhPcGnrLNeXNnQPT68gcCUZ2pHThZ83tTmRwaJNLzJo3nWiXRzqi71U+HRCNNP6MoCZ7manRlYtOo/0EUZS7/Vvh1Icn+I3FPUYpbzJVfzPXF/ck6xgd/36XvLVw==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR0801MB2125.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(83380400001)(6512007)(6506007)(6666004)(52116002)(508600001)(36756003)(53546011)(44832011)(33656002)(2906002)(5660300002)(7416002)(8936002)(4326008)(8676002)(316002)(66946007)(66556008)(66476007)(54906003)(6486002)(2616005)(26005)(186003)(86362001)(6916009)(38100700002)(38350700002)(32563001)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5401
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT028.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	bc533a3c-db61-4e1a-fe82-08d9f0adf868
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Dxm9MLjeN6VtO+lfRF/SF5RjhrI4eLP+1LGHYDQZKyyRTtUS4QPdjBoA1LbAEiuXZIsHDdYOE/B7Du9TmhSXIbb+wlKJZDrzezdH7F0H2ciHYGaaX5KeFHYZFVmT4se7/yUVEuFXB2nII7RDSkOuYAmeROko+0J2HXEs7OQcNLegn4stTgDF9ec6rmuqn2xt3OkxXj1LbTx58dZu9kcJ+DK5UBHWk7o7vn13AG1u7XIogIhXFS9xPHUsysedMgCtbzvASwuDHv+6mYtChEGKjdkVwHKCIrmNZo07cNUJewxxTsmvXh3KktVfdTpUtJbxyAowdYgtq9xJfj5dnY/yHhXIfd5TOxsSq/zbWF51ciAc/C8WkU496MxebQWNOBrKiHk6QYG8hwp/+m0Ul9oyyl995zFCnQsG9seLTHwhFvtBRH+saqqn0L0+fhH7uJxpz1LWUYdOMkAoPdTD6fEkGjBvBwAcR8MPV7n784beZNoU4LCfrgysYzl3Pzzy8zkDbAzGz5Q9HO2HtH388AfO7gPMPaUfDRSCcivyogMMD2FIKiYmnd5xpS3y2niYtbFEdf6uC/tQJTNTFnJ/nl5xG/+nqVfuFFzBJ0Ko0cXT0iE+lQzE/wIpOrVgmF5TZRL8rPWpR7Xy3aRvKsGlxQn3lgD9NxHrn7RQo0T4DtiJvBCTe2KiP6lptuSuRPmIgBDisWoglJjcu5RLZfqJtrWO2Q==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(5660300002)(8936002)(70586007)(82310400004)(44832011)(2906002)(6862004)(26005)(70206006)(356005)(81166007)(40460700003)(4326008)(107886003)(186003)(86362001)(8676002)(6506007)(53546011)(336012)(508600001)(6512007)(6486002)(6666004)(36860700001)(2616005)(47076005)(83380400001)(33656002)(36756003)(54906003)(316002)(32563001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 18:07:42.1587
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 310c6a3e-60e8-4f26-5b38-08d9f0ae0f52
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT028.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3313



> On 15 Feb 2022, at 10:56, Juergen Gross <jgross@suse.com> wrote:
>=20
> On 15.02.22 11:15, Luca Fancellu wrote:
>> Introduce domain-cpupool property of a xen,domain device tree node,
>> that specifies the cpupool device tree handle of a xen,cpupool node
>> that identifies a cpupool created at boot time where the guest will
>> be assigned on creation.
>> Add member to the xen_arch_domainconfig public interface so the
>> XEN_DOMCTL_INTERFACE_VERSION version is bumped.
>> Update documentation about the property.
>> Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
>> ---
>>  docs/misc/arm/device-tree/booting.txt | 5 +++++
>>  xen/arch/arm/domain.c                 | 6 ++++++
>>  xen/arch/arm/domain_build.c           | 9 ++++++++-
>>  xen/arch/x86/domain.c                 | 6 ++++++
>>  xen/common/domain.c                   | 5 ++++-
>>  xen/include/public/arch-arm.h         | 2 ++
>>  xen/include/public/domctl.h           | 2 +-
>>  xen/include/xen/domain.h              | 3 +++
>>  8 files changed, 35 insertions(+), 3 deletions(-)
>> diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/devic=
e-tree/booting.txt
>> index 71895663a4de..0f1f210fa449 100644
>> --- a/docs/misc/arm/device-tree/booting.txt
>> +++ b/docs/misc/arm/device-tree/booting.txt
>> @@ -182,6 +182,11 @@ with the following properties:
>>      Both #address-cells and #size-cells need to be specified because
>>      both sub-nodes (described shortly) have reg properties.
>>  +- domain-cpupool
>> +
>> +    Optional. Handle to a xen,cpupool device tree node that identifies =
the
>> +    cpupool where the guest will be started at boot.
>> +
>>  Under the "xen,domain" compatible node, one or more sub-nodes are prese=
nt
>>  for the DomU kernel and ramdisk.
>>  diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
>> index 92a6c509e5c5..be350b28b588 100644
>> --- a/xen/arch/arm/domain.c
>> +++ b/xen/arch/arm/domain.c
>> @@ -788,6 +788,12 @@ fail:
>>      return rc;
>>  }
>>  +unsigned int
>> +arch_get_domain_cpupool_id(const struct xen_domctl_createdomain *config=
)
>> +{
>> +    return config->arch.cpupool_id;
>> +}
>> +
>=20
> I don't see why this should be arch specific.
>=20
>>  void arch_domain_destroy(struct domain *d)
>>  {
>>      /* IOMMU page table is shared with P2M, always call
>> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
>> index 6931c022a2e8..4f239e756775 100644
>> --- a/xen/arch/arm/domain_build.c
>> +++ b/xen/arch/arm/domain_build.c
>> @@ -3015,7 +3015,8 @@ static int __init construct_domU(struct domain *d,
>>  void __init create_domUs(void)
>>  {
>>      struct dt_device_node *node;
>> -    const struct dt_device_node *chosen =3D dt_find_node_by_path("/chos=
en");
>> +    const struct dt_device_node *cpupool_node,
>> +                                *chosen =3D dt_find_node_by_path("/chos=
en");
>>        BUG_ON(chosen =3D=3D NULL);
>>      dt_for_each_child_node(chosen, node)
>> @@ -3053,6 +3054,12 @@ void __init create_domUs(void)
>>                                           GUEST_VPL011_SPI - 32 + 1);
>>          }
>>  +        /* Get the optional property domain-cpupool */
>> +        cpupool_node =3D dt_parse_phandle(node, "domain-cpupool", 0);
>> +        if ( cpupool_node )
>> +            dt_property_read_u32(cpupool_node, "cpupool-id",
>> +                                 &d_cfg.arch.cpupool_id);
>> +
>>          /*
>>           * The variable max_init_domid is initialized with zero, so her=
e it's
>>           * very important to use the pre-increment operator to call
>> diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c
>> index ef1812dc1402..3e3cf88c9c82 100644
>> --- a/xen/arch/x86/domain.c
>> +++ b/xen/arch/x86/domain.c
>> @@ -880,6 +880,12 @@ int arch_domain_create(struct domain *d,
>>      return rc;
>>  }
>>  +unsigned int
>> +arch_get_domain_cpupool_id(const struct xen_domctl_createdomain *config=
)
>> +{
>> +    return 0;
>> +}
>> +
>>  void arch_domain_destroy(struct domain *d)
>>  {
>>      if ( is_hvm_domain(d) )
>> diff --git a/xen/common/domain.c b/xen/common/domain.c
>> index 2048ebad86ff..d42ca8292025 100644
>> --- a/xen/common/domain.c
>> +++ b/xen/common/domain.c
>> @@ -665,6 +665,8 @@ struct domain *domain_create(domid_t domid,
>>        if ( !is_idle_domain(d) )
>>      {
>> +        unsigned int domain_cpupool_id;
>> +
>>          watchdog_domain_init(d);
>>          init_status |=3D INIT_watchdog;
>>  @@ -698,7 +700,8 @@ struct domain *domain_create(domid_t domid,
>>          if ( !d->pbuf )
>>              goto fail;
>>  -        if ( (err =3D sched_init_domain(d, 0)) !=3D 0 )
>> +        domain_cpupool_id =3D arch_get_domain_cpupool_id(config);
>> +        if ( (err =3D sched_init_domain(d, domain_cpupool_id)) !=3D 0 )
>>              goto fail;
>>            if ( (err =3D late_hwdom_init(d)) !=3D 0 )
>> diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm=
.h
>> index 94b31511ddea..2c5d1ea7f01a 100644
>> --- a/xen/include/public/arch-arm.h
>> +++ b/xen/include/public/arch-arm.h
>> @@ -321,6 +321,8 @@ struct xen_arch_domainconfig {
>>      uint16_t tee_type;
>>      /* IN */
>>      uint32_t nr_spis;
>> +    /* IN */
>> +    unsigned int cpupool_id;
>=20
> As said above: why is this arch specific? Moving it to the common part
> would enable libxl to get rid of having to call xc_cpupool_movedomain()
> in libxl__domain_make().

I=E2=80=99ve put it in arch because it=E2=80=99s only modified by the arm c=
ode, but if you think it=E2=80=99s ok
to have it in struct xen_domctl_createdomain, I don=E2=80=99t see any probl=
em.
My knowledge of the tool stack is limited so I didn=E2=80=99t know about th=
e advantages
of that change.

Cheers,
Luca

>=20
>=20
> Juergen
> <OpenPGP_0xB0DE9DD628BF132F.asc>



From xen-devel-bounces@lists.xenproject.org Tue Feb 15 20:17:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 20:17:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273524.468739 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nK4Gc-00013W-TI; Tue, 15 Feb 2022 20:17:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273524.468739; Tue, 15 Feb 2022 20:17:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nK4Gc-00013P-QE; Tue, 15 Feb 2022 20:17:42 +0000
Received: by outflank-mailman (input) for mailman id 273524;
 Tue, 15 Feb 2022 20:17:40 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nK4Ga-00013J-Ty
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 20:17:40 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nK4GZ-0001El-9s; Tue, 15 Feb 2022 20:17:39 +0000
Received: from 54-240-197-239.amazon.com ([54.240.197.239] helo=[192.168.8.20])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nK4GZ-00021x-3k; Tue, 15 Feb 2022 20:17:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=9N5imJ55gGsuTyovq9DWqwClbgwPfB989+Wb4aEu9JQ=; b=4NWs/oh3m3E1CL1Hi2+IuclITv
	m6kn7uhXPUMWjoi3Bsik2Az9l1V8QPqUUeo+tqeJ41S3c6MXfnjQtTq6otWIErUj/lDF3GzVmGyRA
	ntgWViXnV78UIeh8dDnj7ch7BdF7wN8I5SkhL2anf7CUxyUG9S6Ph+uXFuHEBc447FEM=;
Message-ID: <eb1a58a9-aa72-7d94-a0f3-912dc58e874b@xen.org>
Date: Tue, 15 Feb 2022 20:17:37 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.0
Subject: Re: [PATCH] MAINTAINERS: make Bertrand ARM maintainer
To: Stefano Stabellini <sstabellini@kernel.org>, bertrand.marquis@arm.com
Cc: xen-devel@lists.xenproject.org, Volodymyr_Babchuk@epam.com
References: <alpine.DEB.2.22.394.2202101026360.2091381@ubuntu-linux-20-04-desktop>
From: Julien Grall <julien@xen.org>
In-Reply-To: <alpine.DEB.2.22.394.2202101026360.2091381@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 10/02/2022 19:08, Stefano Stabellini wrote:
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>

Acked-by: Julien Grall <julien@xen.org>

The proposal has been for a few days on the ML without any objection. So 
I will commit it now.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Feb 15 20:26:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 20:26:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273534.468753 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nK4P1-0002cC-Tk; Tue, 15 Feb 2022 20:26:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273534.468753; Tue, 15 Feb 2022 20:26:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nK4P1-0002c5-Ql; Tue, 15 Feb 2022 20:26:23 +0000
Received: by outflank-mailman (input) for mailman id 273534;
 Tue, 15 Feb 2022 20:26:23 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nK4P1-0002bz-8o
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 20:26:23 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nK4P0-0001Qo-UT; Tue, 15 Feb 2022 20:26:22 +0000
Received: from 54-240-197-239.amazon.com ([54.240.197.239] helo=[192.168.8.20])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nK4P0-0002eG-Nw; Tue, 15 Feb 2022 20:26:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=45qqZ7TZpVqK1QT+pjY95BXBg9uA6c0PKxyP5am+zEU=; b=jcHWJKNOhGmLs0waCnsLdAqDNx
	X7+pX3I5eKzUNfjsz23cswS7eD1deC+N9ySUFv4zYzC8f5W+M6E1ysM4s0Vj3rsvtSLgFEgm61RXK
	VcrgBQr6JBSDSF674Ra8f9SFZZTpqkfhL86/rSRnoW52+76hB7a+mO5GShKrfQSgRVG8=;
Message-ID: <eb39c5a6-f5b1-ccf3-8d2b-802ae7da68d0@xen.org>
Date: Tue, 15 Feb 2022 20:26:20 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.0
Subject: Re: [PATCH v6 02/11] xen: introduce CDF_directmap
To: Penny Zheng <penny.zheng@arm.com>, xen-devel@lists.xenproject.org,
 sstabellini@kernel.org
Cc: Bertrand.Marquis@arm.com, Wei.Chen@arm.com,
 Jan Beulich <jbeulich@suse.com>
References: <20220214031956.3726764-1-penny.zheng@arm.com>
 <20220214031956.3726764-3-penny.zheng@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220214031956.3726764-3-penny.zheng@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

(+ Jan)

Hi Penny,

I am CCing Jan to give him a chance to...

On 14/02/2022 03:19, Penny Zheng wrote:
> diff --git a/xen/include/xen/domain.h b/xen/include/xen/domain.h
> index cfb0b47f13..24eb4cc7d3 100644
> --- a/xen/include/xen/domain.h
> +++ b/xen/include/xen/domain.h
> @@ -31,6 +31,10 @@ void arch_get_domain_info(const struct domain *d,
>   /* CDF_* constant. Internal flags for domain creation. */
>   /* Is this a privileged domain? */
>   #define CDF_privileged           (1U << 0)
> +#ifdef CONFIG_ARM
> +/* Should domain memory be directly mapped? */
> +#define CDF_directmap            (1U << 1)
> +#endif

... comment on this approach. I would be happy to switch to an ASSERT() 
if that's preferred.

Please note that as you modify x86 code (even it is a couple of lines) 
you should technically CC the x86 maintainers. Similarly the changes in 
include/xen/domain.h should have the REST CCed.

We have a script that will find the proper correct CC for each patch 
(see scripts/add_maintainers.pl). The workflow is written down in the 
script itself.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Feb 15 20:27:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 20:27:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273540.468765 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nK4Pe-00037A-7W; Tue, 15 Feb 2022 20:27:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273540.468765; Tue, 15 Feb 2022 20:27:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nK4Pe-000373-3r; Tue, 15 Feb 2022 20:27:02 +0000
Received: by outflank-mailman (input) for mailman id 273540;
 Tue, 15 Feb 2022 20:27:01 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nK4Pd-00036t-4s
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 20:27:01 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nK4Pd-0001RP-1Q; Tue, 15 Feb 2022 20:27:01 +0000
Received: from 54-240-197-231.amazon.com ([54.240.197.231] helo=[192.168.8.20])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nK4Pc-0002f3-SQ; Tue, 15 Feb 2022 20:27:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=oqfpihFNn+BLrt42di9PuxzkmDDvafbpeo3tQfeK3QA=; b=aLiYcwoz7afy7Y4Tlcq52yv++X
	Y6fqNdUZRh+/WtwqauBvpCGpBpI1GC5bwe4nE7PShQT61y9/T+Hb6ykyXlgKhcC8RbvJzVi2mLW42
	35jcoj3+Tb+TtI8bTAeivrCJ8rfTtR+mU6+UvnsCCaYOMfch18t9Bg6BC/FGCbVolhJ0=;
Message-ID: <1df77480-bb6b-4ac8-dfa2-f167bce51ffb@xen.org>
Date: Tue, 15 Feb 2022 20:26:59 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.0
Subject: Re: [PATCH v6 03/11] xen/arm: Allow device-passthrough even the IOMMU
 is off
To: Penny Zheng <penny.zheng@arm.com>, xen-devel@lists.xenproject.org,
 sstabellini@kernel.org
Cc: Bertrand.Marquis@arm.com, Wei.Chen@arm.com
References: <20220214031956.3726764-1-penny.zheng@arm.com>
 <20220214031956.3726764-4-penny.zheng@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220214031956.3726764-4-penny.zheng@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 14/02/2022 03:19, Penny Zheng wrote:
> From: Stefano Stabellini <sstabellini@kernel.org>
> 
> At the moment, we are only supporting device-passthrough when Xen has
> enabled the IOMMU. There are some use cases where it is not possible to
> use the IOMMU (e.g. doesn't exist, hardware limitation, performance) yet
> it would be OK to assign a device to trusted domain so long they are
> direct-mapped or the device doesn't do DMA.
> 
> Note that when the IOMMU is disabled, it will be necessary to add
> xen,force-assign-without-iommu for every device that needs to be assigned.
> 
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
> Signed-off-by: Penny Zheng <penny.zheng@arm.com>
> Tested-by: Stefano Stabellini <sstabellini@kernel.org>

Acked-by: Julien Grall <jgrall@amazon.com>

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Feb 15 20:41:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 20:41:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273548.468775 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nK4dD-0005SB-FC; Tue, 15 Feb 2022 20:41:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273548.468775; Tue, 15 Feb 2022 20:41:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nK4dD-0005S4-CJ; Tue, 15 Feb 2022 20:41:03 +0000
Received: by outflank-mailman (input) for mailman id 273548;
 Tue, 15 Feb 2022 20:41:02 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nK4dC-0005Ry-5w
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 20:41:02 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nK4dB-0001g1-LZ; Tue, 15 Feb 2022 20:41:01 +0000
Received: from 54-240-197-231.amazon.com ([54.240.197.231] helo=[192.168.8.20])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nK4dB-0003c9-FT; Tue, 15 Feb 2022 20:41:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=neE5Po6dmyyh3tBfWfFJ6iGtraldi78Vot66mEQEMC0=; b=LuV5qMexY28ChRPBh5Z+24cbuN
	p2XTyJOjYuduXp7mxPRHXOJvOJEhGBxM1EyX1b7D41P23fmXoI1RohG0Z0KQlH6wDAnF8sDf2PHDs
	Ag2MOnE7IMdJxGZrlGULuXISzqG4al7dhh6yEVokkuk7y/gYJl0F5y6kQ8JL0a5m4zq4=;
Message-ID: <6dd022ea-192b-3a5b-e02c-2368e769339f@xen.org>
Date: Tue, 15 Feb 2022 20:40:59 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.0
Subject: Re: [PATCH] docs: add some clarification to xenstore-migration.md
To: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
References: <20220210112652.6237-1-jgross@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220210112652.6237-1-jgross@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Juergen,

On 10/02/2022 11:26, Juergen Gross wrote:
> The Xenstore migration document is missing the specification that a
> node record must be preceded by the record of its parent node in case
> of live update.
> 
> Add that missing part.
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>
> ---
>   docs/designs/xenstore-migration.md | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/docs/designs/xenstore-migration.md b/docs/designs/xenstore-migration.md
> index 5f1155273e..39e31c984b 100644
> --- a/docs/designs/xenstore-migration.md
> +++ b/docs/designs/xenstore-migration.md
> @@ -316,6 +316,10 @@ a _committed_ node (globally visible in xenstored) or a _pending_ node (created
>   or modified by a transaction for which there is also a `TRANSACTION_DATA`
>   record previously present).
>   
> +In the live update case the _committed_ nodes must be in a top-down sequence,
> +i.e. the first node needs to be `/`, and each other node in the stream must
> +come _after_ its parent node.

I would actually expect the same restriction to apply for the 
non-liveupdate case. I.e. we want the parent to either exist in the tree 
or the record for the parent to be before in the stream.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Feb 15 20:58:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 20:58:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273555.468787 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nK4uN-0006zI-RP; Tue, 15 Feb 2022 20:58:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273555.468787; Tue, 15 Feb 2022 20:58:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nK4uN-0006zB-O5; Tue, 15 Feb 2022 20:58:47 +0000
Received: by outflank-mailman (input) for mailman id 273555;
 Tue, 15 Feb 2022 20:58:46 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=zJqs=S6=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nK4uM-0006z4-CX
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 20:58:46 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0ee1650f-8ea2-11ec-8eb8-a37418f5ba1a;
 Tue, 15 Feb 2022 21:58:45 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0ee1650f-8ea2-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644958724;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=JPLHhX/RZu03sGePa0Ovma9LHYxY/o3Uv7lyFhJwVGQ=;
  b=JKrKCEZGJD2LxJpK3nRH2AdaIXq/T4MjBI5XVtkYA6Qb5HkZGVqp4Dpb
   ggZBJa5Ur7et/cyl7uSoC6B7J7WHfFV5YEYa5TX7jug3I1Qh+dzOVWQKX
   kLlvrUhCiW5Cx2PtPoE+wzG2mGiAdOnwJtON0peQNpOfouBphi2sQZjl/
   E=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: /E+DLJP+dXdSXnT/XFxJJlg//GILZamp2G6f6L3LqSV/+x3BRKeF+3wESIy/DK5aPs+5n+21Hr
 o6RJntDgGiVJSgpTOctBl6AkxivQ0QYqslGiPGNJ1N1wURBu6YbQWX0gTeYMtbtD1HQYITfsvp
 WtX4FU/pCV4oQiOr+Wz3khbxSAjtdahrtI3Rz4Hz7poXDAkSkSxufNG6rl+NxgGONGJcTjuy/l
 DifcRFXKsrsHEH3dmritHKUKuNHoE2WXabTE7HXOtjcUvzVD4DQZYHsqgS45gdsEmgXRwovPA6
 2v1nbqAtvlVPGlnUS15AAWfD
X-SBRS: 5.1
X-MesageID: 63729172
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:BOpC1KjeeUIdbUp5AxbNWfnDX161thcKZh0ujC45NGQN5FlHY01je
 htvWTiGM6zcajbzKI1wYYq0/B8CusXcytZqHVc5rX1mH3sb9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oAMKRCQ7InQLlbGILes1htZGEk0GE/NtTo5w7Rj2tQx3IDia++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /1K7NuuaRcofZHsp8QAWFpmDxpaMbFvreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHCOo8Ft24m5jbeFfs8GrjIQrnQ5M8e1zA17ixLNaiFO
 JBIMGU1BPjGSx9iB2gsK7EGoL+tm2LYXGUGom+z+aVitgA/yyQuieOwYbI5YOeiVchT20qVu
 G/C12D4GQ0BcsySzyKf9XChjfOJmjn0MKoNEJWo+/gsh0ecrkQRAhALUVqwodGil1WzHdlYL
 iQpFjEG9PZoshbxF5+kAkP+8CXsUgMgt8R4FLR99iGdy+nowzm5G2NHcCJ6TNA6nZpjLdA17
 WOhk9TsDD1plbSaT3OB67uZxQ+P1TgpwXwqPnFdE1ZcizX3iMRq10+UEI4/eEKgpoCtQVnNL
 ya2QD/Sbln5peoCzO2F8F/OmFpATbCZH1dutm07so9Ihz6VhbJJhaT1szA3Dt4ade51q2VtW
 1BexaCjABgmV83lqcB0aLxl8EuVz/iEKibAplVkAoMs8T+gk1b6I9wMv2EueRoxa51eEdMMX
 KM0kVkPjKK/wVPwNfMnC25PI5hCIVfc+STNCamPM4smjmlZfw6b5iB+DXN8LEi2+HXAZZoXY
 M/BGe71VC5yIf0+kFKeGrdMuZd2l3tW7T6CGvjGI+GPjOP2iIi9EuxebjNjr4kRscu5neki2
 48EaZXTk0wFCLKWj+u+2dd7EG3m5EMTXPjeg8dWavSCMkxhHmQgAOXW2rQvZ8pumKE9qwsC1
 ijlMqOB4Fag13DBNyuQbXVvNOHmUZpl9CppNi0wJ1e4nXMkZN/3vqsYcpI2e5gh9fBikqEoH
 6VUJZ3YD6QdUCnD9hQccYL58N5oeiO0iF/cJCGiejU+IcJtHlSb5t/+cwLz3yASFS7r59Amq
 rit21qDE5oOTghvFujMb/erww/jtHQRgrsqDUDJPsNSaAPn940zc379ifo+IsctLxTfx2TFi
 1bKUElA/eSU+t076tjEg6yAvryFKeomExoIBXTf4Ja3KTLeojipz7hfXbvaZjvaTm71pvmvP
 L0H0/HmPfQbt19WqI4gQa1zxKcz6taz9b9XygNoQCfCY1ixU+4yJ3CH2Y9Et7FXx68fsgyzA
 xrd9t5fMLSPGcXkDF9Oe1Z1MrXdjakZymvI8PA4AETm/ysmrrOIXHJbMwSIlCEAfqB+N5kow
 Lt5tcMbg+BlZsHG7jpSYvhoylmx
IronPort-HdrOrdr: A9a23:ZBXCrq6MDv7a0BGkzQPXwWyBI+orL9Y04lQ7vn2ZFiY7TiXIra
 yTdaoguCMc0AxhJU3Jmbi7Scy9qeu1z+863WBjB8bfYOCAghroEGgC1/qs/9SEIUPDH4FmpN
 5dmsRFeb7N5B1B/LzHCWqDYpYdKbu8gdiVbI7lph8HJ2ALV0gj1XYDNu/yKDwteOAsP+tcKH
 Po3Lsgm9PWQwVxUi3UPAhmY8Hz4/nw0L72ax8PABAqrCOUiymz1bL8Gx+Emj8DTjJm294ZgC
 v4uj28wp/mn+Cwyxfa2WOWxY9RgsHdxtxKA9HJotQJKw/rlh2jaO1aKv+/VXEO0aSSAWQR4Z
 7xSiQbToJOArTqDziISC7Wqk3dOfAVmiffIBGj8CDeSIfCNU0H4oJ69Pxkm13imhcdVZhHod
 J2NyjyjesnMTrQ2Cv6/NTGTBdsiw69pmcji/caizhFXZIZc6I5l/1UwKp5KuZJIMvB0vFtLA
 CuNrCp2N9GNVeBK3zJtGhmx9KhGnw1AxedW0AH/siYySJfknx1x1YRgJV3pAZNyLstD51fo+
 jUOKVhk79DCscQcKJmHe8EBc+6EHbETx7AOH+bZV7nCKYEMXTQrIOf2sR52Mi6PJgTiJcikp
 XIV11V8WY0ZkL1EMWLmIZG9xjcKV/NFAgFCvsukaSRloeMNoYDABfzP2zGyfHQ0Mn3KverLs
 qOBA==
X-IronPort-AV: E=Sophos;i="5.88,371,1635220800"; 
   d="scan'208";a="63729172"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=kI3qaPGI+kg0O5aUVK6wMkqxIpXtqpX01O/hM3ev03hBbu2lrwtYIKlmPvX/VQlSKFTxfeTUVjPei5yBPgilszm3aQvjq7fLEFoc7xRnY88psutwj2MZPAcbM0wV3G7FUM/7vTZ4l4yRk7OvUg26xxXgQXVpdXAjavyQJ9u3fEtYqS4SmYwpfbcnQPhaQiAHdDnDNimQosL+UCrlPBofoJtiDHqfJ5aaBZe5rMLS8Kk9zBh9RqrI/q0uha4GIJaFn1EH/Hrb4LJo0Yr+nhyKqRQeU5FMIzhQNnUqU5p0eUmbsIeKFStAGKb/Ag79JaHpd2LClOwJoJLRzbmvVAx52Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=JPLHhX/RZu03sGePa0Ovma9LHYxY/o3Uv7lyFhJwVGQ=;
 b=M3vb5RCB3cyBxsB6boWBF+d1xD+raAav2InOiYC8Bg+MySj/oriNWzSdu9H6UW8qaPzONUIfCkqnfE+Ec9LXDqoQ88RAwdTtvEOTJvbauSE4Qln22KtxgRoxq5j39far/V6ZX4VVh36sByxGAU1f2RU5UiWFGGRLwy+ZDFa1O/Gkq3TZn1IwFIqnqpTsgNbrmgoI9uP2+Fa+1GxWLoPlm8QxpZoO09IJw9GeEmUTEW31xpeVV7Nr0Hh65Kz1XbfBxH/FOE858g9xgarh6x7DGCgS1AoAxe5hMs79al7/vyskd9vJtBBNO2r5JdSL1ug2SKuFFN/JlR6gU++H+nk12Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=JPLHhX/RZu03sGePa0Ovma9LHYxY/o3Uv7lyFhJwVGQ=;
 b=J7/QoL4GUEnkvmaD6v2GXsqojb9Tu+EOFJI6Q0Tx1HzXkymk+kC4C8gViXIXZg7y3MQaStPiuQ621LvpAUyiS/CN4WNjmZhBvN5NoEZ4+u91yRA3HlRU8t4hHTFAggWLMLyPGeSIFItboiXqMeNmsaaftZPEygkJerVb1IcPWno=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>, Xen-devel
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2 68/70] x86/setup: Rework MSR_S_CET handling for CET-IBT
Thread-Topic: [PATCH v2 68/70] x86/setup: Rework MSR_S_CET handling for
 CET-IBT
Thread-Index: AQHYIaOTUcnCkY5v50erixQZ+OuCLKyU0+kAgABGY4A=
Date: Tue, 15 Feb 2022 20:58:31 +0000
Message-ID: <029ee818-6cdd-6027-59f9-6ddf07ed01d0@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
 <20220214125127.17985-69-andrew.cooper3@citrix.com>
 <79617697-307e-b19b-71a9-7c8554aec481@suse.com>
In-Reply-To: <79617697-307e-b19b-71a9-7c8554aec481@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 782851fb-3f43-45f3-c656-08d9f0c5ec9b
x-ms-traffictypediagnostic: BN6PR03MB2513:EE_
x-microsoft-antispam-prvs: <BN6PR03MB25135AB1F8FA21F2774F359EBA349@BN6PR03MB2513.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8273;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: u0zdZZOdO0LC+zl/BbDF0lMr4d9+B0uYIOnOh3E7dTTM/GDiUuzXIs3kIsySbgZU2JSrN2sOIEahVsuw0zWzv/KQmQ0+GHeflb1f28mz6RvfvojdYjKOO9mGTvr6fKMsrQS0/hzHQ0zSJtYRvX1IfGJHMVoWbb/dTthhqauNIU5UYn4aWT3iKCXmXWsTmlbkS2+5zDzaWgR51eNoEgaySqPzaoHwTydgvamywK7dfOiR9aOgIMcL/cIwpbhLgAHZU+LYs1DejzYZLgqrUURZ9m3dR32kEU1j2o6w/BISUvxabQuA10hq4NvthrbWf+8svftPi3IuB4Gi3UfIdIsxG2UFUfTy/7HnRoJyrX4dbZx0Hh/bYS5e35ZAv9WgYk0Mir8RNKQB70gXJERhQ7wq+q3+CrA1/bSOpdElPnjGXjjIes7c8BlIf5pIJMqlXiuoTMGm++UW9A30CdNSP4xYzcaePszEDlco+2lBz9hIcMgoXtIsiCCF8JmMBS8Mp2GhZV+89z2sTMhms2m0vhq3aW7F5yHkDuUPt+fF2PCS1AZqaBeeZ/EnvFwGa++ROS15J1WmpL09rZV+7SQNEWBxwzI2wBvuvGHlGksxtrGfEL/qOfyb4K5n17Tg/0ni9WiS8i3iiYwAc2Aw1CYugLTI/XJ28Bhv89x+A7exQ4AzKs8YTWZkenjpVSFWYuHWjKBzhsK1ejr9GBjqkFgNRJxOahir9KWkwgQwRdmh8r3l0q0pDjhPVnsYrPKouFjxxkB/m0FTAOtqsE5C8srXwe4P8g==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(83380400001)(31686004)(508600001)(8676002)(31696002)(6486002)(76116006)(86362001)(91956017)(66476007)(66446008)(64756008)(36756003)(4326008)(66946007)(66556008)(8936002)(82960400001)(316002)(186003)(26005)(6916009)(38100700002)(122000001)(54906003)(2906002)(2616005)(71200400001)(53546011)(6512007)(38070700005)(5660300002)(6506007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Z1lNWjFtS29aQ29UOGcxaE9vNVhWY3ZmLzRCaGQ2bWEyblc5R2tHSGVFNnFE?=
 =?utf-8?B?V0kyVUR2ejcvSUJRSHlPRkViRW1jdlo1cm96ZTBxWXVyOTBPc2VlVWM4ZUZK?=
 =?utf-8?B?K29CUWpZNmt6d3N5V0ZzaUlKdHlsUEVRRkFVWlZYSmdQMDFXbnRqSFVSR0N1?=
 =?utf-8?B?Q1dnWWRtdnI4eGFCcDRHVXhrbHRBOFN6eExySUh6N0JEOVU1TDdmN0h6aG0w?=
 =?utf-8?B?NkRTRHEvS081cGxnYUVmaXJUcERUME1va1RCbHJod3Z1aDF2d25BdVRrTWJv?=
 =?utf-8?B?cExKYUxIV0N2dXcydkJaM254Q1hFbWVTSm9PZUNoR2pjQ1pOWUxhaFdrZTV0?=
 =?utf-8?B?SkU0K1lZVy8wRVBKQkJuR2JPMU9ORXZDaXc3bk0yalRFUVdRU3NtMHdPRTlz?=
 =?utf-8?B?M2oxcDNKSGZNdjR2bllsYjVJNWN6UHFSQk1aUU5GMHJDeTY0SGgrQVIwempz?=
 =?utf-8?B?eGtTNzAyMEhJMHBlZU1wajNkQ29FUjh4SnA5VkFlaURwdU5iRHJiY1lvazFJ?=
 =?utf-8?B?c0RGTFBkZmh2VWVDT0FPdFFJajE5ZWhuaHBMMU9HR2pxYnhSMDN3cytUNkdL?=
 =?utf-8?B?YU5xTExVOHFpVmxpT05NZ3ZoYU9rQjQyYitUSjdSaEk1RGV2VHBtVDhoam5Y?=
 =?utf-8?B?cHZ0bkYzOVhDb1VBYnF5YUNjNG5yV3ZmOUE4Y0RndXN3TS9rdENyanZQcDBL?=
 =?utf-8?B?Y0hFRTViNG85UkYrZWNVdzN3ZXFycDFPTktIV2YwVGhlQzA0eUJGZTRhS2ZE?=
 =?utf-8?B?eGN1Nk1IU3dFSHI3NTBnRUkxVGMzTlFRaEhwWE1ZaXhORnhodzhwRkFoMHcx?=
 =?utf-8?B?eGdhcmk0R2ZCUDRUSXgrUk11eU5Lem5ObFF5Z3BvbUQ1Ulh1L2JxV1EvUytl?=
 =?utf-8?B?U0l5Yzl1UWtPRWdRMXFqZkhRbG1CclVOY0hDS3BmNFRuNTFyVzZSZVBpdnFL?=
 =?utf-8?B?YUpkQXpaaVB1K0pOYmVHNEhnZjc5S3U2Q3BGWWxjZ25oaHQ1eVp6RW8wWjhS?=
 =?utf-8?B?MzNaditoUFV4ZEhTL3pNUDNNZHpxOU5wR1FObHN2YU5SN3Q1bHFhejdMRFYx?=
 =?utf-8?B?a09JUnQ3OGJXU1ZMMXpqTFpOb3FRVzJLb29NdlU1eEdKWFBqSFQvalkrN1BF?=
 =?utf-8?B?RkJLMkZZSzNEb2g1L1g4dG9UWmpGS0hTWHUzY2luODFpVlBkMmJ5VzVoL0xJ?=
 =?utf-8?B?OEJERjFPZnVLNS9GUlBBWEtSWUxCalgwQlpJYmd6Q1luT3hvZFFSY3VISXhm?=
 =?utf-8?B?ckpwSUozNHlJaUs1QWxlb2pHakxiblZQYTdZWWYrM2dQUHM1d1VnT1QzS0xY?=
 =?utf-8?B?alRkN3VCVDlMVWxUQWtUbzMvNDFkMmI2TGp1Q2RTQVpuM29jRFNOc21MeW81?=
 =?utf-8?B?ZjBzbUpUejBxbWJTNURIYkFsK0U1d1dNYjBxazUvYTVMTVBFWmJLK3kvZG0z?=
 =?utf-8?B?YWNZY0ZXMVZnaEoycFFkTkZDWCt2RXJVTDNyN1RwUVpVMjByNERjOVNnM2E2?=
 =?utf-8?B?VldQOWZwSzEwL2pmNVJzUDJsOWZCeHFGb01CWmRtTWhPYUJxTFRRSS9oTU9B?=
 =?utf-8?B?L010ZDYxejRDQURDUkdzczhXSEtHZnVGKzNydWZkellVek5SZHlNOGN1NFdG?=
 =?utf-8?B?MnRpakV6L2dmcnV6REhTZnFOREd6MFMyczAxR1hGVi80c3lvSWJDbW80c3RT?=
 =?utf-8?B?Mmd4UW1VbXZsaVd0d3p5RjN1K28zczQ2c0tuNTl4d1VuZG5GeUQ4aXYveDg2?=
 =?utf-8?B?Qk1PR3BGdGVhV2IxWStVcVRqMGlCazhYbVhQMk90eE5yREJ6T05yTzVhSjZS?=
 =?utf-8?B?N2hOVWZ6QTNkM3hqOUhkeFRmQnA3S0dJV1pSVmRWajZ5MndJaHlDTnpTWjdq?=
 =?utf-8?B?NHlKMllsd1V5eHFsREMyVW5YTU9lY2dpZ2VNcmRTc2dXWE94R1pzZEhCOEhm?=
 =?utf-8?B?cDQwc25xd1hobVYxMU5KbUJtaDUxMDVuTTg1TGwrU0hSTUlKRXJYU3lKRHdj?=
 =?utf-8?B?aE5HdFA1REVhNGRYWXArK1BGaDU0VUkrTS9sMnFHdTBDK25LdFBJMTUyaGtO?=
 =?utf-8?B?c2k4YzZLODgvZUxBdHpvM2RENTUxRldYMEpGY3YzZzNSc3hQVFViWjVpeWpD?=
 =?utf-8?B?TlJOeXFrZjc2QVpEWGlmS3JtS3BCZlpkeDFody9iMUFGbTVkZGpGK0ZJZ045?=
 =?utf-8?B?NWd6N3F2SWhPcnRIR1VLdVprdVVWQldxaS9lMngxMTZRbmZyT2hPT2I3Tkl5?=
 =?utf-8?B?WnI2MTAyaUd4UTlUNlVhWkpIcnBRPT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <916DB9069B4FC84BB1CF2A79A31005D9@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 782851fb-3f43-45f3-c656-08d9f0c5ec9b
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Feb 2022 20:58:31.7710
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: PAWaI+JBGEIL2ZLHzKsKHVvFsgwsl1xYkkr91JdyuofOsnv8SPm9ZZu6YjEI4Zg1xsVoEN/EKHchBi2dTEdqO/vcYSk3lf9Yl9HCexNdrvk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2513
X-OriginatorOrg: citrix.com

T24gMTUvMDIvMjAyMiAxNjo0NiwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDE0LjAyLjIwMjIg
MTM6NTEsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBDRVQtU1MgYW5kIENFVC1JQlQgY2FuIGJl
IGluZGVwZW5kZW50bHkgY29udHJvbGxlZCwgc28gdGhlIGNvbmZpZ3VyYXRpb24gb2YNCj4+IE1T
Ul9TX0NFVCBjYW4ndCBiZSBjb25zdGFudCBhbnkgbW9yZS4NCj4+DQo+PiBJbnRyb2R1Y2UgeGVu
X21zcl9zX2NldF92YWx1ZSgpLCBtb3N0bHkgYmVjYXVzZSBJIGRvbid0IGZhbmN5DQo+PiB3cml0
aW5nL21haW50YWluaW5nIHRoYXQgbG9naWMgaW4gYXNzZW1ibHkuICBVc2UgdGhpcyBpbiB0aGUg
MyBwYXRocyB3aGljaA0KPj4gYWx0ZXIgTVNSX1NfQ0VUIHdoZW4gYm90aCBmZWF0dXJlcyBhcmUg
cG90ZW50aWFsbHkgYWN0aXZlLg0KPj4NCj4+IFRvIGFjdGl2ZSBDRVQtSUJULCB3ZSBvbmx5IG5l
ZWQgQ1I0LkNFVCBhbmQgTVNSX1NfQ0VULkVOREJSX0VOLiAgVGhpcyBpcw0KPj4gY29tbW9uIHdp
dGggdGhlIENFVC1TUyBzZXR1cCwgc28gcmVvcmRlciB0aGUgb3BlcmF0aW9ucyB0byBzZXQgdXAg
Q1I0IGFuZA0KPj4gTVNSX1NfQ0VUIGZvciBhbnkgbm9uemVybyByZXN1bHQgZnJvbSB4ZW5fbXNy
X3NfY2V0X3ZhbHVlKCksIGFuZCBzZXQgdXANCj4+IE1TUl9QTDBfU1NQIGFuZCBTU1AgaWYgU0hT
VEtfRU4gd2FzIGFsc28gc2V0Lg0KPj4NCj4+IEFkanVzdCB0aGUgY3Jhc2ggcGF0aCB0byBkaXNh
YmxlIENFVC1JQlQgdG9vLg0KPj4NCj4+IFNpZ25lZC1vZmYtYnk6IEFuZHJldyBDb29wZXIgPGFu
ZHJldy5jb29wZXIzQGNpdHJpeC5jb20+DQo+IFJldmlld2VkLWJ5OiBKYW4gQmV1bGljaCA8amJl
dWxpY2hAc3VzZS5jb20+DQoNClRoYW5rcywNCg0KPiBhbGJlaXQgd2l0aCBhIG5pdCBhbmQgYSBy
ZW1hcms6DQo+DQo+PiAtLS0gYS94ZW4vYXJjaC94ODYvYWNwaS93YWtldXBfcHJvdC5TDQo+PiAr
KysgYi94ZW4vYXJjaC94ODYvYWNwaS93YWtldXBfcHJvdC5TDQo+PiBAQCAtNjMsNyArNjMsMjYg
QEAgRU5UUlkoczNfcmVzdW1lKQ0KPj4gICAgICAgICAgcHVzaHEgICAlcmF4DQo+PiAgICAgICAg
ICBscmV0cQ0KPj4gIDE6DQo+PiAtI2lmZGVmIENPTkZJR19YRU5fU0hTVEsNCj4+ICsjaWYgZGVm
aW5lZChDT05GSUdfWEVOX1NIU1RLKSB8fCBkZWZpbmVkKENPTkZJR19YRU5fSUJUKQ0KPj4gKyAg
ICAgICAgY2FsbCAgICB4ZW5fbXNyX3NfY2V0X3ZhbHVlDQo+PiArICAgICAgICB0ZXN0ICAgICVl
YXgsICVlYXgNCj4+ICsgICAgICAgIGp6ICAgICAgLkxfY2V0X2RvbmUNCj4+ICsNCj4+ICsgICAg
ICAgIC8qIFNldCB1cCBNU1JfU19DRVQuICovDQo+PiArICAgICAgICBtb3YgICAgICRNU1JfU19D
RVQsICVlY3gNCj4+ICsgICAgICAgIHhvciAgICAgJWVkeCwgJWVkeA0KPj4gKyAgICAgICAgd3Jt
c3INCj4+ICsNCj4+ICsgICAgICAgIC8qIEVuYWJsZSBDUjQuQ0VULiAqLw0KPj4gKyAgICAgICAg
bW92ICAgICAkWEVOX01JTklNQUxfQ1I0IHwgWDg2X0NSNF9DRVQsICVlY3gNCj4+ICsgICAgICAg
IG1vdiAgICAgJXJjeCwgJWNyNA0KPj4gKw0KPj4gKyAgICAgICAgLyogV0FSTklORyEgY2FsbC9y
ZXQgbm93IGZhdGFsIChpZmYgU0hTVEspIHVudGlsIFNFVFNTQlNZIGxvYWRzIFNTUCAqLw0KPj4g
Kw0KPj4gKyNpZiBkZWZpbmVkKENPTkZJR19YRU5fU0hTVEspDQo+IEp1c3QgI2lmZGVmLCBhcyBp
dCB3YXMgYmVmb3JlPw0KDQpJIGNhbiBpZiB5b3UgaW5zaXN0LCBidXQgdGhhdCdzIGJyZWFraW5n
IGNvbnNpc3RlbmN5IHdpdGggdGhlIG90aGVyDQppZmRlZmFyeS4NCg0KPg0KPj4gQEAgLTkwLDEw
ICsxMDEsNiBAQCBFTlRSWShzM19yZXN1bWUpDQo+PiAgICAgICAgICBtb3YgICAgICVlZGksICVl
YXgNCj4+ICAgICAgICAgIHdybXNyDQo+PiAgDQo+PiAtICAgICAgICAvKiBFbmFibGUgQ0VULiAg
TVNSX0lOVEVSUlVQVF9TU1BfVEFCTEUgaXMgc2V0IHVwIGxhdGVyIGluIGxvYWRfc3lzdGVtX3Rh
YmxlcygpLiAqLw0KPj4gLSAgICAgICAgbW92ICAgICAkWEVOX01JTklNQUxfQ1I0IHwgWDg2X0NS
NF9DRVQsICVlYngNCj4+IC0gICAgICAgIG1vdiAgICAgJXJieCwgJWNyNA0KPiBUaGUgbGF0dGVy
IHBhcnQgb2YgdGhpcyBjb21tZW50IGNvdWxkIGRvIHdpdGggcmV0YWluaW5nLg0KDQpTbyBJIHRy
aWVkIHRoYXQgaW4gdjEsIGFuZCBjb25jbHVkZWQgbm90IGZvciB2Mi4NCg0KVGhlcmUgaXMgbm93
aGVyZSBhcHByb3ByaWF0ZSBmb3IgaXQgdG8gbGl2ZSwgYW55d2hlcmUgaW4gdGhpcyBibG9jay7C
oA0KQW5kIGl0IGlzIGFuIGFydGVmYWN0IG9mIG1lIGJvb3RzdHJhcHBpbmcgU0hTVEsgdG8gc3Rh
cnQgd2l0aC4NCg0KVGhlIHRydXRoIGlzIHRoYXQgbm90aGluZyBhYm91dCBNU1JfSVNTVF9UQUJM
RSBtYXR0ZXJzIHVudGlsDQpsb2FkX3N5c3RlbV90YWJsZSBzZXRzIHVwIGJvdGggdGhpcyBhbmQg
dGhlIFRTUyBJU1QgZmllbGRzIHRvZ2V0aGVyLsKgDQpJU1QgZXhjZXB0aW9ucyBhcmUgYWxyZWFk
eSBmYXRhbCBhdCB0aGlzIHBvaW50IGZvciBub24tU0hTVEsgcmVhc29ucy4NCg0KfkFuZHJldw0K


From xen-devel-bounces@lists.xenproject.org Tue Feb 15 21:00:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 21:00:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273562.468798 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nK4w9-0008Mk-8M; Tue, 15 Feb 2022 21:00:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273562.468798; Tue, 15 Feb 2022 21:00:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nK4w9-0008Md-38; Tue, 15 Feb 2022 21:00:37 +0000
Received: by outflank-mailman (input) for mailman id 273562;
 Tue, 15 Feb 2022 21:00:35 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nK4w7-0008MX-HO
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 21:00:35 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nK4w6-000232-IB; Tue, 15 Feb 2022 21:00:34 +0000
Received: from 54-240-197-239.amazon.com ([54.240.197.239] helo=[192.168.8.20])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nK4w6-0005GX-Bp; Tue, 15 Feb 2022 21:00:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=vbGF0RPcwfQm4WUX06EwAzgRMZPTh6YbvyHD6PK+ym0=; b=pN3393+P9KnqwsFJKGd6xVgDGO
	G32HT2pTtyHIWKpun9G3iHAORMn10vkWnkPeu/OWo1sMoBlcbqbImJ9WzfrEYab9/DF3jVQsUQ3FZ
	i2cWqLwno130WNNbD6vAH68w+WCTUCjNfV48yuF0awhmz0rzQFGhnPk7k5AC4aMArUyc=;
Message-ID: <35d82770-66cf-e030-5bcc-3c030e4463d7@xen.org>
Date: Tue, 15 Feb 2022 21:00:32 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.0
Subject: Re: [PATCH v2] lib: extend ASSERT()
To: Jan Beulich <jbeulich@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <75125344-b0e1-9663-4c1a-84bb35870fef@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <75125344-b0e1-9663-4c1a-84bb35870fef@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

(+ Bertrand)

Hi Jan,

On 27/01/2022 14:34, Jan Beulich wrote:
> The increasing amount of constructs along the lines of
> 
>      if ( !condition )
>      {
>          ASSERT_UNREACHABLE();
>          return;
>      }
> 
> is not only longer than necessary, but also doesn't produce incident
> specific console output (except for file name and line number).

So I agree that this construct will always result to a minimum 5 lines. 
Which is not nice. But the proposed change is...

> Allow
> the intended effect to be achieved with ASSERT(), by giving it a second
> parameter allowing specification of the action to take in release builds
> in case an assertion would have triggered in a debug one. The example
> above then becomes
> 
>      ASSERT(condition, return);
> 
> Make sure the condition will continue to not get evaluated when just a
> single argument gets passed to ASSERT().
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> v2: Rename new macro parameter.
> ---
> RFC: The use of a control flow construct as a macro argument may be
>       controversial.

indeed controversial. I find this quite confusing and not something I 
would request a user to switch to if they use the longer version.

That said, this is mainly a matter of taste. So I am interested to hear 
others view.

I have also CCed Bertrand to have an opinions from the Fusa Group (I 
suspect this will go backward for them).

> 
> --- a/xen/common/memory.c
> +++ b/xen/common/memory.c
> @@ -826,11 +826,7 @@ int xenmem_add_to_physmap(struct domain
>       union add_to_physmap_extra extra = {};
>       struct page_info *pages[16];
>   
> -    if ( !paging_mode_translate(d) )
> -    {
> -        ASSERT_UNREACHABLE();
> -        return -EACCES;
> -    }
> +    ASSERT(paging_mode_translate(d), return -EACCES);
>   
>       if ( xatp->space == XENMAPSPACE_gmfn_foreign )
>           extra.foreign_domid = DOMID_INVALID;
> @@ -920,11 +916,7 @@ static int xenmem_add_to_physmap_batch(s
>        * call doesn't succumb to dead-code-elimination. Duplicate the short-circut
>        * from xatp_permission_check() to try and help the compiler out.
>        */
> -    if ( !paging_mode_translate(d) )
> -    {
> -        ASSERT_UNREACHABLE();
> -        return -EACCES;
> -    }
> +    ASSERT(paging_mode_translate(d), return -EACCES);
>   
>       if ( unlikely(xatpb->size < extent) )
>           return -EILSEQ;
> --- a/xen/include/xen/lib.h
> +++ b/xen/include/xen/lib.h
> @@ -49,11 +49,13 @@
>   #endif
>   
>   #ifndef NDEBUG
> -#define ASSERT(p) \
> +#define ASSERT(p, ...) \
>       do { if ( unlikely(!(p)) ) assert_failed(#p); } while (0)
>   #define ASSERT_UNREACHABLE() assert_failed("unreachable")
>   #else
> -#define ASSERT(p) do { if ( 0 && (p) ) {} } while (0)
> +#define ASSERT(p, failsafe...) do { \
> +        if ( !count_args(failsafe) || unlikely(!(p)) ) { failsafe; } \
> +    } while ( 0 )
>   #define ASSERT_UNREACHABLE() do { } while (0)
>   #endif
>   
> 

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Feb 15 21:13:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 21:13:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273571.468809 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nK58o-0001Ui-Gn; Tue, 15 Feb 2022 21:13:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273571.468809; Tue, 15 Feb 2022 21:13:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nK58o-0001Ub-Dq; Tue, 15 Feb 2022 21:13:42 +0000
Received: by outflank-mailman (input) for mailman id 273571;
 Tue, 15 Feb 2022 21:13:41 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nK58n-0001UV-K0
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 21:13:41 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nK58n-0002Ef-9b; Tue, 15 Feb 2022 21:13:41 +0000
Received: from 54-240-197-239.amazon.com ([54.240.197.239] helo=[192.168.8.20])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nK58n-0006HU-3f; Tue, 15 Feb 2022 21:13:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=SSgDnZBF1c9vXl+1IPp0VeNvm753pB+kA3bqlvGU0es=; b=IFqQEqCsZ+VT3JPKZSonR1Zc/j
	fHfFpBbY60Qe5Gn1cpH1j0952JDffFLH4V/xkW4gj0u99yOY0ONmN1fGyck41DppBaC8zkk393bLw
	cCEbJ0Iej10tvS4LGd4I8dLh6eN3MLqJrqsbKGPFX2onbRbo8GDgM5IKhhNdMRBZ/a9g=;
Message-ID: <a35bb9ba-e2be-f73e-9272-906bc09d9b6e@xen.org>
Date: Tue, 15 Feb 2022 21:13:38 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.0
Subject: Re: [PATCH v2 2/2] xen/include/public: deprecate GNTTABOP_transfer
To: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
References: <20220203131418.1319-1-jgross@suse.com>
 <20220203131418.1319-2-jgross@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220203131418.1319-2-jgross@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Juergen,

On 03/02/2022 13:14, Juergen Gross wrote:
> Add a comment to include/public/grant_table.h that GNTTABOP_transfer
> is deprecated, in order to discourage new use cases.

 From the commit message, it is unclear to me why we are discouraging 
new use cases and indirectly encouraging current users to move away from 
the feature.

Patch #1 seems to imply this is because the feature is not present in 
Linux upstream. But I don't think this is a sufficient reason to 
deprecate a feature.

A more compelling reason would be that the feature is broken and too 
complex to fix it.

So can you provide more details?

As a side note, should we also update SUPPORT.md?

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Feb 15 22:00:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 22:00:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273579.468820 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nK5sF-0006Sc-RS; Tue, 15 Feb 2022 22:00:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273579.468820; Tue, 15 Feb 2022 22:00:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nK5sF-0006SV-Nx; Tue, 15 Feb 2022 22:00:39 +0000
Received: by outflank-mailman (input) for mailman id 273579;
 Tue, 15 Feb 2022 22:00:38 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Y6yl=S6=gmail.com=digetx@srs-se1.protection.inumbo.net>)
 id 1nK5sE-0006SP-B3
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 22:00:38 +0000
Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com
 [2a00:1450:4864:20::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b44a69d5-8eaa-11ec-b215-9bbe72dcb22c;
 Tue, 15 Feb 2022 23:00:36 +0100 (CET)
Received: by mail-lf1-x133.google.com with SMTP id o2so255905lfd.1
 for <xen-devel@lists.xenproject.org>; Tue, 15 Feb 2022 14:00:36 -0800 (PST)
Received: from [192.168.2.145] (109-252-138-165.dynamic.spd-mgts.ru.
 [109.252.138.165])
 by smtp.googlemail.com with ESMTPSA id k3sm66075lfo.10.2022.02.15.14.00.33
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Tue, 15 Feb 2022 14:00:35 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b44a69d5-8eaa-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=message-id:date:mime-version:user-agent:subject:content-language
         :from:cc:references:to:in-reply-to:content-transfer-encoding;
        bh=DVulEGE2JpmKCAwv+Z9nIfk2u5ZwvRtSEnvF0++tohE=;
        b=eAbTUd8SWrkduWMDvYSL9PCIMvTyx1/PDNq+g34U5a6HTO/JfyDazuc/276Sm7ld7f
         RQAUjz9KnJpaex/eozKDcsnVqqRwA5Fj5CSlNJHiQfzBkJVLCc7y3vw02lxihPY3TExU
         lYcUYoYFkQWAG/XD2qnNsvTl5P4zqH6pcaasqRB1LojAt2IN4Q9BVX82FHrNStE8wYB4
         mmhCvKeDI7YjVSy4dXfgCBsx8WWHAoaLNoouUIXdBuim6buHAqSq3/5veKqw8hxrEwEf
         aYlaoKh86/GFDdT8ghhsvoX3tr735feUL8boUX68tZ9vbfpFMdKPrE/wFw8zC0NNEmPZ
         ssKw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:message-id:date:mime-version:user-agent:subject
         :content-language:from:cc:references:to:in-reply-to
         :content-transfer-encoding;
        bh=DVulEGE2JpmKCAwv+Z9nIfk2u5ZwvRtSEnvF0++tohE=;
        b=7DA+cuQ11pWy8B6Cwrc/8KUbiHzMRGSHtlnL/3yd3RPPkRzJd+RndJMQvHEZllmQsa
         mu3gh76WMmQdwFpKfz+WyunVC43N3jTVZ2KHefgJMUmguwC/xmsa3wwj5zweYmPIOtDw
         BweTxUWsnC2TwYBjAJiCBskYoOFP9VQTEJeWk7JlLr/sF0Obtqbw1niSrYPmG357BYC/
         j1EQqoO8O4L9Qio2QBGuoVg/m4e/aAcsmnsAjICet/cHM3qQ84LWSvo08025rwnBaDLu
         wocfpNtgBeflhE7iBIorF3o1EjWKRR18ZJt8JhCB7DGS//7/6yax4BImoskApEGPPmN0
         0JIw==
X-Gm-Message-State: AOAM531mUeGjWh0zBpmPLJEeAqbzvc4p0NETKSkwD1stMN6saudt6U7S
	/vrovyyle7JZAmrIXgkuHUo=
X-Google-Smtp-Source: ABdhPJyJtWqeT1e2wzvijosINOm/qc6wwzWUL/FDa9uqhHR32CJOoO1KF1UaVLhHtHEQQhQBEaQuLQ==
X-Received: by 2002:a05:6512:96d:: with SMTP id v13mr790998lft.343.1644962435902;
        Tue, 15 Feb 2022 14:00:35 -0800 (PST)
Message-ID: <635e8121-fca4-580c-6af5-d9317a2eee1b@gmail.com>
Date: Wed, 16 Feb 2022 01:00:33 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v6 00/21] Introduce power-off+restart call chain API
Content-Language: en-US
From: Dmitry Osipenko <digetx@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org,
 linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org,
 linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org,
 linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org,
 xen-devel@lists.xenproject.org, linux-acpi@vger.kernel.org,
 linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org,
 Thierry Reding <thierry.reding@gmail.com>,
 Jonathan Hunter <jonathanh@nvidia.com>, Russell King
 <linux@armlinux.org.uk>, Catalin Marinas <catalin.marinas@arm.com>,
 Will Deacon <will@kernel.org>, Guo Ren <guoren@kernel.org>,
 Geert Uytterhoeven <geert@linux-m68k.org>, Greg Ungerer
 <gerg@linux-m68k.org>, Joshua Thompson <funaho@jurai.org>,
 Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
 Sebastian Reichel <sre@kernel.org>, Linus Walleij
 <linus.walleij@linaro.org>, Philipp Zabel <p.zabel@pengutronix.de>,
 Greentime Hu <green.hu@gmail.com>, Vincent Chen <deanbo422@gmail.com>,
 "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
 Helge Deller <deller@gmx.de>, Michael Ellerman <mpe@ellerman.id.au>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Paul Mackerras <paulus@samba.org>, Paul Walmsley <paul.walmsley@sifive.com>,
 Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>,
 Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,
 x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>, Juergen Gross
 <jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>,
 Len Brown <lenb@kernel.org>, Santosh Shilimkar <ssantosh@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
 Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>,
 Pavel Machek <pavel@ucw.cz>, Lee Jones <lee.jones@linaro.org>,
 Andrew Morton <akpm@linux-foundation.org>, Guenter Roeck
 <linux@roeck-us.net>, Daniel Lezcano <daniel.lezcano@linaro.org>,
 Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
 Ulf Hansson <ulf.hansson@linaro.org>, alankao@andestech.com,
 "K . C . Kuen-Chern Lin" <kclin@andestech.com>,
 =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= <mirq-linux@rere.qmqm.pl>
References: <20220130233718.21544-1-digetx@gmail.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
In-Reply-To: <20220130233718.21544-1-digetx@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

31.01.2022 02:36, Dmitry Osipenko пишет:
> Problem
> -------
> 
> SoC devices require power-off call chaining functionality from kernel.
> We have a widely used restart chaining provided by restart notifier API,
> but nothing for power-off.
> 
> Solution
> --------
> 
> Introduce new API that provides both restart and power-off call chains.
> 
> Why combine restart with power-off? Because drivers often do both.
> More practical to have API that provides both under the same roof.
> 
> The new API is designed with simplicity and extensibility in mind.
> It's built upon the existing restart and reboot APIs. The simplicity
> is in new helper functions that are convenient for drivers. The
> extensibility is in the design that doesn't hardcode callback
> arguments, making easy to add new parameters and remove old.
> 
> This is a third attempt to introduce the new API. First was made by
> Guenter Roeck back in 2014, second was made by Thierry Reding in 2017.
> In fact the work didn't stop and recently arm_pm_restart() was removed
> from v5.14 kernel, which was a part of preparatory work started by
> Guenter Roeck. I took into account experience and ideas from the
> previous attempts, extended and polished them.


Rafael and all, do you see anything critical that needs to be improved
in this v6?

Will be great if you could take this patchset via the power tree if it
looks okay, or give an ack.


From xen-devel-bounces@lists.xenproject.org Tue Feb 15 22:59:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 22:59:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273586.468830 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nK6nF-0003Dk-81; Tue, 15 Feb 2022 22:59:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273586.468830; Tue, 15 Feb 2022 22:59:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nK6nF-0003Dd-57; Tue, 15 Feb 2022 22:59:33 +0000
Received: by outflank-mailman (input) for mailman id 273586;
 Tue, 15 Feb 2022 22:59:31 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=a0FC=S6=gmail.com=dmitry.torokhov@srs-se1.protection.inumbo.net>)
 id 1nK6nD-0003DX-CX
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 22:59:31 +0000
Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com
 [2607:f8b0:4864:20::1029])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ee3fb26e-8eb2-11ec-8eb8-a37418f5ba1a;
 Tue, 15 Feb 2022 23:59:30 +0100 (CET)
Received: by mail-pj1-x1029.google.com with SMTP id
 v13-20020a17090ac90d00b001b87bc106bdso4654740pjt.4
 for <xen-devel@lists.xenproject.org>; Tue, 15 Feb 2022 14:59:30 -0800 (PST)
Received: from google.com ([2620:15c:202:201:4e4a:b0ff:e926:40e2])
 by smtp.gmail.com with ESMTPSA id n85sm10430319pfd.142.2022.02.15.14.59.23
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 15 Feb 2022 14:59:25 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ee3fb26e-8eb2-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-disposition:in-reply-to;
        bh=Ydg/QaEHk+YtzGHqWPzjDmBjfyy2f1JmjiAxPzP8crc=;
        b=neA8UZ+ztvqI+c9Y0GhuINKiFZbH9bwEKDbDdCj/aBEOg8Je4KJR2FY7wqhQqcBAYk
         3Wy+WGL8h5hMZhHiRrJnELKEzNVne+rWwRiNSK+LaaB40t3gKAMZ5iPl6SH4z0sCF1sK
         WeebZKAyrtHxpGEBt52RHDKoImWcRYibqiE5YdJSrERCh5ErepkYhiOc7Yw8VRa7JtSJ
         adEHSUdt8ZETIXkSrLoXpm9wbvKFejNQ1Fv3M/q0bRnt69wRrVeApz/eynGg7QDAnCzT
         uJF8lE/RahbG4H9xVfC7Tm4Wgh1nT1vyrj+ukgd4F45LFSngNGYO0nz3bd1+0RfzB/uo
         Q/xw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:references
         :mime-version:content-disposition:in-reply-to;
        bh=Ydg/QaEHk+YtzGHqWPzjDmBjfyy2f1JmjiAxPzP8crc=;
        b=rrX/9m/dUA0gBgIKTuOucjai8w6p5rggoP7MYJfHADccd+N4s4gq2yFPZdcJyiP0Zh
         jDwY2/DQYDyu249fBUgazXKL5zmpHheIOH+CY7lr0Qbxia06ptVRMCLflf4v/uvGi3P5
         HkC4nZCHb4OfyQ3w/zxjyD2etSwX1tjQRzww0MRFHkPip+dBdOppRHfXUjlD5m/KlLRK
         jQAv5/k//myEXhM2/vfj98d4FkGuqWTmvzH3f6yXlnJvql++38/PBaijy2jqU/WdTWHD
         unVa/WYQIoBA+SSMWavNsikW5NMPXDvvykO3WHWV8LYNX6qBNjZ2mdrq34/T6NoJ23R6
         nTXg==
X-Gm-Message-State: AOAM531WR028QUfcOtyG7tf+m1vlagtQXwOR7N8oFfg3fQKidhE+W7Lb
	MR6NA00Eu9+AZE/SSJ3zoZ0=
X-Google-Smtp-Source: ABdhPJzD5VTWuMUJjUi6d0x1rXiN3okRfTcvfy3+tsDIIsH6bfb6SZ+FiyUr2n1wCBp6WTu5fGOOUA==
X-Received: by 2002:a17:902:f686:: with SMTP id l6mr1079179plg.7.1644965965923;
        Tue, 15 Feb 2022 14:59:25 -0800 (PST)
Date: Tue, 15 Feb 2022 14:59:21 -0800
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Qing Wang <wangqing@vivo.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Roger Pau =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>,
	Jens Axboe <axboe@kernel.dk>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	Alex Deucher <alexander.deucher@amd.com>,
	Christian =?iso-8859-1?Q?K=F6nig?= <christian.koenig@amd.com>,
	"Pan, Xinhui" <Xinhui.Pan@amd.com>,
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	Alasdair Kergon <agk@redhat.com>, Mike Snitzer <snitzer@redhat.com>,
	dm-devel@redhat.com, Mauro Carvalho Chehab <mchehab@kernel.org>,
	Hans Verkuil <hverkuil@xs4all.nl>, xen-devel@lists.xenproject.org,
	linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-clk@vger.kernel.org, intel-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
	linux-input@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [PATCH V3 6/13] input: serio: use time_is_before_jiffies()
 instead of open coding it
Message-ID: <YgwwSUlZVakiYF8j@google.com>
References: <1644890154-64915-1-git-send-email-wangqing@vivo.com>
 <1644890154-64915-7-git-send-email-wangqing@vivo.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1644890154-64915-7-git-send-email-wangqing@vivo.com>

Hi Wang,

On Mon, Feb 14, 2022 at 05:55:43PM -0800, Qing Wang wrote:
> From: Wang Qing <wangqing@vivo.com>
> 
> Use the helper function time_is_{before,after}_jiffies() to improve
> code readability.

I applied changes by Danilo Krummrich converting the driver to use
ktime_t (see https://lore.kernel.org/r/20220215160208.34826-3-danilokrummrich@dk-develop.de)
which makes this change not applicable.

Thanks.

-- 
Dmitry


From xen-devel-bounces@lists.xenproject.org Tue Feb 15 23:00:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 23:00:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273592.468842 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nK6o1-0004Xk-Ht; Tue, 15 Feb 2022 23:00:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273592.468842; Tue, 15 Feb 2022 23:00:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nK6o1-0004Xd-Ek; Tue, 15 Feb 2022 23:00:21 +0000
Received: by outflank-mailman (input) for mailman id 273592;
 Tue, 15 Feb 2022 23:00:19 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=zJqs=S6=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nK6nz-0003X9-BB
 for xen-devel@lists.xenproject.org; Tue, 15 Feb 2022 23:00:19 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0a200065-8eb3-11ec-b215-9bbe72dcb22c;
 Wed, 16 Feb 2022 00:00:17 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0a200065-8eb3-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1644966017;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=AacAo/eRvfY4J8goeSIPLwJDsg7Ltb3Rmt/eXKozd4g=;
  b=hW+k5pD2W8mS/SwnqRrxkj6BMFfYynUzmAUpniH3txoCu1ipfFFHuHpY
   lDUjuQXUyJy/t6+zVLU+5HZ9lBBHHTQcwyusC+wI1q1vGj8svEMq/v5+A
   jeqJ3858zYfU4ABU40cXOwCcWFEC6hnxtjSMOmf2Ifa4G+8yc/jrfusJ7
   s=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: heBUP79en1b5kY6vhmZIxGp+UhymKzWQFQFhN+sUq1omiWbRi3jX7XlGX1kp4Rwu8I71Hg4R+K
 fesqJW25wFFwgpCUjeGRHFtL0MJCPAcXAJYRXO5i4idr3VhqkuPxzCIPsCy/O15pm1abPAaRdS
 YzuIZeTva9RnMQe9qrVVXdgKHhbt8YMt4uLwZe1O1GKwtB0t36FXm1SZb/Oo3tT68+ZLvN6/dP
 38gkg+h5/4GWS7AQyGSbM6BseREedSEkgEW2vc5fR0s+4M3CeKU9SnTqfHLZssu0yRgZcLr6dm
 frI+rCK1yMmsyyROgZEBoWQd
X-SBRS: 5.1
X-MesageID: 66528721
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:fRuHj6tZnRkyoMij7CnKgWZNyefnVI1ZMUV32f8akzHdYApBsoF/q
 tZmKW/TPf7eYmH1LYsnat6+oE4P6sODyoRnQVRr/n01EXkT+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZQP0VOZigHtIQMsadUsxKbVIiGHdJZS5LwbZj2NYy2IXhWGthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 NplmpuZSigxL6L1h88ZdENyLnxOB/Mb0eqSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DFYUToHx/ixreCu4rW8vrSKTW/95Imjw3g6iiGN6AO
 ZdDOWU1NXwsZTVLKHMqBa19wNuGvV6ka2EAkVuWq7Q4tj27IAtZj+G2bYu9lsaxbdVYmAOUq
 3zL+0z9AwoGL5qPxDyd6HWui+TT2yThV+o6C7mQ5vNsxlqJyQQ7ChcbSF+6qvmRkVOlVpRUL
 El8x8Y1hfFsrgrxFIC7BkDm5i7f1vIBZzZOO8I9wQKi0rvb2hmyAk9eZAMcWOZ46eZjEFTGy
 WS1t9/uADVutpicRnSc6qqYoFuOBMQFEYMRTXRaFFVYurEPtKl210uSFYg7TMZZm/WoQWmY/
 tyckMQpa1z/Z+Yv3r7zw13IiinESnPhHl9svVW/so5IA2pEiG+Zi26AtACzARVodt/xory9U
 J4swZX2AAcmV8zlqcB1aL9RdIxFHt7cWNEmvXZhHoM66xOm8GO5cIZb7VlWfRk1bpdZIGW4M
 R6K42u9AaO/2lPwMMebhKrrVawXIVXIT4y5Bpg4kPISCnSOSON31H43PhPBt4wcuEMtjbs+K
 f+mnTWEVh4n5VBc5GPuHY81iOZzrghnnD+7bc2rnnyPjOvFDFbIGOhtDbd7Rr1ghE9yiF6Oq
 Ig32grj40g3bdASlQGOqtBNdAhTdyBkbX00wuQOHtO+zsNdMDhJI9fawK87epwjmKJQl+zS+
 Wq6VFMew1367UAr4y3QApy6QL+wD5t5s1whOikgYQSh13Q5ON7956YDbZonO7Ig8bU7n/JzS
 vAEfeSGA+hOFWubq2hMM8GlodwwbgmviCKPIzGhPGo1cal/SlGb4dTjZAbuqnUDV3Llqcskr
 rS8/QrHWp5fFR96BcPbZav3nVO8tHQQgsxoWE7MLoUBcUng6tEyeSfwkuU2M4cHLhCanmmW0
 AOfABE5o+jRotBqrImV1P7c94rwSrlwBEtXGWXf/I2aDyiC8zrx25JEXcaJYSvZCDH+9pK9a
 LgH1Pr7KvAGwgpH6tIuD7ZxwKsizNLzvLsGnB98FXDGYln3WLNtJn6KgZtGuqFXn+ILvAK3X
 gSE+8VAOKXPM8TgSQZDKA0gZ+WF9PcVhjiNsqhlfBSkvHd6rOidTEFfHxiQkygMfrJ6PbQsz
 folpMNLuRe0jQAnM4regy1Zn4hWwqfsj0nzWkkmPbLW
IronPort-HdrOrdr: A9a23:ymB0Hq2hZl00tVzVp/WvAAqjBRZyeYIsimQD101hICG9Lfb2qy
 n+ppgmPEHP5Qr5AEtQ5OxpOMG7MBbhHQYc2/heAV7QZnibhILOFvAi0WKC+UyuJ8SazIBgPM
 hbAtFD4bHLfDtHZIPBkXOF+rUbsZm6GcKT9J/jJh5WJGkAAcAB0+46MHfhLqQffngdOXNTLu
 v52iMznUvHRZ1hVLXdOpBqZZmgm/T70LbdJTIWDR8u7weDyRmy7qThLhSe1hACFxtS3LYL6w
 H+4k/Ez5Tml8v+5g7X1mfV4ZgTssDm0MF/CMuFjdVQAinwizyveJ9qV9S5zXIISaCUmRMXee
 v30lAd1vdImjXsl6aO0ELQMjzboXITArnZuAelaDXY0JfErXkBerV8bMpiA2XkAgwbzYxBOe
 twrhKkX9A8N2KwoA3to9fPTB1kjUyyvD4rlvMSlWVWVc8EZKZWtpF3xjIeLH4sJlOz1GkcKp
 gkMCgc3ocjTXqKK3TC+mV/yt2lWXo+Wh+AX0gZo8SQlzxbhmpwwUcUzNEW2i5ozuNwd7BUo+
 Dfdqh4nrBHScEbKap7GecaWMOyTmjAWwjFPm6eKUnuUKsHJ3XOoZjq56hd3pDmRLUYiJ8p3J
 jRWlJRsmA/P0roFM2VxZVOtgvARW2sNA6dg/22J6IJzIEUaICbQxFreWpe5PdI+c9vcfEzc8
 zDTa5rPw==
X-IronPort-AV: E=Sophos;i="5.88,371,1635220800"; 
   d="scan'208";a="66528721"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=QIEmBUrn8tGEB3IsrtlIeau2WpbC9nM5jqnlrHxbNNXIY8UKaX/2cF5KZraT9FGx2VhgzH14ShWqSc4SkkbHQ1mK2Q+9WLk8PofnMVZW5CvVEH7xtl/aclnnvMo+YhkZCH1fgMocb7FAFp4nDvKePSZOH5HV9qYrZsexlAQC1id8JNitIcMd8uO9MZ8oYCYPAGG83aJOc/+B7JECcVwzZm7g3wq1qXpeQBcP96RKFlTA7WRorkOWZ2lLAnUo911z7HnDB9XWaPvd8URffHPLk5JFB5Wdc+L5AQNt7xEnSpsYvP/keIx5WIITNgDzwLsZ8xm6ENvJpMq6gJpeW7kz9A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=AacAo/eRvfY4J8goeSIPLwJDsg7Ltb3Rmt/eXKozd4g=;
 b=S7MmEg68P8Iv48LYfcOaHeWqHE0RTmFDRFRvN7J1CKYF8ivp0cZB2nrYa02g2kH+5ARtmxS38MV72v6W0LhqhwxBksSn/9K04tSMeiub4AGVZKluog90A0M0ntLPXtEwpevf1hoFJsbi1LMD5iHjbgykApnfn12T5pPnZNPhzA2VzFSt/QvYJGF15bATNILbKZ7Gg/RqXjg+G7BfuL7UrDfKUQ8v5BoISIewkEVmyLP/R9N7jahXlYKBaW9AC9d1fjOG5xa1vLfNyoJOIwMqESocKpetZo12i8t2nnNuf3dSArRRVv23551dZ8ayVp+wQW5/nj/X+iTVqrpTHzD6dA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=AacAo/eRvfY4J8goeSIPLwJDsg7Ltb3Rmt/eXKozd4g=;
 b=hoPn1mmpHwllCmX+luQvzM9R+DEmOxIu/yLOh/67FhiU7eTF0cmcFFVAsCfy26MmmFWIJR5PPEGiJ+4JNiLodVP2ZJNN8iwOjX44syTwW0nyWPJHCj7QLa1egYJbrc+kVcQrEmLUx7KU8EiiKbbFakAMZWrZCot31zerh9VcNxA=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>, Xen-devel
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2 69/70] x86/efi: Disable CET-IBT around Runtime Services
 calls
Thread-Topic: [PATCH v2 69/70] x86/efi: Disable CET-IBT around Runtime
 Services calls
Thread-Index: AQHYIaO5yC8LkxEff0u7D+BbmzJONayU1dyAgABmbAA=
Date: Tue, 15 Feb 2022 23:00:11 +0000
Message-ID: <9909b7ca-3346-a46a-155c-e4a83d99b2fb@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
 <20220214125127.17985-70-andrew.cooper3@citrix.com>
 <0eede8ae-c2a2-cc87-d4cd-47ceffd4e488@suse.com>
In-Reply-To: <0eede8ae-c2a2-cc87-d4cd-47ceffd4e488@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: c924a774-f285-4cd4-e2fe-08d9f0d6eb64
x-ms-traffictypediagnostic: DM4PR03MB6046:EE_
x-microsoft-antispam-prvs: <DM4PR03MB604659E869DA5B558CE576CFBA349@DM4PR03MB6046.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8882;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: sbTd50Obq84bi2R5TXz9icv7hefxpP+x2TXSZtJA/88fzgMAdG3kQ68iOs1s7lD16sXZsZNngiigyXAt8/hCxa1TFskJ0SNLnVhljb2lHqkbSBubuX0Hg8lrNbwEb8IoUNb2NwHRb+9Ji5Kke1n+0bfzxZ1s4H2kpXig2x94pQ2OGxOZg+H2ElO6qQgiu/6fqhOkyxQuUT3Rb4JiBCFR/gDVvwxN0y4K6BoE+0+VTFBFSBUY9wHBRtQuOMVWbaB6D2TIKjxmcQVTqe5YzsCbff+lh/VhVvm0/G8Oodb8LDnkiGdJ6l+yr5GvKSxS5+hR0iXClT9EV4R3AMBuDbkox/vdjZ5f0jeRNwxbQKGo67KkjrHiO8Ifo7ei4cdtLnuUl0B2Z1Cn9B9wIADL6/VoaWBDUuXsl2XXr5y54K8NJ3MkoETddN/wRK6KcUiRit0ALAcOtvCvhJGIz8lbdrkinQVhYQYZm+LBL2jz47OjYd/Po2rVhEUfpdytB6NUIfofRv5SIA/GJQucHfm+lxa/Xe6851YrdN5BSkH+Xo+KWIymfCmfEkjZBsfzFtSdeamFiHU6P8U/Rfjw6oyvUWgTZ/ulHg5xIZ8p4rnPIQ8tSRiP9S7/JZDwkUyMLZeV5422cLgP/tG4mo2FcX0b/w6zfFZwOJcGnVsXs0GF+fW0t55k4plguB8XVpDq8ODcge41CElm97lVcLm576cqa4HwFu6pFdjWvYUT3UFpCnMQtg+xqGPEu1VZkF/dYhCH5lyRq57/7rC5/qrNvHVwwYx7AA==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(2616005)(53546011)(6512007)(6506007)(71200400001)(122000001)(2906002)(26005)(5660300002)(186003)(66476007)(8936002)(66556008)(76116006)(508600001)(6486002)(54906003)(66446008)(38070700005)(4326008)(8676002)(64756008)(91956017)(6916009)(316002)(36756003)(86362001)(38100700002)(31696002)(82960400001)(66946007)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?amdJU1NkRlAwZ1JBbkdxTitxS1ZhRmhvclpIYWdYZENjSE1ja0Z5S3BqSElu?=
 =?utf-8?B?Z29FR093VThUUlBleVRSQStyRDNOSmxtYnFVUlc5bXE1QjlnTVhQd29scG9G?=
 =?utf-8?B?RWFtb3NlUlROUHZabjRTR2NqKzFia0tzaVRMN2RrWUF1Vk9zcWYzVGhvOCtr?=
 =?utf-8?B?V3c0T2FRSUozbktyWUJtcEwzUXlTc2d6bEpuU1lqdkpENHErZXdKVytUZlZJ?=
 =?utf-8?B?amlrYm9neTVwZVpvb3cxT1VwdFR5dnJDVWQyUVY2Mm92UnQwSHNFREREd2pw?=
 =?utf-8?B?S3o5Z3NvZWJMY2t3MDAvcmprWFR0SmplN21xdE1pS3ovT1RZVE42TW45ZXlX?=
 =?utf-8?B?YzNjempwcFVhcFh3c0RwUmZVWmNySmdIdTZLWmVBZ0dRcXNJRnd4WFhESjZt?=
 =?utf-8?B?d0o5MTFtM2h3b0hKR0liUGJkcVlibSt1ZDVSRVZFRmpZYWt1QUdvcTBaR2tI?=
 =?utf-8?B?S2FKNTh5OGJGZFVwczRaaG5sSlJhZmsyUjR3YmNNZ3Fvb1dqSHV1aG5RdG5k?=
 =?utf-8?B?Sm1tTnJCcVNHQkxtQU5FZVZrVnhBUXVnM1lQVXRRbS90cU1WYU94YjNwRFd1?=
 =?utf-8?B?bklYYXNvUkwyUjB0TS8xMHRUa2w4a00wU1hvUEVabGpFdUFkSTVSczd4eXRW?=
 =?utf-8?B?OWFxdExvNDc2TzJpRUhuU2lVT3ptb1lHZ1pHb2VnLzk3Ujk2RXRpQ1A0SGJq?=
 =?utf-8?B?ZnVsdWFXaExkeTVTRGRvRTgzRUR4dllxRmswcmJReC9Hcnl6cDVKQ1RscjNj?=
 =?utf-8?B?UmhPR3JtQXpIVFhHWWEzRmh3YVpNRFQ5WlVndktvZll4ZFpVNURBZkR2Z2E3?=
 =?utf-8?B?bXh0V3BNSDZzZ2J6cHp5c21ydWZJTWRWNnNLMHVkV2NzdDB0MzFYT0t0WnlF?=
 =?utf-8?B?SllZMHBJU0REM25aZXY4UTBzWGxnclYzZ1kzcUtXWTZUcEp5OFVwVmFPZ3V2?=
 =?utf-8?B?UVM2dWw4S0NUZEdPMlVtWUEwZy8xeGsxM1hxN1llWTYzenVFaGUrTGlUZWpp?=
 =?utf-8?B?SU1sTXdmY3N2SGY4dXlQejVHdEtDdjJXZ1h6dTRRanZjek5CcHFwdjZKRytY?=
 =?utf-8?B?ZWUzZlZBbHd0TGVOeXJxTDVuRGJaRG9Yazk5bmpaeE04SElLMW9DTGQ4VXh4?=
 =?utf-8?B?WlZ1V1pkd0R3VFZUTFF1VFJ1aUZBQUgrb0UvRW9xVEhtV3F2ZzZhWHBpakFD?=
 =?utf-8?B?UktvbUxFbDZFMktKNHlaeEFFYmtYcENEbllkU09RUWlXRm5rUDBISmEvbGVp?=
 =?utf-8?B?dTFLZlR2aENwZklzYWszeXBDelRpc3NrdWt4VXVJL1k0SjhMRWI5NDhsQW1M?=
 =?utf-8?B?Tm1hNlVSQ3RmOGNrWXQrNUg3ZWJzV3lVNzFYc0t1bFo1eTVqMmFra2wvUGZu?=
 =?utf-8?B?cW5hbWNheWppYm1jei9jNDZBQ2psdEVEQ3pKTHRDNU5SNm04QkpFejZxemtF?=
 =?utf-8?B?OUJRZWRDWlJxNUJrSUFZNkcrYXdjRmJzak81OGpUUys5V3Z6alBkLzdoR25w?=
 =?utf-8?B?M3pzN2xoZjQrT0ZwUHpacFZDVk5CekFEeVNVWW0vc1Q0MFByTGFlblFXTEw3?=
 =?utf-8?B?emtxd1dCQUVIdHRvWSt6NTB6Y1FFZk9XeGdtejQ4Qi8ydE9Gay9MUXlVais2?=
 =?utf-8?B?UGo4TWNNSkJ6eG5vZU4xL09oVEF6TkdDdE1aQm9qQ3ZNazh0RjN2M2VVMW1Z?=
 =?utf-8?B?ZzdMcmFrVHA4YkdBSUlWSXRQdVk2U1gwbHZXT3BoMHdUMTFYVGFPQ3hyUzZY?=
 =?utf-8?B?cFc5b3UxdFVUMDFYVnpkMFN3R2hRTDVxNytEQWdOVnY4VFJMcU9nRkpOOVlJ?=
 =?utf-8?B?cndyaEZjNHZnbEJ4czBsOVpDbm5RaGo3RmUwdHFrUlZRc28vMGNBdlpUMGpq?=
 =?utf-8?B?NVBjZll3bmRJSWdYQldLd2IvTnRncVVMMENvRVR6akIxSFRvVDNpR3RmbXJP?=
 =?utf-8?B?cE1hWnBaZEtiVEJKQ2RtcWU1V1RSeitsM1FvcytWL1JFZVQrMno5RGdQN1Jz?=
 =?utf-8?B?QXk0c1Fxa09RVDZISVJ3R1hENVI4K2o1L0N2REdOM1ZhRjA5V3BvbWRoM2ow?=
 =?utf-8?B?b2hkSkJaS3pPNkdwc0MwZ1hVazhNSE5TUjJ6UjFrbmlHYTJHRjFldk44OFYx?=
 =?utf-8?B?NyswdnR1aFVvdnBoSUwzeUF0UWtXLy9oS3l6OUd6TW55ODZweFk3QVJxTm90?=
 =?utf-8?B?enJmb09tQ1cyUW91ZDZsM3p6Qkx6ZmxkU3JyeUxWUkNSTFcxOUVHUzZaUGpB?=
 =?utf-8?B?aG5NdGRlVWhFUHY5TlB4SFI2T0h3PT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <AED2B1A18CCBE2409E23E90DCC174DF8@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c924a774-f285-4cd4-e2fe-08d9f0d6eb64
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Feb 2022 23:00:11.1623
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: dIHWOQdoZ78tz5bCkXOhxsPeoZJZsiFQmKHup09beB7mrMS/4EsJL3xcyVJlwI6Qh8HkDVhG3CW3YLLR0hfluSOGJHnIqK/WzPsDbITmqPE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB6046
X-OriginatorOrg: citrix.com

T24gMTUvMDIvMjAyMiAxNjo1MywgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDE0LjAyLjIwMjIg
MTM6NTEsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBVRUZJIFJ1bnRpbWUgc2VydmljZXMsIGF0
IHRoZSB0aW1lIG9mIHdyaXRpbmcsIGFyZW4ndCBDRVQtSUJUIGNvbXBhdGlibGUuDQo+PiBXb3Jr
IGlzIG9uZ29pbmcgdG8gYWRkcmVzcyB0aGlzLiBJbiB0aGUgbWVhbnRpbWUsIHVuY29uZGl0aW9u
YWxseSBkaXNhYmxlIElCVC4NCj4+DQo+PiBTaWduZWQtb2ZmLWJ5OiBBbmRyZXcgQ29vcGVyIDxh
bmRyZXcuY29vcGVyM0BjaXRyaXguY29tPg0KPiBSZXZpZXdlZC1ieTogSmFuIEJldWxpY2ggPGpi
ZXVsaWNoQHN1c2UuY29tPg0KDQpUaGFua3MuDQoNCj4NCj4+IC0tLSBhL3hlbi9jb21tb24vZWZp
L3J1bnRpbWUuYw0KPj4gKysrIGIveGVuL2NvbW1vbi9lZmkvcnVudGltZS5jDQo+PiBAQCAtMjEs
NiArMjEsNyBAQCBzdHJ1Y3QgZWZpX3JzX3N0YXRlIHsNCj4+ICAgICogZG9uJ3Qgc3RyaWN0bHkg
bmVlZCB0aGF0Lg0KPj4gICAgKi8NCj4+ICAgdW5zaWduZWQgbG9uZyBfX2FsaWduZWQoMzIpIGNy
MzsNCj4+ICsgICAgdW5zaWduZWQgbG9uZyBtc3Jfc19jZXQ7DQo+PiAgI2VuZGlmDQo+PiAgfTsN
Cj4gVGhlIGxhdGVzdCB3aXRoIHRoZSBuZXh0IGFkZGl0aW9uIGhlcmUgd2Ugd2lsbCBwcm9iYWJs
eSB3YW50IHRvIC4uLg0KPg0KPj4gQEAgLTExMyw2ICsxMTQsMTkgQEAgc3RydWN0IGVmaV9yc19z
dGF0ZSBlZmlfcnNfZW50ZXIodm9pZCkNCj4gLi4uIG5vIGxvbmdlciBoYXZlIHRoaXMgYmUgdGhl
IGZ1bmN0aW9uJ3MgcmV0dXJuIHR5cGUuDQoNClNvIGFib3V0IHRoaXMuDQoNCndoeSBhcmVuJ3Qg
d2UgdXNpbmcgX19hdHRyaWJ1dGVfXygoZm9yY2VfYWxpZ25fYXJnX3BvaW50ZXIpKSA/wqAgSXQN
CmV4aXN0cyBpbiBhdCBsZWFzdCBHQ0MgNC4xIGFuZCBDbGFuZyA2Lg0KDQpXZSdyZSB3YXkgd2F5
IG92ZXJkdWUgYnVtcGluZyB0aGUgbWluaW11bSB0b29sY2hhaW4gdmVyc2lvbnMsIGFuZCBDbGFu
Zw0KMy41PT42IGlzIHN0aWxsIHZlcnkgb2Jzb2xldGUgbWluaW11bSB2ZXJzaW9uLsKgIFRoaXMg
d2F5LCB3ZSdyZSBub3QNCmRlcGVuZGluZyBvbiBzb21lIHZlcnkgc3VidGxlIEFCSSBtZWNoYW5p
Y3MgdG8gdHJ5IGFuZCBrZWVwIHRoZSBzdGFjaw0KcHJvcGVybHkgYWxpZ25lZC4NCg0KfkFuZHJl
dw0K


From xen-devel-bounces@lists.xenproject.org Tue Feb 15 23:04:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 15 Feb 2022 23:04:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273602.468852 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nK6rq-0005HS-5g; Tue, 15 Feb 2022 23:04:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273602.468852; Tue, 15 Feb 2022 23:04:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nK6rq-0005HL-2c; Tue, 15 Feb 2022 23:04:18 +0000
Received: by outflank-mailman (input) for mailman id 273602;
 Tue, 15 Feb 2022 23:04:17 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nK6rp-0005HB-7c; Tue, 15 Feb 2022 23:04:17 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nK6rp-00048c-4I; Tue, 15 Feb 2022 23:04:17 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nK6ro-0007IW-JA; Tue, 15 Feb 2022 23:04:16 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nK6ro-0003Gm-Ij; Tue, 15 Feb 2022 23:04:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=D8SeRAxHZoQkxE0XYyTv4n26e4vRvOAC5tvRtSQlBAc=; b=sxHaUHraSE9Y7weUzmJ+EvL6lz
	rY4qz7hFibwPBNCN3HFOPeYfZl1NwbLrI1OimtFUKIdUwWP7SC/oWvJRBjhRhaPSTe/b9AXj9jIn8
	OxRem48jDdBkO8T1GfFssg9xHivYYcfLrs+XVao9hfPs0UcMFF98AIgkBETLCWUcwSXw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168120-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 168120: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=e56d873f0ed9f7ed35b40cc1be841bf7f22db690
X-Osstest-Versions-That:
    qemuu=2d88a3a595f1094e3ecc6cd2fd1e804634c84b0f
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 15 Feb 2022 23:04:16 +0000

flight 168120 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168120/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168114
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168114
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168114
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168114
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168114
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168114
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168114
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168114
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 qemuu                e56d873f0ed9f7ed35b40cc1be841bf7f22db690
baseline version:
 qemuu                2d88a3a595f1094e3ecc6cd2fd1e804634c84b0f

Last test of basis   168114  2022-02-14 23:09:51 Z    0 days
Testing same since   168120  2022-02-15 14:08:16 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Jason Wang <jasowang@redhat.com>
  Lei Rao <lei.rao@intel.com>
  Nick Hudson <skrll@netbsd.org>
  Peter Foley <pefoley@google.com>
  Peter Maydell <peter.maydell@linaro.org>
  Philippe Mathieu-Daudé <philmd@redhat.com>
  Rao Lei <lei.rao@intel.com>
  Thomas Jansen <mithi@mithi.net>
  Zhang Chen <chen.zhang@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   2d88a3a595..e56d873f0e  e56d873f0ed9f7ed35b40cc1be841bf7f22db690 -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Wed Feb 16 02:11:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 02:11:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273616.468864 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nK9mn-00007g-T2; Wed, 16 Feb 2022 02:11:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273616.468864; Wed, 16 Feb 2022 02:11:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nK9mn-00007Z-OL; Wed, 16 Feb 2022 02:11:17 +0000
Received: by outflank-mailman (input) for mailman id 273616;
 Wed, 16 Feb 2022 02:11:16 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nK9mm-00007O-3x; Wed, 16 Feb 2022 02:11:16 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nK9mm-0002kW-1M; Wed, 16 Feb 2022 02:11:16 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nK9ml-0006wJ-He; Wed, 16 Feb 2022 02:11:15 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nK9ml-0003yj-HC; Wed, 16 Feb 2022 02:11:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=3H7QpK9pps0TFwurBdrc9tc/+BgDN6Tspc/GGmfJX8c=; b=4AxgOTus0Ud9/8aVwAaAorvjA6
	78DZHA+ZTJvRJn0BuXHcvIM6nLs6b94UAssaFP9G44ShfFBzVABtuS9RnApAv2KmZxbRHPX+3GIk2
	R3E6PD7Y3fJZIQAWpCk1MK1cjGZMKeGWOqzMki3yNvCCg/IDait7RkQWJ0wAYglv1nVg=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168122-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 168122: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=e7c2017cf4a91ab6a0fea6adca2d9dd2ab1603b0
X-Osstest-Versions-That:
    xen=94334d854bd358bd1d9c61d5e3306e4d903b120b
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 16 Feb 2022 02:11:15 +0000

flight 168122 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168122/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  e7c2017cf4a91ab6a0fea6adca2d9dd2ab1603b0
baseline version:
 xen                  94334d854bd358bd1d9c61d5e3306e4d903b120b

Last test of basis   168110  2022-02-14 10:00:43 Z    1 days
Testing same since   168122  2022-02-15 21:01:44 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Stefano Stabellini <sstabellini@kernel.org>
  Stefano Stabellini <stefano.stabellini@xilinx.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   94334d854b..e7c2017cf4  e7c2017cf4a91ab6a0fea6adca2d9dd2ab1603b0 -> smoke


From xen-devel-bounces@lists.xenproject.org Wed Feb 16 02:46:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 02:46:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273636.468875 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKAKa-0003TB-Mo; Wed, 16 Feb 2022 02:46:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273636.468875; Wed, 16 Feb 2022 02:46:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKAKa-0003T4-Ia; Wed, 16 Feb 2022 02:46:12 +0000
Received: by outflank-mailman (input) for mailman id 273636;
 Wed, 16 Feb 2022 02:46:12 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7gZM=S7=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nKAKa-0003Sy-1R
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 02:46:12 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9387b3e3-8ed2-11ec-b215-9bbe72dcb22c;
 Wed, 16 Feb 2022 03:46:02 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 9DB7D6183D;
 Wed, 16 Feb 2022 02:46:00 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 790C5C340EB;
 Wed, 16 Feb 2022 02:45:59 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9387b3e3-8ed2-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1644979560;
	bh=ggXUe6rKOUF5lPIf4uf2zcbkavucVhB0YDq8wqfS9rI=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=kBIztSH2o0TeWTdLEuWffJueBiV99d8LE3O7TxeHQz5VLZriifh1M1wYsiGYOtp34
	 a9mwVklUJfqqOm5//W9ywN7lVXrC6Ncw/6+2KYrp2gCUN4b4uZUO6BVUX4rOL6LNvz
	 WPDQ47c7pJHHzYQ/uYXeUpal9tFkex/u/HKdJ2638rm6hpBDzBCdRMoraod3WBMn87
	 XsH8tjSIefoJOXaDfPLMsonoN+wbeyD/k8t9szCXRwTjNiM5bNb8LZGE/YuPaMVzou
	 2iYCqHX3U9mJhBm3vDXZ3/MVFqRdZO6iK8gADNd/01+MZSNdk65KASk9eYACMOanF2
	 vbxXlliP01BtQ==
Date: Tue, 15 Feb 2022 18:45:59 -0800 (PST)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Luca Fancellu <luca.fancellu@arm.com>
cc: xen-devel@lists.xenproject.org, wei.chen@arm.com, 
    Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Bertrand Marquis <bertrand.marquis@arm.com>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, 
    Wei Liu <wl@xen.org>, Juergen Gross <jgross@suse.com>, 
    Dario Faggioli <dfaggioli@suse.com>
Subject: Re: [PATCH 4/5] xen/cpupool: Create different cpupools at boot
 time
In-Reply-To: <20220215101551.23101-5-luca.fancellu@arm.com>
Message-ID: <alpine.DEB.2.22.394.2202151827380.43738@ubuntu-linux-20-04-desktop>
References: <20220215101551.23101-1-luca.fancellu@arm.com> <20220215101551.23101-5-luca.fancellu@arm.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Tue, 15 Feb 2022, Luca Fancellu wrote:
> Introduce an architecture specific way to create different cpupools
> at boot time, this is particularly useful on ARM big.LITTLE system
> where there might be the need to have different cpupools for each type
> of core, but also systems using NUMA can have different cpu pools for
> each node.
> 
> The feature on arm relies on a specification of the cpupools from the
> device tree to build pools and assign cpus to them.
> 
> Documentation is created to explain the feature.
> 
> Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
> ---
>  docs/misc/arm/device-tree/cpupools.txt | 118 +++++++++++++++++++++++++
>  xen/arch/arm/Kconfig                   |   9 ++
>  xen/arch/arm/Makefile                  |   1 +
>  xen/arch/arm/cpupool.c                 | 118 +++++++++++++++++++++++++
>  xen/common/sched/cpupool.c             |   4 +-
>  xen/include/xen/sched.h                |  11 +++
>  6 files changed, 260 insertions(+), 1 deletion(-)
>  create mode 100644 docs/misc/arm/device-tree/cpupools.txt
>  create mode 100644 xen/arch/arm/cpupool.c
> 
> diff --git a/docs/misc/arm/device-tree/cpupools.txt b/docs/misc/arm/device-tree/cpupools.txt
> new file mode 100644
> index 000000000000..7298b6394332
> --- /dev/null
> +++ b/docs/misc/arm/device-tree/cpupools.txt
> @@ -0,0 +1,118 @@
> +Boot time cpupools
> +==================
> +
> +On arm, when BOOT_TIME_CPUPOOLS is enabled in the Xen configuration, it is
> +possible to create cpupools during boot phase by specifying them in the device
> +tree.
> +
> +Cpupools specification nodes shall be direct childs of /chosen node.
> +Each cpupool node contains the following properties:
> +
> +- compatible (mandatory)
> +
> +    Must always include the compatiblity string: "xen,cpupool".
> +
> +- cpupool-id (mandatory)
> +
> +    Must be a positive integer number.

Why is cpupool-id mandatory? It looks like it could be generated by Xen.
Or is it actually better to have the user specify it anyway?


> +- cpupool-cpus (mandatory)
> +
> +    Must be a list of device tree phandle to nodes describing cpus (e.g. having
> +    device_type = "cpu"), it can't be empty.
> +
> +- cpupool-sched (optional)
> +
> +    Must be a string having the name of a Xen scheduler, it has no effect when
> +    used in conjunction of a cpupool-id equal to zero, in that case the
> +    default Xen scheduler is selected (sched=<...> boot argument).

I don't get why cpupool-id == 0 should trigger a special cpupool-sched
behavior.


> +Constraints
> +===========
> +
> +The cpupool with id zero is implicitly created even if not specified, that pool
> +must have at least one cpu assigned, otherwise Xen will stop.
> +
> +Every cpu brought up by Xen will be assigned to the cpupool with id zero if it's
> +not assigned to any other cpupool.
> +
> +If a cpu is assigned to a cpupool, but it's not brought up correctly, Xen will
> +stop.

Thank you for documenting the constraints, but why do we have them?
Imagine a user specifying 3 cpu pools and imagine the cpupool-id is
optional and missing. We could take care of the cpupool-id generation in
Xen and we could also assign the default scheduler everywhere
cpupool-sched is not specified. Maybe I am missing something?

Does cpupool0 has to exist? I guess the answer could be yes, but if it
is specified as id of one of the pools we are fine, otherwise it could
be automatically generated by Xen.

In any case, I don't think that cpupool0 has to have the default
scheduler?

My suggestion would be:

- make cpupool-id optional
- assign automatically cpupool-ids starting from 0
    - respect cpupool-ids chosen by the user
- if some CPUs are left out (not specified in any pool) add an extra cpupool
    - the extra cpupool doesn't have to be cpupool-id == 0, it could be
      cpupool-id == n
    - the extra cpupool uses the default scheduler

If the user created cpupools in device tree covering all CPUs and also
specified all cpupool-ids everywhere, and none of them are 0 (no cpupool
in the system is cpupool0) then panic. (Assuming that cpupool0 is
required.)


> +Examples
> +========
> +
> +A system having two types of core, the following device tree specification will
> +instruct Xen to have two cpupools:
> +
> +- The cpupool with id 0 will have 4 cpus assigned.
> +- The cpupool with id 1 will have 2 cpus assigned.
> +
> +As can be seen from the example, cpupool_a has only two cpus assigned, but since
> +there are two cpus unassigned, they are automatically assigned to cpupool with
> +id zero. The following example can work only if hmp-unsafe=1 is passed to Xen
> +boot arguments, otherwise not all cores will be brought up by Xen and the
> +cpupool creation process will stop Xen.
> +
> +
> +a72_1: cpu@0 {
> +        compatible = "arm,cortex-a72";
> +        reg = <0x0 0x0>;
> +        device_type = "cpu";
> +        [...]
> +};
> +
> +a72_2: cpu@1 {
> +        compatible = "arm,cortex-a72";
> +        reg = <0x0 0x1>;
> +        device_type = "cpu";
> +        [...]
> +};
> +
> +a53_1: cpu@100 {
> +        compatible = "arm,cortex-a53";
> +        reg = <0x0 0x100>;
> +        device_type = "cpu";
> +        [...]
> +};
> +
> +a53_2: cpu@101 {
> +        compatible = "arm,cortex-a53";
> +        reg = <0x0 0x101>;
> +        device_type = "cpu";
> +        [...]
> +};
> +
> +cpu@102 {
> +        compatible = "arm,cortex-a53";
> +        reg = <0x0 0x102>;
> +        device_type = "cpu";
> +        [...]
> +};
> +
> +cpu@103 {
> +        compatible = "arm,cortex-a53";
> +        reg = <0x0 0x103>;
> +        device_type = "cpu";
> +        [...]
> +};
> +
> +chosen {
> +
> +    cpupool_a {
> +        compatible = "xen,cpupool";
> +        cpupool-id = <0>;
> +        cpupool-cpus = <&a53_1 &a53_2>;
> +    };
> +    cpupool_b {
> +        compatible = "xen,cpupool";
> +        cpupool-id = <1>;
> +        cpupool-cpus = <&a72_1 &a72_2>;
> +        cpupool-sched = "credit2";
> +    };

Question above notwithstanding, I like it!


> +    [...]
> +
> +};
> diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
> index ecfa6822e4d3..64c2879513b7 100644
> --- a/xen/arch/arm/Kconfig
> +++ b/xen/arch/arm/Kconfig
> @@ -33,6 +33,15 @@ config ACPI
>  	  Advanced Configuration and Power Interface (ACPI) support for Xen is
>  	  an alternative to device tree on ARM64.
>  
> +config BOOT_TIME_CPUPOOLS
> +	bool "Create cpupools at boot time"
> +	depends on ARM
> +	default n
> +	help
> +
> +	  Creates cpupools during boot time and assigns cpus to them. Cpupools
> +	  options can be specified in the device tree.
> +
>  config GICV3
>  	bool "GICv3 driver"
>  	depends on ARM_64 && !NEW_VGIC
> diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile
> index d0dee10102b6..6165da4e77b4 100644
> --- a/xen/arch/arm/Makefile
> +++ b/xen/arch/arm/Makefile
> @@ -13,6 +13,7 @@ obj-$(CONFIG_HAS_ALTERNATIVE) += alternative.o
>  obj-y += bootfdt.init.o
>  obj-y += cpuerrata.o
>  obj-y += cpufeature.o
> +obj-$(CONFIG_BOOT_TIME_CPUPOOLS) += cpupool.o
>  obj-y += decode.o
>  obj-y += device.o
>  obj-$(CONFIG_IOREQ_SERVER) += dm.o
> diff --git a/xen/arch/arm/cpupool.c b/xen/arch/arm/cpupool.c
> new file mode 100644
> index 000000000000..a9d5b94635b9
> --- /dev/null
> +++ b/xen/arch/arm/cpupool.c
> @@ -0,0 +1,118 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * xen/arch/arm/cpupool.c
> + *
> + * Code to create cpupools at boot time for arm architecture.
> + *
> + * Copyright (C) 2022 Arm Ltd.
> + */
> +
> +#include <xen/sched.h>
> +
> +static struct cpupool *__initdata pool_cpu_map[NR_CPUS];
> +
> +void __init arch_allocate_cpupools(const cpumask_t *cpu_online_map)
> +{
> +    const struct dt_device_node *chosen, *node;
> +    unsigned int cpu_num, cpupool0_cpu_count = 0;
> +    cpumask_t cpus_to_assign;
> +
> +    chosen = dt_find_node_by_path("/chosen");
> +    if ( !chosen )
> +        return;
> +
> +    cpumask_copy(&cpus_to_assign, cpu_online_map);
> +
> +    dt_for_each_child_node(chosen, node)
> +    {
> +        const struct dt_device_node *cpu_node;
> +        unsigned int pool_id;
> +        int i = 0, sched_id = -1;
> +        const char* scheduler_name;
> +        struct cpupool *pool = cpupool0;
> +
> +        if ( !dt_device_is_compatible(node, "xen,cpupool") )
> +            continue;
> +
> +        if ( !dt_property_read_u32(node, "cpupool-id", &pool_id) )
> +            panic("Missing cpupool-id property!\n");
> +
> +        if ( !dt_property_read_string(node, "cpupool-sched", &scheduler_name) )
> +        {
> +            sched_id = sched_get_id_by_name(scheduler_name);
> +            if ( sched_id < 0 )
> +                panic("Scheduler %s does not exists!\n", scheduler_name);
> +        }
> +
> +        if ( pool_id )
> +        {
> +            pool = cpupool_create_pool(pool_id, sched_id);
> +            if ( !pool )
> +                panic("Error creating pool id %u!\n", pool_id);
> +        }
> +
> +        cpu_node = dt_parse_phandle(node, "cpupool-cpus", 0);
> +        if ( !cpu_node )
> +            panic("Missing or empty cpupool-cpus property!\n");
> +
> +        while ( cpu_node )
> +        {
> +            register_t cpu_reg;
> +            const __be32 *prop;
> +
> +            prop = dt_get_property(cpu_node, "reg", NULL);
> +            if ( !prop )
> +                panic("cpupool-cpus pointed node has no reg property!\n");
> +
> +            cpu_reg = dt_read_number(prop, dt_n_addr_cells(cpu_node));
> +
> +            /* Check if the cpu is online and in the set to be assigned */
> +            for_each_cpu ( cpu_num, &cpus_to_assign )
> +                if ( cpu_logical_map(cpu_num) == cpu_reg )
> +                    break;
> +
> +            if ( cpu_num >= nr_cpu_ids )
> +                panic("Cpu found in %s is not online or it's assigned twice!\n",
> +                      dt_node_name(node));
> +
> +            pool_cpu_map[cpu_num] = pool;
> +            cpumask_clear_cpu(cpu_num, &cpus_to_assign);
> +
> +            printk(XENLOG_INFO "CPU with MPIDR %"PRIregister" in Pool-%u.\n",
> +                   cpu_reg, pool_id);
> +
> +            /* Keep track of how many cpus are assigned to Pool-0 */
> +            if ( !pool_id )
> +                cpupool0_cpu_count++;
> +
> +            cpu_node = dt_parse_phandle(node, "cpupool-cpus", ++i);
> +        }
> +    }
> +
> +    /* Assign every non assigned cpu to Pool-0 */
> +    for_each_cpu ( cpu_num, &cpus_to_assign )
> +    {
> +        pool_cpu_map[cpu_num] = cpupool0;
> +        cpupool0_cpu_count++;
> +        printk(XENLOG_INFO "CPU with MPIDR %"PRIregister" in Pool-0.\n",
> +               cpu_logical_map(cpu_num));
> +    }
> +
> +    if ( !cpupool0_cpu_count )
> +        panic("No cpu assigned to cpupool0!\n");
> +}
> +
> +struct cpupool *__init arch_get_cpupool(unsigned int cpu)
> +{
> +    return pool_cpu_map[cpu];
> +}
> +
> +/*
> + * Local variables:
> + * mode: C
> + * c-file-style: "BSD"
> + * c-basic-offset: 4
> + * tab-width: 4
> + * indent-tabs-mode: nil
> + * End:
> + */
> diff --git a/xen/common/sched/cpupool.c b/xen/common/sched/cpupool.c
> index 4da12528d6b9..6013d75e2edd 100644
> --- a/xen/common/sched/cpupool.c
> +++ b/xen/common/sched/cpupool.c
> @@ -1257,12 +1257,14 @@ static int __init cpupool_init(void)
>      cpupool_put(cpupool0);
>      register_cpu_notifier(&cpu_nfb);
>  
> +    arch_allocate_cpupools(&cpu_online_map);
> +
>      spin_lock(&cpupool_lock);
>  
>      cpumask_copy(&cpupool_free_cpus, &cpu_online_map);
>  
>      for_each_cpu ( cpu, &cpupool_free_cpus )
> -        cpupool_assign_cpu_locked(cpupool0, cpu);
> +        cpupool_assign_cpu_locked(arch_get_cpupool(cpu), cpu);
>  
>      spin_unlock(&cpupool_lock);
>  
> diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
> index a67a9eb2fe9d..dda7db2ba51f 100644
> --- a/xen/include/xen/sched.h
> +++ b/xen/include/xen/sched.h
> @@ -1177,6 +1177,17 @@ extern void dump_runq(unsigned char key);
>  
>  void arch_do_physinfo(struct xen_sysctl_physinfo *pi);
>  
> +#ifdef CONFIG_BOOT_TIME_CPUPOOLS
> +void arch_allocate_cpupools(const cpumask_t *cpu_online_map);
> +struct cpupool *arch_get_cpupool(unsigned int cpu);
> +#else
> +static inline void arch_allocate_cpupools(const cpumask_t *cpu_online_map) {}
> +static inline struct cpupool *arch_get_cpupool(unsigned int cpu)
> +{
> +    return cpupool0;
> +}
> +#endif
> +
>  #endif /* __SCHED_H__ */
>  
>  /*
> -- 
> 2.17.1
> 


From xen-devel-bounces@lists.xenproject.org Wed Feb 16 03:46:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 03:46:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273647.468888 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKBGm-00014p-9h; Wed, 16 Feb 2022 03:46:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273647.468888; Wed, 16 Feb 2022 03:46:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKBGm-00014i-6g; Wed, 16 Feb 2022 03:46:20 +0000
Received: by outflank-mailman (input) for mailman id 273647;
 Wed, 16 Feb 2022 03:46:18 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7gZM=S7=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nKBGk-00014c-HH
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 03:46:18 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id fe083a30-8eda-11ec-b215-9bbe72dcb22c;
 Wed, 16 Feb 2022 04:46:16 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 5550C618DC;
 Wed, 16 Feb 2022 03:46:15 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5380FC004E1;
 Wed, 16 Feb 2022 03:46:14 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fe083a30-8eda-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1644983174;
	bh=zDCx7Z12JnUoqx4oqbxMm3oeRe3hM8SHBDB4ZWLVdCI=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=soeb/S2jkZTzDfoi3yW2Z075mauUG5n9wZU8gRsBjssggs93HNHaY78H8L2Aq3OYC
	 A5JKEpVZ2jibHLjL7QjOD+ct6XMjo+EhppiFEjnsH/5B0tlg+WtcHphWpcAfr4Mlh9
	 5NCfVpi8C08J6Iek/XosyMnYpBKnPlpPQax3UHv5jzbjMTdcp5K6SwWu2GLFrCDgKH
	 V/31vfnJZjamdtNH0GuC9Ds0WD0aM/WL55EA3S219MxqwHOlNDgP2EvBfaafBAZFSK
	 502BofdVxim0ZRy0zld6oopaBpT7hzrVDMzxBEFwGw8DbCYsWP9NBkmGQEWQQHhfM5
	 iNzfHi6pnEXZQ==
Date: Tue, 15 Feb 2022 19:46:14 -0800 (PST)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Julien Grall <julien@xen.org>
cc: Andrew Cooper <andrew.cooper3@citrix.com>, 
    Xen-devel <xen-devel@lists.xenproject.org>, 
    Jan Beulich <JBeulich@suse.com>, 
    =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>, 
    Wei Liu <wl@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Bertrand Marquis <bertrand.marquis@arm.com>
Subject: Re: [PATCH v2 02/70] xen/sort: Switch to an extern inline
 implementation
In-Reply-To: <70824a0c-cc48-b064-695c-35c2d06c0ad1@xen.org>
Message-ID: <alpine.DEB.2.22.394.2202151800230.43738@ubuntu-linux-20-04-desktop>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com> <20220214125127.17985-3-andrew.cooper3@citrix.com> <70824a0c-cc48-b064-695c-35c2d06c0ad1@xen.org>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Mon, 14 Feb 2022, Julien Grall wrote:
> On 14/02/2022 12:50, Andrew Cooper wrote:
> > There are exactly 3 callers of sort() in the hypervisor.  Callbacks in a
> > tight
> > loop like this are problematic for performance, especially with Spectre v2
> > protections, which is why extern inline is used commonly by libraries.
> > 
> > Both ARM callers pass in NULL for the swap function, and while this might
> > seem
> > like an attractive option at first, it causes generic_swap() to be used,
> > which
> > forced a byte-wise copy.  Provide real swap functions so the compiler can
> > optimise properly, which is very important for ARM downstreams where
> > milliseconds until the system is up matters.
> 
> Did you actually benchmark it? Both those lists will have < 128 elements in
> them. So I would be extremely surprised if you save more than a few hundreds
> microseconds with this approach.
> 
> So, my opinion on this approach hasn't changed. On v1, we discussed an
> approach that would suit both Stefano and I. Jan seemed to confirm that would
> also suit x86.


This patch series has become 70 patches and for the sake of helping
Andrew move forward in the quickest and most painless way possible, I
append the following using generic_swap as static inline.

Julien, Bertrand, is that acceptable to you?

Andrew, I know this is not your favorite approach but you have quite a
lot of changes to handle -- probably not worth focussing on one detail
which is pretty minor?


---
xen/sort: Switch to an extern inline implementation

There are exactly 3 callers of sort() in the hypervisor.  Callbacks in a tight
loop like this are problematic for performance, especially with Spectre v2
protections, which is why extern inline is used commonly by libraries.

Make generic_swap() a static inline and used it at the two ARM call
sites.

No functional change.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
---
 xen/arch/arm/bootfdt.c |  2 +-
 xen/arch/arm/io.c      |  2 +-
 xen/include/xen/sort.h | 67 ++++++++++++++++++++++++++++++++++-
 xen/lib/sort.c         | 80 ++----------------------------------------
 4 files changed, 70 insertions(+), 81 deletions(-)

diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c
index afaa0e249b..0d62945d56 100644
--- a/xen/arch/arm/bootfdt.c
+++ b/xen/arch/arm/bootfdt.c
@@ -472,7 +472,7 @@ size_t __init boot_fdt_info(const void *fdt, paddr_t paddr)
      * the banks sorted in ascending order. So sort them through.
      */
     sort(bootinfo.mem.bank, bootinfo.mem.nr_banks, sizeof(struct membank),
-         cmp_memory_node, NULL);
+         cmp_memory_node, generic_swap);
 
     early_print_info();
 
diff --git a/xen/arch/arm/io.c b/xen/arch/arm/io.c
index 729287e37c..1f35aaeea6 100644
--- a/xen/arch/arm/io.c
+++ b/xen/arch/arm/io.c
@@ -170,7 +170,7 @@ void register_mmio_handler(struct domain *d,
 
     /* Sort mmio handlers in ascending order based on base address */
     sort(vmmio->handlers, vmmio->num_entries, sizeof(struct mmio_handler),
-         cmp_mmio_handler, NULL);
+         cmp_mmio_handler, generic_swap);
 
     write_unlock(&vmmio->lock);
 }
diff --git a/xen/include/xen/sort.h b/xen/include/xen/sort.h
index a403652948..f6065eda58 100644
--- a/xen/include/xen/sort.h
+++ b/xen/include/xen/sort.h
@@ -3,8 +3,73 @@
 
 #include <xen/types.h>
 
+extern gnu_inline
+void generic_swap(void *a, void *b, size_t size)
+{
+    char t;
+
+    do {
+        t = *(char *)a;
+        *(char *)a++ = *(char *)b;
+        *(char *)b++ = t;
+    } while ( --size > 0 );
+}
+
+/*
+ * sort - sort an array of elements
+ * @base: pointer to data to sort
+ * @num: number of elements
+ * @size: size of each element
+ * @cmp: pointer to comparison function
+ * @swap: pointer to swap function or NULL
+ *
+ * This function does a heapsort on the given array. You may provide a
+ * swap function optimized to your element type.
+ *
+ * Sorting time is O(n log n) both on average and worst-case. While
+ * qsort is about 20% faster on average, it suffers from exploitable
+ * O(n*n) worst-case behavior and extra memory requirements that make
+ * it less suitable for kernel use.
+ */
+#ifndef SORT_IMPLEMENTATION
+extern gnu_inline
+#endif
 void sort(void *base, size_t num, size_t size,
           int (*cmp)(const void *, const void *),
-          void (*swap)(void *, void *, size_t));
+          void (*swap)(void *, void *, size_t))
+{
+    /* pre-scale counters for performance */
+    size_t i = (num / 2) * size, n = num * size, c, r;
+
+    /* heapify */
+    while ( i > 0 )
+    {
+        for ( r = i -= size; r * 2 + size < n; r = c )
+        {
+            c = r * 2 + size;
+            if ( (c < n - size) && (cmp(base + c, base + c + size) < 0) )
+                c += size;
+            if ( cmp(base + r, base + c) >= 0 )
+                break;
+            swap(base + r, base + c, size);
+        }
+    }
+
+    /* sort */
+    for ( i = n; i > 0; )
+    {
+        i -= size;
+        swap(base, base + i, size);
+        for ( r = 0; r * 2 + size < i; r = c )
+        {
+            c = r * 2 + size;
+            if ( (c < i - size) && (cmp(base + c, base + c + size) < 0) )
+                c += size;
+            if ( cmp(base + r, base + c) >= 0 )
+                break;
+            swap(base + r, base + c, size);
+        }
+    }
+}
 
 #endif /* __XEN_SORT_H__ */
diff --git a/xen/lib/sort.c b/xen/lib/sort.c
index 35ce0d7abd..b7e78cc0e8 100644
--- a/xen/lib/sort.c
+++ b/xen/lib/sort.c
@@ -4,81 +4,5 @@
  * Jan 23 2005  Matt Mackall <mpm@selenic.com>
  */
 
-#include <xen/types.h>
-
-static void u32_swap(void *a, void *b, size_t size)
-{
-    uint32_t t = *(uint32_t *)a;
-
-    *(uint32_t *)a = *(uint32_t *)b;
-    *(uint32_t *)b = t;
-}
-
-static void generic_swap(void *a, void *b, size_t size)
-{
-    char t;
-
-    do {
-        t = *(char *)a;
-        *(char *)a++ = *(char *)b;
-        *(char *)b++ = t;
-    } while ( --size > 0 );
-}
-
-/*
- * sort - sort an array of elements
- * @base: pointer to data to sort
- * @num: number of elements
- * @size: size of each element
- * @cmp: pointer to comparison function
- * @swap: pointer to swap function or NULL
- *
- * This function does a heapsort on the given array. You may provide a
- * swap function optimized to your element type.
- *
- * Sorting time is O(n log n) both on average and worst-case. While
- * qsort is about 20% faster on average, it suffers from exploitable
- * O(n*n) worst-case behavior and extra memory requirements that make
- * it less suitable for kernel use.
- */
-
-void sort(void *base, size_t num, size_t size,
-          int (*cmp)(const void *, const void *),
-          void (*swap)(void *, void *, size_t size))
-{
-    /* pre-scale counters for performance */
-    size_t i = (num / 2) * size, n = num * size, c, r;
-
-    if ( !swap )
-        swap = (size == 4 ? u32_swap : generic_swap);
-
-    /* heapify */
-    while ( i > 0 )
-    {
-        for ( r = i -= size; r * 2 + size < n; r = c )
-        {
-            c = r * 2 + size;
-            if ( (c < n - size) && (cmp(base + c, base + c + size) < 0) )
-                c += size;
-            if ( cmp(base + r, base + c) >= 0 )
-                break;
-            swap(base + r, base + c, size);
-        }
-    }
-
-    /* sort */
-    for ( i = n; i > 0; )
-    {
-        i -= size;
-        swap(base, base + i, size);
-        for ( r = 0; r * 2 + size < i; r = c )
-        {
-            c = r * 2 + size;
-            if ( (c < i - size) && (cmp(base + c, base + c + size) < 0) )
-                c += size;
-            if ( cmp(base + r, base + c) >= 0 )
-                break;
-            swap(base + r, base + c, size);
-        }
-    }
-}
+#define SORT_IMPLEMENTATION
+#include <xen/sort.h>
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Feb 16 04:01:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 04:01:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273654.468900 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKBVI-0003Qb-JT; Wed, 16 Feb 2022 04:01:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273654.468900; Wed, 16 Feb 2022 04:01:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKBVI-0003QU-GM; Wed, 16 Feb 2022 04:01:20 +0000
Received: by outflank-mailman (input) for mailman id 273654;
 Wed, 16 Feb 2022 04:01:20 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7gZM=S7=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nKBVI-0003QO-0F
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 04:01:20 +0000
Received: from sin.source.kernel.org (sin.source.kernel.org
 [2604:1380:40e1:4800::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 16d2ad0e-8edd-11ec-b215-9bbe72dcb22c;
 Wed, 16 Feb 2022 05:01:18 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by sin.source.kernel.org (Postfix) with ESMTPS id 599DDCE2422;
 Wed, 16 Feb 2022 04:01:15 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3BE83C004E1;
 Wed, 16 Feb 2022 04:01:13 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 16d2ad0e-8edd-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1644984073;
	bh=aLnkCMNhpAZFVqWPI81tWpFZcIhwIeUbovv+xTHVwGo=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=dO/BEeEFgfogH9UTPoJZdcDy3gi+pr63hn5ynj+MfpufCEquMcnj16y2V13YMshp4
	 3vV50qTF1SCpXkcV7UGGezhiUtg5UdAL6fmdktV08+YLw7L4oMizm3zneI9bU8o23+
	 lpqXMANhln+sM8qoM1P18NwHSv221VzU6GFStKUQLAA5LU+ixTFM/boNEqe/dE4Mvl
	 8ukrG6qsyQdDFPqE+xSuwJqbdBVFJhPYdAtcTYSx1jMDktIBsEjF09Q+pnKuDKRYId
	 Waq33NCl7yjslMKOD5EGmu9NbCvbnw34xARYBiYCTAT2aQI3IFkzR8qzNsc13a6MOn
	 EvzxB9sGnZrew==
Date: Tue, 15 Feb 2022 20:01:13 -0800 (PST)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Luca Fancellu <luca.fancellu@arm.com>
cc: xen-devel@lists.xenproject.org, wei.chen@arm.com, 
    Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Bertrand Marquis <bertrand.marquis@arm.com>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, 
    Wei Liu <wl@xen.org>, 
    =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>
Subject: Re: [PATCH 5/5] arm/dom0less: assign dom0less guests to cpupools
In-Reply-To: <20220215101551.23101-6-luca.fancellu@arm.com>
Message-ID: <alpine.DEB.2.22.394.2202151847440.43738@ubuntu-linux-20-04-desktop>
References: <20220215101551.23101-1-luca.fancellu@arm.com> <20220215101551.23101-6-luca.fancellu@arm.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Tue, 15 Feb 2022, Luca Fancellu wrote:
> Introduce domain-cpupool property of a xen,domain device tree node,
> that specifies the cpupool device tree handle of a xen,cpupool node
> that identifies a cpupool created at boot time where the guest will
> be assigned on creation.
> 
> Add member to the xen_arch_domainconfig public interface so the
> XEN_DOMCTL_INTERFACE_VERSION version is bumped.
> 
> Update documentation about the property.
> 
> Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
> ---
>  docs/misc/arm/device-tree/booting.txt | 5 +++++
>  xen/arch/arm/domain.c                 | 6 ++++++
>  xen/arch/arm/domain_build.c           | 9 ++++++++-
>  xen/arch/x86/domain.c                 | 6 ++++++
>  xen/common/domain.c                   | 5 ++++-
>  xen/include/public/arch-arm.h         | 2 ++
>  xen/include/public/domctl.h           | 2 +-
>  xen/include/xen/domain.h              | 3 +++
>  8 files changed, 35 insertions(+), 3 deletions(-)
> 
> diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt
> index 71895663a4de..0f1f210fa449 100644
> --- a/docs/misc/arm/device-tree/booting.txt
> +++ b/docs/misc/arm/device-tree/booting.txt
> @@ -182,6 +182,11 @@ with the following properties:
>      Both #address-cells and #size-cells need to be specified because
>      both sub-nodes (described shortly) have reg properties.
>  
> +- domain-cpupool
> +
> +    Optional. Handle to a xen,cpupool device tree node that identifies the
> +    cpupool where the guest will be started at boot.
> +
>  Under the "xen,domain" compatible node, one or more sub-nodes are present
>  for the DomU kernel and ramdisk.
>  
> diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
> index 92a6c509e5c5..be350b28b588 100644
> --- a/xen/arch/arm/domain.c
> +++ b/xen/arch/arm/domain.c
> @@ -788,6 +788,12 @@ fail:
>      return rc;
>  }
>  
> +unsigned int
> +arch_get_domain_cpupool_id(const struct xen_domctl_createdomain *config)
> +{
> +    return config->arch.cpupool_id;
> +}
> +
>  void arch_domain_destroy(struct domain *d)
>  {
>      /* IOMMU page table is shared with P2M, always call
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index 6931c022a2e8..4f239e756775 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -3015,7 +3015,8 @@ static int __init construct_domU(struct domain *d,
>  void __init create_domUs(void)
>  {
>      struct dt_device_node *node;
> -    const struct dt_device_node *chosen = dt_find_node_by_path("/chosen");
> +    const struct dt_device_node *cpupool_node,
> +                                *chosen = dt_find_node_by_path("/chosen");
>  
>      BUG_ON(chosen == NULL);
>      dt_for_each_child_node(chosen, node)
> @@ -3053,6 +3054,12 @@ void __init create_domUs(void)
>                                           GUEST_VPL011_SPI - 32 + 1);
>          }
>  
> +        /* Get the optional property domain-cpupool */
> +        cpupool_node = dt_parse_phandle(node, "domain-cpupool", 0);
> +        if ( cpupool_node )
> +            dt_property_read_u32(cpupool_node, "cpupool-id",
> +                                 &d_cfg.arch.cpupool_id);

Is this the reason to make "cpupool-id" mandatory in device tree? If so,
I think we can avoid it. Instead, we could:

- generate the cpupool-id in xen/arch/arm/cpupool.c
- keep track of cpupool-id <--> "cpupool name", where "cpupool name"
  is the node name in device tree (sibling node names are unique in
  device tree). (Alternatively we could use the phandle.) We could have
  a __initdata pool_names_map to convert cpupool names to cpupool-ids.
- here retrieve the cpupool_id from the cpupool node name


>          /*
>           * The variable max_init_domid is initialized with zero, so here it's
>           * very important to use the pre-increment operator to call
> diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c
> index ef1812dc1402..3e3cf88c9c82 100644
> --- a/xen/arch/x86/domain.c
> +++ b/xen/arch/x86/domain.c
> @@ -880,6 +880,12 @@ int arch_domain_create(struct domain *d,
>      return rc;
>  }
>  
> +unsigned int
> +arch_get_domain_cpupool_id(const struct xen_domctl_createdomain *config)
> +{
> +    return 0;
> +}
> +
>  void arch_domain_destroy(struct domain *d)
>  {
>      if ( is_hvm_domain(d) )
> diff --git a/xen/common/domain.c b/xen/common/domain.c
> index 2048ebad86ff..d42ca8292025 100644
> --- a/xen/common/domain.c
> +++ b/xen/common/domain.c
> @@ -665,6 +665,8 @@ struct domain *domain_create(domid_t domid,
>  
>      if ( !is_idle_domain(d) )
>      {
> +        unsigned int domain_cpupool_id;
> +
>          watchdog_domain_init(d);
>          init_status |= INIT_watchdog;
>  
> @@ -698,7 +700,8 @@ struct domain *domain_create(domid_t domid,
>          if ( !d->pbuf )
>              goto fail;
>  
> -        if ( (err = sched_init_domain(d, 0)) != 0 )
> +        domain_cpupool_id = arch_get_domain_cpupool_id(config);
> +        if ( (err = sched_init_domain(d, domain_cpupool_id)) != 0 )
>              goto fail;
>  
>          if ( (err = late_hwdom_init(d)) != 0 )
> diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
> index 94b31511ddea..2c5d1ea7f01a 100644
> --- a/xen/include/public/arch-arm.h
> +++ b/xen/include/public/arch-arm.h
> @@ -321,6 +321,8 @@ struct xen_arch_domainconfig {
>      uint16_t tee_type;
>      /* IN */
>      uint32_t nr_spis;
> +    /* IN */
> +    unsigned int cpupool_id;
>      /*
>       * OUT
>       * Based on the property clock-frequency in the DT timer node.
> diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
> index b85e6170b0aa..31ec083cb06e 100644
> --- a/xen/include/public/domctl.h
> +++ b/xen/include/public/domctl.h
> @@ -38,7 +38,7 @@
>  #include "hvm/save.h"
>  #include "memory.h"
>  
> -#define XEN_DOMCTL_INTERFACE_VERSION 0x00000014
> +#define XEN_DOMCTL_INTERFACE_VERSION 0x00000015
>  
>  /*
>   * NB. xen_domctl.domain is an IN/OUT parameter for this operation.
> diff --git a/xen/include/xen/domain.h b/xen/include/xen/domain.h
> index 160c8dbdab33..fb018871bc17 100644
> --- a/xen/include/xen/domain.h
> +++ b/xen/include/xen/domain.h
> @@ -63,6 +63,9 @@ void unmap_vcpu_info(struct vcpu *v);
>  int arch_domain_create(struct domain *d,
>                         struct xen_domctl_createdomain *config);
>  
> +unsigned int
> +arch_get_domain_cpupool_id(const struct xen_domctl_createdomain *config);
> +
>  void arch_domain_destroy(struct domain *d);
>  
>  void arch_domain_shutdown(struct domain *d);
> -- 
> 2.17.1
> 


From xen-devel-bounces@lists.xenproject.org Wed Feb 16 04:29:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 04:29:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273662.468911 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKBwg-00063k-PJ; Wed, 16 Feb 2022 04:29:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273662.468911; Wed, 16 Feb 2022 04:29:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKBwg-00063d-M5; Wed, 16 Feb 2022 04:29:38 +0000
Received: by outflank-mailman (input) for mailman id 273662;
 Wed, 16 Feb 2022 04:29:37 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nKBwf-00063T-LO; Wed, 16 Feb 2022 04:29:37 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nKBwf-0006Ga-Iq; Wed, 16 Feb 2022 04:29:37 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nKBwf-00053N-3u; Wed, 16 Feb 2022 04:29:37 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nKBwf-0003cR-3S; Wed, 16 Feb 2022 04:29:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=fvWdzWhtBVMn71XtUN5jzc/ltMSAbfb4/7te6fzvQkY=; b=RpKmQ30GUY1V3pDqrCKTdJvJ23
	dGg54A26BpJVtG/nS0oivXgpi7jSNNbfWiKeq88n5A12RwYMZeynOEMtDmXfJAvmQ0jgE6ACzL/hH
	/zxa+9nxROFb6H9dyb9s0lBOqOOQiqOYpsDPvMYN9TMrh+uYJ30X3kwDyHxTsCI/Ib3g=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168121-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 168121: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=705d84a366cfccda1e7aec1113a5399cd2ffee7d
X-Osstest-Versions-That:
    linux=d567f5db412ed52de0b3b3efca4a451263de6108
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 16 Feb 2022 04:29:37 +0000

flight 168121 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168121/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10       fail  like 168113
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168113
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168113
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168113
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168113
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168113
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168113
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168113
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168113
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                705d84a366cfccda1e7aec1113a5399cd2ffee7d
baseline version:
 linux                d567f5db412ed52de0b3b3efca4a451263de6108

Last test of basis   168113  2022-02-14 19:11:17 Z    1 days
Testing same since   168121  2022-02-15 17:42:38 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andy Shevchenko <andriy.shevchenko@linux.intel.com>
  Cai Huoqing <cai.huoqing@linux.dev>
  David Sterba <dsterba@suse.com>
  Dāvis Mosāns <davispuh@gmail.com>
  Filipe Manana <fdmanana@suse.com>
  Helge Deller <deller@gmx.de>
  John David Anglin <dave.anglin@bell.net>
  Linus Torvalds <torvalds@linux-foundation.org>
  Long Li <longli@microsoft.com>
  Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
  Miaoqian Lin <linmq006@gmail.com>
  Michael Kelley <mikelley@microsoft.com>
  Nathan Chancellor <nathan@kernel.org>
  Purna Pavan Chandra Aekkaladevi <paekkaladevi@microsoft.com>
  Qu Wenruo <wqu@suse.com>
  Randy Dunlap <rdunlap@infradead.org>
  Wei Liu <wei.liu@kernel.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   d567f5db412e..705d84a366cf  705d84a366cfccda1e7aec1113a5399cd2ffee7d -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Wed Feb 16 06:13:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 06:13:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273675.468922 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKDZ5-0008GI-PF; Wed, 16 Feb 2022 06:13:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273675.468922; Wed, 16 Feb 2022 06:13:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKDZ5-0008GB-M3; Wed, 16 Feb 2022 06:13:23 +0000
Received: by outflank-mailman (input) for mailman id 273675;
 Wed, 16 Feb 2022 06:13:21 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=BoLq=S7=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nKDZ3-0008G5-9f
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 06:13:21 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8935e0ac-8eef-11ec-8eb8-a37418f5ba1a;
 Wed, 16 Feb 2022 07:13:19 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id CF29121135;
 Wed, 16 Feb 2022 06:13:18 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A3C9813A3E;
 Wed, 16 Feb 2022 06:13:18 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id F3x3Jv6VDGJxGwAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 16 Feb 2022 06:13:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8935e0ac-8eef-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1644991998; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=VjIr01KmfBi8JXLJ0DZ7y+wj+HDdIgLiV68pwBKcPIU=;
	b=uDmODVZLDSRpJFReVLRj97nX8vzQAauUdiqln5sMTKlQgqZQwqVRL47vhqEob1U4RqKnAL
	0HM1oOCumhw68uQkBORSbY8a40PxsJXilbepIIETXZUUpVTluS145c7QuEe8AB3JKDGDAg
	pl3r0QF3KU+KtD0ROg+Zg1pujVPoqoY=
Message-ID: <8763ed2b-ce5d-12eb-1ea2-542e8024764b@suse.com>
Date: Wed, 16 Feb 2022 07:13:18 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Content-Language: en-US
To: Luca Fancellu <luca.fancellu@arm.com>
Cc: xen-devel@lists.xenproject.org, wei.chen@arm.com, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>
References: <20220215101551.23101-1-luca.fancellu@arm.com>
 <20220215101551.23101-2-luca.fancellu@arm.com>
 <efd968bb-e3f6-9e16-3826-4cab25127718@suse.com>
 <71460E15-5D09-4CE6-99ED-4858147BB0D0@arm.com>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH 1/5] tools/cpupools: Give a name to unnamed cpupools
In-Reply-To: <71460E15-5D09-4CE6-99ED-4858147BB0D0@arm.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------f8jLpR5yK0hQCSz6BGFTM4fn"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------f8jLpR5yK0hQCSz6BGFTM4fn
Content-Type: multipart/mixed; boundary="------------UoADL6uQTsce8rUFlf4S061d";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Luca Fancellu <luca.fancellu@arm.com>
Cc: xen-devel@lists.xenproject.org, wei.chen@arm.com, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>
Message-ID: <8763ed2b-ce5d-12eb-1ea2-542e8024764b@suse.com>
Subject: Re: [PATCH 1/5] tools/cpupools: Give a name to unnamed cpupools
References: <20220215101551.23101-1-luca.fancellu@arm.com>
 <20220215101551.23101-2-luca.fancellu@arm.com>
 <efd968bb-e3f6-9e16-3826-4cab25127718@suse.com>
 <71460E15-5D09-4CE6-99ED-4858147BB0D0@arm.com>
In-Reply-To: <71460E15-5D09-4CE6-99ED-4858147BB0D0@arm.com>

--------------UoADL6uQTsce8rUFlf4S061d
Content-Type: multipart/mixed; boundary="------------Ngf64dvZ52G9OR9qcytKDqUk"

--------------Ngf64dvZ52G9OR9qcytKDqUk
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMTUuMDIuMjIgMTg6NDgsIEx1Y2EgRmFuY2VsbHUgd3JvdGU6DQo+IA0KPiANCj4+IE9u
IDE1IEZlYiAyMDIyLCBhdCAxMDozMywgSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29t
PiB3cm90ZToNCj4+DQo+PiBPbiAxNS4wMi4yMiAxMToxNSwgTHVjYSBGYW5jZWxsdSB3cm90
ZToNCj4+PiBXaXRoIHRoZSBpbnRyb2R1Y3Rpb24gb2YgYm9vdCB0aW1lIGNwdXBvb2xzLCBY
ZW4gY2FuIGNyZWF0ZSBtYW55DQo+Pj4gZGlmZmVyZW50IGNwdXBvb2xzIGF0IGJvb3QgdGlt
ZSBvdGhlciB0aGFuIGNwdXBvb2wgd2l0aCBpZCAwLg0KPj4+IFNpbmNlIHRoZXNlIG5ld2x5
IGNyZWF0ZWQgY3B1cG9vbHMgY2FuJ3QgaGF2ZSBhbg0KPj4+IGVudHJ5IGluIFhlbnN0b3Jl
LCBjcmVhdGUgdGhlIGVudHJ5IHVzaW5nIHhlbi1pbml0LWRvbTANCj4+PiBoZWxwZXIgd2l0
aCB0aGUgdXN1YWwgY29udmVudGlvbjogUG9vbC08Y3B1cG9vbCBpZD4uDQo+Pj4gR2l2ZW4g
dGhlIGNoYW5nZSwgcmVtb3ZlIHRoZSBjaGVjayBmb3IgcG9vbGlkID09IDAgZnJvbQ0KPj4+
IGxpYnhsX2NwdXBvb2xpZF90b19uYW1lKC4uLikuDQo+Pj4gU2lnbmVkLW9mZi1ieTogTHVj
YSBGYW5jZWxsdSA8bHVjYS5mYW5jZWxsdUBhcm0uY29tPg0KPj4+IC0tLQ0KPj4+ICAgdG9v
bHMvaGVscGVycy94ZW4taW5pdC1kb20wLmMgIHwgMjYgKysrKysrKysrKysrKysrKysrKysr
KysrKy0NCj4+PiAgIHRvb2xzL2xpYnMvbGlnaHQvbGlieGxfdXRpbHMuYyB8ICAzICstLQ0K
Pj4+ICAgMiBmaWxlcyBjaGFuZ2VkLCAyNiBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygt
KQ0KPj4+IGRpZmYgLS1naXQgYS90b29scy9oZWxwZXJzL3hlbi1pbml0LWRvbTAuYyBiL3Rv
b2xzL2hlbHBlcnMveGVuLWluaXQtZG9tMC5jDQo+Pj4gaW5kZXggYzk5MjI0YTRiNjA3Li4z
NTM5ZjU2ZmFlYjAgMTAwNjQ0DQo+Pj4gLS0tIGEvdG9vbHMvaGVscGVycy94ZW4taW5pdC1k
b20wLmMNCj4+PiArKysgYi90b29scy9oZWxwZXJzL3hlbi1pbml0LWRvbTAuYw0KPj4+IEBA
IC00Myw3ICs0MywxMCBAQCBpbnQgbWFpbihpbnQgYXJnYywgY2hhciAqKmFyZ3YpDQo+Pj4g
ICAgICAgaW50IHJjOw0KPj4+ICAgICAgIHN0cnVjdCB4c19oYW5kbGUgKnhzaCA9IE5VTEw7
DQo+Pj4gICAgICAgeGNfaW50ZXJmYWNlICp4Y2ggPSBOVUxMOw0KPj4+IC0gICAgY2hhciAq
ZG9tbmFtZV9zdHJpbmcgPSBOVUxMLCAqZG9taWRfc3RyaW5nID0gTlVMTDsNCj4+PiArICAg
IGNoYXIgKmRvbW5hbWVfc3RyaW5nID0gTlVMTCwgKmRvbWlkX3N0cmluZyA9IE5VTEwsICpw
b29sX3N0cmluZyA9IE5VTEw7DQo+IA0KPiBIaSBKdWVyZ2VuLA0KPiANCj4+DQo+PiBwb29s
X3N0cmluZyBzZWVtcyB0byBiZSB1bnVzZWQuDQo+IA0KPiBJIHdpbGwgcmVtb3ZlIGl0DQo+
IA0KPj4NCj4+PiArICAgIGNoYXIgcG9vbF9wYXRoW3N0cmxlbigiL2xvY2FsL3Bvb2wiKSAr
IDEyXSwgcG9vbF9uYW1lW3N0cmxlbigiUG9vbC0iKSArIDVdOw0KPj4NCj4+IEkgZG9uJ3Qg
bGlrZSB0aGF0LiBXaHkgZG9uJ3QgeW91IHVzZSBwb2ludGVycyBhbmQgLi4uDQo+Pg0KPj4+
ICsgICAgeGNfY3B1cG9vbGluZm9fdCAqeGNpbmZvOw0KPj4+ICsgICAgdW5zaWduZWQgaW50
IHBvb2xfaWQgPSAwOw0KPj4+ICAgICAgIGxpYnhsX3V1aWQgdXVpZDsNCj4+PiAgICAgICAg
IC8qIEFjY2VwdCAwIG9yIDEgYXJndW1lbnQgKi8NCj4+PiBAQCAtMTE0LDYgKzExNywyNyBA
QCBpbnQgbWFpbihpbnQgYXJnYywgY2hhciAqKmFyZ3YpDQo+Pj4gICAgICAgICAgIGdvdG8g
b3V0Ow0KPj4+ICAgICAgIH0NCj4+PiAgICsgICAgLyogQ3JlYXRlIGFuIGVudHJ5IGluIHhl
bnN0b3JlIGZvciBlYWNoIGNwdXBvb2wgb24gdGhlIHN5c3RlbSAqLw0KPj4+ICsgICAgZG8g
ew0KPj4+ICsgICAgICAgIHhjaW5mbyA9IHhjX2NwdXBvb2xfZ2V0aW5mbyh4Y2gsIHBvb2xf
aWQpOw0KPj4+ICsgICAgICAgIGlmICh4Y2luZm8gIT0gTlVMTCkgew0KPj4+ICsgICAgICAg
ICAgICBpZiAoeGNpbmZvLT5jcHVwb29sX2lkICE9IHBvb2xfaWQpDQo+Pj4gKyAgICAgICAg
ICAgICAgICBwb29sX2lkID0geGNpbmZvLT5jcHVwb29sX2lkOw0KPj4+ICsgICAgICAgICAg
ICBzbnByaW50Zihwb29sX3BhdGgsIHNpemVvZihwb29sX3BhdGgpLCAiL2xvY2FsL3Bvb2wv
JWQvbmFtZSIsDQo+Pj4gKyAgICAgICAgICAgICAgICAgICAgIHBvb2xfaWQpOw0KPj4+ICsg
ICAgICAgICAgICBzbnByaW50Zihwb29sX25hbWUsIHNpemVvZihwb29sX25hbWUpLCAiUG9v
bC0lZCIsIHBvb2xfaWQpOw0KPj4NCj4+IC4uLiB1c2UgYXNwcmludGYoKSBoZXJlIGZvciBh
bGxvY2F0aW5nIHRoZSBzdHJpbmdzIGluIHRoZSBuZWVkZWQgc2l6ZT8NCj4gDQo+IFdoeSB3
b3VsZCB5b3UgbGlrZSBtb3JlIHRoaXMgYXBwcm9hY2g/IEkgd2FzIHRyeWluZyB0byBhdm9p
ZCBhbGxvY2F0aW9uL2ZyZWUNCj4gb3BlcmF0aW9ucyBpbiBhIGxvb3AgdGhhdCB3b3VsZCBu
ZWVkIGFsc28gbW9yZSBjb2RlIHRvIGNoZWNrIGNhc2VzIGluIHdoaWNoDQo+IG1lbW9yeSBp
cyBub3QgYWxsb2NhdGVkLiBJbnN0ZWFkIHdpdGggdGhlIGJ1ZmZlcnMgaW4gdGhlIHN0YWNr
IHdlIGRvbuKAmXQgaGF2ZSBwcm9ibGVtcy4NCg0KTXkgbWFpbiBjb25jZXJucyBhcmUgdGhl
IHVzYWdlIG9mIHN0cmxlbigpIGZvciBzaXppbmcgYW4gb24tc3RhY2sgYXJyYXksDQp0aGUg
ZHVwbGljYXRpb24gb2YgdGhlIGZvcm1hdCBzdHJpbmdzIChvbmNlIGluIHRoZSBhcnJheXMg
ZGVmaW5pdGlvbiBhbmQNCm9uY2UgaW4gdGhlIHNucHJpbnRmKCkpLCBhbmQgdGhlIG1peHR1
cmUgb2Ygc3RybGVuKCkgYW5kIGNvbnN0YW50cyBmb3INCnNpemluZyB0aGUgYXJyYXlzLg0K
DQpUaGVyZSBhcmUgYWN0dWFsbHkgc29tZSBlcnJvcnMgaW4geW91ciBhcHByb2FjaCBmb3Ig
c2l6aW5nIHRoZSBhcnJheXMsDQpzaG93aW5nIGhvdyBmcmFnaWxlIHlvdXIgc29sdXRpb24g
aXM6IHlvdSBhcmUgYWxsb3dpbmcgYSAicG9zaXRpdmUNCmludGVnZXIgbnVtYmVyIiBmb3Ig
YSBjcHVwb29sLWlkLCB3aGljaCBjb3VsZCBlYXNpbHkgbmVlZCAxMCBkaWdpdHMsDQp3aGls
ZSB5b3VyIGFycmF5cyBhbGxvdyBvbmx5IGZvciA1IG9yIDQgZGlnaXRzLCBkZXBlbmRpbmcg
b24gdGhlIGFycmF5Lg0KDQpBbmQgZG9pbmcgdGhlIHR3byBhc3ByaW50ZigpIGNhbGxzIGFu
ZCB0aGVuIGNoZWNraW5nIHRoYXQgYm90aCBhcnJheXMNCmFyZSBub3QgTlVMTCBpc24ndCB0
aGF0IG11Y2ggY29kZS4gQlRXLCB5b3VyIGFwcHJvYWNoIGlzIG1pc3NpbmcgdGhlDQp0ZXN0
IHRoYXQgdGhlIGFycmF5cyBoYXZlIGJlZW4gbGFyZ2UgZW5vdWdoLg0KDQpUaGUgcGVyZm9y
bWFuY2Ugb2YgdGhhdCBsb29wIHNob3VsZG4ndCBiZSB0aGF0IGNyaXRpY2FsIHRoYXQgYSBm
ZXcNCmFkZGl0aW9uYWwgbWljcm9zZWNvbmRzIHJlYWxseSBodXJ0LCBlc3BlY2lhbGx5IGFz
IEkgZG9uJ3QgdGhpbmsgYW55DQp1c2UgY2FzZSB3aWxsIGV4Y2VlZCBzaW5nbGUgZGlnaXQg
bG9vcCBpdGVyYXRpb25zLg0KDQo+IA0KPj4NCj4+PiArICAgICAgICAgICAgcG9vbF9pZCsr
Ow0KPj4+ICsgICAgICAgICAgICBpZiAoIXhzX3dyaXRlKHhzaCwgWEJUX05VTEwsIHBvb2xf
cGF0aCwgcG9vbF9uYW1lLA0KPj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgIHN0cmxl
bihwb29sX25hbWUpKSkgew0KPj4+ICsgICAgICAgICAgICAgICAgZnByaW50ZihzdGRlcnIs
ICJjYW5ub3Qgc2V0IHBvb2wgbmFtZVxuIik7DQo+Pj4gKyAgICAgICAgICAgICAgICByYyA9
IDE7DQo+Pj4gKyAgICAgICAgICAgIH0NCj4+PiArICAgICAgICAgICAgeGNfY3B1cG9vbF9p
bmZvZnJlZSh4Y2gsIHhjaW5mbyk7DQo+Pj4gKyAgICAgICAgICAgIGlmIChyYykNCj4+PiAr
ICAgICAgICAgICAgICAgIGdvdG8gb3V0Ow0KPj4NCj4+IE1vdmluZyB0aGUgY2FsbCBvZiB4
Y19jcHVwb29sX2luZm9mcmVlKCkgYWhlYWQgb2YgdGhlIGNhbGwgb2YgeHNfd3JpdGUoKQ0K
Pj4gd291bGQgZHJvcCB0aGUgbmVlZCBmb3IgdGhpcyBsYXN0IGlmIHN0YXRlbWVudCwgYXMg
eW91IGNvdWxkIGFkZCB0aGUNCj4+IGdvdG8gdG8gdGhlIHVwcGVyIGlmLg0KPiANCj4gWWVz
IHlvdSBhcmUgcmlnaHQsIGl0IHdvdWxkIHNpbXBsaWZ5IHRoZSBjb2RlDQo+IA0KPj4NCj4+
PiArICAgICAgICB9DQo+Pj4gKyAgICB9IHdoaWxlKHhjaW5mbyAhPSBOVUxMKTsNCj4+PiAr
DQo+Pg0KPj4gV2l0aCBkb2luZyBhbGwgb2YgdGhpcyBmb3IgYmVpbmcgYWJsZSB0byBhc3Np
Z24gb3RoZXIgZG9tYWlucyBjcmVhdGVkDQo+PiBhdCBib290IHRvIGNwdXBvb2xzLCBzaG91
bGRuJ3QgeW91IGFkZCBuYW1lcyBmb3Igb3RoZXIgZG9tYWlucyB0aGFuIGRvbTANCj4+IGhl
cmUsIHRvbz8NCj4gDQo+IFRoaXMgc2VyaWUgaXMgbW9yZSBhYm91dCBjcHVwb29scywgbWF5
YmUgSSBjYW4gZG8gdGhhdCBpbiBhbm90aGVyIGNvbW1pdCBvdXQNCj4gb2YgdGhpcyBzZXJp
ZS4NCg0KRmluZSB3aXRoIG1lLg0KDQoNCkp1ZXJnZW4NCg==
--------------Ngf64dvZ52G9OR9qcytKDqUk
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------Ngf64dvZ52G9OR9qcytKDqUk--

--------------UoADL6uQTsce8rUFlf4S061d--

--------------f8jLpR5yK0hQCSz6BGFTM4fn
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmIMlf4FAwAAAAAACgkQsN6d1ii/Ey+J
Pgf/fkd2Jj1ZQI3guH/E+K99+PwjhrxDEiXO9zHMqfd/VVVoZD2nJx7Uum/+ec00lsAep9m5yOBP
8Lx74+17gTv7g9FoJezQeWz+ekRBNErfYxiFbqNG2v2kNbqRdbh6ckYk9EaVkRVAtcvuuFlozs32
/w472eRbJ+P2Lf1qgdSg8Tbd7mBXyQ1hU0xKvGYwvyTVldiei97h6kt9i/bSL/R9D4siNQGDKi0D
8L+2naaJuiRchKROcvSX67Wj6NpgNMswpe4zqjPAPLwlfiKvU0JrN2ZlbPSKI5AxG6Uc0YTPCwiP
g3prvN+Y/r8bWKxyvjcesTrLppGzOZ5C1WCERk6QTg==
=qijX
-----END PGP SIGNATURE-----

--------------f8jLpR5yK0hQCSz6BGFTM4fn--


From xen-devel-bounces@lists.xenproject.org Wed Feb 16 06:16:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 06:16:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273682.468932 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKDbi-0000Rx-6D; Wed, 16 Feb 2022 06:16:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273682.468932; Wed, 16 Feb 2022 06:16:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKDbi-0000Rq-36; Wed, 16 Feb 2022 06:16:06 +0000
Received: by outflank-mailman (input) for mailman id 273682;
 Wed, 16 Feb 2022 06:16:05 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=BoLq=S7=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nKDbh-0000Ri-AP
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 06:16:05 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id eb869da7-8eef-11ec-8eb8-a37418f5ba1a;
 Wed, 16 Feb 2022 07:16:04 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 0B0721F37D;
 Wed, 16 Feb 2022 06:16:04 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B137113A3E;
 Wed, 16 Feb 2022 06:16:03 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id VpkTKaOWDGJgHAAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 16 Feb 2022 06:16:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: eb869da7-8eef-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1644992164; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=nFkZWLYCBmOpifjImb/h0YhbHGDEqjtB1FTk8XnPyIo=;
	b=aRgSZDaZ3ZczqM3+RrpPxnhgHV83eecGGbx2WJ7nsJbimHmsnDpKjAvZoG9O+NPmv8W7Bs
	NLt7HUe2tnukvYgUQZhZMmmJERNXGA0v/lXVP7V2HOH81gXNgsIG0QYNoi9DO0o+WT+VrQ
	Nm4/LD8bfE/mG+j6T5J6C0mU1f/arp8=
Message-ID: <de879504-7779-5f4a-4dea-4be61f4da167@suse.com>
Date: Wed, 16 Feb 2022 07:16:03 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Subject: Re: [PATCH 2/5] xen/sched: create public function for cpupools
 creation
Content-Language: en-US
To: Luca Fancellu <luca.fancellu@arm.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>, Wei Chen <wei.chen@arm.com>,
 Dario Faggioli <dfaggioli@suse.com>, George Dunlap
 <george.dunlap@citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
 Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
References: <20220215101551.23101-1-luca.fancellu@arm.com>
 <20220215101551.23101-3-luca.fancellu@arm.com>
 <50ad5e74-c8b6-bdb3-2a9b-fa118610d07d@suse.com>
 <3E27F91F-F97A-443D-BBA8-8400FA3FF377@arm.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <3E27F91F-F97A-443D-BBA8-8400FA3FF377@arm.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------h8p9Lxr5j94PYC3iIMzfpSl3"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------h8p9Lxr5j94PYC3iIMzfpSl3
Content-Type: multipart/mixed; boundary="------------XGB80665lt2LZVxDxLXd8o2U";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Luca Fancellu <luca.fancellu@arm.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>, Wei Chen <wei.chen@arm.com>,
 Dario Faggioli <dfaggioli@suse.com>, George Dunlap
 <george.dunlap@citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
 Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Message-ID: <de879504-7779-5f4a-4dea-4be61f4da167@suse.com>
Subject: Re: [PATCH 2/5] xen/sched: create public function for cpupools
 creation
References: <20220215101551.23101-1-luca.fancellu@arm.com>
 <20220215101551.23101-3-luca.fancellu@arm.com>
 <50ad5e74-c8b6-bdb3-2a9b-fa118610d07d@suse.com>
 <3E27F91F-F97A-443D-BBA8-8400FA3FF377@arm.com>
In-Reply-To: <3E27F91F-F97A-443D-BBA8-8400FA3FF377@arm.com>

--------------XGB80665lt2LZVxDxLXd8o2U
Content-Type: multipart/mixed; boundary="------------qdy0Hqr2fuNf2pk0bcGCYF6Y"

--------------qdy0Hqr2fuNf2pk0bcGCYF6Y
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMTUuMDIuMjIgMTg6NTAsIEx1Y2EgRmFuY2VsbHUgd3JvdGU6DQo+IA0KPiANCj4+IE9u
IDE1IEZlYiAyMDIyLCBhdCAxMDozOCwgSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29t
PiB3cm90ZToNCj4+DQo+PiBPbiAxNS4wMi4yMiAxMToxNSwgTHVjYSBGYW5jZWxsdSB3cm90
ZToNCj4+PiBDcmVhdGUgbmV3IHB1YmxpYyBmdW5jdGlvbiB0byBjcmVhdGUgY3B1cG9vbHMs
IGl0IGNoZWNrcyBmb3IgcG9vbCBpZA0KPj4+IHVuaXF1ZW5lc3MgYmVmb3JlIGNyZWF0aW5n
IHRoZSBwb29sIGFuZCBjYW4gdGFrZSBhIHNjaGVkdWxlciBpZCBvcg0KPj4+IGEgbmVnYXRp
dmUgdmFsdWUgdGhhdCBtZWFucyB0aGUgZGVmYXVsdCBYZW4gc2NoZWR1bGVyIHdpbGwgYmUg
dXNlZC4NCj4+PiBTaWduZWQtb2ZmLWJ5OiBMdWNhIEZhbmNlbGx1IDxsdWNhLmZhbmNlbGx1
QGFybS5jb20+DQo+Pg0KPj4gUmV2aWV3ZWQtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0Bz
dXNlLmNvbT4NCj4+DQo+PiB3aXRoIG9uZSBmdXJ0aGVyIHF1ZXN0aW9uOiB5b3UgYXJlIGFs
bG93aW5nIHRvIHVzZSBhbm90aGVyIHNjaGVkdWxlciwNCj4+IGJ1dCB3aGF0IGlmIHNvbWVv
bmUgd2FudHMgdG8gc2V0IG5vbi1zdGFuZGFyZCBzY2hlZHVsaW5nIHBhcmFtZXRlcnMNCj4+
IChlLmcuIGFub3RoZXIgdGltZSBzbGljZSk/DQo+IA0KPiBJIGd1ZXNzIGZvciBub3cgcGFy
YW1ldGVycyBjYW4gYmUgdHVuZWQgb25seSBieSB4bCB0b29sLCBob3dldmVyIGl0IHdvdWxk
DQo+IGJlIHBvc3NpYmxlIGFzIGZ1dHVyZSB3b3JrIHRvIGFsbG93IHBhcmFtZXRlcnMgaW4g
dGhlIGRldmljZSB0cmVlIGZvciBlYWNoDQo+IHNjaGVkdWxlci4NCg0KVGhhdCBpcyBiYXNp
Y2FsbHkgbXkgY29uY2VybiBoZXJlOiBBIHRydWUgZG9tMGxlc3Mgc2V0dXAgd29uJ3QgaGF2
ZSB0aGUNCnBvc3NpYmlsaXR5IHRvIHVzZSB4bC4uLg0KDQpJIGRvbid0IG1pbmQgdGhpcyBz
ZXJpZXMgbm90IHN1cHBvcnRpbmcgdGhhdCBzY2hlbWUsIGJ1dCB0aGUgY2hvc2VuDQpzeW50
YXggZm9yIHRoZSBkZXZpY2UgdHJlZSBzaG91bGQgc3VwcG9ydCB0aGF0IGV4dGVuc2lvbiAo
SSBoYXZlIG5vdA0KbG9va2VkIGludG8gdGhhdCwgYXMgSSBoYXZlIG5vIGRldGFpbGVkIGtu
b3dsZWRnZSBhYm91dCB0aGF0IHRvcGljKS4NCg0KDQpKdWVyZ2VuDQo=
--------------qdy0Hqr2fuNf2pk0bcGCYF6Y
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------qdy0Hqr2fuNf2pk0bcGCYF6Y--

--------------XGB80665lt2LZVxDxLXd8o2U--

--------------h8p9Lxr5j94PYC3iIMzfpSl3
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmIMlqMFAwAAAAAACgkQsN6d1ii/Ey9C
uAf9FJYmfkpv2IP5F+ajIe8tcx5qttSXtvkO0/H4pVDkESX9Wi5qQAepw6kON2ViPc30o/gYhsHQ
JhCEKKTo5363lUWFvi4woHg+1nngfRiQYyCEF2Uvk7wA/NcIX1mmC95cVSvqEJnU36whQUOZizsG
JEBxkIu++hkXsNlo8NO0WL++XMIOq1LhwHlY0yk+Kw45TK20G42wSBPiAPWHXQqzFk7cbpCMZvcc
p7CMj+hXEpQkQNZQjA/qpXlkbGfVQ3Axw73Hd42Q96IdHxrGC7oARN7MZdVQr9lQSJhiulh+leBO
vtGc6nYl6N7glJ5KyrW+/sGf/ajH/VVK+WR1zJVY/Q==
=6KaN
-----END PGP SIGNATURE-----

--------------h8p9Lxr5j94PYC3iIMzfpSl3--


From xen-devel-bounces@lists.xenproject.org Wed Feb 16 06:18:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 06:18:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273688.468944 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKDde-00013Q-J5; Wed, 16 Feb 2022 06:18:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273688.468944; Wed, 16 Feb 2022 06:18:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKDde-00013J-Fs; Wed, 16 Feb 2022 06:18:06 +0000
Received: by outflank-mailman (input) for mailman id 273688;
 Wed, 16 Feb 2022 06:18:05 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=BoLq=S7=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nKDdd-00013B-Ai
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 06:18:05 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3308c8ce-8ef0-11ec-b215-9bbe72dcb22c;
 Wed, 16 Feb 2022 07:18:04 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 09F151F37D;
 Wed, 16 Feb 2022 06:18:04 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id AC43913A3E;
 Wed, 16 Feb 2022 06:18:03 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id eATMKBuXDGLvHAAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 16 Feb 2022 06:18:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3308c8ce-8ef0-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1644992284; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=5bvR+cQM7kV3vvOlHMfT04Bu7E+So7C7IqAwG4VLIwk=;
	b=HG60knYSaJ8Bu4MJJmZhbIq1qFdmwucRgKon//DxRsRgGBJDGC32h7nnRLzT5qj2XljJcn
	y99ZTUaFxE35fXM4RwDqocIu2AQS7GF8U8nLDj19rGa9GKvJTnOqjoWkyqvRuMy4BfUI/B
	Y6KiNN3KFBJKRRrcuxmitQVuIKp7oGQ=
Message-ID: <779968b4-5985-06bc-be35-ce5b0b719930@suse.com>
Date: Wed, 16 Feb 2022 07:18:03 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Subject: Re: [PATCH 4/5] xen/cpupool: Create different cpupools at boot time
Content-Language: en-US
To: Luca Fancellu <luca.fancellu@arm.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>, Wei Chen <wei.chen@arm.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>, Dario Faggioli <dfaggioli@suse.com>
References: <20220215101551.23101-1-luca.fancellu@arm.com>
 <20220215101551.23101-5-luca.fancellu@arm.com>
 <d6f36774-ecb5-15f4-b0c0-6114724060e6@suse.com>
 <AC1B6659-FDCF-49A0-AB6E-EF2196C46D8C@arm.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <AC1B6659-FDCF-49A0-AB6E-EF2196C46D8C@arm.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------ovTIL74uuOjogk659WmZWxj3"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------ovTIL74uuOjogk659WmZWxj3
Content-Type: multipart/mixed; boundary="------------H6jlegWSQ5SX3fL7M84qUChf";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Luca Fancellu <luca.fancellu@arm.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>, Wei Chen <wei.chen@arm.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>, Dario Faggioli <dfaggioli@suse.com>
Message-ID: <779968b4-5985-06bc-be35-ce5b0b719930@suse.com>
Subject: Re: [PATCH 4/5] xen/cpupool: Create different cpupools at boot time
References: <20220215101551.23101-1-luca.fancellu@arm.com>
 <20220215101551.23101-5-luca.fancellu@arm.com>
 <d6f36774-ecb5-15f4-b0c0-6114724060e6@suse.com>
 <AC1B6659-FDCF-49A0-AB6E-EF2196C46D8C@arm.com>
In-Reply-To: <AC1B6659-FDCF-49A0-AB6E-EF2196C46D8C@arm.com>

--------------H6jlegWSQ5SX3fL7M84qUChf
Content-Type: multipart/mixed; boundary="------------yzPp4c76nno0cq0RsKiSyjO6"

--------------yzPp4c76nno0cq0RsKiSyjO6
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMTUuMDIuMjIgMTg6NTYsIEx1Y2EgRmFuY2VsbHUgd3JvdGU6DQo+IA0KPiANCj4+IE9u
IDE1IEZlYiAyMDIyLCBhdCAxMDo0OCwgSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29t
PiB3cm90ZToNCj4+DQo+PiBPbiAxNS4wMi4yMiAxMToxNSwgTHVjYSBGYW5jZWxsdSB3cm90
ZToNCj4+PiBJbnRyb2R1Y2UgYW4gYXJjaGl0ZWN0dXJlIHNwZWNpZmljIHdheSB0byBjcmVh
dGUgZGlmZmVyZW50IGNwdXBvb2xzDQo+Pj4gYXQgYm9vdCB0aW1lLCB0aGlzIGlzIHBhcnRp
Y3VsYXJseSB1c2VmdWwgb24gQVJNIGJpZy5MSVRUTEUgc3lzdGVtDQo+Pj4gd2hlcmUgdGhl
cmUgbWlnaHQgYmUgdGhlIG5lZWQgdG8gaGF2ZSBkaWZmZXJlbnQgY3B1cG9vbHMgZm9yIGVh
Y2ggdHlwZQ0KPj4+IG9mIGNvcmUsIGJ1dCBhbHNvIHN5c3RlbXMgdXNpbmcgTlVNQSBjYW4g
aGF2ZSBkaWZmZXJlbnQgY3B1IHBvb2xzIGZvcg0KPj4+IGVhY2ggbm9kZS4NCj4+PiBUaGUg
ZmVhdHVyZSBvbiBhcm0gcmVsaWVzIG9uIGEgc3BlY2lmaWNhdGlvbiBvZiB0aGUgY3B1cG9v
bHMgZnJvbSB0aGUNCj4+PiBkZXZpY2UgdHJlZSB0byBidWlsZCBwb29scyBhbmQgYXNzaWdu
IGNwdXMgdG8gdGhlbS4NCj4+PiBEb2N1bWVudGF0aW9uIGlzIGNyZWF0ZWQgdG8gZXhwbGFp
biB0aGUgZmVhdHVyZS4NCj4+PiBTaWduZWQtb2ZmLWJ5OiBMdWNhIEZhbmNlbGx1IDxsdWNh
LmZhbmNlbGx1QGFybS5jb20+DQo+Pg0KPj4gSUlSQyBJIHN1Z2dlc3RlZCB0byBoYXZlIHRo
ZSBjb3JlIGZ1bmN0aW9uYWxpdHkgaW4gY29tbW9uIGNvZGUgaW4gb3JkZXINCj4+IHRvIGFs
bG93IHVzaW5nIGJvb3QgdGltZSBjcHVwb29sIGNyZWF0aW9uIGUuZy4gdmlhIGNvbW1hbmRs
aW5lIGZvciB4ODYsDQo+PiB0b28uDQo+IA0KPiBZZXMsIGhvd2V2ZXIgSSB0aGluayB0aGUg
cGFyc2VyIHRvIGhhbmRsZSBldmVyeXRoaW5nIGJ5IGNvbW1hbmQgbGluZSB3b3VsZA0KPiBi
ZSBodWdlIGR1ZSB0byBpbnB1dCBzYW5pdGlzYXRpb24gYW5kIG5vdCBlYXN5IGVub3VnaCBh
cyB0aGUgRFQsIGhvd2V2ZXINCj4gSSBzZWUgSHlwZXJsYXVuY2ggaGFzIHBsYW5zIHRvIHVz
ZSBEVCBvbiB4ODYgc28gSSBndWVzcyBpdCB3b3VsZCBiZSBvayB0byBtYWtlDQo+IHRoaXMg
ZmVhdHVyZSBjb21tb24gb25jZSB0aGUgRFQgaXMgYXZhaWxhYmxlIGFsc28gb24geDg2Lg0K
DQpFdmVyeXRoaW5nIG5vdCBiZWluZyBleHBsaWNpdGx5IHNwZWNpZmljIHRvIEFybSBzaG91
bGQgYmUgaW4gY29tbW9uDQpjb2RlLiBUaGluayBvZiB0aGUgd29yayBpbiBwcm9ncmVzcyBm
b3IgUmlzYy1WLg0KDQoNCkp1ZXJnZW4NCg==
--------------yzPp4c76nno0cq0RsKiSyjO6
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------yzPp4c76nno0cq0RsKiSyjO6--

--------------H6jlegWSQ5SX3fL7M84qUChf--

--------------ovTIL74uuOjogk659WmZWxj3
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmIMlxsFAwAAAAAACgkQsN6d1ii/Ey9A
0Qf9FStUv1v/JKdYReG22mCGvkekmgzJGFf1hPFJf92Ne9KGm1/tyvZHXDD/aSfy1pFr4YBZVzYC
vyMFwFBd491/aUpqsSbkX/8D7ApdlEVPaqbXfPEQyDP85JBHDOTaJivH9e02nePu+bx4I08Go387
ZwcG6jJiyO8rT9deEVSST0uU/QByYnUM8ZeLVLHlWVPN/53rtIsOKVwR8LjOWEP3NvVLqbgI+YQl
EwvKGpq2BOPPvB52Ppw/oJC7X+/NxZD4Qi2hGFEIjgoG1WpMD8Eosa/fFOB21j5oEvcdwGSf707n
ZN3aCRIStaOnpepeOzGDYoYO388A35ofbsQX+ijmNQ==
=UAC2
-----END PGP SIGNATURE-----

--------------ovTIL74uuOjogk659WmZWxj3--


From xen-devel-bounces@lists.xenproject.org Wed Feb 16 06:32:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 06:32:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273699.468955 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKDrd-0003Sa-W5; Wed, 16 Feb 2022 06:32:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273699.468955; Wed, 16 Feb 2022 06:32:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKDrd-0003ST-SP; Wed, 16 Feb 2022 06:32:33 +0000
Received: by outflank-mailman (input) for mailman id 273699;
 Wed, 16 Feb 2022 06:32:32 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=BoLq=S7=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nKDrc-0003S4-0c
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 06:32:32 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 37816dcb-8ef2-11ec-8eb8-a37418f5ba1a;
 Wed, 16 Feb 2022 07:32:30 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 6081A212C3;
 Wed, 16 Feb 2022 06:32:30 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2439413A3E;
 Wed, 16 Feb 2022 06:32:30 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id izAFB36aDGJ7IQAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 16 Feb 2022 06:32:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 37816dcb-8ef2-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1644993150; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=GwxMg2UkWH0rNV1uqw/Ax9X7A7CDk4lDSvqL8KM86I0=;
	b=Fx66wrg18CIFMlgkEP6I3zF8IyMd2uoo/xMvaoVgNzPT1bKSlHSitOPNSLyVHTTDRMp53w
	t4eLVIJGcl8b5EwKgDrFNvuRK3+qDQoq6RJBez2mFASQEAhcZ+IE2wX7+zrJdi6AOLC63k
	WhBtxklU1T39yT5DuELrsAG7Jp5neLY=
Message-ID: <aa39b1ee-feb7-b9b0-9d14-01a5356f7129@suse.com>
Date: Wed, 16 Feb 2022 07:32:29 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Subject: Re: [PATCH] docs: add some clarification to xenstore-migration.md
Content-Language: en-US
To: Julien Grall <julien@xen.org>, xen-devel@lists.xenproject.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
References: <20220210112652.6237-1-jgross@suse.com>
 <6dd022ea-192b-3a5b-e02c-2368e769339f@xen.org>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <6dd022ea-192b-3a5b-e02c-2368e769339f@xen.org>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------kbhIom36OKq4KruNfQlrbTp0"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------kbhIom36OKq4KruNfQlrbTp0
Content-Type: multipart/mixed; boundary="------------RQrnluHG3x0zIzYCJQ8vA7Sh";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Julien Grall <julien@xen.org>, xen-devel@lists.xenproject.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Message-ID: <aa39b1ee-feb7-b9b0-9d14-01a5356f7129@suse.com>
Subject: Re: [PATCH] docs: add some clarification to xenstore-migration.md
References: <20220210112652.6237-1-jgross@suse.com>
 <6dd022ea-192b-3a5b-e02c-2368e769339f@xen.org>
In-Reply-To: <6dd022ea-192b-3a5b-e02c-2368e769339f@xen.org>

--------------RQrnluHG3x0zIzYCJQ8vA7Sh
Content-Type: multipart/mixed; boundary="------------0vibqX66EMfA1rmGDQ49Vlyi"

--------------0vibqX66EMfA1rmGDQ49Vlyi
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMTUuMDIuMjIgMjE6NDAsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gSGkgSnVlcmdlbiwN
Cj4gDQo+IE9uIDEwLzAyLzIwMjIgMTE6MjYsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+PiBU
aGUgWGVuc3RvcmUgbWlncmF0aW9uIGRvY3VtZW50IGlzIG1pc3NpbmcgdGhlIHNwZWNpZmlj
YXRpb24gdGhhdCBhDQo+PiBub2RlIHJlY29yZCBtdXN0IGJlIHByZWNlZGVkIGJ5IHRoZSBy
ZWNvcmQgb2YgaXRzIHBhcmVudCBub2RlIGluIGNhc2UNCj4+IG9mIGxpdmUgdXBkYXRlLg0K
Pj4NCj4+IEFkZCB0aGF0IG1pc3NpbmcgcGFydC4NCj4+DQo+PiBTaWduZWQtb2ZmLWJ5OiBK
dWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+DQo+PiAtLS0NCj4+IMKgIGRvY3MvZGVz
aWducy94ZW5zdG9yZS1taWdyYXRpb24ubWQgfCA0ICsrKysNCj4+IMKgIDEgZmlsZSBjaGFu
Z2VkLCA0IGluc2VydGlvbnMoKykNCj4+DQo+PiBkaWZmIC0tZ2l0IGEvZG9jcy9kZXNpZ25z
L3hlbnN0b3JlLW1pZ3JhdGlvbi5tZCANCj4+IGIvZG9jcy9kZXNpZ25zL3hlbnN0b3JlLW1p
Z3JhdGlvbi5tZA0KPj4gaW5kZXggNWYxMTU1MjczZS4uMzllMzFjOTg0YiAxMDA2NDQNCj4+
IC0tLSBhL2RvY3MvZGVzaWducy94ZW5zdG9yZS1taWdyYXRpb24ubWQNCj4+ICsrKyBiL2Rv
Y3MvZGVzaWducy94ZW5zdG9yZS1taWdyYXRpb24ubWQNCj4+IEBAIC0zMTYsNiArMzE2LDEw
IEBAIGEgX2NvbW1pdHRlZF8gbm9kZSAoZ2xvYmFsbHkgdmlzaWJsZSBpbiANCj4+IHhlbnN0
b3JlZCkgb3IgYSBfcGVuZGluZ18gbm9kZSAoY3JlYXRlZA0KPj4gwqAgb3IgbW9kaWZpZWQg
YnkgYSB0cmFuc2FjdGlvbiBmb3Igd2hpY2ggdGhlcmUgaXMgYWxzbyBhIA0KPj4gYFRSQU5T
QUNUSU9OX0RBVEFgDQo+PiDCoCByZWNvcmQgcHJldmlvdXNseSBwcmVzZW50KS4NCj4+ICtJ
biB0aGUgbGl2ZSB1cGRhdGUgY2FzZSB0aGUgX2NvbW1pdHRlZF8gbm9kZXMgbXVzdCBiZSBp
biBhIHRvcC1kb3duIA0KPj4gc2VxdWVuY2UsDQo+PiAraS5lLiB0aGUgZmlyc3Qgbm9kZSBu
ZWVkcyB0byBiZSBgL2AsIGFuZCBlYWNoIG90aGVyIG5vZGUgaW4gdGhlIA0KPj4gc3RyZWFt
IG11c3QNCj4+ICtjb21lIF9hZnRlcl8gaXRzIHBhcmVudCBub2RlLg0KPiANCj4gSSB3b3Vs
ZCBhY3R1YWxseSBleHBlY3QgdGhlIHNhbWUgcmVzdHJpY3Rpb24gdG8gYXBwbHkgZm9yIHRo
ZSANCj4gbm9uLWxpdmV1cGRhdGUgY2FzZS4gSS5lLiB3ZSB3YW50IHRoZSBwYXJlbnQgdG8g
ZWl0aGVyIGV4aXN0IGluIHRoZSB0cmVlIA0KPiBvciB0aGUgcmVjb3JkIGZvciB0aGUgcGFy
ZW50IHRvIGJlIGJlZm9yZSBpbiB0aGUgc3RyZWFtLg0KDQpIbW0sIHRydWUuIEknbGwgcmVw
aHJhc2UgdGhhdC4NCg0KDQpKdWVyZ2VuDQo=
--------------0vibqX66EMfA1rmGDQ49Vlyi
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------0vibqX66EMfA1rmGDQ49Vlyi--

--------------RQrnluHG3x0zIzYCJQ8vA7Sh--

--------------kbhIom36OKq4KruNfQlrbTp0
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmIMmn0FAwAAAAAACgkQsN6d1ii/Ey8v
BQgAh6uhnweQpWcOFm+/PYzuQShcmbdpAcBZlZIHklaYhwickt1YNM5KOsOnoo/2IM4QsuuSvcWj
1NaFmC5jwjX1F3d5jNIwJSfuHwfii3bLlZdOogAHIPYzmxn+39/MW9qjCTrwr+K/oOQFvynolMm2
sh6Abw9RJc4Qbncbeqh3ysdfBSMD2F9VczZwWaWTDsF32f63W8yvcsSZ5vNOXR6cfY26+melTjlQ
Mb7TfdEfoQH87ledYKqvTN01zfTmC4z6/LkkLADgqbkGDD5NA+sitS/LU4a/JPiwBtZr2wBcHbHw
5adBGA+stxwrJXd+VUjpp0CGkdv2abLCCh1K+hZVig==
=+N1n
-----END PGP SIGNATURE-----

--------------kbhIom36OKq4KruNfQlrbTp0--


From xen-devel-bounces@lists.xenproject.org Wed Feb 16 06:33:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 06:33:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273704.468965 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKDsZ-000403-9v; Wed, 16 Feb 2022 06:33:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273704.468965; Wed, 16 Feb 2022 06:33:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKDsZ-0003zw-6u; Wed, 16 Feb 2022 06:33:31 +0000
Received: by outflank-mailman (input) for mailman id 273704;
 Wed, 16 Feb 2022 06:33:29 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=miT7=S7=gmail.com=andr2000@srs-se1.protection.inumbo.net>)
 id 1nKDsX-0003vd-7d
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 06:33:29 +0000
Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com
 [2a00:1450:4864:20::22c])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 59f39e6a-8ef2-11ec-b215-9bbe72dcb22c;
 Wed, 16 Feb 2022 07:33:28 +0100 (CET)
Received: by mail-lj1-x22c.google.com with SMTP id c15so1746326ljf.11
 for <xen-devel@lists.xenproject.org>; Tue, 15 Feb 2022 22:33:28 -0800 (PST)
Received: from a2klaptop.localdomain ([185.199.97.5])
 by smtp.gmail.com with ESMTPSA id 25sm1595409lfz.65.2022.02.15.22.33.26
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 15 Feb 2022 22:33:26 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 59f39e6a-8ef2-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=hCZUraCHj+42xi/6TKZPfyR+3Ggy49/iCEoKD0rNFj4=;
        b=E7fDUfXxzECKYcgaC/bFWADmnoeRe+sb+8ztKUJPEPfe4VrCbvWsLOcB1jTRKj9RWb
         B4q6Ogas+p0k41/5EA1Ea8BNbsSgrXf0g0zlivuoo3qR09AElJ4Y3nNIWuAWUkYNWTev
         9CheICceYcvcYI5PtqU7yKEqGKP4ebFFtc2YUe0tn2815DnW+3cE5etD1+aKtWVWhCU1
         9z+UqjSfArds4zDuOZnJp9Y8Z70nr8+KoXq0woGPT/vxz0AdXqIuQOkcme7IWzbreWAC
         X6xGFS+SDjbmSXj8s90z7VwBfti5C6PrLvpSgQ0ycfPpq8EjSdIkUUWHjn+3yil9svkG
         8zOw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=hCZUraCHj+42xi/6TKZPfyR+3Ggy49/iCEoKD0rNFj4=;
        b=C17qGJyO/543SArHZEYyMmU8PPFPyEjNI0Yvx+T5z2shVZq8GrVaK36GFNB7ralxWa
         LYvL5QF3hgsPzOyxNVuOhw33IKpfTD1uEpvuCOdFjeIQTwTkufAcACzgC+kY9IXcr3TU
         Wh6sfnHk3i7TVMTphypWMCKtqDwwd5flpPiMBob1CC8kGvX/VTLHUGETH1pN4sE8bwCs
         1D4KnKauMtP1jr1Ow4EbmpIbRQ+uKYUnWFjA7rjuLeb7OpOYbqzwtR4MRqWmsZSSyVXf
         77+wf/8xuMW/Mg3mHLoeK2Sq1Pzflyq3cNydrLj8o3lj8cdATbxcSh/5VNJnSRcDeLpU
         jfOQ==
X-Gm-Message-State: AOAM531xRMU/au6hVssjNusz+04/w7wOgho0wE2/su/m2fB/F/TuJDCs
	D22SeLxBlLY3FykbZJp7Rm3wgHVnmb4=
X-Google-Smtp-Source: ABdhPJzjY+uVQ/+Uuis0oMmo1zYNn0FFg8MJ8c+lNxyCyedwTHdvmrtYhshxe0ftArZBJKKiZsd+Cg==
X-Received: by 2002:a2e:b0e2:0:b0:23d:8a3d:cd70 with SMTP id h2-20020a2eb0e2000000b0023d8a3dcd70mr947444ljl.304.1644993207536;
        Tue, 15 Feb 2022 22:33:27 -0800 (PST)
From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: jgross@suse.com,
	anthony.perard@citrix.com,
	wl@xen.org,
	jandryuk@gmail.com,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: [PATCH v2] tools: remove xenstore entries on vchan server closure
Date: Wed, 16 Feb 2022 08:33:25 +0200
Message-Id: <20220216063325.1552217-1-andr2000@gmail.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

vchan server creates XenStore entries to advertise its event channel and
ring, but those are not removed after the server quits.
Add additional cleanup step, so those are removed, so clients do not try
to connect to a non-existing server.

Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

---
Since v1:
- add NULL check after strdup
---
 tools/include/libxenvchan.h |  5 +++++
 tools/libs/vchan/init.c     | 25 +++++++++++++++++++++++++
 tools/libs/vchan/io.c       |  4 ++++
 tools/libs/vchan/vchan.h    | 31 +++++++++++++++++++++++++++++++
 4 files changed, 65 insertions(+)
 create mode 100644 tools/libs/vchan/vchan.h

diff --git a/tools/include/libxenvchan.h b/tools/include/libxenvchan.h
index d6010b145df2..30cc73cf97e3 100644
--- a/tools/include/libxenvchan.h
+++ b/tools/include/libxenvchan.h
@@ -86,6 +86,11 @@ struct libxenvchan {
 	int blocking:1;
 	/* communication rings */
 	struct libxenvchan_ring read, write;
+	/**
+	 * Base xenstore path for storing ring/event data used by the server
+	 * during cleanup.
+	 * */
+	char *xs_path;
 };
 
 /**
diff --git a/tools/libs/vchan/init.c b/tools/libs/vchan/init.c
index c8510e6ce98a..ae9a6b579753 100644
--- a/tools/libs/vchan/init.c
+++ b/tools/libs/vchan/init.c
@@ -46,6 +46,8 @@
 #include <xen/sys/gntdev.h>
 #include <libxenvchan.h>
 
+#include "vchan.h"
+
 #ifndef PAGE_SHIFT
 #define PAGE_SHIFT 12
 #endif
@@ -251,6 +253,12 @@ static int init_xs_srv(struct libxenvchan *ctrl, int domain, const char* xs_base
 	char ref[16];
 	char* domid_str = NULL;
 	xs_transaction_t xs_trans = XBT_NULL;
+
+	// store the base path so we can clean up on server closure
+	ctrl->xs_path = strdup(xs_base);
+	if (!ctrl->xs_path)
+		goto fail;
+
 	xs = xs_open(0);
 	if (!xs)
 		goto fail;
@@ -298,6 +306,23 @@ retry_transaction:
 	return ret;
 }
 
+void close_xs_srv(struct libxenvchan *ctrl)
+{
+	struct xs_handle *xs;
+
+	if (!ctrl->xs_path)
+		return;
+
+	xs = xs_open(0);
+	if (!xs)
+		goto fail;
+
+	xs_rm(xs, XBT_NULL, ctrl->xs_path);
+
+fail:
+	free(ctrl->xs_path);
+}
+
 static int min_order(size_t siz)
 {
 	int rv = PAGE_SHIFT;
diff --git a/tools/libs/vchan/io.c b/tools/libs/vchan/io.c
index da303fbc01ca..1f201ad554f2 100644
--- a/tools/libs/vchan/io.c
+++ b/tools/libs/vchan/io.c
@@ -40,6 +40,8 @@
 #include <xenctrl.h>
 #include <libxenvchan.h>
 
+#include "vchan.h"
+
 #ifndef PAGE_SHIFT
 #define PAGE_SHIFT 12
 #endif
@@ -384,5 +386,7 @@ void libxenvchan_close(struct libxenvchan *ctrl)
 		if (ctrl->gnttab)
 			xengnttab_close(ctrl->gnttab);
 	}
+	if (ctrl->is_server)
+		close_xs_srv(ctrl);
 	free(ctrl);
 }
diff --git a/tools/libs/vchan/vchan.h b/tools/libs/vchan/vchan.h
new file mode 100644
index 000000000000..621016ef42e5
--- /dev/null
+++ b/tools/libs/vchan/vchan.h
@@ -0,0 +1,31 @@
+/**
+ * @file
+ * @section AUTHORS
+ *
+ * Copyright (C) 2021 EPAM Systems Inc.
+ *
+ * @section LICENSE
+ *
+ *  This library is free software; you can redistribute it and/or
+ *  modify it under the terms of the GNU Lesser General Public
+ *  License as published by the Free Software Foundation; either
+ *  version 2.1 of the License, or (at your option) any later version.
+ *
+ *  This library is distributed in the hope that it will be useful,
+ *  but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ *  Lesser General Public License for more details.
+ *
+ *  You should have received a copy of the GNU Lesser General Public
+ *  License along with this library; If not, see <http://www.gnu.org/licenses/>.
+ *
+ * @section DESCRIPTION
+ *
+ *  This file contains common libxenvchan declarations.
+ */
+#ifndef LIBVCHAN_H
+#define LIBVCHAN_H
+
+void close_xs_srv(struct libxenvchan *ctrl);
+
+#endif /* LIBVCHAN_H */
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Feb 16 07:11:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 07:11:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273713.468977 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKETC-0008DW-12; Wed, 16 Feb 2022 07:11:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273713.468977; Wed, 16 Feb 2022 07:11:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKETB-0008DP-Tx; Wed, 16 Feb 2022 07:11:21 +0000
Received: by outflank-mailman (input) for mailman id 273713;
 Wed, 16 Feb 2022 07:11:20 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nKET9-0008DF-VZ; Wed, 16 Feb 2022 07:11:19 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nKET9-00014i-QF; Wed, 16 Feb 2022 07:11:19 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nKET9-0003pe-5v; Wed, 16 Feb 2022 07:11:19 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nKET9-0005uu-5T; Wed, 16 Feb 2022 07:11:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=PabA3/QC3MpgPnaV2ZEAn90BFiHvh4cDYWNogk/rSe8=; b=jLtpZdGpqc1IKtg+2Z2L1tby5m
	XRtwxC/pAYQZ7N/vZu5hjROVnNUGtR1naKoau4SbzTqGUumftKZLyTWE0MTWA33BkW2FBzvZ10837
	6jA2+V6LWCpTenOUEFO9SQVE+rOQaWBif+veslg4BgiwHsEXojpOFkFf3V2K8GN3gcqI=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168123-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 168123: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:allowable
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=ad38520bdeb2b1e0b487db317f29119e94c1c88d
X-Osstest-Versions-That:
    qemuu=e56d873f0ed9f7ed35b40cc1be841bf7f22db690
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 16 Feb 2022 07:11:19 +0000

flight 168123 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168123/

Failures :-/ but no regressions.

Regressions which are regarded as allowable (not blocking):
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10   fail REGR. vs. 168120

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168120
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168120
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168120
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168120
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168120
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168120
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168120
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168120
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 qemuu                ad38520bdeb2b1e0b487db317f29119e94c1c88d
baseline version:
 qemuu                e56d873f0ed9f7ed35b40cc1be841bf7f22db690

Last test of basis   168120  2022-02-15 14:08:16 Z    0 days
Testing same since   168123  2022-02-15 23:08:13 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Dr. David Alan Gilbert <dgilbert@redhat.com>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Klaus Jensen <k.jensen@samsung.com>
  Peter Maydell <peter.maydell@linaro.org>
  Philippe Mathieu-Daudé <philmd@redhat.com>
  Stefan Hajnoczi <stefanha@redhat.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   e56d873f0e..ad38520bde  ad38520bdeb2b1e0b487db317f29119e94c1c88d -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Wed Feb 16 07:20:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 07:20:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273726.468988 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKEbg-0001JT-1S; Wed, 16 Feb 2022 07:20:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273726.468988; Wed, 16 Feb 2022 07:20:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKEbf-0001JM-UZ; Wed, 16 Feb 2022 07:20:07 +0000
Received: by outflank-mailman (input) for mailman id 273726;
 Wed, 16 Feb 2022 07:20:07 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=BoLq=S7=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nKEbf-00016r-3l
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 07:20:07 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id dc42f55c-8ef8-11ec-b215-9bbe72dcb22c;
 Wed, 16 Feb 2022 08:20:04 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 3445D21AAA;
 Wed, 16 Feb 2022 07:20:04 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E202E13A3E;
 Wed, 16 Feb 2022 07:20:03 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id oGbKNaOlDGLbMgAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 16 Feb 2022 07:20:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dc42f55c-8ef8-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1644996004; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=Nt7cWVPdUojteZJh+gHuHKAmBNIpZtgkn1nMxbEFJhM=;
	b=MRAQsyxenNevOlHq2f+Dsv/lpc/LO69zxo1g2ABFZb0Ymf7l0p4rQq5J3V8u9j2ZYNlU9C
	GBFHwE9C45Dj3I/RAcYVQWeY+fNFj3wwu4u/NWIBBFL+4IaHaqnkVrRFG0KD4V/OMsLp0F
	gxslfjUjY7/fTjmBMfi33Eoxf3xgVJ8=
Message-ID: <93e50bc4-6e53-b753-c520-7d1d0a5a5f5a@suse.com>
Date: Wed, 16 Feb 2022 08:20:03 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Content-Language: en-US
To: Julien Grall <julien@xen.org>, xen-devel@lists.xenproject.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
References: <20220203131418.1319-1-jgross@suse.com>
 <20220203131418.1319-2-jgross@suse.com>
 <a35bb9ba-e2be-f73e-9272-906bc09d9b6e@xen.org>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH v2 2/2] xen/include/public: deprecate GNTTABOP_transfer
In-Reply-To: <a35bb9ba-e2be-f73e-9272-906bc09d9b6e@xen.org>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------na0xiobBbkUvB16Pdkzxbvn4"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------na0xiobBbkUvB16Pdkzxbvn4
Content-Type: multipart/mixed; boundary="------------fsTSIEG3ELjRbYEaQCEaLa8L";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Julien Grall <julien@xen.org>, xen-devel@lists.xenproject.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Message-ID: <93e50bc4-6e53-b753-c520-7d1d0a5a5f5a@suse.com>
Subject: Re: [PATCH v2 2/2] xen/include/public: deprecate GNTTABOP_transfer
References: <20220203131418.1319-1-jgross@suse.com>
 <20220203131418.1319-2-jgross@suse.com>
 <a35bb9ba-e2be-f73e-9272-906bc09d9b6e@xen.org>
In-Reply-To: <a35bb9ba-e2be-f73e-9272-906bc09d9b6e@xen.org>

--------------fsTSIEG3ELjRbYEaQCEaLa8L
Content-Type: multipart/mixed; boundary="------------p7ZB42jg10JtIExq60qthzus"

--------------p7ZB42jg10JtIExq60qthzus
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMTUuMDIuMjIgMjI6MTMsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gSGkgSnVlcmdlbiwN
Cj4gDQo+IE9uIDAzLzAyLzIwMjIgMTM6MTQsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+PiBB
ZGQgYSBjb21tZW50IHRvIGluY2x1ZGUvcHVibGljL2dyYW50X3RhYmxlLmggdGhhdCBHTlRU
QUJPUF90cmFuc2Zlcg0KPj4gaXMgZGVwcmVjYXRlZCwgaW4gb3JkZXIgdG8gZGlzY291cmFn
ZSBuZXcgdXNlIGNhc2VzLg0KPiANCj4gIEZyb20gdGhlIGNvbW1pdCBtZXNzYWdlLCBpdCBp
cyB1bmNsZWFyIHRvIG1lIHdoeSB3ZSBhcmUgZGlzY291cmFnaW5nIA0KPiBuZXcgdXNlIGNh
c2VzIGFuZCBpbmRpcmVjdGx5IGVuY291cmFnaW5nIGN1cnJlbnQgdXNlcnMgdG8gbW92ZSBh
d2F5IGZyb20gDQo+IHRoZSBmZWF0dXJlLg0KPiANCj4gUGF0Y2ggIzEgc2VlbXMgdG8gaW1w
bHkgdGhpcyBpcyBiZWNhdXNlIHRoZSBmZWF0dXJlIGlzIG5vdCBwcmVzZW50IGluIA0KPiBM
aW51eCB1cHN0cmVhbS4gQnV0IEkgZG9uJ3QgdGhpbmsgdGhpcyBpcyBhIHN1ZmZpY2llbnQg
cmVhc29uIHRvIA0KPiBkZXByZWNhdGUgYSBmZWF0dXJlLg0KPiANCj4gQSBtb3JlIGNvbXBl
bGxpbmcgcmVhc29uIHdvdWxkIGJlIHRoYXQgdGhlIGZlYXR1cmUgaXMgYnJva2VuIGFuZCB0
b28gDQo+IGNvbXBsZXggdG8gZml4IGl0Lg0KPiANCj4gU28gY2FuIHlvdSBwcm92aWRlIG1v
cmUgZGV0YWlscz8NCg0KSXQgaXMgYSBmZWF0dXJlIGF2YWlsYWJsZSBmb3IgUFYgZG9tYWlu
cyBvbmx5LCBhbmQgaXQgaXMgdmVyeSBjb21wbGV4DQphbmQgaGFzbid0IGJlZW4gdGVzdGVk
IGZvciBhZ2VzLg0KDQo+IEFzIGEgc2lkZSBub3RlLCBzaG91bGQgd2UgYWxzbyB1cGRhdGUg
U1VQUE9SVC5tZD8NCg0KR29vZCBxdWVzdGlvbi4NCg0KDQpKdWVyZ2VuDQo=
--------------p7ZB42jg10JtIExq60qthzus
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------p7ZB42jg10JtIExq60qthzus--

--------------fsTSIEG3ELjRbYEaQCEaLa8L--

--------------na0xiobBbkUvB16Pdkzxbvn4
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmIMpaMFAwAAAAAACgkQsN6d1ii/Ey+7
Zwf/XN7Jf9PcOHkQ6+ZQGNwecat3Ud+TAf4D4wehDpsSdOuuE5lmvjVPpHTiGBL9W0SK/sUnt94e
w/Y+WbEaWd8iT19S6Z1Dc2RNa9RUYiqNrNptHzJrFyvHNHJuj4QdxAweFNhEplH+w4dpjgMg5XS4
HAO2F7EmB8p55COTNTw83tX+f1wzc5zmCiE1hseIwRu8yQy27DwrLN7/hcFfuRILwuFfAcUEQ8l8
+MS0Mm4YS0NoR/Kz0iIJ84Or7cOZvE7gKtvpIlBn+zMkhZR2eaYjhczififp1Zl9ttwlrD8aZzIN
99JuigUoLL3ilDZG22E8z5oHW4SsfWC0aeZUBJtivA==
=HBT1
-----END PGP SIGNATURE-----

--------------na0xiobBbkUvB16Pdkzxbvn4--


From xen-devel-bounces@lists.xenproject.org Wed Feb 16 07:54:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 07:54:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273746.468999 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKF8e-0004e1-Qg; Wed, 16 Feb 2022 07:54:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273746.468999; Wed, 16 Feb 2022 07:54:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKF8e-0004dt-N6; Wed, 16 Feb 2022 07:54:12 +0000
Received: by outflank-mailman (input) for mailman id 273746;
 Wed, 16 Feb 2022 07:54:11 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Gpsw=S7=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nKF8d-0004dm-MJ
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 07:54:11 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9f456701-8efd-11ec-b215-9bbe72dcb22c;
 Wed, 16 Feb 2022 08:54:09 +0100 (CET)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2104.outbound.protection.outlook.com [104.47.17.104]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-29-rE-wBMqQMM-A5Cuaqt18sQ-1; Wed, 16 Feb 2022 08:54:08 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5166.eurprd04.prod.outlook.com (2603:10a6:803:53::33)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.18; Wed, 16 Feb
 2022 07:54:05 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4995.016; Wed, 16 Feb 2022
 07:54:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9f456701-8efd-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1644998049;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=1vU3j7f/cd9nomR1UVLO6ZvBCxTBOl2FF7nVJvM4JrM=;
	b=hzhC21aeeJCf9Bla8V2H22lf4Bq4SEbdDGjiG6jWJHZRhePlv3MzAsn/tNGC+IxvvkRpLP
	zjgY3jeNmmn83tzLklWCVrRHQTy2nSFPZpfW5+6pZ68SH9xb2W+fhUdinvVCeAP8AoDByo
	/4QyPu+K9pZVRyIEoi2GjC9+Bb3GxLU=
X-MC-Unique: rE-wBMqQMM-A5Cuaqt18sQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ho97QhmDxwjjzk2fw7GTawOpYjdYwRpMtL4Ar7SPrwMGzcVsrfPYTnrSlr5WNb3KtFeWD0KK88wy/e5u4qraNVA9Xx21gqyQAcsHHkuJ2jta29jABRxocmL021bYJ0JEVUyk72Yg03Q7Idx6oqeUOMOa7L2/NwcavDoxfXODpmtc0t9S+/FzuKStoHUDhA4Spl4liA2rvPxsVqst+AR+Zxk6aD/n1Wc5oMiSiYBfnrPeHwgbe3eczMnQqK8jqXhMJO0/mCKEQ+Wmu5Ks3TU6EerWMEvcVpVAMgdL/zGuJfdBQJ9+84TpTowx/xe4uLngWDC/GvRfe7g9v2YJYph7Iw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=7PA3hg//FA1dv8Cgam5+erljiIcWjJ8bYyyRvBR/Rxg=;
 b=h3qbhEb4u486ptxb8hMBYW+XfCp5M+nD0LL1t9hqm1TtaorKquMRv9nMuUp+omOd7w34jn356nyj6iD73ML9ZATbg0U0Gk8NuE5VVJ+qTFv77QJpov+8q0l7/qbMGPa05UcuvW3Vq5Wc761UCCLnEKSxxGay1rcVBjRjcrGZEDOMWyX+CxGd4yLM4XdvVsl0hF7PA71ah8ky+LgiIbL2yVOVb5qEYB9n/fknRBC3nP0iCZjFDd+JIqQ08Aze8rlwwc/kbfaoEuEmZEh575jXlWk/rdwp/aXsCDAAjMM6MpJNM/a5/IQd0EnljP9peFboxMRNCjlj5Gxs4GDB4v+5qg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <e20eeaa5-d782-de4e-0208-96826d877ac0@suse.com>
Date: Wed, 16 Feb 2022 08:54:02 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH 16/16] x86/P2M: the majority for struct p2m_domain's
 fields are HVM-only
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: George Dunlap <George.Dunlap@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <Andrew.Cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 Roger Pau Monne <roger.pau@citrix.com>, Paul Durrant <paul@xen.org>
References: <d1fd572d-5bfe-21d8-3b50-d9b0646ce2f0@suse.com>
 <e5362b33-0f5b-ba2b-d033-ca0a09e5fd54@suse.com>
 <EFFE5241-CB1D-4173-87F9-16AC428902F7@citrix.com>
 <c9fc136c-e7cb-e15d-869c-a952b5b6dc31@suse.com>
In-Reply-To: <c9fc136c-e7cb-e15d-869c-a952b5b6dc31@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0304.eurprd06.prod.outlook.com
 (2603:10a6:20b:45b::30) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 3d4f48c6-4c26-43ba-7ca3-08d9f1218108
X-MS-TrafficTypeDiagnostic: VI1PR04MB5166:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB5166F365AAD54956723DFD3CB3359@VI1PR04MB5166.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	rxob07qKVbyhVn/tgCmMbLQVu8zUIXjkP+AzlFAaH4Kj9fN9fgCAoNf5zTJn7IFe+Mpz0iXyZ9PffGDk199JnBqCYSeiUc/0ayfTvEMf7MgzxbwEYXmF6lKFf0Tnx6jsT0eyAWu3jndrl8Z8ZaMmFgn4RD3q2bG1ofiOzCpBJOq7Om1zBrdQf/kx0sMD1FAfFKFdukFgmWERu2RC/zXU60cAdaWM2Av0JjFXbvVp7mvaAJdiZ++yd7299tWgvCkzHtJsFpNCRkrDzVvRxSqQlqqDNMXnh7aOMcCzqZPtp1WXaDjRox69leSu24Eim1G06BZwioKJ4p08XlFhgWyzE1CYLfSREExv7l0+DuovF6M3ZUf3zzIqNv/F9STTKgvUyK0raGS+H6pOPU6OBopaoibmVGjlkQlrvbrxasu2tq8JQFpUYtJluisAuBdEWeESJZ5lIHyOP6eUkyL4QrIXK/vHIwn0GoDvAjKkYFpuzJ1QO68bhpz8AW1LvWaXTtg7OEDj+MPv13+oW8Q2UUxxoBzHGn3oFkQm0uWE0ZPgITp7maZK5maQyDvnaPojV+alngAhaei/75awByGQCQ+uKP8GE0pqKe3fbWixrhp5jsalBrkSht5sGRYcAdouMXH9HRd5ndhuCnS5qfK4n4uAOW9ohssjrPyOwpG2Dky0Qb5eGS+VWKNqW+ul/0BWxfMiGKojFmmx1T2MySR+MIuNyuv82OOui1MCJATd6G04GGk=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(31696002)(38100700002)(4326008)(2906002)(54906003)(66556008)(53546011)(66476007)(6916009)(36756003)(6512007)(86362001)(31686004)(66946007)(6506007)(83380400001)(8676002)(316002)(6486002)(6666004)(186003)(8936002)(26005)(2616005)(5660300002)(508600001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?B//cssW5ljsbXy+CwMe9fjxvIST5ZWoi0Ix4jxAVnzkF1T72aOJj5jQBKx0o?=
 =?us-ascii?Q?3fE4RZModo/7B6naDIwMRerrasscSFKk85yUX4t1tlHEzqzd93AG12dsjYYh?=
 =?us-ascii?Q?ZOCGIdAQ39eKH+c9xDSKmDnClSXa2Ngn4VxTKO/l7R6TzjlcCE7XS3zKe0Vz?=
 =?us-ascii?Q?mFhg6ZBiMOCR2WFjCw6qbjK5eIYAD8+QCjXh5czjOjh+YTIw3pk0oSMnVvUz?=
 =?us-ascii?Q?wHg/xXBj7fE21XdNw2jM5vHIrNrVlJFkWDsbyUcDxDYI+YySgmf/GNYxc79v?=
 =?us-ascii?Q?dqgkp0mF2VcVH91nE0xTMb4BKOAOOd6Ws3mKsr0wmnX5qzfCIYGluo78HEwv?=
 =?us-ascii?Q?bJzG3ne2T4RJYIS+N1Aoc62POTGVQlRd3pEkIWEKCeAo/3Ffpg9uv+tTl649?=
 =?us-ascii?Q?LsSGSv/p3HPV3PfjUqOwRyZKcfGegqdZUr4NoNZpTYYhlptF68oG00BrF1a3?=
 =?us-ascii?Q?bFft0Itduehzuw9CVRxenyVMZYTS3YWKRKqr9oDzLEbH7PO1SjtL+PEGXg9V?=
 =?us-ascii?Q?lSu/LYBkyn4FMGkrSjw9G7ETZj51AlfHb0Dl7Goj0/yjRJAPngYU3Xtz2H1R?=
 =?us-ascii?Q?3RQftyDbZ7cN1K74eKqRy5p21CigPp1h5ZX5ptUJTtij7g2gV4HHWbXvYF8E?=
 =?us-ascii?Q?sGstOMTfcX0HVvngnttPKo9Afh650wdWVYMH2tA7OOYdPshHjDozIng5bUmn?=
 =?us-ascii?Q?d/j0ehTmrjcxanGh+lLYOxfdMIJPP0jkOYPXrPiTEyRmXgJ4PNN24Kv6bcTM?=
 =?us-ascii?Q?Bu/dt7ukYkafxQVEW/YLQVU60ZOUhjyNQjKFjxRtbBxDvQF7AllU3B75PK4o?=
 =?us-ascii?Q?TbPsRumARA8MGWEaFrCE5+bnfUgL87RT7kVc4elj+FwIPndydTv81wfTUXZX?=
 =?us-ascii?Q?DS1u57mNwvumSTZ7/JEVYFlwZlsTFQnvgnYgpjmOJr1eeviONmj/r7W3cmDt?=
 =?us-ascii?Q?1HFG+CL/qv19f81cB4W2JqW7Za3gHWsg46RUYpp6L3Xwc7w0UwCJ2XaixKqC?=
 =?us-ascii?Q?4LuzW/pXDE2xOBVpi3dqQRK2FQScaN0kATWYdiN+RJE4B3TeihIyh+K/ajxw?=
 =?us-ascii?Q?4ecgtpNA9MwIspqq6YSZGorqCCcxe14b+jD/KP9HbGJEC28wxnERoHNP4TfR?=
 =?us-ascii?Q?A2Nj7GABraJQjnYlGcGT2H29Mlp+q5YHJp+fdu7CXCiX0EhJj763uKXO24UY?=
 =?us-ascii?Q?iiKdRckCc1Ruus+ybSDzttGz6hczTOWVBXKV5JcFrge4ishhH3crPYFOKJOq?=
 =?us-ascii?Q?hrp2cSJFDquMO96g2IBMOyYrKrAe5sLLX1jRCWmbR4NzqAWcG/TfPHH5vbkH?=
 =?us-ascii?Q?3p5w/KEzh0BB1OXPnRrqE1LMBkiN+xt0suFPw4M4Np88zOJpffj2qVqirCmZ?=
 =?us-ascii?Q?2E1J1pXV2i2Ckuse7yer75scLG+4GNDBIvSDqsArgxJNFMnk1FeAqyLaenVM?=
 =?us-ascii?Q?DVsfl3SwL0qJX9nYCBhOpYfQ7MxevL2fnLqrEw1E64r0PyhGJtUUliSrINDN?=
 =?us-ascii?Q?roXeW4PbulnDua7VZryflTeWDEPDJf+xLEr9T5dxjY9zxBOoG3UHWrxneF51?=
 =?us-ascii?Q?ClUZsc4nxOiP+BaCsK7SBKadRwgzT4Y8DUEEcTxG6R45lkHtsSewqdwy5MSj?=
 =?us-ascii?Q?66jpvZEOnEPHMyXcUYU6j0s=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3d4f48c6-4c26-43ba-7ca3-08d9f1218108
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2022 07:54:05.3480
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iJqOhXE3xultk1gpUImnmp1BPl6PA9+j1yT7EXVmtaNQyIb9YAqw8ueRWu4/yqGoKQBYc8ewQDoVHuj2t0ReRA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5166

On 14.02.2022 17:07, Jan Beulich wrote:
> On 14.02.2022 16:51, George Dunlap wrote:
>>> On Jul 5, 2021, at 5:15 PM, Jan Beulich <JBeulich@suse.com> wrote:
>>>
>>> ..., as are the majority of the locks involved. Conditionalize things
>>> accordingly.
>>>
>>> Also adjust the ioreq field's indentation at this occasion.
>>>
>>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>>
>> Reviewed-by: George Dunlap <george.dunlap@citrix.com>
>=20
> Thanks.
>=20
>> With one question=E2=80=A6
>>
>>> @@ -905,10 +917,10 @@ int p2m_altp2m_propagate_change(struct d
>>> /* Set a specific p2m view visibility */
>>> int p2m_set_altp2m_view_visibility(struct domain *d, unsigned int idx,
>>>                                    uint8_t visible);
>>> -#else
>>> +#else /* CONFIG_HVM */
>>> struct p2m_domain *p2m_get_altp2m(struct vcpu *v);
>>> static inline void p2m_altp2m_check(struct vcpu *v, uint16_t idx) {}
>>> -#endif
>>> +#endif /* CONFIG_HVM */
>>
>> This is relatively minor, but what=E2=80=99s the normal for how to label=
 #else macros here?  Wouldn=E2=80=99t you normally see =E2=80=9C#endif /* C=
ONFIG_HVM */=E2=80=9C and think that the immediately preceding lines are co=
mpiled only if CONFIG_HVM is defined?  I.e., would this be more accurate to=
 write =E2=80=9C!CONFIG_HVM=E2=80=9D here?
>>
>> I realize in this case it=E2=80=99s not a big deal since the #else is ju=
st three lines above it, but since you took the time to add the comment in =
there, it seems like it=E2=80=99s worth the time to have a quick think abou=
t whether that=E2=80=99s the right thing to do.
>=20
> Hmm, yes, let me make this !CONFIG_HVM. I think we're not really
> consistent with this, but I agree it's more natural like you say.

Coming to write a similar construct elsewhere, I've realized this is
odd. Looking through include/asm/, the model generally used is

#ifdef CONFIG_xyz
#else /* !CONFIG_xyz */
#endif /* CONFIG_xyz */

That's what I'll switch to here then as well.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Feb 16 08:17:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 08:17:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273762.469010 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKFV1-0007eV-1X; Wed, 16 Feb 2022 08:17:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273762.469010; Wed, 16 Feb 2022 08:17:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKFV0-0007eO-U8; Wed, 16 Feb 2022 08:17:18 +0000
Received: by outflank-mailman (input) for mailman id 273762;
 Wed, 16 Feb 2022 08:17:17 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=wbM1=S7=arm.com=Luca.Fancellu@srs-se1.protection.inumbo.net>)
 id 1nKFUz-0007eI-77
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 08:17:17 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on20613.outbound.protection.outlook.com
 [2a01:111:f400:7d00::613])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d9cc0f39-8f00-11ec-8eb8-a37418f5ba1a;
 Wed, 16 Feb 2022 09:17:16 +0100 (CET)
Received: from DB7PR05CA0047.eurprd05.prod.outlook.com (2603:10a6:10:2e::24)
 by AM5PR0802MB2564.eurprd08.prod.outlook.com (2603:10a6:203:a0::21) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.14; Wed, 16 Feb
 2022 08:17:12 +0000
Received: from DB5EUR03FT044.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:2e:cafe::3c) by DB7PR05CA0047.outlook.office365.com
 (2603:10a6:10:2e::24) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.16 via Frontend
 Transport; Wed, 16 Feb 2022 08:17:12 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT044.mail.protection.outlook.com (10.152.21.167) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4975.11 via Frontend Transport; Wed, 16 Feb 2022 08:17:12 +0000
Received: ("Tessian outbound 63bb5eb69ee8:v113");
 Wed, 16 Feb 2022 08:17:12 +0000
Received: from ff3db04f4d7b.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 36C475AF-8C97-4753-BFB6-4FADCB9816A3.1; 
 Wed, 16 Feb 2022 08:17:11 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ff3db04f4d7b.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 16 Feb 2022 08:17:11 +0000
Received: from VI1PR0801MB2125.eurprd08.prod.outlook.com
 (2603:10a6:800:5b::23) by AM7PR08MB5336.eurprd08.prod.outlook.com
 (2603:10a6:20b:105::9) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.16; Wed, 16 Feb
 2022 08:17:01 +0000
Received: from VI1PR0801MB2125.eurprd08.prod.outlook.com
 ([fe80::5531:4c33:a50c:ea0e]) by VI1PR0801MB2125.eurprd08.prod.outlook.com
 ([fe80::5531:4c33:a50c:ea0e%9]) with mapi id 15.20.4995.016; Wed, 16 Feb 2022
 08:16:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d9cc0f39-8f00-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=PCsX5TWiQRdbBLDv8OYYrtYQkhBsOjbWFA2Z2jFtW/A=;
 b=jkVTlKEeBHUSW9fOJQHzswXjVZ7ONqzxwbp/3o7HW5IiZrZT3eP7E06f+QNN7n8ZRTC0GnjQtXW9uc/Cr+p1eDGBESewN2fTFtlOPO82lvZoNKOeY83k/Wg6SEM2MfQhKFzBdw6ixDoJQkSUXEz70eQxqdHT+fht7OVfx7BXR4g=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: fc015dd556840793
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ZC/Qy3r8ksPghizDKY37BrfjrEq5i8WU0mXEoL7UQR3oMpikZVcxinXf7KsJmswgLcwxRzldunwTOwLnCwEeUwPq6D0VHPNFB5M33wdf12BT7K1ujwAIv8b4MsYL5ev1LlNHR6+Z1cs9VokZYzRHNVD5PVeyWa9xQdi0nhdpdX3k3KpchfaSYu6vN63eGWuTxJ7vIqyDVg6xQymL5fjPMjNB2MXoWY52DMBpewHq7a2wVU1ejWvQZuwHWlgvFB4g0kVwY709Oyz6LxTATBtjkD/wBbOR2EOjDbkcdy6JPYukFhZeAg+XyPFmDK02qXRtlr9/SkhFeTgdqF9M80bNzg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=PCsX5TWiQRdbBLDv8OYYrtYQkhBsOjbWFA2Z2jFtW/A=;
 b=UcKfIR80TLCVwdQ/uwIZIX+QQa8EYWaSACxsPBrEoRCUPFI8sChv06oloWFPOzGyDFNGpdz+lxHcvksvHB2gbynhMnHLuuY7ntTtVtCd75tk3RY2Hh5erO08LbWhlDwk59VkFOMutQg9TUXCBZxo8DAo1wj79vZGHNRP4ULIYnMUSYoE6+r51dgVE7jLb3jVdTVT2Emt9Yb8L7e2Gx6mJi4mWKjgXtQuO44i909eWMb4xV0j+JR7zaAWrDms61+ESKfIGTBmdWtUyPLMuzSdsdYCWbjaXnNwwb+RFwpXyWrpdj8DSz1r2Dx4382ROlIcVb+TCI3hrrThtPVXBSZTbQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=PCsX5TWiQRdbBLDv8OYYrtYQkhBsOjbWFA2Z2jFtW/A=;
 b=jkVTlKEeBHUSW9fOJQHzswXjVZ7ONqzxwbp/3o7HW5IiZrZT3eP7E06f+QNN7n8ZRTC0GnjQtXW9uc/Cr+p1eDGBESewN2fTFtlOPO82lvZoNKOeY83k/Wg6SEM2MfQhKFzBdw6ixDoJQkSUXEz70eQxqdHT+fht7OVfx7BXR4g=
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
Content-Type: text/plain;
	charset=utf-8
Subject: Re: [PATCH 1/5] tools/cpupools: Give a name to unnamed cpupools
From: Luca Fancellu <luca.fancellu@arm.com>
In-Reply-To: <8763ed2b-ce5d-12eb-1ea2-542e8024764b@suse.com>
Date: Wed, 16 Feb 2022 08:16:55 +0000
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
 wei.chen@arm.com,
 Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <994A7B5F-DC53-411A-ABB2-4D7E8B77EF63@arm.com>
References: <20220215101551.23101-1-luca.fancellu@arm.com>
 <20220215101551.23101-2-luca.fancellu@arm.com>
 <efd968bb-e3f6-9e16-3826-4cab25127718@suse.com>
 <71460E15-5D09-4CE6-99ED-4858147BB0D0@arm.com>
 <8763ed2b-ce5d-12eb-1ea2-542e8024764b@suse.com>
To: Juergen Gross <jgross@suse.com>
X-Mailer: Apple Mail (2.3693.60.0.1.1)
X-ClientProxiedBy: LO2P123CA0076.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:138::9) To VI1PR0801MB2125.eurprd08.prod.outlook.com
 (2603:10a6:800:5b::23)
MIME-Version: 1.0
X-MS-Office365-Filtering-Correlation-Id: 99e0bd87-56ab-4fd6-a0e9-08d9f124bbb8
X-MS-TrafficTypeDiagnostic:
	AM7PR08MB5336:EE_|DB5EUR03FT044:EE_|AM5PR0802MB2564:EE_
X-Microsoft-Antispam-PRVS:
	<AM5PR0802MB25640163176EAAC337E51ACFE4359@AM5PR0802MB2564.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 Z5J9RW+wx8FiQWqumtigq8kYXvGbXJxnjR2AIOj7TGrOtd6nak5kgPhoS/zYItF2N6BoTw4EveKo5jr9zarfurEc90/vH35tdS3l86D0dsl9qbhk2OLrD4DAYhPOiWCvpzd6hRJgUdqogBC3YF/cqStL2N8zcp87RjMu28pSiGFXw2v46OzyaAHfiutz6ArWBYgPBIscjNkXYMaW1BFyMG7M8wzfiDwVqU0uI67w4OmWE0fJzlaGsC98mxWIXQRnDKez/0rv5HaiXxD5YcosewVbBHi5IwOfp/pQPIIC4o0UyLZjAzaDDyYXL4micYVOeR1WIyFbyYhphqr3MM5fEWw/31PgA+J6a2f+CdtIki4Tuu8+X3mSdZujcDJN1O1qNjcCO5oDK0SmaA9wqLjtfQ/k88VyLSMMlYjw3yyJvjePz0m+m7ce0knPQBwGeb03X3Tklg1m4bVpMddDfrNrX9kGTg9giOzNs9eR2f2PwGpRi8Y68mZOp6VOk1oqiQHC6dV3tdkVHjSOcHmTxTHGTdo9P8FdvWU01uqG2au3UDjpOzkxQa23GwEReXVSfX3VMSzUahOj0i33FgmJLG3CR5KFG2RXydewJqZmkomZUcR+ZDXKgwbthtcOVPUakH8BxASdkbQwt/fVYV5qylHxHiY9f3B0uiZOdSCk5GM5xIppQ2HE3g2VbnlOkpP3+hJcZLsfwPdCjxVn/YcZjwfDcVyQjaVKA5S0242qi2iRUOY=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR0801MB2125.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(36756003)(52116002)(33656002)(5660300002)(53546011)(316002)(508600001)(6916009)(54906003)(6486002)(38100700002)(38350700002)(8676002)(66946007)(66556008)(86362001)(66476007)(83380400001)(4326008)(6506007)(8936002)(6666004)(6512007)(186003)(44832011)(26005)(2616005)(2906002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5336
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT044.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	7ade7d57-d749-4008-bc6f-08d9f124b382
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	gjUXQXJ77vZTQj1HmYYdTzasBhna3Mob1f/aE5Av8D5UDy/Sp6bO6jmCYc2as2PFUsaBd0W0c4sCZ2cMjDxJLYkMyafMCwUwIa0fUdit4P1VkLvi1Nkj+lp7Vi2CUSrFMRLB62c+jo+qVXdVpYYyC0qTHaj1Mleiqe697NqrzgLNdNZ9T626fZb1PLrxpLhT5/nfFnT4axM6p5KnAUqTgLwoWUeNjrvQQx10ecqoWIAYlqPRe4fVZi3ND54W2PBWkA+G+t3Ni8fsMrAB1meY+wbBVeQDbDKYytfEZjGTurjGZCNUfsL0l5HP+SpZiHY5PLWwqy85+z7jtrzY6hzbfgSielnXZjZQrkKrJD6E27ey/y4jkDw5TnwH8sH04L8x5NmSOpUKtMZxJJk/mB/XCNAkV96NivhWrPDOpGxqk1A594ko6hKtm1flDwZVQhALYGF2NWr9hFOH0ZtKS0YZoHLXRsxXzsdh4uTi7WtHG8+mm2cjNPCKEh5WhK3u2ay/fe51QaMGn4U59PWN/75cl/9bNPc4jMxN5X9leRW8TcYgJEzb/Y87xJ2OXZsah2d1eGH+q/t5q4p0dZOcNO/KO5X/63p1cmH9rAwlB6DMMQEvbZvgfJ1Q1qMPy/ixjLUTIOHAqMjQ8llhSvLddQAfBfgd9JikZN3l20yjOmYMY5RsBRov8qZErtyiy4Y3+YxV
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(316002)(2906002)(5660300002)(508600001)(47076005)(82310400004)(6486002)(8936002)(54906003)(36756003)(8676002)(356005)(44832011)(70586007)(70206006)(81166007)(6862004)(40460700003)(4326008)(36860700001)(6512007)(83380400001)(2616005)(186003)(53546011)(86362001)(33656002)(336012)(107886003)(26005)(6666004)(6506007);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2022 08:17:12.0035
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 99e0bd87-56ab-4fd6-a0e9-08d9f124bbb8
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT044.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0802MB2564



> On 16 Feb 2022, at 06:13, Juergen Gross <jgross@suse.com> wrote:
>=20
> On 15.02.22 18:48, Luca Fancellu wrote:
>>> On 15 Feb 2022, at 10:33, Juergen Gross <jgross@suse.com> wrote:
>>>=20
>>> On 15.02.22 11:15, Luca Fancellu wrote:
>>>> With the introduction of boot time cpupools, Xen can create many
>>>> different cpupools at boot time other than cpupool with id 0.
>>>> Since these newly created cpupools can't have an
>>>> entry in Xenstore, create the entry using xen-init-dom0
>>>> helper with the usual convention: Pool-<cpupool id>.
>>>> Given the change, remove the check for poolid =3D=3D 0 from
>>>> libxl_cpupoolid_to_name(...).
>>>> Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
>>>> ---
>>>>  tools/helpers/xen-init-dom0.c  | 26 +++++++++++++++++++++++++-
>>>>  tools/libs/light/libxl_utils.c |  3 +--
>>>>  2 files changed, 26 insertions(+), 3 deletions(-)
>>>> diff --git a/tools/helpers/xen-init-dom0.c b/tools/helpers/xen-init-do=
m0.c
>>>> index c99224a4b607..3539f56faeb0 100644
>>>> --- a/tools/helpers/xen-init-dom0.c
>>>> +++ b/tools/helpers/xen-init-dom0.c
>>>> @@ -43,7 +43,10 @@ int main(int argc, char **argv)
>>>>      int rc;
>>>>      struct xs_handle *xsh =3D NULL;
>>>>      xc_interface *xch =3D NULL;
>>>> -    char *domname_string =3D NULL, *domid_string =3D NULL;
>>>> +    char *domname_string =3D NULL, *domid_string =3D NULL, *pool_stri=
ng =3D NULL;
>> Hi Juergen,
>>>=20
>>> pool_string seems to be unused.
>> I will remove it
>>>=20
>>>> +    char pool_path[strlen("/local/pool") + 12], pool_name[strlen("Poo=
l-") + 5];
>>>=20
>>> I don't like that. Why don't you use pointers and ...
>>>=20
>>>> +    xc_cpupoolinfo_t *xcinfo;
>>>> +    unsigned int pool_id =3D 0;
>>>>      libxl_uuid uuid;
>>>>        /* Accept 0 or 1 argument */
>>>> @@ -114,6 +117,27 @@ int main(int argc, char **argv)
>>>>          goto out;
>>>>      }
>>>>  +    /* Create an entry in xenstore for each cpupool on the system */
>>>> +    do {
>>>> +        xcinfo =3D xc_cpupool_getinfo(xch, pool_id);
>>>> +        if (xcinfo !=3D NULL) {
>>>> +            if (xcinfo->cpupool_id !=3D pool_id)
>>>> +                pool_id =3D xcinfo->cpupool_id;
>>>> +            snprintf(pool_path, sizeof(pool_path), "/local/pool/%d/na=
me",
>>>> +                     pool_id);
>>>> +            snprintf(pool_name, sizeof(pool_name), "Pool-%d", pool_id=
);
>>>=20
>>> ... use asprintf() here for allocating the strings in the needed size?
>> Why would you like more this approach? I was trying to avoid allocation/=
free
>> operations in a loop that would need also more code to check cases in wh=
ich
>> memory is not allocated. Instead with the buffers in the stack we don=E2=
=80=99t have problems.
>=20
> My main concerns are the usage of strlen() for sizing an on-stack array,
> the duplication of the format strings (once in the arrays definition and
> once in the snprintf()), and the mixture of strlen() and constants for
> sizing the arrays.
>=20
> There are actually some errors in your approach for sizing the arrays,
> showing how fragile your solution is: you are allowing a "positive
> integer number" for a cpupool-id, which could easily need 10 digits,
> while your arrays allow only for 5 or 4 digits, depending on the array.
>=20
> And doing the two asprintf() calls and then checking that both arrays
> are not NULL isn't that much code. BTW, your approach is missing the
> test that the arrays have been large enough.
>=20
> The performance of that loop shouldn't be that critical that a few
> additional microseconds really hurt, especially as I don't think any
> use case will exceed single digit loop iterations.

Hi Juergen,

Thank you for your explanation, totally makes sense. I took inspiration fro=
m
libxl_cpupoolid_to_name in libxl_utils.c writing this code but I see the li=
mitation
now.

I will change it to use asprintf().

Cheers,
Luca

>=20
>>>=20
>>>> +            pool_id++;
>>>> +            if (!xs_write(xsh, XBT_NULL, pool_path, pool_name,
>>>> +                          strlen(pool_name))) {
>>>> +                fprintf(stderr, "cannot set pool name\n");
>>>> +                rc =3D 1;
>>>> +            }
>>>> +            xc_cpupool_infofree(xch, xcinfo);
>>>> +            if (rc)
>>>> +                goto out;
>>>=20
>>> Moving the call of xc_cpupool_infofree() ahead of the call of xs_write(=
)
>>> would drop the need for this last if statement, as you could add the
>>> goto to the upper if.
>> Yes you are right, it would simplify the code
>>>=20
>>>> +        }
>>>> +    } while(xcinfo !=3D NULL);
>>>> +
>>>=20
>>> With doing all of this for being able to assign other domains created
>>> at boot to cpupools, shouldn't you add names for other domains than dom=
0
>>> here, too?
>> This serie is more about cpupools, maybe I can do that in another commit=
 out
>> of this serie.
>=20
> Fine with me.
>=20
>=20
> Juergen
> <OpenPGP_0xB0DE9DD628BF132F.asc>



From xen-devel-bounces@lists.xenproject.org Wed Feb 16 08:42:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 08:42:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273771.469021 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKFsn-0002SZ-5f; Wed, 16 Feb 2022 08:41:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273771.469021; Wed, 16 Feb 2022 08:41:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKFsn-0002SS-2S; Wed, 16 Feb 2022 08:41:53 +0000
Received: by outflank-mailman (input) for mailman id 273771;
 Wed, 16 Feb 2022 08:41:52 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Gpsw=S7=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nKFsm-0002SM-8B
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 08:41:52 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 485c9b1d-8f04-11ec-8eb8-a37418f5ba1a;
 Wed, 16 Feb 2022 09:41:50 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2174.outbound.protection.outlook.com [104.47.17.174]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-28-88pdkn36O6y8ZFF5rGNB8w-1; Wed, 16 Feb 2022 09:41:48 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DB6PR0402MB2837.eurprd04.prod.outlook.com (2603:10a6:4:98::9) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.16; Wed, 16 Feb
 2022 08:41:46 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4995.016; Wed, 16 Feb 2022
 08:41:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 485c9b1d-8f04-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645000909;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=3C9KLmoWGgH3dVrkp1s13qieYY2/tIcI6qYtHjWt9pw=;
	b=WqEEy28whNjEFV4r8mGpz7gVfmwDgQLZgMaqLMXShe+G/6lAex1yOeCQcYF8EY62bBO3sR
	04QwcM9DO1lVJHYvIOHZVFBp8Q3dLuLUMVTQhbPGey/FUdNBcBGocdRWr+k1vSENNV55+n
	6bNXy2kTGq5EHxDfWUZXDX16j1QwnXQ=
X-MC-Unique: 88pdkn36O6y8ZFF5rGNB8w-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=fA1wyMFb7YHy2hihRgLHS/tZW5/Maim9PfZAJgT/cA7Atv+oBxiG04H/tbgz0WfvI2ueEObgdnCxe1ce/HgibAy2Ok236Zqb8YKIKf30dndOgyVeovf2TlKX2j42r9V34U4++rPbHJU0OZz33Z/DoQpS+FA5Wu68qzmSioztfJgdG0iN0hQHiLwt3wMxZmI13jQ/uGDQHHak1LwxerTxUsmIL68lqvFxq5gTKveEouLqL0aZnBx8X2C1cDtHI7sgVj3h/M47nlFSMnUZRSCALH27qs5ahf0ojBtDpAMwRHVHIjeI/FCHhV2AByJ3lTIP/sEc+IqzKdlp9sIyS9BKFw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Alk9KMejPJ+5ydPZltrpBZ3oRaO32Id6ixGtBB0nXbU=;
 b=YQWwi3LY91YvKXF4MkfotNccA32etA85midRNUHGJP27RUF7O+JOTop/YhMGTDTxSmhqotp+k73yrQ3QA0QyAiGCBefXiIy5aZU9uYGL/yD3VWhFeTgpr/sLXa28zp4iuBCWyuwRrjNetoBP3V/S5fUhdjQMC+7cg8iO9vv67PeShwr5NEWsaGad/BdQu8BeI9AwjJZRgcdtke6ysLFdvLp2uLACtYQK5cUkmtrM/klPLTBaUmlG9enYQGdpTojS+WgfsK4Qiu4XtqBLqq88cMcQamy7jLaAa3Oi64mI3gvVCAdXfYCAadGLk1lcHg5N6fDvX6amzDnExreMK4GByQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <7c5ff089-780b-9965-4765-be3ef210a913@suse.com>
Date: Wed, 16 Feb 2022 09:41:44 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH v2 07/70] x86: Build check for embedded endbr64
 instructions
Content-Language: en-US
To: Andrew Cooper <amc96@srcf.net>, Andrew Cooper <andrew.cooper3@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>,
 =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= <marmarek@invisiblethingslab.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
 <20220214125127.17985-8-andrew.cooper3@citrix.com>
 <95c29039-302c-256b-d381-2b5b8b9c1a4a@suse.com>
 <8c6d9714-7e45-1603-a5ad-d49fc060304e@srcf.net>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <8c6d9714-7e45-1603-a5ad-d49fc060304e@srcf.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0351.eurprd06.prod.outlook.com
 (2603:10a6:20b:466::17) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 330de225-4ec7-41d0-0cf1-08d9f1282a67
X-MS-TrafficTypeDiagnostic: DB6PR0402MB2837:EE_
X-Microsoft-Antispam-PRVS:
	<DB6PR0402MB2837DF761AF3992F530703B9B3359@DB6PR0402MB2837.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7219;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	I48/Dh98dpQkEeLlcW/L+y5TbUua8g+mrhP+/D/zIHeDlRnb9NSeOuEpZMC27PkAN2LYdyR/kndj5AmqvHFo7Yyw1141hmrLi3VeQx9HjGvu9B6r2W6YV/0k/JYMPNp4UyI3Di6alHhRDMXWqVUhek+E4yJ5JMPnBq5yryRHhVUuWKcYAhUQvJG9Kduf0CtXlANnn2nqSNzV3PsJudiL/KsWSTMPetqZ5NsZ3/ycvid0Ci6ChyBP3pPUxrdJG8ZaQoWislqGFwY0owZiEt2uojQoIh3pItowIG/F58Pm/IUH7E0G61X/fiL9Envd7wYIZ7yljU7hKfwybLsJ8Uq7op0gITB5qj1Wd7Yf9gjgvNL6xwWLyoMVic/4D3PJH7l4mgFInpkliCoaxq2a2FgHDPk2VHbsuuylKEx1KvZHa8zyY3frSVdHiwzQ14/yB3CHQDJql5O1jp+AM+grPnN0UYC3AZ+Yu/ExuD/SYLc85K4pP3gOWZIfmnYRXMhg50W7Oru601Bw/U6dIe324DeFdwBf4a6ZlmaFivkE3+zAzr1HM2tSu7IVxbgFLiDwE0Is9TOjb4GPvw1cmrep0ejrmhLIu4CUW/rXvNStllxEBJPljZm99g4nsPDwRU7oJaVLDKdfdpcavuY33nIXZX7jKkIwM5pCPNtMVlygygThkYScIE8AANHyeuF01PC5JfN8Win1Q3VNFzz9drUPRGQbyGZJHz9wI3vrZZyeeov3mL4=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66556008)(66476007)(4326008)(8676002)(8936002)(38100700002)(53546011)(66946007)(6506007)(26005)(186003)(5660300002)(2906002)(6512007)(2616005)(6486002)(31686004)(31696002)(54906003)(110136005)(36756003)(83380400001)(86362001)(316002)(508600001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?9yKzi6P894kw0UDtRHjc0jvgSwm3kIDc1+MUt5qyO6foexNe32daH5I6+s1Q?=
 =?us-ascii?Q?Ke49O1sikUucyNw6N/dui6elCWQ/cW4PEMBwEevWu+TVHGD2KPeWyhSHqTNp?=
 =?us-ascii?Q?v16Rbcpwm6OhhSuWYwnRohTqneBoc2oqQrREElNxwW+MWC82+/lIcsz0aOgE?=
 =?us-ascii?Q?w2x90+Kfj+OYbHgIPT7ONQDHETV6J0EYF5Rlpo3LvmaCkQ0p3vA9q4P+EZ2b?=
 =?us-ascii?Q?GH1Mk+y0rX8xLE78vHF+/bUqTjG/ZSzgUMCAO35VGeHCm/pSPbwUgys/cFt/?=
 =?us-ascii?Q?Og7Md45Y4lEdxyZrhDfsHCUfi8wwDAUCA/HUJz1Z+1O7RzFvvckUuJLG5YFr?=
 =?us-ascii?Q?3ZItubQFDcsC8fz48KaUQ5qQKlkHmJv+JM2pMlQvkRz7UIxghbcUcqC9HPph?=
 =?us-ascii?Q?z9dZpKLOAEsrpwWJgGFVSUNeiJ7CWmuP6tENVcP6rGGMmg76FFgXnKOlMmG9?=
 =?us-ascii?Q?1AxQ+sn6u2XS0tbfRP35gmzD/hl7aHagrKoKTjntDamPuuX9ZJpwAivKRM55?=
 =?us-ascii?Q?4Hx/+2BrJQLke1LrP8UZjLj9ZmMM6we1w63GKygmBVecpmM5HsLeLbMI4puv?=
 =?us-ascii?Q?7OXgn3kq73UdxoyxeEGvfL4si4exV1u2IiUEjPEn/0/hZw4KukUCFLXYaDJu?=
 =?us-ascii?Q?2gAWnUqwpj858qwZxqRwQWqSgL8cP+amEL/pTxrvjgt69MMvqtD9DUvmngsQ?=
 =?us-ascii?Q?S5Kjs65A68Cid8OvfYrMbWw27/D2dJgDL+BYnxKIFxgyeIBVeJHgyWh65rNl?=
 =?us-ascii?Q?td3FSb3+F+3mpR0gCE+Sl1ye+3Y07i8Z2NWVyNyq80pA2DAIvZenNytOmhq4?=
 =?us-ascii?Q?g8ZVmAnyO7kImM8rtxU17uSI+0LvLZNkt8qnuZp7BK61QlTWMhVtMFHO4xDJ?=
 =?us-ascii?Q?t4uKJGmKH8+CXnec8IZ+aGGViML3CAnZ5HnlngR+LxX9/eW+C5UiQQIO0zp7?=
 =?us-ascii?Q?nYlsnXvXZ9OpkL4tGAw1z2ai8HBo1qFxo7Yg6PysYnLjP5TjGSXATUg9JfEf?=
 =?us-ascii?Q?qIEyq3io7XUM7IIfvrMeP8vjMcJ7b3G6At6TJRif3R/ntspz0a/QwZTuUtwD?=
 =?us-ascii?Q?61yWly4t8bC8vuppLQ5aRK8BjDqigYhZYAier9H0yJSVY5Z9X55MwBu5yP+1?=
 =?us-ascii?Q?SWu7fxVtdPcNnCOCKJraCtanKmkYvuzRmOVVrCeUDfP/i7QHodPJBrE5Cap8?=
 =?us-ascii?Q?5eBNDMaG51Qt7I1pxULbAQFgtIb118LIPzD/BAhrPmHCtBepwlvClAPgniGs?=
 =?us-ascii?Q?Qnac/molIedlVx1F7d82W6zdUcGx1PFG4E6ws/4YSysegquj9ocXwUUwzdlz?=
 =?us-ascii?Q?Kl1Ci4TmPfFiTclAuewEg27PGYlbGoiNUGLseNc+J8elNljtlFsD5CbB0ucX?=
 =?us-ascii?Q?KpIJUuN/rjPTJ+rJw+huAXqpCratb2dj3+mQi+tQBo5qE7rNPXU6XaKrnVVs?=
 =?us-ascii?Q?dTdoxGm5eUXMw6Vdbga2OdZuHxAiFsHy2N8zQkqhknAaNsi6iFBGVg9l4ri5?=
 =?us-ascii?Q?Iae9bGDf5MlXv4XwBgY47unX05HU45u9rgzurKozPURTDVaBW34ZTKgrUB7g?=
 =?us-ascii?Q?QvglUJFH4R5blBv6ay7Vi8yn75jlJI+yjlTdNdB2nbrrMaMKdh8ezG5kmJog?=
 =?us-ascii?Q?fftVnH5QO14JfG0WCda247Q=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 330de225-4ec7-41d0-0cf1-08d9f1282a67
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2022 08:41:46.3424
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JnRr/hS6XoTQX7GLUZie7i+i7vPFMMDYEdt+6B8yw2/S36pi8Ub7ZYKLVKl3Y7foWDnOy/XylLGe43ZYiwfFbA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0402MB2837

On 15.02.2022 18:52, Andrew Cooper wrote:
> On 15/02/2022 15:12, Jan Beulich wrote:
>> On 14.02.2022 13:50, Andrew Cooper wrote:
>>> --- /dev/null
>>> +++ b/xen/tools/check-endbr.sh
>>> @@ -0,0 +1,76 @@
>>> +#!/bin/sh
>>> +
>>> +#
>>> +# Usage ./$0 xen-syms
>>> +#
>>> +
>>> +set -e
>>> +
>>> +OBJCOPY=3D"${OBJCOPY:-objcopy} -j .text $1"
>>> +OBJDUMP=3D"${OBJDUMP:-objdump} -j .text $1"
>>> +
>>> +D=3D$(mktemp -d)
>>> +trap "rm -rf $D" EXIT
>>> +
>>> +TEXT_BIN=3D$D/xen-syms.text
>>> +VALID=3D$D/valid-addrs
>>> +ALL=3D$D/all-addrs
>>> +BAD=3D$D/bad-addrs
>>> +
>>> +#
>>> +# First, look for all the valid endbr64 instructions.
>>> +# A worst-case disassembly, viewed through cat -A, may look like:
>>> +#
>>> +# ffff82d040337bd4 <endbr64>:$
>>> +# ffff82d040337bd4:^If3 0f 1e fa          ^Iendbr64 $
>>> +# ffff82d040337bd8:^Ieb fe                ^Ijmp    ffff82d040337bd8 <e=
ndbr64+0x4>$
>>> +# ffff82d040337bda:^Ib8 f3 0f 1e fa       ^Imov    $0xfa1e0ff3,%eax$
>>> +#
>>> +# Want to grab the address of endbr64 instructions only, ignoring func=
tion
>>> +# names/jump labels/etc, so look for 'endbr64' preceeded by a tab and =
with any
>>> +# number of trailing spaces before the end of the line.
>>> +#
>>> +${OBJDUMP} -d | grep '	endbr64 *$' | cut -f 1 -d ':' > $VALID &
>> Since you look at only .text the risk of the disassembler coming
>> out of sync with the actual instruction stream is lower than when
>> 32- and 16-bit code was also part of what is disassembled, but it's
>> not zero.
>=20
> I'm not sure that we have any interesting non-64bit code at all in .text.
>=20
> _start is technically 32bit but is mode-invariant as far as decoding goes=
.
>=20
> The kexec trampoline is here too, but when I dust off my cleanup patch,
> there will no longer be data or mode-dependent things to disassemble.
>=20
> Everything else I can think of is in .init.text.
>=20
>> Any zero-padding inserted anywhere by the linker can
>> result in an immediately following ENDBR to be missed (because
>> sequences of zeros resemble 2-byte insns).
>=20
> I'm not sure this is a problem.=C2=A0 This pass is looking for everything
> that objdump thinks is a legal endbr64 instruction, and it splits at labe=
ls.

Oh, right - I did miss the splitting at labels aspect. Hopefully
objdump is really consistent with this.

> Only the hand-written stubs can legitimately have an endbr64 without a
> symbol pointing at it.
>=20
> We also don't have any 0 padding.=C2=A0 It's specified as 0x90 in the lin=
ker
> file, although I've been debating switching this to 0xcc for a while now
> already.

The linker script comes into play only in the final linking step.
Prior "ld -r" could easily have inserted other padding.

>>> +#
>>> +# Second, look for any endbr64 byte sequence
>>> +# This has a couple of complications:
>>> +#
>>> +# 1) Grep binary search isn't VMA aware.  Copy .text out as binary, ca=
using
>>> +#    the grep offset to be from the start of .text.
>>> +#
>>> +# 2) AWK can't add 64bit integers, because internally all numbers are =
doubles.
>>> +#    When the upper bits are set, the exponents worth of precision is =
lost in
>>> +#    the lower bits, rounding integers to the nearest 4k.
>>> +#
>>> +#    Instead, use the fact that Xen's .text is within a 1G aligned reg=
ion, and
>>> +#    split the VMA in half so AWK's numeric addition is only working o=
n 32 bit
>>> +#    numbers, which don't lose precision.
>>> +#
>>> +eval $(${OBJDUMP} -h | awk '$2 =3D=3D ".text" {printf "vma_hi=3D%s\nvm=
a_lo=3D%s\n", substr($4, 1, 8), substr($4, 9, 16)}')
>>> +
>>> +${OBJCOPY} -O binary $TEXT_BIN
>>> +grep -aob "$(printf '\363\17\36\372')" $TEXT_BIN |
>>> +    awk -F':' '{printf "%s%x\n", "'$vma_hi'", strtonum(0x'$vma_lo') + =
$1}' > $ALL
>> None of the three options passed to grep look to be standardized.
>> Is this going to cause problems on non-Linux systems? Should this
>> checking perhaps be put behind a separate Kconfig option?
>=20
> CI says that FreeBSD is entirely happy, while Alpine Linux isn't.=C2=A0 T=
his
> is because Alpine has busybox's grep unless you install the GNU grep
> package, and I'm doing a fix to our container.
>=20
> My plan to fix this is to just declare a "grep capable of binary
> searching" a conditional build requirement for Xen.=C2=A0 I don't think t=
his
> is onerous, and there no other plausible alternatives here.
>=20
> The other option is to detect the absence of support an skip the check.=
=C2=A0
> It is after all a defence in depth scheme, and anything liable to cause
> a problem would be caught in CI anyway.

I'd favor the latter approach (but I wouldn't mind the conditional build
requirement, if you and others deem that better), with a warning issued
when the check can't be performed. I have to admit that I didn't expect
there would be no simple and standardized binary search tool on Unix-es.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Feb 16 08:49:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 08:49:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273778.469032 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKG0V-000391-1c; Wed, 16 Feb 2022 08:49:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273778.469032; Wed, 16 Feb 2022 08:49:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKG0U-00038u-Tf; Wed, 16 Feb 2022 08:49:50 +0000
Received: by outflank-mailman (input) for mailman id 273778;
 Wed, 16 Feb 2022 08:49:50 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Gpsw=S7=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nKG0U-00038o-1R
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 08:49:50 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6550103d-8f05-11ec-b215-9bbe72dcb22c;
 Wed, 16 Feb 2022 09:49:49 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2056.outbound.protection.outlook.com [104.47.14.56]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-28-_VrOifNbOEiZc1aBBO5g0g-1; Wed, 16 Feb 2022 09:49:46 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM8PR04MB7985.eurprd04.prod.outlook.com (2603:10a6:20b:234::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.14; Wed, 16 Feb
 2022 08:49:45 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4995.016; Wed, 16 Feb 2022
 08:49:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6550103d-8f05-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645001387;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=ZUXdphll59OTG+Uy4/FRwf9KSE+cmbXLeSYJ6dESNVI=;
	b=C/Yk6BC1idBgiGxC+T9daPpRLZ9m5cmuQOVBLPL30xeec5A0Cn+Z7zov5OfaZrNukdgMR9
	+ZhW+DLbVVKZzJKJeX2Q8uZbqbxmHOLyihya8KvPzC/iq/2UkzUZoQr71+9oGsbeuI3kP5
	CtnHv/Z7t/dsdFRuljOyQTmI1aYl/Y0=
X-MC-Unique: _VrOifNbOEiZc1aBBO5g0g-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=EL0cm5otvBhqpspECtvM0YKjnPmoBslj0Es6Cj+Og3Bsb7F2/Kq/x56UzsN7sIiE1Q0B83ItEY+2YOV4KP/dWsv8B3E/uC1zlZTAj9Yu4cgfcB3QeGwTtNkvve4WMAsEalM3vLSMEra2hnNCnLkCWelF0XjwJIzs2uwbW8DwPqmrZzHf3RezcVNu+96erl2+3+b3aPO1+Oq8ayRU76l8naZd/SsKjfdeJpEn1Da47iMWpgTFTy+F6w0ZyT06eg/QMdDZ4f8KOyWjS6dPbrdNutLzp7+XJUkiG0Mi6RXscAzYDusEn12ifAvf21QW1I48A/Qn2euhja5A2rYdlS8WDw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=lt0WqcjgodoNc9JCiCyXPdsLIcJAN19KQjqt4nQGX5Y=;
 b=IHDw4g60vu+hM8qwO1J/pl8F9uIuVQNAhnne3GC7bhWT57oP8zTBxgwNlb4k4jWPSsVxOJkW1SdehMTXdNtAJZfWxeVemU5amnOK+CzS7FtcDsu8Tsu0OYYvoiXw6e7tS6IlAk6pt6TjF9S1jBcOCPJNV1uhQSJXgbOh2tExqZIPAo9vaQHyRtr1pULYY2YUKHTxVhUDn2N4CjPaV6ZB+IloTrwwo4im+4m/CubGrrOBZl4ExibMKYJfeSC9nNku7HubaXbG69AdalvvK7wKYyPloriV8eIVYqC95qvTg1JfQgT3UWdd3ahHj8Al2JHd3Y3bL6EY1iD4f3UenAlQFQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <41b56a02-fbd4-bb43-3e94-329dda5785f0@suse.com>
Date: Wed, 16 Feb 2022 09:49:43 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH v2 68/70] x86/setup: Rework MSR_S_CET handling for CET-IBT
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
CC: Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
 <20220214125127.17985-69-andrew.cooper3@citrix.com>
 <79617697-307e-b19b-71a9-7c8554aec481@suse.com>
 <029ee818-6cdd-6027-59f9-6ddf07ed01d0@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <029ee818-6cdd-6027-59f9-6ddf07ed01d0@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9P194CA0021.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:20b:46d::11) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c19b57de-e0b2-42eb-b9b7-08d9f1294800
X-MS-TrafficTypeDiagnostic: AM8PR04MB7985:EE_
X-Microsoft-Antispam-PRVS:
	<AM8PR04MB798540DE505CB5BF0426CC9BB3359@AM8PR04MB7985.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	suy12AGPerUSbd61MQ0IN7ZwEKyOMmHwqM4FX6aKi0dU9Q9iwk18HQ+/hSJc5mON405vvmDwmGhr20A6uH00tDOL3ORKZjhmOniqtko7coLAJVFHjNVEaCQY+ZpKr0va4L81izq6yyNBJasi/XA6YE66y5ErS41vbWpRSi2QsgYI4MHWPzt4vim2Fu6JJvRLZWhUu8vT+F78O5DuRhQUvkwZuVuo3Y9YDQQziduvxQXPel8m9A+u2ZcYz4B91Ryng0kMmapoR85R48RPxQudkR0iCKoNZmiWs1uaAIU/onsf18EoLkQGY8VluCKBx2/t9pWdh988esuNalbwJihuXyvrRS9jYC/X8xy60w6Ap5b8TpMeMazisb195CX+8TyBxGHZo7puOl/zEpVzEN95X34C6tzX0fpt/6VLm14FKdIxfPaTjgY2J4yO8/rFj+CM9zzo+ND9rC5pa3pRsN0vNX7Ebe4ET99m1wRg0AWw0G4YH8tK8/nFDAVwOFZ78wlRnOBWDuuFwvWmsGt3jUiez5ULik/kt7gVLmfTfGdTGpAMid/ngyUGWib1AjgrONBOdHUJYvay7UlaVswNtgjEDyLQ9sDZnH0BBiOpsM3nQTodnXgzyo6tpb+H+otkT5cu6UA3PmuX1QkRlDrxyA+xVCh8lPYvd9eR5ccFkWwjfv9mM7nIBd0k7/oCWwe5bZPvLGY1a9dJQMSosGPQb1Ip4mDSo3AVZ1MLa61Mv8GshtJXhJpK1Sn7j3zHAvkpOXsj
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2906002)(53546011)(26005)(54906003)(186003)(6512007)(6506007)(2616005)(316002)(83380400001)(38100700002)(31696002)(6916009)(6486002)(86362001)(508600001)(36756003)(5660300002)(66556008)(66946007)(66476007)(8936002)(31686004)(4326008)(8676002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?b+wn36gU3nNtzJJ7BboevuPFe99yG/ElDdJ2FII20Berd3/vTvzReSk5A5I3?=
 =?us-ascii?Q?fm0Nc6aY92KvIs1BsVGLVTHSdb1Hl3bGiVconhNVQB2RpmptIbv/qmLmJcPR?=
 =?us-ascii?Q?FUgJT0+j6uiIg/nMrMEhuE2IovI7rHsj0c/UU6y32cJYtaqzxjo90YKVKrOZ?=
 =?us-ascii?Q?a8greXKgJCX0UkZC2SL4fZ/tqX84UYpmJWsgB3NYHduWQw6QKCV5vbvDkKSz?=
 =?us-ascii?Q?iVqSDe7sl4tDVVxCzKT2K04a/uKjAtmJUscPYsckelIZJrBEFKOgBat2/KhU?=
 =?us-ascii?Q?w/s+zzwA1QgiMBC7Xq0o0HSW1Be3KQkWBx/VVcaVNftodTmI34mfJW7M4Bs3?=
 =?us-ascii?Q?ujRPK796r5lzmG5HvVQGGkNGV3UpPd4BKOp5SBnYNQQH+xIlw1/JSCwLtbGj?=
 =?us-ascii?Q?5kFPi6Q5YxqqwfanNDCCJFwfBduLF+M1dEg+ZKAcCMLUi3WqkAsX/575r2Ij?=
 =?us-ascii?Q?8I8sM33RrF//Q8BSihjbI2dE+G9iU2PR3hYJ9LqJfz0gZG/9lWYROavWkGIk?=
 =?us-ascii?Q?HsaxbvrtPyZDPD9Q7jESEt2ec71DlnsEXs3ovO6y8k9/B0N0KHEG4ICv93nm?=
 =?us-ascii?Q?vSzjXbEOgP2h+9GHDAwyRFYhFAdziBT2G8TqufibXn01Cq6E2Wx1XOlXOySu?=
 =?us-ascii?Q?mCA1kOaIryylwKJFWNV8AE0jCsfG9S2d1GDAKKgC5AdCAqzccPA73+Xie4+B?=
 =?us-ascii?Q?O6vZcz3ZkvucDYpxOPvMZXhPpi8felgHD7l5guzkK3+PPa+2mIzQ4mLxaxtF?=
 =?us-ascii?Q?5YcW2+MvuCGuE8fFiab69LPpQmOOWScsJWB8kqyKirTvmx9kY0OrGBhEOmgI?=
 =?us-ascii?Q?7srfwlLLiUdfvHCbr6CZE26zZAOV3gow8aHMazY3OEUfVt1JUgPnv9KHb0u2?=
 =?us-ascii?Q?6PB0gaOxpG6iz6whBWlzACMntZLfXeLLh2ZELyZRCStP46QOegaCH6J90W5Q?=
 =?us-ascii?Q?Rw94aamviZfPZWNkViAmpN0YePfrOy3nqzqUlSHeU/w4GEEJ9e1ZG4+R7RB1?=
 =?us-ascii?Q?hllKGXIUa0ilabwCNBB5v/706ZqFgk3iEbSDp5o+JSeomtw/4o9favJ6QH3y?=
 =?us-ascii?Q?XmhUuLg2BMQcYtb2te4Oc1dNG0hkJ4VSkwJph9WIUmTF3GHPN7xoQu4QxRCs?=
 =?us-ascii?Q?6pw90xatzXezWv3lTCvtdP346qZI4/VWKF3gz9dxml2BUESnTtbjDRje2cyi?=
 =?us-ascii?Q?NRZNAPcxgg1wAC5tucl5GL/2ymYkaW0j9nfy0PSSlcv3+nQ/yynSUKf2ExQV?=
 =?us-ascii?Q?eoaJhXSD6GkVXSkTj6UFJqCkdH4vDWnELzZJIC+mt0Ow3dlgMwbOALMqPOWA?=
 =?us-ascii?Q?SM4MmNi2b0jS/PKZm6+/5c81S5aB2grnpfpYLWu9zEDNyf/DLZRrnIzZBGhQ?=
 =?us-ascii?Q?9FlFgQE4eR7J1+JwYiFRhNhirwU26DKrCnkqZQrAD3LOjCdtJQjH4RzL0whE?=
 =?us-ascii?Q?8nruITA2LfONqE+5rT0B9O7Hw/YR1TDjNuzMJDruEbLHZEmRDYhuCy3Ez88p?=
 =?us-ascii?Q?QSi9E7oiPyUOretGqkbWRF7myiVtM7ZhcvEeRqOWIj3KwdZGdU2UTo4SW8u1?=
 =?us-ascii?Q?lh3Nd50msP4DmHE0214T82R7BAqH0M25YXKR7AzwxBD6UB13qoQ9m8H0pK2E?=
 =?us-ascii?Q?DTuCxpfqZI1L91v261Yj9gU=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c19b57de-e0b2-42eb-b9b7-08d9f1294800
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2022 08:49:45.5314
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pd/ASjmbiMEWxRjIxszlhQChUWNuNlGLQT9IXVdXYT+m2EQ74g98xjCAoBWdL7DJc/QdvIuKOej4JU8CXIv3EQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7985

On 15.02.2022 21:58, Andrew Cooper wrote:
> On 15/02/2022 16:46, Jan Beulich wrote:
>> On 14.02.2022 13:51, Andrew Cooper wrote:
>>> CET-SS and CET-IBT can be independently controlled, so the configuratio=
n of
>>> MSR_S_CET can't be constant any more.
>>>
>>> Introduce xen_msr_s_cet_value(), mostly because I don't fancy
>>> writing/maintaining that logic in assembly.  Use this in the 3 paths wh=
ich
>>> alter MSR_S_CET when both features are potentially active.
>>>
>>> To active CET-IBT, we only need CR4.CET and MSR_S_CET.ENDBR_EN.  This i=
s
>>> common with the CET-SS setup, so reorder the operations to set up CR4 a=
nd
>>> MSR_S_CET for any nonzero result from xen_msr_s_cet_value(), and set up
>>> MSR_PL0_SSP and SSP if SHSTK_EN was also set.
>>>
>>> Adjust the crash path to disable CET-IBT too.
>>>
>>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>> Reviewed-by: Jan Beulich <jbeulich@suse.com>
>=20
> Thanks,
>=20
>> albeit with a nit and a remark:
>>
>>> --- a/xen/arch/x86/acpi/wakeup_prot.S
>>> +++ b/xen/arch/x86/acpi/wakeup_prot.S
>>> @@ -63,7 +63,26 @@ ENTRY(s3_resume)
>>>          pushq   %rax
>>>          lretq
>>>  1:
>>> -#ifdef CONFIG_XEN_SHSTK
>>> +#if defined(CONFIG_XEN_SHSTK) || defined(CONFIG_XEN_IBT)
>>> +        call    xen_msr_s_cet_value
>>> +        test    %eax, %eax
>>> +        jz      .L_cet_done
>>> +
>>> +        /* Set up MSR_S_CET. */
>>> +        mov     $MSR_S_CET, %ecx
>>> +        xor     %edx, %edx
>>> +        wrmsr
>>> +
>>> +        /* Enable CR4.CET. */
>>> +        mov     $XEN_MINIMAL_CR4 | X86_CR4_CET, %ecx
>>> +        mov     %rcx, %cr4
>>> +
>>> +        /* WARNING! call/ret now fatal (iff SHSTK) until SETSSBSY load=
s SSP */
>>> +
>>> +#if defined(CONFIG_XEN_SHSTK)
>> Just #ifdef, as it was before?
>=20
> I can if you insist, but that's breaking consistency with the other
> ifdefary.

I guess consistent of not depends on the way you look at it. I
generally think simple conditionals should just use #ifdef. As
soon as there's an #elif or a more complex condition, #if
defined() is of course more consistent. But one #ifdef nested
inside another #if imo isn't a reason to use #if in both places.

Nevertheless, ftaod - I'm not going to insist, as I can see this
being a matter of personal preference.

>>> @@ -90,10 +101,6 @@ ENTRY(s3_resume)
>>>          mov     %edi, %eax
>>>          wrmsr
>>> =20
>>> -        /* Enable CET.  MSR_INTERRUPT_SSP_TABLE is set up later in loa=
d_system_tables(). */
>>> -        mov     $XEN_MINIMAL_CR4 | X86_CR4_CET, %ebx
>>> -        mov     %rbx, %cr4
>> The latter part of this comment could do with retaining.
>=20
> So I tried that in v1, and concluded not for v2.
>=20
> There is nowhere appropriate for it to live, anywhere in this block.=C2=
=A0
> And it is an artefact of me bootstrapping SHSTK to start with.
>=20
> The truth is that nothing about MSR_ISST_TABLE matters until
> load_system_table sets up both this and the TSS IST fields together.=C2=
=A0
> IST exceptions are already fatal at this point for non-SHSTK reasons.

Well, okay. To me, not being as familiar with this code as you
are, the comments was quite helpful ...

Jan



From xen-devel-bounces@lists.xenproject.org Wed Feb 16 09:03:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 09:03:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273786.469054 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKGDg-0005g5-Jb; Wed, 16 Feb 2022 09:03:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273786.469054; Wed, 16 Feb 2022 09:03:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKGDg-0005fy-GM; Wed, 16 Feb 2022 09:03:28 +0000
Received: by outflank-mailman (input) for mailman id 273786;
 Wed, 16 Feb 2022 09:03:27 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=oYE0=S7=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nKGDf-0005Pr-0f
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 09:03:27 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4ba13f4f-8f07-11ec-b215-9bbe72dcb22c;
 Wed, 16 Feb 2022 10:03:25 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4ba13f4f-8f07-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645002205;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:content-transfer-encoding:mime-version;
  bh=WENpvfDNE8/oapQGORit/gp77hoSL3t4hzn01DyGrFI=;
  b=Me+z+fJX2y0/uNAHJ4NPdPlRM9cJprZm6/gYxk0MuFpDz5D5B/cJPOuk
   ChsW/bbW3kkEbnZ9J1gon4nIxFUg+OIcnG5YvJ7Elst3E20D5hHyn5JWa
   1h4M6p8bjeeZ6wpO3ITgm/005o7sJpDn/L79BAxAMoWwjYhsAVJkJhSsl
   c=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: jIAXe5Vxu4CM9GEz4a5xJuIb5Ahw5XpIqKYwYMiMlF8t3J/8ZqM/z3fZHVfR8VoqISu6HGILdk
 rREPM29RDkG+C1Qu2IY0BU5DkF9q0D8VuHh4yRDDBhXAnth6zIj+i38z6RrkHPBxOWkijwRhEE
 zJUNkAglnSOQbHBQ2ah8zbUyCtBNzrEwdxT10x7ja0qUL7/ZEiLzzvK8uH7iZDsbP4/eiFPjNA
 JEE82ACrIoP6anNNVTdTlukZHougpf+yHbIDr3GpE2Jnq/1iWBl8cfGj4LryvPVdISke2euFSl
 5nO2hpqcIb1lCH1EwKLrcEcp
X-SBRS: 5.1
X-MesageID: 66555052
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:XcQIJq/vyKShVaQhluP9DrUDXHmTJUtcMsCJ2f8bNWPcYEJGY0x3n
 GQbCG/Sa/nYazCke41/bNy/900CsJDWxtFrSQo+rC48E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhFWeIdA970Ug5w7Rg3NYx6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhVw
 eUS9ryNGDtxYKKPxrQjYxNVHRxhaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguw5K8bmJsUHs2xIxjDFF/c2B5vERs0m4PcGgmpt25gTR54yY
 eJFRH1Qch3DZiFiFVYVJp0bueal2XDgJmgwRFW9+vNsvjm7IBZK+KfpGMrYfJqNX8o9tkSSq
 3/C/m/5KgoHL9HZwj2Amlq8i+mKkS7lVYY6ELyj6uUskFCV3nYUChAdSR28u/bRt6Klc4sBc
 QpOoHNo9PVsshzwJjXgY/GmiFqNjkFfe+cBL7Vk50LTmpTk6QuXO3dRG1atd+canMMxQDUr0
 HqAkNXoGSFjvdWpdJ6NyluHhWjsYHZIdAfucQdBFFJYuIe7/OnfmzqSFo4LLUKjsjHi9dgcK
 RiupTN2ubgchNVjO06TrQGe2GLESnQko2cICuTrsoCNs1sRiG2NPdXABb3nARBodtvxor6p5
 iVspiRmxLpSZaxhbQTUKAn3IJmn5uyeLBrXikN1Ep8q+lyFoiD/IdENuWsvdRYwaK7onAMFh
 meJ5Gu9A7cJYhOXgVJfOdrtW6zGM4C8fTgaahwkRoUXOcUgHON21CpveVSRzwjQfLsEyskC1
 WOgWZ/0Vx4yUP0/pBLvHrt1+eJ7l0gWmDKILbimnkvP7FZrTCPMIVvzGADVNb5RAWLtiFi9z
 uuzwOPQm0UFC7yhOHCKmWPRRHhTRUUG6VnNg5U/XsaIIxZ8GXFnDPnUwLg7fJdikbgTneDNl
 kxRkGcDoLYmrXGYewiMdF55b7bjAcR2oX4hZHR+Nle0wXkzJ42o6f5HJZcweLAm8s1lzOJ1E
 KZZK5nRXKwXR2SV4SkZYLn8sJdmKEahizWRMnf3ezM4ZZNhGVDEo4e2Ygv1+SASJSOrrs9i8
 aa43wbWTMNbFQRvBcrbcty1yFa1sSRPke5+RRKQcNJSZF/t4M5hLCmo1q07JMQFKBPiwDqG1
 lnJXUdE9LeV+4JsqYvHn6GJqYutAtBSJEsCEjmJ96uyOAnb4nGnnd1KXtGXcG2PT2jz4qijO
 7lYlqmuLP0dkV9WmINgCLI3n7km7t7iqrIGnARpGHLHMwaiBr96eyTU2MBOsutGx6NDuBvwU
 UWKo4EINbKMMcLjMVgQOAt6MbjTiaBKwmHfvaYvPUH3xC5r577WA0xdMi6FhDFZMLYoYpgux
 v0suZJO5gGy4vbw3g1qUsyAG7ywE0E9
IronPort-HdrOrdr: A9a23:gi13batuwAMAQHMUoL2Cv3h57skC7IMji2hC6mlwRA09TyXGra
 6TdaUguiMc1gx8ZJhBo7C90KnpewK6yXcT2/hvAV7CZnibhILMFuBfBOTZskTd8kHFh4tgPO
 JbAtJD4b7LfChHZKTBkXGF+r8bqbHtms3Y5pa9854ud3AWV0gJ1XYJNu/xKDwReOApP+tcKH
 LKjfA32QZINE5nJPiTNz0gZazuttfLnJXpbVovAAMm0hCHiXeN5KThGxaV8x8CW3cXqI1SvV
 Ttokjc3OGOovu7whjT2yv66IlXosLozp9mCNaXgsYYBz3wgkKDZZhnWZeFoDcpydvfpWoCoZ
 3pmVMNLs5z43TeciWcpgbs4RDp1HIU53rr2Taj8DLeiP28YAh/J9tKhIpffBecwVEnpstA3K
 VC2H/cn4ZLDDvb9R6NpuTgZlVPrA6ZsHAimekcgzh0So0FcoJcqoQZ4Qd8DIoAJiTn84oqed
 MeQv003MwmMm9yUkqp/FWGmLeXLzEO91a9Mwc/U/WuonhrdCsT9Tpd+CQd9k1wgq7VBaM0oN
 gsCZ4Y5o2mePVmGp6VNN1xMvdfNVa9NC4kSFjiWmgPNJt3c04l+KSHq4nc2omRCeg1Jd0J6d
 L8bG8=
X-IronPort-AV: E=Sophos;i="5.88,373,1635220800"; 
   d="scan'208";a="66555052"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Af6tIjKOtVUQrHbUplyOLy2st/jtjqZlBI6RkRbPbDddnW/XyCIeyVku3K3jEtiTzh6hbS2q2i3LzfLY4ipIJzLDfuIatHMqvdj/UhTf7tFIhV0o8Rhoj9SmoYT34jUfWzU9RmVEFCe9HCfPJ1DhBrQur0UFUfapaWa0K8R4aU9ul7f2QEAH7xcC4sVLFSqDNNTPHkY26S3t8tewOuXFEEVNSE8mnTLlxwdUMaaBDgihf0j/MwRm8bLHocAsEO2PDsPYJosaOPPArTqMMJ4iwqvKJ+NQ5BNiA4JnzqKjB69ROKZNiITXY80DHebU879J6cRk8fOspb1t1+QrCckZTA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=59r7fbZ3K+LcmEoyCa8BNqjqMu4sOS5sUKRPzfo807I=;
 b=DBpS0kWXM22tGUAlKqFmPblAc+gLjLRJ/C8P+HCTe13EOXTwztlvZ7jXkW72N5XnjAMUx0kvP44wM86LgA9ceBHVztICjes9NTyx73HYF6ggTJR6JnUJ+shRxQ/3+8FeVnWfEMhH3uSA8ojOSEAAsLX8XkWJbjgYKV2YkMOJhTLY5UQILpjUPyp8UZSGktqqsYJlDdQ+N/o/NFMLaitrRsrvBJ8yRFN3mQWKj53Yhmg9HzLuK10c8Vm2QVCnXpHNL64vUIpFJuoIIpupJo688qB6Te5p9v2LNzr7X7MOrhcmo0BfRtsrYgsICuJK8QABOvCDbrAvnRKt9R8pAbSPEw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=59r7fbZ3K+LcmEoyCa8BNqjqMu4sOS5sUKRPzfo807I=;
 b=Khx0ogaSgWq+Rh2fi7sNbVT7eNrWnpXf/J8suVrPur9BlAhfGFiKimPyj4G0EHtgBXQhKE/j7vt5zmJutjye383hHscFF/Z55imYBHKqqwsh4fsYaTVE7hSQrnIRFr6Nr6LGx8BgO5JqCWw4lTUGgURsHX6bptlfa4DzcHCwp2E=
From: Roger Pau Monne <roger.pau@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Roger Pau Monne <roger.pau@citrix.com>, Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: [PATCH 1/3] x86/retpoline: rename retpoline Kconfig check to include GCC prefix
Date: Wed, 16 Feb 2022 10:02:58 +0100
Message-ID: <20220216090300.9424-2-roger.pau@citrix.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220216090300.9424-1-roger.pau@citrix.com>
References: <20220216090300.9424-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO3P265CA0010.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:bb::15) To SA0PR03MB5610.namprd03.prod.outlook.com
 (2603:10b6:806:b2::9)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ac6e6ad0-fd85-4ff4-1786-08d9f12b2b72
X-MS-TrafficTypeDiagnostic: MWHPR03MB3104:EE_
X-Microsoft-Antispam-PRVS: <MWHPR03MB310454247B9FC084CBB854CF8F359@MWHPR03MB3104.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6108;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 3lbbXZGpyKFO2Qo66v6zPGMOjBsqvUGMYeFsgLnwByV/RARrCb86NlyhZGrBPIsOmIVq5kpiinxOg2AF3694I75F/4ZroH6xUSPu7E0pM207cdBvBx5Jw+1GFdtc6alZBPg9XzFizOayXRsvgXg5Zu335m+T3SizfnNYiLO5bNUzlUHI8T2jiZKTryA8M8EbaQEzl/NNiCNw6E4e4pVUq7KBNRLBaleUTEKAZgPSclAWsyi3CQgftRv5BYtq7Uoiyj4D1k83OuESzzbcFoA6zdA0ane2CFiI9VQDx8hkro/pf4yudLfpho9LY8N56DWbRxgT7lJAWYgpA4lM2hegK5a3OqLuxp5jXnBfUtiyoF0lD1A5j70BKwCX0CbFKkFym6pkrcz4ooaydywUou3s9zuCWS4CSuXut10hrJvrvr57gdGrkJCwwELmJdtxsgZVHS5BzdAkp/T8MG4EkVLjKVMBNR7C1sexnXFjih/ybUBkM2h5roJILiGjNu6CrmG5kV52mJEeOCdI1F2O8yTaCGk1VGYl+dgHxTxVd3O8eW7g4rTUcMER4ClUXCIe9eO3U9+gW3c9Y7+o/NHIDdRdf7eGTNo4G9wNeVHj4nGNdRQSPUZ+Jp+TwjtgGiruYbkJ8CFoTymRDxanbLytxcO7rQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA0PR03MB5610.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(8676002)(6512007)(2906002)(86362001)(6666004)(8936002)(6506007)(5660300002)(83380400001)(54906003)(508600001)(82960400001)(6486002)(38100700002)(6916009)(66476007)(36756003)(66946007)(316002)(2616005)(26005)(1076003)(186003)(66556008)(4326008);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VWtDRndDZ3laVHhRQzh6aXhjVmVQZkN3REFoWDROQnFMZG0xUTh4NUZ6UHR5?=
 =?utf-8?B?cmgyVE82MTduZXBVeGxHcUlDTXp4OFdaSzU5WjVQYytyTkNXc1RYekxqSmtm?=
 =?utf-8?B?Z2h2d0NwdmY0c1pWZGRjbWZYZUFNdjg2ZFg3WGVTc1lWUUkrOUhteFptS0cy?=
 =?utf-8?B?ZjZ0R29tV2pzL2xiNDlPc3ZZVzBkVXgrdHJUU1lIVlFDSzNJQXprRTlmV1N2?=
 =?utf-8?B?RDRBbDcxb1JERzNmZExhemJ2d2JWRzQzOFFLLysxeEZLM1BrTjkrU0dka2hP?=
 =?utf-8?B?ZU1QVWRJL3FZazVQL1lyR1QzZU1SRUlhZy90Ty8wTkxPa1lyTHRsKzVUSWlx?=
 =?utf-8?B?ZE80RzR2aTYvdkhHYzFPMFVYYTdSSjBncGJzOWV5RFkxa1lLTWRBSEJ4bWZs?=
 =?utf-8?B?NnNWUDNta0QyUUNaUnFDTXVUVmtta1MzTk1MYUxLNUZ6UjJaRU1QSm52TU1Q?=
 =?utf-8?B?cTNreERxUzhIWG5ybFY0T3lmTlFzL2J0SXpFS2p3UjFqWW5YekNUeDJrNkNr?=
 =?utf-8?B?TTAyZUdDQy9HenBaWUREYWc0S095VVQ3eFBEVXE4dCtnNmkzbkxkbk1BTXI0?=
 =?utf-8?B?TkJHTW1oOC80YkJpQ2N5alFmZVlwZWhyY1hOaUVSL01CaHpRd1dsamtZVUpq?=
 =?utf-8?B?dDBUdkR1N0hRa0FTSGJCdHgxMWJHOWNNOVF2YmFsZStvUFpUTkFrYXJRb0p0?=
 =?utf-8?B?MC80TmZLU1BoVHpON1NRR25OalhEdHI3MEFqNVhiYTR1M1pSRjZJaHIrL1Bj?=
 =?utf-8?B?V0ZFUDBCcStCQ01DOXU3NXJ5MjJTNktFMGcwZHgrejJxQ3FvL3JJNlZXayt5?=
 =?utf-8?B?RmRtUHZGUmhXLzBTd2xwTHlFemIxSEszOVNraWFrVytsTWk2U2NBK3JLczcw?=
 =?utf-8?B?QU5hcEFCdEZjTit6ZUNaRnFDZWNCTE1tUGU2Uk9NZlVZQ3V4NVVEUUdVSnNX?=
 =?utf-8?B?VnFjL0UrWTBGRUpsMWJldUVpSjJhVnh0L1RQNEUyRnFCWFlFaDJTK1RBelNB?=
 =?utf-8?B?dlhpbXlhM2pJQ1VGYTFsK25ndncxS3JXVFg0cXVDbTJQSXc1T3JEdlNBYlJj?=
 =?utf-8?B?ZmxuSW9wQng4OFIvTkt5WmYzaThyTTd1WDN1Myt5YnJuNnlPSk5XanpjTEJE?=
 =?utf-8?B?UzFSY0owYmVqMG91YVFQMFdOVjdmTFJwdElwbzh5RE5HcTh5eTkrVlhFNkdu?=
 =?utf-8?B?QzgzRTNNeFhqQ1Y3NlFjRU5MdlVZK21sK2ZtYUVlM2ZJWXZvODY4SHhQUjEw?=
 =?utf-8?B?RE5vMTM2VWVTMUtRbnlZQzNRQ1JnbDExUVN0M1E2Uzl0UEc3RFhoZEs5UEdx?=
 =?utf-8?B?cXppc3h6Nmt4d2ptYkR6bk5pcU1rYmo0K3psWUZzWmxDZVdIVDZ0S2d5K2FX?=
 =?utf-8?B?eWdvSXQ0MW9SMzFKRndleWhrdmhTcld1djZsakY4bVVJcm5xek4vN295L2xS?=
 =?utf-8?B?SnBmYzhYNm9Od3Z2Z1BnZU9NTlU0Vk5KcTdmdFUxR1U2QThHZTNtM0ppcFMv?=
 =?utf-8?B?b2ZwTGt4M3J4clViKzJnei95YVUyUHliRGFvVlk5YWdualZ2Wk8xT0M5MWJv?=
 =?utf-8?B?cW9sWVlTb0pYYUpDN213K2tYYWpuWnJaYXJBdU9pM2l5eC9DWGNVVHZHdkpN?=
 =?utf-8?B?RitFQlBwRGNaUnJSV241bk5waEluT216bjIrS3FBR2pwWFdab0JjMWREWHpT?=
 =?utf-8?B?R0Nia2pvZ0dzVXlwSEtlYjFUclFwdFB4MWl4K0tBeDBzdFNneElYVUMwbi92?=
 =?utf-8?B?RTl0c2pjYlRjdzdvQnZ2UlBTSTRGTlF0bExxTGs3bWZONCtkalFqKzBZa0w5?=
 =?utf-8?B?dmwvV3VGZi9IOXRpMVZRWEVzSlBUTWlxM2lZQ01PUlR5dmVhUDBmcHdvWXY1?=
 =?utf-8?B?YytBRXdyZzVOWFJSNGg3NzFGZjB3ZERqc0Q0VktFVkc0TFN6ZGw3QVVkTDE1?=
 =?utf-8?B?VStIVjFtQ1BVM2xvanBURzVlVXZLUTcvZjNaeWtoS0JXdkEwYlRGNVJEZHpZ?=
 =?utf-8?B?Y1ZIeHhUT1ZsK1pSU2xzY1BxNkM4YTc1STJ3ZG1DSm9na1pHNkJmVlJ5VnJX?=
 =?utf-8?B?d2hOa25JZ2N3N3ZXZFNIQi82Q3lpY2dEZWRyd2o2SjhHd0p3SmJZTHpNYnF6?=
 =?utf-8?B?d1VScWFBRWFTbUxuOTE4d1pyNm1CVGMvR2NIYUxPNmxTdE85U1A2QkxETUZI?=
 =?utf-8?Q?s8zW6q45Pu+0eyyUx/zuOec=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ac6e6ad0-fd85-4ff4-1786-08d9f12b2b72
X-MS-Exchange-CrossTenant-AuthSource: SA0PR03MB5610.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2022 09:03:16.8326
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sP7axAO1hdQieDfN/70xItTj4uyBpjxHQM0CEVH4nB6n1zFz15fqA8hNFKw3wtKWy5XDm+QrWrhC4t24POLGog==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB3104
X-OriginatorOrg: citrix.com

Current retpoline checks apply to GCC only, so make it obvious by
prefixing the Kconfig option with GCC. Keep the previous option as a
way to signal generic retpoline support regardless of the underlying
compiler.

No functional change intended.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
 xen/arch/x86/Kconfig | 6 +++++-
 xen/arch/x86/arch.mk | 8 ++++----
 2 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig
index b4abfca46f..2cd713724f 100644
--- a/xen/arch/x86/Kconfig
+++ b/xen/arch/x86/Kconfig
@@ -32,9 +32,13 @@ config ARCH_DEFCONFIG
 	string
 	default "arch/x86/configs/x86_64_defconfig"
 
-config INDIRECT_THUNK
+config GCC_INDIRECT_THUNK
 	def_bool $(cc-option,-mindirect-branch-register)
 
+config INDIRECT_THUNK
+	depends on GCC_INDIRECT_THUNK
+	def_bool y
+
 config HAS_AS_CET_SS
 	# binutils >= 2.29 or LLVM >= 6
 	def_bool $(as-instr,wrssq %rax$(comma)0;setssbsy)
diff --git a/xen/arch/x86/arch.mk b/xen/arch/x86/arch.mk
index fa7cf38443..2da4bdb1ed 100644
--- a/xen/arch/x86/arch.mk
+++ b/xen/arch/x86/arch.mk
@@ -42,10 +42,10 @@ CFLAGS += -mno-red-zone -fpic
 # SSE setup for variadic function calls.
 CFLAGS += -mno-sse $(call cc-option,$(CC),-mskip-rax-setup)
 
-# Compile with thunk-extern, indirect-branch-register if avaiable.
-CFLAGS-$(CONFIG_INDIRECT_THUNK) += -mindirect-branch=thunk-extern
-CFLAGS-$(CONFIG_INDIRECT_THUNK) += -mindirect-branch-register
-CFLAGS-$(CONFIG_INDIRECT_THUNK) += -fno-jump-tables
+# Compile with gcc thunk-extern, indirect-branch-register if available.
+CFLAGS-$(CONFIG_GCC_INDIRECT_THUNK) += -mindirect-branch=thunk-extern
+CFLAGS-$(CONFIG_GCC_INDIRECT_THUNK) += -mindirect-branch-register
+CFLAGS-$(CONFIG_GCC_INDIRECT_THUNK) += -fno-jump-tables
 
 # If supported by the compiler, reduce stack alignment to 8 bytes. But allow
 # this to be overridden elsewhere.
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Wed Feb 16 09:03:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 09:03:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273785.469043 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKGDe-0005Q4-6o; Wed, 16 Feb 2022 09:03:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273785.469043; Wed, 16 Feb 2022 09:03:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKGDe-0005Px-3d; Wed, 16 Feb 2022 09:03:26 +0000
Received: by outflank-mailman (input) for mailman id 273785;
 Wed, 16 Feb 2022 09:03:24 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=oYE0=S7=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nKGDc-0005Pr-Ff
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 09:03:24 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 49d2c6ad-8f07-11ec-b215-9bbe72dcb22c;
 Wed, 16 Feb 2022 10:03:22 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 49d2c6ad-8f07-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645002202;
  h=from:to:cc:subject:date:message-id:
   content-transfer-encoding:mime-version;
  bh=82IywCEJaGTDXuJv2gZ75axUySAXEkRmFEmzOfBUsd8=;
  b=W7pChdPUs71u3NehX/qA2Z25//6GKDeaerBUeKFzO6EhMl0NZyOIoBzo
   rP6TxrnXmFhulxV5lue88YQcPmRrorRDYDZTjLIq+9Xbs3ZMbNoz/7Ki0
   0PAgaxAFZedNNLCi2o+BYHnnGFv83n3ah62J6iKAKI9IkFSN0zeidlvhg
   o=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: 1mFEKa9nNCiyfp7G+lmowVrtSPBHYrvOfSgYpNytdbg/UB1EG6Ghr/x88v1p/n0mKdpiRUOjph
 1dWXn3WHYmSCLw3w0MaVw6ptJTJTegiJMJYbLtOQ9puXIyBrnvdpgQy7PkIqTS47KLx/3V3wSb
 TO+EUOnTw1P2c9CM+aaLZmUxn2iT0mairD08nyb5bjQ37pGMJEC1q0dwkSSnN+YofraW1w2f3Q
 NbVSbut09AKh2BWfbwhteWtaY2jN9RRqNHbwUYsh96/RlHnXJAid+Q9yD74IQTlyk90x5/SsVe
 sAwFoAl0T6nrN5ia/1Rqeugk
X-SBRS: 5.1
X-MesageID: 63762583
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:kuOun6jGJyjlHrsWiEMzvDd2X1615BcKZh0ujC45NGQN5FlHY01je
 htvW2+FPKmMMWL8KN9yPtvgp0ID68PXnddjHAs/+CpgESsb9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oAMKRCQ7InQLlbGILes1htZGEk0GE/NtTo5w7Rj2tQx34Dga++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /0TuIadRywIGJTzp7kbChZSHShlD45ZreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHxO4wSoDd4xCzxBvc6W5HTBa7N4Le02R9u3Z8QR6uOP
 KL1bxJmSTnBQTFUBGsTN6IvkeaVtlPcWAxH/Qf9Sa0fvDGIkV0ZPKLWGNjIft2HQ+1Fk0Deo
 XjJl0ziGQ0TPtGbzTuD81qvi/XJkCe9X5gdfJWn8tZ6jVvVwXYcYDUGWF3+rfSnh0qWX9NEN
 1dS6icotbI19kGgUp/6RRLQiHyOswMYWtFQO/Yn8wzLwa3Rizt1HUBdEGQHMoZ/8pZrG3p6j
 Tdlgu8FGxQxvae4R1m80I6rkm60YCcfI2YZVwwbGF5tD8bYnKk/iRfGT9BGGaGzj8HoFTyY/
 w1mvBTSlJ1I05dVivzTEUTvxmv1+8OXFlJdChD/Azr9hj6VcrJJcGBBBbLzyf9bZLiUQVCa1
 JTvs5jPtbteZX1hecHkfQnsIF1Lz6vdWNE/qQQ2d3XEy9hL0yT+FWy3yGsjTHqFyu5eJVfUj
 Lb74Gu9HqN7MnqwdrNQaImsEcksxqWIPY27CqyFM4MUM8kgLVXvEMRSiai4hT2FfK8Ey/9XB
 HtmWZz0USZy5VpPkFJauNvxIZd0n3tjlAs/tLjwzgi90Kr2WZJmYextDbd6VchgtPnsiFyMq
 753bpLWoz0CALyWSnSGquY7cAFVRUXX8Lir8qS7gMbYeVE4cIzgYteMqY4cl3tNxfQFzLyZo
 SvkBye1CjPX3BX6FOlDUVg6AJvHVpdjt3MreysqOFejwX84ZoizqqwYcvMKkXMPrYSPFNZ4E
 KsIfduuGPNKRmiV8jgRd8Cl/odjaA6qlUSFOC/8OGozeJtpRgro/N74f1SwqHlSX3Tv7cZu8
 ae90g77QIYYQ1gwBsjhd//ynUi6umIQmbwuUhKQcMVTYkjl7KNjNzf10q0sO8gJJBianmma2
 g+aDA02v+7Ip4NpotDFibrd99WiEvdkH1ocFG7etO7kOS7f92ul4IlBTOfXImyNCDKqoP2vP
 LwHwev9PfsLmEdxn7B9S7s7n7gj49bPpqNBylg2Fnv8cFn2WKhrJWOL3JcTu/QVlKNZowa/R
 mmG5sJeZeeSIMrgHVMceFglY+CE2a1GkzXe961ockDz5Ssx97ubS0RCeRKLjXUFfrdyNYokx
 8YnudIXtFPj2kZ7bI7eg3AG7XmII1wBT74j58MTD4LcgwY2zk1PPM7HASjs7ZDTM9hBPyHG+
 NNPaHYuU1iE+nf/Tg==
IronPort-HdrOrdr: A9a23:QkX71K3ZCMglRTSWp1MU5wqjBV5yeYIsimQD101hICG9Lfb2qy
 n+ppgmPEHP5Qr5OEtApTiBUJPwJU80kqQFm7X5XI3SJzUO3VHHEGgM1/qF/9SNIVydygc/79
 YeT0EdMqyIMbESt6+Ti2PZYrUdKbG8gdyVbIzlvhBQpG9RGsRdB1ATMHfnLqQ6fngOObMJUL
 6nouZXrTupfnoaKuy9G3k+RuDG4/nGjojvbxIqDwMurFDmt0Li1JfKVzyjmjsOWTJGxrkvtU
 DDjgzC/62m99W20AXV2WP/54lf3PHh1txALsqRjdV9EESlti+YIKBaH5GStjE8p++irH4sjd
 n3uh8le/9+7nvAF1vF1SfF6k3F6nID+nXiwViXjT/IusriXg83DMJHmMZwbgbZw1BIhqAx7I
 t7m0ai87ZHBxLJmyrwo/LSUQtxq0ayqX0+1cYOkn1kV5cEYrM5l/1TwKpsKuZPIMvG0vFnLA
 E3Z/uspMq+MGnqJUwxh1Mfj+BFBR8Ib1S7qktrgL3h79EZpgE686Ii/r1vop43zuNOd3B13Z
 W7Dk1WrsA/ciZvV9MEOA4ge7rBNoWfe2O7DIqtSW6XZ53vfUi97qLK3A==
X-IronPort-AV: E=Sophos;i="5.88,373,1635220800"; 
   d="scan'208";a="63762583"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Otbo96aYKVZ6p59KEF7xSUIz8OTrjvoSKd/6JcunhlPTwHA40rRUq0EJe0i9X5Cfo5VwqBXk7yMgAjPLslCwKZP3CK3tGT9LsLfyJhEZfHoFnrD9rNQ7Sb6RUoXcEiFIy4G7rQXuQuxcEgCSHp4VHE86kOkEWYWlCvEQ/r+On56gejp/wGImn2q60MhwcQI+mkHpuyTwuH2dH0jLwSSErkCbfR6NySvr66Gnv2mPBg9hSig6J5/iXW6LTFQBoG6CSzIlzjSCLMT7fCaqUvNRlXORNQefRJF76LESdcVhqejOFgBuvjJO7WySgTwoBfxFmfzEzvVPTwVIKKTYsp5FmA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=2JUejUh5yzqKtWUj7o1W9V/dctJs6neBQWjRyLXc7bc=;
 b=KIBKO/keR0aAat2zGxHfEo2OvEIdLZY4zpDHpc7m9DGpni+B9Qu7UGaxoHfBN0Y3hhlFAf+Nm22yodQBIzCd0UuhJeN9W8naz87O5+KsxQ9kdskK7+bAPkuL8faHvBgETvwd7Wk6hBpNQaqt5KOSI7UhOWLcPBlxhuTdK9TEMLYci7FHh51cKjn7Bo3KcW+8n3pDcuGurBVMIGm9tneyRZpF9KIl1JKmXiN3JgQC7tDtXKY8xrspw8vt+qKuHnz4MGaguJzyuyOj75oTkHwV8/GbTR0bs1aZG0k04OIzCnVbUCk9Q9q++HPvPudhKJWH4G2JvojCzyv668ZgFKJU+w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=2JUejUh5yzqKtWUj7o1W9V/dctJs6neBQWjRyLXc7bc=;
 b=bIUVCrGGuR9y0aASYYngBKRu5QXGBFBMW6TNjJ5WPQkSrudTi72msTjkW1LPLVQyfXvc+Eb9VyiiECqyB3ekG/wFvlsfNCyFq4PRGdWI8iFqh+d+0wXCjM3h0c/u68JlreoZkVUmxuIjYf8FLbnW3F4LbJDeEMTlpMjT/P1jHEc=
From: Roger Pau Monne <roger.pau@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Roger Pau Monne <roger.pau@citrix.com>, Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>, George
 Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>, Stefano
 Stabellini <sstabellini@kernel.org>
Subject: [PATCH 0/3] retpoline: add clang support + Kconfig selectable
Date: Wed, 16 Feb 2022 10:02:57 +0100
Message-ID: <20220216090300.9424-1-roger.pau@citrix.com>
X-Mailer: git-send-email 2.34.1
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO4P123CA0242.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1a7::13) To SA0PR03MB5610.namprd03.prod.outlook.com
 (2603:10b6:806:b2::9)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ca098a8e-2156-4c28-c9b2-08d9f12b2863
X-MS-TrafficTypeDiagnostic: MWHPR03MB3104:EE_
X-Microsoft-Antispam-PRVS: <MWHPR03MB310415003D38B1EB6DC490DD8F359@MWHPR03MB3104.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: ZJ+UZ0GZN7gRZH9B6xopiL+cj7/Wp0cIW+RD252AtsoCDkLCBNNXWApgPqKL2NSLoGLmeGLFwPI2z6OzT4HZP0bx50cjlEU0ceVkMOR3Ncbrss9ZubAuYodZmK9Teve9bOC2A/w9O6BlSy3QjIKk6O+aj5dXWY48L1NNgSkTesYC0VutPB+2VZMZlNh5TOVBcJluOHdohMlsQaKg3h2AYqcCSDuhsG78+D3BY/By68Lg02vadUrIj8Uj2lwB074hXSSTM75DpVa5EnOIvbUR1kWBQBdbsjIr9LZvTIBpDQ2/r9bmXCnCfeEuOgQwSzUzvLx1jo2/tnOCIKHFncCsChrRFXhORk+u60U7lhuJBjSh3RzksyRKuCE2CrUcDjWnWxmRWnZXcUWxazV/+NooI+tBkfHvHyWmR0ctNnlLr9Lu7T7+Z7zhURbboeYlW2ThfhOh1/mkDwDiGxC98Vx3whRpSQPrlKlCQBY/wtXrsP2PImI8lhVYIgzIUJO+M+xZ8O0IjmZVoetEYOO2U+p7efDOx/GgQHz23ahaB+jmsxDi9szFm8pmP8B6G9Dk+9W0GGxeOwk9zfLgRBaOOn4lwGaVukY1xQhZpUDq4MvYIffCgKwtwNH61dVmvDHqOrwmco7tTGXgFv4a5RUX47XTvg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA0PR03MB5610.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(4744005)(8676002)(6512007)(2906002)(86362001)(6666004)(8936002)(6506007)(5660300002)(83380400001)(54906003)(508600001)(82960400001)(6486002)(38100700002)(6916009)(66476007)(36756003)(66946007)(316002)(2616005)(26005)(1076003)(186003)(66556008)(4326008);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q2s3dHNrc1BwZkZLVmh0OHU2V2FDY05nOGNsdkZsNGJaNHhQMXh1UjY1TDBS?=
 =?utf-8?B?QmdFVmxXYTBGSG0rNUtzdFhqTGVKajBUT2t1VllRb3ZBMi8zeFdnNmZWUXJQ?=
 =?utf-8?B?dVM1Vnd6M3BWMW9ZeVFHQk4rSWNPczZ6OVpESFVqQ253blNWMU1WaDhjcSt5?=
 =?utf-8?B?bzhKaDZlbE1sM2hwdnB5QkZqbDJaUHd3ekpnMWV1ZUVwbmh4czdxeEl6aVB4?=
 =?utf-8?B?MjRBMVpxQTgxOW42YXZHQUtmSHVtMExZRVJydWg2d1hYaUhhY0wyc1JuaHJV?=
 =?utf-8?B?b0VoYTQ5S2x3NDc0U012T1dRV3ZIc242RytHMzFQVk13OFJPNE80YkFOL2Jt?=
 =?utf-8?B?OFN3YTc4RVJOVjdEMndZczJxSHFqeTNkUDk4UXEzVGM3bGVFKzFSN24xUXJW?=
 =?utf-8?B?bEVEUFkzTnpFeCtjVnliSTZwM1JiRlROUkNOZ0tnVGFxemhpR3hLTU1WaFlU?=
 =?utf-8?B?ZUs1YXNqL2EzMkJxZDNEcXhXZ1lWOTNFdllkVit1U0E2RjBTU2FWWG1ZTDNv?=
 =?utf-8?B?a20zRjZKTU93SWdRUHg4Z0RJTEtrOEh6dWIraFByVG5sR0JRNk9PcS9uZlRK?=
 =?utf-8?B?NEVHN3Y2TVRxbkFlSm41WDZIam9OVENacm5pUTBVK0Q2TjFjVVM0dDJvK1Nt?=
 =?utf-8?B?dlI5TFZSTzhkOWowRFhYMXk4OFZDQi8wMW1HZ0hmV1JrUHNubUlWdmpsMkc4?=
 =?utf-8?B?djdwYzlnR0o2eHJwenZHemJMTTZRME5Kd3VvYUIySDdCbWpNZlk0MmkwdlZy?=
 =?utf-8?B?Nkk2MHN0VFJscVE1YWlpZmxDWTdOVDNjYldvUVVvYXRSNDNZYWU2RDlyODJl?=
 =?utf-8?B?eUx3SDlZTXJFV0lUR1kzSGFUR2hCMXhMenlGTDhKM3MrbWR0MGxRb3FrY25F?=
 =?utf-8?B?YjZlekwyQWVyRGQydmI0RitqMFB3UFZsRGFBTmdqczAzVURhMytTSFNaRVRy?=
 =?utf-8?B?bUoyYlVxVG9HdjRjNU5SQ3NYZ3JkUURPWDZDeEt1L1RmNFpWWGZUVndjcjNY?=
 =?utf-8?B?MS9QZ01KWGplQ3BSQndBSTFJSzlxL3VaNzUwcURXSWk2cU45WTZSUDh2cXll?=
 =?utf-8?B?U3VtMldvNnZQWnhMMTRpYjBzdGN6TzhwbHNVZ0dSR0RoUWRQaTJEaENOak1X?=
 =?utf-8?B?dVlpMTlONEhSMG1rZEFPOTZtOUFoNDFvTk9lWmVVYlphTUNrTnNqYnFhVFlo?=
 =?utf-8?B?UUxlUDBiUUY5eHFHZk1hYWM5NlowbWlmTnM1Q3RERDF6OW1lREN0bGZ4UG96?=
 =?utf-8?B?ZllUUHh5RmFzS2w0MGRQcTRiQnJmUjR5WVJHdW1TWVljVGd4dDJwUEdSVzJ3?=
 =?utf-8?B?c1NuTUNsUkRYbFd6UmdLN244L2tSZ0lBMUdwcjdxbjI2ZlQ3amZoLzFrbTcw?=
 =?utf-8?B?ZmhtNWpOSGQrWVozUGhzbzdUTHhaSE81cmE0c0lZWTVBaElPNTJId1RxU0sz?=
 =?utf-8?B?SVA2dW84eWtRcFQ0QW53RXdXZlhEeCs2NGFicHREdTAwdUhLZzZ1QXYrOWRv?=
 =?utf-8?B?L0ZLdzc1d05OUkxrYXo5SFprOWxuNGFSZGliVFRxUU8vN3E2dkk0VmYybGNt?=
 =?utf-8?B?cTJZK3kweUE0MVB6SVZuSVNNdUlNRUh3UXhXMTZ1cnZLdzZJdDF3R1ZkM1lt?=
 =?utf-8?B?MFZsTVhzTk5iVE94Zlh1b1dTcjk1SUNsY3RZRllDb3JncXA4TXlWYWtVQ1E2?=
 =?utf-8?B?N0x2Sm1zbDFwZWZwYTl4NUJscjJLc1J1YVRwSlp4Qnl6ZUx3SmRtbDJPUzZw?=
 =?utf-8?B?R0JZT09zY2FIRGhoYlZGWkhTQ24rNUhzOE0rYXNJUnl5UGlTV0w4RXVNOFJy?=
 =?utf-8?B?aStmMkM0eXBDYUFEUS9oOTBaUjhqQ0VKRDFlUGxpekxEZjNnR1JWMW5HeU02?=
 =?utf-8?B?QkhXRXJXVUgydVNJdzNnRU9vb0xKZGJlaUozdGRrNDc2SWxvRnpDcXc5ZjN0?=
 =?utf-8?B?U29SNG1teERCaWh0anJrbGl6a1Y5d05rOUFTQXQyR09mYmxRSE9KaWlqZGVZ?=
 =?utf-8?B?UTBuQ0NjV1dkV1YxQzEzU3VvZ0sxVmx3WDVQSGFMMC96aGFJNGl3NytoZG9m?=
 =?utf-8?B?d2R6NlZaZjlWV1BQcERyTUw3OURIMEN2ODlxbVgrMm40VFlycVh1ajN6N21y?=
 =?utf-8?B?UlZFZFNRNkREWFdPelNpMTdFM3FmNERrSlJUL0F0MXo2bGZ0TVJydmdTajJz?=
 =?utf-8?Q?fW5tJI2vcyIxfkElqRHH7Ag=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ca098a8e-2156-4c28-c9b2-08d9f12b2863
X-MS-Exchange-CrossTenant-AuthSource: SA0PR03MB5610.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2022 09:03:11.5663
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0IuCKl/jJsbQZsnFwsz6blRINapCtteFJrzeoGlbANLlcBXUrdsrvsIM5WhjbjJdcy/TGKwnY55oFPcFdy36mA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB3104
X-OriginatorOrg: citrix.com

Hello,

The following series adds retpoline support for clang builds, and also
allows the user to select whether to enable retpoline support at build
time via a new Kconfig option.

I've tried adding a suitable description to the Kconfig option, but I'm
sure there's room for improvement.

Thanks, Roger.

Roger Pau Monne (3):
  x86/retpoline: rename retpoline Kconfig check to include GCC prefix
  x86/clang: add retpoline support
  x86/Kconfig: introduce option to select retpoline usage

 xen/arch/x86/Kconfig |  5 ++++-
 xen/arch/x86/arch.mk | 13 +++++++++----
 xen/common/Kconfig   | 16 ++++++++++++++++
 3 files changed, 29 insertions(+), 5 deletions(-)

-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Wed Feb 16 09:03:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 09:03:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273787.469065 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKGDj-0005yF-SH; Wed, 16 Feb 2022 09:03:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273787.469065; Wed, 16 Feb 2022 09:03:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKGDj-0005y1-Oe; Wed, 16 Feb 2022 09:03:31 +0000
Received: by outflank-mailman (input) for mailman id 273787;
 Wed, 16 Feb 2022 09:03:30 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=oYE0=S7=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nKGDi-0005Pr-5x
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 09:03:30 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4db97b55-8f07-11ec-b215-9bbe72dcb22c;
 Wed, 16 Feb 2022 10:03:28 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4db97b55-8f07-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645002208;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:content-transfer-encoding:mime-version;
  bh=xn4du4McSTZakSHSLhIMNTrpFDgFlHgmcfXxyKC8dAw=;
  b=h+swo9aB5/VPSxcmyacmGvE/VqZHejF4+5RkHrpv3GdasmG3/ARf1Ufk
   akVJ8pq50UYXLa4j+WWu1H6+P4kIfoHEH0GGmMUS4g8a4uamErJyFEqco
   aAbq6P64C8+gfjrxMHCqPY1Zr4Efjhht9eHNLKurPtaqBIAII2x6zwZG3
   M=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: eXBBRENLS5qMAQ/WkGgr51csUPz+1mesK+tKLmgbgzVoNVN1w0Q1+FTSpe+YOtsFoNO5KHnb7G
 E+RZGP5X4CnX6amIhD9/TRJ1oAUPPwrki0/uTQlmpCyOoYcTYZKN6Ipp05W3L6VALL1B7DpKII
 15nyvmtP+bpXhdS2OZIjH4sfbL46Ox3Rm82FmYWE+rLYDunQwo54hzuRR7ysRJT+ZBkSxk1WDM
 9X7VoYFHHn3iR63yZ7KFCGSFEH9vEHfMMcTGbhgAK/sMJkzMn2KYepc+FK3ZwGtu/yOoZMb58a
 DT9c1rjFkZBYV5t72y49VthF
X-SBRS: 5.1
X-MesageID: 64219151
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:ogkKKq0KJL2SZDMhf/bD5Q92kn2cJEfYwER7XKvMYLTBsI5bpzxWn
 zYfX2uEPv2PNzHxfY8lYI/noEME7JGGzoAySQM6pC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkS5PE3oHJ9RGQ74nRLlbHILOCanAZqTNMEn9700o5wrBh2+aEvPDia++zk
 YKqyyHgEAfNNw5cagr4PIra9XuDFNyr0N8plgRWicJj5TcypFFMZH4rHomjLmOQf2VhNrXSq
 9Avbl2O1jixEx8FUrtJm1tgG6EAaua60QOm0hK6V0U+6/TrS+NbPqsTbZIhhUlrZzqhgvRv1
 okc7L6MChobHPPMkek2DzBFKnQrVUFG0OevzXmXtMWSywvNcmf2wuUoB0YzVWEa0r8pWycUr
 6VecW1TKEDY7w616OvTpu1EnMMsIdOtJIoCknph0SvYHbAtRpWrr6Diu4MChWZp25km8fD2d
 8ATUxtjPAj8ZD5NIQ1LOJEOt/aViSyqG9FfgA3M/vdmi4TJ9yRu1JD9PdyTfcaFLe1XlEuFo
 mPN/0ziHwoXcteYzFKt4n+qw+PCgy7/cIYTD6GjsO5nhkWJwW4eAwFQUkG0ycRVkWbnBYgZc
 RZNvHNz8+5iryRHU+URQTWlhGCa4k9FeeYTDt8YtgGEx4GIyhugUz1soiF6VPQqs8o/RDoP3
 1CPns/0CTEHjIB5WU5x5Z/P82rsZHF9wXsqIHZdEFBbu4WLTJQb00qXJuuPBpJZmTEc9dvY5
 zmR5BYziLwI5SLg//XqpAuX695AS3Wgc+LU2uk1dj/9hu+aTNT8D2BN1bQ9xawdRGp+ZgPc1
 EXoY+DEsIgz4WilzURhutklErCz/OqiOzbBm1NpFJRJ323zpyLyINkKsWAvfR0B3iM4ldnBO
 hK7VeR5vsE7AZdXRfUvP9LZ5zoCkcAM6ugJptiLN4ETM/CdhSeM/T10ZF744oweuBNErE3LA
 r/CKZzEJS9DUcxPlWPqL89Age5D7n1vngv7GMGkpylLJJLDPRZ5v59eawDQBg34hYvZyDjoH
 yF3bZvakU4OD7enP0E6M+c7dDg3EJTyPrivw+R/fe+fOAt2XmYnDv7a27Q6fIJ52a9Sk4/1E
 ruVACe0EXLz2i/KLxukcHdmZO+9VJpztytjbyctIUypyz4oZoP2tPUTcJ4+fL8G8u1/zKErE
 6lZKpvYWvkfGC7a/zk9bIXmqNAwfhqcmg/TbTGuZyIyfsA8SlWRqMPkZAbm6AIHEjGz6Zklu
 7Sl2w6CGcgDSg1uAdz4cvWqy1/t73ERlPgrBxnDI8VJeVWq+49vcnSjgvgyKsAKCBPC2jrFi
 FrGXUZG/bHA+tZn/sPIiKaIq5aSP9F/RkcKTXPG6buWNDXB+jbxy4F3T+vVLyvWU3n5+fv+a
 LwNne38KvAOgH1Dr5F4T+Rw1as76tbi++1awwBjECmZZlinEOo9cHyP3M0JvaxR3L5J/wCxX
 xvXqNVdPLyIPuLjEUIQe1V5PrjSi6lMl2mA9+kxLWX7+DRzreiOXkhlNhWRjDBQceluO4Q/z
 OZ94MMb5mRTUPbx3gpqWsyMy1mxEw==
IronPort-HdrOrdr: A9a23:QazVxakHD/MAfaoGRsauTjQS8cLpDfIT3DAbv31ZSRFFG/FwWf
 re5cjztCWE8Ar5PUtLpTnuAtjkfZqxz+8W3WBVB8bAYOCEggqVxeNZnO/fKlTbckWUygce78
 ddmsNFebrN5DZB/KDHCcqDf+rIAuPrzEllv4jjJr5WIz1XVw==
X-IronPort-AV: E=Sophos;i="5.88,373,1635220800"; 
   d="scan'208";a="64219151"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=X1CTA2wFk6gkfO5fh4f664suwHeKKFu9zqoktu063yPfuH+vv1qT8mAfnvsCEWHn/OCq9ahcYDqW3yNXtPN3Wsai1zNoqtpIbZ5EE8JB6CM+ggSGkNY1NmUC4GJSTuIHkthRB8iBEWlF2yQCN61A5ToNLuhPQv9WtWJZKsMmvBOYlp74xJsL1a1/tBjdB31ZaDGanzoEo3h8TBRRiJ/bGFcyBRCPgTfsp4rxfYlnU3QvZ/amaZerBbHAd2sEO86fJIy/lhz0TWEKgudjYdfWVjaap+hqLuM8vyY8HTwH5uxKVN8BKv5Qzw7PAUp1iSR5JbSTj4xAZxmC4u6GULJz7A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ECbNckFONGl7yneZ3OdlmPn6TeB2jy3nQWF/X3oEJ1k=;
 b=aZgUNs1+X44o3ew/aHJNg2BMaAUsTMYXLyKDNMJvvSZGq0YqMFkIYE2pDSbh5TJJ6HQELrl2kchinkQeXZUHVs66zpOhbAbQx49JdhC34HXPapc7FvLxoYki+3OJQhCijUYCHIaE9xoDSTJHGmdjDAgG2X61ZzD+vI3zDYOgkSshHnk9P1P7N66znUJiWT8VAfYSqV9Ur0hZfpxwRLNJukxKte7sf8FDDOaeT/+iE7+11oznsW1/sRlTQS9eVfcM/g+jybgCv2ZUM7hqzEhRAkEgqM6fbH4UxP+5ta5pL346Qb4CXygw8p3SWYmH0EQjWbloUFJdTXa+b6d9nV0Fbw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ECbNckFONGl7yneZ3OdlmPn6TeB2jy3nQWF/X3oEJ1k=;
 b=WmiFWRX7daAck/K0b5o63oJf/dXMdwI6R6e0/be7LrpySA2DhKQSkK7qGabNwqPlrPZ3Z7o4IguG/rw9Sg2cZ5urvRmbYekI1KCJrmDs0aXq+79LIENBJNOiAq3j2tYCd6rQw00t3jhipZyUoq9ycNkutYMfAspebxgspOjXxCA=
From: Roger Pau Monne <roger.pau@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Roger Pau Monne <roger.pau@citrix.com>, Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>, Jan Beulich
	<JBeulich@suse.com>
Subject: [PATCH 2/3] x86/clang: add retpoline support
Date: Wed, 16 Feb 2022 10:02:59 +0100
Message-ID: <20220216090300.9424-3-roger.pau@citrix.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220216090300.9424-1-roger.pau@citrix.com>
References: <20220216090300.9424-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO4P123CA0305.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:196::22) To SA0PR03MB5610.namprd03.prod.outlook.com
 (2603:10b6:806:b2::9)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5e2bf5a9-f891-43bf-7011-08d9f12b2f3d
X-MS-TrafficTypeDiagnostic: MWHPR03MB3104:EE_
X-Microsoft-Antispam-PRVS: <MWHPR03MB31042BFF51AFBF34795E8EC78F359@MWHPR03MB3104.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4941;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 5nggWCyoPkeZwPkZaAvSj5CydmYzATizwU1CBat7bKOaSydQEN+/nuetyYgBsvBXVFEbnkpZggcVZkRlRidaaqFIKcbQmmqNZd53i0oYvueT3N7pY0i1dLjEcxSGzSevw44IztOZdg301qElO4Fbd5+L3jE43THrUPupL1N1xSnIqipVGLONRvid+/Zdo+Aroq7mAUZJ/3N/7qHpuHw+Xzo7Hz0DvxZVhxtF0wRlI1v/RZYFOwXUxQjKbvU8Zm6TWVJt3t+tfm6HtXZKdbZ/jrY/v1VE889RySfRrlBk8HFCoTsjU7qxm4UBIVWC8U7ppE6815SotAg7L/qWMH8gEGB47LZDjlWJ4P4gerJp8USihDlhvqptFbAEv0sXdSH3dVi07mstm/npI3ZraDggsVQeuel/ItHjPFjFurFjhZ2S+ZgGf5npz/wLBq3fCeEYmMO6deiy80m5yKTojeQacDEt+F3p1lGcJA1BTG9ywt8NBtdMSTLWrgCZIxhh8CynEehNISpDV95yT8CdMTK5jyoV3qb0dpwig8fl3nQo6CbOaBZEE2wlE6rZVXpab0yd+QqAsbuxEaX1kE8mx1aey+dTczNMFq2/fcKC1m4P+a9lTYP3+BHTETe5Ibm4QUHIk7vGM1LNgsUKA2leUS8RWw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA0PR03MB5610.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(8676002)(6512007)(2906002)(86362001)(6666004)(8936002)(6506007)(5660300002)(83380400001)(54906003)(508600001)(82960400001)(6486002)(38100700002)(6916009)(66476007)(36756003)(66946007)(316002)(2616005)(26005)(1076003)(186003)(66556008)(4326008);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WG40bE1hNlZQTFJGQ0RMMll4ZUdzMlQxbG9UUGltWXVaSEduZExYV1c3K0p5?=
 =?utf-8?B?TmhNdzdQMHlKQUlkcW0xTGVQTXkyNEVqLzNqOHllVEJUM0pqWEFaTWtZdWor?=
 =?utf-8?B?MUNuaCtFU1lsendXVTVTTlJnV3Fld3pwYXozWDN0SnNmcW5EMnBOcjd4VHFh?=
 =?utf-8?B?VXJaMDU4ck1lSk9lbkQxdlJiMCtSYmxzNVJIcTFLTUVTRm5pWEtiSU8ySys3?=
 =?utf-8?B?c2lZcTQzR01vK1ArTXJmNjVhTFNSTnp5T0NlU3JCRU1OZXcxNytnamE4UktV?=
 =?utf-8?B?ZkFKNlFGRW1GQXJPaHJoNnV3Z0FEa0lLZVkxVEZ1MnZVSm1SRksrUWx4NE1S?=
 =?utf-8?B?S2JuV0FuMlBBLzlYcFQrVlhRNDdHcXlvWkk1UXB1UVFtL0JkRGNOOHNUWklT?=
 =?utf-8?B?MGtRSndZOWw5UlRkMDYwSjE1RmloVFppeHFaT2FVT0JVQWQwRDRvMTBMT3dp?=
 =?utf-8?B?dnJ3SVBJSnZRTHl4amFvNzF2TzFWVDlHR2MwRWpCNHM3aCtUS1Y5MmVDd0dM?=
 =?utf-8?B?Tm1CZG9zdlc1VEg1NHY4S05OcFFrQ0hoMENWNTFrV0IwSG5aME01QmhoN3VK?=
 =?utf-8?B?UnVWZWRTU2ZNLzQ1ZmFjeWtOOXl1eXhzODJGcjN5NVdFNEwvMlZLNUNyZjZn?=
 =?utf-8?B?K3dNeTBKRjZXQzMyMFBpczQ0cUxjQmJFY21aK1VHMVNLL1FNWE0wa0ROU1VF?=
 =?utf-8?B?T3BqaTd3d1hGQWoyVEd2L21oQlYyd1JVMGJidDhzVzRMamo1ZDhtU2tWQVFy?=
 =?utf-8?B?VXJQU3NYZ0NBU2gzcXkvM0pGcHBEMDZxRzM3NFRsWDhPZXV5TnI1UEdtblQ0?=
 =?utf-8?B?YXAydG1YR3RlKzZnRm0rY0RvTUxSLzNvb2xrRFZva2xMUVhnNm1FNW9nTjZP?=
 =?utf-8?B?elBBY1p5d01VQkRqbDBhVWRqaiszRG8vU3NLekE1ODZHdE05MEJTSEtJM2dx?=
 =?utf-8?B?cmcydzhTY2ErdnVCUitnbGFsTzBmVmxjV0VvcHlRWDhPUG5NeEJrSGYrZG0w?=
 =?utf-8?B?S0hnWlRJRFpyWDZ5NVQweVRrQW1LQzBodTFoNTBSMXlaVlppZ2luck9wUGI2?=
 =?utf-8?B?ZTJHOWsrbmtuOGZmUUNyS21vUTNXWGRTNHNneW94YlhFN0xOenRDTWE5TTRs?=
 =?utf-8?B?VVpSeEhsTVNGUlRWbmZ0eXl4OG5KdGNROFdHSWp0aWJ0Z3l4Rk5uNWlyODM3?=
 =?utf-8?B?UUNpeThPMTI3M3k4REhRSDZRVHlpbVNFYjNJYlE4YSsvYUNzd3IrWU9ZbnpB?=
 =?utf-8?B?a0xVdlhYZUtmN3luOGhuMGt1UFNaTVJPY242dWNmQnh2NW5ZUnFqSGhQd3Jv?=
 =?utf-8?B?OVlhNWxpdGhmTHYxUTFtb09NTVdYK01ieHE3YlVLZXdweFFNbHQ4QnRjdDVN?=
 =?utf-8?B?RzJpa25CVXRKUkFWZEpRcytGV2Y5cXoxUnZwYUdtMTdsbm5hMVdwbkFyaWEv?=
 =?utf-8?B?OGJBcHlMa3VoRVBQcWRsM3RITzNQamNpcUI2NTh2YkVycUtZTzhWcExURUpz?=
 =?utf-8?B?SGE3YU1wYXZJNnlLZDJldmZ2UUpJaGpyUDBLNitYdm9BbFdCSy94ZnNJdW1o?=
 =?utf-8?B?OVh0dytBNUdRS1RIdnArdWNXTmE5UGZlSUNjbzd3WlJXMzBuWURNRFBoblJO?=
 =?utf-8?B?RVdyT0V0eUc2Ym4rV3RYMmtGTnIrcGNZczhYUThGdnhSTjN1SStrYWJJQlVR?=
 =?utf-8?B?UnFmNitXaVNWWVdLTU1iWEVSekQyQTg3WTcrWGFYYnd1NCt1eGd4Zkx0N1ox?=
 =?utf-8?B?N1RMRGJ1Q3ZuY3MxcVNaS1FBaXh3Ym5lekU0cmQxRlZZNTFsSzFnT0tvS2R3?=
 =?utf-8?B?S2pMUXduM0ZxcGtRT29wdzdlZVNsTHVuVWpldm5kOURRMGFUci9nU3BycERa?=
 =?utf-8?B?eDRsYjRTV3ZqQ1lZK0RWL01YR0pzeTZ4WWdNcXdObHM4MUVOMjZsMGVTQXF2?=
 =?utf-8?B?TjkyMEF4RW9HVnMyVndlcWpzUjIwbGgxNkVpTXNxUUlNanJJZllpQmhoV01M?=
 =?utf-8?B?dU1WbksyMWpyTFlLdG1jbWg2TWlBSFZ3SzV4UTE4U25HdDNmMDdVMC80Qkhr?=
 =?utf-8?B?anMxUFNaNHdsK1VGWWNZNGpNVDJPdnlVeTJVSkd4b0lzenZBSzNBc2RuSXdJ?=
 =?utf-8?B?emJDMWVIdGcwOUdMVFRQN3NqeWNtSjVkbTh4QTAxSkRtUnlSS0ZaYnBTVXR3?=
 =?utf-8?Q?4HqOl353aUvHzRUH3tWYrVs=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5e2bf5a9-f891-43bf-7011-08d9f12b2f3d
X-MS-Exchange-CrossTenant-AuthSource: SA0PR03MB5610.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2022 09:03:23.0110
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QW2UykXpKeIfW+3AqVdkfNjbYWd0pYy9hGN8zDvOAyJQfbY+gkxHYzjmom/MQ1e0Lj4s+kyInm4XOVBHMPhW1Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB3104
X-OriginatorOrg: citrix.com

Detect whether the compiler supports clang retpoline option and enable
by default if available, just like it's done for gcc.

Note clang already disables jump tables when retpoline is enabled, so
there's no need to also pass the fno-jump-tables parameter.

Reported-by: Jan Beulich <JBeulich@suse.com>
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
 xen/arch/x86/Kconfig | 5 ++++-
 xen/arch/x86/arch.mk | 3 +++
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig
index 2cd713724f..fe00b4598b 100644
--- a/xen/arch/x86/Kconfig
+++ b/xen/arch/x86/Kconfig
@@ -35,8 +35,11 @@ config ARCH_DEFCONFIG
 config GCC_INDIRECT_THUNK
 	def_bool $(cc-option,-mindirect-branch-register)
 
+config CLANG_INDIRECT_THUNK
+	def_bool $(cc-option,-mretpoline-external-thunk)
+
 config INDIRECT_THUNK
-	depends on GCC_INDIRECT_THUNK
+	depends on GCC_INDIRECT_THUNK || CLANG_INDIRECT_THUNK
 	def_bool y
 
 config HAS_AS_CET_SS
diff --git a/xen/arch/x86/arch.mk b/xen/arch/x86/arch.mk
index 2da4bdb1ed..f2aa2a515f 100644
--- a/xen/arch/x86/arch.mk
+++ b/xen/arch/x86/arch.mk
@@ -47,6 +47,9 @@ CFLAGS-$(CONFIG_GCC_INDIRECT_THUNK) += -mindirect-branch=thunk-extern
 CFLAGS-$(CONFIG_GCC_INDIRECT_THUNK) += -mindirect-branch-register
 CFLAGS-$(CONFIG_GCC_INDIRECT_THUNK) += -fno-jump-tables
 
+# Enable clang retpoline support if available.
+CFLAGS-$(CONFIG_CLANG_INDIRECT_THUNK) += -mretpoline-external-thunk
+
 # If supported by the compiler, reduce stack alignment to 8 bytes. But allow
 # this to be overridden elsewhere.
 $(call cc-option-add,CFLAGS_stack_boundary,CC,-mpreferred-stack-boundary=3)
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Wed Feb 16 09:03:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 09:03:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273788.469076 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKGDm-0006Gr-4m; Wed, 16 Feb 2022 09:03:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273788.469076; Wed, 16 Feb 2022 09:03:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKGDm-0006Gg-0L; Wed, 16 Feb 2022 09:03:34 +0000
Received: by outflank-mailman (input) for mailman id 273788;
 Wed, 16 Feb 2022 09:03:32 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=oYE0=S7=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nKGDk-0005Pr-Hb
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 09:03:32 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4fdf0724-8f07-11ec-b215-9bbe72dcb22c;
 Wed, 16 Feb 2022 10:03:31 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4fdf0724-8f07-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645002211;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:content-transfer-encoding:mime-version;
  bh=ysl9wQiGoIFjtZscKuJah+YD5LjaRX0Moam5blmUa6I=;
  b=KhDWnuf42kjh1JVGnYsADY3UASBEp1bG3WKlIOdQ/tqC++HEK0yLVZ59
   uqM9YzYRGvnO/cTklahJ3aocXdnlrJ+lDijLysk697v/P7hZHY3M54l6t
   0FfvIMoFjj4xu6hz3+ULEfj9JoecQtsvJrF70AD1bP2XxWjdXfitjoJyM
   Y=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: NT3IIB7BoZF+xfFJ1xAmPmWgjtNH0yfIS6xM6snXFJiEFAquhx6jroHqbuIYf1o/PYOKJcbYqF
 gc0DYiY03d7qmf7KoRl/v9QxoVaHTs2Dtsb9jcXJOqutbGdpCqpDXFc/7/Cl9s6qQ/5nVmQL3q
 ORuNaXVOTYS/y1E9NNMvOoF4CQoDLjnDtCwv1JEb7LHt9bb0ibOEP0vuvN3QKbu/fk3w/Cnv+h
 hA6Vj4phUo75UFNoTP+VFPQe6J2mAynlViluIoVmWWezadab98v9GcBSkngYcG/4cPzK9xZ4hC
 t6NOoyiAgY6R8HbCOuDpkqxH
X-SBRS: 5.1
X-MesageID: 64219153
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:fNGr/ar3e2YvkiwgmT87Mr9+5RheBmKcYhIvgKrLsJaIsI4StFCzt
 garIBmFP/rcN2X0fYtwa4Xj8U0GuJ7XytA2GwI4pClgE3lE+JuZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlZT4vE2xbuKU5NTsY0idfic5Dndx4f5fs7Rh2NQw24HnW1rlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCnYPuQgowBoDVovRDdjNxNDhCY4dG1rCSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFJkYtXx6iynQEN4tQIzZQrWM7thdtNs1rp4SR6+PP
 pdCAdZpRBn7ejlyY0lGMq8vl/mIrGbSaAZDkk3A8MLb5ECMlVcsgdABKuH9eMGORMhTtlaVo
 CTB5WuRKgoBKNWVxD6B83StruzChyX2XMQVDrLQ3uFuqE2ewCoUEhJ+fUu2p7y1h1CzX/pbK
 lcI4Ww+oK4q7kupQ9LhGRqirxasvBQRRt5RGO0S8xyWx+zf5APxO4QfZmcfMpp87pZwHGF0k
 A/S9z/0OdBxmKLLQn+EzpqNlyPsHAI8CnY+OwUEYwRQtrEPv7oPph7IS99iFou8gdv0BSz8z
 li2kcQuu1kApZVVjvvmpDgrlxrp/8GUFVBtum07S0r4tlsRWWKzW2C/BbE3B95kJZ3RcFSOt
 WNsdyO2vLFXVsHleMBgrYww8FCVCxStbWW0bb1HRcBJG9GRF5iLJ904DNZWfhoBDyr8UWW1C
 HI/QCsIjHOpAFOkbLVsf6W6ANkwwK7rGLzND66IMosTO8IgJV7epkmCgHJ8OUi3zSDAdollZ
 /+mnTuEVy5GWcyLMhLqLwvi7VPb7n9nnj6CLXwK5x+mzaCfdBaopUQtazOzghQCxPrc+m39q
 o8HX+PTkkk3eLCuM0H/rN9IRXhXfCdTOHwDg5EOHgJ1ClE9Qz9J5j646e5JRrGJaIwPxreSp
 SDiABYFoLc97FWeQTi3hrlYQOqHdb50rG4hPDxqOlCt2nM5Zp2o4rtZfJwyFYTLPsQ6pRKtZ
 /VaKciGHNpVTTHLp2YUYZXn9dQwfxW3nwOeeSGiZWFnLZJnQgXI/P7ifxfuq3ZSXnbm65Nmr
 u3yzB7fTLoCWx9mUJTcZsWwwg7jpnMagu9zARfFe4EBZEX2/YF2ACXtlftrcdoUIBDOy2LCh
 QabCBsVv8fXpIox/IWbjKyItd7xQeB/AlBbDy/Q6rPvbXvW+W+qwIlhVueUfG+CCDOoqfv6P
 egMlqPyKvwKmlpOorFQKbczwPJs/cbrqp9b0h9gQCfBYWO0B+4yOXKBx8RO6PFAn+cLpQusV
 0uT0dBGIrHVatj9GVscKQd5POSO0fYYxmvb4fgveRio4SZ2+PyMUFlIPgnKgytYdeMnPIQgy
 OYnmcgX9w3g1UZ6bofY1nhZpzaWM3gNc6Q7rZVLUobkhz0ixkxGfZGBWDT954uCaokUP0QnS
 tNOaHEuW1iIKpL+TkcO
IronPort-HdrOrdr: A9a23:gpCxPauY+oIQpdjHGveW3hRL7skDSdV00zEX/kB9WHVpmwKj5r
 mTdZUgpGfJYVMqMk3I9urwXZVoLUmsl6KdpLNhXotKPzOGhILLFvAH0WKK+VSJcBEWtNQ86U
 4KSdkYNDSfNykdsS842mWF+hQbreVvPJrGuQ4W9RlQcT0=
X-IronPort-AV: E=Sophos;i="5.88,373,1635220800"; 
   d="scan'208";a="64219153"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Y57smHyNjswL/rrZxeiZJlEn7OTTE5UCwY25BiMAyKxnTgspi3rRj30ugokJaX/B4ESLEyD4zSyflIek36Y0zoJlqMVcHG6A17742bVt30zbZjQwmsHOtAnB9XK4BWLPAtlCJmExoqCWhlbpqnA71Rw6G+ViWE0Xhjmzo1oqqzrBTpwnO7DeTVrE33kU0IBeD4OmeadUhb5ekYyK3MTCv45jP++Xu/gbH1PBVxV65sY10gop3Vx1J5fKSF1YHX38Km1E90K3Ajys1AIAB7HtYH26gvfOWCo+hozQnSU/4O0bpnOBdIuDNTbx1SH6S5UKf8ASfCYWxqmjlRwsvCthew==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=+m/NbrA9jbWPANH40Z1eu9xNS2W1mVadFn0RNk2u6CM=;
 b=l9HXLmIgDgrpd1UsTSGvBV81KayWufCo153hi7CJAIIRygRzig+/zr7DgsuqMBRMBya7WN1Bw/1eNiWLGZZ32X7k1WL1T9CnYj+bdtIdxSAobz/MPu71+KYTQC99q8A2NUj/1N7cAoY3mNaJt0PvhQxKz6FFtt1XGeIyMCIJZrZPoNVSsK4sUZ4aqTgd97cdtWtk75z4vqsIDtzEDzR/pb1DKdT8mKJgvVUFIYjv35O0EH0bV//t8pw4tptrztg0VwIsTKonHFcm3XLx0Yiq2JVal0dQT94hf9DppBI6hcUpfVrrghA0ZhS5LM2p+bW0GvA5Zo7uloIpdGoLCpJdpA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=+m/NbrA9jbWPANH40Z1eu9xNS2W1mVadFn0RNk2u6CM=;
 b=ByURqYu+ugQWke5TsaWEwM2jOn2Cfvp3cV6Ud+rXRb6iRzUVWKZAKvhtnsek+jU0uKv58l9g0c5j1c155qvoakEAPm/4laDhurG2XgTMuUhL1BBwpe2pMU/Ug5FnKJjGxXGfnQc/T4EhaUsxFpc7/ZCfWMrlUv9jDsTR8zV8TIA=
From: Roger Pau Monne <roger.pau@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Roger Pau Monne <roger.pau@citrix.com>, Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>, George
 Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>, Stefano
 Stabellini <sstabellini@kernel.org>
Subject: [PATCH 3/3] x86/Kconfig: introduce option to select retpoline usage
Date: Wed, 16 Feb 2022 10:03:00 +0100
Message-ID: <20220216090300.9424-4-roger.pau@citrix.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220216090300.9424-1-roger.pau@citrix.com>
References: <20220216090300.9424-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO4P123CA0310.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:197::9) To SA0PR03MB5610.namprd03.prod.outlook.com
 (2603:10b6:806:b2::9)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e0c5e71c-1e6b-4c65-73b0-08d9f12b31ff
X-MS-TrafficTypeDiagnostic: MWHPR03MB3104:EE_
X-Microsoft-Antispam-PRVS: <MWHPR03MB3104355E93F0D2C98E6F5E898F359@MWHPR03MB3104.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3383;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: +bvGSBYj6zuElY7Lf6NG2bQ4oVRbBh137cnGHznSaAz5Q9TTViV0eHcHsTOPnSynR54lTimPNCnZXu6k3ViXeGbHCprVMPbgK8QP9y8fkINsveBYRjPxi1sXZhRrbdCLkUG1NRXrVEdFxltsaO3av0+9GZMwvhA1UnUV7yAhZ0z9+yzoI+AXW4WLu72ikIBVo8b1Dgc/yOmgSJkIRJQEltoBvLZMQma2N61m6twXO6IyMMYYvPzZ/iY5WSvJfkZ7aG4RK6oaZqBP2fVk/+L0t5CFop6VNC/AVRTaOEu3PYJP6WQL6XLXNvvfP1txeg606OwLTwNcXhQR26yHat6IvAc9UWEbaLH9i2HmPtiH4Jiv6tr5nSjxfEA0njclDeTYhtC4r+RMf3I2dMsyUXZWDIL4BM8UOGAQFaBYgIT5xbFtMMB7YYaCRBVGU7oF7/0gthhid0+M3pJYKMNDMWWlAfr6X+il2sV6LDiBXiMG68ldUoEgzuso5Z8wpqJUD01hl9/MRBtuaF7sskEaOgZjd3AAJExp0+oPtslqhmMKxyrLRCy0K4XOAP/btfW8vUcPEzDYA46upBwmLCsdpUlSLWEWMpensZvK1RxgQ4pAM+x8tEnR+rTrMd8ittIGcxfl7ug6u5K+qGMpCuNoNhQwqw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA0PR03MB5610.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(8676002)(6512007)(2906002)(86362001)(6666004)(8936002)(6506007)(5660300002)(83380400001)(54906003)(508600001)(82960400001)(6486002)(38100700002)(6916009)(66476007)(36756003)(66946007)(316002)(2616005)(26005)(1076003)(186003)(66556008)(4326008);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eFZwMmM2NFFnYzBrb25JeWlFblVMS3R1Y3lrbGVlSGRRR0NZM3RJMUlzajZI?=
 =?utf-8?B?R3JyN1ovekZTa0pCOGcxanlaRFp1czRQdWRQeWp2YVV5d2dES0FaVDFCV0hm?=
 =?utf-8?B?NS9aNGRzdjFRYXMrZXdBdmRtOWxVUUtYd2hCOFoxSTNWOU1NNEp6c1A1M0Jh?=
 =?utf-8?B?aDBNSFJudlEvd1VRdjY4dVBzZjVLYXkrTFBkT0lzNHMwaVN6SFc4MXExYmpq?=
 =?utf-8?B?QTlpWkt5VmpncGNkTkE4WFRjZjdUZ1VSZmw0L2NkQmdTZElXb055YU05NStY?=
 =?utf-8?B?bmFraUp2R2dmL1dVcUVFSEtIaU9nYndQNGUvWGt5NWR4cnR4ZFlmYnlOSzZG?=
 =?utf-8?B?U1pkaGZ1M1NHQjhKdS9rc2s2MzJyZ252bzBkVXBUNGh0dUdyVkVsaEhpVmpR?=
 =?utf-8?B?L3ZEdGJOMnpJVEJqTUhTc0FCdTJSTFNEMldIN1N4YTcweEMrdE9ZeEpNVlk1?=
 =?utf-8?B?RFkvVmp5U3FET2k1Q2g3N1gvelVIMG5PbXQ1akdSbUVzK3JoOE1wS1AzS0VO?=
 =?utf-8?B?bldFdmc4QVJBWE03NG04U2VqOENaa2FpUjZOZXRrZXI5YkxPa2MwQnZDN0t3?=
 =?utf-8?B?Rk8yclJNcHVlcTJQb0dxemk3dzgvYTMwaWl0SjIwZkQ1QlIzL0VjWU5iQ2pn?=
 =?utf-8?B?aGNveUtaaTR1ZFFnOS9udE1Sdnl3YzR3MEhFNnVFYmY5UVFMc2p4NGIxQWRR?=
 =?utf-8?B?emlYbXU0Mk1YMkwzYlZ2N3o4OTBZTFFSZHB6cllib09YTlBGUmJram8zaTEx?=
 =?utf-8?B?enU0cjNCVXR6UzVjM05NbnlmdzBvdnl3UlVUNXBQejhZR2MwM2JQWUc3bnZV?=
 =?utf-8?B?aW5RTTRCbVFGNHJJb3lQWVVpL09iL1k3NGc0TDRIQkVXbGJsS1VUd25jbGh5?=
 =?utf-8?B?RlB6WjNDZi9ZTmFjOXhDZWYrd01WNUtMOC9McnJJdXZXSzZsdjRtTnNFQzln?=
 =?utf-8?B?UGRCUzY1OHlka0VCSko4RjJ3a0Zkb3UwVG1qR3lRYWFGek9rS0RDQ0huVlNJ?=
 =?utf-8?B?cS9QSG1wSjBIbzJacHY2U0JuUFNkZCtkcEUydWRLNCtvYWhJNjVuVEJJbkYw?=
 =?utf-8?B?cktNMkRNVkJ1SVlDOUV4Y28vSE81d21FN2ZrQkRkRlVTazNpbDVhNzhweHNa?=
 =?utf-8?B?TDJhM1poZ3V5eGx2cmgrT1l5Vy9CTVpuN20wRVZsOHd6SWc5RDE4S2NvSFJ4?=
 =?utf-8?B?angzTmMraG1rSTdWMXNyRWVFOWpETjVQV0xOTUZHYUtkM0U0V0YrZlZ5bkhl?=
 =?utf-8?B?dHIzYzhudVZkKzB4bitBMjkycVJWUVlNbUxobmxVTE9LNHU0WmV4M2xKd3JO?=
 =?utf-8?B?UkErRnE3dW1EcWVoYlQzajgwTmk5bG95K29acE5CbUtPeVJibGgwRm9HMnB3?=
 =?utf-8?B?WDhrZ1ZOY0cwVVRoenJqUWNOTXI5b3B0YkxnSURNQ2xOK2JYZ2VkbXlqZ2ZR?=
 =?utf-8?B?VUlTZUtZNDNKL2lZdm1EZUprVksyYnNNM2FBbERZTjlMTm9IS3AyL3VJM0Iv?=
 =?utf-8?B?c2ExNERJbUlOT0E3UllYN3pGVkFqQWlaVDBvWHFrLzZlcU92NHp6RFlzcDFD?=
 =?utf-8?B?WjNYa3Fvb2c1MDhxT2lOd0ZLbXp4WlpPSWRna2pGdXErN25QQkVLMWVuaXRP?=
 =?utf-8?B?a1JpSzNNZUljVTlLaEY2dGV5bE8xNkRNREthdkxJeW5PellKUWRIUWpicUR5?=
 =?utf-8?B?VVF6Q3pMK2MwckVnY1l2VE4zY25adFpYWThEUHQ2dldvTlVBdEpXWDFYSGE0?=
 =?utf-8?B?bGlDVCtVaUZidVVWbCtUaFdrOUtONXkrOTE4M3ZERnZreVYxd29tOEtqa2ow?=
 =?utf-8?B?KzdVVHRMQ1plOEdySzJpZWgyaHl3bjQvY2NBby9rQXFrUHdINUlqeVBqOXNX?=
 =?utf-8?B?c3QyeUx5Wi9Jd3RHRThJVS9LYWs1SjgycXo3WEZqTWpweWJHQTJXQWd0UGNV?=
 =?utf-8?B?QnF2WXJ6bGduMFJTOTBJc0IzQldGMHhEaHd5MnJlRmZUejdiZVF3Z0twcFk2?=
 =?utf-8?B?YUtmMm9WelplQkM4b000ZzFFbjgvZno2OUpwSlA0N0oyS2xKc1dyaGgyMkRl?=
 =?utf-8?B?c04rUE5UVDlUUzJGNGRDNTRVZk5BQ0E1VUxBMVRWOVNBRHBhNWhoZDRyczUr?=
 =?utf-8?B?bEVZMWVlVTJ1OHdHb2twWWMrU0RXaTJ0b1ZkdHhCcWhJcDE1Wkt6WXdBYUE0?=
 =?utf-8?Q?jmC74iw2FgyMmiucVL1N+Es=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e0c5e71c-1e6b-4c65-73b0-08d9f12b31ff
X-MS-Exchange-CrossTenant-AuthSource: SA0PR03MB5610.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2022 09:03:27.5754
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Chk3v1fORFTYRO5g18Tl53vY4D/hsFc8YOT8SkNGmfKE3lYQUfQwN0srNSr1yXho67rLMDNV3trG6TwkHt0zmA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB3104
X-OriginatorOrg: citrix.com

Add a new Kconfig option under the "Speculative hardening" section
that allows selecting whether to enable retpoline. This depends on the
underlying compiler having retpoline support.

Requested-by: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
 xen/arch/x86/Kconfig |  4 ----
 xen/arch/x86/arch.mk |  2 ++
 xen/common/Kconfig   | 16 ++++++++++++++++
 3 files changed, 18 insertions(+), 4 deletions(-)

diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig
index fe00b4598b..7c73802adc 100644
--- a/xen/arch/x86/Kconfig
+++ b/xen/arch/x86/Kconfig
@@ -38,10 +38,6 @@ config GCC_INDIRECT_THUNK
 config CLANG_INDIRECT_THUNK
 	def_bool $(cc-option,-mretpoline-external-thunk)
 
-config INDIRECT_THUNK
-	depends on GCC_INDIRECT_THUNK || CLANG_INDIRECT_THUNK
-	def_bool y
-
 config HAS_AS_CET_SS
 	# binutils >= 2.29 or LLVM >= 6
 	def_bool $(as-instr,wrssq %rax$(comma)0;setssbsy)
diff --git a/xen/arch/x86/arch.mk b/xen/arch/x86/arch.mk
index f2aa2a515f..0597e714f9 100644
--- a/xen/arch/x86/arch.mk
+++ b/xen/arch/x86/arch.mk
@@ -42,6 +42,7 @@ CFLAGS += -mno-red-zone -fpic
 # SSE setup for variadic function calls.
 CFLAGS += -mno-sse $(call cc-option,$(CC),-mskip-rax-setup)
 
+ifeq ($(CONFIG_INDIRECT_THUNK),y)
 # Compile with gcc thunk-extern, indirect-branch-register if available.
 CFLAGS-$(CONFIG_GCC_INDIRECT_THUNK) += -mindirect-branch=thunk-extern
 CFLAGS-$(CONFIG_GCC_INDIRECT_THUNK) += -mindirect-branch-register
@@ -49,6 +50,7 @@ CFLAGS-$(CONFIG_GCC_INDIRECT_THUNK) += -fno-jump-tables
 
 # Enable clang retpoline support if available.
 CFLAGS-$(CONFIG_CLANG_INDIRECT_THUNK) += -mretpoline-external-thunk
+endif
 
 # If supported by the compiler, reduce stack alignment to 8 bytes. But allow
 # this to be overridden elsewhere.
diff --git a/xen/common/Kconfig b/xen/common/Kconfig
index db687b1785..3b0ba16a6a 100644
--- a/xen/common/Kconfig
+++ b/xen/common/Kconfig
@@ -146,6 +146,22 @@ config SPECULATIVE_HARDEN_GUEST_ACCESS
 
 	  If unsure, say Y.
 
+config INDIRECT_THUNK
+	bool "Speculative Branch Target Injection Protection"
+	depends on X86 && (GCC_INDIRECT_THUNK || CLANG_INDIRECT_THUNK)
+	default y
+	help
+	  Contemporary processors may use speculative execution as a
+	  performance optimisation, but this can potentially be abused by an
+	  attacker to leak data via speculative sidechannels.
+
+	  One source of data leakage is via branch target injection.
+
+	  When enabled, indirect calls are implemented using a new construct
+	  called "retpoline" that prevents speculation.
+
+	  If unsure, say Y.
+
 endmenu
 
 config HYPFS
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Wed Feb 16 09:12:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 09:12:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273817.469087 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKGMD-0000KM-5Y; Wed, 16 Feb 2022 09:12:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273817.469087; Wed, 16 Feb 2022 09:12:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKGMD-0000KB-2O; Wed, 16 Feb 2022 09:12:17 +0000
Received: by outflank-mailman (input) for mailman id 273817;
 Wed, 16 Feb 2022 09:12:15 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=oYE0=S7=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nKGMB-0000K5-CE
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 09:12:15 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 863dd229-8f08-11ec-8eb8-a37418f5ba1a;
 Wed, 16 Feb 2022 10:12:13 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 863dd229-8f08-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645002733;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=v71hvXgENyt/7i786Sjub7qsSd4F6KSUH5lYS3es2XY=;
  b=HUyN8pcpUW8k3fj7eehhbDilcW0CcM1EREjQvohk0hUnmtMoPJaOGbBT
   eLYKxQx9yCcf/IwQ9V8ayeFYoKlneR7WLiay97c7Ifu+B6HH0ncOLjC8P
   P8mBoYvHStx2ylT9j7DZh3diTBqDhsKLQT4yUUL7GmF6oCHyX2XIm8NJH
   Y=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: +0WPSXzeeuwHjyTZycKIiISjtvMcc8TXA7SdVxPbUIpH+iLvi08XBFgPhjjDJ0GVcWhf4O/N2C
 MPWDxY+8JTbooyiKikiHAomgFSSTPHJ73Ees7/Uc1rAA2sSOhzDHG4rjyO2+yFh6RlwcUerfnZ
 QkLQjXr1h4GUFTOaDYI28KW7sz9FyATm4GUqwOfdBH3DTRieL7xxjtkvSujM/fiSZHObGmfUuj
 ZvCamqdTew/pokKwG1V7QaAidaHh3cnOb7EsoMGb68KhVLuxUOi3LUGtKxIuD38f+AfNUcakLV
 qINArmYZ2EsDPkKY7xLmeZU5
X-SBRS: 5.1
X-MesageID: 64321649
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Y0bFpqrkXFrDEnTDjyMtXStIA3xeBmL3YhIvgKrLsJaIsI4StFCzt
 garIBmFOP6JYzP1fdggO4W28EkFupeAyt4yTgFoqysxFX5H+ZuZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlZT4vE2xbuKU5NTsY0idfic5Dndx4f5fs7Rh2NQw24HnW1rlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCncytcisMIrX2ofkUbTpDQipdG4dk+aCSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFJkYtXx6iynQEN4tQIzZQrWM7thdtNs1rp4SRqyHO
 ZZIAdZpRAnyXEdJYwosMYwnrf+XjGjnKz9pg03A8MLb5ECMlVcsgdABKuH9eNOQQt5Otl2Fv
 W+A9GP8ajkYPtGCzTuO8lq3m/TC2yj8Xeo6BLC+s/JnnlCX7mgSEwENE0u2p+GjjUyzUM4ZL
 FYbkgIxqYAi+UrtScPyNyBUu1bd4ERaAYAJVbRntkfdkcI4/jp1GEBUUwVtTcA+jvYrTAIJz
 Q6CvPXDJz1w5ej9pW2myp+Yqja7OC4wJGAEZDMZQQZt3+QPsL3fnTqUEI89TffdYsndXGipn
 mvU9HRWa6A70JZTv5hX62wrlN5FSnLhagcurjvaUWu+hu+STN70Ptf4gbQ3ABspEWp4crVjl
 CVc8yR9xLpXZX1oqMBraL9QdF1Oz6zYWAAweXY1Q/EcG82FohZPh7x47jBkP1tOOc0ZYzLva
 0K7kVoPuMMCYSLwPP4mOtjZ5yEWIU7IT4mNuhf8NIQmX3SMXFXfoHEGibC4gwgBb3TAYYlgY
 MzGIK5A/F4RCLh9zSreegvu+eRD+8zK/kuKHcqT503+idK2PSfJIZ9YYArmRr1ot8us/VSKm
 +uzwuPXkn2zpsWlOXKJmWPSRHhXRUUG6Wfe8ZwHLLXSfVA/RQnMyZb5mNscRmCspIwM/s/g9
 XChQE5Ijl35gHzMMwKRbX5/LrjoWP5CQbgTZkTA5H6khCouZ5iB9qAae8dldLUr7rU7n/V1U
 +MEa4OLBfEWEmbL/DEUbJ/cqo1+dUv02VLSbnT9ODVvLYR9QwHp+8P/ele9/ic5ESfq59A1p
 Ket112HTMNbFRhiFsvfdNmm00i14SoGgOt3UkaReotTdUzg/ZJEMSv0ivNrccgAJQ+anmmR1
 hqMAAderu7I+tdn/N7MjKGCjoGoD+ohQRYKQziFte67bHCI8HCizIlMVPezUQrcDG6kqr+/Y
 eh1zu3nNKFVllh9rIchQa1gyrgz5oWzquYCnBhkBnjCc3+iFqhkfiudxcBKu6BAmu1ZtA+xV
 h7d89VWI+zUasbsEVpXLws5dOWTk/oTn2CKv/gyJUz74g5x/aaGDhoOb0Xd1nQFIesnKp4hz
 McgpNUSul62hRcdO9qbijxZqjaXJXsaXqR77pwXDecHUObwJo2utXAENhLL3Q==
IronPort-HdrOrdr: A9a23:2PlxAK493KcTOw+2fAPXwSqBI+orL9Y04lQ7vn2ZFiY7TiXIra
 yTdaoguCMc6AxxZJkh8erwX5VoZUmsj6KdgLNhRotKOTOJhILGFvAB0WKP+UyEJ8S6zJ8h6U
 4CSdkBNDSTNykCsS+S2mDReLxBsbq6GeKT9J/jJh9WPH5XgspbnmFE42igYylLrF4sP+tEKH
 PQ3LsOmxOQPVAsKuirDHgMWObO4/XNiZLdeBYDQzoq8hOHgz+E4KPzV0Hw5GZVbxp/hZMZtU
 TVmQ3w4auu99m91x/nzmfWq7BbgsHoxNdvDNGFzuIVNjLvoAC1Y5kJYczIgBkF5MWUrHo6mt
 jFpBkte+x19nPqZ2mw5SDg3gHxuQxenEPK+Bu9uz/OsMb5TDU1B45qnoRCaCbU7EImoZVVzL
 9L93jxjesZMTrw2ADGo/TYXRBjkUS55VA4l/QIsnBZWYwCLJdMsI0k+l9PGptoJlO31GkeKp
 guMCjg3ocXTbvDBEqp/VWHgebcE0jbJy32DHTr4aeuonprdHMQ9Tpt+CVQpAZEyHsHceg12w
 3zCNUcqFh/dL5mUUtDPpZzfSKWMB26ffueChPaHbzYfJt3SU4l7aSHpIkI2A==
X-IronPort-AV: E=Sophos;i="5.88,373,1635220800"; 
   d="scan'208";a="64321649"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ks+qsuwrS6S3xjuNZdnxt6XkVd7lYkd08CHE20Unyp9p8oYUq4h3LEzxfVH4f/gXnrdAr32cMj72fpM8/d4c9uHFFQXlv3EnIGYr7+4XDVJo3ZUIBJM5MfqXjQgcQyOqa5sGNE0rd5a+PM38yQ8cuoGt2cz6x1RT3dcL3t4joRGo/6U3Icu0CduMKU6NjTOMWW3y3TgoKXVG9ENcPIqPm3ObIjQjSn1B31125mtJzMNOzxDDmBo6AYMmKH3MuCe0dfND0dAuDFoxjRvHrJXe0z1n1XSH3FC27xxe3CD8fA5+yFW4MzgjmEsiRP5ERtyidaCJSLcse/TGQjjRvDdNpg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=udVluXiR1QzWXX/IJsGNlDXZGztfrZ920p1zPk5J7u4=;
 b=EK8sgsqhsFd1AgmUW6+PKzDPTar623Rrvp0nk+Tqbp69NNowGayM5GsitWbgg76P60yUBBP9Si4aDmtSqcZJaqp8LXhDDqpt5VIARKBsP/AgODFdMbeeBjWEyPIVCGgQeIy/E9h6EDXOCsdx0FEbu5Pp7m9USWt0ilNQk+rfaU2Ps6YQkG/MmeAwYXicQHYzvTQrUBfuKsGj1R+jyaF7LDzq7VToOaz8W7VXgG+fRcf2DSpuyZChSZEGrtK/KaBLGICu/itdGQj2sLJqcVmh4cMw/NFIEc3V1pFqLWpkzoIGNKes2ymFCfp/q1vPq0tRsK6QQzn7HP4P4UDpKeb/OA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=udVluXiR1QzWXX/IJsGNlDXZGztfrZ920p1zPk5J7u4=;
 b=YFjlxSbpjj4xyVwq5dz6zA7bl5kiqxUR3lUOkZG/9sU0VvSztQt9n1i1Pega95C1kZvFGMvVDdExAqo2QdrT2renKFP0sXBqWOTzhNkDxdvA1iKJ2qNGbp0pxYynYNJRgAuHpRJIKTRijymDDFXjA9l8kkvHUg8nPMvM+4q39k4=
Date: Wed, 16 Feb 2022 10:12:03 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Anthony PERARD <anthony.perard@citrix.com>
CC: <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>, Juergen Gross
	<jgross@suse.com>, Jan Beulich <jbeulich@suse.com>
Subject: Re: [PATCH v2] tools/libxl: don't allow IOMMU usage with PoD
Message-ID: <Ygy/4zk8Eo78ECi5@Air-de-Roger>
References: <20220203143211.18967-1-roger.pau@citrix.com>
 <YgvB5UtyC29m8zbo@perard.uk.xensource.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <YgvB5UtyC29m8zbo@perard.uk.xensource.com>
X-ClientProxiedBy: LO2P265CA0443.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:e::23) To SA0PR03MB5610.namprd03.prod.outlook.com
 (2603:10b6:806:b2::9)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9a4ff2c9-3752-414f-ee54-08d9f12c68a4
X-MS-TrafficTypeDiagnostic: BL0PR03MB4131:EE_
X-Microsoft-Antispam-PRVS: <BL0PR03MB41312960EAEC579CDAA97EBC8F359@BL0PR03MB4131.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: xEc3SHJVzd3hOdmPKLPVfJaL8vhTX3GTbL5Z/LTn9aXIehD2sCd++rqSbdQyKt/t+uRIFM9aqeMTovfei9/uel9YrNc0FXAD2aXytN9oKdHhauPnUzKsZRRruksdxdbTR0SDDm9+VjNEu4Ag5IAjOsvvk9DFyRI/Z/59h7dpnxE8kvEVDak95z8pz/In5aprcKXHoAvDYy5sPLvEZUbzhws25mEAVPvwUdA1SsrPKYUXufZPSEYlDdpuO9QtmUwhtQnzuO3ZcajEhVYpjI46NJodsWKpfGXnkjeJT00qGibTkU63PorgEPyYDt6OoULFw9N/PWmuGtaZ74HG3X3qg9DsGjwNVVTdF9xAfd0Bn2xYgpa3Km5168YsBoZ7JNY/YtCVBFKOaN/RGK7J5vN/4hkW9jhof48nOC4ajsZViZW9sn8FzPU5vFiCudvm5Do79vcIWbXBz99gWZ5uSU2isGjuuLwpTqPNNVXM8kuOVITa2dIOIuh6ZZBaDW1Hqfasy9DbAvnqlpdSxUGlwZgRkDoy3FghOzzvLt65XHA0vo1knSEdBqJOdgBaaS/voOlyRFQUbTiDJb14N6pUPQXTZSZqfPQEfiyaGc/kwGRZXFhK2AhL5m20+V9qWhFRwe4Swmzr/wkgAYqqsm80yX8LDA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA0PR03MB5610.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(186003)(33716001)(6636002)(316002)(85182001)(6486002)(4326008)(508600001)(66476007)(86362001)(26005)(66556008)(82960400001)(54906003)(6862004)(66946007)(8676002)(6506007)(2906002)(6666004)(9686003)(38100700002)(6512007)(83380400001)(5660300002)(8936002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eTFlMTFiZ3A2QXl3aVdoMEtocWFnelpKcFphbGhMOGtNa3pITUgzbndNWUl4?=
 =?utf-8?B?VXhjL1NYaDE3cDl0TzZmVkxmb3JnRE5PWjJJalB6a3Ryc1ZyYlhBRHFoZmQ4?=
 =?utf-8?B?SVl5YWJFcHZxU2pkU29nQ21hTW9lQlVPcVkxRW9lSUoxbVJlL3ZvdHZPTVlm?=
 =?utf-8?B?dnMwbnMzUlhUcFZwUG80TlJ2U1I2c3VDa2Zxd2tqRVlsamUzaHNEV1B6RURS?=
 =?utf-8?B?TG5lenlFZUlVTWFZelM0UzZqV2dlcFFkazg2cXhhTmdiWkpuRXlGVlF3dlVL?=
 =?utf-8?B?eFFDZVd0V2lFZ2JQTVBQdk9HZzd3NUpqQWZ3cXJvVk1ESXF6YXZoSGtnaE15?=
 =?utf-8?B?MUREOHJpTGZjcVZ3YmlOMGtsSDk0VVlpYnVqQ1lXem5KRC9VenRZQmtUNDJP?=
 =?utf-8?B?N0xwbnFxd1dic3MvTXRPZzdGcjAyOTlyUnpqWVBNblBzSXlpeWNCWFFkS3U2?=
 =?utf-8?B?cWVZMlJ0bGZaS21TWnFzRUprK0xCVDM1amZ1MlRNMFFaNUxVTFpiT3FpNmFu?=
 =?utf-8?B?QlBaS1FYa3JYeDJISWVtLzNWVEw1Wmx6bXhtZTNKRmtLZnB0WGxUT3RLNXhM?=
 =?utf-8?B?bGkwUSt1VzNOMVQzdTIrZ3NJdVNWRDBxZUZRYnV0MGk3T3BTUGR2eDI3YXJQ?=
 =?utf-8?B?VWN4cng0V3hkOG5QZTdzaE8wckozU0FYZEZ0SXdFaCt3cGFVZVoycFpGbEFN?=
 =?utf-8?B?RGpzOWZrZWdEZVFoV0ZaS1NCSUlYeDlJa3VNSGM3ekZGUTArNytaZzdUZXYw?=
 =?utf-8?B?SDJpSWkydnZSa20wZTJCZ3lFQ0w5UlRDSzgzYklkTU9Qb0RQc1JLaWg1ZmlO?=
 =?utf-8?B?alF0ZWtIM0ZCQ0RsdzJDUUdMWHZzUjRsbXVTVGkveEVUOFFBTy9SN3YvdVUz?=
 =?utf-8?B?N3RDcTIrNWtMSC95YnVrR3NzTUtZSmlNUVpPQ1JrTzRyc2s0SEpJTmVvSm50?=
 =?utf-8?B?a2NzRHlFZHhmSC9zd2RzUlg3KytIa0VEQUtZcXkzZzZGR1VuQ294Ui9oT3ZY?=
 =?utf-8?B?WTQ5SWJybjdSb2RyQUw5ZnZjWEtRZ1V3SS9TWkNSd2N0aU4yVk5kT1Zlcnpp?=
 =?utf-8?B?OTZ5Y1ZGOWZGZTcwUTE0TFlkZmlVVzNlSHlXY1NIWlhHRGdldnhPaVZ2YkFl?=
 =?utf-8?B?d2tNaXNLK1I5MWlOK0pDN3k0cXJXNnRmdzJDNHNLV1RSeWdYd1pIMXRCOGFO?=
 =?utf-8?B?OU85ZWNZVVpiTEc2ejFTc0RlQ0pvN2pEd3ljdEhxU2ZSam1hd1pGeGJMdGFL?=
 =?utf-8?B?Vjl5VW1xZzFUY2ZOam40Mll1bXk1MjV5dy84eWJYYU4zT21QTmFLK3hGRFlQ?=
 =?utf-8?B?S1ZNMW9VQjlZcWVYeHNBcG5tbGhGMm1LanVmKzA3UHdiWXhzYXJkMmc0djJt?=
 =?utf-8?B?UmVvaXFVc3VDZi92a0JxbWZuMEF3UjRkb2N0aGFDS2JKRGdyZTJRTEhIdXRi?=
 =?utf-8?B?KzAyenpIY1VlaktGMG0rMG1FWGpXUFVLeXo4azV2azU4UXJ5UEg5emthZXR6?=
 =?utf-8?B?bHFFd3dKcmltNW9wWk53VDRoUDNSZHBweHVMY1lPejZ5QzA2bjEwQittMStU?=
 =?utf-8?B?bXJITHNLdzFsbjhGR0lJaGZKamVEZWdNREFjVGlvTFBsYTZvcWV0aWY3eXJR?=
 =?utf-8?B?Mjk0T0FwK0xHM3FOVDRNTzNWYndoc2lwdERnSWZyckh3NStWRXk4SktyY0N2?=
 =?utf-8?B?OXRoUVdnSE5SYXdadm1KOFlNN1grOVNJcUFQTzJaUXA2OXhYNUk0R1hKNmk2?=
 =?utf-8?B?d3VOMEVZMEJmN0ZLNXBEaVBXaXFPQW5MT0JYYkp0Y2t0Y3ZlYkM5Ny84NUpU?=
 =?utf-8?B?OUpwYnAxenYvRWNiSGppZCtjL0FocFp1YU16QkI0TmdKblhYelo5Tkp1NVBh?=
 =?utf-8?B?QXlRT3ZNNGk4SnBURFh2czk0NHgxbTVpQldqVlZhZTdQY0pKbGoySkdKcDYz?=
 =?utf-8?B?K2ZaeTUxb2tKUUoxYnBQQVZyVVhCNFdvQVExbitKV0hMNDYrdXRtWTgzaTFY?=
 =?utf-8?B?aWhEN2JYT2xQbGFxY20wUnlSckZreGQ3d2xtNmhuVUlsTUU1UVdnQjBrT1R2?=
 =?utf-8?B?ME9xOUtNMlJvVUpVNHZYNDMvWFpyV2FxSUViV3EyZSswUVZXcUN1TkMvTlZt?=
 =?utf-8?B?NGxxUU9MaGQ5bGwzSUVvZjlMcG1uaUhYeUV0ZGpaMHhTZlVmRkpaOTRKN2dw?=
 =?utf-8?Q?h3H0tUIyYCIxmqCeSraC/bk=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9a4ff2c9-3752-414f-ee54-08d9f12c68a4
X-MS-Exchange-CrossTenant-AuthSource: SA0PR03MB5610.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2022 09:12:08.7536
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lEpCga5/QqWwHzooRioC5yjUAYPCjxK0r44sueYgXBIgR2lysz0C3h83qoNScsFUDkDx1qgUcZh5jnjdsj+nlg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR03MB4131
X-OriginatorOrg: citrix.com

On Tue, Feb 15, 2022 at 03:08:21PM +0000, Anthony PERARD wrote:
> On Thu, Feb 03, 2022 at 03:32:11PM +0100, Roger Pau Monne wrote:
> >      if (d_config->c_info.type != LIBXL_DOMAIN_TYPE_PV &&
> > -        d_config->num_pcidevs && pod_enabled) {
> > +        d_config->c_info.passthrough != LIBXL_PASSTHROUGH_DISABLED &&
> > +        pod_enabled) {
> >          ret = ERROR_INVAL;
> > -        LOGD(ERROR, domid,
> > -             "PCI device assignment for HVM guest failed due to PoD enabled");
> > +        LOGD(ERROR, domid, "IOMMU not supported together with PoD");
> 
> I'm not sure that this new error message is going to be good enough to
> point out configuration issue for the guest.
> 
> One is going to set 'pci=["foo"]' or 'dtdev=["bar"]', which will enable
> passthrough. Then they may get en error about IOMMU or PoD.
> Should we maybe write something like this instead?
> 
>    "IOMMU or device passthrough not supported together with PoD"

The "or" seems weird to me: IOMMU is mandatory for device passthrough.
Maybe:

"IOMMU required for device passthrough but not support together with PoD"

Would that be OK?

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Feb 16 09:14:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 09:14:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273823.469097 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKGOT-0000vV-Iy; Wed, 16 Feb 2022 09:14:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273823.469097; Wed, 16 Feb 2022 09:14:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKGOT-0000vO-Fo; Wed, 16 Feb 2022 09:14:37 +0000
Received: by outflank-mailman (input) for mailman id 273823;
 Wed, 16 Feb 2022 09:14:36 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Gpsw=S7=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nKGOS-0000v3-3j
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 09:14:36 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id db89a027-8f08-11ec-8eb8-a37418f5ba1a;
 Wed, 16 Feb 2022 10:14:35 +0100 (CET)
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur03lp2050.outbound.protection.outlook.com [104.47.10.50]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-16-2SIo1XAgNs2NIXUVjSMROQ-1; Wed, 16 Feb 2022 10:14:33 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB6927.eurprd04.prod.outlook.com (2603:10a6:803:139::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.16; Wed, 16 Feb
 2022 09:14:31 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4995.016; Wed, 16 Feb 2022
 09:14:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: db89a027-8f08-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645002874;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=NrZZgoYJY4MdIwcI5jvVrDweJ3r9pdUYfrO9hKacT04=;
	b=frVSHwBAtomNbz5cNBji/11f/v/k5diaQuhwwD4SEp0HaR/4BK7rN5fWYlKQ1nPlKZCSSe
	S8l98hr4eE9GXqC+BGZc8u59cxuDFITcythBudq/Jo3YfwUPvcEy8yoHAitfr9F7vWBiN+
	fl7YGbdFQKA4a3LaOZ+L7JqAfD1krMI=
X-MC-Unique: 2SIo1XAgNs2NIXUVjSMROQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=D9TQg/UjlzHMlEGvBpOdcRTZhcapHT8udX1H4SqZtuG8pwvt53rvjc0+8i+/QhP/LyabvcaLarnnPQ9hRXTGN/YLETWQ/bODpe5WSZ89D/gRGGl8S/KHkWc5Nil6K5KdAx/lZ1CrVp0n0Bs1howZpmuXEyixR5gv02D61QPXAcOA5SPxJ1q4o/ENZ6PVDc2BlbAGSbdWeEgRfC7MUXhFqqbevQ9adhVkeOIR1Tdshd1ckUT/NNmMxNd6O+ftLOIcBYeYclDL3auT2oBx9Rh5M9PiWH9Fq0b6oeewZnCRiSDhs0k8tiBWcWksd7ZpEBDgu2L0oAtnWhw/BcMFd6F/cQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=NfBFHIon4DQN6FibBfU6ww05ycs8WLzjZ4KvIryNk+8=;
 b=YQRVrGa2WD13NPx5SaSz8jazNRwV3lfmIW2yE2eZASLAU1tspZejE9AD1A7ojkaBvmKyVvXAeKLSr8TYrQ5AvZM0qz7Xlgs8wts3Wa78lxZIHutVV1PcFi5hFFNHfHGuVO8ZXYtvm+6/8nGHri8kGifS8mcDCo8mnE2M0P1Vo07oNH8s9LkKkKiTI+cx76Wkg0o9MCvTwmuHgQjEvsckUo4HAcRfGRWnF9UJiW1H7azGdRETlS+AAmPVmcRCc6C2M1nrEhrYc0YyV0avE5l4DwGepmiH2jwcc8ITYyfuSwYllkKkwQUEeM1IgTaLQIn1GmdQMYoCCvtPPvfVEamd9Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <9b1830fc-c189-a421-11da-0b854823b741@suse.com>
Date: Wed, 16 Feb 2022 10:14:29 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH v2 69/70] x86/efi: Disable CET-IBT around Runtime Services
 calls
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
CC: Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
 <20220214125127.17985-70-andrew.cooper3@citrix.com>
 <0eede8ae-c2a2-cc87-d4cd-47ceffd4e488@suse.com>
 <9909b7ca-3346-a46a-155c-e4a83d99b2fb@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <9909b7ca-3346-a46a-155c-e4a83d99b2fb@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6PR0202CA0045.eurprd02.prod.outlook.com
 (2603:10a6:20b:3a::22) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 3af3e12f-6f49-45b6-5af0-08d9f12cbd81
X-MS-TrafficTypeDiagnostic: VI1PR04MB6927:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB692758BF58B901065ED4BBBEB3359@VI1PR04MB6927.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	JL7m9XjMDiLUeNbZl9w4HtiS+SNc67Y2w8dDb68djtLBQ5Ydfuo9guv8eU8jQNffJzk3C2yrnwxakrB77FxjYQ3LdGs/7OedzpoXL/fWXVmzHpaAJhjdGiCZb1/TjUex/nOltYnoZYrc748bcyFouiqoA7NA07hwYL49GkhMq9x5bJGB5bvONAo9TTOM4W15cOEniJwM/qYuvT2L6mLMhFWXJWFC+RpZHQYL+9YZodT+Kd/GNDihdSsGU6+f8/qfoA9FkG1xurFsQZ9puwjeD1l9I8LhxMJrnmvhwVQhDrfmYp3lhp6QsXBVazTzk+WqJ/4XfnL5jXNiiWoqSGjdC/m7ww7Lq/GORBNTowLAbfF7BbJyGCYPr+BnQj8K6niK6r/YP6e8nKcHbGriesIDNG3XBqdE1N36x9qnAKvrkoiTcX1syMbj19Lru80KypRAOJlPiiakgSAE1Q7gQL5pm5GXsBQUzIm0qK9cz+yS0kSnfD6BUR1ppWUsmOk32OrN1lnyyutCOHokstK40dwLeqq41VBkwbEKIsVGNavBe7ACB3foKQIlIUbA40BnY/d/Jcghh47ZOyzbPgVhiayi3oyw0EkTjX81L0A2GjMIaXpq+zlrjOvRukh1OUJ+b6maUoVlbUX940B0YHutl0iYaaC7UbNMy5r0chwN48jxD2S4bquWjjrQt48eYJci4vUva/ILNVc871MGgzAYrnWbvvnj0FjcZqe7350otToS1hXaDqUthaperVuPcm9yaimo
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6916009)(316002)(66556008)(66946007)(83380400001)(54906003)(6506007)(6512007)(508600001)(6486002)(38100700002)(8676002)(4326008)(66476007)(53546011)(86362001)(36756003)(31686004)(31696002)(2906002)(5660300002)(8936002)(26005)(186003)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?OLQbQshf6L8PHMY41wZFCCANy/T/6k1MRPw8WhNtGdI9Gd5hOxy1mUAidx8C?=
 =?us-ascii?Q?y39jJDlUUcAS7+OglTTFhb1IOdxuz0m/6TMmhcH4BUPwYqSeYmUKxT7S7YUm?=
 =?us-ascii?Q?U69QecO2NfdYTl05mFdt50dy2Z+7I1amGa73RdQwavIbCc/fhy+jAjAe1JgG?=
 =?us-ascii?Q?Hod+6vXp925+FYiaYRWCJtdRSFjWu5036c9pYp87hEKw0zilNF/SgOqBZrAw?=
 =?us-ascii?Q?qC7U3IDUl9fnh88mf2GcLmausGyjuk2TGhGflyLa0zWdpBGSo6zXho2hiNef?=
 =?us-ascii?Q?DV/2t4pCGi7dLyEXZj4VgfmFf2N/00O7Mu910hX310NrxaEoZhlwPPNlNt6c?=
 =?us-ascii?Q?so6Zw2iZFeyH3Fdi5X7W3eK2KbU8N4ER3yk5LO5j3bdc2aLfEp/cp7BAlm3D?=
 =?us-ascii?Q?8XRYIynEd4zp9RrfKGpb1NQScVpaTzoeRD8G1r9Z6zdf1Rs9wiT4+3Ogog/m?=
 =?us-ascii?Q?MxEE+9jHl1T33SK3A04i7LU0ZHVlOXeWpC0fFUJCPLI1U11iPrn/rkiIXUA3?=
 =?us-ascii?Q?tZuWlWc4Xk0z/phStDaJrvSmBZgrCxN6obiUufPHdpTx+Pa73M9j/qh45e+2?=
 =?us-ascii?Q?n+VcF/I4rJ+Bgrke9CMmXFGquqnahkIH2OXHj1RZG5KKY+3bC2Q2l7fWGANs?=
 =?us-ascii?Q?azRf8jRxcpiKByBZwib5v+jpnW6en8ctyVMkz0FD5ScrGq7SfyNxTiVDBxDX?=
 =?us-ascii?Q?uhofXE5FruUG6oLJchqPs01u1HoAaHVw7PQFZFGuQGMsOVBUV/LBuG1ncdHi?=
 =?us-ascii?Q?zdoPCcYntBW/oVFQc+YVUD3f9VuweaPzcQJGvwA2z/RQ+2Mx23zez5YNG5o/?=
 =?us-ascii?Q?No+J9mSrGC43AA66d0jrm6lh3WBgeLxdsyx0mGYIgsSUVyspUKkHg73L8eaC?=
 =?us-ascii?Q?HloXW9FAYkoqjKfht/mgZCZQ3Kj4pHLSPBsdYg2lBS9BI9Mojj67aFj6jaXT?=
 =?us-ascii?Q?R10oABKkwltlRz5RYBXkNAKkSSLYKBdBdH1AxzP4VyY5UTz8mOVYpbfyiIZt?=
 =?us-ascii?Q?AFsuTk5wxkZo7mu44TGx51xBTJMmvZKehiROXK8ivkMR4w92Bl/KJk3cRmqv?=
 =?us-ascii?Q?nSAhIYaNMZX3fKNun8nVL58OCDx7FnehsxO6MHHDOX5lrM7qp7NdvTgz4Yur?=
 =?us-ascii?Q?1hxe/GV8/0CaooZ5pzL2nzjAq9dWNwAxOlgOEVtSGnxT2ReEewZSZ+2PGXnF?=
 =?us-ascii?Q?A2YpaEwMR2TreGIakbPz1QD8pUOJi6OTEvuwJZAZ7jYvDtHbpoROPhLpLlhb?=
 =?us-ascii?Q?S2e1Eitc9/cjanyzbiUC/uTHRg3hkH1hENPRzVZLvF17udFobBFukn2Dk8wR?=
 =?us-ascii?Q?y4KgA3RKclKilrLvWITPNPtNvcG2eJnseleePTp+ge3r21O80EyLfb792Hze?=
 =?us-ascii?Q?RLQrsUvfQ6qDUJkWPzzM87zOyUOUX3FIPfXDBCwC+dnT7amvU0UyMOolfRFo?=
 =?us-ascii?Q?1QxrmdRVBqr+a6KMb1DZsFK1UhKotxD2MF5/cOQ0RZPxXOj+qogNzi3A7EO6?=
 =?us-ascii?Q?KUvUz3xpYx2UIxcLtlFwgj5L88oIEvXbw2ysnmpSg467bTOxwASz1rN+wgDH?=
 =?us-ascii?Q?tESLkuELTGOwamzqSH+lA1PMtk2k6Hy0I5xF45WTKORMWn9T/yj/Azg2eYcK?=
 =?us-ascii?Q?M1AC1HqWr4B27yKXA1eupjs=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3af3e12f-6f49-45b6-5af0-08d9f12cbd81
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2022 09:14:31.1737
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FQPAbwiYfi4X3EgUccvmwBOGedl7xbsfh2TqtStpfhQSlQVFG1r9lDYdfpR3hFbM1m+ilGsuudZS52ERA1GaEQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6927

On 16.02.2022 00:00, Andrew Cooper wrote:
> On 15/02/2022 16:53, Jan Beulich wrote:
>> On 14.02.2022 13:51, Andrew Cooper wrote:
>>> --- a/xen/common/efi/runtime.c
>>> +++ b/xen/common/efi/runtime.c
>>> @@ -21,6 +21,7 @@ struct efi_rs_state {
>>>    * don't strictly need that.
>>>    */
>>>   unsigned long __aligned(32) cr3;
>>> +    unsigned long msr_s_cet;
>>>  #endif
>>>  };
>> The latest with the next addition here we will probably want to ...
>>
>>> @@ -113,6 +114,19 @@ struct efi_rs_state efi_rs_enter(void)
>> ... no longer have this be the function's return type.
>=20
> So about this.
>=20
> why aren't we using __attribute__((force_align_arg_pointer)) ?=C2=A0 It
> exists in at least GCC 4.1 and Clang 6.

Perhaps first and foremost because this is the first time I encounter
this attribute, despite it having been around for so long. However,
Clang 6 would be a little too high for the main box I have a Clang
installed on - that's Clang 5 only (and, afaict, no option to upgrade
without also upgrading the distro, while I'd also like to avoid having
to also build myself Clang binaries; maybe sooner or later that's
going to be unavoidable, though). While from binary searching its
libraries it looks to know of that attribute, it still doesn't accept
its use.

The other issue I see is that using it would be fragile: We cannot
afford to forget putting the attribute on any of the relevant
functions. Whereas the present model makes it impossible to miss
any instance.

Finally the attribute's interaction with -mpreferred-stack-boundary=3D
isn't spelled out anywhere. It looks to behave sanely on gcc 11, but
who knows whether this has always been the case.

Jan

> We're way way overdue bumping the minimum toolchain versions, and Clang
> 3.5=3D>6 is still very obsolete minimum version.=C2=A0 This way, we're no=
t
> depending on some very subtle ABI mechanics to try and keep the stack
> properly aligned.
>=20
> ~Andrew



From xen-devel-bounces@lists.xenproject.org Wed Feb 16 09:25:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 09:25:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273831.469109 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKGYs-0002RB-JE; Wed, 16 Feb 2022 09:25:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273831.469109; Wed, 16 Feb 2022 09:25:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKGYs-0002R4-FE; Wed, 16 Feb 2022 09:25:22 +0000
Received: by outflank-mailman (input) for mailman id 273831;
 Wed, 16 Feb 2022 09:25:21 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=bXi8=S7=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1nKGYr-0002Qy-9P
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 09:25:21 +0000
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur02on061f.outbound.protection.outlook.com
 [2a01:111:f400:fe05::61f])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5bad6778-8f0a-11ec-b215-9bbe72dcb22c;
 Wed, 16 Feb 2022 10:25:19 +0100 (CET)
Received: from DU2PR04CA0087.eurprd04.prod.outlook.com (2603:10a6:10:232::32)
 by DB9PR08MB7115.eurprd08.prod.outlook.com (2603:10a6:10:2c8::5) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.15; Wed, 16 Feb
 2022 09:25:16 +0000
Received: from DB5EUR03FT029.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:232:cafe::65) by DU2PR04CA0087.outlook.office365.com
 (2603:10a6:10:232::32) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.16 via Frontend
 Transport; Wed, 16 Feb 2022 09:25:16 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT029.mail.protection.outlook.com (10.152.20.131) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4975.11 via Frontend Transport; Wed, 16 Feb 2022 09:25:16 +0000
Received: ("Tessian outbound 1f399c739551:v113");
 Wed, 16 Feb 2022 09:25:16 +0000
Received: from a015a75e0a35.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 4CE8AF34-3DB5-492C-A371-7600F14D041A.1; 
 Wed, 16 Feb 2022 09:25:09 +0000
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a015a75e0a35.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 16 Feb 2022 09:25:09 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by AM6PR08MB5240.eurprd08.prod.outlook.com (2603:10a6:20b:ec::28)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.14; Wed, 16 Feb
 2022 09:25:07 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::aca7:79c4:fa65:dac6]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::aca7:79c4:fa65:dac6%5]) with mapi id 15.20.4995.014; Wed, 16 Feb 2022
 09:25:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5bad6778-8f0a-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ERvVUvPQYrt93/XLk61uDEFALhwDIgk3XgZP011Jyg0=;
 b=PnQSdPg+1TOWC8dBTZaSMbVJXZ7B4el/G6FAGbes1VYXD9/uPiOc0vH6NgHisMD/IoD/gI98UZQlLIiZkO0p2QNkmazen0Jw3eXIXL5Jz3R2zly2Xybm92ntm8iXnz9Zu8I90bgVWnMtoXdmDesGMcVG348i2vaCsMpc6gemL9w=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: a65327a62a2ce8a6
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=iMn3EojuW8uCH99oY/OIY0SKPYE5hTXyaZLzoVwHida1iWPUIwlI+T1nlLSYoZ015rBdUlV98Py8hAgwgThzU6H7peta4LOYZp3xxXAVuLzYddyuZyWTaeyAl70npnLySuwudwZMbQSdeLhK26BdzurY4jP2lHJr9eQ2O0IVk22sSsVqCKJQxGnLZxQqmITrY5P0ZbGknKo4xPz0atkCENCr04IL2w7iRXH3a8KIaZfNvFooPqtV2500hhwv0uY3HFkfHl7wr/4nCCGAAFzIJkYB/gGSSGCI5/n438GlrsEjmdqBRXfUC3ihpoLfvPAi12Om9ypa0YyFrZ+d611lqQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ERvVUvPQYrt93/XLk61uDEFALhwDIgk3XgZP011Jyg0=;
 b=WbJxZ3ME2ZzE2CXQh3hgWo+Gv5WDlcBQ3T9x6hf8/MDtfo2pB0GAUxEQ9/IyoS9FcC0GpVHqtf8q8rhK3BxGYqbXzaB2uznF0Mv/hVXFR29anBdJS0X5bHwCTflHWXR/vcerBV0J1S1GUvqrCerlkRmkbHdKaqIg528U2Q9NrYdNOIg7zN1QvdHqBiLVfeXJ2s/qKHgpS/rGZoToJWPMPvQ71qIHOTrtSL0msk1nC7AvBQFsrhqvrkFmeHKcGfkv9jFHeZmPiXMqKlLcKqo3PPC6uXxmfgDJZ1mLS7//mvN9Sg7Qdw2EQQwsFcwAbyNKOyt/GjdZ+DThfs5y4Sm9yA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ERvVUvPQYrt93/XLk61uDEFALhwDIgk3XgZP011Jyg0=;
 b=PnQSdPg+1TOWC8dBTZaSMbVJXZ7B4el/G6FAGbes1VYXD9/uPiOc0vH6NgHisMD/IoD/gI98UZQlLIiZkO0p2QNkmazen0Jw3eXIXL5Jz3R2zly2Xybm92ntm8iXnz9Zu8I90bgVWnMtoXdmDesGMcVG348i2vaCsMpc6gemL9w=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Julien Grall <julien@xen.org>
CC: Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
	=?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
Subject: Re: [PATCH v2] lib: extend ASSERT()
Thread-Topic: [PATCH v2] lib: extend ASSERT()
Thread-Index: AQHYE4sUwaOwwc8tCU249z99fRIDqqyVNw0AgADQBoA=
Date: Wed, 16 Feb 2022 09:25:07 +0000
Message-ID: <3F58400B-5151-42F2-8F39-109DDF50EE1E@arm.com>
References: <75125344-b0e1-9663-4c1a-84bb35870fef@suse.com>
 <35d82770-66cf-e030-5bcc-3c030e4463d7@xen.org>
In-Reply-To: <35d82770-66cf-e030-5bcc-3c030e4463d7@xen.org>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3693.60.0.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: aa437432-4161-4266-651c-08d9f12e3dfe
x-ms-traffictypediagnostic:
	AM6PR08MB5240:EE_|DB5EUR03FT029:EE_|DB9PR08MB7115:EE_
X-Microsoft-Antispam-PRVS:
	<DB9PR08MB7115F6ACD4AFAF22A0AE9CD29D359@DB9PR08MB7115.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 TP+lNWot5ZJTyVuDq+aNL1smdPwITR5WC1DBQEEObXY0GtIfPurpDbAF/7f+V8ygG3pW7RgMbEMiL1ib2P/0UHE1aAjM8XfVvre0qxXJsNFI/VvSbLJiyJU14oJZOcP/COCeKa+5yHTTjbxcgPuwM03Q/N8HNjBtpMuxwQ7iuITmOzZFnfZHSmPL3e9kOS/8YU8qssN5UH1db16Dyet0U4Rt/wkobJ172+UTWZk6WkTDhrF7Dg3cv52gJs33faDuPqT15zVfmb5IzdeYF0Mbr19D2z6KMW6BQ9Lh3xLfFZiAjHU7NZiOde4MmmYIk4s5MOTGdqQXX6QZKbK/F/LkST7GNWPcs3xrZeOnw506MrL9GMLIK2OaFlJXr/8m7IWJyMU+COdh1IkQZqSh3SvqvtmnQaBQfNTU+fqGN8q5ZP/FBUQ6bCjcXDkXRsSwg/wCWxqNAFWqCPkkWWdO03KXqpqoCubodpUl6hkwo189fBGTnOC9jhPNg/fdyzss/w1fTdeo4sYbVkLQgCGDl2FjVVtIVTD9A89Hs6Ijfj3foa/J/yekUvcn3Q0GWncEOkNz2gZkGPXZQyu/RyBaJ6kONRq+vgDCE90blK02kP1AA7UTrq6sjtspwc+/nRFnblM6knggBBbn76yNecLS0dHGM73q5kyZrDpIW6XQ9JjpGXggkjaDKfWAhvjtX8rxmhuhtTXPsEeAcm/r5z8ep4PKWrgw1iDN+Kvd4qT4otVOzIebVzLjJ2eGOwa1wW7GKo68
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6486002)(6506007)(66446008)(4326008)(8936002)(76116006)(53546011)(6512007)(26005)(2616005)(83380400001)(186003)(2906002)(508600001)(71200400001)(91956017)(38100700002)(66946007)(66556008)(54906003)(6916009)(33656002)(122000001)(38070700005)(8676002)(66476007)(86362001)(64756008)(316002)(36756003)(5660300002)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <8D5AE8AA7A8A7B46BEED08BCE5324284@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB5240
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT029.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	d34d5492-80ad-4403-6572-08d9f12e38b1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	u+B47gOEDbTZ1E08XwMDK0Redpu/sQrxLLqwBtfRPOl0/X57h/49145YjgtLtn/4ZJijfnJUu3iXzcNtRWPgYRff0H7qbUgVg9DZZ2siB21WIh8gcMu0l752A+wC0XOMS1BgZwNNPKEtsEJE0TxfC6VshPwij0qfsemH/9jQ8eJDYveRwX5MBKS1fvxmOk6jCqa4ec40Plf4DLnxP2vXPFKRnYwsjY3RL5plTqRo0hxAL4mEEs1GJRBuhdYNWCY8H3/DO2TvZ8+i7Bd+/8wUMBnrFMhpSF5ouvNzD+oUgQ2DuH9jiDkd8an10bq6AI9VWMkrewa6LI1xnLG84081h2/c0fT4fIt26yD+Zg6K5YDp7tQNsQ+APZOlU9EL62oCVfYA8OkLs05LVpnOWrpL7pNcl+OyrHYE1bLNLgn+OWjwEXLF09RyJh1geDkF9aJXUnbB1DydaG8faMJJT3A+0UOQRTk57dlQtOdbrXWX5l8um4k8FJAPP168dLvKgz3XBXs3o7+lf1zr83jZ0CCBsEbjiSsvXevO/MYjuZcBl/madahwq3aHh5QD2PmlDAJKLGhd6ztKg0Mrd2sj/tx+NzGolSOSBfna4P7PS2jeNjm2pG1ALCXjW4CNp2atKCcHr/hDVs3Ukpo2443RkPmbwEuAi3qvLESIc5a3d46JrthhzdX2qS9Jm0pllcguj4HV
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(36756003)(6862004)(2616005)(316002)(356005)(81166007)(6486002)(107886003)(4326008)(26005)(70206006)(70586007)(186003)(336012)(33656002)(2906002)(86362001)(53546011)(8676002)(6512007)(54906003)(36860700001)(40460700003)(508600001)(82310400004)(8936002)(83380400001)(6506007)(5660300002)(47076005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2022 09:25:16.0507
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: aa437432-4161-4266-651c-08d9f12e3dfe
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT029.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7115

SGkgSmFuLCBKdWxpZW4sDQoNCj4gT24gMTUgRmViIDIwMjIsIGF0IDIxOjAwLCBKdWxpZW4gR3Jh
bGwgPGp1bGllbkB4ZW4ub3JnPiB3cm90ZToNCj4gDQo+ICgrIEJlcnRyYW5kKQ0KPiANCj4gSGkg
SmFuLA0KPiANCj4gT24gMjcvMDEvMjAyMiAxNDozNCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+PiBU
aGUgaW5jcmVhc2luZyBhbW91bnQgb2YgY29uc3RydWN0cyBhbG9uZyB0aGUgbGluZXMgb2YNCj4+
ICAgICBpZiAoICFjb25kaXRpb24gKQ0KPj4gICAgIHsNCj4+ICAgICAgICAgQVNTRVJUX1VOUkVB
Q0hBQkxFKCk7DQo+PiAgICAgICAgIHJldHVybjsNCj4+ICAgICB9DQo+PiBpcyBub3Qgb25seSBs
b25nZXIgdGhhbiBuZWNlc3NhcnksIGJ1dCBhbHNvIGRvZXNuJ3QgcHJvZHVjZSBpbmNpZGVudA0K
Pj4gc3BlY2lmaWMgY29uc29sZSBvdXRwdXQgKGV4Y2VwdCBmb3IgZmlsZSBuYW1lIGFuZCBsaW5l
IG51bWJlcikuDQo+IA0KPiBTbyBJIGFncmVlIHRoYXQgdGhpcyBjb25zdHJ1Y3Qgd2lsbCBhbHdh
eXMgcmVzdWx0IHRvIGEgbWluaW11bSA1IGxpbmVzLiBXaGljaCBpcyBub3QgbmljZS4gQnV0IHRo
ZSBwcm9wb3NlZCBjaGFuZ2UgaXMuLi4NCj4gDQo+PiBBbGxvdw0KPj4gdGhlIGludGVuZGVkIGVm
ZmVjdCB0byBiZSBhY2hpZXZlZCB3aXRoIEFTU0VSVCgpLCBieSBnaXZpbmcgaXQgYSBzZWNvbmQN
Cj4+IHBhcmFtZXRlciBhbGxvd2luZyBzcGVjaWZpY2F0aW9uIG9mIHRoZSBhY3Rpb24gdG8gdGFr
ZSBpbiByZWxlYXNlIGJ1aWxkcw0KPj4gaW4gY2FzZSBhbiBhc3NlcnRpb24gd291bGQgaGF2ZSB0
cmlnZ2VyZWQgaW4gYSBkZWJ1ZyBvbmUuIFRoZSBleGFtcGxlDQo+PiBhYm92ZSB0aGVuIGJlY29t
ZXMNCj4+ICAgICBBU1NFUlQoY29uZGl0aW9uLCByZXR1cm4pOw0KPj4gTWFrZSBzdXJlIHRoZSBj
b25kaXRpb24gd2lsbCBjb250aW51ZSB0byBub3QgZ2V0IGV2YWx1YXRlZCB3aGVuIGp1c3QgYQ0K
Pj4gc2luZ2xlIGFyZ3VtZW50IGdldHMgcGFzc2VkIHRvIEFTU0VSVCgpLg0KPj4gU2lnbmVkLW9m
Zi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KPj4gLS0tDQo+PiB2MjogUmVu
YW1lIG5ldyBtYWNybyBwYXJhbWV0ZXIuDQo+PiAtLS0NCj4+IFJGQzogVGhlIHVzZSBvZiBhIGNv
bnRyb2wgZmxvdyBjb25zdHJ1Y3QgYXMgYSBtYWNybyBhcmd1bWVudCBtYXkgYmUNCj4+ICAgICAg
Y29udHJvdmVyc2lhbC4NCj4gDQo+IGluZGVlZCBjb250cm92ZXJzaWFsLiBJIGZpbmQgdGhpcyBx
dWl0ZSBjb25mdXNpbmcgYW5kIG5vdCBzb21ldGhpbmcgSSB3b3VsZCByZXF1ZXN0IGEgdXNlciB0
byBzd2l0Y2ggdG8gaWYgdGhleSB1c2UgdGhlIGxvbmdlciB2ZXJzaW9uLg0KPiANCj4gVGhhdCBz
YWlkLCB0aGlzIGlzIG1haW5seSBhIG1hdHRlciBvZiB0YXN0ZS4gU28gSSBhbSBpbnRlcmVzdGVk
IHRvIGhlYXIgb3RoZXJzIHZpZXcuDQo+IA0KPiBJIGhhdmUgYWxzbyBDQ2VkIEJlcnRyYW5kIHRv
IGhhdmUgYW4gb3BpbmlvbnMgZnJvbSB0aGUgRnVzYSBHcm91cCAoSSBzdXNwZWN0IHRoaXMgd2ls
bCBnbyBiYWNrd2FyZCBmb3IgdGhlbSkuDQoNClRoYW5rcyBhbmQgaGVyZSBpcyBteSBmZWVkYmFj
ayBpbiByZWdhcmRzIHRvIEZ1c2EgaGVyZS4NCg0KTW9zdCBjZXJ0aWZpY2F0aW9uIHN0YW5kYXJk
cyBhcmUgZm9yYmlkZGluZyBjb21wbGV0ZWx5IG1hY3JvcyBpbmNsdWRpbmcNCmNvbmRpdGlvbnMg
KGFuZCBxdWl0ZSBhIG51bWJlciBhcmUgZm9yYmlkZGluZyBzdGF0aWMgaW5saW5lIHdpdGggY29u
ZGl0aW9ucykuDQpUaGUgbWFpbiByZWFzb24gZm9yIHRoYXQgaXMgTUNEQyBjb3ZlcmFnZSAoY29u
ZGl0aW9uL2RlY2lzaW9ucyBhbmQgbm90IG9ubHkNCmNvZGUgbGluZSkgaXMgbm90IHBvc3NpYmxl
IHRvIGRvIGFueW1vcmUgZG93biB0byB0aGUgc291cmNlIGNvZGUgYW5kIGhhcyB0byBiZQ0KZG9u
ZSBkb3duIHRvIHRoZSBwcmUtcHJvY2Vzc2VkIGNvZGUuDQoNCk91dCBvZiBGdXNhIGNvbnNpZGVy
YXRpb25zLCBvbmUgdGhpbmcgSSBkbyBub3QgbGlrZSBpbiB0aGlzIHNvbHV0aW9uIGlzIHRoZSBm
YWN0IHRoYXQNCnlvdSBwdXQgc29tZSBjb2RlIGFzIHBhcmFtZXRlciBvZiB0aGUgbWFjcm8gKHRo
ZSByZXR1cm4pLg0KDQpUbyBtYWtlIHRoaXMgYSBiaXQgYmV0dGVyIHlvdSBjb3VsZCBwdXQgdGhl
IHJldHVybiBjb2RlIGFzIHBhcmFtZXRlcg0KaW5zdGVhZCBvZiBoYXZpbmcg4oCccmV0dXJuIENP
REXigJ0gYXMgcGFyYW1ldGVyLg0KDQpBbiBvdGhlciB0aGluZyBpcyB0aGF0IFhlbiBBU1NFUlQg
YWZ0ZXIgdGhpcyBjaGFuZ2Ugd2lsbCBiZSBxdWl0ZSBkaWZmZXJlbnQgZnJvbQ0KYW55IEFTU0VS
VCBmb3VuZCBpbiBvdGhlciBwcm9qZWN0cyB3aGljaCBjb3VsZCBtYWtlIGl0IG1pc2xlYWRpbmcg
Zm9yIGRldmVsb3BlcnMuDQpNYXliZSB3ZSBjb3VsZCBpbnRyb2R1Y2UgYW4gQVNTRVJUX1JFVFVS
TiBtYWNyb3MgaW5zdGVhZCBvZiBtb2RpZnlpbmcgdGhlDQpiZWhhdmlvdXIgb2YgdGhlIHN0YW5k
YXJkIEFTU0VSVCA/DQoNClJlZ2FyZHMNCkJlcnRyYW5kDQoNCj4gDQo+PiAtLS0gYS94ZW4vY29t
bW9uL21lbW9yeS5jDQo+PiArKysgYi94ZW4vY29tbW9uL21lbW9yeS5jDQo+PiBAQCAtODI2LDEx
ICs4MjYsNyBAQCBpbnQgeGVubWVtX2FkZF90b19waHlzbWFwKHN0cnVjdCBkb21haW4NCj4+ICAg
ICAgdW5pb24gYWRkX3RvX3BoeXNtYXBfZXh0cmEgZXh0cmEgPSB7fTsNCj4+ICAgICAgc3RydWN0
IHBhZ2VfaW5mbyAqcGFnZXNbMTZdOw0KPj4gIC0gICAgaWYgKCAhcGFnaW5nX21vZGVfdHJhbnNs
YXRlKGQpICkNCj4+IC0gICAgew0KPj4gLSAgICAgICAgQVNTRVJUX1VOUkVBQ0hBQkxFKCk7DQo+
PiAtICAgICAgICByZXR1cm4gLUVBQ0NFUzsNCj4+IC0gICAgfQ0KPj4gKyAgICBBU1NFUlQocGFn
aW5nX21vZGVfdHJhbnNsYXRlKGQpLCByZXR1cm4gLUVBQ0NFUyk7DQo+PiAgICAgICAgaWYgKCB4
YXRwLT5zcGFjZSA9PSBYRU5NQVBTUEFDRV9nbWZuX2ZvcmVpZ24gKQ0KPj4gICAgICAgICAgZXh0
cmEuZm9yZWlnbl9kb21pZCA9IERPTUlEX0lOVkFMSUQ7DQo+PiBAQCAtOTIwLDExICs5MTYsNyBA
QCBzdGF0aWMgaW50IHhlbm1lbV9hZGRfdG9fcGh5c21hcF9iYXRjaChzDQo+PiAgICAgICAqIGNh
bGwgZG9lc24ndCBzdWNjdW1iIHRvIGRlYWQtY29kZS1lbGltaW5hdGlvbi4gRHVwbGljYXRlIHRo
ZSBzaG9ydC1jaXJjdXQNCj4+ICAgICAgICogZnJvbSB4YXRwX3Blcm1pc3Npb25fY2hlY2soKSB0
byB0cnkgYW5kIGhlbHAgdGhlIGNvbXBpbGVyIG91dC4NCj4+ICAgICAgICovDQo+PiAtICAgIGlm
ICggIXBhZ2luZ19tb2RlX3RyYW5zbGF0ZShkKSApDQo+PiAtICAgIHsNCj4+IC0gICAgICAgIEFT
U0VSVF9VTlJFQUNIQUJMRSgpOw0KPj4gLSAgICAgICAgcmV0dXJuIC1FQUNDRVM7DQo+PiAtICAg
IH0NCj4+ICsgICAgQVNTRVJUKHBhZ2luZ19tb2RlX3RyYW5zbGF0ZShkKSwgcmV0dXJuIC1FQUND
RVMpOw0KPj4gICAgICAgIGlmICggdW5saWtlbHkoeGF0cGItPnNpemUgPCBleHRlbnQpICkNCj4+
ICAgICAgICAgIHJldHVybiAtRUlMU0VROw0KPj4gLS0tIGEveGVuL2luY2x1ZGUveGVuL2xpYi5o
DQo+PiArKysgYi94ZW4vaW5jbHVkZS94ZW4vbGliLmgNCj4+IEBAIC00OSwxMSArNDksMTMgQEAN
Cj4+ICAjZW5kaWYNCj4+ICAgICNpZm5kZWYgTkRFQlVHDQo+PiAtI2RlZmluZSBBU1NFUlQocCkg
XA0KPj4gKyNkZWZpbmUgQVNTRVJUKHAsIC4uLikgXA0KPj4gICAgICBkbyB7IGlmICggdW5saWtl
bHkoIShwKSkgKSBhc3NlcnRfZmFpbGVkKCNwKTsgfSB3aGlsZSAoMCkNCj4+ICAjZGVmaW5lIEFT
U0VSVF9VTlJFQUNIQUJMRSgpIGFzc2VydF9mYWlsZWQoInVucmVhY2hhYmxlIikNCj4+ICAjZWxz
ZQ0KPj4gLSNkZWZpbmUgQVNTRVJUKHApIGRvIHsgaWYgKCAwICYmIChwKSApIHt9IH0gd2hpbGUg
KDApDQo+PiArI2RlZmluZSBBU1NFUlQocCwgZmFpbHNhZmUuLi4pIGRvIHsgXA0KPj4gKyAgICAg
ICAgaWYgKCAhY291bnRfYXJncyhmYWlsc2FmZSkgfHwgdW5saWtlbHkoIShwKSkgKSB7IGZhaWxz
YWZlOyB9IFwNCj4+ICsgICAgfSB3aGlsZSAoIDAgKQ0KPj4gICNkZWZpbmUgQVNTRVJUX1VOUkVB
Q0hBQkxFKCkgZG8geyB9IHdoaWxlICgwKQ0KPj4gICNlbmRpZg0KPj4gIA0KPiANCj4gQ2hlZXJz
LA0KPiANCj4gLS0gDQo+IEp1bGllbiBHcmFsbA0KDQo=


From xen-devel-bounces@lists.xenproject.org Wed Feb 16 09:29:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 09:29:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273842.469127 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKGck-0003CV-JU; Wed, 16 Feb 2022 09:29:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273842.469127; Wed, 16 Feb 2022 09:29:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKGck-0003BI-CH; Wed, 16 Feb 2022 09:29:22 +0000
Received: by outflank-mailman (input) for mailman id 273842;
 Wed, 16 Feb 2022 09:29:21 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Gpsw=S7=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nKGcj-00038P-1F
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 09:29:21 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id eb1a2968-8f0a-11ec-8eb8-a37418f5ba1a;
 Wed, 16 Feb 2022 10:29:20 +0100 (CET)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2111.outbound.protection.outlook.com [104.47.17.111]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-38-4XpOG8NeP-yAcCu576ItGQ-1; Wed, 16 Feb 2022 10:29:18 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5277.eurprd04.prod.outlook.com (2603:10a6:803:51::32)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Wed, 16 Feb
 2022 09:29:17 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4995.016; Wed, 16 Feb 2022
 09:29:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: eb1a2968-8f0a-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645003759;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=p6Wp2ZGTPRZ7LKzifeymUV1Swd8F9/C7R4S7V8z3kt4=;
	b=RJnbxqMtgS4Yfb/JmBcR6a1inyj8pPMAqss/BA8d0eID7Nczzc9FyF/JxcSs5osw4C+kB1
	M39TPLGdVsmDd1yTT8GYME7FnUrl9OadUQTW3k530qa4uG9F6NmzmKg8rqeHT98/pivr8l
	8ZAdvLIdkZYTkqDZxIzrQSIl3g7ZV1k=
X-MC-Unique: 4XpOG8NeP-yAcCu576ItGQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=AMc/FFQSG4Qmg/DWf0pRCFDm8+dX6VbkyFZTl9BNIfGCFanhiAlbzX18pvvgptVCoDPImCUmekvvPE6XvMczSwfrgUWXQkaqPOOdfUjY8GZP/UHCXJhESRteqn9lN/6CEXUkNM1BZDhwp2hR7aInWNsj/hf3K03qXyX80sduoI7Ct0HN7LEjPkKS3dJRdVf+J7sTdq7hvVU1AEHcI5aATkBR8vuExXrGEafpt6lEtKHIRo1wF1s/LEZxbyYMXaPbcXAqkFBUTjLBzXr7ZVRDV7AyC7681RGTDiaXOAlAnNztAnGm2qnyErOB8pG85+Ar9U92pf5p5wW/A3uHHh5HHg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=p6Wp2ZGTPRZ7LKzifeymUV1Swd8F9/C7R4S7V8z3kt4=;
 b=cMDK71B//VIkmAXizoZHt2Bb0fjAb5YnEsFQz5ls1Zqh/+vYGIOLm/hGKv0hl/HQt/KHO2gs5IQ1aXjnrVAvrfI4uGDiNsA5qSdEycV8VJX+CIq1c7NSTSLr189T0dq/rkZwmpqZuqMGhXdmTlIRXQFO1pFq4jm3CqfpXTxaSpD7KuT43P86HbufYKVNDXjZyYGsNiK4a/vlAU72aeu5PAqlEjW0VqAjPBD+V1AM976YGZ9Vo7OoWt1JxqZBQzzIwlseDLH+uS5V35nuoEw6VmyZM+UtXInuW0TbmhAdmPDEER5FL+a8gAOwx1mbM8wxJKV0n4IIenSiFp61ZiJSOw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <7ca05a74-6b65-f9cb-f524-28d700a7d0e4@suse.com>
Date: Wed, 16 Feb 2022 10:29:14 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH v2 2/2] xen/include/public: deprecate GNTTABOP_transfer
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>, Julien Grall <julien@xen.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220203131418.1319-1-jgross@suse.com>
 <20220203131418.1319-2-jgross@suse.com>
 <a35bb9ba-e2be-f73e-9272-906bc09d9b6e@xen.org>
 <93e50bc4-6e53-b753-c520-7d1d0a5a5f5a@suse.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <93e50bc4-6e53-b753-c520-7d1d0a5a5f5a@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR04CA0011.eurprd04.prod.outlook.com
 (2603:10a6:206:1::24) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 0292db69-79e1-467c-2606-08d9f12ecd81
X-MS-TrafficTypeDiagnostic: VI1PR04MB5277:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB5277B65853E1237F8A808E8BB3359@VI1PR04MB5277.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	9t0Niamq/12Q1ypLMARbSpfpxxmwOwy8jK+/B7BgZvGTMzKWZdlMXRdWO6wICNPHWfi+vn70YbHCTHkUJZWaPp4WMFo080/eV1bg+oHTtEe59hEEuP/nhlg/epkrjywzbp8w70SRYTJd/MjFQ/v9eqS6P9vpEgyc2hirxEnT0YgjcA9/DRK1AnZOKKJzsY+Apt9VMdoY+tSdNd2Akt+Iy4EiDPJr3kSxoOJulKLnMU7vDzmFFmQ/bMxN97sWVLaBsVJWdYpeWoEGlaXmIOYAXQBy7RrjVllqAPi7o6KYFIRhxOE9pvvmbeQavZB9z7Gqw/wUBzDOBFfVfzyAXcRyOych+5M5zeFZZWyzmekhLseLV5UN47e2AeVcmlzkTKd0mNiyufW/bsqI25khzVAelkls+gbUsrpL0zxUlK8Ndds3Yw9l9YOTMCni/+a4Eq4BSXC/HjDVVnjzklPY7Zmu2NIZDR3idgh/aPzPgp8CKu1LdxOpzbHJqRUrAIUKXYUk5xWKefs3YKIFXxG9h+fdfzEKGgF/520ynbvSEs2PWfmiX6/JDsCJXv+4HWoRR5ELEOgVjaIAncOGbURMxDYTNjKe5HEK3Qv6etxndSamA/I4ZVMxkYs7bJ6BhNaHQnjQeONujFhAkre8sfoPa1VEStVpOCBlOpAbRDMFqCsfZbq58KmiqwHIG75gPT6HxLhYobGc3mUS21gZed9CC+jjhtofTbqLInb2jS6I4B+l1jlokCf+1TwZsum2/xqZpaUH
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6506007)(31686004)(2906002)(53546011)(38100700002)(36756003)(316002)(5660300002)(83380400001)(8936002)(4744005)(66556008)(54906003)(6666004)(110136005)(86362001)(508600001)(66476007)(26005)(66946007)(8676002)(2616005)(6486002)(31696002)(6512007)(186003)(4326008)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UW9IdEJkWXZwUnhQQnY1aWZqQWFYQ0d3M1Q4cmM2UjB0WjduUHRseXBDT1lh?=
 =?utf-8?B?clE2YzQ5TDFXcC83bnpqKzlUUnBwUTh2anRhcUYveGlzU0dMM2xzbTRDOFZs?=
 =?utf-8?B?OVVTWnVxdlFEcEpSWVlLVng4WDhZRXJlL2RRUTk0MnZqdlVuVG5UN0hVMjIw?=
 =?utf-8?B?amExMDFaeGpMNG9BTzZtRGcrM2N5Z2hZQTE5U2NxQXFqMFpLN1lHdlg0NW9S?=
 =?utf-8?B?SGFmaW41Q0hCUE93RTJ4aEZaSDlTSWp1Z0J1bEZXRmd2Z1d2R2VyZjlzQkEr?=
 =?utf-8?B?R2lUdDM5Sk9VMXpVeUFaNXBJY2o0MTNxOG95U2IyQ245elhQVGpFTWNpSGRt?=
 =?utf-8?B?cVZvZi83bjY5MVBzc2Uya3JTUTh3QWtTSVRLMjhxS2ZwRWwxVk53Nm0wSG1T?=
 =?utf-8?B?c1RIMGNlblpLWHNONmM2bHhReHFpVFJZODRKV3lrc010aGNGMFV5WEd2amZL?=
 =?utf-8?B?VHpnYnpsQjNVdG9ubFZRK0dmTGhOWEFLRElLbEVMbXlEOVB3MDhyUTZPd25O?=
 =?utf-8?B?MFpZTWFSZXlVSHhsbWE0dHZmZmpnM1VtYXY2akFUSGIwSUJwejBHdWxGZjRB?=
 =?utf-8?B?eXdjZ1dOWk9obVNTRzNZQ2pUcndYNjJGZ2pid1ZrR3dENFVzRTVWTkRNNzhB?=
 =?utf-8?B?VVE5QjRwMUFjZUxjUG53NzQ2YW9hUWllUkI5cGpwSlU0NlR1RzF2Q0JLTjBr?=
 =?utf-8?B?LytPYVdsOXZnMm45YmdmV3VXR2ljeVZqa1ZwWDR3UlpnRGtuVTl4WmFsejVF?=
 =?utf-8?B?Um9PSVZDdXVOQzVLUHhhdjRWb2xvTXMzSE1CNWk4WEwwLzZ3NEozRElPcERJ?=
 =?utf-8?B?TXRZVDU4S1VXbjRJWSs4dktKRVVBRHFPQ2lqcUpyeDdNYkF6ZEZxVlh3MFNF?=
 =?utf-8?B?cUtSUGJPUFA2R3M2d0FFc0dzOTJPT2RnWFlLK3hxbVhOMUsyQ29VRU1RZ1hY?=
 =?utf-8?B?Rk93aFhGSmlSTE5WYml2UmR3ajMvNkJBajdjMW1OcVB0Z2pkMVNvcWd4L2cv?=
 =?utf-8?B?d3o0Z0xjNW1jZkZ4blQ0cTNwQ0RBOGpKRlZXUTlOMlNzbE4vZ3B1dkZWR20y?=
 =?utf-8?B?Skl3QkVxN29NckdGc1VpVnp2WUh5bVNhcGlIZHl1SGJ1akhDZjBwaVgvZXk1?=
 =?utf-8?B?NjIxQ1I1UzVSZVpGb3BtbGZuU1R4bk91SFM5bXUzcDh2SEs3YWJHQkZPMWtU?=
 =?utf-8?B?Z2FzbkRsL1JJeFRZd1I0Yll0VzRNWlNnZ0dWSHpqUXdUOXhza2wvWFRoWUd2?=
 =?utf-8?B?dVlKZGZ1aXhyL2JxY3lNN3hVVGFuUEtxaHpySkhOYmV5ZXRRQ2Q5UE1KRHpV?=
 =?utf-8?B?dS9DTXdzM0ZnWlUybVJQeWozaVJRbE1Ud05SZ25WV2JwTGNzZFU2TXBZQzEy?=
 =?utf-8?B?c2xWcDZZOWpvd1ZaK2MzZThRZ2lPVU1rMUlxZjVodCtqemxIakQvNDRqTkVm?=
 =?utf-8?B?dzA0QUpaMVJRSkdQSU9JQk9kT04ydEFXcU16OXZkbEdNWm1zVHhMR0MxTEYy?=
 =?utf-8?B?MXRuamo2Qk5TTnhONG0vZnR6UFRwNm40R25tNEd5bXNJNDZseU1SNFJVRXhI?=
 =?utf-8?B?dld0ZDRxUXd0c216QnNFc29jNXhlTFNMVG1XYW1MU1lmT1dPWDh3ckNZUWlj?=
 =?utf-8?B?aHlZRWNOZlN0MEdIbmN2VGVXM3l4SGlGZWxZT0Z3UCtVNXM2NUFQc24vUU1K?=
 =?utf-8?B?ZzdmQXZmYm5TOWlHeWhsMVRhSEZSZ3VMUURQOEtHSk5HbFBKWElNUTVEbjUy?=
 =?utf-8?B?R2dibWV1U2xQRzJoYWY0a1hxdHVvc1VTN1VhZG5CcG1YQ0dSOXZMYTZhM0JX?=
 =?utf-8?B?MHhHUHhWZ3UrNTVXWVpjRXhGQ1BaN05aSWF5dDdnZU1wemxMdWhjNVcvNEE2?=
 =?utf-8?B?bDdmbFFrTlpIRVV2UG0xb1JYSkVPOVBkcXg4a3Bzd2lkM00wbkpWWXBXL2RI?=
 =?utf-8?B?amFTaTN6bERKeTFWOExVdEJIM0NxR21NVC9LR0t6dDlvbEVpR1lXWFAyRWs0?=
 =?utf-8?B?NWJ0bGpQVG52QlI2YXBIK2Q5YlBJM1ova0txQkxZTE9GSWZkWjR2d3RPS0xr?=
 =?utf-8?B?OFVxYmJoWittZmk1SVd4bmRGVE1kTzNKQlM2eFdxeGdnMnlxcG5aK0lmNUd6?=
 =?utf-8?B?cVlJK0c4M3J0TkpsOHlySXJ2UGVXejFVbGJwMkVMaHdGbDlmNXpXeHl2eUFy?=
 =?utf-8?Q?8D/W9J8OlH2dvl2mAMAk5gE=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0292db69-79e1-467c-2606-08d9f12ecd81
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2022 09:29:16.9468
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MxvvpHZ7wDKCFUcY5JkLdk5nOnM5TeSs8zHDbhmDRLrpzrxz8Rh0YT6h6T9UhjAEp/rirrc6b7ELnzJMFaoPkQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5277

On 16.02.2022 08:20, Juergen Gross wrote:
> On 15.02.22 22:13, Julien Grall wrote:
>> As a side note, should we also update SUPPORT.md?
> 
> Good question.

I'm not sure here either - talking about individual hypercall sub-ops
seems overly small granularity to me for this kind of doc. Plus I
don't view deprecation and de-supporting as the same thing. The latter
would mean to render unsupported any old XenoLinux which may still be
in use, all of the sudden.

What would want gaining an entry in any event imo is CHANGELOG.md.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Feb 16 09:29:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 09:29:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273841.469120 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKGck-00038c-6h; Wed, 16 Feb 2022 09:29:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273841.469120; Wed, 16 Feb 2022 09:29:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKGck-00038V-3E; Wed, 16 Feb 2022 09:29:22 +0000
Received: by outflank-mailman (input) for mailman id 273841;
 Wed, 16 Feb 2022 09:29:20 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=bXi8=S7=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1nKGci-00038J-5r
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 09:29:20 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04on0624.outbound.protection.outlook.com
 [2a01:111:f400:fe0c::624])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id eae009f2-8f0a-11ec-b215-9bbe72dcb22c;
 Wed, 16 Feb 2022 10:29:19 +0100 (CET)
Received: from AM5PR0601CA0038.eurprd06.prod.outlook.com
 (2603:10a6:203:68::24) by AM6PR08MB3991.eurprd08.prod.outlook.com
 (2603:10a6:20b:a8::30) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.15; Wed, 16 Feb
 2022 09:29:16 +0000
Received: from AM5EUR03FT058.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:203:68:cafe::6d) by AM5PR0601CA0038.outlook.office365.com
 (2603:10a6:203:68::24) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.15 via Frontend
 Transport; Wed, 16 Feb 2022 09:29:16 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT058.mail.protection.outlook.com (10.152.17.48) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4975.11 via Frontend Transport; Wed, 16 Feb 2022 09:29:14 +0000
Received: ("Tessian outbound 341d209a0e52:v113");
 Wed, 16 Feb 2022 09:29:14 +0000
Received: from 47de483b1682.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 E9F54DA6-1FEA-4409-8D0E-7C64C5B76903.1; 
 Wed, 16 Feb 2022 09:29:08 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 47de483b1682.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 16 Feb 2022 09:29:08 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by AM4PR08MB2754.eurprd08.prod.outlook.com (2603:10a6:205:e::28) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.18; Wed, 16 Feb
 2022 09:29:05 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::aca7:79c4:fa65:dac6]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::aca7:79c4:fa65:dac6%5]) with mapi id 15.20.4995.014; Wed, 16 Feb 2022
 09:29:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: eae009f2-8f0a-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=/83OOk9cZSV+Xozs8gMrc20TUYybIpGLhJIs50cxDIo=;
 b=17xQ3RhQ4iGyvqXweJXAm4PIM0zhFtIbaApDpSdErQq9ncMl5gpCDTB4TyH1bKpt1bOR0W6Fp/OGr7zHdvs5krVpz/oIL1ZG7z5BQUeSnvSM6UrfBnQTngdOaWEJrJUVCrnfKedyMo6dveKcLjNaM/UNiTQ2/0oHhDkBKDlIhGA=
X-MS-Exchange-Authentication-Results: spf=temperror (sender IP is
 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=temperror action=none
 header.from=arm.com;
Received-SPF: TempError (protection.outlook.com: error in processing during
 lookup of arm.com: DNS Timeout)
X-CheckRecipientChecked: true
X-CR-MTA-CID: f9cab02b8da4d342
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=VBLWlYC7qJ7pDIo0a63aXt5oxvusQP20tQtlZS1KkP6DWh9rRPFvj4FtcOqrm9Ki4gyntIcYWMhnclkSW2J1C2VPxPcWfA+fgGWy29LiCIkGP9GImBl+QGGAX0kHEek+cpENGCHUUY+K4Cn8PsOyN4036reebIioZdjHrWYwfuMl0X7bvqI6gkV1bhxUAuS99SwRLb7WzIxmiJZVLUwspCUGikovB/8TeoOuh8ayPORlYk5GJ2DRHdEhxHa6Qd3YulgW9pTrFg+FBMDotG9Q28DjmObUol87uCEe6C0N/LRmWJPS1LAekS9zmK6a9DJvNppyWdzzIPumeKd9qreLXw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=/83OOk9cZSV+Xozs8gMrc20TUYybIpGLhJIs50cxDIo=;
 b=doVqEuFHFrs9Y1p0lHqeO8avYf9MSiAEDXrrxyTZYuOH2yRak2tt2w57zJcpqzZ3EoFz93w0a+On9y9IbPBuua5CgDmuiXnJyjvK7mbvkBNEWjeSsjkgZKqTRbZF/MbFApJSIGjE1q4IIgMD1kvdLfLvAjUqVdAIWyA0W4NMdmD/wmAMplTJ9nl7wcDWtC3NJ3Ubho6jr5w42HO1RSJp2IYyHHM3RTpkXVRdX9Zmz8zgIqwyi/8cEDPDdPBp7mEHI8X6vOfnpMb3CJeX2pWvbn+Kxh4UvMZTVW/Sqi21KE6MQUygsZeqcMGhquG1J+RpWf5UuOVXNfbmI3JZiMpFPA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=/83OOk9cZSV+Xozs8gMrc20TUYybIpGLhJIs50cxDIo=;
 b=17xQ3RhQ4iGyvqXweJXAm4PIM0zhFtIbaApDpSdErQq9ncMl5gpCDTB4TyH1bKpt1bOR0W6Fp/OGr7zHdvs5krVpz/oIL1ZG7z5BQUeSnvSM6UrfBnQTngdOaWEJrJUVCrnfKedyMo6dveKcLjNaM/UNiTQ2/0oHhDkBKDlIhGA=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: Julien Grall <julien@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>,
	Xen-devel <xen-devel@lists.xenproject.org>, Jan Beulich <JBeulich@suse.com>,
	=?iso-8859-1?Q?Roger_Pau_Monn=E9?= <roger.pau@citrix.com>, Wei Liu
	<wl@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v2 02/70] xen/sort: Switch to an extern inline
 implementation
Thread-Topic: [PATCH v2 02/70] xen/sort: Switch to an extern inline
 implementation
Thread-Index: AQHYIaGnBAePJgt7y0O7PyvIWQlKrKyTBxsAgAKFHwCAAF/KgA==
Date: Wed, 16 Feb 2022 09:29:05 +0000
Message-ID: <24099D77-07E6-4110-B988-309C917D89F1@arm.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
 <20220214125127.17985-3-andrew.cooper3@citrix.com>
 <70824a0c-cc48-b064-695c-35c2d06c0ad1@xen.org>
 <alpine.DEB.2.22.394.2202151800230.43738@ubuntu-linux-20-04-desktop>
In-Reply-To:
 <alpine.DEB.2.22.394.2202151800230.43738@ubuntu-linux-20-04-desktop>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3693.60.0.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 8076549e-bf8b-41d8-c791-08d9f12ecc5a
x-ms-traffictypediagnostic:
	AM4PR08MB2754:EE_|AM5EUR03FT058:EE_|AM6PR08MB3991:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR08MB3991B77005CE8807357736789D359@AM6PR08MB3991.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 80LNKtPtz2GI5DD4QEX+q7f0OOeynJkj2LLG1mNcRv0PlW4e84E6kAvdm8pQcXrSC8KV72fL56eMsS1ER1ggEdLg20zjVhWVqwdkD5NvApijJAik5dgc9ULr14I1JBcQ+9pgbrVkVzq9n4I2HZwONPODUoNt3Ntn5rNFONCOg8mbfSQLYsT6P0gsj6h861LNgOvbFENN6jcfpcALqziXnSvQnqlXzlSdu8L/oXOm4CuLTmtM5I6K8pai1bZhfbKylb5WUvnWjfgXi2cdKy/Pfya6ClTz2jWd7WDB4kjJkaLM+3bYn3/VGQH95u6XkG1dad3NnVVZkHB4Mmh9kfA15zjy8VrYUo69N+CQQmu70oUpVh1KIB/bhVMNeDeT4Z1+Dqn4u4EADWQdAF7OSGjlEwOFHjeWNUnWAOW879eRgEIiBDtSqqb+r6rBnzbU+2t0Ht9EV+71MTr4piA4nUp2UdUg9xbRauSOAunj/tYuvoB+MwYqfJ2Rm/zmM/QZDcivn7EIxnf1BrBTr6M7PXv6SuzFTtjESnWHuYNNkciiE+aCLjBZ2yV1HwqnfitZ2KRBkizwl9PCtXWb7SjlX9AI0jCA0SeJ8cqOeAMHfulA5C8kX72bmXG1JIAIdFa2KF6MYhejLsi9pO49y+C/NWH888pvQHPZv0iIBdFfSv5sNeJijnmi948lLyRu8zHnOwPRx5bA+tRmpQIGfDDef0efl/e8ZVSpW40j9uhPK6YOLJrRBtGJrt9qak30QgSaRUje
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(508600001)(71200400001)(26005)(6512007)(53546011)(2616005)(91956017)(83380400001)(316002)(6506007)(36756003)(6486002)(64756008)(5660300002)(38070700005)(54906003)(6916009)(186003)(4326008)(38100700002)(122000001)(33656002)(66556008)(66446008)(2906002)(86362001)(66476007)(66946007)(76116006)(8676002)(8936002)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <C2683ED7D01CB54A90517525831830C6@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR08MB2754
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT058.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	b06eb978-76da-4480-b118-08d9f12ec707
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	PH4Ed0DDv+QTohKGiApisrk3J467FC10YdG8vH6jrhtm+jYwO8vSKHytQ5NZKlrcq2USJWYm7s0rXQprmwtwkOvORoddjuWEpnIHLufTCgu++CldfEhLICyDaiPscBuqj5jq2M3PbBMxtu8XkPWHwPg14wlFC0EqIqlpLPF5pLkh0Z0H+BcGedHAG7ajohMrb8345r4j0rQmYs4NOgM1KEHe58xf2ig4SxAdmawrbUTWIaBEg5ip9ua/hhC63/vv6x2cRrzpkj8cpxgVIOr5HQnYt35RY1S5aQW8y9Z1LsbBOsQGKMDb/BGpV0lq7tJLmlzzjTxVb2AAanOKi0PguccdADhFfnBYmcf/v4kxRugc5BU2leGbiwMRfFYjZnSnaeH1JlAgVFr5p7OyG+QrdMW8Z12++gIG8BZcjh7k3r7yiaMvUCsLJpyO9jI7gvG5BOwwZTZlsBm35wgmD4qbjTbbxJtzPUsSeJB0cdu/PwsZV+fTfHMhkO8vSW+pCQzbd7njlZArY/A2+o+Xup0CqnG5ILJBgMLeteEh0/gXl0nk6WyzO5PwVIX15krZBS2/F6OgyI0T+U9LPTC9ohdxCPpxNdAUL9zFf+CAbL6+GyFtIinyT4flZzm0NQ3JTSI0rchKgQixh88wfy1LdPIsBLeHrghSkTxi01aj+Af+dStz14oHFUhPaW49ZzuZM55CwSM1Nslx8srIGBnqqbbvFQ==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(6862004)(2616005)(8676002)(508600001)(4326008)(6512007)(53546011)(8936002)(33656002)(6486002)(36756003)(5660300002)(107886003)(6506007)(2906002)(54906003)(81166007)(316002)(47076005)(63370400001)(336012)(26005)(356005)(83380400001)(40460700003)(70586007)(86362001)(70206006)(63350400001)(82310400004)(36860700001)(186003)(45980500001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2022 09:29:14.8145
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 8076549e-bf8b-41d8-c791-08d9f12ecc5a
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT058.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3991

Hi Stefano,

> On 16 Feb 2022, at 03:46, Stefano Stabellini <sstabellini@kernel.org> wro=
te:
>=20
> On Mon, 14 Feb 2022, Julien Grall wrote:
>> On 14/02/2022 12:50, Andrew Cooper wrote:
>>> There are exactly 3 callers of sort() in the hypervisor.  Callbacks in =
a
>>> tight
>>> loop like this are problematic for performance, especially with Spectre=
 v2
>>> protections, which is why extern inline is used commonly by libraries.
>>>=20
>>> Both ARM callers pass in NULL for the swap function, and while this mig=
ht
>>> seem
>>> like an attractive option at first, it causes generic_swap() to be used=
,
>>> which
>>> forced a byte-wise copy.  Provide real swap functions so the compiler c=
an
>>> optimise properly, which is very important for ARM downstreams where
>>> milliseconds until the system is up matters.
>>=20
>> Did you actually benchmark it? Both those lists will have < 128 elements=
 in
>> them. So I would be extremely surprised if you save more than a few hund=
reds
>> microseconds with this approach.
>>=20
>> So, my opinion on this approach hasn't changed. On v1, we discussed an
>> approach that would suit both Stefano and I. Jan seemed to confirm that =
would
>> also suit x86.
>=20
>=20
> This patch series has become 70 patches and for the sake of helping
> Andrew move forward in the quickest and most painless way possible, I
> append the following using generic_swap as static inline.
>=20
> Julien, Bertrand, is that acceptable to you?

Any reason why we cannot in this case keep the NULL parameter in the
existing code and do the if swap =3D=3D NULL handling in the sort code ?

Other then that this is acceptable for me but I will let Julien say if he i=
s
ok or not as I had no objections before.

Regards
Bertrand

>=20
> Andrew, I know this is not your favorite approach but you have quite a
> lot of changes to handle -- probably not worth focussing on one detail
> which is pretty minor?
>=20
>=20
> ---
> xen/sort: Switch to an extern inline implementation
>=20
> There are exactly 3 callers of sort() in the hypervisor.  Callbacks in a =
tight
> loop like this are problematic for performance, especially with Spectre v=
2
> protections, which is why extern inline is used commonly by libraries.
>=20
> Make generic_swap() a static inline and used it at the two ARM call
> sites.
>=20
> No functional change.
>=20
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
> Reviewed-by: Jan Beulich <jbeulich@suse.com>
> ---
> xen/arch/arm/bootfdt.c |  2 +-
> xen/arch/arm/io.c      |  2 +-
> xen/include/xen/sort.h | 67 ++++++++++++++++++++++++++++++++++-
> xen/lib/sort.c         | 80 ++----------------------------------------
> 4 files changed, 70 insertions(+), 81 deletions(-)
>=20
> diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c
> index afaa0e249b..0d62945d56 100644
> --- a/xen/arch/arm/bootfdt.c
> +++ b/xen/arch/arm/bootfdt.c
> @@ -472,7 +472,7 @@ size_t __init boot_fdt_info(const void *fdt, paddr_t =
paddr)
>      * the banks sorted in ascending order. So sort them through.
>      */
>     sort(bootinfo.mem.bank, bootinfo.mem.nr_banks, sizeof(struct membank)=
,
> -         cmp_memory_node, NULL);
> +         cmp_memory_node, generic_swap);
>=20
>     early_print_info();
>=20
> diff --git a/xen/arch/arm/io.c b/xen/arch/arm/io.c
> index 729287e37c..1f35aaeea6 100644
> --- a/xen/arch/arm/io.c
> +++ b/xen/arch/arm/io.c
> @@ -170,7 +170,7 @@ void register_mmio_handler(struct domain *d,
>=20
>     /* Sort mmio handlers in ascending order based on base address */
>     sort(vmmio->handlers, vmmio->num_entries, sizeof(struct mmio_handler)=
,
> -         cmp_mmio_handler, NULL);
> +         cmp_mmio_handler, generic_swap);
>=20
>     write_unlock(&vmmio->lock);
> }
> diff --git a/xen/include/xen/sort.h b/xen/include/xen/sort.h
> index a403652948..f6065eda58 100644
> --- a/xen/include/xen/sort.h
> +++ b/xen/include/xen/sort.h
> @@ -3,8 +3,73 @@
>=20
> #include <xen/types.h>
>=20
> +extern gnu_inline
> +void generic_swap(void *a, void *b, size_t size)
> +{
> +    char t;
> +
> +    do {
> +        t =3D *(char *)a;
> +        *(char *)a++ =3D *(char *)b;
> +        *(char *)b++ =3D t;
> +    } while ( --size > 0 );
> +}
> +
> +/*
> + * sort - sort an array of elements
> + * @base: pointer to data to sort
> + * @num: number of elements
> + * @size: size of each element
> + * @cmp: pointer to comparison function
> + * @swap: pointer to swap function or NULL
> + *
> + * This function does a heapsort on the given array. You may provide a
> + * swap function optimized to your element type.
> + *
> + * Sorting time is O(n log n) both on average and worst-case. While
> + * qsort is about 20% faster on average, it suffers from exploitable
> + * O(n*n) worst-case behavior and extra memory requirements that make
> + * it less suitable for kernel use.
> + */
> +#ifndef SORT_IMPLEMENTATION
> +extern gnu_inline
> +#endif
> void sort(void *base, size_t num, size_t size,
>           int (*cmp)(const void *, const void *),
> -          void (*swap)(void *, void *, size_t));
> +          void (*swap)(void *, void *, size_t))
> +{
> +    /* pre-scale counters for performance */
> +    size_t i =3D (num / 2) * size, n =3D num * size, c, r;
> +
> +    /* heapify */
> +    while ( i > 0 )
> +    {
> +        for ( r =3D i -=3D size; r * 2 + size < n; r =3D c )
> +        {
> +            c =3D r * 2 + size;
> +            if ( (c < n - size) && (cmp(base + c, base + c + size) < 0) =
)
> +                c +=3D size;
> +            if ( cmp(base + r, base + c) >=3D 0 )
> +                break;
> +            swap(base + r, base + c, size);
> +        }
> +    }
> +
> +    /* sort */
> +    for ( i =3D n; i > 0; )
> +    {
> +        i -=3D size;
> +        swap(base, base + i, size);
> +        for ( r =3D 0; r * 2 + size < i; r =3D c )
> +        {
> +            c =3D r * 2 + size;
> +            if ( (c < i - size) && (cmp(base + c, base + c + size) < 0) =
)
> +                c +=3D size;
> +            if ( cmp(base + r, base + c) >=3D 0 )
> +                break;
> +            swap(base + r, base + c, size);
> +        }
> +    }
> +}
>=20
> #endif /* __XEN_SORT_H__ */
> diff --git a/xen/lib/sort.c b/xen/lib/sort.c
> index 35ce0d7abd..b7e78cc0e8 100644
> --- a/xen/lib/sort.c
> +++ b/xen/lib/sort.c
> @@ -4,81 +4,5 @@
>  * Jan 23 2005  Matt Mackall <mpm@selenic.com>
>  */
>=20
> -#include <xen/types.h>
> -
> -static void u32_swap(void *a, void *b, size_t size)
> -{
> -    uint32_t t =3D *(uint32_t *)a;
> -
> -    *(uint32_t *)a =3D *(uint32_t *)b;
> -    *(uint32_t *)b =3D t;
> -}
> -
> -static void generic_swap(void *a, void *b, size_t size)
> -{
> -    char t;
> -
> -    do {
> -        t =3D *(char *)a;
> -        *(char *)a++ =3D *(char *)b;
> -        *(char *)b++ =3D t;
> -    } while ( --size > 0 );
> -}
> -
> -/*
> - * sort - sort an array of elements
> - * @base: pointer to data to sort
> - * @num: number of elements
> - * @size: size of each element
> - * @cmp: pointer to comparison function
> - * @swap: pointer to swap function or NULL
> - *
> - * This function does a heapsort on the given array. You may provide a
> - * swap function optimized to your element type.
> - *
> - * Sorting time is O(n log n) both on average and worst-case. While
> - * qsort is about 20% faster on average, it suffers from exploitable
> - * O(n*n) worst-case behavior and extra memory requirements that make
> - * it less suitable for kernel use.
> - */
> -
> -void sort(void *base, size_t num, size_t size,
> -          int (*cmp)(const void *, const void *),
> -          void (*swap)(void *, void *, size_t size))
> -{
> -    /* pre-scale counters for performance */
> -    size_t i =3D (num / 2) * size, n =3D num * size, c, r;
> -
> -    if ( !swap )
> -        swap =3D (size =3D=3D 4 ? u32_swap : generic_swap);
> -
> -    /* heapify */
> -    while ( i > 0 )
> -    {
> -        for ( r =3D i -=3D size; r * 2 + size < n; r =3D c )
> -        {
> -            c =3D r * 2 + size;
> -            if ( (c < n - size) && (cmp(base + c, base + c + size) < 0) =
)
> -                c +=3D size;
> -            if ( cmp(base + r, base + c) >=3D 0 )
> -                break;
> -            swap(base + r, base + c, size);
> -        }
> -    }
> -
> -    /* sort */
> -    for ( i =3D n; i > 0; )
> -    {
> -        i -=3D size;
> -        swap(base, base + i, size);
> -        for ( r =3D 0; r * 2 + size < i; r =3D c )
> -        {
> -            c =3D r * 2 + size;
> -            if ( (c < i - size) && (cmp(base + c, base + c + size) < 0) =
)
> -                c +=3D size;
> -            if ( cmp(base + r, base + c) >=3D 0 )
> -                break;
> -            swap(base + r, base + c, size);
> -        }
> -    }
> -}
> +#define SORT_IMPLEMENTATION
> +#include <xen/sort.h>
> --=20
> 2.25.1
>=20



From xen-devel-bounces@lists.xenproject.org Wed Feb 16 09:32:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 09:32:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273856.469141 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKGfG-00057o-3t; Wed, 16 Feb 2022 09:31:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273856.469141; Wed, 16 Feb 2022 09:31:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKGfG-00057h-0q; Wed, 16 Feb 2022 09:31:58 +0000
Received: by outflank-mailman (input) for mailman id 273856;
 Wed, 16 Feb 2022 09:31:56 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Gpsw=S7=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nKGfE-00057Z-Qr
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 09:31:56 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 47ca2a67-8f0b-11ec-b215-9bbe72dcb22c;
 Wed, 16 Feb 2022 10:31:55 +0100 (CET)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2109.outbound.protection.outlook.com [104.47.17.109]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-29-43aNQJFkMeGe5ldx6NGTZQ-1; Wed, 16 Feb 2022 10:31:54 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AS8PR04MB7541.eurprd04.prod.outlook.com (2603:10a6:20b:29a::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.19; Wed, 16 Feb
 2022 09:31:52 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4995.016; Wed, 16 Feb 2022
 09:31:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 47ca2a67-8f0b-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645003915;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=c79745g9q0twoP/jWmR0sZSP30p4U/aPeUSqit0aOCE=;
	b=WLjjAbQARMd34cRN4whuJqjT93mvEqZxZhrYUQkas2AF5sVG7wmLGY63ATzyJPyL57xUdT
	3th5qabRFbPugDXJLvx2rSI2aS/LAmH9gQJRUeHUjwF0qezAhVBYHs4xqemPpjT04mR2ln
	+3kPuhQFtlmHEEGTY1eCxlNqDp1g3X0=
X-MC-Unique: 43aNQJFkMeGe5ldx6NGTZQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=OegDvY3c0ZkB7qvZM+IwiS4/tRZZT9dhLj/D5eBt6nOSiMVJBZt4xHDbsYOl+HCoiiJ9P7Huy5i6T1KH0+txDWl4CyFt6diVzWbGKY0yoaUL+Gy3ctdxiBQk3ofSj5Tl/uybbZSUjLtbNn6wqLw7qe/zLwDYPc3ZVFRFjaXO+Dten2T3h6XRr8e6Yy/9VbVTDBRT23z1tI8T0ecXhaDNO0kSJ96U9AvhBJTjWr57WFTyCdb7kx9eS6dkkZVuEwo3KZrBN8eB/D8PFInMgWgDIitAn0Mynuw1DBA7FgC9bKUBhmIXGj00Dfh6T76/g3QjbQTHDXWu8SpVL285SOW0+w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=P30MjygsaVXtlrX+n1Cq0GmO52L4wdwdMSAOZo9PDnk=;
 b=eeeVAUQ803bpaqXrEF6Yue3H93aixCXHyujzb2qQNamz0Glsu7vk0lClfjIzmc/VWHdDYCsDlYODVbZ3vIJK/2PeTtIugoz99RdTmr9ThaVSa3NWBy6Yv6hVCwmy3UTC566x9/tNsuMJ4HAxBIeid3iVgpOrsMXbRbLi5G12zh7CRWG7Olcd2X+/J9IVC5uZwCYBYeXUBz/8f36nKfPwDk8EAE0TaxdPMERTQvRAtjlOdp8yKeYEhidBFeZtv1lEF9L9k2Bix8IDLm7uDfLajtz0GQMZ0bY20Du0Abh0ln8uNnBZEZ1qz7R8S9f+PHX56QDHsYSuLISa9It4lvA3uQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <a89223c8-f59a-24cc-96a7-e40feb28813f@suse.com>
Date: Wed, 16 Feb 2022 10:31:50 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH v2] lib: extend ASSERT()
Content-Language: en-US
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Julien Grall <julien@xen.org>
References: <75125344-b0e1-9663-4c1a-84bb35870fef@suse.com>
 <35d82770-66cf-e030-5bcc-3c030e4463d7@xen.org>
 <3F58400B-5151-42F2-8F39-109DDF50EE1E@arm.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <3F58400B-5151-42F2-8F39-109DDF50EE1E@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: FR3P281CA0040.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:4a::8) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 313251b6-f1f1-4ea6-f2d3-08d9f12f2a08
X-MS-TrafficTypeDiagnostic: AS8PR04MB7541:EE_
X-Microsoft-Antispam-PRVS:
	<AS8PR04MB7541446888B7B9C64703A38BB3359@AS8PR04MB7541.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	cK1c2WbXl7h7EXvjadXxtJnO4H9K2j9XW70IuhU11vR1S5lCnyVgQDpDgxh9jNq02ST6Q3NjMCf5V2X4OwbnhrgJk581URi8FHoXQM2G2mHWuyu156qz7Cn/AI8yWJFB9M8EJ4ilhlHFTWeppPMK1tZfTpXdAVluXG4uUB535qcD3K9c4jGR+sGIiXQs2IFl9dnVYyyOiAF8XMBOopEyJV1AotuCWCDO1gnpVNJESHN3FLx6rTh2VRTv9BZss7vdop2Eidy9eZK4xxoLjZTXUZV0nr6mPPJ+vt1acs2TMUispRtd5MNKbcuhoHXQFTSUmf0KZLV1MNCcCGPErpsDq9S9TCNSkwT8vIyWHqYQlDucJcrIQUuei5qtMWM5OfFRB68nt/egQJ8JGH3DIB0bNXxXKAQese75kbcGZxeRBYziuFDCxUt9kJVar1x4v2BpwGs/X8be7zOupB0g5Z9CkncY4HgtTt/ahaub+fvuWRMyW24YDu2mhZe1+nSMGdA2XzPlSFi168wz5a2wXBa2kGeID+NS8q67xRXAR7d5zl6SCzZZN1f1kAETvw6+9lqWo+pJEho0Tp03OUKBpUaFORyJ8M2oWaT9VkAsbdulW8EQjoNKMg81jgaPs/HxPEGHMAuhDn3Wawuceoal6FNN7Zt/wZL9kR2Il7xrUMvcktYBlVcDPjpGnI+TMnaxYcvFSDaTzPmbK4Ugf+E5Hpanh/WODufXxMQRxFXJfIDWrYpdJd2YE53ijf9oehYqPw+Q
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(508600001)(186003)(316002)(36756003)(38100700002)(6506007)(31686004)(26005)(6486002)(53546011)(6916009)(54906003)(4326008)(8936002)(83380400001)(8676002)(66946007)(66476007)(66556008)(2906002)(86362001)(31696002)(6512007)(5660300002)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?TiairKT7D4R0hpa/lq78O1coyPJLoSs6SWG0Kj/0XJkp1iZJU7IpypDzpj9X?=
 =?us-ascii?Q?OB4qXJNi4fgVnlYPg2EOrqiFSnd/csgK2961vpYRJlyx8XQxnfrE4719h3lM?=
 =?us-ascii?Q?bQc/ZVsjlN1Kdu014/7lbEy3UXDmk+TDpLuAcPHgz6hXMYKzY1JP/TMuYVHx?=
 =?us-ascii?Q?sLuQbUOpmetCrVDYRuVg+Jj12X/fgSk1PN3fmFqOCpV8gE/ffDC/5AZQ0PVw?=
 =?us-ascii?Q?WXRlhAoU3nlP71c6Fj/WoEXKgWIp6KQ+qoJKkFA/y78lwLNWc6rM6In/Wdxu?=
 =?us-ascii?Q?pQtgEVCMCk1NLsSeHApaZ6mPr9xcxxZGeDqsx1HxYoDa5p8+te7S0MFp/+2v?=
 =?us-ascii?Q?4my0FXrHgS1KeLby0ksHK16UJveZP6qqgAGgOX6hM4S8xbpFxkc+6c4h6qRB?=
 =?us-ascii?Q?IliLHCFjxF++zTnTOIu2m7SsYpvq+ulvEm9AYeSWzuUyrUBKLIzJV+Ng8ozp?=
 =?us-ascii?Q?pgohn1AlvidgRZ65IHnrGHoumonWnpfPdr/QS4BSwgQHsGbEqTkn8s3QrE3P?=
 =?us-ascii?Q?PcfJAZKq+EV4DN/57fhoQOgb/Buz6Ml0+N1oSCa1ttwLInWvHP8FPu4giFgx?=
 =?us-ascii?Q?egbFz05Fx7YCrqlYp+5fUY6Si7FfEnCN4uqg5L77Qr1vggOW9OE1k5cW1d8D?=
 =?us-ascii?Q?cA9qonyNAk0tnwkaB1npFFhoWWHlJlSanOwgjYiwd/21n2Ubncu8slOeVkJc?=
 =?us-ascii?Q?VUw9QmPB+N3H4W0goX6C1sN3I99TY0rPjefXqqZH+dANkehnwhdEugO3W3ij?=
 =?us-ascii?Q?fl0AikiaftiA19LqetMo3sbkYzdv4C6yYqzUs9DsJTlIgfjduW1cCLPFMdPc?=
 =?us-ascii?Q?R6sDEXBpcWrXSp5eoFV702YS6BYZr35hL3p60USC1oAah18tSwLWycuvhyBB?=
 =?us-ascii?Q?tlY+I6Vz44JEixgtxTMrBvW5lvPuml4FEXfAXCiilRSfn1ItXYVZ1DmCDUVq?=
 =?us-ascii?Q?8gshg/zDVRuDWpP02Qs3uTl1QMJeHaU5i8Mb+xTTqpjnYVd+tgRFZnjpaldp?=
 =?us-ascii?Q?MczHHZy/9Ai+M5QWIoNp1k5+Zecfac5zzjyLWJrGGtO7R7L2+9uju+JEf2AR?=
 =?us-ascii?Q?BQCYj+a+rcAVJ7tBjhgo1IuAptYwYlsEUgoITgfQNkQzO222Z486nQejZdMp?=
 =?us-ascii?Q?rRKAnSFYH1Cwzh1aPKuoCx/cDJD1Xp3BuGpmn1h/R6dTUTN9bLEQO2QiR1So?=
 =?us-ascii?Q?IzFJpxhRYp+M9Y8j+NCH0asx2k6z+vYPIvyDS/+lN4VLeA0HXOLY+I0GQstX?=
 =?us-ascii?Q?GNOX3Avt8WJd/kk1qPz3yKKYyKt03HejbnQ4HjO7csrCvZl45MC9pmxcGWZ4?=
 =?us-ascii?Q?KNFgAUYFacCYjGIg4VXTDZRlech79yWI0PBRvmAyWxzCc9w3qb9tcbqcwv9a?=
 =?us-ascii?Q?kwqLHOactTN9TubQiLmF51XrjsXsUqjRSnrEYqsNLH3aaA1kcSKSQQ25nrqE?=
 =?us-ascii?Q?o9DNOdCyLn+Ypu5sF2lmQvk8msPGce7Y3DEwRajaCIIWycknb2ieEJ68/voL?=
 =?us-ascii?Q?fOCUXGvMKNJh6eGR4KP+x5upsHI3xVe3Iw2nN2leBMMhXDaDjXYNL++qkz+z?=
 =?us-ascii?Q?lnS8a8pcBKdGRoNnESAtA6CXgZoE3PEABKpVsFxYiBhDs8jp5ZtXDdtDDStK?=
 =?us-ascii?Q?HeRssCTgq5dZal9A4JT8o/Q=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 313251b6-f1f1-4ea6-f2d3-08d9f12f2a08
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2022 09:31:52.1872
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ElfZps58EBn0MCxadf15B3DqxXQgsqsggeQqaSvJ/wnFKMAWdoVIlhHvUamHH88dG+FifGy8IUk/a9QyGJAHAQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7541

On 16.02.2022 10:25, Bertrand Marquis wrote:
> Hi Jan, Julien,
>=20
>> On 15 Feb 2022, at 21:00, Julien Grall <julien@xen.org> wrote:
>>
>> (+ Bertrand)
>>
>> Hi Jan,
>>
>> On 27/01/2022 14:34, Jan Beulich wrote:
>>> The increasing amount of constructs along the lines of
>>>     if ( !condition )
>>>     {
>>>         ASSERT_UNREACHABLE();
>>>         return;
>>>     }
>>> is not only longer than necessary, but also doesn't produce incident
>>> specific console output (except for file name and line number).
>>
>> So I agree that this construct will always result to a minimum 5 lines. =
Which is not nice. But the proposed change is...
>>
>>> Allow
>>> the intended effect to be achieved with ASSERT(), by giving it a second
>>> parameter allowing specification of the action to take in release build=
s
>>> in case an assertion would have triggered in a debug one. The example
>>> above then becomes
>>>     ASSERT(condition, return);
>>> Make sure the condition will continue to not get evaluated when just a
>>> single argument gets passed to ASSERT().
>>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>>> ---
>>> v2: Rename new macro parameter.
>>> ---
>>> RFC: The use of a control flow construct as a macro argument may be
>>>      controversial.
>>
>> indeed controversial. I find this quite confusing and not something I wo=
uld request a user to switch to if they use the longer version.
>>
>> That said, this is mainly a matter of taste. So I am interested to hear =
others view.
>>
>> I have also CCed Bertrand to have an opinions from the Fusa Group (I sus=
pect this will go backward for them).
>=20
> Thanks and here is my feedback in regards to Fusa here.
>=20
> Most certification standards are forbidding completely macros including
> conditions (and quite a number are forbidding static inline with conditio=
ns).
> The main reason for that is MCDC coverage (condition/decisions and not on=
ly
> code line) is not possible to do anymore down to the source code and has =
to be
> done down to the pre-processed code.
>=20
> Out of Fusa considerations, one thing I do not like in this solution is t=
he fact that
> you put some code as parameter of the macro (the return).
>=20
> To make this a bit better you could put the return code as parameter
> instead of having =E2=80=9Creturn CODE=E2=80=9D as parameter.

Except that it's not always "return" what you want, and hence it
can't be made implicit.

> An other thing is that Xen ASSERT after this change will be quite differe=
nt from
> any ASSERT found in other projects which could make it misleading for dev=
elopers.
> Maybe we could introduce an ASSERT_RETURN macros instead of modifying the
> behaviour of the standard ASSERT ?

Along the lines of the above, this would then mean a multitude of
new macros.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Feb 16 09:34:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 09:34:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273864.469152 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKGhr-0005ko-JZ; Wed, 16 Feb 2022 09:34:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273864.469152; Wed, 16 Feb 2022 09:34:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKGhr-0005kh-G3; Wed, 16 Feb 2022 09:34:39 +0000
Received: by outflank-mailman (input) for mailman id 273864;
 Wed, 16 Feb 2022 09:34:37 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nKGhp-0005kX-PL; Wed, 16 Feb 2022 09:34:37 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nKGhp-0004CT-M6; Wed, 16 Feb 2022 09:34:37 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nKGhp-000369-6f; Wed, 16 Feb 2022 09:34:37 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nKGhp-0000hd-6D; Wed, 16 Feb 2022 09:34:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=EMwt7JhHcDWQN0njJzDapRVFjAADoMXjJcc60Df2R3A=; b=6TO3KFQYgfesui7dMOAblmIwYS
	GUcxZXy4mrE5gFVIzs8yrJZkrSvPHUw7sEWI7cCbn4wBaeJin+nELKUVYtyVfJ0/00lHumLVIjRi+
	+EpDlWAbvNtW+zIUBgU7GcnplARQcA5GLbCb0bz1xh8sl9M/TnbUCGSQHJfxjUQYDNRc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168125-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 168125: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=5cba53db57ce2725cf742b89e2c17eb8b4d99586
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 16 Feb 2022 09:34:37 +0000

flight 168125 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168125/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              5cba53db57ce2725cf742b89e2c17eb8b4d99586
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  586 days
Failing since        151818  2020-07-11 04:18:52 Z  585 days  567 attempts
Testing same since   168125  2022-02-16 04:20:12 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brad Laue <brad@brad-x.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Christophe Fergeau <cfergeau@redhat.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Divya Garg <divya.garg@nutanix.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Emilio Herrera <ehespinosa57@gmail.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Ivan Teterevkov <ivan.teterevkov@nutanix.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jing Qi <jinqi@redhat.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Lubomir Rintel <lkundrak@v3.sk>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nicolas Lécureuil <neoclust@mageia.org>
  Nicolas Lécureuil <nicolas.lecureuil@siveo.net>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Rohit Kumar <rohit.kumar3@nutanix.com>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  shenjiatong <yshxxsjt715@gmail.com>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tu Qiang <tu.qiang35@zte.com.cn>
  Tuguoyi <tu.guoyi@h3c.com>
  tuqiang <tu.qiang35@zte.com.cn>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Vineeth Pillai <viremana@linux.microsoft.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yasuhiko Kamata <belphegor@belbel.or.jp>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 98229 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Feb 16 09:34:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 09:34:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273869.469164 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKGiA-00069y-TK; Wed, 16 Feb 2022 09:34:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273869.469164; Wed, 16 Feb 2022 09:34:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKGiA-00069r-Pe; Wed, 16 Feb 2022 09:34:58 +0000
Received: by outflank-mailman (input) for mailman id 273869;
 Wed, 16 Feb 2022 09:34:57 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Gpsw=S7=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nKGi9-00069Q-8Y
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 09:34:57 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b399bc47-8f0b-11ec-b215-9bbe72dcb22c;
 Wed, 16 Feb 2022 10:34:56 +0100 (CET)
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur02lp2054.outbound.protection.outlook.com [104.47.4.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-34-C82M_xz-MTeTFliy3zoMeQ-1; Wed, 16 Feb 2022 10:34:55 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM0PR04MB6418.eurprd04.prod.outlook.com (2603:10a6:208:169::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.18; Wed, 16 Feb
 2022 09:34:53 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4995.016; Wed, 16 Feb 2022
 09:34:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b399bc47-8f0b-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645004096;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=uxH9nhv4gQR4MVu7ewiPz80iqv8Z/8i7K11ftTcI0Xw=;
	b=I7jVfk3f+AqxWoMAdXP8K56BCSlKYFhODKUw7TxtF6/EN77lSzvtKD1i5CuEdLc7iF0Fhi
	e94aX3OlA6arr/3q7/8PesIMsZA0RFuQxl2ezt5ynMWxlaRjj9ySb65nXwmjPRTM4pkmxX
	LSWrOth5FT9qPXXj0OUHl6TOJGzV+Pk=
X-MC-Unique: C82M_xz-MTeTFliy3zoMeQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Kj3w35qcXL47DYErlKBzSQstTFskAT/BPwyefhmoEIebfND7zcXqLnMh77aa8PDaoJE5ruyxdLzlhh0tTmV+n3/prXGkW2gRh6dNnhhFoz/y1NurTzexe3V5M9yeUbC2RjNvRrr97aFx24FRf5rn4Tf15iwnJhpkgG2MP/PWcxoxGpfC+z+8BmP2ho1v6lSkOKHm9QI/q3dwJBQbO1DpoV2umCpBH43Bj6s5YX0fISHVFKrUls3LyByKyUfvoXwR0DhWp7lVShurXt7LD0mRfcgKyCXHOuVhul/DB5Ox6l9EY0aItrJk3k0NuvirmcZtu1NMci33r2ij1xerPLC2+Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=uxH9nhv4gQR4MVu7ewiPz80iqv8Z/8i7K11ftTcI0Xw=;
 b=OsoVgAVa87+MWBq6BrqlOulWTcYL6nKN0XppiVPGq0FUTIIbeaynnONyj6nVHBq+zSxzv3YN7rjWz8lu4bwuIB84WZk3thOrO++3b7YAVohG6JHfYy4eT3s5kziv9Kz3kdMLRXxNLJSKGuNrTwXT3q7+ZJ9XS5Wey28jUfnIa2jRNIVIqdBGV3BYtckQbbVWxsfoe+h1UB9v4NCPgs+eTS6PP8fhv0OmQ3VclgsE0r6QapP7eFENkwV00BILJstfR3ah+wG7Y0d423OJax6lkDfQXQEu8fJoX+Yw8d8XDPFyDF5AGvkqGWFOmjYLOCdAUIbg8yeTzwho+UWKswMoxw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <cdaf49b1-e64a-c104-3b79-a1633a67ee07@suse.com>
Date: Wed, 16 Feb 2022 10:34:50 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH v6 02/11] xen: introduce CDF_directmap
Content-Language: en-US
To: Julien Grall <julien@xen.org>, Penny Zheng <penny.zheng@arm.com>
Cc: Bertrand.Marquis@arm.com, Wei.Chen@arm.com,
 xen-devel@lists.xenproject.org, sstabellini@kernel.org
References: <20220214031956.3726764-1-penny.zheng@arm.com>
 <20220214031956.3726764-3-penny.zheng@arm.com>
 <eb39c5a6-f5b1-ccf3-8d2b-802ae7da68d0@xen.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <eb39c5a6-f5b1-ccf3-8d2b-802ae7da68d0@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR04CA0035.eurprd04.prod.outlook.com
 (2603:10a6:20b:92::48) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4125413e-3630-4b8f-dfed-08d9f12f95e4
X-MS-TrafficTypeDiagnostic: AM0PR04MB6418:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB6418A40BE16A22264D7526C6B3359@AM0PR04MB6418.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	dgQv+8TpcionHmJqI6q+ySA6On3sJ9Mpa2s6BH6ivlzxjLgVOzXO0iSSl5ewT02u71GLXO+O0K0nym4L5JKyqzUQ5jDoi2VAYpEuiS76aro7flLCDLGappcFopOag7lxBc0G0PZnKAd98GLDqOhwMiNbncEDn+j8KNnsRGUu9zrBaSjR3Mhki/xXyWrko0IgfJzY8ZsQ3KoTErZE1LoHV9O3KVnTdQO+bzVT9BpRLYaHAIRXE9cA9IfQDu0Xj+mBYVGKYDYxZE4+b9NKiDP8+7lchazeBfdNYuOI2G+gVmZD4CeiNh5YUWdAvIl3igPZjdFtmuMUTuaIUjuMuV2aDNDpt1Icc9OHZMljSLfIwDnodHCHP2ZnJB3BF6RtdLgiZj5gpAzaYYwVmOIACFwslEm45cJ3UlnUqu3iKHerZv7qkvVfPqeTwpFSqQP+2O9lQKeI6Jrq5AF0d7Q5O7jlXOBUhJLvFbrREjth9UWbCCLGUHh9LyIoqAxUa7BQmx15UJGngtusQJ+Tky7n6lKvapCCDsWPezgCLjAMKj1Pr3cEvqSV7RyyFiY20QyXgWtwOEbu5h99zLCn5mxjO4dZHpp0Aeo9HrF0xtrhldUSHcYtnsutC6o1pMLvfJuWNdnLZPDKOGHNAdEk9P38REL42O9/jR2myhBoczw+4MfJgW/G5HzVyFPT329smvDAzP+3pZWFjaFijq1zGA2cP5uNNLMML+Ap3AGxPNf7WKexSon5RM6Ba06v6vSTxaPeRLqi
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(186003)(31686004)(86362001)(66476007)(31696002)(36756003)(38100700002)(2616005)(26005)(4326008)(4744005)(6506007)(66946007)(6512007)(8936002)(5660300002)(316002)(110136005)(8676002)(2906002)(66556008)(508600001)(6486002)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?R2V0dGVCaTREM2UwR2Z2elVWZUx5bVpuU0FsUUFQajZuVk5YazQ3aVVpWHBw?=
 =?utf-8?B?cnQyUHdtRG1PeWYxQW1uc0JTamZQd1FhV0RGVnNRVlNIQ25XdUZ1TCsrZmlL?=
 =?utf-8?B?N3hOc3RBR09RcDIyb2x1NFN3cmUrMG5yMGFnVmVzT2hPUzJmVnZRUmFLQUJ6?=
 =?utf-8?B?WVpSUm42bXIvYXBka1EzMU9jYWQzVlFHRjltdnVVT0FvSlFmeUo4SUhXYmRS?=
 =?utf-8?B?U3NRWHV1dXJ2ZFdyZUZNNWR1M1FKWHM4czMzN2F4QVFtbjNRT1g5QlA1QWhP?=
 =?utf-8?B?L09WcW5zNUtZL3ZZbGhNZ3ZCM1RPS3piS0FNRFN3WC9LbXdtbDM3U3VuRHR1?=
 =?utf-8?B?MFlPOFFHcGdkVHZSa0p2eWVBTlZPZzZvRXhDOFRDQVY0QjJvUzVISVRzOWxw?=
 =?utf-8?B?RXVacW1GTVRPUUNOTG5WU1IvaFlVN2FnWjNMMTgvdVFJeXlmQklUU28wKzBR?=
 =?utf-8?B?TEtud1NVL0RiN25zY1FQR0kxVTBINWp3bGFoSXVha1F6Y0dtalRvV2tDQis5?=
 =?utf-8?B?Q1pkZkFNa09mZGgwdTE2ZGtlZUJCREsxSVp3UE04SDB3QlZqQlZQMGswQlNU?=
 =?utf-8?B?NmlyVmRVU1Q0Q2o3eWgyT2RTV3lidXJuYllHc1JaMzByL0VEaDZJeXlabnVG?=
 =?utf-8?B?TUswSnk2eTVEMnVqSmNNSFZRTHk5dVZzMUtVT0VWNFkrbC9ETy9QR1Q3dlN4?=
 =?utf-8?B?MkJhU1I4Y1FUb09tckVGeVdTNTdoNHpLamV0dEJTU0IyaktrVTdOQ2NCZmlB?=
 =?utf-8?B?aE4vd3ZNUDZEY1BBOHdGVGdqcFo0b2F4Y0NSV3RtcHBtYmtmNmpybVZIWm13?=
 =?utf-8?B?QlZOUTdyUERjUk5wNC9iSG5VWXZvRk8zS1JjSURhdjR1d3Zydncwc3lmY3BX?=
 =?utf-8?B?T2JZcEVIZUQycU9SYkJnQzUxVmVDekUvZHJQc21mLy9rU2RNL2tIQ3dvYUhU?=
 =?utf-8?B?UXZnbFZ0UEIwdkpKS0Y4WVdoSjV2OWRBWGdVNTQ1WWlYT3Bsc29uU1hPRFAw?=
 =?utf-8?B?QlR6NXBpOG5ZeS9jOTBNZTV6aGRCT2JXK3VqNDBNU0UzZUwxTG51QTJOcEhO?=
 =?utf-8?B?QjlmOGlSMHc1WHRCUGF5SmJNRThMc1h0VGpubmtaVzBjSmpNMVFIT3hZdmxP?=
 =?utf-8?B?R3kyb2NZUWxnKzBadjliZWpITGJVZUgyNjVWdlR6VE1DaENCWHdLY0pjd3Br?=
 =?utf-8?B?THNldTZQdjBrNU5BRUpUV01Fd1QrUWkzUk1NUUROMlpJTUhwMytBYW5tU2lL?=
 =?utf-8?B?NDg2cG9LeGV4VW5hK3J6a2s5QmpCYlY4N1R1cy9FTkdXdStYVmYxN0J4alpn?=
 =?utf-8?B?ZUswRWU1Qk1kTEVmOElLZUJsUU45U0VUWTJqMkRDdHZDVFltMmwrTDExNHI3?=
 =?utf-8?B?OVJRb1Y1d2I2YTJ1aTJhTmtld2J4QnZuR05DKzBXY3V2QUhOdGF2amt5dUtG?=
 =?utf-8?B?ZW9jcnlJdjdLUTJucHNWRkxubDN5WU50c3BEVkZ6NVdvQ2RjQXpoWmlNZFVl?=
 =?utf-8?B?blg0TkdTcHRuSFE1S3hwMWJBMlBHNitIWXJiL0I1dXQ0SnJNdGxRcGZuZlpr?=
 =?utf-8?B?akt3cDgydkhYTi8vWVVDZ3IwWEthRVN1ZlNNRDRSeElFU2IvUkgzcEh0VURJ?=
 =?utf-8?B?VmVERWI0akpVeXdJRW5YdW13NTVONzNOeVZwcUgzNXNaS21Ha1BxYmpUYUZz?=
 =?utf-8?B?SFdKOHhBRjllOTh5OU1PdEpuSVFEWmRwNFlrbHFBLy9pOTZtY0Nua0dXYXhu?=
 =?utf-8?B?M0dkQmZhUXlHN2FTa0M5UEx0cGN0R3RrYkQrTnVZVXg2RlVMaElCdC93QjJN?=
 =?utf-8?B?cER0cFRGUys0RXNwb05mZE9oOW9ydFpLZUtXYXQwYzlyTFArSkFETXl1aVJY?=
 =?utf-8?B?S20vZllkdEgxcDk3UHVnOWY0N3hNUVRGT1ZOSzE3STAzeFAxTE1EeWZmak1l?=
 =?utf-8?B?VzdXSEVPM2twUzlURXV1c1NCbU1WZkRxZmlTQ29JNDZ3RXlZM3ozWnh3aDhM?=
 =?utf-8?B?T3NCSzlxNkpUOE5iUXpkb1NtRmF3LzA1bU0yNmd1eE1lK200K1VqTTdtcklw?=
 =?utf-8?B?dW1PYU5nN2YyS21JUkdrejI0dVZnT3MzZmNBbnRSNHhqcFYrS0k4eEszQTg4?=
 =?utf-8?B?Ri9sZHQyVmowQU03WmdRazlSVlRsSUNLaU1jb212M1BiRUJjS2NLRTh4eVZ3?=
 =?utf-8?Q?rT3hAh1XI6MElZnJLnpNlog=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4125413e-3630-4b8f-dfed-08d9f12f95e4
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2022 09:34:53.1603
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ifLw2aEoDuKJBdECIBIRqgEp2JjkS5Nc2b/ft+oLzx7MUZMprFbGoWZOi30i3J9gVsIRYa+/NC9/Iw1riGJY6g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6418

On 15.02.2022 21:26, Julien Grall wrote:
> (+ Jan)
> 
> Hi Penny,
> 
> I am CCing Jan to give him a chance to...

Thanks, but ...

> On 14/02/2022 03:19, Penny Zheng wrote:
>> diff --git a/xen/include/xen/domain.h b/xen/include/xen/domain.h
>> index cfb0b47f13..24eb4cc7d3 100644
>> --- a/xen/include/xen/domain.h
>> +++ b/xen/include/xen/domain.h
>> @@ -31,6 +31,10 @@ void arch_get_domain_info(const struct domain *d,
>>   /* CDF_* constant. Internal flags for domain creation. */
>>   /* Is this a privileged domain? */
>>   #define CDF_privileged           (1U << 0)
>> +#ifdef CONFIG_ARM
>> +/* Should domain memory be directly mapped? */
>> +#define CDF_directmap            (1U << 1)
>> +#endif
> 
> ... comment on this approach. I would be happy to switch to an ASSERT() 
> if that's preferred.

... I think I did signal agreement with this approach beforehand.
It leaves the option to use the same bit for something x86-specific
down the road.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Feb 16 09:46:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 09:46:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273885.469175 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKGsl-0007v5-2N; Wed, 16 Feb 2022 09:45:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273885.469175; Wed, 16 Feb 2022 09:45:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKGsk-0007uy-VN; Wed, 16 Feb 2022 09:45:54 +0000
Received: by outflank-mailman (input) for mailman id 273885;
 Wed, 16 Feb 2022 09:45:53 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Gpsw=S7=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nKGsj-0007us-DL
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 09:45:53 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 38faa90b-8f0d-11ec-8eb8-a37418f5ba1a;
 Wed, 16 Feb 2022 10:45:52 +0100 (CET)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2054.outbound.protection.outlook.com [104.47.6.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-25-gdtPNhHsMpy0fClBHjhEEQ-1; Wed, 16 Feb 2022 10:45:48 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DB7PR04MB5994.eurprd04.prod.outlook.com (2603:10a6:10:89::24) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.19; Wed, 16 Feb
 2022 09:45:47 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4995.016; Wed, 16 Feb 2022
 09:45:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 38faa90b-8f0d-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645004749;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=+B6fulqIq0gSa8+v+CdeOQX6FEgAQGL8lG+xGt35K7A=;
	b=frfS9MitowSF53/mrjnMTMCYY8h4ym+2wQkSIs/rHC2blq1YZySDOBRghPaRmuFEW2l/6/
	IOdbHLbembVR0cqnCgt92TyiSntCDIURCr6XnfqnuVBLJ8wTFwxyZdgeMM9OFlusnNz/J8
	soFDSU6fCc1YecQu7lp2PBn1+AwIjd4=
X-MC-Unique: gdtPNhHsMpy0fClBHjhEEQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=iln5nIa5IjawOsXcfGkITsZrUv3DvhpqrURR9iUHdYMBtUNPdFYJk8qWCNWP/0tf1wJkiEFdgC8JQ9ctjctvLDMp2I+FZwMK45yffbDzbylRtU7gE/Lg5XlgV6wMvXxLhF0Ewi47cHqP8QfP5FlAoTnbKfZhk9hlyeoBo44ZlXUHdhjkKzgC2ZsGIMLkAzaSrDqWtUrWSErRviiApeES0gnTMZw13Z7VZ9Z5Jwx8ylvWuCq7IRGUGJErUQKgGwdKzjAFER8pddjqTCCXJf53144EPCQfa4ZzskNt2/C1dvkZzA5XJK/ESMZV1nyr7jM8qMw+KBwskCweZ2isM1ZnVg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=oAiZpV8gHbcsIUNxUGTOnA8YjcbALk4FxFPOjUWWkp0=;
 b=au5voNi0ujQPdfta/eoLsDQ3Ao6hnEDytpyD6pvU+BsjMAjenv/5k7gGBjfSLTaPdMQv23X/xZJ6g+xZkPvMa/v8RwcPIanz6wcJWVOBUIk7wooUhDR7i3LI0hZ75yGTd2olLrYJRftgi2YtfuuTNlDZBgZEAOciE856lXbGSlA49hCGkBbXP91XjmR2dh4/Kly54+1dwYeXcADdC1PsSp76mqldaoXzyxMfoTj1tVFcugYTzhPkFRYb4t9Ub4cDjTC4ebhCKhk2pnfZ082d0WhVtqYNjp1xP6E25GuBoL53evWZtv/uZII3T+gnS4X6WSCAeHUCQzNL+tlR7sGcoA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <51341b6d-c58c-585d-4ff3-68076604e255@suse.com>
Date: Wed, 16 Feb 2022 10:45:45 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH 1/3] x86/retpoline: rename retpoline Kconfig check to
 include GCC prefix
Content-Language: en-US
To: Roger Pau Monne <roger.pau@citrix.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220216090300.9424-1-roger.pau@citrix.com>
 <20220216090300.9424-2-roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220216090300.9424-2-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6PR0502CA0064.eurprd05.prod.outlook.com
 (2603:10a6:20b:56::41) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7b8895ed-8842-427b-c9cb-08d9f1311b8d
X-MS-TrafficTypeDiagnostic: DB7PR04MB5994:EE_
X-Microsoft-Antispam-PRVS:
	<DB7PR04MB5994E39D5A50BC132EABF7F5B3359@DB7PR04MB5994.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3383;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	OG25gxll29c5ejVozUFvoRaIFeUJSgpmHlCtpdeqc+sFtQwejzHTkJzaMGbYEfvmxkRCho6hUyJ8UQht26SMAG6f8GlWZPxYoeUDdGlpN14/6rHHNOJ8+OfQ9ozUaT+JfbT/J+JQ+6HRVj7rj+EMKaYvnirxSrTebg5XwWNMcXdxs1Y6g79ZDZwAb/l4kDX/4NbplNJNV4CV54wiKb5dl3vOTMyvmxi1eUI/7K2yyywltBcOwxTPglp5HvCelATBkbejV8a574UaHAioWa+DQhlCC5pEkismwU7skecbs3ndBSPVyEodlzAmpxK0gn3q025cM1wyLCFGdC7HeoQWQwE+kIeMwCz8Fyi7ECwdvqOvZnxdRH3syZW/DLjDs7AV423+6vRq25AGL3thC3jUCt3r7UhVh3zuTDqd2N0xCuhKDcS3kp1pUh+XR+SC+BkKMoVVTs/c9pWIf5Up3dtFO0nQDgwN65GQaARzlYhZAnc4vajnbeedk+3OxXuJKOqA94lYcz19SUkICI4N32swK1/dB0BrTP9rxO/nN8Zg3oPeieOVlA3bPTmKBCUoAS5geEDRfebc4bFl3g/JOHXVT+zDRTgy4/p7KZ+Qe/EB3fDj5V1JB2MGQE1HZaRZ9camgvsjFp4JMLxL/5A1wLdr9KyuZTpqn4mtGSArnsl/dcPwbKCAOkxEx6d2SJ5r9H44J0q7+/DCeA22Ak3DSapPKvKT5AJ1kY9Ao1xEE4AGRJ/dj2Xtvdad0w2oDUC5hrNf
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(38100700002)(2616005)(6916009)(54906003)(508600001)(316002)(36756003)(6486002)(186003)(6512007)(26005)(6506007)(31686004)(53546011)(66946007)(4326008)(66556008)(66476007)(8936002)(8676002)(4744005)(31696002)(86362001)(5660300002)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?VVa+cDjosqd53zHB4ESbb2V+OIf9ennKxUx2D08b3Nnvy3qd9QU5yzIikINH?=
 =?us-ascii?Q?MRqCKdLt01fE8meZUKs6XEwZBlYk2Iq29aDZbptAwn2cL4xnLJj2MJZ43jtb?=
 =?us-ascii?Q?Nq6NO7x3zoFouCkfWpDLVAgz/F/CSrql4JCTc4gP/7wXOFUhvOmGnC4wJHXm?=
 =?us-ascii?Q?l2H3VRuRGvFEASJZBAnKAwT61Y/FPg8EEdDoBFa/RSTLsS5yi8rl7Y2bOndX?=
 =?us-ascii?Q?kM0M0hhwmh1PhDVflq+9pt5CNkjTmC8aBtrJmCisKWm/Hf3M8fAWehLkvWEw?=
 =?us-ascii?Q?GJCXt6mc16Bgda7NhS31fWlFkH6CtVPXyY4RUsCCv0U035mHQXGSL/TOPLM4?=
 =?us-ascii?Q?6Pqy+NvavvWMnvr3rI0tSJYCsDWwE8gyWkxeIri0vzXK2ntcpJSixF3y7QZ7?=
 =?us-ascii?Q?i9MWA+tQ/mc49mgSL8jGageF5B/8VvPCRD2FaI3PMrnv64Jisd/Y+6jnZTT3?=
 =?us-ascii?Q?3rDXlAvTcRE8YROtrnne2BJoKDRjL7POxLRN1DF5eOFoNIElDqmuvOZJULVG?=
 =?us-ascii?Q?3xcHkzAJabYto+ICPJduNYPMH30p2aSaneJXR1iIP46MQ945tcUXjUkKp/Wk?=
 =?us-ascii?Q?O+LQKvYE/jUR+3lAvtAu8XOHzL7Az428A52Jmu5NwZ4scAwfc3evHWlcqwop?=
 =?us-ascii?Q?/Ke6+QyTqpxZcdT7roYYa4NTxqHKlq4ARqp0I80dNjdfHGHHQx7Ic+Y0+any?=
 =?us-ascii?Q?hR9ub03WUSBecQHMCyrr74DFFOcc/22pyBC83bNDcfBLCXqw6yR+d9fuZ/VB?=
 =?us-ascii?Q?QshohLREgkp/ZLJ19jh0IyZGScIKlshtrhqVLYemhOP/5tGsMtPWtBrBPVH9?=
 =?us-ascii?Q?9w0IMdT4tDVGVu3ctuURCLsywqR/XrTKlw/Pq2IEgf7yNH6v7Q8biGiKtMfZ?=
 =?us-ascii?Q?SeOEREOWrB8PIgKjkj/z+v8iOi+nOCGveFE06wvipChiZGHxiQNUWiYNfbZk?=
 =?us-ascii?Q?vUdNhjtqpTZVh4l5VJHGKeZDFBybCffXguBXFXH+xnJ9Kdv1y4OIwGoH2ppT?=
 =?us-ascii?Q?gPOqa2zCJJBY7Fxj6uTgW4SJK3q70mLK8sa2fRzEdFtdAXldSt4hrfvinNYf?=
 =?us-ascii?Q?3B33ZpQTReytKWXuI2XMXPgLGh+w/ayt4rjpLQv82EpVKUOjCbua7UO6X4Oy?=
 =?us-ascii?Q?/CRX5R/nCsvgOuGFXOI4HvypjUh87YV6pGoFbNorpOisyPBmOoKQjGpAc2aC?=
 =?us-ascii?Q?Fih0qXEuoLUVlTuGvCdeaTdOqvB67IJEtqoRSVCsx3KRQ7eM7VoIPCSO3EcZ?=
 =?us-ascii?Q?EamHImWpewBEy0UnD3TD3gbsezovoj8QqBg4ejC2fXULJ4SvM+cfjg6xKKPl?=
 =?us-ascii?Q?U5Z/t1PzCuTeK/9riZtRsHFXitSEf/B94FvOTERTyPYZoe6F6PICDhcHW1RI?=
 =?us-ascii?Q?BgdDtNrCdMWgZ7a7X5ZbjKPGwUOnd7fQ569udz5kYeZYwf+HvOI1nLUGBuHN?=
 =?us-ascii?Q?TRHSpGOrBgm9WK0k03I8UtavTnK20JyDuZsKXFUPTwmtKm32SypBHe4DpF9g?=
 =?us-ascii?Q?/rPF64hYz6OjEd6uYGlNH5YUKKkea4FlxfF0bkZr6quAFLyPuw8ivaKNjBSP?=
 =?us-ascii?Q?RcOBPMdIni5EeNfEr/XXlGA4FUaWrHL4ry8VsqqGaGGdipz0ZEdVSdguW0d7?=
 =?us-ascii?Q?qzBgqJ8G3AzgEDdP4sQnf0Q=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7b8895ed-8842-427b-c9cb-08d9f1311b8d
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2022 09:45:46.9010
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PD3nxSQzNlB8zknCcfeqhoWl16xfOJsQdhNSbjxk9R+sHe2LBWxseyKa06GS8SCtTMjLX3ibhHTovb+nbv70Gw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB5994

On 16.02.2022 10:02, Roger Pau Monne wrote:
> Current retpoline checks apply to GCC only, so make it obvious by
> prefixing the Kconfig option with GCC. Keep the previous option as a
> way to signal generic retpoline support regardless of the underlying
> compiler.
>=20
> No functional change intended.
>=20
> Signed-off-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>
with one remark:

> --- a/xen/arch/x86/Kconfig
> +++ b/xen/arch/x86/Kconfig
> @@ -32,9 +32,13 @@ config ARCH_DEFCONFIG
>  	string
>  	default "arch/x86/configs/x86_64_defconfig"
> =20
> -config INDIRECT_THUNK
> +config GCC_INDIRECT_THUNK
>  	def_bool $(cc-option,-mindirect-branch-register)
> =20
> +config INDIRECT_THUNK
> +	depends on GCC_INDIRECT_THUNK
> +	def_bool y

I think it is more logical (and more consistent) if "depends on"
would come after the basic type (i.e. the "def_bool" here).

Jan



From xen-devel-bounces@lists.xenproject.org Wed Feb 16 09:47:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 09:47:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273890.469186 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKGu3-0008SP-CX; Wed, 16 Feb 2022 09:47:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273890.469186; Wed, 16 Feb 2022 09:47:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKGu3-0008SI-9e; Wed, 16 Feb 2022 09:47:15 +0000
Received: by outflank-mailman (input) for mailman id 273890;
 Wed, 16 Feb 2022 09:47:13 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=bXi8=S7=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1nKGu1-0008SA-LE
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 09:47:13 +0000
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur02on062a.outbound.protection.outlook.com
 [2a01:111:f400:fe05::62a])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6a2d5fca-8f0d-11ec-8eb8-a37418f5ba1a;
 Wed, 16 Feb 2022 10:47:12 +0100 (CET)
Received: from DB6P18901CA0023.EURP189.PROD.OUTLOOK.COM (2603:10a6:4:16::33)
 by AM8PR08MB6628.eurprd08.prod.outlook.com (2603:10a6:20b:362::8) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.16; Wed, 16 Feb
 2022 09:47:09 +0000
Received: from DB5EUR03FT034.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:4:16:cafe::28) by DB6P18901CA0023.outlook.office365.com
 (2603:10a6:4:16::33) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.16 via Frontend
 Transport; Wed, 16 Feb 2022 09:47:09 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT034.mail.protection.outlook.com (10.152.20.87) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4975.11 via Frontend Transport; Wed, 16 Feb 2022 09:47:08 +0000
Received: ("Tessian outbound 826a6d8e58c3:v113");
 Wed, 16 Feb 2022 09:47:08 +0000
Received: from 5253e0bdb9c5.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 1DF72E8D-5DB7-412C-B858-59F46D049AD1.1; 
 Wed, 16 Feb 2022 09:47:02 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 5253e0bdb9c5.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 16 Feb 2022 09:47:02 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by AM9PR08MB7032.eurprd08.prod.outlook.com (2603:10a6:20b:41e::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.14; Wed, 16 Feb
 2022 09:46:59 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::aca7:79c4:fa65:dac6]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::aca7:79c4:fa65:dac6%5]) with mapi id 15.20.4995.014; Wed, 16 Feb 2022
 09:46:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6a2d5fca-8f0d-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=enztSATIE0PNym+Bx0dO33uCIgY6HitJixLacRT1nfQ=;
 b=wXm/Xnfe6UqKBhTeYTeWgni3/zpae7j/LdUwleKPJ0cMwkSoG95VgNJKMsFg83yw1V7FPXMYr3Evz0bhBEhJ8yMh+2iv4OxtmS0Z/Ap4oClCgK7hGV8zcGpFR4MMYvawST8MpxO9L2B4RM5znScoi6IgikLlF0OVT9c6LG0d6bI=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: be327a42f7c37701
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=OrHMiFH3dtrWS8QU1Irw2InPZzengRL2G28XTVEEcQT/le+SD4IYlM3nOrmK758pExR1mjj/fuALxi5DPTmj407J5UAxGACKvtDyt2ohLzL6ws96Ez+72e+Qa0o8NxOR8edD9nfunHjeic9NKiUhzwjT0J56HYhk4wPd9gfhQqPC16UeflgYSHJIm3aHVSwyaG8zHsc2EaYmL/0rhDFFhxWYfV/5/aQ2pZe6Htqt1fzyy5z8DSu7PdL1zoAAqMVfoP+ZbUSc0fIlAkm8X/TjVb5FAS1+Igtrtf1r3bHTDpMvn+BOem05pxbkggKtuo+s/41BFj7zEWARSNtVaxIGSA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=enztSATIE0PNym+Bx0dO33uCIgY6HitJixLacRT1nfQ=;
 b=Jcw5mbp8OgM5+hOodEdFXVmgVsWJeWTutAVuE6Vkj51jUmE+CQKuVU1IqtHV1Vkt2ItYmdVnKaLXAwvoWam4Ki+KisHBRoXgYHUtAhYBpiqPkbwf7lnA6B3Wl0A12lnYRm84WcDb4mp9XZ0p2KxTpHJqHoOfO5PbSh9uFn0CziZEpaboH68jeIdeF+2wpJxdOaEDRDwJWmcKZNfMVyAM9zij+NN4vj+kQmVcvPyFSG4plVoxodLH/hV1uz7TnL325GW3Ig1C+mDZRFuiSfokXLTqJqIuI3sPvnYp83Kpf1IUCE+eFpNE2t14IVr72lXlv4hQ+af2z8/Lst5aa/ENNQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=enztSATIE0PNym+Bx0dO33uCIgY6HitJixLacRT1nfQ=;
 b=wXm/Xnfe6UqKBhTeYTeWgni3/zpae7j/LdUwleKPJ0cMwkSoG95VgNJKMsFg83yw1V7FPXMYr3Evz0bhBEhJ8yMh+2iv4OxtmS0Z/Ap4oClCgK7hGV8zcGpFR4MMYvawST8MpxO9L2B4RM5znScoi6IgikLlF0OVT9c6LG0d6bI=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>,
	Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
	=?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>, Julien Grall
	<julien@xen.org>
Subject: Re: [PATCH v2] lib: extend ASSERT()
Thread-Topic: [PATCH v2] lib: extend ASSERT()
Thread-Index: AQHYE4sUwaOwwc8tCU249z99fRIDqqyVNw0AgADQBoCAAAHjAIAABDoA
Date: Wed, 16 Feb 2022 09:46:59 +0000
Message-ID: <9A2C0906-B7EA-4E18-A384-89D52744B940@arm.com>
References: <75125344-b0e1-9663-4c1a-84bb35870fef@suse.com>
 <35d82770-66cf-e030-5bcc-3c030e4463d7@xen.org>
 <3F58400B-5151-42F2-8F39-109DDF50EE1E@arm.com>
 <a89223c8-f59a-24cc-96a7-e40feb28813f@suse.com>
In-Reply-To: <a89223c8-f59a-24cc-96a7-e40feb28813f@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3693.60.0.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: e64a1815-2d7f-4de9-9824-08d9f1314c89
x-ms-traffictypediagnostic:
	AM9PR08MB7032:EE_|DB5EUR03FT034:EE_|AM8PR08MB6628:EE_
X-Microsoft-Antispam-PRVS:
	<AM8PR08MB6628FD697E5606547D0372D19D359@AM8PR08MB6628.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 LPSUU/vxFHNXnbaZcc0MMqGbrD2aBH53THdFlk6O2+vbYFVWKG1wqrsKT5nhyF6zmr0CaeIjkKpIYb6sRPSUxu4i6zQq1+RyElvTzashHJyK5JoAkHflxQ36Is3CWVvwfrLfsEggguUJ9+dLVWPwD2nkz5MNiuSxeyNNqMdnjWcE+5uN8ZjgVIzWKEuJelCM5xFLpgwu/BHe1ndKDRTJoEBzpBjqBlth+wDDZ1VYFVER5bILVAngrAXpMdB8CmX80bRra1+ZRvJuky7qI+UQaJklzjkZp5hf6sK8X7eN6EX6dq+H0nZpsNPIojtpjnYATFxiD82fWgV8+YR7gfRKqtcVybCJMNQoU65sQfy+D0xQPqOmzGyHNoGH39M9b9YFVb65Byj9Cu5dWlzWmc0+foMLyy/IxJ8p9gteOCIzAh+JVJ1YT9yIMhaIh+OiZ7nXgjTj7IoDkaQm/AM/zCQzRhkgwNIEPFqiZssl8tLhwwCzwY43XpPKiDxQU6m2q6HVfXlbPnbHwn3YPTJwUUhoZh+oSIftXUDFHFhc0gojr2STp1nTuFBtZuiWIHYVB7BsxgM/2EPAvURC4G3yQT6PquG1csR0z/4l2paosg8MzRSoGKXlr5SCgdDVKgQBBfiRvrexEXa9qESwFOKa497adpfbkDHE0/hakGBWWdf5Ex55FfHqhF+5ytfvD+H9OCQ575ES9pRZlrumXwQk+SRHslDzdER13LrYA49BrHo1OshpP/GVrDcokO8hAFKAMk4c
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(71200400001)(6486002)(66946007)(6916009)(186003)(53546011)(26005)(6506007)(86362001)(316002)(36756003)(508600001)(5660300002)(8676002)(2906002)(122000001)(38070700005)(4326008)(66556008)(64756008)(8936002)(66446008)(76116006)(91956017)(66476007)(2616005)(33656002)(38100700002)(6512007)(54906003)(83380400001)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <0A84EFBC88CDA446939A7541BD4AD0C5@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB7032
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT034.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	125a768a-7ee2-468f-c85c-08d9f13146ca
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ruUXGJk57sKdABb51S/N36zxE+ND56a7uW58BvfxV27I5xwTfizDqNwQ0XmoW3WD/hY4nBU/9BxET+QDSELxDgtqTkFNI5jlxL/2+4pT89tB39Cww6n5WIt6j6pg889vQkSLtTCZ7e+jc3WRvOR4VagZ9/MVmi3WUosoxxM7SWuwOaxdCS/mzxileKTXErwxq7XzQ9EesyHJnsetiGleoCSoXG5RLpEdlDe/TaFqZlJFPQ62TtOyxoDHfde8r1YlYqCeMbn99KKYfrcOoWXPjv9ALy63//BCrI2Hnl/snwPf7uajVgDsCcswlqhoHUj4M2W0sHpIbQZPZ6lF8eN6LhEpQ+OEsAI6bN8DtxMoXExBqGAQ8aqV0ieKT9UU02NJj4eAukb5WVs0OtmnbdcwGotA7aypMv6XtsZLqQzChroranPX+/2LDgfmrkJTD9K7fRYSfDWuhK5OHo70zPZf1ZelHKUDcOgSo+KJ4X5KgWJTUq7AhXkdXno7JsK6OV6vgBYJW04uH7Utctb4l6ZzAVjNyIno0Tze4W/CHefLFiLpqgnMnTPSzcNQJ7X0L0BVD2K621bFZZN/Al0uNG4HO//fbpcqbezKr/L1FKk2T8hoQr9pv5ofVWTYxU77Dy1Nh7uhBWnPhNuJ5r0NTLRNsoDqS7yqBVWNYP2eoS4oDrl0k7BXYt6vYkCFMKpkVZC/
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(2906002)(8936002)(5660300002)(33656002)(40460700003)(82310400004)(36756003)(2616005)(26005)(186003)(336012)(36860700001)(83380400001)(47076005)(70586007)(86362001)(316002)(70206006)(356005)(4326008)(8676002)(6862004)(53546011)(6506007)(6512007)(54906003)(6486002)(81166007)(508600001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2022 09:47:08.9338
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: e64a1815-2d7f-4de9-9824-08d9f1314c89
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT034.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6628

SGkgSmFuLA0KDQo+IE9uIDE2IEZlYiAyMDIyLCBhdCAwOTozMSwgSmFuIEJldWxpY2ggPGpiZXVs
aWNoQHN1c2UuY29tPiB3cm90ZToNCj4gDQo+IE9uIDE2LjAyLjIwMjIgMTA6MjUsIEJlcnRyYW5k
IE1hcnF1aXMgd3JvdGU6DQo+PiBIaSBKYW4sIEp1bGllbiwNCj4+IA0KPj4+IE9uIDE1IEZlYiAy
MDIyLCBhdCAyMTowMCwgSnVsaWVuIEdyYWxsIDxqdWxpZW5AeGVuLm9yZz4gd3JvdGU6DQo+Pj4g
DQo+Pj4gKCsgQmVydHJhbmQpDQo+Pj4gDQo+Pj4gSGkgSmFuLA0KPj4+IA0KPj4+IE9uIDI3LzAx
LzIwMjIgMTQ6MzQsIEphbiBCZXVsaWNoIHdyb3RlOg0KPj4+PiBUaGUgaW5jcmVhc2luZyBhbW91
bnQgb2YgY29uc3RydWN0cyBhbG9uZyB0aGUgbGluZXMgb2YNCj4+Pj4gICAgaWYgKCAhY29uZGl0
aW9uICkNCj4+Pj4gICAgew0KPj4+PiAgICAgICAgQVNTRVJUX1VOUkVBQ0hBQkxFKCk7DQo+Pj4+
ICAgICAgICByZXR1cm47DQo+Pj4+ICAgIH0NCj4+Pj4gaXMgbm90IG9ubHkgbG9uZ2VyIHRoYW4g
bmVjZXNzYXJ5LCBidXQgYWxzbyBkb2Vzbid0IHByb2R1Y2UgaW5jaWRlbnQNCj4+Pj4gc3BlY2lm
aWMgY29uc29sZSBvdXRwdXQgKGV4Y2VwdCBmb3IgZmlsZSBuYW1lIGFuZCBsaW5lIG51bWJlciku
DQo+Pj4gDQo+Pj4gU28gSSBhZ3JlZSB0aGF0IHRoaXMgY29uc3RydWN0IHdpbGwgYWx3YXlzIHJl
c3VsdCB0byBhIG1pbmltdW0gNSBsaW5lcy4gV2hpY2ggaXMgbm90IG5pY2UuIEJ1dCB0aGUgcHJv
cG9zZWQgY2hhbmdlIGlzLi4uDQo+Pj4gDQo+Pj4+IEFsbG93DQo+Pj4+IHRoZSBpbnRlbmRlZCBl
ZmZlY3QgdG8gYmUgYWNoaWV2ZWQgd2l0aCBBU1NFUlQoKSwgYnkgZ2l2aW5nIGl0IGEgc2Vjb25k
DQo+Pj4+IHBhcmFtZXRlciBhbGxvd2luZyBzcGVjaWZpY2F0aW9uIG9mIHRoZSBhY3Rpb24gdG8g
dGFrZSBpbiByZWxlYXNlIGJ1aWxkcw0KPj4+PiBpbiBjYXNlIGFuIGFzc2VydGlvbiB3b3VsZCBo
YXZlIHRyaWdnZXJlZCBpbiBhIGRlYnVnIG9uZS4gVGhlIGV4YW1wbGUNCj4+Pj4gYWJvdmUgdGhl
biBiZWNvbWVzDQo+Pj4+ICAgIEFTU0VSVChjb25kaXRpb24sIHJldHVybik7DQo+Pj4+IE1ha2Ug
c3VyZSB0aGUgY29uZGl0aW9uIHdpbGwgY29udGludWUgdG8gbm90IGdldCBldmFsdWF0ZWQgd2hl
biBqdXN0IGENCj4+Pj4gc2luZ2xlIGFyZ3VtZW50IGdldHMgcGFzc2VkIHRvIEFTU0VSVCgpLg0K
Pj4+PiBTaWduZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+Pj4+
IC0tLQ0KPj4+PiB2MjogUmVuYW1lIG5ldyBtYWNybyBwYXJhbWV0ZXIuDQo+Pj4+IC0tLQ0KPj4+
PiBSRkM6IFRoZSB1c2Ugb2YgYSBjb250cm9sIGZsb3cgY29uc3RydWN0IGFzIGEgbWFjcm8gYXJn
dW1lbnQgbWF5IGJlDQo+Pj4+ICAgICBjb250cm92ZXJzaWFsLg0KPj4+IA0KPj4+IGluZGVlZCBj
b250cm92ZXJzaWFsLiBJIGZpbmQgdGhpcyBxdWl0ZSBjb25mdXNpbmcgYW5kIG5vdCBzb21ldGhp
bmcgSSB3b3VsZCByZXF1ZXN0IGEgdXNlciB0byBzd2l0Y2ggdG8gaWYgdGhleSB1c2UgdGhlIGxv
bmdlciB2ZXJzaW9uLg0KPj4+IA0KPj4+IFRoYXQgc2FpZCwgdGhpcyBpcyBtYWlubHkgYSBtYXR0
ZXIgb2YgdGFzdGUuIFNvIEkgYW0gaW50ZXJlc3RlZCB0byBoZWFyIG90aGVycyB2aWV3Lg0KPj4+
IA0KPj4+IEkgaGF2ZSBhbHNvIENDZWQgQmVydHJhbmQgdG8gaGF2ZSBhbiBvcGluaW9ucyBmcm9t
IHRoZSBGdXNhIEdyb3VwIChJIHN1c3BlY3QgdGhpcyB3aWxsIGdvIGJhY2t3YXJkIGZvciB0aGVt
KS4NCj4+IA0KPj4gVGhhbmtzIGFuZCBoZXJlIGlzIG15IGZlZWRiYWNrIGluIHJlZ2FyZHMgdG8g
RnVzYSBoZXJlLg0KPj4gDQo+PiBNb3N0IGNlcnRpZmljYXRpb24gc3RhbmRhcmRzIGFyZSBmb3Ji
aWRkaW5nIGNvbXBsZXRlbHkgbWFjcm9zIGluY2x1ZGluZw0KPj4gY29uZGl0aW9ucyAoYW5kIHF1
aXRlIGEgbnVtYmVyIGFyZSBmb3JiaWRkaW5nIHN0YXRpYyBpbmxpbmUgd2l0aCBjb25kaXRpb25z
KS4NCj4+IFRoZSBtYWluIHJlYXNvbiBmb3IgdGhhdCBpcyBNQ0RDIGNvdmVyYWdlIChjb25kaXRp
b24vZGVjaXNpb25zIGFuZCBub3Qgb25seQ0KPj4gY29kZSBsaW5lKSBpcyBub3QgcG9zc2libGUg
dG8gZG8gYW55bW9yZSBkb3duIHRvIHRoZSBzb3VyY2UgY29kZSBhbmQgaGFzIHRvIGJlDQo+PiBk
b25lIGRvd24gdG8gdGhlIHByZS1wcm9jZXNzZWQgY29kZS4NCj4+IA0KPj4gT3V0IG9mIEZ1c2Eg
Y29uc2lkZXJhdGlvbnMsIG9uZSB0aGluZyBJIGRvIG5vdCBsaWtlIGluIHRoaXMgc29sdXRpb24g
aXMgdGhlIGZhY3QgdGhhdA0KPj4geW91IHB1dCBzb21lIGNvZGUgYXMgcGFyYW1ldGVyIG9mIHRo
ZSBtYWNybyAodGhlIHJldHVybikuDQo+PiANCj4+IFRvIG1ha2UgdGhpcyBhIGJpdCBiZXR0ZXIg
eW91IGNvdWxkIHB1dCB0aGUgcmV0dXJuIGNvZGUgYXMgcGFyYW1ldGVyDQo+PiBpbnN0ZWFkIG9m
IGhhdmluZyDigJxyZXR1cm4gQ09EReKAnSBhcyBwYXJhbWV0ZXIuDQo+IA0KPiBFeGNlcHQgdGhh
dCBpdCdzIG5vdCBhbHdheXMgInJldHVybiIgd2hhdCB5b3Ugd2FudCwgYW5kIGhlbmNlIGl0DQo+
IGNhbid0IGJlIG1hZGUgaW1wbGljaXQuDQoNClRoZW4gaGF2aW5nIGNvZGUgYXMgcGFyYW1ldGVy
IGZvciBhIG1hY3JvIGlzIHJlYWxseSBub3QgbmljZSBJIHRoaW5rLg0KDQo+IA0KPj4gQW4gb3Ro
ZXIgdGhpbmcgaXMgdGhhdCBYZW4gQVNTRVJUIGFmdGVyIHRoaXMgY2hhbmdlIHdpbGwgYmUgcXVp
dGUgZGlmZmVyZW50IGZyb20NCj4+IGFueSBBU1NFUlQgZm91bmQgaW4gb3RoZXIgcHJvamVjdHMg
d2hpY2ggY291bGQgbWFrZSBpdCBtaXNsZWFkaW5nIGZvciBkZXZlbG9wZXJzLg0KPj4gTWF5YmUg
d2UgY291bGQgaW50cm9kdWNlIGFuIEFTU0VSVF9SRVRVUk4gbWFjcm9zIGluc3RlYWQgb2YgbW9k
aWZ5aW5nIHRoZQ0KPj4gYmVoYXZpb3VyIG9mIHRoZSBzdGFuZGFyZCBBU1NFUlQgPw0KPiANCj4g
QWxvbmcgdGhlIGxpbmVzIG9mIHRoZSBhYm92ZSwgdGhpcyB3b3VsZCB0aGVuIG1lYW4gYSBtdWx0
aXR1ZGUgb2YNCj4gbmV3IG1hY3Jvcy4NCg0KVW5kZXJzdG9vZCB0aGVuIG15IHN0YXRlbWVudCBv
ZiBYZW4gaGF2aW5nIGFuIEFTU0VSVCBkaWZmZXJlbnQgZnJvbSBhbnkgb3RoZXIga25vd24NCmFz
c2VydCBzdGlsbCBzdGFuZHMsIHRoaXMgaXMgbm8gc29tZXRoaW5nIEkgd291bGQgdm90ZSBmb3Iu
DQpJZiB5b3Ugd2FudCB0byBrZWVwIHRoZSBjb2RlIHRoZW4gbWF5YmUgdXNpbmcgQVNTRVJUX0FD
VElPTiBvciBzb21ldGhpbmcgbGlrZSB0aGF0IA0KYW5kIGtlZXAgQVNTRVJUIGJlaW5nIGEgc3Rh
bmRhcmQgYXNzZXJ0IHdvdWxkIGJlIGEgZ29vZCBpZGVhLg0KDQpSZWdhcmRzDQpCZXJ0cmFuZA0K
DQo+IA0KPiBKYW4NCg0K


From xen-devel-bounces@lists.xenproject.org Wed Feb 16 09:47:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 09:47:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273896.469196 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKGuk-0000a1-Li; Wed, 16 Feb 2022 09:47:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273896.469196; Wed, 16 Feb 2022 09:47:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKGuk-0000Zu-Ik; Wed, 16 Feb 2022 09:47:58 +0000
Received: by outflank-mailman (input) for mailman id 273896;
 Wed, 16 Feb 2022 09:47:57 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Gpsw=S7=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nKGuj-0008SA-89
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 09:47:57 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8492ea3f-8f0d-11ec-8eb8-a37418f5ba1a;
 Wed, 16 Feb 2022 10:47:56 +0100 (CET)
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur03lp2059.outbound.protection.outlook.com [104.47.10.59]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-5-92T6N7EaO1GhpZhnwFmYWg-1; Wed, 16 Feb 2022 10:47:55 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DB7PR04MB5994.eurprd04.prod.outlook.com (2603:10a6:10:89::24) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.19; Wed, 16 Feb
 2022 09:47:54 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4995.016; Wed, 16 Feb 2022
 09:47:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8492ea3f-8f0d-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645004876;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=wrjV+vLVA73SOFP6R3lpOVxB9Z2Z5MqTybnTbxuoqRc=;
	b=hK3PAYnjVK63ZQMoa/n6HBD5hZ2VifI+L/PvggZTTjg32BiYaGAepTH/T5S/IxSNMDcKdc
	/fSlIEVqJq1WXwGvbSdyxbmiQcomdcYqHxsRSRivcgBKzMVebhigMsCKGpUBpMYEnOsgxQ
	cM12YzzWx4G5JjzSXb9kRrOOO0TpviM=
X-MC-Unique: 92T6N7EaO1GhpZhnwFmYWg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=k4g78f2Cax6A/43wI2u6/tlL5quJzjcSQ7rNZzbesQoick+YS6QaMEN3qSIByCGRGAdf7T7mbcl9qn6RyIAAkArKZf5dn0iFWLtf9iEc4iNN0B1HqPMvlBmlmHWBpe/AxK4mFa/0Uvb2T+xg5js1Q38W1IJTG4zg9eKHHzzlohoHH/soW9sGNrKVBtBNf5V9VvYoAVpvyh3I6C0NszmLYE5bviKuTUULq4sG/WekikhZfaRsJJOO0cJgi9aCBPZT3svCeknJW2MW1LO7drq0HY9IpBKJlzbi6PloHqEkClB5ZbHkv44MP3Dnmyl6hlxp1v84tfJToSNcGmGWR6jhmQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=qJlSCB8e43RnlrcgLKPcBNvQmylBelKT3Fb3SbRaTxw=;
 b=Hqulem0vlLnEvjgbgpB+aFmX8Y/W3P9k2k36SYw8PUFlzmixQ9n4Myem/YhYnhh6YPVYlgFIE6vutRMjHDqEva9/EPBQFvsPuJPfDZinW/OMWchGi3GFcAV6gCqAazdb3s5yK82xIlKTI+SLbK/D7CebmtcLr2AkVyQlQUZBfeieUb3OCtki3T0sBPQMbSFk/GJx2t1l87CUowx+cTsqblGjj0wgOdSC9Iox9Ezf2Nqrm91kJe3rC6k7q0rnBW/lPJugoZkBj1b5mx1aeBaTsfvCKOfJ1xJEJigArD8Ygptm0Ix9i8aq0nFq/bRmWqMcy2T+Yvhr02K8X7Skjr8j4w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <c5657f85-e3c4-9c39-1a67-b5162b1f86ef@suse.com>
Date: Wed, 16 Feb 2022 10:47:52 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH 2/3] x86/clang: add retpoline support
Content-Language: en-US
To: Roger Pau Monne <roger.pau@citrix.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220216090300.9424-1-roger.pau@citrix.com>
 <20220216090300.9424-3-roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220216090300.9424-3-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM5PR0202CA0003.eurprd02.prod.outlook.com
 (2603:10a6:203:69::13) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: aa400f62-252c-4093-78eb-08d9f1316759
X-MS-TrafficTypeDiagnostic: DB7PR04MB5994:EE_
X-Microsoft-Antispam-PRVS:
	<DB7PR04MB5994F0661C541A7F8DE3677CB3359@DB7PR04MB5994.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5236;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	W6fhF5XdFec4s2ZnLhLClhjGpmiiiAUemqMcb3/mPh1GWnzuXLML3jtJBPwUkwnx6zEk7N8hE+yGkXl45coEKPkY+w0fJryVrqJ+djA8vObvBO8t8ZKOd9AKvAd6GkYcL6FfIAPqjRCC655YO5Al6NuGqR+kA2VOv2UqyZ0OoJ+MrfLmXNPyS/eqLY/bEeFAXzvRsBoBudSpvtHbCwc7lQ0nQvysPY3uCgux2jPPNa9JTkvl6u5mRFla7q1y8eiFTEVBSLb7dadpZoIZgl/O1aUNI1qOVPxuBo6izn7xIE06zaGEi+5/CNT8UmDyV0bgoE/f7jqAkKx2WRveYzo7xqKEy/i65Vm5KY2j52dy7aQtxRAkwkKTUvsgz4l8EtSiOyAzgn4P0hT8BkCD14EihrBYYxiSyRzc0mwT24EFQxvT4S5WBRAM/sRBE9Oa7wwB7SiPlC9XreVyijukTCIJmG1kjmwdt1K8+NUEAxuJMOat01xekcqlqm5ZU+FF8ctPRc2gPTXGWP9u5LRiMbI9njlUwTthFDniFp3Ts9sJG7fuW/Q+jXkQTa8rGLs5Cm2DG0oqkevpiRwoe2NpsXApoPrmvOhIyQPOPRl/adD8w03mmEgoSkozkD+4hlUSV5QCuVtbRylVfLycgX39MIk/hKmmHYJngBXlDu07ZV1lKY+We0WJe2+u+mREG+M7k71Zy4EY9vjUowv2w6wmJcgm9FW0mpH1fknFK7wnsHrQ37ph84sUGe3oTtBSk6EuQLSC
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(38100700002)(2616005)(6916009)(54906003)(508600001)(316002)(36756003)(6486002)(186003)(6512007)(26005)(6506007)(31686004)(53546011)(83380400001)(66946007)(4326008)(66556008)(66476007)(8936002)(8676002)(31696002)(86362001)(5660300002)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?mVCp5+D0/E9AVwh9YEYCMKiSU1jaLb6eb5vW6ReERGs0/oOXJQZTEg/3tqUr?=
 =?us-ascii?Q?VIxSfJd0VUUa6xf59r++k8yuBRCGMTOI9kgR9aLM10mH+5ApjXLA2cCGmcp4?=
 =?us-ascii?Q?hSQZCD379NZ8HsKuIcEx2RPDBIpi70YaHYLL1VOB5UHTORj2EOgZy15kswj0?=
 =?us-ascii?Q?6wZc/jU45it7kwdtqHXYq9DORFJ5zjQah4E9MIr9g87w24f8cNtm1ovBajpr?=
 =?us-ascii?Q?+JCbgioDBzmrHrUiHPki1GyJYMYrla33Wb9jP8opFPf8ktKoSEPp2o9scUxu?=
 =?us-ascii?Q?yjDc0otm8825cvAoCVBlcDFLe5+Ato1SZsc8b8n3pZA9bq7gkFYFuiPx/VyY?=
 =?us-ascii?Q?YZcWxKZS9AXdMFoQJyvvzyKI5bw5Xitetp7SVAeuNylr4Kcqeg+GAlQDsW1q?=
 =?us-ascii?Q?6YedW/5cYQaBhWpLbNlRagRIm2UvOGF5XOmIIXiVdJsCam0dXK2z7pKx2L7y?=
 =?us-ascii?Q?pzUvLFddih4DfXytL8Am9ebDeOWEz5DlYJvt9FvqzKKHb2Se9CfOwKzkItSV?=
 =?us-ascii?Q?ZieKRPZVHlGHmbbQnRhvAK/oHruSd7Nj0KiQSf+8K3Rgb/U9Qnu6YaqdVi5A?=
 =?us-ascii?Q?puGsuVXI9KpvFkSaKh+8Afloy3bq+VBs8GLmkN7BirNyHszhFdiA+BOLxuAC?=
 =?us-ascii?Q?7UQP5yZ28ihSCII13NaAEcQQN8hZLH9buUmv2GIyEGDYeGrZXZvDkJMj0LPB?=
 =?us-ascii?Q?0j7S//Urm9olHw0XPNylbOJBoEX9447zNTbPS9O6wedcXAMHZ79ZVecskNEA?=
 =?us-ascii?Q?x3u/7QuoOHBjMOB6rcN43FNIxDJv30FuirsOF7vBm/cDp+HJT0GjVb8SNNts?=
 =?us-ascii?Q?c1vfxyaBC8IH40x1qn7E3NLy0YMunpbZGxFnCYCO7MSmU6Qoy1bNXsLT8QAr?=
 =?us-ascii?Q?cY5FkixVfA+XTe8NDV5Hw42NUK4Q77rxE+KuORIqDQQ4VwgHxO3hvRziF2Ss?=
 =?us-ascii?Q?6MjJPGxGEay1fo1L3wr1MDGDtLqPm/d31wOLfCnUK5u2hg08G69lI+LDlqzZ?=
 =?us-ascii?Q?hn9cCsin60qPhJszdgR9t57dI7Qq2B3SyBVbEa4xR8Bt3BbCuQDuk9AO8ndi?=
 =?us-ascii?Q?VuKHZ+KHWmUZqAUF9EBoS7FwiokLuKdpN0zvPJAaBODDaZtwwttG9SqOAIhV?=
 =?us-ascii?Q?jdwP9PW7d9rg9nsAgHc5xZETuagUPLg6Q7MXLEDPVkGzEKRo676npTJ6z164?=
 =?us-ascii?Q?8fo0L8vCYXfSO9TRrKvKL24/C6mxj4MyRM/s5bNZJZ/llHwDeFGA6sKmnNAl?=
 =?us-ascii?Q?sEdoSMu4CHCNisJHRT2YXH+hCQfrWkD+Cxu2OQbxNP+VChvhObKWQ5eVDmnW?=
 =?us-ascii?Q?Vu8fug+OwHc7eZvkSvIF9ecKNe5g/Hlw/m1CQYY83st9Xgl11mZNvbPY+vT4?=
 =?us-ascii?Q?CflFseSga0EoqzU8xiTvCTuGjL+/IoX7oZn5j7uCCMneQ5IcvQztzuzt5qcq?=
 =?us-ascii?Q?ZnSlV+jOW0v2Y40cJxpha+QRfmHOfT4yxtrQvVnXHEYRF5+DRDkCS9E3tsn1?=
 =?us-ascii?Q?aF877RNL91wEzcOHXrIPj0+HakaAsGunji2d03lLyb406Ri1NajLmxFZ4fn2?=
 =?us-ascii?Q?qwv0aGsjcVWB2UhF+sfUxpLsVgomBC1hQN1fWHlseiB1K97Nkl6cDt5/+7xj?=
 =?us-ascii?Q?nN6wAKwT+1mayISRJBmVzFs=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: aa400f62-252c-4093-78eb-08d9f1316759
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2022 09:47:54.0337
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: U6gTZc6BS1BGkNKZI9ecz5cCceiZvTZF38Bz7Y4bVftVdDkUefHkt6jaxVIB40XltrwQMa+I73TcYO/JPAZUQQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB5994

On 16.02.2022 10:02, Roger Pau Monne wrote:
> Detect whether the compiler supports clang retpoline option and enable
> by default if available, just like it's done for gcc.
>=20
> Note clang already disables jump tables when retpoline is enabled, so
> there's no need to also pass the fno-jump-tables parameter.

That's one of the secondary gcc side arrangements. What about the other
(-mindirect-branch-register)?

> Reported-by: Jan Beulich <JBeulich@suse.com>

That's Andrew, not me?

Jan

> Signed-off-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>
> ---
>  xen/arch/x86/Kconfig | 5 ++++-
>  xen/arch/x86/arch.mk | 3 +++
>  2 files changed, 7 insertions(+), 1 deletion(-)
>=20
> diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig
> index 2cd713724f..fe00b4598b 100644
> --- a/xen/arch/x86/Kconfig
> +++ b/xen/arch/x86/Kconfig
> @@ -35,8 +35,11 @@ config ARCH_DEFCONFIG
>  config GCC_INDIRECT_THUNK
>  	def_bool $(cc-option,-mindirect-branch-register)
> =20
> +config CLANG_INDIRECT_THUNK
> +	def_bool $(cc-option,-mretpoline-external-thunk)
> +
>  config INDIRECT_THUNK
> -	depends on GCC_INDIRECT_THUNK
> +	depends on GCC_INDIRECT_THUNK || CLANG_INDIRECT_THUNK
>  	def_bool y
> =20
>  config HAS_AS_CET_SS
> diff --git a/xen/arch/x86/arch.mk b/xen/arch/x86/arch.mk
> index 2da4bdb1ed..f2aa2a515f 100644
> --- a/xen/arch/x86/arch.mk
> +++ b/xen/arch/x86/arch.mk
> @@ -47,6 +47,9 @@ CFLAGS-$(CONFIG_GCC_INDIRECT_THUNK) +=3D -mindirect-bra=
nch=3Dthunk-extern
>  CFLAGS-$(CONFIG_GCC_INDIRECT_THUNK) +=3D -mindirect-branch-register
>  CFLAGS-$(CONFIG_GCC_INDIRECT_THUNK) +=3D -fno-jump-tables
> =20
> +# Enable clang retpoline support if available.
> +CFLAGS-$(CONFIG_CLANG_INDIRECT_THUNK) +=3D -mretpoline-external-thunk
> +
>  # If supported by the compiler, reduce stack alignment to 8 bytes. But a=
llow
>  # this to be overridden elsewhere.
>  $(call cc-option-add,CFLAGS_stack_boundary,CC,-mpreferred-stack-boundary=
=3D3)



From xen-devel-bounces@lists.xenproject.org Wed Feb 16 10:00:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 10:00:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273908.469208 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKH6q-00036B-VD; Wed, 16 Feb 2022 10:00:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273908.469208; Wed, 16 Feb 2022 10:00:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKH6q-000364-R1; Wed, 16 Feb 2022 10:00:28 +0000
Received: by outflank-mailman (input) for mailman id 273908;
 Wed, 16 Feb 2022 10:00:27 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nKH6p-00035u-I8; Wed, 16 Feb 2022 10:00:27 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nKH6p-0004nu-FW; Wed, 16 Feb 2022 10:00:27 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nKH6p-0004qH-1F; Wed, 16 Feb 2022 10:00:27 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nKH6p-0001lL-0n; Wed, 16 Feb 2022 10:00:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ijzd62xUzpqjs1/+JMu9Yu+QsrnDnhAeuq0+OvmMfmU=; b=WY5B+nx6ji57XGhDSTv1nVJbJo
	HFXWQXuIjMwNfkmmNcG/uZi4jsRmJzwOj5NR9rRJhxd925/VkQbrsD24r4Ix96IqhoUMsoQsaXjxb
	2NnxMHzbBeqxkFCYrCMSyXd+r7CjO9ra97BSJricupGgnXl7Axyms8qu24EYv38qYwwA=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168128-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-coverity test] 168128: all pass - PUSHED
X-Osstest-Versions-This:
    xen=e7c2017cf4a91ab6a0fea6adca2d9dd2ab1603b0
X-Osstest-Versions-That:
    xen=87319afb96973213ec0a76270d93696f3b8d6743
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 16 Feb 2022 10:00:27 +0000

flight 168128 xen-unstable-coverity real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168128/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 xen                  e7c2017cf4a91ab6a0fea6adca2d9dd2ab1603b0
baseline version:
 xen                  87319afb96973213ec0a76270d93696f3b8d6743

Last test of basis   168100  2022-02-13 09:18:29 Z    3 days
Testing same since   168128  2022-02-16 09:19:44 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Jan Beulich <jbeulich@suse.com>
  Norbert Manthey <nmanthey@amazon.de>
  Roger Pau Monné <roger.pau@citrix.com>
  Stefano Stabellini <sstabellini@kernel.org>
  Stefano Stabellini <stefano.stabellini@xilinx.com>

jobs:
 coverity-amd64                                               pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   87319afb96..e7c2017cf4  e7c2017cf4a91ab6a0fea6adca2d9dd2ab1603b0 -> coverity-tested/smoke


From xen-devel-bounces@lists.xenproject.org Wed Feb 16 10:31:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 10:31:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273926.469223 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKHaY-0006QX-Fb; Wed, 16 Feb 2022 10:31:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273926.469223; Wed, 16 Feb 2022 10:31:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKHaY-0006QQ-CT; Wed, 16 Feb 2022 10:31:10 +0000
Received: by outflank-mailman (input) for mailman id 273926;
 Wed, 16 Feb 2022 10:31:09 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=oYE0=S7=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nKHaW-0006Q9-Vf
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 10:31:09 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8b475459-8f13-11ec-8eb8-a37418f5ba1a;
 Wed, 16 Feb 2022 11:31:06 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8b475459-8f13-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645007466;
  h=from:to:cc:subject:date:message-id:
   content-transfer-encoding:mime-version;
  bh=2cmgVfLuMuBrQAmTr+tyhqnmu6SgrAgj21TG/LKd7uE=;
  b=Cf0ZZHVh12pnSqkyd+maMW0oVDtLtz14hxUA9eVG11HWDxpnBRJuXq2y
   57cnt42P+SK9tXX7mudluvlNk9iugYI26NCgcnZlYIfm87iKv586dLlsm
   pU9mh9NX7qQ0bNyo+qzNB8x/uqsBYvNcEWf4igkVFSMgD4/IR9MLLMFjq
   8=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: cpyNvdsXeWSy/GVindAHOYUTyIG1OMciGpmzP+0JG5tfnx8lrWqpNCAUPuL8JtvDHH+tTvZIkg
 qbyqtVrvNe+sle4A7H3rVQLOu8ZfCJQk6Ir7x8/ayaxoi51c1p3iGgyZRrT8EsPIor+5Fci/Yl
 ogiWwudaiTuNbbjMkKnMVwG5iJa2ReoP9cy+0aClzB4kKj3eZLBK/kH3kYQj63Va6RMeoH/1dg
 8G813WeOTVxBzKFS6/1PbP/gXhSbs3SX5t8afC9+IVWFHmIU/xM1OGQJI27Dir2xmVgecrsdpw
 b3m+jeJwNdQxbt7TaXSw4DI1
X-SBRS: 5.1
X-MesageID: 66561505
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:rEGkmKrPdtzbjCGSEV3IqI3+cGxeBmJ2YxIvgKrLsJaIsI4StFCzt
 garIBnXOPvfYmqkLdFyPYy3oE8H75HdytNrTlZppXs1Fy0WoJuZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlZT4vE2xbuKU5NTsY0idfic5Dndx4f5fs7Rh2NQw24HnW1rlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCnZyiFSMPO6nypLgUCAFHPgRzY5xIwKCSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFJkYtXx6iynQEN4tQIzZQrWM7thdtNs1rp4QQKiHO
 pJEAdZpRB/pPS9QeQ5IM58vjraJv33hejdfiU3A8MLb5ECMlVcsgdABKuH9eNOQQt5Otl2Fv
 W+A9GP8ajkBL8CWwzeB9nOqh8fMkDn9VYZUE6e3ntZyiUCX7nweDlsRT1TTice+jkmyStdOM
 Xs+8yAlrbUx3EGzR9y7VBq9yFaOswQAQdNWH6s/4RuU16vPyw+DAy4PSTspQNA5sdBsbT0s2
 EWAk97gCXpoqrL9YWKQ8PKYoC2/PQARLHQefmkUQA0d+d7hrYovyBXVQb5LEqS4k9n0EjHY2
 C2RoW41gLB7pcwW06S2+3jXjjTqoYLGJiYq4i3HU2Tj6Rl2DLNJfKTxtwKdt6wZat/EEB/R5
 xDohvRy8sgOH82psimJftlRFeqx+NugPWPtj2ZwSsxJGyuWx1aveoVZ4TdbLUhvM9oZdTKBX
 HI/qT+997cIYiL0MPYfj5aZTp1zkPO+TYiNuuX8M4IWCqWdYjNr682HiaS4+2n22HYhnqgkU
 XtwWZb9VC1KYUiLIdffegv87VPJ7n1mrY8wbcqip/hC7VZ4TCTIIVviGAHTBt3VFIve/G3oH
 y93bqNmMSl3XuzkeTXw+oUON10MJnVTLcmo95AGK7fZc1s3QTtJ5xrtLVUJIdENc0N9zLmgw
 51AchUAlAqXaYPvdW1mlUyPmJuwBM0i/BrXzAQnPEqy2mhLXGpcxPx3SnfDRpF+rLYL5actF
 5EtIpzcatwSGmWv02lMNvHV8d09HClHcCrTZkJJlhBkJMU+L+EIk/e5FjbSGN4mVHrn75Bv/
 Of5i2s2g/MrHmxfMSofU9r2p3uZtnkBguNiGUzOJ9hYYkL394Z2bSf2i5cKzwskcn0vHxOWi
 FSbBwk2v+7Ir9Nn+dXFn/nc/YyoD/F/DgxRGGyCteS6MizT/2yCx45cUbnXIWCBBT2soKjyN
 /9Iy/zcMeEcmAoYuYRLDLs2n7k14MHipuEGw108TmnLdVmiFphpPmKCgZtUrqRIy7IA4Vm2V
 0uD98N0I7KMPM+5QlcdKBB8NraI1O0OmymU5vMweR2o6Chy9buBcENTIxjT13ANcOoraNsom
 L5zttQX5gqzjgsRHuyH1i0EpX6RKnEgUrk8ss1ICoHclQd2mEpJZobRC3Gq7cjXOclMKEQjP
 hSdmLHG2+ZH3kPHfnc+SSrN0O5aichcsRxG1gZfdVGAm96Djf4rxhxBtz8wS10NnBlA1utyP
 EltNlF0evrSr2s52pAbUjD+ARxFCT2Y5lf1mgkAm2DuRkW1UnDAcT8mMuGX8UFFq29Rc1C3J
 l1DJLoJhdoyQPzM4w==
IronPort-HdrOrdr: A9a23:z+9xaqPFvnREVsBcTy/155DYdb4zR+YMi2TDiHoedfUFSKOlfp
 6V8MjztSWVtN4QMEtQ/uxoX5PwPE80lKQFm7X5WI3CYOCIghrQEGgP1/qG/9SCIVyBygc+79
 YZT0EWMrSZZjIW/KWKgjVQe+xQv+Vvm5rY49s2oU0dKT2DPMpbnntE40ugYwVLbTgDIaB8OI
 uX58JBqTblUXMLbv6jDn1Ae+TYvdXEmL/vfBZDXnccmUOzpALtzIS/PwmT3x8YXT8K6bA+8V
 Ldmwi8wqm4qfm0xjLVymeWxZVLn9nKzMdFGaW3+4MoAwSprjztSJVqWrWEsjxwiOaz6GwymN
 2JmBskN9Qb0QKnQkiF5T/WnyXw2jcn7HHvjXWCh2H4nMD/TDUmT+JcmINwaHLimgUdleA59J
 gO83OStpJRAx+Ftj/6/cL0WxZjkVfxiWY+kNQUk2dUXeIlGfNsRLQkjQJo+ao7bWLHANhNKp
 gsMCic3ocaTbqiVQGWgoE1q+bcHEjaHX+9Mzw/U4Kuon1rdUtCvjslLfok7wI9HaIGOuh5Dt
 v/Q9dVfcl1P7QrhIJGdZE8qJiMeyXwqSylChPhHb2gLtBCB07w
X-IronPort-AV: E=Sophos;i="5.88,373,1635220800"; 
   d="scan'208";a="66561505"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=dyouVvfQVjL2PVbYCCm9yeySVpxNoIrDX+qEKuLcLkGAXFd+UL66EiinQhI3vf9d1dcZFL8YL/XaB/TTsF1+I20EDT2qJO3x1esrqnZ9mmz5KrGGwHGrK4PLYGqW/XFRSmJzKjQCl+03ftX2HHEygmAyhD657NxgH9FBZSt0TvqkomW5whvl6Z5YShBzvC5H2ZDDRpZryi5MzBLVrLgEB7zU8fK4KPb54ncuHOe6AageddsGHgIESON/WeNeNCKvWWpmkrEdQlC/H8FzCyfCCifXMItP8wO0Lg/etd7jFJOJtM9OIBVXjjglt7ou+mCVUUe8DqjbNFIhVL09JxE2VA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=xTyBPc0ixC3wltOLWbiErHLOypalZnlfv/Qcb4R8izM=;
 b=aggHtJatkzm+jwLMH2Yxvh3fBYxm4z6E/ldtZbob8ZV4w4f5uDIiihxH6lksyPaPDSzzx4Iqc8Zpf9oXQRtKxNAj6+IVsvIYW6ByZeGOJAvK2e6HPcg1O+EPwQoYR36/Yyf22VP+BXnyvnBN+20aY7syaXKbaZ6uAuNiU8PbCCgBeAGH1lcE2MpTnXYEfbvYWmg+DLoU1KozaROFp+trF7HRk6xE7qFKqA0wMzubsH8BVd3rGdIvuPz0VrNz888bdZykAwpiTC/4CBswe9EIfhENrRdCLONtK9EcCcU7lO94DiAvBRhPSNOLLlmwMuWqifol4WaSBwdJgx6MenF/pg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=xTyBPc0ixC3wltOLWbiErHLOypalZnlfv/Qcb4R8izM=;
 b=rWvKlD7Xp+10xDp8NY2GxHzyYU2Kvk5NAVJVHCN1evxKYPIrqtIiWxuTfTBVVhNgdq8pD7AtXXeuU7aQbiOBr4QXvB54q3l50A2nv2W8E1csnawvmAqZ1TUyyqasi+py7eBROIXXMu6eTrA3zdC2JV9eIrN+gMauZZaTG2GyThE=
From: Roger Pau Monne <roger.pau@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: <dwmw2@infradead.org>, Roger Pau Monne <roger.pau@citrix.com>, Jan Beulich
	<jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu
	<wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Julien Grall <julien@xen.org>, Stefano Stabellini
	<sstabellini@kernel.org>, Juergen Gross <jgross@suse.com>, Paul Durrant
	<paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>, "Volodymyr
 Babchuk" <Volodymyr_Babchuk@epam.com>
Subject: [PATCH v2 0/5] x86: extended destination ID support
Date: Wed, 16 Feb 2022 11:30:21 +0100
Message-ID: <20220216103026.11533-1-roger.pau@citrix.com>
X-Mailer: git-send-email 2.34.1
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO2P265CA0079.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:8::19) To SA0PR03MB5610.namprd03.prod.outlook.com
 (2603:10b6:806:b2::9)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 6bc99fad-fe4d-43ce-36c8-08d9f1376731
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6256:EE_
X-Microsoft-Antispam-PRVS: <SJ0PR03MB62569AC9FB3782B7A907A6128F359@SJ0PR03MB6256.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: lb+vkWuTvhPd9247JzbarAk08YupkmI1tOD3YDVNMS0ul5UQPXLW4agEwICPK12O32FG0ZHX/uvyVFl+1ndXR5DIv9bbGuNKq43R0GcA8v0GclnnueOKLWHHy2PCMoRY6suqCj4BUo0r8pzXQdbIWaTwNPSvAf7O7R37iktjKa/YURNakOTWvNsvkx3eWnA79AfUyAuDYmB05SOh0hhmNdHAOy04zanw8f4rjZXI2Iy3/023znQkHWEdhkR+fk5JAN930GEW2ziFElwLbF5bAs2Qd0wHQURpkweNgFaAHNuz8HXzFHfbVDySTT+9JDBApOE/jMThKjPk2SUtIZIDK4OQb2bYldp3Gh7v4jF5v7ULhWXtHiLPu6SJGGDuGzwzguCwi8DsfX6da2HDDGM3TkpMmjBeFDQ8QyLUz7ZgwvAGT8mO8pZZWrrrpTbaVG4WH5Bsb1tfstUtb4UFvYhHkXxSYAv5YAv34MfMgW4MpdrABQcy2X5Oqy2Nv4zUKzzPSx0ZEc5EYMc1VkJkt7K9IgDvegc02J87d/X8IlNcwL181Trm8tQnPg+aurO+JFZ1kt9kULhD4A+SdEH7hJrIwN/BRvttdn6Pq3/tMx+n2H0d10L93aoXxMZpIqZeJ3qIgz5cAkMAe8OZ1L+IqLAcMB3rHv4wTOfJsH9MiR/RBAP35j3UTAObrt/c+dOzqypmueDiMqUto7CfmPx+b7DwcULDzCzBUzGxuS+UcUQj0TA=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA0PR03MB5610.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(8676002)(2616005)(66946007)(6506007)(6512007)(316002)(26005)(1076003)(66556008)(508600001)(86362001)(6486002)(6916009)(6666004)(54906003)(966005)(82960400001)(66476007)(83380400001)(4326008)(38100700002)(36756003)(5660300002)(2906002)(8936002)(7416002)(186003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L3BsUGlUS3E4eEFScStIanpoSE1kSzFhMGMwZHJRUUI3YjVxTUk0dUlTZXhi?=
 =?utf-8?B?Qlhpak5HUTJsOVVsMkhZcGRBeE5BQVkzbmZJcUx2S2VzM1BOZkY0VENsa1hG?=
 =?utf-8?B?aDdHaGx6eFdCOGlaNEZhQTdVSjJsc0FJRUR3TTBYTHVpWDh4dWRpbWdrSUY2?=
 =?utf-8?B?N0dwNEZIRDY3eGxhNkp2akd2QUEybS8yVDhLTWFwN2hNcTlrbnB6NjRvNnhp?=
 =?utf-8?B?ekN5VjdYbkpDbXI3YTVpTFdXN1FvdU9zYU1JUnB6YjYwR3JxaFpMTVF5YThU?=
 =?utf-8?B?cm9SMHBSeVN1eU00dnd4R0E5L3ZUY0pLWmJIQmdBWExtM1d3SHJJdE0zWGd4?=
 =?utf-8?B?dS80VUFkdTVDTmtJUURTcUtRbXYwMXRCd0hYMW50TXpTNlBSSzA3bUlXOUdB?=
 =?utf-8?B?a05zeHUxdmtZR2hQR1BkZ3JkajRhOFNCZlRtNldNQTBkOHVCZVBQeXBBYy9v?=
 =?utf-8?B?NnlBdjhQaUJrRzJWVngwWWhCWng5R2UxNmdFamgwV2xjRGJTaVFvRlNaNkZO?=
 =?utf-8?B?andCUzJCanJ6Ui92a2phenh0b0Z6dys4cDhhU09IVGJ4T1BmVUhhQTNhbU9D?=
 =?utf-8?B?bDVwM0MxcktqR1U3MFl2S0lwZUZqRzU1R0duU2JYWXhHZGxEQThrNTNWY08x?=
 =?utf-8?B?cm1YUGpDNTZDRUtMeG1XcjUxcnFyMkVXZmkyM3FZeE1oMElMMnBJT0lCdlNk?=
 =?utf-8?B?cHNoOHlaOTBXOGFMWEJtOTUzNVNIRStYbkEwa0xMcFNUTG96Wm94SWJNbTJz?=
 =?utf-8?B?bWVITEFrMVZYNVF3aGtTb2tVQUhRZnV6elFxcDgxSGhZVmcyTnNXZEZzM0VX?=
 =?utf-8?B?YklVWmI5TkZ3N0lzakIyZ3pNbCtCd0dIcllQVVlvZ1VkT0ZBbGVUc3dtU21K?=
 =?utf-8?B?Tm5lTmFwUjNsQ1RaeFAzVjZrTnlOeVh0TTNPbDNkMEErL0U0ZUlWQjlDclFL?=
 =?utf-8?B?anAwQkdmUnZBS2l5NWt2cGJSUTN1YStKZmh5WlZXbHhSL3Ava0xlNlROVXNK?=
 =?utf-8?B?Q1NyK2QvdWRzajZFRzNzWTRKa0Jadkg2V3RjTmpRWmR3ZE50YUhGUXdIbWwy?=
 =?utf-8?B?OXFzZG1uWjVSMTBnd25zYmwzK3YxMk5CazZ2d250dDBQNUFmS2NVY241OGFS?=
 =?utf-8?B?QzI5dE0vdmpvQXc3a2dtM0tKUFFKRjlHLzBZNzJ0Z25FQ2hIeGxFcjNUaVpH?=
 =?utf-8?B?eHkxTzRFTFA3TXZ6M0xzVlVYQXIwaW9VNjFDZjJvdmlEU1NLTW9mekJvRUpM?=
 =?utf-8?B?WU5sdWpXNGhuaWJrd3gxUS9kc0crTFFHZEZtWGFVaWhnQmZ1VjR1TE1SRGNN?=
 =?utf-8?B?T2V5WFNBT1ppM21jb2xtQlFMNXBKZkpMbEU2emIvSzJ0SnFxbktLWmsvMURw?=
 =?utf-8?B?Ym5qTm03YWhldnArSnQvNk9vd2lEUUtnb1VQVlY3cHdNNmh5OHRDMVRLSVoz?=
 =?utf-8?B?aEpuSXdBTHBvcytJWTZvYms4L2NXc3hRQkZ6VVFBelc5WXRXUXdVUDY1bmJw?=
 =?utf-8?B?R3BGSWdDOGkzNm5yRVJnTFB0aTF4OVpaSGZPT29mTUVZMzFtbURBc0N2NXZH?=
 =?utf-8?B?cmI4WXl2dlZlN29jU1hmbmJxT0xNYlNobm9UL09aZ1IwTElDN0RaOVNueWp2?=
 =?utf-8?B?WjlpNGFoOVhyaXBGcDFIYzIvQzIyVEhYQ0h2R2VoSTNORnF2d0pRZTVlU2l3?=
 =?utf-8?B?dElWM2tkRU1WYWxpWmdNMjN0dnV6SkhweU1QV1B5N3RkTWtDRmUyUktvM2dZ?=
 =?utf-8?B?MzRNMmJkWFB4UUh6YzY0MDZMSnJjMkVuczArZkR2eWxpeER0eklaYWswMHhF?=
 =?utf-8?B?VVhSY2VGTFg4ZXJycVV2ZG1hZWl3WktCMnRBbmRzaFcrN0tjZFFTSEp2OVlW?=
 =?utf-8?B?dW5hcVQ4WXVRWTNtM1hGdjhGSHZ5R3hCbjFndW5CNEM4MmxPeVNrNWU2STAy?=
 =?utf-8?B?blRxdnNONGwyU0t6cVg5MUdnekhJMVM1YVBzdHJ1ZHRpS1BiQ0tPYTVUU1Nx?=
 =?utf-8?B?d1dtbWtPTHpSWUxwS0MwSGRMNWZVTEVxNG9FbTlDS3NJSXJkY25oSkdpSnhl?=
 =?utf-8?B?cVhRL3NFOTBWLzJrdUxPdHdJYVpsUG1lZ2VRY1dFR2x0VHZrZFY1aFZPUVZW?=
 =?utf-8?B?anZ6aHlPK2p5QUlERWZ3TXByTmNwTjJpbTVuZTNsZjA2RUVRSmJZZnl2QUk0?=
 =?utf-8?Q?Paomh+v2pmHRRoaIKg9YWmQ=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6bc99fad-fe4d-43ce-36c8-08d9f1376731
X-MS-Exchange-CrossTenant-AuthSource: SA0PR03MB5610.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2022 10:30:50.8284
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yQDMQlF1tj0Q3EvqEB3b8KIHoIEtGqODoFmLczt//Crw014CfaRvU3Dkdq3phING3tvoeWNW01Ye3ZeYWY5ZbA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6256
X-OriginatorOrg: citrix.com

Hello,

The following series provide a tentative implementation of extended
destination ID support for HVM/PVH guests. A specification for the
feature can be found at:

http://david.woodhou.se/15-bit-msi.pdf

Patch 4 is the one I'm having more doubts about: it's the best thing I
could come up in order for emulators to signal Xen whether they support
parsing the extended destination ID in MSI message address field. This
is only required for device models that support PCI passthrough:
injection of MSI interrupts from emulated devices is done using
XEN_DMOP_inject_msi which already passes the MSI address and data fields
to Xen for processing.

I think we should likely consider patch 1, as it would allow the OS side
of this to make progress (since it's an already present feature in other
hypervisors) independently of the Xen side work.

Thanks, Roger.

Roger Pau Monne (5):
  x86/cpuid: add CPUID flag for Extended Destination ID support
  xen/vioapic: add support for the extended destination ID field
  x86/vmsi: add support for extended destination ID in address field
  x86/ioreq: report extended destination ID support by emulators
  x86/cpuid: expose EXT_DEST_ID feature if supported

 docs/man/xl.cfg.5.pod.in               | 10 ++++++
 tools/include/libxl.h                  |  8 +++++
 tools/libs/light/libxl_create.c        |  6 ++++
 tools/libs/light/libxl_types.idl       |  1 +
 tools/libs/light/libxl_x86.c           | 12 +++++++
 tools/xl/xl_parse.c                    |  3 ++
 xen/arch/arm/ioreq.c                   |  5 +++
 xen/arch/x86/domain.c                  | 10 +++++-
 xen/arch/x86/hvm/ioreq.c               |  7 +++++
 xen/arch/x86/hvm/irq.c                 |  5 ++-
 xen/arch/x86/hvm/vioapic.c             |  3 ++
 xen/arch/x86/hvm/vmsi.c                | 43 +++++++++++++++++++-------
 xen/arch/x86/include/asm/domain.h      |  3 ++
 xen/arch/x86/include/asm/hvm/hvm.h     |  5 +--
 xen/arch/x86/include/asm/msi.h         |  7 +++++
 xen/arch/x86/setup.c                   |  1 +
 xen/arch/x86/traps.c                   |  3 ++
 xen/common/ioreq.c                     |  8 +++--
 xen/drivers/passthrough/x86/hvm.c      | 11 ++++++-
 xen/drivers/vpci/msi.c                 |  2 +-
 xen/include/public/arch-x86/cpuid.h    |  6 ++++
 xen/include/public/arch-x86/hvm/save.h |  4 ++-
 xen/include/public/arch-x86/xen.h      |  2 ++
 xen/include/public/domctl.h            |  3 +-
 xen/include/public/hvm/dm_op.h         |  6 +++-
 xen/include/xen/ioreq.h                |  2 ++
 xen/include/xen/vpci.h                 |  2 +-
 27 files changed, 153 insertions(+), 25 deletions(-)

-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Wed Feb 16 10:31:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 10:31:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273928.469235 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKHaZ-0006Zz-5g; Wed, 16 Feb 2022 10:31:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273928.469235; Wed, 16 Feb 2022 10:31:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKHaY-0006WF-Te; Wed, 16 Feb 2022 10:31:10 +0000
Received: by outflank-mailman (input) for mailman id 273928;
 Wed, 16 Feb 2022 10:31:10 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=oYE0=S7=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nKHaX-0006Q9-Nb
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 10:31:09 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8be89e14-8f13-11ec-8eb8-a37418f5ba1a;
 Wed, 16 Feb 2022 11:31:07 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8be89e14-8f13-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645007467;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:content-transfer-encoding:mime-version;
  bh=5wpWq0tN4xgsFJ1RqLxQToz/62F/R49dfWtSuwedAS8=;
  b=bzGDrsmZ3xV7Bv0VNz4RvJjbwfupD86ilWjxlhOFM4SX7zqvZMLJNDhP
   kLSgxR9vIPI10uUkBE9zzjGLCgckHCAp7z5nUK1JDlvGHsxA1rWDyyCbN
   R5ZZgFE+bXd4UYDlK34JmABp5Dz5I/ZvStrF42sGGSsb8chqwzheWaFAn
   s=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: l9s/CC/67+Z/Ak4p6MqD2jRDxR9fIcFd+rrjm4ovNnX2CEqrU3XCTVQUA1uwUKyHfVAxTjtysX
 8hxjiVEr7eDNhSYaqLpnck90BasA8lGzNcrllV4v8r7fK0XP2/jE0fwdPQFJyiHmEYcrTUHya7
 AwEs9KSSy+qX12eSjWkSN7URZN5qLn5e0UIceCUX1TnNlzM0cqR+qUQkyee30jN7QrSjfeBTyU
 +sFvqnNyoCPGqE5blDUrSK2F6fiKPG8fsienlqeEPvEl9uHVmSdWbT8+wd6rWdbiyOdl5ijhbv
 NvNGDsCubsvR5fW+/Kd4agXU
X-SBRS: 5.1
X-MesageID: 64324541
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:tKQDfa05+wtRyT7PM/bD5XF2kn2cJEfYwER7XKvMYLTBsI5bpzYGz
 DRNXTvQOvbcamrwc91wPd/k9xsE68LWn9JjSAs+pC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkS5PE3oHJ9RGQ74nRLlbHILOCanAZqTNMEn9700o5wrBh2+aEvPDia++zk
 YKqyyHgEAfNNw5cagr4PIra9XuDFNyr0N8plgRWicJj5TcypFFMZH4rHomjLmOQf2VhNrXSq
 9Avbl2O1jixEx8FUrtJm1tgG6EAaua60QOm0hK6V0U+6/TrS+NbPqsTbZIhhUlrZzqhlv5/7
 OVn8tuMWQINNa7HmfYWQwd5DHQrVUFG0OevzXmXtMWSywvNcmf2wuUoB0YzVWEa0r8pWycUr
 6VecW1TKEDY7w616OvTpu1EnMMsIdOtJIoCknph0SvYHbAtRpWrr6Diu4MDhmtt2pkm8fD2T
 ZcyUyZ2ZwT8aj5fCAgnT8kxtfyuvyyqG9FfgA3M/vdmi4TJ9yRzzbzsPdz9atGMA8JPkS6wv
 Xna9m70BhUbMt23yjef9H+owOjVkkvTWo0IE6aj3uV3m1DVzWsWYDUUX1ampfiyimalRslSb
 UcT/0IGvaU0sUCmUNT5dxm5u2Kf+A4RXcJKFO834x3LzbDbiy6VGW0bFBZAbtI8vcM7TDBs0
 UWG9/v2ARR/vbvTTmiSnop4thvrZ3JTdzVbI3ZZE01VuLEPvb3fkDrGYNhHIITyyeHlHBX7w
 DuLviMumZQM2JtjO7qAwXjLhDelp57sRwEz5xnKUm/N0j6VdLJJdKTztwGFsK8owJKxCwDY4
 SNaw5T2APUmUMnV/BFhVtnhC11ACxytFDTHyWBiEJA6n9hG0y7yJNsAiN2SyaoADyrlRdMLS
 BKL0e+yzMUKVJdPUUORS9jsYyjN5fK9fekJrtiOMrJzjmFZLWdrBh1Ga0+KxHzKm0Mxi6w5M
 przWZ/yUSpLVP09nWvnHr11PVoXKsYWnz67qXfTlUrP7FZjTCTNFedt3KWmMojVE59oUC2Kq
 o0CZqNmOj1UUfHkYzm/zGLgBQtiEJTPPriv85Y/XrfaemJOQTh9Y9eMkeJJU9E0xMx9y7aXl
 kxRr2cFkTITc1Wccl7UAp2iAZuyNatCQYUTZ3x8Zw35hCJ6PO5CLs43LvMKQFXuz8Q6pdZcR
 PgZYcSQRPNJTzXM4TMGapfh6odlcXyWacimZkJJuRAzIMxtQRLn4Njhcle9/SUCFHPv58A/v
 6ehxkXQRp9aH1ZuC8PfafSOyVKtvCdCxLIuDhWQetQDKl/x9IVKKjDqiqNlKc87NhielCCR0
 BybAElEqLCV8ZM16tTAmYuNs5ytT7llBkNfEmSCteS2OCDW83CN24hFVOrULznRWHmtoPepZ
 PlPzuG6O/oCxQ4Yv415Grdt7KQ/+9qw+OMKklU6RC3GNg35BKlhL3+K2dh0mpdMnrIJ6xGrX
 k+v+8VBPenbMs3SD1NMdhEuaf6O1K9Il2CKv+g1Okjz+AR+4KGDDRdJJxCJhSFQcOl1PYciz
 btzscIa8VXi2B8jM9LAhSFI7WWcaHcHVvx/5J0dBYbqjCsty01DPsOAWnOnvsnXZoUeKFQuL
 x+VmLHG1uZVyUf1enYuEWTAgLhGjpMUtREWlFIPKjxlQDYeaiPbCPGJzQkKcw==
IronPort-HdrOrdr: A9a23:q0wYWap41C8zy9zz5TexIyIaV5rReYIsimQD101hICG9Evb0qy
 lhppQmPH7P+VIssRQb8+xoV5PufZqxz/BICOoqTNKftWvdyQiVxehZhOOP/9SJIUbDH4VmpM
 VdmsZFaeEZDTJB/LvHCAvTKadd/DFQmprY+ts3zB1WPH9Xg7kL1XYfNu4CeHcGPzWvA/ACZf
 yhz/sCnRWMU1INYP+2A3EUNtKz3eEixPrdEGc77wdM0nj3sQ+V
X-IronPort-AV: E=Sophos;i="5.88,373,1635220800"; 
   d="scan'208";a="64324541"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=bsIM4EBCg7e5qfHeW0KF51iSlKyOnSlD8wJ9TO8+ub19wN7+/VrlUHHA7VSWhBd37EVBE6tK81mC+fBbZDYk24zf+dm4R81Us82i6vlItZNyDjLbkBDvwGAUEIP5A9YSvo47/Q92xsWtvCV5GWI4sNAjAdKAqTWk6mnO3iKel5Zela9icxS3PEgYzbiaP54Qs4ZAnAgUC7KDxNsmZFfpTv42SHY3UN+opRFuw5fL2lcVIPMkKkP0wdbGrUjEaBP3EvsNBxdeywJB7JR437FIH73zdecO5iVxo/sA0V1yj1/awpReGhg0WrF+g94BPs/HKSk/eZIzF2eFwOB8wc8waQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=FFQhQkphMi6Ap1Mi8N3n2KqtwVj5MU8P14jt20/cQvs=;
 b=Nxa7TfdIU2IVKfv0n2dfuFWNv3F72kb+IQEfB4DKBRU7AEDjta9wpsHSAo/4AjZePdXCUwWQzwpSFvEHWDgUrDmGyYD963o5T1e2TYgZaQNerg9JLGS8jeAc6fnLXltkAh0sOiU3kThDNpWp+ErHdaZCCCN0lho1+YBxJHhFutFyy6DxpfRf4jL2J20ZUyyUEK3qLBG5Reh933/WT9QrlI8QMSv0ZpPXy5SPE1b/klmiN4cwVOw1Wzl4wsQuW0Qr8sKLJr9wXvW4YOp/wIoRGjnKaBwMx1e4A7keHFcY0J2sZ2ygjqV0lFY1l8ai7y4xadEiOJI6PUTR1n4kZQzD7A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=FFQhQkphMi6Ap1Mi8N3n2KqtwVj5MU8P14jt20/cQvs=;
 b=GSaHanj6KPwiXs4RuhFvwcczj4ifcnb/qt3SIFUJbUeIxrlcePvuxAqTC3NpXwEhterlc/y0HkQYxts/rH3NhmVPqZlxyVKKLzvcdS2HnL4HBsQ6uCGcTDrZO9J7VbDgFwiQPfIcV5NCUNON5LYnRMuFIjJ+idW/wGUAHLjBR2Q=
From: Roger Pau Monne <roger.pau@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: <dwmw2@infradead.org>, Roger Pau Monne <roger.pau@citrix.com>, Wei Liu
	<wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, Jan
 Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>, Stefano
 Stabellini <sstabellini@kernel.org>, Juergen Gross <jgross@suse.com>
Subject: [PATCH v2 2/5] xen/vioapic: add support for the extended destination ID field
Date: Wed, 16 Feb 2022 11:30:23 +0100
Message-ID: <20220216103026.11533-3-roger.pau@citrix.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220216103026.11533-1-roger.pau@citrix.com>
References: <20220216103026.11533-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO4P123CA0303.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:196::20) To SA0PR03MB5610.namprd03.prod.outlook.com
 (2603:10b6:806:b2::9)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: fd3498a2-37f4-4737-ece1-08d9f1376d63
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6256:EE_
X-Microsoft-Antispam-PRVS: <SJ0PR03MB625660E309D2BF0D289B1D378F359@SJ0PR03MB6256.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: FkqpVYHhUxSDYLy3rTJyukU8sNMWcddPAhRN4TKmVE2Y7h9sDtA6UN/242WcyANkQXea5WM1JV3tO6LULh7qGL+SVYfn0bVEIHDjB60NGBL+Z/9Z9nCAIkvWAu9ye034UA/WEDyJShG4UsFlrEgX7+kKIOvxwynwVYAic1iRm7mIt7rDtivJqHeuPspMUkbtRkeyD5kOVwD/3/6d982sSO8OLmWsZkg1/x/7hh2lP58vWJHJRqFb6jY31WNlBKg1iwLYXXEmOyswcuVb5t5Mpw8nah/VTJx67OWPChzEbTWOFuvpGl1Dsz18uYQp/C3cDXw/XF1BesjdSl/q1EDjL9ywWn9fX9LwCE8yazyvIp3ZbJOGpv/4sNvDkYX5DQXKUyrvzpOZIOywzbmyRrezS4ksd9YyMVdhycr0bUEgFooy8X2M9ph+bMZ8wQ0imxpGMERjQ0ZZ/+ZCliEwCipvm26hb+Gz+KFhAqaODJxsnKMPyhRGAo34iEeHyrSGlmPo9w4ZHCqHgyELNO59EqcK+16Qi+qCve2NBSyR/MM5uIAqs/m9etBeIik7gKHj2qmFF5lowMOPg/c6j5pnFRBBIOATd5FlfFFUzM1S2P+mMrf9utof+afnkk1GgW9otOEMEab3aRVyQiDzmLtVnuD41cK58DmZ1626Z9dfH+SGW0geYbx1Wi4ti81/DK9JrATJJt6EkrQNYuCZqF1SrAGVmQPc5QyHjPy8ORoOHzi5Zpk=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA0PR03MB5610.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(8676002)(2616005)(66946007)(6506007)(6512007)(316002)(26005)(1076003)(66556008)(508600001)(86362001)(6486002)(6916009)(6666004)(54906003)(966005)(82960400001)(66476007)(83380400001)(4326008)(38100700002)(36756003)(5660300002)(2906002)(8936002)(186003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a09EbUhYSFU5MnE3MTAyU3pPbG9KUVdFUUpybjVLSk1BS3IyU010NXdUaDFi?=
 =?utf-8?B?VktnTWQrZ2hCNzN1azkyWW9WK01ROG1pSFdwOGpuRjRIdTRCQ3NGSW92NUV3?=
 =?utf-8?B?V2FiWWNHZlJabFhJbGE5My9sbXJCYlF1dDFSWFR0WXVQNDg1N1prTnFpaHMr?=
 =?utf-8?B?b01WbllGQ2FkMDluQ0p0NlVaa1NValNZbUxMb3hPRVhvRU9lc1JiK0ZBTEow?=
 =?utf-8?B?WU9rZnpnT29LL0J1WExmbWpabWt3K2RxWmFwR001UVpDNXh2K0t3WnltTlRu?=
 =?utf-8?B?ZGVPOG90aUlSMy9neVI5K2pFNVVTNzBQRkZDZEZkTTJ0NG5KMGduWmRBV01Q?=
 =?utf-8?B?MEdDTUdRYURVRUdQaG1GTUNrSlhZRDIyS1M2dW02UVFsQzJTaTJubzYyN0xl?=
 =?utf-8?B?Rmd6OHp5YkZLcDQyS255Y1pJMHhIQ3JrL1VjMzFBOFNya3RPZ2xrYm1vV1BR?=
 =?utf-8?B?a1pLU1FBdDJSQ3poR2loTHNnNDFPL2RKRzBlSlRSNmFHSFBZM1Jod0dGaXRF?=
 =?utf-8?B?NlBhT0xqTXUwajlVMk5QK3JQcjFFTzZkd211eENqdmNsTkRWemVlSWdzWEsw?=
 =?utf-8?B?QThHNnRPc1hlcTE1S1Z6citWWEJjTkk0Tkt4eXh1MHBLVHhJcmdsLzNFaG8v?=
 =?utf-8?B?a0dNNEJFU3pZdjhodlpTQlFQbFpUNlVLZERSSHRKSWdxd2tiRmZSS3VtQ3FU?=
 =?utf-8?B?bWhaeG9pZ0kwVzZzTTY0N3lZa29uTGozNEpZVjgxOG15ZGxOWWwxVXJIWDhw?=
 =?utf-8?B?QkxIVzBzckVvdnRNbStqVTJQTzJlUDN2cW11RFFDWXJzKzJBYnhWRndIelFC?=
 =?utf-8?B?UVRrZFNrU1Rxd2NRMFpPMUxGQ2VFNXVIcmpLNmFxZWtpN3RITGZBNVo0aytR?=
 =?utf-8?B?eVBRaURyZkdQSVNWMHZpTEtDSWVieUw2Q3YvR0piVEhpNWcvWnkzN1lEcjRy?=
 =?utf-8?B?clJ3ajliZjI3bGxYOHZXczBLRHA0SG5XMnJ3QTlXYzlndXo0NTh6eU42RU9u?=
 =?utf-8?B?Vm1heEROdHpMb3pmK0RudkR3RFRtNXJsVEtpWXpnaXpIMWJVVUUwa1Q2RHcy?=
 =?utf-8?B?Nyt4bUFvZ085WnhQQ3llcURvSXI2eDV6NExvaTQ5Y2VHUHo5YVoxYU5tTnFw?=
 =?utf-8?B?cXpjZloySzVoOGE4TXBSdmcyMHlacTJJZGZzeEJ6NzJWbXV6NXMyOWhWbith?=
 =?utf-8?B?b1JhMXgrOUdEd3EzdDA4V2N5VlNtSk9MT0U5eERITjEvbkwwZ3F0cFV4K1lM?=
 =?utf-8?B?aCt2QW00MkNGTjByTUJ4NDZjLzBvamFBNURqbnR6SEN6U0NUNSt3VlY3UEM0?=
 =?utf-8?B?b1MwbDJRQXpQaFFzU292Z3grSFFnaU1rR1lQM3NWdGdrcUlwOERiMVV5TnB0?=
 =?utf-8?B?dUVjWG1yeFUxVXRHcmkrV2tqamc2eHMwdUY2TjhUWFpCRkM3TGlQNUtkOTZ4?=
 =?utf-8?B?VzJRRWM0VHVKWTQ0SEdEbGMyVEt6L2hRZGdrVXNyVDZhL0ZJdldMUEg1c2Jm?=
 =?utf-8?B?cFltemRjM3YrZ0trZ2QyN0gwMTVEbkVzbWVuQi92ZFRhVHB4M0pEQkROUFpO?=
 =?utf-8?B?RXl2c2FHb29mdFhVSnBPL25rcUdBOS9JRGJycXNHQ0dyRkZ4U1hFL0Yvb0Zh?=
 =?utf-8?B?YVArZFg5Q3lGK0gvcnBWci9oRm1xUGlwNUo4cHVCUFlLeTVFNVl4UXI4bVVJ?=
 =?utf-8?B?emFFeklxSE0zVnFtVEI0Nk9IWGNzOXd6bFVWVFB5elowMTNDNHFEQ0tqcGZV?=
 =?utf-8?B?VGtsZy9ObnVBQy9kd0VEeUZPaWxLbzg0WmJuV0dtWDd0NEYxTmIyQkJYbm5j?=
 =?utf-8?B?dGYvd1lhSEE0eUc3SUVxdHFMZjdjRjNqQWJ5V0FuYjJsT1l0VmgrcFlsdnRH?=
 =?utf-8?B?WFFybk9HUFNoNVlJYzlBa3JaVEFFMWVnSWNxZ1FXeDhMWndCT1JDWE5Qell5?=
 =?utf-8?B?MzlSZkdtSDVzWlRneW1LV1MzVjNhb0wzcU55ejlTWDZQNXVnay8vb3J6eFBj?=
 =?utf-8?B?bG8wWHg3ZldjQUlkeU5mWDV1UlhOeU9xSGdiQ1luS2d3K3BnSm11L1BzTUJN?=
 =?utf-8?B?eWlBTFpXWUdkOW1GUnlFWU9JV0FFb2JtTWhRbW0yMXQ3MkNpYzNCdVZxS3pN?=
 =?utf-8?B?U2tIdG1Fbk96NVN0dFNvamhzNUI3eTRJdmFTd0RNVEh0TUx3c0hCaUlzZ0NI?=
 =?utf-8?Q?JTDlnVkPJxNjIxjscZVTYao=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: fd3498a2-37f4-4737-ece1-08d9f1376d63
X-MS-Exchange-CrossTenant-AuthSource: SA0PR03MB5610.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2022 10:31:01.2115
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: b2uxp29TvFaZ0eFye0mvPOHQV0+JON70DgKdeQ6AVypuzaaoTc2y/Rk4Zq3Lbot9FNGaj4JOnNV7iwsGBFOs+g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6256
X-OriginatorOrg: citrix.com

Such field uses bits 55:48, but for the purposes the register will be
used use bits 55:49 instead. Bit 48 is used to signal an RTE entry is
in remappable format which is not supported by the vIO-APIC.

Use the extended destination ID to store the high bits from the
destination ID, thus expanding the size of the destination ID field to
15 bits, allowing an IO-APIC to target APIC IDs up to 32768. A
description of the feature can be found at:

http://david.woodhou.se/15-bit-msi.pdf

Note this is already supported by QEMU/KVM and HyperV.

Introduce an option in xl.cfg to allow switching off the feature.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Changes since v1:
 - Expand commit message, add reference document.
 - Add xl option to disable the feature.
---
 docs/man/xl.cfg.5.pod.in               | 10 ++++++++++
 tools/include/libxl.h                  |  8 ++++++++
 tools/libs/light/libxl_create.c        |  6 ++++++
 tools/libs/light/libxl_types.idl       |  1 +
 tools/libs/light/libxl_x86.c           | 12 ++++++++++++
 tools/xl/xl_parse.c                    |  3 +++
 xen/arch/x86/domain.c                  | 10 +++++++++-
 xen/arch/x86/hvm/vioapic.c             |  3 +++
 xen/arch/x86/include/asm/domain.h      |  3 +++
 xen/arch/x86/setup.c                   |  1 +
 xen/include/public/arch-x86/hvm/save.h |  4 +++-
 xen/include/public/arch-x86/xen.h      |  2 ++
 xen/include/public/domctl.h            |  2 +-
 13 files changed, 62 insertions(+), 3 deletions(-)

diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in
index b98d161398..349e0b432a 100644
--- a/docs/man/xl.cfg.5.pod.in
+++ b/docs/man/xl.cfg.5.pod.in
@@ -2901,6 +2901,16 @@ option.
 
 If using this option is necessary to fix an issue, please report a bug.
 
+=item B<ext_dest_id=BOOLEAN>
+
+(HVM/PVH only) Signal the hypervisor whether the guest should be allowed to use
+extended destination ID for interrupt messages. Such feature allow expanding
+the target APIC ID from 8 to 15bits without requiring the usage of an emulated
+IOMMU with interrupt remapping. Note this requires guest support and might not
+be exposed to the guest even if explicitly set due to other constrains.
+
+Default: enabled
+
 =back
 
 =head1 SEE ALSO
diff --git a/tools/include/libxl.h b/tools/include/libxl.h
index 51a9b6cfac..35329bca50 100644
--- a/tools/include/libxl.h
+++ b/tools/include/libxl.h
@@ -527,6 +527,14 @@
  */
 #define LIBXL_HAVE_MAX_GRANT_VERSION 1
 
+/*
+ * LIBXL_HAVE_X86_EXT_DEST_ID indicates the toolstack can signal to the
+ * hypervisor whether the domain wants to use the extended destination ID mode
+ * for interrupt messages. This is done by setting the libxl_domain_build_info
+ * arch_x86.ext_dest_id field.
+ */
+#define LIBXL_HAVE_X86_EST_DEST_ID 1
+
 /*
  * libxl ABI compatibility
  *
diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_create.c
index 7499922088..66ecfbdf4d 100644
--- a/tools/libs/light/libxl_create.c
+++ b/tools/libs/light/libxl_create.c
@@ -2330,6 +2330,12 @@ int libxl_domain_create_restore(libxl_ctx *ctx, libxl_domain_config *d_config,
      */
     libxl_defbool_setdefault(&d_config->b_info.arch_x86.msr_relaxed, true);
 
+    /*
+     * Do not enable the extended destination ID for restored domains unless
+     * explicitly set.
+     */
+    libxl_defbool_setdefault(&d_config->b_info.arch_x86.ext_dest_id, false);
+
     return do_domain_create(ctx, d_config, domid, restore_fd, send_back_fd,
                             params, ao_how, aop_console_how);
 }
diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl
index 2a42da2f7d..bbfe218c48 100644
--- a/tools/libs/light/libxl_types.idl
+++ b/tools/libs/light/libxl_types.idl
@@ -648,6 +648,7 @@ libxl_domain_build_info = Struct("domain_build_info",[
                                ("vuart", libxl_vuart_type),
                               ])),
     ("arch_x86", Struct(None, [("msr_relaxed", libxl_defbool),
+                               ("ext_dest_id", libxl_defbool),
                               ])),
     # Alternate p2m is not bound to any architecture or guest type, as it is
     # supported by x86 HVM and ARM support is planned.
diff --git a/tools/libs/light/libxl_x86.c b/tools/libs/light/libxl_x86.c
index 1feadebb18..68f4de7ea9 100644
--- a/tools/libs/light/libxl_x86.c
+++ b/tools/libs/light/libxl_x86.c
@@ -14,6 +14,11 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc,
         break;
     case LIBXL_DOMAIN_TYPE_PV:
         config->arch.emulation_flags = 0;
+        if (libxl_defbool_val(d_config->b_info.arch_x86.ext_dest_id))
+        {
+            LOG(ERROR, "Extended Destination ID not supported for PV guests");
+            return ERROR_INVAL;
+        }
         break;
     default:
         abort();
@@ -22,6 +27,8 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc,
     config->arch.misc_flags = 0;
     if (libxl_defbool_val(d_config->b_info.arch_x86.msr_relaxed))
         config->arch.misc_flags |= XEN_X86_MSR_RELAXED;
+    if (libxl_defbool_val(d_config->b_info.arch_x86.ext_dest_id))
+        config->arch.misc_flags |= XEN_X86_EXT_DEST_ID;
 
     return 0;
 }
@@ -824,6 +831,8 @@ void libxl__arch_domain_build_info_setdefault(libxl__gc *gc,
 {
     libxl_defbool_setdefault(&b_info->acpi, true);
     libxl_defbool_setdefault(&b_info->arch_x86.msr_relaxed, false);
+    libxl_defbool_setdefault(&b_info->arch_x86.ext_dest_id,
+                             b_info->type != LIBXL_DOMAIN_TYPE_PV);
 }
 
 int libxl__arch_passthrough_mode_setdefault(libxl__gc *gc,
@@ -880,6 +889,9 @@ void libxl__arch_update_domain_config(libxl__gc *gc,
      */
     libxl_defbool_setdefault(&dst->b_info.arch_x86.msr_relaxed,
                     libxl_defbool_val(src->b_info.arch_x86.msr_relaxed));
+    /* Force Extended Destination ID so it's part of the migration data. */
+    libxl_defbool_setdefault(&dst->b_info.arch_x86.ext_dest_id,
+                    libxl_defbool_val(src->b_info.arch_x86.ext_dest_id));
 }
 
 /*
diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c
index 117fcdcb2b..b609b76779 100644
--- a/tools/xl/xl_parse.c
+++ b/tools/xl/xl_parse.c
@@ -2761,6 +2761,9 @@ skip_usbdev:
 
     xlu_cfg_get_defbool(config, "vpmu", &b_info->vpmu, 0);
 
+    xlu_cfg_get_defbool(config, "ext_dest_id", &b_info->arch_x86.ext_dest_id,
+                        0);
+
     xlu_cfg_destroy(config);
 }
 
diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c
index ef1812dc14..9764f42878 100644
--- a/xen/arch/x86/domain.c
+++ b/xen/arch/x86/domain.c
@@ -685,12 +685,19 @@ int arch_sanitise_domain_config(struct xen_domctl_createdomain *config)
         }
     }
 
-    if ( config->arch.misc_flags & ~XEN_X86_MSR_RELAXED )
+    if ( config->arch.misc_flags &
+         ~(XEN_X86_MSR_RELAXED | XEN_X86_EXT_DEST_ID) )
     {
         dprintk(XENLOG_INFO, "Invalid arch misc flags %#x\n",
                 config->arch.misc_flags);
         return -EINVAL;
     }
+    if ( !hvm && (config->arch.misc_flags & XEN_X86_EXT_DEST_ID) )
+    {
+        dprintk(XENLOG_INFO,
+                "Extended Destination ID only supported for HVM\n");
+        return -EINVAL;
+    }
 
     return 0;
 }
@@ -862,6 +869,7 @@ int arch_domain_create(struct domain *d,
     domain_cpu_policy_changed(d);
 
     d->arch.msr_relaxed = config->arch.misc_flags & XEN_X86_MSR_RELAXED;
+    d->arch.ext_dest_id = config->arch.misc_flags & XEN_X86_EXT_DEST_ID;
 
     return 0;
 
diff --git a/xen/arch/x86/hvm/vioapic.c b/xen/arch/x86/hvm/vioapic.c
index 553c0f76ef..a02bd16b4b 100644
--- a/xen/arch/x86/hvm/vioapic.c
+++ b/xen/arch/x86/hvm/vioapic.c
@@ -424,6 +424,9 @@ static void vioapic_deliver(struct hvm_vioapic *vioapic, unsigned int pin)
 
     ASSERT(spin_is_locked(&d->arch.hvm.irq_lock));
 
+    if ( d->arch.ext_dest_id )
+        dest |= vioapic->redirtbl[pin].fields.virt_ext_dest_id << 8;
+
     HVM_DBG_LOG(DBG_LEVEL_IOAPIC,
                 "dest=%x dest_mode=%x delivery_mode=%x "
                 "vector=%x trig_mode=%x",
diff --git a/xen/arch/x86/include/asm/domain.h b/xen/arch/x86/include/asm/domain.h
index e62e109598..83a1608212 100644
--- a/xen/arch/x86/include/asm/domain.h
+++ b/xen/arch/x86/include/asm/domain.h
@@ -440,6 +440,9 @@ struct arch_domain
     /* Don't unconditionally inject #GP for unhandled MSRs. */
     bool msr_relaxed;
 
+    /* Use the Extended Destination ID to expand APIC ID. */
+    bool ext_dest_id;
+
     /* Emulated devices enabled bitmap. */
     uint32_t emulation_flags;
 } __cacheline_aligned;
diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c
index 115f8f6517..4aaa6ebc07 100644
--- a/xen/arch/x86/setup.c
+++ b/xen/arch/x86/setup.c
@@ -782,6 +782,7 @@ static struct domain *__init create_dom0(const module_t *image,
 
         dom0_cfg.arch.emulation_flags |=
             XEN_X86_EMU_LAPIC | XEN_X86_EMU_IOAPIC | XEN_X86_EMU_VPCI;
+        dom0_cfg.arch.misc_flags |= XEN_X86_EXT_DEST_ID;
     }
 
     if ( iommu_enabled )
diff --git a/xen/include/public/arch-x86/hvm/save.h b/xen/include/public/arch-x86/hvm/save.h
index 773a380bc2..253dc89a04 100644
--- a/xen/include/public/arch-x86/hvm/save.h
+++ b/xen/include/public/arch-x86/hvm/save.h
@@ -376,7 +376,9 @@ union vioapic_redir_entry
         uint8_t trig_mode:1;
         uint8_t mask:1;
         uint8_t reserve:7;
-        uint8_t reserved[4];
+        uint8_t reserved[3];
+        uint8_t :1;
+        uint8_t virt_ext_dest_id:7;
         uint8_t dest_id;
     } fields;
 };
diff --git a/xen/include/public/arch-x86/xen.h b/xen/include/public/arch-x86/xen.h
index 7acd94c8eb..06d64a309f 100644
--- a/xen/include/public/arch-x86/xen.h
+++ b/xen/include/public/arch-x86/xen.h
@@ -317,6 +317,8 @@ struct xen_arch_domainconfig {
  * doesn't allow the guest to read or write to the underlying MSR.
  */
 #define XEN_X86_MSR_RELAXED (1u << 0)
+/* Select whether to use Extended Destination ID for interrupt messages. */
+#define XEN_X86_EXT_DEST_ID (1u << 1)
     uint32_t misc_flags;
 };
 
diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
index b85e6170b0..31ec083cb0 100644
--- a/xen/include/public/domctl.h
+++ b/xen/include/public/domctl.h
@@ -38,7 +38,7 @@
 #include "hvm/save.h"
 #include "memory.h"
 
-#define XEN_DOMCTL_INTERFACE_VERSION 0x00000014
+#define XEN_DOMCTL_INTERFACE_VERSION 0x00000015
 
 /*
  * NB. xen_domctl.domain is an IN/OUT parameter for this operation.
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Wed Feb 16 10:31:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 10:31:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273927.469228 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKHaY-0006Td-Qv; Wed, 16 Feb 2022 10:31:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273927.469228; Wed, 16 Feb 2022 10:31:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKHaY-0006Su-Kp; Wed, 16 Feb 2022 10:31:10 +0000
Received: by outflank-mailman (input) for mailman id 273927;
 Wed, 16 Feb 2022 10:31:09 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=oYE0=S7=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nKHaX-0006QF-Qp
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 10:31:09 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8b42a3d6-8f13-11ec-b215-9bbe72dcb22c;
 Wed, 16 Feb 2022 11:31:06 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8b42a3d6-8f13-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645007466;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:content-transfer-encoding:mime-version;
  bh=zVlywzfrFYT4j81Q9eKIZ01umyrGNIbePcDAlJ1CQAQ=;
  b=BaHpv8bOn0iSO14nCmuxM7hGFaqbjwCescefJUWFPQYCVRJCYJOGIA4+
   8Kd3/OaD2BI2XlFfxOH6pGdn9aH6g2LemPHT7X9MVWhqCCO2dQlMuwLEw
   2lq8FWw91qp7YijQCu8qq3bb6ikGEbYsWA6I3vVtOKTh9ZYyVDYxHiasi
   E=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: l/PpeIPovc6mK8WJ6pMCVSoyEj//rpDQ3TlaOQcYkHIVuCtOyGQDoQ+cAwvOR/zNXPMU5HdnP8
 fotCSggbygUc5GPMeVYxYCGyc4bvvzFKMaWGz93oplz6yN3YpoIkGLRWkAZkc96nRhSGJuE8wR
 eDK5e+2zP1tOkcTMQEAL2A7t2UuLmGQiMgjU7KN3XDXMZlPVXTQZkOfsAUJiCbhw7ih1cEFlpK
 /YgTzhqj/0YOQQiQtTl01wJAjkq8P+CCx44nFV2MOiufZ/VBIXEaa8rdGwvTUdLUAN6WoAZiAB
 h38ZMtlKSdgVxUoM2dmsEi0z
X-SBRS: 5.1
X-MesageID: 64225270
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:epsup6uf1Qub65YOrZr9gz2wrefnVL1ZMUV32f8akzHdYApBsoF/q
 tZmKWHXMv/ZYTf1L9x0YNnkoEpTuMXczoJqQABv/CxnRCIT+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZQP0VOZigHtIQMsadUsxKbVIiGHdJZS5LwbZj2NYy2IbhWmthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 Nplsof3GBwpZKv2w/0CcSJ9NyR+E+p99+qSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DJoQQt2sm1TjEJf0nXYrCU+PB4towMDIY2JwUR6uEO
 JJxhTxHUTjAXzBONVItDb0bgN+nqijUc2ZmkQfAzUYwyzeKl1EguFT3C/LXcNGXQcRenm6Du
 3nLuW/+B3kyK9i32TeDtHW2iYfnjS79HY4fCrC83vprm0GIgHweDgUMUlm2quX/jVSxM/pTN
 EkLoAIvq6Yo/UCmR9W7WAe3yENopTZFBYAWSbdjrljQlOyEuG51G1ToUBZGc5t3r89sQwZxz
 0CrpPbNADxB94aaHCf1GqivkRu+Pi0cLGknbCACTBcY79SLnLzfni4jXf44Tvfr04Sd9SXYh
 mnT8XNg3+l7Ydsjiv3jlW0rlQ5AsXQgouQdwgzMFlyo4QpiDGJOT9z5sAOLhRqswWvwc7Vgg
 JTms5XGhAztJcvU/MBofAnrNOv0jxpiGGeB6WOD57F7q1yQF4eLJOi8Gg1WKkZzKdojcjT0e
 kLVsg45zMYNYCf7MPYtMtPgUp5CIU3c+TLNDK28gj1mOMYZSeN61Hs2OR74M57FzCDAbp3Ty
 b/EKJ3xXB72+IxszSasRvd17FPY7ntW+I8nfriil07P+ePHPBa9EO5ZWHPTPrFRxP7V+239r
 ocAX/ZmPj0CCYUSlAGMqtVNRb3LRFBmba3LRzt/LL7TeFE3Rzt4Vpc8A9oJIuRYokicrc+Rl
 lmVUU5E0lvvw3rBLASBcHd4b73zG514qBoG0eYEZD5EAlAvPtSi6rkxbZwyceV1/eBv16csH
 fIEZ9+BErJETTGeo2YRapz0rYpDchW3hF3RY3r5MWZnJ5MwFRbU/tLEfxf08HVcBCSAqsZj8
 aar0RnWQMRfSl06XtrWcv+m03i4oWMZxLBpR0LNL9QKIBfs/YFmJjbflPgyJ81QexzPyiHDj
 1SdAAsCpPmLqIgwqYGbiaeBpoavMu1/AksFQDWLsefobXHXpzPxz5VBXeCEeSHmeFn1oKjyN
 /9Iy/zcMeEcmAoYuYRLDLs2n7k14MHipuEGw108TmnLdVmiFphpPmKCgZtUrqRIy7JU5Vm2V
 0aI9oUIMLmFIpq4QlsYJQ5jZeWfz/AE3DLV6K1tckn94SZ2+puBUFlTYEbQ2HAMcuMtPdN32
 /olte4X9xe720gjPduxhyxJ83iBcy4bWKI9u5BGWILmh2LHEL2ZjUAw3sMu3KyyVg==
IronPort-HdrOrdr: A9a23:7yYfb6OaXjbvo8BcTjujsMiBIKoaSvp037BK7S1MoNJuEvBw9v
 re+MjzsCWftN9/Yh4dcLy7VpVoIkmskKKdg7NhXotKNTOO0AeVxelZhrcKqAeQeREWmNQ96U
 9hGZIOdeEZDzJB/LrHCN/TKade/DGFmprY+9s31x1WPGZXgzkL1XYDNu6ceHcGIjVuNN4CO7
 e3wNFInDakcWR/VLXAOpFUN9Kz3uEijfjdEGY7OyI=
X-IronPort-AV: E=Sophos;i="5.88,373,1635220800"; 
   d="scan'208";a="64225270"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=C/mkjCdRUppdNHAnl2tHU0LDQ+bt4tk+sCtUB2CNhfwe3xMMbgMjgurhKOf7savGtdxJcsj28tOPvx7Ym4AGck+fD45u8BFrkHcW9zUwakKaJzDebTj941rDSJ61xgidY6hYhgoWdHoBIiSVSPWKFOmrPUWIGlHgM+Xy0VXrdaAnSWOL9rtQM6aIucvs8MKv71AqPJksan3I/JX2sH6j2OnBiaYj9dkiaBhGcOk21bguUf2uK7O7ycibzTHcl5yUwMVGCrWaO2eLkvDKN0NibEJMt3tbaDVJjeucB3w6DMf+qRggpwYPdzag+fU9URLflvDxSdhGjO58XynNzUd0Iw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=h8Tgei5/cDOMx9szRnWDQ16i7axYk3kXvj6N3RsL58M=;
 b=AMGQdgwIqdxY9da3YIyRG4WtLFw/nQToUcQ+5heQeheQAFTqO86+6rHLbqyVz9fzQlA5A/nrXhg4A6fx2ul5Usbgk4cZrmiFYVEma/gToq2CBsrBP7M+JMhdyvNZsxwkexfE293CGJaooKk7CC7IG1RcDzrday2/R9ZgPZewNFjCN8Kh9PZhy3gj4fjFpLSOnQeP/3xQjaJvMNuRLmO+Lp2AnM14Q1xRpCVoKVD6hXrjs8ZldSeU3+kA/70ajnnqHHq4bQjt+TDJw3Bv9H8tz1F7v+YrJngtzHkWUlqYGFsFjj2m3nTiTGhT4/v8EMweXkiv1hI46lwQECuPvEDkPQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=h8Tgei5/cDOMx9szRnWDQ16i7axYk3kXvj6N3RsL58M=;
 b=JfI+VDXna+Abmnlj+sNBDLrqMzek/AyqdBb8L5zcVXwNo0QZELrT0tiRNy5BudgLpC0SDYZCPZTpGRNwz5Dq6fA6ifK/IWSWPFsWWw3A5qnyCTvqCif1ws0RtdRJj591UlTuy6rrNc/t/iJBaDHRbs+VeTw3wXmecbMo1uIluhI=
From: Roger Pau Monne <roger.pau@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: <dwmw2@infradead.org>, Roger Pau Monne <roger.pau@citrix.com>, Jan Beulich
	<jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu
	<wl@xen.org>
Subject: [PATCH v2 1/5] x86/cpuid: add CPUID flag for Extended Destination ID support
Date: Wed, 16 Feb 2022 11:30:22 +0100
Message-ID: <20220216103026.11533-2-roger.pau@citrix.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220216103026.11533-1-roger.pau@citrix.com>
References: <20220216103026.11533-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO4P265CA0023.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:2ae::13) To SA0PR03MB5610.namprd03.prod.outlook.com
 (2603:10b6:806:b2::9)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b67c13fd-2d8d-496c-9c3c-08d9f1376aa3
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6256:EE_
X-Microsoft-Antispam-PRVS: <SJ0PR03MB6256862FDAAE7A4592F9E5478F359@SJ0PR03MB6256.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: lF0Lw1gFJ5/NKLbaFuMXzRM+sZD+7lU8nZxIUpOiZfh1Q7nnAlGpdaRkZYRko0Lb7raOmEkNLARQP4efaKwEXMeJgsL5iAZxq4sjBo9zv53SzthwsOjg87COpSUrAoLV2rhukDqgGPyWIifsxypQSC9ceN3yfvu7zwtpHhuYZj3tuNSjXX1uP7AxTdbe2yc0QkaCI+UXMPVuqKCSHqaSsU1UJwdKSRR8MUzZZZLcVnvhdAvCFnMmbn5lOJAiswxNBAuYdoY2Q61Q6YlEzovhs5anpaSYN/uIu3LghGVCBciZQdBuhOObnJSPayFRxKP1kSYK6PRkI0NBmJ+qPHH89PlMuuKgieZlJ3t1F0aXE6hmfXkBGEirALGAy/A/vsVQBVjoiSjhRx+P2jUipZGSOPYGiy5ui9vIzHTTsI8VpNM6UQSGB+lX5+Yju8YVbS/LibZ1G8jvKyOdUu+TY9tPdyj403/Wt3og3oZcwNCM2PjtUhwJr+/pkI7EF2rlPcOsn+nlz8C+si0w7PJJT7oHUaartry6MJamcKXR6uMhrH7zIdt5499oSLchXPFJtTiyIdWtTYd4zp24x6S8nqN7+wMxI+mqMepljyve+Px04lazgEzPW8RPMTv+s4lRofC+wsulzrrZyfVc2stmFhBsBoq9A729f1E5PsbnEdKV+4FELwcogSjbxjB0U86ULOpei4wy3JmCNpIqmbpJV6F1olPBtouoxvkcPtDsqnVaWA8=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA0PR03MB5610.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(8676002)(2616005)(66946007)(6506007)(6512007)(316002)(26005)(1076003)(66556008)(508600001)(86362001)(6486002)(6916009)(6666004)(54906003)(966005)(82960400001)(66476007)(83380400001)(4326008)(38100700002)(36756003)(5660300002)(2906002)(8936002)(186003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N0pWYUIzZXBsSlNrSWhHRnc0T0pMbWRaaks5K1liSzhVa2hpaTlwUmcrRlhK?=
 =?utf-8?B?UEpUaXpmdlplR0k3U0ZjaDBuM2FNelIybkdCa3BwWVJOZjZMai9KbUVKY2RV?=
 =?utf-8?B?YmNGTENpZ1NKUUV2dGdUYnA2WVg4WmZib0k4bFByMHJoc0ljRVFLbFRvQWp6?=
 =?utf-8?B?STVEOFVVVEpJM1kxTU5kblJDemhqWE5aQmlOcHpKZzFmQWdzQmRRL0pkMTVv?=
 =?utf-8?B?M2xQc1gwOU5ScWpoemN4SmtCOUlpV2tXZ3BhVFVpUHNZeTdBS3RWS2JnZ0xn?=
 =?utf-8?B?eEYwcUFnNFBORXdRaXpEd2RXMFUzZHh1dlZFckkvWWJqNDVieWs3cE51SGQ1?=
 =?utf-8?B?dHZIOUNKRnZmSUZYTm1qUVR1c3hyTFBGUVlaYW5JSTJWK292MVVmc3R2VFRm?=
 =?utf-8?B?VmpyYUtlL051MUwwTGdMenBxUFZNWDA3MFFsdnJXY3F2QWRvSHFITHhMbjBz?=
 =?utf-8?B?c3dJSU55T0tOSStpbDBpS3VlMEkwUzd6dlJLU0gvVHZNNHJSR3RNbDJWa1dn?=
 =?utf-8?B?UFNlemhmWG91NkdnWGIveEViVnJ0SVo1V2hFMmJPZ2xPbFlQM2JObzdYbllM?=
 =?utf-8?B?YVVuakNRdkJNM0ZoTVU4V0M4bTN6L1Q0N21FN1Z4V281SGt5YXFDTm5oRTg0?=
 =?utf-8?B?c292MEVSVDJXTFpqY1ZvWkZYTlUrbk1nNU5LUzY1K09FQjFobWRZQWdHeW8x?=
 =?utf-8?B?ZUt2NkJXbXE0TkJOZjltOFJzS21CdTRNS3gyOFVRUzcxaEtyNXVFVHliRU5M?=
 =?utf-8?B?S3Y1dCtCbDcrQXUwc3NQS3BIbHpaakltSWNyRmRHbVFGRm1BSFNZU1BLYndk?=
 =?utf-8?B?NHpZS3BudzhrM281UUJZOHRnMWtsVkx6eGVIK2xtQ1RLRXNzZ0dncjhXVjhU?=
 =?utf-8?B?enJ0YXhkeE02M0tFeFVDTUVJa0xnN1czM0VwUUZ0dnBYZm81UDB5eDB4T28y?=
 =?utf-8?B?eTkyR3ZZeHJzbFpVSFRwWnMrL1NWNHNEQ0VVaG5BL3F4SVhCT0ZuVVlFT1c2?=
 =?utf-8?B?ZEJweVFhclRhNGpBOFVaS01HYUxsMURDR2RUZTdxQjRFVTdyTmhMbEY0eDh1?=
 =?utf-8?B?ZjFIbWZaNk9zeUhCTHU4U3VTUHNiaGZjL3hHSFM1SUtCNkZ6TEFFRDdtNDR3?=
 =?utf-8?B?QUYwZllyUnpjNkR5SmdxdlRrQU5LWnhtNnhXaWZiaTFzcENSOUlQQjIxdFdu?=
 =?utf-8?B?SE1TZzMyQnh1YS8wTTJhYUtPL3VORllmeVBDS1QzQmU5V0JPcC9KMWFUSk12?=
 =?utf-8?B?M1l0STZyaXd1VzdBVU5wTFRuUXhkSzl5ZDdHZ21ZcUVDTDdUNSttMUhJVzZx?=
 =?utf-8?B?SFhNSy8vRmJrRGhCcGpkQ1VNK3pSK0txNmVIRnMvWXh4YmdmNE9XOHJrZmll?=
 =?utf-8?B?dldWeWpjbEVVa1FVRElHV2d2anY4MWdPZkRIcHlqWkRCMW9LNG1hME8vZjRu?=
 =?utf-8?B?WDFhQUJzTlk1d2xYR3pIVktlcW8vTk9scHNBdXVxVkdIUFB6aUt5SWdGSUVq?=
 =?utf-8?B?NVkzNkpoV3BqeEZxK2JVWkZFY0tsNkdkSUNucERMeUEwSHVmTk4yKzMwZjVr?=
 =?utf-8?B?NmZjbXVFRTY1bmVHbEQ5cGdQaWRQYnAyWGNra1VUSkUzdmtWcXI0bDl2akk5?=
 =?utf-8?B?eU9veGZoeDhid21iVUpYVWtFMkhFRUVERE5RTkhXNk9vYm5uUC9ObWtLSk9C?=
 =?utf-8?B?QS80WXhBUmgxRW9GQk1jS0JJOTBSTi9vUnF3NEY0MnpXSThHWGJrWG1ldFFG?=
 =?utf-8?B?TndLa2NUNnZJcll3aTlwaFJsd0dNbHJreDhjc2lvRWVod29OTHVtWCtYVVp5?=
 =?utf-8?B?OXhNaXM0TEJ5TjRFVU50dStVUXJWYWJjNmZ1ek4vK1lhVll2NFhhN3R5ajVo?=
 =?utf-8?B?T0R3RWpMLytDdFN3akpoNkM4WFZhZDE2aDhRQnFjZnJVNXhoUzdMcUtzUndM?=
 =?utf-8?B?bkEzeTBWcDZFL1JCVGVaRTYxZXNsREorWWJOTXZIZW9nSU1Db29VRzhmNGRD?=
 =?utf-8?B?Vy9RWUNLc0hsS1RSaDJpOVZ5YmdrTC9kMXRtZGJ4Q3JtMlB5WDcyQkRDTm1y?=
 =?utf-8?B?ek90OEd0VlUwSHZFcDQ4eUdFV1doNitNbXdyMEcxR3puenIxaDRvTGx5YVFr?=
 =?utf-8?B?ZWpqKy92LzhkeDlTUk5LNVFwazZZYnQ4Wm53MEUrdDU3T2IzOGtZdFZHeDVH?=
 =?utf-8?Q?uUPJFC9b0yI1el+KfZhOofY=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b67c13fd-2d8d-496c-9c3c-08d9f1376aa3
X-MS-Exchange-CrossTenant-AuthSource: SA0PR03MB5610.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2022 10:30:56.6269
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bH2vgfAnvnQWt7K6aFpUsSlyLq2k2gOWiq4YOLFmoNIZ8bLts5zybpa/QV/eh15Sw/hNt8muWnSYtH1rnShSBQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6256
X-OriginatorOrg: citrix.com

Introduce the CPUID flag to be used in order to signal the support for
using an extended destination ID in IO-APIC RTEs and MSI address
fields. Such format expands the maximum target APIC ID from 255 to
32768 without requiring the usage of interrupt remapping.

The design document describing the feature can be found at:

http://david.woodhou.se/15-bit-msi.pdf

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Changes since v1:
 - New in this version.
---
 xen/include/public/arch-x86/cpuid.h | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/xen/include/public/arch-x86/cpuid.h b/xen/include/public/arch-x86/cpuid.h
index ce46305bee..49bcc93b6b 100644
--- a/xen/include/public/arch-x86/cpuid.h
+++ b/xen/include/public/arch-x86/cpuid.h
@@ -102,6 +102,12 @@
 #define XEN_HVM_CPUID_IOMMU_MAPPINGS   (1u << 2)
 #define XEN_HVM_CPUID_VCPU_ID_PRESENT  (1u << 3) /* vcpu id is present in EBX */
 #define XEN_HVM_CPUID_DOMID_PRESENT    (1u << 4) /* domid is present in ECX */
+/*
+ * Bits 55:49 from the IO-APIC RTE and bits 11:5 from the MSI address can be
+ * used to store high bits for the Destination ID. This expands the Destination
+ * ID field from 8 to 15 bits, allowing to target APIC IDs up 32768.
+ */
+#define XEN_HVM_CPUID_EXT_DEST_ID      (1u << 5)
 
 /*
  * Leaf 6 (0x40000x05)
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Wed Feb 16 10:31:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 10:31:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273929.469256 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKHad-0007Em-JL; Wed, 16 Feb 2022 10:31:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273929.469256; Wed, 16 Feb 2022 10:31:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKHad-0007Ed-Fe; Wed, 16 Feb 2022 10:31:15 +0000
Received: by outflank-mailman (input) for mailman id 273929;
 Wed, 16 Feb 2022 10:31:14 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=oYE0=S7=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nKHac-0006Q9-FD
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 10:31:14 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8e511560-8f13-11ec-8eb8-a37418f5ba1a;
 Wed, 16 Feb 2022 11:31:12 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8e511560-8f13-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645007472;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:content-transfer-encoding:mime-version;
  bh=qxuQethwfQpd/T7pRowavpDI1K+1cW3pPru2nYffN4w=;
  b=M6sHPKZlDaNeNu3A0KUjstX4UJr0fTttHj4+oM6OZTUaAt71+1Kc9ZCG
   11RT6Vb6ly2od0RqLp1eshprAPd7I5c3pWXBBzKtuOttGiED29pcnqN5f
   tkDymR9wcchVCMLmzkqrNA6P7EAkvRHiQL8kP84moVnb3LlSl58o+modT
   k=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: 5UUH/pGaBEsRVlYbTpZCdYq6JNxUhg8Jt/SXXMhMVSgSoqglBWAJscGkv0uGKOQOFztYHdrrYv
 xGcOlsA7kB6/GVZwjDCVbtPsVHNVauQ6+rU04S5JS3yES5dHiYNdMzGvohyhE8okxyxlGqmqK5
 A2iWXKU+8LrtT8U/tdYJQiKe+52+ObI70WQkanmKNjINxndjlq4Jvdch6+M4ogb01XApOYyiAG
 NSu2IDAMyoShcwUlLPmi4KLaigulYY+/F+sg8JpdIxdMCXaFrA4TGh/denCGHtpQrTX+R42KN2
 dPib3g8d3oQuQf7B451t44ZE
X-SBRS: 5.1
X-MesageID: 63768772
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:eMcmuqlMvDGQ5msBefar5s/o5gwgIURdPkR7XQ2eYbSJt1+Wr1Gzt
 xJKD2yEOvfbYzekeNAkaYrg9RsA7MTdnd9rQARvrCo3RSMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BClVlxJVF/fngqoDUUYYoAQgsA180IMsdoUg7wbRh2Nc22YHR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 PF9i5DheCMYAqvFwtw7CERVOANfNpQTrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBNPsM44F/Glp0BnSDOo8QICFSKLPjTNd9Glr2Z4eQqmED
 yYfQQFLNS2bRSUUAQZUWZQ8rueqgH3zejIN/Tp5ooJoujOOnWSdyoPFMsfRe9GMbdVYmACfv
 G2u13/iHhgQOdibyDyE2nGhnOnCmWX8Qo16PKWx6/pCkFCVgGsJB3U+Sl+TsfS/zEmkVLp3O
 0ESvyYjs6U23EiqVcXmGQ21pmaeuRwRUMYWFPc1gCmB1a/LuS6YAGYeRzJMYdBgs9U5LRQo3
 FKUm9LiBRR0raaYD3ma89+pQSiaYHZPazVYPGldEFVDs4KLTJwPYgznauZdHP+EquzJHziq+
 xbR8SUVpZQYtJtev0mkxmzvjzWpr5nPawc64ATLQ26ohj9EiJ6Zi5+AsgaCs6sZRGqNZhzY5
 SVfxZDChAwbJczVzESwrPMx8KZFDhpvGBnVmhZREpYo7FxBEFbzLNkLsFmSyKqEW/vomAMFg
 meO4Wu9B7cJZRNGiJObharrVqzGKoC6SLzYugj8NIYmX3SIXFbvENtSTUCRxXvxt0MnjLsyP
 5yWGe71UypGWPk+lmvnFr5HuVPO+szY7TmOLXwc5075uYdymVbPEetVWLdwRrxRAFy4TPX9r
 I8EapriJ+R3W+zieCjHmbP/3nhRRUXX8ave8pQNHsbae1IOMDh4V5f5nONwE6Q4zv89vrqZo
 RmAtrpwlQOXaYvvcl7RNBiOqdrHAP5CkJ7MFXZ8bQzziid5ONvHAWV2X8JfQITLPddLlJZcZ
 /IEZ9+BErJITDHG8C4adp7zsMppcxHDuO5EF3PNjOEXc8EySgrX1MXjewezpiACAjDu7Zk1o
 qG61xOdSp0GHlwwAMHTYfOp7lWwoXlCx74iAxqWeoFeKBf27YxnCy3tlftrccsCHgrOm2mB3
 AGMDBZG+eSU+90p8MPEjLyvppuyF7csBVJTGmTWtO7kNSTT8me575VHVeKEIWLUWG/uof3wb
 uRJ1fDsdvYAmQ8S4YZ7Fr9qy4M45sfu+OAGnlg1Qi2TYg3yWL16I3SA0c1ejYF3x+dU6VmsR
 0aC2thGIrHVasnrJ0EceVg+ZeOZ2PBKxjSLtaYpIF/37TNc9aacVRkAJAGFjSFQIecnMI4hx
 ut96sca5xbm10gvO9eCyCtV636NPjoLVKB+7sMWB4riiwwKzFBeYMODVn+qsc/XM9gcYFM3J
 jK0hbbZg+UOz0XPRHM/CHzR0LcPnp8Joh1LkAcPKlnhdgApXRPrMMm9KQgKczk=
IronPort-HdrOrdr: A9a23:zw2NzaCBFdlHGiHlHelW55DYdb4zR+YMi2TDt3oddfWaSKylfq
 GV7ZAmPHrP4gr5N0tOpTntAse9qBDnhPtICOsqTNSftWDd0QPFEGgL1+DfKlbbak/DH4BmtJ
 uJc8JFeaDN5VoRt7eH3OFveexQv+Vu88qT9JnjJ28Gd3AMV0n5hT0JcTpyFCdNNW97LKt8Lr
 WwzOxdqQGtfHwGB/7LfEXsD4D41qT2fIuNW29/OyIa
X-IronPort-AV: E=Sophos;i="5.88,373,1635220800"; 
   d="scan'208";a="63768772"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cIfh7YMa0TpVXz1blYI4bBZwY2rlL5JrXyB35aPVYn6p2JQ+uU5fJZA7IsHcxQCx9GMKi2hz46oU/cUXOuuwoQV90q3LRPQ+tlznnfLfTlgVcDjxWKH0s9+KIyKt+n3tjfoPWFyIrGmp4e2BLI/D4ZvfAV60T95NoQbfqK+lVPXzSBKJtcSpMhFI/heTzFS69cxKLa7ctkueA/1lBZVgtP3RwQBlp7czllOiU7oHZDNM7LcAoYgX7eq+dkS0Xp6rWQiAz0iGccJ3VUHJbGUOdodujc5uZ2RkZdSykW2/8bdV6+UxTcFhfaESNBKl760IH81aAYrqWGwy7CeiIeomhQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=SBfiZgeoEobC8xSnV92kybukGWhlimNIsfw/oOQii3E=;
 b=AJCQ4he8iuQZaTnHzpCeZVNvdQxouBB6WDyCohKOh4UG7sBpr842JLfao0w5qlIDSLTqD+VeeU59e3LZWWoUfB5/nFvg8sDV6qg8NvC6Ng7cW3OoFN5fUPtsr47JIyr1oM3vEtjcvV7fU71kDXleIbbnWhBKhEq+ctLlpY/wkrAHTT1b6A+jtLX8gNAPzYO70+ipJHW0TvYkzwhM/FuNq6P1iAORKWVeUiD0ke38fKgY3ZNF5zZ2sZG8ay4JDYAxFtHEZ04qgi5vY5bzjEMngzJtMq1Q2paleZ0Yrsx9Ui79Vxz3zTevei8OVeTNvAt3qknVoQrpyS2w7EoR5F/4Ew==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=SBfiZgeoEobC8xSnV92kybukGWhlimNIsfw/oOQii3E=;
 b=U18ys0vn/HVPNPrPBFEy6ER7io1JgTzdWTT82u/42wGcpfcwbaCFRlMikwNxwMr+WaPh6bCrLYbv/c1ap8ZLOtLbDjiY6iN0mHv4JJnFBI+MygcaBbCCVKodfVKKqD0C3r2nD/u1o9WxowYj1wgOjWGJvL6VGAJ4PZOJZUX4fIY=
From: Roger Pau Monne <roger.pau@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: <dwmw2@infradead.org>, Roger Pau Monne <roger.pau@citrix.com>, Jan Beulich
	<jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu
	<wl@xen.org>, George Dunlap <george.dunlap@citrix.com>, Julien Grall
	<julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Paul Durrant
	<paul@xen.org>
Subject: [PATCH v2 3/5] x86/vmsi: add support for extended destination ID in address field
Date: Wed, 16 Feb 2022 11:30:24 +0100
Message-ID: <20220216103026.11533-4-roger.pau@citrix.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220216103026.11533-1-roger.pau@citrix.com>
References: <20220216103026.11533-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO4P123CA0347.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:18d::10) To SA0PR03MB5610.namprd03.prod.outlook.com
 (2603:10b6:806:b2::9)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4795dab4-8efd-449e-e579-08d9f137702c
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6256:EE_
X-Microsoft-Antispam-PRVS: <SJ0PR03MB6256CD733284D03796847FA88F359@SJ0PR03MB6256.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: YVWifTXL7IE5EOwo4WPERPxbr8F6V+r4qnEwt0ktehPM69LQQxvijuPy3EuoNXRHnFOYOyJ2oq9jlN4/Rq/Vbtxd+ktcWaFJTivvi6YtVhindWGjSRR4b+/2Z4ryZlfwfi8on9KBGqq12XiH/eFviikGwnflnr/fg6VTE573HbBBq6OS37upnliEo3OvxSONVaeCjrODS5DdJpoyuPjElkeIn+sEPeseyHYe7x/xBhufxRwRJ42oVTFrA/Wd6fsvDafhL8G8YyoD5vqWktVyx1PKzVMRX+AkxKyIbLkEI0oqegRGxdeGA2/2QCGJighOABIJNxI9WL9jf8gtozbYhocfGUJb8A0w/Up24/tgVYI3sPQvvKY77ntq5XyEppaamfzbNiAhxJA8MAulmhNgkGHx+qsGw6u1w206nMEV66087Rb2v0RqpVND0f/kgtk8FB/4fuKibXqG3I0cNt7bc0zOMwzr2WPo0nR8XLRwn1GYDhIZDIWTbTe9qA870pEnskgjB36zjaFiiaQaPIvFVHBXVhqocETYF8LnpONxGjiCzurUNDGIC9NoyZ/xE2686113roM2D+r5yj0xnBdiR7JCAKw/OzBX2T+E2LpaDsJSFADYGafmQZAyWbQHJVUoZNsos2j0Jj2pom0c9FC27A==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA0PR03MB5610.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(8676002)(2616005)(66946007)(6506007)(6512007)(316002)(26005)(1076003)(66556008)(508600001)(86362001)(6486002)(6916009)(6666004)(54906003)(82960400001)(66476007)(83380400001)(4326008)(38100700002)(36756003)(5660300002)(2906002)(8936002)(30864003)(186003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WXRUbzlud0Nob2pLTDhOZmJNaE9Ld3lKVTVWOGQ2L3MraHJObFZ3eGhGSjlG?=
 =?utf-8?B?enhJZWlFMXN1NVRyYzNsWCs3MDhJalVxVjJvV1lVVTdLUy9WYldvTXBnWGJP?=
 =?utf-8?B?VEVGVjVIM1lYRi9pVkZtRExjWEEwclE1aVdjcStBb2hKZzNsVFM0bzhYMC9M?=
 =?utf-8?B?dm9SVWtINStDbEVZQXMrUU05dEsvaDB5UEFkZjJUSzRIVm80MW9KcS8xVkdp?=
 =?utf-8?B?TmxMVTJ0N2ozWXd4akZXT2hwbW1YMDhRRDR0MHNUL2hhZFFBc2hGZExoTEUr?=
 =?utf-8?B?QXdUMGNiVnA1RzNhN3pwOTYzVkVuWWRHSXNtTnozd3E5V2dPb0dHOWxHcm80?=
 =?utf-8?B?V2NMckN5LzBKeTF0MUJ5T3VYdU9DR2xPOXRKTk10dVdiVVIrbjdEQlcyZ093?=
 =?utf-8?B?aUFKaFBzWCtUMWQ1WXp2d3ZuSHJOTGRtZDVjUVRGai8rWHRMMU1McUo2S0lW?=
 =?utf-8?B?bWFXWG42aVlRKzdGYWRvMklnYkNKOXBqUi8zUldGa0tPK3FyaVA1OThPRENS?=
 =?utf-8?B?OFRFR0hpdUhrazR2eUdQZkltOGJOdG43TDdFcEJkb2ttaHF5T0FoellNQlRM?=
 =?utf-8?B?MkVURFhrUHNobnRGa0pjcGlHVWJxVWlxb093M09LdDNBZ0ZTZUxIUG9OdzVL?=
 =?utf-8?B?bDlVMU5iYitCN0Q0UnFud1pyczV2WlhJdWlhbmZwZWhDRlhwRlhOYWQyK1B5?=
 =?utf-8?B?NnFweU5aTWxhUlVlMSsvQ3AxUDBTVGtMcmg0bGVZanFoWUVpaTFXV0RYRXdX?=
 =?utf-8?B?R1dqSTdkUjRKS3dXc0VjVUNVTUlJSm9ocDE3ZmZDOE5GYzlMaE5OeTZlRHI2?=
 =?utf-8?B?U2ZxQWVLK3VtUHBkY3J2TFkzZE9adnNSM2tadEFjbmtra1NCWWN3d2VFZjVj?=
 =?utf-8?B?RnNnclhFWUtxZEJkZWNPem1kUjNJSWk3VUJ0a2dmN2RVTWd1aHVNMmhMdFFn?=
 =?utf-8?B?VW1JY3c4MUdvYlFIN1JvazI5dFhGdklkaTVBUEQ3S1BlNmRrRXZSc0kxZEU0?=
 =?utf-8?B?TlpHVEtCaDFiUEVwUWpTTDgrWGxqUzV1VEZwNXNJVVpNTVNFZHh6OFRiVGJJ?=
 =?utf-8?B?T043UUxyZjl1ZkdVUmtYKytiWTB4djAxYittY25HZjl5VUZWMWczRUxBaTg5?=
 =?utf-8?B?SEsvWWMvZ0JPak9HZjFicDNQUHR3eHhnYlJnUUVyWVBFYmhJb1JlanlGYm16?=
 =?utf-8?B?T21Ya0J6UGg5RDc5MXQ1TFpLNDdCRXBGNkhRSjhxZnlJWDlMVjk5a2dLUVdM?=
 =?utf-8?B?SkUyb3I0dDJWQUx4Zm5uWVRFMm05Zkxwc0taeFFMaDBJczExRkJ3MThudHhM?=
 =?utf-8?B?eHlmN3RvV1kzdUFFbEVnV3EzcnVvT054bkRyWTRhYUhyS241WEJHcTVaZEtx?=
 =?utf-8?B?QnI0bXlpUWFBQ2duZUpyejczZzhod2pVa2t6ZDZ2cGZNSzMzZmZWdWR4cHlI?=
 =?utf-8?B?ZUZwSHBxTk5hTDhTVjdYRWV2MFFUZFNoTWZmY2RwYWRsZ3E3TGRZWlYzM2ps?=
 =?utf-8?B?ZmhzOTdURDNyY0tGenRSWVFGVVJSeE1Nd1RvWkd6Ni9KUVlNUlRUa3RjRlNO?=
 =?utf-8?B?VHlHL0EzbCtKOXc2Z2JVcWQ3UUVwbFJhUFhCb2wzYnB3TUtURWFyYkcvcHVK?=
 =?utf-8?B?eXlYV0hrZXBqc0t2Z3dDS3dzUlZqV1dYcGw2bGs3VllVRTUzaVhoN3RhZFFX?=
 =?utf-8?B?SHEreGY4YkEzVEVML0dwV2NkZVFTNFM5aDRxWFQ2R3ZDTWZGUTYzK1NVbjV1?=
 =?utf-8?B?dkN1a1lVQWNpVCtlVGZiZ3pjWjVRYTFqWk14RVV5U2QzaDRKUXc4b29ZWUpD?=
 =?utf-8?B?K2hjL1RMbnhkN0FxMFg4QlVXVXdpTnNLM2V3WnVhQnNBTmFIT2d3RVU4M29z?=
 =?utf-8?B?eVJOcjBocDZjdSswbGlIK2dVVjFya3pZd29icWRyRW9kYmhWMmkzWk1XNW9I?=
 =?utf-8?B?SHk1ZHJnMnlMNXk3ck82RzVyVThoelRuNUJCeWk5aTRvT1p3dWhRWEtUeDM0?=
 =?utf-8?B?dHFEd0lxNUI3dTBacWlHZlpBbE9xUExlMjRwSHZwUTQ1TnczdzgvV3N4K0Iv?=
 =?utf-8?B?a2ZpbXNxeU43eS9PWEY0Qjg1eWFzbFlwajVHOTBCS3ZaeW9Wd085aXZkSlVM?=
 =?utf-8?B?eXB2VGdRenh1SHEwM1BKbXNxVVdYd1Z4Unpnbjc3WGY0WFEzbW43YlBkUnpW?=
 =?utf-8?Q?WTr+eeFBfTMua+s9ujd3QAI=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4795dab4-8efd-449e-e579-08d9f137702c
X-MS-Exchange-CrossTenant-AuthSource: SA0PR03MB5610.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2022 10:31:05.9008
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1oofrVM9duc4RJd50aJ4155qdwSeyM6/PzwtMT3n2sxyegzuqHF8Uiwq1ihL9hQ2v4Fw7qz5mK7ygWm5MPGgkQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6256
X-OriginatorOrg: citrix.com

Both QEMU/KVM and HyperV support using bits 11:5 from the MSI address
field in order to store the high part of the target APIC ID. This
allows expanding the maximum APIC ID usable without interrupt
remapping support from 255 to 32768.

Note the interface used by QEMU for emulated devices (via the
XEN_DMOP_inject_msi hypercall) already passes both the address and
data fields into Xen for processing, so there's no need for any change
to QEMU there.

However for PCI passthrough devices QEMU uses the
XEN_DOMCTL_bind_pt_irq hypercall which does need a modification to the
gflags field in order to pass an APIC destination ID greater than
255.

Take the opportunity to make the domain parameter of
hvm_girq_dest_2_vcpu_id const while modifying the other function
parameters. Also adjust dest_mode when touching related code to make
it bool.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Changes since v1:
 - Do not expose extended destination ID support.
 - Use d->arch.ext_dest_id.
 - Add comment clarifying the usage of MSI_ADDR_VIRT_EXT_DEST_ID_MASK.
---
 xen/arch/x86/hvm/irq.c             |  5 +++-
 xen/arch/x86/hvm/vmsi.c            | 43 +++++++++++++++++++++---------
 xen/arch/x86/include/asm/hvm/hvm.h |  5 ++--
 xen/arch/x86/include/asm/msi.h     |  7 +++++
 xen/drivers/passthrough/x86/hvm.c  | 11 +++++++-
 xen/drivers/vpci/msi.c             |  2 +-
 xen/include/public/domctl.h        |  1 +
 xen/include/xen/vpci.h             |  2 +-
 8 files changed, 58 insertions(+), 18 deletions(-)

diff --git a/xen/arch/x86/hvm/irq.c b/xen/arch/x86/hvm/irq.c
index 52aae4565f..e10e085a55 100644
--- a/xen/arch/x86/hvm/irq.c
+++ b/xen/arch/x86/hvm/irq.c
@@ -383,7 +383,7 @@ int hvm_set_pci_link_route(struct domain *d, u8 link, u8 isa_irq)
 int hvm_inject_msi(struct domain *d, uint64_t addr, uint32_t data)
 {
     uint32_t tmp = (uint32_t) addr;
-    uint8_t  dest = (tmp & MSI_ADDR_DEST_ID_MASK) >> MSI_ADDR_DEST_ID_SHIFT;
+    unsigned int dest = MASK_EXTR(tmp, MSI_ADDR_DEST_ID_MASK);
     uint8_t  dest_mode = !!(tmp & MSI_ADDR_DESTMODE_MASK);
     uint8_t  delivery_mode = (data & MSI_DATA_DELIVERY_MODE_MASK)
         >> MSI_DATA_DELIVERY_MODE_SHIFT;
@@ -391,6 +391,9 @@ int hvm_inject_msi(struct domain *d, uint64_t addr, uint32_t data)
         >> MSI_DATA_TRIGGER_SHIFT;
     uint8_t vector = data & MSI_DATA_VECTOR_MASK;
 
+    if ( vector && d->arch.ext_dest_id )
+        dest |= MASK_EXTR(tmp, MSI_ADDR_VIRT_EXT_DEST_ID_MASK) << 8;
+
     if ( !vector )
     {
         int pirq = ((addr >> 32) & 0xffffff00) | dest;
diff --git a/xen/arch/x86/hvm/vmsi.c b/xen/arch/x86/hvm/vmsi.c
index 13e2a190b4..4af550cc2a 100644
--- a/xen/arch/x86/hvm/vmsi.c
+++ b/xen/arch/x86/hvm/vmsi.c
@@ -66,7 +66,7 @@ static void vmsi_inj_irq(
 
 int vmsi_deliver(
     struct domain *d, int vector,
-    uint8_t dest, uint8_t dest_mode,
+    unsigned int dest, bool dest_mode,
     uint8_t delivery_mode, uint8_t trig_mode)
 {
     struct vlapic *target;
@@ -107,11 +107,14 @@ void vmsi_deliver_pirq(struct domain *d, const struct hvm_pirq_dpci *pirq_dpci)
 {
     uint32_t flags = pirq_dpci->gmsi.gflags;
     int vector = pirq_dpci->gmsi.gvec;
-    uint8_t dest = (uint8_t)flags;
+    unsigned int dest = MASK_EXTR(flags, XEN_DOMCTL_VMSI_X86_DEST_ID_MASK);
     bool dest_mode = flags & XEN_DOMCTL_VMSI_X86_DM_MASK;
     uint8_t delivery_mode = MASK_EXTR(flags, XEN_DOMCTL_VMSI_X86_DELIV_MASK);
     bool trig_mode = flags & XEN_DOMCTL_VMSI_X86_TRIG_MASK;
 
+    if ( d->arch.ext_dest_id )
+        dest |= MASK_EXTR(flags, XEN_DOMCTL_VMSI_X86_EXT_DEST_ID_MASK);
+
     HVM_DBG_LOG(DBG_LEVEL_IOAPIC,
                 "msi: dest=%x dest_mode=%x delivery_mode=%x "
                 "vector=%x trig_mode=%x\n",
@@ -123,7 +126,8 @@ void vmsi_deliver_pirq(struct domain *d, const struct hvm_pirq_dpci *pirq_dpci)
 }
 
 /* Return value, -1 : multi-dests, non-negative value: dest_vcpu_id */
-int hvm_girq_dest_2_vcpu_id(struct domain *d, uint8_t dest, uint8_t dest_mode)
+int hvm_girq_dest_2_vcpu_id(const struct domain *d, unsigned int dest,
+                            bool dest_mode)
 {
     int dest_vcpu_id = -1, w = 0;
     struct vcpu *v;
@@ -636,15 +640,21 @@ void msix_write_completion(struct vcpu *v)
 }
 
 #ifdef CONFIG_HAS_VPCI
-static unsigned int msi_gflags(uint16_t data, uint64_t addr, bool masked)
+static unsigned int msi_gflags(uint16_t data, uint64_t addr, bool masked,
+                               bool ext_dest_id)
 {
+    unsigned int dest = MASK_EXTR(addr, MSI_ADDR_DEST_ID_MASK);
+
+    if ( ext_dest_id )
+        dest |= MASK_EXTR(addr, MSI_ADDR_VIRT_EXT_DEST_ID_MASK) << 8;
+
     /*
      * We need to use the DOMCTL constants here because the output of this
      * function is used as input to pt_irq_create_bind, which also takes the
      * input from the DOMCTL itself.
      */
-    return MASK_INSR(MASK_EXTR(addr, MSI_ADDR_DEST_ID_MASK),
-                     XEN_DOMCTL_VMSI_X86_DEST_ID_MASK) |
+    return MASK_INSR(dest, XEN_DOMCTL_VMSI_X86_DEST_ID_MASK) |
+           MASK_INSR(dest, XEN_DOMCTL_VMSI_X86_EXT_DEST_ID_MASK) |
            MASK_INSR(MASK_EXTR(addr, MSI_ADDR_REDIRECTION_MASK),
                      XEN_DOMCTL_VMSI_X86_RH_MASK) |
            MASK_INSR(MASK_EXTR(addr, MSI_ADDR_DESTMODE_MASK),
@@ -698,7 +708,8 @@ static int vpci_msi_update(const struct pci_dev *pdev, uint32_t data,
             .irq_type = PT_IRQ_TYPE_MSI,
             .u.msi.gvec = (vector & ~vector_mask) |
                           ((vector + i) & vector_mask),
-            .u.msi.gflags = msi_gflags(data, address, (mask >> i) & 1),
+            .u.msi.gflags = msi_gflags(data, address, (mask >> i) & 1,
+                                       pdev->domain->arch.ext_dest_id),
         };
         int rc = pt_irq_create_bind(pdev->domain, &bind);
 
@@ -826,8 +837,13 @@ void vpci_msi_arch_init(struct vpci_msi *msi)
     msi->arch.pirq = INVALID_PIRQ;
 }
 
-void vpci_msi_arch_print(const struct vpci_msi *msi)
+void vpci_msi_arch_print(const struct vpci_msi *msi, const struct domain *d)
 {
+    unsigned long dest = MASK_EXTR(msi->address, MSI_ADDR_DEST_ID_MASK);
+
+    if ( d->arch.ext_dest_id )
+        dest |= MASK_EXTR(msi->address, MSI_ADDR_VIRT_EXT_DEST_ID_MASK) << 8;
+
     printk("vec=%#02x%7s%6s%3sassert%5s%7s dest_id=%lu pirq: %d\n",
            MASK_EXTR(msi->data, MSI_DATA_VECTOR_MASK),
            msi->data & MSI_DATA_DELIVERY_LOWPRI ? "lowest" : "fixed",
@@ -835,8 +851,7 @@ void vpci_msi_arch_print(const struct vpci_msi *msi)
            msi->data & MSI_DATA_LEVEL_ASSERT ? "" : "de",
            msi->address & MSI_ADDR_DESTMODE_LOGIC ? "log" : "phys",
            msi->address & MSI_ADDR_REDIRECTION_LOWPRI ? "lowest" : "fixed",
-           MASK_EXTR(msi->address, MSI_ADDR_DEST_ID_MASK),
-           msi->arch.pirq);
+           dest, msi->arch.pirq);
 }
 
 void vpci_msix_arch_mask_entry(struct vpci_msix_entry *entry,
@@ -891,11 +906,16 @@ void vpci_msix_arch_init_entry(struct vpci_msix_entry *entry)
 
 int vpci_msix_arch_print(const struct vpci_msix *msix)
 {
+    const struct domain *d = msix->pdev->domain;
     unsigned int i;
 
     for ( i = 0; i < msix->max_entries; i++ )
     {
         const struct vpci_msix_entry *entry = &msix->entries[i];
+        unsigned long dest = MASK_EXTR(entry->addr, MSI_ADDR_DEST_ID_MASK);
+
+        if ( d->arch.ext_dest_id )
+            dest |= MASK_EXTR(entry->addr, MSI_ADDR_VIRT_EXT_DEST_ID_MASK) << 8;
 
         printk("%6u vec=%02x%7s%6s%3sassert%5s%7s dest_id=%lu mask=%u pirq: %d\n",
                i, MASK_EXTR(entry->data, MSI_DATA_VECTOR_MASK),
@@ -904,8 +924,7 @@ int vpci_msix_arch_print(const struct vpci_msix *msix)
                entry->data & MSI_DATA_LEVEL_ASSERT ? "" : "de",
                entry->addr & MSI_ADDR_DESTMODE_LOGIC ? "log" : "phys",
                entry->addr & MSI_ADDR_REDIRECTION_LOWPRI ? "lowest" : "fixed",
-               MASK_EXTR(entry->addr, MSI_ADDR_DEST_ID_MASK),
-               entry->masked, entry->arch.pirq);
+               dest, entry->masked, entry->arch.pirq);
         if ( i && !(i % 64) )
         {
             struct pci_dev *pdev = msix->pdev;
diff --git a/xen/arch/x86/include/asm/hvm/hvm.h b/xen/arch/x86/include/asm/hvm/hvm.h
index b44bbdeb21..37e9d4c0fc 100644
--- a/xen/arch/x86/include/asm/hvm/hvm.h
+++ b/xen/arch/x86/include/asm/hvm/hvm.h
@@ -270,11 +270,12 @@ uint64_t hvm_get_guest_time_fixed(const struct vcpu *v, uint64_t at_tsc);
 
 int vmsi_deliver(
     struct domain *d, int vector,
-    uint8_t dest, uint8_t dest_mode,
+    unsigned int dest, bool dest_mode,
     uint8_t delivery_mode, uint8_t trig_mode);
 struct hvm_pirq_dpci;
 void vmsi_deliver_pirq(struct domain *d, const struct hvm_pirq_dpci *);
-int hvm_girq_dest_2_vcpu_id(struct domain *d, uint8_t dest, uint8_t dest_mode);
+int hvm_girq_dest_2_vcpu_id(const struct domain *d, unsigned int dest,
+                            bool dest_mode);
 
 enum hvm_intblk
 hvm_interrupt_blocked(struct vcpu *v, struct hvm_intack intack);
diff --git a/xen/arch/x86/include/asm/msi.h b/xen/arch/x86/include/asm/msi.h
index e228b0f3f3..9d9509a368 100644
--- a/xen/arch/x86/include/asm/msi.h
+++ b/xen/arch/x86/include/asm/msi.h
@@ -54,6 +54,13 @@
 #define MSI_ADDR_DEST_ID_SHIFT		12
 #define	 MSI_ADDR_DEST_ID_MASK		0x00ff000
 #define  MSI_ADDR_DEST_ID(dest)		(((dest) << MSI_ADDR_DEST_ID_SHIFT) & MSI_ADDR_DEST_ID_MASK)
+/*
+ * Use the reserved bits 11:5 to store the high part of the APIC ID, that
+ * allows expanding the destination field from 8 to 15 bits. Note this is a
+ * feature only present in virtualized hardware and currently only exposed to
+ * guests but not used by the hypervisor itself.
+ */
+#define	 MSI_ADDR_VIRT_EXT_DEST_ID_MASK	0x0000fe0
 
 /* MAX fixed pages reserved for mapping MSIX tables. */
 #define FIX_MSIX_MAX_PAGES              512
diff --git a/xen/drivers/passthrough/x86/hvm.c b/xen/drivers/passthrough/x86/hvm.c
index 0b37cd145b..9c42ebe17a 100644
--- a/xen/drivers/passthrough/x86/hvm.c
+++ b/xen/drivers/passthrough/x86/hvm.c
@@ -269,7 +269,8 @@ int pt_irq_create_bind(
     {
     case PT_IRQ_TYPE_MSI:
     {
-        uint8_t dest, delivery_mode;
+        unsigned int dest;
+        bool delivery_mode;
         bool dest_mode;
         int dest_vcpu_id;
         const struct vcpu *vcpu;
@@ -346,6 +347,10 @@ int pt_irq_create_bind(
         /* Calculate dest_vcpu_id for MSI-type pirq migration. */
         dest = MASK_EXTR(pirq_dpci->gmsi.gflags,
                          XEN_DOMCTL_VMSI_X86_DEST_ID_MASK);
+        if ( d->arch.ext_dest_id )
+            dest |= MASK_EXTR(pirq_dpci->gmsi.gflags,
+                              XEN_DOMCTL_VMSI_X86_EXT_DEST_ID_MASK);
+
         dest_mode = pirq_dpci->gmsi.gflags & XEN_DOMCTL_VMSI_X86_DM_MASK;
         delivery_mode = MASK_EXTR(pirq_dpci->gmsi.gflags,
                                   XEN_DOMCTL_VMSI_X86_DELIV_MASK);
@@ -789,6 +794,10 @@ static int _hvm_dpci_msi_eoi(struct domain *d,
                                       XEN_DOMCTL_VMSI_X86_DEST_ID_MASK);
         bool dest_mode = pirq_dpci->gmsi.gflags & XEN_DOMCTL_VMSI_X86_DM_MASK;
 
+        if ( d->arch.ext_dest_id )
+            dest |= MASK_EXTR(pirq_dpci->gmsi.gflags,
+                              XEN_DOMCTL_VMSI_X86_EXT_DEST_ID_MASK);
+
         if ( vlapic_match_dest(vcpu_vlapic(current), NULL, 0, dest,
                                dest_mode) )
         {
diff --git a/xen/drivers/vpci/msi.c b/xen/drivers/vpci/msi.c
index 5757a7aed2..e1d8c1d6f2 100644
--- a/xen/drivers/vpci/msi.c
+++ b/xen/drivers/vpci/msi.c
@@ -297,7 +297,7 @@ void vpci_dump_msi(void)
                 printk(" vectors max: %u enabled: %u\n",
                        pdev->msi_maxvec, msi->vectors);
 
-                vpci_msi_arch_print(msi);
+                vpci_msi_arch_print(msi, d);
             }
 
             msix = pdev->vpci->msix;
diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
index 31ec083cb0..ba71ce1148 100644
--- a/xen/include/public/domctl.h
+++ b/xen/include/public/domctl.h
@@ -588,6 +588,7 @@ struct xen_domctl_bind_pt_irq {
 #define XEN_DOMCTL_VMSI_X86_DELIV_MASK   0x007000
 #define XEN_DOMCTL_VMSI_X86_TRIG_MASK    0x008000
 #define XEN_DOMCTL_VMSI_X86_UNMASKED     0x010000
+#define XEN_DOMCTL_VMSI_X86_EXT_DEST_ID_MASK 0xfe0000
 
             uint64_aligned_t gtable;
         } msi;
diff --git a/xen/include/xen/vpci.h b/xen/include/xen/vpci.h
index e8ac1eb395..354b37ef9c 100644
--- a/xen/include/xen/vpci.h
+++ b/xen/include/xen/vpci.h
@@ -162,7 +162,7 @@ int __must_check vpci_msi_arch_enable(struct vpci_msi *msi,
 void vpci_msi_arch_disable(struct vpci_msi *msi, const struct pci_dev *pdev);
 void vpci_msi_arch_update(struct vpci_msi *msi, const struct pci_dev *pdev);
 void vpci_msi_arch_init(struct vpci_msi *msi);
-void vpci_msi_arch_print(const struct vpci_msi *msi);
+void vpci_msi_arch_print(const struct vpci_msi *msi, const struct domain *d);
 
 /* Arch-specific vPCI MSI-X helpers. */
 void vpci_msix_arch_mask_entry(struct vpci_msix_entry *entry,
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Wed Feb 16 10:31:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 10:31:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273931.469267 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKHap-0007mn-1Q; Wed, 16 Feb 2022 10:31:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273931.469267; Wed, 16 Feb 2022 10:31:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKHao-0007me-Tr; Wed, 16 Feb 2022 10:31:26 +0000
Received: by outflank-mailman (input) for mailman id 273931;
 Wed, 16 Feb 2022 10:31:25 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=oYE0=S7=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nKHan-0006QF-EG
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 10:31:25 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9537cde4-8f13-11ec-b215-9bbe72dcb22c;
 Wed, 16 Feb 2022 11:31:23 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9537cde4-8f13-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645007483;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:content-transfer-encoding:mime-version;
  bh=1VExplsUc/jMeyloOEDLZd1rMjs8V3xmSLjMalaWzI4=;
  b=XbVYHOLHMrOO9ITwKlTWiaiRZOKVNftuW8GAAm7HkPgliOju+xER/nuc
   qAOHG34PTRH5FVKjhkJVlGhE2BTzKGCsn5fBtdkuzjQG/eAlmJxx9LUp1
   oNVtH76i0LTnJnap+A4eDTJh2P3C4j3sWtcKXYGDIW6iz0ycgG9ItWUyD
   Y=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: 9RFSBtBq4Pch33H8W5zita2dZl0xNQOZt0DTr0jfD0dIhVtdBPTHBIhpU2ke/IF1qtV2elJlE5
 Rs0Jk6ci02cmzf6E+2bp54ydJ+HQBHzgFQYqA94nFIllpPM1KeYBhKm061/5H4IU0amyaNyagL
 HVRqDUgW1De9Z2WZX1kKpE+qVs0DkqSeWMavi1LKG85C5ShOhcMYxVp/2RVNFKEmln0nrrkTJb
 SD3UFpr1bedhXHYme/scgQS6H8TEZBpjApDbirwOLMK/VCL/ETp5Lp8IHqY8Odd4MyRGkXfMD8
 GaNJriYGTEpG1CMYQt1XniZb
X-SBRS: 5.1
X-MesageID: 64733272
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:YPwM1qDd/H3NyxVW/3blw5YqxClBgxIJ4kV8jS/XYbTApG4lhTABy
 WMWUGGHbKyKM2TzKYpwa4628kIFucWEz99jQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMo/u1Si6FatANl1ElvU2zbue6WL6s1hxZH1c+En970Ew7wobVv6Yz6TSHK1LV0
 T/Ni5W31G+Ng1aY5UpNtspvADs21BjDkGtwUm4WPJinj3eH/5UhN7oNJLnZEpfNatI88thW5
 Qr05OrREmvxp3/BAz4++1rxWhVirrX6ZWBihpfKMkQLb9crSiEai84G2PQghUh/kASDgvwqk
 +90n8avExUPLKjItPheekwNe81+FfUuFL7vJHG+tYqYzlHccmuqyPJrZK00FdRGoKAtWzgIr
 KFGbmBWBvyAr7veLLaTUO5ji95lNMD2FIgepmth3XfSCvNOrZXrHfmVvoQCg21YasZmJOzxT
 pIHRBlWZUqbZSYMZmk3F5supbL97pX4W2IB8w/EzUYt2EDRxgFs1LnmMPLOZ8eHA85Smy6wm
 GXC+GjoBwAAA/aWwzGF73GEi/fGmGXwX4d6PKWx6/pCkFCVgGsJB3U+Sl+TsfS/zEmkVLp3I
 UEO5jAnq6R08UWxV8T8RDWxunvCtRkZM/JcDOglsimMzKTO6gqUD2RCSSROAPQ2uclzSTE02
 1uhm9LyGScpoLCTUWia9LqfsXW1Iyd9BW0fYS4JSyMV7t+lp5s85jrUVcpqGqOxitzzGBnzz
 iqMoSx4gK8c5fPnzI3iowqB2Wj14MGUEEhlvW07Q15J8CtiVYS4S9fz02Hxt+kaPqCLS12to
 Dstzp32AP81MbmBkymEQeMoFb6v5uqYPDC0vWODD6XN5Bz2pSf9INk4DCVWYR4wb51aIWOBj
 Fr75FsJjKK/KkdGekOej2iZL80xhZbtGt3+Phw/RoofO8MhHONrEcwHWKJx44wPuBV0+U3cE
 c3CGSpJMZr8If46pNZRb71AuYLHPghkmQvuqWnTlnxLK4a2an+PUqsiO1CTdO0/567siFyLr
 4oOapLQmkQOCbeWjszrHWg7dw1iwZ8TX86eliCqXrTbfloO9J8JV5c9Po/Ni6Q6xv8Ix48kD
 1m2W1NCyUqXuJE0AV7iV5yXU5u2BcwXhStiZUQEZA/0s1B+MdfHxPpOLPMfIOh4nNGPONYpF
 pHpje3bWa8RItkGkhxABaTAQHtKLkT731nfYHD8PVDSvfdIHmT0xzMtRSO2nAEmBSurr8ou5
 bqm0wLQW50YQAp+Ss3RbZqSI5mZ5BDxQcp+ABnFJMd9YkLp/NQ4IiD9lKZvccoNNQ/C1n2R0
 APPWUUUouzEookU9tjVhP/b89f1QrUmRkcKTXPG6buWNDXB+jbxy4F3T+vVLyvWU3n5+fv+a
 LwNne38KvAOgH1Dr5F4T+Rw1as76ta2/+1aww1oEW/ldVOuDr88cHCK0dMW7v9Gx6NDuBvwU
 UWKo4EINbKMMcLjMVgQOAt6MbjTiaBKwmHftK1nLl/76Sl7+Ku8fX9TZxTc2jZAKLZVMZ8+x
 btzssAh9AHi2AEhNcyLj34I+j3UfGAASaguqroTHJTv1lgw0lhHbJHRVn327ZWIZ4keO0UmO
 GbJ1q/LhrAazUveaXsjU3PK2LMF15gJvRlLyn4EJkiIxYWZ1qNmgkUJ/GRlVBlRwzVGz/l3a
 zpiOEBCLKmT+ytl2ZpYVGe2FgAdXBCU9yQdEbfSeLE1m6VwalHwEQ==
IronPort-HdrOrdr: A9a23:zcv1g68hp5DBu5b8h6Zuk+AiI+orL9Y04lQ7vn2ZKSY5TiVXra
 CTdZUgpHvJYVMqMk3I9uruBEDtex3hHP1OkOws1NWZLWrbUQKTRekP0WKL+Vbd8kbFh4xgPM
 lbEpSXCLfLfCVHZcSR2njFLz73quP3j5xBho3lvglQpRkBUdAG0+/gYDzraXGfQmN9dPwEPa
 vZ3OVrjRy6d08aa8yqb0N1JdQq97Xw5evbiQdtPW9e1DWz
X-IronPort-AV: E=Sophos;i="5.88,373,1635220800"; 
   d="scan'208";a="64733272"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=juG7/FEdqHumFa+gHTrl5r6QMIltR7s/13Q6RqdSclJnLUKqcyaHz6eh7AROR8zHUjsnZTMmg5ELQk9N4uhgoq0V/bZlWuwvmtb/AxpY+ld9o1DXsVDHj+xpu8DPF45Un8rR2bEYPBRcr3D3C3WALU95Jw7VCWaueC+E6nlxs6ZF5YdRGX4A34TSW6ep/mBcnaBGNe6UkAPNXlaVCCO4rP6QayBtOpXiF2d5FCpItysIiHCxRR85PVmQKJMHGVoE1O1DAwKguZePs1WGa7G8+LO4ey33dNlKQSsXI2aF5EUZrtNcvP2puUEbeYmpCq90wMr69SPqWHc2eq3gnCIT5w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=XYwFCVS+ocU5eNhwXct/uBxkJGH3tqXX4XbY/zZKx+U=;
 b=JFaGh/16tx+W/G4q4YjPIVXzYUvG6gsRFv/nx5aHsdLJQtBHEjcBdg4ivJPLlTa+m/8Chzm4hsUbh1CZHrCdSDL5z7QMBYw4WB3A0LoMu/Wu7QvB+WWB2uCZI5+YCzPZYQsvIb8Bq+D7CRFdtnOPc8aXfkWcdu7sq0JplMIMEifCxavxnag2VwtwkS0ihDyMuF/xVDU9mntW+qvZcF5bpX1GZnqBD37sbXFHiCnpdxTbxm158c660+/XfZeFBtCMo6/b21V5sQp9BMkDjNsWvpqB7oMrPt/Ezp51Zsp0XfKMM4cDuDw20tNwsEO6WTBR0IVdd+D+ecxIK5SSPP5IWQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=XYwFCVS+ocU5eNhwXct/uBxkJGH3tqXX4XbY/zZKx+U=;
 b=txZwMqYsW50k+0//sD3ONK0h0taQRHuCoKH0KK1BGhQN2Hmpqx8woPJ1Gh61kvJypzEYbMCQzKGGtxZ5wL909wZdyp5eofvgWX3tapUoMZTl+mqIOuDYYShKrNV/iht02MNljBMxkGFY1MKAAapHrzd+SRkUF/0cEIPmwNBlpJg=
From: Roger Pau Monne <roger.pau@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: <dwmw2@infradead.org>, Roger Pau Monne <roger.pau@citrix.com>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
	"Bertrand Marquis" <bertrand.marquis@arm.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
	Wei Liu <wl@xen.org>, Paul Durrant <paul@xen.org>
Subject: [PATCH v2 RFC 4/5] x86/ioreq: report extended destination ID support by emulators
Date: Wed, 16 Feb 2022 11:30:25 +0100
Message-ID: <20220216103026.11533-5-roger.pau@citrix.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220216103026.11533-1-roger.pau@citrix.com>
References: <20220216103026.11533-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO4P123CA0369.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:18e::14) To SA0PR03MB5610.namprd03.prod.outlook.com
 (2603:10b6:806:b2::9)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a2437f4a-f332-4497-152a-08d9f13773b7
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6256:EE_
X-Microsoft-Antispam-PRVS: <SJ0PR03MB6256BA37445574DD5219E2FC8F359@SJ0PR03MB6256.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:497;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: Tm73xpCiLc9BBWUUXdOcox7iX0NkzpD9OZhf7gRpmVsxu2yAh3PdDsqIOeA1x3jv82fpUrkKSfn8qSsQHa/GzE3EgHAQddsMBSZuDW2zQ6VhBWqRar2Hrly7vFUkOmLHLv4bgYQYRRfHiZICTc0IjZrBRaMqKMNcu3CmM/Ace6gZ3GQ79BtYeKXqOceXqzULzI6x1QYjcjMF75Os085qkoXdtLtm1SDvjNbeD1H+015y93cN36TdFK7dkDbmap+SjYoK1xNDDt9tEBak78XNmft6Eg6VxV29FLbk/Wap/6MD1jC4W19wcWK8Qk1Iezo7XbkNJMcpl/PDuIlkGInW6xV5gcbfFPOv5PXk9KWrdNDgmFwlRykupzZ9DAMNmpbQvYodCGYfKy+joWPP+7S98OIFUWWJtiVtzGc3O5rJAfxZYrp57ZaW/GZrH4jZpw3cI343bU1Sxvsjvfu17mncNZ0FTLzcrdJbpQl/vMp8pcno9sAS2iZJkMpQr9CGBVQQmtnUd0cSyxzhIgAgMJVp9mOxB5wjPdLUameGPLyCbDmftjkZY3o6NkdvLENMTbNCoYEfJh/aBvdsoQAJoDBkgcTyo6TQ9pzQxknk0MmZ16X6gFBHFt9aNM/Yy01ZK+TzN1qnxlWsXEM4XW2GI6cfRg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA0PR03MB5610.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(8676002)(2616005)(66946007)(6506007)(6512007)(316002)(26005)(1076003)(66556008)(508600001)(86362001)(6486002)(6916009)(6666004)(54906003)(82960400001)(66476007)(83380400001)(4326008)(38100700002)(36756003)(5660300002)(2906002)(8936002)(186003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eWl3S0NkZ3c1Nk1VTzA5VFBWRHRtTVhVUGdCOVNaTW5pS2JQb3FsTkJXeEJC?=
 =?utf-8?B?NWxkOUZYRW1SeERJOG5rWllYOTladW05Nis0b3VTTktvRjA0aWdHWVFQaStz?=
 =?utf-8?B?SDlVZE9oVTQya29Pdm8xeXo5cTZnWTZzZ25oQ1FDL21LRkFWcS9sTGYxQi8v?=
 =?utf-8?B?NDJITlA1RklXV3IrWnJ6RVJBME9DekdsNitjTWo5ZXpQOFVKNk9iVWZ2cWYz?=
 =?utf-8?B?S2JjUUxJbHZwb01QcFRRQyswTUs3ejZheDlkcG8rK2pPQ2Y4U0xCNzg0MnUz?=
 =?utf-8?B?TUtTSkhTSHgwc1FEdW81RDJ5cHg4dVJoUjRpcFV1ZjhEazBjOG8vbktzS050?=
 =?utf-8?B?NXpScG5PRzZnVFZDSXlnM2lrNUNWMlJGTDFXWEFMUmtkNjZ6ZU5Bblcra0Fu?=
 =?utf-8?B?U2h3VEtwTmxCK0ZhdTlZYkUwbEMwMjRiWlkxbUc1clFlRUYrdGJDVDhhY2xH?=
 =?utf-8?B?MlpGYVdWSS9iTDRoVVdDcDhaaFR1U1BwSGROZUllaXhPMk44VHV5N3R0dFFN?=
 =?utf-8?B?QW1aZjVMWXhhTmMrc1JsNjI3WllvcVQxQ1lxMGE1RHE4bGhMcW04M08xcDdr?=
 =?utf-8?B?ZEFUTGNNUjhVcHZTNG1yKzJhRUo1a2JmbEhLMkMyRmtOUmxWSGNvVHZIN05p?=
 =?utf-8?B?TnhhK2RRdW5SUDBJWkRaVnFXWXBkb0NWblErTXBZbWM0cXMwM2dnRDh4ZlVM?=
 =?utf-8?B?TjdVSGQwb0h0OWFvV09venV0akxobVFMRTlEN1F5UVU1Vit4eFVmVFZuczBl?=
 =?utf-8?B?dVlUQm41SEw2eFBEa1BHVklTSml1cmRYMk1vNXlwWGFxWEdVN3gyNXBMTGVI?=
 =?utf-8?B?aWkrM0crTUxXcnc3QXp2cXdaejRJL25iZmFOYm01ZHZmZTYwcGVNZkNyRUxz?=
 =?utf-8?B?ZDIwc3FDd3BjR2tFN1FyYUlNb3gzcVFBWkE1YVRrYlpzYktkVGUxZ094MWFH?=
 =?utf-8?B?OGVLREJpQXMzdGdUaUhNYnRRcjBMYjNiRVp5R3RMRlZUUUU2Y0VqZkpwbE1O?=
 =?utf-8?B?UmllOU5YMVlTUFFsY1p5S0hTTzZxY21aazMxekJYMnFmZzk4aTdYWTFUcGNv?=
 =?utf-8?B?L0UveTk0M29haEFqUjlPaHFub3VVU1BTNGVQOU1EYmMzak9EQWdrVTJGejA4?=
 =?utf-8?B?RVo5eUQ4ZEgrbmZPZWs0WHBMeFdEL0RsY3ZxZXZzWVcxWUtKQWVPbXF1NGV3?=
 =?utf-8?B?ejBXanluYXJSMW04U0xMNUNIK2ZzZCswSFRmeklSKzVBemdEdlpHT0lSQUxi?=
 =?utf-8?B?bXFJSEJ2YzB2MDduQXM0Q3RXeENNR2dTNUVHSnVaRzZHSkxJZ3B6bnhqZHEz?=
 =?utf-8?B?Q0FkL2pDeElNTlgvUGFnMVdRU2tkcTVmSFBxa3BFTFBTLzk1SEZiRk4rSGdO?=
 =?utf-8?B?b1YrMW5NNXRnenBRTTBUVjlBS2JRb0ZJekFIcy9SVWZMUmJlb3ZsY3MzbW9P?=
 =?utf-8?B?Q2dreG8vK2g5Z1NrdE1kdzc4NkdEZnN4Wklxb1FlUkJURHNNd1BxY3VHbG5H?=
 =?utf-8?B?cXBqN0ZYTURmWGlyV09jZFc2UXIrYUtUMUZ1bUlIUm9qd05QYUhEWlhLUzNF?=
 =?utf-8?B?cEdnaXkyZVZsY1Q2cUJoNW1ldWxBSUNhRXRaeTgvZ3NEWVduQVkyd0ZWbHJX?=
 =?utf-8?B?UURiR0QzL2FSVlV0bGtCYXJQM2JCTmErd2Roa2EwK2czcEFoNEF4YmZkNVhh?=
 =?utf-8?B?ZDNFQUNFVkt2WERZeDBuL3lheVlDaGtFSHVSUUZDbWVUQ20wNHpxbU13SGJZ?=
 =?utf-8?B?RnJKL21hRWJDMU9CVlI2dyttbGZaWDQydXhNTUMreXdDTm1jZTRTYXhXbHFo?=
 =?utf-8?B?QVFxL0MyeWpLVHYraWxzWGxROU9naE1QRENzb0FyM29ia2M4NVhsdERHQzNy?=
 =?utf-8?B?SDBNanVzUnh5MEdPbXRQb1NMazA1UkRkcEJVazliVGtJVlVIZzV0REtMNGI1?=
 =?utf-8?B?Z0doN1ZHQksxVDhyV3Y0c3pQVGNLdFZaNTlvdGJ6Ry8xUERlSXQ3V0oxd21V?=
 =?utf-8?B?ZWNQZC9US2ZaMkwrZmF6SE1tUmxvdnF0OTBlRERjeCtBa2crZU9Ta1NUQ01C?=
 =?utf-8?B?Y3ExUzE2aDVSUjJ4VXYvbGZsVUtQMFlXZDZwTVNSSDhpcU9WaHJSZytLejJW?=
 =?utf-8?B?bjJRMFdKb1NWVUZXUjgwRzhMNVhJbkRjelVub2dnYTVtd2tDVTJoNGxPT1pP?=
 =?utf-8?Q?7twKYwOU5F+W6fPU/iXOXE8=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a2437f4a-f332-4497-152a-08d9f13773b7
X-MS-Exchange-CrossTenant-AuthSource: SA0PR03MB5610.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2022 10:31:11.7916
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mltvKfNvcl6pyi61VvYLnLydlELmpEFUe7KQze6cTLgm5z1vQw4wcoN698ctwaexuJTu9xIIe3+DcSjEHF8CMA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6256
X-OriginatorOrg: citrix.com

Introduce a new arch specific field to report whether an emulator
supports the Extended Destination ID field, so that the hypervisor can
refrain from exposing the feature if one of the emulators doesn't
support it.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Changes since v1:
 - New in this version.
---
RFC: I find this kind of clumsy. In fact fully emulated devices
should already support Extended Destination ID without any
modifications, because XEN_DMOP_inject_msi gets passed the address and
data fields, so the hypervisor extracts the extended destination ID
from there.

PCI passthrough devices however use xc_domain_update_msi_irq and that
has leaked the gflags parameter in the API, even worse the position
of the flags are hardcoded in QEMU.

Should the clearing of ext_dest_id be limited to the domain using an
IOMMU?

RFC: Only enable ext_dest_id if max_cpu > 128? So the device model is
aware the domain must use ext_dest_id? (implies device model knows
APIC ID = CPU ID * 2)
---
 xen/arch/arm/ioreq.c           | 5 +++++
 xen/arch/x86/hvm/ioreq.c       | 7 +++++++
 xen/common/ioreq.c             | 8 +++++---
 xen/include/public/hvm/dm_op.h | 6 +++++-
 xen/include/xen/ioreq.h        | 2 ++
 5 files changed, 24 insertions(+), 4 deletions(-)

diff --git a/xen/arch/arm/ioreq.c b/xen/arch/arm/ioreq.c
index 308650b400..7d56d022c8 100644
--- a/xen/arch/arm/ioreq.c
+++ b/xen/arch/arm/ioreq.c
@@ -185,6 +185,11 @@ void arch_ioreq_domain_init(struct domain *d)
 {
 }
 
+void arch_ioreq_server_create(struct domain *d, int bufioreq_handling,
+                              ioservid_t *id, unsigned int arch_flags)
+{
+}
+
 /*
  * Local variables:
  * mode: C
diff --git a/xen/arch/x86/hvm/ioreq.c b/xen/arch/x86/hvm/ioreq.c
index 02ad9db565..3276f0360d 100644
--- a/xen/arch/x86/hvm/ioreq.c
+++ b/xen/arch/x86/hvm/ioreq.c
@@ -336,6 +336,13 @@ void arch_ioreq_domain_init(struct domain *d)
     register_portio_handler(d, 0xcf8, 4, hvm_access_cf8);
 }
 
+void arch_ioreq_server_create(struct domain *d, int bufioreq_handling,
+                              ioservid_t *id, unsigned int arch_flags)
+{
+    if ( !(arch_flags & X86_SUPPORTS_EXT_DEST_ID) )
+        d->arch.ext_dest_id = false;
+}
+
 /*
  * Local variables:
  * mode: C
diff --git a/xen/common/ioreq.c b/xen/common/ioreq.c
index 689d256544..d4d5c653c7 100644
--- a/xen/common/ioreq.c
+++ b/xen/common/ioreq.c
@@ -636,7 +636,7 @@ static void ioreq_server_deinit(struct ioreq_server *s)
 }
 
 static int ioreq_server_create(struct domain *d, int bufioreq_handling,
-                               ioservid_t *id)
+                               ioservid_t *id, unsigned int arch_flags)
 {
     struct ioreq_server *s;
     unsigned int i;
@@ -681,6 +681,8 @@ static int ioreq_server_create(struct domain *d, int bufioreq_handling,
     if ( id )
         *id = i;
 
+    arch_ioreq_server_create(d, bufioreq_handling, id, arch_flags);
+
     spin_unlock_recursive(&d->ioreq_server.lock);
     domain_unpause(d);
 
@@ -1340,11 +1342,11 @@ int ioreq_server_dm_op(struct xen_dm_op *op, struct domain *d, bool *const_op)
         *const_op = false;
 
         rc = -EINVAL;
-        if ( data->pad[0] || data->pad[1] || data->pad[2] )
+        if ( data->pad[0] || data->pad[1] )
             break;
 
         rc = ioreq_server_create(d, data->handle_bufioreq,
-                                 &data->id);
+                                 &data->id, data->arch_flags);
         break;
     }
 
diff --git a/xen/include/public/hvm/dm_op.h b/xen/include/public/hvm/dm_op.h
index fa3f083fed..c6c575328b 100644
--- a/xen/include/public/hvm/dm_op.h
+++ b/xen/include/public/hvm/dm_op.h
@@ -67,7 +67,11 @@ typedef uint16_t ioservid_t;
 struct xen_dm_op_create_ioreq_server {
     /* IN - should server handle buffered ioreqs */
     uint8_t handle_bufioreq;
-    uint8_t pad[3];
+
+/* Signals Xen the emulator supports the Extended Destination ID field. */
+#define X86_SUPPORTS_EXT_DEST_ID (1u << 0)
+    uint8_t arch_flags;
+    uint8_t pad[2];
     /* OUT - server id */
     ioservid_t id;
 };
diff --git a/xen/include/xen/ioreq.h b/xen/include/xen/ioreq.h
index a26614d331..f4566a1254 100644
--- a/xen/include/xen/ioreq.h
+++ b/xen/include/xen/ioreq.h
@@ -127,6 +127,8 @@ bool arch_ioreq_server_destroy_all(struct domain *d);
 bool arch_ioreq_server_get_type_addr(const struct domain *d, const ioreq_t *p,
                                      uint8_t *type, uint64_t *addr);
 void arch_ioreq_domain_init(struct domain *d);
+void arch_ioreq_server_create(struct domain *d, int bufioreq_handling,
+                              ioservid_t *id, unsigned int arch_flags);
 
 #endif /* __XEN_IOREQ_H__ */
 
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Wed Feb 16 10:31:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 10:31:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273935.469278 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKHas-0008Fl-C4; Wed, 16 Feb 2022 10:31:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273935.469278; Wed, 16 Feb 2022 10:31:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKHas-0008Fc-79; Wed, 16 Feb 2022 10:31:30 +0000
Received: by outflank-mailman (input) for mailman id 273935;
 Wed, 16 Feb 2022 10:31:28 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=oYE0=S7=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nKHaq-0006Q9-NP
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 10:31:28 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 98259578-8f13-11ec-8eb8-a37418f5ba1a;
 Wed, 16 Feb 2022 11:31:27 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 98259578-8f13-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645007487;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:content-transfer-encoding:mime-version;
  bh=KVCefupHgl8iFdyKIZI5zs9ugkHZAyHUnwwPql0iuFo=;
  b=V9HO7z9y8PiO9ppmYQsisY+je46MQnmiwboCEx7ixgzzmtlv45hYw0J5
   fgDseYoM5YeqTtl6cx71fLZV28dT2EfRsWeaXMfl9EJz5AzfQ1K/FNrXv
   5GANCsda5ob3nbYMC5l0hHzg+YyifygLrXMvcriwD6PkWJwSSVPQOqWqd
   M=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: LthxVy3Hwp8STD4YSf3vcQJjZHGMS97ClxTWIh5IUC6RJxFlWH4iIsel9KiPpUZzCHt10sN1Hk
 esZC7vatKtESDd7d1H9WqEsaJvn1TTpjTU/UNelDpdRYT9pCs2kKEhIktdYSh1Qpv10zdwfm5t
 TTf1qk435/x/Y3+xd78ioqb8k5uND56y4PNSCOe1TCDGKNBp7u+P/uP1JbqLMvwp/xKSeezGrz
 /llCdYFo1Ta1uBV129s7qwGBwaRXqNhejcVA7liIQ2NAUuvQg1X8C5LSqu/sXyTGJzZepemT//
 0KqkE7Jr7yXh5pQVzTU81lr4
X-SBRS: 5.1
X-MesageID: 64324582
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:B3wBtq9ijiB1h3pxrU/CDrUDa3mTJUtcMsCJ2f8bNWPcYEJGY0x3z
 jYeXmyHMvyPZDGkfd5wPt6w/U4Gu8LXy4Q2TAVt/ng8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhFWeIdA970Ug5w7Rg3NYx6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPh84
 ux/lpaSFzsEI4aPw/0SShVCHSBxaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguw5K8bmJsUHs2xIxjDFF/c2B5vERs0m4PcGgGxq2p0eR54yY
 eIGTT50bTDjUyRgJ04OT44MrdiqumnWJmgwRFW9+vNsvjm7IBZK+LrnPcfRe9eKbd5IhUver
 WXDl0zmBjkKOdrZziCKmlq8i+mKkS7lVYY6ELyj6uUskFCV3nYUChAdSR28u/bRokKhXs0FA
 00S9DAnoaU7+AqsVNaVYvGjiCfa5FhGAYMWSrBkrlHWokbJ3+qHLmUudwxiYv54iOIrbn9xz
 1CQk8nnBDM65dV5Vkmh3ruTqDqzPw0cImkDeTIIQGM53jXznG0gpkmRF4g+ScZZmvWwQGitm
 G7S8EDSkp1O1ZZj6kmtwbzQb9tATLDtRxV92AjYV3nNAuhRNN/8PNzABbQ2AJ99wGelorup4
 SBsdyu2trlm4XSxeMqlGrhl8FaBvavtDdEkqQQzd6TNDhz0k5JZQahe4StlOGBiOdsedDnib
 Sf74F0NuM4OZSH7PP4uOepd7vjGK4C6SLwJsdiOMLJzjmVZLlfbrEmCm2bMt4wSrKTcuf5mY
 srKGSpdJX0bFb5m3FKLqxQ1itcWKtQF7TqLH/jTlk3/uZLHPSL9YepVYTOmM7FihIvZ8Vq9z
 jqqH5bTo/mpeLalOXe/HE96BQ1iEEXX8ris+5wNLb/ceFM7cIzjYteIqY4cl0Vet/09vs/D/
 22nW18ez1z6hHbdLh6NZGwlY7TqNauTZ1piVcD1FVr3iXUlf6i166ITK8k+cbU9rbQxxv9oV
 fgVPc6HB60XGDjA/j0ca7j7rZBjK0v31V7fYXL9bWhtZYNkSizI5sTgIlnl+h4RA3flrsA5u
 bChiF/WGMJRWwR4Ac/KQ/uz1Fft72MFked/UhKQcNlecUnh6qZwLCn1gqNlKs0AM0yblDCby
 xyXEVETouyU+90599zAhKalqYa1ErQhQhoGTjeDtbvvbHvU5Guux4NEQd2kRzGFWTOm4rima
 MVU0+r4bK8NkmFVvtcuCL1s168/uYfi/ucI0gR+EXzXRF23Ebc8cGKe1MxCu6ARlL9UvQy6B
 hCG9tVAYOjbPcrkFBgaJRY/b/TF3vYRw2GA4fMwKUT8xSl24LvYDhkCY0jS0HRQfOlvLYco4
 eY9o8pHuQWwhy0jPsuCki0JpX+HKWYNUvl/u5wXaGMxZtHHFr2WjUTgNxLL
IronPort-HdrOrdr: A9a23:LFarF6/jX2G81IlLkK1uk+AiI+orL9Y04lQ7vn2ZKSY5TiVXra
 CTdZUgpHvJYVMqMk3I9uruBEDtex3hHP1OkOws1NWZLWrbUQKTRekP0WKL+Vbd8kbFh4xgPM
 lbEpSXCLfLfCVHZcSR2njFLz73quP3j5xBho3lvglQpRkBUdAG0+/gYDzraXGfQmN9dPwEPa
 vZ3OVrjRy6d08aa8yqb0N1JdQq97Xw5evbiQdtPW9e1DWz
X-IronPort-AV: E=Sophos;i="5.88,373,1635220800"; 
   d="scan'208";a="64324582"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gy3ojG65/3ycyR8hUILUqnRS4wjtamO5WafkAN25MnuyjjzC8/LhbFaMklPkWjcwNEcszzGjsvziodBR6aYIJ1b0MS4ZAcnbqvK1+V3DolCnqMRl4APgMweWHy3NugsROhUzSXRox3hbJ/CbTxmAGOQoiIO7h0hGg473crapK5WF3hhUFZ0IEJ1cpMIzFGqsWmBwI2+Kt0UGDcKdsmcEvuWpSx01RcaRlRMCe7yI7VRWAnLWPekU3nc2HzlZJ1K3cNJqb1vl1MkPRvIpqIWTADfmH8Y50Tc/sCoVKNpLvuEPdyvcvWRHWOihENeGGiQtesKKB7kd8BWgOk4FyTEE8w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=75VO+AU8QH9BrocEyWlwWVKugRCjMn/bwURNP9DnhoU=;
 b=hUi9WfY686v8Zx/hREPgGrgmCd2ZReXcy94bPAxZU4DU+P2yOPUXUjMpta6CdLDiX3tNtxGJD/ZK7DGHEAdekPBgddZ6JqLeGxEwjVZ87AnUewxMHPtsNB8o215r1HG6S+8lsqN5l8UFHh3Lew8BsHY01EuvzZcovC/QaDWcIEa545kcAeyfY2Ps6k4jGidFwbhlLYALRYhm/opfM0Y/83qskaos3hljpPRdErjrTrdJk2QKiu29HM1ZsZjSUMHy0mos5M0pcgqeLjNwhCaP/upM5ZBtLocNFPjNC/5lXqoe4/PL+/WIWo3iHCpOY2uM/LUlceVjJx4ft+24ra3vpQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=75VO+AU8QH9BrocEyWlwWVKugRCjMn/bwURNP9DnhoU=;
 b=r5eGgGtTzW95gYGRIcZbcRXIqEW2ueJo17jsSUOMF14+tI1Ld4LHfz5BCgDkWPzRi5r6WiLj70iWYXL6KwqvAI6a13FdHihPSRFGAtXMJFl2NkPlmKckn+KAleZNOS7/shsrMlqTxmOcLWtBUcUAZ2FVtvCk90WeEVHbB+57tJs=
From: Roger Pau Monne <roger.pau@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: <dwmw2@infradead.org>, Roger Pau Monne <roger.pau@citrix.com>, Jan Beulich
	<jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu
	<wl@xen.org>
Subject: [PATCH v2 5/5] x86/cpuid: expose EXT_DEST_ID feature if supported
Date: Wed, 16 Feb 2022 11:30:26 +0100
Message-ID: <20220216103026.11533-6-roger.pau@citrix.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220216103026.11533-1-roger.pau@citrix.com>
References: <20220216103026.11533-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO4P123CA0131.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:193::10) To SA0PR03MB5610.namprd03.prod.outlook.com
 (2603:10b6:806:b2::9)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 97ff082c-8541-4ed1-23c9-08d9f13776e9
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6256:EE_
X-Microsoft-Antispam-PRVS: <SJ0PR03MB625612014BDEBA942933909E8F359@SJ0PR03MB6256.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6108;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: ElJ9y0OO2Z/5hfcleDQHwhADR64BcfYyqqHIky+V05axd5LK5dV3O8Et6k6gtbywDL9UT8OPXJFKA7Hg55Oh4yZy/yu7OELNk1kiT+WlPHiA3pnDVf5XTdaw83uvW2JnM1lnAuUmr+XApCXxFnPXOJ46OeWrj87XDx7J9p2PTIPStZ3y179purMdn3utGnkWyJnXLq7UiYyZijKV4kxNuuWSCeltat7Up5H6CQRZpnXRR/LT52ijR+Lf6cDDEo7sq4F8OG72gb4q+NYBHxnoitOtIX9icamjuJRVYA76XSH/hdbCUH4QoNd9m3OQkrbulnsFM7s+xIYHM7Qp5rCYpr0he1VetcWS9psj11s6OQjgG3yOWKMrtnlLhnDVWUyvlkKSxJCJOEtEbuoBDYW05FjUWDPm2jci+wjNrSKboHAEBv6N+0pCwL9K+IdDO9gTKrI1AOHema0cLYcXixSFkybjocFp4qKc3ak8Nm1TIADtJSNSS/pP6nfvrJB3UXK/NWKi2fWEV3DS0MNIMZvvPleOBAvHWwRh1I2fUmXjlYhFFFK7RRv3h7PSPJr3+D1aMlF5yH3Ng3CIaPLsqqpnArCV2cnEQJwx3M3gvJincsQuwjqJl1zaq8lvFRlDzwsQuQDybhUJIbMhcBkrReRy/w==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA0PR03MB5610.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(8676002)(2616005)(66946007)(6506007)(6512007)(316002)(26005)(1076003)(66556008)(508600001)(86362001)(6486002)(6916009)(6666004)(54906003)(4744005)(82960400001)(66476007)(4326008)(38100700002)(36756003)(5660300002)(2906002)(8936002)(186003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VE53SXdxWmlWSkpTUWZ5dEkyTXlmMGx0M09sTXRIV0RPVWlobUhYV043Q3Ny?=
 =?utf-8?B?YkVxQ2Q5ZkF6c2E1ZklLV1F2VGFYa3FWZm9xNE5jdmt6U2t1elViZlFFbkVI?=
 =?utf-8?B?c1VSKzNLMEYzVmxpOW1CcGNmdldqc0w1SUFoWkUwOFZCZG1vR2ltRUEweFE1?=
 =?utf-8?B?TFFEaVpxZHBWNjBNUkhtWmlKeWJRT2I0Q1QvbElFbE1JUHZSTTlMUDgzU1c5?=
 =?utf-8?B?cUNtNnhneS85bEtYc2g2TWNUSHFUbkdLNXFPR3ZrUUl4YkRJV21HdVlqd2do?=
 =?utf-8?B?RVZ2WFV2WUZkSkN4dUNaYjcrOTc1bWI5aGUzSm14Ky9uZXFFMUpva3dzMWMw?=
 =?utf-8?B?SmtCSklxOFFKSGVmUzVHcEZzTmFMQTRmN1dLbmI2QTlGOXdqenRVeFdaMTJ2?=
 =?utf-8?B?QnJkNmRZTSsvNFFnanNmMVNnYmlFejRJZkp5TlBPMHlIOS9UMU9UOHVsMmQz?=
 =?utf-8?B?d2Z2OWt0T3NVRDRPVzRqUHZXTUlJV283K3czMEVaZXFuMUxNZkpjRHl2YStj?=
 =?utf-8?B?YjlJcHQ0Y295Mjh2MUxjbFhHQlhqQkdPNklWWW1SbXllWC9OQ1Qzb1g2dUd6?=
 =?utf-8?B?WXlabmxMN1BmWEk1R01udHNyQ25JcWc2SlQ3Ry95MUR0VDJwVzkyYVhFKzRX?=
 =?utf-8?B?UWlJR3VWZkpadzd6bThVNjBxdkNvOXBSY2pBOG5ERzNmVm1jTUd4ZVhYZVZt?=
 =?utf-8?B?azVZdXl6bGMrcC9xWmo0Y1d6WFJyWkFjZEluYUdGYlcxQWVLWXBIRjFKOS9u?=
 =?utf-8?B?d1NjVzVBVDNuWmQyVDY5Z3kxT3JzbzAwcHZlUy9yTUdEZEFzTG5zNXViODFj?=
 =?utf-8?B?ejROdy9SQTZJZU5aU25sdXRnWnFJeWFHVjdxcDA4R0s1Z0tEbVRWcFhlUVJC?=
 =?utf-8?B?alU3enN6KzRjaG1CYm8zZm12MCt6V3AxazhxZkNzUmpSRTRmak51cG1FbzVK?=
 =?utf-8?B?NFphRTJsMUZEeWxia1RoSXlwbkNLSllGTXFLeFRCVTB3dm53ZzRjZDRsOHg2?=
 =?utf-8?B?NHd5dG1RYkF4b2o1R24xTkEzY2pXMTEwSGc3MUphRTFnWmRPZ3FKSXo3MzFO?=
 =?utf-8?B?OFpJWHVDeGFNN0VJTzgvZ050V1F1R0pEWHR1UFR2RnZDdGxaUlZJYkNKMVBn?=
 =?utf-8?B?TVNGL2pPQ21HYXVBNXc3YXRaT2lHMTJ3bld0Q3RRZjhSNW0xWFZKQkNTdjUw?=
 =?utf-8?B?cFpuck9XUmZqWHVhOWxpZzJTbEtuVHNmRFdpV3dCZWZmejMyYzdFTnhFQ2dD?=
 =?utf-8?B?WFdIV3hZdnRsNnlWS1dNVzQvTDR4aTNRQXYyVGV3elhFMFBxZU1KNFh2VjN4?=
 =?utf-8?B?TUt6ZnJhQk1VVDc2aGVxaWgzY2x0R2JpeUE1TDVYR0lBaUFaUDdmRjdqVXlV?=
 =?utf-8?B?NnViWjRGSTRWTUhVcFgxd0pibTN6bWhxWUtTNWtNaGFORWoxKzIwbDRyUkZS?=
 =?utf-8?B?UUtaN0k5RDhRcU5ITFoyZWxTemZBUlJNN1plM1VUTW1WQkYwWDlYTldSVVJ4?=
 =?utf-8?B?OEFCb1hTN21JaXRVd1FpMWNINmJ1ZTB3RkQyMit3Q0s5WlFIY3RBRzNRMG5Y?=
 =?utf-8?B?V3ZEVkZEUWI5YnNsMU9VTTFLRXRuWEdrVmJaMThxOGUwUkdYRGVXTzRXSmg4?=
 =?utf-8?B?Q3BPRlh4Zmx6MTRSdjAycjRndWpya2lsZG43SXNaV0lYN3Ziemt2WkVSZndB?=
 =?utf-8?B?Qm9hZXhkUXRLWXZFQUNZUEtPdFphQWk0RENMUktsS2UyMFk2Znd2WFBmR1dE?=
 =?utf-8?B?ak1JSEFvOXJ4MnRqVHlqTGRtRGJ0aVlrV1MwQUo0cktZRFlFV3VBekg1V244?=
 =?utf-8?B?K0lWaVRpODYxaUxPSjIwWVNBNXFaTktISHdPb3JqZEdaVFhERFVnOE1FM2xS?=
 =?utf-8?B?UjZDcjJWSVNhME1KamZPZ3VaUjJiQXVBN2Iyem1GUWw4TjZ5ajZITzVLMFJa?=
 =?utf-8?B?V0Q5OER4aktmN1hIWUtjMmRweWwxTm9VeHVwVlV5VlNSaTRKMEJLc1lBMGgr?=
 =?utf-8?B?QVp4eE9Hc1hDVW1PSFRHV203RW9jdm1ZY0M0WkhobzZNOXZubi9KbVY2Z2Ri?=
 =?utf-8?B?bzE5c3lJbGtGRWNsNWtDR1lwNlRVVm5xNXpTMnQ4ZFkzNlFwMGNlOE4zQ2I5?=
 =?utf-8?B?YWJDTWI3VXo5VWlmbWhPZmxCWUtwdFozNEJOQ0RyVHBpWjJ3eVVuczV1VmhN?=
 =?utf-8?Q?oYjOoR6Ze9u64ptT0o5H8V4=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 97ff082c-8541-4ed1-23c9-08d9f13776e9
X-MS-Exchange-CrossTenant-AuthSource: SA0PR03MB5610.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2022 10:31:17.1058
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fep66e4T7ZJttA4ygpzVmzXhvXPvob/iv0lNGE7js+c8HVIH9bEl4a5lqWCvxrLii1uFuhBDqvS8UhBl5UUXrA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6256
X-OriginatorOrg: citrix.com

Expose the feature if available for the domain.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Note: con not be committed ahead of the rest of the series.
---
Changes since v1:
 - New in this version (split from previous patch).
---
 xen/arch/x86/traps.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/xen/arch/x86/traps.c b/xen/arch/x86/traps.c
index 485bd66971..5b24688b07 100644
--- a/xen/arch/x86/traps.c
+++ b/xen/arch/x86/traps.c
@@ -1150,6 +1150,9 @@ void cpuid_hypervisor_leaves(const struct vcpu *v, uint32_t leaf,
         res->a |= XEN_HVM_CPUID_DOMID_PRESENT;
         res->c = d->domain_id;
 
+        if ( d->arch.ext_dest_id )
+            res->a |= XEN_HVM_CPUID_EXT_DEST_ID;
+
         break;
 
     case 5: /* PV-specific parameters */
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Wed Feb 16 10:45:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 10:45:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273973.469289 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKHny-0002Za-Jz; Wed, 16 Feb 2022 10:45:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273973.469289; Wed, 16 Feb 2022 10:45:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKHny-0002ZT-Fc; Wed, 16 Feb 2022 10:45:02 +0000
Received: by outflank-mailman (input) for mailman id 273973;
 Wed, 16 Feb 2022 10:45:01 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=6VyC=S7=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nKHnx-0002Y4-4P
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 10:45:01 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7becb065-8f15-11ec-8eb8-a37418f5ba1a;
 Wed, 16 Feb 2022 11:44:59 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7becb065-8f15-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645008299;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=9aRORfQFiFGzJowWamjkxN0EDjr88tMV2BKQBi2Mc10=;
  b=NGzfgNRgca/02hX6clCYucLv2GJsBNUUwfXwNTfEIEX29qF3zV5ROztV
   DuNf7onl/K7mo/kfLRckEZHHE0XeRUj1wHirtjwDNNAXZa/WN1bJbdmFK
   X3MOQJMu+pFCIgfIMDaYQNMss6kM6XN07rAYNU+Lt6vWhnk+aPTMgeoDy
   I=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: dm3BNYNSPPgnuzAommj4ftxFfzftszDOl9cour0P5EDrefAlZ1KBI9G+JZ2qmdOj/zCYHG7ITv
 8ZLqKs2A8xhCw+SVAR++ELLojwpV3bdLsE/senH81hg+N4eqSzMsFb/YStmWZGIkinUOeFMO2F
 UZK58RGPrOKh2oqESKCirJ1iUVN5HS0/k8htoiAkKiFd/bSN8w+Zb7SW/GJixgo+dnEvy9/wvm
 Xo+2n+DQkVlpkL9cVqUOZ20zceZxfnnmJjIO5HWVp7W3CaEOtSQZ/+PZEzYY8icViWSqLoGvIl
 VpGt5On4CL3DJVrhDQY2L1IY
X-SBRS: 5.1
X-MesageID: 64328256
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:JzL2JqqNybtmKE0Vh/QmKBAtT4peBmKhYhIvgKrLsJaIsI4StFCzt
 garIBmOPqmLMWTyftogO97gpkkFuJTQn9I2HQBqqCg3H3gS95uZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlZT4vE2xbuKU5NTsY0idfic5Dndx4f5fs7Rh2NQw24HnW1rlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCnaOAZD04MInSodwQbCN/GT1MYv0XxaCSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFKoZtmtt0nfyCvE+TIqYa67L+cVZzHE7gcUm8fP2O
 ZZCM2o1MUqojxtnE3MRM7QFs9eRvVb+YRR1pH2NpZYs2j2GpOB2+Oe0a4eEEjCQfu1Kmm6Iq
 2SA+H72ajkkM9iYxSuA42ibrObFliPmW6ofDLS9sPVthTW7zGEJFAcfU1f9pPCjk1O/QPpWM
 UlS8S0rxYAQ3kG2Stj2XzWjvWWJ+BUbXrJ4CPYm4QuAzq7V5QexBWUeSDNFLts8u6ceRyEu1
 1KPt8PkA3poqrL9YWKQ8PKYoC2/PQARLHQefmkUQA0d+d7hrYovyBXVQb5e/LWd14OvX2uqm
 nbT8XZ41+57YdM3O7uTwmDquSOigobwdgMK3CLdQlD6vlJEe9vwD2C30mTz4fFFJYefa1COu
 nkYhsSThNwz4YGxeD+lG7tUQuzwjxqRGHiF2AM0QcF9n9i40yP7JehtDCdCyFCF2yruURvge
 wfttAxY//e/11P6PPYsM+pd5ynHpJUM9OgJtNiJNrKigbArLWdrGR2Cg2bKgggBd2B2zMkC1
 W+zK5rEMJrjIf0PIMCKb+kcy6Q34Ss12HneQ5v2pzz+j+bCNSPME+ZUYQLUBgzc0E9iiF+Im
 zq4H5HUoyizrcWkOnWHmWLtBQxiwYcH6WDe9JUMK7/rzvtOE2A9Ef7BqY7NiKQ+95m5Ytzgp
 ynnMmcBkQKXrSSedW2iNyAyAJuyDM0XhS9qYkQR0aOAhiFLjXCHt/xEKfPavNAPqYRe8BKDZ
 6NVK5/bU6sVE2mvFvZ0RcCVkbGOvS+D3GqmFyGkfCI+b9hnQQnI8cXjZQzh6G8FCS/fiCf0i
 +fIOtrzTcVRSgJ8ItzRbf7znVq9sWJEwLB5XlfSI8kVc0LpqdA4Jyv0h/4xAscNNRScmWfKi
 1fIWU8V9bvXvos40NjVnqTY/Y2nJPRzQxhBFG7B4LfoaSSDpji/wZVNWfqjdCzGUD+m472rY
 OhYlqmuMPAOkFtQnZB7FrJnkfA369f1/ucIxQV4BnTbKV+sD+o4cHWB2MBOsIxLx6NY5lTqC
 h7epIECNOzQas3/EVMXKA40Vci51KkZymvI8PA4AETm/ysrrrCJZlpfYkuXgytHIborbI58m
 bU9uNQb4hCUgwYxNorUlThd8mmBIyBSU6gjsZ1GUobnhhBylwNHaJ3YTCT3/IuOe5NHNUxze
 m2Yg6/LhrJ9wEveciVsSSiRjLQF3Zle6gpXyFIiJkiSnouXj/A66xRd7DArQ1kH1R5Aye9yZ
 jBmOkAdyX9iJNu0aByvh1yRJjw=
IronPort-HdrOrdr: A9a23:sO7N2ai/WVdvy7TAy+vqzymjhHBQX3x13DAbv31ZSRFFG/FwyP
 rBoB1L73DJYWgqNE3IwerwRJVpQRvnhPpICRF4B8biYOCUghrWEGgE1/qj/9SAIVyxygc578
 ZdmsdFeaXN5DRB/KTHCUyDYqsdKbq8geOVbIXlvgxQpGhRAskKhWoYe2Wm+w9NNXN77PICZc
 ehD6F81l2dkAEsH72G7w4+Lo7+TrPw5ffbSC9DIyRixBiFjDuu5rK/OQOfxA0iXzRGxqpn2X
 TZkiTij5/T8c2T+1v57Sv+/p5WkNzuxp9oH8qXkPUYLT3ql0KBeJlhYbufpzo4ydvfrWrC0e
 O85yvIDf4DrU85TVvF+CcFHDOQiArG3kWSjmNwR0GT+vARCghKUfapzrgpDCcxo3BQze2Ulp
 g7g15x/qAnfi8p1k7Glqj1fgAvmUyurXU4l+kPy3RZTIsFcbdU6ZcS5UVPDf47bW/HAa0cYa
 JT5fvnlbxrmJKhHgfkl3gqxMbpUmU4Hx+ATERHssuJ0yJOlHQ8y0cD3sQQknoJ6Zp4EvB/lq
 v5G7UtkKsLQt4dbKp7CutEScyrCnbVSRaJNG6JO1zoGKwOJnqIoZ/q57c+4v2sZfUzvdcPsY
 WEVEkduX85ekroB8HL1JpX8grVSGH4RjjpwtE23ekwhlQ9fsujDcSuciFaryKQmYRoPiSAYY
 fABHt/OY6WEVfT
X-IronPort-AV: E=Sophos;i="5.88,373,1635220800"; 
   d="scan'208";a="64328256"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=MGLMsWMhMcwJ/aAScULkQ8DUwFUHWbr2QbW4xwuodf8TRmflFo5syF+ol/wTeMAxPLwadqZWLAV2q08AQ3psDrXJY7n2onb+Mw5xSngdOR/iaJ5T6NGylcAjfuAC+CGjlda0tyeg4H5HuHXeJvWVq3uo0UtRTEUHvL+OruKv4iYq14wdTI6kTsaEYqOpe/OSaH9sS0dkBi1M3+yNHOPAd9Qd7hM7DcP8xQ1tuGNonbgg85ay7LV6De6bTr7BYXbDu59Dasbpn2JYp19R77W/qQG9YaqKgBEaFBAhi6otKZMogENi+FCoyafc52oiD54e7cuxlgYeeyCVvusb1xN7bQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=9aRORfQFiFGzJowWamjkxN0EDjr88tMV2BKQBi2Mc10=;
 b=nBtIF566W/1LvBN7igCeZds1yIonouGG/1Rrp4FYIqpWiOXy/icTWmQnCgW+4Ow653FS7VCgLYaqLgA+2lZquMi3wZ7bTifoW03KJuefWKiBcPWofl9R4rMuL3TvFetTrcoPdnk9vHsKOjjW5eHCP84qVdWrJ9prPPSybeQMqjPMk8E+JSh9PH5PyN5EBCgqywBEo2BzD8bZ1igq1Lr7yzEF4iKXKlEyU4qg2Wd8e5NTYYDiHBwptW5qm/Eic3lwZvYk+JmUkowMxmdEU69g4wOBBE+usB/ahlt1Uc/rXa9QYWQuK3nuImzWF8Cf4qmajCwU+yBa/g64bNVNh6gwuQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=9aRORfQFiFGzJowWamjkxN0EDjr88tMV2BKQBi2Mc10=;
 b=vWAwb9P+W2MuKG7FHCuDEGZCIk2n5hAVcU/q5JUa3vfv2YcMTwMUvFSgw8DjPz4bcGqswZbEYjgbrodH7X664OcH559OGJ4YIjrHCs5FUl8hRqly6euqizhzdFr8oDp0F8YWF0ADFzS7Sjakhwc4LvTcNNZvRTHHEqbx+OFW/1U=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Jan Beulich
	<JBeulich@suse.com>, Roger Pau Monne <roger.pau@citrix.com>, Wei Liu
	<wl@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, "Bertrand
 Marquis" <bertrand.marquis@arm.com>
Subject: Re: [PATCH v2 02/70] xen/sort: Switch to an extern inline
 implementation
Thread-Topic: [PATCH v2 02/70] xen/sort: Switch to an extern inline
 implementation
Thread-Index: AQHYIaGjy/wpq8SdQkKdLl3UHHKbD6yTBxwAgAKFHgCAAHT3AA==
Date: Wed, 16 Feb 2022 10:44:52 +0000
Message-ID: <faa6c523-6e88-8987-c0c9-3652c002fda3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
 <20220214125127.17985-3-andrew.cooper3@citrix.com>
 <70824a0c-cc48-b064-695c-35c2d06c0ad1@xen.org>
 <alpine.DEB.2.22.394.2202151800230.43738@ubuntu-linux-20-04-desktop>
In-Reply-To: <alpine.DEB.2.22.394.2202151800230.43738@ubuntu-linux-20-04-desktop>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 18bae67d-0140-4071-7b27-08d9f1395d26
x-ms-traffictypediagnostic: DM4PR03MB6094:EE_
x-microsoft-antispam-prvs: <DM4PR03MB6094205E1A0D6084E0084599BA359@DM4PR03MB6094.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: AZQ5k1vi7H9wa5RRmgWrooHvXiwNLnGV6tR1aRY0IxMd0SW/UspbzqJPrv3Hz6pulNEPPwD9ue+aW3lmRZR2mi7elbF+7YrjYL+/5MxWJkf7WSaY0DQbZpYxt9OEphmjEDmGYLBfzkAWNKwd9W+Ct/75WgKJkiF+vlqspWSjJEcKWuqlv+M6YyVjCmnjUPJagJ2uXqDx+gOz3bc4ESPWh5C791BBBKzpKzOixLXswYFoIxIxvMQKJeM5D5+X7pZiJrksJF/gbQcmYXF4u3/4HnWjdoK/rhlffRzCo2kv3XkzkedYjCESGrVCzMa+6ZhuLQHkdy7yYAQv7yN5T+YilYEcN6o4Pyk0RTRF5/6exDdztb4z5JddvLmqNc98FYrjCuDv//vpReYGg/CiGytU8o4xliEn4OXts8CDU2K2ibdz2kaJ9a5av3Jus1EKT7IGdT/DvvXnp3FyaNhC4piTExt9Q/KZlhiY/38mLPy1zj8X/V5OUPqNnQAQjuUQZA06lJ/0kUtOKrqtorks2LaaPVOzpGwWLevXMQw0rvbUQcJbqbTgdH+ECHDBobUtk3+/Keup1r0tx879XtT4EF7C3HG/9xPfYA0kObPP1MCCUZCQIyWVV9aNys4DqVfaY9lnRw+wVNgYUXsibfie9LF/co4CMd76G0JNMGeqNC+raPDFkmZ37dJgT2zQ1EpqLemk3RGP+QhxKsI0fB/v/wNzYC0KxpOKVKjiiEGMFgUDBV5k+LBHSeJVyZv3Gd7Cv3G5HbFqNRL7VVCeqcvRXvI3gA==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6506007)(8676002)(2616005)(4326008)(66946007)(64756008)(91956017)(66446008)(76116006)(6512007)(66556008)(66476007)(53546011)(54906003)(110136005)(6486002)(508600001)(71200400001)(86362001)(31696002)(316002)(82960400001)(122000001)(83380400001)(38070700005)(26005)(186003)(38100700002)(8936002)(36756003)(2906002)(5660300002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?VE42aThYdnpvc2ZsWlVXVUcxdE5aTHhJR3phazhIUDkrS1o1aEhiMVZ0bEls?=
 =?utf-8?B?VDU3c3ZQb256Q1JLUnJxZUgxVnZZQ3lxckJDdHZqN2FlSVZjNDlLazNBZXI1?=
 =?utf-8?B?TVJOK2lKZGVCdXg0eHl1djRycEx0Sk4wdGZ1Y2IyNTNyVWdJaXI3cnBkWW5D?=
 =?utf-8?B?WjNUQi9XQVZkTGFmTklSMnR1K1d6WjNVaVZhdFBKZnN1L1hqVFFHa1lRcnRL?=
 =?utf-8?B?Nk00VGZtekp0bkFNYzVTL3UzV2FrN1hwTUhPdVdEWUQzdVFyYnJjVEJxb1Rs?=
 =?utf-8?B?dWVCTkZRR2ZHaUlDMWM3S3ZiMkFRVUQ1VXNSN1VkSUNmd0d1NTE1cUkvbXVI?=
 =?utf-8?B?L1BtdmdGa0pQeS9jdmVEclUvSDVVUFd1Z3E3UzgwbHdURjFrRWFZUnJNVmZs?=
 =?utf-8?B?KzFHUHk0b2VBaU90a0FoeUxuUDIwRmQ5d2s2ZmJEUkZvdTVzSnRuUEJuTW5q?=
 =?utf-8?B?N01TQUhPc1M3dkpIN1Nkb1dINnk2UlhDOVZsczdyWmUyb1hMTnVFZ3llMzhW?=
 =?utf-8?B?RHQ3TDV2RXg1RGZlYUpUWDRqckg0Y1NKZmwyTU5XWDNIb0IvbnlqRWgreGQ3?=
 =?utf-8?B?S05SVEs4SUVHcDVYZ0pubzlXbkU1MFpoRDVtV2xSOW1OZlZBdnNoVWx4UExO?=
 =?utf-8?B?MnJiMEVSTXJ5aWY3cVl6UDlKUVBxd1IyN1Z5NE5oWVRobXVyM01pbTIxcG8x?=
 =?utf-8?B?MmxmTGswbDZPUUFHNHpWNGQ2TGFmb0N6OEdYRmtjV3dPVk9IMjB5d2toVC9p?=
 =?utf-8?B?dVBjellNejhCUjcwN2dicWN4VURTVWI2N292TnpkVExCQnc0Ukl2VzZPUFFK?=
 =?utf-8?B?QU9ac0hOeFk0QU5jZWdqSTRITUxsb29XZlpnQ0p2S1NEdWdGL2x0SC9VNCtE?=
 =?utf-8?B?WSthVUlNYkcwOFlVdjY5cFhibzlMOHdYR0ozT09mRlNnb09vaWlGU243UFpm?=
 =?utf-8?B?ejdzU0pSOENWd3AzRVRpaDQyaStNbWhPdFJ3K3hmV21kV041V1FZOFFFd1Bo?=
 =?utf-8?B?RjVlRVhaa3lYNTdiOERSd25pdU54MjBZVXU2TDk2WlAzY2lsMlU1UEhpTEQ2?=
 =?utf-8?B?SExPbkFpK1BwMEIrc2gxYUw2UFFzUUpKd0RoN0M0dXE5TExKUVd6cE4zMHJi?=
 =?utf-8?B?cGtIemlmV0QvV0ZNSWtib3FEOGtVTm13WXZmcVVxR0FZNkVsczY5NFJ1YmlD?=
 =?utf-8?B?TE94bzdiWTlDcGlHamdjV0d4a0dpb1FOazZJVm5ueks3RDVmQUttVFVTTzht?=
 =?utf-8?B?OFloTHdZTkF3N3ZySVI1UGcwMWJjbGpDTXd1VVNtL3FlWE5IaE9GQitoR3lj?=
 =?utf-8?B?a2FQSktRVVlzNGVKNCtxZ3NHaWQyRmNnZWNabmIwY2UreGNyNHZ3aHV0SFdn?=
 =?utf-8?B?dGZFcEp3YUFRQlhiYTI0NmhlWlFGbmpFb3E0NzgyM0pxWVJKUmtZanl0MWVF?=
 =?utf-8?B?MitsVUd1R2RkVlZ3d3lYUjBQcERUMDFMM0I1Q2VUVnhTYXIzVFdjcFF0eEtC?=
 =?utf-8?B?bnozdUlCc2xBcFBTbFRFdTN5S3ZGWmdrY3ZSay9HNE8yYW5ybnQyb1BuT2xT?=
 =?utf-8?B?UEFnanQ2dElCRUJUdXE1Q09KRmNRK0lBUFVIb2tkdTNiWlZiYTlZeitJU1RR?=
 =?utf-8?B?cENmVWkvTXpONGhIeGs3YkZEeW1ETytKdm9qTW13M1VpMi94MFF0ejZUTlV0?=
 =?utf-8?B?RUg3a0U3VWUrSUNRZFozWHdvNFRTR3Z5YTEvUm04N21Fb0hoUHFnN0JIcFNw?=
 =?utf-8?B?aFlxUEVkRlVIek1sWXBzV1d0S2I3VHoySW95SGc1bmZWNk5NRTcrMUNTejV3?=
 =?utf-8?B?NFE2bDl5ZlI5WnFqSzNZYjE4MGw4VnRWb1JyT2FaYVl5aGQ5Yi9xZ21yZzJQ?=
 =?utf-8?B?T1R6RWU5emVEQ3Zzdy9CWlpzdzVleTNSOEQxdC95bVNMcnA5MjBNQ0w4LzUr?=
 =?utf-8?B?M2tqUHV0dlNSNDlTaEs0aktudUl3K1FYQTVOZ0dHT3lLOFFKdEk3aFRCMVZE?=
 =?utf-8?B?RCsyaG5tQ0FGSVcwemJkdVN0NHRZMEZXRWhhVlVJbUtKY3RMRGVlcVJGa0tC?=
 =?utf-8?B?ZkV4dXZaR29DQWZkVmpVQ1hzT2t3Mmp4c3JRTXBrWlF5UE5LaVo4Y1FQaUd1?=
 =?utf-8?B?K2RaU1UxeTV5dE9pUVU2ZmFUelpxQkdvRXYyK3Z0akxFNWs1Q05JMms2aGgv?=
 =?utf-8?B?d1E3WWdUeXVUeXBvR0doSk9wclZBZGwxMmNIQW8wbDliYVk3WGhTV29rdzM0?=
 =?utf-8?B?RGVKSTVaYkJZNVZqVWdBRHNqMDV3PT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <F3A5973CE2880B40BF30063A18F2D4BC@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 18bae67d-0140-4071-7b27-08d9f1395d26
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Feb 2022 10:44:52.6775
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: H3zFHUaAi3uSZ7XfJmDlli4/DIVmWAdrv2yZAKuUBBQOLjG72+wIcBGE6V9IMVmGA281P8k0DryNtnM1Fq04gfpv0c5ZLsAjHxTa9cwm8r4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB6094
X-OriginatorOrg: citrix.com

T24gMTYvMDIvMjAyMiAwMzo0NiwgU3RlZmFubyBTdGFiZWxsaW5pIHdyb3RlOg0KPiBPbiBNb24s
IDE0IEZlYiAyMDIyLCBKdWxpZW4gR3JhbGwgd3JvdGU6DQo+PiBPbiAxNC8wMi8yMDIyIDEyOjUw
LCBBbmRyZXcgQ29vcGVyIHdyb3RlOg0KPj4+IFRoZXJlIGFyZSBleGFjdGx5IDMgY2FsbGVycyBv
ZiBzb3J0KCkgaW4gdGhlIGh5cGVydmlzb3IuICBDYWxsYmFja3MgaW4gYQ0KPj4+IHRpZ2h0DQo+
Pj4gbG9vcCBsaWtlIHRoaXMgYXJlIHByb2JsZW1hdGljIGZvciBwZXJmb3JtYW5jZSwgZXNwZWNp
YWxseSB3aXRoIFNwZWN0cmUgdjINCj4+PiBwcm90ZWN0aW9ucywgd2hpY2ggaXMgd2h5IGV4dGVy
biBpbmxpbmUgaXMgdXNlZCBjb21tb25seSBieSBsaWJyYXJpZXMuDQo+Pj4NCj4+PiBCb3RoIEFS
TSBjYWxsZXJzIHBhc3MgaW4gTlVMTCBmb3IgdGhlIHN3YXAgZnVuY3Rpb24sIGFuZCB3aGlsZSB0
aGlzIG1pZ2h0DQo+Pj4gc2VlbQ0KPj4+IGxpa2UgYW4gYXR0cmFjdGl2ZSBvcHRpb24gYXQgZmly
c3QsIGl0IGNhdXNlcyBnZW5lcmljX3N3YXAoKSB0byBiZSB1c2VkLA0KPj4+IHdoaWNoDQo+Pj4g
Zm9yY2VkIGEgYnl0ZS13aXNlIGNvcHkuICBQcm92aWRlIHJlYWwgc3dhcCBmdW5jdGlvbnMgc28g
dGhlIGNvbXBpbGVyIGNhbg0KPj4+IG9wdGltaXNlIHByb3Blcmx5LCB3aGljaCBpcyB2ZXJ5IGlt
cG9ydGFudCBmb3IgQVJNIGRvd25zdHJlYW1zIHdoZXJlDQo+Pj4gbWlsbGlzZWNvbmRzIHVudGls
IHRoZSBzeXN0ZW0gaXMgdXAgbWF0dGVycy4NCj4+IERpZCB5b3UgYWN0dWFsbHkgYmVuY2htYXJr
IGl0PyBCb3RoIHRob3NlIGxpc3RzIHdpbGwgaGF2ZSA8IDEyOCBlbGVtZW50cyBpbg0KPj4gdGhl
bS4gU28gSSB3b3VsZCBiZSBleHRyZW1lbHkgc3VycHJpc2VkIGlmIHlvdSBzYXZlIG1vcmUgdGhh
biBhIGZldyBodW5kcmVkcw0KPj4gbWljcm9zZWNvbmRzIHdpdGggdGhpcyBhcHByb2FjaC4NCj4+
DQo+PiBTbywgbXkgb3BpbmlvbiBvbiB0aGlzIGFwcHJvYWNoIGhhc24ndCBjaGFuZ2VkLiBPbiB2
MSwgd2UgZGlzY3Vzc2VkIGFuDQo+PiBhcHByb2FjaCB0aGF0IHdvdWxkIHN1aXQgYm90aCBTdGVm
YW5vIGFuZCBJLiBKYW4gc2VlbWVkIHRvIGNvbmZpcm0gdGhhdCB3b3VsZA0KPj4gYWxzbyBzdWl0
IHg4Ni4NCj4gVGhpcyBwYXRjaCBzZXJpZXMgaGFzIGJlY29tZSA3MCBwYXRjaGVzIGFuZCBmb3Ig
dGhlIHNha2Ugb2YgaGVscGluZw0KPiBBbmRyZXcgbW92ZSBmb3J3YXJkIGluIHRoZSBxdWlja2Vz
dCBhbmQgbW9zdCBwYWlubGVzcyB3YXkgcG9zc2libGUsIEkNCj4gYXBwZW5kIHRoZSBmb2xsb3dp
bmcgdXNpbmcgZ2VuZXJpY19zd2FwIGFzIHN0YXRpYyBpbmxpbmUuDQo+DQo+IEp1bGllbiwgQmVy
dHJhbmQsIGlzIHRoYXQgYWNjZXB0YWJsZSB0byB5b3U/DQo+DQo+IEFuZHJldywgSSBrbm93IHRo
aXMgaXMgbm90IHlvdXIgZmF2b3JpdGUgYXBwcm9hY2ggYnV0IHlvdSBoYXZlIHF1aXRlIGENCj4g
bG90IG9mIGNoYW5nZXMgdG8gaGFuZGxlIC0tIHByb2JhYmx5IG5vdCB3b3J0aCBmb2N1c3Npbmcg
b24gb25lIGRldGFpbA0KPiB3aGljaCBpcyBwcmV0dHkgbWlub3I/DQoNCkl0J3Mgbm90IHByZXR0
eSBtaW5vci7CoCBNeSB2ZXJzaW9uIHJlYWxseSBpcyB0aGUgYmVzdCB0aGluZyBmb3IgQVJNLg0K
DQpUaGUgcGVyZiBpbXByb3ZlbWVudCBhbG9uZSwgbWFyZ2luYWwgYXMgaXQgbWF5IGJlIGluIHBy
YWN0aWNlLCBpcw0KanVzdGlmaWNhdGlvbiBhbG9uZSBmb3IgdGhlIHBhdGNoLCBhbmQgQmVydHJh
bmQncyBSLWJ5IGlzIHRlc3RhbWVudCB0byB0aGlzLg0KDQpCdXQgdGhlIHJlYXNvbnMgd2h5IGdl
dHRpbmcgcmlkIHRoZSBzd2FwIGZ1bmN0aW9ucyBpcyBpbXBvcnRhbnQgZm9yDQpDRVQtSUJUIG9u
IHg4NiBhcmUgZXhhY3RseSB0aGUgc2FtZSBhcyB3aHkgZ2V0dGluZyByaWQgb2YgdGhlbSBvbiBB
Uk0NCndpbGwgYmUgaW1wb3J0YW50IGZvciBCVEkgc3VwcG9ydC7CoCBBIHRhZ2dlZCBmdW5jdGlv
biBkb2luZyBhbiBhcmJpdHJhcnkNCmJ5dGV3aXNlIHN3YXAgZnJvbSB0d28gcGFyYW1ldGVycyBj
b250cm9sbGVkIGJ5IHRoZSB0aGlyZCBpcyBmYXIgbW9yZQ0KdmFsdWFibGUgdG8gYW4gYXR0YWNr
ZXJzIGdhZGdldCBsaWJyYXJ5IHRoYW4gYSB0eXBpY2FsIGZ1bmN0aW9uLg0KDQppLmUuIHRoaXMg
cHJvcG9zZWQgaW50ZXJtZWRpYXJ5LCBpZiBpdCBjb21waWxlcywgaXMganVzdCBidXN5d29yayB3
aGljaA0Kc29tZW9uZSBlbHNlIGlzIGdvaW5nIHRvIGhhdmUgdG8gcmV2ZXJ0IGluIHRoZSBmdXR1
cmUsIGFsb25nIHdpdGggaGF2aW5nDQp0aGlzIGFyZ3VtZW50IGFnYWluLg0KDQp+QW5kcmV3DQo=


From xen-devel-bounces@lists.xenproject.org Wed Feb 16 10:54:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 10:54:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273989.469304 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKHwi-0004BV-K8; Wed, 16 Feb 2022 10:54:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273989.469304; Wed, 16 Feb 2022 10:54:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKHwi-0004BO-Ge; Wed, 16 Feb 2022 10:54:04 +0000
Received: by outflank-mailman (input) for mailman id 273989;
 Wed, 16 Feb 2022 10:54:03 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mysP=S7=gmail.com=xadimgnik@srs-se1.protection.inumbo.net>)
 id 1nKHwh-0004BE-FV
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 10:54:03 +0000
Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com
 [2a00:1450:4864:20::333])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id bf93bbed-8f16-11ec-b215-9bbe72dcb22c;
 Wed, 16 Feb 2022 11:54:01 +0100 (CET)
Received: by mail-wm1-x333.google.com with SMTP id
 q198-20020a1ca7cf000000b0037bb52545c6so3429841wme.1
 for <xen-devel@lists.xenproject.org>; Wed, 16 Feb 2022 02:54:01 -0800 (PST)
Received: from [10.7.237.11] (54-240-197-227.amazon.com. [54.240.197.227])
 by smtp.gmail.com with ESMTPSA id o4sm16349706wms.9.2022.02.16.02.53.59
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Wed, 16 Feb 2022 02:54:00 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bf93bbed-8f16-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=message-id:date:mime-version:user-agent:reply-to:subject
         :content-language:to:cc:references:from:in-reply-to
         :content-transfer-encoding;
        bh=tPmLSTqOcapZvO9uuQqXhfO95EoSa8ZZQjKGr7P8WvQ=;
        b=MrWlhRHEZscDjDZwu4uFIkEoxOuGnpMV8XkioDQLbSlDe9iacozN8NSy9o1K2zgFM/
         1HwVBUchLx9SYmhvjPIi8zQ1MX5xNgxmRfmIMF73lAU0maSudm/NV2zwUsegl+g9wZ4S
         nY3Gn1WHA+N2f7QSZMXrla0zcnoKrncT4EdH8C6UmMrblkZBYcE0OORMwM/E28wYoKGb
         DzQs5Og4JhQPbvHS3hEVWAqSGjhD1M/Gv3QukE+mCdZnhq+IpAiayfBrRuknXNqMC8CF
         AXuJlNwGLRLuSPodiZbipNbt+2Nk1cqDmVqup5iNPj+si1ilfe55MoXKIDMkfihm4ukn
         KfhQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:message-id:date:mime-version:user-agent:reply-to
         :subject:content-language:to:cc:references:from:in-reply-to
         :content-transfer-encoding;
        bh=tPmLSTqOcapZvO9uuQqXhfO95EoSa8ZZQjKGr7P8WvQ=;
        b=5x2tgEDzK90u/bcZiwKAPDmTPgPdSndcdUxzGAV6ssRP7PvYA8EGhCmO6UI+sc+HIr
         OFvdhIdqt3XoO3jeOKZgeK1dWHX3dvPpfDcyS6R451lisvsV56Ybo1khd/krLbKJwFTK
         IAwjtUrcg2qN4i7MZGbNaF/rg5eunHABZ7zF9WGYaSHltIn+NbmN8dmR4IGGipGmOsSs
         m9jF394epas1EOBCYb3NsUVSvlmGquJsXfc0h5Nx+xlKGkEqcUWN4fS13wuqJ10Gl/5n
         iLRKyfFoyKq4kVvHedynRHrr5GIzmwvrVsyZxfpmdDmdWTjNO8V8Pow50wZVWTgjxEOV
         TsSg==
X-Gm-Message-State: AOAM5302qnlM2BsdofKZp2sihHkHi4DM3itbG07+0ykmbaFIttz+qwiz
	w8i4MHWaCu0hbnE8YGKh3zk=
X-Google-Smtp-Source: ABdhPJwMB0xkn6tPdGfD+4I6HmDmVdRWu2XRzMnIe3yO0Nex+nM0rpiMtiVxBDzMHGlCTVOuueXeAg==
X-Received: by 2002:a1c:f30b:0:b0:37b:b5de:c804 with SMTP id q11-20020a1cf30b000000b0037bb5dec804mr1039815wmq.166.1645008840988;
        Wed, 16 Feb 2022 02:54:00 -0800 (PST)
Message-ID: <73c3db96-fbca-9d03-d645-4d44ab6a640f@gmail.com>
Date: Wed, 16 Feb 2022 10:53:58 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Reply-To: paul@xen.org
Subject: Re: [PATCH v2 RFC 4/5] x86/ioreq: report extended destination ID
 support by emulators
Content-Language: en-US
To: Roger Pau Monne <roger.pau@citrix.com>, xen-devel@lists.xenproject.org
Cc: dwmw2@infradead.org, Stefano Stabellini <sstabellini@kernel.org>,
 Julien Grall <julien@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>, Paul Durrant <paul@xen.org>
References: <20220216103026.11533-1-roger.pau@citrix.com>
 <20220216103026.11533-5-roger.pau@citrix.com>
From: "Durrant, Paul" <xadimgnik@gmail.com>
In-Reply-To: <20220216103026.11533-5-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 16/02/2022 10:30, Roger Pau Monne wrote:
> Introduce a new arch specific field to report whether an emulator
> supports the Extended Destination ID field, so that the hypervisor can
> refrain from exposing the feature if one of the emulators doesn't
> support it.
> 
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> ---
> Changes since v1:
>   - New in this version.
> ---
> RFC: I find this kind of clumsy. In fact fully emulated devices
> should already support Extended Destination ID without any
> modifications, because XEN_DMOP_inject_msi gets passed the address and
> data fields, so the hypervisor extracts the extended destination ID
> from there.
> 
> PCI passthrough devices however use xc_domain_update_msi_irq and that
> has leaked the gflags parameter in the API, even worse the position
> of the flags are hardcoded in QEMU.
> 
> Should the clearing of ext_dest_id be limited to the domain using an
> IOMMU?
> 
> RFC: Only enable ext_dest_id if max_cpu > 128? So the device model is
> aware the domain must use ext_dest_id? (implies device model knows
> APIC ID = CPU ID * 2)

There is still only a single sync ioreq server page, so 128 vCPUs is the 
max possible.

   Paul



From xen-devel-bounces@lists.xenproject.org Wed Feb 16 11:05:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 11:05:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.273996.469315 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKI7c-0005iv-MF; Wed, 16 Feb 2022 11:05:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 273996.469315; Wed, 16 Feb 2022 11:05:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKI7c-0005io-Hl; Wed, 16 Feb 2022 11:05:20 +0000
Received: by outflank-mailman (input) for mailman id 273996;
 Wed, 16 Feb 2022 11:05:18 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nKI7a-0005ie-TD; Wed, 16 Feb 2022 11:05:18 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nKI7a-00061B-K3; Wed, 16 Feb 2022 11:05:18 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nKI7a-0007R1-5E; Wed, 16 Feb 2022 11:05:18 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nKI7a-0004dR-4V; Wed, 16 Feb 2022 11:05:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=dsI0JBbLGA+iVY0ig7y7sGTTd1U2xzhreJSMgWjJZto=; b=yYOJMkNsYcBc9C3JqXDQJB6oAh
	0jswNLo3JJ0390BvVLGt8A4XsDLsthD/L2yYF3YJVTFYvzXBNtvRqS0fOxGYQM/X+XUT7k2YK4ts4
	dNeB9GKgTE93h5RQFwBqE89LwyyT6bI6XpYrldl34VH47KpJtsmDCypiX4tFpNv0eKUU=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168124-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 168124: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-arm64-arm64-xl-thunderx:xen-boot:fail:heisenbug
    xen-unstable:test-amd64-i386-qemuu-rhel6hvm-amd:guest-start/redhat.repeat:fail:heisenbug
    xen-unstable:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=94334d854bd358bd1d9c61d5e3306e4d903b120b
X-Osstest-Versions-That:
    xen=94334d854bd358bd1d9c61d5e3306e4d903b120b
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 16 Feb 2022 11:05:18 +0000

flight 168124 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168124/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-xl-thunderx  8 xen-boot         fail in 168118 pass in 168124
 test-amd64-i386-qemuu-rhel6hvm-amd 14 guest-start/redhat.repeat fail in 168118 pass in 168124
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 168118 pass in 168124
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 18 guest-start/debianhvm.repeat fail in 168118 pass in 168124
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10     fail pass in 168118
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 168118

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168118
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168118
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168118
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168118
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168118
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168118
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168118
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168118
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168118
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168118
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168118
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168118
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  94334d854bd358bd1d9c61d5e3306e4d903b120b
baseline version:
 xen                  94334d854bd358bd1d9c61d5e3306e4d903b120b

Last test of basis   168124  2022-02-16 01:53:08 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Wed Feb 16 11:27:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 11:27:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274007.469325 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKISW-00086k-Hx; Wed, 16 Feb 2022 11:26:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274007.469325; Wed, 16 Feb 2022 11:26:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKISW-00086d-Ej; Wed, 16 Feb 2022 11:26:56 +0000
Received: by outflank-mailman (input) for mailman id 274007;
 Wed, 16 Feb 2022 11:26:55 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=oYE0=S7=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nKISV-00086X-1S
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 11:26:55 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 561d03dc-8f1b-11ec-b215-9bbe72dcb22c;
 Wed, 16 Feb 2022 12:26:52 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 561d03dc-8f1b-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645010813;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=MwoTkKHCCdRbCC8vzc6d2mcfaVwb8s020CqGAIs+tkM=;
  b=hwEVkls/XflYAixVcSomxAWTmnEIHO+pPOEKvl7vu4aBT7BjAkFQ63yg
   zurNeUWGV0aRkEk5wiG9VbLjHuRWwp4VZu8mqEtCUp2s0B/AWxdQmSXJL
   ZiRzlGhi4KQ5H6TqRfJmdLGHkmgYPD/LqvZzkEBdQu8s1XmI4HD+SzHRK
   g=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: MzalmwrdxonjexbZ6CXgALhsRdjii26eAsK6C44GTRioSNQiyqZBDnPTnh5H7l/4/e4Qfo9p5D
 dJ4kzQlr1n4icp7blgZ3gypM/dEDXtM442T+DpERMXgtAyp4iAkEhl3Ds3N4THRjT3Kql8PX6B
 AnYUL6AXtf18nET2OVCNGPpU1BDc2EZkgwv8prFDoT5PYZijIUvDJyPSAkmNNLRjWzN+a15FlX
 sFOoaDwQ0a6soRPblGGWAJlLP6o3MQ8+ZroDumv48wRqX0/3gExasTxvccyspXnWUEsCM7xWmP
 MuSxwvlTp8huk4scjW+k9L8r
X-SBRS: 5.1
X-MesageID: 64330511
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:pcbNbazWmVGdxO6cKSd6t+frwSrEfRIJ4+MujC+fZmUNrF6WrkUHn
 zQfDW2BPPjYamegKox2bIS+p08EvpHczoJgTQJvqiAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAhLeNYYH1500g7wbdn2tcAbeWRWGthh
 /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL
 wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt8hj5
 9VUlKWvcgQWJ6iPqM05YR14HwgraMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr
 6ZBbmlQMFbT3Ipaw5riIgVort4kI8TxepsWp1lrzC3DDOZgSpfGK0nPzYEEh2xo25kXdRrYT
 8EXdWs2TRHCWRpCfQslCooQzc2SlnaqJlW0r3rK/PFqsgA/1jdZwLXrddbYZNGObcFUhVqD4
 HLL+XzjBRMXP8DZziCKmlqzgsffkCW9X5gdfJW6/PN3hFyYxkQIFQYbE1C8pJGEZlWWAowFb
 RZOo2x38PZ0pBfDosTBswOQuGyrvgc9YsVrENIj7UK9447m5yaVLz1RJtJeU+AOuMgzTD0s8
 1aGmdL1GDBi2IGopWKhGqS89m3rZ3VMRYMWTWpdFFZevYG/yG0mpk+XFr5e/LiJYsoZ8N0a6
 xSDt2AAiroalqbnPI3rrAmc01pASnUkJzPZBzk7vEr4tmuVh6b/PuREDGQ3C94ace51qXHb4
 RA5dzC2trxmMH10vHXlrB8xNL+o/e2ZFzbXnERiGZIsnxz0pSL/LN0JumAvdR4zWirhRdMPS
 BWO0e+2zMUNVEZGkIctO97hYyjU5fSI+SvZugD8MYMVP8kZmP6v9yByf0+At10BY2B3+ZzTz
 ayzKJ72ZV5DUPwP5GPvG481jO96rghjlDi7bc2qkHyaPU+2OSf9pUEtawDVMIjULcqs/W3oz
 jqoH5Ham08EAbKkO3S/HEx6BQliEEXXzKve8qR/XuWCPhBnCCcmDfrQyqkmYItrg+JekeKgw
 513chYwJIPXiSKVJAOURGpkbb+zD59zoWhiZX4nPEqy2mhlaoGqtf9Ne5wydLgh1epi0f8rE
 KVVJ5TeWqxCGmbd5jAQTZjht4g+Jh6lsh2DYni+az8lcp8+GwGQoo34fhHi/TUlBzassZdsu
 KWp0w7WGMJRRwlrAMvMRuioyle94SoUlO5oBhOaKdhPYkT8toNtLnWp3PMwJsgNLzTFxyebi
 FnKUUtJ+7GVrtZsotfThK2Co4O4KMdEHxJXTzvB8LK7FSjG5W7/k4VOZ/mFIGLGX2Tu9aT8O
 egMl6PgMOcKlUphupZnF+o51ro34tbiquMIzglgG3mXPV2nBqk5fyuD1MhL8KZM2qVYqU29X
 UfWootWPrCAOcXEFl8NJVV6MrTfhK9MwjSCv+4oJEja5TNs+OvVWEpfCBCAlShBIeYnK4gi2
 +og5JYb5gHXZsDG6TpaYvS4L1ixE0E=
IronPort-HdrOrdr: A9a23:E/zKa6tg39OZSLyYgS9MLfYr7skDctV00zEX/kB9WHVpm6uj5q
 eTdZUgpHvJYVMqM03I9urtBEDtexzhHP1OgbX5X43NYOCOggLBRuxfBODZogHIKmnT8fNcyL
 clU4UWMqyUMbGit7eY3OBvKadD/OW6
X-IronPort-AV: E=Sophos;i="5.88,373,1635220800"; 
   d="scan'208";a="64330511"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ACY9VyE2kkPwYe4gnc2If7g4LE2+CPOrmksYDTutFte25hkbR7mbfclVP3YwQs44qYAWDcCzPwgws86DPxsru6SQahU2h3eH0tbRm4dRYJg0mdQhkOqTHVf8XjiMY0uPTR6niROF7dc6ONCNVZ44UiMHTVfg++zUkiPt8XcRJqudZ8HOASE1Dda9V2N5T41JvCLqu5tT2Ymja406wTM6EZun4S7N6dMicyNqz85HNEQf+HLT30CZPdIyEbW5sOPLlK7E7VlfS+WX3vD8pnheEjx5X+4T1tgIx/WcwCTxuOmHDxk97+EY7SAdwKGrvvaBmnukyOwqro1oSDH7B5xQ4g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ABOy2eIDdsp6vK3CxREgVkNbS5AWcW3H7w/PlWtH0JY=;
 b=jCv0H6XvGs6paO9fo96nxByHd7XXFEmmsZ+p9QF6chZMDKH2mbaNh/m8DuywCjl2CW445RbWSOFxzTDdMfyMbtEPPm2ABAB1+eanliOz+fpRXrtJhC55qJNl8NkW6lRqXV1TL4nZ3gYtomubu1RRax3C0760icAMb8VOuk23CRFloeYkkko63Mpr2PLL9tHiPWV7RdO+T9T5RjhNk5qm79Cr1dH2ViKR9VXNQSXP2m0kJS54cKfpc7p+ePZzZvjFs3u5nAol1zfj9abnmkd/bTkpjVY8tSFua4wFWGtWMG+cLbktYIqT0Tds2hbyqUXKFLotCNpXvkHQMCp5xacdqQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ABOy2eIDdsp6vK3CxREgVkNbS5AWcW3H7w/PlWtH0JY=;
 b=qPdjbYloyBYRXR6AZ2Bp1GqdJUxaOxJJPC83ANkWpPITnJzbC7KPhqrT6pvo8Jrf0SWAUyEBMfvsvnN021KLVtOmGjL90Fb3+/AjdCeDk/T8PUSkQyD8x2zbMUEVzTt4Y2iCbaXVRhzKWOWf5IU7ocefofZNFJo2V+T3UNWPSuM=
Date: Wed, 16 Feb 2022 12:26:42 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 2/3] x86/clang: add retpoline support
Message-ID: <Ygzfcop5TrpeXfG1@Air-de-Roger>
References: <20220216090300.9424-1-roger.pau@citrix.com>
 <20220216090300.9424-3-roger.pau@citrix.com>
 <c5657f85-e3c4-9c39-1a67-b5162b1f86ef@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <c5657f85-e3c4-9c39-1a67-b5162b1f86ef@suse.com>
X-ClientProxiedBy: LO4P123CA0409.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:189::18) To SA0PR03MB5610.namprd03.prod.outlook.com
 (2603:10b6:806:b2::9)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9e62d399-560e-425e-5650-08d9f13f37a4
X-MS-TrafficTypeDiagnostic: BYAPR03MB3447:EE_
X-Microsoft-Antispam-PRVS: <BYAPR03MB3447A07DF0F2921FA983752E8F359@BYAPR03MB3447.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6430;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: B4iR7aJLhudHIzl/GQkMt9+zrPNE5wpdj52izv6ZLL2g86Q4sTFgIlNK+i2v17VDiT562nv5Hc5pf/bx+hjZU6OwnBQ+EyPlWmOJk9Y50mUGF98EeMplhbJTG84T4go/9Wubaof+q5Ch6W+yBOMES/VY6FL2gM7W6/bx1KWBApBzQMGCvjrvEhivtftg/rk4o6YmkfXBohezOIqURzT1WKAvMz9tRE69xJ2Te8Tt7OQp5azqQb8UdTeW08T11dkyW/lzV7QmvmxK0slg8pbjinrS/XeU9jWFCjhCjiP76rjhEH8V6XvNqb3nBqQzQMEuXAjq26/M8h4H8XYERZj9AXKpuMliMYVsl6elTdWxnq4mlUmJPN4vpejfAswxsFqhM/Rjc3TMDi5y3ragTNexanPtwHsdfCVrvtQPW/CGkR3MHV/rNSJT6TGms5Ic5fmUx1CCtaclh299VwdV30AfnUGJg6vmPFNgM8g/C/ufo8y2LwcOpXVG8aeyxRsz8sIHI91GtM72dadW/aP1iiRrs6YkB1nTuUAvzRzNrXhUQgc0zGRMk4s+/a/hqycEo5bjLr+qSKphOO5GJzULUM6rpaM+6++uRRD/xn1N4bOO+n/sPosCCAuocp8kqZJ3yjVqz13braeHcmp3Rr3/XZdhgg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA0PR03MB5610.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(6486002)(4326008)(33716001)(2906002)(38100700002)(508600001)(82960400001)(6512007)(66556008)(66946007)(54906003)(66476007)(316002)(6916009)(8936002)(83380400001)(53546011)(186003)(6666004)(4744005)(6506007)(9686003)(85182001)(5660300002)(8676002)(26005)(86362001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NEtjWDRSU01CeklHam5acHBKK0tZQzl5TXlsWnpVelVkT1ZCVEdUUjFOWS8y?=
 =?utf-8?B?Q1U2OFgyOEJSM0FnMlo4Y3BCeHF0N1dKVGl1MndIV0lad0FQNFlKRlFXNnRP?=
 =?utf-8?B?N1Z0VFB0UTdaeC9zeUYyM29DVE1XbUhKUC8yWHlPTFdzTEZwN2plbmpXaDFm?=
 =?utf-8?B?S1dPRkhEcXJlbFFveGx1dFJiMS9UQStaUjdIRzhxZGtsMTNEUDZvQ3MycTc4?=
 =?utf-8?B?bVc0dWIzR3hISmsybkxXV3Z1YVp4ZGFzMktONnRWS0xCSFJxVFNsMDZ5bkY4?=
 =?utf-8?B?SFdmQzBhek9mR3NpRk5zd2YyUmVCK0xaZHFlbVZNTWtBNXdrTGdJdjQrUFRl?=
 =?utf-8?B?elFvQkYwaXBFSTF5WVVHeU5pLzdEKzZtTHNKZ2J4SVZ0OFJybzZjM1NtVXll?=
 =?utf-8?B?Y0tDQU5qbDlKZ1J6Z0xYN2NuOHRpbGNQcDkzQ0M2VW9WYmp3Sy95ejZyUzJm?=
 =?utf-8?B?VDloMDd6M1NFdVF0cHUzRDRtTCtSYUxob05OVWREUmcvaWhlZTJmVDFudDNm?=
 =?utf-8?B?Y2xoRVZKdEM5a3k2ZnBCcm83M0ZqNGlPODNjT1hXQXYrN2pLZDh2WmgvdG8v?=
 =?utf-8?B?NlNSbHhrNXpaL0dvVVhQQy8yOTVhQmtVWWsxM2I0SlNpQTN1N2ZDQk9mL1hS?=
 =?utf-8?B?anVGZUY1aDNxd041L0pDaVRVL0kxTUd5UGVDQml5RkZVejd3ODVYQXJQbUE5?=
 =?utf-8?B?WjBwdnZuMFFKbHFCTnZqdDRraGo1Rk9Ja0dURmJmVzJIQzU4V3dIVG1PQkZ0?=
 =?utf-8?B?RXBTcGZ2SEk0dG93V2w3ak12ODhzNENYT3JmZWN6S3IwYXZCUUdMRDUxSFV1?=
 =?utf-8?B?VzBvK3R0OVV1c0tJQ2lsVTJUS0phaXllOU9qWFE0WXpBYVM5UzNVdDgwMDhP?=
 =?utf-8?B?c3plQS9mT2tmSXVyL2Zhd0dhN0l3OVF6UWJtVzZhbWZSQzRvSE93NEc3Vzg3?=
 =?utf-8?B?M3pPWnVwazdqRUVHQ2piWUI2N0tRZVhqKzhLMUp0TTZlcDArZmJTNVJKcWh6?=
 =?utf-8?B?MERwZnhnekpjMllsRDJUWmpGTkpmalV5ZUpVeVBFN0lGZTM5bWl0blNmNUJ3?=
 =?utf-8?B?dEdHRFo1V2c1TFRhRFJvU0hUdTlSaVVBYkpBaCtNZUtWdlNoY0RVVUtjK2Rt?=
 =?utf-8?B?THlLc3p4K0JRT3lVemhTRGIxQUc1SWMvYUZOTGxaWUZEa1FCWndXK2VRYjFl?=
 =?utf-8?B?R0l3UDdoTUM2QVlQSm1qODdqSmNXaThsRFgwZE9FNVdZclc5UVczelVIZTRZ?=
 =?utf-8?B?cGNZcWNuOEJtMHh1eGN3VVNLMEtUMTlneTBCYXFCNWZOOXFDb1NDMXhha20r?=
 =?utf-8?B?VTlHdS96cUNWNWVZNHNNT1NrM0pTdStURFMvTVdBWEdyV3NDQXJiL29tcVJw?=
 =?utf-8?B?N2swVHVKR0NvZlViT1dQaFl5TXJYZk1lWVBKdm0rSUZhN0lqb2ZHejJHTVY2?=
 =?utf-8?B?SEMzWlFiVGJUbzBpbWVBYm5zcGJNeXhTNElzb3pZTmtCQXRhYnkyY2FoaFQy?=
 =?utf-8?B?ZXM3eHRlSSsrdUdtQVFlZ1dZdFV6Y1J2WUhEaE95eDBRUWlTWDN4MDNXUlBM?=
 =?utf-8?B?V1pQVWlubXhrQTlVL2tJOThuL0NxeTZGa01VQlJGQitKK0VwbDBmVGcwN1E1?=
 =?utf-8?B?cmtQMDYwU1BmQkFuZ0NFMjZMK01pM3piU3NDSExTaGJVOElpZmtFeStOK0NM?=
 =?utf-8?B?em1xTGRxVGlHbU9JODNpVEVuUldkSXI2WDNvQzczek1keGRDRDRCWFdsT1JQ?=
 =?utf-8?B?WDRlc0Z0N1ZKcmlLWklvblRUdXhhREJuaGtGVURyQUxLNkhhUjJBT2NRb0or?=
 =?utf-8?B?Zno4bFlqMEN0WVZXVi9PYVdHVGJxdmV5TEFIQTdXKzkyTGQ4WXVsQnRpbWNK?=
 =?utf-8?B?eW1oRG9MdkhaZ21VUE9qek92dVd6dFkwVVN1OHA2WDVJYjNmUTN2UElnSUJG?=
 =?utf-8?B?WXB6Uk1BS3ZsOTVJUHpvYmVvVkhpOHNnQjYwUTIxMTFFWi9yNEJac09NKzNO?=
 =?utf-8?B?TzRtSEErVWN2K1hVQ0lhUE9xbEhyeE1Dc3BOaVdJa2RLeVhkdVJLSjNVMHhB?=
 =?utf-8?B?RlMxYWdRa05HUlBKR0tTbEwxYmwzRUsxOXljRXQrRGpmY3g5ajcyVW5jNzR5?=
 =?utf-8?B?RXZHRzc4elZYZ0ZOdHQyVUVNTkNndUhOYWd6YXQyaStaUW90QWVpcWc2ZzVB?=
 =?utf-8?Q?DkZiy5uSGPl7YQtg/NUigKQ=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9e62d399-560e-425e-5650-08d9f13f37a4
X-MS-Exchange-CrossTenant-AuthSource: SA0PR03MB5610.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2022 11:26:46.9792
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OLyH39yWK688Toa5VMEdD9nPL3dFL1ERmXkTNmW5mzyrFh68EVuTQWTINDy2ytrO3dPDKAfI0dvxbyPSG31D2w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB3447
X-OriginatorOrg: citrix.com

On Wed, Feb 16, 2022 at 10:47:52AM +0100, Jan Beulich wrote:
> On 16.02.2022 10:02, Roger Pau Monne wrote:
> > Detect whether the compiler supports clang retpoline option and enable
> > by default if available, just like it's done for gcc.
> > 
> > Note clang already disables jump tables when retpoline is enabled, so
> > there's no need to also pass the fno-jump-tables parameter.
> 
> That's one of the secondary gcc side arrangements. What about the other
> (-mindirect-branch-register)?

clang already passes the return address on a register always on amd64
so that's not needed either. I can add a comment like I've done for
no-jump-tables.

> > Reported-by: Jan Beulich <JBeulich@suse.com>
> 
> That's Andrew, not me?

Ops, sorry, I got that mixed up then.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Feb 16 11:32:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 11:32:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274016.469336 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKIYF-0001AI-C7; Wed, 16 Feb 2022 11:32:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274016.469336; Wed, 16 Feb 2022 11:32:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKIYF-0001AB-9D; Wed, 16 Feb 2022 11:32:51 +0000
Received: by outflank-mailman (input) for mailman id 274016;
 Wed, 16 Feb 2022 11:32:50 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=oYE0=S7=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nKIYE-0001A5-CD
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 11:32:50 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 29b66924-8f1c-11ec-8eb8-a37418f5ba1a;
 Wed, 16 Feb 2022 12:32:48 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 29b66924-8f1c-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645011168;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=9mOJ7FkLWzanCVzXa2si9+t71PueQ44776rxRJ09r9k=;
  b=PV2haipWSP6XHte4C4Cdyf/KrDTwQ0yw82hhY9kp0lRAzBIbVC7r6d/e
   MG+vR9k4BWF+e9IeLx0vRMA/eJJgZoDlvaDr0T6K1sIDl67BCZAhMxOqV
   PzxIv4EnD0zHTMG0wL/QkTqm9beQSaWFFaGDS8OcyOoJrpGiakr3eGOLy
   s=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: yrmqXNTPy+qhf4EldBd/TPQUh/9k7e+8QGPkBGPwwWqewAbgS7PEZBBDpQAvRxkjUeLYEMamH9
 zlBktMQNbFHM4N6bx1dS1EVZRXICWUcrn5kFyj3H6sj8ytet1V6G0PcP05VjBUXvmwwfi9MRvx
 yLlUIDI2thwQiXn9v5uLBsUJXi2HRIAz97OGrkQGcU0XAIBYb9ZoEf3khq395j02B1FDQ/VFdK
 Q2KuVsvc/FBZrUuZZVCwCu+vvea+ifNKUPNuSKRgEdiVU9Tz+GQbO7W1RLkpXQPlaOp9AVan8C
 uyrS5V+YOKk1PB1fe2Ea5Yzx
X-SBRS: 5.1
X-MesageID: 63772499
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:WT2fI66dIr6yXeII46i6jAxRtGfBchMFZxGqfqrLsTDasY5as4F+v
 mUYWmGAOfuMMWPxKdgiPISy9ksCu8DVy9VqQVc5qCk0Hi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FV8MpBsJ00o5wbZj29Aw2LBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zw
 oRQ6aPrECQSLIrCsr4GX15pIQN+FPgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALNs7kMZlZonh95TrYEewnUdbIRKCiCdpwgmxv2ZoSTKe2i
 8wxVSFKawT8aj92GGhIDpEstb+SmmTxfGgNwL6SjfVuuDWCpOBr65DTN97Sds2PVN9itE+Sr
 WLb/Ez0GhgfcteYzFKt+H+2mvXGmy+9XYsIDaC57dZjmljVzWsWYDUJUXOrrP//jVSxM/pdI
 UEJ/islrYAp6VemCNL6WnWQomOAvxMac8pdFas98g7l4rrZ5UOVC3YJShZFacc6r4kmSDoyz
 FiLktj1Qzt1v9W9UXuA8p+EoDX0PjIaRUcZfjMNRwYB59jloakwgwjJQ9IlF7S65vX5BjTvm
 RiLqiYkjrkehMJN0L+0lW0rmBr1+MKPFFRsoFyKACT1tWuVebJJeaSiuEWH0q0ZD72LaVer5
 mMI3PmszuAnWMTleDO2fM0BG7Sg5vCgOTLagEJyE5RJywlB60JPbqgLvmggeR4B3tIsPGawP
 RSN4V85CIp7YSPyBZKbdb5dHCjDIULIMd3+Hs7ZYdNVCnSaXF/WpXo+DaJ8Mo2EraTNrU3dE
 crDGSpPJSxDYUiC8NZQb71AuVPM7npjrV4/vbihk3yaPUO2PRZ5s4stPlqUdfwe56iZugjT+
 Ns3H5LUl0kODbSkM3iGqNR7wbU2wZ4TX82eRyt/LLDrH+abMDt5V6+5LU0JJ+SJYJi5Zs+Xp
 yrgCye0OXL0hGHdKBXiV5yQQOiHYHqLllpiZXZEFQ/xgxALON/zhI9CJ8pfVeR2r4RLkK8rJ
 8Tpju3dW5yjvBycoG9DBXQ8xaQ/HCmWafWmZXr1OmNuIMQ5GmQkOLbMJ2PSycXHNQLu3eMWq
 Ly8zALLB50FQgVpFsHNb/yziVi2uBAgdChaBiMk+/FfJxfh9pZEMSv0gqNlKs0AM0yblDCby
 xyXEVETouyU+90599zAhKalqYa1ErQhQhoGTjeDtbvmZzPH+meDwJNbVLradz7qS26pqr6pY
 v9Yzq+gPaRfzkpKqYd1D51i0bk6u4n0v7Zfwwk9RCfLYl2nB6lOOH6D2cUT5KRByqUA4Vm9W
 16V+8kcMrKMYZu3HFkULQsjT+KCyfBLxWWCsaVreB33vXYl8qCGXENeOwi3pBZcdLYlYpk4x
 eoBudIN71DtgBQdLdvb3Dtf8H6BLyJcXvx/5I0aGoLiliEi1kpGPc7HEibz7ZyCN4dMP00tL
 mPGjabOne0BlE/Lcn51HnnRx+tNw58JvUkSnlMFIl2InPvDh+M2g0INoWhmEFwNw0UVyf93N
 0hqK1ZxdPeH8DpfjcReW3yhRlNaDxqD902tk1YEmQU1laVzurAh+IHlBduwwQ==
IronPort-HdrOrdr: A9a23:KTgKoK9XhSfGdTTTUHpuk+FAdb1zdoMgy1knxilNoENuHfBwxv
 rDoB1E73LJYVYqOU3Jmbi7Sc69qFfnhORICO4qTMqftWjdyRCVxeRZg7cKrAeQeREWmtQtsJ
 uINpIOdOEYbmIK/PoSgjPIaurIqePvmMvD5Za8854ud3ATV0gJ1XYGNu/xKDwReOApP+tcKH
 LKjfA32AZINE5nJfiTNz0gZazuttfLnJXpbVovAAMm0hCHiXeN5KThGxaV8x8CW3cXqI1SvF
 Ttokjc3OGOovu7whjT2yv66IlXosLozp9mCNaXgsYYBz3wgkKDZZhnWZeFoDcpydvfomoCoZ
 3pmVMNLs5z43TeciWcpgbs4RDp1HIU53rr2Taj8A3eiP28YAh/J9tKhIpffBecwVEnpstA3K
 VC2H/cn4ZLDDvb9R6NqeTgZlVPrA6ZsHAimekcgzh0So0FcoJcqoQZ4Qd8DIoAJiTn84oqed
 MeQ/003MwmMW9yUkqp/VWGmLeXLzYO91a9MwQ/U/WuonlrdCsT9Tpc+CQd9k1wg67VBaM0o9
 gsCZ4Y542mePVmGZ6VNN1xMfdfNVa9My4kEFjiaGgPR5t3c04klfbMkcAIDaeRCds18Kc=
X-IronPort-AV: E=Sophos;i="5.88,373,1635220800"; 
   d="scan'208";a="63772499"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=eScfiVuDSnaF6FajSjj6RE7Xfjbbpqy8rFIM4ekW7niFXMXmi8TcuGpzBCzGpQodPT5bLXHk4VcWMkAat/vSBh/PyTZ6ZWk/Y5JeDEGEArcQa4YZ2E5B893tqyb1AX95SDgy8e5+zuYTW4Nrh6IfJlstrB/hn5RjaNcpDMokVzwZlednjuckzqozOPgYnyMix3pIEfkHV3YHWMHadSGYgt4kfwy3/gBiiSmHdxECpIm4a+S5i/x5v41lfMlhwr1IQdsBsKftXrdXYFoyS73mbZ6kGbVQepORqFnSCVRNMe0C8gNJkabHJzi/V3w5+Lp90U9t1cxRTVWEhZV/b+QK8Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=au0BypD7hjMkW1NmsRUpn0eJuS8LJaAXl1P290c0w80=;
 b=l0+DkPDkteoRNvY4jA5Vy+04X/bK5SoMN980AzwsCIZVuA6XduQrbVQATrZzWdOLO4Q/ex+MjeZE+nzVNYKi3MZ8slbpS7OM6dn9MsGR3ygItcQFdSkvnqwRustwtCsjIc8QwPpaYi/zS4O0ioZiVsmMwxoW2zH4Ub4QBbz90wnkpxXzJ3d9JVfHooOQun9K5nVXiT4Jpbb3tHDQGq/ruSOR13fHdZXUZx3+xUaqCfGmbf6Uf+FoVk0KGGpWcWlkGUDb2CTeSuAfShzr6ekvpfWKqzOry0H5PT9Ho8erW3rr4TvPc6DpHSRruqLL2l0fX2jUCvBdsyyPrlEYgG3Hqw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=au0BypD7hjMkW1NmsRUpn0eJuS8LJaAXl1P290c0w80=;
 b=tKt7R7OxR2yWgcy5GqC2o4Sx6QkHrpOJT/XJzg2qhmkWWyVs660we3CyrK7RosfToqKI5/EF/vnS8s8+n6L0+jNFnAsU6JU3KAJRm+M+aBBTSr0IZ8gC6az2HjiqZGdpFSmhAJSntH95+B9BFF22uAdYGDgVc3XdTybIrN6IQUo=
Date: Wed, 16 Feb 2022 12:32:31 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: <paul@xen.org>
CC: <xen-devel@lists.xenproject.org>, <dwmw2@infradead.org>, Stefano
 Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Bertrand
 Marquis <bertrand.marquis@arm.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
	Wei Liu <wl@xen.org>
Subject: Re: [PATCH v2 RFC 4/5] x86/ioreq: report extended destination ID
 support by emulators
Message-ID: <Ygzgz3PONncqIH16@Air-de-Roger>
References: <20220216103026.11533-1-roger.pau@citrix.com>
 <20220216103026.11533-5-roger.pau@citrix.com>
 <73c3db96-fbca-9d03-d645-4d44ab6a640f@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <73c3db96-fbca-9d03-d645-4d44ab6a640f@gmail.com>
X-ClientProxiedBy: LNXP265CA0046.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:5c::34) To SA0PR03MB5610.namprd03.prod.outlook.com
 (2603:10b6:806:b2::9)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c5e84408-a0ac-4c91-3283-08d9f1400770
X-MS-TrafficTypeDiagnostic: DM5PR03MB2572:EE_
X-Microsoft-Antispam-PRVS: <DM5PR03MB2572CA594E95CDAB26D2ACB08F359@DM5PR03MB2572.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: KXSNeisNKXAcgRHcAzurFXaF3t/lom7siuX2tPKvGWhNEEzESyBV0ksm8tmZ/vJhovUwXKd9x2DsMfembfo06w2Ep5AISm3xxPWDaVsPR3hZI6E8hK+DZd0JAKhpaWysMnghqsF0E59aaNhmekQDUzDIG8Jq10Tuvd8iBtaziDJAxn9QbGLOuE9f1ZTKJUzZxbJMRyv9DZRTaDy6M18DJuYw2ekKBAlI0i3fq+paGdK2KUY/BUzIZmZQHFdAjkuJFAqLZhWeDffeSuvR589h8sQHPc41WXUBKqsUCh6GEuWOoCEquJhxur6moBUwP9JdKzREENL8NftQtOh8bfMwLjnrYXHvovyg1poNsuaznyNb54TPWDoniYkZudbmXWm3YUnDnhYcs46FU7XbBR2w6rqqsb24Ii80XpM7xKwc90EwGOgidvfpFzFMqcbwfvaywneIhPwW61OD7IPJBJ35OAtsjO3uKe0oep0ULpbktskP/h1h2gOhBOi9Z0sWLT8MFPmt1vYlb+qQ4r102gPSDOpG6g6UOJ9C5v4+AG9XEHU+k2E7bTi3tv7A+RC8ekqyNX218W28ipLdSlo1ZteNlxkrstxpv28N8kDHUupQ2m39R2O/st9d9H9kYoEfU3aUFt4A+BzkFrEZyl4z+602/w==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA0PR03MB5610.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(54906003)(6916009)(26005)(316002)(508600001)(86362001)(6486002)(9686003)(6512007)(6666004)(8936002)(66946007)(85182001)(83380400001)(6506007)(2906002)(5660300002)(186003)(33716001)(4326008)(8676002)(66476007)(66556008)(53546011)(82960400001)(38100700002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QzJsenJOVnE3aUd2SlRZNUV2aDdxYkJkSGViR1hXc0hWNGZkdWRxTkxJSkpM?=
 =?utf-8?B?eDBGOEtndnJ3aTlFdS9naU43dFE1K0JsUi96Y1pVVDc4TmhMbFA1ckNjN2Uv?=
 =?utf-8?B?YklwT0pDQTA0RTZxWjZHb3BkbnhUL2FkbHdsK0RFL2RneDR5MENqOFBuKzkv?=
 =?utf-8?B?Z0ZYVUQwUkdpZ1NwRUF1UEp2c3d3WGRHYzc4VTkyNTdnUVZmQnVFczg5dUFJ?=
 =?utf-8?B?dUhDSTN0ZWpNZzFCUm1ZdDc2OHdGVy9MOG5EQUUrRU41NCsxL0lwMEs5dmJK?=
 =?utf-8?B?MHZEcDZ0YldvN09BVWpJUCt5b0VJcXRrRXJldjBtWnlxaWJ2QTZPQVFFNExP?=
 =?utf-8?B?MGNjVHpPSmRWMjNrU0RMWkUvMDJwblFDTmdKS3Q3aHdodGpTenRJQlZQUWE2?=
 =?utf-8?B?OGNZcXdhdERzdDA3TmV4SzNEaFVsMEVDbHhYWnU2ZmNUVnVadUYwU3ZjWXox?=
 =?utf-8?B?cE1sbllGTzkvRldJWWxKRHA5T2luc242eDVreEpLSnVkRXpURnZrbzJLSXV5?=
 =?utf-8?B?MWJBY2tmeTgySkdOMERPVUcrcUF0YndTQStxNDI1VUozQ0w2VThHWjNLMWw3?=
 =?utf-8?B?SXFnczRBSkJIMktDejF3QnUwVTRVN05zclpuMkNwLzZoM0RoUTA2L3QwYUdv?=
 =?utf-8?B?ZzFObWtQcEZTUy8ydW1ITXMvNEdkcWY1MUxzN0pINHlyVXViODJmUnprZk1z?=
 =?utf-8?B?ZFdCTFZOY2tYOVVXRGtiampDOTRkWElmekVraHpNNTF3SkJZU3JQMWoxc0lq?=
 =?utf-8?B?WTlSQy9EY3p6aUU2OEhmNldkOGIxT2x3TVR1RUR3SDZhbzNtZ2ZmZHk3VnlV?=
 =?utf-8?B?MGJZdG5tTkdPRDhOakZsckRScmluOW45MFlzT0JpREUwanJ0c3ZVN2dmOFAr?=
 =?utf-8?B?RDBlTlFXNUN6cGlMdXJoYnV0aFQzakVMaFgxcVN4WVM4MGZtZ1hTdks0TjFt?=
 =?utf-8?B?NlQ2WHBNS3VSZEpQYklxaDBjd2liWVhxNnpjTFZNTUhkVXd5N3o0L2JYdXBi?=
 =?utf-8?B?RkhCMkRJeWN1L2VHbEI3OEdCczRyV3hDcWFTSm1HRjZURk41UU1XWjJSQ3hB?=
 =?utf-8?B?UG9peEJtc2g2aklnQ0RzbmhVK2VOTTBPRGRScTlQdFIzTDA3NjZEclhtK2Mr?=
 =?utf-8?B?cnJsMGhWMDg5MXlxbU1RdGhkVVNaN0xlVFNPSVdRbEs5MS8wZG5LQ2MxeWNW?=
 =?utf-8?B?dnlFMjU2TUtaYmZ4YWMrWk5tblcxS1h1R1hjemQvK1JnczFQcWhwM3ZHVFBK?=
 =?utf-8?B?a1pXcVYxYU56RnhZUjhTUlFDNmh1UEZmNXFGTXNaa3Zralk2cVk3enhTNkZ1?=
 =?utf-8?B?M0IyQlN2dENHUjdCNklVNHU3c2NQV2RXU3JGRVFNWFpKVHZsdjVlZmVtK1FZ?=
 =?utf-8?B?SXRoM0VjUnBTSDBlRHpIR2kyQlF6OTBJOGJKL3NuNWxHbEo2UEhJS1dkeDhS?=
 =?utf-8?B?RVN4SmZZKzFxK3Y1ZkhyZFRydENxYXpvbDFWdWJrdVFyclhmMVF3M1BvUFQ3?=
 =?utf-8?B?ZXUwSitsYWZwNTVlSGNoY2s1OEY0Kzlia3B0bkN4Mzd6a1VtV2ZnUDYrdFNk?=
 =?utf-8?B?MmJNMXFqTjZZM3BKSFRzc0pBQzkrY2tRZWZ3Mkh5WHlNYytPcHlaWVdZV3BN?=
 =?utf-8?B?dGpJQ3BaYmc4TmNLb1FnemhUSS9ueXM0dTQzZi92RWJwNmtuQ2ZlSC81L3JD?=
 =?utf-8?B?MnBjL1ZKQ0RwZFgxRVJHWHdQaitmYVBxUmZNMTdEeVd6d2F0U29zZDgwaFQv?=
 =?utf-8?B?eURWcUwxd3NWNnpLL0xhMVBYRVUrNk1uVmx0UUE5bEppQTAxMWdjS2NMSEc0?=
 =?utf-8?B?anhYTUkySUtSK20zZDcrQURTNy84dGJUNExaVzdPakpmWUIxODdsNVZxYTg3?=
 =?utf-8?B?SHc1VEkvdTc0SDhKZEIxU3VYWEcwY3BRVlkzSlNZY2FkVlAydGJ5LzlTWEJ0?=
 =?utf-8?B?Q21ydzZhSmQzSmZHTmFHT01WNUNsUEdQUlh3V2FiZmpBUFJENW83dVpBbTFC?=
 =?utf-8?B?ekxnOXkxVjBBa0ZTVlFMSko1VktuTE1CNURnTmtMWWFQa0tjaVEzRTFyd2dn?=
 =?utf-8?B?REVFRlRuY1ZRbEhMTTBlVG0rMDdFSmN2NHp2ODIxYWlxNFUxeUtzem51M2hG?=
 =?utf-8?B?Z2lGSDdBV2wxZkJBeVNrV1AwblNOdEpXampBZFYxdmlkVXZaMU85d0ZMWkI2?=
 =?utf-8?Q?aMz+o/Yxt/i50ldXpfE46kw=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c5e84408-a0ac-4c91-3283-08d9f1400770
X-MS-Exchange-CrossTenant-AuthSource: SA0PR03MB5610.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2022 11:32:35.7598
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wzI5kOEDHHaHeLthGWL0ATNu/N4zGLviSy24Qi7tQZdgIRZGO3eM8SyYjrwPAk0QqXKQFNXLxWI6Fv0Eoa8C2g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2572
X-OriginatorOrg: citrix.com

On Wed, Feb 16, 2022 at 10:53:58AM +0000, Durrant, Paul wrote:
> On 16/02/2022 10:30, Roger Pau Monne wrote:
> > Introduce a new arch specific field to report whether an emulator
> > supports the Extended Destination ID field, so that the hypervisor can
> > refrain from exposing the feature if one of the emulators doesn't
> > support it.
> > 
> > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> > ---
> > Changes since v1:
> >   - New in this version.
> > ---
> > RFC: I find this kind of clumsy. In fact fully emulated devices
> > should already support Extended Destination ID without any
> > modifications, because XEN_DMOP_inject_msi gets passed the address and
> > data fields, so the hypervisor extracts the extended destination ID
> > from there.
> > 
> > PCI passthrough devices however use xc_domain_update_msi_irq and that
> > has leaked the gflags parameter in the API, even worse the position
> > of the flags are hardcoded in QEMU.
> > 
> > Should the clearing of ext_dest_id be limited to the domain using an
> > IOMMU?
> > 
> > RFC: Only enable ext_dest_id if max_cpu > 128? So the device model is
> > aware the domain must use ext_dest_id? (implies device model knows
> > APIC ID = CPU ID * 2)
> 
> There is still only a single sync ioreq server page, so 128 vCPUs is the max
> possible.

Right - so device models wanting to support > 128 vCPUs will already
need to be modified, and hence we could assume that any HVM guests
with > 128 vCPUs is using a device model capable of handling extended
destination ID?

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Feb 16 11:34:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 11:34:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274023.469348 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKIZr-0001kq-Nz; Wed, 16 Feb 2022 11:34:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274023.469348; Wed, 16 Feb 2022 11:34:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKIZr-0001kj-KJ; Wed, 16 Feb 2022 11:34:31 +0000
Received: by outflank-mailman (input) for mailman id 274023;
 Wed, 16 Feb 2022 11:34:30 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=nrBo=S7=citrix.com=George.Dunlap@srs-se1.protection.inumbo.net>)
 id 1nKIZp-0001kZ-Uc
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 11:34:30 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6571f948-8f1c-11ec-8eb8-a37418f5ba1a;
 Wed, 16 Feb 2022 12:34:28 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6571f948-8f1c-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645011268;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:mime-version;
  bh=Tn7bVSJVe0TQihNERmSZm9Ar/5n1NiKTWVncNWpVH84=;
  b=gxBVkeuXzvMcHjDLdp04msxFjEkIjVA8Zg0/LuNNuvnTLapbAXnSePAy
   K1uzpcWXQ4WfVAahTT5VXjr6IKWC86K/O9he5QXsNQy7rEMrl204RN9bt
   u8JLeyERzuZh875Np/7yZYIHV55rBNy3FXbrd2K/6i2p4mDUwKj/fTciu
   c=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=hardfail (body hash did not verify [final]) header.i=@citrix.onmicrosoft.com
IronPort-SDR: oSprCU1l+9BcfjiZ7sgraq/iBIQN6QKu+zxIY++g9sVCRtKrehGK/tLAIhazUZq6eD0P5v5kI0
 lEVgWggmnu5gCqQu3pmXYmN/ceNtT8SJSIbZG4rtSOrxSFNorj0UwkXecUvctv3X5p16G80j6C
 uOu7CLjvZZ4UJ72y7mEL1ty6wualIsFRTlyEc8pE2NsINGsqw91CgWooDLnd8DwD96Ogj1S6ck
 ELoBGKcfynTA/WkVoGHBFRGL13F0NQqEkP0V9GWnvXwXItjZB2xsnEwFqlYrd7yOtGFdUC7foo
 pkG//mL6D9DVEPe1gwatknf+
X-SBRS: 5.1
X-MesageID: 64736905
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:X5zeoK/DPJDS6MmYUfGDDrUDiniTJUtcMsCJ2f8bNWPdYAuX7wSz/
 BJcAD7Ya7vPIDfrKpolWDmFhR4AucfXmoU2TQdrrS41QikUopLPW4rAJBigZHqfdJKfEhg34
 pkUNIWfcJ8+QnaM+Bvwa7G5o3Ali6+GGbalAbGs1kydPeNBYH5JZUVLx75p6mIRveWEPu+th
 T/Ti5zRZwP/0mMsaTxNuvnY9Esy4v2q4GkWtAVvPf4XsgSOxiUZVJ4RG/q8fiDyKmV28k9WZ
 AphIJWRpD6xE8IFU4v9+lrDn8ljrof6ZWBisFIPM0SZqkUE9nxaPpoTbqJGMx8N0mvRxrid9
 f0W3XCOYVZxVkHzsLx1vylwS0mS6oUfpdcriVDm2SCi5xWun0nEmp2CP2lvVWEswc5lAHkmy
 BAtAGtlgiZvJQ6B6OnTpuFE3qzPJSRwVW8VkikIITrxVZ7KTX1fKkljCBAxMDoY36hz8fjii
 8UxZH1wQk7pbUB2KgkxWJIht9mloWLzSmgNwL6VjfJfD2n7yQVw1P7mMcbPe8zMTsJQ9qqaj
 juYpSKjWEhcbYHBj2remp6vrrancSfTd48VDrK1sNJ3hlma3kQYCQEMVEv9qv684qK7c4wDd
 BdKq3JzxUQ03FKGd4W6XQ+XmSC/4DguB91uEfQgxyjYn8I45C7GXzNZH1atcucOr9QqTDYn0
 luImdLBBjF1trCRD3WH+d+8sjeaKSUTa2gYakcsTxYB4tTliJE+iFTIVNkLOKy/g8DxGDrw6
 yuXtyV4jLIW5eYh2r+n51nBj3SJr4LQUw8uzgzNWySu6QYRTJ6oYcmk5EbW6d5ELZ2FVR+Rs
 X4cgc+c4esSS5aXm0SwrP4lRe/zoazfaXuF3AApT8JJGymRF2CLcMdPzmtXKhpQIpgiKT/2S
 3Henhhd3coGVJe1VpNfb4W0AsUs6KHvE9X5S/zZBuZzjohNmByvp383OxPJt4z5uA11yPxkZ
 8/HGSq5JStCUcxaICyKq/DxOFPB7gQ33ivtSJ/y1HxLOpLONSfOGd/p3LZjB93VDZ9oQi2Iq
 76z1OPQkn2ztdEShAGNrOb/ynhQcBAG6Wje8ZA/SwJ6ClMO9JsdI/HQ26g9XIdugr5YkOzFl
 lnkBBMEmQem3yyWeFzQApyGVF8JdcwixZ7cFXZyVWtEJlB5Odr/hEvhX8dfkUYbGBxLkqcvE
 qhtlzSoCfVTUDXXkwnxnrGmxLGOgC+D3FrUVwL8OWBXV8c5G2Thp4+1FiOypXJmJnfm6qMDT
 0iIi1qzrWwrHF85Uq47qZuHkjuMgJTqsLgiDxGTc4YJIRiEHUoDA3WZs8Lb6vokdH3r7jCby
 xyXEVEfo+zMqJUy697HmeaPqILBLge0NhMy87Dz4enkOC/E0HCkxIMcAu+EcSqEDDH/+bm4Z
 PUTxPb5aaVVkFFPuot6MrBq0aNhuIe/++4EllxpTCfRclCmKrJ8OX3aj8NBgbJAm+1CsgysV
 0PRptQDYeeVONnoGUI6LRY+arjRzukdnzTftKxnIEjz6CJt0qCAVEFeY0uFhCBHdeMnO4I52
 +Yx/sUR7lXn2BYtN9+HiAFS9niNcSNcA/l26MlCDday2AQxy1xEbZjNMQPM4cmCO4dWL00nA
 j6In66e1b5S8VXPLigoHn/X0OsD2ZlX4EJWzEUPLkiik8begqNlxwVY9Dk6Q1gHzhhD1O4va
 GFnO1csePeL9jZswsNCQ3qtC0dKAxjAoh79zF4AlWv4SUi0VzOScD1haLjVpE1JoXhBejV7/
 a2DzDe3WDnnS8j9wy8uVBM3sPfkV9FwqlXPlc3P8x5pxHXmje4JWpOTWFc=
IronPort-HdrOrdr: A9a23:aGgfiqpPpsIoYaEW8fqxXJMaV5ucL9V00zEX/kB9WHVpm5Oj+P
 xGzc526farslsssSkb6K290KnpewK4yXcH2/hsAV7CZniohILMFu9fBOTZskTd8kHFh41gPO
 JbAtJD4b7LfBZHZKTBkXGF+r8bqbHtmsHJuQ6d9QYXcegDUdA50+4TMHf+LqQCfnghOXNPLu
 v62iMonUvDRV0nKuCAQlUVVenKoNPG0Lj8ZwQdOhIh4A6SyRu19b/TCXGjr1YjegIK5Y1n3X
 nOkgT/6Knmmeq80AXg22ja6IkTsMf9y+FEGNeHhqEuW3XRY0eTFcdcso+5zXUISdKUmRIXeR
 730lAd1vFImjHsl6eO0F3QMkfboW8TAjTZuCClaDPY0LLErXQBepF8bMtiA2vkwltls9dm3K
 1R2WWF85JREBPbhSz4o8PFThdwiyOP0DAfeX56tQ0vbWIyUs4YkWUkxjIfLH7AJlOP1Kk3VO
 11SM3M7vdfdl2XK3jfo2l02dSpGnA+BA2PTEQOstGcl2E+pgE082IIgMgE2nsQ/pM0TJdJo+
 zCL6RzjblLCssbd7h0CusNSda+TmbNXRXPOmSPJkmPLtBLB1vd75rspLkl7uCjf5IFiJM0hZ
 TaSVtd8XU/fkr/YPf+laGjMiq9NllVcQ6duP221qIJzYEUHoCbQhFrYGpe5vednw==
X-IronPort-AV: E=Sophos;i="5.88,373,1635220800"; 
   d="asc'?scan'208";a="64736905"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=kaqRwGpva5iQm9cREGeYTMco/16Nk/fC5jm8RSPwPmBxNxsk+mIxNLXXo3nYRJfzl2QJwFKjnbQmV8shfbQw0SInbdWSv7BLVEy7IWd/HBiZLSU7KH9dBKcKgQJoUGeJB1gl6EoH5QNpFg9gQUtFbXWHtxs8PS2oEm/omVce3fUBucdAObid/ji1bQbQ982lttIwwzGbuzGyHqqVNdxQUEkrlxNUbrnyV7gCYlBdwTk/Z7QPvKFzjQ5glBt00Q3gEOrYD5DQaKBgBzWQz0xHu2Ig/Z43xXkmkr2sGy7X8LP82WNuCD8570KZneXYrzUGAAO5aHy+r5GcGx7tbOoDpA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=YsdX51WXsh9P2Sj+L7xGle/P8pJ6O5xUJG2Rw6EWCc8=;
 b=MpT0QeUKyWjJlIOJP/spAYoWWTl5JdKSFFgtALLzkx1wkqHv5MH+r5BdUc5neA1H7lxWMQoD5y+MXmKqOZYzB8g3vdodlhuPb6IDEsE+PjMjDqqzDTZNniA9synyc1g/aGNC2Jb8s9VlZZoNBgRZ5WCkuor2erkUclyS3E8Hlis9VbXzZ6dOmym30gNDaKxpN1bi4CB0xnZZh8MJ4NV1wFGbJsQw7nt30DuBc4wEO3T7+Y9cbMUIGdq0aa0AP7vHov0VUzD9zKGj8DieWzBOE4Q7YxC2+f/zSGZ+ArcdcyPbnYaKc89ByA8tGxI3rHqZral833liMbWKIpSdfKAfnQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=YsdX51WXsh9P2Sj+L7xGle/P8pJ6O5xUJG2Rw6EWCc8=;
 b=AXuWUjgyali87iNK3Z082HKhE3a9TE1J+kQQe8UDCkd/Qe/7xFcxX0QFjOn1MZnC+502lvNrfhroEwHeMhF8xf+8nUnD+GnULBJ28zjrEnEtUthvsBiiVMs3pUUVJIN7wKy2Mq6LNpfsYYitlkdMAhh7BqFlstxjZmG5Rzk1XjA=
From: George Dunlap <George.Dunlap@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Bertrand Marquis <Bertrand.Marquis@arm.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Andrew
 Cooper" <Andrew.Cooper3@citrix.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Wei Liu <wl@xen.org>, Roger Pau Monne
	<roger.pau@citrix.com>, Julien Grall <julien@xen.org>
Subject: Re: [PATCH v2] lib: extend ASSERT()
Thread-Topic: [PATCH v2] lib: extend ASSERT()
Thread-Index: AQHYE4shsIFDV42A206yi2y9mPx4ZqyVNw0AgADQCYCAAAHgAIAAIi+A
Date: Wed, 16 Feb 2022 11:34:21 +0000
Message-ID: <DB014136-7797-4A61-9681-33A7D85403AA@citrix.com>
References: <75125344-b0e1-9663-4c1a-84bb35870fef@suse.com>
 <35d82770-66cf-e030-5bcc-3c030e4463d7@xen.org>
 <3F58400B-5151-42F2-8F39-109DDF50EE1E@arm.com>
 <a89223c8-f59a-24cc-96a7-e40feb28813f@suse.com>
In-Reply-To: <a89223c8-f59a-24cc-96a7-e40feb28813f@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3693.60.0.1.1)
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: fa7da722-8748-4060-7e7d-08d9f14046c5
x-ms-traffictypediagnostic: DM5PR03MB2844:EE_
x-microsoft-antispam-prvs: <DM5PR03MB2844231D9E395A1B970DBF8E99359@DM5PR03MB2844.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8882;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: WTYGieBwt3tC+rjg/P1dFy3o5+GkoP5QOaz9MLPZC6PPPbNzyopOGjv9wd/WOeB4ceO36qILaQoq4UjZWDgod1WLtry28IWK8rY1ILXVjfhNFlyPrqWucpF0Rk9L5BBPfoo3tCy9vGnPgWmq9ATXa2xaxSt+CQBRqdXQ9l2Sod5aZmo508vVgChobJCScxmQKPepDldvSfZh5/kFjD+3U3PN6+vazmB/S/PxiLJ/hRwpNAnFArefI19xC7NWEOXhCXPuZRLS7ts4mq2XStZvmZ6I1HQXAELf4Tog8GkY6EStvn5RmyRk13VIeHBjwO8gb8q92hN4WkVLahl2cA0WsC3YI2pN3RUgej1CRqSt/Ky+693+oVhtl48p+UahoJ/FQq7lrvryH3+gPSw0kHr64FpzYVdjKu+sgGzzyhGmo+9/QTPw2a+o+TC2bpcAhnjthwRWSVMg8e/EPTQ9Iptio4uZFQtVXv/DpVQGJjSzA2BVT6EZ2kGgd6OAGKoIwvWGyZuGGsH45icl0IwzR6Ezyykv7hehfKtVdlCZ8IUOX6phu+6VQNES6G9fF6yFdNOOShNdzVjZE0GdLTEkG7zND7P3EsDZ74OPEDPxYCawjoMRmVtIseMUUDGrIN2ny4ZAJdFqdP2uekSFs0ftGiIjRMtMNPlPDZvFDygRQfAbc9TDVkjV9D+WxOpBjlS9wM1SSKvNAA1y9ki9UQnYfRi25SfF1ESPNfDn59ZGIBovZuaZFQQb10Y1pZlv0uuLcWis
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR03MB5665.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(33656002)(86362001)(2616005)(2906002)(5660300002)(186003)(38100700002)(8936002)(66476007)(76116006)(66446008)(66946007)(53546011)(66556008)(8676002)(26005)(4326008)(122000001)(64756008)(82960400001)(316002)(38070700005)(36756003)(71200400001)(54906003)(6916009)(99936003)(508600001)(91956017)(6512007)(83380400001)(6506007)(6486002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?OVJKYjg3aDNFTWxrZFZ5dnFVY1pTWDE4UkxTQWJKV0tWcERoRUV0cGtKMjJj?=
 =?utf-8?B?WGpJZW9udXJMeDVRRWJ3K2k3TEllQVBQZzVlMXJTR29SUlVLam16THpGU0Zw?=
 =?utf-8?B?c2x4MytpaW0vRHZFYXBCckQ2bzJrTmx1bDFvL2VZNUFDYm51Y3dHRHdTU1VS?=
 =?utf-8?B?S3hNRENkRit1eFg4a2hpMW13L2pnV0VIZUdIRW1QWWRmK3NhOFY1YVg0NXla?=
 =?utf-8?B?cm5HZHptaWNCSGg0ZGZnc29MQnFob0NsTTdwK3FPTlJYaGRESGxaUGtpdnNT?=
 =?utf-8?B?c1Z0VS92WGpDSnRVd0lmOGhqWWpHSGRFdXZIdVNVNkw4c0RmRk1aRE5wbmVK?=
 =?utf-8?B?cTJmcEdJOWdDcHhvMVlmSURJVWlyempqNWhtMUl1SVpJbEFKMldKOEtlRDNM?=
 =?utf-8?B?T1pyQXEzUkErNG51UDJ2KzBQamMyYTB5a3RHbGUrQ2x5UTBtRzBqVTdtVVM0?=
 =?utf-8?B?V1JrRVBuam16UTJPU2gvVU9kNW1yUWVid2lxOFRmT3M2N010V2hRR2dzYldZ?=
 =?utf-8?B?VmwxUWQ0TURFa2J3b2kybXJpK3pveERGNkF5V2tUNXpjc0t1QTFmbWpLRHZx?=
 =?utf-8?B?TEtFLzU4TjVFWkY2U0pTMHRTRDNaUmtGQ3I0SWdsOExWd3hVOUlvMEx5UHds?=
 =?utf-8?B?R0JwY3R4cXBMWkswTzZCeUczeENzbkk0RU0rUzVRTmpWcW5SNURudzlNVXVw?=
 =?utf-8?B?M0kwZDdKeXBNMTFlNWhDdXZQQi96L3E1blRpQXRRd1dPdHBuMWVleFhvWldV?=
 =?utf-8?B?VXJyTVNyVktxRWc4aFB1d1JOSG91Qk5lMG10U1RsdUtVWGw0MDlCOXlYRUlR?=
 =?utf-8?B?RklJL1JMWnpqamo1cWZnR2RESityL1NrbWU2elRHblZuNFpxbHpZSmlqS1Vu?=
 =?utf-8?B?dE5sVGFubVJsQnYxdnJxNy9aK1gyZVhGcGFENmp3N1VoVmVlOGV6bGUwUVRa?=
 =?utf-8?B?Y21SSmxZRlFPTHNMRFZscG9xN1VGd3J5cThjcmhCWVVJck1KMnFoWXg4VW5t?=
 =?utf-8?B?Z0dYRFBTYU52cGR6aUFnK3ZPNFdyRnQ2M3FmL3FSM1FmejF2Wk1EaTF3MC91?=
 =?utf-8?B?WlZYbmtlNjB3d2Y0cTcxUTZ5V2lrQzRoemJLTkRNRmtHT2lwbWVQVGtwQTdk?=
 =?utf-8?B?a0ZzL3J0UFFSUWNqaTdaNEVnK1lrN0JMdkFiZXNFRWMxRjV1bjNRcDY0UnNk?=
 =?utf-8?B?c0trRUtBbXRCMmVsK29ndm1RRjJ1WjZ0WVFUanFlei9pRVlUM3g5RlFPOUdI?=
 =?utf-8?B?by9lVXNla1h6RkIxZ21QdG5LT1dJSVk0VXV5SzFNNFZPRnNLaHI2RFBaUGpn?=
 =?utf-8?B?VTVzc2pZcXcvUTcxaEhad09IRHRLbUN1OVlKOU9QamdkT2prN2E1Nk45K2lU?=
 =?utf-8?B?czdyTGcwVCttM1R0azQ3aVBuaDhxZW13SGN5dlBkMHJKNnZ5dG9zVWtuT1lY?=
 =?utf-8?B?Tlp5eTk2cUQzNDVWQlI3RWxBTzJRNWcvK0RYM1RwY1JLVWFnK0FDMWZEV2pX?=
 =?utf-8?B?MVg2bTZDeEVtL24vNkJaTENKRFBhbHNHSk1oSVlSTnlFUndKeHZOVXZOeVo2?=
 =?utf-8?B?eStRc29oRnRzWTA4a09UZ3ErM3cvbTFNeEpVMDBWMytmQzVCSmpuK2NQTTI4?=
 =?utf-8?B?RSt5dklkekFuTWMxQVBndkpUQUhxT3Y4UWM3R0JqRnVOTmYySUJkUWNFc0sw?=
 =?utf-8?B?dkNlYlppZFNJZlhjNDEyaU5ZelhrWUhuNWRabVhDb3NBcS9TanF5RXpkU2E2?=
 =?utf-8?B?SWhpb1lxZERrY3YvMFkySWUrcnQ3NnZwTlVJanIweS9TN1gxdEtib3hIeVAr?=
 =?utf-8?B?RERTM3J3eGFWS3JITUFsU1RBTVhZaUZnNU1DRUFWWEIxVi9YUExwMm81Y0o0?=
 =?utf-8?B?Y3FaREJjMFZ1NXJqbzRjY0xHa0VNdjFGYlhXeTBWaVRsd1NpaGtBQ01zcEFu?=
 =?utf-8?B?TEhGbkhPUENuYmFFWlVERWpJY0xDVERUQlBmT1JHZ2VUSmVySkErZWpVNnFK?=
 =?utf-8?B?OUlKL1pUZis0U1BhVVQ3RThmRlFiQ1AwKzNPU1ljbFNWam05Z3F2UlRpTWgz?=
 =?utf-8?B?UThaV0FSS1BJOFRIOXhBRDVrVGV6dUpHTVlGaXU3dDhqaGcwNFU3MTl1dHlr?=
 =?utf-8?B?VVNOTFhSYzV2UHVocDl5TXJVa1F0Y1ByaW50MkZHUDFFaUl2QUtVK2h1OWtw?=
 =?utf-8?B?MTM5YkwrNm54SFJ3Z2JYWjZWVWcwK1A1cityQXBJNEJMenRWN2NZcTZOaEpQ?=
 =?utf-8?Q?m5UFQHEKz84umVDvknXSEvhX6S3FznyRNGX4wmWo28=3D?=
Content-Type: multipart/signed;
	boundary="Apple-Mail=_3FE077EC-1DEC-4920-984F-0BE79200A195";
	protocol="application/pgp-signature";
	micalg=pgp-sha512
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO1PR03MB5665.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fa7da722-8748-4060-7e7d-08d9f14046c5
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Feb 2022 11:34:21.6403
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: dJBR/2ofJlin77ViLCmLMwaNskiO39DZORPSYXBaXDMeXMUrfbhwyQCNfrqB8zcXztw7qWw7rSbq2eIrkSlenuzCfShEynlMyq2U7x8AoI8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2844
X-OriginatorOrg: citrix.com

--Apple-Mail=_3FE077EC-1DEC-4920-984F-0BE79200A195
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8



> On Feb 16, 2022, at 9:31 AM, Jan Beulich <jbeulich@suse.com> wrote:
>=20
> On 16.02.2022 10:25, Bertrand Marquis wrote:
>> Hi Jan, Julien,
>>=20
>>> On 15 Feb 2022, at 21:00, Julien Grall <julien@xen.org> wrote:
>>>=20
>>> (+ Bertrand)
>>>=20
>>> Hi Jan,
>>>=20
>>> On 27/01/2022 14:34, Jan Beulich wrote:
>>>> The increasing amount of constructs along the lines of
>>>>    if ( !condition )
>>>>    {
>>>>        ASSERT_UNREACHABLE();
>>>>        return;
>>>>    }
>>>> is not only longer than necessary, but also doesn't produce =
incident
>>>> specific console output (except for file name and line number).
>>>=20
>>> So I agree that this construct will always result to a minimum 5 =
lines. Which is not nice. But the proposed change is...
>>>=20
>>>> Allow
>>>> the intended effect to be achieved with ASSERT(), by giving it a =
second
>>>> parameter allowing specification of the action to take in release =
builds
>>>> in case an assertion would have triggered in a debug one. The =
example
>>>> above then becomes
>>>>    ASSERT(condition, return);
>>>> Make sure the condition will continue to not get evaluated when =
just a
>>>> single argument gets passed to ASSERT().
>>>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>>>> ---
>>>> v2: Rename new macro parameter.
>>>> ---
>>>> RFC: The use of a control flow construct as a macro argument may be
>>>>     controversial.
>>>=20
>>> indeed controversial. I find this quite confusing and not something =
I would request a user to switch to if they use the longer version.
>>>=20
>>> That said, this is mainly a matter of taste. So I am interested to =
hear others view.
>>>=20
>>> I have also CCed Bertrand to have an opinions from the Fusa Group (I =
suspect this will go backward for them).
>>=20
>> Thanks and here is my feedback in regards to Fusa here.
>>=20
>> Most certification standards are forbidding completely macros =
including
>> conditions (and quite a number are forbidding static inline with =
conditions).
>> The main reason for that is MCDC coverage (condition/decisions and =
not only
>> code line) is not possible to do anymore down to the source code and =
has to be
>> done down to the pre-processed code.
>>=20
>> Out of Fusa considerations, one thing I do not like in this solution =
is the fact that
>> you put some code as parameter of the macro (the return).
>>=20
>> To make this a bit better you could put the return code as parameter
>> instead of having =E2=80=9Creturn CODE=E2=80=9D as parameter.
>=20
> Except that it's not always "return" what you want, and hence it
> can't be made implicit.
>=20
>> An other thing is that Xen ASSERT after this change will be quite =
different from
>> any ASSERT found in other projects which could make it misleading for =
developers.
>> Maybe we could introduce an ASSERT_RETURN macros instead of modifying =
the
>> behaviour of the standard ASSERT ?
>=20
> Along the lines of the above, this would then mean a multitude of
> new macros.

Out of curiosity, what kinds of other actions?

I am opposed to overloading =E2=80=9CASSERT=E2=80=9D for this new kind =
of macro; I think it would not only be unnecessarily confusing to people =
not familiar with our codebase, but it would be too easy for people to =
fail to notice which macro was being used.

ASSERT_ACTION(condition, code) (or even ASSERT_OR_ACTION()) would be a =
bare minimum for me.

But I can=E2=80=99t imagine that there are more than a handful of =
actions we might want to take, so defining a macro for each one =
shouldn=E2=80=99t be too burdensome.

Furthermore, the very flexibility seems dangerous; you=E2=80=99re not =
seeing what actual code is generated, so it=E2=80=99s to easy to be =
=E2=80=9Cclever=E2=80=9D, and/or write code that ends up doing something =
different than you expect.

At the moment I think ASSERT_OR_RETURN(condition, code), plus other new =
macros for the other behavior is needed, would be better.

 -George

--Apple-Mail=_3FE077EC-1DEC-4920-984F-0BE79200A195
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="signature.asc"
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEj3+7SZ4EDefWZFyCshXHp8eEG+0FAmIM4TMACgkQshXHp8eE
G+0k9QgAsdq0w65/AV3KvuNEAZvzBcqmhqfnLDDDwkIy4gtCs1gs/X1+0WC/XIqE
r7xO8wxq+X6zN/GdxEod2CO3q3ZU3rRhbZ9za8zk1EBhKg7A3UCxHOtUbhxnlP+T
3Gr0scEEQKETcLPKdFrBBIhkUC33ACFrfRq/vyXnyqB3J+puMMy3IscGpzpJOAIm
kxAxAJbksKi5xczYsL1Qdx0wN9Md9GD29+bD5LA7imysk3iJUBGuCMNsc6Gkqzit
BERt4M26PlDzqZ2nSq2DmxFLPLUwmyylwc+q4/EdDtXTZw8YhTg5hEuIHRy54xKr
fmlZkM1yLki2zOzCsRYI1PIM8olcrA==
=DaMX
-----END PGP SIGNATURE-----

--Apple-Mail=_3FE077EC-1DEC-4920-984F-0BE79200A195--


From xen-devel-bounces@lists.xenproject.org Wed Feb 16 11:43:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 11:43:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274032.469359 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKIhz-0003Mo-La; Wed, 16 Feb 2022 11:42:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274032.469359; Wed, 16 Feb 2022 11:42:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKIhz-0003Mh-IP; Wed, 16 Feb 2022 11:42:55 +0000
Received: by outflank-mailman (input) for mailman id 274032;
 Wed, 16 Feb 2022 11:42:53 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Gpsw=S7=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nKIhx-0003Mb-P6
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 11:42:53 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 92cd497b-8f1d-11ec-8eb8-a37418f5ba1a;
 Wed, 16 Feb 2022 12:42:52 +0100 (CET)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2112.outbound.protection.outlook.com [104.47.17.112]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-23-j3hCXq8KPpmNDlRTdBzHKg-1; Wed, 16 Feb 2022 12:42:50 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by PAXPR04MB9024.eurprd04.prod.outlook.com (2603:10a6:102:20f::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.16; Wed, 16 Feb
 2022 11:42:48 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4995.016; Wed, 16 Feb 2022
 11:42:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 92cd497b-8f1d-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645011772;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=paM1O+oFH4o8DIi1l7sLnizyNmttJIjGyTJyQ4gN3vE=;
	b=JAvMwrmJQhHO2WkAhmJwRNZ5eB6vc5EAqo06+JJTwLTtN/aYBsartSqBQNCZXkrCMwIdLT
	IntOdT32tLNlPVHylp6OGGlc0Muypw1qcb5hqGFmPAYPn2cQ5vJ23fkD0Sk6jW6fPyK136
	4ytydU+qAGMB2KNmyvaOXeUnKgTu3TM=
X-MC-Unique: j3hCXq8KPpmNDlRTdBzHKg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=HICFJDiQmKzrOZF3k4z0x6n8Q6qg9MgNDoUWpMEax6pekU9gcmbiNUhEaj7d4dwfV1dvvO6xP7Y2T01vrvadB7muRiAc8g6JX89JrMGYblXgbFNBR61nYnwvSh3q2evJ83hTPwQ0R/GV4a7QPdRhHNiEJ4iXk+PvExZa1A3hb9hS4rEMlyl26KoMoPtOtBJuQZFexaaGF1RRxi8hzqsuOwBN5cnOemxviDJB3Sei3godu8b9pjf/VXKu7xy9vrlMtqvYNK/6AJQbalBbHHK0XXs9J4+5d7QX2QqASScBQ4bQ4sbKEAT2fx++w/OOBP78ZQ6weRhzx9mrWnPIwaZr2A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=VyqF8PMq7Q7m6HjUTswowbWrBd6wMsRN8YiSyq/GMbM=;
 b=PrI7s0ZwJQk24i+NHqiZYslVYZ//m/3F/chVpsQjaqkm/QyjlFc6jOjCQ0PnwGSO0xNYwbIE6ql+HTu1jMaluz82QDBOmZyMaYfybZ9aC+YB54tk74jPiUrPwgDf94q0kX9BXjuZJ1JiR4ywbvf1gQHXBpwDzJSpd7iAEh+bJMXQed5w3AbMYRiTQVgMUVKhiawlG07qz/P7lMb/F/m0cyuXrcwcbgQ5lfsCZ12FIw/Y7rGMa9sUcJib4XmpqPS/+EuluPPGwdVoWcWHXCIXcU4KLJQsOmUKhRt9cj0lkOlvlfrnNrB2qvfLAVBq193+w13xx/7MZKD2jR1DGCnrbw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <732e8e39-36c4-1651-61f3-9b55caf29fe8@suse.com>
Date: Wed, 16 Feb 2022 12:42:45 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v2] lib: extend ASSERT()
Content-Language: en-US
To: George Dunlap <George.Dunlap@citrix.com>
CC: Bertrand Marquis <Bertrand.Marquis@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <Andrew.Cooper3@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Roger Pau Monne <roger.pau@citrix.com>, Julien Grall <julien@xen.org>
References: <75125344-b0e1-9663-4c1a-84bb35870fef@suse.com>
 <35d82770-66cf-e030-5bcc-3c030e4463d7@xen.org>
 <3F58400B-5151-42F2-8F39-109DDF50EE1E@arm.com>
 <a89223c8-f59a-24cc-96a7-e40feb28813f@suse.com>
 <DB014136-7797-4A61-9681-33A7D85403AA@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <DB014136-7797-4A61-9681-33A7D85403AA@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6P192CA0071.EURP192.PROD.OUTLOOK.COM
 (2603:10a6:209:82::48) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: bc494861-6116-4715-1a69-08d9f141743d
X-MS-TrafficTypeDiagnostic: PAXPR04MB9024:EE_
X-Microsoft-Antispam-PRVS:
	<PAXPR04MB90243002FE14F706D8D1E2F1B3359@PAXPR04MB9024.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	eJexgEAbGFca6vC7oX77STABPR1mhoNagKuu0hnAE7LyDrCsZ/51gxN3KcaZYqXfTVxrpkbHcah1p/KaMVULdf4PFt9Yh/aWmkw5z4ezl+kfHkfjb3rRzn47Fikl7RVGrJ+Ux7xkkIuQliB7a52z5nrvvlQ+mU76aUI/txnqtjKq+TLT8Ry66zrsTtB+KlhQaMRSaDusibh0zE3Ji9mEY4xkEu2v6NNEqcGIZXPpcNiHX2mbD3BsTSOKL0uBEVuWZ33q/5dnrwvZfe0JzFmVo67yUoXWIObvjjgwY7yB52GJ0pysP/LfT6RduDIRdGJQX3UomFbNiEXqnDaiFhB9/CqeHBTQkDXFcJQUXRRSVW044F7oPxBwg0E80H96RPK1YomHc7NqzjsPaEhsg2hB797E48/se7KidMa1Yc7Z9WnPTvE5uGe4kmXUyclJnO0Cr7CHBOPs54mFLdoidXYHH3eF9NDmgvWiYyhxAuBgVqegMScP+csiKEIFFn1lrbCkAnxzSSaDRfu+ZOjeN0QFH55Fv9WPiDxnIazfpWRwVFttAwpdxPDMHpuL0/LWjrWKHlPMOej72w8nsh6rXd5uINDAWTnH0GKuftXbLxDcY0Q6mW4lgQycy/bzb/bsUKd9NOpCbwPl4mxJrwbRRHB7zcXPnrM6celMaHzxNhKWe2IzLaLutrjOtw0cO2L9N5tpC7wceoIcDBv7qcnPR35DDBp4A8XjHe4EKNNdwavvbI8=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(83380400001)(26005)(38100700002)(186003)(36756003)(2906002)(31686004)(5660300002)(54906003)(8936002)(6506007)(316002)(66946007)(6666004)(66556008)(66476007)(6916009)(86362001)(31696002)(2616005)(8676002)(6512007)(4326008)(508600001)(6486002)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?8QSw07O0sX+rN+OUTcl08Xnxvfc8ck0i/UFz72ge6jaeJmWEXVt3/CXB57ZK?=
 =?us-ascii?Q?J5+jYtZ7Q8nijTo8+9jn1yjrQtlkbMlNf4SVCm26nmWILHhhiJO2qJTArri1?=
 =?us-ascii?Q?ivKcKRim5yYamveM/5rb4v6shqzQzXDXKw1f583quDEMd64vrVJNWtCeWgpo?=
 =?us-ascii?Q?qQSk+04OPzPWI+ia+MskmAYp+T8IvM8a9wLJkmIsj9No6STegQKbFR2f2wJd?=
 =?us-ascii?Q?GcvUmk5aZfGmKzISex4MaIa0hgOfQ+MLFaxcIu+Mwvg4bfTs5VpM5hc3EG+m?=
 =?us-ascii?Q?d8q3U7+FOPor8cLxVUrwiSS2uNb5R3D6UVpuu4QF6S2x0vTJPdk8EdctfXiv?=
 =?us-ascii?Q?L+kzQi99c6hMvcPQrAorP/100MPJkfhf1hmYt0G02PR7vAMUX5GWyhabdi4N?=
 =?us-ascii?Q?1jdJS8L5U/MBAvXroS81HzXSeEOC63okAEWxGuvA4xAyXNPudVcnxOr3+J7n?=
 =?us-ascii?Q?tDSTJ8mFbQFjLN9SqX4Y5rVkpe5ztNPM9tXPMivMD5rc1qqTiGFROpxZl6FK?=
 =?us-ascii?Q?3G2LZKlBfB3/HtbDmvl96KY4WY1EpamOj03lSddJOj7dhAvfSmnyRW/kyRBq?=
 =?us-ascii?Q?x7h0QrqOEp6E4I8bd+RLitq2pG4JefgwSgyq9AG8Db84aZYYp8asL0+nBIBn?=
 =?us-ascii?Q?piM4uMTWJtheOms55/MkJgsJQmN7m7TqWLzbF1+Ya9o0/PUv8rzBjDqiMhxp?=
 =?us-ascii?Q?q49L5DSrlXalOoba7d+cVFWYvbBrcRQ3peI6y5Yph6jbvA6sy9NCNdu1pwaW?=
 =?us-ascii?Q?dhHHbfFo8/eIZqpK5BdpbLVRjKc0LuhSWP+RGYUvIyl3OBR4jHCFx3EYSPvc?=
 =?us-ascii?Q?gbDAd353LcftrydbJmVUcA3QMm/OIvKd6GXhDoU9qiH1/B9JsRLfBV3B5j4V?=
 =?us-ascii?Q?KyjceGDbKMtbfIeVx5ARoJ9YqZKB4Vlyzsp/ufqsr6z4wnYhWENUBtHnQQVw?=
 =?us-ascii?Q?75hqb37DJoHu0yObv8fdxt1SgWMFm+nWPUlD1h864leRuzOUCZetUrNGH8vs?=
 =?us-ascii?Q?ll2Hfj5886WzCCWn4wpZWSMpnnRXtodFWPNr4EDhCWqnodDETiV2t8xMlqwA?=
 =?us-ascii?Q?JIbOAb/BDEnu+GJO9Wgjjqk7Y6wWv8UHHD//6RIfqWw4wi8Vx3o3d87jqGMW?=
 =?us-ascii?Q?CUBh5Aj84bg3WJ/dnEwXMc2uQrsIp4n42uwRRkmUl5H9uH7znwPBT6OFLoh7?=
 =?us-ascii?Q?i10WXjrgVIHtLbver76wQdkGsYp5CgBeTgkXK0YdEXkGRnzRfDZpeTMtNWhC?=
 =?us-ascii?Q?gSNGh5eGV5+K+T/ohu7YTZ3C6ibfEXJqKx48U7Rn/0tzg7h4gMBv77Y9ME5/?=
 =?us-ascii?Q?M32bafnIdyS8GaEVFVvMW5h9F+hPlK4mYzDG7q0193rJGtMAOqcBi3mZ7HdV?=
 =?us-ascii?Q?67YCB/+VP7ekU8t3N6QriWDaHRfgOstUKrNxNzew+pSc+wAsKoo43zIwKFzu?=
 =?us-ascii?Q?OuHKMlz8uhtoWGce9V6wy6IFkUp8MPwI5a+xHXYEvqsmZOhug5TkfrGxOXv+?=
 =?us-ascii?Q?pB4BA76QO2WrZpPLJDUkMLJX+HxXxMbACsZRqUCDXRPRL11ht/1s394YP0aU?=
 =?us-ascii?Q?t+y0vtTNmKpHBoRJ1qIjsyPKBDt69HoG6IpQj1XQltjWnCPkaywXK1vJvLwF?=
 =?us-ascii?Q?vBoZzC9/3GAGT7d6hCT2+ts=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bc494861-6116-4715-1a69-08d9f141743d
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2022 11:42:47.7777
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: C/lPmSyQX8b9EDbXORREIr0bjq/vbzFJE0OqCgv/pN/NyaShAMqJr4fUOSgtnFX2dYyM/a3IfMqqv3L3nroFPQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9024

On 16.02.2022 12:34, George Dunlap wrote:
>> On Feb 16, 2022, at 9:31 AM, Jan Beulich <jbeulich@suse.com> wrote:
>> On 16.02.2022 10:25, Bertrand Marquis wrote:
>>>> On 15 Feb 2022, at 21:00, Julien Grall <julien@xen.org> wrote:
>>>> On 27/01/2022 14:34, Jan Beulich wrote:
>>>>> The increasing amount of constructs along the lines of
>>>>>    if ( !condition )
>>>>>    {
>>>>>        ASSERT_UNREACHABLE();
>>>>>        return;
>>>>>    }
>>>>> is not only longer than necessary, but also doesn't produce incident
>>>>> specific console output (except for file name and line number).
>>>>
>>>> So I agree that this construct will always result to a minimum 5 lines=
. Which is not nice. But the proposed change is...
>>>>
>>>>> Allow
>>>>> the intended effect to be achieved with ASSERT(), by giving it a seco=
nd
>>>>> parameter allowing specification of the action to take in release bui=
lds
>>>>> in case an assertion would have triggered in a debug one. The example
>>>>> above then becomes
>>>>>    ASSERT(condition, return);
>>>>> Make sure the condition will continue to not get evaluated when just =
a
>>>>> single argument gets passed to ASSERT().
>>>>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>>>>> ---
>>>>> v2: Rename new macro parameter.
>>>>> ---
>>>>> RFC: The use of a control flow construct as a macro argument may be
>>>>>     controversial.
>>>>
>>>> indeed controversial. I find this quite confusing and not something I =
would request a user to switch to if they use the longer version.
>>>>
>>>> That said, this is mainly a matter of taste. So I am interested to hea=
r others view.
>>>>
>>>> I have also CCed Bertrand to have an opinions from the Fusa Group (I s=
uspect this will go backward for them).
>>>
>>> Thanks and here is my feedback in regards to Fusa here.
>>>
>>> Most certification standards are forbidding completely macros including
>>> conditions (and quite a number are forbidding static inline with condit=
ions).
>>> The main reason for that is MCDC coverage (condition/decisions and not =
only
>>> code line) is not possible to do anymore down to the source code and ha=
s to be
>>> done down to the pre-processed code.
>>>
>>> Out of Fusa considerations, one thing I do not like in this solution is=
 the fact that
>>> you put some code as parameter of the macro (the return).
>>>
>>> To make this a bit better you could put the return code as parameter
>>> instead of having =E2=80=9Creturn CODE=E2=80=9D as parameter.
>>
>> Except that it's not always "return" what you want, and hence it
>> can't be made implicit.
>>
>>> An other thing is that Xen ASSERT after this change will be quite diffe=
rent from
>>> any ASSERT found in other projects which could make it misleading for d=
evelopers.
>>> Maybe we could introduce an ASSERT_RETURN macros instead of modifying t=
he
>>> behaviour of the standard ASSERT ?
>>
>> Along the lines of the above, this would then mean a multitude of
>> new macros.
>=20
> Out of curiosity, what kinds of other actions?

continue, break, assignments of e.g. error codes, just to name a
few immediately obvious ones.

> I am opposed to overloading =E2=80=9CASSERT=E2=80=9D for this new kind of=
 macro; I think it would not only be unnecessarily confusing to people not =
familiar with our codebase, but it would be too easy for people to fail to =
notice which macro was being used.
>=20
> ASSERT_ACTION(condition, code) (or even ASSERT_OR_ACTION()) would be a ba=
re minimum for me.
>=20
> But I can=E2=80=99t imagine that there are more than a handful of actions=
 we might want to take, so defining a macro for each one shouldn=E2=80=99t =
be too burdensome.
>=20
> Furthermore, the very flexibility seems dangerous; you=E2=80=99re not see=
ing what actual code is generated, so it=E2=80=99s to easy to be =E2=80=9Cc=
lever=E2=80=9D, and/or write code that ends up doing something different th=
an you expect.
>=20
> At the moment I think ASSERT_OR_RETURN(condition, code), plus other new m=
acros for the other behavior is needed, would be better.

Hmm, while I see your point of things possibly looking confusing or
unexpected, something like ASSERT_OR_RETURN() (shouldn't it be
ASSERT_AND_RETURN()?) is imo less readable. In particular I dislike
the larger amount of uppercase text. But yes, I could accept this
as a compromise as it still seems better to me than the multi-line
constructs we currently use.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Feb 16 11:46:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 11:46:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274039.469371 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKIl4-00042M-6b; Wed, 16 Feb 2022 11:46:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274039.469371; Wed, 16 Feb 2022 11:46:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKIl4-00042F-1S; Wed, 16 Feb 2022 11:46:06 +0000
Received: by outflank-mailman (input) for mailman id 274039;
 Wed, 16 Feb 2022 11:46:05 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nKIl3-000427-B9
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 11:46:05 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nKIl2-0006in-Db; Wed, 16 Feb 2022 11:46:04 +0000
Received: from 54-240-197-235.amazon.com ([54.240.197.235]
 helo=[192.168.30.223]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nKIl2-0006OZ-73; Wed, 16 Feb 2022 11:46:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=7h/sHj+EdCh/XC90cUNXekG2JrGuF0kkYxv0quBeevA=; b=QVPaBh+ox+D7UEA7KDR+5pcO4J
	5V1q4CU0pTLBMh8Sks7LZYWNHXGJEEHLqcUpAzAbUV7acRB4zXdTUJdurYzFf5gxpG4pq/kUAuPyG
	PqXvhKIvG0OHvgrNkF7Q0/F0ZJy7w/MCQrIb4HK0reQ919VkY3rvFTg2jVsQuNCrqxBs=;
Message-ID: <f5d6de10-5d3c-f86e-71eb-203dd06b6a11@xen.org>
Date: Wed, 16 Feb 2022 11:46:01 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.0
Subject: Re: [PATCH v2 02/70] xen/sort: Switch to an extern inline
 implementation
To: Andrew Cooper <Andrew.Cooper3@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
 Jan Beulich <JBeulich@suse.com>, Roger Pau Monne <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
 <20220214125127.17985-3-andrew.cooper3@citrix.com>
 <70824a0c-cc48-b064-695c-35c2d06c0ad1@xen.org>
 <alpine.DEB.2.22.394.2202151800230.43738@ubuntu-linux-20-04-desktop>
 <faa6c523-6e88-8987-c0c9-3652c002fda3@citrix.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <faa6c523-6e88-8987-c0c9-3652c002fda3@citrix.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi,

On 16/02/2022 10:44, Andrew Cooper wrote:
> On 16/02/2022 03:46, Stefano Stabellini wrote:
>> On Mon, 14 Feb 2022, Julien Grall wrote:
>>> On 14/02/2022 12:50, Andrew Cooper wrote:
>>>> There are exactly 3 callers of sort() in the hypervisor.  Callbacks in a
>>>> tight
>>>> loop like this are problematic for performance, especially with Spectre v2
>>>> protections, which is why extern inline is used commonly by libraries.
>>>>
>>>> Both ARM callers pass in NULL for the swap function, and while this might
>>>> seem
>>>> like an attractive option at first, it causes generic_swap() to be used,
>>>> which
>>>> forced a byte-wise copy.  Provide real swap functions so the compiler can
>>>> optimise properly, which is very important for ARM downstreams where
>>>> milliseconds until the system is up matters.
>>> Did you actually benchmark it? Both those lists will have < 128 elements in
>>> them. So I would be extremely surprised if you save more than a few hundreds
>>> microseconds with this approach.
>>>
>>> So, my opinion on this approach hasn't changed. On v1, we discussed an
>>> approach that would suit both Stefano and I. Jan seemed to confirm that would
>>> also suit x86.
>> This patch series has become 70 patches and for the sake of helping
>> Andrew move forward in the quickest and most painless way possible, I
>> append the following using generic_swap as static inline.
>>
>> Julien, Bertrand, is that acceptable to you?
>>
>> Andrew, I know this is not your favorite approach but you have quite a
>> lot of changes to handle -- probably not worth focussing on one detail
>> which is pretty minor?
> 
> It's not pretty minor.  My version really is the best thing for ARM.
 >
> The perf improvement alone, marginal as it may be in practice, is

Our take on Arm has always been to avoid micro-optimization when the 
resulting code is more difficult to maintain.

> justification alone for the patch, and Bertrand's R-by is testament to this.

I am not sure why calling out that Bertrand agreed means that everyone 
else should accept your approach.

This reminds me other series that have been blocked for a long time by 
you. Yet you made no effort to compromise... How ironic.

> 
> But the reasons why getting rid the swap functions is important for
> CET-IBT on x86 are exactly the same as why getting rid of them on ARM
> will be important for BTI support.  A tagged function doing an arbitrary
> bytewise swap from two parameters controlled by the third is far more
> valuable to an attackers gadget library than a typical function.

This is a more compelling reason. However, I am a bit puzzled why it 
took you so long to come up with this reason.

> i.e. this proposed intermediary, if it compiles, is just busywork which
> someone else is going to have to revert in the future, along with having
> this argument again.

Well, this argument would have never happened if your commit message 
contained information about BTI.

Instead you decided to just mention the performance part despite me 
objecting it and requesting for a different reason in v1 (see [1]).

Anyway, I will wait for a reword of the commit message before lifting my 
Nacked-by.

Cheers,

[1] 
https://lore.kernel.org/xen-devel/f7bb7a08-4721-f2a8-8602-0cd1baf1f083@xen.org/

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Feb 16 11:46:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 11:46:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274044.469381 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKIlk-0004bd-EE; Wed, 16 Feb 2022 11:46:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274044.469381; Wed, 16 Feb 2022 11:46:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKIlk-0004bW-Ap; Wed, 16 Feb 2022 11:46:48 +0000
Received: by outflank-mailman (input) for mailman id 274044;
 Wed, 16 Feb 2022 11:46:47 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nKIlj-0004bF-CL; Wed, 16 Feb 2022 11:46:47 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nKIlj-0006jT-Ah; Wed, 16 Feb 2022 11:46:47 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nKIli-00009m-TU; Wed, 16 Feb 2022 11:46:46 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nKIli-0001A3-T4; Wed, 16 Feb 2022 11:46:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=7Ms48RfWmL8GIzt9wUrvkx/rcZQaRiVy0RmnP/zAgrk=; b=xcEzAtzih/jUKi5x2V6Q14VINl
	D+Fb1NbS5szofpqnLXJxIwcsfnulxEEzTT1z7GiUvcXlhdgcC5kCrr+tzUX/0O6itMfbaR9wbh/re
	sNuNcNYog1pctgk6/TE6xq84MqbRD5XQJcTcTObH9iNQ4BbKSsKnYTQ7fNoXWxW5US98=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168127-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 168127: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=c28e376edc46e6db6e4a551c94b6ac90df0d8d6e
X-Osstest-Versions-That:
    ovmf=85589ddbf6f8c6dc75f73aa32e484e3cfd439e7a
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 16 Feb 2022 11:46:46 +0000

flight 168127 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168127/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 c28e376edc46e6db6e4a551c94b6ac90df0d8d6e
baseline version:
 ovmf                 85589ddbf6f8c6dc75f73aa32e484e3cfd439e7a

Last test of basis   168119  2022-02-15 10:43:01 Z    1 days
Testing same since   168127  2022-02-16 07:13:58 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Brijesh Singh <brijesh.singh@amd.com>
  dann frazier <dann.frazier@canonical.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   85589ddbf6..c28e376edc  c28e376edc46e6db6e4a551c94b6ac90df0d8d6e -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Wed Feb 16 11:55:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 11:55:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274057.469392 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKItv-0006B7-B7; Wed, 16 Feb 2022 11:55:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274057.469392; Wed, 16 Feb 2022 11:55:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKItv-0006B0-7I; Wed, 16 Feb 2022 11:55:15 +0000
Received: by outflank-mailman (input) for mailman id 274057;
 Wed, 16 Feb 2022 11:55:14 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=6VyC=S7=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nKItu-0006Au-75
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 11:55:14 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4b0ae905-8f1f-11ec-8eb8-a37418f5ba1a;
 Wed, 16 Feb 2022 12:55:12 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4b0ae905-8f1f-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645012512;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=w1AMShmSEkasRrcVpUKRpw8B41H7gKDFNFnrQyhxxKI=;
  b=HWJeNYw4UJ09Zkcr+3XpoZYlHgub/1fYBG9vj7182jMvibS9lcToDgjK
   2F3aoiqw2mf9qyM6KB1+PUlahmLC7kSoKo/8UVIxo1viQp5w1k8lzx5nc
   dGtbd3AZqjuueETXBOf/Fd6IQpUBlv7I6vBJqD3AVDT81g8ENf5wspMBc
   c=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: lGI3cgPPARmTI3qObh8kIQMC/bJn2to+LbxYw9eORy9tF1Vyfj3iAktGfzmsaAE20AVlrnQGj3
 hOG9Ji4uKIpPrtrCc41HwYnHSDGOawmcrJH+0oOCLHw82n3xrgYaLiIozFEFv/qNcSzQ3z8Bek
 RzfUI+I7ZSnv16XzVLbs05agtiBKlNqwawwCKGAXGuEr4siwCStXZBSYJSygAQZO12Bj/Rwc67
 vlEgXar4DX99m+WcGx4g+OcW00IXXTTPy+gAOsggKAbw1mEj6XFDz375yPFBU2BexUl0o4z5GJ
 YWOEruXNdj/MkuYXC7hQR1fs
X-SBRS: 5.1
X-MesageID: 64332123
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:/H0Gf6IbbCYFAwqrFE+RV5IlxSXFcZb7ZxGr2PjKsXjdYENShWQPn
 GsbWjiEbq2NMGrxKdwkb9jl/ExX7J7QnN8wHVRlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokcxIn5BC5C5xZVG/fjgqoHUVaiUakideSc+EH170Ug6xbZg6mJVqYPR7z2l6
 IuaT/L3YDdJ6xYsWo7Dw/vewP/HlK2aVAIw5jTSV9gS1LPtvyB94KYkDbOwNxPFrrx8RYZWc
 QphIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbrGvaUXe345iXMfwZ3u7hB2rwfF12
 vIVt6aNFyQJO/3Dg/02UR9xRnQW0a1uoNcrIFC6uM2XiUbHb2Ht07NlC0Re0Y8wo7gtRzsUr
 LpBdW5LPkvra+GemdpXTsFFgMg5IdatF4QYonx6lhnSDOo8QICFSKLPjTNd9Gls3ZsURKyFD
 yYfQRVuck7sRCJpA3IOK58PvuaC2mC8SwQN/Tp5ooJoujOOnWSdyoPFINfTP9CHW8hRtkKZv
 X7duXT0BAkAM96SwibD9Wij7sfKlDn+UZgfF5W58OBrm1yZwmEPCBwQWkC/qPP/gUm7M/pdI
 UEJ/islrYAp6VemCNL6WnWQqXuP70A0QMBbHas85R3l90bPy1/HXC5eFGcHMYF48p9tLdA36
 rOXt/G3JDh9l+WXc0/D1ZeR/TypIAMXK0ZXMEfoUjA5y9XkpYgyiDfGQdBiDLO5g7XJJN3g/
 9yZhHNg3utO1Kbnw43+pAma2Gz0+vAlWyZovl2/Y46z0u9uiGdJjaSM4EOT0/tPJZ3xorKp7
 CldwJj2AAzj4PiweM2xrAclQenBCxWtamS0bbtT838JrWnFF5mLJ9043d2GDB01WvvogBewC
 KMphStf5YVIIFyhZrJtboS6BqwClPa8SYW4D6qFP4sXOPCdkTNrGgk0OCZ8OEi3ziARfVwXY
 8/HIa5A815GYUiY8NZGb7hEiuJ6rszP7WjSWYr633yaPUm2PxaopUM+GALWNIgRtfrcyC2Mq
 oo3H5bamn13DbylCgGKoNF7ELz/BSVibXwAg5cMLbDrz8sPMDxJNsI9Npt7K9w/xPUKzL6Vl
 px/M2cBoGfCabT8AVziQlhoaa/1XIY5qnQ+PCc2Ok2v1WRlaoGqhJrzvbNuFVX+3OA8n/NyU
 dcffMCMXqZGRjjdomxPZpjhto1yMh+sgFvWbSaiZTE+eb9mRhDIpYC4Lle+qnFWA3rlr9Y6r
 p2hyhjfHcgJSTN9AZuEc/mo1V6w4yQQwbogQ0vSL9BPU0zw64w2eTfph/o6LphUexXOzzeXz
 SiMBhIcqbWfqoM56oCR16uFs52oA611GU8DRzvX6rO/NC/7+Gu/wNAfDLbULG6FDG6tofesf
 +RYyf34IcYrplcSvtouCatvwII/+8Dr++1QwDN7ESiZdF+sEL5hfCWLhJEdqq1Xy7ZFkgKqQ
 UbTqMJCMLCENc65Ql4cIA0pMraK2f0Ow2SA6P00JAPx5TNt/arBWkJXZkHehCtYJbpzEYUk3
 eZ+55JGt13h0kInYoSckyRZ12WQNXhRAawou6YTDJLvlgd2mEpJZobRC3Ou7ZyCAzmW3pLG/
 tNAaHL+uolh
IronPort-HdrOrdr: A9a23:kWhOcKDJ3VLKttLlHegKsceALOsnbusQ8zAXPh9KJyC9I/b2qy
 nxppgmPEfP+UossHFJo6HlBEEZKUmstKKdkrNhQotKOzOW+FdATbsSo7cKpgeAJ8SQzJ8k6U
 4NSdkdNDS0NykGsS+Y2nj6Lz9D+qj9zEnAv463pB0BLXAIV0gj1XYCNu/yKDwqeOAsP+tfKH
 Po3Ls/m9PWQwVwUi3UPAhhY8Hz4/nw0L72ax8PABAqrCOUiymz1bL8Gx+Emj8DTjJm294ZgC
 r4uj28wp/mn+Cwyxfa2WOWxY9RgsHdxtxKA9HJotQJKw/rlh2jaO1aKvi/VXEO0aWSAWQR4Z
 /xSiQbTp1OArTqDzmISC7Wqk7dOfAVmiTfIBGj8CHeSIfCNUwH4oJ69PNkm13imhYdVZhHod
 F2NyjyjesmMTrQ2Cv6/NTGTBdsiw69pmcji/caizhFXZIZc6I5l/1TwKp5KuZKIMvB0vFsLA
 CuNrCq2N9GNVeBK3zJtGhmx9KhGnw1AxedW0AH/siYySJfknx1x1YRgJV3pAZOyLstD51fo+
 jUOKVhk79DCscQcKJmHe8EBc+6EHbETx7AOH+bZV7nCKYEMXTQrIOf2sR42Mi6PJgTiJcikp
 XIV11V8WY0ZkL1EMWLmIZG9xjcKV/NFQgFCvsurqSRloeMMYYDABfzPmzGyfHQ0cn3KverL8
 qOBA==
X-IronPort-AV: E=Sophos;i="5.88,373,1635220800"; 
   d="scan'208";a="64332123"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=CfPzZoLYFD1FdbogjENESIGO1A1oMj6urEt/PsS80ceQI3RI+WvkJ1SyUBeQNGaGPyNU03JFBMWyLLftBSvq+AhrfCDtdv1c4oELV1Wy0Bpsj0ngLhUTxSqq+181mKmBo9OkxZvxRbU1WOseSLk5C3MsJ8K8rKjscn913C+3vLplm/hB2EvoLgnZWIV5e8f4m3qErqNzUW89l+BEOVr9T1tDBwfmJTgGPfeNcTZq5G0fcXy1OzKkE9plhKKBxX9LbRhBbDkN2dxqZJ1e6NZLfl++SZR2G22+GtgU8WVHWZZ1JP4/9GRz9jJGMsFrN+pwlUY2zXKfgjX8v/GzV2niSg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=w1AMShmSEkasRrcVpUKRpw8B41H7gKDFNFnrQyhxxKI=;
 b=Vh4RdGentRs4eN0r4J7zKMaXAjfKlWp11zFum7DpTD+jiB6HRuPvw+EvY76r9tQYmHHXMn8P5842DgxBwpSuLJjCjwTVfp/t+9p6MGzcCQdaY5TTbVrkz/IqLI3t3R+0IsOW32YeZmFhcPrcRjcB7nCcrpp+7+oVrSn0zZtnyNQcwbVxWm5q6qqQQNiU7i3VxRj16d/frNT2dQl2KLm3DzRYYW3/wuHOcFmJC7h15CcD8oU1lnXvfAdpGvEpGhGAJC2/vhkM8fPI+KyiPJNodkg5l8aa3YI8iKNLXBuP/7EqCT27VEo86J9PR6YKYhpccnUPUqMWrjcKWmvKOK9xug==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=w1AMShmSEkasRrcVpUKRpw8B41H7gKDFNFnrQyhxxKI=;
 b=ek0PwfhmIA8bDbbIiJAPWfKNg+57Usn3RDHIY1wiek0sKUwF0wtGAtExuhmFcHCrCZqe+RU3e9ueAhviG1AVRXDcbsRptH9GUIwY1MVnuaTk9oGTLjLPshrt4aGKZpR9z1MtIR8N00kCBtiyMh08/pbSASK4mJiaMjKMYnRZnwo=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>, Andrew Cooper <amc96@srcf.net>
CC: Xen-devel <xen-devel@lists.xenproject.org>,
	=?utf-8?B?TWFyZWsgTWFyY3p5a293c2tpLUfDs3JlY2tp?=
	<marmarek@invisiblethingslab.com>
Subject: Re: [PATCH v2 07/70] x86: Build check for embedded endbr64
 instructions
Thread-Topic: [PATCH v2 07/70] x86: Build check for embedded endbr64
 instructions
Thread-Index: AQHYIaGvWqdqb3ZDi0C7/EewX8xTwqyUuZIAgAAssICAAPiHAIAANgUA
Date: Wed, 16 Feb 2022 11:55:04 +0000
Message-ID: <b80670a7-8802-4734-35a1-c7e0ec785da0@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
 <20220214125127.17985-8-andrew.cooper3@citrix.com>
 <95c29039-302c-256b-d381-2b5b8b9c1a4a@suse.com>
 <8c6d9714-7e45-1603-a5ad-d49fc060304e@srcf.net>
 <7c5ff089-780b-9965-4765-be3ef210a913@suse.com>
In-Reply-To: <7c5ff089-780b-9965-4765-be3ef210a913@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: b52cafc7-6e72-4ed3-098d-08d9f1432b9f
x-ms-traffictypediagnostic: BN6PR03MB2820:EE_
x-microsoft-antispam-prvs: <BN6PR03MB2820AF6C3F8E3DDA4A47C03CBA359@BN6PR03MB2820.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:6108;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: cyrdMnOYnr/GLJRJS+DZ4IS81O3aId10aRTkXN1ovIJRAH4AMaZKA3vyxy/pgkb9l28WbxACKnEpCBq67xxNsQOeKegcp+3tEYAZlcK3MupQ9DhvurWoN5DwrGo8PWQMmzb7+JaRJP4oRxg8yFe4OYDq1crGQPdGsHLi/jUIOqIqNKI1VkvvnnPM6MV/GwafvxSFaMuFjg/Wt+R4FDGj8mqy+1lDL/Gcmd+YWIEDdVicU34o6Gk8N5v+Em9b3pnoFIW+pspUfnvwXppTgQZYZHvtj1yr517tOrCCcHNIC1sFCNR1k8Yc2GKpDer3RPXj7qYn4LOyky9mCRRTRTm/yJOh0KJbiPUe1sATA1hO2hpRwo5h/wngK7bDfp3PlwpQUcAiWAL3NYYq0BBx0T/7rodSMF1W7lOLeVYBzeSBxaIH23iKd+G0UaQMjhSb0ypCS4dUK3O7VQS6qMNBFcNYI5jzRum9vxIgoMmfIivA7rlKkXDDHtByklM8lT8AkMC16wW4O2DflpkLzwlQOk3e6J1UNfT2zbC8zXODSyDLtoz492Wxfuf7p7C2Y1tdtELEwOCZh0j6mb6WqKgTBgkCY56Q2181RwXV+GvKJIJo374je9fBOOqQWaZ3vSc2p8TIfxDlsBadF2tqwSw3DhBjF6GNed1Hp+q1QHaOgPu9zaRL0znquoyIEWqe3fsj/HRC6/MCoIqi3UedXTQaDiAEbiBYkjkRUS8BkcJl9pK8kEcWXidAHyeqE//C+51iWGi0Nj6z6CKQn/QEhRfVGEe/fg==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(91956017)(86362001)(66556008)(2616005)(8676002)(4326008)(66476007)(6506007)(66446008)(64756008)(31696002)(8936002)(76116006)(66946007)(6512007)(2906002)(71200400001)(53546011)(83380400001)(186003)(26005)(5660300002)(38070700005)(122000001)(316002)(36756003)(31686004)(38100700002)(6486002)(54906003)(110136005)(508600001)(82960400001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?K2hkay9JQjJGZWtEWm04Q0xmSzdvNmFjNXZQa0Q2dHhPR25ieExQOVdYeGJx?=
 =?utf-8?B?dDVqSTJWaDRMUnhtTTF2ZWV2S055UGVBVFphMzhMQWdCb3U4WjlyeEJXMERM?=
 =?utf-8?B?eG12bndtZE5xYkc5UWRCWFhLdWZKaVI3SWFBbnZjZnQ0SWdFV2M1Nm9JanJu?=
 =?utf-8?B?dzFWK1NncWNCbnFoTnYzMEtkSGpIeDlQZlhSc3VoYmxZdm5GOXNra3hodnZh?=
 =?utf-8?B?U1g0VVR4WTNnS05JME5tSlY2MkVDa2lrYWZxVjFWRkxPaHpVcWUyYkRjWllZ?=
 =?utf-8?B?cE1LOElmZVFhb09sbHBWSEIzbnVPM05wanR6OGRVczJzamh0ekR3OTZhMnlX?=
 =?utf-8?B?d2VrL3BlK2E3RXBmbXRpRXdwUi9hc1JaWDFLc0J0VW92ZWgyamVzdThNbVpn?=
 =?utf-8?B?VCtubjNRd2FzSEwzZDYybUgzQjc2QmVybStXUnorUS80MnNHU0pzb1c5WDhX?=
 =?utf-8?B?MCtwS3RQWFlMbWZOQXV5MC9kNGQvNkp6ek5kam1SOGFEVkdoWm83WStDUVdk?=
 =?utf-8?B?NzhBdGZUUWZGL3NraUh6V3FVSkZGQjNqcW1zMTROYVY2d0M4MGpWQzQ3ejRK?=
 =?utf-8?B?bU1pNGZTS2ZYTDB3Ukw0cERhU0VMa09OYWZMVGJWV1VvUE1Dc2pNb0F2d2FS?=
 =?utf-8?B?dENVMXNMUU5QOW53ZnpFU1NYa0crcDdqVzkwUFRpSDFMSVo1M0VVVjdHUE92?=
 =?utf-8?B?eEdEbHBidTByd25EbHcxZnJSMjM4MzY2SE9aUjdxUURRbDRpeHRJYVJZakpW?=
 =?utf-8?B?bGNrSG9mN3dPNm4vV3B4bng0cE9mRXIyZ1Q2VThKRW5nbDlKa0VSck0zMXhk?=
 =?utf-8?B?MG1HZW5BMXhWTmRqaWNxR2ZHNnI5V205b1hNakZxK2dTRThOS3F4UDhQMHNX?=
 =?utf-8?B?emRVdURONktDQnFBRDFjYW1GY1UzVlVOazhMa1dVVitRalpWOVFjcG9PeXlY?=
 =?utf-8?B?dHBlTHlKN29xWnhwVGZVMnhHekJOc3l4OVVSZ2cwWHdZd2ltNWdIaFJ6bjNI?=
 =?utf-8?B?QXVobVV2dlNvKzdCbnk3Ny9NUUNjU1l6akxXZUNMNWRBWllTUmVOazNaUjlo?=
 =?utf-8?B?U0dtVENJM0h1bFdpZGFmNHRPK0Y3ZHdXUEZORlIxRXdaM3cwY2VDSmlDQW81?=
 =?utf-8?B?eXBJZHJvNEZkT2pVRmdnYWRSdU9neDkxMGxxYUFtMnc1MlEzUlJ1YjJUYTJz?=
 =?utf-8?B?RXJKMnlXajREd0d6SFlXK21vVzZZMEd1WVpPdTdrK09neE1aeVdYWkxBVkN0?=
 =?utf-8?B?ZDI5THlIZW8wU2ZQRnZYeWM5REloMU90V0JydjhKeEo0bWRHeUdWN1J3WUtq?=
 =?utf-8?B?ZTlZMW9PMnFjSHBBeG5ZejRxQ0hkdVFEdGI4aGNDc1lnYVZIdWJQdjcwajJu?=
 =?utf-8?B?aFRCM2wzZWprNUZWMU1GZWNpRnZHRHVxam84YXdqK2E3VnQvTG5CUmNrRWRj?=
 =?utf-8?B?YStmQ0V6cWhnT1kzVnpOSHE2THBJeTlvWGhmaC91S201TlAvU2RLQU5VYVgy?=
 =?utf-8?B?ai8vMHk0SDl2MXYxVDZncDQ0YVF0cGRmRE4zd0JwREs5YTB4NlI1Y3BqTmxk?=
 =?utf-8?B?b0FXM2REL0YrSmdvTVlpbnR3dmhxZElYdE9HZEpFWERJU0FyWmpTZE8zanh3?=
 =?utf-8?B?dFFkVU96Y3dOenNnTmdJM2swQ2JJTTVBN01RaEs4K3kra2UveGdmdGhvQU5J?=
 =?utf-8?B?U1hqRFllaFBxUCt1UGVKT2lpVFp3eEc0QXZFUUdBeTYxSXVIUjhCLzAwYlNn?=
 =?utf-8?B?eW5wNHJaamlFMlVDT0ZDc0tjWlBNbmFTQklRdC8wZmJZRE5OblBNV2RQL2lr?=
 =?utf-8?B?VWJ4d0xRM1NlWTUralVsQUdBREdKbUZMWGJWcHdSd2syeUxxNGRPc2JwVThz?=
 =?utf-8?B?S3NScy9QdXhFOEFsbTNvT0VLWks5Sm1ZRGJsaTZvMzNWRzZXNjF0MU5xM3N6?=
 =?utf-8?B?eDRHT0JIdWJtd0NkaGlPMitET2FxemVYLy9MQy9QUWZVeUpEeEJMNUdNcUUx?=
 =?utf-8?B?SHhuSXVNL1pSV09LVmlaQ3U2amhURjdTb2d6a3dQZnM5ejRPVEh3ZWZQUDhl?=
 =?utf-8?B?UGF1Zk51L0E2Z0hmemZFU2REZ1E4T3UvNFFiYXRhNmZDcWIzdlBwQ3pjd2w0?=
 =?utf-8?B?ZWZQRnA2Y3RyL0JzQTNpU3dhbDdVY3VmeWJyUFV1YTR5OFF2VUJXbWJBL1NW?=
 =?utf-8?B?cmptbndTUGJKOUFNamk2R0hlQVM1SWhnaUZGWDZlVDY0OVRaMGtFOGhLOHpu?=
 =?utf-8?B?djR0MjZDMTdSaE05SitmYXh6bGNRPT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <E1A4EBCBDB1008419F7F40DC488CFB60@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b52cafc7-6e72-4ed3-098d-08d9f1432b9f
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Feb 2022 11:55:04.5644
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: OsFDRgrcw2TSVoducGxyWZ9D2lH9JOp7WttA6xABo/J8i9Bic1nbREF2EBUBJRCUTB7GspmLbS9hCWo6FrIjqPuqYXnCGVlVKDz0BMp3aX0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2820
X-OriginatorOrg: citrix.com

T24gMTYvMDIvMjAyMiAwODo0MSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+Pj4gQW55IHplcm8tcGFk
ZGluZyBpbnNlcnRlZCBhbnl3aGVyZSBieSB0aGUgbGlua2VyIGNhbg0KPj4+IHJlc3VsdCBpbiBh
biBpbW1lZGlhdGVseSBmb2xsb3dpbmcgRU5EQlIgdG8gYmUgbWlzc2VkIChiZWNhdXNlDQo+Pj4g
c2VxdWVuY2VzIG9mIHplcm9zIHJlc2VtYmxlIDItYnl0ZSBpbnNucykuDQo+PiBJJ20gbm90IHN1
cmUgdGhpcyBpcyBhIHByb2JsZW0uwqAgVGhpcyBwYXNzIGlzIGxvb2tpbmcgZm9yIGV2ZXJ5dGhp
bmcNCj4+IHRoYXQgb2JqZHVtcCB0aGlua3MgaXMgYSBsZWdhbCBlbmRicjY0IGluc3RydWN0aW9u
LCBhbmQgaXQgc3BsaXRzIGF0IGxhYmVscy4NCj4gT2gsIHJpZ2h0IC0gSSBkaWQgbWlzcyB0aGUg
c3BsaXR0aW5nIGF0IGxhYmVscyBhc3BlY3QuIEhvcGVmdWxseQ0KPiBvYmpkdW1wIGlzIHJlYWxs
eSBjb25zaXN0ZW50IHdpdGggdGhpcy4NCg0KQ2VydGFpbmx5IGFwcGVhcnMgdG8gYmUgaW4gbXkg
ZXhwZXJpZW5jZS4NCg0KPj4+PiArIw0KPj4+PiArIyBTZWNvbmQsIGxvb2sgZm9yIGFueSBlbmRi
cjY0IGJ5dGUgc2VxdWVuY2UNCj4+Pj4gKyMgVGhpcyBoYXMgYSBjb3VwbGUgb2YgY29tcGxpY2F0
aW9uczoNCj4+Pj4gKyMNCj4+Pj4gKyMgMSkgR3JlcCBiaW5hcnkgc2VhcmNoIGlzbid0IFZNQSBh
d2FyZS4gIENvcHkgLnRleHQgb3V0IGFzIGJpbmFyeSwgY2F1c2luZw0KPj4+PiArIyAgICB0aGUg
Z3JlcCBvZmZzZXQgdG8gYmUgZnJvbSB0aGUgc3RhcnQgb2YgLnRleHQuDQo+Pj4+ICsjDQo+Pj4+
ICsjIDIpIEFXSyBjYW4ndCBhZGQgNjRiaXQgaW50ZWdlcnMsIGJlY2F1c2UgaW50ZXJuYWxseSBh
bGwgbnVtYmVycyBhcmUgZG91Ymxlcy4NCj4+Pj4gKyMgICAgV2hlbiB0aGUgdXBwZXIgYml0cyBh
cmUgc2V0LCB0aGUgZXhwb25lbnRzIHdvcnRoIG9mIHByZWNpc2lvbiBpcyBsb3N0IGluDQo+Pj4+
ICsjICAgIHRoZSBsb3dlciBiaXRzLCByb3VuZGluZyBpbnRlZ2VycyB0byB0aGUgbmVhcmVzdCA0
ay4NCj4+Pj4gKyMNCj4+Pj4gKyMgICAgSW5zdGVhZCwgdXNlIHRoZSBmYWN0IHRoYXQgWGVuJ3Mg
LnRleHQgaXMgd2l0aGluIGEgMUcgYWxpZ25lZCByZWdpb24sIGFuZA0KPj4+PiArIyAgICBzcGxp
dCB0aGUgVk1BIGluIGhhbGYgc28gQVdLJ3MgbnVtZXJpYyBhZGRpdGlvbiBpcyBvbmx5IHdvcmtp
bmcgb24gMzIgYml0DQo+Pj4+ICsjICAgIG51bWJlcnMsIHdoaWNoIGRvbid0IGxvc2UgcHJlY2lz
aW9uLg0KPj4+PiArIw0KPj4+PiArZXZhbCAkKCR7T0JKRFVNUH0gLWggfCBhd2sgJyQyID09ICIu
dGV4dCIge3ByaW50ZiAidm1hX2hpPSVzXG52bWFfbG89JXNcbiIsIHN1YnN0cigkNCwgMSwgOCks
IHN1YnN0cigkNCwgOSwgMTYpfScpDQo+Pj4+ICsNCj4+Pj4gKyR7T0JKQ09QWX0gLU8gYmluYXJ5
ICRURVhUX0JJTg0KPj4+PiArZ3JlcCAtYW9iICIkKHByaW50ZiAnXDM2M1wxN1wzNlwzNzInKSIg
JFRFWFRfQklOIHwNCj4+Pj4gKyAgICBhd2sgLUYnOicgJ3twcmludGYgIiVzJXhcbiIsICInJHZt
YV9oaSciLCBzdHJ0b251bSgweCckdm1hX2xvJykgKyAkMX0nID4gJEFMTA0KPj4+IE5vbmUgb2Yg
dGhlIHRocmVlIG9wdGlvbnMgcGFzc2VkIHRvIGdyZXAgbG9vayB0byBiZSBzdGFuZGFyZGl6ZWQu
DQo+Pj4gSXMgdGhpcyBnb2luZyB0byBjYXVzZSBwcm9ibGVtcyBvbiBub24tTGludXggc3lzdGVt
cz8gU2hvdWxkIHRoaXMNCj4+PiBjaGVja2luZyBwZXJoYXBzIGJlIHB1dCBiZWhpbmQgYSBzZXBh
cmF0ZSBLY29uZmlnIG9wdGlvbj8NCj4+IENJIHNheXMgdGhhdCBGcmVlQlNEIGlzIGVudGlyZWx5
IGhhcHB5LCB3aGlsZSBBbHBpbmUgTGludXggaXNuJ3QuwqAgVGhpcw0KPj4gaXMgYmVjYXVzZSBB
bHBpbmUgaGFzIGJ1c3lib3gncyBncmVwIHVubGVzcyB5b3UgaW5zdGFsbCB0aGUgR05VIGdyZXAN
Cj4+IHBhY2thZ2UsIGFuZCBJJ20gZG9pbmcgYSBmaXggdG8gb3VyIGNvbnRhaW5lci4NCj4+DQo+
PiBNeSBwbGFuIHRvIGZpeCB0aGlzIGlzIHRvIGp1c3QgZGVjbGFyZSBhICJncmVwIGNhcGFibGUg
b2YgYmluYXJ5DQo+PiBzZWFyY2hpbmciIGEgY29uZGl0aW9uYWwgYnVpbGQgcmVxdWlyZW1lbnQg
Zm9yIFhlbi7CoCBJIGRvbid0IHRoaW5rIHRoaXMNCj4+IGlzIG9uZXJvdXMsIGFuZCB0aGVyZSBu
byBvdGhlciBwbGF1c2libGUgYWx0ZXJuYXRpdmVzIGhlcmUuDQo+Pg0KPj4gVGhlIG90aGVyIG9w
dGlvbiBpcyB0byBkZXRlY3QgdGhlIGFic2VuY2Ugb2Ygc3VwcG9ydCBhbiBza2lwIHRoZSBjaGVj
ay7CoA0KPj4gSXQgaXMgYWZ0ZXIgYWxsIGEgZGVmZW5jZSBpbiBkZXB0aCBzY2hlbWUsIGFuZCBh
bnl0aGluZyBsaWFibGUgdG8gY2F1c2UNCj4+IGEgcHJvYmxlbSB3b3VsZCBiZSBjYXVnaHQgaW4g
Q0kgYW55d2F5Lg0KPiBJJ2QgZmF2b3IgdGhlIGxhdHRlciBhcHByb2FjaCAoYnV0IEkgd291bGRu
J3QgbWluZCB0aGUgY29uZGl0aW9uYWwgYnVpbGQNCj4gcmVxdWlyZW1lbnQsIGlmIHlvdSBhbmQg
b3RoZXJzIGRlZW0gdGhhdCBiZXR0ZXIpLCB3aXRoIGEgd2FybmluZyBpc3N1ZWQNCj4gd2hlbiB0
aGUgY2hlY2sgY2FuJ3QgYmUgcGVyZm9ybWVkLiBJIGhhdmUgdG8gYWRtaXQgdGhhdCBJIGRpZG4n
dCBleHBlY3QNCj4gdGhlcmUgd291bGQgYmUgbm8gc2ltcGxlIGFuZCBzdGFuZGFyZGl6ZWQgYmlu
YXJ5IHNlYXJjaCB0b29sIG9uIFVuaXgtZXMuDQoNCk9rLCBzbyBsZXRzIGRvIHRoaXM6DQoNCjEp
IFRoaXMgc2NyaXB0IGdldHMgYSBjaGVjayBmb3IgJChncmVwIC1hb2IpIGFuZCBlbWl0cyBhIHdh
cm5pbmcgdG8NCnN0ZGVyciBidXQgZXhpdHMgMC7CoCBUaGlzIGxldHMgcGVvcGxlIHVzaW5nIElC
VCBrbm93IHRoYXQgc29tZXRoaW5nIHdhcw0KbWlzc2luZy4NCg0KMikgT3B0aW9uYWwgYnVpbGQg
ZGVwZW5kZW5jeSBvZiBgZ3JlcCAtYW9iYCBmb3IgWGVuLsKgIChqdXN0IGEgdHdlYWsgdG8NClJF
QURNRSkNCg0KMykgVXBkYXRlIHRoZSBhbHBpbmUgY29udGFpbmVycyB0byBub3QgbWlzcyBvdXQu
DQoNCn5BbmRyZXcNCg==


From xen-devel-bounces@lists.xenproject.org Wed Feb 16 11:55:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 11:55:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274062.469403 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKIuN-0006hg-Mi; Wed, 16 Feb 2022 11:55:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274062.469403; Wed, 16 Feb 2022 11:55:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKIuN-0006hZ-JR; Wed, 16 Feb 2022 11:55:43 +0000
Received: by outflank-mailman (input) for mailman id 274062;
 Wed, 16 Feb 2022 11:55:42 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=bXi8=S7=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1nKIuL-0006cQ-SA
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 11:55:42 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04on062d.outbound.protection.outlook.com
 [2a01:111:f400:fe0e::62d])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5c31aa60-8f1f-11ec-b215-9bbe72dcb22c;
 Wed, 16 Feb 2022 12:55:40 +0100 (CET)
Received: from AM6P191CA0066.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:7f::43)
 by PAXPR08MB6815.eurprd08.prod.outlook.com (2603:10a6:102:134::23) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.15; Wed, 16 Feb
 2022 11:55:30 +0000
Received: from AM5EUR03FT037.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:7f:cafe::95) by AM6P191CA0066.outlook.office365.com
 (2603:10a6:209:7f::43) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.16 via Frontend
 Transport; Wed, 16 Feb 2022 11:55:30 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT037.mail.protection.outlook.com (10.152.17.241) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4975.11 via Frontend Transport; Wed, 16 Feb 2022 11:55:29 +0000
Received: ("Tessian outbound 2877e54fe176:v113");
 Wed, 16 Feb 2022 11:55:29 +0000
Received: from 0d9ae734107e.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 0159BE3A-AE7C-4A24-9159-4DFC5B615C8A.1; 
 Wed, 16 Feb 2022 11:55:22 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0d9ae734107e.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 16 Feb 2022 11:55:22 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by PR2PR08MB4811.eurprd08.prod.outlook.com (2603:10a6:101:21::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.14; Wed, 16 Feb
 2022 11:55:20 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::aca7:79c4:fa65:dac6]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::aca7:79c4:fa65:dac6%5]) with mapi id 15.20.4995.014; Wed, 16 Feb 2022
 11:55:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5c31aa60-8f1f-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=qU6uSB0HFChXFdJLtQwfaZtWxn3LHATQgu/PsztoSHg=;
 b=qvivfQYINvP8goceVNH6BYNNlAZ7AdlxMngot12DKczu+RrdKVAB86kJXCvhFVlUO75y+cLWX6hLWYXO2O39aJAAXTo1dQ+NqBkneFKE/6+Lu2cPiBFc0CMZQhn0GzgXJO4s7RpDVTKdnpkjyb4ZEVcZdUqBQEgFBV7VCtQjY/4=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 94984090e3fd74ff
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=JzKBCaSlHdJ6AyZz4GSzyOA6/wD9Bc593FRk9WLid0P4JHh9vxeRWR4Fl4/1XYETKVCT1P240AgR1YDRUwsBuejAo2GrEsNB48azb104FyUUyU9JTTwxukkCJTP8zcu8IgHbg2k6HUb5mPI/LPec1DhnWP+urGsW41vCj2LwB90x/dJMGS0HllDvemGeHLO2WDs8nKpjfL3xsZer26JmWB+nSdevlO3tmD7VFcP/Fjcro5rSFJ4/L3dndyNGdAHFJxb7dbo6vB9bZroNn6aGbMJW2KbJwPwRWwJxWtYAduOCZDJtRvyI+xQC5NmUujZe7Uw/qbeHDBB2OUDs46tknA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=qU6uSB0HFChXFdJLtQwfaZtWxn3LHATQgu/PsztoSHg=;
 b=jMSioFOYQzYVNv6+i3ufsHPllwBn8twPyLGDTb7GU5rXHKoBuAl/xk9Kk2DFUt0OCzy7rLMn22zYZpGGPHZhdhkWgtsl0yyq8yc/HpNVxCt1Jn158ylXnOn53xm52MI/yDMFW1qlXJ9iZuIIn+6Se6KZBb3MSf3Tszs3Q1c3E1k/7EpTwle8nuzzqIMswLhOb8lfcN9rfq7WJuGMha8C6NylSDeIX8ry342kamxyL8A2cISW2o/66Fxzsz6HzjGJaj+w1pIED0d0Wra3dWLtoqghOD16ARZM+rp8SKqNVPaNbzeJcpwvwnG/nEIthqcDwWGlD0tdjbYSkJ9gIKST6A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=qU6uSB0HFChXFdJLtQwfaZtWxn3LHATQgu/PsztoSHg=;
 b=qvivfQYINvP8goceVNH6BYNNlAZ7AdlxMngot12DKczu+RrdKVAB86kJXCvhFVlUO75y+cLWX6hLWYXO2O39aJAAXTo1dQ+NqBkneFKE/6+Lu2cPiBFc0CMZQhn0GzgXJO4s7RpDVTKdnpkjyb4ZEVcZdUqBQEgFBV7VCtQjY/4=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Julien Grall <julien@xen.org>
CC: Andrew Cooper <Andrew.Cooper3@citrix.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Xen-devel <xen-devel@lists.xenproject.org>, Jan
 Beulich <JBeulich@suse.com>, Roger Pau Monne <roger.pau@citrix.com>, Wei Liu
	<wl@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v2 02/70] xen/sort: Switch to an extern inline
 implementation
Thread-Topic: [PATCH v2 02/70] xen/sort: Switch to an extern inline
 implementation
Thread-Index: AQHYIaGnBAePJgt7y0O7PyvIWQlKrKyTBxsAgAKFHwCAAHT3AIAAERWAgAACmoA=
Date: Wed, 16 Feb 2022 11:55:19 +0000
Message-ID: <C5CDC3F8-0EC1-4270-B388-70F7E9982576@arm.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
 <20220214125127.17985-3-andrew.cooper3@citrix.com>
 <70824a0c-cc48-b064-695c-35c2d06c0ad1@xen.org>
 <alpine.DEB.2.22.394.2202151800230.43738@ubuntu-linux-20-04-desktop>
 <faa6c523-6e88-8987-c0c9-3652c002fda3@citrix.com>
 <f5d6de10-5d3c-f86e-71eb-203dd06b6a11@xen.org>
In-Reply-To: <f5d6de10-5d3c-f86e-71eb-203dd06b6a11@xen.org>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3693.60.0.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 18cb9fde-b416-43e4-d894-08d9f1433a69
x-ms-traffictypediagnostic:
	PR2PR08MB4811:EE_|AM5EUR03FT037:EE_|PAXPR08MB6815:EE_
X-Microsoft-Antispam-PRVS:
	<PAXPR08MB6815F6F0EFF2974E66CA16C79D359@PAXPR08MB6815.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 1m/KotHCQ1t9SQXo8vKUmxeowJ65pdCyA36EoNXAWQxNHKJ1f5T16ODWFO963hHRwSyuMKvhMuBjo1R5AiwJ73YmPxYKQM9fOSRSwIcflSSbov7Pvw7z3+6rv/MEtD6FK8pLt0vHTmb3jSST+GFOhC9oTfmiZUYttAtkm4L3uWC6EpK3Riha7hL0zyEndbPfrcBJWuKU6x7vib4iqA2yMhRdspTszFK3UhAAxW5jnoVimTin/43At99drrZtK6oMCRiR+0e5AumjgGxWzvFvOEESqya0prhUe05UkbCGYmted2AFTyP2lAb3aQ3FzucXRRDRmYq8za1c5cKDy1BJx/PZyvwIfuKZxPFE6ebt5kDoLM1r1HKegU9VYKlOAPW0cdKP9c59czWiB8DswTMwIM9Tb+VEZcPIgEjUWKXo78jmdxZuhmLziRUBbUBsHpP9CfzgeY7RcszV8u9OnULTA3s6U4kcGlNLwzIt+zAtey5xNRnSIPs6tR74jhRD6PLU+KakC9s/nxFL7qAl/49bba2XVmmKP31EOziU6Z/JntteBf1ncCD0Y970yI9MdZiY1rr43++msbujttDaG1uxMWrZA66UV4SFqpn3dFkY0YdBRzUYs3ZLJz1HF01Wd4EH4JBVsd1MGLKQyZibNDzr0LH6nSzIrHGot4vBzEUOeA0FM7AUWPIcHmbOQ8vG8BTGR8HRFX1FBU9ldsoYTiSiyNRpwJVkEP1216CIuIEhHp9cjatTpsFn0M0JFTIvxceQ2nogRBYc3tegSsx/TNRQVQe780ixv/88V2jo8tHkp/wL0ZoXy1dzLE6q8maxI92KhpuZXKKtYsrcZhN5xtfI5g==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6512007)(508600001)(2616005)(66946007)(4326008)(8936002)(53546011)(86362001)(186003)(6916009)(33656002)(122000001)(91956017)(36756003)(38100700002)(26005)(2906002)(316002)(6486002)(966005)(38070700005)(5660300002)(54906003)(6506007)(66476007)(64756008)(76116006)(8676002)(66556008)(83380400001)(66446008)(71200400001)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <A0E186269A958940A83CF6E260A1E741@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR2PR08MB4811
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT037.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	02b4ac91-4ffa-474c-9629-08d9f14334ba
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	numhYtpw3fsnGuoGOoy9kORAyTI9xL2QgPxe1wcMFXsWM7JuJUAN8GLxnDbSNaE8dZ5hfC6Pykg730SxwijtIOOS+SyphDDHGJcz/ZJqEFYK7mtWbdXuqf3d3UjKGUxj2kg6hfDlMH9Pk9EdG8WhSHuTTXtaVZthEdHjMDEnqh3OnEjXjDGVdNy1oC6qx1zMYzR5wIQ0nlbFFRz/6SwdOlmeqnnaUXM0wrDDFQvW6/AO0wWsLtWrIBKH7IvF2VI9aR4P8cdLEJqGIq50+agv8nzKqSvZTy771xc0vVFTRMDa2zIuNzbT02nmF8SJ3Ghew5GWQ0T0liG39FdvK8sRS/XBPbRl144xB9YxbkMPWZwZicW0tS6y7uuP1RhydHdQvPdgBgAABHK9fv2dwe0V+8/TUizgsB0a1bBIoO5HowXaqK9KnJ527XmxaISXwO17fJ2boRBn4vVUiq4l/mhpu/U5RROqWTUw+LDDc0ZoJmdk4PZsCnEzhy3ncwp/9YEAwpEvLFbJDR+ohqKkJIG2v5ddQnM3zRbMtR5oCIdYAgFcz7o8YkQC8APx3e8JLAk99k1r3xawlwzESlvHT45yuNIdSMHBNCIHO3K6zvonHAgldsaZLyaT7oGh4BFYNuqpuaeRfmgzW4z/Cc8u4yl41tfPB7yP7XpyWhdRktnPiSgOh143fF0P10SOkMpmRdKA6nQuFO+Dn/UgIh+Wd4rUuJ6qJK4IAMIOVGojBUJFocLcwDO524C3iFBXoqG55MNViB5H7dZy3/Gz5Ur3Qgcklg==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(70586007)(83380400001)(336012)(40460700003)(70206006)(186003)(54906003)(316002)(26005)(356005)(81166007)(82310400004)(86362001)(47076005)(8676002)(36860700001)(508600001)(2616005)(33656002)(6512007)(53546011)(5660300002)(6506007)(107886003)(4326008)(6486002)(8936002)(966005)(6862004)(36756003)(2906002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2022 11:55:29.4128
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 18cb9fde-b416-43e4-d894-08d9f1433a69
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT037.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6815

Hi,

> On 16 Feb 2022, at 11:46, Julien Grall <julien@xen.org> wrote:
>=20
> Hi,
>=20
> On 16/02/2022 10:44, Andrew Cooper wrote:
>> On 16/02/2022 03:46, Stefano Stabellini wrote:
>>> On Mon, 14 Feb 2022, Julien Grall wrote:
>>>> On 14/02/2022 12:50, Andrew Cooper wrote:
>>>>> There are exactly 3 callers of sort() in the hypervisor.  Callbacks i=
n a
>>>>> tight
>>>>> loop like this are problematic for performance, especially with Spect=
re v2
>>>>> protections, which is why extern inline is used commonly by libraries=
.
>>>>>=20
>>>>> Both ARM callers pass in NULL for the swap function, and while this m=
ight
>>>>> seem
>>>>> like an attractive option at first, it causes generic_swap() to be us=
ed,
>>>>> which
>>>>> forced a byte-wise copy.  Provide real swap functions so the compiler=
 can
>>>>> optimise properly, which is very important for ARM downstreams where
>>>>> milliseconds until the system is up matters.
>>>> Did you actually benchmark it? Both those lists will have < 128 elemen=
ts in
>>>> them. So I would be extremely surprised if you save more than a few hu=
ndreds
>>>> microseconds with this approach.
>>>>=20
>>>> So, my opinion on this approach hasn't changed. On v1, we discussed an
>>>> approach that would suit both Stefano and I. Jan seemed to confirm tha=
t would
>>>> also suit x86.
>>> This patch series has become 70 patches and for the sake of helping
>>> Andrew move forward in the quickest and most painless way possible, I
>>> append the following using generic_swap as static inline.
>>>=20
>>> Julien, Bertrand, is that acceptable to you?
>>>=20
>>> Andrew, I know this is not your favorite approach but you have quite a
>>> lot of changes to handle -- probably not worth focussing on one detail
>>> which is pretty minor?
>> It's not pretty minor.  My version really is the best thing for ARM.
> >
>> The perf improvement alone, marginal as it may be in practice, is
>=20
> Our take on Arm has always been to avoid micro-optimization when the resu=
lting code is more difficult to maintain.
>=20
>> justification alone for the patch, and Bertrand's R-by is testament to t=
his.
>=20
> I am not sure why calling out that Bertrand agreed means that everyone el=
se should accept your approach.
>=20
> This reminds me other series that have been blocked for a long time by yo=
u. Yet you made no effort to compromise... How ironic.
>=20
>> But the reasons why getting rid the swap functions is important for
>> CET-IBT on x86 are exactly the same as why getting rid of them on ARM
>> will be important for BTI support.  A tagged function doing an arbitrary
>> bytewise swap from two parameters controlled by the third is far more
>> valuable to an attackers gadget library than a typical function.
>=20
> This is a more compelling reason. However, I am a bit puzzled why it took=
 you so long to come up with this reason.
>=20
>> i.e. this proposed intermediary, if it compiles, is just busywork which
>> someone else is going to have to revert in the future, along with having
>> this argument again.
>=20
> Well, this argument would have never happened if your commit message cont=
ained information about BTI.

I agree that this would be nice to have in the commit message as a justific=
ation for the change.

Cheers
Bertrand

>=20
> Instead you decided to just mention the performance part despite me objec=
ting it and requesting for a different reason in v1 (see [1]).
>=20
> Anyway, I will wait for a reword of the commit message before lifting my =
Nacked-by.
>=20
> Cheers,
>=20
> [1] https://lore.kernel.org/xen-devel/f7bb7a08-4721-f2a8-8602-0cd1baf1f08=
3@xen.org/
>=20
> --=20
> Julien Grall



From xen-devel-bounces@lists.xenproject.org Wed Feb 16 12:10:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 12:10:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274077.469414 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKJ92-0000to-6j; Wed, 16 Feb 2022 12:10:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274077.469414; Wed, 16 Feb 2022 12:10:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKJ92-0000th-3h; Wed, 16 Feb 2022 12:10:52 +0000
Received: by outflank-mailman (input) for mailman id 274077;
 Wed, 16 Feb 2022 12:10:51 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=wbM1=S7=arm.com=Luca.Fancellu@srs-se1.protection.inumbo.net>)
 id 1nKJ91-0000tb-6Z
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 12:10:51 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04on061c.outbound.protection.outlook.com
 [2a01:111:f400:fe0e::61c])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 79abc489-8f21-11ec-b215-9bbe72dcb22c;
 Wed, 16 Feb 2022 13:10:48 +0100 (CET)
Received: from DU2PR04CA0251.eurprd04.prod.outlook.com (2603:10a6:10:28e::16)
 by DB9PR08MB6796.eurprd08.prod.outlook.com (2603:10a6:10:2ad::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.18; Wed, 16 Feb
 2022 12:10:45 +0000
Received: from DB5EUR03FT018.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:28e:cafe::51) by DU2PR04CA0251.outlook.office365.com
 (2603:10a6:10:28e::16) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11 via Frontend
 Transport; Wed, 16 Feb 2022 12:10:45 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT018.mail.protection.outlook.com (10.152.20.69) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4975.11 via Frontend Transport; Wed, 16 Feb 2022 12:10:45 +0000
Received: ("Tessian outbound 31aeb3346a45:v113");
 Wed, 16 Feb 2022 12:10:45 +0000
Received: from 8c9cde3e61b6.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 B5263E74-32D3-4C77-91B8-C8C9B66F7414.1; 
 Wed, 16 Feb 2022 12:10:33 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8c9cde3e61b6.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 16 Feb 2022 12:10:33 +0000
Received: from VI1PR0801MB2125.eurprd08.prod.outlook.com
 (2603:10a6:800:5b::23) by DB8PR08MB5068.eurprd08.prod.outlook.com
 (2603:10a6:10:e9::12) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.15; Wed, 16 Feb
 2022 12:10:31 +0000
Received: from VI1PR0801MB2125.eurprd08.prod.outlook.com
 ([fe80::5531:4c33:a50c:ea0e]) by VI1PR0801MB2125.eurprd08.prod.outlook.com
 ([fe80::5531:4c33:a50c:ea0e%9]) with mapi id 15.20.4995.016; Wed, 16 Feb 2022
 12:10:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 79abc489-8f21-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=LtFoFKwO7S2rOjtL5Z3Zt/MozfaqQMWWJi7GW6Shc5c=;
 b=r0JCHg7TLsbMs/oKiWlG8xuiKvicsHpDrPrHPFbSleE3ri5QQRXue5kqy8w2W7zIHlVh7ST/MnhSekqfS2OPJs6AnadYzQloSZbjQ66LTijIGC6hEITQnoATiI57QTINrhb6v9dV91D2bTrv/IWCteAU5C42ncK10XrfiN6idQU=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 097a1bce73520e55
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=j95a26orvrjv3w5itWIO0PN2zc1DNwbJjZvZ8bMqIAuWYyfIzu29Ib8K23tj8vDmjrgaNV/1tPMVdkV93ApsJfrqoNsVTq82eciSGCmjo5vXXE2lYWSzXDqoti7fwYrKdeLjsrbQoMDYrco2DBLr3bkRqx3PCxGC3xb95T2D80IZiykv6ATgUsivUX/x8Tx9iYUeLg6VtPod+W6X9t+XgcUTFgoLkfdD4Sf+lp43wvY+GWljEiLA+P/RagyvJBUSGmDEUVD8i4FLLvjRLgr43M0+9o6A0+ZBdBV3GdD1fR8TkrxtMhcf/4Hm9tUjpTsT6yfk/k15D1+VZOiroAjjpg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=LtFoFKwO7S2rOjtL5Z3Zt/MozfaqQMWWJi7GW6Shc5c=;
 b=IrSEzDr+aGPCutfaV/jdFWYKT997/a+KO1C3EBKpF/sEEme06QRsL73MZrPK5DMXVkOjXt733BuASHsSrjZgu24BGJtqYKNW/nMvNa9r5qlc8snvYBDGCnlzVY88NklIbB9gTWmSHdLGW7qyws5kxbTnFunyY0PWjqWRpFo0tYpAmSqA05X0L1zgmabP8poSercYemER7Hd5JFHwhJ3i2OTJRO7BO2U5Qd7PH/0eP2ctmKJdPTC0SbLnNFbKaKRv+RMudFfOQfodT1QaKBI6Rg0phu75jnV1x9YfN0aa6bhcqkvjR5sUeoQhfQzvsgern7V6gWUDa3qlVXRXa5k25g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=LtFoFKwO7S2rOjtL5Z3Zt/MozfaqQMWWJi7GW6Shc5c=;
 b=r0JCHg7TLsbMs/oKiWlG8xuiKvicsHpDrPrHPFbSleE3ri5QQRXue5kqy8w2W7zIHlVh7ST/MnhSekqfS2OPJs6AnadYzQloSZbjQ66LTijIGC6hEITQnoATiI57QTINrhb6v9dV91D2bTrv/IWCteAU5C42ncK10XrfiN6idQU=
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
Content-Type: text/plain;
	charset=utf-8
Subject: Re: [PATCH 4/5] xen/cpupool: Create different cpupools at boot time
From: Luca Fancellu <luca.fancellu@arm.com>
In-Reply-To: <alpine.DEB.2.22.394.2202151827380.43738@ubuntu-linux-20-04-desktop>
Date: Wed, 16 Feb 2022 12:10:26 +0000
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
 Wei Chen <wei.chen@arm.com>,
 Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>,
 Juergen Gross <jgross@suse.com>,
 Dario Faggioli <dfaggioli@suse.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <53747C8B-681A-4474-B1DF-F08702322AB9@arm.com>
References: <20220215101551.23101-1-luca.fancellu@arm.com>
 <20220215101551.23101-5-luca.fancellu@arm.com>
 <alpine.DEB.2.22.394.2202151827380.43738@ubuntu-linux-20-04-desktop>
To: Stefano Stabellini <sstabellini@kernel.org>
X-Mailer: Apple Mail (2.3693.60.0.1.1)
X-ClientProxiedBy: LO4P265CA0062.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:2af::18) To VI1PR0801MB2125.eurprd08.prod.outlook.com
 (2603:10a6:800:5b::23)
MIME-Version: 1.0
X-MS-Office365-Filtering-Correlation-Id: a633572d-fcc1-4fc0-3cd9-08d9f1455c28
X-MS-TrafficTypeDiagnostic:
	DB8PR08MB5068:EE_|DB5EUR03FT018:EE_|DB9PR08MB6796:EE_
X-Microsoft-Antispam-PRVS:
	<DB9PR08MB6796CF84A468250C4AC033FAE4359@DB9PR08MB6796.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 eruaTOl52CZsRPhkZ7vJg55sGkAAjgX4sVA0Zr93un83qWLwBIX4FRXkZVvnWiS/aYvvRfLkBCBDbnpFxq7M3zCqmt58Dmzac9i8k6KpcaxV6jDhWKuMD/9iC2aX83JVbCT6+M2/2SaDWGeceL/wo670gl4dFviOUu4oYI5+wFNAxJOdzEQS83qHiiMHQxUZ4auhvSUuC4ukrpDQ8C9np14eUk8kUay9lCa8qllgChGvOLAeytSZhygJ+D6T5t+MOF+S4+mPTjwMOv0z0SQGHWfFFHMmMxzDr83kXa+gqphj2wx1Tos0xVob4pl6RE3aQLXfWsYlqNH/riE1zwJ1/S2goQJ/D1Fin1nN1Psx2DGbNTmU0u/k3yh4+sbSO8yNZ3mjtA7qNT6AKk2nakJX+IhL+sbA9Pvhc8KJPdEsIFeXL0V+Shqmoc4qeGbqR4I6nSC76+DH0HLHrkH5NJCd53fjlJCalIDh5leAw5NPKSKfaPEtluzTQlkoRu0qpnU5O01ivbMrocyumrAvrMxqYrcdc0OV5DA/aHT4nWRx0vz0D6jcX37JeTK/CysaXcCTN+NdwYyOZKfE82FZ+Wgiunzljo24Bbubx2b+AgDQtU3S9XvDIo4HhenkA1CbypnI2x8OzvPGKDiqK2vq81EumSQY5ukLopfX7/sS0h47AzavKJLasxPgiZqTcEYlKU80JF5Al3ix6nAhAlUvW8I9JNrfpAUo2lk0wsSsIkM1YPo=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR0801MB2125.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(30864003)(6512007)(83380400001)(2616005)(36756003)(7416002)(8936002)(5660300002)(186003)(2906002)(508600001)(54906003)(52116002)(6486002)(26005)(33656002)(53546011)(6666004)(66476007)(66946007)(8676002)(86362001)(4326008)(316002)(66556008)(6506007)(38100700002)(6916009)(44832011)(38350700002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5068
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT018.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	1522f4d1-26d4-4873-e56c-08d9f14553e4
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	RyzTUrXto0RtJ7hYE7rAHIo1PvmuyodUedQOIuWNhR7O+nelqYsxP8RFDdESIR8VsHDdIYI3mfQy55b/aqDAAIWG3p+nF6HHrH39Qe3yHvJ8hqbCxSGd6XiroVyR776WPJ1kg9lvRNFOYSdNH0iB+JqDJPSNSidgmCUWU3JQ4s36qLA1M7yoxJWankazayw8jS+822qVAwbElKvPDrxAH2TpNwRGQi1Tp3V4ZpuonhT8nvkZ4GTnSzxq6lLZozErrQrquQiGEw3ePr5Bgal6adGTQ4oVmE44v7peauHmyCFFXL3GbvJtRqev46xsnQu3AB1NrnSEe0qr4k1zFCWHDY2O80E3+Jt49kyxkApwMj6SVr/5WEJ1GeUvOKlVH9AMKTUpqEHIUzmVHoMe2VzLT2YibiY3i+I2ui2Dvqk34PZ+vw6tZsoxrUIUGsyfine09hH+5PskQAM5HWqBWM6rOJfA843Fvpk/ZQA0AqhssqE7brJ289oDh9zMDESPEuaACy7qltkNEmuglh0O5RLos8ggj1uyZIAxUimMrRKLG+/JSyFLsYBM1cUrEsDDtWwSC5VWW81t3XQAW0/iBapmTfqcZaK/uD7B96894SxMtE9WRtf+ZBosPY6qAMBEU68RZYi4fwIDyiEXnZf8+ISOl6/A/recPmKwpPdnBt3vgcYFH2E5MNmjt+ZOo1sJKXY+
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(33656002)(316002)(83380400001)(47076005)(40460700003)(6486002)(6666004)(54906003)(2616005)(70586007)(36860700001)(336012)(70206006)(508600001)(186003)(81166007)(6512007)(44832011)(6506007)(53546011)(5660300002)(26005)(6862004)(107886003)(8936002)(30864003)(2906002)(4326008)(8676002)(356005)(36756003)(86362001)(82310400004);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2022 12:10:45.0814
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: a633572d-fcc1-4fc0-3cd9-08d9f1455c28
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT018.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6796



> On 16 Feb 2022, at 02:45, Stefano Stabellini <sstabellini@kernel.org> wro=
te:
>=20
> On Tue, 15 Feb 2022, Luca Fancellu wrote:
>> Introduce an architecture specific way to create different cpupools
>> at boot time, this is particularly useful on ARM big.LITTLE system
>> where there might be the need to have different cpupools for each type
>> of core, but also systems using NUMA can have different cpu pools for
>> each node.
>>=20
>> The feature on arm relies on a specification of the cpupools from the
>> device tree to build pools and assign cpus to them.
>>=20
>> Documentation is created to explain the feature.
>>=20
>> Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
>> ---
>> docs/misc/arm/device-tree/cpupools.txt | 118 +++++++++++++++++++++++++
>> xen/arch/arm/Kconfig                   |   9 ++
>> xen/arch/arm/Makefile                  |   1 +
>> xen/arch/arm/cpupool.c                 | 118 +++++++++++++++++++++++++
>> xen/common/sched/cpupool.c             |   4 +-
>> xen/include/xen/sched.h                |  11 +++
>> 6 files changed, 260 insertions(+), 1 deletion(-)
>> create mode 100644 docs/misc/arm/device-tree/cpupools.txt
>> create mode 100644 xen/arch/arm/cpupool.c
>>=20
>> diff --git a/docs/misc/arm/device-tree/cpupools.txt b/docs/misc/arm/devi=
ce-tree/cpupools.txt
>> new file mode 100644
>> index 000000000000..7298b6394332
>> --- /dev/null
>> +++ b/docs/misc/arm/device-tree/cpupools.txt
>> @@ -0,0 +1,118 @@
>> +Boot time cpupools
>> +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>> +
>> +On arm, when BOOT_TIME_CPUPOOLS is enabled in the Xen configuration, it=
 is
>> +possible to create cpupools during boot phase by specifying them in the=
 device
>> +tree.
>> +
>> +Cpupools specification nodes shall be direct childs of /chosen node.
>> +Each cpupool node contains the following properties:
>> +
>> +- compatible (mandatory)
>> +
>> +    Must always include the compatiblity string: "xen,cpupool".
>> +
>> +- cpupool-id (mandatory)
>> +
>> +    Must be a positive integer number.
>=20

Hi Stefano,

Thank you for your review,

> Why is cpupool-id mandatory? It looks like it could be generated by Xen.
> Or is it actually better to have the user specify it anyway?
>=20

Yes at first I thought to automatically generate that, however I needed a s=
tructure
to map the id to the cpupool DT node. Here my doubt was about the size of t=
he
structure, because the user could even specify a cpupool for each cpu. I co=
uld allocate
It dynamically and free it after domUs creation in setup_xen.
What do you think could be the right way?
Or the dom0less guest could specify the id, but I like it more when using a=
 phandle to the
Xen,cpupool node.

>=20
>> +- cpupool-cpus (mandatory)
>> +
>> +    Must be a list of device tree phandle to nodes describing cpus (e.g=
. having
>> +    device_type =3D "cpu"), it can't be empty.
>> +
>> +- cpupool-sched (optional)
>> +
>> +    Must be a string having the name of a Xen scheduler, it has no effe=
ct when
>> +    used in conjunction of a cpupool-id equal to zero, in that case the
>> +    default Xen scheduler is selected (sched=3D<...> boot argument).
>=20
> I don't get why cpupool-id =3D=3D 0 should trigger a special cpupool-sche=
d
> behavior.

Cpupool with id 0 is embedded in Xen, it has its own special case handling =
in cpupool_create
that is giving it the default scheduler. I thought it was better to leave i=
t as it was, however the
cpupool0 scheduler can be modified using sched=3D boot args as it was befor=
e.

>=20
>=20
>> +Constraints
>> +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>> +
>> +The cpupool with id zero is implicitly created even if not specified, t=
hat pool
>> +must have at least one cpu assigned, otherwise Xen will stop.
>> +
>> +Every cpu brought up by Xen will be assigned to the cpupool with id zer=
o if it's
>> +not assigned to any other cpupool.
>> +
>> +If a cpu is assigned to a cpupool, but it's not brought up correctly, X=
en will
>> +stop.
>=20
> Thank you for documenting the constraints, but why do we have them?
> Imagine a user specifying 3 cpu pools and imagine the cpupool-id is
> optional and missing. We could take care of the cpupool-id generation in
> Xen and we could also assign the default scheduler everywhere
> cpupool-sched is not specified. Maybe I am missing something?

Yes we could make the cpupool-id optional, my doubts are in the fist commen=
t above.
Whenever the cpupool-sched is not specified, the current behaviour is to us=
e the default scheduler.

>=20
> Does cpupool0 has to exist? I guess the answer could be yes, but if it
> is specified as id of one of the pools we are fine, otherwise it could
> be automatically generated by Xen.

Yes cpupool0 needs to exists, however it is still generated by Xen regardle=
ss of the DT
specifications. In fact you could not specify in the DT any xen,cpupool com=
patible node
with the cpupool-id =3D=3D 0 and Xen will generate the cpupool0 anyway
(Xen internals are tied with the existence of a cpupool0).

>=20
> In any case, I don't think that cpupool0 has to have the default
> scheduler?

Ok I think I can create a function to assign a scheduler to the cpupool0 af=
ter its creation,
I would need to test it to be sure I don=E2=80=99t find something strange.

>=20
> My suggestion would be:
>=20
> - make cpupool-id optional
> - assign automatically cpupool-ids starting from 0
>    - respect cpupool-ids chosen by the user

Ok, it would start from 1 because cpupool0 always exists

> - if some CPUs are left out (not specified in any pool) add an extra cpup=
ool
>    - the extra cpupool doesn't have to be cpupool-id =3D=3D 0, it could b=
e
>      cpupool-id =3D=3D n
>    - the extra cpupool uses the default scheduler

I gave all the unassigned cpus to cpupool0 to reflect the current behaviour=
, so that
a user that doesn=E2=80=99t specify any xen,cpupool node ends up in a syste=
m reflecting the
current behaviour as the feature is not enabled.
However I can say, if no xen,cpupool nodes are found then assign cpus to cp=
upool0,
else assign them to a new cpupool and...

>=20
> If the user created cpupools in device tree covering all CPUs and also
> specified all cpupool-ids everywhere, and none of them are 0 (no cpupool
> in the system is cpupool0) then panic. (Assuming that cpupool0 is
> required.)

=E2=80=A6 panic if cpupool0 has no cpus.


Cheers,
Luca


>=20
>=20
>> +Examples
>> +=3D=3D=3D=3D=3D=3D=3D=3D
>> +
>> +A system having two types of core, the following device tree specificat=
ion will
>> +instruct Xen to have two cpupools:
>> +
>> +- The cpupool with id 0 will have 4 cpus assigned.
>> +- The cpupool with id 1 will have 2 cpus assigned.
>> +
>> +As can be seen from the example, cpupool_a has only two cpus assigned, =
but since
>> +there are two cpus unassigned, they are automatically assigned to cpupo=
ol with
>> +id zero. The following example can work only if hmp-unsafe=3D1 is passe=
d to Xen
>> +boot arguments, otherwise not all cores will be brought up by Xen and t=
he
>> +cpupool creation process will stop Xen.
>> +
>> +
>> +a72_1: cpu@0 {
>> +        compatible =3D "arm,cortex-a72";
>> +        reg =3D <0x0 0x0>;
>> +        device_type =3D "cpu";
>> +        [...]
>> +};
>> +
>> +a72_2: cpu@1 {
>> +        compatible =3D "arm,cortex-a72";
>> +        reg =3D <0x0 0x1>;
>> +        device_type =3D "cpu";
>> +        [...]
>> +};
>> +
>> +a53_1: cpu@100 {
>> +        compatible =3D "arm,cortex-a53";
>> +        reg =3D <0x0 0x100>;
>> +        device_type =3D "cpu";
>> +        [...]
>> +};
>> +
>> +a53_2: cpu@101 {
>> +        compatible =3D "arm,cortex-a53";
>> +        reg =3D <0x0 0x101>;
>> +        device_type =3D "cpu";
>> +        [...]
>> +};
>> +
>> +cpu@102 {
>> +        compatible =3D "arm,cortex-a53";
>> +        reg =3D <0x0 0x102>;
>> +        device_type =3D "cpu";
>> +        [...]
>> +};
>> +
>> +cpu@103 {
>> +        compatible =3D "arm,cortex-a53";
>> +        reg =3D <0x0 0x103>;
>> +        device_type =3D "cpu";
>> +        [...]
>> +};
>> +
>> +chosen {
>> +
>> +    cpupool_a {
>> +        compatible =3D "xen,cpupool";
>> +        cpupool-id =3D <0>;
>> +        cpupool-cpus =3D <&a53_1 &a53_2>;
>> +    };
>> +    cpupool_b {
>> +        compatible =3D "xen,cpupool";
>> +        cpupool-id =3D <1>;
>> +        cpupool-cpus =3D <&a72_1 &a72_2>;
>> +        cpupool-sched =3D "credit2";
>> +    };
>=20
> Question above notwithstanding, I like it!
>=20
>=20
>> +    [...]
>> +
>> +};
>> diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
>> index ecfa6822e4d3..64c2879513b7 100644
>> --- a/xen/arch/arm/Kconfig
>> +++ b/xen/arch/arm/Kconfig
>> @@ -33,6 +33,15 @@ config ACPI
>> 	  Advanced Configuration and Power Interface (ACPI) support for Xen is
>> 	  an alternative to device tree on ARM64.
>>=20
>> +config BOOT_TIME_CPUPOOLS
>> +	bool "Create cpupools at boot time"
>> +	depends on ARM
>> +	default n
>> +	help
>> +
>> +	  Creates cpupools during boot time and assigns cpus to them. Cpupools
>> +	  options can be specified in the device tree.
>> +
>> config GICV3
>> 	bool "GICv3 driver"
>> 	depends on ARM_64 && !NEW_VGIC
>> diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile
>> index d0dee10102b6..6165da4e77b4 100644
>> --- a/xen/arch/arm/Makefile
>> +++ b/xen/arch/arm/Makefile
>> @@ -13,6 +13,7 @@ obj-$(CONFIG_HAS_ALTERNATIVE) +=3D alternative.o
>> obj-y +=3D bootfdt.init.o
>> obj-y +=3D cpuerrata.o
>> obj-y +=3D cpufeature.o
>> +obj-$(CONFIG_BOOT_TIME_CPUPOOLS) +=3D cpupool.o
>> obj-y +=3D decode.o
>> obj-y +=3D device.o
>> obj-$(CONFIG_IOREQ_SERVER) +=3D dm.o
>> diff --git a/xen/arch/arm/cpupool.c b/xen/arch/arm/cpupool.c
>> new file mode 100644
>> index 000000000000..a9d5b94635b9
>> --- /dev/null
>> +++ b/xen/arch/arm/cpupool.c
>> @@ -0,0 +1,118 @@
>> +/* SPDX-License-Identifier: GPL-2.0 */
>> +/*
>> + * xen/arch/arm/cpupool.c
>> + *
>> + * Code to create cpupools at boot time for arm architecture.
>> + *
>> + * Copyright (C) 2022 Arm Ltd.
>> + */
>> +
>> +#include <xen/sched.h>
>> +
>> +static struct cpupool *__initdata pool_cpu_map[NR_CPUS];
>> +
>> +void __init arch_allocate_cpupools(const cpumask_t *cpu_online_map)
>> +{
>> +    const struct dt_device_node *chosen, *node;
>> +    unsigned int cpu_num, cpupool0_cpu_count =3D 0;
>> +    cpumask_t cpus_to_assign;
>> +
>> +    chosen =3D dt_find_node_by_path("/chosen");
>> +    if ( !chosen )
>> +        return;
>> +
>> +    cpumask_copy(&cpus_to_assign, cpu_online_map);
>> +
>> +    dt_for_each_child_node(chosen, node)
>> +    {
>> +        const struct dt_device_node *cpu_node;
>> +        unsigned int pool_id;
>> +        int i =3D 0, sched_id =3D -1;
>> +        const char* scheduler_name;
>> +        struct cpupool *pool =3D cpupool0;
>> +
>> +        if ( !dt_device_is_compatible(node, "xen,cpupool") )
>> +            continue;
>> +
>> +        if ( !dt_property_read_u32(node, "cpupool-id", &pool_id) )
>> +            panic("Missing cpupool-id property!\n");
>> +
>> +        if ( !dt_property_read_string(node, "cpupool-sched", &scheduler=
_name) )
>> +        {
>> +            sched_id =3D sched_get_id_by_name(scheduler_name);
>> +            if ( sched_id < 0 )
>> +                panic("Scheduler %s does not exists!\n", scheduler_name=
);
>> +        }
>> +
>> +        if ( pool_id )
>> +        {
>> +            pool =3D cpupool_create_pool(pool_id, sched_id);
>> +            if ( !pool )
>> +                panic("Error creating pool id %u!\n", pool_id);
>> +        }
>> +
>> +        cpu_node =3D dt_parse_phandle(node, "cpupool-cpus", 0);
>> +        if ( !cpu_node )
>> +            panic("Missing or empty cpupool-cpus property!\n");
>> +
>> +        while ( cpu_node )
>> +        {
>> +            register_t cpu_reg;
>> +            const __be32 *prop;
>> +
>> +            prop =3D dt_get_property(cpu_node, "reg", NULL);
>> +            if ( !prop )
>> +                panic("cpupool-cpus pointed node has no reg property!\n=
");
>> +
>> +            cpu_reg =3D dt_read_number(prop, dt_n_addr_cells(cpu_node))=
;
>> +
>> +            /* Check if the cpu is online and in the set to be assigned=
 */
>> +            for_each_cpu ( cpu_num, &cpus_to_assign )
>> +                if ( cpu_logical_map(cpu_num) =3D=3D cpu_reg )
>> +                    break;
>> +
>> +            if ( cpu_num >=3D nr_cpu_ids )
>> +                panic("Cpu found in %s is not online or it's assigned t=
wice!\n",
>> +                      dt_node_name(node));
>> +
>> +            pool_cpu_map[cpu_num] =3D pool;
>> +            cpumask_clear_cpu(cpu_num, &cpus_to_assign);
>> +
>> +            printk(XENLOG_INFO "CPU with MPIDR %"PRIregister" in Pool-%=
u.\n",
>> +                   cpu_reg, pool_id);
>> +
>> +            /* Keep track of how many cpus are assigned to Pool-0 */
>> +            if ( !pool_id )
>> +                cpupool0_cpu_count++;
>> +
>> +            cpu_node =3D dt_parse_phandle(node, "cpupool-cpus", ++i);
>> +        }
>> +    }
>> +
>> +    /* Assign every non assigned cpu to Pool-0 */
>> +    for_each_cpu ( cpu_num, &cpus_to_assign )
>> +    {
>> +        pool_cpu_map[cpu_num] =3D cpupool0;
>> +        cpupool0_cpu_count++;
>> +        printk(XENLOG_INFO "CPU with MPIDR %"PRIregister" in Pool-0.\n"=
,
>> +               cpu_logical_map(cpu_num));
>> +    }
>> +
>> +    if ( !cpupool0_cpu_count )
>> +        panic("No cpu assigned to cpupool0!\n");
>> +}
>> +
>> +struct cpupool *__init arch_get_cpupool(unsigned int cpu)
>> +{
>> +    return pool_cpu_map[cpu];
>> +}
>> +
>> +/*
>> + * Local variables:
>> + * mode: C
>> + * c-file-style: "BSD"
>> + * c-basic-offset: 4
>> + * tab-width: 4
>> + * indent-tabs-mode: nil
>> + * End:
>> + */
>> diff --git a/xen/common/sched/cpupool.c b/xen/common/sched/cpupool.c
>> index 4da12528d6b9..6013d75e2edd 100644
>> --- a/xen/common/sched/cpupool.c
>> +++ b/xen/common/sched/cpupool.c
>> @@ -1257,12 +1257,14 @@ static int __init cpupool_init(void)
>>     cpupool_put(cpupool0);
>>     register_cpu_notifier(&cpu_nfb);
>>=20
>> +    arch_allocate_cpupools(&cpu_online_map);
>> +
>>     spin_lock(&cpupool_lock);
>>=20
>>     cpumask_copy(&cpupool_free_cpus, &cpu_online_map);
>>=20
>>     for_each_cpu ( cpu, &cpupool_free_cpus )
>> -        cpupool_assign_cpu_locked(cpupool0, cpu);
>> +        cpupool_assign_cpu_locked(arch_get_cpupool(cpu), cpu);
>>=20
>>     spin_unlock(&cpupool_lock);
>>=20
>> diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
>> index a67a9eb2fe9d..dda7db2ba51f 100644
>> --- a/xen/include/xen/sched.h
>> +++ b/xen/include/xen/sched.h
>> @@ -1177,6 +1177,17 @@ extern void dump_runq(unsigned char key);
>>=20
>> void arch_do_physinfo(struct xen_sysctl_physinfo *pi);
>>=20
>> +#ifdef CONFIG_BOOT_TIME_CPUPOOLS
>> +void arch_allocate_cpupools(const cpumask_t *cpu_online_map);
>> +struct cpupool *arch_get_cpupool(unsigned int cpu);
>> +#else
>> +static inline void arch_allocate_cpupools(const cpumask_t *cpu_online_m=
ap) {}
>> +static inline struct cpupool *arch_get_cpupool(unsigned int cpu)
>> +{
>> +    return cpupool0;
>> +}
>> +#endif
>> +
>> #endif /* __SCHED_H__ */
>>=20
>> /*
>> --=20
>> 2.17.1



From xen-devel-bounces@lists.xenproject.org Wed Feb 16 12:24:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 12:24:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274084.469425 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKJLg-0002RQ-Cd; Wed, 16 Feb 2022 12:23:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274084.469425; Wed, 16 Feb 2022 12:23:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKJLg-0002RJ-93; Wed, 16 Feb 2022 12:23:56 +0000
Received: by outflank-mailman (input) for mailman id 274084;
 Wed, 16 Feb 2022 12:23:55 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=nrBo=S7=citrix.com=George.Dunlap@srs-se1.protection.inumbo.net>)
 id 1nKJLe-0002RC-SE
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 12:23:54 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4c9bfc7b-8f23-11ec-b215-9bbe72dcb22c;
 Wed, 16 Feb 2022 13:23:52 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4c9bfc7b-8f23-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645014233;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:mime-version;
  bh=IOBG0mozRR3ylbC1U79NcMu6uSkiP/h1NDKzeJcUcKc=;
  b=M1ARRRsiRTF9MdcQjT0g/8EtH0bWezPdvPTu5tDZcR0PUZi/LRSLLzFF
   uCv0382ND2KDJNDWQIxC0NFjoikDgzTmOcPip0tlZmWPWlC5x0HXd9JZp
   t+7lUffnay6ByL7lKgwJ9EY+mmaYiXuaPeWxLwY8SEAp2KyY+lxQjs6Yw
   8=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=hardfail (body hash did not verify [final]) header.i=@citrix.onmicrosoft.com
IronPort-SDR: WyRLp+phUGUkVr3/caxs/2Pg0CwCFDiccR0MdB97HpqLUssYPJoq52BXDzicO50R8J+rA8aJAn
 xHIJqkJ1l/azenYQ8Mk0tQbu+IToV/UScV0hurCH3BZaANMgjpJ7TCN1UrZ4qJRvmuJL8ClW7I
 IN73duJD9RKMR963sQ+ptSJn1CRWbeS1MrTQvf2C+nbvEeM7xtD/SKgGrJaJvv+CCGROjHOzmp
 PmcOHFI27qOe3TEXHVlPQbbDe8jcKY9PEAdLukMf9y1cfgDIqHjceSPoimvky02AFY+0tzioCz
 w+nTVXTbdW3YjpbGbaGaUsRe
X-SBRS: 5.1
X-MesageID: 64739947
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:viJiI64RFPrRXLBAcomosAxRtCXBchMFZxGqfqrLsTDasI4TYg02e
 lBvGjDRZK7OJyCgZYg1O70CxjoFu8PRx9cxGldr+XoxQSpH8JKcX96VcUqpZi6fccCfFhw7s
 JhCZIKacJ5sQnXQrEbza7Gw9ykmj6zYGeGgAeKeUswdqXeIbQ944f40s7Jp0uaE+OSEPj5hm
 e8eguWBNQX5hmEqbThLsfnSpUoztamp52xH5gZgPKFA4gCCyyhJAMoTK5/qIiqjSOG4PAIbq
 8Uvbl2d1jmEl/v4Ior9yt4XSqCOK1LrFVDmZkB+AsBOuTAf4HxiukoHHKBEMx0P0WzXx4kZJ
 Ohl7vRcdy94ZsUgp8xFO/VoO3kW0XpuoeKvzdCX6KR//mWeG5fe66wG4HIeZOX0zt1fE2BWn
 cH0HRhWBvy1a0Ba95rgIgVkrpxLwMAGp+rzsFk4pd3SJa5OrZwu38wmTDKXtds9rpkmIBrQW
 yYWQTh0cTH4Xy1JAGgGAb8kse6qgCDjegQN/Tp5pYJvi4TS5Al40byrO9vJYN2aA85Smy50p
 EqfoT6/WEtDcoXCl3zVqRpAhceW9c//cK0fE6e3+7hGnVuXz3Q7AxwKT1qr5/K+jyZSXvoBd
 xNPq3ty8sDe8mSmcfKibSWDmUW0hSERAoBTDf1msgq0n/+8DwGxWTFfE28phMYdnNQtWTUg2
 1uNntXoLT9iqruYTTSa7Lj8hSy2ETgYKykFfyBsZQkY59jupqkjgxSJScxseIa3hNDoHTD7w
 xiRsTMzwb4UiKYj/aih4UrOhT7qg5HTVxM0/S3eRGfj5QR8DKa1aort5VXF4PJoKIeCUkLHr
 HUCg9KZ7u0FEdeKjiPlfQkWNOj3vbDfamSa2AMxWcl6n9iwx5K9VYJL/RRGGHdvCPkVcBLzT
 UbRv1pN7aYGaRNGcpRLS462Ds0ry43pGtLkSu3YY7JyX3RhSOOU1HowPBDNhggBhGBpyPhiY
 snDLa5AGF5HUfwP8dagewsKPVbHLAgazHibe530xg/PPVG2NC/MEudt3Ldjg4kEAEK4TOf9r
 o432yiikUw3vAjCjs//q9N7wbcidyVTOHwOg5YLHtNv2DZOFmA7EOP2yrg8YYFjlKk9vr6Wo
 i3sBxYCmQuu3CevxeC2hpZLMu6HsXFX9yxTAMDRFQzwhyhLjXiHsM/ziKfbjZF4rbc+nJaYv
 tEOetmaA+Qnd9g00291UHUJl6Q7LE7DrVvXZ0KNOWFjF7Y9F12h0oK1JWPHqXhRZhdbQONj+
 tWIzB3Ae5MfSmxKVYCOAB5Z5wjq5iZ1dSMbdxagH+S/j222oNgwcH2u1KZqSyzOQD2arganO
 8+tKUpwjcHGopMv8cmPgqaBroyzFPB5EFYcFG7ehYta/wGDloZ66YMfAuuOYx7HU2b4pPera
 elPlqmuO/wbhlda9YF7Fu8zn6454tLuoZ5czxhlQyqXPwj6VOs4LynUx9RLu41M2qRd5Vm8V
 HWQ94QIIr6OIs7kTgIcfVJ3cuSZ2PgIsTDO9vBpcl7i7Sp68ePfA0VfNhWBkgJHK75xPN93y
 OstopdOuQe+lgArIpCNiSUNrzaAKXkJUqMGsJAGAdC01lp3mw8aOZGFU334+pCCbdlII3IGG
 D7MifqQnalYy2rDb2E3SSrH091CiMlcoxtN1lIDeQiEw4KXmv8t0RRN2j0rVQAJnA5f2ud+N
 2U3ZU14IaKCo2VhiMRZBj3+HghAAFuS+1DryktPn2rcFhH6WmvIJWw7GOCM4EFGrD4MImkFp
 OmVmDT/TDLnXMDtxS9jC0dqpsvqQcF16gCfytusGN6IHsVibDfo6kN0ibHkd/cz7RsNuXD6
IronPort-HdrOrdr: A9a23:Up4ji6DNdEirPsjlHegbsceALOsnbusQ8zAXPh9KJiC9I/b1qy
 nxppkmPEfP+UsssHFJo6HkBEDyewKhyXcV2/hfAV7GZmfbUQSTXfhfBOfZsl7d8mjFh5RgPM
 RbAuZD4b/LfCBHZK/BiWHSebdB/DDEytHSuQ639QY0cegAUdAF0+4NMHf8LqQAfnggOXNWLu
 v/2uN34x6bPVgHZMWyAXcIG8LZocfQqZ7gaRkaQzY69Qinl1qTmf/HOind+i1bfyJEwL8k/2
 SAuRf+/L+fv/ayzQKZ/3PP7q5RhMDqxrJ4dYyxY4kuW3bRYzSTFcFcso65zXQISSaUmREXee
 z30lUd1gJImjXsly+O0ELQMkLboUkTAjfZuCGlaD3Y0JfErXsBerp8rJMcfR3D50U6utZglK
 pNwmKCrpJSSQjNhSLn+rHzJltXftrdmwtSrQc/tQ0WbWIlUs4bkWXfxjIgLL4QWCbhrIw3Gu
 hnC8/RoP5QbFOBdnjc+m1i2salUHg/FgqPBhFqgL3Y7xFG2HRii0cIzs0WmXkNsJo7Vplf/u
 zBdqBljqtHQMMaZb90QO0BXcy0AGrQRg+kChPeHX33UKUcf37doZ/+57s4oOmsZZwT1ZM33I
 /MVVtJ3FRCMn4Gyff+qqGj3iq9MllVbA6dvf22vaIJyYEUbICbRBG+dA==
X-IronPort-AV: E=Sophos;i="5.88,373,1635220800"; 
   d="asc'?scan'208";a="64739947"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=EATn1/qh1FdD7XTATLN5HbxeSkU3HQc2GAzNtSX77Sz/EqXu+q7gQdJlzCLMjqFdlFLbLleSbvGfXBadQSe3x5hKUJ5Mo+54wfPRTIrCWWxlYvoc08YbMIWMssgMGmo7k/EHILP4CdGY4bqCzL1blAK3XZS2cjzawapgbMaC1KQtjmOGbiVv6/qpg02fg7TUC6iQPbCxQqmDkmZpIXaO3aCfsDOb5zYlu/RpFveUJLwLH+/l7r6CUTXQXHdC231qMRjQhjnmz07hJdWq8FvDzjQz9FeKzH8hpw568iwYDXEjMGIiI5EH3nQbSQfCLAlrEw2lo4gWzPfYigmq+MoQlw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ZslmnCZbH+Dwlon09I1JD2kLv+rewuSwj369UdN1pVI=;
 b=i6wtUpy4Qq8cxLN5VjSEVFm07ugJ/jY6EqMJ+EZ0LWoE8a2CpSeXVzFACRbthaOXDSoC+vZVsXBw65B0+yAv55S55BrIPB3VrUxUSJ2tjpRjUWBbtOwf1c3SPQ984W4z5qZuCCeeXpehg/aX3bqU8x7cMrdiiEybcRCzTubFlbGOW7bmO1UIzyGLIBoFWUNJHrg17X5ppiYeuUvgC/hTGhxwyRuxERA6z/WJCgSz71kawwkxyso4UczpcRHWY6dQmKYbz7Tr7CcJLbDllye49pkNarDAuOc1cYhpWOBgy7DFG9s+5D1OBeAJ0XHwXapWEc+fK/QE9l8ztqdPqQ1TIw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ZslmnCZbH+Dwlon09I1JD2kLv+rewuSwj369UdN1pVI=;
 b=EZLvLFGEe9UjeuJllK6oGroH8Q04z9elHb8ClA1qlhCQdwfWlJZqfV2FemUK7QA0WpdCG7bwNTV7miZC0XkVfpLdWqL8snZA3lvIZwF9xNbHSiT4TA6vCr0NLpp1CPbcKxngViAyQP/D6r1u9SvMgOmoY5j7GcsXYyEyySxwWtA=
From: George Dunlap <George.Dunlap@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Bertrand Marquis <Bertrand.Marquis@arm.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Andrew
 Cooper" <Andrew.Cooper3@citrix.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Wei Liu <wl@xen.org>, Roger Pau Monne
	<roger.pau@citrix.com>, Julien Grall <julien@xen.org>
Subject: Re: [PATCH v2] lib: extend ASSERT()
Thread-Topic: [PATCH v2] lib: extend ASSERT()
Thread-Index: AQHYE4shsIFDV42A206yi2y9mPx4ZqyVNw0AgADQCYCAAAHgAIAAIi+AgAACZYCAAAt2AA==
Date: Wed, 16 Feb 2022 12:23:47 +0000
Message-ID: <46408EAE-5EA4-4B22-B685-BA6D313B5D3A@citrix.com>
References: <75125344-b0e1-9663-4c1a-84bb35870fef@suse.com>
 <35d82770-66cf-e030-5bcc-3c030e4463d7@xen.org>
 <3F58400B-5151-42F2-8F39-109DDF50EE1E@arm.com>
 <a89223c8-f59a-24cc-96a7-e40feb28813f@suse.com>
 <DB014136-7797-4A61-9681-33A7D85403AA@citrix.com>
 <732e8e39-36c4-1651-61f3-9b55caf29fe8@suse.com>
In-Reply-To: <732e8e39-36c4-1651-61f3-9b55caf29fe8@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3693.60.0.1.1)
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: dfe9cd17-3778-4b17-9aed-08d9f1472ecd
x-ms-traffictypediagnostic: DM6PR03MB3468:EE_
x-microsoft-antispam-prvs: <DM6PR03MB3468EAD16E8DD45DFF3E667899359@DM6PR03MB3468.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:7219;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: akNKT0mw48qU/d5xiDa7mDfTOUhyObRGiv9keUy+tmNNivFmELONbjjQ/cMben5oihzucf/a6OCU++mS04g5BfUQAEs9mKRnkwq9DsH+jNXtqZBuUG3LlmBJp/lqEF/PEkpNKsbshYG5QKypg88k+C99zmr/ZrIq+XmGvE0URT4FC7PCKIhXjxFHGLbYJC+NlS8BeQ27AgoPbGhkmsl3B9xnAk7FCFCKvMD7DWmf4yxIm+PTXWgxfprHQnWGjf9jXH6ihvpfglkEVK6G3VFoRVftppfS32znMqI1sNHMAAvIHYDbbywiERM3Y/a8XtID3R0SFdHjR6Pv15ryaYlvwjQc+kgdcy6mb4Q3Qq+5gjLbNAPwWOp7TcSLkY1Kpc54+X82OVBWB5JwyBiTN7l7onH3Alz3g7YOjpjhcho9NvPG+YyI09dVYfw5PRLheBdR6O3vCMvPAY3ftJZGfjrmQbr/Z5gZTjkPOvej9LwsTTIdpIhdp+drKiw8gvMaugx4lKkloZ04olPY/9LLl9Z/NlnC5Mn9e1x0l5K+rFVG0V4B5QmladJsYAkhJygz9pftWVyJN43jCiamFH5rm1ZOqmj4rHnT4PF5k85GKw1WKxsQ1PD4FXPz8k1zkigTfKtSYN/mhLI7YB7lj7x4QuWk9QJ/VGeuAGP57r0rGmVpfU29M5yjVBhakCIdOeyVY0cU6Hi+EwbN5Yx4wOo7iZV/uCuHqM2CIZGBfd7oYxqVnYO3Y/HyHl/vZo6SglvIP6mq
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(82960400001)(66446008)(83380400001)(66556008)(5660300002)(64756008)(2906002)(316002)(66946007)(8676002)(122000001)(6512007)(33656002)(76116006)(26005)(4326008)(53546011)(186003)(6486002)(508600001)(6506007)(38100700002)(91956017)(66476007)(2616005)(54906003)(71200400001)(36756003)(8936002)(86362001)(38070700005)(99936003)(6916009)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?WkV5ZjdZVXlIWUZOZEhVZHBKY0xpVzBQV1IvQVNKUXg1QWVIcGtPeUtudUlv?=
 =?utf-8?B?RjM0ZkdpbDFsZjVGalgrWDZua3dmZm9JVmVqbHZibFhIWE1vYjdVMlF1dk1B?=
 =?utf-8?B?SitOeGw2Mk9RZzBKTSs5Y0tLSm9GdEFwYUFudW5rS1ZPUjRyK0VKdDB1S0dr?=
 =?utf-8?B?RURnZnJiSlpsTlFyY0NxTWlVN0lDOXJTUjRGSnlrZUt0dDdTQmlCejRKTTZi?=
 =?utf-8?B?b2JodzdkZFNpaXlob1E4NStkbU9HZGFLWnErc2JyWXlOZlVqK0tOUE5aeDc5?=
 =?utf-8?B?K01ZVDN6ZUhIZWp5ME5OUTc5NEVJeTNuTzE1UmdMOFVDSUZxamZRK21KMXNN?=
 =?utf-8?B?SDByTXFSdFpjZEJ3d0RjZ0dscEdFT1R1NWFFUDUxTDg4T3U2dFRoaXduUGJv?=
 =?utf-8?B?dE8zMXFhWUI0NTk1RE02TEN2WFRCYlN0R1djbWhRdHE3WnNGSnQvTUtkM3dX?=
 =?utf-8?B?R25VRFY3N3B1QXo3NFVvU3NNaEFOd1ptQkh0bFhsY09pRGpCY05tOS9IajFV?=
 =?utf-8?B?OUpsckNReEMvcUpDczk4WWVTYUxZWTVtZUhGejdLT3o0NnZNNmdxVE5ySUV3?=
 =?utf-8?B?c2lvL0ZiaWw0Ym9RK1FHQVNxdW9FR2srcEhuZ1dyeWZ2ZENlbmNITmRVTjN0?=
 =?utf-8?B?dTNYZFZ3R0FoZCttQXVZbGlLK055SmNzdzZXWklkL3JseHoyeFhkeGU4c3Zs?=
 =?utf-8?B?dXhQREhJcVBvSTBpd1ltVmhTVEdzVm1xR3I1aGZkblZRYm1tanpHQ2FmVFZr?=
 =?utf-8?B?UTZFdXlFdlZUNzV0aDRIdXl2cHg4ZW1SUEsxSWwzS2Q0SmJwaDN1MWRGd080?=
 =?utf-8?B?aWFuSTVreVpjUEVENzVJcXEwRHpVMytMYThMMFU4WDNwS1hzYjNyWVZtY0Ux?=
 =?utf-8?B?MXNWd3dnRm5zd2pjc0VoRi95NFRCYzR2U05mVVhnOGtNL2VJeEpQby8wbXhU?=
 =?utf-8?B?N1JvWnFYd2ZzZWN6RmwxVW5XenlsRjhRY0MxOTAyNTVwS1owOXIvTHg1clV4?=
 =?utf-8?B?cTB3ZGdDcXU2eUltTmNGVXdsN3ZYS2x5bCtFVGh3bUQ4UUh3WFF0S1NwSDFa?=
 =?utf-8?B?OS9EZjVtbnRBMU1udVhLaFR5dVlsM25vRTFaUzdFdlBxaVhtbVV1QUVuOTgy?=
 =?utf-8?B?Y2pOeld1bUE3TGFPUmhncENSa1dNU0IvcVBybUJJZmF3TEliSnIxdjVXMWo2?=
 =?utf-8?B?SUVMTlV2UjdtYXZvKzdaMXg4dU85dlhSc0J2K0p0RWJ6c2twV3BUbENUS3V5?=
 =?utf-8?B?ckhTajRzb09UYmpsWGk5WkpFb1c5VS9HRHpOWGQ0b3NWdEFKK0tMbDUwVG5h?=
 =?utf-8?B?TzNzc0c4MWJjN2pmaEdvejN6VVR2cm5RRzgxVGtiWXZ4VDVYZHcwdGFMK252?=
 =?utf-8?B?NDJRYWdFeERBb2JtcFZvTjNGdmNYVkNnN3lWVmdWR2kxcjJHclY3dUROazBa?=
 =?utf-8?B?RkdGdmp4R01ueXY3a1JxWWNmMCt1R1JyczlpYlcyc3RsUWRWaGo2Zk1jVjNq?=
 =?utf-8?B?RFZtSzRENVNSblFkRGUyUDcwZmlGRFlpcldzZ2Zid0lSdHBZSU9FVmM4NkI2?=
 =?utf-8?B?YUZxNHEyOGZnMDIxekY1Nk85QnlidDZvay9nbHFYY0F5T3hyaS9wTHFpVm5P?=
 =?utf-8?B?UXpONXgwbTFUajA3amdJOGdBMG1nV2JsSnlxSitFZ2FneFRFZFNrc1krano5?=
 =?utf-8?B?NUZlRnVxSnFZdFptWDRHSGE5eWdKNmlTRHYvYXUvQm5uMFREcVdiRm4rTjdZ?=
 =?utf-8?B?dzA0QUdPUWFQYmczd3FQdllTbGVWUjFtbklURmVvU3B0WWRFbkMyMmxMZ0NQ?=
 =?utf-8?B?NllzbWZSR0V1L3UvZWNhWTd5WUx0anlIelExQjU2OXJQR3grK2dHTTNiTlFt?=
 =?utf-8?B?dkhrdFFUR1NGaGxCckx3ZGF6eWY3bXVqWmFwRk9pcDZHVmc1TVVlMHE0OXQ4?=
 =?utf-8?B?ajRzMDRLRWErZTlEQXRZYlJFcXpCd0lDcmdSNFU1MTV0c3UvK3VmMkhadTBj?=
 =?utf-8?B?eitCbkx5M3JMUWFueU9qRVFXODFGd3MvNTcwSGFTc2d6ZmpZZHBkRW02VnMy?=
 =?utf-8?B?ODFGMDJxZm1maVRyTEJPcGJyU0ZXT0tuS256RlRvQWlEYjRPb1ZGWW5WVEZW?=
 =?utf-8?B?dmlvRDlOMFJ5TjcvSk1hL0xPaEp5dmxOZXpZbTNTSVFJb0pvajNNZlQ3VHdY?=
 =?utf-8?B?alJka1laNVRsVkpOOTNEVG1vYW5ra09CVEd1LzZWSGswTkxYeW5WeklkNFdK?=
 =?utf-8?Q?7sypfzYjyk9bFKQPTHxbthPEBQtf3btFcchZvHxe7A=3D?=
Content-Type: multipart/signed;
	boundary="Apple-Mail=_8A8214E3-19D3-43CE-A54A-B2288D06B6AE";
	protocol="application/pgp-signature";
	micalg=pgp-sha512
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dfe9cd17-3778-4b17-9aed-08d9f1472ecd
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Feb 2022 12:23:47.7502
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ABrp0SHTIsho7qgqZ6eaHmj88qCXFbBDVyZ4DzsfFjOZG6tlDFbttqm5fPCejm/TNu/vne6UjtZVKrVEENwR0gjHnoTr1RYxAKYVwigphzk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3468
X-OriginatorOrg: citrix.com

--Apple-Mail=_8A8214E3-19D3-43CE-A54A-B2288D06B6AE
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8



> On Feb 16, 2022, at 11:42 AM, Jan Beulich <jbeulich@suse.com> wrote:
>=20
> On 16.02.2022 12:34, George Dunlap wrote:
>=20
>> I am opposed to overloading =E2=80=9CASSERT=E2=80=9D for this new =
kind of macro; I think it would not only be unnecessarily confusing to =
people not familiar with our codebase, but it would be too easy for =
people to fail to notice which macro was being used.
>>=20
>> ASSERT_ACTION(condition, code) (or even ASSERT_OR_ACTION()) would be =
a bare minimum for me.
>>=20
>> But I can=E2=80=99t imagine that there are more than a handful of =
actions we might want to take, so defining a macro for each one =
shouldn=E2=80=99t be too burdensome.
>>=20
>> Furthermore, the very flexibility seems dangerous; you=E2=80=99re not =
seeing what actual code is generated, so it=E2=80=99s to easy to be =
=E2=80=9Cclever=E2=80=9D, and/or write code that ends up doing something =
different than you expect.
>>=20
>> At the moment I think ASSERT_OR_RETURN(condition, code), plus other =
new macros for the other behavior is needed, would be better.
>=20
> Hmm, while I see your point of things possibly looking confusing or
> unexpected, something like ASSERT_OR_RETURN() (shouldn't it be
> ASSERT_AND_RETURN()?) is imo less readable. In particular I dislike
> the larger amount of uppercase text. But yes, I could accept this
> as a compromise as it still seems better to me than the multi-line
> constructs we currently use.

I see what you=E2=80=99re saying with AND/OR; I personally still prefer =
OR but wouldn=E2=80=99t argue to hard against AND if others preferred =
it.

As far as I=E2=80=99m concerned, the fact that we=E2=80=99re reducing =
lines of code isn=E2=80=99t a reason to use this at all.  As our =
CODING_STYLE says, ASSERT() is just a louder printk.  We would never =
consider writing PRINTK_AND_RETURN(), and we would never consider =
writing a macro like CONDRET(condition, retval) to replace

if (condition)
    return retval;

The only justification for this kind of macro, in my opinion, is to =
avoid duplication errors; i.e. replacing your code segment with the =
following:

if (condition) {
    ASSERT(!condition);
    return foo;
}

is undesirable because there=E2=80=99s too much risk that the conditions =
will drift or be inverted incorrectly. But having control statements =
like =E2=80=98return=E2=80=99 and =E2=80=98continue=E2=80=99 in a macro =
is also undesirable in my opinion; I=E2=80=99m personally not sure which =
I find most undesirable.

I guess one advantage of something like ASSERT_OR(condition, return =
foo); or ASSERT_OR(condition, continue); is that searching for =
=E2=80=9Creturn=E2=80=9D or =E2=80=9Ccontinue=E2=80=9D will come up even =
if you=E2=80=99re doing a case-sensitive search.  But I=E2=80=99m still =
wary of unintended side effects.

Bertrand / Julien, any more thoughts?

 -George

--Apple-Mail=_8A8214E3-19D3-43CE-A54A-B2288D06B6AE
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="signature.asc"
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEj3+7SZ4EDefWZFyCshXHp8eEG+0FAmIM7NIACgkQshXHp8eE
G+0MrwgAjDmCq15MrTU7fJTqwpH6CfRwl5AW43eELgJ3cpZC5zeKsg5jtbhNYj0Q
Ejs0mv/oNCOuZg1zDdgcUG4XjU39te3sFJHF+75nI9nTrXKOVbx46yyGfSoNVEmd
PxAPxcySGRX2buTfkQJY928deC6MyakqMIzo79nN82AVJ6H2U2CMfYBwemuWU+OJ
P/mSpneqSBViOTJwTersOHrtFTX4rT3Mx7TlpxDAadHq1MsCpWRsz2G55XVvVD21
TQUmPFkj1luRFfmXzc1o7djmC/SMP5rk05bazrQ6PfivatoCvniHyDMS9oklAkul
ObJv/AyiP9FeBvnKJ5yCTMPdxODXHQ==
=hlW+
-----END PGP SIGNATURE-----

--Apple-Mail=_8A8214E3-19D3-43CE-A54A-B2288D06B6AE--


From xen-devel-bounces@lists.xenproject.org Wed Feb 16 12:25:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 12:25:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274093.469436 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKJNc-00037N-Ta; Wed, 16 Feb 2022 12:25:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274093.469436; Wed, 16 Feb 2022 12:25:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKJNc-00037G-QH; Wed, 16 Feb 2022 12:25:56 +0000
Received: by outflank-mailman (input) for mailman id 274093;
 Wed, 16 Feb 2022 12:25:55 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TMKw=S7=gmail.com=rjwysocki@srs-se1.protection.inumbo.net>)
 id 1nKJNb-000377-BF
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 12:25:55 +0000
Received: from mail-yb1-f182.google.com (mail-yb1-f182.google.com
 [209.85.219.182]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9533f134-8f23-11ec-b215-9bbe72dcb22c;
 Wed, 16 Feb 2022 13:25:53 +0100 (CET)
Received: by mail-yb1-f182.google.com with SMTP id y129so5474823ybe.7
 for <xen-devel@lists.xenproject.org>; Wed, 16 Feb 2022 04:25:54 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9533f134-8f23-11ec-b215-9bbe72dcb22c
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc:content-transfer-encoding;
        bh=ZzgKkF+Qi9uD0PohBja9X66WgBtIRyDp12JGMxNBcpY=;
        b=H5BkQ2we3A7U+dtK0KCoZ4Zu6SIAJK13H0WXiptdXlGRQzkYD3WqCGIshSoVzuccro
         JkIWamUWRXwDvYuAkuvIlG4JkhYhsyxqVuDKHowUkWaC6VZReJOFtJN9M7VQ9c5oKqI5
         xZKHGzUnDD8SzUDK2rtLyUBAnxoGoNGUOEebQjkcpwFs7F00dFYrVJxwXcGCZk/HRloY
         0/62z5nh7p1CujgggWDJcwY7EzvlJKcr3kYYbSXIvDErl/WUNxINXOPgrL+xHPnCvK7e
         T3YhdNFIxAhWjq7i5yegcJ5QL8kKKrQsKwe8ua0213I2HvPn5AT3ZL59GPZ1JYYTinWz
         aDvQ==
X-Gm-Message-State: AOAM531v1R8x6ikcrmpGVIVF8WBe5N2EMdizOrnjkFg82GNICSaoU9Ko
	dqnXc/OjlUIk7MmOyQS7td6W0iDXxhQKXQlI4Og=
X-Google-Smtp-Source: ABdhPJzgB2WXDlMNWyEW279no9A0knLc+PLldmsjtAqBW5sJWGuZ+ouM0fPGPUzKV7R9c8p8BV9gaIDPnZPFqeD/pjM=
X-Received: by 2002:a81:f008:0:b0:2d0:cd72:74e5 with SMTP id
 p8-20020a81f008000000b002d0cd7274e5mr2135032ywm.301.1645014353165; Wed, 16
 Feb 2022 04:25:53 -0800 (PST)
MIME-Version: 1.0
References: <20220130233718.21544-1-digetx@gmail.com> <635e8121-fca4-580c-6af5-d9317a2eee1b@gmail.com>
In-Reply-To: <635e8121-fca4-580c-6af5-d9317a2eee1b@gmail.com>
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: Wed, 16 Feb 2022 13:25:39 +0100
Message-ID: <CAJZ5v0g0MrBm2+GwctkB7kUyBEt6HTAexRCFFRmTF1UKDrVQ-g@mail.gmail.com>
Subject: Re: [PATCH v6 00/21] Introduce power-off+restart call chain API
To: Dmitry Osipenko <digetx@gmail.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>, 
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, linux-csky@vger.kernel.org, 
	linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, 
	"open list:BROADCOM NVRAM DRIVER" <linux-mips@vger.kernel.org>, linux-parisc@vger.kernel.org, 
	linux-riscv@lists.infradead.org, Linux-sh list <linux-sh@vger.kernel.org>, 
	xen-devel@lists.xenproject.org, 
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>, Linux PM <linux-pm@vger.kernel.org>, 
	linux-tegra <linux-tegra@vger.kernel.org>, Thierry Reding <thierry.reding@gmail.com>, 
	Jonathan Hunter <jonathanh@nvidia.com>, Russell King <linux@armlinux.org.uk>, 
	Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Guo Ren <guoren@kernel.org>, 
	Geert Uytterhoeven <geert@linux-m68k.org>, Greg Ungerer <gerg@linux-m68k.org>, 
	Joshua Thompson <funaho@jurai.org>, Thomas Bogendoerfer <tsbogend@alpha.franken.de>, 
	Sebastian Reichel <sre@kernel.org>, Linus Walleij <linus.walleij@linaro.org>, 
	Philipp Zabel <p.zabel@pengutronix.de>, Greentime Hu <green.hu@gmail.com>, 
	Vincent Chen <deanbo422@gmail.com>, 
	"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>, Helge Deller <deller@gmx.de>, 
	Michael Ellerman <mpe@ellerman.id.au>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, 
	Paul Mackerras <paulus@samba.org>, Paul Walmsley <paul.walmsley@sifive.com>, 
	Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, 
	Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>, 
	Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>, 
	Dave Hansen <dave.hansen@linux.intel.com>, "the arch/x86 maintainers" <x86@kernel.org>, 
	"H. Peter Anvin" <hpa@zytor.com>, Boris Ostrovsky <boris.ostrovsky@oracle.com>, 
	Juergen Gross <jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>, Len Brown <lenb@kernel.org>, 
	Santosh Shilimkar <ssantosh@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>, Liam Girdwood <lgirdwood@gmail.com>, 
	Mark Brown <broonie@kernel.org>, Pavel Machek <pavel@ucw.cz>, Lee Jones <lee.jones@linaro.org>, 
	Andrew Morton <akpm@linux-foundation.org>, Guenter Roeck <linux@roeck-us.net>, 
	Daniel Lezcano <daniel.lezcano@linaro.org>, 
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Ulf Hansson <ulf.hansson@linaro.org>, 
	alankao@andestech.com, "K . C . Kuen-Chern Lin" <kclin@andestech.com>, 
	=?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= <mirq-linux@rere.qmqm.pl>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Feb 15, 2022 at 11:00 PM Dmitry Osipenko <digetx@gmail.com> wrote:
>
> 31.01.2022 02:36, Dmitry Osipenko =D0=BF=D0=B8=D1=88=D0=B5=D1=82:
> > Problem
> > -------
> >
> > SoC devices require power-off call chaining functionality from kernel.
> > We have a widely used restart chaining provided by restart notifier API=
,
> > but nothing for power-off.
> >
> > Solution
> > --------
> >
> > Introduce new API that provides both restart and power-off call chains.
> >
> > Why combine restart with power-off? Because drivers often do both.
> > More practical to have API that provides both under the same roof.
> >
> > The new API is designed with simplicity and extensibility in mind.
> > It's built upon the existing restart and reboot APIs. The simplicity
> > is in new helper functions that are convenient for drivers. The
> > extensibility is in the design that doesn't hardcode callback
> > arguments, making easy to add new parameters and remove old.
> >
> > This is a third attempt to introduce the new API. First was made by
> > Guenter Roeck back in 2014, second was made by Thierry Reding in 2017.
> > In fact the work didn't stop and recently arm_pm_restart() was removed
> > from v5.14 kernel, which was a part of preparatory work started by
> > Guenter Roeck. I took into account experience and ideas from the
> > previous attempts, extended and polished them.
>
>
> Rafael and all, do you see anything critical that needs to be improved
> in this v6?
>
> Will be great if you could take this patchset via the power tree if it
> looks okay, or give an ack.

I need some more time for this, sorry.

I'm a bit concerned about seeing no response to this set from anyone.

It looks like multiple platforms may be affected by it in principle,
so doesn't anyone care?


From xen-devel-bounces@lists.xenproject.org Wed Feb 16 12:38:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 12:38:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274100.469447 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKJZG-0004eb-0a; Wed, 16 Feb 2022 12:37:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274100.469447; Wed, 16 Feb 2022 12:37:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKJZF-0004eU-Sa; Wed, 16 Feb 2022 12:37:57 +0000
Received: by outflank-mailman (input) for mailman id 274100;
 Wed, 16 Feb 2022 12:37:56 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=wbM1=S7=arm.com=Luca.Fancellu@srs-se1.protection.inumbo.net>)
 id 1nKJZE-0004eO-4k
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 12:37:56 +0000
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur02on0630.outbound.protection.outlook.com
 [2a01:111:f400:fe07::630])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 42e96830-8f25-11ec-8eb8-a37418f5ba1a;
 Wed, 16 Feb 2022 13:37:54 +0100 (CET)
Received: from AM5PR1001CA0064.EURPRD10.PROD.OUTLOOK.COM
 (2603:10a6:206:15::41) by DB6PR0802MB2390.eurprd08.prod.outlook.com
 (2603:10a6:4:9f::15) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Wed, 16 Feb
 2022 12:37:49 +0000
Received: from AM5EUR03FT051.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:206:15:cafe::61) by AM5PR1001CA0064.outlook.office365.com
 (2603:10a6:206:15::41) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.14 via Frontend
 Transport; Wed, 16 Feb 2022 12:37:49 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT051.mail.protection.outlook.com (10.152.16.246) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4975.11 via Frontend Transport; Wed, 16 Feb 2022 12:37:48 +0000
Received: ("Tessian outbound 826a6d8e58c3:v113");
 Wed, 16 Feb 2022 12:37:48 +0000
Received: from ffd2aeb60fab.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 F640DA0B-878E-4B26-AB88-E69A5AF7C5F2.1; 
 Wed, 16 Feb 2022 12:37:42 +0000
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ffd2aeb60fab.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 16 Feb 2022 12:37:42 +0000
Received: from VI1PR0801MB2125.eurprd08.prod.outlook.com
 (2603:10a6:800:5b::23) by AM4PR0802MB2353.eurprd08.prod.outlook.com
 (2603:10a6:200:63::16) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.14; Wed, 16 Feb
 2022 12:37:40 +0000
Received: from VI1PR0801MB2125.eurprd08.prod.outlook.com
 ([fe80::5531:4c33:a50c:ea0e]) by VI1PR0801MB2125.eurprd08.prod.outlook.com
 ([fe80::5531:4c33:a50c:ea0e%9]) with mapi id 15.20.4995.016; Wed, 16 Feb 2022
 12:37:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 42e96830-8f25-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=xa2aXVUDyj1ljokgDYvRMRwSkasiXElQNGzhd67PcB4=;
 b=hWCgU0k2nwfxDkOmmMusDTmQn5rRv3J5OUfyFJgU6fMuLVPQ1RsOOqJ2/0RX1Q3IiovqC7a/kRO4DwV/pOX88jxcexWXQGZ7uK2X6eaXoI9wMD3OHe+Fc5WcwmrNCDe8KsbSEHQ9TrnGXQ7VpR8qw2ab+Sh/KNftfGaOqpS4Z+k=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 663303f4835f8353
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=JXUvBbmW3KRE19TTBUgCDIfjsB/OWoCp9ZSMuu7IemLa0iVQxvg5jG+T16+mRN4Y++fDsY0CVsIymvB1Yrne7G/UCxLLT69MSbjI+EELTQ+8BMU7QWfQHJiwKcY5z5bcCt3a6J1r0iOtphHcME1451O9ekiwiovVQBf8/fOFT3nE+8gaVXgO7TMXAju+H19tga1b/RQLd7Eo8FEiqXm1a4Rzy5Ug90DulxTWo8dWP4v/bGrsYz5cao0n7zzfeCPDMin5hBDHBYEDqqkbbg8nGZkNzkZe7Q7TUaHz+quIZE7BYpYum+iJmcL/Ob8OJu4bHlC+Zvy4H6U2ZUH/ZwqV6A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=xa2aXVUDyj1ljokgDYvRMRwSkasiXElQNGzhd67PcB4=;
 b=MCSRvCgPguQfs2n5kNIf+3qrZ6sj2gtr8ozvTWxjTl1XqR4h37zVd7eAI2BrZB0HdC3HPDqzXcDjOVEAyOsLzFQ5B681lepMM5FDm6wfDHAHsek/vAxkZc4WprjOvWrnoPc7vfXiN+PRBcotFe0iuYOqubZIkpHTkWKfueihhb/CQsXq1QL7qlxHa9eh9NERKZC4G/3SBVOFzVDltReYCT3W2GgsrCmEYf1B8CWiop1gTRmNp+FWPVBo/V7hOTOshEEgi2sWrj1CkGYogowIhIHXamxZiOunMhnTvSEyKC2dkupwou3n+OCXlvsjkWvEJksc7h76NYCvvHWfw07D5w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=xa2aXVUDyj1ljokgDYvRMRwSkasiXElQNGzhd67PcB4=;
 b=hWCgU0k2nwfxDkOmmMusDTmQn5rRv3J5OUfyFJgU6fMuLVPQ1RsOOqJ2/0RX1Q3IiovqC7a/kRO4DwV/pOX88jxcexWXQGZ7uK2X6eaXoI9wMD3OHe+Fc5WcwmrNCDe8KsbSEHQ9TrnGXQ7VpR8qw2ab+Sh/KNftfGaOqpS4Z+k=
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
Content-Type: text/plain;
	charset=us-ascii
Subject: Re: [PATCH 4/5] xen/cpupool: Create different cpupools at boot time
From: Luca Fancellu <luca.fancellu@arm.com>
In-Reply-To: <779968b4-5985-06bc-be35-ce5b0b719930@suse.com>
Date: Wed, 16 Feb 2022 12:37:37 +0000
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
 Wei Chen <wei.chen@arm.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>,
 Dario Faggioli <dfaggioli@suse.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <E99BEEA5-863A-4780-95D0-C22A12263737@arm.com>
References: <20220215101551.23101-1-luca.fancellu@arm.com>
 <20220215101551.23101-5-luca.fancellu@arm.com>
 <d6f36774-ecb5-15f4-b0c0-6114724060e6@suse.com>
 <AC1B6659-FDCF-49A0-AB6E-EF2196C46D8C@arm.com>
 <779968b4-5985-06bc-be35-ce5b0b719930@suse.com>
To: Juergen Gross <jgross@suse.com>
X-Mailer: Apple Mail (2.3693.60.0.1.1)
X-ClientProxiedBy: LO2P265CA0464.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:a2::20) To VI1PR0801MB2125.eurprd08.prod.outlook.com
 (2603:10a6:800:5b::23)
MIME-Version: 1.0
X-MS-Office365-Filtering-Correlation-Id: adc70230-e4c3-4d94-43d5-08d9f14923f1
X-MS-TrafficTypeDiagnostic:
	AM4PR0802MB2353:EE_|AM5EUR03FT051:EE_|DB6PR0802MB2390:EE_
X-Microsoft-Antispam-PRVS:
	<DB6PR0802MB2390932FC63E616DF3F03F0CE4359@DB6PR0802MB2390.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 6VxXpJAM0AVUFyFmI89ycq0UB3ZtFXQ4pZz6itrA15AcRuWKDrmUk45fWBQxwN2F5slJbQri/RUyoeMc2OJqTtNCAY0pmbLBxbtSF7xOxf/IxELY1H13RExLUMY8vloaG8h+gb/n1A4wOCJ197iuC+nHu4a9g9/pN25SCGoLY0Sd3AaWbkMoLjIn2X4Z0yVl6a8TzgvIimXVvFyPL6twUCNQ4uQr4PYYRXAx9+13mdrHJHGRcGsWmzB/uaYqboT8jkp9loD1IwrRgqUNB0gkDZj6QOMduVRadLFG7IgFx+UUpte5fJgig8yWlY+R/h9Fv1DEsdajWInJ4WfiWBlje1xXSgOBxaDzOJWVPJxnPWXz78gwJ8PVdYChK8/rFjJ84R0YkOZsB9eC4NxLeMz1kfIBtpl2sgEV5P7rsbuIUKrlBNvUsZ8ZUTujf2HlWZUPf8EIdoKEKp1EFfjSSW7TmWbv/yb7CIpelQ0UeRVrRHWuE7CF5pNOFhY0iPme7HsY9A1hVEnPeDoCR1NMurZGxwH+G806YxCXQdYDjSNyuevA8BJYshotRenHLGfAGGouk+vQrPUuovxVIypIpoyilJ+IHBlfTJIXs6Ful1O3dMnZXAF2bGnjU9KQkx4QVGHg05rGpfixm3QCyVUay0ZLcKyTFlXAna3xOSe8L0HCVQxQB738fl2qIttdaQe4YdFyvir6vCzy3MTOBBTgSV3S6ZtFGu5W2cU+j5prA/rvkd/h4r2VKTSZENBNBkZSZAsj
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR0801MB2125.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(44832011)(66556008)(6486002)(66946007)(86362001)(66476007)(6506007)(2616005)(36756003)(6666004)(6512007)(53546011)(8676002)(26005)(7416002)(4326008)(52116002)(5660300002)(8936002)(2906002)(508600001)(83380400001)(38350700002)(38100700002)(6916009)(316002)(186003)(33656002)(54906003)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0802MB2353
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT051.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	25fd1a19-d771-4c74-8d8a-08d9f1491e5d
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Jjk3/558N5EreaeXXbbZkrzfCeJwUDaDNlg2uKuNaBgjbg55tCH5y8PjAotITZqBZfUKxkQn574it9huvcR3S4VI45N1G+TFvLTWoAVWd7XxiDRqXz5Vj94eA7Acoz18/yNBSakMuxt01bW4kqsxWWQv24bdY+oYHI6MfeCt5iM/M1p8jv/D0mu0kt1zm0NpOMYGgimRS+QK0iMz2IP/KMVMzOUqrJAPHUgiTD7B2Ge3RnNzN2DkGZqWz32BwJvAlktEKDYUadgTxvV163JWRwSzzBM4xlH8ueDN2QaP4sBK35m9FuHT3C10LiSRPWzYBiz7vhWomlce3n+ByH9DPmP9JxslzIGTP/dCvoxyFmiZqosMKQ+Th+oXPH+TATtZJFczltqGZJNHF6UuxWMbEGKcZWcnIv8O8Qv1FZIxNJlxm3vc8KiLdz3ZpTWp29FnfbQFt4jRihHqEgyLmR1GfTM374sWrHrtvDcs0rPZX+QsVGG41iwzUAsMDx1UZHG+KmVm4RJU12Fyyuo/rGJ56ZfWaG4QgzqyphZVhodi4H/tPwwfJDgB9Aj4KmEFeXl8o3isfxYNjKhMEWb/Ep5HjTUhcLJLiPFHl3y9xjv7QAUsopQjJhdzIWzUb/149KhjLsFa2Ks3ECB+DfK07NgvXSPooc7fkEXmjtk/c0mGr+2E1C3L2xYU2T3B0F3obI11
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(4326008)(86362001)(70206006)(70586007)(40460700003)(6486002)(508600001)(2616005)(36860700001)(8676002)(107886003)(186003)(44832011)(26005)(6862004)(36756003)(53546011)(6506007)(33656002)(6666004)(82310400004)(356005)(47076005)(336012)(81166007)(5660300002)(6512007)(8936002)(54906003)(83380400001)(316002)(2906002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2022 12:37:48.6462
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: adc70230-e4c3-4d94-43d5-08d9f14923f1
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT051.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2390



> On 16 Feb 2022, at 06:18, Juergen Gross <jgross@suse.com> wrote:
>=20
> On 15.02.22 18:56, Luca Fancellu wrote:
>>> On 15 Feb 2022, at 10:48, Juergen Gross <jgross@suse.com> wrote:
>>>=20
>>> On 15.02.22 11:15, Luca Fancellu wrote:
>>>> Introduce an architecture specific way to create different cpupools
>>>> at boot time, this is particularly useful on ARM big.LITTLE system
>>>> where there might be the need to have different cpupools for each type
>>>> of core, but also systems using NUMA can have different cpu pools for
>>>> each node.
>>>> The feature on arm relies on a specification of the cpupools from the
>>>> device tree to build pools and assign cpus to them.
>>>> Documentation is created to explain the feature.
>>>> Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
>>>=20
>>> IIRC I suggested to have the core functionality in common code in order
>>> to allow using boot time cpupool creation e.g. via commandline for x86,
>>> too.
>> Yes, however I think the parser to handle everything by command line wou=
ld
>> be huge due to input sanitisation and not easy enough as the DT, however
>> I see Hyperlaunch has plans to use DT on x86 so I guess it would be ok t=
o make
>> this feature common once the DT is available also on x86.
>=20
> Everything not being explicitly specific to Arm should be in common
> code. Think of the work in progress for Risc-V.

Ok I will put it in common and I will make the feature depend on HAS_DEVICE=
_TREE.

Thank you.

Cheers,
Luca

>=20
>=20
> Juergen
> <OpenPGP_0xB0DE9DD628BF132F.asc>



From xen-devel-bounces@lists.xenproject.org Wed Feb 16 12:55:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 12:55:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274108.469458 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKJq7-0006x5-Fw; Wed, 16 Feb 2022 12:55:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274108.469458; Wed, 16 Feb 2022 12:55:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKJq7-0006wy-Cc; Wed, 16 Feb 2022 12:55:23 +0000
Received: by outflank-mailman (input) for mailman id 274108;
 Wed, 16 Feb 2022 12:55:22 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=BoLq=S7=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nKJq6-0006ws-5q
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 12:55:22 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b27dde24-8f27-11ec-b215-9bbe72dcb22c;
 Wed, 16 Feb 2022 13:55:20 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 1227E21763;
 Wed, 16 Feb 2022 12:55:20 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A81E313B0A;
 Wed, 16 Feb 2022 12:55:19 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id p5VhJzf0DGJdXQAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 16 Feb 2022 12:55:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b27dde24-8f27-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1645016120; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=gQJ/FOU/OBDzBQ+DP+YdrS+fYXTN4ezvR/yaqHC6IvA=;
	b=DFLfUIrclvvPh1dbgiYpo0xcIHCuk5GAaAwP7yrmc3sFYCRSa+iimv7BNbfi2rSPywD387
	YP7kTbdER7DtQtXjy16OVCAfej3GNtW0Ayh/RAc9Lwx9Hw6LQ1xMCvOEeSKVgCcUhWKmYR
	mMxvd4yMP9HzfRg0KPH2CnMLBCnJMsU=
Message-ID: <44d2673b-2450-81cf-5d3e-9afb23ae09c6@suse.com>
Date: Wed, 16 Feb 2022 13:55:19 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Subject: Re: [PATCH 4/5] xen/cpupool: Create different cpupools at boot time
Content-Language: en-US
To: Luca Fancellu <luca.fancellu@arm.com>,
 Stefano Stabellini <sstabellini@kernel.org>
Cc: Xen-devel <xen-devel@lists.xenproject.org>, Wei Chen <wei.chen@arm.com>,
 Julien Grall <julien@xen.org>, Volodymyr Babchuk
 <Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>, Dario Faggioli <dfaggioli@suse.com>
References: <20220215101551.23101-1-luca.fancellu@arm.com>
 <20220215101551.23101-5-luca.fancellu@arm.com>
 <alpine.DEB.2.22.394.2202151827380.43738@ubuntu-linux-20-04-desktop>
 <53747C8B-681A-4474-B1DF-F08702322AB9@arm.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <53747C8B-681A-4474-B1DF-F08702322AB9@arm.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------alQ9vdTNmDSPU8J1MtfNMirk"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------alQ9vdTNmDSPU8J1MtfNMirk
Content-Type: multipart/mixed; boundary="------------2djNK4009U0uLsNdoMD4Iix4";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Luca Fancellu <luca.fancellu@arm.com>,
 Stefano Stabellini <sstabellini@kernel.org>
Cc: Xen-devel <xen-devel@lists.xenproject.org>, Wei Chen <wei.chen@arm.com>,
 Julien Grall <julien@xen.org>, Volodymyr Babchuk
 <Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>, Dario Faggioli <dfaggioli@suse.com>
Message-ID: <44d2673b-2450-81cf-5d3e-9afb23ae09c6@suse.com>
Subject: Re: [PATCH 4/5] xen/cpupool: Create different cpupools at boot time
References: <20220215101551.23101-1-luca.fancellu@arm.com>
 <20220215101551.23101-5-luca.fancellu@arm.com>
 <alpine.DEB.2.22.394.2202151827380.43738@ubuntu-linux-20-04-desktop>
 <53747C8B-681A-4474-B1DF-F08702322AB9@arm.com>
In-Reply-To: <53747C8B-681A-4474-B1DF-F08702322AB9@arm.com>

--------------2djNK4009U0uLsNdoMD4Iix4
Content-Type: multipart/mixed; boundary="------------fUaRchlecyt3jRs9acd9w00e"

--------------fUaRchlecyt3jRs9acd9w00e
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMTYuMDIuMjIgMTM6MTAsIEx1Y2EgRmFuY2VsbHUgd3JvdGU6DQo+IA0KPiANCj4+IE9u
IDE2IEZlYiAyMDIyLCBhdCAwMjo0NSwgU3RlZmFubyBTdGFiZWxsaW5pIDxzc3RhYmVsbGlu
aUBrZXJuZWwub3JnPiB3cm90ZToNCj4+DQo+PiBPbiBUdWUsIDE1IEZlYiAyMDIyLCBMdWNh
IEZhbmNlbGx1IHdyb3RlOg0KPj4+IEludHJvZHVjZSBhbiBhcmNoaXRlY3R1cmUgc3BlY2lm
aWMgd2F5IHRvIGNyZWF0ZSBkaWZmZXJlbnQgY3B1cG9vbHMNCj4+PiBhdCBib290IHRpbWUs
IHRoaXMgaXMgcGFydGljdWxhcmx5IHVzZWZ1bCBvbiBBUk0gYmlnLkxJVFRMRSBzeXN0ZW0N
Cj4+PiB3aGVyZSB0aGVyZSBtaWdodCBiZSB0aGUgbmVlZCB0byBoYXZlIGRpZmZlcmVudCBj
cHVwb29scyBmb3IgZWFjaCB0eXBlDQo+Pj4gb2YgY29yZSwgYnV0IGFsc28gc3lzdGVtcyB1
c2luZyBOVU1BIGNhbiBoYXZlIGRpZmZlcmVudCBjcHUgcG9vbHMgZm9yDQo+Pj4gZWFjaCBu
b2RlLg0KPj4+DQo+Pj4gVGhlIGZlYXR1cmUgb24gYXJtIHJlbGllcyBvbiBhIHNwZWNpZmlj
YXRpb24gb2YgdGhlIGNwdXBvb2xzIGZyb20gdGhlDQo+Pj4gZGV2aWNlIHRyZWUgdG8gYnVp
bGQgcG9vbHMgYW5kIGFzc2lnbiBjcHVzIHRvIHRoZW0uDQo+Pj4NCj4+PiBEb2N1bWVudGF0
aW9uIGlzIGNyZWF0ZWQgdG8gZXhwbGFpbiB0aGUgZmVhdHVyZS4NCj4+Pg0KPj4+IFNpZ25l
ZC1vZmYtYnk6IEx1Y2EgRmFuY2VsbHUgPGx1Y2EuZmFuY2VsbHVAYXJtLmNvbT4NCj4+PiAt
LS0NCj4+PiBkb2NzL21pc2MvYXJtL2RldmljZS10cmVlL2NwdXBvb2xzLnR4dCB8IDExOCAr
KysrKysrKysrKysrKysrKysrKysrKysrDQo+Pj4geGVuL2FyY2gvYXJtL0tjb25maWcgICAg
ICAgICAgICAgICAgICAgfCAgIDkgKysNCj4+PiB4ZW4vYXJjaC9hcm0vTWFrZWZpbGUgICAg
ICAgICAgICAgICAgICB8ICAgMSArDQo+Pj4geGVuL2FyY2gvYXJtL2NwdXBvb2wuYyAgICAg
ICAgICAgICAgICAgfCAxMTggKysrKysrKysrKysrKysrKysrKysrKysrKw0KPj4+IHhlbi9j
b21tb24vc2NoZWQvY3B1cG9vbC5jICAgICAgICAgICAgIHwgICA0ICstDQo+Pj4geGVuL2lu
Y2x1ZGUveGVuL3NjaGVkLmggICAgICAgICAgICAgICAgfCAgMTEgKysrDQo+Pj4gNiBmaWxl
cyBjaGFuZ2VkLCAyNjAgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQ0KPj4+IGNyZWF0
ZSBtb2RlIDEwMDY0NCBkb2NzL21pc2MvYXJtL2RldmljZS10cmVlL2NwdXBvb2xzLnR4dA0K
Pj4+IGNyZWF0ZSBtb2RlIDEwMDY0NCB4ZW4vYXJjaC9hcm0vY3B1cG9vbC5jDQo+Pj4NCj4+
PiBkaWZmIC0tZ2l0IGEvZG9jcy9taXNjL2FybS9kZXZpY2UtdHJlZS9jcHVwb29scy50eHQg
Yi9kb2NzL21pc2MvYXJtL2RldmljZS10cmVlL2NwdXBvb2xzLnR4dA0KPj4+IG5ldyBmaWxl
IG1vZGUgMTAwNjQ0DQo+Pj4gaW5kZXggMDAwMDAwMDAwMDAwLi43Mjk4YjYzOTQzMzINCj4+
PiAtLS0gL2Rldi9udWxsDQo+Pj4gKysrIGIvZG9jcy9taXNjL2FybS9kZXZpY2UtdHJlZS9j
cHVwb29scy50eHQNCj4+PiBAQCAtMCwwICsxLDExOCBAQA0KPj4+ICtCb290IHRpbWUgY3B1
cG9vbHMNCj4+PiArPT09PT09PT09PT09PT09PT09DQo+Pj4gKw0KPj4+ICtPbiBhcm0sIHdo
ZW4gQk9PVF9USU1FX0NQVVBPT0xTIGlzIGVuYWJsZWQgaW4gdGhlIFhlbiBjb25maWd1cmF0
aW9uLCBpdCBpcw0KPj4+ICtwb3NzaWJsZSB0byBjcmVhdGUgY3B1cG9vbHMgZHVyaW5nIGJv
b3QgcGhhc2UgYnkgc3BlY2lmeWluZyB0aGVtIGluIHRoZSBkZXZpY2UNCj4+PiArdHJlZS4N
Cj4+PiArDQo+Pj4gK0NwdXBvb2xzIHNwZWNpZmljYXRpb24gbm9kZXMgc2hhbGwgYmUgZGly
ZWN0IGNoaWxkcyBvZiAvY2hvc2VuIG5vZGUuDQo+Pj4gK0VhY2ggY3B1cG9vbCBub2RlIGNv
bnRhaW5zIHRoZSBmb2xsb3dpbmcgcHJvcGVydGllczoNCj4+PiArDQo+Pj4gKy0gY29tcGF0
aWJsZSAobWFuZGF0b3J5KQ0KPj4+ICsNCj4+PiArICAgIE11c3QgYWx3YXlzIGluY2x1ZGUg
dGhlIGNvbXBhdGlibGl0eSBzdHJpbmc6ICJ4ZW4sY3B1cG9vbCIuDQo+Pj4gKw0KPj4+ICst
IGNwdXBvb2wtaWQgKG1hbmRhdG9yeSkNCj4+PiArDQo+Pj4gKyAgICBNdXN0IGJlIGEgcG9z
aXRpdmUgaW50ZWdlciBudW1iZXIuDQo+Pg0KPiANCj4gSGkgU3RlZmFubywNCj4gDQo+IFRo
YW5rIHlvdSBmb3IgeW91ciByZXZpZXcsDQo+IA0KPj4gV2h5IGlzIGNwdXBvb2wtaWQgbWFu
ZGF0b3J5PyBJdCBsb29rcyBsaWtlIGl0IGNvdWxkIGJlIGdlbmVyYXRlZCBieSBYZW4uDQo+
PiBPciBpcyBpdCBhY3R1YWxseSBiZXR0ZXIgdG8gaGF2ZSB0aGUgdXNlciBzcGVjaWZ5IGl0
IGFueXdheT8NCj4+DQo+IA0KPiBZZXMgYXQgZmlyc3QgSSB0aG91Z2h0IHRvIGF1dG9tYXRp
Y2FsbHkgZ2VuZXJhdGUgdGhhdCwgaG93ZXZlciBJIG5lZWRlZCBhIHN0cnVjdHVyZQ0KPiB0
byBtYXAgdGhlIGlkIHRvIHRoZSBjcHVwb29sIERUIG5vZGUuIEhlcmUgbXkgZG91YnQgd2Fz
IGFib3V0IHRoZSBzaXplIG9mIHRoZQ0KPiBzdHJ1Y3R1cmUsIGJlY2F1c2UgdGhlIHVzZXIg
Y291bGQgZXZlbiBzcGVjaWZ5IGEgY3B1cG9vbCBmb3IgZWFjaCBjcHUuIEkgY291bGQgYWxs
b2NhdGUNCj4gSXQgZHluYW1pY2FsbHkgYW5kIGZyZWUgaXQgYWZ0ZXIgZG9tVXMgY3JlYXRp
b24gaW4gc2V0dXBfeGVuLg0KPiBXaGF0IGRvIHlvdSB0aGluayBjb3VsZCBiZSB0aGUgcmln
aHQgd2F5Pw0KPiBPciB0aGUgZG9tMGxlc3MgZ3Vlc3QgY291bGQgc3BlY2lmeSB0aGUgaWQs
IGJ1dCBJIGxpa2UgaXQgbW9yZSB3aGVuIHVzaW5nIGEgcGhhbmRsZSB0byB0aGUNCj4gWGVu
LGNwdXBvb2wgbm9kZS4NCj4gDQo+Pg0KPj4+ICstIGNwdXBvb2wtY3B1cyAobWFuZGF0b3J5
KQ0KPj4+ICsNCj4+PiArICAgIE11c3QgYmUgYSBsaXN0IG9mIGRldmljZSB0cmVlIHBoYW5k
bGUgdG8gbm9kZXMgZGVzY3JpYmluZyBjcHVzIChlLmcuIGhhdmluZw0KPj4+ICsgICAgZGV2
aWNlX3R5cGUgPSAiY3B1IiksIGl0IGNhbid0IGJlIGVtcHR5Lg0KPj4+ICsNCj4+PiArLSBj
cHVwb29sLXNjaGVkIChvcHRpb25hbCkNCj4+PiArDQo+Pj4gKyAgICBNdXN0IGJlIGEgc3Ry
aW5nIGhhdmluZyB0aGUgbmFtZSBvZiBhIFhlbiBzY2hlZHVsZXIsIGl0IGhhcyBubyBlZmZl
Y3Qgd2hlbg0KPj4+ICsgICAgdXNlZCBpbiBjb25qdW5jdGlvbiBvZiBhIGNwdXBvb2wtaWQg
ZXF1YWwgdG8gemVybywgaW4gdGhhdCBjYXNlIHRoZQ0KPj4+ICsgICAgZGVmYXVsdCBYZW4g
c2NoZWR1bGVyIGlzIHNlbGVjdGVkIChzY2hlZD08Li4uPiBib290IGFyZ3VtZW50KS4NCj4+
DQo+PiBJIGRvbid0IGdldCB3aHkgY3B1cG9vbC1pZCA9PSAwIHNob3VsZCB0cmlnZ2VyIGEg
c3BlY2lhbCBjcHVwb29sLXNjaGVkDQo+PiBiZWhhdmlvci4NCj4gDQo+IENwdXBvb2wgd2l0
aCBpZCAwIGlzIGVtYmVkZGVkIGluIFhlbiwgaXQgaGFzIGl0cyBvd24gc3BlY2lhbCBjYXNl
IGhhbmRsaW5nIGluIGNwdXBvb2xfY3JlYXRlDQo+IHRoYXQgaXMgZ2l2aW5nIGl0IHRoZSBk
ZWZhdWx0IHNjaGVkdWxlci4gSSB0aG91Z2h0IGl0IHdhcyBiZXR0ZXIgdG8gbGVhdmUgaXQg
YXMgaXQgd2FzLCBob3dldmVyIHRoZQ0KPiBjcHVwb29sMCBzY2hlZHVsZXIgY2FuIGJlIG1v
ZGlmaWVkIHVzaW5nIHNjaGVkPSBib290IGFyZ3MgYXMgaXQgd2FzIGJlZm9yZS4NCj4gDQo+
Pg0KPj4NCj4+PiArQ29uc3RyYWludHMNCj4+PiArPT09PT09PT09PT0NCj4+PiArDQo+Pj4g
K1RoZSBjcHVwb29sIHdpdGggaWQgemVybyBpcyBpbXBsaWNpdGx5IGNyZWF0ZWQgZXZlbiBp
ZiBub3Qgc3BlY2lmaWVkLCB0aGF0IHBvb2wNCj4+PiArbXVzdCBoYXZlIGF0IGxlYXN0IG9u
ZSBjcHUgYXNzaWduZWQsIG90aGVyd2lzZSBYZW4gd2lsbCBzdG9wLg0KPj4+ICsNCj4+PiAr
RXZlcnkgY3B1IGJyb3VnaHQgdXAgYnkgWGVuIHdpbGwgYmUgYXNzaWduZWQgdG8gdGhlIGNw
dXBvb2wgd2l0aCBpZCB6ZXJvIGlmIGl0J3MNCj4+PiArbm90IGFzc2lnbmVkIHRvIGFueSBv
dGhlciBjcHVwb29sLg0KPj4+ICsNCj4+PiArSWYgYSBjcHUgaXMgYXNzaWduZWQgdG8gYSBj
cHVwb29sLCBidXQgaXQncyBub3QgYnJvdWdodCB1cCBjb3JyZWN0bHksIFhlbiB3aWxsDQo+
Pj4gK3N0b3AuDQo+Pg0KPj4gVGhhbmsgeW91IGZvciBkb2N1bWVudGluZyB0aGUgY29uc3Ry
YWludHMsIGJ1dCB3aHkgZG8gd2UgaGF2ZSB0aGVtPw0KPj4gSW1hZ2luZSBhIHVzZXIgc3Bl
Y2lmeWluZyAzIGNwdSBwb29scyBhbmQgaW1hZ2luZSB0aGUgY3B1cG9vbC1pZCBpcw0KPj4g
b3B0aW9uYWwgYW5kIG1pc3NpbmcuIFdlIGNvdWxkIHRha2UgY2FyZSBvZiB0aGUgY3B1cG9v
bC1pZCBnZW5lcmF0aW9uIGluDQo+PiBYZW4gYW5kIHdlIGNvdWxkIGFsc28gYXNzaWduIHRo
ZSBkZWZhdWx0IHNjaGVkdWxlciBldmVyeXdoZXJlDQo+PiBjcHVwb29sLXNjaGVkIGlzIG5v
dCBzcGVjaWZpZWQuIE1heWJlIEkgYW0gbWlzc2luZyBzb21ldGhpbmc/DQo+IA0KPiBZZXMg
d2UgY291bGQgbWFrZSB0aGUgY3B1cG9vbC1pZCBvcHRpb25hbCwgbXkgZG91YnRzIGFyZSBp
biB0aGUgZmlzdCBjb21tZW50IGFib3ZlLg0KPiBXaGVuZXZlciB0aGUgY3B1cG9vbC1zY2hl
ZCBpcyBub3Qgc3BlY2lmaWVkLCB0aGUgY3VycmVudCBiZWhhdmlvdXIgaXMgdG8gdXNlIHRo
ZSBkZWZhdWx0IHNjaGVkdWxlci4NCj4gDQo+Pg0KPj4gRG9lcyBjcHVwb29sMCBoYXMgdG8g
ZXhpc3Q/IEkgZ3Vlc3MgdGhlIGFuc3dlciBjb3VsZCBiZSB5ZXMsIGJ1dCBpZiBpdA0KPj4g
aXMgc3BlY2lmaWVkIGFzIGlkIG9mIG9uZSBvZiB0aGUgcG9vbHMgd2UgYXJlIGZpbmUsIG90
aGVyd2lzZSBpdCBjb3VsZA0KPj4gYmUgYXV0b21hdGljYWxseSBnZW5lcmF0ZWQgYnkgWGVu
Lg0KPiANCj4gWWVzIGNwdXBvb2wwIG5lZWRzIHRvIGV4aXN0cywgaG93ZXZlciBpdCBpcyBz
dGlsbCBnZW5lcmF0ZWQgYnkgWGVuIHJlZ2FyZGxlc3Mgb2YgdGhlIERUDQo+IHNwZWNpZmlj
YXRpb25zLiBJbiBmYWN0IHlvdSBjb3VsZCBub3Qgc3BlY2lmeSBpbiB0aGUgRFQgYW55IHhl
bixjcHVwb29sIGNvbXBhdGlibGUgbm9kZQ0KPiB3aXRoIHRoZSBjcHVwb29sLWlkID09IDAg
YW5kIFhlbiB3aWxsIGdlbmVyYXRlIHRoZSBjcHVwb29sMCBhbnl3YXkNCj4gKFhlbiBpbnRl
cm5hbHMgYXJlIHRpZWQgd2l0aCB0aGUgZXhpc3RlbmNlIG9mIGEgY3B1cG9vbDApLg0KPiAN
Cj4+DQo+PiBJbiBhbnkgY2FzZSwgSSBkb24ndCB0aGluayB0aGF0IGNwdXBvb2wwIGhhcyB0
byBoYXZlIHRoZSBkZWZhdWx0DQo+PiBzY2hlZHVsZXI/DQo+IA0KPiBPayBJIHRoaW5rIEkg
Y2FuIGNyZWF0ZSBhIGZ1bmN0aW9uIHRvIGFzc2lnbiBhIHNjaGVkdWxlciB0byB0aGUgY3B1
cG9vbDAgYWZ0ZXIgaXRzIGNyZWF0aW9uLA0KPiBJIHdvdWxkIG5lZWQgdG8gdGVzdCBpdCB0
byBiZSBzdXJlIEkgZG9u4oCZdCBmaW5kIHNvbWV0aGluZyBzdHJhbmdlLg0KPiANCj4+DQo+
PiBNeSBzdWdnZXN0aW9uIHdvdWxkIGJlOg0KPj4NCj4+IC0gbWFrZSBjcHVwb29sLWlkIG9w
dGlvbmFsDQo+PiAtIGFzc2lnbiBhdXRvbWF0aWNhbGx5IGNwdXBvb2wtaWRzIHN0YXJ0aW5n
IGZyb20gMA0KPj4gICAgIC0gcmVzcGVjdCBjcHVwb29sLWlkcyBjaG9zZW4gYnkgdGhlIHVz
ZXINCj4gDQo+IE9rLCBpdCB3b3VsZCBzdGFydCBmcm9tIDEgYmVjYXVzZSBjcHVwb29sMCBh
bHdheXMgZXhpc3RzDQo+IA0KPj4gLSBpZiBzb21lIENQVXMgYXJlIGxlZnQgb3V0IChub3Qg
c3BlY2lmaWVkIGluIGFueSBwb29sKSBhZGQgYW4gZXh0cmEgY3B1cG9vbA0KPj4gICAgIC0g
dGhlIGV4dHJhIGNwdXBvb2wgZG9lc24ndCBoYXZlIHRvIGJlIGNwdXBvb2wtaWQgPT0gMCwg
aXQgY291bGQgYmUNCj4+ICAgICAgIGNwdXBvb2wtaWQgPT0gbg0KPj4gICAgIC0gdGhlIGV4
dHJhIGNwdXBvb2wgdXNlcyB0aGUgZGVmYXVsdCBzY2hlZHVsZXINCj4gDQo+IEkgZ2F2ZSBh
bGwgdGhlIHVuYXNzaWduZWQgY3B1cyB0byBjcHVwb29sMCB0byByZWZsZWN0IHRoZSBjdXJy
ZW50IGJlaGF2aW91ciwgc28gdGhhdA0KPiBhIHVzZXIgdGhhdCBkb2VzbuKAmXQgc3BlY2lm
eSBhbnkgeGVuLGNwdXBvb2wgbm9kZSBlbmRzIHVwIGluIGEgc3lzdGVtIHJlZmxlY3Rpbmcg
dGhlDQo+IGN1cnJlbnQgYmVoYXZpb3VyIGFzIHRoZSBmZWF0dXJlIGlzIG5vdCBlbmFibGVk
Lg0KPiBIb3dldmVyIEkgY2FuIHNheSwgaWYgbm8geGVuLGNwdXBvb2wgbm9kZXMgYXJlIGZv
dW5kIHRoZW4gYXNzaWduIGNwdXMgdG8gY3B1cG9vbDAsDQo+IGVsc2UgYXNzaWduIHRoZW0g
dG8gYSBuZXcgY3B1cG9vbCBhbmQuLi4NCj4gDQo+Pg0KPj4gSWYgdGhlIHVzZXIgY3JlYXRl
ZCBjcHVwb29scyBpbiBkZXZpY2UgdHJlZSBjb3ZlcmluZyBhbGwgQ1BVcyBhbmQgYWxzbw0K
Pj4gc3BlY2lmaWVkIGFsbCBjcHVwb29sLWlkcyBldmVyeXdoZXJlLCBhbmQgbm9uZSBvZiB0
aGVtIGFyZSAwIChubyBjcHVwb29sDQo+PiBpbiB0aGUgc3lzdGVtIGlzIGNwdXBvb2wwKSB0
aGVuIHBhbmljLiAoQXNzdW1pbmcgdGhhdCBjcHVwb29sMCBpcw0KPj4gcmVxdWlyZWQuKQ0K
PiANCj4g4oCmIHBhbmljIGlmIGNwdXBvb2wwIGhhcyBubyBjcHVzLg0KDQpUb2RheSBjcHUg
MCBpcyBhbHdheXMgbWVtYmVyIG9mIGNwdXBvb2wwLCBhbmQgY2hhbmdpbmcgdGhhdCBtaWdo
dCBiZQ0KaGFyZC4NCg0KDQpKdWVyZ2VuDQo=
--------------fUaRchlecyt3jRs9acd9w00e
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------fUaRchlecyt3jRs9acd9w00e--

--------------2djNK4009U0uLsNdoMD4Iix4--

--------------alQ9vdTNmDSPU8J1MtfNMirk
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmIM9DcFAwAAAAAACgkQsN6d1ii/Ey9U
RQf9EopFJNLixI3nBdIm4aOSH90VrbR8S4aEzOM2oNJDUEeYEe5pEvM5serMqdMJE4PxFyPwQDr1
dHL9cwVQFFf5xlFqgVQY7+zCypxJr+9er8cZME9JvLKla637mzfnXbL10kdOwNOBg1bCAOSY/65l
K3xntPtnynK7byFaMC4TjzOSGUrt9FOHPHZSM4OEKQiS+8S026LIh2SSLTd+KrkMX8+u2+pgGpbK
UidLDam+VOFy37vHDphSbYCJfF+IaLZ8euELjIDiGFld/AZaHwW5p+MKHnXJptXNi1SXRLPtgSUS
+3U53XOod4ZmbEDWzcrU4SjwHnpalXXNEEMNPkVLKA==
=C6Ks
-----END PGP SIGNATURE-----

--------------alQ9vdTNmDSPU8J1MtfNMirk--


From xen-devel-bounces@lists.xenproject.org Wed Feb 16 13:02:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 13:02:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274117.469468 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKJwc-0008S0-9u; Wed, 16 Feb 2022 13:02:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274117.469468; Wed, 16 Feb 2022 13:02:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKJwc-0008Rt-6k; Wed, 16 Feb 2022 13:02:06 +0000
Received: by outflank-mailman (input) for mailman id 274117;
 Wed, 16 Feb 2022 13:02:04 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=wbM1=S7=arm.com=Luca.Fancellu@srs-se1.protection.inumbo.net>)
 id 1nKJwa-0008Rn-GA
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 13:02:04 +0000
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur03on0620.outbound.protection.outlook.com
 [2a01:111:f400:fe09::620])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a16d9192-8f28-11ec-8eb8-a37418f5ba1a;
 Wed, 16 Feb 2022 14:02:02 +0100 (CET)
Received: from DB8PR04CA0021.eurprd04.prod.outlook.com (2603:10a6:10:110::31)
 by AM6PR08MB4755.eurprd08.prod.outlook.com (2603:10a6:20b:c2::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.16; Wed, 16 Feb
 2022 13:01:59 +0000
Received: from DB5EUR03FT054.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:110:cafe::99) by DB8PR04CA0021.outlook.office365.com
 (2603:10a6:10:110::31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11 via Frontend
 Transport; Wed, 16 Feb 2022 13:01:58 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT054.mail.protection.outlook.com (10.152.20.248) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4975.11 via Frontend Transport; Wed, 16 Feb 2022 13:01:58 +0000
Received: ("Tessian outbound 341d209a0e52:v113");
 Wed, 16 Feb 2022 13:01:58 +0000
Received: from 34074e011fec.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 46AF6948-0894-4B8E-AD2E-772B45101CD3.1; 
 Wed, 16 Feb 2022 13:01:51 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 34074e011fec.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 16 Feb 2022 13:01:51 +0000
Received: from VI1PR0801MB2125.eurprd08.prod.outlook.com
 (2603:10a6:800:5b::23) by DU0PR08MB7487.eurprd08.prod.outlook.com
 (2603:10a6:10:357::19) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.16; Wed, 16 Feb
 2022 13:01:50 +0000
Received: from VI1PR0801MB2125.eurprd08.prod.outlook.com
 ([fe80::5531:4c33:a50c:ea0e]) by VI1PR0801MB2125.eurprd08.prod.outlook.com
 ([fe80::5531:4c33:a50c:ea0e%9]) with mapi id 15.20.4995.016; Wed, 16 Feb 2022
 13:01:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a16d9192-8f28-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=UYnuAoGLLD+lAvfFx1UlXOA8KGYr5Gj5bO9LfnifR7M=;
 b=3GGJyLfhWjc4HjFGq+tNYgvt6h0IIXdtVEkSeWp3+R04hYSwAMDSp8NBRAom0VtrNKGKIuCaH03WgtQztIql3JDtYa+NNVxr4AhkxIgnGTDgBW28d5uV1e4AjpZ13xjiBZRwl4npBHRGFPf1gvVGDT24DQIC1mfkvCV3T+JnnA0=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 520dbcdd9541ea34
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=bS9oYQIDO8jrUCq1P2fAcGfPAz9YkIf9Rv/9Bpv3W9MhTtn6U9Vdk7kDbF4LkwXPd9XfoIRnN9FujKmJBhfTJKrFlLdVJKJYezPPh+vatT2c02nlVuRnKk+b2IWdieIEnfuuw9aWf6117Bn9nTVsPL06Z8ioLrLnn4iH7HciBFXvLpqWjEhrhkNOdE8gJWumGntJATBaVz+khkPCwcNUiOvAztRm6T/PORQJNqNt6ah7rxpRdD7DfF4XJUBGynZmsa4KiQTXveKGY5mCMYKJm7XFF62FyPyVLzgqbof9zQRg98CfR9R02wZ4IEcKBCLFoNXWel6EBEBwJE17D9/ooQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=UYnuAoGLLD+lAvfFx1UlXOA8KGYr5Gj5bO9LfnifR7M=;
 b=cmbU2vr75/BjWd6CiCSJEJn4CRllO8mum1a4HpBpzQvfsUTHlq3U2JFioJSuwinY3Fb9RuGjrwO69ImJEpCM1zhdq4rJIFSiAZSKs1QdAHPb+N7Xus00lGPTmwtCVCxh+ejE0lckUNHAk6Tzivkt9AAIU/9TsrsvyUzU4ZSApJ4qoH9nTGxwgJVq269wOj9pNXbkDvBJKzNTOba44YVMApi1KHdnwaZ6z4ZpyfoMMLkyOKrcZJ8dFIGW3VuL0AySET9rGa87o/PjAq6X2i1eJ9r7hewjzG0YGFAVd3kRnBcyYpuuOQb+II/TmhmnXWf8ssBaMNoJdOoGw0QpKjsz5w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=UYnuAoGLLD+lAvfFx1UlXOA8KGYr5Gj5bO9LfnifR7M=;
 b=3GGJyLfhWjc4HjFGq+tNYgvt6h0IIXdtVEkSeWp3+R04hYSwAMDSp8NBRAom0VtrNKGKIuCaH03WgtQztIql3JDtYa+NNVxr4AhkxIgnGTDgBW28d5uV1e4AjpZ13xjiBZRwl4npBHRGFPf1gvVGDT24DQIC1mfkvCV3T+JnnA0=
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
Content-Type: text/plain;
	charset=utf-8
Subject: Re: [PATCH 4/5] xen/cpupool: Create different cpupools at boot time
From: Luca Fancellu <luca.fancellu@arm.com>
In-Reply-To: <44d2673b-2450-81cf-5d3e-9afb23ae09c6@suse.com>
Date: Wed, 16 Feb 2022 13:01:44 +0000
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Xen-devel <xen-devel@lists.xenproject.org>,
 Wei Chen <wei.chen@arm.com>,
 Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>,
 Dario Faggioli <dfaggioli@suse.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <1D92168D-DFD6-4B1A-9079-FBFDDA9F2969@arm.com>
References: <20220215101551.23101-1-luca.fancellu@arm.com>
 <20220215101551.23101-5-luca.fancellu@arm.com>
 <alpine.DEB.2.22.394.2202151827380.43738@ubuntu-linux-20-04-desktop>
 <53747C8B-681A-4474-B1DF-F08702322AB9@arm.com>
 <44d2673b-2450-81cf-5d3e-9afb23ae09c6@suse.com>
To: Juergen Gross <jgross@suse.com>
X-Mailer: Apple Mail (2.3693.60.0.1.1)
X-ClientProxiedBy: LO2P265CA0025.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:61::13) To VI1PR0801MB2125.eurprd08.prod.outlook.com
 (2603:10a6:800:5b::23)
MIME-Version: 1.0
X-MS-Office365-Filtering-Correlation-Id: 6bdcef03-6ff2-41bc-710b-08d9f14c8404
X-MS-TrafficTypeDiagnostic:
	DU0PR08MB7487:EE_|DB5EUR03FT054:EE_|AM6PR08MB4755:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR08MB4755C6F07EAE4A1B6E0BC4EFE4359@AM6PR08MB4755.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 KyDMVndrItDtop5fF7UidqJ3KDpeQlAbR+qqK0B0o6E8F0VY7tSFwTN/6lNfSJWbO471M29+XtW+yNDkOpd7JMXjQP7TMEC3mMm6YYvRMoRsygFTFbYumlHBqEz63xUc9j2yR3KtYoYn6iyA0dbksAPv3XjZEBUTcDJ/MjZRe6bcjmlyZ+6EMwgqoHzwJr3q9pypVquv1TxmEWSySeE0r7LjwH/L2JZqc2BNaBFX3zen5UL290i9myR0hi1VAKygzfdawgVs6bdtYuokAOGPIB5kk1rvgwhKZ/cvVByq0e8255FJHNiaZTjmZtvgBs87xJZhRng//u4YSk17TLfh0r38+m5JKtui3ae+eLjt/sroG9Uov4EOx6uGkjIPxDmyaYJMOYsTYh1pTHEj+vuprxJ431A3NoZAplufpL6i1b9BjnRUBwMsWJpRV2m2lRc3tai5uBLp6MWByfm3NeLIYbbEW9GN+NCfX4ufVpJt9VnmRNYfpMMUR+f77eWU/FKfpcRqaF5QO04/WaSR9TjSUt32U9imvZlLSxF8VvnQk1z3uNiVROJbTyzFtgM2heIhH6wXO0lS1j3vdaj8JkR4yNXTX+TYGEyR0V7YqQEepqr7A0xjyXWuxQaVeW63ammnk6ilF68lZN8RU0CpMLU7ye9oSrtMA2lHCyrxLbTaoiaWi9EQkwywEBKYsJFC9V1fu/Me5N9aXpAojNsrYRTTpAurc/JTXrLpMm3Q6JE3idIrdBMzZxJWBidHvFp5HAI8
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR0801MB2125.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(7416002)(5660300002)(8936002)(66476007)(44832011)(2616005)(38350700002)(38100700002)(86362001)(36756003)(2906002)(6512007)(33656002)(26005)(186003)(508600001)(52116002)(6486002)(6506007)(53546011)(6666004)(8676002)(66556008)(4326008)(83380400001)(54906003)(66946007)(6916009)(316002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7487
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT054.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	61f719e4-1aa0-402c-0ae9-08d9f14c7ef1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	z0qrsjFs/1OD6BFWC7UJkVOzgLf/2HG4wCjzxUDbERWwBb/uv6Yxr2cKAhVqgl7cUo0sTF7Pa8MX/Ig25aPptv92o6GdccfbfaVzQH/FoBKvxMCq2V86Y6hIA+jLv6S0302I4yZOMvIbmGjpBHKQITvJkT+TiQaqa9dtngel0di2Qpx2piMyNzxzo9KLpZAzwlfOWm1tAukMmAhPcx4ScXUXRDDoCSCEhVY3k6xrgZ8TTfDUM/hQAiEZlbuHsAVq3BDMptymOFFbfyYVxH9Z+tfhESyrbFECEbhbtHmJc52PTYae4DEyVCfU3VCjCrqPFQHYcIUm42asvvgHNDbHlOa7mNS+v0S5ZMGTml6jFvbRZCbgcpL0BVLQles8vOi6T2iAtC7PPWEI263iW6jrtIaInI4lijwvakpZ49kccvYBjAagz2ngkaYHGzi1Yf7VeSSFsxyRpeze5/az4uevFx1M+3nGVqg4gJpSj6+KjvH+92EIv3CCYqf5gK/Gj33Fv/GvQLRa8kLcYFR0a55lCX0xkTRt1FEdhtH5fxFMgqqZRUP3qZkqXtCSHdV2Vjd1jgZkKgJEFxnGPqqD8hSJcOOsXuwCeY1LNI6mjTowMGiKQ5RW801uk57h+5YmaKghkXK6R4cFtQlhpDq33if+HLvLN2YVO2cYbda7OC6BASXHmNteFF3FIBor/tpMjr3T
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(8676002)(6862004)(4326008)(83380400001)(36756003)(40460700003)(70206006)(70586007)(53546011)(6512007)(6506007)(86362001)(2906002)(6666004)(81166007)(356005)(33656002)(82310400004)(6486002)(5660300002)(44832011)(2616005)(336012)(186003)(26005)(8936002)(508600001)(107886003)(36860700001)(316002)(54906003)(47076005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2022 13:01:58.4171
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 6bdcef03-6ff2-41bc-710b-08d9f14c8404
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT054.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4755



> On 16 Feb 2022, at 12:55, Juergen Gross <jgross@suse.com> wrote:
>=20
> On 16.02.22 13:10, Luca Fancellu wrote:
>>> On 16 Feb 2022, at 02:45, Stefano Stabellini <sstabellini@kernel.org> w=
rote:
>>>=20
>>> On Tue, 15 Feb 2022, Luca Fancellu wrote:
>>>> Introduce an architecture specific way to create different cpupools
>>>> at boot time, this is particularly useful on ARM big.LITTLE system
>>>> where there might be the need to have different cpupools for each type
>>>> of core, but also systems using NUMA can have different cpu pools for
>>>> each node.
>>>>=20
>>>> The feature on arm relies on a specification of the cpupools from the
>>>> device tree to build pools and assign cpus to them.
>>>>=20
>>>> Documentation is created to explain the feature.
>>>>=20
>>>> Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
>>>> ---
>>>> docs/misc/arm/device-tree/cpupools.txt | 118 +++++++++++++++++++++++++
>>>> xen/arch/arm/Kconfig                   |   9 ++
>>>> xen/arch/arm/Makefile                  |   1 +
>>>> xen/arch/arm/cpupool.c                 | 118 +++++++++++++++++++++++++
>>>> xen/common/sched/cpupool.c             |   4 +-
>>>> xen/include/xen/sched.h                |  11 +++
>>>> 6 files changed, 260 insertions(+), 1 deletion(-)
>>>> create mode 100644 docs/misc/arm/device-tree/cpupools.txt
>>>> create mode 100644 xen/arch/arm/cpupool.c
>>>>=20
>>>> diff --git a/docs/misc/arm/device-tree/cpupools.txt b/docs/misc/arm/de=
vice-tree/cpupools.txt
>>>> new file mode 100644
>>>> index 000000000000..7298b6394332
>>>> --- /dev/null
>>>> +++ b/docs/misc/arm/device-tree/cpupools.txt
>>>> @@ -0,0 +1,118 @@
>>>> +Boot time cpupools
>>>> +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>>>> +
>>>> +On arm, when BOOT_TIME_CPUPOOLS is enabled in the Xen configuration, =
it is
>>>> +possible to create cpupools during boot phase by specifying them in t=
he device
>>>> +tree.
>>>> +
>>>> +Cpupools specification nodes shall be direct childs of /chosen node.
>>>> +Each cpupool node contains the following properties:
>>>> +
>>>> +- compatible (mandatory)
>>>> +
>>>> +    Must always include the compatiblity string: "xen,cpupool".
>>>> +
>>>> +- cpupool-id (mandatory)
>>>> +
>>>> +    Must be a positive integer number.
>>>=20
>> Hi Stefano,
>> Thank you for your review,
>>> Why is cpupool-id mandatory? It looks like it could be generated by Xen=
.
>>> Or is it actually better to have the user specify it anyway?
>>>=20
>> Yes at first I thought to automatically generate that, however I needed =
a structure
>> to map the id to the cpupool DT node. Here my doubt was about the size o=
f the
>> structure, because the user could even specify a cpupool for each cpu. I=
 could allocate
>> It dynamically and free it after domUs creation in setup_xen.
>> What do you think could be the right way?
>> Or the dom0less guest could specify the id, but I like it more when usin=
g a phandle to the
>> Xen,cpupool node.
>>>=20
>>>> +- cpupool-cpus (mandatory)
>>>> +
>>>> +    Must be a list of device tree phandle to nodes describing cpus (e=
.g. having
>>>> +    device_type =3D "cpu"), it can't be empty.
>>>> +
>>>> +- cpupool-sched (optional)
>>>> +
>>>> +    Must be a string having the name of a Xen scheduler, it has no ef=
fect when
>>>> +    used in conjunction of a cpupool-id equal to zero, in that case t=
he
>>>> +    default Xen scheduler is selected (sched=3D<...> boot argument).
>>>=20
>>> I don't get why cpupool-id =3D=3D 0 should trigger a special cpupool-sc=
hed
>>> behavior.
>> Cpupool with id 0 is embedded in Xen, it has its own special case handli=
ng in cpupool_create
>> that is giving it the default scheduler. I thought it was better to leav=
e it as it was, however the
>> cpupool0 scheduler can be modified using sched=3D boot args as it was be=
fore.
>>>=20
>>>=20
>>>> +Constraints
>>>> +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>>>> +
>>>> +The cpupool with id zero is implicitly created even if not specified,=
 that pool
>>>> +must have at least one cpu assigned, otherwise Xen will stop.
>>>> +
>>>> +Every cpu brought up by Xen will be assigned to the cpupool with id z=
ero if it's
>>>> +not assigned to any other cpupool.
>>>> +
>>>> +If a cpu is assigned to a cpupool, but it's not brought up correctly,=
 Xen will
>>>> +stop.
>>>=20
>>> Thank you for documenting the constraints, but why do we have them?
>>> Imagine a user specifying 3 cpu pools and imagine the cpupool-id is
>>> optional and missing. We could take care of the cpupool-id generation i=
n
>>> Xen and we could also assign the default scheduler everywhere
>>> cpupool-sched is not specified. Maybe I am missing something?
>> Yes we could make the cpupool-id optional, my doubts are in the fist com=
ment above.
>> Whenever the cpupool-sched is not specified, the current behaviour is to=
 use the default scheduler.
>>>=20
>>> Does cpupool0 has to exist? I guess the answer could be yes, but if it
>>> is specified as id of one of the pools we are fine, otherwise it could
>>> be automatically generated by Xen.
>> Yes cpupool0 needs to exists, however it is still generated by Xen regar=
dless of the DT
>> specifications. In fact you could not specify in the DT any xen,cpupool =
compatible node
>> with the cpupool-id =3D=3D 0 and Xen will generate the cpupool0 anyway
>> (Xen internals are tied with the existence of a cpupool0).
>>>=20
>>> In any case, I don't think that cpupool0 has to have the default
>>> scheduler?
>> Ok I think I can create a function to assign a scheduler to the cpupool0=
 after its creation,
>> I would need to test it to be sure I don=E2=80=99t find something strang=
e.
>>>=20
>>> My suggestion would be:
>>>=20
>>> - make cpupool-id optional
>>> - assign automatically cpupool-ids starting from 0
>>>    - respect cpupool-ids chosen by the user
>> Ok, it would start from 1 because cpupool0 always exists
>>> - if some CPUs are left out (not specified in any pool) add an extra cp=
upool
>>>    - the extra cpupool doesn't have to be cpupool-id =3D=3D 0, it could=
 be
>>>      cpupool-id =3D=3D n
>>>    - the extra cpupool uses the default scheduler
>> I gave all the unassigned cpus to cpupool0 to reflect the current behavi=
our, so that
>> a user that doesn=E2=80=99t specify any xen,cpupool node ends up in a sy=
stem reflecting the
>> current behaviour as the feature is not enabled.
>> However I can say, if no xen,cpupool nodes are found then assign cpus to=
 cpupool0,
>> else assign them to a new cpupool and...
>>>=20
>>> If the user created cpupools in device tree covering all CPUs and also
>>> specified all cpupool-ids everywhere, and none of them are 0 (no cpupoo=
l
>>> in the system is cpupool0) then panic. (Assuming that cpupool0 is
>>> required.)
>> =E2=80=A6 panic if cpupool0 has no cpus.
>=20
> Today cpu 0 is always member of cpupool0, and changing that might be
> hard.

Oh, are you sure? I did some test in the past for this serie using a Juno b=
oard,
giving to cpupool0 only a72 cores and the a53 cores in another cpupool, my =
Juno
firmware configuration makes Xen having the boot cpu (cpu 0) to be one of t=
he a53
and it was working fine. But it was long time ago so I would need to try it=
 again.

>=20
>=20
> Juergen
> <OpenPGP_0xB0DE9DD628BF132F.asc>



From xen-devel-bounces@lists.xenproject.org Wed Feb 16 13:07:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 13:07:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274124.469479 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKK1e-0000fx-V6; Wed, 16 Feb 2022 13:07:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274124.469479; Wed, 16 Feb 2022 13:07:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKK1e-0000fq-S8; Wed, 16 Feb 2022 13:07:18 +0000
Received: by outflank-mailman (input) for mailman id 274124;
 Wed, 16 Feb 2022 13:07:17 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=BoLq=S7=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nKK1c-0000fk-Rv
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 13:07:16 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5cae221b-8f29-11ec-8eb8-a37418f5ba1a;
 Wed, 16 Feb 2022 14:07:15 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 268241F383;
 Wed, 16 Feb 2022 13:07:15 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id AA38513B0A;
 Wed, 16 Feb 2022 13:07:14 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id UT3wJwL3DGIkZAAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 16 Feb 2022 13:07:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5cae221b-8f29-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1645016835; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=SUTQuutlbqGH5XGZV+1gUsZX1dIcojU1Q12se0e3hsY=;
	b=H7t6/4AD72MPL8V5iln/7axsOx8sjBOvTkpV/VKOn4xAIQqbarjHDyvuiJnSZoUFW2BfAl
	SLBhGR+OdOokCEpkrdZOl/5k07A1QAivCiKLZwzl+l5hrsA2wl62nS+CwZ10HTwzrHa/U3
	j0Y8cxyiBAmh4Wy+KfWaQl037bkaOr4=
Message-ID: <69d80e47-ad4a-5fa7-acdb-96da6c9598de@suse.com>
Date: Wed, 16 Feb 2022 14:07:14 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Subject: Re: [PATCH 4/5] xen/cpupool: Create different cpupools at boot time
Content-Language: en-US
To: Luca Fancellu <luca.fancellu@arm.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Xen-devel <xen-devel@lists.xenproject.org>, Wei Chen <wei.chen@arm.com>,
 Julien Grall <julien@xen.org>, Volodymyr Babchuk
 <Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>, Dario Faggioli <dfaggioli@suse.com>
References: <20220215101551.23101-1-luca.fancellu@arm.com>
 <20220215101551.23101-5-luca.fancellu@arm.com>
 <alpine.DEB.2.22.394.2202151827380.43738@ubuntu-linux-20-04-desktop>
 <53747C8B-681A-4474-B1DF-F08702322AB9@arm.com>
 <44d2673b-2450-81cf-5d3e-9afb23ae09c6@suse.com>
 <1D92168D-DFD6-4B1A-9079-FBFDDA9F2969@arm.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <1D92168D-DFD6-4B1A-9079-FBFDDA9F2969@arm.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------e3l56HugvGX0TaqW7JqvortL"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------e3l56HugvGX0TaqW7JqvortL
Content-Type: multipart/mixed; boundary="------------RWs5vHXUoPlS9rZSb0xQiggU";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Luca Fancellu <luca.fancellu@arm.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Xen-devel <xen-devel@lists.xenproject.org>, Wei Chen <wei.chen@arm.com>,
 Julien Grall <julien@xen.org>, Volodymyr Babchuk
 <Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>, Dario Faggioli <dfaggioli@suse.com>
Message-ID: <69d80e47-ad4a-5fa7-acdb-96da6c9598de@suse.com>
Subject: Re: [PATCH 4/5] xen/cpupool: Create different cpupools at boot time
References: <20220215101551.23101-1-luca.fancellu@arm.com>
 <20220215101551.23101-5-luca.fancellu@arm.com>
 <alpine.DEB.2.22.394.2202151827380.43738@ubuntu-linux-20-04-desktop>
 <53747C8B-681A-4474-B1DF-F08702322AB9@arm.com>
 <44d2673b-2450-81cf-5d3e-9afb23ae09c6@suse.com>
 <1D92168D-DFD6-4B1A-9079-FBFDDA9F2969@arm.com>
In-Reply-To: <1D92168D-DFD6-4B1A-9079-FBFDDA9F2969@arm.com>

--------------RWs5vHXUoPlS9rZSb0xQiggU
Content-Type: multipart/mixed; boundary="------------IWY3wwzbe04gZE0J09kZbr2u"

--------------IWY3wwzbe04gZE0J09kZbr2u
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMTYuMDIuMjIgMTQ6MDEsIEx1Y2EgRmFuY2VsbHUgd3JvdGU6DQo+IA0KPiANCj4+IE9u
IDE2IEZlYiAyMDIyLCBhdCAxMjo1NSwgSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29t
PiB3cm90ZToNCj4+DQo+PiBPbiAxNi4wMi4yMiAxMzoxMCwgTHVjYSBGYW5jZWxsdSB3cm90
ZToNCj4+Pj4gT24gMTYgRmViIDIwMjIsIGF0IDAyOjQ1LCBTdGVmYW5vIFN0YWJlbGxpbmkg
PHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+IHdyb3RlOg0KPj4+Pg0KPj4+PiBPbiBUdWUsIDE1
IEZlYiAyMDIyLCBMdWNhIEZhbmNlbGx1IHdyb3RlOg0KPj4+Pj4gSW50cm9kdWNlIGFuIGFy
Y2hpdGVjdHVyZSBzcGVjaWZpYyB3YXkgdG8gY3JlYXRlIGRpZmZlcmVudCBjcHVwb29scw0K
Pj4+Pj4gYXQgYm9vdCB0aW1lLCB0aGlzIGlzIHBhcnRpY3VsYXJseSB1c2VmdWwgb24gQVJN
IGJpZy5MSVRUTEUgc3lzdGVtDQo+Pj4+PiB3aGVyZSB0aGVyZSBtaWdodCBiZSB0aGUgbmVl
ZCB0byBoYXZlIGRpZmZlcmVudCBjcHVwb29scyBmb3IgZWFjaCB0eXBlDQo+Pj4+PiBvZiBj
b3JlLCBidXQgYWxzbyBzeXN0ZW1zIHVzaW5nIE5VTUEgY2FuIGhhdmUgZGlmZmVyZW50IGNw
dSBwb29scyBmb3INCj4+Pj4+IGVhY2ggbm9kZS4NCj4+Pj4+DQo+Pj4+PiBUaGUgZmVhdHVy
ZSBvbiBhcm0gcmVsaWVzIG9uIGEgc3BlY2lmaWNhdGlvbiBvZiB0aGUgY3B1cG9vbHMgZnJv
bSB0aGUNCj4+Pj4+IGRldmljZSB0cmVlIHRvIGJ1aWxkIHBvb2xzIGFuZCBhc3NpZ24gY3B1
cyB0byB0aGVtLg0KPj4+Pj4NCj4+Pj4+IERvY3VtZW50YXRpb24gaXMgY3JlYXRlZCB0byBl
eHBsYWluIHRoZSBmZWF0dXJlLg0KPj4+Pj4NCj4+Pj4+IFNpZ25lZC1vZmYtYnk6IEx1Y2Eg
RmFuY2VsbHUgPGx1Y2EuZmFuY2VsbHVAYXJtLmNvbT4NCj4+Pj4+IC0tLQ0KPj4+Pj4gZG9j
cy9taXNjL2FybS9kZXZpY2UtdHJlZS9jcHVwb29scy50eHQgfCAxMTggKysrKysrKysrKysr
KysrKysrKysrKysrKw0KPj4+Pj4geGVuL2FyY2gvYXJtL0tjb25maWcgICAgICAgICAgICAg
ICAgICAgfCAgIDkgKysNCj4+Pj4+IHhlbi9hcmNoL2FybS9NYWtlZmlsZSAgICAgICAgICAg
ICAgICAgIHwgICAxICsNCj4+Pj4+IHhlbi9hcmNoL2FybS9jcHVwb29sLmMgICAgICAgICAg
ICAgICAgIHwgMTE4ICsrKysrKysrKysrKysrKysrKysrKysrKysNCj4+Pj4+IHhlbi9jb21t
b24vc2NoZWQvY3B1cG9vbC5jICAgICAgICAgICAgIHwgICA0ICstDQo+Pj4+PiB4ZW4vaW5j
bHVkZS94ZW4vc2NoZWQuaCAgICAgICAgICAgICAgICB8ICAxMSArKysNCj4+Pj4+IDYgZmls
ZXMgY2hhbmdlZCwgMjYwIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkNCj4+Pj4+IGNy
ZWF0ZSBtb2RlIDEwMDY0NCBkb2NzL21pc2MvYXJtL2RldmljZS10cmVlL2NwdXBvb2xzLnR4
dA0KPj4+Pj4gY3JlYXRlIG1vZGUgMTAwNjQ0IHhlbi9hcmNoL2FybS9jcHVwb29sLmMNCj4+
Pj4+DQo+Pj4+PiBkaWZmIC0tZ2l0IGEvZG9jcy9taXNjL2FybS9kZXZpY2UtdHJlZS9jcHVw
b29scy50eHQgYi9kb2NzL21pc2MvYXJtL2RldmljZS10cmVlL2NwdXBvb2xzLnR4dA0KPj4+
Pj4gbmV3IGZpbGUgbW9kZSAxMDA2NDQNCj4+Pj4+IGluZGV4IDAwMDAwMDAwMDAwMC4uNzI5
OGI2Mzk0MzMyDQo+Pj4+PiAtLS0gL2Rldi9udWxsDQo+Pj4+PiArKysgYi9kb2NzL21pc2Mv
YXJtL2RldmljZS10cmVlL2NwdXBvb2xzLnR4dA0KPj4+Pj4gQEAgLTAsMCArMSwxMTggQEAN
Cj4+Pj4+ICtCb290IHRpbWUgY3B1cG9vbHMNCj4+Pj4+ICs9PT09PT09PT09PT09PT09PT0N
Cj4+Pj4+ICsNCj4+Pj4+ICtPbiBhcm0sIHdoZW4gQk9PVF9USU1FX0NQVVBPT0xTIGlzIGVu
YWJsZWQgaW4gdGhlIFhlbiBjb25maWd1cmF0aW9uLCBpdCBpcw0KPj4+Pj4gK3Bvc3NpYmxl
IHRvIGNyZWF0ZSBjcHVwb29scyBkdXJpbmcgYm9vdCBwaGFzZSBieSBzcGVjaWZ5aW5nIHRo
ZW0gaW4gdGhlIGRldmljZQ0KPj4+Pj4gK3RyZWUuDQo+Pj4+PiArDQo+Pj4+PiArQ3B1cG9v
bHMgc3BlY2lmaWNhdGlvbiBub2RlcyBzaGFsbCBiZSBkaXJlY3QgY2hpbGRzIG9mIC9jaG9z
ZW4gbm9kZS4NCj4+Pj4+ICtFYWNoIGNwdXBvb2wgbm9kZSBjb250YWlucyB0aGUgZm9sbG93
aW5nIHByb3BlcnRpZXM6DQo+Pj4+PiArDQo+Pj4+PiArLSBjb21wYXRpYmxlIChtYW5kYXRv
cnkpDQo+Pj4+PiArDQo+Pj4+PiArICAgIE11c3QgYWx3YXlzIGluY2x1ZGUgdGhlIGNvbXBh
dGlibGl0eSBzdHJpbmc6ICJ4ZW4sY3B1cG9vbCIuDQo+Pj4+PiArDQo+Pj4+PiArLSBjcHVw
b29sLWlkIChtYW5kYXRvcnkpDQo+Pj4+PiArDQo+Pj4+PiArICAgIE11c3QgYmUgYSBwb3Np
dGl2ZSBpbnRlZ2VyIG51bWJlci4NCj4+Pj4NCj4+PiBIaSBTdGVmYW5vLA0KPj4+IFRoYW5r
IHlvdSBmb3IgeW91ciByZXZpZXcsDQo+Pj4+IFdoeSBpcyBjcHVwb29sLWlkIG1hbmRhdG9y
eT8gSXQgbG9va3MgbGlrZSBpdCBjb3VsZCBiZSBnZW5lcmF0ZWQgYnkgWGVuLg0KPj4+PiBP
ciBpcyBpdCBhY3R1YWxseSBiZXR0ZXIgdG8gaGF2ZSB0aGUgdXNlciBzcGVjaWZ5IGl0IGFu
eXdheT8NCj4+Pj4NCj4+PiBZZXMgYXQgZmlyc3QgSSB0aG91Z2h0IHRvIGF1dG9tYXRpY2Fs
bHkgZ2VuZXJhdGUgdGhhdCwgaG93ZXZlciBJIG5lZWRlZCBhIHN0cnVjdHVyZQ0KPj4+IHRv
IG1hcCB0aGUgaWQgdG8gdGhlIGNwdXBvb2wgRFQgbm9kZS4gSGVyZSBteSBkb3VidCB3YXMg
YWJvdXQgdGhlIHNpemUgb2YgdGhlDQo+Pj4gc3RydWN0dXJlLCBiZWNhdXNlIHRoZSB1c2Vy
IGNvdWxkIGV2ZW4gc3BlY2lmeSBhIGNwdXBvb2wgZm9yIGVhY2ggY3B1LiBJIGNvdWxkIGFs
bG9jYXRlDQo+Pj4gSXQgZHluYW1pY2FsbHkgYW5kIGZyZWUgaXQgYWZ0ZXIgZG9tVXMgY3Jl
YXRpb24gaW4gc2V0dXBfeGVuLg0KPj4+IFdoYXQgZG8geW91IHRoaW5rIGNvdWxkIGJlIHRo
ZSByaWdodCB3YXk/DQo+Pj4gT3IgdGhlIGRvbTBsZXNzIGd1ZXN0IGNvdWxkIHNwZWNpZnkg
dGhlIGlkLCBidXQgSSBsaWtlIGl0IG1vcmUgd2hlbiB1c2luZyBhIHBoYW5kbGUgdG8gdGhl
DQo+Pj4gWGVuLGNwdXBvb2wgbm9kZS4NCj4+Pj4NCj4+Pj4+ICstIGNwdXBvb2wtY3B1cyAo
bWFuZGF0b3J5KQ0KPj4+Pj4gKw0KPj4+Pj4gKyAgICBNdXN0IGJlIGEgbGlzdCBvZiBkZXZp
Y2UgdHJlZSBwaGFuZGxlIHRvIG5vZGVzIGRlc2NyaWJpbmcgY3B1cyAoZS5nLiBoYXZpbmcN
Cj4+Pj4+ICsgICAgZGV2aWNlX3R5cGUgPSAiY3B1IiksIGl0IGNhbid0IGJlIGVtcHR5Lg0K
Pj4+Pj4gKw0KPj4+Pj4gKy0gY3B1cG9vbC1zY2hlZCAob3B0aW9uYWwpDQo+Pj4+PiArDQo+
Pj4+PiArICAgIE11c3QgYmUgYSBzdHJpbmcgaGF2aW5nIHRoZSBuYW1lIG9mIGEgWGVuIHNj
aGVkdWxlciwgaXQgaGFzIG5vIGVmZmVjdCB3aGVuDQo+Pj4+PiArICAgIHVzZWQgaW4gY29u
anVuY3Rpb24gb2YgYSBjcHVwb29sLWlkIGVxdWFsIHRvIHplcm8sIGluIHRoYXQgY2FzZSB0
aGUNCj4+Pj4+ICsgICAgZGVmYXVsdCBYZW4gc2NoZWR1bGVyIGlzIHNlbGVjdGVkIChzY2hl
ZD08Li4uPiBib290IGFyZ3VtZW50KS4NCj4+Pj4NCj4+Pj4gSSBkb24ndCBnZXQgd2h5IGNw
dXBvb2wtaWQgPT0gMCBzaG91bGQgdHJpZ2dlciBhIHNwZWNpYWwgY3B1cG9vbC1zY2hlZA0K
Pj4+PiBiZWhhdmlvci4NCj4+PiBDcHVwb29sIHdpdGggaWQgMCBpcyBlbWJlZGRlZCBpbiBY
ZW4sIGl0IGhhcyBpdHMgb3duIHNwZWNpYWwgY2FzZSBoYW5kbGluZyBpbiBjcHVwb29sX2Ny
ZWF0ZQ0KPj4+IHRoYXQgaXMgZ2l2aW5nIGl0IHRoZSBkZWZhdWx0IHNjaGVkdWxlci4gSSB0
aG91Z2h0IGl0IHdhcyBiZXR0ZXIgdG8gbGVhdmUgaXQgYXMgaXQgd2FzLCBob3dldmVyIHRo
ZQ0KPj4+IGNwdXBvb2wwIHNjaGVkdWxlciBjYW4gYmUgbW9kaWZpZWQgdXNpbmcgc2NoZWQ9
IGJvb3QgYXJncyBhcyBpdCB3YXMgYmVmb3JlLg0KPj4+Pg0KPj4+Pg0KPj4+Pj4gK0NvbnN0
cmFpbnRzDQo+Pj4+PiArPT09PT09PT09PT0NCj4+Pj4+ICsNCj4+Pj4+ICtUaGUgY3B1cG9v
bCB3aXRoIGlkIHplcm8gaXMgaW1wbGljaXRseSBjcmVhdGVkIGV2ZW4gaWYgbm90IHNwZWNp
ZmllZCwgdGhhdCBwb29sDQo+Pj4+PiArbXVzdCBoYXZlIGF0IGxlYXN0IG9uZSBjcHUgYXNz
aWduZWQsIG90aGVyd2lzZSBYZW4gd2lsbCBzdG9wLg0KPj4+Pj4gKw0KPj4+Pj4gK0V2ZXJ5
IGNwdSBicm91Z2h0IHVwIGJ5IFhlbiB3aWxsIGJlIGFzc2lnbmVkIHRvIHRoZSBjcHVwb29s
IHdpdGggaWQgemVybyBpZiBpdCdzDQo+Pj4+PiArbm90IGFzc2lnbmVkIHRvIGFueSBvdGhl
ciBjcHVwb29sLg0KPj4+Pj4gKw0KPj4+Pj4gK0lmIGEgY3B1IGlzIGFzc2lnbmVkIHRvIGEg
Y3B1cG9vbCwgYnV0IGl0J3Mgbm90IGJyb3VnaHQgdXAgY29ycmVjdGx5LCBYZW4gd2lsbA0K
Pj4+Pj4gK3N0b3AuDQo+Pj4+DQo+Pj4+IFRoYW5rIHlvdSBmb3IgZG9jdW1lbnRpbmcgdGhl
IGNvbnN0cmFpbnRzLCBidXQgd2h5IGRvIHdlIGhhdmUgdGhlbT8NCj4+Pj4gSW1hZ2luZSBh
IHVzZXIgc3BlY2lmeWluZyAzIGNwdSBwb29scyBhbmQgaW1hZ2luZSB0aGUgY3B1cG9vbC1p
ZCBpcw0KPj4+PiBvcHRpb25hbCBhbmQgbWlzc2luZy4gV2UgY291bGQgdGFrZSBjYXJlIG9m
IHRoZSBjcHVwb29sLWlkIGdlbmVyYXRpb24gaW4NCj4+Pj4gWGVuIGFuZCB3ZSBjb3VsZCBh
bHNvIGFzc2lnbiB0aGUgZGVmYXVsdCBzY2hlZHVsZXIgZXZlcnl3aGVyZQ0KPj4+PiBjcHVw
b29sLXNjaGVkIGlzIG5vdCBzcGVjaWZpZWQuIE1heWJlIEkgYW0gbWlzc2luZyBzb21ldGhp
bmc/DQo+Pj4gWWVzIHdlIGNvdWxkIG1ha2UgdGhlIGNwdXBvb2wtaWQgb3B0aW9uYWwsIG15
IGRvdWJ0cyBhcmUgaW4gdGhlIGZpc3QgY29tbWVudCBhYm92ZS4NCj4+PiBXaGVuZXZlciB0
aGUgY3B1cG9vbC1zY2hlZCBpcyBub3Qgc3BlY2lmaWVkLCB0aGUgY3VycmVudCBiZWhhdmlv
dXIgaXMgdG8gdXNlIHRoZSBkZWZhdWx0IHNjaGVkdWxlci4NCj4+Pj4NCj4+Pj4gRG9lcyBj
cHVwb29sMCBoYXMgdG8gZXhpc3Q/IEkgZ3Vlc3MgdGhlIGFuc3dlciBjb3VsZCBiZSB5ZXMs
IGJ1dCBpZiBpdA0KPj4+PiBpcyBzcGVjaWZpZWQgYXMgaWQgb2Ygb25lIG9mIHRoZSBwb29s
cyB3ZSBhcmUgZmluZSwgb3RoZXJ3aXNlIGl0IGNvdWxkDQo+Pj4+IGJlIGF1dG9tYXRpY2Fs
bHkgZ2VuZXJhdGVkIGJ5IFhlbi4NCj4+PiBZZXMgY3B1cG9vbDAgbmVlZHMgdG8gZXhpc3Rz
LCBob3dldmVyIGl0IGlzIHN0aWxsIGdlbmVyYXRlZCBieSBYZW4gcmVnYXJkbGVzcyBvZiB0
aGUgRFQNCj4+PiBzcGVjaWZpY2F0aW9ucy4gSW4gZmFjdCB5b3UgY291bGQgbm90IHNwZWNp
ZnkgaW4gdGhlIERUIGFueSB4ZW4sY3B1cG9vbCBjb21wYXRpYmxlIG5vZGUNCj4+PiB3aXRo
IHRoZSBjcHVwb29sLWlkID09IDAgYW5kIFhlbiB3aWxsIGdlbmVyYXRlIHRoZSBjcHVwb29s
MCBhbnl3YXkNCj4+PiAoWGVuIGludGVybmFscyBhcmUgdGllZCB3aXRoIHRoZSBleGlzdGVu
Y2Ugb2YgYSBjcHVwb29sMCkuDQo+Pj4+DQo+Pj4+IEluIGFueSBjYXNlLCBJIGRvbid0IHRo
aW5rIHRoYXQgY3B1cG9vbDAgaGFzIHRvIGhhdmUgdGhlIGRlZmF1bHQNCj4+Pj4gc2NoZWR1
bGVyPw0KPj4+IE9rIEkgdGhpbmsgSSBjYW4gY3JlYXRlIGEgZnVuY3Rpb24gdG8gYXNzaWdu
IGEgc2NoZWR1bGVyIHRvIHRoZSBjcHVwb29sMCBhZnRlciBpdHMgY3JlYXRpb24sDQo+Pj4g
SSB3b3VsZCBuZWVkIHRvIHRlc3QgaXQgdG8gYmUgc3VyZSBJIGRvbuKAmXQgZmluZCBzb21l
dGhpbmcgc3RyYW5nZS4NCj4+Pj4NCj4+Pj4gTXkgc3VnZ2VzdGlvbiB3b3VsZCBiZToNCj4+
Pj4NCj4+Pj4gLSBtYWtlIGNwdXBvb2wtaWQgb3B0aW9uYWwNCj4+Pj4gLSBhc3NpZ24gYXV0
b21hdGljYWxseSBjcHVwb29sLWlkcyBzdGFydGluZyBmcm9tIDANCj4+Pj4gICAgIC0gcmVz
cGVjdCBjcHVwb29sLWlkcyBjaG9zZW4gYnkgdGhlIHVzZXINCj4+PiBPaywgaXQgd291bGQg
c3RhcnQgZnJvbSAxIGJlY2F1c2UgY3B1cG9vbDAgYWx3YXlzIGV4aXN0cw0KPj4+PiAtIGlm
IHNvbWUgQ1BVcyBhcmUgbGVmdCBvdXQgKG5vdCBzcGVjaWZpZWQgaW4gYW55IHBvb2wpIGFk
ZCBhbiBleHRyYSBjcHVwb29sDQo+Pj4+ICAgICAtIHRoZSBleHRyYSBjcHVwb29sIGRvZXNu
J3QgaGF2ZSB0byBiZSBjcHVwb29sLWlkID09IDAsIGl0IGNvdWxkIGJlDQo+Pj4+ICAgICAg
IGNwdXBvb2wtaWQgPT0gbg0KPj4+PiAgICAgLSB0aGUgZXh0cmEgY3B1cG9vbCB1c2VzIHRo
ZSBkZWZhdWx0IHNjaGVkdWxlcg0KPj4+IEkgZ2F2ZSBhbGwgdGhlIHVuYXNzaWduZWQgY3B1
cyB0byBjcHVwb29sMCB0byByZWZsZWN0IHRoZSBjdXJyZW50IGJlaGF2aW91ciwgc28gdGhh
dA0KPj4+IGEgdXNlciB0aGF0IGRvZXNu4oCZdCBzcGVjaWZ5IGFueSB4ZW4sY3B1cG9vbCBu
b2RlIGVuZHMgdXAgaW4gYSBzeXN0ZW0gcmVmbGVjdGluZyB0aGUNCj4+PiBjdXJyZW50IGJl
aGF2aW91ciBhcyB0aGUgZmVhdHVyZSBpcyBub3QgZW5hYmxlZC4NCj4+PiBIb3dldmVyIEkg
Y2FuIHNheSwgaWYgbm8geGVuLGNwdXBvb2wgbm9kZXMgYXJlIGZvdW5kIHRoZW4gYXNzaWdu
IGNwdXMgdG8gY3B1cG9vbDAsDQo+Pj4gZWxzZSBhc3NpZ24gdGhlbSB0byBhIG5ldyBjcHVw
b29sIGFuZC4uLg0KPj4+Pg0KPj4+PiBJZiB0aGUgdXNlciBjcmVhdGVkIGNwdXBvb2xzIGlu
IGRldmljZSB0cmVlIGNvdmVyaW5nIGFsbCBDUFVzIGFuZCBhbHNvDQo+Pj4+IHNwZWNpZmll
ZCBhbGwgY3B1cG9vbC1pZHMgZXZlcnl3aGVyZSwgYW5kIG5vbmUgb2YgdGhlbSBhcmUgMCAo
bm8gY3B1cG9vbA0KPj4+PiBpbiB0aGUgc3lzdGVtIGlzIGNwdXBvb2wwKSB0aGVuIHBhbmlj
LiAoQXNzdW1pbmcgdGhhdCBjcHVwb29sMCBpcw0KPj4+PiByZXF1aXJlZC4pDQo+Pj4g4oCm
IHBhbmljIGlmIGNwdXBvb2wwIGhhcyBubyBjcHVzLg0KPj4NCj4+IFRvZGF5IGNwdSAwIGlz
IGFsd2F5cyBtZW1iZXIgb2YgY3B1cG9vbDAsIGFuZCBjaGFuZ2luZyB0aGF0IG1pZ2h0IGJl
DQo+PiBoYXJkLg0KPiANCj4gT2gsIGFyZSB5b3Ugc3VyZT8gSSBkaWQgc29tZSB0ZXN0IGlu
IHRoZSBwYXN0IGZvciB0aGlzIHNlcmllIHVzaW5nIGEgSnVubyBib2FyZCwNCj4gZ2l2aW5n
IHRvIGNwdXBvb2wwIG9ubHkgYTcyIGNvcmVzIGFuZCB0aGUgYTUzIGNvcmVzIGluIGFub3Ro
ZXIgY3B1cG9vbCwgbXkgSnVubw0KPiBmaXJtd2FyZSBjb25maWd1cmF0aW9uIG1ha2VzIFhl
biBoYXZpbmcgdGhlIGJvb3QgY3B1IChjcHUgMCkgdG8gYmUgb25lIG9mIHRoZSBhNTMNCj4g
YW5kIGl0IHdhcyB3b3JraW5nIGZpbmUuIEJ1dCBpdCB3YXMgbG9uZyB0aW1lIGFnbyBzbyBJ
IHdvdWxkIG5lZWQgdG8gdHJ5IGl0IGFnYWluLg0KDQpNYXliZSBvbiBBcm0gdGhlIHJlc3Ry
aWN0aW9ucyBhcmUgbGVzcyBwcm9ibGVtYXRpYywgYnV0IEkgd291bGRuJ3QgYmV0DQp0aGF0
IGFsbCBvcGVyYXRpb25zIChsaWtlIG1vdmluZyBjcHVzIGJldHdlZW4gY3B1cG9vbHMsIGNw
dSBob3RwbHVnLA0KZGVzdHJveWluZyBjcHVwb29scywgc2h1dGRvd24gb2YgdGhlIGhvc3Qs
IC4uLikgYXJlIHdvcmtpbmcgaW4gYSBzYW5lDQp3YXkuDQoNCg0KSnVlcmdlbg0K
--------------IWY3wwzbe04gZE0J09kZbr2u
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------IWY3wwzbe04gZE0J09kZbr2u--

--------------RWs5vHXUoPlS9rZSb0xQiggU--

--------------e3l56HugvGX0TaqW7JqvortL
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmIM9wIFAwAAAAAACgkQsN6d1ii/Ey9M
9Qf/ZaxoPoJncPlNK0T/z/+F7+ABLBCLlCz/oABISb9G3q3w1M2afct8ekKaivAOg4U4gdotFkZ8
n/uLvplTftfOpA3xBa4WIsaZ4Cp2Oj/TcsoNjwG+qsLngn1L8AxPEKdCgw0vaCZL8zCqEuejEJ8d
0wMVAQH1Gx8Zgg2oy46ZVoFC3/VzkvZ3uddg2WN/tfVH0xZhm5bBtHfpC+NtJIricslCm/sHGNmV
UhMNIhxhwbJqXSSkWzWDNHO6eoTxKCrAaAFiZvImyP0apeeNoMlRVqNaxow2mueBvxPVgsQm1cbc
EDiViqW79HK9ioZts65sI/tm/YoltzyTbqLeWW4eXA==
=DLDi
-----END PGP SIGNATURE-----

--------------e3l56HugvGX0TaqW7JqvortL--


From xen-devel-bounces@lists.xenproject.org Wed Feb 16 13:58:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 13:58:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274138.469491 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKKoS-0005j1-SM; Wed, 16 Feb 2022 13:57:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274138.469491; Wed, 16 Feb 2022 13:57:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKKoS-0005iu-PG; Wed, 16 Feb 2022 13:57:44 +0000
Received: by outflank-mailman (input) for mailman id 274138;
 Wed, 16 Feb 2022 13:57:43 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=bXi8=S7=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1nKKoR-0005io-Aw
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 13:57:43 +0000
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur01on0604.outbound.protection.outlook.com
 [2a01:111:f400:fe1e::604])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6887f15d-8f30-11ec-8eb8-a37418f5ba1a;
 Wed, 16 Feb 2022 14:57:42 +0100 (CET)
Received: from AS9P194CA0012.EURP194.PROD.OUTLOOK.COM (2603:10a6:20b:46d::31)
 by DBBPR08MB6251.eurprd08.prod.outlook.com (2603:10a6:10:208::7) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.17; Wed, 16 Feb
 2022 13:57:39 +0000
Received: from AM5EUR03FT013.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:46d:cafe::37) by AS9P194CA0012.outlook.office365.com
 (2603:10a6:20b:46d::31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.14 via Frontend
 Transport; Wed, 16 Feb 2022 13:57:39 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT013.mail.protection.outlook.com (10.152.16.140) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4975.11 via Frontend Transport; Wed, 16 Feb 2022 13:57:38 +0000
Received: ("Tessian outbound 341d209a0e52:v113");
 Wed, 16 Feb 2022 13:57:38 +0000
Received: from d8283e1ac163.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 C36CB0FF-802A-4B9B-BC25-80033BD771E1.1; 
 Wed, 16 Feb 2022 13:57:31 +0000
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d8283e1ac163.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 16 Feb 2022 13:57:31 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by PAXPR08MB7294.eurprd08.prod.outlook.com (2603:10a6:102:215::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.15; Wed, 16 Feb
 2022 13:57:29 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::aca7:79c4:fa65:dac6]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::aca7:79c4:fa65:dac6%5]) with mapi id 15.20.4995.014; Wed, 16 Feb 2022
 13:57:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6887f15d-8f30-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=x99K0ND1sSpv+9jO4RTCV6C3fUnM6g2czl+uqfGJaVQ=;
 b=2tAxhwD/nbRmyh4eHbm4ZvnOlUZ9HvR/dL8Rn//OB04F1Lf5e+jcjW9/cVJlIVMnKr0uVUruPilST6SnhV31Xalel05/YgubhBv2nFbohpjdfWD+A+T6Mfr79CwNXmEJAP+KmNw8Lm+vYFoUHVRxQ8yFSLaWnZdwZBkJy7a9Raw=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 3795b1430dad8cdf
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=kycm7BB/GsMQppyRFOd87zF8h1hA6TrQPho24T9O02/c8PJvyK1uad+xaWx4xVWCtYaW/odpios6+hT1/41rd2rsb0yo1xL2xE6ptwiUw3iJxx2DAdM1K4tZ9e5J5A2/DBcGn4RjfdBjy8mnE71QxoaIuKGxVxCxpvKl8zzQcqrrkxWJzQ59YgXWc9KQOta+ctCzUz4iHPigDSqTCB8LMhn798+/mBR6SMFjcsBUpRPR6bMl9K008uY897WT3DBBvQS0q7yhil0j50f30NO5k8GgYrNAVGxMeHdBN/CWkqK9mayxoZhQNQ8Z6vaJkEajqC++ABOcAmCJNlXYNdbHXw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=x99K0ND1sSpv+9jO4RTCV6C3fUnM6g2czl+uqfGJaVQ=;
 b=oIOq6/FGxuAYy1xLTz+b+PScYusCVYXS5QwXB/0b0MrQJEf/FCHXYojlxWQBO/kl4oCR+oqICzB8D9c3kNgiVsDKqmH1tXgBM3jzzcQ7X4Nr9LpXe9odb4xNVQhNqwAHJkcc2aHIH6wnK+9GW1ZWIJvmnLIuVKvqCrk+IRaCx7vswhd6oLHpdVb+G67yQ12VjYiV8k2d9XpDQFnWUUMH1qtqx2zEqYDfFHkL1lno+A2ftB1Upiyyy68f4340iFWLCwvn7P1/AX0DsDVfiolNrrmbxGMZIOi62b09pi/rHEYZtlbcU5Y3FWHMav7h3fVtkfkhXiWOITMIAASKDKdN1w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=x99K0ND1sSpv+9jO4RTCV6C3fUnM6g2czl+uqfGJaVQ=;
 b=2tAxhwD/nbRmyh4eHbm4ZvnOlUZ9HvR/dL8Rn//OB04F1Lf5e+jcjW9/cVJlIVMnKr0uVUruPilST6SnhV31Xalel05/YgubhBv2nFbohpjdfWD+A+T6Mfr79CwNXmEJAP+KmNw8Lm+vYFoUHVRxQ8yFSLaWnZdwZBkJy7a9Raw=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: George Dunlap <George.Dunlap@citrix.com>
CC: Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, Andrew Cooper <Andrew.Cooper3@citrix.com>,
	Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>, Roger Pau
 Monne <roger.pau@citrix.com>, Julien Grall <julien@xen.org>
Subject: Re: [PATCH v2] lib: extend ASSERT()
Thread-Topic: [PATCH v2] lib: extend ASSERT()
Thread-Index:
 AQHYE4sUwaOwwc8tCU249z99fRIDqqyVNw0AgADQBoCAAAHjAIAAIjuAgAACWYCAAAt3gIAAGi0A
Date: Wed, 16 Feb 2022 13:57:29 +0000
Message-ID: <FEF187A8-0A09-4D50-A0E5-F46E014DB3E1@arm.com>
References: <75125344-b0e1-9663-4c1a-84bb35870fef@suse.com>
 <35d82770-66cf-e030-5bcc-3c030e4463d7@xen.org>
 <3F58400B-5151-42F2-8F39-109DDF50EE1E@arm.com>
 <a89223c8-f59a-24cc-96a7-e40feb28813f@suse.com>
 <DB014136-7797-4A61-9681-33A7D85403AA@citrix.com>
 <732e8e39-36c4-1651-61f3-9b55caf29fe8@suse.com>
 <46408EAE-5EA4-4B22-B685-BA6D313B5D3A@citrix.com>
In-Reply-To: <46408EAE-5EA4-4B22-B685-BA6D313B5D3A@citrix.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3693.60.0.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: e046fcd2-3ab9-4d7c-f37d-08d9f1544b0b
x-ms-traffictypediagnostic:
	PAXPR08MB7294:EE_|AM5EUR03FT013:EE_|DBBPR08MB6251:EE_
X-Microsoft-Antispam-PRVS:
	<DBBPR08MB6251259562CA0A1CA63FA3019D359@DBBPR08MB6251.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 evK9fuRyca2MlKDK0IiiEycS3SF7HeTGAZ4SAtZFiKEARoS3U03zGDL65UuEZMPuXZqwyDqU1VKVZfVGqg8Uuo0N0o6gHpuHQReId6fcszDYCdc2Xin8+p6Z4mA6ulEBJS8zssgQdsBwJiMnVJ9i7mFyn/5eWTZr3Zwfq5bwIcY/oYleGHQR+YcIYhR15H3EqUUk/CiTqcqqBULBG/Hjv9Mjd1RxLlEqpGK5nZ0QU9GKqxjbclRgEB11LzWggOQNZdDeJgB2TkCHlhcUN7c/RHG4ZWqsTuWkMCN3totEEEjg6gkGD+V7disYPtItA53u0yF4BCKrHGjgFqmUQ3DrtZlsngA5EbK1CRq3Xcp9RHcq6/RckDrhsefFR8QpdjcG5nCUMahUq86ffko+kZZBAIWMk+2MvM23LBGyX//hMJTWFfmNEmKaUcPn9aI6/jl9uG4TdO1trIVnrQEMulucGtPxQcafT/rcY+n6N2aO4gSjXAUKV6cAR5Y4J4BuyokH3fLmlZVYEkS/c8MqdcSDhB6CX7w0lVbJuBnTwCBZQE7YoQTI+Lx/3myykV5OtduiH4hmLrU1mtA8iExgryfoyvNY5hu3iiOVj43lcT4mWbcfx309nbubRcgjzldrMjICDwy/DkvMDWQFYS6b1MpWAgPg9ocQJcjzfeCedrGYtvparuSO2Us9+kti3UWKwkYmfrXYtn6dQDFYE5cmb1hBKhCf8Is0DKkkgZVm4Rz+83TrkaDo198W7ThAk0wJ+CCU
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(2616005)(8676002)(66556008)(91956017)(122000001)(4326008)(38070700005)(66446008)(6916009)(76116006)(54906003)(36756003)(316002)(66946007)(64756008)(2906002)(33656002)(66476007)(5660300002)(508600001)(6486002)(86362001)(26005)(186003)(53546011)(83380400001)(71200400001)(6506007)(6512007)(8936002)(38100700002)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <C22CD7552263064198631B890F1E186A@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7294
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT013.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	3a2ee8b3-37cc-453e-2e13-08d9f1544571
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	xf1aLGkq8UmqUJ3dB6j7twPz+4UnNrlJGJWqGgjigjvLMOxuIkMh1UDufY8xw4UQKksVuT00JEkUPJ+kJtLub9NjBEPbFWjdEQAJIPr/QDd3WCsyG2VdOJ6NAm6qVvPZbHjom/YRzGjYdqAChcbaxCf1P/3Tq5ers1z03hrlwSgUIBoB/JJh9GanGbXmQK5gqs3rjni62Ov+vQVHrnskb2r4tsSMRCTrQHjdOf4oH/Y45nNsZBhGDyKlddbMi9VhIQnkhRU+WxtJMe5HsgqB0Bh6RCwAnZAeYtZgvFOT2iH7oSi1LrcdGk/KKnEzymLtj8xPBtdOUmqXCQJXiDuNeCEm8kV6NQGdv8uw4gY4V9DtvthYF9hA5jCd6EkLTeu8UnrKGwpWLoWP+6eeP1nxL64qm0BVpcz00j6Z7g12AsB7iPsAFKY45I+i1EJaLICBot/cqNg5hzSpQuGOtzmqJx7YZKFyIuEt1HKfEQruCUlkSAD+iU/nE9bM9cUuhWbPTjJ7xpEgaPEXWCFe+a5bM6eDrsrxfBmWpc26cGl94hpB8jS0RnuQ/3zrAt8Ouodoh+UvHEexUmvvrNyQtgOmMpBpo0ykhrMuUioRdGUi23Ljah9xK4fwurTYmsBlAguGw/cOvSyiXFqi/bwobLIek1SXhU213ge/vwQBkLobda07cYKFLo/vS7kDj8aihcuD
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(2616005)(70586007)(2906002)(6862004)(70206006)(336012)(8676002)(356005)(86362001)(81166007)(40460700003)(33656002)(54906003)(508600001)(36756003)(8936002)(82310400004)(53546011)(83380400001)(36860700001)(316002)(5660300002)(186003)(47076005)(6486002)(26005)(4326008)(6506007)(6512007);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2022 13:57:38.7723
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: e046fcd2-3ab9-4d7c-f37d-08d9f1544b0b
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT013.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6251

SGksDQoNCj4gT24gMTYgRmViIDIwMjIsIGF0IDEyOjIzLCBHZW9yZ2UgRHVubGFwIDxHZW9yZ2Uu
RHVubGFwQGNpdHJpeC5jb20+IHdyb3RlOg0KPiANCj4gDQo+IA0KPj4gT24gRmViIDE2LCAyMDIy
LCBhdCAxMTo0MiBBTSwgSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPiB3cm90ZToNCj4+
IA0KPj4gT24gMTYuMDIuMjAyMiAxMjozNCwgR2VvcmdlIER1bmxhcCB3cm90ZToNCj4+IA0KPj4+
IEkgYW0gb3Bwb3NlZCB0byBvdmVybG9hZGluZyDigJxBU1NFUlTigJ0gZm9yIHRoaXMgbmV3IGtp
bmQgb2YgbWFjcm87IEkgdGhpbmsgaXQgd291bGQgbm90IG9ubHkgYmUgdW5uZWNlc3NhcmlseSBj
b25mdXNpbmcgdG8gcGVvcGxlIG5vdCBmYW1pbGlhciB3aXRoIG91ciBjb2RlYmFzZSwgYnV0IGl0
IHdvdWxkIGJlIHRvbyBlYXN5IGZvciBwZW9wbGUgdG8gZmFpbCB0byBub3RpY2Ugd2hpY2ggbWFj
cm8gd2FzIGJlaW5nIHVzZWQuDQo+Pj4gDQo+Pj4gQVNTRVJUX0FDVElPTihjb25kaXRpb24sIGNv
ZGUpIChvciBldmVuIEFTU0VSVF9PUl9BQ1RJT04oKSkgd291bGQgYmUgYSBiYXJlIG1pbmltdW0g
Zm9yIG1lLg0KPj4+IA0KPj4+IEJ1dCBJIGNhbuKAmXQgaW1hZ2luZSB0aGF0IHRoZXJlIGFyZSBt
b3JlIHRoYW4gYSBoYW5kZnVsIG9mIGFjdGlvbnMgd2UgbWlnaHQgd2FudCB0byB0YWtlLCBzbyBk
ZWZpbmluZyBhIG1hY3JvIGZvciBlYWNoIG9uZSBzaG91bGRu4oCZdCBiZSB0b28gYnVyZGVuc29t
ZS4NCj4+PiANCj4+PiBGdXJ0aGVybW9yZSwgdGhlIHZlcnkgZmxleGliaWxpdHkgc2VlbXMgZGFu
Z2Vyb3VzOyB5b3XigJlyZSBub3Qgc2VlaW5nIHdoYXQgYWN0dWFsIGNvZGUgaXMgZ2VuZXJhdGVk
LCBzbyBpdOKAmXMgdG8gZWFzeSB0byBiZSDigJxjbGV2ZXLigJ0sIGFuZC9vciB3cml0ZSBjb2Rl
IHRoYXQgZW5kcyB1cCBkb2luZyBzb21ldGhpbmcgZGlmZmVyZW50IHRoYW4geW91IGV4cGVjdC4N
Cj4+PiANCj4+PiBBdCB0aGUgbW9tZW50IEkgdGhpbmsgQVNTRVJUX09SX1JFVFVSTihjb25kaXRp
b24sIGNvZGUpLCBwbHVzIG90aGVyIG5ldyBtYWNyb3MgZm9yIHRoZSBvdGhlciBiZWhhdmlvciBp
cyBuZWVkZWQsIHdvdWxkIGJlIGJldHRlci4NCj4+IA0KPj4gSG1tLCB3aGlsZSBJIHNlZSB5b3Vy
IHBvaW50IG9mIHRoaW5ncyBwb3NzaWJseSBsb29raW5nIGNvbmZ1c2luZyBvcg0KPj4gdW5leHBl
Y3RlZCwgc29tZXRoaW5nIGxpa2UgQVNTRVJUX09SX1JFVFVSTigpIChzaG91bGRuJ3QgaXQgYmUN
Cj4+IEFTU0VSVF9BTkRfUkVUVVJOKCk/KSBpcyBpbW8gbGVzcyByZWFkYWJsZS4gSW4gcGFydGlj
dWxhciBJIGRpc2xpa2UNCj4+IHRoZSBsYXJnZXIgYW1vdW50IG9mIHVwcGVyY2FzZSB0ZXh0LiBC
dXQgeWVzLCBJIGNvdWxkIGFjY2VwdCB0aGlzDQo+PiBhcyBhIGNvbXByb21pc2UgYXMgaXQgc3Rp
bGwgc2VlbXMgYmV0dGVyIHRvIG1lIHRoYW4gdGhlIG11bHRpLWxpbmUNCj4+IGNvbnN0cnVjdHMg
d2UgY3VycmVudGx5IHVzZS4NCj4gDQo+IEkgc2VlIHdoYXQgeW914oCZcmUgc2F5aW5nIHdpdGgg
QU5EL09SOyBJIHBlcnNvbmFsbHkgc3RpbGwgcHJlZmVyIE9SIGJ1dCB3b3VsZG7igJl0IGFyZ3Vl
IHRvIGhhcmQgYWdhaW5zdCBBTkQgaWYgb3RoZXJzIHByZWZlcnJlZCBpdC4NCj4gDQo+IEFzIGZh
ciBhcyBJ4oCZbSBjb25jZXJuZWQsIHRoZSBmYWN0IHRoYXQgd2XigJlyZSByZWR1Y2luZyBsaW5l
cyBvZiBjb2RlIGlzbuKAmXQgYSByZWFzb24gdG8gdXNlIHRoaXMgYXQgYWxsLiAgQXMgb3VyIENP
RElOR19TVFlMRSBzYXlzLCBBU1NFUlQoKSBpcyBqdXN0IGEgbG91ZGVyIHByaW50ay4gIFdlIHdv
dWxkIG5ldmVyIGNvbnNpZGVyIHdyaXRpbmcgUFJJTlRLX0FORF9SRVRVUk4oKSwgYW5kIHdlIHdv
dWxkIG5ldmVyIGNvbnNpZGVyIHdyaXRpbmcgYSBtYWNybyBsaWtlIENPTkRSRVQoY29uZGl0aW9u
LCByZXR2YWwpIHRvIHJlcGxhY2UNCj4gDQo+IGlmIChjb25kaXRpb24pDQo+ICAgIHJldHVybiBy
ZXR2YWw7DQo+IA0KPiBUaGUgb25seSBqdXN0aWZpY2F0aW9uIGZvciB0aGlzIGtpbmQgb2YgbWFj
cm8sIGluIG15IG9waW5pb24sIGlzIHRvIGF2b2lkIGR1cGxpY2F0aW9uIGVycm9yczsgaS5lLiBy
ZXBsYWNpbmcgeW91ciBjb2RlIHNlZ21lbnQgd2l0aCB0aGUgZm9sbG93aW5nOg0KPiANCj4gaWYg
KGNvbmRpdGlvbikgew0KPiAgICBBU1NFUlQoIWNvbmRpdGlvbik7DQo+ICAgIHJldHVybiBmb287
DQo+IH0NCj4gDQo+IGlzIHVuZGVzaXJhYmxlIGJlY2F1c2UgdGhlcmXigJlzIHRvbyBtdWNoIHJp
c2sgdGhhdCB0aGUgY29uZGl0aW9ucyB3aWxsIGRyaWZ0IG9yIGJlIGludmVydGVkIGluY29ycmVj
dGx5LiBCdXQgaGF2aW5nIGNvbnRyb2wgc3RhdGVtZW50cyBsaWtlIOKAmHJldHVybuKAmSBhbmQg
4oCYY29udGludWXigJkgaW4gYSBtYWNybyBpcyBhbHNvIHVuZGVzaXJhYmxlIGluIG15IG9waW5p
b247IEnigJltIHBlcnNvbmFsbHkgbm90IHN1cmUgd2hpY2ggSSBmaW5kIG1vc3QgdW5kZXNpcmFi
bGUuDQo+IA0KPiBJIGd1ZXNzIG9uZSBhZHZhbnRhZ2Ugb2Ygc29tZXRoaW5nIGxpa2UgQVNTRVJU
X09SKGNvbmRpdGlvbiwgcmV0dXJuIGZvbyk7IG9yIEFTU0VSVF9PUihjb25kaXRpb24sIGNvbnRp
bnVlKTsgaXMgdGhhdCBzZWFyY2hpbmcgZm9yIOKAnHJldHVybuKAnSBvciDigJxjb250aW51ZeKA
nSB3aWxsIGNvbWUgdXAgZXZlbiBpZiB5b3XigJlyZSBkb2luZyBhIGNhc2Utc2Vuc2l0aXZlIHNl
YXJjaC4gIEJ1dCBJ4oCZbSBzdGlsbCB3YXJ5IG9mIHVuaW50ZW5kZWQgc2lkZSBlZmZlY3RzLg0K
PiANCj4gQmVydHJhbmQgLyBKdWxpZW4sIGFueSBtb3JlIHRob3VnaHRzPw0KDQpJIHRoaW5rIHRo
YXQgaGF2aW5nIG1hY3JvcyB3aGljaCBhcmUgbWFnaWMgbGlrZSB0aGF0IG9uZSB3aGljaCBpbmNs
dWRlcyBhIHBvc3NpYmxlIHJldHVybiBhbmQgdGhlIGZhY3QgdGhhdCB0aGUgbWFjcm8gaXMgdGFr
aW5nIGNvZGUgYXMgYXJndW1lbnQgaXMgbWFraW5nIHRoZSBjb2RlIHJlYWxseSBoYXJkIHRvIHJl
YWQgYW5kIHVuZGVyc3RhbmQgZm9yIHNvbWVvbmUgbm90IGtub3dpbmcgdGhpcy4NCkV2ZW4gdGhl
IGNvZGUgaXMgbG9uZ2VyIHJpZ2h0IG5vdywgaXQgaXMgbW9yZSByZWFkYWJsZSBhbmQgZWFzeSB0
byB1bmRlcnN0YW5kIHdoaWNoIG1lYW5zIGxlc3MgY2hhbmNlIGZvciBlcnJvcnMgc28gSSBkbyBu
b3QgdGhpbmsgdGhlIG1hY3JvIHdpbGwgYXZvaWQgZXJyb3JzIGJ1dCBtaWdodCBpbiBmYWN0IGlu
dHJvZHVjZSBzb21lIGluIHRoZSBmdXR1cmUuDQoNClNvIEkgYW0gdm90aW5nIHRvIGtlZXAgdGhl
IGN1cnJlbnQgbWFjcm8gYXMgaXQgaXMuDQoNCkJlcnRyYW5kDQoNCj4gDQo+IC1HZW9yZ2UNCg0K


From xen-devel-bounces@lists.xenproject.org Wed Feb 16 14:03:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 14:03:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274145.469502 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKKtg-0007BV-HR; Wed, 16 Feb 2022 14:03:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274145.469502; Wed, 16 Feb 2022 14:03:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKKtg-0007BO-ES; Wed, 16 Feb 2022 14:03:08 +0000
Received: by outflank-mailman (input) for mailman id 274145;
 Wed, 16 Feb 2022 14:03:08 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Gpsw=S7=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nKKtf-0007BI-Sc
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 14:03:07 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 29e853c1-8f31-11ec-b215-9bbe72dcb22c;
 Wed, 16 Feb 2022 15:03:06 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2053.outbound.protection.outlook.com [104.47.14.53]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-23-MuHevETQOF2XxfwW6GW_Ow-1; Wed, 16 Feb 2022 15:03:04 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DU2PR04MB8919.eurprd04.prod.outlook.com (2603:10a6:10:2e2::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.18; Wed, 16 Feb
 2022 14:03:03 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4995.016; Wed, 16 Feb 2022
 14:03:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 29e853c1-8f31-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645020186;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=rBYt9WVboXPyNYp43Pn9hYZWYs4NHFJ2Q/3A7YZQ3Ms=;
	b=bNKj5hG8YhiOFGEp8UGcdN/lVRfVslfYhmq6lc66J483l/EhyRyrM5XGAge3SKWyfcbs/q
	/Af+Ybvnm02rC+6W8hQOhle/PpUNKfJxmMcH/T1b+Ug/PXzE6N+/64DGgSt+Gwi/tyNm0o
	W4K5p3pvK9PPReWb+B74o+z8m3JvPhQ=
X-MC-Unique: MuHevETQOF2XxfwW6GW_Ow-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=LEbcTjyCBgs045LwF/kxSh8ZXgPqWxbbPsDSxz+PT1uAwssYOrZJ+2a9Aij2Q7eHENLWgokrEX+zfQjGuS+J7TpfuXmi0SDp6u1SihCLo+vJWR4Dhb5OddJfEOHQP9TpEpp9bnHIztxlahQOEYVjHMWJGcSijFLKOJ6D57P11Zop3EVE9TwZas6OwznvaV+ekxSJdsUGjlD44enHwwFVCbA3Wh66bKPFZtRKpEY4cq/kwkwUHPDlqB8GDpWIVVg6xWug4e6ll2MQuO6noFtRS/nATrZCJ0BwMbNx4Pv4Ff9xrMfy4aAPfrD1UPvZ79aIWDsn1vdjSa2sGbFbiYEWlw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=fbHJh9+VpQt+jxKRi6sRQbJmhe/uEsMO9RV0NKUOEqY=;
 b=NLamZC88l6BYl2n4kbMzoR1vlhq4dvGMB2ZqsQv7KSufRloG9jUJy+Hu6i9Crkja71x2dWm5VsuyZfByWwK0dD7/ov7ByDood4nhby5H/BK8evJFS0MROwL3jyAdjKazMN4vl+5f9xn9iM8F5wwOHffinmiyy2jvehKxTRQwkXD3wov6FhWTkZvSQ+U4HCHu4/Dx1oYFg5C9akMkMdUbTrLz0weByVz7Eu+FLzVjsxRGqlm2P8TSL4IBLiLsW+0vamsAhVOH8mMpJ6lVF7oHQYhGDevdOZlTppMuQEnlcTI1Ays5O/hnDbMAWXLHu8jpNpdU+C7cKa2ENfaKqqt6uA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <63811bb5-cce4-d542-461e-a24926f01b34@suse.com>
Date: Wed, 16 Feb 2022 15:03:01 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v2] lib: extend ASSERT()
Content-Language: en-US
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <Andrew.Cooper3@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Roger Pau Monne <roger.pau@citrix.com>, Julien Grall <julien@xen.org>,
 George Dunlap <George.Dunlap@citrix.com>
References: <75125344-b0e1-9663-4c1a-84bb35870fef@suse.com>
 <35d82770-66cf-e030-5bcc-3c030e4463d7@xen.org>
 <3F58400B-5151-42F2-8F39-109DDF50EE1E@arm.com>
 <a89223c8-f59a-24cc-96a7-e40feb28813f@suse.com>
 <DB014136-7797-4A61-9681-33A7D85403AA@citrix.com>
 <732e8e39-36c4-1651-61f3-9b55caf29fe8@suse.com>
 <46408EAE-5EA4-4B22-B685-BA6D313B5D3A@citrix.com>
 <FEF187A8-0A09-4D50-A0E5-F46E014DB3E1@arm.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <FEF187A8-0A09-4D50-A0E5-F46E014DB3E1@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6P192CA0027.EURP192.PROD.OUTLOOK.COM
 (2603:10a6:209:83::40) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2c394fda-4f32-4999-bee8-08d9f1550c51
X-MS-TrafficTypeDiagnostic: DU2PR04MB8919:EE_
X-Microsoft-Antispam-PRVS:
	<DU2PR04MB8919402687DB5996C152FD49B3359@DU2PR04MB8919.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Dl4RY35k7DE/GRhquLsaA6h8ilvUxbSHB6SUyIcrcb5HnvcQKskv0P4d94QzK1vnjJVgBndVNJxra/8GIFqbc2i/88e4pMP6BeMTOOP2l+J/mS26ylgPTowynI51e2V8fhEoLWWkSHjSpgne/WPB9pJjy85oseE0FLkvdADvZhNsReCS5FDlnnVDZPV4lKfmVBb9qjL/Ld9AJ8pnucl8NuzgMWsa7DjEIVqcr4vFzI3cXDo5S0u+RiPRCM6/EAp8r02AlXj9U4wJzqDlYdwYdjid87R8ZpSpvzA+xVbsHbSK7ZifDrX2Cn9fDCVzW8EonPRHN64NIGx7I3SzvlPyK0QZ+jxqv3LQnRgocjB5yNeUdzv5xsQNP4M1Cu5epNUvCS1coLA9aT5s09oqMU6vtbyADZOl9yTeDZnvJvEtRd/BncGbmB2qOTOz78HIWesjX/gaUlwWMj2szMvsI5QU6OUP2hsCPoLZFyjjttAKUuHeAp58j7PXtgI4m3VR6g0Joxy57BM/GGrj6ovCeu4MpCCJiKHGk9B+X5Bjw8VPKHwQIfGgVlaQoicyOid+zcc7ul/Nq6i8jCJV3XGBczZoEnymHN+IvoyIA6UlZYzDkB7aa54avMQlmBMmoxeoVF1cJWb+zCbAfP35qD3V7gfJ0THHsw5nAjIO2vMBKO+n7Mnnx+fIpUQg0pGLyQA9wFydok3ZGVG4Az0V/BTT8nPWaeD02nWq0IO1ECpfzMcFhG+qUAjsD6G3hYqhIJ0gvYwF
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(5660300002)(8936002)(508600001)(31696002)(2906002)(38100700002)(66556008)(6512007)(6486002)(86362001)(66946007)(36756003)(54906003)(8676002)(66476007)(6916009)(31686004)(4326008)(26005)(2616005)(6506007)(83380400001)(53546011)(316002)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?it4qhPEh1tZ1n8L5Sq45sTgm30d+bB3NQkrVm+TGAQsZVfDrzFivjwPN5Lpz?=
 =?us-ascii?Q?VyWqwW1QfyVNWsZODqil6wLTKP9FnEbfs98fF+9ygP+0Cf/71M1g9qPTw17y?=
 =?us-ascii?Q?chAioHTdTHObQtf0Q+24kDBilOm5cAAo5b99vqrX6v5pSRJ57ttvRw3Y797R?=
 =?us-ascii?Q?0DEQpZLIX2iwQJ4O0O9AYg8tO9EannG6n4PqPLi/2Bvx9AXCCl+jPrtOTAor?=
 =?us-ascii?Q?3yH4FciFLwV0uLiubaS1DRd4YgcOx1PJY2qrHETG8kMmjveNImXGv3AW99b+?=
 =?us-ascii?Q?GV2RQUl5RFDEJHRWsqcJEOi3+GNI7krJMexy6xzveTdXtpVP59DwtMXhJBIv?=
 =?us-ascii?Q?JANJUTl0DzIiwgrUQ+XrPeUpidiK6hKJSnEYtIHriW9B6/Td+Ah5BLdo48lL?=
 =?us-ascii?Q?2fDdb3ie7jkEa1feSAboYGlhmsFlzTZAW6Uzi/WsiMOAVFOkQz3pX5bqTv0f?=
 =?us-ascii?Q?8qnnE7Ck0Bc3TeiXfYiiU8Wkbt0s/38QvcVXoWIJj/Thyk5JAraz7yfy+X3w?=
 =?us-ascii?Q?qGExbh6s+226Q6zAGAQLYpWSnfeHaMYvMoR9nswO+XwLiwYjaONXdzTnk6B0?=
 =?us-ascii?Q?DcDEictJL/DGBoBJBGdbeQYDxN+KEeGDhcKiZZMPlvnWf/wsDzfl4OH3Q2C8?=
 =?us-ascii?Q?jZYgCsvWXRQhhvyCLnA+gEtNKzk4RP7IjRf692xe9jZza0cilhGHlCNjkSqh?=
 =?us-ascii?Q?zR/fdYReEFZ/F0P+zOl1FNllpEyvXcyjmIqaxM7qwCrfk2paJ73DQlV7WvvU?=
 =?us-ascii?Q?I4sFMVGikiBt9IyQtFAy662pOFiIS2JzHVOhzl/Zzhgf+V/NJzD8zVu8ye20?=
 =?us-ascii?Q?IiJk9Y4ZBqljZkLU3T3UWdi5UYJmlHwI3bjRexhbEe8E97/vcqaF50NVuFg+?=
 =?us-ascii?Q?dKgb6nobORmpve14uOnmJCz0slRU/hlKuKh0XznD1F73VAYfI7MwyEP7ZjAs?=
 =?us-ascii?Q?elad7ZocnHF8Ue3XtN6ZGqDaGFynNWPo92tilIf4Du8wF7T/FWsAfvJ2SuBm?=
 =?us-ascii?Q?XMrgKJs3gAH0y4fIiOZcwMGgHzrORwSuRGB+bjbBBtRxgoTG01SVXK+KvbGK?=
 =?us-ascii?Q?fBm8fFH9940f7uBtqRqCzD0ZGiIdmNgYQbRmoYivgYWfaocCX7lKaSQZSI66?=
 =?us-ascii?Q?Bkkput+AAPd2wlKY11/FQhuV6pLQvK3gfFdAD3kxIjaACThqAQGR7pQvY5MY?=
 =?us-ascii?Q?EmF9l/0pRWhTUqGW5HEBcnIBJ4UAiWQg3NByCzaEs92xEX6vKL+Dsz889Wgw?=
 =?us-ascii?Q?YSFStKwVdBe+hku63GP0LQZ8QdFtICkczZF4RKuyLQtCDKirvlk+xODChrds?=
 =?us-ascii?Q?BCjlpJo0LWTU1NlQgks/WM6xocyYbWOXdv2PTYRMyciNLWuRW6QEtaKe7UGI?=
 =?us-ascii?Q?oRw3c1aZb6Za0D7M78oON+o6Ddd/FxmCT92I7KmPM05oz8hqSvy3ohxcgvLy?=
 =?us-ascii?Q?9KNvM0CN0XHn74afmm2UPHBLyDokipJGue7vYN16Ia8NP9g81zpn+0NkAGvk?=
 =?us-ascii?Q?5yvMCBTgESFWgd4DMNNl3i2itJweCNOL67uNO1NdV3kxS29kYBxhNjK5t7qD?=
 =?us-ascii?Q?oUNIMAqVXikDZeIa5SU/F4bhJ0Qo18KRbnyJcAjUmzn+KHXDwDKRDP3z3llK?=
 =?us-ascii?Q?rtDtpNgswdQe25aqylTQC6U=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2c394fda-4f32-4999-bee8-08d9f1550c51
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2022 14:03:03.1927
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Z+UvfIGnAi12Y1eEKxHnnZ2K1cEqdWbVIJEa/v/VR5gU7qjBh0O5bd2ZQJkGKmsVVqxYQy/EBrumQRHqAQ4LHg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8919

On 16.02.2022 14:57, Bertrand Marquis wrote:
>> On 16 Feb 2022, at 12:23, George Dunlap <George.Dunlap@citrix.com> wrote=
:
>>> On Feb 16, 2022, at 11:42 AM, Jan Beulich <jbeulich@suse.com> wrote:
>>> On 16.02.2022 12:34, George Dunlap wrote:
>>>> I am opposed to overloading =E2=80=9CASSERT=E2=80=9D for this new kind=
 of macro; I think it would not only be unnecessarily confusing to people n=
ot familiar with our codebase, but it would be too easy for people to fail =
to notice which macro was being used.
>>>>
>>>> ASSERT_ACTION(condition, code) (or even ASSERT_OR_ACTION()) would be a=
 bare minimum for me.
>>>>
>>>> But I can=E2=80=99t imagine that there are more than a handful of acti=
ons we might want to take, so defining a macro for each one shouldn=E2=80=
=99t be too burdensome.
>>>>
>>>> Furthermore, the very flexibility seems dangerous; you=E2=80=99re not =
seeing what actual code is generated, so it=E2=80=99s to easy to be =E2=80=
=9Cclever=E2=80=9D, and/or write code that ends up doing something differen=
t than you expect.
>>>>
>>>> At the moment I think ASSERT_OR_RETURN(condition, code), plus other ne=
w macros for the other behavior is needed, would be better.
>>>
>>> Hmm, while I see your point of things possibly looking confusing or
>>> unexpected, something like ASSERT_OR_RETURN() (shouldn't it be
>>> ASSERT_AND_RETURN()?) is imo less readable. In particular I dislike
>>> the larger amount of uppercase text. But yes, I could accept this
>>> as a compromise as it still seems better to me than the multi-line
>>> constructs we currently use.
>>
>> I see what you=E2=80=99re saying with AND/OR; I personally still prefer =
OR but wouldn=E2=80=99t argue to hard against AND if others preferred it.
>>
>> As far as I=E2=80=99m concerned, the fact that we=E2=80=99re reducing li=
nes of code isn=E2=80=99t a reason to use this at all.  As our CODING_STYLE=
 says, ASSERT() is just a louder printk.  We would never consider writing P=
RINTK_AND_RETURN(), and we would never consider writing a macro like CONDRE=
T(condition, retval) to replace
>>
>> if (condition)
>>    return retval;
>>
>> The only justification for this kind of macro, in my opinion, is to avoi=
d duplication errors; i.e. replacing your code segment with the following:
>>
>> if (condition) {
>>    ASSERT(!condition);
>>    return foo;
>> }
>>
>> is undesirable because there=E2=80=99s too much risk that the conditions=
 will drift or be inverted incorrectly. But having control statements like =
=E2=80=98return=E2=80=99 and =E2=80=98continue=E2=80=99 in a macro is also =
undesirable in my opinion; I=E2=80=99m personally not sure which I find mos=
t undesirable.
>>
>> I guess one advantage of something like ASSERT_OR(condition, return foo)=
; or ASSERT_OR(condition, continue); is that searching for =E2=80=9Creturn=
=E2=80=9D or =E2=80=9Ccontinue=E2=80=9D will come up even if you=E2=80=99re=
 doing a case-sensitive search.  But I=E2=80=99m still wary of unintended s=
ide effects.
>>
>> Bertrand / Julien, any more thoughts?
>=20
> I think that having macros which are magic like that one which includes a=
 possible return and the fact that the macro is taking code as argument is =
making the code really hard to read and understand for someone not knowing =
this.
> Even the code is longer right now, it is more readable and easy to unders=
tand which means less chance for errors so I do not think the macro will av=
oid errors but might in fact introduce some in the future.
>=20
> So I am voting to keep the current macro as it is.

But you recall that there were two aspects to me wanting the switch?
(Source) code size was only one. The other was that ASSERT_UNREACHABLE()
doesn't show the original expression which has triggered the failure,
unlike ASSERT() does.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Feb 16 14:08:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 14:08:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274151.469513 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKKyN-0007pm-4w; Wed, 16 Feb 2022 14:07:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274151.469513; Wed, 16 Feb 2022 14:07:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKKyN-0007pf-21; Wed, 16 Feb 2022 14:07:59 +0000
Received: by outflank-mailman (input) for mailman id 274151;
 Wed, 16 Feb 2022 14:07:58 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Gpsw=S7=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nKKyM-0007pZ-D7
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 14:07:58 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d71f3e15-8f31-11ec-8eb8-a37418f5ba1a;
 Wed, 16 Feb 2022 15:07:57 +0100 (CET)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2050.outbound.protection.outlook.com [104.47.12.50]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-16-JK-5HfZ6MmO7c7aXa1U--A-1; Wed, 16 Feb 2022 15:07:55 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DBBPR04MB6075.eurprd04.prod.outlook.com (2603:10a6:10:c4::11) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.18; Wed, 16 Feb
 2022 14:07:53 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4995.016; Wed, 16 Feb 2022
 14:07:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d71f3e15-8f31-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645020476;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=nJJn8F/jiv93/xBblC5frLONhzdSY4epWGtoae2cyoQ=;
	b=a7l4cV8ovIB4yKNC5gBXgJgBfiXd0Og5nWuQZUP2YTmTWBHVSf4yeX2WJ2gIPxNeW4VvIb
	rmD2jRzcVoFvOLXdJrvd1emD85UJtUnNgB3P4wxXz0iIul5NGX0zTgHjRRfMmNs6YZseft
	E3NwzybbqnIUx/8urv2HihsvA+T5rZ0=
X-MC-Unique: JK-5HfZ6MmO7c7aXa1U--A-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=bqAk/LoloeXzVVP6lc1VNlFZb37vXR0wFssgh90X3dTeG5MCRrcoc9srSlFRKH2FDMnlU0yHDe02JO69bnHQhAkliS0Py+0k4QZ/FzyKZcvBg9EVaGLEjw9jD2MUOZdkLgVIMsWSuXusDDKoEHMMQXUFJ5ZaLFQh2wpb9ZIm29rwJgX6OaH516PsOXsaPjFdVOCZWslOZDnLbfcjBDM7/8qdK9t+nw83KbEqbQp3CR/xxke6/kQM1DyFMfTo7bz0idvXOcUN+0XXf0tYfK+ARLdnsrs0fso1SkNJDDMRej7XmNnlfMxn/cLTRIUa0bRlKYXde4Ar2CPWrF4J3LD2bQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=TxFF7yzodAj2dLHF+8uPBkHqQBl/XIXwrFeV8H6HRgI=;
 b=i1VMKEiS8sTYXBCCF9wKz575Uf6ojFVcmWSS0kX29L+CnwHHsi0JD2LrGorGGEsctta3sjEOsXGlxz0P541sGjpbjkqPbIUHZyePpTYy/yGuv8NjZj6L++IboPyy7Pd3NTMZoTbarrVNLwfiUVsX9AKTIMSM2PIQSdJ6H8p8lKGXLa0EHcugi2oLHf85s7sDrRwIVA6jJ3UdH3pH+cGA9qoy6Zz5qvtK7C3nzNB0ZpiqU7AZaZSI+OtZ1NPGUBlCPBCn4xp400pBY2NdbayFsF6z0EE8fRT8VXn6UxmVkDkmuHHCwb+vp7jffePHJ7+JdTIjzPXk8TkQnZBquXokLw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <f35a7003-6ecd-bf33-0f1f-873b96e967b2@suse.com>
Date: Wed, 16 Feb 2022 15:07:51 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH 2/3] x86/clang: add retpoline support
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220216090300.9424-1-roger.pau@citrix.com>
 <20220216090300.9424-3-roger.pau@citrix.com>
 <c5657f85-e3c4-9c39-1a67-b5162b1f86ef@suse.com>
 <Ygzfcop5TrpeXfG1@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Ygzfcop5TrpeXfG1@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR05CA0050.eurprd05.prod.outlook.com
 (2603:10a6:20b:489::24) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ed5d9b51-883d-4722-6697-08d9f155b954
X-MS-TrafficTypeDiagnostic: DBBPR04MB6075:EE_
X-Microsoft-Antispam-PRVS:
	<DBBPR04MB6075D43978BDFB13F6F70E54B3359@DBBPR04MB6075.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5236;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	tjN7fqeasK3+4q9nAhZEW/Vun/LMqwAG3uNwYjh42ezRfz8BOrmBw3cDVnbkAcKTD369uoe3VzMp6K4sxKqSHbf5tvN8PrxR66oShLpjzNQF88crOtJhFoSWDnrSwgTEtID2JIiHE3IsWDJXvptS7FBXK0JPok54moSfc7FiIVi6qckAhCggcBtVgP1iRRgssaXqIubpzLWOQkhqK+4o29cj3fE3RPFY8RsPl8EI+C5YUsiWlNbl34WbhqVhpQcpa9r/N1CypOTVa0OXOId/Sq/5yxTArFVbUVt1xt5cd08heIFbp8jjWaSLsltV65410hxamtAT3Yddqaxm6jAcLtYkPwVf7C6+oc5Am65MtUyfUB0P1PyHzaKBlLdoJcEMO8u6KNnbR9Xb3umAW2f5LhCtl6Cc+36TOL0Wv5KybqKZgY70ZNPyKt78Q8Dt5Zz3OUW71aO7Z1WDkVEaR2yKMd5kFxdwBW/QxpAeqr0aYDCHFSbioBnA1qTc3Zdol7rKqiwJVhQ2/zUxY9p3gnHzhbJ4SFFfXTbQcp9MpGnrSbvwC448C4wJOoxvK3bkzj9Yu2v/dt5plZhsBt2lyrirZghSLEVfMZEwko66aDv/DIEcfZv0w6lxGoYaz2cRGJvTuPz+D14U3PTjKfPymwan4883IbVr0ab32CiPxcGamb0yueA+izYP0gR/u7avXTCb6xmYcsx/a2i5WdIE/7VPghzdWiIln/UEIvd8JUxYRBM=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2906002)(83380400001)(4744005)(6512007)(8676002)(186003)(26005)(4326008)(2616005)(66556008)(54906003)(66476007)(31686004)(66946007)(31696002)(86362001)(316002)(6916009)(5660300002)(36756003)(8936002)(508600001)(53546011)(6506007)(38100700002)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?g5NmsQDNp7qQ/ddx3C0Y6ACPgCUHsTKj1mPn1rOH0XqTcxuyWLq/GXlUvjQm?=
 =?us-ascii?Q?HcD/04Se02r5SwfMnc0zBcm/xJ0Bekv7d+ZCPtnDV/EKD9SkDkB+CFo2CNHW?=
 =?us-ascii?Q?u36vnhuzbc/vmL8aj+1gCNyCAlE0+6pPRh8ePyAfQ3uotPL2x4HEfnK7eGdq?=
 =?us-ascii?Q?Jbx3DbV//SNRb+9DFRSr3cGcKkyuOz1rwPC+LJjCQF3Ral6d14PU8QUY7nnj?=
 =?us-ascii?Q?EPVVWQu3BNH3HkI3zkYhSYwQlZ4D6ydObmGAc/5dPslcvnRrLYJbHmIV/42d?=
 =?us-ascii?Q?p+q5epVWqBept4oWpczSNA0rQcVCdHDtqn/QDdYGYf5pOfQKtxp1aqbMVfhx?=
 =?us-ascii?Q?WfMlhqICBcIMpv5XUCqNmnqk17hQ0X907eXgRr4KezMZR82WZmVwWaQovDpt?=
 =?us-ascii?Q?sgiJvpvsiclLFuUC4aPH01cbboez3xZSTGjVUorqROxc72JV0kLueXTz8lN7?=
 =?us-ascii?Q?ijmrpuu3kgxDulOSXL9vyOAU2MqkUdfo9UoweLKXOHW7HqPmekxiUH+qJgpH?=
 =?us-ascii?Q?TIVqkx4hgWg0xcZvWOuxnD1gJvTwc9G1SXzouihDQycO1lfPtb4q4CRgcrlI?=
 =?us-ascii?Q?BWi6bTxMBzmlR/lOLKPLb4A++32j/6i51gDlwt1xEV51fl1t2IS1A6I5QNwn?=
 =?us-ascii?Q?ApJiaqGiyruFTht2tr0HzI3BVC9UpK1q+YH8DkilSmyISVBwJB58Bc2DRl9E?=
 =?us-ascii?Q?2ib1M/4nIb5s0yRdKtNwcrEUmaJukXbmlN1CIQUhTpQUvnHgko1jNXtUoKNY?=
 =?us-ascii?Q?bYViu2cCH/Ga/09WEYDt8MURmbdckENUKUgDWpmGD1ILi/1vQf/cGRcevVif?=
 =?us-ascii?Q?2o+d6wBvKDA1IRpjjD3RBBgpmVoDUvr2Z7+RxX3PwfTvTojCX39b1qVkf85k?=
 =?us-ascii?Q?em9X94rM5iQIbIPxP0zZiG55zVbl65nzGs42ArXzqvGqU6oFx+JlGSmFd6RK?=
 =?us-ascii?Q?CgCYfcSamdbN+zBc0qjEbBIqfm7WUxFi6P+79i9k+NiW+MMO+nyvH/WsNnvU?=
 =?us-ascii?Q?NkFR+FExpuMROBt2NFPBeiGuMeh1ta/zqL/I/Dmt0DKg8UB2nScN2VhIQYft?=
 =?us-ascii?Q?oGU1daXNzinVt9BMQGRTrZ1Ewr2AANselSX9vI73PYIxpgfBmM6aoxNZFunZ?=
 =?us-ascii?Q?1B/CvhI87KIfmIWxEmzKHQDXB8fekjCDOQpSz8wsTC4y4XiOxT90jRKbwx15?=
 =?us-ascii?Q?euuThDP7Y4ZDyt9SgfX3bdJ62v1gRiVEHZhyYcwu816YugT0BzX+X187KSev?=
 =?us-ascii?Q?3n5ut0axzuTUNmxPg6pfV5mfx6l7heKpbRT0fOJPPBLtv8PFI72s6LOKMEJB?=
 =?us-ascii?Q?YWaIc5t3HBYrl1yQYpMccT98njbFw8vGVVWtUS82uAcLh5sBOyS0JiAsEku3?=
 =?us-ascii?Q?WvWtapO0AcGjbCBdLkECT84Q+0lTDoqH/orM+nTD13bY6wiN+54E2p6hNSHi?=
 =?us-ascii?Q?aSZwOXoQkvoxxKf9AEB6II9JpbxA796f1z+AUiygC4LQI5Jpm95FLisjCoq9?=
 =?us-ascii?Q?nVE6fUAhMDBqonXpz1MepEOxzCekCV5yI5q3Zhn61NVJ+Lg0KJ+0LR8BUHmD?=
 =?us-ascii?Q?Plw3ivWlvRoceAtcImLZtlsxp1VzAKPMc3E/bRKLAr5FxEur1PV3wkyq7Y6w?=
 =?us-ascii?Q?9y8gr6JK8gRY1Z+ijv5rejE=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ed5d9b51-883d-4722-6697-08d9f155b954
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2022 14:07:53.4559
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vUPSi5ImwvI4szYDxrcM4G5RoRpWKlr/4IC7cblQ7riRGn8Ka1UswCaLGyBn6lpWVvEWNRvSyU4IBGCJgU2hrQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB6075

On 16.02.2022 12:26, Roger Pau Monn=C3=A9 wrote:
> On Wed, Feb 16, 2022 at 10:47:52AM +0100, Jan Beulich wrote:
>> On 16.02.2022 10:02, Roger Pau Monne wrote:
>>> Detect whether the compiler supports clang retpoline option and enable
>>> by default if available, just like it's done for gcc.
>>>
>>> Note clang already disables jump tables when retpoline is enabled, so
>>> there's no need to also pass the fno-jump-tables parameter.
>>
>> That's one of the secondary gcc side arrangements. What about the other
>> (-mindirect-branch-register)?
>=20
> clang already passes the return address on a register always on amd64
> so that's not needed either. I can add a comment like I've done for
> no-jump-tables.
>=20
>>> Reported-by: Jan Beulich <JBeulich@suse.com>
>>
>> That's Andrew, not me?
>=20
> Ops, sorry, I got that mixed up then.

With the adjustments then
Reviewed-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Wed Feb 16 14:20:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 14:20:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274161.469524 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKL9s-0000wY-Bo; Wed, 16 Feb 2022 14:19:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274161.469524; Wed, 16 Feb 2022 14:19:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKL9s-0000wR-8m; Wed, 16 Feb 2022 14:19:52 +0000
Received: by outflank-mailman (input) for mailman id 274161;
 Wed, 16 Feb 2022 14:19:51 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TJPu=S7=gmail.com=jandryuk@srs-se1.protection.inumbo.net>)
 id 1nKL9r-0000wJ-2b
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 14:19:51 +0000
Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com
 [2a00:1450:4864:20::22a])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 80308a41-8f33-11ec-8eb8-a37418f5ba1a;
 Wed, 16 Feb 2022 15:19:49 +0100 (CET)
Received: by mail-lj1-x22a.google.com with SMTP id n24so3520472ljj.10
 for <xen-devel@lists.xenproject.org>; Wed, 16 Feb 2022 06:19:49 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 80308a41-8f33-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=Gg4xEJR+SSZMw8ws+HUnrqvJSjZM4FLBBLe+IdNSmpc=;
        b=CvO48LjlnOynprQ9Gj4EiNMgdxDNO7hH2+hUdd4qh/bze8wugrAEQe8YdjcjIeYL91
         STd/4iq3PkPOQJeKhaF/T5kVLf5d3bYXSHnXxkSVi1X01QJG/WuwmIEv2dXilmMLVHmR
         ORK1XsIx/OGZsETHErox48iLVhBGre6vVAn7Z1aMnrb6G/zmV/bW5V6aKRpkH2YR6Xh9
         92NmX0m3QhBiMOGgyw5/ZGptDbv36jJNNAI8oyXnji1Z3oTfbqg6tvV15R4leD4aNMpq
         PmV8kwGJi66N1EkW92NAVdSxsnmi7GSIC/oOtUwzKfb+T9mLXmJsKEAn355ap6jgtRIR
         51+w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=Gg4xEJR+SSZMw8ws+HUnrqvJSjZM4FLBBLe+IdNSmpc=;
        b=vEesZ90IhmByHIXbcrQx+4iYDaZdc/+dGcgik2f8I/XlSuBAMvQ21wHhMEseT0RCTu
         +ZFBkV5r65bVo/tjAlzeDSu9EoBPA4ZGVupZzgsi3rLeN5Mnf5IYdSvtShL28OVOdVrH
         eOWXlEm66/gzcu2edT8TwvIQkb+TtWD/10r2p+Vv65hAhQ56/y4yqTPy3dDxDjXqVyQd
         GyGtL71hg0PFlWBXtfEO/UCala8snmqThZNYMWMULOmjR9t0YX2JKZg36rA43l76Atdt
         56zz7EZijY3AHXF90QBGY6vkcmGxuT+B5Yy5Jf1iJSIU8I8IzhNuxGd2gBbqeH/71q8O
         OokA==
X-Gm-Message-State: AOAM530hfxCQvIYPa9p5gxRROScaM1i+a9JNay7opnH7M4QQsb3hzvkX
	ym9+hOelCk/uj6O4nc1EFa2DjrGmqqxKoSY8bHE=
X-Google-Smtp-Source: ABdhPJwjaLoyusb08C85GkdiEy5q0SpR6gLudrKdCZNy/H4hdZri/CUtQAgFj7Kes0gcauEPYY5pQn+8NFlZ7ov+59M=
X-Received: by 2002:a2e:9d0d:0:b0:244:d41e:a5cf with SMTP id
 t13-20020a2e9d0d000000b00244d41ea5cfmr2193642lji.168.1645021189357; Wed, 16
 Feb 2022 06:19:49 -0800 (PST)
MIME-Version: 1.0
References: <20220216063325.1552217-1-andr2000@gmail.com>
In-Reply-To: <20220216063325.1552217-1-andr2000@gmail.com>
From: Jason Andryuk <jandryuk@gmail.com>
Date: Wed, 16 Feb 2022 09:19:37 -0500
Message-ID: <CAKf6xpvAp7yFJDRVjmkwJTfOcxfyaM9b-ndgw=qwCRFGnKROcw@mail.gmail.com>
Subject: Re: [PATCH v2] tools: remove xenstore entries on vchan server closure
To: Oleksandr Andrushchenko <andr2000@gmail.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>, Juergen Gross <jgross@suse.com>, 
	Anthony PERARD <anthony.perard@citrix.com>, Wei Liu <wl@xen.org>, 
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Content-Type: text/plain; charset="UTF-8"

On Wed, Feb 16, 2022 at 1:33 AM Oleksandr Andrushchenko
<andr2000@gmail.com> wrote:
>
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>
> vchan server creates XenStore entries to advertise its event channel and
> ring, but those are not removed after the server quits.
> Add additional cleanup step, so those are removed, so clients do not try
> to connect to a non-existing server.
>
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>
> ---
> Since v1:
> - add NULL check after strdup
> ---
>  tools/include/libxenvchan.h |  5 +++++
>  tools/libs/vchan/init.c     | 25 +++++++++++++++++++++++++
>  tools/libs/vchan/io.c       |  4 ++++
>  tools/libs/vchan/vchan.h    | 31 +++++++++++++++++++++++++++++++
>  4 files changed, 65 insertions(+)
>  create mode 100644 tools/libs/vchan/vchan.h

> diff --git a/tools/libs/vchan/init.c b/tools/libs/vchan/init.c
> index c8510e6ce98a..ae9a6b579753 100644
> --- a/tools/libs/vchan/init.c
> +++ b/tools/libs/vchan/init.c
> @@ -46,6 +46,8 @@
>  #include <xen/sys/gntdev.h>
>  #include <libxenvchan.h>
>
> +#include "vchan.h"
> +
>  #ifndef PAGE_SHIFT
>  #define PAGE_SHIFT 12
>  #endif
> @@ -251,6 +253,12 @@ static int init_xs_srv(struct libxenvchan *ctrl, int domain, const char* xs_base
>         char ref[16];
>         char* domid_str = NULL;
>         xs_transaction_t xs_trans = XBT_NULL;
> +
> +       // store the base path so we can clean up on server closure
> +       ctrl->xs_path = strdup(xs_base);
> +       if (!ctrl->xs_path)
> +               goto fail;
> +
>         xs = xs_open(0);
>         if (!xs)
>                 goto fail;

Hi, Oleksandr,

You now have multiple conditions goto fail, so I think you need to add
the below snippet to avoid leaking memory.

if (ret) {
    free(ctrl->xs_path)
    ctrl->xs_path = NULL;
}

It's actually okay with your patch since libxenvchan_server_init() does:

        if (init_xs_srv(ctrl, domain, xs_path, ring_ref))
                goto out;
        return ctrl;
out:
        libxenvchan_close(ctrl);
        return 0;

and libxenvchan_close() will free xs_path.  But it's a little more
robust to cleanup local to the failure.

Thanks,
Jason


From xen-devel-bounces@lists.xenproject.org Wed Feb 16 14:36:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 14:36:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274174.469535 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKLPY-0003GP-ME; Wed, 16 Feb 2022 14:36:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274174.469535; Wed, 16 Feb 2022 14:36:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKLPY-0003GI-J0; Wed, 16 Feb 2022 14:36:04 +0000
Received: by outflank-mailman (input) for mailman id 274174;
 Wed, 16 Feb 2022 14:36:03 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=bXi8=S7=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1nKLPW-0003GC-RF
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 14:36:03 +0000
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur02on0610.outbound.protection.outlook.com
 [2a01:111:f400:fe07::610])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c35053cc-8f35-11ec-b215-9bbe72dcb22c;
 Wed, 16 Feb 2022 15:36:02 +0100 (CET)
Received: from AM6PR10CA0046.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:80::23)
 by DB9PR08MB6650.eurprd08.prod.outlook.com (2603:10a6:10:26d::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.10; Wed, 16 Feb
 2022 14:35:59 +0000
Received: from AM5EUR03FT041.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:80:cafe::31) by AM6PR10CA0046.outlook.office365.com
 (2603:10a6:209:80::23) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.14 via Frontend
 Transport; Wed, 16 Feb 2022 14:35:59 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT041.mail.protection.outlook.com (10.152.17.186) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4975.11 via Frontend Transport; Wed, 16 Feb 2022 14:35:58 +0000
Received: ("Tessian outbound 31aeb3346a45:v113");
 Wed, 16 Feb 2022 14:35:58 +0000
Received: from 5f0a8bae4a9c.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 30A2932F-D30C-4805-A898-09554111A661.1; 
 Wed, 16 Feb 2022 14:35:52 +0000
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 5f0a8bae4a9c.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 16 Feb 2022 14:35:52 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by AM9PR08MB6951.eurprd08.prod.outlook.com (2603:10a6:20b:412::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.15; Wed, 16 Feb
 2022 14:35:47 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::aca7:79c4:fa65:dac6]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::aca7:79c4:fa65:dac6%5]) with mapi id 15.20.4995.014; Wed, 16 Feb 2022
 14:35:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c35053cc-8f35-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=HjxCSrsU0cva+FalFgQD+jjys6l5iSe0Frp/qBjff04=;
 b=67bsjXi6kAk4zfEvwRwcPf6tg+UxFAqcQl/jQ/TsxeyAh5zKULH/I68CRURFhKhtUgW/hlq52C+QAQKHWgKbbxGOinc9C9ScIxd4uEb1bXyPtrjHSfUaXh1zNoku/qx0ctcVE2UxNGaf0J3pdJi2xOJgLfX1NkCAvgmmIcjbqDo=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 0ff8043b23f4f351
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=T0s6L5LzVEr+JRly3K4pmLcxUrebUwfMgkG91pPjdmdz4cdyqTVw8Q3pkeVArSnt47WrXkzvvbQFoXFuIJFmp+VYF8DiJjDOhNa84fcFgt1qoCThs95jEsuoFHIzJgklLSaKQZUXN9rRNuS1VvkDC8s26NM+dhW8idLpwKmOEK1z4DHal02rb+Vx+ltaDplDgzdpUiomQzGiP7qwOi1s3n35YUiHurCODwNfcs+Hz9ffm3f7nn1XViGYcYtv4Q/olvDQAOOyuNURy4mSdZZgn2mcjxxScxAQaPXB02YAnmXoCCjHdt0th514L8jyTR/cKkSidaoaZJm3X11Ppf8umQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=HjxCSrsU0cva+FalFgQD+jjys6l5iSe0Frp/qBjff04=;
 b=XjNujYl5Kwk5U4N+1G4Q36P6AYIB9K9bt+4xhJP9AiynyxM7p3iuErkDaWj34fxsrwyyiDbCPXEID8sr8Lm/t8W3pLb6X9O/ECj7ffnc6b+jYDoe8MSDV4ztXIyaspRslSNYenQAGa6derX1y4MolpMcJLYbrr5div2gnkxdHTtVA2VdZKZOVVq/yeBYlMAZ4O9GJEuxuM0N9sAEbf+fpMhJU6tQu8SQcDK1653rJR942Bq+93B+1OyOH9pTEAxl1eILx1w09M6TL70J0eeW+0Fwn2BrV7t7lVLBvFegMCHOEjuq7JD2cCNaeeRH8u37Uyv7iwo/oS/os/G1g2wlTg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=HjxCSrsU0cva+FalFgQD+jjys6l5iSe0Frp/qBjff04=;
 b=67bsjXi6kAk4zfEvwRwcPf6tg+UxFAqcQl/jQ/TsxeyAh5zKULH/I68CRURFhKhtUgW/hlq52C+QAQKHWgKbbxGOinc9C9ScIxd4uEb1bXyPtrjHSfUaXh1zNoku/qx0ctcVE2UxNGaf0J3pdJi2xOJgLfX1NkCAvgmmIcjbqDo=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <Andrew.Cooper3@citrix.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Wei Liu <wl@xen.org>, Roger Pau Monne
	<roger.pau@citrix.com>, Julien Grall <julien@xen.org>, George Dunlap
	<George.Dunlap@citrix.com>
Subject: Re: [PATCH v2] lib: extend ASSERT()
Thread-Topic: [PATCH v2] lib: extend ASSERT()
Thread-Index:
 AQHYE4sUwaOwwc8tCU249z99fRIDqqyVNw0AgADQBoCAAAHjAIAAIjuAgAACWYCAAAt3gIAAGi0AgAABjYCAAAkmAA==
Date: Wed, 16 Feb 2022 14:35:47 +0000
Message-ID: <0BF64A25-F218-404A-8547-4896FCB27E2C@arm.com>
References: <75125344-b0e1-9663-4c1a-84bb35870fef@suse.com>
 <35d82770-66cf-e030-5bcc-3c030e4463d7@xen.org>
 <3F58400B-5151-42F2-8F39-109DDF50EE1E@arm.com>
 <a89223c8-f59a-24cc-96a7-e40feb28813f@suse.com>
 <DB014136-7797-4A61-9681-33A7D85403AA@citrix.com>
 <732e8e39-36c4-1651-61f3-9b55caf29fe8@suse.com>
 <46408EAE-5EA4-4B22-B685-BA6D313B5D3A@citrix.com>
 <FEF187A8-0A09-4D50-A0E5-F46E014DB3E1@arm.com>
 <63811bb5-cce4-d542-461e-a24926f01b34@suse.com>
In-Reply-To: <63811bb5-cce4-d542-461e-a24926f01b34@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3693.60.0.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: d7e890d8-c41c-420d-9763-08d9f159a5cc
x-ms-traffictypediagnostic:
	AM9PR08MB6951:EE_|AM5EUR03FT041:EE_|DB9PR08MB6650:EE_
X-Microsoft-Antispam-PRVS:
	<DB9PR08MB66502E27DEBE8F2F361345F49D359@DB9PR08MB6650.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 /MMsKd/qsYMGufiDMJOd6bRY2CbI3TYbb3d6VhLpq7NOLVHNmV6iehED59S5CL5zysbGXZAFF/SIOBMgY51RnBfsqNSOWMYpqzKAOBUVt6GnbBDvhnYMAYrWZ1+ddNAcrNH/5a3/718Wsj/v+gkO6sgsuW9wZ68iqTY/ZviuBQEmwgyIhChVPwrGBvN9Qrb/NY8Jvv9ycgrshBJb+twpbD+H1SfHQsGdfiS8z9v0t9khVimroDp3CEkP8ZJ3q6A7EJFSLvQWmki/ZAY8JDxIMrmAFuZXykUxcYeHJ6Ec2lhgezoJ/ADpQLpVSLqPB1JbbbtLOdvPM8iKC47o1S1vlm2V3qaEk8uQDsjHIYCi19U1uTFTvZbQKLfJds7/FwJIBDPaDtf6p4U2NdvCe1ZoMuKfUSzFnsW2uWAMpqTW9ZX8806obIThqNsGuxQ1/jqYK7kAMKjcFu76OBFz13sEPtDK4flbInk4P+W0d1mmYtu3NzMkxccwfCBhM60TY68Vq5H7adRQR84wVYqEsWQODLFXLjl+CmJyIqk7fmzHKSvK+bNpk2wZ1nUdMXVALR2Xkq9qY2vOu2acwvHC7G/C19a+Oi+p7xyP4/9hH+1BjM2ZawVORN4BM4qB5ZjaFtoG3/60JrelM0OqnyRYQ1ebyrXO7q7Te/OVigAe4LlgGIwZz7OLT+vZPuO8aElSKaeATK49ccE0tPbWvGOzAnpkaSQZxOwDNiA8ku2cdahyczRoHUybLYdgjktWdz9vxtjIaJbl5OG6oepsx+44sd2oJGiL87rfLPll/xRSwP3mwWE=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(83380400001)(6506007)(186003)(38100700002)(26005)(38070700005)(33656002)(36756003)(2906002)(5660300002)(53546011)(6916009)(64756008)(316002)(66556008)(66946007)(71200400001)(8676002)(66476007)(86362001)(2616005)(6512007)(54906003)(8936002)(4326008)(122000001)(76116006)(6486002)(508600001)(66446008)(91956017)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <440D40EF75CAAD4C9A69ADCFCC027084@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6951
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT041.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	1f17844e-06e6-4447-29af-08d9f1599f54
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	9Yh1tYyQAphHZVVej8QKY77T0SFlGd/dz/snLKEcvGNAh4n/qCBL8yI8CeW2oC2T6JhDJDX8pENk4yrFVUpI+FgN6VCjq/OVHAbGH8p/qvdedKTD1HRpL+H1k2F5S11MZck1n+iOThNowCFUhVTZnoBosBMgvY6RP0db+d3o7bbz0wXuiOsnPxFfgZHOB/S9w0lfBTgbakhoT/zcQCgZjnkzboFxgkqdp9TrsE86HhRv8d1cXPbAeFJ7rsFumyEM7nZN+6o1ghNKSMSva68jQdmrFwCCGlmaDxiWByFlHWZl/30RTBbIfJemzt8tNyGd/AXbOqNRNuyB6Evmy5YvhYVq2K3M4RY+zfghkzxd5BefHz/W5rOYy/gv1MbCsu1oy0k3DlmIMe8fiAe/C7vE5KAKfZxEDWJwSr9TWYX9AMtk7H5ugJQLYlWPQJQhSuh/hkkIJcoYfufEovp2X9P3FMfgtDxUchaAm4Mc8PXDy+nRrSx3aIgq+Sf3JAEbOw8SfogdmaApzLgPhRFqWCHVPIWJ1LUwipeYt4u21REgH3sAUrm9EVZefxLVemKNI0VdA9m/LMKT+mdfcbxT9b2sf9Yp6gSyWlAEMuLK8b91b5TefZO3RoH65F5Ad0orIMwwZYUqIhUbAos79BTGhxFEtNvzf2QVLd/aM57swEvWh308SFdWmuJcPmBHtL/8vDeuX+ZhNl+AZI1IrVW67YKimtq3wMtjEViDkC4LX0O4UVr1K296s3eOIkk1XYn9LIX9KuSGxEkLBKiA6ezWjfijEg==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(40470700004)(46966006)(36840700001)(70206006)(8936002)(316002)(6512007)(8676002)(81166007)(36756003)(336012)(508600001)(5660300002)(6486002)(70586007)(86362001)(2616005)(40460700003)(2906002)(82310400004)(54906003)(36860700001)(53546011)(33656002)(4326008)(26005)(83380400001)(6862004)(6506007)(47076005)(356005)(186003)(107886003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2022 14:35:58.4730
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: d7e890d8-c41c-420d-9763-08d9f159a5cc
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT041.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6650

SGkgSmFuLA0KDQo+IE9uIDE2IEZlYiAyMDIyLCBhdCAxNDowMywgSmFuIEJldWxpY2ggPGpiZXVs
aWNoQHN1c2UuY29tPiB3cm90ZToNCj4gDQo+IE9uIDE2LjAyLjIwMjIgMTQ6NTcsIEJlcnRyYW5k
IE1hcnF1aXMgd3JvdGU6DQo+Pj4gT24gMTYgRmViIDIwMjIsIGF0IDEyOjIzLCBHZW9yZ2UgRHVu
bGFwIDxHZW9yZ2UuRHVubGFwQGNpdHJpeC5jb20+IHdyb3RlOg0KPj4+PiBPbiBGZWIgMTYsIDIw
MjIsIGF0IDExOjQyIEFNLCBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+IHdyb3RlOg0K
Pj4+PiBPbiAxNi4wMi4yMDIyIDEyOjM0LCBHZW9yZ2UgRHVubGFwIHdyb3RlOg0KPj4+Pj4gSSBh
bSBvcHBvc2VkIHRvIG92ZXJsb2FkaW5nIOKAnEFTU0VSVOKAnSBmb3IgdGhpcyBuZXcga2luZCBv
ZiBtYWNybzsgSSB0aGluayBpdCB3b3VsZCBub3Qgb25seSBiZSB1bm5lY2Vzc2FyaWx5IGNvbmZ1
c2luZyB0byBwZW9wbGUgbm90IGZhbWlsaWFyIHdpdGggb3VyIGNvZGViYXNlLCBidXQgaXQgd291
bGQgYmUgdG9vIGVhc3kgZm9yIHBlb3BsZSB0byBmYWlsIHRvIG5vdGljZSB3aGljaCBtYWNybyB3
YXMgYmVpbmcgdXNlZC4NCj4+Pj4+IA0KPj4+Pj4gQVNTRVJUX0FDVElPTihjb25kaXRpb24sIGNv
ZGUpIChvciBldmVuIEFTU0VSVF9PUl9BQ1RJT04oKSkgd291bGQgYmUgYSBiYXJlIG1pbmltdW0g
Zm9yIG1lLg0KPj4+Pj4gDQo+Pj4+PiBCdXQgSSBjYW7igJl0IGltYWdpbmUgdGhhdCB0aGVyZSBh
cmUgbW9yZSB0aGFuIGEgaGFuZGZ1bCBvZiBhY3Rpb25zIHdlIG1pZ2h0IHdhbnQgdG8gdGFrZSwg
c28gZGVmaW5pbmcgYSBtYWNybyBmb3IgZWFjaCBvbmUgc2hvdWxkbuKAmXQgYmUgdG9vIGJ1cmRl
bnNvbWUuDQo+Pj4+PiANCj4+Pj4+IEZ1cnRoZXJtb3JlLCB0aGUgdmVyeSBmbGV4aWJpbGl0eSBz
ZWVtcyBkYW5nZXJvdXM7IHlvdeKAmXJlIG5vdCBzZWVpbmcgd2hhdCBhY3R1YWwgY29kZSBpcyBn
ZW5lcmF0ZWQsIHNvIGl04oCZcyB0byBlYXN5IHRvIGJlIOKAnGNsZXZlcuKAnSwgYW5kL29yIHdy
aXRlIGNvZGUgdGhhdCBlbmRzIHVwIGRvaW5nIHNvbWV0aGluZyBkaWZmZXJlbnQgdGhhbiB5b3Ug
ZXhwZWN0Lg0KPj4+Pj4gDQo+Pj4+PiBBdCB0aGUgbW9tZW50IEkgdGhpbmsgQVNTRVJUX09SX1JF
VFVSTihjb25kaXRpb24sIGNvZGUpLCBwbHVzIG90aGVyIG5ldyBtYWNyb3MgZm9yIHRoZSBvdGhl
ciBiZWhhdmlvciBpcyBuZWVkZWQsIHdvdWxkIGJlIGJldHRlci4NCj4+Pj4gDQo+Pj4+IEhtbSwg
d2hpbGUgSSBzZWUgeW91ciBwb2ludCBvZiB0aGluZ3MgcG9zc2libHkgbG9va2luZyBjb25mdXNp
bmcgb3INCj4+Pj4gdW5leHBlY3RlZCwgc29tZXRoaW5nIGxpa2UgQVNTRVJUX09SX1JFVFVSTigp
IChzaG91bGRuJ3QgaXQgYmUNCj4+Pj4gQVNTRVJUX0FORF9SRVRVUk4oKT8pIGlzIGltbyBsZXNz
IHJlYWRhYmxlLiBJbiBwYXJ0aWN1bGFyIEkgZGlzbGlrZQ0KPj4+PiB0aGUgbGFyZ2VyIGFtb3Vu
dCBvZiB1cHBlcmNhc2UgdGV4dC4gQnV0IHllcywgSSBjb3VsZCBhY2NlcHQgdGhpcw0KPj4+PiBh
cyBhIGNvbXByb21pc2UgYXMgaXQgc3RpbGwgc2VlbXMgYmV0dGVyIHRvIG1lIHRoYW4gdGhlIG11
bHRpLWxpbmUNCj4+Pj4gY29uc3RydWN0cyB3ZSBjdXJyZW50bHkgdXNlLg0KPj4+IA0KPj4+IEkg
c2VlIHdoYXQgeW914oCZcmUgc2F5aW5nIHdpdGggQU5EL09SOyBJIHBlcnNvbmFsbHkgc3RpbGwg
cHJlZmVyIE9SIGJ1dCB3b3VsZG7igJl0IGFyZ3VlIHRvIGhhcmQgYWdhaW5zdCBBTkQgaWYgb3Ro
ZXJzIHByZWZlcnJlZCBpdC4NCj4+PiANCj4+PiBBcyBmYXIgYXMgSeKAmW0gY29uY2VybmVkLCB0
aGUgZmFjdCB0aGF0IHdl4oCZcmUgcmVkdWNpbmcgbGluZXMgb2YgY29kZSBpc27igJl0IGEgcmVh
c29uIHRvIHVzZSB0aGlzIGF0IGFsbC4gIEFzIG91ciBDT0RJTkdfU1RZTEUgc2F5cywgQVNTRVJU
KCkgaXMganVzdCBhIGxvdWRlciBwcmludGsuICBXZSB3b3VsZCBuZXZlciBjb25zaWRlciB3cml0
aW5nIFBSSU5US19BTkRfUkVUVVJOKCksIGFuZCB3ZSB3b3VsZCBuZXZlciBjb25zaWRlciB3cml0
aW5nIGEgbWFjcm8gbGlrZSBDT05EUkVUKGNvbmRpdGlvbiwgcmV0dmFsKSB0byByZXBsYWNlDQo+
Pj4gDQo+Pj4gaWYgKGNvbmRpdGlvbikNCj4+PiAgIHJldHVybiByZXR2YWw7DQo+Pj4gDQo+Pj4g
VGhlIG9ubHkganVzdGlmaWNhdGlvbiBmb3IgdGhpcyBraW5kIG9mIG1hY3JvLCBpbiBteSBvcGlu
aW9uLCBpcyB0byBhdm9pZCBkdXBsaWNhdGlvbiBlcnJvcnM7IGkuZS4gcmVwbGFjaW5nIHlvdXIg
Y29kZSBzZWdtZW50IHdpdGggdGhlIGZvbGxvd2luZzoNCj4+PiANCj4+PiBpZiAoY29uZGl0aW9u
KSB7DQo+Pj4gICBBU1NFUlQoIWNvbmRpdGlvbik7DQo+Pj4gICByZXR1cm4gZm9vOw0KPj4+IH0N
Cj4+PiANCj4+PiBpcyB1bmRlc2lyYWJsZSBiZWNhdXNlIHRoZXJl4oCZcyB0b28gbXVjaCByaXNr
IHRoYXQgdGhlIGNvbmRpdGlvbnMgd2lsbCBkcmlmdCBvciBiZSBpbnZlcnRlZCBpbmNvcnJlY3Rs
eS4gQnV0IGhhdmluZyBjb250cm9sIHN0YXRlbWVudHMgbGlrZSDigJhyZXR1cm7igJkgYW5kIOKA
mGNvbnRpbnVl4oCZIGluIGEgbWFjcm8gaXMgYWxzbyB1bmRlc2lyYWJsZSBpbiBteSBvcGluaW9u
OyBJ4oCZbSBwZXJzb25hbGx5IG5vdCBzdXJlIHdoaWNoIEkgZmluZCBtb3N0IHVuZGVzaXJhYmxl
Lg0KPj4+IA0KPj4+IEkgZ3Vlc3Mgb25lIGFkdmFudGFnZSBvZiBzb21ldGhpbmcgbGlrZSBBU1NF
UlRfT1IoY29uZGl0aW9uLCByZXR1cm4gZm9vKTsgb3IgQVNTRVJUX09SKGNvbmRpdGlvbiwgY29u
dGludWUpOyBpcyB0aGF0IHNlYXJjaGluZyBmb3Ig4oCccmV0dXJu4oCdIG9yIOKAnGNvbnRpbnVl
4oCdIHdpbGwgY29tZSB1cCBldmVuIGlmIHlvdeKAmXJlIGRvaW5nIGEgY2FzZS1zZW5zaXRpdmUg
c2VhcmNoLiAgQnV0IEnigJltIHN0aWxsIHdhcnkgb2YgdW5pbnRlbmRlZCBzaWRlIGVmZmVjdHMu
DQo+Pj4gDQo+Pj4gQmVydHJhbmQgLyBKdWxpZW4sIGFueSBtb3JlIHRob3VnaHRzPw0KPj4gDQo+
PiBJIHRoaW5rIHRoYXQgaGF2aW5nIG1hY3JvcyB3aGljaCBhcmUgbWFnaWMgbGlrZSB0aGF0IG9u
ZSB3aGljaCBpbmNsdWRlcyBhIHBvc3NpYmxlIHJldHVybiBhbmQgdGhlIGZhY3QgdGhhdCB0aGUg
bWFjcm8gaXMgdGFraW5nIGNvZGUgYXMgYXJndW1lbnQgaXMgbWFraW5nIHRoZSBjb2RlIHJlYWxs
eSBoYXJkIHRvIHJlYWQgYW5kIHVuZGVyc3RhbmQgZm9yIHNvbWVvbmUgbm90IGtub3dpbmcgdGhp
cy4NCj4+IEV2ZW4gdGhlIGNvZGUgaXMgbG9uZ2VyIHJpZ2h0IG5vdywgaXQgaXMgbW9yZSByZWFk
YWJsZSBhbmQgZWFzeSB0byB1bmRlcnN0YW5kIHdoaWNoIG1lYW5zIGxlc3MgY2hhbmNlIGZvciBl
cnJvcnMgc28gSSBkbyBub3QgdGhpbmsgdGhlIG1hY3JvIHdpbGwgYXZvaWQgZXJyb3JzIGJ1dCBt
aWdodCBpbiBmYWN0IGludHJvZHVjZSBzb21lIGluIHRoZSBmdXR1cmUuDQo+PiANCj4+IFNvIEkg
YW0gdm90aW5nIHRvIGtlZXAgdGhlIGN1cnJlbnQgbWFjcm8gYXMgaXQgaXMuDQo+IA0KPiBCdXQg
eW91IHJlY2FsbCB0aGF0IHRoZXJlIHdlcmUgdHdvIGFzcGVjdHMgdG8gbWUgd2FudGluZyB0aGUg
c3dpdGNoPw0KPiAoU291cmNlKSBjb2RlIHNpemUgd2FzIG9ubHkgb25lLiBUaGUgb3RoZXIgd2Fz
IHRoYXQgQVNTRVJUX1VOUkVBQ0hBQkxFKCkNCj4gZG9lc24ndCBzaG93IHRoZSBvcmlnaW5hbCBl
eHByZXNzaW9uIHdoaWNoIGhhcyB0cmlnZ2VyZWQgdGhlIGZhaWx1cmUsDQo+IHVubGlrZSBBU1NF
UlQoKSBkb2VzLg0KDQpTb3JyeSBJIGZvY3VzZWQgb24gdGhlIG1hY3JvIHBhcnQgYWZ0ZXIgSnVs
aWVuIGFza2VkIG1lIHRvIGNvbW1lbnQgZnJvbSB0aGUgRnVzYSBwb2ludCBvZiB2aWV3Lg0KDQpU
aGUgdXN1YWwgZXhwZWN0YXRpb24gaXMgdGhhdCBhbiBBU1NFUlQgc2hvdWxkIG5ldmVyIG9jY3Vy
IGFuZCBpcyBhbiBoZWxwIGZvciB0aGUgcHJvZ3JhbW1lciB0byBkZXRlY3QgcHJvZ3JhbW1pbmcg
ZXJyb3JzLiBVc3VhbGx5IGFuIGFzc2VydCBpcyBjcmFzaGluZyB0aGUgYXBwbGljYXRpb24gd2l0
aCBhbiBpbmZvcm1hdGlvbiBvZiB3aGVyZSBhbiBhc3NlcnQgd2FzIHRyaWdnZXJlZC4NCkluIHRo
ZSBjdXJyZW50IGNhc2UsIHRoZSBhc3NlcnQgaXMgdXNlZCBhcyBkZWJ1ZyBwcmludCBhbmQgaW4g
cHJvZHVjdGlvbiBtb2RlIGFuIGVycm9yIGlzIHJldHVybmVkIGlmIHRoaXMgaXMgaGFwcGVuaW5n
IHdpdGhvdXQgYW55IHByaW50LiBJc27igJl0IHRoaXMgYSBkZWJ1ZyBwcmludCBjYXNlIGluc3Rl
YWQgb2YgYW4gYXNzZXJ0ID8NCg0KQmVydHJhbmQNCg0KPiANCj4gSmFuDQo+IA0KDQo=


From xen-devel-bounces@lists.xenproject.org Wed Feb 16 14:43:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 14:43:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274180.469546 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKLWt-0004gA-E1; Wed, 16 Feb 2022 14:43:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274180.469546; Wed, 16 Feb 2022 14:43:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKLWt-0004g3-Ax; Wed, 16 Feb 2022 14:43:39 +0000
Received: by outflank-mailman (input) for mailman id 274180;
 Wed, 16 Feb 2022 14:43:37 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Gpsw=S7=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nKLWr-0004fh-7t
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 14:43:37 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d1de4989-8f36-11ec-8eb8-a37418f5ba1a;
 Wed, 16 Feb 2022 15:43:35 +0100 (CET)
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur01lp2052.outbound.protection.outlook.com [104.47.0.52]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-38-Xsx89txWMfi30zhvZTjDJg-1; Wed, 16 Feb 2022 15:43:34 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM0PR04MB4627.eurprd04.prod.outlook.com (2603:10a6:208:74::29)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.19; Wed, 16 Feb
 2022 14:43:32 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4995.016; Wed, 16 Feb 2022
 14:43:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d1de4989-8f36-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645022615;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=PEqaFPcMnLRpPtrqqKwl5PootIdzOxCejeffTEfXtMw=;
	b=bbTn4CEwNB/3FOavdkb4Wao9jm40dzbXg/6iPirOEU1cIABRS0LSBBLA8t9w+Qb4jfBknA
	QnaLMSmOgY/+hGBAZmI9To/WFG9INqOycdmN3DxAUEMkGYMKUEqbDsZhq3jg+iBIV3Y5rD
	b1JrsZ3QRedMbqRh1Gm2GyuU+QtzDeg=
X-MC-Unique: Xsx89txWMfi30zhvZTjDJg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=lrxKd/7njuxBF6NdZAyphSxdBZOo8brXd9vBXe3LRlNB46Bnzz6MInnkI2S7WkNlt7qAkIt9wBNzYdFF4Gpklh1eqdulcXp9lbPPpAUjnU+gX58ybq9M8IZ6TDqW83dtWQHXnt2wVOoOYuxgGZioSmML90kN/A+ha/h2opQ3Ty16wRMlZe1ZG0CFhFy3lQXjkOhY4H8R6OOLio1edcxEXHva50mu0EokXgOeS3EPHOm/K3M/Wu2i2nOLdHQUPdoa1Oy3BT+fQEuxvZjep6VpUDzt8/Qv0/rojoZKS0cHwM/g3a1SdkBv0Tye3fbhKGh3JwWLoBVnNRsPfPRNg1PeHQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ukggLmPAsPBBymEjnVYTANgCficoCzGImsSNJK0N/wQ=;
 b=IQ9o5Y7Btra93lNcZBajzab9qV4Q59OUNn7WSsaOaoB63wEhnWY5axntBf/7aYX/POrnm7tqC44x5virOw1xMQ9t2EE1Z+ez+ikhIHAl1v6ITgD78unyCgGGMIp+Pxt4JrIXLb4ZbgsNJTMiRiHtJngP5HCEpmpUcTPmdixNzIc8hdsPLz9D9YEq1uHD5rbTXXL9ig3iruIqGXMvcVz835o819OhofiBKrWWopewnPtiBZZlQ6GqQvCCq0SB8+zbApV/pn/9oFSNfVYs9qMa2JWo2HSczq5ld2ww0nfDdwz2uykvSPk3ofcA+JiGW9mrzyHY/TjF8oEwAcoAIAjoMw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <99ffa08c-8482-12d2-0ca9-eccde97ecac3@suse.com>
Date: Wed, 16 Feb 2022 15:43:30 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v2] lib: extend ASSERT()
Content-Language: en-US
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <Andrew.Cooper3@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Roger Pau Monne <roger.pau@citrix.com>, Julien Grall <julien@xen.org>,
 George Dunlap <George.Dunlap@citrix.com>
References: <75125344-b0e1-9663-4c1a-84bb35870fef@suse.com>
 <35d82770-66cf-e030-5bcc-3c030e4463d7@xen.org>
 <3F58400B-5151-42F2-8F39-109DDF50EE1E@arm.com>
 <a89223c8-f59a-24cc-96a7-e40feb28813f@suse.com>
 <DB014136-7797-4A61-9681-33A7D85403AA@citrix.com>
 <732e8e39-36c4-1651-61f3-9b55caf29fe8@suse.com>
 <46408EAE-5EA4-4B22-B685-BA6D313B5D3A@citrix.com>
 <FEF187A8-0A09-4D50-A0E5-F46E014DB3E1@arm.com>
 <63811bb5-cce4-d542-461e-a24926f01b34@suse.com>
 <0BF64A25-F218-404A-8547-4896FCB27E2C@arm.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <0BF64A25-F218-404A-8547-4896FCB27E2C@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: FR3P281CA0011.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:1d::17) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 40a2fece-8637-4939-fa14-08d9f15ab471
X-MS-TrafficTypeDiagnostic: AM0PR04MB4627:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB4627CCB1E623162825FFFE39B3359@AM0PR04MB4627.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	LhmGAOEepRFVInL30Iw30yoKkO0bzJQRJr7awUBPy6YxkB+d1pQL5/AbHK1jjYUkkbqApfZ1A9ct27Eas4mmSN36K/ZEB+E8UYdYvs5v+pnI9embVAPFVtqvKKWEHnNx/LRS/poYlM2mioPuuGo2rz8FLvCEPLRksmhSUsIm1o7E5NJ3P03cFlOmE7ePLTpxz0SPT7TW1DnFMC/0jOvlf549j879pmWep/ZX+8fu3QvhrGoFxBSK/0Xn9yLnBwSGyv+4MjicQw4RzXcWbyZlBscmPD3HBx+9TsZ2uV3tcH/g9clrts6XzLp1p7s1Ub+zYPaLqZ4r3ZXuunaaJ16TMFEN3uqe7MbDS3an+p3KPfRGriKsnrpVtNZL+mQ945GM/rRPyTc7qyvw++FcH+VpbvKUf9uBEnk1is0aNdNrJT0FGPG7pqboeq2h8PaByxfEOLB99ajYet/2Hvpopg2C9l9/MnS5o8Kq9++NggvtVV4HjS28C5B/aOeLz2GurSbC+33LZKvdB5zHkpXmnyTyQkeUZsC2AJIonIRub6t9O9boN66e+/lJDUMJAJVWWFQMEtnPxDb29/o1zcK+IDZLc4FQZX87nYWqaMvEwmCli+/TaqFfD5SiE1gRMm8hYOgZyyUb4GxKj3QY3Jf8IG0sn15bq3SfeDypJPhdZ08x4K4USwWxpo+INh7an+4kC4yH9GH+tGJpgLtLpo6ZG59yVK5pM7TE6AegaNHirXbBWXKozBgsTerKoGYBWbmUjRqw
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(86362001)(31696002)(31686004)(26005)(6512007)(2616005)(6506007)(186003)(66946007)(38100700002)(8676002)(4326008)(2906002)(8936002)(6486002)(54906003)(36756003)(6916009)(53546011)(66556008)(83380400001)(508600001)(66476007)(316002)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?bh2xunCSnkOSCl2MWRkE3TwlBt9C/nfCcKPdKzls8hv/aC74yAiorx/xjYqu?=
 =?us-ascii?Q?R/wcNCaFAx7CHCPUltNq9TKF06kRoGmiBfzr50EeEyUctJk/W9yaFfkTEq4Y?=
 =?us-ascii?Q?ItrGPO7dG11vakQs7DHcGeivFdSEMvmUTLoRt6lDPeMiACpaYY7pd8T2k0zG?=
 =?us-ascii?Q?HA5ibiShAWzoGjBKJ5H8o+dJw9wzFtOE+XRE0BpOJPN/GdNoQU6VlTJsB6GU?=
 =?us-ascii?Q?leeQrnjh3HfF2VddXWCOt50QAg8/lhNhjBUDdmVoZqFG7GRjx0X6f9Z4flMO?=
 =?us-ascii?Q?ZSGKMIv7Nfa8M3JGPGnybPWnZCN1KCXSZEbkFWlYTTqVBJ/TUozDLQ/SEHKC?=
 =?us-ascii?Q?8k6h5uLfngs13b9G7Jl3VjQyq3eMqhQy09HTQguaR5Yi7JnGzJ4QY8FotiCK?=
 =?us-ascii?Q?IBHgoM4EggYjbTkUY3fDuZa9jOwrB3vyrb3fNURfWtroqJAhFbcMPVOA/4tm?=
 =?us-ascii?Q?0pKO0Ct44afIsmGcsAQj2ZNP4YgkD0ZesP0D6tvwrDOA0eX7pKCBO4BRAP20?=
 =?us-ascii?Q?3rPFUVUWzOTEQJ9DwDt4cPbcbSPJZ2/eAZnAfXEERHrAOTAzYln4ppGsk5Fd?=
 =?us-ascii?Q?2bfG2Ikx3dBLSZHbw9lqjbu8DzIQhEcJ6isf1yMXhVPNrwSbd0kLgUuJaIMr?=
 =?us-ascii?Q?x+8MdQzjcwUNkyqZ8UJpxQbxUVejhsBwwvjMa+1SXAhD/mVy9MpFzqtSB3iC?=
 =?us-ascii?Q?v1UpcmT+9w3MUUGU6hxPDiU6GbUxKDwwFdOO1MLM/1ZrMnWLwv49qA6PQp9K?=
 =?us-ascii?Q?3UirCNTbClekSjqA6NNxh8rzj31SQuC8KSIe49ivElMsDozl9Qk28l6gcuxq?=
 =?us-ascii?Q?FHVDnmBp0obUZ/85uOpixGVbI4IDGN3sG9OpZtucKv/B2XRYpLr9E3hd4r2R?=
 =?us-ascii?Q?AZ52F53CwAQQLsKQrCu0EuEUaJn/rkMeMRORVHZ7j/5cQRR4rEgCy5txxssW?=
 =?us-ascii?Q?/DyIr8jmgy02/BXWYmw/Y3mPI7HuU2qZRVI8f2AFf4Pz8AVXc6JFUGC8ZvG+?=
 =?us-ascii?Q?6Ezv/RCgo03OZdw7EolMnUi+T85xerQd8ZloYpPV8JCV6675w4xpbLpFlun6?=
 =?us-ascii?Q?lwPiOzEeAdS5WXUmEDR7FtPHCIPQlDGnFc6XDGgIIsO46KMq47dAJgvbsKZX?=
 =?us-ascii?Q?xYasMTSjb+ebSdsc6BpdceUCOGZzuCsEPi/dNOKVwkRSo3qEMtjpeMdtZi15?=
 =?us-ascii?Q?95PmldnsGTjO6Nvf3qZe6R0ODLR1YVZ84QTjHYg2BbvDNg7peNxieBDqFhAc?=
 =?us-ascii?Q?9ZZSzeZ2eEWD1A+Tw8PLBGWgpFjInottJ7+XQbzNAqpLJJG6RKNeGX6+XkHN?=
 =?us-ascii?Q?05dnNxcFYdUAKAxDFYEQ5r5d51aGjCl40Xn6syq3Z/xyBCd3f8lwaEPsvRcW?=
 =?us-ascii?Q?raYaw55zjlwi3U/RQ1O3+iPehjZzURSlYOLFAvfbR4he7XUr++BDIDg940Kj?=
 =?us-ascii?Q?K9weP1Z6Fug4D00RgI9GnMTIBk2KtE2w5BBlpFCyFk94M3yahSPwyyh+se7O?=
 =?us-ascii?Q?qneO4myKhudr14jsp54jfABkZQisdbOmW5kesRPkSG2UXKCyiD2F4ttE4Fp/?=
 =?us-ascii?Q?6G2jP4PEtF1wmFjAQk3eF9NirpQjz1h6N25yZDuhyEi0jdRf7ChItXYcdvcn?=
 =?us-ascii?Q?gR1lzsShvvgZNfh/7uhT0EA=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 40a2fece-8637-4939-fa14-08d9f15ab471
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2022 14:43:32.7292
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QmQIpLVMANkobZRPxi1LEoM0SjdO8a4nanysCfbNy0qvtWkaVuhT8xz4kfSCpCu6E++7Ku2hrVtTw/u3UfdBLA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4627

On 16.02.2022 15:35, Bertrand Marquis wrote:
> Hi Jan,
>=20
>> On 16 Feb 2022, at 14:03, Jan Beulich <jbeulich@suse.com> wrote:
>>
>> On 16.02.2022 14:57, Bertrand Marquis wrote:
>>>> On 16 Feb 2022, at 12:23, George Dunlap <George.Dunlap@citrix.com> wro=
te:
>>>>> On Feb 16, 2022, at 11:42 AM, Jan Beulich <jbeulich@suse.com> wrote:
>>>>> On 16.02.2022 12:34, George Dunlap wrote:
>>>>>> I am opposed to overloading =E2=80=9CASSERT=E2=80=9D for this new ki=
nd of macro; I think it would not only be unnecessarily confusing to people=
 not familiar with our codebase, but it would be too easy for people to fai=
l to notice which macro was being used.
>>>>>>
>>>>>> ASSERT_ACTION(condition, code) (or even ASSERT_OR_ACTION()) would be=
 a bare minimum for me.
>>>>>>
>>>>>> But I can=E2=80=99t imagine that there are more than a handful of ac=
tions we might want to take, so defining a macro for each one shouldn=E2=80=
=99t be too burdensome.
>>>>>>
>>>>>> Furthermore, the very flexibility seems dangerous; you=E2=80=99re no=
t seeing what actual code is generated, so it=E2=80=99s to easy to be =E2=
=80=9Cclever=E2=80=9D, and/or write code that ends up doing something diffe=
rent than you expect.
>>>>>>
>>>>>> At the moment I think ASSERT_OR_RETURN(condition, code), plus other =
new macros for the other behavior is needed, would be better.
>>>>>
>>>>> Hmm, while I see your point of things possibly looking confusing or
>>>>> unexpected, something like ASSERT_OR_RETURN() (shouldn't it be
>>>>> ASSERT_AND_RETURN()?) is imo less readable. In particular I dislike
>>>>> the larger amount of uppercase text. But yes, I could accept this
>>>>> as a compromise as it still seems better to me than the multi-line
>>>>> constructs we currently use.
>>>>
>>>> I see what you=E2=80=99re saying with AND/OR; I personally still prefe=
r OR but wouldn=E2=80=99t argue to hard against AND if others preferred it.
>>>>
>>>> As far as I=E2=80=99m concerned, the fact that we=E2=80=99re reducing =
lines of code isn=E2=80=99t a reason to use this at all.  As our CODING_STY=
LE says, ASSERT() is just a louder printk.  We would never consider writing=
 PRINTK_AND_RETURN(), and we would never consider writing a macro like COND=
RET(condition, retval) to replace
>>>>
>>>> if (condition)
>>>>   return retval;
>>>>
>>>> The only justification for this kind of macro, in my opinion, is to av=
oid duplication errors; i.e. replacing your code segment with the following=
:
>>>>
>>>> if (condition) {
>>>>   ASSERT(!condition);
>>>>   return foo;
>>>> }
>>>>
>>>> is undesirable because there=E2=80=99s too much risk that the conditio=
ns will drift or be inverted incorrectly. But having control statements lik=
e =E2=80=98return=E2=80=99 and =E2=80=98continue=E2=80=99 in a macro is als=
o undesirable in my opinion; I=E2=80=99m personally not sure which I find m=
ost undesirable.
>>>>
>>>> I guess one advantage of something like ASSERT_OR(condition, return fo=
o); or ASSERT_OR(condition, continue); is that searching for =E2=80=9Cretur=
n=E2=80=9D or =E2=80=9Ccontinue=E2=80=9D will come up even if you=E2=80=99r=
e doing a case-sensitive search.  But I=E2=80=99m still wary of unintended =
side effects.
>>>>
>>>> Bertrand / Julien, any more thoughts?
>>>
>>> I think that having macros which are magic like that one which includes=
 a possible return and the fact that the macro is taking code as argument i=
s making the code really hard to read and understand for someone not knowin=
g this.
>>> Even the code is longer right now, it is more readable and easy to unde=
rstand which means less chance for errors so I do not think the macro will =
avoid errors but might in fact introduce some in the future.
>>>
>>> So I am voting to keep the current macro as it is.
>>
>> But you recall that there were two aspects to me wanting the switch?
>> (Source) code size was only one. The other was that ASSERT_UNREACHABLE()
>> doesn't show the original expression which has triggered the failure,
>> unlike ASSERT() does.
>=20
> Sorry I focused on the macro part after Julien asked me to comment from t=
he Fusa point of view.
>=20
> The usual expectation is that an ASSERT should never occur and is an help=
 for the programmer to detect programming errors. Usually an assert is cras=
hing the application with an information of where an assert was triggered.
> In the current case, the assert is used as debug print and in production =
mode an error is returned if this is happening without any print. Isn=E2=80=
=99t this a debug print case instead of an assert ?

Depends on the terminology you want to use: Our ASSERT() is in no way
different in this regard from the C standard's assert(). The message
logged is of course to aid the developers. But personally I'd call it
more than just a "debug print".

Jan



From xen-devel-bounces@lists.xenproject.org Wed Feb 16 15:09:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 15:09:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274199.469577 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKLvV-0007Pv-PD; Wed, 16 Feb 2022 15:09:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274199.469577; Wed, 16 Feb 2022 15:09:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKLvV-0007Po-LD; Wed, 16 Feb 2022 15:09:05 +0000
Received: by outflank-mailman (input) for mailman id 274199;
 Wed, 16 Feb 2022 15:09:04 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nKLvU-0007Pe-DP; Wed, 16 Feb 2022 15:09:04 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nKLvU-000284-AD; Wed, 16 Feb 2022 15:09:04 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nKLvT-0001Im-PU; Wed, 16 Feb 2022 15:09:03 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nKLvT-0002Cs-Ox; Wed, 16 Feb 2022 15:09:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=poGTeOY1FpTbNFY5rjrzcvbA3RgJNzwD2M8fIOKnZDs=; b=cWQFuOjUfHdXaB0aEvHzGDITh0
	zhNnJcbKQUVfcs/HgR9L+FvtmMA+mS68Kxnq0k892bVzkXDawpn4Eh2do3s5cOjNdSiE85Rp+UhgS
	VEdYXPTO/6lrLbsUucJJpBLta4+aVB2pDwf7k35iWttvI5FevojzC8BPdjiAHMvzOADE=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168126-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 168126: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=c5d9ae265b105d9a67575fb67bd4650a6fc08e25
X-Osstest-Versions-That:
    linux=705d84a366cfccda1e7aec1113a5399cd2ffee7d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 16 Feb 2022 15:09:03 +0000

flight 168126 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168126/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10       fail  like 168121
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168121
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168121
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168121
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168121
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168121
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168121
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168121
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168121
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                c5d9ae265b105d9a67575fb67bd4650a6fc08e25
baseline version:
 linux                705d84a366cfccda1e7aec1113a5399cd2ffee7d

Last test of basis   168121  2022-02-15 17:42:38 Z    0 days
Testing same since   168126  2022-02-16 04:32:24 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alex Henrie <alexhenrie24@gmail.com>
  Basavaraj Natikar <Basavaraj.Natikar@amd.com>
  Benjamin Tissoires <benjamin.tissoires@redhat.com>
  Daniel Thompson <daniel.thompson@linaro.org>
  David Woodhouse <dwmw@amazon.co.uk>
  Dongliang Mu <mudongliangabcd@gmail.com>
  Jim Mattson <jmattson@google.com>
  Jiri Kosina <jkosina@suse.cz>
  Linus Torvalds <torvalds@linux-foundation.org>
  Marc Zyngier <maz@kernel.org>
  Maxim Levitsky <mlevitsk@redhat.com>
  Muhammad Usama Anjum <usama.anjum@collabora.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Ricardo Koller <ricarkol@google.com>
  Sean Christopherson <seanjc@google.com>
  Sergio Costas <rastersoft@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   705d84a366cf..c5d9ae265b10  c5d9ae265b105d9a67575fb67bd4650a6fc08e25 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Wed Feb 16 15:16:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 15:16:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274219.469634 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKM2m-0001Fd-HY; Wed, 16 Feb 2022 15:16:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274219.469634; Wed, 16 Feb 2022 15:16:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKM2m-0001FL-Az; Wed, 16 Feb 2022 15:16:36 +0000
Received: by outflank-mailman (input) for mailman id 274219;
 Wed, 16 Feb 2022 15:16:35 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=miT7=S7=gmail.com=andr2000@srs-se1.protection.inumbo.net>)
 id 1nKM2l-0000ia-8g
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 15:16:35 +0000
Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com
 [2a00:1450:4864:20::229])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6d7fc221-8f3b-11ec-8eb8-a37418f5ba1a;
 Wed, 16 Feb 2022 16:16:34 +0100 (CET)
Received: by mail-lj1-x229.google.com with SMTP id c15so3779180ljf.11
 for <xen-devel@lists.xenproject.org>; Wed, 16 Feb 2022 07:16:34 -0800 (PST)
Received: from a2klaptop.localdomain ([185.199.97.5])
 by smtp.gmail.com with ESMTPSA id bt2sm3082357lfb.93.2022.02.16.07.16.32
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 16 Feb 2022 07:16:32 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6d7fc221-8f3b-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=+ORkUu56CU6HGY8oCapGyNoSUW812hUexJ6w29f/gaw=;
        b=cPsCuLNUCp/mAbeiTz7Ea9oexvjfKLEeXyM4EJ7w+M8wZJ7cW/CghjXa3J+Yqii44b
         yMuNZJpfCHjBeHzIVhtk5jph/ON+iuyGZnBG1bD/R28SRTGWoZeGceNfJZEyqvgQmvj4
         i7El2Mzpbn2z0yYz0KAXXbZ9jLBXYc3QgiuiOiVWIVZmPUL3WkCIEoWStTcO6DZ+rW6k
         U1TxrV/fjn1BoCkWZwiVd5MG2mO5lhAE1ssX1H8UsbKHz80ibLFZjn1EComdHg+fgHHj
         0Uxle6Y5n2etoFwX7Q1a+KY/C9enzTR55NXbXFprFqX7ekC4Yn1zU6eq9jkmXYBQzwrt
         FBDw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=+ORkUu56CU6HGY8oCapGyNoSUW812hUexJ6w29f/gaw=;
        b=laTvvgKMWeVlwCLCJOVqxVpG+EMRQtAoj4J8zLYcT7E2z1vwxwP7zXOeRlPKMePfu3
         /aflLHrdPUJbaKN3bZ54Hl/RbN490sfIEvgplNS46fTX7h+CdNx8yxJgPaJKEhEYfASU
         y1zOOm464Ku1MjhILiMe5lxSLsWIRzLSZodxk6+dgNdTaodSTXVRGj7i4Qkohdz+Iv34
         gH9EkgwPzLVCV7LIbdGg2e9n0B+h3hsbpCE89ekld8FbzuUXuPR92GtuWXk9w6XQBWiC
         StLftaV5yYmrWl7PA1nPRlkXSLP/BdbRttoAP7MT0uzO5PCbmcW/Hv61souK99Ga9P0V
         4jmw==
X-Gm-Message-State: AOAM531nqEp/xXh4zjnUkFrEAJkUtb54EXUC5MCiyqfg+Nvn1JKfnZbv
	PVUwmULszm7QHOKGnEc3SIdOzQ7D2q8=
X-Google-Smtp-Source: ABdhPJxDYrdyScCegh3iYn/DlxcOxXd/KOxJ/b5f2U0ecvwx/kfDsZpJ6qUQoFHk6MIe+Kfo1c4e5Q==
X-Received: by 2002:a2e:b891:0:b0:23a:ee88:844b with SMTP id r17-20020a2eb891000000b0023aee88844bmr2456330ljp.402.1645024593157;
        Wed, 16 Feb 2022 07:16:33 -0800 (PST)
From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: roger.pau@citrix.com,
	jbeulich@suse.com,
	julien@xen.org,
	sstabellini@kernel.org,
	oleksandr_tyshchenko@epam.com,
	volodymyr_babchuk@epam.com,
	artem_mygaiev@epam.com,
	bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: [PATCH 2/4] vpci: restrict unhandled read/write operations for guests
Date: Wed, 16 Feb 2022 17:16:26 +0200
Message-Id: <20220216151628.1610777-3-andr2000@gmail.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220216151628.1610777-1-andr2000@gmail.com>
References: <20220216151628.1610777-1-andr2000@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

A guest would be able to read and write those registers which are not
emulated and have no respective vPCI handlers, so it will be possible
for it to access the hardware directly.
In order to prevent a guest from reads and writes from/to the unhandled
registers make sure only hardware domain can access the hardware directly
and restrict guests from doing so.

Suggested-by: Roger Pau Monné <roger.pau@citrix.com>
Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

---
Since v6:
- do not use is_hwdom parameter for vpci_{read|write}_hw and use
  current->domain internally
- update commit message
New in v6
---
 xen/drivers/vpci/vpci.c | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/xen/drivers/vpci/vpci.c b/xen/drivers/vpci/vpci.c
index fb0947179b79..f564572a51cb 100644
--- a/xen/drivers/vpci/vpci.c
+++ b/xen/drivers/vpci/vpci.c
@@ -213,6 +213,10 @@ static uint32_t vpci_read_hw(pci_sbdf_t sbdf, unsigned int reg,
 {
     uint32_t data;
 
+    /* Guest domains are not allowed to read real hardware. */
+    if ( !is_hardware_domain(current->domain) )
+        return ~(uint32_t)0;
+
     switch ( size )
     {
     case 4:
@@ -253,9 +257,13 @@ static uint32_t vpci_read_hw(pci_sbdf_t sbdf, unsigned int reg,
     return data;
 }
 
-static void vpci_write_hw(pci_sbdf_t sbdf, unsigned int reg, unsigned int size,
-                          uint32_t data)
+static void vpci_write_hw(pci_sbdf_t sbdf, unsigned int reg,
+                          unsigned int size, uint32_t data)
 {
+    /* Guest domains are not allowed to write real hardware. */
+    if ( !is_hardware_domain(current->domain) )
+        return;
+
     switch ( size )
     {
     case 4:
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Feb 16 15:16:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 15:16:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274218.469622 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKM2l-0000yZ-2W; Wed, 16 Feb 2022 15:16:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274218.469622; Wed, 16 Feb 2022 15:16:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKM2k-0000yQ-V7; Wed, 16 Feb 2022 15:16:34 +0000
Received: by outflank-mailman (input) for mailman id 274218;
 Wed, 16 Feb 2022 15:16:33 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=miT7=S7=gmail.com=andr2000@srs-se1.protection.inumbo.net>)
 id 1nKM2j-0000ia-Gd
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 15:16:33 +0000
Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com
 [2a00:1450:4864:20::134])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6c6fe179-8f3b-11ec-8eb8-a37418f5ba1a;
 Wed, 16 Feb 2022 16:16:32 +0100 (CET)
Received: by mail-lf1-x134.google.com with SMTP id f37so4414142lfv.8
 for <xen-devel@lists.xenproject.org>; Wed, 16 Feb 2022 07:16:32 -0800 (PST)
Received: from a2klaptop.localdomain ([185.199.97.5])
 by smtp.gmail.com with ESMTPSA id bt2sm3082357lfb.93.2022.02.16.07.16.30
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 16 Feb 2022 07:16:31 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6c6fe179-8f3b-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=ZBCrQj2lwFzNomdp2NiauAmt+Mty9vunRDBJMAz0cCY=;
        b=Ai0VY8bkdyCx673J/QNboO6zC0ztb8oEypvUaqAWMKiHZpZ9kZHNhnNoBv8K9GhR0b
         u2CHNI0W5hTY44LcHYvRb2l+jxZdUI6Dcn4lpThT+katfuO2R5yhvO/npS0hdM3MaTrM
         zq62uqAs1yET2T44+O5Q/vdV1oCdyv3RF4XlHnlZKeP6SxWxiKTJgV6l7HmfgMpmNhJe
         bu1+i+0JJ/g1CQHaOIbj4fTVGndgvOSIcpqmn3L2o3qyI+cwZWoDO1W4R0WsWb1SLLKh
         Ot2DbmXAWjtWXXyf5u/+3GKuMEhkY1pPAMR6S6QHGOD34qkgMC2xwfzoEQ6N4lTLQsLy
         TU9A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=ZBCrQj2lwFzNomdp2NiauAmt+Mty9vunRDBJMAz0cCY=;
        b=GjfqcMNYVq1EE0k5rJBFKupfxph1QQiz1fv0vL1xO5jIjXvI0n0MOYbGRbSDissCLb
         nM3FVyXLM6LZ6NEkya6Hl6ZTl/ukCY2fhnayc/xrWTiNjNTCcCLxkbO81HT0f0TZt5L1
         ip9XG9E8BXkz4sbXUb6PD3zmwKCByOlauYdsVDQcHVu67vAjrRpogU3NoQvlrw7gBoCo
         0Pd7JPBsPHBCI0EiWRObJBi2IOmOGEhBoDse8I5DgYfI/YqCQ9miaHtLDB9RMLwyOicc
         2otBUKZvEiGoWqN2X6APNjEvmP/p9MG4V1eqIYukcrDjDzhkWLgvyil9BlMB3AUUo1LD
         R1lg==
X-Gm-Message-State: AOAM533Qv1+gqwonshQZD6p3h5pKYoJe/TK4+kjtngnAZ57kIAtqv8F7
	qfdswxQmOrN9Rh6xEV+szmEGKFPfdTg=
X-Google-Smtp-Source: ABdhPJwS/eNqTVLggc40y8HHbv3uipeAY422byje3hbaUB099wArdAJ5Hix4jdXxi9QwZIcucwHrgw==
X-Received: by 2002:a05:6512:220e:b0:439:cb39:cb83 with SMTP id h14-20020a056512220e00b00439cb39cb83mr2258047lfu.551.1645024591977;
        Wed, 16 Feb 2022 07:16:31 -0800 (PST)
From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: roger.pau@citrix.com,
	jbeulich@suse.com,
	julien@xen.org,
	sstabellini@kernel.org,
	oleksandr_tyshchenko@epam.com,
	volodymyr_babchuk@epam.com,
	artem_mygaiev@epam.com,
	bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: [PATCH 1/4] pci: add rwlock to pcidevs_lock machinery
Date: Wed, 16 Feb 2022 17:16:25 +0200
Message-Id: <20220216151628.1610777-2-andr2000@gmail.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220216151628.1610777-1-andr2000@gmail.com>
References: <20220216151628.1610777-1-andr2000@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

Currently pcidevs lock is a global recursive spinlock which is fine for
the existing use cases. It is used to both protect pdev instances
themselves from being removed while in use and to make sure the update
of the relevant pdev properties is synchronized.

Moving towards vPCI is used for guests this becomes problematic in terms
of lock contention. For example, during vpci_{read|write} the access to
pdev must be protected to prevent pdev disappearing under our feet.
This needs to be done with the help of pcidevs_{lock|unlock}.
On the other hand it is highly undesirable to lock all other pdev accesses
which only use pdevs in read mode, e.g. those which do not remove or
add pdevs.

For the above reasons introduce a read/write lock which will help
preventing locking contentions between pdev readers and writers:
- make pci_{add|remove}_device and setup_hwdom_pci_devices use the
  new write lock
- keep all the rest using the existing API (pcidevs_{lock|unlock},
  but extend the later to also acquire the rwlock in read mode.

This is in preparation for vPCI to be used for guests.

Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
---
 xen/drivers/passthrough/pci.c | 45 ++++++++++++++++++++++++++---------
 xen/include/xen/pci.h         |  4 ++++
 2 files changed, 38 insertions(+), 11 deletions(-)

diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
index e8b09d77d880..2a0d3d37a69f 100644
--- a/xen/drivers/passthrough/pci.c
+++ b/xen/drivers/passthrough/pci.c
@@ -51,20 +51,38 @@ struct pci_seg {
 };
 
 static spinlock_t _pcidevs_lock = SPIN_LOCK_UNLOCKED;
+static DEFINE_RWLOCK(_pcidevs_rwlock);
 
 void pcidevs_lock(void)
 {
+    read_lock(&_pcidevs_rwlock);
     spin_lock_recursive(&_pcidevs_lock);
 }
 
 void pcidevs_unlock(void)
 {
     spin_unlock_recursive(&_pcidevs_lock);
+    read_unlock(&_pcidevs_rwlock);
 }
 
 bool_t pcidevs_locked(void)
 {
-    return !!spin_is_locked(&_pcidevs_lock);
+    return !!spin_is_locked(&_pcidevs_lock) || pcidevs_write_locked();
+}
+
+void pcidevs_write_lock(void)
+{
+    write_lock(&_pcidevs_rwlock);
+}
+
+void pcidevs_write_unlock(void)
+{
+    write_unlock(&_pcidevs_rwlock);
+}
+
+bool pcidevs_write_locked(void)
+{
+    return !!rw_is_write_locked(&_pcidevs_rwlock);
 }
 
 static struct radix_tree_root pci_segments;
@@ -758,7 +776,7 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
 
     ret = -ENOMEM;
 
-    pcidevs_lock();
+    pcidevs_write_lock();
     pseg = alloc_pseg(seg);
     if ( !pseg )
         goto out;
@@ -854,7 +872,7 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
     pci_enable_acs(pdev);
 
 out:
-    pcidevs_unlock();
+    pcidevs_write_unlock();
     if ( !ret )
     {
         printk(XENLOG_DEBUG "PCI add %s %pp\n", pdev_type,  &pdev->sbdf);
@@ -885,7 +903,7 @@ int pci_remove_device(u16 seg, u8 bus, u8 devfn)
     if ( !pseg )
         return -ENODEV;
 
-    pcidevs_lock();
+    pcidevs_write_lock();
     list_for_each_entry ( pdev, &pseg->alldevs_list, alldevs_list )
         if ( pdev->bus == bus && pdev->devfn == devfn )
         {
@@ -899,7 +917,7 @@ int pci_remove_device(u16 seg, u8 bus, u8 devfn)
             break;
         }
 
-    pcidevs_unlock();
+    pcidevs_write_unlock();
     return ret;
 }
 
@@ -1176,6 +1194,11 @@ static void __hwdom_init setup_one_hwdom_device(const struct setup_hwdom *ctxt,
                ctxt->d->domain_id, err);
 }
 
+/*
+ * It's safe to drop and re-acquire the write lock in this context without
+ * risking pdev disappearing because devices cannot be removed until the
+ * initial domain has been started.
+ */
 static int __hwdom_init _setup_hwdom_pci_devices(struct pci_seg *pseg, void *arg)
 {
     struct setup_hwdom *ctxt = arg;
@@ -1208,17 +1231,17 @@ static int __hwdom_init _setup_hwdom_pci_devices(struct pci_seg *pseg, void *arg
 
             if ( iommu_verbose )
             {
-                pcidevs_unlock();
+                pcidevs_write_unlock();
                 process_pending_softirqs();
-                pcidevs_lock();
+                pcidevs_write_lock();
             }
         }
 
         if ( !iommu_verbose )
         {
-            pcidevs_unlock();
+            pcidevs_write_unlock();
             process_pending_softirqs();
-            pcidevs_lock();
+            pcidevs_write_lock();
         }
     }
 
@@ -1230,9 +1253,9 @@ void __hwdom_init setup_hwdom_pci_devices(
 {
     struct setup_hwdom ctxt = { .d = d, .handler = handler };
 
-    pcidevs_lock();
+    pcidevs_write_lock();
     pci_segments_iterate(_setup_hwdom_pci_devices, &ctxt);
-    pcidevs_unlock();
+    pcidevs_write_unlock();
 }
 
 /* APEI not supported on ARM yet. */
diff --git a/xen/include/xen/pci.h b/xen/include/xen/pci.h
index b6d7e454f814..e814d9542bfc 100644
--- a/xen/include/xen/pci.h
+++ b/xen/include/xen/pci.h
@@ -152,6 +152,10 @@ void pcidevs_lock(void);
 void pcidevs_unlock(void);
 bool_t __must_check pcidevs_locked(void);
 
+void pcidevs_write_lock(void);
+void pcidevs_write_unlock(void);
+bool __must_check pcidevs_write_locked(void);
+
 bool_t pci_known_segment(u16 seg);
 bool_t pci_device_detect(u16 seg, u8 bus, u8 dev, u8 func);
 int scan_pci_devices(void);
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Feb 16 15:16:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 15:16:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274217.469612 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKM2j-0000iz-RM; Wed, 16 Feb 2022 15:16:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274217.469612; Wed, 16 Feb 2022 15:16:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKM2j-0000is-NJ; Wed, 16 Feb 2022 15:16:33 +0000
Received: by outflank-mailman (input) for mailman id 274217;
 Wed, 16 Feb 2022 15:16:32 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=miT7=S7=gmail.com=andr2000@srs-se1.protection.inumbo.net>)
 id 1nKM2i-0000ia-IA
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 15:16:32 +0000
Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com
 [2a00:1450:4864:20::132])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6bc47f17-8f3b-11ec-8eb8-a37418f5ba1a;
 Wed, 16 Feb 2022 16:16:31 +0100 (CET)
Received: by mail-lf1-x132.google.com with SMTP id g39so4399766lfv.10
 for <xen-devel@lists.xenproject.org>; Wed, 16 Feb 2022 07:16:31 -0800 (PST)
Received: from a2klaptop.localdomain ([185.199.97.5])
 by smtp.gmail.com with ESMTPSA id bt2sm3082357lfb.93.2022.02.16.07.16.29
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 16 Feb 2022 07:16:30 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6bc47f17-8f3b-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=MXnLYo9xw7ZM5aZsNEA3HWbbU8vuMQcB/bLy8UKaVuQ=;
        b=ARmfTXWxdhS34dRh/av2rd2PbcIWokFO9C10alyy0EkcIfQLbfwIJVwng3jn6Ne/wS
         ZvcxSz9NkT0ftRdsmFXd3QkTMjvSHqqcbDHtAXt3HJ6Z9lPiBquJMz0uy4oaRoUgB6mz
         F9c90x1+1Se+pPmlksq9xfH6fEKalLXzR6re5ngimNIDhS3eeJxka6b6FKlmF9Z/jH0O
         266FPoja2tHluKwWu7bIGqEB0m1KpNCIwTJp+KsrPjzlfWFCox1WraIrg6MVMVxSWL/r
         j2U02Xg87Jaj6p6fmqDXpWFhz3lUdgvfbAo/WoU6q2bUYmBPPEnjRUfu2GDQw8SlPOjS
         U1fw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=MXnLYo9xw7ZM5aZsNEA3HWbbU8vuMQcB/bLy8UKaVuQ=;
        b=pYcBFROdBUhfSPIo/+3GoNspEOSPPIpfUS1k7knezIljIJ+1tLa/zBGl0KSkBrG/nX
         jdjAhhs8YzFhU5T7rdUYX8hxCD1z3qt8hOy/xdiD6neXpQH0imh8ZP5JxG6NYWqiJKMg
         16h2Obe2Qtw/rKEiwlRMMoCrIYb6BqVqkEzpAkVXT+Nj8RRSW97LXT+cU8uXhnFstVL0
         hDJI2Qokc4OPtpyoFJ1wueSrH8komVFl2h/py8JV/jlARuJUPZnNgiqajiHKi/vXtNbl
         BXfwMWyj/qe2G/SB2/n1uteQbtUgkjx3ha8DvS6rwuIvNPiuXjlMU+Ev8TI1fnMp0qtk
         DSZA==
X-Gm-Message-State: AOAM5331pHiNc9/dV3ER+OFALxsxE3+iUjEC7IpN1SVo68bRpGRRxbh7
	SWEi1ilRy88ApdjojDFMAHMrNOjg08Q=
X-Google-Smtp-Source: ABdhPJwthWqJXtZl14ZghIYODOBpHT6wWzje4495Bm9dc+pJoerUNbnUhdeElbQLAHfMELC+WhlT5A==
X-Received: by 2002:a05:6512:3b0f:b0:42d:1ebb:dcbf with SMTP id f15-20020a0565123b0f00b0042d1ebbdcbfmr2261329lfv.275.1645024590841;
        Wed, 16 Feb 2022 07:16:30 -0800 (PST)
From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: roger.pau@citrix.com,
	jbeulich@suse.com,
	julien@xen.org,
	sstabellini@kernel.org,
	oleksandr_tyshchenko@epam.com,
	volodymyr_babchuk@epam.com,
	artem_mygaiev@epam.com,
	bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: [PATCH 0/4] Yet another pci/vpci locking re-work
Date: Wed, 16 Feb 2022 17:16:24 +0200
Message-Id: <20220216151628.1610777-1-andr2000@gmail.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

Hello, all!

This is a yet another attempt to re-work the existing pci/vpci locking
scheme towards vPCI is going to be used for guests.
For more details on the previous attempts and their flaws please see [1], [2].

This work is based on the idea that it is possible to extend the
existing locking scheme by additionally providing a global read/write lock:

This way most of the code continues to use pcidevs_{lock|unlock}, so
only minor changes are required which do not lead to functional changes
seen by the users: these become readers with respect to the new rwlock
and they acquire _pcidevs_lock as before.

As to the writers (those which can add/remove pci devices and their
respective pdev) we need to make them use the new rwlock in write mode.
For that we introduce pcidevs_write_{un}lock helpers.

Those users, which do not add/remove pdevs and are only interested in
pdev->vpci or simple pdev's list traversal, will use
pcidevs_read_{lock|unlock} which only acquires the rwlock in read mode
without acquiring _pcidevs_lock. This is to make sure there is no
unnecessary contention for the later. For the cases when it is required
to make sure that no other CPU can access critical sections under the
read lock (modify_bars for example) it is possible to upgrade it to a
normal pcidevs_lock due to both read lock and _pcidevs_lock allow
recursion.

The series was tested on:
 - x86 PVH Dom0 and doesn't break it.
 - x86 HVM with PCI passthrough to DomU and doesn't break it.

Thank you,
Oleksandr

[1] https://lore.kernel.org/xen-devel/20180717094830.54806-2-roger.pau@citrix.com/
[2] https://lore.kernel.org/all/20220204063459.680961-4-andr2000@gmail.com/

Oleksandr Andrushchenko (4):
  pci: add rwlock to pcidevs_lock machinery
  vpci: restrict unhandled read/write operations for guests
  vpci: use pcidevs locking to protect MMIO handlers
  vpci: resolve possible clash while removing BAR overlaps

 xen/arch/x86/hvm/vmsi.c       | 24 +++++++++++--
 xen/drivers/passthrough/pci.c | 65 +++++++++++++++++++++++++++++------
 xen/drivers/vpci/header.c     | 30 ++++++++++++++--
 xen/drivers/vpci/msi.c        | 21 +++++++----
 xen/drivers/vpci/msix.c       | 55 +++++++++++++++++++++++++----
 xen/drivers/vpci/vpci.c       | 34 +++++++++++++++---
 xen/include/xen/pci.h         |  9 +++++
 xen/include/xen/vpci.h        |  2 +-
 8 files changed, 205 insertions(+), 35 deletions(-)

-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Feb 16 15:16:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 15:16:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274220.469645 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKM2n-0001Wu-Of; Wed, 16 Feb 2022 15:16:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274220.469645; Wed, 16 Feb 2022 15:16:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKM2n-0001W8-Jh; Wed, 16 Feb 2022 15:16:37 +0000
Received: by outflank-mailman (input) for mailman id 274220;
 Wed, 16 Feb 2022 15:16:36 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=miT7=S7=gmail.com=andr2000@srs-se1.protection.inumbo.net>)
 id 1nKM2m-0001Dp-JB
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 15:16:36 +0000
Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com
 [2a00:1450:4864:20::231])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6dcb8634-8f3b-11ec-b215-9bbe72dcb22c;
 Wed, 16 Feb 2022 16:16:35 +0100 (CET)
Received: by mail-lj1-x231.google.com with SMTP id c10so3784777ljr.9
 for <xen-devel@lists.xenproject.org>; Wed, 16 Feb 2022 07:16:35 -0800 (PST)
Received: from a2klaptop.localdomain ([185.199.97.5])
 by smtp.gmail.com with ESMTPSA id bt2sm3082357lfb.93.2022.02.16.07.16.33
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 16 Feb 2022 07:16:33 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6dcb8634-8f3b-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=mnHvlszou+sUt2CMWmsEloA/G0o6HD6lA07Jc0hGpOo=;
        b=CnqsZL9viXZMQHQvHmttTnJ0eEVzg9JrOJABXFnJpgoEwIzWtPkIzsA/Khf1vCiYWv
         lROUz5o/Dk2xoX6bpRS47rkPRDkeScth8pCG1ND3JjccdDZ0TKKtux2CYpWpYwewMtK7
         z2OJnLULlUSOZ6VsCf66MzxuSrbxPy6OEA7V58iL05jmDW8IbayQRuS+8f6883ImsQSg
         FSnZqZN5mq1z5qY4tt5HxePYhHWlSPUPHVnGBK1QDnBBfa5sv3v3jEQS9P6oa/0FiMSx
         yacoEAQOOwQq9l0YmUElHzMYeSeZJFxPWFHXHiLglQ3FOEpIbpROc7In0gEv6jnVbzKj
         D1jw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=mnHvlszou+sUt2CMWmsEloA/G0o6HD6lA07Jc0hGpOo=;
        b=CwSnFCTSskQ+1e5uAc86f3jqecdq5oL5rT30ifN2e+TKphhqqhpPSapDeqqJ/Xi+Gd
         V3JXNr+t2EbICuo0cJp5WnCkiDzDW/TaKBZEVbDkt2DUJ8zmxAxJr9ROTVe1sYPUfYIx
         8TZNdV08iYtZx9SDtxm0h2pGtTjzh0EE3+XAyh5Ewh/dmWUeWH3Mdwr2aZaKEeghituJ
         dt6e0FpLQd0TzZpssPd9kZIHWNGpD9SMNGwbWovAszlLvcvcOxGKtCy7XeS72xjAqivk
         7YHLvzASlFz3vALjNLqHIEjAvw2sWSln12oDv8ugwtH32aPT1n4wyK2xRj4PulPe0wWJ
         kkAw==
X-Gm-Message-State: AOAM533J0MyWYximf68cCwxsmnGswUtRx0yLJ5fqJWdLCqyMFjUpLcNm
	uNjtJ5DBrmcc+oZUy5/LgX9uEE0qhcQ=
X-Google-Smtp-Source: ABdhPJxbY8NbS1ZgG14niedixXiySlg73DQhQT2TTHksvvrKaiNwPIMy+7I3IkDlaf2T6KXsC9hn8w==
X-Received: by 2002:a05:651c:1787:b0:244:3308:eb71 with SMTP id bn7-20020a05651c178700b002443308eb71mr2427606ljb.492.1645024594247;
        Wed, 16 Feb 2022 07:16:34 -0800 (PST)
From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: roger.pau@citrix.com,
	jbeulich@suse.com,
	julien@xen.org,
	sstabellini@kernel.org,
	oleksandr_tyshchenko@epam.com,
	volodymyr_babchuk@epam.com,
	artem_mygaiev@epam.com,
	bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: [PATCH 3/4] vpci: use pcidevs locking to protect MMIO handlers
Date: Wed, 16 Feb 2022 17:16:27 +0200
Message-Id: <20220216151628.1610777-4-andr2000@gmail.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220216151628.1610777-1-andr2000@gmail.com>
References: <20220216151628.1610777-1-andr2000@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

vPCI MMIO handlers are accessing pdevs without protecting this access
with pcidevs_{lock|unlock}. This is not a problem as of now as these
are only used by Dom0. But, towards vPCI is used also for guests, we need
to properly protect pdev and pdev->vpci from being removed while still
in use.

For that add new locking helpers: pcidevs_read_{un}lock and means to
check if the lock is held in read mode.

Note, that pcidevs_read_{un}lock doesn't acquire _pcidevs_lock recursive
lock because its users are not expected to modify pdev's contents
other than pdev->vpci which is protected by pdev->vpci->lock (where
appropriate). These new helpers are also suitable for simple pdev
list traversals such as for_each_pdev, pci_get_pdev_by_domain and others.

This patch adds ASSERTs in the code to check that the rwlock is taken
and in appropriate mode. Some of such checks require changes to the
initialization of local variables which may be accessed before the
ASSERT checks the locking. For example see init_bars and mask_write.

Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
---
 xen/arch/x86/hvm/vmsi.c       | 24 +++++++++++++--
 xen/drivers/passthrough/pci.c | 20 +++++++++++++
 xen/drivers/vpci/header.c     | 24 +++++++++++++--
 xen/drivers/vpci/msi.c        | 21 +++++++++----
 xen/drivers/vpci/msix.c       | 55 ++++++++++++++++++++++++++++++-----
 xen/drivers/vpci/vpci.c       | 22 ++++++++++++--
 xen/include/xen/pci.h         |  5 ++++
 xen/include/xen/vpci.h        |  2 +-
 8 files changed, 151 insertions(+), 22 deletions(-)

diff --git a/xen/arch/x86/hvm/vmsi.c b/xen/arch/x86/hvm/vmsi.c
index 13e2a190b439..5ef8f37ab0fc 100644
--- a/xen/arch/x86/hvm/vmsi.c
+++ b/xen/arch/x86/hvm/vmsi.c
@@ -889,10 +889,16 @@ void vpci_msix_arch_init_entry(struct vpci_msix_entry *entry)
     entry->arch.pirq = INVALID_PIRQ;
 }
 
-int vpci_msix_arch_print(const struct vpci_msix *msix)
+int vpci_msix_arch_print(const struct domain *d, const struct vpci_msix *msix)
 {
     unsigned int i;
 
+    /*
+     * FIXME: this is not immediately correct, as the lock can be grabbed
+     * by a different CPU. But this is better then nothing.
+     */
+    ASSERT(pcidevs_read_locked());
+
     for ( i = 0; i < msix->max_entries; i++ )
     {
         const struct vpci_msix_entry *entry = &msix->entries[i];
@@ -909,11 +915,23 @@ int vpci_msix_arch_print(const struct vpci_msix *msix)
         if ( i && !(i % 64) )
         {
             struct pci_dev *pdev = msix->pdev;
+            pci_sbdf_t sbdf = pdev->sbdf;
 
             spin_unlock(&msix->pdev->vpci->lock);
+            pcidevs_read_unlock();
+
+            /* NB: we still hold rcu_read_lock(&domlist_read_lock); here. */
             process_pending_softirqs();
-            /* NB: we assume that pdev cannot go away for an alive domain. */
-            if ( !pdev->vpci || !spin_trylock(&pdev->vpci->lock) )
+
+            if ( !pcidevs_read_trylock() )
+                return -EBUSY;
+            pdev = pci_get_pdev_by_domain(d, sbdf.seg, sbdf.bus, sbdf.devfn);
+            /*
+             * FIXME: we may find a re-allocated pdev's copy here.
+             * Even occupying the same address as before. Do our best.
+             */
+            if ( !pdev || (pdev != msix->pdev) || !pdev->vpci ||
+                 !spin_trylock(&pdev->vpci->lock) )
                 return -EBUSY;
             if ( pdev->vpci->msix != msix )
             {
diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
index 2a0d3d37a69f..74fe1c94cf71 100644
--- a/xen/drivers/passthrough/pci.c
+++ b/xen/drivers/passthrough/pci.c
@@ -70,6 +70,26 @@ bool_t pcidevs_locked(void)
     return !!spin_is_locked(&_pcidevs_lock) || pcidevs_write_locked();
 }
 
+void pcidevs_read_lock(void)
+{
+    read_lock(&_pcidevs_rwlock);
+}
+
+int pcidevs_read_trylock(void)
+{
+    return read_trylock(&_pcidevs_rwlock);
+}
+
+void pcidevs_read_unlock(void)
+{
+    read_unlock(&_pcidevs_rwlock);
+}
+
+bool pcidevs_read_locked(void)
+{
+    return !!rw_is_locked(&_pcidevs_rwlock);
+}
+
 void pcidevs_write_lock(void)
 {
     write_lock(&_pcidevs_rwlock);
diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c
index 40ff79c33f8f..75e972740106 100644
--- a/xen/drivers/vpci/header.c
+++ b/xen/drivers/vpci/header.c
@@ -142,16 +142,19 @@ bool vpci_process_pending(struct vcpu *v)
         if ( rc == -ERESTART )
             return true;
 
+        pcidevs_read_lock();
         spin_lock(&v->vpci.pdev->vpci->lock);
         /* Disable memory decoding unconditionally on failure. */
         modify_decoding(v->vpci.pdev,
                         rc ? v->vpci.cmd & ~PCI_COMMAND_MEMORY : v->vpci.cmd,
                         !rc && v->vpci.rom_only);
         spin_unlock(&v->vpci.pdev->vpci->lock);
+        pcidevs_read_unlock();
 
         rangeset_destroy(v->vpci.mem);
         v->vpci.mem = NULL;
         if ( rc )
+        {
             /*
              * FIXME: in case of failure remove the device from the domain.
              * Note that there might still be leftover mappings. While this is
@@ -159,7 +162,10 @@ bool vpci_process_pending(struct vcpu *v)
              * killed in order to avoid leaking stale p2m mappings on
              * failure.
              */
+            pcidevs_write_lock();
             vpci_remove_device(v->vpci.pdev);
+            pcidevs_write_unlock();
+        }
     }
 
     return false;
@@ -172,7 +178,16 @@ static int __init apply_map(struct domain *d, const struct pci_dev *pdev,
     int rc;
 
     while ( (rc = rangeset_consume_ranges(mem, map_range, &data)) == -ERESTART )
+    {
+        /*
+         * It's safe to drop and re-acquire the lock in this context
+         * without risking pdev disappearing because devices cannot be
+         * removed until the initial domain has been started.
+         */
+        pcidevs_write_unlock();
         process_pending_softirqs();
+        pcidevs_write_lock();
+    }
     rangeset_destroy(mem);
     if ( !rc )
         modify_decoding(pdev, cmd, false);
@@ -450,10 +465,15 @@ static int init_bars(struct pci_dev *pdev)
     uint16_t cmd;
     uint64_t addr, size;
     unsigned int i, num_bars, rom_reg;
-    struct vpci_header *header = &pdev->vpci->header;
-    struct vpci_bar *bars = header->bars;
+    struct vpci_header *header;
+    struct vpci_bar *bars;
     int rc;
 
+    ASSERT(pcidevs_write_locked());
+
+    header = &pdev->vpci->header;
+    bars = header->bars;
+
     switch ( pci_conf_read8(pdev->sbdf, PCI_HEADER_TYPE) & 0x7f )
     {
     case PCI_HEADER_TYPE_NORMAL:
diff --git a/xen/drivers/vpci/msi.c b/xen/drivers/vpci/msi.c
index 5757a7aed20f..4d19b036c98f 100644
--- a/xen/drivers/vpci/msi.c
+++ b/xen/drivers/vpci/msi.c
@@ -184,12 +184,17 @@ static void mask_write(const struct pci_dev *pdev, unsigned int reg,
 
 static int init_msi(struct pci_dev *pdev)
 {
-    uint8_t slot = PCI_SLOT(pdev->devfn), func = PCI_FUNC(pdev->devfn);
-    unsigned int pos = pci_find_cap_offset(pdev->seg, pdev->bus, slot, func,
-                                           PCI_CAP_ID_MSI);
+    uint8_t slot, func;
+    unsigned int pos;
     uint16_t control;
     int ret;
 
+    ASSERT(pcidevs_write_locked());
+
+    slot = PCI_SLOT(pdev->devfn);
+    func = PCI_FUNC(pdev->devfn);
+    pos = pci_find_cap_offset(pdev->seg, pdev->bus, slot, func, PCI_CAP_ID_MSI);
+
     if ( !pos )
         return 0;
 
@@ -277,6 +282,9 @@ void vpci_dump_msi(void)
 
         printk("vPCI MSI/MSI-X d%d\n", d->domain_id);
 
+        if ( !pcidevs_read_trylock() )
+            continue;
+
         for_each_pdev ( d, pdev )
         {
             const struct vpci_msi *msi;
@@ -310,7 +318,7 @@ void vpci_dump_msi(void)
                 printk("  entries: %u maskall: %d enabled: %d\n",
                        msix->max_entries, msix->masked, msix->enabled);
 
-                rc = vpci_msix_arch_print(msix);
+                rc = vpci_msix_arch_print(d, msix);
                 if ( rc )
                 {
                     /*
@@ -318,12 +326,13 @@ void vpci_dump_msi(void)
                      * holding the lock.
                      */
                     printk("unable to print all MSI-X entries: %d\n", rc);
-                    process_pending_softirqs();
-                    continue;
+                    goto pdev_done;
                 }
             }
 
             spin_unlock(&pdev->vpci->lock);
+ pdev_done:
+            pcidevs_read_unlock();
             process_pending_softirqs();
         }
     }
diff --git a/xen/drivers/vpci/msix.c b/xen/drivers/vpci/msix.c
index 846f1b8d7038..f0adfb6c1dbc 100644
--- a/xen/drivers/vpci/msix.c
+++ b/xen/drivers/vpci/msix.c
@@ -144,9 +144,13 @@ static struct vpci_msix *msix_find(const struct domain *d, unsigned long addr)
 
     list_for_each_entry ( msix, &d->arch.hvm.msix_tables, next )
     {
-        const struct vpci_bar *bars = msix->pdev->vpci->header.bars;
+        const struct vpci_bar *bars;
         unsigned int i;
 
+        if ( !msix->pdev->vpci )
+            continue;
+
+        bars = msix->pdev->vpci->header.bars;
         for ( i = 0; i < ARRAY_SIZE(msix->tables); i++ )
             if ( bars[msix->tables[i] & PCI_MSIX_BIRMASK].enabled &&
                  VMSIX_ADDR_IN_RANGE(addr, msix->pdev->vpci, i) )
@@ -158,7 +162,13 @@ static struct vpci_msix *msix_find(const struct domain *d, unsigned long addr)
 
 static int msix_accept(struct vcpu *v, unsigned long addr)
 {
-    return !!msix_find(v->domain, addr);
+    int rc;
+
+    pcidevs_read_lock();
+    rc = !!msix_find(v->domain, addr);
+    pcidevs_read_unlock();
+
+    return rc;
 }
 
 static bool access_allowed(const struct pci_dev *pdev, unsigned long addr,
@@ -186,17 +196,26 @@ static int msix_read(struct vcpu *v, unsigned long addr, unsigned int len,
                      unsigned long *data)
 {
     const struct domain *d = v->domain;
-    struct vpci_msix *msix = msix_find(d, addr);
+    struct vpci_msix *msix;
     const struct vpci_msix_entry *entry;
     unsigned int offset;
 
     *data = ~0ul;
 
+    pcidevs_read_lock();
+
+    msix = msix_find(d, addr);
     if ( !msix )
+    {
+        pcidevs_read_unlock();
         return X86EMUL_RETRY;
+    }
 
     if ( !access_allowed(msix->pdev, addr, len) )
+    {
+        pcidevs_read_unlock();
         return X86EMUL_OKAY;
+    }
 
     if ( VMSIX_ADDR_IN_RANGE(addr, msix->pdev->vpci, VPCI_MSIX_PBA) )
     {
@@ -255,6 +274,7 @@ static int msix_read(struct vcpu *v, unsigned long addr, unsigned int len,
         break;
     }
     spin_unlock(&msix->pdev->vpci->lock);
+    pcidevs_read_unlock();
 
     return X86EMUL_OKAY;
 }
@@ -263,15 +283,24 @@ static int msix_write(struct vcpu *v, unsigned long addr, unsigned int len,
                       unsigned long data)
 {
     const struct domain *d = v->domain;
-    struct vpci_msix *msix = msix_find(d, addr);
+    struct vpci_msix *msix;
     struct vpci_msix_entry *entry;
     unsigned int offset;
 
+    pcidevs_read_lock();
+
+    msix = msix_find(d, addr);
     if ( !msix )
+    {
+        pcidevs_read_unlock();
         return X86EMUL_RETRY;
+    }
 
     if ( !access_allowed(msix->pdev, addr, len) )
+    {
+        pcidevs_read_unlock();
         return X86EMUL_OKAY;
+    }
 
     if ( VMSIX_ADDR_IN_RANGE(addr, msix->pdev->vpci, VPCI_MSIX_PBA) )
     {
@@ -294,6 +323,7 @@ static int msix_write(struct vcpu *v, unsigned long addr, unsigned int len,
             }
         }
 
+        pcidevs_read_unlock();
         return X86EMUL_OKAY;
     }
 
@@ -371,6 +401,7 @@ static int msix_write(struct vcpu *v, unsigned long addr, unsigned int len,
         break;
     }
     spin_unlock(&msix->pdev->vpci->lock);
+    pcidevs_read_unlock();
 
     return X86EMUL_OKAY;
 }
@@ -383,9 +414,13 @@ static const struct hvm_mmio_ops vpci_msix_table_ops = {
 
 int vpci_make_msix_hole(const struct pci_dev *pdev)
 {
-    struct domain *d = pdev->domain;
+    struct domain *d;
     unsigned int i;
 
+    ASSERT(pcidevs_read_locked());
+
+    d = pdev->domain;
+
     if ( !pdev->vpci->msix )
         return 0;
 
@@ -430,13 +465,19 @@ int vpci_make_msix_hole(const struct pci_dev *pdev)
 
 static int init_msix(struct pci_dev *pdev)
 {
-    struct domain *d = pdev->domain;
-    uint8_t slot = PCI_SLOT(pdev->devfn), func = PCI_FUNC(pdev->devfn);
+    struct domain *d;
+    uint8_t slot, func;
     unsigned int msix_offset, i, max_entries;
     uint16_t control;
     struct vpci_msix *msix;
     int rc;
 
+    ASSERT(pcidevs_write_locked());
+
+    d = pdev->domain;
+    slot = PCI_SLOT(pdev->devfn);
+    func = PCI_FUNC(pdev->devfn);
+
     msix_offset = pci_find_cap_offset(pdev->seg, pdev->bus, slot, func,
                                       PCI_CAP_ID_MSIX);
     if ( !msix_offset )
diff --git a/xen/drivers/vpci/vpci.c b/xen/drivers/vpci/vpci.c
index f564572a51cb..119219220a70 100644
--- a/xen/drivers/vpci/vpci.c
+++ b/xen/drivers/vpci/vpci.c
@@ -37,7 +37,9 @@ extern vpci_register_init_t *const __end_vpci_array[];
 
 void vpci_remove_device(struct pci_dev *pdev)
 {
-    if ( !has_vpci(pdev->domain) )
+    ASSERT(pcidevs_write_locked());
+
+    if ( !has_vpci(pdev->domain) || !pdev->vpci )
         return;
 
     spin_lock(&pdev->vpci->lock);
@@ -62,6 +64,8 @@ int vpci_add_handlers(struct pci_dev *pdev)
     unsigned int i;
     int rc = 0;
 
+    ASSERT(pcidevs_write_locked());
+
     if ( !has_vpci(pdev->domain) )
         return 0;
 
@@ -136,6 +140,8 @@ int vpci_add_register(struct vpci *vpci, vpci_read_t *read_handler,
     struct list_head *prev;
     struct vpci_register *r;
 
+    ASSERT(pcidevs_write_locked());
+
     /* Some sanity checks. */
     if ( (size != 1 && size != 2 && size != 4) ||
          offset >= PCI_CFG_SPACE_EXP_SIZE || (offset & (size - 1)) ||
@@ -183,6 +189,8 @@ int vpci_remove_register(struct vpci *vpci, unsigned int offset,
     const struct vpci_register r = { .offset = offset, .size = size };
     struct vpci_register *rm;
 
+    ASSERT(pcidevs_write_locked());
+
     spin_lock(&vpci->lock);
     list_for_each_entry ( rm, &vpci->handlers, node )
     {
@@ -330,10 +338,14 @@ uint32_t vpci_read(pci_sbdf_t sbdf, unsigned int reg, unsigned int size)
         return data;
     }
 
+    pcidevs_read_lock();
     /* Find the PCI dev matching the address. */
     pdev = pci_get_pdev_by_domain(d, sbdf.seg, sbdf.bus, sbdf.devfn);
-    if ( !pdev )
+    if ( !pdev || (pdev && !pdev->vpci) )
+    {
+        pcidevs_read_unlock();
         return vpci_read_hw(sbdf, reg, size);
+    }
 
     spin_lock(&pdev->vpci->lock);
 
@@ -379,6 +391,7 @@ uint32_t vpci_read(pci_sbdf_t sbdf, unsigned int reg, unsigned int size)
         ASSERT(data_offset < size);
     }
     spin_unlock(&pdev->vpci->lock);
+    pcidevs_read_unlock();
 
     if ( data_offset < size )
     {
@@ -441,9 +454,11 @@ void vpci_write(pci_sbdf_t sbdf, unsigned int reg, unsigned int size,
      * Find the PCI dev matching the address.
      * Passthrough everything that's not trapped.
      */
+    pcidevs_read_lock();
     pdev = pci_get_pdev_by_domain(d, sbdf.seg, sbdf.bus, sbdf.devfn);
-    if ( !pdev )
+    if ( !pdev || (pdev && !pdev->vpci) )
     {
+        pcidevs_read_unlock();
         vpci_write_hw(sbdf, reg, size, data);
         return;
     }
@@ -484,6 +499,7 @@ void vpci_write(pci_sbdf_t sbdf, unsigned int reg, unsigned int size,
         ASSERT(data_offset < size);
     }
     spin_unlock(&pdev->vpci->lock);
+    pcidevs_read_unlock();
 
     if ( data_offset < size )
         /* Tailing gap, write the remaining. */
diff --git a/xen/include/xen/pci.h b/xen/include/xen/pci.h
index e814d9542bfc..53cea3167b1f 100644
--- a/xen/include/xen/pci.h
+++ b/xen/include/xen/pci.h
@@ -152,6 +152,11 @@ void pcidevs_lock(void);
 void pcidevs_unlock(void);
 bool_t __must_check pcidevs_locked(void);
 
+void pcidevs_read_lock(void);
+int pcidevs_read_trylock(void);
+void pcidevs_read_unlock(void);
+bool __must_check pcidevs_read_locked(void);
+
 void pcidevs_write_lock(void);
 void pcidevs_write_unlock(void);
 bool __must_check pcidevs_write_locked(void);
diff --git a/xen/include/xen/vpci.h b/xen/include/xen/vpci.h
index e8ac1eb39513..c5f0054026a4 100644
--- a/xen/include/xen/vpci.h
+++ b/xen/include/xen/vpci.h
@@ -173,7 +173,7 @@ int __must_check vpci_msix_arch_enable_entry(struct vpci_msix_entry *entry,
 int __must_check vpci_msix_arch_disable_entry(struct vpci_msix_entry *entry,
                                               const struct pci_dev *pdev);
 void vpci_msix_arch_init_entry(struct vpci_msix_entry *entry);
-int vpci_msix_arch_print(const struct vpci_msix *msix);
+int vpci_msix_arch_print(const struct domain *d, const struct vpci_msix *msix);
 
 /*
  * Helper functions to fetch MSIX related data. They are used by both the
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Feb 16 15:16:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 15:16:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274221.469649 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKM2o-0001bL-5X; Wed, 16 Feb 2022 15:16:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274221.469649; Wed, 16 Feb 2022 15:16:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKM2n-0001aH-UZ; Wed, 16 Feb 2022 15:16:37 +0000
Received: by outflank-mailman (input) for mailman id 274221;
 Wed, 16 Feb 2022 15:16:36 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=miT7=S7=gmail.com=andr2000@srs-se1.protection.inumbo.net>)
 id 1nKM2m-0000ia-P5
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 15:16:36 +0000
Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com
 [2a00:1450:4864:20::22c])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6e692108-8f3b-11ec-8eb8-a37418f5ba1a;
 Wed, 16 Feb 2022 16:16:36 +0100 (CET)
Received: by mail-lj1-x22c.google.com with SMTP id bx31so3882353ljb.0
 for <xen-devel@lists.xenproject.org>; Wed, 16 Feb 2022 07:16:36 -0800 (PST)
Received: from a2klaptop.localdomain ([185.199.97.5])
 by smtp.gmail.com with ESMTPSA id bt2sm3082357lfb.93.2022.02.16.07.16.34
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 16 Feb 2022 07:16:35 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6e692108-8f3b-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=jzNPBmlgY6KQmcQw14tBqJfV5dL9s7shqTcsZA+5AgQ=;
        b=TsV6bEvDXLlZtbCASc/xe9GCKFucEulegH3lKRkFAgyMzTU4SyU+Fun96JhxlD+AOY
         nikahjJOLIneZdfNd8sMpA43APGtReE811C7xELfMAr21E2cGwhS3s38g+oTvwV8/0ik
         3kZJZaUdUyVW2ibfJWyvcCqYQq4gahf2nHuzcbeDQ7SZR483UZ1O/WaBghyrflm5MM6s
         6Ucguyj9A7eHx5yL2PtyjXdLXP3NG7az0pJ/kT3Eaq5XoeWSI77AhtkaOCX0EQLIKMKZ
         P2RhCmWNDcmKSzSWaDaVL14QYZbQEirRAWqpANf3Dq+FxTYKNZI2w8g0RlGw/WJmMIJ8
         1l7w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=jzNPBmlgY6KQmcQw14tBqJfV5dL9s7shqTcsZA+5AgQ=;
        b=2x1EOO7F5s3UgZ1VuRsiWKNFOqBcANlOMnElB7PMMpsZagfwp7fKJeJ9R0hjvoINGM
         hq6kAjKqcBFBTT/zOiIKxx/k+jzQ75hn69MhAkngkg7M5ixyIsT5MbUNYNQ7/T+vyY+d
         gQQGWFoxigczXdK4wgGj/1HtwyIOKg4HaAAzYf7HccM+rJ1Lo7t2Qc6D46IZEdr/nckO
         PkLc8xhmIm43x6TtVoS0/pO9dDlJTovrvDxhNuVmAmkhO8HURrO4eFDP56tGtNnErlGB
         ylDj+gc0U+xw1h/7U8J0T+j6UOtDe76oFkElkqltQj9RZU5bO38l65tPvv9FFk7h0WTq
         a6hA==
X-Gm-Message-State: AOAM533JD3NxC+u17dJzP7yKQBT32vXr+AT7UCOuhnAnVQnQ+Eg47xk6
	TmAb2DH4GVboGMpzGFp0TXBffkKsUfA=
X-Google-Smtp-Source: ABdhPJxnt0SZcGjSHJgWxCZHuf9astKgh20exBxdg26yhlRFgk9MOZE9juT+b1OUcHBpl8MMQnRcKQ==
X-Received: by 2002:a05:651c:1791:b0:243:94bd:d94c with SMTP id bn17-20020a05651c179100b0024394bdd94cmr2382485ljb.468.1645024595427;
        Wed, 16 Feb 2022 07:16:35 -0800 (PST)
From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: roger.pau@citrix.com,
	jbeulich@suse.com,
	julien@xen.org,
	sstabellini@kernel.org,
	oleksandr_tyshchenko@epam.com,
	volodymyr_babchuk@epam.com,
	artem_mygaiev@epam.com,
	bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: [PATCH 4/4] vpci: resolve possible clash while removing BAR overlaps
Date: Wed, 16 Feb 2022 17:16:28 +0200
Message-Id: <20220216151628.1610777-5-andr2000@gmail.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220216151628.1610777-1-andr2000@gmail.com>
References: <20220216151628.1610777-1-andr2000@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

modify_bars checks if the mapping of the BAR memory has already been
done when mapping other device's BARs or, while unmapping, are still
in use by other devices.

With the existing locking scheme it is possible that there are other
devices trying to do the same in parallel with us, but on other CPUs
as we only hold a read lock without acquiring _pcidevs_lock recursive
lock.

To prevent that upgrade the read lock to normal pcidevs_lock during
BAR overlapping check.

Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
---
 xen/drivers/vpci/header.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c
index 75e972740106..c80a8bb5e3e0 100644
--- a/xen/drivers/vpci/header.c
+++ b/xen/drivers/vpci/header.c
@@ -281,7 +281,11 @@ static int modify_bars(const struct pci_dev *pdev, uint16_t cmd, bool rom_only)
     /*
      * Check for overlaps with other BARs. Note that only BARs that are
      * currently mapped (enabled) are checked for overlaps.
+     * We are holding pcidevs_read_lock here, but we need to access
+     * different devices at a time. So, upgrade our current read lock to normal
+     * pcidevs_lock.
      */
+    pcidevs_lock();
     for_each_pdev ( pdev->domain, tmp )
     {
         if ( tmp == pdev )
@@ -321,10 +325,12 @@ static int modify_bars(const struct pci_dev *pdev, uint16_t cmd, bool rom_only)
                 printk(XENLOG_G_WARNING "Failed to remove [%lx, %lx]: %d\n",
                        start, end, rc);
                 rangeset_destroy(mem);
+                pcidevs_unlock();
                 return rc;
             }
         }
     }
+    pcidevs_unlock();
 
     ASSERT(dev);
 
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Feb 16 15:43:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 15:43:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274259.469667 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKMSs-0006NE-QO; Wed, 16 Feb 2022 15:43:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274259.469667; Wed, 16 Feb 2022 15:43:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKMSs-0006N7-N9; Wed, 16 Feb 2022 15:43:34 +0000
Received: by outflank-mailman (input) for mailman id 274259;
 Wed, 16 Feb 2022 15:43:33 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Gpsw=S7=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nKMSr-0006N1-5Z
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 15:43:33 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 314d068d-8f3f-11ec-8eb8-a37418f5ba1a;
 Wed, 16 Feb 2022 16:43:31 +0100 (CET)
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2051.outbound.protection.outlook.com [104.47.8.51]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-29-ubEfInxVMRmgZHIgM0aqdw-1; Wed, 16 Feb 2022 16:43:30 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by PR3PR04MB7386.eurprd04.prod.outlook.com (2603:10a6:102:85::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.19; Wed, 16 Feb
 2022 15:43:29 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4995.016; Wed, 16 Feb 2022
 15:43:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 314d068d-8f3f-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645026211;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=i5ywUzlXsfUlbcScrFPkd7jP1KPxdP8PhPk+LToxxHo=;
	b=Ugv2hilZ1gmXNxzuVx9Vm/RaE1+u9YgzSkNg6zfWQ3yNpX9fDwiZnkxvXW2+/Zr2jSMghg
	RqvNtkejC2zaJiSZ9aFiWiwD8sRo4P0PbItOwa14qTnNssu3w1Ck6tHHpwPgi4wOKGIYmT
	Uj4fVFnLe8YbgqBNTVQ2G7cg5OKyEt8=
X-MC-Unique: ubEfInxVMRmgZHIgM0aqdw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Y5ADSu5PxkigULrPPen4VSVUPxGX0ToPyp9qB2GHMCmCxElNN50celRLl6yFgQM5gujJcl9N7XScejX2kYWv1TA4W2RmCJ4yt4lZY7+4ySiOaANrqakCdLH3awT8196EgM5+weoHHvBL9IwTUGTEEO5yH7d6WZ5wWNfF6RTBMjf7avfQ29yYVSZKaQEo/lAoV5MFgfpcrl6nG6KKje1rOcnL3OudbGaKnc5c+KOI1i+6QRxqNxeED4eodof5y3ZuavdtE1qR3PR/diYCP/UswMyD26hr5geF+pBJrf94jMwL8zDibIe3OMAEFr6HoiMUCIXZ2y455aV2jp0+IVLsiA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=i5ywUzlXsfUlbcScrFPkd7jP1KPxdP8PhPk+LToxxHo=;
 b=OCzTv+B/6FElx1yf9voLK0h3eexm0Y5fNELkuq1ONO5hGbTzsqAOPe0NuQkm0tGSy5fUuuCnzMe+ulzFjaVYLkWr0cqLk/oyq+Ra5ooG06ErRVDRu8aaG5FWqOslAIlxbekWhW9qn9h4rZpqOJXnPFlf4WG/xlGbv/l7KK6Y2Snn3kNkcs698+0l7TBpm16kfnwWUn3rTyDjfwr3xZ+5DekgTSkUKBPp7o1jOOwK2rl/8dgdo7l549au5Wa5abkDhXsY1OwaTb/fZGSgb0t1TiStex2V3Fve22QGsC8YMNEvp9v9M1M/qG8EOUG+SbnRNKpDukHOJCu8XtP6eWOF/g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <979fbc26-925c-f58f-9c1a-9ccd72275c9b@suse.com>
Date: Wed, 16 Feb 2022 16:43:27 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v2 1/5] x86/cpuid: add CPUID flag for Extended Destination
 ID support
Content-Language: en-US
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: dwmw2@infradead.org, Andrew Cooper <andrew.cooper3@citrix.com>,
 Wei Liu <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20220216103026.11533-1-roger.pau@citrix.com>
 <20220216103026.11533-2-roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220216103026.11533-2-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR3P281CA0003.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:1d::22) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c3b548e3-5909-4b95-29d7-08d9f16313eb
X-MS-TrafficTypeDiagnostic: PR3PR04MB7386:EE_
X-Microsoft-Antispam-PRVS:
	<PR3PR04MB73869351E2F14CC29C47266EB3359@PR3PR04MB7386.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	K0MmkbfGDnJMIMK+bWHCGZINXeLo6eVhY/djhEdfdZ8mp5gmtAa+5mZ5jVRaODbSnBIweRchshX61N5hUtsmT1V7udfFNHhCn7p8dcoCBFZHun7KeQwcpLMgA7MBiMxfFhky/Q2nV8H2EkmjIwa56eYQFDznUi7L2niyGjfgboIUNiZAPC8zhE5RLk7c522AL1ZjM4jk62/fobWcPe2Oky7di9LHEOPkaiQ7NmGm8RaPiWkbh9gvQcjc2DLynqbbHPss8Sr1HCrn/EzqbDPrGUnCPjxm1PYZdECbEsfVV3QVrIkjjIHz0zZXMgllQs5b4BZuOd0a7NRxNp7Tig5ejkIoOgCKb5Vo/8DOf55MoF/ge5611S72F17keddnM6RDin3yt/8rLOwv0G/8i/56jFY08z1KWQJnVAISBJw9ZkfGQgUUBMcqbIXc/JbatrX8ApX/sQwE94UEgzTprvmIfZ723xoKzvw+MHAcDCDSd4fakWDeFXEEo0jNz73uGZtbRFgRVtxQEVXVzRnJ6DLuFDYQEhPujU3nEtRJ99pR0qvRdUl+aOr1kV096uGhyYkBBbS5pMag9ZdC5St1It8JC91PBH72GJiEB8hhi9sKJ5p/By5ghJSCJCxU8Rmt7KZQanuy0f0lpdSPuFBmMuQD2zA4rjiUwIArpJOxkLPbtnfGhHNTkFiXQAPsJVg7BqpGF8syZ8LxQXnE6072pLHhVIe3rCU4Bt8UJl86hIgpXh6DYcI6w8SwE7F1etBuRtcx
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(186003)(316002)(38100700002)(86362001)(66946007)(6486002)(508600001)(36756003)(54906003)(6916009)(31686004)(26005)(4326008)(8676002)(8936002)(6506007)(66476007)(2906002)(66556008)(6512007)(31696002)(4744005)(5660300002)(2616005)(53546011)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UmhzV0xjMUJhQW9SSU8zR0NDazViUmNYbFdOUlNEVHNyN1hacDA1Mzd2ZFY2?=
 =?utf-8?B?Y2NwOVhEeUpKblVqN2xFZDNORU5iTzdaU2E5TXZLeVltVHplWFA4aGhUcUNE?=
 =?utf-8?B?dExrclhya3IwWnFuNXF0QjV2dmVjK1hRbGdZdDJuT3ByY2xFMzA3c1o5ZFpS?=
 =?utf-8?B?V3JNM1hLS004eVduay82aUdlL1UrODUvWGRTeVpVRHNlclY3ZGtOTFZpdkJ0?=
 =?utf-8?B?M1JRU0Z1czI2VFBoQ2pDTUgvcEY1UGNYOXJwZ1diTUdaakd3QXZqSzFmc0V5?=
 =?utf-8?B?VkVxSWRoaDZNYVFIcXM2L3gxMnU4N3VUdEpkbkFMMGtUTUhaM3B3MHAxTjJE?=
 =?utf-8?B?T1N1QmhZZDJqRjd5YVpDa3dJVHVZdllpUDM5RHlNMWVDTG1oTldyYURUckIr?=
 =?utf-8?B?UFNtaW00cW5kZCtpcDZjU1pjdlZ6L1BpclR4Z0JUeGs5ZVZ2TGxlb2FYS3FJ?=
 =?utf-8?B?VXBpUkl5YjRwb2Z5VnRQYmFoLzU0NUNtSVdPYjg4QzBlRlFHL3pwYjJaamhL?=
 =?utf-8?B?WWpzR2ZGblY3LzZWZ3d2OUs5U1IzUURhaXR1Y2xoWTl0UVdjSzlXM0lMd1Vj?=
 =?utf-8?B?VzM0anluL3lOVEVmUUFPTzZXS0twVWNjZTJVVFZiaG9kM29PQ3I2eHFJTGY3?=
 =?utf-8?B?SVErQWVkRC8vTDAzbFhxdm5QQjFFblBPUm5udkRxQzdSUFdKdkpZMlgxanhl?=
 =?utf-8?B?eUkvRXZuYnVjbEtZSHRNeURjbW5neC9JcFNWaEZIRFlyRysvMkVwR3J0c1FL?=
 =?utf-8?B?aytuSFdCeEhXM1NhbHpZWDQ4elcrVFlqTkhzbkFoR2MxVE5HM0IzUmx2dW01?=
 =?utf-8?B?R1ZTSlducCtzQ3JRQzBjcmVOUnBDd0lLMkk5R3FyKytpenhxV2V2RGw5SFpN?=
 =?utf-8?B?QnRrc2xFRHVOR1RGcFFuY3dJWkh1REhZcVNHSUt6c1N2bDVtU2M3UUo3aGRi?=
 =?utf-8?B?b3lFS09UTUhrNFlURzBwOWp1eXdwKzRNZ25aL1QwUTZVSFo4aDNlbHhNOWZI?=
 =?utf-8?B?elB4UmhraFNqM1NOMHRvY1l1dW1kYnNRRWNwZVc3d1krZHVRTFdJdzRkSEZR?=
 =?utf-8?B?RExrekdBeFZCd0wyeXY0RUROdTJkNjE0QkpnUDhlSHp6R0pEVUdrbEozVXFn?=
 =?utf-8?B?N0VHOVZsV29pcHVJT0IxWFVxcFBNYjU4OU15alJ2L25FdDRVSG5xVTRuRWVs?=
 =?utf-8?B?Y1pHNndCK0R1OFlPbDlKZGJEbzkxZUVZNnZ1bWJFcWpGcFlwYU1teU9FN2xP?=
 =?utf-8?B?QVVyTkpWdUtNRmRaVjVuM2pVR294MVZkSFhPdzJlN3ROMzZneUR5Z2ZPMkVG?=
 =?utf-8?B?dVFKVlBjTmQwVUJIUGl3Yyt2cDlJckppRUpEUWdDVldGbzNlbld3M2tBOTMz?=
 =?utf-8?B?WWE4TVhjeEhRMzROSVgyQWlta0JKZVFYVXljRlVQcXVDQXRoSFZhYVV2eENM?=
 =?utf-8?B?ZGNKcTBIYVd6NGllSENiWFN0S0NTOXB3UUYxRVBKUDRranA3enpycVd2MTU5?=
 =?utf-8?B?TGdXeHBnMi8vMnUvS3A0M1ZFQ1EveG9Cd0VRa0pjR2svL2c2NW9lUTR5NTgr?=
 =?utf-8?B?bFhaNDVydFNBSmU2b3QwZWEybitZSnhQVmpXSElRN1I3eExIZGRxK2JNQWhY?=
 =?utf-8?B?bmF6elNVTEJFcWdJVkJGUHBpa1cySFFERlByQ2x6ZFc0YVQyTzZHcFdkdElI?=
 =?utf-8?B?NDdrMGs0M3BrMG5GcldYMWVicUZnaEttU1VPM1YyOTQ3Uk05bXFxL0xGcHh1?=
 =?utf-8?B?T2RWRVV4MVdpcS9hVHVwcTh2a1ZySDRxNFJpbThtYmxmTDQvWlRXYU45ZHkv?=
 =?utf-8?B?d2JWZDhnS1h1WGVnTzRJYjVoQUtZd3Q4dFlMVlhPOHo1TjVQRXpSVHB0TStL?=
 =?utf-8?B?WGw3MVMrNlowWWtjOWhtZlg3d0VFcnFKRDRVSTRGK3M3SFBVeVNoVGRjaVor?=
 =?utf-8?B?dUFQeFV5S1lMOHp1VU80ZUd3bzMxUFF6dXJiRXZtN09UeEt0SXpJOTcrQXFa?=
 =?utf-8?B?QjAvTlRJT0hxM3duMkFTM2pRQUlDNXRtMENsWVkwSHc5dWt2dlkxaG5HOTVW?=
 =?utf-8?B?aEpzTDFLMXlyelhXOWtjNk9CdGhBUGY4Ym9VeVlYOWcybXJGNHN3SVJqVXJC?=
 =?utf-8?B?eml3V1MrRzc4Q0JTMXM0YlJpQjdYenQyR1ZQY253M3F5NmZXVDJqYjJKRGw4?=
 =?utf-8?Q?MM6wcE+B/SN71DkFXbuYosk=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c3b548e3-5909-4b95-29d7-08d9f16313eb
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2022 15:43:28.9433
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Si1WwI1l/EV4WODW6tEmrJ5VWQc14VZze2K8LWqMctefPLEwyR26G/TpveJRJK4J7bP7wlozTPzCVbsUMo7bZw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7386

On 16.02.2022 11:30, Roger Pau Monne wrote:
> --- a/xen/include/public/arch-x86/cpuid.h
> +++ b/xen/include/public/arch-x86/cpuid.h
> @@ -102,6 +102,12 @@
>  #define XEN_HVM_CPUID_IOMMU_MAPPINGS   (1u << 2)
>  #define XEN_HVM_CPUID_VCPU_ID_PRESENT  (1u << 3) /* vcpu id is present in EBX */
>  #define XEN_HVM_CPUID_DOMID_PRESENT    (1u << 4) /* domid is present in ECX */
> +/*
> + * Bits 55:49 from the IO-APIC RTE and bits 11:5 from the MSI address can be
> + * used to store high bits for the Destination ID. This expands the Destination
> + * ID field from 8 to 15 bits, allowing to target APIC IDs up 32768.
> + */
> +#define XEN_HVM_CPUID_EXT_DEST_ID      (1u << 5)

Would the comment perhaps better include "in the absence of (guest
visible) interrupt remapping", since otherwise the layout / meaning
changes anyway? Apart from this I'd be fine with this going in
ahead of the rest of this series.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Feb 16 15:54:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 15:54:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274266.469678 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKMdG-0007pu-Qa; Wed, 16 Feb 2022 15:54:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274266.469678; Wed, 16 Feb 2022 15:54:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKMdG-0007pn-NW; Wed, 16 Feb 2022 15:54:18 +0000
Received: by outflank-mailman (input) for mailman id 274266;
 Wed, 16 Feb 2022 15:54:17 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Gpsw=S7=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nKMdF-0007ph-8U
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 15:54:17 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b12a9bdb-8f40-11ec-b215-9bbe72dcb22c;
 Wed, 16 Feb 2022 16:54:15 +0100 (CET)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2056.outbound.protection.outlook.com [104.47.13.56]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-38-8ky15_9ZMLq2OK1Sq2CsdQ-1; Wed, 16 Feb 2022 16:54:14 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM9PR04MB8777.eurprd04.prod.outlook.com (2603:10a6:20b:408::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.18; Wed, 16 Feb
 2022 15:54:12 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4995.016; Wed, 16 Feb 2022
 15:54:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b12a9bdb-8f40-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645026855;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=9//Ze51g2rWtuH/+mWD56wUakSQCmxjrzIMfoLr+5P4=;
	b=b7JDmns4fZgq4LB+QAw95foSsYyn0mjQZeqIl0lgLYfelkGt7o5UV8pFZ+dXqg3YJbhxm0
	8KQaiLrfVj1gRcAnDaRaFvS1N4Wml+bGXUBwYgfrV0q9LnmkQslGdStjzoPxDXZ4/2bzzu
	c4809YnuJLUmN1Wj63E8Rmssplh50G8=
X-MC-Unique: 8ky15_9ZMLq2OK1Sq2CsdQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=BVN8kyt2RRsnLRejM8X3wBzqY+XOH181au5PhNARb2KwNLnLhbZ/+cWrQJEjN/WcdiPpAV3o3e1QC3bCir9gi/t3yK8M8DqM1OxPjxR0LMO74UpzrdEUi2btZR0LSjeGKS+QyeydZPhm2FveHyln1CVgxtMhNX1suWL3bZLYz2lrF28G3pFi0ANsYq4NEkWincq+6zJrZI+I8wKFUCKHOjmRKy3QEt7jlJ4VHUZyt+piIsA8Ard615jhYXtMSbrocDj4eqiQaoPpppB+ceDvr/W5qseTvwsW2F0Dpp7w23TKF/gE3LG6dd0IJLJ5wckMuWZJG7Akwh/4vLeG9OoQXQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=9//Ze51g2rWtuH/+mWD56wUakSQCmxjrzIMfoLr+5P4=;
 b=A3C2bp3MWSKRTUSFG61cjhRq+ORt1+02escdLYEDF8CwwGVwAsLndtSYbXWG/sNOUXnabqaTXdkjFRme5hXHEhTK0Mi2bh832SxtJPNNk5Ai602eRqx4HJMOWxfnr3Rb21hOKLqTDimfsqoxhkXfDCgPW4OmQVk2ThoFhXzkl1/0J4KWxdMLaSfWrH64PwU5/tatk6myM8a6teIE0gnuCm0dud0ZyYN0GgfTLS1fRzjcjIOJ69VIg94WEzb0K6XAlK6Xp3Fb81W40C2gtEo3A4G5DVbs0dgijNzCt8uAaPG9fQEfdWXJHnttrIHOPswEw+6K0wl5gbjy67fuXZGZ+Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <559ec172-c1e3-19ab-c0e4-64c8f0991e9f@suse.com>
Date: Wed, 16 Feb 2022 16:54:10 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v2 2/5] xen/vioapic: add support for the extended
 destination ID field
Content-Language: en-US
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: dwmw2@infradead.org, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Juergen Gross
 <jgross@suse.com>, xen-devel@lists.xenproject.org
References: <20220216103026.11533-1-roger.pau@citrix.com>
 <20220216103026.11533-3-roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220216103026.11533-3-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR07CA0021.eurprd07.prod.outlook.com
 (2603:10a6:20b:46c::26) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 0bee8727-0000-415c-5ec4-08d9f1649392
X-MS-TrafficTypeDiagnostic: AM9PR04MB8777:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<AM9PR04MB8777C667181A966B86353918B3359@AM9PR04MB8777.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	z8SPoCkRurqxFeqh7E2rze5BhlZWwR3rS6qWSHbivLSbXchGCeVpuwmSMJ0R1hFyUplgfjosOYBULFwPZ1wbYBw8jBGn1KwZK7NmKBf1s2z12bnihwA83XllhPNhYgLqfb73R9lwV/PPbajK5oGXjVB/nlGLJDvOWLBVi+mYpiQOHpkgLCC3yrtw9bqSQC2uFzXbs26Tk2wuvhNeFVkO2XZgW7T0uLxdw5td1CG+ew/Ow5SoxO/C/6r7Uv4fIpLA0U6cgb/+ZxImDT8m3cu1A6nbCyvDfIgdqwS5RVBL0B+DiG5lywxJGwSYg46Hc1lJBg93eQoK+JThr6jW+IS8t+3LiArRZ5uwyqeUnfi9O0MIDhKt1NQ11tIg3EpzoHGROUKQfeMqr/4GaweRL8xqrxWD0qvNEerReKBGG9YNXf15xakzZTjob6I/l0A7W4LUi6qlFq9B2YTK/02rG6/SP+RHFyPQztw83v4/C2xbgKV1BF7xUCN09plr+SZlbbUDlNeB+Z/eQyBuKEUXEqbd6Myf0YikGUqp473xIa/Cbn5iKksLAHIPBNAsyzN+/ogiEHq4CvtzlyjrRgD92i/8LDnag+aaMN7aIku/OItXULbhj5teSYz8seYoIruxtInrfltOpFs68C5y00jZogtG3XgJq4kYmuapIe1AsqZwv6lmiSBGW4nryz2SAjHsAJjvYFUpbdUCsjja2LsdJ8qmCLCquREFcH18rAZ7nZA7cc5sJ7mXinfoSd0OecESGJh/
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(31686004)(6506007)(53546011)(86362001)(66946007)(8676002)(36756003)(4326008)(31696002)(6486002)(508600001)(8936002)(66476007)(6512007)(66556008)(5660300002)(2906002)(83380400001)(316002)(2616005)(6916009)(186003)(38100700002)(54906003)(26005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?djZlcGpkUm1OdFYvbzRNeEpEN0RHVkpoTjM4TE1xQ2NFYkUxbmlSN3J2SDFU?=
 =?utf-8?B?MGlyeWpCTktLL2VxTmZjUzdOeVUzUjVvaW5PV01OY2FKT3FXYUxndzJSS0hK?=
 =?utf-8?B?Qi9lajRKZXNJeEJLK0V1Z05LR3VFWXo4dHlRN3diOHRRK1VOQVdNbm1NTWlo?=
 =?utf-8?B?bW1HOW9NTStVMlUraXpIcWlhcDZhV3ZoZmVPRjcvTXFqcXE2QU9tYXNLMjZJ?=
 =?utf-8?B?MmZZR1l5aDlNUEdjakVPdkN0RmFEbWdna2JxamxUZnBJQjVLU3lOdTBpd2l3?=
 =?utf-8?B?UWVjMW8yeklhQlFZUlRjMGZmZzdqMVM2R0Jocmp6cEc2SU1SOXFiQzZZbzhH?=
 =?utf-8?B?UjNkTU5pbmt1NkZEa096Y0kvaCtYQnE3cVRyelZ0dmpDcy9aNHJzODNCbWdk?=
 =?utf-8?B?Vk5SVXZuQkt4d2hDWWNuQ0ljZlRtNFEzZ3VtUFRrS1o4Tm80c1grSnJyR0M5?=
 =?utf-8?B?OVl5SitEdTljWHV6Rlo3c244WTRBNnBnNmwxZ2Z6bmhLVkt4QnFhYUpac09w?=
 =?utf-8?B?dUt3all6Q0Z5RFRWZDZxQnRmTktTWXJLUktnVVhUcnNoZ2EyL2NIejNnRFh1?=
 =?utf-8?B?M05RU1JoRzZDR3ExeWZ2ajhKNUZoYk4yOW9IajdidzJHMFE3bGo0SkIvRytV?=
 =?utf-8?B?VUQvT2VXZkFEd0FrWmdERkZzV25uWGtJUnNnNUtXazlrdGg1bVlWSTIvMCtR?=
 =?utf-8?B?WEdVRmxHVWZyUGtTMXpZQjErRU5sbmFaZFhDM3VGSllZOFlYVWZpQm05dERQ?=
 =?utf-8?B?TEkrcTRkS05RR3BaZWZDUERVL0NHUndlNnA0a2ZPOWZhanhFZDRkdmFEU2Fj?=
 =?utf-8?B?VDJ1VDNSa3dwQzRZNlhRSmhwVWg0Q3hZaDVPZDQ2YXVDcmR4clh3K0lzc09F?=
 =?utf-8?B?eHQ3bDREbEsrMjZlSnVKNjRveVhVbWtjd1FIWVhjYWxuUTVxNUp0Qm9zRTNk?=
 =?utf-8?B?RUxkSUlic1NYYTdsUzY5ZUw3SXl0TlB4cDRYeXJFeGFVTVc4d0FQNFlqSGk3?=
 =?utf-8?B?QndjK04ydWlrN25NUDNDY01zVTAwM1BydkUwVkdvYVA1eWFaaXlEL3NOM1JM?=
 =?utf-8?B?N3NlV2FLK3ViVWU2L0N0ZEtrN3EzVXRMQTZZZ2lNRnFCQS9vRGRBTmo3dE1O?=
 =?utf-8?B?U0hkeWJuR3JpOVlOSVRXam9XNE0rcUp5MG9qZkdETG80T2dIVGNyT1VuTFZo?=
 =?utf-8?B?Y29wNW5XQ0NIallZMHdFL0lxSDcxZEtiWHBDVTJhNWdabFUwSkdNOVF3bFM4?=
 =?utf-8?B?VHBUMTdEaGdxZXIvOHNjL2Z4aGFyNFFISnBybGpWTTcyN0Z4b0kzNXQ5ZHBa?=
 =?utf-8?B?UERKUU0rZUY2aVFxNi9zYlRzQ2YrZlNTa2IyZ0JWa1V0OGFXcmsrUU5tWWZv?=
 =?utf-8?B?ZVlySjkwUzgyU0IzZS9QSHcwMUlHL0V0VXFEWXZSRHhMaHpKWnVTNWZmQTJB?=
 =?utf-8?B?UnNpTXRqYnRrcHNKZzhGNTkwNXVpKzBRZnNQWEVrT2kzaUtTOFZkR2hpNnRD?=
 =?utf-8?B?aGlkNDc3MEowMlB1VjJyUWlUb0JLcHZ1Vjk3RFJTQlpzbzZoeDFxeUIxL1pE?=
 =?utf-8?B?R2k5by8rMjg0bU9rem1mNWFyakkyZmU1OTdkVitZUEk5czIrcWZvMVVBT2pH?=
 =?utf-8?B?dEFPZFNlZmZQRUNXWmdLZ0E4T094MjVkVm9WWnpNVUtmSi8yN3ZwektBT3dS?=
 =?utf-8?B?Wk5CSHhKY2dTL1lSa3N5TTBEVjJLVGg4MEp3OWR1ZTkxdEkxR3l1djMzNUpr?=
 =?utf-8?B?cjVuMGNkWFQ4QU4wUzlKMkw2TS9HRG9rTGV3cTdjdmVzTUJiM2UwQmdPdW1H?=
 =?utf-8?B?a25IeEp4MEhmN055b2I5YUVyNm1RZCtrL1cxNGN6YjFCKzBpV1FQQjlhc3hI?=
 =?utf-8?B?VHpteXNZSmJDNEp5M0pMNXVTRTNtRER3Y3hlM1Q0L3FmZENpam1WT3BCZWhG?=
 =?utf-8?B?cnFsVGpCcnhOY1Y5WDdsc21uWitDdXRkTDJxK21kWlNhYlc5c1Z0R3JkY1dw?=
 =?utf-8?B?L1B1Q3B5dUpjWldwcW04SUZTMmp3WkxzUmdHVTAvTTlJUDVId2ZmZnJmdnk3?=
 =?utf-8?B?Q0lScTZJaStFMGl6bkxGVDY3czB3ZFhQdysrcTRibkdFdm0zSGNhOWhFK2RN?=
 =?utf-8?B?ajJ1UytIYWFPYWpxUXVVZi9LbWR1R2lodDA2WGIyY2s3UUR0R2xVbVFpT0x0?=
 =?utf-8?Q?V9O2kBZWc53DadI+sbwJo4c=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0bee8727-0000-415c-5ec4-08d9f1649392
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2022 15:54:12.5908
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: H5HtIjsWu3l1dnkjf3oL8HGIUMBUVBytzhin/LvV2LUXR/saleHM539A3AvQ5+WaZNSBaSGCmPgQbAhvrPaTNw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8777

On 16.02.2022 11:30, Roger Pau Monne wrote:
> Such field uses bits 55:48, but for the purposes the register will be
> used use bits 55:49 instead. Bit 48 is used to signal an RTE entry is
> in remappable format which is not supported by the vIO-APIC.

Nit: The first sentence looks to have some stray words.

> --- a/tools/include/libxl.h
> +++ b/tools/include/libxl.h
> @@ -527,6 +527,14 @@
>   */
>  #define LIBXL_HAVE_MAX_GRANT_VERSION 1
>  
> +/*
> + * LIBXL_HAVE_X86_EXT_DEST_ID indicates the toolstack can signal to the
> + * hypervisor whether the domain wants to use the extended destination ID mode
> + * for interrupt messages. This is done by setting the libxl_domain_build_info
> + * arch_x86.ext_dest_id field.
> + */
> +#define LIBXL_HAVE_X86_EST_DEST_ID 1

Did you mean LIBXL_HAVE_X86_EXT_DEST_ID, as the comment has it?

> --- a/tools/libs/light/libxl_types.idl
> +++ b/tools/libs/light/libxl_types.idl
> @@ -648,6 +648,7 @@ libxl_domain_build_info = Struct("domain_build_info",[
>                                 ("vuart", libxl_vuart_type),
>                                ])),
>      ("arch_x86", Struct(None, [("msr_relaxed", libxl_defbool),
> +                               ("ext_dest_id", libxl_defbool),

Let's hope there's not going to appear any other meaning of "dest ID".
I would have suggested to add "apic" to the name, but this would get
it a little longish for my taste.

> --- a/xen/arch/x86/setup.c
> +++ b/xen/arch/x86/setup.c
> @@ -782,6 +782,7 @@ static struct domain *__init create_dom0(const module_t *image,
>  
>          dom0_cfg.arch.emulation_flags |=
>              XEN_X86_EMU_LAPIC | XEN_X86_EMU_IOAPIC | XEN_X86_EMU_VPCI;
> +        dom0_cfg.arch.misc_flags |= XEN_X86_EXT_DEST_ID;
>      }

Without any way to suppress this?

> --- a/xen/include/public/domctl.h
> +++ b/xen/include/public/domctl.h
> @@ -38,7 +38,7 @@
>  #include "hvm/save.h"
>  #include "memory.h"
>  
> -#define XEN_DOMCTL_INTERFACE_VERSION 0x00000014
> +#define XEN_DOMCTL_INTERFACE_VERSION 0x00000015

I'm struggling to figure which binary incompatible change in here
requires this bumping. Does this perhaps belong in a later patch?

Jan



From xen-devel-bounces@lists.xenproject.org Wed Feb 16 15:57:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 15:57:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274274.469689 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKMg7-0008Tf-AS; Wed, 16 Feb 2022 15:57:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274274.469689; Wed, 16 Feb 2022 15:57:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKMg7-0008TY-6m; Wed, 16 Feb 2022 15:57:15 +0000
Received: by outflank-mailman (input) for mailman id 274274;
 Wed, 16 Feb 2022 15:57:13 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Gpsw=S7=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nKMg5-0008TS-5R
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 15:57:13 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1a47bd82-8f41-11ec-8eb8-a37418f5ba1a;
 Wed, 16 Feb 2022 16:57:12 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2175.outbound.protection.outlook.com [104.47.17.175]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-15-BaX_eRtfPXusMu9qVQMNow-1; Wed, 16 Feb 2022 16:57:10 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DBBPR04MB7980.eurprd04.prod.outlook.com (2603:10a6:10:1f0::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.19; Wed, 16 Feb
 2022 15:57:08 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4995.016; Wed, 16 Feb 2022
 15:57:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1a47bd82-8f41-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645027031;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Nl3meSd5+jGLXE+GmNVidJkJ2Zx1TVlh0Ie83tElCs4=;
	b=jw0Em4SKsHSW5pCINt+eiv2rJ/4YtXafkoPP/5V4gI3BuTlyqjPSxjCWMx6CTVOOZ+1ruF
	sLRjOzHXPdCcdHCXDy7eow9wSwQblLc02lCVkRfgB6DW0PbPnTDaK5aRZmEVZZPI6NvK3b
	QinViXY9uz/SaBCXi39CvRsfwYqHD+U=
X-MC-Unique: BaX_eRtfPXusMu9qVQMNow-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=BkvyHbYAT1XMLC2p7gzt/WalAYOILPEBfaO5AILHyYmOLOM9gyXEBntHkvy2CEhndNti+7PN+ski5wQgKlFv/f5cXWGfdbKxLSKRt1CLM7IF2+iS+s9qjUuHqi1ADzu1NdJycXdhVODmoNLiaZk5tH1ONug38L4ypJW52qU126AnxFEcV4Z//ba74gXKdPl0vXG1nTqLSi4QNCm5a6gLcelMgIu1C/3QzKJtyNiNQS5oX4Lntdr2ay0ZmYs1H3YC6Y/9V4DfjYsbYvh+rZ7kO/xcJjWbJSNl4jy8HIKtv9n/K8fqZvc6lhSMZnuo3DefUSzJnvm/hrwKbMmjZAu2QA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Nl3meSd5+jGLXE+GmNVidJkJ2Zx1TVlh0Ie83tElCs4=;
 b=SBiI6uLxVEHcg1Cccf85FCDBtcrGvhGrZ60HGxTWBwI6tHIbSgMtfXWg3yQZZP85dUf1PEoxGLOhu7cqIMSnqA26qngOzbKZxFcFDRzB7zZKjXXtvDRRkH4meyLac5+G+yRMhDY92tmklW4pDEAJIplDFcgkjq3CJrjrYhNVy9lGpimOmC+jxkrP7s4/TrSNNGTPP4iu4nGIygQINHEh6DxA7p48rMrbPk+a/hyLjmmxv/Rf/5uT//XUgyHdJl6FNnkkjJJtz3Xjw2/uF1TGP+j1GXjNVCPD4RqBZwFt8Ip01H8iSBOYgwOSGPtZtB7JSG8Aij+/J5OFvMWSqxN1fQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <09091db3-9711-6971-bd62-6dc337cc84c1@suse.com>
Date: Wed, 16 Feb 2022 16:57:06 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v2 3/5] x86/vmsi: add support for extended destination ID
 in address field
Content-Language: en-US
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: dwmw2@infradead.org, Andrew Cooper <andrew.cooper3@citrix.com>,
 Wei Liu <wl@xen.org>, George Dunlap <george.dunlap@citrix.com>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Paul Durrant <paul@xen.org>, xen-devel@lists.xenproject.org
References: <20220216103026.11533-1-roger.pau@citrix.com>
 <20220216103026.11533-4-roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220216103026.11533-4-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR04CA0102.eurprd04.prod.outlook.com
 (2603:10a6:20b:50e::20) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 40599085-2ac9-48f4-b24b-08d9f164fc81
X-MS-TrafficTypeDiagnostic: DBBPR04MB7980:EE_
X-Microsoft-Antispam-PRVS:
	<DBBPR04MB7980CACA1CEFC3DD1316E946B3359@DBBPR04MB7980.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3631;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	5+4AQmoGjpBAnfXsq4R33v6B+08NIakSn+1TN7r/AQEfM44dyUQHwIxn6Fx2pjbknCVmhAuqNGl69pKP+9SwUE+X28C5Q8xpOntm7MbJtkektrt3JaF+RJ8MKeweXfdCXVVbpeecViH8E9/46/v/rprUJwAzAxETIrnjo07L0gNLUrEtA+FJwnaYi0+mEu1D1xFIrEuThpX52lqslwu4xb/ikZLvpsDMsiFOEu7O3kHSHK7ounK+r2UxGskq+kQMSYwbCgD8+RzVy00ZgTT0emO25M63oqC7+pH47hyKHqNcYiwy/et9kagoGOcSrQO2sgo1wytfbGB5T6xXy6MTS3qw6cNOFLU50jeevMSV37Bqg9XxCX3yUzeysAQJrYqsTtse6PiQ/JRBHGApdtxmlY1dlewoBqhjl5GckL+0sFXz4eGP58TSkKME6BeE+MmfcdSo1xA/0dzvAbb6ZVHv0isVyIVc9lk1WJLWCV4DI6zP/utoJPkEiINXNAV3wjkuLgAMG4U5GnC+SaKDNEBnKgAK1Yk1q+RIvifN/e18sEQ2/WVgqGt7BBDnuUu3rKX9my9UgdOtMqMBQbaI1+4hqegKsVElOZVfBsemncYGWe8HOTJQq9yHvcA8f0CEcUMgV3hq2mORYqVthiDLMOPJDG4voJkyJE5IR/f6DhhHaIgV4EbSHUDRYDgg+u35EeDCAk0q+p+aNRKzGkx4YxqWI6ksu3cvI//1KGa6oi/rQvg=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(31686004)(54906003)(26005)(186003)(6916009)(2616005)(316002)(6486002)(86362001)(508600001)(2906002)(36756003)(6506007)(31696002)(66556008)(66946007)(38100700002)(6512007)(53546011)(66476007)(8936002)(4744005)(5660300002)(8676002)(4326008)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?R1pJV3dmWlBHWitnUzZqOGtGMnpVYjBxQnJOMDlDaGhnKzFuWjFNK2JFRndQ?=
 =?utf-8?B?YkdtV1JQdUw0LzNmWk5ERFBKWks4ZVNzeFJHVUVIR1NZb0UrbjhZalVzOEwx?=
 =?utf-8?B?VExWTXZIWGJzRUc4ZGdzWUZFNW1Xelpkb1NyRHBJU1VoZHZvMlM5bVcxZnoy?=
 =?utf-8?B?d1IrekpLc0dSZ1FydGlxWjUyVG5rN2JBUGdpaHlmQ1E4eno5RjNYb2FiRGVS?=
 =?utf-8?B?SXRzdDJ2dkVPaDFhbi8ybFFaS1NSNUFVT01tY0pGSVdNcjU4NXJQMStwSzZm?=
 =?utf-8?B?bkl5WVpqdnFyd3M2SjVlSDZLdndDZUxidHJVRFlJMXI2MmhiN2lMeFovZ0Yw?=
 =?utf-8?B?eHU1ZmhmSUM0V1pNanI4c0lrWkZ0bWJKTWd5ZVpYdjlkNzU0aGQvRXJmdTFZ?=
 =?utf-8?B?K2taZ1NSUWg5Vnp4cUN6YkVWaGlsYkN2bTJaMXhrVjVwTUdWYlFDclAweGo2?=
 =?utf-8?B?dTlLc0MrcW9SR1U2L0NLa2hmMzZMd2hUNnlrUU1EYjJQZHV5UWZhVC9tNi82?=
 =?utf-8?B?cHFYNEtyREVzQzROeTB2cWNZNEZmV3RMSVV2ZTZ6MnNaMW90UmpJeDA2SWtu?=
 =?utf-8?B?RVdMcUs1NEM0SHpib0NaZ2RxMTdBWWZERktaN3VTQTBLQWpSK1pUS2k3a0Vt?=
 =?utf-8?B?U2U4NFJKL1VMbmJjOTNxRXB4dDI5dlBUV1RUWFlESE5xQlZOZGh5bDFQZkxp?=
 =?utf-8?B?VXpIMHRNUFVrWncyc0lCbmdGR0xpbW5aZ2NpK29UQTNocHZCMHo3QUFVa0l3?=
 =?utf-8?B?SWNQeHNNaEEzQXNHR2VWZDR3SUVvRFJiVFlYS1lENzFhd0h5bDE2NXczQm14?=
 =?utf-8?B?SElqVjhLMDNJeWFkMzcvK1lYd1Judi8yYVZlU1Rjc2hHQUtKRDFHd3R3d0pS?=
 =?utf-8?B?TTl6WEsybEo1ZUFPalVlbUYzZVFiNzh0c21EZ1VwV0FneGdtWmZNRWtWNDlF?=
 =?utf-8?B?MS9GdGpJRHVnTDh6V1N4RGhuYnFkaDgxbVMveHlZZzdnZHo4OW93Y3RQU1Bz?=
 =?utf-8?B?N3NrM2d2TW5Hc291N0kxWTd6dk1pMUMwcVg5bm9sNmJSaG9Mc2hlTTNocjBX?=
 =?utf-8?B?eTVLcS9POGU1a3BGNWZlMVp1b0xkQzFidlRybHhxemxLTjFKOTJtdGtGSStF?=
 =?utf-8?B?ZmpxQ0VGNW1FWHBNSEI1TUF5UEJoN0VBNlNTM3JIMlBDb3h6M2luZU1uSkVZ?=
 =?utf-8?B?TWYzbDJiQTdGaEFvTGtYcTh4ODMxUU5YRStpYmptYzNDSmhQdXhjREtNYWEv?=
 =?utf-8?B?V3lqMFZTcUoxK2pVMmMvamkrellTZzNrTHZ5RVhUVkJRTmpoMHNTZ1JFMFVL?=
 =?utf-8?B?UGhMQklocjY0L3dJMmlEMFpjOXJOblc2TzFodkw0RldvUFJyOWpaeFF6Nzlo?=
 =?utf-8?B?NVVSZDF6N2kxejEzTTVCMHQ5ZDdiUXc0RWp3OGlSTVlLbEIrRHFTS1I2eDEv?=
 =?utf-8?B?bjdBT2p1L3lFbkF6ei9WdDJMRWdaTndEQmZIR0pZRjl2S1FKS1hacWZCVGF6?=
 =?utf-8?B?V1NZV1g5UXNoZWptQm13WGl4NUVuWTV0alRmblhJWFgzbFZpaXRqemRwUHZi?=
 =?utf-8?B?L0haS2ZtWlBNNi93QmVXVGJGeEtleVBBVHhURi9qL1hMU1BWQ3NrOU4xaUhq?=
 =?utf-8?B?Ynh4MFh3amQrQ012aFZLditGMmY3VkU4b2g0dGVNalh4ZWxVbmg3M3FMSUFw?=
 =?utf-8?B?d2ZrUXdZS3BnSWpRNTdJcTR4OXpDNzE0T3U5UW8vb3Q5bExLNFhaR1RuNXA4?=
 =?utf-8?B?TEl2bGRuZWNTQUkydGtXdFVPR1UwbjJzaW1VTDVqcXRWejVuTjVYTDNHR05q?=
 =?utf-8?B?dGR1UVpIZ1ZWY0YxbGRWak1FMm1jMHMxN1BaREZjRGhzcHR6T3Z6aVJoN2ZQ?=
 =?utf-8?B?Y3JoaWIzK0xHOXllcEdHS2R2MjFORVpKMjU4ZjJBWnNERVdBbWgzUkI2VDA0?=
 =?utf-8?B?RlZZM3F5ZkxUMmVNMHkvVHMraFpJSjJlcHRCTVZsSGhoTGx4K0g1Q0R5TStM?=
 =?utf-8?B?V2tMODlzRE5yOXEzNStYY0dleERoVGM3eWF5aWo2V3lWdm1BOFJNbENCck8v?=
 =?utf-8?B?czY0NWdLUXR1WGgwTHVERS9rWHlFejlBMnBCMXdxMWovUm51ZUhKMWhGcUNJ?=
 =?utf-8?B?YW52QTRieUJrb0sxWk1MSWluQUZVV0ZFOUhtZE5pUVFHdzJidk9hK0VLQVFy?=
 =?utf-8?Q?Q7wGwOunC19ogM1NIeArZyQ=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 40599085-2ac9-48f4-b24b-08d9f164fc81
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2022 15:57:08.6580
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EVYmZY/7MZ6Mx0obzV2TQCuN5hNn4feo+WOUy2kTYicSgl5MRWevr6eafDgl5/wXoO0KnnW5a12snXHyvJXl+w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7980

On 16.02.2022 11:30, Roger Pau Monne wrote:
> --- a/xen/include/public/domctl.h
> +++ b/xen/include/public/domctl.h
> @@ -588,6 +588,7 @@ struct xen_domctl_bind_pt_irq {
>  #define XEN_DOMCTL_VMSI_X86_DELIV_MASK   0x007000
>  #define XEN_DOMCTL_VMSI_X86_TRIG_MASK    0x008000
>  #define XEN_DOMCTL_VMSI_X86_UNMASKED     0x010000
> +#define XEN_DOMCTL_VMSI_X86_EXT_DEST_ID_MASK 0xfe0000

I think this is what requires the interface version bump. With that
moved here:
Reviewed-by: Jan Beulich <jbeulich@suse.com>

Jan



From xen-devel-bounces@lists.xenproject.org Wed Feb 16 16:08:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 16:08:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274283.469699 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKMrC-00027t-EW; Wed, 16 Feb 2022 16:08:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274283.469699; Wed, 16 Feb 2022 16:08:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKMrC-00027m-Bc; Wed, 16 Feb 2022 16:08:42 +0000
Received: by outflank-mailman (input) for mailman id 274283;
 Wed, 16 Feb 2022 16:08:41 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=AMwT=S7=casper.srs.infradead.org=BATV+15dc3955894813e278c4+6751+infradead.org+dwmw2@srs-se1.protection.inumbo.net>)
 id 1nKMrA-00027N-Da
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 16:08:41 +0000
Received: from casper.infradead.org (casper.infradead.org
 [2001:8b0:10b:1236::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b275ea5d-8f42-11ec-b215-9bbe72dcb22c;
 Wed, 16 Feb 2022 17:08:37 +0100 (CET)
Received: from [2001:871:43:aaee:4f57:49b:cdd5:9de3]
 (helo=dynamic-pd01.res.v6.highway.a1.net)
 by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nKMr0-00EqeV-Lr; Wed, 16 Feb 2022 16:08:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b275ea5d-8f42-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=casper.20170209; h=MIME-Version:Content-Type:References:
	In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender:Reply-To:
	Content-Transfer-Encoding:Content-ID:Content-Description;
	bh=Y6Ad/kJNqTA7loK026v2It3OUujDJVTrB2N+NyXidu8=; b=mzZqDKya8OYTlQwPc0EahgD1JX
	jSTu5SwIDzUx7jOdOQzgntknCM2Ikd/uXuy5ueIBHfmCfEjCjE2t5PJH9qK/Q/+l1A29vO7XEWn8N
	mQOP9pc7L//dgqBoi5kAdkIpp+/gfWV3ljGmKR1Wh9Iy718gJLLuuMN5oHx2EytoVwGNI6wR4p+3Q
	MNerQIY47ql9kimdxER9EcS62tIEqX48nTndjppudSru3N6nJGAsIhKUcQKSAaATjC4gjVMk7BKYt
	CAR//s4dvX6HSqhFyV9HhIpla7AxOV4e3T2KMjqet89TN8gG/teeJlTEB73vJMMCp74Qg8bemcBJ4
	ga2PK+Bg==;
Message-ID: <fd22f7e19590b0e8679e5a3a15992bd1f8a92126.camel@infradead.org>
Subject: Re: [PATCH v2 1/5] x86/cpuid: add CPUID flag for Extended
 Destination ID support
From: David Woodhouse <dwmw2@infradead.org>
To: Jan Beulich <jbeulich@suse.com>, Roger Pau Monne <roger.pau@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>, 
	xen-devel@lists.xenproject.org
Date: Wed, 16 Feb 2022 17:08:29 +0100
In-Reply-To: <979fbc26-925c-f58f-9c1a-9ccd72275c9b@suse.com>
References: <20220216103026.11533-1-roger.pau@citrix.com>
	 <20220216103026.11533-2-roger.pau@citrix.com>
	 <979fbc26-925c-f58f-9c1a-9ccd72275c9b@suse.com>
Content-Type: multipart/signed; micalg="sha-256"; protocol="application/pkcs7-signature";
	boundary="=-FE9ilsyxNQ32bo6r4yLH"
User-Agent: Evolution 3.36.5-0ubuntu1 
MIME-Version: 1.0
X-SRS-Rewrite: SMTP reverse-path rewritten from <dwmw2@infradead.org> by casper.infradead.org. See http://www.infradead.org/rpr.html


--=-FE9ilsyxNQ32bo6r4yLH
Content-Type: multipart/alternative; boundary="=-9+OnViAg1R5rI9Okleeq"


--=-9+OnViAg1R5rI9Okleeq
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, 2022-02-16 at 16:43 +0100, Jan Beulich wrote:
> On 16.02.2022 11:30, Roger Pau Monne wrote:
> > --- a/xen/include/public/arch-x86/cpuid.h
> > +++ b/xen/include/public/arch-x86/cpuid.h
> > @@ -102,6 +102,12 @@
> >  #define XEN_HVM_CPUID_IOMMU_MAPPINGS   (1u << 2)
> >  #define XEN_HVM_CPUID_VCPU_ID_PRESENT  (1u << 3) /* vcpu id is present=
 in EBX */
> >  #define XEN_HVM_CPUID_DOMID_PRESENT    (1u << 4) /* domid is present i=
n ECX */
> > +/*
> > + * Bits 55:49 from the IO-APIC RTE and bits 11:5 from the MSI address =
can be
> > + * used to store high bits for the Destination ID. This expands the De=
stination
> > + * ID field from 8 to 15 bits, allowing to target APIC IDs up 32768.
> > + */
> > +#define XEN_HVM_CPUID_EXT_DEST_ID      (1u << 5)
>=20
> Would the comment perhaps better include "in the absence of (guest
> visible) interrupt remapping", since otherwise the layout / meaning
> changes anyway? Apart from this I'd be fine with this going in
> ahead of the rest of this series.

No, this still works even if the guest has a vIOMMU with interrupt
remapping. The Compatibility Format and Remappable Format MSI messages
are distinct because the low bit of the Ext Dest ID is used to indicate
Remappable Format.

If you wanted to add "=E2=80=A6 without having to use interrupt remapping i=
n
the guest" to the end of the comment then I suppose you could, but I
don't think it adds much.


--=-9+OnViAg1R5rI9Okleeq
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

<html dir=3D"ltr"><head></head><body style=3D"text-align:left; direction:lt=
r;"><pre>On Wed, 2022-02-16 at 16:43 +0100, Jan Beulich wrote:</pre><blockq=
uote type=3D"cite" style=3D"margin:0 0 0 .8ex; border-left:2px #729fcf soli=
d;padding-left:1ex"><pre>On 16.02.2022 11:30, Roger Pau Monne wrote:</pre><=
blockquote type=3D"cite" style=3D"margin:0 0 0 .8ex; border-left:2px #729fc=
f solid;padding-left:1ex"><pre>--- a/xen/include/public/arch-x86/cpuid.h</p=
re><pre>+++ b/xen/include/public/arch-x86/cpuid.h</pre><pre>@@ -102,6 +102,=
12 @@</pre><pre> #define XEN_HVM_CPUID_IOMMU_MAPPINGS   (1u &lt;&lt; 2)</pr=
e><pre> #define XEN_HVM_CPUID_VCPU_ID_PRESENT  (1u &lt;&lt; 3) /* vcpu id i=
s present in EBX */</pre><pre> #define XEN_HVM_CPUID_DOMID_PRESENT    (1u &=
lt;&lt; 4) /* domid is present in ECX */</pre><pre>+/*</pre><pre>+ * Bits 5=
5:49 from the IO-APIC RTE and bits 11:5 from the MSI address can be</pre><p=
re>+ * used to store high bits for the Destination ID. This expands the Des=
tination</pre><pre>+ * ID field from 8 to 15 bits, allowing to target APIC =
IDs up 32768.</pre><pre>+ */</pre><pre>+#define XEN_HVM_CPUID_EXT_DEST_ID  =
    (1u &lt;&lt; 5)</pre></blockquote><pre><br></pre><pre>Would the comment=
 perhaps better include "in the absence of (guest</pre><pre>visible) interr=
upt remapping", since otherwise the layout / meaning</pre><pre>changes anyw=
ay? Apart from this I'd be fine with this going in</pre><pre>ahead of the r=
est of this series.</pre></blockquote><pre><br></pre><pre>No, this still wo=
rks even if the guest has a vIOMMU with interrupt</pre><pre>remapping. The =
Compatibility Format and Remappable Format MSI messages</pre><pre>are disti=
nct because the low bit of the Ext Dest ID is used to indicate</pre><pre>Re=
mappable Format.</pre><pre><br></pre><pre>If you wanted to add "=E2=80=A6 w=
ithout having to use interrupt remapping in</pre><pre>the guest" to the end=
 of the comment then I suppose you could, but I</pre><pre>don't think it ad=
ds much.</pre><div><br></div></body></html>

--=-9+OnViAg1R5rI9Okleeq--

--=-FE9ilsyxNQ32bo6r4yLH
Content-Type: application/pkcs7-signature; name="smime.p7s"
Content-Disposition: attachment; filename="smime.p7s"
Content-Transfer-Encoding: base64

MIAGCSqGSIb3DQEHAqCAMIACAQExDzANBglghkgBZQMEAgEFADCABgkqhkiG9w0BBwEAAKCCEkQw
ggYQMIID+KADAgECAhBNlCwQ1DvglAnFgS06KwZPMA0GCSqGSIb3DQEBDAUAMIGIMQswCQYDVQQG
EwJVUzETMBEGA1UECBMKTmV3IEplcnNleTEUMBIGA1UEBxMLSmVyc2V5IENpdHkxHjAcBgNVBAoT
FVRoZSBVU0VSVFJVU1QgTmV0d29yazEuMCwGA1UEAxMlVVNFUlRydXN0IFJTQSBDZXJ0aWZpY2F0
aW9uIEF1dGhvcml0eTAeFw0xODExMDIwMDAwMDBaFw0zMDEyMzEyMzU5NTlaMIGWMQswCQYDVQQG
EwJHQjEbMBkGA1UECBMSR3JlYXRlciBNYW5jaGVzdGVyMRAwDgYDVQQHEwdTYWxmb3JkMRgwFgYD
VQQKEw9TZWN0aWdvIExpbWl0ZWQxPjA8BgNVBAMTNVNlY3RpZ28gUlNBIENsaWVudCBBdXRoZW50
aWNhdGlvbiBhbmQgU2VjdXJlIEVtYWlsIENBMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKC
AQEAyjztlApB/975Rrno1jvm2pK/KxBOqhq8gr2+JhwpKirSzZxQgT9tlC7zl6hn1fXjSo5MqXUf
ItMltrMaXqcESJuK8dtK56NCSrq4iDKaKq9NxOXFmqXX2zN8HHGjQ2b2Xv0v1L5Nk1MQPKA19xeW
QcpGEGFUUd0kN+oHox+L9aV1rjfNiCj3bJk6kJaOPabPi2503nn/ITX5e8WfPnGw4VuZ79Khj1YB
rf24k5Ee1sLTHsLtpiK9OjG4iQRBdq6Z/TlVx/hGAez5h36bBJMxqdHLpdwIUkTqT8se3ed0PewD
ch/8kHPo5fZl5u1B0ecpq/sDN/5sCG52Ds+QU5O5EwIDAQABo4IBZDCCAWAwHwYDVR0jBBgwFoAU
U3m/WqorSs9UgOHYm8Cd8rIDZsswHQYDVR0OBBYEFAnA8vwL2pTbX/4r36iZQs/J4K0AMA4GA1Ud
DwEB/wQEAwIBhjASBgNVHRMBAf8ECDAGAQH/AgEAMB0GA1UdJQQWMBQGCCsGAQUFBwMCBggrBgEF
BQcDBDARBgNVHSAECjAIMAYGBFUdIAAwUAYDVR0fBEkwRzBFoEOgQYY/aHR0cDovL2NybC51c2Vy
dHJ1c3QuY29tL1VTRVJUcnVzdFJTQUNlcnRpZmljYXRpb25BdXRob3JpdHkuY3JsMHYGCCsGAQUF
BwEBBGowaDA/BggrBgEFBQcwAoYzaHR0cDovL2NydC51c2VydHJ1c3QuY29tL1VTRVJUcnVzdFJT
QUFkZFRydXN0Q0EuY3J0MCUGCCsGAQUFBzABhhlodHRwOi8vb2NzcC51c2VydHJ1c3QuY29tMA0G
CSqGSIb3DQEBDAUAA4ICAQBBRHUAqznCFfXejpVtMnFojADdF9d6HBA4kMjjsb0XMZHztuOCtKF+
xswhh2GqkW5JQrM8zVlU+A2VP72Ky2nlRA1GwmIPgou74TZ/XTarHG8zdMSgaDrkVYzz1g3nIVO9
IHk96VwsacIvBF8JfqIs+8aWH2PfSUrNxP6Ys7U0sZYx4rXD6+cqFq/ZW5BUfClN/rhk2ddQXyn7
kkmka2RQb9d90nmNHdgKrwfQ49mQ2hWQNDkJJIXwKjYA6VUR/fZUFeCUisdDe/0ABLTI+jheXUV1
eoYV7lNwNBKpeHdNuO6Aacb533JlfeUHxvBz9OfYWUiXu09sMAviM11Q0DuMZ5760CdO2VnpsXP4
KxaYIhvqPqUMWqRdWyn7crItNkZeroXaecG03i3mM7dkiPaCkgocBg0EBYsbZDZ8bsG3a08LwEsL
1Ygz3SBsyECa0waq4hOf/Z85F2w2ZpXfP+w8q4ifwO90SGZZV+HR/Jh6rEaVPDRF/CEGVqR1hiuQ
OZ1YL5ezMTX0ZSLwrymUE0pwi/KDaiYB15uswgeIAcA6JzPFf9pLkAFFWs1QNyN++niFhsM47qod
x/PL+5jR87myx5uYdBEQkkDc+lKB1Wct6ucXqm2EmsaQ0M95QjTmy+rDWjkDYdw3Ms6mSWE3Bn7i
5ZgtwCLXgAIe5W8mybM2JzCCBhQwggT8oAMCAQICEQDGvhmWZ0DEAx0oURL6O6l+MA0GCSqGSIb3
DQEBCwUAMIGWMQswCQYDVQQGEwJHQjEbMBkGA1UECBMSR3JlYXRlciBNYW5jaGVzdGVyMRAwDgYD
VQQHEwdTYWxmb3JkMRgwFgYDVQQKEw9TZWN0aWdvIExpbWl0ZWQxPjA8BgNVBAMTNVNlY3RpZ28g
UlNBIENsaWVudCBBdXRoZW50aWNhdGlvbiBhbmQgU2VjdXJlIEVtYWlsIENBMB4XDTIyMDEwNzAw
MDAwMFoXDTI1MDEwNjIzNTk1OVowJDEiMCAGCSqGSIb3DQEJARYTZHdtdzJAaW5mcmFkZWFkLm9y
ZzCCAiIwDQYJKoZIhvcNAQEBBQADggIPADCCAgoCggIBALQ3GpC2bomUqk+91wLYBzDMcCj5C9m6
oZaHwvmIdXftOgTbCJXADo6G9T7BBAebw2JV38EINgKpy/ZHh7htyAkWYVoFsFPrwHounto8xTsy
SSePMiPlmIdQ10BcVSXMUJ3Juu16GlWOnAMJY2oYfEzmE7uT9YgcBqKCo65pTFmOnR/VVbjJk4K2
xE34GC2nAdUQkPFuyaFisicc6HRMOYXPuF0DuwITEKnjxgNjP+qDrh0db7PAjO1D4d5ftfrsf+kd
RR4gKVGSk8Tz2WwvtLAroJM4nXjNPIBJNT4w/FWWc/5qPHJy2U+eITZ5LLE5s45mX2oPFknWqxBo
bQZ8a9dsZ3dSPZBvE9ZrmtFLrVrN4eo1jsXgAp1+p7bkfqd3BgBEmfsYWlBXO8rVXfvPgLs32VdV
NZxb/CDWPqBsiYv0Hv3HPsz07j5b+/cVoWqyHDKzkaVbxfq/7auNVRmPB3v5SWEsH8xi4Bez2V9U
KxfYCnqsjp8RaC2/khxKt0A552Eaxnz/4ly/2C7wkwTQnBmdlFYhAflWKQ03Ufiu8t3iBE3VJbc2
5oMrglj7TRZrmKq3CkbFnX0fyulB+kHimrt6PIWn7kgyl9aelIl6vtbhMA+l0nfrsORMa4kobqQ5
C5rveVgmcIad67EDa+UqEKy/GltUwlSh6xy+TrK1tzDvAgMBAAGjggHMMIIByDAfBgNVHSMEGDAW
gBQJwPL8C9qU21/+K9+omULPyeCtADAdBgNVHQ4EFgQUzMeDMcimo0oz8o1R1Nver3ZVpSkwDgYD
VR0PAQH/BAQDAgWgMAwGA1UdEwEB/wQCMAAwHQYDVR0lBBYwFAYIKwYBBQUHAwQGCCsGAQUFBwMC
MEAGA1UdIAQ5MDcwNQYMKwYBBAGyMQECAQEBMCUwIwYIKwYBBQUHAgEWF2h0dHBzOi8vc2VjdGln
by5jb20vQ1BTMFoGA1UdHwRTMFEwT6BNoEuGSWh0dHA6Ly9jcmwuc2VjdGlnby5jb20vU2VjdGln
b1JTQUNsaWVudEF1dGhlbnRpY2F0aW9uYW5kU2VjdXJlRW1haWxDQS5jcmwwgYoGCCsGAQUFBwEB
BH4wfDBVBggrBgEFBQcwAoZJaHR0cDovL2NydC5zZWN0aWdvLmNvbS9TZWN0aWdvUlNBQ2xpZW50
QXV0aGVudGljYXRpb25hbmRTZWN1cmVFbWFpbENBLmNydDAjBggrBgEFBQcwAYYXaHR0cDovL29j
c3Auc2VjdGlnby5jb20wHgYDVR0RBBcwFYETZHdtdzJAaW5mcmFkZWFkLm9yZzANBgkqhkiG9w0B
AQsFAAOCAQEAyW6MUir5dm495teKqAQjDJwuFCi35h4xgnQvQ/fzPXmtR9t54rpmI2TfyvcKgOXp
qa7BGXNFfh1JsqexVkIqZP9uWB2J+uVMD+XZEs/KYNNX2PvIlSPrzIB4Z2wyIGQpaPLlYflrrVFK
v9CjT2zdqvy2maK7HKOQRt3BiJbVG5lRiwbbygldcALEV9ChWFfgSXvrWDZspnU3Gjw/rMHrGnql
Htlyebp3pf3fSS9kzQ1FVtVIDrL6eqhTwJxe+pXSMMqFiN0whpBtXdyDjzBtQTaZJ7zTT/vlehc/
tDuqZwGHm/YJy883Ll+GP3NvOkgaRGWEuYWJJ6hFCkXYjyR9IzCCBhQwggT8oAMCAQICEQDGvhmW
Z0DEAx0oURL6O6l+MA0GCSqGSIb3DQEBCwUAMIGWMQswCQYDVQQGEwJHQjEbMBkGA1UECBMSR3Jl
YXRlciBNYW5jaGVzdGVyMRAwDgYDVQQHEwdTYWxmb3JkMRgwFgYDVQQKEw9TZWN0aWdvIExpbWl0
ZWQxPjA8BgNVBAMTNVNlY3RpZ28gUlNBIENsaWVudCBBdXRoZW50aWNhdGlvbiBhbmQgU2VjdXJl
IEVtYWlsIENBMB4XDTIyMDEwNzAwMDAwMFoXDTI1MDEwNjIzNTk1OVowJDEiMCAGCSqGSIb3DQEJ
ARYTZHdtdzJAaW5mcmFkZWFkLm9yZzCCAiIwDQYJKoZIhvcNAQEBBQADggIPADCCAgoCggIBALQ3
GpC2bomUqk+91wLYBzDMcCj5C9m6oZaHwvmIdXftOgTbCJXADo6G9T7BBAebw2JV38EINgKpy/ZH
h7htyAkWYVoFsFPrwHounto8xTsySSePMiPlmIdQ10BcVSXMUJ3Juu16GlWOnAMJY2oYfEzmE7uT
9YgcBqKCo65pTFmOnR/VVbjJk4K2xE34GC2nAdUQkPFuyaFisicc6HRMOYXPuF0DuwITEKnjxgNj
P+qDrh0db7PAjO1D4d5ftfrsf+kdRR4gKVGSk8Tz2WwvtLAroJM4nXjNPIBJNT4w/FWWc/5qPHJy
2U+eITZ5LLE5s45mX2oPFknWqxBobQZ8a9dsZ3dSPZBvE9ZrmtFLrVrN4eo1jsXgAp1+p7bkfqd3
BgBEmfsYWlBXO8rVXfvPgLs32VdVNZxb/CDWPqBsiYv0Hv3HPsz07j5b+/cVoWqyHDKzkaVbxfq/
7auNVRmPB3v5SWEsH8xi4Bez2V9UKxfYCnqsjp8RaC2/khxKt0A552Eaxnz/4ly/2C7wkwTQnBmd
lFYhAflWKQ03Ufiu8t3iBE3VJbc25oMrglj7TRZrmKq3CkbFnX0fyulB+kHimrt6PIWn7kgyl9ae
lIl6vtbhMA+l0nfrsORMa4kobqQ5C5rveVgmcIad67EDa+UqEKy/GltUwlSh6xy+TrK1tzDvAgMB
AAGjggHMMIIByDAfBgNVHSMEGDAWgBQJwPL8C9qU21/+K9+omULPyeCtADAdBgNVHQ4EFgQUzMeD
Mcimo0oz8o1R1Nver3ZVpSkwDgYDVR0PAQH/BAQDAgWgMAwGA1UdEwEB/wQCMAAwHQYDVR0lBBYw
FAYIKwYBBQUHAwQGCCsGAQUFBwMCMEAGA1UdIAQ5MDcwNQYMKwYBBAGyMQECAQEBMCUwIwYIKwYB
BQUHAgEWF2h0dHBzOi8vc2VjdGlnby5jb20vQ1BTMFoGA1UdHwRTMFEwT6BNoEuGSWh0dHA6Ly9j
cmwuc2VjdGlnby5jb20vU2VjdGlnb1JTQUNsaWVudEF1dGhlbnRpY2F0aW9uYW5kU2VjdXJlRW1h
aWxDQS5jcmwwgYoGCCsGAQUFBwEBBH4wfDBVBggrBgEFBQcwAoZJaHR0cDovL2NydC5zZWN0aWdv
LmNvbS9TZWN0aWdvUlNBQ2xpZW50QXV0aGVudGljYXRpb25hbmRTZWN1cmVFbWFpbENBLmNydDAj
BggrBgEFBQcwAYYXaHR0cDovL29jc3Auc2VjdGlnby5jb20wHgYDVR0RBBcwFYETZHdtdzJAaW5m
cmFkZWFkLm9yZzANBgkqhkiG9w0BAQsFAAOCAQEAyW6MUir5dm495teKqAQjDJwuFCi35h4xgnQv
Q/fzPXmtR9t54rpmI2TfyvcKgOXpqa7BGXNFfh1JsqexVkIqZP9uWB2J+uVMD+XZEs/KYNNX2PvI
lSPrzIB4Z2wyIGQpaPLlYflrrVFKv9CjT2zdqvy2maK7HKOQRt3BiJbVG5lRiwbbygldcALEV9Ch
WFfgSXvrWDZspnU3Gjw/rMHrGnqlHtlyebp3pf3fSS9kzQ1FVtVIDrL6eqhTwJxe+pXSMMqFiN0w
hpBtXdyDjzBtQTaZJ7zTT/vlehc/tDuqZwGHm/YJy883Ll+GP3NvOkgaRGWEuYWJJ6hFCkXYjyR9
IzGCBMcwggTDAgEBMIGsMIGWMQswCQYDVQQGEwJHQjEbMBkGA1UECBMSR3JlYXRlciBNYW5jaGVz
dGVyMRAwDgYDVQQHEwdTYWxmb3JkMRgwFgYDVQQKEw9TZWN0aWdvIExpbWl0ZWQxPjA8BgNVBAMT
NVNlY3RpZ28gUlNBIENsaWVudCBBdXRoZW50aWNhdGlvbiBhbmQgU2VjdXJlIEVtYWlsIENBAhEA
xr4ZlmdAxAMdKFES+jupfjANBglghkgBZQMEAgEFAKCCAeswGAYJKoZIhvcNAQkDMQsGCSqGSIb3
DQEHATAcBgkqhkiG9w0BCQUxDxcNMjIwMjE2MTYwODI5WjAvBgkqhkiG9w0BCQQxIgQg4ESaKCSh
WyC2W1ByPmRLeUxvwiwkgN+GzdqGdnd33zIwgb0GCSsGAQQBgjcQBDGBrzCBrDCBljELMAkGA1UE
BhMCR0IxGzAZBgNVBAgTEkdyZWF0ZXIgTWFuY2hlc3RlcjEQMA4GA1UEBxMHU2FsZm9yZDEYMBYG
A1UEChMPU2VjdGlnbyBMaW1pdGVkMT4wPAYDVQQDEzVTZWN0aWdvIFJTQSBDbGllbnQgQXV0aGVu
dGljYXRpb24gYW5kIFNlY3VyZSBFbWFpbCBDQQIRAMa+GZZnQMQDHShREvo7qX4wgb8GCyqGSIb3
DQEJEAILMYGvoIGsMIGWMQswCQYDVQQGEwJHQjEbMBkGA1UECBMSR3JlYXRlciBNYW5jaGVzdGVy
MRAwDgYDVQQHEwdTYWxmb3JkMRgwFgYDVQQKEw9TZWN0aWdvIExpbWl0ZWQxPjA8BgNVBAMTNVNl
Y3RpZ28gUlNBIENsaWVudCBBdXRoZW50aWNhdGlvbiBhbmQgU2VjdXJlIEVtYWlsIENBAhEAxr4Z
lmdAxAMdKFES+jupfjANBgkqhkiG9w0BAQEFAASCAgAzGPAOC7rQgRDrrJLduhQnATjMR00elJ6l
kkviiBHmw8sRB7LcIFXzihmCCeOHBwYVwKKwzoihO/ccWKh9s5oFlvwunf985gulV48fS0EpVOsl
XpqGWpDcZUXofGZtggGlkvuzfY2FsvlamYMomS+7GqvE8Y27rMwhLVVmr96ComlZ5CPHmEy7UQqk
A0LKcRLsVe3+uRcmZAA+uqPBUTu6KDsiWcBRjH3DoTs3oHuts0LiRKeMOIFSfwMzvdFKy8euS2As
AtW6Fjy0hxxBWScsx81h25Kfocs4Cd/SWDhZiooSQGhJUnXs7sGkmlgtfJYfAanvMF6zOQqt57cx
wA9KBnAqs6maMdYUdR757+5XPb/NNLNfDGCYp3Bd5a5PEJPTAiZ90Q99i0MFg0LIZ4KD/wqhveGB
noXYrStOwYTypFd1ud8d2rKkCL+IT8tDImlclBGutonrBL6+TxGUZJs0pB/WUoTM4GxfTN7860NH
rw1JejcZPXI94mcGNE0qHB3qP+LcOKXxxF8nNKRTIunG04H3JTuQ1jz84MMNVLHUOiYzJApvJ9DA
VFaOfiUMWfO+OX+xqAgj9g5MvuwfmjEGDT4dHO5PacV5aDe854AAZETJ9/At93devfyE+/Z74vzC
1/jM9I0Nxrfau5blbhrfTa7PlDQIBzRyyR/To8PNXgAAAAAAAA==


--=-FE9ilsyxNQ32bo6r4yLH--



From xen-devel-bounces@lists.xenproject.org Wed Feb 16 16:22:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 16:22:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274291.469716 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKN48-0004RT-18; Wed, 16 Feb 2022 16:22:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274291.469716; Wed, 16 Feb 2022 16:22:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKN47-0004PY-Qx; Wed, 16 Feb 2022 16:22:03 +0000
Received: by outflank-mailman (input) for mailman id 274291;
 Wed, 16 Feb 2022 16:22:02 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=oYE0=S7=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nKN46-0004NT-Mm
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 16:22:02 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 916820ed-8f44-11ec-b215-9bbe72dcb22c;
 Wed, 16 Feb 2022 17:22:00 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 916820ed-8f44-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645028520;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:content-transfer-encoding:mime-version;
  bh=JHqA1stN/h7CkLREvasdTybcxRF2lyYLB/1/bAsoRGo=;
  b=CG7Jkn/Z9mEGgT+r8WvO3T1/+5pGNnJIxpIAwGyaDm22+Bgg/DO6orNx
   EXE8hOf8d/3fl1/dLmxpxagkZ7tGGPzMKeQ5FVV40wT8rbxxSrIhXC44y
   cpxFCOjOfaEK9TNGIxWCredYRAHL/pJ/k/W/Pv0AemO3nc65HPTv4vZoR
   0=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: LtBb+DVRLzoTfbdBNP60pqhrCZqUsiy1PUemff9wYnqeTFlBBaMXu3QXdvatExslLtS+GsIgdG
 NOtxvNCTcwZ9FW3sQojB733CYrZdJW9G73ELYnEXAyvyl0EMMw6wv1crZYefKfhSLP/q5aQ1r6
 UdEhVcdYVb0JYRV2R6PXviXnyYzpdx5F4htu3WVtAHpa9Q42aC3UG6GyHu6n57feLpK+def49P
 uuxsZ/GM/dsIC9MmXRKBJxRI92vobPkB34xQIaCW/1HDfEpv8I0IGSNsChcrYpwxkXd5WVonhd
 BW/NopGiUVJHZkEnovXU9WRi
X-SBRS: 5.1
X-MesageID: 64256048
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:KDx1Na6lPxdl9F6X0BcIwQxRtOTAchMFZxGqfqrLsTDasY5as4F+v
 mUbCjuEO6uCYjT2etx1Ptm0809QusfWm9ZkTANl/Hs8Hi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FV8MpBsJ00o5wbZj29Aw27BVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z+
 YwWqLqdEggQLqTItORCUyYEFQddFPgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALNs7kMZlZonh95TrYEewnUdbIRKCiCdpwgmtq254WQaa2i
 8wxdDdCTEvKbBB1F3Q3Gq8lwvuSiDryWmgNwL6SjfVuuDWCpOBr65DyNPLFd9rMQt9a9m6ar
 G/b+2XyAjkBKceSjzGC9xqEluLJ2C/2Ro8WPLm57eJxxk2ewHQJDx8bXkf9puO24nNSQPoGd
 RZSoHB36/Fvqgr7FbERQiFUvla150UBffcLHNQq4QWhyvXU3FqfIEstG2sphMMdiOc6Qjkj1
 1msltzvBCByvLD9dU9x5ot4vhvpZ3FLcDZqiTssCFJcvoK9+N1bYgfnE447eJNZmOEZDt0ZL
 9qiiCElz4segscQv0lQ1QCW2mn8znQlo+Nc2+k2Yo5Hxl4hDGJGT9bxgbQ+0RqmBNzEJrVml
 CJZ8/VyFMhUUfmweNWlGY3h5o2B6fefKyH7ilVyBZQn/DnF0yf9IdwBvWgkdRY4a5xsldrVj
 Kn74145CHh7ZiXCUEOKS9jpV5RCIVbISbwJqcw4nvIRO8MsJWdrDQllZFKK3nCFraTfufpXB
 HtvSu71VSxyIf0+lFKeHr5BuZd2lnFW7T6CHvjTkkX4uYdykVbIEN/pxnPVNbtnhE5FyS2Im
 +ti2zyikUUPCravPXOOrOb+7zkidBAGOHw/kOQOHsarKQt6AmAxTfjXxLIqYYt+mKpJ0OzP+
 xmAtoVwkjITXFXLdleHbG5NcrTqUcotpH43J3V0b12px2IiccCk66JGL8k7erwu9epCy/9oT
 qZaJ5XcU6oXEjmXqS4AaZTdrZB5cEj5jwy5ICf4MiM0eIRtRlKV94a8LBfv7iQHEgG+qdA6/
 ++7zgreTJdaH1ZiAc/aZeiB1VS0uXRByut+U1GReotYeVn28ZgsICv016dlL8YJIBTF5z2by
 wfJXktI+biT+9c4qYCbi7qFooGlF/pFMnBbR2SLv6yrMST6/3a4xdMSWui/Yj2ABnj//7+vZ
 LsJwqikYuEHhltDr6F1D61vkfAl/9LqqrJXklZkEXHMYwj5A79sOCDbj8xGt6kLzb5FowqmH
 EmI/4ACa7mOPcrkFn8XJRYkMbvfha1FxGGK4KRnOlj+6Q924KGDABdbMBS7gSBAKKd4bdE+y
 uA7tc9KswGyh3LG6DpdYvy4I4hUEkE9bg==
IronPort-HdrOrdr: A9a23:pvIjl6rfanF8uPK3pFo3lxwaV5oXeYIsimQD101hICG9Ffbo8/
 xG/c5rsCMc5wxhO03I9ergBEDiex3hHPxOkO4s1N6ZNWGN1VdARLsSi7cKqAeQeREWmNQ86U
 5ISdkGNDWuZmIQsS+B2maF+nwbsaG6GduT6dvj8w==
X-IronPort-AV: E=Sophos;i="5.88,374,1635220800"; 
   d="scan'208";a="64256048"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=HhO8ffn98OsJYe7Vbfje5Sd2hy1/bzrzNRago4iq018a8Yhr1dxnOveI3KzMkJuoJ3QZkDb89a5hALzvvsoxYQ1/MEWTwrvSnoIaHXLuOw92l5sLfvBa3rWA6Lj/HwqMRcMsIz0az3Shs62p8ZmiH1I/ti+huF2PPwSi/kZ8QqiAfZVY0U5bkU2wRyCSj3C5aj7Syh81G8rxl+Wh6eCHbTaTY00+fkP8uYXEBKKjRsanwaCE2Z4O54wADuDVKy522Ru5tA/RBbZzkmEGf4JUnOZFj8bDUnjmPeI9yvrwJUNRMUz1183r7BWZZ5KwbF5ucPmgpAdC4PsqQGyCkg2SHg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=J/c6eVyHYJXVUlazWNeV+ylcxSqZ5nGqV/mmllNoyMw=;
 b=av1yU3eMMX5oMtJjsffdN9h1A+PThG1Eh/A+mehnlrTgIZXeOHDOl3QW48/XQVCRr9juOYy6N6y8w3OlMeJNb1zXqNB0pDBSr5ln0zE0eitbYwGXX/qh4y48VARb476AAKhs35H/Wn8lv2AadaMSEKjqFdobJKcdd9qyWNzMgnmiSJWyzwZyZ6CYNlnChL+KHQNkZqOxjQlIeaktbWlztzH5KK2IDWG+0J4pg8ByxoB6E09/NtfSnsIprk5Io+w7/0u/a8KuYChTmIuleZM8DezPtS1aq0kLxoMU0svwJwbOt6oQe3nMTK2nLMRB2eYNRyvWDcZ5lhxZkV8DcuVRYQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=J/c6eVyHYJXVUlazWNeV+ylcxSqZ5nGqV/mmllNoyMw=;
 b=AMUoVtDGYiFfPg6nKjX5uFKnVUpIwfQA8RYaAA5I5drOQH+UPE8w+qP/ScjA1jN5HPIDoYml9JYjiEpaeSUFlpUz1qNOsQ1FJepfn4I0xCsuTUFzVP667ofcInK33ZVot0tPnzpMSYSt/1itwnseTU9JIkY2prQ3joAcBOx6tnQ=
From: Roger Pau Monne <roger.pau@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Roger Pau Monne <roger.pau@citrix.com>, Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: [PATCH v2 2/3] x86/clang: add retpoline support
Date: Wed, 16 Feb 2022 17:21:41 +0100
Message-ID: <20220216162142.15384-3-roger.pau@citrix.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220216162142.15384-1-roger.pau@citrix.com>
References: <20220216162142.15384-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO2P265CA0220.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:b::16) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 00291384-75d3-4571-d4ba-08d9f1687419
X-MS-TrafficTypeDiagnostic: SN6PR03MB4143:EE_
X-Microsoft-Antispam-PRVS: <SN6PR03MB4143CDCF381A1DBD7F93195D8F359@SN6PR03MB4143.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5797;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: lNYh/dr0P2vrPoR+Bd9L+NCodfTQb5J5TTxMBo0Briyz28YMxEe1YkJONZjZkINFnghOqlw85EUlGr6LAirxHLS1Hra7Jsbq6Th7NGmRqNK4ZdRwewTuZQ4qpxV31CuoR2jKRtRpQIkGZttIgPXr1rwjDd3xASeFjW2jxnBOi/wjOnVejrQ+fWt9aCvFmuY1qFQ9l8nGee4J9gPFDI2w8JdGzABB/5bL01ElSYQkGnoP/LSMOIqUI7h7sE+E/H8iep/cxcv7pdCFOS5R8US2LdBaXz5xffoHLMpAHHAWHq/3OCTV6DnU36v1cRap/XYccSV2xrn3jvVXALqRyeh33FDzQFt7jFo7pBaTFHlHMGd3HdgXrEVdgezR0pPRj+JXQwqCn9zT+K23yWfOfgJqXeDItjqz5P94t5UcZACcFQUeFplB1gsaCQQu2bdEzJe8it77ymOLHQB917lxTRCKRJJUu9xh+b9Yk4bGVzlOjyVlKBG2qqFf6kqMeNoX43WPfA2fUzOAG835gqMuFRHzV4qBhAAe/E/ftNJ4NknEXI1b+Y7AWjL25wqHjll4IlLpkQ4OLEJp2MJNx5jq5cqH8jLZtdsspwUP9n8xQ1oYnCSIncB1+h8C+BeLeR/ia0MGlLvhU0xM+WQ0QdMpfXhukw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6916009)(508600001)(4326008)(86362001)(1076003)(186003)(6506007)(316002)(8676002)(6512007)(66476007)(36756003)(2906002)(54906003)(5660300002)(83380400001)(6486002)(66556008)(2616005)(66946007)(26005)(6666004)(8936002)(38100700002)(82960400001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L1dwSllLNjQwSjUwdXJCNEJ1SUFFWnZ5ellSYWs5akY5RHhsOHRMd0NBaG16?=
 =?utf-8?B?OVN0Z3Q0Wlkyb2k1a1dFRlhCcnRJaEg4clhndnJ3U0FxTyt1UGtTQ1N1K25R?=
 =?utf-8?B?cm9wVzI3dUxIYWFHN1IwOWl4ejlWbVZKWDNFdkhsOEd5YlJJRXo0YjJWeEVV?=
 =?utf-8?B?U2VIRW1pd2pHVDRPWm5zTFd4L2NRVGQ3NUZpTmxHdmp2UElxNk1vMEtjYzVC?=
 =?utf-8?B?Ylg1T0dKcTRhNUFqMktzc3Jha0tJQ2JPbUhQRFNVdUtCWlpFMEJNQlY1d1ZN?=
 =?utf-8?B?WHJndmhsTWZZczFuMTd3c1pKZ2RZK2gyc1VTMDQzSnpRM3NaL29sUjY0QWpY?=
 =?utf-8?B?VDFNTWFYUUVWMzlKdGNhUitwV2tPVTVUUFZEMUttbTB3bjFsK0hTT002MmlT?=
 =?utf-8?B?elZwUldPM1FUWk16VXdqWkNDMWhCT1haa3IzMTJzazJSWmp5dEU1eUFDZ2Fy?=
 =?utf-8?B?RVNGa3JkSDZCa1lEenIxbkZxckV5cHRaRnZ0aGRWbngvRWNVaS9tUUhNWlZu?=
 =?utf-8?B?djFnRmVyYkgxY0tiZXFJUW5rRElYVWVUN0o5TnpFUVFWQkNZanpCVVg5TFNq?=
 =?utf-8?B?bUhZZUN6Tm0vN04zWXNaNzloVXdNQjQ3UTBtUVVKOVRmendDeW0zWTcyZCsw?=
 =?utf-8?B?R1duN2drMFBwQTFwS0g3U1lGTC80dytrVHZFVE5Rbi9VSGpvQWxvdWlmN2hh?=
 =?utf-8?B?N3NLMm5odTVQaFJpUkxGc2pNRlVBL0tUWTNZSjY4cDhlU1U2c1RITGhpbldj?=
 =?utf-8?B?V1kzWFZzUU5JSTg3ZUNGZi9wQm9jRDlYNlViamVjY1U4OTQrbks1eHVmbEFz?=
 =?utf-8?B?eDlTZC9OSXBlUmdLb0xCNFAwdjhEdll5T04wK0dZYkVyRnNDVXU2dktyRHc4?=
 =?utf-8?B?amN3TGhyV0g2OU9rL2VLZlFvc3pOM0NDaXJkVDRPRko1RXdoNk5QN2NLRC8v?=
 =?utf-8?B?b3k5UmFRWExvQ09EWEQyYzlFcFBFZEkxU1dQU0VOOGZlV285aDFDc2tRNUlX?=
 =?utf-8?B?M05FUmVIcjY4eUx3djRaOE01S25tanc0UnJoVG1hQkl5dlQyajQvQUdFcFhO?=
 =?utf-8?B?WWVLTlFOQ2RUR0srME9mT2tyRkZxdXpudHhaVnpFMzdCQTZQVWdDVlBwWERK?=
 =?utf-8?B?THRZOW51Q1dweVlYL3hiM05odmdRRmRNSndLdGd5OWdLcHBQYUx4bk12dk9U?=
 =?utf-8?B?YWJMS1NreHIwR05TcnJSQ2pmaWk2bU5GZUxNTjBRbmZ6aGVoYW5VbzBvNE5D?=
 =?utf-8?B?MXJSdjhrbXR4bFdwbG1xNjZWSWJRYXRIeTBkaXlaZXUwV3h2bjJYbElPYUZu?=
 =?utf-8?B?SkhEcTBGZTR6UWVvTUEyVUtTWGllbXBHc2RnRnVsWm5HNHBiR1QvdkZZT2lE?=
 =?utf-8?B?OE9taGh5V1dHT09aTXIrK0g4b0NmU21PYUo3WHF1eU53c2F4NVY2UXNFM2FV?=
 =?utf-8?B?MGl1eVpxdlEvRitWak9KVzZaYmgyRllCK0sxV1RxWlllR2VTc0piQVU3ZzdF?=
 =?utf-8?B?S1U5d3g2MTJKL3dMeUdWUm4xSzJ2bzh4dldXM2VUZHJTemhJY2Urd3VHSUFB?=
 =?utf-8?B?bVFkTWZtS3RuV0owTE5Pb0t1bWZKMHpNdWlCaDdTdWtxd1E4SEtMM29qQlVi?=
 =?utf-8?B?NlJWS0YyVHZCRThHem9aUW9xbnZnNkdkbmxhTVAxT0dJREhrdXUyNVhSR0Nw?=
 =?utf-8?B?ckZ4MVA3WmwxWmFGMWo4WDdEeHhWNDdRSW5YZEF2WERKSEFUV2tLQ1l3OW8w?=
 =?utf-8?B?YWtxZFYvNm9RTS9Cbzk1cWtObUhZa3BWZlBsZWJIOG9nOTN3RkZTelQvNlZx?=
 =?utf-8?B?dm1hWUpzb01idURreUNjRXo5TTZhM284R3lLVzVocHczekRheXpBQ09HeGwr?=
 =?utf-8?B?OXVQSURseWZvZjFJQ2todHo3bXFzWlA2RXVyV0JFdlRZNDBZSEowZVFlRFRk?=
 =?utf-8?B?TEl3TDJZQ2RZQWJjaW1MMGhNWjBEK1Y1MWcxZUF5RGdlVmh3ZElQblZubHZD?=
 =?utf-8?B?alRYR05oRVV3SjJ1TkxHbVR2ZWIyUmZnQ3pZZ0ptQW1HeW5SS0ZlSHhXSGFj?=
 =?utf-8?B?TThSQ3kvYXRWZlRGaGJOWmlqOFRTdjRWTzliUGk5SjFMVGlsM29kZGFtOExp?=
 =?utf-8?B?NllaM2Z3WU1oUmhRbDFXM0xHODZuN2FBZGRTVkgzOEpoN2JTcFJrTHNwYmEx?=
 =?utf-8?Q?roT3Psx1YWUlIYBt2PLk8yw=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 00291384-75d3-4571-d4ba-08d9f1687419
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2022 16:21:57.8878
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8hxIRmJ60n3eWgB12EXULdL9jqvJEI+yOE5c2uS1nESGqNK9fGGM1477MdlnZlsr2pWUYoPSEzyH2131NNKecg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR03MB4143
X-OriginatorOrg: citrix.com

Detect whether the compiler supports clang retpoline option and enable
by default if available, just like it's done for gcc.

Note clang already disables jump tables when retpoline is enabled, so
there's no need to also pass the fno-jump-tables parameter. Also clang
already passes the return address on a register always on amd64, so
there's no need for any equivalent mindirect-branch-register
parameter.

Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
---
 xen/arch/x86/Kconfig | 5 ++++-
 xen/arch/x86/arch.mk | 3 +++
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig
index 219ef9791d..2fa456292b 100644
--- a/xen/arch/x86/Kconfig
+++ b/xen/arch/x86/Kconfig
@@ -35,9 +35,12 @@ config ARCH_DEFCONFIG
 config GCC_INDIRECT_THUNK
 	def_bool $(cc-option,-mindirect-branch-register)
 
+config CLANG_INDIRECT_THUNK
+	def_bool $(cc-option,-mretpoline-external-thunk)
+
 config INDIRECT_THUNK
 	def_bool y
-	depends on GCC_INDIRECT_THUNK
+	depends on GCC_INDIRECT_THUNK || CLANG_INDIRECT_THUNK
 
 config HAS_AS_CET_SS
 	# binutils >= 2.29 or LLVM >= 6
diff --git a/xen/arch/x86/arch.mk b/xen/arch/x86/arch.mk
index 2da4bdb1ed..f2aa2a515f 100644
--- a/xen/arch/x86/arch.mk
+++ b/xen/arch/x86/arch.mk
@@ -47,6 +47,9 @@ CFLAGS-$(CONFIG_GCC_INDIRECT_THUNK) += -mindirect-branch=thunk-extern
 CFLAGS-$(CONFIG_GCC_INDIRECT_THUNK) += -mindirect-branch-register
 CFLAGS-$(CONFIG_GCC_INDIRECT_THUNK) += -fno-jump-tables
 
+# Enable clang retpoline support if available.
+CFLAGS-$(CONFIG_CLANG_INDIRECT_THUNK) += -mretpoline-external-thunk
+
 # If supported by the compiler, reduce stack alignment to 8 bytes. But allow
 # this to be overridden elsewhere.
 $(call cc-option-add,CFLAGS_stack_boundary,CC,-mpreferred-stack-boundary=3)
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Wed Feb 16 16:22:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 16:22:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274292.469733 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKN4G-0004xu-AR; Wed, 16 Feb 2022 16:22:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274292.469733; Wed, 16 Feb 2022 16:22:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKN4G-0004xj-5Z; Wed, 16 Feb 2022 16:22:12 +0000
Received: by outflank-mailman (input) for mailman id 274292;
 Wed, 16 Feb 2022 16:22:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=oYE0=S7=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nKN4E-0004NT-Ex
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 16:22:10 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 95981576-8f44-11ec-b215-9bbe72dcb22c;
 Wed, 16 Feb 2022 17:22:09 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 95981576-8f44-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645028529;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:content-transfer-encoding:mime-version;
  bh=MXv+Whc/VwisieV7Q/pmLCawQze7jVoZkFb0ogwdHvQ=;
  b=TLF29kI1+uhUi7sGnegG9LGm2317sSypZATFPZt6wQgs2RSaStukkT08
   m86daPmze/K4IEYYacs99YYCA9/XFg2FdeSTmpWRETuqWeKmqJcYsyi++
   pB6zt0XhEB453yRu/yFuHksMn5yd5zVkBBvClD3NYv3qpUITsvjK6DQB/
   I=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: 1QVe5MJQGRHXQHb1UoGG4501ENCQntVhSev1Rl3Z5v3CPh9ALa474VjML37iCPqMPUPniDXL2V
 Pg4RNwSdGJfpFOQug4H3tkRrUvmsdZKlebCNl1v7XvHNtSDyT3STEgoQxX6mwFYv7xGrmn66aT
 uPLhaPwJEHkdQ8VZEH2Kqa/9vnFbNFN3uvy+PcFZ3avCdfRQIrozCgIUpMecMKIEusgk53jgCl
 lQPegJpT/t2aMST/yzAw5ERSMznTStEkpzwUuoHgEAkb1R+iLs2XyvSO8iMvrQN5UF/13AfHcF
 ZP8Ek/6mxFSocrlcJ/KA8zY9
X-SBRS: 5.1
X-MesageID: 64355270
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:I9LQVqsSAloxerXofd0JUReoIufnVNJZMUV32f8akzHdYApBsoF/q
 tZmKWCBaKneNGH0fIwgb9jkphwOvMTczINiGgM//Ho9EHsU+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZQP0VOZigHtIQMsadUsxKbVIiGHdJZS5LwbZj2NYy2IbhWWthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 Nplj4CtFyw5M4f3scc/fBZYCzB9PKhL9+qSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DJoQQt2sm1TjEJf0nXYrCU+PB4towMDIY2JwVQKuEO
 JJxhTxHcQrcOBNUBHcsLrEhzc6UvGvFcy9TpwfAzUYwyzeKl1EguFT3C/LXZ9iLSMN9jkue4
 GXc8AzRGQoGPdaSzT6E9HOEheLVmy7/HoUIG9WQ6fpCkFCVgGsJB3U+RVa95PW0lEO6c9ZeM
 FAPvDojq7Ao806mRcW7WAe3yFaGtBMBX9tbE8Uh9RqAjKHT5m6k6nMsF2AbLoZ87YlvGGJsh
 gThc87V6SJHiqGIF1mN+52vhBCQFicVNX4BZCoJQl5QizX8m70bghXKR9dlNae6iNzpBD39q
 wy3QDgCa6Y71pBSifjilbzTq3f1/8WSEFZpjunCdj/9tmtEiJiZi5tEALQxxdJJN86nQ1aIp
 xDocODOvblVXflheMFgKdjh/Y1FBd7YaFUwYnY1RvHNEghBHVb5IOi8BxkkeS9U3j4sI2OBX
 aMqkVo5CGVvFHWrd7RrRIm6Ft4ny6Ptffy8CKyIP4cXOMkgJVbdlM2LWaJ29zqw+KTLufthU
 ap3jO72VSpKYUiZ5GbeqxghPU8DmXllmDK7qWHTxBW7y7uODEN5up9eWGZimtsRtfveyC2Mq
 o43H5LTl313Db2vCgGKoNV7BQ1bchAG6WXe9pU/mhireVE9RgnMypb5nNscRmCSt/4Fxr2Tr
 y7nAxIwJZiWrSSvFDhmo0tLMdvHdZ1+sWg6LWorO1Op0GIkeoGh8OEUcJ5fQFXt3LYLISdcQ
 6ZXdsOeLO5ITzibqT0RYYOk9N5pdQixhBLINC2gOWBtc5llTg3P29nlYgqwq3VeUnvp7ZMz8
 ++6ywfWYZsfXAA+XszYX+2ikgGqtn8HleMsA0aReotPeF/h+ZRBIjDqiqNlONkFLBjOn2PI1
 wufDRoCi/PKpos5rIvAiaye9t/7GOpiBEtKWWLc6O/uZyXd+2Oix65GUfqJIm+BBD+lpv36a
 LwMnf/mMfABkFJbiKZGEu5mnfAk+t/ih75G1QA4Tn/FWEumV+F7KX6c0MgR6qAUnu1FuRG7U
 16k88VBPenbI9vsFVMcKVZ3bumH0v1IyDDe4e5sfRf/7S5zurGGTV9TL1+HjykEdOl5N4Ysw
 OEAvs8K6lPg1kp2Y4je1i0EpX6RKnEgUrk8ssBICYDmvQMn11VebMGOESTx+pyON41BP0RCz
 uV4X0Yea2CwHnb/Tkc=
IronPort-HdrOrdr: A9a23:RE/AFa87zDjwDRQYKvluk+DkI+orL9Y04lQ7vn2ZLiYlFvBw9v
 re+cjzuiWE6wr5NEtApTniAse9qBHnhPlICOAqVN/JMTUO0FHYSr2KhrGSoQEIdRefygd179
 YYT0AgY+eaMbEBt6nHCaODYq4dKaK8nJyVuQ==
X-IronPort-AV: E=Sophos;i="5.88,374,1635220800"; 
   d="scan'208";a="64355270"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=FyVJ3McVpA1Otk5PIgKZROpbyYzT8PDgRlyw3Mx/yNjv3/oFTqhzIF2HdDMXB0jRdsBWpb4NxZCVicFvLM4CCKmf9ji9RLLVk38lxiFwcqQHSG5C/pK3xOZOXXEPwrAw3N4Ld5lt+UN5unsog3sXhCIR8i3ULgSR80xs2bIZ7h65lO20o2lEwPLSpGvBqnb0KYIu3yt1WKcoMJ77hZjsUxr9dJN29F7Awu6zrkoI2XvaoFardummhSWPic6ymPQbtZd6+4i1OFae6m2wVV5fNTowBl31uT0Cog46W92BQv9KVLuMoPHyqy3LO21Mzwe8D/mfb86zNHelCy65eXBoLA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=/baYjNnC5E1KhoJ7tzV137/mk2WyOVplKJZMdD4Ofn8=;
 b=e+LT2WKVuSIousfE1ov996QJ9K88QXCR2LAE+fWWt3TveRBwOZV4FC2x6/WedIk71aL98kwJH5eS9tBN8VpvXilTcIi7sT/n90PzyapRxCbiZ6A5ZHh+i0qNYXy/n7uQJiT3DfATQMfV9ftZxbvjuWLQv6jUgic5Psziank0SatbaUEc0qZmX56XnVQ9OyuWdQ1SNIagPzRyhkoLw+cJG9mdQQ8TcjEC5fDCxFTNXjqLgzO+w2j29ou4nodc2NRDd45KvKMuP+gkvwyFYhOWvF8wX6ydBgeuor33JmD+vdbPI1HvQfVWdldzZX+y4YbKwfP3me97/KRvlJ+n62/omg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=/baYjNnC5E1KhoJ7tzV137/mk2WyOVplKJZMdD4Ofn8=;
 b=tGtOkstw7FgfIV2r8RIHhllWuwRK9jcIC27dCnxM1hz5UcV157WUOMNA8ZjmSaExc0bKkkBDIl23kG8RFKawruHBjQUI3XvNIAm5+cAP4yL2JBubtgtkbcsnk9R+GuygtAd1SZNsfXdodTp7R+2uCrUR9fM/JjmJs7rorUi+9BI=
From: Roger Pau Monne <roger.pau@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Roger Pau Monne <roger.pau@citrix.com>, Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>, George
 Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>, Stefano
 Stabellini <sstabellini@kernel.org>
Subject: [PATCH v2 3/3] x86/Kconfig: introduce option to select retpoline usage
Date: Wed, 16 Feb 2022 17:21:42 +0100
Message-ID: <20220216162142.15384-4-roger.pau@citrix.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220216162142.15384-1-roger.pau@citrix.com>
References: <20220216162142.15384-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO2P265CA0012.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:62::24) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: cbeb1994-8bd5-47e2-7118-08d9f1687768
X-MS-TrafficTypeDiagnostic: SN6PR03MB4143:EE_
X-Microsoft-Antispam-PRVS: <SN6PR03MB41432FD6B01CF34E3B6B5E028F359@SN6PR03MB4143.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3383;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: RCxLCB2bSjk4POxcGbrUpVasm/oMsEw/EwVLSoah1LaOCqFsqe1PUKQwUnsXUUQS1QtIYnlIrM256zoLYPZM2KVj/C4H4YMHN8nqBYUR2ZjedpIKiUCefnuTCqvEeAHTZtqO+ssWX5Fgk3jD5t8TH8SuO0YiTUhD4gR3auINK8cZfM7+Q2lpBImEaUoGrc+RBPeDi/riEPcq5ozRGGKaJl6gOs5BUNZfhUvjXD6+ZMDelBl9nLVigq97Otn9cpY+NFWitmScZrysuxosWg/TvVsJCTrgVvuJnf7IMrdsTk8Ouc543Kd5liRLa/bPOH9XAFvXN8XpTyiyXreEwbN1KaiCJrvaR9Sm8zkhGob8UzxwK31SLnRojPA1ITiyp9DpVGMVL/9Lx1mhHSm9GHO2HtcL50BWvxqyFAh7Ew/phabUXGvUCJExmHSBKR8/JZghJ4JdVBjqOvktusr1zWH4rGOloIuvjFIpNojNhqNYwLbJ7LkYo3ZmmGEgrWx81rqWeCXYHjWwoxZSu7h/zKTLhq7xMkcpBZ4Fu+HzPSMAceyrxL2Tb6Hya9JUJlIISNavfD1MWQyzJ1byQhC7MtcJte4YmpTruzR8zq1QjYN5oJhl1lxtSGzLRBN9FiAL5a7n8efxwhT2KfZaBQ6IzFwp6A==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6916009)(508600001)(4326008)(86362001)(1076003)(186003)(6506007)(316002)(8676002)(6512007)(66476007)(36756003)(2906002)(54906003)(5660300002)(83380400001)(6486002)(66556008)(2616005)(66946007)(26005)(6666004)(8936002)(38100700002)(82960400001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TXRXZENJQ1ZOQk9NZW0yengxbHBFblJpWFNFc01SaGVLQzl2SnZSVXdEdlRn?=
 =?utf-8?B?YTdMdTgrWStROFhCNnQzWjR6SHdXWmxxWEdCUjA0OGlDZUZZVHpKUlhTU0ow?=
 =?utf-8?B?MXZBSDVMOGFXdmxvNlFUbUxvbnp2VDBXZXJWWE56ZExSU2NCZVM0K1ROMmJ2?=
 =?utf-8?B?SENtL0cwaWFnNmhMQTgxdEIwWk96ZFRQbVM1MnZoNmRsWFdFSHpqTVQrNm1H?=
 =?utf-8?B?R3ZpbXloeUlQa094dlN6S0VTWmoxTUhjc0JkM2l6MENlRHFwbUtUSnRLSEhN?=
 =?utf-8?B?RTh6Tk5NcWtMNXR1NWdLT1pYdnRiQ3BEZEZPKytpUTQ0M1VaU1BaQ0c2WDBG?=
 =?utf-8?B?dnlmdERFT0k0ZGxvei8zblh6Zmt4NFczQVd0UHBaNXFLQnlQSTdJSS9tQ05N?=
 =?utf-8?B?bUZoLzZsT0h6R01QS2lnWlhuamFNQnh6eERFS1BaUFRKZ01wWE9GUVNIR0k5?=
 =?utf-8?B?Vk0xR2NXUnM5MVZ2N2VhVXl0TXJoM2FUVmQ0bENMcmw2Z3BOWlhYbTRSMXo0?=
 =?utf-8?B?akwwanB5VHhtWmpmR1BPY3V2dmhJNFFnU3FqWHhYNUt1VjJZdjl6RXVIQkg3?=
 =?utf-8?B?NXFwWXY1SyttK1FQUWdxOXpJZDE0QThsVWdOOFBlZHVtUXp3MlNFUlY1cHB2?=
 =?utf-8?B?cTRWUVZ1ZVgyVmxsVnp0cUJPUlFoWC9pcFczSllGMGJOd2ZFL25EYUpxYmhw?=
 =?utf-8?B?ek5BVWNmMFJ2aXRRZzl1OS90U2ZWN3MwV2pzTWVJUFVDbndZSFF4RzRZbGxW?=
 =?utf-8?B?dlQvMTJGSlg2MGtzQXhCdUh2OFV5eG52OUI5WkFnb1p5eVA2ak1OR0QzRXNp?=
 =?utf-8?B?bkh2Vng5MnFKbG5PYktNS29HVVBmT0pWaDkzQ2NQZkptVGI4b0VKWDdGRENp?=
 =?utf-8?B?SUhLZndaNnZGUnJxTnMvNWkxUHhjMzhQSFlvT0ExcWhUcEFuUzlJc2hacUZ5?=
 =?utf-8?B?ektlenN1cG16VStxWUFxSWs4dC8wRnJ5MTQxempzWnFLUHJDamVBOVd2NnMw?=
 =?utf-8?B?ajFWYWRReEpVdW5pcUplMTVud0o0QlVlcUdQV0JjK2E2b3dQV3h2Mmx2UG1W?=
 =?utf-8?B?eFgvaTZjaEtpa0o1MmhnaVdxaENZVXBFZkNvK1hhYVcxbXA4V2IyT3R2cjlp?=
 =?utf-8?B?YVBHU0Y1bmVTTFdjdGVrZVdkQy94dHdzMkVwT0V0Q0JIUk5MTVJackl5bXBB?=
 =?utf-8?B?SXF2VkJrUEtBaEF6TlFKL3dSU0hOMkZ3NU8vYlBORnJKclBHTS9DYUxyRVZU?=
 =?utf-8?B?VUVMUSs2TUU1Nnh3WFVqKzZWZkdkR25PWFd2V3NEQjdSWnpnbE5LS2drMGlk?=
 =?utf-8?B?MUNncG52ang1djNtOTlUcGZZRnl6cnM2Yzh6bDBha1hXNlZMdGRvV29mcnN6?=
 =?utf-8?B?RVJVeHVlVUtDS0xSV0RBeXhudmo1YjVyUlVqRWkydHhISkNPb0hPbUtuYWFB?=
 =?utf-8?B?K1hJeHBNYlN0eG50N1VOdzBWM0s1cnNnQTk5eWhHWmorOUl2WStIRVVJMTd2?=
 =?utf-8?B?Q0dxWUtidHhraTlEa25FUDFGMGFPMDdobW1jYW8xLzRWeTduRC9BTk1nTWYx?=
 =?utf-8?B?cHA2WlUyVlFPbUF2WUUxK21MTUd0TUZkU09NQU11cDRKekJWVUw2d1hiMExI?=
 =?utf-8?B?eWthVkRIaVpFaFhZTnZWbkJCdGZsbWV6eGJPMzFtSkdjbG85akZlQlNQa3lY?=
 =?utf-8?B?cndtSmpyeUhZaDFUOStpQXFvZmhWUzA5UkpvNmw3NURlQXhuTkQ0NE0zWkc2?=
 =?utf-8?B?aHE1eElUZmJGWkRpd2NiRExOL2gvNDVwdk54bUhCTHJpVWVBb1p0S1ZRRGp2?=
 =?utf-8?B?QkNNRVlaOEZyN3ZIRDU4OEtSUzAxQmtFaHM0aFJOVFNRdE5ISTRQTU4rY0or?=
 =?utf-8?B?OTk2eEVpQm1ac3liL2xtK25aWFEwTi9rMUZva2t3bEd5UW1PTEFYODJEbm5P?=
 =?utf-8?B?Y1NNZmNEQzlyQ3FGMitvZUprQjVBKyt2bWRlWjFBaC84Z3RiS1lXcDRpeXA5?=
 =?utf-8?B?YkNJYWpOQVRzRkZ2dlN6eklTQmoxbkY2RTQ0bklCUUsrQlBoT2xHNndjclg4?=
 =?utf-8?B?MWthem1IRDBXZ0lydElzWW9nYWh4b0t3VHpxbVY0anFJdFJiSGk3Y0NPNlFJ?=
 =?utf-8?B?d2ZFSHlray9manovUC93S1BJbWMyQkV4eWdxNHdLYTlDTGMybzByM0FNbUt3?=
 =?utf-8?Q?iMx6PX1CjuYnsHNPQ798Qno=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: cbeb1994-8bd5-47e2-7118-08d9f1687768
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2022 16:22:03.2955
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Jyv6/WKnWvnLgY+hwpW8ntiV2XgyxlIrNSvV3RJrrvtjc7f+GprbjqHMjRg/dWs5O7x0bIsdJ3VNah57Pb+d6g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR03MB4143
X-OriginatorOrg: citrix.com

Add a new Kconfig option under the "Speculative hardening" section
that allows selecting whether to enable retpoline. This depends on the
underlying compiler having retpoline support.

Requested-by: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Changes since v1:
 - Fix description of option to use indirect branches instead of
   indirect calls.
---
 xen/arch/x86/Kconfig |  4 ----
 xen/arch/x86/arch.mk |  2 ++
 xen/common/Kconfig   | 16 ++++++++++++++++
 3 files changed, 18 insertions(+), 4 deletions(-)

diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig
index 2fa456292b..7c73802adc 100644
--- a/xen/arch/x86/Kconfig
+++ b/xen/arch/x86/Kconfig
@@ -38,10 +38,6 @@ config GCC_INDIRECT_THUNK
 config CLANG_INDIRECT_THUNK
 	def_bool $(cc-option,-mretpoline-external-thunk)
 
-config INDIRECT_THUNK
-	def_bool y
-	depends on GCC_INDIRECT_THUNK || CLANG_INDIRECT_THUNK
-
 config HAS_AS_CET_SS
 	# binutils >= 2.29 or LLVM >= 6
 	def_bool $(as-instr,wrssq %rax$(comma)0;setssbsy)
diff --git a/xen/arch/x86/arch.mk b/xen/arch/x86/arch.mk
index f2aa2a515f..0597e714f9 100644
--- a/xen/arch/x86/arch.mk
+++ b/xen/arch/x86/arch.mk
@@ -42,6 +42,7 @@ CFLAGS += -mno-red-zone -fpic
 # SSE setup for variadic function calls.
 CFLAGS += -mno-sse $(call cc-option,$(CC),-mskip-rax-setup)
 
+ifeq ($(CONFIG_INDIRECT_THUNK),y)
 # Compile with gcc thunk-extern, indirect-branch-register if available.
 CFLAGS-$(CONFIG_GCC_INDIRECT_THUNK) += -mindirect-branch=thunk-extern
 CFLAGS-$(CONFIG_GCC_INDIRECT_THUNK) += -mindirect-branch-register
@@ -49,6 +50,7 @@ CFLAGS-$(CONFIG_GCC_INDIRECT_THUNK) += -fno-jump-tables
 
 # Enable clang retpoline support if available.
 CFLAGS-$(CONFIG_CLANG_INDIRECT_THUNK) += -mretpoline-external-thunk
+endif
 
 # If supported by the compiler, reduce stack alignment to 8 bytes. But allow
 # this to be overridden elsewhere.
diff --git a/xen/common/Kconfig b/xen/common/Kconfig
index db687b1785..e688e45513 100644
--- a/xen/common/Kconfig
+++ b/xen/common/Kconfig
@@ -146,6 +146,22 @@ config SPECULATIVE_HARDEN_GUEST_ACCESS
 
 	  If unsure, say Y.
 
+config INDIRECT_THUNK
+	bool "Speculative Branch Target Injection Protection"
+	depends on X86 && (GCC_INDIRECT_THUNK || CLANG_INDIRECT_THUNK)
+	default y
+	help
+	  Contemporary processors may use speculative execution as a
+	  performance optimisation, but this can potentially be abused by an
+	  attacker to leak data via speculative sidechannels.
+
+	  One source of data leakage is via branch target injection.
+
+	  When enabled, indirect branches are implemented using a new construct
+	  called "retpoline" that prevents speculation.
+
+	  If unsure, say Y.
+
 endmenu
 
 config HYPFS
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Wed Feb 16 16:22:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 16:22:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274290.469710 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKN47-0004Nl-LR; Wed, 16 Feb 2022 16:22:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274290.469710; Wed, 16 Feb 2022 16:22:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKN47-0004Ne-IS; Wed, 16 Feb 2022 16:22:03 +0000
Received: by outflank-mailman (input) for mailman id 274290;
 Wed, 16 Feb 2022 16:22:02 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=oYE0=S7=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nKN46-0004NT-0R
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 16:22:02 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8f37ed2b-8f44-11ec-b215-9bbe72dcb22c;
 Wed, 16 Feb 2022 17:21:58 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8f37ed2b-8f44-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645028518;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:content-transfer-encoding:mime-version;
  bh=D1BziOChSKGR/TxZIuNhqH1cTbshReBw7WPjgUO2h1A=;
  b=GHlc2fplMwK/4CCVdHmX0ftM+s4p7Q9vKxk+d9e1nK5NTDWvsX2hG5iQ
   graFXoWm2yW+YnmrUQwOcxmogTYRW5l7zWvxKawKSUceqffeaB7FnPnI3
   7vUSJfZ7gndlz+w2zhzgiLiDg1zuPR7imIz7CFs57Duq7ESHpiNCVzj2C
   Y=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: WiLMvEK0EY48zZ8lOhwRekVUdgJK6muWjPAq7DaL4ZzFsMbnre6QQ+iIQldxNOkylr4Pd9IiJa
 SxvWHm+8dzZWSDnHVezpDakJA8lMlm/BJYWfT+rdUewA+tgeO8djeAYcQPxGJlGoIvHQpev7LT
 GrAxohNPATnF2Ml4tYw52pVS5VJ1V9b6cDm31k1f+AMa31vNHmWiKE1IYpnjR+ldyjIqhG8tUg
 uTUAYwbXQsjStQuoSvPOfmWVRvk0WXSuvSZVlE0xWRHgVaVcJVT7RPs9FCnFkLdabVmXfH6ddG
 Mw0uVOyrmDVmDgbSpng5la4f
X-SBRS: 5.1
X-MesageID: 64256043
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Zw7+pKqd/runSbpkFfPwlx1XBGheBmLEYhIvgKrLsJaIsI4StFCzt
 garIBmPOf7cZ2L1L95yaoi2oRhS6sXVztJqHAI/+yg8RXhApJuZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlZT4vE2xbuKU5NTsY0idfic5Dndx4f5fs7Rh2NQw24HnW1nlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCnYO7ci5qN6jSouc6dTthKg1HIvVG6ZaSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFJkYtXx6iynQEN4tQIzZQrWM7thdtNs1rp4SR6uAP
 5ZCAdZpRD/lTTRrEG1GM8wRuOOXuynGVSIfsHvA8MLb5ECMlVcsgdABKuH9ZdiiVchT2EGCq
 Qru/W70HxUbP9y30iee/zSngeqntTP2XsceGaO18tZugUaP3SoDBRsOT1y5rPKlzEmkVLpix
 1c8o3R06/JorQryE4e7D0bQTGO4UgA0RNFrOq4z7R+3yY3ywT+gKlEbFj5QQYlz3CMpfgAC2
 liMltLvIDVgtryJVH6QnoupQSOO1Ts9djFbO3JdJecRy5y6+dxo0EqTJjp2OPPt1rXI9SfML
 ydmRcTUr5EaloY12qqy5jgraBr898GSHmbZCug6N19JDz+Vhqb4P+RECnCBtJ6sybp1qHHb4
 RDofODEsYgz4WmlznDlfQn0NOjBCwy5GDPdm0VzOJIq6i6g/XWuFagJvm0idRowaJdVKGazC
 KM2he+3zMUOVJdNRfUpC79d9uxwlfSwfTgbfqy8giVyjmhZK1bcoXAGib+41GHxikk8+ZzTy
 r/AGftA+U0yUPw9pBLvHr91+eZymkgWmDOCLbimnk/P+efPOxaopUItbQLmghYRt/jf/m04M
 r93aqO39vmoeLeuMnOMoNFJdA1iwLpSLcmelvG7v9Wre2JOMGogF+XQ0fUmfYlklL5SjeDG4
 je2XUow9bY1rSSvxdyiZi8xZbXxc4x4qH5nbyUgMUzxgyooYJq17bdZfJwyJOF1+OtmxP9yb
 v8EZ8TfXagfFmWZo2wQPcvnsYhvVBW3ngbSbSCrVycyIsx7TAvT9966Iga2rHsSDjC6vNcVq
 qG70l+JWoIKQglvVZ6EaP+mw16rk2IaneZ+AxnBLtVJIR2++4l2MS3hyPQwJphUexnEwzKb0
 SeQAAsZ+raR89NkroGRiPnd/YmzEuZ4Ek5LJEXh7O67ZXvA426u4Y5cS+LULzrTY3z5pfe5b
 uJPwvCibPBexARWs5BxGqpAxL4l44e9vKdTywlpESmZb1mvDb88cHCK0dMW6/9Iz75d/wC3R
 liO6p9RPrDQYJHpF1sYJQwEaOWf1K5LxmmOvKpteEiqtjVq+LenUFlJO0jegSNQG7J5LYc5z
 Lpzo8UR8QG+1kInP9vuYvq4LIhQwqjsi5kai6w=
IronPort-HdrOrdr: A9a23:kjivu6jdaK+VyqZhLlvZn9Td7XBQXuYji2hC6mlwRA09TyX+rb
 HLoB17726QtN9/YgBCpTntAsi9qBDnm6Kdg7NhWotKNTOO0AHEEGgL1/qF/9SKIVydygcy78
 ddmoFFeaTN5QcQt63HCXODfOrIauP3iJxA/t2z80tQ
X-IronPort-AV: E=Sophos;i="5.88,374,1635220800"; 
   d="scan'208";a="64256043"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=e0liJgRmy/Z+yST0MTLAocwWaKTvsORwn5U2ywYp01jQKxJGmUzOyCLJYWbdIXKlhLIcPa6n6VxnvsNpctX1IlOtrg2CNZnP1vvg1He2Hqr+ejY73mzqM5l25A03qJ00C2Zn6tXG6pkABkwOPpjkTDpJPkp+nHPWVrbeufAoWlytKe19wT37PCOfCSrEY7WA8o/YH+NDVJ+FR0BywlJQr3L/omPTDwfhKOyLox/4260slcMwFA//Cc4XEg0g12mYBasXLySquUeWDogLCN7a8SBdj9SGPWJ03YOsawPwwVDBoGMOAPYxKmqxkdvFsZTSKlQT2jPbicVarESexHzQjA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=7/LvDOtIy8kR/1dSVBF5RKlkbq0t2dXqF+GqtyJfVrM=;
 b=hGKQoDz8tgWwGgWKqRlazu4m9KkfUCTdVicjxrMz0yg4iNlMr3xiJ/B46+69DfPVfPjivfb09s1PAjOdwEIHFKSwQ8V3sgIiQELhZMUaE5C6MAoSw9Ibsz/P19GoC1hmFR5MKyXsplvhjl68kBQqhFEGr/9rsVjBcmh91QQZjhh5oplRXGDVLBYqAQ/ctrMa9QbvQNWn1/NLIDAdeOZnai6aGfDoFIdPHC9ogZcmVSjSgVWVZL9KejXMLc13e2FXMmhdT/m5mt/RXuhsqaviMYRP3v06OWXxbiohF1beptZqn3di5BnTQp/c5mXlhYZcjJIqNkoi0h7xuICpfGr1sw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=7/LvDOtIy8kR/1dSVBF5RKlkbq0t2dXqF+GqtyJfVrM=;
 b=ELR1Fqh7S7ucMWx8sFYYUC/yIL+FdpRYfWFD/AITL+DY45Ru4Jp95czDdmAt4PVNWyoHjsFoKrfrbCfJO+fFdSZJVJCvYsbh5eptdCHcau3txgYUyfI2jSIPraAMWdjBTkjxVpaFZevV1vCrElQaZVsaee72ciu4BudjHt7dZfU=
From: Roger Pau Monne <roger.pau@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Roger Pau Monne <roger.pau@citrix.com>, Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: [PATCH v2 1/3] x86/retpoline: rename retpoline Kconfig check to include GCC prefix
Date: Wed, 16 Feb 2022 17:21:40 +0100
Message-ID: <20220216162142.15384-2-roger.pau@citrix.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220216162142.15384-1-roger.pau@citrix.com>
References: <20220216162142.15384-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO4P123CA0042.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:152::11) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c8912618-61c7-414b-3a33-08d9f1687155
X-MS-TrafficTypeDiagnostic: SN6PR03MB4143:EE_
X-Microsoft-Antispam-PRVS: <SN6PR03MB4143D9C0B976DFE78AD1E4B58F359@SN6PR03MB4143.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6108;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: O1/5QDIIdnrp3/a1umCzagELeemVooAbiIgtigd0HmCk8P8jecUwilbEQVWrL6kkZ02ENzYT3+Seic+GpDqwp05ZXbr4xbJM97RoWNgVDFOtuunQfDVAsUVFNlmhV2rsebnvuSsHxagPcOuwq2BJUEKzsyc+mQ8KsETthDmg+2kHOF5FnydI/0RRQGaz4H6Cu22FEQTgFWEUeevAyY094Eqn+5ewpO5pWE5mxBnxE7ExSaTMCXVVppOxJNuoiz0QcmKenDsalO6ppKP5Y/agnOV1rCM/DriZ4fl+kYMbGWfrOyPNcVOIIltV9GpjjlmlxhlTXdIXgT0WHTOoaSvXUFIPG8ORCyJ6gkWeImtmlVeUicYa685GHxen+vZkCow1DjVfec+UjLmzXOqaI8uNmdFiWH2Q2r0a2SlC+oPZgZEgDO3i7UjKXBOBAWAl6dPg++uQrXAM9yfzS0dIyczMveUoEIVworHr6DTVSb4v63cJWVSOyyP3DASja6N1w6F1GTLn+T9Vz+p2TVX6BsLbXpmxt6FdMFYN8Q47kR5b6T9L0z+h/0wzficwYRwfgs34NcxCczOrgx//cI75WqPcoW2yHUK/QaeyElY4a7ZFDyQdd0NJnergsovF2ClJs+bKRckdoN5xMOCYrVxoTnWt5A==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6916009)(508600001)(4326008)(86362001)(1076003)(186003)(6506007)(316002)(8676002)(6512007)(66476007)(36756003)(2906002)(54906003)(5660300002)(83380400001)(6486002)(66556008)(2616005)(66946007)(26005)(6666004)(8936002)(38100700002)(82960400001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dXY2RkJ5VWRtQnFoamRna1hyTmpYQ3RYZW5CTlgwSzBmVWpnakEzVFd4bmEy?=
 =?utf-8?B?dGxzdXIweUVFY0lTV3pzaWxYU25ZeGYwSFRDOUVMQVhES0FKbGM2OFFxMmd5?=
 =?utf-8?B?Vi83TlZMVEN3T29SNEMxWWlscVJFRU80YjJ4K2lweG5IWks1T29aa0tKcG1k?=
 =?utf-8?B?cEVSWjFKQXZlbE9JV3A4MVU2MzBZRThCbnp6Ri9RY1l4cjU2WWg0ODNyQWUx?=
 =?utf-8?B?dHc3QUZKNGhtcmIxaG1vZFBtQVRtS0NQVzYxQlk1a29rOWpuSnRwWVBSTEli?=
 =?utf-8?B?R2FvQ0xRR1plZ1dROVhUNEFSanJKVU1IQS9jWXFmbitMM1R3UERpTittME1Z?=
 =?utf-8?B?eHRDdU5GbTB2bmcvblByM2d5emU0eGV2bGd5UjExYlV3ZExTd0R5SXAvd2pO?=
 =?utf-8?B?NUlndVdZV3pJYWl4dmptNXAvcWlOeEtzb1pvSjlLYmFqSGRmcXRMbHRXcEZr?=
 =?utf-8?B?NzZzbEhOK1M5dXJJRTNSWmg1VUhWOEk1NnIyMUtpSmxvMHhkd3IxNTdGYjN2?=
 =?utf-8?B?bFRpVFI2QW1DVkdLZ2tCUFJ3NGdTektKeFYwUE84MVYxcGF0YnB4dTRleW8z?=
 =?utf-8?B?RWx4cXhEV3VaSHZHZEI4ZTREeW9SWXlnMVVIdko3S1kxK0VJNlp2amZEeXpR?=
 =?utf-8?B?dVVIcEEzY0x3QTBMTmxxM2JsU1RDa2dvY1poOEJYRUk5QUppOTVwdXo4Mk8z?=
 =?utf-8?B?eWZzY1NMZTZaSWdXMlUrenNuWm5tOGZicEZ5OU9vM1ZJN2VqMWhENFljVExa?=
 =?utf-8?B?YWRWMkszRWthR21vdmQ4MmNzajYzWFY0VmtVcTUxbGg1U05yVE1tVzNsaWlp?=
 =?utf-8?B?c2NhZFgvd0lrc1Y2UGJnZjlTUzlZdUJFRUxQcHNhOU1QS2RpcndWQ0FPSHlK?=
 =?utf-8?B?WmFBZ05GbXZycFU4NFFFeVl4UzZSOFR4RjI1NmJ0Z3dONXRrTWNvRW5UYStz?=
 =?utf-8?B?Z3cyL2hsWUM1Y3c2MkxqaGJZR3NoeEg5elRHa3VVeThVZDQrNzlpM05YWXN4?=
 =?utf-8?B?YUlOSWhrN1hPWDNoK01iYUlTRWhBeFF5QzJSeXc1ZFJ2a3dWSWx0dlQ2QXpz?=
 =?utf-8?B?NE5PUUxaNWovdi9wU05TQ0FUMFM4bHVKUVFWSnlZa2dnQlZJcVNHZTZNcHJx?=
 =?utf-8?B?L2V4MXY4WkNkM1JueldSVHpwK0VyeEpicW12WWc1ZDFGOWxNSWFSVW0zeEpH?=
 =?utf-8?B?Mmd2cUMyd25xMTRMRlVEeHk2L2k3MXlWdm9JMmw4TXRGZVVXRitERVgwOHdT?=
 =?utf-8?B?bFU5VmlsUkJya3hnNEk3Rzk2eld3amtHTkxUMU9WdWU5VnkwdWZ6ZkFORjZF?=
 =?utf-8?B?aERLMVVDOTN0QmlyYTNyckdieTlJQlNkVUozY2V2MVdKcUVrNkxCd0x2SCtE?=
 =?utf-8?B?SzUvazFYSWJaZlJXNldsUGkyV1dNZTRYWjdyTUhDQ0V2aHJRMUExcER2MWtW?=
 =?utf-8?B?YWpUV0FZSzNHZUIrV1BXTzRZSzdIRHF0Zi9xVzZkWVJ5NHFSa2Y2OWlhTk5I?=
 =?utf-8?B?RWhvNXlqMFRmb1k3N2ErajRoUEJkazBVZkVwN3l0RHZ0ekdFUGNDcFI2aktG?=
 =?utf-8?B?MnVtd2JocXoxSTg1Y3pWSGloaFp6VURadW5LelduUGxFOUgxVHBTYS9qTkV3?=
 =?utf-8?B?ZkEycUdoNnYwUnp5azNEVW5uVnB6bFJvN1BlazZSOXBNekZ0TEwvUFpFOVY1?=
 =?utf-8?B?ZVgzZGV0YUIrQXFLZUFpaFJIdVNBSVpnOGZDMS9mSy9kQ3l1ajVkQTJtck5D?=
 =?utf-8?B?UU5kdUJvM0l2dEZLMWNtc2JEc1dyWVdzZkdidHJRWTFlL1kzRkQvSjZMamJH?=
 =?utf-8?B?NFpKdldLY2dNV0R1WlA1dU1ITjU2T1p2OGdNMUZWVlpNRW0vS29WVlRSWHVS?=
 =?utf-8?B?emRyUkovNStNUTA4SHplcTUrTUZGWjlzRjl4dUVERXpHM2tXeHRLMzdMUnZk?=
 =?utf-8?B?Q29ERnp1UXFTMmdMV016dHlyOVNHM1R1cjhQcXdBMGREeDdFUmZTZHVjSXdV?=
 =?utf-8?B?Q01LOERuQ01IR3hsbWxLc1MweTJwc2EvaW0zL2lqbkNRUlY4UlpoSEJwdDdB?=
 =?utf-8?B?dTBiY1ZNT0IzNVV4QWZSSkVXd1NsNFR2SDloNmRpTU9VMnJLMHI2YUN3eWlp?=
 =?utf-8?B?UkRlQW90bm8rSjE5dkRnOXg2RXg0WjFCVVRsSFR0Z2hCZUFpcUJUZVJqQzJI?=
 =?utf-8?Q?JUD6xwFW/LKQQxz421QzjkA=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c8912618-61c7-414b-3a33-08d9f1687155
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2022 16:21:53.1970
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Po+kZwuMy//R1Bt3sv0dqCw2B+cBWJLQGqr0bNU3Pc+wjLpdYa3O4ReOsTVvRsC9DbYO8aDriqCOy8UgtNA3RQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR03MB4143
X-OriginatorOrg: citrix.com

Current retpoline checks apply to GCC only, so make it obvious by
prefixing the Kconfig option with GCC. Keep the previous option as a
way to signal generic retpoline support regardless of the underlying
compiler.

No functional change intended.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
---
Changes since v1:
 - Put def_bool before depend on.
---
 xen/arch/x86/Kconfig | 6 +++++-
 xen/arch/x86/arch.mk | 8 ++++----
 2 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig
index b4abfca46f..219ef9791d 100644
--- a/xen/arch/x86/Kconfig
+++ b/xen/arch/x86/Kconfig
@@ -32,9 +32,13 @@ config ARCH_DEFCONFIG
 	string
 	default "arch/x86/configs/x86_64_defconfig"
 
-config INDIRECT_THUNK
+config GCC_INDIRECT_THUNK
 	def_bool $(cc-option,-mindirect-branch-register)
 
+config INDIRECT_THUNK
+	def_bool y
+	depends on GCC_INDIRECT_THUNK
+
 config HAS_AS_CET_SS
 	# binutils >= 2.29 or LLVM >= 6
 	def_bool $(as-instr,wrssq %rax$(comma)0;setssbsy)
diff --git a/xen/arch/x86/arch.mk b/xen/arch/x86/arch.mk
index fa7cf38443..2da4bdb1ed 100644
--- a/xen/arch/x86/arch.mk
+++ b/xen/arch/x86/arch.mk
@@ -42,10 +42,10 @@ CFLAGS += -mno-red-zone -fpic
 # SSE setup for variadic function calls.
 CFLAGS += -mno-sse $(call cc-option,$(CC),-mskip-rax-setup)
 
-# Compile with thunk-extern, indirect-branch-register if avaiable.
-CFLAGS-$(CONFIG_INDIRECT_THUNK) += -mindirect-branch=thunk-extern
-CFLAGS-$(CONFIG_INDIRECT_THUNK) += -mindirect-branch-register
-CFLAGS-$(CONFIG_INDIRECT_THUNK) += -fno-jump-tables
+# Compile with gcc thunk-extern, indirect-branch-register if available.
+CFLAGS-$(CONFIG_GCC_INDIRECT_THUNK) += -mindirect-branch=thunk-extern
+CFLAGS-$(CONFIG_GCC_INDIRECT_THUNK) += -mindirect-branch-register
+CFLAGS-$(CONFIG_GCC_INDIRECT_THUNK) += -fno-jump-tables
 
 # If supported by the compiler, reduce stack alignment to 8 bytes. But allow
 # this to be overridden elsewhere.
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Wed Feb 16 16:22:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 16:22:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274293.469744 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKN4L-0005Kh-JW; Wed, 16 Feb 2022 16:22:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274293.469744; Wed, 16 Feb 2022 16:22:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKN4L-0005KY-G2; Wed, 16 Feb 2022 16:22:17 +0000
Received: by outflank-mailman (input) for mailman id 274293;
 Wed, 16 Feb 2022 16:22:16 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=oYE0=S7=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nKN4K-0004NT-Ez
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 16:22:16 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 996356f7-8f44-11ec-b215-9bbe72dcb22c;
 Wed, 16 Feb 2022 17:22:15 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 996356f7-8f44-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645028534;
  h=from:to:cc:subject:date:message-id:
   content-transfer-encoding:mime-version;
  bh=82IywCEJaGTDXuJv2gZ75axUySAXEkRmFEmzOfBUsd8=;
  b=ULcf3U67X/HhBDl7NBXz4QXE6doACD75ozmaIj1UtA9BFRYuzjiLEitf
   leJG61Pn6w6bkW9oo170UDqWNdSeF8xE04K9zB7RfH3JTDVZfifPPA7xq
   fe6i0c4nQ51vcO96Uy6klPEC7OwLdgahtt9trTdcgVNrWWdqU0M6dkW3H
   A=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: qGzaH+oGlJLizQdf4n0N3NDwTR6Aoh0kW3s8Lccd5JO12zx4JX+wVQg0K9hu8goepBbwTyu4I7
 K54amvK2yIb3EuC1DYqbfCVEZkTPKxzINRhVTq7/Scei9sZUt8XIZv/I3XnUv8tXjGww0UGIuI
 rOrVK8aZ01cx0ojNZFbWql/zrtMnMTWQgdwLNRrhamjvO5pIGlcEIrMLjwYY11122Qta+AUduD
 /aAvY/Xgf9B2BVbEflpi0ss/Z7V7iIsoYMm83uqrNzUDWiHlYUyABErFoioxAsJTXR5cSwbPmR
 F/1yjODNBRpF5dvqTQIS7Lho
X-SBRS: 5.1
X-MesageID: 66594733
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:MSHthK0Cyof1v3GUpPbD5VR2kn2cJEfYwER7XKvMYLTBsI5bp2EPx
 2ZKXWCFOfyCNGujet5/b9nk9RhXvZaEzIc3HAZspC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkS5PE3oHJ9RGQ74nRLlbHILOCanAZqTNMEn9700o5wrBh2OaEvPDia++zk
 YKqyyHgEAfNNw5cagr4PIra9XuDFNyr0N8plgRWicJj5TcypFFMZH4rHomjLmOQf2VhNrXSq
 9Avbl2O1jixEx8FUrtJm1tgG6EAaua60QOm0hK6V0U+6/TrS+NbPqsTbZIhhUlrZzqhpc5e0
 IpvmpiLRhpqZLTCvcNNUSJWHHQrVUFG0OevzXmXtMWSywvNcmf2wuUoB0YzVWEa0r8pWycUr
 6VecW1TKEDY7w616OvTpu1EnMMsIdOtJIoCknph0SvYHbAtRpWrr6Diu4EFjWtv3Zsm8fD2b
 cAAcyhEMRX5eTYfBXUrWbwThve1vyyqG9FfgA3M/vdmi4TJ9yRzzbzsPdz9atGMA8JPkS6wv
 Xna9m70BhUbMt23yjef9H+owOjVkkvTR4Y6BLC+sPlwjzW71mEVTREbS1a/if24kVKlHcJSL
 VQO/SgjprR081akJvH/VRClpH+PvjYHRsFdVeY97WmwJrH8uljDQDJeF3gYNYJg5JReqSEWO
 kGhpc3GHWNNn7muRm/erK6aiBTiOxMbIjpXDcMbdjct797mqYA1qxvASNd/DaK45uHI9SHML
 yOi93Zn2ehK5SIf/+DipA2c3WrwznTcZlNtvm3qsnSZAhSVjWJPT6ih8hDl4PlJN+51pXHR7
 SFfy6ByAA3jZKxhdRBhos1QRNlFBN7faVUwZGKD+bF7qlxBHFb5IOhtDMlWfhsBDyr9UWaBj
 LXvkQ1Q/oRPG3ChcLV6ZYm8Y+xzk/S8RIm8DKGFP4MUCnSUSONh1HszDaJ39zqz+HXAbIllY
 cvLGSpSJSpy5VtbIMqeGL5GjO5DKtEWzmLPX5HrpylLIpLFDEN5vYwtaQPUBshgtfvsiFyMr
 753apvboz0CAbaWSnSGruYuwaUicCFT6Wbe8JcMKIZu42NORQkcNhMm6elxK9Y+zvsPz7qgE
 7PUchYw9WcTTEbvcG2iQntidKnuTdB4q3c6NjYrJlGmxz4oZoPH0UvVX8FuFVX+3OA8n/NyU
 dcffMCMXqZGRjjdomxPZpjhto1yMh+sgFvWbSaiZTE+eb9mRhDIpYC4Lle+qnFWA3rlr9Y6r
 p2hyhjfHcgJSTN9AZuEc/mo1V6w4yQQwbogQ0vSL9BPU0zw64w2eTfph/o6LphUexXOzzeXz
 SiMBhIcqbWfqoM56oCR16uFs52oA611GU8DRzvX6rO/NC/7+Gu/wNAfDLbULG6FDG6tofesf
 +RYyf34IcYrplcSvtouCatvwII/+8Dr++1QwDN7ESiZdF+sEL5hfCWLhJEdqq1Xy7ZFkgKqQ
 UbTqMJCMLCENc65Ql4cIA0pMraK2f0Ow2SA6P00JAPx5TNt/arBWkJXZkHehCtYJbpzEYUk3
 eZ+55JGt13h0kInYoSckyRZ12WQNXhRAawou6YTDJLvlgd2mEpJZobRC3Ou7ZyCAzmW3pLG/
 tNAaHL+uolh
IronPort-HdrOrdr: A9a23:+MO96a9f6G+Dp4JDZZ5uk+E0db1zdoMgy1knxilNoENuHfBwxv
 rDoB1E73LJYVYqOU3Jmbi7Sc29qBTnhORICOgqTMyftWzd1ldAQ7sSi7cKrweQeREWldQtqp
 uIEZIOceEYZGIS5a2RgHjaLz9J+qj6zEnCv5a4854Cd3AOV0k2hD0JdzpzX3cGDTVuNN4cLt
 6x98BHrz2vdTA+adm6PGAMW6zmq8fQnJzrTBYaD1p/gTP+xg+A2frfKVy1zx0eWzRAzfML9n
 XEqRXw4uGGv+ugwhHR+mfP59B9mcfnyPFEGMuQ4/JlYgnEu0KNXsBMSreCtDc6rKWG70srqs
 DFp1MaM8F6+xrqDxWIiCqo/zOl/Ccl6nfkx1Pdq2Dku9bFSDUzDNcErZ5FczPCgnBQ8O1U4e
 Zu5Sa0ppBXBRTPkGDW/N7TTSxnkUKyvD4LjfMTtXpCSoETAYUh4LD3xHklXqvoIRiKqbzOSI
 JVfYHhDbdtABmnhknizyZSKIfGZAVxIv+EKnJyz/B9nQIm3kyR9HFotfD3qE1whq7Ve6M0md
 gsDZ4Y5I2mNvVmFZ6VJN1xNvdfWVa9Ny4lDgqpUCfa/ec8Sjfwl6I=
X-IronPort-AV: E=Sophos;i="5.88,374,1635220800"; 
   d="scan'208";a="66594733"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=X8aSQavogDgxfvmsjM1TwZmj6RAMMRo1Q+lyYGbMMtcZZ+buBI9HXAqM5fbjamfBnudnmS8hgbWxN8h0TXxUnc4sQSxe4LNJd5RoDYtgPtgvhY5jdYY5a125UGshNOdSapSudqQIRR1hOviRn/Q9RVJz3yfaPAapjFJoljS4OmycbM61fTNLo+bRCon7N+BNztShlvzVGiRNJylt+3N3RavA8z154gkSoTwTLbq9EtCM6FlQHjV36eI8g3uLAT97cKN6msFMJUdp82eQM75XrIv2/DfMcr/ZlU2Ve6COK2Extfuw6YnkNaBKbYhowBjKrITJxpwQ4UJTwUMeMn6IEg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=2JUejUh5yzqKtWUj7o1W9V/dctJs6neBQWjRyLXc7bc=;
 b=P76wra8HPaBySXFpiIZHq8L0kCgO+ABcBsqQvikZapNaIdhDNBC/24bcHp80Eav6g389p3OM9j4mw739BG/fFyOqIMlWT1om4gWQO8KxWPJnzByvFve+4DfHRYHj0bM4mzmOtZvQMa6VIF/wIGoiH9OFoTKIshTaNO+EzkUGxE9Ij1eB8PYOvhldjUQUk++LGijc31gZ4lRgc/AMo/xD2HwROA67wL447SAXoz62tBfrllIQWPQsG8cr+vbiMYYeJbea+PDyE2O0pklDM2BR7ilViOSeerUPQbym0vLBW/rC/CY7oeho7FbJpOhbEEZsyI5qb6VObJ/J6uA8qy1eYA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=2JUejUh5yzqKtWUj7o1W9V/dctJs6neBQWjRyLXc7bc=;
 b=g1GjV/KTk6DNZswjMPhqE/OmGGa2FOCfQuRRzeK5Ox/KFq0b2YgASCiANkurVBhfDuoWsFKgspQSyiZH/hceeDd44ZGhlrOAIAlZk3sxjfaVAwv8zh5k85fPXQz8TPDNtdlZDlUL/6JA4tvlCkmPfcckKiWiV5fJDOMOaHzIrpE=
From: Roger Pau Monne <roger.pau@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Roger Pau Monne <roger.pau@citrix.com>, Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>, George
 Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>, Stefano
 Stabellini <sstabellini@kernel.org>
Subject: [PATCH v2 0/3] retpoline: add clang support + Kconfig selectable
Date: Wed, 16 Feb 2022 17:21:39 +0100
Message-ID: <20220216162142.15384-1-roger.pau@citrix.com>
X-Mailer: git-send-email 2.34.1
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO2P123CA0016.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:a6::28) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 463c500d-cbcf-4b95-a5f1-08d9f1686dfa
X-MS-TrafficTypeDiagnostic: SN6PR03MB4143:EE_
X-Microsoft-Antispam-PRVS: <SN6PR03MB4143EDCAAFC9C745B15242128F359@SN6PR03MB4143.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 2Kci9GkdqeQnDtOgpGWWNl6zFyfb0wkaDWEMu9+M7y1XaTSVr1jrGpWKzHKiqv0VFqyi+544TFmbyaXf9vaw5tHhYa9csQy+mDWctUtXPgaPWu1OgJug8RVpmKqy9m0iHdn7MRsiKxT+1HlEfJZlDXw0/rjDcbLMFHMrleABYEC8Sz8+aZI1XtD8374ziHmN+HL4cKC8b30d2EkC/NM54vdZ2fmDOUxrc36w4MFmsnxOJdQJtburZzgeGrwKSoTAzimS10UYGu4QlvufxD9nRlIsZ5dzSkUUl01VGYozcm80KYktI1wNg4D9qRdxidWVwVJMoS7cpm3oBPprMR9MCws2MD9T+PCSOn/HCchoTSiwxuvAtU3L+OKy/NIAioTA+nM/2a67Acu22piwp9kVxAW0YuJ6lY0L3EFrSU0Q6Cnv0XrVcPedx1MQdCO7eYfBeZPL69vfw6Oq+1jecFyiSKB83irt0Pwle7brEpde2ZEFOBcNQhnJ0eHN3k/3DeBw7B7FVv46qie558l77kclNPDZx61HlLLrhpaCTNqNRNGAzM4yZXYO8zK+QpPNGa6P+vGVZNlGGhduWj382ot+ZJqlVnQNzz9PP6aD9qgAU87jt0g8TSy/o51mSUtqw5hMUxg1r23h8WH1lClUwhQ0YA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6916009)(508600001)(4326008)(86362001)(1076003)(186003)(6506007)(316002)(8676002)(6512007)(66476007)(36756003)(2906002)(54906003)(5660300002)(83380400001)(6486002)(66556008)(2616005)(66946007)(26005)(6666004)(4744005)(8936002)(38100700002)(82960400001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dG5UNmRTVXlzTE5idXVjQjd2SDgzVHlSUDVGbFluVk9abHpWdGhGSE0wWXZs?=
 =?utf-8?B?M25ZQ0tqOWhvaUxoNVRLUEFaSEl3NFVTZWVtZFlWNnl5cElTdXEwdnFTTnFz?=
 =?utf-8?B?cXplU0RyU2kzdUF1MkttUmJWTkJIT1FZYitFdWZJY3JlTTlWWnZZeVNFSWFm?=
 =?utf-8?B?Yis2QmRWSEltR0lCOGd4Qzk4OHlnazczZTlZWnZ0Wk8xRVFTZXdleW80UmRx?=
 =?utf-8?B?d3NQellEd1pOdjlKeHBwWFovLzFmREt1MUQ2N1ZLUGNzWSs0R0pySXhHTnVy?=
 =?utf-8?B?T0dzcXZDMkNhRVJqcmJXTVZkV3liVllHVUV5N1RZOUdjYXB2R0UreTJCcUtz?=
 =?utf-8?B?eXV5dGd1QWdhOE1IWk1uVTE5bXBnbWNEV2E4bnp4Tk40TVp1aXlIQWpOVmsy?=
 =?utf-8?B?WnZobHZkMzRHcVI0Rm90ckhla25qc1lxQzJBWGV0cFkvaTdFdGNUaHlaa0JN?=
 =?utf-8?B?TjUraWkySXBDdllReURyREFTTGRINFhDSkRiY0JRQm9tYzJZZW1nMXI1ajFK?=
 =?utf-8?B?d1ErSTY3RGNjOWltcVl4WjEvUHpHUkNHdktJLzdlZWhIdTNoV1RqcGdWSjlR?=
 =?utf-8?B?Tm9WUUl6N01mK3JTRDlaSEpEMmZIaS9RMjIvZXJrc3gvT0krOU5jUjBHWE9p?=
 =?utf-8?B?NVkxRUoya2tlWkNtdFpFbHdYSXdJZDdKNjVWMjYzUWJHaC9LQ0ErTFdqbW9x?=
 =?utf-8?B?cWZFZzdwcHF4c2FWanRqT3BHTW5LcHBqeGg0OTVZTmdjVjBsRGxlc0RoZm82?=
 =?utf-8?B?MkxvYmxaemx3Tzh2SG1wMXZLL1lNSUtmQ0FVbTNuditZSEFpV2lOTU1hOWdL?=
 =?utf-8?B?SWNvUmFHSmEwUE9PWU9VN3M2VkhqemM3M2Z2OExXcTVoelpTQjB4TFZPTXR6?=
 =?utf-8?B?SWpLT2F4UEVtaW85cHdxU2w2OHBkRndkOFNtV1lrbEJaMkpYWmh0Zko3dFA2?=
 =?utf-8?B?T1h0Q1hZbENtbFJuampaYmMrbEpVMG8xM1k2Tms1MkpvVVhGZHhXdG12aHlx?=
 =?utf-8?B?emtQSXJJOUtYVzdtWVB2V1kyMHF0K2lZVUVqZldIOXkyNnNxS0M0cUhoWDNH?=
 =?utf-8?B?TnR3TlJmWlBUVW1yU2pwY1UrYnJsc1phTzd6eS9aQzNmZkhwV0czWEE0MjRv?=
 =?utf-8?B?QzBBZ0F1WkM3TU1QM3ZQOHRrTmswZkJxb3Yya25ZVURhQWJIWjREdzRka0d0?=
 =?utf-8?B?UWNGMm5JTzdLVWhhLzZwbDJQRFdxZFJNZWxkR0pEUW5HUCtXMUcvOXZIdXN1?=
 =?utf-8?B?Zk1NeDQ1K1FiMlYreFRobVJqQzNZWklJMmRTQ1VCTDNuZ2xFVnN3OUZxMXlS?=
 =?utf-8?B?Z2xIb25scGlmNHRRem5uM004eXhPQVpNSHFlR2lnWGhFdnlPellxd2dhVms5?=
 =?utf-8?B?a3cyelRhVHRzYW5RejE1bks0U1I1ZXlhQkEva25hT0hCb1FVYlVJMmIwWXpk?=
 =?utf-8?B?SXhGNkt4NVZtY0lLbU9wS0N3MFNkZnM4WE11TWwzNU5ZTURBVlVROVlPd0xy?=
 =?utf-8?B?UlJra01aajJ4eWFWN2lPWEdGYnIyVGVjcUhqazJTM0tSZUU5clhCWVVNYnJh?=
 =?utf-8?B?NENVSHFwZXZDWVhFRk5Fd1ppSDhzdDRRdCtpOEVkODBwTStUV0l3bnJSN1U5?=
 =?utf-8?B?K05Tb2UxTjR1MHZPTCt5dDZ5YTltRTZDdXYwRjhXdXBQbXlYV3NJS0RzekV5?=
 =?utf-8?B?TEJuT3VuV25DZTZUSVl5dDgxNDl3cXlobHBGNG9EL0F6SXhHZVR0S0JWNmQ5?=
 =?utf-8?B?aUFId3FIQUFUbEZXcEZlN0RXY3dvbjRDOVdPOENFVStvSWYrTEJmcTh1TjBB?=
 =?utf-8?B?enNwaGRYZ0VJdjVhZkZrTzluSGhUN1JZZ3NmL0JMVHVyZGltYTZHaERrTFEw?=
 =?utf-8?B?eSs3c3g2d3dqT0lEUDVScTE3UUhlcktXRkZxakVaWnU3WGZzZDBpZUdtOTQw?=
 =?utf-8?B?Zy9UQmd1Uy9pTDlkTUxVZkNxMXliTXcrQ0IrUTV0QXpEanRiR3c1R2hSamYy?=
 =?utf-8?B?ak9lcTZNK0wwZ2xYUGZSaHRhWU5yUGRuTHJiN0hlTEp4aFZaRkxVL25YZWJy?=
 =?utf-8?B?UzZaeHBFMDljRzllcjJ6YjBGZjY0WUFZaUl1ems0QXdVSUNYNml0TmhLSWtC?=
 =?utf-8?B?MmJtYnpyeis0OUZGTHJVQ0FPRG5hRXhrVlJIc1NKd2s4UjRkdDdtZFMzREQ0?=
 =?utf-8?Q?5o+ZSSP8UxmdCONgqBI4h6I=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 463c500d-cbcf-4b95-a5f1-08d9f1686dfa
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2022 16:21:47.5077
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rbONISsoJjG00FeimFdKfD625fnDRnIKBal4+9YZXtlcJ4330QgDkafrlfCH2rFtNYPMR8W3YzjAqguij++3hA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR03MB4143
X-OriginatorOrg: citrix.com

Hello,

The following series adds retpoline support for clang builds, and also
allows the user to select whether to enable retpoline support at build
time via a new Kconfig option.

I've tried adding a suitable description to the Kconfig option, but I'm
sure there's room for improvement.

Thanks, Roger.

Roger Pau Monne (3):
  x86/retpoline: rename retpoline Kconfig check to include GCC prefix
  x86/clang: add retpoline support
  x86/Kconfig: introduce option to select retpoline usage

 xen/arch/x86/Kconfig |  5 ++++-
 xen/arch/x86/arch.mk | 13 +++++++++----
 xen/common/Kconfig   | 16 ++++++++++++++++
 3 files changed, 29 insertions(+), 5 deletions(-)

-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Wed Feb 16 16:32:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 16:32:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274320.469755 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKNE5-0007f8-KO; Wed, 16 Feb 2022 16:32:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274320.469755; Wed, 16 Feb 2022 16:32:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKNE5-0007f1-HL; Wed, 16 Feb 2022 16:32:21 +0000
Received: by outflank-mailman (input) for mailman id 274320;
 Wed, 16 Feb 2022 16:32:20 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=eQkk=S7=suse.com=dfaggioli@srs-se1.protection.inumbo.net>)
 id 1nKNE4-0007ev-97
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 16:32:20 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0226424e-8f46-11ec-8eb8-a37418f5ba1a;
 Wed, 16 Feb 2022 17:32:19 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 9061D212B8;
 Wed, 16 Feb 2022 16:32:18 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id EE5EE13B2C;
 Wed, 16 Feb 2022 16:32:17 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id EuTtNxEnDWJ5UgAAMHmgww
 (envelope-from <dfaggioli@suse.com>); Wed, 16 Feb 2022 16:32:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0226424e-8f46-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1645029138; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=aMka9Y/6KEIZBAn6n4bu9PNATEQAbTULlP3Q5H1nAU4=;
	b=QdZ4d+IkNJE14oaghbws7Xq5eUXMKfCfohOiS4wzzATsICH7eJLKSWemhVyCOCTOVIrsB4
	b3augip1tjYeAwNp9P5fBZ8i40FPE+zIGwEfVY4kj5yS2ZAtBZgh+TruKpK9OvfyxqgByo
	RKuSyb0vTWPGbSob1PFKoSaLEuxAPvw=
Message-ID: <7b30027945ef9c545fa607f957d8f4cbbe871a52.camel@suse.com>
Subject: Re: [PATCH 4/5] xen/cpupool: Create different cpupools at boot time
From: Dario Faggioli <dfaggioli@suse.com>
To: Luca Fancellu <luca.fancellu@arm.com>, Juergen Gross <jgross@suse.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>, Wei Chen <wei.chen@arm.com>,
  Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
 <julien@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,  Bertrand
 Marquis <bertrand.marquis@arm.com>, Andrew Cooper
 <andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, Jan
 Beulich <jbeulich@suse.com>, Wei Liu <wl@xen.org>
Date: Wed, 16 Feb 2022 17:32:17 +0100
In-Reply-To: <E99BEEA5-863A-4780-95D0-C22A12263737@arm.com>
References: <20220215101551.23101-1-luca.fancellu@arm.com>
	 <20220215101551.23101-5-luca.fancellu@arm.com>
	 <d6f36774-ecb5-15f4-b0c0-6114724060e6@suse.com>
	 <AC1B6659-FDCF-49A0-AB6E-EF2196C46D8C@arm.com>
	 <779968b4-5985-06bc-be35-ce5b0b719930@suse.com>
	 <E99BEEA5-863A-4780-95D0-C22A12263737@arm.com>
Content-Type: multipart/signed; micalg="pgp-sha256";
	protocol="application/pgp-signature"; boundary="=-7JisVB2CEqinCKN1eCl0"
User-Agent: Evolution 3.42.4 (by Flathub.org)) 
MIME-Version: 1.0


--=-7JisVB2CEqinCKN1eCl0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, 2022-02-16 at 12:37 +0000, Luca Fancellu wrote:
> > On 16 Feb 2022, at 06:18, Juergen Gross <jgross@suse.com> wrote:
> > On 15.02.22 18:56, Luca Fancellu wrote:
> > > >=20
> > > Yes, however I think the parser to handle everything by command
> > > line would
> > > be huge due to input sanitisation and not easy enough as the DT,
> > > however
> > > I see Hyperlaunch has plans to use DT on x86 so I guess it would
> > > be ok to make
> > > this feature common once the DT is available also on x86.
> >=20
> > Everything not being explicitly specific to Arm should be in common
> > code. Think of the work in progress for Risc-V.
>=20
> Ok I will put it in common and I will make the feature depend on
> HAS_DEVICE_TREE.
>=20
Can't we split the DT parsing logic & code, which is fine to be either
ARM or HAS_DEVICE_TREE specific, and the actual core logic, which can
be common and not gated by any particular condition?

This way, if one wants to add boot-time cpupool to x86 via command
line, he/she would have to implement "only" the command line parsing.

I've looked at the code, and I appreciate that it's not trivial and
that it's probably impossible to achieve 100% decoupling (at least not
without adding a lot more complexity)... But any step we can make in
that direction would be, IMO, a good investment.

Regards
--=20
Dario Faggioli, Ph.D
http://about.me/dario.faggioli
Virtualization Software Engineer
SUSE Labs, SUSE https://www.suse.com/
-------------------------------------------------------------------
<<This happens because _I_ choose it to happen!>> (Raistlin Majere)

--=-7JisVB2CEqinCKN1eCl0
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEES5ssOj3Vhr0WPnOLFkJ4iaW4c+4FAmINJxEACgkQFkJ4iaW4
c+7MVhAArBW43S7YcpSTI7+sTjANnNlVjHkEzmwTXq+Yvp2AeLX3GkmfqLFYWma2
SREUtQzWu9ZtypX35BYMbGXjl8J99H9VcJvSozqsIjSxlVVqpzL2gWmTLyBWrsZe
d/cbZibye0BBHSSN4kEkwWuFFRxQWLOsFdtnbJQZ3UeSjzu4YDeErZuoFvn+BhJF
IFxTgDepF+6xWg7EVcoRwlcjkUC7oTgpk95knVpjTy4Ulb/UdtophFSvlclNIl9b
EPt+pEBlm+QGkn4mGwwKxAsTK2ax27HGq1b0uN/rrGEZNmkppE18hrhpWYY61wYh
mjzJDGsMTrNDqlcJ9/MHHfnIOCTESMOOSdqKPiT4362O/hQGyUz6XvRx4OoFhltJ
iwk4HXxHtYFMMD+cvyoOAvXPug0mYEddzA849XY03sHgm3JgpVAZabqhmyeN+T8T
xtuTOwCQLjrKBNDSJQoxB7nVvyv9cNuc5rAugaZv7AOup39c9SQuOQH/mc1UzbIr
a9uqdbmIdXTonzrZCCHaPSkaifk+p+3V3KVwSWXGdOOkTxbiQJ1wncoCAzrKVb60
priXzepF8abyQR5o29kdEsS/o0O1POcEJt3EyA7w9vzYS/hQQqN2MXiUp2B6SFWR
UBkyx6tDMs9aBwA1s2jAbed0q9sTmIZI1Jjbi22KZ3AUS4tV9O8=
=Ve2y
-----END PGP SIGNATURE-----

--=-7JisVB2CEqinCKN1eCl0--


From xen-devel-bounces@lists.xenproject.org Wed Feb 16 16:46:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 16:46:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274329.469766 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKNRE-0000oR-W3; Wed, 16 Feb 2022 16:45:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274329.469766; Wed, 16 Feb 2022 16:45:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKNRE-0000oK-SG; Wed, 16 Feb 2022 16:45:56 +0000
Received: by outflank-mailman (input) for mailman id 274329;
 Wed, 16 Feb 2022 16:45:55 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=wbM1=S7=arm.com=Luca.Fancellu@srs-se1.protection.inumbo.net>)
 id 1nKNRD-0000oE-CZ
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 16:45:55 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04on0628.outbound.protection.outlook.com
 [2a01:111:f400:fe0c::628])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e6e8444c-8f47-11ec-b215-9bbe72dcb22c;
 Wed, 16 Feb 2022 17:45:53 +0100 (CET)
Received: from AS8P189CA0023.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:31f::31)
 by AM0PR08MB3409.eurprd08.prod.outlook.com (2603:10a6:208:d4::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.12; Wed, 16 Feb
 2022 16:45:34 +0000
Received: from AM5EUR03FT064.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:31f:cafe::eb) by AS8P189CA0023.outlook.office365.com
 (2603:10a6:20b:31f::31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.16 via Frontend
 Transport; Wed, 16 Feb 2022 16:45:34 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT064.mail.protection.outlook.com (10.152.17.53) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4975.11 via Frontend Transport; Wed, 16 Feb 2022 16:45:32 +0000
Received: ("Tessian outbound 18e50a6f0513:v113");
 Wed, 16 Feb 2022 16:45:32 +0000
Received: from 3561a2de1864.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 EA7FD459-1079-4EB8-AF8C-43BD02F526EB.1; 
 Wed, 16 Feb 2022 16:45:22 +0000
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 3561a2de1864.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 16 Feb 2022 16:45:22 +0000
Received: from VI1PR0801MB2125.eurprd08.prod.outlook.com
 (2603:10a6:800:5b::23) by VI1PR08MB3373.eurprd08.prod.outlook.com
 (2603:10a6:803:7b::23) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.14; Wed, 16 Feb
 2022 16:45:19 +0000
Received: from VI1PR0801MB2125.eurprd08.prod.outlook.com
 ([fe80::5531:4c33:a50c:ea0e]) by VI1PR0801MB2125.eurprd08.prod.outlook.com
 ([fe80::5531:4c33:a50c:ea0e%9]) with mapi id 15.20.4995.016; Wed, 16 Feb 2022
 16:45:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e6e8444c-8f47-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=8SDQQpjilmnDI3MclnSGYcerVK7NcRvz1xk60aNxIMY=;
 b=sruA3KvipqqAzVSbrSOF6XcLFQ0QkRPooKP2+OdrWlgeDF8Cw59rVJzlGQdpXvFJ9YuP1VdcRFMrjsgrHssM8jmhPVhCYK2fytQZbojDHkqhIF3JVNdm18VP03C0aRF0Uv11cdhLT+zatZDKteUUNobOAW7V0G9DyhNm5QzIdC8=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 2595de55582fcc7d
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=mqLGfNg6d9rMdjF5yR/0+i4DfieAEslF9tFtt/L9Wepc5yWga7WhGpTa92r3LNN+ODq8E/QaJ4imQNleqLokbLZ1uvrYTA7EDCfkN7VK0IHOuG8e2ZY+3NgwsRiVpoiYOOd48OPshwUPHl915UGnQxWLv0kQ2a5PX8Dg9Mp/+/zUHdtic76OtVGMxE7JEW0BWx35baIQRXNk0y5OyxnsoNsfT5W93OE02jZt8MJmbxenxAj3v6lZeOqq2KWLUpmK6Sjyb5q1R9Lgfzc38lZG6sEPieadpAi+pB+xTjk5x5R/wsd2vGB+WwkPLFRF9R8Mw1ak1kHDppANhGUGXMzKIA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=8SDQQpjilmnDI3MclnSGYcerVK7NcRvz1xk60aNxIMY=;
 b=FjX1mItQZv4b7YB9DB/+0CbzjddTG4c5pbmLJWwCFaHHdx7s7rEIw9oZP9uq3Xq67Pc9csDTxTtKUzPOxtdnN7n9fOp9ZPEcuPK/nD2G18NorwFWZqUsZneKg97DlULKMti6CNGlKhdM2+frV0cp1G5oW/L509OUOTX7PCqTF12ZsUMql+uGaBlxNdfkalI3xnSTrT/6r6rwBzma+xQypzkCi7jX0Fg0v4617IBZ9WvwKXDz4MLpD3vraDLiZcfV99U6qoXR2HsAJnEMwEgBz/w8b6SVXi8Hvk8BZznaOQfPDjtz73DMxmt6Oofe+zZ9HpYcvs9KXbRZy/9uECu+qA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=8SDQQpjilmnDI3MclnSGYcerVK7NcRvz1xk60aNxIMY=;
 b=sruA3KvipqqAzVSbrSOF6XcLFQ0QkRPooKP2+OdrWlgeDF8Cw59rVJzlGQdpXvFJ9YuP1VdcRFMrjsgrHssM8jmhPVhCYK2fytQZbojDHkqhIF3JVNdm18VP03C0aRF0Uv11cdhLT+zatZDKteUUNobOAW7V0G9DyhNm5QzIdC8=
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
Content-Type: text/plain;
	charset=us-ascii
Subject: Re: [PATCH 4/5] xen/cpupool: Create different cpupools at boot time
From: Luca Fancellu <luca.fancellu@arm.com>
In-Reply-To: <7b30027945ef9c545fa607f957d8f4cbbe871a52.camel@suse.com>
Date: Wed, 16 Feb 2022 16:45:16 +0000
Cc: Juergen Gross <jgross@suse.com>,
 Xen-devel <xen-devel@lists.xenproject.org>,
 Wei Chen <wei.chen@arm.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>
Content-Transfer-Encoding: 7bit
Message-Id: <304383E7-FE8D-4B60-BC7C-5E7A1739471A@arm.com>
References: <20220215101551.23101-1-luca.fancellu@arm.com>
 <20220215101551.23101-5-luca.fancellu@arm.com>
 <d6f36774-ecb5-15f4-b0c0-6114724060e6@suse.com>
 <AC1B6659-FDCF-49A0-AB6E-EF2196C46D8C@arm.com>
 <779968b4-5985-06bc-be35-ce5b0b719930@suse.com>
 <E99BEEA5-863A-4780-95D0-C22A12263737@arm.com>
 <7b30027945ef9c545fa607f957d8f4cbbe871a52.camel@suse.com>
To: Dario Faggioli <dfaggioli@suse.com>
X-Mailer: Apple Mail (2.3693.60.0.1.1)
X-ClientProxiedBy: LO2P265CA0183.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:a::27) To VI1PR0801MB2125.eurprd08.prod.outlook.com
 (2603:10a6:800:5b::23)
MIME-Version: 1.0
X-MS-Office365-Filtering-Correlation-Id: b8edbc96-c1d7-4ae7-6f36-08d9f16bbfba
X-MS-TrafficTypeDiagnostic:
	VI1PR08MB3373:EE_|AM5EUR03FT064:EE_|AM0PR08MB3409:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR08MB3409B5A1C9972FD10AA18A03E4359@AM0PR08MB3409.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 35K4n0xzI4CgbhqDd2T5UFf2ksvod5fbdZyVbhu0SwPZgmkOVXi/JdSZicPdI6gTZAk81cvXJ3ugeBBBSv6KAO4nmcRItD9CLnAec/Fsc794qwLPS0ZykZnFZbpRFu/UT1nQ3d57luYA+ebjRFjn2IAMeI99VwrqvLBiwod/Z/ou63a5bt7SesZHJW3Zq66okZQtmZ/J4k42aDKy4uqATPupbwl0ufik611aL+5h+dgjaIyZacR4Bug3FsI6KWaSbGUzbnB02WsJJS2esH2CN4BpATCoVs5hgBhhCVF9otxX+IfM0n7762NfswuUF7rW8xsF1txAp3bLY0VC31MMvuPOumA/2gOLpMOJaC/o4PIXgcBiXipwe2m3x6fO32M8yfx/FA+uXz58uRdX1jjPIvMW9n6PyxW8i49ifkPBvvGNtInCmtrKL5gKdnQ5iGLmwXappeAiGHQA3suXIoSflObGhd88cuZzSK1A24DcYmnMo/5ORxsHyzzAA4/JfQZdF1UnV6bf1rzMeLUeVQ8jao3M10XdxLYZp0XGQzOBNnl9aLKP6DcV0B3k6sfFbGb5IDOm8dgyqb0IQnrua7ftwQxLUeJnl7BqOVEaHfFCmV+UH3sz72s0IyVb/RC0FZ14yKw/C47OxQqOdTlOC82zYn0TLQYi4xNcrpjWUt4ALTyhSznsslHzV62SOvWQQXDZdE/3kyH28UAAR4wWY4Kww1J3jcmdZcSNtyPRP/fDmBVJEXnW5FSEvXmKC4JIFA6/y21+P4RrYlKLKTNfQaOw6sM5MVQhlnDJ6RpTld1k7AZ4kY5M4IfAWvNYKmlt1nBr
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR0801MB2125.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(8676002)(316002)(86362001)(508600001)(6916009)(4326008)(54906003)(53546011)(6486002)(6666004)(6512007)(6506007)(966005)(66946007)(66556008)(66476007)(33656002)(52116002)(5660300002)(8936002)(44832011)(7416002)(36756003)(2616005)(26005)(38350700002)(2906002)(38100700002)(186003)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3373
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT064.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	ce8dd249-a656-4487-24b0-08d9f16bb75b
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	gyjUEho5JHV1WCS3bJgbLXPQk+RfgxeKTUKo3TxDFSPIS33PUUgn3bmaWxw5+ZEPQopMpr4ffXhwtGalMju0oMZxy8uFr0CyUKw+XooVB7IecDusbseSJNPaj9QbYvR0MFSu2kEChhuSGFHFMrLE9aGLc0S2QYKPkcfwQz4nb9QQfAG3tKo9LfxAtAUBLggW7vlCFI6BpWZvDt+0ZE47/TWOJb0zsV+rjqu2Kwq8/oy5GssLKRDqn3smjymmeKQCGGDTqk9K2cQVPSwOl2Gpzr4PCC9P+fX7efpXq8/CPM6awVodoCdrUz+SqNvRtI9WuX+SP0wdqpkDtpuQf97LFoc2bSZAVTX5Umy1kYsUAjc4MiSTBQnSPJb24/veaZtsxnsIK3RQW3TGltMU+jnpttg3IY9J1ToGd12cSJB5y9mhCGk4RneWlV3hwWqjMxdDqONkGk5mBvjbzIf97U/ZBrGC5BYxbKFf2PyhToPRK3NtFfTN6uPkumwSZWx8Gzy7IShkQLGNC4aNFzcbychuFCvdVcQycqeDhVsISK99C3HJi62DMBOeBqz7GXyjlISn01O+nfQLBx045+m6L1/vjPXL/9HrlLXlEXjX+rYAiLhdSFixCkeNi+W1is+SJeWZ+EMYdbjlOaW+GHva3dDSp5KcnjNZ6j3lcRLYQiUAq+C9nIfjo4HsFEFSie2RjfE/HPR8lc/rvWmoCATZNTzc2gh3nxoMrZsXGMeiEAJCRSBxwu8H6hx3XXP37poFevvV3/NinrAM/MwMCCaYTluOuwBQkRS7g0N7547PAnBIKDU=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(5660300002)(8676002)(6666004)(70206006)(336012)(33656002)(186003)(316002)(4326008)(2906002)(70586007)(26005)(8936002)(86362001)(36756003)(44832011)(6862004)(82310400004)(36860700001)(6512007)(53546011)(40460700003)(966005)(6486002)(356005)(2616005)(54906003)(6506007)(47076005)(508600001)(81166007)(36900700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2022 16:45:32.9522
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: b8edbc96-c1d7-4ae7-6f36-08d9f16bbfba
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT064.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3409



> On 16 Feb 2022, at 16:32, Dario Faggioli <dfaggioli@suse.com> wrote:
> 
> On Wed, 2022-02-16 at 12:37 +0000, Luca Fancellu wrote:
>>> On 16 Feb 2022, at 06:18, Juergen Gross <jgross@suse.com> wrote:
>>> On 15.02.22 18:56, Luca Fancellu wrote:
>>>>> 
>>>> Yes, however I think the parser to handle everything by command
>>>> line would
>>>> be huge due to input sanitisation and not easy enough as the DT,
>>>> however
>>>> I see Hyperlaunch has plans to use DT on x86 so I guess it would
>>>> be ok to make
>>>> this feature common once the DT is available also on x86.
>>> 
>>> Everything not being explicitly specific to Arm should be in common
>>> code. Think of the work in progress for Risc-V.
>> 
>> Ok I will put it in common and I will make the feature depend on
>> HAS_DEVICE_TREE.
>> 
> Can't we split the DT parsing logic & code, which is fine to be either
> ARM or HAS_DEVICE_TREE specific, and the actual core logic, which can
> be common and not gated by any particular condition?
> 
> This way, if one wants to add boot-time cpupool to x86 via command
> line, he/she would have to implement "only" the command line parsing.
> 
> I've looked at the code, and I appreciate that it's not trivial and
> that it's probably impossible to achieve 100% decoupling (at least not
> without adding a lot more complexity)... But any step we can make in
> that direction would be, IMO, a good investment.
> 

Hi Dario,

Sure I will try to do my best to point in that direction.

Cheers,
Luca

> Regards
> -- 
> Dario Faggioli, Ph.D
> http://about.me/dario.faggioli
> Virtualization Software Engineer
> SUSE Labs, SUSE https://www.suse.com/
> -------------------------------------------------------------------
> <<This happens because _I_ choose it to happen!>> (Raistlin Majere)



From xen-devel-bounces@lists.xenproject.org Wed Feb 16 17:42:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 17:42:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274338.469777 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKOJH-0006dV-50; Wed, 16 Feb 2022 17:41:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274338.469777; Wed, 16 Feb 2022 17:41:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKOJH-0006dO-1v; Wed, 16 Feb 2022 17:41:47 +0000
Received: by outflank-mailman (input) for mailman id 274338;
 Wed, 16 Feb 2022 17:41:45 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ai2G=S7=epam.com=prvs=4046428260=oleksii_moisieiev@srs-se1.protection.inumbo.net>)
 id 1nKOJF-0006dI-0u
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 17:41:45 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b23e9fe9-8f4f-11ec-8eb8-a37418f5ba1a;
 Wed, 16 Feb 2022 18:41:41 +0100 (CET)
Received: from pps.filterd (m0174681.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 21GGhIeg022350;
 Wed, 16 Feb 2022 17:41:31 GMT
Received: from eur05-vi1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2168.outbound.protection.outlook.com [104.47.17.168])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3e90eh1dst-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 16 Feb 2022 17:41:31 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com (2603:10a6:102:ea::23)
 by DB7PR03MB4185.eurprd03.prod.outlook.com (2603:10a6:10:23::21) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.14; Wed, 16 Feb
 2022 17:41:25 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::c1c:f98:9dd:86e0]) by PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::c1c:f98:9dd:86e0%6]) with mapi id 15.20.4975.019; Wed, 16 Feb 2022
 17:41:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b23e9fe9-8f4f-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=iA4EFxD2fVNCIHoClymZrLmPngOvJTPvnXIjrowXoMSTGqtVTrqSRxRDfruNbF+WUXF1i4KNkF5B+v3mJRandXcIi3xQjWcPKZavrfZBy2MY39COjDffXSjePeT5St+8VXbjWzFht/hRmd9iJo3QT/bRHST0a20lpIUOO5tl5W9z9xCdrnr7AEwNUQBV3wkxs282JpdbVYlLkLUXcZlMKITQLREJeMa+nYVTzjuB29MFitvGfLcj5jnn2TVDLIsaVs9qftINPZ0t8heh3sbcAuiENX2oTUVfnrgMWvL2QM/t4tnTXpLXo8BiMVUFx72E7Q5q/+h2vOF4AHNrJzCNdA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=NX+SaukE6/joZlH4ugSUUza9ISs4abl66HQvh0Dilms=;
 b=MkiULN1i/B/XrhBjDCPIe7ufYXIrVStojAe3FjGTs5YXBYZbY0iPNgDp8oMFeWGEJLLRlIb2FynJ9RFFHzEWvU4bWu4bV6ebWwMhDOMn5UyZRdBFJ6aG7E79LlX9PfunYryoV2xQ152VUHp9PoAf+hGyo3xs2D0Fwgc1Ape53TahSDBggFzdgnOuPJdkm/alyeokDyTQEg8WlITVhqkMF8UejewHzo/WpaxaXcA7smnMp1D85Ul5tv2c2q0eFL6tPaIOYBA51nHG41FEQvSQqm+tZBVBLXtaopI4DyJHHEb2e5rZPEWCNHCy7MTvNQNfRjn7CjE/q2+9SmaO5pe6JA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=NX+SaukE6/joZlH4ugSUUza9ISs4abl66HQvh0Dilms=;
 b=RZB/QDBDyc5n7/oalqZi+H/RQyuH+ADmTJWja+SIwT1UAdRSkYvAQH5qJjgg5XNgdLlWvgV2C3nwJKvaxTO5B+i9HbCsGxFKGsDe71bITwpPrxH08vieFPhSqrUsnyJfnVJr/O0xNsy/InkTp9IDdFyAKF19SWNKmzD/6Zn973cs8vBac8JB3cnvS8lNM26ZDLi8sxqc6w0tZRwHeabbK1rCCSN3LB7h4339jG7ucVJw3uMX29GjnAR63bWwJxHC5AMIv678K4/Kym3MA0Xa7Q9j+WBvKWqAmFR8H46066+jx/ci3wuYijxu2qwePuKhiydL7kZpZb+XkOjkURfEJg==
From: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: Bertrand Marquis <bertrand.marquis@arm.com>,
        Julien Grall
	<julien@xen.org>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>
Subject: Re: [RFC v2 5/8] xen/arm: introduce SCMI-SMC mediator driver
Thread-Topic: [RFC v2 5/8] xen/arm: introduce SCMI-SMC mediator driver
Thread-Index: 
 AQHYHRW24Dmb0qV8ZkqAv39Pf6/nVayODW6AgAAg+ICAAAmzAIABqiEAgAMLQQCAAAQDgIAABruAgACrggCAAtruAA==
Date: Wed, 16 Feb 2022 17:41:25 +0000
Message-ID: <20220216174124.GA651931@EPUAKYIW015D>
References: <cover.1644341635.git.oleksii_moisieiev@epam.com>
 <cb1493f5d9b5c3437268054b4a8e345cb35c8708.1644341635.git.oleksii_moisieiev@epam.com>
 <F9811680-C6EC-4372-A451-5C1DA279E35E@arm.com>
 <20220211104403.GA2291814@EPUAKYIW015D>
 <A9FF3FBC-C29D-4A17-8737-EBABEF240BA2@arm.com>
 <c13f6312-3922-4504-3248-e2e4701b1a10@xen.org>
 <20220214111300.GA3615313@EPUAKYIW015D>
 <E78206B4-3793-498E-A580-F0561DF6D4AC@arm.com>
 <20220214115127.GA3637134@EPUAKYIW015D>
 <alpine.DEB.2.22.394.2202141355150.4183037@ubuntu-linux-20-04-desktop>
In-Reply-To: 
 <alpine.DEB.2.22.394.2202141355150.4183037@ubuntu-linux-20-04-desktop>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 71c67647-1fbd-4dbd-3f70-08d9f1738dd1
x-ms-traffictypediagnostic: DB7PR03MB4185:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <DB7PR03MB41856BFBD587046E34BEDD70E3359@DB7PR03MB4185.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 4oQvI9bKTcYy656L9h/aR/GGAWt3s/2SrnJWWwVAxp0Yw6SEuuYC4frlTtahc/MG5CWy24/mE/Z4R4u5gQ750hr6B13v4U7pKsgUX1IgstJHAnCOCZ73Q+4miKgnp1rGeVm+jprh3YIe3PwZw7Q2VrjPR/WFuf3xkTyljpgzOO+rbby3W5xN5aIqIfKjUDbosZwfIVhDzLTmEo/6xmT9iDZteLqpLDLm7EL3s4GvbQx0/li9wtBWWFzj2jo9LnOnpkHYJnpuFEmClTWd9hCdxc1xsCfKiurbdPQhTyQ/QGZqNN+em0OJm+V48eD/e2TM0a+EloAxyJuuoiDpkyuXeUGov8IR5nGhZO2YBgwTTDvB3v+FN2K3kw+5BV8HwpfTUrPAncU8mY90Ey1egG9CtGz4flYSPxdHjzF3gaZcTqnCY1tetpTM2LF0XBes1A9h0X9eXzUc9LmF7Puhwjr/rKTttRo8ecyLam008Yh4Q+Fj7KGn+UYMg2oKOhhK13yrqyF97w6F2w+pxY8TnWAnE+2Wb35uwrl6AhXg5R8VIP11aDW13u73uP3/XeHoGadjj3TCIzF9wbvZVtj3/k5hxiboz0I9JsEmc0lOgEbKOICA4/3cV4h4RCBtFnx7yGyMqcARs7eLrw+H4o2YydjtNK37lJeO6h4SywDaSrCj7/UyMfZFmOkPtzmWkvshP1YU0QN7VPpKrOtcAU4v9fMg1PBFF41YG92d2E/eCzc5pt9MhSasmGO1uYWw5sdWFx7+tdidI7+zXb6Yp+dPC14EUDuibCCmdEyi32icm4WhPKsRM5dJraKOYqGe3wfoAa0lYRXrN5NEgQSBRytOsysIUA==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR03MB7136.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(6916009)(53546011)(33716001)(71200400001)(86362001)(8936002)(54906003)(38100700002)(6486002)(966005)(316002)(508600001)(33656002)(6512007)(9686003)(5660300002)(6506007)(107886003)(83380400001)(26005)(8676002)(2906002)(38070700005)(66476007)(66556008)(64756008)(66446008)(91956017)(76116006)(66946007)(186003)(1076003)(122000001)(4326008);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?RdB6JCdqgWFUc/B2WQRX6nD44TsdirMPM6Ii54q6iD0fcJRTbxYAPRAER6+X?=
 =?us-ascii?Q?kuRIXiGxPzHhlgsmDJ+9IFDxDB1TpFsN00E9cpgkVJfuhIrFVhEyNb1Hzfjp?=
 =?us-ascii?Q?oRD5cuB0BMU+THV1RTSIftiTvKDyTojhlLaDNdou82SAS24nQcdZPVMBugbW?=
 =?us-ascii?Q?906dAbWc0e4+GEcmrcIOZSa3o61bAoJ2wv9idjaerctJHVTkVIfJOk7R5Vr0?=
 =?us-ascii?Q?RJxl8v02ve+u7EgCpoH6d4RJJtLrLBAgD4orR2i3WZN9UOT4z1dUGjFLhtLc?=
 =?us-ascii?Q?Jb/xA7SkRMw2jlGOgSzOVUzCoCbjHA0wyDuhnbAqCG7y53YGquxnNTCfKOg4?=
 =?us-ascii?Q?wSb6DGO+Htb7QHSGaYYlvJinaHtGsZ+u597iYSfjN80jrERQrSz9XbhW3QG8?=
 =?us-ascii?Q?YCK2WWiIwNKb1r9kMany162swiaRPAZmFxfZDUgz+t8HZTtm734l4Nc62QVK?=
 =?us-ascii?Q?6xJs1Sp/94CCHrFkOgQxmm5yF65JIgSaCDETWZAWSlduZXD9JiB/xEgUJHql?=
 =?us-ascii?Q?OrY0fOzB1ryNSUtsDhjZ+FmdTO4ZdP/jNWbTrbFwPWYbUjB38hKO1AwW1c/L?=
 =?us-ascii?Q?mbgnZi6JefaRwDoPZkKU990StJFUqjTy3ig98XrRRG2V15b76nbV1NVO7jo5?=
 =?us-ascii?Q?ikA8WBB7mKAEyQ1JErLHpm0jFF55b24vFBPiFvjmqlPZuJDiaTYQmgZZUZh1?=
 =?us-ascii?Q?TiMLHGrt718lqZhkuA4PsbRdWs5aFbyj71VeLfOegrR0cJ0kYamRrjFABgbp?=
 =?us-ascii?Q?Hb5puumbwdeIOJ6K6WFqz+oN8AG8AUpmtcB8EFpK+SshN5EI1RT8EwhvRalW?=
 =?us-ascii?Q?BavJJE7A4TPYgNjwS7BQrSSMcW40tpNg7xLYcbg32FWKVHoTZG9YCWWsnwSO?=
 =?us-ascii?Q?jO8wQ7L4BeBU7NoWwME/VV4nzJ1fgs/55FBhbj44nrl4lZAgO05ckPERzgyC?=
 =?us-ascii?Q?txU9ufaAki0Uglg85ozyTh3PWk0AJ2z4sRqjdP+QTGM648O8kg400YCKQc7G?=
 =?us-ascii?Q?eEfjQPUZmDuzRvBD/jr/5y7oPZClpcbUFY31T2gEHvaYCDRL/RMBnEeYw9B9?=
 =?us-ascii?Q?sNH/R5GvNbMa+x1R159AU1nOTzAHYzFzSsIIkKgQkEwR3WeCXKUvc3ZriQAS?=
 =?us-ascii?Q?Tppco1/q765EqDZx6bUSQN4ILUReSLzJfbHUQQT4R6J9VCK/ITBfqAjD6mKz?=
 =?us-ascii?Q?YazdFuTAOEMqKYUqNKPErEqGvYY63Pc/vtrIEb3W3bYi0gFcR7xQDg9FlnYd?=
 =?us-ascii?Q?iEY8HkjyvksIk5XudWq5UM+q/paS6sNMUTtxZzf4AIctLIci+YmkoV7YiYii?=
 =?us-ascii?Q?6btuKeOVq4NTjrgbJheuetVKcoYsViYAm4kdTjvDvPdLEbNtsMXwKrbGV0EY?=
 =?us-ascii?Q?JEnpieBJyk1rJYd1BYo2hsQdP/tpMn/JGXnlCt49Y8HTsWo60CV9Ku6/drtV?=
 =?us-ascii?Q?KP4gyyO733FMse4cZhnPaTsyE3bb3ohxP1WbNI9kVMHdur4fRzxLtq5aghI1?=
 =?us-ascii?Q?99lPZ1Ca9wH5r3UCGvq2aELKEAzf+CMxe77CkZDml09y3q7dkOg6KvUtTuXB?=
 =?us-ascii?Q?Z0MVQ72+idTxFHGr0ZdtkP3XQWdeQ8Q8sZoldmoJCkKXZJD/ACAzxFYOY1ul?=
 =?us-ascii?Q?xmvoKVFC2zo4zjH6cmum4r6K4CTsrE3ygygXllWjnCago+ynUAdKwLDsnNbq?=
 =?us-ascii?Q?S80q3sNZftTZ5sFx4ywad2uNw38=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <DFF6AF0E31EE8248888FCB561C078CE0@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR03MB7136.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 71c67647-1fbd-4dbd-3f70-08d9f1738dd1
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Feb 2022 17:41:25.1543
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: DwZRR42oTbdoXqi8IiNSu5OC/7h3KDXzIn8/H0iBZeBTWUUXB7ZdOd8KUqHaUHqbEgSfnaO70JjSMs0e+JtFSFunZXI0tzde9aSA1UEM/x4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR03MB4185
X-Proofpoint-ORIG-GUID: E_SY76v2ChxxDTNXgVMnlBQXimE13RLy
X-Proofpoint-GUID: E_SY76v2ChxxDTNXgVMnlBQXimE13RLy
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-16_08,2022-02-16_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0
 lowpriorityscore=0 malwarescore=0 impostorscore=0 mlxlogscore=999
 adultscore=0 mlxscore=0 bulkscore=0 spamscore=0 priorityscore=1501
 phishscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202160100

Hi Stefano,

On Mon, Feb 14, 2022 at 02:05:18PM -0800, Stefano Stabellini wrote:
> On Mon, 14 Feb 2022, Oleksii Moisieiev wrote:
> > Hi Bertrand,
> >=20
> > On Mon, Feb 14, 2022 at 11:27:21AM +0000, Bertrand Marquis wrote:
> > > Hi Oleksii,
> > >=20
> > > > On 14 Feb 2022, at 11:13, Oleksii Moisieiev <Oleksii_Moisieiev@epam=
.com> wrote:
> > > >=20
> > > > Hi Julien,
> > > >=20
> > > > On Sat, Feb 12, 2022 at 12:43:56PM +0000, Julien Grall wrote:
> > > >> Hi,
> > > >>=20
> > > >> On 11/02/2022 11:18, Bertrand Marquis wrote:
> > > >>> Do you plan to add support for other boards ?
> > > >>>=20
> > > >>> Did you discuss more in general with the linux kernel guys to see=
 if this
> > > >>> approach was agreed and will be adopted by other manufacturers ?
> > > >>>=20
> > > >>> All in all I think this is a good idea but I fear that all this w=
ill actually only
> > > >>> be used by one board or one manufacturer and other might use a di=
fferent
> > > >>> strategy, I would like to unrisk this before merging this in Xen.
> > > >>=20
> > > >> In the past we merged code that would only benefits one vendor (i.=
e. EEMI).
> > > >> That said, this was a vendor specific protocol. I believe the situ=
ation is
> > > >> different here because the spec is meant to be generic.
> > > >>=20
> > > >>> @julien and Stefano: what is your view here ?
> > > >>=20
> > > >> I share the same concerns as you. I think we need to make sure all=
 the
> > > >> pieces we rely on (e.g. firmware, DT bindings) have been agreed be=
fore we
> > > >> can merge such code in Xen.
> > > >>=20
> > > >> The first step is to have all the pieces available in public so th=
ey can be
> > > >> reviewed and tested together.
> > > >>
> > > >> Oleksii, on a separate e-mail, you said you made change for ATF. H=
ow much of
> > > >> those changes was related to support for Xen? If they are some, th=
en I think
> > > >> they should be upstreamed first.
> > > >>=20
> > > >=20
> > > > Let me share changes, that were done to AT-F and Linux kernel
> > > > device-tree in terms of the SCMI mediator POC.
> > > > Changes to the Linux kernel:
> > > > https://urldefense.com/v3/__https://github.com/oleksiimoisieiev/arm=
-trusted-firmware/pull/4__;!!GF_29dbcQIUBPA!je9Cu0n0498Yn76OLWjxxVaB7jWJtyW=
ycHX0YARezTnc7aYHpGRJ8tSxHqIC0fTMUUSV$ [github[.]com]
> > > > Based on renesas-rcar linux-bsp, branch v5.10/rcar-5.0.0.rc5
> > > >=20
> > > > Changes to AT-F:
> > > > https://urldefense.com/v3/__https://github.com/oleksiimoisieiev/lin=
ux-bsp/pull/3__;!!GF_29dbcQIUBPA!je9Cu0n0498Yn76OLWjxxVaB7jWJtyWycHX0YARezT=
nc7aYHpGRJ8tSxHqIC0eDKS3ge$ [github[.]com]
> > > > Based on renesas-rcar/arm-trusted-firmware branch rcar_gen3_v2.5.
> > >=20
> > > You inverted the links but thanks this is really useful.
> > >=20
> >=20
> > That's strange. Links looks good from xen.markmail.org interface.
> >=20
> > > Did you push the ATF changes to mainstream ATF or discuss those with
> > > the maintainers ?
> >=20
> > No. We did changes in ATF as a proof of concept.
> >=20
> > >=20
> > > The strategy overall is nice but we need to make sure this is accepte=
d and
> > >  merged by all parties (ATF and Linux) to make sure the support for t=
his will
> > > not only be available in Xen and for one board.
>=20
> +1
>=20
>=20
> > I've prepared patch to Linux kernel, which is introducing scmi_devid
> > binding, needed to set device permissions via SCMI. I've contacted
> > Sudeep Holla <sudeep.holla@arm.com>, who is the maintainer of the SCMI =
protocol
> > drivers. Waiting for the response.
> >=20
> > Changes to ATF are not Xen specific and were done in terms of POC. We d=
o
> > not have plans to upstream those changes right now.
>=20
> If this work relies on a new interface in ATF, and the interface is not
> vendor-specific, then at least the interface (if not the code) should be
> reviewed and accepted by ATF.
>=20
> Otherwise we risk ending up with an upstream SCMI implementation in Xen
> that cannot be used anywhere, except the PoC. To make things worse, this
> could happen:
>=20
> - we upstream the SCMI mediator to Xen
> - we upstream any required changes to Linux
> - ATF rejects the SCMI-related interface changes
> - ATF comes up with a difference interface
>=20
> At this point we would have to deprecate the implementation in Xen. It
> might also be difficult to do so due to versioning issues. We would
> need to be able to detect which version of ATF we are running on, to
> distinguish the ATF PoC version that works with the old interface from
> the new ATF version that supports a different interface.
>=20
> To avoid this kind of issues we typically expect that all relevant
> communities agree on the public interfaces before upstreaming the code.

That's sound reasonable.
I'll contact with AT-F maintainers. Maybe I'll be able to upstream SCMI
to AT-F.
Also I hope I'll be able to contact Linux kernel SCMI maintainers and
discuss device-tree structure.

Best regards,
Oleksii=


From xen-devel-bounces@lists.xenproject.org Wed Feb 16 17:42:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 17:42:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274339.469788 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKOJR-0006v0-DI; Wed, 16 Feb 2022 17:41:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274339.469788; Wed, 16 Feb 2022 17:41:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKOJR-0006ur-A3; Wed, 16 Feb 2022 17:41:57 +0000
Received: by outflank-mailman (input) for mailman id 274339;
 Wed, 16 Feb 2022 17:41:56 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mysP=S7=gmail.com=xadimgnik@srs-se1.protection.inumbo.net>)
 id 1nKOJQ-0006uC-Kp
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 17:41:56 +0000
Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com
 [2a00:1450:4864:20::334])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id baaa8ed6-8f4f-11ec-b215-9bbe72dcb22c;
 Wed, 16 Feb 2022 18:41:54 +0100 (CET)
Received: by mail-wm1-x334.google.com with SMTP id
 d14-20020a05600c34ce00b0037bf4d14dc7so2177615wmq.3
 for <xen-devel@lists.xenproject.org>; Wed, 16 Feb 2022 09:41:54 -0800 (PST)
Received: from [10.7.237.11] (54-240-197-227.amazon.com. [54.240.197.227])
 by smtp.gmail.com with ESMTPSA id f6sm17766743wrv.116.2022.02.16.09.41.52
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Wed, 16 Feb 2022 09:41:52 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: baaa8ed6-8f4f-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=message-id:date:mime-version:user-agent:reply-to:subject
         :content-language:to:cc:references:from:in-reply-to
         :content-transfer-encoding;
        bh=HN1cnZIM+2c6AwqG2zJl30d6wjpvV3kxpHsI8UO8ePU=;
        b=D7ytF1NbZChAhiEdKbJ+9KAPftufFNIntajMb6EKGWNKE34sFyCyF5/vS1TG8jHxtC
         W4PxrIkUdfbLFnq1EUoKkAtsI95mdTEc+fLnMdwHz6b/rLvjCZpHVQWdpD5rhE3tSrlj
         f6iQS6g0U0n09xqbX4Mm30O8XeVEED+f8M0aL/5nh1R3cUVuq/0fnY/JG7LtHQRaiLeK
         uUS53ZR+zffjpBP6Hq+EGHq1LGoAyeoBbOfu6gcb1U9w9TUyyVnNEbgx2pQqagZHc0V2
         Ey83QmfGj/d86NkdBNV950azpoNIf5eZaejKPOankqmnEUpO/A0BmrPJiYf1YmG36ajc
         QUpg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:message-id:date:mime-version:user-agent:reply-to
         :subject:content-language:to:cc:references:from:in-reply-to
         :content-transfer-encoding;
        bh=HN1cnZIM+2c6AwqG2zJl30d6wjpvV3kxpHsI8UO8ePU=;
        b=IT6vPzugQKYTvNJuxpSt/JzgPBKs4IMY9xnU1/FEKP6Xv0+heykpjTzj9PVLObqXjT
         o93X+ErnJ4AOP444BlW1k6qB7s1sQbxiPDB/3Cvf5YOXOC3enEALkG66e4uu2xLf2Y85
         iGREV6OiOW/ZaxDwAnnHsfhyZOGX0FsY8XLMc27OJZaO8IR9A+3b4rxbR9sepKSNkc+Z
         W8I3gGHI7eAKH0UkfX7w4mQYbzZnqlotrVlZUfACQ+cPVvPQNOnlsmObA4XKlI+d47Q2
         gvGGdAxVjcVyJfiTEN553CExyB7ZTY5mxuGxhR6CeF61Nb+fUNBdgnoq3axap64uXMaQ
         RtnA==
X-Gm-Message-State: AOAM530aEJ4ZjFOnrMtMsY3VDFhKK+E4cKDXSrEbj8QxdYNZ8Lp/6PNr
	AavDyjmy4xNOQWcfgfO2RfU=
X-Google-Smtp-Source: ABdhPJxgnLkLjbbPKAByVAnZYmcqCVuwZfGZ5bs08g3kJYK7G/pWjkSHQ0+M4Jt2PEnALHmIEm20Yw==
X-Received: by 2002:a05:600c:3d06:b0:37b:a5ea:a61b with SMTP id bh6-20020a05600c3d0600b0037ba5eaa61bmr2651558wmb.32.1645033313513;
        Wed, 16 Feb 2022 09:41:53 -0800 (PST)
Message-ID: <470464ca-f8c4-e95e-9443-1b2b8538490a@gmail.com>
Date: Wed, 16 Feb 2022 17:41:51 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Reply-To: paul@xen.org
Subject: Re: [PATCH v2 RFC 4/5] x86/ioreq: report extended destination ID
 support by emulators
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, paul@xen.org
Cc: xen-devel@lists.xenproject.org, dwmw2@infradead.org,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>
References: <20220216103026.11533-1-roger.pau@citrix.com>
 <20220216103026.11533-5-roger.pau@citrix.com>
 <73c3db96-fbca-9d03-d645-4d44ab6a640f@gmail.com>
 <Ygzgz3PONncqIH16@Air-de-Roger>
From: "Durrant, Paul" <xadimgnik@gmail.com>
In-Reply-To: <Ygzgz3PONncqIH16@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 16/02/2022 11:32, Roger Pau Monné wrote:
> On Wed, Feb 16, 2022 at 10:53:58AM +0000, Durrant, Paul wrote:
>> On 16/02/2022 10:30, Roger Pau Monne wrote:
>>> Introduce a new arch specific field to report whether an emulator
>>> supports the Extended Destination ID field, so that the hypervisor can
>>> refrain from exposing the feature if one of the emulators doesn't
>>> support it.
>>>
>>> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
>>> ---
>>> Changes since v1:
>>>    - New in this version.
>>> ---
>>> RFC: I find this kind of clumsy. In fact fully emulated devices
>>> should already support Extended Destination ID without any
>>> modifications, because XEN_DMOP_inject_msi gets passed the address and
>>> data fields, so the hypervisor extracts the extended destination ID
>>> from there.
>>>
>>> PCI passthrough devices however use xc_domain_update_msi_irq and that
>>> has leaked the gflags parameter in the API, even worse the position
>>> of the flags are hardcoded in QEMU.
>>>
>>> Should the clearing of ext_dest_id be limited to the domain using an
>>> IOMMU?
>>>
>>> RFC: Only enable ext_dest_id if max_cpu > 128? So the device model is
>>> aware the domain must use ext_dest_id? (implies device model knows
>>> APIC ID = CPU ID * 2)
>>
>> There is still only a single sync ioreq server page, so 128 vCPUs is the max
>> possible.
> 
> Right - so device models wanting to support > 128 vCPUs will already
> need to be modified, and hence we could assume that any HVM guests
> with > 128 vCPUs is using a device model capable of handling extended
> destination ID?
> 

Yes, exactly.

   Paul




From xen-devel-bounces@lists.xenproject.org Wed Feb 16 17:56:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 17:56:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274355.469799 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKOXB-0000N9-QX; Wed, 16 Feb 2022 17:56:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274355.469799; Wed, 16 Feb 2022 17:56:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKOXB-0000N2-NB; Wed, 16 Feb 2022 17:56:09 +0000
Received: by outflank-mailman (input) for mailman id 274355;
 Wed, 16 Feb 2022 17:56:08 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=bXi8=S7=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1nKOXA-0000Mw-ES
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 17:56:08 +0000
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01on0604.outbound.protection.outlook.com
 [2a01:111:f400:fe1f::604])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b644cfbf-8f51-11ec-8eb8-a37418f5ba1a;
 Wed, 16 Feb 2022 18:56:06 +0100 (CET)
Received: from AM6P191CA0016.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:8b::29)
 by DB9PR08MB7099.eurprd08.prod.outlook.com (2603:10a6:10:2c4::16) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.14; Wed, 16 Feb
 2022 17:55:48 +0000
Received: from AM5EUR03FT046.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:8b:cafe::e1) by AM6P191CA0016.outlook.office365.com
 (2603:10a6:209:8b::29) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.15 via Frontend
 Transport; Wed, 16 Feb 2022 17:55:48 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT046.mail.protection.outlook.com (10.152.16.164) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4975.11 via Frontend Transport; Wed, 16 Feb 2022 17:55:48 +0000
Received: ("Tessian outbound 1f399c739551:v113");
 Wed, 16 Feb 2022 17:55:48 +0000
Received: from 460c3ec08cdf.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 3052AB91-B80B-4260-9818-332FA2752896.1; 
 Wed, 16 Feb 2022 17:55:40 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 460c3ec08cdf.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 16 Feb 2022 17:55:40 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by VI1PR0801MB1744.eurprd08.prod.outlook.com (2603:10a6:800:5c::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.15; Wed, 16 Feb
 2022 17:55:36 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::aca7:79c4:fa65:dac6]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::aca7:79c4:fa65:dac6%5]) with mapi id 15.20.4995.014; Wed, 16 Feb 2022
 17:55:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b644cfbf-8f51-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=nJ3QIv3gyXxNBpKX4V2oQnb7NclhrJCVNS4iz/AKMdc=;
 b=OePr038BdQvkdV3KzKqOrHDOHKUctu9uXV8GO4w7oeSd2XU2gpayA6qFvzVrEd9HrEykaaczBHcNy/NeGzww//cVLZcw5lZAI4UsPAMmXgXyOdwHu9gSaSOpikbCPoAJw3hw+4K5TdLELyccQieZ3ClyrXe9c9Vvj4fQWgJu8OU=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 7a0bf511ab750d67
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XiEdZw7RJNppa75g0ZklvWe+tqwh4iDu+240N5iTmlWpMKTrCx3PKiMsmoyCiwKjXFG6p6iBexs9dj2ixd1pzA2k6cKEj0o9v+VameXU/PJlUl8RKoRrV1QLrqmUlIxo2iKq6YPGMCAJmsE+NmYBanCX9XteVlV9vjKkxewKx9qutLAtBeNtX4yvzMcJsyAgnxyfLEEJB5ciXiwhqXz4zgaTefMxKfF6Cyu8OxDDvdFVDiQ9LgLadFz670lO6hOaqWWoP2G/FfdZZsEvA/Y+4fqtVEh3NHfttoGNUCOVQuYOIHnsG6BYUc5sl5iWcZHYC04SqqZxa0M0gAs62fFWzA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=nJ3QIv3gyXxNBpKX4V2oQnb7NclhrJCVNS4iz/AKMdc=;
 b=Wx4jyt9y8AAN1Obn8UzpTXA++MhtX628/vdL1QXYFcC2HkQNLZIaJCTA40OD6vFtVs9q4EBWzMSD2gCIg0ZGY3Fk3zmXfbisvoq1HHPOU+Hwu+rKRUedxiNg4OjTy1z7PH2I39DXefUOxbil/OY1/ZGwPuabru3LYhu2odEYO1tn38qbBRrLxZ7cmvH06t5FKBvmzZnbBWuumk39y+ZCrUQegatt2/wNIRzf+uOoLMd8UEnXrFYS6JQxAm96b3jcQkSYBhBEiub0zXSvb4IIV9VP4EIkG0jgkfKwWfwbEqc3kRUmTKQsxMMkOjVFZ1cCR8Gkimbe+dg6lOpSJESsxw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=nJ3QIv3gyXxNBpKX4V2oQnb7NclhrJCVNS4iz/AKMdc=;
 b=OePr038BdQvkdV3KzKqOrHDOHKUctu9uXV8GO4w7oeSd2XU2gpayA6qFvzVrEd9HrEykaaczBHcNy/NeGzww//cVLZcw5lZAI4UsPAMmXgXyOdwHu9gSaSOpikbCPoAJw3hw+4K5TdLELyccQieZ3ClyrXe9c9Vvj4fQWgJu8OU=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <Andrew.Cooper3@citrix.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Wei Liu <wl@xen.org>, Roger Pau Monne
	<roger.pau@citrix.com>, Julien Grall <julien@xen.org>, George Dunlap
	<George.Dunlap@citrix.com>
Subject: Re: [PATCH v2] lib: extend ASSERT()
Thread-Topic: [PATCH v2] lib: extend ASSERT()
Thread-Index:
 AQHYE4sUwaOwwc8tCU249z99fRIDqqyVNw0AgADQBoCAAAHjAIAAIjuAgAACWYCAAAt3gIAAGi0AgAABjYCAAAkmAIAAAikAgAA1qgA=
Date: Wed, 16 Feb 2022 17:55:35 +0000
Message-ID: <289509F3-D0FA-43EA-89B4-8B4BDBA903FA@arm.com>
References: <75125344-b0e1-9663-4c1a-84bb35870fef@suse.com>
 <35d82770-66cf-e030-5bcc-3c030e4463d7@xen.org>
 <3F58400B-5151-42F2-8F39-109DDF50EE1E@arm.com>
 <a89223c8-f59a-24cc-96a7-e40feb28813f@suse.com>
 <DB014136-7797-4A61-9681-33A7D85403AA@citrix.com>
 <732e8e39-36c4-1651-61f3-9b55caf29fe8@suse.com>
 <46408EAE-5EA4-4B22-B685-BA6D313B5D3A@citrix.com>
 <FEF187A8-0A09-4D50-A0E5-F46E014DB3E1@arm.com>
 <63811bb5-cce4-d542-461e-a24926f01b34@suse.com>
 <0BF64A25-F218-404A-8547-4896FCB27E2C@arm.com>
 <99ffa08c-8482-12d2-0ca9-eccde97ecac3@suse.com>
In-Reply-To: <99ffa08c-8482-12d2-0ca9-eccde97ecac3@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3693.60.0.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: b1955e32-d29b-4cae-2973-08d9f1759061
x-ms-traffictypediagnostic:
	VI1PR0801MB1744:EE_|AM5EUR03FT046:EE_|DB9PR08MB7099:EE_
X-Microsoft-Antispam-PRVS:
	<DB9PR08MB7099FA31B3C5856FE8912C9D9D359@DB9PR08MB7099.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 Sm67f6ASxFdJpMSvD8QEtg6K22uzglOY+bwU3MleXaiXTjmFWhumTkFgVB08C+Pvasa0WklD0T5P+BKSo7UCZ/+i435FtoxxLHN4+3pY0/Sli6CwjZoHBvFl9DqxbEo0GdT0dqgdrZDvd/0arXk6LTyuwtWjCSsHffNzAbtGX1p+ypAysndlOyjn+fttvar2AG8SMcMNQha8CEBKbrjbore84qR9LJjcIIFkUwJ+fnLUYBBrAgXkOIC5/UW3X5T7/sqdGFsfx/V6r2v0v3GjPp9ZDHqHDw8CYs3U4SZcM8PDsqQC4zPNFD4t667XNsQdjmFmZhekEtV7+DMkfNK9J2rvu5aramirwRNLrbNm3+06tmAEIpcWFHT70koUhl3cOcOWOh8iW5avZfdKTwIQh//hhmO5Jv52JIAwhrSghxn94ptG7IX0BjDSnZc8mA8dRBhR9HUsMq3cwm+bTX5n0X5fDH21equLqTYQgwouQuCmgo/FCzz4/puKZzUAiZ2mp71vN91iUNfSelAuuBxnyFEf4cDaH5Dkx9DJAZwMlWhyZ9nhIMJp5ofvTY4MK5EWJHIa80UtSw8AGu6Hb6QNb3x33mvRF14ZIEJU7LAw7YprODGZiKpGN7RFPt06wJfBnTLSpQnC6LYYA7EIzX+lx2Rpi1QmwLuTBVyru8dDoGHTs0rHQPL1AxxK566HOJ2tiLZ/RJtKhkWbVU+O7vjaSfJThS51FH+vhHZ4JuKIocjSCfqCnLPXCdkdc/xqhNeJ
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(83380400001)(122000001)(38100700002)(38070700005)(66446008)(6512007)(6486002)(76116006)(508600001)(53546011)(6916009)(6506007)(71200400001)(2906002)(54906003)(186003)(36756003)(64756008)(91956017)(26005)(8676002)(4326008)(8936002)(316002)(66556008)(66476007)(66946007)(33656002)(86362001)(5660300002)(2616005)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <52652C1124590C47914D83BC0C4E0769@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB1744
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT046.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	5e0d36ab-7110-4b8a-b05b-08d9f17588ba
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	lYChbeW/7bC24iauCafXXenZD3XyVMKJwuo+T9t/E9V/XiOZRpcj4B88jKS6E96OdvKEFJfqYZGpnm2ZGPt+MSpo0WcE8u03VrU0iZGD74s564aFSAv4s++OI7Ej5f/MxSnaMfFAjMAdE8FtFBhRG/eHi50RQhrHNYYWtkVvAoVLgxgOv8WVxvZMUN3kAgM6VyA69al1maApyaJtSVoAtFB9HBzEGU0VHYhP0zQqOWC6ji/kX97tEO9Mh7vJ7GvyKI++brJfDhjtgSYpa4gGTilSXRa9NpTI2MmMPaM+GqX1c7jWZzyJ5C4VMsM9p/7ctDLnYMDv4oelClu7fElzg+vMteZudHN/B+JpXUERD2SLQUfOVsJE+UzPzHJZjBWHmdJwW/UhrKIuHFjTD/MumstTkExd92QFM1VmUp/ofjJdAy2KH7XrAdnN4NchDJteFTezNWy1SUD35gnxYe18bX841HrVVS76CJTRC+bSvLiQbB3o5DECtLqZwxveW1WrxeEf9DBy/wIKYBxU0T80bIV8oWwlCds1DsMnN1jpLDKbt0RjE1e/uHOOOyDeljNheyCMChy4tkZMn+r02XU66TuzXJja5o9GppS/B3nf3DCKOqI9nU0ngD0BXIcQmG8iWrL1GjIIgkvgXOB+Zc+/mlGtblt8u6nRN6xhRKPvLUKy6vXo2xUJfCD72Vrc/dUi
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(86362001)(70586007)(40460700003)(70206006)(6486002)(36756003)(8936002)(4326008)(36860700001)(6862004)(8676002)(356005)(508600001)(47076005)(81166007)(5660300002)(186003)(336012)(33656002)(26005)(2906002)(53546011)(54906003)(82310400004)(2616005)(316002)(83380400001)(107886003)(6512007)(6506007);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2022 17:55:48.4608
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: b1955e32-d29b-4cae-2973-08d9f1759061
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT046.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7099

SGkgSmFuLA0KDQo+IE9uIDE2IEZlYiAyMDIyLCBhdCAxNDo0MywgSmFuIEJldWxpY2ggPGpiZXVs
aWNoQHN1c2UuY29tPiB3cm90ZToNCj4gDQo+IE9uIDE2LjAyLjIwMjIgMTU6MzUsIEJlcnRyYW5k
IE1hcnF1aXMgd3JvdGU6DQo+PiBIaSBKYW4sDQo+PiANCj4+PiBPbiAxNiBGZWIgMjAyMiwgYXQg
MTQ6MDMsIEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4gd3JvdGU6DQo+Pj4gDQo+Pj4g
T24gMTYuMDIuMjAyMiAxNDo1NywgQmVydHJhbmQgTWFycXVpcyB3cm90ZToNCj4+Pj4+IE9uIDE2
IEZlYiAyMDIyLCBhdCAxMjoyMywgR2VvcmdlIER1bmxhcCA8R2VvcmdlLkR1bmxhcEBjaXRyaXgu
Y29tPiB3cm90ZToNCj4+Pj4+PiBPbiBGZWIgMTYsIDIwMjIsIGF0IDExOjQyIEFNLCBKYW4gQmV1
bGljaCA8amJldWxpY2hAc3VzZS5jb20+IHdyb3RlOg0KPj4+Pj4+IE9uIDE2LjAyLjIwMjIgMTI6
MzQsIEdlb3JnZSBEdW5sYXAgd3JvdGU6DQo+Pj4+Pj4+IEkgYW0gb3Bwb3NlZCB0byBvdmVybG9h
ZGluZyDigJxBU1NFUlTigJ0gZm9yIHRoaXMgbmV3IGtpbmQgb2YgbWFjcm87IEkgdGhpbmsgaXQg
d291bGQgbm90IG9ubHkgYmUgdW5uZWNlc3NhcmlseSBjb25mdXNpbmcgdG8gcGVvcGxlIG5vdCBm
YW1pbGlhciB3aXRoIG91ciBjb2RlYmFzZSwgYnV0IGl0IHdvdWxkIGJlIHRvbyBlYXN5IGZvciBw
ZW9wbGUgdG8gZmFpbCB0byBub3RpY2Ugd2hpY2ggbWFjcm8gd2FzIGJlaW5nIHVzZWQuDQo+Pj4+
Pj4+IA0KPj4+Pj4+PiBBU1NFUlRfQUNUSU9OKGNvbmRpdGlvbiwgY29kZSkgKG9yIGV2ZW4gQVNT
RVJUX09SX0FDVElPTigpKSB3b3VsZCBiZSBhIGJhcmUgbWluaW11bSBmb3IgbWUuDQo+Pj4+Pj4+
IA0KPj4+Pj4+PiBCdXQgSSBjYW7igJl0IGltYWdpbmUgdGhhdCB0aGVyZSBhcmUgbW9yZSB0aGFu
IGEgaGFuZGZ1bCBvZiBhY3Rpb25zIHdlIG1pZ2h0IHdhbnQgdG8gdGFrZSwgc28gZGVmaW5pbmcg
YSBtYWNybyBmb3IgZWFjaCBvbmUgc2hvdWxkbuKAmXQgYmUgdG9vIGJ1cmRlbnNvbWUuDQo+Pj4+
Pj4+IA0KPj4+Pj4+PiBGdXJ0aGVybW9yZSwgdGhlIHZlcnkgZmxleGliaWxpdHkgc2VlbXMgZGFu
Z2Vyb3VzOyB5b3XigJlyZSBub3Qgc2VlaW5nIHdoYXQgYWN0dWFsIGNvZGUgaXMgZ2VuZXJhdGVk
LCBzbyBpdOKAmXMgdG8gZWFzeSB0byBiZSDigJxjbGV2ZXLigJ0sIGFuZC9vciB3cml0ZSBjb2Rl
IHRoYXQgZW5kcyB1cCBkb2luZyBzb21ldGhpbmcgZGlmZmVyZW50IHRoYW4geW91IGV4cGVjdC4N
Cj4+Pj4+Pj4gDQo+Pj4+Pj4+IEF0IHRoZSBtb21lbnQgSSB0aGluayBBU1NFUlRfT1JfUkVUVVJO
KGNvbmRpdGlvbiwgY29kZSksIHBsdXMgb3RoZXIgbmV3IG1hY3JvcyBmb3IgdGhlIG90aGVyIGJl
aGF2aW9yIGlzIG5lZWRlZCwgd291bGQgYmUgYmV0dGVyLg0KPj4+Pj4+IA0KPj4+Pj4+IEhtbSwg
d2hpbGUgSSBzZWUgeW91ciBwb2ludCBvZiB0aGluZ3MgcG9zc2libHkgbG9va2luZyBjb25mdXNp
bmcgb3INCj4+Pj4+PiB1bmV4cGVjdGVkLCBzb21ldGhpbmcgbGlrZSBBU1NFUlRfT1JfUkVUVVJO
KCkgKHNob3VsZG4ndCBpdCBiZQ0KPj4+Pj4+IEFTU0VSVF9BTkRfUkVUVVJOKCk/KSBpcyBpbW8g
bGVzcyByZWFkYWJsZS4gSW4gcGFydGljdWxhciBJIGRpc2xpa2UNCj4+Pj4+PiB0aGUgbGFyZ2Vy
IGFtb3VudCBvZiB1cHBlcmNhc2UgdGV4dC4gQnV0IHllcywgSSBjb3VsZCBhY2NlcHQgdGhpcw0K
Pj4+Pj4+IGFzIGEgY29tcHJvbWlzZSBhcyBpdCBzdGlsbCBzZWVtcyBiZXR0ZXIgdG8gbWUgdGhh
biB0aGUgbXVsdGktbGluZQ0KPj4+Pj4+IGNvbnN0cnVjdHMgd2UgY3VycmVudGx5IHVzZS4NCj4+
Pj4+IA0KPj4+Pj4gSSBzZWUgd2hhdCB5b3XigJlyZSBzYXlpbmcgd2l0aCBBTkQvT1I7IEkgcGVy
c29uYWxseSBzdGlsbCBwcmVmZXIgT1IgYnV0IHdvdWxkbuKAmXQgYXJndWUgdG8gaGFyZCBhZ2Fp
bnN0IEFORCBpZiBvdGhlcnMgcHJlZmVycmVkIGl0Lg0KPj4+Pj4gDQo+Pj4+PiBBcyBmYXIgYXMg
SeKAmW0gY29uY2VybmVkLCB0aGUgZmFjdCB0aGF0IHdl4oCZcmUgcmVkdWNpbmcgbGluZXMgb2Yg
Y29kZSBpc27igJl0IGEgcmVhc29uIHRvIHVzZSB0aGlzIGF0IGFsbC4gIEFzIG91ciBDT0RJTkdf
U1RZTEUgc2F5cywgQVNTRVJUKCkgaXMganVzdCBhIGxvdWRlciBwcmludGsuICBXZSB3b3VsZCBu
ZXZlciBjb25zaWRlciB3cml0aW5nIFBSSU5US19BTkRfUkVUVVJOKCksIGFuZCB3ZSB3b3VsZCBu
ZXZlciBjb25zaWRlciB3cml0aW5nIGEgbWFjcm8gbGlrZSBDT05EUkVUKGNvbmRpdGlvbiwgcmV0
dmFsKSB0byByZXBsYWNlDQo+Pj4+PiANCj4+Pj4+IGlmIChjb25kaXRpb24pDQo+Pj4+PiAgcmV0
dXJuIHJldHZhbDsNCj4+Pj4+IA0KPj4+Pj4gVGhlIG9ubHkganVzdGlmaWNhdGlvbiBmb3IgdGhp
cyBraW5kIG9mIG1hY3JvLCBpbiBteSBvcGluaW9uLCBpcyB0byBhdm9pZCBkdXBsaWNhdGlvbiBl
cnJvcnM7IGkuZS4gcmVwbGFjaW5nIHlvdXIgY29kZSBzZWdtZW50IHdpdGggdGhlIGZvbGxvd2lu
ZzoNCj4+Pj4+IA0KPj4+Pj4gaWYgKGNvbmRpdGlvbikgew0KPj4+Pj4gIEFTU0VSVCghY29uZGl0
aW9uKTsNCj4+Pj4+ICByZXR1cm4gZm9vOw0KPj4+Pj4gfQ0KPj4+Pj4gDQo+Pj4+PiBpcyB1bmRl
c2lyYWJsZSBiZWNhdXNlIHRoZXJl4oCZcyB0b28gbXVjaCByaXNrIHRoYXQgdGhlIGNvbmRpdGlv
bnMgd2lsbCBkcmlmdCBvciBiZSBpbnZlcnRlZCBpbmNvcnJlY3RseS4gQnV0IGhhdmluZyBjb250
cm9sIHN0YXRlbWVudHMgbGlrZSDigJhyZXR1cm7igJkgYW5kIOKAmGNvbnRpbnVl4oCZIGluIGEg
bWFjcm8gaXMgYWxzbyB1bmRlc2lyYWJsZSBpbiBteSBvcGluaW9uOyBJ4oCZbSBwZXJzb25hbGx5
IG5vdCBzdXJlIHdoaWNoIEkgZmluZCBtb3N0IHVuZGVzaXJhYmxlLg0KPj4+Pj4gDQo+Pj4+PiBJ
IGd1ZXNzIG9uZSBhZHZhbnRhZ2Ugb2Ygc29tZXRoaW5nIGxpa2UgQVNTRVJUX09SKGNvbmRpdGlv
biwgcmV0dXJuIGZvbyk7IG9yIEFTU0VSVF9PUihjb25kaXRpb24sIGNvbnRpbnVlKTsgaXMgdGhh
dCBzZWFyY2hpbmcgZm9yIOKAnHJldHVybuKAnSBvciDigJxjb250aW51ZeKAnSB3aWxsIGNvbWUg
dXAgZXZlbiBpZiB5b3XigJlyZSBkb2luZyBhIGNhc2Utc2Vuc2l0aXZlIHNlYXJjaC4gIEJ1dCBJ
4oCZbSBzdGlsbCB3YXJ5IG9mIHVuaW50ZW5kZWQgc2lkZSBlZmZlY3RzLg0KPj4+Pj4gDQo+Pj4+
PiBCZXJ0cmFuZCAvIEp1bGllbiwgYW55IG1vcmUgdGhvdWdodHM/DQo+Pj4+IA0KPj4+PiBJIHRo
aW5rIHRoYXQgaGF2aW5nIG1hY3JvcyB3aGljaCBhcmUgbWFnaWMgbGlrZSB0aGF0IG9uZSB3aGlj
aCBpbmNsdWRlcyBhIHBvc3NpYmxlIHJldHVybiBhbmQgdGhlIGZhY3QgdGhhdCB0aGUgbWFjcm8g
aXMgdGFraW5nIGNvZGUgYXMgYXJndW1lbnQgaXMgbWFraW5nIHRoZSBjb2RlIHJlYWxseSBoYXJk
IHRvIHJlYWQgYW5kIHVuZGVyc3RhbmQgZm9yIHNvbWVvbmUgbm90IGtub3dpbmcgdGhpcy4NCj4+
Pj4gRXZlbiB0aGUgY29kZSBpcyBsb25nZXIgcmlnaHQgbm93LCBpdCBpcyBtb3JlIHJlYWRhYmxl
IGFuZCBlYXN5IHRvIHVuZGVyc3RhbmQgd2hpY2ggbWVhbnMgbGVzcyBjaGFuY2UgZm9yIGVycm9y
cyBzbyBJIGRvIG5vdCB0aGluayB0aGUgbWFjcm8gd2lsbCBhdm9pZCBlcnJvcnMgYnV0IG1pZ2h0
IGluIGZhY3QgaW50cm9kdWNlIHNvbWUgaW4gdGhlIGZ1dHVyZS4NCj4+Pj4gDQo+Pj4+IFNvIEkg
YW0gdm90aW5nIHRvIGtlZXAgdGhlIGN1cnJlbnQgbWFjcm8gYXMgaXQgaXMuDQo+Pj4gDQo+Pj4g
QnV0IHlvdSByZWNhbGwgdGhhdCB0aGVyZSB3ZXJlIHR3byBhc3BlY3RzIHRvIG1lIHdhbnRpbmcg
dGhlIHN3aXRjaD8NCj4+PiAoU291cmNlKSBjb2RlIHNpemUgd2FzIG9ubHkgb25lLiBUaGUgb3Ro
ZXIgd2FzIHRoYXQgQVNTRVJUX1VOUkVBQ0hBQkxFKCkNCj4+PiBkb2Vzbid0IHNob3cgdGhlIG9y
aWdpbmFsIGV4cHJlc3Npb24gd2hpY2ggaGFzIHRyaWdnZXJlZCB0aGUgZmFpbHVyZSwNCj4+PiB1
bmxpa2UgQVNTRVJUKCkgZG9lcy4NCj4+IA0KPj4gU29ycnkgSSBmb2N1c2VkIG9uIHRoZSBtYWNy
byBwYXJ0IGFmdGVyIEp1bGllbiBhc2tlZCBtZSB0byBjb21tZW50IGZyb20gdGhlIEZ1c2EgcG9p
bnQgb2Ygdmlldy4NCj4+IA0KPj4gVGhlIHVzdWFsIGV4cGVjdGF0aW9uIGlzIHRoYXQgYW4gQVNT
RVJUIHNob3VsZCBuZXZlciBvY2N1ciBhbmQgaXMgYW4gaGVscCBmb3IgdGhlIHByb2dyYW1tZXIg
dG8gZGV0ZWN0IHByb2dyYW1taW5nIGVycm9ycy4gVXN1YWxseSBhbiBhc3NlcnQgaXMgY3Jhc2hp
bmcgdGhlIGFwcGxpY2F0aW9uIHdpdGggYW4gaW5mb3JtYXRpb24gb2Ygd2hlcmUgYW4gYXNzZXJ0
IHdhcyB0cmlnZ2VyZWQuDQo+PiBJbiB0aGUgY3VycmVudCBjYXNlLCB0aGUgYXNzZXJ0IGlzIHVz
ZWQgYXMgZGVidWcgcHJpbnQgYW5kIGluIHByb2R1Y3Rpb24gbW9kZSBhbiBlcnJvciBpcyByZXR1
cm5lZCBpZiB0aGlzIGlzIGhhcHBlbmluZyB3aXRob3V0IGFueSBwcmludC4gSXNu4oCZdCB0aGlz
IGEgZGVidWcgcHJpbnQgY2FzZSBpbnN0ZWFkIG9mIGFuIGFzc2VydCA/DQo+IA0KPiBEZXBlbmRz
IG9uIHRoZSB0ZXJtaW5vbG9neSB5b3Ugd2FudCB0byB1c2U6IE91ciBBU1NFUlQoKSBpcyBpbiBu
byB3YXkNCj4gZGlmZmVyZW50IGluIHRoaXMgcmVnYXJkIGZyb20gdGhlIEMgc3RhbmRhcmQncyBh
c3NlcnQoKS4gVGhlIG1lc3NhZ2UNCj4gbG9nZ2VkIGlzIG9mIGNvdXJzZSB0byBhaWQgdGhlIGRl
dmVsb3BlcnMuIEJ1dCBwZXJzb25hbGx5IEknZCBjYWxsIGl0DQo+IG1vcmUgdGhhbiBqdXN0IGEg
ImRlYnVnIHByaW50Ii4NCg0KQnV0IGl0IHdpbGwgYmUgaWYgd2UgY2hhbmdlIGl0LiBCdXQgSSBh
Z3JlZSB3aXRoIHlvdSBpdCBpcyBtb3JlIHRoYW4gYSBkZWJ1ZyBwcmludC4NCg0KQmVydHJhbmQN
Cg0KPiANCj4gSmFuDQoNCg==


From xen-devel-bounces@lists.xenproject.org Wed Feb 16 19:31:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 19:31:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274363.469810 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKQ18-0001J8-TU; Wed, 16 Feb 2022 19:31:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274363.469810; Wed, 16 Feb 2022 19:31:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKQ18-0001J1-Pg; Wed, 16 Feb 2022 19:31:10 +0000
Received: by outflank-mailman (input) for mailman id 274363;
 Wed, 16 Feb 2022 19:31:08 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nKQ16-0001Ir-RH; Wed, 16 Feb 2022 19:31:08 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nKQ16-0007RM-OG; Wed, 16 Feb 2022 19:31:08 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nKQ16-0006kn-9C; Wed, 16 Feb 2022 19:31:08 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nKQ16-0003Fq-8h; Wed, 16 Feb 2022 19:31:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=VqfectJqNpaWWxmXzyisGLc1OgG7RyWsR5T47r19GDw=; b=n9DYdyW5NvkMNlFFKjWBCPaKtz
	kYRSCp887UuJHoO/vuo+QpCqMbuswdD1hgEzW/MAJalE80Fja0WNvQ3rHr4Ri3MNUR/DEwcF/AQ5e
	NQg0FX0FfH5GsiF7UwqtRCLkoig1b77N2MFijfoD5IVgaOabaTtS9XGo9mrPcUBa3Hq0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168131-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 168131: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=8a576733162bb72afb4d1eb3012b0aef8d265018
X-Osstest-Versions-That:
    ovmf=c28e376edc46e6db6e4a551c94b6ac90df0d8d6e
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 16 Feb 2022 19:31:08 +0000

flight 168131 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168131/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 8a576733162bb72afb4d1eb3012b0aef8d265018
baseline version:
 ovmf                 c28e376edc46e6db6e4a551c94b6ac90df0d8d6e

Last test of basis   168127  2022-02-16 07:13:58 Z    0 days
Testing same since   168131  2022-02-16 12:13:29 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  MohammedX Rehan <mohammedx.rehan@intel.com>
  Rehan, MohammedX <mohammedx.rehan@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   c28e376edc..8a57673316  8a576733162bb72afb4d1eb3012b0aef8d265018 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Wed Feb 16 19:47:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 19:47:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274375.469825 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKQGw-0002uu-Ae; Wed, 16 Feb 2022 19:47:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274375.469825; Wed, 16 Feb 2022 19:47:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKQGw-0002un-7U; Wed, 16 Feb 2022 19:47:30 +0000
Received: by outflank-mailman (input) for mailman id 274375;
 Wed, 16 Feb 2022 19:47:28 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nKQGu-0002ud-T2; Wed, 16 Feb 2022 19:47:28 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nKQGu-0007iX-Pz; Wed, 16 Feb 2022 19:47:28 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nKQGu-0007bi-Gx; Wed, 16 Feb 2022 19:47:28 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nKQGu-0005Og-GU; Wed, 16 Feb 2022 19:47:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Ot8zV5lvJAd/Fi7BXP4hsJWjuOxZn5dOYed186La0DY=; b=LoMVUav95O8Bs1TqY10us7h46d
	G/lMHWJ+mDk3ynhk7GGxtDc6YJGeW6EZd7mxbrmdZqocR8I21tFx5oLlIV4PBoM0UgUA9hvCDqh8r
	81BoTGLs0Wg+/AH9rrBJ6yktm25gOdZg2YWjDQQIwNIMp+bDU3eUJJvxLTXeMornIlww=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168129-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 168129: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=e7c2017cf4a91ab6a0fea6adca2d9dd2ab1603b0
X-Osstest-Versions-That:
    xen=94334d854bd358bd1d9c61d5e3306e4d903b120b
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 16 Feb 2022 19:47:28 +0000

flight 168129 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168129/

Failures :-/ but no regressions.

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds    18 guest-start/debian.repeat fail REGR. vs. 168124

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168124
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168124
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168124
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168124
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168124
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168124
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168124
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168124
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168124
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168124
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168124
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168124
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  e7c2017cf4a91ab6a0fea6adca2d9dd2ab1603b0
baseline version:
 xen                  94334d854bd358bd1d9c61d5e3306e4d903b120b

Last test of basis   168124  2022-02-16 01:53:08 Z    0 days
Testing same since   168129  2022-02-16 11:08:11 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Stefano Stabellini <sstabellini@kernel.org>
  Stefano Stabellini <stefano.stabellini@xilinx.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   94334d854b..e7c2017cf4  e7c2017cf4a91ab6a0fea6adca2d9dd2ab1603b0 -> master


From xen-devel-bounces@lists.xenproject.org Wed Feb 16 20:32:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 20:32:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274388.469836 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKQyO-0007vn-Hq; Wed, 16 Feb 2022 20:32:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274388.469836; Wed, 16 Feb 2022 20:32:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKQyO-0007vg-Ed; Wed, 16 Feb 2022 20:32:24 +0000
Received: by outflank-mailman (input) for mailman id 274388;
 Wed, 16 Feb 2022 20:32:23 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=dggB=S7=gmx.de=deller@srs-se1.protection.inumbo.net>)
 id 1nKQyN-0007va-6T
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 20:32:23 +0000
Received: from mout.gmx.net (mout.gmx.net [212.227.15.19])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8a652e73-8f67-11ec-8eb8-a37418f5ba1a;
 Wed, 16 Feb 2022 21:32:21 +0100 (CET)
Received: from [192.168.20.60] ([92.116.128.232]) by mail.gmx.net (mrgmx005
 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N4hvR-1oJIk801n5-011mvb; Wed, 16
 Feb 2022 21:31:55 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8a652e73-8f67-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;
	s=badeba3b8450; t=1645043515;
	bh=Ybn8l+gnMKMMXvs55hiDNOMPxOVIuTwQZmrqM3YEIT4=;
	h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To;
	b=AntNcnKLyF3jvT6nrcYCG4qX//R6P/jg6GX9PAq9ahEaqC1d66RPjmbHb+W4q1nhN
	 pMU7WD5iY0FX3JDLRsLSlGXye9WL2FfhU+BQo9tN+35Wd+ULtBzJKhMvmm/TuqFOvm
	 IqYpmS3G8VF0HmaztNK8BDpk8AcbiuITor+K4TAE=
X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c
Message-ID: <de2cbd2a-8d0d-8678-e514-b153d04546cc@gmx.de>
Date: Wed, 16 Feb 2022 21:30:26 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v6 00/21] Introduce power-off+restart call chain API
Content-Language: en-US
To: "Rafael J. Wysocki" <rafael@kernel.org>,
 Dmitry Osipenko <digetx@gmail.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
 linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org,
 linux-m68k@lists.linux-m68k.org,
 "open list:BROADCOM NVRAM DRIVER" <linux-mips@vger.kernel.org>,
 linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org,
 Linux-sh list <linux-sh@vger.kernel.org>, xen-devel@lists.xenproject.org,
 ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
 Linux PM <linux-pm@vger.kernel.org>,
 linux-tegra <linux-tegra@vger.kernel.org>,
 Thierry Reding <thierry.reding@gmail.com>,
 Jonathan Hunter <jonathanh@nvidia.com>, Russell King
 <linux@armlinux.org.uk>, Catalin Marinas <catalin.marinas@arm.com>,
 Will Deacon <will@kernel.org>, Guo Ren <guoren@kernel.org>,
 Geert Uytterhoeven <geert@linux-m68k.org>, Greg Ungerer
 <gerg@linux-m68k.org>, Joshua Thompson <funaho@jurai.org>,
 Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
 Sebastian Reichel <sre@kernel.org>, Linus Walleij
 <linus.walleij@linaro.org>, Philipp Zabel <p.zabel@pengutronix.de>,
 Greentime Hu <green.hu@gmail.com>, Vincent Chen <deanbo422@gmail.com>,
 "James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
 Michael Ellerman <mpe@ellerman.id.au>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Paul Mackerras <paulus@samba.org>, Paul Walmsley <paul.walmsley@sifive.com>,
 Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>,
 Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,
 the arch/x86 maintainers <x86@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>, Juergen Gross
 <jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>,
 Len Brown <lenb@kernel.org>, Santosh Shilimkar <ssantosh@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
 Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>,
 Pavel Machek <pavel@ucw.cz>, Lee Jones <lee.jones@linaro.org>,
 Andrew Morton <akpm@linux-foundation.org>, Guenter Roeck
 <linux@roeck-us.net>, Daniel Lezcano <daniel.lezcano@linaro.org>,
 Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
 Ulf Hansson <ulf.hansson@linaro.org>, alankao@andestech.com,
 "K . C . Kuen-Chern Lin" <kclin@andestech.com>,
 =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= <mirq-linux@rere.qmqm.pl>
References: <20220130233718.21544-1-digetx@gmail.com>
 <635e8121-fca4-580c-6af5-d9317a2eee1b@gmail.com>
 <CAJZ5v0g0MrBm2+GwctkB7kUyBEt6HTAexRCFFRmTF1UKDrVQ-g@mail.gmail.com>
From: Helge Deller <deller@gmx.de>
In-Reply-To: <CAJZ5v0g0MrBm2+GwctkB7kUyBEt6HTAexRCFFRmTF1UKDrVQ-g@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-Provags-ID: V03:K1:BtWBXH8Hx0gs6H70GSeWdQfjHJJkkJcL0sCha+IYkFzIkqPcTuW
 qKy+2T0ZaFjOf0xL3yRiF1cUpCUYSVgqU7KzwzS+JfDwLwpezAw537tUvZg/2bOLghB+l87
 w3cRaMw1LIHIT6wVzHTvekJyjtx+uVE2jwwagYFCMH9R/cOGUhFKVp6jWY02QQ7l0/6B1hQ
 6lKAfYfgEy3VsBR0gZMrQ==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:m5CRufpR4Nc=:3YY8ipwdQLVft0dePw9YSh
 GUR0lnlWhCPH8e7cGyZuVRF4QTaiMpo/t4CaEOUGLIsLKu9l5M/J0O5M31HNvfJdp+wCixixW
 ethNV9fQwcaghavvR5Ys8j3bZzVgSa7R1OyImZriy57lwfiqdjxLeLcFAKSN2rNhwXo+L/1W0
 CQyzAyysct5pNIn6YhVq+UHJuMW9E5n4xaMMBrwmLs2OCCvppuqotMNUovPjEQwyXKEJ+eFhM
 9yjpXwZ8d3mtYgImVbnKr09+gh/F/wPYXq7eYIpe39d9AbGAEQBSqL/KVOnCktbbcz2QF5Qbk
 4e7AQF9zoGHa9dkqmKwp5ZIdSigW0kvkTZVGQrYpdQk+jIkqYRXSjx48uK1QfjU+0gP6+BazZ
 vHIF29XOsraFmwyXxbJ9z62U6lScuvKK+hcIdwsTDX1ggSkvbxldkEoF5EU5WckNyKgp3gyzH
 DfO65T9j2hzIuIY+WJVtkWoyJeNgSwsFOR7Izo94OQHlrcyx49oOnlwEdPO+nwrmIJBci5bOR
 WOLNQgMmF6kCc29abhcYlGzqUMIWI+FO/fCqXzwMQQmpGHb0yApKLUA4nUq0AMOk6w+NN8w2X
 /FbqL85ikgC66lPN0ooU1nS7KTmmY5exT9d7V9iWM6nLCea6Xm6zHRAIXEdyFZzA8VCkbFnzD
 h2vE8D32H6zqsIt6XTnvWDjRnU13iMkEj3E7cMmMtSopa2Wp8u/DtvdAeO/wkDmneLWInPLs8
 6RgI97ngQ4wqgYy1sPu7EIk9kIRcFo4/RoCxjHgIBkJrc2sI1wfoeqEIWGAnQxL/RmH+OLvYO
 4yVmqq+p6FhQjuDDZ4yhghQDs+3QKjtVbK+8SqzHgH28Ka1VeSb/Sjw00g5YRoCxba1dPjJUz
 745leF9ctWiJ4d2dLvna8gH4qOiznTFUsQruaIlZTRQt2Q4WnGzd6w/B0Yn+xWmbkRgyZHOZI
 uy8YKYBLf5449zcoQ3q6pmGV9kDPV93qDp6c5xvkslulnnJ92iiU/+AhdlS7dUnaoQWw0libs
 PaL7jI3w3bUjzZ86ihC2Hg/wIiAwKaAAUMew3jB75LdA9Od0L63l2pMobL+2iUUq3y+BntMIe
 DlxSKf+Q98mWIw=

On 2/16/22 13:25, Rafael J. Wysocki wrote:
> On Tue, Feb 15, 2022 at 11:00 PM Dmitry Osipenko <digetx@gmail.com> wrot=
e:
>>
>> 31.01.2022 02:36, Dmitry Osipenko =D0=BF=D0=B8=D1=88=D0=B5=D1=82:
>>> Problem
>>> -------
>>>
>>> SoC devices require power-off call chaining functionality from kernel.
>>> We have a widely used restart chaining provided by restart notifier AP=
I,
>>> but nothing for power-off.
>>>
>>> Solution
>>> --------
>>>
>>> Introduce new API that provides both restart and power-off call chains=
.
>>>
>>> Why combine restart with power-off? Because drivers often do both.
>>> More practical to have API that provides both under the same roof.
>>>
>>> The new API is designed with simplicity and extensibility in mind.
>>> It's built upon the existing restart and reboot APIs. The simplicity
>>> is in new helper functions that are convenient for drivers. The
>>> extensibility is in the design that doesn't hardcode callback
>>> arguments, making easy to add new parameters and remove old.
>>>
>>> This is a third attempt to introduce the new API. First was made by
>>> Guenter Roeck back in 2014, second was made by Thierry Reding in 2017.
>>> In fact the work didn't stop and recently arm_pm_restart() was removed
>>> from v5.14 kernel, which was a part of preparatory work started by
>>> Guenter Roeck. I took into account experience and ideas from the
>>> previous attempts, extended and polished them.
>>
>>
>> Rafael and all, do you see anything critical that needs to be improved
>> in this v6?
>>
>> Will be great if you could take this patchset via the power tree if it
>> looks okay, or give an ack.
>
> I need some more time for this, sorry.
>
> I'm a bit concerned about seeing no response to this set from anyone.
>
> It looks like multiple platforms may be affected by it in principle,
> so doesn't anyone care?

I did looked into the whole patch set after applying it locally.

While I agree a new combined API is good, and the beginning looked promisi=
ng,
after some time I started to ask myself if the whole infrastructure might
be a little overdesigned.

Anyway, I tested it and it works for me on parisc.
And it's probably better than what we have today.

Helge


From xen-devel-bounces@lists.xenproject.org Wed Feb 16 21:34:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 21:34:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274397.469847 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKRwY-0005R9-Ck; Wed, 16 Feb 2022 21:34:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274397.469847; Wed, 16 Feb 2022 21:34:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKRwY-0005R2-97; Wed, 16 Feb 2022 21:34:34 +0000
Received: by outflank-mailman (input) for mailman id 274397;
 Wed, 16 Feb 2022 21:34:33 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=6VyC=S7=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nKRwX-0005Qw-9R
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 21:34:33 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 38c4f4e9-8f70-11ec-b215-9bbe72dcb22c;
 Wed, 16 Feb 2022 22:34:31 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 38c4f4e9-8f70-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645047271;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=AgdBK7sUvLgEaiJIffffzhuXLDVk8ixdjkNCD5Km92c=;
  b=gsCWgSUOO38YfxmdJSjmYjnfcVoT1ZPqITlTSudPoroEfzjPSrk9aHUL
   uxlsi2KGtNsO/oRhth1bKyoCX9kOVPSDpMl6ZaJva+TUzI1/thQIaEqen
   aSdlcoxc8cmVjwMaaMTxwwTRIyvKIJqbz5JDhd2CwjHco9nikQN4EWNmM
   k=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: G84SvqdtrEHcTfvW0lzFkka4Tw1RFjydBtjP6BvC6maKhrJZ5YV7mKfyDuweBvZQeLQ+sYzwAH
 7AQRlD+eGk6MTm9mGyctgbnOti870+na+C8gJW6KsE7ahk7ld4aurWpuJ2e2v4CS2uUxg+OGbO
 6foGCY2LSVLRDVs2+afex62rKPSLoQBbvDEEBaYoQ5G3v09AKS0DKF5pJTc0g4X37SlIAGCEfb
 nV7i3SWijW7UH7OeVd/4D6b++x3CxFfPmBtEujYOLpO5UFmpfcicmdRZHjFVmT5sEdgXL2+THz
 cWN+meIUyWejaKSMfr0lnQ9q
X-SBRS: 5.1
X-MesageID: 66622945
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:d5hlJq1LJWXbBMB6l/bD5QR2kn2cJEfYwER7XKvMYLTBsI5bp2RTz
 GMXXmmCMveCazPzeN0kPYrkoR4Au5TWndI2GwFopC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkS5PE3oHJ9RGQ74nRLlbHILOCanAZqTNMEn9700o5wrBh2OaEvPDia++zk
 YKqyyHgEAfNNw5cagr4PIra9XuDFNyr0N8plgRWicJj5TcypFFMZH4rHomjLmOQf2VhNrXSq
 9Avbl2O1jixEx8FUrtJm1tgG6EAaua60QOm0hK6V0U+6/TrS+NbPqsTbZIhhUlrZzqhwPEs1
 P53r6CLZV0JGZaPxucXFBZaKnQrVUFG0OevzXmXtMWSywvNcmf2wuUoB0YzVWEa0r8pWycUr
 6VecW1TKEDY7w616OvTpu1Er8IvNsT0eqgYvWlt12rxBvc6W5HTBa7N4Le02R9u2J4UR6eCO
 qL1bxJhfjTiWh8IYmwPGcsyvbuSv1n1SGVx/Qf9Sa0fvDGIkV0ZPKLWGMrYfJmGSNtYmm6cp
 3na5CLpDxcCLtudxDGZtHW2iYfnnyn2RYYTH72Q7eNxjRuYwWl7NfENfQLl+7/j0Bf4Ao8Bb
 RxPksYzkUQs3BOKE8XWZQeEm1LenjknGIRTGao16jjYn8I4/D2lLmQDSzdAbvkvu8k3WSEm2
 ze1oj/5OdB8mObLECzAr994uRv3YHFIdjFaOUfoWCNYu4GLnW0lsv7Yoj+P+oaRh8a9Jzz/y
 iviQMMW1+RK1p5jO0lWEDn6b9OQSnrhE1ZdCub/BDvNAuZFiGiNPdHABb/zt6soEWphZgPd1
 EXoYuDHhAz0MbmDlTaWXMIGF6yz6vCOPVX02AAzQ8h8rm78qi/6J+i8BQ2Swm8zb67onhezP
 ifuVf55vscPbBNGk4crC25ONyja5fe5Tom0PhwlRtFPfoJwZGe6ENJGPiatM5TWuBF0y8kXY
 M7DGe71VCpyIfk3nVKeGrZGuZd2l39W+I8mbc2ip/hR+eHFPyD9pHZsGAbmU93VG4ve8FWPq
 IcAbZLXo/idOcWnChTqHUcoBQliBVAwBIzsqtwRceiGIwF8H3omBeOXyrQkE7GJVYwO/gsR1
 n3iCEJe1nTlgnjLdVeDZnx5Meu9Vpdjt3MreycrOA/wiXQkZI+u6oYZdoc2IuZ7pLAyk6YsQ
 qlXYdiED9ROVi/Dp2YXY67iodEwbx+snw+PYXaoOWBtY556SgXV0db4ZQ+zpjIWBy+6uJJm8
 b2t3w/WW7QZQAFmAJqEYf6j1Qrp73MchPhzTw3DJdwKIBfg941jKirQiP4rIp5TdUWfl2XCj
 wvPWEUWv+jApYMx4eLlv6Hcotf7CfZ6E2pbA3LfseS8Ox7F8zfx2oRHSuuJI2zQDTum5KW4a
 OxJ5PjgK/lbzk1Suo9xHrs3n6Iz49zj++1Twgh+RSiZal2qDvVrI2Wc3NkJvapIn+cLtQyzU
 0OJ299bJbTWZ5+1TA9PfFIoPraZyPUZujjO9vBkckz16Rh+8KeDTUgPbQKHjzZQLectPY4oq
 Qv7VBX6N+BrZsIWD+u7
IronPort-HdrOrdr: A9a23:T2Lz7qGw1rGhmbANpLqFTJHXdLJyesId70hD6qkvc3Nom52j+/
 xGws536fatskdtZJkh8erwXZVp2RvnhNBICPoqTMuftW7dySqVxeBZnMTfKljbdREWmdQtrJ
 uIH5IOa+EYSGIK9/oSgzPIU+rIouP3iJxA7N22pxwGLGFXguNbnnxE426gYxdLrWJ9dP4E/e
 +nl6x6Tk2bCBMqh6qAdxs4dtmGg+eOuIPtYBYACRJiwhKJlymU5LnzFAXd9gsCUhtUqI1Ssl
 Ttokjc3OGOovu7whjT2yv49JJNgubszdNFGYilltUVEDPxkQylDb4RGYFq/QpF5d1H2mxa1+
 UkkC1QefibLEmhJ11dlCGdnzUIFgxes0MKh2Xo2kcL6vaJOw7SQ/Ax+76xNCGptnbI9esMoJ
 6ilQiixutqJAKFkyLn69fSURZ20kKyvHo5iOYWy2dSSI0EddZq3MYiFW5uYd899RjBmcsa+S
 hVfbXhzecTdUnfY2HSv2FpztDpVnMvHg2eSkxHvsCOyTBZkH1w0kNdnaUk7zs93YN4T4MB6/
 XPM6xumr0LRsgKbbhlDONERcesEGTCTR/FLWrXK1X6E6MMPW7LtvfMkfgIzfDvfIZNwIo5mZ
 zHXl8dvWkue1j2AcnLx5FP+gClehT1Yd0s8LAp23FUgMyPeFPbC1z1dLl1qbrSnxw2OLyvZ8
 qO
X-IronPort-AV: E=Sophos;i="5.88,374,1635220800"; 
   d="scan'208";a="66622945"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=BQcBpjbkHWQ69GfKGrdoJ7Co/rcg6Jp1sVU4I8eRwEc91gxPZjp9Wlqu+82ES03YVWfxj4GJf3zi6nFc24S2FaT+Fafc7CBQZkc/q1A/6M8KgmjLeNI4MqXEQxpPdDPte6bbSQLAbstnrJ7HYATii5zwzLm2GekoTNmen7+fXUBSqwe0CgoyxdQmHbZWPtiABnHCNJTiNU45azgPaGtVywptb03qyxkoiaLZpHnARtYD0xYKiD9NemL1DtX2yDfiUSb9HyrtRPQNI9ayRGu3flL0q6cuozze9hk0E31GhPq/iHNqUGZwUOvwIhiTQGb4aVTAn7AHOnCFB6rLfG+Z4Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=AgdBK7sUvLgEaiJIffffzhuXLDVk8ixdjkNCD5Km92c=;
 b=du958pim3qok83Ruf5239enGJ2zY7TAqGbF97APiCmPbJYqn9W8kumAEh6CM6b0UG9yFzikereMvgRxCsBDIBtUs/Br7FWL+xo+p45f7nFAlvJgFLrFiqPS6kh3/Le7lu2soAH6TloW8GUa5+utvhVNU8kbyIsL48KD8rG97mXOwdtkp5zhPvnJGQoPUqMO68rFCy7sBM1aN/exxQIr3MHrVcArh32U3LmJmrclbC71U37LCLMOfunUSaVUAEs+ew+WkuO1yzPaSOjgWOwCUQQUpg3dqSH1xbz3scgzoiMIVjC1fkydFmDdDQHB4o7RpcBdzFACOOVjhLvJ4iXsbtQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=AgdBK7sUvLgEaiJIffffzhuXLDVk8ixdjkNCD5Km92c=;
 b=N4LjNoEA+wBYVdcmZRDHOEVPqs1gutXdrBpV6BSSqN5K6ki9piE2pxcFMy6QsUwjrnacdgoQEizv2AXP2XArvHRGjAPB3EXtZCcHBxwvYaTmVidBl8l+UbZe6hSqOraHlRaHvsc/CJVSYGCaRRHTZHVvLnFaNNDVuy6AFj8866g=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2 34/70] x86/emul: CFI hardening
Thread-Topic: [PATCH v2 34/70] x86/emul: CFI hardening
Thread-Index: AQHYIaPBW5BDF7b7HkCjMh8IXdikYayTDOOAgAGT+YCAAAhigIACDWqA
Date: Wed, 16 Feb 2022 21:34:25 +0000
Message-ID: <18ddd7f8-98fd-a1b4-e694-32bc338a33ea@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
 <20220214125127.17985-35-andrew.cooper3@citrix.com>
 <2a5e1893-506e-e4fc-dbff-6001feec1e99@suse.com>
 <d62fddef-5cae-7334-ed0b-cc2c9313f040@srcf.net>
 <21e40ac1-277a-8675-1299-54561ab3d2d6@suse.com>
In-Reply-To: <21e40ac1-277a-8675-1299-54561ab3d2d6@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 49843bcd-bdba-4e2a-8546-08d9f1941ae5
x-ms-traffictypediagnostic: CY4PR03MB2949:EE_
x-microsoft-antispam-prvs: <CY4PR03MB2949BCCDF29DBB09FBBEA554BA359@CY4PR03MB2949.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: T3LMDNeJ03PGxUmjdR0WVsvHmKi6JTuatAoxC+CAJgwFXj57jaXeOO1IvoIa3oAaXKlcGE41JX5G1OusbLSepay4vkyyQUaZR0Eku4hz8CzSXAzfMp90g7zKpcTuKxNGwfl8cOd/cO9EErICSAryht19G3G7Dncla3zOjvgoLqaZv3UWycbILXzQoavOX3cbbFa/b34X29UoSkYUooNIeKu6lwd1K4vhTmFdMGCIWDK+QW91+lyZtcgfhyXHdf9asWOZbD/HmanW6mso4ZG7u42qomWk3TtiJPcfViVEnYKMd9/5vfsb+LOqlO0aZq46xe/TYOygE6cRxxnNQOzsto88DSv5YbPwlaH+gNnsSmR4olxeXkdq41MfDNG5QpFf8HW6ssi41bDopY1Q+Gv7gkCDVmchwh4bl7eKapaBbLSjg7trr16JMbW+TFr+4TfFzn9HIEmJLs9Rc3Jd/GiUduQVBXE7p1irHp3/hFLtVMsdzNBEPuqWF9mdmnLPgXkfvIwE3A02x9lI9emmxZE1X3p1jWjaKL9iD+0e7yREA8CBnOjDZP9SRXwPCA+lDlF/k8HrhsxCjB5lRzyix9SbE5CHjah508+rX/3U+JTzwYzV2eJJqlos6ik4vFtqdUnmNSznCFgSNOMhxR3suq5bqFcovjLe5N+TdbrKOyW0DiV9Xxozs6eRmHxdjDFHaD6kBnQDOvrEpoRJxKFKfdEwflcxBpu3BFWQwn3AOMj2ht6Tr19aKr8vlMwqHkGKa0zpJa1j7CVW5vIfiH1muPE5oA==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(76116006)(64756008)(4326008)(66446008)(66556008)(66476007)(8936002)(6506007)(53546011)(38100700002)(66946007)(26005)(186003)(91956017)(8676002)(2906002)(71200400001)(5660300002)(122000001)(82960400001)(6512007)(2616005)(38070700005)(31686004)(31696002)(6916009)(6486002)(36756003)(316002)(86362001)(508600001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?MVFzcUhWODdtd3k2cFpMb3dFY2tRVFFid3ZCUlhRemVJakU3UHMwOWxrRlM5?=
 =?utf-8?B?TDR0VHVnSHd1TFFtMGI5eC9jRm5IQjBVemUwblNrZ2xoVTlJb1JBRE5xY0o1?=
 =?utf-8?B?WVNubXVKSHp5dXJvMGJBNzFwc0pUU0VWNjN3VUFjaVJQUzFObitpTVhiUVBm?=
 =?utf-8?B?NUxLVFhIdFVEOG5TaDlvTTlYZTMwT1ZFODZHN3NxQlZwYmdpaDM2WUFhYm9K?=
 =?utf-8?B?N3hkc0FqOWRKTFpQNGRab3RCT1ozYi8rdUdRbHZwd0NNRXpZU3laRWlXWlcr?=
 =?utf-8?B?SDhLZlo1dUNMRXRnN2NjeHJ1RE94RXRsQ0Y2am1XQXU2MkkxMVJRM0loczM1?=
 =?utf-8?B?RHNjK0hVVkhwTmhMQUVCK3RwU0cwMzMrUHU0QzlnN0xkbG41QWo3a1ZpYUFJ?=
 =?utf-8?B?aFo2MWM1REJyd3NZL0s0bG8xS2h0alFrcE5NYTdmRGFUTW5oRDY4VVpuUEtj?=
 =?utf-8?B?RUh4WHo0YTloZThzMXF5elZwMUxCTmprcUdRck1IVGRLK3lJSmtCZVc0OEo5?=
 =?utf-8?B?aWJaVGhZL1pyQm84SmdURG1vSU5VNGk4aXJxOWxaR0ExQy82RkhqMS9VcGRR?=
 =?utf-8?B?QlRxNVAwRDZnSks4VU13dStDWTh1ZEEvRDRBZVJJaXRaVi9DQkNvZXZrYVlv?=
 =?utf-8?B?RnRTZnB6aGQvTTFRN01Wd1R0TEF5aGFRZlppb3N0VTUxQW9BU09zZ3BKcFla?=
 =?utf-8?B?TjBXQTVOcDlDSjQ3UGxPaUt5WFpmWFMxWkhhYmJyUmNxQUdKbUtyQ3pYMUtz?=
 =?utf-8?B?cEZjZFJGUkNJYnYrSzVZNmNYcHRqSHJyelp1VmlhM2ZMUE10cURQL3BINWxp?=
 =?utf-8?B?NEZKVCs1NVFuTm1lQWF1WGswbXNzTUlvUU5uR0xRS3RvK0FrejNQZnJRQlJX?=
 =?utf-8?B?QUw3WXMwZFhsZ1VYUk9RaFFQYjNXOWNRRzBSTEFaNDRlbm9GWDNKZ0FIZ25S?=
 =?utf-8?B?RzBQYllsUFcrdWl1YkJMWUZIUGNPeG1wRlp4bzFZeWlSSTRoVkkyNm54ZFpT?=
 =?utf-8?B?TkVBWkZmNm4vdG5HR2lYOVBVc09GSFBIcFQ0NUovRE1qb2NrckRrM21qSDVN?=
 =?utf-8?B?bXp5TWE0T2hzNkRaRnFUc2tFYTJXNzdKclZrVmdwWDlLT1JlOWlCNUZnY1h4?=
 =?utf-8?B?a1VFbXQ1WWhTa3FkMTdpd042WHdKRWY5MXNMSVNDWDhBOFJTS0R1d1NxZWpV?=
 =?utf-8?B?Tmg3eVo0bUdTdDE5SDRYTDdkZ0pUR2ZvS21yZHZsK3prTXMvTm1JdXJjbTJj?=
 =?utf-8?B?aGNOcHJCVUFGSTNsY0hoa1VLYmpEWWZYR05qRk9neko0czRtcFJYVHJxRkNT?=
 =?utf-8?B?NktzbDhqSWdQTlNTT0h0bnBnVzlNSlpBU0Nwd2FtWXFzTGVBWisyNVhRRXY4?=
 =?utf-8?B?VTRZd1Q0K0ZjaE5VS1ZmbTRsNnhSNHMzZndxeVlqTlVQdVhPdUFrL3JTbFRw?=
 =?utf-8?B?aGN0RUNyWVN1b1V1UW5BWVlkenZjdWJZZE11ZUp6TnYzRDBaZGZ5akczd0tR?=
 =?utf-8?B?TUh4d3liZnpnWWVPSlNkdjltcWJ2N28zTVI3Y1BSZ09icE9CWTlTTzhTcFRi?=
 =?utf-8?B?ZTE2NFZyQWpTMW05VmdMRHhoQ1FpcW9UU2djU041TFpvRHVoU0lrYm13RWJB?=
 =?utf-8?B?b2swbjV1MlRWLzExeEhHQkZXSUE0Sk9tMDJ2Q0JWaVJIemVGMDUrQVQyOC9h?=
 =?utf-8?B?WmRQUVoyTE0ranhuMXA1RWhxV1FmOXpSaVlIQnMvSDZjdHN5SFNqR1VjVTUw?=
 =?utf-8?B?V0paS3V4ZnI1SG5HVllNN0plMUREYVRMUnV2RFpvSWxWN3BBSzhMOFEwWnhH?=
 =?utf-8?B?N2xlODJWMURrR2luZkp0S0JKYzNFTTFWS3czK3huZTgxalYvTUpMdTc3MTRj?=
 =?utf-8?B?SCtwS08vaFZEZ2xHM1lDbCtDVmt0L1cwOU1iNmlhZlZuUEZUUXQ3ejJGMXJl?=
 =?utf-8?B?TVpab3duaE9wYW00blNpMDNNU1JFbFQxbHJxVGxkdFhnQlRURXp3SmQ0b1A2?=
 =?utf-8?B?ckZ5NEh5YWRWdXkya3dldll3bTg5Vitxbm9BRzJSbVI3dEpNVmpnejRldXJJ?=
 =?utf-8?B?TWh1bk44SzY0SWFtSnIyMk1Cc0lXaU0xRWNsWUFyaSs0YkNWbFp5aWpJaUg0?=
 =?utf-8?B?UzRnejdEaGJXdUU3cGxBYjc0VTJYRFcrajQ3N1k0UVBSRzI5RzRPaThKY2Nx?=
 =?utf-8?B?cVRMUlh0amdKRFY4VzZXcFl0am5HaENjaVR5eUwwdnYrMmVZbytsNVFObXhV?=
 =?utf-8?B?MGdOcFZUbmRqMXltMUJ1ZEVhUXlRPT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <CC4F5A3D0BF81F4C98AFE31F64237A53@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 49843bcd-bdba-4e2a-8546-08d9f1941ae5
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Feb 2022 21:34:25.7089
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: x1pzp8A4vKGLGSw7aJQHlVMokADlf/OFzI4F4VsPDrzGlqdeCrtgZvdr8N5dBm0phOXvtPmsiOsP+LZJ05FTGvVe7x2g1vcJc/PjZ3zi2t0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR03MB2949
X-OriginatorOrg: citrix.com

T24gMTUvMDIvMjAyMiAxNDoxMywgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDE1LjAyLjIwMjIg
MTQ6NDMsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBPbiAxNC8wMi8yMDIyIDEzOjM4LCBKYW4g
QmV1bGljaCB3cm90ZToNCj4+PiBPbiAxNC4wMi4yMDIyIDEzOjUwLCBBbmRyZXcgQ29vcGVyIHdy
b3RlOg0KPj4+PiBDb250cm9sIEZsb3cgSW50ZWdyaXR5IHNjaGVtZXMgdXNlIHRvb2xjaGFpbiBh
bmQgb3B0aW9uYWxseSBoYXJkd2FyZSBzdXBwb3J0DQo+Pj4+IHRvIGhlbHAgcHJvdGVjdCBhZ2Fp
bnN0IGNhbGwvanVtcC9yZXR1cm4gb3JpZW50ZWQgcHJvZ3JhbW1pbmcgYXR0YWNrcy4NCj4+Pj4N
Cj4+Pj4gVXNlIGNmX2NoZWNrIHRvIGFubm90YXRlIGZ1bmN0aW9uIHBvaW50ZXIgdGFyZ2V0cyBm
b3IgdGhlIHRvb2xjaGFpbi4NCj4+Pj4NCj4+Pj4gcHZfZW11bF9pc19tZW1fd3JpdGUoKSBpcyBv
bmx5IHVzZWQgaW4gYSBzaW5nbGUgZmlsZS4gIEhhdmluZyBpdCBhcyBhIHN0YXRpYw0KPj4+PiBp
bmxpbmUgaXMgcG9pbnRsZXNzIGJlY2F1c2UgaXQgY2FuJ3QgYmUgaW5saW5lZCB0byBiZWdpbiB3
aXRoLg0KPj4+IEknZCBsaWtlIHlvdSB0byBjb25zaWRlciB0byByZS13b3JkIHRoaXM6DQo+PiBU
aGlzIGlzIHRoZSByZXdvcmRlZCB2ZXJzaW9uLg0KPj4NCj4+PiBJdCBiZWluZyBzdGF0aWMgaW5s
aW5lIHdhcyBmb3INCj4+PiB0aGUgY2FzZSBvZiB0aGVyZSBhcHBlYXJpbmcgYSAybmQgdXNlci4g
SSBkb24ndCB2aWV3IHN1Y2ggYXMgcG9pbnRsZXNzLg0KPj4gSSBmaW5kIHRoYXQgaW1wb3NzaWJs
ZSB0byByZWNvbmNpbGUgd2l0aCB5b3VyIG5vcm1hbCByZXZpZXcgZmVlZGJhY2suDQo+IEludGVy
ZXN0aW5nLiBJIGRvbid0IHRoaW5rIEkgd291bGQgaGF2ZSBvYmplY3RlZCB0byBzb21ldGhpbmcg
bGlrZQ0KPiB0aGlzLCBpZiBpdCB3YXMgY29uY2VpdmFibGUgdGhhdCBhIDJuZCB1c2VyIG1heSBh
cHBlYXIuIEkgZG9uJ3QNCj4gdGhpbmsgdGhpcyBpcyB0aGUgb25seSBpbmxpbmUgZnVuY3Rpb24g
d2UndmUgZ290IHdpdGgganVzdCBhIHNpbmdsZQ0KPiB1c2VyLiBJIGFsc28gZG9uJ3QgdGhpbmsg
dGhpcyBpcyB0aGUgb25seSBpbmxpbmUgZnVuY3Rpb24gd2UndmUgZ290DQo+IHdpdGggaXRzIGFk
ZHJlc3MgdGFrZW4sIGFuZCBoZW5jZSBoYXZpbmcgYW4gb3V0LW9mLWxpbmUgaW5zdGFudGlhdGlv
bi4NCj4NCj4+IEl0IGlzIHVuY29uZGl0aW9uYWxseSBmb3JjZWQgb3V0IG9mIGxpbmUgYmVjYXVz
ZSBvZiBob3cgaXQncyB1c2VkLA0KPj4gbWVhbmluZyB0aGF0IGlmIGl0IGV2ZXIgZ290IHVzZWQg
aW4gYSBzZWNvbmQgdHJhbnNsYXRpb24gdW5pdCB3ZSdkIGVuZA0KPj4gdXAgd2l0aCBhIGR1cGxp
Y2F0ZSBmdW5jdGlvbiwgYXQgd2hpY2ggcG9pbnQgaXQgd291bGQgbmVlZCB0byBiZQ0KPj4gbm9u
LXN0YXRpYyBhbmQgZXhwb3J0ZWQgdG8gcGFzcyByZXZpZXcuwqAgKEFuZCBzYW5pdHkuKQ0KPiBJ
J20gYWZyYWlkIHlvdSd2ZSBsb3N0IG1lIGhlcmUuIFdoYXQgZHVwbGljYXRlIGZ1bmN0aW9uPyBC
ZWZvcmUgYW5kDQo+IGFmdGVyIHRoZSBwYXRjaCB0aGUgZnVuY3Rpb24gaXMgc3RhdGljOyB3aGF0
IGNoYW5nZXMgaXMgbWVyZWx5IHRoZQ0KPiAiaW5saW5lIi4gVHdvIENVcyBjYW4gaGF2ZSBpZGVu
dGljYWxseSBuYW1lZCBzdGF0aWMgZnVuY3Rpb25zLCBjYW4ndA0KPiB0aGV5PyBPciBpZiB0aGF0
J3Mgbm90IHRoZSBwb2ludCB5b3UgdHJ5IHRvIG1ha2UsIHRoZW4gSSBoYXZlIG5vIGlkZWENCj4g
d2hhdCBpdCBpcyB0aGF0IHlvdSdyZSB0cnlpbmcgdG8gdGVsbCBtZS4NCg0KWWVzLCB0aGUgc2Ft
ZSBzdGF0aWMgaW5saW5lIGNhbiBiZSBvdXQtb2YtbGluZWQgaW4gbXVsdGlwbGUgdHJhbnNsYXRp
b24NCnVuaXRzLsKgIFRoaXMgY3JlYXRlcyB0d28gaWRlbnRpY2FsIGNvcGllcyBvZiB0aGUgbG9n
aWMsIGFuZCB0aGVuIGZhbGxzDQpmb3VsIG9mIG91ciB1bmlxdWUgc3ltYm9scyBjb25zdHJhaW50
Lg0KDQpUaGUgYWJzZW5jZSBvZiBjb21wbGFpbnRzIGluIHRoZSBnZW5lcmFsIGNhc2Ugc2hvd3Mg
dGhhdCB3ZSBkb24ndA0KY3VycmVudGx5IGFueSBjYXNlcyB3aGVyZSBhIHN0YXRpYyBpbmxpbmUg
aXMgb3V0LW9mLWxpbmVkIGluIG11bHRpcGxlDQp0cmFuc2xhdGlvbiB1bml0cy4NCg0KVW5kZXIg
SUJULCBpdCBtZWFucyBtb3JlIHRhZ2dlZCBmdW5jdGlvbnMsIHdoaWNoIEkgc3VwcG9zZSBkb2Vz
bid0IG1ha2UNCmEgdXNlZnVsIGRpZmZlcmVuY2UgZnJvbSB0aGUgYXR0YWNrZXJzIHBvaW50IG9m
IHZpZXcsIGJ1dCBpdCdzIHN0aWxsDQpsb2dpYyBkdXBsaWNhdGlvbiBpbiB0aGUgZmluYWwgYnVp
bGQgdGhhdCB3ZSdkIHByZWZlciB0byBhdm9pZC4NCg0KfkFuZHJldw0K


From xen-devel-bounces@lists.xenproject.org Wed Feb 16 21:45:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 21:45:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274404.469858 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKS7E-0006vW-Dd; Wed, 16 Feb 2022 21:45:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274404.469858; Wed, 16 Feb 2022 21:45:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKS7E-0006vP-AV; Wed, 16 Feb 2022 21:45:36 +0000
Received: by outflank-mailman (input) for mailman id 274404;
 Wed, 16 Feb 2022 21:45:35 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=AWAb=S7=xilinx.com=stefanos@srs-se1.protection.inumbo.net>)
 id 1nKS7C-0006vJ-Sr
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 21:45:35 +0000
Received: from NAM02-SN1-obe.outbound.protection.outlook.com
 (mail-sn1anam02on2061e.outbound.protection.outlook.com
 [2a01:111:f400:7ea9::61e])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c2ceef27-8f71-11ec-8eb8-a37418f5ba1a;
 Wed, 16 Feb 2022 22:45:31 +0100 (CET)
Received: from DS7PR03CA0060.namprd03.prod.outlook.com (2603:10b6:5:3b5::35)
 by DM6PR02MB6873.namprd02.prod.outlook.com (2603:10b6:5:259::20) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.18; Wed, 16 Feb
 2022 21:45:28 +0000
Received: from DM3NAM02FT041.eop-nam02.prod.protection.outlook.com
 (2603:10b6:5:3b5:cafe::bf) by DS7PR03CA0060.outlook.office365.com
 (2603:10b6:5:3b5::35) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.16 via Frontend
 Transport; Wed, 16 Feb 2022 21:45:28 +0000
Received: from xsj-pvapexch02.xlnx.xilinx.com (149.199.62.198) by
 DM3NAM02FT041.mail.protection.outlook.com (10.13.5.133) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.4975.11 via Frontend Transport; Wed, 16 Feb 2022 21:45:27 +0000
Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by
 xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2176.14; Wed, 16 Feb 2022 13:45:07 -0800
Received: from smtp.xilinx.com (172.19.127.96) by
 xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id
 15.1.2176.14 via Frontend Transport; Wed, 16 Feb 2022 13:45:07 -0800
Received: from [10.23.121.122] (port=59639 helo=ubuntu-20.04.2-arm64.shared)
 by smtp.xilinx.com with esmtp (Exim 4.90)
 (envelope-from <stefano.stabellini@xilinx.com>)
 id 1nKS6k-0003RU-0k; Wed, 16 Feb 2022 13:45:06 -0800
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c2ceef27-8f71-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ZGsX5E0qE6tXUy5+RxR4gf3dyLb4npE4K2gifFjT+wT4qFA0BsSraY++YzF6Dw6PzmbEtYW1tlddHh5JumRBGVNwqCRkBptcTHJr1LwYL45zpYfAZAGWz9JR95BgIsV9BRMwmbYI6GuUIaQ98SfFoN3MKrL2h6fW7USm2ANrq2FThDKJLDVtbHOiIXw9UnGCG5A9VmtWjDXOW0qfzPPW9dndSzUQkMU4AHv9sSxj8AtOw9K85iHIwEkUEK2ffnUs5QiX3yh7h+KoesD6TcKJjMAm0MpeLo/2kzdT7mZ4BA5MsmO46no62LMSctuiXkoARoTFLDst8wpP3Pca8WUEMA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=DMiileQrEAOXLt2ANWW6F5Qg5RDknaQTnkr0OULuZKM=;
 b=lYmdotqH0vGbppT2cOnbm/j1MGCVP3RCkJrfjBiccf+goTEJpAb1L26WZt1+1XijX1H8wn6IkE12puWjXVQE2GKz+EBMtjqMVphIFJQD5olyar4jZDbuDwu05iUXUCeQ+oAI23qtj6tnbsbSUeia3PTxdcQjvDG2FIaIZHWhUdzngN+bGegsBYYOuXpFrekF4gZV5ZCVD4fPU31q2+wUge1lU1BDvtBSAHuXdFipN+yJc3Kb7ZkRYBdGQmZHnzl7g+5hsV+fGGdYgMEqBdAh8TYW7ash7/bAPzvbgjiQqkyAxMy/j9rLl9vDdeSZKXa7yYeh2ndvQGi6CQqeB1ktjw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 149.199.62.198) smtp.rcpttodomain=linaro.org smtp.mailfrom=xilinx.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=DMiileQrEAOXLt2ANWW6F5Qg5RDknaQTnkr0OULuZKM=;
 b=Ubk7Z0mXaqG+n4P/qH7Cy6tNU5VN+zh24VS5z0fDg22c8pZ1YPTy6kBmBp1tfqdrJ4WZIlcPuIg4DCyV+q5mEusbhpOpTjgzHhYyyOCPjwekps1oaiachToDHFzGn7I1HyD7iAowNxddgRWnKM0fcK4ShF9WMQjLVuVRU0qJGys=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198)
 smtp.mailfrom=xilinx.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=xilinx.com;
Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates
 149.199.62.198 as permitted sender) receiver=protection.outlook.com;
 client-ip=149.199.62.198; helo=xsj-pvapexch02.xlnx.xilinx.com;
Date: Wed, 16 Feb 2022 13:45:05 -0800
From: Stefano Stabellini <stefano.stabellini@xilinx.com>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Vincent Guittot <vincent.guittot@linaro.org>
CC: Stefano Stabellini <stefano.stabellini@xilinx.com>,
	=?UTF-8?Q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>,
	<stratos-dev@op-lists.linaro.org>, <xen-devel@lists.xenproject.org>, AKASHI
 Takahiro <takahiro.akashi@linaro.org>, Arnd Bergmann
	<arnd.bergmann@linaro.org>, Christopher Clark
	<christopher.w.clark@gmail.com>, Dmytro Firsov <dmytro_firsov@epam.com>,
	Julien Grall <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, <Oleksandr_Tyshchenko@epam.com>,
	<Artem_Mygaiev@epam.com>, <bertrand.marquis@arm.com>, <Wei.Chen@arm.com>,
	<Ed.Doxat@arm.com>, <Oleksii_Moisieiev@epam.com>
Subject: Re: Metadata and signalling channels for Zephyr virtio-backends on
 Xen
In-Reply-To: <CAKfTPtB1ONsxA1Rch8AO+UrPRZsHrCgF1_-F-kh9U_Xu2M47aA@mail.gmail.com>
Message-ID: <alpine.DEB.2.22.394.2202161256350.43738@ubuntu-linux-20-04-desktop>
References: <87h79bgd1m.fsf@linaro.org> <alpine.DEB.2.22.394.2202071419270.2091381@ubuntu-linux-20-04-desktop> <CAKfTPtB1ONsxA1Rch8AO+UrPRZsHrCgF1_-F-kh9U_Xu2M47aA@mail.gmail.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed;
	boundary="8323329-1281770804-1645045378=:43738"
Content-ID: <alpine.DEB.2.22.394.2202161303010.43738@ubuntu-linux-20-04-desktop>
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 26b00acf-e363-465a-eb15-08d9f195a5a1
X-MS-TrafficTypeDiagnostic: DM6PR02MB6873:EE_
X-Microsoft-Antispam-PRVS:
	<DM6PR02MB68731356BE9E0C664E17DAEBA0359@DM6PR02MB6873.namprd02.prod.outlook.com>
X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	KZRQ9DXiqAgYrrpxJfW1Yb50tqabWAYxoZgvguP1/zpRKhKFBbVHq6VkXKeSDG4/N+yyrTo5AyHN837VzxKqDL8b+/VnRnXzmNN3QsZLjhtg864PfmsLEpgvaCQsmj1l3HS98GftWHTXbjl1f7pydqmZZg/6O5jLvvkKUX5WM/CbmafokeFZ/Siczb9LRZoRIFWRrQNxopo2DBmqEWzTiy7V4flCpUeuYATKU2MjooITYOIugTtw1C6sI5TYG6YV440p9XAx1EGuV72nuG8llgsbhWco54KnoFCqTJ8XPSGKpJVWg7yXuyx0ZChstoiY0q6WQ11diHxUILgPuoqBNbqyLQ/7djt1oBmfXUDaFiAAHpqfqoknVNOt/WBVvS298FNSxtLoDFpmcDPMaiVMlI+a9KmMiP4fI3Q7In+VbzJjmTNjf9vhAakmB/Q4742BE2wJibQXxtfaWdtHdROafupWBUFuus/SafY63FgYgOOT0sA3qTBlNFOzIvIwmB3WumCqmqFrQ1IUv7D3KET9aojcHZbzf9kghR2WNBnyqcjZs5P9t4fAlF4CIYqbvVTECfKREr0KXNef1yE7aQbDIdsYfVa5nxaG05KQjfdPQwUTWpTZYpL0Ut6dg2PB9SSuOilsFrp3DM0invAz4qFp5tQctpE98phF4A2asVNGGVkwja3TGML5y494Q6MNRh2jH/bFgPDNx0C+1CjpXGZwdCBSNoAiiiO+eXVJxpu188mlNUJyqVY95t7wcf/hdLzefb5CGKtEoByvrgtWtqdwsdDwBN5yiJDJO2E/tz8+GrA=
X-Forefront-Antispam-Report:
	CIP:149.199.62.198;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:xsj-pvapexch02.xlnx.xilinx.com;PTR:unknown-62-198.xilinx.com;CAT:NONE;SFS:(13230001)(4636009)(7916004)(36840700001)(46966006)(40470700004)(83380400001)(966005)(7416002)(508600001)(8936002)(356005)(9786002)(7636003)(316002)(82310400004)(6916009)(54906003)(5660300002)(4326008)(8676002)(70206006)(70586007)(186003)(26005)(33716001)(40460700003)(66574015)(36860700001)(30864003)(47076005)(44832011)(33964004)(336012)(426003)(9686003)(2906002);DIR:OUT;SFP:1101;
X-OriginatorOrg: xilinx.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2022 21:45:27.9971
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 26b00acf-e363-465a-eb15-08d9f195a5a1
X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch02.xlnx.xilinx.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DM3NAM02FT041.eop-nam02.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR02MB6873

--8323329-1281770804-1645045378=:43738
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Content-ID: <alpine.DEB.2.22.394.2202161303011.43738@ubuntu-linux-20-04-desktop>

On Tue, 15 Feb 2022, Vincent Guittot wrote:
> On Tue, 8 Feb 2022 at 01:16, Stefano Stabellini
> <stefano.stabellini@xilinx.com> wrote:
> >
> > On Mon, 7 Feb 2022, Alex Bennée wrote:
> > > Hi Stefano,
> > >
> > > Vincent gave an update on his virtio-scmi work at the last Stratos sync
> > > call and the discussion moved onto next steps.
> >
> > Hi Alex,
> >
> > I don't know the specifics of virtio-scmi, but if it is about power,
> > clocks, reset, etc. like the original SCMI protocol, then virtio-scmi is
> 
> virtio-scmi is one transport channel that support SCMI protocol
> 
> > likely going to be very different from all the other virtio frontends
> 
> The virtio-scmi front-end is merged mainline
> 
> > and backends. That's because SCMI requires a full view of the system,
> > which is different from something like virtio-net that is limited to the
> > emulation of 1 device. For this reason, it is likely that the
> > virtio-scmi backend would be a better fit in Xen itself, rather than run
> > in userspace inside a VM.
> 
> Not sure what you mean when you say that SCMI requires a full view of
> the system.

SCMI can be used to read the status of resources in the system and
typically leads to a full view of the system's resources.

If I assign the USB controller to a VM, I expect that VM to only "see"
the USB controller and any attached USB peripherals, in addition to the
other regular virtual resources that a VM commonly has.

If I assign SCMI to a VM, I expect the VM to "see" everything in the
system thanks to the SCMI probing functions. Unless we only assign a
single SCMI channel with limited capabilities to the VM, like EPAM's
patch series on xen-devel is doing.


> If you are referring to the system wide resources which
> reset or power up/down the whole SoC, this is not really what we are
> targeting here. Those system wide resources should already be handled
> by a dedicated power coprocessor. In our case, the IPs of the SoC will
> be handled by different VMs but those IPs are usually sharing common
> resources like a parent PLL , a power domain or a clock gating reg as
> few examples. Because all those VMs can't directly set these resources
> without taking into account others and because the power coprocessor
> doesn't have an unlimited number of channels, we add an SCMI backend
> that will gather and proxy the VM request before accessing the
> register that gates some clocks IP as an example or before powering
> down an external regulator shared between the camera and another
> device.

Do you know what would be the expected number of SCMI channels available
in a "normal" deployment?

My expectation was that there would be enough SCMI channels to give one
for each VM in a common embedded scenario, where the number of VMs is
typically not very high. If we have enought channels so that we can
assign each channel to a different VM maybe we can get away without a
proxy?


> This SCMI backend will most probably also send request with
> OSPM permission access to the power coprocessor once aggregating all
> the VMs ' request

Please correct me if I am wrong, but I would have expected the SCMI
firmware to be able to do reference counting on the hardware resources
and therefore be able to handle the case where:

- we have 2 VMs
- each VM has its own SCMI channel
- a VM requests power-off on 1 resource also used by the other VM

My understanding of the SCMI protocol is that the SCMI firmware
implementation should detect that the resource in question is also
in-use by another VM/channel and thus it would refuse the power-off
operation. (For your information, that is also how the Xilinx EEMI
protocol works.)

Reference counting is a key requirement for a good multi-channel
implementation. If SCMI doesn't support it today, then we have a
problem with SCMI multi-channel, regardless of virtualization.


> We are using virtio-cmi protocol because it has the main advantage of
> not being tied to an hypervisor

That is a valuable goal, which is a bit different from the goal of
finding the best SCMI architecture for Xen, and that's OK. Let's see if
we can find any common ground and synergies we can exploit to improve
both goals. I'll join the Stratos meeting tomorrow.


> In our PoC, the SCMI backend is running with zehyr and reuse the same
> software that can run in the power coprocessor which helps splitting
> what is critical and must be handled by power coprocessor and what is
> not critical for the system (what is usually managed by linux directly
> when their no hypervisor involved typically)
> 
>
> > FYI, a good and promising approach to handle both SCMI and SCPI is the
> > series recently submitted by EPAM to mediate SCMI and SCPI requests in
> > Xen: https://marc.info/?l=xen-devel&m=163947444032590
> >
> > (Another "special" virtio backend is virtio-iommu for similar reasons:
> > the guest p2m address mappings and also the IOMMU drivers are in Xen.
> > It is not immediately clear whether a virtio-iommu backend would need to
> > be in Xen or run as a process in dom0/domU.)
> >
> > On the other hand, for all the other "normal" protocols (e.g.
> > virtio-net, virtio-block, etc.) the backend would naturally run as a
> > process in dom0 or domU (e.g. QEMU in Dom0) as one would expect.
> >
> >
> > > Currently the demo setup
> > > is intermediated by a double-ended vhost-user daemon running on the
> > > devbox acting as a go between a number of QEMU instances representing
> > > the front and back-ends. You can view the architecture with Vincents
> > > diagram here:
> > >
> > >   https://docs.google.com/drawings/d/1YSuJUSjEdTi2oEUq4oG4A9pBKSEJTAp6hhcHKKhmYHs/edit?usp=sharing
> > >
> > > The key virtq handling is done over the special carve outs of shared
> > > memory between the front end and guest. However the signalling is
> > > currently over a virtio device on the backend. This is useful for the
> > > PoC but obviously in a real system we don't have a hidden POSIX system
> > > acting as a go between not to mention the additional latency it causes
> > > with all those context switches.
> > >
> > > I was hoping we could get some more of the Xen experts to the next
> > > Stratos sync (17th Feb) to go over approaches for a properly hosted on
> > > Xen approach. From my recollection (Vincent please correct me if I'm
> > > wrong) of last week the issues that need solving are:
> >
> > Unfortunately I have a regular conflict which prevents me from being
> > able to join the Stratos calls. However, I can certainly make myself
> > available for one call (unless something unexpected comes up).
> >
> >
> > >  * How to handle configuration steps as FE guests come up
> > >
> > > The SCMI server will be a long running persistent backend because it is
> > > managing real HW resources. However the guests may be ephemeral (or just
> > > restarted) so we can't just hard-code everything in a DTB. While the
> > > virtio-negotiation in the config space covers most things we still need
> > > information like where in the guests address space the shared memory
> > > lives and at what offset into that the queues are created. As far as I'm
> > > aware the canonical source of domain information is XenStore
> > > (https://wiki.xenproject.org/wiki/XenStore) but this relies on a Dom0
> > > type approach. Is there an alternative for dom0less systems or do we
> > > need a dom0-light approach, for example using STR-21 (Ensure Zephyr can
> > > run cleanly as a Dom0 guest) providing just enough services for FE's to
> > > register metadata and BE's to read it?
> >
> > I'll try to answer the question for a generic virtio frontend and
> > backend instead (not SCMI because SCMI is unique due to the reasons
> > above.)
> >
> > Yes, xenstore is the easiest way to exchange configuration information
> > between domains. I think EPAM used xenstore to exchange the
> > configuration information in their virtio-block demo. There is a way to
> > use xenstore even between dom0less VMs:
> > https://marc.info/?l=xen-devel&m=164340547602391 Not just xenstore but
> > full PV drivers too. However, in the dom0less case xenstore is going to
> > become available some time after boot, not immediately at startup time.
> > That's because you need to wait until xenstored is up and running.
> >
> > There are other ways to send data from one VM to another which are
> > available immediately at boot, such as Argo and static shared memory.
> >
> > But dom0less is all about static partitioning, so it makes sense to
> > exploit the build-time tools to the fullest. In the dom0less case, we
> > already know what is going to run on the target before it is even turned
> > on. As an example, we might have already prepared an environment with 3
> > VMs using Yocto and ImageBuilder. We could also generate all
> > configurations needed and place them inside each VMs using Yocto's
> > standard tools and ImageBuilder. So for dom0less, I recommend to go via
> > a different route and pre-generate the configuration directly where
> > needed instead of doing dynamic discovery.
> >
> >
> > >  * How to handle mapping of memory
> > >
> > > AIUI the Xen model is the FE guest explicitly makes grant table requests
> > > to expose portions of it's memory to other domains. Can the BE query the
> > > hypervisor itself to discover the available grants or does it require
> > > coordination with Dom0/XenStore for that information to be available to
> > > the BE domain?
> >
> > Typically the frontend passes grant table references to the backend
> > (i.e. instead of plain guest physical addresses on the virtio ring.)
> > Then, the backend maps the grants; Xen checks that the mapping is
> > allowed.
> >
> > We might be able to use the same model with virtio devices. A special
> > pseudo-IOMMU driver in Linux would return a grant table reference and an
> > offset as "DMA address". The "DMA address" is passed to the virtio
> > backend over the virtio ring. The backend would map the grant table
> > reference using the regular grant table hypercalls.
> >
> >
> > >  * How to handle signalling
> > >
> > > I guess this requires a minimal implementation of the IOREQ calls for
> > > Zephyr so we can register the handler in the backend? Does the IOREQ API
> > > allow for a IPI style notifications using the global GIC IRQs?
> > >
> > > Forgive the incomplete notes from the Stratos sync, I was trying to type
> > > while participating in the discussion so hopefully this email captures
> > > what was missed:
> > >
> > >   https://linaro.atlassian.net/wiki/spaces/STR/pages/28682518685/2022-02-03+Project+Stratos+Sync+Meeting+Notes
> >
> > Yes, any emulation backend (including virtio backends) would require an
> > IOREQ implementation, which includes notifications via event channels.
> > Event channels are delivered as a GIC PPI interrupt to the Linux kernel.
> > Then, the kernel sends the notification to userspace via a file
> > descriptor.
> 
--8323329-1281770804-1645045378=:43738--


From xen-devel-bounces@lists.xenproject.org Wed Feb 16 21:55:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 21:55:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274413.469869 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKSGW-0008Ru-Ez; Wed, 16 Feb 2022 21:55:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274413.469869; Wed, 16 Feb 2022 21:55:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKSGW-0008Rn-Bx; Wed, 16 Feb 2022 21:55:12 +0000
Received: by outflank-mailman (input) for mailman id 274413;
 Wed, 16 Feb 2022 21:55:11 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=6VyC=S7=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nKSGU-0008Rh-WB
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 21:55:11 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1ace0028-8f73-11ec-b215-9bbe72dcb22c;
 Wed, 16 Feb 2022 22:55:09 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1ace0028-8f73-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645048509;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=4CdaV5XZvvzfZn3L7inuYC3WF1kLNIJVIbm73IUmq90=;
  b=eSuwdj8/wBar9Gh/2g5AxlWSpK+LG0e3dNltcT+DyhAOmTUIVKRZwI3V
   /61ktEpZx6wqpaRLoiFL96PVGFU5Nf/A2l5Eht4pSZM6os1HYwWG37j/U
   esfSPChPeDZVqYr2ptLswnX/9/JXd1UwhWA5JFFJSt9kaXYWASZOdMN1J
   4=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: MGqM3qF2EOW1V3YY9EPaDikB/x1v+boGNzhdvqPMl3EMIkGPC53tCoiii3jXnJ5q5jJmQGus8e
 xCSuBpmn0NTviinhcFFMFz6BlZh9U94x4XEOZ7O/nkmMb9krZDaE2h1sMY7VxySAaayeYvPoFc
 +ghZyF4wIPToJrdKObNzTULz3b985yQ8GWm3vyBlW5du9Ah4E5MBMOEQcSzZAC+NNYNrQ9lFly
 i0V3NmROYWdH8Ruh/9BHLyiugpWAyl2xueNAG3PdSWUDOhqSHRgJP6yYuUByvmGtyxcqZEdBIy
 tRwR44zgt/KgvEB5y6aXmwLc
X-SBRS: 5.1
X-MesageID: 64283443
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:7yQ6jqKrkBOON2VMFE+RCpIlxSXFcZb7ZxGr2PjKsXjdYENShDMHz
 mIcCmmPbKzbYTf9Kt5yOYXl90kHvpWBnddiHQRlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokcxIn5BC5C5xZVG/fjgqoHUVaiUakideSc+EH170Ug6xbZj6mJVqYPR7z2l6
 IuaT/L3YDdJ6xYsWo7Dw/vewP/HlK2aVAIw5jTSV9gS1LPtvyB94KYkDbOwNxPFrrx8RYZWc
 QphIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbrGvaUXe345iXMfwZ3u7hB3OuM5g0
 dBGi6W0ClsOYOrGwvtCVh1hRnQW0a1uoNcrIFC6uM2XiUbHb2Ht07NlC0Re0Y8wo7gtRzsUr
 LpBdW5LPkvra+GemdpXTsFFgMg5IdatF4QYonx6lhnSDOo8QICFSKLPjTNd9Gls3JAVQaqFD
 yYfQShycEraYgNlAHssVJAws+q1q13iVhQN/Tp5ooJoujOOnWSdyoPFINfTP9CHW8hRtkKZv
 X7duXT0BAkAM96SwibD9Wij7sfQmQvrVYRUE6e3ntZoilCOwm0YCDUNSEC25/K+jyaDt8l3c
 hJOvHB09O5rqRLtHoKVswCETGCs+TkCSsNVGNMD7ELR7fST6VyGWW0Ad2sUADA5j/MeSTsv3
 16PutrmAz1zrbGYIU6gGqeoQSCaYnZMczJbDcMQZU5cuoS4/tlv5v7aZos7SMaIYsvJ9SYcK
 txghAw3nP0tgMECzM1XFniX0mv39vAlouPYjzg7v15JDCskPOZJhKTysDA3CMqsyq7DEzFtW
 1BexqCjABgmV83lqcB0aLxl8EuVz/iEKibAplVkAoMs8T+gk1b6I9wMsWwnfhY4Y59eEdMMX
 KM1kVkMjHO0FCH0BZKbnqrrU5h6pUQePYiNug/ogipmPcEqKV7vENBGbk+MxWH9+HXAYolkU
 ap3hf2EVC5AYYw+lWLeb75EjdcDm3BvrUuOFMuT50n2jtKjiIu9FO5t3K2mNbtisstpYWz9r
 r5iCid9408PALelM3aNqNN7wJJjBSFTOK0aYvd/L4arCgFnBHsgG7nWx7YgcJZihKNbiqHD+
 XTVZ6OS4ACXaaTvJVrYZ3Z9RqnoWJoj/3s3MTZ1ZQSj2mQ5YJbp56AaLsNlcb4i/e1l7Ph1U
 /haJJnQXqUREmzKq2YHcJ3wjI1+bxD31wiACDWoPWokdJl6Sg2XptK9Jlnz9DMDBzacvNclp
 +HyzRvSRJcOHlwwDMvfZP+14Um2uHwRxLB7U0fSe4EBc0Tw6ol6bSf2i6Zvcc0LLBzCwBqc1
 hqXXkhE9bWc/ddt/YCQ166eroqvH+9vJWZgHjHWveSsKC3X3mu/2oscAuyGSi/QCTHv86K4a
 OQLk/ylaK8bnExHupZXGqpwyf5s/MPmorJXw1g2HHjPaFj3WLpsLmPfgJtKv6xJgLRYpRG3S
 gSE/dwDYeeFP8bsEVgwIgs5b7vciaFIy2eKtfllcl/n4CJX/aacVRQANhaBvyVRMb9pPd532
 uwmosMXt1SyhxdC3gxqVcyIG7Bg9kA9bpg=
IronPort-HdrOrdr: A9a23:G8WKB6pniY6nwQ0Ybi1LOuAaV5uPL9V00zEX/kB9WHVpm5Oj+P
 xGzc526farslsssSkb6K290KnpewK4yXbsibNhc4tKLzOWxFdAS7sSrLcKogeQVBEWk9Qy6U
 4OSdkGNDSdNykYsS++2njDLz9C+qjGzEnLv5an854Fd2gDAMsAjzuRSDzraXGeLDM2X6bRf6
 Dsgvav0gDQH0j/Gf7LYUXtMdKzxeHjpdbDW1orFhQn4A6BgXeD87jhCSWV2R8YTndm3aoi2X
 KtqX272oyT99WAjjPM3W7a6Jpb3PH7zMFYOcCKgs8Jbh3xlweTYph7UbHqhkF2nAjv0idurD
 D/mWZmAy1B0QKWQohzm2q15+DU6kdr15Yl8y7BvZKsm72jeNtwMbs/uWsQSGqm16NnhqAg7E
 sD5RPoi3IcZymw7RjV9pzGUQpnmVGzpmdnmekPj2ZHWY9bc7NJq5cDlXklWqvoMRiKoLzPKt
 MeR/00JcwmBW+yfjTcpC1i0dasVnM8ElOPRVUDoNWc13xTkGpix0UVycQDljNYnahNB6Vs9q
 DBKOBlhbtORsgZYeZ0A/oAW9K+DijITQjXOGyfLFz7HOUMOm7LqZTw/LIpjdvaNaAg3d83gt
 DMQVlYvWk9dwbnDtCPxoRC9lTXTGC0TV3Wu4hjDlhCy8vBrZbQQF++oWEV4rydSq8kc77mst
 6ISedrP8M=
X-IronPort-AV: E=Sophos;i="5.88,374,1635220800"; 
   d="scan'208";a="64283443"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=i050TjaqKDpNXd2M9VDRkxYWurWrEGo546q8gZs4EsCvhevMf+mdO1ungpDViTGtabpKJv/TRO6EhQODQftOkojBmAa+EQ1ILgGArIc8Cn9ChYKcC/IxfPuquNbBJWFTFPXPyF7ejh3j4/eSKADP2jJ1BOkQ/Vf6NWafQYiRN28u1si2sz7fEdHjJTju1lGFl3DyXqAWfLv84+EpB505eLALpPlAenu2QNVFaebN1EcKXakEZHrLWFqcpwwSLa0B19miExZT8gWVb+Q2G45kwh8xFPloSE8lPayTc4gsYyTOTSyoa1twmIbCR39tNBhhWnviVutxgpDFd4Yad24ZLQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=4CdaV5XZvvzfZn3L7inuYC3WF1kLNIJVIbm73IUmq90=;
 b=WteRwn7ARCpIrX5kbMLVWCmvUtfbHRLZCuSZVYVQq3UKIu8FcxdJYjru+ykXvmZ0QDJAYIsuunBKK5b2TidFsZKunSwM1baJJEARKl0qUsOAl6Vc+qhLT/6y/2fMNgfpQC+hB7+Ho6lplrJP/NDAjUWXNgrpMAtHitKWTNCWbo/J1efpWL2suS0PyTjwk4h0Huvu1XCq8FciFrDukkxcRjcZ5Ai717Ez2vLGGFqyA+KZA49hPxByopDC7OmANqq2g16sae0ev3s64GK3OZju0gcKboBMPNuHreV8RJbIYdmz/RM0XJ8PwN+IzlfjjVBfhd+y4MJynwUArz/UaDJ0pw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=4CdaV5XZvvzfZn3L7inuYC3WF1kLNIJVIbm73IUmq90=;
 b=bE3XRxeNTjVzoSK9M2xIVJO5AAhyZ4ohuDqzE30bn4mO3Ngvg085YxuQF44ezaB1INoAMZ5KYjrJRKBFGQs+Q/7j0l0y5jxo9gH84nz8Ae4MNspR57Wjq8N/UfpiIU2jMvnd/E23/Q7rRTjhbPi8u9yCIcg29oFT3/fe475mEMQ=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>, Xen-devel
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2 06/70] x86: Introduce support for CET-IBT
Thread-Topic: [PATCH v2 06/70] x86: Introduce support for CET-IBT
Thread-Index: AQHYIaGnWFhAM4OJ5EW/0Vr9kMg6BqyUpdoAgAIWjgA=
Date: Wed, 16 Feb 2022 21:54:56 +0000
Message-ID: <b2236a34-b20e-6706-c5ab-6be5b47b8f6c@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
 <20220214125127.17985-7-andrew.cooper3@citrix.com>
 <26bc666b-e9c3-7f12-6d8d-256311846233@suse.com>
In-Reply-To: <26bc666b-e9c3-7f12-6d8d-256311846233@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: b47e01eb-9a70-4ce1-4efd-08d9f196f879
x-ms-traffictypediagnostic: BL1PR03MB6165:EE_
x-microsoft-antispam-prvs: <BL1PR03MB61656BF2E20F4243BA2FADFDBA359@BL1PR03MB6165.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8273;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: Za3SUon1bTK3KXLSI9pizlCezwGLgSljHRlN74ZIvmpn/0yZe86MP0IYfIvqYA338fxSJJ2VW8rf45u/LaU1R3+tIGPgdrn99T9X9fbg4sharVP5LDfJSDCqDK12Z/yXqngKWLyi0a6J5YZ4PSecVkObrGbyH8yOCPSWaszd8wH00Gw1d3C7nOH+4STfOsZ+kmHfzGFtF/dbwfwFa0PX/avF1Qxexb4LVrpybmFmA8uOBnn1oWQjm9e5zSKWITgFZ80RVJSBWGfFsOsWROYndrhZtZrP2VGE2n4eLMr/oswypBueySF6E+r7exOQP4MF5RX/KfdMadBNSr8HA+dvrlg93LXsBQs1ou7JFUneVINWwUl9ZBuw5ixpdOe8gK5e3fCApSLE5hRU11oVwKIFo5PDOABo9m3fI832ItpF+b6TUX3oFJO4E/Z2EqrQVyV3+/7WXaGa3iTPNAR0hbDAjW0dsXGU77hM9t+Jqhoja4jnCgRFNUmxPeilTJRwOldbB6/UoSED/TJHHh8vKqX1Ez5AzDwhV17ftjjBZeOaBZib31K4RDiDh67KkyBNThx0dErDQW5lXAaGbmOuMhfvYgaXtomk8YGB1MficeZj7bU05OIYQDjfNx9Rtbcvqo/jsQh37dDtIPg+FPcluAAM0HhJ4bSXra9UVNa8uAwGMlvZxr/lJDk3hWILFRHTbqFqYQIFKG55Tvyo9d5r8s6tcMjbX7+Jwsa27MnVT/TifTXHmz0vo92AcxlqA08OI7teBIstz/luOTY0ZOFVHMl4+fCoPPm06BrL/lCTHv640lNGnyYZ8YjgO/rTAoQ8YjXiq8aVOo7NA0hTZO9p1ZOi4zsrHbyMBr4vL5MSOQByD18=
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66476007)(31696002)(316002)(64756008)(66946007)(76116006)(122000001)(966005)(53546011)(36756003)(38070700005)(8676002)(86362001)(4326008)(82960400001)(8936002)(83380400001)(66446008)(2906002)(66556008)(6506007)(508600001)(186003)(26005)(2616005)(6512007)(31686004)(71200400001)(38100700002)(91956017)(6486002)(6916009)(5660300002)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?dXFBV2ZHL1d4WUl6dkN2S1U2eFJ1M2VISDQxWFhEZ2J5L05NV3VySGF4VXg1?=
 =?utf-8?B?c2oyMUh3dCtPN1RLb2FlZHpHakNSa3ExL3ZObXhYQWIwN2ZTUmhSLy9BU0du?=
 =?utf-8?B?L1RtUjZKbkFNRy9zZXFNNEt4ZDNhamVMcnBmZzNBNnFaanlWVDB2UnpuVWI4?=
 =?utf-8?B?R0dFMHFkRFFQMjNYYkI0YTNUU2lnYkhhYUFISzdUWlFNZDhqNzJDMVNkcjNy?=
 =?utf-8?B?bStwalNoRk9EMCtsYmtkQVdpam9MUkk3by95YXNTdVlzZ3F3TXlNc2xKd0I2?=
 =?utf-8?B?ZjRRNk9mdUkxU1ZrZVdmcU4xYnplVTZNMVZhRmpDYmxyNkpPMHhpOEwyNWQ4?=
 =?utf-8?B?bVNQMVJHUmNGdGc4VldhVVFqL3lBRDZWU2c5U1lNYVk4a3ljMGkxeFNzYWxX?=
 =?utf-8?B?dytJaGRleTZJeG5HUTBpZ1lLWVVVYllrRzNIMDdwWW5xZ3BkMHVvakdOSDNI?=
 =?utf-8?B?Z0dhYXAxL3ZXbG1NRWNscjdDTGZzbGZBSURpNWt5OVNRTlk1TWhDU1JCOTRD?=
 =?utf-8?B?UU1BcUxUdlI0VFJoVlQrdFY5T2Vldks3SzJnSkdKNS8wdG92K2dDamFaYXBQ?=
 =?utf-8?B?UUZwZzRIL3pScGNVYnhmUEZ3b0R6S2FHcE9ZS2UvRzF4M0JORzhEQjVsY0lC?=
 =?utf-8?B?MTVZWm10cU1lRDdES2UvSktlQzJ3Mm9PUGhReWxtbS9TQTFMeEJZUFZqUTRk?=
 =?utf-8?B?blVHS00vc2hmT29nMVk2SGViZk5CREg4KzFHeDgwNnpLZUYydGpBZWs3WjM2?=
 =?utf-8?B?RnlaMGlUUkpIb0tlTmJENEk1dGZIVUwxZDNCUTFaa2IyUHhhVHpZelFqUnhM?=
 =?utf-8?B?Y29TQ2tRZGwvMGkwSXpndHcrdndwd2tlcld5ZElpUU5mWmpJNEU4UjRhbkwv?=
 =?utf-8?B?YjN1SVU0eDZZbDVXdnoxSWJ3V2xWRHhUSGZ5U3VmN2E3TGtKcFlHNHBMVFhC?=
 =?utf-8?B?QVU5ajM4c1NWUzJXU0NBUFQ4MkNHQ3lGT1ZCZ3E0OWJmZWliRk1JV0lzSVN1?=
 =?utf-8?B?U3ZGZFpmTXpmVlBLWXZwTFFCdThIbXduZkpaU2kyTXpveC9oTThWU21EMVBP?=
 =?utf-8?B?V21xQ3NvQ0J1aEFCY1oxT0FoNE80LzlXTEFWSWdScVBVS1pEQ2pzQm1IRlFi?=
 =?utf-8?B?WmRJRmNIbzFsZ2RWbTNzRjJrb04xMUI3NlpyV2x2bEVUL3FoenlxMmtEZ2ty?=
 =?utf-8?B?Zi9pVnZOdmhUdkVZZ1c2T2pzQXMzczB0UHFKamFobTB5SWlqSldVckZDbVFp?=
 =?utf-8?B?ckI2YjF3U0k4SnNROXc1ei8xTzZoQnRKSUphZmwyUDM3NTRSWk0xTXVBRmI5?=
 =?utf-8?B?SDkwSERVdlVBS2pLZXRQU1hPaFAzMkc1STdiZHY4ejFmQStlV1lXVWExY3Ay?=
 =?utf-8?B?MDNHc0c5REhVc0dzRUNFS2d3SVpEUU1hVjNGUDlzU3BsUE51ZHI4UWVzWFlD?=
 =?utf-8?B?c1pKa0FjQzFpYno0eGgzckJlVEEwSkhqajhveW5yV2x1aExiU1BVNzZHbDBU?=
 =?utf-8?B?a2ova3VsVnNhMTRocDIrZW5QQVVJYVB5ODU0VXc3S2JMeVJnQUdEOVd1aFJh?=
 =?utf-8?B?NWluVTFURU1DcVN4OVQrcUNJcEdmczlmN1V1WUtoTXF0YTduM0FIU3hEM1p4?=
 =?utf-8?B?Zmxkc3ZXYUZQQVFaWmpqQSttWDJrNW9LQUFack9aMjNHRFJJMnZPbjNYM3ZR?=
 =?utf-8?B?Z2Q3eGpsUmZ4MkZCMTFTNDk5SnhuMU9HMG93Q2hKc1h3ZzVOcEhnOHovcXNw?=
 =?utf-8?B?M0Q1aE9Gc2p3Ym96WnB6VnFmUzRRS2NKZWdCYnBJdDJmL1pJL0lJUStWME1F?=
 =?utf-8?B?V0lJQUZmUy9HSGU4NVgwaUVwN2VNY25wMExwL05FeWRNWmFUcVdCR1hxbXpr?=
 =?utf-8?B?S25BMzVpUTEwSHVYaktWa3ZyNzE2ZkNFKzNrU2plUENRQTFyNXUzQy9yZEJn?=
 =?utf-8?B?RVRFanVoZlAyb3ZyaEFENnhqYTV4a1RiNjFDZkp4MkN5cTZPMy9menJld3ZX?=
 =?utf-8?B?a3dTYjJoelhVTHAwbzZOUzBYYklGeEpXK2MvVk1TL2o1dDlTVkJraFBaUGVY?=
 =?utf-8?B?akpiV1FRcHhHSEpBZHZBMXVsQUgxUDVTOEhTdXRZVVlEeEw2eWlLeWdYdUh5?=
 =?utf-8?B?MDljZnExQ0kyNWJ4LzJaeklSc2Z2eHFhVU9MeXFKczU3ejcwQUNmUmp4RUpJ?=
 =?utf-8?B?UUpVcndtUFNXWm0vSGFYS3owY01ERUIyZWlFaXgzbkQyNE4zSGZHR1UrbE5V?=
 =?utf-8?B?QytTVUxVU25mMmR5TlcyejcrRTRRPT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <C1A6C3EF1758444085AB4985EF35AB9B@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b47e01eb-9a70-4ce1-4efd-08d9f196f879
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Feb 2022 21:54:56.4630
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: f25TS4uEmkBspeLHiXY5eyAfOI/rwOU+V/a/G+2MP1B2lGXfWgn2Pzh2NWzD5UoyAG8ySCHikYL3QMOq6Wct4CSL/mjNT2ZyhyRl1v+778s=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR03MB6165
X-OriginatorOrg: citrix.com

T24gMTUvMDIvMjAyMiAxNDowMSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDE0LjAyLjIwMjIg
MTM6NTAsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiAtLS0gYS94ZW4vYXJjaC94ODYvS2NvbmZp
Zw0KPj4gKysrIGIveGVuL2FyY2gveDg2L0tjb25maWcNCj4+IEBAIC0zOSw2ICszOSwxMSBAQCBj
b25maWcgSEFTX0FTX0NFVF9TUw0KPj4gIAkjIGJpbnV0aWxzID49IDIuMjkgb3IgTExWTSA+PSA2
DQo+PiAgCWRlZl9ib29sICQoYXMtaW5zdHIsd3Jzc3EgJXJheCQoY29tbWEpMDtzZXRzc2JzeSkN
Cj4+ICANCj4+ICtjb25maWcgSEFTX0NDX0NFVF9JQlQNCj4+ICsJIyBHQ0MgPj0gOSBhbmQgYmlu
dXRpbHMgPj0gMi4yOQ0KPj4gKwkjIFJldHBvbGluZSBjaGVjayB0byB3b3JrIGFyb3VuZCBodHRw
czovL2djYy5nbnUub3JnL2J1Z3ppbGxhL3Nob3dfYnVnLmNnaT9pZD05MzY1NA0KPj4gKwlkZWZf
Ym9vbCAkKGNjLW9wdGlvbiwtZmNmLXByb3RlY3Rpb249YnJhbmNoIC1tbWFudWFsLWVuZGJyIC1t
aW5kaXJlY3QtYnJhbmNoPXRodW5rLWV4dGVybikgJiYgJChhcy1pbnN0cixlbmRicjY0KQ0KPiBB
dCB0aGUgdG9wIG9mIGFzbS1kZWZucy5oIHdlIGhhdmUgYSBudW1iZXIgb2Ygc2ltaWxhcmx5IG9w
ZXJhbmQtbGVzcw0KPiBpbnN0cnVjdGlvbnMgZXhwcmVzc2VkIHZpYSAubWFjcm8gZXhwYW5kaW5n
IHRvIC5ieXRlLiBJIGRvbid0IHNlZSB3aHkNCj4gd2UgY291bGRuJ3QgZG8gc28gaGVyZSBhcyB3
ZWxsLCBlbGltaW5hdGluZyB0aGUgbmVlZCBmb3IgdGhlDQo+ICQoYXMtaW5zdHIgLi4uKS4gSW4g
ZmFjdCAuLi4NCj4NCj4+IC0tLSBhL3hlbi9hcmNoL3g4Ni9pbmNsdWRlL2FzbS9hc20tZGVmbnMu
aA0KPj4gKysrIGIveGVuL2FyY2gveDg2L2luY2x1ZGUvYXNtL2FzbS1kZWZucy5oDQo+PiBAQCAt
NTcsNiArNTcsMTIgQEANCj4+ICAgICAgSU5ESVJFQ1RfQlJBTkNIIGptcCBcYXJnDQo+PiAgLmVu
ZG0NCj4+ICANCj4+ICsjaWZkZWYgQ09ORklHX1hFTl9JQlQNCj4+ICsjIGRlZmluZSBFTkRCUjY0
IGVuZGJyNjQNCj4+ICsjZWxzZQ0KPj4gKyMgZGVmaW5lIEVOREJSNjQNCj4+ICsjZW5kaWYNCj4g
Li4uIGl0IGNvdWxkIGFsc28gYmUgdGhpcyBtYWNybyB3aGljaCBlbmRzIHVwIGNvbmRpdGlvbmFs
bHkgZW1wdHksDQo+IGJ1dCB3b3VsZCB0aGVuIHdhbnQgZXhwcmVzc2luZyBhcyBhbiBhc3NlbWJs
ZXIgbWFjcm8uIEFsYmVpdCBubywgdGhlDQo+IGxvd2VyIGNhc2UgZm9ybSB3b3VsZCBwcm9iYWJs
eSBzdGlsbCBiZSBuZWVkZWQgdG8gZGVhbCB3aXRoIGNvbXBpbGVyDQo+IGVtaXR0ZWQgaW5zbnMs
IGFzIHRoZSBjb21waWxlciBkb2Vzbid0IGFwcGVhciB0byBtYWtlIHJlY29nbml0aW9uIG9mDQo+
IHRoZSBjb21tYW5kIGxpbmUgb3B0aW9uIGRlcGVuZGVudCBvbiB0aGUgdW5kZXJseWluZyBhc3Nl
bWJsZXIncw0KPiBjYXBhYmlsaXRpZXMuDQoNCiQoYXMtaW5zdHIpIGlzbid0IG9ubHkgZm9yIGVu
ZGJyNjQuwqAgSXQgYWxzbyBmb3IgdGhlIG5vdHJhY2sgcHJlZml4LA0Kd2hpY2ggR0NDIGRvZXMg
ZW1pdCBmb3IgYW55IGZ1bmN0aW9uIHBvaW50ZXIgY2FsbCBsYXVuZGVyZWQgdGhyb3VnaCB2b2lk
DQoqIGV2ZW4gd2hlbiBldmVyeXRoaW5nIHdhcyBvdGhlcndpc2UgY2ZfY2hlY2suDQoNCkl0J3Mg
YW5vdGhlciBhcmVhIHdoZXJlIHRyZWF0aW5nIHRoZSBjZl9jaGVjay1uZXNzIGFzIHR5cGUtY2hl
Y2tpbmcNCmZhbGxzIGRvd24sIGFuZCBjcmVhdGVkIHNvbWUgdmVyeSB3ZWlyZCBidWlsZCBmYWls
dXJlcyB1bnRpbCBJIGZpZ3VyZWQNCm91dCB0aGF0IEp1ZXJnZW4ncyAiRG9uJ3QgdXNlIHRoZSBo
eXBlcmNhbGwgdGFibGUgZm9yIGNhbGxpbmcgY29tcGF0DQpoeXBlcmNhbGxzIiByZWFsbHkgZGlk
IG5lZWQgdG8gYmUgYSBwcmVyZXF1aXNpdGUuDQoNCkNFVC1JQlQgdG9vbGNoYWluIHN1cHBvcnQg
aXMgMyB5ZWFycyBvbGQgYWxyZWFkeSwgYW5kIEkgZG9uJ3QgdGhpbmsNCnRoZXJlIGlzIGFueSB2
YWx1ZSBhdHRlbXB0aW5nIHRvIHN1cHBvcnQgYSBkZXZlbG9wZXIgbWl4aW5nIGEgbmV3IEdDQw0K
YW5kIGFuY2llbnQgYmludXRpbHMuDQoNCg0KPj4gLS0tIGEveGVuL2FyY2gveDg2L2luY2x1ZGUv
YXNtL2NwdWZlYXR1cmVzLmgNCj4+ICsrKyBiL3hlbi9hcmNoL3g4Ni9pbmNsdWRlL2FzbS9jcHVm
ZWF0dXJlcy5oDQo+PiBAQCAtMzksNiArMzksNyBAQCBYRU5fQ1BVRkVBVFVSRShTQ19WRVJXX1BW
LCAgICAgICAgWDg2X1NZTlRIKDIzKSkgLyogVkVSVyB1c2VkIGJ5IFhlbiBmb3IgUFYgKi8NCj4+
ICBYRU5fQ1BVRkVBVFVSRShTQ19WRVJXX0hWTSwgICAgICAgWDg2X1NZTlRIKDI0KSkgLyogVkVS
VyB1c2VkIGJ5IFhlbiBmb3IgSFZNICovDQo+PiAgWEVOX0NQVUZFQVRVUkUoU0NfVkVSV19JRExF
LCAgICAgIFg4Nl9TWU5USCgyNSkpIC8qIFZFUlcgdXNlZCBieSBYZW4gZm9yIGlkbGUgKi8NCj4+
ICBYRU5fQ1BVRkVBVFVSRShYRU5fU0hTVEssICAgICAgICAgWDg2X1NZTlRIKDI2KSkgLyogWGVu
IHVzZXMgQ0VUIFNoYWRvdyBTdGFja3MgKi8NCj4+ICtYRU5fQ1BVRkVBVFVSRShYRU5fSUJULCAg
ICAgICAgICAgWDg2X1NZTlRIKDI3KSkgLyogWGVuIHVzZXMgQ0VUIEluZGlyZWN0IEJyYW5jaCBU
cmFja2luZyAqLw0KPiBJcyBhIGZlYXR1cmUgZmxhZyBhY3R1YWxseSB3YXJyYW50ZWQgaGVyZSwg
cmF0aGVyIHRoYW4gYSBzaW5nbGUNCj4gZ2xvYmFsIGJvb2xlYW4/IFlvdSBkb24ndCBrZXkgYW55
IGFsdGVybmF0aXZlcyBwYXRjaGluZyB0byB0aGlzDQo+IGJpdCwgdW5saWtlIHdhcyB0aGUgY2Fz
ZSBmb3IgWEVOX1NIU1RLLiBBbmQgdGhlIG9ubHkgY29uc3VtZXIgaXMNCj4gY3B1X2hhc194ZW5f
aWJ0LCBleHBhbmRpbmcgdG8gdGhlIGJvb3QgQ1BVJ3MgaW5zdGFuY2Ugb2YgdGhlIGJpdC4NCg0K
VGhlc2UgYXJlIGp1c3QgYml0cy7CoCBUaGV5IGxvbmcgcHJlZGF0ZSBhbHRlcm5hdGl2ZXMgZmlu
ZGluZyBhDQpjb252ZW5pZW50IHVzZSBmb3IgdGhlIGZvcm0sIGFuZCBhcmUgOCB0aW1lcyBtb3Jl
IGNvbXBhY3QgdGhhbiBhIGdsb2JhbA0KYm9vbGVhbiwgd2l0aCBiZXR0ZXIgbG9jYWxpdHkgb2Yg
cmVmZXJlbmNlIHRvby4NCg0KfkFuZHJldw0K


From xen-devel-bounces@lists.xenproject.org Wed Feb 16 21:58:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 21:58:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274420.469879 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKSJP-0000dv-Tf; Wed, 16 Feb 2022 21:58:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274420.469879; Wed, 16 Feb 2022 21:58:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKSJP-0000do-Qg; Wed, 16 Feb 2022 21:58:11 +0000
Received: by outflank-mailman (input) for mailman id 274420;
 Wed, 16 Feb 2022 21:58:10 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7gZM=S7=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nKSJO-0000dg-T4
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 21:58:10 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 872dda06-8f73-11ec-8eb8-a37418f5ba1a;
 Wed, 16 Feb 2022 22:58:09 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id AC80FB81ED8;
 Wed, 16 Feb 2022 21:58:08 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id B83F8C004E1;
 Wed, 16 Feb 2022 21:58:06 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 872dda06-8f73-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1645048687;
	bh=Ly7wg5PxhZBmhhl5gwxaLos1qSdn3bNezTtOtZXBFHc=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=lwfmzPCxKgB1za8hb/gwJg2MUWmejm7wBgBcT3US30Gxsf8Bg2Kry3mYqCtusQ6BG
	 t2R6u6sJf/5QKXmabK1ww9yMr1I/+9iBsK4qq584Ux6j6OcdQg2+CJudSJmQq8CURL
	 kZM82RXfo24JFLFxjlWpvdxr0EhRUiTfI5+/ml7Hv0b2XTrF3h/uPja+HZ/8JSjLAZ
	 4JSxk7505/Z2o7dsQ2QRl8OXxq4o/o9gRb6fXXu9vkJp/wc0BBuCLhDpdxHuvpLRcr
	 /CZNDpC86qbjhtkpnOhwJ1bK8ST9EoKsyrzwKkszpq+c0WSaBBPZzkMOf6dWqYer+a
	 yJ9mhS4mto0EQ==
Date: Wed, 16 Feb 2022 13:58:06 -0800 (PST)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Luca Fancellu <luca.fancellu@arm.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    Xen-devel <xen-devel@lists.xenproject.org>, Wei Chen <wei.chen@arm.com>, 
    Julien Grall <julien@xen.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Bertrand Marquis <bertrand.marquis@arm.com>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, 
    Wei Liu <wl@xen.org>, Juergen Gross <jgross@suse.com>, 
    Dario Faggioli <dfaggioli@suse.com>
Subject: Re: [PATCH 4/5] xen/cpupool: Create different cpupools at boot
 time
In-Reply-To: <53747C8B-681A-4474-B1DF-F08702322AB9@arm.com>
Message-ID: <alpine.DEB.2.22.394.2202161328430.43738@ubuntu-linux-20-04-desktop>
References: <20220215101551.23101-1-luca.fancellu@arm.com> <20220215101551.23101-5-luca.fancellu@arm.com> <alpine.DEB.2.22.394.2202151827380.43738@ubuntu-linux-20-04-desktop> <53747C8B-681A-4474-B1DF-F08702322AB9@arm.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-329033661-1645047307=:43738"
Content-ID: <alpine.DEB.2.22.394.2202161335090.43738@ubuntu-linux-20-04-desktop>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-329033661-1645047307=:43738
Content-Type: text/plain; CHARSET=UTF-8
Content-Transfer-Encoding: 8BIT
Content-ID: <alpine.DEB.2.22.394.2202161335091.43738@ubuntu-linux-20-04-desktop>

On Wed, 16 Feb 2022, Luca Fancellu wrote:
> > On 16 Feb 2022, at 02:45, Stefano Stabellini <sstabellini@kernel.org> wrote:
> > 
> > On Tue, 15 Feb 2022, Luca Fancellu wrote:
> >> Introduce an architecture specific way to create different cpupools
> >> at boot time, this is particularly useful on ARM big.LITTLE system
> >> where there might be the need to have different cpupools for each type
> >> of core, but also systems using NUMA can have different cpu pools for
> >> each node.
> >> 
> >> The feature on arm relies on a specification of the cpupools from the
> >> device tree to build pools and assign cpus to them.
> >> 
> >> Documentation is created to explain the feature.
> >> 
> >> Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
> >> ---
> >> docs/misc/arm/device-tree/cpupools.txt | 118 +++++++++++++++++++++++++
> >> xen/arch/arm/Kconfig                   |   9 ++
> >> xen/arch/arm/Makefile                  |   1 +
> >> xen/arch/arm/cpupool.c                 | 118 +++++++++++++++++++++++++
> >> xen/common/sched/cpupool.c             |   4 +-
> >> xen/include/xen/sched.h                |  11 +++
> >> 6 files changed, 260 insertions(+), 1 deletion(-)
> >> create mode 100644 docs/misc/arm/device-tree/cpupools.txt
> >> create mode 100644 xen/arch/arm/cpupool.c
> >> 
> >> diff --git a/docs/misc/arm/device-tree/cpupools.txt b/docs/misc/arm/device-tree/cpupools.txt
> >> new file mode 100644
> >> index 000000000000..7298b6394332
> >> --- /dev/null
> >> +++ b/docs/misc/arm/device-tree/cpupools.txt
> >> @@ -0,0 +1,118 @@
> >> +Boot time cpupools
> >> +==================
> >> +
> >> +On arm, when BOOT_TIME_CPUPOOLS is enabled in the Xen configuration, it is
> >> +possible to create cpupools during boot phase by specifying them in the device
> >> +tree.
> >> +
> >> +Cpupools specification nodes shall be direct childs of /chosen node.
> >> +Each cpupool node contains the following properties:
> >> +
> >> +- compatible (mandatory)
> >> +
> >> +    Must always include the compatiblity string: "xen,cpupool".
> >> +
> >> +- cpupool-id (mandatory)
> >> +
> >> +    Must be a positive integer number.
> > 
> 
> Hi Stefano,
> 
> Thank you for your review,
> 
> > Why is cpupool-id mandatory? It looks like it could be generated by Xen.
> > Or is it actually better to have the user specify it anyway?
> > 
> 
> Yes at first I thought to automatically generate that, however I needed a structure
> to map the id to the cpupool DT node. Here my doubt was about the size of the
> structure, because the user could even specify a cpupool for each cpu. I could allocate
> It dynamically and free it after domUs creation in setup_xen.
> What do you think could be the right way?

Maybe we can achieve the goal with the structure we already have:
pool_cpu_map. pool_cpu_map returns struct cpupool*, which has a
unsigned int cpupool_id field. As a pCPU can only be in 1 cpupool, we
could for each dom0less domain:

- get the xen,cpupool phandle from "domain-cpupool"
- get the first CPU phandle from "cpupool-cpus" in xen,cpupool
- from the CPU node phandle get the CPU number from "reg"
- pool_cpu_map[cpu_reg]->cpupool_id is the id that we need

It should be fast as they are all direct accesses (no walking long lists
or binary trees.)


> Or the dom0less guest could specify the id, but I like it more when using a phandle to the
> Xen,cpupool node. 

No, I think the ID is something Xen should generate.


> >> +- cpupool-cpus (mandatory)
> >> +
> >> +    Must be a list of device tree phandle to nodes describing cpus (e.g. having
> >> +    device_type = "cpu"), it can't be empty.
> >> +
> >> +- cpupool-sched (optional)
> >> +
> >> +    Must be a string having the name of a Xen scheduler, it has no effect when
> >> +    used in conjunction of a cpupool-id equal to zero, in that case the
> >> +    default Xen scheduler is selected (sched=<...> boot argument).
> > 
> > I don't get why cpupool-id == 0 should trigger a special cpupool-sched
> > behavior.
> 
> Cpupool with id 0 is embedded in Xen, it has its own special case handling in cpupool_create
> that is giving it the default scheduler. I thought it was better to leave it as it was, however the
> cpupool0 scheduler can be modified using sched= boot args as it was before.
> 
> > 
> > 
> >> +Constraints
> >> +===========
> >> +
> >> +The cpupool with id zero is implicitly created even if not specified, that pool
> >> +must have at least one cpu assigned, otherwise Xen will stop.
> >> +
> >> +Every cpu brought up by Xen will be assigned to the cpupool with id zero if it's
> >> +not assigned to any other cpupool.
> >> +
> >> +If a cpu is assigned to a cpupool, but it's not brought up correctly, Xen will
> >> +stop.
> > 
> > Thank you for documenting the constraints, but why do we have them?
> > Imagine a user specifying 3 cpu pools and imagine the cpupool-id is
> > optional and missing. We could take care of the cpupool-id generation in
> > Xen and we could also assign the default scheduler everywhere
> > cpupool-sched is not specified. Maybe I am missing something?
> 
> Yes we could make the cpupool-id optional, my doubts are in the fist comment above.
> Whenever the cpupool-sched is not specified, the current behaviour is to use the default scheduler.
> 
> > 
> > Does cpupool0 has to exist? I guess the answer could be yes, but if it
> > is specified as id of one of the pools we are fine, otherwise it could
> > be automatically generated by Xen.
> 
> Yes cpupool0 needs to exists, however it is still generated by Xen regardless of the DT
> specifications. In fact you could not specify in the DT any xen,cpupool compatible node
> with the cpupool-id == 0 and Xen will generate the cpupool0 anyway
> (Xen internals are tied with the existence of a cpupool0).
> 
> > 
> > In any case, I don't think that cpupool0 has to have the default
> > scheduler?
> 
> Ok I think I can create a function to assign a scheduler to the cpupool0 after its creation,
> I would need to test it to be sure I don’t find something strange.
> 
> > 
> > My suggestion would be:
> > 
> > - make cpupool-id optional
> > - assign automatically cpupool-ids starting from 0
> >    - respect cpupool-ids chosen by the user
> 
> Ok, it would start from 1 because cpupool0 always exists
> 
> > - if some CPUs are left out (not specified in any pool) add an extra cpupool
> >    - the extra cpupool doesn't have to be cpupool-id == 0, it could be
> >      cpupool-id == n
> >    - the extra cpupool uses the default scheduler
> 
> I gave all the unassigned cpus to cpupool0 to reflect the current behaviour, so that
> a user that doesn’t specify any xen,cpupool node ends up in a system reflecting the
> current behaviour as the feature is not enabled.
> However I can say, if no xen,cpupool nodes are found then assign cpus to cpupool0,
> else assign them to a new cpupool and...
> 
> > 
> > If the user created cpupools in device tree covering all CPUs and also
> > specified all cpupool-ids everywhere, and none of them are 0 (no cpupool
> > in the system is cpupool0) then panic. (Assuming that cpupool0 is
> > required.)
> 
> … panic if cpupool0 has no cpus.

That could be a good plan.

However, if cpupool0 has to have CPU0 (as Juergen wrote) then we could
automatically assign cpupool-id == 0 to whatever xen,cpupool node has
CPU0:

- if CPU0 is unassigned, cpupool0 is the one with all the unassigned CPUs
- if CPU0 is assigned to one of the xen,cpupool nodes, then that cpupool
  gets id == 0

Alternative we could fix the Xen limitation that cpupool0 has to have
CPU0.

In any case the good thing is that from a device interface perspective,
it doesn't matter. The device tree description doesn't have to change.
The user doesn't need to care how Xen comes up with the IDs.
--8323329-329033661-1645047307=:43738--


From xen-devel-bounces@lists.xenproject.org Wed Feb 16 21:59:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 21:59:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274427.469891 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKSL5-0001Ec-90; Wed, 16 Feb 2022 21:59:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274427.469891; Wed, 16 Feb 2022 21:59:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKSL5-0001EV-5p; Wed, 16 Feb 2022 21:59:55 +0000
Received: by outflank-mailman (input) for mailman id 274427;
 Wed, 16 Feb 2022 21:59:54 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=6VyC=S7=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nKSL4-0001EN-Fi
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 21:59:54 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c43f96eb-8f73-11ec-b215-9bbe72dcb22c;
 Wed, 16 Feb 2022 22:59:53 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c43f96eb-8f73-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645048793;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=lz7K2ltQNzFGFu55w3iG0G/eidwsqwDIT34Zd0SFUIE=;
  b=CKf1Lyql0A2WzH+1Noto7ymS+P+rTX4t4LSA+Uiqp1Jy32dZWxD07r2m
   sr302EqlrcrXv8eXL/SOGcUaDwba4lEU0I2ZgUn9hI4L3IdiLqIUl4vfi
   tjodv7jnHmIbCq6i5eVjPicVnxQQ0XvzjfcKKyMDCKTPr6gGbDNHSxNjO
   s=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: /zBoNJfBC5Po0FR/6Tg+YuXKwf6kwPlJMOBbtRMHHzV/b5iy7r8ngpA4xlrGmpgxf/owLY1Ngq
 Cn7DABKDjmnYoxTdBFGgFrlO/ex1QKWNqNCvZ1o8GTyus3qbYCaWEqpMNfPRrZwcEEAH6XMDzV
 fzYL1r2X38++KNCXxCAGorZ2K89SxJEtSTQowEHg10LL+qPJTmxc+Bx235/t2QnXCc7taTpGCI
 EFNKHARObsTW3wmz/Q3uln7JkHt8Im06mEQsTpGJ52G7+jkdqWIA5gQTv4C2pm9iluXICpfuVG
 T20w5vGksgJgMFPlrdMK3rHV
X-SBRS: 5.1
X-MesageID: 64283660
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:g5okI6M7HeVs5MPvrR32kcFynXyQoLVcMsEvi/4bfWQNrUoh0WAGn
 WJJUWrUP//bM2X8LYtzao+x9UpVvpCHnd5nTAto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6UUsxNbVU8En1500s9w7RRbrNA2rBVPSvc4
 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq
 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYoxqTpY5p5
 fZSj7mbeCQ1M7LLk8Y5SjANRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs
 6VFdnZdNXhvhMrvqF6/YsBqit4uM4/AO4QHt2s75TrYEewnUdbIRKCiCdpwgmtq1psQQ662i
 8wxOTZTZyzKUhN1Ig1IEo0Dp+frm1LBSmgNwL6SjfVuuDWCpOBr65DhKMHQe8CKbcxNk1yEu
 3nd+GDkHhAdMsfZwj2AmlquifXIhjjTQ58JGfuz8fsCqE2ewCkfBQMbUXO/oOKlkQiuVtRHM
 UsW9yEy668o+ySDS9DnWhSirX2svxgCWsFRGek39AGMzKXP5w+TQGMDS1Zpd9gOpMIwAzsw2
 TehndnkGDhuu729Um+G+/GfqjbaESoIKW4PYwcUQA1D5MPsyKkolQ7GRNtnFK+zj/X2FCv2z
 jTMqzIx74j/luZSif/9pwqexWvx+N6ZFWbZ+zk7QEqK9DknfKOGeLaNwmn48ftfK427akCo6
 S1sd9el0MgCCpSElSqoSeoLHa206/vtDAAwkWKDDLF6qW3zpifLkZR4pWgneRw3appslSrBP
 ReL0T698qO/K5dDgUVfR4uqQ/onwqH7fTgOfqCFN4EeCnSdmeLuwc2PWaJy9z21+KTPuftmU
 Xt+TSpKJSxHYUiA5GDrL9rxKZdxmkgDKZr7HPgXNSiP37uEf2KyQrwYKlaIZe1RxPra/FmEr
 o8FZprbkk83vAjCjs//q9N7wbcidyZTOHwLg5YPKr7rzvRORAnN9MM9MZt+Itc4zsy5Z8/D/
 22nW18w9bYMrSavFOl+UVg6MOmHdc8m9RoTZHVwVX71iylLSdv+t883KspoFYTLAcQ+lJaYu
 dFeIJ7eahmOIxyakwkggW7V9twyLk/62ljXYkJIolEXJvZdeuAAwfe9FiPH/ygSFCun88w4p
 ryrzATARpQfAQ9lCa7rhDiHljtdZFARx7B/WVXmON5WdBm++YRmMXWp3PQ2P9sNOVPIwT7Dj
 1SaBhIRpO/spY4p8YaW2fDY/tnxS+YuTFBHG2T77KqtMXWI9GSU3oIdAv2DeirQVT2o9fz6N
 /lV1fz1LNYOgE1O79hnC79uwK9nv4nvqrZWwx5KBnLOa1j3WLpsLmPfhZtEt7FXx68fsgyzA
 xrd9t5fMLSPGcXkDF9Oe1Z1MrXdjakZw2CA4+40LUP24D5M0ICGCUgCbQORjCF9LaduNN93y
 +kWp8NLuRe0jQAnM4jag3kMpXiMNHEJT44uqooeXN3wkgMux1xPPc7cByvx7M3dYtlAKBB3c
 Dqdha6EjLVA3EvSNXE0ECGVj+ZagJ0PvjFMzUMDeAvVyoaU2Kdv0U0D6ykzQyRU0g5DgrB6N
 WVcPkFoIbmDomVzj89ZUmHwQwxMCXV1IKAqJ4flQIEBc3SVaw==
IronPort-HdrOrdr: A9a23:kVBsaaoX2U/AQj+oAVx6sqEaV5uPL9V00zEX/kB9WHVpm5Oj+P
 xGzc526farslsssSkb6K290KnpewK4yXbsibNhc4tKLzOWxFdAS7sSrLcKogeQVBEWk9Qy6U
 4OSdkGNDSdNykYsS++2njDLz9C+qjGzEnLv5an854Fd2gDAMsAjzuRSDzraXGeLDM2X6bRf6
 Dsgvav0gDQH0j/Gf7LYUXtMdKzxeHjpdbDW1orFhQn4A6BgXeD87jhCSWV2R8YTndm3aoi2X
 KtqX272oyT99WAjjPM3W7a6Jpb3PH7zMFYOcCKgs8Jbh3xlweTYph7UbHqhkF2nAjv0idurD
 D/mWZmAy1B0QKWQohzm2q15+DU6kdr15Yl8y7BvZKsm72jeNtwMbs/uWsQSGqm16NnhqAg7E
 sD5RPoi3IcZymw7RjV9pzGUQpnmVGzpmdnmekPj2ZHWY9bc7NJq5cDlXklWqvoMRiKoLzPKt
 MeR/00JcwmBW+yfjTcpC1i0dasVnM8ElOPRVUDoNWc13xTkGpix0UVycQDljNYnahNB6Vs9q
 DBKOBlhbtORsgZYeZ0A/oAW9K+DijITQjXOGyfLFz7HOUMOm7LqZTw/LIpjdvaNaAg3d83gt
 DMQVlYvWk9dwbnDtCPxoRC9lTXTGC0TV3Wu4hjDlhCy8vBrZbQQF++oWEV4rydSq8kc77mst
 6ISedrP8M=
X-IronPort-AV: E=Sophos;i="5.88,374,1635220800"; 
   d="scan'208";a="64283660"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=aPaAFVqsPrBekjiCiEEIfL0ppY+3vfS5vzNOMyIzMwF3t4KHdF/HjiYxQBu1ROVBKlQXpYRKaCfnVxRbXQbpIKI2y3q7j1RMI6EmUKCg+YHrljmruXjKtOlU5zNr5KOVdrPLI+9I4uV5G4+nELHbVSQY9qBi6tSJBdyi1LVtEWbyuKDxOc1Fhg/MxtoOQ4ljFc6ockT4R5RHi6Dk5zHnljfCyQ/5j59wMjMmy6gNtSebTvL/AFE9CAP+SImuWbrBWcMFX0PSLJzoiWRcqeKjwST75lAb1asz68WoMYRSQKeTosximY5b3+rx7V37Hxa7lI0jvVe/5uB1wf+ZAnG90A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=lz7K2ltQNzFGFu55w3iG0G/eidwsqwDIT34Zd0SFUIE=;
 b=c1Dixyo7HBcYOI3s62cxskry01BLbsddT1JHDhJS8ODLDIRqRJK0rp0lug707C3weqrHnlKzej0OnRYoeiDScTcKkhYTt+A3oMykGKzvxcyH+K4WJ4ycI5E4xMwOstb0Ryh15lXRwivtLjSWo/KLBuJOXxRX1ioipsZ6mzsZ9bbtlj8SWPGg3qh2eAr1c0kxLRSfifMtSAzO3V3eWuope5dx/xpAUN+Ey72YMd6iS+MNxPLvn+7g6I6GgPanacAy9UMJjvjSmE3FAEJRipqJgVKoGKJMTm+FvF3USNJ18oGzvExgCKhHZuylTI1uAIlG+gyLEV5tv6hra09UCiXnnA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=lz7K2ltQNzFGFu55w3iG0G/eidwsqwDIT34Zd0SFUIE=;
 b=S+uNRrO2vXlddlH68cMOZB+Xzeoigbsu1+3zO8t0jL+9m7KhhkzpN/3ExZzt2zYJqPTFA+JdoUrHqC+NtCA99Tbqg3UTsUlQ6t5gRJPNNSLBQaYARudFq+EZ4EU3t84q2hqBgU6VhsmZ/p+VQyOETB3BikMVsYK71TAdpZEzRKo=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>, Roger Pau Monne <roger.pau@citrix.com>,
	Wei Liu <wl@xen.org>
CC: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
	<julien@xen.org>, Juergen Gross <jgross@suse.com>, Daniel Smith
	<dpsmith@apertussolutions.com>,
	=?utf-8?B?TWFyZWsgTWFyY3p5a293c2tpLUfDs3JlY2tp?=
	<marmarek@invisiblethingslab.com>, Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2 00/70] x86: Support for CET Indirect Branch Tracking
Thread-Topic: [PATCH v2 00/70] x86: Support for CET Indirect Branch Tracking
Thread-Index: AQHYIaGi+1XAXGQfKUGTLygtpBu/SKyTBUWAgAAJC4CAAAkaAIAABn4AgAOf2oA=
Date: Wed, 16 Feb 2022 21:59:47 +0000
Message-ID: <9bcbd2f9-f713-cb56-abdd-baef5180a964@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
 <c471dcc2-8a91-60b8-ba5d-58874752e4d7@citrix.com>
 <218de2dc-6dd8-4e13-3288-36448e47de7f@suse.com>
 <8c6dd7d0-11e6-9b8a-66fc-f1a4998c074b@citrix.com>
 <83e15c5d-f48b-a6f2-ebca-e416bdef1093@suse.com>
In-Reply-To: <83e15c5d-f48b-a6f2-ebca-e416bdef1093@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 846026e6-20a3-4c16-0dd4-08d9f197a5f5
x-ms-traffictypediagnostic: BN6PR03MB3233:EE_
x-microsoft-antispam-prvs: <BN6PR03MB3233E5FA193BC0B166A9C855BA359@BN6PR03MB3233.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: qW7/N7yEe+1gzx+iqkYjj3/HoE1i/2Y+QHKRWdxvVMZP271t8uU7gVqgQ15Yw7bJewGvAdaN19BMENnbxY2mro83ZFG0emkw4gQ/QEcDORk/FkCj8f3pg1g+/Kuctw/CPzDYjPO0p3D9EWb8IbkpamH55aW7Kcv7o1Lo45+OIOfF7mAFYOTxZQiOb7voQAyCH/x5MvM/crjm4PKHenr0YJzoMuTw3RSPGj5DwMC1wiF56JnkVuperR47YJokrBOWQyFAvhhFIAwdMjjHeG9t7B3Sbmt5cnvgW/1QwnzCQoONIvibDGPD3qu4D0ywQzr6nEe91vIFGc7QugGBnhg+Jax/UTPsrHWozMQaVdIORTwvp5me4IA7pBBfKPXET7LojkGHz01sXWJ/Sr65rDc2VqOmo4EDZmwGN+eL8iBuPUwog7ft+Q9l8PByHT7iVQGezm8w18b1mTnnIaa4W2UTkvPhheeoL49zXQ6BrDlGwbUaDK6hZLsbSSwfMr+m0F/4+aikFyCqP7xDjBmDRHf0pDRgD5g0xen1sNLYhKswtTgPlosFVGhMguttXo3jAbruACSX0oQ0pCbAko/E+Wv1iA2siNz6NNzKRN3kWrOORfvowmkEzUnyGBUWt7gbgQ5N1IS5L2ZflOWu7lvuZSJ/q+xWull7xiF2BCaHR07blV5uadziZiGVjy80TBdyyS5g2EeT8rcICSdLpLfjYm5JY5+TL1dGYtzIF9R9/KAQzwpoPSSYfkPNyZc48bt8LAS32yuwnUyxfmpvXDSXOMlcdR87NN/ilYLtZ+pTDU/pyIfmIqSuQGPE+jcxQG2XqapJcUyilM2tg+LWKnp3bPMc1jIOrygFVr/otM/oRfxT6B8=
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(82960400001)(8936002)(5660300002)(54906003)(122000001)(38100700002)(6486002)(26005)(186003)(966005)(71200400001)(6512007)(6506007)(53546011)(2616005)(508600001)(66476007)(66446008)(8676002)(38070700005)(316002)(4326008)(64756008)(66556008)(91956017)(66946007)(76116006)(110136005)(31696002)(31686004)(2906002)(86362001)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?b0dxY2VpY2Y5UnZKQ2NBZmtVb1pBMXc5YVRJc05RL0dRNTAzTkFXakFZSG83?=
 =?utf-8?B?MUR5ZlRWdHppTm9pcjlrSkVIWmhmc0h3aklhcXg4NGYvVWtLTC9kWWRCS2Vy?=
 =?utf-8?B?SkloMUxidGFHbkxrNzgwcWd3RXdRM2t6Z3lNbWsxSFJKSytFaERjWGFzOUFW?=
 =?utf-8?B?dTJKSlFKTHRadlZ2VXNwMU11Vk9ydHFXUFBXUlpqaFEycVNwRVVUYmE3MGFr?=
 =?utf-8?B?Z2dHQ0UxUGVuN2Rtd0NHMStMckVyN3RocDhLaUJXaGtXcXk5QTJNZUxIZHRH?=
 =?utf-8?B?b1pENnY0U3BXeis1eHo5QkxvbnNFSUx4cW9pWGhpT2V3VWlZeElBQjBBWHRn?=
 =?utf-8?B?WFBTbzI5ZWVmM2VzN1JTbWpyVE9zS3g2TGhVd1pYMFh2RFJZN0c3cXZJelM5?=
 =?utf-8?B?cllvQ25RLy9OTklPcG16VXNyWnREOUUzL3MzaDl2SVFmSzIvTVk4dGRsS3ND?=
 =?utf-8?B?WEs5Q09CdzZsd0Rob3VhOHdITGc4UmF0YWtsODViNmtGb2c2QlJMU0p2NTFr?=
 =?utf-8?B?dnFiMy8rS0FDYmRpZWJHNTl6U25BVzV2MDZ3NUt3cU9QdU5VeTBaaHk5Vkpw?=
 =?utf-8?B?YTNhVXdDcjVaaG5LVm5JTXk0aFRXaE9jbms2MzhoRUhoZlpMb2dkYlR4WjNh?=
 =?utf-8?B?TDNkRWhkVVp3cEdxM1paQ3VxbFhXa2VCNW00K3Z5Uml2YlpHVEVaVkp2ZktP?=
 =?utf-8?B?MkluRk9nNXhQdXlKUFhrNGxWUE1mcmZLbHRUczFJT2c4RUs1MDFBaDdjenRG?=
 =?utf-8?B?Y3dIVVJXYTkwaStqeGVPRVB3TG1mZVR6cE55NFA0KzI5OCtvK1MrR3A1SGho?=
 =?utf-8?B?cE5YMWdvV3ovQ0NxRnFQQ3Vpa3ZjZ2hjQ1NNbGZVSDdVQWZhMS9ndXlhSmNk?=
 =?utf-8?B?NkM0TFdVcm1QdGNDbUlDbVNRckFQUUFNWUtJMDNpQ1k3bnJnL3RpZEF2M0VW?=
 =?utf-8?B?SDJZazJWWHBBNURDeXRoNlU0VEtNUXZYVFFidkd2YjljTDFqckhjVkpSc0tp?=
 =?utf-8?B?OERmSkI3eEwycXY1ZDArTXhGL0ZiNHplQUtyZlRqTGhoRjRHWGltclZxNEVx?=
 =?utf-8?B?dDJvNzVobU9IeTVRY0huOVBWK1UwanhBd1VvKzR4eE02bU94NkdEcUxVbHVK?=
 =?utf-8?B?Z1FUSDZlWlFUUHpwcDB2K3pBNHV4YXkyOEQ3K1BwU1UrL1pZVlFIenBuZHRP?=
 =?utf-8?B?YysyaVN2eTFIQzBFclNITTFHazEySW5VRHF6ZGJtd1h6Vy9sdHlseHA5SDlw?=
 =?utf-8?B?Qlp3REFCdVN3RXZYNGw4TG0zTytXNTc1ZzdjSVZhdURaYjdwZUQrVjZYdGpZ?=
 =?utf-8?B?VDkrNG0wUHBIdHJQOG5GMDlqUTFGSFZGZm53UzF1OU5kbkx1RENxZmo5TGRR?=
 =?utf-8?B?VExDMjVnSWxuUEJ4Vlp3UkxmRFVDSTdIRXpLc0xMNGtPdkNOdUtlSzNGaDN2?=
 =?utf-8?B?MlEwWWc3c21qcVAwWmxpWU1pTURzdG1NOHU2N0phdTFxMTBYZzV1RmIxOGJo?=
 =?utf-8?B?dUthS2J3ZjV4SEt0ODhCZWxKbkVNdFMycmhDUTFWbEVUY3ZZVXJTcmRXeGhx?=
 =?utf-8?B?L25QSGxSRVlIOVFIVkhSMUMwRjAxdXlEM0F4cGZGT2JuT05FVTF6b1ZTMXRo?=
 =?utf-8?B?Rm9sSlE2UW8xRGsra01DTlZXK3BRdENHRjdYWjRzYjN0YU1WcStTZ2V2N1Bq?=
 =?utf-8?B?ak5QWFUrbW1pU2NFNHZGcmFwMWlwbjJXclZHazRaOFFWRjhidVdqWFlteUlt?=
 =?utf-8?B?Sk0yNWthaDhOSDdRSkx4b0JBUnpPaFZkUkgxWWNid1dqWXJGWU5sRTlPWHVD?=
 =?utf-8?B?SUJTbjQwMzBOeHNpc0tqWTQ5Wk9uZFR5cTl2Szk3TUR3NTYxRjhTQnZDUXFI?=
 =?utf-8?B?OUZLbStwK0tQVHE5MHR3ZXhmMTI1aDlXV2xVQTQ4TzJrK21aYmxOeGJQZmlO?=
 =?utf-8?B?QjZWbUd0N3BFL1A2S0Z4czNsVjl3L0tjRSs5TmFZeWROU0ZLTkJiVGRKVmUv?=
 =?utf-8?B?WDk1bnRzNnRyL25MbEJvQjBDbnlzNUtRdjZrbWduL3BWQnJYRHAvRkJQNlJB?=
 =?utf-8?B?Z1Z6Zm9QNituQklTMVhiV3dpV0ZZU2ZuL2V5SDZyL0pnNTRZZEFCVUMwMlQx?=
 =?utf-8?B?Ui9rRXhKQTFON3h1QUsxU3VLTnpiWitiWi9FWkk4VWprdEN2THVGcVJsSkh1?=
 =?utf-8?B?MnIzZVExTkhvc1R2QjJkaUphQW5NclU3dWR6WnRCNThUWEFQQUhPRGdJbmMz?=
 =?utf-8?B?MytqNFFSbVdHaGZwVFBIQ2pPTVd3PT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <D9B3641339785F4D82765FA4A10175EE@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 846026e6-20a3-4c16-0dd4-08d9f197a5f5
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Feb 2022 21:59:47.5510
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 8Bzu9LZvS5gjtqb0DXAhjJWtAgziLBAYe1T6Xrp7qE9X3CgwKcC524usMYzp4ukIAJC7g6N9PeMqJokbewWLgL1sQV2BSVau0FWAutc8b54=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB3233
X-OriginatorOrg: citrix.com

T24gMTQvMDIvMjAyMiAxNDozOCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDE0LjAyLjIwMjIg
MTU6MTUsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBPbiAxNC8wMi8yMDIyIDEzOjQzLCBKYW4g
QmV1bGljaCB3cm90ZToNCj4+PiBPbiAxNC4wMi4yMDIyIDE0OjEwLCBBbmRyZXcgQ29vcGVyIHdy
b3RlOg0KPj4+PiBPbiAxNC8wMi8yMDIyIDEyOjUwLCBBbmRyZXcgQ29vcGVyIHdyb3RlOg0KPj4+
Pj4gQ0VUIEluZGlyZWN0IEJyYW5jaCBUcmFja2luZyBpcyBhIGhhcmR3YXJlIGZlYXR1cmUgZGVz
aWduZWQgdG8gcHJvdGVjdCBhZ2FpbnN0DQo+Pj4+PiBmb3J3YXJkLWVkZ2UgY29udHJvbCBmbG93
IGhpamFja2luZyAoQ2FsbC9KdW1wIG9yaWVudGVkIHByb2dyYW1taW5nKSwgYW5kIGlzIGENCj4+
Pj4+IGNvbXBhbmlvbiBmZWF0dXJlIHRvIENFVCBTaGFkb3cgU3RhY2tzIGFkZGVkIGluIFhlbiA0
LjE0Lg0KPj4+Pj4NCj4+Pj4+IFBhdGNoZXMgMSB0aHJ1IDUgYXJlIHByZXJlcXVpc2l0ZXMuICBQ
YXRjaGVzIDYgdGhydSA2MCBhcmUgZmFpcmx5IG1lY2hhbmljYWwNCj4+Pj4+IGFubm90YXRpb25z
IG9mIGZ1bmN0aW9uIHBvaW50ZXIgdGFyZ2V0cy4gIFBhdGNoZXMgNjEgdGhydSA3MCBhcmUgdGhl
IGZpbmFsDQo+Pj4+PiBlbmFibGVtZW50IG9mIENFVC1JQlQuDQo+Pj4+Pg0KPj4+Pj4gVGhpcyBz
ZXJpZXMgZnVuY3Rpb25zIGNvcnJlY3RseSB3aXRoIEdDQyA5IGFuZCBsYXRlciwgYWx0aG91Z2gg
YW4gZXhwZXJpbWVudGFsDQo+Pj4+PiBHQ0MgcGF0Y2ggaXMgcmVxdWlyZWQgdG8gZ2V0IG1vcmUg
aGVscGZ1bCB0eXBlY2hlY2tpbmcgYXQgYnVpbGQgdGltZS4NCj4+Pj4+DQo+Pj4+PiBUZXN0ZWQg
b24gYSBUaWdlckxha2UgTlVDLg0KPj4+Pj4NCj4+Pj4+IENJIHBpcGVsaW5lczoNCj4+Pj4+ICAg
aHR0cHM6Ly9naXRsYWIuY29tL3hlbi1wcm9qZWN0L3Blb3BsZS9hbmR5aGhwL3hlbi8tL3BpcGVs
aW5lcy80NzA0NTM2NTINCj4+Pj4+ICAgaHR0cHM6Ly9jaXJydXMtY2kuY29tL2J1aWxkLzQ5NjIz
MDgzNjIzMzgzMDQNCj4+Pj4+DQo+Pj4+PiBNYWpvciBjaGFuZ2VzIGZyb20gdjE6DQo+Pj4+PiAg
KiBCb2lsZXJwbGF0ZSBmb3IgbWVjaGFuaWNhbCBjb21taXRzDQo+Pj4+PiAgKiBVRUZJIHJ1bnRp
bWUgc2VydmljZXMgdW5jb25kaXRpb25hbGx5IGRpc2FibGUgSUJUDQo+Pj4+PiAgKiBDb21wcmVo
ZW5zaXZlIGJ1aWxkIHRpbWUgY2hlY2sgZm9yIGVtYmVkZGVkIGVuZGJyJ3MNCj4+Pj4gVGhlcmUn
cyBvbmUgdGhpbmcgSSBjb25zaWRlcmVkLCBhbmQgd2FudGVkIHRvIGRpc2N1c3MuDQo+Pj4+DQo+
Pj4+IEknbSB0ZW1wdGVkIHRvIHJlbmFtZSBjZl9jaGVjayB0byBjZmkgZm9yIHRoZSBmdW5jdGlv
biBhbm5vdGF0aW9uLCBhcw0KPj4+PiBpdCdzIHNob3J0ZXIgd2l0aG91dCByZWR1Y2luZyBjbGFy
aXR5Lg0KPj4+IFdoYXQgd291bGQgdGhlICdpJyBzdGFuZCBmb3IgaW4gdGhpcyBhY3JvbnltPw0K
Pj4gVGhlIGNsYXNzIG9mIHRlY2huaXF1ZXMgaXMgY2FsbGVkIENvbnRyb2wgRmxvdyBJbnRlZ3Jp
dHkuDQo+Pg0KPj4+ICBJcnJlc3BlY3RpdmUgb2YgdGhlIGFuc3dlcg0KPj4+IEknZCBsaWtlIHRv
IHBvaW50IG91dCB0aGUgbmFtZSBjb2xsaXNpb24gd2l0aCB0aGUgQ0ZJIGRpcmVjdGl2ZXMgYXQN
Cj4+PiBhc3NlbWJsZXIgbGV2ZWwuIFRoaXMgaXNuJ3QgbmVjZXNzYXJpbHkgYW4gb2JqZWN0aW9u
IChJJ20gY2VydGFpbmx5IGZvcg0KPj4+IHNob3J0ZW5pbmcpLCBidXQgd2Ugd2FudCB0byBhdm9p
ZCBpbnRyb2R1Y2luZyBjb25mdXNpb24uDQo+PiBJIGRvdWJ0IHRoZXJlIGlzIGNvbmZ1c2lvbiB0
byBiZSBoYWQgaGVyZS7CoCBPbmUgaXMgZW50aXJlbHkgYSBjb21waWxlcg0KPj4gY29uc3RydWN0
IHdoaWNoIHR1cm5zIGludG8gRU5EQlI2NCBpbnN0cnVjdGlvbnMgaW4gdGhlIGFzc2VtYmxlciwg
YW5kDQo+PiBvbmUgaXMgYSBnZW5lcmFsIHRvb2xjaGFpbiBjb25zdHJ1Y3Qgd2UgZXhwbGljaXRs
eSBkaXNhYmxlLg0KPiBIbW0uIEknbSBzdGlsbCBhdCBiZXN0IGhhbGYgY29udmluY2VkLiBQbHVz
IHdlIGdlbmVyYWxseSBoYXZlIGJlZW4NCj4gbmFtaW5nIG91ciBzaG9ydGhhbmRzIGFmdGVyIHRo
ZSBhY3R1YWwgYXR0cmlidXRlIG5hbWVzLiBCeSB1c2luZw0KPiAiY2ZpIiBzdWNoIGEgY29ubmVj
dGlvbiB3b3VsZCBhbHNvIGJlIGxhcmdlbHkgbG9zdC4gUm9nZXIsIFdlaSwNCj4gb3RoZXJzIC0g
ZG8geW91IG9waW5pb25zIGVpdGhlciB3YXk/DQoNCk15IHBvaW50IGlzIHRoaXMuwqAgRG9pbmcg
bm90aGluZyBpcyBteSBlYXNpZXN0IG9wdGlvbi4NCg0KQnV0IGlmIGFueW9uZSBoYXMgbGVuZ3Ro
L2FsdGVybmF0aXZlIHN1Z2dlc3Rpb25zLCBkZWFsaW5nIHdpdGggdGhlbSBub3cNCmlzIGdvaW5n
IHRvIGJlIGluZmluaXRlbHkgZWFzaWVyIHRoYW4gb25jZSB0aGlzIHNlcmllcyBpcyBjb21taXR0
ZWQuDQoNCn5BbmRyZXcNCg==


From xen-devel-bounces@lists.xenproject.org Wed Feb 16 22:17:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 16 Feb 2022 22:17:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274440.469901 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKScJ-0003fZ-Sq; Wed, 16 Feb 2022 22:17:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274440.469901; Wed, 16 Feb 2022 22:17:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKScJ-0003fS-Pp; Wed, 16 Feb 2022 22:17:43 +0000
Received: by outflank-mailman (input) for mailman id 274440;
 Wed, 16 Feb 2022 22:17:42 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=6VyC=S7=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nKScI-0003fM-Fj
 for xen-devel@lists.xenproject.org; Wed, 16 Feb 2022 22:17:42 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 403a8068-8f76-11ec-8eb8-a37418f5ba1a;
 Wed, 16 Feb 2022 23:17:40 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 403a8068-8f76-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645049860;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=2vtSUANBn5bNleSgmkYjLB8eOtq0KzrCK+Zol2UqbnA=;
  b=PWsiP0a0lQteXqosD9Rs8T124SexzqV4l10LGBf+Qo6oUzi+Egc+KlPE
   VeCuoW+DYvlYfyMDBGMCj6M/Q3kLJmyCknn4BrYlIXEv6N4ehC9wyIm+M
   7F+vTBNPQEbw+wEO0AXKLFAoob7xlwIrhdTPYFmN3CqG8L0C4giXclKAd
   Q=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: w5QLhn1Kpfa99f4mK21Pj2JUGgc9doAvCNWy9F4dROV0l+AuOvlisfswTyvUs+3Jvc0m5axxiD
 ejjrdGIR4sgoMa/Ms6BKAmR8BEAamHFOA246n3GlBenEbfHoxt3tka48gNFGaj2HrjvhMKFd4z
 aTGThgq4ULMudnDLPCxoUqhbJnR5LZUbQsT3BgB1Q1i2z3MLNpvkCMrqByxuKKVLGxM+sJWpi5
 WZuU0sSAbecaU0exSdHLBOH+vEAODXS8jyCNw2V++YHSZFRrChirEGjbhGxCn2w3YmLgnhm3j8
 k6PGB32N2moPl4IRcaprjMEl
X-SBRS: 5.1
X-MesageID: 64383997
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:JDg+RqN+riwTtdrvrR1DkMFynXyQoLVcMsEvi/4bfWQNrUoh0TZUy
 GZJD2jXPa3bamvxKd4gbt7lpEMO6p+Em4MxGwto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6UUsxNbVU8En1500s9w7RRbrNA2rBVPSvc4
 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq
 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYoweEmfZg+
 etxiZ3zSTwoLKfKu/wbajANRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs
 6VFdnZdNXhvhMrvqF6/YsBqit4uM4/AO4QHt2s75TrYEewnUdbIRKCiCdpwgmtr1psfTKm2i
 8wxdxNGShfbWiB0OFYaN7klmdaSoGmnbGgNwL6SjfVuuDWCpOBr65D9PdyQdtGUSMF9mkeDu
 nmA72n/GgsdNtGU1XyC6H3Eru3AhyTgQ6oJCaa1sPVthTW7xGYeFRkXXluTuuSihwi1XNc3F
 qAP0nNw9+5orhXtF4SjGU3jyJKZgvICc+hdFcsr2T+x9quX4z2YFGICbSZHUfVz4afaWgcW/
 lOOmtroAxlmv7uUVW+R+9+okN+iBcQGBTRcPHFZFGPp9/Gm+dhu1UyXEr6PBYbo1oWdJN3m/
 9ydQMHSbZ03hNVD6ai09Euvb9mE9smQFV5dCuk6swuYAuJFiGyNOtTABbvzt68owGOlor+p5
 iVsdy+2tr1mMH11vHbRKNjh5Znwjxp/DBXSgER0A74q/Cm39niocOh4uW8ieBY0a5xVKG6wO
 ic/XD+9ArcJYRNGioctPeqM5zkCl/C8RbwJqNiIBjaxXnSBXFDep3w/DaJh92vsjFItgckC1
 WSzKq6R4YIhIf0/llKeHr5FuZdyn3xW7T6DFPjTkkX8uZLDNSH9dFvwGAbXBgzPxPjf+1u9H
 hc2H5bi9iizp8WkMnmNqt9MdwlXRZX5bLivw/Fqmie4ClMOMEkqCuPLwKNnfIpgnq9PkfzP8
 G37UUhdoGcTT1WeQelTQnw8Or7pQ7hlqnc3YX4lMVqygiBxaoez9qYPMZAweOB/puBkyPd1S
 dgDetmBXasTGmiWpWxFYMmvtpFmeTSqmRmKY3ivbg8gcsMyXAfO4NLlIFfirXFcEiqtuMIii
 LS8zQeHE4EbTgFvAZ+OOvKixl+8p1YHn+d2UxeaK9VfYhy0ooNrNzbwnrk8JMRVcUfPwT6T1
 gC3BxYEpLaS/99poYeR3a3d9tWnCepzGEZeDlL317fuOHmI5HenzK9BTP2MIWLXWlTr9fjwf
 u5S1fz9bqEKxQ4Yr4pmHr935qsi/N+z9aRCxwFpEXiXPVSmDrRsfiuP0cVV7/Afw7ZYvU29W
 16V+8kcMrKMYZu3HFkULQsjT+KCyfBLxWWCsaVreB33tH1t4b6KcUROJB3d2iVSIYx8PJ4h3
 ep86tUd7Bayi0ZyP9uL5syOG79g8pDUv30bi6wn
IronPort-HdrOrdr: A9a23:xu0WsqvVBExsFHm3b9Ct/7w07skC0oMji2hC6mlwRA09TyXGra
 +TdaUguSMc1gx9ZJh5o6H8BEGBKUmskKKceeEqTPmftXrdyReVxeZZnMrfKlzbamLDH4tmu5
 uIHJIOceEYYWIK7voSpTPIaerIo+P3sJxA592ut0uFJDsCA8oLjmdE40SgYzZLrWF9dMAE/f
 Gnl656Tk+bCBIqh7OAdx44tob41r/2vaOjRSRDKw8s6QGIgz/twqX9CQKk0hAXVC4K6as+8E
 De+jaJpZmLgrWe8FvxxmXT55NZlJ/K0d1YHvGBjcATN3HFlhuoXoJ8QLeP1QpF4t1HqWxa1e
 UkkS1QePib2EmhOF1dZiGdgjUI5Qxer0MKD2Xo2UcL7/aJHw7SQPAx+r6xOiGplXbI+usMjZ
 6jlljpx6a+R3n77VXAzsmNWBdwmkWup30+1eYVknxESIMbLKRctIoF4SpuYd099Q/Bmcga+d
 NVfYrhDTdtACenRmGcunMqzM2nX3w1EBvDSk8eutaN2zwTmHxi1UMXyMEWg39FrfsGOtV5zv
 WBNr4tmKBFT8cQY644DOAdQdGvAmiIRR7XKmqdLVnuCalCMXPQrJz85qkz+YiRCdE15Yp3nI
 6EXEJTtGY0dU6rAcqS3IdT+hSIW2m5VSSF8LAW23G4gMyLeFPGC1zwdLkeqbrWnxxEOLypZx
 +aAuMiP8Pe
X-IronPort-AV: E=Sophos;i="5.88,374,1635220800"; 
   d="scan'208";a="64383997"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=MGkMNq4hA3ym1fEM8tbqDrZS1/L0yALn7p2tDfsp5l0EM3Yn1lPz8CBKWjTpsvG8CH9QXVVCpqpCbVtWSFypWV0C6WKGi2p8DYqZDWr5RUWeYXiynHbiFZEX+83xzjHaycn50xa5WqQcc7DXOJpZqqt8ikRd6CmZ8T0eiii+LWsebBrR064SUJR35EYv2I0e4yNBUpc7RjuUkJY94cH5kajhMDJbPdqeTRAEJbWFttGqhAM7Tp2ZpBswe9KK4zSnDUIVeCKNJqeYBJQwxeMFwbAd+tnVEh3e/seKKCOD+QgsZ0YrOzFP/Q0RF74uV8/Ps9oRRnoDu4xxPctBrq/paQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=2vtSUANBn5bNleSgmkYjLB8eOtq0KzrCK+Zol2UqbnA=;
 b=TVrh+AGcKCPzpYFcb7692zO2vp/m3gnprFFLQ3OdmnP2JzhdJo6B6gYDTSL+ncmy27WhBZskZWO9dZxJOMb4K3j9AGdEpvNN3VffG4575RPQOjX9kw47CCD3yR5AP8EkloDArUxubYhS0t17lYZyy0rWE/HBPGSMQplQw5uGvTs9zPFEC93o/ahBGEgKt+ndB1SdCSO183md/MdvkjlQUeardH+obu9Sag2qtoOM2RtPPR1XtOhDcWRxV+O+HCuknX279SMX4nbExipp81uCd4HG4M/0oYBqiP94gyMv25cxrUpZ62eQfxy5lxi1tlEmAwxTMDSBiuPEteycEpjuNA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=2vtSUANBn5bNleSgmkYjLB8eOtq0KzrCK+Zol2UqbnA=;
 b=hOvxUAnT6RX5FzLmPbEWxYhcOpcrmmRU2eMFD+Xy5xA1VqcyLYQj39o2JtNrtMoOHC7gf8Vw34WHGBZiaZhGEwx6sxP2ELk8uaKBmxOJpc442fNAK1oyXjyaot0ji9Babc3gSN5E79hMfa+7KJHIMRBqiH8MNvyho9BAn4fKk8c=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Juergen Gross <jgross@suse.com>, Xen-devel
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2 04/70] x86/pv-shim: Don't modify the hypercall table
Thread-Topic: [PATCH v2 04/70] x86/pv-shim: Don't modify the hypercall table
Thread-Index: AQHYIaGhGuRO8pqNlkK4xub7I1FLsayTC50AgAAE4YCAAAF7gIADsLoA
Date: Wed, 16 Feb 2022 22:17:28 +0000
Message-ID: <f0889e93-aec0-443e-b3fc-081892edaf2b@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
 <20220214125127.17985-5-andrew.cooper3@citrix.com>
 <4d8ab414-caf4-5a12-4cb7-a88c633cfd66@suse.com>
 <e18c0c5a-d00b-adf9-d4b0-28e702a18241@srcf.net>
 <6566bf52-58da-f804-f5c2-fca64c1f150c@suse.com>
In-Reply-To: <6566bf52-58da-f804-f5c2-fca64c1f150c@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: aa2a9983-371c-4f32-69b4-08d9f19a1e91
x-ms-traffictypediagnostic: SJ0PR03MB5760:EE_
x-microsoft-antispam-prvs: <SJ0PR03MB5760B3BA5E1FFB9CFFBDFD99BA359@SJ0PR03MB5760.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8882;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: HA+OgdWlgib2YZtRxW4qAqq9wh/Z6H5ihnDckMcHn7UL5eKOe0vQx/yGrzJHDdZbwBsZ/OYIA6dGKE7OFX5QvQZWo83htJhA8W4Sp4DiXewomnPrUg+rz6oqE4RSlbL9PfzIV6OuzoMoVOZBjNtxrgRFS5q7Mvx15P9bR3NpL3yDWXd875RmLrBzc0uSsOc2IROj2Z39NUGTcRfmf4/BaVu0UxmwKxrCOT8xjeNJBUO0G1yzJmN5wyoZCNtL233qmDMuklMBxneDga3C5HOO/++er0/rYKtFceWvpnpiKL2fi/U8DrM9+GEGAeRkbq4MtGZ/T9mHSjSoxtzxjmUhgbiZ2Jt89HTu2l1Jdb5+y8Q4DNRSRR3VYLjW9+lDzZ1zGeIwKjA4KmIcmBzW363blcE2JfvLouBlo75HxAxBfJxTheeSGkikE340En3eOA7m5694i2CAKJ2A5c7ZMdbXWDsdcrp5RKH2MTilSgk/X31jdmfKAKlSAjB9ejz8X2DhbtOWA2WUdmZJpFr69qE8imyrX/Vpo2ZxPurpVC5xsAgRuX599guhOzl1+6hytgD7RS8Zo1uVNbAPpoYFHSvnNYvEXHGY1Ft6YFY0GmSRxfOivwamkzHbEfFoO3OP1fX+L4f6+Qgy1dKXuYZsMmq8qF6/3msKIL7hgxJjo10hJkBIVqkEsccV0BuTaUkkTg/DhVK8Z7TNWL5Vk3w50409V3r1idKyBF9EJUqheGhb7jJcqOarFH+jgWe4jy4mjVOo+OuJQUzFhRgmg3AeKbRzZg==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(86362001)(8676002)(38070700005)(31696002)(26005)(31686004)(71200400001)(54906003)(4326008)(2616005)(8936002)(186003)(36756003)(6506007)(6916009)(66476007)(66446008)(82960400001)(76116006)(64756008)(83380400001)(316002)(91956017)(53546011)(66556008)(6512007)(6486002)(2906002)(38100700002)(66574015)(508600001)(122000001)(5660300002)(66946007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?TXRLS3k2c0RPczRhYmpNc2hRVkJYK3lxT0l0S1J4OUZyZUVwRzl2MDc3SmYx?=
 =?utf-8?B?Y00vcmUwZ3ErYWczeWdoWVZvWW9pM1RRdXFERDd6OXlmWEEwK1RXVlMrNG01?=
 =?utf-8?B?Ymt3N015V1hxS0NKT0Zubi9LWitSRTZrT0hKRGEvOS9xdW8wMmxmMEw3cVpI?=
 =?utf-8?B?Qnh5WGVTdEJRY2lOb2Q4WURCVmpIUXRkckV2TWpCckREZ2pHVU0xWkl0K2pW?=
 =?utf-8?B?M2tRUXQvVzJiTTVHRG9OUGpKNCtIZG9TVnVtS3diK0F0RURpUFRrVlRyeERH?=
 =?utf-8?B?U2hBYlk2U0JsTlFHWm1GVi9MWXNvOEdwWDcvWXZia2dtNHYxcENiN2VhSWN3?=
 =?utf-8?B?MGRGZDNJYzFXTmFhbmNRckV6dklUNXJqWENuaGpMcmdRZ2FCamcvbXJDUEVj?=
 =?utf-8?B?YmZ5WEpQL1VLZFVPeW9oTFRsc3BhUm1TcERydkg4T3NKYVNSL3RldE1BZ3hY?=
 =?utf-8?B?WEIrUyttb1l3MTRoM293YXdURFpCNHpCY3FhbERiTXI5VFFPcXBEOUxhL0l1?=
 =?utf-8?B?VEpDOFZJOXdXT2p2cEtvamxnU2VTQXFHQ1oyS2YwSUQ5NTBYN3dtRmh1QndZ?=
 =?utf-8?B?MmZRL2xjU2FqL0Q2MG1nWTBNdVR3em1MdjZsN2NXWW4wWE5YVnB6R2FnOWpl?=
 =?utf-8?B?M1o3UGZoY2RKUGJIK3FXWTNJQ2lNNWp0WWtkbFY1Q3ZJWTJzRFVuNGZiRXBT?=
 =?utf-8?B?dlhzc0QvaDZWRzdCUjFnSm4wMXY3cHVXWnpaNS9GMTNOR3EvUU0yZDdZbkV5?=
 =?utf-8?B?ck5Yczk0cU52bEtoalFWcTVKSk5pWU02WE55RHZtclRoZmZVUVdQVnNQcHJa?=
 =?utf-8?B?ZGhyQ2FBRXdPSXJzSlZNSVAvNHBvZ2dBb0Erb01SaGZnTlB5UXU5eDdQTE1F?=
 =?utf-8?B?RDVacGFxRTVsdmVWK3d0UWYrZEFndXhKTUZwcmVYOWdQZGw5MlliaktITnkr?=
 =?utf-8?B?VS9qcm43T2xrMG5mbkFqUDhkSXJlc0dtUmFTQlMwMExaY2xOTzJ2VGZhMDh5?=
 =?utf-8?B?cm5NN2JsSlVXdTdNTSthaGZnVWVMei9zSTQwQ1R6dThIS25PZ0xuaW5XRjRv?=
 =?utf-8?B?L3oydFRQUkZZenBFU2FpbHo5MytkV3ZBWkl3THBVMEZhRU9PY3ZHOFpSK3ln?=
 =?utf-8?B?V0xTQUQ3aks4dS9NNTM3YU1vYWVEb2NPRUlvTkViZ2ZqZ2VJUDZMOU5zblFF?=
 =?utf-8?B?bHpab05IeEFWZHN2QXJ1WEErd0J6Ym1xQkhHaEpyQklZRjBpUlRpZ1dIb2lY?=
 =?utf-8?B?V2t2Y0hwLy9zOHBzOFdwcHpTNmZlb2c5aUd5Q1lUWElZM1RUZFJScVhtUDcy?=
 =?utf-8?B?Q1lYa3FCazVEdEdTbHZvWWN6R0FscmlqT1BGYU9kTXcvMTNDOTB1TENzSVRG?=
 =?utf-8?B?NGMxa2RaT3daZUphd3RWeHJobm8zcGhDaTMzczhLS3NxdTUzNFBGZFRnWFV0?=
 =?utf-8?B?Vmdpa3Awa1RXZGdnNnd4M3hVcG1NOE1PNUlabGZkK1lubjhkb2xSRExVd2VU?=
 =?utf-8?B?TTl6OTNNM1JPUDJNL3N2c2ovRFB5VFpaUWszMThEN2E4eDZ3RThHUDJkVHBT?=
 =?utf-8?B?Ylo5Q0tTckw2QkIzRW1VOVFSejc0QWM0UDRFTGZUcXBodW1uQjMvOWRkbThw?=
 =?utf-8?B?OU90Wk1NOEYyTzFiT3AxSzAvOFBIaFRjRG80dE5xVUFjTS9VblplZmdTRkw3?=
 =?utf-8?B?N2FsSS95U1NUVWtvSC81c2JTVS8yeWkyelhyckdORFVReWpSYktzdGhhMlVm?=
 =?utf-8?B?NFV1TDhmS2hPWDgvYWdwMzNUTWNLamNnM2R0Sm4yMHEwVE41THgyWTBtYTRQ?=
 =?utf-8?B?UURGeVdpbUJnVmVkcFpHNDNqdUVoS05ESjROOGRMTmZmZ0FyS2RnM2ZiRXVt?=
 =?utf-8?B?TGtvM05FRGN0VTVPQWc4ajMwKzBNK01kcXQ0TFRzMHZydklPSmo1cTNwazF2?=
 =?utf-8?B?ZUJNcjN3WndzUmxyR3M4R28xZmM5aHJWZ1NOUWozbGdoaytTa2ZxcWNjVWo2?=
 =?utf-8?B?aEJzNVBjajZQZ3M5MzYvMGQ1VERKeWFXWm96NGRjZy9Iam5YRjNTb2VTWWdM?=
 =?utf-8?B?R0oveFM3USt5TmFSek5hbXhlQ2NRVk5uSjAyd20rUDhjcjQ1N2EwbDhPTWll?=
 =?utf-8?B?UlpIZjVuN3JKRmtvOFM0eHFPcC9jQ1A1c3BmbjlYWGJrU3FWQUx0T2NOY3JW?=
 =?utf-8?B?V05CU3ZXWXhNSWhVUlQxajJhWmZWakkzTHpWMGV6Sk1HK3R0SkVmTXZaaVQz?=
 =?utf-8?B?RlVmNmQ4ekk0WjNFSkJ0eEQ2b2NnPT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <4E26D738C3098F4DB4C538D94F342E2C@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: aa2a9983-371c-4f32-69b4-08d9f19a1e91
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Feb 2022 22:17:28.9114
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 0wDTkGoaKnl/CsuQkZsm2S1ApUzDsIcBI1NkZeUz1i0+M1iaxP8IsreekC4XssO7J2x3XVNvBhh64miZNT9bnRim+W1smwCgwcLbpviIWuE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5760
X-OriginatorOrg: citrix.com

T24gMTQvMDIvMjAyMiAxMzo1NiwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDE0LjAyLjIwMjIg
MTQ6NTAsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBPbiAxNC8wMi8yMDIyIDEzOjMzLCBKYW4g
QmV1bGljaCB3cm90ZToNCj4+PiBPbiAxNC4wMi4yMDIyIDEzOjUwLCBBbmRyZXcgQ29vcGVyIHdy
b3RlOg0KPj4+PiBGcm9tOiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+DQo+Pj4+DQo+
Pj4+IFdoZW4gcnVubmluZyBhcyBwdi1zaGltIHRoZSBoeXBlcmNhbGwgaXMgbW9kaWZpZWQgdG9k
YXkgaW4gb3JkZXIgdG8NCj4+Pj4gcmVwbGFjZSB0aGUgZnVuY3Rpb25zIGZvciBfX0hZUEVSVklT
T1JfZXZlbnRfY2hhbm5lbF9vcCBhbmQNCj4+Pj4gX19IWVBFUlZJU09SX2dyYW50X3RhYmxlX29w
IGh5cGVyY2FsbHMuDQo+Pj4+DQo+Pj4+IENoYW5nZSB0aGlzIHRvIGNhbGwgdGhlIHJlbGF0ZWQg
ZnVuY3Rpb25zIGZyb20gdGhlIG5vcm1hbCBoYW5kbGVycw0KPj4+PiBpbnN0ZWFkIHdoZW4gcnVu
bmluZyBhcyBzaGltLiBUaGUgcGVyZm9ybWFuY2UgaW1wbGljYXRpb25zIGFyZSBub3QNCj4+Pj4g
cmVhbGx5IHJlbGV2YW50LCBhcyBhIG5vcm1hbCBwcm9kdWN0aW9uIGh5cGVydmlzb3Igd2lsbCBu
b3QgYmUNCj4+Pj4gY29uZmlndXJlZCB0byBzdXBwb3J0IHNoaW0gbW9kZSwgc28gdGhlIHJlbGF0
ZWQgY2FsbHMgd2lsbCBiZSBkcm9wcGVkDQo+Pj4+IGR1ZSB0byBvcHRpbWl6YXRpb24gb2YgdGhl
IGNvbXBpbGVyLg0KPj4+Pg0KPj4+PiBOb3RlIHRoYXQgZm9yIHRoZSBDT05GSUdfUFZfU0hJTV9F
WENMVVNJVkUgY2FzZSB0aGVyZSBpcyBhIGR1bW15DQo+Pj4+IHdyYXBwZXIgZG9fZ3JhbnRfdGFi
bGVfb3AoKSBuZWVkZWQsIGFzIGluIHRoaXMgY2FzZSBncmFudF90YWJsZS5jDQo+Pj4+IGlzbid0
IGJlaW5nIGJ1aWx0Lg0KPj4+Pg0KPj4+PiBTaWduZWQtb2ZmLWJ5OiBKdWVyZ2VuIEdyb3NzIDxq
Z3Jvc3NAc3VzZS5jb20+DQo+Pj4+IFNpZ25lZC1vZmYtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJl
dy5jb29wZXIzQGNpdHJpeC5jb20+DQo+Pj4gSSBkb24ndCB0aGluayB5b3Ugc3luYy1lZCB0aGlz
IHdpdGggSsO8cmdlbidzIHYzLiBUaGVyZSB3ZXJlIG9ubHkgbWlub3INCj4+PiBjaGFuZ2VzIGJ1
dCBoYXZpbmcgYSBzdGFsZSB2ZXJzaW9uIHNlbnQgdHdvIG1vbnRocyBsYXRlciBpc24ndCB2ZXJ5
DQo+Pj4gbmljZS4NCj4+IEkgZGlkIHJlc3luYy7CoCBXaGF0IGRvIHlvdSB0aGluayBpcyBtaXNz
aW5nPw0KPiBBIGZldyBsaWtlbHkoKSAvIHVubGlrZWx5KCkgYXMgZmFyIGFzIEkgY291bGQgc2Vl
Lg0KDQpPaCB0aG9zZSB0d28uwqAgSSBhcHBlYXIgdG8gaGF2ZSBmb3Jnb3QgdG8gZW1haWwuDQoN
ClRoZXkncmUgd3JvbmcgLSBvYnNlcnZlIHRoZXkncmUgaW4gYW4gaWZuZGVmIGJsb2NrLCBub3Qg
YW4gaWZkZWYgYmxvY2suwqANCk9ibGlnYXRvcnkgY2l0YXRpb24gb2YgdGhlIHJlY29tbWVuZGF0
aW9uIGZvciBodW1hbnMgbm90IHRvIHRyeSBhbm5vdGF0aW5nLg0KDQo+Pj4+IC0tLSBhL3hlbi9j
b21tb24vY29tcGF0L211bHRpY2FsbC5jDQo+Pj4+ICsrKyBiL3hlbi9jb21tb24vY29tcGF0L211
bHRpY2FsbC5jDQo+Pj4+IEBAIC01LDcgKzUsNyBAQA0KPj4+PiAgRU1JVF9GSUxFOw0KPj4+PiAg
DQo+Pj4+ICAjaW5jbHVkZSA8eGVuL3R5cGVzLmg+DQo+Pj4+IC0jaW5jbHVkZSA8eGVuL211bHRp
Y2FsbC5oPg0KPj4+PiArI2luY2x1ZGUgPHhlbi9oeXBlcmNhbGwuaD4NCj4+Pj4gICNpbmNsdWRl
IDx4ZW4vdHJhY2UuaD4NCj4+Pj4gIA0KPj4+PiAgI2RlZmluZSBDT01QQVQNCj4+Pj4gQEAgLTE5
LDcgKzE5LDYgQEAgc3RhdGljIGlubGluZSB2b2lkIHhsYXRfbXVsdGljYWxsX2VudHJ5KHN0cnVj
dCBtY19zdGF0ZSAqbWNzKQ0KPj4+PiAgICAgICAgICBtY3MtPmNvbXBhdF9jYWxsLmFyZ3NbaV0g
PSBtY3MtPmNhbGwuYXJnc1tpXTsNCj4+Pj4gIH0NCj4+Pj4gIA0KPj4+PiAtREVGSU5FX1hFTl9H
VUVTVF9IQU5ETEUobXVsdGljYWxsX2VudHJ5X2NvbXBhdF90KTsNCj4+Pj4gICNkZWZpbmUgbXVs
dGljYWxsX2VudHJ5ICAgICAgY29tcGF0X211bHRpY2FsbF9lbnRyeQ0KPj4+PiAgI2RlZmluZSBt
dWx0aWNhbGxfZW50cnlfdCAgICBtdWx0aWNhbGxfZW50cnlfY29tcGF0X3QNCj4+Pj4gICNkZWZp
bmUgZG9fbXVsdGljYWxsX2NhbGwgICAgY29tcGF0X211bHRpY2FsbF9jYWxsDQo+Pj4gSsO8cmdl
bidzIHBhdGNoIGRvZXNuJ3QgaGF2ZSBhbnkgY2hhbmdlIHRvIHRoaXMgZmlsZSwgYW5kIEknbSBh
ZnJhaWQgSQ0KPj4+IGFsc28gZG9uJ3Qgc2VlIGhvdyB0aGVzZSBhZGp1c3RtZW50cyBhcmUgcmVs
YXRlZCBoZXJlLiBUaGUgY29tbWl0DQo+Pj4gbWVzc2FnZSBzYWRseSBhbHNvIGRvZXNuJ3QgaGVs
cCAuLi4NCj4+IFRoZSBjaGFuZ2VzIGFyZSB2ZXJ5IG5lY2Vzc2FyeSB0byBzcGxpdCBpdCBvdXQg
b2YgSnVlcmdlbidzIHNlcmllcy4NCj4+DQo+PiBXaXRob3V0IHRoZSBhZGp1c3RtZW50LCB0aGUg
Y29ycmVjdGlvbiBvZiBjb21wYXRfcGxhdGZvcm1fb3AoKSdzIGd1ZXN0DQo+PiBoYW5kbGUgdHlw
ZSBmcm9tIHZvaWQgdG8gY29tcGF0X3BsYXRmb3JtX29wX3QgZG9lc24ndCBjb21waWxlLg0KPiBJ
bnRlcmVzdGluZy4gVGhhdCdzIHF1aXRlIGZhciBmcm9tIG9idmlvdXMgaW4gdGhpcyBjb250ZXh0
LCBzbyBjbGFyaWZ5aW5nDQo+IHRoZSBwdXJwb3NlIGluIHRoZSBkZXNjcmlwdGlvbiB3b3VsZCBz
ZWVtIGhlbHBmdWwuDQo+DQo+IENvbWluZyBiYWNrIHRvIHRoZSBzeW5jaW5nIHdpdGggdjM6IFdh
cyB0aGlzIGNoYW5nZSB0aGUgcmVhc29uIHRoZW4gd2h5DQo+IHlvdSBkaWQgZHJvcCBteSBSLWI/
DQoNCk15IHBvcnRpbmcgb2YgdGhpcyBwYXRjaCBpcyBhIG5vbi10cml2aWFsIG1vZGlmaWNhdGlv
biBmcm9tIEp1ZXJnZW4ncw0KdmVyc2lvbiwgYW5kIG5vdCBlbGlnaWJsZSB0byByZXRhaW4gYW55
IHRhZ3MuDQoNCkkgdGhvdWdodCBJJ2QgZGlzY3Vzc2VkIHRoaXMsIGJ1dCBJIGFwcGVhciB0byBo
YXZlIG1pc3NlZCBpdCBmcm9tIGJvdGgNCnZlcnNpb25zIG9mIHRoZSBzZXJpZXMuwqAgU29ycnku
DQoNCkVpdGhlciB3YXkuwqAgSXQncyBleGFjdGx5IHRoZSBzYW1lIHB1cnBvc2UgYXMgYmVmb3Jl
LCBidXQgbW9kaWZpZWQgdG8NCmNvbXBpbGUgaW4gaXNvbGF0aW9uLg0KDQpKdWVyZ2VuJ3Mgc2Vj
b25kIHBhdGNoLCBzdWJzZXF1ZW50IHRvIHRoaXMgb25lLCBpcyB1bm1vZGlmaWVkIHdoaWNoIGlz
DQp3aHkgSSByZXRhaW5lZCB5b3VyIFItYnkgdGhlcmUuDQoNCn5BbmRyZXcNCg==


From xen-devel-bounces@lists.xenproject.org Thu Feb 17 00:13:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 17 Feb 2022 00:13:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274449.469913 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKUPu-0007BZ-4B; Thu, 17 Feb 2022 00:13:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274449.469913; Thu, 17 Feb 2022 00:13:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKUPu-0007BS-0m; Thu, 17 Feb 2022 00:13:02 +0000
Received: by outflank-mailman (input) for mailman id 274449;
 Thu, 17 Feb 2022 00:13:00 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nKUPs-0007BI-Gm; Thu, 17 Feb 2022 00:13:00 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nKUPs-0004iq-Cp; Thu, 17 Feb 2022 00:13:00 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nKUPr-0005Z0-W9; Thu, 17 Feb 2022 00:13:00 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nKUPr-0006Fh-Ub; Thu, 17 Feb 2022 00:12:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=jtWo5HpCDdBHVr2wuR0Nzz2dQKbQi121y3h5pVIiOP0=; b=pvvdt22ZAt3osDLc+J8P8BUu4R
	0yAZykHC66i3hh1P46RU4lqo0l0ViUoBL0ObRkqnGGig5n7lJBrEogs0eIULAsM3F9bdV9ruPCxgA
	BUpuijXY2VdadWvMCVPvQQIvmONyVMcn+rJdlXFuxdIJPzAxUGc+Meapb06CyJ+RDkFk=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168130-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-5.4 test] 168130: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=7b3eb66d0daf61e91cccdb2fe5d271ae5adc5a76
X-Osstest-Versions-That:
    linux=52871671099d1bb3fca5ed076029e4b937bfc053
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 17 Feb 2022 00:12:59 +0000

flight 168130 linux-5.4 real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168130/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168112
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168112
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168112
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168112
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168112
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168112
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168112
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168112
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168112
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168112
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168112
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168112
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                7b3eb66d0daf61e91cccdb2fe5d271ae5adc5a76
baseline version:
 linux                52871671099d1bb3fca5ed076029e4b937bfc053

Last test of basis   168112  2022-02-14 18:12:51 Z    2 days
Testing same since   168130  2022-02-16 12:13:29 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Adam Ford <aford173@gmail.com>
  Adrian Hunter <adrian.hunter@intel.com>
  Alexandre Ghiti <alexandre.ghiti@canonical.com>
  Alexei Starovoitov <ast@kernel.org>
  Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
  Amelie Delaunay <amelie.delaunay@foss.st.com>
  Andrew Jeffery <andrew@aj.id.au>
  Anna Schumaker <Anna.Schumaker@Netapp.com>
  Antoine Tenart <atenart@kernel.org>
  Armin Wolf <W_Armin@gmx.de>
  Arnaldo Carvalho de Melo <acme@redhat.com>
  Aurelien Jarno <aurelien@aurel32.net>
  Brian Johannesmeyer <bjohannesmeyer@gmail.com>
  Cameron Williams <cang1@live.co.uk>
  Catalin Marinas <catalin.marinas@arm.com>
  Christian Brauner <brauner@kernel.org>
  Christian König <christian.koenig@amd.com>
  Christoph Hellwig <hch@lst.de>
  Chuck Lever <chuck.lever@oracle.com>
  Daniel Borkmann <daniel@iogearbox.net>
  Daniel Vetter <daniel.vetter@ffwll.ch>
  David S. Miller <davem@davemloft.net>
  Dinh Nguyen <dinguyen@kernel.org>
  Eric Dumazet <edumazet@google.com>
  Fabio Estevam <festevam@gmail.com>
  Florian Fainelli <f.fainelli@gmail.com>
  Frank van der Linden <fllinden@amazon.com>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Guenter Roeck <linux@roeck-us.net>
  Hulk Robot <hulkrobot@huawei.com>
  Jakob Koschel <jakobkoschel@gmail.com>
  Jakub Kicinski <kuba@kernel.org>
  James Smart <jsmart2021@gmail.com>
  Jann Horn <jannh@google.com>
  Jay Vosburgh <jay.vosburgh@canonical.com>
  Jens Axboe <axboe@kernel.dk>
  Jernej Skrabec <jernej.skrabec@gmail.com>
  Jiasheng Jiang <jiasheng@iscas.ac.cn>
  Jisheng Zhang <jszhang@kernel.org>
  Joel Stanley <joel@jms.id.au>
  Johan Hovold <johan@kernel.org>
  Jon Hunter <jonathanh@nvidia.com>
  Jon Maloy <jmaloy@redhat.com>
  Jonas Malaco <jonas@protocubo.io>
  Kees Cook <keescook@chromium.org>
  Keith Busch <kbusch@kernel.org>
  Konrad Jankowski <konrad0.jankowski@intel.com>
  Kosuke Tatsukawa <tatsu-ab1@nec.com>
  Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
  Linux Kernel Functional Testing <lkft@linaro.org>
  Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
  Louis Peens <louis.peens@corigine.com>
  Mahesh Bandewar <maheshb@google.com>
  Martin Blumenstingl <martin.blumenstingl@googlemail.com>
  Martin K. Petersen <martin.petersen@oracle.com>
  Masami Hiramatsu <mhiramat@kernel.org>
  Mathias Krause <minipli@grsecurity.net>
  Mimi Zohar <zohar@linux.ibm.com>
  Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>
  Neil Armstrong <narmstrong@baylibre.com>
  Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
  Nilesh Javali <njavali@marvell.com>
  Olga Kornievskaia <kolga@netapp.com>
  Palmer Dabbelt <palmer@rivosinc.com>
  Paolo Abeni <pabeni@redhat.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Pavel Hofman <pavel.hofman@ivitera.com>
  Pavel Parkhomenko <Pavel.Parkhomenko@baikalelectronics.ru>
  Pawel Dembicki <paweldembicki@gmail.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Prabhath Sajeepa <psajeepa@purestorage.com>
  Pratham Pratap <quic_ppratap@quicinc.com>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Raju Rangoju <Raju.Rangoju@amd.com>
  Raymond Jay Golo <rjgolo@gmail.com>
  Roberto Sassu <roberto.sassu@huawei.com>
  Robin Murphy <robin.murphy@arm.com>
  Sagi Grimberg <sagi@grimberg.me>
  Samuel Mendoza-Jonas <samjonas@amazon.com>
  Sasha Levin <sashal@kernel.org>
  Saurav Kashyap <skashyap@marvell.com>
  Sean Anderson <sean.anderson@seco.com>
  Shawn Guo <shawnguo@kernel.org>
  Shuah Khan <skhan@linuxfoundation.org>
  Simon Horman <simon.horman@corigine.com>
  Slade Watkins <slade@sladewatkins.com>
  Song Liu <song@kernel.org>
  Stefan Berger <stefanb@linux.ibm.com>
  Stephan Brunner <s.brunner@stephan-brunner.net>
  Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
  Sudip Mukherjee <sudipm.mukherjee@gmail.com>
  Szymon Heidrich <szymon.heidrich@gmail.com>
  TATSUKAWA KOSUKE (立川 江介) <tatsu-ab1@nec.com>
  Tong Zhang <ztong0001@gmail.com>
  Tony Nguyen <anthony.l.nguyen@intel.com>
  Trond Myklebust <trond.myklebust@hammerspace.com>
  Udipto Goswami <quic_ugoswami@quicinc.com>
  Ulf Hansson <ulf.hansson@linaro.org>
  Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
  Victor Nogueira <victor@mojatatu.com>
  Vitaly Kuznetsov <vkuznets@redhat.com>
  Vlad Buslov <vladbu@nvidia.com>
  Xiaoke Wang <xkernel.wang@foxmail.com>
  Zechuan Chen <chenzechuan1@huawei.com>
  ZouMingzhe <mingzhe.zou@easystack.cn>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   52871671099d..7b3eb66d0daf  7b3eb66d0daf61e91cccdb2fe5d271ae5adc5a76 -> tested/linux-5.4


From xen-devel-bounces@lists.xenproject.org Thu Feb 17 06:22:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 17 Feb 2022 06:22:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274464.469924 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKaAx-0001PP-1N; Thu, 17 Feb 2022 06:21:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274464.469924; Thu, 17 Feb 2022 06:21:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKaAw-0001PH-S6; Thu, 17 Feb 2022 06:21:58 +0000
Received: by outflank-mailman (input) for mailman id 274464;
 Thu, 17 Feb 2022 06:21:57 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nKaAv-0001P7-Aw; Thu, 17 Feb 2022 06:21:57 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nKaAv-0005Ix-54; Thu, 17 Feb 2022 06:21:57 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nKaAu-0008Ko-SW; Thu, 17 Feb 2022 06:21:56 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nKaAu-0000oY-QN; Thu, 17 Feb 2022 06:21:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=OsBP7ERcFXLO0rhI2w0JhKmBko1hcjjA9J2bvmJAISM=; b=o8OhyzNPOPntx0TlCHpSnEyeFK
	zfybB1DfS8QyYqbrpuxjkd0cnPa8+Rj8RwsMdlOn1jNc2VnUQ1XVolOm0zNSRukqEBOIzeCZck3R9
	esDzqzsFa2Kon12PaAD2TyQQSGxt6KRy8vHJHuagCn6AbOf5juz1WpUMZa8gcb8Eee7A=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168136-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.16-testing test] 168136: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-4.16-testing:test-amd64-amd64-xl-xsm:guest-start/debian.repeat:fail:heisenbug
    xen-4.16-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=0941d6cb2383c4e87d7f53f1df74e8850e1649bc
X-Osstest-Versions-That:
    xen=2d8eade97343e99c26b004a05868532613007c8d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 17 Feb 2022 06:21:56 +0000

flight 168136 xen-4.16-testing real [real]
flight 168147 xen-4.16-testing real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/168136/
http://logs.test-lab.xenproject.org/osstest/logs/168147/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-xsm 22 guest-start/debian.repeat fail pass in 168147-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168063
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168063
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168063
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168063
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168063
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168063
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168063
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168063
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168063
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168063
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168063
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168063
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  0941d6cb2383c4e87d7f53f1df74e8850e1649bc
baseline version:
 xen                  2d8eade97343e99c26b004a05868532613007c8d

Last test of basis   168063  2022-02-08 18:37:45 Z    8 days
Testing same since   168136  2022-02-16 15:11:54 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Anthony PERARD <anthony.perard@citrix.com>
  Dario Faggioli <dfaggioli@suse.com>
  James Dingwall <james-xen@dingwall.me.uk>
  James Fehlig <jfehlig@suse.com>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      fail    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   2d8eade973..0941d6cb23  0941d6cb2383c4e87d7f53f1df74e8850e1649bc -> stable-4.16


From xen-devel-bounces@lists.xenproject.org Thu Feb 17 08:29:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 17 Feb 2022 08:29:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274491.469958 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKcA1-00054j-Ek; Thu, 17 Feb 2022 08:29:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274491.469958; Thu, 17 Feb 2022 08:29:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKcA1-00054c-Bd; Thu, 17 Feb 2022 08:29:09 +0000
Received: by outflank-mailman (input) for mailman id 274491;
 Thu, 17 Feb 2022 08:29:08 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=A/h9=TA=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nKcA0-00054U-Gt
 for xen-devel@lists.xenproject.org; Thu, 17 Feb 2022 08:29:08 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id aaae141d-8fcb-11ec-8eb8-a37418f5ba1a;
 Thu, 17 Feb 2022 09:29:06 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: aaae141d-8fcb-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645086546;
  h=from:to:cc:subject:date:message-id:
   content-transfer-encoding:mime-version;
  bh=3wEtOBKwmOfozVUjF0JPZjCv/ozkDpH90hBgaJa3VwA=;
  b=QFg0Syd+mM0Sdi7bqnlO4uu4tIg/YAmtFC2uzLZNhThQLmWhbamrnln6
   1j5A51RsC/OdRFw4rwU09+YLU9cKMf8suJVCDWaM3DvvbpkU/dWtoFCPL
   9ZB+YvIRJAKXH9+xSynI3jC1dYLF3LFVoQwTME5UYA/jPnH0N5hsfPJQl
   4=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: kRvO8hK4rZi+6g7zv2Ldz3cL3nG+xIo1TFjFtknMf0leHAYxDsfZmGMkDgDIGHq+nnZuLOTeon
 bF/BOM2n8P8rOzT3ofKM06VjfS1zFypqivd3m/YyE+iVpFmNCBkfeyWuHdZNCtg0ZCgKbLysxZ
 VilB78YNE/GLm8SakR5mopxZ/Ktyd+87AQLLYtqyFvhk7GMUCrJy22fEBOLBQogXzk8GY8snTw
 L3i9dEfVk3+PhG9qbbRLCbL1EM9lSzsrtGJUJ5wF/ymYQi/FupnPuG9WKifP7OMtYSH/dPkiia
 2/Hs7KsiuT/f+qhwwu00PsE1
X-SBRS: 5.1
X-MesageID: 66651923
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:+SZlmK7UyO9zYa5Uk6TtNQxRtLzAchMFZxGqfqrLsTDasY5as4F+v
 mJMCDqDOarYZ2qgKtFzaNi/8xkBupCEz4M2Gwo4+Cg3Hi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FV8MpBsJ00o5wbZj29Ew2LBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zx
 fEc5KDtVjYQHIL0hfkaUjhXNRhHIvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALNs7kMZlZonh95TrYEewnUdbIRKCiCdpwgmlu25kfR622i
 8wxeDhyYkjSXj9zJWwFKpMkgfWjp1/iWmgNwL6SjfVuuDWCpOBr65D2K8bccNGOQcRTn26bq
 3jA8mC/BQsVXPSAzRKV/3TqgfXA9Qv5RYYTGbuQ5vNsxlqJyQQ7GBAQEFe2v/S9okq/QM5Eb
 VwZ/DI0qqo//1DtScPyNzW6qnOZuh8XW/JLDvY3rgqKz8LpDx2xXzZeCGQbMZp/6ZFwFWdCO
 kK1c83BCBg+4YHIVkOk1JissC61OAkaC1Y7enpRJeca2OXLrIY2hxPJa99sFq+pk9H4cQ3NL
 yC2QDsW3OtK05NSv0mv1RWe2m/3+MCVJuIgzliPBgqYAhVFiJlJjmBCwXzS9r5+IYmQVTFtV
 1BUypHFvIji4Xxg/RFhodnh/pn1tp5p0xWG2DaD+qXNERz3pBZPmqgKvVlDyL9BaJpsRNMQS
 Ba7VfltzJFSJmC2SqR8fpi8Dc8npYC5S4i4DquLMIYTOccsHONiwM2ITRTPt4wKuBJx+ZzTx
 L/BKZr8ZZrkIf8PIMWKqxc1juZwm3FWKZL7TpHn1RW3uYdyl1bOIYrpxGCmN7hjhIvd+V292
 48Ga6OilkUOOMWjM3K/2dNCcjg3wY0TWMmeRzp/LbXYfGKL2QgJVpfs/F/WU9c0xfsLyLaTr
 yrVt40x4AOXuEAr4D6iMxhLQLjuQYx+vTQ8OyktNkyvwH8tfcCk66J3Snf9VeBPGDVLwaEmQ
 v8bVd+HB/gTGD3L9y5ENcv2rZB4dQTtjgWLZnL3bD86dp9mZgrI5t67IVe/qHhQVnK65Zkkv
 rmt9gLHWp5fFQ5sO9nbNaC0xFSrsHlDxO8rBxnUIsNecVnH+ZRxL3Cjlec+JswBcE2RxjaT2
 wuMLw0foO3B/908/NXT3PjWpIa1CepuWEFdGjCDv7qxMCDb+EulwJNBD7nULWyMCjus9fz7N
 +tPzvz6PPkWp3pwstJxQ+Rx0KYzx9rzvLsGnA5qK2rGMgawAbR6L3jYgcQW7v9RxqVUsBedU
 16U/oUIIq2APc7oHQJDJAchaejfh/gYliOLsKYwKUT+oiR24KCGQQNZOBzV0H5RK758MYUEx
 +Y9uZFJt1zj20RyatvW3DpJ82msL2AbV/R1v54XN4bnlw43xwwQepfbECL3vMmCZtgk3pPG+
 dNIaH4uX4hh+3c=
IronPort-HdrOrdr: A9a23:hhT56a4sg3T3K7Ux0wPXwAHXdLJyesId70hD6qkoc20vTiSZ//
 re/8jzpiWE8gr5OUtQ6OxoV5PwJk80maQV3WBVB8bbYODqggCVxeJZnPvfKl/bakvDH4dmvM
 8NHMZD4Z/LfCFHZK3BkWuF+qMbsb26GdeT9ILjJhlWLT2CbZsL0+6aMGum+wZNNXR77NICZe
 ahDtwunUveRZ04VLXEOkU4
X-IronPort-AV: E=Sophos;i="5.88,375,1635220800"; 
   d="scan'208";a="66651923"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=hg46y3+IoV2Fk8yNMRHFuCL9m5Iy8oMnVmgD6yPsS5ZVMScHyMFhqSmuAbjB5wV96z4T8Cnfmme8JCxEXowYoBGJxg62dd9/PwNzk4RtBwcXzDQM/d8F3p0b6X7jgSUR5neGcDAMCrSgsn+YVmBJ043hnFtFw9yzlW7u0YCCkiypYYcri1kj+Kw/AVVTTotYK93H8drCNslebH9hemFNUQpxsDahdxFY0IRc5pj4KnhSZneeSBn5l09s1OdxeOIZY5lHh8QUJrZnGzChVdGF8S3QTGVfc77H/S5KGE3+3or2G96EHMzmBro8ChZZZUm7eDJoPeOdvFtz+tTEmL/OAQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=6YwBQuVDpFFptRjvFrPgL/9F6Jj/+r12HgrhapdGMXU=;
 b=e7MMxR0ubb6Dplrdi4XMCKIWSt0MljvBykuWEM12y5MkC4QY6Z33vpQYuNAEQsi1/YProvJ8oNY46QgcEWyU/0zHE7zARJFIhQiuWMBlGJWUpHGiJ0eOuON1yvJfOxc+io2UBrgVYCIFdtwddltP28vDdpovbOYmDIMcPR0OY79Pee3j5f5ng+Tqc3Eumo/IOUh1tj0kgf5IHIAx8ADxKGOfeIjHI8PihAmlo4WS3eKlNqlSMFeQHetiqlAXMgYNeiuarhcOPLunpQUGRcr4ZJVM0auhnvUAeFAueiRrNkILo7QrImzKpowe2UfxxaJQdbvcZpjwlJARMWED7WnShQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=6YwBQuVDpFFptRjvFrPgL/9F6Jj/+r12HgrhapdGMXU=;
 b=T+9zZZmSEsG6libs9M0xGuH3k+XRPrpTawCcuy6620d7pIStUSAMa2Uig3rS0YTPbi/qfSyxIztEzOstcrD//vARgDGDOuoabFGjc+PsMoboBa/V4t1eE0Umtc57orlwrwe4EW1eNdPlhTZR1wDMSkENaJ5hm9ctjoRjjdOAkQs=
From: Roger Pau Monne <roger.pau@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Roger Pau Monne <roger.pau@citrix.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, Jan
 Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>, Stefano
 Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Subject: [PATCH] x86/console: process softirqs between warning prints
Date: Thu, 17 Feb 2022 09:28:50 +0100
Message-ID: <20220217082850.19407-1-roger.pau@citrix.com>
X-Mailer: git-send-email 2.34.1
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: PR3P191CA0029.EURP191.PROD.OUTLOOK.COM
 (2603:10a6:102:54::34) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 05242b17-9990-439b-e1f9-08d9f1ef8b5d
X-MS-TrafficTypeDiagnostic: MN2PR03MB4768:EE_
X-Microsoft-Antispam-PRVS: <MN2PR03MB4768C803F21D459E43D372498F369@MN2PR03MB4768.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:107;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: ++tTkbKeDYe3jBhw0WUrRQ+u3L6gPYJ/QJXQjfE1bPJOwXBi+T2q0JM8PAExKVaCtRJy79r1089QGTqtUFAR38Riv5/hf24Ns5zJXdBb1ofmMHcd3BY45oBlHdBaqRMMTLIaAaBzbxg9i56VVZxNNxxvMGMMoyvp7yTWL/GRIZCAiRqqo7mCMbd4uXm5afSKvPED/ogW35JPG46aEP5pFCtbyOQ7p169qGj1o7crhNS8MCoMDL6986tvaK4Axk5JSKeM2UtsItLAgBbpjBKrdpdXCToNmLKQUZjtasaxtc5ZGYAzhkJRYZX8bb2jhykdlGtNYKNpDn0IgwpCYeyoi7fZTaChGjdIsQYwHEux/E+Q/thYpnrlzrvpH3/ZTsjuTpbO9R++hMqfHOgpZSoqm9+p8vsx5UXDP/yDNqb1ji48EaZCpCmmMeqAf4cMcaTOIUyoH93RAIkcDC07l45GzRtiJR0NDGVsXlZSYzCo0OQ6zsf91lSGrupOaCcbqmlp7luLGckgUftzopgzz0vEGpkvmAsyxfDZbDHpxov8ubi9FwpXiv475IdYpPTf5Hdin9cGm4lg1eMha5RPo0ayR622X0aE3z74CsRy/xvqh3Iwj5Ucjn77aCUQrdLN5jHTMKNF7KfIQ5F0swVeMnxTqg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6512007)(8676002)(4326008)(508600001)(6486002)(38100700002)(6506007)(66476007)(86362001)(66946007)(82960400001)(6666004)(66556008)(316002)(54906003)(6916009)(1076003)(2906002)(186003)(36756003)(26005)(8936002)(5660300002)(2616005)(83380400001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZFhqZjJqMTJoYW52eW9Mb3VWQWhLcVgrYWZaK1VkeG1GZFZpbDlYTDRlNHds?=
 =?utf-8?B?TEwxWWdCUUJ4cFdJUzBlS2VlUEFHdnVRd25TWm04aVpDdWpySjhRTFEybks3?=
 =?utf-8?B?TXNUdlhnQ2thVFZ6cGEwaDhmWDU3R28yT1lSenphb0ZNYy9LTktqR0srdnY3?=
 =?utf-8?B?VmVnK1pGa3FsbTVjOERjVEl0ZDNSMVhLcjRCNVJOZUExWk5TKzMzTXVjdnpv?=
 =?utf-8?B?R2RQc3cvc1Q4RThlVStoaWhPS1pmL0pZK3BLWXZSSDVFSkVFTkNBZ25ESkRw?=
 =?utf-8?B?Qy9COE5WODZtdE0rR21UcmxoQUs2TGFKRUZEMEVpdlBDd2h5d3cxZjVpeVZ1?=
 =?utf-8?B?QzJtM3hUOGVEejBhdUtiWmNpdWhhTk1GR3NMajlPVVcyV0FINXhtRjZqb3Jm?=
 =?utf-8?B?NXFqYmZ5OEVZelVLY3UvRlRaN0lLYzBCWVI1Y3BsQk8xdVJ6NjBhcVo0L0hF?=
 =?utf-8?B?b0JyRzZIdC9zYm9Ndm5QUWFSdXY3c0JGdkFtREhHVlI3UW1KbWl1U0UxR2Nu?=
 =?utf-8?B?dTBkbUhHd3JBeWNPNW56RGhMaG5ZQ1REK05NcUcrNEQrTWwybUJJbFp1cmRw?=
 =?utf-8?B?cVRKUHpFMzBGVWh2REJBd3VYTGYrUVV1T0h6R2xYejduRlI4cGRSb29rU1BX?=
 =?utf-8?B?d2RQOGFJSDBYTkVIYmlSMm9QUGtoQldPN0lzTmJ5YkVrdjA3SFJhcGdCaEtD?=
 =?utf-8?B?V3ZhSkZkZGV6UkhXTU4xODhGdzYzZDgvRkpXeklYT2x5YXZ2di93SDdqaTVr?=
 =?utf-8?B?ankrZUVicmllSnVjRjhVYUJ5SjhxclBtdnpVamI5MEp3RlRlZmt3b3N3V0ZG?=
 =?utf-8?B?RXpzTGpGQ3NzNmRUNEFyMnhnbjVaTzVFbFNMbEV0c3QrcFh1QkRXKzFqMVlp?=
 =?utf-8?B?aWdGN0NxRkRvSmpNSEZ0bG8zUlBaWXNsT1k1Qm5hUlVtODlxdmM1b1k0ckJh?=
 =?utf-8?B?OEhvRitOcTRQK0tnTG5wRG9ZSXhpbkdlbHhtMUxod1Fob3RhcHpjNGJzTUd0?=
 =?utf-8?B?bjBEbGIzbERkTmtSVWJRZTUySElFRGRpY2lMTjcvUER1dHl4MWJBOVo3RTVj?=
 =?utf-8?B?cW5Ua2NjMlYrRzBhQ0E1REZxUFlaNGhwbXlkZXhMQTRMZkh3OStaY1Z6SXls?=
 =?utf-8?B?aVRvaU4xaER2aDhVL0hndUg1VjhjdXRHYjRBZ2FoVW1tVkxxallsM3BIMkUr?=
 =?utf-8?B?ZTM5d1ZURzB4Yi9yemVwNXJhc2NpaWM1M3dOU3o2STJpTjBITmUvZzJqQ0U3?=
 =?utf-8?B?N1Z3L01vU3B3QS9pN1BrN0t6S1BaWEI2WVpaRGZFWk1DclcxT085UEVWK1NG?=
 =?utf-8?B?TEZZdWZmOFE0djFqNklHMnY1UHM3Njk5ejMxZW96QlZYNG5pdzAvTk1WdXNJ?=
 =?utf-8?B?NnVyTURaald6d00xcmNuTUlkWm9weXduMUZsZ0RQTUFmYjJOQ1hJeno3VHda?=
 =?utf-8?B?MHcrYlgvWHhweHVnOExraUorRGNFdGJndjlvSkU3NnZEWFFFRG5laXRMQlFC?=
 =?utf-8?B?TnBoMFhnMm56cU5MUjkwOEZhN3VKcHZEb1dkbFdqRXB0R2k4bFBERStLQU0r?=
 =?utf-8?B?UUwzRVJBaGF6c1UxckdzbjdLT3ppUjNROGlvRW5OR2tyaWEzeG44dXlOajJn?=
 =?utf-8?B?QllMcENwMDllcGFQRUU3cE1oRFQ0c2hTbUwza29aZ3FUMHV0UUtQM3J2bTZ5?=
 =?utf-8?B?THNuS25pajZXaGV5LzV2WnhxNHRabEhCUllXQVo3ZExMRG1wWjRWdTlQUnd3?=
 =?utf-8?B?UHJ5SFliaFhhaGdqZjZvRENjSVZ2clhhbW9SYXNnZjRkYjRzUVRReFpGVW44?=
 =?utf-8?B?dUxpUEdQaUhYS2dVRFpwL3JNczdrU2VUNEplQll4Zk1obkw3OFlvSXFTaWt0?=
 =?utf-8?B?NFp0dHVhWWtRNzBVNXZ0SkNzQ3IyeFowb0VBa0MrbmRJSHdJRVg1M2ZpMFVs?=
 =?utf-8?B?cWtYRjkrVkdCdnBIYm9sYUNVeGxWcmhKdFBmVjZaaUxUWms1NTl1R0oraExm?=
 =?utf-8?B?eHdBQlg3T0NoN1A3OERic3Z6bStxaGkrVEVkZER4UERpdU4zeGZVdzVKN21G?=
 =?utf-8?B?K3JmbkFjV0pWcGFyR0ZYVS9Ubk4xcjNhaXpoeFNYSXVkY0IwUDB3enl0cnZl?=
 =?utf-8?B?UTRKT2ZnaGtCaS8vUGNBdVlLVDZOTnZyN2lDQ2Faa1JtbFd2MUk2SE1NZEhW?=
 =?utf-8?Q?cXNYNlvsGwp5cVGqY8iZD5A=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 05242b17-9990-439b-e1f9-08d9f1ef8b5d
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2022 08:28:59.0268
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5sUCZq4Vv1AzaWFUiCHNfmMRjaKgc7TeLNNqtkXfkAUTEgc1tyNQsMu9dcHcHMnpBc9ekJeybKPYHr7bey05nA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB4768
X-OriginatorOrg: citrix.com

Process softirqs while printing end of boot warnings. Each warning can
be several lines long, and on slow consoles printing multiple ones
without processing softirqs can result in the watchdog triggering:

(XEN) [   22.277806] ***************************************************
(XEN) [   22.417802] WARNING: CONSOLE OUTPUT IS SYNCHRONOUS
(XEN) [   22.556029] This option is intended to aid debugging of Xen by ensuring
(XEN) [   22.696802] that all output is synchronously delivered on the serial line.
(XEN) [   22.838024] However it can introduce SIGNIFICANT latencies and affect
(XEN) [   22.978710] timekeeping. It is NOT recommended for production use!
(XEN) [   23.119066] ***************************************************
(XEN) [   23.258865] Booted on L1TF-vulnerable hardware with SMT/Hyperthreading
(XEN) [   23.399560] enabled.  Please assess your configuration and choose an
(XEN) [   23.539925] explicit 'smt=<bool>' setting.  See XSA-273.
(XEN) [   23.678860] ***************************************************
(XEN) [   23.818492] Booted on MLPDS/MFBDS-vulnerable hardware with SMT/Hyperthreading
(XEN) [   23.959811] enabled.  Mitigations will not be fully effective.  Please
(XEN) [   24.100396] choose an explicit smt=<bool> setting.  See XSA-297.
(XEN) [   24.240254] *************************************************(XEN) [   24.247302] Watchdog timer detects that CPU0 is stuck!
(XEN) [   24.386785] ----[ Xen-4.17-unstable  x86_64  debug=y  Tainted:   C    ]----
(XEN) [   24.527874] CPU:    0
(XEN) [   24.662422] RIP:    e008:[<ffff82d04025b84a>] drivers/char/ns16550.c#ns16550_tx_ready+0x3a/0x90

Fixes: ee3fd57acd ('xen: add warning infrastructure')
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
 xen/common/warning.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/xen/common/warning.c b/xen/common/warning.c
index 0269c6715c..e6e1404baf 100644
--- a/xen/common/warning.c
+++ b/xen/common/warning.c
@@ -30,6 +30,7 @@ void __init warning_print(void)
     {
         printk("%s", warnings[i]);
         printk("***************************************************\n");
+        process_pending_softirqs();
     }
 
     for ( i = 0; i < 3; i++ )
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Thu Feb 17 08:53:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 17 Feb 2022 08:53:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274500.469969 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKcX7-0008JE-Gs; Thu, 17 Feb 2022 08:53:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274500.469969; Thu, 17 Feb 2022 08:53:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKcX7-0008J7-Cu; Thu, 17 Feb 2022 08:53:01 +0000
Received: by outflank-mailman (input) for mailman id 274500;
 Thu, 17 Feb 2022 08:53:00 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=xzkl=TA=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nKcX6-0008J1-3j
 for xen-devel@lists.xenproject.org; Thu, 17 Feb 2022 08:53:00 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 00a37dee-8fcf-11ec-b215-9bbe72dcb22c;
 Thu, 17 Feb 2022 09:52:59 +0100 (CET)
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur02lp2053.outbound.protection.outlook.com [104.47.4.53]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-40-gY-5CE-DOryv5Pz2Q-vqjg-1; Thu, 17 Feb 2022 09:52:55 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5711.eurprd04.prod.outlook.com (2603:10a6:803:e7::24)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.19; Thu, 17 Feb
 2022 08:52:53 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4995.016; Thu, 17 Feb 2022
 08:52:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 00a37dee-8fcf-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645087977;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=AIWwaZsNXUhbiUx2/pIsVIGVMEiOa3To7oqairq16xA=;
	b=WYlWg3E9PD2ID/kB51Ky8fOx80ti42RcYL6q0fLBjbkX/SX6bUbM9HGF9pQ6/dCCmaeJET
	FCBkfJcN45lHF+pQiKO7SYe04mOmuHpcF5WOEt+GikYhzyIwnZQ96cbmsish0/yrGmLg5f
	gfWAmY08PgO5nb1I/G6lBkuEZCb10vY=
X-MC-Unique: gY-5CE-DOryv5Pz2Q-vqjg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=C29iF97BXAAGfAWZVc1/91fYG0ROqg3mtdkU9tmDcmvI+PKcyqZG9svLvhHLnlbWJPjkHhZdA97aXxT6UrwdoWp/0DbgS2TkWKDEiuGlc+h5lyob0lHFjuMqjnZUYZmBoELj7obR4fihEZD86hJKxqaiQV7Y8OAZ5E9HXtCOm2KRdFeK2dC2N97f7qFK9+hgGHQv2uDa0QtAIIlah3UKguAmBSRRtYctvWM9AiGuD6mDVwVShamVGdymi5Hdtu+euvj8v23ROWDWviIK1ZRGRGvMbi9aunfZGGXztsaYNMpbxUqYWGJraED/z6bjCWUocbLugXnvCAGzfndHxETVDg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=AIWwaZsNXUhbiUx2/pIsVIGVMEiOa3To7oqairq16xA=;
 b=cdnXCYOnuFAFYhYu4fplaasMAADG0ejeW9EvOMBWq0AdkHpb9W4lMzRuB5EIQufYdWAYE98+zVAHK+sCCJ7rbuz1wz/M4A5HAv8ughW9hDXN40zVmp2pPzNC3J1eCM+c1lhsRXOUSKb9fMU91/D7Y7uWW0E57ViRzlPyM9MXkg5qdLVGcraIFf+YfAB1Jm5nnmqNjRbqi2B1yeYEfnkZTqveDSm0bJ1C32b4RjS7fRAJRI2oqeEHwV0XvxKUH7j/298gQFn6Ea6GR1zU9/ajTZDWXj9jr6ss6bzCzDETs16u4FxTPwbKEy3dZblOyacd6lTEyBpbCOJDmpWOzBwNvw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <9b5a8474-0be2-b4e6-8919-7e22dde1570a@suse.com>
Date: Thu, 17 Feb 2022 09:52:51 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v2 1/5] x86/cpuid: add CPUID flag for Extended Destination
 ID support
Content-Language: en-US
To: David Woodhouse <dwmw2@infradead.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org, Roger Pau Monne <roger.pau@citrix.com>
References: <20220216103026.11533-1-roger.pau@citrix.com>
 <20220216103026.11533-2-roger.pau@citrix.com>
 <979fbc26-925c-f58f-9c1a-9ccd72275c9b@suse.com>
 <fd22f7e19590b0e8679e5a3a15992bd1f8a92126.camel@infradead.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <fd22f7e19590b0e8679e5a3a15992bd1f8a92126.camel@infradead.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9P194CA0003.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:20b:46d::12) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f6386ed0-1c72-4a5d-a177-08d9f1f2e280
X-MS-TrafficTypeDiagnostic: VI1PR04MB5711:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB5711715438AAB97B9F89CA84B3369@VI1PR04MB5711.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	nz/1EYT8v+V2p4Q5LoRAIo0rq9/DL6su2myJnQO6ko4hxwMOFhg1gbjF+HEHhp7VZWT3aJmP48THnJKZRsj4UTjv4GoZKOKWUAJf/Ebg1g3Zh6FtAgn7q0XD7WKHdhjAW3ykqOeJB78qLS/re1dEwJbeWucvNInNwaEUhyCEFxBr8PPuHKuv+olmUjtBn+MupAFLbqlE+PQS4tkw/NsCUH2CQ1N9WxO12K8NbWn1fEKDIq6ns7d6Hi17iFwYW1LZjDH3RD0Cxzr9G1f7GIvriYa3tegoinFHQMyyU+a13kb99O9DRyd+H61wHQE+F6C41SOuXsslgJ9TUuDxUrNboku9mRO1paeZLE8yFm76jGhXqAzljMUxUcWA7KrSq0wxaAzwoxbV4TQ6hk7jYp7OkXnKix13q9mkcTl3mGm+0fNuje7MmQuyPo3Zunc7TAGsyerwhWtr6ZNlJpVJWH21MSINIh8HLwIiTHEL6Vny2oilE7xp3SgApNQB3thpdHccId9qz/yHeRYtMHwy+qXDiaGualm0J218Mtqk0G6Jz8yf4+vQweTZSBDZWoYIgjybmGysONoPaDpHl9O1a3x0MFjrkpLgux/GBWoaKvc4yaadcP+gy41DkZuZ3v/dGDlO2CUP/ESN9zhlYcX0mN2Twr09W5l4ZQKnh9w0kkoHMBU/MNLFwkr0AypVn851uCPBOrezZtfm8FhkyvpJWsOUG5MlT9Lq2vpol3AHTbwK8hOCm0GfJK92K1MBL48qSCOF
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(54906003)(316002)(31696002)(86362001)(38100700002)(6486002)(508600001)(8676002)(6916009)(66556008)(2906002)(66946007)(4326008)(36756003)(31686004)(8936002)(83380400001)(66476007)(2616005)(6506007)(6512007)(53546011)(186003)(5660300002)(26005)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?U25Ed3BYWFFCZjRkVXBJV3F5TEFkSzRCVEplbElqRHlCRzNMTEduUWg3aUxO?=
 =?utf-8?B?RmFmRHhiYmFSY0ZqL2NpR1Y5b0EzSmhvUXM5SUhHZ213VXdwS0hUY1dNR1dL?=
 =?utf-8?B?N21zbGwrVHZNYXR5NlEzMDduODk0RzJic1IyK2lodldBeWdhNHlmVXNEZlAr?=
 =?utf-8?B?VndDMWUrLzg4cXRHeHlRWmt3K1hzMUV0U0FYa0NFd1NFaGN3ZTVIZE4vajls?=
 =?utf-8?B?eGhLSk41QVo2T3NZbzIvdTBtNWJKeGpPYnRYZ0t6ZDIzMWd3R2hEUC9VQ0pL?=
 =?utf-8?B?RWZPWlZhWERMRzJxT25DU0tESEM1blBORm5vWENrYmE2N21HYjdkbjRnWG9F?=
 =?utf-8?B?OE1nWVd0Ukx6aW8wTVk2SWUrbVhNSzVhSnpOZktQdGp4MU1Nc3NubExGbTFW?=
 =?utf-8?B?WVplb2l1OXlGKzhwK3ZPVk1xdFVXOU9Ed0RWZWxqa2Y0T21XNzdUMGpYdk5m?=
 =?utf-8?B?NnZKcDNXaXFZeWVlbXBVOS84THNFanJYRms3bE04K0JKR3ZNaG9LVHpmZkpU?=
 =?utf-8?B?VXdQVk8wL213K0kreGpGajQzeUw2OFF4a2E4Z0pxVTFoNEFxY3lTZXF6RVp1?=
 =?utf-8?B?U2swYXFMSis3VkZiNWdZakZMWi9wblBzUnRUYW9wUGgwNDRIYzVvai85cTdQ?=
 =?utf-8?B?TlhKMloyZVNqQXZVV1JpWm45aG82cUdoWEY5bG4zRS94U1RMMVBJaUJLOWIr?=
 =?utf-8?B?VTZ4VVdsVDhEKzl1ZzJPVFFZNDRTVGcxKytHcEorZHNtc1BRVEVva1Q4MDY4?=
 =?utf-8?B?WkdUbDBNTGE4YjY1TDN4ZEhnSmJTV2Z2dmxEOHJtMmk0QWlrRTNTZGtDOTdB?=
 =?utf-8?B?YkliQUtObDFmY3V3U0NqQ2VrUGRZejJkR0Y1Z2ZzTmZ5dVJUcVpaRkFZUTdx?=
 =?utf-8?B?M2o0NWdWTzhETEVUT1pOcnhoVnV0bGNVQ1k1UWFFTDcvWWRuWVMzdDdwemMr?=
 =?utf-8?B?cTVXNzNRUTUxTFB5aHNxeEdEcW1CV2R6SkI3VDVzSEJTVlE2NVFrMitram43?=
 =?utf-8?B?OFVkWDQvVU8rcjhDSXFWbFhSK29OUCttTUdYdHZ2TTdIenp3T1A3N25OclNQ?=
 =?utf-8?B?cDhkaERreDFuWkkvNDRlQ2k5YklzL3dTL0FLbTdSa0ovakdDdXpveUVOU091?=
 =?utf-8?B?MmdRTzZNRTdRblYxVHNLckNFUk5scWVSTW12WXlyVVRFajBMVFBwZ1pWbFJl?=
 =?utf-8?B?aHFQaUdMSGszTHlJWU1BLzMreGpRRlArWU14OVNOQWJwVEYvZDE1aFdsa2Ns?=
 =?utf-8?B?K2JJd2dVNkdSeEkzZElUcllyR3R3TlBJbTMyOVNUb2dLYjBhN2xlWFJGTFpp?=
 =?utf-8?B?cGIvV1hYajFDZGlqR3A4VkdVQlhyc214TG9SNTQ5d1lJck1EaEhsYkc5OE9t?=
 =?utf-8?B?OEk0V3FFaFpjeDIvYTRsQlNVbXFDeG52Y3lkY2NYV3l4cHBvaTlvTjZRb2pD?=
 =?utf-8?B?eEdIT0w1b2RMZks3TlFFbGNFQ2J6cE90V25EZGJGbWJLQVVDVFhJaWVPMElI?=
 =?utf-8?B?bjhNQ29Ka1FUakNrd1h3Rk1kR2xzV1FCUjNFdlphTkE1K2JqSUZTYnNZQlNq?=
 =?utf-8?B?MCtRQkFRYWtXOUQ4L2gwUWdQRWRweEVsaXY4eUNZaVJ1MUs0QXo1d2FaWHFv?=
 =?utf-8?B?aVdmK0RDbGk2NnFGRnFKQ0RsUHpEZS80cWk4Wnp6SlBKRGZ3ak9SNkhYLzZq?=
 =?utf-8?B?dllmb0cwQnd3ZklXOXJFY0xZcHowb3JCRHNONzlva0YzWFNrVFV3SENyOHZa?=
 =?utf-8?B?NXM5L1RwR0U5ME1uY0QxR2o4OUJTcko0dkNpTFRiWEVudVdPZnRLaG5TQzhE?=
 =?utf-8?B?cjkrMkZTaXZzQWtqbmFvMzhpZHZSTVhpb3J5SHdKbllLME10ZEduaFhwRlRm?=
 =?utf-8?B?SCtFdElyRlplVFVPdDRNdmtqbFoyUkNoMGdxZ3FWTk1UT1p5dTF5Uk0zcGJ2?=
 =?utf-8?B?SXhqcVRqd2p2SVUyMW5zOTRiTkkwVlRaa3FkQWx0Q3I0cUdxNXcrY0hhSVAw?=
 =?utf-8?B?NmVQa0dKWjRtNkhleWxSOXlRNzJ0TnF2RjFFUGJzWHI5cUxWNFR4RFBGbW4r?=
 =?utf-8?B?THYvdWduOUNPVTdGMVRTTFZ4eGRJNHZZYS9NZzAwUHBRR1hvWFZZRkRrN0w0?=
 =?utf-8?B?VU1VUjVMaVZtMWd1SS9WTmw1TmtIRDNHazBIZlYxWWJkMlg4UVNjdjBYbG5V?=
 =?utf-8?Q?PU7yI7N1p8JG0VTEt3mKKbs=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f6386ed0-1c72-4a5d-a177-08d9f1f2e280
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2022 08:52:53.7846
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: u/9JLl2CCK8T+lT56MSNLGAOdTve3ys1vORGxyTH0XOHT+rZw+zxqVsx+CdiPfT6LJKA809GmxJZg4WWU4bcbg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5711

On 16.02.2022 17:08, David Woodhouse wrote:
> On Wed, 2022-02-16 at 16:43 +0100, Jan Beulich wrote:
>> On 16.02.2022 11:30, Roger Pau Monne wrote:
>>> --- a/xen/include/public/arch-x86/cpuid.h
>>> +++ b/xen/include/public/arch-x86/cpuid.h
>>> @@ -102,6 +102,12 @@
>>>  #define XEN_HVM_CPUID_IOMMU_MAPPINGS   (1u << 2)
>>>  #define XEN_HVM_CPUID_VCPU_ID_PRESENT  (1u << 3) /* vcpu id is present in EBX */
>>>  #define XEN_HVM_CPUID_DOMID_PRESENT    (1u << 4) /* domid is present in ECX */
>>> +/*
>>> + * Bits 55:49 from the IO-APIC RTE and bits 11:5 from the MSI address can be
>>> + * used to store high bits for the Destination ID. This expands the Destination
>>> + * ID field from 8 to 15 bits, allowing to target APIC IDs up 32768.
>>> + */
>>> +#define XEN_HVM_CPUID_EXT_DEST_ID      (1u << 5)
>>
>> Would the comment perhaps better include "in the absence of (guest
>> visible) interrupt remapping", since otherwise the layout / meaning
>> changes anyway? Apart from this I'd be fine with this going in
>> ahead of the rest of this series.
> 
> No, this still works even if the guest has a vIOMMU with interrupt
> remapping. The Compatibility Format and Remappable Format MSI messages
> are distinct because the low bit of the Ext Dest ID is used to indicate
> Remappable Format.

Well, yes, that was my point: With that bit set bits 55:49 / 11:5 change
meaning. As an alternative to my initial proposal the comment could also
state that bit 48 / 4 needs to be clear for this feature to take effect.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Feb 17 09:00:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 17 Feb 2022 09:00:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274507.469980 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKcdt-0000bx-Bq; Thu, 17 Feb 2022 09:00:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274507.469980; Thu, 17 Feb 2022 09:00:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKcdt-0000bM-5J; Thu, 17 Feb 2022 09:00:01 +0000
Received: by outflank-mailman (input) for mailman id 274507;
 Thu, 17 Feb 2022 08:59:59 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=xzkl=TA=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nKcdr-0000YO-He
 for xen-devel@lists.xenproject.org; Thu, 17 Feb 2022 08:59:59 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id fb42625c-8fcf-11ec-8eb8-a37418f5ba1a;
 Thu, 17 Feb 2022 09:59:58 +0100 (CET)
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2052.outbound.protection.outlook.com [104.47.2.52]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-41-qrhNlcobNSaFFLNtp9pmPw-1; Thu, 17 Feb 2022 09:59:56 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM9PR04MB7681.eurprd04.prod.outlook.com (2603:10a6:20b:286::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.17; Thu, 17 Feb
 2022 08:59:54 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4995.016; Thu, 17 Feb 2022
 08:59:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fb42625c-8fcf-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645088397;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=0kSekM1LszJuw8C4+D+KVcAZC+OFUak0kpiGLwXtTU0=;
	b=XmP3yICYON2wzQf3cP7osmEE1ZJGtrlstarJgvwaEsMS9f6g8ku9USe6p4Wo8Y63aHtjdT
	B/HMzQx2YknABufqWtzbIQ+cYxh/UyP/6XPTMSEZa1C7AKjoKQPkzmQpziVxGMuDq7Yq9c
	IBTndTvxU0+TYZ9DYyEJ3zmVWnybiXM=
X-MC-Unique: qrhNlcobNSaFFLNtp9pmPw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=R6O8ADVm8RSaGrbcycxBD7f+hOPB0B+4IElp4e9r8Md362Nnu1lPV4g4t6Qy5iBBygb/UUkTdyjrOBTxM8cxqENuaPzspAtNrM0Hode816Z36nsUPWrSNUgdfl416bAAt/8oOrylfKx1pVfU0icamMu7ghJmV6OPJoAU39UAW8pYW2ZnSpr9hRPTV0WK7NUDMBbfTSUzKXsZ6iOSUcuQts6BGpjkkb/M9dr37p7+8tYnlgVfhIiyMP7vrA0Wd72elDtEh24mrNGqIyX1s5h9+LJ/tRE0HYHkt+aN4QHKvsfJ5hMDERbaNDWGnVopTSf6nOFmbmhvvDgcFxf73z8tsQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=UA/k/Mxh1ePla6moqwRTP2hCd5vGqy6eR507Pa1dsr4=;
 b=FuuPOpgZuw2SCd0QB93XbCrUxtVgKy7xuQMFpDNJkrGzPR4V0HhE+hfuuiCHVvCQa/6f+DDZ0F1HZSu53mX18ySPSXVyNVBAAupLqjHG5Xs1za9/p+XCjbJX78s9As5hyj4bQS+ic+xtT35YBf/9X36M2o0E/01zHtGebMnd1duDBopTQhUy03ElDDaL+5h05owviaTsTyIBAkCiDVKLE30Z04M2F6BHhZK/mewcnMMqTsZjEkq0snmLxN9NARmMeX2Y71cbND+MqDfoW64qidCnbeTms69ATEdK7+LXmsiNOBaoIpm127ht75v8o26v0+wBx+6Gz3EeK/iEbIt5WQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <7e5f721c-9771-bf35-8b94-f7fec7cd6eeb@suse.com>
Date: Thu, 17 Feb 2022 09:59:52 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v2 1/3] x86/retpoline: rename retpoline Kconfig check to
 include GCC prefix
Content-Language: en-US
To: Roger Pau Monne <roger.pau@citrix.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220216162142.15384-1-roger.pau@citrix.com>
 <20220216162142.15384-2-roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220216162142.15384-2-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM5PR04CA0020.eurprd04.prod.outlook.com
 (2603:10a6:206:1::33) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4c341f14-d6e8-4bc9-4758-08d9f1f3dd73
X-MS-TrafficTypeDiagnostic: AM9PR04MB7681:EE_
X-Microsoft-Antispam-PRVS:
	<AM9PR04MB76817A0D9AC34EB42C028F37B3369@AM9PR04MB7681.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6430;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	vDUdYgfM9pu6u210LTIi73l/d5ISpS6jjcRN8SJVYVTAVpuac6IZ4WLDs5bMS8iywhL9MOWq7J4oUVPGVrEsGHmllPIDRSA/8UkLL0uGhCEtmNIrJPDsVrtVf0SEKLNwe7mkhDFFV8i0sUNPnhh+lb6hacCKY9185agaEXGGMGdPzoo0t3LIWJ4W0D+4g8szbhdmP0iFWdabyZ39pr6DNjo7VGLm+I8eDKsgSfAx0Kw2fnkgdzfXfM6zbQUHpQyybHm29gPgy3wa+xYlAXKySOdGgI6qQopY2Vl1MRKwJc5RfGAjqmEUg8AJD+Qcgh4JODjcg0RaPbNtCpO+S2YFuP/yaaYxa4ZHwhOGeNdKEBFPKYEjftJftcNj1Z6lIxXoeufqr07KaxVvrQYc+7iyij2ZxX23B2N749QGF4geb4MdvxYdIaH8xGD2p1yKXYL6DU9f3/JUmpGLGkG1ocNacGQhQKZ58l6A0Vbn6ezkyLQFu0GXI6Y0XKKcM41p0Xmv5DQqIryfY7Dtdsdl5dyZeA6xUkAHfkD5ZU1aJ3KQVR6v1I0Combiel6Ox75IngjHYKnn/QSuBlE0dpdEyt41U7w4Pigaobrq0vLssi5aTuncGpinQQZLFXKU0VJTMG0LMFiA0H+TUMyOdau8xbHrKVmZm9kTfZblHdYjs+0BDlq/XxdrU9PtKYLXcLHjPX+uAW74p56nRkLtR/KlTBf/V1g0pyf84xgcmtsV6t1TJp/ZkpBnyf4YcYgNVX1bo9cv
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(5660300002)(38100700002)(8676002)(2616005)(4326008)(6512007)(66476007)(66556008)(53546011)(66946007)(6506007)(2906002)(8936002)(86362001)(186003)(31696002)(26005)(316002)(6916009)(6486002)(36756003)(31686004)(54906003)(508600001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?F9QHRyffy5/+J1ukqait9lDebMtrJA7PucyI87N40wqDKNJXPEPhm6fDxPUe?=
 =?us-ascii?Q?7cklTmdFHDW1vmnjxfWZmhoo2AAOrmm3HI0KDqL2IDL1WkPiLr6fSyJF7RQm?=
 =?us-ascii?Q?0VagoUd/DyLtU0SqwA9PiufzpwEntVsuo08Ay+9o6vEWZJj5kxNQ3CaV7AK2?=
 =?us-ascii?Q?bbfOrkfdAF3BQYQv35Ovp1JlhXBFR8qHIx1XI3xJRuEhkRAlconsDs8n+4K+?=
 =?us-ascii?Q?nYUHdMsJPTc/wHm/fgj4qxi2cjy7N3SJrjDi/HgFDDQ8RaX5zxITQ8GrYrpm?=
 =?us-ascii?Q?DatlcUZe+6aAYAMx7cEwCElrgqvhBG0zinI2eNs8P7ugDvXA/o0DTQ8YDj5u?=
 =?us-ascii?Q?onkEscRuu79J1Y/msuld0x5KxbEU9Xv6FxHuxOX49fDrl2Ao3VQgVp/4gFtN?=
 =?us-ascii?Q?A3C2nIif4dwFNApsj7Q+MpjURabLgKxc+yofWo3rdBJRJxtEhpOJ+5fcV1Te?=
 =?us-ascii?Q?djMcMBJ9aQIWVfxYkp8lFjVI2VClEZyfFyc9347NIEVWEh+7Cq/1skT4+MY/?=
 =?us-ascii?Q?9ziX2ZGZ9daiyxCoGpfpehqgxR9FAihC8p0cjjFHcIR1kQcnfsXLThScsy6t?=
 =?us-ascii?Q?VdiOPOIpnL21ABQkjpMt7Ftpn2c0wOS7wXFMC66Z9WUacuu0Dp1D/2xl6rKg?=
 =?us-ascii?Q?xSt35d70cXihKeMHtnJ+U+U4xNcFNWRI0N3nHqoFw/WtQiYSO7YRnQbH4G18?=
 =?us-ascii?Q?Ci30Ite3fyvZrpHfqYq7l792aYd8IUJX57Rv8BZqThxbzl97OBKL14Q4CO9R?=
 =?us-ascii?Q?dUZQ402CZx6Vgc/eEPNbqwYY5LHPjMaarGOdCwYeqhw0XzXrbafXa6emp7bK?=
 =?us-ascii?Q?DN5JJACqfn/rSTfW65W/QuVj0SttPtt9smT+qsFX56aGPEJs2hVjphgljQLn?=
 =?us-ascii?Q?15koKgciVyNsjnnwvAXTXjb051+I1KMmFzTMay/x9yWFJTSO9h1Q0PQ0RbH+?=
 =?us-ascii?Q?Z9Ju8sBVfPE2RPofIUb4+8MZHq9BBYK/h2iLsoYBDan/38OcyPUcYcQwA3VJ?=
 =?us-ascii?Q?KGA2gwxVazn2KVQ0scHN6RRgpGTauuZ38/dPAo2uleCb07p21VZjOOFW6VLO?=
 =?us-ascii?Q?M+5S1ra8we0JUFibZNL+KOTg36YyO8doHTZr7JKcPjBkwAxJQLaSHn+4ZKh2?=
 =?us-ascii?Q?bu4TRfovhAnq3plRl21lS4G+5SPxiyI57ehns6PtqwOGcZrSP65M8aK3TUz8?=
 =?us-ascii?Q?U8ugMInh6dH42V3wY8BGZ9q8PzJrvnYHtXhVXeOBB7kr1O+VOuIyviT7xI14?=
 =?us-ascii?Q?MvlFHVCNPSjRpXooQRZo8XTox8WgQiHjnC9Ks2xArc790mpaUzNa5d492kyk?=
 =?us-ascii?Q?2bROmmx/8ElYJVFky3sFFlzUNkkITzmOOa9q87mYg/JiR4Th4eHDbz84QXJd?=
 =?us-ascii?Q?SbpN2xipjWFw/H23J3hP72+AOKoQV+0+9fa8JWWjNaG3K5oow7xIHwTwbyHx?=
 =?us-ascii?Q?4SSLHnpx3EnjceGMd346QAL+ZLqoBHezGPcu0ZlTRHfX3lsK9V3a3TA3LnbM?=
 =?us-ascii?Q?A4cxE74TR7ddZ1DCsNTCOKi/b8pwBbebR/1qJywkIe7hVMKDpkTNr7pQNwnJ?=
 =?us-ascii?Q?trh/cEbYUnSEGh0T5OyO+e3Ff78WE7xiZTCWMQg72MFQwaeSJfG0uEPxo/HC?=
 =?us-ascii?Q?1jeePpUhMGjZowNRbIIBZCQ=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4c341f14-d6e8-4bc9-4758-08d9f1f3dd73
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2022 08:59:54.6489
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LRERGViv871beSguKJaqSn+3IKDP09MONNW+PemoairLn8ja32PioYP8mQlLc+uWgpM1n3AsWQh0Ob4vaLjwoQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB7681

On 16.02.2022 17:21, Roger Pau Monne wrote:
> Current retpoline checks apply to GCC only, so make it obvious by
> prefixing the Kconfig option with GCC. Keep the previous option as a
> way to signal generic retpoline support regardless of the underlying
> compiler.
>=20
> No functional change intended.
>=20
> Signed-off-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>
> Reviewed-by: Jan Beulich <jbeulich@suse.com>
> ---
> Changes since v1:
>  - Put def_bool before depend on.

Just for the record: A slightly shorter alternative would have been ...

> --- a/xen/arch/x86/Kconfig
> +++ b/xen/arch/x86/Kconfig
> @@ -32,9 +32,13 @@ config ARCH_DEFCONFIG
>  	string
>  	default "arch/x86/configs/x86_64_defconfig"
> =20
> -config INDIRECT_THUNK
> +config GCC_INDIRECT_THUNK
>  	def_bool $(cc-option,-mindirect-branch-register)
> =20
> +config INDIRECT_THUNK
> +	def_bool y
> +	depends on GCC_INDIRECT_THUNK

config INDIRECT_THUNK
	bool

config GCC_INDIRECT_THUNK
	def_bool $(cc-option,-mindirect-branch-register)
	select INDIRECT_THUNK

A more appropriate thing to use for "depends on" might have been
CC_IS_GCC. With the next patch in mind this would then avoid
potential confusion if e.g. Clang folks decided to (also) support
the gcc style command line options.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Feb 17 09:00:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 17 Feb 2022 09:00:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274512.470003 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKceG-0001s0-NG; Thu, 17 Feb 2022 09:00:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274512.470003; Thu, 17 Feb 2022 09:00:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKceG-0001rt-Jt; Thu, 17 Feb 2022 09:00:24 +0000
Received: by outflank-mailman (input) for mailman id 274512;
 Thu, 17 Feb 2022 09:00:23 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=u+F2=TA=arm.com=Luca.Fancellu@srs-se1.protection.inumbo.net>)
 id 1nKceE-0001nC-MM
 for xen-devel@lists.xenproject.org; Thu, 17 Feb 2022 09:00:22 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04on0616.outbound.protection.outlook.com
 [2a01:111:f400:fe0d::616])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0826b690-8fd0-11ec-b215-9bbe72dcb22c;
 Thu, 17 Feb 2022 10:00:20 +0100 (CET)
Received: from DB8PR09CA0001.eurprd09.prod.outlook.com (2603:10a6:10:a0::14)
 by PA4PR08MB6093.eurprd08.prod.outlook.com (2603:10a6:102:e8::7) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.17; Thu, 17 Feb
 2022 09:00:16 +0000
Received: from DB5EUR03FT027.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:a0:cafe::78) by DB8PR09CA0001.outlook.office365.com
 (2603:10a6:10:a0::14) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.16 via Frontend
 Transport; Thu, 17 Feb 2022 09:00:16 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT027.mail.protection.outlook.com (10.152.20.121) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4975.11 via Frontend Transport; Thu, 17 Feb 2022 09:00:16 +0000
Received: ("Tessian outbound 341d209a0e52:v113");
 Thu, 17 Feb 2022 09:00:16 +0000
Received: from e58b2d5dbee0.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 59F95ABE-6C7A-4E45-A814-8965CED7BEF0.1; 
 Thu, 17 Feb 2022 09:00:09 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e58b2d5dbee0.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 17 Feb 2022 09:00:09 +0000
Received: from VI1PR0801MB2125.eurprd08.prod.outlook.com
 (2603:10a6:800:5b::23) by PR2PR08MB4844.eurprd08.prod.outlook.com
 (2603:10a6:101:1d::12) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.14; Thu, 17 Feb
 2022 09:00:03 +0000
Received: from VI1PR0801MB2125.eurprd08.prod.outlook.com
 ([fe80::5531:4c33:a50c:ea0e]) by VI1PR0801MB2125.eurprd08.prod.outlook.com
 ([fe80::5531:4c33:a50c:ea0e%9]) with mapi id 15.20.4995.017; Thu, 17 Feb 2022
 09:00:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0826b690-8fd0-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Vbq2pUhWcYMWmBB4geu0FnnTyGexLI9QGune3Xs7okg=;
 b=384oGFtPGlurVaGLtUp2STuypFETnBwxlJ6H/gvirn8CJWFF6on7cmuH/dhQswGDFg2S771eueuMoxnPymw3N1zIz2M1Ket/86kaV2Bt5KIEtVYi7Rej5Asg4SlJ6DabuJKFNi4FcG+b6Qlw4bQ8AsS3OqFGNsTZdY9xYgUZl9U=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 7c660b119950a015
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Yud2LlJ0x9hR3z8RyxNLtQ+Js34WRpqMoeaHTdwZ8+WjP3F0lYK4Diw2D6LnMbdA2M9r/X9TumjpqOMIzeNg/YgGUiLJONrViM2nTHlWZ2iBx7DJgHliXLEKpDIFMgvW8OTC2/vm9TYkH5cN/HiRmF1SR32PCc/X5fUUggP6lvLL9NpyjZ67/1sB2ya6VJoYmmBrTTp2mw7xWTCySWZzSWgaN+RuHGGuhywX5ucs1b0iwYxl7VDBVAfEUCrIjk/HeR/MASwwOCeAQluuWJkR1D7M4sc1L3HRKyjpodEgDvTq4EM5lEdIAb3YiFYo/pG+FycpsnbBb4iRiOTSSJ6UPA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Vbq2pUhWcYMWmBB4geu0FnnTyGexLI9QGune3Xs7okg=;
 b=fP7E9NFJ4w24rsxVpM5gxfl9BuSWoZjLUnV26sq1wxbOYmsg3Q5ujLIRdHpq+AWFmRWg3mfE0EUem+Bu/e7XwI5EhT89HnUXFr0w+5sCBev7hsHQNvNPBIQw3TFx+4sDEzMeg/JxzHwArm2st+0YcyhRfSIlwMqKAmLtx5lCC9AgOfB/Pq0MTHivrKbj6sQAIUZA9gNmvANfiKC+VxlDDJ/4LTrVqSpAgBLf/oFG7CNFfUU3slCcGdYMdPlvC/ReGGJD5kjXB8hq0qecDnuSB3GfbnEKCMRK2N5pdW0AAHa+GRbnaH/vCPZR8KF87JRO/OynZwiFzu8Op0lK+9Q+BA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Vbq2pUhWcYMWmBB4geu0FnnTyGexLI9QGune3Xs7okg=;
 b=384oGFtPGlurVaGLtUp2STuypFETnBwxlJ6H/gvirn8CJWFF6on7cmuH/dhQswGDFg2S771eueuMoxnPymw3N1zIz2M1Ket/86kaV2Bt5KIEtVYi7Rej5Asg4SlJ6DabuJKFNi4FcG+b6Qlw4bQ8AsS3OqFGNsTZdY9xYgUZl9U=
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
Content-Type: text/plain;
	charset=utf-8
Subject: Re: [PATCH 4/5] xen/cpupool: Create different cpupools at boot time
From: Luca Fancellu <luca.fancellu@arm.com>
In-Reply-To: <69d80e47-ad4a-5fa7-acdb-96da6c9598de@suse.com>
Date: Thu, 17 Feb 2022 08:59:58 +0000
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Xen-devel <xen-devel@lists.xenproject.org>,
 Wei Chen <wei.chen@arm.com>,
 Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <E60AD169-4721-4C27-ADC0-DD575AD62D8A@arm.com>
References: <20220215101551.23101-1-luca.fancellu@arm.com>
 <20220215101551.23101-5-luca.fancellu@arm.com>
 <alpine.DEB.2.22.394.2202151827380.43738@ubuntu-linux-20-04-desktop>
 <53747C8B-681A-4474-B1DF-F08702322AB9@arm.com>
 <44d2673b-2450-81cf-5d3e-9afb23ae09c6@suse.com>
 <1D92168D-DFD6-4B1A-9079-FBFDDA9F2969@arm.com>
 <69d80e47-ad4a-5fa7-acdb-96da6c9598de@suse.com>
To: Juergen Gross <jgross@suse.com>,
 Dario Faggioli <dfaggioli@suse.com>
X-Mailer: Apple Mail (2.3693.60.0.1.1)
X-ClientProxiedBy: LO2P265CA0486.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:13a::11) To VI1PR0801MB2125.eurprd08.prod.outlook.com
 (2603:10a6:800:5b::23)
MIME-Version: 1.0
X-MS-Office365-Filtering-Correlation-Id: b012262a-1834-4234-1c10-08d9f1f3eaac
X-MS-TrafficTypeDiagnostic:
	PR2PR08MB4844:EE_|DB5EUR03FT027:EE_|PA4PR08MB6093:EE_
X-Microsoft-Antispam-PRVS:
	<PA4PR08MB60933546A11EF39BA2B7B7D8E4369@PA4PR08MB6093.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 i5B2dpFInuaHb4ZtndqLu+Yd/m+9MHmpo581kVPShStfidnPxilXRqsvRLm+uaqtYKxvHmrB172XA6R/XMf3IqLxfk5BHs+66KUIa5tKNA7CWI7J3WRHok7H/I27IulkZmw6nvNypp4yD4MXh9Bcy5F3zew8NyO7zIbjbM2C+AJ+S/ULlKnSQB65ok6AEn0hrWUu5HLwivfrrF3ng+Mv6MD9NfaHIVY78dWvamf1X2Ln2rOXldVvJkV8cUpZIM4a2/LxFj0Y4UChSrjCnYo6coiYbFrZd7ja/tAR4ejLuN3EcHp+jwpqIY0kHwyhk5Ew0YuBpuDFhZXNqvkp8tl+16IVz6gpNRY7jSM1Iu8a1nY5sPPzzRCDPTEde3Go1adzJjMeEVUc+AURr15lG6TK4MsO09kvBXHL0SVwfZ6b5mICpQ3pYSmfJlaleflgwA1qZZQh8nidEAq7YB8qy1qmBO10TZfn1IMTWYl8I+zX8pRx8N9TZUNnIspofhblXZfTdR03hFe9dLpNWgDyvaq9K1XxxLBDLCVbmqP3yMiUcP4vy8xDFO66j1gohIm0CxpEFpYLwV/tLfbIaiSB/W4OJefuYbD4t1UV9rFUFYHvMDyQqb4j65qFr5ZyCodneZkROCbyHi+l6PgOeTu0ibw7yqP6nuDBrjC44ri8dTakEy17R2QKShB64E7ywGSGR/beBp/YZpA8BteiRDaCziVWlWNOgXFeabzG1uVe1yjs3Zc=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR0801MB2125.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6512007)(54906003)(6666004)(86362001)(6486002)(110136005)(66556008)(66946007)(8936002)(66476007)(4326008)(53546011)(44832011)(508600001)(36756003)(7416002)(5660300002)(186003)(8676002)(33656002)(26005)(38350700002)(316002)(6506007)(83380400001)(2616005)(2906002)(52116002)(38100700002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR2PR08MB4844
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT027.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	9355360f-6a54-4757-e22f-08d9f1f3e28f
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	OWVQ7b+4q3wOY2P4OAsRxBwgz5XR+tpbY0LeFq8gqm6kFNZLPCr7VpulNU/SesPZ9dEjdD2Hg4jRAsDAU9i3S+oCGOTq/rQ4jlpazoWQr+vqxA7Sttf7Y+G7rbYSrBco6C6NNFBj/JiARSxGg3Urg/Mxk4RhNVLL4bvluwH+v1vAijCZWB5HNGb1rm1tIRaeSVFfbSjcvNd4inMZZHFvqUlUdB1mffeaKw+5OKBTnGtpQYZ84C7yU3c2erkWqjKkwlr1asnRqQTPryOG/CboTssjTESNBX9+m30lyIzKjxVkAfi41v8fdT06zXoYUEvX9gWEHrMicIUVd/BlIQDzwSd7lbpd6NK0G4XJ4leIEU1wGWf50l63vKlDjyEEMi382E4zDdF09qaVbIiO2yTA9l32o8HFm1Vjh+v6XbXrEPpaENtdYI/1kISF6N1wSWuaQBtDSkXUmIDm06cVHb4Iwaoekfz1gBX3zldtethchq8i1ddQ3hBXf2Ri+J60NJ2MLOLmvZ6Vq0sIFVoaz5g5Ik4hQ56cRlDT3BI26aWo55jkTgpUMOAHFDUSAb/vBdgIyTJiR84wLFwJbpAIKbsSCC0iAIDARhiPYn1r7i7kfMKS7IQRrtTLeFLd5EbDaW0GzOrLr/xmYw4vPs0YgiPfjQjk05aPMVvYlfgD/SHV6YEPhN6INXBLclH/U9eExEdG
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(186003)(6506007)(4326008)(36860700001)(6486002)(6512007)(6666004)(53546011)(508600001)(36756003)(33656002)(316002)(70586007)(8676002)(70206006)(110136005)(83380400001)(47076005)(54906003)(82310400004)(86362001)(26005)(2906002)(44832011)(356005)(2616005)(336012)(40460700003)(8936002)(5660300002)(81166007);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2022 09:00:16.5974
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: b012262a-1834-4234-1c10-08d9f1f3eaac
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT027.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6093



> On 16 Feb 2022, at 13:07, Juergen Gross <jgross@suse.com> wrote:
>=20
> On 16.02.22 14:01, Luca Fancellu wrote:
>>> On 16 Feb 2022, at 12:55, Juergen Gross <jgross@suse.com> wrote:
>>>=20
>>> On 16.02.22 13:10, Luca Fancellu wrote:
>>>>> On 16 Feb 2022, at 02:45, Stefano Stabellini <sstabellini@kernel.org>=
 wrote:
>>>>>=20
>>>>> On Tue, 15 Feb 2022, Luca Fancellu wrote:
>>>>>> Introduce an architecture specific way to create different cpupools
>>>>>> at boot time, this is particularly useful on ARM big.LITTLE system
>>>>>> where there might be the need to have different cpupools for each ty=
pe
>>>>>> of core, but also systems using NUMA can have different cpu pools fo=
r
>>>>>> each node.
>>>>>>=20
>>>>>> The feature on arm relies on a specification of the cpupools from th=
e
>>>>>> device tree to build pools and assign cpus to them.
>>>>>>=20
>>>>>> Documentation is created to explain the feature.
>>>>>>=20
>>>>>> Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
>>>>>> ---
>>>>>> docs/misc/arm/device-tree/cpupools.txt | 118 +++++++++++++++++++++++=
++
>>>>>> xen/arch/arm/Kconfig                   |   9 ++
>>>>>> xen/arch/arm/Makefile                  |   1 +
>>>>>> xen/arch/arm/cpupool.c                 | 118 +++++++++++++++++++++++=
++
>>>>>> xen/common/sched/cpupool.c             |   4 +-
>>>>>> xen/include/xen/sched.h                |  11 +++
>>>>>> 6 files changed, 260 insertions(+), 1 deletion(-)
>>>>>> create mode 100644 docs/misc/arm/device-tree/cpupools.txt
>>>>>> create mode 100644 xen/arch/arm/cpupool.c
>>>>>>=20
>>>>>> diff --git a/docs/misc/arm/device-tree/cpupools.txt b/docs/misc/arm/=
device-tree/cpupools.txt
>>>>>> new file mode 100644
>>>>>> index 000000000000..7298b6394332
>>>>>> --- /dev/null
>>>>>> +++ b/docs/misc/arm/device-tree/cpupools.txt
>>>>>> @@ -0,0 +1,118 @@
>>>>>> +Boot time cpupools
>>>>>> +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>>>>>> +
>>>>>> +On arm, when BOOT_TIME_CPUPOOLS is enabled in the Xen configuration=
, it is
>>>>>> +possible to create cpupools during boot phase by specifying them in=
 the device
>>>>>> +tree.
>>>>>> +
>>>>>> +Cpupools specification nodes shall be direct childs of /chosen node=
.
>>>>>> +Each cpupool node contains the following properties:
>>>>>> +
>>>>>> +- compatible (mandatory)
>>>>>> +
>>>>>> +    Must always include the compatiblity string: "xen,cpupool".
>>>>>> +
>>>>>> +- cpupool-id (mandatory)
>>>>>> +
>>>>>> +    Must be a positive integer number.
>>>>>=20
>>>> Hi Stefano,
>>>> Thank you for your review,
>>>>> Why is cpupool-id mandatory? It looks like it could be generated by X=
en.
>>>>> Or is it actually better to have the user specify it anyway?
>>>>>=20
>>>> Yes at first I thought to automatically generate that, however I neede=
d a structure
>>>> to map the id to the cpupool DT node. Here my doubt was about the size=
 of the
>>>> structure, because the user could even specify a cpupool for each cpu.=
 I could allocate
>>>> It dynamically and free it after domUs creation in setup_xen.
>>>> What do you think could be the right way?
>>>> Or the dom0less guest could specify the id, but I like it more when us=
ing a phandle to the
>>>> Xen,cpupool node.
>>>>>=20
>>>>>> +- cpupool-cpus (mandatory)
>>>>>> +
>>>>>> +    Must be a list of device tree phandle to nodes describing cpus =
(e.g. having
>>>>>> +    device_type =3D "cpu"), it can't be empty.
>>>>>> +
>>>>>> +- cpupool-sched (optional)
>>>>>> +
>>>>>> +    Must be a string having the name of a Xen scheduler, it has no =
effect when
>>>>>> +    used in conjunction of a cpupool-id equal to zero, in that case=
 the
>>>>>> +    default Xen scheduler is selected (sched=3D<...> boot argument)=
.
>>>>>=20
>>>>> I don't get why cpupool-id =3D=3D 0 should trigger a special cpupool-=
sched
>>>>> behavior.
>>>> Cpupool with id 0 is embedded in Xen, it has its own special case hand=
ling in cpupool_create
>>>> that is giving it the default scheduler. I thought it was better to le=
ave it as it was, however the
>>>> cpupool0 scheduler can be modified using sched=3D boot args as it was =
before.
>>>>>=20
>>>>>=20
>>>>>> +Constraints
>>>>>> +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>>>>>> +
>>>>>> +The cpupool with id zero is implicitly created even if not specifie=
d, that pool
>>>>>> +must have at least one cpu assigned, otherwise Xen will stop.
>>>>>> +
>>>>>> +Every cpu brought up by Xen will be assigned to the cpupool with id=
 zero if it's
>>>>>> +not assigned to any other cpupool.
>>>>>> +
>>>>>> +If a cpu is assigned to a cpupool, but it's not brought up correctl=
y, Xen will
>>>>>> +stop.
>>>>>=20
>>>>> Thank you for documenting the constraints, but why do we have them?
>>>>> Imagine a user specifying 3 cpu pools and imagine the cpupool-id is
>>>>> optional and missing. We could take care of the cpupool-id generation=
 in
>>>>> Xen and we could also assign the default scheduler everywhere
>>>>> cpupool-sched is not specified. Maybe I am missing something?
>>>> Yes we could make the cpupool-id optional, my doubts are in the fist c=
omment above.
>>>> Whenever the cpupool-sched is not specified, the current behaviour is =
to use the default scheduler.
>>>>>=20
>>>>> Does cpupool0 has to exist? I guess the answer could be yes, but if i=
t
>>>>> is specified as id of one of the pools we are fine, otherwise it coul=
d
>>>>> be automatically generated by Xen.
>>>> Yes cpupool0 needs to exists, however it is still generated by Xen reg=
ardless of the DT
>>>> specifications. In fact you could not specify in the DT any xen,cpupoo=
l compatible node
>>>> with the cpupool-id =3D=3D 0 and Xen will generate the cpupool0 anyway
>>>> (Xen internals are tied with the existence of a cpupool0).
>>>>>=20
>>>>> In any case, I don't think that cpupool0 has to have the default
>>>>> scheduler?
>>>> Ok I think I can create a function to assign a scheduler to the cpupoo=
l0 after its creation,
>>>> I would need to test it to be sure I don=E2=80=99t find something stra=
nge.
>>>>>=20
>>>>> My suggestion would be:
>>>>>=20
>>>>> - make cpupool-id optional
>>>>> - assign automatically cpupool-ids starting from 0
>>>>>    - respect cpupool-ids chosen by the user
>>>> Ok, it would start from 1 because cpupool0 always exists
>>>>> - if some CPUs are left out (not specified in any pool) add an extra =
cpupool
>>>>>    - the extra cpupool doesn't have to be cpupool-id =3D=3D 0, it cou=
ld be
>>>>>      cpupool-id =3D=3D n
>>>>>    - the extra cpupool uses the default scheduler
>>>> I gave all the unassigned cpus to cpupool0 to reflect the current beha=
viour, so that
>>>> a user that doesn=E2=80=99t specify any xen,cpupool node ends up in a =
system reflecting the
>>>> current behaviour as the feature is not enabled.
>>>> However I can say, if no xen,cpupool nodes are found then assign cpus =
to cpupool0,
>>>> else assign them to a new cpupool and...
>>>>>=20
>>>>> If the user created cpupools in device tree covering all CPUs and als=
o
>>>>> specified all cpupool-ids everywhere, and none of them are 0 (no cpup=
ool
>>>>> in the system is cpupool0) then panic. (Assuming that cpupool0 is
>>>>> required.)
>>>> =E2=80=A6 panic if cpupool0 has no cpus.
>>>=20
>>> Today cpu 0 is always member of cpupool0, and changing that might be
>>> hard.
>> Oh, are you sure? I did some test in the past for this serie using a Jun=
o board,
>> giving to cpupool0 only a72 cores and the a53 cores in another cpupool, =
my Juno
>> firmware configuration makes Xen having the boot cpu (cpu 0) to be one o=
f the a53
>> and it was working fine. But it was long time ago so I would need to try=
 it again.
>=20
> Maybe on Arm the restrictions are less problematic, but I wouldn't bet
> that all operations (like moving cpus between cpupools, cpu hotplug,
> destroying cpupools, shutdown of the host, ...) are working in a sane
> way.

Hi Juergen, Dario,

I will try to check the cases you list (on arm because I don=E2=80=99t have=
 an x86 setup),
I spotted in the code some places where the cpu0 can be hardcoded but I wou=
ld
need a feedback from you (and Dario, I know he worked around that area too)
since the scheduler code is very complex.

While I see cpu0 is hardcoded in these places:

cpu_schedule_up
scheduler_init

I can=E2=80=99t see the relation with cpupool0.

However here:

#ifdef CONFIG_X86
void __init sched_setup_dom0_vcpus(struct domain *d)
[=E2=80=A6]

I see something that I=E2=80=99m not able to test, could you confirm if tha=
t code would
lead to problems if cpu0 is not in cpupool0, since Dom0 is attached to that=
 pool?

Thank you very much for every feedback you can provide.

Cheers,
Luca

>=20
>=20
> Juergen
> <OpenPGP_0xB0DE9DD628BF132F.asc>



From xen-devel-bounces@lists.xenproject.org Thu Feb 17 09:04:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 17 Feb 2022 09:04:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274527.470026 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKcht-0002sn-HK; Thu, 17 Feb 2022 09:04:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274527.470026; Thu, 17 Feb 2022 09:04:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKcht-0002sg-E7; Thu, 17 Feb 2022 09:04:09 +0000
Received: by outflank-mailman (input) for mailman id 274527;
 Thu, 17 Feb 2022 09:04:08 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=xzkl=TA=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nKchs-0002sY-9X
 for xen-devel@lists.xenproject.org; Thu, 17 Feb 2022 09:04:08 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8e79133f-8fd0-11ec-b215-9bbe72dcb22c;
 Thu, 17 Feb 2022 10:04:05 +0100 (CET)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2053.outbound.protection.outlook.com [104.47.6.53]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-6-UpD1vrqUP72qn4x2KIL0nw-1; Thu, 17 Feb 2022 10:04:05 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM7PR04MB7192.eurprd04.prod.outlook.com (2603:10a6:20b:11e::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.16; Thu, 17 Feb
 2022 09:04:04 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4995.016; Thu, 17 Feb 2022
 09:04:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8e79133f-8fd0-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645088646;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=9SOUwmz1sKb7ItPssG1li6njxqm6lI8NiffXi7IzS2A=;
	b=ArOpiii6U4N0o+7N5n2e05+aCd8wikZF/rNWHN72L235mqXN72+PElN83LuGdxnQQSSL2k
	0puAdnueVgNBN0JvIS11vb6pHF2j6sJf8WN37ysBiYM+COb3RoA9b/a8iQ6bm7FDsd4vqa
	TtKP1uAFkZxl76X3FYMtD1Z4kaaRpSs=
X-MC-Unique: UpD1vrqUP72qn4x2KIL0nw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=DGgaN/AtwtSJTI9afis4B0q3Y/2NGCUxWiv+TyvxqGfAFyzw8exZccDrRd7ZVdktUMqDemr/iw46QqIjfrbTYinK9GR+Vf6ECt06kM90UsHlGu9hHwI52IlBjXmxmsUWOl2gK1RmkNCJrfplQ0Drv/tU6DaL3OLTEySpzRLvJhcQMC3ElZSnrXXWxQHIynI8fheZ236ZbfvEQsGYK3y7nrU/RvVOjqE5fSu1WgrS7yoS6NsTGXJGrbCw/RBkom/+1+JsamzuV/QSyCqIBTpkDsFvCadyufO7GlbXaYNmviCvStFv1hhE5iMKHuFc4O6ni/xb/n7c8CriStvuJoTUvw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=QEjLKlgDrHQLTdfmcBcuuF+HC2FjTqBwkMW2qXBOUnA=;
 b=GYub6zLE8RLgr8GiJ1gGuTCRzDIWS1PDcLCXbosaP06ueewaMv/ESgVTwD6iVWxTkwZPJfs4wLbFAqzIoLqmVcSGU5GalDjK2U+gTTQh2eOZo8uA7qPkdv+o9ThU9Vo5Qmv6jUjG5XhkO3ZV5FG8KKuOVteVKZutijiRZTGcgPaSpyxvusoTftav2RAKcC1J2mnmCUDwfaaBDBnE2pvJ4N6yUWBYCchdOEan8MDv03EcgXy3EUdL6C340ZltGEpxtrwAf0AD0PChltaWu+HL1OcGQ/r9MUYipSS7i+zTHvq4Do7d6GwV/qwhMaDWoc4CTDNzQp1VXEe/0ABaCwwysQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <536a357b-b895-7fe6-f99d-e83f5ac44745@suse.com>
Date: Thu, 17 Feb 2022 10:04:01 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v2 1/3] x86/retpoline: rename retpoline Kconfig check to
 include GCC prefix
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: Roger Pau Monne <roger.pau@citrix.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220216162142.15384-1-roger.pau@citrix.com>
 <20220216162142.15384-2-roger.pau@citrix.com>
 <7e5f721c-9771-bf35-8b94-f7fec7cd6eeb@suse.com>
In-Reply-To: <7e5f721c-9771-bf35-8b94-f7fec7cd6eeb@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM5PR0701CA0014.eurprd07.prod.outlook.com
 (2603:10a6:203:51::24) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 1e0e5ccf-e795-4ef1-8555-08d9f1f47227
X-MS-TrafficTypeDiagnostic: AM7PR04MB7192:EE_
X-Microsoft-Antispam-PRVS:
	<AM7PR04MB7192812996AAA3D92D1517DFB3369@AM7PR04MB7192.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	2tfujPm3buYpDAZuGP72QmKmTzCU658qt5Q4mtkB4n9ybY1facUdVFW/tmmK1urTkuGC6zQLhoiaOH94stX0l+6yWtN5uijgW6TwmD1k0+FqWePPXl5NSg06z6TtWj2QwRVvzUu+kvxk5n0TdnOUqf2I9ypzrXmrjGxj6oWn5Lr4KXmav9DzF3wq0c7LNWqclpPKqw0ngJ0EdciplVfLeKW152QMof0t3wkmG03ATbe0TR1JDKSi9cqC30KNT2DT0z2r3+rhbXNjKKe6WgsS4UsR+IGU2LAcQ2FgBaEIMnqnL4fMcp7tF7RjBya5HLXDIYzdsJm3wQ3sNQWJ/i6bnNo0HJCA7NzdXHDvFIgIn+YbPq3LA7LuIJtErCJOGBxFzh49EWazgY+Vo5d6fwFKrNcilpFwKPL+Sx4Vf/235CkcDs9NbEjYQtvRBfJaJ0R3FVUKI9WMAMiG5dOQ9iemF3wBe1+UZJ8IZeeJS2MOg61L4bhH/Z4oJHi0LLjK0ovHYo/Kjs3+kdRVfPpKccLldTRTx9+KDhjiSdKjxha9+DN5VbbRYQqMq89t+EAgYgbbtg6BoD1ncY1Pulmx6U+z1UYxHbMYDT0tBBbUKcuWx+DWoHl8q0YYxs1/WaCfng7xfgYTwJG/0+mgKnzCkm0LJH8LALMNiQDs16gkBjq5HRzjqkVLMfRaZB+EOkktCj3DYcAAcBKo3XwqGLaOtwln/rxJBQYoDkte3XuJV4VW/XMKsOmQVmevfdVZoAIE/5uu
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(186003)(2616005)(36756003)(2906002)(6486002)(6666004)(31686004)(508600001)(8936002)(66556008)(66476007)(5660300002)(38100700002)(8676002)(4326008)(66946007)(86362001)(31696002)(53546011)(26005)(6512007)(6506007)(6916009)(316002)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?K018fq9kuJrBc7PqPt+q8/QAZHBxVD+uaNq1ZQ6V+X2Ys7zi5uVJ/LJ11LUx?=
 =?us-ascii?Q?J18byCnrH1IegXZIYQ3yqZCr6iLMo3BiYpkTKM+H4VREYuI7nPc8V/8I8l5T?=
 =?us-ascii?Q?p+XWFqB5Ms+VgW32noYhCEKAXr977Co0SA4HMoFrpUBFUaCmiyatGuGq66Mb?=
 =?us-ascii?Q?AoSjP0+axjriN6Fg1UX8WRG7DuUfHNj/95IOc6nuUJ2v+Kfl0ybSiyy16kvl?=
 =?us-ascii?Q?8YhkAq+IxDl4TFEysbZEyFuWfLJtDVpId4EKZxwyAV99WypY9xj7wNfjCpti?=
 =?us-ascii?Q?JcMcjdq5tZNlQkMCNQJRT3WY7HsWeB2lUlhsDctIJ0z8SCUaGsUkrvlfIQfW?=
 =?us-ascii?Q?Tvvkdb2e7hVF2sqY7BBw5AbEZ8jhzYOM6XXqOZBHE7lBofNpgxrVEYnwWUF8?=
 =?us-ascii?Q?jI/tKmXQuOBy2kekl0aMDxAJ11FEjLBDRlnxB7+u0s2BgoEnseRRZKFJk9zH?=
 =?us-ascii?Q?bfjmXI1pVZ6Jc1rq5UYbRdgrPsIyRNOIccZgqI8AZXI+UcQFOMsTAOlc7tzQ?=
 =?us-ascii?Q?6brGrFx0ST/CwiyZIezkUhvbm4XWcCBJIqEhhNt5F96STG5fNsE6sJl6AmnE?=
 =?us-ascii?Q?o8zRwDqaLoELUBt29y9rDm51j3RAXqUUaqNfUY8zxW5CY5Li34j0gDbsoDWr?=
 =?us-ascii?Q?N8FW6kdN05x6BTKzESrCU2uzuQoERtNV2yZPvI9/ecgfY1jWAazFCBhQw0lt?=
 =?us-ascii?Q?idCBEFuAcWd2bWtzKPAKtZ4nQzXHUJ4yT95KbATK3WT0ulsb3krnZepUTVv0?=
 =?us-ascii?Q?W1al7D7gXCnGpkEfhxwKAhbKwJcDzwhPhO3a4zlAi+/YjHMbVnLdeZOMZ5Pn?=
 =?us-ascii?Q?v003llHLMrUU50DTJBPjn/FJHGmY03+x58pVZwiKh9Tr3NYo0ls9IAbjoUEb?=
 =?us-ascii?Q?LHZSTTPPNJBzrP4zDE+IoY2/vS/W5Xq9Z9tLHQMGJOsUNkERDbyWu66Bk03Z?=
 =?us-ascii?Q?jcUB7gbHR5qzx7rhkWKPrz4fIGTTEXjhziovGN/80BdzOy1ZgHVIl8gNy99U?=
 =?us-ascii?Q?E21LGqu1GXpdGON6jtB7xw1iFUZMso1gzv5Gy6SyU7nAuGo64FJ2xwMkCdfz?=
 =?us-ascii?Q?R7KPbcfr2PHB4zaYGyJT/sNCQXcylLSUfgc062kh2mUCqo9xWjr1oEosfOrn?=
 =?us-ascii?Q?Bt/V04BpZDEM2UhT/lheeWz8bXbEndczcvbrYIGDqmcYQnCux/MvR/DseGGB?=
 =?us-ascii?Q?yTdQTl2UyVtCMCieItDJb+3TSqj7ZwssM05B9GqZYu+dsuuevRHKGJsrRzFB?=
 =?us-ascii?Q?vWd1XxGxguvH5HR0JK9H8dBmC8T+AhtEC35Gqj9OQUZyIjR2EdCpyyBAkdh9?=
 =?us-ascii?Q?KI0gFGIJlUFdvOYXsvV6Md9EEDNf48Lpo/6SLFax12qf4MZL7WSfcGcIN+0p?=
 =?us-ascii?Q?LbnK3Z9HpHhRGmhocRt7fo2aqs+4p49GgS4Pidv/xcGTN5qpuQzOJZSH1fWL?=
 =?us-ascii?Q?9y3XX+Of0muXXL/whPD2X7O23n5fOV0NDz/LXetOtNxeFgsi8Tn9Jt5yy5bY?=
 =?us-ascii?Q?rYFzjGtx9e9O26lPsR1UOsaUptA4qg+Dpxfyj2mfB4YG8FngdAt3Rzacuz33?=
 =?us-ascii?Q?LAJ0xjfoHUgqUI9w9vaceVyPErwfRSOHCw5dl3HLHV2YniuNmh4Rpw+PEYEC?=
 =?us-ascii?Q?7ZdilgkQDw8o9FXU+pgG7MA=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1e0e5ccf-e795-4ef1-8555-08d9f1f47227
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2022 09:04:04.0705
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CV+K1dO13FJMGe5ZfeD9l/URDClFgY/lVwE/LEWZD1dJFjmMAibIwCkD5DQ1A+Dw3SonmKBNfcfcFyjT5RVmSw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB7192

On 17.02.2022 09:59, Jan Beulich wrote:
> On 16.02.2022 17:21, Roger Pau Monne wrote:
>> Current retpoline checks apply to GCC only, so make it obvious by
>> prefixing the Kconfig option with GCC. Keep the previous option as a
>> way to signal generic retpoline support regardless of the underlying
>> compiler.
>>
>> No functional change intended.
>>
>> Signed-off-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>
>> Reviewed-by: Jan Beulich <jbeulich@suse.com>
>> ---
>> Changes since v1:
>>  - Put def_bool before depend on.
>=20
> Just for the record: A slightly shorter alternative would have been ...
>=20
>> --- a/xen/arch/x86/Kconfig
>> +++ b/xen/arch/x86/Kconfig
>> @@ -32,9 +32,13 @@ config ARCH_DEFCONFIG
>>  	string
>>  	default "arch/x86/configs/x86_64_defconfig"
>> =20
>> -config INDIRECT_THUNK
>> +config GCC_INDIRECT_THUNK
>>  	def_bool $(cc-option,-mindirect-branch-register)
>> =20
>> +config INDIRECT_THUNK
>> +	def_bool y
>> +	depends on GCC_INDIRECT_THUNK
>=20
> config INDIRECT_THUNK
> 	bool
>=20
> config GCC_INDIRECT_THUNK
> 	def_bool $(cc-option,-mindirect-branch-register)
> 	select INDIRECT_THUNK

Oh, looking at patch 3 again (which I should have still had in mind)
this would of course not help. Yet ..

> A more appropriate thing to use for "depends on" might have been
> CC_IS_GCC. With the next patch in mind this would then avoid
> potential confusion if e.g. Clang folks decided to (also) support
> the gcc style command line options.

... adding this dependency (and a respective one in patch 2) might
still be a good thing.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Feb 17 09:05:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 17 Feb 2022 09:05:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274534.470036 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKcjE-0003U8-Sv; Thu, 17 Feb 2022 09:05:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274534.470036; Thu, 17 Feb 2022 09:05:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKcjE-0003U1-PX; Thu, 17 Feb 2022 09:05:32 +0000
Received: by outflank-mailman (input) for mailman id 274534;
 Thu, 17 Feb 2022 09:05:31 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nKcjD-0003Tp-Fk; Thu, 17 Feb 2022 09:05:31 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nKcjD-0000M5-AT; Thu, 17 Feb 2022 09:05:31 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nKcjD-0000Bt-0J; Thu, 17 Feb 2022 09:05:31 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nKcjC-00027y-W8; Thu, 17 Feb 2022 09:05:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=TW7djR2UDAPA2wMT6hLxDoNCGUqkx8/kUzwxymbKT/w=; b=WWItloxOWL6wsKHLSAaAd40QMb
	slpJFRTwGE03ApCBE8CKVRZgMVyAlB4CrGfspr2nbfWf/1ggu+9lAIJfyVlNxViDAmqdW9hBaEzhy
	1lyRH61OZC+pe7bfc4M1tValgM6mVDFBhraH5bbMD0PN85X6YFF2j1kmadEKClvdoZLo=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168135-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.15-testing test] 168135: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-4.15-testing:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-4.15-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=084bf6b19a7645e05878afcba88373534b06bb18
X-Osstest-Versions-That:
    xen=1ec097c35c4f402d7a3fbb05c2b9797afdc3f59c
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 17 Feb 2022 09:05:30 +0000

flight 168135 xen-4.15-testing real [real]
flight 168148 xen-4.15-testing real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/168135/
http://logs.test-lab.xenproject.org/osstest/logs/168148/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 168148-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168062
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168062
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168062
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168062
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168062
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168062
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168062
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168062
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168062
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168062
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168062
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168062
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  084bf6b19a7645e05878afcba88373534b06bb18
baseline version:
 xen                  1ec097c35c4f402d7a3fbb05c2b9797afdc3f59c

Last test of basis   168062  2022-02-08 18:37:46 Z    8 days
Testing same since   168135  2022-02-16 15:11:54 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Anthony PERARD <anthony.perard@citrix.com>
  Dario Faggioli <dfaggioli@suse.com>
  Ian Jackson <iwj@xenproject.org>
  James Dingwall <james-xen@dingwall.me.uk>
  James Fehlig <jfehlig@suse.com>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Kevin Stefanov <kevin.stefanov@citrix.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   1ec097c35c..084bf6b19a  084bf6b19a7645e05878afcba88373534b06bb18 -> stable-4.15


From xen-devel-bounces@lists.xenproject.org Thu Feb 17 09:07:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 17 Feb 2022 09:07:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274549.470047 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKclH-0004Cg-Fk; Thu, 17 Feb 2022 09:07:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274549.470047; Thu, 17 Feb 2022 09:07:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKclH-0004CZ-Ca; Thu, 17 Feb 2022 09:07:39 +0000
Received: by outflank-mailman (input) for mailman id 274549;
 Thu, 17 Feb 2022 09:07:38 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=xzkl=TA=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nKclG-0004CT-ON
 for xen-devel@lists.xenproject.org; Thu, 17 Feb 2022 09:07:38 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0d4aad8b-8fd1-11ec-8eb8-a37418f5ba1a;
 Thu, 17 Feb 2022 10:07:37 +0100 (CET)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2050.outbound.protection.outlook.com [104.47.12.50]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-12-i3SFe0FyM_KYYRiD4UznMQ-1; Thu, 17 Feb 2022 10:07:36 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DB8PR04MB6523.eurprd04.prod.outlook.com (2603:10a6:10:10f::26)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.17; Thu, 17 Feb
 2022 09:07:35 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4995.016; Thu, 17 Feb 2022
 09:07:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0d4aad8b-8fd1-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645088857;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=qxR+U81+Bws88LV73ylkbssUV3f2VX9Dxi1UEzAImpM=;
	b=ak3haw/vH1p3b3n6+0tzhKU7khytfGvtaTQxVEgzCrk9K9/1h1qEznA7ZcIAJ6Khcq87k6
	zaE/O9xI1faqpbfPTl80O+I+3kW6H+QkbxGiFyPPGDTFlSpVRau9li2eATz/Ij4oXG54IK
	99LHsnRSoAHjpy56VXfNEJ5Zdy7SOGw=
X-MC-Unique: i3SFe0FyM_KYYRiD4UznMQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=mjfnYvqna72/HdXYEDsZy16Z7H8AA3lWlGvKenld8wymHpAB8kbug3kvkIqBTFXbLii6MIVO1j2a8sL3eFsoFtE/0JgoHHAPbYX1skJplRWpDOIx+yvUuAJsecmSMYyoZLZvXOOx6zF8MbDvGe0lmL1vqMBayu84e2vK/egCDtdifMRNIkW3ur3oSv2BmgyS3CU5kSNSUvormwk0iFD72Df+2UdJQHRX30CcseU8yGUaXN5jtlVHc6D2k1EnuUPpZbDNIyiVJmFJyUkJXvVhhSTNpOm2ZpE/Ipfa4/ycKqiaa6yPDN+HJFJby7bXOG556ydxdaR87UoIRwsiHSKZGg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ktT5ySOkV2vsUa2J2WMDpKrja6GG5Cten5+0rHeuU1A=;
 b=e4BAZCiAfbmsUvB6QXP8hgFsynkfR/l0m+FI/vqOOLRV0OVoZdhGGtYajT18YMoT2xESy68BTlSAon5COcxHkHMxeLPibGAkPIB2i09H85vZ9kDKgGHJC6Hw3bUCN/Wzf2LEJnZcFY4ReMeTMC82z7/Dy5ILXxob/sMIwsZrq0wDngsSjt+rlshwbSfTX6CZUAPxTZjU5ZnXVtgE7h3/CSJx8LX7zxyryosyiifH+UdKgl0uXFZe40bwpAtk7Lr27va6ezzb0d8klQ0LB2FwF8QW3CWkcysPv7fYS/Gh9RL+A3sFtPrjK5I2Wkziu6O9vTc8SC5jQLMK+XMEF8T5MQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <b6dc1214-4f1d-f7df-50c4-d357a2380b30@suse.com>
Date: Thu, 17 Feb 2022 10:07:32 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v2 3/3] x86/Kconfig: introduce option to select retpoline
 usage
Content-Language: en-US
To: Roger Pau Monne <roger.pau@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 George Dunlap <george.dunlap@citrix.com>, xen-devel@lists.xenproject.org
References: <20220216162142.15384-1-roger.pau@citrix.com>
 <20220216162142.15384-4-roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220216162142.15384-4-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6PR0202CA0060.eurprd02.prod.outlook.com
 (2603:10a6:20b:3a::37) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 6c89ca2d-cd6f-4572-408a-08d9f1f4efbc
X-MS-TrafficTypeDiagnostic: DB8PR04MB6523:EE_
X-Microsoft-Antispam-PRVS:
	<DB8PR04MB652307C24BE4DB1474FBD405B3369@DB8PR04MB6523.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3173;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	MQMVsWUbYsSea1TApuD+agfnsr0ahZWHIrjKZQzh2X4uItf2TYGe2o+yYmjw5a6SR8EeQPxtT8av0tP/L5rht+ToPHMJ4gu8Tlj7RUW5hPSCwp6R8TXyDEaXMR9aNY26hGbCfoegltGSGJ1kKCaSX/QWgGlnpibHU8VOiO9DDMPlSJW7+yDW8ZtxriXW9c663PXobEXWvZDGZAAepo39mNXZDX8EzFQcOBcHUPkLlppP7FqWgXQ5mD3U32jORWXp22WXHNwj2f5cCQUcDGMi+8zFgUSRGNWSnDCzlwp871/5Q9MrN0HydGVba68Nx+clCcevcNNG0PU5aM0CiEEjyN4DC6PlG7JnzE02rmPMgQPj/3u+ZmJpOtiZldSD8pFufWQGNXBommf7TfHvLhnjBM0VeP+85g5MqL/5GU70sTuP062ZRIWAHWXcrpAy227VV7kD+JHaVhyCbVtyFf25ZaAIOXEhLor/Gr5I/twS7h8M8GCO6T0IX4RIGaNjkKNu29HtgXqUG9TDEX4wIs4GThg57MuVOEEJhF/LllhQ92KmpragNAEFibJk44JQL4jrgTGy8hEEzS09D5/Jw6gPAouulcTqFTcvm7HRdp/229ipQ3IuaX/9PN92/j9DiJtZbjVurpfhRk2rbUpCOMdoe3AhNm0cnSz1Jw84I/F+cIh/DseqJ7zL3znynq6RuCUwsQ65Td1C5IeIcJJ9GI5uNkGE/nUcakHvv6X0Ury9LMWn6qV1h70Cp8yWVyKhT5sX
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(83380400001)(66556008)(110136005)(54906003)(2616005)(4326008)(8676002)(66946007)(86362001)(53546011)(316002)(66476007)(31696002)(6512007)(6506007)(5660300002)(36756003)(31686004)(508600001)(6486002)(186003)(26005)(38100700002)(2906002)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?+D01LgujGN3Ywbg5Ou8jgmReo91dVKKxYkDeWG16k7bapHg3YgeOTOZnWPpB?=
 =?us-ascii?Q?dpuFal7kJ2pwipYITWz53IkRceFYSE1D9jVHCREmStIliyo2hLVPJonJF8kO?=
 =?us-ascii?Q?wobZhA1Id36ZdPiKM3a9QKGDGYzpuadELrdwujMFCFd0YPpZLseTERMSiC1K?=
 =?us-ascii?Q?5+BwMN8uPKJVwAAfFsv3JFCmTv1TZAWFYjXzjXHkxdLqx6EHHjcK6M5BqIbe?=
 =?us-ascii?Q?y5ziIiMUVKL+7pob7yZgKqcrUZmc9RDddtLygUqgVnbrzAKeZhw3utdessAy?=
 =?us-ascii?Q?rQhG5Vy5Ne+HBwNRXafcxNt3e/CgIpm+t+FV3OJ+AMatinJ7YaKn7ZrPiA1n?=
 =?us-ascii?Q?y3SJgo9S65NasSM0ybCtndZ12PYZySdq7Ehe/fJkHnMsCROz2NVH7WQRU3/w?=
 =?us-ascii?Q?ue/qwcfF8qSHZffrVfgSRBtmh4T3uRlMBu/1RWsF0wj2mCqpQVj2ah094YNC?=
 =?us-ascii?Q?82pHYOHgMVQy6t1WFOTAhFRK000oLyy4jo8HT0+CSMfhhu6G/hUVtfNdxJSk?=
 =?us-ascii?Q?iElfyKFbpbMPHFDdWHA3IGVxe7BjUJNO1JgU+DV4c4JROlWLuTdTG99oTKeB?=
 =?us-ascii?Q?w6LAyuax2jgx1pm/gMgNPmfJavmxD8WoG6ypt9IqT225vYTbjD27IpRnmVgq?=
 =?us-ascii?Q?KhQ+S9QALODoWNFqNi9I9ooIFuYO9kXtG+UOYkS1vVd5FnwUMgEfJu1pU+XT?=
 =?us-ascii?Q?SXZ+Jl+eSSOUK1FRoHm2n2duJxVw8qUMXQsM0INsnqQYuy4KwREI3xfUXPPU?=
 =?us-ascii?Q?lpFXwu4Hlommc84A96IbJWehL+x9fCyg11UtR/1VUM0ydg4UO87RJ161pvEv?=
 =?us-ascii?Q?pVOvEDKSBuTU/3M4VR371mHSP1sauQ3PD4qlzhu+f7LlOln2KXSmeqH0AEuE?=
 =?us-ascii?Q?4MVR/HZNBHb7uHWfZxo/exIKuntOYO0p5QLNcu7I9vVqGGXKvkZPnSaEMSkX?=
 =?us-ascii?Q?7XtwkWSXyo9N7qPJMs8Fx0FBUr1nit1vZvJ9OTXGJtlVjHA/bdenFAsM2xvp?=
 =?us-ascii?Q?1uwe4x6X3ypb+iZchSLIgfedgSIHVdxUS9+5EhwnKolFIl+THcw4IMFaCZ1a?=
 =?us-ascii?Q?X60ZTuSB02mUAJhlAHZPbjvV+N9h+vNg+M8tO14dgcjCLd1+TSsZEc94vHsY?=
 =?us-ascii?Q?0axFwnudO3FNAiZbM0rqb8+xIq9ZL1mXJC4XAaTDEOyHyP6pUby6X1Ai58XY?=
 =?us-ascii?Q?vLvVSXZdJ8VTU8cXEjRfeXcCTPNcSSjjxUhLZd5CgZJTHY5WePPeJjeA+RZV?=
 =?us-ascii?Q?MBWxcbVDnsp2xilYbmA0DYEnw1xwNK2w+prIhyWzsJOiaTc3yIu0eusQ9lnE?=
 =?us-ascii?Q?OiW/QrbyBfUSEyeWGAvEv1Q4sO8mbeLW1OrVzE4KKUz/cChzsG7fWMWeLusV?=
 =?us-ascii?Q?kIqIbql8YmX0qpdM9pyoV/UxwCI/aPNQ5MnngYqOcHpipBUSqGGyuxICat32?=
 =?us-ascii?Q?xFScreDiJ3pJp7wWZPfSJy/NVhMoxrZwijxnggj42ZNvgOyLDyutX9qYiC7K?=
 =?us-ascii?Q?DiEaBHk4n9ANs1ZaDfgflkwRk+dNq3g6ap+Cgb5/1kKyTEwjnXmXk89+5YvS?=
 =?us-ascii?Q?NsLErzC01I0NXSHn9AFhweZ22QcZStuy0Daw9tABTm/yhocprbnhpQ5lOG8O?=
 =?us-ascii?Q?1iHUUZ8bzIukgzLZZX/wkdI=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6c89ca2d-cd6f-4572-408a-08d9f1f4efbc
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2022 09:07:34.7604
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0SZUkzxq66LG5IzmSlErUSvN8M1pRKedN6FgRR565l2WNRgGdFwHKjEPSOhw8IP+uDebRqbIBo44eb4EPHtDUg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6523

On 16.02.2022 17:21, Roger Pau Monne wrote:
> Add a new Kconfig option under the "Speculative hardening" section
> that allows selecting whether to enable retpoline. This depends on the
> underlying compiler having retpoline support.
>=20
> Requested-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Signed-off-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>

There's one aspect though which I would like to see Arm maintainer
input on:

> --- a/xen/arch/x86/Kconfig
> +++ b/xen/arch/x86/Kconfig
> @@ -38,10 +38,6 @@ config GCC_INDIRECT_THUNK
>  config CLANG_INDIRECT_THUNK
>  	def_bool $(cc-option,-mretpoline-external-thunk)
> =20
> -config INDIRECT_THUNK
> -	def_bool y
> -	depends on GCC_INDIRECT_THUNK || CLANG_INDIRECT_THUNK

Moving this ...

> --- a/xen/common/Kconfig
> +++ b/xen/common/Kconfig
> @@ -146,6 +146,22 @@ config SPECULATIVE_HARDEN_GUEST_ACCESS
> =20
>  	  If unsure, say Y.
> =20
> +config INDIRECT_THUNK
> +	bool "Speculative Branch Target Injection Protection"
> +	depends on X86 && (GCC_INDIRECT_THUNK || CLANG_INDIRECT_THUNK)

... here despite being explicitly marked x86-specific looks a
little odd. Since the dependencies are x86-specific, dropping
X86 from here would make my slight concern go away.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Feb 17 09:24:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 17 Feb 2022 09:24:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274557.470059 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKd1f-0006Vk-V7; Thu, 17 Feb 2022 09:24:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274557.470059; Thu, 17 Feb 2022 09:24:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKd1f-0006Vd-RM; Thu, 17 Feb 2022 09:24:35 +0000
Received: by outflank-mailman (input) for mailman id 274557;
 Thu, 17 Feb 2022 09:24:35 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=A/h9=TA=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nKd1f-0006VX-41
 for xen-devel@lists.xenproject.org; Thu, 17 Feb 2022 09:24:35 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 69a210d4-8fd3-11ec-8eb8-a37418f5ba1a;
 Thu, 17 Feb 2022 10:24:33 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 69a210d4-8fd3-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645089873;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=5ZqwbG/uKxvFoi9E+cTOEe3zBec1/oYOl00/WlHlBRs=;
  b=PsZ9G3nCzKcHDpJqEWANYmYLurOxFCv8/gaumN546TuNgCxgYutCztOY
   TUd30l8G6XtVzI1uxrqD0cWlHvrNbaW56KHAgmE8/bdS+RdLfoTK4wQIz
   4u/Bhd1zZDsbZQWLoeckgzZZT12YIcI2SJm5c97LR0WnMiHD0Z3dANqdd
   8=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: Zk2iAw4KOQ3yfOBqBCopQdhixhb2qjFL1HED2mkgIZUUzyColS8LuWtJAZH4AcIaLxpcuZAhK7
 WIZKEacwa9g9tYHPrKSzYTTVel8vHLY72PmgA6DSPzde9hNsdxQm/jO5LImCSysIhugnCp0OKX
 1jeGos/ylriM3aLjaLkHwkXGCPl/njG/fkbL8A9kstpFQlGE99S/9jljQfc31VhG3oM8RycIbr
 0UTS5kj4RGwF0XxsS0GNHYYOl8CI0jopzFeQR4RJ9h/VlcHOceL9JuTKynkL4jlB+G+BIhdBu4
 1PvO2fPBDrkapYR3yIB/02sB
X-SBRS: 5.1
X-MesageID: 64820656
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:vdYaVaJb99DGLFcbFE+ROpIlxSXFcZb7ZxGr2PjKsXjdYENS0TdTm
 jBMXG3SOq2OZTT8f95wO4/kpBsPvcTSzNRqSFRlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokcxIn5BC5C5xZVG/fjgqoHUVaiUakideSc+EH170Ug6xLZg6mJVqYPR7z2l6
 IuaT/L3YDdJ6xYsWo7Dw/vewP/HlK2aVAIw5jTSV9gS1LPtvyB94KYkDbOwNxPFrrx8RYZWc
 QphIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbrGvaUXe345iXMfwZ3u7hB2pgs5t1
 sRpp6eialxwN5Dwlb0TYjNXRnQW0a1uoNcrIFC6uM2XiUbHb2Ht07NlC0Re0Y8wo7gtRzsUr
 LpBdW5LPkvra+GemdpXTsF2gcsuNo/zNZ43sXB81zDJS/0hRPgvRo2UuY8ChGlt2KiiG97FW
 5YCTiB1SS3mbjBtM04NV6A8xu6B0yyXnzpw9wvO+PtfD3Lo5BN1+KjgNpzSYNPibdVYmAOUq
 3zL+0z9AwoGL5qPxDyd6HWui+TT2yThV+o6Fre16/pri1273XEIBVsdUl7TifWmj1Hkc9NZJ
 VYd9icnoe417kPDczXmd0Tm+jje5EdaAocOVb1hgO2Q9kbKyyaEGHQaXxpTU84F75Y/eAAnj
 1G4tdy8UFSDr4apYX6a876Vqxa7Ni4UMXIOaEc4cOcV3zXwiNpt10ySF76PBIbw14SoQm+on
 1hmuQBj3+17sCId60msEbkraRqIr4OBcAM67x6/somNvlIgP97Ni2BFBDHmARd8wGSxEgjpU
 JsswZH2AAUy4XelznPlrAIlRuzB2hp9GGeA6WOD5rF4n9hXx1atfJpL/BZ1L1pzP8APdFfBO
 RGP5FsKu8EPYSD1MMebhr5d7exwksAM8vy/C5jpgidmOMAtJGdrAgk1DaJv44wduBd1yvxuU
 XtqWc2tEWwbGcxaIMmeHI8gPUsQ7nlmnwv7HMmjpzz+iOb2TCPFGN8tbQrVBshkvfzsnekg2
 4sGXyd8404EC7OWj+i+2dN7EG3m2lBgVMqp9ZIGLb/YSuekcUl4Y8LsLXoaU9UNt4xel/vS/
 2H7XUldyVHlgmbAJxnMYXdmAI4Dl74mxZ7iFSBzb1uuxVY5ZoOjsPUWe5ctJOF1/+1/1/9kC
 fICfpzYUPhITz3G/RUbbIX889M+JEj621rWMnr3eiU7cr5hWxfNpo3ucDzw+XRcFSGwr8Y//
 eGtj1uJXZoZSg1+J8/Kc/bznUiptH0QlbsqDUvFK9VeYmv2941uJ3Cjh/M7OZhUex7C2iGbx
 0CdBhJB/bvBpIo88d/og6GYrtj2T7siTxQCR2SCtOS4LyjX+Gan0LRsaufQcGCPTn7w9YWje
 f5Rk6P2PsoYkQsYqIF7Cbtqk/4zvoO9u79Aww14N3zXdFD3WKh4K3yL0MQT5K1AwrhV5Vm/V
 k6Vo4QIPLyIPIXuEUILJRpjZeOGjKlGlj7X5PUzAUP7+C4oo+bXDRQMZ0GB2H5HMb94EII52
 uNw6scZ5ju2hgcuLtvb3Dtf8H6BLyBYXqgq3n3A7FQHVub/Jol+XKHh
IronPort-HdrOrdr: A9a23:riGffar16ko49mgYV0BQefUaV5vJL9V00zEX/kB9WHVpm5Oj+P
 xGzc526farslsssREb+OxpOMG7MBThHLpOkPMs1NaZLXLbUQ6TQr2KgrGSoQEIdxeOk9K1kJ
 0QDpSWa+eAc2SS7/yKmTVQeuxIqLLskNHKuQ6d9QYUcegDUdAe0+4TMHf8LqQZfngjOXJvf6
 Dsmvav6gDQMUg/X4CePD0oTuLDr9rEmNbPZgMHPQcu7E2rgSmz4LD3PhCE1lNGOgk/i4sKwC
 zgqUjU96+ju/a0xlv10HLS1Y1fnJ/ExsFYDMKBp8AJInHHixquZq5mR7qe1QpF692H2RIPqp
 3hsh0gN8N85zf4eXy0mwLk303a3DMn+xbZuCilqEqmhfa8aCMxCsJHi44cWADe8VAcsNZ117
 8O936FtrJMZCmw0xjV1pztbVVHh0C0qX0tnao4lHpES7YTb7dXsMg24F5VKpEdByj3gbpXXN
 WGNPuspcq+TGnqL0ww5gJUsZ+RtzUIb1q7q3E5y4KoO2M8pgE686MarPZv6kvouqhNDqWs3N
 60QpiAoos+O/P+XZgNddvpfvHHeVAlYSi8Rl56cm6XXZ3uBRr22uzKCfMOlaWXRKA=
X-IronPort-AV: E=Sophos;i="5.88,375,1635220800"; 
   d="scan'208";a="64820656"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=KAQ5VSUFL/tdm9O/jaz3UtD/lVQWi84YRq2iQ61QZYMvzjSJRKbr4OQWwwNkxuY8gDHr1lwKgcUlpCmX2BRleIaTXokEQuZ8HkzoPbD6aQR0meb7UFapEYRQQql61VcDcsGa+lGZgfVoAMj8Zu+umzyC1oClDna9JkgA6eCrig7erdF8ApcqTVsbVnjFDl+BAtW2PGrbJ1pPVfekJ1N93Bqqfwn13A6s1LuVc2hVr3J2b52Ym325WHG3zsBJPKqsNb7WfFUFuFZ1+WZZbV3rRlEKJ4kSZboinvNG1RGhds0DavHXaDjb31umYzd0rCFCq8OxKw7GD0c+A66wanRdbQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=yeZVID7WEt1NNuALJjPNEUhUpiWtrNlfafwbYA/JAuI=;
 b=NKPwKK2fWzpRp3C1rhnMcYh1cO0BwzmtHqkmNIZ0xno+Ujz9car5gjOdnr+QLxd7BZihSnCcW6HNTCeZ3eBzON2AuVmJu/uKrZVl8JARuAY7XPTqX6ttFckQ/APRBHEg7IdTPofxot2UndJSjDgsd07MSP88+3JOFR66ln7AMSWQV3385nnOZMvEInAIdnzCcBMaUAl/dITmH82TosTunSKuSA+LkebKaROYC7GsFMHBsL0eZ2SCux7IpNOJPz8GhD/2I2x/FajGPfryKvvKhasuYoCKh6mxi4yoJ6Ej/1uGRDFrb9Bq+1vO9qc039HBovNpGz2Y9stM1D+b8oDhFg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=yeZVID7WEt1NNuALJjPNEUhUpiWtrNlfafwbYA/JAuI=;
 b=GB1uIHjowzMvBU+TYJ1K+AxAIWedK/rpv3mciKomPHQYnCEDhfZ+IlFS4I8S1h4PkI3Dt9+sR0BxAxCsB73q7D2P0f8LA3g5RifTbHod6BG8JQW9/TAONis/2jrXYfj/uj9bJXQk2BzQgAUR6WPxhgQfp7VhwuXWKzUWUz8UZlw=
Date: Thu, 17 Feb 2022 10:24:15 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: David Woodhouse <dwmw2@infradead.org>, Andrew Cooper
	<andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2 1/5] x86/cpuid: add CPUID flag for Extended
 Destination ID support
Message-ID: <Yg4UPzFk15tJGo0B@Air-de-Roger>
References: <20220216103026.11533-1-roger.pau@citrix.com>
 <20220216103026.11533-2-roger.pau@citrix.com>
 <979fbc26-925c-f58f-9c1a-9ccd72275c9b@suse.com>
 <fd22f7e19590b0e8679e5a3a15992bd1f8a92126.camel@infradead.org>
 <9b5a8474-0be2-b4e6-8919-7e22dde1570a@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <9b5a8474-0be2-b4e6-8919-7e22dde1570a@suse.com>
X-ClientProxiedBy: MR2P264CA0053.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:500:31::17) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9012f5e2-a9e5-40a1-f38f-08d9f1f746ed
X-MS-TrafficTypeDiagnostic: BN7PR03MB3970:EE_
X-Microsoft-Antispam-PRVS: <BN7PR03MB39708107FB869785C6CBC5A38F369@BN7PR03MB3970.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: l8hjyzp2qwO6AoptAyJvS7Om0h2+tzWIr8MT/d7ga2Wvko+pKj6tdgDaDhdj3jCJJ699icpT0A+et9OEmVm8ovEkmysPoDArF3wgW/R4rw9EY6HUW6tl24iw4hElkuA+PDAgAXGQ4TtY5RKHoVCMSsh4Kr+FSOYuP70dhqcHSu/6MWMytT4DvZ3a2natSDjLdmQxraY3XvRkx3uMwqTWfCjnw/g5us6EICcbq+WUm6KpKgtJbUlFK4CIVOw1nCZiL29ISFOfsNAwAOBj6ywoGZgpWHOE5HNYuQ/Vq0CbkZAewTB0FBBA8FVcgmzIr5mIVzhKbvwCIxD34rxcCuhEY4Ep5wCjfboo7Ox05KsR7shbXPWMF51Ek/bzPxJ4Jk1sq6aKHlDlH7KXUFPviQUfoznOpBntSj+jonHJ2gsmR+hw65/98O2posH6YTKlB5hhw3z+Pa5X/wPgw9S9N2m+376ShD7sokFWmaadrTQoRDoTFN0f+RwqzMeCarrGZeqVHCJrM9qwPfljqDkhGa4DVuxvf8ZmNev//V2HNPxMD1Dvrn4pN2FN1QLTzMXMpqMhcRY3ixBUsIUSyjj+2tngZQ88xfXx6CnDLiPSYRDRe4gSOsMobvRccuFp0IKQda4s4S48XSnrSfjncnCheog6YA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(508600001)(6512007)(8676002)(66946007)(4326008)(6506007)(66476007)(8936002)(86362001)(66556008)(9686003)(2906002)(53546011)(83380400001)(186003)(26005)(6666004)(5660300002)(82960400001)(38100700002)(54906003)(316002)(6486002)(6916009)(33716001)(85182001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RnFnMEtLL2NMdURZWTZsdHVYL3VNT1Y5ZTV2M256QnlGUVAwcjZIRmcveCtF?=
 =?utf-8?B?OWY2bGl1a0hRbWtXRUdYbWZzUlNHV3hBcTRxNUY4Y3Qzb0w4QlpQSzZqSmRQ?=
 =?utf-8?B?NElLZlVYdjFkdXVQMDkzWi9MRXpoVnVwcGNmT05WUGV4Yi9VS3QyTDBDL2pW?=
 =?utf-8?B?eDhPSXpCY2Nsb3E5QndXRjlQSE9DRFEwdVVUN0JkUGJtNHlYNXVCZFdjYjJW?=
 =?utf-8?B?c2VqUUkyc2tGTXhhTEJRNWtNVUcvbytUWHpadWh5K2dGL2RzaklvbkhOTTUz?=
 =?utf-8?B?eFRsM01USVhoQTZDRVl0Z1YwYjZyaUNxN2hadlBUNUcybE9mNU5MbWNML2t2?=
 =?utf-8?B?UlYxZUpWTnFmMjNlaVdpVTcwTDNyRHNKMmtCem5BWUgzWUhYbmxpcGR0YmpZ?=
 =?utf-8?B?ZUN3NUlPcDduVDNDZVlET2NIZGQxdTBJNnAwaWJqSzJJOUd1Tm5EbVdKTGdK?=
 =?utf-8?B?MDZ1S0RzNVdBZEVydk1NNkZSV1dEVVE5TGdRS1ZzYWI0eWZoeGtBWTN2bUJE?=
 =?utf-8?B?aUVIK0xzelE3RzE0K25TV09nekM3NGZPWGxjbmlEVDBLZnBIYUVRSUQzNUh0?=
 =?utf-8?B?ZEV5eFdHQ3NPWVNid2dvYlhTZUxnNVJ2WmUyZTJhR3dNM1VkVzF0WldRdUVB?=
 =?utf-8?B?RVd0V3JJUkpBQktQM3RYSjVYTHNvSWFoZmdxZmg2WWJ0eWFQKzBNU1REMlh0?=
 =?utf-8?B?RlUrN0YxYld3cjQxcTg4UkE4LzQycUxqaVpqVmEvL21RL0hMQjJDeGZBTjVv?=
 =?utf-8?B?MGZvdmN6WmdyOU9aVjJOWjl5UlB1aGRTRlFWSmFDdWZ5OGxSUndQMjZ5RWVQ?=
 =?utf-8?B?TENSSGVSQ2oxUUI2MFcwTjBLNW12aUZNU1hEam1XQTlMSUdVaTA4cnRyUUx0?=
 =?utf-8?B?c2NOTmZ0eEdPRDR1KytlVXM2OEZhUWlDZlZURHZaNnNqMnJkRnZHdm1JaDJl?=
 =?utf-8?B?UFJJdHpJalAwV2xIb1c1MWZCaG9ZN1lSeGV5SHA0ajl5dVRHdm1JQjNZaFhD?=
 =?utf-8?B?WVdwRS9ldXhXRmcwNWp6alJnMzF3a1RFMGtlK0E2Rnl3dWE3eVp3a2FIakFZ?=
 =?utf-8?B?emhkZFB1c1VnNW5NbnI0S0xJWE9QdytTR1pmZTFGL3E2Y1dwblRoN1ZvU3ps?=
 =?utf-8?B?b2l6bnl6U2w4UHB0Q2ZNWlkxOXRwWkJzSG9TemZsYUFVOHRsQjFRNWppV0Fl?=
 =?utf-8?B?V01Sb2xUeWdtR1lqS2lpZ1YwRXo0ZXc4anV0STQxcmdnVFk4c3lvSm5NWGkr?=
 =?utf-8?B?RWVkc2RYcTZLR3NRVUZ5aUFjaS9kclAvWDh4eUJYK2RQWW1MeHRMemUyaHM1?=
 =?utf-8?B?NFVuOEFMWE5GaEU5cDNRYlNYVzBheDNGTExmejM1U0hPUUxLblVMVjhRUUc3?=
 =?utf-8?B?Qm1mbnRpTmFXdGxUMjdTOEcyNnJqVHdQVVEzTnJyTTQycnlpOVAyVXJQRmlq?=
 =?utf-8?B?cGg0cWtWZktKNFpCQUJuUlBkZlVDeitOcEpUa3d3aGF0QVpCbnZTQ1JDWmZU?=
 =?utf-8?B?SGQvcUNiM2hzMXJZRlU2TWdBWlp5Q2dZcGNCaStPK1RUMlNZMHJGR2Zna09l?=
 =?utf-8?B?bi8wY2Y4YUhqUGgrYUw3ZkVjaDlac21MYXFvUm5VQ2V2OGZVMVRnK05VeDNv?=
 =?utf-8?B?bXEySy9oeVhuVng2TkJSazB2NGpwVUJvMEd4QjdkOVloaU5JYVRPbmxkTWhN?=
 =?utf-8?B?NWwrSkNHaFlqb1RTMjBHeDkyR3NkV014WXRHV1JSRDE2aC8wcjFaZGtiVWFD?=
 =?utf-8?B?U1ZHRnJJUEtQZzlXQXVCckN5L3RRTlRPL1B3VDFKWjlJaFZrZmlRU1hOS3Vl?=
 =?utf-8?B?NUF5OEYwOVRrQ1ZZcGxtalJ0d3hFS2hmcUh6cko4VlZxaGVsZlpyUEVuL1dz?=
 =?utf-8?B?ZFBDNS9oS2pneVhGL091QkUxaFVYS1FnS0g2S2YyOHBHclVnamlzMVVaenFU?=
 =?utf-8?B?bkJwTnp5LytlNEVyL1owQWJwWGVYdS9KM2FZMUxzdzNUZTZDVzh3ZVJJNGJu?=
 =?utf-8?B?WXl4azA2VkRxOWhFQzFVbGVaVkptS2x2Z29WbWJRL05zZTZHdTUzSGg5a2du?=
 =?utf-8?B?b0NuYTVleFR1WVdmUTZhT0JxbU5QbFE1SlN3U0syZ2ZWNys4dHpIL0xabDBk?=
 =?utf-8?B?RzUxSFA2aktkYXcrQUhHVThCWjFJWm1HRDdzcGNxVDRCZmk3S2Y4d2JKazNa?=
 =?utf-8?Q?uR9YLk629dawke34EThizRU=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9012f5e2-a9e5-40a1-f38f-08d9f1f746ed
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2022 09:24:20.3706
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MFcjqktg9DyucVRUUNO5BgpkEF6OOiT2PHP7+QQ4xrOaBm2fwi6zHd6+aZXCDEHovayZOwlqJft9vxYt5niF/w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB3970
X-OriginatorOrg: citrix.com

On Thu, Feb 17, 2022 at 09:52:51AM +0100, Jan Beulich wrote:
> On 16.02.2022 17:08, David Woodhouse wrote:
> > On Wed, 2022-02-16 at 16:43 +0100, Jan Beulich wrote:
> >> On 16.02.2022 11:30, Roger Pau Monne wrote:
> >>> --- a/xen/include/public/arch-x86/cpuid.h
> >>> +++ b/xen/include/public/arch-x86/cpuid.h
> >>> @@ -102,6 +102,12 @@
> >>>  #define XEN_HVM_CPUID_IOMMU_MAPPINGS   (1u << 2)
> >>>  #define XEN_HVM_CPUID_VCPU_ID_PRESENT  (1u << 3) /* vcpu id is present in EBX */
> >>>  #define XEN_HVM_CPUID_DOMID_PRESENT    (1u << 4) /* domid is present in ECX */
> >>> +/*
> >>> + * Bits 55:49 from the IO-APIC RTE and bits 11:5 from the MSI address can be
> >>> + * used to store high bits for the Destination ID. This expands the Destination
> >>> + * ID field from 8 to 15 bits, allowing to target APIC IDs up 32768.
> >>> + */
> >>> +#define XEN_HVM_CPUID_EXT_DEST_ID      (1u << 5)
> >>
> >> Would the comment perhaps better include "in the absence of (guest
> >> visible) interrupt remapping", since otherwise the layout / meaning
> >> changes anyway? Apart from this I'd be fine with this going in
> >> ahead of the rest of this series.
> > 
> > No, this still works even if the guest has a vIOMMU with interrupt
> > remapping. The Compatibility Format and Remappable Format MSI messages
> > are distinct because the low bit of the Ext Dest ID is used to indicate
> > Remappable Format.
> 
> Well, yes, that was my point: With that bit set bits 55:49 / 11:5 change
> meaning.

Bits 55:49/11:5 become reserved again with the interrupt format bit
set to remappable.

> As an alternative to my initial proposal the comment could also
> state that bit 48 / 4 needs to be clear for this feature to take effect.

I've always assumed that setting the IF to remappable invalidates
extended destination ID, as the format of the interrupt is different
then and there's no destination ID anymore, just a handle field. Maybe
I could make it more explicit:

/*
 * With interrupt format set to 0 (non-remappable) bits 55:49 from the
 * IO-APIC RTE and bits 11:5 from the MSI address can be used to store
 * high bits for the Destination ID. This expands the Destination ID
 * field from 8 to 15 bits, allowing to target APIC IDs up 32768.
 */

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Thu Feb 17 09:48:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 17 Feb 2022 09:48:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274564.470070 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKdOT-0000V6-Qp; Thu, 17 Feb 2022 09:48:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274564.470070; Thu, 17 Feb 2022 09:48:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKdOT-0000Uz-N5; Thu, 17 Feb 2022 09:48:09 +0000
Received: by outflank-mailman (input) for mailman id 274564;
 Thu, 17 Feb 2022 09:48:08 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=xzkl=TA=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nKdOS-0000Ut-PB
 for xen-devel@lists.xenproject.org; Thu, 17 Feb 2022 09:48:08 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b390765b-8fd6-11ec-8eb8-a37418f5ba1a;
 Thu, 17 Feb 2022 10:48:06 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2175.outbound.protection.outlook.com [104.47.17.175]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-26--7-1J0u7MGK6UjpBK542lw-1; Thu, 17 Feb 2022 10:48:02 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DU2PR04MB8677.eurprd04.prod.outlook.com (2603:10a6:10:2dc::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Thu, 17 Feb
 2022 09:48:00 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4995.016; Thu, 17 Feb 2022
 09:48:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b390765b-8fd6-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645091283;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=/Fk8hG3xO+5URrFW6ecPKEd1mw8Tp+W0TolQORDmEG0=;
	b=E1BmQf/3KPBFpmQpAbRRuqoLLmasCXjSOANRwH5UEyDj4SkO7x+y/tqSjdvnf2q4yxmi/9
	8Rr3BHhIDUov1JhvO2T+2jvLYG7QAr8Y7d37Wim4i7ZhwFZ4ntiIRlN6T8ioFWo7P0OdN6
	ul4u4kcKT1QIbYfvj0brcp2oFk5VaRs=
X-MC-Unique: -7-1J0u7MGK6UjpBK542lw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=kfobEzO/J7fn22vL2JK+36+j8aO3qumHXfOxyechFVTeAo/GO6ZKgEPNZT2aF4tH5lLtmnzQz0KkwX6WPz93IsjoxPoOXurvGoQTz9ds+YCsCcQ+8b30+N0dhApSGFokYQaySW9EZjvppBsnEL9OSpI0biQWhkKTMSLinWyVusRwety9KUcqsV7PgxFG8jbOSC5WjRMP+zDsoMIZZMpkHNvTXyuGT6UctpsbyZeHoRH5fIGzHbUG7H+a9MlS8L4JVMkZIJbgmMP+ubJUsuIZsd4DSkR0dUjIYduX7pslBIl3xZCM60xT8IkPRbjAqk3FawrpFeM+uMStXR/rOhnhZA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=fy0UePrlVTTNcJntfNiuSPcc8zS67fNtCIo5/uA/lf8=;
 b=Y7tvr4szsvXjFj55xwzPiavkhohTzFa/tRG3h2zRsf5W6VihijK8bHJfba57aK0/kWPtZPBYvcLGQ9H7YOpFbh6MC0QJRlmuarZhcXy67YyckoAxjJ+qnQ8EEy4xanIL9LdUZcSIQ9FeHeENC6B5S3loQki9OlBi+IuCd+WJF2QIZbiitZ9jlWTpPknl57leogwG5Za8n6cl+2n/670bT/e5QVbNcxeq2iV2AqURFnBiX/RMqA/TVxcKSwHOZFTcfX0e3MzkX+wZwThSOICb+9PH1rAE4OO6fC/alRZUz307O8ouDXYoA1zhpeTO0M75OTHOMOpjlb90YJfZsvqIkQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <9f0e5a2a-9aed-3869-b9c9-576885388686@suse.com>
Date: Thu, 17 Feb 2022 10:47:57 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v2 1/5] x86/cpuid: add CPUID flag for Extended Destination
 ID support
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: David Woodhouse <dwmw2@infradead.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220216103026.11533-1-roger.pau@citrix.com>
 <20220216103026.11533-2-roger.pau@citrix.com>
 <979fbc26-925c-f58f-9c1a-9ccd72275c9b@suse.com>
 <fd22f7e19590b0e8679e5a3a15992bd1f8a92126.camel@infradead.org>
 <9b5a8474-0be2-b4e6-8919-7e22dde1570a@suse.com>
 <Yg4UPzFk15tJGo0B@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Yg4UPzFk15tJGo0B@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0051.eurprd06.prod.outlook.com
 (2603:10a6:20b:463::22) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2edbb064-6765-4eb0-18a5-08d9f1fa957c
X-MS-TrafficTypeDiagnostic: DU2PR04MB8677:EE_
X-Microsoft-Antispam-PRVS:
	<DU2PR04MB8677876F44FCC1202FA1B6CAB3369@DU2PR04MB8677.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	QYIJEsmYtltK6QCqwhN1ilk8Cmzk7GNZSF1ZUNdlmDk/t2KGL+X6o+bMWQ5ky2qCVG2xbcfsW3TDvjuwvGt68N0D6Zq9fSraayah3pU/Gb78kuzlk1fKADQZ4LMBqcpelfB+fldVXOKYDlujozxcABxnZCEeavVX52Z9K0rnEQfUbAffgc7ngjq/4BZHZQX9SJ2Wf8GDLKkBuzRB2BmLoI/xZ9kprVETDzcZSlr6AQm17xQjVb5fmmEpLaX7CL6i0Q0OnKIzPIK4ePhtaovMN52/8TdsYypE9wCpmXQCicmaNo/W5mUJ58/7M1KbclaH89THLVasyYXre2Cm25Wp1oKeCxdszlRYn5MIH+xzb5PfsVEUX3T4YqdV82uRoUkQuKi2kq5laQr4KtqF10Qy6CozPzxUJCksqUZ+EheFImNnppTBMuURnvRhFJF7vxrF14OpvkIYKyVM0VfBvkqP8iPF38JcIEOwzVUOe6+m5JkyU6k9Uuc2Lh+2/hjAtr+OFrbWw+o5QPd5V1skp6yYnC6WdNFx3rN1Kysgdr/BGnX6zeni/t8RZCBO0zq33zKB3XYd5KLZUoTNSQy6S3wDkvHZwTxlqZMHcdtMceyYkpldQpurKexsB81SLRkpT35AxhpQ/R4t7fefC0ePbYXL6ENTKXFMyS7nE8Grv+FQVjvAiXf4xlASjJ0yMri6OuETv0wWu2Zy62NfNKZ2xT7Dn1QDlsnQ8fE0jR49bc2BHoNxpnGwoevg8g3ptFbrTHmX
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(36756003)(316002)(31686004)(6666004)(2616005)(38100700002)(54906003)(5660300002)(6506007)(26005)(53546011)(186003)(6486002)(83380400001)(2906002)(6916009)(6512007)(66946007)(8936002)(31696002)(86362001)(508600001)(66556008)(8676002)(4326008)(66476007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?KWtvOhpROX5+xRfs2dsEEEQIWPeKnpwWAPnXAivRcRaQfiJdpyUJIV5C5Cny?=
 =?us-ascii?Q?v3sfHrCnV6MRc65XkHARDAsM782n5cTBGLx4a8gWX6Tt9j2euGMtDM8nqh82?=
 =?us-ascii?Q?n+XalmKbGLzLJImIrKOxMcKuxM9nrmwrEpKSCN/GR4nfscpq1aQYPfF36iOD?=
 =?us-ascii?Q?YSae/mXafuxJsH2uiiWbOWvhOgou9yFCBIY0sVGATQ/RIbH5PhI3zOLYs72O?=
 =?us-ascii?Q?QoijBs5GxMywPVVbXAicp/b4MS12TmahNfhW8MjyRB+FYCEoO4swUV7MWnty?=
 =?us-ascii?Q?kNnSlyNUhSUaDAy081NSfYE0l4vozl3spYs0x+J030BHh/gzz+hCsZQ0j7e/?=
 =?us-ascii?Q?6JHKv3FdCK54QQeQlQ7KU9tBrlrDAy9XC5MBEWNGKfcU+M70Qfi0G7ec43gW?=
 =?us-ascii?Q?Tsc0FtR7P9hXiajMJ2BwA+FEFy1nivyp07CYRJYRdBFp5BI3t2CmXvEOhzd/?=
 =?us-ascii?Q?GetzOMtqVbMfgJsR2KuNH0PbRrxZlzI/vxRUh2/pC5xVBUjsI76tpy8bWwrg?=
 =?us-ascii?Q?f8pgIc+z3bC8l0R2sKV/Ozx9bhlnvrn7tD+AD11EbhJmx3suB7ZyA0nl+Mk7?=
 =?us-ascii?Q?ouq7agNegNUevI99BimTTVm5F7lHhRcHQMhWCbFFjWbJScn5GBr02hTKMavg?=
 =?us-ascii?Q?y0fgK7rT8DUoACz2kfvt5JkVei61SHpb3qfxKJEi2V/2jUEus4Se5OItSMvk?=
 =?us-ascii?Q?7UXqwM/MIdyVXbGhc13XwmVzoDL38V5/r0ZntUg4VpPtKD9BqnOHGcCUi7Zx?=
 =?us-ascii?Q?YYgkjv75L+0T1ekVulg7MvN1eFCqmeokIlNoaLNv1W/WhH8mNA+JI2JmI7Ca?=
 =?us-ascii?Q?miTdt8pDpUFNbJODoEYIZIANr0Pe0WYmoiQj9tR1uPG2vBGK5fmW6RNTlS3j?=
 =?us-ascii?Q?ix5TAPd0UR6TuACJh5obSKQv4Uu7hP8h0MnGvPw1gmUWl9q9hWIGcLlv6/g5?=
 =?us-ascii?Q?6vb3iU4TGOv0j+Ysu+7ioT99u7ObnQCXioNt3tYOxKdCKkp/td3ApfeGYkt1?=
 =?us-ascii?Q?Z+kyfkLyTxOKmd1bIlcfo1agleRpU67F3LvJ9wFpxNjv57GXnvxJObV0tqNC?=
 =?us-ascii?Q?nfYn/OVcqh12yl323Vxcy/rZl43BVHRH8gH7eJA+2+tYuj4kFnlYykATSgKI?=
 =?us-ascii?Q?lPceWrQY8+0mFo4iP6maPdW+cDBT9KUap06kIuYcekw8XM0glQjd88jZbx/T?=
 =?us-ascii?Q?EiVeOBmgMhqOT0224hqjz0OceVPszQnAtk2nHzITUguBwK/+ZGwNVvAzWxuf?=
 =?us-ascii?Q?J86v66gsmEPjRnDMYg0nfexNB4e3Pid0lJtUvE/s7fXYcF8T6rMVnVtJaMB9?=
 =?us-ascii?Q?UiWv7SpI7GcmhMYwV01djCOAkkz7blS9NGFHiBw7AufNLLLECwF0O0nhqLAR?=
 =?us-ascii?Q?TcW3GoQtN5A+ON4XW6kwZjF/HZUJf2TA2XRPbydU1+iL7KPnd4KNWn/ioNwQ?=
 =?us-ascii?Q?zRY2TU0Im9pZC+xpHiENBGw2OkjOVATWb+jKPVubIDrK6cZLeJY1GVNDnASs?=
 =?us-ascii?Q?ZV15ykTMMeLhzlxkaW594saPKogp3aUvf4W++mQR41nZPDqJrmynr6yIF+rj?=
 =?us-ascii?Q?l/8CrtclYXGhLhTKkoQ5Y2qEEpChTtyWGThG3WbYrv1fuwFWFFsc87xc6WL/?=
 =?us-ascii?Q?VE5x3wtwQQ4nUkLFW0ic0vw=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2edbb064-6765-4eb0-18a5-08d9f1fa957c
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2022 09:48:00.3410
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lUEtHOMSRyG1rdHQucy6+21Bf+AlTaIpZO4XipmRZ81Mintdl9Q+/NJtlUg9Jru0e6OwqOsbsToCmoNg9Ze/5w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8677

On 17.02.2022 10:24, Roger Pau Monn=C3=A9 wrote:
> On Thu, Feb 17, 2022 at 09:52:51AM +0100, Jan Beulich wrote:
>> On 16.02.2022 17:08, David Woodhouse wrote:
>>> On Wed, 2022-02-16 at 16:43 +0100, Jan Beulich wrote:
>>>> On 16.02.2022 11:30, Roger Pau Monne wrote:
>>>>> --- a/xen/include/public/arch-x86/cpuid.h
>>>>> +++ b/xen/include/public/arch-x86/cpuid.h
>>>>> @@ -102,6 +102,12 @@
>>>>>  #define XEN_HVM_CPUID_IOMMU_MAPPINGS   (1u << 2)
>>>>>  #define XEN_HVM_CPUID_VCPU_ID_PRESENT  (1u << 3) /* vcpu id is prese=
nt in EBX */
>>>>>  #define XEN_HVM_CPUID_DOMID_PRESENT    (1u << 4) /* domid is present=
 in ECX */
>>>>> +/*
>>>>> + * Bits 55:49 from the IO-APIC RTE and bits 11:5 from the MSI addres=
s can be
>>>>> + * used to store high bits for the Destination ID. This expands the =
Destination
>>>>> + * ID field from 8 to 15 bits, allowing to target APIC IDs up 32768.
>>>>> + */
>>>>> +#define XEN_HVM_CPUID_EXT_DEST_ID      (1u << 5)
>>>>
>>>> Would the comment perhaps better include "in the absence of (guest
>>>> visible) interrupt remapping", since otherwise the layout / meaning
>>>> changes anyway? Apart from this I'd be fine with this going in
>>>> ahead of the rest of this series.
>>>
>>> No, this still works even if the guest has a vIOMMU with interrupt
>>> remapping. The Compatibility Format and Remappable Format MSI messages
>>> are distinct because the low bit of the Ext Dest ID is used to indicate
>>> Remappable Format.
>>
>> Well, yes, that was my point: With that bit set bits 55:49 / 11:5 change
>> meaning.
>=20
> Bits 55:49/11:5 become reserved again with the interrupt format bit
> set to remappable.
>=20
>> As an alternative to my initial proposal the comment could also
>> state that bit 48 / 4 needs to be clear for this feature to take effect.
>=20
> I've always assumed that setting the IF to remappable invalidates
> extended destination ID, as the format of the interrupt is different
> then and there's no destination ID anymore, just a handle field. Maybe
> I could make it more explicit:
>=20
> /*
>  * With interrupt format set to 0 (non-remappable) bits 55:49 from the
>  * IO-APIC RTE and bits 11:5 from the MSI address can be used to store
>  * high bits for the Destination ID. This expands the Destination ID
>  * field from 8 to 15 bits, allowing to target APIC IDs up 32768.
>  */

Yes, this disambiguates things enough to address my concern. Then
Reviewed-by: Jan Beulich <jbeulich@suse.com>
and I'd be fine making the adjustment while committing, if no other
concerns arise.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Feb 17 09:56:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 17 Feb 2022 09:56:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274573.470080 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKdWW-00021A-Oo; Thu, 17 Feb 2022 09:56:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274573.470080; Thu, 17 Feb 2022 09:56:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKdWW-000213-Lm; Thu, 17 Feb 2022 09:56:28 +0000
Received: by outflank-mailman (input) for mailman id 274573;
 Thu, 17 Feb 2022 09:56:26 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=xzkl=TA=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nKdWU-00020x-RH
 for xen-devel@lists.xenproject.org; Thu, 17 Feb 2022 09:56:26 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id de779bdf-8fd7-11ec-8eb8-a37418f5ba1a;
 Thu, 17 Feb 2022 10:56:25 +0100 (CET)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2056.outbound.protection.outlook.com [104.47.12.56]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-4-3eJVzCu3PzG-0gDMCGJo_A-1; Thu, 17 Feb 2022 10:56:24 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM6PR04MB5336.eurprd04.prod.outlook.com (2603:10a6:209:4f::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.15; Thu, 17 Feb
 2022 09:56:22 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4995.016; Thu, 17 Feb 2022
 09:56:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: de779bdf-8fd7-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645091785;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=65MJJRs7UlTXYknN+AoWyVdia8q/yC54n+4Kph5kFC4=;
	b=KuaW5IXuK4tgJNk+kbmN86Qrbbv4/eME0dZXpjKE6/fYSFyzHuasaMRDpp4g0L8sXBnXXl
	zxrkjx1YCkaD3bw3DzD5KrNZJkmtNadr2Jrn+SrudhON+dQiOKB8OjytBo+56w+IKuNI/P
	ck1Pt91mwLYhqF5xpBzxj1TjALpRlnU=
X-MC-Unique: 3eJVzCu3PzG-0gDMCGJo_A-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=MWrGjO52+3uC5JELaXbpamcvAmBqVT3CZxB+ulO0qxaLJ7UH9z2BWroxQZY7OrvXq33ooeWPUUxnVHevQQGKinJf/M/w+r7KRbBL32fPAV+17FoX3dt5MsZp3oXHqSVHsk6AnXAWlpDQ7Y2ueBIlP47oDj/jXwWj3yZey86VSUqVDt8q7Uf5PC4pDPIKe7FzikOwLhl2f8zRdce40X5AlQlPMUCBLThPNYvC6TfxTOsHCIqVndmpkBNXmYszra+S/31258GGs20acYdFlP23pkcFWiIS+2hS7Sc85yIL6gkXM+IYTlofkDRNQ0EApaGe04B86M3AaBnYlgPdjIOODA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=gekqWGqOBjPGU1p+uQpZXjt//QFLg7yP/cvraATeqBs=;
 b=e4miC+LMli3S9BIUbNjGmPBJwMrdcRiwghT6pKViohNSxydwuRVIXiyg0MiUveF5teT2k0rlDuPXb/yzMxJED3orLvIb72CAxZrzVUxn+Azx4e3cIFQ5u6+1STqJ/s8QRiBF56qXwokxXMeoBhf8GLDW0U7kKwNULugKkoB0FyEgdCtCKA7AijC8xEiVLy0HXCkkMAb5ahsLfNbrZm57l5ZOUZFTX+2434Gv+iqWL3PHakhfBeNb9nDRJiaZq0ocjKlxWWjTbleE6f8BCj2xkHT9aYcAVfZPAHTtFA0fplI9r5RuGK/49+i/JapOYoB/1KRIfMSEo4GW3GuGPRZ83w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <53c10ff6-ca7d-e332-72b5-593203a5303d@suse.com>
Date: Thu, 17 Feb 2022 10:56:20 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v2 00/70] x86: Support for CET Indirect Branch Tracking
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
CC: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
 <julien@xen.org>, Juergen Gross <jgross@suse.com>,
 Daniel Smith <dpsmith@apertussolutions.com>,
 =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>, Xen-devel
 <xen-devel@lists.xenproject.org>, Roger Pau Monne <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
 <c471dcc2-8a91-60b8-ba5d-58874752e4d7@citrix.com>
 <218de2dc-6dd8-4e13-3288-36448e47de7f@suse.com>
 <8c6dd7d0-11e6-9b8a-66fc-f1a4998c074b@citrix.com>
 <83e15c5d-f48b-a6f2-ebca-e416bdef1093@suse.com>
 <9bcbd2f9-f713-cb56-abdd-baef5180a964@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <9bcbd2f9-f713-cb56-abdd-baef5180a964@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS8PR04CA0053.eurprd04.prod.outlook.com
 (2603:10a6:20b:312::28) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 685c0fde-0dfd-4b93-3066-08d9f1fbc0fd
X-MS-TrafficTypeDiagnostic: AM6PR04MB5336:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB5336B8E18FFFC9047B0C3065B3369@AM6PR04MB5336.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Y8w2fHGvo3YKIKdUd7VOos16GYb459Fx2Tv4c6FeYzeQD2cxOn6f/CiB1cEwksOF30wkrbj7HOoeh8cyqOLJiaUvbSEJrNRrld4uAgpAgmiGlyRzPLWNUTJiWQ48L9piX6tT3c5YL1CsqVDa88axrcme6ItEGcbdAixnrY6kLrd/r6OyCctqVly5qrWvly78XBj10F6imMHHtVp+0jvMyApR8t82iJncMFO77xKrsJ6Tz4hHu7Z3s9US7tDl1bW2y+kpo32sRGnc0NDeJd3IolNpX98KTyMx26F/N/ymz3o0qchdWS1NED8+9CVgkgRYdj5hgGewnkTizoULkypw97rRlAOQELXxNsyC1BBpxr/D7cY8dgjKuM3sphK0Gy4z8r3ewrWxpDLYZT/k6vF0a4sxnx+2FRK52OEgKKvzJIAen6F43uIPbV41on9G5rm+ht8b8bUvMY7y+gssCxk1139eiBui9dCI/CPxJt4o5ScWL7FcFXXbcFioH/o8IZ5JCGOzbglxuvVizKMpcwW2HVEifssqeG0487JtDA4fBekhX9vyFAhmlUIpJ1wotf4aBnIH+CpxkxgBlJlEmCrJiR/YlNFl17TcfS6co6jGgbhq1CUc9YM92EedIPUOxJc9gtkTpGR6j1Cmxa5XHIu+JyD7xaPGG6U6iAo5v45b1myqAYV6mUja8COkfIltIRsjC6Y1Cv9hXFUbV/LzYOix11H1wlxQxglflQz2QT1B1pAgpRNG/OZX6RFzCp2OhxgTLENWhtpy7nn2cR5l7RFGZfdaV5IakkZOqivAOTsSPK3FJfsdGZQK/L7LZ2OOd5hSS19Pp7R58svhOB5QP1wT0A==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(31696002)(508600001)(6486002)(186003)(26005)(966005)(6916009)(86362001)(6512007)(6506007)(53546011)(2616005)(31686004)(4326008)(36756003)(316002)(5660300002)(8936002)(2906002)(66946007)(66556008)(66476007)(8676002)(38100700002)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?YxkYVgluruXAmbTm4TCX4xoPfyiVYfwypG8HcmZH0Ss1DJxjfOgjzlJCP3+t?=
 =?us-ascii?Q?aA8oWvanUwwA9AC+EWSM5shVIyZcFkvt9vxI/JU8ZnapLasiMvudml+8eBwq?=
 =?us-ascii?Q?3w0NSJqG5+Py8PorCjDS0PTWYRAnlX+2ILk+iYE6cNFzhFE16aR3g/Slrf7d?=
 =?us-ascii?Q?Aki6j2Z1A2MMWd4//9MIeXhLKJPblE8+UMdpesFwDnF8NMyh2sZA2OtX+IJ4?=
 =?us-ascii?Q?sKWnEiRDLXlNEzCsk+zuflef8IJoT4fq6OaY7+ASLz1dDSaA1sIDs8aH7mug?=
 =?us-ascii?Q?ulg2GQlypxqsktO6GD2h3HsM9jkzApgRBz/7b/uJzSQnTlJTg+FdnkwFvlLV?=
 =?us-ascii?Q?GdKSUsxbnSuTbpTjY3GiM9sTyYeWF0RzrpK2gjRFBY7J/SCw72OvI1F+Zf71?=
 =?us-ascii?Q?QUnvpkL6UzV4HDu2B3RlNDHkFHMkOvHYtpaDh9cENLqmV9ZtLGZpDcQwEGrm?=
 =?us-ascii?Q?ClydQPlLeGPKFu72EsSGxvQ0S9va6A6YFGScAXhhH26dwB/j+7ff1+UDLzPF?=
 =?us-ascii?Q?QsU/CNQyz/rIO6Gul4pWubYSxqkwDreWObM9whuNhj6LeflWbsIT2H1mTbRA?=
 =?us-ascii?Q?9s0QNqakpLmMtGz5zHC2iDLKCrYo29XLy7D/DqPW2e1KTQmsZRQAC7dsHy09?=
 =?us-ascii?Q?tcn3WCnDEcb2T4Y+SwSNl+3t70phtcaXqIpfcyQ4KmyG1+7yzz22v7XYEJai?=
 =?us-ascii?Q?YUPNm6ksDZ8bcMybfPMlfixUlYD9FIrBxFKoGVXMlu4j1VC7THZC/48ZXjLU?=
 =?us-ascii?Q?M0xroUt65hqwlBxR8efdovcdMadKPm/Ryb61k0fjGnJwUvunIvNC5AoqqQ8Y?=
 =?us-ascii?Q?HXHh4k3tjmsJFl8EXc6jtcHB0apra9mxF2SaNX59FII7OLK0chvsFAGuXkxG?=
 =?us-ascii?Q?OEoa9nqgxPu9yCtFxTW8M3n7v05spbvbfTxdZipeN31CtskMbvQ/hJSxSis2?=
 =?us-ascii?Q?iwppEk/dKFKE+YQSyqLl+AhZPmhZkezyEpjI576ROIvmCdsRuJmognpqpx2N?=
 =?us-ascii?Q?Vw1VXMPTRXGkKHlUDgaaKDoy1eEoXkf5KUfZBfXwnAiP9y3KK/rU/9XlEffo?=
 =?us-ascii?Q?UMwvGfdBP2iBRby7vVnDpQwbdYu8gFoMjZ49H96lGNGlqdU+uPBCNfsr/V5V?=
 =?us-ascii?Q?hCcaAC0ut4Arx1o1O+VTkWoBxiSt4lDENlzDBQNLnAwy3eLV7OHeh8YCfr3d?=
 =?us-ascii?Q?abWjyRTgG+C7aoC0+udwhYlPmg8AuJSwNoiUssb6G4JcqTbyNcE4M+yGlfN/?=
 =?us-ascii?Q?CJSsqe+Au7EoyGzAOTlXwICx8+CxjM0og2RaNvtjtyjS/9A8gkD4tx8Vqfw6?=
 =?us-ascii?Q?THvKgtgMqBLDjVRDVpewf0VsZlD4aCrqAa28aPuymhPdEy3+33Kwwm+aL18Y?=
 =?us-ascii?Q?Z1B8R0yiwgT29/myO0T0ziP1LzG2vGZ1kb4+OhUNLeKcjbAw/wpJM6Lhxt1d?=
 =?us-ascii?Q?aOi3kkQPgJ32/uOEUljhxHxyO7FMkpj7R/Hn0Vv6+6bWPwUP7sQOddJ3ouxr?=
 =?us-ascii?Q?0+L56A/UFqrX+LcPHmLKXnCGcwuQeXmTqK2LUI/qLUS/TXvAMswD5WFMPXqJ?=
 =?us-ascii?Q?4FXQFRO3h9afHzUj7x5gNfimoZ1o5UV/uZvW9RevK3VlAU6tNLdXUv9stZrW?=
 =?us-ascii?Q?NzuA5y1Mvfa0JJ30FX2zwIw=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 685c0fde-0dfd-4b93-3066-08d9f1fbc0fd
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2022 09:56:22.8102
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Q6dt6YzTJWbwo2qj/yixmbS+4W9lMrcqNprD3LnhGsgEixwxyPEyRZ8JldiAPXjFVw9mX6fopukK8P2cBAf0BA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5336

On 16.02.2022 22:59, Andrew Cooper wrote:
> On 14/02/2022 14:38, Jan Beulich wrote:
>> On 14.02.2022 15:15, Andrew Cooper wrote:
>>> On 14/02/2022 13:43, Jan Beulich wrote:
>>>> On 14.02.2022 14:10, Andrew Cooper wrote:
>>>>> On 14/02/2022 12:50, Andrew Cooper wrote:
>>>>>> CET Indirect Branch Tracking is a hardware feature designed to prote=
ct against
>>>>>> forward-edge control flow hijacking (Call/Jump oriented programming)=
, and is a
>>>>>> companion feature to CET Shadow Stacks added in Xen 4.14.
>>>>>>
>>>>>> Patches 1 thru 5 are prerequisites.  Patches 6 thru 60 are fairly me=
chanical
>>>>>> annotations of function pointer targets.  Patches 61 thru 70 are the=
 final
>>>>>> enablement of CET-IBT.
>>>>>>
>>>>>> This series functions correctly with GCC 9 and later, although an ex=
perimental
>>>>>> GCC patch is required to get more helpful typechecking at build time=
.
>>>>>>
>>>>>> Tested on a TigerLake NUC.
>>>>>>
>>>>>> CI pipelines:
>>>>>>   https://gitlab.com/xen-project/people/andyhhp/xen/-/pipelines/4704=
53652
>>>>>>   https://cirrus-ci.com/build/4962308362338304
>>>>>>
>>>>>> Major changes from v1:
>>>>>>  * Boilerplate for mechanical commits
>>>>>>  * UEFI runtime services unconditionally disable IBT
>>>>>>  * Comprehensive build time check for embedded endbr's
>>>>> There's one thing I considered, and wanted to discuss.
>>>>>
>>>>> I'm tempted to rename cf_check to cfi for the function annotation, as
>>>>> it's shorter without reducing clarity.
>>>> What would the 'i' stand for in this acronym?
>>> The class of techniques is called Control Flow Integrity.
>>>
>>>>  Irrespective of the answer
>>>> I'd like to point out the name collision with the CFI directives at
>>>> assembler level. This isn't necessarily an objection (I'm certainly fo=
r
>>>> shortening), but we want to avoid introducing confusion.
>>> I doubt there is confusion to be had here.=C2=A0 One is entirely a comp=
iler
>>> construct which turns into ENDBR64 instructions in the assembler, and
>>> one is a general toolchain construct we explicitly disable.
>> Hmm. I'm still at best half convinced. Plus we generally have been
>> naming our shorthands after the actual attribute names. By using
>> "cfi" such a connection would also be largely lost. Roger, Wei,
>> others - do you opinions either way?
>=20
> My point is this.=C2=A0 Doing nothing is my easiest option.
>=20
> But if anyone has length/alternative suggestions, dealing with them now
> is going to be infinitely easier than once this series is committed.

Understood. My personal preference then is to stick with cf_check.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Feb 17 10:02:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 17 Feb 2022 10:02:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274580.470092 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKdc8-0003Tw-Eq; Thu, 17 Feb 2022 10:02:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274580.470092; Thu, 17 Feb 2022 10:02:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKdc8-0003Tp-AA; Thu, 17 Feb 2022 10:02:16 +0000
Received: by outflank-mailman (input) for mailman id 274580;
 Thu, 17 Feb 2022 10:02:14 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=W+1Z=TA=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nKdc6-0003Tj-Cx
 for xen-devel@lists.xenproject.org; Thu, 17 Feb 2022 10:02:14 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ab32a6cb-8fd8-11ec-b215-9bbe72dcb22c;
 Thu, 17 Feb 2022 11:02:10 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ab32a6cb-8fd8-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645092132;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=GMU8LsN/3Pxq78qL9996Dptilzd5w89xVJXi9VTdYfI=;
  b=YxpzR8+mSemDdtYBt7arL6HzL/pNR3TCnRr1hDIJGv7E7yu7H9HwS0Gv
   5YC6mvHj17LaCiZACvy/8Dk0cYadTISUUwr47nVjKRyUlaGRkQkFDxNnx
   H7mZrAelOLUc5ZGq+il1jAoaDiqRFtR02NUwc2NW12ZjgVgOJqWbJT0sz
   s=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: e3tKdMLDgMD4cmrSo3bQqbb3IOiAmvd8tP/z/S7DAulTflI0ai1izY773zlo3el5TudJqz6d/H
 CJx3ZdBBA0BDOKNlJlQQcYEcTiAl1Rnd4oDbRVP7espBbt10ggmQSyfffwUQO3lHwER+Q16Gl6
 nns0lVWbMFDFfvAviL5kGs8AzpOs7M109sCU6IwtpMur+h1eHj6+4IjtPgJxiMOoxthZ+hnTT8
 9Cyo4wOgs8bEYnZns0tcxVsZi0YkBZ4Cvt3maYHe1bOslCyzsTWi/oaFKdP1q4yZYWksNaLkvM
 M3LKDwacXvRdzCyz3rN2FPkF
X-SBRS: 5.1
X-MesageID: 64418586
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:/POyTannM4d2Ue3RgAX1ySvo5gxDIURdPkR7XQ2eYbSJt1+Wr1Gzt
 xJJDTqGP6rba2KhetFwaNi29EhT75TQy95lQVZuqHo0QyMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BClVlxJVF/fngqoDUUYYoAQgsA180IMsdoUg7wbRh2Nc32YHR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 NtLi5eUbQYjB5+PiP05bjhxOTNuMrITrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBODtMJkSpTdLyjbBAOx9aZvCX7/L9ZlT2zJYasVmQ6qCP
 ppEOWQHgBLoM0ISNF48V5UFvKSDoUOubm17qwuPjP9ii4TU5FMoi+W8WDbPQfSVQe1Fk0Deo
 XjJl0zbKBwHMN2UyRKe72mhwOTImEvTSI8UUbG16PNuqFmS3XAITg0bU0Ohpvu0gVL4XMhQQ
 3H44QJ38/J0rhbyCICgAVvo+xZooyLwRfJeFdMxzCWMwJPmoBaAIlUlZxRTeNM54ZpeqSMR6
 neFmNbgBDpKubKTSG6A+rr8kQ5eKRT5PkdZO3ZaEFJtD83L5dhq00mRFooL/Lud04WtcQwc1
 Qxmu8TXa187qccQn5u28lnc695HjsiYF1Vljuk7s4/M0++YWGJHT9D5gbQ4xawZRGp8crVnl
 CJb8yR5xLpTZaxhbATXHI0w8EiBvp5pygH0j191BIUG/D+w4XOldo04yGggeBoxaZlaJWKyP
 xK7VeZtCHl7ZiTCgUhfOd/ZNijX5fK4SYSNug78NbKinaSdhCfYpXozNCZ8LkjmkVQ2kLFXB
 HtoWZ3EMJruMow+lGDeb75EidcDn3lirUuOFcGT50n2itK2OS/KIYrpxXPTN4jVGovf+16Lm
 zueXuPXoyhivBrWOXiNrtBNfAtbdhDWx/ne8qRqSwJKGSI+cElJNhMb6epJl1VNk/sHm+HW0
 Gu6X0MEmlPziWeecVeBa2x5aaOpVpF69CppMSspNFeu+n4ifYfws/tPK8ppJeEqpL550Pp5b
 /gZYMHcUP5BfSvKpmYGZp7noY08KBny3VCSPzCoaSQUdoJ7Q1Cb4cftewbirXFcDie+ucYkj
 aen0wfXHcgKSwh4VZ6EY/Oz1VKh+3ManbsqDUfPJ9BSfmTq8ZRrdHOt3qNmfZlUJEyalDWA1
 guQDRMJnsX3otc4oIvTmKSJj4a1CO8iTEBUKHbWsOStPi7A82v9nYIZCLSUfSrQXX/f8bm5Y
 bkH1On1NfAKkQoYs4d4FLo3n6sy68G2+u1fxwVgWn7Kc06qGvVrJXzfhZtDsahEx7l4vwqqW
 x3QpokGaOvRYM61QkQMIAcFb/iY0aBGkzbf2v05PUHm6XIl57GAS0hTY0GBhSE1wGGZ62/5L
 TPNYPIr1jE=
IronPort-HdrOrdr: A9a23:p/YIyqnsH8XT7LvMsb09wNSdvIvpDfIU3DAbv31ZSRFFG/Fxl6
 iV8sjzsiWE8Qr5OUtQ/+xoV5PhfZqxz/JICMwqTNKftWrdyQyVxeNZnOjfKlTbckWUnINgPO
 VbAsxD4bXLfCBHZK3BgTVQfexO/DD+ytHLudvj
X-IronPort-AV: E=Sophos;i="5.88,375,1635220800"; 
   d="scan'208";a="64418586"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>
Subject: [PATCH v2.1 6.5/70] x86/kexec: Annotate embedded data with ELF metadata
Date: Thu, 17 Feb 2022 10:01:58 +0000
Message-ID: <20220217100158.22402-1-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125127.17985-1-andrew.cooper3@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

Scanning for embedded endbranch instructions involves parsing the .text
disassembly.  Data in the kexec trampoline has no ELF metadata, so objdump
treats it as instructions and tries to disassemble.  Convert:

  ffff82d040396108 <compatibility_mode_far>:
  ffff82d040396108:       00 00                   add    %al,(%rax)
  ffff82d04039610a:       00 00                   add    %al,(%rax)
  ffff82d04039610c:       10 00                   adc    %al,(%rax)

  ffff82d04039610e <compat_mode_gdt_desc>:
  ffff82d04039610e:       17                      (bad)
          ...

  ffff82d040396118 <compat_mode_gdt>:
          ...
  ffff82d040396120:       ff                      (bad)
  ffff82d040396121:       ff 00                   incl   (%rax)
  ffff82d040396123:       00 00                   add    %al,(%rax)
  ffff82d040396125:       93                      xchg   %eax,%ebx
  ffff82d040396126:       cf                      iret
  ffff82d040396127:       00 ff                   add    %bh,%bh
  ffff82d040396129:       ff 00                   incl   (%rax)
  ffff82d04039612b:       00 00                   add    %al,(%rax)
  ffff82d04039612d:       9b                      fwait
  ffff82d04039612e:       cf                      iret
          ...

  ffff82d040396130 <compat_mode_idt>:
          ...

  ffff82d0403961b6 <kexec_reloc_size>:
  ffff82d0403961b6:       b6 01                   mov    $0x1,%dh
          ...

to:

  ffff82d040396108 <compatibility_mode_far>:
  ffff82d040396108:       00 00 00 00 10 00                               ......

  ffff82d04039610e <compat_mode_gdt_desc>:
  ffff82d04039610e:       17 00 00 00 00 00 00 00 00 00                   ..........

  ffff82d040396118 <compat_mode_gdt>:
          ...
  ffff82d040396120:       ff ff 00 00 00 93 cf 00 ff ff 00 00 00 9b cf 00 ................

  ffff82d040396130 <compat_mode_idt>:
  ffff82d040396130:       00 00 00 00 00 00                               ......

  ffff82d040396136 <reloc_stack>:
          ...

Most data just gains type and size metadata.  The reloc_stack label is the
wrong end of the data block to have a size, so move it to the lowest address
and introduce .Lreloc_stack_base as a replacement.

While kexec_reloc_size could gain metadata, it's use in the linker
assertion (while correct) is deeply confusing to follow.  Drop it entirely,
using a linker symbol instead to denote the end of the trampoline.

No functional change.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>

The remainder of the 32bit code has mode-invariant lengths, so disassembles
safely as 64bit.  The only differences come from 32/64bit implicit register
sizes.

v2.1:
 * New
---
 xen/arch/x86/include/asm/machine_kexec.h |  2 +-
 xen/arch/x86/machine_kexec.c             |  2 +-
 xen/arch/x86/x86_64/kexec_reloc.S        | 22 +++++++++++++++++-----
 xen/arch/x86/xen.lds.S                   |  3 ++-
 4 files changed, 21 insertions(+), 8 deletions(-)

diff --git a/xen/arch/x86/include/asm/machine_kexec.h b/xen/arch/x86/include/asm/machine_kexec.h
index ba0d469d077b..d4880818c1d9 100644
--- a/xen/arch/x86/include/asm/machine_kexec.h
+++ b/xen/arch/x86/include/asm/machine_kexec.h
@@ -9,7 +9,7 @@ extern void kexec_reloc(unsigned long reloc_code, unsigned long reloc_pt,
                         unsigned long ind_maddr, unsigned long entry_maddr,
                         unsigned long flags);
 
-extern unsigned int kexec_reloc_size;
+extern const char kexec_reloc_end[];
 
 #endif
 
diff --git a/xen/arch/x86/machine_kexec.c b/xen/arch/x86/machine_kexec.c
index 08ec9fd43b1d..751a9efcaf6a 100644
--- a/xen/arch/x86/machine_kexec.c
+++ b/xen/arch/x86/machine_kexec.c
@@ -117,7 +117,7 @@ int machine_kexec_load(struct kexec_image *image)
     }
 
     code_page = __map_domain_page(image->control_code_page);
-    memcpy(code_page, kexec_reloc, kexec_reloc_size);
+    memcpy(code_page, kexec_reloc, kexec_reloc_end - (char *)kexec_reloc);
     unmap_domain_page(code_page);
 
     /*
diff --git a/xen/arch/x86/x86_64/kexec_reloc.S b/xen/arch/x86/x86_64/kexec_reloc.S
index d488d127cfb9..05bf8810cee6 100644
--- a/xen/arch/x86/x86_64/kexec_reloc.S
+++ b/xen/arch/x86/x86_64/kexec_reloc.S
@@ -34,7 +34,7 @@ ENTRY(kexec_reloc)
         movq    %rcx, %rbp
 
         /* Setup stack. */
-        leaq    (reloc_stack - kexec_reloc)(%rdi), %rsp
+        leaq    (.Lreloc_stack_base - kexec_reloc)(%rdi), %rsp
 
         /* Load reloc page table. */
         movq    %rsi, %cr3
@@ -175,10 +175,16 @@ compatibility_mode_far:
         .long 0x00000000             /* set in call_32_bit above */
         .word 0x0010
 
+        .type compatibility_mode_far, @object
+        .size compatibility_mode_far, . - compatibility_mode_far
+
 compat_mode_gdt_desc:
         .word .Lcompat_mode_gdt_end - compat_mode_gdt -1
         .quad 0x0000000000000000     /* set in call_32_bit above */
 
+        .type compat_mode_gdt_desc, @object
+        .size compat_mode_gdt_desc, . - compat_mode_gdt_desc
+
         .align 8
 compat_mode_gdt:
         .quad 0x0000000000000000     /* null                              */
@@ -186,16 +192,22 @@ compat_mode_gdt:
         .quad 0x00cf9b000000ffff     /* 0x0010 ring 0 code, compatibility */
 .Lcompat_mode_gdt_end:
 
+        .type compat_mode_gdt, @object
+        .size compat_mode_gdt, . - compat_mode_gdt
+
 compat_mode_idt:
         .word 0                      /* limit */
         .long 0                      /* base */
 
+        .type compat_mode_idt, @object
+        .size compat_mode_idt, . - compat_mode_idt
+
         /*
          * 16 words of stack are more than enough.
          */
-        .fill 16,8,0
 reloc_stack:
+        .fill 16,8,0
+.Lreloc_stack_base:
 
-        .globl kexec_reloc_size
-kexec_reloc_size:
-        .long . - kexec_reloc
+        .type reloc_stack, @object
+        .size reloc_stack, . - reloc_stack
diff --git a/xen/arch/x86/xen.lds.S b/xen/arch/x86/xen.lds.S
index c399178ac123..13fc7ee008c1 100644
--- a/xen/arch/x86/xen.lds.S
+++ b/xen/arch/x86/xen.lds.S
@@ -87,6 +87,7 @@ SECTIONS
        *(.text.unlikely)
        *(.fixup)
        *(.text.kexec)
+       kexec_reloc_end = .;
        *(.gnu.warning)
        _etext = .;             /* End of text section */
   } PHDR(text) = 0x9090
@@ -433,7 +434,7 @@ ASSERT(__2M_rwdata_end <= XEN_VIRT_END - XEN_VIRT_START + __XEN_VIRT_START -
        "Xen image overlaps stubs area")
 
 #ifdef CONFIG_KEXEC
-ASSERT(kexec_reloc_size - kexec_reloc <= PAGE_SIZE, "kexec_reloc is too large")
+ASSERT(kexec_reloc_end - kexec_reloc <= PAGE_SIZE, "kexec_reloc is too large")
 #endif
 
 /* The Multiboot setup paths relies on this to simplify superpage PTE creation. */
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Thu Feb 17 10:13:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 17 Feb 2022 10:13:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274587.470103 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKdmY-0004x3-EC; Thu, 17 Feb 2022 10:13:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274587.470103; Thu, 17 Feb 2022 10:13:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKdmY-0004ww-Ad; Thu, 17 Feb 2022 10:13:02 +0000
Received: by outflank-mailman (input) for mailman id 274587;
 Thu, 17 Feb 2022 10:13:01 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=7Axj=TA=gmail.com=digetx@srs-se1.protection.inumbo.net>)
 id 1nKdmX-0004wq-2L
 for xen-devel@lists.xenproject.org; Thu, 17 Feb 2022 10:13:01 +0000
Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com
 [2a00:1450:4864:20::235])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2de8b409-8fda-11ec-b215-9bbe72dcb22c;
 Thu, 17 Feb 2022 11:12:57 +0100 (CET)
Received: by mail-lj1-x235.google.com with SMTP id b20so7486186ljf.7
 for <xen-devel@lists.xenproject.org>; Thu, 17 Feb 2022 02:12:59 -0800 (PST)
Received: from [192.168.2.145] (109-252-138-165.dynamic.spd-mgts.ru.
 [109.252.138.165])
 by smtp.googlemail.com with ESMTPSA id o10sm5079173lfl.116.2022.02.17.02.12.57
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Thu, 17 Feb 2022 02:12:58 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2de8b409-8fda-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=message-id:date:mime-version:user-agent:subject:content-language:to
         :cc:references:from:in-reply-to:content-transfer-encoding;
        bh=OO8O5AkWPhI/5yGYSTEQp+LjZetKZnyQ+pZ7++XrzEA=;
        b=X8w7in6JtN9+vwIDY375tbKdJ6/kAXjQzoJEMNX/aRNZ/xldyGjWjXODYmSy5mi1RE
         IVBvYSJ5Q0hWoh3euDgluS6hajxAwota0SjPBhdLfholDQzq33VHuJfcHHzCkXGyz8tb
         MDBzs6ibY/EGdDqB/ff2GewtKr6TpYHNqvy5y4L9nhOeKSaVrEEfVSAdHs3oIc8/KGvy
         BUoC/Ntz4HLIebyoKI3bup9qeurRZrprpsOzzaMBNquRHtxpasWvx6s1xD7yjJ47gW7a
         aqMUkT2VhDOvjwLmzIlZFje3GuDLrgVXuDJcvjJJbqm/WRU77L4UMZYg+2nxY7fnS64M
         8wzw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:message-id:date:mime-version:user-agent:subject
         :content-language:to:cc:references:from:in-reply-to
         :content-transfer-encoding;
        bh=OO8O5AkWPhI/5yGYSTEQp+LjZetKZnyQ+pZ7++XrzEA=;
        b=jcFazVfVPcyMscwe0jS3hIW3SeYVoaKUDT+xY/t+bMyv/7GdNmNVfG05h5QUkf8jt0
         edCFFMmbrqPfX8GB+C33CRXIemfEyjt81YIe629tRPFklGZpMiSbyGToXLanCMGpvs1i
         /WL3qeftCYNmw0nu4/t6Smftr0Cbj9XwsTufOVQAIQtidGlGfHOWQlW0ok7RML/YWNzZ
         oozfLEvxHbIq1gtdqaRxRkUgGip8+x9crWYJ5NXZ1RqmaHo2aICQF/0s+O4nxaZ0NyaU
         hBhd+KOhx/t9tiUq7j9p9geps1Xz683jEoVkzAtAVbZAYMILvBJ/wnie4kK0K8DWT8De
         ZC4g==
X-Gm-Message-State: AOAM533XKz59swn3imyPdElzH2p5dNWMHK94594fVTlPFAdylxiOhPyK
	CUFDlnOVjWPphndSdigyP1M=
X-Google-Smtp-Source: ABdhPJzppLbwPh7ryO4JRMtpJc/4Lz2rbVquaymBUgCgBO2OneSkA3o02raf386TVCaqFDiGA98BPg==
X-Received: by 2002:a05:651c:1544:b0:246:1887:cf4c with SMTP id y4-20020a05651c154400b002461887cf4cmr917179ljp.118.1645092779295;
        Thu, 17 Feb 2022 02:12:59 -0800 (PST)
Message-ID: <4f0d1b50-9f55-dd81-f0c7-f5e0dfd75c2a@gmail.com>
Date: Thu, 17 Feb 2022 13:12:57 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v6 00/21] Introduce power-off+restart call chain API
Content-Language: en-US
To: Helge Deller <deller@gmx.de>, "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
 linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org,
 linux-m68k@lists.linux-m68k.org,
 "open list:BROADCOM NVRAM DRIVER" <linux-mips@vger.kernel.org>,
 linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org,
 Linux-sh list <linux-sh@vger.kernel.org>, xen-devel@lists.xenproject.org,
 ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
 Linux PM <linux-pm@vger.kernel.org>,
 linux-tegra <linux-tegra@vger.kernel.org>,
 Thierry Reding <thierry.reding@gmail.com>,
 Jonathan Hunter <jonathanh@nvidia.com>, Russell King
 <linux@armlinux.org.uk>, Catalin Marinas <catalin.marinas@arm.com>,
 Will Deacon <will@kernel.org>, Guo Ren <guoren@kernel.org>,
 Geert Uytterhoeven <geert@linux-m68k.org>, Greg Ungerer
 <gerg@linux-m68k.org>, Joshua Thompson <funaho@jurai.org>,
 Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
 Sebastian Reichel <sre@kernel.org>, Linus Walleij
 <linus.walleij@linaro.org>, Philipp Zabel <p.zabel@pengutronix.de>,
 Greentime Hu <green.hu@gmail.com>, Vincent Chen <deanbo422@gmail.com>,
 "James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
 Michael Ellerman <mpe@ellerman.id.au>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Paul Mackerras <paulus@samba.org>, Paul Walmsley <paul.walmsley@sifive.com>,
 Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>,
 Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,
 the arch/x86 maintainers <x86@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>, Juergen Gross
 <jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>,
 Len Brown <lenb@kernel.org>, Santosh Shilimkar <ssantosh@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
 Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>,
 Pavel Machek <pavel@ucw.cz>, Lee Jones <lee.jones@linaro.org>,
 Andrew Morton <akpm@linux-foundation.org>, Guenter Roeck
 <linux@roeck-us.net>, Daniel Lezcano <daniel.lezcano@linaro.org>,
 Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
 Ulf Hansson <ulf.hansson@linaro.org>, alankao@andestech.com,
 "K . C . Kuen-Chern Lin" <kclin@andestech.com>,
 =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= <mirq-linux@rere.qmqm.pl>
References: <20220130233718.21544-1-digetx@gmail.com>
 <635e8121-fca4-580c-6af5-d9317a2eee1b@gmail.com>
 <CAJZ5v0g0MrBm2+GwctkB7kUyBEt6HTAexRCFFRmTF1UKDrVQ-g@mail.gmail.com>
 <de2cbd2a-8d0d-8678-e514-b153d04546cc@gmx.de>
From: Dmitry Osipenko <digetx@gmail.com>
In-Reply-To: <de2cbd2a-8d0d-8678-e514-b153d04546cc@gmx.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

16.02.2022 23:30, Helge Deller пишет:
> On 2/16/22 13:25, Rafael J. Wysocki wrote:
>> On Tue, Feb 15, 2022 at 11:00 PM Dmitry Osipenko <digetx@gmail.com> wrote:
>>>
>>> 31.01.2022 02:36, Dmitry Osipenko пишет:
>>>> Problem
>>>> -------
>>>>
>>>> SoC devices require power-off call chaining functionality from kernel.
>>>> We have a widely used restart chaining provided by restart notifier API,
>>>> but nothing for power-off.
>>>>
>>>> Solution
>>>> --------
>>>>
>>>> Introduce new API that provides both restart and power-off call chains.
>>>>
>>>> Why combine restart with power-off? Because drivers often do both.
>>>> More practical to have API that provides both under the same roof.
>>>>
>>>> The new API is designed with simplicity and extensibility in mind.
>>>> It's built upon the existing restart and reboot APIs. The simplicity
>>>> is in new helper functions that are convenient for drivers. The
>>>> extensibility is in the design that doesn't hardcode callback
>>>> arguments, making easy to add new parameters and remove old.
>>>>
>>>> This is a third attempt to introduce the new API. First was made by
>>>> Guenter Roeck back in 2014, second was made by Thierry Reding in 2017.
>>>> In fact the work didn't stop and recently arm_pm_restart() was removed
>>>> from v5.14 kernel, which was a part of preparatory work started by
>>>> Guenter Roeck. I took into account experience and ideas from the
>>>> previous attempts, extended and polished them.
>>>
>>>
>>> Rafael and all, do you see anything critical that needs to be improved
>>> in this v6?
>>>
>>> Will be great if you could take this patchset via the power tree if it
>>> looks okay, or give an ack.
>>
>> I need some more time for this, sorry.

No worries, we're not in a rush.

>> I'm a bit concerned about seeing no response to this set from anyone.
>>
>> It looks like multiple platforms may be affected by it in principle,
>> so doesn't anyone care?

The platforms that didn't provide ack so far are: SH, x86, IA64, MIPS
and NDS32. At least x86 and MIPS are alive, not sure why maintainers
didn't bother to answer yet.

> I did looked into the whole patch set after applying it locally.
> 
> While I agree a new combined API is good, and the beginning looked promising,
> after some time I started to ask myself if the whole infrastructure might
> be a little overdesigned.
> 
> Anyway, I tested it and it works for me on parisc.
> And it's probably better than what we have today.

Thank you!


From xen-devel-bounces@lists.xenproject.org Thu Feb 17 10:21:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 17 Feb 2022 10:21:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274597.470114 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKduF-0006UJ-AX; Thu, 17 Feb 2022 10:20:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274597.470114; Thu, 17 Feb 2022 10:20:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKduF-0006UC-7Q; Thu, 17 Feb 2022 10:20:59 +0000
Received: by outflank-mailman (input) for mailman id 274597;
 Thu, 17 Feb 2022 10:20:58 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=xzkl=TA=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nKduE-0006U6-8d
 for xen-devel@lists.xenproject.org; Thu, 17 Feb 2022 10:20:58 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4a1fe71c-8fdb-11ec-b215-9bbe72dcb22c;
 Thu, 17 Feb 2022 11:20:55 +0100 (CET)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2058.outbound.protection.outlook.com [104.47.13.58]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-41-NKXEcG0YO8WnpF6p6XQDeQ-2; Thu, 17 Feb 2022 11:20:55 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DB8PR04MB6748.eurprd04.prod.outlook.com (2603:10a6:10:10e::24)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Thu, 17 Feb
 2022 10:20:51 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4995.016; Thu, 17 Feb 2022
 10:20:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4a1fe71c-8fdb-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645092977;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=NCkLUEy2U6STOHaphPPK/NDCiSK/9UshqiogFsCJ9u8=;
	b=K2ja0xpYL7UEFjrofX0KfZQ+jVtrX3w2lKaABW/NSDZpROb0mUMuCVlRkjSCu2UOIfP+6P
	gThg+TChJ1ISSlU+leJQEnAdiJd5zA70gXEV31MTWzF0S8kmKQr4QF+ihgSOPm+NR5ra+f
	28dW/NN7VGeJkvoGYVkOTkd3cGV6dmY=
X-MC-Unique: NKXEcG0YO8WnpF6p6XQDeQ-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=AYhyvqieWnlrM+GQLxiRpFeVu7OPFGCGl7Et84oGBlAgcb8MXX3YSDTqtF0IvK38rHZ4Y29gu8HSZZQFbF3in7sDlSM+xwYL/nnv+icY0dur/SBldVDpzmVa8oXhgyNW2rBTFqyx5+zbzIIs9H9Z0hjz5MQ0HVb0kAiXzhJA/Ns6m+Z0Tcm9aFHYPbhuhdADSiFoskmrsW+eaP4pOlp0BOcG4oBoFwY1/WgIMSEfD129sCC6FNhNjp9rppAi3IkTDXj5oN9BbXtW/W2WXT8GAtWiqkXPTatIejkTOIGxoCepc5KoS3z+t/AGw3gVPFO8DNGKwrhct2GPtyr+UV9JWg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=hgaWmZ0lcq7FzIcTB3VPyEClczv06jhS9M81h14zoSc=;
 b=XitLCcnX8O75KKEjALtUl1eN1A+PikeTKGu/42if+VV+eG5GIcruyWl/gpw2cq20ke1Xm1AyBId82c1/KdEepryrVSh2FF/hW5Q/5GlfGk3uBFeTbLSGb/3Q24fOFga4EmEcG8ZJYXUkTJ60CamDTISyRGCKZ72JhJsvd/MmdHOoI3W/YQe/s7iDF9JSE2YLn8dVl1UIppPJXqzOc6K7xg1f0iCYyFx6uJL6cKMtR3LyNmT+YOx8RPZC72K3jxrqwmQlJ4GcLmIuZtlD/fxJWR3aBmw0AZI2ksOyscbiS97/hiSJNA8kqzREOIk6MmSjo6eJ8FBxYqwFJf/i0rCeBw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <44e0ab16-e807-c8f5-deef-7094b7aecdeb@suse.com>
Date: Thu, 17 Feb 2022 11:20:49 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v2 04/70] x86/pv-shim: Don't modify the hypercall table
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
CC: Juergen Gross <jgross@suse.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
 <20220214125127.17985-5-andrew.cooper3@citrix.com>
 <4d8ab414-caf4-5a12-4cb7-a88c633cfd66@suse.com>
 <e18c0c5a-d00b-adf9-d4b0-28e702a18241@srcf.net>
 <6566bf52-58da-f804-f5c2-fca64c1f150c@suse.com>
 <f0889e93-aec0-443e-b3fc-081892edaf2b@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <f0889e93-aec0-443e-b3fc-081892edaf2b@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6PR08CA0047.eurprd08.prod.outlook.com
 (2603:10a6:20b:c0::35) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7d79aebf-8883-4afa-22a6-08d9f1ff2c36
X-MS-TrafficTypeDiagnostic: DB8PR04MB6748:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<DB8PR04MB6748104038F6F065A131C69BB3369@DB8PR04MB6748.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	DMKCms0Y8V1uTSqwlURtgVvYmRo/+Ok+lNjBtW4oh7E2xZBUvZP0R9s+fG4rpHWoQYaNeJ7rmfIlLQPkKQ9RjcNH2fjdLV/5Wcmr4giTS9BMrcbIxDK9kwrEDSJo+q/zNG57PFyp8PsEw6TJbNgoC14KnJ+cjiXA4zNgxpOkAFnx3hssRq6q7CuZqFJzLz0IwyiwaEZQjm8CRuMECW5k1vQn7ajmrZQtbzBwQvpYvvzV/7Z0Ld3JXfntstNk/OIXH2zDSCQiXbYkKO8JZH7+c+9KKJ65VLL+qaICxiJnU8xO8ibe3GFBbqfwXpXcR3jOT3nqhwzNGbZzHW2buRRM6D1b4FvdikfKC9rJdJx7xmIZR2Taszq8wDu4azqp2XMBBfCPVoN6HcUckNfj9ZNtJ9vVM/TwNhFo2V0HX/RUgCd36pTVaZ7/AUEZa0WphUIBoP50eju/k0ZnPyQRD06oqLfGiqCCJSa/+F2Om0e/BffO6q13yPeXzrpWlbTRg8FeqUfuSskgWe8XkShYy0yW+ENuCb8p4OqhJkUH69NQuT+RMz25SYG8W1AvgAV8/4R1kldj4KCo5j+DE26q9Z1BdKIMHvenizWxgBt8c1DuX/I5JBlTLPdODHxDldk5THFgg/mHYzSTQMniTdKVwHys8q/LvhnNoxBoXooQh6GAZeao6AG2NkmT64Egz+jGupgXpImfPbzjP1uhdcBgrH07n8CjjHQOh+/eLSX8Ly4OCCf/Pxa7ot1oN9iqHehJhifB
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66476007)(6916009)(31686004)(6512007)(316002)(186003)(4326008)(66556008)(5660300002)(2906002)(66946007)(54906003)(36756003)(8936002)(8676002)(508600001)(6486002)(38100700002)(53546011)(83380400001)(31696002)(66574015)(86362001)(26005)(6506007)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?oFSpJlTEnRhxlI79Y+WOm7TwDP7XUbIVNn9SrO3xDTcpEhqKom/bi+0Djigu?=
 =?us-ascii?Q?2o6rh6QlJebbVb7+k5rXU6l+PdAw5PqAugOAFfJRIdOYcaaVl+zjgc0rwwxX?=
 =?us-ascii?Q?tX7Fe7GOjypIRV8GaobrEeKfLAHbQiChI3HPIikYlq6OrR3/Xqv8dnFvdPTd?=
 =?us-ascii?Q?jJIp8Xj2/yZVH4uJR7nmKecxSd1qYjKzxebkKUDVSOSwS24nuWNsjCDErNhn?=
 =?us-ascii?Q?hNx1349xUo/dt1ejfJiWLmHxVtm4tTQdLjXnJFhCgeS2FVMgpX3CBVIMJZQc?=
 =?us-ascii?Q?lnhVxdR2xZD8I8vYK3MsBDxXgWvfzkgWrTBgHSs7qBViYzPZ0R2iRSEBpFzN?=
 =?us-ascii?Q?hZKJDMrtB8ea2rLt3TKs2w54nS/622nPC+OhRM0Jenx1XbKM+bwctGVcu8yy?=
 =?us-ascii?Q?vuSxHY5wa2MpPpf92nTJBmVKPKt1VtI2uGA0dOO2iNEg9brMhXLHv2glRUyP?=
 =?us-ascii?Q?4FZj9xQadXY5+/o7FdMOIO1/FNIt+C7oLq3wxj9uTd8IhH5u0KnI+J/xBCMV?=
 =?us-ascii?Q?VQLKz2JRpTC8kjs6Izdx53Q/Dr9edaQkk2rkvVx/Jh40/4zof9//jMuQ/+2f?=
 =?us-ascii?Q?y4fGAJh61AZjJURORTZLI6LmMKueWmeIcegnBe5h4B8DSZbgOnOwEVNstxW4?=
 =?us-ascii?Q?TQjZZEcceOpBV4ICf8BtV5qN0MqqUNgz9nXLznoV3ENGODBKjfQfjSv0H0EY?=
 =?us-ascii?Q?Ky7jrLRHwabHLvOLyJJXq07kldGzKJCBxnHbm4d4NaxromJqwOGiLsZV8Jbj?=
 =?us-ascii?Q?btKrSUZVaxy+vA6iVaKiyV6vPFL8PXiEUTfeXMoT1W53aknyCJLZ7ewbg/7U?=
 =?us-ascii?Q?aDtU6J8+laBpIHL3z3gXvBLtlMOZhq+IB1jdAqsqFt2Y+yIQUTBPj69e6A9u?=
 =?us-ascii?Q?/jjGoBdGRbIlngiYn8EoXaOS19eV+k+2dz7YW/CwmsvxHTjjvNBVr0hu/0gX?=
 =?us-ascii?Q?nQp0vute1W79YIfeNdlmFSsbLImZySXTDnqyo+mt+FBfci1DpSLuj0onfOf9?=
 =?us-ascii?Q?66lYuU+0ZEuoiz/MSmBUgXbBTukRnlm82FlQ6Kf+kNfGD9hAeeL9qy4ubRWx?=
 =?us-ascii?Q?e+6UaPtTuzxq8Xcm2Ls9JEtcKUkLuSMbx4eBp1TZ+djVtMJC3yEFyTeHTIko?=
 =?us-ascii?Q?vhWFGjd+QzAHeiC7BVcZDa1At/lbTwfVloG6NRV935u47q1TAJHfqXCfotMY?=
 =?us-ascii?Q?tIGU44hhRBph2z33eyAfGaK3B/k0mpmjQgyBuvs6qv0y0PaOEcGaGsAd0SGu?=
 =?us-ascii?Q?Bh54k134wgl7PAUzHhuGU0tI6bF0g9kVMbA7sO2CrfhKhMFkyv6dYyDIO/pE?=
 =?us-ascii?Q?Yfqmh6eIoIO9C3K2Djuxi+3t9ehv4ze9Dh+EVuScT3Va3RlisT3GFpwc0his?=
 =?us-ascii?Q?B+xflu+ZHBeiFnF+1uqvQmTAZ0lywGEtgNZN25POlEmy3oVCQY1GCoCW040n?=
 =?us-ascii?Q?x7TrbJJk64cqH2P3PZkJQa2p6r8JxwXjZ7HUk844NFhrHVU2HApbPAQbWbZ2?=
 =?us-ascii?Q?aWykLFa70XDKhLwQnG9l/NTqbk3wgh34WmxYRajZ8ekRszU0+Upxaa8OMLTx?=
 =?us-ascii?Q?4kDASMm4f/nF066UD0kaIMLKoS+R5qZUCx+hTp5JtTprj0Z8CnciryOsb3RF?=
 =?us-ascii?Q?//t7Ys6VbAbCIe/lq610B/w=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7d79aebf-8883-4afa-22a6-08d9f1ff2c36
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2022 10:20:51.2366
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HTjC5erxGQDtEJMSVcfTR3MOeEa6i9TnJl0VPTNcUEirYKEf5kPZBndw5KhAF3zugxdr2FkzntsltbXyrp3Ykg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6748

On 16.02.2022 23:17, Andrew Cooper wrote:
> On 14/02/2022 13:56, Jan Beulich wrote:
>> On 14.02.2022 14:50, Andrew Cooper wrote:
>>> On 14/02/2022 13:33, Jan Beulich wrote:
>>>> On 14.02.2022 13:50, Andrew Cooper wrote:
>>>>> From: Juergen Gross <jgross@suse.com>
>>>>>
>>>>> When running as pv-shim the hypercall is modified today in order to
>>>>> replace the functions for __HYPERVISOR_event_channel_op and
>>>>> __HYPERVISOR_grant_table_op hypercalls.
>>>>>
>>>>> Change this to call the related functions from the normal handlers
>>>>> instead when running as shim. The performance implications are not
>>>>> really relevant, as a normal production hypervisor will not be
>>>>> configured to support shim mode, so the related calls will be dropped
>>>>> due to optimization of the compiler.
>>>>>
>>>>> Note that for the CONFIG_PV_SHIM_EXCLUSIVE case there is a dummy
>>>>> wrapper do_grant_table_op() needed, as in this case grant_table.c
>>>>> isn't being built.
>>>>>
>>>>> Signed-off-by: Juergen Gross <jgross@suse.com>
>>>>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>>>> I don't think you sync-ed this with J=C3=BCrgen's v3. There were only =
minor
>>>> changes but having a stale version sent two months later isn't very
>>>> nice.
>>> I did resync.=C2=A0 What do you think is missing?
>> A few likely() / unlikely() as far as I could see.
>=20
> Oh those two.=C2=A0 I appear to have forgot to email.
>=20
> They're wrong - observe they're in an ifndef block, not an ifdef block.=
=C2=A0

I don't see how the (unrelated) #ifndef matters here: The #ifndef
is about grant table availability. The two likely() are about
running as shim. I'm of the firm opinion that a binary built
without PV_SHIM_EXCLUSIVE is far more likely to be used as a bare
metal hypervisor. And for a PV_SHIM_EXCLUSIVE hypervisor the
conditions are constant anyway, and hence the unlikely() has no
effect.

And if your way should really be followed, why did you deem the two
unlikely() in do_event_channel_op() and do_grant_table_op() okay?

>>>>> --- a/xen/common/compat/multicall.c
>>>>> +++ b/xen/common/compat/multicall.c
>>>>> @@ -5,7 +5,7 @@
>>>>>  EMIT_FILE;
>>>>> =20
>>>>>  #include <xen/types.h>
>>>>> -#include <xen/multicall.h>
>>>>> +#include <xen/hypercall.h>
>>>>>  #include <xen/trace.h>
>>>>> =20
>>>>>  #define COMPAT
>>>>> @@ -19,7 +19,6 @@ static inline void xlat_multicall_entry(struct mc_s=
tate *mcs)
>>>>>          mcs->compat_call.args[i] =3D mcs->call.args[i];
>>>>>  }
>>>>> =20
>>>>> -DEFINE_XEN_GUEST_HANDLE(multicall_entry_compat_t);
>>>>>  #define multicall_entry      compat_multicall_entry
>>>>>  #define multicall_entry_t    multicall_entry_compat_t
>>>>>  #define do_multicall_call    compat_multicall_call
>>>> J=C3=BCrgen's patch doesn't have any change to this file, and I'm afra=
id I
>>>> also don't see how these adjustments are related here. The commit
>>>> message sadly also doesn't help ...
>>> The changes are very necessary to split it out of Juergen's series.
>>>
>>> Without the adjustment, the correction of compat_platform_op()'s guest
>>> handle type from void to compat_platform_op_t doesn't compile.
>> Interesting. That's quite far from obvious in this context, so clarifyin=
g
>> the purpose in the description would seem helpful.
>>
>> Coming back to the syncing with v3: Was this change the reason then why
>> you did drop my R-b?
>=20
> My porting of this patch is a non-trivial modification from Juergen's
> version, and not eligible to retain any tags.
>=20
> I thought I'd discussed this, but I appear to have missed it from both
> versions of the series.=C2=A0 Sorry.
>=20
> Either way.=C2=A0 It's exactly the same purpose as before, but modified t=
o
> compile in isolation.

I see. I'm under the impression though that parts were effectively
present elsewhere in J=C3=BCrgen's series. Perhaps it would have been easie=
r
if his series (at least up to the point to which you need it here)
would (long) have gone in already. What it looks to be blocked on are
two or three Arm acks and an x86 ack on patch 1 (which I've expressed
I'm not entirely happy about, and hence I'm not going to either ack or
nack it).

Jan



From xen-devel-bounces@lists.xenproject.org Thu Feb 17 10:34:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 17 Feb 2022 10:34:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274604.470125 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKe7E-0007yL-Gy; Thu, 17 Feb 2022 10:34:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274604.470125; Thu, 17 Feb 2022 10:34:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKe7E-0007yE-Dv; Thu, 17 Feb 2022 10:34:24 +0000
Received: by outflank-mailman (input) for mailman id 274604;
 Thu, 17 Feb 2022 10:34:23 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9h7v=TA=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nKe7C-0007y8-TR
 for xen-devel@lists.xenproject.org; Thu, 17 Feb 2022 10:34:23 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 29d8b545-8fdd-11ec-b215-9bbe72dcb22c;
 Thu, 17 Feb 2022 11:34:19 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 2E2701F383;
 Thu, 17 Feb 2022 10:34:21 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 04B1313DD8;
 Thu, 17 Feb 2022 10:34:20 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id M3CaOqwkDmLrQgAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 17 Feb 2022 10:34:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 29d8b545-8fdd-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1645094061; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=tzOPpUpRF2XYpvTTZJG459hyrAZp/dMMpSBvT6SUPjY=;
	b=hNsDtZEKpoRXeOF9iXKS7SHTzBgvKDjcXoSNVhWqWwEXoGLrz0qotPJU7+nioiVTWzWp3p
	VhkQMJZO+eRvRC2MPpOisLNY2RCaJqnS6/U/3f+fiwyB6RnQ/Dc2sOHMJBGbTyQJYnYUyu
	BlRTScddI3R1YHmcHihf+L+5F79cKVM=
Message-ID: <c07cb7f8-c936-c383-a860-045e80e2f1ef@suse.com>
Date: Thu, 17 Feb 2022 11:34:20 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Subject: Re: [PATCH v2 04/70] x86/pv-shim: Don't modify the hypercall table
Content-Language: en-US
To: Jan Beulich <jbeulich@suse.com>, Andrew Cooper <Andrew.Cooper3@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
 <20220214125127.17985-5-andrew.cooper3@citrix.com>
 <4d8ab414-caf4-5a12-4cb7-a88c633cfd66@suse.com>
 <e18c0c5a-d00b-adf9-d4b0-28e702a18241@srcf.net>
 <6566bf52-58da-f804-f5c2-fca64c1f150c@suse.com>
 <f0889e93-aec0-443e-b3fc-081892edaf2b@citrix.com>
 <44e0ab16-e807-c8f5-deef-7094b7aecdeb@suse.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <44e0ab16-e807-c8f5-deef-7094b7aecdeb@suse.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------NZKW2d7QF00sRdPyh4O1WjAX"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------NZKW2d7QF00sRdPyh4O1WjAX
Content-Type: multipart/mixed; boundary="------------kPcR8pGmh0Zy8xLeFkw0PIxt";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <jbeulich@suse.com>, Andrew Cooper <Andrew.Cooper3@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>
Message-ID: <c07cb7f8-c936-c383-a860-045e80e2f1ef@suse.com>
Subject: Re: [PATCH v2 04/70] x86/pv-shim: Don't modify the hypercall table
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
 <20220214125127.17985-5-andrew.cooper3@citrix.com>
 <4d8ab414-caf4-5a12-4cb7-a88c633cfd66@suse.com>
 <e18c0c5a-d00b-adf9-d4b0-28e702a18241@srcf.net>
 <6566bf52-58da-f804-f5c2-fca64c1f150c@suse.com>
 <f0889e93-aec0-443e-b3fc-081892edaf2b@citrix.com>
 <44e0ab16-e807-c8f5-deef-7094b7aecdeb@suse.com>
In-Reply-To: <44e0ab16-e807-c8f5-deef-7094b7aecdeb@suse.com>

--------------kPcR8pGmh0Zy8xLeFkw0PIxt
Content-Type: multipart/mixed; boundary="------------2c7yhqEgFNzU80kJwQJpSSoC"

--------------2c7yhqEgFNzU80kJwQJpSSoC
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMTcuMDIuMjIgMTE6MjAsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAxNi4wMi4yMDIy
IDIzOjE3LCBBbmRyZXcgQ29vcGVyIHdyb3RlOg0KPj4gT24gMTQvMDIvMjAyMiAxMzo1Niwg
SmFuIEJldWxpY2ggd3JvdGU6DQo+Pj4gT24gMTQuMDIuMjAyMiAxNDo1MCwgQW5kcmV3IENv
b3BlciB3cm90ZToNCj4+Pj4gT24gMTQvMDIvMjAyMiAxMzozMywgSmFuIEJldWxpY2ggd3Jv
dGU6DQo+Pj4+PiBPbiAxNC4wMi4yMDIyIDEzOjUwLCBBbmRyZXcgQ29vcGVyIHdyb3RlOg0K
Pj4+Pj4+IEZyb206IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4NCj4+Pj4+Pg0K
Pj4+Pj4+IFdoZW4gcnVubmluZyBhcyBwdi1zaGltIHRoZSBoeXBlcmNhbGwgaXMgbW9kaWZp
ZWQgdG9kYXkgaW4gb3JkZXIgdG8NCj4+Pj4+PiByZXBsYWNlIHRoZSBmdW5jdGlvbnMgZm9y
IF9fSFlQRVJWSVNPUl9ldmVudF9jaGFubmVsX29wIGFuZA0KPj4+Pj4+IF9fSFlQRVJWSVNP
Ul9ncmFudF90YWJsZV9vcCBoeXBlcmNhbGxzLg0KPj4+Pj4+DQo+Pj4+Pj4gQ2hhbmdlIHRo
aXMgdG8gY2FsbCB0aGUgcmVsYXRlZCBmdW5jdGlvbnMgZnJvbSB0aGUgbm9ybWFsIGhhbmRs
ZXJzDQo+Pj4+Pj4gaW5zdGVhZCB3aGVuIHJ1bm5pbmcgYXMgc2hpbS4gVGhlIHBlcmZvcm1h
bmNlIGltcGxpY2F0aW9ucyBhcmUgbm90DQo+Pj4+Pj4gcmVhbGx5IHJlbGV2YW50LCBhcyBh
IG5vcm1hbCBwcm9kdWN0aW9uIGh5cGVydmlzb3Igd2lsbCBub3QgYmUNCj4+Pj4+PiBjb25m
aWd1cmVkIHRvIHN1cHBvcnQgc2hpbSBtb2RlLCBzbyB0aGUgcmVsYXRlZCBjYWxscyB3aWxs
IGJlIGRyb3BwZWQNCj4+Pj4+PiBkdWUgdG8gb3B0aW1pemF0aW9uIG9mIHRoZSBjb21waWxl
ci4NCj4+Pj4+Pg0KPj4+Pj4+IE5vdGUgdGhhdCBmb3IgdGhlIENPTkZJR19QVl9TSElNX0VY
Q0xVU0lWRSBjYXNlIHRoZXJlIGlzIGEgZHVtbXkNCj4+Pj4+PiB3cmFwcGVyIGRvX2dyYW50
X3RhYmxlX29wKCkgbmVlZGVkLCBhcyBpbiB0aGlzIGNhc2UgZ3JhbnRfdGFibGUuYw0KPj4+
Pj4+IGlzbid0IGJlaW5nIGJ1aWx0Lg0KPj4+Pj4+DQo+Pj4+Pj4gU2lnbmVkLW9mZi1ieTog
SnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPg0KPj4+Pj4+IFNpZ25lZC1vZmYtYnk6
IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+DQo+Pj4+PiBJIGRv
bid0IHRoaW5rIHlvdSBzeW5jLWVkIHRoaXMgd2l0aCBKw7xyZ2VuJ3MgdjMuIFRoZXJlIHdl
cmUgb25seSBtaW5vcg0KPj4+Pj4gY2hhbmdlcyBidXQgaGF2aW5nIGEgc3RhbGUgdmVyc2lv
biBzZW50IHR3byBtb250aHMgbGF0ZXIgaXNuJ3QgdmVyeQ0KPj4+Pj4gbmljZS4NCj4+Pj4g
SSBkaWQgcmVzeW5jLsKgIFdoYXQgZG8geW91IHRoaW5rIGlzIG1pc3Npbmc/DQo+Pj4gQSBm
ZXcgbGlrZWx5KCkgLyB1bmxpa2VseSgpIGFzIGZhciBhcyBJIGNvdWxkIHNlZS4NCj4+DQo+
PiBPaCB0aG9zZSB0d28uwqAgSSBhcHBlYXIgdG8gaGF2ZSBmb3Jnb3QgdG8gZW1haWwuDQo+
Pg0KPj4gVGhleSdyZSB3cm9uZyAtIG9ic2VydmUgdGhleSdyZSBpbiBhbiBpZm5kZWYgYmxv
Y2ssIG5vdCBhbiBpZmRlZiBibG9jay4NCj4gDQo+IEkgZG9uJ3Qgc2VlIGhvdyB0aGUgKHVu
cmVsYXRlZCkgI2lmbmRlZiBtYXR0ZXJzIGhlcmU6IFRoZSAjaWZuZGVmDQo+IGlzIGFib3V0
IGdyYW50IHRhYmxlIGF2YWlsYWJpbGl0eS4gVGhlIHR3byBsaWtlbHkoKSBhcmUgYWJvdXQN
Cj4gcnVubmluZyBhcyBzaGltLiBJJ20gb2YgdGhlIGZpcm0gb3BpbmlvbiB0aGF0IGEgYmlu
YXJ5IGJ1aWx0DQo+IHdpdGhvdXQgUFZfU0hJTV9FWENMVVNJVkUgaXMgZmFyIG1vcmUgbGlr
ZWx5IHRvIGJlIHVzZWQgYXMgYSBiYXJlDQo+IG1ldGFsIGh5cGVydmlzb3IuIEFuZCBmb3Ig
YSBQVl9TSElNX0VYQ0xVU0lWRSBoeXBlcnZpc29yIHRoZQ0KPiBjb25kaXRpb25zIGFyZSBj
b25zdGFudCBhbnl3YXksIGFuZCBoZW5jZSB0aGUgdW5saWtlbHkoKSBoYXMgbm8NCj4gZWZm
ZWN0Lg0KPiANCj4gQW5kIGlmIHlvdXIgd2F5IHNob3VsZCByZWFsbHkgYmUgZm9sbG93ZWQs
IHdoeSBkaWQgeW91IGRlZW0gdGhlIHR3bw0KPiB1bmxpa2VseSgpIGluIGRvX2V2ZW50X2No
YW5uZWxfb3AoKSBhbmQgZG9fZ3JhbnRfdGFibGVfb3AoKSBva2F5Pw0KPiANCj4+Pj4+PiAt
LS0gYS94ZW4vY29tbW9uL2NvbXBhdC9tdWx0aWNhbGwuYw0KPj4+Pj4+ICsrKyBiL3hlbi9j
b21tb24vY29tcGF0L211bHRpY2FsbC5jDQo+Pj4+Pj4gQEAgLTUsNyArNSw3IEBADQo+Pj4+
Pj4gICBFTUlUX0ZJTEU7DQo+Pj4+Pj4gICANCj4+Pj4+PiAgICNpbmNsdWRlIDx4ZW4vdHlw
ZXMuaD4NCj4+Pj4+PiAtI2luY2x1ZGUgPHhlbi9tdWx0aWNhbGwuaD4NCj4+Pj4+PiArI2lu
Y2x1ZGUgPHhlbi9oeXBlcmNhbGwuaD4NCj4+Pj4+PiAgICNpbmNsdWRlIDx4ZW4vdHJhY2Uu
aD4NCj4+Pj4+PiAgIA0KPj4+Pj4+ICAgI2RlZmluZSBDT01QQVQNCj4+Pj4+PiBAQCAtMTks
NyArMTksNiBAQCBzdGF0aWMgaW5saW5lIHZvaWQgeGxhdF9tdWx0aWNhbGxfZW50cnkoc3Ry
dWN0IG1jX3N0YXRlICptY3MpDQo+Pj4+Pj4gICAgICAgICAgIG1jcy0+Y29tcGF0X2NhbGwu
YXJnc1tpXSA9IG1jcy0+Y2FsbC5hcmdzW2ldOw0KPj4+Pj4+ICAgfQ0KPj4+Pj4+ICAgDQo+
Pj4+Pj4gLURFRklORV9YRU5fR1VFU1RfSEFORExFKG11bHRpY2FsbF9lbnRyeV9jb21wYXRf
dCk7DQo+Pj4+Pj4gICAjZGVmaW5lIG11bHRpY2FsbF9lbnRyeSAgICAgIGNvbXBhdF9tdWx0
aWNhbGxfZW50cnkNCj4+Pj4+PiAgICNkZWZpbmUgbXVsdGljYWxsX2VudHJ5X3QgICAgbXVs
dGljYWxsX2VudHJ5X2NvbXBhdF90DQo+Pj4+Pj4gICAjZGVmaW5lIGRvX211bHRpY2FsbF9j
YWxsICAgIGNvbXBhdF9tdWx0aWNhbGxfY2FsbA0KPj4+Pj4gSsO8cmdlbidzIHBhdGNoIGRv
ZXNuJ3QgaGF2ZSBhbnkgY2hhbmdlIHRvIHRoaXMgZmlsZSwgYW5kIEknbSBhZnJhaWQgSQ0K
Pj4+Pj4gYWxzbyBkb24ndCBzZWUgaG93IHRoZXNlIGFkanVzdG1lbnRzIGFyZSByZWxhdGVk
IGhlcmUuIFRoZSBjb21taXQNCj4+Pj4+IG1lc3NhZ2Ugc2FkbHkgYWxzbyBkb2Vzbid0IGhl
bHAgLi4uDQo+Pj4+IFRoZSBjaGFuZ2VzIGFyZSB2ZXJ5IG5lY2Vzc2FyeSB0byBzcGxpdCBp
dCBvdXQgb2YgSnVlcmdlbidzIHNlcmllcy4NCj4+Pj4NCj4+Pj4gV2l0aG91dCB0aGUgYWRq
dXN0bWVudCwgdGhlIGNvcnJlY3Rpb24gb2YgY29tcGF0X3BsYXRmb3JtX29wKCkncyBndWVz
dA0KPj4+PiBoYW5kbGUgdHlwZSBmcm9tIHZvaWQgdG8gY29tcGF0X3BsYXRmb3JtX29wX3Qg
ZG9lc24ndCBjb21waWxlLg0KPj4+IEludGVyZXN0aW5nLiBUaGF0J3MgcXVpdGUgZmFyIGZy
b20gb2J2aW91cyBpbiB0aGlzIGNvbnRleHQsIHNvIGNsYXJpZnlpbmcNCj4+PiB0aGUgcHVy
cG9zZSBpbiB0aGUgZGVzY3JpcHRpb24gd291bGQgc2VlbSBoZWxwZnVsLg0KPj4+DQo+Pj4g
Q29taW5nIGJhY2sgdG8gdGhlIHN5bmNpbmcgd2l0aCB2MzogV2FzIHRoaXMgY2hhbmdlIHRo
ZSByZWFzb24gdGhlbiB3aHkNCj4+PiB5b3UgZGlkIGRyb3AgbXkgUi1iPw0KPj4NCj4+IE15
IHBvcnRpbmcgb2YgdGhpcyBwYXRjaCBpcyBhIG5vbi10cml2aWFsIG1vZGlmaWNhdGlvbiBm
cm9tIEp1ZXJnZW4ncw0KPj4gdmVyc2lvbiwgYW5kIG5vdCBlbGlnaWJsZSB0byByZXRhaW4g
YW55IHRhZ3MuDQo+Pg0KPj4gSSB0aG91Z2h0IEknZCBkaXNjdXNzZWQgdGhpcywgYnV0IEkg
YXBwZWFyIHRvIGhhdmUgbWlzc2VkIGl0IGZyb20gYm90aA0KPj4gdmVyc2lvbnMgb2YgdGhl
IHNlcmllcy7CoCBTb3JyeS4NCj4+DQo+PiBFaXRoZXIgd2F5LsKgIEl0J3MgZXhhY3RseSB0
aGUgc2FtZSBwdXJwb3NlIGFzIGJlZm9yZSwgYnV0IG1vZGlmaWVkIHRvDQo+PiBjb21waWxl
IGluIGlzb2xhdGlvbi4NCj4gDQo+IEkgc2VlLiBJJ20gdW5kZXIgdGhlIGltcHJlc3Npb24g
dGhvdWdoIHRoYXQgcGFydHMgd2VyZSBlZmZlY3RpdmVseQ0KPiBwcmVzZW50IGVsc2V3aGVy
ZSBpbiBKw7xyZ2VuJ3Mgc2VyaWVzLiBQZXJoYXBzIGl0IHdvdWxkIGhhdmUgYmVlbiBlYXNp
ZXINCj4gaWYgaGlzIHNlcmllcyAoYXQgbGVhc3QgdXAgdG8gdGhlIHBvaW50IHRvIHdoaWNo
IHlvdSBuZWVkIGl0IGhlcmUpDQo+IHdvdWxkIChsb25nKSBoYXZlIGdvbmUgaW4gYWxyZWFk
eS4gV2hhdCBpdCBsb29rcyB0byBiZSBibG9ja2VkIG9uIGFyZQ0KPiB0d28gb3IgdGhyZWUg
QXJtIGFja3MgYW5kIGFuIHg4NiBhY2sgb24gcGF0Y2ggMSAod2hpY2ggSSd2ZSBleHByZXNz
ZWQNCj4gSSdtIG5vdCBlbnRpcmVseSBoYXBweSBhYm91dCwgYW5kIGhlbmNlIEknbSBub3Qg
Z29pbmcgdG8gZWl0aGVyIGFjayBvcg0KPiBuYWNrIGl0KS4NCg0KVGhlIG1haW4gYmxvY2tp
bmcgcG9pbnQgY3VycmVudGx5IGlzIHRoYXQgSnVsaWVuIHdvdWxkIGxpa2UgbWUgdG8gbGV0
DQphbGwgaHlwZXJjYWxscyByZXR1cm4gYW4gaW50IChhcGFydCBmcm9tIHRoZSBvbmVzIHdo
aWNoIHJlYWxseSBuZWVkDQphIGxvbmcpLiBUaGlzIHdpbGwgYWZmZWN0IGxvdCBvZiBjb21t
b24gY29kZSBhbmQgSSBuZWVkIHRvIGhhdmUgbW9yZQ0KdGltZSBmb3IgdGhhdCBlbmRlYXZv
ci4NCg0KQW4gYWx0ZXJuYXRpdmUgdG8gdGhhdCB3b3VsZCBiZSB0byBub3QgcmV3b3JrIHRo
ZSBBcm0gc2lkZSBvZiB0aGUNCmh5cGVyY2FsbCBsb2dpYy4NCg0KDQpKdWVyZ2VuDQoNCg==

--------------2c7yhqEgFNzU80kJwQJpSSoC
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------2c7yhqEgFNzU80kJwQJpSSoC--

--------------kPcR8pGmh0Zy8xLeFkw0PIxt--

--------------NZKW2d7QF00sRdPyh4O1WjAX
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmIOJKwFAwAAAAAACgkQsN6d1ii/Ey8c
tQf/bjQZ7MXx1JP1V14FeQuhOKIr53q5CLj/dxsPqUGV+C6HndnV/zqDYEgqWm63WXk10OsIKTlM
c7DRKoaaaysV1wGtBbWh3evhhnFGflUaIN4r3NQn138OkKRrGCxEkDJe3X+aSlGixuZ1ZrLfmnVm
Nrjf5b14WOJFrVbQK1ejQ+JzTeW06kH3Fi9NFzFRnI+SVBTWv8km7g2MsiGcDnTWJz4l/5fScYe3
dVVOyF09xhfQOkHz89CCDXg3kCORapZHkPbfJUuF03H8T0bO5aIckHdjXgcF6UHdnM7M9Elz+zNG
7bY4ReDOr+CdsDXBg5YeQeOAPBjKfBPzdSKoEHt4Qw==
=MjBf
-----END PGP SIGNATURE-----

--------------NZKW2d7QF00sRdPyh4O1WjAX--


From xen-devel-bounces@lists.xenproject.org Thu Feb 17 10:34:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 17 Feb 2022 10:34:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274606.470136 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKe7h-0008Nw-Qg; Thu, 17 Feb 2022 10:34:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274606.470136; Thu, 17 Feb 2022 10:34:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKe7h-0008Np-Md; Thu, 17 Feb 2022 10:34:53 +0000
Received: by outflank-mailman (input) for mailman id 274606;
 Thu, 17 Feb 2022 10:34:52 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=A/h9=TA=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nKe7g-0007y8-5G
 for xen-devel@lists.xenproject.org; Thu, 17 Feb 2022 10:34:52 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3a6ea88b-8fdd-11ec-b215-9bbe72dcb22c;
 Thu, 17 Feb 2022 11:34:48 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3a6ea88b-8fdd-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645094090;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=laCNSC1BYAO2UJbiV9bbtsxcWaNk70Ym0/2POxIQx0E=;
  b=ePcM8H8lpSRhFR31mfZqMgHR0JRugG29ipjkHFj3496AeGZj2sDo5XYm
   kbIdLEvtDliDjMiW97i8cDbB79Oa8BKy/41Bt2ulpfFvnFu5xvPA6D4MZ
   xCS6rz5NWoXKwOBPhvt9kFE8RqbQlaQLnxL8kzk+clAyJB5LfrB74W0Xf
   c=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: jhgwknE7O09vuosLOJewtHlZK1wuY3wm77WxhywGgei7PCvUjl3NxS7MNRSdBafw+Aus0oJRCa
 UM4XT6vNU9Dcy71oIC9gIN4+sY88zl0UUNMLyRPvlkPUErtQDCz1hKDSGWrnyHHoZ07i5BcGpJ
 f5fcbiLrffs3KrKpu28rjJ8osiVU/89OP8P6L8XpPOG4Y6SHvnMEtn27pbq3lQEQe9d4yim1lC
 /Q+clqc0xjMbifDMGb/7vYaAgJY921SlB8vx8mH7cUVPhhF0Aea5wZnXQtEfgvtbn0mSo22NJl
 Nin27tLDhIm2Qo1ES+D+7lQC
X-SBRS: 5.1
X-MesageID: 63860118
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:OXDSmqLMNSD9kfcXFE+RT5IlxSXFcZb7ZxGr2PjKsXjdYENS0GQBz
 DEXWGzXP//eYGX8Ltp2PYnk9BtS6JaDnd9lG1RlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokcxIn5BC5C5xZVG/fjgqoHUVaiUakideSc+EH170Ug6xLZg6mJVqYPR7z2l6
 IuaT/L3YDdJ6xYsWo7Dw/vewP/HlK2aVAIw5jTSV9gS1LPtvyB94KYkDbOwNxPFrrx8RYZWc
 QphIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbrGvaUXe345iXMfwZ3u7hB22rcJ0z
 9IX7aaKVFcSP43Vxf05aBpXRnQW0a1uoNcrIFC6uM2XiUbHb2Ht07NlC0Re0Y8wo7gtRzsUr
 LpBdW5LPkvra+GemdpXTsF2gcsuNo/zNZ43sXB81zDJS/0hRPgvRo2Uvo8GhG5p1qiiG97cV
 ck2S2FFPS3xOTFiK1hUOaMlzei30yyXnzpw9wvO+PtfD3Lo5AZ8yqT3OdzZPNmDX9xIn12wr
 3jDuW/+B3kyK9i32TeDtHW2iYfnjS79HY4fCrC83vprm0GIgHweDgUMUlm2quX/jVSxM/pdI
 UEJ/islrYAp6VemCNL6WnWQomOAvxMac8pdFas98g7l4rHP/w+TC2wATzhAQN8rrsk7QXotz
 FDhoj/yLWUx6vvPEyvbr+rK62PpUcQIEYMcTRA2Xw4C5IO7mrsu3inObs8+CYqOjdKgTFkc3
 Au2hCQ5grwSi+sC2KO64U3LjlqQm3TZcuImzl6JBzz4t2uVcKbgPtX1sgaDsZ6sOa7EFgHpg
 ZQSpySJAAni57mpnTfFfugCFarBCx2tYGyF2g4H83XMGl2QF5+fkWJ4vGAWyKRBaJ9sldrVj
 Kn741w5CHh7ZibCUEOPS9jtY/nGNIC5fTgfatjab8BVfr96fxKd8SdlaCa4hj6xzRB3zv9jZ
 MzELK5A6Er274w9k1JaoM9HjNcWKt0WnzuPFfgXMTz8uVZhWJJlYehcawbfBgzIxKiFvB/U4
 75i2ziikH1ivBnFSnCPq+Y7dAlSRVBiXMyeg5EHJ4arf1s9cEl8WqC5/F/UU9E890ijvryTp
 S/Vt44x4AeXuEAr3i3ROyo8Nu2+BsckxZ/5VAR1VWuVN7EYSd/HxI8UdoctfKlh8+pmzPVuS
 OICddnGCfNKIgkrMRxEBXUkhIA9JhmtmyyUOC+pPGo2c5J6HlSb8d74ZAr/siIJC3Pv58c5p
 rSh0CLdQIYCGFs+XJqHNqr3wgPjp2UZlcJzQ1DMfotZdnLz/dU4MCf2lPI2fZ0BcE2R2juA2
 g+KKh4Evu2R8ZQt+dzEiPnc/YekGudzBGRAGGzf4erkPCXW5DP7k4RBTPyJbXbWU2atoPeuY
 uBczvfdNvwbnQkV79ogQugzla9nvonhvb5XyAhgDU7nVVXzB+MyOGSC0OlOqrZJmu1TtzypV
 x/d4dJdI7iIZp/oSQZDOAo/Y+2f/vgIgT2Ov+8tKUD36SIrrrqKVUJeY0uFhCBHdeYnNYokx
 aEqudIM6hz5gR0va47UgidR/mWKD3oBT6R46c1KXN610lImmgNYfJjRKi7q+5XeOdxDP34jL
 iKQmKef1a9XwVDPciZrGHXAtQaHaU/iZPyeIIc+Gmm0
IronPort-HdrOrdr: A9a23:fJAqoapb2mWdhtg5sEeWHBkaV5uxL9V00zEX/kB9WHVpm5Oj+f
 xGzc516farslossREb+expOMG7MBXhHLpOkPQs1NCZLXXbUQqTXftfBO7ZogEIdBeOk9K1uZ
 0QF5SWTeeAcmSS7vyKkDVQcexQuOVvmZrA7Yy1ogYPPGNXguNbnnxE426gYzxLrWJ9dOME/f
 Snl616T23KQwVoUi33PAhOY8Hz4/nw0L72ax8PABAqrCGIkDOT8bb/VzyVxA0XXT9jyaortT
 GtqX202oyT99WAjjPM3W7a6Jpb3PPn19t4HcSJzuwYMC/lhAqEbJloH5eCoDc2iuey70tCqq
 iAnz4Qe+BIr1/BdGC8phXgnyHmzTYV8nfnjWSVhHPyyPaJDQ4SOo5kv8Z0YxHZ400vsJVXy6
 RQxV+UsJJREFfpgDn9z8KgbWAqqmOE5V4Z1cIDhX1WVoUTLJVLq5YEwU9TGJAcWArn9YEcFv
 V0Bs203ocZTbqjVQGbgoBT+q3vYpxqdS32B3Tq+/blnAS+pUoJj3fxn6ck7zM9HJFUcegz2w
 2LCNUuqFh0dL5lUUtKPpZ3fSKGMB2/ffvyChPmHb3GLtBOB5ufke+93F0KjNvaDKDgiqFC3q
 j8bA==
X-IronPort-AV: E=Sophos;i="5.88,375,1635220800"; 
   d="scan'208";a="63860118"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Lxgis4sOxLOq/CLc/1A4V65Rz1ivzTY+OxbEApIJfxOXwwqNlmzchh1/hIte+S9NK8cpRPcA8gi6XdJPS5qvWjsyjBAQ6RzpgJaTbN8G/zTLTmvKcu7g4ScDdPq8BLmihWHif5R+fMNdF4E7iIpD8xixjb2bqILG6h298O7YdS1cHxKhR7z+yWPR4OI10REoiZL+JsZUdRxgIsI+JN5wd07Bi5aPcWqSv622N9bsReLRWzUDOn8JjRXSx3j4Yfqxx8Dx51iuGRnNdV0psthxUK2cqD+rDfIpNt0TDebPvjdZQMniBbS1a27dGZhCCduqZ32sY96hPe+MNtWw+IuiHg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=L5oYhkmLmM+trtw5ccrjv11z5sGlM9gOJ4043XAXVxs=;
 b=gfIA6ICeSCsc/5Fw1EHLF2t9VfsUMYDBn+rf/4oBgoufMuCh4MinnSqfxqSmBoO2hQ/bZ9T/NGaMDnmaxjXO88McONJDXGc7MVOXwDbjct/ch3uD4LLJKo+M+qiWPw7lDJaiLR49JMcViSq1e1HmewFCcdR/UEUQAzVfqJ+XI0tXqzmkYO0DedhodRJu6CgCjXT6KGtqqyWGjo4RmppxiQGfQp6S4rtP3hxF37MXIHpSIStIFbPexvyBprO53NBvhNJ6wvuGeVKhoCmxvcwdTm27N6RiqCPPJM692GetO2mlkCbLTiWze0yjiBrP2jHRWQxynF5aLHgAFnFOB4+kCw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=L5oYhkmLmM+trtw5ccrjv11z5sGlM9gOJ4043XAXVxs=;
 b=HfT4BgUu0+j5+xYEitM4GJjPNk/9+i9Dfvlei+2K0H+91ZsPW+goNFMP2pB6sEIGCL+M4R5VLN2/83gK8jss8AfpNZrI4yOaPv9348RWWhNX//5ICNrL7EfOP99iakKXRSQkokw9EW6ifDFsaIX4AkfbpHLK2hAregHjBuys6k4=
Date: Thu, 17 Feb 2022 11:34:40 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Julien Grall <julien@xen.org>, Stefano Stabellini
	<sstabellini@kernel.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
	"Andrew Cooper" <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>, George
 Dunlap <george.dunlap@citrix.com>, <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2 3/3] x86/Kconfig: introduce option to select retpoline
 usage
Message-ID: <Yg4kwK7XJJPNXUD7@Air-de-Roger>
References: <20220216162142.15384-1-roger.pau@citrix.com>
 <20220216162142.15384-4-roger.pau@citrix.com>
 <b6dc1214-4f1d-f7df-50c4-d357a2380b30@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <b6dc1214-4f1d-f7df-50c4-d357a2380b30@suse.com>
X-ClientProxiedBy: LO4P265CA0033.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:2ae::6) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 872ad875-2f19-4de9-a75c-08d9f2011ce4
X-MS-TrafficTypeDiagnostic: SN6PR03MB3856:EE_
X-Microsoft-Antispam-PRVS: <SN6PR03MB3856544605D79924FADB5C2C8F369@SN6PR03MB3856.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5236;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: RyRnWxvVZjiSbDaNsq8199Cru00ILnAvdXLi+alL2qjcMkg7p0AOOfkjK8uYPu6/zlgZ7faYrZvWJcDUEIFVqPkQhsUnROLUGukkiERAhmHov4Qf/SaMGlXEXU8BggLkp6PtXQpsKvqcRzKoN4oteNYQyt5oNkIyjsYu1dliQBqjxwEx5q/jvvI4OJiReOHVWWbU2MeWXZ/CePtfHol0mVHgEwAZxgf873vWBhLKUlPlrZJxKUCMXwZzKePhf/myblxW7jJgbN+Jbd5GVW0yZJvSzcqmsGDRLR1eqTEvdSgjC+zDJiYd2O1k5aU3h8W24fLaGTp7rs+Yi019BiBlUFrXiSZblwcwBKQKBzrgEc9t8rfMvVXfQ66fdKwMMOfbXxP8Sd9FJisVP2axrfsuKASuvP6Xre0TVGCASS/W5/E/icyytOCOdPWe50GsqcuM5JdmgA129xb4WHLm5SOu5eyIfsfOWp7oKjXojATlgkeNY4AmaSvpX0gN1NjAJg4e0sWTdBiGs2kOV4N25kexuLKPriyX9d40m82URhrFeLENcmni28NRw4GoKMchw+EumU7y9wdLMeZeSTom3Hp1UkRDLdX0TlokCLVTGMDdgwXFoObzEiPX97ac3qqqAHUUvKnXmfJrexlbjSh99cD2vQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(316002)(6666004)(8936002)(83380400001)(66476007)(66946007)(66556008)(4326008)(6512007)(53546011)(82960400001)(38100700002)(6506007)(33716001)(186003)(26005)(8676002)(2906002)(6916009)(85182001)(54906003)(5660300002)(6486002)(86362001)(508600001)(9686003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S01uUHc0dUJjUWx5OTZVeTVJRlhqbGFka3pNK0R6MndhaWpPOHBFVXBPMzNE?=
 =?utf-8?B?L0dzQ0VoSkF2WE54NEp1SmRSQk1pWEhTNExGSmh3MXpoVm1yZ0Q3MXNBaEwz?=
 =?utf-8?B?VFlGdUwxWDdGYXRVaHBuMktuZGRVTDNRZWxWQmFFTVNKQTRUZ3pHSys1R3VZ?=
 =?utf-8?B?aUgvZzE5RmZDSzloZXRPWEU2bkIxRFBWQlp5dXFvcm9hYlhNdTF2RmYwdStN?=
 =?utf-8?B?NjNrUzVBOVRjdDBwWDBtRlk5NzFuQWtwMEIwamNOazdKblVrTzRWdStvYWx2?=
 =?utf-8?B?eWRDOVhydmF5NERyYm9CSERsSzBqdno5dGlNTlJjQmZlS3FKT0ZUeHBGTG9S?=
 =?utf-8?B?a0hLd2R6V2FUTERXeE1uZHRsdEFVY3hDaUVaUWtyWVhicTFoWDZldGdqWWpP?=
 =?utf-8?B?cHVTTHdPME96elB0Q2xiU3hoelFaeWx2Qm9IWm8raXRoMHRVN3htZE12VzVj?=
 =?utf-8?B?UndMTDZNWjFGVThDWkwvYkJBeXJoTGlaZGtjVTA0UGdjaXE1T3FEUXNXS2FK?=
 =?utf-8?B?N2lqTnVNNGZjUk1SZXhQTks2MUZmNytpRWJSUWRtRXY4a2lNZXRnUklEL2l1?=
 =?utf-8?B?QXVlV3dGdWpwbDdUQ2VtNm9JY2dDZ09DbERYWXA4dVhwNWFiK3RqR0RmZ3h6?=
 =?utf-8?B?VGdsWGpQNWg3WC9JRDBkaE9tcDBXaERUY1pVc1hvTlhuWXRuOVYyOS9seVA3?=
 =?utf-8?B?VTBCZ1VNVWJzV2dGbXBjeU9ZMzBrdFFnZm00Vmd2K1pxZksyeW1rdlRKaWxB?=
 =?utf-8?B?QzlpZEdyZk82Q3ljZUJUQi9ZWHgvYm9Fc1ZtN3pjT25JcHVhZU5sVnA5YzZQ?=
 =?utf-8?B?QzZieEZHcE1mVU10Z1Y5Z2tuUDRJdlNpNkNTd0w4bGhTMVlLVk4vQzBhZnBL?=
 =?utf-8?B?Z3orY1NhcUNEUlZxSlNybjY3R21BR2NrcmJ1SmM3Mi91VTJ3SHJMeHNzeTVl?=
 =?utf-8?B?ZVBjclhEL3IzVHpjSVQzT25iNFBJVGVOc3lWcmRBQ1A0QWszcUxNSzZxeHpX?=
 =?utf-8?B?MEpVUzVJMTJuMXdOYTBXMkdjb0l2MW56RkNuSit2Z2FNRnZ5bWcwdytCUDho?=
 =?utf-8?B?WGRneFRIZWYveDRwUGh1dEpvZzRMZzBwWHlibUdPNjZiWVdOZmFDK2ZhV3lo?=
 =?utf-8?B?djlkc3BXcWJON0JZYmJMZG1HSys5UXhvYVo5S3Y1OUM3Wi9Kb0VSVGxGd2pT?=
 =?utf-8?B?WHFTT0RJUEMyMHhzWlNFZDRrSzEyUVcwbmkxY2pHQjFncTdtWWtTN3AxVGo0?=
 =?utf-8?B?UkVsMW5OWEgycDR2bnI0MjVVSEZOTkZud2ptajMxOW9FMlJmY2dMVEQxekJa?=
 =?utf-8?B?ZFhJc1ZjWE1JN0htOWtCU2xHTHFWK0lFZVV0WlRtYTdrM0FKQ1NxQnZSRzgz?=
 =?utf-8?B?TXBCTkNjYnhtQkNYc0JtaGptVWxtTFUrNisvL1ZLd1drcS9QSVFQM3I2Y1N1?=
 =?utf-8?B?dmpYWm1UdG1iSFVaeFlhcFJqK1AzL2Z3SkVqWk9LcFg4T2h1L0daNjJnRUFL?=
 =?utf-8?B?a29jdTQreXRpTHBDdXFwK3NHdEdGNXkrZkdQUjNRTDRTdHIzWjRkRC9IVXRP?=
 =?utf-8?B?aXFmYTg4QW9iRk5DMWE4RUpKMGw4RWJrQjdwNkVZSWtuZHIrK0dHNXZ3K3Nx?=
 =?utf-8?B?WUEydnV6RG5sM3VqOEQ3bWRJSnZqTmRhNmFPai9OY2dpbWNzY1pybG9iU1lE?=
 =?utf-8?B?K09vNlNjdStJcWV3b2VVVnJjVmFCbnhYbTZnTDBZZi9hdnlkV0ZXUDdTQUdh?=
 =?utf-8?B?R0ZwUDhlajNUTnpCOUNyajdRSTFrY1dmRVJhOVdEYWtCRE56ZkF2NktGZ1Qz?=
 =?utf-8?B?c1B4QkxjY1NGemd1UVoxKzNTRzlTVFBNUmFlVzdTMFBFUGg2MG0vdTBoNy9J?=
 =?utf-8?B?a1Z2S2xScE9jajNENVI5Q1lnQWswL01BWEtPRk5tcUQxejFaUEhrRU9ScDdX?=
 =?utf-8?B?SC9vdXVvMDd0Zi9ha3JQZytIU0d0TEdqcldzSjFSc01tUDhHSlg2MDB5UkYy?=
 =?utf-8?B?L1BRMFF1Z1JtYm9FbWltRUhmcmNSSXlFL0xxaTFyb1puTEhRa013bWFZMDRi?=
 =?utf-8?B?cVdlT2wyNW9FUFJFZU1TV0tKbjVVcEd5bUJneno5eUNVb0xVbzhacm9abWYw?=
 =?utf-8?B?eVJodlNCVmIxU0txNFpmbG5pZS9la3hzcE56TDhJZGN3UnB0ZFFCNFhLME1u?=
 =?utf-8?Q?Gvu6D35JAvsxvffKJexXFPY=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 872ad875-2f19-4de9-a75c-08d9f2011ce4
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2022 10:34:44.4991
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: F/NyHulpKtC7jNr8n9CKj2sNH3wrGUnVwADhmEE4lvAQpmTYswXN11kDXcPZxhVSzAFrbYqKi1iRQlN3+pU2EA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR03MB3856
X-OriginatorOrg: citrix.com

On Thu, Feb 17, 2022 at 10:07:32AM +0100, Jan Beulich wrote:
> On 16.02.2022 17:21, Roger Pau Monne wrote:
> > Add a new Kconfig option under the "Speculative hardening" section
> > that allows selecting whether to enable retpoline. This depends on the
> > underlying compiler having retpoline support.
> > 
> > Requested-by: Andrew Cooper <andrew.cooper3@citrix.com>
> > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> 
> Reviewed-by: Jan Beulich <jbeulich@suse.com>
> 
> There's one aspect though which I would like to see Arm maintainer
> input on:
> 
> > --- a/xen/arch/x86/Kconfig
> > +++ b/xen/arch/x86/Kconfig
> > @@ -38,10 +38,6 @@ config GCC_INDIRECT_THUNK
> >  config CLANG_INDIRECT_THUNK
> >  	def_bool $(cc-option,-mretpoline-external-thunk)
> >  
> > -config INDIRECT_THUNK
> > -	def_bool y
> > -	depends on GCC_INDIRECT_THUNK || CLANG_INDIRECT_THUNK
> 
> Moving this ...
> 
> > --- a/xen/common/Kconfig
> > +++ b/xen/common/Kconfig
> > @@ -146,6 +146,22 @@ config SPECULATIVE_HARDEN_GUEST_ACCESS
> >  
> >  	  If unsure, say Y.
> >  
> > +config INDIRECT_THUNK
> > +	bool "Speculative Branch Target Injection Protection"
> > +	depends on X86 && (GCC_INDIRECT_THUNK || CLANG_INDIRECT_THUNK)
> 
> ... here despite being explicitly marked x86-specific looks a
> little odd. Since the dependencies are x86-specific, dropping
> X86 from here would make my slight concern go away.

Right - I've added the X86 because I was concerned about GCC or CLANG
also exposing the repoline options on Arm, but that's not an issue
because the compiler tests are only done for x86 anyway.

Feel free to drop the 'X86 &&' and the parentheses if you wish.
Otherwise I can resend if you prefer.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Thu Feb 17 10:38:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 17 Feb 2022 10:38:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274620.470146 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKeAo-0000qk-F9; Thu, 17 Feb 2022 10:38:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274620.470146; Thu, 17 Feb 2022 10:38:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKeAo-0000qd-C7; Thu, 17 Feb 2022 10:38:06 +0000
Received: by outflank-mailman (input) for mailman id 274620;
 Thu, 17 Feb 2022 10:38:05 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=A/h9=TA=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nKeAn-0000qX-B2
 for xen-devel@lists.xenproject.org; Thu, 17 Feb 2022 10:38:05 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id aed02d73-8fdd-11ec-8eb8-a37418f5ba1a;
 Thu, 17 Feb 2022 11:38:04 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: aed02d73-8fdd-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645094284;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=Y/+Z1xX3H+2mN+DrOZnYIO61TuGO9vbx7FjtDJlyc0A=;
  b=KyXQz5LbzxL+PUOSG4OyR4zxM6gn+YLPOTyK9TPiblA3oIbwVu+iSPeM
   4heOnqBK8r5XQJmy7cY7IqbOV/ELjVeUAjHytCikX2WCC45F5ez/XwTpu
   7AcYJATFTsohxGQYk4sjR2X+eTUMBhJT93AI79D/3Ft79iVwwYLHtpvE/
   k=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: ea285KvfEjQFCd4EhISYvkiOkPx1DRsFzH5TaXdfkaajiJSVXxTPcIAcnEKjzr4lTAPdFp+ndY
 t8eyyzC1vfaUL9p8aErYyH20LkOK/ZdVIQqRaUO8gv86K9jrhalusbtX2YEHTiatgabJPnxro8
 G4iQuueyQEPz3Q2b3bfp5SE636j7uYi1W15ftp3KwBc2XzmURxPS/Lv/gP8JJ0hzF3LICVyQCY
 WkPVS4Z4nPYWHbnWJlnbCG2w2iHmTefjpXIMe1CMKCDNsz11slksPbWVdKxi2leitaZYU7smcC
 Vn+984GAOhz4ghWaLovgWTgu
X-SBRS: 5.1
X-MesageID: 64420385
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:SIZrG6riquYYSbUvV7unflrc2JZeBmLEYhIvgKrLsJaIsI4StFCzt
 garIBnVPfqPajCneY8jPdmx/UJV65bTnYNqG1Y+ri1kQy9B+ZuZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlZT4vE2xbuKU5NTsY0idfic5Dndx4f5fs7Rh2NQw24HmW1rlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCnbq0RVkNMvXIor8AFBhfNH4ueqNU37CSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFJkYtXx6iynQEN4tQIzZQrWM7thdtNs1rp4SQayGP
 JpEAdZpRAbNIDlkCHMUMbAno82lwVvEchRnsk3A8MLb5ECMlVcsgdABKuH9atGMAMlYgEucj
 mbH5HjiRAEXMsSFzjiI+W7qgfXA9QvkXKoCGbv+8eRl6HWRzGEODBwdVXOgvOK0zEW5Xrpix
 1c8o3R06/JorQryE4e7D0bQTGO4UgA0fd5cTck2sAW3kbeT4gG+WThDQCxmZ4lz3CMpfgAC2
 liMltLvIDVgtryJVH6QnoupQSOO1Ts9djFbO3JdJecRy5y6+dxo0EqTJjp2OPPt1rXI9SfML
 ydmRcTUr5EaloY12qqy5jgraBr898GSHmbZCug6N19JDz+Vhqb5NuRECnCBtJ6sybp1qHHb4
 xDofODEsYgz4WmlznDlfQn0NOjBCwy5GDPdm0VzOJIq6i6g/XWuFagJvm0jfBw2bJpZImC0C
 KM2he+3zMUMVJdNRfUqC79d9uxwlfSwfTgbfqu8giVyjmhZK1bcoXAGib+41GHxikk8+ZzTy
 r/AGftA+U0yUPw9pBLvHr91+eZymkgWmDOCLbimnk/P+efPOxaopUItbQLmghYRt/jf/m04M
 r93aqO39vmoeLavOHaJr99IfAtiwLpSLcmelvG7v9Wre2JOMGogF+XQ0fUmfYlklL5SjeDG4
 je2XUow9bY1rSSvxdyiZi8xZbXxc4x4qH5nbyUgMUzxgyooYJq17bdZfJwyJOF1+OtmxP9yb
 v8EZ8TfXagfFmWZo2wQPcvnsYhvVBW3ngbSbSCrVycyIsx7TAvT9966Iga2rHsSDjC6vNcVq
 qG70l+JWoIKQglvVZ6EaP+mw16rk2IaneZ+AxnBLtVJIR2++4l2MS3hyPQwJphUexnEwzKb0
 SeQAAsZ+raR89NkroGRiPnd/YmzEuZ4Ek5LJEXh7O67ZXvA426u4Y5cS+LULzrTY3z5pfe5b
 uJPwvCibPBexARWs5BxGqpAxL4l44e9vKdTywlpESmZb1mvDb88cHCK0dMW6/9Iz75d/wC3R
 liO6p9RPrDQYJHpF1sYJQwEaOWf1K5LxmmOvKpteEiqtjVq+LenUFlJO0jegSNQG7J5LYc5z
 Lpzo8UR8QG+1kInP9vuYvq4LIhQwqjsi5kai6w=
IronPort-HdrOrdr: A9a23:7f4OuKvip1hHT32fZ0ifOFe07skC7oMji2hC6mlwRA09TyXGra
 +TdaUguSMc1gx9ZJhBo7G90KnpewK6yXdQ2/hqAV7EZniahILIFvAY0WKG+VPd8kLFh4xgPM
 tbAs1D4ZjLfCRHZKXBkXiF+rQbsaC6GcmT7I+0pRcdLj2CKZsQlzuRYjzrbHGeLzM2Y6bReq
 Dsgvau8FGbCAsqh4mAdzI4dtmGg+eOuIPtYBYACRJiwA6SjQmw4Lq/NxSDxB8RXx5G3L9nqA
 H+4kHEz5Tml8v+5g7X1mfV4ZgTsNz9yuFbDMjJrsQOMD3jhiuheYwkcbyfuzIepv2p9T8R4Z
 PxiiZlG/42x2Laf2mzrxeo8w780Aw243un8lOciWuLm72OeBsKT+56wa5JeBrQ7EQt+Ptm1r
 hQ4m6fv51LSTvdgSXU/bHzJl9Xv3vxhUBnvf8YjnRZX4dbQqRWt5Yj8ERcF4pFND7m6bogDP
 JlAKjnlblrmGuhHjDkV1RUsZ+RtixZJGbFfqFCgL3Y79FupgE586NCr/Zv20vp9/oGOu55Dq
 r/Q+BVfYp1P7wrhJRGdZM8qPuMexzwqC33QRCvyHTcZeg60iH22tbKCItc3pDeRHVP9up0pK
 j8
X-IronPort-AV: E=Sophos;i="5.88,375,1635220800"; 
   d="scan'208";a="64420385"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=kVOR1pyhxuDqSn9MilMYO1W41+5QiMSx5FUMTw3F1MX5rQnKwdDBO48vQR1XnI1RRtzflaQT86HQ40o9hrCpnza9UUto1nmirCAxfnkVFxjZoRUR2rFycRWlO44RWVTiBMJHcmznlDPEc/aYnvpSoSY7LPWti047zBTtUfPQESF9O8Omm3qu45U6qGYT6qLDcnyVE/ysDVWMfprLVr2b1K2640uf/xElsNTdrAb0Ammdt3jinuOJyelUuOiVv5rSeJfcmYAeOsm9zIOsr6ggwACvaPb8HAJsNhF/4JzYhp0hmh0H7WLqWGQCw8Op1pypAIXk5lQQwGKxu7xeT6mMmQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=xremFid+HzM26/bOUumPJtVZiyl9Rq49wmaqJF4LgjU=;
 b=G8EoTndAh/O5XKsRNIaKhnDQ25Ht5DOmsJkWZeCwbGaFQI9q4rUXCYev4xVg78gOanab3oQbKNyqogWNM1yQJqPbIkAR8egjJNDVHd/ZsU3npAXGtFHWjEB53csRfgk2ktcQmbenE5T8WP50IffeeHrvnPeAkyt3UQucuYX8XQm3A9fOt7LYu0CCyFWpn3QbCayu0OYaFckgLJb39d9DURgtjHx+fnZ6fr5A2lwRaWzQSaG4bCR4QRaWclukYkIy6InQfuAxj4uIiknoUd3I8RZUH+KZaYIYqHMDgWpxY6QzRGYvSQ653Y9N4woYFs9Y62z5VOdBfSHSa9c1m9fcJQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=xremFid+HzM26/bOUumPJtVZiyl9Rq49wmaqJF4LgjU=;
 b=CChPx4apqe2iPmxGMqOfRWMuw8YRqa4jSk9qwJNSodO5R+52pefpjdBHvXrSs7BgH75/RFO31RNs8nFgV833omPggQ93E7miEdEOUfnqlmtDey6sNLbqGrtCv9Krw1LtWLlXng1Bzxc5TPth86tV6lRx+5PrCVJwUN4rhAJ3YBM=
Date: Thu, 17 Feb 2022 11:37:53 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2 1/3] x86/retpoline: rename retpoline Kconfig check to
 include GCC prefix
Message-ID: <Yg4lgQlNBTyTlsLD@Air-de-Roger>
References: <20220216162142.15384-1-roger.pau@citrix.com>
 <20220216162142.15384-2-roger.pau@citrix.com>
 <7e5f721c-9771-bf35-8b94-f7fec7cd6eeb@suse.com>
 <536a357b-b895-7fe6-f99d-e83f5ac44745@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <536a357b-b895-7fe6-f99d-e83f5ac44745@suse.com>
X-ClientProxiedBy: LO2P265CA0385.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:f::13) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 31189acf-9d34-40d9-474b-08d9f201907c
X-MS-TrafficTypeDiagnostic: SN6PR03MB3856:EE_
X-Microsoft-Antispam-PRVS: <SN6PR03MB3856D41F289B9910CDD3A8D88F369@SN6PR03MB3856.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: B7LC67b3JIgs5WQ0re6fy2IDp2P8fASwbsr4Le4o6a8sUqXWVOfhSI2NfOs5AvjLRwtUfDpM/elnhA5V6nSbf5dtGm0xmg6n0I+6Mr0SFOELkyk8B+k+f3rlimB2o9JCusSw2c6dnCIj07NxX81F3C87yU5FGkLif1/plvUDBVAaX7jwzZ4cpduFsQhjAETQ/XJyMTb6jJkxEdckYveqQoM/dN1m11LBuqGLl2XrZqW2f4Qz10UAnmytDLfazPLIhM7nYizlypf8LivJYj6jMCfHGxBQCb/1KMhyvdNOmgIioGSZ92wdWoFSRjRvYTIjEkzHXLbdmGFKXAYhfWSLlfzO7rZZTqHXSCqcM0zhwRt/AEsH7/wCHbtJj28n6QO9S6Omd2aWtXJX9nYqPatVI9e+65gzo6QrgoA+nQiEPHg3ESIZ5bYiKmG0EyU8QTzcJ8WQpoxG99mfRokgpsauUiesEGe9+TQigSAfYGyStIe5MwN/jDCXyiVK4JhYNcx1jYcbD1pGakv6edJAyPUv3tboxj+GRvCjslm8hWH6wO8Bn56bGgz3qJFv6cnvgd1gZpKmyAGEEI+lEQGlTfeIHDEeWHb2yJhkGWJuqLMa9v4KSQF0/LOn6n1sx8nbFws/kl/3tRv3gbdxdOQlbwyd5Q==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(8676002)(2906002)(6916009)(85182001)(54906003)(6506007)(33716001)(186003)(26005)(86362001)(508600001)(9686003)(5660300002)(6486002)(6512007)(66476007)(66946007)(66556008)(6666004)(8936002)(316002)(53546011)(38100700002)(82960400001)(4326008);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NGVZa3MvWXcrOHZMdm5heWxJbTlnaldrbm5UdWRQbUs4d3RyL2RyUjU1ekI5?=
 =?utf-8?B?MEtGNGdmYTN1bTRGdUVKUjlEaGVCeGhmWGRKZ2JHRHdtbDIvc1dOaGFKS3VH?=
 =?utf-8?B?S2RxNk5FdkxmZ2p0SlZZaThxYi8zZXpzUHp1M1pvcVh5VDJxY2U5U0pmV0s3?=
 =?utf-8?B?OTZhV2EvTEdRcTM3T3JKNytLYzBQSUdmMkVDUENEOHNiWHdDZExzV2MwMFZ2?=
 =?utf-8?B?anpJVHc2dWRsZVNPQ2tRQkE2bk9xUGZOeTFCY0dad0lZZjc3VDJPZ21VNGtu?=
 =?utf-8?B?SVhuUnhEdmlrblNaMFhrU0dzSFF4aE0zOExZUWI2dnVGMHlidis4cSsrZWVr?=
 =?utf-8?B?UW1ZUEszZ3VsaWZmWVFSRVZmVXBCSUFhd0hjRmt1KzlOK0ppbklFVElzN29V?=
 =?utf-8?B?NTVlaTU1VUZXbTNUYVd4M2RPcENjc0ZYNXpmaVVuZHAxbWlxdFRtaXhKSEZP?=
 =?utf-8?B?dmExbjdweCt2cG5OUURSNUZWYXUvSmNSQS9PVXdMNnN6UWJaODlSczU0UEZ3?=
 =?utf-8?B?MDcwYUVBNnVMRG5Jc0Z5eHJPTkNTMXFDNnJ1VytYL0hud1dXamJ2OEM5amFj?=
 =?utf-8?B?RUxSclN1RTZMMVEwMkVqWm1rZGRkMjlhTURZbnBGdUdYNXF1cmRYYVZKcjB2?=
 =?utf-8?B?eWE2VmJ1aHRzaEtwdzF3SmJ1dkdJMnlOR0c4TUJnOWEzL3FhS0FhYklhVnQ0?=
 =?utf-8?B?YjhIdVNDYXRLSFRBNDkzdXN4TUM2VnEvWld3aGUzamREVU16alI0aUdmbmhM?=
 =?utf-8?B?QVVlMUZwWmJKS3lCZXcwK2V4UHRNRVd6clhUbStFZG1LNWg2RDh3TlhBVi93?=
 =?utf-8?B?aFhEQXMxRUJjNDhyaGVXQ0lobG5IMzNLdE82Z0hvUXVTZWhkZEdaRVgzOU5v?=
 =?utf-8?B?ZE5HUlFvcWJaTzZhcCt5enZhM1FNQmJaZlNla3VGRlNYdUJxZTY2dGJnREgy?=
 =?utf-8?B?emZzd2NrKzBLdFhxQnB4R3dTbW5SaElVSEdhOWFNbzBjc3JHMk9qWUVpNHhM?=
 =?utf-8?B?UzBQVHBWbWdGTlh6cWU4TGxHanNLVXZVaFdseDJnZ3RFMGExb3E4eWxkbjli?=
 =?utf-8?B?emJoUTVTYkNrb2ZPajhMbzBGOFlnOVNmQ3lIVDlrVTBMOW1FTGdKZUo3YXQx?=
 =?utf-8?B?L2ZTaDdqRFl6OXJoNVA2bDV0ZERBQTVnNTk3NG9kSm84L3BadzdOQlZWc2x2?=
 =?utf-8?B?YWpHM3NaanlMU2xVL09sYmxPZngrMU9WUjduZW5qWXV4YUhzV2d5eXdpRWVQ?=
 =?utf-8?B?RGNSVTZaMmZmK2tXUmdKQ2puWUE5TnFXeUkrK01uRnRVY1ZUK0Y0Z3ZWdVU5?=
 =?utf-8?B?bm9oeUhBL2Z1R2ZLMjNMT2YzTmkvbG00YWJNdTk4SVo4ZlIzMWx2S25wdHBR?=
 =?utf-8?B?Y1J6RlV6MkZ6YktQRjl6ZjdVaHB1Wm50NlZIeEtOcUgxT2NhZDlTVEFuUGJ1?=
 =?utf-8?B?ellKRzNFcThnTTAyMUNMSE94REpEN0tmQVNFSTV6OTlQL2lkaUtnNFpTVUJz?=
 =?utf-8?B?QWZlKzlHMnB6MjZpbnd5Q2pVMmpMRkU2THpDTXJ4RmkyZnpvdk9jZUpTT09N?=
 =?utf-8?B?eVloaDF6cjBiSmN1MFpacnkyL0UyRm9xRFVlSDRBREY5NjByWHYzK3RlZHhu?=
 =?utf-8?B?TFl1a1Iyb1VZMGNsaGx1ZmRLdzRmVjI2SFhNTGRobDc0dER0dVBhcEpsVG0y?=
 =?utf-8?B?T1N3b2dPcXJTS2dCVUE3VnBSRFFMSlFXRE1KWG0ySWE0MGM4bVlSNG9qSHdB?=
 =?utf-8?B?VWZRaFRMTWlYUUpHQ2cvUGd4TytiVzNDSzNTU2RDZlVwb0ZQazNYUEppdWli?=
 =?utf-8?B?dCtzU0hoZmpOamF6MkVuU2l4WGRZNDNBbW5Kemo2YmVWYkFOcks4U3pHbEFo?=
 =?utf-8?B?TlBVWjBCb1ZBQ0lpelVxWThxcFdsUk4vSTY4OFM1d1pYMjUyMVUxVEZFbGtx?=
 =?utf-8?B?UkUzNzdKNWFGa3BVclROZHRTNVFnU3lkUllBTnF2cjFjRjN2MEw1WHFZWDlw?=
 =?utf-8?B?MDdUblAyK1lScy9UaDkyOU10Sm9QZ0IyaTlXcllYZXEzV1Z4Qm80NHYwcEU1?=
 =?utf-8?B?RWdmODV3VUVsVjRTVjVCL1ZEZkdQMDNaeEwybFp3WUhLREF3Tkw1ckZMSk91?=
 =?utf-8?B?RDdCSFBSN2tRWmdvQkRyUXlMeWRUdzB5cUh3amNyL0ZRZi9UNTZFdHVXbGxn?=
 =?utf-8?Q?4z3/W1uomCaVeOUtNaCom1Y=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 31189acf-9d34-40d9-474b-08d9f201907c
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2022 10:37:58.4150
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SvWEjHQDJTW3GeyosiKLJJ8t7cfgPSY1PW8daPVk8IEX/2JcvvMNI4DoOBYD/j/htGIrnDXuFMpztcW0RWLvIw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR03MB3856
X-OriginatorOrg: citrix.com

On Thu, Feb 17, 2022 at 10:04:01AM +0100, Jan Beulich wrote:
> On 17.02.2022 09:59, Jan Beulich wrote:
> > On 16.02.2022 17:21, Roger Pau Monne wrote:
> >> Current retpoline checks apply to GCC only, so make it obvious by
> >> prefixing the Kconfig option with GCC. Keep the previous option as a
> >> way to signal generic retpoline support regardless of the underlying
> >> compiler.
> >>
> >> No functional change intended.
> >>
> >> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> >> Reviewed-by: Jan Beulich <jbeulich@suse.com>
> >> ---
> >> Changes since v1:
> >>  - Put def_bool before depend on.
> > 
> > Just for the record: A slightly shorter alternative would have been ...
> > 
> >> --- a/xen/arch/x86/Kconfig
> >> +++ b/xen/arch/x86/Kconfig
> >> @@ -32,9 +32,13 @@ config ARCH_DEFCONFIG
> >>  	string
> >>  	default "arch/x86/configs/x86_64_defconfig"
> >>  
> >> -config INDIRECT_THUNK
> >> +config GCC_INDIRECT_THUNK
> >>  	def_bool $(cc-option,-mindirect-branch-register)
> >>  
> >> +config INDIRECT_THUNK
> >> +	def_bool y
> >> +	depends on GCC_INDIRECT_THUNK
> > 
> > config INDIRECT_THUNK
> > 	bool
> > 
> > config GCC_INDIRECT_THUNK
> > 	def_bool $(cc-option,-mindirect-branch-register)
> > 	select INDIRECT_THUNK
> 
> Oh, looking at patch 3 again (which I should have still had in mind)
> this would of course not help. Yet ..
> 
> > A more appropriate thing to use for "depends on" might have been
> > CC_IS_GCC. With the next patch in mind this would then avoid
> > potential confusion if e.g. Clang folks decided to (also) support
> > the gcc style command line options.
> 
> ... adding this dependency (and a respective one in patch 2) might
> still be a good thing.

So you would like to make GCC_INDIRECT_THUNK depend on CC_IS_GCC?

That would be fine, but I think it's extremely unlikely for CLANG to
adopt the GCC options - I've already mentioned at implementation time
and they refused.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Thu Feb 17 10:42:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 17 Feb 2022 10:42:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274627.470158 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKeEk-0002EN-05; Thu, 17 Feb 2022 10:42:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274627.470158; Thu, 17 Feb 2022 10:42:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKeEj-0002EG-TF; Thu, 17 Feb 2022 10:42:09 +0000
Received: by outflank-mailman (input) for mailman id 274627;
 Thu, 17 Feb 2022 10:42:09 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=xzkl=TA=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nKeEi-0002EA-Ue
 for xen-devel@lists.xenproject.org; Thu, 17 Feb 2022 10:42:08 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 40d13035-8fde-11ec-8eb8-a37418f5ba1a;
 Thu, 17 Feb 2022 11:42:07 +0100 (CET)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2055.outbound.protection.outlook.com [104.47.12.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-5-Dk8FM5SJOG-VT4-BZPZNpQ-1; Thu, 17 Feb 2022 11:42:06 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM8PR04MB7395.eurprd04.prod.outlook.com (2603:10a6:20b:1c4::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.17; Thu, 17 Feb
 2022 10:42:05 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4995.016; Thu, 17 Feb 2022
 10:42:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 40d13035-8fde-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645094248;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=LsNLX9HKlarzxpykQvdNVa6gyEF5+GjGf0wJ34RvpBg=;
	b=jw9Rlr/7xH71UYhIfEhEimo7amGBV+Rpd8srI8n5sMNfr2b5mtGGK5xbN07hfmANJQ5jMd
	2zphufQsL6CemTUNBNAZmsIgc3tBShwUlIs3FBX80zspP+86CMCeuDYQr/xbVQgAOGtYZR
	bIKO8r46kqZppm5MUE7lEmC1kAD6cdU=
X-MC-Unique: Dk8FM5SJOG-VT4-BZPZNpQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Pb3GF/sl3TsQ9+hGlNgBRxILL86YSemhdMR37UVTtYWQ8UFZSgUXvKb0J56w6ZaSODT9heJ4C5sbFCNrBbLuQQz+bKahREuT5v4SRSg6J1KFKm++gg/0Cu/4pEEQ3r+/LNd+FR2BcUC/9m5Q1wVceKbBiOj5A6kS1YEyxu3w0bAqUgOAgAwv0/OS5cH9A59gHAb2KOzlMpK8lDUZFR2P62XlkEtSm8I5kAOXLHKxS9T1R7lWLW3LHrPSknYGy3gCWMt6C4Z5XphlCfgy7Te+Jgv08lSr3A+iL6M75qZhEFkNlkzt78HVd1xR3D5nd4tirXvH49l+Zg/Hq6y38cZ/6g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=LsNLX9HKlarzxpykQvdNVa6gyEF5+GjGf0wJ34RvpBg=;
 b=DYq8KP4ntnvHr61lLEmcYGn7qry63wq2VPVwQVYUWoCocULbxwPgAs40COkiZ76XNvwbP4fXJSNXjGuseFnkEg7YfDeDKPhF9ibJq9atVzY1o0l1+GaAGGaQZ1IeJHAE9SA/PqSkfHdRwxUN7p7dw9yK7AgXXDT0EIOMwriF85bfhtpcC3FpurZCZnGAX0bYHzdVpyBG883ZqhPDvidUZKDmpeGHCQLTAMsym4WFpAU9ADv36KpAxyjbON5RfaoqAu8SphzgimACYz4xVu1RHSLZNwmyR83bJ3UZ1ALGb9TViIrUA4q06G3ESh9Y0ep77V6MPjYksI4BYJeAY9F2wA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <4e9924f7-fdfa-c3c3-7b6c-e5cbe77ff9ac@suse.com>
Date: Thu, 17 Feb 2022 11:42:03 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v2.1 6.5/70] x86/kexec: Annotate embedded data with ELF
 metadata
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
 <20220217100158.22402-1-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220217100158.22402-1-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0231.eurprd06.prod.outlook.com
 (2603:10a6:20b:45e::28) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: eff7a023-f55a-4f72-364d-08d9f2022390
X-MS-TrafficTypeDiagnostic: AM8PR04MB7395:EE_
X-Microsoft-Antispam-PRVS:
	<AM8PR04MB73959070E2676F254E966A41B3369@AM8PR04MB7395.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	AXHQhYffjL+0D7jDOQuRTFHxQxrafGm9D7CzCKub8Bpzxw5MkGOBzwoLsMF4crBqWK9gHo1M7pxhOdEEZPaLtadmhtq/LaFo6XLT2TBo21LoyAaYgVTaYPo5ZHy35jd7r5VAJpA4TRf8qmUVH7fAW0432SQbvz/X5oJRreTXAxHYoOP+XikPpeSASwHOrh8EffmCZj82KQATsX/LasO/iwP9KUOi4r0nFZ7jjbbb7rKnnCYCmBby8g5FBC5uFvLf3mwoOFgfijOdZjgdNxD5egtQkxRWZ4LpqBoOjG0xU4GY1LllXBHBFTzdTkDBpC3OdUEsNqQoo/35jPSEuPVclIrlMILKlRMVH8qofnPruZb7MkdbgpD9CJDCaCo9qLvJ/QRZ4dFnQNtm6Vac+gSzKmt8kTQ31z0+y18DV5L9GNkd8CT8K9vYlFDVCMD4a4FbSIIN9ZpaXP6QkL5OgEShn+tWd5x0eESVMkAoxgi1VFwgiXAe51pd5veuFH6jAxuLoEOqK596KISVoG8IH6MD/0XI266bDe1JiQ0U/uwDxRrTsQ85Y/7Yu7VuGyNb2IwU6iZSDrz7RZretx91BjtVKk9mqxS5ONhgjnU/XCG1kfMdpxsJEpZbYWwdN22ny6RaZLJs9vJZI5pe16eQvC0uHI3Glfv3b2CTEiuVN5acJMeuKFUaO58NPH4XgfsgRh6yJTPeUxMYdCrwVu5GlbFa2x7aP6ibr1AkW+m2d54IIOcmmkBDqI+S/XyWpauNG7At
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(38100700002)(83380400001)(54906003)(5660300002)(6916009)(316002)(66476007)(66556008)(66946007)(4326008)(8676002)(2616005)(8936002)(6486002)(186003)(26005)(2906002)(508600001)(6512007)(53546011)(6506007)(31696002)(86362001)(36756003)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?SDlxaVdkZ0d6SHVmcWZZT0NjVVhFN0UzQXkrSU40Rjd4c2VYM3pDZXluN0VS?=
 =?utf-8?B?SHpCY0tFdjkyT2I3V3ZyOFYzY0Q5R3plRWNBa3R4TXJHRVJMT01BdVlBUGFj?=
 =?utf-8?B?RGxKY3JkeitWbW9BRWtyS09lQVFaTWUzUlU2QWJYRlhqeG44aHZwdWRDa0p3?=
 =?utf-8?B?SU1OT3JTeldCc2tIdndRc2c2cks5U21CZmEyYzU3L3ZpRjlyb0JRK1p0VERC?=
 =?utf-8?B?eG9uSUhHZlQ5RDl1TUVEYTAyejBtNkh6dGI4NGRDZ1J3R0FvTHZFY2NacHV5?=
 =?utf-8?B?cFJxdHEvaE9NaE94aFVidHNaNncwVlFGV25nNldsbUdKYllHcmJMdGw4RGpr?=
 =?utf-8?B?RTJpU1dDZ2xEMklvN1JqSURubE1KSkg4VnpYZzMwVGpwOG82TGZBYkU3NXlm?=
 =?utf-8?B?VzlMYVdVQklzYUNaVjlpQWlQVjlORzMrN0lLdjkxRFhZL0ViQ0VsekVrS3Js?=
 =?utf-8?B?TDlyVXZqYXhrZzZCK0dHWlhjZGg4MnA4cHJXVGRmMmJPV3BKMmRxdDRxNkNN?=
 =?utf-8?B?U2JqOVNLQ2FpME05TUxBcUJVRVZ0L2ltOWFNNmRFN2JZcDM2L1dFRHlaOXQ5?=
 =?utf-8?B?Tk5XTUEvQ05rKzV2MW9jbkVUK1NJZTNWdTROY01VcHpwQ2k5QTMvRTd1NEVE?=
 =?utf-8?B?cG9nNVJFWTRHQ3lFK05ZSkMrYnk1M0tIbnJ4SEJJRmxmbXJZUnp3UkV1TG0y?=
 =?utf-8?B?dWhKY1VyM25pQ0t2WEYvUFJRNnRQb2pFUTZMb3BLTURramlhNm45QXFKem8z?=
 =?utf-8?B?WjN0bWlsR0pmZW5WeWNiazg5QTRGRVJrNlprTVdGemlnajgvbFJ1Q2xTaTNH?=
 =?utf-8?B?U1JLcFFvUjRqU21NSDdDWTNjbDZpNVI2MnNTVjB6Q1R3cnBrMnZhUHpaNDJO?=
 =?utf-8?B?cWl2ZEo4QTkwekhkbHkyblBOVGNFS1ZvcnUxaXFFZXlOWmsweEExcTdISmMv?=
 =?utf-8?B?TEZVL2JMcG83UmxsYnF6cmRZQnRTbyt4aEtFVmhFSGxBVVkxaVFSY0ZqR3pZ?=
 =?utf-8?B?emp0T1RmSUh4YXpRRWJ2L010eHozN3dENTZZcmtHRERHdFN5Q0hFdG1NeHdq?=
 =?utf-8?B?Qlh2b0c4OHE0NzFnY2tFemR1MUM4dS9PNFdpV1hXODhvLzBxbVJ0VVV6MFZR?=
 =?utf-8?B?VXp2UkhLS0NydE5PZ0trWjJnNFU1dm53Vi9DaHZmbTB5aXVJY2tzWmt5eGsv?=
 =?utf-8?B?M2FoVlM4TmMyblRSUXpEUXJGcTVqWnozNS9aamtseHVIa1ZsSUNPbEJoNmN3?=
 =?utf-8?B?Y2RyZUdrVll2NlUxMERWeFF3a0NXNXpuUTYvam5rNk0xYXNQRW1QbUtORnJQ?=
 =?utf-8?B?czFMdUY1Vmt5ZW1KeGg4UVpka0NWbXMzQ0k1aXJOZTJtOU8xZHI4cWxxcXJB?=
 =?utf-8?B?d3pqdlQ5TUxmdlF3RzJIVlVuOC9vdE04TnhyWFF6bjFzZ3d3UkwyUjdPeElm?=
 =?utf-8?B?NjRkT3hySkRnQXdvbG5mUmE3bk5MczBqTEpCL0VESndqQmgrUU1rSzB5T1dv?=
 =?utf-8?B?dlhqQW92Z0NzaGpYVkt6Ym1ib0FDdmRwRExjWXZBUU5TNk5tbTk3eXR1UUpj?=
 =?utf-8?B?UXVGai83ZU1hT01rWms5RzY0aEJmdkVMWjVLa1lEMTRFdUg5U3RTUFg2R05U?=
 =?utf-8?B?NnNYVmkzNnVvZXZHV3hJTGZTN3pEZmdBMmlBL0s2TjZieTZKc2Z3Q2J2RDI5?=
 =?utf-8?B?dUpHQWpKYVNrSm1pcFQ3bThxa3ZZOGZJMk5nKzdhZTdVM3NFbWdVUG8yV1hu?=
 =?utf-8?B?aEtKRGJjY050M2QxQ3E3MW9kTzlYNTQvS0Flc3QwSW5VMnczTGNESUJYWFI3?=
 =?utf-8?B?bzhjcGlNN0YyRERJV1lFaUxOWUtHUEpWU0x0TlNFWG8ycTdEcDVwSDgreStw?=
 =?utf-8?B?dTZ4S2FUWXdSZjM5RDdwVEtET2dRMVYzaXAzSTRpbjVOZFFEeFB0MVZCQnQ3?=
 =?utf-8?B?eXFzbXA2U3RUQUZLSzBqWURMMjRwWDBxQW01cmxFSmhuL1d1RExYSXlnR0Vq?=
 =?utf-8?B?VS8rQit4S293Nkg4elBsQTZ3dm8vMk5qOGxKZzlIS1kySGFYcE44dytkZTJC?=
 =?utf-8?B?bVRZSXRaeTZ3d3BIYkFGb3FxTEMzN0NqbDZMakF0bWVZaHBXa3pzNFRoVmhk?=
 =?utf-8?B?NjIrbGhyWVRPRS9rKzY0b2ZhNWVpWi9LMmdjNllwakRpZ0pQTHA5TVVqcTY2?=
 =?utf-8?Q?1t4ViUVv1iStxShX5z/dihI=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: eff7a023-f55a-4f72-364d-08d9f2022390
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2022 10:42:05.1395
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: t4L+d+jq5A+r3LyqCn7LXA3EhuM6uu82hpj6b+LbR9OI1X6zs2/rj7QMtAiybtAe+cWCmcMD1lhtr5QiCLPSzg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7395

On 17.02.2022 11:01, Andrew Cooper wrote:
> Scanning for embedded endbranch instructions involves parsing the .text
> disassembly.  Data in the kexec trampoline has no ELF metadata, so objdump
> treats it as instructions and tries to disassemble.  Convert:
> 
>   ffff82d040396108 <compatibility_mode_far>:

What about the (possible) padding ahead of this? Should the .align
there perhaps specify a filler character?

>   ffff82d040396108:       00 00                   add    %al,(%rax)
>   ffff82d04039610a:       00 00                   add    %al,(%rax)
>   ffff82d04039610c:       10 00                   adc    %al,(%rax)
> 
>   ffff82d04039610e <compat_mode_gdt_desc>:
>   ffff82d04039610e:       17                      (bad)
>           ...
> 
>   ffff82d040396118 <compat_mode_gdt>:
>           ...
>   ffff82d040396120:       ff                      (bad)
>   ffff82d040396121:       ff 00                   incl   (%rax)
>   ffff82d040396123:       00 00                   add    %al,(%rax)
>   ffff82d040396125:       93                      xchg   %eax,%ebx
>   ffff82d040396126:       cf                      iret
>   ffff82d040396127:       00 ff                   add    %bh,%bh
>   ffff82d040396129:       ff 00                   incl   (%rax)
>   ffff82d04039612b:       00 00                   add    %al,(%rax)
>   ffff82d04039612d:       9b                      fwait
>   ffff82d04039612e:       cf                      iret
>           ...
> 
>   ffff82d040396130 <compat_mode_idt>:
>           ...
> 
>   ffff82d0403961b6 <kexec_reloc_size>:
>   ffff82d0403961b6:       b6 01                   mov    $0x1,%dh
>           ...
> 
> to:
> 
>   ffff82d040396108 <compatibility_mode_far>:
>   ffff82d040396108:       00 00 00 00 10 00                               ......
> 
>   ffff82d04039610e <compat_mode_gdt_desc>:
>   ffff82d04039610e:       17 00 00 00 00 00 00 00 00 00                   ..........
> 
>   ffff82d040396118 <compat_mode_gdt>:
>           ...
>   ffff82d040396120:       ff ff 00 00 00 93 cf 00 ff ff 00 00 00 9b cf 00 ................
> 
>   ffff82d040396130 <compat_mode_idt>:
>   ffff82d040396130:       00 00 00 00 00 00                               ......

With the .size directives added, can we rely on consistent (past,
present, and future) objcopy behavior for padding gaps? It just so
happens that there's no 4-byte gap between compat_mode_gdt_desc and
compat_mode_gdt. Changing the .align ahead of compatibility_mode_far
would eliminate the risk of padding appearing if the code further up
changed.

>   ffff82d040396136 <reloc_stack>:
>           ...

Now this is particularly puzzling: Us setting %rsp to an unaligned
address is clearly not ABI-conforming. Since you're fiddling with
all of this already anyway, how about fixing this at the same time?
Of course there would then appear padding ahead of the stack, unless
the stack was moved up some.

> @@ -175,10 +175,16 @@ compatibility_mode_far:
>          .long 0x00000000             /* set in call_32_bit above */
>          .word 0x0010
>  
> +        .type compatibility_mode_far, @object
> +        .size compatibility_mode_far, . - compatibility_mode_far
> +
>  compat_mode_gdt_desc:
>          .word .Lcompat_mode_gdt_end - compat_mode_gdt -1
>          .quad 0x0000000000000000     /* set in call_32_bit above */
>  
> +        .type compat_mode_gdt_desc, @object
> +        .size compat_mode_gdt_desc, . - compat_mode_gdt_desc

Side note: We really ought to gain something like OBJECT(name) to avoid
c'n'p mistakes not updating correctly all three symbol name instances.

> --- a/xen/arch/x86/xen.lds.S
> +++ b/xen/arch/x86/xen.lds.S
> @@ -87,6 +87,7 @@ SECTIONS
>         *(.text.unlikely)
>         *(.fixup)
>         *(.text.kexec)
> +       kexec_reloc_end = .;

Does this maybe want aligning on a 4- or even 8-byte boundary? If
so, imo preferably not here, but by adding a trailing .align in the
.S file.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Feb 17 10:57:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 17 Feb 2022 10:57:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274634.470169 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKeT9-0003nJ-6n; Thu, 17 Feb 2022 10:57:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274634.470169; Thu, 17 Feb 2022 10:57:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKeT9-0003nC-1u; Thu, 17 Feb 2022 10:57:03 +0000
Received: by outflank-mailman (input) for mailman id 274634;
 Thu, 17 Feb 2022 10:57:02 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mzVd=TA=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nKeT8-0003n6-AJ
 for xen-devel@lists.xenproject.org; Thu, 17 Feb 2022 10:57:02 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 539eaaf5-8fe0-11ec-b215-9bbe72dcb22c;
 Thu, 17 Feb 2022 11:57:00 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 539eaaf5-8fe0-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645095420;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=ZtW6VisS4ywH8dJriw3Ytb5KVKugn/0fU/ZsU7IJrwg=;
  b=RZS3u7l+em4yH00niIg3iwB2YfmNK6r3g7Snvuh3fO6IoF9pAEAEsYq5
   xhgFoDnILhhAZLBqDelK6/OS6EdfWd7UmShNojsLUJyRrXB2uZTA93hFf
   qMTvp/ZE893AjWlSGBqTNqQSl3zFhZ24vYU4dd2cq6swrvl9/szpeUy94
   I=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: BUc3DiS6lY9e4LfAqDVql4X4a+3j0ic+7/NPA7neb7JbKsnQnjYkwjetVdIdnJovPqwbiUMSE9
 fwWH4Z9hCRajICV4oAb6gFZtzEGlxbbCk6Z1hFLjYnipky80C1+e275M3L6I9BdpuVKLwmP04d
 8Sy7fNOvkzfnylFNoyWdw97NMKnlStydWXw/DV3QbaDjMakXyDpVxCR3Vzke6F4IEFMB1JPTHq
 IMS6/MBxktPHjJT+iUQQuNDT1Qjz7p07YH2C8pwCAZvOu7S+dB8eSPL2dMb0DPUvBC6KC2vnUp
 ObizTexrd1sgeLUq/z2gMi9g
X-SBRS: 5.1
X-MesageID: 64316964
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:h3IXdqjmAeoy7ohTO5nYwJ5WX1615RcKZh0ujC45NGQN5FlHY01je
 htvCmmEMq7eMGb9Kdsjbtzn/UJS7Z7Wyt42SQJv+CoyFCkb9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oAMKRCQ7InQLlbGILes1htZGEk0GE/NtTo5w7Rj2tQx3oDga++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /1TsprqThg2OJeLp/hBeV5+LiYlZp9vreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHiOp8fvXdxiynUF/88TbjIQrnQ5M8e1zA17ixLNaiCP
 JNHOGQzBPjGS0QWeXIuN5I+oOahoX2mehEFtWmTiJNitgA/yyQuieOwYbI5YOeiR9hRn0uej
 nLL+SL+GB5yHMeE1TOP/3aoh+nOtSD2QoQfEPu/7PECqEKX7nweDlsRT1TTifu2kEmlQPpEN
 lcZvCEpqMAa5EGtC9XwQRC8iHqFpQIHHcpdFfUg7wOAwbaS5ByWbkAGRDNcbN0ttOctWCcnk
 FSOmrvU6SdH6ePPDyjHr/HN8G30aXN9wXI+iTEsUwwDud78v4cJyS3TEvwkNpOy1YbHMGSlq
 9yVlxQWi7IWhM8N8qy0+1Hbnj6hzqT0oh4JChb/BTz8sF4gDGKxT8nxsAWAs64cRGqMZgTZ5
 BA5d96iAPfi5H1nvAiEW60zEb6g/J5p2xWM0Ac0T/HNG9lAkkNPnLy8AhkidS+F0e5eIFcFh
 XM/XysLu/e/21PwMMdKj3qZUZhC8EQZPY2NugroRtRPeINtUwSM4TtjY0Wdt0i0zhRxyfpgZ
 8vGKpnxZZr/NUiB5GDpLwv6+eV2rh3SOEuJHcyrp/hZ+eH2iIGppUctbwLVM7FRAFKsqwTJ6
 ddPX/ZmOD0EONASlhL/qNZJRXhTdCBTLcmv96R/K77SSiI7STpJI6KAntscl3lNwv09ehHgp
 SrmBCe1CTPX2BX6FOl9QisyMuyxA8ck/ClT0O5FFQ/A5kXPqL2HtM83H6bbt5F9nAC65fIrH
 fQDZeuaBfFDFmbO9zgHNMGvp41+bhW7wwmJOnP9MjQ4epdhQS3P+8PlIVSzpHVfUHLvuJtsu
 aCk2yPaXYEHG1ZoAvHJZa/91Fi2p3Ucxr5/BhOaPtlJdUzw24F2MCit3OQvKsQBJEyblDuX3
 gqbGzkCouzJr9Nn+dXFn/nc/YyoD/F/DgxRGGyCteS6MizT/2yCx45cUbnXIWCBBT2soKj7P
 Ldb1fDxNvEDjW1miYskHuY517866vvuu6ReklZuEkLUYgn5EbhnOHSHg5VC7/Uf2r9DtAKqc
 UuT4d0Ga66RMcboHVNNdgooauOPiaMdljXItKlnJUz74Gl8/aadUFUUNB6J0XQPILxwOYIj4
 OEgpM9JtFDv1kt0ao6L3nJO6mCBDn0cSKF25JgVDbjihhcv1lwfM4fXDTX74c3XZthBWqXwz
 uR4WEYWa2xg+3f/
IronPort-HdrOrdr: A9a23:VUNWfqHHL6MDWhMWpLqE6MeALOsnbusQ8zAXP0AYc3Jom+ij5q
 STdZUgpHrJYVkqNU3I9ertBEDEewK6yXcX2/hyAV7BZmnbUQKTRekIh7cKgQeQeBEWntQts5
 uIGJIeNDSfNzdHsfo=
X-IronPort-AV: E=Sophos;i="5.88,375,1635220800"; 
   d="scan'208";a="64316964"
Date: Thu, 17 Feb 2022 10:56:53 +0000
From: Anthony PERARD <anthony.perard@citrix.com>
To: Juergen Gross <jgross@suse.com>
CC: <xen-devel@lists.xenproject.org>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, "Jan
 Beulich" <jbeulich@suse.com>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH] tools/xenstore: add error indicator to ring page
Message-ID: <Yg4p9eq4A7b+FimR@perard.uk.xensource.com>
References: <20220210111620.5256-1-jgross@suse.com>
 <YgvJyt5Jpvsb2Jws@perard.uk.xensource.com>
 <8891ed69-2ad2-2842-e34e-8252860b71d9@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <8891ed69-2ad2-2842-e34e-8252860b71d9@suse.com>

On Tue, Feb 15, 2022 at 04:45:28PM +0100, Juergen Gross wrote:
> On 15.02.22 16:42, Anthony PERARD wrote:
> > On Thu, Feb 10, 2022 at 12:16:20PM +0100, Juergen Gross wrote:
> > > +The "Connection error indicator" is used to let the server indicate it has
> > > +detected some error that led to deactivation of the connection by the server.
> > > +If the feature has been advertised then the "Connection error indicator" may
> > > +take the following values:
> > > +
> > > +Value   Description
> > > +-----------------------------------------------------------------
> > > +0       No error, connection is valid
> > > +1       Communication problems (event channel not functional)
> > > +2       Inconsistent producer or consumer offset
> > > +3       Protocol violation (client data package too long)
> > 
> > Is this meant to be the only possible error value? If in the future we
> > want to add more possible error, does it going to need a new feature
> > bit and maybe a new error field?
> 
> No, as the guest is not opting into this feature, but just gets it
> presented, there is no need to have another bit for new error values.

This probably needs to be spelled out in the documents that.

> Note that this is a purely informational interface. The error value
> (other than 0) is only for diagnostic purposes, there is no way a
> guest could react in a sane way to a specific error case.

This could also be spelled out in the document, in the new section "The
connection error feature", that a value other than 0 is a connection
error even if the error number isn't known to the client.

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Thu Feb 17 10:59:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 17 Feb 2022 10:59:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274643.470179 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKeVZ-0004Ro-Mo; Thu, 17 Feb 2022 10:59:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274643.470179; Thu, 17 Feb 2022 10:59:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKeVZ-0004Rh-JE; Thu, 17 Feb 2022 10:59:33 +0000
Received: by outflank-mailman (input) for mailman id 274643;
 Thu, 17 Feb 2022 10:59:32 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mzVd=TA=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nKeVY-0004RX-4O
 for xen-devel@lists.xenproject.org; Thu, 17 Feb 2022 10:59:32 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id add93785-8fe0-11ec-b215-9bbe72dcb22c;
 Thu, 17 Feb 2022 11:59:30 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: add93785-8fe0-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645095570;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:content-transfer-encoding:in-reply-to;
  bh=ZqAs0fk/xAXnllDiy4SxZ+MynxdNz0fhyVsASs+4ueE=;
  b=WeAfbFhJA/O0eJ2kmz/lK6dR8XpPOGHiRxSDopEvsLzNaSW18WRn0lO5
   VRSwZQNlhm0D6EvOdJs95nQGOQUe9CBH6q7KGJ+WytqTr+UzieVoqvimv
   HKS4WHxMK61iu3Xy+HGdbCPwObx8PELx96N/QaByekDVaK+82wo3duGJt
   E=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: 7qEhOOmzBirL7zEWWSfRAI0CARMbfh9qq72ADa3HIVeBGKnFyg9kcv4zZeIhOejXq4B1Tyi9gN
 cAMykRcBzIk/VoXFqpvBYRKXMznxLlZeN42izYAiw+6B43+Mq0SpqNc8gwnMUFQzqmCbAkYeUo
 vFlNJBIuBJJDLwrs08S1Y0vN5yimTstSolWhmxt2YdUgeaiWUBv3bXbAkbrkJBBUSLfGMiwHgY
 p2fAbHCzGQTWqC0EjxUgNoAuT/Al67Uip5HMOtdi/wH7uWdJlvxw9NUELF+SPUMRBVUtz9qWlS
 0/b5lhUnUyciMrl61aNdpnOw
X-SBRS: 5.1
X-MesageID: 64421317
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:OqRltK9fNOlZNH6C9upEDrUDXXmTJUtcMsCJ2f8bNWPcYEJGY0x3x
 jFMDW7TPv+KYDCkKIx/bIzlo0lXu8PSz9dhSwFlpCk8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhFWeIdA970Ug5w7Rg3dYx6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhO8
 I8SjZWAbjsPFYnAmcMXaB5GMXtXaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguwqKtXrO4UO/Glt1zjDAd4tQIzZQrWM7thdtNs1rp4SQayHP
 JNGAdZpRDDvXxtFeXg2MbB9jfqGv1zzKB9DlU3A8MLb5ECMlVcsgdABKuH9eNOQQt5Otl2Fv
 W+A9GP8ajkYPtGCzTuO8lq3m/TC2yj8Xeo6BLC+s/JnnlCX7mgSEwENE0u2p+GjjUyzUM4ZL
 FYbkgIxqYAi+UrtScPyNyBUu1bd4ERaAYAJVbRntkfdkcI4/jp1GEA7dmQeUNUWk/MQbhgm1
 3iDpNT3J2ZG5ej9pW2myp+Yqja7OC4wJGAEZDMZQQZt3+QPsL3fnTqUEI89TffdYsndXGipn
 mvU9HRWa6A70JZTv5hX62wrlN5FSnLhagcurjvaUWu+hu+STN70Ptf4gbQ3ABspEWp4crVjl
 CRV8yR9xLpXZX1oqMBraL9SdF1Oz6zYWAAweXY1Q/EcG82FohZPh7x47jBkP1tOOc0ZYzLva
 0K7kVoPuMILZyT0MfIsPN/Z5yEWIU7IT4uNuhf8NIcmX3SMXFXfoHEGibC4hAgBb3TAYYlgY
 MzGIK5A/F4RCLh9zSreegvu+eRD+8zK/kuKHcqT503+idK2PSfJIZ9YYArmRr1ot8us/VSKm
 +uzwuPXkn2zpsWlOXKJmWPSRHhXRUUG6Wfe8J0NKbDdc1E3QwnMyZb5mNscRmCspIwN/s+gw
 513chYwJIPXiSKVJAOURGpkbb+zD59zoWhiZX4nPEqy2mhlaoGqtf9Ne5wydLgh1epi0f8rE
 KVVJ5TeWqxCGmbd5jAQTZjht4g+Jh6lsh2DYni+az8lcp8+GwGQoo34fhHi/TUlBzassZdsu
 KWp0w7WGMJRRwlrAMvMRuioyle94SoUlO5oBhOaKdhPYkT8toNtLnWp3PMwJsgNLzTFxyebi
 FnKUUtJ+7GVrtZsotfThK2Co4O4KMdEHxJXTzvB8LK7FSjG5W7/k4VOZ/mFIGLGX2Tu9aT8O
 egMl6PgMOcKlUphupZnF+o51ro34tbiquMIzglgG3mXPV2nBqk5fyuD1MhL8KZM2qVYqU29X
 UfWootWPrCAOcXEFl8NJVV6MrTfhK9MwjSCv+4oJEja5TNs+OvVWEpfCBCAlShBIeYnK4gi2
 +og5JYb5gHXZsDG6TpaYvS4L1ixE0E=
IronPort-HdrOrdr: A9a23:be8HHKHOuOmvfmuzpLqE1seALOsnbusQ8zAXPidKOHtom62j5q
 STdZsgpH3JYVoqOE3I+urgBEDjewK7yXcd2+B4V9rPYOCPghrQEGgI1/qG/9SPIVycygd179
 YZT0AgY+eaMbEBt6jHCaODYq0dKaK8n5yVuQ==
X-IronPort-AV: E=Sophos;i="5.88,375,1635220800"; 
   d="scan'208";a="64421317"
Date: Thu, 17 Feb 2022 10:59:24 +0000
From: Anthony PERARD <anthony.perard@citrix.com>
To: Roger Pau =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>
CC: <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>, Juergen Gross
	<jgross@suse.com>, Jan Beulich <jbeulich@suse.com>
Subject: Re: [PATCH v2] tools/libxl: don't allow IOMMU usage with PoD
Message-ID: <Yg4qjERzoki2Lpi/@perard.uk.xensource.com>
References: <20220203143211.18967-1-roger.pau@citrix.com>
 <YgvB5UtyC29m8zbo@perard.uk.xensource.com>
 <Ygy/4zk8Eo78ECi5@Air-de-Roger>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <Ygy/4zk8Eo78ECi5@Air-de-Roger>

On Wed, Feb 16, 2022 at 10:12:03AM +0100, Roger Pau Monn� wrote:
> On Tue, Feb 15, 2022 at 03:08:21PM +0000, Anthony PERARD wrote:
> > On Thu, Feb 03, 2022 at 03:32:11PM +0100, Roger Pau Monne wrote:
> > >      if (d_config->c_info.type != LIBXL_DOMAIN_TYPE_PV &&
> > > -        d_config->num_pcidevs && pod_enabled) {
> > > +        d_config->c_info.passthrough != LIBXL_PASSTHROUGH_DISABLED &&
> > > +        pod_enabled) {
> > >          ret = ERROR_INVAL;
> > > -        LOGD(ERROR, domid,
> > > -             "PCI device assignment for HVM guest failed due to PoD enabled");
> > > +        LOGD(ERROR, domid, "IOMMU not supported together with PoD");
> > 
> > I'm not sure that this new error message is going to be good enough to
> > point out configuration issue for the guest.
> > 
> > One is going to set 'pci=["foo"]' or 'dtdev=["bar"]', which will enable
> > passthrough. Then they may get en error about IOMMU or PoD.
> > Should we maybe write something like this instead?
> > 
> >    "IOMMU or device passthrough not supported together with PoD"
> 
> The "or" seems weird to me: IOMMU is mandatory for device passthrough.
> Maybe:
> 
> "IOMMU required for device passthrough but not support together with PoD"

                                                 ^ supported ?
> Would that be OK?

Sound good, with that new error message: Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Thu Feb 17 10:59:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 17 Feb 2022 10:59:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274644.470191 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKeVk-0004mO-U5; Thu, 17 Feb 2022 10:59:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274644.470191; Thu, 17 Feb 2022 10:59:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKeVk-0004mH-Qz; Thu, 17 Feb 2022 10:59:44 +0000
Received: by outflank-mailman (input) for mailman id 274644;
 Thu, 17 Feb 2022 10:59:43 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9h7v=TA=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nKeVj-0004lL-Kn
 for xen-devel@lists.xenproject.org; Thu, 17 Feb 2022 10:59:43 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b5ac42a0-8fe0-11ec-8eb8-a37418f5ba1a;
 Thu, 17 Feb 2022 11:59:42 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 4BD4C1F37D;
 Thu, 17 Feb 2022 10:59:42 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0BA0913DD8;
 Thu, 17 Feb 2022 10:59:42 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id Bk3+AJ4qDmIlTwAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 17 Feb 2022 10:59:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b5ac42a0-8fe0-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1645095582; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=AZV3S2C9Olws3SAVZKEWCpXK/WAFTRAOKoTzYU0jXLg=;
	b=daZDJ/sF/DaHriFdy6MgdU4mD76n5aGwHsV72TKh+xU0wEESruJOp9KihUFee0jc6caZN3
	NID3RPHtlUaNCL5v/KB8qHYoGeG7/rqSLKwxzo27zrj7kjisDhDCGi0oOHMYt2PAKDJm5y
	jeLnVn5LUquK+1iYcqBTI3qL57xoKvs=
Message-ID: <d03ca9b8-9b47-eae7-dbdf-e6f3eb131ebe@suse.com>
Date: Thu, 17 Feb 2022 11:59:41 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Subject: Re: [PATCH] tools/xenstore: add error indicator to ring page
Content-Language: en-US
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: xen-devel@lists.xenproject.org, Andrew Cooper
 <andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>,
 Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
References: <20220210111620.5256-1-jgross@suse.com>
 <YgvJyt5Jpvsb2Jws@perard.uk.xensource.com>
 <8891ed69-2ad2-2842-e34e-8252860b71d9@suse.com>
 <Yg4p9eq4A7b+FimR@perard.uk.xensource.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <Yg4p9eq4A7b+FimR@perard.uk.xensource.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------hbj147hcyzmyU0jgILszg2x0"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------hbj147hcyzmyU0jgILszg2x0
Content-Type: multipart/mixed; boundary="------------yQHfNujSpnkp8SESQXV3HC6u";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: xen-devel@lists.xenproject.org, Andrew Cooper
 <andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>,
 Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Message-ID: <d03ca9b8-9b47-eae7-dbdf-e6f3eb131ebe@suse.com>
Subject: Re: [PATCH] tools/xenstore: add error indicator to ring page
References: <20220210111620.5256-1-jgross@suse.com>
 <YgvJyt5Jpvsb2Jws@perard.uk.xensource.com>
 <8891ed69-2ad2-2842-e34e-8252860b71d9@suse.com>
 <Yg4p9eq4A7b+FimR@perard.uk.xensource.com>
In-Reply-To: <Yg4p9eq4A7b+FimR@perard.uk.xensource.com>

--------------yQHfNujSpnkp8SESQXV3HC6u
Content-Type: multipart/mixed; boundary="------------Oe0ldEXZrcJvsjTFafS7jIjo"

--------------Oe0ldEXZrcJvsjTFafS7jIjo
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMTcuMDIuMjIgMTE6NTYsIEFudGhvbnkgUEVSQVJEIHdyb3RlOg0KPiBPbiBUdWUsIEZl
YiAxNSwgMjAyMiBhdCAwNDo0NToyOFBNICswMTAwLCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0K
Pj4gT24gMTUuMDIuMjIgMTY6NDIsIEFudGhvbnkgUEVSQVJEIHdyb3RlOg0KPj4+IE9uIFRo
dSwgRmViIDEwLCAyMDIyIGF0IDEyOjE2OjIwUE0gKzAxMDAsIEp1ZXJnZW4gR3Jvc3Mgd3Jv
dGU6DQo+Pj4+ICtUaGUgIkNvbm5lY3Rpb24gZXJyb3IgaW5kaWNhdG9yIiBpcyB1c2VkIHRv
IGxldCB0aGUgc2VydmVyIGluZGljYXRlIGl0IGhhcw0KPj4+PiArZGV0ZWN0ZWQgc29tZSBl
cnJvciB0aGF0IGxlZCB0byBkZWFjdGl2YXRpb24gb2YgdGhlIGNvbm5lY3Rpb24gYnkgdGhl
IHNlcnZlci4NCj4+Pj4gK0lmIHRoZSBmZWF0dXJlIGhhcyBiZWVuIGFkdmVydGlzZWQgdGhl
biB0aGUgIkNvbm5lY3Rpb24gZXJyb3IgaW5kaWNhdG9yIiBtYXkNCj4+Pj4gK3Rha2UgdGhl
IGZvbGxvd2luZyB2YWx1ZXM6DQo+Pj4+ICsNCj4+Pj4gK1ZhbHVlICAgRGVzY3JpcHRpb24N
Cj4+Pj4gKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tDQo+Pj4+ICswICAgICAgIE5vIGVycm9yLCBjb25uZWN0aW9u
IGlzIHZhbGlkDQo+Pj4+ICsxICAgICAgIENvbW11bmljYXRpb24gcHJvYmxlbXMgKGV2ZW50
IGNoYW5uZWwgbm90IGZ1bmN0aW9uYWwpDQo+Pj4+ICsyICAgICAgIEluY29uc2lzdGVudCBw
cm9kdWNlciBvciBjb25zdW1lciBvZmZzZXQNCj4+Pj4gKzMgICAgICAgUHJvdG9jb2wgdmlv
bGF0aW9uIChjbGllbnQgZGF0YSBwYWNrYWdlIHRvbyBsb25nKQ0KPj4+DQo+Pj4gSXMgdGhp
cyBtZWFudCB0byBiZSB0aGUgb25seSBwb3NzaWJsZSBlcnJvciB2YWx1ZT8gSWYgaW4gdGhl
IGZ1dHVyZSB3ZQ0KPj4+IHdhbnQgdG8gYWRkIG1vcmUgcG9zc2libGUgZXJyb3IsIGRvZXMg
aXQgZ29pbmcgdG8gbmVlZCBhIG5ldyBmZWF0dXJlDQo+Pj4gYml0IGFuZCBtYXliZSBhIG5l
dyBlcnJvciBmaWVsZD8NCj4+DQo+PiBObywgYXMgdGhlIGd1ZXN0IGlzIG5vdCBvcHRpbmcg
aW50byB0aGlzIGZlYXR1cmUsIGJ1dCBqdXN0IGdldHMgaXQNCj4+IHByZXNlbnRlZCwgdGhl
cmUgaXMgbm8gbmVlZCB0byBoYXZlIGFub3RoZXIgYml0IGZvciBuZXcgZXJyb3IgdmFsdWVz
Lg0KPiANCj4gVGhpcyBwcm9iYWJseSBuZWVkcyB0byBiZSBzcGVsbGVkIG91dCBpbiB0aGUg
ZG9jdW1lbnRzIHRoYXQuDQo+IA0KPj4gTm90ZSB0aGF0IHRoaXMgaXMgYSBwdXJlbHkgaW5m
b3JtYXRpb25hbCBpbnRlcmZhY2UuIFRoZSBlcnJvciB2YWx1ZQ0KPj4gKG90aGVyIHRoYW4g
MCkgaXMgb25seSBmb3IgZGlhZ25vc3RpYyBwdXJwb3NlcywgdGhlcmUgaXMgbm8gd2F5IGEN
Cj4+IGd1ZXN0IGNvdWxkIHJlYWN0IGluIGEgc2FuZSB3YXkgdG8gYSBzcGVjaWZpYyBlcnJv
ciBjYXNlLg0KPiANCj4gVGhpcyBjb3VsZCBhbHNvIGJlIHNwZWxsZWQgb3V0IGluIHRoZSBk
b2N1bWVudCwgaW4gdGhlIG5ldyBzZWN0aW9uICJUaGUNCj4gY29ubmVjdGlvbiBlcnJvciBm
ZWF0dXJlIiwgdGhhdCBhIHZhbHVlIG90aGVyIHRoYW4gMCBpcyBhIGNvbm5lY3Rpb24NCj4g
ZXJyb3IgZXZlbiBpZiB0aGUgZXJyb3IgbnVtYmVyIGlzbid0IGtub3duIHRvIHRoZSBjbGll
bnQuDQoNCk9rYXksIHdpbGwgYWRkIHNvbWV0aGluZyB0byB0aGUgZG9jIChmb3IgYm90aCBp
c3N1ZXMpLg0KDQoNCkp1ZXJnZW4NCg==
--------------Oe0ldEXZrcJvsjTFafS7jIjo
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------Oe0ldEXZrcJvsjTFafS7jIjo--

--------------yQHfNujSpnkp8SESQXV3HC6u--

--------------hbj147hcyzmyU0jgILszg2x0
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmIOKp0FAwAAAAAACgkQsN6d1ii/Ey+1
Ygf/RxCmxS7MHMbd84KonTNKvxhgyTrmNauQnhJ8aWqMxGsiRVn8gOd2A3Jvx6VX+SdFmg21UQhR
1/Hi+U+ozBs9oQ0VPl5cipBxpM9xf2Gy5xHcQWxRL7XQQ5X4QUf6/muiORhj1dEI/EdM9UHWK4WP
w3fiUijnA1K3naUsb00/ASBMK5hgrC7Zla5FuuDIIc3GA966UG4qoYvtYO9TnveUh7ydr/SSQcdl
M4sAo+7Q9MpEJzUSguX10ExXKddIpYB4t+Z0uaDls0eSC1UJvN41NBr4oPIKIcwzd8yFiQHnA8zy
1ee/d/B3Mr6c+PQVRO/AZ1LgTN/PQyhpGs2XpN/ZIQ==
=sYcV
-----END PGP SIGNATURE-----

--------------hbj147hcyzmyU0jgILszg2x0--


From xen-devel-bounces@lists.xenproject.org Thu Feb 17 11:01:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 17 Feb 2022 11:01:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274657.470202 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKeXC-0006Pj-AN; Thu, 17 Feb 2022 11:01:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274657.470202; Thu, 17 Feb 2022 11:01:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKeXC-0006Pc-6D; Thu, 17 Feb 2022 11:01:14 +0000
Received: by outflank-mailman (input) for mailman id 274657;
 Thu, 17 Feb 2022 11:01:13 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nKeXB-0006PU-JC
 for xen-devel@lists.xenproject.org; Thu, 17 Feb 2022 11:01:13 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nKeX9-0002em-GX; Thu, 17 Feb 2022 11:01:11 +0000
Received: from 54-240-197-231.amazon.com ([54.240.197.231] helo=[10.7.236.18])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nKeX9-0005PC-Ar; Thu, 17 Feb 2022 11:01:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=ILJlgiB2MVZhZyIdl6l4gpCNPlV65nDoLLW2Rp3c5Zw=; b=CHCkSz3/8TcTWqcHX8ucbiSAeR
	RqNDJYoIh6b4wDbzTA1qgjnxJtbzsMW8xFEZdNIYq3l7bX+CFNDTAagIqbLcI4kWCSFBOqI6TMBTv
	xF32689QKEPl2JpG4oXKhCHvzTXyS/HwzF+We/Hh4ieZ0rsnUDLRroHRze9gkZge6Um4=;
Message-ID: <7d934fd7-b1e2-8a9e-10dd-a213db93c689@xen.org>
Date: Thu, 17 Feb 2022 11:01:09 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.1
Subject: Re: [PATCH v6 02/11] xen: introduce CDF_directmap
To: Jan Beulich <jbeulich@suse.com>, Penny Zheng <penny.zheng@arm.com>
Cc: Bertrand.Marquis@arm.com, Wei.Chen@arm.com,
 xen-devel@lists.xenproject.org, sstabellini@kernel.org
References: <20220214031956.3726764-1-penny.zheng@arm.com>
 <20220214031956.3726764-3-penny.zheng@arm.com>
 <eb39c5a6-f5b1-ccf3-8d2b-802ae7da68d0@xen.org>
 <cdaf49b1-e64a-c104-3b79-a1633a67ee07@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <cdaf49b1-e64a-c104-3b79-a1633a67ee07@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Jan,

On 16/02/2022 09:34, Jan Beulich wrote:
> On 15.02.2022 21:26, Julien Grall wrote:
>> (+ Jan)
>>
>> Hi Penny,
>>
>> I am CCing Jan to give him a chance to...
> 
> Thanks, but ...
> 
>> On 14/02/2022 03:19, Penny Zheng wrote:
>>> diff --git a/xen/include/xen/domain.h b/xen/include/xen/domain.h
>>> index cfb0b47f13..24eb4cc7d3 100644
>>> --- a/xen/include/xen/domain.h
>>> +++ b/xen/include/xen/domain.h
>>> @@ -31,6 +31,10 @@ void arch_get_domain_info(const struct domain *d,
>>>    /* CDF_* constant. Internal flags for domain creation. */
>>>    /* Is this a privileged domain? */
>>>    #define CDF_privileged           (1U << 0)
>>> +#ifdef CONFIG_ARM
>>> +/* Should domain memory be directly mapped? */
>>> +#define CDF_directmap            (1U << 1)
>>> +#endif
>>
>> ... comment on this approach. I would be happy to switch to an ASSERT()
>> if that's preferred.
> 
> ... I think I did signal agreement with this approach beforehand.

You raised a concern and it wasn't 100% obvious whether you would still 
be happy if we merged it as-is.

So I preferred to ask rather than merging it and getting an angry 
e-mail/message afterwards :).

Anyway, this series is now fully acked. So I will commit the series in a 
bit.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Feb 17 11:01:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 17 Feb 2022 11:01:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274658.470213 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKeXF-0006gX-Hy; Thu, 17 Feb 2022 11:01:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274658.470213; Thu, 17 Feb 2022 11:01:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKeXF-0006gL-EW; Thu, 17 Feb 2022 11:01:17 +0000
Received: by outflank-mailman (input) for mailman id 274658;
 Thu, 17 Feb 2022 11:01:16 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=xzkl=TA=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nKeXE-0006fR-45
 for xen-devel@lists.xenproject.org; Thu, 17 Feb 2022 11:01:16 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ec5e39c7-8fe0-11ec-b215-9bbe72dcb22c;
 Thu, 17 Feb 2022 12:01:14 +0100 (CET)
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur03lp2053.outbound.protection.outlook.com [104.47.9.53]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-16-HJYdhSgqOM-rhwrN7qPJqA-1; Thu, 17 Feb 2022 12:01:13 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DB9PR04MB8393.eurprd04.prod.outlook.com (2603:10a6:10:25f::8) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.16; Thu, 17 Feb
 2022 11:01:10 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4995.016; Thu, 17 Feb 2022
 11:01:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ec5e39c7-8fe0-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645095674;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=zM5O0NIegQlxsb91H6RIMRG/er+065jMoSojdzl6S6Q=;
	b=TYPY4PDZj0qd1jgBfGHocq6yjire/7ThufXSXY/WjuTGtPcBhwk2W3MACD4rro8x2+lSVp
	eg5zz4pocbRh0EEr3UsEtBKW4VnGEVl9EjADeKJ9glK+tW4cEdv617inBJ+YsP3lzmVW+4
	lVwFd7P3232yapMK9stnqJ2sTz8ZUE4=
X-MC-Unique: HJYdhSgqOM-rhwrN7qPJqA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=KQR5tHm0FmEeH94C5RKwgbdaFuYzGqU32M072OB2hO5fVYIj6kyT4sO28JOfTd/h2f45hoKBwYnVMevw/sBdPTFuNf9CL29QT/ITB5HwoInbnzYt2GtOf0wMD32Sju4RCQYGb47KSAuFi2KsHzJBm31O64+hIQ9wX0eiw+XnL2yzcmZ8MYkquLINNvDXAmYGr0kB9fkpPzedWGuBx5cZgrabYECJBFwUpj0pTOLUTEm3Db+dbyx7RzK75tm+Zakmh9PtPbBZAvkosFZZIECoHDeuqSRycyG+p1emromuqJI1gAXe9q6Q6mEderr1X6+lA9sHN1VMrmoyiCl4UCoICA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=zM5O0NIegQlxsb91H6RIMRG/er+065jMoSojdzl6S6Q=;
 b=K8bV+/t4COAsnTQP+HuaoJvkgYU9T4M93o0s1fU3jAwmBKq+p7PC1x7X1tMf5K2UYIH5d6QhdP6BP+J+6m9TiDyhQ5P/4RuabNdnw8LUmkDrNXcTXAxG5OC1W621n5HDmuQ5AH2A7OaXzrZTKxJVVPTPsKmgDacwVJnedMtaoFELZlp9QjO3G0Ugwtd+dlm2ixlj4HLfUkRce8NbR6Pje+9SgKqtpNuk93noQ/znU3b/y5yRgg+8EkwcxfW/4h27hSlKr0x2BMV17cNVcaIjyOcDojzqI+gZL4X5GqTQ9oCR2PBeLm3vRF1GtzAcr81fB3t2kPb+B2dBXd7FMrcOUA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <c56aadc8-e568-4625-5d6f-bd2b8981f3ae@suse.com>
Date: Thu, 17 Feb 2022 12:01:08 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH RESEND v2] x86: introduce ioremap_wc()
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <8f56a8f4-0482-932f-96a9-c791bebb4610@suse.com>
Content-Language: en-US
In-Reply-To: <8f56a8f4-0482-932f-96a9-c791bebb4610@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR05CA0056.eurprd05.prod.outlook.com
 (2603:10a6:20b:489::19) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9238906f-8bb4-4832-752c-08d9f204ce45
X-MS-TrafficTypeDiagnostic: DB9PR04MB8393:EE_
X-Microsoft-Antispam-PRVS:
	<DB9PR04MB8393BB63DC70ED7D7F62E52EB3369@DB9PR04MB8393.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	5AL8La9bJwtxDuvrq8SCQfmpPoKj9GHkadxfxGpYoS20pKJXKjzb6x+wn3wQbTHXHdiSM8wCCZ6APTDCQeFRfFBler7jOtlHiJB76E90AS8r7wbBZo02kEdeNx7y4nGy883rnvyRHCtpZeyzEvsKte6jxeDo0qRRAxVNaYjmXVoZE49dJlVAOlaZclaZKQWzv9W7noxDNkPyy5xUMExYqhGyP6ghs4oCdHPrLfBEZaT5c3Tjlmz/fmNlDXBBZRvSkvFsRgmELkoQIDntXABUNyfxBqvTXsGdDJEUPQloMvaWTebS6D7pEy6RAIPnUF0aFQ9yOHRS/vqr8Lo35ciGbUeIEs42f0Ygu8QN7fw+OdJMF6cfP+QdiTwWdXlya1CHmXi0AqtPnR76CCmYVBe2SkvG+M/1/XrGxa98t1EvtKENuJjN/vloKRgRFqW15b9CXRkQUDSqJku/yaL+679GyCecNSMUdBYlwUzE9SXPwi4Hh12ct0cCzNCGGX+52jhPDKC0Ru3rwC4dTGdte4YAco5OuEfUYRg9jtWPfUnT98d19fvKkoPHVKNiYl7/8f+cZ2/JZ62stylQ8lT+u1VprqoRQ5v9CqnAFD5w9Wk7Ok/g+3o9hQaUFXX/NE+DvbbKBQz5uvq+wozjJ+hgsYVFlgJO0QxEqNTB83uuKvdb36ZYaFB3QCMTf0h2K2Uhy4VK4/W81ZC2ODEFXR4FaD+Ve3C8CTk5jfGNppE8D580Ddu7UQFhKxXwS8Ze8voc/AGZgby1RboRlwcjM/x4iOU91w==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66946007)(54906003)(6506007)(66556008)(31696002)(66476007)(6512007)(2616005)(86362001)(8936002)(38100700002)(6916009)(8676002)(316002)(6486002)(508600001)(4326008)(26005)(83380400001)(31686004)(5660300002)(36756003)(186003)(2906002)(43740500002)(45980500001)(473944003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?STVoamphVFliNGx2cmhuRzRoVm5oazNxTnllYTBYSUhESFMvQjc3T3BaV3Iz?=
 =?utf-8?B?aDA2UjEzdVZJQzZtaEpMQTFIajVQWVJQdHdoTnp6VjRWZkdSNlZtUHlyWHVp?=
 =?utf-8?B?RXlsMGxBaklKcitxVnBKamk1RCtYVjN0KzBzcll2ZTFqZWNZbHJiTDJtZ3Zm?=
 =?utf-8?B?bmR0QzFDMy8xcmxqRWUrS2tGamwzWUtmbnNua0wrdm4zNHJZQWlFbkRzWUZT?=
 =?utf-8?B?M2VZNWUxaUVLSmlBQUxsbERNemowU1htaURaN0ZIWmxPblN4Um1SUitXOW9G?=
 =?utf-8?B?TXJBUXdUNGFCbkR6WExYam10dkRqdnY0ckl0NjlwUzFPT2Y1MmpUenRqWEtq?=
 =?utf-8?B?K054czJXZE5CbHlwd1JlVEI2Tk9rK3huS3BvQ3hDTWFYSDM0Z2pWNzF6Q1Ay?=
 =?utf-8?B?RGVEaFh6Y1RRNnVHald0OWlycEk1R1JRWXhKR24xVWhBNlNuZ1RodS9aYzc0?=
 =?utf-8?B?blBWRFR0cEpoS3JKWGxMeGVUalFTYlh6MWR4MXlKSVBmVDhEZUE0c3FCOVRT?=
 =?utf-8?B?M3FneUMxTk1tVEVST1VVU0lSRThxQlllYms2SnFYNmEybmRPVjlqVUtvZ3cx?=
 =?utf-8?B?emRPUDY1ZmRNdk9tU0dMUHMycWNyQ1ExVnR1dUUwYUdyK2hyR2tzcDJid0hv?=
 =?utf-8?B?Tk5zRmdYaEt1QnowK3JaWjNya0tZaFBISGtYazhML3h6Z082Sm5WaVNkOHA5?=
 =?utf-8?B?L0Y2T01Qc2pNb0FxRUVMZVZLaDBwbUtmdE5xV2RJVjFiSmk1R0dhbkJLemM1?=
 =?utf-8?B?NURqTjdUTFR1VVVuVWJLRjBNWkF3d1hhQ1JMTU12LzU4RmZiaEdoZ1F3QXhX?=
 =?utf-8?B?eTZTV1FOWThRZXVHd0I5eGlVZ1kxMGJHcVVTRnlCdWJwM3JWSjRZN1o2QkJ4?=
 =?utf-8?B?aStoSVNVejFWb2VFemJ1R0pDeHZINFNQN3B5SlgvZ2ZSY0hid0lxRk80WFNF?=
 =?utf-8?B?MmQ3QU1CM1NFWjVpbDNkYWl5QWlWcnFLczJxN1ZYeThNZUFOYTFubDlET2Ew?=
 =?utf-8?B?VVU0bXRjQkI3a2xHY1hNV0R3ZVBCVHorcUoyTlJ4OHlNQldZYkpyN2hKNlNx?=
 =?utf-8?B?ZFpFQUtzV1BKTkszVzV3L1hHMzZIUE9VWmNlMS82ZU9EaHI5TTI2akVrQndM?=
 =?utf-8?B?T0k4SC84K3NQQ2ZHN2dEeHFEcDRzK2RJSDZuL0lhYlZvcm84bi9WamxWMElj?=
 =?utf-8?B?OWY3TUc4SnhqaVNXTk1OMU9Ub3NPUnUxc1dhem85cHdyMkhZZ0dHRnlmUjl3?=
 =?utf-8?B?OEFkOHc0eG9xY1pzWUxQOVlhYkxPSVhRSVRqVytYQXNYZzNINmlReURUNGpR?=
 =?utf-8?B?SnRrZUFIT2twUHBwbnRCSnFiOEVQT05MTmVTVjI2eGhIdnZPTGhMazZEVFpt?=
 =?utf-8?B?c2U4UGltZ3hOODVSOUlTQklqRzhpUFZKaE14ODJycE1RS3dqdlpQd29MRXVq?=
 =?utf-8?B?TEV6S3VoQlVBaUV1cm9NU3NaNFBndE13UGkzTE80N29rMlBpaGR6czNic2Vh?=
 =?utf-8?B?Z0RJWjZUTFdBMEUxa09NcmErZ0Y3OGNXaW1VeWR0dTlRVEVYZy9pdVUrbXpq?=
 =?utf-8?B?Wm9uRUE4aFhwZzUyNUd2NHRYRGhqT01pQ2VxM0wxNkpGZXc3RTNBQUoyOUFL?=
 =?utf-8?B?bGphYUszR3JmRGMxc3BnZTM5UWVlOTVpRVZVMGJkZ3hhOVhzRkRsZGtyeEFJ?=
 =?utf-8?B?SGQwZzk3eVVXRXNhdi9qRFJvSzlkdUt3Q3JhSFJlUnFjSFRNUFZ0TmpSQUJX?=
 =?utf-8?B?S05sZWhpSUhyRWxVTEhReW5FWjRuaCtDZGxMQVY2Qlg0aWpucG9wMkZqa21u?=
 =?utf-8?B?ZVdlbTE3ZnhDNjdZT3VCWUErNTdnejVJOFhhOVJSc2l6T05uVWY0NkliN3N2?=
 =?utf-8?B?dzhxcEtuNFl6VWFJeWRiNjB1aTFDTjdKSndHRElOVmVLa1FpTXY3eW05Sm9o?=
 =?utf-8?B?akUzRStrcUk2SXNSTnh5RDJ0Y1FURkp5cTZpeDl3dHg1b1BjT0RXSFd6VHlr?=
 =?utf-8?B?T0ZVRDB3b0RWR1NXZzJscmxva3M3bzBtR1pLdXVnRTUycFF6cmZURDlxMUU4?=
 =?utf-8?B?MGtlWXVhZnFMOVVVUlNoTWJseG9zOHRhOGlMV2hUT0ZBaWJSQlNZejk5MFU2?=
 =?utf-8?B?VGhOa1BJQlR5UDFnN2FsMFRwRnEzcUpzSHAvNkZlNHpwcUUyTm9uc0lEa01m?=
 =?utf-8?Q?7Dwxkysy3I/nLXV1eI3P3fk=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9238906f-8bb4-4832-752c-08d9f204ce45
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2022 11:01:10.5491
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IfMaBLa+D64+yGhqZ8+OL+tbQfUacDFStusHZCaJYJHPWTZoNr84icy6MJN8ecgYXS+jR0QIre990AdbqnIq6A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8393

In order for a to-be-introduced ERMS form of memcpy() to not regress
boot performance on certain systems when video output is active, we
first need to arrange for avoiding further dependency on firmware
setting up MTRRs in a way we can actually further modify. On many
systems, due to the continuously growing amounts of installed memory,
MTRRs get configured with at least one huge WB range, and with MMIO
ranges below 4Gb then forced to UC via overlapping MTRRs. mtrr_add(), as
it is today, can't deal with such a setup. Hence on such systems we
presently leave the frame buffer mapped UC, leading to significantly
reduced performance when using REP STOSB / REP MOVSB.

On post-PentiumII hardware (i.e. any that's capable of running 64-bit
code), an effective memory type of WC can be achieved without MTRRs, by
simply referencing the respective PAT entry from the PTEs. While this
will leave the switch to ERMS forms of memset() and memcpy() with
largely unchanged performance, the change here on its own improves
performance on affected systems quite significantly: Measuring just the
individual affected memcpy() invocations yielded a speedup by a factor
of over 250 on my initial (Skylake) test system. memset() isn't getting
improved by as much there, but still by a factor of about 20.

While adding {__,}PAGE_HYPERVISOR_WC, also add {__,}PAGE_HYPERVISOR_WT
to, at the very least, make clear what PTE flags this memory type uses.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
REPOST (in isolation) upon Roger's request. The header location change I
don't really consider a "re-base".

v2: Mark ioremap_wc() __init.
---
TBD: If the VGA range is WC in the fixed range MTRRs, reusing the low
     1st Mb mapping (like ioremap() does) would be an option.

--- a/xen/arch/x86/include/asm/mm.h
+++ b/xen/arch/x86/include/asm/mm.h
@@ -602,6 +602,8 @@ void destroy_perdomain_mapping(struct do
                                unsigned int nr);
 void free_perdomain_mappings(struct domain *);
 
+void __iomem *ioremap_wc(paddr_t, size_t);
+
 extern int memory_add(unsigned long spfn, unsigned long epfn, unsigned int pxm);
 
 void domain_set_alloc_bitsize(struct domain *d);
--- a/xen/arch/x86/include/asm/page.h
+++ b/xen/arch/x86/include/asm/page.h
@@ -349,8 +349,10 @@ void efi_update_l4_pgtable(unsigned int
 #define __PAGE_HYPERVISOR_RX      (_PAGE_PRESENT | _PAGE_ACCESSED)
 #define __PAGE_HYPERVISOR         (__PAGE_HYPERVISOR_RX | \
                                    _PAGE_DIRTY | _PAGE_RW)
+#define __PAGE_HYPERVISOR_WT      (__PAGE_HYPERVISOR | _PAGE_PWT)
 #define __PAGE_HYPERVISOR_UCMINUS (__PAGE_HYPERVISOR | _PAGE_PCD)
 #define __PAGE_HYPERVISOR_UC      (__PAGE_HYPERVISOR | _PAGE_PCD | _PAGE_PWT)
+#define __PAGE_HYPERVISOR_WC      (__PAGE_HYPERVISOR | _PAGE_PAT)
 #define __PAGE_HYPERVISOR_SHSTK   (__PAGE_HYPERVISOR_RO | _PAGE_DIRTY)
 
 #define MAP_SMALL_PAGES _PAGE_AVAIL0 /* don't use superpages mappings */
--- a/xen/arch/x86/include/asm/x86_64/page.h
+++ b/xen/arch/x86/include/asm/x86_64/page.h
@@ -152,6 +152,10 @@ static inline intpte_t put_pte_flags(uns
                                  _PAGE_GLOBAL | _PAGE_NX)
 #define PAGE_HYPERVISOR_UC      (__PAGE_HYPERVISOR_UC | \
                                  _PAGE_GLOBAL | _PAGE_NX)
+#define PAGE_HYPERVISOR_WC      (__PAGE_HYPERVISOR_WC | \
+                                 _PAGE_GLOBAL | _PAGE_NX)
+#define PAGE_HYPERVISOR_WT      (__PAGE_HYPERVISOR_WT | \
+                                 _PAGE_GLOBAL | _PAGE_NX)
 
 #endif /* __X86_64_PAGE_H__ */
 
--- a/xen/arch/x86/mm.c
+++ b/xen/arch/x86/mm.c
@@ -5895,6 +5895,20 @@ void __iomem *ioremap(paddr_t pa, size_t
     return (void __force __iomem *)va;
 }
 
+void __iomem *__init ioremap_wc(paddr_t pa, size_t len)
+{
+    mfn_t mfn = _mfn(PFN_DOWN(pa));
+    unsigned int offs = pa & (PAGE_SIZE - 1);
+    unsigned int nr = PFN_UP(offs + len);
+    void *va;
+
+    WARN_ON(page_is_ram_type(mfn_x(mfn), RAM_TYPE_CONVENTIONAL));
+
+    va = __vmap(&mfn, nr, 1, 1, PAGE_HYPERVISOR_WC, VMAP_DEFAULT);
+
+    return (void __force __iomem *)(va + offs);
+}
+
 int create_perdomain_mapping(struct domain *d, unsigned long va,
                              unsigned int nr, l1_pgentry_t **pl1tab,
                              struct page_info **ppg)
--- a/xen/drivers/video/vesa.c
+++ b/xen/drivers/video/vesa.c
@@ -9,9 +9,9 @@
 #include <xen/param.h>
 #include <xen/xmalloc.h>
 #include <xen/kernel.h>
+#include <xen/mm.h>
 #include <xen/vga.h>
 #include <asm/io.h>
-#include <asm/page.h>
 #include "font.h"
 #include "lfb.h"
 
@@ -103,7 +103,7 @@ void __init vesa_init(void)
     lfbp.text_columns = vlfb_info.width / font->width;
     lfbp.text_rows = vlfb_info.height / font->height;
 
-    lfbp.lfb = lfb = ioremap(lfb_base(), vram_remap);
+    lfbp.lfb = lfb = ioremap_wc(lfb_base(), vram_remap);
     if ( !lfb )
         return;
 
@@ -179,8 +179,7 @@ void __init vesa_mtrr_init(void)
 
 static void lfb_flush(void)
 {
-    if ( vesa_mtrr == 3 )
-        __asm__ __volatile__ ("sfence" : : : "memory");
+    __asm__ __volatile__ ("sfence" : : : "memory");
 }
 
 void __init vesa_endboot(bool_t keep)
--- a/xen/drivers/video/vga.c
+++ b/xen/drivers/video/vga.c
@@ -79,7 +79,7 @@ void __init video_init(void)
     {
     case XEN_VGATYPE_TEXT_MODE_3:
         if ( page_is_ram_type(paddr_to_pfn(0xB8000), RAM_TYPE_CONVENTIONAL) ||
-             ((video = ioremap(0xB8000, 0x8000)) == NULL) )
+             ((video = ioremap_wc(0xB8000, 0x8000)) == NULL) )
             return;
         outw(0x200a, 0x3d4); /* disable cursor */
         columns = vga_console_info.u.text_mode_3.columns;
@@ -164,7 +164,11 @@ void __init video_endboot(void)
     {
     case XEN_VGATYPE_TEXT_MODE_3:
         if ( !vgacon_keep )
+        {
             memset(video, 0, columns * lines * 2);
+            iounmap(video);
+            video = ZERO_BLOCK_PTR;
+        }
         break;
     case XEN_VGATYPE_VESA_LFB:
     case XEN_VGATYPE_EFI_LFB:



From xen-devel-bounces@lists.xenproject.org Thu Feb 17 11:03:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 17 Feb 2022 11:03:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274673.470224 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKeZI-0007fc-51; Thu, 17 Feb 2022 11:03:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274673.470224; Thu, 17 Feb 2022 11:03:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKeZI-0007fV-1Z; Thu, 17 Feb 2022 11:03:24 +0000
Received: by outflank-mailman (input) for mailman id 274673;
 Thu, 17 Feb 2022 11:03:22 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=xzkl=TA=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nKeZG-0007fI-75
 for xen-devel@lists.xenproject.org; Thu, 17 Feb 2022 11:03:22 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 37dbdf80-8fe1-11ec-8eb8-a37418f5ba1a;
 Thu, 17 Feb 2022 12:03:21 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2176.outbound.protection.outlook.com [104.47.17.176]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-26-DxL0BHYJMMOc3IQIJTP3Vg-1; Thu, 17 Feb 2022 12:03:19 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5534.eurprd04.prod.outlook.com (2603:10a6:803:d2::32)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.16; Thu, 17 Feb
 2022 11:03:18 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4995.016; Thu, 17 Feb 2022
 11:03:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 37dbdf80-8fe1-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645095800;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=22IXCnbo7+/Kthl1EIQKUx4jCq4taBINGjK3TR/zkic=;
	b=hqqgMLbsJd8dBSJkUdlE+WZ23J5Dhkf/L4GZccSkPeE9yX45bXBny2s+Wg/1axyOMx07iK
	R8kRaPpnwCD+dwlFSTCzNRR1eorojMWowjuy2Cb/dSsKotPajO4Rk2+W4aMfTKEWDWnj0Y
	Pc9Johx7YAhz/D06XnvFrSbDeSoo1sc=
X-MC-Unique: DxL0BHYJMMOc3IQIJTP3Vg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=iIa2idleg8NwJpGhVMBX77Rky8VJVUA+0Br6uaB7+dKtlkudpY29MWSAE5OkKbdWdHoDusJIbh1nfFtLMClhmj/hr8xpKMluwZMRtzLX1jYeBwrbYxdWO6MrFVwPg8e5nCTXWMx1gv4FPuyFKBMbCivbrVYmWKuO79LjWBAEFydJyXZayUz4zPy6tuJfmRJs9BP/n3LSmww9tcDIyZTYBW8eZmkqrFApToXq5vvaUIXwsXMDr60HICzB66//6l7lbTshMUARLfsnbv7XnsPqMLKXBlqx3EWoT+cP2t8TRVxVeUk8fzVwW5QHCOcjskPIXEVYPzgCUJq9uZXRd6jymg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Yfe7nauKf8aNurctFju3NHseneLi7dJXN6BM8N+QbyI=;
 b=WOH5/vVhBZyRJqW3vq71fGD5XLLipxdIqAakXlN79bpAdP2CQGaEF4C3UhAxeec+Gh5gZnUSWsg+33cy8qqUbihU2ui6BHWF2ud1NpAv5x4K8vMQkOw2bx7O/hd7QQAJcZ8tJLfQ28VoMfiONWdRsaufs749LwBtzRQYWKDVjj4YkZlthKeK6QHOB6qLRu4DcBG54zSV+H7ba3yek54XcIw6aSx6jrljRwSzLfIXVPB6zris+v7qHeAbbAiY+4+r4g4M4i5Kshe3aa+ho6X26JLaONfrFyMEgTxT90FtCoy42IiO7NCvfCsKjYp0/2fkEbNXw793hWNx2MhH/ijclQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <b22d6e6c-1810-8f04-7531-9d606478a79f@suse.com>
Date: Thu, 17 Feb 2022 12:03:16 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v2 1/3] x86/retpoline: rename retpoline Kconfig check to
 include GCC prefix
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220216162142.15384-1-roger.pau@citrix.com>
 <20220216162142.15384-2-roger.pau@citrix.com>
 <7e5f721c-9771-bf35-8b94-f7fec7cd6eeb@suse.com>
 <536a357b-b895-7fe6-f99d-e83f5ac44745@suse.com>
 <Yg4lgQlNBTyTlsLD@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Yg4lgQlNBTyTlsLD@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6PR05CA0029.eurprd05.prod.outlook.com
 (2603:10a6:20b:2e::42) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 434908c0-b09c-4c34-4488-08d9f2051a88
X-MS-TrafficTypeDiagnostic: VI1PR04MB5534:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB553483F3B663BDC92B6A6C5EB3369@VI1PR04MB5534.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	rV4Y6YX40s3xyxp5vs5tLO3Djoo+qwHfWZKQGQ4NGz+7mlzrd1rAKAPPNI21h8fUFdUP2WO2RR8g5HXOCdQmCX5rXtG702DJPs3S7ywpLOy05u7N2Ou4BYisOxH8tV5akib+3dIHFKgvMIrJgqkhGzKAjH1aruVPcS2L/MywpJYt5Q5X+eavtIjqsD3r++Fqrq6gN1QsvEgqbLfI+BY1wxWFkp843SQxyxkjsJu/MB9YGc6y0r+7hkfy/83739Mw58N7f4jWZkVi5ygAN+H30BlooRmUg4tbWwFRiku+x1sy7vqd0gw4VWqwJRpUMrIMMbz9LUNz39tylOL5IxOCs6IiHamFbFJw+ahM3nDQjnbMGDknIn9d3h5NXzLiiFUg0ZHcmLnCo/7BnfXov1BSKfVizwLeEssMBNnjh+Xx2WcM6AbRWPHNqfiPfL4dX6x8DDFr34Kq36jdmFRAREbe3eghfKVH8Lli5PiN7Qx0wc9tM+f1yZsf2DNdBTtl1t+mlEuz3oPk3OWi4Ey64nLzT4ZNp/7sf2FZ5KxLGAKP6iWuAoDshLdUrEQvjGhfZ45HzVjmYvpMYVygrsfCIuPduXSbqRQwRKfiV6ttT3UzGwkxnFYatlTz9uu5rtsfQOrDeCss4g2LpXRaayChQfHQMHkwYjqpYgX07PedgRhK45NI2wpu/jGKYxw4UsXTQYAysGjwN+w24MAtyTKfdYDQSD7ClkSlettKB7kFnq0aBX25McORgg6wx6mubAHGtoJW
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6916009)(6486002)(31696002)(54906003)(31686004)(316002)(86362001)(508600001)(36756003)(26005)(8676002)(6506007)(66556008)(66476007)(4326008)(8936002)(66946007)(53546011)(38100700002)(2616005)(6512007)(2906002)(5660300002)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?YCB1m7H/fdhRUizMKwtwH9vqVXcxZNcmhmal3PT1GmSc4GyrN1S4i1kD1yRA?=
 =?us-ascii?Q?+lhHIfQo4RtiARuDOckarJNRYHOzmJSyyY+CuV2AGyjiZpNWDlr/tJQzhTST?=
 =?us-ascii?Q?SJ0gNI7EO9EGz4uTbR4DT6mlPbgZeFKQ3eS5i853AKSJj69bmhPmaOKzXWRV?=
 =?us-ascii?Q?tr8AHwE962VOk0dDfvHKbkO/VQMVmjjjC24XOL1RW+7gex3cMW/jD3rmQmOK?=
 =?us-ascii?Q?EijR1FXsq4scJGe43ldnrNQMr3gE6xcbh92tYozuYvK06hhh70+0vPU1n+qv?=
 =?us-ascii?Q?B5/gBUlF3P36r9RTQNpfvKWl81Iw2F2nwctyn0fc43+adFmOe/IHWaHPmOaR?=
 =?us-ascii?Q?6+eYKHftcTLka8LhhKQ7mxGV/4Xj38vQQpFR69+y4a8aqgzFFDJIXHsXGvQl?=
 =?us-ascii?Q?Zx6oh6TSom1JuK2sZrh9oephPWOSIGmiGiz7o4qkEZhXxZf17Vn2wzB20dGm?=
 =?us-ascii?Q?9DCCD4AcMk5dwBfp+xvQ9wjiWe8mFr65podBJRjktBKlrrMjmo5nLu8PC7Oj?=
 =?us-ascii?Q?5c6+6LwpNintRC/UGtbo7EHNCsmqs0RHNFcwp5kNMJ4OwL7WLGCIyx6chdRq?=
 =?us-ascii?Q?KM89yOoGTK5RRboL8Cs282fqv5oEnzHD4eY424TmxaUynX4Qy9QQgGg/CpGB?=
 =?us-ascii?Q?mWF/+weiLJNbIGUNHigOJS02IB1TlJCqkIHQMkk1GWtxfviqGiGwbicduJhB?=
 =?us-ascii?Q?EWhP98EwJqXYAdunx4/LuUKSqCX5+UbvAh7ilc5GX5T1c0MBUP8sMBfhqS3I?=
 =?us-ascii?Q?mal6gauw7+yeiDRC9eYJ/hA57vnEJ00KJoJ4Y5D4ge016bZLCeu216c2tY4z?=
 =?us-ascii?Q?WxA8Ooc2CzLRaBubH9wtXuKbidjcBMhTnerONoiZjm3NXOTYez8WWf7xl9A1?=
 =?us-ascii?Q?2tbO4+VCYjPdeJ5N6Pue86pZJ8bOwc1hPIGj/oqylfp8CZEamW6Vip4cBmOG?=
 =?us-ascii?Q?3JjtKYP39BPuOdCRYpqF4ISh61KDBIH2zqRqVmyJOtU/U6vRUkEem+6gAluK?=
 =?us-ascii?Q?7rJL7FIF6JkBtVuLOJj3yGrNiax/RLMVUf2KTn2puTi7ECv6ZEHIZodYzgtv?=
 =?us-ascii?Q?uBwCvA5+GEv7f6kOmhtQPCmxsgdqY2RnvOCvYq4lnYMOP3ScHkKqG8E24OY0?=
 =?us-ascii?Q?lfeX601RZH6pwmcA4c/79vq0TDufVX72op3NeF9c44CtBAgpHEQb6oabbkJh?=
 =?us-ascii?Q?qCobgK947YgqunciWQSAwWv6UCHG4xcfHLKkRZMqwb6cPUDMCD+aBC/5z2gW?=
 =?us-ascii?Q?t1ibTaFKUG9NxaCEO+186/1oh1UvPG1MZpzBUZajFJjORruKoHRKujNdRBpm?=
 =?us-ascii?Q?V0IosjNrj6af93/i9TXN0pukceQQLCKJ2wydOPu4D1KcLZoHUt4C0zmKHyzO?=
 =?us-ascii?Q?H1YbeNVpNXGBS+e7vgmc/eAkPvbMZl+PL5tQG1ZmkQ4oIX8+pOO3RrdNLC6+?=
 =?us-ascii?Q?FknbyH+i2Hv7RYJN5+TXZj/aNpaxhsIqq0bMzp0FxtY4TM/HddL4rARgf71W?=
 =?us-ascii?Q?41qWEIfbj4k8k5TN/3TmkRaPYfSdVtd0Xd43awT0NmZyjB3MyKY7rD2ndWSE?=
 =?us-ascii?Q?nfXbQxZV1GD5TX9KU2gMyL4MIUPHkdwTHQ0Xl8/yMw/zTvIhVbCI78q8c0Nn?=
 =?us-ascii?Q?jKz/5TUOUQ15rj/4Yydc+EI=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 434908c0-b09c-4c34-4488-08d9f2051a88
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2022 11:03:18.4782
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: C2YXsOcujTIWkwOEToWf651XtXyRCyxl0hbmapR4Z2wfA4/mtJv+iNxnJ17SkV+6XVsvgm0j2La+dZEvQQuPEg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5534

On 17.02.2022 11:37, Roger Pau Monn=C3=A9 wrote:
> On Thu, Feb 17, 2022 at 10:04:01AM +0100, Jan Beulich wrote:
>> On 17.02.2022 09:59, Jan Beulich wrote:
>>> On 16.02.2022 17:21, Roger Pau Monne wrote:
>>>> Current retpoline checks apply to GCC only, so make it obvious by
>>>> prefixing the Kconfig option with GCC. Keep the previous option as a
>>>> way to signal generic retpoline support regardless of the underlying
>>>> compiler.
>>>>
>>>> No functional change intended.
>>>>
>>>> Signed-off-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>
>>>> Reviewed-by: Jan Beulich <jbeulich@suse.com>
>>>> ---
>>>> Changes since v1:
>>>>  - Put def_bool before depend on.
>>>
>>> Just for the record: A slightly shorter alternative would have been ...
>>>
>>>> --- a/xen/arch/x86/Kconfig
>>>> +++ b/xen/arch/x86/Kconfig
>>>> @@ -32,9 +32,13 @@ config ARCH_DEFCONFIG
>>>>  	string
>>>>  	default "arch/x86/configs/x86_64_defconfig"
>>>> =20
>>>> -config INDIRECT_THUNK
>>>> +config GCC_INDIRECT_THUNK
>>>>  	def_bool $(cc-option,-mindirect-branch-register)
>>>> =20
>>>> +config INDIRECT_THUNK
>>>> +	def_bool y
>>>> +	depends on GCC_INDIRECT_THUNK
>>>
>>> config INDIRECT_THUNK
>>> 	bool
>>>
>>> config GCC_INDIRECT_THUNK
>>> 	def_bool $(cc-option,-mindirect-branch-register)
>>> 	select INDIRECT_THUNK
>>
>> Oh, looking at patch 3 again (which I should have still had in mind)
>> this would of course not help. Yet ..
>>
>>> A more appropriate thing to use for "depends on" might have been
>>> CC_IS_GCC. With the next patch in mind this would then avoid
>>> potential confusion if e.g. Clang folks decided to (also) support
>>> the gcc style command line options.
>>
>> ... adding this dependency (and a respective one in patch 2) might
>> still be a good thing.
>=20
> So you would like to make GCC_INDIRECT_THUNK depend on CC_IS_GCC?

It would seem more clean to me, but ...

> That would be fine, but I think it's extremely unlikely for CLANG to
> adopt the GCC options - I've already mentioned at implementation time
> and they refused.

... I'm not going to insist.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Feb 17 11:10:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 17 Feb 2022 11:10:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274680.470234 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKegU-0000ia-PF; Thu, 17 Feb 2022 11:10:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274680.470234; Thu, 17 Feb 2022 11:10:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKegU-0000iT-M4; Thu, 17 Feb 2022 11:10:50 +0000
Received: by outflank-mailman (input) for mailman id 274680;
 Thu, 17 Feb 2022 11:10:49 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=xzkl=TA=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nKegT-0000iN-8C
 for xen-devel@lists.xenproject.org; Thu, 17 Feb 2022 11:10:49 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4254715a-8fe2-11ec-b215-9bbe72dcb22c;
 Thu, 17 Feb 2022 12:10:48 +0100 (CET)
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2050.outbound.protection.outlook.com [104.47.8.50]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-24-lAeUG71uPhSUUFpIzCS97A-1; Thu, 17 Feb 2022 12:10:46 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AS8PR04MB8295.eurprd04.prod.outlook.com (2603:10a6:20b:3b0::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.19; Thu, 17 Feb
 2022 11:10:46 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4995.016; Thu, 17 Feb 2022
 11:10:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4254715a-8fe2-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645096247;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Kti0RY/8Y7Xjs1ngXd4Mmv7UV0LLB6b9gpzST5i0JYw=;
	b=YHg+qAZhh+7Fp8UUcERh8Nf1kVufi17MXEsbCEo2i9hAt+sJ4emP3Lx1XJ2hPw5lE6pjCE
	suYVnPC+kxe98Wl2BX9IeWXE3ua7RpcTSTB5CRWrHSsdmcQ8gtYELdIrsYLMDsRTWu/8CB
	EZEoUo8FAr1ki/Jr8Iu2hQy6UueZHm8=
X-MC-Unique: lAeUG71uPhSUUFpIzCS97A-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=nx5FNRxcAVndwj14fIeqzw5Ujs6FWuWQVyhx/aJcWaJHpYQhq3tfw6s9YI5a8iJOTWsCg7uO11NFqgM33Rc5yxhSxQ6OYBg0UK+FJkjU00R2Nb13RU3jcezAK1YYj5QLeUp81demjNibTcIZ9jM26ExSgulsSKNOuKD8xsge7Q7/dR421ol4GIg6rNgFx5/7BFx+02+lp88dC8kRuFXYCRQ8OnnJ64iQfom6lC4RWuvOBQrtQ5w5aJpqT6t+TNgBnFf6KRaNS6zRQexFUPEPGlFGyyxzSgjkBaLghrEw9tZ6NguJL2JkNVrCHIYXUsdk62cmhdur5WHpfqYSEi9fxw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=nXodBuNaQM7i9evwYxPWnSfdDvuz6QkNlqIFHPxIVng=;
 b=hL+FcOzRTHiHzc5Kx9CVGrhDhhn9+MLLCa41tyL2uEir4eJJhQ4E4YI5zduo0zZV9e57yqT+p/ZPRmSBtCyFt73MY24XyKojnpZaJ09tV/e3hq52jB450kJRcK7cp+NOgiL6QaxMtQr5jFJFojxIgCqHks8NnSeJghEj4+WFtg03G2s9USS19qIFTZyWcMIeAodd+aA62Wvupv/YrXiHl47YVPSS2Cs0O8LKAvNs6JpV4xyaKp2Bcjsji98CG6zXhfuMzHJHcvEgiyz2jtStIt3ag33Yr3fn9G5deRt4HFseK840TIuE4IS/WycNXM9zGnEFmPQ0fCjPC3dqaW7Lgg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <8d9c1694-402f-9bb7-f221-5201baa39326@suse.com>
Date: Thu, 17 Feb 2022 12:10:44 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v2 3/3] x86/Kconfig: introduce option to select retpoline
 usage
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: Julien Grall <julien@xen.org>, Stefano Stabellini
 <sstabellini@kernel.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 George Dunlap <george.dunlap@citrix.com>, xen-devel@lists.xenproject.org
References: <20220216162142.15384-1-roger.pau@citrix.com>
 <20220216162142.15384-4-roger.pau@citrix.com>
 <b6dc1214-4f1d-f7df-50c4-d357a2380b30@suse.com>
 <Yg4kwK7XJJPNXUD7@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Yg4kwK7XJJPNXUD7@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS8PR04CA0155.eurprd04.prod.outlook.com
 (2603:10a6:20b:331::10) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 33e480a3-2c45-41f3-7c62-08d9f2062535
X-MS-TrafficTypeDiagnostic: AS8PR04MB8295:EE_
X-Microsoft-Antispam-PRVS:
	<AS8PR04MB8295D407205D7158219E4B09B3369@AS8PR04MB8295.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4125;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Rs4Ga+Z22w9cehFJBaf6mpE09+KI1GqdJgOrsw/r/esyzl9zFQbO0xsNC8xcw+XglPXDOfc+/FX/1cNwnEbHCAUrpJ+po4CqDR9oCiE9NMJHXUTLpITjqDZy4jnPj/JIiAU8HG5KQ4QePLimDmHThfh10TzEF00XvuYA0f98bSSWXtlOUXbyyxFMr2SENGBIl+yAjkoiSHNT86CxaDMT/a0R1wL9yDSictrkM1cuU/3zD69MDOLd9xr4lBrHEZkX7BJv/YRdXloMnNPZP1qSzIUhUUbl7xdjbBdtIuCBLlvSoECbslwfMia4gEyFRCNJikjAN15tBS7J0mF9Fd0rC8/RbBInsfcl115a5LiZXagkZUOrOSj5TpSe6KtIPhuBwLF5F4ZIErrRt8M5/7VVJJbsa903TwVin9K6SbNBsCJ1vNY+1+AxLkiRi42Yte6fHRjO76/CoFAPwbI//puEAXfXTLstsVITAHXR9/G+Q4zQsLuRc29TQe8JpUN7mxyxvUhT50x3RBHEJsTKkUg5mwfzkAgex3KWxveHnDhMuFaoEz44XLOqt2fVVLXJUSHuaGKgvhRN/lqG3Kh8a56GnfgNCw0voc8o7sf2Jss5Jnp9Dmx0F3EaBBpQhBcMu07jO/702KaHy58EhVmA1zcRtSfpaakF0jOedwqQItit9ATnS6gf9Xn3RS9OZh4tisD9n3J1wCPIlOaPhAFI6w3OF6tftuXD3K5Y7xox/+K74mmG5h4X8NgwAmCCVBG877ap
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(53546011)(6506007)(2616005)(31686004)(5660300002)(8676002)(6916009)(31696002)(66556008)(6512007)(2906002)(8936002)(54906003)(186003)(6486002)(508600001)(4326008)(36756003)(26005)(316002)(83380400001)(38100700002)(86362001)(66946007)(66476007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?Q4bzJuWF9TpY8rgbKgAfmQ3EAW55p9r8Ya18x/28JK3HtGcbFhJu4jRoSJX/?=
 =?us-ascii?Q?5uy/90gu0rpApRaNmObsKRKplnExMPgXV6jLq3nqhqsrftGHq1C7Rx9fJUyP?=
 =?us-ascii?Q?DClfNxK1XoUsUI4X1qKMApZzVYE95aAUoEdcD1TGVDeU7d1AhXmuDs1o44bx?=
 =?us-ascii?Q?w+rI8e/qpxF8RoTUKLqS8V7dEse9mahoFwdjIyDZmPI3y4zVpLtnme5Wida1?=
 =?us-ascii?Q?qSOHTbyvJmti/+dDqZ5aqZaJF4mU9eip7n49yEQd/owiKdyRy03WGO5lUOJ6?=
 =?us-ascii?Q?cLVROMgWWksMdv47hfS668s7eky9tFG0lrZNF7nWyHBNW/p+cUBne+myQUNI?=
 =?us-ascii?Q?aW3RhT5v6HIe820QVLMGIVq30JANebA8I6pQhItR3RiGNMlkfB0yws6pLpN2?=
 =?us-ascii?Q?2VhhBx6FDV3G84yeILk4aTopgxd7NoQAGQi9afcEh8jOx1lM3gZqCLnUrkKd?=
 =?us-ascii?Q?hVQudZosfTE983NjE+Zwo6d2irjQFXIASjpxnMUdzC4CLdxURt2fzkOOHYGz?=
 =?us-ascii?Q?Tlc1sqasA2Z5AUq0iQFDDNLveY/+rwwu8t92z+jb6pyCksWA/TeCG9Zmp5EI?=
 =?us-ascii?Q?WpuDBDsDs7pSOCtiU5EmkTb7swTc7jMraWfNOojPuJdX5Ucq2M3X59GVeygV?=
 =?us-ascii?Q?DsFzp4i6me+xXtnpkGJTTKjhIWnVQ55MP0md4xcWbM5b4lj3d7L32fQpWubx?=
 =?us-ascii?Q?u46l34NojJqedjIolw84bJ2S1A5CyZl1T3vxD7UxkNnrRIg5wUySW//4ooU0?=
 =?us-ascii?Q?l6nh9nGeFTvdujHOD0TTHWodfe05AvuKiN4wpR1SlXWa7sMtsf1Wp8EBrngu?=
 =?us-ascii?Q?omY5MDKeARj4XJpvMAlYJLLpv+V2WbqUf7Bl6oPL6S/z6YVwhPCqrD8uW87X?=
 =?us-ascii?Q?rrRPunTcfW1M+GcDq/tAqXsOJ/o2Qg5VF7qzh6gHeoSKcvjeUXT1y64/EB16?=
 =?us-ascii?Q?sCQ+sjzjKzvJ5YTv9Oj/hQXR1rZUIEA1w9X2rJjeCj+BjGNvT5fqCO43DAO1?=
 =?us-ascii?Q?yDJZA2NAJaXF0WeIDhCe9c64R6kDL+wHVKp6iuC4ec6smnmhZS2iBWPE28Op?=
 =?us-ascii?Q?runbCKFOUGVE8MFZXPBJU/1IBMpNh28L4lhrChjk0+WF3KbQHmR/+iPeQcGT?=
 =?us-ascii?Q?f/AqGNOWrJdzFdiNKKKzxvMeLwcXtnvuSIkIgHEYLmA9bPP0T178szWrU3p2?=
 =?us-ascii?Q?NuhlhfJirRcvsOvDSjT4wvcDjAY1MYuV14ouF1jX95/BHFwgKrmfU1Emnnhn?=
 =?us-ascii?Q?nGLbljwj/HdQucyeaP4aTohxZBUDt+ng+Mb10CuV9gCI43wslXvcP0SQgpOH?=
 =?us-ascii?Q?t6d+ketovVv3bJcyCPpIF4drtl4/cDQZcsqptqNnHz6ebvicnxph/NFxguWB?=
 =?us-ascii?Q?k4iNYZATttBRE2amzmC1ukHXbFJ/PI/Kgp/h9y+0t07YQhEz7FZx7yjJvQul?=
 =?us-ascii?Q?qJpn5v7OwNlLKkFHxkBh4+5B8b25gBp9dLUWFKzgYeGH6CdXtZqSG6kpHqkG?=
 =?us-ascii?Q?TjbP/qy/didfefy0Hg+4SWEJyrCteaV1AgxKnmLjHOv0QRYMwVhVeZcJ925t?=
 =?us-ascii?Q?nc/tM1F84JcemgO4OHuhWvtP6G1v/c+cdvHX4fe9OwgzaNCiz8f3caIonHdG?=
 =?us-ascii?Q?WnA4Rj49lFKKMD2pVx1T6lE=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 33e480a3-2c45-41f3-7c62-08d9f2062535
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2022 11:10:45.9029
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +sWq7qII1jweyLj7TIiBQbcA2/ej32AvNGiq9s6KtcZiXVQ4Rth8zSYt2S9rpc7X0JvN5HpUvL7kxt6TvhX23Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8295

On 17.02.2022 11:34, Roger Pau Monn=C3=A9 wrote:
> On Thu, Feb 17, 2022 at 10:07:32AM +0100, Jan Beulich wrote:
>> On 16.02.2022 17:21, Roger Pau Monne wrote:
>>> Add a new Kconfig option under the "Speculative hardening" section
>>> that allows selecting whether to enable retpoline. This depends on the
>>> underlying compiler having retpoline support.
>>>
>>> Requested-by: Andrew Cooper <andrew.cooper3@citrix.com>
>>> Signed-off-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>
>>
>> Reviewed-by: Jan Beulich <jbeulich@suse.com>
>>
>> There's one aspect though which I would like to see Arm maintainer
>> input on:
>>
>>> --- a/xen/arch/x86/Kconfig
>>> +++ b/xen/arch/x86/Kconfig
>>> @@ -38,10 +38,6 @@ config GCC_INDIRECT_THUNK
>>>  config CLANG_INDIRECT_THUNK
>>>  	def_bool $(cc-option,-mretpoline-external-thunk)
>>> =20
>>> -config INDIRECT_THUNK
>>> -	def_bool y
>>> -	depends on GCC_INDIRECT_THUNK || CLANG_INDIRECT_THUNK
>>
>> Moving this ...
>>
>>> --- a/xen/common/Kconfig
>>> +++ b/xen/common/Kconfig
>>> @@ -146,6 +146,22 @@ config SPECULATIVE_HARDEN_GUEST_ACCESS
>>> =20
>>>  	  If unsure, say Y.
>>> =20
>>> +config INDIRECT_THUNK
>>> +	bool "Speculative Branch Target Injection Protection"
>>> +	depends on X86 && (GCC_INDIRECT_THUNK || CLANG_INDIRECT_THUNK)
>>
>> ... here despite being explicitly marked x86-specific looks a
>> little odd. Since the dependencies are x86-specific, dropping
>> X86 from here would make my slight concern go away.
>=20
> Right - I've added the X86 because I was concerned about GCC or CLANG
> also exposing the repoline options on Arm, but that's not an issue
> because the compiler tests are only done for x86 anyway.
>=20
> Feel free to drop the 'X86 &&' and the parentheses if you wish.
> Otherwise I can resend if you prefer.

No need to resend just for this.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Feb 17 11:30:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 17 Feb 2022 11:30:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274687.470246 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKezN-000360-FR; Thu, 17 Feb 2022 11:30:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274687.470246; Thu, 17 Feb 2022 11:30:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKezN-00035t-Ar; Thu, 17 Feb 2022 11:30:21 +0000
Received: by outflank-mailman (input) for mailman id 274687;
 Thu, 17 Feb 2022 11:30:20 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9h7v=TA=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nKezM-00035n-PY
 for xen-devel@lists.xenproject.org; Thu, 17 Feb 2022 11:30:20 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id fc1f8a24-8fe4-11ec-b215-9bbe72dcb22c;
 Thu, 17 Feb 2022 12:30:19 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 75DE41F37D;
 Thu, 17 Feb 2022 11:30:18 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 25A4213BBF;
 Thu, 17 Feb 2022 11:30:18 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id emn0B8oxDmLCXQAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 17 Feb 2022 11:30:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fc1f8a24-8fe4-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1645097418; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=BERprfVQLlUU2/0r8f0rOy+5qxqLqk3fnm/xGVBRun4=;
	b=O1Y0TMtwIkx/68laJyAF3k1ebX172iok7RuvJtJM+mfoUz5ss9R6T2d9x2aox1Fgb7+NVO
	cHe2A+23FHigp29E5hOKQhBH4n6yEWclO97GWHsFgMcNWxuSYXN3G9KC6Svn9Om9MKESBv
	djA4EXKFLpt0mLVafUoB0FNpdi6UbGU=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>
Subject: [PATCH v2] tools/xenstore: add error indicator to ring page
Date: Thu, 17 Feb 2022 12:30:16 +0100
Message-Id: <20220217113016.8260-1-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

In case Xenstore is detecting a malicious ring page modification (e.g.
an invalid producer or consumer index set by a guest) it will ignore
the connection of that guest in future.

Add a new error field to the ring page indicating that case. Add a new
feature bit in order to signal the presence of that error field.

Move the ignore_connection() function to xenstored_domain.c in order
to be able to access the ring page for setting the error indicator.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
V2:
- add some clarifications (Anthony PERARD)
---
 docs/misc/xenstore-ring.txt       | 35 +++++++++++++++++++++++++
 tools/xenstore/xenstored_core.c   | 43 +++++++------------------------
 tools/xenstore/xenstored_core.h   |  1 -
 tools/xenstore/xenstored_domain.c | 34 +++++++++++++++++++++++-
 tools/xenstore/xenstored_domain.h |  1 +
 xen/include/public/io/xs_wire.h   |  9 +++++++
 6 files changed, 88 insertions(+), 35 deletions(-)

diff --git a/docs/misc/xenstore-ring.txt b/docs/misc/xenstore-ring.txt
index 16b4d0f5ac..b338b21b19 100644
--- a/docs/misc/xenstore-ring.txt
+++ b/docs/misc/xenstore-ring.txt
@@ -22,6 +22,7 @@ Offset  Length  Description
 2060    4       Output producer offset
 2064    4       Server feature bitmap
 2068    4       Connection state
+2072    4       Connection error indicator
 
 The Input data and Output data are circular buffers. Each buffer is
 associated with a pair of free-running offsets labelled "consumer" and
@@ -66,6 +67,7 @@ The following features are defined:
 Mask    Description
 -----------------------------------------------------------------
 1       Ring reconnection (see the ring reconnection feature below)
+2       Connection error indicator (see connection error feature below)
 
 The "Connection state" field is used to request a ring close and reconnect.
 The "Connection state" field only contains valid data if the server has
@@ -78,6 +80,19 @@ Value   Description
 1       Ring close and reconnect is in progress (see the "ring
         reconnection feature" described below)
 
+The "Connection error indicator" is used to let the server indicate it has
+detected some error that led to deactivation of the connection by the server.
+If the feature has been advertised then the "Connection error indicator" may
+take the following values (new values might be added in future without them
+being advertised as a new feature):
+
+Value   Description
+-----------------------------------------------------------------
+0       No error, connection is valid
+1       Communication problems (event channel not functional)
+2       Inconsistent producer or consumer offset
+3       Protocol violation (client data package too long)
+
 The ring reconnection feature
 =============================
 
@@ -114,3 +129,23 @@ packet boundary.
 
 Note that only the guest may set the Connection state to 1 and only the
 server may set it back to 0.
+
+The connection error feature
+============================
+
+The connection error feature allows the server to signal error conditions
+leading to a stop of the communication with the client. In case such an error
+condition has occurred, the server will set the appropriate error condition in
+the Connection error indicator and will stop communication with the client.
+
+Any value different from 0 is indicating an error. The value used is meant
+just for diagnostic purposes. A client reading the error value should be
+prepared to see values not described here, as new error cases might be added
+in future.
+
+The server will discard any already read or written packets, in-flight
+requests, watches and transactions associated with the connection.
+
+Depending on the error cause it might be possible that a reconnect via the
+ring reconnection feature (if present) can be performed. There is no guarantee
+this will succeed.
diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c
index 91d3adccb1..6e4022e5da 100644
--- a/tools/xenstore/xenstored_core.c
+++ b/tools/xenstore/xenstored_core.c
@@ -1455,35 +1455,6 @@ static struct {
 	[XS_DIRECTORY_PART]    = { "DIRECTORY_PART",    send_directory_part },
 };
 
-/*
- * Keep the connection alive but stop processing any new request or sending
- * reponse. This is to allow sending @releaseDomain watch event at the correct
- * moment and/or to allow the connection to restart (not yet implemented).
- *
- * All watches, transactions, buffers will be freed.
- */
-void ignore_connection(struct connection *conn)
-{
-	struct buffered_data *out, *tmp;
-
-	trace("CONN %p ignored\n", conn);
-
-	conn->is_ignored = true;
-	conn_delete_all_watches(conn);
-	conn_delete_all_transactions(conn);
-
-	list_for_each_entry_safe(out, tmp, &conn->out_list, list) {
-		list_del(&out->list);
-		talloc_free(out);
-	}
-
-	talloc_free(conn->in);
-	conn->in = NULL;
-	/* if this is a socket connection, drop it now */
-	if (conn->fd >= 0)
-		talloc_free(conn);
-}
-
 static const char *sockmsg_string(enum xsd_sockmsg_type type)
 {
 	if ((unsigned int)type < ARRAY_SIZE(wire_funcs) && wire_funcs[type].str)
@@ -1598,6 +1569,7 @@ static void handle_input(struct connection *conn)
 {
 	int bytes;
 	struct buffered_data *in;
+	unsigned int err;
 
 	if (!conn->in) {
 		conn->in = new_buffer(conn);
@@ -1612,8 +1584,10 @@ static void handle_input(struct connection *conn)
 		if (in->used != sizeof(in->hdr)) {
 			bytes = conn->funcs->read(conn, in->hdr.raw + in->used,
 						  sizeof(in->hdr) - in->used);
-			if (bytes < 0)
+			if (bytes < 0) {
+				err = XENSTORE_ERROR_RINGIDX;
 				goto bad_client;
+			}
 			in->used += bytes;
 			if (in->used != sizeof(in->hdr))
 				return;
@@ -1621,6 +1595,7 @@ static void handle_input(struct connection *conn)
 			if (in->hdr.msg.len > XENSTORE_PAYLOAD_MAX) {
 				syslog(LOG_ERR, "Client tried to feed us %i",
 				       in->hdr.msg.len);
+				err = XENSTORE_ERROR_PROTO;
 				goto bad_client;
 			}
 		}
@@ -1638,8 +1613,10 @@ static void handle_input(struct connection *conn)
 
 	bytes = conn->funcs->read(conn, in->buffer + in->used,
 				  in->hdr.msg.len - in->used);
-	if (bytes < 0)
+	if (bytes < 0) {
+		err = XENSTORE_ERROR_RINGIDX;
 		goto bad_client;
+	}
 
 	in->used += bytes;
 	if (in->used != in->hdr.msg.len)
@@ -1649,14 +1626,14 @@ static void handle_input(struct connection *conn)
 	return;
 
 bad_client:
-	ignore_connection(conn);
+	ignore_connection(conn, err);
 }
 
 static void handle_output(struct connection *conn)
 {
 	/* Ignore the connection if an error occured */
 	if (!write_messages(conn))
-		ignore_connection(conn);
+		ignore_connection(conn, XENSTORE_ERROR_RINGIDX);
 }
 
 struct connection *new_connection(const struct interface_funcs *funcs)
diff --git a/tools/xenstore/xenstored_core.h b/tools/xenstore/xenstored_core.h
index 190d2447cd..742812a974 100644
--- a/tools/xenstore/xenstored_core.h
+++ b/tools/xenstore/xenstored_core.h
@@ -206,7 +206,6 @@ struct node *read_node(struct connection *conn, const void *ctx,
 
 struct connection *new_connection(const struct interface_funcs *funcs);
 struct connection *get_connection_by_id(unsigned int conn_id);
-void ignore_connection(struct connection *conn);
 void check_store(void);
 void corrupt(struct connection *conn, const char *fmt, ...);
 
diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c
index d03c7d93a9..ae065fcbee 100644
--- a/tools/xenstore/xenstored_domain.c
+++ b/tools/xenstore/xenstored_domain.c
@@ -427,6 +427,38 @@ static void domain_conn_reset(struct domain *domain)
 	domain->interface->rsp_cons = domain->interface->rsp_prod = 0;
 }
 
+/*
+ * Keep the connection alive but stop processing any new request or sending
+ * reponse. This is to allow sending @releaseDomain watch event at the correct
+ * moment and/or to allow the connection to restart (not yet implemented).
+ *
+ * All watches, transactions, buffers will be freed.
+ */
+void ignore_connection(struct connection *conn, unsigned int err)
+{
+	struct buffered_data *out, *tmp;
+
+	trace("CONN %p ignored, reason %u\n", conn, err);
+
+	if (conn->domain && conn->domain->interface)
+		conn->domain->interface->error = err;
+
+	conn->is_ignored = true;
+	conn_delete_all_watches(conn);
+	conn_delete_all_transactions(conn);
+
+	list_for_each_entry_safe(out, tmp, &conn->out_list, list) {
+		list_del(&out->list);
+		talloc_free(out);
+	}
+
+	talloc_free(conn->in);
+	conn->in = NULL;
+	/* if this is a socket connection, drop it now */
+	if (conn->fd >= 0)
+		talloc_free(conn);
+}
+
 static struct domain *introduce_domain(const void *ctx,
 				       unsigned int domid,
 				       evtchn_port_t port, bool restore)
@@ -1305,7 +1337,7 @@ void read_state_connection(const void *ctx, const void *state)
 		 * dead. So mark it as ignored.
 		 */
 		if (!domain->port || !domain->interface)
-			ignore_connection(conn);
+			ignore_connection(conn, XENSTORE_ERROR_COMM);
 
 		if (sc->spec.ring.tdomid != DOMID_INVALID) {
 			tdomain = find_or_alloc_domain(ctx,
diff --git a/tools/xenstore/xenstored_domain.h b/tools/xenstore/xenstored_domain.h
index 1e929b8f8c..4a37de67a0 100644
--- a/tools/xenstore/xenstored_domain.h
+++ b/tools/xenstore/xenstored_domain.h
@@ -47,6 +47,7 @@ int do_reset_watches(struct connection *conn, struct buffered_data *in);
 void domain_init(int evtfd);
 void dom0_init(void);
 void domain_deinit(void);
+void ignore_connection(struct connection *conn, unsigned int err);
 
 /* Returns the implicit path of a connection (only domains have this) */
 const char *get_implicit_path(const struct connection *conn);
diff --git a/xen/include/public/io/xs_wire.h b/xen/include/public/io/xs_wire.h
index 4dd6632669..953a0050a3 100644
--- a/xen/include/public/io/xs_wire.h
+++ b/xen/include/public/io/xs_wire.h
@@ -124,6 +124,7 @@ struct xenstore_domain_interface {
     XENSTORE_RING_IDX rsp_cons, rsp_prod;
     uint32_t server_features; /* Bitmap of features supported by the server */
     uint32_t connection;
+    uint32_t error;
 };
 
 /* Violating this is very bad.  See docs/misc/xenstore.txt. */
@@ -135,11 +136,19 @@ struct xenstore_domain_interface {
 
 /* The ability to reconnect a ring */
 #define XENSTORE_SERVER_FEATURE_RECONNECTION 1
+/* The presence of the "error" field in the ring page */
+#define XENSTORE_SERVER_FEATURE_ERROR        2
 
 /* Valid values for the connection field */
 #define XENSTORE_CONNECTED 0 /* the steady-state */
 #define XENSTORE_RECONNECT 1 /* guest has initiated a reconnect */
 
+/* Valid values for the error field */
+#define XENSTORE_ERROR_NONE    0 /* No error */
+#define XENSTORE_ERROR_COMM    1 /* Communication problem */
+#define XENSTORE_ERROR_RINGIDX 2 /* Invalid ring index */
+#define XENSTORE_ERROR_PROTO   3 /* Protocol violation (payload too long) */
+
 #endif /* _XS_WIRE_H */
 
 /*
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Thu Feb 17 11:32:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 17 Feb 2022 11:32:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274696.470257 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKf1u-0003kz-Uj; Thu, 17 Feb 2022 11:32:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274696.470257; Thu, 17 Feb 2022 11:32:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKf1u-0003ks-Rg; Thu, 17 Feb 2022 11:32:58 +0000
Received: by outflank-mailman (input) for mailman id 274696;
 Thu, 17 Feb 2022 11:32:57 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=xzkl=TA=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nKf1t-0003km-OI
 for xen-devel@lists.xenproject.org; Thu, 17 Feb 2022 11:32:57 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 59e69cca-8fe5-11ec-8eb8-a37418f5ba1a;
 Thu, 17 Feb 2022 12:32:56 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2168.outbound.protection.outlook.com [104.47.17.168]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-27-TNl0pBOONhi79z-fqIFinw-1; Thu, 17 Feb 2022 12:32:54 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM0PR04MB6052.eurprd04.prod.outlook.com (2603:10a6:208:142::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.16; Thu, 17 Feb
 2022 11:32:52 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4995.016; Thu, 17 Feb 2022
 11:32:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 59e69cca-8fe5-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645097575;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Vh7KOYva6Ba093wY9CUMgReHNFbDuL2OEmcxgRhWDOo=;
	b=QuBn0Z8SaGhuiY0JF7eB8cc9QslKp611pWMOql/8OLuEXBuEYbm00rFPhR4l25H3Af/Rgq
	L1P5JGD7ru8Av5M3lN0KZmogWp/NLl0+tKKI2M89jda8wIQZjLAC9doPT1djwdthGN+6wK
	UlCS9YQ5QRcwnQWqHnRL34k4DGiLT2Y=
X-MC-Unique: TNl0pBOONhi79z-fqIFinw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=fdgJfoxp9BWHCY0n9qJf6q8SrKsv5iDf4GOFSFmDxoOp9agqKrKHuxH9rIVESp/df+Vs/oiKFMz0Mgu6JoTCPlL6YbfwGmwbuHK8yDj8Ax1jSyp6wcVQ0phwxgprU1pJ1g5QIY6ijAnQ07dq7JRcFdxYthlIGmAvmB3f2LLHZqjPHUcx2CcT1iXbt+aDEkyDevToaEkCBHtdhb0SWtsRwnWcmmMUDx8nD2tb4C/oGebr2Z/NMAL2B1M5tBDm2hllYV5sexixPxWpsRLUfujAQHi7HB1rrdoFgZWu5KXr3iiNp3jC1G6EQimDz5nr1OSUt8Jax0w/Lbt7t8R8afdZxQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=kvTUJhiMRJWr+rrdO40Y/ElFkK53sUNEBhoi51pO0uU=;
 b=ZZ20rR85gUgiwCNmnNy45/Wuo//sJGMjK5P2N4MVzcDM7hkGJvUQ3QqGLq0FDUo9rO8AZ1KgpaprnCBoqzi5IYU45FmfVhi5Y7D2+Zbhp1pbincC6Ud11HAHiqcpK8tdRAq42O18m4HrETZQAKfty2SDl4HcxmY6VVC7ip2Kb6+AUvz21MPreh1LR7o/64DIpD9Lt8rK8FYuvaGQdnChhpHztEEy4/HezwrhajoKo72LvahP+HrMWU/08QBwwY2K8yBf/4UNWM7/SKQgtm0J4xrJMSCztlgXYr5awNZAF+ANENfxNIkPZDDnuzx2HkumblU5ErsrROes+sTa446m6g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <e08b9837-9798-c884-6219-1680d319ba53@suse.com>
Date: Thu, 17 Feb 2022 12:32:50 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v2 06/70] x86: Introduce support for CET-IBT
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
CC: Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
 <20220214125127.17985-7-andrew.cooper3@citrix.com>
 <26bc666b-e9c3-7f12-6d8d-256311846233@suse.com>
 <b2236a34-b20e-6706-c5ab-6be5b47b8f6c@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <b2236a34-b20e-6706-c5ab-6be5b47b8f6c@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS8P251CA0014.EURP251.PROD.OUTLOOK.COM
 (2603:10a6:20b:2f2::13) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 1227a7a9-2184-45ad-f349-08d9f2093c0b
X-MS-TrafficTypeDiagnostic: AM0PR04MB6052:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB6052A524B6245E80A0A918F2B3369@AM0PR04MB6052.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	VEgYerq2CNyxGXsf4dEz/7hMvePCpAd9tSY7nVz/LQV/AG3W2eY4biU5U387OoHSqjPGrhj7FZLVtOi3Do6Yo5e6qzkiO/DYz4kx8Qx7yOp+IVIoVX3AVpwiMvrV/rfUt+/AjrHjsJxBb8HrZbjpF8hTkJOwtSa7EiFMphEPys/Bi1df0SGLMltKF0XQ3wEkAa9NKHDCIe7fGpKR4paV+31gxvr6LLCi3UqLtan7sAzTXiMkDmdTsumaRMdfnZgUAJc1vKJYJ/WdJLOjp5EcHSQzlAwyQprUWO5YdRcQYH+mwy5emAHdYKOtP6WCvI/9QATCc7OXQuqFkYcismRtfOyy/DmQ8e4awPdgEdCAxwQsCs6D5+L0lbeLde+49Vmm7Y8g/Dq6fDVoQIKlABRndEVLzH393RANw9KfX1cB6A/NgIuYQ10st0hZykWlDs5Q8fdbOY1MR0CMfuwq5ga8JSWUXGoUGOpOmGEvG0iSWcQOT7xhGa8lp4fsNByLO+NkkW73wikvp1MUkofzyi3lnK3EfNc7mKRTMAU+KZ2MUrXGo1hbZ/0oB3C5CE5nsYbvW88BbeZcHu0wYEMozOLB2s1dplcsxiZ7VtYyebMSV3JxVn37f9J4FWncI2PfIdXZLv36feBIOb3+PK4rSFOnR2p5a7yQhECYeoJAcY3DaDiml2sABQ1Eh11Q5Sw2X7rjOmLofhUObdjaANyeSNb1qVj0UMtq2jsfPjXX36HDwHJMrcoplimBIK8kE8dH5VEObNbBEGF0JBT2Q8mL3YiNwDiyfxuVjqO1OByZ/CDhKBYgfcsCFdHEHA0ZrDuZ/YRyYTgU3YCSPprhvO53aP1WhA==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2616005)(186003)(26005)(5660300002)(4326008)(31686004)(53546011)(6506007)(6512007)(508600001)(316002)(6916009)(54906003)(36756003)(6486002)(966005)(8936002)(2906002)(83380400001)(66476007)(86362001)(66946007)(8676002)(66556008)(38100700002)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?cpWLpz94M+qURkqtPTXraSD2kDAdmB94NFxqqD+aJjyyzGj0V8dvrQNcq+Hg?=
 =?us-ascii?Q?E4CAeDPf20tRKj6rZSvT/hOz0EOyc7GSbkWBheVFGTSyQikHrO5bzfpIOBR1?=
 =?us-ascii?Q?2rsfUmzlyDvLXxyu4/9pU01AwGubmt6QEVtSJqxoFvFLu/+T6c+OegEzKafy?=
 =?us-ascii?Q?xi11FrxSUehSvhpjFcczrbLgLE8JeD1bJCNfWFfzSPal7Bpl9GorMb/blqdb?=
 =?us-ascii?Q?uk2xoKbAvR5Y1oXASjLfoZ5YRrMjVfSMg7UYTAGzh/W2LEi33cWzJyd3Krzx?=
 =?us-ascii?Q?NigyUq9DjAXbuFm2bgtPdBzZphyNOoRm7Q7IZwUDL44lrPb81CRvdMQVQlki?=
 =?us-ascii?Q?yONwThZ6EsmmNGPyld/kYTQg2w9j59+nhpjk3tUJC4t0Xkq4CWdX1baKpYFo?=
 =?us-ascii?Q?97t7+C1SADEq1Jhe3/NMRAK8+XM9wQ+LYsIdlsBuPRhvhnjmCKYnDhd+yJLA?=
 =?us-ascii?Q?e2oG8UX25QAuMiX5XjTyCmawebcB3nDID9HslEm2y8asoHG4k/LVi06jZJ+X?=
 =?us-ascii?Q?mdqWtWboo6vwjRbzgi/fc82hh/AinWYvybR8VB3JY2kRPzB0Ewr2xEwLx5aC?=
 =?us-ascii?Q?h+uvz+0WPdtPvZ4gS8LoANInIiAwwrPEQctITvFDg9O0iDnTs6zYuZ2ilvvF?=
 =?us-ascii?Q?yjkm+1u4bu2PJeD+/Hr+xyUErUIyl3kZG5KL+y7WUNo2xdOaWIBufiVZCutX?=
 =?us-ascii?Q?gPb0XqufwmAjw4pymh6rwUt8x+zJHUtUGelf5snyaNqjjf9/5qBx8LmmC0B2?=
 =?us-ascii?Q?hySJ/dkSLabyoxCxEuvfrUiMqX1TyUmgsx6euF9pFSUoq5HGdXMCWMJl4kNW?=
 =?us-ascii?Q?uECUmrR7XwihOx3I5I+6PJULefyGF/1dr8xnCU6rpkmmUv35zDzykW9P17R3?=
 =?us-ascii?Q?MH8Uec5fsiHwnrGLOHp1PtaISeXMKmC0v+ymkMG+DZD7hJvkI6z+ji6n8WFc?=
 =?us-ascii?Q?8ty/izBuyr1Y4vN/CMrVwpJ1nT8z+s8acLEPU+dmjgaBLTLtbgu09z3o/Mrh?=
 =?us-ascii?Q?KX0TqiyebygYS77RRMcny13hZ7XJ4/vaIT44LTKU2n5BZ2nOk2OJb8xN6OCx?=
 =?us-ascii?Q?nr5yuY4EQaHEP62C6EGI7q9BMuU4Z6m+eoKJC6ODSRYSN+6ADLD0HPC78Ggg?=
 =?us-ascii?Q?9eYxd+4fddb/Xlspy8Tr7/YiENS6L6iLoSe0vI8fWmM+UScnRCfJ4qZXgTaK?=
 =?us-ascii?Q?S+DVzTDWfeiTZwAGnTgOn5D0wKlmOH7vF/TgF5XlFZ5LI6qRLLDbSJEcryKz?=
 =?us-ascii?Q?5i5WRFNf/+7qZNKtvo4VDIu329nTCnvF2yoyxsHj8GiS9khg7Q3ZwH2sFz/p?=
 =?us-ascii?Q?gOU2pvFs8NN2knTuMgVpcSDdg79wGc9LHZEVs1AfDU6qf5iZMrqPy3Egws1I?=
 =?us-ascii?Q?g2v2urUNsvcNZXTEexqfarL9bh8MaeVCfqR1vLtmsykqP+yf7RAguWJJyumb?=
 =?us-ascii?Q?EQ3Kx7zQdIN4N+s+XQurxYRKbrhU/Zazr6Sf7KVaLI+KPwl0AYrIZJSnBySN?=
 =?us-ascii?Q?ZCk9xxr8Y2IGBCFbg4l6rlxj+0vF+MpL1EGCaes+K5i9MvfzlJauYuuXIQWW?=
 =?us-ascii?Q?N/qjgTjaa/V10C/DLiJd3iphcABRjMAx4zNN3nlYDcNYMCPAi1d+H74gEsUb?=
 =?us-ascii?Q?N4oB+5eFnTY2v7MDxkMKX/g=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1227a7a9-2184-45ad-f349-08d9f2093c0b
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2022 11:32:52.7554
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9xTEg+sYeAuB7iC8Fcq7D4uM7mOFKqovv7lMTtEWVAtUwBrh0+QIaynmNP7K0jxm8S0iKRuTrzFEpzPfZ1F5Rg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6052

On 16.02.2022 22:54, Andrew Cooper wrote:
> On 15/02/2022 14:01, Jan Beulich wrote:
>> On 14.02.2022 13:50, Andrew Cooper wrote:
>>> --- a/xen/arch/x86/Kconfig
>>> +++ b/xen/arch/x86/Kconfig
>>> @@ -39,6 +39,11 @@ config HAS_AS_CET_SS
>>>  	# binutils >=3D 2.29 or LLVM >=3D 6
>>>  	def_bool $(as-instr,wrssq %rax$(comma)0;setssbsy)
>>> =20
>>> +config HAS_CC_CET_IBT
>>> +	# GCC >=3D 9 and binutils >=3D 2.29
>>> +	# Retpoline check to work around https://gcc.gnu.org/bugzilla/show_bu=
g.cgi?id=3D93654
>>> +	def_bool $(cc-option,-fcf-protection=3Dbranch -mmanual-endbr -mindire=
ct-branch=3Dthunk-extern) && $(as-instr,endbr64)
>> At the top of asm-defns.h we have a number of similarly operand-less
>> instructions expressed via .macro expanding to .byte. I don't see why
>> we couldn't do so here as well, eliminating the need for the
>> $(as-instr ...). In fact ...
>>
>>> --- a/xen/arch/x86/include/asm/asm-defns.h
>>> +++ b/xen/arch/x86/include/asm/asm-defns.h
>>> @@ -57,6 +57,12 @@
>>>      INDIRECT_BRANCH jmp \arg
>>>  .endm
>>> =20
>>> +#ifdef CONFIG_XEN_IBT
>>> +# define ENDBR64 endbr64
>>> +#else
>>> +# define ENDBR64
>>> +#endif
>> ... it could also be this macro which ends up conditionally empty,
>> but would then want expressing as an assembler macro. Albeit no, the
>> lower case form would probably still be needed to deal with compiler
>> emitted insns, as the compiler doesn't appear to make recognition of
>> the command line option dependent on the underlying assembler's
>> capabilities.
>=20
> $(as-instr) isn't only for endbr64.=C2=A0 It also for the notrack prefix,
> which GCC does emit for any function pointer call laundered through void
> * even when everything was otherwise cf_check.
>=20
> It's another area where treating the cf_check-ness as type-checking
> falls down, and created some very weird build failures until I figured
> out that Juergen's "Don't use the hypercall table for calling compat
> hypercalls" really did need to be a prerequisite.

Oh, I see. I can certainly accept this as a reason, but half a sentence
mentioning this would be nice in the description.

>>> --- a/xen/arch/x86/include/asm/cpufeatures.h
>>> +++ b/xen/arch/x86/include/asm/cpufeatures.h
>>> @@ -39,6 +39,7 @@ XEN_CPUFEATURE(SC_VERW_PV,        X86_SYNTH(23)) /* V=
ERW used by Xen for PV */
>>>  XEN_CPUFEATURE(SC_VERW_HVM,       X86_SYNTH(24)) /* VERW used by Xen f=
or HVM */
>>>  XEN_CPUFEATURE(SC_VERW_IDLE,      X86_SYNTH(25)) /* VERW used by Xen f=
or idle */
>>>  XEN_CPUFEATURE(XEN_SHSTK,         X86_SYNTH(26)) /* Xen uses CET Shado=
w Stacks */
>>> +XEN_CPUFEATURE(XEN_IBT,           X86_SYNTH(27)) /* Xen uses CET Indir=
ect Branch Tracking */
>> Is a feature flag actually warranted here, rather than a single
>> global boolean? You don't key any alternatives patching to this
>> bit, unlike was the case for XEN_SHSTK. And the only consumer is
>> cpu_has_xen_ibt, expanding to the boot CPU's instance of the bit.
>=20
> These are just bits.=C2=A0 They long predate alternatives finding a
> convenient use for the form, and are 8 times more compact than a global
> boolean, with better locality of reference too.

Well, I disagree (and we were here before, so I think you could have
predicted such a comment coming back). We should never have cloned this
directly from Linux. It's only bits, but with enough CPUs it sums up.
We shouldn't duplicate data when we need only a single instance (and
when no other infrastructure, like alternative patching, depends on it).

Last time you put me in a situation like this one, I told myself to not
ack such changes anymore, but here I am again - in the interest of not
being blamed for blocking this series:
Acked-by: Jan Beulich <jbeulich@suse.com>

Jan



From xen-devel-bounces@lists.xenproject.org Thu Feb 17 11:47:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 17 Feb 2022 11:47:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274703.470267 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKfFz-0005La-7A; Thu, 17 Feb 2022 11:47:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274703.470267; Thu, 17 Feb 2022 11:47:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKfFz-0005LT-4I; Thu, 17 Feb 2022 11:47:31 +0000
Received: by outflank-mailman (input) for mailman id 274703;
 Thu, 17 Feb 2022 11:47:30 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9h7v=TA=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nKfFy-0005LN-Ai
 for xen-devel@lists.xenproject.org; Thu, 17 Feb 2022 11:47:30 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 62360248-8fe7-11ec-b215-9bbe72dcb22c;
 Thu, 17 Feb 2022 12:47:29 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id B20971F37D;
 Thu, 17 Feb 2022 11:47:28 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6FB3113BBF;
 Thu, 17 Feb 2022 11:47:28 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id tj5sGdA1DmJTZgAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 17 Feb 2022 11:47:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 62360248-8fe7-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1645098448; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=uDJRyFd5hVkQNt9lps+kB/Y84BVoWZeCo2NQlN26dMc=;
	b=ddnVYCN4Mp8aGXWLtGMMIWx6JFk5hWeGRWr68NpKmaJY8CkNPckXi0o06FgaQxCr6vM/J9
	Z6XWIWgDvUMAmQcTNMqSKG4ExwClT3KIu0d+MDCPpTYPNd3zq8y/wLaNh0ei8ErrZ0VDhf
	wo2aMCa/4qPSU4WkHiUE41r1cccmzZk=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>
Subject: [PATCH v2] docs: add some clarification to xenstore-migration.md
Date: Thu, 17 Feb 2022 12:47:26 +0100
Message-Id: <20220217114726.8994-1-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

The Xenstore migration document is missing the specification that a
node record must be preceded by the record of its parent node in case
of live update.

Add that missing part.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
V2:
- rephrase to cover non-LU case, too (Julien Grall)
---
 docs/designs/xenstore-migration.md | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/docs/designs/xenstore-migration.md b/docs/designs/xenstore-migration.md
index 5f1155273e..b94af7fd7c 100644
--- a/docs/designs/xenstore-migration.md
+++ b/docs/designs/xenstore-migration.md
@@ -316,6 +316,11 @@ a _committed_ node (globally visible in xenstored) or a _pending_ node (created
 or modified by a transaction for which there is also a `TRANSACTION_DATA`
 record previously present).
 
+Each _committed_ node in the stream is required to have an already known parent
+node. A parent node is known if it was either in the node data base before the
+stream was started to be processed, or if a `NODE_DATA` record for that parent
+node has already been processed in the stream.
+
 
 ```
     0       1       2       3    octet
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Thu Feb 17 11:49:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 17 Feb 2022 11:49:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274710.470279 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKfI0-0005wv-Kl; Thu, 17 Feb 2022 11:49:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274710.470279; Thu, 17 Feb 2022 11:49:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKfI0-0005wo-Gv; Thu, 17 Feb 2022 11:49:36 +0000
Received: by outflank-mailman (input) for mailman id 274710;
 Thu, 17 Feb 2022 11:49:35 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=xzkl=TA=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nKfHz-0005wi-Bo
 for xen-devel@lists.xenproject.org; Thu, 17 Feb 2022 11:49:35 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id acc3d86f-8fe7-11ec-b215-9bbe72dcb22c;
 Thu, 17 Feb 2022 12:49:34 +0100 (CET)
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2056.outbound.protection.outlook.com [104.47.2.56]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-23-b-bfFyeQM4yNxpoCp1saoA-1; Thu, 17 Feb 2022 12:49:32 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AS1PR04MB9383.eurprd04.prod.outlook.com (2603:10a6:20b:4d9::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.14; Thu, 17 Feb
 2022 11:49:31 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4995.016; Thu, 17 Feb 2022
 11:49:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: acc3d86f-8fe7-11ec-b215-9bbe72dcb22c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645098573;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=RVjVVw/rYnFIm8d+oOZzUaWhthjUh/GTcopoalAfGZo=;
	b=S5lHTgzkq12iBRFDx2ubXBjxg69zMNMqLUGYboiirap5o2K7M9dKe/Y4gnfHFWrsjeAuDs
	THANc7DiHCrxnNJmVedRadK7nCz/mL6oMUj8XSzM2mKD2hEIROuqLvjWBxPttadBOvggAF
	oF3QNsxUFPX0t8TqvaxmYS6kXSZ5COE=
X-MC-Unique: b-bfFyeQM4yNxpoCp1saoA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=TA9NXyEdXsW1VwYW54WfGrmPBOVI4uZx3AVlEwEHu7SrODQ4MI1QGCcgAebF6uqpRjyr36Bw25tg9HTCmFOTXoc0bZ+9lVlW+9Kppoox5igv0W8Cu3y1/X5KPjUGQXsFYX8khcXBKGdKyMz5Ce8Zn7s0LGk3VCjMDTZmBZUPbogR/riz7rhArO0ZHXSdx9mXMY8+m1WgrhKl7rPUGyTqGAO4UbsgdmWtrALwCKW864ZXfUCbunO5CGlQVN4R3pn32wD39deaUrP5CDkMhqTG9f9sArNGaMIBhng6GK38/dZ3WifxXwfmMSyfDmp50hA3PW0WaH/uBrKdP3jN+li5AQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=f4slbJJaJD/qbmq3zdUhk6YCDPhBioSYx1cDovdkhHc=;
 b=Jnr1ybWjD4CSsgisMorG5w2LRh88WP9D3xIwr0aluJ4XyqFBy7JeY+Trf+aRLjP0NBFYmksebOPOCt+yAcaH4TEC4IAXb9eFT1St9Iejaep1mDPJhotnKDTuQP0QgjPrhvATAHcTcWgidVjljMoOxp173mBAw5AEDXrt5z3owtpqowULZ2R5yhmtLf50XulB/xrO9kRF58Y1Mu6C4tvaX/BnNIU4+pxTjbH07fqJMygsUDozHvYFFMM/VRxCn8oJOO9w86S42XaqASaRwNXW0t1i+4yO25mcV6wxns/eEv/AQPDD4faWjWCJkCKjvPCS5lF400x9oGpWswBIzBjvtA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <0696ce53-b126-edcd-7022-83d1d0688be7@suse.com>
Date: Thu, 17 Feb 2022 12:49:29 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v2 34/70] x86/emul: CFI hardening
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
 <20220214125127.17985-35-andrew.cooper3@citrix.com>
 <2a5e1893-506e-e4fc-dbff-6001feec1e99@suse.com>
 <d62fddef-5cae-7334-ed0b-cc2c9313f040@srcf.net>
 <21e40ac1-277a-8675-1299-54561ab3d2d6@suse.com>
 <18ddd7f8-98fd-a1b4-e694-32bc338a33ea@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <18ddd7f8-98fd-a1b4-e694-32bc338a33ea@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0376.eurprd06.prod.outlook.com
 (2603:10a6:20b:460::14) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 0910c98a-4377-4e62-447f-08d9f20b8f48
X-MS-TrafficTypeDiagnostic: AS1PR04MB9383:EE_
X-Microsoft-Antispam-PRVS:
	<AS1PR04MB9383073E8E2F7F083B5EC795B3369@AS1PR04MB9383.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	0YgcCYr3g8qbaG6YWQAMR69MtkcHX4/GtpeLkbIwOhwopKG560J4p/T6ahQP7/fe+yBKoeGD8McyY48DlnuDt/SLZOUSYHhXI5ffYerF3rRkCg1a+jfDriP8i9hsVXv0/elgOxg44ezcTtS002Phe3SZvrM4iIkYLV3En6mjusw1XBDUanWxjSqU05qyUgIZ5bZHl3XzHd5jjkttGg+Y0jgprl7f8YpSE84CKtLNQSBTfqQXW8HPa7CjpLTX3mpaDuyqutqw3Q8i4y9+UxwmXzEpcbRixJfYF34Wk+Wc+I9e5k5inNwCyL58wZua5J8yKJLOt2b2IYseK3j0pfY5/iKQyolGB5vhtLjltV4JLHD6AyuiCaMGaGyUESWtOtIUIKjEIrAIFo8cpmhuYWOhi5MaGv3li63y0GbW4pe/CVcwr24HcB41r6Gd/jQfbWZuGQHX5C5PNjlFq8xHqOCtXqIbhZbS4C6WQDr6QNGrsZbeW2lDtdvBw4kz2T7WFQDFLZQqMpdBRjxfkILKULn61WgBwfU9CLkjmerg9jYU3/X/6slpN5bmVc1uCcgWXLDr681JJltItKDwZZRPPnqA/0iHwHlIwPm86ar404OJm/3G+bl6nrmVTGoHDzDf5wOYfgAkk7pZ7CkRk7rxWg0KwvlYl7TWYIBFC0CJQBtq9wA9Hh/RELiLSHKoDn3nAyoFTeWhWNWxV5Ogt0lZSIXNNlmf+As1CuyPyATh7cZ3V2wkepfDMpZsitf6QgdJkJvW
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(186003)(6506007)(6916009)(5660300002)(8936002)(6512007)(26005)(66946007)(53546011)(83380400001)(86362001)(6486002)(38100700002)(31696002)(36756003)(66556008)(8676002)(316002)(2906002)(66476007)(4326008)(2616005)(508600001)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?LWtJjkEr3Xo/rpNlkfML/V4b1kncr3E7LSfDrlSIv8heAaTRAdqJaWsejKeQ?=
 =?us-ascii?Q?FVlnMY9mmRcntf5NKhqUwN1aJlzEUXT5hb0o/YNTBd34lfYpp48IcIPO3Vti?=
 =?us-ascii?Q?PN8AUAM9n7mugsILuDerouqYZnSPnZkOiQGQ4VrYGQAxog+SPSAo4oX1aIp/?=
 =?us-ascii?Q?iGEjRIbk44373ZWqqRu4EmHCNnd97cesph13mXwfM7KUFXsI37YibvVLjTYu?=
 =?us-ascii?Q?ppikl4d0SleQ9yZK+m7ZpJzDtTuHv/mURIMmfOmJuQNPDMSBQrdXqbMyoAYl?=
 =?us-ascii?Q?hb9Iec5blWJSAVPqPvYPJzPyY5pgN4fl9vBbIqX6gCXOYmbZjQmND5z/QT69?=
 =?us-ascii?Q?rspLS+tp07axeBjRJsbpgYvAjPSLKTqmHAvutLG8RM6SxqRtTLmjqyXYuBfo?=
 =?us-ascii?Q?bASk8U3pgyuzuJpea0/VMINF65UGlH/RwuIlPzq6hhwarqm6bANx8EJpH/Ib?=
 =?us-ascii?Q?sFG6nDEsLIKe+h2M37FY427lyx5pWTr8CPUKP1ZdgCP7ZIssE4lfpeHTkCFj?=
 =?us-ascii?Q?mC104vmiHeJOrk9R4zQmGWZ+9ODdObqxCAnKF0eTIP6gOUX63STc+kSDcyqy?=
 =?us-ascii?Q?FFcUEzyiSAA0aUkT6DrixEo9152OYhFzEQ22WuVqISChBWYS26N1A+g0xDeE?=
 =?us-ascii?Q?045+vkEUwkGJH8EkfQkEP1YGCqqP7iT6rbX149QC+4/njNJriJnRYcQG9tkS?=
 =?us-ascii?Q?cBqek+6PmrG7Ju7nju5utMt18pTGCDlBMtudkJk+VZwb22LMAzaCIREZj7Co?=
 =?us-ascii?Q?U+I+gvArauoaH7hvjsdeBfqIe+zT22YNRJS/4Pu1FqJAiJs0KQjT0/Kf1SIs?=
 =?us-ascii?Q?InqulXjSyVhzKM00UAOUQMj0+vs2ddGuMBLmZEYTZc+jRCGsajF2Mz0AFv+x?=
 =?us-ascii?Q?cyPRzkEYapeCuH3siBQJM/F4EaRfXZy6cnrCPtic2oB5SgR+XozlqLO+XNLG?=
 =?us-ascii?Q?mcUzlguGm2rgVo5fZbUdfTtLUnzceCTDNfh8ttUrSwnIOScF+a651Ikzs0TM?=
 =?us-ascii?Q?uyB6Iq7yZUTE3nfktVEe1OCdqw1nkXhIVdKPFG09TULD8F7gyjcBBCtfJt6Y?=
 =?us-ascii?Q?uODukYrvyhTCYcsMP6Z1pesDpZYIlR7bLQv+x4emAstugb/mIsX70F1jF5bd?=
 =?us-ascii?Q?UYb6lr0Gv8Wm96VBhehKYdLgxIw/XSbjdYnoB41ukJQzH5NRVYGBCLAi7bjU?=
 =?us-ascii?Q?mo9xoNiklysqNuNrcVck8wnx8sf+XfColb8t0PJpd1ak96VtnJZ5ngKM7O2u?=
 =?us-ascii?Q?h+dHJckE9v2ZmoRQkTyj+2YJIlZihHTnnbxE703qik6njZ6VGiIx7Pxdi66h?=
 =?us-ascii?Q?SFgx89VTn4bbbYLuXu/LKJC449X/VLEX9RYOOIEWw0qoi5wlk5MeuBZ3jVo/?=
 =?us-ascii?Q?zpIwvypy24rEBGEpVjvQOvfDXeDKyz25rxncR7xZDM0MobMupkszUGaHU+ql?=
 =?us-ascii?Q?DNveEN1If907GDI2VYTutQ12hALJHGNJZISUns618sQGNuV5lVyg2G1wt31p?=
 =?us-ascii?Q?22pFWZVyUKzcI55SppzSX2RBVEfhF2HMBiK77OUIxCIzoDSlus7COFeXSFGI?=
 =?us-ascii?Q?dnbWjgYEabetSdxWsC5o4/w18flxwI5Jf1iW5rii87byLFVJtSsk4sG24k+g?=
 =?us-ascii?Q?x9Dg4gORe6AngwM/fGCGYlA=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0910c98a-4377-4e62-447f-08d9f20b8f48
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2022 11:49:31.3950
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IRD8nqsSaQoWjic5o6SrGTmQmdUBFKnIsjDskHCrZYal31744m4avIHuHbBrLjn+PJPnJZ11SKxr/PhhLJwORQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9383

On 16.02.2022 22:34, Andrew Cooper wrote:
> On 15/02/2022 14:13, Jan Beulich wrote:
>> On 15.02.2022 14:43, Andrew Cooper wrote:
>>> On 14/02/2022 13:38, Jan Beulich wrote:
>>>> On 14.02.2022 13:50, Andrew Cooper wrote:
>>>>> Control Flow Integrity schemes use toolchain and optionally hardware =
support
>>>>> to help protect against call/jump/return oriented programming attacks=
.
>>>>>
>>>>> Use cf_check to annotate function pointer targets for the toolchain.
>>>>>
>>>>> pv_emul_is_mem_write() is only used in a single file.  Having it as a=
 static
>>>>> inline is pointless because it can't be inlined to begin with.
>>>> I'd like you to consider to re-word this:
>>> This is the reworded version.
>>>
>>>> It being static inline was for
>>>> the case of there appearing a 2nd user. I don't view such as pointless=
.
>>> I find that impossible to reconcile with your normal review feedback.
>> Interesting. I don't think I would have objected to something like
>> this, if it was conceivable that a 2nd user may appear. I don't
>> think this is the only inline function we've got with just a single
>> user. I also don't think this is the only inline function we've got
>> with its address taken, and hence having an out-of-line instantiation.
>>
>>> It is unconditionally forced out of line because of how it's used,
>>> meaning that if it ever got used in a second translation unit we'd end
>>> up with a duplicate function, at which point it would need to be
>>> non-static and exported to pass review.=C2=A0 (And sanity.)
>> I'm afraid you've lost me here. What duplicate function? Before and
>> after the patch the function is static; what changes is merely the
>> "inline". Two CUs can have identically named static functions, can't
>> they? Or if that's not the point you try to make, then I have no idea
>> what it is that you're trying to tell me.
>=20
> Yes, the same static inline can be out-of-lined in multiple translation
> units.=C2=A0 This creates two identical copies of the logic, and then fal=
ls
> foul of our unique symbols constraint.

How / where / when? If you care about unique symbol names, you've got
a Kconfig setting to enable.

> The absence of complaints in the general case shows that we don't
> currently any cases where a static inline is out-of-lined in multiple
> translation units.

Nope. I see reports of duplicate symbols (in their warning incarnation)
quite frequently. hvm.c#cpu_callback and hvm.c#cpu_nfb, to just name
two. Those aren't inline functions, but the naming constraints apply
equally.

> Under IBT, it means more tagged functions, which I suppose doesn't make
> a useful difference from the attackers point of view, but it's still
> logic duplication in the final build that we'd prefer to avoid.

Right, which is why I didn't object in any way (and you did have my ack
for the patch already anyway), but merely asked that you soften
"pointless" in the description. I really don't like it if, for reasons
I cannot follow, things are criticized more severely than (imo)
warranted. I'd like to point out that effectively you're reverting
08143c5b6c1f ("x86: move pv_emul_is_mem_write to pv/emulate.h") then
(just that the function moves to a different file now, following the
movement of its users), which you did give your R-b. (And yes, I know
views can change over time.)

Jan



From xen-devel-bounces@lists.xenproject.org Thu Feb 17 11:55:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 17 Feb 2022 11:55:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274719.470290 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKfNN-0007R0-C5; Thu, 17 Feb 2022 11:55:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274719.470290; Thu, 17 Feb 2022 11:55:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKfNN-0007Qt-8x; Thu, 17 Feb 2022 11:55:09 +0000
Received: by outflank-mailman (input) for mailman id 274719;
 Thu, 17 Feb 2022 11:55:08 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=xzkl=TA=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nKfNM-0007Qk-GA
 for xen-devel@lists.xenproject.org; Thu, 17 Feb 2022 11:55:08 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 70b7dc7b-8fe8-11ec-8eb8-a37418f5ba1a;
 Thu, 17 Feb 2022 12:55:03 +0100 (CET)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2106.outbound.protection.outlook.com [104.47.17.106]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-9-VkWHycLAPfu6R8MSsdqw7g-1; Thu, 17 Feb 2022 12:55:01 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM5PR04MB3219.eurprd04.prod.outlook.com (2603:10a6:206:7::16) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Thu, 17 Feb
 2022 11:54:59 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4995.016; Thu, 17 Feb 2022
 11:54:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 70b7dc7b-8fe8-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645098902;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=YnPS9/nD8c4KRFmp7yJHwrM/rXbMzTFeSeEuIKsSMe8=;
	b=ZCwgfBk2G1uowHPwiXtLoBiXUfHPoNuX1Dgl3C9yIZGWJ47E1gktvvjBKTrtHcLLXEiSRQ
	CV2KYQ4nLQPxwb9QMS02aChmgQeG7dpIveekF3/PeCl9XpGrNms/X1A1tE2Itj4Z+ePC3b
	9ZilWnF5MgfzD4dBXmbDA4sc1iIR7wI=
X-MC-Unique: VkWHycLAPfu6R8MSsdqw7g-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=as9HYgTqW+suX3UHm34nCBnaMUIg1J45YcMzYZ1jHYw7IvpEmkMz1Ul7all5L0qmcy0CA39AUuprvUBPYrGxNmNcJuUnpAsT6gG7aW7evqIxcC9u9M6OnJj+FrBFALtgk1Sj/eL+g5aMuf68qq5nSOCMsGPLRVlMkq2lq2d86xsl7Bp26xC2bgk3T0Fg92yqcACYTOi/NrYx2/06nv+JqSLG0zXEUU6A5pI/PBvEHYo4kFTzapyrgQOIWXs0tIMbWZ6L5mrpryJd2kYEeXwQZBkUvz2hHvsnEiTWWLKh1A/cgfLLohy+Hs6HHLu/1r6DpSBzxHdAvxBq55n04YjiTg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=lwCmrc+OOp3j0OsjVgwI0AAxApvQODONnngGicqeoXc=;
 b=Kj9hehfodl+8MuwoizzB7NGZyEWY2PcPIqk2/MwtNzPORMwFc1av8XiBj1KmV2kQkTEFC2EbmBxJ1WUiChJEsVWl+E1FiCdMzaEX9m9FkvDK+0CTDfgJORUHI2zAW+nkW1Hm9ZftZIoWJYoVPBxc6Ek6l4zm6o7wEqg4ZRYNqG9s5u0Hx+oStokiq2O4u9/pu5OKJQXIwoaRlnuiJQzVIhabaJ/KcKwy3y6nS7kkmaiB7hMupcP+eC6MYM+zItFy+2ydLputYzwZJjgrkVhTgda4jZF3PyeWuPh1P6PZdEGxPmpLNB5BU7eUWJXuVi/cXwa4C/eXGFuzxetil2+0MQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <16386211-4909-da40-3b0f-c76d64289cd3@suse.com>
Date: Thu, 17 Feb 2022 12:54:57 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH] x86/console: process softirqs between warning prints
Content-Language: en-US
To: Roger Pau Monne <roger.pau@citrix.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220217082850.19407-1-roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220217082850.19407-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0329.eurprd06.prod.outlook.com
 (2603:10a6:20b:45b::35) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5a5c6f3a-5d89-43fe-c5e3-08d9f20c530f
X-MS-TrafficTypeDiagnostic: AM5PR04MB3219:EE_
X-Microsoft-Antispam-PRVS:
	<AM5PR04MB32198E73AC84B27A32C20B20B3369@AM5PR04MB3219.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:142;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	VE+zzzjYnSUtOn6XJAqJyXxv3uZ/qaSFq6P9WkVDKVEVrKufaz5en5DLvxPYXjvIsWEsU2K20j+gdNRLZhtdL4aa7QFCjmt3//89Spkwrx2LsegRryGrLHauBK+sA0a/jOhelyT/vqkhxln9/2CUCCVApXuviqJDnp2tsghC1HTCuEiIbM8h+g2WgiCWZ/0hfBqoSERZo4n/y2FQ/SG2s95+nwUt9CXQLqixJyiVlwmh+RHik7UWQzHLZgG62/8hGTbIHexFPxznDsx3R8sCOhgbGXk6WGmMcH26bkdVkWgYZoLi7zRw2vxU11MkN6RyRMOesWNIFH/M5vVhvXYcPn9e0vMLw3WZG7L4+aGwvV/SDzbSadkdYc0DTS4dGFKQ7zlbKmz4X1YVFd0Rt704Vk1tFrp1i0Q9obNkQbm3/TxP8HF1YZNwmBoTdeLjG2zdNeTYY2DcmPb0mEVUzTym/ZpOPPduspYt85ddVJDlGl9AI3D923cgnOocN/Kri8wdvNJHRflPWSKYgu6uDmuP4HeCqT6Gyf+FfVGw+Ax+06i7gE/OY4911odIMXR+2/rVIhU0dNRVpJUZqZO7LxzqPn7nfaaITrgH4yVWQq57PeKwg+rYxvFvW8cdSvMnKAscWwLayMa+iMovMAqU4B+TnA9oI6ooE2GjA+j4+6TooYMPG2HaZuXWn4rGarKlvjz+mEKahgQvMUbZnNCcQczLFczcI9Yl9xr5fSIbgBSFey3wE9/Z7XkicioMgb6Q92Kk
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(86362001)(66476007)(4326008)(186003)(8676002)(6916009)(83380400001)(316002)(36756003)(6486002)(26005)(2906002)(31696002)(66556008)(5660300002)(53546011)(6512007)(6506007)(38100700002)(66946007)(31686004)(2616005)(508600001)(54906003)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?n+8SQUWEVLiRxa1G+ULgjYrjGJkewdmyKkFazoKttmV8L7nve8YVPUx5wO7C?=
 =?us-ascii?Q?b7EdnDP5p/ljs4l2vgXXyNb9V1EBQbYsIzbpKNxvyX5g8k5fm+6IQJiMP5c1?=
 =?us-ascii?Q?jSuTS+F2eTvYypulTZrUCeIfw6h9xMKjjYTCnijT5cmVuMR3Z0cBztIp8heF?=
 =?us-ascii?Q?jX8NBkKDS50uDsi0A//0bWg+NJbHU+EV7Wmj5jJauir24/uIqBgxKg8FtoPM?=
 =?us-ascii?Q?pEw4i5tSrD4fP8BHCMraA6q8HEt1l36jLO4HTM0CeNSszyh4mo9gHL6WVvLk?=
 =?us-ascii?Q?aPUyWlu9wM/E04ZOsUBuiuBEqsfXhnI3mPTylGsc065E5LD1DCgt+Jvr6iuc?=
 =?us-ascii?Q?Kv8sviGXIUWMshyjliacEQ5L5HnN2fxYhvUb+bolNhjqJWXK3fC5fxnt+Bhf?=
 =?us-ascii?Q?tT6wQM5LFAmmfXNVCyHtIAJ26neOLN3Ja5lfQg61jTpZXBC7MG+bJl1lmBf9?=
 =?us-ascii?Q?JWYLqOqcyKVMX3LwPJ8E8LLoo4he0Zfxd5ZirWhzU55LkZDfhKYYksWkXPXU?=
 =?us-ascii?Q?2P58LmEmUZzR1yl9iZGKDRHqrbY3J1e5DfW8+i94/7Fsu3dwtXtfoZCyP94H?=
 =?us-ascii?Q?4LgN0drMiuMlFes8A9qT4EfcmilBUSMNoMrrvGCJDCRK+1DaZ5kk7e9spKE9?=
 =?us-ascii?Q?uG6/2LLQ5toY++Hy1cThu96VHAxux4xK7ZP9b7EE9EoyVSZotYQ3dRfz0h7m?=
 =?us-ascii?Q?0DIKjfoFz5EiQJBucC0JkAn3wgUHkkvv81/9CXuAS7o7x9BdaH45hCfmaf5j?=
 =?us-ascii?Q?mad/TFb5VT85go3XnLC4scARH1R9iaJHqoWMMJ7RVTDa3r+UwQQlxncYneqc?=
 =?us-ascii?Q?zyb6e51VljbHBRlyiXpk+IWML6PO4Ly2N3HkhCdmegvTEhGQi2cTkfLthNSr?=
 =?us-ascii?Q?C7LtXFFQPWkJiK3tN4lI8nObwb7dkYM3si3Sz9yOpdAPFY0qALr8Ix5VbtDm?=
 =?us-ascii?Q?9QAc/VtynAon3CJ5EUWCfluPbzWfGdVjSFVIt3VWDPyg7xfFKBRjje3yEqp7?=
 =?us-ascii?Q?YkafRa8Ouut7Yp/oCdozA6RgFhAV7jLU3srZU526gOwUKkcEh3U97EpfBs7+?=
 =?us-ascii?Q?kV721ywmsM0qxF1jm30Pvf7NlTtzWUYJZglHqwNOabKiTKEDH+S/P1WPRgOc?=
 =?us-ascii?Q?Cez8VfN+tW3mAe71vsYmkg3FfN3T/eDRpnus7dabz+7hwaTagKaGnfhsFLDt?=
 =?us-ascii?Q?avFd3SHQf0o7uwvYQ8aFNtrXcCme2ECfzNUtGNAYZ4NwAT7gXxeVaz5KD56P?=
 =?us-ascii?Q?QcgBFrPUkh3nKaFzS0/zHTsG8M/2lE1VBf+uf0HTb0PF3aP2kGGhTXieK2C4?=
 =?us-ascii?Q?I3b8pGbWF8bEJsVg2Av3Yh2E/yWw5Oep2lRYS7TzdlJsRzOhHe2JnA3cs6V9?=
 =?us-ascii?Q?9nJU/OXwawegf3NPoDeC/ycqwg84Xkzlit/zdtJPRt4QeIqtmmhjixSsJHf5?=
 =?us-ascii?Q?Clxetna5EWn+vfP6RFTLlHKGp8J5lgPRmn/vQshDgRcDKC8Ag0KQcGs7DIqy?=
 =?us-ascii?Q?n3+mHgngZCbqYsi9INnM4csDmDMLBoAgY543Ap76MOJIKvfK4wYSPmdk4tNo?=
 =?us-ascii?Q?QrIhHfLGfdBuXLPVkO/huU6lAGDbeDu3CX7sf1QRHQ+m7GKBGAp0cn5tCK2n?=
 =?us-ascii?Q?XMgJaVl0bjhFGTot8am4S1Y=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5a5c6f3a-5d89-43fe-c5e3-08d9f20c530f
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2022 11:54:59.8113
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eQOoJR1OnraT/wJQtsxAtuXkvRD0jbM6+b476CvUWZcFGMokwn/gvtvxUxbAvwSqBjpM51FjLYJ79WzohhJwog==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR04MB3219

On 17.02.2022 09:28, Roger Pau Monne wrote:
> Process softirqs while printing end of boot warnings. Each warning can
> be several lines long, and on slow consoles printing multiple ones
> without processing softirqs can result in the watchdog triggering:
>=20
> (XEN) [   22.277806] ***************************************************
> (XEN) [   22.417802] WARNING: CONSOLE OUTPUT IS SYNCHRONOUS
> (XEN) [   22.556029] This option is intended to aid debugging of Xen by e=
nsuring
> (XEN) [   22.696802] that all output is synchronously delivered on the se=
rial line.
> (XEN) [   22.838024] However it can introduce SIGNIFICANT latencies and a=
ffect
> (XEN) [   22.978710] timekeeping. It is NOT recommended for production us=
e!
> (XEN) [   23.119066] ***************************************************
> (XEN) [   23.258865] Booted on L1TF-vulnerable hardware with SMT/Hyperthr=
eading
> (XEN) [   23.399560] enabled.  Please assess your configuration and choos=
e an
> (XEN) [   23.539925] explicit 'smt=3D<bool>' setting.  See XSA-273.
> (XEN) [   23.678860] ***************************************************
> (XEN) [   23.818492] Booted on MLPDS/MFBDS-vulnerable hardware with SMT/H=
yperthreading
> (XEN) [   23.959811] enabled.  Mitigations will not be fully effective.  =
Please
> (XEN) [   24.100396] choose an explicit smt=3D<bool> setting.  See XSA-29=
7.
> (XEN) [   24.240254] *************************************************(XE=
N) [   24.247302] Watchdog timer detects that CPU0 is stuck!
> (XEN) [   24.386785] ----[ Xen-4.17-unstable  x86_64  debug=3Dy  Tainted:=
   C    ]----
> (XEN) [   24.527874] CPU:    0
> (XEN) [   24.662422] RIP:    e008:[<ffff82d04025b84a>] drivers/char/ns165=
50.c#ns16550_tx_ready+0x3a/0x90
>=20
> Fixes: ee3fd57acd ('xen: add warning infrastructure')
> Signed-off-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>
> ---
>  xen/common/warning.c | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/xen/common/warning.c b/xen/common/warning.c
> index 0269c6715c..e6e1404baf 100644
> --- a/xen/common/warning.c
> +++ b/xen/common/warning.c
> @@ -30,6 +30,7 @@ void __init warning_print(void)
>      {
>          printk("%s", warnings[i]);
>          printk("***************************************************\n");
> +        process_pending_softirqs();
>      }

To be honest, I'm not convinced. This gets us pretty close to needing
to process softirqs after _every_ line of output. If a console is this
slow, the problem imo needs dealing with there (and according to irc
we appear on a helpful track there already), not by sprinkling more
process_pending_softirqs() all over the code.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Feb 17 11:58:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 17 Feb 2022 11:58:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274725.470300 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKfQq-000857-Nz; Thu, 17 Feb 2022 11:58:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274725.470300; Thu, 17 Feb 2022 11:58:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKfQq-000850-Kx; Thu, 17 Feb 2022 11:58:44 +0000
Received: by outflank-mailman (input) for mailman id 274725;
 Thu, 17 Feb 2022 11:58:44 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mzVd=TA=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nKfQq-00084u-2r
 for xen-devel@lists.xenproject.org; Thu, 17 Feb 2022 11:58:44 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f1876aa8-8fe8-11ec-8723-dd0c611c5f35;
 Thu, 17 Feb 2022 12:58:41 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f1876aa8-8fe8-11ec-8723-dd0c611c5f35
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645099121;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=zP5WKChedbDf2/dl7BiMkmk/iYp7HhvucErYv8k5dyw=;
  b=G7FJ5Xacn/mYokAOTGQ4ER/VtvXxHnhpb5b9MU41iJBMEwKXHcfC/f3d
   vyZROVioN2Pb1yYTSZoIrZ4u/HFqa88rjlkBnbfTpcjjB2b0znnDdLKex
   Nn2fblNttBYTnv8Q3sEbv9LYyNsTVI1GT/4tqUVGvgzSTYueSKvoPMDj7
   U=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: DSKVq1igvFteTYfgveL2meV3oavkMLNB++61d8H0iJJBuPSK/xIVYxnSZZsb7ieGQv6vZo64Xo
 u6rRvk+AbIWce6V7+xS1PPdD0q1oMZ7F5z4YLvYF9nHq3d0MuFFqp/znQl9xwZMLLxRf568G4o
 eOkB3Zp1G2CCuv5LOMIfLPX3324SAVU87QtBiXEZoYMeVfoPIjdbed7PcWAqb1SjVCFrP1ShNR
 raWyHnUq86w6bDDd1BxgijyljfU05D3ObrNKJmOb/ugQLDtKrbVl7cBGYm/zQdqIjr8IqZRokj
 GMKTQ3fFjKN6kQMhf5u0yL2Y
X-SBRS: 5.1
X-MesageID: 66663852
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Uw5ut69MkL8CY86LJJWsDrUDCnmTJUtcMsCJ2f8bNWPcYEJGY0x3n
 WAZXjiFP67ZYDD9e9Byadzj8RgBucDQmtVhHlRk/CA8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhFWeIdA970Ug5w7Rg3dYx6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhv9
 NdhioSLaTwHAYmSp9YyWh8fAQVHaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguwqKtXrO4UO/Glt1zjDAd4tQIzZQrWM7thdtNs1rp4QQ6iFN
 5dDAdZpRBnmYANNC3kaNNUdmeOhpFXDSBgAgU3A8MLb5ECMlVcsgdABKuH9ZdiiVchT2EGCq
 Qru/W3/DgsLKd+3xj+M83bqjejK9Qv8XI8RD7S++uRdiVuf3HEICBYWWF24ptG0kke7HdlYL
 iQ88ywit/JqrBSDQdz0Xhn+q3mB1jYMVtwVH+Ak5QWlzqvP/x3fFmUCViRGatEtqIkxXzNC/
 l2GhdTyHhR0raaYD3ma89+pQSiaYHZPazVYPGldEFVDs4KLTJwPYgznUOphPJGttf3ONw7Un
 Q+4gyE4wKc3tJtev0mkxmzvjzWpr5nPawc64ATLQ26ohj9EiJ6Zi5+AsgaCs6sZRGqNZhzY5
 SVfxZDChAwbJczVzESwrPMx8KZFDhpvGBnVmhZREpYo7FxBEFbzLNkLsFmSyKqEW/vomAMFg
 meP6Gu9B7cJZRNGiJObharrVKzGKoC6SLzYugj8NIYmX3SIXFbvENtSTUCRxXvxt0MnjLsyP
 5yWGe71UypHUf84kmbrHLhAuVPO+szY7TmMLXwc5076uYdymVbPEetVWLdwRrtRAFy4TPX9r
 I8EapriJ+R3W+zieCjHmbP/3nhRRUXX8ave8pQNHsbae1IOMDh4V5f5nONwE6Q4zv89vrqZo
 RmAtrpwlQOXaYvvcl7RNBiOqdrHAP5CkJ7MFXd9Zwn2hSl4MN3HAWV2X8JfQITLPddLlZZcJ
 8Tpse3ZahiWYjiYqTkbc7fnq4luKEaiiQ6UZnL3azkjZZ9wAQfO/4a8LAfo8SAPCAuxtNc//
 OL8hl+KH8JbSlQwFtvSZdKu00i14SoXltVtUhaaOdJUYkjtrtRncnSjkv8tLsgQAhzf3T/Gh
 R2OCBIVqLCV8Y84+dXEn46eqIKtH7csF0ZWBTCDv723KTPb7iyoxooZCLSEejXUVWXV/qS+Z
 LoKk6GgYaNfxFsT6thyCbdmy6469uDDnb4Cw1Q2BmjPYnSqFqhkfiuM0/5Qu/Af3bReowa3B
 B6Co4EIJbWTNcr5O1cNPw55PP+b3PQZlzSOv/Q4JEL2uH1+8LadCBgAOhCNjGpWLadvMZNjy
 uAk4ZZE5wu6gxssE9CHkiELqDjcci1eC/0q5sMAHYvmqgs30VUTM5XTBxj/7IyLd9gRYFIhJ
 SWZhfaairlRrqYYn6HfyZQZMTJhuKkz
IronPort-HdrOrdr: A9a23:akqZQ67DJcaQXjX56gPXwMrXdLJyesId70hD6qhwISY1TiW9rb
 HIoB17726RtN9/Yh0dcLy7V5VoBEmsk6KdgrNhWItKPjOW21dARbsKheCJrgEIWReOlNK1vZ
 0QCpSWY+eRMbEVt6jH3DU=
X-IronPort-AV: E=Sophos;i="5.88,375,1635220800"; 
   d="scan'208";a="66663852"
Date: Thu, 17 Feb 2022 11:58:29 +0000
From: Anthony PERARD <anthony.perard@citrix.com>
To: Oleksandr Andrushchenko <andr2000@gmail.com>
CC: <xen-devel@lists.xenproject.org>, <jgross@suse.com>, <wl@xen.org>,
	<jandryuk@gmail.com>, Oleksandr Andrushchenko
	<oleksandr_andrushchenko@epam.com>
Subject: Re: [PATCH v2] tools: remove xenstore entries on vchan server closure
Message-ID: <Yg44ZaC2YuftyEQe@perard.uk.xensource.com>
References: <20220216063325.1552217-1-andr2000@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220216063325.1552217-1-andr2000@gmail.com>

Hi Oleksandr,

On Wed, Feb 16, 2022 at 08:33:25AM +0200, Oleksandr Andrushchenko wrote:
> diff --git a/tools/libs/vchan/init.c b/tools/libs/vchan/init.c
> index c8510e6ce98a..ae9a6b579753 100644
> --- a/tools/libs/vchan/init.c
> +++ b/tools/libs/vchan/init.c
> @@ -251,6 +253,12 @@ static int init_xs_srv(struct libxenvchan *ctrl, int domain, const char* xs_base
>  	char ref[16];
>  	char* domid_str = NULL;
>  	xs_transaction_t xs_trans = XBT_NULL;
> +
> +	// store the base path so we can clean up on server closure
> +	ctrl->xs_path = strdup(xs_base);

You could do this in libxenvchan_server_init(), this might make it
easier to avoid leaking the path.

You need to initialise ctrl->xs_path in libxenvchan_server_init() in
any case before libxenvchan_close() is called.

I think you need to initialise ctrl->xs_path to NULL in
libxenvchan_client_init() as well even if it's not going to be used, to
avoid issue later in case the field start to be used.


> @@ -298,6 +306,23 @@ retry_transaction:
>  	return ret;
>  }
>  
> +void close_xs_srv(struct libxenvchan *ctrl)
> +{
> +	struct xs_handle *xs;
> +
> +	if (!ctrl->xs_path)
> +		return;
> +
> +	xs = xs_open(0);

There is missing a xs_close() call.

> +	if (!xs)
> +		goto fail;
> +
> +	xs_rm(xs, XBT_NULL, ctrl->xs_path);
> +
> +fail:
> +	free(ctrl->xs_path);
> +}
> +
>  static int min_order(size_t siz)
>  {
>  	int rv = PAGE_SHIFT;
> diff --git a/tools/libs/vchan/io.c b/tools/libs/vchan/io.c
> index da303fbc01ca..1f201ad554f2 100644
> --- a/tools/libs/vchan/io.c
> +++ b/tools/libs/vchan/io.c
> @@ -40,6 +40,8 @@
>  #include <xenctrl.h>
>  #include <libxenvchan.h>
>  
> +#include "vchan.h"
> +
>  #ifndef PAGE_SHIFT
>  #define PAGE_SHIFT 12
>  #endif
> @@ -384,5 +386,7 @@ void libxenvchan_close(struct libxenvchan *ctrl)
>  		if (ctrl->gnttab)
>  			xengnttab_close(ctrl->gnttab);
>  	}
> +	if (ctrl->is_server)
> +		close_xs_srv(ctrl);

Since init_xs_srv() is one of the last step of the initialisation of
*ctrl, I think close_xs_srv() should be one of the first step in
libxenvchan_close().

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Thu Feb 17 12:00:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 17 Feb 2022 12:00:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274734.470312 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKfSh-00016r-9W; Thu, 17 Feb 2022 12:00:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274734.470312; Thu, 17 Feb 2022 12:00:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKfSh-00016k-5V; Thu, 17 Feb 2022 12:00:39 +0000
Received: by outflank-mailman (input) for mailman id 274734;
 Thu, 17 Feb 2022 12:00:38 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mzVd=TA=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nKfSg-00013n-22
 for xen-devel@lists.xenproject.org; Thu, 17 Feb 2022 12:00:38 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 3715389b-8fe9-11ec-8eb8-a37418f5ba1a;
 Thu, 17 Feb 2022 13:00:37 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3715389b-8fe9-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645099236;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=8aVlUbec5+APin9fmOiz+4RSATpJ+Wu2Uo1xofp6+t0=;
  b=WKSIb56E8BL3QtGaikTyv6gVOzUKUtL9nzfjzEBvKY1GH3j2CTxoBTsW
   BPbIV2Git4LY9emFRhgVwy0s9XCTHBPqb9z3IWdiynBa/oGtAQCnDLaOz
   ocAlhKY7CrAv06FzyynctNYXXqUHAbBmvDTG1o1BkqFtBYtnrFQGtfz4K
   E=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: VZQ240aSSnAOwyU6YNTZc978hc503xwiTilpBp4gEgO88u6o1/EFWuIrvfQLWCshOYGldmIhz9
 EGj1LuA9KzMfgRxO/AslEDPzGrLHnJl84AyuZ+rNE4XUd4uBzhz0PanduqYKcsLYzLzGhSqoZe
 yZrURxSFOHOj/swAMueu5V0Q9RrIPgvFTu3pU04C+Nx4Prl5GLFNFwNTbRd6gKg4oFjv3JghJq
 +RmI563+zPOuNpLsuenPE5sxrPdYG7OFhdHCUbTv/8DNK15eHn+LViOeMJcCRrcQl+TbG43cSX
 WR6Hvs26RZ571ZS3w4g1FJGn
X-SBRS: 5.1
X-MesageID: 66663986
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:g4Beaqkqn5f28vfwaWZliIro5gwEIURdPkR7XQ2eYbSJt1+Wr1Gzt
 xJJW2uAbvnfamSkfo0jYYuwoUhVvJCAyNc1HAFqq3hhECMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BClVlxJVF/fngqoDUUYYoAQgsA180IMsdoUg7wbRh2Nc32YHR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 PNfp5KMVTYuAobrmL80cxRkDwBZbbITrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBMDtIIMYvGAm1TzDBOwqaZvCX7/L9ZlT2zJYasVmQ6iAO
 ZFIOWQHgBLoYzNKPWkTIckErv6h30PUSGcC8Q+aqv9ii4TU5FMoi+W8WDbPQfSIWMFUk0Cwt
 m/AuWPjDXkyL8eDwDCI9natgO7nni7hXo8WUrqi+ZZCn1m71mEVThoMWjOTo/ajjVWlc8lCM
 EFS8S0rxYAi+UruQtTjUhmQpH+fogVaS9dWC/c96gyG1uzT+QnxLmoOQyNFadcmnNQrXjFs3
 ViM9+4FHhQ27ufTEyjEsO7J83XiYkD5MFPuewciXxkL38XSp70YqRKUZ/ZuLLKUqY3qTGSYL
 y+xkAAygLAajMgu3qq9/Ezajz/EmqUlXjLZ9S2MADv7s1oRiJqNItXxtAOFtaoowJOxEwHZ1
 EXojfRy+wzn4XulsCWWCNsAE7iyjxpuGG2N2AU/d3XNGtnExpJCQWyyyG0vTKuKGpxdEdMMX
 KM1kVkOjHO0FCH3BZKbm6rrV6wXIVHITLwJrMz8YNtUeYRWfwSa5ixobkP49zmzzBV0yv5hZ
 crALpvE4ZMm5UJPlmXeqwA1i+JD+8zD7TmLGcCTI+qPitJym0J5uZ9aaQDTP4jVHYuPoRnP8
 sY3Cid54043bQEKWQGOqdR7BQlTdRATXMmqw+QKJr/rClc3QwkJVq6OqY7NjqQ4xsy5YM+Tp
 SrjMqKZoXKi7UD6xfKiMSE5N+2xDM0u9hrW/0UEZD6V5pTqWq73hI93Snf9VeVPGDVLwaEmQ
 v8bVd+HB/gTGD3L9y5ENcv2rZB4dQTtjgWLZnL3bD86dp9mZgrI5t67IVe/qHhQVnK65Zkkv
 rmt9gLHWp5fFQ5sO9nbNaC0xFSrsHlDxO8rBxnUIsNecVnH+ZRxL3Cjlec+JswBcE2RxjaT2
 wuMLw0foO3B/908/NXT3PjWpIa1CepuWEFdGjCDv7qxMCDb+EulwJNBD7nULWyMCjus9fz7N
 +tPzvz6PPkWp3pwstJxQ+Rx0KYzx9rzvLsGnA5qK2rGMgawAbR6L3jYgcQW7v9RxqVUsBedU
 16U/oUIIq2APc7oHQJDJAchaejfh/gYliOLsKYwKUT+oiR24KCGQQNZOBzV0H5RK758MYUEx
 +Y9uZFJt1zj20RyatvW3DpJ82msL2AbV/R1v54XN4bnlw43xwwQepfbECL3vMmCZtgk3pPG+
 dNIaH4uX4hh+3c=
IronPort-HdrOrdr: A9a23:oke1n6Etd0lJ9n7UpLqE6seALOsnbusQ8zAXP0AYc31om+ij5q
 eTdZUgpHvJYVkqNE3I9eruBEDEewK7yXcX2/h1AV7BZniEhILAFugLhuGO/9SjIVydygc079
 YYT0EUMr3N5DZB4/rH3A==
X-IronPort-AV: E=Sophos;i="5.88,375,1635220800"; 
   d="scan'208";a="66663986"
Date: Thu, 17 Feb 2022 12:00:31 +0000
From: Anthony PERARD <anthony.perard@citrix.com>
To: Juergen Gross <jgross@suse.com>
CC: <xen-devel@lists.xenproject.org>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, "Jan
 Beulich" <jbeulich@suse.com>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v2] tools/xenstore: add error indicator to ring page
Message-ID: <Yg44354PEvJdYiIV@perard.uk.xensource.com>
References: <20220217113016.8260-1-jgross@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220217113016.8260-1-jgross@suse.com>

On Thu, Feb 17, 2022 at 12:30:16PM +0100, Juergen Gross wrote:
> In case Xenstore is detecting a malicious ring page modification (e.g.
> an invalid producer or consumer index set by a guest) it will ignore
> the connection of that guest in future.
> 
> Add a new error field to the ring page indicating that case. Add a new
> feature bit in order to signal the presence of that error field.
> 
> Move the ignore_connection() function to xenstored_domain.c in order
> to be able to access the ring page for setting the error indicator.
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>
> ---
> V2:
> - add some clarifications (Anthony PERARD)

Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Thu Feb 17 12:06:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 17 Feb 2022 12:06:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274743.470323 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKfYi-0001qS-UU; Thu, 17 Feb 2022 12:06:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274743.470323; Thu, 17 Feb 2022 12:06:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKfYi-0001qL-RS; Thu, 17 Feb 2022 12:06:52 +0000
Received: by outflank-mailman (input) for mailman id 274743;
 Thu, 17 Feb 2022 12:06:51 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=W+1Z=TA=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nKfYh-0001qF-H3
 for xen-devel@lists.xenproject.org; Thu, 17 Feb 2022 12:06:51 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 14f01089-8fea-11ec-8723-dd0c611c5f35;
 Thu, 17 Feb 2022 13:06:49 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 14f01089-8fea-11ec-8723-dd0c611c5f35
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645099609;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=UwxJpcOon4iEybAaIBAUJENkEQjUrLrGY7Hrv1Ijb3M=;
  b=E8CljPmrsAEYVCk5Ta0GIpO2tFZ9qm7PAfl+h7PhXjS1IRfpYFNN87RN
   Nz3tpeefEqvcK8+UtBX7K7Gs7NvU1MtEBqoxis1QL40lQtRCPX7VC6wbH
   XAguwTEdO87nLuyFQby8grXWdCfBhh8PsViV+cuImZGUA/xL6tTbcBGA3
   Q=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: jkZzGRfK5o3BLOqBOsLTIGaFQYAoPpCbATj+zgtzoeN1lLCe4IQQCmMAlYSMfm0TB+hVyo5WpH
 ye50oVLq+p/LbIosIOo7x3EgLPLgPwKaqOq2VRDZ5c2qoNgaYga80O/WT3y6ULOXo7ijsKiBUc
 Z/czcMXvqE8hiHUW4eRNjY0+16L9Pwd+Qm7oM0/kwn38aI+cRd515W5VvPSQbZ7wjyb9Ag21UA
 s00k7xANcr4JmNIaN5frcSygZGxjsl24jAdSCns2clO5ffAUfdvNDxoWbA6Ai1AiVCWNnekgb8
 U+IhJ3qJLimxTn64ch6OvIxs
X-SBRS: 5.1
X-MesageID: 63865198
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:9XYcZ6x2mJcFrAQ5Tkp6t+fswSrEfRIJ4+MujC+fZmUNrF6WrkUAx
 mBOWzjVPqneMTT1KN8laI3goUsPvsWEzYU1TQNk+yAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAhLeNYYH1500g7wbdm2tcAbeWRWGthh
 /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL
 wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt9Zj9
 /ZxuqS7dSokA/KXouosfSJaQy4raMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr
 6ZBbmlQMFbT3Ipaw5riIgVoru0lINPmI8U0vXZ4wCuCJf0nXYrCU+PB4towMDIY2JseQ6uHN
 ppxhTxHdE6RYgBPC2srJZMjx+imiyLWQ2Z0gQfAzUYwyzeKl1EguFT3C/LFd9rPSchLk0Kwo
 mPd43+/EhwcLMaYyzeO7jSrnOCntTz/cJIfEvu/7PECqF+Zy3EXCRYWfUCmuvT/gUm7M++zM
 GRNpHBo9/JrshX2EJ+tBHVUvUJooDYaSeVzL+IC4z2gx5eLuDyXN0Y/TG5OPYlOWNANeRQm0
 VqAntXMDDNpsaGIRX/1yop4vQ9eKgBOczZcOHZsoR8tpoC6/dpt1k6nosNLTfbt5uAZDw0c1
 NxjQMIWo7wIxfAG2Kyglbwsq2L9/8OZJuLZC+i+Y45E0u+bTNL0D2BLwQKChRqlEGp/ZgPe1
 JTjs5LDhN3i9bnXyESwrBwlRdlFHcqtPjzGmkJIFJI87Tmr8HPLVdkOvGwmfxg3bptfJmKBj
 KrvVeV5vsA70JyCN/IfXm5MI55ykfiI+SrNDZg4keaikrAuLVTarUmClGab3nz3kVhErE3ME
 czzTCpYNl5DUf4P5GPvH481iOZ3rghjlTK7bc2qlHyPjOvBDEN5vJ9YaTNimMhit/jayOgUm
 v4CX/a3J+J3C7ykPXeJoNVCdjjn7xETXPjLliCeTcbaSiJOE2A9Ef7Bh7Qnfo1uhaNOkenUu
 Hq6XydlJJDX3BUr8C2GNSJubq3BR5F6oS5pNCAgJw/wiXMifZyu/OEUcJ5uJesr8+lqzPhVS
 fgZeprfXqQTG2qfozlNP4PgqIFCdQiwgV7cNSSSfzViLYVrQBbE+4G4c1K3pjUOFCe+qeA3v
 6akilHAWZMGSgk7VJTWZfujwkmfp38YnO4uDULELsMKIBfn8ZRwKjy3hfgyepleJRLGzzqc9
 gCXHRZH+rWd/95rqIHE3PnWoZ2oHu1yGlthM1PatbvmZzPH+meDwJNbVLradz7qS26pqr6pY
 v9Yzq+gPaRfzkpKqYd1D51i0bk6u4n0v7ZfwwlpQCfLYlCsBu8yK3WKx5AS5KhEx7sfsgqqQ
 EOfvNJdPOzRas/iFVcQIisjb/iCiq5IymWDs6xtLRWo/jJz8ZqGTV5WbkuFhyFqJbdoNJ8on
 LU6s8kM5g3j0hcnP75qVMyPG7hg+pDYb5gaiw==
IronPort-HdrOrdr: A9a23:HAz5zam4aolSw6ppPvJ5VUKUnFTpDfOIimdD5ihNYBxZY6Wkfp
 +V88jzhCWZtN9OYhwdcIi7SdS9qXO1z+8R3WGIVY3SEjUOy1HYUL2KirGSggEIeheOudK1sJ
 0PT0EQMqyIMbEXt7eY3OD8Kadb/DDlytHpuQ699QYUcegCUcgJhG0ZajpzUHcGPzWubaBJTq
 Z0jfA3wwZIDE5nCPhTcUN1ONQryee79q7OUFojPVoK+QOOhTSn5PrRCB6DxCoTVDtJ3PML7X
 XFuxaR3NThj9iLjjvnk0PD5ZVfn9XsjvFZAtaXt8QTIjLwzi61eYVaXaGYtjxdmpDs1L9qqq
 iIn/4TBbU115rjRBDynfIr4Xi47N8a0Q6n9bZfuwq6nSW2fkNgNyMLv/MnTvKQ0TtfgDg76t
 MX44vRjesmMfuL9h6NluTgRlVkkFG5rmEllvNWh3tDUZEGYLsUtoAH+lhJea1wVh4SxbpXWN
 WGNvusr8q+sGnqG0zxry1q2pihT34zFhCJTgwLvdGUySFfmDR8w1EDzMISk38c/NZlIqM0q9
 jsI+BtjvVDX8UWZaVyCKMIRta2EHXERVbJPHiJKVrqGakbMzbGqoLx4r8y+Oa2EaZ4gacaid
 DEShdVpGQyc0XhBYmH24BK6AnERCGnUTHk2qhlltFEU33HNczW2AG4OSITevqb0oIi65fgKo
 WO0bptcoreEVc=
X-IronPort-AV: E=Sophos;i="5.88,375,1635220800"; 
   d="scan'208";a="63865198"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=UWZlY8eyWtjGZKVs6CKUSWsEREUYIA1oV0ETBvotN3yzy6MNaTejp0fAhqm/f+sA+mb2Fyq0C0Go6msAGcriPRYNy6mfAg4YoAFZ1nO9aP5Er1VpdRXOmwM6DRHZl0aTrpXk6MqSz7EvzkvrSMmnYibZkQYt+Dh3A+MNMRuMw4aJB0A+tE1r5L52H+DWN0Qo0F1VZREklTS9Wm6lMJhVviXB1fsCSLVGFP3pX+2ZMUCkKc7FksPIHz3tT4UGWmMSiCjHptl/Ghss2nXNf/PI6GkYE0FA75mNMYR8MpIcp9lz80FhGv//sqsTDiazQcCoZBwtMIvf3PwOw4urYRW1Lg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=UwxJpcOon4iEybAaIBAUJENkEQjUrLrGY7Hrv1Ijb3M=;
 b=Sfl47qjmKdXC+xlTvKYDN10cG13ro4yIP2MZ3tbPM54yh3EIW3Ru1iG8ZoitQ5r3S/HY7A1b7hpc5AsAOII0zvDJpwSLUFX8KlccbNuuNtQ/N7vTFVnmu/5sTWTBpeyKVGqaTxYr7fjfjNReI/uvXSstc8Bq/lq6QuqgSb4xPWgYzwgalyqEK9Dzics5thd+JuQ5WXs+C7U95DMWMOM7QSgMKdAyNN9ruAvuz1VpkgkVeMwA63ZCPJbPG/RoGkDyEHEoIpEif0p1l5xq4mrUq5JeBT1z8S5RKnFXTzwgIfJw31/iX4fl4ZoG7q6sjwHG7GUUZ37uIMPwzIESKImItQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=UwxJpcOon4iEybAaIBAUJENkEQjUrLrGY7Hrv1Ijb3M=;
 b=rZOD/JRfdo84B5bqz/ZHGD0jQSpF9PO4NTCg88wD1yQcbQGQE6IC+jC8AYRqDEh11WD9mTq38YoKab9gCdMLvDHc78vobpINaC84x77tOcZrfekqoE+XooirHIxaXdOgoAS7IQykyLMfl3ozRojKpRIj6+ooskhZpKgcLr8IjRc=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>, Xen-devel
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2.1 6.5/70] x86/kexec: Annotate embedded data with ELF
 metadata
Thread-Topic: [PATCH v2.1 6.5/70] x86/kexec: Annotate embedded data with ELF
 metadata
Thread-Index: AQHYI+WIB3ag8ccQV0mMbUcu9Q8VKKyXjjSAgAAXo4A=
Date: Thu, 17 Feb 2022 12:06:39 +0000
Message-ID: <826c97dd-dda9-b6c2-37bf-451354fcfde2@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
 <20220217100158.22402-1-andrew.cooper3@citrix.com>
 <4e9924f7-fdfa-c3c3-7b6c-e5cbe77ff9ac@suse.com>
In-Reply-To: <4e9924f7-fdfa-c3c3-7b6c-e5cbe77ff9ac@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 2c107ad7-5da0-42f8-5ee4-08d9f20df43b
x-ms-traffictypediagnostic: DM6PR03MB4491:EE_
x-microsoft-antispam-prvs: <DM6PR03MB4491CC7BB0960F39F36BE4F4BA369@DM6PR03MB4491.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: VTU+3Ym+iFaBXDPiHO8iY7p/NNV4zhKforQLB/EsjpsrukZ2XtCrje8nQen4C/yuqTD8M+rrSghUybhLuRD2NCFAtArCa1K/l2m0ca/2slExbUDdt7beO7VDqPERQD0VB3OyYas37GxiPva7VOir6IQ0reIkb7nzHHW4evfzSoxMEPf5wdsj0wUa6Bv8kXuyeckUxsH0hjoBWSzva3H5w+TSbWN+00nCNmyAVDd3rw2WNb7GGADrA0e9Xe54bVythgAl8xdofhRp6pqmUQm+l5SumavvgdbKHI+MFROuMbCfZFvYq42T1DPf+NozwQsvDACPBvGU9XZIZLXWvvrLW2I4XWDIUWCULWHKz8k7pCFMTlDDIN3R2tOKCOs7XxU09mXt5bJuxnDpO/c8WQcvRaafKZCU/mQIyJ632S/kOAH+k/6FEK++7nXot70gCdL+900dCHygzbyZD3jLV2D4eCAUJaVBX9zCHe3iE4bxBOFeL/N7ZcELttMcsHWwNldM+i4VDYF6+A8fYxBfV75OHhK1JPlcJ7r5HvCjDFvA4Lx/jjJh8MdSXUnkWx4RCjLgJPII1zSUWXEF3SdqxnzuvviaOdsQjw8oS157r69RlhOQ9iOoor5aEFuztK6iHRObsjf0pnEyGrwlq86hDGjYSMIV6CS2Voxmbm9LCaMJ64JQptCELguV0OfKXZGw0j0qD4chYC4rywO+kWnkaz9M2Yhy/Df5L70bOA1/SJ2VEHUUygke1GDbftMhGQeVseyzdPrZfzzUCL+WiJ+eD5dCFg==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(5660300002)(6506007)(86362001)(38100700002)(508600001)(6486002)(82960400001)(31696002)(2906002)(316002)(36756003)(6512007)(54906003)(53546011)(66476007)(31686004)(91956017)(71200400001)(64756008)(66446008)(8936002)(66556008)(186003)(26005)(66946007)(76116006)(122000001)(8676002)(38070700005)(6916009)(4326008)(83380400001)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?cVBnQ0lBQUUrb1UrbDlPYzFiV3ZwV1Yra1FCaVlRdllGODlIV1J2NFhjMlZa?=
 =?utf-8?B?d2s3blBZUDhlYVNWckpRNnl0UjQrTmt2RlVQNzBpZVNybFhsYmxidTFGYnVi?=
 =?utf-8?B?d3hSditaendJR2IzSHNVbmtET2crQWtCWHExNE1WbGhRcXJkUEIrSUZsbFBv?=
 =?utf-8?B?dHdpM29pdUF3eWFKY05oU3AwdzdVU1lzL1Q3YmYzaXZkZTdYWFVYUm1JbEZC?=
 =?utf-8?B?VXpVazBrYkhaNGpFU3phUUFnSnlSUkFwQUhtT1BQT05oS1pFeGlkU3BxWm5n?=
 =?utf-8?B?YmpTSDYyUFFLNzBFMEtjeHBUK0dKT1BWUys1Smg1RFUzKzhkOEJPeFJZVzEz?=
 =?utf-8?B?YXV4akZWMEdYc0twOU9HVCtOTDhKZ254eVdDbXFEYmdnYjdhRWZKSWpuT05v?=
 =?utf-8?B?R1I4ekVoNC9abHdmN2xLcWVQOHlTVmZnekkwYld5d0xYdFJIcXB4ckFmVVl2?=
 =?utf-8?B?OGFhQ1d6aEd1TVUwazdkQUkwU1NVMno1Wkw4U0c5WDgwaEtyRWlnWlRHdUV4?=
 =?utf-8?B?bFhmSGpSaURJbnhQdVVheWloRGcvYndUUkJySXQzSmU5S0t0L2tNYjdETmx6?=
 =?utf-8?B?WThyVS9lL3g3STZGc05ucDlGaTE3cUQ4OVR6MHNlQ2tzemNDMGRicnhKU2d4?=
 =?utf-8?B?RmdPZkZNWUxQMDZkZTVKSUpQbDNCZ2x4R3VXNnlDY1U5QnJKOVliK0FCUVZy?=
 =?utf-8?B?THBiTzF1OGFKcmZYRm1DYUtidmRZVkMvUVFUdjlrYStsdFBxVm1xamhWc0Jv?=
 =?utf-8?B?TUNpMWI3NVRlYzA0VGFCZysvZlh4L1hmMkc1NjZtL3BNN0h1L3c1R3QrOHJj?=
 =?utf-8?B?b1J6MDU4YVd5bWw0b1hYK0ZmSUJwbW9XODJoT2tNTVQxNEpvL1ozMGthNnJi?=
 =?utf-8?B?MXI1Vk5SaE9SYWVPVzJyekdTejBaZ1pCRXlKT2xUOCtVRDloZnR5MnA4R1hE?=
 =?utf-8?B?SHpnbU9Wbk5NL0NoZ2lLZDFrMXpURkRBbWJlUTZOcVFlZ09tVDFZcFdvemh6?=
 =?utf-8?B?MzdSN3BJbDNzbWxjYTdJRlhGQnB4cXJMUVZla0xJeEdVazdLMDNKNzZkcVdv?=
 =?utf-8?B?M1QvMTVVSGZqdXAzVUIxYktkUys3RDcwNjBLNGY1OStKT0V4Y2NWSG4xcTVw?=
 =?utf-8?B?NTMzSlNleVlTRENVZElyYi9USktPNHNBOG5FSmxCdXdESnRSbjdORnpySURI?=
 =?utf-8?B?c2ZFeDUweUxxNWFSTWs5akZ0K0lnMUN5TklTblhESldWUVd3NmgxVDRDRklE?=
 =?utf-8?B?VUwzZnQ5eUN2RWVtT0RRSVlIY0IvZDg3cDJJMXB5TlNMcUI5My9vMXJwckRS?=
 =?utf-8?B?NUlwZHl4KzZSTFVXR3NuZnFrdENlaDFwcDF2OG8yNi9nMFdZK1lnSzZ6MERr?=
 =?utf-8?B?Y3ZONEU5Szc0VGp2MlVWM0dSMG9leDlGM0lqMUVJKzR3ZmJ3V3F6d2h0OGpt?=
 =?utf-8?B?bXdGWHlhMUhnamxhM1NUcHFSTXZIcWVtYWFBbHh6VlE0eUlieHpRa0pHSHJ6?=
 =?utf-8?B?WTlnSVE1UDc5TzNtZ3JITURQY3BXVitIT21pajd0RENKYVZRYlJxMDgwbklv?=
 =?utf-8?B?cHVhY0l4QTM5L3pwaFNTb21rNU5ITkJMSlZHODgyZjVaZWM0QU1Kek9ib1Nn?=
 =?utf-8?B?SlpxdnRHbHZqVndJZHJRbWJSdHJLY3liandTRERHSzRuMUlETFloZHlBM2k5?=
 =?utf-8?B?WTlIeS85dHZtYWFCUzZZc1lBR2M4Y3RPa1JqWlJyemt5M3VpSlpvYStucWtC?=
 =?utf-8?B?eVhxazJPSE9BVnNzdjlKaEZyaWVCd2lxUnlmYTdaQ3h2NkMvNlc0MU9WKzMw?=
 =?utf-8?B?STk1VFhHU3pRT3hZcG5UMFAxTFFZdCtrVm1SaTU4aC9CTTZTamcyczJWOGZU?=
 =?utf-8?B?T0JPYjVycnFabW5tWmk1Z3ROdDFra2VlZE1vWWkrVEVLSDZDTHA0eHN6aUZn?=
 =?utf-8?B?eDZBWDNUeWxYeDNvZkNNcUozemhxLzFpZWFSSDR3NGJqdXN0ZXRvWE5FQktr?=
 =?utf-8?B?NGdWcVo4alU5UkthOHpHTnlhd2xlNnQrSzhPVi9OUXIxbEJWYU93emhMbG50?=
 =?utf-8?B?azJUZzdPSVVESEtpSVE5YVB5VWlMSlFCTkhxUXBOMGYvdFlGaUZ6elFxZVFw?=
 =?utf-8?B?ZEJPQklaQVVDNnBsL0dwa2ZKNThmTEp4YzNtQ043bDUxc0VJR2Z3UmZEdHpV?=
 =?utf-8?B?bmRDc1A1cnNPOUJneWo5NGZJVjJFT2syVjZSOCt5U05BcUJIUE5oc3lIZWxC?=
 =?utf-8?B?K1dTYlhhbjFING5HN3hkTGdUKzR3PT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <CE410F38881D7A4AA4D3B34BF592AADC@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2c107ad7-5da0-42f8-5ee4-08d9f20df43b
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Feb 2022 12:06:39.5039
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: udx9gTRwzV+lJ1ZvUNWbnAsvMbKtDuYFmis5jJLm7eoSoZRLCNZJlOjNpSfYAeiXy06fJEDrO6aWl/2Zk9ip/uSWYPvlgSUDJyrVndaT4NE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4491
X-OriginatorOrg: citrix.com

T24gMTcvMDIvMjAyMiAxMDo0MiwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDE3LjAyLjIwMjIg
MTE6MDEsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBTY2FubmluZyBmb3IgZW1iZWRkZWQgZW5k
YnJhbmNoIGluc3RydWN0aW9ucyBpbnZvbHZlcyBwYXJzaW5nIHRoZSAudGV4dA0KPj4gZGlzYXNz
ZW1ibHkuICBEYXRhIGluIHRoZSBrZXhlYyB0cmFtcG9saW5lIGhhcyBubyBFTEYgbWV0YWRhdGEs
IHNvIG9iamR1bXANCj4+IHRyZWF0cyBpdCBhcyBpbnN0cnVjdGlvbnMgYW5kIHRyaWVzIHRvIGRp
c2Fzc2VtYmxlLiAgQ29udmVydDoNCj4+DQo+PiAgIGZmZmY4MmQwNDAzOTYxMDggPGNvbXBhdGli
aWxpdHlfbW9kZV9mYXI+Og0KPiBXaGF0IGFib3V0IHRoZSAocG9zc2libGUpIHBhZGRpbmcgYWhl
YWQgb2YgdGhpcz8gU2hvdWxkIHRoZSAuYWxpZ24NCj4gdGhlcmUgcGVyaGFwcyBzcGVjaWZ5IGEg
ZmlsbGVyIGNoYXJhY3Rlcj8NCg0KV2hhdCBhYm91dCBpdD/CoCBJdCdzIGp1c3QgbG9uZyBub3Bz
IGxpa2UgYWxsIG90aGVyIHBhZGRpbmcgaW4gLnRleHQNCg0KZmZmZjgyZDA0MDM5NjEwMTrCoMKg
wqDCoMKgwqAgZmYgZDXCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgY2FsbMKg
wqAgKiVlYnANCmZmZmY4MmQwNDAzOTYxMDM6wqDCoMKgwqDCoMKgIDBmIDBiwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHVkMsKgwqAgwqANCmZmZmY4MmQwNDAzOTYxMDU6wqDC
oMKgwqDCoMKgIDBmIDFmIDAwwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIG5vcGzCoMKg
ICglZWF4KQ0KDQpmZmZmODJkMDQwMzk2MTA4IDxjb21wYXRpYmlsaXR5X21vZGVfZmFyPjoNCmZm
ZmY4MmQwNDAzOTYxMDg6wqDCoMKgwqDCoMKgIDAwIDAwIDAwIDAwIDEwDQowMMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
IC4uLi4uLg0KDQpBbmQgZm9yIHRoaXMgcHJvYmxlbSwgd2UgZG9uJ3QgbmVlZCB0byBjYXJlIGFi
b3V0IHRoZSBiZWhhdmlvdXIgb2YgYW55DQpwcmUtQ0VUIHZlcnNpb24gb2YgYmludXRpbHMuDQoN
Cj4+ICAgZmZmZjgyZDA0MDM5NjEwODogICAgICAgMDAgMDAgICAgICAgICAgICAgICAgICAgYWRk
ICAgICVhbCwoJXJheCkNCj4+ICAgZmZmZjgyZDA0MDM5NjEwYTogICAgICAgMDAgMDAgICAgICAg
ICAgICAgICAgICAgYWRkICAgICVhbCwoJXJheCkNCj4+ICAgZmZmZjgyZDA0MDM5NjEwYzogICAg
ICAgMTAgMDAgICAgICAgICAgICAgICAgICAgYWRjICAgICVhbCwoJXJheCkNCj4+DQo+PiAgIGZm
ZmY4MmQwNDAzOTYxMGUgPGNvbXBhdF9tb2RlX2dkdF9kZXNjPjoNCj4+ICAgZmZmZjgyZDA0MDM5
NjEwZTogICAgICAgMTcgICAgICAgICAgICAgICAgICAgICAgKGJhZCkNCj4+ICAgICAgICAgICAu
Li4NCj4+DQo+PiAgIGZmZmY4MmQwNDAzOTYxMTggPGNvbXBhdF9tb2RlX2dkdD46DQo+PiAgICAg
ICAgICAgLi4uDQo+PiAgIGZmZmY4MmQwNDAzOTYxMjA6ICAgICAgIGZmICAgICAgICAgICAgICAg
ICAgICAgIChiYWQpDQo+PiAgIGZmZmY4MmQwNDAzOTYxMjE6ICAgICAgIGZmIDAwICAgICAgICAg
ICAgICAgICAgIGluY2wgICAoJXJheCkNCj4+ICAgZmZmZjgyZDA0MDM5NjEyMzogICAgICAgMDAg
MDAgICAgICAgICAgICAgICAgICAgYWRkICAgICVhbCwoJXJheCkNCj4+ICAgZmZmZjgyZDA0MDM5
NjEyNTogICAgICAgOTMgICAgICAgICAgICAgICAgICAgICAgeGNoZyAgICVlYXgsJWVieA0KPj4g
ICBmZmZmODJkMDQwMzk2MTI2OiAgICAgICBjZiAgICAgICAgICAgICAgICAgICAgICBpcmV0DQo+
PiAgIGZmZmY4MmQwNDAzOTYxMjc6ICAgICAgIDAwIGZmICAgICAgICAgICAgICAgICAgIGFkZCAg
ICAlYmgsJWJoDQo+PiAgIGZmZmY4MmQwNDAzOTYxMjk6ICAgICAgIGZmIDAwICAgICAgICAgICAg
ICAgICAgIGluY2wgICAoJXJheCkNCj4+ICAgZmZmZjgyZDA0MDM5NjEyYjogICAgICAgMDAgMDAg
ICAgICAgICAgICAgICAgICAgYWRkICAgICVhbCwoJXJheCkNCj4+ICAgZmZmZjgyZDA0MDM5NjEy
ZDogICAgICAgOWIgICAgICAgICAgICAgICAgICAgICAgZndhaXQNCj4+ICAgZmZmZjgyZDA0MDM5
NjEyZTogICAgICAgY2YgICAgICAgICAgICAgICAgICAgICAgaXJldA0KPj4gICAgICAgICAgIC4u
Lg0KPj4NCj4+ICAgZmZmZjgyZDA0MDM5NjEzMCA8Y29tcGF0X21vZGVfaWR0PjoNCj4+ICAgICAg
ICAgICAuLi4NCj4+DQo+PiAgIGZmZmY4MmQwNDAzOTYxYjYgPGtleGVjX3JlbG9jX3NpemU+Og0K
Pj4gICBmZmZmODJkMDQwMzk2MWI2OiAgICAgICBiNiAwMSAgICAgICAgICAgICAgICAgICBtb3Yg
ICAgJDB4MSwlZGgNCj4+ICAgICAgICAgICAuLi4NCj4+DQo+PiB0bzoNCj4+DQo+PiAgIGZmZmY4
MmQwNDAzOTYxMDggPGNvbXBhdGliaWxpdHlfbW9kZV9mYXI+Og0KPj4gICBmZmZmODJkMDQwMzk2
MTA4OiAgICAgICAwMCAwMCAwMCAwMCAxMCAwMCAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAuLi4uLi4NCj4+DQo+PiAgIGZmZmY4MmQwNDAzOTYxMGUgPGNvbXBhdF9tb2RlX2dkdF9kZXNj
PjoNCj4+ICAgZmZmZjgyZDA0MDM5NjEwZTogICAgICAgMTcgMDAgMDAgMDAgMDAgMDAgMDAgMDAg
MDAgMDAgICAgICAgICAgICAgICAgICAgLi4uLi4uLi4uLg0KPj4NCj4+ICAgZmZmZjgyZDA0MDM5
NjExOCA8Y29tcGF0X21vZGVfZ2R0PjoNCj4+ICAgICAgICAgICAuLi4NCj4+ICAgZmZmZjgyZDA0
MDM5NjEyMDogICAgICAgZmYgZmYgMDAgMDAgMDAgOTMgY2YgMDAgZmYgZmYgMDAgMDAgMDAgOWIg
Y2YgMDAgLi4uLi4uLi4uLi4uLi4uLg0KPj4NCj4+ICAgZmZmZjgyZDA0MDM5NjEzMCA8Y29tcGF0
X21vZGVfaWR0PjoNCj4+ICAgZmZmZjgyZDA0MDM5NjEzMDogICAgICAgMDAgMDAgMDAgMDAgMDAg
MDAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgLi4uLi4uDQo+IFdpdGggdGhlIC5zaXpl
IGRpcmVjdGl2ZXMgYWRkZWQsIGNhbiB3ZSByZWx5IG9uIGNvbnNpc3RlbnQgKHBhc3QsDQo+IHBy
ZXNlbnQsIGFuZCBmdXR1cmUpIG9iamNvcHkgYmVoYXZpb3IgZm9yIHBhZGRpbmcgZ2Fwcz8NCg0K
T2YgY291cnNlIG5vdC7CoCBXZSBkb24ndCBrbm93IGhvdyB0aGluZ3Mgd2lsbCBkZXZlbG9wIGlu
IHRoZSBmdXR1cmUuwqANClRoZSBiZXN0IHdlIGNhbiBkbyBpcyBob3BlIHRoYXQgaXQgZG9lc24n
dCBjaGFuZ2UgdG9vIG11Y2guDQoNCkJ1dCBvbiB0aGF0IG5vdGUsIHRoZSB3YXkgdGhpcyB3b3Vs
ZCBnbyB3cm9uZyBpcyB0aGUgYmluYXJ5IHNjYW4gZmluZGluZw0KYW4gZW5kYnIgdGhhdCB3YXNu
J3QgZGlzYXNzZW1ibGVkIHByb3Blcmx5IGhlcmUsIGZvciB3aGF0ZXZlciByZWFzb24uDQoNCj4g
IEl0IGp1c3Qgc28NCj4gaGFwcGVucyB0aGF0IHRoZXJlJ3Mgbm8gNC1ieXRlIGdhcCBiZXR3ZWVu
IGNvbXBhdF9tb2RlX2dkdF9kZXNjIGFuZA0KPiBjb21wYXRfbW9kZV9nZHQuIENoYW5naW5nIHRo
ZSAuYWxpZ24gYWhlYWQgb2YgY29tcGF0aWJpbGl0eV9tb2RlX2Zhcg0KPiB3b3VsZCBlbGltaW5h
dGUgdGhlIHJpc2sgb2YgcGFkZGluZyBhcHBlYXJpbmcgaWYgdGhlIGNvZGUgZnVydGhlciB1cA0K
PiBjaGFuZ2VkLg0KDQpHYXBzIHdpbGwgYmUgZm9ybWVkIG9mIGxvbmcgbm9wcyBiZWNhdXNlIHdl
J3JlIGluIC50ZXh0LCBhbmQgdGhleSBtZXJnZQ0Kd2l0aCB0aGUgcHJldmlvdXMgZGF0YSBibG9i
IChzZWUgYmVsb3cpLg0KDQo+DQo+PiAgIGZmZmY4MmQwNDAzOTYxMzYgPHJlbG9jX3N0YWNrPjoN
Cj4+ICAgICAgICAgICAuLi4NCj4gTm93IHRoaXMgaXMgcGFydGljdWxhcmx5IHB1enpsaW5nOiBV
cyBzZXR0aW5nICVyc3AgdG8gYW4gdW5hbGlnbmVkDQo+IGFkZHJlc3MgaXMgY2xlYXJseSBub3Qg
QUJJLWNvbmZvcm1pbmcuIFNpbmNlIHlvdSdyZSBmaWRkbGluZyB3aXRoDQo+IGFsbCBvZiB0aGlz
IGFscmVhZHkgYW55d2F5LCBob3cgYWJvdXQgZml4aW5nIHRoaXMgYXQgdGhlIHNhbWUgdGltZT8N
Cj4gT2YgY291cnNlIHRoZXJlIHdvdWxkIHRoZW4gYXBwZWFyIHBhZGRpbmcgYWhlYWQgb2YgdGhl
IHN0YWNrLCB1bmxlc3MNCj4gdGhlIHN0YWNrIHdhcyBtb3ZlZCB1cCBzb21lLg0KDQpPaCAtIEkn
ZCBub3QgZXZlbiBub3RpY2VkIHRoYXQuwqAgTHVja2lseSB0aGVyZSBpcyBubyBBQkkgd2hpY2gg
bWF0dGVycywNCmJlY2F1c2UgaXQncyB0aGUgY2FsbC9wdXNoL3BvcCdzIGluIHRoaXMgZmlsZSBh
bG9uZS4NCg0KV2l0aCBhbiBhbGlnbiA4LCB3ZSBnZXQ6DQoNCmZmZmY4MmQwNDAzYTcxMzggPGNv
bXBhdF9tb2RlX2lkdD46DQpmZmZmODJkMDQwM2E3MTM4OsKgwqDCoMKgwqDCoCAwMCAwMCAwMCAw
MCAwMCAwMCA2Ng0KOTDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoCAuLi4uLi5mLg0KDQpmZmZmODJkMDQwM2E3MTQwIDxyZWxvY19zdGFjaz46
DQrCoMKgwqDCoMKgwqDCoCAuLi4NCg0Kd2hlcmUgdGhlIDY2IDkwIGluIGNvbXBhdF9tb2RlX2lk
dCBpcyB0aGUgcGFkZGluZy7CoCBSZWNhbGwgYy9zIDlmZDE4MTU0MGM3ZTYNCg0KPg0KPj4gQEAg
LTE3NSwxMCArMTc1LDE2IEBAIGNvbXBhdGliaWxpdHlfbW9kZV9mYXI6DQo+PiAgICAgICAgICAu
bG9uZyAweDAwMDAwMDAwICAgICAgICAgICAgIC8qIHNldCBpbiBjYWxsXzMyX2JpdCBhYm92ZSAq
Lw0KPj4gICAgICAgICAgLndvcmQgMHgwMDEwDQo+PiAgDQo+PiArICAgICAgICAudHlwZSBjb21w
YXRpYmlsaXR5X21vZGVfZmFyLCBAb2JqZWN0DQo+PiArICAgICAgICAuc2l6ZSBjb21wYXRpYmls
aXR5X21vZGVfZmFyLCAuIC0gY29tcGF0aWJpbGl0eV9tb2RlX2Zhcg0KPj4gKw0KPj4gIGNvbXBh
dF9tb2RlX2dkdF9kZXNjOg0KPj4gICAgICAgICAgLndvcmQgLkxjb21wYXRfbW9kZV9nZHRfZW5k
IC0gY29tcGF0X21vZGVfZ2R0IC0xDQo+PiAgICAgICAgICAucXVhZCAweDAwMDAwMDAwMDAwMDAw
MDAgICAgIC8qIHNldCBpbiBjYWxsXzMyX2JpdCBhYm92ZSAqLw0KPj4gIA0KPj4gKyAgICAgICAg
LnR5cGUgY29tcGF0X21vZGVfZ2R0X2Rlc2MsIEBvYmplY3QNCj4+ICsgICAgICAgIC5zaXplIGNv
bXBhdF9tb2RlX2dkdF9kZXNjLCAuIC0gY29tcGF0X21vZGVfZ2R0X2Rlc2MNCj4gU2lkZSBub3Rl
OiBXZSByZWFsbHkgb3VnaHQgdG8gZ2FpbiBzb21ldGhpbmcgbGlrZSBPQkpFQ1QobmFtZSkgdG8g
YXZvaWQNCj4gYyduJ3AgbWlzdGFrZXMgbm90IHVwZGF0aW5nIGNvcnJlY3RseSBhbGwgdGhyZWUg
c3ltYm9sIG5hbWUgaW5zdGFuY2VzLg0KDQpJJ3ZlIGdvdCBhbiBpbnRlcm4gd29ya2luZyBvbiBp
dC4NCg0KPg0KPj4gLS0tIGEveGVuL2FyY2gveDg2L3hlbi5sZHMuUw0KPj4gKysrIGIveGVuL2Fy
Y2gveDg2L3hlbi5sZHMuUw0KPj4gQEAgLTg3LDYgKzg3LDcgQEAgU0VDVElPTlMNCj4+ICAgICAg
ICAgKigudGV4dC51bmxpa2VseSkNCj4+ICAgICAgICAgKiguZml4dXApDQo+PiAgICAgICAgICoo
LnRleHQua2V4ZWMpDQo+PiArICAgICAgIGtleGVjX3JlbG9jX2VuZCA9IC47DQo+IERvZXMgdGhp
cyBtYXliZSB3YW50IGFsaWduaW5nIG9uIGEgNC0gb3IgZXZlbiA4LWJ5dGUgYm91bmRhcnk/IElm
DQo+IHNvLCBpbW8gcHJlZmVyYWJseSBub3QgaGVyZSwgYnV0IGJ5IGFkZGluZyBhIHRyYWlsaW5n
IC5hbGlnbiBpbiB0aGUNCj4gLlMgZmlsZS4NCg0KVGhlcmUncyBubyBzcGVjaWFsIG5lZWQgZm9y
IGl0IHRvIGJlIGFsaWduZWQsIGFuZCBpdCBpcyBhbnl3YXkgYXMgdGhlDQpzdGFjayBpcyB0aGUg
bGFzdCBvYmplY3QgaW4gaXQuDQoNClRoZSBzb2xlIHVzZXIgaXMgdGhlIG1lbWNweSgpIHNpemUg
Y2FsY3VsYXRpb24gbW92aW5nIHRoZSB0cmFtcG9saW5lIHRvDQppdHMgZGVzdGluYXRpb24gcGFn
ZSBpbiB0aGUga2V4ZWMgcmVzZXJ2ZWQgYXJlYS4NCg0KfkFuZHJldw0K


From xen-devel-bounces@lists.xenproject.org Thu Feb 17 12:07:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 17 Feb 2022 12:07:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274749.470334 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKfZm-0002Of-8I; Thu, 17 Feb 2022 12:07:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274749.470334; Thu, 17 Feb 2022 12:07:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKfZm-0002OY-4v; Thu, 17 Feb 2022 12:07:58 +0000
Received: by outflank-mailman (input) for mailman id 274749;
 Thu, 17 Feb 2022 12:07:56 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=A/h9=TA=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nKfZk-0002OO-TM
 for xen-devel@lists.xenproject.org; Thu, 17 Feb 2022 12:07:56 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3c4fe699-8fea-11ec-8723-dd0c611c5f35;
 Thu, 17 Feb 2022 13:07:55 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3c4fe699-8fea-11ec-8723-dd0c611c5f35
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645099675;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=AKzo7k6MF2/SvLdlcQUAA5rd1y8YQypPjmbIZK+Ohro=;
  b=C9YyYlv3DVPdt/JI9X69qYnJL1KIudNs1/gpZud+3Rmf2Uf4vxOXAIs4
   EVICzHWNewSDylQTpDdP753sfHPNiaf1FBlioilsa6cBlBv3cg0/ArT0E
   YT/qw8/0VQcqbBFWQiEmjuDxt4yqGUvjRBMI95DfrFWj3zs6oRSYXf4bB
   k=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: W/EH3YmRnDiMMPhBL+F7YKbiaPXkmtB7AyRr8JvHR7DG8hnG6z5waofCi7TNwI3q2WLCCx+hB/
 FPjhSBCn6yn2bWhoXSwIGF31OaKVJxfR/L/OOODk1ukidTR8NI8sVVCVFHgCIyQUz0Rs6V6mQG
 q0QbN3E1KiPPib/pRXvaFyGUc4WAJMCnY2HeictEzISVc74BqAnc6nJKX9VRwT7C1KlOxzy4iM
 lN9A0a+p9IBnypMFAWgtulDJVt09o1DzE85jXIzhAE0AMLrpMUPYdWjZyGvcacCKYFDIS7xXtA
 PrZ7dZprhaqab6dmRKxUEgG4
X-SBRS: 5.1
X-MesageID: 66664464
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:ql4F/qs4GhxmQNYlyEnfXU6SQufnVNJZMUV32f8akzHdYApBsoF/q
 tZmKWHQafyLZDH0L4h3YNm1/RlXvpTTndcwS1dq/H8xHiMb+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZQP0VOZigHtIQMsadUsxKbVIiGHdJZS5LwbZj2NYy2IfhWmthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 Npl8rjodgs0J5L1mvksSzIEKXFyFvEX5+qSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DJoQQt2sm1TjEJf0nXYrCU+PB4towMDIY2J4QQ6qCO
 ZZxhTxHQA3cQzYSN2stE5MUnLbroUDhMGMFkQfAzUYwyzeKl1EguFT3C/LKfvSaSMMTmVyXz
 krW8mK8DhwEOdi3zTue7mnqluLJhTn8Wo8ZCPu/7PECqEaI2mUZBRkSVF26ifq0kEizX5RYM
 UN80igkoLU29UerZsLgRBD+q3mB1jYeRt5RHusS+AyLjK3O7G6k6nMsF2AbLoZ87YlvGGJsh
 gThc87V6SJH95nNdn6A74itry6DIQNJFz8OTnNVUl5QizX8m70bghXKR9dlNae6iNzpBD39q
 wy3QDgCa6Y71pBSifjilbzTq3f1/8WSEFZpjunCdj/9tmtEiJiZi5tEALQxxdJJN86nQ1aIp
 xDocODOvblVXflheMFgKdjh/Y1FBd7ZYVUwYnY1RvHNEghBHVb5Iui8BxkkeS9U3j4sI2OBX
 aMqkVo5CGVvFHWrd7RrRIm6Ft4ny6Ptffy8CKyJNoERPMQsL1DalM2LWaJ29zqy+KTLuftiU
 ap3jO72VSpKYUiZ5GHeqxghPU8DmXllmDK7qWHTxBW7y7uODEN5up9eWGZimtsRtfveyC2Mq
 o43H5LTl313Db2vCgGKoNV7BQ1bchAG6WXe9pU/mhireVE9RgnMypb5nNscRmCSt/8EzLiWo
 CDmCxQwJZiWrSSvFDhmo0tLMdvHdZ1+sWg6LWorO1Op0GIkeoGh8OEUcJ5fQFXt3LYLISdcQ
 6ZXdsOeLO5ITzibqT0RYYOk9N5pdQixhBLINC2gOWBtc5llTg3P29nlYgqwq3VeUnvp7ZMz8
 ++6ywfWYZsfXAA+XszYX+2ikgGqtn8HleMsA0aReotPeF/h+ZRBIjDqiqNlONkFLBjOn2PI1
 wufDRoCi/PKpos5rIvAiaye9t/7GOpiBEtKWWLc6O/uZyXd+2Oix65GUfqJIm+BBD+lpv36a
 LwMnf/mMfABkFJbiKZGEu5mnfAk+t/ih75G1QA4Tn/FWEumV+F7KX6c0MgR6qAUnu1FuRG7U
 16k88VBPenbI9vsFVMcKVZ3bumH0v1IyDDe4e5sfRf/7S5zurGGTV9TL1+HjykEdOl5N4Ysw
 OEAvs8K6lPg1kp2Y4je1i0EpX6RKnEgUrk8ssBICYDmvQMn11VebMGOESTx+pyON41BP0RCz
 uV4X0Yea2CwHnb/Tkc=
IronPort-HdrOrdr: A9a23:Geb5IqDSWcHFUGrlHemo55DYdb4zR+YMi2TDsHoBLiC9E/bo8/
 xG+c5x6faaslossR0b9uxoW5PhfZq/z/BICOAqVN/JMTUO01HIEKhSqafk3j38C2nf24dmpM
 JdmnFFeb7N5I5B/KTH3DU=
X-IronPort-AV: E=Sophos;i="5.88,375,1635220800"; 
   d="scan'208";a="66664464"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=oFNYWbwgnGVAxw7p7264u3F2QAJth/CWQzIvRkrEOxRtktU3eCiSRfgCff7bIWpkHmFN5rRRxr0AHCFvciK6ExfWxDmk5UTHcTGwJ5nzWpEi/CgDkrpsQR6CKmuMELg3+8kI3qaxEQvJeqITSc+jlDv+ycIBzksRBTIiDFe5DpuVgamT93I4yeBq48Z5/yYBaMb4GZY1uYlHOWVBK3a4RkvsejG6zOnNPeqJqr4HdwGoQplueqOM+QcGfK//TDt58veHRhNec9Ls9kCQcq9tOTHjej/Yiz7d9KJm+z6DbyVXuh/LvhNhzTEKW0X0IXD3GedVJ7XMKIUBHuVe9QyWXg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=fN/6gvNC3DHJvpRIEGPMEbEjSqfPxr1KMfpL3vg19xQ=;
 b=gCw9NZrMmN/RQOuTEKHx5hQ5KB6rFc7IMg7Y2YbGOQlZf8d4cSpgueL9OY/7hRN1or5B1LYI1b83RcyK4MkA3/vjnFYXq97fe7EWA4EFGYFThVR/RmFuUDhlqqccQJdCz7hDFs1JZdL0OAb7ZqKHrMJfweKXrRBCoso2BSUuJi+lSsnhBySxGrYRa5oZrl8lwjQAGih0XKrnh0Jiwgd7sIybLpf5vnhMcXi/WCi8LcfMJeVR1pOkfqt9CiHPZjgt+DB8FqP+PPskKMdPlZAW43ktM4mNHu+3W1E12wBIt2Skp4yzKb5HzmUiduAvjNZDesjFIBV5R17wz+K1xdTR/w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=fN/6gvNC3DHJvpRIEGPMEbEjSqfPxr1KMfpL3vg19xQ=;
 b=BoTp4A5mpwSL9D0rbBIKHYBs7W+KNbpuoWqZWOwE+urPFEbTIkgH/CokdQfVG67pUlNhzn02fp9OG/FnZA00zjKn7Scqaeh29MNnC+xu/wtBGdQgMJfk0zrxJAV0bSWUesqDmx0GhL7Z8xsqj6Bf2IBUii+Gj1N5Gc6jvKL2JRU=
Date: Thu, 17 Feb 2022 13:07:44 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Julien Grall <julien@xen.org>, Stefano Stabellini
	<sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] x86/console: process softirqs between warning prints
Message-ID: <Yg46HsntJztYBQS0@Air-de-Roger>
References: <20220217082850.19407-1-roger.pau@citrix.com>
 <16386211-4909-da40-3b0f-c76d64289cd3@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <16386211-4909-da40-3b0f-c76d64289cd3@suse.com>
X-ClientProxiedBy: LO2P265CA0474.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:a2::30) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d8b8a7c3-74a2-455b-21f6-08d9f20e1dba
X-MS-TrafficTypeDiagnostic: BN6PR03MB3331:EE_
X-Microsoft-Antispam-PRVS: <BN6PR03MB3331DA59B0555F09D34796338F369@BN6PR03MB3331.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:462;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 5irHs1Lhshosv0fELdhZzMPefW/jLf0cbGckW6//UdZIpSZupbWwYYakGHarWfK3UE1Aesln6VjiOWL7SGlIVR94jm9D7m6VDMtc5aAz/nfuWkpz8Zwzwukc/e6FsP6aqk/QlGRO7Ag6DyAZn3g4BqdAYa/dEvbDrXcV4BJ+Dq89b7l+l+ZBlzSzcDDyVmFFJPGmjTUWFPaGOyOtr8BsBkfaQNSQCc0F8jHfAcOgjgdhzRsVxtQ3kaB6sunKvJ9WS0JX4Ch6PH6VF/0ZzyGqKWUmNqidVKJ/Kph+4hh/PwscYCR5JslJ8L6Pwj2E9ymhmbNq+vfErl0PYntw7W7F6ECxf3kwlBbP1MO3BSG13fG24bVcGbTtRiEizRYhEkEX9lQ/uiTifCbTsbXRFbcCnufcdlCBvSJwedq44u0XahSP13R+VHRzC1a5zHucySHhu3gZvDTsnUePqGd3/xmSrqaArnGb2O5Jg31DM4nLvI+GbMU9Tj6t1T7PpBibqMZdOIAuswJwnl/wqEz91M/rF3IPtvyIv3tgb1s04qKx4jkvFWvc/2DQPRu2mnC+xk2QyMKpz2Y+bttVx8JWfjPvyBv4V2cCpccwniWcs3TFs3zlGOEnVaJfUsao84pBCkvpSYUMp91uNeBPTj+eh5EuGQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(4326008)(66476007)(66556008)(66946007)(54906003)(33716001)(8676002)(83380400001)(186003)(26005)(86362001)(5660300002)(38100700002)(85182001)(8936002)(6486002)(2906002)(508600001)(82960400001)(316002)(6666004)(6512007)(9686003)(53546011)(6506007)(6916009);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VWMrakloa2c2RGlPQlgrODlOd0R1cUt0cklKVUN5ODNHcVhCV1FLUFRWR29l?=
 =?utf-8?B?TjAvMkovaE9qd2hIVHBSRnl2cDAvY01iMUpGS1Y2TE1XSUJjcDkwTzVpUEph?=
 =?utf-8?B?N1kwL2xxUEdweEZIbXdxcmNRZ2ZETGw5VDRvL3dua1hNQkxyaTFCdTV4VmRU?=
 =?utf-8?B?NEQ1bDkxVDl1UEFQb2RRSktXaUo0ZHhBV21scWhvTG5QdFlGRDd0aGxtL0oy?=
 =?utf-8?B?OTNQdUpNd1pyOVJKNlpicndHSjdyaUhRaXdtMlhiTGhzbXMwdUtzV1M1K0xl?=
 =?utf-8?B?YzhKdUM2VVVMWC9yNmhJUE80eTBzYTl4V0tVS25GOFBQVTI4K2I0dHE5UU5p?=
 =?utf-8?B?Y3hqZkJXdHlkUVgvSE9HNGZLckJvZFUyYTVabldwWUMwUG5KcGJ5VTc1NFNa?=
 =?utf-8?B?cmxMOTRVaFpKRzBhUFQ3dHlSZGJiYUNJRzFGbERaU0lwVXZwSC9KaWlaV3Fx?=
 =?utf-8?B?ZVkrTEdmVHBWYllPaWhLM29QVjNseWhNcVZwMythUjNaUzU2Yk9aTjRDVWNi?=
 =?utf-8?B?d0tYYUZGQ2pzc3M0ZnNwWWliUEZjREFpV2cwTTZvN0tzYzQxcVhBYlBwUE1p?=
 =?utf-8?B?SW0wbDNkTkl1bTVJamhqSDlyYm5CMkFoaUtCYWt1eENKTjJCM0J0WlFDOVNV?=
 =?utf-8?B?eXIwWVE5MGUyMGo2VGN4SGNvZmRoOFJCbDFEdWhXcGwvb2kybHIxT095bkp1?=
 =?utf-8?B?K1hYb25KdVBLemorR1dJQ1BTaENVTGNTMHdUMC9uVVNKZ25xTW1RUWxvdFhM?=
 =?utf-8?B?N29QTWswZFl1d2l5RFFjeEowcEo2NVRjbm5YdU9UL3ljNGw3cXRsSm1MdUVh?=
 =?utf-8?B?RUNNS0laK3g2b0RFMkZrRkE3UlNicmNMNVVJbm9veitnazdiL0grV2xtVnNp?=
 =?utf-8?B?K0U3d3lNUVIvUkkyMmM4clRuOU94Y1VyOEFiOUp1R0d2MUpjM2djMlpKQ3NP?=
 =?utf-8?B?TXdYalJEcWZ3blFsbXJuTW5ROWZCYlZCaDcrZnZ2RGZ1aVE4QjdFcmdzMm5l?=
 =?utf-8?B?K0VLTWczdDhQY2tzdGpQUy9PSGkvcytWQWlhYi9NcXVBTG1OUmk3bkt3elhJ?=
 =?utf-8?B?Rk9rN1pydnZhV2VZK2NRSUdBOG55cHh3eC9VSnBoUXROQ3ViQVFMOXpVQWt4?=
 =?utf-8?B?OU91Y1gwUVhyeTRJNUZlTGRmM09oK25Nc3dYeHFnSGt0cUhzN2NGSHRtczhW?=
 =?utf-8?B?RHJTcDROMGJqTmp6ZXEvSk4xejdmMFdkUWFEeTNNV3NCVnlJTUdnQ29zZmo3?=
 =?utf-8?B?eklPSERtUTNaUkltZHhjZFoyQzgxNlVISmNUazlCMmtYdVNPOFJvWXB6WDNQ?=
 =?utf-8?B?OHF6OVJyUGFERUFtUHpwNExuTXdzT1dDWXQ0emFOOVpMMEhDekFHWVZvS3Jy?=
 =?utf-8?B?RnBiUzlyRDk0UTU2WEtoT2ZST2t6TklvNWdXaXZGNTBQNmIvRlQ5d1BIZUZD?=
 =?utf-8?B?cE4zVGl1STFQYzVXME5mRnNQbW1sSTRBVys2YmFHSjJpaWtoOS9IeTl5cWpG?=
 =?utf-8?B?NFB0ZlFxejVBSm9pL1p1SitYR3FmT2tDVW9xMW13alFtWGkyRkduNEVmNjdB?=
 =?utf-8?B?MHJlbDI0OG42WDZpNDdTdm1tR3JSMFpheHAzSlUvRXE0aEpkVHhTQ0Z1NnJz?=
 =?utf-8?B?TFFncXBoOS9QNTFIQkZnRVBVN2FkbDVRWmx2S3gvVDZMUklSYnEvcStGN1lp?=
 =?utf-8?B?aGx5aFdHd013KzA0bzhRdHQ5SE1vRy95MHo1V3pFd1dNUXpkNVlaWXBJSVFi?=
 =?utf-8?B?ZEJLdzNVNTBIS3phRFNEUmE5cEI5TUd4OWtlWmtoZ1N0N0JiUC82TlpZQ3Ji?=
 =?utf-8?B?VDlQRUlsOEwreXl3MkN4aGJ2dC84MFhQOEFWWXQ2RGhlSXNYc0x1T0hDRGtP?=
 =?utf-8?B?K3MyTkZEdlJNcjdraVhJU3pqTXhES2l2V0dBRytyYzRMZHdsK1FKQUMvK3R1?=
 =?utf-8?B?TUN0eUdGRzNxQUVVYlduRlNPazJ3dlh5Mk5GMnhmaUF6ajlxZ2ZGOExKZWNi?=
 =?utf-8?B?KzdGT21lTDI0WnJ3V0lEeGJnTGlxbGEwdWxoem5XRk01R242YW82K21kaXhP?=
 =?utf-8?B?cGp4RVoyYk9NRU9Lc2dkZHNwSVBNRzM2UlJVY0N5M1pxYURhWXVPS2phRnpX?=
 =?utf-8?B?UUtyTmZQZnhvRjVjVks3c2lvck1iWnVVV2lHZ2N5Z2s2WlB4a09FZlQvTHp0?=
 =?utf-8?Q?UpMfSEQ7hSq4qf4mWoGF9oE=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d8b8a7c3-74a2-455b-21f6-08d9f20e1dba
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2022 12:07:49.2930
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xgnHrvK+Asb4dd1yRApJvuQeznSzYhM/FDGnBWSmCNZNVKyvRb4ltKxqRuaMT3B0LlW+KYoE4XfCNgmCjj4N8w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB3331
X-OriginatorOrg: citrix.com

On Thu, Feb 17, 2022 at 12:54:57PM +0100, Jan Beulich wrote:
> On 17.02.2022 09:28, Roger Pau Monne wrote:
> > Process softirqs while printing end of boot warnings. Each warning can
> > be several lines long, and on slow consoles printing multiple ones
> > without processing softirqs can result in the watchdog triggering:
> > 
> > (XEN) [   22.277806] ***************************************************
> > (XEN) [   22.417802] WARNING: CONSOLE OUTPUT IS SYNCHRONOUS
> > (XEN) [   22.556029] This option is intended to aid debugging of Xen by ensuring
> > (XEN) [   22.696802] that all output is synchronously delivered on the serial line.
> > (XEN) [   22.838024] However it can introduce SIGNIFICANT latencies and affect
> > (XEN) [   22.978710] timekeeping. It is NOT recommended for production use!
> > (XEN) [   23.119066] ***************************************************
> > (XEN) [   23.258865] Booted on L1TF-vulnerable hardware with SMT/Hyperthreading
> > (XEN) [   23.399560] enabled.  Please assess your configuration and choose an
> > (XEN) [   23.539925] explicit 'smt=<bool>' setting.  See XSA-273.
> > (XEN) [   23.678860] ***************************************************
> > (XEN) [   23.818492] Booted on MLPDS/MFBDS-vulnerable hardware with SMT/Hyperthreading
> > (XEN) [   23.959811] enabled.  Mitigations will not be fully effective.  Please
> > (XEN) [   24.100396] choose an explicit smt=<bool> setting.  See XSA-297.
> > (XEN) [   24.240254] *************************************************(XEN) [   24.247302] Watchdog timer detects that CPU0 is stuck!
> > (XEN) [   24.386785] ----[ Xen-4.17-unstable  x86_64  debug=y  Tainted:   C    ]----
> > (XEN) [   24.527874] CPU:    0
> > (XEN) [   24.662422] RIP:    e008:[<ffff82d04025b84a>] drivers/char/ns16550.c#ns16550_tx_ready+0x3a/0x90
> > 
> > Fixes: ee3fd57acd ('xen: add warning infrastructure')
> > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> > ---
> >  xen/common/warning.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/xen/common/warning.c b/xen/common/warning.c
> > index 0269c6715c..e6e1404baf 100644
> > --- a/xen/common/warning.c
> > +++ b/xen/common/warning.c
> > @@ -30,6 +30,7 @@ void __init warning_print(void)
> >      {
> >          printk("%s", warnings[i]);
> >          printk("***************************************************\n");
> > +        process_pending_softirqs();
> >      }
> 
> To be honest, I'm not convinced. This gets us pretty close to needing
> to process softirqs after _every_ line of output. If a console is this
> slow, the problem imo needs dealing with there (and according to irc
> we appear on a helpful track there already), not by sprinkling more
> process_pending_softirqs() all over the code.

There could be up to 20 warning messages of unknown length, so I do
think we need some processing of softirqs in the loop.

If you prefer I could do softirq processing only every 4? messages,
but I'm not sure it's worth it. Also there's no indication of the
length of messages, so IMO it's safer to just process softirqs after
each.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Thu Feb 17 12:25:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 17 Feb 2022 12:25:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274759.470345 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKfq8-0004nD-Qc; Thu, 17 Feb 2022 12:24:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274759.470345; Thu, 17 Feb 2022 12:24:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKfq8-0004n6-Mv; Thu, 17 Feb 2022 12:24:52 +0000
Received: by outflank-mailman (input) for mailman id 274759;
 Thu, 17 Feb 2022 12:24:51 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nKfq7-0004mw-D7; Thu, 17 Feb 2022 12:24:51 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nKfq7-0004KB-5S; Thu, 17 Feb 2022 12:24:51 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nKfq6-0001Sc-Oa; Thu, 17 Feb 2022 12:24:50 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nKfq6-0002sR-O9; Thu, 17 Feb 2022 12:24:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=8oAvMZnVA+80ZBQp/nVv6RqhIGgoOaUG52h7syWKNHk=; b=OBAV5y8x6CZqX61hQlwbuPul4h
	iVZSO71cg4AYZk+AOffhezlTO5lSUW+dlwBjzRxNI5hvgigWVGSQkY6ReDUPe+Gzg8UhzmfJ3sALT
	/ST+xUGSkIT1POIG4KpO9Uh/xSGzZnt2rmVfkNF9YU8WPlamDenOxtaT0SW0nQw9sI9Q=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168139-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 168139: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-arm64-arm64-xl-vhd:guest-start:fail:heisenbug
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=c13b8e9973635f34f3ce4356af27a311c993729c
X-Osstest-Versions-That:
    qemuu=ad38520bdeb2b1e0b487db317f29119e94c1c88d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 17 Feb 2022 12:24:50 +0000

flight 168139 qemu-mainline real [real]
flight 168153 qemu-mainline real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/168139/
http://logs.test-lab.xenproject.org/osstest/logs/168153/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-xl-vhd      13 guest-start         fail pass in 168153-retest

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl-vhd     14 migrate-support-check fail in 168153 never pass
 test-arm64-arm64-xl-vhd 15 saverestore-support-check fail in 168153 never pass
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10       fail  like 168123
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168123
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168123
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168123
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168123
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168123
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168123
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168123
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168123
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 qemuu                c13b8e9973635f34f3ce4356af27a311c993729c
baseline version:
 qemuu                ad38520bdeb2b1e0b487db317f29119e94c1c88d

Last test of basis   168123  2022-02-15 23:08:13 Z    1 days
Testing same since   168139  2022-02-16 15:37:01 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alistair Francis <alistair.francis@wdc.com>
  Anup Patel <anup.patel@wdc.com>
  Anup Patel <anup@brainfault.org>
  Frédéric Pétrot <frederic.petrot@univ-grenoble-alpes.fr>
  Guo Ren <ren_guo@c-sky.com>
  Junqiang Wang <wangjunqiang@iscas.ac.cn>
  LIU Zhiwei <zhiwei_liu@c-sky.com>
  Peter Maydell <peter.maydell@linaro.org>
  Petr Tesarik <ptesarik@suse.com>
  Philipp Tomsich <philipp.tomsich@vrull.eu>
  Weiwei Li <liweiwei@iscas.ac.cn>
  Wilfred Mallawa <wilfred.mallawa@wdc.com>
  Yu Li <liyu.yukiteru@bytedance.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   ad38520bde..c13b8e9973  c13b8e9973635f34f3ce4356af27a311c993729c -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Thu Feb 17 13:00:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 17 Feb 2022 13:00:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274771.470357 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKgOL-0000d0-Jy; Thu, 17 Feb 2022 13:00:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274771.470357; Thu, 17 Feb 2022 13:00:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKgOL-0000ct-Es; Thu, 17 Feb 2022 13:00:13 +0000
Received: by outflank-mailman (input) for mailman id 274771;
 Thu, 17 Feb 2022 13:00:12 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nKgOK-0000ce-T3; Thu, 17 Feb 2022 13:00:12 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nKgOK-00052y-Kl; Thu, 17 Feb 2022 13:00:12 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nKgOK-00034d-2Q; Thu, 17 Feb 2022 13:00:12 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nKgOK-0002we-1x; Thu, 17 Feb 2022 13:00:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=wuP6SfTpY5QYibhO+dmAncTjtPXT/L+47nDzHXO3qjU=; b=pG3z/42OIXpz683Gk+pS0IPwWM
	w4qhLNvE11s3n460MdvmeczPfkxFPsE9XZp9pgYR/odi4/TGRPh+DV2g2XLTR+C+Up+XJQ2LDnerU
	kAw1ZB3NFlBUovymdZJfGBreWsYMZxaUMGG8/FeDJfrVE5WTdTp913RbWJNtgtFx6Vlc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168146-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 168146: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=096e3c72ec473f389a8b2fb2587e8fbaa350bde6
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 17 Feb 2022 13:00:12 +0000

flight 168146 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168146/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              096e3c72ec473f389a8b2fb2587e8fbaa350bde6
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  587 days
Failing since        151818  2020-07-11 04:18:52 Z  586 days  568 attempts
Testing same since   168146  2022-02-17 04:20:10 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brad Laue <brad@brad-x.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Christophe Fergeau <cfergeau@redhat.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Divya Garg <divya.garg@nutanix.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Emilio Herrera <ehespinosa57@gmail.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Ivan Teterevkov <ivan.teterevkov@nutanix.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jing Qi <jinqi@redhat.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Lubomir Rintel <lkundrak@v3.sk>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nicolas Lécureuil <neoclust@mageia.org>
  Nicolas Lécureuil <nicolas.lecureuil@siveo.net>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Rohit Kumar <rohit.kumar3@nutanix.com>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  shenjiatong <yshxxsjt715@gmail.com>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tu Qiang <tu.qiang35@zte.com.cn>
  Tuguoyi <tu.guoyi@h3c.com>
  tuqiang <tu.qiang35@zte.com.cn>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Vineeth Pillai <viremana@linux.microsoft.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yasuhiko Kamata <belphegor@belbel.or.jp>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 98286 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Feb 17 13:49:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 17 Feb 2022 13:49:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274784.470367 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKh9c-00051Z-JJ; Thu, 17 Feb 2022 13:49:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274784.470367; Thu, 17 Feb 2022 13:49:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKh9c-00051S-Ek; Thu, 17 Feb 2022 13:49:04 +0000
Received: by outflank-mailman (input) for mailman id 274784;
 Thu, 17 Feb 2022 13:49:03 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Ek+T=TA=linaro.org=vincent.guittot@srs-se1.protection.inumbo.net>)
 id 1nKh9a-00051I-Vo
 for xen-devel@lists.xenproject.org; Thu, 17 Feb 2022 13:49:03 +0000
Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com
 [2a00:1450:4864:20::231])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5c4b574a-8ff8-11ec-8723-dd0c611c5f35;
 Thu, 17 Feb 2022 14:49:00 +0100 (CET)
Received: by mail-lj1-x231.google.com with SMTP id a42so8359683ljq.13
 for <xen-devel@lists.xenproject.org>; Thu, 17 Feb 2022 05:49:01 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5c4b574a-8ff8-11ec-8723-dd0c611c5f35
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc:content-transfer-encoding;
        bh=+VzvwP9q9rcxg9/70qSfTmhKlUJ83T/9udBSY0she1U=;
        b=AKK51VNRvS70KYO4rkGwcq0iW5aui916+YnAkVgxvpTK56lPgdgnJEpqDk8XMOm1XI
         N4zQGvihzrWQjcK14FnpQo5RUrl1F9STEt1BiD/6jO1X5HskCO9iQ/+GONqef8Urr18/
         TWdLEzG/i1YBv64p2p+l7A/58VwO5dkr5ko/MAupeChhrM1p9kriAJO29ivAKxXaLxPe
         qm4xL3mYNHi3Nv7B7yYFYjfnWvoRbLgqVohCJycoQLCEWk/e95nNkybd9WMTc9AOPenA
         SvOE0ZXprtmvey7axaDe5iGjy92BWjQbB2Fyv4ZIguyZdcbSEjFIMN6m6QaXKn3yNj26
         jn2A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc:content-transfer-encoding;
        bh=+VzvwP9q9rcxg9/70qSfTmhKlUJ83T/9udBSY0she1U=;
        b=QuzOhAARQWMT7EwP4UFumJL9g8a2PW90PGH5CoZZz7/yAhOhPMCW3Up4JyQSpjWKFx
         Y0A7FKkkkZ2Vj1HUldHXrLulNECE6x2RQLSXRUXj9yCvEPr0es+ghAwV6MbRIRX8+vLw
         F8XceyFfNDfgfIqiT60Q8h09suuQnLCb/WrmuMG0dwq3VcOMjQiKgyRCOrZKx+MwhifV
         1IiW8MVbieL6yXoV+uN6Y9crktR273Om377HjBueb413oQSBZisOO1DdhvGVEaxiidvs
         Un1/hKg2tB+c2R4IfL/3Ut94iwgWDSIDf3HGi6Wa5R2yMKQ1iqxkyDhDBO7bicYaKv5i
         XhwA==
X-Gm-Message-State: AOAM53141RDno7sT/+Iv1G1hDDy3WaBXygfN4NNVRCWdEMdIOQL4BX8L
	v3HMLepKLKQs3UfCL2yuFPCCE2NAvkBsD5Hn3Urqkw==
X-Google-Smtp-Source: ABdhPJzO3R9aNlX4bduIHjzZh9O3CSJPNdQ4O50S560P0SMmepintzmcbbr2U/DXPDTJXJSC4gKeWTRy7uJwNanEvaY=
X-Received: by 2002:a2e:bd82:0:b0:241:130d:90b3 with SMTP id
 o2-20020a2ebd82000000b00241130d90b3mr2234881ljq.383.1645105740337; Thu, 17
 Feb 2022 05:49:00 -0800 (PST)
MIME-Version: 1.0
References: <87h79bgd1m.fsf@linaro.org> <alpine.DEB.2.22.394.2202071419270.2091381@ubuntu-linux-20-04-desktop>
 <CAKfTPtB1ONsxA1Rch8AO+UrPRZsHrCgF1_-F-kh9U_Xu2M47aA@mail.gmail.com> <alpine.DEB.2.22.394.2202161256350.43738@ubuntu-linux-20-04-desktop>
In-Reply-To: <alpine.DEB.2.22.394.2202161256350.43738@ubuntu-linux-20-04-desktop>
From: Vincent Guittot <vincent.guittot@linaro.org>
Date: Thu, 17 Feb 2022 14:48:45 +0100
Message-ID: <CAKfTPtCtwnHXS143LQM-HDuZv8BOHSMDrQjh1cJqiBUci--smA@mail.gmail.com>
Subject: Re: Metadata and signalling channels for Zephyr virtio-backends on Xen
To: Stefano Stabellini <stefano.stabellini@xilinx.com>
Cc: =?UTF-8?B?QWxleCBCZW5uw6ll?= <alex.bennee@linaro.org>, 
	stratos-dev@op-lists.linaro.org, xen-devel@lists.xenproject.org, 
	AKASHI Takahiro <takahiro.akashi@linaro.org>, Arnd Bergmann <arnd.bergmann@linaro.org>, 
	Christopher Clark <christopher.w.clark@gmail.com>, Dmytro Firsov <dmytro_firsov@epam.com>, 
	Julien Grall <julien@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
	Oleksandr_Tyshchenko@epam.com, Artem_Mygaiev@epam.com, 
	bertrand.marquis@arm.com, Wei.Chen@arm.com, Ed.Doxat@arm.com, 
	Oleksii_Moisieiev@epam.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, 16 Feb 2022 at 22:45, Stefano Stabellini
<stefano.stabellini@xilinx.com> wrote:
>
> On Tue, 15 Feb 2022, Vincent Guittot wrote:
> > On Tue, 8 Feb 2022 at 01:16, Stefano Stabellini
> > <stefano.stabellini@xilinx.com> wrote:
> > >
> > > On Mon, 7 Feb 2022, Alex Benn=C3=A9e wrote:
> > > > Hi Stefano,
> > > >
> > > > Vincent gave an update on his virtio-scmi work at the last Stratos =
sync
> > > > call and the discussion moved onto next steps.
> > >
> > > Hi Alex,
> > >
> > > I don't know the specifics of virtio-scmi, but if it is about power,
> > > clocks, reset, etc. like the original SCMI protocol, then virtio-scmi=
 is
> >
> > virtio-scmi is one transport channel that support SCMI protocol
> >
> > > likely going to be very different from all the other virtio frontends
> >
> > The virtio-scmi front-end is merged mainline
> >
> > > and backends. That's because SCMI requires a full view of the system,
> > > which is different from something like virtio-net that is limited to =
the
> > > emulation of 1 device. For this reason, it is likely that the
> > > virtio-scmi backend would be a better fit in Xen itself, rather than =
run
> > > in userspace inside a VM.
> >
> > Not sure what you mean when you say that SCMI requires a full view of
> > the system.
>
> SCMI can be used to read the status of resources in the system and
> typically leads to a full view of the system's resources.
>
> If I assign the USB controller to a VM, I expect that VM to only "see"
> the USB controller and any attached USB peripherals, in addition to the
> other regular virtual resources that a VM commonly has.
>
> If I assign SCMI to a VM, I expect the VM to "see" everything in the
> system thanks to the SCMI probing functions. Unless we only assign a
> single SCMI channel with limited capabilities to the VM, like EPAM's
> patch series on xen-devel is doing.


>
>
> > If you are referring to the system wide resources which
> > reset or power up/down the whole SoC, this is not really what we are
> > targeting here. Those system wide resources should already be handled
> > by a dedicated power coprocessor. In our case, the IPs of the SoC will
> > be handled by different VMs but those IPs are usually sharing common
> > resources like a parent PLL , a power domain or a clock gating reg as
> > few examples. Because all those VMs can't directly set these resources
> > without taking into account others and because the power coprocessor
> > doesn't have an unlimited number of channels, we add an SCMI backend
> > that will gather and proxy the VM request before accessing the
> > register that gates some clocks IP as an example or before powering
> > down an external regulator shared between the camera and another
> > device.
>
> Do you know what would be the expected number of SCMI channels available
> in a "normal" deployment?

I don't have a fixed value but it can comes from few to hundreds
depending of the product

>
> My expectation was that there would be enough SCMI channels to give one
> for each VM in a common embedded scenario, where the number of VMs is
> typically not very high. If we have enought channels so that we can
> assign each channel to a different VM maybe we can get away without a
> proxy?

If you have enough HW channels per VM then you don't need anything
including what EPAM is proposing. But part of my requirement is that
we don't have enough HW resources and we don't want to update the
secure power coprocessor for each and every product.

In SCMI, each channel/agent can have its own view of available
resources; Typically only the ATF/PSCI channel can power off the whole
system but not OSPMs agent

>
>
> > This SCMI backend will most probably also send request with
> > OSPM permission access to the power coprocessor once aggregating all
> > the VMs ' request
>
> Please correct me if I am wrong, but I would have expected the SCMI
> firmware to be able to do reference counting on the hardware resources
> and therefore be able to handle the case where:

The example that I have in mind is :
current case: Linux takes care of a clock divider that provides clocks
for let say video decoder and SD controller but its parent is a system
clock shared with others subsystem which is managed by the power
coprocessor.
Linux will 1st send a request to the coprocessor to enable system
clock. Then it will set the divider and probably ungates the clock at
HW IP level

Now we move the sdcard in VMA and the video decoder in VMB.
The SCMI server VM will take care of the clock divider and clock gating reg=
ister
VMA will send a request to SCMI backend which aggregates/refcounts its
request with VMB request. When it needs to enable the clock divider,
It will 1st send a request to the coprocessor for the system clock.

The coprocessor stays unchanged and the SCMI backend can be adjusted
per product.

>
> - we have 2 VMs
> - each VM has its own SCMI channel
> - a VM requests power-off on 1 resource also used by the other VM

yes it has refcounting but you assume that you have enough HW channels.
It also implies that the coprocessor firmware is different for each
and every end product because you will have to adjust the scmi
permission of each channel

>
> My understanding of the SCMI protocol is that the SCMI firmware
> implementation should detect that the resource in question is also
> in-use by another VM/channel and thus it would refuse the power-off
> operation. (For your information, that is also how the Xilinx EEMI
> protocol works.)
>
> Reference counting is a key requirement for a good multi-channel
> implementation. If SCMI doesn't support it today, then we have a
> problem with SCMI multi-channel, regardless of virtualization.channels
>
>
> > We are using virtio-cmi protocol because it has the main advantage of
> > not being tied to an hypervisor
>
> That is a valuable goal, which is a bit different from the goal of
> finding the best SCMI architecture for Xen, and that's OK. Let's see if
> we can find any common ground and synergies we can exploit to improve
> both goals. I'll join the Stratos meeting tomorrow.

Great

>
>
> > In our PoC, the SCMI backend is running with zehyr and reuse the same
> > software that can run in the power coprocessor which helps splitting
> > what is critical and must be handled by power coprocessor and what is
> > not critical for the system (what is usually managed by linux directly
> > when their no hypervisor involved typically)
> >
> >
> > > FYI, a good and promising approach to handle both SCMI and SCPI is th=
e
> > > series recently submitted by EPAM to mediate SCMI and SCPI requests i=
n
> > > Xen: https://marc.info/?l=3Dxen-devel&m=3D163947444032590
> > >
> > > (Another "special" virtio backend is virtio-iommu for similar reasons=
:
> > > the guest p2m address mappings and also the IOMMU drivers are in Xen.
> > > It is not immediately clear whether a virtio-iommu backend would need=
 to
> > > be in Xen or run as a process in dom0/domU.)
> > >
> > > On the other hand, for all the other "normal" protocols (e.g.
> > > virtio-net, virtio-block, etc.) the backend would naturally run as a
> > > process in dom0 or domU (e.g. QEMU in Dom0) as one would expect.
> > >
> > >
> > > > Currently the demo setup
> > > > is intermediated by a double-ended vhost-user daemon running on the
> > > > devbox acting as a go between a number of QEMU instances representi=
ng
> > > > the front and back-ends. You can view the architecture with Vincent=
s
> > > > diagram here:
> > > >
> > > >   https://docs.google.com/drawings/d/1YSuJUSjEdTi2oEUq4oG4A9pBKSEJT=
Ap6hhcHKKhmYHs/edit?usp=3Dsharing
> > > >
> > > > The key virtq handling is done over the special carve outs of share=
d
> > > > memory between the front end and guest. However the signalling is
> > > > currently over a virtio device on the backend. This is useful for t=
he
> > > > PoC but obviously in a real system we don't have a hidden POSIX sys=
tem
> > > > acting as a go between not to mention the additional latency it cau=
ses
> > > > with all those context switches.
> > > >
> > > > I was hoping we could get some more of the Xen experts to the next
> > > > Stratos sync (17th Feb) to go over approaches for a properly hosted=
 on
> > > > Xen approach. From my recollection (Vincent please correct me if I'=
m
> > > > wrong) of last week the issues that need solving are:
> > >
> > > Unfortunately I have a regular conflict which prevents me from being
> > > able to join the Stratos calls. However, I can certainly make myself
> > > available for one call (unless something unexpected comes up).
> > >
> > >
> > > >  * How to handle configuration steps as FE guests come up
> > > >
> > > > The SCMI server will be a long running persistent backend because i=
t is
> > > > managing real HW resources. However the guests may be ephemeral (or=
 just
> > > > restarted) so we can't just hard-code everything in a DTB. While th=
e
> > > > virtio-negotiation in the config space covers most things we still =
need
> > > > information like where in the guests address space the shared memor=
y
> > > > lives and at what offset into that the queues are created. As far a=
s I'm
> > > > aware the canonical source of domain information is XenStore
> > > > (https://wiki.xenproject.org/wiki/XenStore) but this relies on a Do=
m0
> > > > type approach. Is there an alternative for dom0less systems or do w=
e
> > > > need a dom0-light approach, for example using STR-21 (Ensure Zephyr=
 can
> > > > run cleanly as a Dom0 guest) providing just enough services for FE'=
s to
> > > > register metadata and BE's to read it?
> > >
> > > I'll try to answer the question for a generic virtio frontend and
> > > backend instead (not SCMI because SCMI is unique due to the reasons
> > > above.)
> > >
> > > Yes, xenstore is the easiest way to exchange configuration informatio=
n
> > > between domains. I think EPAM used xenstore to exchange the
> > > configuration information in their virtio-block demo. There is a way =
to
> > > use xenstore even between dom0less VMs:
> > > https://marc.info/?l=3Dxen-devel&m=3D164340547602391 Not just xenstor=
e but
> > > full PV drivers too. However, in the dom0less case xenstore is going =
to
> > > become available some time after boot, not immediately at startup tim=
e.
> > > That's because you need to wait until xenstored is up and running.
> > >
> > > There are other ways to send data from one VM to another which are
> > > available immediately at boot, such as Argo and static shared memory.
> > >
> > > But dom0less is all about static partitioning, so it makes sense to
> > > exploit the build-time tools to the fullest. In the dom0less case, we
> > > already know what is going to run on the target before it is even tur=
ned
> > > on. As an example, we might have already prepared an environment with=
 3
> > > VMs using Yocto and ImageBuilder. We could also generate all
> > > configurations needed and place them inside each VMs using Yocto's
> > > standard tools and ImageBuilder. So for dom0less, I recommend to go v=
ia
> > > a different route and pre-generate the configuration directly where
> > > needed instead of doing dynamic discovery.
> > >
> > >
> > > >  * How to handle mapping of memory
> > > >
> > > > AIUI the Xen model is the FE guest explicitly makes grant table req=
uests
> > > > to expose portions of it's memory to other domains. Can the BE quer=
y the
> > > > hypervisor itself to discover the available grants or does it requi=
re
> > > > coordination with Dom0/XenStore for that information to be availabl=
e to
> > > > the BE domain?
> > >
> > > Typically the frontend passes grant table references to the backend
> > > (i.e. instead of plain guest physical addresses on the virtio ring.)
> > > Then, the backend maps the grants; Xen checks that the mapping is
> > > allowed.
> > >
> > > We might be able to use the same model with virtio devices. A special
> > > pseudo-IOMMU driver in Linux would return a grant table reference and=
 an
> > > offset as "DMA address". The "DMA address" is passed to the virtio
> > > backend over the virtio ring. The backend would map the grant table
> > > reference using the regular grant table hypercalls.
> > >
> > >
> > > >  * How to handle signalling
> > > >
> > > > I guess this requires a minimal implementation of the IOREQ calls f=
or
> > > > Zephyr so we can register the handler in the backend? Does the IORE=
Q API
> > > > allow for a IPI style notifications using the global GIC IRQs?
> > > >
> > > > Forgive the incomplete notes from the Stratos sync, I was trying to=
 type
> > > > while participating in the discussion so hopefully this email captu=
res
> > > > what was missed:
> > > >
> > > >   https://linaro.atlassian.net/wiki/spaces/STR/pages/28682518685/20=
22-02-03+Project+Stratos+Sync+Meeting+Notes
> > >
> > > Yes, any emulation backend (including virtio backends) would require =
an
> > > IOREQ implementation, which includes notifications via event channels=
.
> > > Event channels are delivered as a GIC PPI interrupt to the Linux kern=
el.
> > > Then, the kernel sends the notification to userspace via a file
> > > descriptor.
> >


From xen-devel-bounces@lists.xenproject.org Thu Feb 17 14:03:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 17 Feb 2022 14:03:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274791.470377 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKhNK-0007O2-Nz; Thu, 17 Feb 2022 14:03:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274791.470377; Thu, 17 Feb 2022 14:03:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKhNK-0007Nv-KZ; Thu, 17 Feb 2022 14:03:14 +0000
Received: by outflank-mailman (input) for mailman id 274791;
 Thu, 17 Feb 2022 14:03:13 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nKhNJ-0007Nl-4n; Thu, 17 Feb 2022 14:03:13 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nKhNI-0006Er-Tv; Thu, 17 Feb 2022 14:03:12 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nKhNI-0005d0-Kz; Thu, 17 Feb 2022 14:03:12 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nKhNI-0008Rt-Ka; Thu, 17 Feb 2022 14:03:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ltpXWTGcjbjoSLpOdS9gdUSli4V2ef4rPW+EMUlDtrc=; b=q/ISHSLkV6C8ml98nTXx/k7I2H
	6qKMp8plT376U5cAHf3apzQFfmy/51dXSAXen5EU43KHOHzMtaOgREPPdHZZz2co8kbrAZLKixdVK
	XzT/DHcTj0TIxrUtCDqSp1X3FH4xVYcrg7wCFOP42dWiSgJOFabMsZxwpydS7SiUeu/M=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168144-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 168144: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=3593030761630e09200072a4bd06468892c27be3
X-Osstest-Versions-That:
    linux=c5d9ae265b105d9a67575fb67bd4650a6fc08e25
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 17 Feb 2022 14:03:12 +0000

flight 168144 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168144/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10       fail  like 168126
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168126
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168126
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168126
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168126
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168126
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168126
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168126
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168126
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                3593030761630e09200072a4bd06468892c27be3
baseline version:
 linux                c5d9ae265b105d9a67575fb67bd4650a6fc08e25

Last test of basis   168126  2022-02-16 04:32:24 Z    1 days
Testing same since   168144  2022-02-16 19:41:31 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Linus Torvalds <torvalds@linux-foundation.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   c5d9ae265b10..359303076163  3593030761630e09200072a4bd06468892c27be3 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Thu Feb 17 14:09:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 17 Feb 2022 14:09:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274804.470389 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKhTZ-00089j-KR; Thu, 17 Feb 2022 14:09:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274804.470389; Thu, 17 Feb 2022 14:09:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKhTZ-00089c-Gg; Thu, 17 Feb 2022 14:09:41 +0000
Received: by outflank-mailman (input) for mailman id 274804;
 Thu, 17 Feb 2022 14:09:40 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=A/h9=TA=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nKhTY-00089W-1x
 for xen-devel@lists.xenproject.org; Thu, 17 Feb 2022 14:09:40 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 3c7969b3-8ffb-11ec-8eb8-a37418f5ba1a;
 Thu, 17 Feb 2022 15:09:38 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3c7969b3-8ffb-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645106977;
  h=from:to:cc:subject:date:message-id:
   content-transfer-encoding:mime-version;
  bh=SUEtwAWtcJz8FFqOViIaRergwqEBWyJ861AsBOVBCKI=;
  b=R/Hx+VqmH+l7+XmjT+5i3x2FpCykfy35fzZxn/f+++5Iqi0nLh3AJwXb
   MQvHT93q2V2MhWh9p4R+M6lTa5slkQQQ+hlOS0W8CP3aHti/NemZqJqvu
   8LeQvURFf8k0RlSzgfey3tyoRZJuPoPZ9BwZONzO299RVkiM0vH+1nTnE
   4=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: 0c5sTZ7sv4VGS7eBVNASqvWdxYBNWSFNbEZAVoAure3ceqSF46EHxBpwVW32mJ0WOr7QT1NRbf
 m1zNcE38Cy/0Rf6oqkNIqqgY2Bu89H8trZ0Za3z00eti2vdE6ZJzLg/hCw+Z67gvKRo3F8ApKU
 auSrBVjOQKXsGZv6UWVHC35D8CbI1hTeYivhjRyso7CqPzFEV7CzbssvHNv1j6g1r6lgH9SVrP
 ZyL3HMz4jmVFs77iHH/zwW8spMGq2SmHWfQqoBBlr0a3cTL2uZyLlB7uwUxZb2lDZ1SVEccYgH
 COAe9ORfCwGG2Lpc4vMKh7xW
X-SBRS: 5.1
X-MesageID: 64434754
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:jVllGa0Mwj19pTUr/fbD5Tx2kn2cJEfYwER7XKvMYLTBsI5bp2FUn
 WMaC26CbPuCYmvyLdEnOt639E4F7Z6HndVlSwI+pC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkS5PE3oHJ9RGQ74nRLlbHILOCanAZqTNMEn9700o5wrFh2OaEvPDia++zk
 YKqyyHgEAfNNw5cagr4PIra9XuDFNyr0N8plgRWicJj5TcypFFMZH4rHomjLmOQf2VhNrXSq
 9Avbl2O1jixEx8FUrtJm1tgG6EAaua60QOm0hK6V0U+6/TrS+NbPqsTbZIhhUlrZzqhvNB76
 /IcmKaMVV0JOrHUku5BWkZBHHQrVUFG0OevzXmXtMWSywvNcmf2wuUoB0YzVWEa0r8pWycUr
 6VecW1TKEDY7w616OvTpu1EnMMsIdOtJIoCknph0SvYHbAtRpWrr6Diu4MEh2tv25wm8fD2O
 8weN2B2MTL6UTYTJ3o7Wbtit8ivryyqG9FfgA3M/vdmi4TJ9yRz36LqK8H9YcGRSINemUPwj
 mDM8nn9AxoaHMeC0jfD+XWp7sffkCW+VI8MGbmQ8v9xnEbV1mEVEAcRV1awvb++kEHWc81bA
 1wZ/Gwpt6dayaCwZoCjBVvi+ifC50NCHYoLewEn1O2T4onU6SW+V0U+ciIbSNg6rMU8GTV1z
 1DcyrsFGgdTmLGSTHuc8JKdojWzJTUZIAc+WMMUcecWy4K9+d9u13ojWv4mSffo1YOtRVkc1
 hjX9HBWulkFsSIcO0xXF3jjiinkmJXGRxVdCu7/DjP8tVMRiGJIiuWVBbnnARRocNfxorqp5
 iFsdy2iAAYmV87leMulGrhlIV1Rz6zZWAAweHY2d3Xbyxyj+mS4Yadb6yxkKUFiP64sIGG1P
 ReI5l0NucQMYRNGiJObharrVKzGKoC6SLzYug38NIISMvCdiifclM2RWaJg9z+0yxV9+U3OE
 ZyabdytHR4n5VdPl1KLqxMm+eZznEgWnDqLLbiilkjP+efONRa9FOZeWHPTP79R0U9xiFiMm
 zqpH5DRkEs3vSyXSnS/zLP/2nhRfCJkW86n8J0MHgNBSyI/cFwc5zbq6epJU6RunrhPl/eO+
 Xe4W0RCz0H4i2GBIgKPAk2Popu1NXqmhX5kbyEqI3iy3H0vPdSm4KsFLsNldrg77u1zi/VzS
 qBdKcmHB/1OTBXB+igcMsah/NAzKkzziFLcJTehbRg+Y4VkG17D9Oj7c1a97yIJFCe265cz+
 uXyygPBTJMfbA1+F8KKOum3xla8sCFFyuJ/VkfFOPdJf0Do/NQ4IiD9lKZvccoNNQ/C1n2R0
 APPWUUUouzEookU9tjVhP/b89f1QrUmRkcDRjvV97e7MyXe71GP+44YXbbaZy3ZWUP15L6mO
 bdfwcbjPaBVh11NqYd9TepmlPps+9v1qrZG5Q14B3GXPU+zA7ZtL3Taj8lCsqpBmu1QtQesA
 x/d/9BbPfOCOd//EU5XLw0gN7zR2fYRkzjUzPI0PESlu3MnoOvZCR1fb0uWlShQDLppK4d0k
 +4utfkf5xG7lhd3YM2NiTpZ9jjUI3ENO0n9Wkr23GM/ZtIX92x/
IronPort-HdrOrdr: A9a23:K6vRhq0o2mJFrx7TBwJA5wqjBV5yeYIsimQD101hICG9Lfb2qy
 n+ppgmPEHP5Qr5OEtApTiBUJPwJU80kqQFm7X5XI3SJzUO3VHHEGgM1/qF/9SNIVydygc/79
 YeT0EdMqyIMbESt6+Ti2PZYrUdKbG8gdyVbIzlvhBQpG9RGsRdB1ATMHfnLqQ6fngOObMJUL
 6nouZXrTupfnoaKuy9G3k+RuDG4/nGjojvbxIqDwMurFDmt0Li1JfKVzyjmjsOWTJGxrkvtU
 DDjgzC/62m99W20AXV2WP/54lf3PHh1txALsqRjdV9EESlti+YIKBaH5GStjE8p++irH4sjd
 n3uh8le/9+7nvAF1vF1SfF6k3F6nID+nXiwViXjT/IusriXg83DMJHmMZwbgbZw1BIhqAx7I
 t7m0ai87ZHBxLJmyrwo/LSUQtxq0ayqX0+1cYOkn1kV5cEYrM5l/1TwKpsKuZPIMvG0vFnLA
 E3Z/uspMq+MGnqJUwxh1Mfj+BFBR8Ib1S7qktrgL3h79EZpgE686Ii/r1vop43zuNOd3B13Z
 W7Dk1WrsA/ciZvV9MEOA4ge7rBNoWfe2O7DIqtSW6XZ53vfUi97qLK3A==
X-IronPort-AV: E=Sophos;i="5.88,376,1635220800"; 
   d="scan'208";a="64434754"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=facQYtpmeQKqa/rBz8SWgotskqCSQh6TYNjmYh/he0qEuWxZgvsRjHQ5CbAuso3yCzyF36j5CLXLfo/cMiKT2zop5TvW3ETkxlXkO0MP1mTn6iYpPsbFb2UUyEEimFCDLMIY3Cm/3HUNMjfyUVjGiZw3GzNs4SqDQ3YmbI1rNn1JFcq/hbp3PhQgkiFCjekjgbVmxst5XzRKyxsHIRld9AIQUjIJB8AO6bsh+Jo/4Yn9Lumz1SqXqtKvX7evcPG/N3+T1R1fN04wYYBrOsOTifOg4aG0yrPsyt2J7xUZQZTYQCuIJX/EzCbAxMsQd5zaGCB7bL+r9ZbdjTwbckGGUQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=RmFW8G1SOY+FkPII6jLYpk2BttaqjF96Q4Wld3f0da8=;
 b=lTSbvFXO8gPAtngUkUS/7fomtZ4HftlRFBr4e3luRuoEeIy2o6q++Il4R1o8L+sHUL/8qp4hFToQijE0OPTwISgSe4lSvAiMKoC25YtGHB1tg2lQr7XIIblIZXcvnJrAMh6edTbtqI+TbGyXbzXsY4qtb51hzUz4MEq8yME/aHE8yeuhdtw3ZZXRQRDH4Z8yNNutym/wiglLULFNZHO0EYyxzBtJpZlocgSFuVi+hQ4Pl0Rxdwb8behJDjn5ncdD1VtChHB+sbxPh8wlgJbdcmS0T17J/ZXH9iAI5tOBlklRB2BBEev1kKz9zaI5klVYHJprU2PyxSyXCSYmRTzQ5w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=RmFW8G1SOY+FkPII6jLYpk2BttaqjF96Q4Wld3f0da8=;
 b=qVC65ufPCLzjkCm35KVHdB7m350phu5u83/feu+8VXd6QS0ytNXYwXKGgEldLjphCiHH93jknxd8Q6I+uWDaUZZWq6fIALRHyEOJBdjIEas6+JCxORq04yFtDVq0fON0+cf1nrKBDccXm+29qUVQhygSB9A839aeLW1iTYg16eI=
From: Roger Pau Monne <roger.pau@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>, Anthony
 PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, Jan
 Beulich <jbeulich@suse.com>
Subject: [PATCH v3] tools/libxl: don't allow IOMMU usage with PoD
Date: Thu, 17 Feb 2022 15:09:23 +0100
Message-ID: <20220217140923.22485-1-roger.pau@citrix.com>
X-Mailer: git-send-email 2.34.1
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO2P123CA0074.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:138::7) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9d22b2f6-69c8-4427-3f8f-08d9f21f1d8a
X-MS-TrafficTypeDiagnostic: MWHPR03MB2736:EE_
X-Microsoft-Antispam-PRVS: <MWHPR03MB27360B3F343AF7C35D6939A48F369@MWHPR03MB2736.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5236;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: LpcFedqog8Ws84N7uxoBccczQaGY+15CES20Jwg8xTBVRMdk0Gni4QRwqGauALuBB8jsKAqLfV8tvidqW70+gGo31Yvg7ewuzqkps7dsbEYr9NGQiQh+pm0JQAT/iKvxhnXGOtOkuOw/8gN8KC1M8TqIJBwFyofFu4E4FCz5bBcxPqVtFLR9xGuvaQwFGMMVefbPjegHr2PkcMrrfzK0CgjjTOuofosYRYjMM/BIGsO4iy3r0t6RIwaWBtO8USvpmHVEFY6Ux1oOoQXd0rgtyxYtOA4DPyu2lUGU/9Bmeaz/PoZkiXXc94jRGDAbFAXbwLij4NaT7NBrAf8d1AB6QBqKtW973xnUYu6ovkREwuz7rQTtoyYgRWGZf5CRXELvxIyOvxU+/zP3jzAgy8IOux57019eeDhh3lNFACcRQDgeD3Vi0SO0GngrbJfiB/ffGGgMUE+DnC8pA/hRy7Ar4vpz1L7CmcFd1dLcfh1d5GNi8EM/+aEyEzEmaxO6X85g0MlYlXncrcRUt5DJGeZ3A9DpA77dGKujF5k7qt17c61Cu6Mu7FfKIY0aZFZAnnEVMS3AUDeO2FhbZGKF8dAmeioc6hk3o6ouWxeEjYeENl0A/s51ibNDrowXeCEu/ZzQNmcbnCUoLNRcf5EETz8Sxg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38100700002)(1076003)(86362001)(82960400001)(2906002)(8936002)(5660300002)(2616005)(508600001)(186003)(26005)(6506007)(6666004)(6916009)(316002)(54906003)(6512007)(66946007)(66476007)(66556008)(83380400001)(36756003)(8676002)(6486002)(4326008);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R0NhU2NjRUlHdHFxSjgwMGg0YWU5QTN4SlZOdk81MVZJcHpTSDdkVUR3eW54?=
 =?utf-8?B?OTloMUhKSzdDNjFVamF4ekl4dHdTUFRRNGFsQU9NTVQ0TGZFYk9LcTJBVXAv?=
 =?utf-8?B?REF5ZXltYmNMV1l0bWVrVHhlaGcyVEhidVBxSnNsa0N1enZyaHhuSVZ4NE5J?=
 =?utf-8?B?R216N1ZqdDQrY1BFa0pSUXpWcGFQZXJHOUk4UWxWM1lJVlI1dGlRNHJMZDhw?=
 =?utf-8?B?T0ZwT2Zkamwxdmd2Y09EbXlnZ2kram82eHlRek95YlhqQzBOdXZwQmJGNnRx?=
 =?utf-8?B?UGx6dFIvakQ1WCt6SGVBVTdGY0FOOGgyMjZJaDhKOFRpUENmNVFIOFpONjZB?=
 =?utf-8?B?T2VXMnNycXo5RlhYNGRvRlFPOUdJNkRLNkgyWW4wY3BwRTNrYWt0a3lndlhp?=
 =?utf-8?B?dk9aa3A2QnlLTXRvTkV3MVcyU2gzK0xOdHc1SVpNaXoxOFBUekkrWi96ckg2?=
 =?utf-8?B?OFJDdE1JMDlZQnZsdUdPOTVKUjBGUUtNVFBWZXRoc3FBNnl1ekM2cTR1QTFw?=
 =?utf-8?B?WnRnTERsWXQ5ck5jOWVLYnZUeVkvbi8weFFjZk0xMFpZRjl2aHl0dDFOLzM0?=
 =?utf-8?B?Y1NIRDhObkVCbmMwV09XTngvVFdNSGM4dllJZ1lMZk1TSW4yWHAyU2RzQkMz?=
 =?utf-8?B?QmJYZDg2eVE4aVU2SzdRaVluNWEvUG5GWkNzNmk1QURjclh5U0VURWdLRlhP?=
 =?utf-8?B?WThlcVVhb3RldXNWRStMOERqT3k5aC9EK25Zb2s5bTEzVXdCbGJUQW40dmhB?=
 =?utf-8?B?OUVFak9kbUp3SkxSak8xYitRdHBHZ2JjU3dqTUlZbW1UamR1bTlNbWZKTFRn?=
 =?utf-8?B?TzlIWWU1dmVEVk5nYnVrRUJUUDljQkg5d1lNSVNWT1JHdnd6WVlWSHJWSzMv?=
 =?utf-8?B?YWU4Z2VPd2tVY3FCTXJBRkV0WGRsRUZlQlU5MklOdTl1Y2h0cDJIckJEeGE1?=
 =?utf-8?B?VXNyUzNRdUtQV1MrTU5OdDJLWmVhdU1hSEc1c0NIUWxnOXJpUzI3OUVrSTJp?=
 =?utf-8?B?WUx1RmxJLzAwdW5OWEtlczJ6VnJxVGVGbjdGRytjcGUxOVpUN2RLQVhOTzRh?=
 =?utf-8?B?czlwWlNqZGRHdG1YV25FbW9xUmx6QlJZQmtQemc5THM1QUtvQ21ZcHh1bEdZ?=
 =?utf-8?B?R3MzU0F5OUtaQjJNVFBKUkx0MDk3K1NkZXUrWE9lVU5jdlFYZml0M3Nlb2ZL?=
 =?utf-8?B?NEVUcnAreG82K3JrN2NFV0lGallrd0lUY3hob0FINVppT1NBeUhrTWhhYmJZ?=
 =?utf-8?B?WS9PL2lvdFluemF5akY3TXh4YXRVaHk0bHZ1blg4Mmx3a2ZTT1VwWmdPQU9v?=
 =?utf-8?B?bHlJQ2dwUmNjV285Z21wUjdrc254WXlnM2dkdmIxY2p5QU04MFZkL21JNjZ2?=
 =?utf-8?B?RzFRSERkMFJhZ0ZwckZMeGhTTmJJL1hiUXMrM3Bkbi96c1NNZzY0ckorS2lo?=
 =?utf-8?B?Yk8ycG4ycFlYc0NtUkFJWk1IMW1oTUJPa3p6TkVkazN5d0s2cGFsbVovcjMr?=
 =?utf-8?B?MXNxeXQydXVubFlYYnBJSEx1bXRZRW5LZElIMGxRbWswMUFDUHJXZGRXeThY?=
 =?utf-8?B?S2tNR3RSQi9lb09PY0hvcGVXa1IvZG1TcEhRNnFCUHl3ZUFlNGhxMzA1Q0ZY?=
 =?utf-8?B?THk5cm5TSFQ2Si9vWkh2Z0pyYWxxYjdtYmN2QkoxQ1hiL3Jvdk4vZXZoYXpX?=
 =?utf-8?B?RlR5N2dJU21Eak02bHFoRDc2b3hhbVlQSkZOLzRkajVZclZaME9FSVB3Mmk1?=
 =?utf-8?B?dmx6NzViTEcydkdvNVNOMnZzOVY2a0VkbWplaXcwWUtNU210aTlrUFVMSjdL?=
 =?utf-8?B?aWhQQmhhSGpaaW5VbUk4Y0VHbURuSldEeGhVV0NTS3VtQ0NIMXpXSldQR3RI?=
 =?utf-8?B?SGh0TUJVenlNR3VRNVRPa3JhYkpiSW1xZzRpa1h1MDV6WWoyZjRLZUdMaVBR?=
 =?utf-8?B?aFhNZ3VoNDRZSmZlNFFvR0tKSGJkemtDNUVTcTA0RkQ0ckhISGo4dGU0NGpn?=
 =?utf-8?B?V2ZUQ2doc3BpMnRtcFYrbnVGaDNwQmpuSzlLSVhVUkFHR0NmL3N0V0RDNmJZ?=
 =?utf-8?B?bWRxanVRRHlxcE1kbHFuaWxqbCtsMTZaV1BWUlZuaEVaZVRFTGJYcmZ0Z3E3?=
 =?utf-8?B?ckl6c1l6QjhkYkQwbmRFa2FWRlJwbHBzK3I3Qk1kQk81TWxNanVYZGRwYTl3?=
 =?utf-8?Q?VpcA5rwisaifvfbxrybKXV4=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9d22b2f6-69c8-4427-3f8f-08d9f21f1d8a
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2022 14:09:30.6111
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2Us3TIDI4Bxb+3A9rE8fsPRQKMeNaH2D573uDwyYpUA37CruKpGTI7YVIFbC58CD0NsgQm2v3R3n0N8jE7Zuvg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2736
X-OriginatorOrg: citrix.com

Prevent libxl from creating guests that attempts to use PoD together
with an IOMMU, even if no devices are actually assigned.

While the hypervisor could support using PoD together with an IOMMU as
long as no devices are assigned, such usage seems doubtful. There's no
guarantee the guest has PoD no longer be active, and thus a later
assignment of a PCI device to such domain could fail.

Preventing the usage of PoD together with an IOMMU at guest creation
avoids having to add checks for active PoD entries in the device
assignment paths.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>
---
Cc: Jan Beulich <jbeulich@suse.com>
---
Changes since v2:
 - Reword error message.

Changes since v1:
 - Reword commit message.
---
 tools/libs/light/libxl_create.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_create.c
index d7a40d7550..15ed021f41 100644
--- a/tools/libs/light/libxl_create.c
+++ b/tools/libs/light/libxl_create.c
@@ -1160,17 +1160,17 @@ int libxl__domain_config_setdefault(libxl__gc *gc,
     pod_enabled = (d_config->c_info.type != LIBXL_DOMAIN_TYPE_PV) &&
         (d_config->b_info.target_memkb < d_config->b_info.max_memkb);
 
-    /* We cannot have PoD and PCI device assignment at the same time
-     * for HVM guest. It was reported that IOMMU cannot work with PoD
-     * enabled because it needs to populated entire page table for
-     * guest. To stay on the safe side, we disable PCI device
-     * assignment when PoD is enabled.
+    /* We don't support having PoD and an IOMMU at the same time for HVM
+     * guests. An active IOMMU cannot work with PoD because it needs a fully
+     * populated page-table. Prevent PoD usage if the domain has an IOMMU
+     * assigned, even if not active.
      */
     if (d_config->c_info.type != LIBXL_DOMAIN_TYPE_PV &&
-        d_config->num_pcidevs && pod_enabled) {
+        d_config->c_info.passthrough != LIBXL_PASSTHROUGH_DISABLED &&
+        pod_enabled) {
         ret = ERROR_INVAL;
         LOGD(ERROR, domid,
-             "PCI device assignment for HVM guest failed due to PoD enabled");
+             "IOMMU required for device passthrough but not supported together with PoD");
         goto error_out;
     }
 
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Thu Feb 17 14:39:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 17 Feb 2022 14:39:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274812.470399 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKhwa-00031m-0q; Thu, 17 Feb 2022 14:39:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274812.470399; Thu, 17 Feb 2022 14:39:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKhwZ-00031f-UC; Thu, 17 Feb 2022 14:39:39 +0000
Received: by outflank-mailman (input) for mailman id 274812;
 Thu, 17 Feb 2022 14:39:38 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=xzkl=TA=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nKhwY-00031Y-9u
 for xen-devel@lists.xenproject.org; Thu, 17 Feb 2022 14:39:38 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6db386ac-8fff-11ec-8eb8-a37418f5ba1a;
 Thu, 17 Feb 2022 15:39:36 +0100 (CET)
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur01lp2052.outbound.protection.outlook.com [104.47.0.52]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-12-ih_-3N9dNI64B5ZMD5aDow-1; Thu, 17 Feb 2022 15:39:34 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by HE1PR0401MB2346.eurprd04.prod.outlook.com (2603:10a6:3:23::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.16; Thu, 17 Feb
 2022 14:39:32 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4995.016; Thu, 17 Feb 2022
 14:39:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6db386ac-8fff-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645108776;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=dP1p/T8Bhac5jKrK8H6jCmoDnc3lGYrdmo5Lu7G2Uc4=;
	b=PsKbFz9nCusdpeGJtuUFPr7IaZQ6gSadD2cejqXnI7uCvwc0L4ZsecnH0zgkBNW2klF0I5
	FUDT5mPNRmODGC3ssigOstif7MencGJOEFYbhog/+psvEo/YgFJ+Z2zA7wj3xDMO0QK06c
	E0JaIrvzyUJkDrjDMgiVNOgSaMw1AgE=
X-MC-Unique: ih_-3N9dNI64B5ZMD5aDow-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ESqX0Am2z5yuoxVuzCXXycuND6agExhNGqtIFws0vNBHDeFLKA2D1JbyF1Jcz9w5/mbL/1IZXeIyUxmoikghRn7r+1EopdbEye5iD4Sys9CmAI180mD9zoGuLehKTnRH4WG6tEJw1N3fmwgnZKxozEls9qF3/rYpZXFneQMy5Lml36LbLDrdaEoFCchenFnd5uvVepFW9m4qUmZtkdH9nbC0Lr7Ng5ZdhBwDtAZzJOo6D4z7awOr0yzsXsTSMZIzQ27i8CRzH5W+0RXqZHdeCmCXKftAE6Lhra1PisjPe2OhDKagii+bmx6Vzru0VEPYDPhPT5e66JdxLT6s4N++Rg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=q8qfcCKNg6fcvSUgvLIzGViEgbFFi9JhMHMAPhxCAyM=;
 b=ebDMyWAw8AvPgYiRbd2B1IvzyvJUmnAKWXtGasgtGdJVWc2TaUExk/8eZwgE0OzHgaSG3ZcSnfkCSgqCyJMk/GLXiXMVA1ROub31t/QQrr1GYZmJBnoHNJqz6eTGL7YKE5W0pmNM3uwSgwUn/JaMLTcnaIDcvxN2fKML8tnABUZPpKOzcTzXuu7fKO8RIPOFM6oVlZ7A/aecZnHER6QP8/XffvNbwgOSO5hHfvnOCaG71/PbvLASjs8/6BgAq72A34K6MqahUB2RyQB9Zk/0DqetZaT7IsioTKPmE4QFdLjCKh7yyGRj4PtDGuWNEA676sf+XxkMlbgG2eOOA/VGnw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <4faeba1f-1062-e08f-1a5a-0b8bb383fe7e@suse.com>
Date: Thu, 17 Feb 2022 15:39:30 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH] x86/console: process softirqs between warning prints
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220217082850.19407-1-roger.pau@citrix.com>
 <16386211-4909-da40-3b0f-c76d64289cd3@suse.com>
 <Yg46HsntJztYBQS0@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Yg46HsntJztYBQS0@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0043.eurprd06.prod.outlook.com
 (2603:10a6:20b:463::19) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9e9744da-4596-4ff8-6685-08d9f2234fc2
X-MS-TrafficTypeDiagnostic: HE1PR0401MB2346:EE_
X-Microsoft-Antispam-PRVS:
	<HE1PR0401MB234614AC6A1E7FA130EC22ACB3369@HE1PR0401MB2346.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:335;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	N/Ek+vfH/0TllQaavT3GjyGex+VPUIYXanWvBzgqMK0iW6xOT1Wu/3iJEb4DhuCL5OjD25+uurB7l4B5HzRre5KHU46Jx2Gig+Qro/CT5cDqKLE3rxUNgjC/I37nl7MlqnSAYJIHUvMgMn3tW7NHZuFh3LnHMoi+MGBwVpXMrfQd0QkyO4zyqYBLkKdNFCx+hMp8kE6ef1GJ6wFx1Apph6BbPf6KVcIRfbmDx22zU+hC+Q9Xa49jJdzQi8w2vJ65U2ODD6Tj06jrxkiVSt7e6YX/TMK0BqrLGwtidgupfVgbuPQ7WqAo/9AUV1Nc2kzl6XgINH1z5ia2EZJsAtrdg6B/WieyyE6OlXdtago0egoyFkM2YTRpgffEP+5K9brqiWA9GRviReX8B9pO42k6meVZzaW1R9z/uFf1btOMirXXh23jc1NuHVc5oq5Yu3U0fF7HSvAHfSzEW3hgce6NQ74SIf1/Np8Uhmksj0jxXiaIh3zezeJGn6h/oKU8KQgJfr9SvyAVv32mwJVQXb/u0ZXHu811sutD14hX9RWyPlAe8DeJ3VhWFNrD9Jaig3Cs+RUgrEMi/X5rysAM3pwnzz0KGX24/+P8qzafYDp6vCg6STdt6auVdopRbM1TunzuHedwMFN2g/zBv/AdoZ+9kKJgWXae0SF8LTfLgR3kT8a+n0i1f3WzQU4D4s9HEI2efOPCwVlB8kPoAlw+IvLnwLB/BUTzASj9YfFFIdkrkDk=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(316002)(6916009)(31686004)(54906003)(38100700002)(83380400001)(8936002)(5660300002)(2616005)(186003)(6506007)(26005)(508600001)(31696002)(6512007)(86362001)(8676002)(6486002)(4326008)(36756003)(66476007)(53546011)(2906002)(66946007)(66556008)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?rgyE6f4FtaKBEMvDOTuKwP79urvYxWPURynpM0UaAfn2UCJq9xvALDA6FO92?=
 =?us-ascii?Q?GFUlIMuEe3Xk8Zow3/rUH7blpVy2cB2Vrfi/S31zsk/fKzF52YaF3djYjszz?=
 =?us-ascii?Q?WKfzZAvDUKDu8H1TOze/zvoG3XHzdNRNN3vhVoVFDs6zkLEYTrVk4FXQr6qM?=
 =?us-ascii?Q?FwfUtHM6IHMVS9sIQGhWj3FDBL8fjHogC9Jxsdy9PdsSqtvlwxF1ojjrEmZw?=
 =?us-ascii?Q?hhkP8rSy3AWtTmmnlW/R1l0zinHqtl8lrMvK4gsa+XZ6HLLyxi67n69Kq6ZY?=
 =?us-ascii?Q?bEXLLnuXNIKWn5y/x2nH5cxhFb25wrzA6VabfEyeu/Z6XOuB2phJBYqQcNB8?=
 =?us-ascii?Q?KWa2qR4X7iqHVnLZXmvFQh0YM2C7h3kPB/FyoswfkXF3D5I1djWdmcqi1Hk9?=
 =?us-ascii?Q?251OEwhh+VuVFYrX5tOO2Lq/rbTZi0naW2kgkLM+ogcn/+D6HMvyzE0DcgrI?=
 =?us-ascii?Q?I4ZfJMqcpHXOHyob207MoQPbsEKDj4EENKmQlAgR9J7yBpMcD9v9ZVCB5Wh7?=
 =?us-ascii?Q?r4q6auAHtvnRdtxNyF7LRiHFay8U8oUuZkaGYUOqSFTrIY2P5fiBb+tGLkmp?=
 =?us-ascii?Q?uy9ICNJz1koG2wZjdF5XQX3CNCC8XGivP180b77UafiinOCDg9HnwLmjjQqg?=
 =?us-ascii?Q?3QWqCtiHq8DSaddnUXOOZGBMR22DXWF0hg4+qFiwp2d/Y+JLb9RhknIaofdd?=
 =?us-ascii?Q?VKKEASd9dFoif3MzQ0XmM5UCHsqMvLy6HLFhP9VJVR1Uv53OvPYmElM0GozG?=
 =?us-ascii?Q?+3nFw2XHK/GQl3Gsjhz5xL9a35Ii6h169McIxx/WPnsOBd7Q6bb3Z1DKVRD2?=
 =?us-ascii?Q?omEKyv3Z77er9USVOaX/Z/9MIP0bnLHoMRSwtFAqLdyBASy/nkRI+FNyfZJo?=
 =?us-ascii?Q?lW4wdHNjzn4LnZnjWjOF5w/XvS3GZj21X+oOTdukIluM0O8dvvwhmz8E6MeL?=
 =?us-ascii?Q?L3RXuqqvP7aKK11t6HpkodUD1zxpuutQx/vcRqvqpp1UsDCUdZl4RVBTzndF?=
 =?us-ascii?Q?5PDQ4VzjVRx77KkGB6CYWgETrpzdJW7DDnLwk3f8/YQlAHhfktnq/PCckyxD?=
 =?us-ascii?Q?DlKstxLvpPHNs0/4zpxIzCterrCSlwu54gI0oEQnKcONnuzeGaefhBgorpYI?=
 =?us-ascii?Q?/SRwBlLRYXVBuYmNyofXpFEqVqTLBBdIdvlBG2wxmx380tFsd9FAIwgMHz7K?=
 =?us-ascii?Q?lbParrUIDHXegGmBBofBxg+ACJID1RXj+DBrCLfz/DFe+O2ppk+zBB2Wg2oA?=
 =?us-ascii?Q?wiBGoM9ueb3ArEGi1AxTEDQ67E0ra9jR9zFeHO/QveB21JCqxs+U2XoT2NcS?=
 =?us-ascii?Q?DlUoN/sxCZ4umURAXSeIs2fHXqna2DqFupU3y/NKu0tpJqSRoDz/lgt/NaxK?=
 =?us-ascii?Q?UbngtqfooGyZlM7kG/sd/WhDjNMXamCXcAVyoJdQ2Kbgj4RyyMS40ZGlRW6I?=
 =?us-ascii?Q?nxusc/0gIlQiArOWFsgkmK7z28xUG0eikUHJM4bfsrmI2ZQfDV0erOTbSkrK?=
 =?us-ascii?Q?YEXxWQWS9xH6O+e3q94eEo2okGvgQhLxYMNoQStM5ANBNVK6moaoBPt0ga+E?=
 =?us-ascii?Q?VJCNEOsKoUIYWBb/u8vcKcO6A6H9viaVwTiEoaRDUUMGPYzzb4ccxJWkq+XK?=
 =?us-ascii?Q?SCCIZRnN1b5nFHJU/E37uCc=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9e9744da-4596-4ff8-6685-08d9f2234fc2
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2022 14:39:32.8053
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aIs6QBlRwAdh8mTEPyla3SAem7GI5dl6fd2sO5URik739pzCVu2MUp8SEZ3rGeXS+97w19QvvJl/jplUAWkrxA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0401MB2346

On 17.02.2022 13:07, Roger Pau Monn=C3=A9 wrote:
> On Thu, Feb 17, 2022 at 12:54:57PM +0100, Jan Beulich wrote:
>> On 17.02.2022 09:28, Roger Pau Monne wrote:
>>> Process softirqs while printing end of boot warnings. Each warning can
>>> be several lines long, and on slow consoles printing multiple ones
>>> without processing softirqs can result in the watchdog triggering:
>>>
>>> (XEN) [   22.277806] **************************************************=
*
>>> (XEN) [   22.417802] WARNING: CONSOLE OUTPUT IS SYNCHRONOUS
>>> (XEN) [   22.556029] This option is intended to aid debugging of Xen by=
 ensuring
>>> (XEN) [   22.696802] that all output is synchronously delivered on the =
serial line.
>>> (XEN) [   22.838024] However it can introduce SIGNIFICANT latencies and=
 affect
>>> (XEN) [   22.978710] timekeeping. It is NOT recommended for production =
use!
>>> (XEN) [   23.119066] **************************************************=
*
>>> (XEN) [   23.258865] Booted on L1TF-vulnerable hardware with SMT/Hypert=
hreading
>>> (XEN) [   23.399560] enabled.  Please assess your configuration and cho=
ose an
>>> (XEN) [   23.539925] explicit 'smt=3D<bool>' setting.  See XSA-273.
>>> (XEN) [   23.678860] **************************************************=
*
>>> (XEN) [   23.818492] Booted on MLPDS/MFBDS-vulnerable hardware with SMT=
/Hyperthreading
>>> (XEN) [   23.959811] enabled.  Mitigations will not be fully effective.=
  Please
>>> (XEN) [   24.100396] choose an explicit smt=3D<bool> setting.  See XSA-=
297.
>>> (XEN) [   24.240254] *************************************************(=
XEN) [   24.247302] Watchdog timer detects that CPU0 is stuck!
>>> (XEN) [   24.386785] ----[ Xen-4.17-unstable  x86_64  debug=3Dy  Tainte=
d:   C    ]----
>>> (XEN) [   24.527874] CPU:    0
>>> (XEN) [   24.662422] RIP:    e008:[<ffff82d04025b84a>] drivers/char/ns1=
6550.c#ns16550_tx_ready+0x3a/0x90
>>>
>>> Fixes: ee3fd57acd ('xen: add warning infrastructure')
>>> Signed-off-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>
>>> ---
>>>  xen/common/warning.c | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/xen/common/warning.c b/xen/common/warning.c
>>> index 0269c6715c..e6e1404baf 100644
>>> --- a/xen/common/warning.c
>>> +++ b/xen/common/warning.c
>>> @@ -30,6 +30,7 @@ void __init warning_print(void)
>>>      {
>>>          printk("%s", warnings[i]);
>>>          printk("***************************************************\n"=
);
>>> +        process_pending_softirqs();
>>>      }
>>
>> To be honest, I'm not convinced. This gets us pretty close to needing
>> to process softirqs after _every_ line of output. If a console is this
>> slow, the problem imo needs dealing with there (and according to irc
>> we appear on a helpful track there already), not by sprinkling more
>> process_pending_softirqs() all over the code.
>=20
> There could be up to 20 warning messages of unknown length, so I do
> think we need some processing of softirqs in the loop.

Hmm, yes, you have a point there.

> If you prefer I could do softirq processing only every 4? messages,
> but I'm not sure it's worth it. Also there's no indication of the
> length of messages, so IMO it's safer to just process softirqs after
> each.

No, that's indeed not worth it.

Acked-by: Jan Beulich <jbeulich@suse.com>

Jan



From xen-devel-bounces@lists.xenproject.org Thu Feb 17 14:48:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 17 Feb 2022 14:48:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274819.470411 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKi4m-0004Wb-Tt; Thu, 17 Feb 2022 14:48:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274819.470411; Thu, 17 Feb 2022 14:48:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKi4m-0004WU-Pi; Thu, 17 Feb 2022 14:48:08 +0000
Received: by outflank-mailman (input) for mailman id 274819;
 Thu, 17 Feb 2022 14:48:06 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=A/h9=TA=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nKi4k-0004WO-PF
 for xen-devel@lists.xenproject.org; Thu, 17 Feb 2022 14:48:06 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9be86b9c-9000-11ec-8eb8-a37418f5ba1a;
 Thu, 17 Feb 2022 15:48:05 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9be86b9c-9000-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645109285;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=qTZcx9WChNVhjJksKTzip/5ECScls2qgeTSJAOMca68=;
  b=OehSZBBv4pnv0FKdp7E51zZ9AKlYFY33+L7ZahkQc78GEb2QVINBEoer
   LDsOwKviWFho1Fare8AOvbMNI899IIS/nMSSKfWFEKlYnniB+mM0IXBj5
   2JdiNHwCh4OaXq/thloT33A3Z2LZe3d4NOvUjfcJuxDlzb314Bzu3sX1x
   g=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: p94FuqK+HroUFxlkoGf/bN63jWBua20z89OExIIt26g9S9xmsswk0+uYek/G7Lts8Qj3pOAXcH
 sUX/jbkx0Ie0pw41szjDQwCRRdQlhq30ikqsRMpYh57nV1YD1/aVhRNK7wWB2nXwst8AnzY2m9
 frEJuJPotNiVXPCf3KXz4L76p9VxCH+Aj4FHtMVc4cbE19r9FRP+ogcYd7n6vG+kmM2hYCmN4n
 plDitHapJ+EfY3cLo7YzRs49AGOPYAIHry6tVSexBqBgsj+q9LQTCQGHUGk9OSNgiLFI2iQ65f
 Sawcdn414lKR52dvuxNQBr6h
X-SBRS: 5.1
X-MesageID: 64333349
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:a3ziiqlJj4xUKg/fUhuIyQDo5gxdIURdPkR7XQ2eYbSJt1+Wr1Gzt
 xIeUDqCOqvfZmr2Lt5zaovi8h5Uu57UmtdhGgc5pSo8QyMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BClVlxJVF/fngqoDUUYYoAQgsA180IMsdoUg7wbRh2Nc32YLR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 Nhok8yUc0RqB5PzkegRYyhiSRh3GbITrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBNPsM44F/Glp0BnSDOo8QICFSKLPjTNd9Gls3ZsVRqqPD
 yYfQSJgfAzkURcTBlMKNo4Hp8SWqCjbXjIN/Tp5ooJoujOOnWSdyoPFL979atGMA8JPkS6wt
 m/Aumj0HBweHNie0iaetGKhgPfVmiH2U55UE6e3ntZoilCOwm0YCDUNSEC25/K+jyaDt8l3c
 hJOvHB09O5rqRLtHoKVswCETGCsszs6C/5qUK4D1j6Exqbk0jzDP2EgUWsUADA5j/MeSTsv3
 16PutrmAz1zrbGYIU6gGqeoQSCaYnZMczJbDcMQZU5cuoS4/tlv5v7aZos7SMaIYsvJ9SYcK
 txghAw3nP0tgMECzM1XFniX0mv39vAlouPYjzg7v15JDCslNeZJhKTysDA3CMqsyq7DETFtW
 1BexqCjABgmV83lqcB0aLxl8EuVz/iEKibAplVkAoMs8T+gk1b6I9wNuGohehs0aZlZEdMMX
 KM1kVkOjHO0FCH3BZKbnqrrU5h6pUQePY+Nug/ogipmPcEqKV7vENBGbk+MxWH9+HXAYolkU
 ap3hf2EVC5AYYw+lWLeb75EjdcDm3BvrUuOFMuT50n2jtKjiIu9FO5t3K2mNbtisstpYWz9r
 r5iCid9404OCrKgPHiMoNV7wJJjBSFTOK0aYvd/L4arCgFnBHsgG7nWx7YgcJZihKNbiqHD+
 XTVZ6OS4ACXaaTvJVrYZ3Z9RqnoWJoj/3s3MTZ1ZQSj2mQ5YJbp56AaLsNlcb4i/e1l7Ph1U
 /haJJnQXqUREmzKq2YHcJ3wjI1+bxD31wiACDWoPWokdJl6Sg2XptK9Jlnz9DMDBzacvNclp
 +HyzRvSRJcOHlwwDMvfZP+14Um2uHwRxLB7U0fSe4EBc0Tw6ol6bSf2i6Zvcc0LLBzCwBqc1
 hqXXkhE9bWc/ddt/YCQ166eroqvH+9vJWZgHjHWveSsKC3X3mu/2oscAuyGSi/QCTHv86K4a
 OQLk/ylaK8bnExHupZXGqpwyf5s/MPmorJXw1g2HHjPaFj3WLpsLmPfgJtKv6xJgLRYpRG3S
 gSE/dwDYeeFP8bsEVgwIgs5b7vciaFIy2eKtfllcl/n4CJX/aacVRQANhaBvyVRMb9pPd532
 uwmosMXt1SyhxdC3gxqVcyIG7Bg9kA9bpg=
IronPort-HdrOrdr: A9a23:cNZa1KrCyAGjkPZ3OR/uJAYaV5vJL9V00zEX/kB9WHVpm5Oj+P
 xGzc526farslsssREb+OxpOMG7MBThHLpOkPMs1NaZLXLbUQ6TQr2KgrGSoQEIdxeOk9K1kJ
 0QDpSWa+eAc2SS7/yKmTVQeuxIqLLskNHKuQ6d9QYUcegDUdAe0+4TMHf8LqQZfngjOXJvf6
 Dsmvav6gDQMUg/X4CePD0oTuLDr9rEmNbPZgMHPQcu7E2rgSmz4LD3PhCE1lNGOgk/i4sKwC
 zgqUjU96+ju/a0xlv10HLS1Y1fnJ/ExsFYDMKBp8AJInHHixquZq5mR7qe1QpF692H2RIPqp
 3hsh0gN8N85zf4eXy0mwLk303a3DMn+xbZuCilqEqmhfa8aCMxCsJHi44cWADe8VAcsNZ117
 8O936FtrJMZCmw0xjV1pztbVVHh0C0qX0tnao4lHpES7YTb7dXsMg24F5VKpEdByj3gbpXXN
 WGNPuspcq+TGnqL0ww5gJUsZ+RtzUIb1q7q3E5y4KoO2M8pgE686MarPZv6kvouqhNDqWs3N
 60QpiAoos+O/P+XZgNddvpfvHHeVAlYSi8Rl56cm6XXZ3uBRr22uzKCfMOlaWXRKA=
X-IronPort-AV: E=Sophos;i="5.88,376,1635220800"; 
   d="scan'208";a="64333349"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=VjE0LLfW8ICVX77NgSmcsEyqUw6jqNefxMpJGfSg4mPog4Ypm3bk4EigptwrvWDr8w4kgzbWcAkEUc0NwF7Us/r4etnh2HyGYjXePWimklizZ4lj8lPXiULzWNloem46uF20/m78rHPalMpMZU/RxaK+H0A8C6YLw5dgjWvpXqFmndHJlb5TuPA9qZ5SrL9StoUPSw4HyDf2GepvfTlXcK0+aAquWoCskmqfG+LmtuUyvvLH+jRCCkbSvqCw+q4BhL3M16Mvn+CxG01wCsSnIR51hmu02iYThE2neAm2dbp5qsnJUlEvR9EylRcz44mPsCyzs1eceo0tsvNRi2FLGA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=FULfcuiL5IXvaRBgERreSKtuIFIoX2cUBj9wvMWN0OI=;
 b=moFS/zt+v1aDq+JdC0TI4Zh3fP5la4ako2ESumJaBAn7BhU8SN8Qrf6GcpPl9qRX8Lca8WnRUfckq5VzYUe9Uj9ZiKLi8D4wdN7E7Y7mp/gwNQwmt3WYJUNlnGRxX96R3vvdkwgBkdAh2va0OLvxWn1IyYxhuw88m8HFcVM8U+aOSoHIb1iM6POSa61iNxPG7M53ObrpIKB2mTmaCuVBq173/QDKXNbCvNzzCzWgNldLHRtctmnJqVRQHlpy7Efvr/droiGiTwdVuLdLEq7etYw8lxjbwC56OLFmnKsmYyTGX1xQuEosfH1wkaes/EAw1tMPEft6V0OTEN80LwCuEA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=FULfcuiL5IXvaRBgERreSKtuIFIoX2cUBj9wvMWN0OI=;
 b=NBCsCCmJ73K0zzzELTua+3nW6lovqUD4fxXqI6QeLg0BlHyhpiGbkSVUyBzEzW5QgnteCr1agZHDvH4aG5Qcn1Kl56TFBvhvmknBurRZtkeBqek4e8+ZQj54is0n4rQ2LQsEFPlIbhsNwl6fGv+w096I9YeotCPRrnnCpPZxXrA=
Date: Thu, 17 Feb 2022 15:47:53 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH RESEND v2] x86: introduce ioremap_wc()
Message-ID: <Yg5gGenFpAwZqtSW@Air-de-Roger>
References: <8f56a8f4-0482-932f-96a9-c791bebb4610@suse.com>
 <c56aadc8-e568-4625-5d6f-bd2b8981f3ae@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <c56aadc8-e568-4625-5d6f-bd2b8981f3ae@suse.com>
X-ClientProxiedBy: LNXP123CA0018.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:d2::30) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: cbded9e6-ab19-49f4-238e-08d9f2247dc3
X-MS-TrafficTypeDiagnostic: BN7PR03MB3489:EE_
X-Microsoft-Antispam-PRVS: <BN7PR03MB3489C60B44ED78258052C9088F369@BN7PR03MB3489.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: GjnGSco/hmrwFs/dNQ6B1tioJJVeAZPK7XL07f4RpGsJn/YLRqgQ1szlgfX2u14srxrNpifYTpeK/4MHkQBDnaRNa+Zu1+g9WEOFZjfei8gwbG5JbAX3LG4tBQ3rfwqHWXuIFtk+DEVn5WVkxxoFlzQuAjiDEd/KSEh5NEVZGbpG5zsIPFDUAee1ipu+lzu3LFuCLBEJQVYCHut9o7Q57Io6uWYuJTP3ztQA9Fb9UqAJ/EK1c835FlSVWIfTOEfKM2V1Esg7H+fsRi45IPg6PIRefo7geNYtAiU+H0Abq3F5sCDq0hyD2R77M7ziRXKMYxcA7yQEX/nImQ74/3M6GCKSz4rtqDlYjLYB0sKmo894w0ouaVMuWpyDZfJZLZjxKHNzqO4xN8Vf5AdX79zQKJb3grU3EJ+dc9MPa6nUij+TCGDbRlRFXd4TZiDOFjAkk/dppgSfv5Pe5olbhYmDUVchhJYrGqobcs4VIGKzz/CyGoFb0TTyUIsecUL2Cv69ond8uyqMIoUMqCsaq6pJju3DoCdjxoPbi+SfXF/Vz3BRm73KZXNtEdjN5pU5Z+Oc9nViOdyFw7tRXorEyRrzKQOCbaKopp7dyzn6zVfgZL0UE4xhkFGv3UgWtv/xc6EWtDZoY+d+WpwLZVUy+w9Ylu6BeAn8TE6XQPAv7ANL2Z9yBwkfE6/JO/rlfERHK+O8cmNLyxHzxv55zyuFG+l+2Q==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(38100700002)(86362001)(82960400001)(2906002)(8936002)(5660300002)(508600001)(85182001)(186003)(26005)(33716001)(6506007)(6666004)(6916009)(316002)(54906003)(6512007)(9686003)(66946007)(66476007)(66556008)(83380400001)(8676002)(6486002)(4326008)(473944003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dDhuT3FoNDhjWExPZndaQTVTR2ExL1poWUJlYVFlaEZrbmhqWDBNTVkrWFds?=
 =?utf-8?B?Y0JGdnEzSE1QTWRXRUwvMERGbGtDVE9nUjRxc01yUmRnb25uekIyMmdtWnhR?=
 =?utf-8?B?SmFlTU9Uby9VYnJZNlBKVGxWTU4rNkh1MWg1TFkwbEFyV0FsMllJYjFwZ01m?=
 =?utf-8?B?RFpwZXFKYlNiOXUrVWw4WWxhM1hMcVloNDhiYnV6aXRxZVREcWMxRWJwTnlS?=
 =?utf-8?B?SDhXejFzOVYxZDRmd0ltUUwvd1ZZWWJTVEc3V0NxK1BKSkU1aDVva28yY0pI?=
 =?utf-8?B?SEM5TWkzaUM3NGk0OHhSYmMvS0ltUmRQK2JzNVZpRHdqVEtYQlNlY0VzeS94?=
 =?utf-8?B?TjZlb3E3Z0VzL3RodjdwZGtxZXdyRGJ1ckpkbEVHd2pyVlM5MGkrejZlUDZZ?=
 =?utf-8?B?L0hMV0wxdm9FT291V05aQzVFbFdUcENGekZOL042TnFpYkZqeEJvWWRqRkJ4?=
 =?utf-8?B?L0VmLyt3SHdJaVRudU5lYU03NnBINkpEUTRmdWFDTW9xM1pXK0ZJVGVpMzdh?=
 =?utf-8?B?ajI1SjQvcTlVdmVhdURHZ0N4U3paSGJoY0NQVEEvQUxISERoMGJvUEN6c0l1?=
 =?utf-8?B?NW8rMEx4WTArYjdCNEx0K1VlK0Nyc29LMzBTdTA1V3poNkp3blBGbldBM0lE?=
 =?utf-8?B?NjlINVp6U0U4c1dYL3EwMGxLUWJhZFlmNnhGUjRGSlNkNVh5OHBzWFd0V0hF?=
 =?utf-8?B?MWRyVzhJSXJPbnFpY3J2YlN6UUgvSWJqTzh2aThDWTJBM3kzbnNpNHl1emhP?=
 =?utf-8?B?VVhoWmQ3QXRmdEQyOGI2bDdvQi9KaFk5eWVudHNraVUwQnZQTWE2ZExWR2dQ?=
 =?utf-8?B?ZSs1TWxyNkpoelViUW0rNFVHQWN4WUFEdHFhKzNXV2VUUUNOcXFEVndremVZ?=
 =?utf-8?B?SGs3YmJvTjgrYkFyNllJbU9yNzJKdGRLMGlod1VzVFk2SkhpQ1lGSERId25S?=
 =?utf-8?B?VzFzNUFFL09Za2h6QlRBZU9ObUNTcjFWZEp1YStjbE5EVDVHUVVhY3FYQ2Jw?=
 =?utf-8?B?UzhiTklabGVkMWdIb3BUWHJGY0xiZXJBcXVNRkU2WkZyNjBPMVpZd1dSR1pX?=
 =?utf-8?B?aWVGajRCRWRJNktUanhNVFNsU0IyU0wvTmM5eWVmMmpKUktSWGJWZDg1Q09U?=
 =?utf-8?B?Z0dvUVRSeFJOOE51Z2VmcVBKeGkxTlhCeDN2cGxjSUZtTHJmdkVKMlRZWWtn?=
 =?utf-8?B?emRkM1p4QVdJT3BOVkZ4aTlOcWFtTGRnSlpPNTZkMUhVV3hxR0xLdXBBVUV0?=
 =?utf-8?B?ank1N0xYaFJsNCs2eXlpM0tsYjRJWFRzRStYWXdUUjNuSStqK3dWdFRmVFg4?=
 =?utf-8?B?WkJWcytjVnNOQm5vdVNqMXRmU3ZtTnAvcXdTVHZOR2FtL29uN1pBQ05jRnBz?=
 =?utf-8?B?NFZiUHFDWTZudHBZamhpRmZrK0dyb3diNEEwUUw2aWJWTTZCVmFzdWxwT0Fk?=
 =?utf-8?B?VTl3RUlKWHFWSkk5TFJxYlErNGFoRnN6WUd1ZElsUU93L2JQbHFPOEUvMXJr?=
 =?utf-8?B?N3NKWFRDRjBDQjBwZzcvaisrK1BKYm9ZVWRoUTlwZkJoS0VFS0laRno2QUNw?=
 =?utf-8?B?L2NwdEJub2tMZXBzdnBOR1FzU1ZGc1JiM0dUVUYzZ2VUbkxHUXMybTlaSG9J?=
 =?utf-8?B?N3dLQzVqbDZhcktHQTdNYW9ELy9ST05KTkpOaWpwdUZIUHJuTlA5ZXRjWHEy?=
 =?utf-8?B?cldLWmVoRnQrVndiZ2hOTWhaNmE1c3pJVTU0Zy9rYXdEYmk5MWJDb0xtS2FK?=
 =?utf-8?B?ck9iZkpJaUM2REQzYTI5RHBZdGdWQ1lWdXRhVDVPaTZ3MzNaOWtMcnZXK3du?=
 =?utf-8?B?RTRaakZ4c1k1RDFSZDR2WlR2ZzBDWGRXMy9ubm1Hak1qWkcxRUFaN2E4aEJw?=
 =?utf-8?B?Mm1lL2xSNGFJcEdsdmRiU3RvU0h3S2VkelFvNlBBTW4zdzF4UWptUXZESUVW?=
 =?utf-8?B?K1VuVzdvelhiYTJzaDBENG40SFYyOGozL2ozQXNsNHJNWk43UTQrVkpBUlkx?=
 =?utf-8?B?N3VSOG1Da3hIOUZ4dlk1QlJYMUxLVXVhT2E3U284UmlYR3BYVUIrL01EdGVQ?=
 =?utf-8?B?aDBCbzRaOFNINTEvUW05eGpyT2FINHZ2UXJtREJ2MUNhMlZsYUd0RzJqSU41?=
 =?utf-8?B?aDVPWndJVmkvWE5PTXY1MTRwUHBqY1hkbFJ4eVpHMTZOdlBQMFZUakQyQUpB?=
 =?utf-8?Q?wdBB/WMUHg7MnFgmpqCUd6w=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: cbded9e6-ab19-49f4-238e-08d9f2247dc3
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2022 14:47:59.4652
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aJIblaTEZ3DVaklElc9yEBtIUE0W2j8tYaVPtjaZUGJ4SRYEzkNnTdWWQ75mJNYG4iwRpEgInwkRPFwVzPsO9w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB3489
X-OriginatorOrg: citrix.com

On Thu, Feb 17, 2022 at 12:01:08PM +0100, Jan Beulich wrote:
> In order for a to-be-introduced ERMS form of memcpy() to not regress
> boot performance on certain systems when video output is active, we
> first need to arrange for avoiding further dependency on firmware
> setting up MTRRs in a way we can actually further modify. On many
> systems, due to the continuously growing amounts of installed memory,
> MTRRs get configured with at least one huge WB range, and with MMIO
> ranges below 4Gb then forced to UC via overlapping MTRRs. mtrr_add(), as
> it is today, can't deal with such a setup. Hence on such systems we
> presently leave the frame buffer mapped UC, leading to significantly
> reduced performance when using REP STOSB / REP MOVSB.
> 
> On post-PentiumII hardware (i.e. any that's capable of running 64-bit
> code), an effective memory type of WC can be achieved without MTRRs, by
> simply referencing the respective PAT entry from the PTEs. While this
> will leave the switch to ERMS forms of memset() and memcpy() with
> largely unchanged performance, the change here on its own improves
> performance on affected systems quite significantly: Measuring just the
> individual affected memcpy() invocations yielded a speedup by a factor
> of over 250 on my initial (Skylake) test system. memset() isn't getting
> improved by as much there, but still by a factor of about 20.
> 
> While adding {__,}PAGE_HYPERVISOR_WC, also add {__,}PAGE_HYPERVISOR_WT
> to, at the very least, make clear what PTE flags this memory type uses.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> REPOST (in isolation) upon Roger's request. The header location change I
> don't really consider a "re-base".
> 
> v2: Mark ioremap_wc() __init.
> ---
> TBD: If the VGA range is WC in the fixed range MTRRs, reusing the low
>      1st Mb mapping (like ioremap() does) would be an option.
> 
> --- a/xen/arch/x86/include/asm/mm.h
> +++ b/xen/arch/x86/include/asm/mm.h
> @@ -602,6 +602,8 @@ void destroy_perdomain_mapping(struct do
>                                 unsigned int nr);
>  void free_perdomain_mappings(struct domain *);
>  
> +void __iomem *ioremap_wc(paddr_t, size_t);
> +
>  extern int memory_add(unsigned long spfn, unsigned long epfn, unsigned int pxm);
>  
>  void domain_set_alloc_bitsize(struct domain *d);
> --- a/xen/arch/x86/include/asm/page.h
> +++ b/xen/arch/x86/include/asm/page.h
> @@ -349,8 +349,10 @@ void efi_update_l4_pgtable(unsigned int
>  #define __PAGE_HYPERVISOR_RX      (_PAGE_PRESENT | _PAGE_ACCESSED)
>  #define __PAGE_HYPERVISOR         (__PAGE_HYPERVISOR_RX | \
>                                     _PAGE_DIRTY | _PAGE_RW)
> +#define __PAGE_HYPERVISOR_WT      (__PAGE_HYPERVISOR | _PAGE_PWT)
>  #define __PAGE_HYPERVISOR_UCMINUS (__PAGE_HYPERVISOR | _PAGE_PCD)
>  #define __PAGE_HYPERVISOR_UC      (__PAGE_HYPERVISOR | _PAGE_PCD | _PAGE_PWT)
> +#define __PAGE_HYPERVISOR_WC      (__PAGE_HYPERVISOR | _PAGE_PAT)
>  #define __PAGE_HYPERVISOR_SHSTK   (__PAGE_HYPERVISOR_RO | _PAGE_DIRTY)
>  
>  #define MAP_SMALL_PAGES _PAGE_AVAIL0 /* don't use superpages mappings */
> --- a/xen/arch/x86/include/asm/x86_64/page.h
> +++ b/xen/arch/x86/include/asm/x86_64/page.h
> @@ -152,6 +152,10 @@ static inline intpte_t put_pte_flags(uns
>                                   _PAGE_GLOBAL | _PAGE_NX)
>  #define PAGE_HYPERVISOR_UC      (__PAGE_HYPERVISOR_UC | \
>                                   _PAGE_GLOBAL | _PAGE_NX)
> +#define PAGE_HYPERVISOR_WC      (__PAGE_HYPERVISOR_WC | \
> +                                 _PAGE_GLOBAL | _PAGE_NX)
> +#define PAGE_HYPERVISOR_WT      (__PAGE_HYPERVISOR_WT | \
> +                                 _PAGE_GLOBAL | _PAGE_NX)
>  
>  #endif /* __X86_64_PAGE_H__ */
>  
> --- a/xen/arch/x86/mm.c
> +++ b/xen/arch/x86/mm.c
> @@ -5895,6 +5895,20 @@ void __iomem *ioremap(paddr_t pa, size_t
>      return (void __force __iomem *)va;
>  }
>  
> +void __iomem *__init ioremap_wc(paddr_t pa, size_t len)
> +{
> +    mfn_t mfn = _mfn(PFN_DOWN(pa));
> +    unsigned int offs = pa & (PAGE_SIZE - 1);
> +    unsigned int nr = PFN_UP(offs + len);
> +    void *va;
> +
> +    WARN_ON(page_is_ram_type(mfn_x(mfn), RAM_TYPE_CONVENTIONAL));
> +
> +    va = __vmap(&mfn, nr, 1, 1, PAGE_HYPERVISOR_WC, VMAP_DEFAULT);
> +
> +    return (void __force __iomem *)(va + offs);
> +}
> +
>  int create_perdomain_mapping(struct domain *d, unsigned long va,
>                               unsigned int nr, l1_pgentry_t **pl1tab,
>                               struct page_info **ppg)
> --- a/xen/drivers/video/vesa.c
> +++ b/xen/drivers/video/vesa.c
> @@ -9,9 +9,9 @@
>  #include <xen/param.h>
>  #include <xen/xmalloc.h>
>  #include <xen/kernel.h>
> +#include <xen/mm.h>
>  #include <xen/vga.h>
>  #include <asm/io.h>
> -#include <asm/page.h>
>  #include "font.h"
>  #include "lfb.h"
>  
> @@ -103,7 +103,7 @@ void __init vesa_init(void)
>      lfbp.text_columns = vlfb_info.width / font->width;
>      lfbp.text_rows = vlfb_info.height / font->height;
>  
> -    lfbp.lfb = lfb = ioremap(lfb_base(), vram_remap);
> +    lfbp.lfb = lfb = ioremap_wc(lfb_base(), vram_remap);
>      if ( !lfb )
>          return;
>  
> @@ -179,8 +179,7 @@ void __init vesa_mtrr_init(void)
>  
>  static void lfb_flush(void)
>  {
> -    if ( vesa_mtrr == 3 )
> -        __asm__ __volatile__ ("sfence" : : : "memory");
> +    __asm__ __volatile__ ("sfence" : : : "memory");

Now that the cache attribute is forced to WC using PAT don't we need
to drop vesa_mtrr_init and vesa_mtrr? The more that the option is
fully undocumented.

>  }
>  
>  void __init vesa_endboot(bool_t keep)
> --- a/xen/drivers/video/vga.c
> +++ b/xen/drivers/video/vga.c
> @@ -79,7 +79,7 @@ void __init video_init(void)
>      {
>      case XEN_VGATYPE_TEXT_MODE_3:
>          if ( page_is_ram_type(paddr_to_pfn(0xB8000), RAM_TYPE_CONVENTIONAL) ||
> -             ((video = ioremap(0xB8000, 0x8000)) == NULL) )
> +             ((video = ioremap_wc(0xB8000, 0x8000)) == NULL) )
>              return;
>          outw(0x200a, 0x3d4); /* disable cursor */
>          columns = vga_console_info.u.text_mode_3.columns;
> @@ -164,7 +164,11 @@ void __init video_endboot(void)
>      {
>      case XEN_VGATYPE_TEXT_MODE_3:
>          if ( !vgacon_keep )
> +        {
>              memset(video, 0, columns * lines * 2);
> +            iounmap(video);
> +            video = ZERO_BLOCK_PTR;
> +        }
>          break;
>      case XEN_VGATYPE_VESA_LFB:
>      case XEN_VGATYPE_EFI_LFB:

I think in vesa_endboot you also need to iounmap the framebuffer
iomem?

I would assume this was also required before your change, yet I'm not
finding any iounmap call that would do it.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Thu Feb 17 14:48:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 17 Feb 2022 14:48:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274820.470422 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKi4t-0004p4-B4; Thu, 17 Feb 2022 14:48:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274820.470422; Thu, 17 Feb 2022 14:48:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKi4t-0004ox-5j; Thu, 17 Feb 2022 14:48:15 +0000
Received: by outflank-mailman (input) for mailman id 274820;
 Thu, 17 Feb 2022 14:48:14 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=xzkl=TA=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nKi4s-0004nc-0y
 for xen-devel@lists.xenproject.org; Thu, 17 Feb 2022 14:48:14 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a12f85b0-9000-11ec-8723-dd0c611c5f35;
 Thu, 17 Feb 2022 15:48:12 +0100 (CET)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2055.outbound.protection.outlook.com [104.47.6.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-38-oOHM5BbPMASfYgp9SdqD5g-1; Thu, 17 Feb 2022 15:48:10 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by PAXPR04MB8864.eurprd04.prod.outlook.com (2603:10a6:102:20f::6)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.18; Thu, 17 Feb
 2022 14:48:09 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4995.016; Thu, 17 Feb 2022
 14:48:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a12f85b0-9000-11ec-8723-dd0c611c5f35
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645109291;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=yLRlS1TQ/0HLnf7Aekd8PRj8perQ1WT6n8g4YRBzASA=;
	b=lEU04fmds/8+lOhbYOWKtnk99kZCFphT8JCEYFh5BJMTvBaMywSzmRAl3/lGF86CFC6czH
	ll++uWgp/LdPVFk64vQRjLT6HVOQIv70To5eUTQ+jpl+M+Gjjy+NlIL0lNXHcbx/VvwQg9
	U+99VmfgH6ZeAoXQF/slZ8vXQ3RjyRc=
X-MC-Unique: oOHM5BbPMASfYgp9SdqD5g-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Bjw/wy57SjEIbTvYppBghIGPETI4q14qMZu/zigGF/per/AsPHBTky8eqnXvJBU4Vtj4tMcrESVP64XlTrL3jL5BF738kjy3PbENkwqhkL/fdllm6LIDQnceJL8NpX78qb1I5GFcjQa+dOhJhTc5UI/y6XDcQSpA20lZguSS1V85fWHuHZNR7EvZRjZWDW2vQZ258csMLuCH5kcV63BclbN43gM12QNOynRSXhzUO8cUFkB8HQZ+uXHia26kxunEiNRJKp/S7doa56Bjo8WMZTrber1FXh9RBV7LVeLK6XMtpce2rUtPiaqj2DhvixuN45NXyfu01Vu+6CzH9ifA2Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=SxmVAe6CICoHSnm34+hYUvosoelqWzQoX4FB/ctSxTY=;
 b=Ci6sqnX4w78JKnCi+Nv2plAyQQqUtXbKSKclyA+OZua8n280AlGlDIix/S6AJafDxa83R3ZuiEQw/pxInxIQpUU+NQ9LCQHaegY4BImW/PArpoZLlwWct9VkWN+zp6HeIl+agGGV6q7XZhRX3//9W3+JxFrTsnfWoWBWeCoN4NDfa374We6tLDNssWcHQNS+JiuzWtYBGJbApWfU2YZOmffJqgnbgbDdnyr+BpGd0tVfPVg2qjPclCT8tKjJdHqCTYDFhHgNvrGeGMMVvazX+rikZY3Rj6sHtiriFtMcy0ZF/Nk/ET8yDVil3HgGnRKMU2jcMqY6jcF7tRjALQJUkA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <e35ca83f-12ad-0c28-075b-82ff08b2bf1d@suse.com>
Date: Thu, 17 Feb 2022 15:48:07 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v2.1 6.5/70] x86/kexec: Annotate embedded data with ELF
 metadata
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
CC: Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
 <20220217100158.22402-1-andrew.cooper3@citrix.com>
 <4e9924f7-fdfa-c3c3-7b6c-e5cbe77ff9ac@suse.com>
 <826c97dd-dda9-b6c2-37bf-451354fcfde2@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <826c97dd-dda9-b6c2-37bf-451354fcfde2@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0117.eurprd06.prod.outlook.com
 (2603:10a6:20b:465::32) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: bbf6056b-db0c-4b88-16cc-08d9f2248386
X-MS-TrafficTypeDiagnostic: PAXPR04MB8864:EE_
X-Microsoft-Antispam-PRVS:
	<PAXPR04MB8864A8D244A916A799D2C890B3369@PAXPR04MB8864.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	QFiMW8CncciIJzKdZ7WcQAcCBVYG5nnm+dVggR5dn8bz7jdS+7XndFAhFrDoYU758nZDRz7uhdFyqPB6BlM2xrUvdli2rdEvCdb72ntqNzPaiQM1lMxRFaUQdzr1330D5+8BgPnLuhW3tP4CYgoIU8jCtn46mPopoJCqQmf9aUSw7TKynE1hL40VqeRFIGylimURg6oxJwQ4Sq6ak01cq9zfD/IihmKFkmxhTDomKEnF0pLci1oS3PpVtulpnxQT2lCIp4SfONsvjASilxwsWAoKFDFrms6qdL9t49MGDEiq1AArpJP00F7XlfZ7ObtJEzroH+2QExMPGSCDFzc3Nq8CB769TVXYgOaD79OednKhu4WZqLF6sLGKh5eZOd4FBZ1mG96Fi2wH49LeMOMT6x7D6nBllfLC/uNDHVjHGhPRaYlF4vgTkHTFdHHawKGkeVnVaJzPFze+RqMZK2ft2Solrmv+XuicpKKQI2Qu2bjKnz94siYyqpS2j9EhFHLVVVqpBWZ60GfVd51eeNsX8EGbjCAK68grUVvpB2pYL4zlBNp9MHEaJyERSLdTDk5iin5nXzs/mE9IoaqhandOz3MIV4ENAkiB0AsWeOas7BLoGALXyOJEu2szw//lYhPg04qSevIhTCFy+mj8nbR1i4KHqSasx4IBAQjp7kfQu4LlyJkLj3P8T5zE1HnLQAdRCueze3ARA79epZYbYfPF+OvVITOo6TGZYGzq4MaaglLBwz9I+23quuSGzkqiUavS
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(316002)(36756003)(2906002)(54906003)(6916009)(5660300002)(8936002)(86362001)(66476007)(31696002)(66556008)(4326008)(83380400001)(8676002)(31686004)(66946007)(186003)(53546011)(6506007)(2616005)(26005)(38100700002)(6512007)(508600001)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?6IoAarlnzAolgv+Mddguy5sWhIEYIL10Lg2SJmIUjdaQk8IniwfzWQOiK24l?=
 =?us-ascii?Q?jaGv5HaCNLLxT8rRqRh6uN4E9zqa2NHEivYS+4WgoeiMLG/JauheTiatoiL9?=
 =?us-ascii?Q?iguxhuntX499OswBZM6wsHfQi86cVjMv0taK57xAwIKgrJFGDebyVgYC+Ajx?=
 =?us-ascii?Q?9LhEBN7RzExMDyg1ja0awNO4dBDRgnZbCGvXD93GqOlFvFvFcY+6uGUMhULA?=
 =?us-ascii?Q?Mc7KHP6dIw0PIYxAklqFPyI2kmgdUjl32RYA23yz3NhJGja3U+1sn1RkkgJE?=
 =?us-ascii?Q?x6qGtS1L+p5qZoMSAXM9ARqSm5PWV0ykbR0NwXm6gX+5deaexg3tfaKJ0wrX?=
 =?us-ascii?Q?XsdAPDvmIY+WhflkOPYYHp5Yyn/4blRGBBYNfLJVaJyNWwxXeJShnOlx1BYT?=
 =?us-ascii?Q?ApB5Z3vEJlfrxDKcYe37ey1ODICVBkhwDaclJvVI9XE9cqrDT1CixNw/dQEc?=
 =?us-ascii?Q?7eGDZDjEaYj836rlEfOmNmfA/5FTT+x5PmQ2gXct84rm0SjUrA0VLPDdFF8m?=
 =?us-ascii?Q?daHAkANIEnlB+5Tc3ykaIe0ngyjYx1TF6x7J1sUeI1wsK7GgxAEoqdqW4Us6?=
 =?us-ascii?Q?8+QnyIhmeZpgaVxfKK63Ip/R3ZqCZghFxpjgCxdt7csunxivgHvQ6iNPeawN?=
 =?us-ascii?Q?280H30eXlHowzF2Q/IKRsexUmGOpkF6bbhsZGiTGfJsKKmPR8apT0Ela93Yg?=
 =?us-ascii?Q?FJKS+j5o0iWgC/eWLFUKEkEvJ9Dn7GqiP/LejMYjZ3yH0T8m2gU9pk5SY1+C?=
 =?us-ascii?Q?CISTMsP/Zrpf8Zp7XQU2W60/i3yN7TnoRmRFfMVp0Xk26Q6CW98u5BIPuwtS?=
 =?us-ascii?Q?7jBIvvUsX4oYUQKORzuPBKiEtL8fKh5C0sUvAifn+trdfUQduFH7jH5wzEiA?=
 =?us-ascii?Q?T7AEJGnimYSRQUUvOZIRj0UQsVDmh6jFz+POr70xMUbBIa1cKHo2Fo0egNy+?=
 =?us-ascii?Q?lZQipWqWUt/mSfWKcNlhF+gXP/cLKB86qiCn8UgOHzNLK1oe8kqVlBgHFDIm?=
 =?us-ascii?Q?NHJwKomiMK6MeSwbzno/4FxwLaLJkdec3+zEuYt1PAz1K7tcVRnxvgbHB6Zq?=
 =?us-ascii?Q?WO/yG27zJsxzlztB/IuCI+zO5ebhPFcXT8etDfdt+miQX3bMSBMnxxsRTAHC?=
 =?us-ascii?Q?PEN5UDlY2yDK7uLdlB/kKWSxezGYPmPDoUk+jH9k9+cR+7r65qWpTJYVJglQ?=
 =?us-ascii?Q?kIH+FeT0tJih4RCSrvDncjKlntNJCoyi+RA792Hc8yAvhkZhkicGQ6+/Q746?=
 =?us-ascii?Q?07/0EnOaCghb/TuRJfxj4canTsA6COpiulaWAi84xmyAGyxT3u+yGanJyl2Q?=
 =?us-ascii?Q?4fFr5wGo1Kbm5o4HUohh3tnrMMTlZ5RWouyOJLkSoMdzJRDbeiYxvWrikbtG?=
 =?us-ascii?Q?9szfK2WLH0El9t0oKmzPVlWSbw+wip8XxhQyIeevdrx6KLQ0Q0z6CdfGPRYF?=
 =?us-ascii?Q?h6RSdBD4wtNVWThEibglVah1iCurPPuEMHtOJ1SJoyS+G0IKhJGyVr74NwSI?=
 =?us-ascii?Q?vpJj3bDNTF8/JO95/IrvDWKgip9UJfF4+hGVj3PPFcmCtXwMbmwKC/2DdOLU?=
 =?us-ascii?Q?Cgt910dZmyC0yhnnyCeOMSi3+y0kTOw6xZGhD64mYNMVFuUmgkSBdNZkub5d?=
 =?us-ascii?Q?VHtGTfJovyE6PilOZQq09W8=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bbf6056b-db0c-4b88-16cc-08d9f2248386
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2022 14:48:09.0389
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gYxaMOXNCQOZrXYofmZOPBGAJAbRhMuMMM7pMRiRk2vPmNKcGepodGNB68CF/UtgUPxEHSrOw1FcVEEpkNa5qg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8864

On 17.02.2022 13:06, Andrew Cooper wrote:
> On 17/02/2022 10:42, Jan Beulich wrote:
>> On 17.02.2022 11:01, Andrew Cooper wrote:
>>> Scanning for embedded endbranch instructions involves parsing the .text
>>> disassembly.  Data in the kexec trampoline has no ELF metadata, so objd=
ump
>>> treats it as instructions and tries to disassemble.  Convert:
>>>
>>>   ffff82d040396108 <compatibility_mode_far>:
>> What about the (possible) padding ahead of this? Should the .align
>> there perhaps specify a filler character?
>=20
> What about it?=C2=A0 It's just long nops like all other padding in .text
>=20
> ffff82d040396101:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ff d5=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0 call=C2=A0=C2=A0 *%ebp
> ffff82d040396103:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 0f 0b=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0 ud2=C2=A0=C2=A0 =C2=A0
> ffff82d040396105:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 0f 1f 00=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0 nopl=C2=A0=C2=A0 (%eax)
>=20
> ffff82d040396108 <compatibility_mode_far>:
> ffff82d040396108:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 00 00 00 00 10
> 00=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ......
>=20
> And for this problem, we don't need to care about the behaviour of any
> pre-CET version of binutils.

I was about to ask, but yes - this is a good point.

Reviewed-by: Jan Beulich <jbeulich@suse.com>

>>>   ffff82d040396108:       00 00                   add    %al,(%rax)
>>>   ffff82d04039610a:       00 00                   add    %al,(%rax)
>>>   ffff82d04039610c:       10 00                   adc    %al,(%rax)
>>>
>>>   ffff82d04039610e <compat_mode_gdt_desc>:
>>>   ffff82d04039610e:       17                      (bad)
>>>           ...
>>>
>>>   ffff82d040396118 <compat_mode_gdt>:
>>>           ...
>>>   ffff82d040396120:       ff                      (bad)
>>>   ffff82d040396121:       ff 00                   incl   (%rax)
>>>   ffff82d040396123:       00 00                   add    %al,(%rax)
>>>   ffff82d040396125:       93                      xchg   %eax,%ebx
>>>   ffff82d040396126:       cf                      iret
>>>   ffff82d040396127:       00 ff                   add    %bh,%bh
>>>   ffff82d040396129:       ff 00                   incl   (%rax)
>>>   ffff82d04039612b:       00 00                   add    %al,(%rax)
>>>   ffff82d04039612d:       9b                      fwait
>>>   ffff82d04039612e:       cf                      iret
>>>           ...
>>>
>>>   ffff82d040396130 <compat_mode_idt>:
>>>           ...
>>>
>>>   ffff82d0403961b6 <kexec_reloc_size>:
>>>   ffff82d0403961b6:       b6 01                   mov    $0x1,%dh
>>>           ...
>>>
>>> to:
>>>
>>>   ffff82d040396108 <compatibility_mode_far>:
>>>   ffff82d040396108:       00 00 00 00 10 00                            =
   ......
>>>
>>>   ffff82d04039610e <compat_mode_gdt_desc>:
>>>   ffff82d04039610e:       17 00 00 00 00 00 00 00 00 00                =
   ..........
>>>
>>>   ffff82d040396118 <compat_mode_gdt>:
>>>           ...
>>>   ffff82d040396120:       ff ff 00 00 00 93 cf 00 ff ff 00 00 00 9b cf =
00 ................
>>>
>>>   ffff82d040396130 <compat_mode_idt>:
>>>   ffff82d040396130:       00 00 00 00 00 00                            =
   ......
>> With the .size directives added, can we rely on consistent (past,
>> present, and future) objcopy behavior for padding gaps?
>=20
> Of course not.=C2=A0 We don't know how things will develop in the future.=
=C2=A0
> The best we can do is hope that it doesn't change too much.
>=20
> But on that note, the way this would go wrong is the binary scan finding
> an endbr that wasn't disassembled properly here, for whatever reason.

True; it'll "just" be a false positive build failure.

>>  It just so
>> happens that there's no 4-byte gap between compat_mode_gdt_desc and
>> compat_mode_gdt. Changing the .align ahead of compatibility_mode_far
>> would eliminate the risk of padding appearing if the code further up
>> changed.
>=20
> Gaps will be formed of long nops because we're in .text, and they merge
> with the previous data blob (see below).
>=20
>>
>>>   ffff82d040396136 <reloc_stack>:
>>>           ...
>> Now this is particularly puzzling: Us setting %rsp to an unaligned
>> address is clearly not ABI-conforming. Since you're fiddling with
>> all of this already anyway, how about fixing this at the same time?
>> Of course there would then appear padding ahead of the stack, unless
>> the stack was moved up some.
>=20
> Oh - I'd not even noticed that.=C2=A0 Luckily there is no ABI which matte=
rs,
> because it's the call/push/pop's in this file alone.

And the entity transitioned to is forbidden to make use of our stack?

> With an align 8, we get:
>=20
> ffff82d0403a7138 <compat_mode_idt>:
> ffff82d0403a7138:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 00 00 00 00 00 00 6=
6
> 90=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0 ......f.
>=20
> ffff82d0403a7140 <reloc_stack>:
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ...
>=20
> where the 66 90 in compat_mode_idt is the padding.=C2=A0 Recall c/s 9fd18=
1540c7e6
>=20
>>> --- a/xen/arch/x86/xen.lds.S
>>> +++ b/xen/arch/x86/xen.lds.S
>>> @@ -87,6 +87,7 @@ SECTIONS
>>>         *(.text.unlikely)
>>>         *(.fixup)
>>>         *(.text.kexec)
>>> +       kexec_reloc_end =3D .;
>> Does this maybe want aligning on a 4- or even 8-byte boundary? If
>> so, imo preferably not here, but by adding a trailing .align in the
>> .S file.
>=20
> There's no special need for it to be aligned, and it is anyway as the
> stack is the last object in it.

You mean it anyway would be, if the stack was aligned? Or am I to imply
that you've amended the patch to add alignment there?

Jan



From xen-devel-bounces@lists.xenproject.org Thu Feb 17 14:52:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 17 Feb 2022 14:52:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274835.470433 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKi9O-0006Ys-Ts; Thu, 17 Feb 2022 14:52:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274835.470433; Thu, 17 Feb 2022 14:52:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKi9O-0006Yl-QD; Thu, 17 Feb 2022 14:52:54 +0000
Received: by outflank-mailman (input) for mailman id 274835;
 Thu, 17 Feb 2022 14:52:53 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mzVd=TA=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nKi9N-0006Yf-Cf
 for xen-devel@lists.xenproject.org; Thu, 17 Feb 2022 14:52:53 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4696ea34-9001-11ec-8eb8-a37418f5ba1a;
 Thu, 17 Feb 2022 15:52:51 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4696ea34-9001-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645109571;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=Tr4ULkFu1o+lZzc5YMuT3c2t8RcmQKwmSur4ak2We0o=;
  b=QkssGENMDfsIvWyvJnXa8bpROwdlRzs5AyN2UPjeuW02iDKe2Z2dPRbQ
   R8DQxcyxA6Te+O6CltBY7vmJrkuDtXccxkWqwyChn6DkhjypvxHVLQuWj
   ikAFnVoxHnJAVJLtgO8k3xFwanqHZJtP48tukZl9ICPPTJ8UVyGgleV2I
   o=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: lBTkOqFGFD+ObEvNJy0UneyyktmIazivQ5/YSeDK1KA+Eqy7qShmT/ZtoAQiaHltaY2tY7Wv8p
 XjO0RGQBhbuhbva/h5lp0DvvYLtW9y06DVz+FS8qRrPX91UzOoEPipOf2U+KfkKMGibor0H1KM
 NcRa23N4EwaE1cEF/GjhCmcQ0prd4KQjUl9H2wGqYIMb7keVWUpPuDDNfDWcLTIpctsJmIQcjD
 ocMQ9E2qlbDEoVG4NvWXnxLRpBaluiJ900Utr9IJTNrTFgN/Lt6yaEWxLHPEMsbyjdcWQ0eTHX
 NTl//i4RIL3Ato7S6q59jsTZ
X-SBRS: 5.1
X-MesageID: 64434574
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:AdtuIqiryZIHr8LIZcsdAgTkX161JxYKZh0ujC45NGQN5FlHY01je
 htvUD2FO/yNM2L9eIp+Po7k9U5SvJKAnd81GQU+/n82QyMb9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oAMKRCQ7InQLlbGILes1htZGEk0GE/NtTo5w7Rj2tQx3oDja++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /1o9r2rVh53L5bWgeoaeTxSEyFcDaFJreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHiOp8fvXdxiynUF/88TbjIQrnQ5M8e1zA17ixLNaiCO
 5FFNGUzBPjGSztkNHMKAo1ipbiHl0v6Vn5HhlWJo5NitgA/yyQuieOwYbI5YOeiX8JOlFyfo
 WHA1234BB8dL9GUjzGC9xqEnfTTlCn2XIYTEryQ9fNwhlCXgGsJB3U+TVKmpdGph0j4XMhQQ
 2QW9TAptrMa71GwQ5/2WBjQiHyZuh8RXfJAHut87xuCooLE7gDcCmUaQzppbN09qNRwVTEsz
 kWOnd7iGXpoqrL9YVWZ+7SPrDKFHC8UNm4PZCIaZQYd6tylq4Y25jrNRNt+FK++jvXuBCr9h
 TuNqUAWmLE7ncMNkaKh8jj6bymE/8aTCFRvv0OOAzzjvlgRiJOZi5KAzBv69ulZcpeiVECPu
 1IhkcieztACAsTY/MCSe9klELas7veDFTTTh19zApUsnwiQF26fkZN4u28nehowWioQUXqwO
 RKI51sNjHNGFCbyNcdKj5SN59PGJEQKPfDsTbjqY9VHefCdnyfXrXg1NSZ8M40A+XXAcJ3T2
 7/HIK5A7l5AUMyLKQZaoc9HjtfHIQhkmAvuqWjTlUjP7FZnTCf9pU05GFWPdPsly6iPvR/Y9
 d1SX+PTlUkCCLahPHWKqtFORbzvEZTdLcqpwyCwXrTeSjeK5Ul7U6OBqV/fU9cNc1tpehfgo
 SjmBx4wJKvXjnzbMwSaAk2Pm5u0NauTWUkTZHR2VX7xgiBLSd/2sM83KstmFZF6pbcL5aMlE
 JE4lzCoX60npsLvoG9GM/EQbeVKKXyWuO55F3H0OmdhIc87FlehFx2NVlKHyRTixxGf7aMWy
 4BMHCuCKXbabwg9XsvQdty1yFa94SoUlO5oBhOaKdhPYkT8toNtLnWp3PMwJsgNLzTFxyebi
 FnKUUtJ+7GVrt9n6sTNiICFs5ytT7l0EH1FEjSJ9r2xLyTboDaumNcSTOaScDnBf2ro46H+N
 /5NxvTxPaRfzlZHuoZxCZhxyqc664e9rrNW1F08Tn7Kc06qGvVrJXzfhZtDsahEx7l4vwqqW
 x3QpokGaOvRYM68SQwfPgsoaOiHxMo4oDiK4KRnOlj+6Q924KGDDRdYMS6ThXEPN7ByKo4kn
 7ss4ZZE9wylhxM2Gd+alSQIpX+UJ3kNXqh75JEXBIjn1lgixl1YOMGODyb35NeEaslWM1lsK
 TiR3fKQi7NZz0vEUnwyCXmSgrYN2cVQ4EhHnA0YOlCEutvZnftmjhRe/AM+QhlR0hgagfl4P
 XJmNhEtKKiDl9uyaBOvg4x499l9OSCk
IronPort-HdrOrdr: A9a23:GQrDDaDsgaHY57nlHegjsceALOsnbusQ8zAXPh9KJCC9I/bzqy
 nxpp8mPEfP+U4ssQIb6Ku90ci7MDjhHPtOjbX5Uo3SODUO1FHIEGgm1/qa/9SCIVy1ygc+79
 YGT0EWMrSZYjZHZITBkW+F+r0bsbq6GdWT9ILjJgBWPGNXgs9bjztRO0K+KAlbVQNGDZ02GN
 63/cxcvQetfnwRc4CSGmQFd/KrnayGqLvWJTo9QzI34giHij2lrJTgFQKD4xsYWzRThZ8/7G
 n+lRDj7KnLiYD19vac7R6c031loqqg9jJxPr3OtiHTEESvtu+cXvUhZ1RFhkFxnAjg0idvrD
 CGmWZbAy060QKtQojym2qh5+Co6kdT11byjVCfmnftusr/WXYzDNdAn5tQdl/D51Mnp8wU6t
 M844u1jesiMfr7plWL2zEIbWAbqmOk5X451eIDhX1WVoUTLLdXsIwE5UtQVJMNBjjz5owrGP
 RnSJi03ocfTXqKK3TC+mV/yt2lWXo+Wh+AX0gZo8SQlzxbhmpwwUcUzNEW2n0A6JU+QZ9Z4P
 msCNUgqJheCssNKa5tDuYIRsW6TmTLXBLXKWqXZU/qEakWUki93qIfII9Flt1CVKZ4sqfaqa
 6xI2+w71RCBH4GIff+raF2zg==
X-IronPort-AV: E=Sophos;i="5.88,376,1635220800"; 
   d="scan'208";a="64434574"
Date: Thu, 17 Feb 2022 14:52:44 +0000
From: Anthony PERARD <anthony.perard@citrix.com>
To: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Wei Liu
	<wl@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, Julien Grall
	<julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Nick Rosbrook
	<rosbrookn@ainfosec.com>, Juergen Gross <jgross@suse.com>, Paul Durrant
	<paul@xen.org>
Subject: Re: [RFC v2 6/8] tools/arm: Introduce force_assign_without_iommu
 option to xl.cfg
Message-ID: <Yg5hPMd86GOPt/ni@perard.uk.xensource.com>
References: <cover.1644341635.git.oleksii_moisieiev@epam.com>
 <d333126d12f2281f8df92e66cfba1c9eb2425dca.1644341635.git.oleksii_moisieiev@epam.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <d333126d12f2281f8df92e66cfba1c9eb2425dca.1644341635.git.oleksii_moisieiev@epam.com>

On Tue, Feb 08, 2022 at 06:00:12PM +0000, Oleksii Moisieiev wrote:
> If set, Xen is allowed to assign the devices even if they are not under
> IOMMU.
> Can be confugired from dom.cfg in the following format:
> force_assign_without_iommu = 1
> 
> This parameter has the same purpose as xen,force-assign-without-iommu
> property in dom0less archtecture.
> 
> Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@epam.com>
> ---
> diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl
> index 2a42da2f7d..1080966c33 100644
> --- a/tools/libs/light/libxl_types.idl
> +++ b/tools/libs/light/libxl_types.idl
> @@ -564,6 +564,7 @@ libxl_domain_build_info = Struct("domain_build_info",[
>      ("apic",             libxl_defbool),
>      ("dm_restrict",      libxl_defbool),
>      ("tee",              libxl_tee_type),
> +    ("force_assign_without_iommu", libxl_defbool),

As you are making changes to libxl's API, could you add a LIBXL_HAVE_*
macro in "tools/include/libxl.h", they are plenty of example there about
adding new fields in "libxl_domain_build_info".

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Thu Feb 17 15:02:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 17 Feb 2022 15:02:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274842.470444 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKiIy-00084i-Ro; Thu, 17 Feb 2022 15:02:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274842.470444; Thu, 17 Feb 2022 15:02:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKiIy-00084b-OR; Thu, 17 Feb 2022 15:02:48 +0000
Received: by outflank-mailman (input) for mailman id 274842;
 Thu, 17 Feb 2022 15:02:47 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=xzkl=TA=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nKiIx-00084V-Gq
 for xen-devel@lists.xenproject.org; Thu, 17 Feb 2022 15:02:47 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id aa2bb849-9002-11ec-8723-dd0c611c5f35;
 Thu, 17 Feb 2022 16:02:46 +0100 (CET)
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2052.outbound.protection.outlook.com [104.47.2.52]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-29-qICcIUNZNKiH-dR6lCqz6g-1; Thu, 17 Feb 2022 16:02:43 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM0PR04MB4979.eurprd04.prod.outlook.com (2603:10a6:208:c7::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.17; Thu, 17 Feb
 2022 15:02:41 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4995.016; Thu, 17 Feb 2022
 15:02:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: aa2bb849-9002-11ec-8723-dd0c611c5f35
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645109895;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=eyvb255NzLHiS7Bzf96OV8sjF9N9UsX1kY499I1qVoI=;
	b=Jlvp3DQjVC0vWz9zZg1mWAOldXCQeV80fDF7lIKJ8KRUIyG48hL+jnSLpJDMUTn113d6ET
	JxYjozLckcocUxA+H8ezpzruE8ntOmcBZrC6cDA4pATkqEN6evbmfxZsvd5eTndyg75xjc
	37P7T8en8ILTQqgBtStyFx/gkMq8PWU=
X-MC-Unique: qICcIUNZNKiH-dR6lCqz6g-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=iSDO59iOrHLw0U7HPfxVckdEhCl2Yo+i8Hbk3QSV294BN2Py8ZZ9uM+5JtNVUuV7Xo8WWZpbaOi1ctRJQgducjUt3LMrdyzNYfUTlv7lYdUQ7U34oNr9/P4eMezMO0qUwHogfnSJ+04M2CRJt7JIjMi7eT6IwMDKPr2j9Y+mZzvMcU2HR0jvcUcXHYtfDpWwLAEHCcW8RKjAYrM/4sDrqjy23LtYyBAw08Eqa5hcKkUBM6cwtCtAw/BcPw5wlqxgzZSAjGkF2DKwyPMMF2pp0TPFR59ww8H1d/m/ZE84CL7AizLQ9aRNO2U7HL1+ML7XG3ibxoLnVpmns6QbxA8W9g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=LpC1FcHME74XGsJB+ztRJkpzb0uREjKBdr4epQR6hKo=;
 b=VPJI9W2LcJtxoSowEwjIsvewlfWu2Us5+u9nlIyMKYUxxaUP93l6rA101U6B0gQzaBiwUZXuFdqpKcgyRVoFguHpNMOVpCTUyTUtOftw5RNY2azhuThvMaq4Tc2YiSANo5j6J0BcqjjQ0KbovIlOLZMhXbLExoRWGEigPtsKId5SUi3xfEIM0XjgMiHdhdQGGbNOltXhKNG+RZCbM5PoGN1mwAoduOd1JsZPigLwnhGoOvvLJKBUy6g8uflQz9xZVhcyoyoA2bx+Onbl07ISviU5EOJkDWRfT/qRiAjuOaDCTKsuBBFW64b8FqaCM6N/s7w70kbE129C/I6heliK2Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <34dac738-0631-f80c-a3db-7367e37ec0b9@suse.com>
Date: Thu, 17 Feb 2022 16:02:39 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH RESEND v2] x86: introduce ioremap_wc()
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
References: <8f56a8f4-0482-932f-96a9-c791bebb4610@suse.com>
 <c56aadc8-e568-4625-5d6f-bd2b8981f3ae@suse.com>
 <Yg5gGenFpAwZqtSW@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Yg5gGenFpAwZqtSW@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM5PR0602CA0023.eurprd06.prod.outlook.com
 (2603:10a6:203:a3::33) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 0d5e365d-d243-4594-9a23-08d9f2268ba2
X-MS-TrafficTypeDiagnostic: AM0PR04MB4979:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB49798D3C677AE49483A96458B3369@AM0PR04MB4979.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6790;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	1EMx1RckkiGNW9J0qICcQRArYykrUNSVqiSEqbmuO5drUZcDWqad2TT2OgfeJ3q8i5zxS7O3Lq91QoGPoaEOZIpDVbm5Bi1Cd6SJZh7HgFsoQ1mjThFVKK70shn/wYHw72eY5XFPAOQpSaMsKD9AKwYE9jq+/cFLjHiqJtaU+xObdPTuBpxyhCWqZ8ykC22pvuS6Fn5WcrX3H7fnz8E6FwP6+KIzb3AED0e9cfJG2GHFkCtKGa16VYy2zNRQXEjlkMbuN0IiTFNReQSBjQxsKqPT0mKtlzWkzP++YRKQ4klBhGatZyhpxUtBM22XIvyozKe4x9UOp1McuL/kz9Ol4GULhOvX/Gzrm2VnnfX0wXP7Cz211P7j50STsPCbPR/dqof3Kh+GEJGiHXoksoMDgR/PKSVQjpGQCcN4ykvDRuWay1AybaQqb/+SeCLiuRpWXI6IeHmHvkh6ck4P43qRpsyg0NAkfZJJpRS/RWN51KIh56JtGLTsPnLRVM3E5DkRPLJTIlvVQhM5J/8a+K75xttZrOtrKiyOQjc9S4N1pV7R9asV5WizH/vIAZcVadMepMkDNNwvGSLgbGWRI0vob3XUlfxxj5sK+e7c4EyTjLZzGFy1Cme07GYBvChrwM9bMrluLnEu5fF+xSyTedlBrFJW0YG3igxL09RBaRiz8mx7jy1fVyuJPlPvzcBs/O64NMwLktd4yxnHbiYpQH2/P3gbmn+idprjV4RZ2o3iWiiJjaA1aoqqSeCP/PX4OyUF
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(83380400001)(53546011)(6512007)(6506007)(6916009)(2616005)(26005)(186003)(36756003)(31686004)(86362001)(31696002)(38100700002)(2906002)(316002)(66476007)(8676002)(66556008)(54906003)(66946007)(4326008)(8936002)(5660300002)(6486002)(508600001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?nq8qJO2t1usBofeGYPskkEnTTkVbDCaO3ir+6YQ6ksU6/5dST66kM5FdZ02z?=
 =?us-ascii?Q?2ucyxxPoSsUNc65Jm9ENIEOg3LsBlpwlzS2Rp2CGOB+zkcTcPdZR8u/kc1d7?=
 =?us-ascii?Q?xaxAJNa+fQ9BAXXcDZTf3pqPjrn2JvxgD3aJgknuWZwCS1xnEN/yO4VAoWO/?=
 =?us-ascii?Q?D4xJT90+07hU5tJCR3AVeFiWAOF+3CBITAeoMMKgLpMvRNReH2PlAk/lPsgb?=
 =?us-ascii?Q?oMt27BYpPtWJjcsMGFW3Aqqism7sqEdF96xcPv4tRylEC8y3Veipb4uz3PPW?=
 =?us-ascii?Q?YA26iE8GBxrJHSJRb74Kj+RV8hL+5ssXMZQT+pFFfVKf0pC39hbOq7zGSuLC?=
 =?us-ascii?Q?9hj2e1k3ao0C4VQ/vcff+W6sPb5nmZqdXNUtiKx/3+1INwBcOa0e4PLqIMNc?=
 =?us-ascii?Q?nDRYlI3Qq1+K8usp0zd70AZdq36skkxnlZVVwbZ11xd4Vw4+adonM6XZSiXc?=
 =?us-ascii?Q?jDZjm1V1g7mAttdp+whwzffpylf392ABQZCCNi8N0XscG8jWpbciFeCspl0i?=
 =?us-ascii?Q?7rxuRHKruvlAvMUxze0pWr74Av4FtEI0bnvU96ZZiTWnDlSUkjCIcCus6cEY?=
 =?us-ascii?Q?/js+EKn2yBYVxa7TddblWn9xysVlSRqdQ7I+kAs/dd6UEV79QeL1YjWRH/+d?=
 =?us-ascii?Q?hdyrDPRjLXPxrH/BbOPy+yo38ZC556vZ3x6VRaktWb561TGc8mw8kZYaCRAs?=
 =?us-ascii?Q?8RoZLD7EFnm+hr98wK7RmMpV1RNpbsmwufHXh/l7I1GayAiGry0eMnQ5XECE?=
 =?us-ascii?Q?SJfNEU5G6f4U5Gfr/EB9zdDATO7EE//X8WwI2kQ8jaqXBzjb9OJonyQHklkw?=
 =?us-ascii?Q?QCcuvaFI+K79G1m6U/OT/kcV0VMzGa9kOviBKaV1r3j2jAMqRa9cm8mA6yIh?=
 =?us-ascii?Q?kBiHtB8NkT0tXvki0lKKKgRzRHXLd+3RGMgfaMDWkBS01VJFUvxJmGvu1gU7?=
 =?us-ascii?Q?J5DJNLXZMWyzgn/VRvNKBSPkJTj8phtSkpy6GREi88RDR8XMEbmZv5rZsepw?=
 =?us-ascii?Q?TvIYMk+4mr36Ae3qtF/DsoP7m5ZSfGXF3Uv4gKQ3EM4iC9O0sWRyPySM/TmX?=
 =?us-ascii?Q?qFbCg3bhqM7DiyFNWDwJykL0Z8r/3ylwAIV3POYeyuk7TfPzFSz/9HGhPXgp?=
 =?us-ascii?Q?sxVGJvLyJVHPkWC72HUkswbEruLs2rCcOhhgKqMPEr4NVV36nPDuGFK8to2M?=
 =?us-ascii?Q?F9Z00+NUhW4zyUroNmJ/b/l+L4xPNom74Y1cOVUC8u0/90WUG/P+af9aKRwr?=
 =?us-ascii?Q?6W19tDb05d4NZeTbWbLPv18DIH3Z7tMiG1JATz8BIuyM0q24CdPTgjwhn+qR?=
 =?us-ascii?Q?hUAAGoJ2EXfDoMzqJhYAk4d19zeQQHzxuUvgrUhqDFcw7+PCt3NRuBpOMWtb?=
 =?us-ascii?Q?nYJl6gvOUUcBNTm5W8xhIlFi5exGWau4mxiBMhAFYN4MaF3YvaWTZBHVdRxP?=
 =?us-ascii?Q?tr5AiZxqzM4ffiSoTkgThc4rR5Iy/pYgRbsk8k/eW7Ytqo8qOIIAkb1Kx3Wr?=
 =?us-ascii?Q?0dcGT84Ui0l2QxRBymH9tBD7g4QVvKGNnfY3LcBSnJtsu0UD8gPZfPI32cKO?=
 =?us-ascii?Q?BSnQzGYVPal1CXaZRc8pSNBcKbsAItJHezTKaNpIPdIbNEaGFHeh3+EI91jV?=
 =?us-ascii?Q?sZ9sEeWt2yqvprYsAXoYD64=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0d5e365d-d243-4594-9a23-08d9f2268ba2
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2022 15:02:41.6410
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Pp3CYkv1Mx1hppsWu55oyG8u4OhY0/w5izHyPS3JJ5yTWDZzpiT32tx5p8kVAQK3tBe5tl2YsrNRZupg3dEwEQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4979

On 17.02.2022 15:47, Roger Pau Monn=C3=A9 wrote:
> On Thu, Feb 17, 2022 at 12:01:08PM +0100, Jan Beulich wrote:
>> @@ -179,8 +179,7 @@ void __init vesa_mtrr_init(void)
>> =20
>>  static void lfb_flush(void)
>>  {
>> -    if ( vesa_mtrr =3D=3D 3 )
>> -        __asm__ __volatile__ ("sfence" : : : "memory");
>> +    __asm__ __volatile__ ("sfence" : : : "memory");
>=20
> Now that the cache attribute is forced to WC using PAT don't we need
> to drop vesa_mtrr_init and vesa_mtrr? The more that the option is
> fully undocumented.

Yes indeed. You did ask to re-send this patch in isolation. This removal
is part of the full series.

>> --- a/xen/drivers/video/vga.c
>> +++ b/xen/drivers/video/vga.c
>> @@ -79,7 +79,7 @@ void __init video_init(void)
>>      {
>>      case XEN_VGATYPE_TEXT_MODE_3:
>>          if ( page_is_ram_type(paddr_to_pfn(0xB8000), RAM_TYPE_CONVENTIO=
NAL) ||
>> -             ((video =3D ioremap(0xB8000, 0x8000)) =3D=3D NULL) )
>> +             ((video =3D ioremap_wc(0xB8000, 0x8000)) =3D=3D NULL) )
>>              return;
>>          outw(0x200a, 0x3d4); /* disable cursor */
>>          columns =3D vga_console_info.u.text_mode_3.columns;
>> @@ -164,7 +164,11 @@ void __init video_endboot(void)
>>      {
>>      case XEN_VGATYPE_TEXT_MODE_3:
>>          if ( !vgacon_keep )
>> +        {
>>              memset(video, 0, columns * lines * 2);
>> +            iounmap(video);
>> +            video =3D ZERO_BLOCK_PTR;
>> +        }
>>          break;
>>      case XEN_VGATYPE_VESA_LFB:
>>      case XEN_VGATYPE_EFI_LFB:
>=20
> I think in vesa_endboot you also need to iounmap the framebuffer
> iomem?

Again part of the full series. I guess I was a little inconsistent
with leaving the VGA unmap in here, but breaking out the VESA part.
It's been a long time, but I guess I did so because the VESA part
needs to touch two files.

> I would assume this was also required before your change, yet I'm not
> finding any iounmap call that would do it.

Indeed, this has been missing all the time.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Feb 17 15:20:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 17 Feb 2022 15:20:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274851.470455 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKiaI-00025e-GX; Thu, 17 Feb 2022 15:20:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274851.470455; Thu, 17 Feb 2022 15:20:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKiaI-00025X-DF; Thu, 17 Feb 2022 15:20:42 +0000
Received: by outflank-mailman (input) for mailman id 274851;
 Thu, 17 Feb 2022 15:20:40 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nKiaG-00025R-BC
 for xen-devel@lists.xenproject.org; Thu, 17 Feb 2022 15:20:40 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nKiaF-0007mN-6X; Thu, 17 Feb 2022 15:20:39 +0000
Received: from 54-240-197-231.amazon.com ([54.240.197.231] helo=[10.7.236.18])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nKiaE-0007EM-Vy; Thu, 17 Feb 2022 15:20:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=nDE20JAHrHiHzPhpUoZuugFZT0dSKEMJ/mHl8bG2ZnA=; b=O6/Q03THa/2sLXjmobKPbz6yrr
	ETDUYeEHncfrq3B/pPs/cdCScgKRbDmHQINB3ojS5KsKG2qwiYZtfSSDYHuIdyP57tQgH3/aIS6XK
	fLBPA/MgZsfNzyrPsK6GVrfuVO8nVmoCLoOM+hp9wD/CWnGyI1qNf7Uo+kl9RN/q5tMU=;
Message-ID: <ab6d8d13-30cf-d322-668e-f3f5aaa56824@xen.org>
Date: Thu, 17 Feb 2022 15:20:36 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.1
Subject: Re: [RFC v2 6/8] tools/arm: Introduce force_assign_without_iommu
 option to xl.cfg
To: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Wei Liu <wl@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Nick Rosbrook <rosbrookn@ainfosec.com>,
 Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 Paul Durrant <paul@xen.org>
References: <cover.1644341635.git.oleksii_moisieiev@epam.com>
 <d333126d12f2281f8df92e66cfba1c9eb2425dca.1644341635.git.oleksii_moisieiev@epam.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <d333126d12f2281f8df92e66cfba1c9eb2425dca.1644341635.git.oleksii_moisieiev@epam.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 08/02/2022 18:00, Oleksii Moisieiev wrote:
> If set, Xen is allowed to assign the devices even if they are not under
> IOMMU.

I think you mean "not protected by an IOMMU".

> Can be confugired from dom.cfg in the following format:

s/confugired/configured/

> force_assign_without_iommu = 1
> 
> This parameter has the same purpose as xen,force-assign-without-iommu
> property in dom0less archtecture.

s/archtecture/architecture/

> 
> Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@epam.com>
> ---
>   docs/man/xl.cfg.5.pod.in              |  9 +++++++++
>   tools/golang/xenlight/helpers.gen.go  |  5 +++++
>   tools/golang/xenlight/types.gen.go    |  1 +
>   tools/libs/light/libxl_arm.c          |  3 +++
>   tools/libs/light/libxl_types.idl      |  1 +
>   tools/xl/xl_parse.c                   |  3 +++
>   xen/common/domain.c                   |  2 +-
>   xen/drivers/passthrough/device_tree.c | 19 +++++++++++++++++--
>   xen/drivers/passthrough/iommu.c       |  5 ++++-
>   xen/include/public/domctl.h           |  5 ++++-
>   xen/include/xen/iommu.h               |  3 +++
>   11 files changed, 51 insertions(+), 5 deletions(-)
> 
> diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in
> index b98d161398..ddf82cb3bc 100644
> --- a/docs/man/xl.cfg.5.pod.in
> +++ b/docs/man/xl.cfg.5.pod.in
> @@ -1614,6 +1614,15 @@ This feature is a B<technology preview>.
>   
>   =back
>   
> +=over 4
> +
> +=item B<force_assign_without_iommu=BOOLEAN>
> +
> +If set, Xen allows to assign a devices even if it is not behind an IOMMU.
> +This renders your platform *unsafe* if the device is DMA-capable.

I agree this is going to be unsafe. But the more important bit here is 
this is not going to work because the guest has no way to translate a 
GFN to an MFN.

Your guest will need to be direct map to make it usable. So I would add 
that this will *not* work with DMA-capable devices.

Also, can you explain in the commit message why you want to allow this 
setup?

>       xlu_cfg_get_defbool(config, "xend_suspend_evtchn_compat",
> diff --git a/xen/common/domain.c b/xen/common/domain.c
> index 093bb4403f..f1f19bf711 100644
> --- a/xen/common/domain.c
> +++ b/xen/common/domain.c
> @@ -512,7 +512,7 @@ static int sanitise_domain_config(struct xen_domctl_createdomain *config)
>   
>       if ( iommu )
>       {
> -        if ( config->iommu_opts & ~XEN_DOMCTL_IOMMU_no_sharept )
> +        if ( config->iommu_opts >> XEN_DOMCTL_IOMMU_MAX )

XEN_DOMCTL_IOMMU_MAX will be defined as:

(1U << _XEN_DOMCTL_IOMMU_force_iommu)

This means the shift will do the wrong thing. However, AFAICT, this new 
option will only be supported by Arm and likely only for platform device 
for the time being.

That said, I am not convinced this flag should be per-domain in Xen. 
Instead, I think it would be better to pass the flag via the device 
assign domctl.

>           {
>               dprintk(XENLOG_INFO, "Unknown IOMMU options %#x\n",
>                       config->iommu_opts);
> diff --git a/xen/drivers/passthrough/device_tree.c b/xen/drivers/passthrough/device_tree.c
> index 98f2aa0dad..103608dec1 100644
> --- a/xen/drivers/passthrough/device_tree.c
> +++ b/xen/drivers/passthrough/device_tree.c
> @@ -198,6 +198,7 @@ int iommu_do_dt_domctl(struct xen_domctl *domctl, struct domain *d,
>   {
>       int ret;
>       struct dt_device_node *dev;
> +    struct domain_iommu *hd = dom_iommu(d);
>   
>       switch ( domctl->cmd )
>       {
> @@ -238,6 +239,16 @@ int iommu_do_dt_domctl(struct xen_domctl *domctl, struct domain *d,
>               return -EINVAL;
>   
>           ret = iommu_add_dt_device(dev);
> +
> +        /*
> +         * iommu_add_dt_device returns 1 if iommu is disabled or device don't
> +         * have iommus property
> +         */
> +        if ( (ret == 1) && (hd->force_assign_iommu) ) {
> +            ret = -ENOSYS;
> +            break;
> +        }
> +
>           if ( ret < 0 )
>           {
>               printk(XENLOG_G_ERR "Failed to add %s to the IOMMU\n",
> @@ -275,10 +286,14 @@ int iommu_do_dt_domctl(struct xen_domctl *domctl, struct domain *d,
>   
>           ret = iommu_deassign_dt_device(d, dev);
>   
> -        if ( ret )
> -            printk(XENLOG_G_ERR "XEN_DOMCTL_assign_dt_device: assign \"%s\""
> +        if ( ret ) {
> +            if ( hd->force_assign_iommu )
> +                ret = -ENOSYS;
> +            else
> +                printk(XENLOG_G_ERR "XEN_DOMCTL_assign_dt_device: assign \"%s\""
>                      " to dom%u failed (%d)\n",
>                      dt_node_full_name(dev), d->domain_id, ret);
> +        }
>           break;
>   
>       default:
> diff --git a/xen/drivers/passthrough/iommu.c b/xen/drivers/passthrough/iommu.c
> index 6334370109..216a9058c0 100644
> --- a/xen/drivers/passthrough/iommu.c
> +++ b/xen/drivers/passthrough/iommu.c
> @@ -193,6 +193,8 @@ int iommu_domain_init(struct domain *d, unsigned int opts)
>       hd->node = NUMA_NO_NODE;
>   #endif
>   
> +    hd->force_assign_iommu = opts & XEN_DOMCTL_IOMMU_force_iommu;
> +
>       ret = arch_iommu_domain_init(d);
>       if ( ret )
>           return ret;
> @@ -534,6 +536,7 @@ int iommu_do_domctl(
>   {
>       int ret = -ENODEV;
>   
> +

Spurious change.

>       if ( !is_iommu_enabled(d) )

Should not this check be updated to check force_assign?

>           return -EOPNOTSUPP;
>   
> @@ -542,7 +545,7 @@ int iommu_do_domctl(
>   #endif
>   
>   #ifdef CONFIG_HAS_DEVICE_TREE
> -    if ( ret == -ENODEV )
> +    if ( ret == -ENOSYS )

AFAICT, none of the code (including callee) before ret have been 
modified. So why are you modifying the check here?

>           ret = iommu_do_dt_domctl(domctl, d, u_domctl);
>   #endif
>   
> diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
> index b85e6170b0..bf5f8c5b6b 100644
> --- a/xen/include/public/domctl.h
> +++ b/xen/include/public/domctl.h
> @@ -81,8 +81,11 @@ struct xen_domctl_createdomain {
>   #define _XEN_DOMCTL_IOMMU_no_sharept  0
>   #define XEN_DOMCTL_IOMMU_no_sharept   (1U << _XEN_DOMCTL_IOMMU_no_sharept)
>   
> +#define _XEN_DOMCTL_IOMMU_force_iommu 1
> +#define XEN_DOMCTL_IOMMU_force_iommu  (1U << _XEN_DOMCTL_IOMMU_force_iommu)
> +
>   /* Max XEN_DOMCTL_IOMMU_* constant.  Used for ABI checking. */
> -#define XEN_DOMCTL_IOMMU_MAX XEN_DOMCTL_IOMMU_no_sharept
> +#define XEN_DOMCTL_IOMMU_MAX XEN_DOMCTL_IOMMU_force_iommu
>   
>       uint32_t iommu_opts;
>   
> diff --git a/xen/include/xen/iommu.h b/xen/include/xen/iommu.h
> index 6b2cdffa4a..a9cf2334af 100644
> --- a/xen/include/xen/iommu.h
> +++ b/xen/include/xen/iommu.h
> @@ -330,6 +330,9 @@ struct domain_iommu {
>        * necessarily imply this is true.
>        */
>       bool need_sync;
> +
> +    /* Do not return error if the device without iommu is assigned */
> +    bool force_assign_iommu;
>   };
>   
>   #define dom_iommu(d)              (&(d)->iommu)

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Feb 17 15:43:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 17 Feb 2022 15:43:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274858.470466 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKiw1-0004WF-C1; Thu, 17 Feb 2022 15:43:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274858.470466; Thu, 17 Feb 2022 15:43:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKiw1-0004W8-8n; Thu, 17 Feb 2022 15:43:09 +0000
Received: by outflank-mailman (input) for mailman id 274858;
 Thu, 17 Feb 2022 15:43:08 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mzVd=TA=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nKiw0-0004W2-9G
 for xen-devel@lists.xenproject.org; Thu, 17 Feb 2022 15:43:08 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4bb00712-9008-11ec-8eb8-a37418f5ba1a;
 Thu, 17 Feb 2022 16:43:06 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4bb00712-9008-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645112586;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=WYsCC30DTUis/FmKE5Z3+CVmrp7owvRWbCtgXBB4CUo=;
  b=OxZTSZd3y0rJdVqwH/fqqkBNdUXxe8166mhwMJWQ5ez47bx1z4i3zmm+
   DYnRZ0dMbyW0WnnfpVBxFWtnx5PYRpFpK33mpDP74XB65hYVQi3i1wAPV
   HkI984EciwixVQIcMyDiiUrlIeFLYsKtTS9f5/7uRkGHpMlRCn4EUp7MJ
   g=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: h5TZCVeTNVrbpo6vVZiDcuYdf/lR1n4JHnqFrBEprHWFVqy6s/NmzY4nS+tibumMYi9EEeCI1e
 d//OpfXOPN98EL3umtIqUtbOkWiQGWzb0vrPoCqX+jxt89T2hjjXRQ8V8ydpB9yTWKhaAvLZUV
 kfvxg4cCmKLyHiylQBmQltCWffRWS2xOqCrlxB46Mhm7vhh3DPpcEmsTQ5FsRr2kpqO1o07sAh
 vzjozyzZJ4F6QRSOd1IGbd/hPYfL8mG3IxVfs7bM6EF+i9oQy3eTAJk42Xj0eVYcYhUvSfJJNo
 rGDcmH2/EFOujeU7K/Ia4moP
X-SBRS: 5.1
X-MesageID: 63883320
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:YWWTm6pH9xZAK5F4jKLbmb3n4AdeBmKaYhIvgKrLsJaIsI4StFCzt
 garIBnVaPjcYzTzetgkOozlpk4Ov8Pdm9AxSVc/rHpnQi0Q9ZuZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlZT4vE2xbuKU5NTsY0idfic5Dndx4f5fs7Rh2NQw24HmW1nlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCnaS/ExY7OoqSpORHSRdXIhNQHPFioaCSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFIoZpnFnyyCfFfs8SIrPa67L+cVZzHE7gcUm8fP2O
 ZFJOWE0NkyojxtnAk03LrYgufyTviPQdxdJmmqwqY0Y7D2GpOB2+Oe0a4eEEjCQfu1Xg0KZq
 2Tu72n/RBYAO7S30iGZ+3ihguvOmyLTW48IErC8sPlwjzW72Wg7GBAQE1yhrpGRmkO4Ht5SN
 UEQ0i4vtrQpslymSMHnWB+1q2LCuQQTM/JTFOsg4Q3L1avQ4C6eHGEPSjMHY9sj3Oc0TzE30
 l6Cn/vyGCdi9raSTBqgGqy89G3of3JPdClbOHFCHVBtD8TfTJ8bth2VX8RnN/CJjofvFz7B8
 R6r8AxnmOBG5SIU7JmT8VfCijOqg5HGSA8p+wnaNl6YAhNFiJ2NPNLxtwWChRpUBMPAFwTa4
 iBY8ySLxL1WVfmweDqxrPLh9V1Dz9KMK3XijFFmBPHNHBz9qif4Lei8DNyTTXqF0/romxe1M
 Sc/WisLvfe/2UdGi4ctPOpd7OxwkMDd+SzNDKy8Uza3SsEZmPW71C9vf1WM+GvmjVIhl6oyU
 b/CL5rxVS1FV/g6l2XrLwv47VPN7nphrY80bcqmpylLLJLEPCLFIVv7GADmgh8FAFOs/1yOr
 oc32zqiwBRDSuzuChQ7AqZIRW3m2UMTXMisw+QOL7brClM/RAkJVq+AqZt8KtcNt/kEyY/1E
 oSVBxYwJKzX3iacd21nqxlLNdvSYHqIhSlqZ3NyYwfziiNLjETGxP53SqbbtIIPrIRLpcOYh
 dFcEylZKvgQGDnB5RoHapzx8N5reBix3FrcNCu5ejkvOZVnQlWRqNPjewLu8ggIDza26pRi8
 +HxiFuDTMpRXRlmAebXdOmrkwG7s08Clb8gREDPONRSJhnhqdA4Nyzrg/YrCMgQMhGflCCC3
 gObDE5A9+nAqoM46vfTgqWAo9v7GudyBBMCTWLa8ay3JW/R+W/6md1MV+OBfDb8UmLo+fr9O
 bUJnq+kaPBexQREqYtxFbpv3JkS3dq3qu8I1BlgEVXKc0+vVuFqLE6Z0JQdraZK3LJY51e7A
 xrd5tlANLyVE8r5C1pNdhE9Z+GO2PxIyDnf6fM5fBfz6CNtpefVVExTO1+HiTBHLaszO4Qgm
 L9ztMkT4g25qxwrLtfZ0XwEqzXSdiQNA/c9q5UXII73kQ56mFhNbKvVBjLy/JzSOc5HNVMnI
 2PMiafP71iGKpEur5bn+aDx4Ndg
IronPort-HdrOrdr: A9a23:PhVje623qOmOFEbfk4HHDwqjBLYkLtp133Aq2lEZdPUzSL3+qy
 nOpoV+6faQsl0ssR4b9exoVJPufZq+z/5ICOsqU4tKNTOO0AHEEGgI1+rf6gylNyri9vNMkY
 dMGpIObeEY1GIK7voSNjPIceod/A==
X-IronPort-AV: E=Sophos;i="5.88,376,1635220800"; 
   d="scan'208";a="63883320"
Date: Thu, 17 Feb 2022 15:42:58 +0000
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>, Konrad Rzeszutek Wilk
	<konrad.wilk@oracle.com>, Ross Lagerwall <ross.lagerwall@citrix.com>
CC: Jan Beulich <jbeulich@suse.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>,
	"Julien Grall" <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>
Subject: Ping: [XEN PATCH v9 06/30] build: rework test/livepatch/Makefile
Message-ID: <Yg5tArVkT2JUyM91@perard.uk.xensource.com>
References: <20220125110103.3527686-1-anthony.perard@citrix.com>
 <20220125110103.3527686-7-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220125110103.3527686-7-anthony.perard@citrix.com>

Hi Ross, Konrad,

Could you ack or review this patch?

There is also a few other patches in this series that make some changes
to "xen/test/livepatch/Makefile", an ack for those would be nice as
well:

- 09/30 build: build everything from the root dir, use obj=$subdir
- 19/30 build: clean-up "clean" rules of duplication
- 20/30 build: rework "clean" to clean from the root dir
- 25/30 build: replace $(BASEDIR) by $(objtree)
- 30/30 build: adding out-of-tree support to the xen build

Cheers.

On Tue, Jan 25, 2022 at 11:00:39AM +0000, Anthony PERARD wrote:
> This rework the livepatch/Makefile to make it less repetitive and make
> use of the facilities. All the targets to be built are now listed in
> $(extra-y) which will allow Rules.mk to build them without the need of
> a local target in a future patch.
> 
> There are some changes/fixes in this patch:
> - when "xen-syms" is used for a target, it is added to the dependency
>   list of the target, which allow to rebuild the target when xen-syms
>   changes. But if "xen-syms" is missing, make simply fails.
> - modinfo.o wasn't removing it's $@.bin file like the other targets,
>   this is now done.
> - The command to build *.livepatch targets as been fixed to use
>   $(XEN_LDFLAGS) rather than just $(LDFLAGS) which is a fallout from
>   2740d96efdd3 ("xen/build: have the root Makefile generates the
>   CFLAGS")
> 
> make will findout the dependencies of the *.livepatch files and thus
> what to built by "looking" at the objects listed in the *-objs
> variables. The actual dependencies is generated by the new
> "multi-depend" macro.
> 
> "$(targets)" needs to be updated with the objects listed in the
> different *-objs variables to allow make to load the .*.cmd dependency
> files.
> 
> This patch copies the macro "multi_depend" from Linux 5.12, and rename
> it to "multi-depend".
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> Acked-by: Jan Beulich <jbeulich@suse.com>
> ---
> 
> Notes:
>     v9:
>     - half acked, still need "livepatch" maintainer ack.
>     
>     v8:
>     - rename multi_depend to multi-depend
>     - use $() for single-letter make variable
>     - re-indent one line
> 
>  xen/scripts/Kbuild.include  |   9 ++
>  xen/test/livepatch/Makefile | 213 ++++++++++++++----------------------
>  2 files changed, 91 insertions(+), 131 deletions(-)

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Thu Feb 17 15:53:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 17 Feb 2022 15:53:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274865.470477 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKj5W-00061C-Am; Thu, 17 Feb 2022 15:52:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274865.470477; Thu, 17 Feb 2022 15:52:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKj5W-000615-7M; Thu, 17 Feb 2022 15:52:58 +0000
Received: by outflank-mailman (input) for mailman id 274865;
 Thu, 17 Feb 2022 15:52:57 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=A/h9=TA=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nKj5U-00060z-Vj
 for xen-devel@lists.xenproject.org; Thu, 17 Feb 2022 15:52:57 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id aa86c7de-9009-11ec-8723-dd0c611c5f35;
 Thu, 17 Feb 2022 16:52:55 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: aa86c7de-9009-11ec-8723-dd0c611c5f35
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645113175;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=T2txGOiXiKki1sdU0KOuGz/sQsnPCagkFj3I0aACfks=;
  b=btJSFocz6yp1knq93A+dMqf3+1HpLRKsAdNLT8nmE4apQ23DVbyXAK79
   jeWI/KEXzm70vahFoN7h3wf7K9c23PSi0SLzG00ueFaBU2inGS8XUQF63
   SJ84rdyvFySEbbwzd8NaHNWIRqpV++Nf58IoydHKMsES6Y8hfGnoZ4pIK
   k=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: 4q56oXGDLr+A3UgP7yg6nzt5T22SEW+lgLxrZ4cn8WH8e2xxkjo87Iaq+ARIuBJOojvYpVqVLW
 vg9CbsGd2pg2m2aV5A3I7c27JxfMpKLjuhFUMl8N0zLBAUyQVYgsiRBGecjmabRGyUIeJFuBKY
 s0UiG65sI5tvbog47wi8m8YJYf6f+ZWRj0rV1xSiiXFtcE3fTbGF2Od5Ia5tr8PXMlB3NLFoDF
 t1X4NZqaqw/UjQvBu7IYvk7wygh3jjvhn1NFg/PEyzqSb5pfep/PcmphIe5kDaSR/VV1zuK+De
 wekmCDaj9mc7koxxbrvR66ED
X-SBRS: 5.1
X-MesageID: 64446626
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:yWs+qq+JfK+Z3jrcc2/wDrUDXnmTJUtcMsCJ2f8bNWPcYEJGY0x3m
 2sdXmyBbq7fMWLyfdtzaIvl8EwOv8LdyNBnG1Ftqng8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhFWeIdA970Ug5w7Rg3dYy6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhxy
 88WvLeNVT41GZ+Xm88EDz5XNxphaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguw5K8bmJsUHs2xIxjDFF/c2B5vERs0m4PcGgGts2J4UQ54yY
 eIjcmFGRx+RfyRVI042Wb4Ds/aQr3bgJmgwRFW9+vNsvjm7IBZK+KfpGMrYfJqNX8o9tlaVo
 CfK8nr0BjkeNceD0nyV/3S0nOjNkCjnHoUIG9WQ9PRnnVmSzWw7EwANWB2wpvzRt6Klc4sBc
 QpOoHNo9PVsshzwJjXgY/GmiH6HpEUVcOdMKvEd2lqO4bOIxAm9PXdRG1atd+canMMxQDUr0
 HqAkNXoGSFjvdWpdJ6NyluHhWjsYHZIdAfucQdBFFJYuIe7/OnfmzqSFo4LLUKjsjHi9dgcK
 RiupTN2ubgchNVjO06TrQGe2GLESnQko2cICuTrsoCNslIRiG2NPdXABb3nARBodtnxor6p5
 iVspiRmxLpSZaxhbQTUKAn3IJmn5uyeLBrXikN1Ep8q+lyFoiD/INgLv28ieRw2b67onAMFh
 meJ5mu9A7cJYROXgVJfOdrtW6zGM4C7fTgaahwkRoUXOcUgHON21CpveVSRzwjQfLsEyskC1
 WOgWZ/0Vx4yUP0/pBLvHrt1+eJ7l0gWmDKILbimnkvP7FZrTCPMIVvzGADVNb5RAWLtiFi9z
 uuzwOPRmk8ADrOvOXiMmWPRRHhTRUUG6VnNg5U/XsaIIxZ8GXFnDPnUwLg7fJdikbgTneDNl
 kxRkGcCkgGXaaTvJVrYZ3Z9RqnoWJoj/3s3MTZ1ZQSj2mQ5YJbp56AaLsNlcb4i/e1l7Ph1U
 /haJJnQXqUREmzKq2YHcJ3wjI1+bxD31wiACDWoPWokdJl6Sg2XptK9Jlnz9DMDBzacvNclp
 +HyzRvSRJcOHlwwDMvfZP+14Um2uHwRxLB7U0fSe4EBc0Tw6ol6bSf2i6Zvcc0LLBzCwBqc1
 hqXXkhE9bWc/ddt/YCQ166eroqvH+9vJWZgHjHWveSsKC3X3mu/2oscAuyGSi/QCTHv86K4a
 OQLk/ylaK8bnExHupZXGqpwyf5s/MPmorJXw1g2HHjPaFj3WLpsLmPfgJtKv6xJgLRYpRG3S
 gSE/dwDYeeFP8bsEVgwIgs5b7vciaFIy2eKtfllcl/n4CJX/aacVRQANhaBvyVRMb9pPd532
 uwmosMXt1SyhxdC3gxqVcyIG7Bg9kA9bpg=
IronPort-HdrOrdr: A9a23:imhk0KqQSqtxvui+/p0zcSsaV5uzL9V00zEX/kB9WHVpm5Oj+P
 xGzc526farslsssREb+OxpOMG7MBThHLpOkPMs1NCZLXTbUQqTXfpfBO7ZrQEIdBeOlNK1uZ
 0QFpSWTeeAcWSS7vyKkTVQcexQueVvmZrA7Yy1rwYPcegpUdAZ0+4QMHfkLqQcfnghOXNWLu
 v52iIRzADQBkj/I/7LTUUtbqzmnZnmhZjmaRkJC1oO7xSPtyqh7PrfHwKD1hkTfjtTyfN6mF
 K13jDR1+GGibWW2xXc32jc49B/n8bg8MJKAIiphtIOIjvhpw60bMBKWqGEvhoyvOazgWxa2u
 XkklMFBYBe+nnRdma6rV/E3BTh6i8n7zvYxVqRkRLY0LrEbQN/L/AEqZNScxPf5UZllsp7yr
 h302WQsIcSJQ/cnQzmjuK4GS1Cpw6Rmz4PgOQTh3tQXc81c7lKt7ES+0tTDdMpAD/60oY6C+
 NjZfusq8q+SWnqL0wxg1Mfg+BFBh8Ib1W7qwk5y4CoOgFt7TFEJxBy/r1bop8CnKhNPKWsqd
 60dpiAr4s+PfP+W5gNcNvpcfHHelAlfii8Ql56AW6XXZ3vaEi946Ie3t0OlZSXkdozvdwPpK
 g=
X-IronPort-AV: E=Sophos;i="5.88,376,1635220800"; 
   d="scan'208";a="64446626"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=HVwy/fv9IdQn3yliLflSQyEm1eze9lx+K/IN/XCUR/gcXd0/e7wl9LC1GGfDA37iT8kPCJn62n4JzWYADXqR0zygqRNjwwTbwGAbR9kgVJc3J1I+I6qPyUHwTjPqnUjUC4Hh6zWl8J1hcYqVhWlLNYaegbQtdFhMl1qSJ/jO06WH1CZ3tiw01KSJLpMOW7FdsNC0G8jJlkddaL5Od+4yb9wR04rYhkX0XncEk50GWxs38AtbTQ7dvKzEyD6ompqwbO0ZXzkjqASZmMAMQsY6bQ/QZiOqbeTQndr3COMJfEH12D7nrY0wWsQiA71b8iGPwD2jg9Stgln9bxXwC2md/A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=koOWlH8ydSAqujxyjK1NQtAxTr+mx/9U1EGpVfw8e5w=;
 b=nlujufLqctb56JMy76SJGSbI1iXZ/mUmB97aG7Ucbl6pn/FJ3qhyGduVLOsOBkxfaQN36zyJQGV9aXWAfcYcDWZPmCCjdd3IX3rzYdlQZphRecUsKfEw6MX3n6+zvt4gE4Di9QIU/aHljxd7CTTnxIPr5XI1kX55bSieNuaEIZnr+ZBPMIkB0bgkjb5rtvN45PCLBhvk1fTaNUBD+AMe78x8GPUgTLNmvd301ncfethOkGtYvnQYjsNsPnGkkb989X2I7zfERnLrwzeyN3o3CUo7iOz3RNh5pFc3ua6Y4jwdeCXyQlbcH/UnqBkmgoL3pot4MHqEaxrzGeOK6811Yw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=koOWlH8ydSAqujxyjK1NQtAxTr+mx/9U1EGpVfw8e5w=;
 b=DWhgg44pRrZZMjSzAfTOdvKciRN8lTfc4nEsd1ypnd4bUqWs4kZevUOut/o2qtaBUEcv3C0yisrT9HpfP6p2ts7beW/aPtr86w4DxsBvhZe83EIPd0gd7BM4rK8Wf00RWs7opMHIcpvXl/cNVx+cupT5/3V9Msnd1zBa9ITh1ys=
Date: Thu, 17 Feb 2022 16:50:04 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH RESEND v2] x86: introduce ioremap_wc()
Message-ID: <Yg5urE+rpOQGWiH9@Air-de-Roger>
References: <8f56a8f4-0482-932f-96a9-c791bebb4610@suse.com>
 <c56aadc8-e568-4625-5d6f-bd2b8981f3ae@suse.com>
 <Yg5gGenFpAwZqtSW@Air-de-Roger>
 <34dac738-0631-f80c-a3db-7367e37ec0b9@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <34dac738-0631-f80c-a3db-7367e37ec0b9@suse.com>
X-ClientProxiedBy: LO4P123CA0057.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:153::8) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b2effffd-5721-4851-aed6-08d9f22d2c9a
X-MS-TrafficTypeDiagnostic: CY1PR03MB2299:EE_
X-Microsoft-Antispam-PRVS: <CY1PR03MB22992246BE6954996D8F0CC08F369@CY1PR03MB2299.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6430;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: ble3DOrO0wkPIACn9v4zDUBwoOBQHKqapUbbhugxrwkKUNtIE8db1X0nAHIaJwXouwo1V/DCXF7ta/AwDDgpxM3ms0PqLPb0p7A/qmdACRXzc3SmHyb2uD3hiO1DKx1EjScV29r0rmpDDKn6NB/7zczWP1PyKySC3OmJ0oPr1ohDH7SBP+yzdNHzKp9pG+QBFQOZ/0ofcgcfyWrBZC1kKGKJOhLzWClillL0n28iC1o+txzuTrYUr8i17liAqzoYSmN0u8X+Su/e25DYM8tC2j2QJYlHbrGE/jzR0VeDyzK0ye5HkFMt+Dlza6VnlZlw8zATyPIQb9JkXve1O2mAQYUC51oKBeVnnxHYYbBhcMOr1ovegBhbQjkoYXEfw9/+G6ES3q0r4AShgtlrJgfma2D98uuRL4TG0JNaHiPOHwEHBpQfT01ymVq7vyZMEb1ME1zc8tHjSJAzeDzCVUv0wBQJC2U4qLGYRWOQSQ2wr0+es+4YA4hzn+O3n7f76tsG19gysk5lzkuBC7PQQ1Km6umYlGeYZj6iRgRuG8SPNATCqquQbr0n9i+GWA3jfEggdpprvwo0y+6Hr8IY7rQnJ2inLXp/xT7wQe+tp3D+Ch1WzEhxU5Q/6M8wUynvwhiwGVANmGNca4Gv53tQp2mwz0136WmYsgyFymW7euZPVHeRp+AO9iHUU8IalIcRhbZ5z2b02xkVtFt+qrcn4A7V3g==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(316002)(6666004)(82960400001)(6916009)(6512007)(9686003)(53546011)(6506007)(33716001)(8676002)(54906003)(83380400001)(4326008)(66946007)(66476007)(66556008)(38100700002)(5660300002)(6486002)(2906002)(508600001)(8936002)(85182001)(86362001)(186003)(26005)(67856001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?alhhWDUrdzU4Z2xCVlZuNldDaU9iUmlzdk8zWVVuY2RvYmthbEYzK3BNeUVr?=
 =?utf-8?B?VUJLMjVPQXZyQ2Fxak14dHd1QXNwYVZkMHFVK1hLOTRLaEZzV2I0WUc3dkRM?=
 =?utf-8?B?QVhwOGJkcTk5VUpGNnB5VVo5NVVDdlpHR3RwMzdpSm43U3lYN1lRWnpjSUhn?=
 =?utf-8?B?TE9KMEo4cXkvbENWd2I2YmtwYnliZTF3QkNQQnJSV0NMTE9KQVY2eWZZcFZR?=
 =?utf-8?B?YWttaEk4RTRXMmRYc3c2TEsyMlZMcm1mVWFseFJtZ2hrdFR2TzFzRElNeXVs?=
 =?utf-8?B?K2llNDQvWm5kRGVFM0JrSHJqZzJpNTlaZGROLzNIdGlGUU95TTJrQWs5Y01B?=
 =?utf-8?B?SFhuZHdxVnNFWk9NMmRLTEU4UmQ4dDhkYjQvQU1mYTkxWUxndEpNN1V0c21h?=
 =?utf-8?B?Q0M0V0VpTi93b2ltUU5IazlPRlNZSGZneU1pTk4wRTBjQ0hYZmVOaEp1alNJ?=
 =?utf-8?B?WGQyZ2YxNm91MDZYbE9KbFN3alRNMER0bWtna0Q2L0ZIRkdzTVpKRG9CS3lz?=
 =?utf-8?B?VmpWbzhwL1ROOTFpTStZa3BEb0hKZUlJR3JQdGY2cGZtZFZxUUxxSUwwZ3Mx?=
 =?utf-8?B?TWJSa0NoelZlb1B2YzdrZGZtZ2kzcUltQnFJbDI5MWh0akdaSWxuUTVWRzFJ?=
 =?utf-8?B?YkxRTXk4bUdjdXM1cGNyWmpvOUlsTUp0L3p4VDgvRTJGWEV5dUlPbFVMN1Zs?=
 =?utf-8?B?bUxBMDE1QTFrZW1VRkpQbzVBTkNzTHJ3clNXT0ZpM2FYN0M1VzI3R3F3eVUx?=
 =?utf-8?B?am5nT1hYaytCT3JQbHliQk43ZjRqbUZWMnFodStCKys2SmZpK0QvZWNVUVRR?=
 =?utf-8?B?ZUloQm1TVzh6M05neGY5UUt3VlFHRzJDYzZKVEFGRVhuWTdLVVpFbEhSM1h6?=
 =?utf-8?B?UWZwb3dzTlBXU0xHVHBQN2FiZmZBc3dqdnpJZkN6Z3lPZ2FQSUlqK3hxSG1F?=
 =?utf-8?B?dVg3N0hteWlwdUp1QTIvUjQyZGhUalhzTC9odlpsdUE5MENkNGk3UDJUcGJY?=
 =?utf-8?B?V2NBL1BNc1phVG4rVWsxejZhcjQ5Z2xYZ2FZMWxEeVVjQm1TdkMza1p5UFBZ?=
 =?utf-8?B?VUJMdjgvcHRMemg5clRnWTRxWTNDUHNSSkJpekF1SnljNkUySGw2VFZzNUh4?=
 =?utf-8?B?SHArR2FERkNNZVE2enYxdi9BSGlpZmxOWUxaeGpBKzgvNXMvc2w4ck1RZkZq?=
 =?utf-8?B?azFlOVUvZk95L256ZXppOUFUb3lmaHd6aDFWcVBMNUpBQ1FSU1U3YTQ0cXJx?=
 =?utf-8?B?NTZuNC9ZV3h1S2tsSmVXN2dDWkk0OHE2Q1MvOFBnRmIvaDJtRmI2cWREeVhE?=
 =?utf-8?B?R2tGUW5qL0lJallsUlF1V2hBazhkV0ZtZmlqTjUrRTNqK2UwaHlnTlVtN1dr?=
 =?utf-8?B?eGhlTkRLcERGeUZvb2Z1SllrUUx6Zk9HbXpveTZ0TkZoVUlQUmt6WFBDZmRX?=
 =?utf-8?B?azYyQXNBS25EMnJUdlJNSlhDb0ZCSlRIT1BnUXhIb0dOUjNJcE1XTHlwT0RS?=
 =?utf-8?B?SGR4dDJCazcrRUEyd21YOEZpcTdIckNZNlJQczFyTTJDdmlmWjZiaUZPdHlD?=
 =?utf-8?B?M2FpRXdiamdVR0g1VEw5U0xPRXM2azJ1MzloM3g4SFEwWEdwbkZBakltUGJt?=
 =?utf-8?B?dUdTR2V4a3RCS2h1cVlsaDNkWW96MzY3dG9vbWduNVNGelo5aDZyRVk1NEFj?=
 =?utf-8?B?ZmM3YjRKL0RSV2J4MHNSUDV5K3ZybGFVZ0JEYlRSbnJOYjAzL0VrQ3h2TFdG?=
 =?utf-8?B?TENqRFFvQ0FNZC96VWYwL2FqMXhIc3FGNVNVSDZxS0lKKzBQWklVRno0dmRF?=
 =?utf-8?B?TitFSDFUeFV4aFRERGlLWXNoTVFlRjNwZ2hyWUV2Vmk2Y3hraExXMXVFa3Rp?=
 =?utf-8?B?TWtYdm9CRjBGeVR3UGxLYVVZQUVOdXhwSExIcTA3K2YvZWVKYjRWcHBRNi9R?=
 =?utf-8?B?RG1EcmFBZWtUZ0szbzNFYVVoQWNSaHJIMjlzemtCTmJVazY1ZlFVNkN0N1dO?=
 =?utf-8?B?aURFZGR4L2cvQlJvdmZObnFOUWNZRHNwSEJ3Qis4aExqNTJXOFJFRkY4Tzhu?=
 =?utf-8?B?aGl2MzM2eXhzOGhGeFVPUEFNdnAwdnVVbStWWkpzSXdBaDc3MTVXeGVBNFZq?=
 =?utf-8?B?ZUVOLzVuU29jeERQcUhvWFMwWG1icmp1dFdPaXl5cmZ2Yjc0cTJ2dUVpcEdZ?=
 =?utf-8?Q?4o1bsMYytAbUblokiJdjSMU=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b2effffd-5721-4851-aed6-08d9f22d2c9a
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2022 15:50:08.7920
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZoqG6FTKzFJA71TNwv5IeTj5ES+dDk89md+xf2I/kcnvG4XyI+BeJWYtD0LoiQNURtSVAhZRWTpfO8LyXWnQqA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR03MB2299
X-OriginatorOrg: citrix.com

On Thu, Feb 17, 2022 at 04:02:39PM +0100, Jan Beulich wrote:
> On 17.02.2022 15:47, Roger Pau Monné wrote:
> > On Thu, Feb 17, 2022 at 12:01:08PM +0100, Jan Beulich wrote:
> >> @@ -179,8 +179,7 @@ void __init vesa_mtrr_init(void)
> >>  
> >>  static void lfb_flush(void)
> >>  {
> >> -    if ( vesa_mtrr == 3 )
> >> -        __asm__ __volatile__ ("sfence" : : : "memory");
> >> +    __asm__ __volatile__ ("sfence" : : : "memory");
> > 
> > Now that the cache attribute is forced to WC using PAT don't we need
> > to drop vesa_mtrr_init and vesa_mtrr? The more that the option is
> > fully undocumented.
> 
> Yes indeed. You did ask to re-send this patch in isolation. This removal
> is part of the full series.
> 
> >> --- a/xen/drivers/video/vga.c
> >> +++ b/xen/drivers/video/vga.c
> >> @@ -79,7 +79,7 @@ void __init video_init(void)
> >>      {
> >>      case XEN_VGATYPE_TEXT_MODE_3:
> >>          if ( page_is_ram_type(paddr_to_pfn(0xB8000), RAM_TYPE_CONVENTIONAL) ||
> >> -             ((video = ioremap(0xB8000, 0x8000)) == NULL) )
> >> +             ((video = ioremap_wc(0xB8000, 0x8000)) == NULL) )
> >>              return;
> >>          outw(0x200a, 0x3d4); /* disable cursor */
> >>          columns = vga_console_info.u.text_mode_3.columns;
> >> @@ -164,7 +164,11 @@ void __init video_endboot(void)
> >>      {
> >>      case XEN_VGATYPE_TEXT_MODE_3:
> >>          if ( !vgacon_keep )
> >> +        {
> >>              memset(video, 0, columns * lines * 2);
> >> +            iounmap(video);
> >> +            video = ZERO_BLOCK_PTR;
> >> +        }
> >>          break;
> >>      case XEN_VGATYPE_VESA_LFB:
> >>      case XEN_VGATYPE_EFI_LFB:
> > 
> > I think in vesa_endboot you also need to iounmap the framebuffer
> > iomem?
> 
> Again part of the full series. I guess I was a little inconsistent
> with leaving the VGA unmap in here, but breaking out the VESA part.
> It's been a long time, but I guess I did so because the VESA part
> needs to touch two files.

I think you are hesitant to include the chunks for the above items? (or
maybe I'm not properly accounting for their complexity).

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Thu Feb 17 15:57:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 17 Feb 2022 15:57:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274874.470487 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKjAD-0006lg-1D; Thu, 17 Feb 2022 15:57:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274874.470487; Thu, 17 Feb 2022 15:57:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKjAC-0006lZ-UU; Thu, 17 Feb 2022 15:57:48 +0000
Received: by outflank-mailman (input) for mailman id 274874;
 Thu, 17 Feb 2022 15:57:47 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=xzkl=TA=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nKjAB-0006lT-ON
 for xen-devel@lists.xenproject.org; Thu, 17 Feb 2022 15:57:47 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 591e9acf-900a-11ec-8723-dd0c611c5f35;
 Thu, 17 Feb 2022 16:57:46 +0100 (CET)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2111.outbound.protection.outlook.com [104.47.18.111]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-28---t2E1Q1NiCqNUpACSpbnA-2; Thu, 17 Feb 2022 16:57:45 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AS8PR04MB7672.eurprd04.prod.outlook.com (2603:10a6:20b:23e::5)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.16; Thu, 17 Feb
 2022 15:57:43 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4995.016; Thu, 17 Feb 2022
 15:57:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 591e9acf-900a-11ec-8723-dd0c611c5f35
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645113466;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=iunAgiiwD/6hmyu1jkkrPQJWUH9YFXwUtL+ILSNeHbc=;
	b=nkoJ9gwjMiLr2NDCvsy9OowpURuFanstRnp+sY1CkrHlTM2ZHiLs1f2P59pfnmNGIUFfw7
	t7UWjRDMHmPBDidJRhg+opvCbmNEQIf35ZieHnyqGcpGRms34QaNXv3Uh2KxWDpk69dnR+
	jIf0xUUf3vf8QHbcGCxOLCiFJaDoaUc=
X-MC-Unique: --t2E1Q1NiCqNUpACSpbnA-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=BAIP5PNA+/b1nOkFmCerz58gP1AYuHvsFYhSHb27oATXWw9tMEoWU+3NpYyOiJWfgYDtbaaLX3nFWUudyb1i55zs3uh3P7hrCOctpD7sel+zFuNcyNiJSFjIexZOfsWzTzdao3dZ1OOzXCLvk91/WXDTN375vmzgLiEaLSORhF3uO6z2IPPmNAC6DAQXqg9a6v2Slj8IOX9Z0UIFxLbpI+rnHGrgTj/3gwyhwNUhB5ILpB85ikQsWvbx31EixcJkxPIo35AjUi6EdT6BI/iZARMTP9v5b00F6b9xbGe6yNMjwrBYsTqYHJ6UGuvTuslnBkkQHdurrcl3LOg2X1a6DA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Y8PaQRst3XiOwatV1sZARRAChZY4jzPC6XQs4ZHxiCA=;
 b=i21GlgTAs7tufkx65inKxACTEPabvcRKgO8FKI4wI18bLBbEAXtwRYlaaqjzaKMq53ORszY+lpMg6whjpT/aUtSK3XbbNLyu51ikllexh2KcmwnBPJPJOfkJjIJrPKFSPRXjDEA2TFYAxIjtD6TjyPuh1sdSk7FuhrqsDozCuZhkQpykBlnak7bOjyqcERVvwm90TAzJ1tsy3dIvLyiEQRjNdXx+gSFBIUiDWcB13vGO4P5UOoG6AvP9wQzcjLTctPPlYpyo7IDaOeN5mwvvdTYK/K6ZsC9w+pUAN6J2+UAlNl69uFFjtCD2+V1wDSzPK4HpJHo/KGhaw8HH385mvQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <6f343b71-80f7-1aca-3be1-58239ba81dff@suse.com>
Date: Thu, 17 Feb 2022 16:57:41 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH RESEND v2] x86: introduce ioremap_wc()
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
References: <8f56a8f4-0482-932f-96a9-c791bebb4610@suse.com>
 <c56aadc8-e568-4625-5d6f-bd2b8981f3ae@suse.com>
 <Yg5gGenFpAwZqtSW@Air-de-Roger>
 <34dac738-0631-f80c-a3db-7367e37ec0b9@suse.com>
 <Yg5urE+rpOQGWiH9@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Yg5urE+rpOQGWiH9@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0029.eurprd06.prod.outlook.com
 (2603:10a6:20b:462::18) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e8961105-23c7-4ab2-76c6-08d9f22e3b95
X-MS-TrafficTypeDiagnostic: AS8PR04MB7672:EE_
X-Microsoft-Antispam-PRVS:
	<AS8PR04MB7672F83B91DC61BAC4B6824DB3369@AS8PR04MB7672.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4125;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ln341RwRLbHBCmsmK+vje+0S1LGA0qWYqtOGjZmnsw2//Vj8bRbc5sw3bxWp6F5u2xM7ceHFe6ergZrEccLcsGEwLbd+gXUH8LOKiJLfsl67Yq6oneWulX5ro7vwOnlvrUq0VQdXQmU2y9VRNDC1DDSxhScwWkYy9p8N/QY7ZlqoXdd+eLfFA9IzYmVL5u2UxZwv6rc5dXXcCVXgItHhHNNVs7YT+uwMYaffF8YOoY/wJokITGE6mQg0o90yFaDkN0lw/ehKZp2zcu9PHbVwHg+c07OzyL5EiuctgN1eFvjK4RQNgGjTp0db5LBYORa9lLkT5z+/OVyWWBIxVyp0vL5fAwYfX7kMlGXi1IOwkTQptAiU4y134tIy7CFZrUK7meycNNsKa2Zs3TA1Zeol5QgsMKnWnSka6xWoMExpguj/Zc0TGyDZ9O9nS/qyvR+MpR6ujSgdGZMHasmzLvQzwWIY9pQeEyOPGHsCO0sBkoAGWulLXx4TTpy2TOC1WM9hV9X38Ire8KOemFuSBOlYQXuADbkys2DX4AJ/9JPOufyAsQk8+YYqVRTEJ6LI2KBCupcGCdQ8kWVuuPfYXtw3o7eFJJDerzrLymAdszj+29Y3eD6pOUnkEeosiQz5JBsh3t+ZJSPbgnmCsZspzBxK6/WaWCmG/ivi60/iCykkZk/tEGRvMkwlL+7v+0YWlZBugcYHQVA3Ds0/IylA+adUbT+vuJj8I6OxVf63hz7Q9uWuPc+qx6uXIUGlZUiAzDioX77SAxT0L0ZWkDX5WdT9pP5z4NW8OHmohI0xuMvRYz6aMHX/QmU3omES7lumfrKZnkpmGs1ZAXppTR9hh1tTcw==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(31696002)(36756003)(8676002)(31686004)(54906003)(83380400001)(66556008)(2906002)(5660300002)(6916009)(6506007)(6512007)(53546011)(8936002)(508600001)(6486002)(84970400001)(66946007)(86362001)(186003)(66476007)(4326008)(26005)(2616005)(38100700002)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?ejJvvVdpJr4JTiHMMEgIIlWV3sE6v1gzpgTzxaGM30WX44RfOLXmcUNSS1Uv?=
 =?us-ascii?Q?Eggbofv1+fL51uopzAv+ugIm+FBWXYdd1iD4mSZ8crfyaWSpNlKVG8sfl3B3?=
 =?us-ascii?Q?1ke/+4hnL8QZ9hIKQUbwrX2/qkZk9JVuJLiNFTMC0sMwSFnntGdjil28WV/k?=
 =?us-ascii?Q?5X9okakNWib+a7HxW/+CvIBRKvXcJFFcwAAMirgaLkCPAcHooOduso40/C6E?=
 =?us-ascii?Q?3EzaHbxyN7vDWnOx3gFbVTteMoiq5GuZ302A4XKPt6jT78/O1ErQpnej73XZ?=
 =?us-ascii?Q?ynWDyiEZ1KTWOi2tZsQ5Nr2yD4YHPACqwognEESrS46Xd/huiv1HUW5B8sfZ?=
 =?us-ascii?Q?XTvxXhSit9ZReHGJeWP1oTBzGCWbMrE6tdSbxPHr0+ril8hKib4uoh9Ex0a2?=
 =?us-ascii?Q?2xlmNWNwNqd3aRSdi1kU0PJQsrUULZDRbz1RCaxdQDJ/qiO17WEHKIimd6+3?=
 =?us-ascii?Q?45ggjpWnNPwpE396TK7s3gpLYXV14hlPFVXPfzB00BVUboLtllCD/OzRpMSJ?=
 =?us-ascii?Q?kbmkp4lYBjpPjeo61k7DscCMB+ogbzlpZ7jutrXZ9Nqi+7cMP5q50Ln4Zsj4?=
 =?us-ascii?Q?vW/61xzSYVDGAOcjQjNZA3a9ili0I+V+2a4k0tlglEFPvQnO9uGI+cNfXkEm?=
 =?us-ascii?Q?exgKFNmBubwpgt6nOUayRvDdBmgo/4fWK+csZnvgbTE+/9bBjv13L6yFM5y1?=
 =?us-ascii?Q?4QiMpkCXbqwyexZVeTxFq5EbrTn87IXwyRdxCN3Wan62NCFX1LhcfI2g1WbW?=
 =?us-ascii?Q?tYc/vsQgbw05W5sp29SCHS1e6510EuayjHFa6vbeO5lKDxbrRfRuEIqpM24N?=
 =?us-ascii?Q?wykSLDGad7yJCKTx4IW5ctWE2j+sYyZ0Ebbo9o2atVfnrDGiagD+6auEE/Y6?=
 =?us-ascii?Q?xOAJCp7rHVcS0IyR6N98Q9AoAi0SsXe9PQwtQz/tsrhTM+9uR3cLw9Xr/Aju?=
 =?us-ascii?Q?mK7pyYuBlX7YBw/QuhgOgRUaZ8nJS4xMpXHredrvsRrORC9EcSnictdx4u5T?=
 =?us-ascii?Q?1Y1wa5G06SlanLva8EzzHyDYHCgX97cIXQjaIb9e3lFqKNRCNkU/zMFCW83+?=
 =?us-ascii?Q?RF5ssO5X9Sjh3xyHFv1wJwgaIz9SIXsxOrzbHB6EFbQZIQrIZ7N6fNJa+mR9?=
 =?us-ascii?Q?+AfNh5yNhZLmIFjlS2vp0AVMALNTVU41llkBsWWw344xIXBTgOd5uCq65C4E?=
 =?us-ascii?Q?ln06W6QutJQAQ56nS+qbdNSlXnjSgtOoBPRdL3wuqOU8OLtq1+t5nGKfuVjp?=
 =?us-ascii?Q?Xc/lEA75k8yFkrhtv3UoxqEd/j7r7VYkdhUrZDHy2pWjp8BMxnbogx0DiN+T?=
 =?us-ascii?Q?JW2/uXSIfjQy7IpLZtgBPtvTaBW2ANXKvnLOC6FfggsNUl4rIP50AhDuW7rZ?=
 =?us-ascii?Q?OhNo9CquDUviqgwC0C4KgUUvFZ1zJ6olUe4ncWA28NGsVcIdYFuh3eZPYedm?=
 =?us-ascii?Q?j9Zzjt4J8TbzDj7lFIRlafxzduEFzf/UKeto9iR3IYsI1WUQZ3uzzYHNYBAh?=
 =?us-ascii?Q?nOhuNPdGmX9IO39M3MMXLS5NKoUeXv80ds+2u9Cp8Bzbjjelj3CO/P6xAoBz?=
 =?us-ascii?Q?eEmZxiMgI0MVq069VEN6YZWhmV16jJimZOIdKbbKHQBuGQ+IqsA6Afgzrwf8?=
 =?us-ascii?Q?sqcX14CnYSQo5/2WLbuoYkY=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e8961105-23c7-4ab2-76c6-08d9f22e3b95
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2022 15:57:43.4516
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UQcYCuMdxPa6NHP7JQ6nSOwuoTHc2AJl2G45jHUfgWGAV1HsgZznmZ5BRhGh7wyorEDBC+w/RamkclP+ga94/g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7672

On 17.02.2022 16:50, Roger Pau Monn=C3=A9 wrote:
> On Thu, Feb 17, 2022 at 04:02:39PM +0100, Jan Beulich wrote:
>> On 17.02.2022 15:47, Roger Pau Monn=C3=A9 wrote:
>>> On Thu, Feb 17, 2022 at 12:01:08PM +0100, Jan Beulich wrote:
>>>> --- a/xen/drivers/video/vga.c
>>>> +++ b/xen/drivers/video/vga.c
>>>> @@ -79,7 +79,7 @@ void __init video_init(void)
>>>>      {
>>>>      case XEN_VGATYPE_TEXT_MODE_3:
>>>>          if ( page_is_ram_type(paddr_to_pfn(0xB8000), RAM_TYPE_CONVENT=
IONAL) ||
>>>> -             ((video =3D ioremap(0xB8000, 0x8000)) =3D=3D NULL) )
>>>> +             ((video =3D ioremap_wc(0xB8000, 0x8000)) =3D=3D NULL) )
>>>>              return;
>>>>          outw(0x200a, 0x3d4); /* disable cursor */
>>>>          columns =3D vga_console_info.u.text_mode_3.columns;
>>>> @@ -164,7 +164,11 @@ void __init video_endboot(void)
>>>>      {
>>>>      case XEN_VGATYPE_TEXT_MODE_3:
>>>>          if ( !vgacon_keep )
>>>> +        {
>>>>              memset(video, 0, columns * lines * 2);
>>>> +            iounmap(video);
>>>> +            video =3D ZERO_BLOCK_PTR;
>>>> +        }
>>>>          break;
>>>>      case XEN_VGATYPE_VESA_LFB:
>>>>      case XEN_VGATYPE_EFI_LFB:
>>>
>>> I think in vesa_endboot you also need to iounmap the framebuffer
>>> iomem?
>>
>> Again part of the full series. I guess I was a little inconsistent
>> with leaving the VGA unmap in here, but breaking out the VESA part.
>> It's been a long time, but I guess I did so because the VESA part
>> needs to touch two files.
>=20
> I think you are hesitant to include the chunks for the above items? (or
> maybe I'm not properly accounting for their complexity).

There's no complexity, it's really just that the zapping of the pointer
needs to be done in a different place from where the unmap is. See below.

Jan

video/vesa: unmap frame buffer when relinquishing console

There's no point in keeping the VA space occupied when no further output
will occur.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- unstable.orig/xen/drivers/video/lfb.c
+++ unstable/xen/drivers/video/lfb.c
@@ -168,4 +168,5 @@ void lfb_free(void)
     xfree(lfb.lbuf);
     xfree(lfb.text_buf);
     xfree(lfb.line_len);
+    lfb.lfbp.lfb =3D ZERO_BLOCK_PTR;
 }
--- unstable.orig/xen/drivers/video/vesa.c
+++ unstable/xen/drivers/video/vesa.c
@@ -197,5 +197,7 @@ void __init vesa_endboot(bool_t keep)
                    vlfb_info.width * bpp);
         lfb_flush();
         lfb_free();
+        iounmap(lfb);
+        lfb =3D ZERO_BLOCK_PTR;
     }
 }



From xen-devel-bounces@lists.xenproject.org Thu Feb 17 15:58:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 17 Feb 2022 15:58:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274880.470499 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKjB9-0007Jw-BW; Thu, 17 Feb 2022 15:58:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274880.470499; Thu, 17 Feb 2022 15:58:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKjB9-0007Jp-80; Thu, 17 Feb 2022 15:58:47 +0000
Received: by outflank-mailman (input) for mailman id 274880;
 Thu, 17 Feb 2022 15:58:45 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mzVd=TA=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nKjB7-00078y-9a
 for xen-devel@lists.xenproject.org; Thu, 17 Feb 2022 15:58:45 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7a100682-900a-11ec-8eb8-a37418f5ba1a;
 Thu, 17 Feb 2022 16:58:43 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7a100682-900a-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645113523;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=7vDmYNMG7ZomJStg1puDXZbYX7r23zfLVP7LyhkGS+8=;
  b=FPPTAsnHmGgzaORvrrKjHSe9zGvMcuT1uin66b42BKgRH13gn+Jjt4ao
   Ets0XdVWWTjDm7cklTHCdSzzgIbXHF+F2WSVGx6SolemVzstRcGJuGEZ2
   4a2xBYuLRAfwSJfza6Iuvp4Y65sQIZV3rd949fZi8OoRLALkoBgQw67/m
   s=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: aVbdd8Cqg1GvyoqlbC0TBHxYVYiDqzEhtzAFShveLdnnQXY+sBbSDx7OnwyLUtBFCFulGGUJ6q
 wWU+gGmLFTAGKmDAZ5BUYC5DWdOtJj+rDsjv8M/DzDVntjrYxKt7CDKeSPPfZc4KkG9L0/oh5l
 y84AATyktHWj9puG+PEZULaNUuE1jjKU84MatIVeRll7sAlzMtdYeUS1ekdcXScOgaOuFWcLO7
 wkiT91iCyWd6uQMNx5g8XSHdPVGWtn3Ebh9y3IL383HfXtksZAhJ/U+txwxFaxJeA0NwvjjvA8
 urwCxGLutKl43mOmzsO0kTAH
X-SBRS: 5.1
X-MesageID: 66687161
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Wj7mjaocTefr5xGdmxvVGHKNcbVeBmK4YhIvgKrLsJaIsI4StFCzt
 garIBnTa/mKNDanfoglbNu1oBgDvpHXnNZqG1c/pHg0FyNEpJuZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlZT4vE2xbuKU5NTsY0idfic5Dndx4f5fs7Rh2NQw24HmW1nlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCnd+oVhoHbr3doc82AjgETAtCI5QB+ZaSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFIoZpnFnyyCfFfs8SIrPa67L+cVZzHE7gcUm8fP2O
 ZRHOWU2Mk2ojxtnYQcJK8xjjt2S3niuS21b9UKQvIZqyj2GpOB2+Oe0a4eEEjCQfu1Kmm6Iq
 2SA+H72ajkkM9iYxSuA42ibrObFliPmW6ofDLS9sPVthTW7zGEJFAcfU1f9pPCjk1O/QPpWM
 UlS8S0rxYAw/kG2Stj2XzWjvWWJ+BUbXrJ4A+A8rQ2A1KfQywKYHXQfCC5MbsQ8s807TiBs0
 UWG9/vrGDhuvbu9WX+bsLCOoluaIjMJJGUPYSsFSwot4NT5pow3yBXVQb5e/LWd14OvX2uqm
 nbT8XZ41+57YdM3O7uTvkjYnhz8tonwZSVkx1mIdF6710R4TdvwD2C30mTz4fFFJYefa1COu
 nkYhsSThNwz4YGxeD+lG7tUQuzwjxqRGHiF2AM0QcF9n9i40yP7JehtDCdCyFCF2yruURvge
 wfttAxY//e/11P6PPYsM+pd5ynHpJUM9OgJtNiIP7KigbArLWdrGR2Cg2bKgAgBd2B2zMkC1
 W+zK5rEMJrjIf0PIMCKb+kcy6Q34Ss12HneQ5v2pzz+j+bDPCXKF+tYawTTBgzc0E9iiF+Km
 zq4H5HXoyizrcWkOnWHmWLtBQtiwYcH6WDe9JUMK7/rzvtOE2A9Ef7BqY7NiKQ+95m5Ytzgp
 ynnMmcBkQKXrSSedW2iNyAyAJuyDM0XhS9qYkQR0aOAhiFLjXCHt/xEKfPavNAPqYRe8BKDZ
 6JUIZreXKUUG2+vFvZ0RcCVkbGOvS+D3WqmVxdJqhBmF3K5bwCWqNLiYCX18ywCUni+ucck+
 uXy3QLHW5sTAQ9lCZ+OOv6oylqwu1kbmf5zABSUcoUCJh20/dg4MTH1g982P9oIdUfJyAyF2
 lvEGhwfv+TM/dM4qYGbmaCeoo61OOJiBU4GTXLD5LO7OHCCrGquyINNSsiSejXZWD+m8amuf
 7wNnfr9LOcGjBBBtI8lS+Rnyqc35t3Oob5Gz1s7QCWXPgrzUr45eyuIx8hCsKFJ14R1gwruV
 xLd4MReNJWIJNjhTAwbKj06Y7nRzvoTgDTTs6g4eR2o+C9t8bObekxOJB3Q2jdFJb54PY55k
 +csvMkat162hhYwa4vUiylV8yKHL2AaUrVhvZYfWde5hg0uw1BEQJrdFi6pv83fN4QSahEnc
 m2Oma7Pp7VA3U6TIXM8GE/E0fdZmZlT6gtBy0UPJgjRl9fI7hPtMMa9Ldjjotxp8yh6
IronPort-HdrOrdr: A9a23:wbASVq0TZM9x+vcvNPQsWwqjBLYkLtp133Aq2lEZdPUzSL3+qy
 nOpoV+6faQsl0ssR4b9exoVJPufZq+z/5ICOsqU4tKNTOO0AHEEGgI1+rf6gylNyri9vNMkY
 dMGpIObeEY1GIK7voSNjPIceod/A==
X-IronPort-AV: E=Sophos;i="5.88,376,1635220800"; 
   d="scan'208";a="66687161"
Date: Thu, 17 Feb 2022 15:58:36 +0000
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, Wei Liu
	<wl@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, "Bertrand
 Marquis" <bertrand.marquis@arm.com>, Roger Pau =?iso-8859-1?Q?Monn=E9?=
	<roger.pau@citrix.com>
Subject: Ping: [XEN PATCH v9 04/30] build: set ALL_OBJS in main Makefile;
 move prelink.o to main Makefile
Message-ID: <Yg5wrGAhJ/+kMPcU@perard.uk.xensource.com>
References: <20220125110103.3527686-1-anthony.perard@citrix.com>
 <20220125110103.3527686-5-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220125110103.3527686-5-anthony.perard@citrix.com>

Hi Julien, Stefano,

This patch has some changes to the Arm makefiles. Could you have a quick
look or ack the changes?

They are some other patches in the series which might want a Arm ack:
- 20/30 build: rework "clean" to clean from the root dir
- 24/30 build: grab common EFI source files in arch specific dir
- 25/30 build: replace $(BASEDIR) by $(objtree)

Cheers.

On Tue, Jan 25, 2022 at 11:00:37AM +0000, Anthony PERARD wrote:
> This is to avoid arch/$arch/Makefile having to recurse into parents
> directories.
> 
> This avoid duplication of the logic to build prelink.o between arches.
> 
> In order to do that, we cut the $(TARGET) target in the main Makefile in
> two, there is a "prepare" phase/target runned before starting to build
> "prelink.o" which will prepare "include/" among other things, then all
> the $(ALL_OBJS) will be generated in order to build "prelink.o" and
> finally $(TARGET) will be generated by calling into "arch/*/" to make
> $(TARGET).
> 
> Now we don't need to prefix $(ALL_OBJS) with $(BASEDIR) as it is now
> only used from the main Makefile. Other changes is to use "$<" instead
> of spelling "prelink.o" in the target "$(TARGET)" in both
> arch/*/Makefile.
> 
> Beside "prelink.o" been at a different location, no other functional
> change intended.
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> ---
> 
>  xen/Makefile          | 12 +++++++++++-
>  xen/Rules.mk          | 13 -------------
>  xen/arch/arm/Makefile | 31 ++++---------------------------
>  xen/arch/arm/Rules.mk |  4 ++++
>  xen/arch/arm/arch.mk  |  2 ++
>  xen/arch/x86/Makefile | 29 ++++++-----------------------
>  xen/arch/x86/arch.mk  |  2 ++
>  xen/build.mk          | 18 ++++++++++++++++++
>  8 files changed, 47 insertions(+), 64 deletions(-)

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Thu Feb 17 16:07:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 17 Feb 2022 16:07:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274888.470510 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKjJ2-0000wl-6J; Thu, 17 Feb 2022 16:06:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274888.470510; Thu, 17 Feb 2022 16:06:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKjJ2-0000we-2G; Thu, 17 Feb 2022 16:06:56 +0000
Received: by outflank-mailman (input) for mailman id 274888;
 Thu, 17 Feb 2022 16:06:55 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=W+1Z=TA=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nKjJ1-0000wY-7D
 for xen-devel@lists.xenproject.org; Thu, 17 Feb 2022 16:06:55 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9d96364e-900b-11ec-8723-dd0c611c5f35;
 Thu, 17 Feb 2022 17:06:53 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9d96364e-900b-11ec-8723-dd0c611c5f35
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645114013;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=ypmZqLLCvaipn6/0EIASn2jU1PCFp3n5XIdOL8ylKdQ=;
  b=QLn0p1eHCNYQ8hdqGv50nBt24c29L8F9fppbjLcN6Uh3ArJapZ0L904u
   6c90N7JxYb69E3xq0UnylhZZj3jMYNfQvZ+hong5wFCafRyhvWX4Uoex/
   YkfDxuCd07EUplnK3thqkM2GpkDLl8vRvBrESdHLp9Sey6K1jFs7didoW
   U=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: iM40Q1ZZXA+4pQJ9wfRrPuTg+kuY25QKWMn5iMU9CgiIvCa3nnXc3Si7k7FRjjaEY8IkiTke40
 fy+JsGQRMPanOPwaMEyeOJkqFc0QFVOiw/yeOgdqPDmnMBOQhtBxmkF8SxVjo+HpRaFqYL9gkd
 e57lJLFTlaXRDLG7otOUfwOMrTQxVElRrpcvFTiIRrSFfMlV9X6/iw3EFFfJ0Aj8CCNRQ0l2y6
 cJp6BFOtFl4A2J6VLZUjJM6Y4Z8+jpB4pmOcEX3Zd4gq68w7kMT3G3qKllggqKttSC9sSBJhn0
 I6MyHGAcnU0/tSfFitmNpkrT
X-SBRS: 5.1
X-MesageID: 64343431
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:DrNUNqPXb6yYzwTvrR1+kMFynXyQoLVcMsEvi/4bfWQNrUp032RUy
 mdOC2jUMq2LMWCkLdhwbYiwpEMG7ZKHy9JgTAto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6UUsxNbVU8En1500s8w7RRbrNA2rBVPSvc4
 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq
 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYozLOvdN84
 uRHj5WxcyYzErDpptYdcDANRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs
 6VFdnZdNXhvhMrvqF6/YsBqit4uM4/AO4QHt2s75TrYEewnUdbIRKCiCdpwgmtr2psSRq+2i
 8wxNDhhYTLkZh51anAJGJ8jt9WVukDkSmgNwL6SjfVuuDWCpOBr65D9PdyQdtGUSMF9mkeDu
 nmA72n/GgsdNtGU1XyC6H3ErvDLtTP2XsQVDrLQ3vxgjUCXx2cTIAYLTlb9qv684nNSQPoGd
 RZSoHB36/Fvqgr7FbERQiFUvlaD+TwfVvBhGdcz6Tus0IbJxjirBkstG2sphMMdiOc6Qjkj1
 1msltzvBCByvLD9dU9x5ot4vhvpZ3FLcDZqiTssCFJcvoK9+N1bYgfnE447eJNZmOEZDt0ZL
 9qiiCElz4segscQv0lQ1QCW2mn8znQlo+Nc2+k2Yo5Hxl8oDGJGT9bxgbQ+0RqmBNzGJrVml
 CJZ8/VyFMhUUfmweNWlGY3h5o2B6fefKyH7ilVyBZQn/DnF0yf9Id0Iu24geBoybZtsldrVj
 Kn741w5CHh7ZibCUEOKS9jpV5RCIVbITrwJqcw4nvIRO8MsJWdrDQllZFKK3nCFraTfufpXB
 HtvSu71VSxyIf0+lFKeHr5BuZd2lnFW7T6CHvjTkkX4uYdykVbIEN/pxnPVNbtnhE5FyS2Im
 +ti2zyikEQFD7OgM3KGqub+7zkidBAGOHw/kOQOHsarKQt6AmAxTfjXxLIqYYt+mKpJ0OzP+
 xmAtoVwljITXFXLdleHbG5NcrTqUcotpH43J3V0b12px2IiccCk66JGL8k7erwu9epCy/9oT
 qZaJ5XcU6oXEjmXqS4AaZTdrZB5cEj5jwy5ICf4MiM0eIRtRlKV94a8LBfv7iQHEgG+qdA6/
 ++7zgreTJdaH1ZiAc/aZeiB1VS0uXRByut+U1GReotYeVn28ZgsICv016dlL8YJIBTF5z2by
 wfJXktI+biT+9c4qYCbi7qFooGlF/pFMnBbR2SLv6yrMST6/3a4xdMSWui/Yj2ABnj//7+vZ
 LsJwqikYuEHhltDr6F1D61vkfAl/9LqqrJXklZkEXHMYwj5A79sOCDbj8xGt6kLzb5FowqmH
 EmI/4ACa7mOPcrkFn8XJRYkMbvfha1FxGGK4KRnOlj+6Q924KGDABdbMBS7gSBAKKd4bdE+y
 uA7tc9KswGyh3LG6DpdYvy4I4hUEkE9bg==
IronPort-HdrOrdr: A9a23:r1zu2a/oqF4nbyLOUaluk+F8db1zdoMgy1knxilNoENuHfBwxv
 rDoB1E73LJYW4qKQwdcdDpAtjkfZtFnaQFr7X5To3SIDUO31HYbb2KjLGSjAEIfheRygcz79
 YYT0ETMqySMbE+t7eB3ODaKadh/DDkytHRuQ629R4EJmsKC52IrT0JcTpzencGHjWubqBJcK
 Z0k/A3wQZIDk5nCfhTaEN1PdTrlpnurtbLcBQGDxko5E2lljWz8oP3FBCew1M3Ty5P6a1Kyx
 mHryXJooGY992rwB7V0GHeq75MnsH699dFDMuQzuAINzTXjBqybogJYczBgNl1mpDr1L8Zqq
 iKn/4SBbU015oXRBDtnfLZ4Xil7N/p0Q679bbXuwq5nSWzfkNENyMIv/MmTvKe0Tt8gDg06t
 M644rS3aAnfC/ojWDz4cPFWAptkVfxqX0+kfQLh3gaSocGbqRNxLZvtn+9Pa1wVB4S0rpXW9
 WGzfuskMp+YBefdTTUr2NvyNujUjA6GQqHWFELvoiQ3yJNlH50wkMEzIhH901wuK4VWt1B/a
 DJI65onLZBQosfar98Hv4IRY+yBnbWSRzBPWqOKRDsFb0BOXjKt5nriY9Fqd2CadgN1t8/iZ
 7BWFRXuSo7fF/vE9SH2NlR/hXEUAyGLH3QIwFllu5EU5HHNcjW2By4OScTepGb0oYi6+XgKo
 OOBK4=
X-IronPort-AV: E=Sophos;i="5.88,376,1635220800"; 
   d="scan'208";a="64343431"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=nMhuMzJVwavUTu+gFfH4hNxeQlYpaMkJrowBOsj06dubc5gmoXdy/ArspUKIFZdeRk++m/aKRtaopKEQ+V604tbgJ+uq5vH1hC9MgrlqMIGKld9vNLc2fxeresVqK7OBZaQ0cULIXKc/dCqEWPVZL9EY8XZ7QfsO+drxStJ84xJoiGhvH+NspWlPrwq9omSWWnnMJxNEZcM/4mZ2kHcyLXm4gOFharUExkrjziwvh7fyjkAIWPW6QxIgT/moDLe1/HAXLUpJcrTGvhr1oujcSlM3oiPn2dkCVeSp+O5A9VKc9aeM/XJnoYkZa3EpBTCiOOflmabRp9f0XhgiSuFK3A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ypmZqLLCvaipn6/0EIASn2jU1PCFp3n5XIdOL8ylKdQ=;
 b=MvllHHb8u27NuvAVx5f6gXMWrl3IT4tMwlqa170YnwM1tKYZvZW4vIh/Si/NduZu7TyEEXEk4TVHRMbTHUDUjmi2ir6sYjcV/c8jg7wmu+CbmNVr238I4UpiVa4oI6XcwvtlMUGNVOJVsIZNOUrg6EjGf0O39nDe4lUZ3QRziqrTbkLv5regdYNgEcdM+FAAVrrNpkm+dz++hRwX6q+eYS7lAdSnwTskkoLOQAfuu/SESrziZOGcWFix+c/aKj1rVqttSLGSwa4zhKABVR05zNQlbv2vMraeEykoEQIiixtn8vomcUXO5NI0dNCnXKyw/NgFLmjjQqDsBx8cIKLVqQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ypmZqLLCvaipn6/0EIASn2jU1PCFp3n5XIdOL8ylKdQ=;
 b=Dw8p2Pe0w+qG9jVAt6qOYjttrc9ZGdTv1PT1+Gq0sc1iwvfhn8pHtoVy/wcXr9tK7dnwYKztl4p9Ioc3PIVLaIEmWJTX1vAfn67RrPgHN27lkQrftwqXlrsjAv5fTp8j5tW4hCQWs2gAYQEoWzk6wGQcAbQTYZLpU6cbpjLlWBw=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>, Xen-devel
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2.1 6.5/70] x86/kexec: Annotate embedded data with ELF
 metadata
Thread-Topic: [PATCH v2.1 6.5/70] x86/kexec: Annotate embedded data with ELF
 metadata
Thread-Index: AQHYI+WIB3ag8ccQV0mMbUcu9Q8VKKyXjjSAgAAXo4CAAC0dgIAAFfaA
Date: Thu, 17 Feb 2022 16:06:44 +0000
Message-ID: <19446d4d-b4ee-e26c-10b1-b2c49a1950ad@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
 <20220217100158.22402-1-andrew.cooper3@citrix.com>
 <4e9924f7-fdfa-c3c3-7b6c-e5cbe77ff9ac@suse.com>
 <826c97dd-dda9-b6c2-37bf-451354fcfde2@citrix.com>
 <e35ca83f-12ad-0c28-075b-82ff08b2bf1d@suse.com>
In-Reply-To: <e35ca83f-12ad-0c28-075b-82ff08b2bf1d@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 1e3eb858-7560-496a-01f7-08d9f22f7e76
x-ms-traffictypediagnostic: BN7PR03MB3604:EE_
x-microsoft-antispam-prvs: <BN7PR03MB36040769F60DFF809B82832EBA369@BN7PR03MB3604.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: vpd9HVp8oAbzrTFlOahCPrErJGmp4EkmSKVeql/F41/Wvg8qBjvmEUgM2mkRex3aXPvburAr687+nB5fICpwOyEa4cXOM6tr2ytAsVXI5s2s5EutcVYSCKaByMoxTwomWJYUWDUYkRo/oWrMMq6dIax2tAcGEjkVrKdpCoQmuBgzDjTt8MExydVSsIQLmPe/iTWbt7MPblZdP7iakRCoAD64zMM5v/ziID1sFDwAD6ZooHgxkk8SijLZl6xuxHg1HpaNPwxxtMQAiecwNly1wkc14AOZ0iGq0seSVakgrLz8HBxEJIjLvWk+zkxwBl/ZB5BMHVIgBGhe/EWLGlLwfGA3tI6IKTYXasNwjG87mClHNy5qVocEhCrafBR+hMvCEx0/ZmlnmkWt4G3hqPKnqhxP8wRPwnR6C4kG52QD1+gi8rn5qEIvaP+Eranjez4tgHIm20jdZ6lz56KQ4jqmW8csz+KMTkE5W8dMWOIdq54HgdjrxrHIzCxQI0bFoHBxWkD5QPlfFu+7ipBrA5dZQMJ6fxSbBn5M230m8TCXxXY2MWs7LP+ftCLQ7phTI9Lv59UPUonW7M3luu1nuzsr/MMKn0RULArLfXi+NhqvakR98m0azjFgsRlL7D9jbj1/6cnSLMRy8DY724eaUm9Q/MkSZ0tJrYNqaIL/1060nlpnugzwIXejKvgCJ/i/nAOTUtfbch9a3AKmKsUDTQsFetbenhf+sk1hAOe1rkI/qwcPfvoFIF/gGfQKmijehnRyomxNjWTISTyWIkgOqJsVxw==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(186003)(38070700005)(122000001)(6506007)(2616005)(6486002)(53546011)(71200400001)(508600001)(38100700002)(31696002)(4326008)(6512007)(83380400001)(82960400001)(86362001)(8676002)(2906002)(31686004)(36756003)(316002)(76116006)(8936002)(66946007)(66556008)(66476007)(6916009)(64756008)(66446008)(54906003)(26005)(91956017)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?eVVZZVQvQ3pGR2M1TnZ1MXhEeklWK0ZWSVI4SGdXQ0JTc0xxYWwyQTBtR1pF?=
 =?utf-8?B?bW4rQitsa3dhQnAra3pTSXgxQnppbDA2dm9IUGoyM3VQK1hjb2ZnUW1tVWdB?=
 =?utf-8?B?Y3lhemVsUVNJUDlRVGpRRGZGZTc5aHVwcjRxdmZicFkzWGF3SzJ3NHVWMXM3?=
 =?utf-8?B?QUhyRVpkLzFxL2lvRzltc2djeVpBV0o4bGVoUE8xSENadjBhendzRk9udmpn?=
 =?utf-8?B?VzdCQm5UNFNGYzUvMUVqejlhRWd1QjFlZTFBNEFPRWtoazJSRDdaelF4YVNz?=
 =?utf-8?B?d0VZdlArODUrMTJDanp5QkNIS2RxenloTk83akVGTkZ6L21HQldZZ1FuNGFs?=
 =?utf-8?B?R2JFS1FKekpuRGhhaEduU0Y2cTB2c2ROdFJTMUR0T3dsYVhScVdjVENQVGZT?=
 =?utf-8?B?bFdXc01aLzMzQjRUeERucGg1Unc3VjUzdHYzZzRlczBGY1RYK2llRWx1Sklm?=
 =?utf-8?B?VHVCUjh5K0p3TW5DWE81Qkk3N2h2aXdCMW44ZERtQSt1M2M4WXZySEg0a2FX?=
 =?utf-8?B?SWZvcmRGTmpwUWtVYTloYm11VzM4ekRBbEphYTlJeTREemtaajY4MFdzUWRG?=
 =?utf-8?B?UUgxOFFkMitoa212RU1ieThleGRibTVnb0lUV0lITE9yRlRIazhDMHZVSHdI?=
 =?utf-8?B?b1pWQVpFZVpaYmxIdWphMFkwakFSakpYVkhJN3NTdndIZ0RSNmpPRUpCMmNN?=
 =?utf-8?B?aXRhNVZuc1QvUjgrQjVFZjM3cHkxaHlpaGI2NVY3VzVzbWhDUlVERWhXUlpm?=
 =?utf-8?B?ZkdwTDVJQjdvVmlUVGxudDhFaFRmQld1S2pjeHFPNDB5c0VBUUZaT0Z1bEwz?=
 =?utf-8?B?SVlZUmhXcHJPVEtVZ0FEV1lLTEU2NE9Reld6NFhnTUtVQ24yUjR3amtJR2xi?=
 =?utf-8?B?b2ZHdTR2ZE9VWjJRSG9sZXBiVHBRRHpHMnI5M09VVEl5MVR1RU1URlYydVNQ?=
 =?utf-8?B?cjFLQnF4MUk1enRBNllzM1VZNDVOSlBrdEIwWWNqc2hTL3o1RDdlQ2xwZTJq?=
 =?utf-8?B?UDNwSTd4b2M4VmoxSG40NjRNL1lsbXJWQ3E1eTZnQ3cyK0oxbUs4MHFudUs5?=
 =?utf-8?B?cVQrdGNpNEc4QSt1dnZUYzBwNWR1N3FPVmNvTzlBcDRYVC9ZMktoSFljSURH?=
 =?utf-8?B?dmN4eE0zWjBOZUYwRUZjSVJFeHp3QlY2T2o1bldhUjZ3UE9VL0ZRamdRVk5I?=
 =?utf-8?B?Z3FzRjFadzlDYlVWRUlkRWF4eFZneUdmWENZRmRTMStSUnh2NVAyVlRaZEE1?=
 =?utf-8?B?RnlDc3ZlYlVzbnJiSFJvM0JBS2FubkVrVCtEcGJ6YzRPODcwZ2I4V1Q1YU1s?=
 =?utf-8?B?ei8xYXo1bklZR3plOTdNbVZLa0dja3BoSnBHNkNhOWQycThTNlNDN0t0Z1lS?=
 =?utf-8?B?blhyL25mMHllSmJibmlDcnBFRzF1VHZxd1JzWk96dTQybWVYRnJ2eDM0UUw1?=
 =?utf-8?B?cVdMS2dhRVFMdXErVzZ3blNaSlJwSmFTUnBJVDBEdHBwcHI1OTA1OEpkSUs2?=
 =?utf-8?B?clRVc3FoMXp3Q2R2dE4vdU5pNGIrd2VaV3pTemhEVVJjUTRaYU5nS24vb2lS?=
 =?utf-8?B?ZWlVNVVQTVg2T2thNktNU3hnaktkcWN0dGxGTWdCSndJQ05TZHFtb3IrZWJ0?=
 =?utf-8?B?eGliY25IRnVWd2grRGkrWmZuRE9HWkJOMkZLVWxmVm9PQ3AvUVVZUkNhODBq?=
 =?utf-8?B?UTVkMUZlQ0phYUdQOWJhU3VJeklaeVRXMHFKVGt5M2NNK0tNSmF6bEkrZEdL?=
 =?utf-8?B?WXZxQWFKR0kwSzY0c01HL29VVXhkNW1yZUFlR3Z3MlBIYkJxaGptYWNVcWxD?=
 =?utf-8?B?eERGeUVWNjNnMEd0dmhmNXJCcDRTL09WY0N2NXlNREp3YmhlZnlpYm1CRXRS?=
 =?utf-8?B?ZnQ4UXdGakNxWFdqVkdWamloZEl4OE9zeHhoL1FLTnlGRysyQ0hqR2xmYTRy?=
 =?utf-8?B?amZKTGFQeW9aQWRqTmZPVDNCSEF3SGNOMW5vdlFEOEpMT3Z1MmhFanIxeGxT?=
 =?utf-8?B?VGNCY1JvbmM3d2lpd1B5bHNOTWJCb1JpSUQ3c2dJNkdhdTA2VEZLMk5oMWhp?=
 =?utf-8?B?N3BLZFBnaE92K1AxUVQ3bXBzVjJtRmtva3Jic3daeUNjbWpNNWZ2aUY1UGk5?=
 =?utf-8?B?aE9lcDV4TVF6NVlUS3J4bVRPZ3dSU0FvWXF3UEx3VnJLYy9LeUt5Z0ZTRGZ1?=
 =?utf-8?B?eTBxeit4TitvZFo4VXJuZkZCaUE4NXpJeVRyTmdCTXdIV2JVQ1hNNDlLNmsv?=
 =?utf-8?B?NTcrWWpZd01UV2l4dG1odkc0UDZBPT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <2529C01C7422BB49ABE43A7C7180ABE9@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1e3eb858-7560-496a-01f7-08d9f22f7e76
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Feb 2022 16:06:44.7746
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: NWh/VT+PYewj4o1BqBgtFlhTEoZkh50IxVvN+IXaA6SqI7oZHeA8TagWhycXn52RMiBb7WvBPiQnq19dxbbiw/7IFVjIYUALbqrDCJj3NTA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB3604
X-OriginatorOrg: citrix.com

T24gMTcvMDIvMjAyMiAxNDo0OCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDE3LjAyLjIwMjIg
MTM6MDYsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBPbiAxNy8wMi8yMDIyIDEwOjQyLCBKYW4g
QmV1bGljaCB3cm90ZToNCj4+PiBPbiAxNy4wMi4yMDIyIDExOjAxLCBBbmRyZXcgQ29vcGVyIHdy
b3RlOg0KPj4+PiBTY2FubmluZyBmb3IgZW1iZWRkZWQgZW5kYnJhbmNoIGluc3RydWN0aW9ucyBp
bnZvbHZlcyBwYXJzaW5nIHRoZSAudGV4dA0KPj4+PiBkaXNhc3NlbWJseS4gIERhdGEgaW4gdGhl
IGtleGVjIHRyYW1wb2xpbmUgaGFzIG5vIEVMRiBtZXRhZGF0YSwgc28gb2JqZHVtcA0KPj4+PiB0
cmVhdHMgaXQgYXMgaW5zdHJ1Y3Rpb25zIGFuZCB0cmllcyB0byBkaXNhc3NlbWJsZS4gIENvbnZl
cnQ6DQo+Pj4+DQo+Pj4+ICAgZmZmZjgyZDA0MDM5NjEwOCA8Y29tcGF0aWJpbGl0eV9tb2RlX2Zh
cj46DQo+Pj4gV2hhdCBhYm91dCB0aGUgKHBvc3NpYmxlKSBwYWRkaW5nIGFoZWFkIG9mIHRoaXM/
IFNob3VsZCB0aGUgLmFsaWduDQo+Pj4gdGhlcmUgcGVyaGFwcyBzcGVjaWZ5IGEgZmlsbGVyIGNo
YXJhY3Rlcj8NCj4+IFdoYXQgYWJvdXQgaXQ/wqAgSXQncyBqdXN0IGxvbmcgbm9wcyBsaWtlIGFs
bCBvdGhlciBwYWRkaW5nIGluIC50ZXh0DQo+Pg0KPj4gZmZmZjgyZDA0MDM5NjEwMTrCoMKgwqDC
oMKgwqAgZmYgZDXCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgY2FsbMKgwqAg
KiVlYnANCj4+IGZmZmY4MmQwNDAzOTYxMDM6wqDCoMKgwqDCoMKgIDBmIDBiwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHVkMsKgwqAgwqANCj4+IGZmZmY4MmQwNDAzOTYxMDU6
wqDCoMKgwqDCoMKgIDBmIDFmIDAwwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIG5vcGzC
oMKgICglZWF4KQ0KPj4NCj4+IGZmZmY4MmQwNDAzOTYxMDggPGNvbXBhdGliaWxpdHlfbW9kZV9m
YXI+Og0KPj4gZmZmZjgyZDA0MDM5NjEwODrCoMKgwqDCoMKgwqAgMDAgMDAgMDAgMDAgMTANCj4+
IDAwwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqAgLi4uLi4uDQo+Pg0KPj4gQW5kIGZvciB0aGlzIHByb2JsZW0sIHdlIGRv
bid0IG5lZWQgdG8gY2FyZSBhYm91dCB0aGUgYmVoYXZpb3VyIG9mIGFueQ0KPj4gcHJlLUNFVCB2
ZXJzaW9uIG9mIGJpbnV0aWxzLg0KPiBJIHdhcyBhYm91dCB0byBhc2ssIGJ1dCB5ZXMgLSB0aGlz
IGlzIGEgZ29vZCBwb2ludC4NCj4NCj4gUmV2aWV3ZWQtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGlj
aEBzdXNlLmNvbT4NCg0KVGhhbmtzLg0KDQo+Pj4gIEl0IGp1c3Qgc28NCj4+PiBoYXBwZW5zIHRo
YXQgdGhlcmUncyBubyA0LWJ5dGUgZ2FwIGJldHdlZW4gY29tcGF0X21vZGVfZ2R0X2Rlc2MgYW5k
DQo+Pj4gY29tcGF0X21vZGVfZ2R0LiBDaGFuZ2luZyB0aGUgLmFsaWduIGFoZWFkIG9mIGNvbXBh
dGliaWxpdHlfbW9kZV9mYXINCj4+PiB3b3VsZCBlbGltaW5hdGUgdGhlIHJpc2sgb2YgcGFkZGlu
ZyBhcHBlYXJpbmcgaWYgdGhlIGNvZGUgZnVydGhlciB1cA0KPj4+IGNoYW5nZWQuDQo+PiBHYXBz
IHdpbGwgYmUgZm9ybWVkIG9mIGxvbmcgbm9wcyBiZWNhdXNlIHdlJ3JlIGluIC50ZXh0LCBhbmQg
dGhleSBtZXJnZQ0KPj4gd2l0aCB0aGUgcHJldmlvdXMgZGF0YSBibG9iIChzZWUgYmVsb3cpLg0K
Pj4NCj4+Pj4gICBmZmZmODJkMDQwMzk2MTM2IDxyZWxvY19zdGFjaz46DQo+Pj4+ICAgICAgICAg
ICAuLi4NCj4+PiBOb3cgdGhpcyBpcyBwYXJ0aWN1bGFybHkgcHV6emxpbmc6IFVzIHNldHRpbmcg
JXJzcCB0byBhbiB1bmFsaWduZWQNCj4+PiBhZGRyZXNzIGlzIGNsZWFybHkgbm90IEFCSS1jb25m
b3JtaW5nLiBTaW5jZSB5b3UncmUgZmlkZGxpbmcgd2l0aA0KPj4+IGFsbCBvZiB0aGlzIGFscmVh
ZHkgYW55d2F5LCBob3cgYWJvdXQgZml4aW5nIHRoaXMgYXQgdGhlIHNhbWUgdGltZT8NCj4+PiBP
ZiBjb3Vyc2UgdGhlcmUgd291bGQgdGhlbiBhcHBlYXIgcGFkZGluZyBhaGVhZCBvZiB0aGUgc3Rh
Y2ssIHVubGVzcw0KPj4+IHRoZSBzdGFjayB3YXMgbW92ZWQgdXAgc29tZS4NCj4+IE9oIC0gSSdk
IG5vdCBldmVuIG5vdGljZWQgdGhhdC7CoCBMdWNraWx5IHRoZXJlIGlzIG5vIEFCSSB3aGljaCBt
YXR0ZXJzLA0KPj4gYmVjYXVzZSBpdCdzIHRoZSBjYWxsL3B1c2gvcG9wJ3MgaW4gdGhpcyBmaWxl
IGFsb25lLg0KPiBBbmQgdGhlIGVudGl0eSB0cmFuc2l0aW9uZWQgdG8gaXMgZm9yYmlkZGVuIHRv
IG1ha2UgdXNlIG9mIG91ciBzdGFjaz8NCg0KVGhlcmUncyBubyBleHBlY3RhdGlvbi9ndWFyYW50
ZWUgb2YgYSBnb29kIHN0YWNrLCBuby7CoCBQdXJnYXRvcnkgaXMgYQ0KdmVyeSBtaW5pbWFsIGVu
dmlyb25tZW50IGJlZm9yZSBpdCBzZXRzIHNvbWV0aGluZyBuZXcgdXAuDQoNCj4+IFdpdGggYW4g
YWxpZ24gOCwgd2UgZ2V0Og0KPj4NCj4+IGZmZmY4MmQwNDAzYTcxMzggPGNvbXBhdF9tb2RlX2lk
dD46DQo+PiBmZmZmODJkMDQwM2E3MTM4OsKgwqDCoMKgwqDCoCAwMCAwMCAwMCAwMCAwMCAwMCA2
Ng0KPj4gOTDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoCAuLi4uLi5mLg0KPj4NCj4+IGZmZmY4MmQwNDAzYTcxNDAgPHJlbG9jX3N0YWNrPjoN
Cj4+IMKgwqDCoMKgwqDCoMKgIC4uLg0KPj4NCj4+IHdoZXJlIHRoZSA2NiA5MCBpbiBjb21wYXRf
bW9kZV9pZHQgaXMgdGhlIHBhZGRpbmcuwqAgUmVjYWxsIGMvcyA5ZmQxODE1NDBjN2U2DQo+Pg0K
Pj4+PiAtLS0gYS94ZW4vYXJjaC94ODYveGVuLmxkcy5TDQo+Pj4+ICsrKyBiL3hlbi9hcmNoL3g4
Ni94ZW4ubGRzLlMNCj4+Pj4gQEAgLTg3LDYgKzg3LDcgQEAgU0VDVElPTlMNCj4+Pj4gICAgICAg
ICAqKC50ZXh0LnVubGlrZWx5KQ0KPj4+PiAgICAgICAgICooLmZpeHVwKQ0KPj4+PiAgICAgICAg
ICooLnRleHQua2V4ZWMpDQo+Pj4+ICsgICAgICAga2V4ZWNfcmVsb2NfZW5kID0gLjsNCj4+PiBE
b2VzIHRoaXMgbWF5YmUgd2FudCBhbGlnbmluZyBvbiBhIDQtIG9yIGV2ZW4gOC1ieXRlIGJvdW5k
YXJ5PyBJZg0KPj4+IHNvLCBpbW8gcHJlZmVyYWJseSBub3QgaGVyZSwgYnV0IGJ5IGFkZGluZyBh
IHRyYWlsaW5nIC5hbGlnbiBpbiB0aGUNCj4+PiAuUyBmaWxlLg0KPj4gVGhlcmUncyBubyBzcGVj
aWFsIG5lZWQgZm9yIGl0IHRvIGJlIGFsaWduZWQsIGFuZCBpdCBpcyBhbnl3YXkgYXMgdGhlDQo+
PiBzdGFjayBpcyB0aGUgbGFzdCBvYmplY3QgaW4gaXQuDQo+IFlvdSBtZWFuIGl0IGFueXdheSB3
b3VsZCBiZSwgaWYgdGhlIHN0YWNrIHdhcyBhbGlnbmVkPyBPciBhbSBJIHRvIGltcGx5DQo+IHRo
YXQgeW91J3ZlIGFtZW5kZWQgdGhlIHBhdGNoIHRvIGFkZCBhbGlnbm1lbnQgdGhlcmU/DQoNCkkg
aGF2ZSBhbGlnbmVkIHJlbG9jX3N0YWNrIHN0YWNrIGJlY2F1c2UgdGhhdCdzIGEgbm8tYnJhaW5l
ci4NCg0KV2l0aCB0aGF0IHN1aXRhYmx5IGFsaWduZWQsIGtleGVjX3JlbG9jX2VuZCBiZWNvbWVz
IGFsaWduZWQgbmF0dXJhbGx5DQooYmVjYXVzZSByZWxvY19zdGFjayBpcyB0aGUgZmluYWwgb2Jq
ZWN0KSwgYW5kIEkgZG9uJ3QgdGhpbmsgdGhlcmUncw0KbXVjaCBwb2ludCBwdXR0aW5nIGFueXRo
aW5nIGV4cGxpY2l0IGluIHRoZSBsaW5rZXIgc2NyaXB0Lg0KDQpJdCBkb2Vzbid0IG1hdHRlciBp
ZiBzdWJzZXF1ZW50IHRoaW5ncyBmb2xsb3cgaW1tZWRpYXRlbHksIGJlY2F1c2UgdGhpcw0KdHJh
bXBvbGluZSBpcyBjb3BpZWQgaW50byB0aGUga2V4ZWMgcmVnaW9uIGJlZm9yZSBiZWluZyB1c2Vk
LsKgIEluDQpwcmFjdGljZSwgdGhlIHRoaW5nIGltbWVkaWF0ZWx5IGZvbGxvd2luZyBpdCBpcyAu
aW5pdC50ZXh0Lg0KDQp+QW5kcmV3DQo=


From xen-devel-bounces@lists.xenproject.org Thu Feb 17 16:08:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 17 Feb 2022 16:08:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274896.470521 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKjKY-0001aZ-K5; Thu, 17 Feb 2022 16:08:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274896.470521; Thu, 17 Feb 2022 16:08:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKjKY-0001aS-Gy; Thu, 17 Feb 2022 16:08:30 +0000
Received: by outflank-mailman (input) for mailman id 274896;
 Thu, 17 Feb 2022 16:08:29 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=XMIn=TA=citrix.com=George.Dunlap@srs-se1.protection.inumbo.net>)
 id 1nKjKX-0001aM-PZ
 for xen-devel@lists.xenproject.org; Thu, 17 Feb 2022 16:08:29 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d7387440-900b-11ec-8723-dd0c611c5f35;
 Thu, 17 Feb 2022 17:08:28 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d7387440-900b-11ec-8723-dd0c611c5f35
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645114108;
  h=from:to:subject:date:message-id:mime-version;
  bh=RmBp639xehp6cT+ykyShG7v72VHO8G5flXGbV46chEs=;
  b=F/Ph9FfoBj4rjkqdBVedRyFN5dazHvu7ixxX3inNrBFM7AiSxX12VpPD
   Hqf/oSExRHIrNADx+W0YU+i0DcTy/8spzG7d8VsdbWStusq5iM7CTRABW
   1CHQAlyYD2Jp1Qnh/INShQQASe2lfCcNg2DTZiCH2Anhr/pqDj1qh4RAy
   c=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=hardfail (body hash did not verify [final]) header.i=@citrix.onmicrosoft.com
IronPort-SDR: I108lmZPzsbjd9zaIPWvS6hZS3WlFyKQbd5AwFYTo+khcnETuTAeLm4IsY/uNDaX8tX4WurdKn
 Pchee9tnWzsI4O972Zq1YtjgVbQqKNYTq7y5NubG3rJ5gGhhoIwiKTtBRDB3zRX4Cwl0NtHF3t
 WwpdpeAe3v9wAXPCSaskRjtMWxWVh8AJkowlC8MgDrsduAnz7x+Y25pI2WEor+SIYCmCIHI1hq
 JxFroFTAEM6uRG6s37fx2fgGDDgWxa4Nfwg7Y1LHyix4d8Lf/buFPM7kNK1fV+ROcNkLpCrEQy
 0YZrKN9CD7/rLLafEwpcUJAo
X-SBRS: 5.1
X-MesageID: 64343614
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:NMC5/KlD+NMOScMfA8/ZK//o5gwqIURdPkR7XQ2eYbSJt16W5oA//
 9YtKSrfbaHbJie3LscnK96GQXl27ZaExodrTQVk+X02RnlA8MaaWY/Hfk2uMynCI5ydEExq5
 Z4UNdSecJloQHGHr0r1YrS+9nR2iP+CF7GsVOCYN0idKeMcpAIJ0HqPzMZl0t4AbaGFPj6wV
 fPOT+z3YQerhGQuPD5N4aiN9kM25qiu4GpCs1VkbKlG5A+FyyVEUJ5HKa+PdHapGYM88sxW5
 grgIBNV2kuDon/B3/v8yu6TnnXnxtc+BCDW4pZsc/HKbiNq+2pigs7XCNJGMR0N02/QwIgro
 DlwncfYpTkBb/WkdNs1C3G0IwkmVUGR0OaaSZQXmZX7I3zuKxMA8d03ZK0FFdRwFtJMKXNP7
 ZQlxAUlNXhvsQ4ULIWTEYGAjux7RCXi0Rh2VntIlVk1Bt5+KXzPrjmjCXa1E17ci+gXdcsya
 fb1ZhJwXSbaXw9zZGsUEagvjMKPnX7Sd21X/Qf9SaofuwA/zSR02bnpdtHUZsaLVYNemUPwS
 mDupjqjREtAbZrGlGTDoinEauznxEsXXKo9Gbqi+fMsrECVwmULIBYXSUG6sb+yjUvWt9d3d
 RBPpnFw9PRaGEqDEf/TU0PkplK4hxNfa51ITcoA8waq8/+Bi+qeLjddFWMQADA8j+cmSDpv2
 lKXktfBAT10rKbTWX+b7q2Trz65JW4SN2BqWMMfZVJbuZ+5+th110+RCIY4eEKosjHrMS7B8
 Sq2vhRgu7YKt98b8oKg+n3D0z358/AlUTUJzgnQW2uk6CZwa4ike5Gk5DDn0BpQEGqKZgLf5
 SZZwqBy+MhLVMjQz3LVHI3hCZn0v67tDdHKvbJ483DNHRyJ8mXrQ41f6SoWyKxBYpddIm+Bj
 KM+VGpsCH5v0JmCMf4fj2GZUZ1CIU3c+TLNDK+8gj1mOMUZSeN/1HsyDXN8Jki0+KTWrYkxO
 I2AbeGnBmsABKJswVKeHrlBjOdwmX5imDiMGPgXKihLN5LEOxZ5rp9fbTOzgh0RtvvY8G05D
 f4EXyd19/mveLKnOXSGmWLiBVsLMWI6FfjLRz9/LYa+zv5dMDh5UZf5mOp5E6Q8xvg9vrqYr
 xmVBx4DoHKi1CKvFOl/Qi06AF8Zdc0k9ixT0O1FFQvA5kXPlq70vf1AKcVmJuh8nAGhpNYtJ
 8Q4lwy7KqknYhzM+igHbIm7q4pndR+xghmJMTbjaz86F6OMjSSQkjM9VgewpiQIEAStss4y/
 ++p2g/BGMJRTAV+FsfGLvmoygrp73QanetzWWrOI8VSJxqwoNQ7dXSpg69lOdwIJDXC2iCei
 1ScDyAHqLSfuIQy6tTI2/yJ9t/7D+tkE0NGNGDH9rLqZzLC92+uzNYYAuaFdDzQTk3u/6Cma
 bkHxv3wKqRfzl1Lr5B9A/Bgyqdnv4njoLpTzwJFGnTXbgv0VuM8cyfehcQW7/9D3L5UvweyS
 3mjwNgCNOXbIt7hHX4QOBEhMraJ28YLl2SA9v8yOkj7unN6peLVTUVIMhCQoyVBN78pYpg9y
 OIstcNKuQyyjh0mboSPgixOrjneK3UBV+Mst40AAZ+tgQ0ukwkQbZvZAy7wwZeOd9QTbRV6f
 m7K3PLP1+ZG207PU3svDnycj+NSiKMHtA1O0FJfdU+CncDIh6Nv0RBcmdjtot+5EvmTPzpPB
 1VW
IronPort-HdrOrdr: A9a23:ttM0n6yT/EfMx9OX3SwQKrPxqOskLtp133Aq2lEZdPULSKOlfp
 GV8MjziyWYtN9IYgBZpTnyAtj6fZq8z+8+3WB1B9mftWbdyQ2Vxe1ZnOjfKl7bamDDH4xmpN
 5dmsFFYbWaZzkbsS+T2nj+Lz9K+qjjzEncv5a4854bd3APV0gP1XYaNi+rVmlNACVWD5swE5
 SRouBdoSC7RHgRZsOnQlEYQunqvbTw5d7bSC9DIyRixBiFjDuu5rK/OQOfxA0iXzRGxqpn2X
 TZkjb++r6ov5iAu1DhPi7ontprcenau5t+7f+3+4sow/LX+0SVjbFaKvy/VfYO0aSSARgR4Z
 3xSlwbTr5OAjvqDxyISF3Wqk/dOX8VmgDf4E7djn35rcPjQjUmT8JHmIJCaxPcr1Etpddmzc
 twriukXwo+N2K9oM3R3am+a/hRrDvDnZPiq59hs1VPFY8FLLNBp40W+01YVJ8GASLh8YgiVO
 1jFtvV6vpaeU6TKymxhBgl/PW8GnAoWhuWSEkLvcKYlzBQgXBi1kMdgMgShG0J+p4xQ4RNo+
 7ELqNrnrdTSdJ+V9M0OM4RBc+sTmDdSxPFN2yfZVzhCaEcInrI74X65b0kjdvaDKDgDKFC7a
 gpfGkoxFLaSniee/Fmhqc7jCwlaF/NLQjQ9g==
X-IronPort-AV: E=Sophos;i="5.88,376,1635220800"; 
   d="asc'?scan'208";a="64343614"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Wc0ioYK3xrB7CSJYH23AwSUpstL2Ym0NwSTPrZAwsgLkpq2j+yuyex4W4EWfQWzNZm/R42oNvneUeAu+gEUx5w7d7hnNdGEdhI7DhiUuuREVQ62MYgg7s2LuvQ/AAVqAoroEDgjWDbin8sVLze15ybFmCZI3TmTDut1t1K40pc/Qbv5AVAApTgu0aX0hfXzpuqz2rZ9HTho2K1OO/ejfUgpHZ4ct+IQUD5uLsG4Y5ymSdszG5UJhutTcZveIH4KOkObISBHocNYvOD7iZyRxLq6BaPfP4UC0SuFar8bAAEJhM+rujm6uNjx3Apb1aiNwEyS5NCUc7TN01VU51zro+g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=krkmKVsFDyASJVU/TyqNyjsSzSBZs/HUFZ7ywK5S1r4=;
 b=BeS31v2C3rjx8lymo4IW2d/+4dqpASlYddv6cSw8hQPTyEdh6l9hdSx0AU2yaswYHv1l1X3cRlmCgMokIXrTl0O1imetJK7cRP3pPjImggBpuIRWwzCAbQwXV6wdRZcNOFmsJiWUMTP/RKb9BZY2zDJ4z5Q4H7WLZeLorZGpR1ird2lFRMYcSEc9s3cndY1xqHmHj/RX8viF+g6XoXnhipb8xmTtcAcFZjDSNbb+cqFqBBiNZBl9GEWL0XXvsstqUSPwqcM22pC8B2e4G2lU3IsxNn3IAp/x30oflW5boR7l9Ep11gIY5xZIuRy+HbVlobvoyxTf8XHj1kf1RruU0w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=krkmKVsFDyASJVU/TyqNyjsSzSBZs/HUFZ7ywK5S1r4=;
 b=eZcypNM37xJveMiIeZ2PGj7HVuzMqf1KFMahzmBxccycb9kNj4CTXgnNvDLAOnE7n6arZan6SLLJnCngmlUvG7UjYw3L17Qv26EFw8Ua+4w03y3lrtu8oG4gjPxjzT1p2HKCvmObPxENFsbevrWVFdeerkh4F2wwhqOouhjJcoI=
From: George Dunlap <George.Dunlap@citrix.com>
To: xen-devel <xen-devel@lists.xenproject.org>
Subject: Outreachy, and the Outreach Program Projects wiki page
Thread-Topic: Outreachy, and the Outreach Program Projects wiki page
Thread-Index: AQHYJBiVHzNmzILnD0qqh0+WgY2BPw==
Date: Thu, 17 Feb 2022 16:08:22 +0000
Message-ID: <55020853-21B2-4153-BEF1-0FF5A3F04363@citrix.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3693.60.0.1.1)
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 45d8461c-3237-4def-0ede-08d9f22fb886
x-ms-traffictypediagnostic: BYAPR03MB3670:EE_
x-microsoft-antispam-prvs: <BYAPR03MB36702B213617B6BCA459DEA899369@BYAPR03MB3670.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8882;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: N+CDCINEP50OWGqtvW8dZbPc7FNxMGdW6YLHKzVmNZjkapoRtMf2Wp2TU5PBYFeVPSJ6R/G3FGfIclorymPBrSf1quoxHvOhhbATkPF1mhZ9euVDLCTWtxw5Fs+uX9+CXpncJ65dH6WsRlctpQFlFymyv41beD0Yd1Yhs4Fpo2v3qRHHcNQ+WvxBM7bm4C21eEWnAZDYCmNUQG84T0ZrPWfyUJMIwPDDBw22WaBqWTUciSe3iRTYYDvB+xCcN2Y645FoaAUUkl7n8AcfSpXR02jrzJbC4l8s/6K+rRf4nQcjmH68ab/CZ4yBJLVmJlOoLteZIrsqQCSN89QUFB1vxUv6A9NCZD9KnU7pU9m38A68kqBT5zlHXJfkSkSgJJFAt0jYzNGJrOtA6diOWVg7HXbrSs1t78FPkO6EnRE+TuOarqXJCicFPuSrgMqKqIzlO+UVB19vvAZhLhoYjRptnVzEPxKKMcO9bA8KH2Kw0ta/QOUTwPqTi0QeUsEs/CroM8CVt1Gq9wQBKkiDvmMJAclqdTAayTRxnHITuEEzAw+lEEK51lKt1xHvVwEytukFyQho9kpHM3LsCUq1Sw5FEco0EtP59xDRheuATVQPbSgwNqdyZBGcjoeckX137D4p3X3z/iJ7EKcHGGqgJ8PEHU6bSjUtJyx1ZhxVx/FqoBT/fPG4Zh9YXOb5KxzVFqkNxP7iK9BSN3MInb+gphFiY0MnXRe3f6LlY6qyElUWz41RoARSEk27wGeuz0IKaoWHbaqb/YT4oRVohEFPHNfLL3fz0syXwcH4545cemQG3UAx/iGA+eLZ68+sPz6/gb7x6IJOGHMAVTTHFXuD7QBMWQ==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(2616005)(26005)(186003)(91956017)(76116006)(33656002)(6512007)(6506007)(508600001)(99936003)(122000001)(316002)(4744005)(36756003)(71200400001)(6486002)(966005)(8936002)(38070700005)(2906002)(82960400001)(83380400001)(66446008)(64756008)(86362001)(66946007)(8676002)(66476007)(66556008)(5660300002)(38100700002)(6916009)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Q3VBeWpTRThjSHFzeHpaeVNLMDJhczdIOHlJMFVUNmFrelJRKzdZUVAyYmpt?=
 =?utf-8?B?T09vV282YWM1RU5wWFVLUDRKZG1ObkM0VG9VYVFCU0ZzZkFqNm5xL1hlMTQz?=
 =?utf-8?B?SW8yYWNIYTM5ZVVoUGwzRk1VTVNVTHhjbTVrdUwvR1hJR2pFWWRVdWloeFNt?=
 =?utf-8?B?aTZ3UCtUNElrRzFhU0dSVjdoMFBrZmxYOGgrcUx6ZXNKc2p6TWFteG5vV2F5?=
 =?utf-8?B?TmFNWTlHSCtiMmhWeFBKVHl0VENERk13ZnU1eWs4bDlGRkp2ZDV0cU1SU2VV?=
 =?utf-8?B?R0dhZDhXTEtuQ1IzZjJ6Nm5sanYyaHI4OHFRcUlZWTNUK2lOSnAwY3ZXMXN5?=
 =?utf-8?B?VWxzb055YzBjRFU0M1JKeWh3L1pZQnVwQk9aN1IvRldocmxJeFpEL2hLOUFE?=
 =?utf-8?B?dFlVaHhoZVdiV252Y0lBSllKM3hYTEk4allJVmcrNkxadW5obVRGTUwxbTc3?=
 =?utf-8?B?cnBlbW1OMVdxaDNuempjVmxEZ3BTbkxmNWNsZ2R0eG5XSDYwRmRhRWdienJU?=
 =?utf-8?B?RXByMFE0elZGeDdCSkZBWVhRY2tCeGxoazNKMEoySlErZm9ONGR0NTBueEha?=
 =?utf-8?B?cWVLMkNFYTZyRnhpMlFYZnFBUmRMN2J5eWh4Z2lHb1FUSEdqOGdhayt0L0t4?=
 =?utf-8?B?ZHM3NGhQVUNTNTUvRnVtOGE5NFVaaG0wYkkyRXdTVTAwQUZKbTBZUVZadFBK?=
 =?utf-8?B?dmJjaDZhWXlXUXhzZUhYVzVCeGxPN2l1ZlkyTEVzZEgxMXVTN2UzS3NmK1lP?=
 =?utf-8?B?L25makJrK0pia25OQkVsdkQ2djRVZFpGUmpvK09tVDNZNW1Bd1I1ODhFbW5Q?=
 =?utf-8?B?WXdORzkrK2hib2RsMXdSd1MySTlDR05MZ1YrbjVWdlVLb1V1SDlBUHdmYlgw?=
 =?utf-8?B?VXB4SWpCcFloWlRyVUdoUG1HMXdiT0xxNjhvTjBwOFlEZ21kZEdkUnl3UDRQ?=
 =?utf-8?B?a1hzU2haYU9XOGpHVWk4WHhtYlR4ZTUzNWFpblNRTVJBWTFJU3JSUFNaVWQx?=
 =?utf-8?B?THVvL2JiMVN2bmN3VmtxTUdSSGRpVzhsUzNQYXVlVzI1VHZuTmYwUmZaM2Fj?=
 =?utf-8?B?bmlFUmVQYWJEbWtvc1ZucVg4aFUxdVliYlRUNHdWSkJXeEZaOEJyUEs5Yk5l?=
 =?utf-8?B?c0ZicFQyWjVTUVJsVE9taklDQ1BkSSs1M1VDU2w3UGdPd1VaaG1TcCtmazNq?=
 =?utf-8?B?WjkzeXRzWWloMmZlLzhvME1iY0RIZzZLR1hlb1ludGJIc3gveUhpWjZxNnpO?=
 =?utf-8?B?VndCMnZ0dHZKR2NEMnJlc1lQMGt0UUpjSlVwSkFVV29valVPTTJodWt5YXBB?=
 =?utf-8?B?djNLdnJlVm15cENUSkNlandXc2krVXJpb2toTkF2L0k1SzlkdWZVS0hUVXdQ?=
 =?utf-8?B?L2Mxbzg0K2E5MzNkTUhXZkQrbWxGenJkN1dYUVEySWdEa3U0dVd0Q1BNc3JE?=
 =?utf-8?B?VGZrRmdrMzk2czJqZE1idTVVZytWaThJOVZ1VkR4YWxMUS91RDM5YkpraVJR?=
 =?utf-8?B?Ri94RzlIQkN6RWRWUVg4RUx5NnJPNVQwMnI0KzFvMlV5VU1NV2MzOUYrVDhj?=
 =?utf-8?B?NnZoS2c4UTIrWU52VlBPdjdLT2RGQVo4VFZ0TFVxWnNHR3FjM1dHMnovK2gy?=
 =?utf-8?B?cHRwTi9TY1kyUTJLNUZSeVpickRQbEttaWxiNGh3U3hFZ3FoUkJOWGlBTmZ4?=
 =?utf-8?B?Qk1MbWI0ODgwWnpzdG5QUGpnSVI5ZTUxT2lkK0pFcVQ4blM4eWVqUGhoelZD?=
 =?utf-8?B?Z1N2dk5JY2o4VHF5Q3BselJEREtnOXU3OU9jS3RMMEhIMWdvZzlUSkFsc2p4?=
 =?utf-8?B?bDJuWW9DK1FOQ01PNzFncy90SitlU0ZZOC9EWGc2akNoSWx1WTdJKzdzUTB4?=
 =?utf-8?B?RHFuTEptakVPWC9kOCs0UnRValpzQVVMY2E1bU43TjV5c3h0UWEyNWhrTFFB?=
 =?utf-8?B?VVJQdktFSzZWYTFJSTl0MjFYTGllYWUxNFdYVEI3eTB0WGpjRkYxL2ZFemlZ?=
 =?utf-8?B?L3dISGdFNEtrUHJlQXJJRDg3WDloN3E1U0U5dXk1bWZESnNCMlpqck9WUy9k?=
 =?utf-8?B?TzlZaGVOUys2Y2lvMDlVUytaYkZHbHMycTVSdnlVdmk1bHpRaWV6YzVFa0ZW?=
 =?utf-8?B?Myt0UVRFU2tXK3VNUVBEeHpJVDJHTHMrVDJJQmVaT0gxa2U1ZlhYazltY1ZQ?=
 =?utf-8?B?MmcyZC9xUFRuVFlaSWozNWJveEoyUzh3YnIrc0p2TzRFU0RodDE4RGhvVUZE?=
 =?utf-8?Q?rgNZHcKZKjPZiAZ4FB2aJRNKwlSiOBSlJr0aQmS/CY=3D?=
Content-Type: multipart/signed;
	boundary="Apple-Mail=_A61881FD-AACA-4EE0-8BDD-E134035BDD40";
	protocol="application/pgp-signature";
	micalg=pgp-sha512
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 45d8461c-3237-4def-0ede-08d9f22fb886
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Feb 2022 16:08:22.2032
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 01ADzntffee0Ae4NlCYFf4yaQ546q0CLdnuHsF0KPC6pqPNvW6Am7vw+3AVEKFTmcWESv/+LzZ6PvQ8cr61AXCIadnLseMSvvnmLaS9qB1E=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB3670
X-OriginatorOrg: citrix.com

--Apple-Mail=_A61881FD-AACA-4EE0-8BDD-E134035BDD40
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8

Hey all,

Sorry this is a bit late; the deadline for organizations to sign up for =
the upcoming Outreachy round is 25 February; and the deadline for =
mentors to submit projects is 4 March.  It=E2=80=99s not 100% clear, but =
it looks like prospective mentors will need to individually submit their =
projects.

Additionally, our project list [1] is looking a bit thin.

[1] https://wiki.xenproject.org/wiki/Outreach_Program_Projects

I think for this session, I=E2=80=99ll only go through the work of =
applying to participate if there are people who individually step up to =
say they=E2=80=99ll submit their project to mentorship.  In any case, we =
definitely need more people to brainstorm projects for outreach =
programs.

Thanks,
 -George

--Apple-Mail=_A61881FD-AACA-4EE0-8BDD-E134035BDD40
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="signature.asc"
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEj3+7SZ4EDefWZFyCshXHp8eEG+0FAmIOcu8ACgkQshXHp8eE
G+0RWQf+PAsp9wA052/4SO7ZI72N+1dQwW56RKkPd8q6zTTh927aKW+17x+pkv1L
rKJvvbGYxjDWMVwrqhKKDKx6u1jTOcNsVrE50BP4NsxlhRUE+FdFNjhPhC5mvdAD
gY7zCYGpsm+G3SsU1do3Z7GiMGu1CrTBZ4JDF57vz7gLz8e7xItt3QuLNfzCu0SG
yXbX2hMLwpssNx/Q9yeo16E2e46xmnlfilz55Ryh3+EfMDhME3iDCz5L2bBV1lit
xn5CtAYDd2C+lPc7U6lbnuysgDs9ywkfZ8wutUpe3ENHWV+q2xjg5/7v86k02mHH
irc2IqhwBQx0rRKsIh27lVrBSL3Hxw==
=WLjO
-----END PGP SIGNATURE-----

--Apple-Mail=_A61881FD-AACA-4EE0-8BDD-E134035BDD40--


From xen-devel-bounces@lists.xenproject.org Thu Feb 17 16:13:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 17 Feb 2022 16:13:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274904.470533 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKjPH-0002zS-9x; Thu, 17 Feb 2022 16:13:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274904.470533; Thu, 17 Feb 2022 16:13:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKjPH-0002zL-3y; Thu, 17 Feb 2022 16:13:23 +0000
Received: by outflank-mailman (input) for mailman id 274904;
 Thu, 17 Feb 2022 16:13:21 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=XMIn=TA=citrix.com=George.Dunlap@srs-se1.protection.inumbo.net>)
 id 1nKjPF-0002zF-OD
 for xen-devel@lists.xenproject.org; Thu, 17 Feb 2022 16:13:21 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 850e8340-900c-11ec-8eb8-a37418f5ba1a;
 Thu, 17 Feb 2022 17:13:20 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 850e8340-900c-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645114400;
  h=from:to:subject:date:message-id:mime-version;
  bh=Snox3KHOAxYs+2nsfXzxSnwUUSU1D6GH+5UAxqr1Qh8=;
  b=eG+eKrePomtHLlyh7B/ftPStI9kfAMpK2EkMOVGF8pcMYyg/5fg8MBgT
   LIRezUCWYKZdGp3cLXpJ550+IsTgX/PXoamg8NvqQmRhYoYM01GRJNh3N
   QhaZqAO7FqkmQzZBdlrtDvJJ+ybDr0mxua5ZS38xgdySYPX5EDexccqNJ
   4=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=hardfail (body hash did not verify [final]) header.i=@citrix.onmicrosoft.com
IronPort-SDR: 1eecYmoZOwHqQiutsPckH9pl3UMb8ebbR1ROhbahcdwDd8sQJTWIXQ4r1yEgPvVHvNWLcPX/+V
 Hm7Rgf7QzPozZXTQLInw+uIFJJD5ESh0WRMCfHnLYqBZ4/Em8UvuprCV/6kV/Bv0/cdOvd4525
 TrOyvm+zf6crW+mNMwsHf+uU+ulRLyWJo1m6jbSaFO0+uOeq5GGglQniTuGu9Yr2XJzdysCw2Y
 +1msmJJdXr3TX1pFYIB853fNATielWDmxPZBdEgs77+CjEX+J/MaUhwv85/TzjWqjqS0jHZ7Q5
 u+IQ46Yf1e2zJZ9/odI7Me4W
X-SBRS: 5.1
X-MesageID: 63887733
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:yPwsE6/hclrO313YhYkADrUDK3mTJUtcMsCJ2f8bNWPdYAuX7wSz/
 BJcAD7Ya7vPIDfrKpolWDmFhU5QvpHXzt4wTARlrnwwFXgR+caeWtjGIh76Y3vDJ5XIExo/5
 pwXNoSfcphsRy6GrRuja7G7/XRy3vDST+OmBbKs1kydPeNBYH5JZUVLx75p6mIRveWEPu+th
 T/Ti8CCZgL4izJ+Oz8dsvPeox1l4qn/52lE4QAyOPpAtw+ExiUZVJ4RG/q8fiDyKmV28k9WZ
 AphIJWRpD6xE8IFU4v9+lrDn8ljrof6ZWBisFIPM0SZqkUE9nxaPpoTbqJGMx8N0mrRxbid9
 f0W3XCOYVZxVkHzsLx1vylwS0mS6oUfpdcriVDm2SCi5xWun0nEmp2CP2lvVWEswc5lAHkmy
 BAtAGtlgiZvJQ6B6OnTpuFE3qzPJSRwVW8VkikIITrxVZ7KTX1fKkljCBAxMDoY36hz8fjii
 8UxNwpvRjKbUzJ1Ogk1U5dkne7zjFPbSmgNwL6VjfJfD2n7yQVw1P7mMcbPe8zMTsJQ9qqaj
 juYpSKjWEhcbYHBj2remp6vrrancSfTd48VDrK1sNJ3hlma3kQYCQEMVEv9qv684qK7c4wEe
 xxLpXF1xUQ03GmCceHGcUGRnHergjkFSd9dNNQ5sw7Yn8I45C7GXzNZH1atcucOpMIwADAny
 FKNt9foHiB09q2YT2qH8bWZpi/0PjIaRVLufgddE1FDuYO65thu0FSfFb6PDZJZkPWrKTHa5
 Wu6gxI+2ZdIiJQK3v6x13T+1mfESofyciY54QDeX2SA5wx/ZZK4a4HA1WU3/cqsP67CEADf4
 SFsd9y2qblXUMrTzHDlrPAlQenxj8tpJgEwlrKG83MJ0z22s0CucolLiN2VDBc4a51UEdMFj
 aK6hO+w2HOxFCf7BUOUS9joYyjP8UQGPY66PhwzRoATCqWdjCfdoElTibe4hggBanQEn6AlI
 ou8es2xF3scAqkP5GPoG7pFiuB1mn1lmj67qXXHI/KPi+X2iJm9E+ptDbdzRrphsPPsTPv9q
 L6zyPdmOz0ACbajM0E7AKYYLEwQLGhTOHwFg5c/SwJ3GSI/QDtJI6aImdsJItU594wIxrag1
 izsASdwlQug7UAr3C3XMxiPnpu0Bs0hxZ/6VARxVWuVN48LOtf1s/lBJsBmJtHKNoVLlJZJc
 hXMQO3datxnQTXb4TUNK577qY1pbhOwggySeSGiZVACk1RIHmQlI/foIVni8jcgFC2yuZdsq
 rGszFqDE5ECWx5jHIDdb/f2lwG9un0UmeRTWUrUI4YMJBWwodYycyGh3OUqJ8wsKAnYwmfI3
 QihHhpF9/LGpJU48YeViPnc/ZupCeZ3AmFTA3LfseStLSDf82f6md1AXe+EcCrzTmTx/Kn+N
 +xZw+ulaK8MnUpQspo6GLFulPps69zqrr5c7wJlAHSUMAj7VuI+eiGLhJAduLdMy7lVvRqNd
 niOotQKa6+UPM7FEUIKIFZ3ZOq0yvxJyCLZ6u44IRum6XYvrqaHS0hbIzKFlDdZcOluKIogz
 Oos5JwW5gi4hkZ4O9qKlHkJpWGFL3hGWKQ7rJAKRoTsj1NzmF1FZJXdDA7w4Y2ONIoQYhV7f
 GfMifqQnalYy2rDb2E3RCrE0udqjJgTvAxHkQ0ZLFOTl9uZ3vI60XW9K9jsoti5Gvmf799OB
 w==
IronPort-HdrOrdr: A9a23:YzQcnK0o+D6iIwrPur956AqjBTRyeYIsimQD101hICG9Lfb3qy
 n+ppsmPEHP5Ar5AEtQ4uxoS5PwO080lKQFrLX5WI3CYOCIghrQEGgP1/qB/9SCIVyzygc+79
 YZT0EWMrSZZjIW7beY3ODRKadn/DDtytHNuQ6q9QYKcegcUdAG0+4WMHf/LmRGAC19QbYpHp
 uV4cRK4xC6f24MU8i9Dn4ZG8DeutzijvvdEFE7Li9izDPLoSKj6bb8HRTd9AwZSSlzzbAr9n
 WAuxDl55+kr+qwxnbnpiHuBtVt6ZrcI+l4dY+xY/suW3fRY8GTFcFcsoi5zXAISSeUmRIXeZ
 f30lAd1o9Img7slymO0GfQMk/boW8TAjbZuCGlqGqmrsrjSD0gDc1dwYpfbxvC8kIl+Mpxya
 RRwguixtJq5YOpplWD2zHkbWAdqqOPmwtqrQfTtQ0sbaIOLLtK6YAP9kJcF5kNWCr89YA8Ce
 FrSMXR/uxff1+WZ23Q+jAH+q3nYl0jWhOdBkQSsM2c1DZb2Hh/0ksD3cQa2nMN7og0RZVI7/
 nNdq5oiLZNRMkLar8VPpZLfeKnTmjWBR7cOmObJlrqUKkBJnLWspbypK444em7EaZ4u6faWK
 6xJG+wmVRCC34GOPf+qaGjqCq9MVlVdQ6duf1j2w==
X-IronPort-AV: E=Sophos;i="5.88,376,1635220800"; 
   d="asc'?scan'208";a="63887733"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=iaOQY972eF6ZEkU1+EN7cUgYt/L/rjckkCPNhoGNPXu58wWkxcpdvsmKgopXhnpJJeSlA7P1lJjfcKgEWhI37nB2fNzDvHsv8AM11WjBO6hAtVWuV34qSM0oX5NAFwLk4H7YCJJyJj/5GoJLUijDX1qM8O9V82i+Grx/juoLjs+bnhXV/vJTGK+4/qNYOblcpH+LA5/NDC2QKMEyheLTDbScAG29YeTs36q78XqtQtlfKFtnSluz2VzEM3b4M4Lh8hu23XdNBZ80ybFxuPBtvxTy/DDhmzvfRV+A6ao4d2TJuDl7AP7K38CGsyUKWzkflDtzdFEA/nx/E4KSmwSTDQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=FFj8PAEnr5oa5TJh4u0Bq4rso0mAnYCj0+TXV80DcyM=;
 b=U8HPHTxIVLrS6c0HRQpOU7RBMjVJMrYegYYXCxvLHIw6RjZ2nUYQtUvbDUUQrQAaYuHkUIQPtgxR6Y6JNJX6IjGncYQo254zzvqRTRX+yH8NbssKeSHQerq5LbdlYc+JkluZG7xOErvAXx0xSSz+LtHgBKS/yFDitHAcu56Or4C+hT13U/n1aCYHmyEpfyly4M9idP9TjS1J2c873IJqyJIvCRWntqXMjplSqoEB6Jf02gOF5zmLy/yp/L44QDZiC7IPvKOszI2EZc4NSy/W/vj3CyeeYpB3ZNvvFFu26VUcnXQ/mkoztjEXLFMPKq+0ubgISc0gxCB76EHjlM+s1w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=FFj8PAEnr5oa5TJh4u0Bq4rso0mAnYCj0+TXV80DcyM=;
 b=Ks6IQdphcBAhnsEPM5pz8MY2J0+iOIygzQ7xsZiMg9Di9+/9mF8ATKmMwBZ14OXxuBDSxrvAojzLbaMuu02yIMm3qx0qMBcCndJwkNjzvX79djHFAclzkzHYvoRiEy0MS8ToD6ReO78FH/32ny01w206wbmdhSGRylsIddQdo6g=
From: George Dunlap <George.Dunlap@citrix.com>
To: xen-devel <xen-devel@lists.xenproject.org>
Subject: Potential dates for XenSummit
Thread-Topic: Potential dates for XenSummit
Thread-Index: AQHYJBlEabRNM87QJEepavafzujS4A==
Date: Thu, 17 Feb 2022 16:13:14 +0000
Message-ID: <30359D98-22A7-4161-90DB-476587FA2C7D@citrix.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3693.60.0.1.1)
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 838c38cf-298f-476d-7ad2-08d9f23066fa
x-ms-traffictypediagnostic: SN4PR03MB6717:EE_
x-microsoft-antispam-prvs: <SN4PR03MB67175CC78236C611BEA2B47899369@SN4PR03MB6717.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 5JpgWpn8OVMzAOZf9INPXO15/TAQVbyjWGRvB6uGqNGIDTfEWliIGNgvmmAGX2MYGxJZJLM2UKA9kTYEqvFnn4VZyM267t14c0wsL8rUPlotJKyvjVdu5p70MXaEH1JmEAPbeuNv39Ph9RX+bzVwUz/2YUr9WLrl6AI6QDnq3Gh75vx5H6IV5aGHjXULq70+RfhUK18GZylaBH6Xj0MsM+4EGxXcBOb9fvTKT0GQH2oL/QiWC9F1wYlRJT4MgEs1b+k1md03936DPIfitoQN/APIyAL+ZI+Rc+8lsx9hnvne9qKtLYXPQsJy5KNgpkC+axqfmn3vY3KPDDYtySh/n9uU+4AzViIV/y3PIqZnLJp1v0k+nVBhl97f3bYhKfER1xrjn7JcLjUvu/yH4KlAA8UMXW4CRFWZP+8GojfsbNLubRYzL8CG5zcnt9R4Cf8PQ918IgPdqMq6rPH01JwQiWzrQmQPzEMSchXeAkr3+OigybGfPMxwBy6B7kAZb7bK2xDBvW29OP1aG8drh7rf/WSyoFUTD62IJJkCPp60+Fcw9h4g3iEHeXa3ftH/6YcZrFeFW4Oo2y8/PY8tJ57hJ6ZLZRPBUz5UsD0mbInWNptfI//L7wpGYG4R5D3sdrQNufXwvKSARJpRR8LcU1utZriQJXUCrFWoJR9wm6e7+5KwDaKpGkFo9jX+rOBWleoF2WWJHRPPZaWExOcf+ChEz7VnYhpjkSqFCb4KYSP+v5Joa1itv4clof3MfW1EyGKN
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6916009)(8676002)(186003)(6506007)(64756008)(66446008)(66476007)(91956017)(2906002)(66556008)(508600001)(316002)(33656002)(76116006)(6486002)(86362001)(66946007)(2616005)(26005)(5660300002)(6512007)(38070700005)(122000001)(36756003)(38100700002)(71200400001)(3480700007)(8936002)(4744005)(82960400001)(99936003)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?K1R4dFl5R0I1MTU1NjhPb0o4R1JMQTV5Q2ZrS213NElVaENSbDRNSFU0OHh1?=
 =?utf-8?B?M0Q1UnVjd2hBMHd6bWs2WmRGV0xHNUVabEQ2MzVmcElrV1hBRDd4Nms4VFNM?=
 =?utf-8?B?VDBWU296dUJjYmpGaUtCc0w5YzhCaUhQZ292WnZrMjY4VFkrTktlMXRSRkFL?=
 =?utf-8?B?NndjcEcxWXJPc3EwNGFJa3NETm8wWEZWNnQxTUZMb3U4WG4vNVhOeEVreTk3?=
 =?utf-8?B?MjBQSGdvb1FrRjBWR1JOTGRHMGw1NER4ZGlJM0pkZ2wxUGo0MXlFRDNweWVP?=
 =?utf-8?B?bmU0TXBTN3NOdEtJTEptRE54QzdYSXpsVEdmalg4dU0wVGpLaE9sSEpwUEFU?=
 =?utf-8?B?M055blNPU3VHbkF1cWRvVXVSNFkycWs0eEcvaG1JRjlaMnM4bnhCZnJ2Y08x?=
 =?utf-8?B?MGRiZnNMSnY1RWVsK2JXNm1IT05peXNKUWtIaEdSeUh4bUJpQmw0bDhwQnE5?=
 =?utf-8?B?ZGxqbmc5ZXZCaTZDd01QSG91VUZ0eHp4dmdSU0VIaHBuVmRZM2lZb0RoZHoy?=
 =?utf-8?B?MzJOU0VDT2NZeXBxUGJMNW9ZU212ejI0SlZCeDZYYkNPeXlFR2o1Umd4dit1?=
 =?utf-8?B?cWVLS3JxQWVDOFB2dkt4TVZWb0RKT000TFJvUTBQSHNaRUZRZW05cTBHb1NN?=
 =?utf-8?B?YW0vTWZNVHdwcFg4a3MwVHh0NjVRYXczU2twZFZuWWhHZ1BYc2NvdXFObFVJ?=
 =?utf-8?B?NnMzb3BLcHREWmMzYXBXcTd1MzNCb3BNK09UUFJlbEY3N002YlVVeTNsQVhr?=
 =?utf-8?B?THhhbVhWYytnc0NrSmoydEc2R2FkYTRFQmVVYWRhLzNlOFhYQVN0L21VUFo3?=
 =?utf-8?B?UTFWZ0I0czdGMHBlN1F2dFU2M09tdHlvNVlhcmw1aXRFTGtvL3VLTGU4cHN3?=
 =?utf-8?B?NDVXd1NsZ2RKWTNoeEJZaTRMRTV4eHBGdlVkMERMV1NMcUJkY3M2eWQ3Zi9t?=
 =?utf-8?B?Q1JyUFdVcmJPbGhoQkk2YnFybnFOMHRlK2dLeWIvRzRuTHJteHU3MUFqMVV1?=
 =?utf-8?B?K1BGNU02d3EraDY0MktPUmNTZ0s0MmFBcVdsNDgrZWZET1FpUkkrWXI0Q1l0?=
 =?utf-8?B?VTlhMURDbUl2cWlSRFg4ZCtVNTlVcm5idjZUeUs4MDlwWURMQUt1bXl4Yko1?=
 =?utf-8?B?RWhkZkttSmVGQTRhYVgwM0lrOFpRODZJTlZTNm9oLzVVeksyaS9qRVp4Umkr?=
 =?utf-8?B?VkVFd3RhbjVLUVpobGlOUW1CVkZMcTU2RXpvbWJPRllvNWwxVzl1em9zTnhh?=
 =?utf-8?B?U21hc1RDODRNdHFZMkROZCtuZzN0ZjcxUGE3SVBrS1VFQ2tGNUhncFhpUXky?=
 =?utf-8?B?L2JPVmRpNUVxSDFhR2Y5LzNSQ0pjZTVyUDRxVHpEdjIzbTBVQUNlb2g3OUZE?=
 =?utf-8?B?dGh4bDhLdDJLcGdkS1BCQjh2Ly85aHJuczVqcFNneDRvak5iY0VxTEpreGpQ?=
 =?utf-8?B?eXp5Nk03VHpHZFhmRjlqR0hrcUtpdXo1MUlnb0YvTXp0SWM2NEY3RGs5SHR4?=
 =?utf-8?B?Ym1KbTVQTWFqMkxRWDRUcXc3Ym1NK1owS01tdEFkNUdKblUxbW0xazFBWFY4?=
 =?utf-8?B?WXE5c2dna042SHZveC9GOEpvOW1RbFRVMXQ2Tll1MWxFNnB3NDA2NmFYK3ZY?=
 =?utf-8?B?WWt6aitaL2NqUDg1RWZSZW1iSWw2U29RVjV1OUp4ZFNTcTg3NmM1YVlDNmpG?=
 =?utf-8?B?TmR0Y2x1SkZPelFWdFFFbmNDRjR1VDhodGRvOUlBYlY0aTNRS3ZXUHlOWGlF?=
 =?utf-8?B?QkxJbXBkOWtWNFpwdFlCUy9Ld09LSHNRdEhiNzk5RzdNWUdqa3o3eXBKYlJD?=
 =?utf-8?B?S3ZpQStkNDdzSWhFUVQwWEdxdjRNc25pWWJoa21QNUVBNjZtK3dMWkFvRlhp?=
 =?utf-8?B?UHd1RjVleEhFQ0YySzFSd0N6dG8ycENUZmVpeWpGcy9PeW5VdEFjRXFROVNQ?=
 =?utf-8?B?TGZKMy9QUThrWkplMXBTYThaL21BSkRDU0oxUVBmaFVmUzZiTDVucDVlY0RP?=
 =?utf-8?B?eUJMdlp4ZFhod05hYk5TeSthczRGU3hBbjMrZnZSaVFxM2V1cnFINld2VzVD?=
 =?utf-8?B?YjdTRzkxdjJTOHFKM0pjWHEybzVmWGp4UHRXZSt0UE1wVWdHQU0vWWEzVkRi?=
 =?utf-8?B?Um9mMCs4RjIrMXNoaUwzczZERHZZNE5JZVlSSFUwNHdSNEZ1R1I5RHAvVjFp?=
 =?utf-8?B?SERjUmFUQzcvODJtYVRJN1hURnVwOWlPWFdpUERYRm80TzM4THFkMld0Y0dZ?=
 =?utf-8?Q?y+cfvp73gSP9tn4FtfYUZCgIU/XZpEHlEiN0YU2kRU=3D?=
Content-Type: multipart/signed;
	boundary="Apple-Mail=_D685ED24-8CF1-44BB-A596-89AE94202066";
	protocol="application/pgp-signature";
	micalg=pgp-sha512
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 838c38cf-298f-476d-7ad2-08d9f23066fa
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Feb 2022 16:13:14.8742
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 3WVptDfRilFdIZsP+2hq9jpq7yTUShn+h7+x8MAlmTxa8sNAvHfLAogg9ayMjEpf7GLOkXEomjo0JzW9iOjtT7MBHEy7I4LIs0/MX7Ebm9E=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR03MB6717
X-OriginatorOrg: citrix.com

--Apple-Mail=_D685ED24-8CF1-44BB-A596-89AE94202066
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8

I=E2=80=99m looking for input for dates of the XenSummit.  At the =
moment, we=E2=80=99re looking at three options:

1. The week of 25 July.  This conflicts with SCALE.

2. The week of 1 August.  There are a handful of minor public holidays; =
but worse this is in August, when much of Europe is on holiday.

3. The week of 7 August.  One minor public holiday, but still in August.

My sense is that August holidays is going to be a bigger conflict than =
SCALE, so I=E2=80=99m tempted to go for the week of 25 July.  If you =
want to give input, please let me know by Friday 19 Feb.

 -George

--Apple-Mail=_D685ED24-8CF1-44BB-A596-89AE94202066
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="signature.asc"
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEj3+7SZ4EDefWZFyCshXHp8eEG+0FAmIOdBoACgkQshXHp8eE
G+3YrAf/eiVawyadnzkJ0oYkt60xLx45YIfSI7yz0i+u6HJ98TWvzJdsv+GbH52e
CI6fFiHs9TiVnlAvcg+aUO6jBZHcWU8y42MLKx5PISyRTbKQkdH9pRdOMBIuuxjZ
HhZU26C2TtuOTqkO9oAtpk7342TkaaIFKLANyfa9TsCLrEV0Xf9SyMWtcSshm/+I
KV4KIDDvSw9tRa9zfnz1esbWoEuiJplE0queyDCTUSqhLmIpZCJQT2C2R0YFh/ED
vD53bhFio/d4yeDSBgkfh3nyvV1IX27RD/4qrYWvbYqdy1Lj9o5CYUHzWRWs5zPQ
nQ0IXXpdiMlYBRBXw+/Y10IyFlry/Q==
=RuT6
-----END PGP SIGNATURE-----

--Apple-Mail=_D685ED24-8CF1-44BB-A596-89AE94202066--


From xen-devel-bounces@lists.xenproject.org Thu Feb 17 16:16:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 17 Feb 2022 16:16:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274912.470543 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKjSY-0003fv-NU; Thu, 17 Feb 2022 16:16:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274912.470543; Thu, 17 Feb 2022 16:16:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKjSY-0003fo-JZ; Thu, 17 Feb 2022 16:16:46 +0000
Received: by outflank-mailman (input) for mailman id 274912;
 Thu, 17 Feb 2022 16:16:45 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=xzkl=TA=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nKjSX-0003fh-IT
 for xen-devel@lists.xenproject.org; Thu, 17 Feb 2022 16:16:45 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ff8d51df-900c-11ec-8723-dd0c611c5f35;
 Thu, 17 Feb 2022 17:16:44 +0100 (CET)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2105.outbound.protection.outlook.com [104.47.18.105]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-15-96FwoUXePCGwlhVYdNiCxg-1; Thu, 17 Feb 2022 17:16:43 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM6PR04MB5543.eurprd04.prod.outlook.com (2603:10a6:20b:99::28)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Thu, 17 Feb
 2022 16:16:42 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4995.016; Thu, 17 Feb 2022
 16:16:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ff8d51df-900c-11ec-8723-dd0c611c5f35
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645114604;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Xek/oQqGq7nBXNMK/qReZzo6SCj9YW6gLqIfCeyunag=;
	b=AfJjZdmO5GbrpyCCygWWDzKTCTixrnoSOkCwKKsUp7moFui9UGK6+bF8qvIrvhuoTKDDUa
	i99kgsTBwWVQkmw04obhZhu6sT8NtGyzOTr5Px1+2n4tT0k64Ef93Vi2EGizA1W0cpEiEn
	O9POXLAL9WRl77ugmvEYTPCprwaiUAU=
X-MC-Unique: 96FwoUXePCGwlhVYdNiCxg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jN3vABOdpM9WXFlMLwK5aRHPkp8OWofqxxURH+1GQ/pIJ0DwdBfdKivYmExfqD5/9Hg+11p8LDO7GROYGjy98ceWUkksu2R7q59+zMtw+6qx28T1R+SQ7pyna8X4JCfmA32BJg24DBmZQwPkgJBPLmHCVHQBX9sbfaFfzCBGjPruTuamiiPS+AIflh0WWT4DQLMvhA+rgV3DbWCCNeaC1cTeG9iX4wzjAPftEvdaQPjKbxbQdkyUVvnNjs4DbMEzhUfXNnF7coJwEX8GhdXeK/AKf0kd5rJXvFsq3Sffq1slFOPbnMg8Mi+m/Pbh/defsqbkDyBBjtuDVLrWkNb6mg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Xek/oQqGq7nBXNMK/qReZzo6SCj9YW6gLqIfCeyunag=;
 b=BAFTlgzt7g1s6F442iZRQnXG4tqPddZXNaYzueaM/KFLMsy27AuI35fkoUpaISp2xcSWXEuKWi8zJuxigAUVLTCEUkPw6pK5lo2iYEnNkejAK1LXMEhuGMh5XnDt9aE3nyEQ2+yniRRbMJbCz3s0nL+n6WXiLnXYGjYqMc6N5Lb5JWtlzXkysa6W/uNSzZV8nLS21s7bi3bvxumrGIjFazraotagrdMI0QPzkoJ9TIJWXG19Sg9zrZSV2CxfrakZLESmaM5fHz0Xr01ADr8DW5Lkn4KMSm5Gs5IQaOmRUNXIKvTsL3P74vaZiJrNmDIEN2Jod9l/sTKYXDSN91Xlpw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <c74472c7-3f23-a73b-4df3-55ad1700463d@suse.com>
Date: Thu, 17 Feb 2022 17:16:40 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v2.1 6.5/70] x86/kexec: Annotate embedded data with ELF
 metadata
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
Cc: Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
 <20220217100158.22402-1-andrew.cooper3@citrix.com>
 <4e9924f7-fdfa-c3c3-7b6c-e5cbe77ff9ac@suse.com>
 <826c97dd-dda9-b6c2-37bf-451354fcfde2@citrix.com>
 <e35ca83f-12ad-0c28-075b-82ff08b2bf1d@suse.com>
 <19446d4d-b4ee-e26c-10b1-b2c49a1950ad@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <19446d4d-b4ee-e26c-10b1-b2c49a1950ad@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P191CA0018.EURP191.PROD.OUTLOOK.COM
 (2603:10a6:209:8b::31) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 59d1ce25-ed2e-441a-5843-08d9f230e283
X-MS-TrafficTypeDiagnostic: AM6PR04MB5543:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB5543F44944E3BB0F173AA486B3369@AM6PR04MB5543.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	8vExkUM2UAilcHcz0yVdSut6mG4O1wvoJSFZl/5ZwkZsCO/z3YhxzWmRP42+M88rGc+q1wD9rFTPlie2EIQQDrfb9OJb1tUC2dBhIAy2GN1vLaCUI2MSB9/CTy4v8ej7tmflSom0QZTKQO6IKHWjwtU9wDVQ2zW0MwOAQzMAutbAhzKqe/ZJk13VkUYV/JZNBpuYC8FdhX9BoFBix0N/lJuwFBsChH9T8zhQAA2SfiYfFWAx+xU5EG7Z132czBOk1mPWp74q/vX0IaSqlOGuif+0Kf/uS+u2TYIZcrC3YyBstGos6t1eIAgdzkOnz2QGyPhhtRlihv2p4EYPQIRYVxQtfnIlaqq0YtU5HYseKE0TIGVZ9D68VE5H1SRP5lNWZoTx5EBT0TRVxMnqyE1d2UkE6rFwR4kI/W0rXmSsrFe7SOyJDsecx5kgX4jXcmIGwESABAcQfrPl3/i+564cSCrh3nvqcTrSw7eedexh3nb/9xe4OGom9cEoQwAe7TyxY2x8wogadr4G1ylV4ozWSBhLJQB2z/pqTb6T5K7zPaDFL31lT5V6a/s0MqwJ5FMjhJxQ47FhL4fr4MGetkJtVhG8nEKkeVJyJXQL3QoaWovEDHP+k9gXOZe2sUDhgUF7zIlQoPdsAMRskWrfceYeDK1lRibaj2ynYnbKM7+z/U4O0c75UwbsqDGk4hgjymA86O2+vYqVNyQH3A9flQbAYRzNnw7kc2rJXuXU5xUuwtKNzWCrBGQAOLYdURqhOQ7Z
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6916009)(31696002)(2906002)(316002)(6486002)(8936002)(8676002)(4326008)(508600001)(36756003)(2616005)(86362001)(66946007)(6512007)(26005)(186003)(54906003)(6506007)(5660300002)(66476007)(38100700002)(66556008)(53546011)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?MGtSQzVUSnZ0NFM1Tm80VVQyMGcvbEJaL05HY1AyOE1ZUHF2aXJWMkdHcFk5?=
 =?utf-8?B?WWplZXFSUjY1VVlrLzc4dUNlQ3BBbXUzYm1wRGwzM0lTMnlLR1VHWXBSNHhE?=
 =?utf-8?B?eTI3Z3FOSXBVa3V4WHZBUUJjUUFQdG5valpzZFRxUjQ3d2hGU29xdlkxbFdq?=
 =?utf-8?B?Sk54L0ovQ01iNThTU2N5QmFMZ1RIZW5kNWl0R29ZRndoOGZSUDhHOU82UEFZ?=
 =?utf-8?B?Vko5VVQzM1Q1S24zY3p4eGFvSzZsQm02ZzdRS285Y3g0Qlh3ODg1QlcxVm8v?=
 =?utf-8?B?eFNXazFvd3c2eWoyZ3djM3ZVVmExcVkxM3JVUTdsS0dUQlRyems4a1BtMGF5?=
 =?utf-8?B?NHVDMWlUQ3dpVHRObnpIK2xmWGFYWmxwaVV5eHUrcFlyeFU1WXE1VEhWdUM0?=
 =?utf-8?B?VGZmS1RhN2xTeGJzbGpCT3o4VFNBNW9LdzY2R1U4M2ptL2U0YnNBMFN1bkZZ?=
 =?utf-8?B?VWNzVmZwdU45RUtIV0tNdTR3QXh3QTBSTTRpY3VkcGFqMTNiU0pRUG9MUU5n?=
 =?utf-8?B?eCthNlIwN0RrVkJhOEZmb29FK1lESE9iUUkxSHF5cnhhUGNodlpQQnlKbXJ1?=
 =?utf-8?B?dGRKRjR1VkU3aE9aWkFobFQyMGhkK1JrTGZmazBnM2V5Y2lqT05JTW13eWRB?=
 =?utf-8?B?MzN0eGdHT0hZQkxGT0ZxQzFBWlY0TGQvUXZsS0ZMK3RmRXpmY3B3QU9PQ3pV?=
 =?utf-8?B?UHptTmUvRGRDNStrV3FDMmxuVHM3NVJvNm04RWRaM29ZZkJMbkIrSXlDRmR2?=
 =?utf-8?B?NUpSbmZSRmpmUEd2ZWJITEtjZnRTeHplME5NamVlQ1IzQnVLa2I4dC9Xc3Fn?=
 =?utf-8?B?OHFtZjJvdGlnUmNxYk16UUgrLy82TnJIbUFaYkdBNE5tc0hjcHZNdUJDblAr?=
 =?utf-8?B?Z3V4c0ZkcWkzTThjV3ZDejB6K3RKWkhpQWwvdXpITm5VUFZEUDJCTlI5bEwv?=
 =?utf-8?B?Rkt3V3EyZXc0UVhXdTNXSm5ldEtrdTlEcXlXcmRkeFRwMmtaZFk2eXdzRnNO?=
 =?utf-8?B?S0pUeVg3Z0RKYjhkdmlGa2NRTTdVeDdCVzNiOCtEMzNWNGpJczU4MzVnUXJw?=
 =?utf-8?B?RlFuVlA5K1pCL0M2U08rdm5STXFLaHVrTmJYSmxFenBaVGd5UVhTa3NXOUlV?=
 =?utf-8?B?ZU14Szd6Zk0zR2xqR3BMbUVWdGRjSENnVlpvMU9hMjM2R2lvaUF5UVlDeGJC?=
 =?utf-8?B?S1cwRGR4NXVmRFl0VXVjOTNRUjlheHo4bU1icFVWNFo1T3gvUk8zTUVjUDBl?=
 =?utf-8?B?TGRNV0xGZ0NXenRQR2NYZEFkZEMyZVdTREVGYW1Pc3pybVppQTNUbHZQeFlt?=
 =?utf-8?B?ZitSRFhKNlNQR3FXaUkydlNCNFQ5ank0MmRkY0tIQnNub0pDdm05TmlHblpZ?=
 =?utf-8?B?WVdRMFp0R1dhTmpITkJTbEwwTnJ6bEpNTVB5bXV3YUJKYncxQWJFSlBtU0Fj?=
 =?utf-8?B?cm9oOXMxWHEzcEFyVlg1WkVLQUp5MlIxb2luSGNrK1dHeGNnVjk0d2lRajRv?=
 =?utf-8?B?TEo3NXd6b0gyc1FlSG5ScXVaUlp0bFY4VksrNDRmdzdPOUJaNnFtZ3UySXNp?=
 =?utf-8?B?bkV2YVAyc0xHU2F6b25nWmVXQU05enkzeHNuSGltWVlFc29mNUp0U3JQNkxt?=
 =?utf-8?B?MzZzZkF5L2ZQYVlVM2NLb2dzU2d1Vk9Ka1cvS0tyeTVjblJFYzBJWUlubWFB?=
 =?utf-8?B?NWVEUTQwMWI0YnVrN3R2RUxTNWdZemRRc2E0MDMxcGx4Nk5Xc2Fra1hDZUI5?=
 =?utf-8?B?VTVlYXRuNEEvVzFxMm5pRTBaZnM0K1ppRG5RTkczL2ptdFRwc0RNR3pkMFlR?=
 =?utf-8?B?Y2tVbVo3OEl5ZmlCM0xOWkdRSDRsTnozTlViaHZpS1FoMzA1UDNoU3dEWGRD?=
 =?utf-8?B?elIrNmdpZzdVRUVIalBPNUVxSkhaR2JYWDFzVnV0b2REa0xsblN3bFpaOG5H?=
 =?utf-8?B?SEdpS0tYTVhNdlZpSnN1eEdVRjNMY0ZTVnlVWDF2aHQ3OUlPOW0vdEpkTkZE?=
 =?utf-8?B?aE81RnhUSXEzLy9hNTFlWUdDbzE0b2JrWFBGUmpXbXF3cGU0RklMWXZ2Y1dN?=
 =?utf-8?B?RXdRYnVvdnhQQlRoa3FzSGd2VGNhakVoa3pYazNhbjAweEhwZGc4bmNyK0Nu?=
 =?utf-8?B?dzBWbXdQTkNZK1BzYU1jb2dEUU5TdTVaZUp3UFRPSzVUOXltdThaWTliWE5Y?=
 =?utf-8?Q?Xj/bd4QC3uSyb1NOLdWAS10=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 59d1ce25-ed2e-441a-5843-08d9f230e283
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2022 16:16:42.3496
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NC2eD0DfuC6SfDpRNCo5fPU60QAi7kzO0R2+8Rq9CJXLDpqf5FxDesArh4H47io8r4N1qYkWGwZqRy7Ct89TnQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5543

On 17.02.2022 17:06, Andrew Cooper wrote:
> On 17/02/2022 14:48, Jan Beulich wrote:
>> On 17.02.2022 13:06, Andrew Cooper wrote:
>>> On 17/02/2022 10:42, Jan Beulich wrote:
>>>> On 17.02.2022 11:01, Andrew Cooper wrote:
>>>>> --- a/xen/arch/x86/xen.lds.S
>>>>> +++ b/xen/arch/x86/xen.lds.S
>>>>> @@ -87,6 +87,7 @@ SECTIONS
>>>>>         *(.text.unlikely)
>>>>>         *(.fixup)
>>>>>         *(.text.kexec)
>>>>> +       kexec_reloc_end = .;
>>>> Does this maybe want aligning on a 4- or even 8-byte boundary? If
>>>> so, imo preferably not here, but by adding a trailing .align in the
>>>> .S file.
>>> There's no special need for it to be aligned, and it is anyway as the
>>> stack is the last object in it.
>> You mean it anyway would be, if the stack was aligned? Or am I to imply
>> that you've amended the patch to add alignment there?
> 
> I have aligned reloc_stack stack because that's a no-brainer.

With this ...

> With that suitably aligned, kexec_reloc_end becomes aligned naturally
> (because reloc_stack is the final object), and I don't think there's
> much point putting anything explicit in the linker script.

... I certainly agree with this.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Feb 17 16:30:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 17 Feb 2022 16:30:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274921.470554 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKjfD-0005GH-1o; Thu, 17 Feb 2022 16:29:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274921.470554; Thu, 17 Feb 2022 16:29:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKjfC-0005GA-Un; Thu, 17 Feb 2022 16:29:50 +0000
Received: by outflank-mailman (input) for mailman id 274921;
 Thu, 17 Feb 2022 16:29:50 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nKjfC-0005G4-H8
 for xen-devel@lists.xenproject.org; Thu, 17 Feb 2022 16:29:50 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nKjf7-000188-NW; Thu, 17 Feb 2022 16:29:45 +0000
Received: from 54-240-197-231.amazon.com ([54.240.197.231] helo=[10.7.236.18])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nKjf7-00046D-H5; Thu, 17 Feb 2022 16:29:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=a5hJ6sE6YIbun3pdVHiv4KDsA8J63QXFakflQfgHBnI=; b=KZncZyu78B8F8Yyx3OTHBJlpbQ
	PeRU9xo/2Ntq7qAP58RUM7ODDsniCWs/vWf4VomySui3A9tBwC4NsfeZ/Pa3RKK38aHk2Oodci2dK
	8VG6hho+qQRMFfCz8ah+vmD1B0gCK/fzEK4UOvBrCjKbm1LayeK+ByZVa444+fl8BBvQ=;
Message-ID: <bf8dba24-c4c2-5aa9-1cf7-cd5315d5b067@xen.org>
Date: Thu, 17 Feb 2022 16:29:43 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.1
Subject: Re: [XEN PATCH v9 04/30] build: set ALL_OBJS in main Makefile; move
 prelink.o to main Makefile
To: Jan Beulich <jbeulich@suse.com>,
 Anthony PERARD <anthony.perard@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 xen-devel@lists.xenproject.org
References: <20220125110103.3527686-1-anthony.perard@citrix.com>
 <20220125110103.3527686-5-anthony.perard@citrix.com>
 <9bd4d8e6-d426-97be-f1d4-429a793f888c@suse.com> <YfPUP6iAatz9JPaS@perard>
 <4c757048-bf9f-5743-a2e7-cbf5a7fd97d5@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <4c757048-bf9f-5743-a2e7-cbf5a7fd97d5@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 28/01/2022 11:41, Jan Beulich wrote:
> On 28.01.2022 12:32, Anthony PERARD wrote:
>> On Thu, Jan 27, 2022 at 04:50:32PM +0100, Jan Beulich wrote:
>>> On 25.01.2022 12:00, Anthony PERARD wrote:
>>>> --- a/xen/Makefile
>>>> +++ b/xen/Makefile
>>>> @@ -285,6 +285,16 @@ CFLAGS += -flto
>>>>   LDFLAGS-$(CONFIG_CC_IS_CLANG) += -plugin LLVMgold.so
>>>>   endif
>>>>   
>>>> +# Note that link order matters!
>>>
>>> Merely as a remark: I wonder how applicable that comment is anymore.
>>> If anything I'd expect it to be relevant to $(TARGET_SUBARCH)/head.o
>>> (Arm) and boot/built_in.o (x86), neither of which get named here.
>>
>> Indeed, the order here probably doesn't matter. I tried to build on x86
>> with the list reversed (so still leaving boot/ first) and the build
>> works. I didn't try to boot it.
> 
> It's quite unlikely for the order to matter at build time. Being able
> to boot the result is the minimum. Even then you can't be sure you
> merely avoided the problematic piece of code on the particular
> hardware you did the test on. Perhaps the most fragile parts are
> sections holding pointers which get processed in the order the linker
> put them. E.g. unexpected interdependencies between initcalls.
> 
>> Maybe it's time to retire the comment?
> 
> Probably, but Arm folks would want to confirm that's fine on their side
> as well.

Sorry I missed that comment. On Arm, the ordering is enforced in 
xen/arm/Makefile:

ALL_OBJS := $(TARGET_SUBARCH)/head.o $(ALL_OBJS)

AFAIK, the ordering in xen/Makefile doesn't matter to us. So I think the 
comment in xen/Makefile can be droppped.

That said, I always found this approach too magic. I have a TODO (low 
priority though) to enforce the ordering in the link script instead.

Anyway, I will build Xen with your branch and test it to confirm there 
are no changes.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Feb 17 17:03:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 17 Feb 2022 17:03:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274928.470565 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKkBH-0000zK-M2; Thu, 17 Feb 2022 17:02:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274928.470565; Thu, 17 Feb 2022 17:02:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKkBH-0000zD-Iu; Thu, 17 Feb 2022 17:02:59 +0000
Received: by outflank-mailman (input) for mailman id 274928;
 Thu, 17 Feb 2022 17:02:59 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=xzkl=TA=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nKkBG-0000z7-R5
 for xen-devel@lists.xenproject.org; Thu, 17 Feb 2022 17:02:58 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 73d31d92-9013-11ec-8eb8-a37418f5ba1a;
 Thu, 17 Feb 2022 18:02:56 +0100 (CET)
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur03lp2053.outbound.protection.outlook.com [104.47.9.53]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-13-iqJYVE2kOnC5xMYaYvygjA-1; Thu, 17 Feb 2022 18:02:48 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM5PR04MB3236.eurprd04.prod.outlook.com (2603:10a6:206:10::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.16; Thu, 17 Feb
 2022 17:02:47 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4995.016; Thu, 17 Feb 2022
 17:02:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 73d31d92-9013-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645117376;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=YXp4RbEIbzc2Q/K8u3a5bLeNx0tNOf/jd4Orl7119vU=;
	b=mJmbY3uPeEqejv1qoCD6T+HCCV9hDAnKTZyKnRcAaCB60XdKqouC2E2SUhjQyHpWQXzS9C
	rZN5h3Gpoc3FqhwF1DUVKS1KsR0DSirIKO/wu0lZMbPuve7bMaPDYoVyAQF7susAnObvW8
	xkzntKiUCMkRuYvM7Coxjjzs7vYcRd0=
X-MC-Unique: iqJYVE2kOnC5xMYaYvygjA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=NguKtD5JM5agdXafeDiEYWLzPsPhjnB/jiw5TUr6H/C6quBbL+WLQVx0yEtPp47YEn03l0yEFaVbM/RsskubcClPWNaR76GNy66nc+6Wz2SGYFnyAr1jNqMUCVNjHdGjAoG+JvBGzJaWRNVy4zvzo4ltKdf8SpHknghtKrMeS8NJIWqipvMfgQDfdWiapWLKUBX5sbHejb7R267s3xv8S74nn8WVqZcVojflqHDzcl9MsTG7OycQcCSZPWspo0ieufbZ6YvC5e+vJPRtKb1ayr/bd/bFwtyFPDM7on/smdL4bjhF31xSJtqILV+Bnt0pVwaOdx/9G1mbLsGsF0vHEA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=1b8je33a3kDzpyjFIEH//zYsdb7s/5A6gEIoDTLooGI=;
 b=SbvSoATf8XBj/Ezt4QP4IFNZ7YCGETIdQ0aQuZcyKBDUblE0tF2U9W6LIu30l9dFFd49dOfo6GKK5z4p/iy6z6CgVmHJl2QeHhpwSU4JZAB5VNCvfkSYB0VRZZV48RC+/A6f/0JpBefCK2leR0woET+wniJqR6XvW9QogpJxYXv6iwcOU2Et0uvMkJex84jtPZHDWs+VWnbn47kbPv71ux8brlYTsih9KzzdDd3JBldHMinzJyaH9MLnnNiIgCvU42pZQLQSbBlRH6OiKOVmMNp+m2xioTpb30zueCECK213SVfFTbYzk8WFswIxvrARVrCcxbEIOnvnrIqip0128Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <4f26b785-ae03-34a7-7dfc-d36121a44ac2@suse.com>
Date: Thu, 17 Feb 2022 18:02:45 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Content-Language: en-US
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Mateusz_M=c3=b3wka?= <mateusz.mowka@intel.com>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH v2] MAINTAINERS: update TXT section
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0318.eurprd06.prod.outlook.com
 (2603:10a6:20b:45b::18) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 600f9d3d-7dc4-4d5e-da0c-08d9f2375281
X-MS-TrafficTypeDiagnostic: AM5PR04MB3236:EE_
X-Microsoft-Antispam-PRVS:
	<AM5PR04MB3236D029A2DC335C19DF953DB3369@AM5PR04MB3236.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:345;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	WxKF2uDs1oMp/lRNrO0blqwiwtyHrxoXvh3bxj7EMu4pQjyjprNofz3ovfEIO919vrMk+NJViZLeg3M3vN8YQGr1O3SxwGC3ne2HdSeyFTK0mOa0JJAJEPrPgjInesYeJPHtPNpSpQdhjMhYjVURDEaQRtlDqQ2LHoZCBN10ixAZqI3y0xxvyPYErcy/HtSp4EOTUeN9Txb3Cj21vDBv79tGLxX4RivKsip8IPrb1OjW32xO1RCleGU1B+/X88k0oMAuHGI8YzsGGa+Dmc9Fi+DkGSjT4P810jSJj1IMatuYJ8rKGNhfJPuVIO191WKaPBzq+Gyvrs0U7g6qU4+n5ndj9jHw5PJh+Vz0TYyaSVpG0AX7H9LI3Ap90vl6Kt1I7N3QHxo/5R/nnhcXvbxJ6OFTl+rPSEKhp996HWIHBSqDAuZfIONc8I77wvXQ6ts1uyl9pzM62vyP/Zh4NAZbL3My7Q0dd8pKALk0HwifoQFmWh1+IZQ1FqrO9QX4PK4t6ezNVY2Il7GBDM8yFnHjJsP4q2g3JMdAcsknX+FDQOpmGQzt5ZcmVIzIrctECeAts7FHY4JB7nxNKTJkvNfn70gEhcvc3ygy98Av3VsLLvrVWGtik6AV2mqyEFUFL8QWPK+tP9JtyToToqM7VybRDYuXlu0PhFVHvo5uWhWpFPw+SDMqgdyfQvw91cWimsbmJZXFUYn6Faxi6Nopagm0yT8hfMq98JV614T0n1pDSN8=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(186003)(508600001)(6486002)(26005)(316002)(31696002)(6916009)(54906003)(4326008)(8676002)(2906002)(38100700002)(66556008)(66476007)(86362001)(66946007)(6512007)(8936002)(2616005)(4744005)(5660300002)(31686004)(36756003)(6506007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?tKTzKIQ3BMYBAXAQdinPLeMD+5aSSbq3uvrDATwXVFPrjej6uXxWm/rx+/p4?=
 =?us-ascii?Q?mysK2ChqSiXESgJlw8gnL3tl318rPVMC7PLZH3ktskKaCwgx23CQdTN/XKcj?=
 =?us-ascii?Q?9DX75mbcXBFkev8XqBx/dLou1RDLRpFK4V1rc8avm4DAlEIJi4wF44qunrw0?=
 =?us-ascii?Q?6t74CSRyVlOKp5koIhyDplDrCKeFjJpZGkIJrx/DPnAljUpKj1aMsIGZrO1F?=
 =?us-ascii?Q?PZCGcVm+RmGGhFRnC1v3+fWqS3ZOZNCRfWR8xB4XDiBzRS47X9R0yP6zTlMp?=
 =?us-ascii?Q?JnYCdhBqB+vYIa2Hyzq8PrB4yUTUT1EaXBIJXZDOT1Abt/rbE+WgKHefdS3h?=
 =?us-ascii?Q?9FoVai+DsGKhY2PTXlX9RLWYU9Z6bt0xEQA6VIaegdyzjy3qLKa9xSjUy4ev?=
 =?us-ascii?Q?snWBLe6/ADsoEwoIBugJBDRlS59C0q0d16zix6dJSoSUO7zvTuLll3oqxuLz?=
 =?us-ascii?Q?wJ8KGtf/0yaiav9V/Ire54dIY8GHcwYmdqPPg1odOdfU9p/qpNPFWLvUwuFW?=
 =?us-ascii?Q?O3cmPiRITHv5zh5BhoLGxWiJNBNKcO8K8VTLiu4K2c4OYs8AozkEOpnlFGQb?=
 =?us-ascii?Q?tKHJdqr8WYTH18XTB0pL1dKGF8M7PoM7rmP97K2EMoc1h6tqi1Vysr9eV7IN?=
 =?us-ascii?Q?UIEVozAr94xe1ZE3/m7DRndTNgrDolhVTm8MymNbhCXuP9orepZPaMB7NerE?=
 =?us-ascii?Q?dBv4/1dLz0MkMXJ5C9xsJ6i97y7Y00JyfY0psJofrzUkD6euN/7M4fV9SQfT?=
 =?us-ascii?Q?fP/uHoD9jHPWTBYdjYquklTsps6nKvDlpkL+/zeAxlxeYgQmygaiTygiT7G7?=
 =?us-ascii?Q?Um4DJUOxw/Hl+S2JDsjB1S3w+Jkzl0mIebbtRLljU7HrznGE/E20it5sZY9V?=
 =?us-ascii?Q?dhNhfVjUB7zTzTt2Bv1EbeG/c/OeU1uMTF4QajVyrDxZH1fUD4FQmTVvKcPa?=
 =?us-ascii?Q?B6nr/mBaNmvTiu95zQnTCcN74Z8za1jgHYWgw5JvYnW5AtEhT4ByW88j+yOk?=
 =?us-ascii?Q?lA6MJpRZOrya6UxHJFKa/V6w/+3vuSUniK/u2n4rhQsev7u397fkgc+yUNZO?=
 =?us-ascii?Q?d2b0pvy4s5GkEYtu02Ig/dh9c6GA1oiPmO7BuQMNgBXQJxgIuZNbOpIHr1Xg?=
 =?us-ascii?Q?FVXKgc7t3WFvgpGVNedJlWqyR9/Fye1LMny6C/Ps2yDaIYnhfNyvBkWssama?=
 =?us-ascii?Q?ubwFNfG+zI4tFhXwyjF/u209b4KbdtJG6efbKW9W8EltT1U7Ipvljb0N7i2w?=
 =?us-ascii?Q?KIAQ/mcXf8qNS4B8n1zUYv5Q/5O+hePBkgb33Jun2RrfTqB6+/dRfQVk399L?=
 =?us-ascii?Q?hS/h/nYw9ISd1Fcd20gh1yuGe3VfwrvZLLXw7gT5kYClEuqoD8hViGJBfOXw?=
 =?us-ascii?Q?1DoKAynFXkrE4FXVbXqHO3Hko9TP9S4RpI5sUpkWKT3aISLG+cWFKjhI87Mu?=
 =?us-ascii?Q?/d5ZEotCFHeAL4rHeYv+cqyYDR1WXZVunNsubUd5ycXbsYs3SmC7l/pzf8H0?=
 =?us-ascii?Q?7ISK3cESxPvrlYMJIkhT8h8nFu2GDdXsJV5oz+KpU75btM0eWDzhJEHoCaAc?=
 =?us-ascii?Q?EsG7PgRMf80jbaRNnAA26+tYZBXbtJ5UrPOHSYIkoIGAdXcZlZTkR/AApvQw?=
 =?us-ascii?Q?/7QitK9qoVcqXYdJpxxPwf0=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 600f9d3d-7dc4-4d5e-da0c-08d9f2375281
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2022 17:02:47.2875
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2oyq/Yibl2fjiK/107gyzIdTrWadPscCZQRJxtVIMh3gHdv9z6aR5M46K/dW8lbgIPoh4O7O2sX42hM+wZoetA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR04MB3236

Since Lukasz has left Intel, they have suggested a replacement contact.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
v2: Only add Mateusz, and only as reviewer.

--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -318,6 +318,7 @@ F:	xen/common/hypfs.c
 INTEL(R) TRUSTED EXECUTION TECHNOLOGY (TXT)
 R:	Lukasz Hawrylko <lukasz@hawrylko.pl>
 R:	Daniel P. Smith <dpsmith@apertussolutions.com>
+R:	Mateusz M=C3=B3wka <mateusz.mowka@intel.com>
 S:	Odd Fixes
 F:	xen/arch/x86/include/asm/tboot.h
 F:	xen/arch/x86/tboot.c



From xen-devel-bounces@lists.xenproject.org Thu Feb 17 18:32:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 17 Feb 2022 18:32:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274936.470576 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKlZI-0001Jn-F7; Thu, 17 Feb 2022 18:31:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274936.470576; Thu, 17 Feb 2022 18:31:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKlZI-0001Jg-BX; Thu, 17 Feb 2022 18:31:52 +0000
Received: by outflank-mailman (input) for mailman id 274936;
 Thu, 17 Feb 2022 18:31:51 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nKlZH-0001JW-6u; Thu, 17 Feb 2022 18:31:51 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nKlZH-0003Lz-2k; Thu, 17 Feb 2022 18:31:51 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nKlZG-0002n6-G6; Thu, 17 Feb 2022 18:31:50 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nKlZG-00085R-FS; Thu, 17 Feb 2022 18:31:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=90OiiyLo36+tP83EJYaAWYKhMEELqX/3omh8k8zlMJM=; b=X1a+gOT3Uc9ePYBgGfT3MuEBoc
	Kt+iCIQhpsPjFrGvSyWw3q0p8ityEVzEr3YaT36T9MkbPLlxh1BWnXuT55aSwIgws97m5RtBs23XB
	J8GP5rmPfJuIwRgLdTA/ZISPkp6/QafnPe9MqC+66UoLJsa/ytM5ggTgxNH9JhEAuoEo=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168145-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 168145: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-arm64-arm64-examine:reboot:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=e7c2017cf4a91ab6a0fea6adca2d9dd2ab1603b0
X-Osstest-Versions-That:
    xen=e7c2017cf4a91ab6a0fea6adca2d9dd2ab1603b0
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 17 Feb 2022 18:31:50 +0000

flight 168145 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168145/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 168129 pass in 168145
 test-arm64-arm64-examine      8 reboot                     fail pass in 168129
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 168129

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168129
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168129
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168129
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168129
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168129
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168129
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168129
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168129
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168129
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168129
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168129
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168129
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  e7c2017cf4a91ab6a0fea6adca2d9dd2ab1603b0
baseline version:
 xen                  e7c2017cf4a91ab6a0fea6adca2d9dd2ab1603b0

Last test of basis   168145  2022-02-17 01:54:29 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     fail    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Thu Feb 17 19:30:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 17 Feb 2022 19:30:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274949.470587 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKmTf-0007Lq-WF; Thu, 17 Feb 2022 19:30:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274949.470587; Thu, 17 Feb 2022 19:30:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKmTf-0007Lj-So; Thu, 17 Feb 2022 19:30:07 +0000
Received: by outflank-mailman (input) for mailman id 274949;
 Thu, 17 Feb 2022 19:30:07 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nKmTf-0007Jb-4J
 for xen-devel@lists.xenproject.org; Thu, 17 Feb 2022 19:30:07 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nKmTY-0004PK-Fb; Thu, 17 Feb 2022 19:30:00 +0000
Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nKmTY-0007yl-9v; Thu, 17 Feb 2022 19:30:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:
	References:Cc:To:From:Subject:MIME-Version:Date:Message-ID;
	bh=Fu/u7UAlCwfCHCQs6Ete1UHqGaTbhjjQ56FqhxJZVwM=; b=g/fNNw3VerBLuD6IkK/QLxdHe6
	pcZpYSp/v/Y61DDhM//7NlbcS0Kt7xiiBX51n2Q2keOARBmvSgjnW8jOUu5A1bQTaDxwJjqLmlLAR
	FZI5VP4Xvw+/FG0ioCNQ/Umb5b0JA0MAA36sCQWgiDAcf7irukzqjf97e96aqDWfsrJ4=;
Message-ID: <f10460a5-ec80-159e-ef8c-dc19e0452f00@xen.org>
Date: Thu, 17 Feb 2022 19:29:57 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.1
Subject: Re: [XEN PATCH v9 04/30] build: set ALL_OBJS in main Makefile; move
 prelink.o to main Makefile
From: Julien Grall <julien@xen.org>
To: Jan Beulich <jbeulich@suse.com>,
 Anthony PERARD <anthony.perard@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 xen-devel@lists.xenproject.org
References: <20220125110103.3527686-1-anthony.perard@citrix.com>
 <20220125110103.3527686-5-anthony.perard@citrix.com>
 <9bd4d8e6-d426-97be-f1d4-429a793f888c@suse.com> <YfPUP6iAatz9JPaS@perard>
 <4c757048-bf9f-5743-a2e7-cbf5a7fd97d5@suse.com>
 <bf8dba24-c4c2-5aa9-1cf7-cd5315d5b067@xen.org>
In-Reply-To: <bf8dba24-c4c2-5aa9-1cf7-cd5315d5b067@xen.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi,

On 17/02/2022 16:29, Julien Grall wrote:
> On 28/01/2022 11:41, Jan Beulich wrote:
>> On 28.01.2022 12:32, Anthony PERARD wrote:
>>> On Thu, Jan 27, 2022 at 04:50:32PM +0100, Jan Beulich wrote:
>>>> On 25.01.2022 12:00, Anthony PERARD wrote:
>>>>> --- a/xen/Makefile
>>>>> +++ b/xen/Makefile
>>>>> @@ -285,6 +285,16 @@ CFLAGS += -flto
>>>>>   LDFLAGS-$(CONFIG_CC_IS_CLANG) += -plugin LLVMgold.so
>>>>>   endif
>>>>> +# Note that link order matters!
>>>>
>>>> Merely as a remark: I wonder how applicable that comment is anymore.
>>>> If anything I'd expect it to be relevant to $(TARGET_SUBARCH)/head.o
>>>> (Arm) and boot/built_in.o (x86), neither of which get named here.
>>>
>>> Indeed, the order here probably doesn't matter. I tried to build on x86
>>> with the list reversed (so still leaving boot/ first) and the build
>>> works. I didn't try to boot it.
>>
>> It's quite unlikely for the order to matter at build time. Being able
>> to boot the result is the minimum. Even then you can't be sure you
>> merely avoided the problematic piece of code on the particular
>> hardware you did the test on. Perhaps the most fragile parts are
>> sections holding pointers which get processed in the order the linker
>> put them. E.g. unexpected interdependencies between initcalls.
>>
>>> Maybe it's time to retire the comment?
>>
>> Probably, but Arm folks would want to confirm that's fine on their side
>> as well.
> 
> Sorry I missed that comment. On Arm, the ordering is enforced in 
> xen/arm/Makefile:
> 
> ALL_OBJS := $(TARGET_SUBARCH)/head.o $(ALL_OBJS)
> 
> AFAIK, the ordering in xen/Makefile doesn't matter to us. So I think the 
> comment in xen/Makefile can be droppped.
> 
> That said, I always found this approach too magic. I have a TODO (low 
> priority though) to enforce the ordering in the link script instead.
> 
> Anyway, I will build Xen with your branch and test it to confirm there 
> are no changes.

Tested on Arm64. I confirm this can still boot :).

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Feb 17 19:30:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 17 Feb 2022 19:30:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274953.470598 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKmUF-0007pI-9h; Thu, 17 Feb 2022 19:30:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274953.470598; Thu, 17 Feb 2022 19:30:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKmUF-0007pB-5V; Thu, 17 Feb 2022 19:30:43 +0000
Received: by outflank-mailman (input) for mailman id 274953;
 Thu, 17 Feb 2022 19:30:42 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nKmUE-0007ox-7x
 for xen-devel@lists.xenproject.org; Thu, 17 Feb 2022 19:30:42 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nKmUD-0004Ry-N1; Thu, 17 Feb 2022 19:30:41 +0000
Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nKmUD-00080k-HO; Thu, 17 Feb 2022 19:30:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=USOWqZaYG6maOXGpy3mseZWGLjYQggOgaUd3Qm0AgWk=; b=MHJ0u5H5aqTn2ub4jJ11pD7Vtl
	4GUcinpj/Hp3Zk+qmaSWjayntP0PB5EDvAMA8dqHLctg3StkiXYYk4YlyFZo7J9ywcLJbDKsyEqbF
	Whw+CaGYIZYA/XO8ies21SKQtavIjh78gYT1G5YXTPvmbKNqx7mx/k9x7YF1EEVuNL7Q=;
Message-ID: <b7f3e614-eebb-8247-c540-8e8a853c679c@xen.org>
Date: Thu, 17 Feb 2022 19:30:39 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.1
Subject: Re: [XEN PATCH v9 04/30] build: set ALL_OBJS in main Makefile; move
 prelink.o to main Makefile
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <20220125110103.3527686-1-anthony.perard@citrix.com>
 <20220125110103.3527686-5-anthony.perard@citrix.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220125110103.3527686-5-anthony.perard@citrix.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Anthony,

On 25/01/2022 11:00, Anthony PERARD wrote:
> This is to avoid arch/$arch/Makefile having to recurse into parents
> directories.
> 
> This avoid duplication of the logic to build prelink.o between arches.
> 
> In order to do that, we cut the $(TARGET) target in the main Makefile in
> two, there is a "prepare" phase/target runned before starting to build
> "prelink.o" which will prepare "include/" among other things, then all
> the $(ALL_OBJS) will be generated in order to build "prelink.o" and
> finally $(TARGET) will be generated by calling into "arch/*/" to make
> $(TARGET).
> 
> Now we don't need to prefix $(ALL_OBJS) with $(BASEDIR) as it is now
> only used from the main Makefile. Other changes is to use "$<" instead
> of spelling "prelink.o" in the target "$(TARGET)" in both
> arch/*/Makefile.
> 
> Beside "prelink.o" been at a different location, no other functional
> change intended.
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Acked-by: Julien Grall <jgrall@amazon.com>

Cheers,

> ---
> 
> Notes:
>      v9:
>      - set ALL_OBJS and ALL_LIBS on make command line instead of exporting
>        them.
>      - arm/Rules.mk, have one rule instead of two for head.o
>      - fix typo in title
>      
>      v8:
>      - rebased
>      - move Arm specific dependencies between $(ALL_OBJS) objects (head.o)
>        into Arm specific "Rules.mk" instead of the common "build.mk".
>      
>      v7:
>      - change, now things are in build.mk: no more prepare phase needed
> 
>   xen/Makefile          | 12 +++++++++++-
>   xen/Rules.mk          | 13 -------------
>   xen/arch/arm/Makefile | 31 ++++---------------------------
>   xen/arch/arm/Rules.mk |  4 ++++
>   xen/arch/arm/arch.mk  |  2 ++
>   xen/arch/x86/Makefile | 29 ++++++-----------------------
>   xen/arch/x86/arch.mk  |  2 ++
>   xen/build.mk          | 18 ++++++++++++++++++
>   8 files changed, 47 insertions(+), 64 deletions(-)
> 
> diff --git a/xen/Makefile b/xen/Makefile
> index fb37043d08e0..d953dc50ac6a 100644
> --- a/xen/Makefile
> +++ b/xen/Makefile
> @@ -285,6 +285,16 @@ CFLAGS += -flto
>   LDFLAGS-$(CONFIG_CC_IS_CLANG) += -plugin LLVMgold.so
>   endif
>   
> +# Note that link order matters!
> +ALL_OBJS-y                := common/built_in.o
> +ALL_OBJS-y                += drivers/built_in.o
> +ALL_OBJS-y                += lib/built_in.o
> +ALL_OBJS-y                += xsm/built_in.o
> +ALL_OBJS-y                += arch/$(TARGET_ARCH)/built_in.o
> +ALL_OBJS-$(CONFIG_CRYPTO) += crypto/built_in.o
> +
> +ALL_LIBS-y                := lib/lib.a
> +
>   include $(BASEDIR)/arch/$(TARGET_ARCH)/arch.mk
>   
>   # define new variables to avoid the ones defined in Config.mk
> @@ -407,7 +417,7 @@ $(TARGET): FORCE
>   	$(MAKE) -f $(BASEDIR)/Rules.mk -C include
>   	$(MAKE) -f $(BASEDIR)/Rules.mk -C arch/$(TARGET_ARCH) include
>   	$(MAKE) -f $(BASEDIR)/Rules.mk arch/$(TARGET_ARCH)/include/asm/asm-offsets.h
> -	$(MAKE) -f $(BASEDIR)/Rules.mk -C arch/$(TARGET_ARCH) MKRELOC=$(MKRELOC) $@
> +	$(MAKE) -f $(BASEDIR)/Rules.mk MKRELOC=$(MKRELOC) "ALL_OBJS=$(ALL_OBJS-y)" "ALL_LIBS=$(ALL_LIBS-y)" $@
>   
>   SUBDIRS = xsm arch/$(TARGET_ARCH) common drivers lib test
>   define all_sources
> diff --git a/xen/Rules.mk b/xen/Rules.mk
> index 7b8b9047cfd5..77d359bedaf8 100644
> --- a/xen/Rules.mk
> +++ b/xen/Rules.mk
> @@ -8,25 +8,12 @@
>   include $(XEN_ROOT)/Config.mk
>   include $(BASEDIR)/scripts/Kbuild.include
>   
> -# Note that link order matters!
> -ALL_OBJS-y               += $(BASEDIR)/common/built_in.o
> -ALL_OBJS-y               += $(BASEDIR)/drivers/built_in.o
> -ALL_OBJS-y               += $(BASEDIR)/lib/built_in.o
> -ALL_OBJS-y               += $(BASEDIR)/xsm/built_in.o
> -ALL_OBJS-y               += $(BASEDIR)/arch/$(TARGET_ARCH)/built_in.o
> -ALL_OBJS-$(CONFIG_CRYPTO)   += $(BASEDIR)/crypto/built_in.o
> -
> -ALL_LIBS-y               := $(BASEDIR)/lib/lib.a
> -
>   # Initialise some variables
>   lib-y :=
>   targets :=
>   CFLAGS-y :=
>   AFLAGS-y :=
>   
> -ALL_OBJS := $(ALL_OBJS-y)
> -ALL_LIBS := $(ALL_LIBS-y)
> -
>   SPECIAL_DATA_SECTIONS := rodata $(foreach a,1 2 4 8 16, \
>                                               $(foreach w,1 2 4, \
>                                                           rodata.str$(w).$(a)) \
> diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile
> index d0dee10102b6..14952275772b 100644
> --- a/xen/arch/arm/Makefile
> +++ b/xen/arch/arm/Makefile
> @@ -75,14 +75,6 @@ ifneq ($(CONFIG_DTB_FILE),"")
>   obj-y += dtb.o
>   endif
>   
> -ALL_OBJS := $(TARGET_SUBARCH)/head.o $(ALL_OBJS)
> -
> -# head.o is built by descending into the sub-directory, depends on the part of
> -# $(ALL_OBJS) that will eventually recurse into $(TARGET_SUBARCH)/ and build
> -# head.o
> -$(TARGET_SUBARCH)/head.o: $(BASEDIR)/arch/arm/built_in.o
> -$(TARGET_SUBARCH)/head.o: ;
> -
>   ifdef CONFIG_LIVEPATCH
>   all_symbols = --all-symbols
>   ifdef CONFIG_FAST_SYMBOL_LOOKUP
> @@ -98,33 +90,18 @@ ifeq ($(CONFIG_ARM_64),y)
>   	ln -sf $(@F) $@.efi
>   endif
>   
> -ifeq ($(CONFIG_LTO),y)
> -# Gather all LTO objects together
> -prelink_lto.o: $(ALL_OBJS) $(ALL_LIBS)
> -	$(LD_LTO) -r -o $@ $(filter-out %.a,$^) --start-group $(filter %.a,$^) --end-group
> -
> -# Link it with all the binary objects
> -prelink.o: $(patsubst %/built_in.o,%/built_in_bin.o,$(ALL_OBJS)) prelink_lto.o
> -	$(call if_changed,ld)
> -else
> -prelink.o: $(ALL_OBJS) $(ALL_LIBS) FORCE
> -	$(call if_changed,ld)
> -endif
> -
> -targets += prelink.o
> -
> -$(TARGET)-syms: prelink.o xen.lds
> -	$(LD) $(XEN_LDFLAGS) -T xen.lds -N prelink.o \
> +$(TARGET)-syms: $(BASEDIR)/prelink.o xen.lds
> +	$(LD) $(XEN_LDFLAGS) -T xen.lds -N $< \
>   	    $(BASEDIR)/common/symbols-dummy.o -o $(@D)/.$(@F).0
>   	$(NM) -pa --format=sysv $(@D)/.$(@F).0 \
>   		| $(BASEDIR)/tools/symbols $(all_symbols) --sysv --sort >$(@D)/.$(@F).0.S
>   	$(MAKE) -f $(BASEDIR)/Rules.mk $(@D)/.$(@F).0.o
> -	$(LD) $(XEN_LDFLAGS) -T xen.lds -N prelink.o \
> +	$(LD) $(XEN_LDFLAGS) -T xen.lds -N $< \
>   	    $(@D)/.$(@F).0.o -o $(@D)/.$(@F).1
>   	$(NM) -pa --format=sysv $(@D)/.$(@F).1 \
>   		| $(BASEDIR)/tools/symbols $(all_symbols) --sysv --sort >$(@D)/.$(@F).1.S
>   	$(MAKE) -f $(BASEDIR)/Rules.mk $(@D)/.$(@F).1.o
> -	$(LD) $(XEN_LDFLAGS) -T xen.lds -N prelink.o $(build_id_linker) \
> +	$(LD) $(XEN_LDFLAGS) -T xen.lds -N $< $(build_id_linker) \
>   	    $(@D)/.$(@F).1.o -o $@
>   	$(NM) -pa --format=sysv $(@D)/$(@F) \
>   		| $(BASEDIR)/tools/symbols --all-symbols --xensyms --sysv --sort \
> diff --git a/xen/arch/arm/Rules.mk b/xen/arch/arm/Rules.mk
> index e69de29bb2d1..c6463a433efd 100644
> --- a/xen/arch/arm/Rules.mk
> +++ b/xen/arch/arm/Rules.mk
> @@ -0,0 +1,4 @@
> +# head.o is built by descending into arch/arm/$(TARGET_SUBARCH), depends on the
> +# part of $(ALL_OBJS) that will eventually recurse into $(TARGET_SUBARCH)/ and
> +# build head.o
> +arch/arm/$(TARGET_SUBARCH)/head.o: arch/arm/built_in.o ;
> diff --git a/xen/arch/arm/arch.mk b/xen/arch/arm/arch.mk
> index c3ac443b3788..ba3f140e2ea7 100644
> --- a/xen/arch/arm/arch.mk
> +++ b/xen/arch/arm/arch.mk
> @@ -26,3 +26,5 @@ ifeq ($(CONFIG_ARM64_ERRATUM_843419),y)
>           LDFLAGS += --fix-cortex-a53-843419
>       endif
>   endif
> +
> +ALL_OBJS-y := arch/arm/$(TARGET_SUBARCH)/head.o $(ALL_OBJS-y)
> diff --git a/xen/arch/x86/Makefile b/xen/arch/x86/Makefile
> index 9fc884813cb5..a830b5791e8b 100644
> --- a/xen/arch/x86/Makefile
> +++ b/xen/arch/x86/Makefile
> @@ -123,37 +123,20 @@ $(TARGET): $(TARGET)-syms $(efi-y) boot/mkelf32
>   
>   CFLAGS-$(XEN_BUILD_EFI) += -DXEN_BUILD_EFI
>   
> -ALL_OBJS := $(BASEDIR)/arch/x86/boot/built_in.o $(BASEDIR)/arch/x86/efi/built_in.o $(ALL_OBJS)
> -
> -ifeq ($(CONFIG_LTO),y)
> -# Gather all LTO objects together
> -prelink_lto.o: $(ALL_OBJS) $(ALL_LIBS)
> -	$(LD_LTO) -r -o $@ $(filter-out %.a,$^) --start-group $(filter %.a,$^) --end-group
> -
> -# Link it with all the binary objects
> -prelink.o: $(patsubst %/built_in.o,%/built_in_bin.o,$(ALL_OBJS)) prelink_lto.o FORCE
> -	$(call if_changed,ld)
> -else
> -prelink.o: $(ALL_OBJS) $(ALL_LIBS) FORCE
> -	$(call if_changed,ld)
> -endif
> -
> -targets += prelink.o
> -
> -$(TARGET)-syms: prelink.o xen.lds
> -	$(LD) $(XEN_LDFLAGS) -T xen.lds -N prelink.o $(build_id_linker) \
> +$(TARGET)-syms: $(BASEDIR)/prelink.o xen.lds
> +	$(LD) $(XEN_LDFLAGS) -T xen.lds -N $< $(build_id_linker) \
>   	    $(BASEDIR)/common/symbols-dummy.o -o $(@D)/.$(@F).0
>   	$(NM) -pa --format=sysv $(@D)/.$(@F).0 \
>   		| $(BASEDIR)/tools/symbols $(all_symbols) --sysv --sort \
>   		>$(@D)/.$(@F).0.S
>   	$(MAKE) -f $(BASEDIR)/Rules.mk $(@D)/.$(@F).0.o
> -	$(LD) $(XEN_LDFLAGS) -T xen.lds -N prelink.o $(build_id_linker) \
> +	$(LD) $(XEN_LDFLAGS) -T xen.lds -N $< $(build_id_linker) \
>   	    $(@D)/.$(@F).0.o -o $(@D)/.$(@F).1
>   	$(NM) -pa --format=sysv $(@D)/.$(@F).1 \
>   		| $(BASEDIR)/tools/symbols $(all_symbols) --sysv --sort $(syms-warn-dup-y) \
>   		>$(@D)/.$(@F).1.S
>   	$(MAKE) -f $(BASEDIR)/Rules.mk $(@D)/.$(@F).1.o
> -	$(LD) $(XEN_LDFLAGS) -T xen.lds -N prelink.o $(build_id_linker) \
> +	$(LD) $(XEN_LDFLAGS) -T xen.lds -N $< $(build_id_linker) \
>   	    $(@D)/.$(@F).1.o -o $@
>   	$(NM) -pa --format=sysv $(@D)/$(@F) \
>   		| $(BASEDIR)/tools/symbols --all-symbols --xensyms --sysv --sort \
> @@ -206,7 +189,7 @@ note_file_option ?= $(note_file)
>   
>   ifeq ($(XEN_BUILD_PE),y)
>   extra-y += efi.lds
> -$(TARGET).efi: prelink.o $(note_file) efi.lds efi/relocs-dummy.o efi/mkreloc
> +$(TARGET).efi: $(BASEDIR)/prelink.o $(note_file) efi.lds efi/relocs-dummy.o efi/mkreloc
>   ifeq ($(CONFIG_DEBUG_INFO),y)
>   	$(if $(filter --strip-debug,$(EFI_LDFLAGS)),echo,:) "Will strip debug info from $(@F)"
>   endif
> @@ -235,7 +218,7 @@ $(TARGET).efi: FORCE
>   	echo '$(if $(filter y,$(XEN_BUILD_EFI)),xen.efi generation,EFI support) disabled'
>   endif
>   
> -efi/buildid.o efi/relocs-dummy.o: $(BASEDIR)/arch/x86/efi/built_in.o
> +# These should already have been rebuilt when building the prerequisite of "prelink.o"
>   efi/buildid.o efi/relocs-dummy.o: ;
>   
>   .PHONY: include
> diff --git a/xen/arch/x86/arch.mk b/xen/arch/x86/arch.mk
> index fa7cf3844362..bfd5eaa35f25 100644
> --- a/xen/arch/x86/arch.mk
> +++ b/xen/arch/x86/arch.mk
> @@ -104,3 +104,5 @@ endif
>   
>   # Set up the assembler include path properly for older toolchains.
>   CFLAGS += -Wa,-I$(BASEDIR)/include
> +
> +ALL_OBJS-y := arch/x86/boot/built_in.o arch/x86/efi/built_in.o $(ALL_OBJS-y)
> diff --git a/xen/build.mk b/xen/build.mk
> index 3d7a91df22d1..af1b28311393 100644
> --- a/xen/build.mk
> +++ b/xen/build.mk
> @@ -59,3 +59,21 @@ arch/$(TARGET_ARCH)/include/asm/asm-offsets.h: asm-offsets.s
>   	  sed -rne "/^[^#].*==>/{s:.*==>(.*)<==.*:\1:; s: [\$$#]: :; p;}"; \
>   	  echo ""; \
>   	  echo "#endif") <$< >$@
> +
> +ifeq ($(CONFIG_LTO),y)
> +# Gather all LTO objects together
> +prelink_lto.o: $(ALL_OBJS) $(ALL_LIBS)
> +	$(LD_LTO) -r -o $@ $(filter-out %.a,$^) --start-group $(filter %.a,$^) --end-group
> +
> +# Link it with all the binary objects
> +prelink.o: $(patsubst %/built_in.o,%/built_in_bin.o,$(ALL_OBJS)) prelink_lto.o FORCE
> +	$(call if_changed,ld)
> +else
> +prelink.o: $(ALL_OBJS) $(ALL_LIBS) FORCE
> +	$(call if_changed,ld)
> +endif
> +
> +targets += prelink.o
> +
> +$(TARGET): prelink.o FORCE
> +	$(MAKE) -f $(BASEDIR)/Rules.mk -C arch/$(TARGET_ARCH) $@

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Feb 17 19:32:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 17 Feb 2022 19:32:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274963.470609 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKmVy-0008Vl-Jm; Thu, 17 Feb 2022 19:32:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274963.470609; Thu, 17 Feb 2022 19:32:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKmVy-0008Ve-GY; Thu, 17 Feb 2022 19:32:30 +0000
Received: by outflank-mailman (input) for mailman id 274963;
 Thu, 17 Feb 2022 19:32:29 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nKmVx-0008VQ-8L
 for xen-devel@lists.xenproject.org; Thu, 17 Feb 2022 19:32:29 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nKmVu-0004Ty-Lf; Thu, 17 Feb 2022 19:32:26 +0000
Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nKmVu-00085Z-GH; Thu, 17 Feb 2022 19:32:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=HucGBESsRWJC7dzzmFYEr3QpNJw6JJwcEf+iP1Cl0FE=; b=6F12dy0pyq8/f1IV4fTWJG4Ma/
	DyHAh1h808zL4ELgY/wWLjNigt08uZ/KsxB+EQk2BAoRA9uW30XY1qBpe8UBwBFZrSxF1nRsdKGHQ
	s0S/5ZZZVH/2qUZya80S4BXbjTksB0oB+/2wFq82Q+t5NnluGCKuKiFH8Z37TeaGCNwQ=;
Message-ID: <7fae5d20-f5fc-8858-c18b-fc2dff89e15c@xen.org>
Date: Thu, 17 Feb 2022 19:32:23 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.1
Subject: Re: [XEN PATCH v9 20/30] build: rework "clean" to clean from the root
 dir
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Jan Beulich <jbeulich@suse.com>, Andrew Cooper
 <andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
 Ross Lagerwall <ross.lagerwall@citrix.com>,
 Daniel De Graaf <dgdegra@tycho.nsa.gov>,
 "Daniel P. Smith" <dpsmith@apertussolutions.com>
References: <20220125110103.3527686-1-anthony.perard@citrix.com>
 <20220125110103.3527686-21-anthony.perard@citrix.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220125110103.3527686-21-anthony.perard@citrix.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Anthony,

On 25/01/2022 11:00, Anthony PERARD wrote:
> This will allow "clean" to work from an out-of-tree build when
> it will be available.
> 
> Some of the file been removed in current "clean" target aren't added
> to $(clean-files) because they are already listed in $(extra-) or
> $(extra-y).
> 
> Also start to clean files listed in $(targets). This allows to clean
> "common/config_data.S" and "xsm/flask/flask-policy.S" without
> having to list them a second time.
> 
> Also clean files in "arch/x86/boot" from that directory by allowing
> "clean" to descend into the subdir by adding "boot" into $(subdir-).
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> Reviewed-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Julien Grall <jgrall@amazon.com>

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Feb 17 19:36:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 17 Feb 2022 19:36:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274970.470620 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKmZP-0000jl-2q; Thu, 17 Feb 2022 19:36:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274970.470620; Thu, 17 Feb 2022 19:36:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKmZO-0000je-Vz; Thu, 17 Feb 2022 19:36:02 +0000
Received: by outflank-mailman (input) for mailman id 274970;
 Thu, 17 Feb 2022 19:36:01 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nKmZN-0000jY-4E
 for xen-devel@lists.xenproject.org; Thu, 17 Feb 2022 19:36:01 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nKmZK-0004YG-Hs; Thu, 17 Feb 2022 19:35:58 +0000
Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nKmZK-00006k-Bp; Thu, 17 Feb 2022 19:35:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=xq3ofygjMKSKuKTtVeabYxNwbicydvZfsrah2LpbYg0=; b=OMBkrot6LxhYEdjbZsZGxpPsc0
	KkqhNjH5J0JTBEwYPfxv/svBI/zBEkQwpwHLojuCCnSkR5pfJ9IIKfAV0mkgk54xGosU+nZVkw2Zc
	zWAmgBPF6uc0Gd0VeM+3mMGwdaCy4gMYWOPgxOdTtOCe9Yzca3JjbQLqpFlkGI5gdnV0=;
Message-ID: <4162e249-3a75-eb31-0871-71261af88247@xen.org>
Date: Thu, 17 Feb 2022 19:35:55 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.1
Subject: Re: [XEN PATCH v9 30/30] build: adding out-of-tree support to the xen
 build
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Jan Beulich <jbeulich@suse.com>, Andrew Cooper
 <andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
 Ross Lagerwall <ross.lagerwall@citrix.com>,
 Daniel De Graaf <dgdegra@tycho.nsa.gov>,
 "Daniel P. Smith" <dpsmith@apertussolutions.com>
References: <20220125110103.3527686-1-anthony.perard@citrix.com>
 <20220125110103.3527686-31-anthony.perard@citrix.com>
 <Ye/g7P0wV5Vj8OoT@perard>
From: Julien Grall <julien@xen.org>
In-Reply-To: <Ye/g7P0wV5Vj8OoT@perard>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Anthony,

On 25/01/2022 11:37, Anthony PERARD wrote:
> On Tue, Jan 25, 2022 at 11:01:03AM +0000, Anthony PERARD wrote:
>> This implement out-of-tree support, there's two ways to create an
>> out-of-tree build tree (after that, `make` in that new directory
>> works):
>>      make O=build
>>      mkdir build; cd build; make -f ../Makefile
>> also works with an absolute path for both.
> 
> Maybe I should have made it more explicit in the description that those
> only works within the xen dir, i.e. not the whole project.

That would be useful. In any case:

Acked-by: Julien Grall <jgrall@amazon.com>
Tested-by: Julien Grall <jgrall@amazon.com>

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Feb 17 19:38:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 17 Feb 2022 19:38:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274977.470631 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKmbX-0001MT-FV; Thu, 17 Feb 2022 19:38:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274977.470631; Thu, 17 Feb 2022 19:38:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKmbX-0001MM-Ba; Thu, 17 Feb 2022 19:38:15 +0000
Received: by outflank-mailman (input) for mailman id 274977;
 Thu, 17 Feb 2022 19:38:15 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nKmbX-0001MG-2I
 for xen-devel@lists.xenproject.org; Thu, 17 Feb 2022 19:38:15 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nKmbW-0004aG-LU; Thu, 17 Feb 2022 19:38:14 +0000
Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nKmbW-0000Kh-FJ; Thu, 17 Feb 2022 19:38:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=2IITUzmyPBjpNe7wLaUepcfDbEOPcOl0QoxUFjHGfjU=; b=WxotjB2QaGnJChqIByogbFS1bU
	lVLlISlxL6sbnR9VxUGIWzitNtHze7dOCbuXwEJY4pfNwWVDb8vTqUjTdaYcqb6VYR2iZpfwCOes5
	lcas3bZTVocaE+cwp3zyXhfRzxLDL4pxanBXSnXfYdHelxTYbJo2YDGfQaPdTobQA+Tg=;
Message-ID: <5f1d5525-3c3f-bad9-3448-c266d0ad5004@xen.org>
Date: Thu, 17 Feb 2022 19:38:12 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.1
Subject: Re: [PATCH v2] docs: add some clarification to xenstore-migration.md
To: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
References: <20220217114726.8994-1-jgross@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220217114726.8994-1-jgross@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Juergen,

On 17/02/2022 11:47, Juergen Gross wrote:
> The Xenstore migration document is missing the specification that a
> node record must be preceded by the record of its parent node in case
> of live update.
The patch also cover normal migration. So I think you want to drop " in 
case of live update".

I can do the modification on commit:

Acked-by: Julien Grall <jgrall@amazon.com>

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Feb 17 19:47:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 17 Feb 2022 19:47:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274984.470642 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKmk9-0002oy-BE; Thu, 17 Feb 2022 19:47:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274984.470642; Thu, 17 Feb 2022 19:47:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKmk9-0002or-7z; Thu, 17 Feb 2022 19:47:09 +0000
Received: by outflank-mailman (input) for mailman id 274984;
 Thu, 17 Feb 2022 19:47:08 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nKmk8-0002ol-6Q
 for xen-devel@lists.xenproject.org; Thu, 17 Feb 2022 19:47:08 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nKmk7-0004kG-TJ; Thu, 17 Feb 2022 19:47:07 +0000
Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nKmk7-0001Mx-Nm; Thu, 17 Feb 2022 19:47:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:
	References:Cc:To:From:Subject:MIME-Version:Date:Message-ID;
	bh=R8vjhRB9J2oZT2Tu2BwVDR8D2Dttl7pUedpYcP58Zxg=; b=67/6P/mUT6zvgmoocy3XbtnEXB
	alNxlYncGkJ/mlVZGr8/ClFFqwLomK4Mu33pfRG2oJ76m/dat/CVtcaVTCEvfVMWViB1LQM0s9KWv
	ZyOtWkSSQocycc/CWRjonh4E7jJtSNsxDN/Y5HSGPQ2IT7QULvYBxhYEWt9rpghFUgwc=;
Message-ID: <32c0c8f9-6e34-1a1a-3638-d3f68b7d6819@xen.org>
Date: Thu, 17 Feb 2022 19:47:05 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.1
Subject: Re: [PATCH v6 02/11] xen: introduce CDF_directmap
From: Julien Grall <julien@xen.org>
To: Penny Zheng <penny.zheng@arm.com>
Cc: Bertrand.Marquis@arm.com, Wei.Chen@arm.com,
 xen-devel@lists.xenproject.org, sstabellini@kernel.org
References: <20220214031956.3726764-1-penny.zheng@arm.com>
 <20220214031956.3726764-3-penny.zheng@arm.com>
 <eb39c5a6-f5b1-ccf3-8d2b-802ae7da68d0@xen.org>
 <cdaf49b1-e64a-c104-3b79-a1633a67ee07@suse.com>
 <7d934fd7-b1e2-8a9e-10dd-a213db93c689@xen.org>
In-Reply-To: <7d934fd7-b1e2-8a9e-10dd-a213db93c689@xen.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi,

On 17/02/2022 11:01, Julien Grall wrote:
> On 16/02/2022 09:34, Jan Beulich wrote:
>> On 15.02.2022 21:26, Julien Grall wrote:
>>> (+ Jan)
>>>
>>> Hi Penny,
>>>
>>> I am CCing Jan to give him a chance to...
>>
>> Thanks, but ...
>>
>>> On 14/02/2022 03:19, Penny Zheng wrote:
>>>> diff --git a/xen/include/xen/domain.h b/xen/include/xen/domain.h
>>>> index cfb0b47f13..24eb4cc7d3 100644
>>>> --- a/xen/include/xen/domain.h
>>>> +++ b/xen/include/xen/domain.h
>>>> @@ -31,6 +31,10 @@ void arch_get_domain_info(const struct domain *d,
>>>>    /* CDF_* constant. Internal flags for domain creation. */
>>>>    /* Is this a privileged domain? */
>>>>    #define CDF_privileged           (1U << 0)
>>>> +#ifdef CONFIG_ARM
>>>> +/* Should domain memory be directly mapped? */
>>>> +#define CDF_directmap            (1U << 1)
>>>> +#endif
>>>
>>> ... comment on this approach. I would be happy to switch to an ASSERT()
>>> if that's preferred.
>>
>> ... I think I did signal agreement with this approach beforehand.
> 
> You raised a concern and it wasn't 100% obvious whether you would still 
> be happy if we merged it as-is.
> 
> So I preferred to ask rather than merging it and getting an angry 
> e-mail/message afterwards :).
> 
> Anyway, this series is now fully acked. So I will commit the series in a 
> bit.

Well, I forgot to explicitely Acked this patch. So:

Acked-by: Julien Grall <jgrall@amazon.com>

This series is now fully committed. Thank you for your contribution!

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Feb 17 19:55:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 17 Feb 2022 19:55:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.274995.470661 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKms6-0004Ns-AG; Thu, 17 Feb 2022 19:55:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 274995.470661; Thu, 17 Feb 2022 19:55:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKms6-0004Nl-6n; Thu, 17 Feb 2022 19:55:22 +0000
Received: by outflank-mailman (input) for mailman id 274995;
 Thu, 17 Feb 2022 19:55:20 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nKms4-0004NX-To
 for xen-devel@lists.xenproject.org; Thu, 17 Feb 2022 19:55:20 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nKms4-0004vC-Ju; Thu, 17 Feb 2022 19:55:20 +0000
Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nKms4-0001yF-Ed; Thu, 17 Feb 2022 19:55:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=o+x8fuWDLPE8tVuDYD0qKnOM1zogr7tYTO9oUybEp3w=; b=CbKjcm3EnpBSl1qSUn+6JrEEmF
	k5GxUs9vew7R2jxZHrwFf3DCFAGU4ugVAwhDdX3nYgeO7a/es/dkT3NqF48KxS/pT48Dk/I81h221
	DN9JrGmSbsCrhtwMqVN1ycv6cYVAiFCsjtRnTO9rRo0EQqzlHzb1O9rmVtbFrfaHxLNE=;
Message-ID: <eea83d0a-a96d-f050-c6ac-7dad731a16f0@xen.org>
Date: Thu, 17 Feb 2022 19:55:18 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.1
Subject: Re: [PATCH v2 2/2] xen/include/public: deprecate GNTTABOP_transfer
To: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
References: <20220203131418.1319-1-jgross@suse.com>
 <20220203131418.1319-2-jgross@suse.com>
 <a35bb9ba-e2be-f73e-9272-906bc09d9b6e@xen.org>
 <93e50bc4-6e53-b753-c520-7d1d0a5a5f5a@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <93e50bc4-6e53-b753-c520-7d1d0a5a5f5a@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi,

On 16/02/2022 07:20, Juergen Gross wrote:
> On 15.02.22 22:13, Julien Grall wrote:
>> Hi Juergen,
>>
>> On 03/02/2022 13:14, Juergen Gross wrote:
>>> Add a comment to include/public/grant_table.h that GNTTABOP_transfer
>>> is deprecated, in order to discourage new use cases.
>>
>>  From the commit message, it is unclear to me why we are discouraging 
>> new use cases and indirectly encouraging current users to move away 
>> from the feature.
>>
>> Patch #1 seems to imply this is because the feature is not present in 
>> Linux upstream. But I don't think this is a sufficient reason to 
>> deprecate a feature.
>>
>> A more compelling reason would be that the feature is broken and too 
>> complex to fix it.
>>
>> So can you provide more details?
> 
> It is a feature available for PV domains only, and it is very complex
> and hasn't been tested for ages.

Right. To reply to Jan's e-mail here, shouldn't we also de-support 
(either completely or security) in this case?

My concern here is you wrote this code has been untested for ages (not 
clear how long) and complex. So potentially this means there are 
security issues in it.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Feb 17 20:15:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 17 Feb 2022 20:15:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275011.470708 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKnBl-0007HE-Fu; Thu, 17 Feb 2022 20:15:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275011.470708; Thu, 17 Feb 2022 20:15:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKnBl-0007H7-CU; Thu, 17 Feb 2022 20:15:41 +0000
Received: by outflank-mailman (input) for mailman id 275011;
 Thu, 17 Feb 2022 20:15:40 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=K7LG=TA=wind.enjellic.com=greg@srs-se1.protection.inumbo.net>)
 id 1nKnBk-0007H1-QK
 for xen-devel@lists.xen.org; Thu, 17 Feb 2022 20:15:40 +0000
Received: from wind.enjellic.com (wind.enjellic.com [76.10.64.91])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 5dee8133-902e-11ec-8723-dd0c611c5f35;
 Thu, 17 Feb 2022 21:15:38 +0100 (CET)
Received: from wind.enjellic.com (localhost [127.0.0.1])
 by wind.enjellic.com (8.15.2/8.15.2) with ESMTP id 21HKFY7Z029544;
 Thu, 17 Feb 2022 14:15:34 -0600
Received: (from greg@localhost)
 by wind.enjellic.com (8.15.2/8.15.2/Submit) id 21HKFY8l029543;
 Thu, 17 Feb 2022 14:15:34 -0600
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5dee8133-902e-11ec-8723-dd0c611c5f35
Date: Thu, 17 Feb 2022 14:15:34 -0600
From: "Dr. Greg" <greg@enjellic.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "Dr. Greg" <greg@enjellic.com>, xen-devel@lists.xen.org
Subject: Re: IGD pass-through failures since 4.10.
Message-ID: <20220217201534.GA29303@wind.enjellic.com>
Reply-To: "Dr. Greg" <greg@enjellic.com>
References: <20220214060011.GA24404@wind.enjellic.com> <198ef291-4dee-ddac-aef6-8451bc1e880c@suse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Description: tgrregfiierifhrlngrgdjl
Content-Disposition: inline
In-Reply-To: <198ef291-4dee-ddac-aef6-8451bc1e880c@suse.com>
User-Agent: Mutt/1.4i
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.2.3 (wind.enjellic.com [127.0.0.1]); Thu, 17 Feb 2022 14:15:34 -0600 (CST)

On Mon, Feb 14, 2022 at 09:56:34AM +0100, Jan Beulich wrote:

Good morning, I hope the day is starting well for everyone, Jan thanks
for taking the time to reply.

> On 14.02.2022 07:00, Dr. Greg wrote:

> > It appears to be a problem with mapping interrupts back to dom0 given
> > that we see the following:
> > 
> > Feb 10 08:16:05 hostname kernel: xhci_hcd 0000:00:14.0: xen map irq failed -19 for 32752 domain
> > 
> > Feb 10 08:16:05 hostname kernel: i915 0000:00:02.0: xen map irq failed -19 for 32752 domain
> > 
> > Feb 10 08:16:12 hostname kernel: xhci_hcd 0000:00:14.0: Error while assigning device slot ID

> Just on this one aspect: It depends a lot what precisely you've used
> as 4.10 before. Was this the plain 4.10.4 release, or did you track
> the stable branch, accumulating security fixes?

It was based on the Xen GIT tree with a small number of modifications
that had been implemented by Intel to support their IGD
virtualization.

We did not end up using 'IGD virtualization', for a number of
technical reasons, instead we reverted back to using straight device
passthrough with qemu-traditional that we had previously been using.

If it would up being useful, we could come up with a diff between the
stock 4.10.4 tag and the codebase we used.

One of the purposes of the infrastructure upgrade was to try and get
on a completely mainline Xen source tree.

> would suspect device quarantining to get getting in your way. In
> which case it would be relevant to know what exactly "re-attach to
> the Dom0" means in your case.

Re-attach to Dom0 means to unbind the device from the pciback driver
and then bind the device to its original driver.  In the logs noted
above, the xhci_hcd driver to the USB controller and the i915 driver
to the IGD hardware.

It is the same strategy, same script actually, that we have been using
for 8+ years.

In the case of the logs above, the following command sequence is being
executed upon termination of the domain:

# Unbind devices.
echo 0000:00:14.0 >| /sys/bus/pci/drivers/pciback/unbind
echo 0000:00:02.0 >| /sys/bus/pci/drivers/pciback/unbind

# Rebind devices.
echo 0000:00:14.0 >| /sys/bus/pci/drivers/xhci_hcd/bind
echo 0000:00:02.0 >| /sys/bus/pci/drivers/i915/bind

Starting with the stock 4.11.4 release, the Dom0 re-attachment fails
with the 'xen_map_irq' failures being logged.

> Which brings me to this more general remark: What you describe sounds
> like a number of possibly independent problems. I'm afraid it'll be
> difficult for anyone to help without you drilling further down into
> what lower level operations are actually causing trouble. It also feels
> as if things may have ended up working for you on 4.10 just by
> chance.

I think the issue comes down to something that the hypervisor does, on
behalf of the domain doing the passthrough, as part of whatever
qemu-traditional needs to do in order to facilitate the attachment of
the PCI devices to the domain.

Running the detach/re-attach operation works perfectly in absence of
qemu-traditional being started in the domain.  The failure to
re-attach only occurs after qemu-traditional has been run in the
domain.

> I'm sorry that I'm not really of any help here,

Actually your reflections have been helpful.

Perhaps the most important clarification that we could get, for posterity
in this thread, is whether or not IGD pass-through is actually
supported in the mind of the Xen team.

According to the Xen web-site, IGD PCI pass-through is documented as
working with the following combinations:

Xen 4.11.x: QEMU >= 3.1

Xen 4.14.x: QEMU >= 5.2

We are currently having IGD pass-through with qemu-dm (3.1/5.2) fail
completely in those combinations.

Pass through with qemu-traditional works with 4.11.x but the
re-attachment fails.  On 4.14.x, execution of qemu-traditional is
failing secondary to some type of complaint about the inability to
determine the CPU type, which is some other issue that we haven't been
able to run down yet.

Those tests were done with builds from stock tagged releases in the
Xen GIT tree.

So it may be helpful to verify whether or not any of this is expected
to work, and if not, the Xen web-site would seem to need correction.

> Jan

Hopefully the following is helpful, I will be replying to Roger's
comments later.

Have a good day.

Dr. Greg

As always,
Dr. G.W. Wettstein, Ph.D.   Enjellic Systems Development, LLC.
4206 N. 19th Ave.           Specializing in information infra-structure
Fargo, ND  58102            development.
PH: 701-281-1686            EMAIL: greg@enjellic.com
------------------------------------------------------------------------------
"If your doing something the same way you have been doing it for ten years,
 the chances are you are doing it wrong."
                                -- Charles Kettering


From xen-devel-bounces@lists.xenproject.org Thu Feb 17 20:39:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 17 Feb 2022 20:39:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275018.470719 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKnYL-0001Eo-Dl; Thu, 17 Feb 2022 20:39:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275018.470719; Thu, 17 Feb 2022 20:39:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKnYL-0001Eh-Am; Thu, 17 Feb 2022 20:39:01 +0000
Received: by outflank-mailman (input) for mailman id 275018;
 Thu, 17 Feb 2022 20:39:00 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nKnYK-0001EX-KD; Thu, 17 Feb 2022 20:39:00 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nKnYK-0005mV-Gw; Thu, 17 Feb 2022 20:39:00 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nKnYK-0006ei-04; Thu, 17 Feb 2022 20:39:00 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nKnYJ-0007Te-Vs; Thu, 17 Feb 2022 20:38:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=g11hHp7xQa2lY/MBX9rQUh+6fwotqCIZKyhov4/qTp4=; b=XfW/uUUNcw8XLfqiTjphyHPXKT
	Bpnio1B37P8uMkssuxEjny9ZJzLoYrmOVs3hN7fx7aL1zB9VQPZww3yJRtaatb8y37NRaRBiNk0Ip
	zHchwKWlUVP80r9VCVSnDCfpbDrIxsXIBUZpuDuSzYJgaHReDvqffAwpLzMWHuXFQjDw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168154-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 168154: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=f71077a4d84bbe8c7b91b7db7c4ef815755ac5e3
X-Osstest-Versions-That:
    linux=3593030761630e09200072a4bd06468892c27be3
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 17 Feb 2022 20:38:59 +0000

flight 168154 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168154/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10       fail  like 168144
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168144
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168144
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168144
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168144
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168144
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168144
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168144
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168144
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                f71077a4d84bbe8c7b91b7db7c4ef815755ac5e3
baseline version:
 linux                3593030761630e09200072a4bd06468892c27be3

Last test of basis   168144  2022-02-16 19:41:31 Z    1 days
Testing same since   168154  2022-02-17 14:06:00 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Christian Loehle <cloehle@hyperstone.com>
  Christian Löhle <CLoehle@hyperstone.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Ulf Hansson <ulf.hansson@linaro.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   359303076163..f71077a4d84b  f71077a4d84bbe8c7b91b7db7c4ef815755ac5e3 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Thu Feb 17 21:38:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 17 Feb 2022 21:38:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275030.470733 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKoTn-0007G4-C4; Thu, 17 Feb 2022 21:38:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275030.470733; Thu, 17 Feb 2022 21:38:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKoTn-0007Fx-8I; Thu, 17 Feb 2022 21:38:23 +0000
Received: by outflank-mailman (input) for mailman id 275030;
 Thu, 17 Feb 2022 21:38:21 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=8ZiC=TA=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nKoTl-0007Fr-Ef
 for xen-devel@lists.xenproject.org; Thu, 17 Feb 2022 21:38:21 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ec287345-9039-11ec-8723-dd0c611c5f35;
 Thu, 17 Feb 2022 22:38:19 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 4C405B82520;
 Thu, 17 Feb 2022 21:38:18 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id F4004C340E8;
 Thu, 17 Feb 2022 21:38:15 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ec287345-9039-11ec-8723-dd0c611c5f35
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1645133896;
	bh=gzx34/A/fr8rA7hgyWnns3l7OCcHWPPWGqK28A/tBfQ=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=DWhMRWvZjct+idcqymzJaF2vsB69wcbtJHWbek5jw5U4l3s5Bmg+wxT/PwSwyNnnD
	 OFP/r8R56Zn8gmdgw/MTGL3xs+miJf13BXgM/+SEigd2NdtjNMV6Br95FywF+Q4tYZ
	 gqPWFO4RTt53ZKCowHWoMg5UM0G+vVvbsBTzd5fZNb+XT7WYxx8AKFmhORrzMRbsh1
	 mgnZ3Y4q2vgYrRk/NvQWoi5tvzCArt2nuhPKrKVF+folmn3ytVxdeh6WQDeoLkMbWB
	 gSW3asdR5APZqyRa2D4hAhG2vLv2w+m2QVMBhpuWY7u2IPo8AJfrBjpBwKyhV8P4vO
	 J7G47sxiqeAGg==
Date: Thu, 17 Feb 2022 13:38:07 -0800 (PST)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Vincent Guittot <vincent.guittot@linaro.org>
cc: Stefano Stabellini <stefano.stabellini@xilinx.com>, 
    =?UTF-8?Q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>, 
    stratos-dev@op-lists.linaro.org, xen-devel@lists.xenproject.org, 
    AKASHI Takahiro <takahiro.akashi@linaro.org>, 
    Arnd Bergmann <arnd.bergmann@linaro.org>, 
    Christopher Clark <christopher.w.clark@gmail.com>, 
    Dmytro Firsov <dmytro_firsov@epam.com>, Julien Grall <julien@xen.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Oleksandr_Tyshchenko@epam.com, Artem_Mygaiev@epam.com, 
    bertrand.marquis@arm.com, Wei.Chen@arm.com, Ed.Doxat@arm.com, 
    Oleksii_Moisieiev@epam.com
Subject: Re: Metadata and signalling channels for Zephyr virtio-backends on
 Xen
In-Reply-To: <CAKfTPtCtwnHXS143LQM-HDuZv8BOHSMDrQjh1cJqiBUci--smA@mail.gmail.com>
Message-ID: <alpine.DEB.2.22.394.2202171330580.239973@ubuntu-linux-20-04-desktop>
References: <87h79bgd1m.fsf@linaro.org> <alpine.DEB.2.22.394.2202071419270.2091381@ubuntu-linux-20-04-desktop> <CAKfTPtB1ONsxA1Rch8AO+UrPRZsHrCgF1_-F-kh9U_Xu2M47aA@mail.gmail.com> <alpine.DEB.2.22.394.2202161256350.43738@ubuntu-linux-20-04-desktop>
 <CAKfTPtCtwnHXS143LQM-HDuZv8BOHSMDrQjh1cJqiBUci--smA@mail.gmail.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-353924123-1645133896=:239973"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-353924123-1645133896=:239973
Content-Type: text/plain; charset=US-ASCII

Hi Vincent,

I am replying to this thread to follow-up on this morning's discussion.

I am attaching the simple patch that I mentioned during the call to add
event channels support to guest kernels, see xen.h.

I am also attaching a toy example application that makes use of it, just
to give you an idea.

Cheers,

Stefano
--8323329-353924123-1645133896=:239973
Content-Type: text/x-chdr; name=xen.h
Content-Transfer-Encoding: BASE64
Content-ID: <alpine.DEB.2.22.394.2202171338070.239973@ubuntu-linux-20-04-desktop>
Content-Description: 
Content-Disposition: attachment; filename=xen.h

LyogU1BEWC1MaWNlbnNlLUlkZW50aWZpZXI6IChCU0QtMy1DbGF1c2UpICov
DQovKg0KICogWGVuIGRlZmluaXRpb25zLCBoeXBlcmNhbGxzLCBhbmQgZnVu
Y3Rpb25zIHVzZWQgdG8gc2V0dXAgZXZlbnQNCiAqIGNoYW5uZWxzIGFuZCBz
ZW5kIGFuZCByZWNlaXZlIGV2ZW50IG5vdGlmaWNhdGlvbnMuDQogKi8NCg0K
I2lmbmRlZiBYRU5fSA0KI2RlZmluZSBYRU5fSA0KDQojZGVmaW5lIEdVRVNU
X0VWVENITl9QUEkgICAgICAgIDMxDQojZGVmaW5lIERPTUlEX1NFTEYgICAg
ICAgICAgICAgIDB4N0ZGMFUNCg0Kc3RydWN0IHZjcHVfdGltZV9pbmZvIHsN
CiAgICB1aW50MzJfdCB2ZXJzaW9uOw0KICAgIHVpbnQzMl90IHBhZDA7DQog
ICAgdWludDY0X3QgdHNjX3RpbWVzdGFtcDsNCiAgICB1aW50NjRfdCBzeXN0
ZW1fdGltZTsNCiAgICB1aW50MzJfdCB0c2NfdG9fc3lzdGVtX211bDsNCiAg
ICBpbnQ4X3QgICB0c2Nfc2hpZnQ7DQogICAgdWludDhfdCAgZmxhZ3M7DQog
ICAgdWludDhfdCAgcGFkMVsyXTsNCn0gX19hdHRyaWJ1dGVfXygoX19wYWNr
ZWRfXykpOyAvKiAzMiBieXRlcyAqLw0KDQpzdHJ1Y3QgcHZjbG9ja193YWxs
X2Nsb2NrIHsNCiAgICB1aW50MzJfdCB2ZXJzaW9uOw0KICAgIHVpbnQzMl90
IHNlYzsNCiAgICB1aW50MzJfdCBuc2VjOw0KICAgIHVpbnQzMl90IHNlY19o
aTsNCn0gX19hdHRyaWJ1dGVfXygoX19wYWNrZWRfXykpOw0KDQpzdHJ1Y3Qg
YXJjaF92Y3B1X2luZm8geyB9Ow0Kc3RydWN0IGFyY2hfc2hhcmVkX2luZm8g
eyB9Ow0KDQpzdHJ1Y3QgdmNwdV9pbmZvIHsNCiAgICB1aW50OF90IGV2dGNo
bl91cGNhbGxfcGVuZGluZzsNCiAgICB1aW50OF90IGV2dGNobl91cGNhbGxf
bWFzazsNCiAgICB1aW50NjRfdCBldnRjaG5fcGVuZGluZ19zZWw7DQogICAg
c3RydWN0IGFyY2hfdmNwdV9pbmZvIGFyY2g7DQogICAgc3RydWN0IHZjcHVf
dGltZV9pbmZvIHRpbWU7DQp9Ow0KDQpzdHJ1Y3Qgc2hhcmVkX2luZm8gew0K
ICAgIHN0cnVjdCB2Y3B1X2luZm8gdmNwdV9pbmZvWzFdOw0KICAgIHVpbnQ2
NF90IGV2dGNobl9wZW5kaW5nW3NpemVvZih1aW50NjRfdCkgKiA4XTsNCiAg
ICB1aW50NjRfdCBldnRjaG5fbWFza1tzaXplb2YodWludDY0X3QpICogOF07
DQoNCiAgICBzdHJ1Y3QgcHZjbG9ja193YWxsX2Nsb2NrIHdjOw0KICAgIHVp
bnQzMl90IHdjX3NlY19oaTsNCiAgICBzdHJ1Y3QgYXJjaF9zaGFyZWRfaW5m
byBhcmNoOw0KfTsNCg0KI2RlZmluZSBhY3RpdmVfZXZ0Y2hucyhjcHUsc2gs
aWR4KSAgICAgICAgICAgICAgXA0KICAgICgoc2gpLT5ldnRjaG5fcGVuZGlu
Z1tpZHhdICYgICAgICAgICAgICAgICAgXA0KICAgICB+KHNoKS0+ZXZ0Y2hu
X21hc2tbaWR4XSkNCg0KI2RlZmluZSBIWVBFUlZJU09SX21lbW9yeV9vcCAg
ICAgICAgICAgIDEyDQojZGVmaW5lIEhZUEVSVklTT1JfeGVuX3ZlcnNpb24g
ICAgICAgICAgMTcNCiNkZWZpbmUgSFlQRVJWSVNPUl9jb25zb2xlX2lvICAg
ICAgICAgICAxOA0KI2RlZmluZSBIWVBFUlZJU09SX2dyYW50X3RhYmxlX29w
ICAgICAgIDIwDQojZGVmaW5lIEhZUEVSVklTT1JfdmNwdV9vcCAgICAgICAg
ICAgICAgMjQNCiNkZWZpbmUgSFlQRVJWSVNPUl94c21fb3AgICAgICAgICAg
ICAgICAyNw0KI2RlZmluZSBIWVBFUlZJU09SX3NjaGVkX29wICAgICAgICAg
ICAgIDI5DQojZGVmaW5lIEhZUEVSVklTT1JfY2FsbGJhY2tfb3AgICAgICAg
ICAgMzANCiNkZWZpbmUgSFlQRVJWSVNPUl9ldmVudF9jaGFubmVsX29wICAg
ICAzMg0KI2RlZmluZSBIWVBFUlZJU09SX3BoeXNkZXZfb3AgICAgICAgICAg
IDMzDQojZGVmaW5lIEhZUEVSVklTT1JfaHZtX29wICAgICAgICAgICAgICAg
MzQNCiNkZWZpbmUgSFlQRVJWSVNPUl9zeXNjdGwgICAgICAgICAgICAgICAz
NQ0KI2RlZmluZSBIWVBFUlZJU09SX2RvbWN0bCAgICAgICAgICAgICAgIDM2
DQojZGVmaW5lIEhZUEVSVklTT1JfYXJnb19vcCAgICAgICAgICAgICAgMzkN
CiNkZWZpbmUgSFlQRVJWSVNPUl9kbV9vcCAgICAgICAgICAgICAgICA0MQ0K
I2RlZmluZSBIWVBFUlZJU09SX2h5cGZzX29wICAgICAgICAgICAgIDQyDQoN
Cg0KLyogaHlwZXJjYWxscyAqLw0Kc3RhdGljIGlubGluZSBpbnQ2NF90IHhl
bl9oeXBlcmNhbGwodW5zaWduZWQgbG9uZyBhcmcwLCB1bnNpZ25lZCBsb25n
IGFyZzEsDQogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1
bnNpZ25lZCBsb25nIGFyZzIsIHVuc2lnbmVkIGxvbmcgYXJnMywNCiAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGxvbmcg
aHlwZXJjYWxsKQ0Kew0KICAgIHJlZ2lzdGVyIHVpbnRwdHJfdCBhMCBhc20o
IngwIikgPSBhcmcwOw0KICAgIHJlZ2lzdGVyIHVpbnRwdHJfdCBhMSBhc20o
IngxIikgPSBhcmcxOw0KICAgIHJlZ2lzdGVyIHVpbnRwdHJfdCBhMiBhc20o
IngyIikgPSBhcmcyOw0KICAgIHJlZ2lzdGVyIHVpbnRwdHJfdCBhMyBhc20o
IngzIikgPSBhcmczOw0KICAgIHJlZ2lzdGVyIHVpbnRwdHJfdCBuciBhc20o
IngxNiIpID0gaHlwZXJjYWxsOw0KICAgIGFzbSB2b2xhdGlsZSgiaHZjIDB4
ZWExXG4iDQogICAgICAgICAgICAgICAgICAgICA6ICI9ciIgKGEwKSwgIj1y
IihhMSksICI9ciIgKGEyKSwgIj1yIiAoYTMpLCAiPXIiIChucikNCiAgICAg
ICAgICAgICAgICAgICAgIDogIjAiIChhMCksDQogICAgICAgICAgICAgICAg
ICAgICAgICJyIiAoYTEpLA0KICAgICAgICAgICAgICAgICAgICAgICAiciIg
KGEyKSwNCiAgICAgICAgICAgICAgICAgICAgICAgInIiIChhMyksDQogICAg
ICAgICAgICAgICAgICAgICAgICJyIiAobnIpKTsNCiAgICByZXR1cm4gYTA7
DQp9DQoNCg0KLyogY29uc29sZV9pbyAqLw0KI2RlZmluZSBDT05TT0xFSU9f
d3JpdGUgMA0KDQoNCi8qIG1lbW9yeV9vcCAqLw0KI2RlZmluZSBYRU5NQVBT
UEFDRV9zaGFyZWRfaW5mbyAgMCAvKiBzaGFyZWQgaW5mbyBwYWdlICovDQoj
ZGVmaW5lIFhFTk1BUFNQQUNFX2dyYW50X3RhYmxlICAxIC8qIGdyYW50IHRh
YmxlIHBhZ2UgKi8NCg0KI2RlZmluZSBYRU5NRU1fYWRkX3RvX3BoeXNtYXAg
ICAgICA3DQoNCnN0cnVjdCB4ZW5fYWRkX3RvX3BoeXNtYXAgew0KICAgIC8q
IFdoaWNoIGRvbWFpbiB0byBjaGFuZ2UgdGhlIG1hcHBpbmcgZm9yLiAqLw0K
ICAgIHVpbnQxNl90IGRvbWlkOw0KDQogICAgLyogTnVtYmVyIG9mIHBhZ2Vz
IHRvIGdvIHRocm91Z2ggZm9yIGdtZm5fcmFuZ2UgKi8NCiAgICB1aW50MTZf
dCAgICBzaXplOw0KDQogICAgLyogU291cmNlIG1hcHBpbmcgc3BhY2UuICov
DQogICAgdW5zaWduZWQgaW50IHNwYWNlOw0KDQogICAgLyogSW5kZXggaW50
byBzb3VyY2UgbWFwcGluZyBzcGFjZS4gKi8NCiAgICB1aW50NjRfdCBpZHg7
DQoNCiAgICAvKiBHUEZOIHdoZXJlIHRoZSBzb3VyY2UgbWFwcGluZyBwYWdl
IHNob3VsZCBhcHBlYXIuICovDQogICAgdWludDY0X3QgZ3BmbjsNCn07DQoN
CnN0YXRpYyBpbmxpbmUgaW50IHhlbl9yZWdpc3Rlcl9zaGFyZWRfaW5mbyhz
dHJ1Y3Qgc2hhcmVkX2luZm8gKnNoYXJlZF9pbmZvKQ0Kew0KICAgIGludCBy
YzsNCiAgICBzdHJ1Y3QgeGVuX2FkZF90b19waHlzbWFwIHhhdHA7DQoNCiAg
ICB4YXRwLmRvbWlkID0gRE9NSURfU0VMRjsNCiAgICB4YXRwLmlkeCA9IDA7
DQogICAgeGF0cC5zcGFjZSA9IFhFTk1BUFNQQUNFX3NoYXJlZF9pbmZvOw0K
ICAgIHhhdHAuZ3BmbiA9ICgodW5zaWduZWQgbG9uZylzaGFyZWRfaW5mbykg
Pj4gMTI7DQogICAgcmMgPSB4ZW5faHlwZXJjYWxsKFhFTk1FTV9hZGRfdG9f
cGh5c21hcCwgKHVuc2lnbmVkIGxvbmcpJnhhdHAsIDAsIDAsDQogICAgICAg
ICAgICAgICAgICAgICAgIEhZUEVSVklTT1JfbWVtb3J5X29wKTsNCiAgICBy
ZXR1cm4gcmM7DQp9DQoNCg0KLyogZXZlbnRfY2hhbm5lbF9vcCAqLw0KI2Rl
ZmluZSBFVlRDSE5PUF9iaW5kX2ludGVyZG9tYWluIDANCiNkZWZpbmUgRVZU
Q0hOT1BfY2xvc2UgICAgICAgICAgICAzDQojZGVmaW5lIEVWVENITk9QX3Nl
bmQgICAgICAgICAgICAgNA0KI2RlZmluZSBFVlRDSE5PUF9zdGF0dXMgICAg
ICAgICAgIDUNCiNkZWZpbmUgRVZUQ0hOT1BfYWxsb2NfdW5ib3VuZCAgICA2
DQojZGVmaW5lIEVWVENITk9QX3VubWFzayAgICAgICAgICAgOQ0KDQpzdHJ1
Y3QgZXZ0Y2huX2JpbmRfaW50ZXJkb21haW4gew0KICAgIC8qIElOIHBhcmFt
ZXRlcnMuICovDQogICAgdWludDE2X3QgcmVtb3RlX2RvbTsNCiAgICB1aW50
MzJfdCByZW1vdGVfcG9ydDsNCiAgICAvKiBPVVQgcGFyYW1ldGVycy4gKi8N
CiAgICB1aW50MzJfdCBsb2NhbF9wb3J0Ow0KfTsNCg0Kc3RydWN0IGV2dGNo
bl9hbGxvY191bmJvdW5kIHsNCiAgICAvKiBJTiBwYXJhbWV0ZXJzICovDQog
ICAgdWludDE2X3QgZG9tLCByZW1vdGVfZG9tOw0KICAgIC8qIE9VVCBwYXJh
bWV0ZXJzICovDQogICAgdWludDMyX3QgcG9ydDsNCn07DQoNCnN0cnVjdCBl
dnRjaG5fc2VuZCB7DQogICAgLyogSU4gcGFyYW1ldGVycy4gKi8NCiAgICB1
aW50MzJfdCBwb3J0Ow0KfTsNCg0KDQovKiBwcmludGYgKi8NCnN0YXRpYyBp
bmxpbmUgdm9pZCB4ZW5fY29uc29sZV93cml0ZShjb25zdCBjaGFyICpzdHIp
DQp7DQogICAgc3NpemVfdCBsZW4gPSBzdHJsZW4oc3RyKTsNCg0KICAgIHhl
bl9oeXBlcmNhbGwoQ09OU09MRUlPX3dyaXRlLCBsZW4sICh1bnNpZ25lZCBs
b25nKXN0ciwgMCwNCiAgICAgICAgICAgICAgICAgIEhZUEVSVklTT1JfY29u
c29sZV9pbyk7DQp9DQoNCnN0YXRpYyBpbmxpbmUgdm9pZCB4ZW5fcHJpbnRm
KGNvbnN0IGNoYXIgKmZtdCwgLi4uKQ0Kew0KICAgIGNoYXIgYnVmWzEyOF07
DQogICAgdmFfbGlzdCBhcDsNCiAgICBjaGFyICpzdHIgPSAmYnVmWzBdOw0K
ICAgIG1lbXNldChidWYsIDB4MCwgMTI4KTsNCg0KICAgIHZhX3N0YXJ0KGFw
LCBmbXQpOw0KICAgIHZzcHJpbnRmKHN0ciwgZm10LCBhcCk7DQogICAgdmFf
ZW5kKGFwKTsNCg0KICAgIHhlbl9jb25zb2xlX3dyaXRlKGJ1Zik7DQp9DQoN
Cg0KLyogDQogKiB1dGlsaXR5IGZ1bmN0aW9ucywgbm90IHhlbiBzcGVjaWZp
YywgYnV0IG5lZWRlZCBieSB0aGUgZnVuY3Rpb24NCiAqIGJlbG93DQogKi8N
CiNkZWZpbmUgeGNoZyhwdHIsdikgX19hdG9taWNfZXhjaGFuZ2VfbihwdHIs
IHYsIF9fQVRPTUlDX1NFUV9DU1QpDQoNCnN0YXRpYyBfX2lubGluZV9fIHVu
c2lnbmVkIGxvbmcgX19mZnModW5zaWduZWQgbG9uZyB3b3JkKQ0Kew0KICAg
ICAgICByZXR1cm4gX19idWlsdGluX2N0emwod29yZCk7DQp9DQoNCg0KLyog
ZXZlbnQgaGFuZGxpbmcgKi8NCnN0YXRpYyBpbmxpbmUgdm9pZCBoYW5kbGVf
ZXZlbnRfaXJxKHN0cnVjdCBzaGFyZWRfaW5mbyAqcywNCiAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgIHZvaWQgKCpkb19ldmVudCkodW5z
aWduZWQgaW50IGV2ZW50KSkNCnsNCiAgICB1aW50NjRfdCAgbDEsIGwyLCBs
MWksIGwyaTsNCiAgICB1bnNpZ25lZCBpbnQgICBwb3J0Ow0KICAgIGludCAg
ICAgICAgICAgIGNwdSA9IDA7DQogICAgc3RydWN0IHZjcHVfaW5mbyAgICp2
Y3B1X2luZm8gPSAmcy0+dmNwdV9pbmZvW2NwdV07DQoNCiAgICB2Y3B1X2lu
Zm8tPmV2dGNobl91cGNhbGxfcGVuZGluZyA9IDA7DQogICAgbWIoKTsNCg0K
ICAgIGwxID0geGNoZygmdmNwdV9pbmZvLT5ldnRjaG5fcGVuZGluZ19zZWws
IDApOw0KICAgIHdoaWxlICggbDEgIT0gMCApDQogICAgew0KICAgICAgICBs
MWkgPSBfX2ZmcyhsMSk7DQogICAgICAgIGwxICY9IH4oMVVMIDw8IGwxaSk7
DQogICAgICAgIGwyID0geGNoZygmcy0+ZXZ0Y2huX3BlbmRpbmdbbDFpXSwg
MCk7DQoNCiAgICAgICAgd2hpbGUgKCBsMiAhPSAwICkNCiAgICAgICAgew0K
ICAgICAgICAgICAgbDJpID0gX19mZnMobDIpOw0KICAgICAgICAgICAgbDIg
Jj0gfigxVUwgPDwgbDJpKTsNCg0KICAgICAgICAgICAgcG9ydCA9IChsMWkg
KiBzaXplb2YodWludDY0X3QpKSArIGwyaTsNCg0KICAgICAgICAgICAgZG9f
ZXZlbnQocG9ydCk7DQogICAgICAgIH0NCiAgICB9DQp9DQoNCiNlbmRpZiAv
KiBYRU5fSCAqLw0K

--8323329-353924123-1645133896=:239973
Content-Type: text/x-csrc; name=example.c
Content-Transfer-Encoding: BASE64
Content-ID: <alpine.DEB.2.22.394.2202171338071.239973@ubuntu-linux-20-04-desktop>
Content-Description: 
Content-Disposition: attachment; filename=example.c

LyogU1BEWC1MaWNlbnNlLUlkZW50aWZpZXI6IChCU0QtMy1DbGF1c2UpICov
DQovKg0KICogVEJNIGFwcGxpY2F0aW9uIHRvIHNlbmQgYW5kIHJlY2VpdmUg
WGVuIGV2ZW50IGNoYW5uZWxzLg0KICoNCiAqIFdyaXR0ZW4gYnkgU3RlZmFu
byBTdGFiZWxsaW5pDQogKi8NCiNkZWZpbmUgX01JTklDX1NPVVJDRQ0KDQoj
aW5jbHVkZSA8c3RkaW8uaD4NCiNpbmNsdWRlIDxzdGRib29sLmg+DQojaW5j
bHVkZSA8c3RkaW50Lmg+DQojaW5jbHVkZSA8c3RyaW5nLmg+DQojaW5jbHVk
ZSA8dW5pc3RkLmg+DQojaW5jbHVkZSAic3lzLmgiDQoNCiNpbmNsdWRlICJk
cml2ZXJzL2FybS9naWMuaCINCg0KI2luY2x1ZGUgInhlbi5oIg0KDQpzdGF0
aWMgdWludDE2X3QgZG9taWQgPSAwOw0Kc3RhdGljIHN0cnVjdCBzaGFyZWRf
aW5mbyAqc2hhcmVkX2luZm8gPSAwOw0KLyogc3RhdGljYWxseSBjb25maWd1
cmVkIHNoYXJlZCBtZW1vcnkgYXQgYWRkcmVzcyAweDdmZTAwMDAwICovDQpz
dGF0aWMgY2hhciogc2hhcmVkX21lbSA9IChjaGFyICopMHg3ZmUwMDAwMDsN
Cg0Kc3RhdGljIHZvaWQgcHJpbnRfZXZlbnQodW5zaWduZWQgaW50IGV2ZW50
KQ0Kew0KICAgIHhlbl9wcmludGYoImhhbmRsZV9ldmVudCBkb21pZD0ldSBl
dmVudD0ldVxuIiwgZG9taWQsIGV2ZW50KTsNCn0NCg0Kc3RhdGljIHZvaWQg
aXJxX2hhbmRsZXIoc3RydWN0IGV4Y3BfZnJhbWUgKmYpDQp7DQogICAgdWlu
dDMyX3QgaXJxOw0KDQogICAgaXJxID0gZ2ljX2Fja19pcnEoR0lDX0NQVV9C
QVNFKTsNCg0KICAgIGhhbmRsZV9ldmVudF9pcnEoc2hhcmVkX2luZm8sIHBy
aW50X2V2ZW50KTsNCg0KICAgIGdpY19lbmRfb2ZfaXJxKEdJQ19DUFVfQkFT
RSwgaXJxKTsNCiAgICBnaWNfZGVhY3RpdmF0ZV9pcnEoR0lDX0NQVV9CQVNF
LCBpcnEpOw0KICAgIGxvY2FsX2NwdV9laSgpOw0KfQ0KDQpzdGF0aWMgdm9p
ZCBnaWNfaW5pdChpbnQgaXJxKQ0Kew0KICAgIGFzc2VydChpcnEgPCAzMik7
DQoNCiAgICAvKiBEaXNhYmxlIGludGVycnVwdHMgd2hpbGUgd2UgY29uZmln
dXJlIHRoZSBHSUMuICAqLw0KICAgIGxvY2FsX2NwdV9kaSgpOw0KDQogICAg
LyogU2V0dXAgdGhlIEdJQy4gICovDQogICAgZ2ljZF9zZXRfaXJxX2dyb3Vw
KEdJQ19ESVNUX0JBU0UsIGlycSwgMCk7DQogICAgZ2ljZF9zZXRfaXJxX3Rh
cmdldChHSUNfRElTVF9CQVNFLCBpcnEsIDApOw0KICAgIGdpY2RfZW5hYmxl
X2lycShHSUNfRElTVF9CQVNFLCBpcnEpOw0KICAgIGdpY2Rfc2V0X2lycV9n
cm91cChHSUNfRElTVF9CQVNFLCA1LCAwKTsNCiAgICBnaWNkX3NldF9pcnFf
dGFyZ2V0KEdJQ19ESVNUX0JBU0UsIDUsIDApOw0KICAgIGdpY2RfZW5hYmxl
X2lycShHSUNfRElTVF9CQVNFLCA1KTsNCg0KICAgIHdyaXRlbChHSUNfRElT
VF9CQVNFICsgR0lDRF9DVFJMLCAzKTsNCiAgICB3cml0ZWwoR0lDX0NQVV9C
QVNFICsgR0lDQ19DVFJMLCAzKTsNCiAgICB3cml0ZWwoR0lDX0NQVV9CQVNF
ICsgR0lDQ19QTVIsIDB4ZmYpOw0KICAgIG1iKCk7DQogICAgbG9jYWxfY3B1
X2VpKCk7DQp9DQoNCnZvaWQgZGVidWdfZ2V0X2RvbWlkKCkNCnsNCiAgICBy
ZWdpc3RlciB1aW50cHRyX3QgYTAgYXNtKCJ4MCIpOw0KICAgIF9fYXNtX18g
X192b2xhdGlsZV9fKCJodmMgMHhmZmZkXG4iIA0KICAgICAgICAgICAgOiAi
PXIiIChhMCkNCiAgICAgICAgICAgIDogIjAiIChhMCkpOw0KICAgIGRvbWlk
ID0gYTA7DQp9DQoNCnZvaWQgYXBwX3J1bih2b2lkKQ0Kew0KICAgIGludCBy
ZXQgPSAwOw0KDQogICAgLyogU2V0dXAgR0lDIGFuZCBpbnRlcnJ1cHQgaGFu
ZGxlciBmb3IgWGVuIGV2ZW50cyAqLw0KICAgIGdpY19pbml0KEdVRVNUX0VW
VENITl9QUEkpOw0KICAgIGFhcmNoNjRfc2V0X2lycV9oKGlycV9oYW5kbGVy
KTsNCg0KICAgIC8qIFJlZ2lzdGVyIHNoYXJlZF9pbmZvIHBhZ2UgKi8NCiAg
ICBzaGFyZWRfaW5mbyA9IGFsaWduZWRfYWxsb2MoNDA5NiwgNDA5Nik7DQog
ICAgbWVtc2V0KHNoYXJlZF9pbmZvLCAweDAsIDQwOTYpOw0KICAgIHhlbl9y
ZWdpc3Rlcl9zaGFyZWRfaW5mbyhzaGFyZWRfaW5mbyk7DQoNCiAgICAvKiBH
ZXQgb3VyIGRvbWlkIHdpdGggZGVidWcgaHlwZXJjYWxsICovDQogICAgZGVi
dWdfZ2V0X2RvbWlkKCk7DQogICAgeGVuX3ByaW50ZigiREVCVUcgZG9taWQ9
JWRcbiIsIGRvbWlkKTsNCg0KICAgIC8qIElmIGRvbWlkID09IDEgYWxsb2Nh
dGUgYW4gdW5ib3VuZCBldmVudCB0byByZWNlaXZlIG5vdGlmaWNhdGlvbnMg
Ki8NCiAgICBpZiAoZG9taWQgPT0gMSkgew0KICAgICAgICB1aW50MTZfdCBy
ZW1vdGVfZG9taWQgPSAyOw0KICAgICAgICBzdHJ1Y3QgZXZ0Y2huX2FsbG9j
X3VuYm91bmQgYWxsb2M7DQoNCiAgICAgICAgYWxsb2MuZG9tID0gRE9NSURf
U0VMRjsNCiAgICAgICAgYWxsb2MucmVtb3RlX2RvbSA9IHJlbW90ZV9kb21p
ZDsNCiAgICAgICAgYWxsb2MucG9ydCA9IDA7DQoNCiAgICAgICAgcmV0ID0g
eGVuX2h5cGVyY2FsbChFVlRDSE5PUF9hbGxvY191bmJvdW5kLCAodW5zaWdu
ZWQgbG9uZykmYWxsb2MsDQogICAgICAgICAgICAgICAgICAgICAgICAgICAg
MCwgMCwgSFlQRVJWSVNPUl9ldmVudF9jaGFubmVsX29wKTsNCiAgICAgICAg
bWIoKTsNCg0KICAgICAgICB4ZW5fcHJpbnRmKCJERUJVRyBkb21pZD0lZCBh
bGxvY191bmJvdW5kIHJldD0lZCBwb3J0PSV1XG4iLCBkb21pZCwgcmV0LCBh
bGxvYy5wb3J0KTsNCg0KICAgICAgICAvKiBmaXJzdCBtZXNzYWdlIHRvIHNp
Z25hbCByZWFkaW5lc3MgKi8NCiAgICAgICAgbWVtY3B5KHNoYXJlZF9tZW0s
ICJnbyIsIHNpemVvZigiZ28iKSk7DQogICAgICAgIG1iKCk7DQogICAgICAg
IC8qIHNlbmQgcG9ydCBudW1iZXIgdG8gb3RoZXIgZG9tYWluICovDQogICAg
ICAgIG1lbWNweShzaGFyZWRfbWVtICsgNCwgJmFsbG9jLnBvcnQsIHNpemVv
ZihhbGxvYy5wb3J0KSk7DQoNCiAgICAvKiBpZiBkb21pZCA9PSAyIGJpbmQg
dG8gZm9yZWlnbiBldmVudCBjaGFubmVsIGFuZCBzZW5kIGV2ZW50IG5vdGlm
aWNhdGlvbnMgKi8NCiAgICB9IGVsc2Ugew0KICAgICAgICB1aW50MTZfdCBy
ZW1vdGVfZG9taWQgPSAxOw0KICAgICAgICB1aW50MTZfdCByZW1vdGVfcG9y
dDsNCiAgICAgICAgc3RydWN0IGV2dGNobl9iaW5kX2ludGVyZG9tYWluIGJp
bmQ7DQogICAgICAgIHN0cnVjdCBldnRjaG5fc2VuZCBzZW5kOw0KDQogICAg
ICAgIC8qIHdhaXQgZm9yIHJlYWRpbmVzcyBzaWduYWwgKi8NCiAgICAgICAg
d2hpbGUgKDEpIHsNCiAgICAgICAgICAgIGlmIChzdHJjbXAoc2hhcmVkX21l
bSwgImdvIikgPT0gMCkNCiAgICAgICAgICAgICAgICBicmVhazsNCiAgICAg
ICAgICAgIG1iKCk7DQogICAgICAgIH0NCiAgICAgICAgbWIoKTsNCiAgICAg
ICAgLyogcmVhZCBwb3J0IG51bWJlciBvZiB0aGUgb3RoZXIgZG9tYWluICov
DQogICAgICAgIG1lbWNweSgmcmVtb3RlX3BvcnQsIHNoYXJlZF9tZW0gKyA0
LCBzaXplb2YocmVtb3RlX3BvcnQpKTsNCg0KICAgICAgICB4ZW5fcHJpbnRm
KCJERUJVRyBkb21pZD0lZCByZW1vdGVfcG9ydD0ldVxuIiwgZG9taWQsIHJl
bW90ZV9wb3J0KTsNCg0KICAgICAgICBiaW5kLnJlbW90ZV9kb20gPSByZW1v
dGVfZG9taWQ7DQogICAgICAgIGJpbmQucmVtb3RlX3BvcnQgPSByZW1vdGVf
cG9ydDsNCiAgICAgICAgYmluZC5sb2NhbF9wb3J0ID0gMDsNCiAgICAgICAg
cmV0ID0geGVuX2h5cGVyY2FsbChFVlRDSE5PUF9iaW5kX2ludGVyZG9tYWlu
LCAodW5zaWduZWQgbG9uZykmYmluZCwNCiAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAwLCAwLCBIWVBFUlZJU09SX2V2ZW50X2NoYW5uZWxfb3ApOw0K
DQogICAgICAgIHhlbl9wcmludGYoIkRFQlVHIGRvbWlkPSVkIGJpbmRfaW50
ZXJkb21haW4gcmV0PSVkIGxvY2FsX3BvcnQ9JXVcbiIsIGRvbWlkLCByZXQs
IGJpbmQubG9jYWxfcG9ydCk7DQoNCiAgICAgICAgc2VuZC5wb3J0ID0gYmlu
ZC5sb2NhbF9wb3J0Ow0KICAgICAgICB4ZW5faHlwZXJjYWxsKEVWVENITk9Q
X3NlbmQsICh1bnNpZ25lZCBsb25nKSZzZW5kLA0KICAgICAgICAgICAgICAg
ICAgICAgIDAsIDAsIEhZUEVSVklTT1JfZXZlbnRfY2hhbm5lbF9vcCk7DQog
ICAgfQ0KDQogICAgd2hpbGUgKDEpDQogICAgICAgIDsNCn0NCg==

--8323329-353924123-1645133896=:239973--


From xen-devel-bounces@lists.xenproject.org Thu Feb 17 23:49:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 17 Feb 2022 23:49:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275040.470744 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKqW7-0002cE-4U; Thu, 17 Feb 2022 23:48:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275040.470744; Thu, 17 Feb 2022 23:48:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKqW7-0002c7-1K; Thu, 17 Feb 2022 23:48:55 +0000
Received: by outflank-mailman (input) for mailman id 275040;
 Thu, 17 Feb 2022 23:48:53 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nKqW5-0002bw-QM; Thu, 17 Feb 2022 23:48:53 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nKqW5-0000f8-OW; Thu, 17 Feb 2022 23:48:53 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nKqW5-0005Tb-Aj; Thu, 17 Feb 2022 23:48:53 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nKqW5-000476-9y; Thu, 17 Feb 2022 23:48:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=oPzXfA0mGmbtCg99GdJYgqPYWkpDwbwR9I5H3LVtAFo=; b=dch86UhwbBCN8od1VWHa54pg14
	gqED/Fe39kJk/YVFusVu3dVqmu55l46yBvurCaa2E43mDrvjyWzkagWihVQrNANFoelJnUo2z0STk
	SEOvtrMwUb8GeuBkj1rWYcncqXySrkIRZIYSxQEKnBD1nwP3EJBmozZ/Nz5h10KEqry4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168155-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 168155: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=4ec51e87804bd9aad0d0b8e5dadb987b54c5adeb
X-Osstest-Versions-That:
    xen=e7c2017cf4a91ab6a0fea6adca2d9dd2ab1603b0
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 17 Feb 2022 23:48:53 +0000

flight 168155 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168155/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  4ec51e87804bd9aad0d0b8e5dadb987b54c5adeb
baseline version:
 xen                  e7c2017cf4a91ab6a0fea6adca2d9dd2ab1603b0

Last test of basis   168122  2022-02-15 21:01:44 Z    2 days
Testing same since   168155  2022-02-17 20:02:59 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Penny Zheng <penny.zheng@arm.com>
  Stefano Stabellini <sstabellini@kernel.org>
  Stefano Stabellini <stefano.stabellini@xilinx.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   e7c2017cf4..4ec51e8780  4ec51e87804bd9aad0d0b8e5dadb987b54c5adeb -> smoke


From xen-devel-bounces@lists.xenproject.org Fri Feb 18 03:13:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 18 Feb 2022 03:13:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275056.470758 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKthd-0007tY-BY; Fri, 18 Feb 2022 03:13:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275056.470758; Fri, 18 Feb 2022 03:13:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKthd-0007tQ-6m; Fri, 18 Feb 2022 03:13:01 +0000
Received: by outflank-mailman (input) for mailman id 275056;
 Fri, 18 Feb 2022 03:13:00 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nKthc-0007tG-9m; Fri, 18 Feb 2022 03:13:00 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nKthc-0006nw-5j; Fri, 18 Feb 2022 03:13:00 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nKthb-0005aW-KD; Fri, 18 Feb 2022 03:12:59 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nKthb-0005T0-Jm; Fri, 18 Feb 2022 03:12:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=p2knbKkJ6hiPCYxNpPLY+CP0f8HfOBRS9LEW/cZwBFw=; b=QDqNvWZQ/AqAw3K2gSalUFtc/V
	kfQMx6+tIxk2LBhLvj/veEQ1FEamMfY4Mo00eyJ9+WIsgOkODskE1qVb+hSklSvaTxT0w7JJfqM+P
	lfZ8ktNTgoF2BVsoQz16W/vyyBIeRuCn/NJRagykZqiZdxISER8Q5sr8ykYz2shK9G+c=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168156-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 168156: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=8b97cae315cafd7debf3601f88621e2aa8956ef3
X-Osstest-Versions-That:
    linux=f71077a4d84bbe8c7b91b7db7c4ef815755ac5e3
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 18 Feb 2022 03:12:59 +0000

flight 168156 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168156/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168154
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168154
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168154
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168154
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168154
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168154
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168154
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168154
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                8b97cae315cafd7debf3601f88621e2aa8956ef3
baseline version:
 linux                f71077a4d84bbe8c7b91b7db7c4ef815755ac5e3

Last test of basis   168154  2022-02-17 14:06:00 Z    0 days
Testing same since   168156  2022-02-17 21:09:38 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alex Maydanik <alexander.maydanik@gmail.com>
  Alexey Khoroshilov <khoroshilov@ispras.ru>
  Arnaldo Carvalho de Melo <acme@redhat.com>
  Arınç ÜNAL <arinc.unal@arinc9.com>
  Benjamin Beichler <benjamin.beichler@uni-rostock.de>
  Changbin Du <changbin.du@gmail.com>
  Congyu Liu <liu3101@purdue.edu>
  Danie du Toit <danie.dutoit@corigine.com>
  Daniele Palmas <dnlplm@gmail.com>
  David S. Miller <davem@davemloft.net>
  DENG Qingfang <dqfext@gmail.com>
  Dmitry Torokhov <dmitry.torokhov@gmail.com>
  Emmanuel Grumbach <emmanuel.grumbach@intel.com>
  Eric Dumazet <edumazet@google.com>
  Florian Fainelli <f.fainelli@gmail.com>
  Florian Westphal <fw@strlen.de>
  Gatis Peisenieks <gatis@mikrotik.com>
  German Gomez <german.gomez@arm.com>
  Gurucharan G <gurucharanx.g@intel.com> (A Contingent worker at Intel)
  Hangbin Liu <liuhangbin@gmail.com>
  Hangyu Hua <hbh25y@gmail.com>
  Hauke Mehrtens <hauke@hauke-m.de>
  Ignat Korchagin <ignat@cloudflare.com>
  JaeMan Park <jaeman@google.com>
  Jakub Kicinski <kuba@kernel.org>
  Jamal Hadi Salim <jhs@mojatatu.com>
  James Clark <james.clark@arm.com>
  Jay Vosburgh <jay.vosburgh@canonical.com>
  Jeremy Kerr <jk@codeconstruct.com.au>
  Jesse Brandeburg <jesse.brandeburg@intel.com>
  Jiasheng Jiang <jiasheng@iscas.ac.cn>
  Jiri Olsa <jolsa@kernel.org>
  Johannes Berg <johannes.berg@intel.com>
  Jon Maloy <jmaloy@redhat.com>
  Jonas Gorski <jonas.gorski@gmail.com>
  Josh Poimboeuf <jpoimboe@redhat.com>
  Justin M. Forbes <jforbes@fedoraproject.org>
  Kalle Valo <kvalo@kernel.org>
  Kees Cook <keescook@chromium.org>
  Kees Kook <keescook@chromium.org>
  Linus Torvalds <torvalds@linux-foundation.org>
  Loic Poulain <loic.poulain@linaro.org>
  Louis Peens <louis.peens@corigine.com>
  Luca Coelho <luciano.coelho@intel.com>
  Luis Chamberlain <mcgrof@kernel.org>
  Luo Likang <luolikang@nsfocus.com>
  Mans Rullgard <mans@mansr.com>
  Miquel Raynal <miquel.raynal@bootlin.com>
  Miri Korenblit <miriam.rachel.korenblit@intel.com>
  Nikolay Aleksandrov <nikolay@nvidia.com>
  Oleksandr Mazur <oleksandr.mazur@plvision.eu>
  Oliver Neukum <oneukum@suse.com>
  Pablo Neira Ayuso <pablo@netfilter.org>
  Phil Elwell <phil@raspberrypi.com>
  Radu Bulie <radu-andrei.bulie@nxp.com>
  Rob Herring <robh@kernel.org>
  Seth Forshee <sforshee@digitalocean.com>
  Simon Horman <simon.horman@corigine.com>
  Stefan Schmidt <stefan@datenfreihafen.org>
  Toke Høiland-Jørgensen <toke@redhat.com>
  Toke Høiland-Jørgensen <toke@toke.dk>
  Tom Rix <trix@redhat.com>
  Tony Nguyen <anthony.l.nguyen@intel.com>
  Valdis Klētnieks <valdis.kletnieks@vt.edu>
  Vladimir Oltean <vladimir.oltean@nxp.com>
  Wen Gu <guwen@linux.alibaba.com>
  Willem de Bruijn <willemb@google.com>
  Xin Long <lucien.xin@gmail.com>
  Yi Chen <yiche@redhat.com>
  Zhang Changzhong <zhangchangzhong@huawei.com>
  Zhang Yunkai <zhang.yunkai@zte.com.cn>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   f71077a4d84b..8b97cae315ca  8b97cae315cafd7debf3601f88621e2aa8956ef3 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Fri Feb 18 05:01:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 18 Feb 2022 05:01:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275068.470769 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKvOb-0001xC-UR; Fri, 18 Feb 2022 05:01:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275068.470769; Fri, 18 Feb 2022 05:01:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKvOb-0001x5-R9; Fri, 18 Feb 2022 05:01:29 +0000
Received: by outflank-mailman (input) for mailman id 275068;
 Fri, 18 Feb 2022 05:01:28 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qkm2=TB=intel.com=kevin.tian@srs-se1.protection.inumbo.net>)
 id 1nKvOZ-0001wz-Q1
 for xen-devel@lists.xenproject.org; Fri, 18 Feb 2022 05:01:28 +0000
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d0695a7f-9077-11ec-8eb8-a37418f5ba1a;
 Fri, 18 Feb 2022 06:01:23 +0100 (CET)
Received: from orsmga006.jf.intel.com ([10.7.209.51])
 by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 17 Feb 2022 21:01:20 -0800
Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19])
 by orsmga006.jf.intel.com with ESMTP; 17 Feb 2022 21:01:18 -0800
Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by
 ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.20; Thu, 17 Feb 2022 21:01:17 -0800
Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by
 orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.20 via Frontend Transport; Thu, 17 Feb 2022 21:01:17 -0800
Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.47) by
 edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.1.2308.20; Thu, 17 Feb 2022 21:01:17 -0800
Received: from BN9PR11MB5276.namprd11.prod.outlook.com (2603:10b6:408:135::18)
 by MWHPR1101MB2304.namprd11.prod.outlook.com (2603:10b6:301:4e::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.16; Fri, 18 Feb
 2022 05:01:10 +0000
Received: from BN9PR11MB5276.namprd11.prod.outlook.com
 ([fe80::f514:7aae:315b:4d8d]) by BN9PR11MB5276.namprd11.prod.outlook.com
 ([fe80::f514:7aae:315b:4d8d%3]) with mapi id 15.20.4995.016; Fri, 18 Feb 2022
 05:01:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d0695a7f-9077-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
  d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
  t=1645160484; x=1676696484;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-transfer-encoding:mime-version;
  bh=DeRfIz/ZZN9WK9zX+Y3M8EAmfgxbe1Ge5kugEXG99Zs=;
  b=iSIOrakMyqsrbXg1BwHEQC7K0oSTmDZm7u18xyv/o40ZGFskXMj5RzRN
   F2WjjHbq6HvPoK9gr4dWIPGAzrxeuXIJbjIw7fmLKpOZIMZdyi6G/WJQl
   kK2vUyrkwu5Tof9F85C4XdHDMQjnTqlD3DfrQjKEf7sc1Se77mnwe+Rf7
   FQqCx0JIEUfWjnsMIkYF+mDaIGKHU/dfHvxdXV+1L1TphOyJvQoR9Q7S+
   o62H5k4lj6W+x+kGEtkn8ZREpSLWn6wclX/a3Ac2Qx1rzLDLGKqq1iQ9w
   9Yi2agBF5qsg6bAaLKaEIfNKrDO4biyRQ2P6++2P6r4Mki+BAfTbqAF88
   g==;
X-IronPort-AV: E=McAfee;i="6200,9189,10261"; a="337496732"
X-IronPort-AV: E=Sophos;i="5.88,377,1635231600"; 
   d="scan'208";a="337496732"
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.88,377,1635231600"; 
   d="scan'208";a="504655328"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=LM5FSjLIkrp/GFnrFKnKZY6G1eaP4TxlG2Hhj+kCxVVSsdfjW4zZ11wjJLuS732W2mvGKY91rJv8kK17Y809lqwUq2tM8PC1xlYsdnCrquLgmXXNcgNFVQiJ2YFbuCTUqjAmcvSonGXUf/oFJiq3d1+A4641ho2R7i6mzrm1V8OcoZM3PIpArB9vG5/FigCD40abR6+LdHf//LR/zZuDgxjMCJfMLTKpnQ1LtICOwYcwOYhCeqdpAUpzYMA+42jIUGoSLOMWkCJPOwakwoa0BftOVeqZrUwTTNtRBWQhsZ04WyYnpkZtCEF5H1HUNoKoNLzJpcajmRWzR1/M8+W2pA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=DeRfIz/ZZN9WK9zX+Y3M8EAmfgxbe1Ge5kugEXG99Zs=;
 b=U+J33e04r1d0sSIrX2aokD/bhET6XSmq8Px1DDNh7jOQw6nOjgYpkqMJELiVkqMHTXx0LTHFgNZifK7UGQZr/3em1rH7U0i2rEcxBdjnFJCr9h5Ru6IRCwz1ec0seMRi0X4OcKk49tUuRVj4lhsjKc289n5m8ZrHrnRdKyTj6QnkuIs1goIdQ3aYYhT0+8tD+JI2+BnxgJZiZv5xfAJOxvzAYLMbmeIjxbAzjuDB6q7vOpuohLgJkPfqnakl+HekX5UVauLmUTSnRrwTNO1AW1jEMOcZ0yeRny69BE/ipL79k53A+YzuIysqUdV8iWjYrqdpahLuTcnCA0Ghc/QK8g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
 dkim=pass header.d=intel.com; arc=none
From: "Tian, Kevin" <kevin.tian@intel.com>
To: "Beulich, Jan" <JBeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: "Cooper, Andrew" <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>,
	=?utf-8?B?UGF1IE1vbm7DqSwgUm9nZXI=?= <roger.pau@citrix.com>
Subject: RE: [PATCH v3 17/23] IOMMU/x86: prefill newly allocate page tables
Thread-Topic: [PATCH v3 17/23] IOMMU/x86: prefill newly allocate page tables
Thread-Index: AQHYBkAJc6JSR61nEESS/gtIFkcsm6yY/BvA
Date: Fri, 18 Feb 2022 05:01:10 +0000
Message-ID: <BN9PR11MB52763A2638F1460EC83420B38C379@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <76cb9f26-e316-98a2-b1ba-e51e3d20f335@suse.com>
 <b985d619-05ea-73c1-1919-b0343e5a9b8e@suse.com>
In-Reply-To: <b985d619-05ea-73c1-1919-b0343e5a9b8e@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=intel.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 77bd9722-8220-4264-0a4e-08d9f29bae4e
x-ms-traffictypediagnostic: MWHPR1101MB2304:EE_
x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr
x-microsoft-antispam-prvs: <MWHPR1101MB2304D60ED003445D3B376B1C8C379@MWHPR1101MB2304.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:6430;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: IYtmsLVkFo0+dDUEnH7dgCYszwp8L3keCG2xuMOgLL/+JBWC2trZJCCqSQFCHvl9HImAuxbDSXOuk2kVhXS/RuFXTZIXgbJFfqGagsosa0eDBLRwB1WhWPA0xTk/OXICPy0eaFmKktI9/R2B4qDL/Ifelycqwu07gq6YS9vluA6OjOrbQw/NupPIDFfFnXO+eljDlFBQJ7LQ/2fyTrkinxvNNgLhRUm6TsfLwK7MSINL97biVt2GEnt6ZR1WsZVFwqN/6SvaMvpDc7923AmC/x+mh+7ceatsy1E1CbnYkY+ikVCzzeUwtTPAq8oUbqpLbciWncmHPLWaEDb+yuesbke01NdkZvEBhGp9srXTCJ70+0Uc3j7I0M4yoYIFMuC1A3ZzxBqi3RVDxMyJ3PpgximZyZ1f4TcY3AVvqsZ0AjgVesy5uXbgWHBDofghFQ6ENVKwuLsVjwRavnKrF0qFwMJZSWl6ar0daLznhFSO10p9H6UB3PTOahnAbF3d5b0XpEjRhv4Se2F5aSJmYz/g28zINpZklGy2pCrLhsC3vnNpgwRkQrwoX7HD94UE0LJKW4U/K+LPgSJZAbuPjqoS/QBTs3kV1zWsSdPtcHMwdhTyFZuWXjT9m7M0focDSM1Xg/L6ZaSF6qkXJFqGZQdW9BJ1evxii91nN7HF7Wfh4wrAXFaqwxGhbOonP60Qi1mTuqSwExOXtY5AtBept08WXQ==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5276.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(316002)(5660300002)(186003)(26005)(122000001)(82960400001)(54906003)(110136005)(8936002)(83380400001)(55016003)(7696005)(6506007)(2906002)(508600001)(86362001)(38100700002)(52536014)(71200400001)(9686003)(66946007)(8676002)(4326008)(66556008)(64756008)(33656002)(38070700005)(76116006)(66476007)(66446008);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?WmVhbGRFVTNzanpmcG1aejVjOXpETE5HWGlpUWFGdWdaRGw1NHJCOHJCRkdS?=
 =?utf-8?B?bUVaOXJtNjdqL1N0ZGsvQjAwa3dQbXpBRTNpYXVwQU8xQmZaR0FJUW5rdGJH?=
 =?utf-8?B?QnNqWWNoVnMzNW5MbVYyTWpyU1pLcUxjQmtJNHRGbU9mUUdINytMZ2h0ZWdF?=
 =?utf-8?B?MzBEM2Rua2NVcDVLZXRud0VMSXM0U2ViODBUOHRUakJjWGdhMnJSK3VFTHlD?=
 =?utf-8?B?eFR2ZXRpYlMzNUdYNms0enJ1alNRYThlblJENnBNVVFBcVc3dk1XcEc2U21M?=
 =?utf-8?B?MG5SSGFLN2xNcWxET0VqdnJ0V2lZSUZMcDUzOGJpaTVXaFI1d3pEVGprQllD?=
 =?utf-8?B?dEl3QjdsWDdDQmUveWNqMEx4TWxSZ3RiZ3Q4QUpMK3k5NFdPMTdRY2ZGRm4z?=
 =?utf-8?B?UzgxdVdKNjFkcjJHQ3hzOVdOVlZGTGh6L3JWQ3BKZUNXQUpUWHN2WFZZdk5y?=
 =?utf-8?B?WGd0Sy9UMFpoQ241WWs0Y3BpS1J5TStDWG1yMzZzdWxMbElHaC9aWnZTMEh0?=
 =?utf-8?B?cExhbW1oUVNhc2l3Y1dWTjllbThiVEE2aklsSEZlWlA1bnM5TmJXeWpMTFNW?=
 =?utf-8?B?a1Fqc09Dc013WG8zbE4wSDlBVEZWQzJNOFpZTzluVUlkTWo4VWdOVEszQllF?=
 =?utf-8?B?RjhNNGNpbWNrZFZiTTNYcEdJQ3Z6VWtxUmpEdjYxWWJ0bnFualBQa3RZeVQ3?=
 =?utf-8?B?endOM1c1NVVXWUQxVUE5UFlmUTdsNlBXdk5taVhXR2lWYlZSQmVxZVlreDhG?=
 =?utf-8?B?QkxNSHk1Wno4N3c0cm1CT254ZVB4QWs0RHNOV0VtMXE5NDdNTnRBdnFDL00z?=
 =?utf-8?B?Tlgvcm5xMms5NFJCRlpGUDJhQjFJTTV6dks5bVpDeWg2RlJCQmpiNXJwOWF1?=
 =?utf-8?B?cS9jZUNSTktvaGhHalh0aDZTdFFtODh3SCtBYjJ3QWNJMWd5U2w3OG1BaXEy?=
 =?utf-8?B?TGtYYjRtSURlampZc3d1dzF2L1NtVkNZSERtNnJPWndYa1pkM1Q1ek9Od2h0?=
 =?utf-8?B?bU5wMHZ2Y2lwUG16MjR5NEw5b2VvbDlOMzJaUEVFZlB6RWhPdFl0RVA5QU1F?=
 =?utf-8?B?YUlTY3UzM3JIOGR6cy94T25oUkc5TUlBbktnTmp1YWRVWXJobENjNnhYbnlx?=
 =?utf-8?B?TVRYMGZpT0VtRlhOd1Jnc2h2dzliSWtxMG1TWnlGSkZ2REczQmdKWllkRVNz?=
 =?utf-8?B?alh0NXJwKys3blRQczlJWGlPekRSVElReVB3L2tGcEFYb0RETGtOQ1dsZVpC?=
 =?utf-8?B?WkZZRVQ3OC9HODVZeWpjYW1melhWQUt3WXg3MDgvSXpVUlZxRWdBVGUxNXBP?=
 =?utf-8?B?NjhpVkRyQk81YUJrRGhEQ0pTY0pVRE9tcFdEdVl6T0RKZHg5dldQKzFTNldL?=
 =?utf-8?B?U1JxaFNvN05UV3RPcVNrVDF2ZGVUcHVtSGNSR0pZcHVGM2pURURaTjA2dTFx?=
 =?utf-8?B?TEZ6djU2eUpDaXlEdUxNR1kwNU1qc3Q0YkZUL3JZZlVWOGxDYjhXbi9uQTJj?=
 =?utf-8?B?U0xQdzY1ZllLMEk1cGdpa3ZoWUg2azBEMjdsYk1UV2NoZU9WZGc2N2RjWmlN?=
 =?utf-8?B?Q3liWDZvZHdLZHNjb3ZKcVJPK3Z1QlV6ZVV4ZDBJN3dMZDhXdnhsZkRCeHVQ?=
 =?utf-8?B?SVluZExzM2dzcDc0M0FFK3Q3WjVoQnFNcnIyQThtVmEvbmdYYm5WRDI1ZGth?=
 =?utf-8?B?M2NLVm1xZmdWL21qSnNBdkxwVWFrd0wwbTdybDAySDZyOXU2R3hjMlJEeFVq?=
 =?utf-8?B?M29LcktVRmFCc1FWRVlSYytqQ3N4a0JzOGNQN3RTeG8zY1c3K3Fhcnk2cHdR?=
 =?utf-8?B?ZGhQZ0ZDVVBEblZBdnhTclplRDN1ZHNRM0pkaXhYejlsR1NOVmxZZ0JzMktm?=
 =?utf-8?B?MklxVE04dGduWTNqQ212eVNRYVk4TmFYSzNwWTFDNG91eWVNSUdjaW9wVi9r?=
 =?utf-8?B?bUJYZnVkZjZqNDV0ZmptNk5lMm5lRGkvTEErVE9NU3VXRmlUd1lWOVRhOXhr?=
 =?utf-8?B?YzVVUXgrd0RxVlFWNG9RQW5EWGw5di9qdXF2K1dJVHR4Lzd1ekx3U1BSQm9j?=
 =?utf-8?B?bG9rU2hZSWVINFJicmNKOHk1c3FsQXEzcDVxeENiUFlzeGExcUo2Q00yMFJ0?=
 =?utf-8?B?eS9iblN3YzMyTFh6US93YU15OXFieTdTYng4ZWsvTEdYNmlRcWJDZWFRVUo1?=
 =?utf-8?B?WWc9PQ==?=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 77bd9722-8220-4264-0a4e-08d9f29bae4e
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Feb 2022 05:01:10.6901
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 3vaJaW9PFz8F6XdSx9wdtjtnwjvwqWw6BsqIZEa7/ljj65nq5CdwtzXVu1w3Phme3LoYCrmUxYqQQcqoBiauhA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2304
X-OriginatorOrg: intel.com

PiBGcm9tOiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+IFNlbnQ6IFR1ZXNkYXks
IEphbnVhcnkgMTEsIDIwMjIgMTI6MzUgQU0NCj4gDQo+IFBhZ2UgdGFibGVzIGFyZSB1c2VkIGZv
ciB0d28gcHVycG9zZXMgYWZ0ZXIgYWxsb2NhdGlvbjogVGhleSBlaXRoZXINCj4gc3RhcnQgb3V0
IGFsbCBlbXB0eSwgb3IgdGhleSBnZXQgZmlsbGVkIHRvIHJlcGxhY2UgYSBzdXBlcnBhZ2UuDQo+
IFN1YnNlcXVlbnRseSwgdG8gcmVwbGFjZSBhbGwgZW1wdHkgb3IgZnVsbHkgY29udGlndW91cyBw
YWdlIHRhYmxlcywNCj4gY29udGlndW91cyBzdWItcmVnaW9ucyB3aWxsIGJlIHJlY29yZGVkIHdp
dGhpbiBpbmRpdmlkdWFsIHBhZ2UgdGFibGVzLg0KPiBJbnN0YWxsIHRoZSBpbml0aWFsIHNldCBv
ZiBtYXJrZXJzIGltbWVkaWF0ZWx5IGFmdGVyIGFsbG9jYXRpb24uIE1ha2UNCj4gc3VyZSB0byBy
ZXRhaW4gdGhlc2UgbWFya2VycyB3aGVuIGZ1cnRoZXIgcG9wdWxhdGluZyBhIHBhZ2UgdGFibGUg
aW4NCj4gcHJlcGFyYXRpb24gZm9yIGl0IHRvIHJlcGxhY2UgYSBzdXBlcnBhZ2UuDQo+IA0KPiBU
aGUgbWFya2VycyBhcmUgc2ltcGx5IDQtYml0IGZpZWxkcyBob2xkaW5nIHRoZSBvcmRlciB2YWx1
ZSBvZg0KPiBjb250aWd1b3VzIGVudHJpZXMuIFRvIGRlbW9uc3RyYXRlIHRoaXMsIGlmIGEgcGFn
ZSB0YWJsZSBoYWQganVzdCAxNg0KPiBlbnRyaWVzLCB0aGlzIHdvdWxkIGJlIHRoZSBpbml0aWFs
IChmdWxseSBjb250aWd1b3VzKSBzZXQgb2YgbWFya2VyczoNCj4gDQo+IGluZGV4ICAwIDEgMiAz
IDQgNSA2IDcgOCA5IEEgQiBDIEQgRSBGDQo+IG1hcmtlciA0IDAgMSAwIDIgMCAxIDAgMyAwIDEg
MCAyIDAgMSAwDQo+IA0KPiAiQ29udGlndW91cyIgaGVyZSBtZWFucyBub3Qgb25seSBwcmVzZW50
IGVudHJpZXMgd2l0aCBzdWNjZXNzaXZlbHkNCj4gaW5jcmVhc2luZyBNRk5zLCBlYWNoIG9uZSBz
dWl0YWJseSBhbGlnbmVkIGZvciBpdHMgc2xvdCwgYnV0IGFsc28gYQ0KPiByZXNwZWN0aXZlIG51
bWJlciBvZiBhbGwgbm9uLXByZXNlbnQgZW50cmllcy4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IEph
biBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCg0KUmV2aWV3ZWQtYnk6IEtldmluIFRpYW4g
PGtldmluLnRpYW5AaW50ZWwuY29tPiwgd2l0aCBhIG5pdDoNCg0KPiBAQCAtNDc4LDcgKzQ3OCwy
OCBAQCBzdHJ1Y3QgcGFnZV9pbmZvICppb21tdV9hbGxvY19wZ3RhYmxlKHN0DQo+ICAgICAgICAg
IHJldHVybiBOVUxMOw0KPiANCj4gICAgICBwID0gX19tYXBfZG9tYWluX3BhZ2UocGcpOw0KPiAt
ICAgIGNsZWFyX3BhZ2UocCk7DQo+ICsNCj4gKyAgICBpZiAoIGNvbnRpZ19tYXNrICkNCj4gKyAg
ICB7DQo+ICsgICAgICAgIHVuc2lnbmVkIGludCBpLCBzaGlmdCA9IGZpbmRfZmlyc3Rfc2V0X2Jp
dChjb250aWdfbWFzayk7DQo+ICsNCj4gKyAgICAgICAgQVNTRVJUKCgoUEFHRV9TSElGVCAtIDMp
ICYgKGNvbnRpZ19tYXNrID4+IHNoaWZ0KSkgPT0gUEFHRV9TSElGVCAtIDMpOw0KPiArDQo+ICsg
ICAgICAgIHBbMF0gPSAoUEFHRV9TSElGVCAtIDN1bGwpIDw8IHNoaWZ0Ow0KPiArICAgICAgICBw
WzFdID0gMDsNCj4gKyAgICAgICAgcFsyXSA9IDF1bGwgPDwgc2hpZnQ7DQo+ICsgICAgICAgIHBb
M10gPSAwOw0KPiArDQo+ICsgICAgICAgIGZvciAoIGkgPSA0OyBpIDwgUEFHRV9TSVpFIC8gODsg
aSArPSA0ICkNCj4gKyAgICAgICAgew0KPiArICAgICAgICAgICAgcFtpICsgMF0gPSAoZmluZF9m
aXJzdF9zZXRfYml0KGkpICsgMHVsbCkgPDwgc2hpZnQ7DQo+ICsgICAgICAgICAgICBwW2kgKyAx
XSA9IDA7DQo+ICsgICAgICAgICAgICBwW2kgKyAyXSA9IDF1bGwgPDwgc2hpZnQ7DQo+ICsgICAg
ICAgICAgICBwW2kgKyAzXSA9IDA7DQo+ICsgICAgICAgIH0NCg0Kc29tZSBjb21tZW50IHNpbWls
YXIgdG8gd2hhdCBjb21taXQgbXNnIGRlc2NyaWJlcyBjYW4gaW1wcm92ZQ0KdGhlIHJlYWRhYmls
aXR5IGhlcmUuDQoNClRoYW5rcw0KS2V2aW4NCg==


From xen-devel-bounces@lists.xenproject.org Fri Feb 18 05:12:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 18 Feb 2022 05:12:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275077.470779 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKvZW-0003Wp-3c; Fri, 18 Feb 2022 05:12:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275077.470779; Fri, 18 Feb 2022 05:12:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKvZW-0003Wi-0J; Fri, 18 Feb 2022 05:12:46 +0000
Received: by outflank-mailman (input) for mailman id 275077;
 Fri, 18 Feb 2022 05:12:44 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=xRNf=TB=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nKvZU-0003Wc-AN
 for xen-devel@lists.xenproject.org; Fri, 18 Feb 2022 05:12:44 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6650e886-9079-11ec-8eb8-a37418f5ba1a;
 Fri, 18 Feb 2022 06:12:43 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 1EE3A2199B;
 Fri, 18 Feb 2022 05:12:42 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D1AD213B7B;
 Fri, 18 Feb 2022 05:12:41 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id nBSAMMkqD2I9CgAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 18 Feb 2022 05:12:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6650e886-9079-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1645161162; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=yv+VO1s/oQPkN+v0bIm76a0uAXqBiz6QaRFYTTbqzeY=;
	b=bwNLuGKvkw6p37X34mligOffFYkFvtUnuquhBC3NNWdwdda8xtNzeoGCTX3kRNh1R7Z6XE
	QeXM0KwJienMwvUW+oizx1LZ0PcXC+T6YFLIdaSbfgqEZMRfw+rGs7aaMpfJt/cb670TAy
	9b7hvMjCa0chFo810aNZx/hOBjP/I4w=
Message-ID: <5f5cabaf-ffd8-264e-ac40-d7c4a6db260f@suse.com>
Date: Fri, 18 Feb 2022 06:12:41 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Subject: Re: [PATCH v2 2/2] xen/include/public: deprecate GNTTABOP_transfer
Content-Language: en-US
To: Julien Grall <julien@xen.org>, xen-devel@lists.xenproject.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
References: <20220203131418.1319-1-jgross@suse.com>
 <20220203131418.1319-2-jgross@suse.com>
 <a35bb9ba-e2be-f73e-9272-906bc09d9b6e@xen.org>
 <93e50bc4-6e53-b753-c520-7d1d0a5a5f5a@suse.com>
 <eea83d0a-a96d-f050-c6ac-7dad731a16f0@xen.org>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <eea83d0a-a96d-f050-c6ac-7dad731a16f0@xen.org>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------YiabZme1b6jFk57APfeLxDaU"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------YiabZme1b6jFk57APfeLxDaU
Content-Type: multipart/mixed; boundary="------------0Gpr3l5elaSUndAmNfNyshoM";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Julien Grall <julien@xen.org>, xen-devel@lists.xenproject.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Message-ID: <5f5cabaf-ffd8-264e-ac40-d7c4a6db260f@suse.com>
Subject: Re: [PATCH v2 2/2] xen/include/public: deprecate GNTTABOP_transfer
References: <20220203131418.1319-1-jgross@suse.com>
 <20220203131418.1319-2-jgross@suse.com>
 <a35bb9ba-e2be-f73e-9272-906bc09d9b6e@xen.org>
 <93e50bc4-6e53-b753-c520-7d1d0a5a5f5a@suse.com>
 <eea83d0a-a96d-f050-c6ac-7dad731a16f0@xen.org>
In-Reply-To: <eea83d0a-a96d-f050-c6ac-7dad731a16f0@xen.org>

--------------0Gpr3l5elaSUndAmNfNyshoM
Content-Type: multipart/mixed; boundary="------------5B0ezaljc0kP6Pjfvzd5OVkw"

--------------5B0ezaljc0kP6Pjfvzd5OVkw
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMTcuMDIuMjIgMjA6NTUsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gSGksDQo+IA0KPiBP
biAxNi8wMi8yMDIyIDA3OjIwLCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gT24gMTUuMDIu
MjIgMjI6MTMsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4+PiBIaSBKdWVyZ2VuLA0KPj4+DQo+
Pj4gT24gMDMvMDIvMjAyMiAxMzoxNCwgSnVlcmdlbiBHcm9zcyB3cm90ZToNCj4+Pj4gQWRk
IGEgY29tbWVudCB0byBpbmNsdWRlL3B1YmxpYy9ncmFudF90YWJsZS5oIHRoYXQgR05UVEFC
T1BfdHJhbnNmZXINCj4+Pj4gaXMgZGVwcmVjYXRlZCwgaW4gb3JkZXIgdG8gZGlzY291cmFn
ZSBuZXcgdXNlIGNhc2VzLg0KPj4+DQo+Pj4gwqBGcm9tIHRoZSBjb21taXQgbWVzc2FnZSwg
aXQgaXMgdW5jbGVhciB0byBtZSB3aHkgd2UgYXJlIGRpc2NvdXJhZ2luZyANCj4+PiBuZXcg
dXNlIGNhc2VzIGFuZCBpbmRpcmVjdGx5IGVuY291cmFnaW5nIGN1cnJlbnQgdXNlcnMgdG8g
bW92ZSBhd2F5IA0KPj4+IGZyb20gdGhlIGZlYXR1cmUuDQo+Pj4NCj4+PiBQYXRjaCAjMSBz
ZWVtcyB0byBpbXBseSB0aGlzIGlzIGJlY2F1c2UgdGhlIGZlYXR1cmUgaXMgbm90IHByZXNl
bnQgaW4gDQo+Pj4gTGludXggdXBzdHJlYW0uIEJ1dCBJIGRvbid0IHRoaW5rIHRoaXMgaXMg
YSBzdWZmaWNpZW50IHJlYXNvbiB0byANCj4+PiBkZXByZWNhdGUgYSBmZWF0dXJlLg0KPj4+
DQo+Pj4gQSBtb3JlIGNvbXBlbGxpbmcgcmVhc29uIHdvdWxkIGJlIHRoYXQgdGhlIGZlYXR1
cmUgaXMgYnJva2VuIGFuZCB0b28gDQo+Pj4gY29tcGxleCB0byBmaXggaXQuDQo+Pj4NCj4+
PiBTbyBjYW4geW91IHByb3ZpZGUgbW9yZSBkZXRhaWxzPw0KPj4NCj4+IEl0IGlzIGEgZmVh
dHVyZSBhdmFpbGFibGUgZm9yIFBWIGRvbWFpbnMgb25seSwgYW5kIGl0IGlzIHZlcnkgY29t
cGxleA0KPj4gYW5kIGhhc24ndCBiZWVuIHRlc3RlZCBmb3IgYWdlcy4NCj4gDQo+IFJpZ2h0
LiBUbyByZXBseSB0byBKYW4ncyBlLW1haWwgaGVyZSwgc2hvdWxkbid0IHdlIGFsc28gZGUt
c3VwcG9ydCANCj4gKGVpdGhlciBjb21wbGV0ZWx5IG9yIHNlY3VyaXR5KSBpbiB0aGlzIGNh
c2U/DQo+IA0KPiBNeSBjb25jZXJuIGhlcmUgaXMgeW91IHdyb3RlIHRoaXMgY29kZSBoYXMg
YmVlbiB1bnRlc3RlZCBmb3IgYWdlcyAobm90IA0KPiBjbGVhciBob3cgbG9uZykgYW5kIGNv
bXBsZXguIFNvIHBvdGVudGlhbGx5IHRoaXMgbWVhbnMgdGhlcmUgYXJlIA0KPiBzZWN1cml0
eSBpc3N1ZXMgaW4gaXQuDQoNCkluIGNhc2Ugd2UgYXJlIGRvaW5nIHRoaXMsIHdlIHNob3Vs
ZCBzZXQgdGhlIGRlZmF1bHQgdG8gZGlzYWJsZSB0aGUNCnRyYW5zZmVyIGZ1bmN0aW9uYWxp
dHkuDQoNCg0KSnVlcmdlbg0K
--------------5B0ezaljc0kP6Pjfvzd5OVkw
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------5B0ezaljc0kP6Pjfvzd5OVkw--

--------------0Gpr3l5elaSUndAmNfNyshoM--

--------------YiabZme1b6jFk57APfeLxDaU
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmIPKskFAwAAAAAACgkQsN6d1ii/Ey/w
ngf8Ca1Y2773QgQDCIyIhUtqF0Ouf3ZbhXHrF85JwRjxhtyv+tGtOF9tZHdPzRAwjVyVoUcmZt2O
1Gz/AqoO5+NrCBCG3hRrtjxtFcBxoQ5gOE1YCv7aG1Nu9JjxiWOmX/CixDW7AOZrB7md4gKfvfvg
tinGEmSylBWGrYMxt/1ax+e4HaCOzBp6rPNgYYQemzbKqtspq0WwbYnka9zBkXK2TdAAMaDaap/H
DRkRoin2ZyOjlXkmry8BJ/2cj5OkV5Vx2T6Pdd+sFioqhGbSeVLRpJ+hB8iao4x2PeUWQMNTO9lL
0i3ddiIBOXJAregLH80Pev1vapEz3t9ZV6KX4mtKcw==
=8c5+
-----END PGP SIGNATURE-----

--------------YiabZme1b6jFk57APfeLxDaU--


From xen-devel-bounces@lists.xenproject.org Fri Feb 18 05:20:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 18 Feb 2022 05:20:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275084.470791 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKvh7-00050M-UT; Fri, 18 Feb 2022 05:20:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275084.470791; Fri, 18 Feb 2022 05:20:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKvh7-00050F-Qc; Fri, 18 Feb 2022 05:20:37 +0000
Received: by outflank-mailman (input) for mailman id 275084;
 Fri, 18 Feb 2022 05:20:36 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qkm2=TB=intel.com=kevin.tian@srs-se1.protection.inumbo.net>)
 id 1nKvh6-000509-94
 for xen-devel@lists.xenproject.org; Fri, 18 Feb 2022 05:20:36 +0000
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7e11a3a8-907a-11ec-8eb8-a37418f5ba1a;
 Fri, 18 Feb 2022 06:20:33 +0100 (CET)
Received: from orsmga005.jf.intel.com ([10.7.209.41])
 by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 17 Feb 2022 21:20:31 -0800
Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81])
 by orsmga005.jf.intel.com with ESMTP; 17 Feb 2022 21:20:31 -0800
Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by
 fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.20; Thu, 17 Feb 2022 21:20:30 -0800
Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by
 fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.20 via Frontend Transport; Thu, 17 Feb 2022 21:20:30 -0800
Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.168)
 by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.1.2308.20; Thu, 17 Feb 2022 21:20:30 -0800
Received: from BN9PR11MB5276.namprd11.prod.outlook.com (2603:10b6:408:135::18)
 by DM5PR11MB0058.namprd11.prod.outlook.com (2603:10b6:4:6c::11) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Fri, 18 Feb
 2022 05:20:29 +0000
Received: from BN9PR11MB5276.namprd11.prod.outlook.com
 ([fe80::f514:7aae:315b:4d8d]) by BN9PR11MB5276.namprd11.prod.outlook.com
 ([fe80::f514:7aae:315b:4d8d%3]) with mapi id 15.20.4995.016; Fri, 18 Feb 2022
 05:20:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7e11a3a8-907a-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
  d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
  t=1645161633; x=1676697633;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-transfer-encoding:mime-version;
  bh=55WpNPG1YQ4oNB2e4F6gEqonZ7TVbRzDH6W+HYJNnmU=;
  b=hwb7BD9PiheVJv40zBTMEpdT7Xhez4PoKMxuSVK7KPtCJiqlZ0iK6YsO
   LIWIiIiDJ7ECXM43sr4Trn421wZmUULnYCQ7YvnwaWescmQAMofiQ2mAb
   n8/sgKGM9eFnE2NaC9jFtRk52V9h/9HY1C6mHl8EF1ha2qjE/ctZiWLqS
   tcvDFrzqBEHIOtuMC8CTj1pD+ri+I60vSfSokvOM/KI6EFhfsLaxe9saB
   gX8EKsQrvCYFotg3ly3e56FZI8XM/pXc5wXeAwajj6lqd0NKb6Mrjqw03
   p+Kw7IFnEA9up7anQzE4xcbKzU9hc2gUw8ds2amFd6vyTqPt96p95kEBo
   A==;
X-IronPort-AV: E=McAfee;i="6200,9189,10261"; a="314319413"
X-IronPort-AV: E=Sophos;i="5.88,377,1635231600"; 
   d="scan'208";a="314319413"
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.88,377,1635231600"; 
   d="scan'208";a="705231493"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=eAQKMHG3rKsqIwsvSEeOe1Ti/OSPySwGY/l4jp53krRvQ5lL7oycnNJEzxdk7VPFvw7cv8Z4QrGmBlM8GsrhBVGqFmwhAXVIjkdJH5mur7iM2AM7kf8vZxZa/WQDygbPI8d4BlMaPvnkrUcuJkRTa+SjQG+Qj78Da3UwH6+TaLk4u+eI/qMQdC3uNEMCbOdrhwA5Rmp7wN9OAENqpS1mzOREVCKtqFS7MXf0/5pTUosZfEmuJI8kBtKts69l/7WhsLpL07uscLV/S/waXNTXSr72uc1MKN3w9m8htAANhpbPlEfDkRuEVEhrDxG/gBmBXDqcHm7TFGSPso5Npd/f9A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=55WpNPG1YQ4oNB2e4F6gEqonZ7TVbRzDH6W+HYJNnmU=;
 b=mypLZWSnFg0w0+dBin2tAxsv8NdyCJluGUXC1FqXyceFPi6iWrpZ7P1knbf2/IzsmKnsYFdgeFiUTU2D+cdqPfKiMVW4/gMfA6RRi1gSAbs6xnKAlUACfT1maJhWL7edvz7thbNDtrg6hNrhzDYZ/j0r1ThkNSgdlcMlQvG37nFClyK7zMnpt2E6I9sNVxm0fjWBZuVS7hHVEL8I7Ia9nXbUmYqjXKBIPrZBTSa213341u4KrtWmHs6C9byT6GnlX9FJhGIcM5I5DDaC0EB5GepMkeiRVZ4tCM99KkWnIQLHj/j1oLjsbiDcvvmunOHdWP4qXVXzXVIcxOlmtsGlDg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
From: "Tian, Kevin" <kevin.tian@intel.com>
To: "Beulich, Jan" <JBeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: "Cooper, Andrew" <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>,
	=?utf-8?B?UGF1IE1vbm7DqSwgUm9nZXI=?= <roger.pau@citrix.com>
Subject: RE: [PATCH v3 20/23] VT-d: free all-empty page tables
Thread-Topic: [PATCH v3 20/23] VT-d: free all-empty page tables
Thread-Index: AQHYBkBAHcUqxDPFCEWIL9jRoPTFzayZAFJQ
Date: Fri, 18 Feb 2022 05:20:29 +0000
Message-ID: <BN9PR11MB527622E58C2E4EF90CF29EF88C379@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <76cb9f26-e316-98a2-b1ba-e51e3d20f335@suse.com>
 <807a48fe-3829-d976-75dc-1767d32fb0f4@suse.com>
In-Reply-To: <807a48fe-3829-d976-75dc-1767d32fb0f4@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=intel.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 98afe172-4c82-4b1a-f177-08d9f29e60dc
x-ms-traffictypediagnostic: DM5PR11MB0058:EE_
x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr
x-microsoft-antispam-prvs: <DM5PR11MB00587728688EBB114225134C8C379@DM5PR11MB0058.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:7219;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: lN47a3R3U5mkSCtVlJoUb4U3Tj13ElbFNvwXvBfHeFYipFFReaM5bSQfs+QdL6KGme3jYYjNhav9PplItHaumkatOKnWFKL9IGoUKE2MWJH3wdqvDrQoXFak89ISSdLTrH4zyjuK0ndFtTrU9eLzuS544/jCfTdzLyjQ9kx1prvO8+II8tI8+Wip4yn9GzZG0LnPueFfuQgKWrdIRI1tusiELeU0CuPa3Nu+OjnBi636cCZfc3piwbh/RxnP85K5UshfX9APkaiUf+5QPGzoXfxx1nmvceWTlU2n81gxbZqGLducnRqXVb61xkQTO1COgtazk4KwNpvAr2I9XtMxuhIapGu6dPVkb1wOLX1M4/+hfFSj2jYdSYFn7GYjrUPsWQMCC0zvU1hzMlVz7ONtTW0yvXFIPDgXWlFuPSs95oJBtFuqfegswyxIYdLQ95LYNFweGGfY1U9M/8lSglSsngQ+IaMSQmAV3FCHKCcfv7fkTbYBbAcwWDIEojaYwtRbtkcmwxQyVf3lxd/5Q01X5BJYfn/7k6gMVeOqvfq+nGIErmFUPrITiClyFTODal9bR6lWxUNWhs70T+z2G5INGHX03CcIacsbblDjgcmRGwL5+UwXPjZIWURtaSYmrozJPk/QBr5ltWNh7KNvL0KaUe9hxuSXhAYw11726K4ziMSwd7kxo/DmRqET2gYckLQIV5XXFJUaNVT+ll2TZUesUw==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5276.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(5660300002)(26005)(71200400001)(52536014)(83380400001)(38100700002)(66476007)(8936002)(110136005)(7696005)(64756008)(186003)(508600001)(82960400001)(76116006)(66946007)(9686003)(86362001)(33656002)(55016003)(66446008)(38070700005)(4326008)(66556008)(6506007)(2906002)(316002)(8676002)(54906003)(122000001);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?QnBPSHdxVjNSaHZGTFQ2ODMrbUU3dm1BRVdJZEFVTE5JUm9HN284TUZ0bnVJ?=
 =?utf-8?B?MGZZYXZsSG9mTW1EYWlwakNhTkppLzgyS0drK3dpSGhrbTA3NjBDWjZTMWw5?=
 =?utf-8?B?eDdGRDUvOU9PTGpWbkdLTWJtemRmQnJjdEJQRTZBbWxqem5wa0dXZU5SaEM4?=
 =?utf-8?B?ZXNwUlYzM0VwU3dWam0xZUpzZHVmTjZrM0FqZ09CTDVWaUpVNWZ4TXB2TTJO?=
 =?utf-8?B?V2tFVXJENkE4Tng4SDZrNlhYaDJRa0tZQWgzVUxhY0QrY3JVVzRySDNpNW5T?=
 =?utf-8?B?Q1AwOTd5ZFZBMkVLNlJiZ1ZBVXN4SzQxVHhwcDc2VmIzalNkdlVPeHJyVWNI?=
 =?utf-8?B?aGxicUZra0NmUUd2MEROL3E4SFM4U0NYMzB3dnkvRWFJRzZORkI3ZXJRN1Rt?=
 =?utf-8?B?VXJWaThxN1pTZXNsdFdqTFNoRW5sVGw4ajZBcERoMkxGaVliZndhaVkvQ2Fx?=
 =?utf-8?B?ajU2VEIrTitRMFBBWE5pZXJ0MXZjTWNuUkpyZmNMb3k0RzRFY1d0UmcwNk5U?=
 =?utf-8?B?MGhlWGJray9DbGdCWFRlOGJDZlVtdG42aFVTUENVM29iQWh3Znh3NGYvTWlH?=
 =?utf-8?B?dzNpUHNFYmI4eCtEYWphQjRGQ1JpenpsSmY2Q1VJcmRWM3BVWVE5OHhJSGIz?=
 =?utf-8?B?bC8vT1ZZSVAxdFk1S3Q3OEFaVXhRejR5QVk4VFhRZlJ1KytGTGpRR0crN3ZH?=
 =?utf-8?B?NlBNSWhQQmhxN2krNTZMYllWem9mcnpRdVJ2QTNKYm9uYlBOL2R1VUhOb1Ux?=
 =?utf-8?B?UkdSS0pzWnN1L09DdWZ0dVI3QXJXZjlHbXR3WFRyRnBEbXlVU0hrQmd2WlNy?=
 =?utf-8?B?akI0YlI3a2lSK0FHUlF3MXNXVHlRdC9zT1pzVWp4SGRLLzE3U0ZWMks1dG1a?=
 =?utf-8?B?N3l3bzNjQ2VpUVhDMEJxcElEMDJTcllWQmVNd2ZkZDhNRGF0UGdiQ1hjSXdw?=
 =?utf-8?B?cnkzRm1HTnFKSFM5azdUMGpMVEFPalg3NGZQQUNhb1BvOE1pMnFFdGh1Mkll?=
 =?utf-8?B?dVl5a2V3OGNQaEVWTG51d3JmM0UwNVFNTzkvK3dzUlpDb2xCREZGQVptdUxS?=
 =?utf-8?B?aGNnaG5TS3BsNUljSDJzTUc1MGZObnUrcEJLMHEzRkxsaUVFNjZ6NUtQVDUz?=
 =?utf-8?B?eDRKK3ZFSk9TTVRDaFp3d2pUczRnb2kwanVQZ3NuZzhGc2RnaFkxTVpKVGlw?=
 =?utf-8?B?UlZvSGxVTmFrNXlWS1d1Nm5ZZ0dJVml4WVhOQU8xblZ1a0RjZXpGbVhPeElz?=
 =?utf-8?B?TXdUQ0pzVEVUYU9aYld3OFgyYzZKZFdkb1duQTJVdVNzMUJpM3RScnZjSkRJ?=
 =?utf-8?B?Vkhnc2FIV0orbzUwaGhjd2VlWTIwdlAxd1hqZG5FL0I1ekRHQjJ4MUI1T3lR?=
 =?utf-8?B?OTJoQTJqUWpaL3NwVFF5TWQ5YWdTWW1Rb0U5L01ZT1J1UTU5b0hvS3lLYWtE?=
 =?utf-8?B?U1QydE9nbHpKUG5TSXp2VDc0cUVFOEJBL1M1Z0FOUDVTbmlTL3hnVUJSUmpI?=
 =?utf-8?B?NzNLSS85NjU1MmlrQWtPVDFDYkVHMnJTbzkxMko0RlZzUzBuUEdYTjc5Mjd0?=
 =?utf-8?B?QmZ4bUZ4RHhtelE4YWd4TGJJdE1zaHhZM2FaeDAwaTdrQzRIa2RIWE5CMW9F?=
 =?utf-8?B?NEJJb0N1NVZqN0UzV0pieml4Nkh4YVdadmlBMytzRW9vY3V1ZEtpblkvTVBP?=
 =?utf-8?B?RE94RkJlK2RjamJwQi83WEpzalVoNzRldENRcXJsSEpjc0RCTVNTWnIrYUl0?=
 =?utf-8?B?UVFsaUQ2RVpBaGsvbXRIdVpieHFtTXpyaUVhcXY3WjZ6YVpLNHpybU9UZ0I5?=
 =?utf-8?B?ekgwTmE1QzQ2bkx1alBwbldFL25uQkFtbkE0K2h5K0ttUUdwWDRFRjhGeGJL?=
 =?utf-8?B?NXMzZ24vbzlTc2ZYMTZ3OGRvMlNMQ0FVb1pkc3BnVTQyaFNVdG5qM0NqMjdZ?=
 =?utf-8?B?OUFNN1hWVTYwL0wxZENqbldkb2lTWGhWWFJQZS9KZ05RNEEwTXM1cG9Pdkpl?=
 =?utf-8?B?dTJwa1FNbkJ4VXc5bGloOC9MekxMTWZKK0xnQlE2T3ZlMHNjbnRvR1p0TEcz?=
 =?utf-8?B?dTBoYWZkenRPbnpxeVNTYkRtVlcvY29Qcm02bTdWWEYrNkZjVTV2M1M4UjZs?=
 =?utf-8?B?TllhaXc1dkZkV29SVFpOMmNZVzFvVGhNWm4rRklkVkNEZEMxN1pwVXNEVWVF?=
 =?utf-8?B?UEE9PQ==?=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 98afe172-4c82-4b1a-f177-08d9f29e60dc
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Feb 2022 05:20:29.2701
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: gNOJsI3VRfKyTnDKOpp6Dj3B0To9vnhJLw3V++Iu1i0dEXRVjo7GoxCG0WfGPa1kJocao4nRVbFWH8rJDV3s6Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB0058
X-OriginatorOrg: intel.com

PiBGcm9tOiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+IFNlbnQ6IFR1ZXNkYXks
IEphbnVhcnkgMTEsIDIwMjIgMTI6MzYgQU0NCj4gDQo+IFdoZW4gYSBwYWdlIHRhYmxlIGVuZHMg
dXAgd2l0aCBubyBwcmVzZW50IGVudHJpZXMgbGVmdCwgaXQgY2FuIGJlDQo+IHJlcGxhY2VkIGJ5
IGEgbm9uLXByZXNlbnQgZW50cnkgYXQgdGhlIG5leHQgaGlnaGVyIGxldmVsLiBUaGUgcGFnZSB0
YWJsZQ0KPiBpdHNlbGYgY2FuIHRoZW4gYmUgc2NoZWR1bGVkIGZvciBmcmVlaW5nLg0KPiANCj4g
Tm90ZSB0aGF0IHdoaWxlIGl0cyBvdXRwdXQgaXNuJ3QgdXNlZCB0aGVyZSB5ZXQsDQo+IHB0X3Vw
ZGF0ZV9jb250aWdfbWFya2VycygpIHJpZ2h0IGF3YXkgbmVlZHMgdG8gYmUgY2FsbGVkIGluIGFs
bCBwbGFjZXMNCj4gd2hlcmUgZW50cmllcyBnZXQgdXBkYXRlZCwgbm90IGp1c3QgdGhlIG9uZSB3
aGVyZSBlbnRyaWVzIGdldCBjbGVhcmVkLg0KPiANCj4gTm90ZSBmdXJ0aGVyIHRoYXQgd2hpbGUg
cHRfdXBkYXRlX2NvbnRpZ19tYXJrZXJzKCkgdXBkYXRlcyBwZXJoYXBzDQo+IHNldmVyYWwgUFRF
cyB3aXRoaW4gdGhlIHRhYmxlLCBzaW5jZSB0aGVzZSBhcmUgY2hhbmdlcyB0byAiYXZhaWwiIGJp
dHMNCj4gb25seSBJIGRvIG5vdCB0aGluayB0aGF0IGNhY2hlIGZsdXNoaW5nIHdvdWxkIGJlIG5l
ZWRlZCBhZnRlcndhcmRzLiBTdWNoDQo+IGNhY2hlIGZsdXNoaW5nIChvZiBlbnRpcmUgcGFnZXMs
IHVubGVzcyBhZGRpbmcgeWV0IG1vcmUgbG9naWMgdG8gbWUgbW9yZQ0KPiBzZWxlY3RpdmUpIHdv
dWxkIGJlIHF1aXRlIG5vdGljYWJsZSBwZXJmb3JtYW5jZS13aXNlICh2ZXJ5IHByb21pbmVudA0K
PiBkdXJpbmcgRG9tMCBib290KS4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IEphbiBCZXVsaWNoIDxq
YmV1bGljaEBzdXNlLmNvbT4NCj4gLS0tDQo+IHYzOiBQcm9wZXJseSBib3VuZCBsb29wLiBSZS1i
YXNlIG92ZXIgY2hhbmdlcyBlYXJsaWVyIGluIHRoZSBzZXJpZXMuDQo+IHYyOiBOZXcuDQo+IC0t
LQ0KPiBUaGUgaGFuZyBkdXJpbmcgYm9vdCBvbiBteSBMYXRpdHVkZSBFNjQxMCAoc2VlIHRoZSBy
ZXNwZWN0aXZlIGNvZGUNCj4gY29tbWVudCkgd2FzIHByZXR0eSBjbG9zZSBhZnRlciBpb21tdV9l
bmFibGVfdHJhbnNsYXRpb24oKS4gTm8gZXJyb3JzLA0KPiBubyB3YXRjaGRvZyB3b3VsZCBraWNr
IGluLCBqdXN0IHNvbWV0aW1lcyB0aGUgZmlyc3QgZmV3IHBpeGVsIGxpbmVzIG9mDQo+IHRoZSBu
ZXh0IGxvZyBtZXNzYWdlJ3MgKFhFTikgcHJlZml4IHdvdWxkIGhhdmUgbWFkZSBpdCBvdXQgdG8g
dGhlIHNjcmVlbg0KPiAoYW5kIHRoZXJlJ3Mgbm8gc2VyaWFsIHRoZXJlKS4gSXQncyBiZWVuIGEg
bG90IG9mIGV4cGVyaW1lbnRpbmcgdW50aWwgSQ0KPiBmaWd1cmVkIHRoZSB3b3JrYXJvdW5kICh3
aGljaCBJIGNvbnNpZGVyIHVnbHksIGJ1dCBoYWxmd2F5IGFjY2VwdGFibGUpLg0KPiBJJ3ZlIGJl
ZW4gdHJ5aW5nIGhhcmQgdG8gbWFrZSBzdXJlIHRoZSB3b3JrYXJvdW5kIHdvdWxkbid0IGJlIG1h
c2tpbmcgYQ0KPiByZWFsIGlzc3VlLCB5ZXQgSSdtIHN0aWxsIHdhcnkgb2YgaXQgcG9zc2libHkg
ZG9pbmcgc28gLi4uIE15IGJlc3QgZ3Vlc3MNCj4gYXQgdGhpcyBwb2ludCBpcyB0aGF0IG9uIHRo
ZXNlIG9sZCBJT01NVXMgdGhlIGlnbm9yZWQgYml0cyA1Mi4uLjYxDQo+IGFyZW4ndCByZWFsbHkg
aWdub3JlZCBmb3IgcHJlc2VudCBlbnRyaWVzLCBidXQgYWxzbyBhcmVuJ3QgInJlc2VydmVkIg0K
PiBlbm91Z2ggdG8gdHJpZ2dlciBmYXVsdHMuIFRoaXMgZ3Vlc3MgaXMgZnJvbSBoYXZpbmcgdHJp
ZWQgdG8gc2V0IG90aGVyDQoNCklzIHRoaXMgbWFjaGluZSBhYmxlIHRvIGNhcHR1cmUgYW55IFZU
LWQgZmF1bHRzIGJlZm9yZT8gSWYgeWVzIG1heWJlDQp5b3Ugd2lsbCBvYnNlcnZlIG1vcmUgaW5m
b3JtYXRpb24gaWYgdHJ5aW5nIHRvIHR3ZWFrIHRob3NlIGJpdHMgYXQgYSBsYXRlcg0KdGltZSAo
aW5zdGVhZCBvZiB3aGVuIGlvbW11IGlzIGVuYWJsZWQpPw0KDQpUaGFua3MNCktldmluDQo=


From xen-devel-bounces@lists.xenproject.org Fri Feb 18 05:22:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 18 Feb 2022 05:22:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275091.470802 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKvjH-0005ao-AN; Fri, 18 Feb 2022 05:22:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275091.470802; Fri, 18 Feb 2022 05:22:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKvjH-0005ah-7H; Fri, 18 Feb 2022 05:22:51 +0000
Received: by outflank-mailman (input) for mailman id 275091;
 Fri, 18 Feb 2022 05:22:50 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qkm2=TB=intel.com=kevin.tian@srs-se1.protection.inumbo.net>)
 id 1nKvjG-0005aZ-EC
 for xen-devel@lists.xenproject.org; Fri, 18 Feb 2022 05:22:50 +0000
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ced1b8c2-907a-11ec-8eb8-a37418f5ba1a;
 Fri, 18 Feb 2022 06:22:48 +0100 (CET)
Received: from orsmga005.jf.intel.com ([10.7.209.41])
 by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 17 Feb 2022 21:22:46 -0800
Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81])
 by orsmga005.jf.intel.com with ESMTP; 17 Feb 2022 21:22:46 -0800
Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by
 fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.20; Thu, 17 Feb 2022 21:22:46 -0800
Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by
 fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.20; Thu, 17 Feb 2022 21:22:45 -0800
Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by
 fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.20 via Frontend Transport; Thu, 17 Feb 2022 21:22:45 -0800
Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.106)
 by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.1.2308.20; Thu, 17 Feb 2022 21:22:45 -0800
Received: from BN9PR11MB5276.namprd11.prod.outlook.com (2603:10b6:408:135::18)
 by BL0PR11MB3393.namprd11.prod.outlook.com (2603:10b6:208:62::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.12; Fri, 18 Feb
 2022 05:22:44 +0000
Received: from BN9PR11MB5276.namprd11.prod.outlook.com
 ([fe80::f514:7aae:315b:4d8d]) by BN9PR11MB5276.namprd11.prod.outlook.com
 ([fe80::f514:7aae:315b:4d8d%3]) with mapi id 15.20.4995.016; Fri, 18 Feb 2022
 05:22:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ced1b8c2-907a-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
  d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
  t=1645161768; x=1676697768;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-transfer-encoding:mime-version;
  bh=YoMAvBlYNKl7S5cif6ZmpyZbVrslo/8FlvOzVArIXRw=;
  b=K4/XZUHcHgAiNAoM5VBemcs0HfEiDKxONZqvhEtfw/RShTfqsMKMuDoQ
   L3/rnfUnnT+ZnsQPtn2NDqnptpIfKGb8z//K5bGHVWDGraRfc/kXABkR2
   6MSKMzm1RRghd6DMvO9vrcPqHehF8QgngOIt5/w1synsrenYttso7NNsx
   ucDc47Hs7sva+C5fS+YxsKqNVfgzXkjqelyzCO5hhfe8m0hQ9N4PSrtvZ
   70i7NtPQkx50Tc90HdKf9AZ6HScBFVsYtcBnydrS7q9jLLEvn3KGRCQH+
   4lez0kKtTcPqNZEqJdJFtKFOy3RGGsMadFDIjRVq0kbf4RqzNHxWBOk1o
   g==;
X-IronPort-AV: E=McAfee;i="6200,9189,10261"; a="248649582"
X-IronPort-AV: E=Sophos;i="5.88,377,1635231600"; 
   d="scan'208";a="248649582"
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.88,377,1635231600"; 
   d="scan'208";a="705231989"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cDA+dWJdB383jnQmqlgBxmiibIVx4vycxVwFRQZD/edwLCVdJTrwnM7S/uz6dUUsCGXQwbzRPQMARRyXTTAvxFc2WgXr88KbvxInR1GomJ5rgHk3C7hrUyausEZJ1IZv93+2Ftm6OQDPNs1IjVyp/qk/7dgQ7g1gcHely8XA1vTqZIC7wu7yQXNm4TLlvDhRTXYh+eW0cxQKyedoRindusZ//oSvC3slgz0pmQphlbL0sil265uond1/YdWjTEjp4Fmwlsu86ygdWr+CUjSZemP4/iLB4BFeyg2p4GALUnu06+PNh7evdmUDv/3pwQHqFh694etKx5hwPYOej8hm9w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=YoMAvBlYNKl7S5cif6ZmpyZbVrslo/8FlvOzVArIXRw=;
 b=RMFAL/g/G6fXKFdeo2+kdSKoMR65P2jCMNw3yXEI/ghApa+dW64tP5zaej5zogyTVoRrQSOTZSJmyW+X30ShBKG57pdDsZReKO1v6fBb0/17JcHBTk7ly3WoXvjVdSp6h5wpI2bcQlDM/BEbHpqhsswcEML98OC/wi6aB+V1WTMaJ+ULE4tzh1Rnr2sF5NoQEcLPoXvVG1n8b74i4A5myJfriA1OwfwpCXbvOvhCQ2Dxkagiimnr/1AgSF4SryRggC23KK5RkxBb7zM7Xr+GEhJ9H8t3sTQutPZGtBwQVcLMcxyd8ZpHoNpSLgNEBPryf2bCcZzBf6VsZs8eYkK3RQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
From: "Tian, Kevin" <kevin.tian@intel.com>
To: "Beulich, Jan" <JBeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: "Cooper, Andrew" <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>,
	=?utf-8?B?UGF1IE1vbm7DqSwgUm9nZXI=?= <roger.pau@citrix.com>
Subject: RE: [PATCH v3 22/23] VT-d: replace all-contiguous page tables by
 superpage mappings
Thread-Topic: [PATCH v3 22/23] VT-d: replace all-contiguous page tables by
 superpage mappings
Thread-Index: AQHYBkB8/KmB2TX4WUKM/AnbwIUwVKyZAm9Q
Date: Fri, 18 Feb 2022 05:22:43 +0000
Message-ID: <BN9PR11MB5276D586FA7B825D4A3009608C379@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <76cb9f26-e316-98a2-b1ba-e51e3d20f335@suse.com>
 <58e8871c-0d5e-ec32-74ac-9137e8f2ce41@suse.com>
In-Reply-To: <58e8871c-0d5e-ec32-74ac-9137e8f2ce41@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=intel.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 1bd5c84e-1a07-4574-07fa-08d9f29eb11a
x-ms-traffictypediagnostic: BL0PR11MB3393:EE_
x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr
x-microsoft-antispam-prvs: <BL0PR11MB339360C787D597876101965C8C379@BL0PR11MB3393.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:7691;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: p5c4HodQS1nJlOO7Usj4Y9A4Rek8lUz1KnH5WthCTnsy5ubUQP59Qj4OHAYvGMCcBZm3KDBQp7u9KRhgraIdcYhR75mJ/090y23Sy50GUuvn7KewBlQHQ7sx8Pa5SoS6VY1tKyPR8T4ix627Mnxkoy51ZFKj76QE/TB3CQxgPiLUwar1D80bVG0LonvkJggs/xT4cwTG2cMtWauFuTwX/3ffLoh7fUBI1QRDvzFDK6iVWLVRs8UgFZ7tNh6q1MryZL7HiVacc9Cr176LUX9Vzyk7EqjkvgESHDJRVTTLjma96xjnufha+1f1r27UvVcF7mDJPoodXovMe/vD32eXgeejAgpmvkEhZfkE/Yd33a9N6ZKORwJTeCWM2navtd87cwIUIv5MgFb2T69DzMXda0ITsbR4AxrAvGXRjW59/DNXJeVR9pY/UADc/wcFJ6phsNls35dlG92M+6qN4MY84AxQJT5DSRXYnHYm+HPQxSV06Xz44zrgyVOYif/09jilOP6I0fQFv4XwCUbA991YTu8T9gTQcc6+lvLLZbUYgaPczYeMqjIGWz+1R5uFt7o5g4vS3mv1z9qpbayVuLi7PChxD91qcFF6CYxeds7iA+nT3WDWP01vgDF7PeTXrFRvP7mp9YeLNomsepjVrQSxQYX24THOfNm3Rx7+7r4XmiyJFVdnsFcO+pgAvkE97smvGGtRTUCSeBO26vclyDBsbw==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5276.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(4326008)(2906002)(76116006)(5660300002)(64756008)(122000001)(26005)(38100700002)(54906003)(8676002)(83380400001)(186003)(66946007)(52536014)(66476007)(316002)(66556008)(110136005)(8936002)(66446008)(33656002)(71200400001)(7696005)(82960400001)(6506007)(38070700005)(55016003)(86362001)(508600001)(9686003);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Vy9uRGhlMWVhRklqckh5RTVXUTN2K2tkUUhTVmg4eVk4bWhLWTRrdXRQQ0cy?=
 =?utf-8?B?QzUzVllWWFByc0ROWXZjbG1OZlBnT3kyNE5CVitUSUNUMVJxOHJyR2JZN245?=
 =?utf-8?B?Vi9nZUYxa3hpR25GMG5GSDdudHdxU0JRcWM0MVBMMUZrd09kTnZsWHNsNXds?=
 =?utf-8?B?TUZ4elllSE1PcHFMdEh2ZzJhdklRYkNIa1pwQ2wwZ3NLREdFbU4wVmkrVWhj?=
 =?utf-8?B?NGxQMmpjNHlmb05QQWdNOFRENUk0NGQzaUJ5UnlWTXh3Q0c4bFVjNU5YanBO?=
 =?utf-8?B?QXpvVStYdGFkZkN5cUluYUtHZGl0RWhzV2xPUThtS2MyNmtuMW96RVpuNDhF?=
 =?utf-8?B?ZWRWemV4TVNtOXdENlIzM0J2QWNIR0RXTnVJOUVQdDBEek1SN2VIMExmdUhr?=
 =?utf-8?B?OFJLSW52Zk5XeGpub1BiYVA1clRuZ2M4VWVUWjQ1ZGtQVWI3eWFJdXQvTXdG?=
 =?utf-8?B?ME40TG54a01Ed1dvYWEzeVQ2Q3ZPZnpHWHBYSWNyaitlUjRxOSs3N3ozMVJY?=
 =?utf-8?B?Vng4WHNPMHRZMXhqeHJhYkVSdjZ0SmVoK0lLcHRRVmJPcFRPaFNDTU5NcGJr?=
 =?utf-8?B?YW55TEhtOWhDaXFNSXlvOFNBWXl4WUJjam1ja2IwWjJ2Zk44dHM5TVhSSXNy?=
 =?utf-8?B?dWM4T2Y5ZzkxS3M1dFFETzJaT25BaVAzb0VDSlhiMjYrZDJCMmxXSjdnY2Y2?=
 =?utf-8?B?L3FzNE5jT0ZZWW5ZWEFBQSs2V1ZralBPbm5vVDRJRENJK0NIU3lrb2VIRXF4?=
 =?utf-8?B?TkJoR0dleE8xdlptQnNib1g4MElQQ1Q4blFrY20vbHh6WXVhMjFyOTgxSnUw?=
 =?utf-8?B?VTR0ZjkzaXRMNis2K1dKZS9RNDJnajBpdVpNaEVCK2w0bTg3RXRlYzNZQkdz?=
 =?utf-8?B?Mkg0YUtuSFVlMDRJUlFBSEFJbzNmaXdTbUxpRk1iaUNueTRaV0FZeFk5WS8y?=
 =?utf-8?B?K05KYUdTQ3VzQ2xLTmw1UU03WjJBOGIveVNzMkQ3cGp5d0tGVTZnVUVLbVd0?=
 =?utf-8?B?SHJKdE9hUjYrN2x5c0FjWkQwOVlMcHhna2tJekpWSmhYOWJxcTZtU2UzU200?=
 =?utf-8?B?TUhuaDFldVNmS3VqTE9IRzR0Y1RtYm93cmx3dkN2c0czdDBJZ2JQb05DbGpp?=
 =?utf-8?B?T252MlZYUFpaV3ZxbzRmdFhyZkRWRUVrbFhvYmtYVFl3bURNdjFoOWJzOG1w?=
 =?utf-8?B?a3hRbU1GcGFURlg5TXNCT2dTalRxeXRlQXVDcjdQbkdsWEJsREFVSE1KZjd4?=
 =?utf-8?B?UXVpMUlFMHBONXFhclNLdWxoSUxzUmtJMCtRRm5WRnBsNlR2MnNrTEV5VVJN?=
 =?utf-8?B?UXBmL0M2cC9uUWs1K2pneUswa21CdmhHTTJHVXNOMjVzam9WdGV4MlhnZm5n?=
 =?utf-8?B?d3N1NWlqbS9LcHVUVmFvNzY5cTI3Yk1udThTbnB1djczVzJiVzBpdDVFU09x?=
 =?utf-8?B?N3Bua1dBeFVGQ0xTK3JuTmF4VFRBRzRZVzVkUDY5YXkxbG5vaktmemg2cDNy?=
 =?utf-8?B?Vk9rQXVnRWpqNS84MllpRHJkZmtybWJsck5oZ0FEZmJDV2pld2cyS1BOa0Rz?=
 =?utf-8?B?cExBaXA0NHB4cFBwMGNSYVEzRHRveWNRTG53K3lzOUcyU01ocE5oYlpIc1ps?=
 =?utf-8?B?ZXR0K3E1ZTgrU2RlNUJKck5rOGU2bTlsL3VNdzFPTHo5ejN6MTkwbG1taE5m?=
 =?utf-8?B?b0M4ZllkOGU0WHhkTldpbEZQRXFZQzgxdHpMcGp3dVRIR2RBR0kvcUszMno5?=
 =?utf-8?B?b1d3K2s2ajR5VXByTFptc0lOY3dhZGlpRUhEei9IOHozSjFIN2hRdmUxUUc0?=
 =?utf-8?B?Y25BYzJEanJGME42K3kxTSt4eFR2dFB5b1JCbkZOOTROb0dmYWxYYzUxSUli?=
 =?utf-8?B?NmpNbUFpUEc2YzNWdTh4Wk5aQjMxMUhqajRSSjhjRGd6ZDI1SEtVdXFxdnR3?=
 =?utf-8?B?a2cyVXBQT0FDMGpiY0xHbHVXV2R1ckVSYmQ3a0ZsZzlMWEJtbTMxRVV3Z3NZ?=
 =?utf-8?B?am50dWNHZTV5UXdPbW9lTU56S2ErREtuMmZoNHNqV1F3dGRpeXdQKzF5QXI4?=
 =?utf-8?B?R0hjdWw0N2Q1WlJVYVVRSzd0TUhXRDFBN2JjTzFpd2pZcXo2TnVIUEFiTU9q?=
 =?utf-8?B?OXZHdEdMc2xUTFptMkJGaC96S2ZrUHJ0ZmFCNmFBRlc3cis4c2d4aVcyRDBU?=
 =?utf-8?B?Q1E9PQ==?=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1bd5c84e-1a07-4574-07fa-08d9f29eb11a
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Feb 2022 05:22:43.8726
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: rfsCgjQOKAzuEVQleVLLdB0buDsynH5efE4qRQKe2X3tA/EbbUVYhzmJmSPvMRLC9EQBUgY2G38QSUhEHVYZuQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR11MB3393
X-OriginatorOrg: intel.com

PiBGcm9tOiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+IFNlbnQ6IFR1ZXNkYXks
IEphbnVhcnkgMTEsIDIwMjIgMTI6MzggQU0NCj4gDQo+IFdoZW4gYSBwYWdlIHRhYmxlIGVuZHMg
dXAgd2l0aCBhbGwgY29udGlndW91cyBlbnRyaWVzIChpbmNsdWRpbmcgYWxsDQo+IGlkZW50aWNh
bCBhdHRyaWJ1dGVzKSwgaXQgY2FuIGJlIHJlcGxhY2VkIGJ5IGEgc3VwZXJwYWdlIGVudHJ5IGF0
IHRoZQ0KPiBuZXh0IGhpZ2hlciBsZXZlbC4gVGhlIHBhZ2UgdGFibGUgaXRzZWxmIGNhbiB0aGVu
IGJlIHNjaGVkdWxlZCBmb3INCj4gZnJlZWluZy4NCj4gDQo+IFRoZSBhZGp1c3RtZW50IHRvIExF
VkVMX01BU0sgaXMgbWVyZWx5IHRvIGF2b2lkIGxlYXZpbmcgYSBsYXRlbnQgdHJhcA0KPiBmb3Ig
d2hlbmV2ZXIgd2UgKGFuZCBvYnZpb3VzbHkgaGFyZHdhcmUpIHN0YXJ0IHN1cHBvcnRpbmcgNTEy
RyBtYXBwaW5ncy4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBz
dXNlLmNvbT4NCj4gLS0tDQo+IFVubGlrZSB0aGUgZnJlZWluZyBvZiBhbGwtZW1wdHkgcGFnZSB0
YWJsZXMsIHRoaXMgY2F1c2VzIHF1aXRlIGEgYml0IG9mDQo+IGJhY2sgYW5kIGZvcnRoIGZvciBQ
ViBkb21haW5zLCBkdWUgdG8gdGhlaXIgbWFwcGluZy91bm1hcHBpbmcgb2YgcGFnZXMNCj4gd2hl
biB0aGV5IGdldCBjb252ZXJ0ZWQgdG8vZnJvbSBiZWluZyBwYWdlIHRhYmxlcy4gSXQgbWF5IHRo
ZXJlZm9yZSBiZQ0KPiB3b3J0aCBjb25zaWRlcmluZyB0byBkZWxheSByZS1jb2FsZXNjaW5nIGEg
bGl0dGxlLCB0byBhdm9pZCBkb2luZyBzbw0KPiB3aGVuIHRoZSBzdXBlcnBhZ2Ugd291bGQgb3Ro
ZXJ3aXNlIGdldCBzcGxpdCBhZ2FpbiBwcmV0dHkgc29vbi4gQnV0IEkNCj4gdGhpbmsgdGhpcyB3
b3VsZCBiZXR0ZXIgYmUgdGhlIHN1YmplY3Qgb2YgYSBzZXBhcmF0ZSBjaGFuZ2UgYW55d2F5Lg0K
PiANCg0KQWdyZWUuIHRodXM6DQoNCglSZXZpZXdlZC1ieTogS2V2aW4gVGlhbiA8a2V2aW4udGlh
bkBpbnRlbC5jb20+DQoNCj4gT2YgY291cnNlIHRoaXMgY291bGQgYWxzbyBiZSBoZWxwZWQgYnkg
bW9yZSAiYXdhcmUiIGtlcm5lbCBzaWRlDQo+IGJlaGF2aW9yOiBUaGV5IGNvdWxkIGF2b2lkIGlt
bWVkaWF0ZWx5IG1hcHBpbmcgZnJlZWQgcGFnZSB0YWJsZXMNCj4gd3JpdGFibGUgYWdhaW4sIGlu
IGFudGljaXBhdGlvbiBvZiByZS11c2luZyB0aGF0IHNhbWUgcGFnZSBmb3IgYW5vdGhlcg0KPiBw
YWdlIHRhYmxlIGVsc2V3aGVyZS4NCj4gLS0tDQo+IHYzOiBOZXcuDQo+IA0KPiAtLS0gYS94ZW4v
ZHJpdmVycy9wYXNzdGhyb3VnaC92dGQvaW9tbXUuYw0KPiArKysgYi94ZW4vZHJpdmVycy9wYXNz
dGhyb3VnaC92dGQvaW9tbXUuYw0KPiBAQCAtMjA3MSwxNCArMjA3MSwzNSBAQCBzdGF0aWMgaW50
IF9fbXVzdF9jaGVjayBpbnRlbF9pb21tdV9tYXBfDQo+ICAgICAgICogV2hpbGUgdGhlIChhYil1
c2Ugb2YgUFRFX2tpbmRfdGFibGUgaGVyZSBhbGxvd3MgdG8gc2F2ZSBzb21lIHdvcmsgaW4NCj4g
ICAgICAgKiB0aGUgZnVuY3Rpb24sIHRoZSBtYWluIG1vdGl2YXRpb24gZm9yIGl0IGlzIHRoYXQg
aXQgYXZvaWRzIGEgc28gZmFyDQo+ICAgICAgICogdW5leHBsYWluZWQgaGFuZyBkdXJpbmcgYm9v
dCAod2hpbGUgcHJlcGFyaW5nIERvbTApIG9uIGEgV2VzdG1lcmUNCj4gLSAgICAgKiBiYXNlZCBs
YXB0b3AuDQo+ICsgICAgICogYmFzZWQgbGFwdG9wLiAgVGhpcyBhbHNvIGhhcyB0aGUgaW50ZW5k
ZWQgZWZmZWN0IG9mIHRlcm1pbmF0aW5nIHRoZQ0KPiArICAgICAqIGxvb3Agd2hlbiBzdXBlciBw
YWdlcyBhcmVuJ3Qgc3VwcG9ydGVkIGFueW1vcmUgYXQgdGhlIG5leHQgbGV2ZWwuDQo+ICAgICAg
ICovDQo+IC0gICAgcHRfdXBkYXRlX2NvbnRpZ19tYXJrZXJzKCZwYWdlLT52YWwsDQo+IC0gICAg
ICAgICAgICAgICAgICAgICAgICAgICAgIGFkZHJlc3NfbGV2ZWxfb2Zmc2V0KGRmbl90b19kYWRk
cihkZm4pLCBsZXZlbCksDQo+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgIGxldmVsLA0K
PiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoaGQtPnBsYXRmb3JtX29wcy0+cGFnZV9z
aXplcyAmDQo+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoMVVMIDw8IGxldmVsX3Rv
X29mZnNldF9iaXRzKGxldmVsICsgMSkpDQo+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICA/IFBURV9raW5kX2xlYWYgOiBQVEVfa2luZF90YWJsZSkpOw0KPiArICAgIHdoaWxlICggcHRf
dXBkYXRlX2NvbnRpZ19tYXJrZXJzKCZwYWdlLT52YWwsDQo+ICsgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgYWRkcmVzc19sZXZlbF9vZmZzZXQoZGZuX3RvX2RhZGRyKGRmbiks
IGxldmVsKSwNCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBsZXZlbCwN
Cj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoaGQtPnBsYXRmb3JtX29w
cy0+cGFnZV9zaXplcyAmDQo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICgxVUwgPDwgbGV2ZWxfdG9fb2Zmc2V0X2JpdHMobGV2ZWwgKyAxKSkNCj4gKyAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgID8gUFRFX2tpbmRfbGVhZiA6IFBURV9raW5kX3Rh
YmxlKSkgKQ0KPiArICAgIHsNCj4gKyAgICAgICAgc3RydWN0IHBhZ2VfaW5mbyAqcGcgPSBtYWRk
cl90b19wYWdlKHBnX21hZGRyKTsNCj4gKw0KPiArICAgICAgICB1bm1hcF92dGRfZG9tYWluX3Bh
Z2UocGFnZSk7DQo+ICsNCj4gKyAgICAgICAgbmV3LnZhbCAmPSB+KExFVkVMX01BU0sgPDwgbGV2
ZWxfdG9fb2Zmc2V0X2JpdHMobGV2ZWwpKTsNCj4gKyAgICAgICAgZG1hX3NldF9wdGVfc3VwZXJw
YWdlKG5ldyk7DQo+ICsNCj4gKyAgICAgICAgcGdfbWFkZHIgPSBhZGRyX3RvX2RtYV9wYWdlX21h
ZGRyKGQsIGRmbl90b19kYWRkcihkZm4pLCArK2xldmVsLA0KPiArICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgZmx1c2hfZmxhZ3MsIGZhbHNlKTsNCj4gKyAgICAgICAg
QlVHX09OKHBnX21hZGRyIDwgUEFHRV9TSVpFKTsNCj4gKw0KPiArICAgICAgICBwYWdlID0gbWFw
X3Z0ZF9kb21haW5fcGFnZShwZ19tYWRkcik7DQo+ICsgICAgICAgIHB0ZSA9ICZwYWdlW2FkZHJl
c3NfbGV2ZWxfb2Zmc2V0KGRmbl90b19kYWRkcihkZm4pLCBsZXZlbCldOw0KPiArICAgICAgICAq
cHRlID0gbmV3Ow0KPiArICAgICAgICBpb21tdV9zeW5jX2NhY2hlKHB0ZSwgc2l6ZW9mKCpwdGUp
KTsNCj4gKw0KPiArICAgICAgICAqZmx1c2hfZmxhZ3MgfD0gSU9NTVVfRkxVU0hGX21vZGlmaWVk
IHwgSU9NTVVfRkxVU0hGX2FsbDsNCj4gKyAgICAgICAgaW9tbXVfcXVldWVfZnJlZV9wZ3RhYmxl
KGQsIHBnKTsNCj4gKyAgICB9DQo+IA0KPiAgICAgIHNwaW5fdW5sb2NrKCZoZC0+YXJjaC5tYXBw
aW5nX2xvY2spOw0KPiAgICAgIHVubWFwX3Z0ZF9kb21haW5fcGFnZShwYWdlKTsNCj4gLS0tIGEv
eGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL2lvbW11LmgNCj4gKysrIGIveGVuL2RyaXZlcnMv
cGFzc3Rocm91Z2gvdnRkL2lvbW11LmgNCj4gQEAgLTIyOSw3ICsyMjksNyBAQCBzdHJ1Y3QgY29u
dGV4dF9lbnRyeSB7DQo+IA0KPiAgLyogcGFnZSB0YWJsZSBoYW5kbGluZyAqLw0KPiAgI2RlZmlu
ZSBMRVZFTF9TVFJJREUgICAgICAgKDkpDQo+IC0jZGVmaW5lIExFVkVMX01BU0sgICAgICAgICAo
KDEgPDwgTEVWRUxfU1RSSURFKSAtIDEpDQo+ICsjZGVmaW5lIExFVkVMX01BU0sgICAgICAgICAo
UFRFX05VTSAtIDFVTCkNCj4gICNkZWZpbmUgUFRFX05VTSAgICAgICAgICAgICgxIDw8IExFVkVM
X1NUUklERSkNCj4gICNkZWZpbmUgbGV2ZWxfdG9fYWdhdyh2YWwpICgodmFsKSAtIDIpDQo+ICAj
ZGVmaW5lIGFnYXdfdG9fbGV2ZWwodmFsKSAoKHZhbCkgKyAyKQ0KDQo=


From xen-devel-bounces@lists.xenproject.org Fri Feb 18 05:23:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 18 Feb 2022 05:23:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275099.470813 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKvju-0006Cf-OE; Fri, 18 Feb 2022 05:23:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275099.470813; Fri, 18 Feb 2022 05:23:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKvju-0006CY-Ky; Fri, 18 Feb 2022 05:23:30 +0000
Received: by outflank-mailman (input) for mailman id 275099;
 Fri, 18 Feb 2022 05:23:28 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qkm2=TB=intel.com=kevin.tian@srs-se1.protection.inumbo.net>)
 id 1nKvjs-000639-K0
 for xen-devel@lists.xenproject.org; Fri, 18 Feb 2022 05:23:28 +0000
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e46a225d-907a-11ec-8723-dd0c611c5f35;
 Fri, 18 Feb 2022 06:23:25 +0100 (CET)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 17 Feb 2022 21:23:23 -0800
Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17])
 by orsmga001.jf.intel.com with ESMTP; 17 Feb 2022 21:23:23 -0800
Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by
 ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.20; Thu, 17 Feb 2022 21:23:22 -0800
Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by
 orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.20 via Frontend Transport; Thu, 17 Feb 2022 21:23:22 -0800
Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.109)
 by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.1.2308.20; Thu, 17 Feb 2022 21:23:22 -0800
Received: from BN9PR11MB5276.namprd11.prod.outlook.com (2603:10b6:408:135::18)
 by BL0PR11MB3393.namprd11.prod.outlook.com (2603:10b6:208:62::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.12; Fri, 18 Feb
 2022 05:23:20 +0000
Received: from BN9PR11MB5276.namprd11.prod.outlook.com
 ([fe80::f514:7aae:315b:4d8d]) by BN9PR11MB5276.namprd11.prod.outlook.com
 ([fe80::f514:7aae:315b:4d8d%3]) with mapi id 15.20.4995.016; Fri, 18 Feb 2022
 05:23:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e46a225d-907a-11ec-8723-dd0c611c5f35
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
  d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
  t=1645161805; x=1676697805;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-transfer-encoding:mime-version;
  bh=EbWANJsRUZKLUt4JPLl6gZ4pr9WFC3q+JjvG5T4qSp4=;
  b=GzY0T+JzZQrzIfTf/7SlBGQ4M/347YCe6699vOlvLj+EmAEw64lWw3AR
   1DbMktSgXldxzmm0Z2Jf6BQDApAf6jJW2D38SpvLks2GGaCrX3znuBDMl
   2Vm4EWc5HbVg12Q2pQUDNQvos9FiTabJPG7/jZGJbT45ljjjmR3/8UHQA
   ayZbdQmth920/iXYUjqe/sy6o/S+5vd7YOGPOcACe4AvLHZLaQfWK+96A
   Khkvmpgg+judm9h3USDmc2mK1oPyCFUfytd9zqMzpnhyO5YyOyTiyIFcw
   Ql5vLLgkIXfdhDoBM9C9tYZojgVgp7gTnmKiJU9ZmgflNvdw7UXlTuD+c
   g==;
X-IronPort-AV: E=McAfee;i="6200,9189,10261"; a="311796813"
X-IronPort-AV: E=Sophos;i="5.88,377,1635231600"; 
   d="scan'208";a="311796813"
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.88,377,1635231600"; 
   d="scan'208";a="572170395"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=klsHyxy/ZHkhJQJCFMkK5yQt/Ugsqyb9YngqFE/kSoZso+AHvas1TD9n1TrUGBnxWjRZ1w66m/sEv5s/xDW+bAZGEwonyni+xjaxtg+Ufuw/CHfikuRMTNnnfH0sXjQn9EVRgeKM2Tu/E88RF8O3tlsQ5KKdcYqUz9gvKg57bpUJ0y+DrmDIjqZ0C9tGfR5a2tSDtD33YiUrskfUoFDree+gX/1RiJ40TMqctZj75b7CwkxbI/pNCKBEBHuzNzQ2H6IENAYZXQ/+CP7oK6n2X/IhYQiSO8VTs6TYLFLzh5MrtK+1ZGXEajMcBui/o5CvTAe+2rmizTKfySE7byo6UA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=EbWANJsRUZKLUt4JPLl6gZ4pr9WFC3q+JjvG5T4qSp4=;
 b=Z8q/0NvD1pfayOeYQ92if7xoc1QgzyAQs5TJb8CkET0u28bB1hsx4lV+beRUKIGWCVNGgbZs+3RIe4veGFgkF73mPhD6eIpR27IzzeOFczN75KVSxQkLccCcPYml2A2Uza8DrImWKcxMWguewbg3gOVZ65D25ePtpp3X2g128WVoDwD+prqC7nqe9Vy/YcGofQKBRE1xh0TIG07p2fBK58AKJP6UBxWjyWj19YIVULJFxDemWmXKnkXb/SZakw/NvDUsv8v1FvLxMUy8aJlT1Rho2WtLGs0C/0QKzS1NB+xvpZnG0TKiPz7UogSeo7RpLd4Nd37SBwhM5y+4t4PVOg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
From: "Tian, Kevin" <kevin.tian@intel.com>
To: "Beulich, Jan" <JBeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: "Cooper, Andrew" <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>,
	=?utf-8?B?UGF1IE1vbm7DqSwgUm9nZXI=?= <roger.pau@citrix.com>
Subject: RE: [PATCH v3 23/23] IOMMU/x86: add perf counters for page table
 splitting / coalescing
Thread-Topic: [PATCH v3 23/23] IOMMU/x86: add perf counters for page table
 splitting / coalescing
Thread-Index: AQHYBkCIiD6zzqjEpESy/R2RlVmrhayZAq9g
Date: Fri, 18 Feb 2022 05:23:20 +0000
Message-ID: <BN9PR11MB52767CD34997901F4455BD168C379@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <76cb9f26-e316-98a2-b1ba-e51e3d20f335@suse.com>
 <b5d5d7b1-7b53-5c74-1988-3baec74a9f45@suse.com>
In-Reply-To: <b5d5d7b1-7b53-5c74-1988-3baec74a9f45@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=intel.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 86909568-9e40-44a1-3461-08d9f29ec6d3
x-ms-traffictypediagnostic: BL0PR11MB3393:EE_
x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr
x-microsoft-antispam-prvs: <BL0PR11MB3393ABCB599BF9549D8C6E418C379@BL0PR11MB3393.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:663;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: xgUTq2oB1+JV0x/gq9Pw9xHhT+eWq4cOwAf5aXiGb3g1OtH3Ky5BrbFOwAlgql14C3xUz9CR4o1ydyFkrtH1yS0ey2HdLkj4+KKpSgvmRMGwZpz5v37hr/2S1BELBvCFOLz2RMzYFsTChzU07+fJTNKJVobLD6ms+fvPAtDZETEuTTiol/L0/p2LvC6+rREvMi1rLCgU44nGmKl8S2bPlvZLati7sJXUfdqV/vn/w0/u8oAKDrvW42Xs+bsH5F2TU9+A2mTRyGZ+hsZZYJNGS/6MRSv9cCnYU9z2WpdcCwVlQI9nS8kEY3falYMvLNCp/P1mXzP9ShDfPjk9ZpEEWTBaB660PAQr60XkDIcYinTi5Ui7TQIOR5rT2bBsNgpz4DsB3TTGRCDDcV1UGIAzTW7+EJOMvGCYkAg81eY/R+zchvSGxN4mlEU4iXbevMbI8uZHhCzrSTU4Hwsi9RTQlG0PtZQH05sdtLcpcmJUWwhYEx28C4VPrDWhy0xR6qNGvGnFBH/a6YmY1GMSgCoBjRy70G9QvZbEEd6/VeiFLUwV+xtbRoiA6HT/kWOi+Tniae9o7YF8btmEbG5kmzSB6KsxfX8AlUEJq0+EC5sGU+837SE9iCoocGDQ9+AdjquCcmc2JlsZuwF+bsbMqXPyJt7qE+pXMRm+PTguDtqQXtGLq6jEpE5BM4q19cSrwe1ZAGOc16oGGG6UzR/bjsEhIg==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5276.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(4326008)(2906002)(76116006)(5660300002)(64756008)(122000001)(26005)(38100700002)(54906003)(8676002)(83380400001)(186003)(66946007)(52536014)(66476007)(316002)(66556008)(110136005)(8936002)(66446008)(33656002)(71200400001)(7696005)(82960400001)(6506007)(38070700005)(55016003)(86362001)(508600001)(9686003);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?ZnRFU1dIMmcwWmlUb1FtQTByT2RXZkdTazM2azdTT0M3aVEwYTJZb0poQmc4?=
 =?utf-8?B?YWJPSUwwYU10c2U5dWhmWDZ1aytpN00va2VyK2lKblh4MzV6Wm15WGFFMDdv?=
 =?utf-8?B?Mk01dXZUa000QnN3SDBZdGpTNUNRUmVWYlg5UlpoMDNVTSt2U21jUGQ0STJi?=
 =?utf-8?B?UlF3SWRNdGdOU1ZFRkwxREZzTi8wYndjS2d2Vk5ybDlDNGplK1B6R0ZKODZr?=
 =?utf-8?B?T3dKOVhXY3NtS2lFR2EydUtlRUVBWVVTbHZybVN2MUN5MU05QTA5TUZOQkg2?=
 =?utf-8?B?c2hRcnVobS9lbEpBVkdDRHlQVDE3bktLbDFqZGsxeUJQU2tZT3dUMnpjWWJT?=
 =?utf-8?B?OFVqUW0zb0dWZWRxRWF3VUZQMTRVbjR4Ty9MQ2JacUJvQ1NUazdmL0pzQ2JS?=
 =?utf-8?B?VHN4WXg0d1dKMThPOUN2dHZDQndZcThreXhVK0V3dHJrenlXSFZSSFZjRlRD?=
 =?utf-8?B?YkRWdk8zYWNOeUhvdFFOcXprMGpGZGFGT1B1Qno1czFhZHF5R1dzclhxVm5W?=
 =?utf-8?B?eUs3VUc3SEZ4Y3RJRGp1WDRBdWgxZ1lLNnVnbUY3ZVYrOFlXSzdUcFhRc2Jy?=
 =?utf-8?B?NHlKTG5kajRkT0o4TUxLNldRd3RWeWFzbzFiUC9wOE5MSStqWjQ0Z0M5UU5B?=
 =?utf-8?B?NUE0QWtQOXRlaWR4NjhtME5yR1NxUWpKb2pkRUgrTTU1RmJHeUFOT3BEMVh4?=
 =?utf-8?B?NlptUVpBMnJnU2h1RWowaGRiRW9xak9ka2hCVVpsNDlsYURWMXUyVmNFenRH?=
 =?utf-8?B?RkdKY1V6T21VY2NtWnZMR3hVWmhXQllKVEhzYzJWMlBZZGJvMjZ6VGJjbEl5?=
 =?utf-8?B?RGJCbGdpb0NRYldGSHRnSjBTazE4cEhUM3NGYjVXdmJyUy9odWE1UFRHTmsy?=
 =?utf-8?B?RkNUa3lySDJXYUNIOFpkNUZhNHZmTEszTWx5M01NQm1YQ042dDBubFJRR0VB?=
 =?utf-8?B?L0RPMkY3VFdQNTlSdDlFeDBrcUhxRHF5V24rUktSRFhtbzdLY3dLZGtPcWNm?=
 =?utf-8?B?SSt2YnZZemVCNFJjUkRQU2FKVUROeGNBUkgxUEFYR2tJMkFNOGUwT0xVeEV5?=
 =?utf-8?B?TXNCRmYreW4zWmVHR3QxMTNiUkNFdnpkWXFVeHBuSGltNmJwUXRoWjJtU3RN?=
 =?utf-8?B?NUJGSTZvS3EyKzlIQ295TFBhY1hnWVR4OTFPdnpwSmM2SllWNWoxd2dUNkRz?=
 =?utf-8?B?dXNLVHVDRjZVQU4rUEZKU2hVd25kblljcm9CZ2U4SkhnWHpPOTVIV3BiV21Z?=
 =?utf-8?B?Wkc2NXdWeE1wZERTc25JeUhnNjlwSGlGbWduWFVnK1E5aXVOZG5waTJhOGdl?=
 =?utf-8?B?NGd4SUFZTHREbi8rbVVvSXZMcDM2K3dRUVNCMDBuVEM2YzhXWUVaZEFGTDFp?=
 =?utf-8?B?MG9memVGdGtRckNselBOeC9FempXSC92USsxeG9LWmNLK3FGOTd1WG94QkxQ?=
 =?utf-8?B?eTBrTVlFVGhaaTNjbXZNd1VyRjR0ZFBaUU1GNGpwaUVCOGN1Q1B2RUZzVW4w?=
 =?utf-8?B?dkdDSE5maDNpUURic0t1bEFZWFNzZE5sVVorZGZDV3hXZUowWHdkZTZ0cWxj?=
 =?utf-8?B?SXRQY29hMTlGai82Y0drb1JrRzJHcUxLMlJrTzdubTBPSlhSN1ROV0MwcDdE?=
 =?utf-8?B?VjZoZTFUOElYOFhYK3FuaEtpZDd6MHNkODVOYmw5ckJoa3pCUjBRZVFNSnZr?=
 =?utf-8?B?UndQb0lqMDlpVEVhNi94eFJlbC9hZFJsSVRPd0VLYWVVK0c4ZmQwT1ovb3Bz?=
 =?utf-8?B?eFZXeEVxZWtPblJKYjhXdGhTMndUdE9iRkFkVDNLYzM4R2JtemFqZXhLWUh1?=
 =?utf-8?B?VXQ1SWZzSWtRdWpJMXkxUjZUNnIzOGpab0ZXQnp6Y3JydnRkNGN0NW9SY05R?=
 =?utf-8?B?Z0s0aTRNUXhqbk8ycGFGT0JneE5sNUQ5OHJERE0vM2EvUXZTMXdDcDVXRW45?=
 =?utf-8?B?ZktMWkRjeGYxbGt2b3NXSjNWcEhlYWJSbEVoL25hY0M0d0E4WTNVZzBnSnlJ?=
 =?utf-8?B?TngwWlpKMlJIY2t2UFQ1UCtWbUNBdTIzNkFTU3hGT1FnSVl2bm5tL1JLSHlx?=
 =?utf-8?B?S0Vac01kKzhhOWpsdjlWUlhTdkVyOWh1N3cvU1RvdWwyenQzUGRKSmM0OTRI?=
 =?utf-8?B?ck1yck1HWnp3aU5Rd05TVGdEN1J3dFJPQmF3SFlZSG40bEhmb090cUVHdlVU?=
 =?utf-8?B?Tmc9PQ==?=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 86909568-9e40-44a1-3461-08d9f29ec6d3
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Feb 2022 05:23:20.3015
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: CGtUeAKF5NRfWXNa77yV6cfraRzMXxUiXrAW0zzzB0zoCPLcpO/gc/XMNrSXEBMpBsovALnEdCZw8dOqQHeZkA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR11MB3393
X-OriginatorOrg: intel.com

PiBGcm9tOiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+IFNlbnQ6IFR1ZXNkYXks
IEphbnVhcnkgMTEsIDIwMjIgMTI6MzkgQU0NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IEphbiBCZXVs
aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCg0KUmV2aWV3ZWQtYnk6IEtldmluIHRpYW4gPGtldmlu
LnRpYW5AaW50ZWwuY29tPg0KDQo+IC0tLQ0KPiB2MzogTmV3Lg0KPiANCj4gLS0tIGEveGVuL2Ry
aXZlcnMvcGFzc3Rocm91Z2gvYW1kL2lvbW11X21hcC5jDQo+ICsrKyBiL3hlbi9kcml2ZXJzL3Bh
c3N0aHJvdWdoL2FtZC9pb21tdV9tYXAuYw0KPiBAQCAtMjgzLDYgKzI4Myw4IEBAIHN0YXRpYyBp
bnQgaW9tbXVfcGRlX2Zyb21fZGZuKHN0cnVjdCBkb20NCj4gICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICBsZXZlbCwgUFRFX2tpbmRfdGFibGUpOw0KPiANCj4gICAgICAgICAg
ICAgICpmbHVzaF9mbGFncyB8PSBJT01NVV9GTFVTSEZfbW9kaWZpZWQ7DQo+ICsNCj4gKyAgICAg
ICAgICAgIHBlcmZjX2luY3IoaW9tbXVfcHRfc2hhdHRlcnMpOw0KPiAgICAgICAgICB9DQo+IA0K
PiAgICAgICAgICAvKiBJbnN0YWxsIGxvd2VyIGxldmVsIHBhZ2UgdGFibGUgZm9yIG5vbi1wcmVz
ZW50IGVudHJpZXMgKi8NCj4gQEAgLTQxMSw2ICs0MTMsNyBAQCBpbnQgYW1kX2lvbW11X21hcF9w
YWdlKHN0cnVjdCBkb21haW4gKmQsDQo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBm
bGFncyAmIElPTU1VRl9yZWFkYWJsZSwgJmNvbnRpZyk7DQo+ICAgICAgICAgICpmbHVzaF9mbGFn
cyB8PSBJT01NVV9GTFVTSEZfbW9kaWZpZWQgfCBJT01NVV9GTFVTSEZfYWxsOw0KPiAgICAgICAg
ICBpb21tdV9xdWV1ZV9mcmVlX3BndGFibGUoZCwgcGcpOw0KPiArICAgICAgICBwZXJmY19pbmNy
KGlvbW11X3B0X2NvYWxlc2Nlcyk7DQo+ICAgICAgfQ0KPiANCj4gICAgICBzcGluX3VubG9jaygm
aGQtPmFyY2gubWFwcGluZ19sb2NrKTsNCj4gQEAgLTQ3MSw2ICs0NzQsNyBAQCBpbnQgYW1kX2lv
bW11X3VubWFwX3BhZ2Uoc3RydWN0IGRvbWFpbiAqDQo+ICAgICAgICAgICAgICBjbGVhcl9pb21t
dV9wdGVfcHJlc2VudChwdF9tZm4sIGRmbl94KGRmbiksIGxldmVsLCAmZnJlZSk7DQo+ICAgICAg
ICAgICAgICAqZmx1c2hfZmxhZ3MgfD0gSU9NTVVfRkxVU0hGX2FsbDsNCj4gICAgICAgICAgICAg
IGlvbW11X3F1ZXVlX2ZyZWVfcGd0YWJsZShkLCBwZyk7DQo+ICsgICAgICAgICAgICBwZXJmY19p
bmNyKGlvbW11X3B0X2NvYWxlc2Nlcyk7DQo+ICAgICAgICAgIH0NCj4gICAgICB9DQo+IA0KPiAt
LS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC92dGQvaW9tbXUuYw0KPiArKysgYi94ZW4vZHJp
dmVycy9wYXNzdGhyb3VnaC92dGQvaW9tbXUuYw0KPiBAQCAtNDUxLDYgKzQ1MSw4IEBAIHN0YXRp
YyB1aW50NjRfdCBhZGRyX3RvX2RtYV9wYWdlX21hZGRyKHMNCj4gDQo+ICAgICAgICAgICAgICAg
ICAgaWYgKCBmbHVzaF9mbGFncyApDQo+ICAgICAgICAgICAgICAgICAgICAgICpmbHVzaF9mbGFn
cyB8PSBJT01NVV9GTFVTSEZfbW9kaWZpZWQ7DQo+ICsNCj4gKyAgICAgICAgICAgICAgICBwZXJm
Y19pbmNyKGlvbW11X3B0X3NoYXR0ZXJzKTsNCj4gICAgICAgICAgICAgIH0NCj4gDQo+ICAgICAg
ICAgICAgICB3cml0ZV9hdG9taWMoJnB0ZS0+dmFsLCBuZXdfcHRlLnZhbCk7DQo+IEBAIC05MDcs
NiArOTA5LDcgQEAgc3RhdGljIGludCBkbWFfcHRlX2NsZWFyX29uZShzdHJ1Y3QgZG9tYQ0KPiAN
Cj4gICAgICAgICAgKmZsdXNoX2ZsYWdzIHw9IElPTU1VX0ZMVVNIRl9hbGw7DQo+ICAgICAgICAg
IGlvbW11X3F1ZXVlX2ZyZWVfcGd0YWJsZShkb21haW4sIHBnKTsNCj4gKyAgICAgICAgcGVyZmNf
aW5jcihpb21tdV9wdF9jb2FsZXNjZXMpOw0KPiAgICAgIH0NCj4gDQo+ICAgICAgc3Bpbl91bmxv
Y2soJmhkLT5hcmNoLm1hcHBpbmdfbG9jayk7DQo+IEBAIC0yMDk5LDYgKzIxMDIsNyBAQCBzdGF0
aWMgaW50IF9fbXVzdF9jaGVjayBpbnRlbF9pb21tdV9tYXBfDQo+IA0KPiAgICAgICAgICAqZmx1
c2hfZmxhZ3MgfD0gSU9NTVVfRkxVU0hGX21vZGlmaWVkIHwgSU9NTVVfRkxVU0hGX2FsbDsNCj4g
ICAgICAgICAgaW9tbXVfcXVldWVfZnJlZV9wZ3RhYmxlKGQsIHBnKTsNCj4gKyAgICAgICAgcGVy
ZmNfaW5jcihpb21tdV9wdF9jb2FsZXNjZXMpOw0KPiAgICAgIH0NCj4gDQo+ICAgICAgc3Bpbl91
bmxvY2soJmhkLT5hcmNoLm1hcHBpbmdfbG9jayk7DQo+IC0tLSBhL3hlbi9hcmNoL3g4Ni9pbmNs
dWRlL2FzbS9wZXJmY19kZWZuLmgNCj4gKysrIGIveGVuL2FyY2gveDg2L2luY2x1ZGUvYXNtL3Bl
cmZjX2RlZm4uaA0KPiBAQCAtMTI1LDQgKzEyNSw3IEBAIFBFUkZDT1VOVEVSKHJlYWxtb2RlX2V4
aXRzLCAgICAgICJ2bWV4aXQNCj4gDQo+ICBQRVJGQ09VTlRFUihwYXVzZWxvb3BfZXhpdHMsICJ2
bWV4aXRzIGZyb20gUGF1c2UtTG9vcCBEZXRlY3Rpb24iKQ0KPiANCj4gK1BFUkZDT1VOVEVSKGlv
bW11X3B0X3NoYXR0ZXJzLCAgICAiSU9NTVUgcGFnZSB0YWJsZSBzaGF0dGVycyIpDQo+ICtQRVJG
Q09VTlRFUihpb21tdV9wdF9jb2FsZXNjZXMsICAgIklPTU1VIHBhZ2UgdGFibGUgY29hbGVzY2Vz
IikNCj4gKw0KPiAgLyojZW5kaWYqLyAvKiBfX1hFTl9QRVJGQ19ERUZOX0hfXyAqLw0KDQo=


From xen-devel-bounces@lists.xenproject.org Fri Feb 18 05:31:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 18 Feb 2022 05:31:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275107.470824 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKvrI-0007i3-GD; Fri, 18 Feb 2022 05:31:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275107.470824; Fri, 18 Feb 2022 05:31:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKvrI-0007hw-DC; Fri, 18 Feb 2022 05:31:08 +0000
Received: by outflank-mailman (input) for mailman id 275107;
 Fri, 18 Feb 2022 05:31:07 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qkm2=TB=intel.com=kevin.tian@srs-se1.protection.inumbo.net>)
 id 1nKvrH-0007hq-7M
 for xen-devel@lists.xenproject.org; Fri, 18 Feb 2022 05:31:07 +0000
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f659242c-907b-11ec-8723-dd0c611c5f35;
 Fri, 18 Feb 2022 06:31:05 +0100 (CET)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 17 Feb 2022 21:31:02 -0800
Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18])
 by fmsmga002.fm.intel.com with ESMTP; 17 Feb 2022 21:31:02 -0800
Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by
 ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.20; Thu, 17 Feb 2022 21:31:01 -0800
Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by
 ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.20; Thu, 17 Feb 2022 21:31:01 -0800
Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by
 orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.20 via Frontend Transport; Thu, 17 Feb 2022 21:31:01 -0800
Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.104)
 by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.1.2308.20; Thu, 17 Feb 2022 21:31:01 -0800
Received: from BN9PR11MB5276.namprd11.prod.outlook.com (2603:10b6:408:135::18)
 by MWHPR1101MB2143.namprd11.prod.outlook.com (2603:10b6:301:4f::8)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.14; Fri, 18 Feb
 2022 05:30:55 +0000
Received: from BN9PR11MB5276.namprd11.prod.outlook.com
 ([fe80::f514:7aae:315b:4d8d]) by BN9PR11MB5276.namprd11.prod.outlook.com
 ([fe80::f514:7aae:315b:4d8d%3]) with mapi id 15.20.4995.016; Fri, 18 Feb 2022
 05:30:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f659242c-907b-11ec-8723-dd0c611c5f35
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
  d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
  t=1645162265; x=1676698265;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-transfer-encoding:mime-version;
  bh=prQ3LGXFbhnMdjGsP9kuryjHEr1tIwPjHHynugB9hNk=;
  b=NYFwOOgRksSCuRm8XhqpFNEoyaEIOp9pSDMoRr+AHu2S6i4ZiaYrfldb
   J7+L8KkC4/FXWbYa2jkjHvWVr7gkcPARXHtwvE7ifmsKiqbW9/vogCnp9
   SegIV7rbT7QurtbsnlmZt0OW6K5a7u6MYiGrR34JKsZ2mZvX8P1k0JiXo
   mYZrRtKV1f8OWnnkORRVwknj02cEU12rlGuYxwqVMmNrKnmYiB6Mof7ou
   gorEIszFWGhUIff/ijVCEr6yMHhT0uzfX8jhUIQSGv/8JLqNpc+8qQqkr
   ByNQcOeW46HpyXZ5uig2Pe/56F0mz59NfvEFzARS6b5Xug6AaHr3JvYQ+
   A==;
X-IronPort-AV: E=McAfee;i="6200,9189,10261"; a="250811985"
X-IronPort-AV: E=Sophos;i="5.88,377,1635231600"; 
   d="scan'208";a="250811985"
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.88,377,1635231600"; 
   d="scan'208";a="635537628"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Hna/nYgwzl93fUrZymab5SNdiOGT/3F7oxn+mlr3Nq6EyWCESJ8NhI/fb+W7y8S1F+bqjMLXbdkWeNfeQEXrKiM0yyIF/NH6kQMcaroYsbkcrMeKOPWaAG8wWYGQxBg/p3//16F+COfZka7emZ7MN30qFbOGJodjKO6Slkg5o8mg4J4reepv026ivZPi1PQK1dDFHLF1200zHZlVIdA+/8KcmuxdCXzBM+oyqejS5XmhtlOGqU5jXPwUahV4BYmiXXzO6LXd9Dy4mshKLWq152F/CKM496cFYriYOsVfUY541JyKfjrxc3K+jL5hqMDm9l2xANilsWwci/Tkk7AhHg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=prQ3LGXFbhnMdjGsP9kuryjHEr1tIwPjHHynugB9hNk=;
 b=T4Y6adpmxJFECw3oJmR+V3kM1MYrsYGLmANBOaxZXZryyhvUaqPa3wOLmVf260L16R1VaouigS5UYFfqT8WQzzJ2uaV7KOeDsI//C/4zh4oOP4DNkPNV1OwZNvsIUu24s2qU5Uyw3TZdtWsNwE1Zjx6Bnkg5NE0B+eCvgUWQm8sixB6EJhk0YeXgJVshMCEOoLzFd7r+rGQgoN8WFX6H7N/CR76B/4HzaPS34g6PXQ1tdlQnBO8kbHzr5WVB+IVqFWKycAdInrr4cidwxJc9senMUeZ5bOKMlu/5Kaxt2GRgzqcUDJt0X4oxJ8/sIH19OzsFyh/YVWLxnK35i+3ECQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
 dkim=pass header.d=intel.com; arc=none
From: "Tian, Kevin" <kevin.tian@intel.com>
To: "Cooper, Andrew" <andrew.cooper3@citrix.com>, Xen-devel
	<xen-devel@lists.xenproject.org>
CC: "Cooper, Andrew" <andrew.cooper3@citrix.com>, "Beulich, Jan"
	<JBeulich@suse.com>, =?utf-8?B?UGF1IE1vbm7DqSwgUm9nZXI=?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>, "Nakajima, Jun"
	<jun.nakajima@intel.com>
Subject: RE: [PATCH] x86/hvm: Drop get_shadow_gs_base() hook and use
 hvm_get_reg()
Thread-Topic: [PATCH] x86/hvm: Drop get_shadow_gs_base() hook and use
 hvm_get_reg()
Thread-Index: AQHYDrlHm/6o22eN0EWvDD5o+20u9KyY89XQ
Date: Fri, 18 Feb 2022 05:30:54 +0000
Message-ID: <BN9PR11MB527615EA292D365A802A42028C379@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20220121112241.19277-1-andrew.cooper3@citrix.com>
In-Reply-To: <20220121112241.19277-1-andrew.cooper3@citrix.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=intel.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 689e0562-ffd7-4f85-45e2-08d9f29fd5d3
x-ms-traffictypediagnostic: MWHPR1101MB2143:EE_
x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr
x-microsoft-antispam-prvs: <MWHPR1101MB214322A094404B248223E4BC8C379@MWHPR1101MB2143.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8273;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: viADG0ZnI85fSczK+vqu9Bg93l2XAZRX4eI7ucbGntbP55MDU0fFyL6HwEx/Tm/2KE2IAyCWE6yNoxAXru+ZmegLF47QhqSLtt24CZkxJJlgRN7FwRsd+4h/bRPR7gchwaoC68rAvRq95ikhNzP/jreQOKhQS1ZxJjtxE3cCazWslkk21AAcWwafqOCAvTtxPsmE5jx8KHTbKMlV0w+VX+OJOkNldMZcoYRltKI/p+uZI6MGBNIfvOVuMUaXCwUMmgLMEeBl1LcoXW1Iydcl6m282y2MjNlkyaLKXJNA2V454uStyJafzNIhAJ3JNnR3IeTpG8sqWQpsFY3juN2zUWIVIlC2m8AGBYQbrf3txp+c3DEGEMtF77CNtTZYj8n2svKNXBleknCtbK9BNHF+56ntkPJKLGWZ2PiDfNpup6WwMGz5EzqPUDShsBE3cbHI82BEuvjR47MkmdhlLugcnHf/VomrgY5QTGeMgHsxkhxMw3OETatl/m96cOCI1kihY0bei44WbpHBReTifIv9SSchTcfbBaSkMYZtCLcmRY/g84OCnp3kmKOLJgtDqdbgdrv3syPRROFXFq8IoPUYTYEuYFmZhyuRYU2QwjYU5NqvhKaKkVtbPxOnJ3esFRgNMZFgodQvVhuYXZBZZ1s9UIm1LfrMVI9Ltc48lBY7j7jSZP9vYbSjiLqu6SSWQbYuRS5rLGN1G83SMUgwTUtRGg==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5276.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(107886003)(6506007)(9686003)(54906003)(83380400001)(8936002)(186003)(26005)(71200400001)(316002)(110136005)(66556008)(76116006)(122000001)(4326008)(508600001)(55016003)(66946007)(66476007)(2906002)(8676002)(64756008)(5660300002)(86362001)(52536014)(38100700002)(33656002)(38070700005)(82960400001)(7696005)(66446008);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?QmZITUVxWnhSQ1VNbGVJTzRRUm9tZG5sSmxFaXNvV3YzTTduL0l1cjlCVkNV?=
 =?utf-8?B?Yy9HQ0J3NVFFWGQvVHRBcWRaZUo3WE9NUm1nYW9XMUQ1NmgvQTljVC9nR3pS?=
 =?utf-8?B?RG9XMEFEM2crTUZrelVUQmxnaWV4ejlNaytZRW9vREJhWXVNdXpxelRYblZx?=
 =?utf-8?B?TkRnTHlXWThPR1IxUStVazRjZ2lneTd2YVhLYzRsUkt1MXFIeXdTVGhpV2w1?=
 =?utf-8?B?RFVwb05tMHBGNG1jeG5henFERjRlSnh6bDhCWUl5aE1OOWFWMHZZbStjRXV5?=
 =?utf-8?B?UnViNCtpUm55VHlyYytSc3grUUVxSzA0Vk1YY0JnUTJsMVQ2aVFVTytlWGpq?=
 =?utf-8?B?MWYwR1IxaVo5YlQ2RHVPdDdURzdMdlB4M09CeFh2OEhFbWFJWlpNRGFOeHFB?=
 =?utf-8?B?QzltMFNJQVBpVmFwWFlMVjNleHh1VFBoMXlVbGdHSHpUVUdkTHY4T3V0SWc1?=
 =?utf-8?B?WnZHYkc5bitoWGgyQ3lieEo3QkQ3d1FIcmc5TnZLb3NVNkphNEE0dDl6T2Vn?=
 =?utf-8?B?VkZic0JZY3JmZDIwWkVnWFptNWE4VnNTMGZLaFRWdUtkOHJ6VTFjN0VodlYw?=
 =?utf-8?B?UE9HNzJRSGI4ZDJ0S1NOVU1nS0VOYVJQK1hQNm9PS2tyajFrbGd0dVRtazFz?=
 =?utf-8?B?b2dvbVRFSGdTTGJjMzdENksxbGxRVFV1dmxyUmRUZUdzOUdzamttQmdVSFAv?=
 =?utf-8?B?ZEdWbWxLb04ySWZGQUtIMENMK0ZsUnVmdjhHa1pzc0FYUlJMbm10d01KZjJI?=
 =?utf-8?B?MUR6MVJSTGRqME01WjBBdExlZm1nVTNGRzlsRkdhQVV2SjR2MVVIMkh6YTJQ?=
 =?utf-8?B?VUZPbFRDRG1uTC9ucjZWRUhLelY0b0dHaUJvdU94YjFHYVVkUnpoY01Xc3Nl?=
 =?utf-8?B?YVBkaHVRYzl0U1oySlpXTysyRmNsZmhONGc2YkZDMXBLSUpnUldNeDVwU2JR?=
 =?utf-8?B?SldmQWxUbTNNL1MxVkpNREJpY2hPbkh6OHFGWmZqNkZ4Umh3MDNtKzh4cmJP?=
 =?utf-8?B?S3g0NEZQakJqeHUrWE5wZHJaZEZ0RUZJVm51NUFDT0s1VWFjbExjc0JLWUhw?=
 =?utf-8?B?MFhiRnBhY2FjTFRNbFZ2NWk3WW5RejJkRE9hNFRnUnRjMFpnNWh2ekdld0I2?=
 =?utf-8?B?WWZkbFZqd04rUTEra0pSVEhEK1BET3hPTXk5WkVYNldyandqbkNETFVKS2lL?=
 =?utf-8?B?Sy9XNHUwbGp6b3VjN08ya1YzZ0FiOGxGSWhmcFh1cWlHdjJHTFprai9oaEV4?=
 =?utf-8?B?bjVYV2Z3MTYvOFZBMmhBVkdFd1I4cWd5b3IxaGNBQlIyaEFUZlU2L2JWaU91?=
 =?utf-8?B?cjh2clVadnVjQlYxUHVaZkdvbHBlYmlxZHo0Wkk4MG9PSWNrejBFaVg5dkN6?=
 =?utf-8?B?aFdsK3RaVDJlVmVMcHdPTktGTFN0dUdNaDlacXFIU2FxNzlDYnhXdjhqZkVB?=
 =?utf-8?B?a3FPZWZWQVpUSWFZU3VyY0kxMEVHRlFHSmw2RGNVanI5OXlPenM0ZEErTWx3?=
 =?utf-8?B?SXBYcDhLSTFPWGtvZmZZYjZHWVJHWXJXVER2Y0htcThad1dXNUhZOTFuT0V4?=
 =?utf-8?B?NWI0aG1kbXR4ZnN2U1A4UjhkTGw1RmFkZjgvZEJqdWg5b3Q4M3JwWCtUUnNx?=
 =?utf-8?B?eXlMWGNWL0xKU2t3aitnY0VXNk9xcWJTUXBJdGtwM2szNHpSU0RhV0hzcTNt?=
 =?utf-8?B?UEFUdDkzajRRQmlxYXJDdG9pc05waGJTL1pzOTM4VFFLTTVqVnE1YUNGSXkw?=
 =?utf-8?B?YXptQmlDQXFNN3dEUWViK2FHU3hyMmtjK2M0YjFRMnBKcFlkUW1KSHBleW9h?=
 =?utf-8?B?WjA4d09XUXYvUGJGb2lwdXhsdDBmQzdVQk15T0xrVjB2RStDd0xZSVczNWJ5?=
 =?utf-8?B?SGRyVHpQcVU4dENYMktZelZNNDdTMUNCS3VlTk0zT2lFL2FmaG93WFZkNjRq?=
 =?utf-8?B?UkFmeXh5NmJ3UWFJaFZzTS9jS0h0Q0pEM3U4dXV6dXg4SXloRGQ0QUdTNFBl?=
 =?utf-8?B?ekJMeVFiVWtORm5IYlVIMVJiNXZEemZORngwNkJKSm5CZVdVempjN2JHZlI4?=
 =?utf-8?B?eHhWWE04YlQzUERubDRkOGxZeTl4ZVVWRnBhRnU4Wlp3VWpMRkQvRVNmQTBJ?=
 =?utf-8?B?cG9tSzBTMHV0YWhjb0NOUWtiNld1NVhLcnJHdlpUcnY0VXp4NG1pOGQxdHVQ?=
 =?utf-8?B?Q1E9PQ==?=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 689e0562-ffd7-4f85-45e2-08d9f29fd5d3
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Feb 2022 05:30:54.9344
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: KMlE94oHYUEHxPW0pQ8ooKfVrsSm6Gr/YZZycE89KZV3x5nwJjHgLwBJfzfaknKUkLUjuFjf2gNIhs8ZvlfBOw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2143
X-OriginatorOrg: intel.com

PiBGcm9tOiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPg0KPiBTZW50
OiBGcmlkYXksIEphbnVhcnkgMjEsIDIwMjIgNzoyMyBQTQ0KPiANCj4gVGhpcyBpcyBhIHRyaXZp
YWwgYWNjZXNzb3IgZm9yIGFuIE1TUiwgc28gdXNlIGh2bV9nZXRfcmVnKCkgcmF0aGVyIHRoYW4g
YQ0KPiBkZWRpY2F0ZWQgaG9vay4gIEluIGFyY2hfZ2V0X2luZm9fZ3Vlc3QoKSwgcmV3b3JrIHRo
ZSBsb2dpYyB0byByZWFkDQo+IEdTX1NIQURPVw0KPiBvbmx5IG9uY2UuDQo+IA0KPiBnZXRfaHZt
X3JlZ2lzdGVycygpIGlzIGNhbGxlZCBvbiBjdXJyZW50LCBtZWFuaW5nIHRoYXQgZGlhZ25vc3Rp
Y3MgcHJpbnQgYQ0KPiBzdGFsZSBHU19TSEFET1cgZnJvbSB0aGUgcHJldmlvdXMgdmNwdSBjb250
ZXh0IHN3aXRjaC4gIEFkanVzdCBib3RoDQo+IGltcGxlbWVudGF0aW9ucyB0byBvYnRhaW4gdGhl
IGNvcnJlY3QgdmFsdWUuDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRy
ZXcuY29vcGVyM0BjaXRyaXguY29tPg0KDQpSZXZpZXdlZC1ieTogS2V2aW4gVGlhbiA8a2V2aW4u
dGlhbkBpbnRlbC5jb20+DQoNCj4gLS0tDQo+IENDOiBKYW4gQmV1bGljaCA8SkJldWxpY2hAc3Vz
ZS5jb20+DQo+IENDOiBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT4NCj4g
Q0M6IFdlaSBMaXUgPHdsQHhlbi5vcmc+DQo+IENDOiBKdW4gTmFrYWppbWEgPGp1bi5uYWthamlt
YUBpbnRlbC5jb20+DQo+IENDOiBLZXZpbiBUaWFuIDxrZXZpbi50aWFuQGludGVsLmNvbT4NCj4g
DQo+IElmIHdlIGNhcmUgdG8gYmFja3BvcnQgdGhlIGJ1Z2ZpeCBhc3BlY3QsIGEgZmFyIGxlc3Mg
aW52YXNpdmUgb3B0aW9uIHdvdWxkIGJlDQo+IHRvIHJlYWQgTVNSX1NIQURPV19HU19CQVNFIGRp
cmVjdGx5Lg0KPiANCj4gVGhlIG9ubHkgY2FzZSB3aGVyZSB0aGF0IGdvZXMgd3JvbmcgaXMgd2hl
biB2bWNiLT5rZXJuZ3NiYXNlIGhhcyBiZWVuDQo+IG1vZGlmaWVkDQo+IGFuZCBpcyBwZW5kaW5n
IGEgVk1MT0FELiAgSSdtIGZhaXJseSBzdXJlIHRoaXMgY2FuIG9ubHkgb2NjdXIgd2hlbiB3ZSBu
ZWVkDQo+IHZjcHUgZGlhZ25vc3RpY3MsIGFmdGVyIGFuIGVtdWxhdGVkIHdyaXRlIG9mIE1TUl9T
SEFET1dfR1NfQkFTRS4NCj4gLS0tDQo+ICB4ZW4vYXJjaC94ODYvZG9tY3RsLmMgICAgICAgICAg
ICAgIHwgIDggKysrKysrLS0NCj4gIHhlbi9hcmNoL3g4Ni9odm0vc3ZtL3N2bS5jICAgICAgICAg
fCAxMiArKysrKystLS0tLS0NCj4gIHhlbi9hcmNoL3g4Ni9odm0vdm14L3ZteC5jICAgICAgICAg
fCAxNiArKysrKysrKysrLS0tLS0tDQo+ICB4ZW4vYXJjaC94ODYvaW5jbHVkZS9hc20vaHZtL2h2
bS5oIHwgIDcgLS0tLS0tLQ0KPiAgeGVuL2FyY2gveDg2L3g4Nl82NC90cmFwcy5jICAgICAgICB8
ICAyICstDQo+ICA1IGZpbGVzIGNoYW5nZWQsIDIzIGluc2VydGlvbnMoKyksIDIyIGRlbGV0aW9u
cygtKQ0KPiANCj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9kb21jdGwuYyBiL3hlbi9hcmNo
L3g4Ni9kb21jdGwuYw0KPiBpbmRleCA3ZDEwMmUwNjQ3ZWMuLmU0OWY5ZTkxYjlmYSAxMDA2NDQN
Cj4gLS0tIGEveGVuL2FyY2gveDg2L2RvbWN0bC5jDQo+ICsrKyBiL3hlbi9hcmNoL3g4Ni9kb21j
dGwuYw0KPiBAQCAtMTQ0Nyw2ICsxNDQ3LDcgQEAgdm9pZCBhcmNoX2dldF9pbmZvX2d1ZXN0KHN0
cnVjdCB2Y3B1ICp2LA0KPiB2Y3B1X2d1ZXN0X2NvbnRleHRfdSBjKQ0KPiAgICAgIGlmICggaXNf
aHZtX2RvbWFpbihkKSApDQo+ICAgICAgew0KPiAgICAgICAgICBzdHJ1Y3Qgc2VnbWVudF9yZWdp
c3RlciBzcmVnOw0KPiArICAgICAgICB1bnNpZ25lZCBsb25nIGdzX3NoYWRvdzsNCj4gDQo+ICAg
ICAgICAgIGMubmF0LT5jdHJscmVnWzBdID0gdi0+YXJjaC5odm0uZ3Vlc3RfY3JbMF07DQo+ICAg
ICAgICAgIGMubmF0LT5jdHJscmVnWzJdID0gdi0+YXJjaC5odm0uZ3Vlc3RfY3JbMl07DQo+IEBA
IC0xNDY1LDE1ICsxNDY2LDE4IEBAIHZvaWQgYXJjaF9nZXRfaW5mb19ndWVzdChzdHJ1Y3QgdmNw
dSAqdiwNCj4gdmNwdV9ndWVzdF9jb250ZXh0X3UgYykNCj4gICAgICAgICAgYy5uYXQtPmZzX2Jh
c2UgPSBzcmVnLmJhc2U7DQo+ICAgICAgICAgIGh2bV9nZXRfc2VnbWVudF9yZWdpc3Rlcih2LCB4
ODZfc2VnX2dzLCAmc3JlZyk7DQo+ICAgICAgICAgIGMubmF0LT51c2VyX3JlZ3MuZ3MgPSBzcmVn
LnNlbDsNCj4gKw0KPiArICAgICAgICBnc19zaGFkb3cgPSBodm1fZ2V0X3JlZyh2LCBNU1JfU0hB
RE9XX0dTX0JBU0UpOw0KPiArDQo+ICAgICAgICAgIGlmICggcmluZ18wKCZjLm5hdC0+dXNlcl9y
ZWdzKSApDQo+ICAgICAgICAgIHsNCj4gICAgICAgICAgICAgIGMubmF0LT5nc19iYXNlX2tlcm5l
bCA9IHNyZWcuYmFzZTsNCj4gLSAgICAgICAgICAgIGMubmF0LT5nc19iYXNlX3VzZXIgPSBodm1f
Z2V0X3NoYWRvd19nc19iYXNlKHYpOw0KPiArICAgICAgICAgICAgYy5uYXQtPmdzX2Jhc2VfdXNl
ciA9IGdzX3NoYWRvdzsNCj4gICAgICAgICAgfQ0KPiAgICAgICAgICBlbHNlDQo+ICAgICAgICAg
IHsNCj4gICAgICAgICAgICAgIGMubmF0LT5nc19iYXNlX3VzZXIgPSBzcmVnLmJhc2U7DQo+IC0g
ICAgICAgICAgICBjLm5hdC0+Z3NfYmFzZV9rZXJuZWwgPSBodm1fZ2V0X3NoYWRvd19nc19iYXNl
KHYpOw0KPiArICAgICAgICAgICAgYy5uYXQtPmdzX2Jhc2Vfa2VybmVsID0gZ3Nfc2hhZG93Ow0K
PiAgICAgICAgICB9DQo+ICAgICAgfQ0KPiAgICAgIGVsc2UNCj4gZGlmZiAtLWdpdCBhL3hlbi9h
cmNoL3g4Ni9odm0vc3ZtL3N2bS5jIGIveGVuL2FyY2gveDg2L2h2bS9zdm0vc3ZtLmMNCj4gaW5k
ZXggYmI2YjhlNTYwYTlmLi5lM2JjODhlNzgwNTggMTAwNjQ0DQo+IC0tLSBhL3hlbi9hcmNoL3g4
Ni9odm0vc3ZtL3N2bS5jDQo+ICsrKyBiL3hlbi9hcmNoL3g4Ni9odm0vc3ZtL3N2bS5jDQo+IEBA
IC03NTIsMTEgKzc1Miw2IEBAIHN0YXRpYyB2b2lkIHN2bV9zZXRfc2VnbWVudF9yZWdpc3Rlcihz
dHJ1Y3QgdmNwdSAqdiwNCj4gZW51bSB4ODZfc2VnbWVudCBzZWcsDQo+ICAgICAgfQ0KPiAgfQ0K
PiANCj4gLXN0YXRpYyB1bnNpZ25lZCBsb25nIHN2bV9nZXRfc2hhZG93X2dzX2Jhc2Uoc3RydWN0
IHZjcHUgKnYpDQo+IC17DQo+IC0gICAgcmV0dXJuIHYtPmFyY2guaHZtLnN2bS52bWNiLT5rZXJu
Z3NiYXNlOw0KPiAtfQ0KPiAtDQo+ICBzdGF0aWMgaW50IHN2bV9zZXRfZ3Vlc3RfcGF0KHN0cnVj
dCB2Y3B1ICp2LCB1NjQgZ3BhdCkNCj4gIHsNCj4gICAgICBzdHJ1Y3Qgdm1jYl9zdHJ1Y3QgKnZt
Y2IgPSB2LT5hcmNoLmh2bS5zdm0udm1jYjsNCj4gQEAgLTI0NzEsMTAgKzI0NjYsMTYgQEAgc3Rh
dGljIGJvb2wgc3ZtX2dldF9wZW5kaW5nX2V2ZW50KHN0cnVjdCB2Y3B1DQo+ICp2LCBzdHJ1Y3Qg
eDg2X2V2ZW50ICppbmZvKQ0KPiANCj4gIHN0YXRpYyB1aW50NjRfdCBzdm1fZ2V0X3JlZyhzdHJ1
Y3QgdmNwdSAqdiwgdW5zaWduZWQgaW50IHJlZykNCj4gIHsNCj4gKyAgICBzdHJ1Y3QgdmNwdSAq
Y3VyciA9IGN1cnJlbnQ7DQo+ICAgICAgc3RydWN0IGRvbWFpbiAqZCA9IHYtPmRvbWFpbjsNCj4g
DQo+ICAgICAgc3dpdGNoICggcmVnICkNCj4gICAgICB7DQo+ICsgICAgY2FzZSBNU1JfU0hBRE9X
X0dTX0JBU0U6DQo+ICsgICAgICAgIGlmICggdiA9PSBjdXJyICkNCj4gKyAgICAgICAgICAgIHN2
bV9zeW5jX3ZtY2Iodiwgdm1jYl9pbl9zeW5jKTsNCj4gKyAgICAgICAgcmV0dXJuIHYtPmFyY2gu
aHZtLnN2bS52bWNiLT5rZXJuZ3NiYXNlOw0KPiArDQo+ICAgICAgZGVmYXVsdDoNCj4gICAgICAg
ICAgcHJpbnRrKFhFTkxPR19HX0VSUiAiJXMoJXB2LCAweCUwOHgpIEJhZCByZWdpc3RlclxuIiwN
Cj4gICAgICAgICAgICAgICAgIF9fZnVuY19fLCB2LCByZWcpOw0KPiBAQCAtMjUxMyw3ICsyNTE0
LDYgQEAgc3RhdGljIHN0cnVjdCBodm1fZnVuY3Rpb25fdGFibGUgX19pbml0ZGF0YQ0KPiBzdm1f
ZnVuY3Rpb25fdGFibGUgPSB7DQo+ICAgICAgLmdldF9jcGwgICAgICAgICAgICAgID0gc3ZtX2dl
dF9jcGwsDQo+ICAgICAgLmdldF9zZWdtZW50X3JlZ2lzdGVyID0gc3ZtX2dldF9zZWdtZW50X3Jl
Z2lzdGVyLA0KPiAgICAgIC5zZXRfc2VnbWVudF9yZWdpc3RlciA9IHN2bV9zZXRfc2VnbWVudF9y
ZWdpc3RlciwNCj4gLSAgICAuZ2V0X3NoYWRvd19nc19iYXNlICAgPSBzdm1fZ2V0X3NoYWRvd19n
c19iYXNlLA0KPiAgICAgIC51cGRhdGVfZ3Vlc3RfY3IgICAgICA9IHN2bV91cGRhdGVfZ3Vlc3Rf
Y3IsDQo+ICAgICAgLnVwZGF0ZV9ndWVzdF9lZmVyICAgID0gc3ZtX3VwZGF0ZV9ndWVzdF9lZmVy
LA0KPiAgICAgIC5jcHVpZF9wb2xpY3lfY2hhbmdlZCA9IHN2bV9jcHVpZF9wb2xpY3lfY2hhbmdl
ZCwNCj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9odm0vdm14L3ZteC5jIGIveGVuL2FyY2gv
eDg2L2h2bS92bXgvdm14LmMNCj4gaW5kZXggYzQ0Y2Y4ZjVkNDI1Li4yN2MzNmFmNjAyN2QgMTAw
NjQ0DQo+IC0tLSBhL3hlbi9hcmNoL3g4Ni9odm0vdm14L3ZteC5jDQo+ICsrKyBiL3hlbi9hcmNo
L3g4Ni9odm0vdm14L3ZteC5jDQo+IEBAIC0xMTgzLDExICsxMTgzLDYgQEAgc3RhdGljIHZvaWQg
dm14X3NldF9zZWdtZW50X3JlZ2lzdGVyKHN0cnVjdCB2Y3B1DQo+ICp2LCBlbnVtIHg4Nl9zZWdt
ZW50IHNlZywNCj4gICAgICB2bXhfdm1jc19leGl0KHYpOw0KPiAgfQ0KPiANCj4gLXN0YXRpYyB1
bnNpZ25lZCBsb25nIHZteF9nZXRfc2hhZG93X2dzX2Jhc2Uoc3RydWN0IHZjcHUgKnYpDQo+IC17
DQo+IC0gICAgcmV0dXJuIHYtPmFyY2guaHZtLnZteC5zaGFkb3dfZ3M7DQo+IC19DQo+IC0NCj4g
IHN0YXRpYyBpbnQgdm14X3NldF9ndWVzdF9wYXQoc3RydWN0IHZjcHUgKnYsIHU2NCBncGF0KQ0K
PiAgew0KPiAgICAgIGlmICggIXBhZ2luZ19tb2RlX2hhcCh2LT5kb21haW4pIHx8DQo+IEBAIC0y
NDAxLDYgKzIzOTYsNyBAQCBzdGF0aWMgaW50IHZtdHJhY2VfcmVzZXQoc3RydWN0IHZjcHUgKnYp
DQo+IA0KPiAgc3RhdGljIHVpbnQ2NF90IHZteF9nZXRfcmVnKHN0cnVjdCB2Y3B1ICp2LCB1bnNp
Z25lZCBpbnQgcmVnKQ0KPiAgew0KPiArICAgIHN0cnVjdCB2Y3B1ICpjdXJyID0gY3VycmVudDsN
Cj4gICAgICBzdHJ1Y3QgZG9tYWluICpkID0gdi0+ZG9tYWluOw0KPiAgICAgIHVpbnQ2NF90IHZh
bCA9IDA7DQo+ICAgICAgaW50IHJjOw0KPiBAQCAtMjQxNyw2ICsyNDEzLDE1IEBAIHN0YXRpYyB1
aW50NjRfdCB2bXhfZ2V0X3JlZyhzdHJ1Y3QgdmNwdSAqdiwNCj4gdW5zaWduZWQgaW50IHJlZykN
Cj4gICAgICAgICAgICAgIGRvbWFpbl9jcmFzaChkKTsNCj4gICAgICAgICAgfQ0KPiAgICAgICAg
ICByZXR1cm4gdmFsOw0KPiArDQo+ICsgICAgY2FzZSBNU1JfU0hBRE9XX0dTX0JBU0U6DQo+ICsg
ICAgICAgIGlmICggdiA9PSBjdXJyICkNCj4gKyAgICAgICAgew0KPiArICAgICAgICAgICAgcmRt
c3JsKE1TUl9TSEFET1dfR1NfQkFTRSwgdmFsKTsNCj4gKyAgICAgICAgICAgIHJldHVybiB2YWw7
DQo+ICsgICAgICAgIH0NCj4gKyAgICAgICAgZWxzZQ0KPiArICAgICAgICAgICAgcmV0dXJuIHYt
PmFyY2guaHZtLnZteC5zaGFkb3dfZ3M7DQo+ICAgICAgfQ0KPiANCj4gICAgICAvKiBMb2dpYyB3
aGljaCBtYXliZSByZXF1aXJlcyByZW1vdGUgVk1DUyBhY3F1aXNpdGlvbi4gKi8NCj4gQEAgLTI0
ODksNyArMjQ5NCw2IEBAIHN0YXRpYyBzdHJ1Y3QgaHZtX2Z1bmN0aW9uX3RhYmxlIF9faW5pdGRh
dGENCj4gdm14X2Z1bmN0aW9uX3RhYmxlID0gew0KPiAgICAgIC5nZXRfY3BsICAgICAgICAgICAg
ICA9IF92bXhfZ2V0X2NwbCwNCj4gICAgICAuZ2V0X3NlZ21lbnRfcmVnaXN0ZXIgPSB2bXhfZ2V0
X3NlZ21lbnRfcmVnaXN0ZXIsDQo+ICAgICAgLnNldF9zZWdtZW50X3JlZ2lzdGVyID0gdm14X3Nl
dF9zZWdtZW50X3JlZ2lzdGVyLA0KPiAtICAgIC5nZXRfc2hhZG93X2dzX2Jhc2UgICA9IHZteF9n
ZXRfc2hhZG93X2dzX2Jhc2UsDQo+ICAgICAgLnVwZGF0ZV9ob3N0X2NyMyAgICAgID0gdm14X3Vw
ZGF0ZV9ob3N0X2NyMywNCj4gICAgICAudXBkYXRlX2d1ZXN0X2NyICAgICAgPSB2bXhfdXBkYXRl
X2d1ZXN0X2NyLA0KPiAgICAgIC51cGRhdGVfZ3Vlc3RfZWZlciAgICA9IHZteF91cGRhdGVfZ3Vl
c3RfZWZlciwNCj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9pbmNsdWRlL2FzbS9odm0vaHZt
LmgNCj4gYi94ZW4vYXJjaC94ODYvaW5jbHVkZS9hc20vaHZtL2h2bS5oDQo+IGluZGV4IDg0MmY5
ODc2M2M0Yi4uZmViOWQyMjFhNmE2IDEwMDY0NA0KPiAtLS0gYS94ZW4vYXJjaC94ODYvaW5jbHVk
ZS9hc20vaHZtL2h2bS5oDQo+ICsrKyBiL3hlbi9hcmNoL3g4Ni9pbmNsdWRlL2FzbS9odm0vaHZt
LmgNCj4gQEAgLTEyOCw3ICsxMjgsNiBAQCBzdHJ1Y3QgaHZtX2Z1bmN0aW9uX3RhYmxlIHsNCj4g
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0cnVjdCBzZWdtZW50X3JlZ2lzdGVy
ICpyZWcpOw0KPiAgICAgIHZvaWQgKCpzZXRfc2VnbWVudF9yZWdpc3Rlcikoc3RydWN0IHZjcHUg
KnYsIGVudW0geDg2X3NlZ21lbnQgc2VnLA0KPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgc3RydWN0IHNlZ21lbnRfcmVnaXN0ZXIgKnJlZyk7DQo+IC0gICAgdW5zaWduZWQgbG9u
ZyAoKmdldF9zaGFkb3dfZ3NfYmFzZSkoc3RydWN0IHZjcHUgKnYpOw0KPiANCj4gICAgICAvKg0K
PiAgICAgICAqIFJlLXNldCB0aGUgdmFsdWUgb2YgQ1IzIHRoYXQgWGVuIHJ1bnMgb24gd2hlbiBo
YW5kbGluZyBWTSBleGl0cy4NCj4gQEAgLTQ2OSwxMSArNDY4LDYgQEAgaHZtX2dldF9jcGwoc3Ry
dWN0IHZjcHUgKnYpDQo+ICAgICAgcmV0dXJuIGFsdGVybmF0aXZlX2NhbGwoaHZtX2Z1bmNzLmdl
dF9jcGwsIHYpOw0KPiAgfQ0KPiANCj4gLXN0YXRpYyBpbmxpbmUgdW5zaWduZWQgbG9uZyBodm1f
Z2V0X3NoYWRvd19nc19iYXNlKHN0cnVjdCB2Y3B1ICp2KQ0KPiAtew0KPiAtICAgIHJldHVybiBh
bHRlcm5hdGl2ZV9jYWxsKGh2bV9mdW5jcy5nZXRfc2hhZG93X2dzX2Jhc2UsIHYpOw0KPiAtfQ0K
PiAtDQo+ICAjZGVmaW5lIGhhc19odm1fcGFyYW1zKGQpIFwNCj4gICAgICAoKGQpLT5hcmNoLmh2
bS5wYXJhbXMgIT0gTlVMTCkNCj4gDQo+IEBAIC03NTMsNyArNzQ3LDYgQEAgdm9pZCBodm1fc2V0
X3JlZyhzdHJ1Y3QgdmNwdSAqdiwgdW5zaWduZWQgaW50IHJlZywNCj4gdWludDY0X3QgdmFsKTsN
Cj4gICAqIG5lZWRlZCBiZWNhdXNlIERDRSB3aWxsIGtpY2sgaW4uDQo+ICAgKi8NCj4gIGludCBo
dm1fZ3Vlc3RfeDg2X21vZGUoc3RydWN0IHZjcHUgKnYpOw0KPiAtdW5zaWduZWQgbG9uZyBodm1f
Z2V0X3NoYWRvd19nc19iYXNlKHN0cnVjdCB2Y3B1ICp2KTsNCj4gIHZvaWQgaHZtX2NwdWlkX3Bv
bGljeV9jaGFuZ2VkKHN0cnVjdCB2Y3B1ICp2KTsNCj4gIHZvaWQgaHZtX3NldF90c2Nfb2Zmc2V0
KHN0cnVjdCB2Y3B1ICp2LCB1aW50NjRfdCBvZmZzZXQsIHVpbnQ2NF90IGF0X3RzYyk7DQo+IA0K
PiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gveDg2L3g4Nl82NC90cmFwcy5jIGIveGVuL2FyY2gveDg2
L3g4Nl82NC90cmFwcy5jDQo+IGluZGV4IGQ2NjFkN2ZmY2FhZi4uZDk3YmYwN2IyMmJjIDEwMDY0
NA0KPiAtLS0gYS94ZW4vYXJjaC94ODYveDg2XzY0L3RyYXBzLmMNCj4gKysrIGIveGVuL2FyY2gv
eDg2L3g4Nl82NC90cmFwcy5jDQo+IEBAIC03OSw3ICs3OSw3IEBAIHN0YXRpYyB2b2lkIGdldF9o
dm1fcmVnaXN0ZXJzKHN0cnVjdCB2Y3B1ICp2LCBzdHJ1Y3QNCj4gY3B1X3VzZXJfcmVncyAqcmVn
cywNCj4gICAgICBodm1fZ2V0X3NlZ21lbnRfcmVnaXN0ZXIodiwgeDg2X3NlZ19zcywgJnNyZWcp
Ow0KPiAgICAgIHJlZ3MtPnNzID0gc3JlZy5zZWw7DQo+IA0KPiAtICAgIGNyc1s3XSA9IGh2bV9n
ZXRfc2hhZG93X2dzX2Jhc2Uodik7DQo+ICsgICAgY3JzWzddID0gaHZtX2dldF9yZWcodiwgTVNS
X1NIQURPV19HU19CQVNFKTsNCj4gIH0NCj4gDQo+ICBzdGF0aWMgdm9pZCBfc2hvd19yZWdpc3Rl
cnMoDQo+IC0tDQo+IDIuMTEuMA0KDQo=


From xen-devel-bounces@lists.xenproject.org Fri Feb 18 05:35:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 18 Feb 2022 05:35:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275116.470834 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKvv1-0008Pf-4d; Fri, 18 Feb 2022 05:34:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275116.470834; Fri, 18 Feb 2022 05:34:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKvv1-0008PY-1Z; Fri, 18 Feb 2022 05:34:59 +0000
Received: by outflank-mailman (input) for mailman id 275116;
 Fri, 18 Feb 2022 05:34:58 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qkm2=TB=intel.com=kevin.tian@srs-se1.protection.inumbo.net>)
 id 1nKvuz-0008PQ-RQ
 for xen-devel@lists.xenproject.org; Fri, 18 Feb 2022 05:34:57 +0000
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8018cf1c-907c-11ec-8eb8-a37418f5ba1a;
 Fri, 18 Feb 2022 06:34:55 +0100 (CET)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 17 Feb 2022 21:34:53 -0800
Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14])
 by fmsmga002.fm.intel.com with ESMTP; 17 Feb 2022 21:34:53 -0800
Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by
 ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.20; Thu, 17 Feb 2022 21:34:53 -0800
Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by
 orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.20 via Frontend Transport; Thu, 17 Feb 2022 21:34:53 -0800
Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.100)
 by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.1.2308.20; Thu, 17 Feb 2022 21:34:52 -0800
Received: from BN9PR11MB5276.namprd11.prod.outlook.com (2603:10b6:408:135::18)
 by SN6PR11MB2815.namprd11.prod.outlook.com (2603:10b6:805:62::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.15; Fri, 18 Feb
 2022 05:34:46 +0000
Received: from BN9PR11MB5276.namprd11.prod.outlook.com
 ([fe80::f514:7aae:315b:4d8d]) by BN9PR11MB5276.namprd11.prod.outlook.com
 ([fe80::f514:7aae:315b:4d8d%3]) with mapi id 15.20.4995.016; Fri, 18 Feb 2022
 05:34:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8018cf1c-907c-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
  d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
  t=1645162496; x=1676698496;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-transfer-encoding:mime-version;
  bh=/KRAENq2ZD/H5LC/wAS4dS2+EEEGfv6Q3p1mUQPMjZs=;
  b=CgNi7cRG3bp4lu7P4SYPKkLRqEqMM9x+9xDJwIZjaNnN46IJ6Kg7YZT9
   VjIbA3B8XdcJhCkixrx/wf9lCl8UkZ6kYAwf9G7ZYsKvFuy77lsd6phuK
   X7OPQpF8oQ+Lc0UCfhXRD7JVzwqocUYfd8N6dR5IiV5NYZp9xSfjEkeKI
   F/Rst97KW5D2kbrZCXlBTo/VmhHbowD9QSQb5Ilwe5pCecIucZY4JCmFx
   ZiSd0a8LcbwUOsesJwNi8agcAO8gR7rA4D4Gb23CMb30MPXQta0AlXgWu
   3dZmnheP+JKMF5tXNwgUUNaBh+trWnR8UM700cBLyfRi6832/JwAvoQDR
   w==;
X-IronPort-AV: E=McAfee;i="6200,9189,10261"; a="337500275"
X-IronPort-AV: E=Sophos;i="5.88,377,1635231600"; 
   d="scan'208";a="337500275"
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.88,377,1635231600"; 
   d="scan'208";a="635539540"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XGegvpJIQIkiH9y6SMpDlJLiz6pJvRMd4a+nsYWuueojjtCYNJ9tgkRLQZSnB2Fh03k++cHP+czpctj4xZ67LjgP0myR9EFrJlGQBBd+HkWTJO/EBc0AyZ9yquU/LEFIZE3mo7EyKtMLXhtFMPdBEaSC95ciMpVS16VLgtpCz30e7bGLovIkBZ0uGoLR3gK8WMwHN0yo2ofLPTLMV3yG2el/F27rPS5FjsuIHanR44TGYpZnCXhMgf7bifYp2vtPwA719a2urH8yADfPRO4i955AW8n57oqp+xnE5zfTpmGXJ0b6REExM7PgJd++wugpWzqT+GT3KjhqCMQiZ+s5bw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=/KRAENq2ZD/H5LC/wAS4dS2+EEEGfv6Q3p1mUQPMjZs=;
 b=kHgIJEarRyiIe3cuYtJoyCDd+QK0oIb1AowgRFA/mJFJkmSxWzTKQ4ZwCdnwBEjrigwqe2TJu9yQWz3Vs06saVhTiSCpUy7U4v2zCduwlP+LNDCXLKtqEWQNT/mXVKiNOrfDHOCc6gbXOBfQp73Vuk5YZJS8Xeq46hhcN4CkWkW0JeTlPeCgY1QovIE9LQGP3Uro42vtgfo7aVrO9AEEa0OETcvr5qvntNSOIeUhP3zsbUeHS0yV6CVhM4kOKxg+qEo0uc25ODL+syzen4T9ylE9H6eRWKIqGCHrvf1mhBahKpokrLry/KGoEXXlGyUxo1u0l8ZSAOrvEaqE5sgbVQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
From: "Tian, Kevin" <kevin.tian@intel.com>
To: "Beulich, Jan" <JBeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Paul Durrant <paul@xen.org>, "Cooper, Andrew" <andrew.cooper3@citrix.com>,
	Wei Liu <wl@xen.org>, =?utf-8?B?UGF1IE1vbm7DqSwgUm9nZXI=?=
	<roger.pau@citrix.com>
Subject: RE: [PATCH v2 2/4] VT-d / x86: re-arrange cache syncing
Thread-Topic: [PATCH v2 2/4] VT-d / x86: re-arrange cache syncing
Thread-Index: AQHYE4z9cNIIU9JepUSjhIuqcb/UzqyY6wbA
Date: Fri, 18 Feb 2022 05:34:46 +0000
Message-ID: <BN9PR11MB52765927D13689873F4C4B788C379@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <4b7db7ae-eb84-7ecc-4334-fe5f0f7ef46b@suse.com>
 <54c4539f-0bed-c42d-aa8e-4e31c45c4245@suse.com>
In-Reply-To: <54c4539f-0bed-c42d-aa8e-4e31c45c4245@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=intel.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 071cd7a4-0347-4c6a-3929-08d9f2a05fcb
x-ms-traffictypediagnostic: SN6PR11MB2815:EE_
x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr
x-microsoft-antispam-prvs: <SN6PR11MB28157CB375D978D9C549A5018C379@SN6PR11MB2815.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8882;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: eLBRV936MJzSQIDEWCRFCdLK7Djdmt/p9x2P5jzkKcxZIOIidqmUZ9zOifzdFCwwPIImhLZiHDYmuc6xgGaLMeZK7yxY7t/BnJNmJBBpMg91o85zhq5v8dZk2DiXJsu8/k1wsqsD+5CYtSHzhL5bXIMaJ0PVkIFCipxzXv8ahoqegyfDoCHtZPTrPjACHYPq2qD2ss/JreOW7llzEPVMXsup8DNVIBNpWI4s7f4hLqEqQRTS1oP9CN+79HWCUqMJRiT5iNYMTusqKmFWZ3/IVCl8aKIX4IcnbHp5od2F4hmgnugo42TUujMPGfvqIRQbigWqYbSzxI0+MfRAXBRxZoFNtZcs0cugWf1zFHRBo6xpEKBwXy84uvqaNZGAuVF7Kcq5J50Ws/nOBb3U96WZJUJOcWjNwA8F9vDuTPfqIzpOK71vJpHRLReaq1uAlYd4hwukBPOnk/q4B56S1JSLoi0XLasaK5F5t2QVmSIumNvSkMVTD/iell6Wcv/HNbmnd44aV3ffKqrUxI/oY0jV+t9QCJl9Gziy0AG+dYzQrocqUotfEMw0jy1CMHBiM2nKE+kDOxJDSmolaAQq52Akf6Z978NJyzcV0TWxdbNIxjS1q4rqm3nvwcfxWth5xLSaILVrclrYCXtt1ELBcnhe7/B59qH8woyWkUIEniCC7GR2fnLq7roHKI2cUocIihKj4Wkqhn/9CW/gTQlxrvOpHQ==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5276.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8676002)(38100700002)(66446008)(71200400001)(38070700005)(64756008)(26005)(186003)(66476007)(83380400001)(122000001)(82960400001)(4326008)(66946007)(2906002)(508600001)(86362001)(110136005)(54906003)(9686003)(5660300002)(8936002)(66556008)(316002)(33656002)(7696005)(76116006)(52536014)(55016003)(6506007);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?M29zbUE5anJWOVJheXpmZWIzSDhuSXZURk5qZDRucVU1djZPODJBT053ZXFZ?=
 =?utf-8?B?azI5cGlUc21VK1JXNWx6V1RVeEI2WmtZem5TUDBvVlQ2d0FTeEhOSEErSFR4?=
 =?utf-8?B?akt1MTZmY3hYbjFTMEZuYmdUemZ3Vk5wZ0dsd21ZNm0rY3JUT0FwMTFmRVBm?=
 =?utf-8?B?dWRiOElQTzhlcE41OFFsOVZzOUxCOGRsMVlpOVIranlRK3AyNDlxd21xNngy?=
 =?utf-8?B?a1paUTA1cTB4di9SbVR1NGFjMFVDQ0F4SG5XbDcwUGVGRWt4OGFRM0tUbHUz?=
 =?utf-8?B?em81ck5Nd2tMSVFQc1lHMVVWT2ZTOUZiZmZiY0lnUFNMUWZOYzZGYXB1MTBs?=
 =?utf-8?B?N21zQThyekJMQ1kxNW1wb3BiOUZJZk9lVXJ4d3lncWZkWTFMMWNtc093QUFp?=
 =?utf-8?B?L2JuQ1ZsNWk4aG5WR3N1eXZ5dDM2S29ZMVd0Z3lRaUdyOVJPNkFZbFZDMVdL?=
 =?utf-8?B?aCtJa0w1c2thTC9QTmpiaUpUeW0xTXN2RTNUSDFSWEc4a3l1bmJ1VjJGUTcx?=
 =?utf-8?B?YmtqbE4xaE0wSU9KTjA5d3BaTFk0U0ZRWGFvMHpmTFUvd1B6QmR5ZHRYTzdO?=
 =?utf-8?B?MFpLcnh5bXljc2Q0dzBsdGpobEVrbDJLaWRYREQvK3o1dDhUcEp3YlpxQStq?=
 =?utf-8?B?bFFyaTFUVmtyeWNqejNGTVFsMDFjeWt6cHl4bW1FNXBtWWtJV0dXZzl2RTY0?=
 =?utf-8?B?NGZ1QksxUHNkYldaQjhtTlB2b2RVM0ptYVlVM0NUR2NZQ0ovbko2amJwRUpV?=
 =?utf-8?B?d2NuSTQzUUJqRUxZOUlRN2hreWRJbmFUK0lBbHNTMEFKRk95cUw4V3pGQTVu?=
 =?utf-8?B?a1BZZHpIVUNRbG4vUld4WER0WjFocU1WS2tldklCNHdLdk01OFkrZW9qTS9y?=
 =?utf-8?B?Q0NBdEplNzA2SkdRaE5zYXU2SmNaeW1wRTRaa0w1VVlJYzQzMVlScWdZMVMy?=
 =?utf-8?B?UnY3UWlwNjdocFpQVVlUZm1mVmJFdU5uVEdCMURJZFdLTFJ1YVBlVXlKeVpj?=
 =?utf-8?B?MnE4Y0Y0Z1Q3RHpZQ0dmc1p5anUwc29QQ0c5VVZQK3pXQk1IeENjMGsyMHdj?=
 =?utf-8?B?eVdmcWNEU1kxTmtIOXpYR1B1dlkyWTQ0QnpaWFlDQkpkOFhabnphOUR6S1Ja?=
 =?utf-8?B?c0d0Yk9jZko3Z25sNmRiVzJ6QzdNMFNBMFhGS0lRbExZaTlRd1J3WnBmTXp1?=
 =?utf-8?B?K1hkd0kzdVphRWhXeURBYlBhS1g4RW5EdGxJd283bWVHeWFxdTBCSGFDWEFq?=
 =?utf-8?B?SFZqU3l1dnFBcFI5d1g4VVN0ZVJYOEE2UE03YWpTMzFVamJjMGkzaTVCUHRw?=
 =?utf-8?B?WkJRRUhGZVl3MUFIT0lBZkM5enNBS0t5L0RtME4xcXUvTVBucDYxdG1PUDNF?=
 =?utf-8?B?VGNFKzBwTDhhNE9JVEFlN0RsR1FnaW5nSTdSSHp1OHlWeEVUMlVoQXhrY091?=
 =?utf-8?B?NllORGR5UDRnYmpWYlZpUVNDUDMrOVhzQUFpL3lRSk9XTm5lQVdoWjU4VlNp?=
 =?utf-8?B?eUYxUk1EUURtZE5sL2ZoZDl2NmROV1g1R3owTS8xeW1WNzhLNTczbmJ0ZUpK?=
 =?utf-8?B?L25CakFyNVEvbzQrMk1vL3p5SEdLVWRGcEpoUmp3dWt3ZGJ0aWhSVkJKRXR0?=
 =?utf-8?B?MjcwNmFtU0F5ckNHcW5ROGFpZGtONDNMY1RJSjNMUmRtcTlZSy9Gdi8yT2xj?=
 =?utf-8?B?Zm54TEsvN3VMM2NZaGVSOTlPaCs4ZmwzWlRrSGlCR2VrVG9BVGJtQjI1cmRi?=
 =?utf-8?B?S0NvNnhmN1YyMERJa1pzU0MyT0hSQmEvakU4b2pQZlZYZSsxQzdkR0YwekVF?=
 =?utf-8?B?ZG5Ya0VLQll3dTMvRkRBZmRFVlRwbVdyTGdLazlWS3oyMEQ1LzlFVzlqREtH?=
 =?utf-8?B?bURYU0xaTGVWNFFNeUpZWXlMRzVuRmJlVDF1ODdaMDdjb2F0bnNlWWJHZEpx?=
 =?utf-8?B?d3h1YjlJSEtnUVdjQ1QxckJUK29TVlF6SzhVSzVTN2ZZd1hLa2VLTWZuZGJZ?=
 =?utf-8?B?R1poK0ppRzFPaisyZmJTbkh0anYrbC85WkNVOWQ2eWJxSFhNeStuSExwT2Nj?=
 =?utf-8?B?VCt0U0VVdE5rdktuWUF6dFJESG4vblRTekZhNUNSUEFVUWpvZDBiY0hvb1l5?=
 =?utf-8?B?bE4xUHNzNVMzRFNocG4wdnordnRua0NCTzRFdFRCWmZGOVZHWlVPdmd6ckZn?=
 =?utf-8?B?Wnc9PQ==?=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 071cd7a4-0347-4c6a-3929-08d9f2a05fcb
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Feb 2022 05:34:46.4697
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: wv3GNbTzXAwdnPRDhrOM4RP0tK39ut+qQrVVUY+kWbI+k5t1/PIJeQlVSZ+PWm12ndQgwUorOClYFh7/qXsCXA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB2815
X-OriginatorOrg: intel.com

PiBGcm9tOiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+IFNlbnQ6IFRodXJzZGF5
LCBKYW51YXJ5IDI3LCAyMDIyIDEwOjQ4IFBNDQo+IA0KPiBUaGUgYWN0dWFsIGZ1bmN0aW9uIHNo
b3VsZCBhbHdheXMgaGF2ZSBsaXZlZCBpbiBjb3JlIHg4NiBjb2RlOyBtb3ZlIGl0DQo+IHRoZXJl
LCByZXBsYWNpbmcgZ2V0X2NhY2hlX2xpbmVfc2l6ZSgpIGJ5IHJlYWRpbHkgYXZhaWxhYmxlIChl
eGNlcHQgdmVyeQ0KPiBlYXJseSBkdXJpbmcgYm9vdDsgc2VlIHRoZSBjb2RlIGNvbW1lbnQpIGRh
dGEuIEFsc28gcmVuYW1lIHRoZSBmdW5jdGlvbi4NCj4gDQo+IERyb3AgdGhlIHJlc3BlY3RpdmUg
SU9NTVUgaG9vaywgKHJlKWludHJvZHVjaW5nIGEgcmVzcGVjdGl2ZSBib29sZWFuDQo+IGluc3Rl
YWQuIFJlcGxhY2UgYSB0cnVlIGFuZCBhbiBhbG1vc3Qgb3Blbi1jb2RpbmcgaW5zdGFuY2Ugb2YN
Cj4gaW9tbXVfc3luY19jYWNoZSgpLg0KPiANCj4gU2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2gg
PGpiZXVsaWNoQHN1c2UuY29tPg0KDQpSZXZpZXdlZC1ieTogS2V2aW4gVGlhbiA8a2V2aW4udGlh
bkBpbnRlbC5jb20+DQoNCj4gLS0tDQo+IFBsYWNpbmcgdGhlIGZ1bmN0aW9uIG5leHQgdG8gZmx1
c2hfYXJlYV9sb2NhbCgpIGV4cG9zZXMgYSBjdXJpb3VzDQo+IGFzeW1tZXRyeSBiZXR3ZWVuIHRo
ZSBTRkVOQ0UgcGxhY2VtZW50czogc3luY19jYWNoZSgpIGhhcyBpdCBhZnRlciB0aGUNCj4gZmx1
c2gsIHdoaWxlIGZsdXNoX2FyZWFfbG9jYWwoKSBoYXMgaXQgYmVmb3JlIGl0LiBJIHRoaW5rIHRo
ZSBsYXR0ZXIgb25lDQo+IGlzIG1pc3BsYWNlZC4NCj4gLS0tDQo+IHYyOiBSZW5hbWUgc3luY19j
YWNoZSgpIHRvIGNhY2hlX3dyaXRlYmFjaygpLg0KPiANCj4gLS0tIGEveGVuL2FyY2gveDg2L2Zs
dXNodGxiLmMNCj4gKysrIGIveGVuL2FyY2gveDg2L2ZsdXNodGxiLmMNCj4gQEAgLTExLDYgKzEx
LDcgQEANCj4gICNpbmNsdWRlIDx4ZW4vc2NoZWQuaD4NCj4gICNpbmNsdWRlIDx4ZW4vc21wLmg+
DQo+ICAjaW5jbHVkZSA8eGVuL3NvZnRpcnEuaD4NCj4gKyNpbmNsdWRlIDxhc20vY2FjaGUuaD4N
Cj4gICNpbmNsdWRlIDxhc20vZmx1c2h0bGIuaD4NCj4gICNpbmNsdWRlIDxhc20vaW52cGNpZC5o
Pg0KPiAgI2luY2x1ZGUgPGFzbS9ub3BzLmg+DQo+IEBAIC0yNjUsNiArMjY2LDU3IEBAIHVuc2ln
bmVkIGludCBmbHVzaF9hcmVhX2xvY2FsKGNvbnN0IHZvaWQNCj4gICAgICByZXR1cm4gZmxhZ3M7
DQo+ICB9DQo+IA0KPiArdm9pZCBjYWNoZV93cml0ZWJhY2soY29uc3Qgdm9pZCAqYWRkciwgdW5z
aWduZWQgaW50IHNpemUpDQo+ICt7DQo+ICsgICAgLyoNCj4gKyAgICAgKiBUaGlzIGZ1bmN0aW9u
IG1heSBiZSBjYWxsZWQgYmVmb3JlIGN1cnJlbnRfY3B1X2RhdGEgaXMgZXN0YWJsaXNoZWQuDQo+
ICsgICAgICogSGVuY2UgYSBmYWxsYmFjayBpcyBuZWVkZWQgdG8gcHJldmVudCB0aGUgbG9vcCBi
ZWxvdyBiZWNvbWluZyBpbmZpbml0ZS4NCj4gKyAgICAgKi8NCj4gKyAgICB1bnNpZ25lZCBpbnQg
Y2xmbHVzaF9zaXplID0gY3VycmVudF9jcHVfZGF0YS54ODZfY2xmbHVzaF9zaXplID86IDE2Ow0K
PiArICAgIGNvbnN0IHZvaWQgKmVuZCA9IGFkZHIgKyBzaXplOw0KPiArDQo+ICsgICAgYWRkciAt
PSAodW5zaWduZWQgbG9uZylhZGRyICYgKGNsZmx1c2hfc2l6ZSAtIDEpOw0KPiArICAgIGZvciAo
IDsgYWRkciA8IGVuZDsgYWRkciArPSBjbGZsdXNoX3NpemUgKQ0KPiArICAgIHsNCj4gKy8qDQo+
ICsgKiBUaGUgYXJndW1lbnRzIHRvIGEgbWFjcm8gbXVzdCBub3QgaW5jbHVkZSBwcmVwcm9jZXNz
b3IgZGlyZWN0aXZlcy4NCj4gRG9pbmcgc28NCj4gKyAqIHJlc3VsdHMgaW4gdW5kZWZpbmVkIGJl
aGF2aW9yLCBzbyB3ZSBoYXZlIHRvIGNyZWF0ZSBzb21lIGRlZmluZXMgaGVyZSBpbg0KPiArICog
b3JkZXIgdG8gYXZvaWQgaXQuDQo+ICsgKi8NCj4gKyNpZiBkZWZpbmVkKEhBVkVfQVNfQ0xXQikN
Cj4gKyMgZGVmaW5lIENMV0JfRU5DT0RJTkcgImNsd2IgJVtwXSINCj4gKyNlbGlmIGRlZmluZWQo
SEFWRV9BU19YU0FWRU9QVCkNCj4gKyMgZGVmaW5lIENMV0JfRU5DT0RJTkcgImRhdGExNiB4c2F2
ZW9wdCAlW3BdIiAvKiBjbHdiICovDQo+ICsjZWxzZQ0KPiArIyBkZWZpbmUgQ0xXQl9FTkNPRElO
RyAiLmJ5dGUgMHg2NiwgMHgwZiwgMHhhZSwgMHgzMCIgLyogY2x3YiAoJSVyYXgpDQo+ICovDQo+
ICsjZW5kaWYNCj4gKw0KPiArI2RlZmluZSBCQVNFX0lOUFVUKGFkZHIpIFtwXSAibSIgKCooY29u
c3QgY2hhciAqKShhZGRyKSkNCj4gKyNpZiBkZWZpbmVkKEhBVkVfQVNfQ0xXQikgfHwgZGVmaW5l
ZChIQVZFX0FTX1hTQVZFT1BUKQ0KPiArIyBkZWZpbmUgSU5QVVQgQkFTRV9JTlBVVA0KPiArI2Vs
c2UNCj4gKyMgZGVmaW5lIElOUFVUKGFkZHIpICJhIiAoYWRkciksIEJBU0VfSU5QVVQoYWRkcikN
Cj4gKyNlbmRpZg0KPiArICAgICAgICAvKg0KPiArICAgICAgICAgKiBOb3RlIHJlZ2FyZGluZyB0
aGUgdXNlIG9mIE5PUF9EU19QUkVGSVg6IGl0J3MgZmFzdGVyIHRvIGRvIGEgY2xmbHVzaA0KPiAr
ICAgICAgICAgKiArIHByZWZpeCB0aGFuIGEgY2xmbHVzaCArIG5vcCwgYW5kIGhlbmNlIHRoZSBw
cmVmaXggaXMgYWRkZWQgaW5zdGVhZA0KPiArICAgICAgICAgKiBvZiBsZXR0aW5nIHRoZSBhbHRl
cm5hdGl2ZSBmcmFtZXdvcmsgZmlsbCB0aGUgZ2FwIGJ5IGFwcGVuZGluZyBub3BzLg0KPiArICAg
ICAgICAgKi8NCj4gKyAgICAgICAgYWx0ZXJuYXRpdmVfaW9fMigiLmJ5dGUgIiBfX3N0cmluZ2lm
eShOT1BfRFNfUFJFRklYKSAiOyBjbGZsdXNoICVbcF0iLA0KPiArICAgICAgICAgICAgICAgICAg
ICAgICAgICJkYXRhMTYgY2xmbHVzaCAlW3BdIiwgLyogY2xmbHVzaG9wdCAqLw0KPiArICAgICAg
ICAgICAgICAgICAgICAgICAgIFg4Nl9GRUFUVVJFX0NMRkxVU0hPUFQsDQo+ICsgICAgICAgICAg
ICAgICAgICAgICAgICAgQ0xXQl9FTkNPRElORywNCj4gKyAgICAgICAgICAgICAgICAgICAgICAg
ICBYODZfRkVBVFVSRV9DTFdCLCAvKiBubyBvdXRwdXRzICovLA0KPiArICAgICAgICAgICAgICAg
ICAgICAgICAgIElOUFVUKGFkZHIpKTsNCj4gKyN1bmRlZiBJTlBVVA0KPiArI3VuZGVmIEJBU0Vf
SU5QVVQNCj4gKyN1bmRlZiBDTFdCX0VOQ09ESU5HDQo+ICsgICAgfQ0KPiArDQo+ICsgICAgYWx0
ZXJuYXRpdmVfMigiIiwgInNmZW5jZSIsIFg4Nl9GRUFUVVJFX0NMRkxVU0hPUFQsDQo+ICsgICAg
ICAgICAgICAgICAgICAgICAgInNmZW5jZSIsIFg4Nl9GRUFUVVJFX0NMV0IpOw0KPiArfQ0KPiAr
DQo+ICB1bnNpZ25lZCBpbnQgZ3Vlc3RfZmx1c2hfdGxiX2ZsYWdzKGNvbnN0IHN0cnVjdCBkb21h
aW4gKmQpDQo+ICB7DQo+ICAgICAgYm9vbCBzaGFkb3cgPSBwYWdpbmdfbW9kZV9zaGFkb3coZCk7
DQo+IC0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3Z0ZC9pb21tdS5jDQo+ICsrKyBiL3hl
bi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3Z0ZC9pb21tdS5jDQo+IEBAIC0yNDAsNTQgKzI0MCw2IEBA
IGRvbWlkX3QgZGlkX3RvX2RvbWFpbl9pZChjb25zdCBzdHJ1Y3QgdnQNCj4gICAgICByZXR1cm4g
aW9tbXUtPmRvbWlkX21hcFtkaWRdOw0KPiAgfQ0KPiANCj4gLXN0YXRpYyB2b2lkIHN5bmNfY2Fj
aGUoY29uc3Qgdm9pZCAqYWRkciwgdW5zaWduZWQgaW50IHNpemUpDQo+IC17DQo+IC0gICAgc3Rh
dGljIHVuc2lnbmVkIGxvbmcgY2xmbHVzaF9zaXplID0gMDsNCj4gLSAgICBjb25zdCB2b2lkICpl
bmQgPSBhZGRyICsgc2l6ZTsNCj4gLQ0KPiAtICAgIGlmICggY2xmbHVzaF9zaXplID09IDAgKQ0K
PiAtICAgICAgICBjbGZsdXNoX3NpemUgPSBnZXRfY2FjaGVfbGluZV9zaXplKCk7DQo+IC0NCj4g
LSAgICBhZGRyIC09ICh1bnNpZ25lZCBsb25nKWFkZHIgJiAoY2xmbHVzaF9zaXplIC0gMSk7DQo+
IC0gICAgZm9yICggOyBhZGRyIDwgZW5kOyBhZGRyICs9IGNsZmx1c2hfc2l6ZSApDQo+IC0vKg0K
PiAtICogVGhlIGFyZ3VtZW50cyB0byBhIG1hY3JvIG11c3Qgbm90IGluY2x1ZGUgcHJlcHJvY2Vz
c29yIGRpcmVjdGl2ZXMuDQo+IERvaW5nIHNvDQo+IC0gKiByZXN1bHRzIGluIHVuZGVmaW5lZCBi
ZWhhdmlvciwgc28gd2UgaGF2ZSB0byBjcmVhdGUgc29tZSBkZWZpbmVzIGhlcmUgaW4NCj4gLSAq
IG9yZGVyIHRvIGF2b2lkIGl0Lg0KPiAtICovDQo+IC0jaWYgZGVmaW5lZChIQVZFX0FTX0NMV0Ip
DQo+IC0jIGRlZmluZSBDTFdCX0VOQ09ESU5HICJjbHdiICVbcF0iDQo+IC0jZWxpZiBkZWZpbmVk
KEhBVkVfQVNfWFNBVkVPUFQpDQo+IC0jIGRlZmluZSBDTFdCX0VOQ09ESU5HICJkYXRhMTYgeHNh
dmVvcHQgJVtwXSIgLyogY2x3YiAqLw0KPiAtI2Vsc2UNCj4gLSMgZGVmaW5lIENMV0JfRU5DT0RJ
TkcgIi5ieXRlIDB4NjYsIDB4MGYsIDB4YWUsIDB4MzAiIC8qIGNsd2IgKCUlcmF4KSAqLw0KPiAt
I2VuZGlmDQo+IC0NCj4gLSNkZWZpbmUgQkFTRV9JTlBVVChhZGRyKSBbcF0gIm0iICgqKGNvbnN0
IGNoYXIgKikoYWRkcikpDQo+IC0jaWYgZGVmaW5lZChIQVZFX0FTX0NMV0IpIHx8IGRlZmluZWQo
SEFWRV9BU19YU0FWRU9QVCkNCj4gLSMgZGVmaW5lIElOUFVUIEJBU0VfSU5QVVQNCj4gLSNlbHNl
DQo+IC0jIGRlZmluZSBJTlBVVChhZGRyKSAiYSIgKGFkZHIpLCBCQVNFX0lOUFVUKGFkZHIpDQo+
IC0jZW5kaWYNCj4gLSAgICAgICAgLyoNCj4gLSAgICAgICAgICogTm90ZSByZWdhcmRpbmcgdGhl
IHVzZSBvZiBOT1BfRFNfUFJFRklYOiBpdCdzIGZhc3RlciB0byBkbyBhIGNsZmx1c2gNCj4gLSAg
ICAgICAgICogKyBwcmVmaXggdGhhbiBhIGNsZmx1c2ggKyBub3AsIGFuZCBoZW5jZSB0aGUgcHJl
Zml4IGlzIGFkZGVkIGluc3RlYWQNCj4gLSAgICAgICAgICogb2YgbGV0dGluZyB0aGUgYWx0ZXJu
YXRpdmUgZnJhbWV3b3JrIGZpbGwgdGhlIGdhcCBieSBhcHBlbmRpbmcgbm9wcy4NCj4gLSAgICAg
ICAgICovDQo+IC0gICAgICAgIGFsdGVybmF0aXZlX2lvXzIoIi5ieXRlICIgX19zdHJpbmdpZnko
Tk9QX0RTX1BSRUZJWCkgIjsgY2xmbHVzaCAlW3BdIiwNCj4gLSAgICAgICAgICAgICAgICAgICAg
ICAgICAiZGF0YTE2IGNsZmx1c2ggJVtwXSIsIC8qIGNsZmx1c2hvcHQgKi8NCj4gLSAgICAgICAg
ICAgICAgICAgICAgICAgICBYODZfRkVBVFVSRV9DTEZMVVNIT1BULA0KPiAtICAgICAgICAgICAg
ICAgICAgICAgICAgIENMV0JfRU5DT0RJTkcsDQo+IC0gICAgICAgICAgICAgICAgICAgICAgICAg
WDg2X0ZFQVRVUkVfQ0xXQiwgLyogbm8gb3V0cHV0cyAqLywNCj4gLSAgICAgICAgICAgICAgICAg
ICAgICAgICBJTlBVVChhZGRyKSk7DQo+IC0jdW5kZWYgSU5QVVQNCj4gLSN1bmRlZiBCQVNFX0lO
UFVUDQo+IC0jdW5kZWYgQ0xXQl9FTkNPRElORw0KPiAtDQo+IC0gICAgYWx0ZXJuYXRpdmVfMigi
IiwgInNmZW5jZSIsIFg4Nl9GRUFUVVJFX0NMRkxVU0hPUFQsDQo+IC0gICAgICAgICAgICAgICAg
ICAgICAgInNmZW5jZSIsIFg4Nl9GRUFUVVJFX0NMV0IpOw0KPiAtfQ0KPiAtDQo+ICAvKiBBbGxv
Y2F0ZSBwYWdlIHRhYmxlLCByZXR1cm4gaXRzIG1hY2hpbmUgYWRkcmVzcyAqLw0KPiAgdWludDY0
X3QgYWxsb2NfcGd0YWJsZV9tYWRkcih1bnNpZ25lZCBsb25nIG5wYWdlcywgbm9kZWlkX3Qgbm9k
ZSkNCj4gIHsNCj4gQEAgLTMwNiw4ICsyNTgsNyBAQCB1aW50NjRfdCBhbGxvY19wZ3RhYmxlX21h
ZGRyKHVuc2lnbmVkIGxvDQo+IA0KPiAgICAgICAgICBjbGVhcl9wYWdlKHZhZGRyKTsNCj4gDQo+
IC0gICAgICAgIGlmICggKGlvbW11X29wcy5pbml0ID8gJmlvbW11X29wcyA6ICZ2dGRfb3BzKS0+
c3luY19jYWNoZSApDQo+IC0gICAgICAgICAgICBzeW5jX2NhY2hlKHZhZGRyLCBQQUdFX1NJWkUp
Ow0KPiArICAgICAgICBpb21tdV9zeW5jX2NhY2hlKHZhZGRyLCBQQUdFX1NJWkUpOw0KPiAgICAg
ICAgICB1bm1hcF9kb21haW5fcGFnZSh2YWRkcik7DQo+ICAgICAgICAgIGN1cl9wZysrOw0KPiAg
ICAgIH0NCj4gQEAgLTEzMjcsNyArMTI3OCw3IEBAIGludCBfX2luaXQgaW9tbXVfYWxsb2Moc3Ry
dWN0IGFjcGlfZHJoZF8NCj4gICAgICBpb21tdS0+bnJfcHRfbGV2ZWxzID0gYWdhd190b19sZXZl
bChhZ2F3KTsNCj4gDQo+ICAgICAgaWYgKCAhZWNhcF9jb2hlcmVudChpb21tdS0+ZWNhcCkgKQ0K
PiAtICAgICAgICB2dGRfb3BzLnN5bmNfY2FjaGUgPSBzeW5jX2NhY2hlOw0KPiArICAgICAgICBp
b21tdV9ub25fY29oZXJlbnQgPSB0cnVlOw0KPiANCj4gICAgICBucl9kb20gPSBjYXBfbmRvbXMo
aW9tbXUtPmNhcCk7DQo+IA0KPiAtLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC94ODYvaW9t
bXUuYw0KPiArKysgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC94ODYvaW9tbXUuYw0KPiBAQCAt
MjgsNiArMjgsNyBAQA0KPiANCj4gIGNvbnN0IHN0cnVjdCBpb21tdV9pbml0X29wcyAqX19pbml0
ZGF0YSBpb21tdV9pbml0X29wczsNCj4gIHN0cnVjdCBpb21tdV9vcHMgX19yZWFkX21vc3RseSBp
b21tdV9vcHM7DQo+ICtib29sIF9fcmVhZF9tb3N0bHkgaW9tbXVfbm9uX2NvaGVyZW50Ow0KPiAN
Cj4gIGVudW0gaW9tbXVfaW50cmVtYXAgX19yZWFkX21vc3RseSBpb21tdV9pbnRyZW1hcCA9DQo+
IGlvbW11X2ludHJlbWFwX2Z1bGw7DQo+IA0KPiBAQCAtNDM4LDggKzQzOSw3IEBAIHN0cnVjdCBw
YWdlX2luZm8gKmlvbW11X2FsbG9jX3BndGFibGUoc3QNCj4gICAgICBwID0gX19tYXBfZG9tYWlu
X3BhZ2UocGcpOw0KPiAgICAgIGNsZWFyX3BhZ2UocCk7DQo+IA0KPiAtICAgIGlmICggaGQtPnBs
YXRmb3JtX29wcy0+c3luY19jYWNoZSApDQo+IC0gICAgICAgIGlvbW11X3ZjYWxsKGhkLT5wbGF0
Zm9ybV9vcHMsIHN5bmNfY2FjaGUsIHAsIFBBR0VfU0laRSk7DQo+ICsgICAgaW9tbXVfc3luY19j
YWNoZShwLCBQQUdFX1NJWkUpOw0KPiANCj4gICAgICB1bm1hcF9kb21haW5fcGFnZShwKTsNCj4g
DQo+IC0tLSBhL3hlbi9hcmNoL3g4Ni9pbmNsdWRlL2FzbS9jYWNoZS5oDQo+ICsrKyBiL3hlbi9h
cmNoL3g4Ni9pbmNsdWRlL2FzbS9jYWNoZS5oDQo+IEBAIC0xMSw0ICsxMSwxMCBAQA0KPiANCj4g
ICNkZWZpbmUgX19yZWFkX21vc3RseSBfX3NlY3Rpb24oIi5kYXRhLnJlYWRfbW9zdGx5IikNCj4g
DQo+ICsjaWZuZGVmIF9fQVNTRU1CTFlfXw0KPiArDQo+ICt2b2lkIGNhY2hlX3dyaXRlYmFjayhj
b25zdCB2b2lkICphZGRyLCB1bnNpZ25lZCBpbnQgc2l6ZSk7DQo+ICsNCj4gKyNlbmRpZg0KPiAr
DQo+ICAjZW5kaWYNCj4gLS0tIGEveGVuL2FyY2gveDg2L2luY2x1ZGUvYXNtL2lvbW11LmgNCj4g
KysrIGIveGVuL2FyY2gveDg2L2luY2x1ZGUvYXNtL2lvbW11LmgNCj4gQEAgLTE5LDYgKzE5LDcg
QEANCj4gICNpbmNsdWRlIDx4ZW4vbWVtX2FjY2Vzcy5oPg0KPiAgI2luY2x1ZGUgPHhlbi9zcGlu
bG9jay5oPg0KPiAgI2luY2x1ZGUgPGFzbS9hcGljZGVmLmg+DQo+ICsjaW5jbHVkZSA8YXNtL2Nh
Y2hlLmg+DQo+ICAjaW5jbHVkZSA8YXNtL3Byb2Nlc3Nvci5oPg0KPiAgI2luY2x1ZGUgPGFzbS9o
dm0vdm14L3ZtY3MuaD4NCj4gDQo+IEBAIC0xMzQsMTIgKzEzNSwxMyBAQCBleHRlcm4gYm9vbCB1
bnRydXN0ZWRfbXNpOw0KPiAgaW50IHBpX3VwZGF0ZV9pcnRlKGNvbnN0IHN0cnVjdCBwaV9kZXNj
ICpwaV9kZXNjLCBjb25zdCBzdHJ1Y3QgcGlycSAqcGlycSwNCj4gICAgICAgICAgICAgICAgICAg
ICBjb25zdCB1aW50OF90IGd2ZWMpOw0KPiANCj4gLSNkZWZpbmUgaW9tbXVfc3luY19jYWNoZShh
ZGRyLCBzaXplKSAoeyAgICAgICAgICAgICAgICAgXA0KPiAtICAgIGNvbnN0IHN0cnVjdCBpb21t
dV9vcHMgKm9wcyA9IGlvbW11X2dldF9vcHMoKTsgICAgICBcDQo+IC0gICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFwNCj4gLSAgICBpZiAoIG9w
cy0+c3luY19jYWNoZSApICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXA0KPiAtICAgICAg
ICBpb21tdV92Y2FsbChvcHMsIHN5bmNfY2FjaGUsIGFkZHIsIHNpemUpOyAgICAgICBcDQo+IC19
KQ0KPiArZXh0ZXJuIGJvb2wgaW9tbXVfbm9uX2NvaGVyZW50Ow0KPiArDQo+ICtzdGF0aWMgaW5s
aW5lIHZvaWQgaW9tbXVfc3luY19jYWNoZShjb25zdCB2b2lkICphZGRyLCB1bnNpZ25lZCBpbnQg
c2l6ZSkNCj4gK3sNCj4gKyAgICBpZiAoIGlvbW11X25vbl9jb2hlcmVudCApDQo+ICsgICAgICAg
IGNhY2hlX3dyaXRlYmFjayhhZGRyLCBzaXplKTsNCj4gK30NCj4gDQo+ICBpbnQgX19tdXN0X2No
ZWNrIGlvbW11X2ZyZWVfcGd0YWJsZXMoc3RydWN0IGRvbWFpbiAqZCk7DQo+ICBzdHJ1Y3QgcGFn
ZV9pbmZvICpfX211c3RfY2hlY2sgaW9tbXVfYWxsb2NfcGd0YWJsZShzdHJ1Y3QgZG9tYWluICpk
KTsNCj4gLS0tIGEveGVuL2luY2x1ZGUveGVuL2lvbW11LmgNCj4gKysrIGIveGVuL2luY2x1ZGUv
eGVuL2lvbW11LmgNCj4gQEAgLTI2OCw3ICsyNjgsNiBAQCBzdHJ1Y3QgaW9tbXVfb3BzIHsNCj4g
ICAgICBpbnQgKCpzZXR1cF9ocGV0X21zaSkoc3RydWN0IG1zaV9kZXNjICopOw0KPiANCj4gICAg
ICBpbnQgKCphZGp1c3RfaXJxX2FmZmluaXRpZXMpKHZvaWQpOw0KPiAtICAgIHZvaWQgKCpzeW5j
X2NhY2hlKShjb25zdCB2b2lkICphZGRyLCB1bnNpZ25lZCBpbnQgc2l6ZSk7DQo+ICAgICAgdm9p
ZCAoKmNsZWFyX3Jvb3RfcGd0YWJsZSkoc3RydWN0IGRvbWFpbiAqZCk7DQo+ICAgICAgaW50ICgq
dXBkYXRlX2lyZV9mcm9tX21zaSkoc3RydWN0IG1zaV9kZXNjICptc2lfZGVzYywgc3RydWN0IG1z
aV9tc2cNCj4gKm1zZyk7DQo+ICAjZW5kaWYgLyogQ09ORklHX1g4NiAqLw0KPiAtLS0gYS94ZW4v
ZHJpdmVycy9wYXNzdGhyb3VnaC92dGQvZXh0ZXJuLmgNCj4gKysrIGIveGVuL2RyaXZlcnMvcGFz
c3Rocm91Z2gvdnRkL2V4dGVybi5oDQo+IEBAIC03OCw3ICs3OCw2IEBAIGludCBfX211c3RfY2hl
Y2sgcWludmFsX2RldmljZV9pb3RsYl9zeW4NCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgIHN0cnVjdCBwY2lfZGV2ICpwZGV2LA0KPiAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgdTE2IGRpZCwgdTE2IHNpemUsIHU2NCBhZGRyKTsN
Cj4gDQo+IC11bnNpZ25lZCBpbnQgZ2V0X2NhY2hlX2xpbmVfc2l6ZSh2b2lkKTsNCj4gIHZvaWQg
Zmx1c2hfYWxsX2NhY2hlKHZvaWQpOw0KPiANCj4gIHVpbnQ2NF90IGFsbG9jX3BndGFibGVfbWFk
ZHIodW5zaWduZWQgbG9uZyBucGFnZXMsIG5vZGVpZF90IG5vZGUpOw0KPiAtLS0gYS94ZW4vZHJp
dmVycy9wYXNzdGhyb3VnaC92dGQveDg2L3Z0ZC5jDQo+ICsrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0
aHJvdWdoL3Z0ZC94ODYvdnRkLmMNCj4gQEAgLTQ3LDExICs0Nyw2IEBAIHZvaWQgdW5tYXBfdnRk
X2RvbWFpbl9wYWdlKGNvbnN0IHZvaWQgKnYNCj4gICAgICB1bm1hcF9kb21haW5fcGFnZSh2YSk7
DQo+ICB9DQo+IA0KPiAtdW5zaWduZWQgaW50IGdldF9jYWNoZV9saW5lX3NpemUodm9pZCkNCj4g
LXsNCj4gLSAgICByZXR1cm4gKChjcHVpZF9lYngoMSkgPj4gOCkgJiAweGZmKSAqIDg7DQo+IC19
DQo+IC0NCj4gIHZvaWQgZmx1c2hfYWxsX2NhY2hlKCkNCj4gIHsNCj4gICAgICB3YmludmQoKTsN
Cg0K


From xen-devel-bounces@lists.xenproject.org Fri Feb 18 05:35:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 18 Feb 2022 05:35:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275122.470846 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKvvb-0000Xw-FB; Fri, 18 Feb 2022 05:35:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275122.470846; Fri, 18 Feb 2022 05:35:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKvvb-0000Xp-AT; Fri, 18 Feb 2022 05:35:35 +0000
Received: by outflank-mailman (input) for mailman id 275122;
 Fri, 18 Feb 2022 05:35:34 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qkm2=TB=intel.com=kevin.tian@srs-se1.protection.inumbo.net>)
 id 1nKvvZ-0000Ta-ON
 for xen-devel@lists.xenproject.org; Fri, 18 Feb 2022 05:35:33 +0000
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 95dc2160-907c-11ec-8723-dd0c611c5f35;
 Fri, 18 Feb 2022 06:35:32 +0100 (CET)
Received: from fmsmga006.fm.intel.com ([10.253.24.20])
 by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 17 Feb 2022 21:35:29 -0800
Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16])
 by fmsmga006.fm.intel.com with ESMTP; 17 Feb 2022 21:35:29 -0800
Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by
 ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.20; Thu, 17 Feb 2022 21:35:28 -0800
Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by
 ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.20; Thu, 17 Feb 2022 21:35:28 -0800
Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by
 orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.20 via Frontend Transport; Thu, 17 Feb 2022 21:35:28 -0800
Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.177)
 by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.1.2308.20; Thu, 17 Feb 2022 21:35:27 -0800
Received: from BN9PR11MB5276.namprd11.prod.outlook.com (2603:10b6:408:135::18)
 by SN6PR11MB2815.namprd11.prod.outlook.com (2603:10b6:805:62::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.15; Fri, 18 Feb
 2022 05:35:26 +0000
Received: from BN9PR11MB5276.namprd11.prod.outlook.com
 ([fe80::f514:7aae:315b:4d8d]) by BN9PR11MB5276.namprd11.prod.outlook.com
 ([fe80::f514:7aae:315b:4d8d%3]) with mapi id 15.20.4995.016; Fri, 18 Feb 2022
 05:35:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 95dc2160-907c-11ec-8723-dd0c611c5f35
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
  d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
  t=1645162532; x=1676698532;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-transfer-encoding:mime-version;
  bh=KjN3JFxacm4iP65kvUanE9pOzvfIR6bD9mkByBqe6Hg=;
  b=jueK1+8l01tjjs37B3mSG5tbFMh5sIpFOCeD+HC5vdgl/ODMpME2ZYrc
   dNzb2kjlnVqkX3isMwaYQzh+4LNjz3bbzDslqTfIexcutMREchMeLzZ6g
   +StmGhaTpkGvB5M49urDH0+ILdZCPswShJrNEys4v/ICk0dh71XBLOjuL
   9QEoidIdnp1OWqa08JuhddPfVacFgeGP9onLzi25XXCw/rHnuwKc/NyrS
   HjVtDAsc0UbZX4DrKPGE2mO+1cULaYjtKOKzGiYjrVOAihZx5/TNh8CTC
   JCt5xkFl6/yzeegpQ9nYBU6+z6zVt8Oa9MtPJDcjmT4vgyz0soXG8Ooex
   Q==;
X-IronPort-AV: E=McAfee;i="6200,9189,10261"; a="238460050"
X-IronPort-AV: E=Sophos;i="5.88,377,1635231600"; 
   d="scan'208";a="238460050"
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.88,377,1635231600"; 
   d="scan'208";a="775182339"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=bNTY3VcvPLdGdYpIH2fDKLLrIt1QpnxGZIM+QKxNxU9FgqbwpuAQ8/90olJgq6KvwBciCHmLFyWA2/a5ibPNLZ7sERxa37R5UjrgNZsTVVkjCISc3ZrHMvMoSSMHjMDsScF01Ye/AbLL1181Kxns+1RqDmfSFA4M1XTHPzYOiELM/v2BD1HXl/GNgwCG36TMXa5r0L2H03maDkDoxJtO0RP2BWfy4i0tRvgx9uUx1rD/kaL7zWD5/+XiQBFKs9V8gEGuDzB16nMMdKGqFrPFFQDwfaG6DLFxMjg4ZbhnQWo6HeWWHUHqU4NIu8BG8SQnG8ns1gBMBWq81oINORnyeg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=KjN3JFxacm4iP65kvUanE9pOzvfIR6bD9mkByBqe6Hg=;
 b=f9u1xTln6zEo1xBXr1UqJiKnKK2EwvMzHhNX9PvkVN3cYtgmn29yF+TJ2wwNtn/SyKqCx+cc6z2QI3i0X8iHCy5a9xCoHFxp5+PBQ6xtQNwzC/r9LvvyErUqV3XImjZg/8CXxpqz4de5q0sgHjk+G7eyOv4OE34MV7mQ6kIlvwxcwOJMsQpGhqyzURiu3JJv1TiXqHCfmt0Uhlb6DwPOEbNyD/WF//b9INQWEDLOj5aFt8u+hsvXmuvNu/PxzXnUhDMvuFxwWKklu2fmXPqssOK2j0BcO9sDf5uC//vn5hZE64xjHER+d1agN6p6JoHwodOA7Gk8Fv1Wke/1P5zRyg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
From: "Tian, Kevin" <kevin.tian@intel.com>
To: "Beulich, Jan" <JBeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Paul Durrant <paul@xen.org>, "Cooper, Andrew" <andrew.cooper3@citrix.com>
Subject: RE: [PATCH v2 3/4] VT-d: replace flush_all_cache()
Thread-Topic: [PATCH v2 3/4] VT-d: replace flush_all_cache()
Thread-Index: AQHYE40cwzioqi7zCkCsPderd+h65ayY62ww
Date: Fri, 18 Feb 2022 05:35:26 +0000
Message-ID: <BN9PR11MB52761F4D52321571162676A28C379@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <4b7db7ae-eb84-7ecc-4334-fe5f0f7ef46b@suse.com>
 <2a39cb48-7d38-6d7e-0557-fd93d377a31b@suse.com>
In-Reply-To: <2a39cb48-7d38-6d7e-0557-fd93d377a31b@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=intel.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 415608c9-0efb-4693-84d5-08d9f2a0776b
x-ms-traffictypediagnostic: SN6PR11MB2815:EE_
x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr
x-microsoft-antispam-prvs: <SN6PR11MB28151829A74CFE4380612E2F8C379@SN6PR11MB2815.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:1468;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: uv8S+nGscO5qaj64mqXCyNNaqXi142l2CM3Na6lLsznIBO/Fi3wkXtjZEcomhDln4hO66jIIBR6TmofbcqYZlPX3Ambs6kOrc/yITv4XbutZ5GVFZW9wd40hH4U9XJiMUmvI8wZ37SmeftjajzXVVseeVsta1yTvsyC4W2iJ7xlBVaL7gYy4+JCEZ0wF0b99eoLMz1JdjITZDAUPlHXEf9n+itVKvIuxdIecVFqLnLUebxbwxjI9z7ZZiv1kpmSMzDkd2yVLoS2AY+BJcHDN1kkZ/3Dap1uS8DnOSfTvOBMoOABPxHtr6rpMaDx11sUP08iR+vMzyHBq3rJBPC/CpoAdCsjyVcStOUC5joFHSnpim8lwnY1juF87k1beVh/eR2YFmd2OZRZMhwJJkLgj0HzbGQDfiCGS6IgxTVWtYaf2n3khJi+CRvIUZ12p5WK/RWZMfkR4rZ2HVczV/uSQJmVKpXzIDi2bjTBCfkMthkQhNd38oQ85RywZEYy18moqMcdJIoJds0cl79HCVOZ+9tGSiLTEwizlD6OOpClkDz6gMg+Dao5AsOHihmZhKrR4w3f0AA38e25JhYJQ8NlHYnXxIk5jOZsp3qKbuLtwcsPh7RIHb3CHhnoDAeJAqu5z5ke+WAmlRuUhBIQeWbCPa4ZFU1lkUgbhpZ33aiVaA6niClVEB4TS7mv57uRL6mVO6YqyeHEHLVR4b7aMaNNHQA==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5276.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8676002)(38100700002)(66446008)(71200400001)(38070700005)(64756008)(26005)(186003)(66476007)(122000001)(82960400001)(4326008)(66946007)(2906002)(508600001)(86362001)(110136005)(54906003)(9686003)(5660300002)(8936002)(66556008)(316002)(33656002)(7696005)(76116006)(52536014)(55016003)(6506007);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?OEdUbXozRmNROG9lN0VTQTRKZHBuOFhJb0VTNHFJRWJzRERqUnVpbkN0WEFu?=
 =?utf-8?B?ZGZtRlVaaW5jMU9ZZURLeVRPWXA5cUhrRXRVM2FkR2t1NmErN1RaU2praHVP?=
 =?utf-8?B?eEg2cXA5KzBTRkZyQkVPdHFBdE55a2FOTmdGdlp6WEt3OXgwMWRsbU9BZFRW?=
 =?utf-8?B?UGNKcVVnRkZOOVY3S05CYUhyc09kTHA3SlVHSHR1a3pZZzdZQzFpalRQQk5q?=
 =?utf-8?B?N0hrWDNZL0hDakFqd0NxVDdBYVJ0aldjWnh3bXA3Wk5acjBYR1Q4VmNzTEdo?=
 =?utf-8?B?S1p0WW5YaDVyYjVLUERCQUMwMWZZazlpMHZ1U2tDS2ErSWUrbytobWJobElV?=
 =?utf-8?B?VzhXYlNIWE9Jd1FRZDZGditqVVViYW5mVURTQ3dlL09OV3Z3TVVDRnYyaHFY?=
 =?utf-8?B?UzZKNjhxbG4zTUZZTS9veVIxMThDSFhaU2ozMGQ0c3EvOXVCK3BYKyt3aitz?=
 =?utf-8?B?NnU4Vzl0N3BBdWo2UFBHTmswU0x6d0tpQklWa1F2YTNIK3RyQWUvYkNrNkR4?=
 =?utf-8?B?cVpVU2ZwZG91aDhROFkxNGtkVWRKekl5WmVuR21yZGh6RU9NQWMrYUJidERa?=
 =?utf-8?B?cXlmb0gvSW5adW1XOVFlUVBqQTBOQWJmVHVBVFE3NGhTdmU2VUNMTTlMc0Fl?=
 =?utf-8?B?RnE0R3daN0NONGRra01jN0xaUUlIREhFUnNlcm9BQlB5L3Yydk9LN1lpQnZR?=
 =?utf-8?B?QlZpSTc4cVhDcWFmQm1XaVpHZlJhazZTOC9ZVStyc1VRWkdhSTcwYmtCaExm?=
 =?utf-8?B?TnVyQjdoQXNITDc2WEtEclpQQlZVYU8vRU4yT216aytINkpTTjlCUkNpWUJz?=
 =?utf-8?B?TUFnYUhjRDhDaVZLWnpObXNib09QK3BESjNCLzA0Q2cydndyTi9sWllwMjM2?=
 =?utf-8?B?bHpwTW9LOEtKZ080RFlDWk92Uk4vN1ZvdFNhejlVV21NaGd3amdvTk1Gc0pv?=
 =?utf-8?B?NDVxTGU1OEprY1piMGdVL3Rxdm1CdFZIcTRNaHVIQ251WEdmVVJXbWZRLzM1?=
 =?utf-8?B?WWRjcld4eFJWNWFGeFE2bnk3MlpOenErZTc0cTBxd3ZtejZ6RlgxREk2amFK?=
 =?utf-8?B?VlVTakx6Qy9ZMCtSU1NtSW9tcXJnakNwRVNRWTBxendEL3MrdjRRQjM0OEF2?=
 =?utf-8?B?UUcxc0lZajRVTUovdDNWTmM5S0svaHFYMDBjMWh1dzRZZUdsenhGZWxSb2Nn?=
 =?utf-8?B?T0NLUzFNdXBhSERYS1c2WFYzZ2NvNTRoR1pRQTh5eE1DMDErNkN5aGl4dlF2?=
 =?utf-8?B?VDNKcGtOZDFBODBZTHNZNkErbVdvdGJvaDQ5RGFydFFaOWFLZi9DOVphNDA3?=
 =?utf-8?B?QlJZWmticmxqK0JaVlVCTWlZcm9iMGU0ZWYvK01QNldCWHR4V2JSZHE1M0M2?=
 =?utf-8?B?ZzUxN0ZweW45dG03Uld3NXlidnI4WEtBNFFlZ2tLQmhsRzlma2hGU0NnZ3Mr?=
 =?utf-8?B?N0tpZWJ6Snpib1E5ZC8zTVhnNFgrUDN0SXI4N2h5UkhJd3FxUkFhQ0dMbUpo?=
 =?utf-8?B?VE9UMFZaMUdxeE53a3FmZzVnRStwa0U5d2wxbHlCbUFHZ25vcS9lMVhGSy9S?=
 =?utf-8?B?ZDNRcWJnVElINVl1NUdIR040WTBoTk1FcFQ2K3dRWm85WXJpRXcyREFuM0Qv?=
 =?utf-8?B?emZwVjNFSWMybGxyUG5Bc0R3WWRaSkM1dXBjNC8vQ1VEcWRINWsvbjRhMnU1?=
 =?utf-8?B?S2FWZ3RIc1J0aDFyZ3ZYdWQzVUpxVlhpWk1GMURhK0RsbFJkT3RhTlg3cGkr?=
 =?utf-8?B?Y2I2UXM1bU9wc3pRRWYxby9QNWNIZHRQYjVUeVdYcVdnWVozclNUc3diNlFO?=
 =?utf-8?B?bTBSY2VNUHJ4WmRpdmpuVVE0YjMyWjNzbGczOEl0OG5IczBvOUhURXUzY0ov?=
 =?utf-8?B?R2lRRGtjaUVzMERSZ3JmK1R1bmwwcnJqTUVkM043VzZjQVFlYTIyZ0dycVRV?=
 =?utf-8?B?S2FwazkyMjQwWXZIM3BHRlZjSkxVT3FlV3hKbmtNSUNxMWllNTVkYlN6K2du?=
 =?utf-8?B?U2MyMUlheGFqcnJERFI4cVM1K0szVUxyazUwaDh1bEFPSTZGWjVhWE5QYzlr?=
 =?utf-8?B?SVEvS29hc2RiejdFQWpTbW92cm9uSVVkMkRSOUlLdVFCYndvLzAvTnVUNmlu?=
 =?utf-8?B?aVJ3QmhoY21NRU9FTUg4TnBrbEd3WndRaG9rb1lhVFRnSEJMUmhncU10OHZT?=
 =?utf-8?B?Qmc9PQ==?=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 415608c9-0efb-4693-84d5-08d9f2a0776b
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Feb 2022 05:35:26.1235
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: f3KODe2GXImionF6UdboCBXbfEUTfyCXbboWPCOwVz5lWJufC5C892Or95HqajU+zhmXemD+LxsX1Xb2BxX5WQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB2815
X-OriginatorOrg: intel.com

PiBGcm9tOiBKYW4gQmV1bGljaA0KPiBTZW50OiBUaHVyc2RheSwgSmFudWFyeSAyNywgMjAyMiAx
MDo0OSBQTQ0KPiANCj4gTGV0J3MgdXNlIGluZnJhc3RydWN0dXJlIHdlIGhhdmUgYXZhaWxhYmxl
IGluc3RlYWQgb2YgYW4gb3Blbi1jb2RlZA0KPiB3YmludmQoKSBpbnZvY2F0aW9uLg0KPiANCj4g
U2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KDQpSZXZpZXdl
ZC1ieTogS2V2aW4gVGlhbiA8a2V2aW4udGlhbkBpbnRlbC5jb20+DQoNCj4gDQo+IC0tLSBhL3hl
bi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3Z0ZC9leHRlcm4uaA0KPiArKysgYi94ZW4vZHJpdmVycy9w
YXNzdGhyb3VnaC92dGQvZXh0ZXJuLmgNCj4gQEAgLTc4LDggKzc4LDYgQEAgaW50IF9fbXVzdF9j
aGVjayBxaW52YWxfZGV2aWNlX2lvdGxiX3N5bg0KPiAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgc3RydWN0IHBjaV9kZXYgKnBkZXYsDQo+ICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1MTYgZGlkLCB1MTYgc2l6ZSwgdTY0IGFkZHIp
Ow0KPiANCj4gLXZvaWQgZmx1c2hfYWxsX2NhY2hlKHZvaWQpOw0KPiAtDQo+ICB1aW50NjRfdCBh
bGxvY19wZ3RhYmxlX21hZGRyKHVuc2lnbmVkIGxvbmcgbnBhZ2VzLCBub2RlaWRfdCBub2RlKTsN
Cj4gIHZvaWQgZnJlZV9wZ3RhYmxlX21hZGRyKHU2NCBtYWRkcik7DQo+ICB2b2lkICptYXBfdnRk
X2RvbWFpbl9wYWdlKHU2NCBtYWRkcik7DQo+IC0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdo
L3Z0ZC9pb21tdS5jDQo+ICsrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3Z0ZC9pb21tdS5j
DQo+IEBAIC02MjMsNyArNjIzLDggQEAgc3RhdGljIGludCBfX211c3RfY2hlY2sgaW9tbXVfZmx1
c2hfYWxsKA0KPiAgICAgIGJvb2xfdCBmbHVzaF9kZXZfaW90bGI7DQo+ICAgICAgaW50IHJjID0g
MDsNCj4gDQo+IC0gICAgZmx1c2hfYWxsX2NhY2hlKCk7DQo+ICsgICAgZmx1c2hfbG9jYWwoRkxV
U0hfQ0FDSEUpOw0KPiArDQo+ICAgICAgZm9yX2VhY2hfZHJoZF91bml0ICggZHJoZCApDQo+ICAg
ICAgew0KPiAgICAgICAgICBpbnQgY29udGV4dF9yYywgaW90bGJfcmM7DQo+IC0tLSBhL3hlbi9k
cml2ZXJzL3Bhc3N0aHJvdWdoL3Z0ZC94ODYvdnRkLmMNCj4gKysrIGIveGVuL2RyaXZlcnMvcGFz
c3Rocm91Z2gvdnRkL3g4Ni92dGQuYw0KPiBAQCAtNDYsOCArNDYsMyBAQCB2b2lkIHVubWFwX3Z0
ZF9kb21haW5fcGFnZShjb25zdCB2b2lkICp2DQo+ICB7DQo+ICAgICAgdW5tYXBfZG9tYWluX3Bh
Z2UodmEpOw0KPiAgfQ0KPiAtDQo+IC12b2lkIGZsdXNoX2FsbF9jYWNoZSgpDQo+IC17DQo+IC0g
ICAgd2JpbnZkKCk7DQo+IC19DQo+IA0KDQo=


From xen-devel-bounces@lists.xenproject.org Fri Feb 18 05:42:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 18 Feb 2022 05:42:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275132.470857 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKw2W-00025L-As; Fri, 18 Feb 2022 05:42:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275132.470857; Fri, 18 Feb 2022 05:42:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKw2W-00025E-6U; Fri, 18 Feb 2022 05:42:44 +0000
Received: by outflank-mailman (input) for mailman id 275132;
 Fri, 18 Feb 2022 05:42:43 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qkm2=TB=intel.com=kevin.tian@srs-se1.protection.inumbo.net>)
 id 1nKw2U-000258-KN
 for xen-devel@lists.xenproject.org; Fri, 18 Feb 2022 05:42:42 +0000
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 955af088-907d-11ec-8eb8-a37418f5ba1a;
 Fri, 18 Feb 2022 06:42:40 +0100 (CET)
Received: from orsmga008.jf.intel.com ([10.7.209.65])
 by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 17 Feb 2022 21:42:38 -0800
Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81])
 by orsmga008.jf.intel.com with ESMTP; 17 Feb 2022 21:42:38 -0800
Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by
 fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.20; Thu, 17 Feb 2022 21:42:37 -0800
Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by
 fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.20; Thu, 17 Feb 2022 21:42:37 -0800
Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by
 fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.20 via Frontend Transport; Thu, 17 Feb 2022 21:42:37 -0800
Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.105)
 by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.1.2308.20; Thu, 17 Feb 2022 21:42:37 -0800
Received: from BN9PR11MB5276.namprd11.prod.outlook.com (2603:10b6:408:135::18)
 by MWHPR1101MB2143.namprd11.prod.outlook.com (2603:10b6:301:4f::8)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.14; Fri, 18 Feb
 2022 05:42:35 +0000
Received: from BN9PR11MB5276.namprd11.prod.outlook.com
 ([fe80::f514:7aae:315b:4d8d]) by BN9PR11MB5276.namprd11.prod.outlook.com
 ([fe80::f514:7aae:315b:4d8d%3]) with mapi id 15.20.4995.016; Fri, 18 Feb 2022
 05:42:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 955af088-907d-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
  d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
  t=1645162960; x=1676698960;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-transfer-encoding:mime-version;
  bh=BcaSNAGT+HCBzd2+gHk1kGFKyHc9ILmmBlGHmNwnId4=;
  b=fswqw28bzkQ8y4GT0O/k5Iz5ISvYRZv1N/Vofk+nfZtkR7py4euhBKQt
   zcQ3t+N666GhWaVedjAdqbtdfympyhqIJneDffhC7+aRpH6tZsHZI0HiE
   RucmgyKyx0yFmD/WCxEtYkQU3VUUiHrZDRQ7H7X0EfOQEizoh8ogfapFy
   hXgqbb3UKU5P6PQFKG4GGj3MabbqmK7Zyz0CKVU1RNCuehyIiOVcKL//Z
   T+ZPf0fmD34gZisTrGiW7m6PIxQgO92QdoLnS0P5ib2pOzqiL17q1NIOe
   obhh+nu9x37s1iIls6WWlleeXh39rlZ59CIBRP8amspWeSDe5gzHd3dB7
   Q==;
X-IronPort-AV: E=McAfee;i="6200,9189,10261"; a="337501223"
X-IronPort-AV: E=Sophos;i="5.88,377,1635231600"; 
   d="scan'208";a="337501223"
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.88,377,1635231600"; 
   d="scan'208";a="546123095"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Qk3yl5nh7U2Rh9aPI+7JR2jCvLPzIHOHHNZh5usCpa42W/n3lrWpvaOKNET2XV3wXzhRw9gM+DVNdWYNoR4kiuiOGupX3/aGmwlaMyjovokaMN5qznzJJaljelrwxVB3fk3EDT3m94aLv9DckB5OgPlx1Py2FLTrJsxug7dZdCNA6F6vz1BMIrTO/0IlW8UcZ8PAl46UqZCtIAnCswu26lv3OIJ7zdeYgiL0ha4cFjFjofAJQyull/TKMjnyRX9X6+Vu5+LR8ohzRRjP+zTpZy/FIIhPwjlksjGWxbA9mAWTRDNHNRtSj/Tzq+PBBV95Trqg5XXGpRJ5xLAtQBkBUQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=BcaSNAGT+HCBzd2+gHk1kGFKyHc9ILmmBlGHmNwnId4=;
 b=H0oIuNDhoMZcj1KaxsSD0IpAapyQe4EUVjFZxbC6NwSy+vaSjF3RWEccFT9lKY1wERggmS16fBeCJ+lf6fhKS5kYe25mqjZ5pJewa07K9U+epkFFtjRTVeuQqCjJol8tBv80nC/pCCGCe59/2Xc4NpiCHcKblsv3m5Mp1o6t1dKxKuxg9zVpPDCqpuJm76avXdPH7GDVggj+wxQ2GKFtpzaywCDIR5sS4b6cfQYekxgzvBDeJvbsByo7tiQWyB+LU6nrqPQQEBta2tYsLtUagnirZCKo4Djaaghqk5VSW1bKh7dXzMJUdCGzXy6N2q45pb4YAyWuFvnN3RSe6W65Uw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
 dkim=pass header.d=intel.com; arc=none
From: "Tian, Kevin" <kevin.tian@intel.com>
To: "Beulich, Jan" <JBeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Paul Durrant <paul@xen.org>, "Cooper, Andrew" <andrew.cooper3@citrix.com>
Subject: RE: [PATCH v2 4/4] IOMMU/PCI: propagate get_device_group_id() failure
Thread-Topic: [PATCH v2 4/4] IOMMU/PCI: propagate get_device_group_id()
 failure
Thread-Index: AQHYE40qNspWQzZvQEWmCw0ZHMO91KyY7RMQ
Date: Fri, 18 Feb 2022 05:42:34 +0000
Message-ID: <BN9PR11MB527660ACF4439570E4F5C25E8C379@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <4b7db7ae-eb84-7ecc-4334-fe5f0f7ef46b@suse.com>
 <998f6587-d64a-7336-a44b-d05ca486b4bc@suse.com>
In-Reply-To: <998f6587-d64a-7336-a44b-d05ca486b4bc@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=intel.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: c302d991-5ad8-4e68-7c1c-08d9f2a1770d
x-ms-traffictypediagnostic: MWHPR1101MB2143:EE_
x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr
x-microsoft-antispam-prvs: <MWHPR1101MB2143DCFB090DBDE4793C4AD18C379@MWHPR1101MB2143.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:6790;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: nUY1Pwpx/Bf1G6Wt0RjeMjc5ndw5jr2znKgXYXHKOXsFXyYUPu5i2JAYT3lKvcv6mZ+RtQVavrO4zHp823yo0qHyJwtN4twrbLj/iVSrRaQStRYFL3dDQCkczgJwNmGzcAN6HpJ0RJChlfpgYN6de+X3JZ0dgt2+cHhStMz2SvHP0KugP4Cc8/sjY+22f9i0VH+h3SXd2XLiibMEV1s3FJgU/HT+Adyc62wbIf9M5tlL77eJUxnaUiTfIeLq34+7UgQJjBVJmxNYZ0TMWzDY22Cp1XzEZz5+QqibGMXDMWgdqZU2cA4bLgZaYVzApO4z6xHBmnsRjErDEyzZD/2Y57hhiiuKOH2IoAhrC7/qbeynlwT+qxLAWTeJp0PBMDgGSIyw8LV1dkFfDO4KAwuVjfFdsUh8WYFhrXh04GWrw2iAX1qf7nFz5K5CfM7Vf10oBow+jOTHBNx9IKAEpAy/JH7bqHezx5baala8tcTWsu8G3KhEuuQpEuk99lxcLs47QmAYgJawYCZ9Y+EOiihDVUaAcluJYwUe/4t9fV6Lz1iCXx42oYae8gCprrH2BQpADmDXe4JUkzqBaeC1FyhHJTpniI6IlthakAgrowO+rpTlIhLuJkMrK3DHF1dyJxSdrQLrmwtSQ1ab+4rR0r3UVD8tfRrhPbtHAG6ogU1Q7L6IYrs1dqU2qP9rtq8EO1RO1tdfnt7FQSkHcqYzpiEGwA==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5276.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2906002)(66476007)(8676002)(55016003)(66946007)(64756008)(122000001)(316002)(110136005)(76116006)(66556008)(508600001)(4326008)(38070700005)(7696005)(66446008)(82960400001)(52536014)(86362001)(5660300002)(38100700002)(33656002)(9686003)(83380400001)(54906003)(6506007)(186003)(71200400001)(26005)(8936002);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?U1dxZzMxeWtLWGNXNVpHNk1qbDMxcldLcWd5Y2QrMno3d1laM2VOSHhkZ0Vu?=
 =?utf-8?B?eEJlMHBHOWZZRkNuWmg0dUh0NzRyTTdFdjB4NlNTMERvb05UZWNackNoMS9k?=
 =?utf-8?B?MEF0b2t5WHlvS2lTVnVadnpBNW4rNXYwc0FqNEVxbXRIenRlK01DS210a0Rr?=
 =?utf-8?B?eVYzRTlPclIrNGJ3blROS1pUYUhGcmRBeWpYVkt1TUZZSGtQZFVoV1BrWEEy?=
 =?utf-8?B?VzVvTzdUbWhIdk85SmZ3UGZoSTVmbFpDYk8xU0hsY1lGL0ZGQ1dCMjFEZUF0?=
 =?utf-8?B?S0tjZkhTT1hLblptY1BhUWZ6MG1PUnFqTUNXWm5oSEFVSVROdXVzeFVXMEwx?=
 =?utf-8?B?YUc3U3RPQ1YzZEJuWVBhMzdjVXRKTDB3bUlHOUh6Q2h6THBRUDh3QW1jZUx3?=
 =?utf-8?B?MWlHaUk2TkYvSW8rMTZJSlAwNHJSMEhISWwwcnlpemZMSmxzTmhCdHlVVlcv?=
 =?utf-8?B?NXBkbURqd0ZxRUozOTU0V0pZYjZ3QkhTR3Z3UFh1Z24xRzZUK2VOSTFYaFhX?=
 =?utf-8?B?Z1Q4RDR4dUxQOGNKSEpOZEVxNzZJSXp2cFJlN3ZYcHdnN01jNVV3OXkyZitv?=
 =?utf-8?B?VTYwZTRJVnZLM1piYXhLZ0ZiZVppQXpwYTlXajZuSkVLRE5KbWdZUEdpcHor?=
 =?utf-8?B?RWpmazRRKzdHZDRBcEFuS2hnZ0paYmdYbWtmZFBONU13dTRYMnBTNEt6UUFp?=
 =?utf-8?B?b01VbU9WUlJ4MTVmUXFoMTFIK2laZ08yemtydTFoOUdqNjhQVWEyY1FXajE4?=
 =?utf-8?B?YTlkQVdnRW5VSk92YnJlUnVPYW92MlQ5ZUxuWWU1RGNxU0cyRys3SWFzdkJS?=
 =?utf-8?B?NGdlVi9DbHZVeFJDVFNLMm9DYmZJZXVKbG1xamRvTy9QMjNqTFc3b3A4VFhG?=
 =?utf-8?B?dmpmTGFOaERtWjFzMmN6emx4U2NHc1c4eXFVQXdrRlNHY2VZR2hrZmFRTm5s?=
 =?utf-8?B?VUlNejRKeDJtVW42MFJVSDVydmFSOXlIWGNzYW5Db2hxa3ZjNm1ZQmxSeEFD?=
 =?utf-8?B?dk1PZmgwYVpybHNoaTZiOUl3cVRaOVk5ZUJyVVhROVppOGFPOTd6bVhOc2tC?=
 =?utf-8?B?SVc2Ry9hUWRZbWc0NEViN0pZSm9kVDZJbGxNdVRnK3dIYWR6dGZsUmlweDA4?=
 =?utf-8?B?NXFVeUFtL2pybHRzbSs3NWZjNzNhc2NDVlNtSjNjUjhQT09VVUx1bzgzVksy?=
 =?utf-8?B?NDhMYWREVytFNGVFWjZzUVcvNWpsZE96YTliT1NyTzdQcWxYNlVnVm02MVQw?=
 =?utf-8?B?d21McnhaUGNLa3pCK1lxaE9YN3ozb3dTSC9qenA4S1lDUU5RVnp3dytJTTFD?=
 =?utf-8?B?MzZ3ZDZVNDAzWTZoM0F1QitVWTRUbmtUTTI1MnB2cVZTaUVGdi9OTkMwQ2s2?=
 =?utf-8?B?cVJxZWdKSHp0cXBJaDFJSDBKWTF6aTNqVWFHNFcwYVZVNHU4NHp0bDRyd2cz?=
 =?utf-8?B?WnlsQkNEeEpwcmlSQ2FnRkVtMDFoekVkcTVHNmxZd21idlZQWTc1cWJGdUtk?=
 =?utf-8?B?bXNnTkhKb3piZnBXWW1GWlI4ZERJeTFqbkpzcFZZZGIzS1JFdEtYcGdxUWU1?=
 =?utf-8?B?cTlaTjcvN1FmVStEUkR6QkFTWU1ZUldab0NnNm5iaE13cldlTE9FVDdoVnRK?=
 =?utf-8?B?YldvOTRVQTlPTVBiZUFhczduTmc5VHFXZFc5N2I5d0lvOVRXRGlJS0Fiam9p?=
 =?utf-8?B?dVphY1ZpNkFVcUowMGpQUjFGdmFHQWtFcWQ1b1ZlSG53MFVpUS9KQ2dJRVpu?=
 =?utf-8?B?Wkl2RW1uaGhTUTdBblN0KzQycUo1bzRkN09XRzRUeExhTEhtNXVBVXJvQ1Fv?=
 =?utf-8?B?aWYvWkpzRlFRc1FzQUIwcUJtUUJvK3NOVWtWWTFMeHlYdUxuNTBZbWR1OU5u?=
 =?utf-8?B?ZUp5WVBnNFJmMWVaR3llbkhpbm9BUmlpd2tmTlJZQUtQd2JhRGhYVGtDa1pj?=
 =?utf-8?B?RVBjZUtEL3VKWTNPQVFqSGFEcnJPN0lFQ2J0eXZYaXRtSXViNGtFV0NuNVRK?=
 =?utf-8?B?cjZHYmdpY0gyN2xNM24rZWVpTmdHK3c1Z2M3RE5jb2kwZ3pINC9RUFo3M290?=
 =?utf-8?B?WXVNQk9xUG5mOWpPU3FJOTdxZjNwcTlqMGJPRWcrRnBFTUh5Qk14YTlpSVR1?=
 =?utf-8?B?NnBGYXhZMDJ3UmdxeVVqY1FKMndoS1pIMlJGSzRCT3hkMVNleXR4dzdxTnBn?=
 =?utf-8?B?Qnc9PQ==?=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c302d991-5ad8-4e68-7c1c-08d9f2a1770d
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Feb 2022 05:42:34.9883
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ptc7EahkQWsddEPXol/KCDqe+RDV60h5iNXQPWkT5XUZq0M7ztCZOV3erfn/C6VEGBzgeukspqRvNxkmrQXIYQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2143
X-OriginatorOrg: intel.com

PiBGcm9tOiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+IFNlbnQ6IFRodXJzZGF5
LCBKYW51YXJ5IDI3LCAyMDIyIDEwOjUwIFBNDQo+IA0KPiBUaGUgVlQtZCBob29rIGNhbiBpbmRp
Y2F0ZSBhbiBlcnJvciwgd2hpY2ggc2hvdWxkbid0IGJlIGlnbm9yZWQuIENvbnZlcnQNCj4gdGhl
IGhvb2sncyByZXR1cm4gdmFsdWUgdG8gYSBwcm9wZXIgZXJyb3IgY29kZSwgYW5kIGxldCB0aGF0
IGJ1YmJsZSB1cC4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBz
dXNlLmNvbT4NCj4gLS0tDQo+IEknbSBub3QgY29udmluY2VkIG9mIHRoZSBYU00gcmVsYXRlZCBi
ZWhhdmlvciBoZXJlOiBJdCdzIG5laXRoZXIgY2xlYXINCj4gd2h5IHRoZSBjaGVjayBnZXRzIHBl
cmZvcm1lZCBvbiB0aGUgcG9zc2libGUgZnVydGhlciBncm91cCBtZW1iZXJzDQo+IGluc3RlYWQg
b2Ygb24gdGhlIHBhc3NlZCBpbiBkZXZpY2UsIG5vciAtIGlmIHRoZSBmb3JtZXIgaXMgaW5kZWVk
DQo+IGludGVuZGVkIGJlaGF2aW9yIC0gd2h5IHRoZSBsb29wIHRoZW4gc2ltcGx5IGdldHMgY29u
dGludWVkIGluc3RlYWQgb2YNCj4gcmV0dXJuaW5nIGFuIGVycm9yLiBBZnRlciBhbGwgaW4gc3Vj
aCBhIGNhc2UgdGhlIHJlcG9ydGVkICJncm91cCIgaXMNCj4gYWN0dWFsbHkgaW5jb21wbGV0ZSwg
d2hpY2ggY2FuJ3QgcmVzdWx0IGluIGFueXRoaW5nIGdvb2QuDQo+IA0KPiBJJ20gZnVydGhlciB1
bmNvbnZpbmNlZCB0aGF0IGl0IGlzIGNvcnJlY3QgZm9yIHRoZSBBTUQgaG9vayB0byBuZXZlcg0K
PiByZXR1cm4gYW4gZXJyb3IuDQoNCkkgYWxzbyBoYXZlIHRoaXMgcXVlc3Rpb24gb24gdGhlIEFN
RCBzaWRlLiBJbiBjb25jZXB0IHRoYXQgY2hlY2sgc2hvdWxkDQpiZSB4ODYgdmVuZG9yIGFnbm9z
dGljLg0KDQpidXQgdGhpcyBjaGFuZ2UgaXMgZ29vZCBpbiBpdHMgY29udGV4dDoNCg0KCVJldmll
d2VkLWJ5OiBLZXZpbiBUaWFuIDxrZXZpbi50aWFuQGludGVsLmNvbT4NCg0KPiAtLS0NCj4gdjI6
IE5ldy4NCj4gDQo+IC0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3BjaS5jDQo+ICsrKyBi
L3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3BjaS5jDQo+IEBAIC0xNDYzLDYgKzE0NjMsOCBAQCBz
dGF0aWMgaW50IGlvbW11X2dldF9kZXZpY2VfZ3JvdXAoDQo+ICAgICAgICAgIHJldHVybiAwOw0K
PiANCj4gICAgICBncm91cF9pZCA9IGlvbW11X2NhbGwob3BzLCBnZXRfZGV2aWNlX2dyb3VwX2lk
LCBzZWcsIGJ1cywgZGV2Zm4pOw0KPiArICAgIGlmICggZ3JvdXBfaWQgPCAwICkNCj4gKyAgICAg
ICAgcmV0dXJuIGdyb3VwX2lkOw0KPiANCj4gICAgICBwY2lkZXZzX2xvY2soKTsNCj4gICAgICBm
b3JfZWFjaF9wZGV2KCBkLCBwZGV2ICkNCj4gQEAgLTE0NzcsNiArMTQ3OSwxMiBAQCBzdGF0aWMg
aW50IGlvbW11X2dldF9kZXZpY2VfZ3JvdXAoDQo+ICAgICAgICAgICAgICBjb250aW51ZTsNCj4g
DQo+ICAgICAgICAgIHNkZXZfaWQgPSBpb21tdV9jYWxsKG9wcywgZ2V0X2RldmljZV9ncm91cF9p
ZCwgc2VnLCBiLCBkZik7DQo+ICsgICAgICAgIGlmICggc2Rldl9pZCA8IDAgKQ0KPiArICAgICAg
ICB7DQo+ICsgICAgICAgICAgICBwY2lkZXZzX3VubG9jaygpOw0KPiArICAgICAgICAgICAgcmV0
dXJuIHNkZXZfaWQ7DQo+ICsgICAgICAgIH0NCj4gKw0KPiAgICAgICAgICBpZiAoIChzZGV2X2lk
ID09IGdyb3VwX2lkKSAmJiAoaSA8IG1heF9zZGV2cykgKQ0KPiAgICAgICAgICB7DQo+ICAgICAg
ICAgICAgICBiZGYgPSAoYiA8PCAxNikgfCAoZGYgPDwgOCk7DQo+IEBAIC0xNDg0LDcgKzE0OTIs
NyBAQCBzdGF0aWMgaW50IGlvbW11X2dldF9kZXZpY2VfZ3JvdXAoDQo+ICAgICAgICAgICAgICBp
ZiAoIHVubGlrZWx5KGNvcHlfdG9fZ3Vlc3Rfb2Zmc2V0KGJ1ZiwgaSwgJmJkZiwgMSkpICkNCj4g
ICAgICAgICAgICAgIHsNCj4gICAgICAgICAgICAgICAgICBwY2lkZXZzX3VubG9jaygpOw0KPiAt
ICAgICAgICAgICAgICAgIHJldHVybiAtMTsNCj4gKyAgICAgICAgICAgICAgICByZXR1cm4gLUVG
QVVMVDsNCj4gICAgICAgICAgICAgIH0NCj4gICAgICAgICAgICAgIGkrKzsNCj4gICAgICAgICAg
fQ0KPiBAQCAtMTU1Miw4ICsxNTYwLDcgQEAgaW50IGlvbW11X2RvX3BjaV9kb21jdGwoDQo+ICAg
ICAgICAgIHJldCA9IGlvbW11X2dldF9kZXZpY2VfZ3JvdXAoZCwgc2VnLCBidXMsIGRldmZuLCBz
ZGV2cywgbWF4X3NkZXZzKTsNCj4gICAgICAgICAgaWYgKCByZXQgPCAwICkNCj4gICAgICAgICAg
ew0KPiAtICAgICAgICAgICAgZHByaW50ayhYRU5MT0dfRVJSLCAiaW9tbXVfZ2V0X2RldmljZV9n
cm91cCgpIGZhaWxlZCFcbiIpOw0KPiAtICAgICAgICAgICAgcmV0ID0gLUVGQVVMVDsNCj4gKyAg
ICAgICAgICAgIGRwcmludGsoWEVOTE9HX0VSUiwgImlvbW11X2dldF9kZXZpY2VfZ3JvdXAoKSBm
YWlsZWQ6ICVkXG4iLCByZXQpOw0KPiAgICAgICAgICAgICAgZG9tY3RsLT51LmdldF9kZXZpY2Vf
Z3JvdXAubnVtX3NkZXZzID0gMDsNCj4gICAgICAgICAgfQ0KPiAgICAgICAgICBlbHNlDQo+IC0t
LSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3Z0ZC9pb21tdS5jDQo+ICsrKyBiL3hlbi9kcml2
ZXJzL3Bhc3N0aHJvdWdoL3Z0ZC9pb21tdS5jDQo+IEBAIC0yNTY0LDEwICsyNTY0LDExIEBAIHN0
YXRpYyBpbnQgaW50ZWxfaW9tbXVfYXNzaWduX2RldmljZSgNCj4gIHN0YXRpYyBpbnQgaW50ZWxf
aW9tbXVfZ3JvdXBfaWQodTE2IHNlZywgdTggYnVzLCB1OCBkZXZmbikNCj4gIHsNCj4gICAgICB1
OCBzZWNidXM7DQo+ICsNCj4gICAgICBpZiAoIGZpbmRfdXBzdHJlYW1fYnJpZGdlKHNlZywgJmJ1
cywgJmRldmZuLCAmc2VjYnVzKSA8IDAgKQ0KPiAtICAgICAgICByZXR1cm4gLTE7DQo+IC0gICAg
ZWxzZQ0KPiAtICAgICAgICByZXR1cm4gUENJX0JERjIoYnVzLCBkZXZmbik7DQo+ICsgICAgICAg
IHJldHVybiAtRU5PREVWOw0KPiArDQo+ICsgICAgcmV0dXJuIFBDSV9CREYyKGJ1cywgZGV2Zm4p
Ow0KPiAgfQ0KPiANCj4gIHN0YXRpYyBpbnQgX19tdXN0X2NoZWNrIHZ0ZF9zdXNwZW5kKHZvaWQp
DQoNCg==


From xen-devel-bounces@lists.xenproject.org Fri Feb 18 07:04:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 18 Feb 2022 07:04:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275141.470868 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKxJX-0001ik-Bs; Fri, 18 Feb 2022 07:04:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275141.470868; Fri, 18 Feb 2022 07:04:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKxJX-0001id-8W; Fri, 18 Feb 2022 07:04:23 +0000
Received: by outflank-mailman (input) for mailman id 275141;
 Fri, 18 Feb 2022 07:04:21 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=v1rr=TB=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nKxJV-0001iX-9l
 for xen-devel@lists.xen.org; Fri, 18 Feb 2022 07:04:21 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id fd983962-9088-11ec-8723-dd0c611c5f35;
 Fri, 18 Feb 2022 08:04:19 +0100 (CET)
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2059.outbound.protection.outlook.com [104.47.8.59]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-26-3UZRo5NjMN-wKeIjbMATIQ-2; Fri, 18 Feb 2022 08:04:17 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by HE1PR0402MB2777.eurprd04.prod.outlook.com (2603:10a6:3:d6::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.16; Fri, 18 Feb
 2022 07:04:16 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4995.016; Fri, 18 Feb 2022
 07:04:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fd983962-9088-11ec-8723-dd0c611c5f35
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645167858;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=deGc8pyup6UHsfzl7QgokKt0quEDIb1buVKBQmqvZgY=;
	b=Gh52bFN3lLuVs3wQ+Hwl5T5kA4W81HZuCKd2HtS9gKeCmAE6PYtrCPfL8iBrlxbM+rrgra
	Ve3i29BizL9kQoGWy0cTOGAfD75saditSnxzPKHO8m64UaZi/fUszEyTMDnnIn5QrPgWuo
	444LwOi7EW5V2nEs4mEZRvMJyfZ+AYE=
X-MC-Unique: 3UZRo5NjMN-wKeIjbMATIQ-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=OVqrARCo5bHigfgEZXWWfFA+ytZh9FTul/O8hZ2j8wXFA900akYoRdc1qtBTOeRuArqG4u0uUx2W98lIZxi6JRX9z6JorPfEydPg516g5QJB2SI4fppFO45v3R7GxNKACxGbIRv9U6brqvr1d7FgpKzHVAa/i294jLARguCMaOy6B6uBlYxd5a4ppEwvuglvbdSVANU2PW6ISKnYxkDw0HojnAZO3SJ0pOXi1S2crMOBWD2rlw6rELbuEmU1S+xvP98rtiXxnHSUf2pknXAJz4LjMlWbh8yHBR5ERqmBM2G9L8Bvx2kBY1COIqcPMioRwHbQS2xV/UcijJncsNKPVg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=deGc8pyup6UHsfzl7QgokKt0quEDIb1buVKBQmqvZgY=;
 b=bBSlSIC2IxMP19ik5Pdw7jMiAmFcAbM0C3DuE1mdzM2CuNuxHOQ/XhrpD9S8fgzRQ88jMxnJyqWMI6taw3qgSVPANLA59pL6xgWr6E+YiFuJ14Vv3ZSzQeT5lULHuVX8mBVdT8ejrbuixGk7eHXtMnE3icXq84SBWMhvZz9R/HEN5jOsnwgHpXr9RuaiyXVh4Giz5VtsIn2/wpWU2YV2egOKUtpZfVon1EFLmueX6J+O15x+ZYV3hmnB3jI7a5HEn6vfVAxrMbE9HHACcRnFibhX0bHIUHSgQzN8IUwrWCa4gMt/o10rMIfJpWHpE3F7gkQJwPImTbcanMOyLkkoNA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <dc1a4483-7dca-aa72-6b86-4217e6840efb@suse.com>
Date: Fri, 18 Feb 2022 08:04:14 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: IGD pass-through failures since 4.10.
Content-Language: en-US
To: "Dr. Greg" <greg@enjellic.com>
Cc: xen-devel@lists.xen.org
References: <20220214060011.GA24404@wind.enjellic.com>
 <198ef291-4dee-ddac-aef6-8451bc1e880c@suse.com>
 <20220217201534.GA29303@wind.enjellic.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220217201534.GA29303@wind.enjellic.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0253.eurprd06.prod.outlook.com
 (2603:10a6:20b:45f::21) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5f2ea688-4d45-4cd9-25b9-08d9f2ace003
X-MS-TrafficTypeDiagnostic: HE1PR0402MB2777:EE_
X-Microsoft-Antispam-PRVS:
	<HE1PR0402MB27771811F6AD2FF46DCDDAB6B3379@HE1PR0402MB2777.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	LRK6gNa5PbIYqZuBpdqvYlqgtehGpuR0ty20Z3HcuWxjCLhdKylci2lt5jJmScR0WS/cwzqYxQ/NNhSTHussAgMq3pkNA/sgfNglvHQLOOMy3sTWKAp1d4ZMb4mk8SDn+icS7K9LpxZS/GMZUcV8eWD9XmVwtSzLbtczmU4lzePHFEr5Peh81qiUIZRTIKs0xTvyzwU3gx4TTWVqwVLrpRWcCQeZV6wwRpUa6Cu7AJVJZKJyFyL7PdBp+D1ayFDTEpCeaDQK1loel2Qak6Ma3TGDzH5nbOzZLxL4RbEchZsry5MUglkgEPMCKLTwIhxSxnglTqBoinB7wBiDrjcpl7frW4LzcJnp02d8iC90nuVmmxlNkfdTRyTW1tStXb/KmrX7QD0QenB/awKC72hD3yHFyrU8nFR41PT6oS3wMuy1msim/+hmQSyw8RxrWLwiXuPuMSF/C0DwWR9VPUJW+jTQkWJBWqE4mZCaT0B4b3YhyyhHYRavzbO73NTT5RYu59nVJ+bXs2N3d1N+TYsRShoXAOtDfvdzIxk6A8nRu8QxGTGpL4FHUT4av8qnTpQpomn6MrRbL05r3szFUQkk4UHK5x7g8OQDW7HgA1NEYSONXyCellsAFmVOvH/mQsR7E4wDbfnKiL/SI14ITgbRalHmnKAhv6vqL9eNhmit6NCY+K+VigUVtm4Vg3f/7CX4nyyT6d2FweUeVd6Us0CMWW46a7FV4poN9ilJpbrAaYk=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(4326008)(66556008)(8936002)(38100700002)(53546011)(66946007)(66476007)(186003)(26005)(6506007)(8676002)(5660300002)(2906002)(6512007)(2616005)(31696002)(31686004)(6486002)(6916009)(83380400001)(36756003)(86362001)(316002)(508600001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TGthbmtqWWtKMTVUTktnc3VjV0VieFppbTRXUnRMcWgvYzJ0VDlhUkl4Y1Ry?=
 =?utf-8?B?Nk1xdXBMV1FURGxzNitQU1EwWm1IMS9JbkF6YjZnWnhGM3ltQVYxZUFhMGVK?=
 =?utf-8?B?SEs4bFdpbzRqUDlXY21Bd1ZKOXpmelloeTdvSUppb0FaVytDa3FOd2cremJR?=
 =?utf-8?B?SGdnOEhpcHFRbHB3M2dsSDVxcUd1VmZ2dFZ4YlFUYi80YlJQcVBTd2ZIWTNm?=
 =?utf-8?B?M2lzL3pjd2kwSmxRWHEyc1ZqRUEvTzVJd1p2MEZtbURUb0JKZjdqaUg2dity?=
 =?utf-8?B?dndHNjI3TmYvTG8zdlc5eElUbkRraG5wWXdwdnIzMlNuWk9ndGVBS2NFTFdz?=
 =?utf-8?B?MXlXeFc2UEdsS09LMWlBNW5GcTRkdmhDbUNjSElKUlVGMmNmMHR3L2tsOFZB?=
 =?utf-8?B?TlA3aXUzWHBNcWRyTW0xSGk2VDUzbVgrcitZZXBueVdHR1I4M2pVSU9DZWdW?=
 =?utf-8?B?elpKZ3I0UGsrL05Na0xuelBVS1lIMkVPU0xsUmZ5T1NkK1lXbnk3U3YrcUty?=
 =?utf-8?B?Mk5QU240UE4yOTdlalRtNkltRU5vQmZWYk9ZWVB5L2wzQmdwTlVkTmlLSzBG?=
 =?utf-8?B?VHZ0ZE9XRlVxVEdoWUtaS2o3TUQxbXhCNmNwOWRuUWVQbDZZbEtmeG9peWJM?=
 =?utf-8?B?T2hmMG90K2kxRjdUNEdQZXIxZ2lrY2NuM2w3MmFEcmNsMWZ2WXcxdHVhL1Zp?=
 =?utf-8?B?dHhsSmcwM1hMVWR6bG1KaUVJUi9xdDk5dXNtMzArcG5kM2JCRnZDMUJxeE5i?=
 =?utf-8?B?aGZpdEd3anRBL0JCV01LbmNtc0N0REpic29LaTNqaHR3OWxJRjk3cHNKUnVZ?=
 =?utf-8?B?aGlQVk8vSWQxL2pDRkcvcG95YUljQWdzeWlLUG8rTkIwOVM5V0w2KzVUa1Nq?=
 =?utf-8?B?dU4zb2RudjlEVjRrNzVZWWN4VXd5TFZrZ28rOG1xNjNiNXhnVEFzaTNpTjM1?=
 =?utf-8?B?aWhFQkNwMXpTWmEvWTM0UGpXS0J2dlRZVytscWZ1RVVPaW1uQWhLTkplZkVO?=
 =?utf-8?B?RU4yYkdocjlsWUVzSUt3WWFTUnVVT0JvbFFZcEdHZERmZ2FzcmdpMXJINEo2?=
 =?utf-8?B?Q1pqOEl3dEliUjMxWWQrUkRGdWhCM3JYYksyQVZmcmtGQ1o1cW1LNDdsVnRX?=
 =?utf-8?B?dVVYaTJZWVNvSkJyOGFMbXZ3bVBjbVpMWVRleG1TYk01MFZZMitXRjBnM2Vj?=
 =?utf-8?B?VE8vOTBrb2RPZEFRNHBHQytRNGJVTjI0QVJlek1xd2dyS1NFanlBSEhaVEFn?=
 =?utf-8?B?Q0crWFBLTUxNY1BsSHpIUFg2bysvSWVsdk1mU210TjluczdJSThObnYrT2xi?=
 =?utf-8?B?TFl1RHk4UVZzZ0VENy8yZlY5Q0hCZXdKNEpBZ2N6NHlrZlFDNHIxbWJTQ0pQ?=
 =?utf-8?B?eG5NcUF2WlNRbHV6K25USERsUUV3MGIzcjFnL094ektpZDZMSnlrOWp6Zllr?=
 =?utf-8?B?ejB3TERtenhQK0ptanNadUh3L0NLVGloTThYVW52ZTZSeUdSdUp5cjliZVZt?=
 =?utf-8?B?Um1TVjJwU1dvWDVmZXpNdDBCYmc4R01mN0dOL0M5aSszQXZDazdsem5Gb1l0?=
 =?utf-8?B?NWk2cTdCbVFqa0xyYTAvbys1TGJXaW8wbk5YTzVOZ1FjODJlUUxTcTNLQ1U0?=
 =?utf-8?B?ZkNXbTA2SWYyOHNuYmJVdGxkR1VKU00xRTN4T1NDcWdZd2ZSWmhYTks2OHVk?=
 =?utf-8?B?SHRYdXUzUnlCY21KV1o5WS8zalh3a0UwaGtZR1E3NVVwZGl6OXBld1ArcmJL?=
 =?utf-8?B?S1hIUy82aTdtck5LRHJ5UjlJZ2t4ejFWUTlaYlZxQXQ0VUFmZkxnN0pUSURS?=
 =?utf-8?B?VlNNbTErWnZXNW5LNnhYbklxQmhuak9KVmhJVTV4ZzNVTXVBbnIweDVjeG5R?=
 =?utf-8?B?SnltTFlFcEFVaFVsNkpwSlB2NWVFblFmeWVaMTBqMDNKYWZBdXZSbzhKU3JT?=
 =?utf-8?B?V1Y0MHNybU1SVE56eEd6QWNzbzRDV01lTEhGaktmcCtGSS8xU09TQnJ5Rk0v?=
 =?utf-8?B?dVpoR3pvbDNmLzBWdkdsOVY2cVlwQWNSdEttV2tReU1HaG5zbWhBb0pSckx4?=
 =?utf-8?B?WHduR3JrbGc2amtSNVFDWWpiMEdhcW5LSVFGVjcvRVhEQWVucWZtaTNMOGh2?=
 =?utf-8?B?WXg3ZWdnTHgvNytQdUhZMXNxUEw3NjNTN0NiV1ZDK2pZVG1KbDUzdWFrMkU4?=
 =?utf-8?Q?YZG0aOJ/9epiowySXg8qcqo=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5f2ea688-4d45-4cd9-25b9-08d9f2ace003
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Feb 2022 07:04:15.7797
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uPgCS587nLQSDQE3Hv+J/uEQ1MoSswrzPOWtLWZcpN9W7NmaPof/wC8T3PlYYVoK43xu6J1OaEnEpvMhzszJOQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0402MB2777

On 17.02.2022 21:15, Dr. Greg wrote:
> On Mon, Feb 14, 2022 at 09:56:34AM +0100, Jan Beulich wrote:
>> On 14.02.2022 07:00, Dr. Greg wrote:
>>> It appears to be a problem with mapping interrupts back to dom0 given
>>> that we see the following:
>>>
>>> Feb 10 08:16:05 hostname kernel: xhci_hcd 0000:00:14.0: xen map irq failed -19 for 32752 domain
>>>
>>> Feb 10 08:16:05 hostname kernel: i915 0000:00:02.0: xen map irq failed -19 for 32752 domain
>>>
>>> Feb 10 08:16:12 hostname kernel: xhci_hcd 0000:00:14.0: Error while assigning device slot ID
> 
>> Just on this one aspect: It depends a lot what precisely you've used
>> as 4.10 before. Was this the plain 4.10.4 release, or did you track
>> the stable branch, accumulating security fixes?
> 
> It was based on the Xen GIT tree with a small number of modifications
> that had been implemented by Intel to support their IGD
> virtualization.
> 
> We did not end up using 'IGD virtualization', for a number of
> technical reasons, instead we reverted back to using straight device
> passthrough with qemu-traditional that we had previously been using.
> 
> If it would up being useful, we could come up with a diff between the
> stock 4.10.4 tag and the codebase we used.
> 
> One of the purposes of the infrastructure upgrade was to try and get
> on a completely mainline Xen source tree.

Depending on the size of the diff, this may or may not be helpful.
What you sadly didn't state is at least the precise base version.

>> would suspect device quarantining to get getting in your way. In
>> which case it would be relevant to know what exactly "re-attach to
>> the Dom0" means in your case.
> 
> Re-attach to Dom0 means to unbind the device from the pciback driver
> and then bind the device to its original driver.  In the logs noted
> above, the xhci_hcd driver to the USB controller and the i915 driver
> to the IGD hardware.
> 
> It is the same strategy, same script actually, that we have been using
> for 8+ years.

Right, but in the meantime quarantining has appeared. That wasn't
intended to break "traditional" usage, but ...

> In the case of the logs above, the following command sequence is being
> executed upon termination of the domain:
> 
> # Unbind devices.
> echo 0000:00:14.0 >| /sys/bus/pci/drivers/pciback/unbind
> echo 0000:00:02.0 >| /sys/bus/pci/drivers/pciback/unbind
> 
> # Rebind devices.
> echo 0000:00:14.0 >| /sys/bus/pci/drivers/xhci_hcd/bind
> echo 0000:00:02.0 >| /sys/bus/pci/drivers/i915/bind

... you may still want to try replacing these with
"xl pci-assignable-add ..." / "xl pci-assignable-remove ...".

> Starting with the stock 4.11.4 release, the Dom0 re-attachment fails
> with the 'xen_map_irq' failures being logged.
> 
>> Which brings me to this more general remark: What you describe sounds
>> like a number of possibly independent problems. I'm afraid it'll be
>> difficult for anyone to help without you drilling further down into
>> what lower level operations are actually causing trouble. It also feels
>> as if things may have ended up working for you on 4.10 just by
>> chance.
> 
> I think the issue comes down to something that the hypervisor does, on
> behalf of the domain doing the passthrough, as part of whatever
> qemu-traditional needs to do in order to facilitate the attachment of
> the PCI devices to the domain.
> 
> Running the detach/re-attach operation works perfectly in absence of
> qemu-traditional being started in the domain.  The failure to
> re-attach only occurs after qemu-traditional has been run in the
> domain.

Interesting. This suggests missing cleanup somewhere in the course of
tearing down assignment to the DomU. Without full (and full verbosity)
logs there's unlikely to be a way forward. Even the there's no promise
that the logs would have useful data.

Of course with qemu-trad now being neither security supported nor
recommended to use, you will want (need) to look into moving to
upstream qemu anyway, trying to deal with problems there instead.

>> I'm sorry that I'm not really of any help here,
> 
> Actually your reflections have been helpful.
> 
> Perhaps the most important clarification that we could get, for posterity
> in this thread, is whether or not IGD pass-through is actually
> supported in the mind of the Xen team.
> 
> According to the Xen web-site, IGD PCI pass-through is documented as
> working with the following combinations:
> 
> Xen 4.11.x: QEMU >= 3.1
> 
> Xen 4.14.x: QEMU >= 5.2
> 
> We are currently having IGD pass-through with qemu-dm (3.1/5.2) fail
> completely in those combinations.

I wonder on what basis these statements were added.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Feb 18 08:06:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 18 Feb 2022 08:06:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275159.470879 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKyHt-0008J3-J8; Fri, 18 Feb 2022 08:06:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275159.470879; Fri, 18 Feb 2022 08:06:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKyHt-0008Iw-Fj; Fri, 18 Feb 2022 08:06:45 +0000
Received: by outflank-mailman (input) for mailman id 275159;
 Fri, 18 Feb 2022 08:06:44 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=v1rr=TB=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nKyHs-0008Iq-Dl
 for xen-devel@lists.xenproject.org; Fri, 18 Feb 2022 08:06:44 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b4d51263-9091-11ec-8723-dd0c611c5f35;
 Fri, 18 Feb 2022 09:06:42 +0100 (CET)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2053.outbound.protection.outlook.com [104.47.13.53]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-18-J4vxsJ8XNUaVXhKSQpAtCw-1; Fri, 18 Feb 2022 09:06:40 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM7PR04MB7094.eurprd04.prod.outlook.com (2603:10a6:20b:11f::8)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.16; Fri, 18 Feb
 2022 08:06:38 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4995.016; Fri, 18 Feb 2022
 08:06:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b4d51263-9091-11ec-8723-dd0c611c5f35
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645171601;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=aBiAVOMZGq++Df5VR4RIU5g4UdPKgSP24QnQ3tsEYec=;
	b=OueQmu6XcniZdJ90mM52fNIGWLKZ3jyBTOfIMun/6NNMfT9j93awndlCtJhCjWao2AcYYl
	wV0Rb9kVH/a1mUnRdJfAk0opAav8HlJ4dEza/jth03Ue0kom+Hg5wz9LfzCtZkg1qE7ONe
	roV1KO6OKz1XTfkU3xMJB29rTeEJkgk=
X-MC-Unique: J4vxsJ8XNUaVXhKSQpAtCw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=nYtO8JpamBF5jCaIKtNwaIOAHYmQNS1kpnwUfti+PeY5KLOCOxM6SieujZp6yGG8m54JaAVl5nbWuqCO/VrGymM1kTQNxUiVzxb750Ypo7xaJpbwv11sXln5zuQmuTesIdE1yhZFYjcCYTH443lcG7SH3q/Ul7mu3XLaysiD3im57Ft2Zyucg7ATfHMtrpS1jZOwMHJv9p07tzi69EQvkEwG/QdWk0JPKemQT+6bby0DRIrrZkNQyOKmmtC1/N0e2SkvhujoYH3/5Vb3/fMmjgDynGliK8L5390X+sHEAAvEXDtis/huqZ8fGBtlI4jUVH0IKEGm+V9FBvqRauqcMQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=PrBq8lgcrPZI8jhsiqj2B0Fr5vp3ju2ZPZOYgHn9a2k=;
 b=la78hV+1vZeo2QTKMOSc7l5RXbNsmtJlMHe7LeVMoT52oThwOa+dC+CBloW2/8NwJv9qArX21884mp0WfjinG8ox+u490gU1UfIsLcbQQdwptmqWhO2dl9iv0ZbBMu1fqDIG+xiv8o/Ejmnojw3A/qmoisFHY9f5kdUyfqU0TGnhMWQvoes0fEhrhEMeN19nI6sRKsYF0eURCD+L858Su3tg1dDOdS8d4Dev9wlOISWVAlNXsDDwIK8q7ZC3SDwqdygfJmXqQqDgaJ+XoUNpYEj7wWVtqKUQxAW0TFq0Q3/8Akv5A7OMJhNZfFHGWgqMNCUQVLBSV6+1+NnikNBPWg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <e59dc35d-013d-1db6-a61e-c2e4504952b1@suse.com>
Date: Fri, 18 Feb 2022 09:06:35 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v3] tools/libxl: don't allow IOMMU usage with PoD
Content-Language: en-US
To: Anthony PERARD <anthony.perard@citrix.com>
CC: Wei Liu <wl@xen.org>, Juergen Gross <jgross@suse.com>,
 xen-devel@lists.xenproject.org, Roger Pau Monne <roger.pau@citrix.com>
References: <20220217140923.22485-1-roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220217140923.22485-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6PR08CA0007.eurprd08.prod.outlook.com
 (2603:10a6:20b:b2::19) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 366917f1-ab7a-449a-dd91-08d9f2b59680
X-MS-TrafficTypeDiagnostic: AM7PR04MB7094:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<AM7PR04MB709433AFA1C6EB15D9BC7F9FB3379@AM7PR04MB7094.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	a5YGV/4NGPKTBVYP5JLcCtcz/r7hjaiLLOFtzrVT6GTINrANUlOSEopHWn+Xn4YcIfgz960J0d8+Vh4RcF86PkUKS/9ncxSS82lS9jszGz8uz4lfVIbwBPF+vLzI2HCWqtLWubf5Mxsk+6hqh21p/3Q0qeRmvOvkjFrBBNwnzbaRxLYSAw7BzYQuJPZzaT993+JYNmnUy4OYW/TQ3NIcjZnb37+bX85W57UTTVFZiv3pbhHnt6D70C+7uJ3GDDpPJj7DDzyg/PYKopsKvpQTjdozNAFTRsXvAARvQMpgyNhSV4m4u/+70BLwm+D7Qg0ymUtsltiwSXyqWshU5tp1dfQpIFadeQsptZvs5VGhwU2HYBtgurPw9UziFmKQKc/w4S5fohRMKs6bZ7iOrdbbdVr3EG03kiycwj22i3W5/DpgZSGxu4xOKLw0ai0QlYLbuyE3LkpZWSoLi94CmnXhbNqyh39YczFzbRH0MIdwTaxvgM3USSyw8j7kz0f5fv7tD7wA7i9l3wcuE0uBQcbDG/cLWolEONFoSHBt+pKUrImJs0iyRYa1YANmOviola7mAfRiLN8s6O5i2d9mkXQR8oFcI9MbRw2HPxtav+zHYl+xtoPXHXqPPjCHnGvSa+7zFT++i2YzLFJSXUF32rSSKFN+J4/l742rKoxjw88kItvFM/DX7yeO/crMjsMm4jTgRIxau/5vtdmEaAY/l8SxAfl9PIlmyUG5BS7jJ63CjOY=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2616005)(186003)(26005)(31686004)(53546011)(6666004)(6512007)(6506007)(508600001)(54906003)(316002)(36756003)(4744005)(6486002)(8936002)(2906002)(8676002)(86362001)(4326008)(66476007)(66556008)(66946007)(31696002)(5660300002)(6916009)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?N3OxSZ4mwBU5OQasG9CyJFNT/NakxQbuI9AgsQ8hmAnPoRQZuhbSFzV8JhUm?=
 =?us-ascii?Q?ZEHdvFkkM2avCzhmtSZx2FYo6xeTfgwuMS5xk341u50MT3T3Q4aCl1Au+RAc?=
 =?us-ascii?Q?qGGitIWlQr/LsiEPfvo8rHs1kaaR6bUJTd80rzco6RkWKGn1lNFOMaowFDtV?=
 =?us-ascii?Q?3NrucPDQxnAAeeXnWOw8VjIEVMwF91ngJ0H9zaZm7fjLs6x5AZanmQgJupIB?=
 =?us-ascii?Q?GZz0O64dcsL1eN0sotxCQAw/mCw9zuIdluL2KtqPIay5JtOxzX5NBpcn++DT?=
 =?us-ascii?Q?xFZejRt8J4fOBKiXeNUM5Ep8NV20xYbR/5eoHsE4xs2Rbg+8+yo8HLvIh+OO?=
 =?us-ascii?Q?cJJHAukvhTlKsjv67E5fQmgbQRmHCpqDG9qbz/9buhwow2nzPvoViOM3b6oM?=
 =?us-ascii?Q?K79C+5CwWngqXtq4euUFtWYZvpU7KLIoViFWTM5EeOyTcZvk9/Yiu8yLNcD3?=
 =?us-ascii?Q?8x9nOMoJHfav8DYQm+VX5OU1IE3bKsNGg8KJXxrrjW3CVtY0Y+c6L8umM0FZ?=
 =?us-ascii?Q?aFA3B6q35MbPpI/jjwIl4R7G7tODZaG76nj+Fj2rEnIc/Zlh2qWd0mydtxsg?=
 =?us-ascii?Q?OQbd3T2iVaT5OIIG04oQ+xTc21lgk1B9SkmC+s2R/hfvF+xXch383hOPqWdw?=
 =?us-ascii?Q?YENy6gDhe2OnujnbZUQCuKsFZXW+Kpew00JOx0FBYZbdZaYOvjm29tKXItc3?=
 =?us-ascii?Q?bne7FbegIJt8MRLiTNCkfN1T2c1MLCowamRASLIZjOI8vFsqbv+W0yearol5?=
 =?us-ascii?Q?826j+HZ2IDcGneUKFTO9sI9WcWjSc/JBRmKlIR5OxqRdLy+QqEHbUr1hS97H?=
 =?us-ascii?Q?S7xCvRQB0rEteg+YzNR+YTsvtBEnOKcsBi2DzGWcDMp5HTGWTPO7UsRYSNP/?=
 =?us-ascii?Q?I9gfBPXDMHvDpI8jT1HTtQ8V+BZwD/oUuEu77j9KQyZ1bvAsJxR/D0MBUJfr?=
 =?us-ascii?Q?Ikn0fb+SQXmODvEF8xBhq3GkAQYMtFuHPBwyavpjTKYV13i8kq7E+68jY+6H?=
 =?us-ascii?Q?/fd+ugGyfZ7lsK8ds3jOzSLXNZyRhpWlLfUu417h587LMhN74VD/hx1uUaal?=
 =?us-ascii?Q?hgIVeeSKSDZoiZZPZyE+428d5C+1Jna77YCeLRsOkp2CisvAOAnIAoQoqMFC?=
 =?us-ascii?Q?RQtTkzBpOuGy40UKItG5Abc++YTQw7/72I2N3lcBwUOWddIX5/m8VZMcauct?=
 =?us-ascii?Q?GOALvbKY47zIr6SJCbXNhGa71WaxUOOzcYdHMw2G0ZD+fY3lTf053aMNTolP?=
 =?us-ascii?Q?mJqB0DfvO2sgvp+ZnDUiOdKmw3UQyfrVNY6ltM0qXWK/vbsZE/XkOcx1u3bz?=
 =?us-ascii?Q?5rVU6v17q1R6Ee7O+RM9rRI6Xd/J0TaRk21h2tSTmim743xKZwW5gdvn0ZIn?=
 =?us-ascii?Q?QlYwQhSyahQi+AyDrYK/oL4w1JWNDFlS6OSu+kmD25kc8Qri4s0YH+2edxIT?=
 =?us-ascii?Q?WEcTyIMR43/fk29CCVDe/H1H4FlE79gfgDx0ua+Uc8g6m7C3Q6MIo7IuYhNu?=
 =?us-ascii?Q?Z5r223xaEG3Xi9da+VyFl/mVdJR2LSvp4B3jZvZDypsD8loJNVJWrM87HbYV?=
 =?us-ascii?Q?9Imb3ykKCrUQaNVZazMqvFyEvVAGH9j4GtwksGcMpnFucRKwJZDhSikwUpTc?=
 =?us-ascii?Q?MpZNGCVmdg31tJOVP0x6rW0=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 366917f1-ab7a-449a-dd91-08d9f2b59680
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Feb 2022 08:06:38.0009
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Us88UERTHGHwBf1NuVTTv1+mdyEaOAQf1iyRKSn+RE3Js/ml/aV3oik1Zyxgl8zXUS98w9829805W9lg3CAEmg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB7094

On 17.02.2022 15:09, Roger Pau Monne wrote:
> Prevent libxl from creating guests that attempts to use PoD together
> with an IOMMU, even if no devices are actually assigned.
>=20
> While the hypervisor could support using PoD together with an IOMMU as
> long as no devices are assigned, such usage seems doubtful. There's no
> guarantee the guest has PoD no longer be active, and thus a later
> assignment of a PCI device to such domain could fail.
>=20
> Preventing the usage of PoD together with an IOMMU at guest creation
> avoids having to add checks for active PoD entries in the device
> assignment paths.
>=20
> Signed-off-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>
> Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>

I'm inclined to queue this for the stable trees. Thoughts?

Jan



From xen-devel-bounces@lists.xenproject.org Fri Feb 18 08:16:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 18 Feb 2022 08:16:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275177.470925 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKyRD-0001pv-1N; Fri, 18 Feb 2022 08:16:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275177.470925; Fri, 18 Feb 2022 08:16:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKyRC-0001po-Um; Fri, 18 Feb 2022 08:16:22 +0000
Received: by outflank-mailman (input) for mailman id 275177;
 Fri, 18 Feb 2022 08:16:21 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=v1rr=TB=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nKyRB-0001pi-Nm
 for xen-devel@lists.xenproject.org; Fri, 18 Feb 2022 08:16:21 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0dbec2da-9093-11ec-8eb8-a37418f5ba1a;
 Fri, 18 Feb 2022 09:16:20 +0100 (CET)
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2056.outbound.protection.outlook.com [104.47.2.56]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-8-e_ZUpT8lMZ2GEGNnzNk8Ow-1; Fri, 18 Feb 2022 09:16:19 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DBAPR04MB7397.eurprd04.prod.outlook.com (2603:10a6:10:1a9::7) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.19; Fri, 18 Feb
 2022 08:16:18 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4995.016; Fri, 18 Feb 2022
 08:16:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0dbec2da-9093-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645172180;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=2B/X4O4o6jIa0I9oC1Ga/ELeIuE2O7OqW9XdHsDltsg=;
	b=kzZIfpqcSr/0Nq+iZ/2JEb/YRKkQ1tkErbSw+7uQ3WHhaDTWLpv+tnmRjUzCEYVGa8LIx0
	/RH7IY1Vqje//Ns9SpirfxWM5E8/b5yTCfI4bQiT7R+euE8rFodXXzPw/IedYqsc0c3e4s
	TBjbwMrste/Lmwlk1aLpkWHgyReiYDg=
X-MC-Unique: e_ZUpT8lMZ2GEGNnzNk8Ow-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=k7ETfLZ3ofpiwB9wh1eTpSXwcnKnM4Ay+6khANElXqruj8f1QweWf7PTkVKUb+dlnQYsIPNjWr3XzdjfQRjv8caHPCaPwSV1F/SmPMFS9IGoUkLLHuWY57GkO0IoSefSiQmTjChtIFiAY1L8MLVelt29brqwNuWtDctwt1XwBOBhUGJxYnflgrLcmu42gNOdSuNQRQ+ARsEo39dsYQcdEntFJiWK2imBQDTltLCEAAn+ZMzbkcToY8mPeiyKxBurxsiyR7Amxu4i3FVukbOdQmtYqDuXJvKSUBEYOz2X5zxGj2eHWO7R0cvwOwizQoeshurzeNKTHMTIUpsGTBSCMw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=/4BmVG5Py4dPXp3giiQvp/yxxbBQu2gaQTICH54fiNw=;
 b=KmezueqKrb4CmyBI/9uhu8l0UmWePHGDn4zX/B/I1+K8ZwHqsemP+ccCAqSVZgjDusQAg8BbAMmnn4t4W8Mb/S0EyWx20mv3uj6HdU3Q8ZvQxxrb/guOP/j1CvYylbB8TQJgLd9sh54fC9nS+h5YxctAaEq1XiPT/qkQ8gJiAA8FCNFqGu4P3SuSddXG97eu4XVX5a59gBDS5rCz+/3sQusm6GMgoDeAm+OgG0ngXr17VUQ/XpzvgjVY5kAAE5JV8zumP62dGQbZ73TFq5YLfTmVryk2qhT2hYYH6fB7bj/gqC/EHfXdKnXH9pDq3rWaS0F4HdikugrKj4AtAkC63g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <660b2b8d-7211-46c8-67b2-f53f424910dc@suse.com>
Date: Fri, 18 Feb 2022 09:16:16 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v2 5/5] x86/cpuid: expose EXT_DEST_ID feature if supported
Content-Language: en-US
To: Roger Pau Monne <roger.pau@citrix.com>
CC: dwmw2@infradead.org, Andrew Cooper <andrew.cooper3@citrix.com>,
 Wei Liu <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20220216103026.11533-1-roger.pau@citrix.com>
 <20220216103026.11533-6-roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220216103026.11533-6-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6PR10CA0075.EURPRD10.PROD.OUTLOOK.COM
 (2603:10a6:209:8c::16) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 88bc7f33-0c24-43ad-1a5a-08d9f2b6f073
X-MS-TrafficTypeDiagnostic: DBAPR04MB7397:EE_
X-Microsoft-Antispam-PRVS:
	<DBAPR04MB739741EA3A0B9562F875E5AFB3379@DBAPR04MB7397.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3968;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	KixlApk9/7T/8LlPyK20TpxuPXWvfsB+o179PN/lC2zXBN0hg9kMMY1gztyRpHudtrsUs2YD/UF/+XEDCCoMXcNM/Vwb1EdOk3I7ebL5kerCYXsNKo3G2HIz4Hs7Njep8mldkPlpt1d0JKFeyNyTVoLba7bcBN13NYniiDLMdKwHd4FBPdQ9wfJ7P+9CgQ/mArr5ciYXdZComm0qvFq+DuvlTWFRMcfqAuklLPxD9jXvKFYZa0P9qT8rdlmtQEjz+DorTW3uvueCe36pS/XlgMqMxGXOeVJzJybAyhnNl9CJbjXiAHLlq3nqj3tPAuvMyGxmTjpvLPQ+l63sgq678HPn7adFOH1nG7FNF0DKAa+Gp0jHuIeiFUwU1DjibPs4oZ1FDN+j6BVqVuOUZHnolUe423ehGaRBykaQjMEVNQQdUGcK+ZFMNx6WQVr1k9UINmfxpnn0CIFbVCuYvU5+h1PAZzxgSyiS3SSaMBtbXSBDuWlTTdq150K0dATQBdHHjXg8BkHIi+Lbx0Icvy9xdzkKmkv3Qgyl8Ck8OBneh4/vLKwLsc/CDYRYZlKtHqrcObbdgsd7pi3uHZ0QjVnb1POCK0yIV3Rz/5spe2hKd7fsUICBc06ze6OSJ1NzmK5xNNEorSMKvOIM2w4fS6dLo2Mya/0u+mQ/LinQX7TKw0bxJDrRBMINeItxaqcQOCO+7HAq6IHa8WmSvAj8Z/ITgkl0oFnEwHlLVaJKzdGCNsT7pvyxu4Gjj9nPbJtw99Ug
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(36756003)(31686004)(558084003)(2906002)(5660300002)(54906003)(6916009)(6486002)(6506007)(38100700002)(316002)(8936002)(508600001)(86362001)(2616005)(26005)(186003)(4326008)(6512007)(53546011)(8676002)(66476007)(66946007)(66556008)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?Q85zLO5A3+cAMQOqBMlrGSAJKOfJCri+K+pNfMLLPP8A5LR01Bh0gaevPHje?=
 =?us-ascii?Q?qgl0zmgsxwqn43PfU1is4r03NNXG47HHY0Icq5y3Mn0TfIDNPxOCfF00B0Jb?=
 =?us-ascii?Q?jZvL5zVvphvRldidWIZIAIiGJ9SUw0HIeoym+Ah8j79Rl7MvkC6jLZ1JQa4i?=
 =?us-ascii?Q?UV3QNlf89xpBNp3SiXaChTK8ef6M7g8xd7JLXKrH5aCslLDJ0lMF/Ztl3Nuh?=
 =?us-ascii?Q?hRtVeho86IjYhvvLEyFXvMfp7H/34qttpYYEd6WvQ5r5s75vJe8gDM8Lz38s?=
 =?us-ascii?Q?22rG1XiRu5m8r67I9c7DGFt+gwbehO/rJsVZMYKL8KAG6Y7tT/Z/qruEcCt8?=
 =?us-ascii?Q?JKYGJJKeKcKDBrWxxTfUEuvV7ifXjTGeUvDZ/QnMy2MFhp7xXKItyNtRz+OJ?=
 =?us-ascii?Q?x71GnXyEVLra4qXKA64I5tkX4+UMX87OyRFfEc/dvWmr0KAyIhRmAkXyDU/P?=
 =?us-ascii?Q?IyaeIFFsh8IMfFK2wQjkMHg3vIwG5pdwxbDWznAYiE+2yERdG6sM7xQEgIjk?=
 =?us-ascii?Q?98Ms/rkokMkBxnSWbnh+0rmIUSZ7VJfyRqRFGiSZRDOtlXzvWWO7xLv1U9Sq?=
 =?us-ascii?Q?sS/mTmfzHOfPnt86/jxCzbPYsg5Scbz379ZlunDJs1vaWTjDaNKdlJjaZQ+c?=
 =?us-ascii?Q?30D7eXI4vYn/uQcwTE5dszH62Slia0xaNKLdy8eWd5wQtpwhN4t3zi329c4Q?=
 =?us-ascii?Q?NhWPCN4h4SGN607VgMQFQaOxjVW7ENA2aTFtHxTSWXYvlofmel1lndY9Wqi5?=
 =?us-ascii?Q?zH7hEjsuUEXKXLJtufZuWCPlGmqgNfzEkvz5/K4+eukMq0tpqdLOi2CSMrIi?=
 =?us-ascii?Q?TIyNjIOyIqr11AuEl6QJd+QGPfYnUTyBI6IYda3srRWyxwaG1vjwMDA9twTo?=
 =?us-ascii?Q?vURikf5gkp3iNHElC4nsQyZMPNCXqXWtVnNsInRGGMqBOxcXlO2oA2rKvLOv?=
 =?us-ascii?Q?M7WiPN8iaq7xjYnCkRu55DKR6eeoCVMe6AqlwIjUTcpVpWNw/3Z0PEaDi8sP?=
 =?us-ascii?Q?sUNC2WseHgpRaq1xIYriIua6xUmrIUy+2/mg55S5KOiZzBiTwBRiNM1s+Yjk?=
 =?us-ascii?Q?uQEJrVOI/V3CQF2sBEFMgIQ/C43otoXSlrqb4GrF3mA9VGJwg1NTSkVVhxpo?=
 =?us-ascii?Q?m0YC6AM07mmaVS+D0q4sviCSCtEULIYzSrcLjRQjhRWLU2sFRuVfSRJASYDR?=
 =?us-ascii?Q?pj8y1+R/55zGRotR1+1QH/bFJKeBm4oV5johDzRlFyYHS1BDoKRP2JSAfm4H?=
 =?us-ascii?Q?qa2XngUP+ruFRVFXb5zp0TFJU/oo3BG705uaXaOQzSIXiwfd6Suj7+PYR7Ff?=
 =?us-ascii?Q?SSgdQm/KWElXqtOEOKJxKQAm4haMDmjGqRcKwq/ySaJUMGxHtl/qONYd/ix/?=
 =?us-ascii?Q?wG+c8J2H5rC6iJXgj6PDV1HBoBnGftO8IOWJ5Cdg5D/6IDhij7fP7jWlH5YA?=
 =?us-ascii?Q?3craL1AOxHxlVmoRbcmCYy2Ud4SpYsarBaxypM17fudJifg3SYqtyIkYmu4f?=
 =?us-ascii?Q?flba52ynRF4tg/tfUlkBwKObh6K09bM8uIvvqN5RUugJHnbY0x24C1aItaWI?=
 =?us-ascii?Q?yF8Z1fD7VK/XdMz/xb0FbN+LoNlNxij1Sc6VvSg7Z+wsHi+OgAsuF5BZRfrW?=
 =?us-ascii?Q?txcn7coAhFeW0TlNO81gWCs=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 88bc7f33-0c24-43ad-1a5a-08d9f2b6f073
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Feb 2022 08:16:18.3555
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 69/Aidv4wIsNNd+soCmurLOTf244RGgC62529UiOyqwPHszRwC3BxgJtsVEMJFUHOyYUwQJt6Pk03ffHtolSiQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7397

On 16.02.2022 11:30, Roger Pau Monne wrote:
> Expose the feature if available for the domain.
>=20
> Signed-off-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>

Acked-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Fri Feb 18 08:20:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 18 Feb 2022 08:20:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275184.470936 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKyUn-00038k-IR; Fri, 18 Feb 2022 08:20:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275184.470936; Fri, 18 Feb 2022 08:20:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKyUn-000382-F2; Fri, 18 Feb 2022 08:20:05 +0000
Received: by outflank-mailman (input) for mailman id 275184;
 Fri, 18 Feb 2022 08:20:04 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Mscz=TB=epam.com=prvs=4048df52bb=oleksii_moisieiev@srs-se1.protection.inumbo.net>)
 id 1nKyUm-0002sn-4e
 for xen-devel@lists.xenproject.org; Fri, 18 Feb 2022 08:20:04 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 918cfae3-9093-11ec-8eb8-a37418f5ba1a;
 Fri, 18 Feb 2022 09:20:02 +0100 (CET)
Received: from pps.filterd (m0174681.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 21I805Bm026098;
 Fri, 18 Feb 2022 08:19:49 GMT
Received: from eur04-db3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2051.outbound.protection.outlook.com [104.47.12.51])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3ea7jcg2mp-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 18 Feb 2022 08:19:49 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com (2603:10a6:102:ea::23)
 by DB7PR03MB3721.eurprd03.prod.outlook.com (2603:10a6:5:5::25) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4995.16; Fri, 18 Feb 2022 08:19:47 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::c1c:f98:9dd:86e0]) by PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::c1c:f98:9dd:86e0%6]) with mapi id 15.20.4995.020; Fri, 18 Feb 2022
 08:19:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 918cfae3-9093-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Om/3zlG346gMlExf/TNSV0yuxyGouFWmECsMobshYAGalY9Hr8o+j+qph+GaEOuftj0r+kKwaLFFMPwYWgBRpeiyR/1jXLYQsk58av28YQgGMdTyzDzqJfNQEN/Y0Mhx2sfGF1YGVFK84ix7Pt9ZqZ5mMR9XOpszLgc3QLW2Wp2hcyJIfCrfTsYd8HWKNBVdf+cynqPlJmFlCb17AP3dNJY8wKwi4PPhaeAdw/BB+IoNXDifEbyuvmev8TGFnG79RUbv0/O2RaAAZtpnZjZFEL1PVexjsVJOzy+93Yux/ZBDY1/+p7ZTL3UOBcxQ/lWaQQEV349xin83f7Rs/A9jqg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=uNuNB1oJK3Ejt8n4W5UHd8DtoRW5KIs+zSS07a3M5Ws=;
 b=Fet9fIz98+6uj9khjF2kyUFE6+xgkSBJ/x8Y9QHkXafol3gQszF7gGsR9Pq0OiHAhcP+jpeEIjEzIzwXciV8felMg6dj4CB3XhB6mr3IB5vWXT34u626pO0VTjWRIBmfwlOIekF5ARlOelzpmP31D4mikkqvDXqM8GafI6ODhHicnJka5kxKE25Bmlsr0WcLgPkdH1hxWOETV4AUBIHOk+0E7Sflvi1dQzw1SaXuL7w+J3l80VEuoQ067ZHpSgjUDEvBeYVbqWiXs/WHUjQsiYO6S2w3mVQ4LlgkKsc1tDmTtJEMjCyWimATVH0nJaCiQbNXKKC50toV2alHsEAKJg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=uNuNB1oJK3Ejt8n4W5UHd8DtoRW5KIs+zSS07a3M5Ws=;
 b=oa0FrPVo67z4k+vyAfMVb1cEoWOMH+SBUfnB01AM3YEKQLndv5WN3dhQJqG5POfTlY8b88Uld/PvJEEszRzKSW4I/vSIvIyCHoBr9FKv6+7QXFcO0X0LZ4YiR5AB+EEscg4O/PFlEVINH15VW/ruQt8ij7dQvJ6330WWp5EzS4MVqqxZaxwezT+N0P7BfupdUJgvic2rWzteTHn8AawJ8j/N3Dfcm4S3uadbGouqg120TWDG/6+wiMQ9OTRE8x6rNGLcS4y+HxuPigy5Xc0YoUwyDhIKfbJYWc747ZlO1TuHU00Qd4B5PuwTyzzEwcm/Ja0qiwvEuE4MmSfrFxWgyA==
From: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
To: Anthony PERARD <anthony.perard@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        Wei Liu
	<wl@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>,
        George Dunlap
	<george.dunlap@citrix.com>,
        Jan Beulich <jbeulich@suse.com>, Julien Grall
	<julien@xen.org>,
        Stefano Stabellini <sstabellini@kernel.org>,
        Nick Rosbrook
	<rosbrookn@ainfosec.com>,
        Juergen Gross <jgross@suse.com>, Paul Durrant
	<paul@xen.org>
Subject: Re: [RFC v2 6/8] tools/arm: Introduce force_assign_without_iommu
 option to xl.cfg
Thread-Topic: [RFC v2 6/8] tools/arm: Introduce force_assign_without_iommu
 option to xl.cfg
Thread-Index: AQHYHRW3O86755dYV0qSgPdVO9oeMayX4d4AgAEkigA=
Date: Fri, 18 Feb 2022 08:19:46 +0000
Message-ID: <20220218081946.GA1482399@EPUAKYIW015D>
References: <cover.1644341635.git.oleksii_moisieiev@epam.com>
 <d333126d12f2281f8df92e66cfba1c9eb2425dca.1644341635.git.oleksii_moisieiev@epam.com>
 <Yg5hPMd86GOPt/ni@perard.uk.xensource.com>
In-Reply-To: <Yg5hPMd86GOPt/ni@perard.uk.xensource.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: f137eb5c-7ece-46e9-aeb1-08d9f2b76cee
x-ms-traffictypediagnostic: DB7PR03MB3721:EE_
x-microsoft-antispam-prvs: 
 <DB7PR03MB37215946BD2F037D1323E2C9E3379@DB7PR03MB3721.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 QyQPJOBpTys/fv3VLqvoRXab8uKNXlUkgGmwAme85bbaGqwnb5/NOb2ptO0InlGnOq+W4tDZzLkz8u+/AJ1fLD8Mu19sC2BMwQrmrSHopYj30rCpxew3BzvEy7AR4KlrfcRZiP/EjV0ZYOeC1fN/D0mtxNb7ofaiv8jiSlS3323sMf/tUyqxP5RDtMk29bAexWHpo+ij4GuruXPsGHJSTP18rKBcNLPiqpYle4BpZNmgzaeROXjs+3rYU4RczPcBxHi2T6ieaSgDdzHSjWHkypUGdcoTG3lpWUnIYzlBShAkGE9Q6qqb1YCpEqwLF9RSfAFzmIYCoKK1xOnz9MXks4MHHeinzxLquuJXPnz8O2I9Wp+tN7n8PS5JeMHTt6JcJVSVuYv6DaqzuwmQJnSlGgs9qAv5W2mP0Hug+XzFnN6NFp/emjulng3wdnc7ECPqlsqplLRfFG7pRw+nFqqZsdG4OzNq1w/dM1M8AQ7kbESDTFjJUNiTMH51Hsn74IHX9m27AdlSwzUQho11f4fWnQXMnGEnrLrNRXBVJovm7+V0wKKfnVnOPOB5Le2Dy8hGAnlEOZaNDWIsSulKbHRQtHzpH7pzuep9AOh/lqZ1XxOCZNk117AWo7c5LaG1fwyh2pg7J8lervOteiz9WzRqnAM/DJZRGQlTuo5X9QMF84Sey9Vjec7xbzMxMUl5WjID1HjmWabsQgOUWC+GUaGeNQ==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR03MB7136.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(1076003)(26005)(186003)(9686003)(2906002)(6512007)(6506007)(71200400001)(8936002)(7416002)(5660300002)(33716001)(66476007)(508600001)(66556008)(6486002)(66446008)(8676002)(76116006)(4326008)(64756008)(91956017)(66946007)(6916009)(316002)(38070700005)(38100700002)(122000001)(54906003)(86362001)(33656002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?LoIg6EXxI+hrAlGsQeNx5Xr4ZCRHYfQZ/X2wpy4bMZRwbFtlvVfoXe5QHPp9?=
 =?us-ascii?Q?J4dkUgKgfXz0F6AB9aU9b9IlwKE2yFyFV/BdIZo7BSmuIvYSt0JQEXxSNZq0?=
 =?us-ascii?Q?Gc8KbMkMAaPKdvdh/q9Fsb80T9nObL+z0cXyTWzF12Pq5UYdKk2qRdgzP8z4?=
 =?us-ascii?Q?zKOyAEEVf01EXrqJrbuWUHxYZFq1PJ/ke4zqAZ61BLGNpIFKQgVgT3H1ZgEo?=
 =?us-ascii?Q?8oTuDXS2bnxQy+yzG8VcMPNlJv505av6LiOJUowLCOjgMRCkGQr/OwbJyXSW?=
 =?us-ascii?Q?DJDooQEaZIyCbkHsBaGb4F6PaG9GoFUjdZvsWttB4iV8bryR4up2chVw4U1W?=
 =?us-ascii?Q?NRlx0LRijVT+fmx7uDRWoyHV7sm4+ImygGf6PQgBsAt5f4lKjdcObOPq7xpK?=
 =?us-ascii?Q?jV6hWpoQCV5nLRiZooA5J1Z5o2VQnEvgakioPHDdL6XYJLMGILa58p6Ib2l1?=
 =?us-ascii?Q?SLFikcg3Ihd6CZ+sPrhDRICXMH3A2RzI8IHipGQ4/r7h2zmFLB0ziP9dhpSG?=
 =?us-ascii?Q?T1eGZt/R2HhlP5oL5SDfHZMKwvLHZX7WyM+Y/K5AzGXU03RC7SFNcji7nFhi?=
 =?us-ascii?Q?1Oz0lDqWzGXojw+fg/U2QCs4hY/7HJ/vt42GBUeQmHE9QsyY2TG74KXZ+/oK?=
 =?us-ascii?Q?tDgvxhfDLJ+JJhBR7rhgr7rSYHEBh0DB4cnDe6M54+r0sx4qmROAmNKmhF4o?=
 =?us-ascii?Q?b08FYHUyFjKKjjV+GwKqMJ8PwXxe4a54ZGThiSeQFHL+MD/tsiSpe6KYL0iF?=
 =?us-ascii?Q?Rdwl2Hptzruz4dhvoB2SQkOxofRfx8x/3o+LgLj4wqa4kEZY0Sdx0IzRnVC3?=
 =?us-ascii?Q?zAFc7sK+pQSFTsP5r9sHKF3W0d94pYamTWHyNR0U1JPk78Z2n1kh+yemv/b9?=
 =?us-ascii?Q?aKJnTimljMwR6xlLhEtNL1BIch4EXQINinqxx/4CZQ7Zkj8ckvOdZTeyWuKA?=
 =?us-ascii?Q?Lwa6g2wIKsw+bhntPYmXq6vPjsd5pV9Et9Pe54vOlgp2pLqd7NnuBmtOIAta?=
 =?us-ascii?Q?0RpFiv4ila/w6JE0+iY20SnHrZAmy2J8Sh5vAJgMYEE7pWZBXqzoKA5Cq567?=
 =?us-ascii?Q?iMLP76ZXlfOhSwR/A7eOjkGsC5/Gs42Y94hdLvxTMMIF/OEjFvYGbATo0Zng?=
 =?us-ascii?Q?CsbhQ2/QldTlZRolQs1r0GbOHJdUbTvPStR/SfdvVBdLYJSvjxpqSut3fGj4?=
 =?us-ascii?Q?vsm8CSuMB1kahYxrb2ji8SU+9D/uSVw5N3/d7e1jremT8OjYFFyLhDIEbeGj?=
 =?us-ascii?Q?joufZRPJPMuoI0uDdRHYArS9+TOyWk4dvlhPYhes7NBb3j2ylEZWXysZsKjp?=
 =?us-ascii?Q?Q7ChZhTg/OiGKx7fPB88cmJYvpids0cIUknrGNosnTtit+7etaIIc3viiil2?=
 =?us-ascii?Q?avJHM9FeZvAytDM7/QGMqfP7cLM3YtpHlvoOh+/nWNqEN50ErzZ2OKmksta2?=
 =?us-ascii?Q?T8gl00Y6CDtWYyXMEmhzSVvNIOpQC4a6BaZnLlvJMhPZENXxTMI+wyrAYDjZ?=
 =?us-ascii?Q?pwfWTbbZ9CxJvWcGrmjfy9Bl03piij/K61MBoyjJWZjoIfyUGel4L2PbQDWM?=
 =?us-ascii?Q?Oj4SWwuppdXPKybxqBouTeZZh9U1BiIZ/YsztyVrGgfwD0jfKXsoF7kpYF2n?=
 =?us-ascii?Q?Bx1xFYN5RZGuhAzfP2hu61aWRt1trk10nx0QHrCpOpa2T8Xgd9a9Amkoy3iF?=
 =?us-ascii?Q?ozL/W691q6IHHr9jF0PwP8XvBPI=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <6F8CC0ACC87C164FB37D72FAF07D6AC8@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR03MB7136.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f137eb5c-7ece-46e9-aeb1-08d9f2b76cee
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Feb 2022 08:19:46.9373
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: AzXJV6V/xzqt9BWJc9PSGNrxMwnLCF4WaT6mTT7b3FvoMKMvZVqxJbgLrOJHePRiNBSI0MUQ3Ii9IRwsfT3CoUXe9y1OdM40udmcdv41zN8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR03MB3721
X-Proofpoint-GUID: Y-JpYlJGLAiON5z9-Eai_HjwUK4URaBT
X-Proofpoint-ORIG-GUID: Y-JpYlJGLAiON5z9-Eai_HjwUK4URaBT
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-18_03,2022-02-17_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0
 lowpriorityscore=0 spamscore=0 suspectscore=0 bulkscore=0
 priorityscore=1501 phishscore=0 adultscore=0 mlxlogscore=883 clxscore=1015
 impostorscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202180052

Hi Anthony,

On Thu, Feb 17, 2022 at 02:52:44PM +0000, Anthony PERARD wrote:
> On Tue, Feb 08, 2022 at 06:00:12PM +0000, Oleksii Moisieiev wrote:
> > If set, Xen is allowed to assign the devices even if they are not under
> > IOMMU.
> > Can be confugired from dom.cfg in the following format:
> > force_assign_without_iommu =3D 1
> >=20
> > This parameter has the same purpose as xen,force-assign-without-iommu
> > property in dom0less archtecture.
> >=20
> > Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@epam.com>
> > ---
> > diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_=
types.idl
> > index 2a42da2f7d..1080966c33 100644
> > --- a/tools/libs/light/libxl_types.idl
> > +++ b/tools/libs/light/libxl_types.idl
> > @@ -564,6 +564,7 @@ libxl_domain_build_info =3D Struct("domain_build_in=
fo",[
> >      ("apic",             libxl_defbool),
> >      ("dm_restrict",      libxl_defbool),
> >      ("tee",              libxl_tee_type),
> > +    ("force_assign_without_iommu", libxl_defbool),
>=20
> As you are making changes to libxl's API, could you add a LIBXL_HAVE_*
> macro in "tools/include/libxl.h", they are plenty of example there about
> adding new fields in "libxl_domain_build_info".

Sure, I will add it in v3.

--
Oleksii.=


From xen-devel-bounces@lists.xenproject.org Fri Feb 18 08:25:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 18 Feb 2022 08:25:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275193.470951 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKyZc-0003tO-7K; Fri, 18 Feb 2022 08:25:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275193.470951; Fri, 18 Feb 2022 08:25:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKyZc-0003tH-3r; Fri, 18 Feb 2022 08:25:04 +0000
Received: by outflank-mailman (input) for mailman id 275193;
 Fri, 18 Feb 2022 08:25:02 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=v1rr=TB=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nKyZa-0003sP-In
 for xen-devel@lists.xenproject.org; Fri, 18 Feb 2022 08:25:02 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 43ffd845-9094-11ec-8eb8-a37418f5ba1a;
 Fri, 18 Feb 2022 09:25:01 +0100 (CET)
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur01lp2054.outbound.protection.outlook.com [104.47.0.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-14-K0EXySFlOVu4K_s8W5CwEQ-1; Fri, 18 Feb 2022 09:24:59 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM0PR04MB6035.eurprd04.prod.outlook.com (2603:10a6:208:138::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.17; Fri, 18 Feb
 2022 08:24:57 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4995.016; Fri, 18 Feb 2022
 08:24:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 43ffd845-9094-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645172701;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=qpfJ/2lOHie385EtIUECXmt0dCOgdruSpPCiFO+/p2c=;
	b=fS3jL2YYd4Y/Su3sjgl2R1tHnL08Fo1ltOpMqpQuEhIQKqIS/6GboEjbwV6s9PwM+WBiae
	M9BXhpSnzBzNz5XeYLVaPNrKfs/6T4Hp3jk2L0g9UmvPON+25apwQqRHccHrHFys0DoA1d
	uMK23D1Q6A3DRL4mVmPf9uWpQrdWB44=
X-MC-Unique: K0EXySFlOVu4K_s8W5CwEQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XrshcfwHjzl54bR3UaJI/KjXteN1L7OrXVwZml+glgigsZyoVReMgRxGkbO/+gcQf4hDBfeCXn0EFZbkkZEFaVj2kX7a3r7SVz2Kc5OB8+hXSAhnR4o87jYaZ01nf0u59oeyXUWiCDQ/BhlduAVVS2xNEliDUi6LtRZHJtjZVeeGujkH4iBmtSZKFwyLhIpYZLq41ZE6PFgxlTG/MYeTzOfmPGiTNheZhzX6nPLY103sdGvyyukx+tCWB7+XAXT93jxdsexXpS4/Q4MwdSJcNMzBfC6Wm8xaj3IHQVkBSaalG+h99paXhSTLJUOwvFIQoQWyynykPIIvjKOqC6HAiw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=qpfJ/2lOHie385EtIUECXmt0dCOgdruSpPCiFO+/p2c=;
 b=Q0F9pkCAuV2z6KL6TIEewGFv8o+PRdojPIICTQzoMweS7ZQJBXv6mBJju+/vAl1Zh+f+OeF67r0Y1UPSfFYatFxl6xX5G5ZNQzu5oTpbzz4xn1uZfaPwemM9lXjJsHgkwKkJ3zbquoOH+AVteqCEvKBGk+PHef690AaHwhfEdnHK1UEdXbPUgenyFw84iodotWREdHmSA5WsX/pR9d7W5TcDS8O0GnSZO01d0/QskG094ujcQctEZAmmcnb3ZoI+X/Bti1wpmFphpVt/hfFcdDDLu5RZq1mdq3BkU5YttrEDZjHVJv3Xer7z8M8UmpwC4l0lZX0yf0fPVe/pTcVXQQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <78991818-ca76-2065-3511-f7e62a3f2e0c@suse.com>
Date: Fri, 18 Feb 2022 09:24:55 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v3 17/23] IOMMU/x86: prefill newly allocate page tables
Content-Language: en-US
To: "Tian, Kevin" <kevin.tian@intel.com>
Cc: "Cooper, Andrew" <andrew.cooper3@citrix.com>, Paul Durrant
 <paul@xen.org>, =?UTF-8?Q?Pau_Monn=c3=a9=2c_Roger?= <roger.pau@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <76cb9f26-e316-98a2-b1ba-e51e3d20f335@suse.com>
 <b985d619-05ea-73c1-1919-b0343e5a9b8e@suse.com>
 <BN9PR11MB52763A2638F1460EC83420B38C379@BN9PR11MB5276.namprd11.prod.outlook.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <BN9PR11MB52763A2638F1460EC83420B38C379@BN9PR11MB5276.namprd11.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0601CA0038.eurprd06.prod.outlook.com
 (2603:10a6:203:68::24) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b01c6eb8-42f7-49a2-0e8a-08d9f2b8260a
X-MS-TrafficTypeDiagnostic: AM0PR04MB6035:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB603599FB8957E0B4121E1D2CB3379@AM0PR04MB6035.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7219;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	/OeT8T2BMGxqSCNi6Q91s3g1KyDFJW0LqNNibpZi7YFylvGCzinm4p2Gbo768M5B2TJwaVnE2rW8YqSrT93jqy+j8721X0boc4+OZPxGEMRPBsneduWvO4a+azsRvLqj8uldkwPeBhDJ6Gl+4sBoHYEf790ntde8Dzow440lo72trVG5b/niQEYriXbala6HLxxUouvWK9qfcorpGZnu1ehJ9XFv9pzUePEQvyxgCZanuoFVxB9uRDUAyB0bQkA+ZjeistedCDzb9m5AfW3lo78Hq56RFLVff7/qQmO91g1BSccY6GNbfnSt4p7dkcVf37D9ddB8zVnBvboY6bEUewsbMYCaIvV1enjzqAs20m3fasaHdiDmzDNrVVBVB6kUx9xbvPy3XT73gkMq4T4cZGIc6rqGKPOLIm0clr5gefm4xiT/7zOs7o6tX8Vs25GgyY8IxaVBzlAz/ljxcRGN+kDkDgwOTT4D892GBt0ZvRTpznoHCFbChCYoU/LxwtwRFJA9Dn5pfgHEMe/YSIlTuKbJy44hVq8PB0tUum1YEkhVlpR92nLwjISIIk8Au0TuHYzTZHIIMhe9ePEX+DJOsKEvDGgSB3cxejeVMMJZVrsOo/d4yMngwJx+cYDu8LTLn6W7HT0hhHI/dsuJ148EC6p0NUgZrxIlmP2DLFQYszWvRo/JkVPOPuy4UEkbb1cvTU9jdIS0QVKswBbLULsJfkMastSMeuSsZfJPUX7FB5auhNkZictgtMu8fr01ZqPn
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2906002)(86362001)(508600001)(8936002)(31686004)(8676002)(4326008)(66556008)(66476007)(66946007)(31696002)(5660300002)(36756003)(6916009)(54906003)(6486002)(2616005)(26005)(186003)(316002)(83380400001)(6512007)(38100700002)(6506007)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bWJZMWhHT2pSaGhHYmxGcndQUjJsVnJRZ3lsTVhwdDZ0ZmxHMTFHZ1k3Q0tp?=
 =?utf-8?B?ekdab2JNVXN6NERTaFo5VUJTdDN0SDJSaVptS2UvZXZTb24reEVmaTNrU1dR?=
 =?utf-8?B?WG9xU2RmNnN3VzlqKzZHdnBTSVY5Zkw2YzdSL1lGOWFvcmlXK1lhMmVrSERG?=
 =?utf-8?B?QzF3YjZVazZMMXdNM3FSd29QVHh4eE95UEN5bkxSWTVNZ0JCRFVqRGwzR0oy?=
 =?utf-8?B?Z1RmSVhZb3RjVGUrTFVWNmd0SHFDOUMxY01IQldpblZCa2lRSVBBajNOQUdn?=
 =?utf-8?B?YnNvMFY2L2ZYbWVzZnJWSlp3YSs4Q2ZoQS94QnlwRHRnYVZXa0o0YWFqUkVN?=
 =?utf-8?B?YkpSUDdhNHdBY0dJYytidnVwQks5NE1SRUs3V0UrTlQ5dnZEVmNwQ2ZkdzNR?=
 =?utf-8?B?Q2pad3pjcGpsQUoraFVRbnNsN1lYNkw5RkdHajh0SG5XSmN1V2hnTnJrN0FR?=
 =?utf-8?B?OVE3eFVxM2c1MG1SYVYyeUxwemN1NENRSmZzRmNORzJDMTFreDM3K0d5SVNB?=
 =?utf-8?B?K3BvQVB1RHJIRlhKc1UwQXJIMDRBdUJZSXVVQlc4bTZhVlV6STZhL3Y1d2po?=
 =?utf-8?B?SVpzeHU1ZUJnS0ZkVmJZejNhY284blptZStBVEtOT0d3ZzR3YXY2Rmh1RVNy?=
 =?utf-8?B?VXJIQk5LYjJheUZETGRtaWlwNmw2Q0ZBbzFQcnhqY3RUcVJiN29MU25BM1Vw?=
 =?utf-8?B?QlhDTklwSXNNR1ZiZk9ub1kwdFpRaE1iZUtaK0JxMk1kVVYrSGNiek9MUUpp?=
 =?utf-8?B?OGJhYTJMTGN4dEc4L3FzYytEQ1V2OHZPd0dpOTZNNVJ5WFlSSy9DY0hvMTlu?=
 =?utf-8?B?WWp5b3RQVm42MDdYck1lN2h0eU1MN3FRTkNSOWlzM04zY3RCbWJTNjJYMnFV?=
 =?utf-8?B?ZFlhdDJNc1lFL3lqbnd2V2hsZUtKU2JnQ3ZlbTBodkdacDVkZ29PeW5zQWpM?=
 =?utf-8?B?VXdsVExoY0Zibk1tYTVYang1L3lqNVhOeUREU1lYMmRqQ2RNZ2ZXcm1icFBl?=
 =?utf-8?B?SGdsRElsMFU5RkIrWXoxTytYWnpKYXcvbE1HWUF6Qk16dmhkM1l1d1NPQkEw?=
 =?utf-8?B?aGd6Mjh3eFpCekg2aWQ1VEt2NU41Y0VXdnlydDV4YzFOVFh1VVdXdmFsdU8x?=
 =?utf-8?B?TjFIWkhjZmd5RTVwVytOV0FNYm55amRkTlZKbmc1YXRvZnRpWmhPaUVoR1Rk?=
 =?utf-8?B?dG1RTUIzMjZJcDJqMStmL2gzcWJ3dld6YU1ZdTZEZEsxQ1hYWHpFaEc4cE91?=
 =?utf-8?B?ZnBXVjl1cjdPazJsdkJrYjhFc3lzYTA5TDlzWkptc1JjRUNWejdOaFV3ODFp?=
 =?utf-8?B?ZU4xUURUMitKT1FrVSt6Mk5xRlZud3AxVGc0Q0FveTY1RkZXN2FEM1U5SEYv?=
 =?utf-8?B?UVZMSTFwZVFlQnRZRXJkaHMrb2pUWnY1RCtLTDFuY1paUUFwQW83M1U3STY0?=
 =?utf-8?B?RVp1YW5VMWI0cUlXUU5OMFVKTEtQekdlRlRmbUszV0E5OVZDNDZnZCs3bEp5?=
 =?utf-8?B?cHpLRU9maldPcXZzcGp1REp4ZGlZdGxUek5KYzRRVDlXSHNhc1BqUW1HbHBP?=
 =?utf-8?B?UzE4RmhVbUhnczhKYXpJMkhraWtzVkVZeXBFeE4rem9vYVJYSVVVSzVUSlRr?=
 =?utf-8?B?UkdUbG5FOFpvazlIMHNZT2h3UW5oWGlLK1JFVXlJajNzSVBkTUxLdG8wenhM?=
 =?utf-8?B?d01ieWZHeWU2ZWRVRHlhQndRa0t1WnVyVnhHSDVJQ0l6cDVDTkhOM0xNcFh2?=
 =?utf-8?B?REtaYVNJandnWHpzVG1aV0lLbUp0QVBLaUhzb2FOOWw0NDNyMTlQVzJQWUZI?=
 =?utf-8?B?cXJrTCtaN3BTNmpjQ3VyL2pHUHBiRDZHazJWeEhNcmViMlc5b0NucVdUMGE4?=
 =?utf-8?B?MnhVdi90WmwzZ0Nxa1FZOU5SSnl0SGRQcVIrVHYzU2JqVGtZaXQrRTZlZDYy?=
 =?utf-8?B?Zy9DZzdRckNITW85R293U3dwaitMT1Ewa2E1dGtMTFNoZ0ZCQVFwM1Q2cVV4?=
 =?utf-8?B?S2cybjlUajlqZG9uSDNaZEZKZzJSVFVDbjRoamJRR3RoWUFYaG44VnovZkJy?=
 =?utf-8?B?dnoxeDFhVHFlMVRtZWc4c05hUnNPMGRJVUMzUjRWZ3QyZmVKNHdtRG5kUXU4?=
 =?utf-8?B?UFQ4U3NFVTdJTU15bTdZMndodGYrbUtMbU9yRkROa3lWN09UL2hyU2ltYmVi?=
 =?utf-8?Q?PapaPvm/igA9g2tF7tjyTco=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b01c6eb8-42f7-49a2-0e8a-08d9f2b8260a
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Feb 2022 08:24:57.7139
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BswgXIsuHUQobfzrZNAdj/zCGmyOvPOIxFYOFmtU/j6yEkkIwhJonw2H3Ihb3UbgLVdvXd5aKJ29nspuI1mp8A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6035

On 18.02.2022 06:01, Tian, Kevin wrote:
>> From: Jan Beulich <jbeulich@suse.com>
>> Sent: Tuesday, January 11, 2022 12:35 AM
>>
>> Page tables are used for two purposes after allocation: They either
>> start out all empty, or they get filled to replace a superpage.
>> Subsequently, to replace all empty or fully contiguous page tables,
>> contiguous sub-regions will be recorded within individual page tables.
>> Install the initial set of markers immediately after allocation. Make
>> sure to retain these markers when further populating a page table in
>> preparation for it to replace a superpage.
>>
>> The markers are simply 4-bit fields holding the order value of
>> contiguous entries. To demonstrate this, if a page table had just 16
>> entries, this would be the initial (fully contiguous) set of markers:
>>
>> index  0 1 2 3 4 5 6 7 8 9 A B C D E F
>> marker 4 0 1 0 2 0 1 0 3 0 1 0 2 0 1 0
>>
>> "Contiguous" here means not only present entries with successively
>> increasing MFNs, each one suitably aligned for its slot, but also a
>> respective number of all non-present entries.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 
> Reviewed-by: Kevin Tian <kevin.tian@intel.com>, with a nit:

Thanks.

>> @@ -478,7 +478,28 @@ struct page_info *iommu_alloc_pgtable(st
>>          return NULL;
>>
>>      p = __map_domain_page(pg);
>> -    clear_page(p);
>> +
>> +    if ( contig_mask )
>> +    {
>> +        unsigned int i, shift = find_first_set_bit(contig_mask);
>> +
>> +        ASSERT(((PAGE_SHIFT - 3) & (contig_mask >> shift)) == PAGE_SHIFT - 3);
>> +
>> +        p[0] = (PAGE_SHIFT - 3ull) << shift;
>> +        p[1] = 0;
>> +        p[2] = 1ull << shift;
>> +        p[3] = 0;
>> +
>> +        for ( i = 4; i < PAGE_SIZE / 8; i += 4 )
>> +        {
>> +            p[i + 0] = (find_first_set_bit(i) + 0ull) << shift;
>> +            p[i + 1] = 0;
>> +            p[i + 2] = 1ull << shift;
>> +            p[i + 3] = 0;
>> +        }
> 
> some comment similar to what commit msg describes can improve
> the readability here.

I wouldn't want to replicate what pt-contig-markers.h describes, so
maybe a comment referring there would do?

Jan



From xen-devel-bounces@lists.xenproject.org Fri Feb 18 08:27:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 18 Feb 2022 08:27:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275202.470963 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKycB-0004Ys-OI; Fri, 18 Feb 2022 08:27:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275202.470963; Fri, 18 Feb 2022 08:27:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKycB-0004Yl-L5; Fri, 18 Feb 2022 08:27:43 +0000
Received: by outflank-mailman (input) for mailman id 275202;
 Fri, 18 Feb 2022 08:27:41 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qkm2=TB=intel.com=kevin.tian@srs-se1.protection.inumbo.net>)
 id 1nKyc9-0004Yf-B1
 for xen-devel@lists.xenproject.org; Fri, 18 Feb 2022 08:27:41 +0000
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a09246f6-9094-11ec-8723-dd0c611c5f35;
 Fri, 18 Feb 2022 09:27:39 +0100 (CET)
Received: from orsmga004.jf.intel.com ([10.7.209.38])
 by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 18 Feb 2022 00:26:38 -0800
Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19])
 by orsmga004.jf.intel.com with ESMTP; 18 Feb 2022 00:26:37 -0800
Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by
 ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.20; Fri, 18 Feb 2022 00:26:37 -0800
Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by
 orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.20 via Frontend Transport; Fri, 18 Feb 2022 00:26:37 -0800
Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.176)
 by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.1.2308.20; Fri, 18 Feb 2022 00:26:37 -0800
Received: from BN9PR11MB5276.namprd11.prod.outlook.com (2603:10b6:408:135::18)
 by DM6PR11MB3915.namprd11.prod.outlook.com (2603:10b6:5:19c::11) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.15; Fri, 18 Feb
 2022 08:26:35 +0000
Received: from BN9PR11MB5276.namprd11.prod.outlook.com
 ([fe80::f514:7aae:315b:4d8d]) by BN9PR11MB5276.namprd11.prod.outlook.com
 ([fe80::f514:7aae:315b:4d8d%3]) with mapi id 15.20.4995.016; Fri, 18 Feb 2022
 08:26:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a09246f6-9094-11ec-8723-dd0c611c5f35
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
  d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
  t=1645172859; x=1676708859;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-transfer-encoding:mime-version;
  bh=l/f5xypZqjw2suVXTiTVySGThvVTUm5eh/LMP1QVt+c=;
  b=hO6OdeSOPIfQW/DghDsAjQXZVTp1wUUNNzxEQWCRsZJ+h5D0Fq1BM14i
   z2BxPQmA1700z/X/QXWQjR00yFus0gJOuIm4PA9aFDoKezIOl+DGpOg7h
   o8nMRqFoKNuApWFccWWnXKrGfabduFf4A1OmX3eJhgm5ejkyXI6uBjDRn
   U0Ne+eIj/PXdbxPG9T+y6f8liZ+6RgVV8T/hRaDvACZux+zp37ar0mChM
   dr13gkrrB4qjZR8gYw58SsZRN6jZWkR5eADcMHAlI5Lbi0bq9FtOlieDh
   iQ/fyn9Lg6KtlMv32U/D7eKQ3XC7TJMq2+FrcSYqh4fciiuUgGGUgCkVq
   A==;
X-IronPort-AV: E=McAfee;i="6200,9189,10261"; a="251279878"
X-IronPort-AV: E=Sophos;i="5.88,378,1635231600"; 
   d="scan'208";a="251279878"
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.88,378,1635231600"; 
   d="scan'208";a="637670128"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=k7Ga0UM1ZylmcVtZYWH5ME0FhcyQsYqpYOaYtXqHHA9HfcqCVKZPlBhaCDekbrKVnps7AJjlepJW/wL0yBHOaGgl/pswgwYqOw4XRy21NSExJ1LMiBWCzlz9UD0gpAz6AME5oxrNujMNGs/ZlvKDEcYTuiw1fkU6zNiFshriyvNBbbTQ8LiI7TDUjkJKXwFmNzkuF/AHW4RGFQKXtx6JkfZvYu9hDnzyRhXrmFTnflgciacALwjRyYi3zsrhAEpe8LFPAvtqzQFJs4/zMCB7ihhKkNS4IU3Mp/q3yT7/Bf75fiUT855nNci6CmdztzIU1yGpeYmyH+zIJjCpzWw11A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=l/f5xypZqjw2suVXTiTVySGThvVTUm5eh/LMP1QVt+c=;
 b=oCMXcXGytK1Q881eNOtXC1gdaat18ltby+j/xN2WyJEQA3iIfuINAbdpMZ9UfyDzPYjfg6JyX0/ZBEGPm4RZbQRZVptjEfScF0OD+v9luUhmjTdnvcr1PqZ3feQC16dS5fVWXVyNPyWvPNrt/vpQh/WVSEl/y4wSluPeBFHH2BlJ/PVFt2GFv5BY/kURXDG1BwwbwavArXy9j8CHpWQS0tfyiXVVla0EeWqOn+Plhy24k75mm0rbWZROWLpnwQE6jChJNnSIKCCVdMmg9S6fi6QgVCG5HWyDO+7NOHKnLrmQcwAtVS/TeEC39L3oZ2vVwQuNvGKVq2zInZbOS9U4BA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
From: "Tian, Kevin" <kevin.tian@intel.com>
To: "Beulich, Jan" <JBeulich@suse.com>
CC: "Cooper, Andrew" <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>,
	=?utf-8?B?UGF1IE1vbm7DqSwgUm9nZXI=?= <roger.pau@citrix.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: RE: [PATCH v3 17/23] IOMMU/x86: prefill newly allocate page tables
Thread-Topic: [PATCH v3 17/23] IOMMU/x86: prefill newly allocate page tables
Thread-Index: AQHYBkAJc6JSR61nEESS/gtIFkcsm6yY/BvAgAA5aYCAAABjEA==
Date: Fri, 18 Feb 2022 08:26:35 +0000
Message-ID: <BN9PR11MB52765F822E3D17CAB12817AC8C379@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <76cb9f26-e316-98a2-b1ba-e51e3d20f335@suse.com>
 <b985d619-05ea-73c1-1919-b0343e5a9b8e@suse.com>
 <BN9PR11MB52763A2638F1460EC83420B38C379@BN9PR11MB5276.namprd11.prod.outlook.com>
 <78991818-ca76-2065-3511-f7e62a3f2e0c@suse.com>
In-Reply-To: <78991818-ca76-2065-3511-f7e62a3f2e0c@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=intel.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 00f23e28-4363-4b7e-3acd-08d9f2b860aa
x-ms-traffictypediagnostic: DM6PR11MB3915:EE_
x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr
x-microsoft-antispam-prvs: <DM6PR11MB3915DD4F6B6C2C861D3EFD108C379@DM6PR11MB3915.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:7219;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: TspQshZLq8ar8K8xIi076ax7oisbRYOiBIaqZajfvYr0xLcDwJ9PdXrVynHx8/wFjqYSfNPff5U7lwFNlArHWHUiOsLKSkwtU72Z4qlABSjGeSi6YvX90ngSxb2xox7vFBOok2mVj36uB6ty1P260sSBmm8jWGMGa8oPYfzfsqM1yjTFOWh+r+/WBg43Hq0907Np49CnpopaB4IQG4FM5TmkqGAojETsrLuGecrva+vlphwuvW4LE6ESXDjbeuN/PonUCIloKHlZyVp49gpo/HKIaL+KjXBroIs9gWCYIsX6/B9FUGF1czDVPsdXZoUA6bWYDd11VbTSWV6z+icq5GQpzPiBssrHHT8ShsL77p2UItrDtLR1pzLq3gCzFw0bogJgNiFyfVzLqSoCm6Y/cmXwq2FCfp+bWtvBiZ1FpkHWksernZSpMAC7ipxWd3aBAFQKVki9moo+1nW17ugBSCcb+36hmnFITNRkwMvCNjGkXtW2D+RMjMVPGGqXDYzXm7LwqjYLBai18c80LBuHO/euJJ+kObrhTaSFGEXUqmrNdQEtbq1xfG5KtK/myi5jNFNn6dUpBT3oaEMQ+bynNQIkmWtxV18iNA3QB4U2051uXaI+gowcgnMefryjerHesSkCniDka1trhUtnTVDeQLWmaad+skh+jgm18HP409nUqFA4PRkP59cvfUgxyZMEtdtlNSeDizFRSFgBWhQCAg==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5276.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(76116006)(6506007)(122000001)(508600001)(38100700002)(186003)(52536014)(2906002)(82960400001)(5660300002)(8936002)(66476007)(83380400001)(53546011)(86362001)(38070700005)(7696005)(66446008)(64756008)(66946007)(66556008)(8676002)(26005)(54906003)(6916009)(316002)(9686003)(4326008)(55016003)(33656002)(71200400001);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?cmYxQ2JmbnhnMnBXdHVCMHlEc3Z3V1hqRFNXTHBrcjNHNUdKVGlMVU5vdXox?=
 =?utf-8?B?RGFTK1lueHpMMGg5aW5CN0t1a2NlMlpWa2ZUKzBvbi81TFZnK014TGMzNi9M?=
 =?utf-8?B?aTI3MEdRWWRRSHM4eDFSTmF4K0FDdjljVUF0UGwwMUI1MnRYdVJub1I2RTc3?=
 =?utf-8?B?UEQzUjVnR1BsTEFOWEN5RTc3OFdnR0xyVGsvbDY0TU9sRTBQbGlPN1orcmtE?=
 =?utf-8?B?VE9kOXM5cStUb09UZHhrZUZLZjJHaHI3bmdtK1N0cXhYUlJUbWZoQlhLQktT?=
 =?utf-8?B?NGJpN3VzOWF5WTZwUkNGSjNkbTZGOWF3amVZaUpvYlpxSmJkLy9vRGo5ZFZE?=
 =?utf-8?B?cFFwVnJYNTVMdzVSTjZ0QXlXMWF2Qk9NdW4zQUxic1lZOVU5RkNsVDYvL2ly?=
 =?utf-8?B?R2lGYXltRDl0M0lYWkpQTFYzeHN3K0wrOFFXN2Z6c3Q5M3FlcFRRcVd0b24x?=
 =?utf-8?B?OUdhS01wTXM5WWxQV0VzKzJjekNSb2ROSUNwVC9PMHprb1BhR1dsbVBKYXps?=
 =?utf-8?B?bWtTM1JtOU9EMElnSlFERFBVNVcrUisyV1FKR2F1QWhKV3BpMkRjUWpzQ0V0?=
 =?utf-8?B?WDROT252RU5INzBLclNISCtzTzZBTzVrMDV5VFlOVXByRG1YMzh2cDZJSFA1?=
 =?utf-8?B?eGNRLytzaStjRFQ3eHNybjI0ODd3UnJZM2ZUcWdwSTZ3VDlmV0NKTmkxWGZW?=
 =?utf-8?B?Tmp2dEZPdy9MUmpMeGQrTWFLVjZPNXh1eVp1Z0ZHcEE3YjJKUEErWjFZVWRu?=
 =?utf-8?B?Z0srdlFYWTZSRmZlMTVyQWUwSmJITHo2T2V2SVVPTjh4UFQ2QTNjNklYL2lU?=
 =?utf-8?B?QWxFNFdVdmVONWpjclFvdUV0QzVWeGQ4OTRHSkFXaUo0OGt3YkFQcmxDMUUx?=
 =?utf-8?B?Rk9nUGNFQS9jZDE5TTBtd3dHUXIzeWVjcW5yMGhOcUk2TlNwS0lHRHhwbUdL?=
 =?utf-8?B?YjV6TlVlVHgwaElkTjJlVTFqZ3kzYi9aZ0xMbUdxbDFjbjAzQk5xZjNEWlFz?=
 =?utf-8?B?MjdyUWpXTzhKZmhTckFaampoaTFudUhFTTc2bGZBS1dSemVDS0FPR2w4M0t3?=
 =?utf-8?B?ZHZjS2RTcWZTRldtaFA0TDV1RU42Y3NDaEpPMmU5bFJSaGVlUkNTN0IyWm1r?=
 =?utf-8?B?cmNIQUtoSzFrSUZnQm5ldFMvL3FrOVh3Q0F6eEhhZVNaV2tiejd4cDdJQXVM?=
 =?utf-8?B?S0NJVjhPZEF6RWRVNXU0UkNtNW1VckZGTWJRRy83YkpsWkdCSFhrdnJYUlZ3?=
 =?utf-8?B?Mkd0cE5BY3ZEczJpMFQ4Z2RhY2wxMHQyUDlEdVk2SVVpeGMvL1Q2OEltMFVJ?=
 =?utf-8?B?UWtGNTFGMWRHalBrUXgzVHNBeWxTRFo1OW1DUWNDazlydWFMQ05SZytRRCtm?=
 =?utf-8?B?STRWMWQrMmN2K0F4RDNGNjJBY2dLWUFuRWZjNnF6MHFZWmRJNnRpSUFKZmNX?=
 =?utf-8?B?b04rS1BsdS9JSXB2dGVtQkVPZGRwTEZNVG02WE1DV2ZTZEp1bFlQNU9oT0l1?=
 =?utf-8?B?RStMVXoxdFpzREtrNWtqWHJzZkVienlVU0txNjFjNklOQjdvMDRaMGJQY29J?=
 =?utf-8?B?ZS9aejV5cUMwN0Q5bHhtQkFXTHZWTVF3RFN1SkFNMnBXZ2NmV0xvdXk2Y0VB?=
 =?utf-8?B?QjVVZU9hZWVpTXhucFh2SndTSTBBaEhtTkwvK1A3STBSRGFLeWx5S1ZWQVpx?=
 =?utf-8?B?QWlEak1xZUQxVGI1b3BiVDRTMlNYMXI3WUtMUkxCT21KeWxWMG1wZTNJaVht?=
 =?utf-8?B?VkV2TnhONGhrY1hpa2dTY1R3Q1owZTFPS0tWT1VwZWd2Y2hQenpzODMzeVJB?=
 =?utf-8?B?TnNVTjJ1TDAyYU1qTEF1ODAzc0FKNFpWeGdEY0hlL3NSWTlyS1NYdW93Smdy?=
 =?utf-8?B?cUhrZFE2d0JFMVdXOWlxK3ltdHo2S04zZVduVG1jVkhyZFcyQmJEdHprSVd6?=
 =?utf-8?B?bEMyR00rcTczNmppVDFrMGxQcHUzYXFLcEpXcUFYNlpMY09HVW5yaDZOTlRP?=
 =?utf-8?B?SHIzWGZPL25tSVRydmRpT1RMaU9XbE4xZHhCRU51Y2xWUEpWc2tHRGpvOUUv?=
 =?utf-8?B?WlpFK1VUOEtzQzJVTndEeUI2RldPa3VzWkJ1WWFRbyt2Tmh3TGJlSjZlcFlC?=
 =?utf-8?B?QUVXRXRzL1lqczlDR2lPNEFmcGVQSmJ3aWljOEJLVXkxaWs5WFNFNEcvY2ds?=
 =?utf-8?B?TlE9PQ==?=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 00f23e28-4363-4b7e-3acd-08d9f2b860aa
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Feb 2022 08:26:35.8527
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 1NqJE7CmSxn7EqmmEG8H32HYTg/S/W7560LQmZPE2RRXFRRraPD5BL3Bw7T+4OoY2Dzhl4vddU3lH5+mTQGSCg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3915
X-OriginatorOrg: intel.com

PiBGcm9tOiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+IFNlbnQ6IEZyaWRheSwg
RmVicnVhcnkgMTgsIDIwMjIgNDoyNSBQTQ0KPiANCj4gT24gMTguMDIuMjAyMiAwNjowMSwgVGlh
biwgS2V2aW4gd3JvdGU6DQo+ID4+IEZyb206IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNv
bT4NCj4gPj4gU2VudDogVHVlc2RheSwgSmFudWFyeSAxMSwgMjAyMiAxMjozNSBBTQ0KPiA+Pg0K
PiA+PiBQYWdlIHRhYmxlcyBhcmUgdXNlZCBmb3IgdHdvIHB1cnBvc2VzIGFmdGVyIGFsbG9jYXRp
b246IFRoZXkgZWl0aGVyDQo+ID4+IHN0YXJ0IG91dCBhbGwgZW1wdHksIG9yIHRoZXkgZ2V0IGZp
bGxlZCB0byByZXBsYWNlIGEgc3VwZXJwYWdlLg0KPiA+PiBTdWJzZXF1ZW50bHksIHRvIHJlcGxh
Y2UgYWxsIGVtcHR5IG9yIGZ1bGx5IGNvbnRpZ3VvdXMgcGFnZSB0YWJsZXMsDQo+ID4+IGNvbnRp
Z3VvdXMgc3ViLXJlZ2lvbnMgd2lsbCBiZSByZWNvcmRlZCB3aXRoaW4gaW5kaXZpZHVhbCBwYWdl
IHRhYmxlcy4NCj4gPj4gSW5zdGFsbCB0aGUgaW5pdGlhbCBzZXQgb2YgbWFya2VycyBpbW1lZGlh
dGVseSBhZnRlciBhbGxvY2F0aW9uLiBNYWtlDQo+ID4+IHN1cmUgdG8gcmV0YWluIHRoZXNlIG1h
cmtlcnMgd2hlbiBmdXJ0aGVyIHBvcHVsYXRpbmcgYSBwYWdlIHRhYmxlIGluDQo+ID4+IHByZXBh
cmF0aW9uIGZvciBpdCB0byByZXBsYWNlIGEgc3VwZXJwYWdlLg0KPiA+Pg0KPiA+PiBUaGUgbWFy
a2VycyBhcmUgc2ltcGx5IDQtYml0IGZpZWxkcyBob2xkaW5nIHRoZSBvcmRlciB2YWx1ZSBvZg0K
PiA+PiBjb250aWd1b3VzIGVudHJpZXMuIFRvIGRlbW9uc3RyYXRlIHRoaXMsIGlmIGEgcGFnZSB0
YWJsZSBoYWQganVzdCAxNg0KPiA+PiBlbnRyaWVzLCB0aGlzIHdvdWxkIGJlIHRoZSBpbml0aWFs
IChmdWxseSBjb250aWd1b3VzKSBzZXQgb2YgbWFya2VyczoNCj4gPj4NCj4gPj4gaW5kZXggIDAg
MSAyIDMgNCA1IDYgNyA4IDkgQSBCIEMgRCBFIEYNCj4gPj4gbWFya2VyIDQgMCAxIDAgMiAwIDEg
MCAzIDAgMSAwIDIgMCAxIDANCj4gPj4NCj4gPj4gIkNvbnRpZ3VvdXMiIGhlcmUgbWVhbnMgbm90
IG9ubHkgcHJlc2VudCBlbnRyaWVzIHdpdGggc3VjY2Vzc2l2ZWx5DQo+ID4+IGluY3JlYXNpbmcg
TUZOcywgZWFjaCBvbmUgc3VpdGFibHkgYWxpZ25lZCBmb3IgaXRzIHNsb3QsIGJ1dCBhbHNvIGEN
Cj4gPj4gcmVzcGVjdGl2ZSBudW1iZXIgb2YgYWxsIG5vbi1wcmVzZW50IGVudHJpZXMuDQo+ID4+
DQo+ID4+IFNpZ25lZC1vZmYtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4g
Pg0KPiA+IFJldmlld2VkLWJ5OiBLZXZpbiBUaWFuIDxrZXZpbi50aWFuQGludGVsLmNvbT4sIHdp
dGggYSBuaXQ6DQo+IA0KPiBUaGFua3MuDQo+IA0KPiA+PiBAQCAtNDc4LDcgKzQ3OCwyOCBAQCBz
dHJ1Y3QgcGFnZV9pbmZvICppb21tdV9hbGxvY19wZ3RhYmxlKHN0DQo+ID4+ICAgICAgICAgIHJl
dHVybiBOVUxMOw0KPiA+Pg0KPiA+PiAgICAgIHAgPSBfX21hcF9kb21haW5fcGFnZShwZyk7DQo+
ID4+IC0gICAgY2xlYXJfcGFnZShwKTsNCj4gPj4gKw0KPiA+PiArICAgIGlmICggY29udGlnX21h
c2sgKQ0KPiA+PiArICAgIHsNCj4gPj4gKyAgICAgICAgdW5zaWduZWQgaW50IGksIHNoaWZ0ID0g
ZmluZF9maXJzdF9zZXRfYml0KGNvbnRpZ19tYXNrKTsNCj4gPj4gKw0KPiA+PiArICAgICAgICBB
U1NFUlQoKChQQUdFX1NISUZUIC0gMykgJiAoY29udGlnX21hc2sgPj4gc2hpZnQpKSA9PSBQQUdF
X1NISUZUIC0NCj4gMyk7DQo+ID4+ICsNCj4gPj4gKyAgICAgICAgcFswXSA9IChQQUdFX1NISUZU
IC0gM3VsbCkgPDwgc2hpZnQ7DQo+ID4+ICsgICAgICAgIHBbMV0gPSAwOw0KPiA+PiArICAgICAg
ICBwWzJdID0gMXVsbCA8PCBzaGlmdDsNCj4gPj4gKyAgICAgICAgcFszXSA9IDA7DQo+ID4+ICsN
Cj4gPj4gKyAgICAgICAgZm9yICggaSA9IDQ7IGkgPCBQQUdFX1NJWkUgLyA4OyBpICs9IDQgKQ0K
PiA+PiArICAgICAgICB7DQo+ID4+ICsgICAgICAgICAgICBwW2kgKyAwXSA9IChmaW5kX2ZpcnN0
X3NldF9iaXQoaSkgKyAwdWxsKSA8PCBzaGlmdDsNCj4gPj4gKyAgICAgICAgICAgIHBbaSArIDFd
ID0gMDsNCj4gPj4gKyAgICAgICAgICAgIHBbaSArIDJdID0gMXVsbCA8PCBzaGlmdDsNCj4gPj4g
KyAgICAgICAgICAgIHBbaSArIDNdID0gMDsNCj4gPj4gKyAgICAgICAgfQ0KPiA+DQo+ID4gc29t
ZSBjb21tZW50IHNpbWlsYXIgdG8gd2hhdCBjb21taXQgbXNnIGRlc2NyaWJlcyBjYW4gaW1wcm92
ZQ0KPiA+IHRoZSByZWFkYWJpbGl0eSBoZXJlLg0KPiANCj4gSSB3b3VsZG4ndCB3YW50IHRvIHJl
cGxpY2F0ZSB3aGF0IHB0LWNvbnRpZy1tYXJrZXJzLmggZGVzY3JpYmVzLCBzbw0KPiBtYXliZSBh
IGNvbW1lbnQgcmVmZXJyaW5nIHRoZXJlIHdvdWxkIGRvPw0KPiANCg0Kc291bmRzIGdvb2QuDQo=


From xen-devel-bounces@lists.xenproject.org Fri Feb 18 08:31:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 18 Feb 2022 08:31:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275209.470974 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKyfh-0005xu-8f; Fri, 18 Feb 2022 08:31:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275209.470974; Fri, 18 Feb 2022 08:31:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKyfh-0005xn-5U; Fri, 18 Feb 2022 08:31:21 +0000
Received: by outflank-mailman (input) for mailman id 275209;
 Fri, 18 Feb 2022 08:31:19 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=v1rr=TB=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nKyff-0005xh-PV
 for xen-devel@lists.xenproject.org; Fri, 18 Feb 2022 08:31:19 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 24a8d434-9095-11ec-8eb8-a37418f5ba1a;
 Fri, 18 Feb 2022 09:31:18 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2059.outbound.protection.outlook.com [104.47.14.59]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-38-bwnr58lXO_Cn0k5-iKhrHw-1; Fri, 18 Feb 2022 09:31:17 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM0PR04MB5746.eurprd04.prod.outlook.com (2603:10a6:208:131::31)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.17; Fri, 18 Feb
 2022 08:31:15 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4995.016; Fri, 18 Feb 2022
 08:31:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 24a8d434-9095-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645173078;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=S2WcSMWv6vYT6GuxsW7yHK1xG36f0wjL73/6I1eRVEU=;
	b=jHAX3hjaJ7a6wZusMU+8gM/xTn4lj635X8qHTfo7DvncFS31Q8hsZHCxyktQm9oGKhxKRg
	HyB7NFOVVeGSk1lK6FtGQLQgswtPMZEF/sNif92Oy6LmXjXZPjcn1NjUlMwZkkX3fnDEJT
	C/U+fzZ7sm0+Je72i/Wg2x9L5cCm5Es=
X-MC-Unique: bwnr58lXO_Cn0k5-iKhrHw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=lG5LsHdHQOKIQ0T4aiEQUwvT3R3Fj3ycsmi3lUlDewprFW6/nIjnGtgmRTQD7nW2U27wh0C0aqHHT8rXDUhjUgf2vQnp2nwZLrtMPDOYcqsnCTLXZ7MgaClaQ5ejU2bb8XEV7mXv0/7p1rtgtWb9AAHwdJA5yABylZvP5l9dnxm03bbQxlCY9B1G7jfqGaj15hCdObXwqRZnhToEWAFPOEbJzEPfcYtlV3AoX5nS13gdS2T03/7Yp2SKnKPhu8jkwXo3ARyvu1Bfr7wZthx1N+Y2TavA/fM3MA4A43x2nW7/L/hn6479qot5f0EvfkwnxNdHwnoEKd9kzwBv+veBzQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=S2WcSMWv6vYT6GuxsW7yHK1xG36f0wjL73/6I1eRVEU=;
 b=mXyHXepIBB3lXpWYvVRPWUNoyiagThiPWtCu+JtiSJDKT14OJIAqzz7NubcMnEmkx06lOgzwG/C5pVOXpXeRfQxbENx4N9nb8wVN+kQB41bgvJCYYfWx8dzLW7gYkf8vCxZ6EWzYJDP2xRxxbZW63Q0j1QaZq9Mzo6eLE8AkQOuGgTDAPHFMP0b5n0d3Hl7GdsTzpzAO2PZtCWqSGDfG3Ed1WXOHPEsoF3lf92rDJ/TiFUWivm9Y3T4PM2cKvgATXhk8eyacH4DEFfwC6aYjlPkLhunItWGFYAoSpWV5BgUMO1aaIk1BvsTpMC9MZ9cIhADMhOxtARFBuQVzDeR6Ew==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <9432990c-6de4-ad12-e9fa-12792200748a@suse.com>
Date: Fri, 18 Feb 2022 09:31:13 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v3 20/23] VT-d: free all-empty page tables
Content-Language: en-US
To: "Tian, Kevin" <kevin.tian@intel.com>
Cc: "Cooper, Andrew" <andrew.cooper3@citrix.com>, Paul Durrant
 <paul@xen.org>, =?UTF-8?Q?Pau_Monn=c3=a9=2c_Roger?= <roger.pau@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <76cb9f26-e316-98a2-b1ba-e51e3d20f335@suse.com>
 <807a48fe-3829-d976-75dc-1767d32fb0f4@suse.com>
 <BN9PR11MB527622E58C2E4EF90CF29EF88C379@BN9PR11MB5276.namprd11.prod.outlook.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <BN9PR11MB527622E58C2E4EF90CF29EF88C379@BN9PR11MB5276.namprd11.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR04CA0052.eurprd04.prod.outlook.com
 (2603:10a6:20b:f0::29) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 0aa9d653-9ab9-4346-f467-08d9f2b906f2
X-MS-TrafficTypeDiagnostic: AM0PR04MB5746:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB5746A29B9DB772B42739A1D3B3379@AM0PR04MB5746.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7219;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	SlMryBsF/Uj08xQm/GPfvOoxosY782JgDLurOO+WbIoxyT54dAccSjR35eQESNztt+V/R8kHZA7Yq0ksl/Sj4yO8mEaq2mYy9PLLukeI2OPgjHIgP+S1K2s7haj0ZgefsRFA9nGvHeTnd9hQcYmmRZck4QfPHKBT/TCZGMt7ziMHATyObp/DpUkMIk3s2zpP/i+W+z51Tab9POxQctSZ11FmE5zqkToY8J6gFIB1zoYuXWvfjkoPLcvvlSFAuqS9u37d4UJkSZ+bv1AmZyYe3BrXUlrJnU9EbHYincCSt6jXuFYGuivXpegREAmEwwsZcULHRs5welap2VNLVZKQRdyFPFBGd3cNQ2OgpGVANmFOFZmd4csp5QVrnq3agOIqJKV9X0acM+/FTl4fImkxAGuZB/4O/P1YiOHhZNDwQep672qTgeOgBIKcYn0eOVYJ7BSVAKBo4FZuOR5PGoLyGinMu3euPWGCYI0HISVxcGnyu4manAYleO9S+kuSPyDPjYUS9QG1hhTN6mm0QJi2tIXDnWQpyLii3JcEt5Qp8cKq4nTh4xF4XNkhiY8iwuSbxNP7KX4qYbslJgcT/RuSf8Bwa9aVnZ6G14qD+x8ObYuTaaVJPnxUPBeNqIKP/+dnf5qQpjWxKxHszTIkHOm2apg4bnYVxfmN853vyQcVMGCR6qTigKX/wg/zkX6M8t9Tl7iT09fiSYc4xkt4+weGRPi1XnsxW+rhYHXJxKXxSFrf43GH72bGIn1jYyDeaAQz
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(54906003)(316002)(66946007)(4326008)(6916009)(31696002)(2906002)(31686004)(66476007)(66556008)(53546011)(2616005)(86362001)(26005)(83380400001)(186003)(6512007)(6506007)(36756003)(5660300002)(8936002)(508600001)(6486002)(8676002)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VWM4R3FXVDBMaklBNlYreDdpWG16V1VVVlREeUFGRnJjSVVNcmYxbldxQUpQ?=
 =?utf-8?B?VTBQWnBSSGZ1WFhiVXF4MG1BYmpjYnhJRnVtRjRhY3pGSTg0dXZ1bzVjR0VP?=
 =?utf-8?B?Q3NGeFR1RXpPdGRBWDRhbG9Vd3pSZlNiZDgydHdzeE5OL2Q5NFBxdVppbDZO?=
 =?utf-8?B?MGZwcHdpeTRqTklWRjZnYmxxZkNpRkNMbG9DaDVITGNkTjE3aXNQSVpqN0Ev?=
 =?utf-8?B?NGlnaFpjMitqK3p4SUxxRzBYSlRWM2NLMVZMTVdQL3NGQ0wzWXVOWFdXNFZo?=
 =?utf-8?B?WTNBQ0R5STVKc3g5UC9ZSlNyNXhoKzFzYys3VHNaV1FEdUVnRWRIcDgrbWZi?=
 =?utf-8?B?VDU3K2NUS3V2T2IvMGdIUUFNN2JIOXVFdzNvMTBFamNSR1ZkUVdKQ0ltWVBK?=
 =?utf-8?B?V1lKVzQvZHpPWUdUa3ZqYkRZUC9ja0tYZWw4ZlhUYW5CNzlmRkVTMGFJWVdI?=
 =?utf-8?B?UTNXSDJKbXk1dThqN3pqYzJiZGdUOTBBTG45YXBXNFR2VmowN3IwSnplYzZn?=
 =?utf-8?B?MUUvS3Q3SzliV2VsZFJUQW0rMEFia2tSQW1weTFCRXVCSHlOeUkycitVdHZQ?=
 =?utf-8?B?QTdWK2w5dFlzdlVSVXZGZC9QYytLMklwWjVPcU56djVUb3hVV0xzZS9RVTJP?=
 =?utf-8?B?SXBZNXRXaVpKcWkrc1gzcmU3QytoSlI3NzdhNXE1aG9TZC8wa0VoQVovTCtt?=
 =?utf-8?B?cmdRajB4eHV0UWhmU1l3blgwRDgrR2ZFK0dYS3I4Q3AzeHduUE5JTXVGQTQv?=
 =?utf-8?B?Yk5hRjVmNUpmeDV6cUk2MDlTODNZNFJqeSt3UklEYk5BczB2MFZsN3htVzln?=
 =?utf-8?B?MVdRWlIzQTE0TUtkZ3A1YmluMlkwSFZzZWU1MzVXOUd4TW5Zck9HeWIwNzZX?=
 =?utf-8?B?a0NRQ1RWSENhS0pPRy9ydEx6alZlMFZLTElhSE5HQlVObjNQZnY4NnY1RUpH?=
 =?utf-8?B?SWJac3FQZUY3eG9JanJOWnZ5eXAyVjBCZlBTUmxvVnBYeEE5SS9nMDN4eGl4?=
 =?utf-8?B?MDl0OVlCRFd1MFdYTnAwU0pXUDRBVDVLL2RLbWZxcmcwWDF2d2lnSSs0QTNo?=
 =?utf-8?B?bitseUo5M21WdWMzVVN2Z2JTYjh5SncxeENFQzNWNStVRGRaNGRxMEY2OGdS?=
 =?utf-8?B?ZzlrWVhkL2MzMGF1eW9YRHNtSkd3djlTUUxvV1o2dWpsMmpyQ0cralBXZFcz?=
 =?utf-8?B?YUF5eGhsWGRuNzUxNTEzSmJ3cnRyZmxBTlZPYnlnQjZadUZlSG1uT1RCcEZM?=
 =?utf-8?B?TUl4UHdzdURHaVBaeW9KODN3a1hBOXk3QWFGYXoxdDZGUEozRUd0RkkzMXBD?=
 =?utf-8?B?ZWoxdVN4Zk96ajBaMTBuRklaNWN4R0p3dkg1Um1iYkhObHZ3TVNhU2tQZXRP?=
 =?utf-8?B?VjZ1bFBVcC9jaGd6Ym1SNGdaTCtqMVFOTUpwS3FBbWN2cG1QWjNzdVlFTkdw?=
 =?utf-8?B?NFBPNUVoYlltVmNOYVNDTkJKQ3FzY0FPcDZOdDd4L24wTTVpOVozR3BzMU5o?=
 =?utf-8?B?MWdyczJjYjNZcWhhOU00MVVFN0lJYWNRdVBjamRwbEZ3dVd3Q3FGZkpQNjlP?=
 =?utf-8?B?eGNISWlDSHhRL2tSY3JQVTNCY3c1bzBVNHowZVNlSk9XR0xiWFZlVFlJdGhC?=
 =?utf-8?B?VFJydUg1TUxLcytjRWZ1bHNhZnVESUZtUC9vK28vUG9HMG9XSUFHc1lmd1Zm?=
 =?utf-8?B?VWg0aTJpak5QTWtOOWNkWEdMVzZiRXdWU0lRVXRnVjFtOC92V2tjSEhTVUR6?=
 =?utf-8?B?TTVqQlN2cFZnQjlLR2tDS2p4SUgzZ1h0eU1PY1JVaDNFbkpndHBZd0RsZXVP?=
 =?utf-8?B?WXgyZ1d0cHNVRFV0c3pQNFdINmEzSXc0N3l1Q0NUVkNZODN3SnI2Z1AzTDNS?=
 =?utf-8?B?TDFKcVlLcVVJbUNGT3pSTmZuWUtKRll1eSs2VmZ2YlpYL3daZVltaEpvNkl0?=
 =?utf-8?B?SFRsamNJWG9MTnFSaWZOSGh5bjhEaU5yUVVwbkhwMU5MbGIrcll0SXMwRTFx?=
 =?utf-8?B?blJlRWQrOEYyTTZ5a3RRWldmRVgraW9GbFZUSVBKT3RBamlnbEhzL0NvVTht?=
 =?utf-8?B?SjloQ2I0eCtvMS9CNk5sMTJJODhhTS8vY2gzVzlTSStwajlncnZtSGFSbG81?=
 =?utf-8?B?U0YvL3NwZWxWQ1JkUExvbVZNdnh6T1NjQzI5MGZDYlBCWVJHM2pXZjBoM1NP?=
 =?utf-8?Q?APvRb7zSNA4eRs5PQHfFtpI=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0aa9d653-9ab9-4346-f467-08d9f2b906f2
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Feb 2022 08:31:15.0499
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /ynMpSSECP6Kd30E+gAiqgH3CCVGW3QDCgpwPNHy+pA14uhfD7cxPUTSPs9pUW5HQHCewCxiEwBD5BYdMyUdUw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5746

On 18.02.2022 06:20, Tian, Kevin wrote:
>> From: Jan Beulich <jbeulich@suse.com>
>> Sent: Tuesday, January 11, 2022 12:36 AM
>>
>> When a page table ends up with no present entries left, it can be
>> replaced by a non-present entry at the next higher level. The page table
>> itself can then be scheduled for freeing.
>>
>> Note that while its output isn't used there yet,
>> pt_update_contig_markers() right away needs to be called in all places
>> where entries get updated, not just the one where entries get cleared.
>>
>> Note further that while pt_update_contig_markers() updates perhaps
>> several PTEs within the table, since these are changes to "avail" bits
>> only I do not think that cache flushing would be needed afterwards. Such
>> cache flushing (of entire pages, unless adding yet more logic to me more
>> selective) would be quite noticable performance-wise (very prominent
>> during Dom0 boot).
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> ---
>> v3: Properly bound loop. Re-base over changes earlier in the series.
>> v2: New.
>> ---
>> The hang during boot on my Latitude E6410 (see the respective code
>> comment) was pretty close after iommu_enable_translation(). No errors,
>> no watchdog would kick in, just sometimes the first few pixel lines of
>> the next log message's (XEN) prefix would have made it out to the screen
>> (and there's no serial there). It's been a lot of experimenting until I
>> figured the workaround (which I consider ugly, but halfway acceptable).
>> I've been trying hard to make sure the workaround wouldn't be masking a
>> real issue, yet I'm still wary of it possibly doing so ... My best guess
>> at this point is that on these old IOMMUs the ignored bits 52...61
>> aren't really ignored for present entries, but also aren't "reserved"
>> enough to trigger faults. This guess is from having tried to set other
> 
> Is this machine able to capture any VT-d faults before?

Not sure what you mean here. I don't think I can trigger any I/O at this
point in time, and hence I also couldn't try to trigger a fault. But if
the question is whether fault reporting at this time actually works,
then yes, I think so: This is during Dom0 construction, i.e. late enough
for fault reporting to be fully set up and enabled.

Jan

> If yes maybe
> you will observe more information if trying to tweak those bits at a later
> time (instead of when iommu is enabled)?
> 
> Thanks
> Kevin



From xen-devel-bounces@lists.xenproject.org Fri Feb 18 08:35:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 18 Feb 2022 08:35:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275216.470985 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKyjZ-0006cE-Sp; Fri, 18 Feb 2022 08:35:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275216.470985; Fri, 18 Feb 2022 08:35:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKyjZ-0006c7-OF; Fri, 18 Feb 2022 08:35:21 +0000
Received: by outflank-mailman (input) for mailman id 275216;
 Fri, 18 Feb 2022 08:35:21 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=v1rr=TB=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nKyjZ-0006c1-1Q
 for xen-devel@lists.xenproject.org; Fri, 18 Feb 2022 08:35:21 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b31d1eb3-9095-11ec-8eb8-a37418f5ba1a;
 Fri, 18 Feb 2022 09:35:17 +0100 (CET)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2050.outbound.protection.outlook.com [104.47.12.50]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-31-htTExiZbPtevkipbiCnJyw-2; Fri, 18 Feb 2022 09:35:16 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM6PR04MB5813.eurprd04.prod.outlook.com (2603:10a6:20b:ab::33)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.14; Fri, 18 Feb
 2022 08:35:12 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4995.016; Fri, 18 Feb 2022
 08:35:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b31d1eb3-9095-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645173076;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=RRyQl3XXjMIkv3EC1aE9ooEVH9T0PmKRPMUQxTpYUAA=;
	b=g8jRxyqEI+Z/65MuUhp1vFtbRykS/0jfcIO2Tbrj6JM+98YYPN3gC45HGiYWZQ/B/sLEPw
	ApNB4fHXp0xsaYfFc3N79SC+6dUGiEN69tNvRzfVP63cYpAHyqjpUmXhCmJVrU5hMo5xfc
	yzOXumrF4OuSSvzedHwreAtpCuBraA0=
X-MC-Unique: htTExiZbPtevkipbiCnJyw-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=PfYXQ8Be+P4mdNmoFO2gEb6w7qUgIsPWjM3spf/rNqqgl4A2rt792eHxSkuc5Y8gEPwBEUxO9XzbqproJDyi+dUOwoMWqPU55KG7ry2w+e9D6UsBW7cInp/lQq3zt25pdG3e4ahxEtwyr8FhVvjTIa2EMaMVB1T2RWvtT97smhTCbg9yg48wmah5mAX+79GKFITrdAhUBrFqRVgXla5gA3CkVW9ci2Gj7nR9n4PynDGEZF04h/CuWLcSdRQ4sT55fbLAutDQuQFB/1eMlXKHoPd86iUeWDVstweGZ0nod7IzZWXi2L6EtnA6CT3a+jUi7x5i0LBiN4ZnIvIwIpLvLA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=RRyQl3XXjMIkv3EC1aE9ooEVH9T0PmKRPMUQxTpYUAA=;
 b=N8nJxz3IcEAzSafOE3q/41uXsB9mn9fzfBIKKQCQMJMWaR4YG59E/Q6ieKvLbVbvWLHSW3ZwzQTxDP1RRH+pfuMEav6gVRowEGCMXcrBRn2m2UFtA2xOnvn7Mix4DE3BDlBYTZWr//SQDiGk7RogD1lipAL5i0TdCmR6rCDnCKV3a0c90cyqs9TBeLUm298Bub8QYZOi3VInIhQ+burB2ep+LqGgKwyr0Bv+JJ1KgJYE9Lw7WGCaJby76QsoANZjEXcsmzsWIB2I7YJZJ8Wj5NFml7Ls8FltWGYPg2TZxCoEMhxPZ192ndVNo0LJ+GTiZe29v0Rqh1z+4a6STEjCcA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <2db7bc79-4fe4-abf6-9e5a-83055af9a78a@suse.com>
Date: Fri, 18 Feb 2022 09:35:10 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH v4] x86/mwait-idle: re-order state entry/exit code a little
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <faff6a1e-9f00-e924-9766-deda8f0b38c1@suse.com>
Content-Language: en-US
In-Reply-To: <faff6a1e-9f00-e924-9766-deda8f0b38c1@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8P189CA0026.EURP189.PROD.OUTLOOK.COM
 (2603:10a6:20b:31f::30) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e163a9d8-b02e-47ee-1910-08d9f2b99485
X-MS-TrafficTypeDiagnostic: AM6PR04MB5813:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB581317F4ECB65825FAB12364B3379@AM6PR04MB5813.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	3lwXCsR/576G0CT/xY2Xuq5Eq8BXlNefjwPfqVuoahKDv4GlipwlACH3ybxf4Wmjrhr1Juu/Dmzxd+bzqpz9dDHWbQCc0RhExGKULeBs4CuYDCbwVzNdJZHJfv3cACwx5eIW/ZX92Na6GXi9rAIUvjMt4/CP5PBpVOKwPdX3RXtSGccUxiLaqDBWnhoZBYdnnKpc2Nj/OIWq8xr4eIb7N/Ww/cN6UM63undbLxOX+BgpD/ckcyUFTS3AnKWsS5EedY4ICV0Eg2Zx2Mn6FIyf7kscnwfxYzfVU1jE/aUmMLjSJ/CBvxzjAsfqeF6Tldhxrb4a+rFdpgjs6N3YUK4xpjIDUCP+AEr+NOuFE57UlvBBPpW0cNKiCy4WgZEvw3FNX2lhze+mqEEGYEvU5fYKhDMXxDual90Rc8g1FfuYQju/wUVV4lKvK6j2zbbdCGJ1EALc8Tn+kaPXfLMYSD7VWkIISmaJnLRfiIIpcMb/5kqttpidPA4X+EkRPFuhC8eQhUXYeIEjqNNhUyT3ru2XHz1GquQr+fjtSb9FUqxyUvv43+OuC8x3Hj4Tkaf1nbm0oX34QpY/LJkmBJ0GOxrPZg1atlAnLJFDGFP8KxK13ehIMWGcr0XjnfGNzBO4Wk2h+O4VVuQTQAEkMRxZ7KWkddh80ja/eE8I1Kce+Zf8xZdAlR+/43tRxXTE3ET0IipYdFjqUCLCUIr/p5EbmHCETW0UrC2pBUU+yEPLuzEcSMZPNJIGUPpNEj16JS/ac0KLqQbrbRTT9fW+0bhisWVFcw==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(4326008)(66476007)(508600001)(2616005)(66556008)(8676002)(2906002)(316002)(31686004)(83380400001)(86362001)(66946007)(54906003)(8936002)(186003)(6916009)(5660300002)(6506007)(26005)(6512007)(31696002)(36756003)(6486002)(38100700002)(169823001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZEIwbjFtMEJpUlRmb0kvNGdFQnpoNDFtRSt2aE9Ub0xpNGRGcFI3TjQvZEJG?=
 =?utf-8?B?cDdRUE1xRGxYWnZndGVKa2ZyRk93NTVWdVRKUCtKYU42am9od0FhWm8ydHd1?=
 =?utf-8?B?STE1cE5MTDRWSXRtV1FMU0ZORStPa2ZUUzV1NUUzOEpNNVFjNk1YOFJzSThG?=
 =?utf-8?B?SDVhZDVOY2NpczJjL1EvK0hubDZvb2RLK1pRTlVNNUhTTzVobkxldDU2T1ZW?=
 =?utf-8?B?RXVPUTM2WWpicmJWOTRyUlQ0WFZxRHF0NkdiMXpFZmg0V2tzNWJqQ1hTZGgv?=
 =?utf-8?B?Q0w1SzBuOWlvK1lLbkhaUzM4d2YvaVBDNmZmaTlmTEpSTVlmazNpakxSN1g4?=
 =?utf-8?B?YVJpZm1aY0lzd3FydXd5TUJLOS9CYkRuemxMakFzdkNjUng2ZUpSaS8yVndw?=
 =?utf-8?B?QVpIdDluVjV1N0RDTWYvYStqdkx0QzZGK1BBdTN4em1oUHVQb3RFdEpPSHFk?=
 =?utf-8?B?emg5STVvSmZ5QVdiNHJteHdPeHJUa05WQ2VCUTIvZkNjb2o3bVMxWDI0TDNS?=
 =?utf-8?B?T3krak16L2VtNjRYK0JVL2Radms3c3ZGcVpzSE5LSDdxY3c1anpVQll0Y1pW?=
 =?utf-8?B?d2lha1dLVllJV0dnQlMzRk9sM2Z5TWNSOCs4VktaSjAwVTZNNkRrdEgrOTF3?=
 =?utf-8?B?UGtBUDcxUG5RM1l2RXV0RVBTRWgxUGZuUmxmMmNYZ2Z3OU5SK1Y5WFoyTENZ?=
 =?utf-8?B?V0dmeGhCUzI0bUptS1lHSjI4U1ZreHQwd1M5ZzcvRVN0RGpVT3E0V2k3bDVN?=
 =?utf-8?B?VTZKT1hxOEVhMnJuek42dHVIaDJ6WWFMRnA2bVg4ZE9tWkRaZ3QxL2lPcEkz?=
 =?utf-8?B?aThwS2JLZTNTVWIxbDNySUUvRURIR09oY1ZwNUQ0TEE3TTR5eEc3OC9ORGNr?=
 =?utf-8?B?UTJuYzA0QVdMa3FxbWsxUDh0Qy83S05aK0NhZG9JWkVDYTZUczhHM2liMkhO?=
 =?utf-8?B?VmpPM2tWbzJMUmEyV09HWFZreURKaVVsNXh0b0pFYWlPUUF2dDhSU0VPNGVW?=
 =?utf-8?B?b3ljNlFHb0dHNnplc2pVK2ZCVnVML0pvSzYvVkFmMUhoZFpGdUJseVpkaVRL?=
 =?utf-8?B?YXlabXVjT1ZvSHhtd0NCUnZKbTVGNEF4YStoUUh2OXJ6akk1RUlYMjhXT0dr?=
 =?utf-8?B?MUNwQi8wZTRuQnQ0b3pCUWdSbjJpSTJjcURsTE90UEFHZFJBejZtdjlGTVJH?=
 =?utf-8?B?N2diRkpnellyZmNQWjM0blZiQTFtSXhBZDV1Q2VJSDl5RjlieGNwVUhhUWY5?=
 =?utf-8?B?VTNGcGZLK08vMmVDWjZ1RVJpczliZTk3cEloaG4weUFFU3VwaG5LbXhIRTQv?=
 =?utf-8?B?d29JOHd1WUlVWDVzbmZieFV0aTJoNkZwckx4YnRRVVJTWFA5MVhxYmRhZjVX?=
 =?utf-8?B?MUdaaWs5Ny9NMll4RVN0YVhEWFU1RnZuQlppTFoveTByQ1NhQm5GU1grNFl3?=
 =?utf-8?B?MjNWS0JVRWdWUEdDMElLcklMNlRocTFqNkt1SXlYcXhMejd2MmpKdE5FbkQ3?=
 =?utf-8?B?MEUwM0V2YlpjZVJWRzJuQlZySi9MWEw2dUF2YU1VblUycXpZRHU1UEUybllB?=
 =?utf-8?B?M1J6U3gxQ082Qjh1cE05c0tJN0hOazM1OEZTaStKd0VzTUVqQ1R6aWFjV0dl?=
 =?utf-8?B?Tjl4YkFrMlFzajBZSVh2NVVKY1VnRWV0aTJwVk13SW9leVdqS1VQMVdzbG1w?=
 =?utf-8?B?S0xydXpMdHNFSU9uaS9jM0hKR0NTak5jUGpweXRTMSsxQ3FZeHh4MFh5eE1Y?=
 =?utf-8?B?cG9OTHI0ckNadDgvY2huS0tBOTg1c3R5NExIM2EvRzg1QW1wMml0VU8vYlZ0?=
 =?utf-8?B?cnJLVFdlQk5PL0VyMk44aGc1RkxsUVJyc25PNGhsaHJreTkvcU9oSmNDeTIv?=
 =?utf-8?B?blIxNnMySGtkeDFKaE4vUW5kWitaT0VDcU5EZWZKWDUzeEpmVVgrR3RCcTht?=
 =?utf-8?B?eEFKNWZKTDFNY2ZjS0VuMWdieHd6OURxOUxwNXJuaUNZZXJGT0UvRERMRGNm?=
 =?utf-8?B?SEVBa3BrT3o5TEtlTHNDUFlHM1NPQURCL3Z1K3QzWDFoQjlTNWpDNSsyMkNs?=
 =?utf-8?B?c3BrSHpOdGkxTit1OEFRYVo5eEhEcEhXZ051UGt3cnNoSmZidng5dW9lelNt?=
 =?utf-8?B?Z1J2ZVphSmVVNjdUUXRLRlplWEpFM0hhelF5Z3VVeTIwRTlpbjRvclRhUUg5?=
 =?utf-8?Q?bu3Afg27wzJcT8yug2tky5s=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e163a9d8-b02e-47ee-1910-08d9f2b99485
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Feb 2022 08:35:12.5507
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yvDyd028BHTXDZwt5ofSqeGrFP1Keon+xr1qgLlpNj9uttLAPBHHUeE695YMYSSDZ8FLHt0xTd+hjsMCZi9lHw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5813

The initial observation is that unlike the original ACPI idle driver we
have a 2nd cpu_is_haltable() in here. By making the actual state entry
conditional, the emitted trace records as well as the subsequent stats
update are at least misleading in case the state wasn't actually entered.
Hence they would want moving inside the conditional. At which point the
cpuidle_get_tick() invocations could (and hence should) move as well.
cstate_restore_tsc() also isn't needed if we didn't actually enter the
state.

This leaves only the errata_c6_workaround() and lapic_timer_off()
invocations outside the conditional. As a result it looks easier to
drop the conditional (and come back in sync with the other driver again)
than to move almost everything into the conditional.

While there also move the TRACE_6D() out of the IRQ-disabled region.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
Moving the TRACE_6D() may be a little controversial, as this could lead
to a sequence of trace records not actually representing the sequence of
events, in case further records get emitted by interrupt handlers. But
with us now conditionally enabling interrupts around MWAIT, that issue
exists already anyway.

Unlike said in the earlier outline of the alternative approach,
errata_c6_workaround() cannot be moved: cpu_has_pending_apic_eoi() needs
to be called when IRQs are already off.
---
v4: Different approach (and title), as was previously outlined as an
    alternative.
v3: Also move cstate_restore_tsc() invocation and split ones to
    update_idle_stats().
v2: New.

--- a/xen/arch/x86/cpu/mwait-idle.c
+++ b/xen/arch/x86/cpu/mwait-idle.c
@@ -847,26 +847,25 @@ static void mwait_idle(void)
 
 	update_last_cx_stat(power, cx, before);
 
-	if (cpu_is_haltable(cpu)) {
-		if (cx->irq_enable_early)
-			local_irq_enable();
+	if (cx->irq_enable_early)
+		local_irq_enable();
 
-		mwait_idle_with_hints(cx->address, MWAIT_ECX_INTERRUPT_BREAK);
+	mwait_idle_with_hints(cx->address, MWAIT_ECX_INTERRUPT_BREAK);
 
-		local_irq_disable();
-	}
+	local_irq_disable();
 
 	after = alternative_call(cpuidle_get_tick);
 
 	cstate_restore_tsc();
 	trace_exit_reason(irq_traced);
-	TRACE_6D(TRC_PM_IDLE_EXIT, cx->type, after,
-		irq_traced[0], irq_traced[1], irq_traced[2], irq_traced[3]);
 
 	/* Now back in C0. */
 	update_idle_stats(power, cx, before, after);
 	local_irq_enable();
 
+	TRACE_6D(TRC_PM_IDLE_EXIT, cx->type, after,
+		irq_traced[0], irq_traced[1], irq_traced[2], irq_traced[3]);
+
 	if (!(lapic_timer_reliable_states & (1 << cx->type)))
 		lapic_timer_on();
 



From xen-devel-bounces@lists.xenproject.org Fri Feb 18 08:39:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 18 Feb 2022 08:39:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275225.470995 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKynm-0007Jq-H0; Fri, 18 Feb 2022 08:39:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275225.470995; Fri, 18 Feb 2022 08:39:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKynm-0007Jj-Da; Fri, 18 Feb 2022 08:39:42 +0000
Received: by outflank-mailman (input) for mailman id 275225;
 Fri, 18 Feb 2022 08:39:40 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=v1rr=TB=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nKynk-0007Jd-OZ
 for xen-devel@lists.xenproject.org; Fri, 18 Feb 2022 08:39:40 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4eb99333-9096-11ec-8723-dd0c611c5f35;
 Fri, 18 Feb 2022 09:39:38 +0100 (CET)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2110.outbound.protection.outlook.com [104.47.17.110]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-20-S3qw7ABENImTacbhv9hK2Q-2; Fri, 18 Feb 2022 09:39:38 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM6PR04MB6086.eurprd04.prod.outlook.com (2603:10a6:20b:b8::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.22; Fri, 18 Feb
 2022 08:39:36 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4995.016; Fri, 18 Feb 2022
 08:39:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4eb99333-9096-11ec-8723-dd0c611c5f35
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645173579;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=iVCxnMLfzFqoNvutd3hEV89puCpn08g09o07iaObBvA=;
	b=IRF1HyV2cTnbieoN5uAWj3+IwGQPaKB4ye1aw0RyLBiihna3S+jy6WzpovsrSreewONyx2
	DPTGzGQL4NR+gTysk9sIpwrYiEVxLRAhX6RxgTYQ40YHKeh1nP4zY6YZqYGitqQIfnuf3L
	ADvUFwV2l/hNt4Y9QbXrM/nGYnv8yRc=
X-MC-Unique: S3qw7ABENImTacbhv9hK2Q-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=dNIpPE0xhfGD92xBSBSWuCa1PEzu1R8TTh1KSTJBKuTkUyJWMDpe6BXizLp94CZ43vCETB3G+ex4OnWs/nlXAWnvsTMsZIK8JiuUvRVOCF1Pl5jVf3hu/QZoRFJuacdxF0clq8TrjkAWxK37AHooHS6r7H7N/ruBTIOEyiLRUlcVsfpOmFIhJ07ugAGpRRoYbJVgoHLDYjt2tgQ8cMzyTMrLdoI1ytpo7xO/Xn3dLSGFAXTAPTfjT1bGPHCEdnAHDc8ZgEVpY+Xn5K6VI6KTuPxIc+7Zkc2g2N1E2h1g2Pl/Xhk3/YFcPKoSMlqXV2vUNuxVoz+VsDKvPai0XK/pkg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=sA2PzKQ4OmUxqARxBo/HC7VSsPJXf02Cdes+lt85rmc=;
 b=DU/e11UJC1L+x9Gm4oX7yBj4kdGEoi+uWh+cF9R6pSkQwXkMmoYoofpU+toe0EKYPOgdzQfb48R1lqZhbzj85lmAOZKOkiNm9K+ThrboCJJYib8aPR0tlZbbuWN92xu5mhGkM86/YIPnH6quzj6+Vkm/BVNp4RZTrJXNxz7AMODprUY5lfU/sAgufe1dkpQkvZQmHUnM4RWAIAugvF8PMaZYOQWi46T5ny+RRPIVPGcR+dfTzvwwaA1ji8hykSm6WBzSxGBIdhHmSXI2tigZQA/kz7uifvdY43Q6bx1iBz57u1IZ11ftFbspDH3t3XkckAbQY4KTQ3nCIm+xl9Dw+Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <66c63b32-aca9-0fb8-ea6d-8b91c23eed9e@suse.com>
Date: Fri, 18 Feb 2022 09:39:34 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Ping: [PATCH] x86: replace a few do_div() uses
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: Andrew Cooper <amc96@srcf.net>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <01baee92-9d7f-5a2c-d63f-1de390bc10e2@suse.com>
 <a5af3a6a-da51-2624-622e-2566c8db7dce@srcf.net>
 <f4dd528a-d1e0-f516-bb7d-f1ec01abc3d5@suse.com>
In-Reply-To: <f4dd528a-d1e0-f516-bb7d-f1ec01abc3d5@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM5PR0101CA0012.eurprd01.prod.exchangelabs.com
 (2603:10a6:206:16::25) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: fa3213bd-a183-47cd-6ea6-08d9f2ba319d
X-MS-TrafficTypeDiagnostic: AM6PR04MB6086:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB6086AB2FF5AD931287915932B3379@AM6PR04MB6086.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	+/Hh8Gqsi5QQYhXV+XuH4i0BrzUwzIDJWiQNu30xdVWdBxt+MlzCaBz7sch8MLeW+/pNeElP8/PIR1Qa6cDYRlQoygNGjRzO2bFW9pHf45aevK/3DS0IYiMwWPpgttuIoTKpnWfzKHl0FRitvl3HYGDRcyzYhsXDbNxONKqwfjquePesSQtaAuJpgNvLQ6jBP5uity8fZf3/LZQTOU+1IVfZFZlzlNc/n5d/pjZrgjcPpw35UWTp9XOKiGIv0zSaFC+wzQOVdSWKaxargIe/NeGy4iAI1GbPmCE3FG21pvXHxUG0TgfFNGOD0sL/iCH9/Rj9hs1+ZAthn0oEF52YDB28dhV84lQ65smXWSl168xoZHOJ3QWF0rOGwHHmzkq7OepKk0pBEX8a67C2FeOr/S8jvtHD7F2uQTxp61jnAR0IpfFnAPuja7JnZnbFiHi+k5vFdxQB3j9zTdqonE11FIPPv0aMA9gpJziP6XTYJfse4doH13va+wH1Zkrd4VcG4ZZpwEOP/oH7WuYVvlqnra9gSnQX7aFc+hyX53MD7hiv/AmebyJ1p3iK7Fo5WTEl+mDP8wu4Fi+iYm5onvQCPHJMLtMDy2em8MqPwEiD1Wp9lLFaqjB/ogKXcv0LcPzDwDgx+sJgZwWCWPOcM7jHwmAGdBE2+0iPh3+7xDSXAW4u9NngLZ6vBKRVb6ok2emIZQjXXSerMe6B4JmFEvs6wNmAzVeUagKXsylmnFSTW4c=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(5660300002)(2616005)(8936002)(38100700002)(66946007)(83380400001)(2906002)(8676002)(4326008)(26005)(66556008)(186003)(31696002)(31686004)(86362001)(6506007)(53546011)(66476007)(316002)(508600001)(6916009)(36756003)(54906003)(6486002)(6512007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?OpH0w7pCa6EUsulIAGIVxnqAt9ieSICO5hvwYR+Oc2tKSo//5gHJ77pqbrER?=
 =?us-ascii?Q?hEClnaJGP6dHckxjIaXlvnbIFEMlI8T3Lnoz7+BweIvuGe5nnH8spq537fXl?=
 =?us-ascii?Q?MHBSlh43xrACo4qJgZlLbFg4Tt01eZ04iu9m4eXFCtpRGP98hpPFEtl48FsW?=
 =?us-ascii?Q?oohU8UevPFdBAQCwC3yzMZZ5rV+r9WYbu4t2o1GURKqTNZlH+oTU5VayuyS2?=
 =?us-ascii?Q?prciveTnUUHUCdxLbwjprS2MgoE5I+ISAB71EilcsURXBxh7uMQct3dMLFgu?=
 =?us-ascii?Q?a9pdK9Kr355FY9Jhey3TiTSB06nVyHZ0PLQyt9HgSyUDd0yZfzojBcxczRHX?=
 =?us-ascii?Q?6wRDrPotZ8bDjcbVGkhrcnX10XnXIso0f2UZ4ooikZr2Q+oftdzWirLdkNOd?=
 =?us-ascii?Q?UprYJcUkg3im1viuxE9BJFB7RiJ+0dMG9OEd1Ctd0lt/ZJc/cQfOY91kgI9i?=
 =?us-ascii?Q?EgpoLgo2foJMNN30ChOYF2DqD73zF75xpWMq6oZNGQ35WZfxsK20uARQNcfN?=
 =?us-ascii?Q?TCgwF4qAznF4I+b1JFQsrH7HuRYcPqGJ+dro9xKUHGD65xk3tIRexAhWJdaR?=
 =?us-ascii?Q?bmmobr139lgh2y4kweyqMGe3AxjmadAT2XRSYAk4gnadgtOxsM591qhF3+YY?=
 =?us-ascii?Q?673FimzScKpDms//GULuMl/wY4R02BPX3dw/9G5zpn8/OHWSmFwBd1qciDHs?=
 =?us-ascii?Q?JOR2j/P30s7kahXpUe+PYSzlX85vJhjhmOXRm56iI/40mC7il24MGFGURM7P?=
 =?us-ascii?Q?X17sShtBTA8aWoVANZrdzPfZS1LjnXKEinVXZyKq4uaaLUN5vbJa9OAXI3ub?=
 =?us-ascii?Q?RjtTTNOsiAnNFCJL33vtJ6XUt7OwU3AYX+fuX5fZKR9OzZlOFWebyAj1j7oZ?=
 =?us-ascii?Q?FqHBU8Y8DnzBqitvEXeMCLxb51VHD9ZkArfAVOYiy+NEnPz+yRQdZ+i1zLl3?=
 =?us-ascii?Q?gYMglR4ZgR9/u3AH+2bk0hX8qwCQR29ch+ClTg3UvCvSIN/MgZt+iIHfr8Pk?=
 =?us-ascii?Q?+mMxzq8FAJ7KSMW0nM6cfb8gvCmNLFGemgGQfiLqMaH4aywIRCFwAej1j/XP?=
 =?us-ascii?Q?4t9WU1Yllm90SuCun4LqzhiynEyhig/IeS4qQfTYj8kZRaJUFEEYzkl5rn1x?=
 =?us-ascii?Q?XMgXgTdxp9Zjm+ymqTCB0BIfzj3pBO6+CCUagAGfVkFY3zUei78wp3riE59g?=
 =?us-ascii?Q?RBiL8VAJbQaQYQOaEISvy6j0BIqdlWHEtMdVknRoyudJSVzGWHZmpkiWxzPi?=
 =?us-ascii?Q?RcsIZ1ScXY+Y82iF6wCkx6brLQ2ZykkifjPXXzXw98s+dRffAdDABu8HNQOH?=
 =?us-ascii?Q?sC2T1EdtFTFwcXMAJAd5giT2l+S8cZiCB/mPXuHCBSHmUJfhBKpn952J1CIp?=
 =?us-ascii?Q?zJIA4stXB9/lmhPTDdblrj/+QEHo3NIkMdjP0+NwWO7MmOwE3N//KR+yS2Nd?=
 =?us-ascii?Q?5qQ0ym+/juvFmmEtXrv6CC+AFoImfVcU7RsR0Std4czjSYreLvM4wNOoqfj8?=
 =?us-ascii?Q?MOV9+Zg+jmwrQRoAsLTPykY23S8w8G9/nReFw90ZKBGv5IZjTG2xVZ7oOyAm?=
 =?us-ascii?Q?JfnDEt9PI/1lxCds5QScBRGaY4w+PYU6yonVoYtEDR4qpHzNXdrYGcS4/Vww?=
 =?us-ascii?Q?gx0fxd+IXYFBHwc2jHvwj1s=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fa3213bd-a183-47cd-6ea6-08d9f2ba319d
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Feb 2022 08:39:36.1906
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7hOstShIxy6DMwhbuGU/vsevPfbIuxxOBAFFm8VFzaT7pGVMd2StZ+ujxX5bQCPgwWa++aOhNGQmsXxbcL3law==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB6086

On 12.01.2022 10:28, Jan Beulich wrote:
> On 12.01.2022 10:22, Andrew Cooper wrote:
>> On 12/01/2022 09:00, Jan Beulich wrote:
>>> When the macro's "return value" is not used, the macro use can be
>>> replaced by a simply division, avoiding some obfuscation.
>>>
>>> According to my observations, no change to generated code.
>>>
>>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>>
>> I like this change in principle, but see below.
>>
>> do_div() needs to be deleted, because it's far too easy screw up.=C2=A0 =
At a
>> bare minimum, it should be replaced with a static inline that takes it's
>> first parameter by pointer, because then at least every callsite reads
>> correctly in terms of the C language.
>=20
> That ought to be a 2nd step, requiring agreement with Arm folks (and
> adjustments to their code).
>=20
>>> --- a/xen/arch/x86/time.c
>>> +++ b/xen/arch/x86/time.c
>>> @@ -610,8 +610,7 @@ static uint64_t xen_timer_cpu_frequency(
>>>      struct vcpu_time_info *info =3D &this_cpu(vcpu_info)->time;
>>>      uint64_t freq;
>>> =20
>>> -    freq =3D 1000000000ULL << 32;
>>> -    do_div(freq, info->tsc_to_system_mul);
>>> +    freq =3D (1000000000ULL << 32) / info->tsc_to_system_mul;
>>>      if ( info->tsc_shift < 0 )
>>>          freq <<=3D -info->tsc_shift;
>>
>> do_div()'s output is consumed here.=C2=A0 I don't think this hunk is saf=
e to
>> convert.
>=20
> If by "output" you mean its "return value", then it clearly isn't
> consumed. And I continue to think that I did express correctly the
> effect do_div() did have on "freq".

I think I did address both points (the earlier one was actually more a
remark imo anyway, not a request to change anything right in this patch),
so may I please ask for an ack (or a response clarifying what I'm not
understanding in what you have said)?

Thanks, Jan



From xen-devel-bounces@lists.xenproject.org Fri Feb 18 08:42:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 18 Feb 2022 08:42:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275232.471007 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKyq2-0000Et-UC; Fri, 18 Feb 2022 08:42:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275232.471007; Fri, 18 Feb 2022 08:42:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKyq2-0000Em-QU; Fri, 18 Feb 2022 08:42:02 +0000
Received: by outflank-mailman (input) for mailman id 275232;
 Fri, 18 Feb 2022 08:42:01 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=v1rr=TB=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nKyq1-0000Ee-5V
 for xen-devel@lists.xenproject.org; Fri, 18 Feb 2022 08:42:01 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a309c796-9096-11ec-8eb8-a37418f5ba1a;
 Fri, 18 Feb 2022 09:42:00 +0100 (CET)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2051.outbound.protection.outlook.com [104.47.13.51]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-16-RbjlQSt8N5S-0RnGoYQbqw-1; Fri, 18 Feb 2022 09:41:58 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM6PR04MB6086.eurprd04.prod.outlook.com (2603:10a6:20b:b8::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.22; Fri, 18 Feb
 2022 08:41:57 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4995.016; Fri, 18 Feb 2022
 08:41:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a309c796-9096-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645173719;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=naQPYhXYCMSrZhRPtdp7vixNsqEpmgJpGBZMysrS6Vw=;
	b=iXJeJI+pe+pgAi0txezSWTPWy5wwf4v+6wR3w+qHs2FRnHL9z/qiGplm01F3M0r8x32c2E
	mvdv/SeOT7+vYF/tcLAORZicedgjshAAmXSkiyxF2ppk32xTIglcdqxjkdUkXvtaHAwG6E
	MAx1U4IDCQOubh4kP9WZKO+jStQHAsM=
X-MC-Unique: RbjlQSt8N5S-0RnGoYQbqw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=m0HB6zp28XLnKTpLhRB1pyuU7tlYdQMucB05favtNbq6GnrJG+MTxMftAZ1FSPbIii9gbZWPBG5bm+lGjwUYe8RCbjYizSDLwZYl9Kltcy7Xc7fRmHvvlrGSV4apSJkoEOUQdjv2dJrFWsH6JcHSwgrT1BeaI4nJe1gJ+ewq+SyneJ2ODOspSlV0GsO3a26yBXK16zaRPP0Gvcg5ehou3WCmKnTWN8U48C0YCouaNf+rngkqIgxmtQt8KIuCN6LNClhZ42h8I1ZNkoroEpR28Gi5Ws1G/fFV+yJkcnOxIO5kCRKC8veIP5qijWPxAyLpOYC9V5i1xtfp3FRc/nGqfw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=naQPYhXYCMSrZhRPtdp7vixNsqEpmgJpGBZMysrS6Vw=;
 b=P8Bhy49Ui50x2FAI4IoiEazNgWJJ40wBc1J+9eyREOZXQfWrgTDNH4oBwlf+RkW92jcNvJj5no1UK9CRnP9h3SZ6lBDA9bhCTP65x9piy81oF65vzldcQQcz903ybYQdrfAWntcczHCKsCedal0rHr4hZIGdxK2gBXd1eEP81w5HKMCBA0yrW4CavGow2ZtuCthAOMhDc22bhLmYEMTBM5R0FC5+FgDBzYHB9deYjawdhIDxoc89YGkllsh89Hyl+ueCAUfQxsVfs6p6ELAFaxZ4Z4jqml5xVhaIuTCH1xubBnQnOMykwfqv2cQ0eTAhO0RsT5l6XIEzZIy4UyekTw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <73cea081-5ad4-8a2c-96db-e9c45571bc12@suse.com>
Date: Fri, 18 Feb 2022 09:41:55 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Ping: [PATCH v2 0/3] x86/perfc: assorted adjustments
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Cc: Wei Liu <wl@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <ff461a77-93a0-5424-6565-2e947bec3912@suse.com>
In-Reply-To: <ff461a77-93a0-5424-6565-2e947bec3912@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR1001CA0072.EURPRD10.PROD.OUTLOOK.COM
 (2603:10a6:206:15::49) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4ba84994-8e28-42b8-9b11-08d9f2ba85a4
X-MS-TrafficTypeDiagnostic: AM6PR04MB6086:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB6086E1CEFB0533CE3BA81860B3379@AM6PR04MB6086.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6790;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	oCrPhJM9v65sk2L6pMkDxPUt2t48oIk085Ew4khXLsZ8qUL+frpswy0epHURYxjiGWp8/USSfCGlMjJ0HPfeP9cKmUHXqXz2vXr3VldGwhMyfRhHWPjjov90Ck2uXPDe6ePPkrfigGl3yI5zkKiGVlqn1bGqTHyEoOkKzq4bxHkZ3Li5uOUGnQmoXXesRBnv8ocwwQf2DYe0qigEtIKaZ6054szUVX3nDVM1TF1ztetuhNeJPvDPmQv2CWbWkU3W5pDCPWtiJUB7Lelfcn5xj8DYp+eOaURQIvRAGvNXF055SyS8c393I+YU0oqm8doJ1PWaAwvNEdMcRgJs5kJ1sc6C+iFaetWyOPI9RrHYbnlnfqRDqEOy5PZLECpboU8gxkqf86VgwxnWI2yyWDhNUhMtaRSbyLlOYz3iBdRekecHcwQVdwDmGJKMRpAXoZlIq7v0dHCH5seDQApgG1aSpreFe4IllpEZOMMVCWVujtiWrE4+oVOUM5iKepghOlXx7sDbR8Hgrcyp91FL+2qEMrHd/yyNTthVf1cug5ZjQNnVKaExCKQwKxxHCTqsAKkYMfze0EB7l9T0PB0/hj6Tys8oLbbrQk7brhSjvSB9584bDP+0GjCYab6WVDJ0Tdd0shwYlY5Q97IMEOrYfy2gRMpuCiZqhOs8WFtJ4qMDDqPtHF1PAnaK6Yo54sK+JtbFFlJwZloyIk/2yDfAB/EgnE3Y9S1Fx0dI5nRfzaLP2XgRkG0SIQTEoeJMqdlmjvSt
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(5660300002)(2616005)(8936002)(38100700002)(66946007)(83380400001)(2906002)(8676002)(4326008)(26005)(66556008)(186003)(31696002)(31686004)(86362001)(6506007)(53546011)(66476007)(316002)(508600001)(36756003)(54906003)(110136005)(6486002)(4744005)(6512007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VU1NdHpGNGp6U1NKbHFVS1NYMkdjcTF1eXJwQXdPdkpsWUlIWG5yTSt0dXV4?=
 =?utf-8?B?dWtjQ2VYTzV0WXhyTGJVNnVQcldTVE1rc2EyRTRQMy9yY09FNndPc0Uvd3VE?=
 =?utf-8?B?OW1kd1N0T0txV25GSnJhY3hVa0swR25yNlc2K3dKNDN6UVVuWDVpcVA0QnJm?=
 =?utf-8?B?M2RNNW1BTXI1MVlydWluZUVINHB2d1BDeFgwa0dKVDR3NnAxRUtUcncxdlVa?=
 =?utf-8?B?WkliY1owNmpKQ1lqS1dZblNGUGVUWFM5SW5BZ3I1WVd4M0lGQ0dsVzFkaUlr?=
 =?utf-8?B?SWxiZXZoQXRIZWY2RlhIc2YyM3QvZzhCbFExQXhIRFpHclJHcHhiclR5OVd2?=
 =?utf-8?B?a3o2YkZqNTJjS2tuY2xQY3o3ZFh2RnQrdm5iZVlWTUYrQi9ubGh4SUEzakVz?=
 =?utf-8?B?TDZhWUpJTjJOeEpsL2VhSDNFcDZ5Skg2c0lyOWNabWRseEJzaWVLSXNWU1Ft?=
 =?utf-8?B?WnNZVDdkU3ZQNHRNSDdiUS9qMmVzNVlGMENJV0ZIdk8xNmxIM3pQY05VMUUv?=
 =?utf-8?B?TG9Ec1lJa2FXc1lvdFA1Yld5MHJBWGRrWDdNWnB1NENkaVdCSnNFc0ExZVpX?=
 =?utf-8?B?SG15K2M4dUpqVGZmNUEveHc1OXVFSWVrbGJRUHc5L0Fhb0IybGRVcmVpZVdj?=
 =?utf-8?B?TUxHSWwwTUQwMERNV1hXZG5qRm42TTRwUytBV3d6UVROcWczVXl6djZsNlEx?=
 =?utf-8?B?bzdTVnVnY3A3Mk0ya2tiK3MvamVtMEdHekVIY1BMZmV2eXpVdEw0dG9nODRh?=
 =?utf-8?B?K0E3N2QveExPTHlFQXBzcWdhcFo1cHFvQ3JaM3pyRVl0YTMrRWZmSndvTjdy?=
 =?utf-8?B?NVlaQzBieE5ZSmRYeW1SRmVUbGtiK1paSlFXUlM2TVNYSEU4RHJYN010R0lZ?=
 =?utf-8?B?K00zSWpQdXZKNlhaMFRIVXllSkNPeEFwOUh0ZkVrQTZ6Q0dtOU1qMlB6WTgy?=
 =?utf-8?B?Q1lMSlRVVlZ5ZnR2Y1FRck9TeHhqYXFtaTVwOGY4VG8xOW93ZnYwZzZHZHJP?=
 =?utf-8?B?dnRya2VWVTQ1Qzc5SXZNdDZiZFRxWThxTzBGWlc2RlNSTzEwN0NEeUhBdVJw?=
 =?utf-8?B?U1pzT3RuOXpYNHhENWJlNHNaaWtnUE9UMUhFYk1hTFFUNVM0WmQ3VUhJTlNj?=
 =?utf-8?B?V0VmcWJtV1BXZjVMb1luK3E3dGdGRWJ5NklzVHJtdzZ6dTlwZE5WYVd5bDNQ?=
 =?utf-8?B?MFd1L3BxWWNpdmxDMFpMMVI0M054ekUvTmRkL3J4c3lVamh2MHlncFk0UkpY?=
 =?utf-8?B?Rjljd05Xb0ZQSXhxM0w5ZnNlc010M2ZHcE1RdUVFb1VHZTBYMG4zbVFBbWgy?=
 =?utf-8?B?YSs1VjVXMllFZkphZzEwbzhUS1FSN0JjM3hablRzeW1Ia2UxakptOGJNNWlU?=
 =?utf-8?B?NGpDUnhPUVFkMjg4K0NrVXpkNHZuSUcwTGVDd3orWll6VUFRbjRldFZBYnZW?=
 =?utf-8?B?MTU2cG1rWU1nMllLSUxESE5SSnRNWjZHVDNiUW94WjBYa2tNNG9LZnVmNE5X?=
 =?utf-8?B?VWVoRG10MVJoUzVZS2pjcUZGZzZCd08vZGlOTDZ2SmlUdUlkQ2RqVFBaU0JG?=
 =?utf-8?B?dEJiRXpQR01FdUdwTDlUV1JSQ1p0NmFhTytoREloZENkbzNDeGI4eU5oUGM1?=
 =?utf-8?B?MGU2RkpsSEx6Sm1PMkE0TS9ncmhnMWI3TkhSZytoMmh0bytrM0Zybk1LaXVj?=
 =?utf-8?B?bGh1ZFR3Q3VMR3E5VHBqM1pwSHFWelNSdS9Yd1QxRHlJZEwxSVVHNzNUT0s2?=
 =?utf-8?B?WFZvMVlBbFkrWVhnODZHZnprTlY3djRJWXFLNUtTdnU0RGpMTTY3azNIOW5L?=
 =?utf-8?B?cS9ZSThjcUNFeU9hVWRxSGNIaVM3dit1NndaVkJLK1ZpbVlPR3ZxRURqamV2?=
 =?utf-8?B?ZjB1RVljcDgwVjZHaktrZTVra01lQkx4OHkrd1V4N1p0UVZwVHZ0Sjhzd3kr?=
 =?utf-8?B?SllEQk9YdzJMcUw3U3I3QVNyYjEzYjA5cUppOEZMWTNIWDFNSk4yYmZnL1pp?=
 =?utf-8?B?RFJxRnlZVU43dVRWejlIY0N1ZU5sWDJBUEFPL3FQQkloemppdkRLY2IyWHp5?=
 =?utf-8?B?N3JHejg1bHVqSEk4bUZLcTJ6blZmZTZRSFp3TFJ1K1BZdzYwMUU3a3FRemlF?=
 =?utf-8?B?VklnbFJJYmxuVm1EQmI4VHI3VFhuV3JWeHJqMUN5OUNoQzJIYklXajFSVU5Q?=
 =?utf-8?Q?az89UkejbqYWR2aown38tvs=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4ba84994-8e28-42b8-9b11-08d9f2ba85a4
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Feb 2022 08:41:57.1819
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: y6VBUmKgyINhVeM6EUVoHhiEXk9jJgkmAc1WeqB+p1lUOn6Em2WN375LtQHZru0YcVPsCZ/NwQl7H5H/tdvMjg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB6086

On 05.01.2022 14:56, Jan Beulich wrote:
> Addressing some observations made while reviewing other patches.
> 
> 1: VMX: sync VM-exit perf counters with known VM-exit reasons
> 2: SVM: sync VM-exit perf counters with known VM-exit reasons
> 3: x86/perfc: fold HVM's VM-exit counter arrays

Patch 1 has gone in a little while ago. Would be nice for the other
two to also be acked, or for adjustment requests to be voiced.

Thanks, Jan



From xen-devel-bounces@lists.xenproject.org Fri Feb 18 09:09:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 18 Feb 2022 09:09:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275246.471022 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKzGm-0002rj-4c; Fri, 18 Feb 2022 09:09:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275246.471022; Fri, 18 Feb 2022 09:09:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKzGm-0002rc-1R; Fri, 18 Feb 2022 09:09:40 +0000
Received: by outflank-mailman (input) for mailman id 275246;
 Fri, 18 Feb 2022 09:09:38 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=YtLv=TB=citrix.com=prvs=0411da6ea=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nKzGk-0002rO-CS
 for xen-devel@lists.xenproject.org; Fri, 18 Feb 2022 09:09:38 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7d232fe9-909a-11ec-8eb8-a37418f5ba1a;
 Fri, 18 Feb 2022 10:09:36 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7d232fe9-909a-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645175375;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=zX4SjgHBWf4OPXb2hEhKFyKfg2Z3b/qAoSUtpOME14k=;
  b=Ru4ybEiZYpaHv1G3Hi5YvO8vYvAM3RBep9pbohGQScH9c1+MuN3KiNp/
   3NYlB2Emtu58vQS7u5hPuhfV1HeLlAT7M+ATTaX4OYQhHIT+KmD1jJdIY
   OkuFxUaUnOjJKvEhinY8aBuovXIKfpBbLNefDvMiNTZxb/1UkOuUoAdsg
   Y=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 64501450
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:MhIrnKliLzNJXsynzHodhgXo5gyWJkRdPkR7XQ2eYbSJt1+Wr1Gzt
 xIdC2mGPP7ZajehfdpyaoWw9xtVvsLVmoNhT1RqrCk1EiMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2UILd9IR2NYy24DjWlPV4
 LsenuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR
 v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ
 NtxWZOYb18CY4fNvu8hDDJmEBt1P6NEwa74GC3q2SCT5xWun3rExvxvCAc9PJEC+/YxCmZLn
 RAaAGlTNFbZ3bvwme/lDLk37iggBJCD0Ic3oHZvwCufFf87aZvCX7/L9ZlT2zJYasVmQ6qDP
 5NFNGIHgBLoODhwJHIUA6oHg+aPujquXCNRrwqUjP9ii4TU5FMoi+W8WDbPQfSVQe1Fk0Deo
 XjJl0zpDxdfONGBxD6t9nO3mvSJjS79QJgVFrCz6rhtmlL77m4ZBQASVFC7ieKkkUP4UNVaQ
 3H44QJ38/J0rhbyCICgAVvo+xZooyLwRfJ2S8ZnwgCrwZaLyDiaPGMGQDx4eeMf4ZpeqSMR6
 neFmNbgBDpKubKTSG6A+rr8kQ5eKRT5PkdZO3ZaEFJtD83L5dhq00mRFooL/Lud04WtcQwc1
 Qxmu8TXa187qccQn5u28lnc695HjsiYF1Vljuk7s4/M0++YWGJHT9D5gbQ4xawZRGp8crVnl
 CFV8yR5xLpTZaxhbATXHI0w8EiBvp5pygH0j191BIUG/D+w4XOldo04yGggeBowaJpcKGO3O
 RW7VeZtCHl7ZSrCgUhfOd/ZNijX5fK4SYSNug78NbKinaSdhCfYpXozNCZ8LkjmkVQ2kLFXB
 HtoWZ3EMJruMow+lGDeb75EidcDn3lirUuOFcGT50n2itK2OS/KIYrpxXPTN4jVGovf+16Lm
 zueXuPXoyhivBrWOHePqtdLdQhQRZX5bLivw/Fqmie4ClMOMEkqCuPLwKNnfIpgnq9PkfzP8
 G37UUhdoGcTT1WeQelWQhiPsI/SYKs=
IronPort-HdrOrdr: A9a23:biqm1azzXrkYgj28/9BSKrPwKL1zdoMgy1knxilNoHtuA6ulfq
 GV7ZAmPHrP4wr5N0tNpTntAsa9qBDnlaKdg7N+AV7KZmCP0gaVxepZjLfK8nnNHDD/6/4Y9Y
 oISdkaNDQoNykYsS8t2njbL+od
X-IronPort-AV: E=Sophos;i="5.88,378,1635220800"; 
   d="scan'208";a="64501450"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=YgkvOQ1C2ckD1h23ZEccbW2i6AJm0TgFKYrk7ioBpIqbGDTojLk81qWITBu0et+eIH9Ldib0nslooJzZuRtYpzmkFX8Zk23UAjrF6ioeUr9CsX21AdNLtz+oGY5gPCdtC/K/NJJe67rJhzFmGZ1fkNBqw/5fKQDx9261fW6PGpZTuSTvpZT1EH0YfKVFbukgtzFsfyWzm+CzRR+1ZM+AAi2e7Iw5W9MIxGoZuAPkJ8C8eUs9wiR9y+i6RiG6RBkKTjN1lQS0eJhQOO1VGRSgDj5wr02ifTDWbpy2OiTLEYiBntHWCN/g0ByJkcEx+nCMYfT98DeQBCvCQeR1YvwwNQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=0ett+XDu2hDr6Veiai8PvSlhBtqqKmzxcxfDfOHu3C8=;
 b=XJbDtseifBFHoAIh7JMdI+dgT5U1mvmmQI26/e/Udi+h+LHRwkHmxoi5ZwIqlfn/i3yueOe6jGAVtONJQZV0YTPSjL1hZaSRJPG0yWOUO9Xsc5zSclJXGs6IrBGJhhKEEqG6R8Y8LLlDwICvBqxuOPP2cRPCmUyW0fdvVgFaLaIbIjCsNH0u9VjgsCGMNjZsGtM+Th4+m38cDay2wYu76t/VBnaU3ZrjmELQxOdIi6XdU6RQmqBF5j9JQwBpV3Y/J+fbA6AZmWwlVGJWjZQzoOd8Vdw8A29Pdp97Oq5qKsjKwd15WgNT6YfTnVt53gW4Fxo6tRivHuyncXTg7K4POw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=0ett+XDu2hDr6Veiai8PvSlhBtqqKmzxcxfDfOHu3C8=;
 b=XoRYvMbLDlUHiiJXC4/UurLGApGMUEsyTOXJoHhYWnuuNsRNWHHvLlTZs9eaHTk84v9RKlQrz2+jMkbYt6rvYHGRH9WcdW0RFMK9MKsP9OOnCx0ogNZgUR/Ip2FOGoqoQxF4we/xnp9LQtt6r/7BUz6SUm4UYgOMBHvoczLIvxA=
Date: Fri, 18 Feb 2022 10:09:22 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH RESEND v2] x86: introduce ioremap_wc()
Message-ID: <Yg9iQq7AEnDirafd@Air-de-Roger>
References: <8f56a8f4-0482-932f-96a9-c791bebb4610@suse.com>
 <c56aadc8-e568-4625-5d6f-bd2b8981f3ae@suse.com>
 <Yg5gGenFpAwZqtSW@Air-de-Roger>
 <34dac738-0631-f80c-a3db-7367e37ec0b9@suse.com>
 <Yg5urE+rpOQGWiH9@Air-de-Roger>
 <6f343b71-80f7-1aca-3be1-58239ba81dff@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <6f343b71-80f7-1aca-3be1-58239ba81dff@suse.com>
X-ClientProxiedBy: MR2P264CA0124.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:500:30::16) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 1d7e1a47-259f-490e-2b8b-08d9f2be5e2d
X-MS-TrafficTypeDiagnostic: BL1PR03MB6183:EE_
X-Microsoft-Antispam-PRVS: <BL1PR03MB6183B0A24672DB106D38866F8F379@BL1PR03MB6183.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 67SYd7OsW6IuBqN6CUQt99zoXTXR1Y6pNKVhblVabca4DVT0VGkOfe01mvavqOqtRl8jb/L3WPshT/yAgLVw0piQK9Poh0ttvUAZdnlWsIts1eI6S/qk6gQPCo7C35ZOdfYuIo2tE+drcJnqTeq7JENG9Z/d1WxCDBwcXFiNFXYFmjJb8pa0xIxDvuCMzyKE8dtngWDQuE/EHQz19sOu0RT7gnmt/g4P4+WgYZ/eUXuXWk7UnL9IcLUlq/c4yYq3j3OT4ixZFrlbqXDNqSDysdV2Nnpc+OI8U3xzafHGKEviP7DKt0akNtst9eoA4A9Q0AuHafjIGeW2Ug07EYT8bhq6Z+Mq3jga0f+JSRf97o7hBEJvzjvGMc/d8axXXv4Vg1QgL+h03vSEWUmGkxmGFguZor71Kfjcoz8MFRTb1DTZL8nDQy5BCWmpO4ow6u+OCqw17aCd15yEH6QQRRtJnUHxnfluFWv5xMPofXQfPXIqE9FIHj18cHLUsOjvpKULXMr8QcEKD+EJgVktym35ScdbyDfu+1U7ZshTWobz35kCtJ7QKJfJkt3Zd9OlNOgXRzUkA+UbTKfbwW/WurMkL81S4oYiC/sNngud/nS4n89hQRYlW96B+pgFv9xHX1PXnwYEcqgOCkufm+xq7PRhzg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(83380400001)(508600001)(316002)(85182001)(9686003)(5660300002)(26005)(53546011)(8936002)(6506007)(33716001)(186003)(6666004)(6916009)(66556008)(66476007)(38100700002)(6486002)(86362001)(54906003)(6512007)(82960400001)(8676002)(2906002)(4326008)(66946007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VVp1b1ZxNlpFVjF2R2NNcjRURnVSaWRwNTJCTndmOXJINFZmU3FFLzcveXBn?=
 =?utf-8?B?TEQ2RFByVEl5OXZkbExXcjVKU0lINXB1VWJKWWNEMFd5SGZYQ1paaldkZ0RD?=
 =?utf-8?B?Zms3c2VRWFpFRE10cHVZMkxGZ29hK2Z1cWtkek52L1VqakoySnZiQWVSbG1V?=
 =?utf-8?B?dkxTR3Q5akxXa0I5U1hLSzY2OTduMlc1RHgycEhES3RqN0JpZDZjU05ROWxx?=
 =?utf-8?B?TFpUWHN3V2ZFK2I5dmNMS3hISWg1akNvaEZuUm1yejAyb1M2aHRKTGNqYkxS?=
 =?utf-8?B?T0R3MHQxalFac3huM2hhSVBGK043aTRsaGpWL3lNbVZUWEVuNkFHNnRsNWRx?=
 =?utf-8?B?YzdZV2pTbGRuOHJLZnpTVXUrTWo4NndTSmhKZjNDNm9pRDg2N0xEc2Ftek5w?=
 =?utf-8?B?d0pzOG9HKzNNcFFTR3VsM2dxQmtabE0vL1NLdlROeVZBRVZWcnNzS0ZuYzNq?=
 =?utf-8?B?alhFRUtnRWp6N1dpUlovSXZ3bG1vbi93VUpHekNra3B5Q2FBaTNjVklKRCty?=
 =?utf-8?B?QjIvT3d2MXpja1BlYzJ3WERCK2VpaTdkS2UrYzZOWWttZnVtbS9TaGZ4WkN3?=
 =?utf-8?B?N1FLbXFNeXFlQkJUUm1QMEZvcURsNGxBU2JlTXdxRnhjMG5TK3pucDQyNk5y?=
 =?utf-8?B?WDlmVnJQYU0xTS85VmNkdlBiYWZnaTNocVRaSmF3MEo0V25DaXNoaFFTcmFv?=
 =?utf-8?B?ZjZYaW13c3A5QlhadXJNR2dxckpiMG82K3NKS2RpdTR0RUNPYVRaL3dKMHFh?=
 =?utf-8?B?Q2JZeXUrQy90c1RBeXJlUjcrREsrTmxRbENBM2h5d3BVek5iYlNvbG05alpS?=
 =?utf-8?B?bFIwdGtVQ1VJc3N5YWZyZDU1MXRMT0VlOGZ3T0tGblRWRWdRZjA0am80VFlC?=
 =?utf-8?B?SjMvaFVKTzlUTWttc00rN0xRTW9QdytCL0IvMHMzZllvSDB5QU82UUQzVEU3?=
 =?utf-8?B?NFM0bXNxSWl5UklCK0RtdnRTbERNMWttV1YvaDRWS3NvSXNRaVpaQ2xIWFEr?=
 =?utf-8?B?VE5vZ1lrbFEvQmRSWFZBeFFRLzMyc0dFekRYSFNBKzhvNVFJbFY2RnVQQ21E?=
 =?utf-8?B?TkZwLzNHYkZsQWpIWkJORk8vL2xmWG9GU0dPbzRVcDd6S2plbU1ZY1FOeDRK?=
 =?utf-8?B?a3NrbG5Zc25wOWg0aUdGWmIwY09jQ2lOMXU2UXJEREpnQ3FQSnpDMjNFMk1O?=
 =?utf-8?B?cVRFR3lJSXJhNi9TN3lrbkJGc2NxMU9JbXozWk5zTFJ5T21vckhpYThYbWJS?=
 =?utf-8?B?cWJTVnowKzltOW1ZTEJrZnEyQzFWMlNHUW9wb0d0MkM3b0FWeTN1YUk5Q2k5?=
 =?utf-8?B?VHpkNm1ZcmRBd0dxeUtjSnNQTHA3OVdnNDB4LzhRVHBWUGFaeTg4VVozZGcw?=
 =?utf-8?B?Y1doOFBIM1pWeGVZL0M2MXFmZmRBa3FJL2dBSHhqU2kyWGc5amVmL3Bra1VE?=
 =?utf-8?B?V1k4RWt2TTNpckN2VEVTZElQSGZxMFVGL0pwUEdYQ2hXYit3N0xPN0JPZmlq?=
 =?utf-8?B?VjdDZ0d5RmVWTDlQVUR2dUo4NkpScnJWcVZ2S2RwWVpWZ09hVi92eUN3KzFL?=
 =?utf-8?B?c3FBRW94NjJuNGN0bUdWMHkxK0ljKzVwYXY3NTdZRk9BT0kyaUZ0V05jRnp0?=
 =?utf-8?B?SFNMcHMwWmZrcjk0UmxKcEF0akZGT3FJbEtqSTBodEZ2cTRMdzNURjNSUnMz?=
 =?utf-8?B?bHhFdU05V1pOREl3ZldPMmg2WnZTVWE5RllQWnRJYWRoTFdFYm1MQnNEY1B6?=
 =?utf-8?B?aDJtdDFOK2FSZk5FbS9QNHF1RFp4QlA2UlJyTUhjVnRaN1F6RlpUc0t1bTZW?=
 =?utf-8?B?dHFxb3hGbURnZ1J1WUZrd0NCK2hMdGxxUjc4bE81dmpEa2Q2QmdvdXlTMEda?=
 =?utf-8?B?OG1SSklYWkQwRWFKQWJhLzhsNzZqNStzcHpuYzhHQXlQK0Y5TWF5R21ZdmVo?=
 =?utf-8?B?bGV1anJPNjRCaEJoQmpUWVFjZkRvVGRkZXFjTWIrcTRNUDVvSUU2bEptVWZF?=
 =?utf-8?B?TllUcW15MXFXbjhiRmFCSW9jempjZUUvbk0yWURBT0tXTUZiR0hSWFlTbFRi?=
 =?utf-8?B?YWYzWnhNRW1ndEdKWEhIYkl4TDZqektZUEQvSldvNGFpYkVHUzNLclRwRUY0?=
 =?utf-8?B?VmlmaW5ZK1lBS3FzVnF2cmt4MnhVYURwWFJNelRKK2NhMkgrLzF2eUUxNzZD?=
 =?utf-8?Q?cbSJhsQ7agxqOzsGed0FAgE=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 1d7e1a47-259f-490e-2b8b-08d9f2be5e2d
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Feb 2022 09:09:28.9705
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: L4ZMJXMxrYQE6EHq4HmEhpDIv/e2BOE7fd2HfQ1mT9uIIWA+Rq80DzpF9QfwMmSQvntKdaLNEqMixd3z669jPA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR03MB6183
X-OriginatorOrg: citrix.com

On Thu, Feb 17, 2022 at 04:57:41PM +0100, Jan Beulich wrote:
> On 17.02.2022 16:50, Roger Pau Monné wrote:
> > On Thu, Feb 17, 2022 at 04:02:39PM +0100, Jan Beulich wrote:
> >> On 17.02.2022 15:47, Roger Pau Monné wrote:
> >>> On Thu, Feb 17, 2022 at 12:01:08PM +0100, Jan Beulich wrote:
> >>>> --- a/xen/drivers/video/vga.c
> >>>> +++ b/xen/drivers/video/vga.c
> >>>> @@ -79,7 +79,7 @@ void __init video_init(void)
> >>>>      {
> >>>>      case XEN_VGATYPE_TEXT_MODE_3:
> >>>>          if ( page_is_ram_type(paddr_to_pfn(0xB8000), RAM_TYPE_CONVENTIONAL) ||
> >>>> -             ((video = ioremap(0xB8000, 0x8000)) == NULL) )
> >>>> +             ((video = ioremap_wc(0xB8000, 0x8000)) == NULL) )
> >>>>              return;
> >>>>          outw(0x200a, 0x3d4); /* disable cursor */
> >>>>          columns = vga_console_info.u.text_mode_3.columns;
> >>>> @@ -164,7 +164,11 @@ void __init video_endboot(void)
> >>>>      {
> >>>>      case XEN_VGATYPE_TEXT_MODE_3:
> >>>>          if ( !vgacon_keep )
> >>>> +        {
> >>>>              memset(video, 0, columns * lines * 2);
> >>>> +            iounmap(video);
> >>>> +            video = ZERO_BLOCK_PTR;
> >>>> +        }
> >>>>          break;
> >>>>      case XEN_VGATYPE_VESA_LFB:
> >>>>      case XEN_VGATYPE_EFI_LFB:
> >>>
> >>> I think in vesa_endboot you also need to iounmap the framebuffer
> >>> iomem?
> >>
> >> Again part of the full series. I guess I was a little inconsistent
> >> with leaving the VGA unmap in here, but breaking out the VESA part.
> >> It's been a long time, but I guess I did so because the VESA part
> >> needs to touch two files.
> > 
> > I think you are hesitant to include the chunks for the above items? (or
> > maybe I'm not properly accounting for their complexity).
> 
> There's no complexity, it's really just that the zapping of the pointer
> needs to be done in a different place from where the unmap is. See below.
> 
> Jan
> 
> video/vesa: unmap frame buffer when relinquishing console
> 
> There's no point in keeping the VA space occupied when no further output
> will occur.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

For both patches, the one inline here and "x86: introduce
ioremap_wc()".

While at it, I think you should also push "video/vesa: drop
"vesa-mtrr" command line option".

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Feb 18 09:16:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 18 Feb 2022 09:16:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275255.471034 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKzNf-0004OL-2X; Fri, 18 Feb 2022 09:16:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275255.471034; Fri, 18 Feb 2022 09:16:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKzNe-0004OE-Te; Fri, 18 Feb 2022 09:16:46 +0000
Received: by outflank-mailman (input) for mailman id 275255;
 Fri, 18 Feb 2022 09:16:45 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Mscz=TB=epam.com=prvs=4048df52bb=oleksii_moisieiev@srs-se1.protection.inumbo.net>)
 id 1nKzNd-0004O8-CY
 for xen-devel@lists.xenproject.org; Fri, 18 Feb 2022 09:16:45 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7c66d1ed-909b-11ec-8723-dd0c611c5f35;
 Fri, 18 Feb 2022 10:16:43 +0100 (CET)
Received: from pps.filterd (m0174680.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 21I98aT4024031;
 Fri, 18 Feb 2022 09:16:36 GMT
Received: from eur03-am5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2058.outbound.protection.outlook.com [104.47.8.58])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3ea8jar1gu-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 18 Feb 2022 09:16:36 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com (2603:10a6:102:ea::23)
 by AM6PR0302MB3223.eurprd03.prod.outlook.com (2603:10a6:209:1d::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.14; Fri, 18 Feb
 2022 09:16:33 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::c1c:f98:9dd:86e0]) by PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::c1c:f98:9dd:86e0%6]) with mapi id 15.20.4995.020; Fri, 18 Feb 2022
 09:16:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7c66d1ed-909b-11ec-8723-dd0c611c5f35
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XJ3spoHrDqbdN/D2vsbIjUPJnHVRB6/3hKkeeJjZEbpPagCtQ4JhkAX+46w5LrF7T1GPtIH1dbFthubmymEomjPVGSyGkd5QziHLVJ1//yEExzH42bGKTDc8c9wFlUhWcR+wTh7TQU2D9SNHcHPNqNMtlL/0eA1SN7P1HP2FpMJpFh47TNxRiouKsIq9UPUXHCmMc/iVgNc4mKAsqW0/PXjXeKPoERMOX3cQol9s851LdTxXOouDYnZ4fc/N1hnGHLa4zTBF6YdPzzft6iikkKT1AothVyZj46oJ7n1/S8mqL960DdUaZC5Jpq4mJPqTv2YN0wm64+zy4486b2nJ2Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=3EqCdQ3YamF9qUl0RJEherENn3kpxyXsvfJ+HCmnHrI=;
 b=Ght2iHLPsx/2LY7X77UrR24zfxKHXk9K6IFTlVN8l33y8ePU3/OmtO/LVZQwcavFJ/bIDi6ctAClZCUfGiCNh3w9bbzVE+HUE2bGSCFib1MZJODC/1QpSvPwM77PiSHjgrESUX7+XoOAXxNpF1lMdjXnNSp/FtFEClCAjW20aqLB6rD7S4NEzCPay8JI6s0W14XVqubhd7Hvkh8WxCAwom4LObYEQKJ9gMHa1UDnjYWcX/3gLfhc3FS8UAQTJ3gXaDVlEvsQXWK2s6zOZp9/4WDFa7K6SHB5BFB7GYjSkaPHSO6DfAY/OX4SOzTb4HgNlpaNyexblnBltT7Pmn/hnA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=3EqCdQ3YamF9qUl0RJEherENn3kpxyXsvfJ+HCmnHrI=;
 b=sBkwJ4/6uKZ7S8CgwC5WUvaYZyu73HiMHohHh1eViOQIYiJRIboMHeg7UmpQjfyOM5DMkDkUwqv4QUFMlSr7mVYfdYUu6ITZU5ByedcdgVHsuWgVPXakcEjW0+y+NvPjXAaFykHmzsuXfh7YA0C1tNox6VxOovJbG6Tb5bFcMwYHW7XuD1KWZ0vcRnPP7SFOkbtnSUi/pXzLM9Fk3bFpNali6LPgI7ROeLCSLoYW1qrjJLdX+UJES3ezGbyRLIMJLdAXPuVDKqrxLQ1fu/00J+GGloyYFOm8x7d6LhtKdJLF3M6jK6AOVNNkcFk6z5Oy+sczCtFd0208uzQH5k5F+A==
From: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
To: Julien Grall <julien@xen.org>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        Wei Liu
	<wl@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>,
        George Dunlap
	<george.dunlap@citrix.com>,
        Jan Beulich <jbeulich@suse.com>,
        Stefano
 Stabellini <sstabellini@kernel.org>,
        Nick Rosbrook <rosbrookn@ainfosec.com>,
        Anthony PERARD <anthony.perard@citrix.com>,
        Juergen Gross <jgross@suse.com>, Paul Durrant <paul@xen.org>
Subject: Re: [RFC v2 6/8] tools/arm: Introduce force_assign_without_iommu
 option to xl.cfg
Thread-Topic: [RFC v2 6/8] tools/arm: Introduce force_assign_without_iommu
 option to xl.cfg
Thread-Index: AQHYHRW3O86755dYV0qSgPdVO9oeMayX6acAgAEsnQA=
Date: Fri, 18 Feb 2022 09:16:33 +0000
Message-ID: <20220218091632.GA1486420@EPUAKYIW015D>
References: <cover.1644341635.git.oleksii_moisieiev@epam.com>
 <d333126d12f2281f8df92e66cfba1c9eb2425dca.1644341635.git.oleksii_moisieiev@epam.com>
 <ab6d8d13-30cf-d322-668e-f3f5aaa56824@xen.org>
In-Reply-To: <ab6d8d13-30cf-d322-668e-f3f5aaa56824@xen.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 29a83539-7b35-4092-0413-08d9f2bf5b6e
x-ms-traffictypediagnostic: AM6PR0302MB3223:EE_
x-microsoft-antispam-prvs: 
 <AM6PR0302MB32234D8B6694B2F3480579A1E3379@AM6PR0302MB3223.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:1923;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 oBvpv2ghFzqbNzn0y4EQd2P7i1Pgu+GlRD/O2WzS1cxbfBzGh+4Ez84qmslmbaKZCTj+61OjfSwymVUX/LHyfrbuPjpr3Zd2wss4XWk8AXkY4xTLA+F6V0O9vve49xPXdHQ3SmVXcBb+Ve3kCjVY0vgeftPgL6K9Uut0ek9RHai7hTqahGTVT7vIGP11FCd8xwDX7GTFaQBKxEOZ9Owg852rQmlS8u6jpNjpuAu00e8VBfs8P/R/HEdCLvje05P3BaiP6bljr/lqBrcOJl13Qv7RZMf65ePsq1fKAHMSd654cvb9asOjuSUVRB60F1ZeL2GIayWMs/JFqOUHpnog87W5EhAKGQ6cZN5yiiL3Ct+scqlBrVdgnljLvh4UhGQ0+0oLrQcdlAjcOPU+lf0Nm6H1BznZ/Q8AdslPEPQQFzoFz04cN+5D2pNhj6AoV1pPLdrVIBLykDfiPbZl+KCi4c2o13QV8Rsda7wJQQppfpDz5pxe8QM02p3tqaK88DC0aIgSJe+A0KxEM49WOBD3EDzdtrnt3KAcBmh3E0qovZ0RvMPf5yLl9gRXyTShqmxAnmKr5e600p66vHsXB8JBIB5jyUxyGbRPPgPuhlh0M+kzdp8A0R/4Z6daLilfL6QHUBmDyb8GRiGmzJVR7juzBKgWJPx2U//vDVXLkHCwXIOuHgzzM3rX6U16JiQ1qURQBoPHBT/nt2xd6Hbloyz+Y2emsecYtJ3ykznGB3ssvnxbLmSf4EoxSHifvcRsgJOX0M+eukapfigP4BRqYJ1k3jnECXDhgXbkWhdU3BpaxqQ=
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR03MB7136.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(71200400001)(508600001)(7416002)(2906002)(966005)(6486002)(5660300002)(76116006)(66946007)(8936002)(186003)(26005)(33656002)(66556008)(66476007)(86362001)(66446008)(64756008)(4326008)(91956017)(8676002)(1076003)(33716001)(316002)(122000001)(38100700002)(83380400001)(53546011)(6916009)(6506007)(54906003)(9686003)(6512007)(38070700005);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?DehOmVzR3DYxqa+MDKvOZCme099biZcg4vQ++9UirZrDFSqn6g7zpj4FGFMH?=
 =?us-ascii?Q?Y9Ecwjjq1Mpqux97LNZsGZcjAtSf7dAjfOQVI/DqEnpwoXyV7dZxzgvd+/BR?=
 =?us-ascii?Q?AInFyO/102AO23KvJebs+Ft+YJpT1T8tyWtq8BKfuvLveKlGCWfPjHl50+0o?=
 =?us-ascii?Q?6aMk84MyHNG7Hzvn1BBWLjUMMmVb3xOITx84zFScjc7lgKYp3exFQt4imf5H?=
 =?us-ascii?Q?QC+3WQgWT6aPSxKeBQojifVan3OpaYylMemCindSAPniN2iqzMJdoo5Qcqe3?=
 =?us-ascii?Q?IfezLIQ3f4LCFdt0arW3MsUC8FxFucp2nu2wpAA99SU1Y2nhkhkOWOa8t89S?=
 =?us-ascii?Q?z0Hq2DhWYlazN+DgUOJ+1vcjbafvH+hzJ+z+TgoPsRf7C/4Dzy2+izRrlIa6?=
 =?us-ascii?Q?G19XVNU0NgbOW/WEYCULC5h6bXJCgaA0F/9O6Y/4WflqRx2BAuUPy5CpJsy8?=
 =?us-ascii?Q?1latsi6bXH/ZkddHeFYod1iJ5V9yHt5uFLjCCdvEdvHEWTiLJBiscQ8Kstkh?=
 =?us-ascii?Q?kyX5SXbEI9cU2/WKcdKIYsiIS3hBVdh1bzP3+XwRjn6hVZfZx5Ky2a8LsFn1?=
 =?us-ascii?Q?5fK1zJfZ57kdcUM2WznHCHVymFcJnId/5qYikFxZ6hjWMsenR9BUUVK4dGGA?=
 =?us-ascii?Q?vIssrFUQtP+gsAxOrSTA4Pr9/BjMIed2co0i+w3sp3vsK06NGUw6D+9FOMll?=
 =?us-ascii?Q?U1BzS9IddHRavnDV14y0VSVHjhrA4sKrcUWoUOfpsIaUIGZXpqHWi5EtgG3M?=
 =?us-ascii?Q?ZGj+EjS0Z1cIaby78J3j3mTFvX/uyy56UYZVkfjmTxu+EsmrO3yb594W6Ept?=
 =?us-ascii?Q?QkMZWkawlqGuLmjR/B/zHrBP7K4qNXO09Lx2YB4ZBCwivig9PBCNUbtXfhRu?=
 =?us-ascii?Q?tyq4aa01fmyRvVoODx/G/6/D2czACX15GcSkG1aS8R2XtWbHOPrnXSugEO0Z?=
 =?us-ascii?Q?isoCN90zR6AUwEqSPMekh2cLJPPArmnYumOV75v8y0yh2R3LjPnuDC7txbUB?=
 =?us-ascii?Q?BYnmE4Y917XhrWPHl+eKNOumQYjgvMp2LfF1RGdUSO4a0l8iTV7+w8IjztCb?=
 =?us-ascii?Q?Jph4DcpI/dI0BxqzCaGfXXg7HzwkveyymQcmZc8IZj61FxIXYt8H0DudDd7Z?=
 =?us-ascii?Q?Dz8VcXXBtkK3eiTUazorHEpgwkoETU3svH3/7hHgtlSI9I50stcR4eUIE19n?=
 =?us-ascii?Q?gGaNcFr+7Nd2AIhFZZ4JOz6TTacG10k5mcalXlOK41GvAuIQK7Y3k0ic0HCb?=
 =?us-ascii?Q?LY3y6miLTxhxec96aWknCnO7QKQNDGSGDc/12d0xO2nSJKm7K8ZEWV0ZS1B7?=
 =?us-ascii?Q?BFEpSVX2G36RreeumKKrOVxg34/TZGmFKp8g/j9xsEpzMbiK4jaBTlTLWH9C?=
 =?us-ascii?Q?silqVjf7w+3L1OXIJSkps9VPiKLMD1312JT/Jz4y/Jud5Ttj+L9emSy/I4mk?=
 =?us-ascii?Q?cGWR1Kc7EDRmPJIE9FCq5hmASmtLFoF/e+9qyTbnS7SY21FBaiEOCtdSUoiQ?=
 =?us-ascii?Q?tEUHaSISXXYCtPA4ic94j0u/SvfV64juw2SO/eHLjqKWmpbDlrPLMW58+vl7?=
 =?us-ascii?Q?dWS0XpMJUFiKp3U8jDkeWVk+E7vUBmNCeHHsXv1AKm9l2qh7vjvrZDb0cu+e?=
 =?us-ascii?Q?eAVRj615mstj2Ktu6ugPzj+iXYmVuzu/y/gPrcTiRvnqbgM2O4EZpOxAtgKZ?=
 =?us-ascii?Q?G3QqF19OtQkYEGvWaXrHrfWAIks=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <0CE841105886904E98607A1116C9554D@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR03MB7136.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 29a83539-7b35-4092-0413-08d9f2bf5b6e
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Feb 2022 09:16:33.5621
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: zjG2ebqitn9eyTZqvMuzSwDo3NDDlhrW3Ep/wT1PdkRMaMRDrLumZyq+KcXwIBq0uP5/VcKnMA1N8DyCnwOU0I1G821+cozwWNSsyhyXGS8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR0302MB3223
X-Proofpoint-GUID: EZ8hh8c9iDMgeDhS9itqvQkjsCbNOZ0J
X-Proofpoint-ORIG-GUID: EZ8hh8c9iDMgeDhS9itqvQkjsCbNOZ0J
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-18_03,2022-02-17_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501
 spamscore=0 impostorscore=0 suspectscore=0 mlxscore=0 adultscore=0
 clxscore=1015 phishscore=0 bulkscore=0 malwarescore=0 mlxlogscore=999
 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202180060

Hi Julien,

On Thu, Feb 17, 2022 at 03:20:36PM +0000, Julien Grall wrote:
> Hi,
>=20
> On 08/02/2022 18:00, Oleksii Moisieiev wrote:
> > If set, Xen is allowed to assign the devices even if they are not under
> > IOMMU.
>=20
> I think you mean "not protected by an IOMMU".

Yes. Thanks.
>=20
> > Can be confugired from dom.cfg in the following format:
>=20
> s/confugired/configured/
>=20
> > force_assign_without_iommu =3D 1
> >=20
> > This parameter has the same purpose as xen,force-assign-without-iommu
> > property in dom0less archtecture.
>=20
> s/archtecture/architecture/
>=20
Shame on me :(. I'll fix that.
> >=20
> > Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@epam.com>
> > ---
> >   docs/man/xl.cfg.5.pod.in              |  9 +++++++++
> >   tools/golang/xenlight/helpers.gen.go  |  5 +++++
> >   tools/golang/xenlight/types.gen.go    |  1 +
> >   tools/libs/light/libxl_arm.c          |  3 +++
> >   tools/libs/light/libxl_types.idl      |  1 +
> >   tools/xl/xl_parse.c                   |  3 +++
> >   xen/common/domain.c                   |  2 +-
> >   xen/drivers/passthrough/device_tree.c | 19 +++++++++++++++++--
> >   xen/drivers/passthrough/iommu.c       |  5 ++++-
> >   xen/include/public/domctl.h           |  5 ++++-
> >   xen/include/xen/iommu.h               |  3 +++
> >   11 files changed, 51 insertions(+), 5 deletions(-)
> >=20
> > diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in
> > index b98d161398..ddf82cb3bc 100644
> > --- a/docs/man/xl.cfg.5.pod.in
> > +++ b/docs/man/xl.cfg.5.pod.in
> > @@ -1614,6 +1614,15 @@ This feature is a B<technology preview>.
> >   =3Dback
> > +=3Dover 4
> > +
> > +=3Ditem B<force_assign_without_iommu=3DBOOLEAN>
> > +
> > +If set, Xen allows to assign a devices even if it is not behind an IOM=
MU.
> > +This renders your platform *unsafe* if the device is DMA-capable.
>=20
> I agree this is going to be unsafe. But the more important bit here is th=
is
> is not going to work because the guest has no way to translate a GFN to a=
n
> MFN.
>=20
> Your guest will need to be direct map to make it usable. So I would add t=
hat
> this will *not* work with DMA-capable devices.
>=20
> Also, can you explain in the commit message why you want to allow this
> setup?

Ok, I will update the commit message.

>=20
> >       xlu_cfg_get_defbool(config, "xend_suspend_evtchn_compat",
> > diff --git a/xen/common/domain.c b/xen/common/domain.c
> > index 093bb4403f..f1f19bf711 100644
> > --- a/xen/common/domain.c
> > +++ b/xen/common/domain.c
> > @@ -512,7 +512,7 @@ static int sanitise_domain_config(struct xen_domctl=
_createdomain *config)
> >       if ( iommu )
> >       {
> > -        if ( config->iommu_opts & ~XEN_DOMCTL_IOMMU_no_sharept )
> > +        if ( config->iommu_opts >> XEN_DOMCTL_IOMMU_MAX )
>=20
> XEN_DOMCTL_IOMMU_MAX will be defined as:
>=20
> (1U << _XEN_DOMCTL_IOMMU_force_iommu)
>=20
> This means the shift will do the wrong thing. However, AFAICT, this new
> option will only be supported by Arm and likely only for platform device =
for
> the time being.

Thanks, I will fix that.

>=20
> That said, I am not convinced this flag should be per-domain in Xen.
> Instead, I think it would be better to pass the flag via the device assig=
n
> domctl.

Do you mean that it's better to set this flag per device, not per
domain? This will require setting this flag for each device which should
require either changing the dtdev format in dom.cfg or setting
xen,force-assign-without-iommu in partial device-tree.

Both of those ways will complicate the configuration. As was mentioned
before, we don't want to make domain configuration more complicated.
What do you think about that?


>=20
> >           {
> >               dprintk(XENLOG_INFO, "Unknown IOMMU options %#x\n",
> >                       config->iommu_opts);
> > diff --git a/xen/drivers/passthrough/device_tree.c b/xen/drivers/passth=
rough/device_tree.c
> > index 98f2aa0dad..103608dec1 100644
> > --- a/xen/drivers/passthrough/device_tree.c
> > +++ b/xen/drivers/passthrough/device_tree.c
> > @@ -198,6 +198,7 @@ int iommu_do_dt_domctl(struct xen_domctl *domctl, s=
truct domain *d,
> >   {
> >       int ret;
> >       struct dt_device_node *dev;
> > +    struct domain_iommu *hd =3D dom_iommu(d);
> >       switch ( domctl->cmd )
> >       {
> > @@ -238,6 +239,16 @@ int iommu_do_dt_domctl(struct xen_domctl *domctl, =
struct domain *d,
> >               return -EINVAL;
> >           ret =3D iommu_add_dt_device(dev);
> > +
> > +        /*
> > +         * iommu_add_dt_device returns 1 if iommu is disabled or devic=
e don't
> > +         * have iommus property
> > +         */
> > +        if ( (ret =3D=3D 1) && (hd->force_assign_iommu) ) {
> > +            ret =3D -ENOSYS;
> > +            break;
> > +        }
> > +
> >           if ( ret < 0 )
> >           {
> >               printk(XENLOG_G_ERR "Failed to add %s to the IOMMU\n",
> > @@ -275,10 +286,14 @@ int iommu_do_dt_domctl(struct xen_domctl *domctl,=
 struct domain *d,
> >           ret =3D iommu_deassign_dt_device(d, dev);
> > -        if ( ret )
> > -            printk(XENLOG_G_ERR "XEN_DOMCTL_assign_dt_device: assign \=
"%s\""
> > +        if ( ret ) {
> > +            if ( hd->force_assign_iommu )
> > +                ret =3D -ENOSYS;
> > +            else
> > +                printk(XENLOG_G_ERR "XEN_DOMCTL_assign_dt_device: assi=
gn \"%s\""
> >                      " to dom%u failed (%d)\n",
> >                      dt_node_full_name(dev), d->domain_id, ret);
> > +        }
> >           break;
> >       default:
> > diff --git a/xen/drivers/passthrough/iommu.c b/xen/drivers/passthrough/=
iommu.c
> > index 6334370109..216a9058c0 100644
> > --- a/xen/drivers/passthrough/iommu.c
> > +++ b/xen/drivers/passthrough/iommu.c
> > @@ -193,6 +193,8 @@ int iommu_domain_init(struct domain *d, unsigned in=
t opts)
> >       hd->node =3D NUMA_NO_NODE;
> >   #endif
> > +    hd->force_assign_iommu =3D opts & XEN_DOMCTL_IOMMU_force_iommu;
> > +
> >       ret =3D arch_iommu_domain_init(d);
> >       if ( ret )
> >           return ret;
> > @@ -534,6 +536,7 @@ int iommu_do_domctl(
> >   {
> >       int ret =3D -ENODEV;
> > +
>=20
> Spurious change.

I'll remove this.

>=20
> >       if ( !is_iommu_enabled(d) )
>=20
> Should not this check be updated to check force_assign?

That's a good point. I'll take a look on it.

>=20
> >           return -EOPNOTSUPP;
> > @@ -542,7 +545,7 @@ int iommu_do_domctl(
> >   #endif
> >   #ifdef CONFIG_HAS_DEVICE_TREE
> > -    if ( ret =3D=3D -ENODEV )
> > +    if ( ret =3D=3D -ENOSYS )
>=20
> AFAICT, none of the code (including callee) before ret have been modified=
.
> So why are you modifying the check here?
>

Because this check will fail if we have CONFIG_HAS_DEVICE_TREE define,
but do not have CONFIG_HAS_PCI and iommu_do_dt_domctl will not be
called.
Same thing if switch/case inside iommu_do_pci_domctl go to default and
return -ENOSYS. This part looked strange for me. But I will definitely
go through this part once again.

Or maybe I've misinterpreted this part?=20

> >           ret =3D iommu_do_dt_domctl(domctl, d, u_domctl);
> >   #endif
> > diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
> > index b85e6170b0..bf5f8c5b6b 100644
> > --- a/xen/include/public/domctl.h
> > +++ b/xen/include/public/domctl.h
> > @@ -81,8 +81,11 @@ struct xen_domctl_createdomain {
> >   #define _XEN_DOMCTL_IOMMU_no_sharept  0
> >   #define XEN_DOMCTL_IOMMU_no_sharept   (1U << _XEN_DOMCTL_IOMMU_no_sha=
rept)
> > +#define _XEN_DOMCTL_IOMMU_force_iommu 1
> > +#define XEN_DOMCTL_IOMMU_force_iommu  (1U << _XEN_DOMCTL_IOMMU_force_i=
ommu)
> > +
> >   /* Max XEN_DOMCTL_IOMMU_* constant.  Used for ABI checking. */
> > -#define XEN_DOMCTL_IOMMU_MAX XEN_DOMCTL_IOMMU_no_sharept
> > +#define XEN_DOMCTL_IOMMU_MAX XEN_DOMCTL_IOMMU_force_iommu
> >       uint32_t iommu_opts;
> > diff --git a/xen/include/xen/iommu.h b/xen/include/xen/iommu.h
> > index 6b2cdffa4a..a9cf2334af 100644
> > --- a/xen/include/xen/iommu.h
> > +++ b/xen/include/xen/iommu.h
> > @@ -330,6 +330,9 @@ struct domain_iommu {
> >        * necessarily imply this is true.
> >        */
> >       bool need_sync;
> > +
> > +    /* Do not return error if the device without iommu is assigned */
> > +    bool force_assign_iommu;
> >   };
> >   #define dom_iommu(d)              (&(d)->iommu)
>=20
> Cheers,
>=20
> --=20
> Julien Grall

Also I've posted a task on AT-F Phabricator asking about the feedback
about my SCMI implementation.
Link: https://developer.trustedfirmware.org/T985
Hope I'll be able to start a discussion and get an implementation, which
is approved by AT-F.

Best regards,
Oleksii.=


From xen-devel-bounces@lists.xenproject.org Fri Feb 18 09:23:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 18 Feb 2022 09:23:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275262.471044 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKzTw-0005nl-NX; Fri, 18 Feb 2022 09:23:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275262.471044; Fri, 18 Feb 2022 09:23:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nKzTw-0005ne-KD; Fri, 18 Feb 2022 09:23:16 +0000
Received: by outflank-mailman (input) for mailman id 275262;
 Fri, 18 Feb 2022 09:23:14 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=v1rr=TB=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nKzTu-0005nY-H1
 for xen-devel@lists.xenproject.org; Fri, 18 Feb 2022 09:23:14 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 655cc655-909c-11ec-8723-dd0c611c5f35;
 Fri, 18 Feb 2022 10:23:13 +0100 (CET)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2052.outbound.protection.outlook.com [104.47.12.52]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-37-0mKHGwbMMmScHo8n-eTT3g-1; Fri, 18 Feb 2022 10:23:12 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM9PR04MB8969.eurprd04.prod.outlook.com (2603:10a6:20b:408::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.17; Fri, 18 Feb
 2022 09:23:10 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4995.016; Fri, 18 Feb 2022
 09:23:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 655cc655-909c-11ec-8723-dd0c611c5f35
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645176193;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=i0ZwXjK2viuZHUHMqRNew1B15bGiZaTyRgb8wudTT48=;
	b=k1mbqchgarP75pMC6YGb4MtqqQXUsPXfGtdCmNy8rvlSFRCcMw5uheCtA8XEbahinZvxIO
	AXnk0yPZhT7o7u4h3rp4L2A2xjQ4UgUMHxIhEIlIuIZ8P+jEh7hXL5/ZXZw5LPVhcs9xLS
	yncj+VAUAtU11i3ztZYiOQ0zlevu0Fo=
X-MC-Unique: 0mKHGwbMMmScHo8n-eTT3g-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=AfkSbpArsXbUCPg3fjdhcMlhCBYkvwiOt7Euxg7NNVcgQeuVR6GQY9NxZ1EXoISx61SMo4F5NP1OO8VTPanudezvHD/5cd6dugtLRKQrBQkmHYMdTqwGR/JPf+Bi+kj8zb0ATlQnQnmx51a8ejtDx7utLPhVFKrx+RDj7QyKDoF2yF8ezb2tJtyuakC7MR8b6kX85lF2Fb7rr3Ha4uxvdaN9AjzX0kcMKUKXvadaUb9R7RXS7JXNeBlTuo+l3mfAtGblL6RzBwPQvZm23WsBt83eMMCA3LTf6cqKUmsg7fHWGkrkyfwnchTzqV+TkJpoX2X4GF4cyMHq37NoQImtJg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=lPOU4T+sDkpArn1Kw6m7Awwf/Dr26oM/r+SUieR7NJg=;
 b=VEwEU3rMxcoTlCq+SJBSTvxdMPfOE7sg8+cIjjPSMqh36Mh6GTWZn74v9tELhhZa1ob+o0JjwaH9mgg7H6QQ2gVfb/fAqCuJqz5Gcp7ICF39UgmfXbF0ESYgnT4qGnfCabwuhtYbJpi3RQOIHwjp3JMT8Gzwsv6SoC43692+SuN9MNSM9j1qJUIv8+CSXSJbVWwBVQbd+Db0s3BWkph/cePFZmqFxH5F2Ubs4rRCJsPPeM7KojJe0HcWxwDQbVxDUBlzEoMirzcLISMWj34GnEnwDV76YAQeg7L+QSUrLTqJvBlgHEXGt2BJjpRwE3/YAmtVbTepSOWimCmL5lcJ+Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <9029ba87-632e-5061-521f-fb3fdcb6724f@suse.com>
Date: Fri, 18 Feb 2022 10:23:08 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH RESEND v2] x86: introduce ioremap_wc()
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
References: <8f56a8f4-0482-932f-96a9-c791bebb4610@suse.com>
 <c56aadc8-e568-4625-5d6f-bd2b8981f3ae@suse.com>
 <Yg5gGenFpAwZqtSW@Air-de-Roger>
 <34dac738-0631-f80c-a3db-7367e37ec0b9@suse.com>
 <Yg5urE+rpOQGWiH9@Air-de-Roger>
 <6f343b71-80f7-1aca-3be1-58239ba81dff@suse.com>
 <Yg9iQq7AEnDirafd@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Yg9iQq7AEnDirafd@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR05CA0014.eurprd05.prod.outlook.com
 (2603:10a6:20b:488::33) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a2b724c8-3b25-48d6-7547-08d9f2c047c7
X-MS-TrafficTypeDiagnostic: AM9PR04MB8969:EE_
X-Microsoft-Antispam-PRVS:
	<AM9PR04MB8969B9397B00D146ACF9C182B3379@AM9PR04MB8969.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	GKysKR6BGU9KL3b4gPqSOcTF7wxtSgCeppaR8WDntitjjK1NyZRo+GdpT22UKWTODpVFiYALHOSnb1h6q8bVstSSsyY/ejVDrSeuYN/l7VedBqZF0G1jy8sgS1OnXeo55VcrPcZfEdGMX6VtZowBHTLgKHZvBJAvW0WwIzMqzMqZBCb8lwEmGZX/++YGwddsNrS6C+0q0fyjXJaFxtnrZuWG/UZSa/4GLLrdD/KvpQ57FCLFDZvJsz15TeOQola3UxAYeh9CzHuoUHo3k9+9YuEPu2b5Db5nXoF17s7oV/RgptGtk0MViFPWefSxbwIvkn6KeNQ7UDwt9navErkrnRc6RMXfZ+RR16hBsJcey+MjJDihA5QbtzjffmQux5bCugxQaClyLVhNugM+5UR53AxZUAb55GgoPh6nLcjF3KAGPXkoDotN9/yiPrazP0vfu7XBJ5U3q+ticBlhxgHdp2de+0ZJnE2pvbzY0qaqsvyDya+Royw6mgtLso0Bl82qtz3c5Y/552G59FJJiAcJGoeAgfdJbuSuhuptvVxaWgLArqshMMp5uH9smXaYM8x9UXaXBZ3Rol013s06+9W+AqwVJm1dakbz3aeAb7JiMK/swvkJqZBPtsci6AUeAxOEFk1iEPJsVOE+a9q2KWwGlKZiw67y8IKP1spG5w/v7zzHDySDjFbGVjJTeDwSAvBY/XChHJutsMZCZkYEM59Yp38M0emkQ5obGH9lpXIdo5zA59w0HzkW6Y/xFHmKa+Cd
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(36756003)(31686004)(31696002)(83380400001)(2906002)(8936002)(186003)(6512007)(38100700002)(5660300002)(2616005)(26005)(508600001)(86362001)(53546011)(6486002)(316002)(6506007)(8676002)(4326008)(6916009)(66946007)(66476007)(66556008)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?Xp4iPNeDBPpNpmAgV9KeYTIGnPBzTCI/tCjodeTdP8Cw0UCxyUzbsA4It5qd?=
 =?us-ascii?Q?AWBSMPqjZRHoZ/F/GvbiQhleck9BQJhzR5sA+9HRmoSZrGWmR+9zf4mKNupK?=
 =?us-ascii?Q?E7eT8OAzbWrFE12pXpMJ8YKjtPZgy18YCztzfueObupy9UOjVdLNz6xWlM3U?=
 =?us-ascii?Q?KHFF6H9oQyOECk7UgtKl2gUL1vMlEqWC5nQDsoEdw8I7jP569paqcJNZPcqI?=
 =?us-ascii?Q?UC4TDAEz/xMfoDeK7nnCrl4M1q0xYh/bR2BHGvucqIJL+Pcl0TFie/niM1zr?=
 =?us-ascii?Q?baN7CKl7knjUmdFV/u8XX9Jc81QlpriMrwmfSLJwXe+HUN8oh7i70P/Bvrg7?=
 =?us-ascii?Q?IXrIumbAUa8HGBG16ZGmC+p91aYhnvihXsYoXnkrA3/Ns01GTpm8HCCsCpui?=
 =?us-ascii?Q?IE4CVXUY1/mkua0UJWoTPjFgQhmGGTD5kRgcDQri0/cdPfarfhFVfnZRW6x/?=
 =?us-ascii?Q?x8aARy7nRm5reZb0FXCZyZI+mZuA6regi8/Hnepm5SPI72Nxg5VvCoYGgfmF?=
 =?us-ascii?Q?p3gOewYf8IZpRoJY4tHRW3l4Q9DzCRvyk+S8ctWJgjZ+bVqLyato3aLM1Rma?=
 =?us-ascii?Q?cxAYJFyLej5XpfHePeJadoexyLlsO43FGLdsj5bU1O1LuT+2/QIlGtnMHaDY?=
 =?us-ascii?Q?YGIz5HQjIY6GzpPli+0p1U6h06Aw9Im5+/qN5p6NYcS1sXjN1TRJChu5vmJW?=
 =?us-ascii?Q?QelYQRT9vJ326ZakcxZS1UHx2AYair9A/jaEBBvFal3d/42FibkkLWTj7jtV?=
 =?us-ascii?Q?Dzafrqzc8J0OnvXz+6mECy8/QIrjPZ1VS/rS380Pi1bo1x63VY07m5cAPTgD?=
 =?us-ascii?Q?apz1loYwanW/ExL/PD8RampKikM/nAzy3vvE2iH2rl6CDSf5pOoalDw6RnbR?=
 =?us-ascii?Q?Ycp0IWqPLhSgf72A6OoDr/M5VdEQQT0LtQK5x5WWDiQf0eerTncJBHL2LjSw?=
 =?us-ascii?Q?aZbzKvzK2p57nW6QHOPNbOSBU/08crZWQj2JC/bKusvwmS4uCV/ACF8WgNNW?=
 =?us-ascii?Q?jYbJbb0sEJFV+ncQXWLF7C6oykNqBFN0cvBpZ5qdQJ6xEqsaWC/yxsDnBFq6?=
 =?us-ascii?Q?QQHqYKtF6d6KtJ1X49k37Yj4IWwQWueR+R9db1fN4/DkPk+ZSc19T7ZtgNSj?=
 =?us-ascii?Q?C5Wd6THAnoKvlEx4IQ0bovQSdI//Dw7Qx8ijoF/UEq9JMpqWjEAKKas2rFe5?=
 =?us-ascii?Q?iHMy5E+Sax7C5NMp3bUaiCLYSxEu5JZYdJCoycMayeYdR5md9487q+Y+cULj?=
 =?us-ascii?Q?ggWM1E1IYyHuYrcnY0t2N1gAHbLELlP/opnnc0T1/cY3mkcQlbPaFbPBzdmR?=
 =?us-ascii?Q?8UxdodXP0F6FH7AxqEkqmm2jHrV8Uuie3XWBKTNWDxgWyiY6ke6TrYjEIeon?=
 =?us-ascii?Q?x2fPNVsonaBolGfxhi5JXQbES6sBmvXDihDci2A+NQeWy47PQf2XohKfg004?=
 =?us-ascii?Q?9Dl/v3hmNORKoLqACbTRbaGdwR+BrNK/ReNb/LxQDICyWx6czScoABYipRTS?=
 =?us-ascii?Q?rLoPqTVOhwU4BsjBsKpMjDhKhcuLuqJYjHg/BRA3eKARsgz37uy0EH3UYfg5?=
 =?us-ascii?Q?Uh2WNvLmjSMOV/D03bD4D+Nn9LiE7G0f2j7SZmQ87H08xb9mwffVn7RYIzQ8?=
 =?us-ascii?Q?BfbcVBJvIxcGDRoFvEDdFUI=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a2b724c8-3b25-48d6-7547-08d9f2c047c7
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Feb 2022 09:23:10.6844
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 44TbRIDM49ARo3IArEg0VmUx3X7t6b/0IM0V6sPWeaY+mD3szq0LUN88UAFwu0QM28vcJ9ML5hm4m2vgjXxj9g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8969

On 18.02.2022 10:09, Roger Pau Monn=C3=A9 wrote:
> On Thu, Feb 17, 2022 at 04:57:41PM +0100, Jan Beulich wrote:
>> On 17.02.2022 16:50, Roger Pau Monn=C3=A9 wrote:
>>> On Thu, Feb 17, 2022 at 04:02:39PM +0100, Jan Beulich wrote:
>>>> On 17.02.2022 15:47, Roger Pau Monn=C3=A9 wrote:
>>>>> On Thu, Feb 17, 2022 at 12:01:08PM +0100, Jan Beulich wrote:
>>>>>> --- a/xen/drivers/video/vga.c
>>>>>> +++ b/xen/drivers/video/vga.c
>>>>>> @@ -79,7 +79,7 @@ void __init video_init(void)
>>>>>>      {
>>>>>>      case XEN_VGATYPE_TEXT_MODE_3:
>>>>>>          if ( page_is_ram_type(paddr_to_pfn(0xB8000), RAM_TYPE_CONVE=
NTIONAL) ||
>>>>>> -             ((video =3D ioremap(0xB8000, 0x8000)) =3D=3D NULL) )
>>>>>> +             ((video =3D ioremap_wc(0xB8000, 0x8000)) =3D=3D NULL) =
)
>>>>>>              return;
>>>>>>          outw(0x200a, 0x3d4); /* disable cursor */
>>>>>>          columns =3D vga_console_info.u.text_mode_3.columns;
>>>>>> @@ -164,7 +164,11 @@ void __init video_endboot(void)
>>>>>>      {
>>>>>>      case XEN_VGATYPE_TEXT_MODE_3:
>>>>>>          if ( !vgacon_keep )
>>>>>> +        {
>>>>>>              memset(video, 0, columns * lines * 2);
>>>>>> +            iounmap(video);
>>>>>> +            video =3D ZERO_BLOCK_PTR;
>>>>>> +        }
>>>>>>          break;
>>>>>>      case XEN_VGATYPE_VESA_LFB:
>>>>>>      case XEN_VGATYPE_EFI_LFB:
>>>>>
>>>>> I think in vesa_endboot you also need to iounmap the framebuffer
>>>>> iomem?
>>>>
>>>> Again part of the full series. I guess I was a little inconsistent
>>>> with leaving the VGA unmap in here, but breaking out the VESA part.
>>>> It's been a long time, but I guess I did so because the VESA part
>>>> needs to touch two files.
>>>
>>> I think you are hesitant to include the chunks for the above items? (or
>>> maybe I'm not properly accounting for their complexity).
>>
>> There's no complexity, it's really just that the zapping of the pointer
>> needs to be done in a different place from where the unmap is. See below=
.
>>
>> Jan
>>
>> video/vesa: unmap frame buffer when relinquishing console
>>
>> There's no point in keeping the VA space occupied when no further output
>> will occur.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>=20
> Reviewed-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>
>=20
> For both patches, the one inline here and "x86: introduce
> ioremap_wc()".

Thanks. Actually, while looking back at the original thread, to re-check
what pending objections there might have been, I did find the reason for
the split: In the patch here I would have introduced another leak, while
the other patch fixes an existing one.

> While at it, I think you should also push "video/vesa: drop
> "vesa-mtrr" command line option".

Yes, that one's merely dependent on the one here.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Feb 18 10:12:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 18 Feb 2022 10:12:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275283.471087 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL0FM-0002uP-1d; Fri, 18 Feb 2022 10:12:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275283.471087; Fri, 18 Feb 2022 10:12:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL0FL-0002uI-Tq; Fri, 18 Feb 2022 10:12:15 +0000
Received: by outflank-mailman (input) for mailman id 275283;
 Fri, 18 Feb 2022 10:12:14 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nL0FK-0002tu-Lx; Fri, 18 Feb 2022 10:12:14 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nL0FK-0006z4-Jh; Fri, 18 Feb 2022 10:12:14 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nL0FK-0007cQ-4v; Fri, 18 Feb 2022 10:12:14 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nL0FK-0004bP-4T; Fri, 18 Feb 2022 10:12:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=W9J7Wql/5W1Q9sLBGcJ9z9cftQfO3UwnKJjfjZFknNk=; b=xEERcdhdgE2rm92w6odQVlALSX
	cYneWuAtW/hEX0ZYBxMNDQG2z4ZkJToapZXM3GkiBItOp6JRJRDl4CNK9/X+e8Fq3phwno+evk0Ma
	/78hSkC2osrlQZ/wPf6I+CKAvKnW0+4cm5Qyurw52gxfQqRlW/vaKL68PfR4NWvYJigk=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168157-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 168157: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=4ec51e87804bd9aad0d0b8e5dadb987b54c5adeb
X-Osstest-Versions-That:
    xen=e7c2017cf4a91ab6a0fea6adca2d9dd2ab1603b0
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 18 Feb 2022 10:12:14 +0000

flight 168157 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168157/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168145
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168145
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168145
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168145
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail like 168145
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168145
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168145
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168145
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168145
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168145
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168145
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168145
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168145
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  4ec51e87804bd9aad0d0b8e5dadb987b54c5adeb
baseline version:
 xen                  e7c2017cf4a91ab6a0fea6adca2d9dd2ab1603b0

Last test of basis   168145  2022-02-17 01:54:29 Z    1 days
Testing same since   168157  2022-02-18 00:09:34 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Penny Zheng <penny.zheng@arm.com>
  Stefano Stabellini <sstabellini@kernel.org>
  Stefano Stabellini <stefano.stabellini@xilinx.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   e7c2017cf4..4ec51e8780  4ec51e87804bd9aad0d0b8e5dadb987b54c5adeb -> master


From xen-devel-bounces@lists.xenproject.org Fri Feb 18 10:17:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 18 Feb 2022 10:17:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275298.471110 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL0KZ-0003ke-QY; Fri, 18 Feb 2022 10:17:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275298.471110; Fri, 18 Feb 2022 10:17:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL0KZ-0003kX-ML; Fri, 18 Feb 2022 10:17:39 +0000
Received: by outflank-mailman (input) for mailman id 275298;
 Fri, 18 Feb 2022 10:17:38 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nL0KY-0003kR-8N
 for xen-devel@lists.xenproject.org; Fri, 18 Feb 2022 10:17:38 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nL0KW-00077N-5V; Fri, 18 Feb 2022 10:17:36 +0000
Received: from [54.239.6.187] (helo=[192.168.5.69])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nL0KV-0000Ex-V5; Fri, 18 Feb 2022 10:17:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=2ShuNqr5mAyxiQ7Lsz5GN1KJDBSZ8apPCs8GDRThhO0=; b=QS39UQ0+TUnUYgnu73Jegcn72o
	nMD5xFftB5p508MYWEDmnie9Ta5EwM4wMvV3SxpkwHKEaLpjOQYRHIRipUxNvLNxV9hDG5xdmcFyI
	5xBHV8ntq1Tbu5bzGQHFE9FqHlACtFo3Y1UrEZpnH9UvKdHX3bIS+hPnSknKBKvvwxsg=;
Message-ID: <15ada062-2ec5-d8ff-6bd7-5c580939accc@xen.org>
Date: Fri, 18 Feb 2022 10:17:33 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.1
Subject: Re: [RFC v2 6/8] tools/arm: Introduce force_assign_without_iommu
 option to xl.cfg
To: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Wei Liu <wl@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Nick Rosbrook <rosbrookn@ainfosec.com>,
 Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 Paul Durrant <paul@xen.org>
References: <cover.1644341635.git.oleksii_moisieiev@epam.com>
 <d333126d12f2281f8df92e66cfba1c9eb2425dca.1644341635.git.oleksii_moisieiev@epam.com>
 <ab6d8d13-30cf-d322-668e-f3f5aaa56824@xen.org>
 <20220218091632.GA1486420@EPUAKYIW015D>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220218091632.GA1486420@EPUAKYIW015D>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit



On 18/02/2022 09:16, Oleksii Moisieiev wrote:
> Hi Julien,

Hi Oleksii,

> On Thu, Feb 17, 2022 at 03:20:36PM +0000, Julien Grall wrote:
>>>        xlu_cfg_get_defbool(config, "xend_suspend_evtchn_compat",
>>> diff --git a/xen/common/domain.c b/xen/common/domain.c
>>> index 093bb4403f..f1f19bf711 100644
>>> --- a/xen/common/domain.c
>>> +++ b/xen/common/domain.c
>>> @@ -512,7 +512,7 @@ static int sanitise_domain_config(struct xen_domctl_createdomain *config)
>>>        if ( iommu )
>>>        {
>>> -        if ( config->iommu_opts & ~XEN_DOMCTL_IOMMU_no_sharept )
>>> +        if ( config->iommu_opts >> XEN_DOMCTL_IOMMU_MAX )
>>
>> XEN_DOMCTL_IOMMU_MAX will be defined as:
>>
>> (1U << _XEN_DOMCTL_IOMMU_force_iommu)
>>
>> This means the shift will do the wrong thing. However, AFAICT, this new
>> option will only be supported by Arm and likely only for platform device for
>> the time being.
> 
> Thanks, I will fix that.
> 
>>
>> That said, I am not convinced this flag should be per-domain in Xen.
>> Instead, I think it would be better to pass the flag via the device assign
>> domctl.
> 
> Do you mean that it's better to set this flag per device, not per
> domain? > This will require setting this flag for each device which should
> require either changing the dtdev format in dom.cfg or setting
> xen,force-assign-without-iommu in partial device-tree.
> 
> Both of those ways will complicate the configuration. As was mentioned
> before, we don't want to make domain configuration more complicated.
> What do you think about that?

We have two interfaces here:
   1) User -> tools
   2) tools -> Xen

We can chose different policy for each interface.

For the tools -> Xen interface, I think this should be per device 
(similar to XEN_DOMCTL_DEV_RDM_RELAXED).

For the User -> tools, I am open to discussion. One advantage with per 
device is the user explicitely vet each device. So it is harder to 
passthrough a device wrongly.

But I agree this also complicates the interface. What do other thinks?

>>
>>>            return -EOPNOTSUPP;
>>> @@ -542,7 +545,7 @@ int iommu_do_domctl(
>>>    #endif
>>>    #ifdef CONFIG_HAS_DEVICE_TREE
>>> -    if ( ret == -ENODEV )
>>> +    if ( ret == -ENOSYS )
>>
>> AFAICT, none of the code (including callee) before ret have been modified.
>> So why are you modifying the check here?
>>
> 
> Because this check will fail if we have CONFIG_HAS_DEVICE_TREE define,
> but do not have CONFIG_HAS_PCI and iommu_do_dt_domctl will not be
> called.

Below the implementation of iommu_do_domctl() on staging:

int iommu_do_domctl(
     struct xen_domctl *domctl, struct domain *d,
     XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl)
{
     int ret = -ENODEV;

     if ( !is_iommu_enabled(d) )
         return -EOPNOTSUPP;

#ifdef CONFIG_HAS_PCI
     ret = iommu_do_pci_domctl(domctl, d, u_domctl);
#endif

#ifdef CONFIG_HAS_DEVICE_TREE
     if ( ret == -ENODEV )
         ret = iommu_do_dt_domctl(domctl, d, u_domctl);
#endif

     return ret;
}

'ret' is initialized to -ENODEV. So for !CONFIG_HAS_PCI, then ret will 
not be changed. Therefore the current check is correct.

AFAICT, your patch is setting 'ret' so I don't expect any change here.

> Same thing if switch/case inside iommu_do_pci_domctl go to default and
> return -ENOSYS. This part looked strange for me. But I will definitely
> go through this part once again.
We use the same sub-op to assign/deassign a PCI and "DT" device. So we 
are not interested in -ENOSYS but -ENODEV that would be returned by the 
checks:

if ( domct->u.assign_device.dev != XEN_DOMCTL_DEV_PCI )

At the moment, there are no sub-op specific to "DT" device. So it is not 
necessary for us to check -ENOSYS yet.

I haven't looked at the rest of the series to see if we need it. But if 
we do, then I think the check should be extended in the patch that 
requires it.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Feb 18 12:01:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 18 Feb 2022 12:01:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275312.471132 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL1we-00060k-Sa; Fri, 18 Feb 2022 12:01:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275312.471132; Fri, 18 Feb 2022 12:01:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL1we-00060d-P1; Fri, 18 Feb 2022 12:01:04 +0000
Received: by outflank-mailman (input) for mailman id 275312;
 Fri, 18 Feb 2022 12:01:03 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=YtLv=TB=citrix.com=prvs=0411da6ea=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nL1wd-0005gu-AW
 for xen-devel@lists.xenproject.org; Fri, 18 Feb 2022 12:01:03 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7043625a-90b2-11ec-8723-dd0c611c5f35;
 Fri, 18 Feb 2022 13:01:02 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7043625a-90b2-11ec-8723-dd0c611c5f35
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645185662;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:content-transfer-encoding:mime-version;
  bh=3Ag96AKa6ckCXDTMAqCXlDOih2VxTNmBDm/9Ym2Fx4s=;
  b=TEYcBq7LQ/5WB5/0zDGIXZWaVLlLWX2344Q4vSdfzXVNgmzwtbMEJ0B6
   lAaOAxr56ZuNby7BCB0tZAEK5+Xr7iXnVm7/z0AYO3O4Udnt6UO24b6cM
   OWFnTgpmZUq5n8YXu+w+IWIr+Dr2xrWzHok2iyekA4PupcSa14zhtIdWW
   Y=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 64916530
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:enEo1q/aY5rDMJmZ62EyDrUDv36TJUtcMsCJ2f8bNWPcYEJGY0x3y
 DFMW2/UOPaPYWajfN0lOd7k9k0P7cOAydVqSQs9/iw8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si+Fa+Sn9T8mvU2xbuKU5NTsY0idfic5Dndx4f5fs7Rh2NQw24HpW1rlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCnY2KcggYJonIosQUCykGDQh1DKFp0bCSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFJkYtXx6iynQEN4tQIzZQrWM7thdtNs1rp4STK+AO
 pFBAdZpRCTjZh0XanImMr0Fs6CB2GjyYgxckV3A8MLb5ECMlVcsgdABKuH9YceWTM9YmkKZo
 GPu/GnjBBwectuFxlKt7XaEluLJ2yThV+o6FqC89/NsqE2ewCoUEhJ+fUu2p7y1h1CzX/pbK
 lcI4Ww+oK4q7kupQ9LhGRqirxasvBQRRt5RGO0S8xyWx+zf5APxO4QfZmcfMpp87pZwHGF0k
 A/S9z/0OdBxmKyvcn2s7pOQlxO7YRhLM0YJVCMrZARQtrEPv7oPph7IS99iFou8gdv0BSz8z
 li2kcQuu1kApZVVjvvmpDgrlxrp/8GUFVBtum07S0r4tlsRWWKzW2C/BbE3B95kJZ3RcFSOt
 WNsdyO2vLFXVsHleMBgrYww8FCVCxStbGy0bb1HRcBJG9GRF5iLJNE4DNZWfhoBDyr8UWW1C
 HI/QCsIjHOpAFOkbLVsf6W6ANkwwK7rGLzND66IM4MUPsAgKFHepkmCgHJ8OUi0wSDAdollZ
 P+mnTuEVy5GWcyLMhLtLwvi7VPb7n9nnj6CLXwK5x+mzaCfdBaopUQtazOzghQCxPrc+m39q
 o8HX+PTkkk3eLCuM0H/rN9IRXhXfCdTOHwDg5EOHgJ1ClE9Qz9J5j646e5JRrGJaIwPyL+Tp
 ynlAhUwJZiWrSSvFDhmo0tLMdvHdZ1+sWg6LWorO1Op0GIkeoGh8OEUcJ5fQFXt3LYLISJcJ
 xXdR/i9Pw==
IronPort-HdrOrdr: A9a23:YagHa66OGe94NEmmvwPXwBfXdLJyesId70hD6qkXc20wTiX4rb
 HKoB1/73XJYVkqN03I9ervBEDiewK/yXcW2+ks1N6ZNWGM1QeVxepZnOjfKlPbehHWx6plzq
 FnfLF5CNrsSXZHreuS2njfL/8QhOCd9qamnOHfyGooazpLReVP0ydVYzzrdXGfYmF9dOIE/V
 6nl7N6mwY=
X-IronPort-AV: E=Sophos;i="5.88,378,1635220800"; 
   d="scan'208";a="64916530"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=kSjEZo0CG061CYMyUv000bNswHK41SbUbsu04GJWKEtRqKwV4KKXHweuFBTY+EVg/nvzU7sUT0aKo2GaNVrcupd0mMTyDdMfvsszVWN9hliBCuq68eLGvMgUxQ3YHTjTcWKbLabeYzmumEJHMFtVczsP2ovRzdgjozZcu6PQCDcjsJxgk6EPuMzbA2OMpX/yafbzJM6iK/ozlMNVqiKBqaFcqDxdicPKQ7PiD04hk+qc+fPUU3CMLNBJ5PMI7niqZDM8jVpWfcJkkKfsnB5bWljjUoYQj2Rkd+Ais3BzaD1Hxj4YUhH9WnMItxT6mEGKgz6rLwkhLH7M8r5wuziRFA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=JVEEC7hGK2V16CSDkdSlQ4L0CqRHMYhugTfKIlrqonY=;
 b=XhlEE1EdYhvUtOknVQIWYYC80MF5zBYxBYNGYEyvYvQzhHWiUlBuJ3IhOsCAXVpsSws7e7xp/aB/dLXT9mrdfsDETlyat+PVxczqBTXNiZKx21v+YsWOqV5SygY+8/KVF12t85PTFJMKnTMYE0EXUm0MFK+dv7sbtiK95h2Q9SkyTEm6w/8cCTDLT9xrN44ULxVErKnW3RDUJqyPWox8Y2lt3GxrAiDunRHu4Hfx94TTCjhUA8jv/TPHCW6iDFONK+EBDir3nXADkO3MY9WWY7VQ8cqo1hF0ZinYgeHJOyEsVeWrN0fqWmVKExou0QmD7da0w4cGkEM3XbqIP2H4iw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=JVEEC7hGK2V16CSDkdSlQ4L0CqRHMYhugTfKIlrqonY=;
 b=p1I5HxPv7tn71SJ+hJ6/ioQl/KyN8W30dH5RDaDfyqiqQ8yN1dssaLxBFB2HjfjMvSqVQevAQDjxjXVCcs1cthKZNWVKO4FTwzbKsB8TseiJeO+HWGmotfunLelmB/BU5p48TPp3ZLr4BU8LlVbrDc670IkYaGai6YXI81hdZMA=
From: Roger Pau Monne <roger.pau@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Roger Pau Monne <roger.pau@citrix.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, "Jan
 Beulich" <jbeulich@suse.com>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Subject: [PATCH 1/2] github: add workflow to run Coverity scans
Date: Fri, 18 Feb 2022 13:00:41 +0100
Message-ID: <20220218120042.32102-2-roger.pau@citrix.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220218120042.32102-1-roger.pau@citrix.com>
References: <20220218120042.32102-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: MR2P264CA0185.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501::24)
 To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: fb09affa-e51e-4329-eb9a-08d9f2d6519f
X-MS-TrafficTypeDiagnostic: SJ0PR03MB5406:EE_
X-Microsoft-Antispam-PRVS: <SJ0PR03MB5406D81619BCB8A90DBFCE1C8F379@SJ0PR03MB5406.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: kdCpd2k5MLryhXGAty8WAnj1SomgnEWGl3dB2ctn+JP0GyqNI65htEunAVoTe/608v1oKd2CHLIOdZK0tyWu0CxJs2D3ZauHySfAbv1OpUNhqz1lx1hzr7V/yyaWeWLvB3hvwOErwZ6SokADi2Wmq+pfYMCeBiSvMS3a+QYRSpvru9ag5LjeRgrXB26FqxAOpSMwp/LKsBR2iBfJCqUQzIltV1UtYr9fbDzMUbCBWEhdGpVjmBhy/YfWuP+9O45QFVDvIjXkVPp6N3KYyzgYoCztHKyO+CVlGfoXyuo09VxUEeFreKafc6SZrjHGNRUCz0/AB6etBguU7q8ewoF4BS6uCDdzH5LR6Q9Nwi5bG2dtmW3NuTwKG2K1SkXZdbK7nhKGbvwpzKdTYWO0bWny1FDopXtJgXwZzVol3kTSvwfraRrjPTt5fMsUXJNVBn05TcmlTpafWTs8kkP+6WTwdzOtPTXBmTMSL2BAYtDGav7YcfEaLGi1/DUBR5O43nq83KZpuzNEQQ4uBDEmYSFjekff7eA1rvEbEfky8/Khr46EpHbMFvk/5aZE7Z4ZC9QOHxWgBhqfaiWeTxBuUTWx826wEZRAD6fJOXBd/mJf6OD8RlyWvZskzY0qRjDSKROHP1839gFExr28uBBuMgiIfA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(5660300002)(1076003)(2616005)(38100700002)(8936002)(66946007)(4326008)(83380400001)(8676002)(2906002)(66556008)(26005)(186003)(82960400001)(6666004)(86362001)(66476007)(6506007)(316002)(508600001)(6916009)(36756003)(54906003)(6486002)(6512007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?clIvVzB0M3l2elN2TVZPajlVT0Rpc00rR1NFYTFCT3d0d3ZhVkRkTDhqcUxV?=
 =?utf-8?B?S3ROVWhQTjN3Z2VvWjFKWlZpSWE0Tm1MRDFmZjZ0bzVFODFSWWE2YmRyeFBu?=
 =?utf-8?B?UWdqWUVrTEh6MEhHMjBTS1NvRHVjRGtSeGZtM2M4QURoWUtKTmJnWGpYRjlB?=
 =?utf-8?B?SnJOZTdVZ09xRmpYMmZUeE1pbjBLak44Z21MbUhncnNpN29xRDg5L0U4LzFt?=
 =?utf-8?B?UW5TN0R5Znl1WDRGWExmSDJlbWlER09JZ2F6R3NzeHdMenVwL0NTV0I1WEwv?=
 =?utf-8?B?Smd2clNhMWozS0hhTTdwTU1USjJHN3B5ak5yZFZEKzNWWUViV1lXeXlnNktM?=
 =?utf-8?B?RW5GdHFKN3RhRjNWbmVFWjAyeEdxcEtYMy9icGNNNEU5N0xOWDFkUFU0RlUr?=
 =?utf-8?B?TWF6VGhaZFVoM2cvNlAwL0FCemJQSGhjNjlNalBiV3JsY0hwbytIaVdqS3pt?=
 =?utf-8?B?dy9RNm05WWNlVUhSb2RGZDZXYW5KZW1rVlVRWlJnMmR5akd5ODRlK1U5NS9w?=
 =?utf-8?B?YWtENmF6K3ZPNkVNTFFpcGJXLzB0N3cwdEZSYXRYS0FTcnNROHFMSDIxb1ly?=
 =?utf-8?B?Q3lpYW1TangxRkRsM052bWJLYlI2V1JZRFBQRGJXb3BLcCtzVDFReVYvWnM3?=
 =?utf-8?B?aWpEL0xmYVVSSmZkdnRsMXd4aFJDQ3lCY1FjT2dVU29jMUZGRkFxLzQxZXhH?=
 =?utf-8?B?emplTThJQkpwOTRQL29pRDN5REVPWkVSdFRCV3BIbVBTMWs3cWJ3cWZZbC91?=
 =?utf-8?B?YUZIaVpJcUdGdDl4SkY0RllLbUt3K1BGUWNTNDBOdTQxd1U0RUk5eGp4VmJx?=
 =?utf-8?B?MHM0QlBsalJObHYvcjBrUnpFbVlDazNpbzFtR1Q5SW5sb1plcG9raWEwUlUr?=
 =?utf-8?B?Y092a3FLQ3crbngrbGdkZHZGVklrdXNWYWxOdFF2Y1M4VnJaejY5SWlJS0ZF?=
 =?utf-8?B?cFVrdS8zMkZiemdnWmk0Wkp3c3V6QWN2NXlaNC8yUDVIL3grOERqN1c5aWU1?=
 =?utf-8?B?MzVtNjZGNDM4blBZd3IzT1ZHY2kwbnc2SXFQVHhWV2JFazdoQVdpaC81amth?=
 =?utf-8?B?a3JxMjl6MkwvczFHSzF2Qm1oOWk5ZG1LTVVwUlpXUG9BMEVHT1UwNERwdkF5?=
 =?utf-8?B?WTA0V2ZwandtNUNEckl4ODF6YzhrV3o1ZmdIc3I0a0VTZ096MUNydlczeGkz?=
 =?utf-8?B?MVI0VG5EaUlXdHJvYVEzeTBidjlsbXRSbytkUXpFZnlFSlJ6b01vQ0RMQWdE?=
 =?utf-8?B?YUczNThtbHhCNjFCS2diSDRGQnpSL2dhZFBXOGtaMHY3Ri85bHF3cmdhRW1Z?=
 =?utf-8?B?NEtiMWpGRDhKZzdFN3ZIWENyOEZFL1NiUkdSMW1qRThEUnVXaC9XUGVER1Vr?=
 =?utf-8?B?UmZxMlNOOTNpeFZtWGZsUHZzU0UwZ1puSktpcGdsTytaOVlyQ2J0TlpvejlY?=
 =?utf-8?B?d2NZcWcxL1Q1dFVDUWNMaVd0YkNqdU1NNDBNbUdiN1BoZEx1SDgwVzgzeGQ5?=
 =?utf-8?B?QitCSmp5WWVPc0FZR0d5akJpdnpXTGc3MDRTRnBDSWxBc0I4ZERnTDhsUFVt?=
 =?utf-8?B?Z3JNRzQycDdoUmpXNHVtMUc5a09ja1EzZkpaM0FWQWoyWXlFeHJDK3Fmd0NG?=
 =?utf-8?B?dXIwQ0xScUxhM3lka0I4RGUzMkVNUnF1cWhBMG05aUxMcFV5SlJiR1NZN0xL?=
 =?utf-8?B?Zjl3TTdpSFE4QkEzVHd6dGM1Q0FmMk95NEp4dW9hTk1XSGw1RjcxMlBOQlEx?=
 =?utf-8?B?Q04zclp0TW51bTFWbUt5R0dZQk43aVZ5UXVNVEJsRlM3VXExeWZKcncxcHRz?=
 =?utf-8?B?ZlJkQXpUeHZnSyt3bkI3OUk5SEdHU1k0dG5JS3ZOTmZodHdQSi9UeklhQllw?=
 =?utf-8?B?dHJmRkYyMTIxb0M4WmJoK0NCY01XakhxN2UwdFZHSWVPR3hkSzVHSExjVUFD?=
 =?utf-8?B?VEVuSVB0M1cwczRTQW9kQy94WGlFU05raEppUTJnUUtyaytXa0VOamZocEVm?=
 =?utf-8?B?UDZYbDQxZlM0NThZODVsdk5XTW1LOVRqQ0ZhNGgvT051ZmF4TVBLM24zc2dH?=
 =?utf-8?B?MmRUa1ZRblNtVzdsYm5VU0xWZUVtZExOTml2SW5KSHlkRGoyditERGZqcThy?=
 =?utf-8?B?MnFxa3BVTXpKMGNpZVpLSzIrMU1FbEV3Y20wUDYyWm13VmJ6bzNiTFVyRWNO?=
 =?utf-8?Q?1/yv8XqQW+cgb+3bHilvXAM=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: fb09affa-e51e-4329-eb9a-08d9f2d6519f
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Feb 2022 12:00:55.7868
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: o1DfpJcYBrJ2k+uYnKmqDt7BvhNBB/W2ADqmRauCGCe5w7IGuNOyOp9xhPz5eT0enq5R+2MpgyY9OLZ1H3Hsxw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5406
X-OriginatorOrg: citrix.com

Add a workflow that performs a build like it's done by osstest
Coverity flight and uploads the result to Coverity for analysis. The
build process is exactly the same as the one currently used in
osstest, and it's also run at the same time (bi-weekly).

This has one big benefit over using osstest: we no longer have to care
about keeping the Coverity tools up to date in osstest.

Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
 .github/workflows/coverity.yml | 35 ++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)
 create mode 100644 .github/workflows/coverity.yml

diff --git a/.github/workflows/coverity.yml b/.github/workflows/coverity.yml
new file mode 100644
index 0000000000..12fc9c782b
--- /dev/null
+++ b/.github/workflows/coverity.yml
@@ -0,0 +1,35 @@
+name: Coverity Scan
+
+# We only want to test official release code, not every pull request.
+on:
+  schedule:
+    - cron: '18 9 * * WED,SUN' # Bi-weekly at 9:18 UTC
+
+jobs:
+  coverity:
+    runs-on: ubuntu-latest
+    steps:
+    - name: Install build dependencies
+      run: |
+        sudo apt-get install -y wget git bcc bin86 gawk bridge-utils \
+          iproute2 libcurl4-openssl-dev bzip2 libpci-dev build-essential \
+          make gcc libc6-dev libc6-dev-i386 linux-libc-dev zlib1g-dev \
+          libncurses5-dev patch libvncserver-dev libssl-dev libsdl-dev iasl \
+          libbz2-dev e2fslibs-dev git-core uuid-dev ocaml libx11-dev \
+          ocaml-findlib xz-utils gettext libyajl-dev libpixman-1-dev \
+          libaio-dev libfdt-dev cabextract libglib2.0-dev autoconf automake \
+          libtool libfuse-dev liblzma-dev ninja-build \
+          kpartx python3-dev python3-pip golang python-dev libsystemd-dev
+    - uses: actions/checkout@v2
+    - name: Configure Xen
+      run: |
+        ./configure
+    - name: Pre build stuff
+      run: |
+        make -C tools/firmware/etherboot all && make mini-os-dir
+    - uses: vapier/coverity-scan-action@v1
+      with:
+        command: make xen tools && make -C extras/mini-os/
+        project: XenProject
+        email: ${{ secrets.COVERITY_SCAN_EMAIL }}
+        token: ${{ secrets.COVERITY_SCAN_TOKEN }}
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Fri Feb 18 12:01:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 18 Feb 2022 12:01:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275313.471143 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL1wk-0006Jp-5D; Fri, 18 Feb 2022 12:01:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275313.471143; Fri, 18 Feb 2022 12:01:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL1wk-0006Je-1l; Fri, 18 Feb 2022 12:01:10 +0000
Received: by outflank-mailman (input) for mailman id 275313;
 Fri, 18 Feb 2022 12:01:09 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=YtLv=TB=citrix.com=prvs=0411da6ea=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nL1wj-0005gu-Fk
 for xen-devel@lists.xenproject.org; Fri, 18 Feb 2022 12:01:09 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 73f8fb1b-90b2-11ec-8723-dd0c611c5f35;
 Fri, 18 Feb 2022 13:01:08 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 73f8fb1b-90b2-11ec-8723-dd0c611c5f35
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645185668;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:content-transfer-encoding:mime-version;
  bh=GhD/MKCyt1tNObvGu7VW+kHZJjYgGOKLwY2vmd6FRxw=;
  b=HfHCDlN3MqFB8g2vl5nnxLGluoEjqVsAqvjbLLbUedyizKtlqnTe7L4m
   CsbiwshK0FpkPKBjAMERPiBMpFqXZ77uyOszKGxD3O7jhjvzLVf9PI6Fe
   lqU+xA9D7DTqcvYC6CVv+aCSCOtUGzc/ObRI55rhNKCeiggUMCDBVN72Q
   g=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 64510430
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:0GJR+6sOUb/GInm4f1dxsXMDZOfnVGleMUV32f8akzHdYApBsoF/q
 tZmKWyEaPaOMTPwedl/bYix9BkA7ZOAnNJhQVc++CtjHiJG+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQzy4bVvqYy2YLjW1nU6
 YuryyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb
 /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo
 Oihu6BcRi8kJ6yQybQ4QyNVGiw5Bb8d2Jj6eXSG5Jn7I03uKxMAwt1rBUAye4YZ5vx2ESdF8
 vlwxDIlN07ZwbjsmfTiF7cq1p9LwMrDZevzvll6yj7UF7A+SI3rSKTW/95Imjw3g6iiGN6AO
 5dAMWY0NHwsZTUTOkhHEJ81jN32jyP7QyFT73yl9K0etj27IAtZj+G2bYu9lsaxbd5Ogk+Sq
 2bC/mL4KhIXLtqSzXyC6H3ErvDLtTP2XsQVDrLQ3vx3hFyewEQDBRtQUkG0ydGph0j7V99BJ
 kg8/is1sbN05EGtVsP6XRCzvDiDpBF0c9haHvA+6QqN4rHJ+AvfDW8BJgOtc/R/6pVwH2Zzk
 AbUwZW5XlSDrYF5V1qQ77bI/GOXKRIYJGJFXT1fbSw4u9Xa9dRbYg30cv5vF6u8j9vQED72w
 iyXoCVWu4j/nfLnxI3gowmZ3mvESozhC1dsu16JBj7NAhZROdb9D7FE/2Q3+hqpwGyxalCa9
 EYJlMGFhAzlJcHczXfdKAnh8VzA2hpkDNE+qQI+d3XC3270k5JGQWy2yGgvTKuOGpxZEQIFm
 GeJ5WtsCGZ7ZRNGl5NfbYOrENgNxqP9D9njXf28RoMQPsUoLlPfrX0wPBT4M4XRfK4EyPBX1
 XCzK5vEMJrnIf4/kGreqxk1itfHORzSNUuMHMumnnxLIJKVZWKPSKdtDbd9RrtR0U9wmy2Mq
 4w3H5LTk313CbSiCgGKod97BQ1bdhATWMGpw/G7g8bee2KK7kl6UKSPqV7gEqQ495loehDgp
 C/lARYAkAKl7ZAFQC3TAk1ehHrUdc8XhVowPDA2PEbu3H4mYI2167wYeYdxdr4inNGPB9YuJ
 xXZU61s2shydwk=
IronPort-HdrOrdr: A9a23:3oBo06Frx1TjikfapLqEN8eALOsnbusQ8zAXPidKOHhom62j5q
 WTdZEgvyMc5wx/ZJhNo7690cq7MBHhHPxOgbX5VI3KNGKK1FdAR7sSjrcKrQeAJwTOstdH06
 Fuaq5/D8C1I2RboK/BkW+FOudl+cKA9q+wg+fY0jNKdiFFL49dzyoRMHf9LqVRLDM2fabR0K
 Dsn/Z6mw==
X-IronPort-AV: E=Sophos;i="5.88,378,1635220800"; 
   d="scan'208";a="64510430"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=IEmItYhYh5pS7uF7dXvu1x3vk8HK4E+hQF8Bz86brfx08qVbyZaG0vI5pIqYZgWDNLH9R+jxSj158jkG0JbeEHDYd+CULzT8/DC4B8K53xXndxmSZLt8C8cagbY4uShiXwSrtq5Gj5f6XduJT3A5id0IvdE/vtQUlKXov1cBdMJtWOjvbQZ27c+TjqNUsnV6Jt5oEtqUVqMpTt5aZTWU4OGHnrWHKoXnmSJuwCw98ZfD9qur+A3x3EIFDk01gt1t/ac1gfXmtZQEGerGVEZ4xt5l41FyZjvsZMJQjFXVHcc5OYcflwebkVfIM/OoONmtBRJy+b59IGVtwq0lref7HQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=7VlOmKA4bVXwDcKvezRyv4XKMfbB325M9suR6eSlV7A=;
 b=OPalNfFbE4PkUJLJ5EHb4xwtdtBRukw0WVGDL6+eKOhb78Z62SmJMEEkW24XFHc5+5OBFyUyOE0k3fgM1dGqf4BodllHUWi1FP7FdQe1oEqHNNEfLU4xGFwa1xOrT7Sn3ufnlCQC1mvQztaKcRDinm/7S97s8RcEbsStQwgCCAcaeuMjjkWGHE76PN/vDlX1L0ESeGu+Pv1a30UNpPYe0O3lqwNXRAqz9u0IHm3F9stNpHTOkJ5OcwCeZRmcfxRY3k6icyhmJhWg0aPQ3VE3cpQNRP/3QhjEip5oyefpnj2nJyzgZcKnW/ylcw1gRAmAZ6G+6bDjTkPkV8XDcguNDA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=7VlOmKA4bVXwDcKvezRyv4XKMfbB325M9suR6eSlV7A=;
 b=QC+FSRjsODCfNXcKDt568cpiz0HpTRQ6iZXn+OLUi9bamcurGacHb4cSPwuyX4JmMFfq7P0ZfFL2vMTZ4/SqQZeFgy1tXh3wy8xJxsyFFV6C4mvVCdRpq4p5Al8Qire4IzvomBpqY5mm4laaw+YPZF/0iifN4o9XCr5mqUqcZnM=
From: Roger Pau Monne <roger.pau@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Roger Pau Monne <roger.pau@citrix.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, "Jan
 Beulich" <jbeulich@suse.com>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Subject: [PATCH 2/2] coverity: do not build QEMU, SeaBIOS or OVMF
Date: Fri, 18 Feb 2022 13:00:42 +0100
Message-ID: <20220218120042.32102-3-roger.pau@citrix.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220218120042.32102-1-roger.pau@citrix.com>
References: <20220218120042.32102-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: MR2P264CA0192.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501::31)
 To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b1176881-5aa4-4aa0-1718-08d9f2d654d9
X-MS-TrafficTypeDiagnostic: SJ0PR03MB5406:EE_
X-Microsoft-Antispam-PRVS: <SJ0PR03MB540633E4584E1D35516188848F379@SJ0PR03MB5406.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4502;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: hAYICApki7nit+XwgFJ3JMt3lqM56Um0qSGn5aDnPLopuceQzhcxn2AMp7V9UHEWgn5doZrPoKuNiN937MAklYQH2r/NDrYzPQjsfMBK63Z24MJCvoHOviC/uDwdzlHHcEIaF6BmWWPFruJHmbosXbOre4ztTylAUI1ga3Z0SUWzBZfl/krWhbiE1ILnOrJVGUAmsaS45st+caOUVd8JicxWFSC/LwryfNYBXO633uuYOYRu6mCfRhbmBk74D5YxaZlMYII7lKidgLTfmxHvbv6Jv9a2PvRv2W9bJahi1QenXidNftml+aeicLWlxMRon26C6ZSiEMY9yUA36ZdUrAMTTgmfwz7hovYx7HGGOqbuRWryhSg7yneU6h2Q82zJiZWDdEjnCD5sjJsTstshn63PfeLHVdWP/AZ+g0TTVvp/Zx2nwUdHzU1gL25yVo4P9tlrmO4LL3t50xMqjew5Ssgsd1sV+SrGsA26Yw61wTA6ux9fz5lOn4prjlLzzX+2UW9bq2WLWe6jz/COaGc6lqJsLIugoJ0z0cz+wDEEvwrPLeo0rLqH/DBS0NkICEt8jjLhog5l3Tvs6Atd7a7NwUvlwcelZGR0thdgdUrKjIfvolNlK7U2e1MvBC+1R5QB6KpzVhNGhgQhC1tj3oYRag==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(5660300002)(1076003)(2616005)(38100700002)(8936002)(66946007)(4326008)(83380400001)(8676002)(2906002)(66556008)(26005)(186003)(82960400001)(6666004)(86362001)(66476007)(6506007)(316002)(508600001)(6916009)(36756003)(54906003)(6486002)(6512007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UVdCY3NBRm1ORlJlbmdTbGRQRldwZnh2NnlHZ2x5RlBsN3oyZmUwTFV4bGNp?=
 =?utf-8?B?R1cyVUdWckgxM0JwUFhmZlVBUUJWczhXQUhUQzQxdncyeE5mYXl3d0FYbVhv?=
 =?utf-8?B?YWlTcXlUOE5RMURoWGlJamZWSlF6V282NytLTkx5OGpkczNBQjJKTVJxMXUr?=
 =?utf-8?B?ZS9LN20wNmVrSTJzTDRtd0pheitTVHI4SGVKWUkvR3FkMGZRWGRRa2ZrWHdl?=
 =?utf-8?B?R0cxSEwzdTdJVGE1MUE3MFpGN0RlblNoMGJPeDh0S2RycVBtaUUxNUNxclpT?=
 =?utf-8?B?WkdkSVJGSVpGTUNDdmtUMFFjWTV4S2I4TjlodTJLbGpkOUlRNzBaQ3F3bkdo?=
 =?utf-8?B?QVBqcEdidU16ZWczYVNOMGZ5cmdxS1BQUHBKRHRIK3MrNlVUNk1ocXh5bkYz?=
 =?utf-8?B?L3RKZGNnVkZlTnovQ3RMUGFQY0FCeEtNOTM2MzNiN1VPWnpOclB3Q2JLUjkr?=
 =?utf-8?B?MGVXQkpyM0ZVL0FHUEJZWDhaMkI2bSt4WEtSTTBDRndwUER6SmZjTUoxci9M?=
 =?utf-8?B?eS9HT3hLbmlNS2NPdG93V2t3a1RTem5SOUNrNWJZcW1ScXVmNnRRSkU4Sllt?=
 =?utf-8?B?TWxneW5RY1doSG5SYU1FVzJMYmtDdEJhQWlDa2tOb2hQdU8rbFF1Z2xaTUlx?=
 =?utf-8?B?Zy8yaHJoTmNUcmxtRnQvOFpSTWVBVGg1T25UWXM5QlNQOFV2MFJlVDR0OVVt?=
 =?utf-8?B?d0dMQ1VJNVkvYUI2dS9rTStPNDZNWmkrRGtUWmdzNTRIS3N0RFI2K0pxeVNJ?=
 =?utf-8?B?NW5nU09nOFBYbGpwYzJ4c2Exbmd1b01LZTNlZzBwRE1tN3dWSXdMM3ArcGha?=
 =?utf-8?B?dzQ2b2o1dVRPOVdxNDM1QmtPYUFsTExON1hzWW5MQW1rR0xVck1jTEZiZVlX?=
 =?utf-8?B?M0ljQW9ENiswQisxdnp3RUgvNXNMVjhLd1krZXJMdGlSSE1WaDBINjRNWnd1?=
 =?utf-8?B?WE94N2lSZWZVaXo2U1B5b1orQWZYK0RrakdHeHJlUWVZL0R4cXp2SjNQdG9K?=
 =?utf-8?B?SE14ai8rNjdZMFB4TExJd2E0WnJUVUpHS05HUzR3SXVJZzFjelJ0eHdOd0RE?=
 =?utf-8?B?bkVqUnFxNGlRVlppdUlwS1BRNittVFd0emw4a0t3ZVhzQlc5VVhJWDdqN245?=
 =?utf-8?B?N3pZblREd3ZTeFR3VktzSGhValdiSlZ4cGlsOTZMMEpGcVJNeXNCYzlFTEl2?=
 =?utf-8?B?Z0JrVk9CVnJFaHJwVFp0V1VnOEFzL0NUa29BWVlDaDFWbUFNdnZ6aG4xbzM2?=
 =?utf-8?B?bFNIdVRDMmdyK1Y2ZDNvY21NZ1ZGYklnbGs1NEgvTU15RU1lQnBmNlZCZXBp?=
 =?utf-8?B?d0ZBVkdlR1Y2RkZYbEVaVDFKdDZ3eHdBaGVGZjBTdGhtL2lqUVFXS1VxaDhI?=
 =?utf-8?B?TnFqSEdmUTN1NjVac3NTNzdoRVR5aGVTS1RrTGgyOCtxOVZ6VWx4YXpoVW83?=
 =?utf-8?B?MDdUbTMzR29memZvbHgvM0FNQS9CbkVFVVlPZ0VWUGpCMEdhU09JTzJwdG11?=
 =?utf-8?B?QlliM3pZbnN1TEc5ZkFWWVI2b0ZiQXYrSGoxa29STzFWdThPNkhKMGJFdWF0?=
 =?utf-8?B?WDVqeEFNT3F5RUZmenp5MTdRYW9rdTRZUUw4RnFMcnI0a2I5MDhPaGhBMGVP?=
 =?utf-8?B?U0twNE5xTFlDRU1IRXMwT3p6SHdxMGhZVjVwZGdGWGtkMTFwM1YveEp4eCs1?=
 =?utf-8?B?M0VvRE9SV0FIb01BbWdHTCtCMXlkK0xETEduaXZXVWZaZVNra1RYYVFZS2lq?=
 =?utf-8?B?bmlPWE1SMXI1d2M2NmhteHlETWVrOU4wYWxaSjZMR1huYXRNaHhsNlgvd0I1?=
 =?utf-8?B?cndFdkdCcDBSUWE4aVV5b3FkazJxdlhKV2dmWEpLcUF2UVloNlFuelJSWStN?=
 =?utf-8?B?cTREWXl5NDBtcTg3YWhGTVZDQ05odU5lOUZJZ3ZablNZYnk3SXNOdmoxZndx?=
 =?utf-8?B?YjlxTXdmRFJpeGc1d1piZ2gwcnVFcFJCOStKMFZoTkk2anB0YUZMc1Q4bnMw?=
 =?utf-8?B?TGdhSDhIdkVwZ29rbTBuZW1rM1B3dzlSaHA3L1FQc0FDWDdNRHNpa3gxRnVv?=
 =?utf-8?B?L21CMDg4bjY2SklBU2c5cTAzLzlLUmVDNlBxRWJoaVJhRW5wdk5IQk9mYzFa?=
 =?utf-8?B?dllIWGxXbk1mdU4vOVJIOUFSYzh5TmpnRXRZWm0rUi91OGFYZ2xGb3M0ek1W?=
 =?utf-8?Q?l4to8wLuVZJxAB5OLYwqDR4=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b1176881-5aa4-4aa0-1718-08d9f2d654d9
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Feb 2022 12:01:01.1946
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uMBfVaniPm4tmK+Zvkfoc6Q+Dw8PQ7gxNn7T57ZortE0aB70MdRIwXWNYZf9a6pzkVpAiP3tGSMiC5B1jeq4fw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5406
X-OriginatorOrg: citrix.com

Such external projects should have their own Coverity runs, and
there's not much point in also making them part of our scan (apart
from greatly increasing the amount of code scanned).

Trim the dependencies now that QEMU is not built.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
 .github/workflows/coverity.yml | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/.github/workflows/coverity.yml b/.github/workflows/coverity.yml
index 12fc9c782b..e8d33bf70a 100644
--- a/.github/workflows/coverity.yml
+++ b/.github/workflows/coverity.yml
@@ -11,22 +11,22 @@ jobs:
     steps:
     - name: Install build dependencies
       run: |
-        sudo apt-get install -y wget git bcc bin86 gawk bridge-utils \
-          iproute2 libcurl4-openssl-dev bzip2 libpci-dev build-essential \
-          make gcc libc6-dev libc6-dev-i386 linux-libc-dev zlib1g-dev \
-          libncurses5-dev patch libvncserver-dev libssl-dev libsdl-dev iasl \
-          libbz2-dev e2fslibs-dev git-core uuid-dev ocaml libx11-dev \
-          ocaml-findlib xz-utils gettext libyajl-dev libpixman-1-dev \
-          libaio-dev libfdt-dev cabextract libglib2.0-dev autoconf automake \
-          libtool libfuse-dev liblzma-dev ninja-build \
-          kpartx python3-dev python3-pip golang python-dev libsystemd-dev
+        sudo apt-get install -y wget git gawk bridge-utils \
+          iproute2 bzip2 build-essential \
+          make gcc zlib1g-dev libncurses5-dev patch iasl \
+          libbz2-dev e2fslibs-dev git-core uuid-dev ocaml \
+          ocaml-findlib xz-utils gettext libyajl-dev \
+          autoconf libtool liblzma-dev \
+          python3-dev python3-pip golang python-dev libsystemd-dev
     - uses: actions/checkout@v2
     - name: Configure Xen
       run: |
-        ./configure
+        ./configure --with-system-qemu=/bin/true \
+                    --with-system-seabios=/bin/true \
+                    --with-system-ovmf=/bin/true
     - name: Pre build stuff
       run: |
-        make -C tools/firmware/etherboot all && make mini-os-dir
+        make mini-os-dir
     - uses: vapier/coverity-scan-action@v1
       with:
         command: make xen tools && make -C extras/mini-os/
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Fri Feb 18 12:01:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 18 Feb 2022 12:01:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275310.471120 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL1wY-0005jf-KN; Fri, 18 Feb 2022 12:00:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275310.471120; Fri, 18 Feb 2022 12:00:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL1wY-0005jY-HG; Fri, 18 Feb 2022 12:00:58 +0000
Received: by outflank-mailman (input) for mailman id 275310;
 Fri, 18 Feb 2022 12:00:57 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=YtLv=TB=citrix.com=prvs=0411da6ea=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nL1wW-0005gu-RZ
 for xen-devel@lists.xenproject.org; Fri, 18 Feb 2022 12:00:57 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6be54d83-90b2-11ec-8723-dd0c611c5f35;
 Fri, 18 Feb 2022 13:00:55 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6be54d83-90b2-11ec-8723-dd0c611c5f35
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645185655;
  h=from:to:cc:subject:date:message-id:
   content-transfer-encoding:mime-version;
  bh=6M4waMGtjuKlBRZrPZQ40AQuX96BQYMLRzM3lGNwL4k=;
  b=FBrpn4rQ6FEUhCzAcezT2a0iTbySgBkVh8esL5nS3Yb6OUvA11LqlXZd
   SjQyz8MsRfyK7lABZDwYkwh5b6tfVP3yfb3qT6g+bIeTD5O95vjMJyU+I
   JSO7muASaYaSqO+yE0ykrImzuhDaaVQcIlXnEFFPCUR0kDVWKIMG7nuEp
   M=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 64407646
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:w9//FqjRNCwzLZ2a726QuMOPX161XxAKZh0ujC45NGQN5FlHY01je
 htvD22EafjZZzCgLtgnPtyy8BsGscTWy4dmHApqqHhnQiMb9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0Iz8wIFqtQw24LhWVrd4
 YqaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV
 efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9
 TlDiXC/YVp4L6zJwNgtbzNjSw9UP4tKw63MOlHq5KR/z2WeG5ft6/BnDUVwNowE4OdnR2pJ8
 JT0KhhUMErF3bjvhuvmFK883azPL+GyVG8bkmtnwjzDS+4vXLjIQrnQ5M8e1zA17ixLNaiCO
 5JGN2YxBPjGSwRwYXVJOI4+p+zr1mDiKzlHj0m1oYNitgA/yyQuieOwYbI5YOeiXt5Jl0yVo
 mbH+WXRARwAMtGbjz2f/RqEmevnjS79HoUIG9WQ9ONugVCV7nweDlsRT1TTiem0jAuyVsxSL
 2QQ+zEytu4i+UqzVN7/Uhak5nmesXY0WdBdDuk74wGl0bfP7kCSAW1sc9JaQIV47olsH2Vsj
 wLX2YOybdByjFGLYS/M57aR9Q+CBQIudUEoZwkIdhkO+PC29enfkSnzZtpkFae0iPj8Fjfx3
 y2GoUACulkDsSIY//7lpA6a2lpAsrCMF1dovVuPAgpJ+yskPNbNWmC+1bTMAR+sxq69R0LJg
 nULktP2AAsmXcDUz3zlrAng8diUCxe53N/03Q8H83oJrW3FF5ufkWZ4uWAWyKBBaJtsRNMRS
 BWP0T69HbcKVJdQUYd5YpiqF+MhxrX6GNLuW5j8N4QSP8ErKFfWoH83PyZ8OlwBdmB1wMnT3
 r/BLK6R4YsyU/w7nFJauc9GuVPU+szO7TyKHs2qp/hW+bGfeGSUWd843KimNYgEAFe/iFyNq
 b53bpLSoz0GCbGWSnSHoOY7cAFRRVBmVM+eliCiXrPaSuaQMDp6UKG5LHJIU9ENopm5Yc+So
 CnmAxcAkACXaL+uAVziV02PoYjHBP5XhXk6ITYtLRCv3X0iapyo96ARa908erxPyQCp5acco
 yUtEylYPslydw==
IronPort-HdrOrdr: A9a23:2jqeO6CN0DKSDUzlHehAsceALOsnbusQ8zAXPh9KJiC9I/b1qy
 nxppkmPH/P6Qr4WBkb6LS90c67MAnhHP9OkPIs1NKZMjUO11HYSr2KgbGSoQEIeBeOidK1t5
 0QCpSWYeeYZTMR7beY3ODRKadd/DDtytHOuQ6x9QYJcek8AJsQkjuRRzzrW3FedU1jP94UBZ
 Cc7s1Iq36JfmkWVN2yAj0gU/LYr9PGuZr6aVpebiRXozWmvHeN0vrXAhKY1hARX3dmxqojy3
 HMl0jc6r+4u/+25xfA3yv47ohQmvHm1txfbfb8wvQ9G3HJsEKFdY5hU7qNsHQcp/yu0k8jlJ
 32rxIpL61ImgfsV1DwhSGo9xjr0T4o5XOn40Sfm2HfrcvwQy9/I9ZdhKpCGyGpp3YIjZVZ6u
 ZmzmiZv51YAVfrhyLm/eXFUBlsiw6dvWciq+gOlHZSOLFuJYO5lbZvsn+9La1wXR4TsOscYa
 lT5YDnlbxrmGqhHj/kVjIF+q3uYpwxdi32N3Tq9PblkQS+p0oJvnfw8vZv7EvoxKhNNaWs2N
 60QpiA7Is+NvP+TZgNc9vpEvHHfFAkf3r3QRGvyBLcZeQ6B04=
X-IronPort-AV: E=Sophos;i="5.88,378,1635220800"; 
   d="scan'208";a="64407646"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=d/tSImZlsSiKcWBbtgUpqyiGUqb60IYZCOkjqUH/VBYzQ4OdqFkkwCZVLB0LJ+e8inrMmF1usLgieZ53crKk4pb1yvuxo6Hmfg7mcNZLGhoShH5yKd3LhcbPV9H8bjjIQFLDopY96JZqZpbQBIt56FV6JT2wyY3JqwxPT+9tROhSsRgTyJhJjdLF8rztvgsxDK4Z9QN3Ndert3KaUW5ZtCt4/eS2ukMNyAoUyhoD805W98pxYKlWqufcbHH+Ppqethg0scOmkFcpx0HSagcsFvOJ0BCXILFpkpACJfK9TnS1H2JG5n3lWQ3Wnlz8owwWGkhwkUVfd/w/hgyEW9lARg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=JJ9YZ1PV+13OCnW+hEH8zun3CBe3IS2HDQy5Vg/LRec=;
 b=GXkZ0k7wo9K9t6H61kjgqxVklovCkz/FprPcfdqO9S5+wy8/asWrKO61cHr+rw8GJSCPHKbj3bsyaJClme+j1rBB7v1YJ+ULw/L1B0Sz3ddS/Oinv/dz0UlhHsZgQLFW9GVOZ6ozfT79kuyrKzW7woZs+hIP6nppMwXedsSQHIWwvpFQdLb4HO0HKcDkp2Qb4yOrKpbePAnEvIxtSYiD8fUEnsTg4loqz+G7Ch5mULnv1fu9b5YkvnEURk1/dWP20eHKmWGMEalkzUkj4OLK5kMjD1iIR2tUyyU9eWRH98oZQJRrdS5yqsepWzxMnRGIjpEj7Iq0kO2eNPMgI4xDoA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=JJ9YZ1PV+13OCnW+hEH8zun3CBe3IS2HDQy5Vg/LRec=;
 b=YISgw0IPDrIe0YQEKriBNnejrvmjhuZNt/QRqDkDJJ21W/N6NTRZfrgJDBlvKEjKw3Jio9IoKhd3qA3bfDwtEko1NAoCGESiVFg8FF4Wdox4n97utAWAG18Shs1oQufTsi47kTQkvLtbhCgOQj1hnj1dvZKYfCVrTKF/I5atzKg=
From: Roger Pau Monne <roger.pau@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Roger Pau Monne <roger.pau@citrix.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, Jan
 Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>, Stefano
 Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Subject: [PATCH 0/2] coverity: trigger scan as a github action
Date: Fri, 18 Feb 2022 13:00:40 +0100
Message-ID: <20220218120042.32102-1-roger.pau@citrix.com>
X-Mailer: git-send-email 2.34.1
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: MR2P264CA0186.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501::25)
 To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: bd66d0b5-eefa-4fcf-a0f7-08d9f2d64e15
X-MS-TrafficTypeDiagnostic: SJ0PR03MB5406:EE_
X-Microsoft-Antispam-PRVS: <SJ0PR03MB540654E16C7B483BB76DC6288F379@SJ0PR03MB5406.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 10YQad4fCpoQu13bZqF5EFA8XxKBtORFTdRdbyBS32sLkZL1FiTR56o4lojjhHEtI1rxedxhMW4KHuuKKwv4UcnWBGtI4b2NTzi1pQSXqN78k6iQq1TsHyYXwHQ21pjrMG5RMmAvgVYCb2USRNlomhUF3M9IKkTWYYx4LUOhoZsotHbutcIm5KGRUnl25d5FPLEJ6P5hAeEmYbll9F5H9un5PiSOkd8ZkD8Xskr9fR8aVmADu77chJtr/oo2NgpW5AUziShi4eeoE8bAoW2Zqwew2/xiCC7IkXj2lmA16q84tEa49OgRIga7B48PiP1eT5fc/RBzHL6dPUTtH65uUCZUeGdgzrStOKgpvf+igexksgc6Q3LVdYs4EcRbpKpW6jNFeOdu8Flzys3Wfmi2s9NW+BmVoMI4Nossj3BqbBiWc+ivCWDio6DLxrEan0wKfwRRrleURmFMClGj/acEMz3/I66vDDslC+GMrPjsbIaMF/XNs9zbvyRnhwC/OyVunmgyh5ucB8DvrUECHTkw1upLU7ufVI0G6q1Uouhbw0GlCcbYzFN21Zs+Ud3dsbv5MIJqKJ9UMPdbIIwhq3pIfgSxvTnkdKQ4DcQr0q420Rk/sjiIj47Jmiz2BMWNYGunWvRsweAUUrMF6rUoDb0VPg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(5660300002)(1076003)(2616005)(38100700002)(8936002)(66946007)(4326008)(8676002)(2906002)(66556008)(26005)(186003)(82960400001)(6666004)(86362001)(66476007)(6506007)(316002)(508600001)(6916009)(36756003)(54906003)(6486002)(4744005)(6512007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OGtQTk5NQnZkUldhOFQxb1lFRjB6OW5YTFd6U2dId3VpUkNCbEtMZ083Q2dF?=
 =?utf-8?B?anJEVzNEYlFTY1NKTFg1NC9FZ3BUVnVlZEwyY3JhYmtmbm1xTnQxTDU5bXhP?=
 =?utf-8?B?THQ2MEtLNnN6WVZRKzl6NmJCTC95RmVJQm9HMFJ2VUVIRXA1VC94eU9CRkJ1?=
 =?utf-8?B?a0FlbVNwcVpSSnZ3c3QzemwyS0dBUVRKRE9JdEtvWmY3MzZFU3ExcmhHWWVv?=
 =?utf-8?B?NGQySVRUQllBd1VBWXZkTE9rNDhQS2M0VW5lek5mdVpibGNUM0ZKQXM3NnVW?=
 =?utf-8?B?K0p2Um5FV1lFMk1zZkRrdmxJQnhmc3h5YXlVUUxldm14QVpRRnRURUl4N1cx?=
 =?utf-8?B?alVpN0hjQXFrSU9RNThvdkU5ZDBwem9uS3EvNEUyWVRpRTNSNlBEVGJieTZo?=
 =?utf-8?B?RXhEREM1cm44aWpNU2NLRm5POXNJakErQmhvQ3dueWtsYzBiU1V0aXl3djlV?=
 =?utf-8?B?ZTFqZ1U0bGVJaTU2WmovUURnUnp0TFNlKzNCcEZhZHcvaGhvYmhOZ2JUNE9R?=
 =?utf-8?B?Mkt6VHVhY0Y5L3ozMlFlWnI4K3Z0VklYSGJqMW5PK0o4VWVxRjN1UUFBajVD?=
 =?utf-8?B?aWtQUzV1MEtJQ3ZzeElRV014ZXBTVFBHaEpKRlhoak1NeHdTYXhKSlp1N1lM?=
 =?utf-8?B?Wm43RHNRNENkU3lqU0NBUVE4TW1URDN6VnBjclFHenVDWVgxQmZxdWhKMkVk?=
 =?utf-8?B?cXArSldxNElnM0JQTmpwak44dlVLbGRiOGVQTnptdXhkeVcwVE1lNDdGYzJp?=
 =?utf-8?B?Y0Jrb2dhQ1lmMGJSU2ZmK3E4SGNZcG5KdjJMSkZUNlRzWmFuTkVqQzdnbW5B?=
 =?utf-8?B?UE1wME11KzhnK3RBZXJORGNNa3J2dVMxdGZQbXNPYkVqOWFJblNyWW1JcW5P?=
 =?utf-8?B?Y1UxdFR2QncvYVdrOE9CaXdUNEYxNDhNQ0VNSkZNOUszcHA0S2Q3L2VjbUJL?=
 =?utf-8?B?Q0ljbHFRYW4wamhmUVduYitTL2hTRnlpWno3RUJNOWFBWHIxLzJXWU1BNEdq?=
 =?utf-8?B?cERidDhHNFNBUWpMWk4vZ1pkWEx4QklaUkRnN3NFRG1tTFJhczRmMkU2NWlO?=
 =?utf-8?B?NlNnWktrWTdqMnpPbzcySzZLaFZ3d3QzeXV5ekdKQlAxaDVxZDZPMmdKVFFp?=
 =?utf-8?B?OGRkNHRrazcvbTRNM29VYzFudlgvUUxEd01Qd2E2NmlxWXE1V0liTThUem82?=
 =?utf-8?B?SlFGdWkwclZpT1hnRER2R2RMMWE4WTZmaU5aUW1yL292TW5FdnoxMzdGM0ly?=
 =?utf-8?B?OWoxV21ITjJreVdOZjNLM0w3dzlRQmNFME01K3hranVLSHJvRkdMbEdOeVhj?=
 =?utf-8?B?WUJxK1B4VU5RZk1wTjhKMmVQUUlzcThlNzh0dHZNV09CV3dHL1Y4d2V5SUh2?=
 =?utf-8?B?OU53eFNQbnliOEhpTUtTdjRibmdtNDBCZEI5OUJXbzY0d0ZjM1JHeTNNSFJu?=
 =?utf-8?B?bDhFTzRROEI4ejlOeEtZbHp0bWJOMzVidmg3WFVaYzdNOHRpWC9KekhoUUhQ?=
 =?utf-8?B?emY5RTZwZVVkREQxYm8xTngyMTMraUFQZ09WN1ZUSW1oUHJFUGU1WjlQOWN0?=
 =?utf-8?B?UUh5NXNValVOb0dzeFlVVC9GK1UxSGs4SFF6VHhoQ3JiZzdYM1poamhpSm9P?=
 =?utf-8?B?NjQ2ckplZzArVSt2NnBXeDdmRHcwL05CN3V2RnllOVluN2F6SjQxSVpnWHEx?=
 =?utf-8?B?ZDdoTG93OGpEcUNGWVpESU41UlFYVzRuTUxxUlRGVVNmd2JuT01LNWFvMXRP?=
 =?utf-8?B?YU9iN3RnbGFia3J0aUF1WXA3TC9nK25Sek5LbVVuQW9XZzNVdGZYQ1EvTHJU?=
 =?utf-8?B?TVU0NzBBaVVZUmdmMDZrRWNWQWo1aXpaMm1qbGZFdUcrZTZQcGFnSUJ0Wm5w?=
 =?utf-8?B?M3lyeUhDRDVEVTA5ZWhJbFROcDJIQVR0d0NDSWg1dHlkN3RrbHJQa0FmUjVY?=
 =?utf-8?B?Wk45MStxb2xYRmx2RTRYZWliaEhrcVhsb21LWVBleEVsQkxvaXpJWGJTY3BF?=
 =?utf-8?B?NldTZlpqSm55NWZOejZrckRhcUtobnFIeWhCWmp1MGVIZTdEc2hOMTR5dEpC?=
 =?utf-8?B?K0VleFExejhDY1RybkJhb1hsZDh4T28yVUFwNGN6ckRseTNLZDlZZlF6UFZX?=
 =?utf-8?B?U2wrRjFzRXo3andLaFRzNzN4U2VKVnNiUVJlS3lUcjBFRS9GWmN6RUkwLzNF?=
 =?utf-8?Q?6pVLtQ1bHP/EpxIcJUM3Oro=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: bd66d0b5-eefa-4fcf-a0f7-08d9f2d64e15
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Feb 2022 12:00:49.7692
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dTm9H0L0MzRxViRvMS5lIbK+TV8McIY36/P+GQAXyC3LMWQhaCdQEgkJAzoGl8ihsZyt+OKFA1sRLc11tkf6ug==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5406
X-OriginatorOrg: citrix.com

Hello,

Following series introduces a github workflow to trigger a Coverity
Scan. First patch attempts to move the logic currently in osstest into a
github action mostly as-is (same build targets).

Second patch removes the build of QEMU, SeaBIOS and OVMF from the
Coverity Scan.

Thanks, Roger.

Roger Pau Monne (2):
  github: add workflow to run Coverity scans
  coverity: do not build QEMU, SeaBIOS or OVMF

 .github/workflows/coverity.yml | 35 ++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)
 create mode 100644 .github/workflows/coverity.yml

-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Fri Feb 18 12:21:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 18 Feb 2022 12:21:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275334.471153 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL2Gc-0000ud-Ut; Fri, 18 Feb 2022 12:21:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275334.471153; Fri, 18 Feb 2022 12:21:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL2Gc-0000uW-Rq; Fri, 18 Feb 2022 12:21:42 +0000
Received: by outflank-mailman (input) for mailman id 275334;
 Fri, 18 Feb 2022 12:21:42 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=N23X=TB=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1nL2Gb-0000uQ-W7
 for xen-devel@lists.xenproject.org; Fri, 18 Feb 2022 12:21:41 +0000
Received: from ppsw-31.csi.cam.ac.uk (ppsw-31.csi.cam.ac.uk [131.111.8.131])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 531c6325-90b5-11ec-8723-dd0c611c5f35;
 Fri, 18 Feb 2022 13:21:40 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:57012)
 by ppsw-31.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.137]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1nL2GV-000XsY-KX (Exim 4.95) (return-path <amc96@srcf.net>);
 Fri, 18 Feb 2022 12:21:35 +0000
Received: from [192.168.1.10] (host-92-12-45-187.as13285.net [92.12.45.187])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 1EB011FDB0;
 Fri, 18 Feb 2022 12:21:35 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 531c6325-90b5-11ec-8723-dd0c611c5f35
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <0eeb8f5f-d049-8a8e-9e65-d1966c21a781@srcf.net>
Date: Fri, 18 Feb 2022 12:21:34 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Content-Language: en-GB
To: Roger Pau Monne <roger.pau@citrix.com>, xen-devel@lists.xenproject.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>
References: <20220218120042.32102-1-roger.pau@citrix.com>
 <20220218120042.32102-2-roger.pau@citrix.com>
From: Andrew Cooper <amc96@srcf.net>
Subject: Re: [PATCH 1/2] github: add workflow to run Coverity scans
In-Reply-To: <20220218120042.32102-2-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 18/02/2022 12:00, Roger Pau Monne wrote:
> Add a workflow that performs a build like it's done by osstest
> Coverity flight and uploads the result to Coverity for analysis. The
> build process is exactly the same as the one currently used in
> osstest, and it's also run at the same time (bi-weekly).
>
> This has one big benefit over using osstest: we no longer have to care
> about keeping the Coverity tools up to date in osstest.
>
> Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> ---
>  .github/workflows/coverity.yml | 35 ++++++++++++++++++++++++++++++++++
>  1 file changed, 35 insertions(+)
>  create mode 100644 .github/workflows/coverity.yml
>
> diff --git a/.github/workflows/coverity.yml b/.github/workflows/coverity.yml
> new file mode 100644
> index 0000000000..12fc9c782b
> --- /dev/null
> +++ b/.github/workflows/coverity.yml
> @@ -0,0 +1,35 @@
> +name: Coverity Scan
> +
> +# We only want to test official release code, not every pull request.
> +on:
> +  schedule:
> +    - cron: '18 9 * * WED,SUN' # Bi-weekly at 9:18 UTC
> +
> +jobs:
> +  coverity:
> +    runs-on: ubuntu-latest
> +    steps:
> +    - name: Install build dependencies
> +      run: |
> +        sudo apt-get install -y wget git bcc bin86 gawk bridge-utils \
> +          iproute2 libcurl4-openssl-dev bzip2 libpci-dev build-essential \
> +          make gcc libc6-dev libc6-dev-i386 linux-libc-dev zlib1g-dev \
> +          libncurses5-dev patch libvncserver-dev libssl-dev libsdl-dev iasl \
> +          libbz2-dev e2fslibs-dev git-core uuid-dev ocaml libx11-dev \
> +          ocaml-findlib xz-utils gettext libyajl-dev libpixman-1-dev \
> +          libaio-dev libfdt-dev cabextract libglib2.0-dev autoconf automake \
> +          libtool libfuse-dev liblzma-dev ninja-build \
> +          kpartx python3-dev python3-pip golang python-dev libsystemd-dev

We dropped gettext as a dependency a few releases ago, and we don't need
python3-pip either.  Can fix on commit.

> +    - uses: actions/checkout@v2

I think we want

- uses: actions/checkout@v2
  with:
    ref: staging

Can also fix on commit.

Acked-by: Andrew Cooper <andrew.cooper3@citrix.com> (mainly because I
can see that Coverity has done the right thing with this.)

> +    - name: Configure Xen
> +      run: |
> +        ./configure
> +    - name: Pre build stuff
> +      run: |
> +        make -C tools/firmware/etherboot all && make mini-os-dir
> +    - uses: vapier/coverity-scan-action@v1
> +      with:
> +        command: make xen tools && make -C extras/mini-os/
> +        project: XenProject
> +        email: ${{ secrets.COVERITY_SCAN_EMAIL }}
> +        token: ${{ secrets.COVERITY_SCAN_TOKEN }}



From xen-devel-bounces@lists.xenproject.org Fri Feb 18 12:23:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 18 Feb 2022 12:23:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275340.471164 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL2Ht-0001Tl-9Q; Fri, 18 Feb 2022 12:23:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275340.471164; Fri, 18 Feb 2022 12:23:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL2Ht-0001Te-6a; Fri, 18 Feb 2022 12:23:01 +0000
Received: by outflank-mailman (input) for mailman id 275340;
 Fri, 18 Feb 2022 12:22:59 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=N23X=TB=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1nL2Hr-0001TS-8B
 for xen-devel@lists.xenproject.org; Fri, 18 Feb 2022 12:22:59 +0000
Received: from ppsw-30.csi.cam.ac.uk (ppsw-30.csi.cam.ac.uk [131.111.8.130])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 81c8a641-90b5-11ec-8eb8-a37418f5ba1a;
 Fri, 18 Feb 2022 13:22:58 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:57546)
 by ppsw-30.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.136]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1nL2Hm-000v0m-eD (Exim 4.95) (return-path <amc96@srcf.net>);
 Fri, 18 Feb 2022 12:22:54 +0000
Received: from [192.168.1.10] (host-92-12-45-187.as13285.net [92.12.45.187])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 42D871FDB0;
 Fri, 18 Feb 2022 12:22:54 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 81c8a641-90b5-11ec-8eb8-a37418f5ba1a
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <e8be7a6e-162d-bd5d-5955-77e4fa4c3e77@srcf.net>
Date: Fri, 18 Feb 2022 12:22:54 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH 2/2] coverity: do not build QEMU, SeaBIOS or OVMF
Content-Language: en-GB
To: Roger Pau Monne <roger.pau@citrix.com>, xen-devel@lists.xenproject.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>
References: <20220218120042.32102-1-roger.pau@citrix.com>
 <20220218120042.32102-3-roger.pau@citrix.com>
From: Andrew Cooper <amc96@srcf.net>
In-Reply-To: <20220218120042.32102-3-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 18/02/2022 12:00, Roger Pau Monne wrote:
> Such external projects should have their own Coverity runs, and
> there's not much point in also making them part of our scan (apart
> from greatly increasing the amount of code scanned).
>
> Trim the dependencies now that QEMU is not built.
>
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>

Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>


From xen-devel-bounces@lists.xenproject.org Fri Feb 18 12:23:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 18 Feb 2022 12:23:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275347.471176 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL2Ik-00023m-K4; Fri, 18 Feb 2022 12:23:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275347.471176; Fri, 18 Feb 2022 12:23:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL2Ik-00023f-Gd; Fri, 18 Feb 2022 12:23:54 +0000
Received: by outflank-mailman (input) for mailman id 275347;
 Fri, 18 Feb 2022 12:23:52 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=N23X=TB=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1nL2Ii-0001yZ-FA
 for xen-devel@lists.xenproject.org; Fri, 18 Feb 2022 12:23:52 +0000
Received: from ppsw-41.csi.cam.ac.uk (ppsw-41.csi.cam.ac.uk [131.111.8.141])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a1318a46-90b5-11ec-8723-dd0c611c5f35;
 Fri, 18 Feb 2022 13:23:51 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:60164)
 by ppsw-41.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.139]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1nL2Id-0000iN-S5 (Exim 4.95) (return-path <amc96@srcf.net>);
 Fri, 18 Feb 2022 12:23:47 +0000
Received: from [192.168.1.10] (host-92-12-45-187.as13285.net [92.12.45.187])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 6D5511FDB0;
 Fri, 18 Feb 2022 12:23:47 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a1318a46-90b5-11ec-8723-dd0c611c5f35
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <34ebc66c-e55f-3f98-b769-0e73bdf3c2fe@srcf.net>
Date: Fri, 18 Feb 2022 12:23:47 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH 1/2] github: add workflow to run Coverity scans
Content-Language: en-GB
To: Roger Pau Monne <roger.pau@citrix.com>, xen-devel@lists.xenproject.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>
References: <20220218120042.32102-1-roger.pau@citrix.com>
 <20220218120042.32102-2-roger.pau@citrix.com>
 <0eeb8f5f-d049-8a8e-9e65-d1966c21a781@srcf.net>
From: Andrew Cooper <amc96@srcf.net>
In-Reply-To: <0eeb8f5f-d049-8a8e-9e65-d1966c21a781@srcf.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 18/02/2022 12:21, Andrew Cooper wrote:
> On 18/02/2022 12:00, Roger Pau Monne wrote:
>> Add a workflow that performs a build like it's done by osstest
>> Coverity flight and uploads the result to Coverity for analysis. The
>> build process is exactly the same as the one currently used in
>> osstest, and it's also run at the same time (bi-weekly).
>>
>> This has one big benefit over using osstest: we no longer have to care
>> about keeping the Coverity tools up to date in osstest.
>>
>> Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
>> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
>> ---
>>  .github/workflows/coverity.yml | 35 ++++++++++++++++++++++++++++++++++
>>  1 file changed, 35 insertions(+)
>>  create mode 100644 .github/workflows/coverity.yml
>>
>> diff --git a/.github/workflows/coverity.yml b/.github/workflows/coverity.yml
>> new file mode 100644
>> index 0000000000..12fc9c782b
>> --- /dev/null
>> +++ b/.github/workflows/coverity.yml
>> @@ -0,0 +1,35 @@
>> +name: Coverity Scan
>> +
>> +# We only want to test official release code, not every pull request.
>> +on:
>> +  schedule:
>> +    - cron: '18 9 * * WED,SUN' # Bi-weekly at 9:18 UTC
>> +
>> +jobs:
>> +  coverity:
>> +    runs-on: ubuntu-latest
>> +    steps:
>> +    - name: Install build dependencies
>> +      run: |
>> +        sudo apt-get install -y wget git bcc bin86 gawk bridge-utils \
>> +          iproute2 libcurl4-openssl-dev bzip2 libpci-dev build-essential \
>> +          make gcc libc6-dev libc6-dev-i386 linux-libc-dev zlib1g-dev \
>> +          libncurses5-dev patch libvncserver-dev libssl-dev libsdl-dev iasl \
>> +          libbz2-dev e2fslibs-dev git-core uuid-dev ocaml libx11-dev \
>> +          ocaml-findlib xz-utils gettext libyajl-dev libpixman-1-dev \
>> +          libaio-dev libfdt-dev cabextract libglib2.0-dev autoconf automake \
>> +          libtool libfuse-dev liblzma-dev ninja-build \
>> +          kpartx python3-dev python3-pip golang python-dev libsystemd-dev
> We dropped gettext as a dependency a few releases ago, and we don't need
> python3-pip either.  Can fix on commit.
>
>> +    - uses: actions/checkout@v2
> I think we want
>
> - uses: actions/checkout@v2
>   with:
>     ref: staging
>
> Can also fix on commit.
>
> Acked-by: Andrew Cooper <andrew.cooper3@citrix.com> (mainly because I
> can see that Coverity has done the right thing with this.)
>
>> +    - name: Configure Xen
>> +      run: |
>> +        ./configure

On second thoughts, we can probably --disable-docs here, because it's
just wasted processing time when all we care about is the C.

~Andrew


From xen-devel-bounces@lists.xenproject.org Fri Feb 18 12:27:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 18 Feb 2022 12:27:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275355.471187 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL2MS-0002kz-4X; Fri, 18 Feb 2022 12:27:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275355.471187; Fri, 18 Feb 2022 12:27:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL2MS-0002ks-14; Fri, 18 Feb 2022 12:27:44 +0000
Received: by outflank-mailman (input) for mailman id 275355;
 Fri, 18 Feb 2022 12:27:42 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=YtLv=TB=citrix.com=prvs=0411da6ea=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nL2MQ-0002km-M6
 for xen-devel@lists.xenproject.org; Fri, 18 Feb 2022 12:27:42 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 289d4a5c-90b6-11ec-8723-dd0c611c5f35;
 Fri, 18 Feb 2022 13:27:39 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 289d4a5c-90b6-11ec-8723-dd0c611c5f35
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645187261;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=gvlXktozY19bj+HWyVzUQFBQt2NrqF7Sqh3nlu3qVnk=;
  b=AvhN37Fu2hBFTkByHjrCSJbiwfQJpuSODY5IqGaJIkZfhvhiC1o1xMnF
   blOvyYo+NYycQ0NM4WcCcRgBXFxWTUoAVRl4G3ZbWPhIuLpfga9AOP4Te
   P2KqKCoZX45n+Z54NDZCOqKTwVgEokwclEr9s3gsSTsgsEQeApo0vBCnS
   A=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 64511627
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:NWezu6qs/+XCbcyOOhMD7oT3Sc5eBmLXZRIvgKrLsJaIsI4StFCzt
 garIBmPPaqKNjemLd9+OtyzpB8B6JeHyoNiGlBt/CBnFCga8puZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlVEliefQAOCU5NfsYkidfyc9IMsaoU8ly75RbrJA24DjWVvX4
 IOq+qUzBXf+s9JKGjNMg068gEsHUMTa4Fv0aXRnOJinFHeH/5UkJMp3yZOZdhMUcaENdgKOf
 M7RzanRw4/s10xF5uVJMFrMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKv+Zvrgc91Zk
 b1wWZKMpQgBN7XjgeYWbRxkQwZdMalG6af4M2immJnGp6HGWyOEL/RGCUg3OcsT+/ptAHEI/
 vsdQNwPRknd3aTsmuv9E7QywJR4RCXoFNp3VnVI1zbWAOxgWZnea67L+cVZzHE7gcUm8fP2O
 ZZEMGMxNkuojxtnGA8tJ5MjjcqSoDr2QgdUjkvKjJYU/D2GpOB2+Oe0a4eEEjCQfu1Xg0KZq
 2Tu72n/RBYAO7S30iGZ+3ihguvOmyLTW48IErC8sPlwjzW72Wg7GBAQE1yhrpGRg0u1Cox3M
 FYf9GwooLRa3FymSJzxUgO1pFaAvwUAQJxAHusi8gaPx6HIpQGDCQAsTDRMddgnv88eXiEx2
 xmCmNaBONB0mOTLEzTHrO7S9G7sf3hORYMfWcMaZQIdzMDhq782skLobdpnEL+tsc/lABill
 lhmsxMCr7kUiMcK0YCy8lbGny+gq/D1c+Il2unEdjn7t10kPeZJc6TtsAGGtqgYcO51W3Hc5
 CBspiSI0AwZ4XhhfgSpSf5FIrym7u3t3Nb00Q82RMlJG9hAFheekWFsDNNWeBYB3iUsI2aBj
 KrvVeV5vc470JyCN/IfXm5JI552pZUM7Py8PhwuUvJAY4JqaCiM9zx0aEib0gjFyRZwzPhlZ
 c/KLZj1Vx727JiLKhLvFo/xNpdxm0gDKZ77H8inn3xLL5LFDJJqdVv1GATXNb1ohE91iA7U7
 8xeJ6O3J+Z3C4XDjt3s2ddLdzgidCFjbbiv8pA/XrPTc2JORTB6Y9eMkOxJRmCQt/kM/gs+1
 irmAREwJZuWrSCvFDhmnVg5Nuu0BM4n9ShT0O5FFQ/A5kXPqL2Htc83X5A2YaMm5Kpky/t1R
 OMCYMKOHrJETTGvxtjXRcCVQFBKHPhzuT+zAg==
IronPort-HdrOrdr: A9a23:MTtx5aCMHED/44rlHeg0sceALOsnbusQ8zAXPh9KJiC9I/b1qy
 nxppkmPH/P6Qr4WBkb6Le90Y27MAnhHPlOkPQs1NaZLXLbUQ6TQr2KgrGSoQEIdxeOk9K1kJ
 0QD5SWa+eAfGSS7/yKmTVQeuxIqLLskNHKuQ6d9QYUcegDUdAf0+4TMHf8LqQZfngjOXJvf6
 Dsmfav6gDQMkg/X4CePD0oTuLDr9rEmNbPZgMHPQcu7E2rgSmz4LD3PhCE1lNGOgk/jIsKwC
 zgqUjU96+ju/a0xlv10HLS1Y1fnJ/ExsFYDMKBp8AJInHHixquZq5mR7qe1QpF6t2H2RIPqp
 3hsh0gN8N85zf4eXy0mwLk303a3DMn+xbZuCmlqEqmhfa8aCMxCsJHi44cWADe8VAcsNZ117
 8O936FtrJMZCmw0hjV1pztbVVHh0C0qX0tnao4lHpES7YTb7dXsMg24F5VKpEdByj3gbpXX9
 WGNPuspMq+TGnqLEww5gJUsZ6RtzUIb1u7q3E5y42oO2M8pgE986MarPZv6UvouqhND6Ws3N
 60QZiAoos+OvP+XZgNdNvpfvHHeFAlYSi8eV56cm6XXJ3uBRr22uvKCfMOlaaXRKA=
X-IronPort-AV: E=Sophos;i="5.88,378,1635220800"; 
   d="scan'208";a="64511627"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=flBIRRrgU63h71mYCQHVuEtJKarwNiNGlQvdjsXjfJeEYCMDfou3KYL6mLWwaND4g5SpywMqeN4V7gzmfClNq4TYUbKW1mQYlPBjrvsWNwj0RDbK97Fx9m766aDW3G9Hk2EMAt0TmfhXfT/kaoyq3v5ZKAbK5rENy96OeRYhwrs6qc99eYKyACDXuPo7oL7x2uuVd134JJxDHJQs/Hxy19Q0JXZpdYFXeX0PNI/ZIGIQ5nQHp5v9xdgb43YBD9HbIAyam9P/ImqQigR3KR+uVxmkV++5iuyGIsR0m9ITBIJzGJ9noINqoEUv330mOKVyUhnPcTAJKVSRNcgaPcBv8g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=0gi1zub+GpucqWxCwkIGN7iC7DQk9TUFldlfyPdd1aw=;
 b=MY/ksQ9/44JfUoKJCMkYOQR9hN5sQpozkborEIvotZbkn+rBbsMrZ1HXfFjgPt1V6CmXQ1vtGULbj/LCTzOYwBymzYz6wrWX3grwl3M2BCnYW+lBr+P7rVWn+5yKsZAddzogzDAT/5M3xZhOegfeYIW/t6YcZsFS5jHeW1zdlDPx59+HonjSXiEcWJkWGEusGvWuRS7MlUfPClErydOKZcD2cQHQ40AdDYL6N+1xSocc2j1Xv7NkXZUaHjGtwlmJs7MdqnLeOlqUYAXjDYlp9aKng8FEbbOnLnfwhEMES0OVs94/lB5HSs/UXxZKpEibKoz4hsAUZdYPo27jUylx5Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=0gi1zub+GpucqWxCwkIGN7iC7DQk9TUFldlfyPdd1aw=;
 b=OKcL/nPC0VIV35SF18sD4G9JE5u2w0hl09KVCTF9RBT7HcZHVYAQFRGK3QzWAbjCLfHYPhcX24Zg6xszCtTpabapsfaTEvFZRubDwggpawYXyD5Pk0UaQm2Pk3/faEheAsNwFFowgNrtSJyBQfSfNbln6eN0gxXQjXbuqi+iab4=
Date: Fri, 18 Feb 2022 13:27:27 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Andrew Cooper <amc96@srcf.net>
CC: <xen-devel@lists.xenproject.org>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, Jan
 Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>, Stefano
 Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH 1/2] github: add workflow to run Coverity scans
Message-ID: <Yg+Qr3+nnTMv7eVN@Air-de-Roger>
References: <20220218120042.32102-1-roger.pau@citrix.com>
 <20220218120042.32102-2-roger.pau@citrix.com>
 <0eeb8f5f-d049-8a8e-9e65-d1966c21a781@srcf.net>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <0eeb8f5f-d049-8a8e-9e65-d1966c21a781@srcf.net>
X-ClientProxiedBy: MR1P264CA0077.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:501:3f::9) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 15f39b02-09fb-43bc-d10d-08d9f2da0a44
X-MS-TrafficTypeDiagnostic: BN7PR03MB4450:EE_
X-Microsoft-Antispam-PRVS: <BN7PR03MB4450B2F1A340301452E657978F379@BN7PR03MB4450.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2582;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: BBc0oyygHsNq5t7LEoowfg7rU+mwuVf3bdRonKu3VTTBjf6dZIc9eKwwBfgLDQSQaC0A20SV48rByt3T75Wb26bRch0ynqnNrYWKXEG9DyYW2ctRCnRK0Pte9BDLpTEbyxDaAHWTX+lAFjNtyHjwL+mBmRTleB3KOdVRqDDIBH3emPtVm3dj13UqG6igoPPCuCA9eXLL70K4RHQWfW72urZQVAY7mk7paJncJyCBjRZZ96VO+awfC/HzHrj1GFSGN1WbnjNe8dRhZMr93qFFvUEENxI7MCwaK9rKs7Ym+pf7Bmclq+eP/Ma4+hMTbmfn32hMoa5By2CHMMvsqNZGeITsEWA0shjt8dLalai8PD4yhxk8foERCk0pB4BprIsgYrKdU+TSvFYc6KiFQ6a6KCPlz+bhVgWCmXbqnOFMBwTK5lmXM8TJ9GRErdvMU/tquwwqXs1br85E1BhAJfnpvX2Ka/0MORcjISNf2y7S4U//7x0UxA3fB+jykwn3lS0XLruCXh2ii0sD22alwPg8Jabf8VThc7m+nUMxlIojcw/dm1ED2eg/jZ7w/13ug+oJFdaO3Px0iWgA9mbvywGjqxnRJl+H4L7QRcLNzORiYshU1IafWBgh+UEw3qRYua7UIk46pPgMpkBl4DDQMili7Q==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(26005)(33716001)(186003)(38100700002)(2906002)(83380400001)(66946007)(6666004)(6512007)(9686003)(82960400001)(85182001)(6486002)(6506007)(66556008)(508600001)(8936002)(5660300002)(6916009)(53546011)(316002)(4326008)(8676002)(54906003)(86362001)(66476007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U1BZK3YySGdCNGtVdWgrMEo3amV1VFNFclpmdWllakJTSGkxQzZsQUtyRnBO?=
 =?utf-8?B?RzRWb24rNzFXaFFNRGFYdlVyVXVoMUxJTm4vQ2szSWVHMlRXM0xlUlpEVHJt?=
 =?utf-8?B?WWV0M0YvRFJueUNDc2lSVVEwcWRvY0JzdS9VQUhDa0w3R29qSjVBN1ZkLzAx?=
 =?utf-8?B?MkFyc0VyS0o3Z1NUU04wZ1ZXWE1TMFNkTFE0SG92VVdmM1pWNHl6UDIwUVA0?=
 =?utf-8?B?eHYrMGJzRHZqeUtleGVtSk11NzdKMitDeHZsSVB3VDlUaTFxZm9GV2lWTkMr?=
 =?utf-8?B?eTlmZ0l0b21BYnpBR0hZMHlrTnRiOFA5SFU2Vjl2T3c2NFF1RkhsVitvMFl2?=
 =?utf-8?B?YkxsWEcvY3AwTDI2MGdnK2luRHRWQUdPbFQwVUJYYnZyMzE2K3VtVXRXbEV6?=
 =?utf-8?B?dUZ1TldQVzYzS2hzcVpiTWRRK2o4NUdHcVpzb3UwYTlxQlhTbUs3T2Y4emNo?=
 =?utf-8?B?elg1dXRFTzhGYytQSVNJZGc3c0l4dmpYU0ZBV04zenlpY1JYNElKYXczbUp4?=
 =?utf-8?B?Yk8vYTBaeG1jZkIvL3N1cHlsTUtFZGs0TS9qK0ZaYUdBQ1FxbGpvUE9PeWJD?=
 =?utf-8?B?TWU1empvTFpEc3NIclRObzExMEJxcVg3OEEzOCtPa0dOTkN6b3NaaTFlQzRw?=
 =?utf-8?B?SFpaZjhBVEJ0M0Vib2lFZVJoYlRrTWNUNEIzL01xYXpMOGQycmR2alJPYTYx?=
 =?utf-8?B?Wk5xOTFhTWN3N2ZLNVoxVXNpSXJ0UVk0Y3V6MkN3L0E5TS9LbzAvenMzOGFz?=
 =?utf-8?B?aEk0ZE5NaFRxSnA1SldPS0VyNTViY1o3eVhiNUhnNWxLSjhCM2JIb2NRWEdC?=
 =?utf-8?B?YkpHK01RYkQ0bklaUi9yK0xUY1hBYzVNZ3pDRXo5ejMzSzR1TjlPSXdFdTlO?=
 =?utf-8?B?THZyLy81Z1FmVHNtUnNzVWFhOE5walFaWnJ3UlFTc2Y1TTUxVmc2NnRoWFdq?=
 =?utf-8?B?YmcwRWdxcDBOSmFrcTdsbU8zQWNjZWZFL1k4SEtUaUU4WGwrbUJ5K21aaExW?=
 =?utf-8?B?RnpzalpxN3VZU1EvRDN3TVRGVWo0dHkySi9CdTRySjk5MjFYNGo5V0tpbTRj?=
 =?utf-8?B?UmhQTnR3WHExMnpGL2FRRk5VMk5CQkdYY2VzTjV0REIzcFdidlVkVEJLUmNw?=
 =?utf-8?B?R1drZXRwOEk0QWtHeVdOcTBJTWlsOE9QL3I5Ui95dHRKQXhHNFRLVGtvVmVE?=
 =?utf-8?B?d1B4TUpJR1VjYllTSzBjeW0zMXVwNFdzMldLaVNkOXRBOGkyZ1krWmJpdmZU?=
 =?utf-8?B?OWx6S2VNdWQzb1NRY0l5VFNreWpIRDVlM3U3bDU5a2N0bEZVUnEwTW9GeElH?=
 =?utf-8?B?emdzNTJkNU5zTlJKQXZxWWx1Z1Z3SVJUVGk1QVcvRXA4Wm82Ni94Z2NjQkRs?=
 =?utf-8?B?cDNMUVhDTTgvQTdhRC95K3NJQURMNTJJN1c5NkdnVDZyOXp5RzRyYytVU2xR?=
 =?utf-8?B?UGNuMStVMFZ4MzNoYmVHWHFoU2NESXQ2aUd6SGp3dUZvK0t1dENZR2NiN3p6?=
 =?utf-8?B?dzhDNmZ4Ri9YdnhWb0JuVjRJWUxIOE9PVTM1akk0WURCUnh3clV4RkMvSHU5?=
 =?utf-8?B?UG11Zzh0OU9ZTVNBWU5WbndtcmZVaXV0SmQ1Q1A5aGtJVVllZjhDaGhxOUVa?=
 =?utf-8?B?MEd0VWxJZEh6NDN3OTE3b2QzWk9Wa3dQV29MNlZOd1l2RTZUeFA3U2FYYzZH?=
 =?utf-8?B?eUU4ZjcrbysvYnN1bnZFT25heXpuYlRtUEpFSHZqWGtxTjcyOXRUUWxJVW1O?=
 =?utf-8?B?TmdjS0U3YVJZUUJ2NS9SVlgrUFhpT0R5OHBTYlR1YXRzYXZ5OWRLZTRMSlow?=
 =?utf-8?B?RmttMHFCRHJWMXh0MXU4Nm9UeTA0Y0E0RjRBSU5sRm5WQllPY0pnaWQ0aHY2?=
 =?utf-8?B?YyswZ2N6RTlOMnNzT1MzS0c3dVN0UnBqUHBHL2V1NWdab0xUOU9yNmFVNSsv?=
 =?utf-8?B?TllLZGtVMTlheHFsdm96Vnh4a21lNk00clFSQmtmT0Nuekc2Rkxwb0V5dmFE?=
 =?utf-8?B?Tit6UEJIUmpCSTZEVDkxc0RYR1V0NFNkNExOamJVWUFWZlFkWURva0hCWEpE?=
 =?utf-8?B?WWFBajBleTVZMysxQ1JWRnJXVmtzZDRxbWtoajN5NW1MV1NyWjRUUnplYm1D?=
 =?utf-8?B?MENma2x4REkxZmo0M2dhczJwd2p0dkQ2ZnNSRHNnQzdvNmtTSm41Nkx6TWZO?=
 =?utf-8?Q?GAZ7IFGHGPb3ccfEGIgbXBo=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 15f39b02-09fb-43bc-d10d-08d9f2da0a44
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Feb 2022 12:27:33.9647
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NgMm4S1G+pABYHp3vxXIWQ/V8jq8kjn2mcU13Mgkd8vC7G/c4U7isWfli7YSZQK1WAzJXcu2kaWUGcAN2optXQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB4450
X-OriginatorOrg: citrix.com

On Fri, Feb 18, 2022 at 12:21:34PM +0000, Andrew Cooper wrote:
> On 18/02/2022 12:00, Roger Pau Monne wrote:
> > Add a workflow that performs a build like it's done by osstest
> > Coverity flight and uploads the result to Coverity for analysis. The
> > build process is exactly the same as the one currently used in
> > osstest, and it's also run at the same time (bi-weekly).
> >
> > This has one big benefit over using osstest: we no longer have to care
> > about keeping the Coverity tools up to date in osstest.
> >
> > Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
> > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> > ---
> >  .github/workflows/coverity.yml | 35 ++++++++++++++++++++++++++++++++++
> >  1 file changed, 35 insertions(+)
> >  create mode 100644 .github/workflows/coverity.yml
> >
> > diff --git a/.github/workflows/coverity.yml b/.github/workflows/coverity.yml
> > new file mode 100644
> > index 0000000000..12fc9c782b
> > --- /dev/null
> > +++ b/.github/workflows/coverity.yml
> > @@ -0,0 +1,35 @@
> > +name: Coverity Scan
> > +
> > +# We only want to test official release code, not every pull request.
> > +on:
> > +  schedule:
> > +    - cron: '18 9 * * WED,SUN' # Bi-weekly at 9:18 UTC
> > +
> > +jobs:
> > +  coverity:
> > +    runs-on: ubuntu-latest
> > +    steps:
> > +    - name: Install build dependencies
> > +      run: |
> > +        sudo apt-get install -y wget git bcc bin86 gawk bridge-utils \
> > +          iproute2 libcurl4-openssl-dev bzip2 libpci-dev build-essential \
> > +          make gcc libc6-dev libc6-dev-i386 linux-libc-dev zlib1g-dev \
> > +          libncurses5-dev patch libvncserver-dev libssl-dev libsdl-dev iasl \
> > +          libbz2-dev e2fslibs-dev git-core uuid-dev ocaml libx11-dev \
> > +          ocaml-findlib xz-utils gettext libyajl-dev libpixman-1-dev \
> > +          libaio-dev libfdt-dev cabextract libglib2.0-dev autoconf automake \
> > +          libtool libfuse-dev liblzma-dev ninja-build \
> > +          kpartx python3-dev python3-pip golang python-dev libsystemd-dev
> 
> We dropped gettext as a dependency a few releases ago, and we don't need
> python3-pip either.  Can fix on commit.
> 
> > +    - uses: actions/checkout@v2
> 
> I think we want
> 
> - uses: actions/checkout@v2
>   with:
>     ref: staging

I've assumed we wanted master as that at least functional per the
testing done in osstest. But maybe it's indeed better to use staging
in order to catch issues before they reach master.

I'm fine with this.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Feb 18 12:47:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 18 Feb 2022 12:47:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275362.471197 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL2fU-00058l-Q2; Fri, 18 Feb 2022 12:47:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275362.471197; Fri, 18 Feb 2022 12:47:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL2fU-00058e-Mm; Fri, 18 Feb 2022 12:47:24 +0000
Received: by outflank-mailman (input) for mailman id 275362;
 Fri, 18 Feb 2022 12:47:23 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nL2fT-00058U-Qq; Fri, 18 Feb 2022 12:47:23 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nL2fT-0001PZ-OR; Fri, 18 Feb 2022 12:47:23 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nL2fT-000571-Dq; Fri, 18 Feb 2022 12:47:23 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nL2fT-0004OR-DP; Fri, 18 Feb 2022 12:47:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Tz4LRO9do9pQOy2PKJ2XbfPcFL5LF+oTCp+PODvfBpw=; b=ln3hvyqGQnRCfUyxzMDSuV23I0
	5yREfVJwAea4ntp9glNfBeAV5TYSxEEgbvwyd22nPNN1TcPJU2VOGhQ0nnivco4lMsByQP6E037m3
	7MStvbsTmVnAfm/wkjlhHk1S0rjyC6iXh53nQysGnmOWGrdJbV8fN5YdtqEnLoctCeL0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168160-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 168160: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=f5592322062f7912dc45b30606f20691f6e1c3ee
X-Osstest-Versions-That:
    xen=4ec51e87804bd9aad0d0b8e5dadb987b54c5adeb
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 18 Feb 2022 12:47:23 +0000

flight 168160 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168160/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  f5592322062f7912dc45b30606f20691f6e1c3ee
baseline version:
 xen                  4ec51e87804bd9aad0d0b8e5dadb987b54c5adeb

Last test of basis   168155  2022-02-17 20:02:59 Z    0 days
Testing same since   168160  2022-02-18 09:01:37 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Anthony PERARD <anthony.perard@citrix.com>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   4ec51e8780..f559232206  f5592322062f7912dc45b30606f20691f6e1c3ee -> smoke


From xen-devel-bounces@lists.xenproject.org Fri Feb 18 12:52:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 18 Feb 2022 12:52:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275375.471209 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL2kY-0006bH-JK; Fri, 18 Feb 2022 12:52:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275375.471209; Fri, 18 Feb 2022 12:52:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL2kY-0006bA-GJ; Fri, 18 Feb 2022 12:52:38 +0000
Received: by outflank-mailman (input) for mailman id 275375;
 Fri, 18 Feb 2022 12:52:36 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nL2kW-0006b0-JH; Fri, 18 Feb 2022 12:52:36 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nL2kW-0001Ut-FC; Fri, 18 Feb 2022 12:52:36 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nL2kW-0005Rl-3Q; Fri, 18 Feb 2022 12:52:36 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nL2kW-00079I-2z; Fri, 18 Feb 2022 12:52:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Xw9RiqZ+rNsIOVmkU7NZ9wRWI46saJ7PcVGHseuw7iI=; b=SlcojbLhHaOZPt2Gb8+IszhAVx
	3eEuoaucVgMhPymhl7IwR4654kKkxp6mQHyTO2aZ1CLGsxqLMUc88mY4M3fgr1EwP5VtKNaBNV8EI
	Dak+4i8fpabZE4msfFNDENCQsNQQOHjK++fymobWvJT8qMwp+ukbcTjNKMxnmTAxSJ1w=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168158-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 168158: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=9195e5e0adbb8a9a5ee9ef0f9dedf6340d827405
X-Osstest-Versions-That:
    linux=8b97cae315cafd7debf3601f88621e2aa8956ef3
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 18 Feb 2022 12:52:36 +0000

flight 168158 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168158/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168156
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168156
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168156
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168156
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168156
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168156
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168156
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168156
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                9195e5e0adbb8a9a5ee9ef0f9dedf6340d827405
baseline version:
 linux                8b97cae315cafd7debf3601f88621e2aa8956ef3

Last test of basis   168156  2022-02-17 21:09:38 Z    0 days
Testing same since   168158  2022-02-18 03:14:21 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Aaron Liu <aaron.liu@amd.com>
  Alex Deucher <alexander.deucher@amd.com>
  Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
  AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
  Chun-Kuang Hu <chunkuang.hu@kernel.org>
  Daniel Vetter <daniel@ffwll.ch>
  Dave Airlie <airlied@redhat.com>
  Evan Quan <evan.quan@amd.com>
  Jani Nikula <jani.nikula@intel.com>
  Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Matthew Auld <matthew.auld@intel.com>
  Maxime Ripard <maxime@cerno.tech>
  Muhammad Usama Anjum <usama.anjum@collabora.com>
  Nicholas Bishop <nicholasbishop@google.com>
  Nícolas F. R. A. Prado <nfraprado@collabora.com>
  Rajib Mahapatra <rajib.mahapatra@amd.com>
  Randy Dunlap <rdunlap@infradead.org>
  Robin Murphy <robin.murphy@arm.com>
  Sebastian Andrzej Siewior <bigeasy@linutronix.de>
  Sherry Yang <sherry.yang@oracle.com>
  Shuah Khan <skhan@linuxfoundation.org>
  Siva Mullati <siva.mullati@intel.com>
  Thomas Zimmermann <tzimmermann@suse.de>
  Tvrtko Ursulin <tvrtko.ursulin@intel.com>
  Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
  Ville Syrjälä <ville.syrjala@linux.intel.com>
  Yifan Zhang <yifan1.zhang@amd.com>
  Zhi Wang <zhi.a.wang@intel.com>
  Zhi Wang <zhi.wang.linux@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   8b97cae315ca..9195e5e0adbb  9195e5e0adbb8a9a5ee9ef0f9dedf6340d827405 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Fri Feb 18 12:59:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 18 Feb 2022 12:59:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275386.471220 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL2qs-0007Iz-BX; Fri, 18 Feb 2022 12:59:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275386.471220; Fri, 18 Feb 2022 12:59:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL2qs-0007Is-8B; Fri, 18 Feb 2022 12:59:10 +0000
Received: by outflank-mailman (input) for mailman id 275386;
 Fri, 18 Feb 2022 12:59:08 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=6Z2s=TB=citrix.com=prvs=041b9fbab=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nL2qq-0007IR-KC
 for xen-devel@lists.xenproject.org; Fri, 18 Feb 2022 12:59:08 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8cf6292d-90ba-11ec-8723-dd0c611c5f35;
 Fri, 18 Feb 2022 13:59:06 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8cf6292d-90ba-11ec-8723-dd0c611c5f35
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645189146;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=lddUhaVDBPtq6QBodkEwUXilrGgtaPioD/w3S4ycJKc=;
  b=DRrrQhC6+ZWIqYUW5Tp90tcLxQDGBabC1vnVVkQ8L/3WPHdpIj6MVCEw
   SV0I08o7OZlhl05bHpw5qYOIWj++JCwanyFI7nLTBR8q1HhgS/fJk1qS6
   0FjWA7DJcBuPWhizsyjGZL+ibyQHpl7fRGkWD54TnPVXN4NWHgwgnct07
   4=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 64515871
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:WjBE/al7ZGZdlctGccME1nzo5gxLJkRdPkR7XQ2eYbSJt1+Wr1Gzt
 xIZDTjSM/qIYzD8fYx/Ooi09h4FuceGzN9qTAVu+Xo3QyMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2UILd9IR2NYy24DjWlPV4
 LsenuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR
 v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ
 NtxWZOYaisCJJeLpMYhCzIGFSNmAqYe+aDFCC3q2SCT5xWun3rExvxvCAc9PJEC+/YxCmZLn
 RAaAGlTNFbZ3bvwme/lDLk37iggBJCD0Ic3k3ds1zzGS90hRojOWf7i7t5ExjYgwMtJGJ4yY
 uJHNWc2MUSfOnWjPH8zUY8PxN2yo0DvLQBq9lyPpoMdzU/6mVkZPL/Fb4OOJ43iqd9utkSFo
 mPL+UzpDxdcM8aQoRKe6W6ljOLLmSL9WaoRGae++/osh0ecrkQMDDUGWF39puO24ma3XtkOd
 WQP4CEg664/6CSDXtT7GhG1vnOAlhodQMZLVf037hmXzajZ6BrfAXILJhZDYtE7sM49RRQxy
 0SE2djuAFRSXKa9ECzHsO3O9HXrZHZTfTRqiTI4oRUtwPXIurt0sjDzFv09FqytsdatGC7y6
 mXfxMQhvIk7gckO3qS92FnIhTOwu5TEJjIIChXrsnGNtV0gOtP8D2C8wR2CtKsbct7FJrWUl
 CVcw6CjAPYy4YZhfcBnaMEEB/mX6vmMK1UwanY/TsB6p1xBF5NOFL28AQ2Sxm81Y67omhezO
 Sc/XD+9ArcKbRNGioctPuqM5zwCl/SIKDgcfqm8giBySpZwbhSb2ypleFSd2Wvg+GB1z/1iY
 M3HKZfwUy9AYUiC8NZQb75MuVPM7npjrV4/uLihl0j3uVZgTCX9pUg53KumMblisfLsTPT9+
 NdDLcqaoyizo8WlChQ7BbU7dAhQRVBiXMieg5UOKoarf1o3cEl8WqS56e5wJORYc1F9y76gE
 oeVARQDljISRBTvdG23V5yUQOmxBc0m9SpjZ0TB/z+AghAeXGpm149GH7Mfdrg77u1zi/lyS
 vgOYcKbBfpTDD/A/lwggVPV9eSOqDzDadqyAheY
IronPort-HdrOrdr: A9a23:9JUbQKnF2h4LBPiOjDy/Y3cCTBLpDfOKimdD5ihNYBxZY6Wkfp
 +V8sjzhCWatN9OYh0dcIi7SdW9qXO1z+8Q3WGIVY3SHTUOy1HYU72KirGSgwEIeheOuNK1sJ
 0AT0EQMqyJMbEXt7eZ3OD8Kadc/DDlytHquQ699QYXcegCUcgJhG0Vanf5LqQ1fng9OXNQLu
 vA2iMtnUvGRZ1jVLXDOpBzZZmkmzSkruOCXTc2QzocrCWehzKh77D3VzKC2A0Fbj9JybA+tU
 DYjg3Q/MyYwrOG4y6Z81WWw4VdmdPnxNcGLteLkNIpJjLljRvtTJh9WoeFoCs+rIiUmRMXeZ
 j30lMd1vZImjXsl1KO0ELQMs7boW4TAkrZuBilaL3Y0JfErXwBepB8bMliA2XkAgIbzaBBOe
 Rwrj6kXtNsfGD9dG6W3am5azh60kWzunYsiugVkjhWVpYfcqZYqcgF8FpSC4poJlO21GkLKp
 gkMCjn3ocdTbpaVQGvgkB/hNi3GngjFBaPRUYP/sSTzjhNhXh8i08V3tYWkHsM/I80D8As3Z
 WKDo140LVVCsMGZ6N0A+kMBcOxF2zWWBrJdGafO07uGq0LM2/E75T3/LI27ue3f4Fg9up/pL
 3RFFdD8WIicUPnDsODmJVN7xDWWW24GS/gz8lPjqIJ8oEUhICbeBFrZGpe5vdIks9vdPEzAc
 zDSq6+K8WTWVfTJQ==
X-IronPort-AV: E=Sophos;i="5.88,378,1635220800"; 
   d="scan'208";a="64515871"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=UKpx8OtfNiKqpj3E7/+4tU8un8NBhKyBfhswN6EkyGZNK0zZL0iLDIWpghTVWdOnleuior3KqFJu3Pio/OHw3ix9LEIRfFFWkbZjUWWqIUFzxJYz82e4n7HCZe6J860nPGZJFzOiW/xNWepU6JjzCAKhTrMsPP7Fk0FJM+oUKcB89QmKu8uXXZG5p9tHZWaipl2ZvMsV3hcDvNZtrEH09BarOxtyNQ+UyIG8lKkQDlzVNFIaki+WGi1DZKimQIGkP9b6HY2hdkHgAcde7FEtqfQpDDELaVE4aTNZFapHwJds4zqenRUw+MWeIYvMCOetu7d0BqK4m/wqIQw86+Eolg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=lddUhaVDBPtq6QBodkEwUXilrGgtaPioD/w3S4ycJKc=;
 b=Fos/PXbDqM8INz22x/3RC021KBKVv0dKdJMZI9YkQ50klf6U+f00qnz5QOXSNqaOzRbpoXrU1TcxVFD0MYqsXyBYqaiMcywLkoA6o94HpWJHIqPAcmUM35hUpEPSwKnSJiVc66Lkn7eZDnn8J1df3tyWL25en1s7YJl282KcD8W2ampnPz5Z+0JC05M46li00Pes48EHZ0YR+L2qycVVU6womqrhG5EN4Q+TPKOjKnDO1KbehpU/2J951IzhXJILFAVTHzXg4b+CuOCKGXw0iLj6Ye7Rjn59bbJYrsGKHU8c1lGNXAsXh+kiznRHdqG2SpZHRwr5AuwKPZIri6VuPw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=lddUhaVDBPtq6QBodkEwUXilrGgtaPioD/w3S4ycJKc=;
 b=dKiutzeDrcdE1mW1dyW6sVgpoxPRPePDCiPG4lsu93oTqaYzwvGEXvwWx+DK+U7svAg9YCqTW9SkvYR6+25ig1QDtxcn1mPCdsGVcMq9E7yWjHaLKikFG8KgCPQMpAQus9tPkrBzEmiNzReDEwwW5WR/9i+6fSWrnZzw1xJKJKQ=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>, Andrew Cooper <amc96@srcf.net>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "George
 Dunlap" <George.Dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, "Julien
 Grall" <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Wei Liu
	<wl@xen.org>
Subject: Re: [PATCH 1/2] github: add workflow to run Coverity scans
Thread-Topic: [PATCH 1/2] github: add workflow to run Coverity scans
Thread-Index: AQHYJL8wuvXnHhxuC0qfnAoHQI92b6yZOqQAgAABpYCAAAjHAA==
Date: Fri, 18 Feb 2022 12:58:52 +0000
Message-ID: <a35a8960-0e27-1669-b4a1-b8f59f148759@citrix.com>
References: <20220218120042.32102-1-roger.pau@citrix.com>
 <20220218120042.32102-2-roger.pau@citrix.com>
 <0eeb8f5f-d049-8a8e-9e65-d1966c21a781@srcf.net>
 <Yg+Qr3+nnTMv7eVN@Air-de-Roger>
In-Reply-To: <Yg+Qr3+nnTMv7eVN@Air-de-Roger>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 14d059f4-3a05-4d1b-a4a7-08d9f2de6a57
x-ms-traffictypediagnostic: DM5PR03MB2428:EE_
x-microsoft-antispam-prvs: <DM5PR03MB24289B1B2DDA1AA0C9F5B0C3BA379@DM5PR03MB2428.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:3631;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: qffWzitUAWxy6C6xJxHWv8wrTyZO/h8aZE8uEsv3Yg9IVy2GAL8gRyTsn+RJIbNSdyO1W/1CeGF5FNZ0A3a+Aqb590P+Xou1NSCHrTxUPY+0/v+/QWQszP+krpnhK3076cpNrKNptwrX/OG3pQn0pG0afgEgwc+EbdgkpeIDlgli9D8YcLrGLqGAzqf1SgyauNKE3QC3tRXvrqVT9A5DntKgxPa5M2Qfaqxv46VAk/nacnURraWsfFSRy0YYo3q8epE1bo9yO+JvkP5qLQJIE+tjisR+PBB1SRN2OhwPYBNSq4C66yvOMAlmKe5zVcUIEhwsQEQsNa9iwAiP1pYabmtbtmLcrrgMfpF7pn1Hm5FcwXXd7QTOVEShfLOMg2DBkCgHSBcCK5LAoIMKFAnVj1vCua6LTRapny5N3jpBwof1LiaKgogF5j6p0Gta6yPjt3kckhClCMLZKj8q59FqfIhHrcbp7U7cjbliKG1rFBOndNKtOn4utxWJFjoG74XCGvLnEmgz61R4B2KS/M21pDtfQMOOwHwMoxc/6cQHOhfGSjOw4iIwF3gCi9lEBU7lzg4QGkgvFVAo/4w3QHgULtSQfB6tGnRbyVhThtkSf7O8Y+L9lBb98VeXeoeeFCKQdFmH9WzH0ID+SlP7I7CcwbH0W2hDW3XOSwH7T0FuLwrmEBiZXenHP55/aP8JbFFoHw8TESp5vb/XpZw3dEjydWh4Uz2bXi0MnHN7SsWkPkq/0/AfqO402q/htTsuQNcFCWKZtalEYCraLmp2LDznyg==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(26005)(91956017)(76116006)(8676002)(66476007)(122000001)(66946007)(66556008)(38100700002)(8936002)(64756008)(110136005)(6512007)(4326008)(54906003)(6506007)(316002)(71200400001)(66446008)(6486002)(53546011)(86362001)(508600001)(38070700005)(31696002)(83380400001)(31686004)(2616005)(2906002)(82960400001)(186003)(5660300002)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?R2VPS012ZGVDOUdRRG53cjZaYnZ0SlQvTlp3M1NpeEp5SjZFU1k5V0dxRTF5?=
 =?utf-8?B?blJSWXNzVGVJZ0trb3hRMVhJVWZweWFPc0lybFpITHJNa3QzclhQTGpIOUow?=
 =?utf-8?B?NGJabGRicXl5UXFNUHFuUWNlcjVIcnBab2lsNzErL2JxYkxwL1FTMndsMmRW?=
 =?utf-8?B?N2NUbXh1ZFN1V05PbElRRFpHd2xZTDdyaW15NlIxckFzMG56SjhTQ2FDVjRn?=
 =?utf-8?B?NjdoWkZlaGVxVHZrM0ppQlgyWXl0Ri9pMlZqWXVYcWJGU0FCQjB3Mko0NXNk?=
 =?utf-8?B?RDBnaU5KN1E0ZW9Fd2wrRUowNmtKQWN6SVFBa0IwTG1ETnpsMjdiQ2JtZ01k?=
 =?utf-8?B?SE84QWY4eEFhWVoxaURUYkE3YzllZHdkbE5qc1dxZ2lSTHhtcWJPZUVzR0NO?=
 =?utf-8?B?MTlSbVNMY2F4VWxzOUJTRFF4bXpnYVhUa0MwdDZpTXBsTG96Y2wzZWVwQjFP?=
 =?utf-8?B?aG1qcU5UU21MRTUvZ29WaXViV3RhcnRSZjBJc3Q0aGkxcEx3TTE5Zmc3UEVC?=
 =?utf-8?B?em0rYytlbGhROFlxL2x2QmhJeDVTL3RicHRhK0UvdlZxdkkvbnlFTm9Tck9Q?=
 =?utf-8?B?S3ZnMGttMGhoVjAreFlOd0JwNStaaWhXSS9OSU8yMERuUzQ1NWhxRk11UzdH?=
 =?utf-8?B?WU5waytjcXRGdXZhU3FXemVkeUF5SnZpeDhjdlh3bVYxL1d3VSthcmlGMllG?=
 =?utf-8?B?YUw2bE05YzJyd2FRaGxvZmJTYU1YRDNqeXZINEJaUEJjck5qUmZCakloUkh5?=
 =?utf-8?B?R2IyRlNiSm1EY3JKVW45UG5lRjByeEN4TzZLR1dobmoxb0cvWkYrUnVsRU4v?=
 =?utf-8?B?bGd6VlF0dktWU1lmTTZOc244Zk5xaHRDSW5ibm9zazF4SHdHMHl6cmRkc0xl?=
 =?utf-8?B?Z0N1NmNERWZnSE1ZdU9ZTVVUeUMvdHlWS2dORExBN2J3K1hlNFdVRDlqR3Jw?=
 =?utf-8?B?WGcrVGdiM3VBRlZKK2tsSEE1SGNnbit2QUZGOG9ycUhZWmxtbloxbm9ROTl2?=
 =?utf-8?B?ZktOc0pWUm95Z3BGYmZMMG4ycUdyNTEwYmtLeCs1aHc4Zml4YXFvTXl0Vkpo?=
 =?utf-8?B?RW9jWHZNK0haekJaSUpNUjlNb1FGSTZwYlhLVDlxNTFqRkdsNVZDYk1IckNJ?=
 =?utf-8?B?QjBSYTlKcVZyMjQyTUw0ZS90clhrWTBlckcvT0dna3BDdG14ZXVpZnkzUGtz?=
 =?utf-8?B?Yi9vNmRUZXV4UmQzZnhieWp6bTJwR0xuS1BWZTNLWmd0UVlXR1E3WFprTXRs?=
 =?utf-8?B?eEU2aG9LYkFWUmc1SGtJNmY5ZW13SWdiUkFQdm1nOXl6NjhEOElsZmF0MmE1?=
 =?utf-8?B?TlJvc0pVbmo5QisvbjR5K0lNdzhvT20yNHg5WnNBc25jZitlWC9Ia2FHRkRp?=
 =?utf-8?B?RnNKZHczSnJEMTZYUDJNVW1HUTVnQTRYYTE0VUJ1Z1RkMUZZWGhSNm9SV043?=
 =?utf-8?B?TVVuN041cUVVUmxHYUtnMzBhSW1rV1ZZSWJXc3l0UG96ek1Fa1FveVhOQW1D?=
 =?utf-8?B?S0tBTFV4VDMySWdHRnVWdEhSRUYrS0dLcFFNOUFHbUwwRDZzRHlUaFFuTU9W?=
 =?utf-8?B?MjN3QlNwWktoS0tZY2ZEWGRDcTZvcG1XdXVoYm1MM0MrWS9UV1pQbEFkYWli?=
 =?utf-8?B?SUdTWEovRnRoN2RLY3BpWWpmMVIyaCtUWjUyeU9tRit4ZitkZlZEOFMxUDMv?=
 =?utf-8?B?b3ZJWUpiZjkrUExUelRGSGpaazJlRVJuQ2lydVVhS3pTckRQNTF3dXNaLzlO?=
 =?utf-8?B?VGZtbm5RYTYzM3BXMUhpNktFMXNIbjhFOXRKKzR4bDBkUmpsT1NFZWw0RmFB?=
 =?utf-8?B?bTNnOFAzNGY4R1hmQ3laSit1bWJIcUVrYmsrLy9QRDZoa09OMmRpQWNROFdq?=
 =?utf-8?B?VWtGRHVETlBvZk5kcDJYd1dxR2YvWDZUY3VOdWFOcmd3OFR6cE0rMThtRWV6?=
 =?utf-8?B?VGdWV0VzMStnTzJCNHZmbUhPTGpvMC8xK3B1OVdoNkdZM25aQThVc1ptLzR5?=
 =?utf-8?B?djVjak92bDFvYkRXc1FuYnlocFJ6OHlJeWtDNUpqdFBLeVljcWMwVVZXdmNs?=
 =?utf-8?B?KzVZQXZiMG04V1ArVnd1ODNyZklLbUZpb3hWcHBmUjgvVFJRc0NGM09DUTYx?=
 =?utf-8?B?YkVPMVlRakJYVFVvVFdXQ3FodUo4NHJ0bERzVUJ1N1lxS3N2M0VQTDdmRnFE?=
 =?utf-8?B?RXI1VU9xTTEwRmQrdkFFK2U1TkJ5Q1JvVjNtTjJ4M0FOcDhtUzIyVGNMVVJh?=
 =?utf-8?B?TmwwSmRZK1hWUVhHVi91ZHZIMkRnPT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <FDDC61659B3616468FDB1FF6A487D054@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 14d059f4-3a05-4d1b-a4a7-08d9f2de6a57
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Feb 2022 12:58:52.9488
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: XDfvtZGDA5FRGA14LXpVOB0054mjGDSCiZc8fXV28VCL+h3fIb2kanBODYZF5KIQSiUWp8HKqtTYukAH0Hz259taU0Uebgp3XW0E+IKbfjs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2428
X-OriginatorOrg: citrix.com

T24gMTgvMDIvMjAyMiAxMjoyNywgUm9nZXIgUGF1IE1vbm5lIHdyb3RlOg0KPiBPbiBGcmksIEZl
YiAxOCwgMjAyMiBhdCAxMjoyMTozNFBNICswMDAwLCBBbmRyZXcgQ29vcGVyIHdyb3RlOg0KPj4g
T24gMTgvMDIvMjAyMiAxMjowMCwgUm9nZXIgUGF1IE1vbm5lIHdyb3RlOg0KPj4+IEFkZCBhIHdv
cmtmbG93IHRoYXQgcGVyZm9ybXMgYSBidWlsZCBsaWtlIGl0J3MgZG9uZSBieSBvc3N0ZXN0DQo+
Pj4gQ292ZXJpdHkgZmxpZ2h0IGFuZCB1cGxvYWRzIHRoZSByZXN1bHQgdG8gQ292ZXJpdHkgZm9y
IGFuYWx5c2lzLiBUaGUNCj4+PiBidWlsZCBwcm9jZXNzIGlzIGV4YWN0bHkgdGhlIHNhbWUgYXMg
dGhlIG9uZSBjdXJyZW50bHkgdXNlZCBpbg0KPj4+IG9zc3Rlc3QsIGFuZCBpdCdzIGFsc28gcnVu
IGF0IHRoZSBzYW1lIHRpbWUgKGJpLXdlZWtseSkuDQo+Pj4NCj4+PiBUaGlzIGhhcyBvbmUgYmln
IGJlbmVmaXQgb3ZlciB1c2luZyBvc3N0ZXN0OiB3ZSBubyBsb25nZXIgaGF2ZSB0byBjYXJlDQo+
Pj4gYWJvdXQga2VlcGluZyB0aGUgQ292ZXJpdHkgdG9vbHMgdXAgdG8gZGF0ZSBpbiBvc3N0ZXN0
Lg0KPj4+DQo+Pj4gU3VnZ2VzdGVkLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0Bj
aXRyaXguY29tPg0KPj4+IFNpZ25lZC1vZmYtYnk6IFJvZ2VyIFBhdSBNb25uw6kgPHJvZ2VyLnBh
dUBjaXRyaXguY29tPg0KPj4+IC0tLQ0KPj4+ICAuZ2l0aHViL3dvcmtmbG93cy9jb3Zlcml0eS55
bWwgfCAzNSArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrDQo+Pj4gIDEgZmlsZSBj
aGFuZ2VkLCAzNSBpbnNlcnRpb25zKCspDQo+Pj4gIGNyZWF0ZSBtb2RlIDEwMDY0NCAuZ2l0aHVi
L3dvcmtmbG93cy9jb3Zlcml0eS55bWwNCj4+Pg0KPj4+IGRpZmYgLS1naXQgYS8uZ2l0aHViL3dv
cmtmbG93cy9jb3Zlcml0eS55bWwgYi8uZ2l0aHViL3dvcmtmbG93cy9jb3Zlcml0eS55bWwNCj4+
PiBuZXcgZmlsZSBtb2RlIDEwMDY0NA0KPj4+IGluZGV4IDAwMDAwMDAwMDAuLjEyZmM5Yzc4MmIN
Cj4+PiAtLS0gL2Rldi9udWxsDQo+Pj4gKysrIGIvLmdpdGh1Yi93b3JrZmxvd3MvY292ZXJpdHku
eW1sDQo+Pj4gQEAgLTAsMCArMSwzNSBAQA0KPj4+ICtuYW1lOiBDb3Zlcml0eSBTY2FuDQo+Pj4g
Kw0KPj4+ICsjIFdlIG9ubHkgd2FudCB0byB0ZXN0IG9mZmljaWFsIHJlbGVhc2UgY29kZSwgbm90
IGV2ZXJ5IHB1bGwgcmVxdWVzdC4NCj4+PiArb246DQo+Pj4gKyAgc2NoZWR1bGU6DQo+Pj4gKyAg
ICAtIGNyb246ICcxOCA5ICogKiBXRUQsU1VOJyAjIEJpLXdlZWtseSBhdCA5OjE4IFVUQw0KPj4+
ICsNCj4+PiAram9iczoNCj4+PiArICBjb3Zlcml0eToNCj4+PiArICAgIHJ1bnMtb246IHVidW50
dS1sYXRlc3QNCj4+PiArICAgIHN0ZXBzOg0KPj4+ICsgICAgLSBuYW1lOiBJbnN0YWxsIGJ1aWxk
IGRlcGVuZGVuY2llcw0KPj4+ICsgICAgICBydW46IHwNCj4+PiArICAgICAgICBzdWRvIGFwdC1n
ZXQgaW5zdGFsbCAteSB3Z2V0IGdpdCBiY2MgYmluODYgZ2F3ayBicmlkZ2UtdXRpbHMgXA0KPj4+
ICsgICAgICAgICAgaXByb3V0ZTIgbGliY3VybDQtb3BlbnNzbC1kZXYgYnppcDIgbGlicGNpLWRl
diBidWlsZC1lc3NlbnRpYWwgXA0KPj4+ICsgICAgICAgICAgbWFrZSBnY2MgbGliYzYtZGV2IGxp
YmM2LWRldi1pMzg2IGxpbnV4LWxpYmMtZGV2IHpsaWIxZy1kZXYgXA0KPj4+ICsgICAgICAgICAg
bGlibmN1cnNlczUtZGV2IHBhdGNoIGxpYnZuY3NlcnZlci1kZXYgbGlic3NsLWRldiBsaWJzZGwt
ZGV2IGlhc2wgXA0KPj4+ICsgICAgICAgICAgbGliYnoyLWRldiBlMmZzbGlicy1kZXYgZ2l0LWNv
cmUgdXVpZC1kZXYgb2NhbWwgbGlieDExLWRldiBcDQo+Pj4gKyAgICAgICAgICBvY2FtbC1maW5k
bGliIHh6LXV0aWxzIGdldHRleHQgbGlieWFqbC1kZXYgbGlicGl4bWFuLTEtZGV2IFwNCj4+PiAr
ICAgICAgICAgIGxpYmFpby1kZXYgbGliZmR0LWRldiBjYWJleHRyYWN0IGxpYmdsaWIyLjAtZGV2
IGF1dG9jb25mIGF1dG9tYWtlIFwNCj4+PiArICAgICAgICAgIGxpYnRvb2wgbGliZnVzZS1kZXYg
bGlibHptYS1kZXYgbmluamEtYnVpbGQgXA0KPj4+ICsgICAgICAgICAga3BhcnR4IHB5dGhvbjMt
ZGV2IHB5dGhvbjMtcGlwIGdvbGFuZyBweXRob24tZGV2IGxpYnN5c3RlbWQtZGV2DQo+PiBXZSBk
cm9wcGVkIGdldHRleHQgYXMgYSBkZXBlbmRlbmN5IGEgZmV3IHJlbGVhc2VzIGFnbywgYW5kIHdl
IGRvbid0IG5lZWQNCj4+IHB5dGhvbjMtcGlwIGVpdGhlci7CoCBDYW4gZml4IG9uIGNvbW1pdC4N
Cj4+DQo+Pj4gKyAgICAtIHVzZXM6IGFjdGlvbnMvY2hlY2tvdXRAdjINCj4+IEkgdGhpbmsgd2Ug
d2FudA0KPj4NCj4+IC0gdXNlczogYWN0aW9ucy9jaGVja291dEB2Mg0KPj4gwqAgd2l0aDoNCj4+
IMKgwqDCoCByZWY6IHN0YWdpbmcNCj4gSSd2ZSBhc3N1bWVkIHdlIHdhbnRlZCBtYXN0ZXIgYXMg
dGhhdCBhdCBsZWFzdCBmdW5jdGlvbmFsIHBlciB0aGUNCj4gdGVzdGluZyBkb25lIGluIG9zc3Rl
c3QuIEJ1dCBtYXliZSBpdCdzIGluZGVlZCBiZXR0ZXIgdG8gdXNlIHN0YWdpbmcNCj4gaW4gb3Jk
ZXIgdG8gY2F0Y2ggaXNzdWVzIGJlZm9yZSB0aGV5IHJlYWNoIG1hc3Rlci4NCg0KSUlSQywgT1NT
VGVzdCBoYXMgQ292ZXJpdHkgZm9sbG93aW5nIHNtb2tlLCBidXQgdGhlc2UgZGF5cyB3ZSdyZSBm
YXINCmJldHRlciBhcmUgbm90IGJyZWFraW5nIHRoZSBidWlsZCBub3cgdGhhdCBHaXRsYWIgQ0kg
aXMgaW4gcGxhY2UuDQoNCkJ1dCBpdCBtaWdodCBiZSBwcnVkZW50IHRvIGNoZWNrIHRoYXQgaWYg
dGhlIGJ1aWxkIGZhaWxzLCB3ZSBkb24ndA0Kc3VibWl0IGEgcGFydGlhbCByZXN1bHQgdG8gQ292
ZXJpdHkuDQoNClRoZSBkaWZmZXJlbmNlIGJldHdlZW4gc3RhZ2luZyBhbmQgbWFzdGVyIGlzIHB1
cmVseSBob3cgZWFybHkgd2UgZ2V0IHRoZQ0KcmVwb3J0Lg0KDQp+QW5kcmV3DQo=


From xen-devel-bounces@lists.xenproject.org Fri Feb 18 13:18:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 18 Feb 2022 13:18:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275395.471231 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL39A-0001Kp-4C; Fri, 18 Feb 2022 13:18:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275395.471231; Fri, 18 Feb 2022 13:18:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL39A-0001Ki-16; Fri, 18 Feb 2022 13:18:04 +0000
Received: by outflank-mailman (input) for mailman id 275395;
 Fri, 18 Feb 2022 13:18:03 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=6Z2s=TB=citrix.com=prvs=041b9fbab=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nL399-0001Kc-8j
 for xen-devel@lists.xenproject.org; Fri, 18 Feb 2022 13:18:03 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 318bc14b-90bd-11ec-8eb8-a37418f5ba1a;
 Fri, 18 Feb 2022 14:18:01 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 318bc14b-90bd-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645190282;
  h=from:to:cc:subject:date:message-id:mime-version:
   content-transfer-encoding;
  bh=LAVCDmvleJ/ZQlUX8xw4BAImML8/qd6o1PHt/BckBzY=;
  b=SsjGL2bX+w3QC5hOW2+l/EnBVBOj10+8DD0lGeYUww2xfZEWcsFVqjS9
   XFbbMaFJVj09FAKPuLPgAAqmHFAKdsy015uFVMJK4RWqGr52MPJjYjQKu
   WEMpI3Vs1vpTeCNnJ1O+MULJkH8gGZ7Aff2ZXt+kE9MPidKPCBFIexmpz
   I=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 64517396
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:1TTpRqiYBs8Go3kaefnqaQj+X161ThAKZh0ujC45NGQN5FlHY01je
 htvDzrUaavca2ejL9knOY3n8UsHu5XczIdlTgNt+ytmESMb9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0Iz8wIFqtQw24LhWVrd4
 YqaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV
 efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9
 TlDiXC/YToTBbaWlO0eaUlVPB1jE7Vo4br6AWfq5KR/z2WeG5ft6/BnDUVwNowE4OdnR2pJ8
 JT0KhhUMErF3bjvhuvmFK883azPL+GyVG8bklhmwSvUErANRpfbTr+RzdRZwC0xloZFGvO2i
 88xN2YyNUubMkMn1lE/OLI6su7y1nfFbBYf93Kfh6cc4Er+w1kkuFTqGIWMIYHbLSlPpW6Dv
 X7P9Wn9BhAcNfScxCCD/3bqgfXA9QvZco8PELyz9tZxnUaegGcUDXU+Sl+TsfS/zEmkVLp3O
 0ESvyYjs6U23EiqVcXmGQ21pmaeuRwRUMYWFPc1gCmGw7DY5AuxDWEeQjlMLtchsacLqScCj
 wHT2YmzXHo27ePTGSn1GqqoQS2aBBIuNjUObCw+HQYq38TNuK8qiy/vUYM2eEKqteHdFTb1y
 jGMiSExgbQPkMIGv5mGEUD7byGE/caQEFNsjunDdif8t14iOtb5D2C9wQWDtZ59wJClok5tV
 ZTus+yX96gwAJ6Ej0Rhq81dTejyt55p3NAx6GOD/qXNFRzxqhZPnqgKuVmSwXuF1O5dKFcFh
 2eJ5GtsCGd7ZifCUEOOS9vZ5z4W5abhD8/5cfvfc8BDZJN8HCfeon0zPBTMhzGxzhF2+U3aB
 Xt9WZ/9ZZr9If46pAdaus9HieN7rszA7Ti7qW/HI+SPjuPFOS/9pUYtO1qSdOEphJ5oUy2Om
 +uzw/Cikk0FOMWnO3G/2ddKcTgicChqbbir+pc/XrPSfWJb9JQJVqa5LUUJINc+wcy4V47go
 xmAZ6Ov4ACh3SaecV3SMBiOqtrHBP5CkJ7yBgR0VX7A5pTpSd3HAHs3H3fvQYQayQ==
IronPort-HdrOrdr: A9a23:hr6q6q5f9l2xoHeW7QPXwMTXdLJyesId70hD6qhwISY6TiX+rb
 HIoB17726RtN9/YhEdcLy7VJVoIkmskKKdg7NhXotKNTOO0ADDQb2KhbGSpQEIcBeeygcy78
 hdmtBFeb/NMWQ=
X-IronPort-AV: E=Sophos;i="5.88,378,1635220800"; 
   d="scan'208";a="64517396"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Doug Goldstein
	<cardoe@cardoe.com>, Wei Liu <wl@xen.org>, Anthony PERARD
	<anthony.perard@citrix.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Stefano Stabellini <sstabellini@kernel.org>, "Jan
 Beulich" <JBeulich@suse.com>
Subject: [PATCH] CI: Add gnu grep to alpine containers
Date: Fri, 18 Feb 2022 13:17:40 +0000
Message-ID: <20220218131740.30922-1-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

A forthcoming change is going to want more support than busybox's grep can
provide.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Doug Goldstein <cardoe@cardoe.com>
CC: Wei Liu <wl@xen.org>
CC: Anthony PERARD <anthony.perard@citrix.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Stefano Stabellini <sstabellini@kernel.org>
CC: Jan Beulich <JBeulich@suse.com>

I've already rebuilt the containers and confirmed that the build is still fine.
---
 automation/build/alpine/3.12.dockerfile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/automation/build/alpine/3.12.dockerfile b/automation/build/alpine/3.12.dockerfile
index 4ee3ddc12e52..4cce7ab926dc 100644
--- a/automation/build/alpine/3.12.dockerfile
+++ b/automation/build/alpine/3.12.dockerfile
@@ -26,6 +26,7 @@ RUN \
   # gettext for Xen < 4.13
   apk add gettext && \
   apk add git && \
+  apk add grep && \
   apk add iasl && \
   apk add libaio-dev && \
   apk add linux-headers && \
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Fri Feb 18 13:18:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 18 Feb 2022 13:18:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275397.471242 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL39W-0001hz-Bo; Fri, 18 Feb 2022 13:18:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275397.471242; Fri, 18 Feb 2022 13:18:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL39W-0001hq-8e; Fri, 18 Feb 2022 13:18:26 +0000
Received: by outflank-mailman (input) for mailman id 275397;
 Fri, 18 Feb 2022 13:18:25 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=6Z2s=TB=citrix.com=prvs=041b9fbab=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nL39U-0001Kc-Tn
 for xen-devel@lists.xenproject.org; Fri, 18 Feb 2022 13:18:25 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 3f039856-90bd-11ec-8eb8-a37418f5ba1a;
 Fri, 18 Feb 2022 14:18:23 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3f039856-90bd-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645190303;
  h=from:to:cc:subject:date:message-id:mime-version:
   content-transfer-encoding;
  bh=cOUWI3z94656wRQdu1HK/Pu/la0FR5XncqommOnx4q4=;
  b=BIJxFo+z5fV0NbsBrWgwltda+kZkqgNWMs2Nb6MO9MJJihEefJ1vmOiw
   ZNudYD5V2vnmNDbb2+tXgwCgZwoDpzQgFooKWTO5evMzbB8VrXvONcuPt
   4DZ2/swxBIyPqaOz1Sk9ArW4+a5giLevwLIYfwceTnNHt8yDMoE1jarkX
   w=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 64920608
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:hAdPgqJrSN3FHwFzFE+RzJUlxSXFcZb7ZxGr2PjKsXjdYENS12BUx
 2ZOXW+ObvaMMWvxKNl+PI7k/RwBuMDRy4diTVFlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA180IMsdoUg7wbRh2Nc42YHR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 PRkiaXpVjolBJTvgcYaXhVROSdSF5QTrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBODtMJkSpTdLyjbBAOx9aZvCX7/L9ZlT2zJYasVmQ6qPP
 ZJHMWoHgBLoPjsUJXUlCM4EmtyTi3LAegRxoVWFjP9ii4TU5FMoi+W8WDbPQfSVQe1Fk0Deo
 XjJl0ziGQ0TPtGbzTuD81qvi/XJkCe9X5gdfJWo+/gvjFCNy2g7DBwNSUD9sfS/klS5Wd9UN
 woT4CVGhaM77kCsQ/H2Vge0p3PCtRkZM+e8CMVjtlvLkPCNpV/EWC5UFVatdeDKqucXbAATj
 0C0k+nQJiVNt7CZQFib2p2t+Gba1TcuEUcOYioNTA0g6tbloZ0ugh+ncuuPAJJZnfWuR2iun
 mniQDwWwuxK0JVVj/nTEUXv3mr0zqUlWDLZ8ek+soiNygpiLLCoaIWzgbQwxaYRdd3JJrVtU
 ZVtpiR/0AzsJc3c/MBuaL9UdF1M2xpjGGSN6bKIN8N8nwlBA1b5IehtDMhWfS+FyPosdz7ze
 1P0sghM/pJVN3bCRfYpP9/oUZhynPS+TI6NuhXogjxmO8kZmOivpnwGWKJt9zq1zBhEfV8XY
 v93jvpA/V5FUP86nVJats8W0KMxxzBW+I8gbcuT8vhT6pLHPCT9Ye5caDOmN7llhIvZ8FS92
 4sObKOilkQAONASlwGKqOb/23hRdiNlbX03wuQKHtO+zv1OQj95UKaJmet7E2Gn9owM/tr1E
 riGchcw4DLCabfvcG1mtlgLhGvTYKtC
IronPort-HdrOrdr: A9a23:Qo8hQqBH4OB/eublHemg55DYdb4zR+YMi2TC1yhKJyC9Ffbo8P
 xG/c5rsSMc5wxwZJhNo7y90cq7MBbhHPxOkOos1N6ZNWGM0gaVxelZnO3fKlbbehEWmNQz6U
 4ZSdkdNOHN
X-IronPort-AV: E=Sophos;i="5.88,378,1635220800"; 
   d="scan'208";a="64920608"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Doug Goldstein
	<cardoe@cardoe.com>, Wei Liu <wl@xen.org>, Anthony PERARD
	<anthony.perard@citrix.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Stefano Stabellini <sstabellini@kernel.org>
Subject: [PATCH] CI: Clean up alpine containers
Date: Fri, 18 Feb 2022 13:18:11 +0000
Message-ID: <20220218131811.31133-1-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

 * `apk --no-cache` is the preferred way of setting up containers, and it does
   shrink the image by a few MB.
 * Neither container needs curl-dev.
 * Flex and bison are needed for Xen, so move to the Xen block.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Doug Goldstein <cardoe@cardoe.com>
CC: Wei Liu <wl@xen.org>
CC: Anthony PERARD <anthony.perard@citrix.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Stefano Stabellini <sstabellini@kernel.org>

I've already rebuilt the containers and confirmed that the build is still fine.
---
 automation/build/alpine/3.12-arm64v8.dockerfile | 69 ++++++++++-------------
 automation/build/alpine/3.12.dockerfile         | 75 +++++++++++--------------
 2 files changed, 65 insertions(+), 79 deletions(-)

diff --git a/automation/build/alpine/3.12-arm64v8.dockerfile b/automation/build/alpine/3.12-arm64v8.dockerfile
index a1ac9605959e..006cdb3668b3 100644
--- a/automation/build/alpine/3.12-arm64v8.dockerfile
+++ b/automation/build/alpine/3.12-arm64v8.dockerfile
@@ -8,46 +8,39 @@ RUN mkdir /build
 WORKDIR /build
 
 # build depends
-RUN \
-  # apk
-  apk update && \
+RUN apk --no-cache add \
   \
   # xen build deps
-  apk add argp-standalone && \
-  apk add autoconf && \
-  apk add automake && \
-  apk add bash && \
-  apk add curl && \
-  apk add curl-dev && \
-  apk add dev86 && \
-  apk add dtc-dev && \
-  apk add gcc  && \
+  argp-standalone \
+  autoconf \
+  automake \
+  bash \
+  bison \
+  curl \
+  dev86 \
+  dtc-dev \
+  flex \
+  gcc \
   # gettext for Xen < 4.13
-  apk add gettext && \
-  apk add git && \
-  apk add iasl && \
-  apk add libaio-dev && \
-  apk add libfdt && \
-  apk add linux-headers && \
-  apk add make && \
-  apk add musl-dev  && \
-  apk add ncurses-dev && \
-  apk add patch  && \
-  apk add python3-dev && \
-  apk add texinfo && \
-  apk add util-linux-dev && \
-  apk add xz-dev && \
-  apk add yajl-dev && \
-  apk add zlib-dev && \
+  gettext \
+  git \
+  iasl \
+  libaio-dev \
+  libfdt \
+  linux-headers \
+  make \
+  musl-dev  \
+  ncurses-dev \
+  patch  \
+  python3-dev \
+  texinfo \
+  util-linux-dev \
+  xz-dev \
+  yajl-dev \
+  zlib-dev \
   \
   # qemu build deps
-  apk add bison && \
-  apk add flex && \
-  apk add glib-dev && \
-  apk add libattr && \
-  apk add libcap-ng-dev && \
-  apk add pixman-dev && \
-  \
-  # cleanup
-  rm -rf /tmp/* && \
-  rm -f /var/cache/apk/*
+  glib-dev \
+  libattr \
+  libcap-ng-dev \
+  pixman-dev \
diff --git a/automation/build/alpine/3.12.dockerfile b/automation/build/alpine/3.12.dockerfile
index 4cce7ab926dc..22cad2524972 100644
--- a/automation/build/alpine/3.12.dockerfile
+++ b/automation/build/alpine/3.12.dockerfile
@@ -8,49 +8,42 @@ RUN mkdir /build
 WORKDIR /build
 
 # build depends
-RUN \
-  # apk
-  apk update && \
+RUN apk --no-cache add \
   \
   # xen build deps
-  apk add argp-standalone && \
-  apk add autoconf && \
-  apk add automake && \
-  apk add bash && \
-  apk add curl && \
-  apk add curl-dev && \
-  apk add dev86 && \
-  apk add gcc  && \
-  apk add g++ && \
-  apk add clang  && \
+  argp-standalone \
+  autoconf \
+  automake \
+  bash \
+  bison \
+  clang \
+  curl \
+  dev86 \
+  flex \
+  g++ \
+  gcc \
   # gettext for Xen < 4.13
-  apk add gettext && \
-  apk add git && \
-  apk add grep && \
-  apk add iasl && \
-  apk add libaio-dev && \
-  apk add linux-headers && \
-  apk add make && \
-  apk add musl-dev  && \
-  apk add libc6-compat && \
-  apk add ncurses-dev && \
-  apk add patch  && \
-  apk add python3-dev && \
-  apk add texinfo && \
-  apk add util-linux-dev && \
-  apk add xz-dev && \
-  apk add yajl-dev && \
-  apk add zlib-dev && \
+  gettext \
+  git \
+  grep \
+  iasl \
+  libaio-dev \
+  libc6-compat \
+  linux-headers \
+  make \
+  musl-dev  \
+  ncurses-dev \
+  patch  \
+  python3-dev \
+  texinfo \
+  util-linux-dev \
+  xz-dev \
+  yajl-dev \
+  zlib-dev \
   \
   # qemu build deps
-  apk add bison && \
-  apk add flex && \
-  apk add glib-dev && \
-  apk add libattr && \
-  apk add libcap-ng-dev && \
-  apk add ninja && \
-  apk add pixman-dev && \
-  \
-  # cleanup
-  rm -rf /tmp/* && \
-  rm -f /var/cache/apk/*
+  glib-dev \
+  libattr \
+  libcap-ng-dev \
+  ninja \
+  pixman-dev \
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Fri Feb 18 13:23:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 18 Feb 2022 13:23:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275412.471264 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL3E5-0003Qm-17; Fri, 18 Feb 2022 13:23:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275412.471264; Fri, 18 Feb 2022 13:23:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL3E4-0003Qf-UW; Fri, 18 Feb 2022 13:23:08 +0000
Received: by outflank-mailman (input) for mailman id 275412;
 Fri, 18 Feb 2022 13:23:06 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=6Z2s=TB=citrix.com=prvs=041b9fbab=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nL3E2-0003QZ-LW
 for xen-devel@lists.xenproject.org; Fri, 18 Feb 2022 13:23:06 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e6b9f0ee-90bd-11ec-8eb8-a37418f5ba1a;
 Fri, 18 Feb 2022 14:23:05 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e6b9f0ee-90bd-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645190585;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=ArgSZLkCL7gUMLOr3Uj2rcxDXVSxdO5cj6dGuKr9+oA=;
  b=ZSR7xEnGFcHBcQxUacNAAn82gU7LPuUX6V3zG/vC7Z+6evn6w5o1ODcA
   yKBC1AKVNGxxJwCWG4BkLDuRpXs0ZK0+i1T16i1pXdJG87nhhPfYfUtgk
   Bxt0FDXs9mBXMDtYfUYTMEJKyUskAXDuXptFNCrTB39jzqDWA107zujkI
   c=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 66760077
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:QcfR2qIkbC37QXRyFE+R85UlxSXFcZb7ZxGr2PjKsXjdYENS3jRUm
 zEfXD2GMv6Jamqncop0bdy18E5X7JDRm4c1HABlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA180IMsdoUg7wbRh2Nc42YHR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 O5B6qeJT19yAqDdlb8hdUFUOSRSE7ITrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBODtMJkSpTdLyjbBAOx9aZvCX7/L9ZlT2zJYasVmQ6iBO
 ZJBNmUHgBLoOgB2JmceLMMCt6SrrUDGLTx3hmnNuv9ii4TU5FMoi+W8WDbPQfSVQe1Fk0Deo
 XjJl0zpDxdfONGBxD6t9nO3mvSJjS79QJgVFrCz6rhtmlL77m4ZBQASVFC7ieKkkUP4UNVaQ
 2Qd/yF/84Ap7kelCN/wQ3WFTGWs50BGHYAKSqtjtV/LmvG8Dxul6nYsdTIeU+Ug7JQKSC0nj
 WOvx9/DABBBr+jAIZ6CzYu8oTS3MCkTCGYNYy4YUAcIi+XeTJEPYgHnFYg6TvPs5jHhMXSpm
 m3R8nBi71kGpZNTj82GEUb7byVAT3QjZio8/U3pU22s9WuVj6b1NtXzuTA3ARutRbt1r2VtX
 lBYyqByD8hUVPlhcRBhps1UTdlFAN7fbVXhbaZHRcVJythU0yfLkXpsyD9/Plx1Fc0PZCXkZ
 kTe0SsIusMOZSH2Nf4rPdvrYyjP8UQGPY20PhwzRoATCqWdiSfdpH0+DaJu9zuFfLcQfVEXZ
 s7ALJfE4YcyAqV71jumL9rxIpdwrh3SMVj7HMihpzz+iOL2TCfMFd8tbQvfBshkvfjsiFiEr
 L5i2z6ilkw3vBvWOXKMr+b+7DkicBAGOHwBg5YJLrXaelI+QgnMyZb5mNscRmCspIwM/s/g9
 XChQE5Ijl35gHzMMwKRbX5/LrjoWP5CQbgTZ0TA4X7AN6AfXLuS
IronPort-HdrOrdr: A9a23:xV2Gnq3HyL9l2CO89qZdUQqjBRZyeYIsimQD101hICG9Lfb2qy
 n+ppgmPEHP5Qr5AEtQ5OxpOMG7MBbhHQYc2/heAV7QZnibhILOFvAi0WKC+UyuJ8SazIBgPM
 hbAtFD4bHLfDtHZIPBkXOF+rUbsZm6GcKT9J/jJh5WJGkAAcAB0+46MHfhLqQffngdOXNTLu
 v52iMznUvHRZ1hVLXdOpBqZZmgm/T70LbdJTIWDR8u7weDyRmy7qThLhSe1hACFxtS3LYL6w
 H+4k/Ez5Tml8v+5g7X1mfV4ZgTssDm0MF/CMuFjdVQAinwizyveJ9qV9S5zXIISaCUmRMXee
 v30lAd1vdImjXsl6aO0ELQMjzboXITArnZuAelaDXY0JfErXkBerV8bMpiA2XkAgwbzYxBOe
 twrhKkX9A8N2KwoA3to9fPTB1kjUyyvD4rlvMSlWVWVc8EZKZWtpF3xjIeLH4sJlOz1GkcKp
 gkMCgc3ocjTXqKK3TC+mV/yt2lWXo+Wh+AX0gZo8SQlzxbhmpwwUcUzNEW2i5ozuNwd7BUo+
 Dfdqh4nrBHScEbKap7GecaWMOyTmjAWwjFPm6eKUnuUKsHJ3XOoZjq56hd3pDmRLUYiJ8p3J
 jRWlJRsmA/P0roFM2VxZVOtgvARW2sNA6dg/22J6IJzIEUaICbQxFreWpe5PdI+c9vcfEzc8
 zDTa5rPw==
X-IronPort-AV: E=Sophos;i="5.88,378,1635220800"; 
   d="scan'208";a="66760077"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=BOljm7JtnDn9OBfgWtza9Md80vRZPemG13QihsAeslDSZfPbFfk4jWauof5+9wpn7BaG3vXmVzQdZBJ2X8qYTZhn1AyRGg1U1jxaM2J3veDJ2ATJPYlKjwC4oc/bDHX7GIw8KXfg/5oltaugzsO9jQJpBOZt4+oPeD/QTEU+IXfpMDUTiRIuFEZ7mdcPpjyPRPIBEix4aTO/bECl3KAVAIHEWxpFkNERW+YkVqimDaBPvQJ5PtIoTmZX5snhuKu7CG/9+6XDRGoOlLbotei/kEkQ3wiVz4/bkhQJppeRD/N1MgGmH5z2LUq4a0aZNp7rlT3KNm88XOm7p0I/uffQ9A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ArgSZLkCL7gUMLOr3Uj2rcxDXVSxdO5cj6dGuKr9+oA=;
 b=L9LxzMeuMcZVmmY0/ttiruOVJxiET2EIiU1JjA2IvkhP5S2FvXr7rHIqSxw78j1rG5+eW6AwXaF2ABVkbz5S7QrbBHDWQlKA2LRvPHQqDKoIXZ1bTDthG+2pwyW1BWZKTknw76KeLNMAa6mDmZ65qIEW+PrqNVxSM8OZSeYXyV5dGmCUN+4NnBAUvkH5OJJdD3g9DqQBLHA6tZ2knlK0HhpRug8s6etZ5tDV8OnvhzrLC3i1XUWZxXw/tEnVOFj2LFYKe0K/7FIXbTcU/XtnVWE7IMe91oVrOWKCnF78HYC64MLgBAr3kNiAvbw3waByDPRh4EsCxNLDJ6tzokANJw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ArgSZLkCL7gUMLOr3Uj2rcxDXVSxdO5cj6dGuKr9+oA=;
 b=LUosB1eyVsCINKSGW+uH0j+OTysnDPWVGd0+TF5Ts1rmRVzOOiW802lfuO5h4vH9u1j7mABlRcZ7EX1OdJyYnkpxe5iHHFBWrlFMxDmuy5Y/HEAcKOWH6LthlersjjuD3Ga0vcKV/RvB7kDAxVOCvI6vQvgnjMOJpo7wCTPqvKg=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>, Andrew Cooper <amc96@srcf.net>
CC: Wei Liu <wl@xen.org>, Roger Pau Monne <roger.pau@citrix.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: Ping: [PATCH] x86: replace a few do_div() uses
Thread-Topic: Ping: [PATCH] x86: replace a few do_div() uses
Thread-Index: AQHYB5LijlOnVfNOdkqZn9v3W4GnqqxfHNSAgAABroCAOhh0AIAATy4A
Date: Fri, 18 Feb 2022 13:22:58 +0000
Message-ID: <48fe4bb7-e02d-520f-a023-2c762fdbadfd@citrix.com>
References: <01baee92-9d7f-5a2c-d63f-1de390bc10e2@suse.com>
 <a5af3a6a-da51-2624-622e-2566c8db7dce@srcf.net>
 <f4dd528a-d1e0-f516-bb7d-f1ec01abc3d5@suse.com>
 <66c63b32-aca9-0fb8-ea6d-8b91c23eed9e@suse.com>
In-Reply-To: <66c63b32-aca9-0fb8-ea6d-8b91c23eed9e@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: bc55fef3-f378-4147-3187-08d9f2e1c83a
x-ms-traffictypediagnostic: CY1PR03MB2315:EE_
x-microsoft-antispam-prvs: <CY1PR03MB23156C45A800EA5978F0E456BA379@CY1PR03MB2315.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: K4H1GqRNfkCLMqhKgMMllV9HKO/P0Kvtmtd28BIMzaqroZs9Ysc+8dz5EQy2znOOht0nIk6o33BeWDvQjyzPVGr1btbId8f/djoMr9KalCiC/O1FodhqveAYLxjpeqOJll3zlvWk3QIdoBoDpmbo3d2f8lD6P/TZIPCDta8WO6XWfjhnchPjWP9W/Fy09p8TmZg/f5mifs+rp8QpHMarBM9+X85jpEi8QX6murYdpMLH0VGv3aTiEl8DncqsBEKjaUy7dCw9UNviWYjVYD1QwQNBk76AIEyk4rT7ywIj9gYa5kYiJ5M4unS0j4Zld5RdQK1+tznVoFldXXiscV+jUsV5QjVXLVfJy0pFtoM9vQiXpgQHNZXCflgI1Kp6z06USEtQdXHyMJfMAl6sZyjZ+LHlNI3ctg1K9F4p5ymRS2WNjDLvDpL0gIq3C2pkEFeSAoMZKhv8Ipf1g7bqkEFYqqtiPDHwjyyD9RRftBDx5A2kEc/JVUWp/zd8vJ8AmaDw1sSjdI4JhxamcOxxGwKd1lM1qc3FRCXsBR8QOEMeXCMTCd+U5V1vPfbG99Jh5iIgoFFfyp5shKF7kyrJ0mrEuAHYJZCoNiaOVJriSf4DkYXXckf7SjfRpmI3vhhy02MvQLIwg5uKIjfhN2yf4K+ekvPDVVHUvFkGbTj4/da0eCw/OuX0nK1kRNOCMNM3hHbWGAFcykcThY3ptFGOHmC1HwoWlIt21dslt7hOdU4EPxlN3irBu6/0cfDr7PATw0h7e0nDTNQAfXwNUh91JwO//g==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(36756003)(31686004)(83380400001)(186003)(26005)(31696002)(2616005)(6512007)(8676002)(86362001)(71200400001)(2906002)(6486002)(6506007)(508600001)(53546011)(82960400001)(54906003)(66556008)(66476007)(38100700002)(76116006)(66946007)(66446008)(122000001)(5660300002)(110136005)(64756008)(316002)(91956017)(38070700005)(4326008)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?UEl2OXVkZEVRWUxZbXhPYzg4Ylk2b25tRkJtbWpZREZVZUZ0VU5PcnFxemlQ?=
 =?utf-8?B?M2szUlhBYVo1N1hlbnVNL2NFazFpVXNDSGZ3cFZXWExRdVJ0WVhDS2QzajNE?=
 =?utf-8?B?bmh0SHZwUGdEZUQ2eG1KSWRpYkNOZnlZcDFGSHMxMklMWTEzU1U0YTJOQWRt?=
 =?utf-8?B?VkwyY0UyVi9uOGZHV0xSNm91N24xdzZhZkxYOG83WVFONUc4WlJzeTFuZVBY?=
 =?utf-8?B?MXhva3hidGlabUdsYUN0dCtsa2tiV2NSTXNNQlE0VTloeWM5dlUxenhLYndO?=
 =?utf-8?B?UVlNSkc4dEUyYkU3dWNnK0hFbzhjZW1MNE43clpMSjd2SU9aeW1aOENiQ2h1?=
 =?utf-8?B?eW5acUpFQUZtNExvVFZZaWNUQ3hIMGl3SUNkUFRqMEhoclR6ampUTVVwOFda?=
 =?utf-8?B?aFRZQWZHNnRiNlU1N2NFRXUzQ3pVM09aVWhrNFkza1o4L1Bkakk3M1NyaFpY?=
 =?utf-8?B?dDVncC91T1RROUxSdFlPTHJhcklwNmNRRTEyejhUa1FZamUzNmtmVjlWc2Nt?=
 =?utf-8?B?QVJrZ2lzem14dDdUVy9GS2o2dFZzT09VSDlWSUVTdnNLMzMrdUdCeFZaSU15?=
 =?utf-8?B?bDJKWi9tcllBd2t4Y3lPNysrV0E4NUI5S2tnU0dQNU12TitsaUxEbGc0cEND?=
 =?utf-8?B?cXczRi80RCtJcmRsNUszMmhzMlp6OVA4MmVmT2JMTEFtcTcxYllaUUdrSnYy?=
 =?utf-8?B?V3V5SUIzc1MrWUI1d1VWaEp3eWVvM2RaMTJGYWdhTkNwMW1QWFYzNEhreXNT?=
 =?utf-8?B?M05CbDVzYy9QeEMvZGg0cFVMdFFEWHp2eGNzMFB1WlhUMTFDR2hWdVMraUZ4?=
 =?utf-8?B?TmtRZ2ZkaUR2Rks0K1hyK0J5endaYVU0NDlDcWl0YVJIc2hQQXByaVBqNTJm?=
 =?utf-8?B?R1VhNXdyU3p4YkRQa3I0Q0VRUGtrNmU5S2hNVzc4eTB1MUJYcjhwUU0ycTZW?=
 =?utf-8?B?MlJlVHFIMUxjcUQ5ZmJ2K3ZnZ0paS2VHYUxpUEw1Y0lLL250am5MbmtydjVQ?=
 =?utf-8?B?TDNRZmJueUFtRDVwc3VaVjRhazlwbDQ2M0lBTzRzbVExVGgwbFAzcThyZGdK?=
 =?utf-8?B?eUhkejBBR1JCQjUvTjNwUlNsUlBQQksySWVrSFMxQVNTbVllVlozZk5lL2s3?=
 =?utf-8?B?UTVJRXcrMzB0Y1hIS3lKc0pxNXBGeGx4eUVPajVwY2N1a3pVQ1Y1aktrZjg3?=
 =?utf-8?B?MFk2akxJdmh0b1o4bUlqeE5VOHFiUUlCY1RJcGdTZExNdFNuS2M5RDdRNkpW?=
 =?utf-8?B?ZW9GMDhCRi9VNUVyb0Vta3REZW4vQTBMVk9NOHJkcW9ocmRpSlpMRHRJZitw?=
 =?utf-8?B?a05yNEkzbXdXYUZmOUcxYmZ5S1JFRlZySFA0dThBN1MxMXRrRDN5cXlNVVFW?=
 =?utf-8?B?TTQ0WlNabWMxN0hva0VqcEs3YnhsQy9DUzNSVS9xMzFGS1RORDM4cFdCU1Mx?=
 =?utf-8?B?c2JOWVZzT2Vyb0p2UCtPVDd5RGJYMnQ0b25RQ0NOQzYvZlM2bDNoeHN4ZUUx?=
 =?utf-8?B?QkdlcWRjU0dzVyttcm40OUxZdmZWZTNBYjRjQnFaUG53WkRSbWNVYTZyRFFL?=
 =?utf-8?B?QTZkalFQcmE1YWxhcyswdG95MFo4cDFqcElQd0VxNDl6bWV1TTdtNWxLZkxV?=
 =?utf-8?B?U3ljS0NwUmFQVkhCNWk1KzJrN25aVEhjZExDbWFCZm5INUVOeXV1dXFxNzBP?=
 =?utf-8?B?SEFvdWhoZThtUVR0NUNEWVgySXRRd3pkZlF1MU9CWUtJQ2g3Vk9kVnI2b3B1?=
 =?utf-8?B?cVBaOTZkaTJJeG00bVBkV3luTDhNL01nL3U4Mlg1d2x6UzRRSGZSbUhzN0lE?=
 =?utf-8?B?ZXBnZldKUUZvL05VNHVnMyttV3pDbWJkNnVlRGI4eE9jODU2MlU0SFNhWDJw?=
 =?utf-8?B?bDRORGJWSFF2cTc1eGlZanZ0bTZMWjRmajk3R1haT0JHdkhmSVA0ajh0ZDZQ?=
 =?utf-8?B?NndiUkg2dnVwS1pjMDJoR1ZEVEtSMUkwbnVIMlFHeVYvV3JXTllIdm5tMDlC?=
 =?utf-8?B?Zk9jQXVDZHZiYXlsalJjZ3dWZFdxTjRxekVNQk9Qd1d0d2RlTXBPUFV6bkMz?=
 =?utf-8?B?aTI0NWkrbldaTmVZN3FORHZDcjZnQTRoVkZuQ01ZWHRnRVc4cHYwSnNXU0dt?=
 =?utf-8?B?Zy9XcGNjL2h0V2E5QWY5NDhQUWlDUzc0aTlJZklLT2V6dmN6MHJmWmJLRFMv?=
 =?utf-8?B?YUwvczBEcVVPQndLQTJOQUVNeDJrRm9jL0xsOUR6VEQyRXNhNm9VN01iZGI3?=
 =?utf-8?B?d2ltWjdYWEo3ZDJROFhNRHpVR09RPT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <7AF4D9FED1FCDD488F8E8A1B8ED6C495@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bc55fef3-f378-4147-3187-08d9f2e1c83a
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Feb 2022 13:22:58.8893
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: e1kKPxf24NDOi2J6JThtM8wfbL52YgG7YKZaxhVpaFJUdaumtiW5G7B2ULlrTlrV1smP1ucFv2vXsLxKkstMK580cALT0KezEjjist7gH3g=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR03MB2315
X-OriginatorOrg: citrix.com

T24gMTgvMDIvMjAyMiAwODozOSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDEyLjAxLjIwMjIg
MTA6MjgsIEphbiBCZXVsaWNoIHdyb3RlOg0KPj4gT24gMTIuMDEuMjAyMiAxMDoyMiwgQW5kcmV3
IENvb3BlciB3cm90ZToNCj4+PiBPbiAxMi8wMS8yMDIyIDA5OjAwLCBKYW4gQmV1bGljaCB3cm90
ZToNCj4+Pj4gV2hlbiB0aGUgbWFjcm8ncyAicmV0dXJuIHZhbHVlIiBpcyBub3QgdXNlZCwgdGhl
IG1hY3JvIHVzZSBjYW4gYmUNCj4+Pj4gcmVwbGFjZWQgYnkgYSBzaW1wbHkgZGl2aXNpb24sIGF2
b2lkaW5nIHNvbWUgb2JmdXNjYXRpb24uDQo+Pj4+DQo+Pj4+IEFjY29yZGluZyB0byBteSBvYnNl
cnZhdGlvbnMsIG5vIGNoYW5nZSB0byBnZW5lcmF0ZWQgY29kZS4NCj4+Pj4NCj4+Pj4gU2lnbmVk
LW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KPj4+IEkgbGlrZSB0aGlz
IGNoYW5nZSBpbiBwcmluY2lwbGUsIGJ1dCBzZWUgYmVsb3cuDQo+Pj4NCj4+PiBkb19kaXYoKSBu
ZWVkcyB0byBiZSBkZWxldGVkLCBiZWNhdXNlIGl0J3MgZmFyIHRvbyBlYXN5IHNjcmV3IHVwLsKg
IEF0IGENCj4+PiBiYXJlIG1pbmltdW0sIGl0IHNob3VsZCBiZSByZXBsYWNlZCB3aXRoIGEgc3Rh
dGljIGlubGluZSB0aGF0IHRha2VzIGl0J3MNCj4+PiBmaXJzdCBwYXJhbWV0ZXIgYnkgcG9pbnRl
ciwgYmVjYXVzZSB0aGVuIGF0IGxlYXN0IGV2ZXJ5IGNhbGxzaXRlIHJlYWRzDQo+Pj4gY29ycmVj
dGx5IGluIHRlcm1zIG9mIHRoZSBDIGxhbmd1YWdlLg0KPj4gVGhhdCBvdWdodCB0byBiZSBhIDJu
ZCBzdGVwLCByZXF1aXJpbmcgYWdyZWVtZW50IHdpdGggQXJtIGZvbGtzIChhbmQNCj4+IGFkanVz
dG1lbnRzIHRvIHRoZWlyIGNvZGUpLg0KPj4NCj4+Pj4gLS0tIGEveGVuL2FyY2gveDg2L3RpbWUu
Yw0KPj4+PiArKysgYi94ZW4vYXJjaC94ODYvdGltZS5jDQo+Pj4+IEBAIC02MTAsOCArNjEwLDcg
QEAgc3RhdGljIHVpbnQ2NF90IHhlbl90aW1lcl9jcHVfZnJlcXVlbmN5KA0KPj4+PiAgICAgIHN0
cnVjdCB2Y3B1X3RpbWVfaW5mbyAqaW5mbyA9ICZ0aGlzX2NwdSh2Y3B1X2luZm8pLT50aW1lOw0K
Pj4+PiAgICAgIHVpbnQ2NF90IGZyZXE7DQo+Pj4+ICANCj4+Pj4gLSAgICBmcmVxID0gMTAwMDAw
MDAwMFVMTCA8PCAzMjsNCj4+Pj4gLSAgICBkb19kaXYoZnJlcSwgaW5mby0+dHNjX3RvX3N5c3Rl
bV9tdWwpOw0KPj4+PiArICAgIGZyZXEgPSAoMTAwMDAwMDAwMFVMTCA8PCAzMikgLyBpbmZvLT50
c2NfdG9fc3lzdGVtX211bDsNCj4+Pj4gICAgICBpZiAoIGluZm8tPnRzY19zaGlmdCA8IDAgKQ0K
Pj4+PiAgICAgICAgICBmcmVxIDw8PSAtaW5mby0+dHNjX3NoaWZ0Ow0KPj4+IGRvX2RpdigpJ3Mg
b3V0cHV0IGlzIGNvbnN1bWVkIGhlcmUuwqAgSSBkb24ndCB0aGluayB0aGlzIGh1bmsgaXMgc2Fm
ZSB0bw0KPj4+IGNvbnZlcnQuDQo+PiBJZiBieSAib3V0cHV0IiB5b3UgbWVhbiBpdHMgInJldHVy
biB2YWx1ZSIsIHRoZW4gaXQgY2xlYXJseSBpc24ndA0KPj4gY29uc3VtZWQuIEFuZCBJIGNvbnRp
bnVlIHRvIHRoaW5rIHRoYXQgSSBkaWQgZXhwcmVzcyBjb3JyZWN0bHkgdGhlDQo+PiBlZmZlY3Qg
ZG9fZGl2KCkgZGlkIGhhdmUgb24gImZyZXEiLg0KPiBJIHRoaW5rIEkgZGlkIGFkZHJlc3MgYm90
aCBwb2ludHMgKHRoZSBlYXJsaWVyIG9uZSB3YXMgYWN0dWFsbHkgbW9yZSBhDQo+IHJlbWFyayBp
bW8gYW55d2F5LCBub3QgYSByZXF1ZXN0IHRvIGNoYW5nZSBhbnl0aGluZyByaWdodCBpbiB0aGlz
IHBhdGNoKSwNCj4gc28gbWF5IEkgcGxlYXNlIGFzayBmb3IgYW4gYWNrIChvciBhIHJlc3BvbnNl
IGNsYXJpZnlpbmcgd2hhdCBJJ20gbm90DQo+IHVuZGVyc3RhbmRpbmcgaW4gd2hhdCB5b3UgaGF2
ZSBzYWlkKT8NCg0KTm8gLSB5b3UncmUgcmlnaHQuwqAgTXkgbWlzdGFrZS4NCg0KQWNrZWQtYnk6
IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+DQo=


From xen-devel-bounces@lists.xenproject.org Fri Feb 18 13:34:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 18 Feb 2022 13:34:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275419.471276 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL3Ot-0004wZ-0e; Fri, 18 Feb 2022 13:34:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275419.471276; Fri, 18 Feb 2022 13:34:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL3Os-0004wS-TN; Fri, 18 Feb 2022 13:34:18 +0000
Received: by outflank-mailman (input) for mailman id 275419;
 Fri, 18 Feb 2022 13:34:18 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=6Z2s=TB=citrix.com=prvs=041b9fbab=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nL3Os-0004wM-5m
 for xen-devel@lists.xenproject.org; Fri, 18 Feb 2022 13:34:18 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7734bf98-90bf-11ec-8723-dd0c611c5f35;
 Fri, 18 Feb 2022 14:34:16 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7734bf98-90bf-11ec-8723-dd0c611c5f35
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645191256;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=j5nv94RfPou9hdDxbDa1pE72QPialCW4xUJnRAqg0yE=;
  b=DN9a0SoIR+QLjJB7+YBFAKAQ6qPBy203Jk8b40Hd4yCVTktPQoh7wZ1W
   Ya2ow/fu1CNkl7mGRu6RJJ7HbAiV8v3SqmRcwUPrdzUTCfqHICD7cnVnJ
   2HxNVpESwWMsSJKTW1bCFNc/bt8MY24y/th3ChAMgaICPw/2/2oREOlEF
   8=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 66760967
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:2o/wDKMEvcvrzOrvrR23l8FynXyQoLVcMsEvi/4bfWQNrUpxhDIGm
 zMdWDyEP/iOazb0e9p3boiypx5VupaDn4QyGgto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FV8MpBsJ00o5wbZj294w2LBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zz
 9tgr4CaSRUQY4bUg8s+fERaESxxIvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALBc/nJo4A/FpnyinUF60OSpHfWaTao9Rf2V/cg+gQQ6mAP
 5tHNlKDajzDegJIEUgYVKs9v+n1mn7PQWRApGiK8P9fD2/7k1UqjemF3MDuUsOObdVYmACfv
 G2u13T0BFQWOcKSzRKB82mwnanfkCXjQoUQGbaksPlwjzW7xGYeFRkXXluTuuSihwi1XNc3F
 qAP0nNw9+5orhXtF4SjGU3jyJKZgvICc91ePvcmwgGf8/f/+x22JUdZTDxMZ8Nz4afaWgcW/
 lOOmtroAxlmv7uUVW+R+9+okN+iBcQGBTRcPHFZFGPp9/Gm+dhu1UyXEr6PBYbo1oWdJN3m/
 9ydQMHSbZ03hNVD6ai09Euvb9mE9smQFV5dCuk6swuYAuJFiGyNO93ABbvzt68owGOlor+p5
 Slsdy+2tr1mMH11vHbRKNjh5Znwjxp/DBXSgER0A74q/Cm39niocOh4uW8ieR4zbp5VJWGwO
 ic/XD+9ArcKbRNGioctPuqM5zkCl/C8RbwJqNiPBjaxXnSBXFDep3w/DaJh92vsjFItgckC1
 WSzKq6R4YIhIf0/llKeHr5FuZdyn3xW7T6DFPjTkkX8uZLDNSH9dFvwGAbXBgzPxPjf+1u9H
 hc2H5bi9iizp8WkPHGMqNZLdQpiwLpSLcmelvG7v9Wre2JOMGogF+XQ0fUmfYlklL5SjeDG4
 je2XUow9bY1rSevxdmiApy7VI7SYA==
IronPort-HdrOrdr: A9a23:qPaS36iYctj2n/cE+Qu6eCfPW3BQX3513DAbv31ZSRFFG/FwyP
 rAoB1L73PJYWgqNU3IwerwRZVpQRvnhPtICRF4B8btYOCUghrVEGgE1/qi/9SAIVywygc578
 ldmsdFeaTN5DRB/KXHCUyDYqwdKbq8geCVbIXlvg9QpGhRAskKhWYYNu/YKDwMeOAvP+tiKH
 P23Lsim9PUQwVwUi3NPAhjYwGsnayoqLvWJTo9QzI34giHij2lrJTgFQKD4xsYWzRThZ8/7G
 nsiWXCl+aemsD+7iWZ+37Y7pxQltek4MBEHtawhs8cLSipohq0Zb5mR6aJsFkO0aOSARcR4Z
 zxSiUbToNOAkDqDyeISNzWqlDdOQMVmjvfIJmj8CPeSILCNWkH4oF69P1km1PimjQdVZdHof
 92Niuixupq5VmrplWN2/HYEx5tjUa6unwkjKoaiGFeS5IXbPtLoZUY5149KuZLIMvW0vFuLA
 BVNrCW2B+WSyLvU1nJ+m10hNC8VHU6GRmLBkAEp8yOyjBT2HR01VERysATlmoJsMtVcegJ28
 3UdqBz0L1eRM4faqxwQO8HXMusE2TIBRbBKnibL1jrHLwOf3jNt5n06rMo4/zCQu1E8LIi3J
 DaFF9Iv287fEzjTcWIwZ1Q6xjIBH6wWDz8o/surqSReoeMMoYDHRfzOmzGovHQ1Mn3WPerKM
 pbEKgmdsPeEQ==
X-IronPort-AV: E=Sophos;i="5.88,378,1635220800"; 
   d="scan'208";a="66760967"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=bou7of9rfu1etP6sC1VEyStjhJQhj6HTp1NlTKyf6SsGL6eMWah52Co+K3uBVZhyEjh8tvMW7adMrRx7wINNDgv0uD5vBhjr+m5jhEYpUa91N9/eB2Jks6DHQO3IvVd32b8x9nufH2/079PLWqe2RS2E++UIvj6EBrZb73+vLFcXrVnMQAHOlBSmEwXaaHxEyibptZbcKPEJgNkiuXwk+QDwbQ4/USMhRA66rBvJpLiQPy8LxklHqXuPeqnqydB/POHRPvi4q6AD++bcFg5Ifc8moqOgsMQeRLFx6woVDU4sl14Erp5JQdv7YX5e8xGTRT2UTv0DpyaWY1Xosm4RWQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=j5nv94RfPou9hdDxbDa1pE72QPialCW4xUJnRAqg0yE=;
 b=DsuorAUTo7kT8SBA7p96EktLKlqwg2lJovMFdKogfDtdoEHbA+Eop///9Ri1arbKAlx75B4PK5N5J+S4CRhVzQa3rbY8bFXxYoiHR+AXb08VFvV+0oSbVbj9G8cbCQ/wi+ngqIm1iccyBPpztYsJnCaWWqNoUp5F356Q0KfNC68u6cZZDGoasvZuf7yTb2p3W9Unhlb//oygHjZDDI/tMTc6Ix+pMunuc/jlEHsBEy/XQfa3Oyyjj/UHz4uokpiWoDanQivf+u6NZcdJ10I9dcAib6W+Nx/cPbNFu0iBedRsNKpqRJHhwGI6XSUrJ1a3Ph0BO7UZ1xoDyY66O7o21g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=j5nv94RfPou9hdDxbDa1pE72QPialCW4xUJnRAqg0yE=;
 b=hD91ESbIqfqwu6NxrMgLtIVdoErJ1BEbIOLtGNTDaeYK8FQ4X2SepMPCjndfiC/TNA5wsxdAnzHR58lJD63FqC3fE86EQ8tsYwGKduh7G7LdBVEEyIJnBdSDC2IJoYXVhxSFzKOltzTiUJAingxS40d885DuDjTv6TlNZprnf0k=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Wei Liu <wl@xen.org>, Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH v2 08/12] x86: move .text.kexec
Thread-Topic: [PATCH v2 08/12] x86: move .text.kexec
Thread-Index: AQHXUvSjTUOKHmUOM0uSyn1XCQornKya8oIA
Date: Fri, 18 Feb 2022 13:34:11 +0000
Message-ID: <80777b20-fbf5-0671-cfbf-413c9a483612@citrix.com>
References: <8f56a8f4-0482-932f-96a9-c791bebb4610@suse.com>
 <f964e5bb-6b84-40d6-d247-7655ef09d47b@suse.com>
In-Reply-To: <f964e5bb-6b84-40d6-d247-7655ef09d47b@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: f28682a9-d701-438c-1274-08d9f2e358ee
x-ms-traffictypediagnostic: SN4PR03MB6719:EE_
x-microsoft-antispam-prvs: <SN4PR03MB6719F8AB7E96519641FDD44ABA379@SN4PR03MB6719.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:663;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: izg2rgUbYb5X7dc2G1HShsCcYAuGZ9IE1cUaS5zTBmi0h53ilCHeLRhRVnzZvW5wSKtE2UXqauG5aAzLaaji/+IEsivatFLDKl0HZ1S3wYYulIimxk9Sdmr267QLPF9uNjkHs9A9OFYn8L6xaA3RZk4ibgZmMk5WPXx13lqDQneUTJtHi7vSHdfqbk+DSbCJXF55Cl59N19URiJ8SLiIpRZVw1Mq/NOPLC3FX6QLB3qFRYarBzWkI4OmEKaXmJ9vtldUzKYoJArGd0eBHRjc83KR5B+4ZgZeasALDsYMzJgQAbgVRia9RJ+7b5jypt4D00QM6WW5uxF+pPa/Aw3JDAzwTHhkuu1sHVxbbvAtLvl9TwpFsYAAqv0Ek4M7VswcoBm1y4ETlKtAzFSd8UCSnDtQ7J/J9bTiQSNgD+VTG0K5tTiVA9kdOsfu2jiJZsKUA6sMyQ1So6ob8ubCWUPIPYdwwZ01JaHOKiubbL5dd5Ra+VM6KpF7i+raVYzsAYp+y5xBbP7MBwPa9zq5/qXuJSVueRhtdj+2GQDDis2kbzlH6pa9aZuO/9/MhJCbEQL9mGJ10yeWpGWRCUKF2+4uzbzr5bX23pkz8DVVpWZxUrY8kaUOw3+S3o+zI7ethD1sCHxyPz05z83p9C4T9nFvGvV3RVP7trAF7+0b8eFEc1qROsFAQ4AuK9ViZe+znLNvqsmKVprF7LMTaXJrNBXSNEiUo4VOlEdX07qu20jYlaucQQdjVNG+KMn4vFHl13gA/3TDXzWehatJTHkFXQopUEfWQYkXWdMcuwZDbLu09As=
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(71200400001)(508600001)(4744005)(2906002)(107886003)(110136005)(6486002)(5660300002)(66946007)(26005)(8936002)(186003)(76116006)(31686004)(36756003)(4326008)(66476007)(66556008)(91956017)(66446008)(86362001)(64756008)(8676002)(2616005)(316002)(82960400001)(122000001)(38100700002)(83380400001)(53546011)(54906003)(6506007)(6512007)(38070700005)(31696002)(142923001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?MG5TNTlXdVpiNHhHdU9Jb3M0aHFyVHhUcVNRdTl0K0s1ampFS0dQMUd3ZEIy?=
 =?utf-8?B?UkVlQVZkdzdkVVdRalJYM1I4SGNqR3RBTmdVbXJWMzRIWWxnZUIrOC8xWjVI?=
 =?utf-8?B?NjZkNSt6UUFsajFXd2Nzdm4wdjlGWnhuUkxTNitGNEhmNE9mT2pLUFQ2MXZo?=
 =?utf-8?B?MUM4U0FINy9SZVFYT0xXOXRxUlBSaHlLLzdTNjdLOW83YnRHWVRJN1NVdTh5?=
 =?utf-8?B?RWNBOGQ4Zk0xTGM0YWpVaUdhUWYrR0hTQ0VGRnYwZWdtaUVDeVhBbXRuNDlP?=
 =?utf-8?B?WUZmSHpmcjY0c2ZnTUdkdzBxemJoVXpJT0lDbDNqZGZtR3BCTDJjRExrUDNj?=
 =?utf-8?B?RkVobUtVTUFLRUZKczBXSXVBSkFaY0pna0ZKcDVBdEhkVDJnZU1EQWF1TGk2?=
 =?utf-8?B?bGMyc3NQa1VVVThTbTFRS3FjVzUvdFFaUE1DUkFHbm9JQWJ2clJUb3dubnNN?=
 =?utf-8?B?dUs5cXd0MzJKZnRMOUllNi9KVVF3SEJvTlZxbjB4WXRSTUt2enFTWU1ORHM0?=
 =?utf-8?B?VFFLaUVtVWxUSjFPK3ZpY3hWcUpkL05SdlBPellscDNNK2hNMjBNV0hWQUg2?=
 =?utf-8?B?c1RwWGtjYlJjL0kxT2l1S2M5bUlQR1Azd0FwamQyblM5ZklvakdINzRvMGsr?=
 =?utf-8?B?UXZwWjFLa3RRWFZhY2lpeDdmcnc0WnVaQTNBOStneWdMK3J2eE5Ua0Q0cThZ?=
 =?utf-8?B?VmNhaGVFd1hJNVRDU3V5Mk44bzJSNG5ScjZiTlBoejlSY3ZXU0xoTlFhdEtI?=
 =?utf-8?B?ZjZmeExBeFd0akFuZ0NOaHBhSHV3cEVMYlRXTlcyanJDTU53dlB0Ylh3b1Rl?=
 =?utf-8?B?akp1b1d0eG5MdTVkWmxqb0xSZi9IUEZmMDZEYUZxUEh0ZzhuVFNyV3JpSzZL?=
 =?utf-8?B?NmJrUDhPUWhHVjlWQkFJMTNhRzY0K1NoVWM4OWRXcGovVlFEaDV1VDhvK0dW?=
 =?utf-8?B?dFZFYjVoejNCb0FJUEJWWmduS0JGM0pNY05wWGIwbStxNDA5SEpOVVowTlJ3?=
 =?utf-8?B?bE9EbXhsL0FxcUxscSt3MUh5YUkvNXFPV3B2M1hJUHpnVkVpSDcyRVRUWWVk?=
 =?utf-8?B?dnhPMkV2eW51b3pJa1B3Y3ZLWUFDdEF2SHl1KzRLUXR0M0c1SXl2bXZGZC9W?=
 =?utf-8?B?d0ZYMkc5R0tYUk1CbVcwYWdpQ05veEwzNXJqb0RuRjlTTGRpTEV4Nng4WU1W?=
 =?utf-8?B?VUFZVE9RZGsveDcvT0h1dmtRUWlkRHR0SUt4VklnUDRQZEdYMmxrWXRhWE5Z?=
 =?utf-8?B?WEhzQ082OWxEL0hhL3dVazQ3RFVjbHFUenBmUTFSM0pKM1VUdkdzVGora21W?=
 =?utf-8?B?RjlCaTJoc2tBNzRsZ1Jtanl2Q0VXaHh1VGxPRDZYSlZxd1p6b001VGwrVytv?=
 =?utf-8?B?SjVGTURXTUZjTTJma2lxdGhvZG1HWmpCVXYzb1dlSVZqN0NhYjFHalc0M0ll?=
 =?utf-8?B?UTAvMVhydktoTWZJakJmbmhQMmswMHc5TTl1T016Q3FORytuQzVGalE4MGh5?=
 =?utf-8?B?VTAzRWF4UjlqcTJDSG1kVFRuUE9BNStpM2NkMmhsNFFpb3FZa2RWclFLSmJr?=
 =?utf-8?B?Tm03WFRBYWRPajVTWExKVk0yUTh0T2dUNk5pMnhES1Y3azI1b0lPSVNuRXNi?=
 =?utf-8?B?UlV2RFQ3Ky9xZVRSWHRJeHJKWWYzTlliRmVRY2lyVmowZUNqNEFKY3V5OVhH?=
 =?utf-8?B?RVJJVURhMVNUOWxzc3RMNWg1bGRvdk5LSmpTelB2ak1xeXZlZUQxM2FYMmtW?=
 =?utf-8?B?NmxMQTJXeHBIYUpIaGcwa0ltaDEwSFF3ZlVBVUlBcXNTS1g1Z25pbkUyU25P?=
 =?utf-8?B?NjBmWDQzUUM3dlZnTEpSTlE5b0cvK0t5NmxjZnh5MWNKSXF5RTZPMXp4OUFE?=
 =?utf-8?B?c3RlaUJPMVh0dml0dHlCRXArdHJOUUpSTEpoSlBRYkRqK3g0c2lOdFlMdXRV?=
 =?utf-8?B?TkZONDFhUFV0QWNTenltcFlnWVdONE1Xb1hmcUNwYUNwQWZBYStPSWo2RGxD?=
 =?utf-8?B?NSsyOE1SVnpPYTJjSmVpMXNXOUg0OGV0ZWhKTlR0cmF4QXBBNkhmZU1CalVP?=
 =?utf-8?B?NUtpL0NZWWJObUxqcElZS1FaZ05TQysvcjlVOFllY0tQMTNYVTVPQnJubVF0?=
 =?utf-8?B?Y0hrS0pIdjFJV0w3bUQwRnZtdWpFOVRKQTVSajBIczkxeVNhV2RsZkcyLy9n?=
 =?utf-8?B?dzZJU2tEQWtzcndTTWc1bVo5NlAzTHZzUE55RTR2VmcwTndKZzFndEVqWGtn?=
 =?utf-8?B?Z3BwNnJkZU9Ma01oaDl1aUJaZ0p3PT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <CF063840B9E40649A3314C8D34AB5337@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f28682a9-d701-438c-1274-08d9f2e358ee
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Feb 2022 13:34:11.1724
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 7iG2G8ChYnHBuo5F34i173HEo+IYi+6UTCS1Ia1HsQjmol70xHluY0Xy7qQ9mr47X7THcNigyvgY73iPJFyzBfaknBEGlHg70u6ACDtlISs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR03MB6719
X-OriginatorOrg: citrix.com

T24gMjcvMDUvMjAyMSAxMzozNCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IFRoZSBzb3VyY2UgZmls
ZSByZXF1ZXN0cyBwYWdlIGFsaWdubWVudCAtIGF2b2lkIGEgcGFkZGluZyBob2xlIGJ5DQo+IHBs
YWNpbmcgaXQgcmlnaHQgYWZ0ZXIgLnRleHQuZW50cnkuIE9uIGF2ZXJhZ2UgdGhpcyB5aWVsZHMg
YSAudGV4dCBzaXplDQo+IHJlZHVjdGlvbiBvZiAyay4NCj4NCj4gUmVxdWVzdGVkLWJ5OiBBbmRy
ZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPg0KPiBTaWduZWQtb2ZmLWJ5OiBK
YW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQoNClJldmlld2VkLWJ5OiBBbmRyZXcgQ29v
cGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPg0KDQpJJ2xsIHJlYmFzZSBteSBrZXhlYyBt
ZXRhZGF0YSBwYXRjaCBvdmVyIHRoaXMuDQoNCn5BbmRyZXcNCg==


From xen-devel-bounces@lists.xenproject.org Fri Feb 18 13:35:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 18 Feb 2022 13:35:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275427.471287 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL3Q5-0005b1-Dv; Fri, 18 Feb 2022 13:35:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275427.471287; Fri, 18 Feb 2022 13:35:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL3Q5-0005au-As; Fri, 18 Feb 2022 13:35:33 +0000
Received: by outflank-mailman (input) for mailman id 275427;
 Fri, 18 Feb 2022 13:35:32 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=6Z2s=TB=citrix.com=prvs=041b9fbab=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nL3Q4-0005am-Bw
 for xen-devel@lists.xenproject.org; Fri, 18 Feb 2022 13:35:32 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a367ff42-90bf-11ec-8eb8-a37418f5ba1a;
 Fri, 18 Feb 2022 14:35:31 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a367ff42-90bf-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645191331;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=kk0nfI1i0Buabsci0U6735eKzw3N17e6WbCZSRdQMnQ=;
  b=RgT0aLdLg3W06rqF8AXp4un0kQfc1JZpqqjHRG1jBHxs2XY6fAWMsrPy
   WOmWNZUY0EvI/SLgW7i9HLXQQxAHhahX6YgYmjigLUX8oULrQMKugtwu4
   CMuuSjiExELr9YwgWT0Fb5arJwK6a7VT3PGow4UjJZUOC3YEKaO+dIH22
   I=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 66761053
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:BeBIlat4wX1Q/nAaeoxHYjHGH+fnVEReMUV32f8akzHdYApBsoF/q
 tZmKWGGOPyOY2f3etElaorjp0kCuMPUxtdhQQFl/HtmFykQ+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQzy4bVvqYy2YLjW1nU6
 YuryyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb
 /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo
 Oihu6BcRi8GPp/Co8QWCSVDOBhZGqgd+5/pel6W5Jn7I03uKxMAwt1rBUAye4YZ5vx2ESdF8
 vlwxDIlN07ZwbjsmfTiF7cq1p9LwMrDZevzvllJyz3DAOlgapfEW6jQvvdT3Ssqh9AIFvHbD
 yYcQWQxM0qZO0AUUrsRIJQnw/ap1nbASGdJsAzWiq0x+2f20hMkhdABN/KKI4fXFK25hH2wu
 Wbu72n/RBYAO7S32TeDt36hmOLLtSf6Q54JUq218OZwh1+ezXBVDwcZPXO5q/Skjk+1W/pEN
 lcZvCEpqMAPGFeDF4enGUfi+Tjd40BaC4E4//AGBB+l5arm7T25DTI4VRV4T/sj78wWa2cM/
 wrc9z/2PgBHvLqQQHOb076bqzKuJCQYRVM/iT84oRgtuIe6/txq5v7bZpM6SfPu0IWpcd3l6
 23S9EADa6MvYdnnPklR1XTOmHqSq5fAVWbZDS2HDzv+vmuViGNIDrFECGQ3D94cfe51rXHb5
 RDofvRyCshXXPlhcwTXHY0w8EmBvartDdElqQcH82Md3zqs4WW/Wotb/StzIkxkWu5dJ2O0O
 RWP4VINusYJVJdPUUORS9vgYyjN5fK9fekJq9iONoYeCnSPXFTvEN5Sib64gDm2zRlEfVAXM
 paHa8e8ZUv2+ow8pAdas9w1iOdxrghnnDu7bcmik3yPjOrPDFbIGOxtGAbfMYgEAFas/Vy9H
 yB3bJDRlX2ykYTWP0HqzGLkBQpUdSNiXciu8aS6tIere2JbJY3oMNeIqZsJcI15haVF0ODO+
 3C2QEhDz1Tjw3bALG23hrpLMdsDgb4XQaoHABER
IronPort-HdrOrdr: A9a23:vxNLyarrwj6hKyPog75Sy40aV5uNL9V00zEX/kB9WHVpm5Oj+f
 xGzc516farslossSkb6Ky90KnpewK5yXbsibNhfItKLzOWx1dAS7sSrbcKogeQVREWk9Q96U
 4OSdkHNDSdNykZsS++2njELz9C+qjFzEnLv5ak854Fd2gDAMsMj3YbNu/YKDwNeOAvP+tlKH
 P23Lshm9PUQwVvUi3NPAhiYwGsnayvqLvWJTo9QzI34giHij2lrJTgFQKD4xsYWzRThZ8/7G
 nsiWXCl+eemsD+7iWZ+37Y7pxQltek4MBEHtawhs8cLSipohq0Zb5mR6aJsFkO0aSSARcR4Z
 3xSiUbToJOAkDqDziISNzWqlHdOQMVmjjfIJmj8CDeSILCNWgH4oF69Pxkm1PimjsdVZdHof
 52Niuixulq5VmrplWM2/HYEx5tjUa6unwkjKoaiGFeS5IXbPtLoZUY5149KuZMIMvW0vFtLA
 BVNrCX2B+WSyLsU1nJ+m10hNC8VHU6GRmLBkAEp8yOyjBT2HR01VERysATlmoJsMtVcegK28
 3UdqBz0L1eRM4faqxwQO8HXMusE2TIBRbBKnibL1jrHLwOf3jNt5n06rMo4/zCQu1F8LIi3J
 DaFF9Iv287fEzjTcWIwZ1Q6xjIBH6wWDz8o/sur6SReoeMDYYDHRfzPWzGovHQ1cn3WPerKc
 pbEKgmd8PeEQ==
X-IronPort-AV: E=Sophos;i="5.88,378,1635220800"; 
   d="scan'208";a="66761053"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=JEhQjOqxU4+UfsYo/+M3Y5MUQIC93ljjr+ExvOyqp29xsS+usqXMwfj9fbd567LB18W2hsYQJkpvqx6iGfCxO8lolFoVkGKMHGoKo3ixYNNqAoAsgkXy1H0tZm5aIGY3V5LDWNRQRLXLmq94y8JJowCUfzstTd0WnUktPpjeT34Ed6r6Oa73bF6DSCNRof0hvXiM07Nv1cGlBlG8jEP5S/QvBXIGQAhKwWu2bWs6kPN1j3LejdwqkBw7yL2dTzv2+UdRZ6vUIJfU6Vznl3dy59kqxUgUsVp5JwzQ8hgrZ3FdHeKxGvnBOicVX6LjYGTbsuK+GqOQ2WTZ1EsPLZOgJQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=kk0nfI1i0Buabsci0U6735eKzw3N17e6WbCZSRdQMnQ=;
 b=RmXYH6mJUkCR5BooqlLOeE4Drdnk+ID+HjRmMyr7apBwwWTy+zf3RwK9MdxOXLbfdQ8SizFoQFKjXBRORaTyUKGg1cPbzg5+rDF+EdtGjybzHCYDM5Zo5uuaZKAfMixClKx2t6CTPofQJBNuhSNc8vMmDfi4tLu/lJ8IuKIUR+nwm6xGeVRnBv6w+1u4ZW+ICMxlEXHII54VChsHR8f7NklafZMfEFA2qii2zf4Ct/KsbbaluXeGMqAxk3BnYv7WvRG+z4Pf39faI4SMwIsSpWWZ8KgeEpS8tCK91Z7g3BY7IUxVDm24IAYhswDzK67luuLMWIesKL/4Q9X0LOL2Sg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=kk0nfI1i0Buabsci0U6735eKzw3N17e6WbCZSRdQMnQ=;
 b=IP/n/n4V+AEOIzTYdIOzIPsROItU6q2NToqylK5BWreHVDE/uAqkbc5/hLyZrxkf4sxhSCM2ctD8m3i9RnE54uUjz+zmip9GupQJdLl++1h28m24znwAMCRiCJ+gvc/NjWNKKGSzDx+wYMAGw+L9GOea9PjE70kke9gSS0kuXL4=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Wei Liu <wl@xen.org>, Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH v2 11/12] video/vesa: drop "vesa-remap" command line
 option
Thread-Topic: [PATCH v2 11/12] video/vesa: drop "vesa-remap" command line
 option
Thread-Index: AQHXUvTpAmL8laVK/kuChxpnAZopaqya8tcA
Date: Fri, 18 Feb 2022 13:35:22 +0000
Message-ID: <cf92c886-fb0f-3763-d46f-3c0004eb5537@citrix.com>
References: <8f56a8f4-0482-932f-96a9-c791bebb4610@suse.com>
 <bc1411cc-f920-a002-d64d-84ce1ebd080e@suse.com>
In-Reply-To: <bc1411cc-f920-a002-d64d-84ce1ebd080e@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 3ef0be4c-bce6-454b-560d-08d9f2e383aa
x-ms-traffictypediagnostic: BYAPR03MB4837:EE_
x-microsoft-antispam-prvs: <BYAPR03MB48378F6FCB49D528944B093DBA379@BYAPR03MB4837.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:2399;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: NuKBiTiyLSFS9TGB11Dwj/l6hGTpcPzDAAwdi49OSNgrxRyWf4hk3rfhRXauPEFLk61q1ngNkvb0BgfEUKOaR8m5ycUzbJirERvraT8/sQ9z++98+CmUyaK7eXMC1o/+kx0Kek+fSeA6mkqRGs6QI/jtOloBxHTO7M1OJmapMfbKPRpUWq3cTwWcF0z0qlH+K6d2ymkCE57zTpbhq+k0989gTzFyMh2lh0rPcq6rnjDV7fTdXQH9Kj4KGwEa0hc0U91IbRgy5SDg0P/ChhpHeGoI0/sHKwHsoDt1qtDlRNFMWTBr1Po7wdxTNcxAxmVsui7CqySTa7etkPqmo+h3pXk58/2L4Rsqks3k0aHvO1GOx0LlJvq9w0PFxod1HGSFbEGvRaL+d8d1m1moOpDHF37a++knZ69l0L8Vs3ojby2jDBEWIybtCepZAac9ENOE1b6drrsiWaPCIPm4yxMfpClUozziOuP5uiuKjqFIFvfICgUE2rpGuW+3nP0tstFvkcNhHfs4oloEWDId4vChfC/vM/EPAc9s4DEVVVPvNO8LQj2oN/MpJRFcTqeeiR4KvLFQJ9khGzsyd2qFhoahnWpLuM1ByPkpYeLWFkb6+wpo90YaXEvrvBX+4hWLX+VKjICs68S3L/5usYjspqbvP/pzoxtAEgD+Jdy62ln/OAMqMINAGywuzighd2v8EErrxACQBcTUGafIU2c2q1OXZH/PpoJAAMvLrASIsmX6aD41CUWciXHmipY6b/9n563kRbgwLkE/OcvwUK0iVxP7Dw==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6506007)(107886003)(71200400001)(8936002)(26005)(31686004)(6512007)(508600001)(2616005)(53546011)(83380400001)(110136005)(316002)(36756003)(64756008)(5660300002)(38070700005)(54906003)(91956017)(4326008)(186003)(31696002)(2906002)(38100700002)(82960400001)(122000001)(4744005)(66446008)(66556008)(66946007)(86362001)(66476007)(6486002)(76116006)(8676002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?cllWQ083RUpKeDRueVMvL0JWK1JiMFNrM3JpNjV6aVNQSmVHT1J6cUh4Umxn?=
 =?utf-8?B?UFZjcEVWdE5JNENWN3RraDk3YUttbUc1RnNoVUJjZHRHZzlVdG1yaG43RXZJ?=
 =?utf-8?B?RXNWNzFIc0JwZUVkUzdZejZJWUM4TWVIb05nQVJOaUZmZXJTTGRkZUliR0cy?=
 =?utf-8?B?ZHBHVXdIVTBKZlJWWit2OWxmQUQ1ZHdDc3l2TDVNSkxLeWhrSUEzMUlZNXlH?=
 =?utf-8?B?ZGhGSjdHUGlLN2VxRzYrVVhIeDRoVjBiWVJ6THk4TmMvSGwyNkRDQnZGcmdp?=
 =?utf-8?B?SkdUZmVDZWdqZmd6Qkt0VnIzWjNsaGo0cTlHc3o2WVhCaDNGaG5HdzlwaFp5?=
 =?utf-8?B?UWNjd3dGUndvMldXT2h2b0RrNGwrQnZ2RmR2dzJZS0ZKbVNvODJHdldyQ3ZN?=
 =?utf-8?B?ODN5R1FvYjkzVkdnR0M2dkdWM1dBSFVtYzROTFlYbWpnK1c4YjY0OGc5S1Jq?=
 =?utf-8?B?Q0xCNVZyVjNJY0ExSUdYVXlUb21FUmttSWlML1BLcjNEQ3RYNVVoejNqdG1K?=
 =?utf-8?B?dUxaZnpDZllCZExtc1dWQWljc1JKN0cvVjhlR29nV3lMNXRlSXlLRmNuOHpR?=
 =?utf-8?B?aktQQ3dGWHZMVXJ1SkJ1OWxtY2ltZmFjYUU4VkZTSnpNQkdmM0ZEU002d1lh?=
 =?utf-8?B?Mmtiek9KcWduaEc2YU9YTy9xS0kxcnE5c3JobllKdjczUmw3VG1UampUYUlh?=
 =?utf-8?B?dUUyTDBpRnZqV1VBd0pHZURMbG9mY1J2dDVMRjRVeTBmSVR0YTNXZjRTK3Bk?=
 =?utf-8?B?WkxwK1FaNWs2Uk9mQXM5eXJmQTVPSXByYi80TTVFdWNaclVjZjE2Y0tyMVJx?=
 =?utf-8?B?VWlKR1Avdi9ZWUxwc2kvRk04Q3BDNTBPS3BHdWpNTGZvd1dLOHFDVkVQQzNN?=
 =?utf-8?B?UWI4RU5hZTRrS1FvaVV4a3M0NjNjbXprSHZzemZrUWF1K29tYThRdzMrZ0k4?=
 =?utf-8?B?OGJEdFJsU1hRc1FINFVrMG1LSE5NSkNFcENac3k4ZHlpeDBNSXZ1bzZEbTVJ?=
 =?utf-8?B?U3k4RlJvdGs2RlMxN1VhNXZvTEMvd2l2eXREOTMzc3JHUnY1NWxHV21paXp5?=
 =?utf-8?B?SUpIbWFVczVrT0l6N0NSV2Vwc3NBNXZ2V2hsb1hUUkJPSTBpVDFpbHhhdTlY?=
 =?utf-8?B?MUh3bUZ2R3FETmdTYU5wNWYvaUFteVhqcWxPak5XQ3FvK1ZFN1ZYY3oxeWM4?=
 =?utf-8?B?MWJsdTdZS2FsYW5ZbWFHbWxOQmF1NVI3aktZSkl3UEgvZXoyRE1YM0VUK0ky?=
 =?utf-8?B?SHhabUt6bm0vM0l6VUNLOUd4VlNPMFBsYzlMQlhibndEbDdOcGZTS2U5TUdW?=
 =?utf-8?B?YTF3UjVvbG5OQjU2cytRRE83MHN4d0k5Mnl3bjAvM2h3bkRCdUtxR0ppWGVm?=
 =?utf-8?B?cWxmNDFqeEpIeGI1a05YNVRJN3FSLzFVeTg0M2hpaDFxaG1TbjVkdXlwNU1x?=
 =?utf-8?B?K1AyRlVWQUtOM3k1eGh0MlRHVXlnc2RPYkFpUkdaWnNKWWdTWGtIbnQ5UFZD?=
 =?utf-8?B?M282NEYrOVVCU1RQeHlXaHFiUGcrOGlpeDIwdUYzWFJWb0U1MUhwQzN1Y1dm?=
 =?utf-8?B?L3lIWCtURnBpUTFTam5MUFlNUGRuOGFXUE5VY1pBMzhXZ1dEb1Y3UWZ2Njcw?=
 =?utf-8?B?QmNqOGZIUUMrZ2JNblBsaU5BYnNFVkk5TkZzT3l2by9TdFZSeUZRRHdnVVoy?=
 =?utf-8?B?Vlo2aml0WnR4QXdIclRnaWljbEs3K1Q2MFRsbU5tSU45Q0hiU2YvdENkWnI2?=
 =?utf-8?B?N29RVXg3UE8yTmRSRXYzbXZSVjJtQWJMaUlvY3RaNzM5VFlrODB0TWZBTDll?=
 =?utf-8?B?YUo2NFcwRUM1bVlIbEFLdVN5S2dLMnlMMFVGKytDbTJKWG5JTUIxQXcveVFQ?=
 =?utf-8?B?MjVKc1NUMGE1WU0vYUVBYzB0dE1Pdm9HbzBFK2dYNzZIcC9VZlI3dHRFWnlh?=
 =?utf-8?B?L0FlWDgybDZFUEMxYURHZU5hNXhZVEVZZ2FreWJyZWk4WTYydmxHUEVEN1JK?=
 =?utf-8?B?blc2L0U1TjhZWGVFTnNKL1dJZHY5M3cxNVRiVWpSNEFUYTVBZUlHc2xEMUdK?=
 =?utf-8?B?YjZmWW1zb2Y5WEFPc1B0VFRSRC9WWDJFeVZUTVF5QllsQUJrSzVOY3lSdC9z?=
 =?utf-8?B?eVZIakVicmZnclN2VUhNYTNoZjdUZUJzcGdNMFBPWnFsb1NoL2c3cWhwVlFG?=
 =?utf-8?B?NHhYdVpEck9uTDRpdGJrVG9EMHhiNjZBaG9OeWxTbjFubFFkeHJsUndyRkpG?=
 =?utf-8?B?MVFhUklBaXFTdWpGUFRxUTNHbndBPT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <F41F7F5C8EAF0B429F2931BD0BBA7CCE@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3ef0be4c-bce6-454b-560d-08d9f2e383aa
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Feb 2022 13:35:22.8706
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: HB/VpOOJ1JWhzV6fPNjytQ8vjxhSk1OFaGI/tkWqAjFbxfvYAtP18m9TKYkyLlGkNymUFfGzvENAGQgvMpjlOv0s0ZU2NqDHhY9Sl5JY0TI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4837
X-OriginatorOrg: citrix.com

T24gMjcvMDUvMjAyMSAxMzozNSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IElmIHdlIGdldCBtb2Rl
IGRpbWVuc2lvbnMgd3JvbmcsIGhhdmluZyB0aGUgcmVtYXBwaW5nIHNpemUgY29udHJvbGxhYmxl
DQo+IHZpYSBjb21tYW5kIGxpbmUgb3B0aW9uIGlzbid0IGdvaW5nIHRvIGhlbHAgbXVjaC4gRHJv
cCB0aGUgb3B0aW9uLg0KPg0KPiBXaGlsZSBhZGp1c3RpbmcgdGhpcyBhbHNvDQo+IC0gYWRkIF9f
aW5pdGRhdGEgdG8gdGhlIHZhcmlhYmxlLA0KPiAtIHVzZSBST1VORFVQKCkgaW5zdGVhZCBvZiBv
cGVuLWNvZGluZyBpdC4NCj4NCj4gUmVxdWVzdGVkLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcu
Y29vcGVyM0BjaXRyaXguY29tPg0KPiBTaWduZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJldWxp
Y2hAc3VzZS5jb20+DQoNCkFja2VkLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0Bj
aXRyaXguY29tPg0K


From xen-devel-bounces@lists.xenproject.org Fri Feb 18 13:36:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 18 Feb 2022 13:36:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275434.471298 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL3Qn-0006Cf-NM; Fri, 18 Feb 2022 13:36:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275434.471298; Fri, 18 Feb 2022 13:36:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL3Qn-0006CY-KS; Fri, 18 Feb 2022 13:36:17 +0000
Received: by outflank-mailman (input) for mailman id 275434;
 Fri, 18 Feb 2022 13:36:16 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=YtLv=TB=citrix.com=prvs=0411da6ea=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nL3Qm-0006CK-3F
 for xen-devel@lists.xenproject.org; Fri, 18 Feb 2022 13:36:16 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id bd135f36-90bf-11ec-8723-dd0c611c5f35;
 Fri, 18 Feb 2022 14:36:14 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bd135f36-90bf-11ec-8723-dd0c611c5f35
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645191374;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=RNQ+X39j3WBOcf6XAmYjL4d8gDvIpgPH/GbrzvAZnE0=;
  b=VJFLt8zphc25YsKX2Ut+VDzzEtlY+vAhAod8pEQ+jfxezTtXeOPfoHDt
   3xeZydrPpRUe2N5UAvjaU5BlkMN7pmYRHOrl+HBGZ4U/zv2AZoXjSon/G
   URzR4ZpBPtCmIOwCY5ae+uRm/oFZpfuqnYw8WIqTZkeiEU0cqgmZfsd8u
   k=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 64921623
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:fFQZFKIiC7ECzOMtFE+RHpUlxSXFcZb7ZxGr2PjKsXjdYENSg2dSy
 2dJXWGFOPyJY2P9LYp3aN+28hhSvcXXxoNlS1FlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA180IMsdoUg7wbRh2Nc42YHR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 Otxma7zDjd1BJaSotYhaj9hFSV4OqITrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBNPsM44F/Glp0BnSDOo8QICFSKLPjTNd9Gls15oXQ6yFD
 yYfQWNBYSvubCdyAwsGE4wyubrzgCKiMBQN/Tp5ooJoujOOnWSdyoPFMsfRe9GMbdVYmACfv
 G2u13/iHhgQOdibyDyE2nGhnOnCmWX8Qo16PKK83u5nhhuU3GN7IBQTXgrlieKjgUD4Xd9DQ
 2QE9yxroaUs+UiDStjmQwb+sHOCpgQbWddbD6s98g7l4qje7hudB2MEZiVcc9Fgv8gzLQHGz
 XfQwYmvX2Y29uTIFzTNrd94sA9eJwArEUMwJmg0ETE+vePRnLgVtxTLSNFsRfvdYsLOJRn8x
 DWDrS4bjroVjNIW26jTwW0rkw5AtbCSEFdru1y/snaNq1ogOdX7P9DABU3zsK4YRLt1WGVtq
 5TtdyK2yOkVRa+AmyWWKAnmNOH4vq3VWNEwbLMGInXAy9hP0yLyFWyzyGsnTKuMDiriUWa4C
 KM0kVkMjKK/xFPwMcdKj3uZUqzGN5TIG9X/TezzZdFTeJV3fwLv1HgwORPJhTy1wRRyyPtX1
 XKnnSCEVCdy5UNPlmfeegvg+eVzmnBWKZ37HvgXMChLIZLBPSXIGN/pwXOFb/wj7bPsnekm2
 403Cid+8D0GCLeWSnCOqeY7dAlWRVBmVcGeg5EGLYarf1s5cFzN/teMmNvNjaQ+xP8L/goJl
 1ngMnJlJK3X3yOfclzSMig5AF4tNL4mxU8G0eUXFQ/A81AoYJq17bdZcJ0yfLI98/dkw+IyR
 P4AE/hsyNwVItgb01zxtaXAkbE=
IronPort-HdrOrdr: A9a23:gd1tFKPwnatXh8BcT1n155DYdb4zR+YMi2TDiHofdfUFSKClfp
 6V8cjztSWUtN4QMEtQ/uxoHJPwO080kqQFnLX5XI3SJzUO3VHHEGgM1/qB/9SNIVyaygcZ79
 YdT0EcMqyAMbEZt7eC3ODQKb9Jq7PmgcOVbKXlvg9QpGlRGt9dBmxCe2Cm+yNNNW177c1TLu
 vi2iMLnUvqRV0nKuCAQlUVVenKoNPG0LrgfB49HhYirC2Dlymh5rLWGwWRmk52aUID/Z4StU
 z+1yDp7KSqtP+2jjfaym/o9pxT3P/s0MFKCsCggtUcbh/slgGrToJ8XKDqhkF+nMifrHIR1P
 XcqRYpOMp+r1vXY2GOuBPonzLt1T4/gkWSv2OwsD/Gm4jUVTg6A81OicZyaR3C8Xctu9l6ze
 Ziw3+Zn4A/N2KPoA3No/zzEz16nEu9pnQv1cQJiWZEbIcYYLhN6aQC4UJuFosaFi6S0vFpLA
 BXNrCd2B9qSyLYU5iA1VMfguBEH05DUitue3Jy+/B8iFNt7TVEJ0hx/r1pop5PzuN4d3B+3Z
 W2Dk1frsA7ciYnV9MMOA4/e7rENoXse2OEDIvAGyWuKEk4U0i93qIfpo9Fo92XRA==
X-IronPort-AV: E=Sophos;i="5.88,378,1635220800"; 
   d="scan'208";a="64921623"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=QXvcwjzvg23FCWONa9bJI007oRLCTehjQlvqZLcgGMSO0G+XMKvNvSf4RHzjF6mBDb1TB29UCJWgf0RCxg6YxyCwoI+BbPOPqU9CjFYkKY6hxdFF4KND3h2QG3xsMB1lW4uhlbQSlTFqL2W1UnESkHMtRHpHY4Hc+s4vJPhlNMGkdkzIX1LuWhqBsZ5M9C+2NgvJ127nM230CbqSjiiRo8eFPVe831RZ8eAicQ0u98H7aVX51kXVXdKiFTrD9B56WI2j4wCeJMIh0uTCKKZTF7B8DrUXh2DJUGrJ8eWOjQnJoD58Aum+Hw/YAyeq5vbpmj+wcrYh8CqtV+FLxPjH2w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=G/5CpKoyKCE/Gsh5aSSZpTE6RwlvYPQR20z+RqO1Gfc=;
 b=UWB5vqJS9y7ePfu9xmu7ujPkCDzWVvyy0+JSpJO2YO6DyfpSd7eUAtnQ7Sxy6Am9UFDQ5b8Wr1Ykt4CFD4CxlmduprwBf8DRXWyH+ImtYg0zJJ3+dAY6Mrd9CHkcq6A9HpQ7m5O2k52VMxwIEk3X1yHrnQVWDFHqPoq6SF+IUBI8Gj2IARMty7/tk4G774KokLwakmfwz7v2X3Zl+GCl2LkQlGxGjIfjtNDBoSP8EwuedJsZWVQxSQ0fi17STK5mRmMPJHbyUD+GcODhzUIjEYE+nXqsZWj1m1KNi8LcftMsow/xfmJYW69Ujb4oYPRe8e7z5ST6Jr4COGmYv4i7/Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=G/5CpKoyKCE/Gsh5aSSZpTE6RwlvYPQR20z+RqO1Gfc=;
 b=l08nns2saS9gdZrOioYpSGya6FpM2tHQUySisOEt/7NE2uJPfgyGlvj7dK++Id7ae8TrNUGNZBWQvUoTNX4UvztpGTrm8LrkPdcmoZ1tlezIejtzfJiJjKnfnzJvnnbxWf351zgKYbkJydXtc7abrDKRKcwY5HKps5izuGOMTNs=
Date: Fri, 18 Feb 2022 14:36:01 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Andrew Cooper <amc96@srcf.net>
CC: <xen-devel@lists.xenproject.org>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, Jan
 Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>, Stefano
 Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH 1/2] github: add workflow to run Coverity scans
Message-ID: <Yg+gwfRqetYoT4Th@Air-de-Roger>
References: <20220218120042.32102-1-roger.pau@citrix.com>
 <20220218120042.32102-2-roger.pau@citrix.com>
 <0eeb8f5f-d049-8a8e-9e65-d1966c21a781@srcf.net>
 <34ebc66c-e55f-3f98-b769-0e73bdf3c2fe@srcf.net>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <34ebc66c-e55f-3f98-b769-0e73bdf3c2fe@srcf.net>
X-ClientProxiedBy: LO4P123CA0456.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1aa::11) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 87282880-412c-48b5-91f6-08d9f2e39dd6
X-MS-TrafficTypeDiagnostic: BN6PR03MB2868:EE_
X-Microsoft-Antispam-PRVS: <BN6PR03MB28682EB7BCBBACCCBDCCC7AF8F379@BN6PR03MB2868.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2887;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 2x6BA+NYlCU299tgbTBZthNoBkfy/t//S459VndGuijekLvowuMpgqJV2uEw8mLIXmlc+O/NO1IH0LkUyCou3APD+t8B9NP641mYBQ0vlYoJ631JgoIXnwF76+BlN69eVl1LaCwJnlgk+ZjrX6xQTZF2iVLz6IwzNYC1OopU1kCo54mZlG99uGc19Us83GkzDdLlrL9Nvb/58qlIRRX667aoyAhxDtpiv7uGZxO3TyPA4i7drdRh2UhAlFnnePSyZfb4SVJah+e2+xXpsfz9KArKWsrcuiLZGsZ3G5VjCCCo6xjvca0gw1iVmLJhknSVemjtfji2uSd8uZCo8kKU7ZXQKlSdcSb+JuvPgz1jhQHkb12JBcvti4wVEB///zdCtEe5iCSpDuA3CXKwcWzXMrSaStX1mymZHFoiOXb8S5MCZzxehiCnFhJl1wKZO5UogLOqeEyk+5P231qwXiIJR8IJn/9KRq8oxLV5s7QU5vnNIOT5NE+y2PY0AUquq3hkLJ3QcCbqpR9Zg0vjEyTq69dMEn8rwvwLNt7ywsPu3Z8V5yaFaLamDcOdtm2sT40ZQpO8ItTPlSGpxEpcPr3U0p+0iS4guZGzD3XbCPYZQ2a5Mh2eCzwtcNiDI0gEqxJCzfCvDcKnE1PC7tZ+uYnj3YHtLzoVCxL8AmN7MNY9Qa307zzUAnEvsnJzDKwCIaUeoh1BfgGjHVyvshVXraI0yA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(8936002)(53546011)(82960400001)(8676002)(66556008)(4326008)(86362001)(316002)(2906002)(85182001)(83380400001)(6666004)(26005)(6512007)(186003)(6506007)(508600001)(33716001)(9686003)(6916009)(38100700002)(6486002)(66946007)(54906003)(5660300002)(66476007)(67856001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TkFDNEkzZVJNRUVYc2RPUU9CRDlYQ2U3NVduUldsQW5ER1ZjSFNoMHk5end2?=
 =?utf-8?B?eHpIRkhTekhGSW84bGlvODBmUXltNm5jRSsvZFFkVFl5YWd6cENsdXJ5d1pI?=
 =?utf-8?B?UGRjc1pWZHUvWCtLV2JENkF6SXZwYktVN0NKSmVpMzdBVlR3cGpNaUMyRENI?=
 =?utf-8?B?WmRTbXl0enJwcUU0VkVKVjlGa3RFK0xKRFd5QWR0aWhWNUU0c1hzSjVhVVZE?=
 =?utf-8?B?K05vOUlNeVZBZi8zTElZMjNicmEwZVlmYTZFQWVyREMwQ0hIN2FSQmx1REtm?=
 =?utf-8?B?TFNWcjFWOThXcndpUkpGSWM4RERXSGxJSzZEdTFiZDVLNXdjb2VBZkdNRzV2?=
 =?utf-8?B?M2hEWkVtMkM0U3dOaTVEK2dGMFJkelNiRE91WUJuZUpsdFB2RmhHOEtyb0ZQ?=
 =?utf-8?B?MnZiRnhTSzBKZ242STA5TDZ2YTNYSGpuZVU0MmxiUFpHZWVLTFpWR2ttWWRy?=
 =?utf-8?B?ZlV3aWl4QnBCdmVoalZVbElackZsYlN3VzZURlR5SkJhMHRqR1REalpYN0pq?=
 =?utf-8?B?dzFnZ1BsaUw4SVpwVFM4eC9FVTZFaE5XYm5NbzZveUtKVXlBOGUwYWJhRFJT?=
 =?utf-8?B?cXd4U05WcUwvVVBiM0xQakI3NDNaYjdCaWxlVjlHbWtzMDlVbVdYV2JTb2l5?=
 =?utf-8?B?a0Iwc1JDZ3NQQTd2K2RTOVkwcUE3OVR3eHpjeStlOHNpazNjU2NaUUsxdWl0?=
 =?utf-8?B?cFllUGxZV2JLQ0pzWEJoSitidE4vNVBqemlJdHhyVVpXYktXZDByb0l0eVpQ?=
 =?utf-8?B?MHBIblhOZ0VGVWtNVTVZQktKWHU5Vkp5RjNRenJFTlgzWitHQVlldUl4NmIv?=
 =?utf-8?B?N25pUDlSSGYwOS8yVTJlSzV6YnUrdjVxTmhFWjZkc3NCME95U0drZWl1WUVk?=
 =?utf-8?B?UnVBKzFOQkFkWVlPdTVNWEQ3R3RHRFFZWTFoa2Y2TGFwMFp4cktkeTBNRDJS?=
 =?utf-8?B?cm1rNlZ6NmVadjVTREo5Z0NkVFY3ZXBjV0RCblZNTEhPVm5MTjFmUHpZdVhU?=
 =?utf-8?B?cGVuaXg0M1NWWDZXR3dSR01VTUo2cktXenZWRE9hVDVvUVRoY2FqNTUxWGRo?=
 =?utf-8?B?UVZGbmVPanRPZm1YclM2ejFXYkZ3cEt6d01aaVN6VUp6TWlRSVk4Y2t0WDdF?=
 =?utf-8?B?Sk8yV0hmaTlxRmVPakdWY2Nzd2tEajNzZStTMDY2bUlFdEhMcFQ5bENNa2k2?=
 =?utf-8?B?OHJBbWlwSlhhSUxUUGx6dXAyQktlcHNXM054bHIveGg1c2pSOWh3UUp4WFhj?=
 =?utf-8?B?K1ROSUVRQjdaV0tFNUZ2bEQ1Tmk2QVJTdGY3V0FLMnFUNVZ1dkZmVUxsOGlQ?=
 =?utf-8?B?SkhyeURyWi9TcDVsR1dCcUdYYytSZ1VMVDVtTVdlTGIzTFNiUnJqWDlxUm0v?=
 =?utf-8?B?cTJiclFNZnNLS05ZRVVIYUVtNFVsM2VXUFcrYlFzN0R1cGU0dmlMaDhrOUpz?=
 =?utf-8?B?WVZYdjJTNmQ4anpzZTRsRUthdXc2YU40eTBsUURJekQ5NitaZzMrUno1NEpZ?=
 =?utf-8?B?aUp4YW1TT04yK0FZOG12TXdiT0lsOWNqc2tiSWs1emNEMzZqVC9ud2Y0UzFl?=
 =?utf-8?B?WWI4SU9KS1h3WjhTdXRkaVpTZHhzL3VJM0Q3bzZBeEN0QUhtMGVKd2w4d0tO?=
 =?utf-8?B?MzFWTVNsSy9JTEl0ZTE4ZDFSWDArTzQ1ZzhEQ09NM3VyVlI0QnQ1L0NTQkpr?=
 =?utf-8?B?enlkdVJvNUhMeG1xdUZEWk12d1A5TjRBbE5wQW83NC9DSEZRVzcvYlBXYmY1?=
 =?utf-8?B?K3BVSFRSbEtCdUtZVUxXVC9tdXFNN2VhMWtsQ2ZRdUkvazBNT2MvUlFGL0M5?=
 =?utf-8?B?dm1MQXpFeU1CZ2ZVWlo0T055c0liTWZiUHEybkQzUDNRWW5rV282emtNWmJS?=
 =?utf-8?B?WnhsNGhoWlUrRDFIZ2tZNE9GdzEwODVTMGx3aTF5TEZ0QVNrcVU2U2IybG0x?=
 =?utf-8?B?SWttb2dpUHdaY0czclNrZUF1YmlaYVJ6SGJUcDZNdlJHcnU3WXZGUW1KZFBh?=
 =?utf-8?B?VXVKdFRXUmdaTmJLUG9ZVnJ4bDJMMGNxb05RKzRpVHl4aW1PRnJOaWorQ3do?=
 =?utf-8?B?amkxU2cwa2I0V0lDYTVaQk4yMFg3UXdNaUhDNmc2V1RJQjFER2JMalh5REZh?=
 =?utf-8?B?Y0gzMVhqTzJleEt5UVhvSXpDaTl2Q0R1Z2VrSjV6MmZUc3FGWnYrS0FmZU1p?=
 =?utf-8?Q?rzPE9UI4z7QlBI53vssZv10=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 87282880-412c-48b5-91f6-08d9f2e39dd6
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Feb 2022 13:36:07.0781
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NGfePxJYKDBnGSHlZO7bLLiAU8WJgj8/jn5m9Nb2rY1rlvTuUZNwVDcrHkhKR/edomyZ4pakePMYbm6ElyF0FA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2868
X-OriginatorOrg: citrix.com

On Fri, Feb 18, 2022 at 12:23:47PM +0000, Andrew Cooper wrote:
> On 18/02/2022 12:21, Andrew Cooper wrote:
> > On 18/02/2022 12:00, Roger Pau Monne wrote:
> >> Add a workflow that performs a build like it's done by osstest
> >> Coverity flight and uploads the result to Coverity for analysis. The
> >> build process is exactly the same as the one currently used in
> >> osstest, and it's also run at the same time (bi-weekly).
> >>
> >> This has one big benefit over using osstest: we no longer have to care
> >> about keeping the Coverity tools up to date in osstest.
> >>
> >> Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
> >> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> >> ---
> >>  .github/workflows/coverity.yml | 35 ++++++++++++++++++++++++++++++++++
> >>  1 file changed, 35 insertions(+)
> >>  create mode 100644 .github/workflows/coverity.yml
> >>
> >> diff --git a/.github/workflows/coverity.yml b/.github/workflows/coverity.yml
> >> new file mode 100644
> >> index 0000000000..12fc9c782b
> >> --- /dev/null
> >> +++ b/.github/workflows/coverity.yml
> >> @@ -0,0 +1,35 @@
> >> +name: Coverity Scan
> >> +
> >> +# We only want to test official release code, not every pull request.
> >> +on:
> >> +  schedule:
> >> +    - cron: '18 9 * * WED,SUN' # Bi-weekly at 9:18 UTC
> >> +
> >> +jobs:
> >> +  coverity:
> >> +    runs-on: ubuntu-latest
> >> +    steps:
> >> +    - name: Install build dependencies
> >> +      run: |
> >> +        sudo apt-get install -y wget git bcc bin86 gawk bridge-utils \
> >> +          iproute2 libcurl4-openssl-dev bzip2 libpci-dev build-essential \
> >> +          make gcc libc6-dev libc6-dev-i386 linux-libc-dev zlib1g-dev \
> >> +          libncurses5-dev patch libvncserver-dev libssl-dev libsdl-dev iasl \
> >> +          libbz2-dev e2fslibs-dev git-core uuid-dev ocaml libx11-dev \
> >> +          ocaml-findlib xz-utils gettext libyajl-dev libpixman-1-dev \
> >> +          libaio-dev libfdt-dev cabextract libglib2.0-dev autoconf automake \
> >> +          libtool libfuse-dev liblzma-dev ninja-build \
> >> +          kpartx python3-dev python3-pip golang python-dev libsystemd-dev
> > We dropped gettext as a dependency a few releases ago, and we don't need
> > python3-pip either.  Can fix on commit.
> >
> >> +    - uses: actions/checkout@v2
> > I think we want
> >
> > - uses: actions/checkout@v2
> >   with:
> >     ref: staging
> >
> > Can also fix on commit.
> >
> > Acked-by: Andrew Cooper <andrew.cooper3@citrix.com> (mainly because I
> > can see that Coverity has done the right thing with this.)
> >
> >> +    - name: Configure Xen
> >> +      run: |
> >> +        ./configure
> 
> On second thoughts, we can probably --disable-docs here, because it's
> just wasted processing time when all we care about is the C.

We do not build the docs already, because the build command is `make
xen tools`.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Feb 18 13:36:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 18 Feb 2022 13:36:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275435.471309 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL3Qp-0006TL-VF; Fri, 18 Feb 2022 13:36:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275435.471309; Fri, 18 Feb 2022 13:36:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL3Qp-0006TE-S1; Fri, 18 Feb 2022 13:36:19 +0000
Received: by outflank-mailman (input) for mailman id 275435;
 Fri, 18 Feb 2022 13:36:18 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=6Z2s=TB=citrix.com=prvs=041b9fbab=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nL3Qo-0006CK-7f
 for xen-devel@lists.xenproject.org; Fri, 18 Feb 2022 13:36:18 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id bec27801-90bf-11ec-8723-dd0c611c5f35;
 Fri, 18 Feb 2022 14:36:17 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bec27801-90bf-11ec-8723-dd0c611c5f35
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645191376;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=B6Z/6EC7+xjySVFa9pp0oCDTOKjG4jLyxrlZIt00NPY=;
  b=VgVmWOMCJpwuA4MgCo7MTdrXtbvV2jU1P94RWkyyGtrgh5dByOP1vc+n
   2Xi9yw98WFx/vlb3wEu0kdp7QriCXFQJ+skdxUCTngrDbrY2x3b0ew/s3
   5rZK2C69soXDbAMknFl3cOhXaVK5N8khJMC3LjT1ukbCSD4g9/foLDudb
   0=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 64413323
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:PcI1xamNs0zyhZiEvugtlDXo5gyTJkRdPkR7XQ2eYbSJt1+Wr1Gzt
 xJNXzuOaPyKYGShLt8ka4+29EsFuJLSztdkSgI9+HtgRSMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2UILd9IR2NYy24DjWlPV4
 LsenuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR
 v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ
 NtxWZOYGVlwJLL1tsghQ0NyEyZjH4EX35bKPi3q2SCT5xWun3rExvxvCAc9PJEC+/YxCmZLn
 RAaAGlTNFbZ3bvwme/lDLk37iggBJCD0Ic3k3ds1zzGS90hRojOWf7i7t5ExjYgwMtJGJ4yY
 uJHNWY2N0+aOHWjPH8JA7sikMOi2kDYVGdChFO2tJo6zjnMmVkZPL/Fb4OOJ43iqd9utlmcj
 nLL+SL+GB5yHMySz3+J/2yhgsfLnDjnQ8QCGbug7PlojVaPgGsJB3U+V1G2vP24gU6WQM9EJ
 gof/S9GkEQp3BX1FJ+nBUT++SPa+E5HMzZNLwEkwFHTk7DL2ii1OnheZD5Gdf4K5egfSCN/g
 zdlgOjVLTBotbSUT1eU+bGVsS6+NEApEIMSWcMXZVBbuoe++enfmjqKF48+S/Dt0rUZDBmtm
 2jikcQou1kEYSfnPY2f9EuPvT+jr4OhouUdtlSOBTLNAu+UieeYi22UBbrzsacowGWxFADpU
 J04dy62tbFm4XalznHlfQn1NOv1j8tpyRWF6bKVI7Ev9i6251modp1K7Td1KS9Ba5hYJGazP
 BeC5V0Ivve/2UdGi4cuMupd7OxwkMDd+SnNDKiIPrKinLAqHON4wM2eTRHJhD28+KTduao+J
 Y2aYa6R4YUyUsxaIM6Nb75Fi9cDn3lmrUuKHMyT50n3gNK2OS/OIZ9YYQTmUwzMxP7dyOkj2
 40EbJXiJtQ2eLCWXxQ7BqZJcwhRdCBjXcqeRg4+XrfrHzeK0VoJUpf56bggZ5Zkj+JSkOLJ9
 Wu6QUhW1Bz0gnivFOlAQikLhG/HNXqnkU8GAA==
IronPort-HdrOrdr: A9a23:4KHWzaDzljvbjgvlHegKsceALOsnbusQ8zAXPh9KJyC9I/b2qy
 nxppgmPEfP+UossHFJo6HlBEEZKUmstKKdkrNhQotKOzOW+FdATbsSo7cKpgeAJ8SQzJ8k6U
 4NSdkdNDS0NykGsS+Y2nj6Lz9D+qj9zEnAv463pB0BLXAIV0gj1XYCNu/yKDwqeOAsP+tfKH
 Po3Ls/m9PWQwVwUi3UPAhhY8Hz4/nw0L72ax8PABAqrCOUiymz1bL8Gx+Emj8DTjJm294ZgC
 r4uj28wp/mn+Cwyxfa2WOWxY9RgsHdxtxKA9HJotQJKw/rlh2jaO1aKvi/VXEO0aWSAWQR4Z
 /xSiQbTp1OArTqDzmISC7Wqk7dOfAVmiTfIBGj8CHeSIfCNUwH4oJ69PNkm13imhYdVZhHod
 F2NyjyjesmMTrQ2Cv6/NTGTBdsiw69pmcji/caizhFXZIZc6I5l/1TwKp5KuZKIMvB0vFsLA
 CuNrCq2N9GNVeBK3zJtGhmx9KhGnw1AxedW0AH/siYySJfknx1x1YRgJV3pAZOyLstD51fo+
 jUOKVhk79DCscQcKJmHe8EBc+6EHbETx7AOH+bZV7nCKYEMXTQrIOf2sR42Mi6PJgTiJcikp
 XIV11V8WY0ZkL1EMWLmIZG9xjcKV/NFQgFCvsurqSRloeMMYYDABfzPmzGyfHQ0cn3KverL8
 qOBA==
X-IronPort-AV: E=Sophos;i="5.88,378,1635220800"; 
   d="scan'208";a="64413323"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Vnu1/PnGFhKmJyxAplcIo5OKq0MFexOSnnYfXxB8c4fkECZ1yG3ToFFpQy8F3QzPTZCMUVUewGwLopzilZbDjTcnRilkGPRcQpNz7mg2Sm0ZPKGn/UQ7kVlkaoqkC41NZVk/Y9QH6S54YujpSDorK3axk2XxfLpZLUVl9CH8ijHEiMjkFRfN9Hmq6/Nzjg1IDVDjw0V6r6etXvLvPxyDh7LYn+qRwGHoKG2jolpqYPIy0u6wx0PFNmsErIr0wtppkcC5E2TA5uREpD1oi/qkkwGR7R2Fk98U7ZTqSW3LZjakgu+nqpo6Ge4SDTSUnLbyeGGHRMyqwknFT6TPVTriNA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=B6Z/6EC7+xjySVFa9pp0oCDTOKjG4jLyxrlZIt00NPY=;
 b=EFJiSe0JNzObX3Bmu8F5rAqD7A6vrVjLb6b40YAdE+33G85fo5kNS/AJaTi2Gb6cnbumRtF5DZK6h/8X/zClbD1IJTFP0Ju7Iyn2NwsEtPXow7ls8yqeIqa51Hzg17s2d8E/KMj/y+nuX3g/PVncI6Y/Jv5BIZ3Zd00qHLw1gxygdVw9idFrUX2wqvc/KCoX3SBX3c2+TwBmEbEK2JjXQl2DVVLoQDXkDRB0ElfYkhY+LxWurlie+OdflJX5x7fVQZS2dSSLDsWCgeZNpGk3i1MerDo2aRbqWjd0y5aGRFKUK69JNRVs1lQ4g8Y1+F8UOcRwgva0qYhHR2Cpmc25pQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=B6Z/6EC7+xjySVFa9pp0oCDTOKjG4jLyxrlZIt00NPY=;
 b=suubCDwliNK9sgcYwQye9wiJDO4MiOAYaqfqGnsQYi+AzbuSN7IjhltwiZAjufi+gQ8yiKixodLwpfl45Rm5vEWwd5Evrqt2KZXWgfrfzUVnQWbilVO4b7Zl4vQfN9lPNmDXKtF4Di4xFLvmas5xtvSTuyQRc5mFzvcd7UZBoH0=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Wei Liu <wl@xen.org>, Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH v2 09/12] video/vesa: unmap frame buffer when
 relinquishing console
Thread-Topic: [PATCH v2 09/12] video/vesa: unmap frame buffer when
 relinquishing console
Thread-Index: AQHXUvS6bSKgeOnvKUm16fE8JrtG66ya8xKA
Date: Fri, 18 Feb 2022 13:36:11 +0000
Message-ID: <c491c1a4-67c2-d689-5fc9-aec64deffaa1@citrix.com>
References: <8f56a8f4-0482-932f-96a9-c791bebb4610@suse.com>
 <843f440e-039f-ca0b-6ac1-a4d50559d5bc@suse.com>
In-Reply-To: <843f440e-039f-ca0b-6ac1-a4d50559d5bc@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 9823fde8-2471-4afe-a1b6-08d9f2e3a0a0
x-ms-traffictypediagnostic: BYAPR03MB4837:EE_
x-microsoft-antispam-prvs: <BYAPR03MB4837F342729A00716670867BBA379@BYAPR03MB4837.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:2657;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 1SpKVl2+OnvaOMS4u0uCtHsmcVSyIXBt45LjXT6vl1JeB7XTx1THM3UzBGxrcj6KqwQA7mwAqT5r5pynCNcvCd+iUwnI5e33nwGpqp98q+b6wgSIOyoV9ogQM3Y46L1WyehNPQuzQvGns9KuEeyZ2Pe+Gdp6hmrzS6+Sx4km4DexfJtC0KVLYbd1MY7h2L+eP/KLHa73xAbTso3whx5G8Oc51Ri+RVDVmWVgKuDlKvt/NAX5klF2QyNCQYMi+5A9dU7Qpv6/bSnTqoxtmmKQWsxfKQgNmi6fE0RV/eEh0qTj7UgdKIAnBrnwlX2N1pTKudTlYGwG9F/2g4UVNurg5oYGNLJ1yYWSokslymLMlwHdRSCgBLjjYZSrIPHHvkBtWPIDg8itNJp9GrEEzkrSiK+hdT1ODO11zpaeCfh7x5OtTtfQc7H1mtHR1fX3U3hccmM4MPEQ1RIEG+Dic+hYWzvZo6PTVrvr7IvwnYfYCjEEopqGJ/5UrKoyekj9k+rkun4eu3Z4nGXdqvQuKn2pmdleUWpg/en9sC4Rwgmz7KTMuyiQdaI4D0H0ADnl28IFmbCZOsgmqLzUuZLvjXWMmMGe6hrlfw/Y7Xl/HWahOvvv8q9PRQZpDkGxcSBeoBlB1sdvKRdRDSvq1dxKZbrr3ia/fO1ogmw8U0g6fjZcm2H0uHwewU0fs+5BCceyE7ZYyfMZm97tttAosdK7hIju279H4RXjXPpvR5Daw1HuVzxxKbIabI/YhEBE9MDemn/ZQqVgZOJoBiz6RpGctoGf0Q==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6506007)(107886003)(71200400001)(8936002)(26005)(31686004)(6512007)(508600001)(2616005)(53546011)(110136005)(316002)(36756003)(64756008)(5660300002)(38070700005)(54906003)(91956017)(4326008)(186003)(31696002)(2906002)(38100700002)(82960400001)(122000001)(66446008)(66556008)(558084003)(66946007)(86362001)(66476007)(6486002)(76116006)(8676002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?ZjdVeldsYlR5ZUNBSVkreHBnSE02Y21BQ0RjWmZJTDhPaVczQWZUUEh5d1lJ?=
 =?utf-8?B?VUhLelQyeXQ2TTRPWUdSMGlYRFNaalZVTjR6VjlJcXUwUlNEbXJYL3ErdENn?=
 =?utf-8?B?UStZenRSRkZQcWJLMGplWHF5VVhob01OZTR3Tkg5bHJsaFRNZlJLWHlFOXJ6?=
 =?utf-8?B?c2RnaDg0RHFMNXI0eTJJZzNLamVwOFlGYldNVjR1WGI1RWkzQTY0RlBqOWow?=
 =?utf-8?B?WUx4S08rYWgrNWZlTDhDc09qaVVYQnBrUHdTS0xSMmR2SmRBMU9uWksxNlNw?=
 =?utf-8?B?dHB3UzM0RkRXMjJwSEF0VUFITmd4eXRZVVIzM0pLMDdxZmphT1Fvb28zb1Z4?=
 =?utf-8?B?N0Q1RlNKZ2tNMFpZWFRpWE9jMnY0OGR0MlRiZzlOT2lNRWdRaXVGUm45ajk4?=
 =?utf-8?B?cG5pVGJYODRac002aXBndU9oeVBib3prU1VXa3Q3cGxnbTRvRDdkYS9aYVRF?=
 =?utf-8?B?R0h1SW1QRU5UMG45VjFZMU5KK21KU3F3dXo3UW8yRXNFQVk5N1loUGcvZ202?=
 =?utf-8?B?YmxrM1JlZGM5V1ZMaGhrUWdGWWZLd0NXb3c5U0NWRDJJUVhLc2lnejUwKzFL?=
 =?utf-8?B?aHBnVEx3dUZ6K0ZwWmRVOTRmMTZURjRCdm85dzNtaDlSNDhqemNmTmlOb3E3?=
 =?utf-8?B?SnBXdFBFWElnTy9KL29uTW1QTFNFSWV3ME9DaFNoUTJjTCtSWG9NVFRqMWV6?=
 =?utf-8?B?YXJTSklWdmFUTHliWEMrWmJXZGlySk9pNVI1b0lMZHN0Z1JlT2FaRnh5SlUy?=
 =?utf-8?B?akp1cXJVT0dTRGhoVWNPNGRZRU9ReEkzck5VRjRzZlNPaURLaExHTmdQS09l?=
 =?utf-8?B?UU1EVVp3cndWM0RoMmlXZU5lL0g1OGJzanFiVnhxaUREZml4MTFwVldYTTRI?=
 =?utf-8?B?d2JjZUp6allqTnM3M20yKzl1MjA3QjFtR0ZvUnV3TzJ1eXdpSlJXQU1mL3R0?=
 =?utf-8?B?WDVrZXU1YitlMVg5TUhyRTQ0OWUwVjBLWUhSdEFIdExqUGdMVTM2bXFFdnN0?=
 =?utf-8?B?VlkyZkJJRGdpWDRYdHZaV1lVR21LTktvUzdsR3JnRVFobDhFMTJyekZTMTFy?=
 =?utf-8?B?ZzR4SDA1a09JMTJKSXBoNDJkaEY4ZTBBM1JHb1lSazVOcGFEKzlEczBRbDlN?=
 =?utf-8?B?dlMxZXJMZ0pNaXNYZHZDTWpuVXNSWW5ZSlRDVWVITXBDYWk2RFZzRzF1SEhx?=
 =?utf-8?B?U1UwbGkxbEFET21qb3N1L010bW1Ya0trUUpRNVFGV1p4U1phMGRKVGkybnF0?=
 =?utf-8?B?Y2ZVVjd1Y3VWSEpsL1NpTE1mSHR3Wkx5WnF6a3NzRWFOTVRpdUNOSHJkeVUr?=
 =?utf-8?B?emYrSmJSWjR5UjhLYW1PbHlhT1RHR2xsNUM5WmpKTnpJdTVDQndibDkrMWFv?=
 =?utf-8?B?TElhVTc3NXJQNVlxRE9mQzFUaGRBN2U0Q2ZxVkhqcmFSWUtSTWRvU3VFOGtJ?=
 =?utf-8?B?bDUzbnBVcE5TWWJaSUxONklITy90Z09BbXdoZkd6WmJwalVlN3lGM1FuMG1u?=
 =?utf-8?B?SlBFRllJdkk5MHM4Ynl3dTlKSVVBL1lXRWhCeE9JYkI3SGlhcUVrQy9sL0hR?=
 =?utf-8?B?Z0gwTTVWQlNFSGloaU9EZTBYR2RxSHBCN3FCejVqSW5HL0drdTN1SG9LMDN3?=
 =?utf-8?B?cjcxVFhjUmdJWkN2Z1Fzc2k5V2lCQTJvc1paMUdVQktGN0YyUnpmZU0rNi9p?=
 =?utf-8?B?TkpqTldKZUVqVVA2bnFsZk9vVkJHQjIzaGlJUEJ1YSs1R2RBQWZyTmhCM1JZ?=
 =?utf-8?B?bEhxNjR4cmx5bDhuc3lZc1JBa1NFeExKUllraUMzQUpCVEx4c3VCYmEzWnRX?=
 =?utf-8?B?SWNMSnlBeDM3NkljMlgvQ25TdEMxWjZUSy9FdzBkV2FCU0FPSCtWVTA3Y1c1?=
 =?utf-8?B?OGdjKzY0L05McnFaekE2TEpuRVhqbndLKzJ4dGduSXVNQ1Z6WndST0I4Tndl?=
 =?utf-8?B?VFNQSXFEaEMycXVPaUpHSm5KYkFZdzdWYkVmSTBqTjFlWVU0ZXFLM1VFK1lN?=
 =?utf-8?B?R0JYVGVlSnJFTStHRHhOcDdQMFdiQmZRUnhOZFJoTVlqc3pWS1RFaDU2cER4?=
 =?utf-8?B?WjZ0cElNTFhwakFJR0I0L1lMOGFJcWVPVVM4TlRYcnArMHZNWjlPTUNvVHdX?=
 =?utf-8?B?NElTOXJiSjAxUzhjdW5sZkplelVIQldqRklqM1labEJVQm1nS3JEQWI4UzRH?=
 =?utf-8?B?QXB5aWxBdk1COEhHMWxIYXRCaXNKTmdyU1FYZWtWdVdsdFBkbzNYK1ZUbmFa?=
 =?utf-8?B?RlorQitZZ1FkNTdVNlZqUis1dlZ3PT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <212005125E1BCF478D005B56FE07A070@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9823fde8-2471-4afe-a1b6-08d9f2e3a0a0
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Feb 2022 13:36:11.4609
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: eNdF+PBnd09wWqEpNpMgs3KFFsQ0BBMBA1ZKE7CpdY0gC7/NcEUafnt+L2ZN9NZ+JRsh6NsroAifFLzla7e0Rdt4/0a9pnXvtwsCRGEzuBc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4837
X-OriginatorOrg: citrix.com

T24gMjcvMDUvMjAyMSAxMzozNCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IFRoZXJlJ3Mgbm8gcG9p
bnQgaW4ga2VlcGluZyB0aGUgVkEgc3BhY2Ugb2NjdXBpZWQgd2hlbiBubyBmdXJ0aGVyIG91dHB1
dA0KPiB3aWxsIG9jY3VyLg0KPg0KPiBTaWduZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJldWxp
Y2hAc3VzZS5jb20+DQoNCkFja2VkLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0Bj
aXRyaXguY29tPg0K


From xen-devel-bounces@lists.xenproject.org Fri Feb 18 13:39:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 18 Feb 2022 13:39:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275451.471320 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL3TR-0007Uu-GP; Fri, 18 Feb 2022 13:39:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275451.471320; Fri, 18 Feb 2022 13:39:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL3TR-0007Un-DJ; Fri, 18 Feb 2022 13:39:01 +0000
Received: by outflank-mailman (input) for mailman id 275451;
 Fri, 18 Feb 2022 13:39:01 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/ZS3=TB=gmail.com=bjolson1278@srs-se1.protection.inumbo.net>)
 id 1nL3TQ-0007Uf-V7
 for xen-devel@lists.xenproject.org; Fri, 18 Feb 2022 13:39:01 +0000
Received: from mail-io1-xd2a.google.com (mail-io1-xd2a.google.com
 [2607:f8b0:4864:20::d2a])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 20628dfd-90c0-11ec-8eb8-a37418f5ba1a;
 Fri, 18 Feb 2022 14:39:00 +0100 (CET)
Received: by mail-io1-xd2a.google.com with SMTP id q20so5251271ioi.0
 for <xen-devel@lists.xenproject.org>; Fri, 18 Feb 2022 05:38:59 -0800 (PST)
Received: from [192.168.122.77] (68-168-187-203.fttp.usinternet.com.
 [68.168.187.203])
 by smtp.gmail.com with ESMTPSA id x14sm3375799ill.88.2022.02.18.05.38.57
 for <xen-devel@lists.xenproject.org>
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 18 Feb 2022 05:38:58 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 20628dfd-90c0-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=message-id:date:mime-version:user-agent:subject:content-language:to
         :references:from:in-reply-to:content-transfer-encoding;
        bh=ftto2S0yErh3khVzh/U/wtVZFfGeIHj49Z7MrFjrxt0=;
        b=JQwWMF1YZSEqQf7hF8AxFg3xREm5jy2QXfGg9NExYaW7v9qNlTqABPsI72wwViIDg+
         96NtdAWV4ZOxiV3efoQ3qUNmX2iJlt5TYcess7BO2qYZ12Eqimfp1iTyFwCzrIJ7Tk6b
         aJMji3eTzxLLUZlZeNcI/pLbVNzhNHwQwuJ4SbQRGjeCKrEVYeGPbqkSChy2bv3yJhiz
         asyQ1mV2qr2gDgx+XN1mmEy8p/NvhiyjihETxY/iPwCErUY/jyC6q+a+i0ZJoph3hmr2
         8zbNEk3E3LFtzHU5xAchGhwmOM4KVHp6nhD7ElsERoRzw9fQf3yy2FbkDv9zs99A+vPS
         f8IQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:message-id:date:mime-version:user-agent:subject
         :content-language:to:references:from:in-reply-to
         :content-transfer-encoding;
        bh=ftto2S0yErh3khVzh/U/wtVZFfGeIHj49Z7MrFjrxt0=;
        b=oOfYAdcBMIdDmMddaylqpDR+HSsAyYN7e9f9guSGRQQEzj2zZ/YLj2EBi5z6njLFBy
         A/unmFt85bagrxoeOQvXHwDUZ7k8N57ABrBK5F+0BwgLR2x73t1cUzPGYnfIP/zlAk7m
         XCUKAJ3L3SRSBpitBYH57WIOIQJ9cjxXefdc495db2O9DLu7yxpzBxmB4bxQVfn8pFgp
         fRC3ao8S1uYomDSqtiguZnWvYMQYV6s57MC9e1DtXIZcFCXRNUGOhvZIhLqgsnaxBALQ
         zmGMTNtpAlUyljefIxdYntD0HTuVx34Z0y2okPFn01D6p0MaBa5MvmJ8u8u4XlrkTEYM
         3JOg==
X-Gm-Message-State: AOAM530QDyxbUXbEdtEpXKNDFWpr7xsKLE4TafaiPUydB7OpJ0cJIWNC
	Q1BiSW8aMqlX74/nBbKPJ4irzDJt9xZww6Ux
X-Google-Smtp-Source: ABdhPJya2nL/hIYyr9wKq1X1YFV0zBCXIMGj/SKq9ukrWmvyeh+CoSYC+9V5wsoWMPW+k0AMZ0XvbA==
X-Received: by 2002:a05:6638:d87:b0:30f:6208:19fa with SMTP id l7-20020a0566380d8700b0030f620819famr5434995jaj.204.1645191538632;
        Fri, 18 Feb 2022 05:38:58 -0800 (PST)
Message-ID: <a44ed8cb-0bdc-0f6f-fc6e-7f831605a71c@gmail.com>
Date: Fri, 18 Feb 2022 07:38:57 -0600
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH 1/2] github: add workflow to run Coverity scans
Content-Language: en-US
To: xen-devel@lists.xenproject.org
References: <20220218120042.32102-1-roger.pau@citrix.com>
 <20220218120042.32102-2-roger.pau@citrix.com>
 <0eeb8f5f-d049-8a8e-9e65-d1966c21a781@srcf.net>
 <34ebc66c-e55f-3f98-b769-0e73bdf3c2fe@srcf.net>
 <Yg+gwfRqetYoT4Th@Air-de-Roger>
From: Brian Olson <bjolson1278@gmail.com>
In-Reply-To: <Yg+gwfRqetYoT4Th@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Can someone please tell me how to remove my email account from this 
list? Thank you.

On 2/18/22 07:36, Roger Pau Monné wrote:
> On Fri, Feb 18, 2022 at 12:23:47PM +0000, Andrew Cooper wrote:
>> On 18/02/2022 12:21, Andrew Cooper wrote:
>>> On 18/02/2022 12:00, Roger Pau Monne wrote:
>>>> Add a workflow that performs a build like it's done by osstest
>>>> Coverity flight and uploads the result to Coverity for analysis. The
>>>> build process is exactly the same as the one currently used in
>>>> osstest, and it's also run at the same time (bi-weekly).
>>>>
>>>> This has one big benefit over using osstest: we no longer have to care
>>>> about keeping the Coverity tools up to date in osstest.
>>>>
>>>> Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
>>>> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
>>>> ---
>>>>   .github/workflows/coverity.yml | 35 ++++++++++++++++++++++++++++++++++
>>>>   1 file changed, 35 insertions(+)
>>>>   create mode 100644 .github/workflows/coverity.yml
>>>>
>>>> diff --git a/.github/workflows/coverity.yml b/.github/workflows/coverity.yml
>>>> new file mode 100644
>>>> index 0000000000..12fc9c782b
>>>> --- /dev/null
>>>> +++ b/.github/workflows/coverity.yml
>>>> @@ -0,0 +1,35 @@
>>>> +name: Coverity Scan
>>>> +
>>>> +# We only want to test official release code, not every pull request.
>>>> +on:
>>>> +  schedule:
>>>> +    - cron: '18 9 * * WED,SUN' # Bi-weekly at 9:18 UTC
>>>> +
>>>> +jobs:
>>>> +  coverity:
>>>> +    runs-on: ubuntu-latest
>>>> +    steps:
>>>> +    - name: Install build dependencies
>>>> +      run: |
>>>> +        sudo apt-get install -y wget git bcc bin86 gawk bridge-utils \
>>>> +          iproute2 libcurl4-openssl-dev bzip2 libpci-dev build-essential \
>>>> +          make gcc libc6-dev libc6-dev-i386 linux-libc-dev zlib1g-dev \
>>>> +          libncurses5-dev patch libvncserver-dev libssl-dev libsdl-dev iasl \
>>>> +          libbz2-dev e2fslibs-dev git-core uuid-dev ocaml libx11-dev \
>>>> +          ocaml-findlib xz-utils gettext libyajl-dev libpixman-1-dev \
>>>> +          libaio-dev libfdt-dev cabextract libglib2.0-dev autoconf automake \
>>>> +          libtool libfuse-dev liblzma-dev ninja-build \
>>>> +          kpartx python3-dev python3-pip golang python-dev libsystemd-dev
>>> We dropped gettext as a dependency a few releases ago, and we don't need
>>> python3-pip either.  Can fix on commit.
>>>
>>>> +    - uses: actions/checkout@v2
>>> I think we want
>>>
>>> - uses: actions/checkout@v2
>>>    with:
>>>      ref: staging
>>>
>>> Can also fix on commit.
>>>
>>> Acked-by: Andrew Cooper <andrew.cooper3@citrix.com> (mainly because I
>>> can see that Coverity has done the right thing with this.)
>>>
>>>> +    - name: Configure Xen
>>>> +      run: |
>>>> +        ./configure
>> On second thoughts, we can probably --disable-docs here, because it's
>> just wasted processing time when all we care about is the C.
> We do not build the docs already, because the build command is `make
> xen tools`.
>
> Thanks, Roger.
>


From xen-devel-bounces@lists.xenproject.org Fri Feb 18 13:51:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 18 Feb 2022 13:51:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275458.471331 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL3fn-0001LS-Lh; Fri, 18 Feb 2022 13:51:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275458.471331; Fri, 18 Feb 2022 13:51:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL3fn-0001LL-Ih; Fri, 18 Feb 2022 13:51:47 +0000
Received: by outflank-mailman (input) for mailman id 275458;
 Fri, 18 Feb 2022 13:51:46 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nL3fm-0001LB-N3; Fri, 18 Feb 2022 13:51:46 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nL3fm-0002bk-G3; Fri, 18 Feb 2022 13:51:46 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nL3fl-000826-UY; Fri, 18 Feb 2022 13:51:46 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nL3fl-0001pA-U4; Fri, 18 Feb 2022 13:51:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=TMvv6NIRZKQlc8W1N/QkGzGTJyfcqXmdB0Im8f7H4fY=; b=jFsPAtuwJEzAtLKTBI2ddWDJfh
	TtA+1RctxVVKeRaEjuGbwS3ijWYv/cB8eufesTOL7/jYuJBF5xbFrGUBy88kp6M4Ovg9s7Ld96uwN
	P0i+sf4DwzSlT5Ba+npCmu5C1KAjCSbrykffOl1rtgmrKzGxuJwiJC4FRR/MknzxC/xs=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168159-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 168159: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=d2bc5a04c098057b09ceed7b4cf10b8726c9361f
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 18 Feb 2022 13:51:45 +0000

flight 168159 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168159/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              d2bc5a04c098057b09ceed7b4cf10b8726c9361f
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  588 days
Failing since        151818  2020-07-11 04:18:52 Z  587 days  569 attempts
Testing same since   168159  2022-02-18 04:20:19 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brad Laue <brad@brad-x.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Christophe Fergeau <cfergeau@redhat.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Divya Garg <divya.garg@nutanix.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Emilio Herrera <ehespinosa57@gmail.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Ivan Teterevkov <ivan.teterevkov@nutanix.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jing Qi <jinqi@redhat.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Lubomir Rintel <lkundrak@v3.sk>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nicolas Lécureuil <neoclust@mageia.org>
  Nicolas Lécureuil <nicolas.lecureuil@siveo.net>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Rohit Kumar <rohit.kumar3@nutanix.com>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  shenjiatong <yshxxsjt715@gmail.com>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tu Qiang <tu.qiang35@zte.com.cn>
  Tuguoyi <tu.guoyi@h3c.com>
  tuqiang <tu.qiang35@zte.com.cn>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Vineeth Pillai <viremana@linux.microsoft.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yasuhiko Kamata <belphegor@belbel.or.jp>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 98463 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Feb 18 13:58:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 18 Feb 2022 13:58:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275477.471369 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL3mV-0002Nl-NP; Fri, 18 Feb 2022 13:58:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275477.471369; Fri, 18 Feb 2022 13:58:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL3mV-0002Ne-KT; Fri, 18 Feb 2022 13:58:43 +0000
Received: by outflank-mailman (input) for mailman id 275477;
 Fri, 18 Feb 2022 13:58:42 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=6Z2s=TB=citrix.com=prvs=041b9fbab=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nL3mU-0002NY-CO
 for xen-devel@lists.xenproject.org; Fri, 18 Feb 2022 13:58:42 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id defde30e-90c2-11ec-8eb8-a37418f5ba1a;
 Fri, 18 Feb 2022 14:58:41 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: defde30e-90c2-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645192720;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=Jwxj837jYM/s1nhFzcMdZIK5ZKiAfGjY1tKn+bil6io=;
  b=YspsmNtrWf9G750Y9jLXbWNamcrGL6BaUTG5M1TUA25q46/2dQUCVLti
   qC9mK8YxmZReXcM83AYRf5NsuhC+TTrriDBAcDYJPQIH2OvH+c/66YbdG
   WW8L7dMKisaC55ZSSQCogZ+7KkVwoq+N2/JI3k0SMW+gTLvtyq9oyO0jI
   c=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 66762665
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:PCkb3qNsyPglBZ7vrR2fl8FynXyQoLVcMsEvi/4bfWQNrUol12QOn
 TYcCG6DOP7cZmP8fI0ib9uw9k8Av5/RxoVqHQto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FV8MpBsJ00o5wbZj294w2LBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z+
 PBMs7ybFggVO4aVgd0BTTZCFiJ+MvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALBc/nJo4A/FpnyinUF60OSpHfWaTao9Rf2V/cg+gQQ6mAP
 ZRHNFKDajyYUyFoMHoQCqh5hbn3wVLQfDAGqE+s8P9fD2/7k1UqjemF3MDuUt6XQcRYmG6Iq
 2SA+H72ajkBL8CWwzeB9nOqh8fMkDn9VYZUE6e3ntZ1hHWDy2pVDwcZPXOrrP/8hkOgVtZ3L
 00P5jFovaU07FasTNT2Q1u/unHslhwWVsdUEuY6wBqQ0aeS6AGcblXoVRYYNoZg7pVvA2V3i
 BnZxLsFGACDrpWlbHOb1pzLog+3EnEMFHMcSjUBTgsKtoyLTJ4IsjrDSdNqEaiQh9LzGC3tz
 z3ikBXSl4n/nuZQifzloAmvbyaE48GQE1Vrvlm/sneNs1shDLNJcbBE/rQyARxoCI+CBmeMs
 3Ef8yR1xLBfVMrd/MBhrQhkIV1I2xpnGGGN6bKMN8N4n9hIx5JFVdkBiN2ZDB00WvvogRezP
 CfuVfp5vfe/xkeCY65teJ6WAM8316XmHtmNfqmKMocXOMQpJVPZpXsGiausM4bFyRlEfUYXY
 8rzTCpRJSxCVfQPIMSeHI/xLoPHNghhnDiOFPgXPjys0KaEZW79dFv2GADmUwzN14vd+F+92
 48Gb6OikkwDOMWjMni/2dNCdjgicClkba0aXuQKL4Zv1CI9Qzp/YxIQqJt8E7FYc1N9zLmQp
 SjlAhcCoLc97FWeQTi3hrlYQOqHdb50rG4hPDxqOlCt2nM5Zp2o4rtZfJwyFYTLPsQ6pRKoZ
 5Hpo/m9P8k=
IronPort-HdrOrdr: A9a23:/NtpE6Bh/lAHhiPlHegIsceALOsnbusQ8zAXPh9KJiC9I/b1qy
 nxppkmPEfP+UsssHFJo6HkBEEZKUmsu6KdkrNhQYtKOzOW+VdATbsSorcKpgePJ8SQzJ8l6U
 4NSdkcNDS0NykBsS+Y2nj5Lz9D+qj+zEnAv463pB0NLT2CKZsQlDuRYjzrSHGeLzM2YabRYa
 DsgPav0ADQHkj/AP7LZEUtbqzmnZnmhZjmaRkJC1oM8w+Vlw6l77b8Dlyxwgoeeykn+8ZgzU
 H11yjCoomzufCyzRHRk0XJ6Y5NpdfnwtxfQOSRl8kuLCn2gArAXvUiZ1TChkFxnAic0idsrD
 D+mWZnAy210QKJQoiBm2qo5+An6kd315at8y7CvZKpm72HeNtzMbs+uWseSGqF16NohqAN7E
 oAtVjpxqZ/HFfOmj/w6MPPUAwvnk2ooWA6mepWlHBHV5ACAYUh57D30XklWKvoJhiKo7zP0d
 MeeP309bJTaxeXfnrZtm5gzJilWWkyBA6PRgwHttaO2zZbkXhlxw9ArfZv0kso5dY4Ud1J9u
 7EOqNnmPVHSdIXd7t0AKMETdGsAmLATBrQOCaZIEjhFqsAJ3XRwqSHrYkd9aWvYtgF3ZEykJ
 POXBdRsnMzYVvnDYmU0JhC4nn2MSyAtPTWu7djDrRCy8/BrYvQQFq+oQoV4ridSt0kc7jmZ8
 o=
X-IronPort-AV: E=Sophos;i="5.88,378,1635220800"; 
   d="scan'208";a="66762665"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=lBQK5MWhIDsyT+FdN8rdLYEIDPtUfiw8bdFu+MjclnDlDkeVIbcMn5auOeij7TnYSQPflNduJLEC3/GB39L7971ZEOFHZgnzlJMAEdVqZP4yXG/UyXoDALkOqVeGfcDNpvODZJLujC2F3PQWNgMAzrvlU7bEfszz+Jrgt9BB0/lk1ORxLGjn8mQWFQU0tledhlmZLoYnfDlxaUB4ZYJDCtqbvpqFZFhm4dwSu1goqafprnqY0pRaOQm/r93datFl/Kyclk5zi2QqvS5eP12miJ4SviviTrxEvC16oR7+NJFIYRAYC9P5H2zzCfykeTeU50DC6xiV7L4XpR3N9zCllQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Jwxj837jYM/s1nhFzcMdZIK5ZKiAfGjY1tKn+bil6io=;
 b=GKgplaZwGhBKwUA0LhWExnUGVIGpzwqT14AFhuaN1uDA6OU1Yp1FH33JcfqzCfHtFvcWUn1uj7QWbJm7imIqRbJdNoKWG8NTw9iiQJV/ULvEptUUSrX7tEf82r5vX84FU3iTmsf+Vpvvgl80sdzk5e3+rriNcapyc8Eby4z1WTB9henq6SaYxF8103t8ofagEEURmnLXXvIo/6mzi/y81+exyqAG0hL1DsniKow7KyLLAc1y2X2QsVrpemqV1W23gd98oFxveFqvGMoNXvqrWCUK751835JDI3xAlsuXgwbwstavwq3xU3217qeS4IPDNmQMCS8qA4Cx0KRXMxf4lQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Jwxj837jYM/s1nhFzcMdZIK5ZKiAfGjY1tKn+bil6io=;
 b=PDt6++6Q770OQBkwk6Fb+KzaYtvQCsF8VL+/tJi7KdamJ0iWXTNpHK4ZdGpsbZcGGvYrN0c7MJkVRGHtwxw4nxgoskzaEH0hsFaJtma7NGs0vId4yfPbJPLCqQZxmdb+oQzfAkCrTjmHq8kFiv/zLuCWgtnhoV6QoKfEm4qOKf0=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Jan Beulich <jbeulich@suse.com>, Wei Liu <wl@xen.org>, George Dunlap
	<George.Dunlap@citrix.com>, Julien Grall <julien@xen.org>, Stefano Stabellini
	<sstabellini@kernel.org>
Subject: Re: [PATCH v2 0/3] retpoline: add clang support + Kconfig selectable
Thread-Topic: [PATCH v2 0/3] retpoline: add clang support + Kconfig selectable
Thread-Index: AQHYI1FM/431BUtYuEy2GtPXIcEIC6yZWJaA
Date: Fri, 18 Feb 2022 13:58:31 +0000
Message-ID: <cfa55fd4-1990-b1ac-e6f3-94ef364793a3@citrix.com>
References: <20220216162142.15384-1-roger.pau@citrix.com>
In-Reply-To: <20220216162142.15384-1-roger.pau@citrix.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 50929868-ba86-490b-3fcf-08d9f2e6bf94
x-ms-traffictypediagnostic: MN2PR03MB4605:EE_
x-microsoft-antispam-prvs: <MN2PR03MB4605EE918ABCF552518510D1BA379@MN2PR03MB4605.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: nCklak1YgCI8jtp3PhAag7VneE/JbV9/eRbupKdsBfn7PF3y8an+PEgHQuaf5g+PNzjRlVnDSz/suz7uaGIbWU3hg1Ee5VLEkRby6PO6/DLNOCl7g08SkFhJsqmtJUtQs6t5gyX/ybH3zkc8dAi38R7hiFydXlTLdysl4G+3vYn8Bj2SW1uq0JAUlOHL7oWXvf5+Y0p/8GNIAzt+H3YVbaFxDNS/g87s/+YuVi0iWOkMlV2UERF1t6NT6rfH7Ojj7ZjA+kVQY9zy1ZEcCal2x0mLTR8fRTsJFX/hMf45++hgxkIF72iYk++66D2G+z0JeA2xeh44rhyAl71QsQ7xsDViRAE+jkfaJqovqBfm0gri1AbrUmODs+nz+75sAWMn5+IHq8U2krpHTEeAMLXCQXsqNV+YxUu5XM1FZ1E6cmyFJOu++nz0Fxa0PbZDe2+lA9p5zPND5lrE/WxamcqmsZXUX6Lo5Rt13pc3BxJQye8XEwqkXvvtBXlZchDSoHfm+vDoJASWltkmU10Pp1xb8fYCIn5Yp8c9Uv8yaZN/3kuPorvSF+fOR+Oxn9Sc+cBcPBiD+mmsF8oQkXCCWrYCpDVHF+OTDc9/sZPvSaXhImCddRIP/05Ay3nynAYs6pm14kGJZmmffnxanU2XdSzq72X0GGjhT3BLIJ0dbHJRx33ljQW1vJg5jlYqP37IFPGATvNBonnjBOFuRfk3/UR9pZ6Zu0OnXVycgqelsz3LMlRx7uv5n4QA133/uYELmjASoj75vxVWdPm6ZWMgB/bj4w==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(31696002)(6506007)(31686004)(6486002)(186003)(83380400001)(508600001)(2906002)(6512007)(82960400001)(53546011)(38070700005)(8936002)(316002)(2616005)(86362001)(110136005)(54906003)(26005)(71200400001)(5660300002)(38100700002)(122000001)(91956017)(66556008)(66476007)(66446008)(64756008)(66946007)(76116006)(36756003)(4326008)(8676002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?WEZROG4xZEcxTEdraFRYcWtzK3hjeFREcTFheWUrM1V5UmJUZTEvUG1KQ2p6?=
 =?utf-8?B?VjdodjJoY0dtMXRLVkU0cTN4a2c5UGkvSkVndGtmTkZXanVDSnlHT3hmc3RT?=
 =?utf-8?B?NTF3NzlyemczdmFVSkhZVW05NmdUQVZBQkQ3WmZTaWFZcHdKV0JPcWdXb01q?=
 =?utf-8?B?OTg1UXArbzNlNHRRc0hFRGlsYkZMcmc1T253eUNSSk1VYVk2NzVpSW5kUGJ2?=
 =?utf-8?B?QVZjbnZ4MjZsNXZtVWVLSVRmY3UzQVRDbVREclpmakFOMlNVWWdoT011OUlk?=
 =?utf-8?B?ZHVCZVkzWDF5Szcvbk1TR0NPRzJwN2ZOR0RrZm1RL2RVTS9qZzZ1amtyUlRJ?=
 =?utf-8?B?RkFoRTNaRG90NjlNcm9vTnZKcEUvMWxla1ROWWtzVVNXQVdaNW9oY3k3VDB6?=
 =?utf-8?B?T0RKZ3JOVURCLzErVFFsWnRqYnAwODV5K1RGTDFrVlQrYzFkeXJnYmRSWC90?=
 =?utf-8?B?TEM2Z2ZiVFo1WnpmazZXM096N1JhMVVjWlpjOEhGVU4weTYwRDFjdVF2dVox?=
 =?utf-8?B?OFhVMXBscFBjQk1oTUhCZEZXRkRiTHhqYmVwaXpLNTN5aVBuU3VEZjNwK3Vv?=
 =?utf-8?B?TVoraW5qbkNTdEtuSmZFU2FlUkFURzBQV2hMS0twajdpeWRvMGgyMWdHemJZ?=
 =?utf-8?B?MU8wZklZOGVIampMb1czZUlrRHkzb1A2REFobk5iTUtnbWNCc2pTMlpyQ0pi?=
 =?utf-8?B?Wlh4ZGg4RUJqUjNodzI0YjB2ZXZCN3V0UTZlaWJHSEhQQUNjYzgxZUpLVlRU?=
 =?utf-8?B?WlI0bzJjazRpSldwYVZBckJSOFBFNVJ6bXY2N2tMaUlzRTk0aHd0YjM0R3p2?=
 =?utf-8?B?M2pLbUFINTIwV3V3U1dHcGZSTVZ1QUNsSnI1N3NOVyt3Q3RvNVZlWVZUNzR3?=
 =?utf-8?B?MTZsMVJRWSs1MWF2bHZCZkN3LzVUenlveW9rS05nV0VvR2FBQ21xYzhLQk9i?=
 =?utf-8?B?YUYvZVUxdzZhRWZLUmZTN1lSR01tM2ROZnZCRG9odmVzbFVZZFdkT2hFK3pZ?=
 =?utf-8?B?cGJFZWtlNEs2bEhGbEpkMWFhTkpzNmdkZFJVZG5ncFI2eFdSSHhNVWpEbDFW?=
 =?utf-8?B?ZENscW5wNXBSL0swdWhRTSs1S2RUWE9XM2J0OURQaHhSUUZONFlQakwyYVdo?=
 =?utf-8?B?ZlJoc2w0OENzZ084M2MrOTB3cjM3dGFya0p4M1FNYmxqbVJmZGYrbHZrN0N4?=
 =?utf-8?B?eENUaEF1UDhEYldOU3lzdVNhL0RRUDhyekZUblVTbGJISno0V0h5T2NNYWdw?=
 =?utf-8?B?VmdaS1VRMFdEY3YvYzRkdWxRdm9iQXVkMGlxWm5NZlUwNmhiMFRaa1kySksr?=
 =?utf-8?B?a3hKUWFlR1MyenRwb1dVcDExcDhMWk9rV2RxZ0Mra2d3ODMzckVyS3l1bHdM?=
 =?utf-8?B?ek52SWxWMloxWGUvcmJRYjVkTEcrL0l5UHQvQVhDVVJNcFZOM0o5R3hvRGN3?=
 =?utf-8?B?NEpZcjRXWXBua2cyNy9Kd3hhZ3htWC9jcHpraGJQQnlHM0R1eDhEcjlHRTJ2?=
 =?utf-8?B?cGw5WWVyeWJBRVJEQTV6N3g4VFpQcFFuSWFOWVlYUFMxb2sxRlVwVVpaSTdB?=
 =?utf-8?B?czhmeVNDSVhIbnRkckdLYmhxTWxoYThDR3E4cVpDTzdpS29ONjhaa2JYak5U?=
 =?utf-8?B?dFlqZEY4dUJpRzZ0b01VRVBpeElYRHZueE9Tc0xHbmlxKzd1VzJ2VjExaGJK?=
 =?utf-8?B?Mkd5SytGV2VVb1VtanBvc3hzdjJZSDNnMlBnS1hXckh2eEk5SHlQd1R4WFhZ?=
 =?utf-8?B?RzlCVmxkOXVjaWFOWVNETmhoVDZFbE9VcXRKbURBdGVBUlUyTGxwZ2k5TUNV?=
 =?utf-8?B?d0dkT1V5aTZRSXUrYThqOXJzVDBGNW8wbkh3Nm40MWwvaTBqN2lKd1c3bmoz?=
 =?utf-8?B?LzJmSURTZ1NNL2k2dEVZQysxNk4wb2wxTzROQkVhWG9IMUsyZCtINnV6OUIv?=
 =?utf-8?B?NTg0MDNFems2Z1JyRCtGQW9zN25GMWZzNkJPY1hjTEJVVW5mdHA0RE9XdWhV?=
 =?utf-8?B?OE11QkF3UFBXbVVxYXVtcFE4WmU0RXFoMHpaL0I0TFg0bDc3eXcxUncybXYx?=
 =?utf-8?B?anJJNHBxWE0wcjBJa0l3ZlhwbVNQeGhEV1BuVXdMR3NiZ2VNZi8wT1hrclor?=
 =?utf-8?B?RGZ4UndhV0ZwbTdyMjVLMGdJNVVLMCt3Y0xyUWZ6ZFpIUXVPN3c5cjEwSXU4?=
 =?utf-8?B?OVViWUFoWWJwRWZDdldIQUZIZXRVWURxOXFJbUNZUEZORXg3M0xDNW9qL0h1?=
 =?utf-8?B?Q0JkY0tkS0lwdnN5RG1XUXVCdFB3PT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <5AC3F68AC68F674C9DFFE7FD70AB7118@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 50929868-ba86-490b-3fcf-08d9f2e6bf94
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Feb 2022 13:58:31.8637
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: vv6y/VoPoQyYBe4/Jw1XM8/+vK7HjN6jQm2UBO/VUVrTEtwAetUwBNAHaX0KRjyuWT55QGZmrutbWjSZAc2Yk2AeoXbZb6kaDRjF+ROu+TE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB4605
X-OriginatorOrg: citrix.com

T24gMTYvMDIvMjAyMiAxNjoyMSwgUm9nZXIgUGF1IE1vbm5lIHdyb3RlOg0KPiBIZWxsbywNCj4N
Cj4gVGhlIGZvbGxvd2luZyBzZXJpZXMgYWRkcyByZXRwb2xpbmUgc3VwcG9ydCBmb3IgY2xhbmcg
YnVpbGRzLCBhbmQgYWxzbw0KPiBhbGxvd3MgdGhlIHVzZXIgdG8gc2VsZWN0IHdoZXRoZXIgdG8g
ZW5hYmxlIHJldHBvbGluZSBzdXBwb3J0IGF0IGJ1aWxkDQo+IHRpbWUgdmlhIGEgbmV3IEtjb25m
aWcgb3B0aW9uLg0KPg0KPiBJJ3ZlIHRyaWVkIGFkZGluZyBhIHN1aXRhYmxlIGRlc2NyaXB0aW9u
IHRvIHRoZSBLY29uZmlnIG9wdGlvbiwgYnV0IEknbQ0KPiBzdXJlIHRoZXJlJ3Mgcm9vbSBmb3Ig
aW1wcm92ZW1lbnQuDQo+DQo+IFRoYW5rcywgUm9nZXIuDQo+DQo+IFJvZ2VyIFBhdSBNb25uZSAo
Myk6DQo+ICAgeDg2L3JldHBvbGluZTogcmVuYW1lIHJldHBvbGluZSBLY29uZmlnIGNoZWNrIHRv
IGluY2x1ZGUgR0NDIHByZWZpeA0KPiAgIHg4Ni9jbGFuZzogYWRkIHJldHBvbGluZSBzdXBwb3J0
DQo+ICAgeDg2L0tjb25maWc6IGludHJvZHVjZSBvcHRpb24gdG8gc2VsZWN0IHJldHBvbGluZSB1
c2FnZQ0KDQpJIGRvbid0IHBhcnRpY3VsYXJseSB3YW50IHRvIG5pdHBpY2ssIGJ1dCBJTU8gdGhp
cyB3b3VsZCBiZSBhIGxvdCBlYXNpZXINCnRvIGZvbGxvdyBpZiB3ZSBlbmRlZCB1cCB3aXRoDQoN
CmNvbmZpZyBDQ19IQVNfUkVUUE9MSU5FDQrCoMKgwqAgZGVmX2Jvb2wgJChjYy1vcHRpb24sLW1p
bmRpcmVjdC1icmFuY2gtcmVnaXN0ZXIpIHx8DQokKGNjLW9wdGlvbiwtbXJldHBvbGluZS1leHRl
cm5hbC10aHVuaykNCg0KY29uZmlnIElORElSRUNUX1RIVU5LDQrCoMKgwqAgZGVwZW5kcyBvbiBD
Q19IQVNfUkVUUE9MSU5FDQoNCmFuZA0KDQppZmVxICgkKENPTkZJR19JTkRJUkVDVF9USFVOSyks
eSkNCkNGTEFHUy0kKENPTkZJR19DQ19JU19HQ0MpICs9IC4uLg0KQ0ZMQUdTLSQoQ09ORklHX0ND
X0lTX0NMQU5HKSArPSAuLi4NCmVuZGlmDQoNCmJlY2F1c2UgdGhpcyByZWR1Y2VzIHRoZSBudW1i
ZXIgb2YgQ09ORklHXyogb3B0aW9ucyBpbnZvbHZlZC4NCg0KVGhvdWdodHM/DQoNCk9uIHN1YnN0
YW50aWFsbHkgbW9yZSBtaW5vciBwb2ludHMsIElORElSRUNUX1RIVU5LIHdhbnRzIHRvIGJlIGZp
cnN0IGluDQp0aGUgc3BlY3VsYXRpdmUgaGFyZGVuaW5nIGxpc3QsIHNlZWluZyBhcyBpdCBpcyBi
eSBmYXIgYW5kIGF3YXkgdGhlIG1vc3QNCmltcG9ydGFudCBvbmUsIGFuZCBJIHRoaW5rIHdlIHNo
b3VsZCBzdG9wIHdyaXRpbmcgdGhpbmdzIGxpa2UgIklmDQp1bnN1cmUsIC4uLiIgaW4gdGhlIGhl
bHAgYmVjYXVzZSBpdCdzIGp1c3QgcGFycm90aW5nIHRoZSBkZWZhdWx0IHdoaWNoDQppcyBhbHNv
IHJlbmRlcmVkIHRvIHBlb3BsZSByZWFkaW5nIHRoaXMgbWVzc2FnZS7CoCBPdXIgYXVkaWVuY2Ug
aGVyZSBhcmUNCmRldmVsb3BlcnMsIGFuZCBJIHRoaW5rIHdlIGNhbiBkZXBlbmQgb24gdGhlbSB0
byBpbnR1aXQgdGhlIHN0YXRlZCBkZWZhdWx0Lg0KDQp+QW5kcmV3DQo=


From xen-devel-bounces@lists.xenproject.org Fri Feb 18 14:04:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 18 Feb 2022 14:04:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275486.471381 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL3sC-0003uk-Hh; Fri, 18 Feb 2022 14:04:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275486.471381; Fri, 18 Feb 2022 14:04:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL3sC-0003ud-Dd; Fri, 18 Feb 2022 14:04:36 +0000
Received: by outflank-mailman (input) for mailman id 275486;
 Fri, 18 Feb 2022 14:04:35 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=6Z2s=TB=citrix.com=prvs=041b9fbab=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nL3sB-0003uX-6x
 for xen-devel@lists.xenproject.org; Fri, 18 Feb 2022 14:04:35 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b1e12dd7-90c3-11ec-8723-dd0c611c5f35;
 Fri, 18 Feb 2022 15:04:33 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b1e12dd7-90c3-11ec-8723-dd0c611c5f35
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645193073;
  h=from:to:subject:date:message-id:references:in-reply-to:
   content-id:content-transfer-encoding:mime-version;
  bh=uO04jYTwFolGGSq5mq8Wfiylf/SJH6GDhgE4weFwY9Q=;
  b=eNTuSJ12kbTAU/yvjDTzNlP5nFLwDwUi49FQxRyYJYiHuP6uoTcxIVIr
   V3/6RgQGYHtzOQOwqmcwuwr026aquEGqaCLKhzhk+Be8BxAoVjIH5qzUG
   s6qDkFkbhBTRzCNk/a6l2gdhCViy3pxgl64m6oVj9WdWjOHNry5ZCeW27
   4=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 63957588
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:tgbvSKkhDWX62wYNj8TMz8/o5gyLJkRdPkR7XQ2eYbSJt1+Wr1Gzt
 xJKXWuHPP7bZzSnfNhwYI3gpBwAvJ+Hx9EwGwdlrXtmESMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2UILd9IR2NYy24DjWlPV4
 LsenuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR
 v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ
 NtxWZOYEFsOHf2ViLsmED4DL3pbLPFK5pzCPi3q2SCT5xWun3rExvxvCAc9PJEC+/YxCmZLn
 RAaAGlTNFbZ3bvwme/lDLk37iggBJCD0Ic3k3ds1zzGS90hRojOWf7i7t5ExjYgwMtJGJ4yY
 uJHMmsyM0mQM3WjPH87I4wHof+Pr0XybjNz706ZgYYNukHMmVkZPL/Fb4OOJ43iqd9utlaVo
 CfK8nr0BjkeNceD0nyV/3S0nOjNkCjnHoUIG9WQ/PxthEaUwDVJV00+Wl6yoP3/gUm7M++zM
 GRNpHBo9/JrshX2EJ+tBHVUvUJooDZFB/1zQ7QqtzrO7fHouCOIWmQabTtePYlOWNANeRQm0
 VqAntXMDDNpsaGIRX/1yop4vQ9eKgBOczZcOHZsoR8tpoC6/dpt1k6nosNLTfbt5uAZDw0c1
 NxjQMIWo7wIxfAG2Kyglbwsq2L9/8OZJuLZC+i+Y45E0u+bTNL0D2BLwQKChRqlEGp/ZgDQ1
 JTjs5LDhN3i9bnXyESwrBwlRdlFHcqtPjzGmkJIFJI87Tmr8HPLVdkOvGwnfhsxY5paIGWBj
 KrvVeV5vc470JyCN/IfXm5MI55ykfiI+SrNDZg4keaikrAuLVTarUmClGab3nz3kVhErE3ME
 czzTCpYNl5DUf4P5GPvH481iOZ3rghjlTK7bc2qlHyPjOvBDEN5vJ9YaTNimMhit/jayOgUm
 v4CX/a3J+J3CrOmOXCPqdZJRb3IRFBiba3LRwVsXrfrCiJtGX07Cu+XxrUkeod/mL9SmPuO9
 Xa4MnK0AnKl7ZEbAW1mskxeVY4=
IronPort-HdrOrdr: A9a23:YcXoGK93FUuwJdXr1Y5uk+F1db1zdoMgy1knxilNoENuHfBwxv
 rDoB1E73LJYW4qKQsdcUjpAtjOfZquz+8J3WB3B8btYOCGghrlEGgG1+XfKlLbakvDH4JmpM
 Rdmu1FeabN5DtB/IfHCWuDYq8dKbC8mcjC74a/854ud3ATV0gJ1XYjNu/xKDwSeOAyP+tfKH
 Pq3Lsim9PPQwV0Uu2LQl0+G8TTrdzCk5zrJTQcAQQ81QWIhTS0rJbnDhmxxH4lInNy6IZn1V
 KAvx3y562lvf3+4ATbzXXv45Nfn8ak4sdfBfaLltMeJlzX+0WVjcVaKv+/VQIO0aWSAWUR4Z
 7xStAbToJOAkbqDySISN3WqlDdOXgVmiffIBSj8AfeSITCNU0H4ox69Nhkm1LimjsdVJsX6t
 M040uJ85VQFh/OhyL7+pzBUAxrjFO9pT44nfcUlGE3a/pUVFZ9l/1XwKpuKuZJIMs60vFTLM
 B+SMXHoPpGe1KTaH7U+mFp3dy3R3w2WhOLWFILtMCZ2yVf2CkR9TpU+OUP2nMbsJ4tQZhN4O
 rJdqxuibFVV8cTKaZwHv0IT8e7AnHEBRjMLGWRK1L6E7xvAQOGl7fnpLEuoO26cp0By5U/3J
 zHTVNDrGY3P1njDMWftac7hCwlgF/NKggF5vsulKSRi4eMMIYDaxfzOGzGu/HQ0ckiPg==
X-IronPort-AV: E=Sophos;i="5.88,378,1635220800"; 
   d="scan'208";a="63957588"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=DCJU55CEvRyrLtgg/FTLdp74h9x4WDCItbUw8/NeCPodUKiPFDiRciZfnrhQp2Uj3t43dAUAhjDhKI/zzdnFgFjQEvev3Am/aNTSt51lQKnBehU6ZE70msjRxrRn7NGn7p+ReYO24d3TrgWyydu4pJhR0ANaFmhwA01VDrUwI/dV//02nOK88gy+RAgsmU6kOmlO/gucESlUOn8b5KNOjzQp1Lg2LAIWsFMT/0C0Y3zZQKPwYPH8yXbPNnEvobpjNnBg1nfGtSxbU2Yn1fQRI8HZNCI4Mm0ssmb+/Bh8VNxMgHMl9YE38yfkuPCf1cr3xBnOt8Txih4LuT/e3KkyDQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=uO04jYTwFolGGSq5mq8Wfiylf/SJH6GDhgE4weFwY9Q=;
 b=NvhZvBEaXyMgccEDqpT8arrd8ul7SIGiFByyDTuXaFOk9IJ2YE3JgYMnJWB6mKKFAiAKit9KffKdniMPlMXWY34ZDlRMd+1YAN17zXW3J7lcY6F4nJYwywgVtuV7HKX05mNQl9DX4XDBYg1d/ay+vYyL7pyf8iaUBfNwSWi1ZSB7hIZ8Lc3ZS3jnDVatGHrGxXeMZedxzToOpBmvkyMsrK4VA8FIX2ffycxmU1yMWW2hC6KCvGWi4baIfKIlkVsrH7C/CLck1lt4kho+0FmT6/QS8JhZT5cw3mnn0O2iBR5pzpQBmiGOGApER22sa6LQ688MFUczem6kMOp3h69drg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=uO04jYTwFolGGSq5mq8Wfiylf/SJH6GDhgE4weFwY9Q=;
 b=Wr1C0PKQsesyhuiouO+DR1er10j4e3Em+aOLbjxVILNaAsaqa63TF9IkLt5eNrG8mbiofIX99TkGyDB7RSbcRIdJY84xAJeRkAO32/tVm6xnDftpEA0SmaPgYrq7K/s5zIyXD3CVwwS/NJYcF/Zn3jtkl/0fMjg+LfB1jOqnCeQ=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Brian Olson <bjolson1278@gmail.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: [unsubscribe from xen-devel] Re: [PATCH 1/2] github: add workflow to
 run Coverity scans
Thread-Topic: [unsubscribe from xen-devel] Re: [PATCH 1/2] github: add
 workflow to run Coverity scans
Thread-Index: AQHYJL8wuvXnHhxuC0qfnAoHQI92b6yZOqQAgAAAnoCAABQvgIAAANKAgAAHIQA=
Date: Fri, 18 Feb 2022 14:04:28 +0000
Message-ID: <43c3d27d-e68b-60f6-b0d1-13435276ac5a@citrix.com>
References: <20220218120042.32102-1-roger.pau@citrix.com>
 <20220218120042.32102-2-roger.pau@citrix.com>
 <0eeb8f5f-d049-8a8e-9e65-d1966c21a781@srcf.net>
 <34ebc66c-e55f-3f98-b769-0e73bdf3c2fe@srcf.net>
 <Yg+gwfRqetYoT4Th@Air-de-Roger>
 <a44ed8cb-0bdc-0f6f-fc6e-7f831605a71c@gmail.com>
In-Reply-To: <a44ed8cb-0bdc-0f6f-fc6e-7f831605a71c@gmail.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 224fb4c2-983b-4b1f-7e5c-08d9f2e7940b
x-ms-traffictypediagnostic: MN2PR03MB4605:EE_
x-microsoft-antispam-prvs: <MN2PR03MB4605B51E8C5C231B55CB43D6BA379@MN2PR03MB4605.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:5236;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: ddzMqZNqdCfOSB4ab33TV0JGWU3KVHSaMz+3mwsY10llF+DYzbKKJhBtx0lvA0dZ/Fg4rcsNb+PAkbQoHuCrHr1I64WpI6/kYTXBX5tpIWUiWd4Sc6Rg30sghgllv1pk7be578DDx7FvB/Csj4N9XoT338BQftA7VkKULcZAsyXANNWlInhvN9fY82bmWqe1z/HKj2MAQgtT6/7lIoGE7NHgXcRnr4t5j7YX7Z8y6hO+PseAXvnKww8N1kp29CbKycLXYwtHZzNf2i2UQLW2XXnakR4H16ZyZEADhYrWYcbDFv6mR5rzqWEBTvsW27b1ibz9aeX5xkyQT/2Ap1NoR+ftkzHpG2hPLc5Y6fskE7YeY52UmoQwxMM5dEx/YSPVsvdj3i9GJOpor4cjOIUS2y6RvN9yR/m7tRwptY0it7O7ewK1EMwySgMcY5BNWqywzsXS8gO47DlbOGIkhQq/fON2RGqTBPjisYtgA+0Yg0MQZDs5v4t91WdxXVVw1R78eILuk0EytYV8L7xWgCYrr+2LWXN3mCgpqJz7sfVuepWHkVQIz2QdcENOQI6mUqntRCD6ljW1d/jtmkj3/8/R113zngzjBXg5hu6fiUcoqJRpMIV4HkP39Gc8irZmmf69gE7EltwDHFc1QB/mQ9rxCCcC1h/8Sb+YJPVE/24HS48gsKSI7By68Yn7AzRpC0Haw3mUXOYW8pj1NBN/jGMGLY/0/rJd9dndqZ1BHCXRjeItU8tUdxg1tpcewgdU5kWKFKo2VVSpVz2NMDiM3NZsn/Mtwtm20o/LgkOSNSUdISgM2UYqRBEsLZwsHMkY9Ur8Ma6eDsj30h9/XshFfLhDAl5vXGkhdEyOenaSQK+SBLI=
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(31696002)(966005)(6506007)(31686004)(6486002)(186003)(83380400001)(508600001)(2906002)(6512007)(82960400001)(53546011)(38070700005)(8936002)(316002)(2616005)(86362001)(110136005)(558084003)(26005)(71200400001)(5660300002)(38100700002)(122000001)(91956017)(66556008)(66476007)(66446008)(64756008)(66946007)(76116006)(36756003)(8676002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?ZmxJSmxUZFVuZG0zZGFWVm1NWmMyOG1DYk44MWUzeXlKQnIyOTZ3dlBQWUlx?=
 =?utf-8?B?bjJ1d1dTR29QVGVFUEdYOHk5cTBvYzladTFLTmZOOGlldFRSVG1mYUJZRStx?=
 =?utf-8?B?WkxFU3dSdzh3eDRGbHJlV04yVEFydzZkMFltSTF5bDlOa0haMEw0Q1dmMWJV?=
 =?utf-8?B?TlBOZDZNUTFObnM4Tzc2bUFtVGlRU2ZabFRZei9raFhTSFUwWXpCWEcvQzJQ?=
 =?utf-8?B?ajZSc0lpRlRiQ2E4aFVLL3JvNkQ5aXVIZFY0WXRabThhV1h4OWdtcFJ6eWxM?=
 =?utf-8?B?Nis2YUFReFJCNDlpRjE1Q3VaR2V1VlRrSXM3SUJPZEYwdzhDYlZFYnFWU2Rm?=
 =?utf-8?B?SCt1NitmZ2hsMm1VNUVlVWVWaFpqUHgvYW9SekVOQzVkSGI1MHRFNHRCVXBO?=
 =?utf-8?B?bmVRa0M3M2dzZTRTVWhpVTFwTUZZZUlZeEV0eTBrVmZkeUZzcFpGMXpWMnN5?=
 =?utf-8?B?VTVZTmltMEpCNTRYU0pCVGhIUjluRlE5enZvMTF6aXhhdXlKU0haenFuTmh4?=
 =?utf-8?B?MUU5U2I1RHhNSnFpaEJkcDVzVWFMak9PZkdmdUYvcGdpcGVTbnVNSzhwSG1p?=
 =?utf-8?B?Q1pFQXR4d0VJVzcvQkthZDBTc1VzRFd5YXA0dGFJcjZNQjVDWFduRkczU1pP?=
 =?utf-8?B?M210Qml0bkJ5amErS2JhZEl1YWt1Z2VuaXhRZGNxTWxnRE5KRkVLbFJRK2d5?=
 =?utf-8?B?TkE1ek1iMjlLS0pvZzdlUHU4RTVXS0VrRUtLWVE2dTVBQkFzekdwZGhSWFI1?=
 =?utf-8?B?dXVMTmpGNkRKZkdZVkRXdFBjSXlMeTJzdHY0STlYbGhDcURYZ3VPQXh3ODNp?=
 =?utf-8?B?VmtDZFdTdGVQY1ZjMzIwQUt2VVkwWGNmRjRWaURNL0FwTHZBLzhMSE4zeDRE?=
 =?utf-8?B?SUVPTzNwcTkrZ2ZNcnRxbGtoMTVKM2Z2K0lNNkYzbC9PdnBuRlBzeHJTaVBM?=
 =?utf-8?B?U09QMmYvSFVvZFd4TDJMR3ZRTXFLcmFPSTk2NTNWQm0xNnEzOUVMNjFmQldG?=
 =?utf-8?B?YTJnNThudll3OTBzMkx3YTNkRWVZWFkwSHZISzR1dGlMMis5UGcxQkZpdWZ1?=
 =?utf-8?B?T2ptaVV5dlk1d1QvblVDVTBSeGt6N0xXMkJpMEJTR0NDdk9HNk1ueXZQNkpa?=
 =?utf-8?B?amZ3L3RsMzJCc0pSNEYxa2o0MG9qeGFhN2tvaTdYcWJrdS9zRFZ1R2NOS2M1?=
 =?utf-8?B?aUJkUnplVGJhYkU0cU9NVzBsenZZbE1wb05mU3c0V2JtclRKelcyS2NwWHVC?=
 =?utf-8?B?S05JOUJqcXpkNzFWMFgxSXV5SDU0N2tGWkJlbnpqSmxHZWhCUkJOSW0zc1R0?=
 =?utf-8?B?MDhaM0RUVWNWdFNsNWdvakYycDM3MlAwajI2ZGFqMlhPSFpqa0JwZU9hRk5F?=
 =?utf-8?B?TjltU1Evczc2azBOWTFUbmYvaXg1M1NoYjBvTElyM1kwUDVtNVF4NzRnZ1Fa?=
 =?utf-8?B?WHRqL05FaHhtczI5SENiRmRLVWFiNmJSRU9sZ2JGV1FhVmFERlhqTXJQbzhK?=
 =?utf-8?B?YlhJd1BYbk1JNEhZQTZOZVF4RSsrdTlEMEpaRytBYldnT3gvbjRhVjhKWWp6?=
 =?utf-8?B?bkRuVUZpaUpPei8wR1pUUFZqcm5aL0JtaTBqMDJHUXljLytjcXlkUFJFY2wy?=
 =?utf-8?B?dVowSnJUWWZ0bGNxcEMwa1M5VlpxYUpaV3Btd01pUks1b2JVUldzNnZ1MzFp?=
 =?utf-8?B?eTVWeGhOK2pzK3JIVTdoNERZbDZBblRqeitmSW90NFFlYmNCYXlYNVYvTkdk?=
 =?utf-8?B?dEtBR3pMVS93UFNuSjZGM3dpQTBYS3Z0dUNDRDNXRVBsOTdDaDI2NGhHTHF5?=
 =?utf-8?B?UWV0TTM2YmdiQk9lanN6YTZ2SFg5VElPQldWSnlJUVN0NFdBWXhQWW9Ubi8x?=
 =?utf-8?B?RnYwd2RTcmJyemRRaGxRY2R1NWNwb3hnYWVRdXVJOW1VK1JLcEEwT0lPb2dv?=
 =?utf-8?B?RDl4Njk1SlZ3SjZpZk0rUVpLQnEwa2lIenFsRDBucEx3cW1FTENzeEtGNkUx?=
 =?utf-8?B?cnZ1UUFuVzdzOHlqalB4a3NNa3YxRWp4UFMyRjBBQWo2TlBpU2puS25wMGRx?=
 =?utf-8?B?Y2oxVDZseEdQa0xHWjNCRDB0UzJLSEs5ckZLSTdyVlNLaDUyM0lHMlU0T3lo?=
 =?utf-8?B?ajc3YmVTMVVmMGxNaDJ1V0JsckRRelFGUTVqLzQwNlZFVlZXU213VHNQVlE1?=
 =?utf-8?B?OU82UnRaNEM5MFA5d1E5NVJGZWQ2WXpnRTE1V3BVZDhNaTROeTUvV1M0cW1s?=
 =?utf-8?B?QlZySG1DUk45ZXVMRlB2U0ZCMEdRPT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <DC778E3BB4B50D43883BB638FAA7C413@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 224fb4c2-983b-4b1f-7e5c-08d9f2e7940b
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Feb 2022 14:04:28.3690
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 00cE9j/E8gshUKvHDy02b0B++/rhXq5qacznEPbHLLyNld8UBkNbqqm5qaxONcqEehZaYuk+g0DaFB98ji35GQyCuLHOFlRPy7KHCOx7v4U=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB4605
X-OriginatorOrg: citrix.com

T24gMTgvMDIvMjAyMiAxMzozOCwgQnJpYW4gT2xzb24gd3JvdGU6DQo+IENhbiBzb21lb25lIHBs
ZWFzZSB0ZWxsIG1lIGhvdyB0byByZW1vdmUgbXkgZW1haWwgYWNjb3VudCBmcm9tIHRoaXMNCj4g
bGlzdD8gVGhhbmsgeW91Lg0KDQpVc2UgaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWls
bWFuL2xpc3RpbmZvL3hlbi1kZXZlbCB0byB1bnN1YnNjcmliZS4NCg0KfkFuZHJldw0K


From xen-devel-bounces@lists.xenproject.org Fri Feb 18 14:05:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 18 Feb 2022 14:05:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275489.471392 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL3sZ-0004L5-Pc; Fri, 18 Feb 2022 14:04:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275489.471392; Fri, 18 Feb 2022 14:04:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL3sZ-0004Ky-Mf; Fri, 18 Feb 2022 14:04:59 +0000
Received: by outflank-mailman (input) for mailman id 275489;
 Fri, 18 Feb 2022 14:04:58 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=6Z2s=TB=citrix.com=prvs=041b9fbab=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nL3sY-0003uX-Dv
 for xen-devel@lists.xenproject.org; Fri, 18 Feb 2022 14:04:58 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c030cbcf-90c3-11ec-8723-dd0c611c5f35;
 Fri, 18 Feb 2022 15:04:57 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c030cbcf-90c3-11ec-8723-dd0c611c5f35
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645193097;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=ZCFBdfGBUOcjU4e5ZvTfJo9189M+jKbK7n+APEHcAlc=;
  b=gDfnswhTLHVqCQye8NN0Nz50EjdDLu0YEZaW8Q+XFTyN2anE2dcyJc29
   2zBNmy7s6vieQAPs3q91Yc9fGJhlkrhKuBIfjPL7anDxla8uqu7UzOpps
   wnLzIR5CK7N1bpZKDZuNx25tpGQVA3jmofEa9D6KUpMBOE+XduwlpiXnc
   0=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 63957636
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:K97Rf6Mg8nD4xOHvrR1vl8FynXyQoLVcMsEvi/4bfWQNrUoq0D0Ex
 2NNWmyOPKneNjDxL49wYIW+/EhXv5PQyIc1TQto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FV8MpBsJ00o5wbZj294w2LBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zx
 99LmqaVV1oQNe7mkbwxDDdfKiVSIvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALBc/nJo4A/FpnyinUF60OSpHfWaTao9Rf2V/cg+gQRqeDO
 JRCN1KDajzKfDlxFnI4Iqs7xsWHgELtQQRRhH+K8P9fD2/7k1UqjemF3MDuUt6XQcRYmG6Iq
 2SA+H72ajkBL8CWwzeB9nOqh8fMkDn9VYZUE6e3ntZ1hHWDy2pVDwcZPXOypPLo1GalQdlRb
 UoZ5kIGvaU0sUCmUNT5dxm5u2Kf+A4RXcJKFO834x3LzbDbiy6bDGUZSj9KaPQ9qdQ7Azct0
 ze0c8jBXGI19ufPEDTEq+nS/Wja1TUpwXEqaiUCYjEg/YTaq8IZh0rjEfhkKaqZkYigcd3v+
 AyioC87jrQVqMcE0aSn4FzK6w6RSoj1oh0dvVuOAD/8hu9tTMv8PtHztwCHhRpVBNvBFjG8U
 G44d99yBQzkJbWEj2SzTeoEB9lFDN7VYWSH0TaD83TMnglBGkJPn6gMsVmSx28za67onAMFh
 meK6Gu9A7cJYROXgVdfOd7ZNijT5fGI+S7Zfv7VdMFSRZN6aRWK+ipjDWbJgTywyRJwyfBjZ
 87BGSpJMZr8If02pNZRb71AuYLHOwhknT+DLXwF50/PPUWiiI69Fu5ebQrmghER56KYugTFm
 +uzxOPRoyizpNbWO3GNmaZKdAhiBSFiWfje9pwGHsbec1EOMDxwVJfsLUYJJtUNc1J9zbyTo
 BlQmyZwlTLCuJEwAV/UMis6MOu3B/6SbxsTZEQRALph4FB6Ca6H56YDbZonO74h8e1o1/lvS
 PcZPc6HB5xypv7volzxsbGVQFReSSmW
IronPort-HdrOrdr: A9a23:n5lnNKlIQD2ctmDkZFBFB6e2AxbpDfOBimdD5ihNYBxZY6Wkfp
 +V88jzhCWZtN9OYhwdcIi7SdO9qeu1z+873WBjB8beYOCAghrnEGgC1/qv/9SEIUPDH4FmpM
 FdmsRFeb7N5B1B/L3HCWqDYpcdKbu8gdmVbI7lph8HJ2ALV0gj1XYANu/yKDwseOAsP+tdKH
 Po3Lshm9PWQwVyUi3UPAhmY8Hz4/nw0L72ax8PABAqrCOUiymz1bL8Gx+Emj8DTjJm294ZgC
 j4uj28wp/mn+Cwyxfa2WOWxY9RgsHdxtxKA9HJotQJKw/rlh2jaO1aKv6/VXEO0aOSAWQR4Z
 3xSiQbToNOArTqDyeISC7WqkzdOfAVmibfIBGj8CPeSIfCNU4H4oJ69P1km13imhAdVZhHod
 N2NyjyjesoMTrQ2Cv6/NTGTBdsiw69pmcji/caizhFXZIZc6I5l/1VwKp5KuZIIMvB0vFuLA
 CuNrCo2N9GNVeBK3zJtGhmx9KhGnw1AxedW0AH/siYySJfknx1x1YRgJV3pAZMyLstD51fo+
 jUOKVhk79DCscQcKJmHe8EBc+6EHbETx7AOH+bZV7nCKYEMXTQrIOf2sR+2Mi6PJgTiJcikp
 XIV11V8WY0ZkL1EMWLmIZG9xjcKV/NKwgFCvsukKSRloeMN4YDABfzPGzGyfHQ08n3KverKc
 qOBA==
X-IronPort-AV: E=Sophos;i="5.88,378,1635220800"; 
   d="scan'208";a="63957636"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=g8eMGGS+eSSFT2D2hygJHG7MNaHXiJ77i150YeXSct5XLQWNvGxlVTMqXqAAn86EUqYCwNpBOGY9bc+/q2eklDGYXdPAJLvLjmNB4nTZNvuF17kW+gJO5O7pdzR55n2CzVnN6K4OtVy6Hz8ri626OM0hZ7yLvBqTS7l8/ZD0ZZmsjQAvceWNR2CG9JKzm6xaLYNmiFMBpyTXM29w2VP94EBbW2defUADZWH/gFRuycpfSuG+AXIU7XyUioqKWLU3CBJYsKrxF5jT/+fkJkquXQ/2qkE9df5OpxDWOVXy0EfX/pa4iPj9lKiHN0FlOLqcu2VVuSs/JgGnJ4An2aYpsA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ZCFBdfGBUOcjU4e5ZvTfJo9189M+jKbK7n+APEHcAlc=;
 b=WthXSbDfjOZ6eX0d/ACY/bJLPXiJI1JbyH1a/xNgtsIyKGNj5CG7Ou8Ey8qXlBqWPmdFj6E4L19xuwJfQYh1u6dVxGjkRd169ZHiovLyuHHDtZRsQAP2ckI/7lsTlPs1eIjEGDMIvfcaPNqrlrjxWx+0VEivBf1PJPj494xUbKPcMunx/vTS7mLB/qLliWBwBUC1oZuXvu6fDR8NiMPuYUz6cGmgn0W+EWFbBOtnFj3HiUwOkEtUorLyQriDmefq9K2ojT3PRvJn6EcWpOju/DO0x4zNUYUPTqRcpkavOdvcBow0gUOSxFH0Jm+YW8FMNGFRqkx/K9yHdYpT57szPw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ZCFBdfGBUOcjU4e5ZvTfJo9189M+jKbK7n+APEHcAlc=;
 b=YdDt+3cRgjB9h8KzfwFi3akGXHiH2l25Fh05HHekFeR7zKsv1v7Usfe3xd/wIn2ylNygVWPXb20hSfk8OA0XJhM/POwc+RvoalIG5jZwverOmpjU2ERgfByVn4leiR2Q2PSzske2xSxsaYYJgUonLl2Bn7bSXhTI2smUyCwWDfE=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>, Andrew Cooper <amc96@srcf.net>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "George
 Dunlap" <George.Dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, "Julien
 Grall" <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Wei Liu
	<wl@xen.org>
Subject: Re: [PATCH 1/2] github: add workflow to run Coverity scans
Thread-Topic: [PATCH 1/2] github: add workflow to run Coverity scans
Thread-Index: AQHYJL8wuvXnHhxuC0qfnAoHQI92b6yZOqQAgAAAnoCAABQvgIAACA8A
Date: Fri, 18 Feb 2022 14:04:52 +0000
Message-ID: <26eb08ea-b803-a508-c8c9-cb57833ce4c5@citrix.com>
References: <20220218120042.32102-1-roger.pau@citrix.com>
 <20220218120042.32102-2-roger.pau@citrix.com>
 <0eeb8f5f-d049-8a8e-9e65-d1966c21a781@srcf.net>
 <34ebc66c-e55f-3f98-b769-0e73bdf3c2fe@srcf.net>
 <Yg+gwfRqetYoT4Th@Air-de-Roger>
In-Reply-To: <Yg+gwfRqetYoT4Th@Air-de-Roger>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 7bff13b8-6d3c-4885-f1db-08d9f2e7a275
x-ms-traffictypediagnostic: MN2PR03MB4605:EE_
x-microsoft-antispam-prvs: <MN2PR03MB460548706B0DB7F43A4FD221BA379@MN2PR03MB4605.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:2887;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: Z7IaoHwnBykGFj06+GoceiB0jBtD1wIqo7dJJtQ1Uvz2hE3/q9y/EnnQk5FfYvest1Api8Yq0khODpqT48bgolhi5ew6s0uefXSDVYQ+GUt7xqjJJ8+n6PH/iN5b2bnKgkcnbwSrdZYDTfbAlHmiWZDChKq8YMuQXNZVhI4yNgaX3zaHX/++BsU88qF/FXM4Z8qym8M+AYp6jCqkJtag/cd+119pZCVZ6F+xgcNrJ9WS7HI58P4+/qVEKi2qmR/KMutjarsF0kfsD1Dq2U6RhtJXuy2eVCfpow71CxeQNv+OMRtvoV2+lZVd7KzVoAdYfwisoK9IdITOqEyTTvwtSguXggrhREj/6yGhjlghzBRx9IpgjQZKfHJGmH8mtXTc9rsov5JzGZ/29zfp22Ba4BmegcGV6N/3iZeTHFxMYYoxJ/G17qCJz1GmlTZev+f39ntvSmt+Sw0zoSzAZqQFJUun7O7giwq9bK25F7w5wfMdzvrQtsOoz2hVkUshS+1rSiiHiFhzfpGH8W2HwjNc7NuaJtn1frI/GEzl+JAgus1qorLcYqt6YYuypRocHCxy35Q+nRQhlG41a3sODFhYQFxVDZ4qu494oa2ld4yiw7PhJWybOM8OjptG7mjzA8IkFtPoyukusD39aby3d8Ty6N0vgdfTtywL3gGsXlRcsMaT6zwtHE/dBkb3g+obDiNGtEbhaNtFkNB6kS3AoZ5xUL2PgTvVppOr3fzvwUES/uajpXWa3A2iq+AkHwNbh392UoOlGlX835OQVfw8DguqRw==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(31696002)(6506007)(31686004)(6486002)(186003)(83380400001)(508600001)(2906002)(6512007)(82960400001)(53546011)(38070700005)(8936002)(316002)(2616005)(86362001)(110136005)(54906003)(26005)(71200400001)(5660300002)(38100700002)(122000001)(91956017)(66556008)(66476007)(66446008)(64756008)(66946007)(76116006)(36756003)(4326008)(8676002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?b29qM3BKcGxUUWx6RlZ6allHM1ZlamNDSkE5Z1hSVUVvTWZ2bUFITlpqcWpG?=
 =?utf-8?B?ZitQajBaR2FDdi9NaE5MSjBxdEQydlpzME1ybzZEU1BTMGxIR0NzQjVyRFY0?=
 =?utf-8?B?U2x2TE5La2FLTkl1Q2p1OFh3SEZYRGNzNU9rMk8vcWNWNDU5WjZzcGRMR05X?=
 =?utf-8?B?bVNOOWlwZUdqMURyZXFxNWJzdUxkaGdHdm9vV3diUUY2SmFpUFlud1lNR2ln?=
 =?utf-8?B?SWNsYXNNaytiUlB0YlRkUXp1dzdZYkdCZnNFNGd0Rk9jeW5ZSnpNci9SNlJw?=
 =?utf-8?B?SUVrTlBjWG5hblFuaUhWRm9kaVRjMVRLTUR6SkV0OEU0KzlMN0krM1NVaDVH?=
 =?utf-8?B?a014V1NsRVZsQVI5RTkvbVVOcDBEY1o4b21KclRjYzZ2MHFNNTlQWXdXU3hN?=
 =?utf-8?B?MWoxV0dUMXJ2cU5naVpsN3VpeEVSMWhPTDBYcVVJMkk0VFR6bEJhTC9uRmUz?=
 =?utf-8?B?WUpJdHRIQU9tT3hPYm12M1dZV1JKVU1aZXZMdXoyYzhxNWVuZ2xpQjlHTWtl?=
 =?utf-8?B?djBnS3hTQXR1SFFmNUplalZHNXh4VUg1bGpkbkxhandvelpPY05nYld4ZTNw?=
 =?utf-8?B?elNCVmJSNjc4cmRYTi9QSzN0bjB5Zmg3bmlLSmVJNm96L1ZoQjNDUzlVZFhk?=
 =?utf-8?B?TGhNMldLUGJoSUZpT2dtbjZoaTE0bXhaQ1BrWlFFeVE3WGVBcWh5aDNZS2xy?=
 =?utf-8?B?VEpvSkUzL29xdXlUZFI2QkI4RmVsZDZOYlhmZlBIeTA4TERHMVNoaXRIQUxC?=
 =?utf-8?B?WThmQjJ0MnorV0pDK29uTUtpRkttM3FFODhHTVN3SWRxdHJWV05UK1lrK3lJ?=
 =?utf-8?B?TFBtR0dCellKT2ZuSTlabXhmeUtrYUdhVUs3NDBxeVlwUWtzbDJYbzBSNytq?=
 =?utf-8?B?S29ONmQ2QWhyS1ZDRTZaY1RJMWR1TCtZMUltRmJldWxELzV4NDIyVkdvMitm?=
 =?utf-8?B?NHY2M213bWdJK0VyRllKb1BFOE84SGZQRTZINDB1VXhUY1picjU4ZWtHOEFL?=
 =?utf-8?B?Z1puM2kyUG5KVG82RWRKVVZPVGE1MVNiSXJ0QXJKZU95WnFtRk1SNE5aSEEy?=
 =?utf-8?B?djZtb3ZDQ09LemFyZW9qcm8zWURncHFXK2tpVUJxNzJSSGVtU0diSDNSeVY5?=
 =?utf-8?B?OGFyUlNhTmIwMEthckR3eVd0RUxsWUhkTDJwMHErcU5ZQ1g1T1JqS2VvR05w?=
 =?utf-8?B?c2FNZnZCK0FaRndMYWdhU3B1bXowNHNRbW8zZWpnZWhTazZYZURPOThoVG9V?=
 =?utf-8?B?MFpQeW50NVhiTXpRRll4QkdEeFBjWVE3RGxpUjBuYVJNeWhxc0wvdlhSZ3NU?=
 =?utf-8?B?RW5GTjh6Q3dndGM3TnlMcDRXYmI1NmQ1NHduZHJVZjN2QmJCZnUvNkIxZzB5?=
 =?utf-8?B?ZjZJNlBnWnhaQTBTSDBkWElOSkx1dnhydVZGUU9rYjFnRkFyYm1GdTc3VExT?=
 =?utf-8?B?SVdxRWczUWlRakFML3RHSTdtOUc4cG5Pb1E2WmpwRUtKRmtzRTJIdmhQclpq?=
 =?utf-8?B?V3A1WndqZGxucGV5ZHliN0xMQnpEUWtqV2o4NDlWaFJHVFR2K0RCV3hWM0xi?=
 =?utf-8?B?NEJDTi9rcWJlNXE4S0psTXVEeEhwRlBDYXBFTkFrd2g0Qjd3U1A5dG8wM0JO?=
 =?utf-8?B?REE4azVvWm4vVVlWejhhU2Jwa3VxNkl5S0c1Z1V0RjRjdHlQeXZneWIyTGZE?=
 =?utf-8?B?TEdVOGgvVHJBSjZtejFuWkV3cG1lSW0yZkVmRVlIU2JCZUhRTXRYMkVYdmp6?=
 =?utf-8?B?V2xhTW9xTGVCc0RYN01ZNkRYVS9QcDZMbERqV1lwL3JHU3RuN24yeEdJOXh5?=
 =?utf-8?B?SkdkcVZXcXpoQXZjZW1CV0Y1cVUxdGIrclpaMzdpSDBEVE9vUkJ3UERPWExF?=
 =?utf-8?B?VTZaMUNBOENjcW9hN0w0eXdJSFVsODJHTzk1aUQ5R3dYNXlldER3YjJUcHhy?=
 =?utf-8?B?cWNjbkIyVmlHMkRrakFSWnM4RnRvODFXMWc2bjM1bFhiTkcxVlArOXFZR1Zt?=
 =?utf-8?B?R1RhNjNXUTBYZTZVMlJLeCtsQldYZExHcWhHcnJ4OHhucjJ1WVJ3U2J4Zzc0?=
 =?utf-8?B?Ymt3SUp6SnlWVzNHbUlmc01oMEFrU1d6U1hvRmoyTFVtSW8wMWxpY1FVTkJj?=
 =?utf-8?B?azlmYmwwL2pSMGNFNmZzSDVxTW91YnF6WFdPNDJqMDlxRHNBNUlldlkxclJI?=
 =?utf-8?B?L1kxUDJyR0EvTEVLZnpXeFFnaE1pbUNzeTRyYWU0TXFZMElVTjZOQkhGMVY1?=
 =?utf-8?B?aG4xbVlNMlBqTWJaMml2amIwaWhnPT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <13B56734A7CA844390A83D9A6E302AC5@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7bff13b8-6d3c-4885-f1db-08d9f2e7a275
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Feb 2022 14:04:52.5547
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: WzeXmmcLVvAE2LqfcYPOp+iN5XRVamRJqr7V9TLPsV7uHcFCyhz1iuxrkGrvy34UcKMKTobmKforZQUslmRTFRhQmp1o0uuDuEptE7/hkug=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB4605
X-OriginatorOrg: citrix.com

T24gMTgvMDIvMjAyMiAxMzozNiwgUm9nZXIgUGF1IE1vbm5lIHdyb3RlOg0KPiBPbiBGcmksIEZl
YiAxOCwgMjAyMiBhdCAxMjoyMzo0N1BNICswMDAwLCBBbmRyZXcgQ29vcGVyIHdyb3RlOg0KPj4g
T24gMTgvMDIvMjAyMiAxMjoyMSwgQW5kcmV3IENvb3BlciB3cm90ZToNCj4+PiBPbiAxOC8wMi8y
MDIyIDEyOjAwLCBSb2dlciBQYXUgTW9ubmUgd3JvdGU6DQo+Pj4+IEFkZCBhIHdvcmtmbG93IHRo
YXQgcGVyZm9ybXMgYSBidWlsZCBsaWtlIGl0J3MgZG9uZSBieSBvc3N0ZXN0DQo+Pj4+IENvdmVy
aXR5IGZsaWdodCBhbmQgdXBsb2FkcyB0aGUgcmVzdWx0IHRvIENvdmVyaXR5IGZvciBhbmFseXNp
cy4gVGhlDQo+Pj4+IGJ1aWxkIHByb2Nlc3MgaXMgZXhhY3RseSB0aGUgc2FtZSBhcyB0aGUgb25l
IGN1cnJlbnRseSB1c2VkIGluDQo+Pj4+IG9zc3Rlc3QsIGFuZCBpdCdzIGFsc28gcnVuIGF0IHRo
ZSBzYW1lIHRpbWUgKGJpLXdlZWtseSkuDQo+Pj4+DQo+Pj4+IFRoaXMgaGFzIG9uZSBiaWcgYmVu
ZWZpdCBvdmVyIHVzaW5nIG9zc3Rlc3Q6IHdlIG5vIGxvbmdlciBoYXZlIHRvIGNhcmUNCj4+Pj4g
YWJvdXQga2VlcGluZyB0aGUgQ292ZXJpdHkgdG9vbHMgdXAgdG8gZGF0ZSBpbiBvc3N0ZXN0Lg0K
Pj4+Pg0KPj4+PiBTdWdnZXN0ZWQtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNp
dHJpeC5jb20+DQo+Pj4+IFNpZ25lZC1vZmYtYnk6IFJvZ2VyIFBhdSBNb25uw6kgPHJvZ2VyLnBh
dUBjaXRyaXguY29tPg0KPj4+PiAtLS0NCj4+Pj4gIC5naXRodWIvd29ya2Zsb3dzL2NvdmVyaXR5
LnltbCB8IDM1ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysNCj4+Pj4gIDEgZmls
ZSBjaGFuZ2VkLCAzNSBpbnNlcnRpb25zKCspDQo+Pj4+ICBjcmVhdGUgbW9kZSAxMDA2NDQgLmdp
dGh1Yi93b3JrZmxvd3MvY292ZXJpdHkueW1sDQo+Pj4+DQo+Pj4+IGRpZmYgLS1naXQgYS8uZ2l0
aHViL3dvcmtmbG93cy9jb3Zlcml0eS55bWwgYi8uZ2l0aHViL3dvcmtmbG93cy9jb3Zlcml0eS55
bWwNCj4+Pj4gbmV3IGZpbGUgbW9kZSAxMDA2NDQNCj4+Pj4gaW5kZXggMDAwMDAwMDAwMC4uMTJm
YzljNzgyYg0KPj4+PiAtLS0gL2Rldi9udWxsDQo+Pj4+ICsrKyBiLy5naXRodWIvd29ya2Zsb3dz
L2NvdmVyaXR5LnltbA0KPj4+PiBAQCAtMCwwICsxLDM1IEBADQo+Pj4+ICtuYW1lOiBDb3Zlcml0
eSBTY2FuDQo+Pj4+ICsNCj4+Pj4gKyMgV2Ugb25seSB3YW50IHRvIHRlc3Qgb2ZmaWNpYWwgcmVs
ZWFzZSBjb2RlLCBub3QgZXZlcnkgcHVsbCByZXF1ZXN0Lg0KPj4+PiArb246DQo+Pj4+ICsgIHNj
aGVkdWxlOg0KPj4+PiArICAgIC0gY3JvbjogJzE4IDkgKiAqIFdFRCxTVU4nICMgQmktd2Vla2x5
IGF0IDk6MTggVVRDDQo+Pj4+ICsNCj4+Pj4gK2pvYnM6DQo+Pj4+ICsgIGNvdmVyaXR5Og0KPj4+
PiArICAgIHJ1bnMtb246IHVidW50dS1sYXRlc3QNCj4+Pj4gKyAgICBzdGVwczoNCj4+Pj4gKyAg
ICAtIG5hbWU6IEluc3RhbGwgYnVpbGQgZGVwZW5kZW5jaWVzDQo+Pj4+ICsgICAgICBydW46IHwN
Cj4+Pj4gKyAgICAgICAgc3VkbyBhcHQtZ2V0IGluc3RhbGwgLXkgd2dldCBnaXQgYmNjIGJpbjg2
IGdhd2sgYnJpZGdlLXV0aWxzIFwNCj4+Pj4gKyAgICAgICAgICBpcHJvdXRlMiBsaWJjdXJsNC1v
cGVuc3NsLWRldiBiemlwMiBsaWJwY2ktZGV2IGJ1aWxkLWVzc2VudGlhbCBcDQo+Pj4+ICsgICAg
ICAgICAgbWFrZSBnY2MgbGliYzYtZGV2IGxpYmM2LWRldi1pMzg2IGxpbnV4LWxpYmMtZGV2IHps
aWIxZy1kZXYgXA0KPj4+PiArICAgICAgICAgIGxpYm5jdXJzZXM1LWRldiBwYXRjaCBsaWJ2bmNz
ZXJ2ZXItZGV2IGxpYnNzbC1kZXYgbGlic2RsLWRldiBpYXNsIFwNCj4+Pj4gKyAgICAgICAgICBs
aWJiejItZGV2IGUyZnNsaWJzLWRldiBnaXQtY29yZSB1dWlkLWRldiBvY2FtbCBsaWJ4MTEtZGV2
IFwNCj4+Pj4gKyAgICAgICAgICBvY2FtbC1maW5kbGliIHh6LXV0aWxzIGdldHRleHQgbGlieWFq
bC1kZXYgbGlicGl4bWFuLTEtZGV2IFwNCj4+Pj4gKyAgICAgICAgICBsaWJhaW8tZGV2IGxpYmZk
dC1kZXYgY2FiZXh0cmFjdCBsaWJnbGliMi4wLWRldiBhdXRvY29uZiBhdXRvbWFrZSBcDQo+Pj4+
ICsgICAgICAgICAgbGlidG9vbCBsaWJmdXNlLWRldiBsaWJsem1hLWRldiBuaW5qYS1idWlsZCBc
DQo+Pj4+ICsgICAgICAgICAga3BhcnR4IHB5dGhvbjMtZGV2IHB5dGhvbjMtcGlwIGdvbGFuZyBw
eXRob24tZGV2IGxpYnN5c3RlbWQtZGV2DQo+Pj4gV2UgZHJvcHBlZCBnZXR0ZXh0IGFzIGEgZGVw
ZW5kZW5jeSBhIGZldyByZWxlYXNlcyBhZ28sIGFuZCB3ZSBkb24ndCBuZWVkDQo+Pj4gcHl0aG9u
My1waXAgZWl0aGVyLsKgIENhbiBmaXggb24gY29tbWl0Lg0KPj4+DQo+Pj4+ICsgICAgLSB1c2Vz
OiBhY3Rpb25zL2NoZWNrb3V0QHYyDQo+Pj4gSSB0aGluayB3ZSB3YW50DQo+Pj4NCj4+PiAtIHVz
ZXM6IGFjdGlvbnMvY2hlY2tvdXRAdjINCj4+PiDCoCB3aXRoOg0KPj4+IMKgwqDCoCByZWY6IHN0
YWdpbmcNCj4+Pg0KPj4+IENhbiBhbHNvIGZpeCBvbiBjb21taXQuDQo+Pj4NCj4+PiBBY2tlZC1i
eTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4gKG1haW5seSBiZWNh
dXNlIEkNCj4+PiBjYW4gc2VlIHRoYXQgQ292ZXJpdHkgaGFzIGRvbmUgdGhlIHJpZ2h0IHRoaW5n
IHdpdGggdGhpcy4pDQo+Pj4NCj4+Pj4gKyAgICAtIG5hbWU6IENvbmZpZ3VyZSBYZW4NCj4+Pj4g
KyAgICAgIHJ1bjogfA0KPj4+PiArICAgICAgICAuL2NvbmZpZ3VyZQ0KPj4gT24gc2Vjb25kIHRo
b3VnaHRzLCB3ZSBjYW4gcHJvYmFibHkgLS1kaXNhYmxlLWRvY3MgaGVyZSwgYmVjYXVzZSBpdCdz
DQo+PiBqdXN0IHdhc3RlZCBwcm9jZXNzaW5nIHRpbWUgd2hlbiBhbGwgd2UgY2FyZSBhYm91dCBp
cyB0aGUgQy4NCj4gV2UgZG8gbm90IGJ1aWxkIHRoZSBkb2NzIGFscmVhZHksIGJlY2F1c2UgdGhl
IGJ1aWxkIGNvbW1hbmQgaXMgYG1ha2UNCj4geGVuIHRvb2xzYC4NCj4NCj4gVGhhbmtzLCBSb2dl
ci4NCg0KR29vZCBwb2ludC4NCg0KfkFuZHJldw0K


From xen-devel-bounces@lists.xenproject.org Fri Feb 18 14:17:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 18 Feb 2022 14:17:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275500.471402 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL450-00066C-VM; Fri, 18 Feb 2022 14:17:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275500.471402; Fri, 18 Feb 2022 14:17:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL450-000665-SR; Fri, 18 Feb 2022 14:17:50 +0000
Received: by outflank-mailman (input) for mailman id 275500;
 Fri, 18 Feb 2022 14:17:49 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=YtLv=TB=citrix.com=prvs=0411da6ea=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nL44z-00065z-4l
 for xen-devel@lists.xenproject.org; Fri, 18 Feb 2022 14:17:49 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8b6cd64f-90c5-11ec-8723-dd0c611c5f35;
 Fri, 18 Feb 2022 15:17:47 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8b6cd64f-90c5-11ec-8723-dd0c611c5f35
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645193867;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=dGRY3nYm5LQJyB2cOwRV6M5AzMjjwfdBEyE/7Jl6Xlw=;
  b=ER6onnktLz8zT8Io+wyFiAsUFgH923x0Q6jOPtD2uj5ErfxWmeXL8Qra
   MMUVZ4v/MmevLPo5pP/uUuyLlBgKfB8CqlnCUBojMs1JONQmqU0PO8U8H
   2TZSZdpH3UzpfzsC9OXb/RszrXjqZEha9FCgfTt+wSGMApiEFSd6WTHGe
   E=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 64416751
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:SgBY5qsZ2mN8yvbSo6f4PhyO+OfnVGleMUV32f8akzHdYApBsoF/q
 tZmKW3UP/mOMzahftgnb4S+8koHucTRmNRqTQduqS4yRSJB+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQzy4bVvqYy2YLjW1nU6
 YuryyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb
 /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo
 Oihu6BcRi8kO6Dzuco0YiNeGhFmZ7x6oaDaLFig5Jn7I03uKxMAwt1rBUAye4YZ5vx2ESdF8
 vlwxDIlN07ZwbjsmfTiF7cq1p9LwMrDZevzvll6yj7UF7A+SI3rSKTW/95Imjw3g6iiGN6AO
 5ZAN2UyNXwsZTVia0gNGKwRv9uG2Emidjh4lHabm6A4tj27IAtZj+G2bYu9lsaxbcdImkeVo
 ErW8mK/BQsVXPSE0iaM+H+ogu7JnAv4VZgUGbn+8eRl6HWMwkQDBRtQUkG0ydGph0j7V99BJ
 kg8/is1sbN05EGtVsP6XRCzvDiDpBF0c9haHvA+6QqN4rHJ+AvfDW8BJgOtc/R/6pVwH2Zzk
 AbUwZW5XlSDrYF5V1qQ87qrjB2bCBITJF8aPz44FBQY7vn89dRbYg30cv5vF6u8j9vQED72w
 iyXoCVWu4j/nfLnxI3gowmZ3mvESozhC1dsu16JBj7NAhZROdb9D7FE/2Q3+hqpwGyxalCa9
 EYJlMGFhAzlJcHczXfdKAnh8VzA2hpkDNE+qQI+d3XC3270k5JGQWy2yGgvTKuOGpxZEQIFm
 GeJ5WtsCGZ7ZRNGl5NfbYOrENgNxqP9D9njXf28RoMQPsUoLlPfrX0wPBT4M4XRfK4EyPBX1
 XCzK5vEMJrnIf4/kGreqxk1itfHORzSNUuMHMumnnxLIJKVZWKPSKdtDbd9RrtR0U9wmy2Mq
 4w3H5LTk313CbSiCgGKod97BQ1bdhATWMGpw/G7g8bee2KK7kl6UKSPqV7gEqQ495loehDgp
 C/lARYAkAKl7ZAFQC3TAk1ehHrUdc8XhVowPDA2PEbu3H4mYI2167wYeYdxdr4inNGPB9YuJ
 xXZU61s2shydwk=
IronPort-HdrOrdr: A9a23:DyoX0aPXry7ECcBcT1v155DYdb4zR+YMi2TDiHoedfUFSKOlfp
 6V8MjztSWVtN4QMEtQ/+xoHJPwPE80kqQFnbX5XI3SJjUO3VHIEGgM1/qG/9SNIVybygcZ79
 YeT0EcMqyBMbEZt7eD3ODQKb9Jq7PrgcPY59s2jU0dNj2CA5sQnjuRYTzra3GeKjM2YqbQQ/
 Gnl7R6TnebCD4qR/X+IkNAc/nIptXNmp6jSRkaByQ/4A3LqT+z8rb1HzWRwx9bClp0sPsf2F
 mAtza8yrSosvm9xBOZ/2jP765OkN+k7tdYHsSDhuUcNz2poAe1Y4ZKXaGEoVkO0aySwWdvtO
 OJjwYrPsx15X+UVmapoSH10w2l6zoq42+K8y7QvVLT5ejCAB4qActIgoxUNjHD7VA7gd162K
 VXm0qEqpt+F3r77WXAzumNcysvulu/oHIkn+JWpWdYS5EiZLhYqpFa1F9JEa0HADnx5OkcYa
 dT5fnnlbVrmG6hHjLkVjEF+q3oYp1zJGbIfqE6gL3U79AM90oJi3fxx6Qk7wE9HdwGOt55Dt
 //Q9ZVfYd1P7grhJJGdZQ8qPSMexnwqDL3QSqvyAfcZeo600ykke+C3Fxy3pDtRKA1
X-IronPort-AV: E=Sophos;i="5.88,378,1635220800"; 
   d="scan'208";a="64416751"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=k9gC1hLe9Six56e/TFc0tylQEWGND03py2QBjBe36x5hCQ/5mnbzvrKyK37TAd25u7C6yS1onSXXhoeMTDc88d/ob4KvyYuIh/kSHyqUTEmqFrGUA8ZSmjoR1jU+cPntTfEDUOhUe00Pr1DTJzbWE+C2osisEwlJNcemUV4JFX8Tv1yn5bdCbf8jxYbAvgw+kicGLDfO1RqHs9d6Xkkdvr8GgkiXqEXvpz5py8D++a78KQwHVT/aBIJid5yxo64kZd918c/Y0DIM3jNcVitIM10kCa65xqubFZPxSSzKdxFKWfmPjEb3SPtuUwWqNlYSG3L0LcOWxUTbz2tEiCA7ug==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=RnMNqMDAPNB8sN0Ba8vr6XnL4/lcdqLqp9Dc7DfcPas=;
 b=K23UPVNyRniCS/MMYOMufifUvEDzd2IG0BAFj27R0zSrQ/iNc9rko1UOvV0TAeJrNM++Qal6f7UrP5MKk6dRDLImEcP5xQOs6IhHAtZNF4m/2uCArIO0zGZaCgppnYQfTqnQR/NZBMQto09CvE/ym79EmyNBbKouFQWnkYPBiQ3iNhmIecGbwE9Sl+jbAcreZk2nJA8nW25xuYjQnBUxiJyemn3OOjfeGDEEr54ZsKsX8SDUS4Q6q8lB0y3Ksd0Y45I80IZNUmgEm6agoR65VO6P3f6F3kwO8tixg5C4rG0hWXKTNfA3a60k20YpEJ74UKyoaFk3/DZuHpSAWaVNzQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=RnMNqMDAPNB8sN0Ba8vr6XnL4/lcdqLqp9Dc7DfcPas=;
 b=V6TBEpWsL+h21plnO1BS9n+SUApJlrGj/c+gjlR1HI1VxekyxwgjwBQb2ijLt+ltIU0xWGr8DgimRnGVR1twEpUCaLvCFRxZgY5MpANhC49eLiWCXA9Wt5G8yDzSOahnO9fObnSt+zqVCCk4doNS59wx8eIButbaugYdiS0YzJ0=
Date: Fri, 18 Feb 2022 15:17:35 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Jan
 Beulich" <jbeulich@suse.com>, Wei Liu <wl@xen.org>, George Dunlap
	<George.Dunlap@citrix.com>, Julien Grall <julien@xen.org>, Stefano Stabellini
	<sstabellini@kernel.org>
Subject: Re: [PATCH v2 0/3] retpoline: add clang support + Kconfig selectable
Message-ID: <Yg+qf6ZlTX67LPCv@Air-de-Roger>
References: <20220216162142.15384-1-roger.pau@citrix.com>
 <cfa55fd4-1990-b1ac-e6f3-94ef364793a3@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <cfa55fd4-1990-b1ac-e6f3-94ef364793a3@citrix.com>
X-ClientProxiedBy: LO2P265CA0435.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:e::15) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b6182592-0c2e-4162-8450-08d9f2e96af3
X-MS-TrafficTypeDiagnostic: BYAPR03MB4439:EE_
X-Microsoft-Antispam-PRVS: <BYAPR03MB4439207A9E7326A15DCCA1CE8F379@BYAPR03MB4439.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: aoq8pt/Qukd4a31CaVu1cJAawUIOW9CyrkmB1VPjN4VSPWW60NDRnPfsHp7sZkPz5C1ZYHvC3zngT4aruhVcR8U733liON4oj8R/6O1U3SqqQcalBhgfcTBWY5NirMpL9lZSnyTwle5QiISfPWR9341fECnX6Y/VUyv+FAlsCNS52ypBtFGXucxYcJOxs70bV4WXsD/WQxjDCA08IFwGYfazX2YdpXD/ptzwrRIHM97kuqaOyUSPFqdyVDsncz2CLeS9BQOQymkf4T05p6jPrxWdANBrLft7WEWFL77ncLge9/TXr30CLhIsYUBqSKNWGXQU/5TB5w8t0HU8LwKup8Heb/0JWTJKipGZv/DPxJZstV3vdPoxMlgdKYt+UzTwjp/H0J2Nh0vXoegCeIEAIyyKJq8roL4OoeRKLvx77Uo+7s+DU0ZG1+HN6r4jMFu3crgsltk2jIBX98a3Rjk4p7hwtNXLfSEM886vck6eWbdQghJUk0aWd1OZ8X1pfnTeI2eem9TYDAaS+h/4SvU23qdkJYBOgz8XRb5favasFS5JKD9N46NwQRzm96RG1ANK55PJ5UnPJZN9Wx33srNuoq+8LGFAet4tj5XOIMJBv/xZ8SX2WW/C2z0vA6OQvKG12UWFR3Hk1v/ztVSEMc1mScnw/A3yaSjhMP8BUA+xCSE+l6lRWyG9CtovMHFnUnob0tT3+RAn0rIQzegNcwCY0w==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(8936002)(2906002)(6486002)(66946007)(66476007)(66556008)(8676002)(4326008)(86362001)(5660300002)(38100700002)(6862004)(82960400001)(83380400001)(33716001)(186003)(26005)(508600001)(54906003)(6666004)(6512007)(6506007)(6636002)(316002)(85182001)(53546011)(9686003)(67856001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WkdoUHVJZk1lKzlmb3hsaEx4MHNiOGdobGJMVXlhZHJ1Z3RUdkdVZnZHZ25x?=
 =?utf-8?B?MXZ3MERtdTJxbDBHZ0ZaNWJtNXpRbDQyMy8yaG5aYUg4SUdSQ0hWa0dRMHNa?=
 =?utf-8?B?NVpCQ3BRQ2IwdUZrem9tZ3g3TXIxQ1BsYW40eDRyMDNrbmhPV2JPanpwSnJT?=
 =?utf-8?B?Rk00T1lyYVhINXBOL1VObWpnRGdlUUcyejdrdmFJeXE0ZHpwOHJQRy9PWTZo?=
 =?utf-8?B?OFNSMjVab3Q0Z1NPUU15d0lFanE5QmxKSjhxV29TYVlaMk41Y2s0eGc3dEs1?=
 =?utf-8?B?MWh5L3JKWUc1eXE3STVwazJYYlhTYWFTU211MVJUQjJVNHR1V2RCTGhvVlNr?=
 =?utf-8?B?MFd6akxEay82MkZaNW5sSVI2TXJydHY0eDBteTlyS2NtRnpvRFF5ZG9nOXh0?=
 =?utf-8?B?SlhFSlRiZ2dkZGtzY0xTZS9JSW94Z1hweFRwVTNVSUQrNnl0bVYwWjIyeWw2?=
 =?utf-8?B?RjdFYUNIRzBhcGF3QzU3ZW5lTi9xYXJrTlNJTmliMUpJbEdJcTRQTVdoLzQv?=
 =?utf-8?B?d2tXdTZPMW5qZlUyU1JhTEVvRmRkQ2JIQjlncnN1VTVjc2tMeTZTOENSbndt?=
 =?utf-8?B?VU1Wc1RuMVpKMW04WEp6N3BQelVMVEJYNUw0TENXSVVvYW5WTVZkbWt3MVFi?=
 =?utf-8?B?Q2RqNWNkRy9jVi9XVVdITndudjVrTkVsSnl2cHFObFVqMDdZcVdmR0hURWJE?=
 =?utf-8?B?dXl2NlBRMkM0VFZpN3pKRXVMZnl5TDZNMHIvM1dudWppOTMrYUMyYzZyc1Na?=
 =?utf-8?B?QmhqUERKRlBkZmFZZm1vTFBWZXYvdEVFamRhMjhNZFNkZlNFNFNKMGxrcWJl?=
 =?utf-8?B?K1g2UDlTc3ljQjJNL3dZNWxmd0p3K0pnV1R0S0oxTXhLbUNOK0s4TUJXU1hv?=
 =?utf-8?B?MmUwY21nWHI5RmVzK2RhcHBvR1pkOTVEeElUSlN2MXp5VHAyUmFabnovdGdG?=
 =?utf-8?B?MTBZOVF2bWFLejhMZGpNeERmZ25XbnpBNzhMS25DbGNaRW5SbVFpZjVUd01i?=
 =?utf-8?B?NmhISE5FMjcwMUpQWEFGbWIvc1d4YWM0S0lQaHZqQW1DUStxUlNBcDZHRi9w?=
 =?utf-8?B?em53WENKZkFrSVhWZlhTdm1uenRRY2EwSis4dlZnQi9paHFTUWhORkdHVDAw?=
 =?utf-8?B?bk16N0hRa2paOGtJc09IVEtDMG81VFlqTktLc20vUUYrSVVkU0hydlozaDNW?=
 =?utf-8?B?UWh2aTAyalBNTlBXdUxJdUU3WEwxMUl5a2ZrTGdWdU8rWjBuMFlkSEU2ZExo?=
 =?utf-8?B?ZEFNMno4VUtSS1c0VDFBODlkWWVSL2NnMTBxanpIekZsOThnSVZnTlhxODNk?=
 =?utf-8?B?cVUvL1dCdm14K1lBTGZOajJ4czYwN1EwbmQxMWRTTG1EWWtkYUw3bXBWUWlw?=
 =?utf-8?B?QldwZkF1ajlRUUx3YzVyRWl6aWFIVjJhSndIaVJ2T0xPKytaWFdJL2RyNlow?=
 =?utf-8?B?RU9LYmNYVmM4RUdqeWhXajJOTHg5L2s4ekxaTG40SndNT1pNWUtyUE5vRk5I?=
 =?utf-8?B?WllRZ3NsREJ4aG9BVUpsRVRZMWlQTWV4Q1VPdCtPaFZHU210OEJOaUxLZmIz?=
 =?utf-8?B?dXNHREVtbk01YTlBR2N0TVp6NElidkNqdjk1VnBWUkgyd1d0SVFXV2tpZmpP?=
 =?utf-8?B?RVpvazRtTWVwTlNobCtjRVY2bDM0ZVA3TXZIQk5kTDFrTXVEL1JnYzlEZzlF?=
 =?utf-8?B?VHJEQ1VKaWZmclBCdDF2TnhHVE5jS3krZUtXQVdydFpPT0k3dW51WCtVM3FV?=
 =?utf-8?B?T0xPYi84SDZVRUpPcHY4N3lLWVMvVFR5TlU4WllxSitGRHJrbVhTQzZJblhM?=
 =?utf-8?B?aWdBZ2NSM2F4aDVWMTZ3KzRFejdQcy9UbHRLNEd2dnRtdXdaRFd6YjV0WEc4?=
 =?utf-8?B?YjNRQXlULzZ3V0hSZEo4QnBDSkhzY2k0VFhKaW9zVTVPL2RCQjhaZHgzZklM?=
 =?utf-8?B?blN5STNkb2NOMnFtWnRENUhsSVJybFhiSFR6MksxUVJuOXFZS2F0dHNJaGxo?=
 =?utf-8?B?TG5VME9WUDJrTWVMK2JMT3AyV2l2OFUzaG9nNitJWkJDMnY2M2RNd0VoQlZY?=
 =?utf-8?B?WDJSTDZqNHNrUFBER3VuRlh5elRvQ0d1cnBpVGsxMGpmRmxERExxWTlqNGxh?=
 =?utf-8?B?dDJ3RVRXYU1CR1dVNU5GcTRxalJ0ZUMvaG5rM3h4UDdRWjBDQmJUK0twS3VL?=
 =?utf-8?Q?9oym/6ckpzjvGdKLTfx+Hwg=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b6182592-0c2e-4162-8450-08d9f2e96af3
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Feb 2022 14:17:38.7000
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2nlwi/AfquRiA1SshwxcoVv8lwkdDVbHK1WZeZ5PB+hKtDSYYOcYIm13TVzHk3zpmbIa0l17p33ZwTj/o2LCSg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4439
X-OriginatorOrg: citrix.com

On Fri, Feb 18, 2022 at 01:58:31PM +0000, Andrew Cooper wrote:
> On 16/02/2022 16:21, Roger Pau Monne wrote:
> > Hello,
> >
> > The following series adds retpoline support for clang builds, and also
> > allows the user to select whether to enable retpoline support at build
> > time via a new Kconfig option.
> >
> > I've tried adding a suitable description to the Kconfig option, but I'm
> > sure there's room for improvement.
> >
> > Thanks, Roger.
> >
> > Roger Pau Monne (3):
> >   x86/retpoline: rename retpoline Kconfig check to include GCC prefix
> >   x86/clang: add retpoline support
> >   x86/Kconfig: introduce option to select retpoline usage
> 
> I don't particularly want to nitpick, but IMO this would be a lot easier
> to follow if we ended up with
> 
> config CC_HAS_RETPOLINE
>     def_bool $(cc-option,-mindirect-branch-register) ||
> $(cc-option,-mretpoline-external-thunk)
> 
> config INDIRECT_THUNK
>     depends on CC_HAS_RETPOLINE
> 
> and
> 
> ifeq ($(CONFIG_INDIRECT_THUNK),y)
> CFLAGS-$(CONFIG_CC_IS_GCC) += ...
> CFLAGS-$(CONFIG_CC_IS_CLANG) += ...
> endif
> 
> because this reduces the number of CONFIG_* options involved.
> 
> Thoughts?

That would reduce one hidden Kconfig option. I don't mind
implementing it that way.

> On substantially more minor points, INDIRECT_THUNK wants to be first in
> the speculative hardening list, seeing as it is by far and away the most
> important one, and I think we should stop writing things like "If
> unsure, ..." in the help because it's just parroting the default which
> is also rendered to people reading this message.  Our audience here are
> developers, and I think we can depend on them to intuit the stated default.

OK, so let me put that one first on the list then, and drop the "If
unsure, "

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Feb 18 14:34:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 18 Feb 2022 14:34:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275510.471425 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL4LC-0000Ho-NC; Fri, 18 Feb 2022 14:34:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275510.471425; Fri, 18 Feb 2022 14:34:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL4LC-0000Hh-Jv; Fri, 18 Feb 2022 14:34:34 +0000
Received: by outflank-mailman (input) for mailman id 275510;
 Fri, 18 Feb 2022 14:34:33 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=YtLv=TB=citrix.com=prvs=0411da6ea=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nL4LB-0008Sp-9I
 for xen-devel@lists.xenproject.org; Fri, 18 Feb 2022 14:34:33 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e21f6463-90c7-11ec-8723-dd0c611c5f35;
 Fri, 18 Feb 2022 15:34:32 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e21f6463-90c7-11ec-8723-dd0c611c5f35
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645194872;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:content-transfer-encoding:mime-version;
  bh=OBvd7Te7RVC9tLWUnRCr7dexqEAV0RltpksYs1SPDnw=;
  b=R3aKWenWhiUGNwfuWyF4iX3s5Ek/OpvQFD9sd4CbtEfwC9SNZlHQpyt7
   usjz4oB3QZKxy0g0duz8yRZcEQ7Dh/6HuEZOUeqtZtmw3BP/sHDBDd6P9
   9YA4aR0dzSiZW9Nn2Xi4Gm7FPKArv4mzUjNSPBEE9F81Ds5C6UNuBRiZm
   A=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 63960496
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:yaHGUKnBiORX9doYGzCHIh7o5gyWJkRdPkR7XQ2eYbSJt1+Wr1Gzt
 xIXCmzXOv+CMWX9KNt1Ooq/9khTsZSEzIUxHQtrrX82EiMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2UILd9IR2NYy24DjWlPV4
 7senuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR
 v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ
 NtxWZOYRxsUI4nDx/0kUD5pHj5UI6tnv5rLPi3q2SCT5xWun3rExvxvCAc9PJEC+/YxCmZLn
 RAaAGlTNFbZ3bvwme/lDLk37iggBJCD0Ic3oHZvwCufFf87aZvCX7/L9ZlT2zJYasVmQ62PO
 ZJFOGQHgBLobx9RNH0qKJIFhe6tmHrnXxgGq0+Euv9ii4TU5FMoi+W8WDbPQfSVQe1Fk0Deo
 XjJl0z7CBwHMN2UyRKe72mhwOTImEvTSI8UUbG16PNuqFmS3XAITg0bU0Ohpvu0gVL4XMhQQ
 3H44QJ38/J0rhbyCICgAVvo+xZooyLwRfJeD9AnzA7S05PXxDeUGUIaSB8GTdA54ZpeqSMR6
 neFmNbgBDpKubKTSG6A+rr8kQ5eKRT5PkdZO3ZaEFJtD83L5dhq00mRFooL/Lud04WtcQwc1
 Qxmu8TXa187qccQn5u28lnc695HjsiYF1Vljuk7s4/M0++YWGJHT9D5gbQ4xawZRGp8crVnl
 CFV8yR5xLpTZaxhbATXHI0w8EiBvp5pygH0j191BIUG/D+w4XOldo04yGggeBowaJpcKGO3O
 RW7VeZtCHl7ZSrCgUhfOd/ZNijX5fK4SYSNug78NbKinaSdhCfYpXozNCZ8LkjmkVQ2kLFXB
 HtoWZ3EMJruMow+lGDeb75EidcDn3lirUuOFcGT50n2itK2OS/KIYrpxXPTN4jVGovf+16Lm
 zueXuPXoyhivBrWOHePqtdLdQhQRZX5bLivw/Fqmie4ClMOMEkqCuPLwKNnfIpgnq9PkfzP8
 G37UUhdoGcTT1WdQelWQhiPsI/SYKs=
IronPort-HdrOrdr: A9a23:DCiLMq1pvVo0VBtwcJTw4wqjBLYkLtp133Aq2lEZdPUzSL3+qy
 nOpoV+6faQsl0ssR4b9exoVJPufZq+z/5ICOsqU4tKNTOO0AHEEGgI1+rf6gylNyri9vNMkY
 dMGpIObeEY1GIK7voSNjPIceod/A==
X-IronPort-AV: E=Sophos;i="5.88,379,1635220800"; 
   d="scan'208";a="63960496"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=a6Ixpo+AY8qOybEFDFwVrdOw0xtCGDyypGF3c9qnd6BdCokqebGcxViWDiO/AZpIvaJxzsxjVv7F4OFEApxNWlsoFfqckp0wiKFxhXNHDfRaLOheyhM+u390rnLvahl7cl32cElkC/JTA57H+WUEDQC+8WLhPCRD7PHUBjqEsjvbH75zlPPxmSqwLbrL/90nj7Qt1Z/65iHtTAg0ZQKis4VzE2jBMhUeZyuYhxcAlMDjRxRx5L+B5MuKcZTxHGXOVaTLYouw3QnOuLY+766setZxV1/ezMUCU2gbPyGgYXUDgcnJ03gdbF6URC2UQtBAP5wUY3gZHhXxJSB4PhR68A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Q5KrC8FlxtiywlEQxR4J2fdDfBJ+V23D+gnQTYifv1I=;
 b=SvzvLa3xJlK2Ze10l26a9mBsji+99lxl0KXdAA1A54PNadroUZtoFQQdnCKkIK6exy79VMU1ArJCKAUv/x40AyKWYFy/TE0Sf4uLln1IEGwCububjOhEUTnV/wSGOTcZLyeQvVwnE7lrSOn0AOmCgt7dSPmdIZ/yCg/YhbSv3OadT/DGrZ9qr/CnaeU+24GEWoRQa8WQTzojF3k7Q7X7iEm4icVINdx7yn0d3rIr+M5iI7iRomYmb1P5gP4rfmddLF65Bw/i5f3wWAQu4GbWbZ0U426P37ur17bGQUiUaE2ne/SplGgY+SugMTQ9rS53m8b8iqeCcMSAMw4A369zGw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Q5KrC8FlxtiywlEQxR4J2fdDfBJ+V23D+gnQTYifv1I=;
 b=pFBYwqcI67c6kf8R2NxFy978xltcIrZMpZZSzQ711f6YTPjPr0gBESzYSN4Ae4sNj/pBtA9K7F+kvDuKT/UFoYgjzf191mBkfoE/InEjPVD/EArrrODzhxDvVB8C0uYrhP74uZASU7Qc9X4YPaXPJLgTHe9rE+Kwrl7IvzjrGOY=
From: Roger Pau Monne <roger.pau@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Roger Pau Monne <roger.pau@citrix.com>, Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: [PATCH v3 1/3] x86/retpoline: split retpoline compiler support into separate option
Date: Fri, 18 Feb 2022 15:34:14 +0100
Message-ID: <20220218143416.34475-2-roger.pau@citrix.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220218143416.34475-1-roger.pau@citrix.com>
References: <20220218143416.34475-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO4P123CA0223.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1a6::12) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 658147a6-596c-4729-b009-08d9f2ebc3ea
X-MS-TrafficTypeDiagnostic: DS7PR03MB5543:EE_
X-Microsoft-Antispam-PRVS: <DS7PR03MB5543E921E3CB8FB6701EB8918F379@DS7PR03MB5543.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4502;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: aafhI/N//VXt5Qo4d/Rv2WkKL3iGB6LsF5mGo/OE083fZv1nxot1DZf5BFZ1pwjxOQXY8e7ap5K6vBOhShqLwva0BlS7FgkDBrufMq4QWzI/HfvafnRlKQRzT+c+dxtE1Mhur6SGlBakTSnQRblbK0X9b4JKCjR+mTgsW+wKBw88yyYvq5YLqa0x6AFggPdxcnjHDWaSKY1shgPZMWJxZbF3W/RyZDMOYiwh4P9mIwlT6XLuUlokKMFjeN1VlGkkN2zSBWOFjFvu6Uh6N1jkUFr9t18tvJ0g65kr+7Xa/tD5dKZBEwKp6OUuXK++8a+o1wzCNd6OnG0qkH4jf8XtGFVEDKDuN8kf8YcRagbfvzqGaW0NZ2CJvnyNA6mjmlEgdzdyMobLVJK/hCTF6PO1BEh0qQfuVf0xXpeNqJdWsTzwBxMANagZaSKdBTawLmMIoBsjNmZTuutJ9kYLp4xiFOccoyHPqGTnwbql0NX7CNEn93nMGuvfO9GPwDM5+4YULuTuNCxP+K/lv0r2Y+bDUIDAGuIzyGP7kkjJmoVb3AcFCWOd5z4Yo2QSvbF/XWQz0JhxuxTUBLcJMXVRReRtP+1FTvk1KaANgkH42I2T8ZL4ObZhXZ3n20Pt0RNVY46xnJ/l22brrjg4uYS9F7Gukw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(86362001)(6512007)(36756003)(82960400001)(8936002)(26005)(1076003)(6486002)(8676002)(6666004)(6916009)(2616005)(66946007)(5660300002)(2906002)(54906003)(66476007)(316002)(66556008)(83380400001)(4326008)(508600001)(6506007)(186003)(38100700002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V0lIVUpiVHZmb21FR3U3cjBzd0ZCbi9DQStPbDNlZ0tVSWhzRFBCUDlidEkz?=
 =?utf-8?B?VWE0bThaUm9ReTZWdDJKbmlkaWhQSGFEWkc0T3VuTnB1cXY3eTBiRUNnNkJl?=
 =?utf-8?B?amw0UkY2aUQ5VEtOK1I4aTFwc0lxZDQ4R0lsWXJYTVBhNUNYc1F6UjNlZzRt?=
 =?utf-8?B?WlVTUlY3VFF0Sk9lNXY2eUNjZ01jbW91ODl4dDlNd29oVWRJeGtQQVBja3Uv?=
 =?utf-8?B?VVpBdzJCU2pVQytFTDI1NFRqWnh0bmROTmFnTGd0OGFrTnFZWHF0YlVLSzNh?=
 =?utf-8?B?ODltMmljQjdSaDc2bWwrajdPSU5EUG9HOEJmQUhCL0NTbXZlMGhmek5iVEgr?=
 =?utf-8?B?U1NlSWpmVDBkSGEzMWM4Rjd4NXlyNkxPcWQ5Ym5FZVpWaDFMZnNncjZ2d2hp?=
 =?utf-8?B?aFNYZGN4ZkZZMkIyV1ZXTUh6Y0hlSVZYREtPYUZVbjhxWUoxaWlzcGpabU5i?=
 =?utf-8?B?VTFXV1Nkbmd1a09mV25nU1p2TGlHOGhQV0RueCtjaXBMMmpOcFA5YWMzM3NL?=
 =?utf-8?B?Um90OTJ1UmRFcU9Ea0JONkNFRGVGNThkUUk3K25GYWtqbHlGV2hDT0NWVERo?=
 =?utf-8?B?NW93LzR0QVlIbE9zbGN0TFJydFFUTVZpblFodmxzU3RSY2I3WkFYNlZnV2tQ?=
 =?utf-8?B?WnFUblFSRmhDaVJhN2FpcW9JUDh0clB2bmZjcXZNL3RUZnNHcGZyenhiS0gv?=
 =?utf-8?B?YXVTankrc0Y5YWwvT3ZIcUtxOEpSRjNtVmMxYWR4ejk2SzZ0NXI3M1pncUNW?=
 =?utf-8?B?SkJXeWIvSGVJLzJDV0xweG5FT0h4VzBuWGdlTjRQZjhCSDErVnZBN3RIWlZq?=
 =?utf-8?B?bnJ4UFNsYW1Qd01qbVJIY0ZLY1I0U2tZR1pMK01zWHV0aUc5NC80aDdtOXBQ?=
 =?utf-8?B?UkJheS9DWXNlQU5Yai9iL3pRTlFOSTJiMzR3dUJSaHhlaTF3a1hnYXlVUGo2?=
 =?utf-8?B?eWZKOUJSR1pMMEhiRDAvdWVtZUVLZExOc1Z4SHlOMGVzZjdjQmYwWTU2eldZ?=
 =?utf-8?B?V0EwNmluTy9LZFlXVWZOOWFSK1NMVUlMY3dGNlJUSklTRFgwbm5ha1ZVdGxW?=
 =?utf-8?B?Rk9sRC9vdWFxTEZaTkdCM3lXSkZCUkY0YU9lOGlNSmdMVjFFVlZTbW9tWWVt?=
 =?utf-8?B?anBwSjZ0UnlYMnpnRnRXTkNrZXFWcGJ1cEY3YnR2d2ZZR1N4elMzWmNDK3hh?=
 =?utf-8?B?azRyS1A0MURCbXNPckhLbEk5NEEvTmxmbVpsc2VLMERyRUlmK1IrT2JDY2Vj?=
 =?utf-8?B?NVFVZ3RjN1dOWEU4R0s4cE44a1Nyc3EremFPd1ZGSGd1WEhXbGtmLzh6WUNB?=
 =?utf-8?B?WitrcG9YejVHOFZyWUxjTVhPQ3NVRkZuMW43U0pPMWV4aGhsSUp4Z0hrVzQ5?=
 =?utf-8?B?ZmdPSDBhNW15dDVRQVFkQTh1QmVyN25VVGpmUi9Ob1RBOUpJbUxzUFFEYW45?=
 =?utf-8?B?QlNKUmtwbWxXeTNOT25DSnlEN29Rb0hPNk4vQnc3NkVLSWpBT3RwMEkvV0Vr?=
 =?utf-8?B?c2Jsa2dhQjZHTm1aSld1YkVoZjFrbml0djZsRWZTRm55eWhPT2JJK25SQndI?=
 =?utf-8?B?enNPK2JRTEQ2WFNnK2ZVVFRDY2pNN0ZucFl6aW5Ba010S1pPT0JadGkzR2li?=
 =?utf-8?B?SkoyUUphNW9LSmZSQlBJM0R2dGVjUjlSQ01CQmR1aDJNc28wNkJNS3dDdHdj?=
 =?utf-8?B?SWp4ckJhK0txU0JyS0Z4R21Kb2g3TVhrN1JaT2FaZ0owb3crMkZHdkQyejNq?=
 =?utf-8?B?QXdWWjNWQlBHaW8zU3F3M1RPVU5lUkNUdk9RSTcrUzNHQi8vZ241Tkg4bVZ4?=
 =?utf-8?B?YzEvNnFkcFpnaUp4SFVqTkI0aUR5Q3U5UXhEVjJueXZXRFI1UVhGQU5UTVNZ?=
 =?utf-8?B?d3kwM2tkTzdUVnU4OU9ZQ1VCTjQ4Sk5TbURjQlArTk82SUVabTIzVExTYWkr?=
 =?utf-8?B?cEJhRFA0NGt6djU3RFFacXZveWVkSFUyZXBpLzM5Szh1czFUSWdMN3ZvU3dO?=
 =?utf-8?B?Z1Q3b3pxOVI2UkRJZGx1N1VTbGtNOEFQT1dPeWVwbENQZGlMUjFzVlh6aDU0?=
 =?utf-8?B?ZnlMM1FVaEZrQUp1djBHeW5ncktaNmZ6WDRQcDFGMms4dmZTS25RNERQWGZE?=
 =?utf-8?B?b3EyNDR2bnpIMEh3VHdidjNvekdMS2pCRFpWa0hrOUlOM2dmVDVWUVhHZVhj?=
 =?utf-8?Q?NTacOkrg/5ejpy3hWky5yjI=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 658147a6-596c-4729-b009-08d9f2ebc3ea
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Feb 2022 14:34:27.0322
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rgqKvh1TK6+p4i07OBiG71NfQaU2dSjc4dHThmA4mq+B0v+x2g79x5FZnixLS5i99cxMJIzMxvSGTWgJtLpYAA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5543
X-OriginatorOrg: citrix.com

Keep the previous option as a way to signal generic retpoline support
regardless of the underlying compiler, while introducing a new
CC_INDIRECT_THUNK that signals whether the underlying compiler
supports retpoline.

No functional change intended.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Changes since v2:
 - Make the compiler option check generic instead of GCC only.

Changes since v1:
 - Put def_bool before depend on.
---
 xen/arch/x86/Kconfig |  6 +++++-
 xen/arch/x86/arch.mk | 10 ++++++----
 2 files changed, 11 insertions(+), 5 deletions(-)

diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig
index b4abfca46f..a1a90da4fc 100644
--- a/xen/arch/x86/Kconfig
+++ b/xen/arch/x86/Kconfig
@@ -32,9 +32,13 @@ config ARCH_DEFCONFIG
 	string
 	default "arch/x86/configs/x86_64_defconfig"
 
-config INDIRECT_THUNK
+config CC_INDIRECT_THUNK
 	def_bool $(cc-option,-mindirect-branch-register)
 
+config INDIRECT_THUNK
+	def_bool y
+	depends on CC_INDIRECT_THUNK
+
 config HAS_AS_CET_SS
 	# binutils >= 2.29 or LLVM >= 6
 	def_bool $(as-instr,wrssq %rax$(comma)0;setssbsy)
diff --git a/xen/arch/x86/arch.mk b/xen/arch/x86/arch.mk
index fa7cf38443..6388b1d93f 100644
--- a/xen/arch/x86/arch.mk
+++ b/xen/arch/x86/arch.mk
@@ -42,10 +42,12 @@ CFLAGS += -mno-red-zone -fpic
 # SSE setup for variadic function calls.
 CFLAGS += -mno-sse $(call cc-option,$(CC),-mskip-rax-setup)
 
-# Compile with thunk-extern, indirect-branch-register if avaiable.
-CFLAGS-$(CONFIG_INDIRECT_THUNK) += -mindirect-branch=thunk-extern
-CFLAGS-$(CONFIG_INDIRECT_THUNK) += -mindirect-branch-register
-CFLAGS-$(CONFIG_INDIRECT_THUNK) += -fno-jump-tables
+ifeq ($(CONFIG_INDIRECT_THUNK),y)
+# Compile with gcc thunk-extern, indirect-branch-register if available.
+CFLAGS-$(CONFIG_CC_IS_GCC) += -mindirect-branch=thunk-extern
+CFLAGS-$(CONFIG_CC_IS_GCC) += -mindirect-branch-register
+CFLAGS-$(CONFIG_CC_IS_GCC) += -fno-jump-tables
+endif
 
 # If supported by the compiler, reduce stack alignment to 8 bytes. But allow
 # this to be overridden elsewhere.
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Fri Feb 18 14:34:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 18 Feb 2022 14:34:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275511.471436 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL4LH-0000aX-Ve; Fri, 18 Feb 2022 14:34:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275511.471436; Fri, 18 Feb 2022 14:34:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL4LH-0000aQ-SW; Fri, 18 Feb 2022 14:34:39 +0000
Received: by outflank-mailman (input) for mailman id 275511;
 Fri, 18 Feb 2022 14:34:38 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=YtLv=TB=citrix.com=prvs=0411da6ea=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nL4LG-0000ZM-Q1
 for xen-devel@lists.xenproject.org; Fri, 18 Feb 2022 14:34:38 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e499195e-90c7-11ec-8eb8-a37418f5ba1a;
 Fri, 18 Feb 2022 15:34:37 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e499195e-90c7-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645194877;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:content-transfer-encoding:mime-version;
  bh=7VTNoFVDNGcjQfdLiA7ylnRk9qV10cync6xBOedRTiw=;
  b=QAHd+gsoAw/iMz+t84iot3A745iHxzYdbqmthlOJvVu7WZUG5fX8gOhB
   XJHJof/AGucrSBrXURnrrQoH0yLhU5KoJEy/NihkHRnlObo+tMqV5MQY0
   49IZd+SiNwJPHPTuXssIVbOQzbNzYx+NSfMxQwRWEp4S0QoCK8H4dqVF2
   s=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 64417970
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:q3HvnaKNiG8yTkHxFE+RxpUlxSXFcZb7ZxGr2PjKsXjdYENS3jAOm
 GQXWmnXOPiKM2SgL4pzOt+zoEwD7cLTzoUyGVNlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA180IMsdoUg7wbRh2Nc42YLR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 NRQmsaQVD4jAqeSh+M2SQhYLS1FGbITrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBNPsM44F/Glp0BnSDOo8QICFSKLPjTNd9Gls2pkRTKmGD
 yYfQRRhcBudew9+AWwKC7khrMatn3rmVzIN/Tp5ooJoujOOnWSdyoPFL979atGMA8JPkS6wp
 GjL4mD4CREyL8GExHyO9XfErv/Cm2b3VZwfEJW89+V2mxuDy2oLEhoUWFCn5/6jhSaDt8l3c
 hJOvHB09O5rqRLtHoKVswCETGCsvwMzAfpNKucG4l+SzYHO8ganClMgUWsUADA5j/MeSTsv3
 16PutrmAz1zrbGYIU6gGqeoQSCaYnZMczJbDcMQZU5cuoS4/tlv5v7aZos7SMaIYsvJ9SYcK
 txghAw3nP0tgMECzM1XFniX0mv39vAlouPYjzg7v15JDCslNeZJhKTysDA3CMqsyq7AHzFtW
 1BexqCjABgmV83lqcB0aLxl8EuVz/iEKibAplVkAoMs8T+gk1b6I9wNuWsifBY1bJ9eEdMMX
 KM1kVoAjHO0FCH3BZKbnqrrU5h6pUQePY+Nug/ogipmPcEqKV7vENBGbk+MxWH9+HXAYolkU
 ap3hf2EVC5AYYw+lWLeb75EjdcDm3BvrUuOFMuT50n2jtKjiIu9FO5t3K2mNbtisstpYWz9r
 r5iCid9408BCLanOnGPq+b+7zkidBAGOHw/kOQOHsarKQt6AmAxTfjXxLIqYYt+mKpJ0OzP+
 xmAtoVwkzITWVWvxd22V01e
IronPort-HdrOrdr: A9a23:xyo+r6nF8dwNbiyusYo9p2+zIavpDfO0imdD5ihNYBxZY6Wkfp
 +V88jzhCWZtN9OYhwdcLC7WZVpQRvnhPpICO4qTMuftWjdyRaVxeRZg7cKrAeQfREWmtQtt5
 uINpIOc+EYbmIK/PoSgjPIaurIqePvmMvD5Za8854ud3ARV0gJ1XYGNu/xKDwQeOApP+tdKH
 LKjfA32AZINE5nJfiTNz0gZazuttfLnJXpbVovAAMm0hCHiXeN5KThGxaV8x8CW3cXqI1SvF
 Ttokjc3OGOovu7whjT2yv66IlXosLozp9mCNaXgsYYBz3wgkKDZZhnWZeFoDcpydvfomoCoZ
 3pmVMNLs5z43TeciWcpgbs4RDp1HIU53rr2Taj8A3eiP28YAh/J9tKhIpffBecwVEnpstA3K
 VC2H/cn4ZLDDvb9R6NqeTgZlVPrA6ZsHAimekcgzh0So0FcoJcqoQZ4Qd8DIoAJiTn84oqed
 MeQ/003MwmMW9yUkqp/VWGmLeXLzYO91a9MwQ/U/WuonlrdCsT9Tpc+CQd9k1wg67VBaM0o9
 gsCZ4Y542mePVmGZ6VNN1xMfdfNVa9My4kSFjiWWgPNJt3ck4l+KSHqInc2omRCek1Jd0J6d
 P8bG8=
X-IronPort-AV: E=Sophos;i="5.88,379,1635220800"; 
   d="scan'208";a="64417970"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=af74N8QXH5MqPxnqegTCdHwz1KfVlQYKl/XzcAuBz2/MJLVnuQ0agrWyM9qDgklh55++k3WdNOU6m2OFrmMX7UsLITenguiduGXcFd7cSFgXbSqQxln2pQ5iXFW4hb5lFlmEqDoQ9txbyISkYi+GwxQbE/Gd5sGz0O5icr2ZqJblgRRA94tECSAd3Nff5BeeY2cGWTktXQy2HNKdf7aEW/XQxSlC54PfTsn3zmC4XGENysXgevQIUa0zlX36IwA53IBHPT8+TlJj3MbhJy5/4RbDfo2zRM3NXJfdH/DftWS0nqCSM1PfQ3DH1M9B6teostxVfQFJSAEAn+G+H4vhbA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=nv6gW1Mlt7VQSuRHTBBB8hz+ff/2S3H03ut9wK9Gkqs=;
 b=kpzao6FfhQcuy/b+7ONocd+T5NG8jtvpAitOq7L7WyqC3XwvxAfWxPCa/3MY0NGVQ4RjkIVtt+VEsNEsaJuEywTaaDC4VbZ44XwSd6R2K99e30yK4h34DvTeq+5VLD0Mo+sY6wI5NZw64W+PbbS7EzotrfoJ6NUNoe8kl44MeRBeMvjDwGjlv9esJuSNsu8sO5d5zJHYf3ZR0Nqjgs8QfZ1ybSPRHLfkCUkDCd7C6ji2ca+u/oQYdhKMSQzlYvEt5RVYmF6tCjbWaevHvy1hlTOaYBiWO5a5n/dXHoFrOpCFx8EquPR8GRkAscBO7+SbOzWFmZuIGAY9niCtHEfJ/Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=nv6gW1Mlt7VQSuRHTBBB8hz+ff/2S3H03ut9wK9Gkqs=;
 b=wiO8WYATf5WL+xKwB+hhSYdeF16pHxycMC0cnrJvzFUVI6cfVBL916dGEd771LEzy6YMl9aVAolB0zvXDyJ1Zzk6sEWYeIJY2n9KGg4jFlq5dgbm88TEJ5fioVHMJlG4auMw9excVLvfp0zp+yRw3hde8l4FBVqFAGVqHMMmSBI=
From: Roger Pau Monne <roger.pau@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Roger Pau Monne <roger.pau@citrix.com>, Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: [PATCH v3 2/3] x86/clang: add retpoline support
Date: Fri, 18 Feb 2022 15:34:15 +0100
Message-ID: <20220218143416.34475-3-roger.pau@citrix.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220218143416.34475-1-roger.pau@citrix.com>
References: <20220218143416.34475-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO4P123CA0299.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:196::16) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: fb99fa3f-f0f6-4ab6-9992-08d9f2ebc6b8
X-MS-TrafficTypeDiagnostic: DS7PR03MB5543:EE_
X-Microsoft-Antispam-PRVS: <DS7PR03MB55434A4956237A22A3AD4C308F379@DS7PR03MB5543.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4303;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: afrksBiQhL2DSkJ+wcpQZ6SYNWJCdbFz2QXClNnywRbQt3SDSU8DqUJOMt4xAg84JocBim3vzsNlsE9hQmQ+ibaxOBGC1NjJr2X4+hO5F7jEdx+MbUOTxqn8bODZQnHPdq3OWbkL6IEA3dAzaCLUhBFRqC6Ip3tSaKXnXm7x+T7f+CxRx9RCwnUR4mJ90L+6CwUtMflYPUAyoKIV/7SJ71uCezF87vEKcrd2yQ3rL8iHI64gZ3ZTDU67QtxkFHMvS1rI/FWm5FXRUgsYKaCOKauT93j+ZLIJnuSioKitLUEMuzZ8w8R8/YF8tIxMx8It7Pw3lMECPgrZ7uTLdIrml4TaRUrD0d4D+4PMN/BfdoIu2iq4jgnAWImyQTV3JNmGg4TqFPe82iCFo9188mZ2ZMktm/1iOkEmwuGBvOMcxOGWl4b2K0JojEOowMA0L3fUMI1Rprg5YI+zdnqMFbrEiRfJlFDmymwgY9WGs/WeLj1fNd181WFZLfz+I1Yzq14sYyg5FdXLQtgJNrIK53SUCQcG/yxaqB/YCUeM1LycAxUt5J6v7hZzoYS8IIVOlnBRVE4vve7Dc8bKzKKuKTRfrrhsS3S/5BPq2dIHn3EfaRtEFnl+WFjsAeO4lDsUUwKt732q3Efwm251ZH5tsFuJWw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(86362001)(6512007)(36756003)(82960400001)(8936002)(26005)(1076003)(6486002)(8676002)(6666004)(6916009)(2616005)(66946007)(5660300002)(2906002)(54906003)(66476007)(316002)(66556008)(83380400001)(4326008)(508600001)(6506007)(186003)(38100700002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TWtnRWZhZFM1TEJ6SS9YcHdFcGNINW9pMk42QUN5bjRCTXI3Z2lTTGZDWnlm?=
 =?utf-8?B?TmF3aHRSaUdYazkxa055L1RSb25xK0dlL0VqUE1PN2I5aFF0YTNRb0I4b0U1?=
 =?utf-8?B?dm1UcVVHK3lXUVphd2FmQ1RGUVJJZ2xEU0x4dGFWOXpHMEZoUHM5WXFuWFRy?=
 =?utf-8?B?dDBIYU55L0JPWlRGbmxscVljWVArWEZzdnM4dXcyS0I0dTVDUllza0o4Qy9E?=
 =?utf-8?B?clMxOGFwUnZ6d2d5cjd5REd0MzFPcjhZQnJRZWkyTVcvNnk4Z2dNV2o4OWo0?=
 =?utf-8?B?Rmh3YUNJZGVKeGljTnVWZ3RjdmtXdFg5SG1ibnRkcVhodFNDKzZiVlE1ZFd5?=
 =?utf-8?B?azN5N2t1YkNvUnNsa0NyODdJWCtDUVVPM1hkMW0rMTQzL0tvNERONnptajdL?=
 =?utf-8?B?RExHSTV6YTZZeDRSSitHa1BTQktGK2F3YjV6ckFSTlNaMi9QdXA1MndjUjZk?=
 =?utf-8?B?QjAwVHFwOWZNa1d2elJzdmdodk5PMUVvYi9wcjcwekwxY1RJbEZITFoyRDln?=
 =?utf-8?B?Ry9hT25XWlY3eTl0eGJVdzd6Mk05QkZ1aGUwZWZUaDlveGRBa0liYzNTclVh?=
 =?utf-8?B?TFZOdVI0c2pGa3l4L0FqWkZnWmFQMVg1amhSb0k3Q3pyM3NVcFA4TlRxVnZH?=
 =?utf-8?B?UWlTb2l1eWtvZDV5UWs1aUhMY0ZxRTg1NDVONUowQnIzOXc2VEQzZ3NuK3gx?=
 =?utf-8?B?eHozNUljMXVLQWIxak5FbjlwZW1aL2xRSVk1V3JyL0w2amt1NzUxZmt0MWZP?=
 =?utf-8?B?K1FFdFFrRHVnNTNDL0J0ZTZiQS9hSkVmaWVXancrMWZDL083ZkNWOU9uTkh0?=
 =?utf-8?B?ejZyb0RQQzQyTjYxL2UxN1pkODg3aVZFVnM5OFdybmtBaFZsZ2gzVzRyRDVR?=
 =?utf-8?B?WmdzbFJBUlRDZ1lyWndhdC9KV0t5a2NLNjQ3Nzgrc1Fsb0RBVVFqSTVvZzVN?=
 =?utf-8?B?MkVqdktiZ2EvTXhXYWpWUTZYc05zZ2dSdUFJbGk0cnpnMnJqekpaUXBXK1NM?=
 =?utf-8?B?UXRNMlhvM3M0c0hCeGRseEVlNWNYeWg2SUFpTG11WXNxaTgwbFZZT0NUZERF?=
 =?utf-8?B?L2NhaVlxOWxqVE9mb3V5Qk1JSXpTK01DZkJzejh5RnF4VnNUU0NQVFZmV1NF?=
 =?utf-8?B?dXJHYkZOWUM1TGVzbE5mK3BRdDZhWEM4c1g2VTljK1JCblIwc3Vtb1pFYjI1?=
 =?utf-8?B?M0tINDZsMnlLVXF3eS9xMXlGN0NVR0dZREFiUlhaLzFyWVdsNFRIMVZWZnZ0?=
 =?utf-8?B?L3hYTmhQRC9KNFl4M3c2NDNEOTUzYWp3MFEzT0F1N1hCUkE2amJwdG9IQi9y?=
 =?utf-8?B?MlVIeGhtMDNxNnlYWmJHQnFPMGxvT1ZVNzduU3FXUFFLR2VocnNNVWRLM0pW?=
 =?utf-8?B?UmhhYTZ3OXNCQ0NKeVY5b2UyTi9GT1lxQ3JqN3FtMXpPeHI0eGJOK0VoeXN4?=
 =?utf-8?B?RnVhbTN5TEpZamM3bHRleEhrSmRRK3A1NldHL1hWamVaeDBNUUhyOUhlNUZK?=
 =?utf-8?B?OCtSUGpTanU2Vk9ZMkZ3azN6YzNCdVBHMS83WXFzUEcxTk1LZkZodUVoTE5o?=
 =?utf-8?B?Tkw0VVdPTGx1NHBYWkhiRndFb3E5a01idzg3Tk4yNzdROEZ5Mis1eGtTeDBp?=
 =?utf-8?B?K0tqTUtnUVVBTEFPdmF6YllhWThheGovQ3krdVFuV1lPanRnOURIck9BRXVL?=
 =?utf-8?B?MGp0VUxaR3VsU296SkVRN2Zlc1dtK2NDUEFXWjl4QTVTeVp4cmNZWVBmdTcw?=
 =?utf-8?B?cW8vMTEyeXdHUG5qaXZSUzl5eWJhS3F2cHoyVlJVc053Y21yejQwNCtOa2NX?=
 =?utf-8?B?UU51eUp0N2hkNm5FajNSNWVoT1VRQ2JYa2hESE14bHg5RGlZSGhrNVVseitL?=
 =?utf-8?B?SSsxRE9UZUlnYzQrSFJxWHlCME1ERG9YRElyN3VnUjhiUzBDTEpqWXpXQTMr?=
 =?utf-8?B?R2RRK01mem0wclJFQmEvM1MyTy82czQ4bkZuSVJBTnhVQXNvaEM2MWltMmNR?=
 =?utf-8?B?ZHJoclM2UHdOMC9DNVlpdDhNZ3dydGJFM2tMYWFRNk1YNFBWNDBtTFNFTlJE?=
 =?utf-8?B?R080ZXdMZmFUMnZwQmhLblczRVc1SmxzeGVDOTFCRWJzWDhhNDd5SWFsMUIv?=
 =?utf-8?B?TEI5a29SL3VsdFdPajZ0RzQrM1plcmIrQ3oydkVDd0RvOTI5MDdmQWlTeUp0?=
 =?utf-8?Q?IKq6xAPMDC3jJRlBxxrCb7M=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: fb99fa3f-f0f6-4ab6-9992-08d9f2ebc6b8
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Feb 2022 14:34:31.6421
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IJpOkLrqsXkA6RLDZT+oEdkAjcvwZ7v4mVJTBmDqS4LrebmlAU3dJqfW5Qw5FkdLCS/2iufT62x+xbFJtMFXhQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5543
X-OriginatorOrg: citrix.com

Detect whether the compiler supports clang retpoline option and enable
by default if available, just like it's done for gcc.

Note clang already disables jump tables when retpoline is enabled, so
there's no need to also pass the fno-jump-tables parameter. Also clang
already passes the return address on a register always on amd64, so
there's no need for any equivalent mindirect-branch-register
parameter.

Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
 xen/arch/x86/Kconfig | 4 +++-
 xen/arch/x86/arch.mk | 3 +++
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig
index a1a90da4fc..f8dca4dc85 100644
--- a/xen/arch/x86/Kconfig
+++ b/xen/arch/x86/Kconfig
@@ -33,7 +33,9 @@ config ARCH_DEFCONFIG
 	default "arch/x86/configs/x86_64_defconfig"
 
 config CC_INDIRECT_THUNK
-	def_bool $(cc-option,-mindirect-branch-register)
+	def_bool $(cc-option,-mindirect-branch-register) || \
+	         $(cc-option,-mretpoline-external-thunk)
+
 
 config INDIRECT_THUNK
 	def_bool y
diff --git a/xen/arch/x86/arch.mk b/xen/arch/x86/arch.mk
index 6388b1d93f..066d749ba0 100644
--- a/xen/arch/x86/arch.mk
+++ b/xen/arch/x86/arch.mk
@@ -47,6 +47,9 @@ ifeq ($(CONFIG_INDIRECT_THUNK),y)
 CFLAGS-$(CONFIG_CC_IS_GCC) += -mindirect-branch=thunk-extern
 CFLAGS-$(CONFIG_CC_IS_GCC) += -mindirect-branch-register
 CFLAGS-$(CONFIG_CC_IS_GCC) += -fno-jump-tables
+
+# Enable clang retpoline support if available.
+CFLAGS-$(CONFIG_CC_IS_CLANG) += -mretpoline-external-thunk
 endif
 
 # If supported by the compiler, reduce stack alignment to 8 bytes. But allow
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Fri Feb 18 14:34:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 18 Feb 2022 14:34:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275509.471414 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL4LA-0008T2-G0; Fri, 18 Feb 2022 14:34:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275509.471414; Fri, 18 Feb 2022 14:34:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL4LA-0008Sv-Bo; Fri, 18 Feb 2022 14:34:32 +0000
Received: by outflank-mailman (input) for mailman id 275509;
 Fri, 18 Feb 2022 14:34:30 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=YtLv=TB=citrix.com=prvs=0411da6ea=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nL4L8-0008Sp-3t
 for xen-devel@lists.xenproject.org; Fri, 18 Feb 2022 14:34:30 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id dee5d1c3-90c7-11ec-8723-dd0c611c5f35;
 Fri, 18 Feb 2022 15:34:26 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dee5d1c3-90c7-11ec-8723-dd0c611c5f35
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645194866;
  h=from:to:cc:subject:date:message-id:
   content-transfer-encoding:mime-version;
  bh=rCaw4YlAdsLa1oDS6xBVJ/i1Wan12JGK7S2VvZt37aE=;
  b=BDbfFX7nYK/+5mm6YquIH+tsGDjxQLv0hAkU8+U54A09oYhCvsosu9q2
   jEhXlnTrzZC6IEMRbE4eVtaS0WCziYUVUiHAZ1nDFe6bZItXMsvkl6QKv
   jjXv5jyzgKJLKa7JYlPI/xdwMpWoRbrF1BFJX6qpsJoBpFiXUDEvvwsbR
   s=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 66766300
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:2KOZqaC6ZY4f0BVW/xbjw5YqxClBgxIJ4kV8jS/XYbTApDhzhmYFm
 mFOUG6Cb/aDZDGhfosgbI6y8RtTscTdzNA3QQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YhFWeIdA970Ug5w7Rg0tYy6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPgow
 vUXipWWZz4lJ5Ln2+AQTRtiNX9HaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguw5K8bmJsUHs2xIxjDFF/c2B5vERs0m4PcGgmhu2JsWRZ4yY
 eIGVCVNawucTCdQJ2YODbxmsNj3vUjGJmgwRFW9+vNsvjm7IBZK+LrwNNvYfPSaSMMTmVyXz
 krd5HjwCBweMN2ZyBKG/2iqi+uJmjn0MKoNEJWo+/gsh0ecrkQDBRtTWValrP2Rjk+lR8kZO
 0ES4jApr6U56AqsVNaVdx+yrWOAvxUcc8FNCOB84waIopc4+C7AWDJCFGQYLoV76olmHlTGy
 2NlgfuwDxw1j7SzZ0uR74i/7je/JyovCzE7MHpsoRQ+3/Hvp4Q6jxTqR9llEbKogtCdJQwc0
 wxmvwBl2exN0JdjO7GTuAme3mny/sShohsdu12PNl9J+D+Vc2JMi2aAzVHApchNI4+CJrVql
 ChVwpPOhAzi4HzkqcBsfAnvNO34jxpmGGeF6bKKI3XH3238k5JEVdoNiAyS3G8zbq45lcbBO
 Sc/Qz956p5JJ2eNZqRqeY+3AMlC5fG+SYm8DKyMP4YQO8IZmOq7EMdGPB/4M4fFyhVErE3CE
 c3DLZbE4YgyUsyLMwZat89CiOR2l0jSNEvYRIzhzgTP7FZtTCX9dFvxC3PXNrpRxPrd+G39q
 o8DX+PXm0Q3eLCvOUH/rN9MRW3m2FBmXPgaXeQMLbXdSuencUl8Y8LsLUQJIdI9xP0Nzr+Sl
 px/M2cBoGfCabT8AVziQlhoaa/1XIY5qnQ+PCc2Ok2v1WRlaoGqhJrzvbNuFVX73ISPFcJJc
 sQ=
IronPort-HdrOrdr: A9a23:lr7cu6+R4JHpeDkkK6Buk+DcI+orL9Y04lQ7vn2ZLiYlFfBw9v
 re+MjzsCWetN9/Yh0dcLy7V5VoIkm9yXcW2+cs1N6ZNWGN1VdAR7sC0aLShxHmBi3i5qp8+M
 5bAs1D4QTLfDtHZBDBkWuFL+o=
X-IronPort-AV: E=Sophos;i="5.88,379,1635220800"; 
   d="scan'208";a="66766300"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=eVma+ykpGVbM3/7CYYu3HwG2rk5MxEV72z4pTsyHvdfz9azh+VrtZpiwU5/hAdXWopC96Jh3Gz9ln2nCyU0+imNiCJh4pi2wkSJ76n1rq3itnwsDt4d5QHmwn5zBtlNLygTuWQB+MruJAz5xiPsUCDJ0fEBtqHb9V7RJf8gquMhmF7Kk5W1JLkdGRyJAQEvMtl8FyxP2P60NZseoMFog2B31e0TrprAZdiCSKP11KBE+s/PnrabE0Vc/KYJhuta+NSEKShLFpLZPErbz9tXbX8XCF8QP9NrrhZ3ees2a9+3JSpYBvN1LrYhLnen+ibOXgtPuB9OZEzJ9jaxkDZEpDw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=V69HkAqfmLCDxeKC5CYpv9zauxv4VeWcFtmi3X1p5is=;
 b=gkoqpGgUQxM5JIPQWYZQo4cs2T3Q61KobCt/ennoCiV9yFe9aO2XT8o7BSrHRFxXzi9BtOxKOql1krZka8DS7Mb952HNCwyoEYlA0mUV2FG2NkxU7Adu7qD4BZLoIc1VK1fgYu9Pin8uvgwRsgVr7ruJvT2iA6zOXgZcEtKXFEdoRyPx006F5+cHtOWJveGjeVacjoXo6vgNrFceliSyamK0Bu2/xS0vo42TNvhAe2LVkRVMMNoErSrNVLOT0Lj9vf1Hwre4vQuZJZusQZ4eRSoul6EtJQKtO1SDBSnLaleCMCZ23VcQktHSqXVVBuhrs1G0m6/inMqCThWMlqcpSw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=V69HkAqfmLCDxeKC5CYpv9zauxv4VeWcFtmi3X1p5is=;
 b=JEZtaXQrJvs5Nre0nUrPdoI9aCfwDcOA8SmPApqT/vcRkZnfATcZOGGOg5bt5tWy21L1OgE3/8zcKDLNxnYmlC8i2RCXVDh1GkGs3S5qLZZxrMLVoHja+MpZHdBSCDy9bUKH41IP3oiwHSI9MiKwyeXrhkiuJOifT3bsgkY8KrU=
From: Roger Pau Monne <roger.pau@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Roger Pau Monne <roger.pau@citrix.com>, Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>, George
 Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>, Stefano
 Stabellini <sstabellini@kernel.org>
Subject: [PATCH v3 0/3] retpoline: add clang support + Kconfig selectable
Date: Fri, 18 Feb 2022 15:34:13 +0100
Message-ID: <20220218143416.34475-1-roger.pau@citrix.com>
X-Mailer: git-send-email 2.34.1
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO4P123CA0315.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:197::14) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f27da68b-e03e-4d9e-10bc-08d9f2ebc124
X-MS-TrafficTypeDiagnostic: DS7PR03MB5543:EE_
X-Microsoft-Antispam-PRVS: <DS7PR03MB5543A007C79D7EEFBE30ABA98F379@DS7PR03MB5543.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: UUhF5yiT3j3FZylfYK0WplX8ntoGCPg5TnKnnlQMDsPk4d5Ab3Pb6vuBJg4FgJ/GM/onaI61spN4RWaV9EwvsjKlIsKjWY/rMUTUQyi+9Qx1EoPZ9MxRTZ0GFTykh4b69Z/ky7h7gFyFlixPhsaGxCtcvNzbpTALJTBcw/akA2q3TER2WqSjQ7u/19gqI6PcXVgeBB1ntafWOEx7Hz/gXRT+tvlf6uatnxUElub64dmnIp/MQQ7i4BDwML8E1iBu9Utusv6YtUHSZsQmPTiQvY+p+0R+g5OXw81y0GBAFbYi/FU8j8IwdfKH2HAn/+QbrAjViiu6/4ttxGwWqqsiytxQY+P8YCYrKUTffy8W3PkqkSSiUR8WsJ1I4L6fwXwTStv2SqYMuI9YHZLxKCQlTyW7Fio5+lqD2Ma+YIeEE49lqVLE1xBI7I0P477KPC88kwKCYJpYj7D/v3TP1Edg/UB2eJlde1/AYtpjkuT7SuHF2I+CQX8UZo9BEcWucecZ7jAaRGXfshq7H9T0zSYsnyJNcsVnd3+oR27TZ0/hYVWItALWNBPBAqcPFIzEMZTHLqI3389Hmb7ysVtVQBXAcRslshSBW3USuYScJEpuT9uUW6IaCt3zqz8JeMKjPzirvSQwCz1maCgpd9pNc1cRqQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(86362001)(6512007)(36756003)(82960400001)(8936002)(26005)(1076003)(6486002)(8676002)(6666004)(6916009)(2616005)(66946007)(5660300002)(2906002)(54906003)(66476007)(316002)(66556008)(83380400001)(4326008)(4744005)(508600001)(6506007)(186003)(38100700002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZzF6NVNKbng2TWZLT3hoNkh4TzY2bHd6OEVXNTYyUnBFRk1NN0lpN3N1VUti?=
 =?utf-8?B?Wmxva2pHOEcvVEV2SkVwMy82NEltUDhxQXJjK3lFWWdEcGtFcURsOHUxQy9l?=
 =?utf-8?B?TVNMUmtkRVh0L3A3YThYaUFldklocXJQUnhmM3lFVzJ4S3NTV0hRWTJIWEtH?=
 =?utf-8?B?UkFUckxXVWhXOEl4d1N5THZPeVNBNkJvS1haeTI3bTBaLy9xTkFrZjJwZ01u?=
 =?utf-8?B?UW5SUFVnUU5rVzU4NGQ5VFprMlJCRndvKzdoV1VGTmVFVVNaRTMzTWNOQnI5?=
 =?utf-8?B?Z0VRZmpZSHBvVVNHZnhERGRTWHhMSk5vNmtnWkZvb1RiVWVGWU5QMzVNVHBD?=
 =?utf-8?B?T0VoeHRrZXJRcStJMVV3VitCQXk1dlN2bkhkcklBeTJJOHgyMTRlWjUyWmN5?=
 =?utf-8?B?dEZ0Mng2cm1sc1BtR1lYMmppeVhhV2orY3VLeUNWYnMvVVFlZDRSS2x1TERZ?=
 =?utf-8?B?bmZ4cE96RTBYdXNOZit6cnFSWHdSZkxSd1FKenZnUkU4NEZDckl3bWM0VElv?=
 =?utf-8?B?Q3lad0w0cnc2WjNMVjZqamg5bjMvUkRBTW5WTW1sanM1YWtIbzdjRVAyOGVI?=
 =?utf-8?B?cVlFbzB6ZWVHNXpQYmNUUm1XdStXSUh6ZW5ZQUhaNTlIUHpDdkNQeXM0Z1dr?=
 =?utf-8?B?Ykx2aU9xdys2V21oWUM4clZsOVVybjhuNkw5bkJ0aUt0MDRDTFd5ajhnVWV6?=
 =?utf-8?B?UnpRZ0FIcW5RWU9yNW54UEpwa0NnclRZVGxLZEpidVRHdVdKOVZ1aHR4SnBU?=
 =?utf-8?B?YTNFVXRYOU54OVZXRUNoZmFObWp6SmVTcFRqYVkycjY3bmNaNm8xQUVHSzRi?=
 =?utf-8?B?ajZXWXFHdjZnNjBrZDhQQU1ScHI0cEE4WDZGc0VXSWRIeHl2WW5HbEI1VEc0?=
 =?utf-8?B?alFwZVU0WUJrOVl3VVpIM2VKTTdrUHdyNDMydm9CMmdIY3h4dUhtcFZJQTZI?=
 =?utf-8?B?N2RtVjF0WHZBSzBleThCUE1zMERuQlVqaDhhN29aZkxlSWl4MDJRbDJ6V3Z3?=
 =?utf-8?B?TUZpYUN0clN5VWFFKzlITi9NQWJ4M3hERjJkN0JYVkFPM3BnTXpPNnlxM002?=
 =?utf-8?B?ZHhWTE4rYUgxN2w0REZSb2RWenZtT1Z1QWIwVHZrR1JZL0ZCWXF5c1dVcDMz?=
 =?utf-8?B?eXZWcjdwaC9zdVp3MzRXSXRQKy94M3Fyc1ZNZW50OGd5b2cxSFNDZk9ENVRk?=
 =?utf-8?B?RFRJS3I0UTZLaFBLOHdmNERPcmVsUWpVWEZ0QjFnZlpZTlgvWGJZVkZUYXRB?=
 =?utf-8?B?YnhDSnNXUVVITmhBcXZFbFFnNmQ4aTJ5TDJrS0xzSUN3bFMzUHIydlZ3VnBh?=
 =?utf-8?B?T3NCSFRVaFV5MVhMejVlblNwNzJ0NHVqSytMTVowYzNEaytjM2FRVW11aDlT?=
 =?utf-8?B?WlhYeHB3Y2ZQV0s0MXFhcUVWSWtydEU3R09kMThlb3VTYnJ0Y05sRkM3aGJJ?=
 =?utf-8?B?SEYyNXFSMklCWElnRW94YmNrek9VYm1zcE1ldGdZbzV1YjJCczR3bkVtcmsy?=
 =?utf-8?B?QTRIR29yU2NKUkdTMGp3cWVNQ21xYmhPS0lSR3d1VGJhaDRYZ1h2MmVrUVBu?=
 =?utf-8?B?R3BJWFdXeDBRc0hiMkZwaXd0by9KK0IzdnU3bE4wRm4xSUZTRXpnM202WVNX?=
 =?utf-8?B?cW9SbE43VVNGUmpXd1draUl1S1ZScnpoWUd0UjZzYzhNUnA3UlJrYWhDdmFv?=
 =?utf-8?B?NExjTkI2TmJZNHU3NFZmTnhyS2N3RXlNb2VJVEYwQnVDUWFKZG1Ld0RTUEdE?=
 =?utf-8?B?VUVtZE53eTh4MmkvQUtlZUtyUkFUOXJsYWxZOFB2MlByK016VFQ1eTA3Q243?=
 =?utf-8?B?ekVrMDBVb1NiZHhISXJma2tzcGxwV245a3FLem95aENPdmhQMEM0dUVSV3gw?=
 =?utf-8?B?aG9rOVRCR0FJNVlISW1GYkRZbjRPMExKNGtwbS9tRXo1RVBLeHAxTHAxY3lZ?=
 =?utf-8?B?SnppL0JZNytGUFNVeGtvMk1KaVJNUzZSZnRneHdmbHJKSHpSUmtKcGZ4NlZj?=
 =?utf-8?B?OVQrQzlET3pCbTJUejFkY1loZXhVb1JFWjhKUi9QY1N2dkhQMzhkRkROSnRH?=
 =?utf-8?B?UzIzcXFsM1FzVEtrNXdFSW1DWG1ROEhrZ2hWcS9Sb0dFUVBYelV6TXpadlFw?=
 =?utf-8?B?b1JYS0p1S0ZEbGc1SnpvZ0lsRVMyYXJOU2NrVEM1YVE5LzhGbWhZUUMzRGZC?=
 =?utf-8?Q?f4lqGW29018ggsgHhPJDdpM=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f27da68b-e03e-4d9e-10bc-08d9f2ebc124
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Feb 2022 14:34:22.2488
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1MusYxJBadxZuovV+tf4glQiUUUhQxA4XwaNqsBf886B56cF70juO6yQ7SaKxximZ6Vi1tdShXvnZJG/zuz37A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5543
X-OriginatorOrg: citrix.com

Hello,

The following series adds retpoline support for clang builds, and also
allows the user to select whether to enable retpoline support at build
time via a new Kconfig option.

I've tried adding a suitable description to the Kconfig option, but I'm
sure there's room for improvement.

Thanks, Roger.

Roger Pau Monne (3):
  x86/retpoline: split retpoline compiler support into separate option
  x86/clang: add retpoline support
  x86/Kconfig: introduce option to select retpoline usage

 xen/arch/x86/Kconfig |  5 +++--
 xen/arch/x86/arch.mk | 13 +++++++++----
 xen/common/Kconfig   | 14 ++++++++++++++
 3 files changed, 26 insertions(+), 6 deletions(-)

-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Fri Feb 18 14:35:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 18 Feb 2022 14:35:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275512.471446 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL4LS-00011S-CF; Fri, 18 Feb 2022 14:34:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275512.471446; Fri, 18 Feb 2022 14:34:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL4LS-00011J-8z; Fri, 18 Feb 2022 14:34:50 +0000
Received: by outflank-mailman (input) for mailman id 275512;
 Fri, 18 Feb 2022 14:34:48 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=YtLv=TB=citrix.com=prvs=0411da6ea=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nL4LQ-0008Sp-Ey
 for xen-devel@lists.xenproject.org; Fri, 18 Feb 2022 14:34:48 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id eb23284e-90c7-11ec-8723-dd0c611c5f35;
 Fri, 18 Feb 2022 15:34:47 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: eb23284e-90c7-11ec-8723-dd0c611c5f35
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645194887;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:content-transfer-encoding:mime-version;
  bh=NkHFymHkeKgIK++83ZytrpXL1OQuo5Mz+mG7P3n6lX8=;
  b=eYr40jb/Q4yoOV2Aiqy7dZ+RgYsjMOt+5L6kFyJFuKN7FWgMv1q0bHkS
   yBNY1LrQYpsYiMWod/LOclTA5IYH9ch/67hggz4pG9lA7pyS11A/q18UY
   hJqGUO85ti+kvVEh3CMsZrqEogGuSHhMikiRvVxtwRgAt0OOkgI47zd9c
   I=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 66766320
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:2ooFoKlhSxozIqs+EIFfKXno5gy+JkRdPkR7XQ2eYbSJt1+Wr1Gzt
 xJKWj/VPfeDZmHwcoh0Ot7i/E4AsMfUn95mTQdkrng2HiMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2UILd9IR2NYy24DjWlPV4
 7senuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR
 v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ
 NtxWZOYcl4HYYLntL4ndUdCPyslPqx85r/7GC3q2SCT5xWun3rExvxvCAc9PJEC+/YxCmZLn
 RAaAGlTNFbZ3bvwme/lDLk37iggBJCD0Ic3oHZvwCufFf87aZvCX7/L9ZlT2zJYasVmQ6iBO
 ZRCM2IHgBLoXC1RAhQFI9UEntiv2VT1SA1KkQu2qv9ii4TU5FMoi+W8WDbPQfSIWMFUk0Cwt
 m/AuWPjDXkyL8eDwDCI9natgO7nni7hXo8WUrqi+ZZCn1m71mEVThoMWjOTsfS/z0KzRd9bA
 0gV4TY167g/8lSxSdvwVAH+p2SL1jYeUddNF+wx6CmW17HZpQ2eAwA5oiVpMYJ88pVsHHpzi
 wHPz4iB6SFTXKO9ciuzqZi/gWmIH3YPAWVZZi4+Uws52oy2yG0stS7nQtFmGa+zq9T6HzDs3
 jyHxBQDa6UvYd0jjPviow2e6964jt2QF1NuuF2LNo6wxl4hPOaYi5qUBU83BBqqBKKQVRG/s
 XcNgKByB8heXMjWxERhrAjgdYxFBspp0hWA0DaD/LF7rlxBHkJPm6gJsVmSw28zb645lcfBO
 hO7hO+ozMY70IGWRaF2eZmtLM8h0LLtE9/oPtiNMIYTO8ItLF7bong0DaJ144wLuBF9+U3YE
 c3GGftA8F5AUfg3pNZIb7x1PUAXKtAWmjqIGMGTI+WP2ruCfn+FIYrpw3PVBt3VGJis+V2Pm
 /4GbpPi40wGDIXWP3mGmaZOfAtiBSVqWvjLRzl/K7frzvxOQzp6VZc8ANoJJuRYokiivr2Wp
 irkAhcAkjISRxTvcG23V5yqU5u2Nb5XpnMnJy08e1Gu3nkoe4G066kDMZAweNEaGCZLl5aYk
 9Ftlx28P8ly
IronPort-HdrOrdr: A9a23:/8CnO6M7cd3fvcBcT1v155DYdb4zR+YMi2TDiHoedfUFSKOlfp
 6V8MjztSWVtN4QMEtQ/uxoX5PwPk80lKQFnbX5WI3CYOCIghrQEGgP1/qG/9SkIVyFygc/79
 YRT0EdMqyJMbESt6+Ti2PUYrVQouVvsprY+Ns2p00dPD2CAJsQiTuRZDzrdnGfE2J9dOQE/d
 enl4B6jgvlXU5SQtWwB3EDUeSGj9rXlKj+aRpDIxI88gGBgR6h9ba/SnGjr1sjegIK5Y1n3X
 nOkgT/6Knmm/anyiXE32uWy5hNgtPuxvZKGcTJoMkILTfHjBquee1aKvC/lQFwhNvqxEchkd
 HKrRtlF8Nv60nJdmXwmhfp0xmI6kdm11bSjXujxVfzq83wQzw3T+Bbg5hCTxff4008+Plhza
 NixQuixttqJCKFuB64y8nDVhlsmEbxi2Eli/Qvg3tWVpZbQKNNrLYY4FheHP47bWzHAbgcYa
 pT5fznlbRrmQvwVQGdgoAv+q3iYp0LJGbHfqBY0fbllwS/nxhCvj0lLYIk7zA9HakGOut5Dt
 L/Q9NVfYF1P7wrhJ1GdZI8qLOMexfwqDL3QSqvyAfcZeo600ykke+C3Fxy3pDtRKA1
X-IronPort-AV: E=Sophos;i="5.88,379,1635220800"; 
   d="scan'208";a="66766320"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=emWtRwsxU7T1YMq73bIaGzJPvnSVff4MgVOJ12ttDX0iLJUiwMGEIxm/dJhkSkYiDgPpFjLcSp+T5jRrb5B1eLXywsKHcl/L698FajttlBMKCP4Jhhpp7JYaqpluzqd2FY2BIXAgKs6An24etLVZlJdP+ql6whfZRcxkE0yNp9LYZDtgiPIE8AiKEsEetgimCULRXFkxfNMz6Vwsrd6bhwgxm5ecHho+z6JjnrbmJ4H6Lhx11uHKHE37k9lgW3tm6u5Lbw9u1CCjBUBG3LeDfAxv2lBVAEYLleziAOWpmVH1m3K6mRNuXmZjJ6OAa1v5FkdabRN9ssugkEkygDJMMw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=wycz5DnGVIywU467a7gmql8uL29FYGmIDOKp8zvRFgg=;
 b=CWzoWqGcBUOfARhVL9hJFFlgYUq0hlf7yf27x4m11i/0Z8IIevFDMnwds7BkkkFtHwO78XCBKJQTKvsY4gaY0Rpt9bPOrLSq4gcNMSSp8sstAmqXcStNdMCASWpdG9Mbugcp1lJ8YMdR+u9MkdSRIR/psl6eaJLWFPD4Xi49a+qiWw2LuoN8Z8sgB84Vpe/Eh/cu93VYETdDdPwj82EhlCofpsZ8CSPl5LKKi6D+j2yb1t5cWZbF4i685b7YhaEj7fW5+G59yRUQGP+c9V3/zkF0CNvBK/C16jgdIBRxHQ+ovWEZmf0MBth24RPG3EmRbvL6e2ByleJka+3cHUBG+Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=wycz5DnGVIywU467a7gmql8uL29FYGmIDOKp8zvRFgg=;
 b=o30pPP/T9AT+7fPAjAGOnK9z4Ku7naPI+SNVlxoapVk5buIFfAyn3zs3ozLyuJZJqKqI73BzYVLNmmLOaR7youE5e8g4fsfTIjCKDnZpuZ6LKZJXHO6n1Bb8fkYUyDGesa2U6VKljquO1A7T2r170xQnolMo8v9aVZ+wJKjR8fM=
From: Roger Pau Monne <roger.pau@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Roger Pau Monne <roger.pau@citrix.com>, Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>, "George
 Dunlap" <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>
Subject: [PATCH v3 3/3] x86/Kconfig: introduce option to select retpoline usage
Date: Fri, 18 Feb 2022 15:34:16 +0100
Message-ID: <20220218143416.34475-4-roger.pau@citrix.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220218143416.34475-1-roger.pau@citrix.com>
References: <20220218143416.34475-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO4P123CA0260.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:194::13) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 53b7cb76-8d17-4e83-7eae-08d9f2ebc9a5
X-MS-TrafficTypeDiagnostic: DS7PR03MB5543:EE_
X-Microsoft-Antispam-PRVS: <DS7PR03MB554304D47216A2FD6ED186958F379@DS7PR03MB5543.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3968;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: TyQkV81lnCAkpdI5B+Z8R7wYQFiYppun/JrNeq+P67tgyWk0Z9yCPiciyvIBy+UjbbeacuBrFjUrKkcIkNpy32gWNJk9vswWsu+uZ2Bfa5PZfBC/DAItgZeh4YwzhoUayYY2WnLPrC8a2cOAPKAdBdCWhJ9HMUuqO6u5I6qx0LAYYnt0dW+rGKdZ9dnAlNWWmC+ZKCwdshaJ36GNhfN+HKnPOHK94YIrsN+klxfEYJaVjOUg6fJl6xK6t1s+EXCyLt/xH9QAFAH7ghpZYnnArokq1rNHPj8ymTg3xq5gZa8ktdWUQ75cTB/FLVpumXNauAjxYGCxzEwSEqDFKhpmFYBe0AtFgkw+9AN9enm/U3SsmkATUDNtvXu277KmeNgSWBQW9YMcEg1A+33YQnQ/W58LlH7A9HkSIVh/kI2jTELeo4i4zY6i2b1r01nwRGbDjOUuWjG7wkNmPXWkczvaX5UnHs6jl9Re1PTCjibVfIxewVrGFyg7/+8vX7Lnamt77ENyZioE9/IiCsMVPqIWOq2v2Gunx+cz0Cp9oH8Ll+b+VjF3cV08g82k4XKew8hIEGZOzY6ZgoRNmFe8u29mKYuh1izvBuYcL2HZdEeJXwmjy8DV+XYRUmo5nt/SOaihYyaUKr6Yc5gzH1RThvQeYQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(86362001)(6512007)(36756003)(82960400001)(8936002)(26005)(1076003)(6486002)(8676002)(6666004)(6916009)(2616005)(66946007)(5660300002)(2906002)(54906003)(66476007)(316002)(66556008)(83380400001)(4326008)(508600001)(6506007)(186003)(38100700002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Tjg1b3orS1lMSGZ4RzBuRFg3amNuZXVxZWRZYlJ2VXpWS2xKTDZMRGI0aFhs?=
 =?utf-8?B?MGNXMHNDY0pFYi9kRUNhUXprV1k5U0VPUkxiTHpTbUlLelUvbHl5MUdaKysy?=
 =?utf-8?B?YnFWSWIvZTdFNkl5SjVodHI2dmFRYjVmVWEvUDBZWEIxbGpXZ05HMCtMSVpQ?=
 =?utf-8?B?aG9zT0lwMmNyRDY3K252bW9lOW1ZN3IzQjJGN1k3L2FEbXNvV1JEbmtmU1Zn?=
 =?utf-8?B?dXdUa25XaVRVMmxsRTQ1NUMxREphQTBvZVZZT3VLSk9BNG9jenVQTlQxU0xY?=
 =?utf-8?B?NFQ0NGhqenowUHhva1gvUE84dDJkbk1URlNmRVJ0dG1vQjhCNFlLTEdocmkv?=
 =?utf-8?B?MnJlWW9jSGphNVl2ZlI0eDZmYXVId0t1ODdTakFtYVNkcS81M3VqQi9pcTRq?=
 =?utf-8?B?Nm92c0V1YUdZTld2TGt1OXk5SklPRmUrVHZmOGpyd3BCRkVQQW5XRjdjeEtp?=
 =?utf-8?B?MDY5amV2RzEyQmJ6QkxpUEt0TXdvcU1lWWNjQUR6VFRxMDlyNGV5c1JERzFj?=
 =?utf-8?B?Q050T0gxQ0lHdmNhRFZrQVd3azZPd0dDWkNkWlIyK1pyWWh4VmpLSHJ2Q0RG?=
 =?utf-8?B?aUZxYmpZZlBmVkVZb2ZpQThIODBLRFA4ODQxelJUUldGcm15TENrNy9iZlNE?=
 =?utf-8?B?NWEvblpiSW5BSTBWM2JoN0IvQ0JWU0lOVDNEU3dTbWorMmRqcDE1bnBJNktL?=
 =?utf-8?B?QjF2OEtEcFBxZ2F1NWlmWmpTWVpud2Q5YlVndU9kb3NjK0ROR29iNWFjT1NZ?=
 =?utf-8?B?TmlZM0lGYXZ0MGJ3aHRMSnVWUWRyRm5zZjlOV094eDE5MzA3ajVUeDhuYmlN?=
 =?utf-8?B?MGRyejN6UUdNMkJ0US80R1Jsb1QyWkpzVFN3aDNYR2JRdDVMNzE2UXdKb2FS?=
 =?utf-8?B?Z3dEZzJ3Ky9pQmVzTU4wZmkrL3NGTmpGUWhqMjIrVlVmTzVTdVh6T3lXRVdn?=
 =?utf-8?B?ZDFHQm9mdWR1VGFKVGNFZ3A3RGo1NlhFL2RPV2lkVGZJQzZxVmRNUkl6UjV1?=
 =?utf-8?B?cHp1c2ZDb2NKY3FqeU54TCtwZ0RWbUJKUlhTbzEvdU5iUGNoTWVVelYxeWdP?=
 =?utf-8?B?WWdMZVp4RFNwRlFBZHlHaGJpK1crOENiODI5VHBBeHdWYUczR0psK3QybGNE?=
 =?utf-8?B?UzNoclJ0VmRFVE4xQTRnWFdtU1d6d2svM2tVSHpCVTQxWjBCam8rUzYySEdr?=
 =?utf-8?B?MWdaYW5DTWtzSTEvSFltQ2w2UHIvam9BOVZoRUpOMWpkUGtrM1BpT1dPQTlW?=
 =?utf-8?B?UWExSEpSa3dpLzV4OXBBWXVFOVRMQzdaaGM2VmxmZ3hQR3lkUTlmRkZkWVgy?=
 =?utf-8?B?QStyRlRDdFFpOUZjeVZsb2lvSXJ5UXlNQWhTeUJKZmtYYk5Xc1dvMk80TUVK?=
 =?utf-8?B?MzhPRUVnd2dPdGlxMEJ6L0ZOakorZ3YwNGFUK0U4ZmI1UUpMK0JydWNGK0Zq?=
 =?utf-8?B?OC9BQ3F0aE9FRytJcTI3T0N1K2lTbVY2NlZiYjYrd3pKRVhySkRvRzE5amg2?=
 =?utf-8?B?OWNRQ1VWZFBzV2ZSS2VpQ2U3aE8xUDlpd2IzMTJSWFJUdFFScTl1bUVySlZk?=
 =?utf-8?B?eG1zdWRjeHQ2dHBDK2RKVzFpS2N3cHpmWnB6QmQydHRmYWhhMFdHekplTExk?=
 =?utf-8?B?VURuNmNIVzNJL1JUelViKzM4R1VXdE12S28wTm5iT2diM0RSc1YzVDNXNDl2?=
 =?utf-8?B?SkxrQnJiUmMwamlwS2M4Qy9RbUVyb2VhNDlvd3NYczByajA2NHpIenRBaStJ?=
 =?utf-8?B?dFVmajFQSlFLMG53REJnNDZnbWpBcWRyWmlXbi83WkcyQnpTNDg4LzVKS2lz?=
 =?utf-8?B?OXhhcXE2RlpvZmVzYk5tREduUDcvOVJGMzBqRGJjNWJoaXlNSCs2Ky9wM21X?=
 =?utf-8?B?c1JTRmlDVDJtN2h1OW1nSEZhbi9mbEFpVjBNOU1XYnVzRWpFNWZPQTZnZWc4?=
 =?utf-8?B?cXZBK3RaYkRkWEFMYnhWL3ZXU3NTdnRqZ3lZeEk1N0pVbEk2K3RLOGwzWWRM?=
 =?utf-8?B?dXVqWXlSUmo0MDk0ak14Y0pTUndxSEM3VyszMEQzeXlVcHc5a0RzWXNMY0NH?=
 =?utf-8?B?NFNKSDBzQndaZ1gwUXF3WlphWFFKMVlVRlJTUFJSR0ROM0laMkRwaFpFNHlr?=
 =?utf-8?B?ajJLYTEzdmpKcWYzV050c0NQdDlQTXZ2NldvdGhhOHVXM2VWVnZhU3hNczhR?=
 =?utf-8?Q?RKwyVlX99s/eqoDfspJOZcE=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 53b7cb76-8d17-4e83-7eae-08d9f2ebc9a5
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Feb 2022 14:34:36.7843
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 734ro5G1d620ojDR8cd6Qn96yFTe1tRmMMeyd1kNENBudn6iOvgy0NwEDUBnO0RFf/VZCa3apAmZhbOQwdm+qw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5543
X-OriginatorOrg: citrix.com

Add a new Kconfig option under the "Speculative hardening" section
that allows selecting whether to enable retpoline. This depends on the
underlying compiler having retpoline support.

Requested-by: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Changes since v2:
 - Place first in the section.
 - Remove "If unsure".

Changes since v1:
 - Fix description of option to use indirect branches instead of
   indirect calls.
---
 xen/arch/x86/Kconfig |  5 -----
 xen/common/Kconfig   | 14 ++++++++++++++
 2 files changed, 14 insertions(+), 5 deletions(-)

diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig
index f8dca4dc85..eb4d1a949f 100644
--- a/xen/arch/x86/Kconfig
+++ b/xen/arch/x86/Kconfig
@@ -36,11 +36,6 @@ config CC_INDIRECT_THUNK
 	def_bool $(cc-option,-mindirect-branch-register) || \
 	         $(cc-option,-mretpoline-external-thunk)
 
-
-config INDIRECT_THUNK
-	def_bool y
-	depends on CC_INDIRECT_THUNK
-
 config HAS_AS_CET_SS
 	# binutils >= 2.29 or LLVM >= 6
 	def_bool $(as-instr,wrssq %rax$(comma)0;setssbsy)
diff --git a/xen/common/Kconfig b/xen/common/Kconfig
index db687b1785..533b8f33e6 100644
--- a/xen/common/Kconfig
+++ b/xen/common/Kconfig
@@ -85,6 +85,20 @@ config STATIC_MEMORY
 
 menu "Speculative hardening"
 
+config INDIRECT_THUNK
+	bool "Speculative Branch Target Injection Protection"
+	depends on CC_INDIRECT_THUNK
+	default y
+	help
+	  Contemporary processors may use speculative execution as a
+	  performance optimisation, but this can potentially be abused by an
+	  attacker to leak data via speculative sidechannels.
+
+	  One source of data leakage is via branch target injection.
+
+	  When enabled, indirect branches are implemented using a new construct
+	  called "retpoline" that prevents speculation.
+
 config SPECULATIVE_HARDEN_ARRAY
 	bool "Speculative Array Hardening"
 	default y
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Fri Feb 18 14:39:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 18 Feb 2022 14:39:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275539.471457 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL4Pv-0002Xk-W5; Fri, 18 Feb 2022 14:39:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275539.471457; Fri, 18 Feb 2022 14:39:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL4Pv-0002Xd-T7; Fri, 18 Feb 2022 14:39:27 +0000
Received: by outflank-mailman (input) for mailman id 275539;
 Fri, 18 Feb 2022 14:39:26 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=6Bzb=TB=citrix.com=prvs=041dc651e=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nL4Pt-0002XX-W0
 for xen-devel@lists.xenproject.org; Fri, 18 Feb 2022 14:39:25 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9083a1f9-90c8-11ec-8723-dd0c611c5f35;
 Fri, 18 Feb 2022 15:39:24 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9083a1f9-90c8-11ec-8723-dd0c611c5f35
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645195164;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:content-transfer-encoding:in-reply-to;
  bh=EYs7NGzGuJbaaYQP0j8NOvWe47eafHSpFNrbjUk83Vo=;
  b=HYCbxbvJNo1kEdne7ZczMYeuXrfn/p9/9UL12n4pyIeTtYY3cKez2c/R
   5LlxrbcSbTrUr+uxZRYxra03IWoLcUzZidmNYUjInhmBDH7Gh/5c9bZlh
   3EqMDLBfE/eD3Q7RUw4Dtp2+PSiRYPGFFCb6OOlCHEK+WMipOvPf15VL2
   s=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 63960861
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:bd9TV62cyPVg6acygvbD5f1xkn2cJEfYwER7XKvMYLTBsI5bpzRUm
 GtKXj+EMv+Da2Dwc9wnaIXk/UIP75DWytBrSQM/pC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk0GE/NtTo5w7Rj2tQx0YDja++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /1Rq8aKZCwCMpfVwt4bUjlKHSshFrZvreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHiOp8fvXdxiynUF/88TbjIQrnQ5M8e1zA17ixLNaiFN
 pRBOWQ2BPjGSwBNJlMQOLE6pcW5rGTgQTpYq0/NoZNitgA/yyQuieOwYbI5YOeiXt5Jl0yVo
 mbH+WXRARwAMtGbjz2f/RqEpMXCgCf6U4I6D6Cj+7hhh1j77nMXIA0bUx28u/bRol6zXZdTJ
 lIZ/gIqrLMu7wq7Q9/lRRq6rXWY+BkGVLJ4GOQg5AaA4qHd+QqeCy4PSTspVTA9nJZoH3pwj
 AbPxo63Q2w02FGIdZ6D3quK9wmfEgMZF3ZYXykFbRkL6YbIu6hm23ojUe1fOKKyi9T0HxT5z
 DaLsDUyit0vsCIb60mo1QuZ2mzx//AlWiZwv1yKBTz9smuVcab4P9TA1LTN0RpXwG91pHGlt
 WNMpcWR5ftm4XqlxH3UG7Vl8F1ECp+43NzgbbxHQ8hJG9eFoSfLkWVsDNdWfRYB3iEsI2KBX
 aMrkVkNjKK/xVPzBUONX6q/Ct4x0Y/rHsn/W/bfY7JmO8YtKVbdoHk/ORDJhQgBdXTAd4lma
 P93lu72UB4n5VlPlmLqF4/xL5dwrszB+Y8jbc+ilEn2uVZvTHWUVa0EIDOzghMRt8u5TPHu2
 48HbaOikkwHOMWnO3W/2dNDfDgicClgbbir+pM/SwJ2Clc/cI3XI6SKmu1Jlk0Mt/k9q9okC
 VnnBBcDkQKn3SevxMfjQikLVY4DlK1X9RoTVRHA937ys5T/Se5DNJsiSqY=
IronPort-HdrOrdr: A9a23:XXILAKogRpOZaH9dxDZw4ZsaV5oteYIsimQD101hICG8cqSj+f
 xGuM5rsSMc7wxhP03I+OrwXZVoLkmwyXcY2+Us1PKZLW/bUQiTXeNfBOnZowEIcheWnoU26U
 4jSdkcNDSZNykCsS+Q2miF+rgbr+W6zA==
X-IronPort-AV: E=Sophos;i="5.88,379,1635220800"; 
   d="scan'208";a="63960861"
Date: Fri, 18 Feb 2022 14:39:20 +0000
From: Anthony PERARD <anthony.perard@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Doug Goldstein
	<cardoe@cardoe.com>, Wei Liu <wl@xen.org>, Roger Pau =?iso-8859-1?Q?Monn=E9?=
	<roger.pau@citrix.com>, Stefano Stabellini <sstabellini@kernel.org>, "Jan
 Beulich" <JBeulich@suse.com>
Subject: Re: [PATCH] CI: Add gnu grep to alpine containers
Message-ID: <Yg+vmEsWzurilMNy@perard.uk.xensource.com>
References: <20220218131740.30922-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220218131740.30922-1-andrew.cooper3@citrix.com>

On Fri, Feb 18, 2022 at 01:17:40PM +0000, Andrew Cooper wrote:
> A forthcoming change is going to want more support than busybox's grep can
> provide.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> ---
> CC: Doug Goldstein <cardoe@cardoe.com>
> CC: Wei Liu <wl@xen.org>
> CC: Anthony PERARD <anthony.perard@citrix.com>
> CC: Roger Pau Monn� <roger.pau@citrix.com>
> CC: Stefano Stabellini <sstabellini@kernel.org>
> CC: Jan Beulich <JBeulich@suse.com>
> 
> I've already rebuilt the containers and confirmed that the build is still fine.

Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Fri Feb 18 14:46:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 18 Feb 2022 14:46:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275546.471469 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL4WR-0003xy-Oe; Fri, 18 Feb 2022 14:46:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275546.471469; Fri, 18 Feb 2022 14:46:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL4WR-0003xr-K0; Fri, 18 Feb 2022 14:46:11 +0000
Received: by outflank-mailman (input) for mailman id 275546;
 Fri, 18 Feb 2022 14:46:10 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=6Bzb=TB=citrix.com=prvs=041dc651e=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nL4WQ-0003xV-Gb
 for xen-devel@lists.xenproject.org; Fri, 18 Feb 2022 14:46:10 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8160fc5e-90c9-11ec-8eb8-a37418f5ba1a;
 Fri, 18 Feb 2022 15:46:09 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8160fc5e-90c9-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645195568;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:content-transfer-encoding:in-reply-to;
  bh=76scZa6Wb0sZrTMu+slcePwmpKNJDx+oKFLbu6zjHWM=;
  b=ORJQNpwwvAUVxG69bFNCQQlnR+K2ytPpNzs8VRhNXSVoPfNN0ygWeB+c
   /KKIjpSeGLZBsTx1Ktf2kMfrbXNuFuU4GT22Ii0zpGGX1PSuxLzbs36Ee
   wJceXDV8e4EdMtiIWZajOC6J+Rim2LN8PIWasD3bWy6JkEhz7asK+I3f+
   8=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 64521464
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:n0fcx6vrK+n12SoEhzBPMqYJA+fnVEteMUV32f8akzHdYApBsoF/q
 tZmKW7UOKmIZWOmed8iatyw/R8Bv57Sy4dmSAQ+q3gyEysU+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQzy4bVvqYy2YLjW1nU6
 YuoyyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb
 /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo
 Oihu6BcRi8UYKz2vOVBSSVGODgjOaYbou7Bf1aW5Jn7I03uKxMAwt1rBUAye4YZ5vx2ESdF8
 vlwxDIlN07ZwbjsmfTiF7cq1p9LwMrDZevzvllpyy3ZCvA3B4jOWazQ6fdT3Ssqh9AIFvHbD
 yYcQWQzMU6ZP0MTUrsRILFhlfmHg1P5SGIbsXGno+kF+EHhjyUkhdABN/KKI4fXFK25hH2wu
 Wbu72n/RBYAO7S30iGZ+3ihguvOmyLTW48IErC8sPlwjzW71mEVTREbS1a/if24kVKlHcJSL
 VQO/SgjprR081akJvH2Vge0p3OstRcGV91dVeY97WmwJrH8uljDQDJeF3gYNYJg5JReqSEWO
 kGhoo3oPxhu7KepV1mEq7Of8GnjP3Y7BDpXDcMbdjct797mqYA1qxvASNd/DaK45uHI9SHML
 yOi93Zn2ehK5SIf/+DipA2c3WrwznTcZlNtvm3qsnSZAhSVjWJPT6ih8hDl4PlJN+51pXHR7
 SFfy6ByAA3jZKxhdRBhos1RTdlFBN7faVUwZGKD+bF4plxBHFb5IOhtDMlWfhsBDyr9UWaBj
 LXvkQ1Q/oRPG3ChcLV6ZYm8Y+xzk/S9TI65DqGIMIMUCnSUSONh1Hg/DaJ39zqw+HXAbIllY
 cvLGSpSJS1y5VtbIMqeGL5GjO5DKtEWzmLPX5HrpylLIpLFDEN5vYwtaQPUBshgtfvsiFyMr
 753apvboz0CAbaWSnSGruYuwaUicCFT6Wbe8JcMKIZu42NORQkcNhMm6el/I9c8x/wNzI8lP
 BiVAydl9bY2vlWfQS3iV5ypQOqHsUpXxZ7jARERAA==
IronPort-HdrOrdr: A9a23:z5aksqm5o1NXqw1torQzH4zAp6bpDfIq3DAbv31ZSRFFG/Fxl6
 iV8sjz8SWE7Ar5P0tQ/uxoWZPwJE80mqQZ3WB8B9uftUzdyQ2VxeJZnOnfKl/bexEWn9Q1vc
 wLT0E9MqySMbETt7eC3ODSKbcdKbe8n5yVuQ==
X-IronPort-AV: E=Sophos;i="5.88,379,1635220800"; 
   d="scan'208";a="64521464"
Date: Fri, 18 Feb 2022 14:46:03 +0000
From: Anthony PERARD <anthony.perard@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Doug Goldstein
	<cardoe@cardoe.com>, Wei Liu <wl@xen.org>, Roger Pau =?iso-8859-1?Q?Monn=E9?=
	<roger.pau@citrix.com>, Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH] CI: Clean up alpine containers
Message-ID: <Yg+xK0xO3Rk8+xZe@perard.uk.xensource.com>
References: <20220218131811.31133-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220218131811.31133-1-andrew.cooper3@citrix.com>

On Fri, Feb 18, 2022 at 01:18:11PM +0000, Andrew Cooper wrote:
>  * `apk --no-cache` is the preferred way of setting up containers, and it does
>    shrink the image by a few MB.
>  * Neither container needs curl-dev.
>  * Flex and bison are needed for Xen, so move to the Xen block.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> ---
> CC: Doug Goldstein <cardoe@cardoe.com>
> CC: Wei Liu <wl@xen.org>
> CC: Anthony PERARD <anthony.perard@citrix.com>
> CC: Roger Pau Monn� <roger.pau@citrix.com>
> CC: Stefano Stabellini <sstabellini@kernel.org>
> 
> I've already rebuilt the containers and confirmed that the build is still fine.
> ---
> diff --git a/automation/build/alpine/3.12-arm64v8.dockerfile b/automation/build/alpine/3.12-arm64v8.dockerfile
> index a1ac9605959e..006cdb3668b3 100644
> --- a/automation/build/alpine/3.12-arm64v8.dockerfile
> +++ b/automation/build/alpine/3.12-arm64v8.dockerfile
> @@ -8,46 +8,39 @@ RUN mkdir /build
>  WORKDIR /build
>  
>  # build depends
> -RUN \
> -  # apk
> -  apk update && \
> +RUN apk --no-cache add \
>    \
>    # xen build deps
> -  apk add argp-standalone && \
> -  apk add autoconf && \
> -  apk add automake && \
> -  apk add bash && \
> -  apk add curl && \
> -  apk add curl-dev && \
> -  apk add dev86 && \
> -  apk add dtc-dev && \
> -  apk add gcc  && \
> +  argp-standalone \
> +  autoconf \
> +  automake \

Since you are removing some other pkgs, I don't think "automake" is
needed either. We only use "autoconf" and "autoheader". (Maybe the
automake pkg give access to something we need, but I'm not sure about
that.)


In any case, changes looks good:
Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Fri Feb 18 14:59:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 18 Feb 2022 14:59:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275553.471480 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL4jM-0005YV-UL; Fri, 18 Feb 2022 14:59:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275553.471480; Fri, 18 Feb 2022 14:59:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL4jM-0005YO-QQ; Fri, 18 Feb 2022 14:59:32 +0000
Received: by outflank-mailman (input) for mailman id 275553;
 Fri, 18 Feb 2022 14:59:31 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=6Z2s=TB=citrix.com=prvs=041b9fbab=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nL4jL-0005YI-D3
 for xen-devel@lists.xenproject.org; Fri, 18 Feb 2022 14:59:31 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5e1f5e53-90cb-11ec-8eb8-a37418f5ba1a;
 Fri, 18 Feb 2022 15:59:29 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5e1f5e53-90cb-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645196369;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=3EwvVF/KPonXNYvygcxvUjcnvz4g9uUo0FHyIlWlzu8=;
  b=QCfdnzhXIfcwQ5jKBNVaInKcpyMBVA9EPlDTi+rp1SHcFPf5sTwNeqje
   rA85Mx7+viL2OxgDPDw2SmrMKG73L5UV9RgpYv8FJ62+V5SnSsNE90uVH
   0r3ao2Osp8oeNgZ5rUGWfMyiHC5EIuBG25hUWcoDRPU1Y71O25w2TaVSs
   w=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 66768096
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:N2YvuaDxtNIQtRVW/wPjw5YqxClBgxIJ4kV8jS/XYbTApDkngzxUn
 GMbC2+BPPmPa2qme9AiOtzgphxTuZOAydFlQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YhFWeIdA970Ug5w7Rg0tYy6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhS4
 5Jx67C+ETwMJ43Cn8I2DzpRHR9HaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguwKKsXxMZxZkXZn1TzDVt4tQIzZQrWM7thdtNs1rp4QQqiOP
 5tHAdZpRDKHeABNHm0XMZIZmbylmVauQg17tU3A8MLb5ECMlVcsgdABKuH9ZdiiVchT2EGCq
 Qru5H/lCxsXMNiezzut8X+2gOLL2yThV+o6BLC+s/JnnlCX7mgSEwENE0u2p+GjjUyzUM4ZL
 FYbkgIlpLI+80GDRdDnUxq15nWDu3Yht8F4SrNgrlvXk+yNvljfVjNsoiN9hMIOl+RxeWIG2
 AeyusrJCztJm+G2QHyjz+LBxd+tAhQ9IWgHbC4CaAIK5dj/vY0+5i7yosZf/L2d1YOsR2ypq
 9yehG1n3uhI05ZXv0mu1Q2f21qRSo71ohnZD+k9dkas9UtHaYGsfOREAnCLvK8bfO51orRs1
 UXoevRyDshSXPlhdwTXGY3h+Y1FAd7cYVUwZnY1QvEcG8yFoSLLQGypyGgWyL1VGsgFYyT1R
 0TYpBlc4pReVFPzM/MqOtjtU5V2k/G6fTgAahwyRoMfCnSWXFXalByCmGbKhzy9+KTSufpX1
 WinnTaEUi9BVPUPIMueTOYBy747rh3SNkuILa0XOy+PiOLEDFbMEO9tGALXMogRsfPVyC2Io
 o03H5bblH1ivBjWP3C/HXg7dgtRcxDWxPne9qRqSwJ0ClA4QDp4U6eJm9vMueVNxsxoqwsBx
 VnkMmdww1vjn3zXbwKMb3FocrT0Wphj63k8OEQR0ZyAghDPva7HAH8jSqYK
IronPort-HdrOrdr: A9a23:lciHDKGsRBZQiltzpLqFTJHXdLJyesId70hD6qkvc3Nom52j+/
 xGws536fatskdtZJkh8erwXZVp2RvnhNBICPoqTMuftW7dySqVxeBZnMTfKljbdREWmdQtrJ
 uIH5IOa+EYSGIK9/oSgzPIU+rIouP3iJxA7N22pxwGLGFXguNbnnxE426gYxdLrWJ9dP4E/e
 +nl6x6Tk2bCBMqh6qAdxs4dtmGg+eOuIPtYBYACRJiwhKJlymU5LnzFAXd9gsCUhtUqI1Ssl
 Ttokjc3OGOovu7whjT2yv49JJNgubszdNFGYilltUVEDPxkQylDb4RGYFq/QpF5d1H2mxa1+
 UkkC1QefibLEmhJ11dlCGdnzUIFgxes0MKh2Xo2kcL6vaJOw7SQ/Ax+76xNCGptnbI9esMoJ
 6ilQiixutqJAKFkyLn69fSURZ20kKyvHo5iOYWy2dSSI0EddZq3MYiFW5uYd899RjBmcsa+S
 hVfbXhzecTdUnfY2HSv2FpztDpVnMvHg2eSkxHvsCOyTBZkH1w0kNdnaUk7zs93YN4T4MB6/
 XPM6xumr0LRsgKbbhlDONERcesEGTCTR/FLWrXK1X6E6MMPW7LtvfMkfgIzfDvfIZNwIo5mZ
 zHXl8dvWkue1j2AcnLx5FP+gClehT1Yd0s8LAp23FUgMyPeFPbC1z1dLl1qbrSnxw2OLyvZ8
 qO
X-IronPort-AV: E=Sophos;i="5.88,379,1635220800"; 
   d="scan'208";a="66768096"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=DvbFzb1UaZ2osiCQYWZSrKuSxSKnz/B0U+6iA/oFLohgr1wNTmK/OsQcaTuD+zLy+312UWsM+pBrbieaMJ+QB5ExrwCDHeJ7VNmqWDr5nO29VMX0oNCI7S1n9DDzcSzCjqIY55GRoTgpwFBUcOye06+ACfngDDqf4AdmQwKEn0tMLNE4Xu4Q41LxKXH9Pa9912k9QRPVYDQXmn8aYwIrcQYtwWvbev9vxmvM8eTR5mvUtUisgtkDe0ujJgIFtuyJOlQPdPPbQCSFHLONvmgC+mleGA7O4Y8utB4OkNHt5R2IVNYi5mf1Un6DhE4qzHMBQhRvoFi2caCP4dhFS22tbA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=3EwvVF/KPonXNYvygcxvUjcnvz4g9uUo0FHyIlWlzu8=;
 b=E1+RgojrsPkMG1mIbePP696GTBTeCwWB3ZHf4K+dIKhtnvSL2ztnEhqDSp+ozaWyeTIKR1Yq7fo6evznh7FsZLc2RRJBcJXm7CTdICkBwyxKx/QPuiuvUaNmEe2CfTnK9zg2HPt9Dcs/WpS3e3ur08bkgE1qzwzfx0+YhywfYgC25w2mICQHIIi02kULOtpKILq/eFLx26itTDrCUrRgCy8htzomuN97U6IjZC8NSmzW+n3zyR8hO6IsTlW7za0bbos+aCS4AxLIGNGLfYsMRFXzFXLf/k99PcH41+sOtY59SNgw/dbKlYOPk270GIxnMI0CavHdl+L/fAJVpVCcbA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=3EwvVF/KPonXNYvygcxvUjcnvz4g9uUo0FHyIlWlzu8=;
 b=AsE6xAXwAt/rNTRZ/X97Q29Co/WGbw5jPNBl6vU60H2zdNkAn6B8sNwURFJm8bXVYCLu+hRQUakFkH4roJ9BtqvBIWq8xCd0lTkaLrD3oCnnkmF1Y2H/UP2wmGaO8mi2ejSJT86tixQfJy1+jpl54dPBFdFO9bqzM2yeN+77cUg=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Anthony Perard <anthony.perard@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Doug Goldstein
	<cardoe@cardoe.com>, Wei Liu <wl@xen.org>, Roger Pau Monne
	<roger.pau@citrix.com>, Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH] CI: Clean up alpine containers
Thread-Topic: [PATCH] CI: Clean up alpine containers
Thread-Index: AQHYJMoUO4xl86uH0E6ly+blvuakQqyZYuyAgAADuwA=
Date: Fri, 18 Feb 2022 14:59:24 +0000
Message-ID: <b5beac90-cec0-1548-829c-e376be107c3c@citrix.com>
References: <20220218131811.31133-1-andrew.cooper3@citrix.com>
 <Yg+xK0xO3Rk8+xZe@perard.uk.xensource.com>
In-Reply-To: <Yg+xK0xO3Rk8+xZe@perard.uk.xensource.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 7a8cd335-857a-4ae0-1806-08d9f2ef40ad
x-ms-traffictypediagnostic: SJ0PR03MB5407:EE_
x-microsoft-antispam-prvs: <SJ0PR03MB54070F374D408FE125BDC52ABA379@SJ0PR03MB5407.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: T2kUwP1givDGshHl5xYZMIm4RUf8aNyk+0DcxxeZOXNU/zK0+jtSOsRXH4z9Gwqq1SxWiYyeH4HT864bS4EftlIq+8iqbQ88zXS1PLUQ77TwSRxMZYKiNl0iQGkcUcox0ddqnSdieX1YpzZH9mfxoZ5CD+dAD8JfK1CvCG6TFQ5kOm6i8WahBVBURb5YaTdGgcxT9FzA0QDb6yGfXVbJ8ds8hVbNnoNX3msm+ubnqd5twy884kmTfYilRMyBE4T4HiYfDyIkNjyOmbIfoUx3+sHY4UmMAn90GUC50kFVkZc9QjsuRJwP2VBJKXfnx8hB2P+lRIFrY7ZJGz/Hggt/RCpOpXDT2tg11q0eAwKBcZKE++EUTyXCb9lcSOkcCVr5McVNzABAxTb6RXk1RREaPDjY+OMsJI1FmnqXezB+oCVwvi6qF2AUP0oWu8j1PQ4mGb3eCcZ7L+R+1ioiyRL8EhcfR/1vXvPUUhWDaIx8IAFB3hPuvARQJBYBMYotd55bSXSTrw3PtH0zpsL1VebieEEtwVlSdacUr7skDkecEssRkmS1UKKkhCWI32XFL77XfqK/wzcf7OanGd24wyq63qybI0YFcAA7ZU8+E0xJTRGl4J5+STkdkEAsQFNsv834QwAr3QhGKZvB7eO0qhVa3D7xQ7b91if1dpSVCzRykEej4OFYjYpTrS0ia4VQUfZH76Yl3xpyhsPIKrBbOBrt0WKsXxZHkq/BW6BWdBh+j58PfjGSjQNBjoNsferWc1Cv8PiF8j4VD3kzv3t6iYcCOA==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(83380400001)(38100700002)(122000001)(82960400001)(71200400001)(6486002)(53546011)(6506007)(36756003)(316002)(31686004)(508600001)(2616005)(6636002)(37006003)(54906003)(8936002)(66476007)(66556008)(66946007)(5660300002)(4326008)(31696002)(6512007)(26005)(186003)(91956017)(38070700005)(86362001)(6862004)(76116006)(2906002)(8676002)(66446008)(64756008)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?QWthZVZVVi9LZ3o2S3dzSHR2YWEyNWcwWVUwWmNpRHFPWUc2SHZqWXlTSk9h?=
 =?utf-8?B?TnF4a24yRVpkRkxJdmsvdTFJUG01S2JTcXZ6Vm9PcEdjcituOVg4OGt3SDc5?=
 =?utf-8?B?M2U3UkxUL2U0TEplOCs5TmxVamtLcFBnbFR4cXV3eXQzcnNDSHNVY05Ma3BD?=
 =?utf-8?B?alUrRzMvMlBPblVyaW5qc2hIRWFvMUNOSDNGS0I2L01lV29lSWpFYlZYNE5U?=
 =?utf-8?B?WjBjbWwxM2trOUJvdUVpU0NNWThMUVJjYnRNRGVyQU52Sk56c3RmV3AzWUI3?=
 =?utf-8?B?WkxOVjMvR1ZQaUYzdnlpN3VnKzVXdVJnK01NV09kRkdCSnlUTm5UcHVnMDY1?=
 =?utf-8?B?MzZWb1FTT2pzamtuSlAwejJSM2R2SE1TNzh2UEV6ZHVZRi92MFlHM3N1Y0Rx?=
 =?utf-8?B?Tk1zeFlSdUk5T0VtcnFGZjlPZENXOU8zd243WVpRcTR4VjhyOWpvTDJMK294?=
 =?utf-8?B?WWxub2l5anlxaDZIcVNmTzB6M2FXVlpBNXNsTzNCSk5vY1Z4YUh2dmtQeEYw?=
 =?utf-8?B?Tms0cGlpSnVRTGNvRHVHSVpqZWw4WWlEM2t5dGJUVWFpanJQYUVKTFlPZ0lu?=
 =?utf-8?B?ZUR2UmNmUE5WaGN1SFA3SElFQXNmZzJKVTJVNEt1TmNqbSs1K3NmQzcySU11?=
 =?utf-8?B?cXNPWjFEZjBGdVhXUXhwM1E4R1ZBeXV1Y3N4bU8wWjRBeWdzeUtRU1pnNzAz?=
 =?utf-8?B?NCszZWxKREJKZk5CcVJna1RuRE5EQ09NNzZ0T1RmRzFHZ2p2Mkx5aHdONUV4?=
 =?utf-8?B?QkJPVlFsYUFieDlTMVhCdnBsY2dqR2hWZFJiQXVZRHA1Z01Mc0JYcUxiTE5l?=
 =?utf-8?B?TlE2K1VEbTBlWHdUdkQzU2IrSFIwd3V4ZCtGMk9obUFYdy94U1FKUGNNc0Fr?=
 =?utf-8?B?UitQYWVraFpwOUFIWFdGUWQvUzVCcWs0a3RocEVtN09VRzBuNlJNVUZmOTRC?=
 =?utf-8?B?T0pJTnRVSE9RQmhMMDdFeGhkUjBrMXAxdm43c20vbzZ0NGJGL1A3NS9jMWQ1?=
 =?utf-8?B?bFVhZGR4cHc0M21ieEkzaEJzMjNVRDdxZlNhaDBaSzQwWEtHdzFYRXRyeW16?=
 =?utf-8?B?Y0c5cTB2KzVzcFZBSVdzQjFsNVhPUjJkQURUSzErZVFjOGFDYmE1SFZjNmRV?=
 =?utf-8?B?aWRYcDFDZXljNnpjTWlZNVo2OG9PRStVQmhienpHcGZJWW9rM21OL3JnTXR1?=
 =?utf-8?B?Y1JReFB0dVJobWlCOEhmYWlKUDV3RVpsQm5kS2xSbCs1djZjZW11dVpyYi9H?=
 =?utf-8?B?d2FHck0wbTAzblNocURSU095YnVMT0RkdE45OHpyN25GNXIweDduOFpFbnRF?=
 =?utf-8?B?eXBldnkxeW9aaDFCYTVvZ0Jqc2ljbzRUeGgrbE5XT01lOEhXWmtFZEc5Uzkw?=
 =?utf-8?B?NnFlR1g2U0R1b1NaTFBKMzNPTjFDbHU0TzlsOU54NmlIeUFEK0lhUytUc21R?=
 =?utf-8?B?VVhQcFduTTFZTnB2Y0x1cWwxZXhMclpHWVMrVXBvV3ZNZFRScm41WVpQdkJ1?=
 =?utf-8?B?THE4anJKMzA0Rk9LZTZwelVhWnp5aDhaajYvb2V1UVo5MDhKNWYrNitFb1E2?=
 =?utf-8?B?eHB5QUVGTFZhVkcrbmhKRlBaVGpJZGZ6Q241RnJYcXVOejZSeHhzOEg3Nk5r?=
 =?utf-8?B?blFVejlnMmNPZWs2QkNvWEpyTnN5eThjblNUQ1dXUVZjUWgzNVZ2SnFPS1I2?=
 =?utf-8?B?T0ZsZm1ndVg5WGJiTmpzR25ibXp6VWFHeTRKV011U1MweWZKWFNkYVE1SjNN?=
 =?utf-8?B?d1h5cjE1OXV4R3NJcXpTRTBEZmNPSHBsRWV2YVVFbGo0L2JKaTlIQjVOWi9k?=
 =?utf-8?B?bDRuNUdtb3pPRmtqUU9MQTZtbitoVW80TllMQVEwRVhwZUorZ1VvaEtiQU93?=
 =?utf-8?B?eDgwS3VwL1hCVU1iNVQrOVRsMG1wZ2lqbk94WmtPQ2REUGxHUm9YL0pQL3ZV?=
 =?utf-8?B?QXpmREcvM3ZtNndVTFhIUm9XdGFyVmFKbWxKS1UvNWcxR0VPVGM0dXN0M0JK?=
 =?utf-8?B?YStYNG1hMzFnTHM3UllLRU1nb3BTOVE2SlEvSWt1RWNoRXoxZldlWWxwbFdZ?=
 =?utf-8?B?ZHUxSEFxVXdLaGsxcjNPcG4ybjdxRHQreXFLQXZXckM2ODlvT3gzY3pqL2Nr?=
 =?utf-8?B?RU9pV0M5dEUrTURLc0hLU1RsSkxCZkMxRElNZExhN3prRFVETXlnUSt1Q0pX?=
 =?utf-8?B?OTFUallmZURUQ0VXVCtNQTZObmlDWGNWSkE1cmFlY01PRkVYc2tjUldiMFBK?=
 =?utf-8?B?NzNVaGxZYTVuL1VuQWFKQzJGVTBBPT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <A6CE50F7C1BBBE4B893FBCECD820517B@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7a8cd335-857a-4ae0-1806-08d9f2ef40ad
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Feb 2022 14:59:24.5045
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: rtzltdBtAmUBLXYHq62dt50tTFAJ8JlqFoQLeP+hoLVtn1LXnh3q2+u+veFmD38aelpCAklAjBhrigsRpAO1xnLtwtgG7V7pfwrJAm/TQg0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5407
X-OriginatorOrg: citrix.com

T24gMTgvMDIvMjAyMiAxNDo0NiwgQW50aG9ueSBQRVJBUkQgd3JvdGU6DQo+IE9uIEZyaSwgRmVi
IDE4LCAyMDIyIGF0IDAxOjE4OjExUE0gKzAwMDAsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiAg
KiBgYXBrIC0tbm8tY2FjaGVgIGlzIHRoZSBwcmVmZXJyZWQgd2F5IG9mIHNldHRpbmcgdXAgY29u
dGFpbmVycywgYW5kIGl0IGRvZXMNCj4+ICAgIHNocmluayB0aGUgaW1hZ2UgYnkgYSBmZXcgTUIu
DQo+PiAgKiBOZWl0aGVyIGNvbnRhaW5lciBuZWVkcyBjdXJsLWRldi4NCj4+ICAqIEZsZXggYW5k
IGJpc29uIGFyZSBuZWVkZWQgZm9yIFhlbiwgc28gbW92ZSB0byB0aGUgWGVuIGJsb2NrLg0KPj4N
Cj4+IFNpZ25lZC1vZmYtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5j
b20+DQo+PiAtLS0NCj4+IENDOiBEb3VnIEdvbGRzdGVpbiA8Y2FyZG9lQGNhcmRvZS5jb20+DQo+
PiBDQzogV2VpIExpdSA8d2xAeGVuLm9yZz4NCj4+IENDOiBBbnRob255IFBFUkFSRCA8YW50aG9u
eS5wZXJhcmRAY2l0cml4LmNvbT4NCj4+IENDOiBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVA
Y2l0cml4LmNvbT4NCj4+IENDOiBTdGVmYW5vIFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5l
bC5vcmc+DQo+Pg0KPj4gSSd2ZSBhbHJlYWR5IHJlYnVpbHQgdGhlIGNvbnRhaW5lcnMgYW5kIGNv
bmZpcm1lZCB0aGF0IHRoZSBidWlsZCBpcyBzdGlsbCBmaW5lLg0KPj4gLS0tDQo+PiBkaWZmIC0t
Z2l0IGEvYXV0b21hdGlvbi9idWlsZC9hbHBpbmUvMy4xMi1hcm02NHY4LmRvY2tlcmZpbGUgYi9h
dXRvbWF0aW9uL2J1aWxkL2FscGluZS8zLjEyLWFybTY0djguZG9ja2VyZmlsZQ0KPj4gaW5kZXgg
YTFhYzk2MDU5NTllLi4wMDZjZGIzNjY4YjMgMTAwNjQ0DQo+PiAtLS0gYS9hdXRvbWF0aW9uL2J1
aWxkL2FscGluZS8zLjEyLWFybTY0djguZG9ja2VyZmlsZQ0KPj4gKysrIGIvYXV0b21hdGlvbi9i
dWlsZC9hbHBpbmUvMy4xMi1hcm02NHY4LmRvY2tlcmZpbGUNCj4+IEBAIC04LDQ2ICs4LDM5IEBA
IFJVTiBta2RpciAvYnVpbGQNCj4+ICBXT1JLRElSIC9idWlsZA0KPj4gIA0KPj4gICMgYnVpbGQg
ZGVwZW5kcw0KPj4gLVJVTiBcDQo+PiAtICAjIGFwaw0KPj4gLSAgYXBrIHVwZGF0ZSAmJiBcDQo+
PiArUlVOIGFwayAtLW5vLWNhY2hlIGFkZCBcDQo+PiAgICBcDQo+PiAgICAjIHhlbiBidWlsZCBk
ZXBzDQo+PiAtICBhcGsgYWRkIGFyZ3Atc3RhbmRhbG9uZSAmJiBcDQo+PiAtICBhcGsgYWRkIGF1
dG9jb25mICYmIFwNCj4+IC0gIGFwayBhZGQgYXV0b21ha2UgJiYgXA0KPj4gLSAgYXBrIGFkZCBi
YXNoICYmIFwNCj4+IC0gIGFwayBhZGQgY3VybCAmJiBcDQo+PiAtICBhcGsgYWRkIGN1cmwtZGV2
ICYmIFwNCj4+IC0gIGFwayBhZGQgZGV2ODYgJiYgXA0KPj4gLSAgYXBrIGFkZCBkdGMtZGV2ICYm
IFwNCj4+IC0gIGFwayBhZGQgZ2NjICAmJiBcDQo+PiArICBhcmdwLXN0YW5kYWxvbmUgXA0KPj4g
KyAgYXV0b2NvbmYgXA0KPj4gKyAgYXV0b21ha2UgXA0KPiBTaW5jZSB5b3UgYXJlIHJlbW92aW5n
IHNvbWUgb3RoZXIgcGtncywgSSBkb24ndCB0aGluayAiYXV0b21ha2UiIGlzDQo+IG5lZWRlZCBl
aXRoZXIuIFdlIG9ubHkgdXNlICJhdXRvY29uZiIgYW5kICJhdXRvaGVhZGVyIi4gKE1heWJlIHRo
ZQ0KPiBhdXRvbWFrZSBwa2cgZ2l2ZSBhY2Nlc3MgdG8gc29tZXRoaW5nIHdlIG5lZWQsIGJ1dCBJ
J20gbm90IHN1cmUgYWJvdXQNCj4gdGhhdC4pDQoNClZlcnkgZ29vZCBvYnNlcnZhdGlvbi7CoCBX
ZSBkb24ndCBoYXZlIGF1dG9tYWtlIGluIGFueSBvdGhlciBjb250YWluZXJzLsKgDQpJJ2xsIHN0
cmlwIGl0IG91dCBhbmQgZG91YmxlIGNoZWNrIHRoZSByZXN1bHRpbmcgYnVpbGQuDQoNCj4gSW4g
YW55IGNhc2UsIGNoYW5nZXMgbG9va3MgZ29vZDoNCj4gUmV2aWV3ZWQtYnk6IEFudGhvbnkgUEVS
QVJEIDxhbnRob255LnBlcmFyZEBjaXRyaXguY29tPg0KDQpUaGFua3MuDQoNCn5BbmRyZXcNCg==


From xen-devel-bounces@lists.xenproject.org Fri Feb 18 15:45:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 18 Feb 2022 15:45:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275563.471491 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL5Ri-0002Pw-KE; Fri, 18 Feb 2022 15:45:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275563.471491; Fri, 18 Feb 2022 15:45:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL5Ri-0002Pp-Gp; Fri, 18 Feb 2022 15:45:22 +0000
Received: by outflank-mailman (input) for mailman id 275563;
 Fri, 18 Feb 2022 15:45:21 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=6Z2s=TB=citrix.com=prvs=041b9fbab=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nL5Rg-0002Pj-Q5
 for xen-devel@lists.xenproject.org; Fri, 18 Feb 2022 15:45:21 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c4bb2792-90d1-11ec-8723-dd0c611c5f35;
 Fri, 18 Feb 2022 16:45:18 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c4bb2792-90d1-11ec-8723-dd0c611c5f35
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645199118;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=WKNIonxcahKNHrmTDcEKSy7WRj7ghI/H77ZzKPmKQEo=;
  b=e+0fGZNzqQj4A2se4dTf2W49oM2GEaA3hjOrey+2xvPvNOY/n7ag3Kn+
   H9rVwRG+w3LZJxoaqMmsre3gUWJPYVkGlJ/38gY8f9mZ9loW0ANfoXDF/
   yWyKzA56/gMXZgpBdaPyqKeZ83C5NA5jQorBa4mvez2om1SXFevCyk6mE
   c=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 63966704
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:cd4gz6t8cD6bKVl+nlEhWkMg++fnVJteMUV32f8akzHdYApBsoF/q
 tZmKTqEOarZMDP2L90kPNyz/E5Vu5XRydNiSQVuqXw2FyoU+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQzy4bVvqYy2YLjW1nU6
 YuoyyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb
 /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo
 Oihu6BcRi8rHpTiuOQlciAALCR8OY1EpbT5HFKG5Jn7I03uKxMAwt1rBUAye4YZ5vx2ESdF8
 vlwxDIlN07ZwbjsmfTiF7cq1p9LwMrDZevzvllJyz3DAOlgapfEW6jQvvdT3Ssqh9AIFvHbD
 yYcQWQ0PUqePEUTUrsRIK89mt6HpH/RSmNBqU+ZrKcroFHL/hMkhdABN/KKI4fXFK25hH2wp
 H/C/mn/KgEXMpqY0zXt2mm3mubFkCf/WYQTPL617PhnhBuU3GN7IAISfUu2p7++kEHWc8JSL
 QkY9zQjqYA29Ve3VZ/tUhugunmGsxUAHd1KHIUS6guA167V6AaxHXUfQ3hKb9lOiSMtbWV0j
 BnTxYqvXGEx9u3OIZ6AyluKhTGSAAY1LVcjXHc7SAkBw9u+q78OpCuaG76PD5WJptHyHDjxx
 RWDoy4/m6gfgKY36kmrwbzUq2ny/8aUF2bZ8i2SBzv4tV0hOOZJcqT1sQCz0BpWEGqOorBtV
 lAgktPW0u0BBIrleMelELRUR+HBCxpo3VThbb9T83sJq2XFF52LJ9k4DNRCyKFBa5dsldjBO
 hK7hO+pzMUPVEZGl5NfbYOrENgNxqP9D9njXf28RoMQPsUoLlPfrX0wPBT4M4XRfK4EyPBX1
 XCzK5vEMJrnIf4/kGreqxk1itfHORzSNUuMHMumnnxLIJKVZWKPSKdtDbd9RrtR0U9wmy2Mq
 4w3H5LTk313CbSiCgGKod97BQ1bdhATWMGpw/G7g8bee2JOAn86MfbNzNsJIso990ijvryTp
 S/Vt44x4AeXuEAr3i3QNCg4Meu3BcwXQLBSFXVEAGtEEkMLOO6HxKwea4E2bf8g8ulixuRzV
 P4LZ4OLBfEnd9gN0211gUXVxGC6SCmWuA==
IronPort-HdrOrdr: A9a23:NJZt7K3YFZdzeQANZ3kZfQqjBRRyeYIsimQD101hICG9Lfb3qy
 n+ppsmPEHP5Ar5AEtQ5expOMG7MBfhHQYc2/hRAV7QZniYhILOFvAj0WKC+UyvJ8SazI9gPM
 hbAtBD4bHLfDpHZIPBkXSF+rUbsZq6GcKT9JzjJh5WJGkAAcwBnmRE40SgYzdLrWF9dMcE/f
 Gnl616Tk+bCA0qh7OAdx84tob41rj2vaOjRSRDKw8s6QGIgz/twqX9CQKk0hAXVC4K6as+8E
 De+jaJpJmLgrWe8FvxxmXT55NZlJ/K0d1YHvGBjcATN3HFlhuoXoJ8QLeP1QpF5d1HqWxa1O
 UkkS1Qefib2EmhJ11dZiGdgzUI5QxerEMKD2Xo2kcL7/aJHg7SQPAx+76xOiGpmnbI+usMjJ
 6jlljpxKa+R3n77VTAzsmNWBdwmkWup30+1eYVknxESIMbLKRctIoF4SpuYdo99Q/Bmcsa+d
 NVfYvhDTdtACSnRmGcunMqzM2nX3w1EBvDSk8eutaN2zwTmHxi1UMXyMEWg39FrfsGOtZ5zv
 WBNr4tmKBFT8cQY644DOAdQdGvAmiIRR7XKmqdLVnuCalCMXPQrJz85qkz+YiRCdA15Yp3nI
 6EXEJTtGY0dU6rAcqS3IdT+hSIW2m5VSSF8LAX23G4gMy0eFPGC1z3dLkeqbrXnxxEOLyoZx
 +aAuMjP8Pe
X-IronPort-AV: E=Sophos;i="5.88,379,1635220800"; 
   d="scan'208";a="63966704"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Zw3d3d/u/V+J+pE+t+IpiC9VXT0G7AsWxoNxKdYUTmDgEsEiUKfU7bdY9vcrOPom3kd4fqRcT53pHGwPqPh37RKtW+2SLAgQ3a4i/re9pwFBnexb38b/Ob+zxg5ntvMPlCaTc9oCeBPiymkEuo8Ps/GJ4OJMbcn0VWm5MXVGerT7HSkjBWmA2pfAPPn4bsuwA61Xmtjc0Y+q7ELJ7hKApnd8Gp7yJfcOGuzm10L+r1ie8KYdIqmu8R4Vu67oXAF2C9/9cnS1ttEI5onpDraTWFHEpIDLVNTleaMDvzZM4AjLhVuyn5a1W9YJBTVHXmgUZ1Bn7PbjritdzMO1TucHtA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=WKNIonxcahKNHrmTDcEKSy7WRj7ghI/H77ZzKPmKQEo=;
 b=iOGxMWB3//CzdZOxTrhD7uIC+HLcbp+DApr2qvs6VYIcp7ij7LYE8xlUonIJnAs0wSdgEnGSouMQLbHPagw6JTVe3EuZSnTrcfdnyMcB0gtLVb5W8TH5dCeBNRPxiT92vzrwK6zGX96d/YmGYI8Fo8+unbwsQttZVaG/0lRXJFEo8UpVdNXGDhrOopYJC/r7joIAM4VxkXnRwknp1CNk1tsy4KW0vtfW3Yv0vJ8YpTIsrR2eow7eUA5hGVNlmckc05D8KKjYnbk1y+ChuOLnH52+DlD/Avt8eQJqy5KjMy+j+Q6D8UP239Y94wrCL2laslSEWEGcL+0XnN4X/5AjEw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=WKNIonxcahKNHrmTDcEKSy7WRj7ghI/H77ZzKPmKQEo=;
 b=D8O+SA5ghp0nvTJ5eYCYvSDKJiBph2QTu/2GuG13Q0oJE8IACc8ZTUQfvhujXBeBgeFd6rDP3HBSmHSZ+QNOWFR0o9+2yXUHPhKTe79MbtBNp8FrAJTrTk1JwDPy/NyM9J056Y+Z41lpclCS9pblsaSzDt9X6i7a7dXPCoyeiz4=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Jan Beulich <jbeulich@suse.com>, Wei Liu <wl@xen.org>, George Dunlap
	<George.Dunlap@citrix.com>, Julien Grall <julien@xen.org>, Stefano Stabellini
	<sstabellini@kernel.org>
Subject: Re: [PATCH v3 0/3] retpoline: add clang support + Kconfig selectable
Thread-Topic: [PATCH v3 0/3] retpoline: add clang support + Kconfig selectable
Thread-Index: AQHYJNSfcDAKqGNVbkqTBpzLddC15ayZc12A
Date: Fri, 18 Feb 2022 15:45:12 +0000
Message-ID: <9500afea-3ca0-deb9-9d48-4983454b1c4f@citrix.com>
References: <20220218143416.34475-1-roger.pau@citrix.com>
In-Reply-To: <20220218143416.34475-1-roger.pau@citrix.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: a879f4e9-fd03-4363-a93a-08d9f2f5a67b
x-ms-traffictypediagnostic: PH0PR03MB6478:EE_
x-microsoft-antispam-prvs: <PH0PR03MB6478B38562FDC1499E9144BCBA379@PH0PR03MB6478.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:2887;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: m7K2WfhS4E6WSG+G+5BwPKQgoWH1GkBEvEPZH6Kxw8w6mQ59iG4/jL+kJf7ON0NZ/lnOxWnv1SPfA2oq33w/jg5dhnRSbbwL8r+TPqpM4+pFv8CV9q4Ae8k76UtD5yhreXzmRAUKBWB5yhSr/5k/2No7HwbJKTT8Yn8FA1/JwGig/ZsgnU29kumvJh4Uqbz7FdkhebJkRFrfriD4GU5L/nOXtG/MNv/E6Tz9u6925p+oBZVPA+tjwYSZc3AXZKto1s8IG3SEpMzN13cteWA2Jsuo3Rjhltv8xdYjBDwxuLWzJUMHsG8XsZ2dmElNwGa423btG2Srh0DMgmZSmHYNuMJaGs/FM/+nKyzpGe8dEl8MOoUWdmGaO1PkQWRwa1o+mr/knyr+lAPcNMk+OgjzOKPJq7fi/+buVrtTFYj//8cgNhKCuZYIPjAeRtzFp+5UAT1O95JsUslGDomP/gpSXkgYzZlNLRJz2YoNGv4MXgmt0KNiN55Ke1PAWHToWL4pE/SYVc5xLdUqfaH7Bkt8y/65C0hmwcMkI3P3av/2QhR3zgyecJaeZaePC/Hi2fRBUg9Jw1z4gbWrPFHy36H9Q70SzAFn8jg2Q6HKvrVxXGpNqBjpDj0FkLfeCbztDLKs6mACAQpYGu/6XfcNHVQHyTl8A56BrDP3ogetW7OYxKlU6lknwwr8AxUS27i3GViQeL5+ydST+mpjBfDzAlEYwqJVKGJmiEsCKjcmM9A1smc4Hw0SA3VSv2Id1Chd0t4QJg2K/v12Yab1TLnSwv/ySA==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(2906002)(4326008)(8676002)(38100700002)(8936002)(66946007)(4744005)(64756008)(76116006)(66476007)(66556008)(66446008)(71200400001)(2616005)(186003)(26005)(31686004)(36756003)(53546011)(508600001)(6506007)(6512007)(38070700005)(86362001)(82960400001)(31696002)(6486002)(110136005)(5660300002)(91956017)(54906003)(122000001)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?OGdUaUd3RDlaZURYS3gwbkxpYlZicFVmN0pHK1N4K2ZSdzVTRXZPb0pnc3lI?=
 =?utf-8?B?YzFQUWpmUEVXc2ZKMFd1K3RhWW5HUExxUHlYanNFcTdXLzJhL2IxNHd0N2Fq?=
 =?utf-8?B?Q2VRQ05mdVQ2alNsQnZqUVhWYTlJUjlyMjdIbm56c3UvaXVOenFsWGlQbng2?=
 =?utf-8?B?cWdIRG93N1kxL2hMVzhsMDZTK1hncTJ0U3NjRzZaclB2WlVsOXBhejVMMnFp?=
 =?utf-8?B?RDdtdEEvVXdvUjFUSG1XVjB5WXZXSzVnYVJ3UkJrdGZ5M0EyVmJVZEU0ZlhO?=
 =?utf-8?B?ZVFsZzRIQ2pFYWpsWnlRcCt4cWNKdXZ1bHpwdm50RUJsSnAzaWhCU0Y1Lzlx?=
 =?utf-8?B?MVVTbHZIYzBSSDlvdWdmQkZJMDRYVThNUkVVRXJ3bGYwY2xRMU9EdzhrQndF?=
 =?utf-8?B?VnprcXc3NUZmMEMzaXJ2akU1TGtxTHF4ZElzTXV4MElpdkpiZVdoY3pkMzFC?=
 =?utf-8?B?amhJeStWN3MrVU0zcFluWnRMSFdlbUVCaFlKYmxtb1JKODJSODBBbmROa1NO?=
 =?utf-8?B?VmwvMHAvSkJWOG9aYnRSQkphd2dCU1Z4YTZpYzNRY1ZDVWVIS05iRWtLTytq?=
 =?utf-8?B?MVZzN3UxUHNRUDczWFpJY1BaYURweXFnUTZSQjRUZTFYSi94T1hJK25NZDAy?=
 =?utf-8?B?RVBMZkdPd1JrRjBLcTNScDJiQVFVaWZoOERBUnJvSVZDT25tWTdySElzUlcy?=
 =?utf-8?B?dkx1YjhucnVKUEI3VmZPOUp4NUEzbnVmMXRBbE45TVhUYUdXN2FMN1RXSTVP?=
 =?utf-8?B?czJ0TFQ1eWRMOGZPbEh1WUc3TU9YZ3lLa0JNZldnS2dPYTB6RjgyOG1ZWjRM?=
 =?utf-8?B?WG9Xb0VLZFJpL3lHa056QUZsOFE0M1luaEtmdWRxMVpTMG80UFRZVDJUM1BS?=
 =?utf-8?B?OVhZR0hjZngvaVl4TXRjZit0VWYrQnZrMVA3M0o5RlZzSzhtVXNiL1dydmNv?=
 =?utf-8?B?QWxNZk14VDdDWlVoVTcvZXFhd0N6cDdqdmVuNnZVUEk0SGFoRE9tdVphUkIv?=
 =?utf-8?B?MmtxRDZYeEQ0Tkx0dGFia3o5SWpIQ3dGdXd5U3NSSnhtaUh5aGRYTnZPM2gr?=
 =?utf-8?B?OTZWMmh3U25USnBWTDBvZVdXMlAzaWNBNHd1MWVjcHBDOTdrbjBQS0dDWVZh?=
 =?utf-8?B?UnQrTHhPeUhQRnlTNkpzbXI2djh2Uy81WmdhQWxsSnRlMmhoZHhnQmlCODha?=
 =?utf-8?B?SzV2N1MvOFhFN3BUZFdlN0pvd0ZmcGJXTnpUL2Nxdyt5UUJISmRDZzVzdVZ0?=
 =?utf-8?B?aWZ2VUVPQnJuODJGeEFqdlhiS2t0NHlaZC9EajhseG9QNStVOUFid2lHVERp?=
 =?utf-8?B?UHZ6YitLaE1WWnVDWmZOeWJkRDloUGs0NnVqdUMxWndMUUszdTAvaVFvY1ps?=
 =?utf-8?B?cFlLcTBTMnZ4N2hUcXRFdFRRVG1kWnFpVDRLSS9uRHJCQ2NnZkdzTmo4U05V?=
 =?utf-8?B?eVljZzBvU3FvRWI0NWkweHRzOXE3K0JRdnZ5K2svU2toOXllbVRFYXQyTnI5?=
 =?utf-8?B?ZnRFQ1RhWHFzSWNXclNueThCOVVNWk5IaDlmdmViZDh5YnNYVHlZa0U0ei92?=
 =?utf-8?B?Wk9nMk5Td2pneHZWRmF5OURIeFBaeDdHODgxYUErc1JFakh4MEpLUm16Q0ha?=
 =?utf-8?B?VEZJSFVNWWhOWFVVQ1h1MFYvcC8weWN1bkNra3BRWmNsdmVjWHRIWEVtQWYy?=
 =?utf-8?B?emwveElieGptQjgrY2ZHQ2d3VjhiZk5ja1U0UnVMU3FDL1hrL1JiUG1rYlJx?=
 =?utf-8?B?OHpMUjVrYm53ZE5UVGF5WEpwSWdVejB6eENjMFdsWkVOOHZQZUVUWmdaTDVJ?=
 =?utf-8?B?eFdkVXVYRVNscGhrMm52ZFl5Y1gvdXBUeEQvSzduVVFTVy9GOFlyUnRLaUtz?=
 =?utf-8?B?UElmOUpZeWJIaGxWUXAxMzJaZjZERGR6UDJoMGVYVFNMUG1ZQlI2SGs1aFB0?=
 =?utf-8?B?c0wxWXpjeHk1czJ4b0VJS3FDcGRXc3lGc3k2MkRrVGozS1Q5WmdXK0NOTUJJ?=
 =?utf-8?B?ekRYaVdSbktLSWRBNmJZVlpENjgxMVNVZ0JrK2F6MjFJMDJZbDZBQ3V4d290?=
 =?utf-8?B?NGl5bGJDU3lYVGhzaDZ5Tjl1c0xkUjNZdmxtZ2JlemdnY0hReXNWaHRZMEZZ?=
 =?utf-8?B?VXRFWFR1VGVnUlRtdXJrMXpKTllsUDdTeFd6QmxlR1NKVnV2bDAvdExpUUN0?=
 =?utf-8?B?N2JTMVorWHkzTDk2djd6aHBVbVhyNGpxMzF4eDJwZXFKUWx3d3VNUkxkc05V?=
 =?utf-8?B?WTMyRDgyb2xMdkZkMWdtc0Rnc3pBPT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <CF285C9EB2CE9C489D5A55CAF4635634@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a879f4e9-fd03-4363-a93a-08d9f2f5a67b
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Feb 2022 15:45:12.2886
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: EG5Y/7stXaCoATTgztkH8xxTezY62KZd+2325EN/95uD9f8lixpBXf8KqY5OvgUBig0+y205AAjVwcCRoKrrzLjxtg4UbwOoaYj0RvTDk4g=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6478
X-OriginatorOrg: citrix.com

T24gMTgvMDIvMjAyMiAxNDozNCwgUm9nZXIgUGF1IE1vbm5lIHdyb3RlOg0KPiBIZWxsbywNCj4N
Cj4gVGhlIGZvbGxvd2luZyBzZXJpZXMgYWRkcyByZXRwb2xpbmUgc3VwcG9ydCBmb3IgY2xhbmcg
YnVpbGRzLCBhbmQgYWxzbw0KPiBhbGxvd3MgdGhlIHVzZXIgdG8gc2VsZWN0IHdoZXRoZXIgdG8g
ZW5hYmxlIHJldHBvbGluZSBzdXBwb3J0IGF0IGJ1aWxkDQo+IHRpbWUgdmlhIGEgbmV3IEtjb25m
aWcgb3B0aW9uLg0KPg0KPiBJJ3ZlIHRyaWVkIGFkZGluZyBhIHN1aXRhYmxlIGRlc2NyaXB0aW9u
IHRvIHRoZSBLY29uZmlnIG9wdGlvbiwgYnV0IEknbQ0KPiBzdXJlIHRoZXJlJ3Mgcm9vbSBmb3Ig
aW1wcm92ZW1lbnQuDQo+DQo+IFRoYW5rcywgUm9nZXIuDQo+DQo+IFJvZ2VyIFBhdSBNb25uZSAo
Myk6DQo+ICAgeDg2L3JldHBvbGluZTogc3BsaXQgcmV0cG9saW5lIGNvbXBpbGVyIHN1cHBvcnQg
aW50byBzZXBhcmF0ZSBvcHRpb24NCj4gICB4ODYvY2xhbmc6IGFkZCByZXRwb2xpbmUgc3VwcG9y
dA0KPiAgIHg4Ni9LY29uZmlnOiBpbnRyb2R1Y2Ugb3B0aW9uIHRvIHNlbGVjdCByZXRwb2xpbmUg
dXNhZ2UNCg0KVGhhbmtzLsKgIEkgdGhpbmsgdGhhdCdzIGxvb2tpbmcgbXVjaCBiZXR0ZXIgSU1P
Lg0KDQpPbmUgdGhpbmcsIHdlIHdhbnQgQ0NfSEFTXyogZm9yIGNvbnNpc3RlbmN5LsKgIEkgY2Fu
IGZpeCB0aGlzIG9uIGNvbW1pdC4NCg0KQWNrZWQtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJldy5j
b29wZXIzQGNpdHJpeC5jb20+DQo=


From xen-devel-bounces@lists.xenproject.org Fri Feb 18 16:28:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 18 Feb 2022 16:28:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275570.471502 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL67B-0007Fn-U8; Fri, 18 Feb 2022 16:28:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275570.471502; Fri, 18 Feb 2022 16:28:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL67B-0007Fg-QG; Fri, 18 Feb 2022 16:28:13 +0000
Received: by outflank-mailman (input) for mailman id 275570;
 Fri, 18 Feb 2022 16:28:13 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=4/tq=TB=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nL67B-0007Fa-6F
 for xen-devel@lists.xenproject.org; Fri, 18 Feb 2022 16:28:13 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c2ea28c8-90d7-11ec-8723-dd0c611c5f35;
 Fri, 18 Feb 2022 17:28:11 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id C285861F55;
 Fri, 18 Feb 2022 16:28:09 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id D6951C340E9;
 Fri, 18 Feb 2022 16:28:08 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c2ea28c8-90d7-11ec-8723-dd0c611c5f35
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1645201689;
	bh=tu/rlcE4PGLfIX332wCU3ndCRs3Cg+5vl0zzYUA9bec=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=H73x7oyUe+hzzSJMir/3qnUxce5JRG5fNL2ZbaF6+wR8x/zT1Nbk1qvJl41wdFqKE
	 H5AlZVUVCGj2RCfmEBh3hL2Al0WPUPqhiXfe7NtPSmOTPQHVHLlftwr03ugl96iu0C
	 XmVvqxQFRDuy26YZtQWGl65k+oUmQ2msl1YAaO9iXRny/MepkyyG4/pOWio1CTYXS3
	 s6tu+FSA6CAidso92NTMxkFNbiGzSwRZwbtDNerISOLnid79yafefIerD8tlEzryHl
	 /MybXsUsar1wt/nx6nOOnqNvw86xlYw4V5HgnAyBV5RKLVkzGqXYvPpIzdlesNbP4X
	 J+2n3Wyz/yoJA==
Date: Fri, 18 Feb 2022 08:28:07 -0800 (PST)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Anthony PERARD <anthony.perard@citrix.com>
cc: Andrew Cooper <andrew.cooper3@citrix.com>, 
    Xen-devel <xen-devel@lists.xenproject.org>, 
    Doug Goldstein <cardoe@cardoe.com>, Wei Liu <wl@xen.org>, 
    =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    Jan Beulich <JBeulich@suse.com>
Subject: Re: [PATCH] CI: Add gnu grep to alpine containers
In-Reply-To: <Yg+vmEsWzurilMNy@perard.uk.xensource.com>
Message-ID: <alpine.DEB.2.22.394.2202180826310.239973@ubuntu-linux-20-04-desktop>
References: <20220218131740.30922-1-andrew.cooper3@citrix.com> <Yg+vmEsWzurilMNy@perard.uk.xensource.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-574380469-1645201597=:239973"
Content-ID: <alpine.DEB.2.22.394.2202180827140.239973@ubuntu-linux-20-04-desktop>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-574380469-1645201597=:239973
Content-Type: text/plain; CHARSET=UTF-8
Content-Transfer-Encoding: 8BIT
Content-ID: <alpine.DEB.2.22.394.2202180827141.239973@ubuntu-linux-20-04-desktop>

On Fri, 18 Feb 2022, Anthony PERARD wrote:
> On Fri, Feb 18, 2022 at 01:17:40PM +0000, Andrew Cooper wrote:
> > A forthcoming change is going to want more support than busybox's grep can
> > provide.
> > 
> > Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> > ---
> > CC: Doug Goldstein <cardoe@cardoe.com>
> > CC: Wei Liu <wl@xen.org>
> > CC: Anthony PERARD <anthony.perard@citrix.com>
> > CC: Roger Pau Monné <roger.pau@citrix.com>
> > CC: Stefano Stabellini <sstabellini@kernel.org>
> > CC: Jan Beulich <JBeulich@suse.com>
> > 
> > I've already rebuilt the containers and confirmed that the build is still fine.
> 
> Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>

Good for me too. Out of curiousity, what is that is not working with
busybox's grep? Is it regex?
--8323329-574380469-1645201597=:239973--


From xen-devel-bounces@lists.xenproject.org Fri Feb 18 16:31:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 18 Feb 2022 16:31:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275577.471512 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL6AO-0000BV-C9; Fri, 18 Feb 2022 16:31:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275577.471512; Fri, 18 Feb 2022 16:31:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL6AO-0000BO-9P; Fri, 18 Feb 2022 16:31:32 +0000
Received: by outflank-mailman (input) for mailman id 275577;
 Fri, 18 Feb 2022 16:31:30 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=N23X=TB=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1nL6AM-0000BI-TY
 for xen-devel@lists.xenproject.org; Fri, 18 Feb 2022 16:31:30 +0000
Received: from ppsw-30.csi.cam.ac.uk (ppsw-30.csi.cam.ac.uk [131.111.8.130])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 38bb1627-90d8-11ec-8eb8-a37418f5ba1a;
 Fri, 18 Feb 2022 17:31:29 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:57668)
 by ppsw-30.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.136]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1nL6AF-000sOE-dI (Exim 4.95) (return-path <amc96@srcf.net>);
 Fri, 18 Feb 2022 16:31:23 +0000
Received: from [192.168.1.10] (host-92-12-45-187.as13285.net [92.12.45.187])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id EC1771FACB;
 Fri, 18 Feb 2022 16:31:22 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 38bb1627-90d8-11ec-8eb8-a37418f5ba1a
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <7ad6214b-f4d0-ea06-fa3e-3778bb8bc25a@srcf.net>
Date: Fri, 18 Feb 2022 16:31:22 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH] CI: Add gnu grep to alpine containers
Content-Language: en-GB
To: Stefano Stabellini <sstabellini@kernel.org>,
 Anthony PERARD <anthony.perard@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 Xen-devel <xen-devel@lists.xenproject.org>,
 Doug Goldstein <cardoe@cardoe.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Jan Beulich <JBeulich@suse.com>
References: <20220218131740.30922-1-andrew.cooper3@citrix.com>
 <Yg+vmEsWzurilMNy@perard.uk.xensource.com>
 <alpine.DEB.2.22.394.2202180826310.239973@ubuntu-linux-20-04-desktop>
From: Andrew Cooper <amc96@srcf.net>
In-Reply-To: <alpine.DEB.2.22.394.2202180826310.239973@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 18/02/2022 16:28, Stefano Stabellini wrote:
> On Fri, 18 Feb 2022, Anthony PERARD wrote:
>> On Fri, Feb 18, 2022 at 01:17:40PM +0000, Andrew Cooper wrote:
>>> A forthcoming change is going to want more support than busybox's grep can
>>> provide.
>>>
>>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>>> ---
>>> CC: Doug Goldstein <cardoe@cardoe.com>
>>> CC: Wei Liu <wl@xen.org>
>>> CC: Anthony PERARD <anthony.perard@citrix.com>
>>> CC: Roger Pau Monné <roger.pau@citrix.com>
>>> CC: Stefano Stabellini <sstabellini@kernel.org>
>>> CC: Jan Beulich <JBeulich@suse.com>
>>>
>>> I've already rebuilt the containers and confirmed that the build is still fine.
>> Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>
> Good for me too. Out of curiousity, what is that is not working with
> busybox's grep? Is it regex?

No.  Binary searching, which we want to use in a build-time check for
CET-IBT.

https://lore.kernel.org/xen-devel/8c6d9714-7e45-1603-a5ad-d49fc060304e@srcf.net/

~Andrew


From xen-devel-bounces@lists.xenproject.org Fri Feb 18 17:30:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 18 Feb 2022 17:30:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275590.471562 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL75G-0006td-Aa; Fri, 18 Feb 2022 17:30:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275590.471562; Fri, 18 Feb 2022 17:30:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL75G-0006tU-79; Fri, 18 Feb 2022 17:30:18 +0000
Received: by outflank-mailman (input) for mailman id 275590;
 Fri, 18 Feb 2022 17:30:16 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=nO3j=TB=citrix.com=prvs=0411eaaf8=Jane.Malalane@srs-se1.protection.inumbo.net>)
 id 1nL75E-0006rZ-6N
 for xen-devel@lists.xenproject.org; Fri, 18 Feb 2022 17:30:16 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6c8f5e0e-90e0-11ec-8723-dd0c611c5f35;
 Fri, 18 Feb 2022 18:30:13 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6c8f5e0e-90e0-11ec-8723-dd0c611c5f35
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645205411;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=/ZduhxfybYUOigZ7XcderhnCORrUGSi1ysw6fK2cCVc=;
  b=ayRwRR6nomJZdEZRxYCfRTieV2DWAILXrLW0Uw0qMgnV9J7IFuCjdXi7
   Thh3gz7NZP1mnzh0bN14rJDPmtUNui/iI5FBC4MOw8ai4Dd84nWI8IfQM
   LtA4oSfEnzvI/B2o4U9Lu9NY3vD9/rJ+GQLriMJ+lu5mEWA+nY9VWNPt5
   U=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 64941224
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:M/XMp6DFzVVfkhVW/8njw5YqxClBgxIJ4kV8jS/XYbTApGwh1jBSz
 GBKWTiGafuMM2v3ftxwadyy90xV65fXnNBiQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YhFWeIdA970Ug5w7Rg0tYy6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPh9y
 o126Y6sZTsCO5+Qw/wYeRRySS1haPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguwBJc/meqYWvnhkxDfUJf0nXYrCU+PB4towMDIY2JwfQa+EP
 ZZxhTxHaBLjZhhWE0ktJbkDob6TuyXxcBNztwfAzUYwyzeKl1EguFT3C/LOYcCDT8hRmkeep
 0rF8n7/DxVcM8aQoRKH73ati+nnjS79HoUIG9WQyPluh1GCw30JPzcfX1C7vPqRh1a3XpRUL
 El80iYns6Ua7kGgSdj5GRqirxasvBEGXMFLO/Yn8wzLwa3Riy6JC25BQjNfZdgOsM4tWSdsx
 lKPh8nuBzFkrPuSU3313qiQhSO/P24SN2BqTS0OQBYB4tLjiJoulR+JRdFmeJNZlfWsR2u2m
 WrT6nFj2fND1qbnyplX43jLgWqX+orVYjIe4zeLBXqgxA5TPoK6MtnABUfg0d5MK4OQT1+kt
 XcCmtSD4O1mMaxhhBBhU81WQuj3uq/t3Cn0xAc2QsJ/r2jFF2uLINgIiAySMnuFJSrtldXBR
 EbI8T1c65ZIVJdBRf8mOtnhYyjGIEWJKDgEahw2RoYfCnSSXFXelM2LWaJ29zm8+KTLuftiU
 ap3ie72UR4n5V1PlVJavds1374x3TwZzmjOX539xBnP+ePAOCPME+tdYQfQN7pRAEa4TOP9q
 oc32yyikUg3bQEDSnOPrd57wa4idhDX+qwaW+QIL7Xec2KK6UkqCuPLwKNJRmCWt/89qws8x
 VnkAhUw4AOm3RXvcFzWAlg+OOKHdcsu9hoTYH1zVWtELlB+OO5DGo9ELMBpFVTmncQ+pcNJo
 w4tIZvYWa0XEmydk9nfBLGkxLFfmN2QrVrmF0KYjPIXJvaMmyShFgfYQzbS
IronPort-HdrOrdr: A9a23:OHNv1qEFBgkALBQopLqE0MeALOsnbusQ8zAXP0AYc3Jom6uj5r
 mTdZUgpHnJYVkqOE3I9ertBEDEewK4yXcX2/h3AV7BZniEhILAFugLhuGO/9SjIVybygc079
 YZT0EUMrzN5DZB4voSmDPIceod/A==
X-IronPort-AV: E=Sophos;i="5.88,379,1635220800"; 
   d="scan'208";a="64941224"
From: Jane Malalane <jane.malalane@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Jane Malalane <jane.malalane@citrix.com>, Wei Liu <wl@xen.org>, "Anthony
 PERARD" <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, "Andrew
 Cooper" <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, Julien Grall
	<julien@xen.org>, "Stefano Stabellini" <sstabellini@kernel.org>, Christian
 Lindig <christian.lindig@citrix.com>, David Scott <dave@recoil.org>,
	"Volodymyr Babchuk" <Volodymyr_Babchuk@epam.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>
Subject: [PATCH v3 2/2] x86/xen: Allow per-domain usage of hardware virtualized APIC
Date: Fri, 18 Feb 2022 17:29:43 +0000
Message-ID: <20220218172943.12182-3-jane.malalane@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220218172943.12182-1-jane.malalane@citrix.com>
References: <20220218172943.12182-1-jane.malalane@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

Introduce a new per-domain creation x86 specific flag to
select whether hardware assisted virtualization should be used for
x{2}APIC.

A per-domain option is added to xl in order to select the usage of
x{2}APIC hardware assisted vitualization, as well as a global
configuration option.

Having all APIC interaction exit to Xen for emulation is slow and can
induce much overhead. Hardware can speed up x{2}APIC by decoding the
APIC access and providing a VM exit with a more specific exit reason
than a regular EPT fault or by altogether avoiding a VM exit.

On the other hand, being able to disable x{2}APIC hardware assisted
vitualization can be useful for testing and debugging purposes.

Note: vmx_install_vlapic_mapping doesn't require modifications
regardless of whether the guest has virtualize_apic_accesses enabled
or not, i.e., setting the the APIC_ACCESS_ADDR VMCS field is fine so
long as virtualize_apic_accesses is supported by the CPU.

Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Jane Malalane <jane.malalane@citrix.com>
---
CC: Wei Liu <wl@xen.org>
CC: Anthony PERARD <anthony.perard@citrix.com>
CC: Juergen Gross <jgross@suse.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
CC: George Dunlap <george.dunlap@citrix.com>
CC: Jan Beulich <jbeulich@suse.com>
CC: Julien Grall <julien@xen.org>
CC: Stefano Stabellini <sstabellini@kernel.org>
CC: Christian Lindig <christian.lindig@citrix.com>
CC: David Scott <dave@recoil.org>
CC: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
CC: "Roger Pau Monné" <roger.pau@citrix.com>

v3:
 * Change info in xl.cfg to better express reality and fix
   capitalization of x{2}apic
 * Move "physinfo" variable definition to the beggining of
   libxl__domain_build_info_setdefault()
 * Reposition brackets in if statement to match libxl coding style
 * Shorten logic in libxl__arch_domain_build_info_setdefault()
 * Correct dprintk message in arch_sanitise_domain_config()
 * Make appropriate changes in vmx_vlapic_msr_changed() and
   cpuid_hypervisor_leaves() for amended "assisted_x2apic" bit
 * Remove unneeded parantheses

v2:
 * Add a LIBXL_HAVE_ASSISTED_APIC macro
 * Pass xcpyshinfo as a pointer in libxl__arch_get_physinfo
 * Add a return statement in now "int"
   libxl__arch_domain_build_info_setdefault()
 * Preserve libxl__arch_domain_build_info_setdefault 's location in
   libxl_create.c
 * Correct x{2}apic default setting logic in
   libxl__arch_domain_prepare_config()
 * Correct logic for parsing assisted_x{2}apic host/guest options in
   xl_parse.c and initialize them to -1 in xl.c
 * Use guest options directly in vmx_vlapic_msr_changed
 * Fix indentation of bool assisted_x{2}apic in struct hvm_domain
 * Add a change in xenctrl_stubs.c to pass xenctrl ABI checks
---
 docs/man/xl.cfg.5.pod.in              | 19 +++++++++++++++++++
 docs/man/xl.conf.5.pod.in             | 12 ++++++++++++
 tools/golang/xenlight/helpers.gen.go  | 12 ++++++++++++
 tools/golang/xenlight/types.gen.go    |  2 ++
 tools/include/libxl.h                 |  7 +++++++
 tools/libs/light/libxl_arch.h         |  5 +++--
 tools/libs/light/libxl_arm.c          |  7 +++++--
 tools/libs/light/libxl_create.c       | 22 +++++++++++++---------
 tools/libs/light/libxl_types.idl      |  2 ++
 tools/libs/light/libxl_x86.c          | 28 ++++++++++++++++++++++++++--
 tools/ocaml/libs/xc/xenctrl.ml        |  2 ++
 tools/ocaml/libs/xc/xenctrl.mli       |  2 ++
 tools/ocaml/libs/xc/xenctrl_stubs.c   |  2 +-
 tools/xl/xl.c                         |  8 ++++++++
 tools/xl/xl.h                         |  2 ++
 tools/xl/xl_parse.c                   | 16 ++++++++++++++++
 xen/arch/x86/domain.c                 | 28 +++++++++++++++++++++++++++-
 xen/arch/x86/hvm/vmx/vmcs.c           |  4 ++++
 xen/arch/x86/hvm/vmx/vmx.c            |  8 ++++----
 xen/arch/x86/include/asm/hvm/domain.h |  6 ++++++
 xen/arch/x86/traps.c                  |  8 ++++----
 xen/include/public/arch-x86/xen.h     |  2 ++
 22 files changed, 179 insertions(+), 25 deletions(-)

diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in
index b98d161398..dcca564a23 100644
--- a/docs/man/xl.cfg.5.pod.in
+++ b/docs/man/xl.cfg.5.pod.in
@@ -1862,6 +1862,25 @@ firmware tables when using certain older guest Operating
 Systems. These tables have been superseded by newer constructs within
 the ACPI tables.
 
+=item B<assisted_xapic=BOOLEAN>
+
+B<(x86 only)> Enables or disables hardware assisted virtualization for
+xAPIC. With this option enabled, a memory-mapped APIC access will be
+decoded by hardware and either issue a more specific VM exit than just
+an EPT fault, or altogether avoid a VM exit. Notice full
+virtualization for xAPIC can only be achieved if hardware supports
+“APIC-register virtualization” and “virtual-interrupt delivery”. The
+default is settable via L<xl.conf(5)>.
+
+=item B<assisted_x2apic=BOOLEAN>
+
+B<(x86 only)> Enables or disables hardware assisted virtualization for
+x2APIC. With this option enabled, an MSR-Based APIC access will
+either issue a VM exit or altogether avoid one. Notice full
+virtualization for x2APIC can only be achieved if hardware supports
+“APIC-register virtualization” and “virtual-interrupt delivery”. The
+default is settable via L<xl.conf(5)>.
+
 =item B<nx=BOOLEAN>
 
 B<(x86 only)> Hides or exposes the No-eXecute capability. This allows a guest
diff --git a/docs/man/xl.conf.5.pod.in b/docs/man/xl.conf.5.pod.in
index df20c08137..95d136d1ea 100644
--- a/docs/man/xl.conf.5.pod.in
+++ b/docs/man/xl.conf.5.pod.in
@@ -107,6 +107,18 @@ Sets the default value for the C<max_grant_version> domain config value.
 
 Default: maximum grant version supported by the hypervisor.
 
+=item B<assisted_xapic=BOOLEAN>
+
+If enabled, domains will use xAPIC hardware assisted virtualization by default.
+
+Default: enabled if supported.
+
+=item B<assisted_x2apic=BOOLEAN>
+
+If enabled, domains will use x2APIC hardware assisted virtualization by default.
+
+Default: enabled if supported.
+
 =item B<vif.default.script="PATH">
 
 Configures the default hotplug script used by virtual network devices.
diff --git a/tools/golang/xenlight/helpers.gen.go b/tools/golang/xenlight/helpers.gen.go
index dd4e6c9f14..dece545ee0 100644
--- a/tools/golang/xenlight/helpers.gen.go
+++ b/tools/golang/xenlight/helpers.gen.go
@@ -1120,6 +1120,12 @@ x.ArchArm.Vuart = VuartType(xc.arch_arm.vuart)
 if err := x.ArchX86.MsrRelaxed.fromC(&xc.arch_x86.msr_relaxed);err != nil {
 return fmt.Errorf("converting field ArchX86.MsrRelaxed: %v", err)
 }
+if err := x.ArchX86.AssistedXapic.fromC(&xc.arch_x86.assisted_xapic);err != nil {
+return fmt.Errorf("converting field ArchX86.AssistedXapic: %v", err)
+}
+if err := x.ArchX86.AssistedX2Apic.fromC(&xc.arch_x86.assisted_x2apic);err != nil {
+return fmt.Errorf("converting field ArchX86.AssistedX2Apic: %v", err)
+}
 x.Altp2M = Altp2MMode(xc.altp2m)
 x.VmtraceBufKb = int(xc.vmtrace_buf_kb)
 if err := x.Vpmu.fromC(&xc.vpmu);err != nil {
@@ -1605,6 +1611,12 @@ xc.arch_arm.vuart = C.libxl_vuart_type(x.ArchArm.Vuart)
 if err := x.ArchX86.MsrRelaxed.toC(&xc.arch_x86.msr_relaxed); err != nil {
 return fmt.Errorf("converting field ArchX86.MsrRelaxed: %v", err)
 }
+if err := x.ArchX86.AssistedXapic.toC(&xc.arch_x86.assisted_xapic); err != nil {
+return fmt.Errorf("converting field ArchX86.AssistedXapic: %v", err)
+}
+if err := x.ArchX86.AssistedX2Apic.toC(&xc.arch_x86.assisted_x2apic); err != nil {
+return fmt.Errorf("converting field ArchX86.AssistedX2Apic: %v", err)
+}
 xc.altp2m = C.libxl_altp2m_mode(x.Altp2M)
 xc.vmtrace_buf_kb = C.int(x.VmtraceBufKb)
 if err := x.Vpmu.toC(&xc.vpmu); err != nil {
diff --git a/tools/golang/xenlight/types.gen.go b/tools/golang/xenlight/types.gen.go
index 87be46c745..253c9ad93d 100644
--- a/tools/golang/xenlight/types.gen.go
+++ b/tools/golang/xenlight/types.gen.go
@@ -520,6 +520,8 @@ Vuart VuartType
 }
 ArchX86 struct {
 MsrRelaxed Defbool
+AssistedXapic Defbool
+AssistedX2Apic Defbool
 }
 Altp2M Altp2MMode
 VmtraceBufKb int
diff --git a/tools/include/libxl.h b/tools/include/libxl.h
index 333ffad38d..1c83cae711 100644
--- a/tools/include/libxl.h
+++ b/tools/include/libxl.h
@@ -535,6 +535,13 @@
 #define LIBXL_HAVE_PHYSINFO_ASSISTED_APIC 1
 
 /*
+ * LIBXL_HAVE_ASSISTED_APIC indicates that libxl_domain_build_info has
+ * assisted_x{2}apic fields, for enabling hardware assisted virtualization for
+ * x{2}apic per domain.
+ */
+#define LIBXL_HAVE_ASSISTED_APIC 1
+
+/*
  * libxl ABI compatibility
  *
  * The only guarantee which libxl makes regarding ABI compatibility
diff --git a/tools/libs/light/libxl_arch.h b/tools/libs/light/libxl_arch.h
index 207ceac6a1..03b89929e6 100644
--- a/tools/libs/light/libxl_arch.h
+++ b/tools/libs/light/libxl_arch.h
@@ -71,8 +71,9 @@ void libxl__arch_domain_create_info_setdefault(libxl__gc *gc,
                                                libxl_domain_create_info *c_info);
 
 _hidden
-void libxl__arch_domain_build_info_setdefault(libxl__gc *gc,
-                                              libxl_domain_build_info *b_info);
+int libxl__arch_domain_build_info_setdefault(libxl__gc *gc,
+                                             libxl_domain_build_info *b_info,
+                                             const libxl_physinfo *physinfo);
 
 _hidden
 int libxl__arch_passthrough_mode_setdefault(libxl__gc *gc,
diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c
index 39fdca1b49..ba5b8f433f 100644
--- a/tools/libs/light/libxl_arm.c
+++ b/tools/libs/light/libxl_arm.c
@@ -1384,8 +1384,9 @@ void libxl__arch_domain_create_info_setdefault(libxl__gc *gc,
     }
 }
 
-void libxl__arch_domain_build_info_setdefault(libxl__gc *gc,
-                                              libxl_domain_build_info *b_info)
+int libxl__arch_domain_build_info_setdefault(libxl__gc *gc,
+                                             libxl_domain_build_info *b_info,
+                                             const libxl_physinfo *physinfo)
 {
     /* ACPI is disabled by default */
     libxl_defbool_setdefault(&b_info->acpi, false);
@@ -1399,6 +1400,8 @@ void libxl__arch_domain_build_info_setdefault(libxl__gc *gc,
     memset(&b_info->u, '\0', sizeof(b_info->u));
     b_info->type = LIBXL_DOMAIN_TYPE_INVALID;
     libxl_domain_build_info_init_type(b_info, LIBXL_DOMAIN_TYPE_PVH);
+
+    return 0;
 }
 
 int libxl__arch_passthrough_mode_setdefault(libxl__gc *gc,
diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_create.c
index d7a40d7550..4043bc682f 100644
--- a/tools/libs/light/libxl_create.c
+++ b/tools/libs/light/libxl_create.c
@@ -75,6 +75,7 @@ int libxl__domain_build_info_setdefault(libxl__gc *gc,
                                         libxl_domain_build_info *b_info)
 {
     int i, rc;
+    libxl_physinfo info;
 
     if (b_info->type != LIBXL_DOMAIN_TYPE_HVM &&
         b_info->type != LIBXL_DOMAIN_TYPE_PV &&
@@ -264,7 +265,18 @@ int libxl__domain_build_info_setdefault(libxl__gc *gc,
     if (!b_info->event_channels)
         b_info->event_channels = 1023;
 
-    libxl__arch_domain_build_info_setdefault(gc, b_info);
+    rc = libxl_get_physinfo(CTX, &info);
+    if (rc) {
+        LOG(ERROR, "failed to get hypervisor info");
+        return rc;
+    }
+
+    rc = libxl__arch_domain_build_info_setdefault(gc, b_info, &info);
+    if (rc) {
+        LOG(ERROR, "unable to set domain arch build info defaults");
+        return rc;
+    }
+
     libxl_defbool_setdefault(&b_info->dm_restrict, false);
 
     if (b_info->iommu_memkb == LIBXL_MEMKB_DEFAULT)
@@ -457,14 +469,6 @@ int libxl__domain_build_info_setdefault(libxl__gc *gc,
     }
 
     if (b_info->max_grant_version == LIBXL_MAX_GRANT_DEFAULT) {
-        libxl_physinfo info;
-
-        rc = libxl_get_physinfo(CTX, &info);
-        if (rc) {
-            LOG(ERROR, "failed to get hypervisor info");
-            return rc;
-        }
-
         if (info.cap_gnttab_v2)
             b_info->max_grant_version = 2;
         else if (info.cap_gnttab_v1)
diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl
index 42ac6c357b..db5eb0a0b3 100644
--- a/tools/libs/light/libxl_types.idl
+++ b/tools/libs/light/libxl_types.idl
@@ -648,6 +648,8 @@ libxl_domain_build_info = Struct("domain_build_info",[
                                ("vuart", libxl_vuart_type),
                               ])),
     ("arch_x86", Struct(None, [("msr_relaxed", libxl_defbool),
+                               ("assisted_xapic", libxl_defbool),
+                               ("assisted_x2apic", libxl_defbool),
                               ])),
     # Alternate p2m is not bound to any architecture or guest type, as it is
     # supported by x86 HVM and ARM support is planned.
diff --git a/tools/libs/light/libxl_x86.c b/tools/libs/light/libxl_x86.c
index e0a06ecfe3..c377d13b19 100644
--- a/tools/libs/light/libxl_x86.c
+++ b/tools/libs/light/libxl_x86.c
@@ -23,6 +23,14 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc,
     if (libxl_defbool_val(d_config->b_info.arch_x86.msr_relaxed))
         config->arch.misc_flags |= XEN_X86_MSR_RELAXED;
 
+    if (d_config->c_info.type != LIBXL_DOMAIN_TYPE_PV)
+    {
+        if (libxl_defbool_val(d_config->b_info.arch_x86.assisted_xapic))
+            config->arch.misc_flags |= XEN_X86_ASSISTED_XAPIC;
+
+        if (libxl_defbool_val(d_config->b_info.arch_x86.assisted_x2apic))
+            config->arch.misc_flags |= XEN_X86_ASSISTED_X2APIC;
+    }
     return 0;
 }
 
@@ -819,11 +827,27 @@ void libxl__arch_domain_create_info_setdefault(libxl__gc *gc,
 {
 }
 
-void libxl__arch_domain_build_info_setdefault(libxl__gc *gc,
-                                              libxl_domain_build_info *b_info)
+int libxl__arch_domain_build_info_setdefault(libxl__gc *gc,
+                                             libxl_domain_build_info *b_info,
+                                             const libxl_physinfo *physinfo)
 {
     libxl_defbool_setdefault(&b_info->acpi, true);
     libxl_defbool_setdefault(&b_info->arch_x86.msr_relaxed, false);
+
+    if (b_info->type != LIBXL_DOMAIN_TYPE_PV) {
+        libxl_defbool_setdefault(&b_info->arch_x86.assisted_xapic,
+                             physinfo->cap_assisted_xapic);
+        libxl_defbool_setdefault(&b_info->arch_x86.assisted_x2apic,
+                             physinfo->cap_assisted_x2apic);
+    }
+
+    else if (!libxl_defbool_is_default(b_info->arch_x86.assisted_xapic) ||
+             !libxl_defbool_is_default(b_info->arch_x86.assisted_x2apic)) {
+        LOG(ERROR, "Interrupt Controller Virtualization not supported for PV");
+        return ERROR_INVAL;
+    }
+
+    return 0;
 }
 
 int libxl__arch_passthrough_mode_setdefault(libxl__gc *gc,
diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl.ml
index 21783d3622..672a11ceb6 100644
--- a/tools/ocaml/libs/xc/xenctrl.ml
+++ b/tools/ocaml/libs/xc/xenctrl.ml
@@ -50,6 +50,8 @@ type x86_arch_emulation_flags =
 
 type x86_arch_misc_flags =
 	| X86_MSR_RELAXED
+	| X86_ASSISTED_XAPIC
+	| X86_ASSISTED_X2APIC
 
 type xen_x86_arch_domainconfig =
 {
diff --git a/tools/ocaml/libs/xc/xenctrl.mli b/tools/ocaml/libs/xc/xenctrl.mli
index af6ba3d1a0..f9a6aa3a0f 100644
--- a/tools/ocaml/libs/xc/xenctrl.mli
+++ b/tools/ocaml/libs/xc/xenctrl.mli
@@ -44,6 +44,8 @@ type x86_arch_emulation_flags =
 
 type x86_arch_misc_flags =
   | X86_MSR_RELAXED
+  | X86_ASSISTED_XAPIC
+  | X86_ASSISTED_X2APIC
 
 type xen_x86_arch_domainconfig = {
   emulation_flags: x86_arch_emulation_flags list;
diff --git a/tools/ocaml/libs/xc/xenctrl_stubs.c b/tools/ocaml/libs/xc/xenctrl_stubs.c
index 1fa5453043..c0ef57d6b7 100644
--- a/tools/ocaml/libs/xc/xenctrl_stubs.c
+++ b/tools/ocaml/libs/xc/xenctrl_stubs.c
@@ -239,7 +239,7 @@ CAMLprim value stub_xc_domain_create(value xch, value wanted_domid, value config
 
 		cfg.arch.misc_flags = ocaml_list_to_c_bitmap
 			/* ! x86_arch_misc_flags X86_ none */
-			/* ! XEN_X86_ XEN_X86_MSR_RELAXED all */
+			/* ! XEN_X86_ XEN_X86_ASSISTED_X2APIC max */
 			(VAL_MISC_FLAGS);
 
 #undef VAL_MISC_FLAGS
diff --git a/tools/xl/xl.c b/tools/xl/xl.c
index 2d1ec18ea3..31eb223309 100644
--- a/tools/xl/xl.c
+++ b/tools/xl/xl.c
@@ -57,6 +57,8 @@ int max_grant_frames = -1;
 int max_maptrack_frames = -1;
 int max_grant_version = LIBXL_MAX_GRANT_DEFAULT;
 libxl_domid domid_policy = INVALID_DOMID;
+int assisted_xapic = -1;
+int assisted_x2apic = -1;
 
 xentoollog_level minmsglevel = minmsglevel_default;
 
@@ -201,6 +203,12 @@ static void parse_global_config(const char *configfile,
     if (!xlu_cfg_get_long (config, "claim_mode", &l, 0))
         claim_mode = l;
 
+    if (!xlu_cfg_get_long (config, "assisted_xapic", &l, 0))
+        assisted_xapic = l;
+
+    if (!xlu_cfg_get_long (config, "assisted_x2apic", &l, 0))
+        assisted_x2apic = l;
+
     xlu_cfg_replace_string (config, "remus.default.netbufscript",
         &default_remus_netbufscript, 0);
     xlu_cfg_replace_string (config, "colo.default.proxyscript",
diff --git a/tools/xl/xl.h b/tools/xl/xl.h
index c5c4bedbdd..528deb3feb 100644
--- a/tools/xl/xl.h
+++ b/tools/xl/xl.h
@@ -286,6 +286,8 @@ extern libxl_bitmap global_vm_affinity_mask;
 extern libxl_bitmap global_hvm_affinity_mask;
 extern libxl_bitmap global_pv_affinity_mask;
 extern libxl_domid domid_policy;
+extern int assisted_xapic;
+extern int assisted_x2apic;
 
 enum output_format {
     OUTPUT_FORMAT_JSON,
diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c
index 117fcdcb2b..0ab9b145fe 100644
--- a/tools/xl/xl_parse.c
+++ b/tools/xl/xl_parse.c
@@ -1681,6 +1681,22 @@ void parse_config_data(const char *config_source,
         xlu_cfg_get_defbool(config, "vpt_align", &b_info->u.hvm.vpt_align, 0);
         xlu_cfg_get_defbool(config, "apic", &b_info->apic, 0);
 
+        e = xlu_cfg_get_long(config, "assisted_xapic", &l , 0);
+        if ((e == ESRCH && assisted_xapic != -1)) /* use global default if present */
+            libxl_defbool_set(&b_info->arch_x86.assisted_xapic, assisted_xapic);
+        else if (!e)
+            libxl_defbool_set(&b_info->arch_x86.assisted_xapic, l);
+        else
+            exit(1);
+
+        e = xlu_cfg_get_long(config, "assisted_x2apic", &l, 0);
+        if ((e == ESRCH && assisted_x2apic != -1)) /* use global default if present */
+            libxl_defbool_set(&b_info->arch_x86.assisted_x2apic, assisted_x2apic);
+        else if (!e)
+            libxl_defbool_set(&b_info->arch_x86.assisted_x2apic, l);
+        else
+            exit(1);
+
         switch (xlu_cfg_get_list(config, "viridian",
                                  &viridian, &num_viridian, 1))
         {
diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c
index 9835f90ea0..c239e55f12 100644
--- a/xen/arch/x86/domain.c
+++ b/xen/arch/x86/domain.c
@@ -619,6 +619,8 @@ int arch_sanitise_domain_config(struct xen_domctl_createdomain *config)
     bool hvm = config->flags & XEN_DOMCTL_CDF_hvm;
     bool hap = config->flags & XEN_DOMCTL_CDF_hap;
     bool nested_virt = config->flags & XEN_DOMCTL_CDF_nested_virt;
+    bool assisted_xapic = config->arch.misc_flags & XEN_X86_ASSISTED_XAPIC;
+    bool assisted_x2apic = config->arch.misc_flags & XEN_X86_ASSISTED_X2APIC;
     unsigned int max_vcpus;
 
     if ( hvm ? !hvm_enabled : !IS_ENABLED(CONFIG_PV) )
@@ -685,13 +687,31 @@ int arch_sanitise_domain_config(struct xen_domctl_createdomain *config)
         }
     }
 
-    if ( config->arch.misc_flags & ~XEN_X86_MSR_RELAXED )
+    if ( config->arch.misc_flags & ~(XEN_X86_MSR_RELAXED |
+                                     XEN_X86_ASSISTED_XAPIC |
+                                     XEN_X86_ASSISTED_X2APIC) )
     {
         dprintk(XENLOG_INFO, "Invalid arch misc flags %#x\n",
                 config->arch.misc_flags);
         return -EINVAL;
     }
 
+    if ( (assisted_xapic || assisted_x2apic) && !hvm )
+    {
+        dprintk(XENLOG_INFO,
+                "Interrupt Controller Virtualization not supported for PV\n");
+        return -EINVAL;
+    }
+
+    if ( (assisted_xapic && !assisted_xapic_available) ||
+         (assisted_x2apic && !assisted_x2apic_available) )
+    {
+        dprintk(XENLOG_INFO,
+                "Hardware assisted x%sAPIC requested but not available\n",
+                assisted_xapic && !assisted_xapic_available ? "" : "2");
+        return -EINVAL;
+    }
+
     return 0;
 }
 
@@ -864,6 +884,12 @@ int arch_domain_create(struct domain *d,
 
     d->arch.msr_relaxed = config->arch.misc_flags & XEN_X86_MSR_RELAXED;
 
+    d->arch.hvm.assisted_xapic =
+        config->arch.misc_flags & XEN_X86_ASSISTED_XAPIC;
+
+    d->arch.hvm.assisted_x2apic =
+        config->arch.misc_flags & XEN_X86_ASSISTED_X2APIC;
+
     return 0;
 
  fail:
diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c
index be981e11bc..862b1d2126 100644
--- a/xen/arch/x86/hvm/vmx/vmcs.c
+++ b/xen/arch/x86/hvm/vmx/vmcs.c
@@ -1155,6 +1155,10 @@ static int construct_vmcs(struct vcpu *v)
         __vmwrite(PLE_WINDOW, ple_window);
     }
 
+    if ( !v->domain->arch.hvm.assisted_xapic )
+        v->arch.hvm.vmx.secondary_exec_control &=
+            ~SECONDARY_EXEC_VIRTUALIZE_APIC_ACCESSES;
+
     if ( cpu_has_vmx_secondary_exec_control )
         __vmwrite(SECONDARY_VM_EXEC_CONTROL,
                   v->arch.hvm.vmx.secondary_exec_control);
diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c
index 36c8a12cfe..2a0851c960 100644
--- a/xen/arch/x86/hvm/vmx/vmx.c
+++ b/xen/arch/x86/hvm/vmx/vmx.c
@@ -3333,15 +3333,15 @@ static void vmx_install_vlapic_mapping(struct vcpu *v)
 
 void vmx_vlapic_msr_changed(struct vcpu *v)
 {
-    int virtualize_x2apic_mode;
+    bool virtualize_x2apic_mode;
     struct vlapic *vlapic = vcpu_vlapic(v);
     unsigned int msr;
 
     virtualize_x2apic_mode = ( (cpu_has_vmx_apic_reg_virt ||
                                 cpu_has_vmx_virtual_intr_delivery) &&
-                               cpu_has_vmx_virtualize_x2apic_mode );
+                               v->domain->arch.hvm.assisted_x2apic );
 
-    if ( !cpu_has_vmx_virtualize_apic_accesses &&
+    if ( !v->domain->arch.hvm.assisted_xapic &&
          !virtualize_x2apic_mode )
         return;
 
@@ -3373,7 +3373,7 @@ void vmx_vlapic_msr_changed(struct vcpu *v)
                 vmx_clear_msr_intercept(v, MSR_X2APIC_SELF, VMX_MSR_W);
             }
         }
-        else
+        else if ( v->domain->arch.hvm.assisted_xapic )
             v->arch.hvm.vmx.secondary_exec_control |=
                 SECONDARY_EXEC_VIRTUALIZE_APIC_ACCESSES;
     }
diff --git a/xen/arch/x86/include/asm/hvm/domain.h b/xen/arch/x86/include/asm/hvm/domain.h
index 698455444e..92bf53483c 100644
--- a/xen/arch/x86/include/asm/hvm/domain.h
+++ b/xen/arch/x86/include/asm/hvm/domain.h
@@ -117,6 +117,12 @@ struct hvm_domain {
 
     bool                   is_s3_suspended;
 
+    /* xAPIC hardware assisted virtualization. */
+    bool                   assisted_xapic;
+
+    /* x2APIC hardware assisted virtualization. */
+    bool                   assisted_x2apic;
+
     /* hypervisor intercepted msix table */
     struct list_head       msixtbl_list;
 
diff --git a/xen/arch/x86/traps.c b/xen/arch/x86/traps.c
index 485bd66971..8f1c5efef7 100644
--- a/xen/arch/x86/traps.c
+++ b/xen/arch/x86/traps.c
@@ -1115,7 +1115,8 @@ void cpuid_hypervisor_leaves(const struct vcpu *v, uint32_t leaf,
         if ( !is_hvm_domain(d) || subleaf != 0 )
             break;
 
-        if ( cpu_has_vmx_apic_reg_virt )
+        if ( cpu_has_vmx_apic_reg_virt &&
+             v->domain->arch.hvm.assisted_xapic )
             res->a |= XEN_HVM_CPUID_APIC_ACCESS_VIRT;
 
         /*
@@ -1124,9 +1125,8 @@ void cpuid_hypervisor_leaves(const struct vcpu *v, uint32_t leaf,
          * and wrmsr in the guest will run without VMEXITs (see
          * vmx_vlapic_msr_changed()).
          */
-        if ( cpu_has_vmx_virtualize_x2apic_mode &&
-             cpu_has_vmx_apic_reg_virt &&
-             cpu_has_vmx_virtual_intr_delivery )
+        if ( cpu_has_vmx_apic_reg_virt && cpu_has_vmx_virtual_intr_delivery &&
+             v->domain->arch.hvm.assisted_x2apic )
             res->a |= XEN_HVM_CPUID_X2APIC_VIRT;
 
         /*
diff --git a/xen/include/public/arch-x86/xen.h b/xen/include/public/arch-x86/xen.h
index 7acd94c8eb..9da32c6239 100644
--- a/xen/include/public/arch-x86/xen.h
+++ b/xen/include/public/arch-x86/xen.h
@@ -317,6 +317,8 @@ struct xen_arch_domainconfig {
  * doesn't allow the guest to read or write to the underlying MSR.
  */
 #define XEN_X86_MSR_RELAXED (1u << 0)
+#define XEN_X86_ASSISTED_XAPIC (1u << 1)
+#define XEN_X86_ASSISTED_X2APIC (1u << 2)
     uint32_t misc_flags;
 };
 
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Fri Feb 18 17:30:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 18 Feb 2022 17:30:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275589.471550 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL75B-0006bt-Uv; Fri, 18 Feb 2022 17:30:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275589.471550; Fri, 18 Feb 2022 17:30:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL75B-0006bm-Rt; Fri, 18 Feb 2022 17:30:13 +0000
Received: by outflank-mailman (input) for mailman id 275589;
 Fri, 18 Feb 2022 17:30:12 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=nO3j=TB=citrix.com=prvs=0411eaaf8=Jane.Malalane@srs-se1.protection.inumbo.net>)
 id 1nL75A-0006Ln-1T
 for xen-devel@lists.xenproject.org; Fri, 18 Feb 2022 17:30:12 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6a71c1d9-90e0-11ec-8eb8-a37418f5ba1a;
 Fri, 18 Feb 2022 18:30:09 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6a71c1d9-90e0-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645205409;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=S+8V/rw6crKioKh5KpXJahKwQ6j0S27m+hsi0+7wm3c=;
  b=V/6PTdywwEZPJhtbEBJXUqHoKFu7IBfA809PEL0jCiZH65nOhgInghH2
   meeO7mndYzWm/dBa+aGBU3Djt3EFJOQML7jd+AqqyZnOCm0WSzME7NKc9
   QU/RvQfPk+81NJMQZU7REYOCJESbPLMZF6thDJ6LDUyumUu1shEfmZs8O
   o=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 63974997
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:6gJukq9cTUo/lsfNtB+1DrUDGX6TJUtcMsCJ2f8bNWPcYEJGY0x3y
 jZKDzyDPveCYmr3fY12PY/noEJV6pHVm9RjT1E9+Xg8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si+Fa+Sn9T8mvU2xbuKU5NTsY0idfic5Dndx4f5fs7Rh2NQw24HpW1nlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCnYSeWVx1DIzro8MibwIFHiRFEJR6paCSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFKEWvHwm6DjdBPIvR53rSKTW/95Imjw3g6iiGN6AP
 JtGNWs+M3wsZTVgA3kKEapisd6FrWntLw9ogmqp+ro4tj27IAtZj+G2bYu9lsaxbftSmkGUt
 2fX5VPTCxsRNMGc4Ted+3fqjejK9QvgQ54bHrC88v9sgXWQy3YVBRlQUkG0ydGzh1SiQdtZJ
 woR8zA3sKkp3EWxS5/2WBjQiH2JoB8aHcZRGusS6QeRx66S6AGcbkAGUzgHbtUlvc03QDUC1
 1mVktevDjtq2JWXRmia7ay8ti6pNG4eKmpqTT8JS04J7sfupKk3jwnTVZBzHaitlNr3FDrsh
 TeQo0AWhb8ekMoK3KWT5k3cjnSnoZ2hZgwo4gTaWEq14wU/Y5SqD6S37XDL4PAGK5yWJmRtp
 1BdxZLYtrpXS8jQymrdG43hAY1F+d6dHi2H3WxOOKIGyAi2pnOmRq1p3GxhcRIB3tk/RRflZ
 0rauAV07ZBVPWe3YaIfX79dG/jG3oC7S427C6m8gs5mJ8EoKVTZpH0GiVu4gji1+HXAh53TL
 ntynSyEKX8BQZpqwzOtLwv2+e96n3turY8/qH2S8vhG7VZ8TCLEIVvmGAHXBgzc0E9iiFyEm
 zq4H5HXoyizqMWkPkHqHXc7dDjm10QTC5HssNBwfeWeOAdgE2xJI6aPne54IdA9zvgLz72gE
 pSBtqlwkQuXaZrvc1jiV5yeQOm3AcYXQYwTZkTAwmpEK1B8ON3yvc/zhrM8fKU99fwL8BKHZ
 6JtRil0OdwWEm6v021ENfHV9dU+HDz21VPmF3f0O1AXIs8/LzElD/e5J2MDAgFVVXHp3Sb/y
 pX9vj7mrW0rHVo6V5+OMKr1p75z1FBE8N9Ps4LzCoE7UC3RHEJCcEQdUtdfzxkwFCj+
IronPort-HdrOrdr: A9a23:K+/FK64hmRlmFIWTLwPXwPDXdLJyesId70hD6qhwISY6TiX+rb
 HWoB17726TtN9/YhEdcLy7VJVoBEmskKKdgrNhWotKPjOW21dARbsKheCJrgEIWReOktK1vZ
 0QC5SWY+eQMbEVt6nHCXGDYrQd/OU=
X-IronPort-AV: E=Sophos;i="5.88,379,1635220800"; 
   d="scan'208";a="63974997"
From: Jane Malalane <jane.malalane@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Jane Malalane <jane.malalane@citrix.com>, Wei Liu <wl@xen.org>, "Anthony
 PERARD" <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, "Andrew
 Cooper" <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, Julien Grall
	<julien@xen.org>, "Stefano Stabellini" <sstabellini@kernel.org>, Volodymyr
 Babchuk <Volodymyr_Babchuk@epam.com>, Bertrand Marquis
	<bertrand.marquis@arm.com>, Jun Nakajima <jun.nakajima@intel.com>, Kevin Tian
	<kevin.tian@intel.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>
Subject: [PATCH v3 1/2] xen+tools: Report Interrupt Controller Virtualization capabilities on x86
Date: Fri, 18 Feb 2022 17:29:42 +0000
Message-ID: <20220218172943.12182-2-jane.malalane@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220218172943.12182-1-jane.malalane@citrix.com>
References: <20220218172943.12182-1-jane.malalane@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

Add XEN_SYSCTL_PHYSCAP_ARCH_ASSISTED_xapic and
XEN_SYSCTL_PHYSCAP_ARCH_ASSISTED_x2apic to report accelerated xapic
and x2apic, on x86 hardware.
No such features are currently implemented on AMD hardware.

For that purpose, also add an arch-specific "capabilities" parameter
to struct xen_sysctl_physinfo.

Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Jane Malalane <jane.malalane@citrix.com>
---
CC: Wei Liu <wl@xen.org>
CC: Anthony PERARD <anthony.perard@citrix.com>
CC: Juergen Gross <jgross@suse.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
CC: George Dunlap <george.dunlap@citrix.com>
CC: Jan Beulich <jbeulich@suse.com>
CC: Julien Grall <julien@xen.org>
CC: Stefano Stabellini <sstabellini@kernel.org>
CC: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
CC: Bertrand Marquis <bertrand.marquis@arm.com>
CC: Jun Nakajima <jun.nakajima@intel.com>
CC: Kevin Tian <kevin.tian@intel.com>
CC: "Roger Pau Monné" <roger.pau@citrix.com>

v3:
 * Define XEN_SYSCTL_PHYSCAP_ARCH_MAX for ABI checking and actually
   set arch_capbilities, via a call to c_bitmap_to_ocaml_list()
 * Have assisted_x2apic_available only depend on
   cpu_has_vmx_virtualize_x2apic_mode
v2:
 * Use one macro LIBXL_HAVE_PHYSINFO_ASSISTED_APIC instead of two
 * Pass xcpyshinfo as a pointer in libxl__arch_get_physinfo
 * Set assisted_x{2}apic_available to be conditional upon "bsp" and
   annotate it with __ro_after_init
 * Change XEN_SYSCTL_PHYSCAP_ARCH_ASSISTED_X{2}APIC to
   (...)_X86_ASSISTED_X{2}APIC
 * Keep XEN_SYSCTL_PHYSCAP_X86_ASSISTED_X{2}APIC contained within
   sysctl.h
 * Fix padding introduced in struct xen_sysctl_physinfo and bump
   XEN_SYSCTL_INTERFACE_VERSION
---
 tools/golang/xenlight/helpers.gen.go |  4 ++++
 tools/golang/xenlight/types.gen.go   |  2 ++
 tools/include/libxl.h                |  7 +++++++
 tools/libs/light/libxl.c             |  3 +++
 tools/libs/light/libxl_arch.h        |  4 ++++
 tools/libs/light/libxl_arm.c         |  5 +++++
 tools/libs/light/libxl_types.idl     |  2 ++
 tools/libs/light/libxl_x86.c         | 11 +++++++++++
 tools/ocaml/libs/xc/xenctrl.ml       |  5 +++++
 tools/ocaml/libs/xc/xenctrl.mli      |  5 +++++
 tools/ocaml/libs/xc/xenctrl_stubs.c  | 14 +++++++++++---
 tools/xl/xl_info.c                   |  6 ++++--
 xen/arch/x86/hvm/vmx/vmcs.c          |  7 +++++++
 xen/arch/x86/include/asm/domain.h    |  3 +++
 xen/arch/x86/sysctl.c                |  7 +++++++
 xen/include/public/sysctl.h          | 11 ++++++++++-
 16 files changed, 90 insertions(+), 6 deletions(-)

diff --git a/tools/golang/xenlight/helpers.gen.go b/tools/golang/xenlight/helpers.gen.go
index b746ff1081..dd4e6c9f14 100644
--- a/tools/golang/xenlight/helpers.gen.go
+++ b/tools/golang/xenlight/helpers.gen.go
@@ -3373,6 +3373,8 @@ x.CapVmtrace = bool(xc.cap_vmtrace)
 x.CapVpmu = bool(xc.cap_vpmu)
 x.CapGnttabV1 = bool(xc.cap_gnttab_v1)
 x.CapGnttabV2 = bool(xc.cap_gnttab_v2)
+x.CapAssistedXapic = bool(xc.cap_assisted_xapic)
+x.CapAssistedX2Apic = bool(xc.cap_assisted_x2apic)
 
  return nil}
 
@@ -3407,6 +3409,8 @@ xc.cap_vmtrace = C.bool(x.CapVmtrace)
 xc.cap_vpmu = C.bool(x.CapVpmu)
 xc.cap_gnttab_v1 = C.bool(x.CapGnttabV1)
 xc.cap_gnttab_v2 = C.bool(x.CapGnttabV2)
+xc.cap_assisted_xapic = C.bool(x.CapAssistedXapic)
+xc.cap_assisted_x2apic = C.bool(x.CapAssistedX2Apic)
 
  return nil
  }
diff --git a/tools/golang/xenlight/types.gen.go b/tools/golang/xenlight/types.gen.go
index b1e84d5258..87be46c745 100644
--- a/tools/golang/xenlight/types.gen.go
+++ b/tools/golang/xenlight/types.gen.go
@@ -1014,6 +1014,8 @@ CapVmtrace bool
 CapVpmu bool
 CapGnttabV1 bool
 CapGnttabV2 bool
+CapAssistedXapic bool
+CapAssistedX2Apic bool
 }
 
 type Connectorinfo struct {
diff --git a/tools/include/libxl.h b/tools/include/libxl.h
index 51a9b6cfac..333ffad38d 100644
--- a/tools/include/libxl.h
+++ b/tools/include/libxl.h
@@ -528,6 +528,13 @@
 #define LIBXL_HAVE_MAX_GRANT_VERSION 1
 
 /*
+ * LIBXL_HAVE_PHYSINFO_ASSISTED_APIC indicates that libxl_physinfo has
+ * cap_assisted_x{2}apic fields, which indicates the availability of x{2}APIC
+ * hardware assisted virtualization.
+ */
+#define LIBXL_HAVE_PHYSINFO_ASSISTED_APIC 1
+
+/*
  * libxl ABI compatibility
  *
  * The only guarantee which libxl makes regarding ABI compatibility
diff --git a/tools/libs/light/libxl.c b/tools/libs/light/libxl.c
index a0bf7d186f..6d699951e2 100644
--- a/tools/libs/light/libxl.c
+++ b/tools/libs/light/libxl.c
@@ -15,6 +15,7 @@
 #include "libxl_osdeps.h"
 
 #include "libxl_internal.h"
+#include "libxl_arch.h"
 
 int libxl_ctx_alloc(libxl_ctx **pctx, int version,
                     unsigned flags, xentoollog_logger * lg)
@@ -410,6 +411,8 @@ int libxl_get_physinfo(libxl_ctx *ctx, libxl_physinfo *physinfo)
     physinfo->cap_gnttab_v2 =
         !!(xcphysinfo.capabilities & XEN_SYSCTL_PHYSCAP_gnttab_v2);
 
+    libxl__arch_get_physinfo(physinfo, &xcphysinfo);
+
     GC_FREE;
     return 0;
 }
diff --git a/tools/libs/light/libxl_arch.h b/tools/libs/light/libxl_arch.h
index 1522ecb97f..207ceac6a1 100644
--- a/tools/libs/light/libxl_arch.h
+++ b/tools/libs/light/libxl_arch.h
@@ -86,6 +86,10 @@ int libxl__arch_extra_memory(libxl__gc *gc,
                              uint64_t *out);
 
 _hidden
+void libxl__arch_get_physinfo(libxl_physinfo *physinfo,
+                              const xc_physinfo_t *xcphysinfo);
+
+_hidden
 void libxl__arch_update_domain_config(libxl__gc *gc,
                                       libxl_domain_config *dst,
                                       const libxl_domain_config *src);
diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c
index eef1de0939..39fdca1b49 100644
--- a/tools/libs/light/libxl_arm.c
+++ b/tools/libs/light/libxl_arm.c
@@ -1431,6 +1431,11 @@ int libxl__arch_passthrough_mode_setdefault(libxl__gc *gc,
     return rc;
 }
 
+void libxl__arch_get_physinfo(libxl_physinfo *physinfo,
+                              const xc_physinfo_t *xcphysinfo)
+{
+}
+
 void libxl__arch_update_domain_config(libxl__gc *gc,
                                       libxl_domain_config *dst,
                                       const libxl_domain_config *src)
diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl
index 2a42da2f7d..42ac6c357b 100644
--- a/tools/libs/light/libxl_types.idl
+++ b/tools/libs/light/libxl_types.idl
@@ -1068,6 +1068,8 @@ libxl_physinfo = Struct("physinfo", [
     ("cap_vpmu", bool),
     ("cap_gnttab_v1", bool),
     ("cap_gnttab_v2", bool),
+    ("cap_assisted_xapic", bool),
+    ("cap_assisted_x2apic", bool),
     ], dir=DIR_OUT)
 
 libxl_connectorinfo = Struct("connectorinfo", [
diff --git a/tools/libs/light/libxl_x86.c b/tools/libs/light/libxl_x86.c
index 1feadebb18..e0a06ecfe3 100644
--- a/tools/libs/light/libxl_x86.c
+++ b/tools/libs/light/libxl_x86.c
@@ -866,6 +866,17 @@ int libxl__arch_passthrough_mode_setdefault(libxl__gc *gc,
     return rc;
 }
 
+void libxl__arch_get_physinfo(libxl_physinfo *physinfo,
+                              const xc_physinfo_t *xcphysinfo)
+{
+    physinfo->cap_assisted_xapic =
+        !!(xcphysinfo->arch_capabilities &
+           XEN_SYSCTL_PHYSCAP_X86_ASSISTED_XAPIC);
+    physinfo->cap_assisted_x2apic =
+        !!(xcphysinfo->arch_capabilities &
+           XEN_SYSCTL_PHYSCAP_X86_ASSISTED_X2APIC);
+}
+
 void libxl__arch_update_domain_config(libxl__gc *gc,
                                       libxl_domain_config *dst,
                                       const libxl_domain_config *src)
diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl.ml
index 7503031d8f..21783d3622 100644
--- a/tools/ocaml/libs/xc/xenctrl.ml
+++ b/tools/ocaml/libs/xc/xenctrl.ml
@@ -127,6 +127,10 @@ type physinfo_cap_flag =
 	| CAP_Gnttab_v1
 	| CAP_Gnttab_v2
 
+type physinfo_arch_cap_flag =
+	| CAP_X86_ASSISTED_XAPIC
+	| CAP_X86_ASSISTED_X2APIC
+
 type physinfo =
 {
 	threads_per_core : int;
@@ -139,6 +143,7 @@ type physinfo =
 	scrub_pages      : nativeint;
 	(* XXX hw_cap *)
 	capabilities     : physinfo_cap_flag list;
+	arch_capabilities : physinfo_arch_cap_flag list;
 	max_nr_cpus      : int;
 }
 
diff --git a/tools/ocaml/libs/xc/xenctrl.mli b/tools/ocaml/libs/xc/xenctrl.mli
index d1d9c9247a..af6ba3d1a0 100644
--- a/tools/ocaml/libs/xc/xenctrl.mli
+++ b/tools/ocaml/libs/xc/xenctrl.mli
@@ -112,6 +112,10 @@ type physinfo_cap_flag =
   | CAP_Gnttab_v1
   | CAP_Gnttab_v2
 
+type physinfo_arch_cap_flag =
+  | CAP_X86_ASSISTED_XAPIC
+  | CAP_X86_ASSISTED_X2APIC
+
 type physinfo = {
   threads_per_core : int;
   cores_per_socket : int;
@@ -122,6 +126,7 @@ type physinfo = {
   free_pages       : nativeint;
   scrub_pages      : nativeint;
   capabilities     : physinfo_cap_flag list;
+  arch_capabilities : physinfo_arch_cap_flag list;
   max_nr_cpus      : int; (** compile-time max possible number of nr_cpus *)
 }
 type version = { major : int; minor : int; extra : string; }
diff --git a/tools/ocaml/libs/xc/xenctrl_stubs.c b/tools/ocaml/libs/xc/xenctrl_stubs.c
index 5b4fe72c8d..1fa5453043 100644
--- a/tools/ocaml/libs/xc/xenctrl_stubs.c
+++ b/tools/ocaml/libs/xc/xenctrl_stubs.c
@@ -712,7 +712,7 @@ CAMLprim value stub_xc_send_debug_keys(value xch, value keys)
 CAMLprim value stub_xc_physinfo(value xch)
 {
 	CAMLparam1(xch);
-	CAMLlocal2(physinfo, cap_list);
+	CAMLlocal3(physinfo, cap_list, arch_cap_list);
 	xc_physinfo_t c_physinfo;
 	int r;
 
@@ -730,8 +730,15 @@ CAMLprim value stub_xc_physinfo(value xch)
 		/* ! physinfo_cap_flag CAP_ lc */
 		/* ! XEN_SYSCTL_PHYSCAP_ XEN_SYSCTL_PHYSCAP_MAX max */
 		(c_physinfo.capabilities);
+	/*
+	 * arch_capabilities: physinfo_arch_cap_flag list;
+	 */
+	arch_cap_list = c_bitmap_to_ocaml_list
+		/* ! physinfo_arch_cap_flag CAP_ none */
+		/* ! XEN_SYSCTL_PHYSCAP_ XEN_SYSCTL_PHYSCAP_ARCH_MAX max */
+		(c_physinfo.arch_capabilities);
 
-	physinfo = caml_alloc_tuple(10);
+	physinfo = caml_alloc_tuple(11);
 	Store_field(physinfo, 0, Val_int(c_physinfo.threads_per_core));
 	Store_field(physinfo, 1, Val_int(c_physinfo.cores_per_socket));
 	Store_field(physinfo, 2, Val_int(c_physinfo.nr_cpus));
@@ -741,7 +748,8 @@ CAMLprim value stub_xc_physinfo(value xch)
 	Store_field(physinfo, 6, caml_copy_nativeint(c_physinfo.free_pages));
 	Store_field(physinfo, 7, caml_copy_nativeint(c_physinfo.scrub_pages));
 	Store_field(physinfo, 8, cap_list);
-	Store_field(physinfo, 9, Val_int(c_physinfo.max_cpu_id + 1));
+	Store_field(physinfo, 9, arch_cap_list);
+	Store_field(physinfo, 10, Val_int(c_physinfo.max_cpu_id + 1));
 
 	CAMLreturn(physinfo);
 }
diff --git a/tools/xl/xl_info.c b/tools/xl/xl_info.c
index 712b7638b0..3205270754 100644
--- a/tools/xl/xl_info.c
+++ b/tools/xl/xl_info.c
@@ -210,7 +210,7 @@ static void output_physinfo(void)
          info.hw_cap[4], info.hw_cap[5], info.hw_cap[6], info.hw_cap[7]
         );
 
-    maybe_printf("virt_caps              :%s%s%s%s%s%s%s%s%s%s%s\n",
+    maybe_printf("virt_caps              :%s%s%s%s%s%s%s%s%s%s%s%s%s\n",
          info.cap_pv ? " pv" : "",
          info.cap_hvm ? " hvm" : "",
          info.cap_hvm && info.cap_hvm_directio ? " hvm_directio" : "",
@@ -221,7 +221,9 @@ static void output_physinfo(void)
          info.cap_vmtrace ? " vmtrace" : "",
          info.cap_vpmu ? " vpmu" : "",
          info.cap_gnttab_v1 ? " gnttab-v1" : "",
-         info.cap_gnttab_v2 ? " gnttab-v2" : ""
+         info.cap_gnttab_v2 ? " gnttab-v2" : "",
+         info.cap_assisted_xapic ? " assisted_xapic" : "",
+         info.cap_assisted_x2apic ? " assisted_x2apic" : ""
         );
 
     vinfo = libxl_get_version_info(ctx);
diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c
index 7ab15e07a0..be981e11bc 100644
--- a/xen/arch/x86/hvm/vmx/vmcs.c
+++ b/xen/arch/x86/hvm/vmx/vmcs.c
@@ -343,6 +343,13 @@ static int vmx_init_vmcs_config(bool bsp)
             MSR_IA32_VMX_PROCBASED_CTLS2, &mismatch);
     }
 
+    /* Check whether hardware supports accelerated xapic and x2apic. */
+    if ( bsp )
+    {
+        assisted_xapic_available = cpu_has_vmx_virtualize_apic_accesses;
+        assisted_x2apic_available = cpu_has_vmx_virtualize_x2apic_mode;
+    }
+
     /* The IA32_VMX_EPT_VPID_CAP MSR exists only when EPT or VPID available */
     if ( _vmx_secondary_exec_control & (SECONDARY_EXEC_ENABLE_EPT |
                                         SECONDARY_EXEC_ENABLE_VPID) )
diff --git a/xen/arch/x86/include/asm/domain.h b/xen/arch/x86/include/asm/domain.h
index e62e109598..72431df26d 100644
--- a/xen/arch/x86/include/asm/domain.h
+++ b/xen/arch/x86/include/asm/domain.h
@@ -756,6 +756,9 @@ static inline void pv_inject_sw_interrupt(unsigned int vector)
                       : is_pv_32bit_domain(d) ? PV32_VM_ASSIST_MASK \
                                               : PV64_VM_ASSIST_MASK)
 
+extern bool assisted_xapic_available;
+extern bool assisted_x2apic_available;
+
 #endif /* __ASM_DOMAIN_H__ */
 
 /*
diff --git a/xen/arch/x86/sysctl.c b/xen/arch/x86/sysctl.c
index aff52a13f3..642cc96985 100644
--- a/xen/arch/x86/sysctl.c
+++ b/xen/arch/x86/sysctl.c
@@ -69,6 +69,9 @@ struct l3_cache_info {
     unsigned long size;
 };
 
+bool __ro_after_init assisted_xapic_available;
+bool __ro_after_init assisted_x2apic_available;
+
 static void l3_cache_get(void *arg)
 {
     struct cpuid4_info info;
@@ -135,6 +138,10 @@ void arch_do_physinfo(struct xen_sysctl_physinfo *pi)
         pi->capabilities |= XEN_SYSCTL_PHYSCAP_hap;
     if ( IS_ENABLED(CONFIG_SHADOW_PAGING) )
         pi->capabilities |= XEN_SYSCTL_PHYSCAP_shadow;
+    if ( assisted_xapic_available )
+        pi->arch_capabilities |= XEN_SYSCTL_PHYSCAP_X86_ASSISTED_XAPIC;
+    if ( assisted_x2apic_available )
+        pi->arch_capabilities |= XEN_SYSCTL_PHYSCAP_X86_ASSISTED_X2APIC;
 }
 
 long arch_do_sysctl(
diff --git a/xen/include/public/sysctl.h b/xen/include/public/sysctl.h
index 55252e97f2..d38141a780 100644
--- a/xen/include/public/sysctl.h
+++ b/xen/include/public/sysctl.h
@@ -35,7 +35,7 @@
 #include "domctl.h"
 #include "physdev.h"
 
-#define XEN_SYSCTL_INTERFACE_VERSION 0x00000014
+#define XEN_SYSCTL_INTERFACE_VERSION 0x00000015
 
 /*
  * Read console content from Xen buffer ring.
@@ -111,6 +111,13 @@ struct xen_sysctl_tbuf_op {
 /* Max XEN_SYSCTL_PHYSCAP_* constant.  Used for ABI checking. */
 #define XEN_SYSCTL_PHYSCAP_MAX XEN_SYSCTL_PHYSCAP_gnttab_v2
 
+/* The platform supports x{2}apic hardware assisted emulation. */
+#define XEN_SYSCTL_PHYSCAP_X86_ASSISTED_XAPIC  (1u << 0)
+#define XEN_SYSCTL_PHYSCAP_X86_ASSISTED_X2APIC (1u << 1)
+
+/* Max XEN_SYSCTL_PHYSCAP_X86{ARM}__* constant. Used for ABI checking. */
+#define XEN_SYSCTL_PHYSCAP_ARCH_MAX XEN_SYSCTL_PHYSCAP_X86_ASSISTED_X2APIC
+
 struct xen_sysctl_physinfo {
     uint32_t threads_per_core;
     uint32_t cores_per_socket;
@@ -120,6 +127,8 @@ struct xen_sysctl_physinfo {
     uint32_t max_node_id; /* Largest possible node ID on this host */
     uint32_t cpu_khz;
     uint32_t capabilities;/* XEN_SYSCTL_PHYSCAP_??? */
+    uint32_t arch_capabilities;/* XEN_SYSCTL_PHYSCAP_X86{ARM}_??? */
+    uint32_t pad; /* Must be zero. */
     uint64_aligned_t total_pages;
     uint64_aligned_t free_pages;
     uint64_aligned_t scrub_pages;
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Fri Feb 18 17:30:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 18 Feb 2022 17:30:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275588.471540 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL75A-0006M5-ME; Fri, 18 Feb 2022 17:30:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275588.471540; Fri, 18 Feb 2022 17:30:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL75A-0006Ly-J7; Fri, 18 Feb 2022 17:30:12 +0000
Received: by outflank-mailman (input) for mailman id 275588;
 Fri, 18 Feb 2022 17:30:11 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=nO3j=TB=citrix.com=prvs=0411eaaf8=Jane.Malalane@srs-se1.protection.inumbo.net>)
 id 1nL759-0006Ln-EJ
 for xen-devel@lists.xenproject.org; Fri, 18 Feb 2022 17:30:11 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 69c467d6-90e0-11ec-8eb8-a37418f5ba1a;
 Fri, 18 Feb 2022 18:30:09 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 69c467d6-90e0-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645205409;
  h=from:to:cc:subject:date:message-id:mime-version:
   content-transfer-encoding;
  bh=v5AvBjRUda1vG0duvK2xZJ6G9uVS/XVqZUB9W75c8Xk=;
  b=GqppBh4XvbCumP2TFlfv0iP0JpSn1KJXXo4o0yi4GWcBVmU+G+1Cg3g6
   wVmC6AjCNBM0LMoDj54aqHaYCmRnGIkcScyiR0SD1WYexRg6pYdrzgiiI
   LBUewqZQWDXeiDvOOzAbsR/dtBaW9cpLVw86z/qszAWl4uAmB458goYK7
   I=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 66781801
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:xfNoCK4emkqjc9S2JuY+1gxRtF3HchMFZxGqfqrLsTDasY5as4F+v
 mtMCD/Xa/mLMGajed4iYYS2ox4C6pTXzodkGlNk+Ck0Hi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFx2XqPp8Zj2tQy2YLgU1vX0
 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X
 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx
 umhurSpGD4lJIKWmd4DCSkAMRlBEalKxPjudC3XXcy7lyUqclPpyvRqSko3IZcZ6qB8BmQmG
 f4wcW5XKErZ3qTvnez9GrIEascLdaEHOKs9s3dtixTQCf8iSJbOa67L+cVZzHE7gcUm8fP2O
 ZRGOWM/NE2ojxtnAGkbL51mp86T22jSLzMGl36c+Kkm7D2GpOB2+Oe0a4eEEjCQfu1Fk0Ddq
 m/Y8mDRBhABKMfZ2TeD6mirhOLEgWX8Qo16KVGj3qc02hvJnDVVUUBIEwvgyRWktqKgc8sOE
 kAO1XAvl7ZoxBSJdubRWxGE51fR63bwROFsO+E97QiMzI/d7ACYGnUIQ1Z9VTA2iCMlbWd0j
 wHUxrsFERQq6eTIEizFqt94uBvvYXB9EIMUWcMToeLpCfHHqZp7sB/AR80L/EWd3oysQmGYL
 9xnQUEDa1QvYSwji/TTEbPv2WvESn31ougdv1S/soWNtF4RWWJdT9b0gWU3FN4ZRGpjcnGPv
 WIfh++V5/0UAJeGmUSlGbtRQejzu67UbGOF2zaD+qXNERz0qhZPmqgKvVlDyLpBaJ5YKVcFn
 meI0e+u2HOjFCTzNvImC25AI88r0bLhBbzYugP8NbJzjmxKXFbfpklGPBfIt0i0yRREufxva
 P+zLJf3ZV5HWPsP8dZDb7pEuVPd7ntlnj27qFGS50nP7Idyk1bPF+9eaQPWNrpRAWHtiFy9z
 uuz/vCik313ONASqAGMmWLPBTjm9UQGOK0=
IronPort-HdrOrdr: A9a23:5xoZb6hrwpuMp02d1wpNC5kQAHBQXtQji2hC6mlwRA09TySZ//
 rOoB19726TtN9xYgBGpTnuAtjifZqxz/FICOoqTNOftWvdyQmVxehZhOOIqVCNJ8SXzJ8l6U
 4KSchD4bPLY2SS9fyKhTWFLw==
X-IronPort-AV: E=Sophos;i="5.88,379,1635220800"; 
   d="scan'208";a="66781801"
From: Jane Malalane <jane.malalane@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Jane Malalane <jane.malalane@citrix.com>
Subject: [PATCH v3 0/2] xen+tools: Report Interrupt Controller Virtualization capabilities on x86
Date: Fri, 18 Feb 2022 17:29:41 +0000
Message-ID: <20220218172943.12182-1-jane.malalane@citrix.com>
X-Mailer: git-send-email 2.11.0
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

Jane Malalane (2):
  xen+tools: Report Interrupt Controller Virtualization capabilities on
    x86
  x86/xen: Allow per-domain usage of hardware virtualized APIC

 docs/man/xl.cfg.5.pod.in              | 19 +++++++++++++++++
 docs/man/xl.conf.5.pod.in             | 12 +++++++++++
 tools/golang/xenlight/helpers.gen.go  | 16 ++++++++++++++
 tools/golang/xenlight/types.gen.go    |  4 ++++
 tools/include/libxl.h                 | 14 +++++++++++++
 tools/libs/light/libxl.c              |  3 +++
 tools/libs/light/libxl_arch.h         |  9 ++++++--
 tools/libs/light/libxl_arm.c          | 12 +++++++++--
 tools/libs/light/libxl_create.c       | 22 ++++++++++++--------
 tools/libs/light/libxl_types.idl      |  4 ++++
 tools/libs/light/libxl_x86.c          | 39 +++++++++++++++++++++++++++++++++--
 tools/ocaml/libs/xc/xenctrl.ml        |  7 +++++++
 tools/ocaml/libs/xc/xenctrl.mli       |  7 +++++++
 tools/ocaml/libs/xc/xenctrl_stubs.c   | 16 ++++++++++----
 tools/xl/xl.c                         |  8 +++++++
 tools/xl/xl.h                         |  2 ++
 tools/xl/xl_info.c                    |  6 ++++--
 tools/xl/xl_parse.c                   | 16 ++++++++++++++
 xen/arch/x86/domain.c                 | 28 ++++++++++++++++++++++++-
 xen/arch/x86/hvm/vmx/vmcs.c           | 11 ++++++++++
 xen/arch/x86/hvm/vmx/vmx.c            |  8 +++----
 xen/arch/x86/include/asm/domain.h     |  3 +++
 xen/arch/x86/include/asm/hvm/domain.h |  6 ++++++
 xen/arch/x86/sysctl.c                 |  7 +++++++
 xen/arch/x86/traps.c                  |  8 +++----
 xen/include/public/arch-x86/xen.h     |  2 ++
 xen/include/public/sysctl.h           | 11 +++++++++-
 27 files changed, 269 insertions(+), 31 deletions(-)

-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Fri Feb 18 18:26:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 18 Feb 2022 18:26:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275611.471573 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL7xQ-0004OV-MN; Fri, 18 Feb 2022 18:26:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275611.471573; Fri, 18 Feb 2022 18:26:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL7xQ-0004OO-JV; Fri, 18 Feb 2022 18:26:16 +0000
Received: by outflank-mailman (input) for mailman id 275611;
 Fri, 18 Feb 2022 18:26:15 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nL7xP-0004OE-5z; Fri, 18 Feb 2022 18:26:15 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nL7xP-0008G9-2j; Fri, 18 Feb 2022 18:26:15 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nL7xO-00020l-Jk; Fri, 18 Feb 2022 18:26:14 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nL7xO-00022A-JH; Fri, 18 Feb 2022 18:26:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=4mj6lOJAfXlvevPUGbgjFqZVNSbqRNIfMGFpXcRzpBk=; b=5SzU4Gp6KVQuV/EJ3Ft/QQmQXA
	IHHiYw1TM174aNQX70Y6I2yhbEUT2Uv71dZsY5QfJLqaRlDM5Y9z9VEujCk0gVmjJ9XU9zT8f/R2r
	XXiSC9WofGMoQ8TcvJ8EWzY2QWxYnpBCnhkx5oEbUDRu6cQVkgnx0mM+E1V5yGKfI+B4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168165-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 168165: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=8dc44294806c83456794ba9488b4b440aa6193c2
X-Osstest-Versions-That:
    xen=f5592322062f7912dc45b30606f20691f6e1c3ee
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 18 Feb 2022 18:26:14 +0000

flight 168165 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168165/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  8dc44294806c83456794ba9488b4b440aa6193c2
baseline version:
 xen                  f5592322062f7912dc45b30606f20691f6e1c3ee

Last test of basis   168160  2022-02-18 09:01:37 Z    0 days
Testing same since   168165  2022-02-18 14:03:03 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Jan Beulich <jbeulich@suse.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   f559232206..8dc4429480  8dc44294806c83456794ba9488b4b440aa6193c2 -> smoke


From xen-devel-bounces@lists.xenproject.org Fri Feb 18 20:06:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 18 Feb 2022 20:06:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275626.471584 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL9WG-0005lb-Ah; Fri, 18 Feb 2022 20:06:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275626.471584; Fri, 18 Feb 2022 20:06:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nL9WG-0005lU-6y; Fri, 18 Feb 2022 20:06:20 +0000
Received: by outflank-mailman (input) for mailman id 275626;
 Fri, 18 Feb 2022 20:06:19 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nL9WF-0005lK-K8; Fri, 18 Feb 2022 20:06:19 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nL9WF-0001wa-GS; Fri, 18 Feb 2022 20:06:19 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nL9WF-0006qt-3t; Fri, 18 Feb 2022 20:06:19 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nL9WF-0003jO-3N; Fri, 18 Feb 2022 20:06:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=1dA8bRkEo/ntTbP8dJnKwq0QdVpf2t/PWcYpaCUIZk0=; b=R+zsBhexbbSWz0FFNXJGns2pJ2
	bS3jgpYEabTOiKnPmB7HfBd0x/BMnJpetmkz/kvbDR+5APSqnuOIEG8Vq8F9aDDTyXQadYu2vUtMb
	3eLoOFqwKCeaBm6qeoG0lIvmWJkODWCL2BDVx8R7R8pDd2kXSfyJ0j520ESeId2lskWc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168161-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 168161: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-xsm:guest-localmigrate/x10:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=4ec51e87804bd9aad0d0b8e5dadb987b54c5adeb
X-Osstest-Versions-That:
    xen=4ec51e87804bd9aad0d0b8e5dadb987b54c5adeb
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 18 Feb 2022 20:06:19 +0000

flight 168161 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168161/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 168157 pass in 168161
 test-amd64-amd64-xl-xsm      20 guest-localmigrate/x10     fail pass in 168157

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168157
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168157
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168157
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168157
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168157
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168157
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168157
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168157
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168157
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168157
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168157
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168157
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  4ec51e87804bd9aad0d0b8e5dadb987b54c5adeb
baseline version:
 xen                  4ec51e87804bd9aad0d0b8e5dadb987b54c5adeb

Last test of basis   168161  2022-02-18 10:14:12 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      fail    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Fri Feb 18 23:13:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 18 Feb 2022 23:13:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275637.471595 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nLCQl-0006Z8-7d; Fri, 18 Feb 2022 23:12:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275637.471595; Fri, 18 Feb 2022 23:12:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nLCQl-0006Z1-4Z; Fri, 18 Feb 2022 23:12:51 +0000
Received: by outflank-mailman (input) for mailman id 275637;
 Fri, 18 Feb 2022 23:12:49 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=z0EK=TB=wind.enjellic.com=greg@srs-se1.protection.inumbo.net>)
 id 1nLCQj-0006Yv-BD
 for xen-devel@lists.xen.org; Fri, 18 Feb 2022 23:12:49 +0000
Received: from wind.enjellic.com (wind.enjellic.com [76.10.64.91])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 482eeb5c-9110-11ec-8723-dd0c611c5f35;
 Sat, 19 Feb 2022 00:12:46 +0100 (CET)
Received: from wind.enjellic.com (localhost [127.0.0.1])
 by wind.enjellic.com (8.15.2/8.15.2) with ESMTP id 21INCgMR006709;
 Fri, 18 Feb 2022 17:12:42 -0600
Received: (from greg@localhost)
 by wind.enjellic.com (8.15.2/8.15.2/Submit) id 21INCg7Y006708;
 Fri, 18 Feb 2022 17:12:42 -0600
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 482eeb5c-9110-11ec-8723-dd0c611c5f35
Date: Fri, 18 Feb 2022 17:12:42 -0600
From: "Dr. Greg" <greg@enjellic.com>
To: Roger Pau Monn?? <roger.pau@citrix.com>
Cc: xen-devel@lists.xen.org
Subject: Re: IGD pass-through failures since 4.10.
Message-ID: <20220218231242.GA6668@wind.enjellic.com>
Reply-To: "Dr. Greg" <greg@enjellic.com>
References: <20220214060011.GA24404@wind.enjellic.com> <Ygoe/e+UzAtHe3Ac@Air-de-Roger>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Ygoe/e+UzAtHe3Ac@Air-de-Roger>
User-Agent: Mutt/1.4i
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.2.3 (wind.enjellic.com [127.0.0.1]); Fri, 18 Feb 2022 17:12:42 -0600 (CST)

On Mon, Feb 14, 2022 at 10:21:01AM +0100, Roger Pau Monn?? wrote:

Good afternoon, I hope the week has gone well for everyone.

> On Mon, Feb 14, 2022 at 12:00:11AM -0600, Dr. Greg wrote:

> >
> > [ Material removed ]
> >
> > It appears to be a problem with mapping interrupts back to dom0 given
> > that we see the following:
> > 
> > Feb 10 08:16:05 hostname kernel: xhci_hcd 0000:00:14.0: xen map irq failed -19 for 32752 domain
> > 
> > Feb 10 08:16:05 hostname kernel: i915 0000:00:02.0: xen map irq failed -19 for 32752 domain
> > 
> > Feb 10 08:16:12 hostname kernel: xhci_hcd 0000:00:14.0: Error while assigning device slot ID

> Are you testing with an hypervisor with debug enabled? If not,
> please build one and see if there are any messages in Xen dmesg also
> as a result of the error (uisng `xl dmesg` if you don't have a
> serial attached to the box). Posting full Linux and Xen dmesgs (Xen
> build with debug=y) could also help.

It was just a stock build out of the GIT tree.

We will get a debug hypervisors built and get traces out of the test
machine and post them to this thread.  I don't believe that dom0
kernel was talking very much about what was going on but we will
verify that.

> PHYSDEVOP_map_pirq is failing but without further information it's
> impossible to limit the scope of the issue (and whether the issue is
> with PHYSDEVOP_map_pirq or some previous operation).

Very useful piece of information to have.

>From the log messages above, I assume the kernel is getting ENODEV
from the hypervisor call.  We will see if we can get some targeted
debug statements into the hypervisor to figure out what is going on.

> Thanks, Roger.

Thank you for the follow-up, have a good weekend.

Dr. Greg

As always,
Dr. Greg Wettstein, Ph.D    Worker / Principal Engineer
IDfusion, LLC
4206 19th Ave N.            Specialists in SGX secured infrastructure.
Fargo, ND  58102
PH: 701-281-1686            CELL: 701-361-2319
EMAIL: gw@idfusion.org
------------------------------------------------------------------------------
"Real Programmers consider "what you see is what you get" to be just as
 bad a concept in Text Editors as it is in women.  No, the Real
 Programmer wants a "you asked for it, you got it" text editor --
 complicated, cryptic, powerful, unforgiving, dangerous."
                                -- Matthias Schniedermeyer


From xen-devel-bounces@lists.xenproject.org Fri Feb 18 23:14:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 18 Feb 2022 23:14:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275643.471606 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nLCRz-00076o-Hz; Fri, 18 Feb 2022 23:14:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275643.471606; Fri, 18 Feb 2022 23:14:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nLCRz-00076h-Ev; Fri, 18 Feb 2022 23:14:07 +0000
Received: by outflank-mailman (input) for mailman id 275643;
 Fri, 18 Feb 2022 23:14:05 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nLCRx-00076P-Gm; Fri, 18 Feb 2022 23:14:05 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nLCRx-0005Ev-DC; Fri, 18 Feb 2022 23:14:05 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nLCRx-0005Fq-1n; Fri, 18 Feb 2022 23:14:05 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nLCRx-0006Fs-1O; Fri, 18 Feb 2022 23:14:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=oQ4AIvcwHtf1bcyXVJRLc8vewHr37A9dRVE5cMbJQwo=; b=vOAnIIAzJ/De7e/1muPFYT2fmN
	WDSmMDKhZczXtTxiEIe/FTtSIjEMcV6Wb0aLH4VsBymPySDBYJpvEn4Q0wzjvrNjznuHhwocTKmVU
	HP/1zNJBNnqhgAzIht2UU69q05SOZTbTyPVKZP73Aw/DY53AOZpXx8clRphasePARK4g=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168167-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 168167: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=686f13cfce1d95464ff39fb59ac1f85163cea03b
X-Osstest-Versions-That:
    xen=8dc44294806c83456794ba9488b4b440aa6193c2
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 18 Feb 2022 23:14:05 +0000

flight 168167 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168167/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  686f13cfce1d95464ff39fb59ac1f85163cea03b
baseline version:
 xen                  8dc44294806c83456794ba9488b4b440aa6193c2

Last test of basis   168165  2022-02-18 14:03:03 Z    0 days
Testing same since   168167  2022-02-18 19:01:37 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Roger Pau Monne <roger.pau@citrix.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   8dc4429480..686f13cfce  686f13cfce1d95464ff39fb59ac1f85163cea03b -> smoke


From xen-devel-bounces@lists.xenproject.org Fri Feb 18 23:31:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 18 Feb 2022 23:31:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275657.471616 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nLCiO-00019R-4o; Fri, 18 Feb 2022 23:31:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275657.471616; Fri, 18 Feb 2022 23:31:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nLCiO-00019K-1i; Fri, 18 Feb 2022 23:31:04 +0000
Received: by outflank-mailman (input) for mailman id 275657;
 Fri, 18 Feb 2022 23:31:02 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=4/tq=TB=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nLCiM-00019E-ON
 for xen-devel@lists.xenproject.org; Fri, 18 Feb 2022 23:31:02 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d49be2b6-9112-11ec-8eb8-a37418f5ba1a;
 Sat, 19 Feb 2022 00:31:01 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id BF80BB826FE;
 Fri, 18 Feb 2022 23:30:59 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 32074C340E9;
 Fri, 18 Feb 2022 23:30:58 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d49be2b6-9112-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1645227058;
	bh=88AERh/QkWzUu4pRpqNxx4VC/sjCyonupm8mVWsqANU=;
	h=Date:From:To:cc:Subject:From;
	b=N/QZgOY2kQPQH+hQzqOuD6+Bg3tMcLQY6EaiC4Pyq+dDoQ9oDq0J+F5cSu97fo3H6
	 8nEqJ2nhiampaMbr9u3HqmT69COLhQCDPQRBeSo5TKH4luLMUwn7dh4/3DWXNKaSGj
	 MeuaiiMuAmmWl5OuTZ9AaJnybUdFLEuedmWjlMTAX/WApLogGjrhSVsAspt1fUEtcs
	 t3KzS0pMEG5X9c3i4g5QInvZQdnhswMtVUlLjfKu9bmZJQBC2yLiq5f5+IAV8cJKZf
	 jP6gzUt0D4OGRj0HliKS62Td+jFMqdLlLK3BpdzQcEyZID5eATH6jS9yBrmlUTfPDh
	 DFm9LfKHBG2yg==
Date: Fri, 18 Feb 2022 15:30:56 -0800 (PST)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: anthony.perard@citrix.com, wl@xen.org
cc: sstabellini@kernel.org, xen-devel@lists.xenproject.org, 
    christopher.w.clark@gmail.com, jgross@suse.com, bertrand.marquis@arm.com
Subject: [PATCH] tools/hotplug: don't install init.d scripts if SYSTEMD
Message-ID: <alpine.DEB.2.22.394.2202181525440.239973@ubuntu-linux-20-04-desktop>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

When Xen is configured with --with-systemd currently both the systemd
init scripts as well as the traditional init.d scripts (e.g. xencommons)
are installed.

This causes issues to distros where old style init scripts are still
supported even when systemd is enabled, e.g. Yocto. The consequence is
that xenconsoled (and other daemons) are executed twice resulting in
errors at boot.

If --with-systemd don't install xencommons and the other sysvinit
scripts.

Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>


diff --git a/tools/hotplug/Linux/Makefile b/tools/hotplug/Linux/Makefile
index 0b1d111d7e..03ed00ca70 100644
--- a/tools/hotplug/Linux/Makefile
+++ b/tools/hotplug/Linux/Makefile
@@ -47,10 +47,12 @@ install-initd:
 	$(INSTALL_DATA) init.d/sysconfig.xendomains $(DESTDIR)$(SYSCONFIG_DIR)/xendomains
 	$(INSTALL_DATA) init.d/sysconfig.xencommons $(DESTDIR)$(SYSCONFIG_DIR)/xencommons
 	$(INSTALL_PROG) xendomains $(DESTDIR)$(LIBEXEC_BIN)
+ifndef CONFIG_SYSTEMD
 	$(INSTALL_PROG) init.d/xendomains $(DESTDIR)$(INITD_DIR)
 	$(INSTALL_PROG) init.d/xencommons $(DESTDIR)$(INITD_DIR)
 	$(INSTALL_PROG) init.d/xendriverdomain $(DESTDIR)$(INITD_DIR)
 	$(INSTALL_PROG) init.d/xen-watchdog $(DESTDIR)$(INITD_DIR)
+endif
 
 .PHONY: uninstall-initd
 uninstall-initd:


From xen-devel-bounces@lists.xenproject.org Fri Feb 18 23:40:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 18 Feb 2022 23:40:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275664.471628 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nLCrs-0002eA-Vy; Fri, 18 Feb 2022 23:40:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275664.471628; Fri, 18 Feb 2022 23:40:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nLCrs-0002e3-Sp; Fri, 18 Feb 2022 23:40:52 +0000
Received: by outflank-mailman (input) for mailman id 275664;
 Fri, 18 Feb 2022 23:40:51 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=6Z2s=TB=citrix.com=prvs=041b9fbab=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nLCrr-0002dx-LQ
 for xen-devel@lists.xenproject.org; Fri, 18 Feb 2022 23:40:51 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 32b38512-9114-11ec-8eb8-a37418f5ba1a;
 Sat, 19 Feb 2022 00:40:49 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 32b38512-9114-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645227649;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=d1t8B7JvqtxBgtqAw0NwLR4XdNVHjjInxr42Sm1K8ZQ=;
  b=bfneBYciPlfoXkfIoY9EubQjwrs97lzp5zZ0+DWCyzYuIA0wfG9WeYNO
   1g1LGodg1lJzuyB8RsGmRhUa1VI+PsFfiJok/8n3moqCDa5far7+lZlY3
   5jgM3yO4FZire1MgtOgJ/J+UF8F2kBb/jY8imZlqYrEkxlVY59856LAGX
   Y=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 66802860
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:lJIqbKD2+Yy62hVW/8rjw5YqxClBgxIJ4kV8jS/XYbTApG4kgzUOz
 DMZWzjSP/yNZDT9fYolaYm1900Hup/XxoQ1QQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YhFWeIdA970Ug5w7Rg0tYz6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhR4
 +dXhYWxbjwrM5TLmtRFXEhHPn1xaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguwKKsXxMZxZkXZn1TzDVt4tQIzZQrWM7thdtNs1rp4QTa6EN
 5RBAdZpRAvwQUJLZnYdMrkZmeuavVjwKjp693vA8MLb5ECMlVcsgdABKuH9cdyQRN5JmV6Yq
 3iA4CLyBhgAN/SQzDOE9jSngeqntSH0QoUJD5Wj6+VnxlaUwwQ7AhAMSUGyp/X/j0ekQs9eM
 GQd4C9opq83nGSwVcX0VRC8pH+CvzYfVsBWHul87xuCooLL5y6JC25CSSROAPQ2uclzSTE02
 1uhm9LyGScpoLCTUWia9LqfsXW1Iyd9EIMZTXZaF01fuYCl+dxtyEKUJjp+LEKrpv3eKyvA2
 jGtlyozvrIRvZYEhrqWoV+S1lpAuaP1ZgIy4wzWWEes4QV4eJOpauSU1LTL0RpTBN3HFwfc5
 RDoj+DbtblTVs/VyERhVc1QROnB2hqTDNHLbbeD9bEF/i/lxXOsdJs4DNpWdBYwaZZsldMEj
 SbuVeJtCH17YSPCgUxfOdvZ5yEWIU7IT4iNuhf8NIcmX3SJXFXblByCnGbJt4wXrGAikLskJ
 bCQetu2AHARBMxPlWTqGr1EieR1nH1nlAs/oKwXKTz9jdJyg1bPFN843KamNLhlvMtoXi2Om
 zqgCyd640oGC7CvCsUm2YUSMUoLPRAG6WPe8KRqmhq4ClM+QgkJUqaJqZt4ItANt/kFx4/go
 yDmMmcFmQWXuJEyAVjTApyVQOi0BsgXQLNSFXFEAGtELFB5P970tf9HL8FfkHtO3LUL8MOYh
 sItIq2oKv9OVi7G63Iaa5z8p5ZlbxOlmUSFOC/NXdT1V8cIq9DhkjM8QjbSyQ==
IronPort-HdrOrdr: A9a23:V32VMq7lncXbbb7XKwPXwDLXdLJyesId70hD6qkQc3FomwKj9/
 xG/c5rsSMc7Qx6ZJhOo7+90cW7L080lqQFhLX5X43SPzUO0VHARO1fBOPZqAEIcBeOlNK1u5
 0AT0B/YueAcGSTj6zBkXWF+wBL+qj5zEiq792usUuEVWtRGsZdB58SMHfhLqVxLjM2Y6YRJd
 6nyedsgSGvQngTZtTTPAh+YwCSz+e77a4PeHQ9dmYa1DU=
X-IronPort-AV: E=Sophos;i="5.88,380,1635220800"; 
   d="scan'208";a="66802860"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Pd9KD45R1JEZFRDevwDqR5tNm26MWPAA0VLd1qpHDXJRU6qq3dMlCdsGnmiv/VQbT6H0SgvdPJJJL/WvAqIxkmgM6iiSAInFWSf6rRRbhCZp5W37NZ+xtfn+V5V9bxhNflcgZwJJwuOSOI/gEyA87HtEHy8WmRATKtlTos9rzrDcidYSEY8ewzbOw2wyC/7B7biDMLU2sx1Chgflw6xi035DFMmt2hjwed6bm7zFQkRAtNmxxq5LTTxx+g2m48EUDL/Nkz45uzI7/CtFOfrqUzD+cO3rLvrd20/yDhkRuBjnWFFba8LPS0ccirxlVEp3cvB0Jg02Ikm3oBOYsdZRTA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=d1t8B7JvqtxBgtqAw0NwLR4XdNVHjjInxr42Sm1K8ZQ=;
 b=MwKuucxYqIaVXxv40JIlFJbAa2ZdMVJDOWpjF5QP21qnnSdt/4gRSzP9fh7qxt9mOmoJpZjDPgDRNZ0X4y4PoErr8i6fVK/nKNQNh2S8tCwXnKCdKAfUu27n1g2FXtMG53t9D3hha4FzDvjKASaC5T2zSaMDrjy+OLxDwPKKaOTUOmTrfH6c815Wbdg+I0JQm2WzxIK55K8khlrYwg9KKVv2g96agFBTR10dfLlqRAjuPiEL60HccLwLTi+mm4kAVRQzEbkKsAgPvpegL5W+tvodUs6SgLQUSBhc/cxxQAG20w9WD/KhOdW9vbsKdO1qq43l7WYPiq7A/i3acd5ChA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=d1t8B7JvqtxBgtqAw0NwLR4XdNVHjjInxr42Sm1K8ZQ=;
 b=GNxGKP8uxtpaTSE+UL4pYRgZ4lc7QEx0beuN7wjkYIBvVwcFbwBLDDYN2SqlKI+jgBwVjNJbvdUTx5DVP/FBg3yRHBy/4T8w/bsK7C8now+iisaoj4getkqiUuu/Ufz6ghQkRBZ2tUkHEkUJOQk2PMZdfC+vBVel5uWOGBig9Ow=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Stefano Stabellini <sstabellini@kernel.org>, Anthony Perard
	<anthony.perard@citrix.com>, "wl@xen.org" <wl@xen.org>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"christopher.w.clark@gmail.com" <christopher.w.clark@gmail.com>,
	"jgross@suse.com" <jgross@suse.com>, "bertrand.marquis@arm.com"
	<bertrand.marquis@arm.com>
Subject: Re: [PATCH] tools/hotplug: don't install init.d scripts if SYSTEMD
Thread-Topic: [PATCH] tools/hotplug: don't install init.d scripts if SYSTEMD
Thread-Index: AQHYJR+qUOfXagHVfEujp222vc98OqyZ96IA
Date: Fri, 18 Feb 2022 23:40:43 +0000
Message-ID: <d801f210-7b01-8d20-921d-8ecc418e6fe3@citrix.com>
References: <alpine.DEB.2.22.394.2202181525440.239973@ubuntu-linux-20-04-desktop>
In-Reply-To: <alpine.DEB.2.22.394.2202181525440.239973@ubuntu-linux-20-04-desktop>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: aec26dcf-c287-493b-ab74-08d9f3381468
x-ms-traffictypediagnostic: SJ0PR03MB5807:EE_
x-microsoft-antispam-prvs: <SJ0PR03MB5807611966896CCF817D5BC9BA379@SJ0PR03MB5807.namprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: ZagtdV8KdqJh7uGsOJUooxAAYhKORDzBoL11c82Q7tnfKPOfqZQYN8kNxNKJsG5WDu/RV8S41mh9EQ8opocZMCdutq026CzGsYxqIqqvL25cvVNuN8SiwIftw/sJq3mJiGixE9FT4CEU36VcrLHz/HD1Pn0w02S8i1bXEiR3RZAKRCAZwUrmr5kUP14dJnliw4277O85So3ybD84TT+3iDCijX37QcghAqFWSJ/PPOWxKo9cbEDZRF+BPYqW4As0dn5ihignXS9/yZ5XdxF8TWtaJ1R5xlbacuT4xHJ0JW48jFGC4h3Ub0P9u47tPY/4Imteer42hIJeupUtoECD8G8MJGhTTQxBqAE9mtX2J5GH5ItJ3oNUAW+xZBdZFRm8+glyHvzYDYQSnBXZhaOQk+ef5hdbSqktewWa7t+Oynn2gz+6cr9d1/dKwsWKgxoQI5bW7EmxEOl/0+SzNO5++Ba8s7OoFTkfAMiZp+GtVY8mhRxdfWZQtT70WhKL4FfgZCNTV4H8ydvdIbmXr1WA/95kLr7pvbIGeC90rzDGstHNT53wz4Wief3gtYYMiQKYe86OmN4MY6cZDHVNQE+GTuKGeU3ApKt+YvUN/d5TnlKLW53XimSUOq5cMevG+0r0ADnrGjdQqPHCk1smjY+B3nzc99N4z+jknSRJuAqK/RWsqpqQgTcyQ+du/mr6mskR8BBI6j7ab0PFq21Gi+blhtr7yG1ZrYzsaRB6qXWr5q7q5As/KsHa4AFPhJZ0DFcbTFcaVlxADOsQbTpQT1zK7A==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(64756008)(76116006)(8676002)(91956017)(86362001)(4744005)(4326008)(66446008)(66476007)(66946007)(66556008)(31696002)(186003)(8936002)(5660300002)(26005)(122000001)(316002)(2906002)(38100700002)(82960400001)(110136005)(38070700005)(54906003)(31686004)(6512007)(53546011)(2616005)(6506007)(6486002)(508600001)(71200400001)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Y0d4d0hSc3RSYURmcVdPbHhYU2ZsK1BHOU1oRm9lSWw2bUREb0pvWGZCRXdm?=
 =?utf-8?B?Y1ZsdGduVTB6MHFXY09ESmg4V05ianJVRTNlYUdabUI1aFRhTWJrKy9mdUh6?=
 =?utf-8?B?eEpsQmdacnJVNGZTME9jVHlUa3cxU1ZVblgwR0pFNmgrY3lTeDh4R24ySHlB?=
 =?utf-8?B?SmFhZE5ybTQ3cS9wRWZaMzJBTnRweWN2TytZZ1FqM1BTRjNEOUYzblptclp1?=
 =?utf-8?B?a0pxcUsyZGx3SUMzSXQ3MUV6S0tSNDU1eTNHUTk0YzhPamhtcWh2Z0h1U3Jp?=
 =?utf-8?B?Z2g4Q0d4UGlSbktCODc0cHZQYkcrVllERnRkZkFuSDllQWNieG9POGltL3Zj?=
 =?utf-8?B?ZjhxSFpJT3V0WktpNzZ1VURVSDNJUU5TQ0lHQkhadmdNbFUvN3B0T1pVbXhP?=
 =?utf-8?B?b0trYmc1SGNQUlZ1Vkx0SEFHMnF0ZVBCcnRRa20zY3BOVTN4UkVPejNSQldW?=
 =?utf-8?B?UGh0bnBVMjhXVVY5VmJEVEtmZ3daNmwrVDNvNS9RK0tKejAxdlJBRXFEMjFs?=
 =?utf-8?B?SElMa1dpN0ozU3BkWmpPTloxYzVFUVFNYk1INDBUeHYwSDZVM05ZeCtHVm1Q?=
 =?utf-8?B?OHJ0Y0xadlNQQ1V3VVZQTXdTdk0xbU5JN3lUMDYwbTBGT01FWmVJdUNBRkk2?=
 =?utf-8?B?L0FLTmoyR3h6NHczaWxxVWZXSElNemx6bzZpa2F5Q0FCSWF5V00zc01oUm9U?=
 =?utf-8?B?WFB3VDVQbDlydHdJMlMza3hMQjUwRXMwT0l0SmVmWVB2NHBsTEQ5SldFTC9U?=
 =?utf-8?B?eFFQRFlHWFFrbGlGalZxb2U5bm1mWjlXMU1TRmlCWDFieFIyQzVISzNjUWpT?=
 =?utf-8?B?K2xqNU5FRVp3Z1V2dm5ST3lSTG55a0xyOC8vdGhaWUZJNnAyUXFJS2xBVjVR?=
 =?utf-8?B?b29KVEtYT2E4U21yVzhsMHJvYlE4b09nQUQ4TDZ4QlkzODI0aCtLYUZVa1RY?=
 =?utf-8?B?QmR2MHRJQTBaT1c1SkR1eFVuMUMxaGRVM1pNWCtKVCtnSlJJZWttTm5QUWk1?=
 =?utf-8?B?Tk1IOEpnMlVPb3gyWW9mKzRKTEpqano3NFMvaG1kT0FLVklHc2diRCtjRSth?=
 =?utf-8?B?VWFLZGFURitibXFxRGpzbjk4ZWxGT0lIazd1YU11M0FENHU0RSsvQ2lqdkpm?=
 =?utf-8?B?cFJ2WTdrRFdhWnRBK3pBTExoTDJTVDZIQVEwb2w3SUFYR0dhRVJkcDJPdlUv?=
 =?utf-8?B?N3V0YnQ0ZnJhQ1ZhSXVPaS92Rjd4Q2o3OGJjd25OVHkzc3M1clNUQ242bXBn?=
 =?utf-8?B?MGhzOGxkTUpsamhFTWNUalNIbXhobi9KQ3pXRjJvR0dJbUV2ZDVJNlhJazFt?=
 =?utf-8?B?YkYydTgvaTRYV1U2bXNjVnQ0WDFKMXdYKzBxSkQydDdHczMvRjF1eEo2VVBI?=
 =?utf-8?B?SHJVRnBhaEFNbU01TXdxeEJKWEVyY2ZKYmVJMXZoNWZYMmtWb3IrYlcwVzZi?=
 =?utf-8?B?UlNrUUx1V1ZOTXF1MnRYd1BjNzlvbTFyTW5reDgvc0Z3MHlHdC96WXhlQ0cy?=
 =?utf-8?B?ZUJvdlp5SEhyOE9HY1doNWp6TG51djdjMzNxZzVyeEZSUEhibDZPVUc5cnhZ?=
 =?utf-8?B?L0REakZNcXBMeVRkRjZycW1nOXdQWVU4ZFRoQnprZEdMai81M0FheklpcWR0?=
 =?utf-8?B?b0J0UVFka1FpRkdQdEphWEphRWpkMTJwQTVmNDhSMll5VXF4QzNSV1RDaldF?=
 =?utf-8?B?WFhOSnBVRUNsZzZkWStZbHd5TEZLeU1xTzBSR0N3eE9iYldIQVpiT1ppRlE3?=
 =?utf-8?B?SnRCdEVqakczYldEMGlPaVpsNlJ2OEM1NWxiSmdCUGJnQ0NzbzlVWSsxUTI3?=
 =?utf-8?B?SHA4NnR0bGtwR1Q3Ykx4NDNob3VmcFFKdlBkRHl4ajV1UHZhQnFibDR6ZldW?=
 =?utf-8?B?Znp4ajNVWW1YdUYwL3hnL2pKci9NRExnYmM3R1lCaG9ES0t3UDM3UkdVNW5N?=
 =?utf-8?B?UWpCc0QzbHViR3FvRDRBVC9PMGduTEdDZ2lhOXloZGVrR1NFQU96UHhLZjMw?=
 =?utf-8?B?Q1VBN2RyNWg1WVh2bXJJdFhrZWNEQmlSS25ObnJJR2lHaENRZHJZQnQvL2ZB?=
 =?utf-8?B?dDhoaG1NdWozNVJ1LytRT21tMnR1YW5KbGdORjJVdTdPajRadW5KZkdWUERn?=
 =?utf-8?B?VWlnZmZRRXBPbERvZHZkN3BLVTdUc0w5SzJobHdNSlNpcmZRRjl5aGFoUFBP?=
 =?utf-8?B?c1l4VXFkR2wvNUd5TDFGak1vZnlucUFLS1I5NHAzRXhWdzFVSnVrRHZZcFgw?=
 =?utf-8?B?QzVvSk9hQ05ERXZnUkswbnNMTlBRPT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <4BF94C25C9B7EC48A244319BD56BDED2@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: aec26dcf-c287-493b-ab74-08d9f3381468
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Feb 2022 23:40:43.3414
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Vdn5y5cOfXbUFDfJx3JrnmNhCQ6lJdwNCDHh2ufmP0jbO9hjm9edx11SSq5cQhxHsFdLz0gjELLZhi+QZ7QO8GslinkWAZpu7iT2PVHJUxI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5807
X-OriginatorOrg: citrix.com

T24gMTgvMDIvMjAyMiAyMzozMCwgU3RlZmFubyBTdGFiZWxsaW5pIHdyb3RlOg0KPiBXaGVuIFhl
biBpcyBjb25maWd1cmVkIHdpdGggLS13aXRoLXN5c3RlbWQgY3VycmVudGx5IGJvdGggdGhlIHN5
c3RlbWQNCj4gaW5pdCBzY3JpcHRzIGFzIHdlbGwgYXMgdGhlIHRyYWRpdGlvbmFsIGluaXQuZCBz
Y3JpcHRzIChlLmcuIHhlbmNvbW1vbnMpDQo+IGFyZSBpbnN0YWxsZWQuDQo+DQo+IFRoaXMgY2F1
c2VzIGlzc3VlcyB0byBkaXN0cm9zIHdoZXJlIG9sZCBzdHlsZSBpbml0IHNjcmlwdHMgYXJlIHN0
aWxsDQo+IHN1cHBvcnRlZCBldmVuIHdoZW4gc3lzdGVtZCBpcyBlbmFibGVkLCBlLmcuIFlvY3Rv
LiBUaGUgY29uc2VxdWVuY2UgaXMNCj4gdGhhdCB4ZW5jb25zb2xlZCAoYW5kIG90aGVyIGRhZW1v
bnMpIGFyZSBleGVjdXRlZCB0d2ljZSByZXN1bHRpbmcgaW4NCj4gZXJyb3JzIGF0IGJvb3QuDQo+
DQo+IElmIC0td2l0aC1zeXN0ZW1kIGRvbid0IGluc3RhbGwgeGVuY29tbW9ucyBhbmQgdGhlIG90
aGVyIHN5c3Zpbml0DQo+IHNjcmlwdHMuDQo+DQo+IFNpZ25lZC1vZmYtYnk6IFN0ZWZhbm8gU3Rh
YmVsbGluaSA8c3RlZmFuby5zdGFiZWxsaW5pQHhpbGlueC5jb20+DQoNCkkgYWdyZWUgd2l0aCB0
aGUgaW50ZW50LCBidXQganVzdCBiZWNhdXNlIHlvdSB3YW50IHRoZSBzeXN0ZW1kIGZpbGVzDQpk
b2Vzbid0IG1lYW4geW91IGRvbid0IHdhbnQgdGhlIHN5c3Zpbml0IGZpbGVzLsKgIChBbHNvLCBJ
J3ZlIGJlZW4gdHJ5aW5nDQp0byBwZXJzdWFkZSBBbHBpbmUgb3IgR2VudG9vIHRvIHVwc3RyZWFt
IHRoZSBPcGVuUkMgY29uZmlnIGZpbGVzIHRvbywNCndoaWNoIHdvdWxkIG1ha2UgYSAzcmQpLg0K
DQpUaGVyZSB3YW50cyB0byBiZSAtLXdpdGgtc3lzdmluaXQgKGRlZmF1bHRpbmcgdG8geSkgdG8g
Y29udHJvbGxpbmcgdGhpcywNCmF0IHdoaWNoIHBvaW50IGEgcGFja2FnZXIgY2FuIGNob3NlIGFu
eS9hbGwgaW5pdHN5c3RlbXMgd29ydGggb2YgY29uZmlnLg0KDQp+QW5kcmV3DQo=


From xen-devel-bounces@lists.xenproject.org Sat Feb 19 02:25:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 19 Feb 2022 02:25:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275675.471645 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nLFRJ-0003qc-Vc; Sat, 19 Feb 2022 02:25:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275675.471645; Sat, 19 Feb 2022 02:25:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nLFRJ-0003qV-RJ; Sat, 19 Feb 2022 02:25:37 +0000
Received: by outflank-mailman (input) for mailman id 275675;
 Sat, 19 Feb 2022 02:25:35 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nLFRH-0003qK-MD; Sat, 19 Feb 2022 02:25:35 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nLFRH-00030b-J4; Sat, 19 Feb 2022 02:25:35 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nLFRH-0005wb-1a; Sat, 19 Feb 2022 02:25:35 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nLFRH-0005Po-1A; Sat, 19 Feb 2022 02:25:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=wnYjQ0ReXcH5CmgSQOcZR7TDzej26OdCzVkoF+YrLoA=; b=wYzQQPFNSHOgWnnI6Zit8D4xPp
	b1xxmWFI+n5+yKIzQkcXIrLosVQA38i8Tn897byld+RU7d1dDDFslfmmUY8CLPHOUv62jbOANZM0/
	me0nQIqBU7iK6WSefjPQsvrTkNr5ETLgKcU/0e0GY5hACJzyrp27/84MBn06hHU0ndww=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168166-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 168166: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-arm64-arm64-xl-vhd:guest-start/debian.repeat:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:allowable
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=7993e65fdd0fe07beb9f36f998f9bbef2c0ee391
X-Osstest-Versions-That:
    linux=9195e5e0adbb8a9a5ee9ef0f9dedf6340d827405
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 19 Feb 2022 02:25:35 +0000

flight 168166 linux-linus real [real]
flight 168169 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/168166/
http://logs.test-lab.xenproject.org/osstest/logs/168169/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-xl-vhd 17 guest-start/debian.repeat fail pass in 168169-retest

Regressions which are regarded as allowable (not blocking):
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10   fail REGR. vs. 168158

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168158
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168158
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168158
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168158
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168158
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168158
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168158
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168158
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                7993e65fdd0fe07beb9f36f998f9bbef2c0ee391
baseline version:
 linux                9195e5e0adbb8a9a5ee9ef0f9dedf6340d827405

Last test of basis   168158  2022-02-18 03:14:21 Z    0 days
Testing same since   168166  2022-02-18 18:09:53 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Adam Manzanares <a.manzanares@samsung.com>
  Amir Goldstein <amir73il@gmail.com>
  Anders Roxell <anders.roxell@linaro.org>
  Ansuel Smith <ansuelsmth@gmail.com>
  Benson Leung <bleung@chromium.org>
  Bryan O'Donoghue <bryan.odonoghue@linaro.org>
  Catalin Marinas <catalin.marinas@arm.com>
  Cezary Rojewski <cezary.rojewski@intel.com>
  Charles Keepax <ckeepax@opensource.cirrus.com>
  Cheng-Yi Chiang <cychiang@chromium.org>
  Christian Eggers <ceggers@arri.de>
  Christoph Hellwig <hch@lst.de>
  Christophe Leroy <christophe.leroy@csgroup.eu>
  Dan Carpenter <dan.carpenter@oracle.com>
  david regan <dregan@mail.com>
  Guenter Roeck <linux@roeck-us.net>
  Haimin Zhang <tcs.kernel@gmail.com>
  Jens Axboe <axboe@kernel.dk>
  Joakim Tjernlund <joakim.tjernlund@infinera.com>
  Kai Vehmanen <kai.vehmanen@linux.intel.com>
  Laibin Qiu <qiulaibin@huawei.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Mark Brown <broonie@kernel.org>
  Martin Povišer <povik+lin@cutebit.org>
  Matteo Martelli <matteomartelli3@gmail.com>
  Miaoqian Lin <linmq006@gmail.com>
  Michael Ellerman <mpe@ellerman.id.au>
  Ming Lei <ming.lei@redhat.com>
  Ming Lei <ming.lei@rehdat.com>
  Miquel Raynal <miquel.raynal@bootlin.com>
  Pankaj Raghav <p.raghav@samsung.com>
  Roger Quadros <rogerq@kernel.org>
  Ronnie Sahlberg <lsahlber@redhat.com>
  Stephen Boyd <swboyd@chromium.org>
  Steve French <stfrench@microsoft.com>
  Takashi Iwai <tiwai@suse.de>
  Tzung-Bi Shih <tzungbi@google.com>
  V sujith kumar Reddy <vsujithkumar.reddy@amd.com>
  Yu Huang <diwang90@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   9195e5e0adbb..7993e65fdd0f  7993e65fdd0fe07beb9f36f998f9bbef2c0ee391 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Sat Feb 19 06:21:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 19 Feb 2022 06:21:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275688.471656 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nLJ6z-0001M3-Ut; Sat, 19 Feb 2022 06:20:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275688.471656; Sat, 19 Feb 2022 06:20:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nLJ6z-0001Lw-Pi; Sat, 19 Feb 2022 06:20:53 +0000
Received: by outflank-mailman (input) for mailman id 275688;
 Sat, 19 Feb 2022 06:20:52 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nLJ6y-0001Lm-AA; Sat, 19 Feb 2022 06:20:52 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nLJ6y-0007qs-7X; Sat, 19 Feb 2022 06:20:52 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nLJ6x-00082S-Nc; Sat, 19 Feb 2022 06:20:51 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nLJ6x-0005Eg-NC; Sat, 19 Feb 2022 06:20:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Sk1VglxhLeLAFkFbKqjwQ6eWidmIdLRvhVtItf0M3/k=; b=cBFlZj8k30Dv8dTYVsrd5HOamo
	4IWHjt2hhJQ4fdHoi0SFgdTO8opmBYlODTlQtmd5FCCg09dn6hwXx+9mvQY+Z6m+FAn4C61sDJlGs
	vAolDaAtIf5LhpH54DAqKi00S63vsSPhPu+JZQyIqYiN/ox7GF9DOOcs+JP4X8j9Dx9A=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168168-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 168168: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-i386-freebsd10-amd64:guest-start/freebsd.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=8dc44294806c83456794ba9488b4b440aa6193c2
X-Osstest-Versions-That:
    xen=4ec51e87804bd9aad0d0b8e5dadb987b54c5adeb
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 19 Feb 2022 06:20:51 +0000

flight 168168 xen-unstable real [real]
flight 168172 xen-unstable real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/168168/
http://logs.test-lab.xenproject.org/osstest/logs/168172/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-i386-freebsd10-amd64 21 guest-start/freebsd.repeat fail pass in 168172-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168161
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168161
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168161
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168161
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168161
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168161
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168161
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168161
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168161
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168161
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168161
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168161
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  8dc44294806c83456794ba9488b4b440aa6193c2
baseline version:
 xen                  4ec51e87804bd9aad0d0b8e5dadb987b54c5adeb

Last test of basis   168161  2022-02-18 10:14:12 Z    0 days
Testing same since   168168  2022-02-18 20:38:21 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              fail    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   4ec51e8780..8dc4429480  8dc44294806c83456794ba9488b4b440aa6193c2 -> master


From xen-devel-bounces@lists.xenproject.org Sat Feb 19 09:27:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 19 Feb 2022 09:27:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275733.471747 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nLM1D-0002uv-C5; Sat, 19 Feb 2022 09:27:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275733.471747; Sat, 19 Feb 2022 09:27:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nLM1D-0002uo-8m; Sat, 19 Feb 2022 09:27:07 +0000
Received: by outflank-mailman (input) for mailman id 275733;
 Sat, 19 Feb 2022 09:27:05 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nLM1B-0002ue-3u; Sat, 19 Feb 2022 09:27:05 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nLM1B-0003Om-0s; Sat, 19 Feb 2022 09:27:05 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nLM1A-0008NP-KD; Sat, 19 Feb 2022 09:27:04 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nLM1A-0002hw-Jj; Sat, 19 Feb 2022 09:27:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=OfFRiK7T4+7ze2lYQMb1QlcuhaK2FBoMKEXlG5hqPV4=; b=yrlHHSv8szifPcLmTiNjEoqklj
	LQZIDeds6Uefmc/A/JQ9R+jvYG3pw0AFzDJqkTyhuULyq3pQY2WPnOn2gHkQfZ7ABIt6tWbB3lT9Q
	hK2UmUqhNuiTe/NUfwvAwd8CJGkmGwJfMAwi6uvRdfWRHuW+LZtfQwyBM1qew6kgt4HE=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168171-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 168171: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=454b927d1e33a1fe9dca535db2c97300fdae62cc
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 19 Feb 2022 09:27:04 +0000

flight 168171 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168171/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              454b927d1e33a1fe9dca535db2c97300fdae62cc
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  589 days
Failing since        151818  2020-07-11 04:18:52 Z  588 days  570 attempts
Testing same since   168171  2022-02-19 04:18:57 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brad Laue <brad@brad-x.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Christophe Fergeau <cfergeau@redhat.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Divya Garg <divya.garg@nutanix.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Emilio Herrera <ehespinosa57@gmail.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Ivan Teterevkov <ivan.teterevkov@nutanix.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jing Qi <jinqi@redhat.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Lubomir Rintel <lkundrak@v3.sk>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nicolas Lécureuil <neoclust@mageia.org>
  Nicolas Lécureuil <nicolas.lecureuil@siveo.net>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Rohit Kumar <rohit.kumar3@nutanix.com>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  shenjiatong <yshxxsjt715@gmail.com>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tu Qiang <tu.qiang35@zte.com.cn>
  Tuguoyi <tu.guoyi@h3c.com>
  tuqiang <tu.qiang35@zte.com.cn>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Vineeth Pillai <viremana@linux.microsoft.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yasuhiko Kamata <belphegor@belbel.or.jp>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 98477 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Feb 19 11:10:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 19 Feb 2022 11:10:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275746.471757 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nLNdL-00054m-Lt; Sat, 19 Feb 2022 11:10:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275746.471757; Sat, 19 Feb 2022 11:10:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nLNdL-00054f-Ip; Sat, 19 Feb 2022 11:10:35 +0000
Received: by outflank-mailman (input) for mailman id 275746;
 Sat, 19 Feb 2022 11:10:34 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nLNdK-00054V-0d; Sat, 19 Feb 2022 11:10:34 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nLNdJ-0005Mb-Rk; Sat, 19 Feb 2022 11:10:33 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nLNdJ-0004Xu-Fd; Sat, 19 Feb 2022 11:10:33 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nLNdJ-0007pJ-FH; Sat, 19 Feb 2022 11:10:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=BCPJ99Ek23OkyUv+D671fFYRrc+F5aI5su1PyvJQxeo=; b=BWI1FcdeocLBfEBMkMr9hgA2tZ
	11cUAT7UvQEXEm8y81M64xO6yJjspybsOaP6ihm8Z4rBLeVj6Cme9AKYECnLF9HjPngYaLIv/wh5H
	YZlGxY4G60hcijQk9pni/bg/3fUIrLl6+zozizJe4kHaf1Zev9bfWO04eZRYLAK9xjzE=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168170-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 168170: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=4f12b742eb2b3a850ac8be7dc4ed52976fc6cb0b
X-Osstest-Versions-That:
    linux=7993e65fdd0fe07beb9f36f998f9bbef2c0ee391
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 19 Feb 2022 11:10:33 +0000

flight 168170 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168170/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10       fail  like 168166
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168166
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168166
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168166
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168166
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168166
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168166
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168166
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168166
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                4f12b742eb2b3a850ac8be7dc4ed52976fc6cb0b
baseline version:
 linux                7993e65fdd0fe07beb9f36f998f9bbef2c0ee391

Last test of basis   168166  2022-02-18 18:09:53 Z    0 days
Testing same since   168170  2022-02-19 02:28:10 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Anna Schumaker <Anna.Schumaker@Netapp.com>
  Atish Patra <atishp@rivosinc.com>
  Dan Williams <dan.j.williams@intel.com>
  Donald Buczek <buczek@molgen.mpg.de>
  Geert Uytterhoeven <geert@linux-m68k.org>
  Linus Torvalds <torvalds@linux-foundation.org>
  Palmer Dabbelt <palmer@rivosinc.com>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Trond Myklebust <trond.myklebust@hammerspace.com>
  Woody Suwalski <wsuwalski@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   7993e65fdd0f..4f12b742eb2b  4f12b742eb2b3a850ac8be7dc4ed52976fc6cb0b -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Sat Feb 19 11:24:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 19 Feb 2022 11:24:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275757.471769 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nLNr0-0006aY-T4; Sat, 19 Feb 2022 11:24:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275757.471769; Sat, 19 Feb 2022 11:24:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nLNr0-0006aR-Q4; Sat, 19 Feb 2022 11:24:42 +0000
Received: by outflank-mailman (input) for mailman id 275757;
 Sat, 19 Feb 2022 11:24:42 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=teU/=TC=twosheds.srs.infradead.org=BATV+40acfcbe1360a33f4347+6754+infradead.org+dwmw2@srs-se1.protection.inumbo.net>)
 id 1nLNqz-0006aL-IV
 for xen-devel@lists.xenproject.org; Sat, 19 Feb 2022 11:24:42 +0000
Received: from twosheds.infradead.org (unknown
 [2001:8b0:10b:1:aaa1:59ff:fe2f:55f7])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 82f2eb40-9176-11ec-8eb8-a37418f5ba1a;
 Sat, 19 Feb 2022 12:24:36 +0100 (CET)
Received: from localhost ([127.0.0.1] helo=twosheds.infradead.org)
 by twosheds.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nLNqi-00HAKw-T8; Sat, 19 Feb 2022 11:24:25 +0000
Received: from 213.205.198.58 (SquirrelMail authenticated user dwmw2)
 by twosheds.infradead.org with HTTP; Sat, 19 Feb 2022 11:24:25 -0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 82f2eb40-9176-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=twosheds.20170209; h=Content-Transfer-Encoding:
	Content-Type:MIME-Version:Cc:To:From:Subject:Date:References:In-Reply-To:
	Message-ID:Sender:Reply-To:Content-ID:Content-Description;
	bh=18M5bAzaOzMosPRkCjGj+3xBT8/uvub9kNysc83iM8o=; b=ZuH+djneu3h7V2MmraMAnDAeI0
	nsLuJYDVJKGMVvLmZeu2VtcPo+Q8KvoRZC46eSPbnSKTTNJZ54RpMVlOeEUzHg2/H7Nc6v2dan6iN
	lIRkhVgUnig+VeJ13OTD0PyyWMEquX+aY0F25oJ+1Bfe+7ysrw9aaB0viaeTMlCpe37/lXecP7AV1
	9+JEnch8P79JE+vqsn9COUKmSEz1tma5TdVkyVGSvFKX5hAohDwjHzMtTCzxMM5Ggod7EsGSjSaDw
	xpcd2l1JKrkeLpurH46/nuy0ltS2w9Wt2kDVXNFq53r5N2TrmbF/gdOq/s5U3WDN4klvNqNg99yVE
	HlLFqpcg==;
Message-ID: <4d89ffe13d2579096c955edf800b5c86.squirrel@twosheds.infradead.org>
In-Reply-To: <Yg4UPzFk15tJGo0B@Air-de-Roger>
References: <20220216103026.11533-1-roger.pau@citrix.com>
    <20220216103026.11533-2-roger.pau@citrix.com>
    <979fbc26-925c-f58f-9c1a-9ccd72275c9b@suse.com>
    <fd22f7e19590b0e8679e5a3a15992bd1f8a92126.camel@infradead.org>
    <9b5a8474-0be2-b4e6-8919-7e22dde1570a@suse.com>
    <Yg4UPzFk15tJGo0B@Air-de-Roger>
Date: Sat, 19 Feb 2022 11:24:25 -0000
Subject: Re: [PATCH v2 1/5] x86/cpuid: add CPUID flag for Extended
 Destination ID support
From: "David Woodhouse" <dwmw2@infradead.org>
To: =?utf-8?B?IlJvZ2VyIFBhdSBNb25uw6ki?= <roger.pau@citrix.com>
Cc: "Jan Beulich" <jbeulich@suse.com>,
 "David Woodhouse" <dwmw2@infradead.org>,
 "Andrew Cooper" <andrew.cooper3@citrix.com>,
 "Wei Liu" <wl@xen.org>,
 xen-devel@lists.xenproject.org
User-Agent: SquirrelMail/1.4.23 [SVN]-7.fc34.20220108
MIME-Version: 1.0
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: 8bit
X-Priority: 3 (Normal)
Importance: Normal
X-SRS-Rewrite: SMTP reverse-path rewritten from <dwmw2@infradead.org> by twosheds.infradead.org. See http://www.infradead.org/rpr.html



> /*
>  * With interrupt format set to 0 (non-remappable) bits 55:49 from the
>  * IO-APIC RTE and bits 11:5 from the MSI address can be used to store
>  * high bits for the Destination ID. This expands the Destination ID
>  * field from 8 to 15 bits, allowing to target APIC IDs up 32768.
>  */

I am not keen on that wording because it doesn't seem to fully reflect the
fact that the I/OAPIC is just a device to turn line interrupts into MSIs.
The values in bits 55:49 of the RTE *are* what go into bits 11:5 of the
resulting MSI address. Perhaps make it more parenthetical to make it
clearer that they are not independent... "bits 11:5 of the MSI address
(which come from bits 55:49 of the I/OAPIC RTE)..."


-- 
dwmw2



From xen-devel-bounces@lists.xenproject.org Sat Feb 19 15:01:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 19 Feb 2022 15:01:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275773.471795 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nLRES-00029t-J0; Sat, 19 Feb 2022 15:01:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275773.471795; Sat, 19 Feb 2022 15:01:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nLRES-00029m-G7; Sat, 19 Feb 2022 15:01:08 +0000
Received: by outflank-mailman (input) for mailman id 275773;
 Sat, 19 Feb 2022 15:01:06 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nLREQ-00029c-Nm; Sat, 19 Feb 2022 15:01:06 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nLREQ-0001Ij-LR; Sat, 19 Feb 2022 15:01:06 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nLREQ-0002vJ-4B; Sat, 19 Feb 2022 15:01:06 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nLREQ-0005z0-3l; Sat, 19 Feb 2022 15:01:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=MTAa5DA0aoLA1FlMcvb6AUH1Kx7DZVOrpyG+vh5cR68=; b=xtotD7V5rywowMK4rsX46g95VP
	j4it0oDcj7/MurZVxhgRr+jTVsyOnF4VfOzsAtuvZM7DT+Vg1nrH4HZcqNb1kPcc/88mKLIuRKg8L
	SJDbHurCzUazuHTnyYp3aY2kiI3wF5hPMItVDtwHtMsxJlNL9nIfowZSa2lL73CfFsT8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168173-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 168173: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=686f13cfce1d95464ff39fb59ac1f85163cea03b
X-Osstest-Versions-That:
    xen=8dc44294806c83456794ba9488b4b440aa6193c2
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 19 Feb 2022 15:01:06 +0000

flight 168173 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168173/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168168
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168168
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168168
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168168
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168168
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168168
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168168
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168168
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168168
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168168
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168168
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168168
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  686f13cfce1d95464ff39fb59ac1f85163cea03b
baseline version:
 xen                  8dc44294806c83456794ba9488b4b440aa6193c2

Last test of basis   168168  2022-02-18 20:38:21 Z    0 days
Testing same since   168173  2022-02-19 06:22:48 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Roger Pau Monne <roger.pau@citrix.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   8dc4429480..686f13cfce  686f13cfce1d95464ff39fb59ac1f85163cea03b -> master


From xen-devel-bounces@lists.xenproject.org Sat Feb 19 22:07:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 19 Feb 2022 22:07:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275786.471806 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nLXsw-0007n5-H5; Sat, 19 Feb 2022 22:07:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275786.471806; Sat, 19 Feb 2022 22:07:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nLXsw-0007my-E7; Sat, 19 Feb 2022 22:07:22 +0000
Received: by outflank-mailman (input) for mailman id 275786;
 Sat, 19 Feb 2022 22:07:20 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nLXsu-0007mo-N5; Sat, 19 Feb 2022 22:07:20 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nLXsu-0001Lt-Ki; Sat, 19 Feb 2022 22:07:20 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nLXsu-0000pL-2i; Sat, 19 Feb 2022 22:07:20 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nLXsu-0006v1-2F; Sat, 19 Feb 2022 22:07:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=F2vgG01OHrs61/WcuhaACmg8JKWfzB62C2yTIDREqAs=; b=0NJgJS27U/yxZ/UKcohH/eTgEM
	aXwZOYPm4qxUafaViCjYOnx0HKw/W/eL8VuAMOYTMYDuzuD0COXV9V1ezfava9FgtVpCzbDGR0qZG
	Fmf069BL2lhwSSr1vjiT8xKMs3RunvgWNd2MOto6z3qAVgprhSHaYjR6td4Eub94PR3I=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168174-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 168174: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable
    qemu-mainline:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=439346ce8fa32095433a9abb2aa3564d11283372
X-Osstest-Versions-That:
    qemuu=c13b8e9973635f34f3ce4356af27a311c993729c
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 19 Feb 2022 22:07:20 +0000

flight 168174 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168174/

Failures :-/ but no regressions.

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds    18 guest-start/debian.repeat fail REGR. vs. 168139

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10       fail  like 168139
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168139
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168139
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168139
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168139
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168139
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168139
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168139
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168139
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                439346ce8fa32095433a9abb2aa3564d11283372
baseline version:
 qemuu                c13b8e9973635f34f3ce4356af27a311c993729c

Last test of basis   168139  2022-02-16 15:37:01 Z    3 days
Testing same since   168174  2022-02-19 15:39:39 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Greg Kurz <groug@kaod.org>
  Peter Maydell <peter.maydell@linaro.org>
  Vitaly Chikunov <vt@altlinux.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   c13b8e9973..439346ce8f  439346ce8fa32095433a9abb2aa3564d11283372 -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Sun Feb 20 07:36:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 20 Feb 2022 07:36:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275802.471817 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nLglf-0004VO-IX; Sun, 20 Feb 2022 07:36:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275802.471817; Sun, 20 Feb 2022 07:36:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nLglf-0004VH-Fd; Sun, 20 Feb 2022 07:36:27 +0000
Received: by outflank-mailman (input) for mailman id 275802;
 Sun, 20 Feb 2022 07:36:26 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nLgle-0004V7-Bk; Sun, 20 Feb 2022 07:36:26 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nLgle-0006rQ-9A; Sun, 20 Feb 2022 07:36:26 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nLgld-0004FE-SY; Sun, 20 Feb 2022 07:36:25 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nLgld-0002zB-S4; Sun, 20 Feb 2022 07:36:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=cLaMLrzMnz306JYHJ0BW3Z0kYOPnYC0sVkMNiFjPK1Y=; b=ljxL1Gbv63l7s1JuGIkzvQWwOD
	6mjJ/HHV+qNRy4TeT1yUAErR7pDKwnGVH6voAqWgETGZkekCjuhmG1WWXGjZWtxcmF6od4p4knLFY
	g8RWUwjZ6lq3hsBttuBMEHn4xkgbw/jl5NmYwbhMdmZc9FGysXAkJgB2pc5SQm37AR7w=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168176-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 168176: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=454b927d1e33a1fe9dca535db2c97300fdae62cc
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 20 Feb 2022 07:36:25 +0000

flight 168176 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168176/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              454b927d1e33a1fe9dca535db2c97300fdae62cc
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  590 days
Failing since        151818  2020-07-11 04:18:52 Z  589 days  571 attempts
Testing same since   168171  2022-02-19 04:18:57 Z    1 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brad Laue <brad@brad-x.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Christophe Fergeau <cfergeau@redhat.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Divya Garg <divya.garg@nutanix.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Emilio Herrera <ehespinosa57@gmail.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Ivan Teterevkov <ivan.teterevkov@nutanix.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jing Qi <jinqi@redhat.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Lubomir Rintel <lkundrak@v3.sk>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nicolas Lécureuil <neoclust@mageia.org>
  Nicolas Lécureuil <nicolas.lecureuil@siveo.net>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Rohit Kumar <rohit.kumar3@nutanix.com>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  shenjiatong <yshxxsjt715@gmail.com>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tu Qiang <tu.qiang35@zte.com.cn>
  Tuguoyi <tu.guoyi@h3c.com>
  tuqiang <tu.qiang35@zte.com.cn>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Vineeth Pillai <viremana@linux.microsoft.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yasuhiko Kamata <belphegor@belbel.or.jp>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 98477 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Feb 20 09:49:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 20 Feb 2022 09:49:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275822.471828 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nLiqG-0000UN-9p; Sun, 20 Feb 2022 09:49:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275822.471828; Sun, 20 Feb 2022 09:49:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nLiqG-0000UG-6r; Sun, 20 Feb 2022 09:49:20 +0000
Received: by outflank-mailman (input) for mailman id 275822;
 Sun, 20 Feb 2022 09:49:18 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nLiqE-0000U6-TA; Sun, 20 Feb 2022 09:49:18 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nLiqE-0001Ty-OP; Sun, 20 Feb 2022 09:49:18 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nLiqE-0007xF-Cs; Sun, 20 Feb 2022 09:49:18 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nLiqE-0007jg-CR; Sun, 20 Feb 2022 09:49:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=S0EMfC5jK9NJnXE8h92L8qn7Qq6XMRE2QhXLPltg7Bk=; b=fVPpfOA8gVaxTjImJlN6cugWfD
	aZ6Rh+qCcE1O4DQrxXpDMR4qQArbiRol8fnI9WPfI8LHxQUjpVjp/faWS0mt+1C5thy5C2KNtJx7R
	fCT2h7wcAmO9FVj5HvS9+8nwWJi4j5stheQHvkw05WqMEIqOhVcy6WGbP3IeZAhrBF8M=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168177-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-coverity test] 168177: all pass - PUSHED
X-Osstest-Versions-This:
    xen=686f13cfce1d95464ff39fb59ac1f85163cea03b
X-Osstest-Versions-That:
    xen=e7c2017cf4a91ab6a0fea6adca2d9dd2ab1603b0
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 20 Feb 2022 09:49:18 +0000

flight 168177 xen-unstable-coverity real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168177/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 xen                  686f13cfce1d95464ff39fb59ac1f85163cea03b
baseline version:
 xen                  e7c2017cf4a91ab6a0fea6adca2d9dd2ab1603b0

Last test of basis   168128  2022-02-16 09:19:44 Z    4 days
Testing same since   168177  2022-02-20 09:19:40 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Julien Grall <jgrall@amazon.com>
  Penny Zheng <penny.zheng@arm.com>
  Roger Pau Monne <roger.pau@citrix.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Stefano Stabellini <sstabellini@kernel.org>
  Stefano Stabellini <stefano.stabellini@xilinx.com>

jobs:
 coverity-amd64                                               pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   e7c2017cf4..686f13cfce  686f13cfce1d95464ff39fb59ac1f85163cea03b -> coverity-tested/smoke


From xen-devel-bounces@lists.xenproject.org Sun Feb 20 10:36:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 20 Feb 2022 10:36:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275834.471839 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nLjaB-0005bW-RD; Sun, 20 Feb 2022 10:36:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275834.471839; Sun, 20 Feb 2022 10:36:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nLjaB-0005bP-OC; Sun, 20 Feb 2022 10:36:47 +0000
Received: by outflank-mailman (input) for mailman id 275834;
 Sun, 20 Feb 2022 10:36:45 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nLja9-0005bF-Tp; Sun, 20 Feb 2022 10:36:45 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nLja9-0002Qz-QP; Sun, 20 Feb 2022 10:36:45 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nLja9-0000gE-F5; Sun, 20 Feb 2022 10:36:45 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nLja9-0005iy-Eb; Sun, 20 Feb 2022 10:36:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=h5eoLORnyjJQzFbDD9QD6jvQ6BCBDjEiux+BgGJOpwI=; b=jFAEalbVegVXhww6tZjiZpKrHb
	d4AQkZWRGfKfHV3tJDAWRJSb0VAmMiusWa8+RG7ry0kxjRkRQjr2zzEN+o6kkJniC1HJFkyN5Dkdn
	m6uEE8erx9QU3zmNwyq8rYuU9p7yCpKv8ijjDLpTe8FWmvKSvA+y/eaX+irYE4+ltZM0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168175-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 168175: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-arm64-arm64-xl-seattle:xen-boot:fail:heisenbug
    xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=686f13cfce1d95464ff39fb59ac1f85163cea03b
X-Osstest-Versions-That:
    xen=686f13cfce1d95464ff39fb59ac1f85163cea03b
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 20 Feb 2022 10:36:45 +0000

flight 168175 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168175/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-xl-seattle   8 xen-boot                   fail pass in 168173
 test-armhf-armhf-xl-rtds     18 guest-start/debian.repeat  fail pass in 168173

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl-seattle 15 migrate-support-check fail in 168173 never pass
 test-arm64-arm64-xl-seattle 16 saverestore-support-check fail in 168173 never pass
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168173
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168173
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168173
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168173
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168173
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168173
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168173
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168173
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168173
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168173
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168173
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168173
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  686f13cfce1d95464ff39fb59ac1f85163cea03b
baseline version:
 xen                  686f13cfce1d95464ff39fb59ac1f85163cea03b

Last test of basis   168175  2022-02-20 01:54:18 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Sun Feb 20 13:49:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 20 Feb 2022 13:49:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275850.471850 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nLmam-0006SY-Vd; Sun, 20 Feb 2022 13:49:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275850.471850; Sun, 20 Feb 2022 13:49:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nLmam-0006SR-SS; Sun, 20 Feb 2022 13:49:36 +0000
Received: by outflank-mailman (input) for mailman id 275850;
 Sun, 20 Feb 2022 13:49:35 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=84H/=TD=invisiblethingslab.com=marmarek@srs-se1.protection.inumbo.net>)
 id 1nLmak-0006SL-RA
 for xen-devel@lists.xenproject.org; Sun, 20 Feb 2022 13:49:35 +0000
Received: from wnew3-smtp.messagingengine.com (wnew3-smtp.messagingengine.com
 [64.147.123.17]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ecb18b16-9253-11ec-8eb8-a37418f5ba1a;
 Sun, 20 Feb 2022 14:49:31 +0100 (CET)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailnew.west.internal (Postfix) with ESMTP id 63AE62B00158;
 Sun, 20 Feb 2022 08:49:27 -0500 (EST)
Received: from mailfrontend1 ([10.202.2.162])
 by compute1.internal (MEProxy); Sun, 20 Feb 2022 08:49:28 -0500
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun,
 20 Feb 2022 08:49:25 -0500 (EST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ecb18b16-9253-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-transfer-encoding
	:content-type:date:date:from:from:in-reply-to:message-id
	:mime-version:reply-to:sender:subject:subject:to:to:x-me-proxy
	:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=Hzfm38
	gwPt5b09qOmLkmmfY2IIYl8DekKzBTC8y6E/4=; b=Mh2eOvmHHkVx++fz80uns8
	7+Y+xWxOHRMVpsAEIc1iX9iGRssSrqTt4DEoPDkKx1zMSVEFmktobYjSc+Q1vqpE
	NB3k0jRzA8yiLumKKiNCTPhOv39knberB8iIy1iNXVam1m3xZ6RSDAXrqrZv8jX+
	22yZfgzepiyULlT8Tz9i7x1r8X55zgZl8EZFYADfPMtKl/mzHfYyUHRn9F32L8x5
	AKBkMSn9RahYlDyjeZLmzBXrhHBv5seX3OlpAlQfvr+eIxQRsqqhKWY76ow10uQ1
	6Mdrffpszfy/cfGdr0ALfw3W1veNut0gsBQH0iw9CHa0rkPUs2n6BxamINmtawbw
	==
X-ME-Sender: <xms:5kYSYlZgeDpGHPwBYlonXCSlDA0koRyD9axOwL3Z0YRw_CmQo-vWOw>
    <xme:5kYSYsZkDLdYwizt3-sWnDo0Ek_-VY4wz4nUUXDRQm0KjWCCWcgIghGQQDlmgRR1H
    gUdKOwZErNerA>
X-ME-Received: <xmr:5kYSYn8kuaTIvJOQXtNXDSf_ZOaNsWIkXIB_zr2Ob-zXUb5UEpK2gIRWp0tu1j402tCpXi8AMuyBoBnqBS-_PsBDhHnIRE1I6n7OsbTNlbAh77k7t4A>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrkeeggdehkecutefuodetggdotefrodftvf
    curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
    uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
    fjughrpefhvffufffkofggtghogfesthekredtredtjeenucfhrhhomhepofgrrhgvkhcu
    ofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinhhvih
    hsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepgedvfefh
    tdfgkeefveetkefhiedvuedvjeffuefggeefffdvueffvefgueelteehnecuffhomhgrih
    hnpehgihhthhhusgdrtghomhenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhep
    mhgrihhlfhhrohhmpehmrghrmhgrrhgvkhesihhnvhhishhisghlvghthhhinhhgshhlrg
    gsrdgtohhm
X-ME-Proxy: <xmx:5kYSYjoQloU_-2nKAY4zkNwVwTH0cnfqm9aPKAwL1aCC9pjApIe0Sg>
    <xmx:5kYSYgrJNDHfSBhfWrXbh6aXi_ynQA1dHd5K9tXEFd7SIoILG-VPjg>
    <xmx:5kYSYpQxN-LOWG68VKFpG8cBbHvCtcI2Y_kJqNdU2_BtkTjlS_xZ3A>
    <xmx:5kYSYscqhqYX42m4acL8gaVOPiOG9sWqWL9OVERVct4UnFI7b5HIcb_l0sI>
From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: linux-kernel@vger.kernel.org
Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>,
	stable@vger.kernel.org,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Antoine Tenart <atenart@kernel.org>,
	xen-devel@lists.xenproject.org (moderated list:XEN HYPERVISOR INTERFACE),
	netdev@vger.kernel.org (open list:NETWORKING DRIVERS)
Subject: [PATCH] xen/netfront: destroy queues before real_num_tx_queues is zeroed
Date: Sun, 20 Feb 2022 14:42:01 +0100
Message-Id: <20220220134202.2187485-1-marmarek@invisiblethingslab.com>
X-Mailer: git-send-email 2.31.1
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Organization: Invisible Things Lab
Content-Transfer-Encoding: 8bit

xennet_destroy_queues() relies on info->netdev->real_num_tx_queues to
delete queues. Since d7dac083414eb5bb99a6d2ed53dc2c1b405224e5
("net-sysfs: update the queue counts in the unregistration path"),
unregister_netdev() indirectly sets real_num_tx_queues to 0. Those two
facts together means, that xennet_destroy_queues() called from
xennet_remove() cannot do its job, because it's called after
unregister_netdev(). This results in kfree-ing queues that are still
linked in napi, which ultimately crashes:

    BUG: kernel NULL pointer dereference, address: 0000000000000000
    #PF: supervisor read access in kernel mode
    #PF: error_code(0x0000) - not-present page
    PGD 0 P4D 0
    Oops: 0000 [#1] PREEMPT SMP PTI
    CPU: 1 PID: 52 Comm: xenwatch Tainted: G        W         5.16.10-1.32.fc32.qubes.x86_64+ #226
    RIP: 0010:free_netdev+0xa3/0x1a0
    Code: ff 48 89 df e8 2e e9 00 00 48 8b 43 50 48 8b 08 48 8d b8 a0 fe ff ff 48 8d a9 a0 fe ff ff 49 39 c4 75 26 eb 47 e8 ed c1 66 ff <48> 8b 85 60 01 00 00 48 8d 95 60 01 00 00 48 89 ef 48 2d 60 01 00
    RSP: 0000:ffffc90000bcfd00 EFLAGS: 00010286
    RAX: 0000000000000000 RBX: ffff88800edad000 RCX: 0000000000000000
    RDX: 0000000000000001 RSI: ffffc90000bcfc30 RDI: 00000000ffffffff
    RBP: fffffffffffffea0 R08: 0000000000000000 R09: 0000000000000000
    R10: 0000000000000000 R11: 0000000000000001 R12: ffff88800edad050
    R13: ffff8880065f8f88 R14: 0000000000000000 R15: ffff8880066c6680
    FS:  0000000000000000(0000) GS:ffff8880f3300000(0000) knlGS:0000000000000000
    CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
    CR2: 0000000000000000 CR3: 00000000e998c006 CR4: 00000000003706e0
    Call Trace:
     <TASK>
     xennet_remove+0x13d/0x300 [xen_netfront]
     xenbus_dev_remove+0x6d/0xf0
     __device_release_driver+0x17a/0x240
     device_release_driver+0x24/0x30
     bus_remove_device+0xd8/0x140
     device_del+0x18b/0x410
     ? _raw_spin_unlock+0x16/0x30
     ? klist_iter_exit+0x14/0x20
     ? xenbus_dev_request_and_reply+0x80/0x80
     device_unregister+0x13/0x60
     xenbus_dev_changed+0x18e/0x1f0
     xenwatch_thread+0xc0/0x1a0
     ? do_wait_intr_irq+0xa0/0xa0
     kthread+0x16b/0x190
     ? set_kthread_struct+0x40/0x40
     ret_from_fork+0x22/0x30
     </TASK>

Fix this by calling xennet_destroy_queues() from xennet_close() too,
when real_num_tx_queues is still available. This ensures that queues are
destroyed when real_num_tx_queues is set to 0, regardless of how
unregister_netdev() was called.

Originally reported at
https://github.com/QubesOS/qubes-issues/issues/7257

Fixes: d7dac083414eb5bb9 ("net-sysfs: update the queue counts in the unregistration path")
Cc: stable@vger.kernel.org # 5.16+
Signed-off-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>

---
While this fixes the issue, I'm not sure if that is the correct thing
to do. xennet_remove() calls xennet_destroy_queues() under rtnl_lock,
which may be important here? Just moving xennet_destroy_queues() before
unregister_netdev() in xennet_remove() did not helped - it crashed in
another way (use-after-free in xennet_close()).

Signed-off-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
---
 drivers/net/xen-netfront.c | 33 +++++++++++++++++----------------
 1 file changed, 17 insertions(+), 16 deletions(-)

diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
index d514d96027a6..5b69a930581e 100644
--- a/drivers/net/xen-netfront.c
+++ b/drivers/net/xen-netfront.c
@@ -828,6 +828,22 @@ static netdev_tx_t xennet_start_xmit(struct sk_buff *skb, struct net_device *dev
 	return NETDEV_TX_OK;
 }
 
+static void xennet_destroy_queues(struct netfront_info *info)
+{
+	unsigned int i;
+
+	for (i = 0; i < info->netdev->real_num_tx_queues; i++) {
+		struct netfront_queue *queue = &info->queues[i];
+
+		if (netif_running(info->netdev))
+			napi_disable(&queue->napi);
+		netif_napi_del(&queue->napi);
+	}
+
+	kfree(info->queues);
+	info->queues = NULL;
+}
+
 static int xennet_close(struct net_device *dev)
 {
 	struct netfront_info *np = netdev_priv(dev);
@@ -839,6 +855,7 @@ static int xennet_close(struct net_device *dev)
 		queue = &np->queues[i];
 		napi_disable(&queue->napi);
 	}
+	xennet_destroy_queues(np);
 	return 0;
 }
 
@@ -2103,22 +2120,6 @@ static int write_queue_xenstore_keys(struct netfront_queue *queue,
 	return err;
 }
 
-static void xennet_destroy_queues(struct netfront_info *info)
-{
-	unsigned int i;
-
-	for (i = 0; i < info->netdev->real_num_tx_queues; i++) {
-		struct netfront_queue *queue = &info->queues[i];
-
-		if (netif_running(info->netdev))
-			napi_disable(&queue->napi);
-		netif_napi_del(&queue->napi);
-	}
-
-	kfree(info->queues);
-	info->queues = NULL;
-}
-
 
 
 static int xennet_create_page_pool(struct netfront_queue *queue)
-- 
2.31.1



From xen-devel-bounces@lists.xenproject.org Sun Feb 20 21:56:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 20 Feb 2022 21:56:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275862.471862 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nLuBH-000156-KI; Sun, 20 Feb 2022 21:55:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275862.471862; Sun, 20 Feb 2022 21:55:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nLuBH-00014z-Fz; Sun, 20 Feb 2022 21:55:47 +0000
Received: by outflank-mailman (input) for mailman id 275862;
 Sun, 20 Feb 2022 21:55:46 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nLuBG-00014p-FM; Sun, 20 Feb 2022 21:55:46 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nLuBG-00083J-Bc; Sun, 20 Feb 2022 21:55:46 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nLuBF-0005KR-TB; Sun, 20 Feb 2022 21:55:46 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nLuBF-00078o-Si; Sun, 20 Feb 2022 21:55:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ELoNYZu+oEj0pa5Xd7chPe/HnBZPs22CMVhpGgjZPGw=; b=YrgTdd6Y80hNX+ZCynCTdYYLC/
	7WAik4bKU2fG17YNR9EburReSkIbRqeAeI6IorVgl6O1dETGfrIIfuuxjHHom+Wp16jwApnbHE7Yb
	CYhQeHIcIRfrro3Oo5a01oKS8hj/4ciZGkDRkZADJA+Tie4695HqGb4L95ojYLPjpjAg=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168178-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 168178: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=242f2cae782d433d69d195e14564b6437ec9f7e6
X-Osstest-Versions-That:
    qemuu=439346ce8fa32095433a9abb2aa3564d11283372
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 20 Feb 2022 21:55:45 +0000

flight 168178 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168178/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168174
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168174
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168174
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168174
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168174
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168174
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168174
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168174
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                242f2cae782d433d69d195e14564b6437ec9f7e6
baseline version:
 qemuu                439346ce8fa32095433a9abb2aa3564d11283372

Last test of basis   168174  2022-02-19 15:39:39 Z    1 days
Testing same since   168178  2022-02-20 15:38:18 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Dr. David Alan Gilbert <dgilbert@redhat.com>
  Greg Kurz <groug@kaod.org>
  Peter Maydell <peter.maydell@linaro.org>
  Sebastian Hasler <sebastian.hasler@stuvus.uni-stuttgart.de>
  Vivek Goyal <vgoyal@redhat.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   439346ce8f..242f2cae78  242f2cae782d433d69d195e14564b6437ec9f7e6 -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Mon Feb 21 01:58:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 21 Feb 2022 01:58:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275874.471873 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nLxxi-0000bH-EV; Mon, 21 Feb 2022 01:58:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275874.471873; Mon, 21 Feb 2022 01:58:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nLxxi-0000b9-9M; Mon, 21 Feb 2022 01:58:02 +0000
Received: by outflank-mailman (input) for mailman id 275874;
 Mon, 21 Feb 2022 01:58:01 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nLxxh-0000az-Mx; Mon, 21 Feb 2022 01:58:01 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nLxxh-0006XN-E3; Mon, 21 Feb 2022 01:58:01 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nLxxg-00072y-Op; Mon, 21 Feb 2022 01:58:00 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nLxxg-0004vO-OA; Mon, 21 Feb 2022 01:58:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=vMnyRQP3YIESl8EBq3BhbpvSvIu47XvOIu2owPMn57A=; b=hZmfhLpd/cKllhDnIzFZbUFGl0
	egztuGFzUWtHUQ1r3SikV1NYkKv5phFpCUjzwa3dbvLHTNi9LHN2Md1Xb8vCXaGJqLJPMl1IDg/wQ
	sNmmrWJslN/OcaXJKtbut6oKRHIV06Ht7Ie6ZScMaAHela4z04+vuARxh0Ms01p1bpMU=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168179-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 168179: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-freebsd12-amd64:guest-start/freebsd.repeat:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=7f25f0412c9e2be6811e8aedbd10ef795fff85f2
X-Osstest-Versions-That:
    linux=4f12b742eb2b3a850ac8be7dc4ed52976fc6cb0b
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 21 Feb 2022 01:58:00 +0000

flight 168179 linux-linus real [real]
flight 168181 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/168179/
http://logs.test-lab.xenproject.org/osstest/logs/168181/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-freebsd12-amd64 21 guest-start/freebsd.repeat fail pass in 168181-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10       fail  like 168170
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168170
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168170
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168170
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168170
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168170
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168170
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168170
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168170
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                7f25f0412c9e2be6811e8aedbd10ef795fff85f2
baseline version:
 linux                4f12b742eb2b3a850ac8be7dc4ed52976fc6cb0b

Last test of basis   168170  2022-02-19 02:28:10 Z    1 days
Testing same since   168179  2022-02-20 19:11:13 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  "Eric W. Biederman" <ebiederm@xmission.com>
  Christian Brauner <brauner@kernel.org>
  Eric W. Biederman <ebiederm@xmission.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Waiman Long <longman@redhat.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             fail    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   4f12b742eb2b..7f25f0412c9e  7f25f0412c9e2be6811e8aedbd10ef795fff85f2 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Mon Feb 21 03:43:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 21 Feb 2022 03:43:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275889.471895 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nLzb9-0003aX-Ad; Mon, 21 Feb 2022 03:42:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275889.471895; Mon, 21 Feb 2022 03:42:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nLzb9-0003aQ-7V; Mon, 21 Feb 2022 03:42:51 +0000
Received: by outflank-mailman (input) for mailman id 275889;
 Mon, 21 Feb 2022 03:42:50 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Dco5=TE=invisiblethingslab.com=marmarek@srs-se1.protection.inumbo.net>)
 id 1nLzb7-0003Ks-SB
 for xen-devel@lists.xenproject.org; Mon, 21 Feb 2022 03:42:49 +0000
Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com
 [64.147.123.19]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 53057aed-92c8-11ec-8eb8-a37418f5ba1a;
 Mon, 21 Feb 2022 04:42:47 +0100 (CET)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.46])
 by mailout.west.internal (Postfix) with ESMTP id CAB523200258;
 Sun, 20 Feb 2022 22:42:40 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163])
 by compute2.internal (MEProxy); Sun, 20 Feb 2022 22:42:41 -0500
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun,
 20 Feb 2022 22:42:38 -0500 (EST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 53057aed-92c8-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-transfer-encoding
	:content-type:date:date:from:from:in-reply-to:message-id
	:mime-version:reply-to:sender:subject:subject:to:to:x-me-proxy
	:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=4Ftth8
	jIR9thK7FgELPaAjI8cJu47K8WHyuMsUo9B1g=; b=FdoiMWvU0BfcBuxRwZU+21
	YkXa3ru8QvLBJzmL/AR2f3zSpdyN/RArycC556yS3nEpHXST4J6m2eSpv6RsAfae
	HVDZ0tHyCtBHkF+ERY5MvQNm5iP2mhYt2LyddO0yYU4fvStJbC0IIM14aXMD33Fd
	gDIUNKDMi398RCkvE7HHV8/5mkBXoCY3qYqSkxKuCmIYRhjFNNNGujLo6iCqohEo
	jrcLXcM12/4ynXvJxVvUm8dAIn1OnnbIzU1WSBn6s6cGnMvOO95hNqMNJKpHSPZj
	kYpA/hauWPYnxQm0ebleiBxI0kcS2gkEmB3L2nA0ujfpiws/nhx5TNz9yHNa5flQ
	==
X-ME-Sender: <xms:LwoTYpCoP_vRoO-_W43C6K6fDJoUfDxtuNFYf33mJAATjxinZwOqbA>
    <xme:LwoTYnhBQrjcD6W4_JUHEJJ5xXbslYuqYGV2q7GbsGS7sM24JA9cfSloftU9n_920
    GovhIkTXs473g>
X-ME-Received: <xmr:LwoTYkkICF2S4BqHYuGwzspmSGfOM82iVlML-aoKIWsuRIHSpPpgyT8Ipq4Ty5RXgEx9qF_BHzRkiTO5CL53ix3RwgdmF7PdYuDnP39P6FH2XPWzMIA>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrkeehgdeitdcutefuodetggdotefrodftvf
    curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
    uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
    fjughrpefhvffufffkofggtghogfesthekredtredtjeenucfhrhhomhepofgrrhgvkhcu
    ofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinhhvih
    hsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhephefhfeet
    ueelvddvtedttdevieeluedtvedtfeejieelhedutdeuheduieejgfegnecuffhomhgrih
    hnpehkvghrnhgvlhdrohhrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhep
    mhgrihhlfhhrohhmpehmrghrmhgrrhgvkhesihhnvhhishhisghlvghthhhinhhgshhlrg
    gsrdgtohhm
X-ME-Proxy: <xmx:LwoTYjyJDArO5Qikpwxqss0lYz6rfAvZG-o-ZDWrYSHkps5AmaKhPQ>
    <xmx:LwoTYuQaNlIgZeG2_YCDGLJG9dPE5ErYpcWEQBbdDTU6BHUQWHvkLA>
    <xmx:LwoTYmbnSKBtsO3el5Uoa9Tu8brFC5fcwyiqug_rUxPPmUavF9DXMA>
    <xmx:MAoTYrQZH-q9MTuCmeVGtFapoCE7E5IoRirCF9BmYN3iEkXq9iMhtQ>
From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: linux-kernel@vger.kernel.org
Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>,
	stable@vger.kernel.org,
	Michael Brown <mcb30@ipxe.org>,
	Wei Liu <wei.liu@kernel.org>,
	Paul Durrant <paul@xen.org>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	xen-devel@lists.xenproject.org (moderated list:XEN NETWORK BACKEND DRIVER),
	netdev@vger.kernel.org (open list:XEN NETWORK BACKEND DRIVER)
Subject: [PATCH 1/2] Revert "xen-netback: remove 'hotplug-status' once it has served its purpose"
Date: Mon, 21 Feb 2022 04:42:12 +0100
Message-Id: <20220221034214.2237097-1-marmarek@invisiblethingslab.com>
X-Mailer: git-send-email 2.31.1
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Organization: Invisible Things Lab
Content-Transfer-Encoding: 8bit

This reverts commit 1f2565780e9b7218cf92c7630130e82dcc0fe9c2.

The 'hotplug-status' node should not be removed as long as the vif
device remains configured. Otherwise the xen-netback would wait for
re-running the network script even if it was already called (in case of
the frontent re-connecting). But also, it _should_ be removed when the
vif device is destroyed (for example when unbinding the driver) -
otherwise hotplug script would not configure the device whenever it
re-appear.

Moving removal of the 'hotplug-status' node was a workaround for nothing
calling network script after xen-netback module is reloaded. But when
vif interface is re-created (on xen-netback unbind/bind for example),
the script should be called, regardless of who does that - currently
this case is not handled by the toolstack, and requires manual
script call. Keeping hotplug-status=connected to skip the call is wrong
and leads to not configured interface.

More discussion at
https://lore.kernel.org/xen-devel/afedd7cb-a291-e773-8b0d-4db9b291fa98@ipxe.org/T/#u

Cc: stable@vger.kernel.org
Signed-off-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
---
Cc: Michael Brown <mcb30@ipxe.org>
---
 drivers/net/xen-netback/xenbus.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/xen-netback/xenbus.c b/drivers/net/xen-netback/xenbus.c
index d24b7a7993aa..ce0f3035bee8 100644
--- a/drivers/net/xen-netback/xenbus.c
+++ b/drivers/net/xen-netback/xenbus.c
@@ -256,6 +256,7 @@ static void backend_disconnect(struct backend_info *be)
 		unsigned int queue_index;
 
 		xen_unregister_watchers(vif);
+		xenbus_rm(XBT_NIL, dev->nodename, "hotplug-status");
 #ifdef CONFIG_DEBUG_FS
 		xenvif_debugfs_delif(vif);
 #endif /* CONFIG_DEBUG_FS */
@@ -675,7 +676,6 @@ static void hotplug_status_changed(struct xenbus_watch *watch,
 
 		/* Not interested in this watch anymore. */
 		unregister_hotplug_status_watch(be);
-		xenbus_rm(XBT_NIL, be->dev->nodename, "hotplug-status");
 	}
 	kfree(str);
 }
-- 
2.31.1



From xen-devel-bounces@lists.xenproject.org Mon Feb 21 03:43:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 21 Feb 2022 03:43:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275888.471884 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nLzb8-0003L4-3m; Mon, 21 Feb 2022 03:42:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275888.471884; Mon, 21 Feb 2022 03:42:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nLzb7-0003Kt-WF; Mon, 21 Feb 2022 03:42:50 +0000
Received: by outflank-mailman (input) for mailman id 275888;
 Mon, 21 Feb 2022 03:42:48 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Dco5=TE=invisiblethingslab.com=marmarek@srs-se1.protection.inumbo.net>)
 id 1nLzb6-0003Km-Ic
 for xen-devel@lists.xenproject.org; Mon, 21 Feb 2022 03:42:48 +0000
Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com
 [64.147.123.19]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 54bc1562-92c8-11ec-8723-dd0c611c5f35;
 Mon, 21 Feb 2022 04:42:46 +0100 (CET)
Received: from compute5.internal (compute5.nyi.internal [10.202.2.45])
 by mailout.west.internal (Postfix) with ESMTP id 412EC32001BB;
 Sun, 20 Feb 2022 22:42:44 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163])
 by compute5.internal (MEProxy); Sun, 20 Feb 2022 22:42:45 -0500
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun,
 20 Feb 2022 22:42:42 -0500 (EST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 54bc1562-92c8-11ec-8723-dd0c611c5f35
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-transfer-encoding
	:content-type:date:date:from:from:in-reply-to:in-reply-to
	:message-id:mime-version:references:reply-to:sender:subject
	:subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
	:x-sasl-enc; s=fm2; bh=kRJmWAWFjKOALsTRLgibyhb8NsyL7NusOB/YUc9eB
	kM=; b=hd0w/MJf6l//ha5NyaJHPHtK+xblj4CF7MnwjPQP918OiOgwP+vE+zlRl
	vkKsrgeohaO+ZE2PT3ab/v5Bc9Lk+yhUhBm09xahRA0oGJ3NTTz1cuqxoEotitz4
	mjy7FKfgTgsNNgnWzt5bk4ujJFPRPZVdhbEFkj4iCTwJqJ5gnUoKQYC8/t0eQ70k
	HC6j3ozXuG1GM2BG5LH52Y0kkfPIfAxBZPdE/BASgP0MnByqcAXv7wfm+lR+/awr
	aBxwKvbMEafVx1ppp2sukMezYqZmd5zK3LuF8M4os1aelsbNjxNcbeUiW+UdLHLJ
	RmtUwsrOae1YyHt21nbhMq9AKRyNw==
X-ME-Sender: <xms:MwoTYpJAi8YoCYmyuEqg-QdsIRKZ6L7-NhiHdG7SEG7lMyP8nALj6Q>
    <xme:MwoTYlLG2w-RlJ5DEbSD9gPWL9EnEJzkpLT7dJZ6AGwsLgQ0sg7HtN4MHdllqBix3
    ySyHXipQVRB4Q>
X-ME-Received: <xmr:MwoTYht1uRt60FM5guu_6RXFXGIRWdYP2MwQCY0yYop4o7IebxWgUEC7TaiXnHs1h61vX4BDQhy3TGtvonP0XMpRjAOi7nVnKdNSGiTYsaNMmLbA6To>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrkeehgdeitdcutefuodetggdotefrodftvf
    curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
    uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
    fjughrpefhvffufffkofgjfhggtghogfesthekredtredtjeenucfhrhhomhepofgrrhgv
    khcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinh
    hvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepffdt
    uefffeduhfelueegvdetheejvdehteelfeetfeekgfekkefggedtgefhieejnecuffhomh
    grihhnpehkvghrnhgvlhdrohhrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgr
    mhepmhgrihhlfhhrohhmpehmrghrmhgrrhgvkhesihhnvhhishhisghlvghthhhinhhgsh
    hlrggsrdgtohhm
X-ME-Proxy: <xmx:MwoTYqaK9BAcguBxDC2Hd73fGSTVhtfhY7s3hgvK24QFn6aHVI5R-g>
    <xmx:MwoTYgbx--0TdhDf36bHLrCDs32_iWQH7Li3s42yimtcuB6CDw25BA>
    <xmx:MwoTYuCfP5VPhCYLo4ZQbRtRTBc2Eeii-zqjX9Ujjz-bYtDLiypS7g>
    <xmx:MwoTYg6J601ARQwvABPkeNeeDB-PEJwSE5WkMjMDK-spsG7obGyI-g>
From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: linux-kernel@vger.kernel.org
Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>,
	stable@vger.kernel.org,
	Michael Brown <mcb30@ipxe.org>,
	Wei Liu <wei.liu@kernel.org>,
	Paul Durrant <paul@xen.org>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	xen-devel@lists.xenproject.org (moderated list:XEN NETWORK BACKEND DRIVER),
	netdev@vger.kernel.org (open list:XEN NETWORK BACKEND DRIVER)
Subject: [PATCH 2/2] Revert "xen-netback: Check for hotplug-status existence before watching"
Date: Mon, 21 Feb 2022 04:42:13 +0100
Message-Id: <20220221034214.2237097-2-marmarek@invisiblethingslab.com>
X-Mailer: git-send-email 2.31.1
In-Reply-To: <20220221034214.2237097-1-marmarek@invisiblethingslab.com>
References: <20220221034214.2237097-1-marmarek@invisiblethingslab.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Organization: Invisible Things Lab
Content-Transfer-Encoding: 8bit

This reverts commit 2afeec08ab5c86ae21952151f726bfe184f6b23d.

The reasoning in the commit was wrong - the code expected to setup the
watch even if 'hotplug-status' didn't exist. In fact, it relied on the
watch being fired the first time - to check if maybe 'hotplug-status' is
already set to 'connected'. Not registering a watch for non-existing
path (which is the case if hotplug script hasn't been executed yet),
made the backend not waiting for the hotplug script to execute. This in
turns, made the netfront think the interface is fully operational, while
in fact it was not (the vif interface on xen-netback side might not be
configured yet).

This was a workaround for 'hotplug-status' erroneously being removed.
But since that is reverted now, the workaround is not necessary either.

More discussion at
https://lore.kernel.org/xen-devel/afedd7cb-a291-e773-8b0d-4db9b291fa98@ipxe.org/T/#u

Cc: stable@vger.kernel.org
Signed-off-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
---
I believe this is the same issue as discussed at
https://lore.kernel.org/xen-devel/20220113111946.GA4133739@dingwall.me.uk/
Cc: James Dingwall <james-xen@dingwall.me.uk
Cc: Michael Brown <mcb30@ipxe.org>
---
 drivers/net/xen-netback/xenbus.c | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/drivers/net/xen-netback/xenbus.c b/drivers/net/xen-netback/xenbus.c
index ce0f3035bee8..9d7a3a92959f 100644
--- a/drivers/net/xen-netback/xenbus.c
+++ b/drivers/net/xen-netback/xenbus.c
@@ -824,15 +824,11 @@ static void connect(struct backend_info *be)
 	xenvif_carrier_on(be->vif);
 
 	unregister_hotplug_status_watch(be);
-	if (xenbus_exists(XBT_NIL, dev->nodename, "hotplug-status")) {
-		err = xenbus_watch_pathfmt(dev, &be->hotplug_status_watch,
-					   NULL, hotplug_status_changed,
-					   "%s/%s", dev->nodename,
-					   "hotplug-status");
-		if (err)
-			goto err;
+	err = xenbus_watch_pathfmt(dev, &be->hotplug_status_watch, NULL,
+				   hotplug_status_changed,
+				   "%s/%s", dev->nodename, "hotplug-status");
+	if (!err)
 		be->have_hotplug_status_watch = 1;
-	}
 
 	netif_tx_wake_all_queues(be->vif->dev);
 
-- 
2.31.1



From xen-devel-bounces@lists.xenproject.org Mon Feb 21 05:55:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 21 Feb 2022 05:55:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275902.471906 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM1fU-0008Ep-TJ; Mon, 21 Feb 2022 05:55:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275902.471906; Mon, 21 Feb 2022 05:55:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM1fU-0008Ei-Pb; Mon, 21 Feb 2022 05:55:28 +0000
Received: by outflank-mailman (input) for mailman id 275902;
 Mon, 21 Feb 2022 05:55:26 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nM1fS-0008EY-P8; Mon, 21 Feb 2022 05:55:26 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nM1fS-0004Cf-Mf; Mon, 21 Feb 2022 05:55:26 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nM1fS-0002TC-2t; Mon, 21 Feb 2022 05:55:26 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nM1fS-0000w6-1i; Mon, 21 Feb 2022 05:55:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=CwqkOG9NNaDyckMjk8DhFiYvIt+EHfxiphs1PaKJKL4=; b=F7wwawr9OdHMDF9vi86VprADgb
	WfW2utnY83nSH5OV+t9IcIhn0JzoD7SAbvU4ifPR+lfXn0GbpEkDKPHqDZueNoo4vBNPCXDIo8Vyu
	Q2iJud0Krc9dzl6eetRc8eF7JrcLYKzlSUCPRpJtkbcnKBwfPFKZwBJ7ackY2DSdRUt4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168180-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 168180: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=e670f6d825d4dee248b311197fd4048469d6772b
X-Osstest-Versions-That:
    qemuu=242f2cae782d433d69d195e14564b6437ec9f7e6
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 21 Feb 2022 05:55:26 +0000

flight 168180 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168180/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168178
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168178
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168178
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168178
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168178
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168178
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168178
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168178
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                e670f6d825d4dee248b311197fd4048469d6772b
baseline version:
 qemuu                242f2cae782d433d69d195e14564b6437ec9f7e6

Last test of basis   168178  2022-02-20 15:38:18 Z    0 days
Testing same since   168180  2022-02-20 22:09:39 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Cédric Le Goater <clg@kaod.org>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Fabiano Rosas <farosas@linux.ibm.com>
  Nicholas Piggin <npiggin@gmail.com>
  Peter Maydell <peter.maydell@linaro.org>
  Shivaprasad G Bhat <sbhat@linux.ibm.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   242f2cae78..e670f6d825  e670f6d825d4dee248b311197fd4048469d6772b -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Mon Feb 21 06:27:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 21 Feb 2022 06:27:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275916.471916 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM2Aa-0003GK-IT; Mon, 21 Feb 2022 06:27:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275916.471916; Mon, 21 Feb 2022 06:27:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM2Aa-0003GD-FQ; Mon, 21 Feb 2022 06:27:36 +0000
Received: by outflank-mailman (input) for mailman id 275916;
 Mon, 21 Feb 2022 06:27:35 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=tDfV=TE=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nM2AZ-0003G7-Ic
 for xen-devel@lists.xenproject.org; Mon, 21 Feb 2022 06:27:35 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5a72141e-92df-11ec-8eb8-a37418f5ba1a;
 Mon, 21 Feb 2022 07:27:33 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 294BF1F382;
 Mon, 21 Feb 2022 06:27:33 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B803C12FC5;
 Mon, 21 Feb 2022 06:27:32 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id zxmAKtQwE2LdOQAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 21 Feb 2022 06:27:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5a72141e-92df-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1645424853; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=UY4426qAxxmQ2a9UManO4VFLDik/euHBVCCtWIwUXac=;
	b=IzZDdC5lACReo2lR2HlJ/oKJvtQ+HAWBTb3rEPytQ8H9NA7H/os76KaXlUcC4M3vZh/DcQ
	IH1CBkiZKO7mdedHnfhtmxGypUxnpPoXn0SiZrwH7h3G2hq6pLHzaOxZlceFKLbnl0qzC/
	EF8WyDVAdGnzPwUETAoAUB0n17+SueA=
Message-ID: <3786b4ef-68e7-5735-0841-fcbae07f7e54@suse.com>
Date: Mon, 21 Feb 2022 07:27:32 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Content-Language: en-US
To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>, linux-kernel@vger.kernel.org
Cc: stable@vger.kernel.org, Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 "David S. Miller" <davem@davemloft.net>, Jakub Kicinski <kuba@kernel.org>,
 Antoine Tenart <atenart@kernel.org>,
 "moderated list:XEN HYPERVISOR INTERFACE" <xen-devel@lists.xenproject.org>,
 "open list:NETWORKING DRIVERS" <netdev@vger.kernel.org>
References: <20220220134202.2187485-1-marmarek@invisiblethingslab.com>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH] xen/netfront: destroy queues before real_num_tx_queues is
 zeroed
In-Reply-To: <20220220134202.2187485-1-marmarek@invisiblethingslab.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------NbSvRM0BXdfOCmjjjQR4XP0G"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------NbSvRM0BXdfOCmjjjQR4XP0G
Content-Type: multipart/mixed; boundary="------------BcFvWjNSSH2gGq1foKq12Wbr";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>, linux-kernel@vger.kernel.org
Cc: stable@vger.kernel.org, Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 "David S. Miller" <davem@davemloft.net>, Jakub Kicinski <kuba@kernel.org>,
 Antoine Tenart <atenart@kernel.org>,
 "moderated list:XEN HYPERVISOR INTERFACE" <xen-devel@lists.xenproject.org>,
 "open list:NETWORKING DRIVERS" <netdev@vger.kernel.org>
Message-ID: <3786b4ef-68e7-5735-0841-fcbae07f7e54@suse.com>
Subject: Re: [PATCH] xen/netfront: destroy queues before real_num_tx_queues is
 zeroed
References: <20220220134202.2187485-1-marmarek@invisiblethingslab.com>
In-Reply-To: <20220220134202.2187485-1-marmarek@invisiblethingslab.com>

--------------BcFvWjNSSH2gGq1foKq12Wbr
Content-Type: multipart/mixed; boundary="------------rVg6F7eL5G4iBBp0YLU80g2c"

--------------rVg6F7eL5G4iBBp0YLU80g2c
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMjAuMDIuMjIgMTQ6NDIsIE1hcmVrIE1hcmN6eWtvd3NraS1Hw7NyZWNraSB3cm90ZToN
Cj4geGVubmV0X2Rlc3Ryb3lfcXVldWVzKCkgcmVsaWVzIG9uIGluZm8tPm5ldGRldi0+cmVh
bF9udW1fdHhfcXVldWVzIHRvDQo+IGRlbGV0ZSBxdWV1ZXMuIFNpbmNlIGQ3ZGFjMDgzNDE0
ZWI1YmI5OWE2ZDJlZDUzZGMyYzFiNDA1MjI0ZTUNCj4gKCJuZXQtc3lzZnM6IHVwZGF0ZSB0
aGUgcXVldWUgY291bnRzIGluIHRoZSB1bnJlZ2lzdHJhdGlvbiBwYXRoIiksDQo+IHVucmVn
aXN0ZXJfbmV0ZGV2KCkgaW5kaXJlY3RseSBzZXRzIHJlYWxfbnVtX3R4X3F1ZXVlcyB0byAw
LiBUaG9zZSB0d28NCj4gZmFjdHMgdG9nZXRoZXIgbWVhbnMsIHRoYXQgeGVubmV0X2Rlc3Ry
b3lfcXVldWVzKCkgY2FsbGVkIGZyb20NCj4geGVubmV0X3JlbW92ZSgpIGNhbm5vdCBkbyBp
dHMgam9iLCBiZWNhdXNlIGl0J3MgY2FsbGVkIGFmdGVyDQo+IHVucmVnaXN0ZXJfbmV0ZGV2
KCkuIFRoaXMgcmVzdWx0cyBpbiBrZnJlZS1pbmcgcXVldWVzIHRoYXQgYXJlIHN0aWxsDQo+
IGxpbmtlZCBpbiBuYXBpLCB3aGljaCB1bHRpbWF0ZWx5IGNyYXNoZXM6DQo+IA0KPiAgICAg
IEJVRzoga2VybmVsIE5VTEwgcG9pbnRlciBkZXJlZmVyZW5jZSwgYWRkcmVzczogMDAwMDAw
MDAwMDAwMDAwMA0KPiAgICAgICNQRjogc3VwZXJ2aXNvciByZWFkIGFjY2VzcyBpbiBrZXJu
ZWwgbW9kZQ0KPiAgICAgICNQRjogZXJyb3JfY29kZSgweDAwMDApIC0gbm90LXByZXNlbnQg
cGFnZQ0KPiAgICAgIFBHRCAwIFA0RCAwDQo+ICAgICAgT29wczogMDAwMCBbIzFdIFBSRUVN
UFQgU01QIFBUSQ0KPiAgICAgIENQVTogMSBQSUQ6IDUyIENvbW06IHhlbndhdGNoIFRhaW50
ZWQ6IEcgICAgICAgIFcgICAgICAgICA1LjE2LjEwLTEuMzIuZmMzMi5xdWJlcy54ODZfNjQr
ICMyMjYNCj4gICAgICBSSVA6IDAwMTA6ZnJlZV9uZXRkZXYrMHhhMy8weDFhMA0KPiAgICAg
IENvZGU6IGZmIDQ4IDg5IGRmIGU4IDJlIGU5IDAwIDAwIDQ4IDhiIDQzIDUwIDQ4IDhiIDA4
IDQ4IDhkIGI4IGEwIGZlIGZmIGZmIDQ4IDhkIGE5IGEwIGZlIGZmIGZmIDQ5IDM5IGM0IDc1
IDI2IGViIDQ3IGU4IGVkIGMxIDY2IGZmIDw0OD4gOGIgODUgNjAgMDEgMDAgMDAgNDggOGQg
OTUgNjAgMDEgMDAgMDAgNDggODkgZWYgNDggMmQgNjAgMDEgMDANCj4gICAgICBSU1A6IDAw
MDA6ZmZmZmM5MDAwMGJjZmQwMCBFRkxBR1M6IDAwMDEwMjg2DQo+ICAgICAgUkFYOiAwMDAw
MDAwMDAwMDAwMDAwIFJCWDogZmZmZjg4ODAwZWRhZDAwMCBSQ1g6IDAwMDAwMDAwMDAwMDAw
MDANCj4gICAgICBSRFg6IDAwMDAwMDAwMDAwMDAwMDEgUlNJOiBmZmZmYzkwMDAwYmNmYzMw
IFJESTogMDAwMDAwMDBmZmZmZmZmZg0KPiAgICAgIFJCUDogZmZmZmZmZmZmZmZmZmVhMCBS
MDg6IDAwMDAwMDAwMDAwMDAwMDAgUjA5OiAwMDAwMDAwMDAwMDAwMDAwDQo+ICAgICAgUjEw
OiAwMDAwMDAwMDAwMDAwMDAwIFIxMTogMDAwMDAwMDAwMDAwMDAwMSBSMTI6IGZmZmY4ODgw
MGVkYWQwNTANCj4gICAgICBSMTM6IGZmZmY4ODgwMDY1ZjhmODggUjE0OiAwMDAwMDAwMDAw
MDAwMDAwIFIxNTogZmZmZjg4ODAwNjZjNjY4MA0KPiAgICAgIEZTOiAgMDAwMDAwMDAwMDAw
MDAwMCgwMDAwKSBHUzpmZmZmODg4MGYzMzAwMDAwKDAwMDApIGtubEdTOjAwMDAwMDAwMDAw
MDAwMDANCj4gICAgICBDUzogIDAwMTAgRFM6IDAwMDAgRVM6IDAwMDAgQ1IwOiAwMDAwMDAw
MDgwMDUwMDMzDQo+ICAgICAgQ1IyOiAwMDAwMDAwMDAwMDAwMDAwIENSMzogMDAwMDAwMDBl
OTk4YzAwNiBDUjQ6IDAwMDAwMDAwMDAzNzA2ZTANCj4gICAgICBDYWxsIFRyYWNlOg0KPiAg
ICAgICA8VEFTSz4NCj4gICAgICAgeGVubmV0X3JlbW92ZSsweDEzZC8weDMwMCBbeGVuX25l
dGZyb250XQ0KPiAgICAgICB4ZW5idXNfZGV2X3JlbW92ZSsweDZkLzB4ZjANCj4gICAgICAg
X19kZXZpY2VfcmVsZWFzZV9kcml2ZXIrMHgxN2EvMHgyNDANCj4gICAgICAgZGV2aWNlX3Jl
bGVhc2VfZHJpdmVyKzB4MjQvMHgzMA0KPiAgICAgICBidXNfcmVtb3ZlX2RldmljZSsweGQ4
LzB4MTQwDQo+ICAgICAgIGRldmljZV9kZWwrMHgxOGIvMHg0MTANCj4gICAgICAgPyBfcmF3
X3NwaW5fdW5sb2NrKzB4MTYvMHgzMA0KPiAgICAgICA/IGtsaXN0X2l0ZXJfZXhpdCsweDE0
LzB4MjANCj4gICAgICAgPyB4ZW5idXNfZGV2X3JlcXVlc3RfYW5kX3JlcGx5KzB4ODAvMHg4
MA0KPiAgICAgICBkZXZpY2VfdW5yZWdpc3RlcisweDEzLzB4NjANCj4gICAgICAgeGVuYnVz
X2Rldl9jaGFuZ2VkKzB4MThlLzB4MWYwDQo+ICAgICAgIHhlbndhdGNoX3RocmVhZCsweGMw
LzB4MWEwDQo+ICAgICAgID8gZG9fd2FpdF9pbnRyX2lycSsweGEwLzB4YTANCj4gICAgICAg
a3RocmVhZCsweDE2Yi8weDE5MA0KPiAgICAgICA/IHNldF9rdGhyZWFkX3N0cnVjdCsweDQw
LzB4NDANCj4gICAgICAgcmV0X2Zyb21fZm9yaysweDIyLzB4MzANCj4gICAgICAgPC9UQVNL
Pg0KPiANCj4gRml4IHRoaXMgYnkgY2FsbGluZyB4ZW5uZXRfZGVzdHJveV9xdWV1ZXMoKSBm
cm9tIHhlbm5ldF9jbG9zZSgpIHRvbywNCj4gd2hlbiByZWFsX251bV90eF9xdWV1ZXMgaXMg
c3RpbGwgYXZhaWxhYmxlLiBUaGlzIGVuc3VyZXMgdGhhdCBxdWV1ZXMgYXJlDQo+IGRlc3Ry
b3llZCB3aGVuIHJlYWxfbnVtX3R4X3F1ZXVlcyBpcyBzZXQgdG8gMCwgcmVnYXJkbGVzcyBv
ZiBob3cNCj4gdW5yZWdpc3Rlcl9uZXRkZXYoKSB3YXMgY2FsbGVkLg0KPiANCj4gT3JpZ2lu
YWxseSByZXBvcnRlZCBhdA0KPiBodHRwczovL2dpdGh1Yi5jb20vUXViZXNPUy9xdWJlcy1p
c3N1ZXMvaXNzdWVzLzcyNTcNCj4gDQo+IEZpeGVzOiBkN2RhYzA4MzQxNGViNWJiOSAoIm5l
dC1zeXNmczogdXBkYXRlIHRoZSBxdWV1ZSBjb3VudHMgaW4gdGhlIHVucmVnaXN0cmF0aW9u
IHBhdGgiKQ0KPiBDYzogc3RhYmxlQHZnZXIua2VybmVsLm9yZyAjIDUuMTYrDQo+IFNpZ25l
ZC1vZmYtYnk6IE1hcmVrIE1hcmN6eWtvd3NraS1Hw7NyZWNraSA8bWFybWFyZWtAaW52aXNp
YmxldGhpbmdzbGFiLmNvbT4NCj4gDQo+IC0tLQ0KPiBXaGlsZSB0aGlzIGZpeGVzIHRoZSBp
c3N1ZSwgSSdtIG5vdCBzdXJlIGlmIHRoYXQgaXMgdGhlIGNvcnJlY3QgdGhpbmcNCj4gdG8g
ZG8uIHhlbm5ldF9yZW1vdmUoKSBjYWxscyB4ZW5uZXRfZGVzdHJveV9xdWV1ZXMoKSB1bmRl
ciBydG5sX2xvY2ssDQo+IHdoaWNoIG1heSBiZSBpbXBvcnRhbnQgaGVyZT8gSnVzdCBtb3Zp
bmcgeGVubmV0X2Rlc3Ryb3lfcXVldWVzKCkgYmVmb3JlDQoNCkkgY2hlY2tlZCBzb21lIG9m
IHRoZSBjYWxsIHBhdGhzIGxlYWRpbmcgdG8geGVubmV0X2Nsb3NlKCksIGFuZCBhbGwgb2YN
CnRob3NlIGNvbnRhaW5lZCBhbiBBU1NFUlRfUlROTCgpLCBzbyBpdCBzZWVtcyB0aGUgcnRu
bF9sb2NrIGlzIGFscmVhZHkNCnRha2VuIGhlcmUuIENvdWxkIHlvdSB0ZXN0IHdpdGggYWRk
aW5nIGFuIEFTU0VSVF9SVE5MKCkgaW4NCnhlbm5ldF9kZXN0cm95X3F1ZXVlcygpPw0KDQo+
IHVucmVnaXN0ZXJfbmV0ZGV2KCkgaW4geGVubmV0X3JlbW92ZSgpIGRpZCBub3QgaGVscGVk
IC0gaXQgY3Jhc2hlZCBpbg0KPiBhbm90aGVyIHdheSAodXNlLWFmdGVyLWZyZWUgaW4geGVu
bmV0X2Nsb3NlKCkpLg0KDQpZZXMsIHRoaXMgd291bGQgbmVlZCB0byBiYXNpY2FsbHkgZG8g
dGhlIHhlbm5ldF9jbG9zZSgpIGhhbmRsaW5nIGluDQp4ZW5uZXRfZGVzdHJveSgpIGluc3Rl
YWQsIHdoaWNoIEkgYmVsaWV2ZSBpcyBub3QgcmVhbGx5IGFuIG9wdGlvbi4NCg0KSW4gY2Fz
ZSB5b3VyIHRlc3Qgd2l0aCB0aGUgYWRkZWQgQVNTRVJUX1JUTkwoKSBkb2Vzbid0IHNob3cg
YW55DQpwcm9ibGVtIHlvdSBjYW4gYWRkIG15Og0KDQpSZXZpZXdlZC1ieTogSnVlcmdlbiBH
cm9zcyA8amdyb3NzQHN1c2UuY29tPg0KDQoNCkp1ZXJnZW4NCg==
--------------rVg6F7eL5G4iBBp0YLU80g2c
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------rVg6F7eL5G4iBBp0YLU80g2c--

--------------BcFvWjNSSH2gGq1foKq12Wbr--

--------------NbSvRM0BXdfOCmjjjQR4XP0G
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmITMNQFAwAAAAAACgkQsN6d1ii/Ey94
WQgAgLn2BBds2BiphVyS8FqnqKLE5lHc6MD7cY6TTpM8+8juiDbtnWdN20ZDydlUC9JTKCBOgVUo
cFllyzPJKX3be+9EPxgTMMlvOdAA+y8rc5QYUzCpCiR9sgwRbv6fhOAo4GGvpHVPIQr2vDLAGT6O
HSWpeED8PVk5T0f4wi72EfqhWyagBHYQK5vgsIN4AQupV9tebpi7Y0WOCUPD83RcPIjARUQQj3vz
RMbUaLQ3QZbHPj/d0sUqsQt0Q0JmVQP8RLTbCL1GySGUcE8bwU2uTWpnzUATB1dHm7kDUvJuC77+
tzv8dsEH7k63ZgmmabY9wM/DzhclOdp/Mf4gpmTNhg==
=iNZp
-----END PGP SIGNATURE-----

--------------NbSvRM0BXdfOCmjjjQR4XP0G--


From xen-devel-bounces@lists.xenproject.org Mon Feb 21 09:36:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 21 Feb 2022 09:36:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275941.471932 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM57V-0004g0-6G; Mon, 21 Feb 2022 09:36:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275941.471932; Mon, 21 Feb 2022 09:36:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM57V-0004ft-2t; Mon, 21 Feb 2022 09:36:37 +0000
Received: by outflank-mailman (input) for mailman id 275941;
 Mon, 21 Feb 2022 09:36:36 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=vyL6=TE=citrix.com=prvs=04447c275=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nM57U-0004fn-70
 for xen-devel@lists.xenproject.org; Mon, 21 Feb 2022 09:36:36 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c1799a26-92f9-11ec-8eb8-a37418f5ba1a;
 Mon, 21 Feb 2022 10:36:34 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c1799a26-92f9-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645436194;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=5jNIvNO4GZxND01VagRoUBd/GzqCBijSlE2w4EcIQbw=;
  b=etNeaEuMfYSYjZQWBE1pcV0sguqpTjkKZDQUZeQ5Ezteb2cBC0GwFQMa
   mo6NerQ4tRjvXlfEyBA2xU1OPnyji0I3yiL6D4jN51WUyOJjYuUkiDUQv
   yq6MD8BdPXiw0/Va5Odqz3GJmdua0GHceoBPmLelds2FVLRXpEgwK5DSo
   0=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 64635024
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Xs/FXqjWwMN0hAPYp63HO1ffX161fhAKZh0ujC45NGQN5FlHY01je
 htvCGyBbP6LZ2v9Ldwgbd/i/UIPvceAzIUySgI/+3sxHi8b9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0Iz8wIFqtQw24LhWVnU4
 YqaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV
 efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9
 TlDiXC/YQsTH4TDs9kSaSFZDgVbGrx9yJ+EG3fq5KR/z2WeG5ft6/BnDUVwNowE4OdnR2pJ8
 JT0KhhUMErF3bjvhuvmFK883azPL+GyVG8bkmtnwjzDS+4vXLjIQrnQ5M8e1zA17ixLNaiCO
 ZFEMWAzBPjGSz9jHVYTLp81peO5p3v2SzwftQ7Lu6VitgA/yyQuieOwYbI5YOeiWsF9jkue4
 GXc8AzREhwccdCS1zeB2natnfPU2zP2XpoIE7+1/eIsh0ecrkQfFxgJD3O6p/ejg0KzUt4ZL
 FYbkgIsp6Uv8E2gTvHmQga15nWDu3Yht8F4SrNgrlvXk+yNvljfVjNsoiN9hMIOuPUXbDMB6
 1Czp9L0IRlIoYalaTGn+eLBxd+tAhQ9IWgHbC4CaAIK5dj/vY0+5i7yosZf/L2d1YOsR2ypq
 9yehG1n3uhI05ZXv0mu1Q2f21qRSo71ohnZD+k9dkas9UtHaYGsfOREAnCLvK8bfO51orRs1
 UXoevRyDshTV/lhdwTXGY3h+Y1FAN7fbVXhbaZHRcVJythU0yfLkXpsyD9/Plx1Fc0PZCXkZ
 kTe0SsIusMOZyv2PPImPtjgYyjP8UQHPY64Ps04k/IUOsQhHON51HoGibGsM5DFzxF3zPBX1
 WazesewF3cKYZmLPxLtL9rxJYQDn3hkrUuKHMiT503+jdK2OS7EIZ9YYQDmRr1os8u5TPD9r
 o832z2ikE4EDoUTo0D/rOYuELz9BSJlXcuv85QPLIZu4GNOQQkcNhMY+pt4E6RNlKVJjObYu
 Ha7X05T0l3kgnPbbw6NbxhehHnHBP6TcVpT0fQQAGuV
IronPort-HdrOrdr: A9a23:3AeVEqNJAgytx8BcTy/155DYdb4zR+YMi2TDiHoedfUFSKOlfp
 6V8MjztSWVtN4QMEtQ/+xoHJPwPE80lKQFm7X5WI3CYOCIghrMEGgP1/qH/9SkIVyDygc/79
 YQT0EdMqyJMbESt6+Ti2PUYrVQouVvsprY/ts2p00dMz2CAJsQljuRZDzrdXGfE2J9dOUE/d
 enl4J6jgvlXU5SQtWwB3EDUeSGj9rXlKj+aRpDIxI88gGBgR6h9ba/SnGjr10jegIK5Y1n3X
 nOkgT/6Knmm/anyiXE32uWy5hNgtPuxvZKGcTJoMkILTfHjBquee1aKva/lQFwhNvqxEchkd
 HKrRtlF8Nv60nJdmXwmhfp0xmI6kdY11bSjXujxVfzq83wQzw3T+Bbg5hCTxff4008+Plhza
 NixQuixtVqJCKFuB64y8nDVhlsmEbxi2Eli/Qvg3tWVpZbQKNNrLYY4FheHP47bW7HAbgcYa
 hT5fznlbZrmQvwVQGbgoAv+q3gYp0LJGbJfqBY0fblkQS/nxhCvj8lLYIk7zI9HakGOup5Dt
 T/Q9RVfY51P70rhIJGdZE8qJiMeyXwqSylChPmHb2gLtBCB07w
X-IronPort-AV: E=Sophos;i="5.88,385,1635220800"; 
   d="scan'208";a="64635024"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=JKRQkXa0qz916XEI1yVmlO92mRKpQsbspRn2b21xU/5aLWXm+3CErMvjtgzaP0RImre1mvRK8J2GlFn+o8VdjEL49qB4z3KK0nDuQYhgJhK2/mL/nGamAD7QMVMihcQWbghN/trn/biWT8v8o+s3+9yGO+bQVloo22xcckjuFHVcrI7LtxFTXwB4DB/fA7OKaTKVDxpRcBkX9xxTgcBng5USlxp6/xDGkVIAI8AH5brLi0Kua9agFYWQS0WTq/Xv3z61yANPq2u84P4c05pn2wiunvze/SAhJbVV80X7SIptfg/+iSC5oVUto1obsCA0tHvCjEX+ERaweDKplgFHgw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=JybfmasKiAgFTnXItVYG5ibtIRfT/x+K2IvtkLPKnkw=;
 b=NXXYeAqk167ugERo9/YfhRolc3p+MzreMdQ4DNeQoZhC6dC5p9lLi/LWRnX2QNEZzA/qHiSIJQG057R9kdD7Pz4Q2mVR1BOdGf4KvlvfCr6zt3jdMEewUFsb0GJr+zEg1Rlv4XWWO6WOBeeQJ8ovSBUL+r8+D4Q7Eot2EGEeILGdNDCtuIEXOsxBmDQVQ+ojg9njxOLIk70yIzrDjmnebM4pSZaeDVqn9ailULxeHA20wZ0K0Qu7gLSO43S3EzkLsHwyhFZea6laFXEJUNsTfKSPMrJGgC83h6Q9WyTa3M+Z0CslCRHS8HwSjlDYZI1JpVsrpitWH5WCzlHSYUGcOA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=JybfmasKiAgFTnXItVYG5ibtIRfT/x+K2IvtkLPKnkw=;
 b=Gf0fZmpXZ0v+OnTeLk24nKqxEI4vy/9BYc3S7W42BN4q73wIicdfLVTPOrScbiv9hptnP8NIoo9vWkNA+tRW65wu+cKE6SF8vj17zOtZHdeZ6o2urQHEvwmtpdSyM5f8gBumAlarHFLbnMcFJT0+nFFPpCPopWik1oA+vna+HMU=
Date: Mon, 21 Feb 2022 10:36:10 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: David Woodhouse <dwmw2@infradead.org>
CC: Jan Beulich <jbeulich@suse.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2 1/5] x86/cpuid: add CPUID flag for Extended
 Destination ID support
Message-ID: <YhNdCnxjmUW9/Ui2@Air-de-Roger>
References: <20220216103026.11533-1-roger.pau@citrix.com>
 <20220216103026.11533-2-roger.pau@citrix.com>
 <979fbc26-925c-f58f-9c1a-9ccd72275c9b@suse.com>
 <fd22f7e19590b0e8679e5a3a15992bd1f8a92126.camel@infradead.org>
 <9b5a8474-0be2-b4e6-8919-7e22dde1570a@suse.com>
 <Yg4UPzFk15tJGo0B@Air-de-Roger>
 <4d89ffe13d2579096c955edf800b5c86.squirrel@twosheds.infradead.org>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <4d89ffe13d2579096c955edf800b5c86.squirrel@twosheds.infradead.org>
X-ClientProxiedBy: LO2P265CA0065.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:60::29) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9496f261-cbd6-4914-699c-08d9f51d9b09
X-MS-TrafficTypeDiagnostic: MWHPR03MB2464:EE_
X-Microsoft-Antispam-PRVS: <MWHPR03MB2464C8D6226558BE6CAD83758F3A9@MWHPR03MB2464.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: mWHks6dVksDS4WXpwwo/k28CKVJqvgSyjO7+2M/fQH+pmLpkrUKvJrn9YuxZU7LnIrNFk6uO6d8K8rZNXt9O/AMoA4WMoS+VZzwMsEnkq0A50SUqMyxpbYFugAE6d/9rtt7o9YwQZP+g1PQJqivjD35PBa1Fa91mcEETEq4OSR5SLE/65WTJl+w4ffxz+l93dvoBuPUXqTUanj4mX/nHfU7MItZJjvtbSJlchl9ndiGJauInboaRCpa4CqXTrdZCnFQtU+IivxEoDqQN91WNaJ/7h8ruE4U5GfzgcccYoTOQ1vpesFpjiEj4ZgUtDPs9/tskmDfChqWXQRWEAv9BFoby2wvyd5bBBtVgj+6pZ5BxcHrvrCHirexb7a/NkerqbEqupICO1UC+GKu/X63vtqTqemfH6h/1KxgU/0cjHaP3+RGl62z/FEwEu/TZLyFAx5YTdAPuF/j41iqxJ3KnEBtsUU9N0BHxzhc/qlQzuXzKENfsE+4A+/dXD5q9viFZhCI/OjBVZFanyCl376bHaos4q4e/8240OtigUrj4/G+9FmIc1M38zFMB6WAPj06nO/6shw+o8+NG2xYsSfKA9mVebNm9YWR7E7IRZ2JXmSBcwGmTWUmRxrLSKHO5dTjhQYOrU30l6KEa5wTxt1TebQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(6506007)(85182001)(6666004)(508600001)(6486002)(6512007)(9686003)(2906002)(38100700002)(5660300002)(6916009)(186003)(54906003)(8936002)(26005)(316002)(86362001)(82960400001)(66476007)(66556008)(33716001)(8676002)(4326008)(66946007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eVgreW5oR21saU5CeTlWZWEyOGZBTTB2ZnN2NGlSM3BvYm1tQlpydmdSRlMw?=
 =?utf-8?B?Y1JhSlVjRjNoVXZxQnlySVZaYm53V0YxbXZGRjdJZzdiMTVpRkZ2R1RUMUsv?=
 =?utf-8?B?TjRjb0xmNFhVaTd3WmtBQUJUTUpudkZDelBoa1kzNEkvS25YVm1EUi9IT2Vq?=
 =?utf-8?B?MDMzdDNEeEp4S3NKd1RKT2dmOE0zWlZrVyt0M3QrK3M2VTBkTWpWckdabzlZ?=
 =?utf-8?B?MmwwU0M4d0hZMm1CTUFSRSsvWTV2ZlZMS3VzUlhyZmxiZnhNZlQzZW1FNlEx?=
 =?utf-8?B?NGhrK0h0MHRvY3J2ZzZvR21CNG9seWFwOXZOZHc2TjNlZVFQbmRoL3VZYlVl?=
 =?utf-8?B?OTZIdTh2WjFzODVwWVllTW5jOTJmMzRGVmdLMW11Vk5pLzYvOTdzWTNKRHZY?=
 =?utf-8?B?RnBFcVlWS2QyZktUMlZoaWRKSlU4Z2JhaXRmOXlpUjZUOHplazdHbnd4UWQ2?=
 =?utf-8?B?TythOWEyajZweXYrZ3pkYldSUDZORmtmQ1JoaGRxMENrdzJiZzNGMHM3UTlT?=
 =?utf-8?B?WWJxK1RFajkrUGlWNmlnekkyZlpzeXBwQ2NPeTdGU09mNEF5OGxvdnlGZkZQ?=
 =?utf-8?B?c0xxcnk5eVJ3SkpwcGtodllJUFZDdi9xVnY2R2NZNXVBV3Ivb1VrbWZKSzZ0?=
 =?utf-8?B?TGo3NVlWNFU1OVhOTHNvU0FxeW42YUJYT3RmZWdydGlDanBvbmNYRWZiL3RJ?=
 =?utf-8?B?emlZQ3lHZmZvUWZzZ0g2ZzhzTjhUU0IzYnJlSGRhWDcrQndMMm04a3NZcC9H?=
 =?utf-8?B?N2NQTDdXOTVVQjlCbGFJZmlUN1lic0Z6WmtvM3ExQXdYNWlobGRNM01ldnBC?=
 =?utf-8?B?NVE0R2FvaDA0Tm1aVmNZMXQ0K01vaUlhRjJ3QnpCUlkwa2p1NnBWcjhzVzgx?=
 =?utf-8?B?LzQzSGhlT3hOc1dQVVA5SEh6SFcxVzRWVy9tSWlXY0dqUFBwWkxldjI3WGw5?=
 =?utf-8?B?bWZBODRDYVNPTFFhLzhrcjdUQ1IvRk1iTnJEWGJuRkFKd2NWcWY5Nmx5c2VV?=
 =?utf-8?B?aHpMMzR5UFczL1hNMjJ3UCtnRjJKU2Z0aDJ2cWk3RFFjeVlwcjN1S2tCMWY3?=
 =?utf-8?B?L2E1bktlQktkeTIrZUR0L3EzR2RZQU5aQXkvNjh1TU51S2VBaEVCaENpRWRo?=
 =?utf-8?B?ckdqWWxGL2tvTDMxWHh0YVZQRkhkd2hQOFRHdGlMWmwzdUQ4Uk91bXBJVVhw?=
 =?utf-8?B?ZjNnR1BzaWpyaFgwVU5XYXcybnVXanZiRGZBeWhINllOZGI5b01mVVJkbmps?=
 =?utf-8?B?ZmRoeFBXSDJGS3BLWDJUNlpkUXRLM2dQMFBBTFdPSk1zTzBNM3IyOVF2YmVH?=
 =?utf-8?B?ZjhCWUh1R1dqZVVBemNIVlJDeTB2OWVyNHdFRTZMczJBUXMvN0tIMDhELzRy?=
 =?utf-8?B?Qi9XT1BIV1Jwd1lFekR3U0dHSFR4YmdWTzdkWi9RVDE1Q3BFd0wzN2x3MExG?=
 =?utf-8?B?TStJK0NySldpcFlFdm5pV0JndlRDNmFaUHg0RkFpQ0JFQ2RIbVpUazN4UFVN?=
 =?utf-8?B?d2NDcmZxVGVjVzAyV3p2Q1hvY09rdWNrOExNNURXTU9OVnJuT096Nk1QQ3RW?=
 =?utf-8?B?aFBSUVFJcnFMWGhOSFcwVU5xalB4L2x2c0ZqWnVDVWVvUDh4c3FBRTIydEl3?=
 =?utf-8?B?Uko0N1orN0VZbWFHcTNuSDQ3OERIeWZHaDdyUkV0WitzQVlmc3JET0Yra0My?=
 =?utf-8?B?d0xtQ0x6Q1pLck5IKzFuNDQrQmYwNWNhQkxJVnhQSWdTKytPekc4Q1pwcFk4?=
 =?utf-8?B?UGlBY01zc3J4cFdDRkp3V2lsTlJWTm1GMEYzVEZUSmFNZVVaSHNjMmltbE5B?=
 =?utf-8?B?ZHkzYUZxMDRLMkp0MVgxTysydTBsYzc3UlB5QnRmeDVVZnZhZEFCVzVaVzVz?=
 =?utf-8?B?dW1PWVRYdjFCWjBwaW9nVjVBMWdBY3EvK2ZNOTJWeElNd2tWalZQU2RkbGdY?=
 =?utf-8?B?OUVVMlhlZnBlWkIwczZxcWVlOXpicHNiYk4zVFI4VHRVYnFiWkNlendDSGs3?=
 =?utf-8?B?b1RLUjJVTmluKzNFbXpNRXlnTFdwcFJnbjd1M1E5ZUhqOTJZVkt5d042RmEw?=
 =?utf-8?B?VnJwM2ttekYvaExIWVNjUkYySy9HT1JnT1RDaTZRa1BtVUIvYU4zMzhYV2J2?=
 =?utf-8?B?K0VEUHhmNlRzU20vTHhQajd5S3k0NStJNDlYMERjM2FNN2N1V2VyM1ZiWFpq?=
 =?utf-8?Q?xnrA8IudsFshGyqtN7U+LHk=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9496f261-cbd6-4914-699c-08d9f51d9b09
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2022 09:36:15.6088
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 56rL6qv14O+45nNv74qz6tWoy4KDO5kk+65OZRsHj1F+q5UnVVF2PqzbA30D8eRuaugtPvvFtygsyGRm6f4Epw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2464
X-OriginatorOrg: citrix.com

On Sat, Feb 19, 2022 at 11:24:25AM -0000, David Woodhouse wrote:
> 
> 
> > /*
> >  * With interrupt format set to 0 (non-remappable) bits 55:49 from the
> >  * IO-APIC RTE and bits 11:5 from the MSI address can be used to store
> >  * high bits for the Destination ID. This expands the Destination ID
> >  * field from 8 to 15 bits, allowing to target APIC IDs up 32768.
> >  */
> 
> I am not keen on that wording because it doesn't seem to fully reflect the
> fact that the I/OAPIC is just a device to turn line interrupts into MSIs.

But that's an architecture implementation detail, I'm not sure I've
seen this written down explicitly in any specification.

> The values in bits 55:49 of the RTE *are* what go into bits 11:5 of the
> resulting MSI address. Perhaps make it more parenthetical to make it
> clearer that they are not independent... "bits 11:5 of the MSI address
> (which come from bits 55:49 of the I/OAPIC RTE)..."

That could be an option also, as long as it's clear to which bits of
the IO-APIC RTE this affects.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Feb 21 09:48:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 21 Feb 2022 09:48:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275948.471942 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM5Iu-0006AS-AX; Mon, 21 Feb 2022 09:48:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275948.471942; Mon, 21 Feb 2022 09:48:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM5Iu-0006AL-7O; Mon, 21 Feb 2022 09:48:24 +0000
Received: by outflank-mailman (input) for mailman id 275948;
 Mon, 21 Feb 2022 09:48:23 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=vyL6=TE=citrix.com=prvs=04447c275=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nM5It-0006AF-7d
 for xen-devel@lists.xenproject.org; Mon, 21 Feb 2022 09:48:23 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 66fa17f1-92fb-11ec-8723-dd0c611c5f35;
 Mon, 21 Feb 2022 10:48:21 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 66fa17f1-92fb-11ec-8723-dd0c611c5f35
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645436902;
  h=from:to:cc:subject:date:message-id:
   content-transfer-encoding:mime-version;
  bh=lHcl6MSrGpr0X6ergIoeaWIyzjrFUMqzqv2h69J9W3I=;
  b=DEIoIKuxnpSI3WI+YqZzYnvqkOWjK6ACi5gr9COfa0BIC5G52nRZhO+V
   0FhneYH5wLVK0QXI/GZJ5DIWEyx7sXUsoW/ioGngI8TE1AnN2MISGiMjn
   tzkDTk1yxUnv+chg7Wny4NgkdRHDIGNzqoxJckUiVj/Q1WPZdkaSqCYwq
   0=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 64635581
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:HHt6wKoQYhnCHFP5SeTdxdqwPipeBmJmZRIvgKrLsJaIsI4StFCzt
 garIBmBPffeMGrxKN53bIiz9kpU75XSyd9lGVA9/ik3EywU8puZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlVEliefQAOCU5NfsYkidfyc9IMsaoU8ly75RbrJA24DjWVvX4
 4qq+qUzBXf+s9JKGjNMg068gEsHUMTa4Fv0aXRnOJinFHeH/5UkJMp3yZOZdhMUcaENdgKOf
 M7RzanRw4/s10xF5uVJMFrMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKv+Zvrgc91Zk
 b1wWZKMpQgBIp+TweZGXklhMx5+BpBH26/NGFThrpnGp6HGWyOEL/RGCUg3OcsT+/ptAHEI/
 vsdQNwPRknd3aTsmuv9E7QywJR4RCXoFNp3VnVI1zbWAOxgWZnea67L+cVZzHE7gcUm8fP2O
 ZZHMmcyPE2ojxtnCFwRIrVgl8WRpHTeYSxXiUuLg7US2j2GpOB2+Oe0a4eEEjCQfu1UgUSwt
 m/A537+ABwRKJqY0zXt2mKhgKrDkD32XKoWFaak7bh6jVuL3GsRBRYKE1yhrpGEZlWWAowFb
 RZOo2x38PZ0pBfDosTBswOQvEzb5xxHVoppM9I60zyM6bre2irHGT1RJtJeU+AOuMgzTD0s8
 1aGmdL1GDBi2IGopWKhGqS89m3rZ3VMRYMWTWpdFFZevYG/yG0mpk+XFr5e/LiJYsoZ8N0a6
 xSDt2AAiroalqbnPI3rrAmc01pASnUkJzPZBzk7vEr4tGuVh6b/PuREDGQ3Ct4ace6koqGp5
 iRspiRnxLlm4WuxvCKMWv4RO7qi+uyINjbR6XY2QcV8rGTxqiPyINoBiN2bGKuOGpxZEQIFn
 WeJ4V8BjHOtFCDCgVBLj3KZVJ1xkPmI+SXNXfHIdNteCqWdhyfclByCkXW4hji3+GB1yPlXE
 c7CLa6EUCZLYYw6nWHeb7pMjtcWKtUWmDq7qWbTlE/8j9JzpRe9FN84Dbd5RrpntPjd+F2Nq
 b6y9aKikn1ibQE3WQGOmaY7JlEWN3krQ5fwrs1cbOmYJQR6XmomDpfsLXkJIuSJQ4w9ej/0w
 0yA
IronPort-HdrOrdr: A9a23:uLdQza78R0zBhFJfnAPXwAPXdLJyesId70hD6qkoc20yTiX5rb
 HToB1p726EtN9xYgBRpTnuAtjjfZqxz/FICMwqTNCftWrdyRaVxeNZnO7fKlTbckWUm4JgPO
 VbAsxD4bbLbGSS+PyKgzVQZOxB/DDoys6VbUq09R1QpEpRGthdBk9Ce36m+socfng5OXLsf6
 DsmfausVKbCA8qh+qAdwM4Y9Q=
X-IronPort-AV: E=Sophos;i="5.88,385,1635220800"; 
   d="scan'208";a="64635581"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Zh/CYRByhUnjYSFdbIiiQI/2lmCyxyYJ3T23U0U+4pd/Px33TauQwG8GxD4NrrO7yK3lLhk08DFwZGH9kMieacPtsCQYjgei2IatcJzuh/SDpKrIjWwAGJePALs5bWFkikkghGqZm/2DJFXJKQBrKvacs0Rl6/0kMaH0HCn4ro4mMdQlkOGPlM/aYEKNHo1Rxt+C7QtmlbPyYfZ+ABHBotEonEKYyBSwkFkTOLqpKgXzwxcnAo7EGWZG6qXvJ1g2esMJjzLF2oMDAGzGURs6NazAyxN3B7uoKQpQnSRlr1e4WsEJD3ZiEhVdMB7mKM80iPxwEYdz+CKdxybxtNkCpQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=lbyOJGVqno9s0d2X3LZSO9x9Tj8UTr1uNemmnbyLu/M=;
 b=LFF/xjK5dGOaVKW7muWMj3svsjHHy16vIxh0IL/L/b3BnOreTSQhDVWYQpPgdPc585XxFb7oPQwh/lsDqF6YmzjWxSBuf3z1GGyTbZdqpEpRpTgbtUMvM1u0vSdpzr4zqKtgqyBj39dUK1f419oBg+8Nm+wrYBBIvcF9jfhYUgEaJa+jPmx/17fx4BqRojFiJr+aXFnAQHn2yHj9FQR+TV5KDXLXZWfoOz70Abc99Pz3SiUDm+K8Dz8yfcNg+jwMsylUYWCwNAFurItfS+n3in643BKS3XLvwgX8naEwc2e6LOxJOwHwIg+JFXy9UHEPd84+X51QJ02oS50cTNqn3g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=lbyOJGVqno9s0d2X3LZSO9x9Tj8UTr1uNemmnbyLu/M=;
 b=QW5zR/C9hPgRyjNozDOuO9Y9Mimiah0emP24+qjIZthEuVu+W2JCIMyt4v6eqxGp64y32uwSiKwO/yHRfObn7LnBD5OI2taZGZsuoj3IEnmnVP5I4APilYalrsJDcS0l7D4rW1DyU9R3mmxXOffxlI0QFIw3l2s35aGJBGaFtWs=
From: Roger Pau Monne <roger.pau@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: <iwj@xenproject.org>, Roger Pau Monne <roger.pau@citrix.com>
Subject: [PATCH] coverity: disable flight from crontab
Date: Mon, 21 Feb 2022 10:48:00 +0100
Message-ID: <20220221094800.54169-1-roger.pau@citrix.com>
X-Mailer: git-send-email 2.34.1
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO2P123CA0108.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:139::23) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c368af5d-535d-4bdf-34c0-08d9f51f4526
X-MS-TrafficTypeDiagnostic: BN3PR03MB2179:EE_
X-Microsoft-Antispam-PRVS: <BN3PR03MB21799F26FF72F0B98686F6158F3A9@BN3PR03MB2179.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: MRRAQvXrKMnnnf52pKd8KB3Poja392UWJwKW3OOjk/7c3HG3ZK/2gOMEu+UTX1mOrLn+sA5a/536Or2G2Wk4mLXfHb1YJNqKEAnCUMiIb+lZ1sycXg/NGTBBh5P1MScWwPVNDrr63ngcFwBvqVIAi+DLxlma/BvLCi71DyJgp7rq9NPUuNAIdMVpZxW3VkXlSj2omd2V6F+PHDYb0q5Yz7UwIDSRpXDEkUT7mDkJtB9fHdoJhpMMJVVxSr2E6vL6+WivZs/8HUGxDuA99fexmbnirPYOaiV5+4ZHu1C0dOtaksOrAVT+Pi7rXJAKwT4bz0Qu5C7wJPo2V/7KEzDcwqiyH1F5IamI9Tmy/bQn7i8H15h+xS76sAN0DrDleyI3rqKRRCWGWuvwCc1JBc1FwEsP/zxG4kw4FFYA8ZgmQyvo1tbPVvHw/Nvp/S9cFCmvtG30AACJ0M3gWbyi9uppRGqxmH4hHsaUst/Rpr8XytQd+simPJS5sVi6Cg2XG9fYV13pKwdLLuA7C+1prGu4tGanbYHYBz1PI/P+GX1i+DpIW2F1A8WiKxfArzhBWU69vE5JU3V+mXFHv7EpHVaLpFIyWI9aCrmcEpxI7chPsV1cXV2fef6J/VY0VAvHyy2dLw9vnVT1tLI3vbTrLJk1XQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(8676002)(4326008)(66556008)(66476007)(6486002)(66946007)(6916009)(316002)(508600001)(83380400001)(1076003)(6512007)(8936002)(5660300002)(2616005)(2906002)(107886003)(82960400001)(6666004)(86362001)(186003)(26005)(6506007)(38100700002)(36756003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U1dZOC9UVm9KLy9nenZuY3hSRytKSjhNdUR0TnBpNGdKYis1TENnSVkvdjFF?=
 =?utf-8?B?NWV4QkFNVEZ0eEZCNFJRY3NydGJ5SjJYbWFPbzMzUjI3VmlJWlNybUIxalpO?=
 =?utf-8?B?YmpwdUVKWWRkdk5zb3piK20wVWo0eXBob0hzc0xTa1krNnFqdnF6bklaNzEw?=
 =?utf-8?B?M01oVzBKZlR0MXhHOUV1REhndHdCRVdETHY3eXlyOU1RY2xSTmVjb01UNUps?=
 =?utf-8?B?SjRIVHpZK0p5b3dOb3g3OExUckxsa054UkJYVGpRa08reWJSbEVMdjBHL01u?=
 =?utf-8?B?anA0Q1JDM2x6Z084YXFZa0l1bFV6UGxNZjU5TXl1TDJGemgrTVViZFkwOHYx?=
 =?utf-8?B?dElBcDh0R1FPVnRzcVB0SVRUZ2Z2dGJHQ284RnQySzM4OW1uaEpQajA0bnFs?=
 =?utf-8?B?bk42TzIzcHdrOWR3Q3N0V1BOd0VHcGxhVGhNWmVkTStwckRkNmx3R2hxN2xo?=
 =?utf-8?B?MHYvYldZdWt5Qkd6TCtPRlBSU0dQNitrUmZUcU5DNExWaC93THJkVFJlbXhK?=
 =?utf-8?B?ZGhIMytTRm9IRUVhWndrbDVaa3VvZ0YvMCt5cFlxbDBxcHBzUE9NWlg0UnJs?=
 =?utf-8?B?Zm9Ia2tPVE5IUGhnMnU5L2c5T3RZYlAzc0YrUFExYWVBaEN4OVZNN2JFMTd4?=
 =?utf-8?B?Y3lPQzUwdU1VTFNWZzFPWENadElpQThJN3plM2pwSXNDRWQ4Z2Nlbnp0S2JD?=
 =?utf-8?B?Z3JsL2piUVlFVzZGTzVLbzlvTHFzc1RERW1ZZmluM0VZYTlTY0VGNlBOc0tp?=
 =?utf-8?B?S2w3amtkbzkyeWJETE9Cb3JJZ05WVlFmN1RwaU5lOVhXdXZGVCtuQTArQ3d0?=
 =?utf-8?B?NXlPdzhQYTRnWUxqbTFyOENFUzR3VnRKVWZCdjZuU0hxWUNzQkFOYzNPVmNU?=
 =?utf-8?B?amxFNktqcndZb0dVbFpCK040QThsSUZFb00rNnIxZ1E3NnUrN0oxMTdUUlc0?=
 =?utf-8?B?M20vNDNnMkcyNmNnL1dIQ3ZOQWFXc1R3b2srT1VpREVIclZ0bjM5emxWd05q?=
 =?utf-8?B?eGJLOTlKajJMRmg3WmVpYVV3WGU2dVIxWkdUK3NPNFhmTTZyVTZuV0xmTWNS?=
 =?utf-8?B?dlhTUWFOSXhic0IvRjFidlB6TEczRXJ3K3FmRkFVam9BZ243OTJucUVCYzlr?=
 =?utf-8?B?azNLOExtU2ZtM3dPZ09lNElWR09ITjdDM2daUGpxWWROOVUveDBHdzFVcjd1?=
 =?utf-8?B?Rk1tV1ArUXNmZE9CaEdmL1V6V1RkMmhENjd1SU13cjRsT0UzazNORGRLQ3o5?=
 =?utf-8?B?SkgwQ2VuTzZLdE9GVW9DZkhDQitXcVFIbEdaQkRyNEJ4K1NMVEU0SUpjNUpU?=
 =?utf-8?B?ODBCNXhpZGlqeEFYZllKczZUTkszY2l2a05maUhrSkNUbEJoKzVOdFFpMnJh?=
 =?utf-8?B?QnY2NHlRN3UvNFk5cTEvUHZzY1RhNkRuRTRFSnAwSmlKd1I0aS9GOGlwbDFI?=
 =?utf-8?B?cGNjN29kTXBGNDhoLzlGY1kvMit4WUo4M2drT1V1YktOZlZpd0lpOThoR3NP?=
 =?utf-8?B?YlptYUtiWVhWZEJBWUVCVU4vQk5lU2Rjb2ZYZzZ3OFluM0VGRHZ5THBWWHRX?=
 =?utf-8?B?aWZIT1RtK1RST3U0SjdDQnNrWXh2eDQybUJTZm9lS0c4ZkpLTFFNUTdKSkV0?=
 =?utf-8?B?UFRFMUNVaFFFajJ1U2w0dWNYVTJzYmdaTTRxVjM4RHZXTkMxNHJPNzRhSkJu?=
 =?utf-8?B?QTByUFFPa1g5NXQzZjFzaytoN0tRK0xubXlDV1NkSEZzK0h4Yjg3MFFKVytJ?=
 =?utf-8?B?dVBkeHdzcmlHWEFsZWpQc1RqdE9vY01BekxOOG8xcjBJVjZCbVl1UE03K0t5?=
 =?utf-8?B?K1NzeHVlemg2Zm1Zb3ZucXdUbytaMmhyQlNYdnUxSmVoQnhoZ0RybS85djdI?=
 =?utf-8?B?czF3WmNGM2Y5NjQ4UHU5b3MyZkNmdTBRU1NMOVRCUnozR1ZxRmhNeG9HMllH?=
 =?utf-8?B?dHFNanlveGI2VVNYRng1N0V0dlFoelNyalZMU2huejhuNGpDSGlvdUNYc1hS?=
 =?utf-8?B?dHI4Vzk0Q1VnbThTcCtKRFV5anlnUHJSSUI5QjJVTXZoU09BU2hDQ0JNdXdn?=
 =?utf-8?B?ODM4NlhpQXJ1TmNqNFZ1Wll0VTJaaklkdTdBZlpTWEJQVHVCcGZvdndQZmk5?=
 =?utf-8?B?TGJleXhOVUlKdURmRDdlbU80cHl4VjJoRitkcGtXWXZKUEswcmJRMkNPRm5Z?=
 =?utf-8?Q?GAyI2JyODBBSq3T6/KEo0q8=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c368af5d-535d-4bdf-34c0-08d9f51f4526
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2022 09:48:10.3496
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VrCNrr/w9UhM+gwcV/Q/evYdgdK6XqkoBmkGVM3jtQwnfUoqheeRa0kS2/yQnGPajOS5tS4FlIXuNFD7WVAvMw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB2179
X-OriginatorOrg: citrix.com

We are currently doing the Coverity Scans using a github workflow.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
 crontab | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/crontab b/crontab
index 8d9b31f1..f43e8bc5 100755
--- a/crontab
+++ b/crontab
@@ -12,7 +12,7 @@ MAILTO=osstest-admin@xenproject.org
 0		*	* * *		cd testing.git && BRANCHES=xen-unstable-smoke	./cr-for-branches branches -q "./cr-daily-branch --real"
 4-59/30		*	* * *		cd testing.git &&				./cr-for-branches branches -q "./cr-daily-branch --real"
 18		9	* * 1,3,5	cd testing.git && BRANCHES='linux-next freebsd-master' 	./cr-for-branches branches -w "./cr-daily-branch --real"
-18		9	* * 3,7		cd testing.git && BRANCHES=xen-unstable-coverity ./cr-for-branches branches -w "./cr-daily-branch --real"
+#18		9	* * 3,7		cd testing.git && BRANCHES=xen-unstable-coverity ./cr-for-branches branches -w "./cr-daily-branch --real"
 34		15	23 * *		cd testing.git && BRANCHES=examine		./cr-for-branches branches -w "./cr-daily-branch --real"
 18		4	* * *		cd testing.git && BRANCHES='linux-3.0 libvirt' ./cr-for-branches branches -w "./cr-daily-branch --real"
 6-59/15   	*	* * *		cd testing.git && EXTRA_BRANCHES='xen-unstable-smoke linux-3.0 libvirt freebsd-master' ./cr-for-branches bisects -w "./cr-try-bisect --real"
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Mon Feb 21 10:03:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 21 Feb 2022 10:03:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275959.471975 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM5XO-0000er-81; Mon, 21 Feb 2022 10:03:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275959.471975; Mon, 21 Feb 2022 10:03:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM5XO-0000ej-4r; Mon, 21 Feb 2022 10:03:22 +0000
Received: by outflank-mailman (input) for mailman id 275959;
 Mon, 21 Feb 2022 10:03:21 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=fvXl=TE=citrix.com=prvs=044a77a3b=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nM5XN-00008I-D3
 for xen-devel@lists.xenproject.org; Mon, 21 Feb 2022 10:03:21 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7f0fbc45-92fd-11ec-8eb8-a37418f5ba1a;
 Mon, 21 Feb 2022 11:03:20 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7f0fbc45-92fd-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645437800;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=HSRz95RA0iD9ZY3bHdVhf3Vb2e+MAy95oW5EbGSBx8c=;
  b=Je6+j5Ch6fDHjp6yEaQ9FU0q6pEn8PrlrSVsx7KlladOU5P93Cs/PWkO
   5BFE4CRiRq+/ui5XiOOCy7Hf1UYAAwdcpewY6AOprbngNWnWfcRP9TjO9
   MSsf8P0d0W4S4oBTKSd1GgPPXFOzVsxNfzmsyjOTxMj9/zYrAcow85hMV
   s=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 66881348
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:FEE52Km5bvvTRA36iZaizR/o5gzRJkRdPkR7XQ2eYbSJt1+Wr1Gzt
 xIeWmyPPfqJYGD0eI10OY60oEsBsMOBx4RlTFBtqS03FyMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2UILd9IR2NYy24DjWVrV4
 LsenuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR
 v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ
 NtxWZOYVDooHKLSxMgnVUcbMBBEL/VA+qebLi3q2SCT5xWun3rExvxvCAc9PJEC+/YxCmZLn
 RAaAGlTNFbZ3bvwme/lDLk37iggBJCD0Ic3k3ds1zzGS90hRojOWf7i7t5ExjYgwMtJGJ4yY
 uJHN2o/NU+cM3WjPH9IItUBvNn3rUKmUBdktnu0rK4n8zfcmVkZPL/Fb4OOJ43iqd9utlaVo
 CfK8nr0BjkeNceD0nyV/3S0nOjNkCjnHoUIG9WFGuVC2QPJgDZJUVtPCAX98aLRZlOCt8x3N
 nEV2CUw8YQI8hLobejHTUW+ombYsUtJMzZPKNES5AaIw6vSxg+WAGkYUzJMAOAbWN8KqS8Cj
 QHQwY6wbdB7mPjMEC/GqO/Ixd+nEXVNdQc/iTk4oRzpCjUJiKU6lVrxQ9lqC8ZZZfWlSGirk
 1hmQMXT7oj/bPLnNY3mpzgrYBr2//AlqzLZAS2NAwqYAvtRPtLNWmBRwQGzAQx8BIiYVEKdm
 3MPhtKT6usDZbnUynDQG7VRTez4uqzUWNE5vbKIN8N8nwlBBlb5JdwAiN2ADBwB3jk4lc/BP
 xaI5FI5CG57N3q2d65nC79d+OxxpZUM4e/ND6iOBvIXO8AZXFbeoElGOB7Bt0iwwRNEufxuZ
 v+mnTOEUC9y5VJPl2HtGY/wENYDm0gD+I8kbcqll0/+ieLGPhZ4i94taTOzUwzw14vcyC29z
 jqVH5fiJ8l3OAEmXhTqzA==
IronPort-HdrOrdr: A9a23:58ab3KOioY/PzMBcTvmjsMiBIKoaSvp037Eqv3oedfUzSL3gqy
 nOpoV86faaslYssR0b9exofZPwJE80lqQFhrX5X43SPzUO0VHAROoJgLcKgQeQfxEWntQtrZ
 uIGJIeNDSfNzdHZL7BkWuFL+o=
X-IronPort-AV: E=Sophos;i="5.88,385,1635220800"; 
   d="scan'208";a="66881348"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>
Subject: [PATCH 1/3] tests/resource: Initialise gnttab before xenforeignmemory_map_resource()
Date: Mon, 21 Feb 2022 10:02:52 +0000
Message-ID: <20220221100254.13661-2-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220221100254.13661-1-andrew.cooper3@citrix.com>
References: <20220221100254.13661-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

It the 'addr' input to mmap(), and currently consuming stack rubble.

Coverity-ID: 1500115
Fixes: c7a7f14b9299 ("tests/resource: Extend to check that the grant frames are mapped correctly")
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Roger Pau Monné <roger.pau@citrix.com>
---
 tools/tests/resource/test-resource.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/tests/resource/test-resource.c b/tools/tests/resource/test-resource.c
index 0557f8a1b585..189353ebcb43 100644
--- a/tools/tests/resource/test-resource.c
+++ b/tools/tests/resource/test-resource.c
@@ -24,7 +24,7 @@ static void test_gnttab(uint32_t domid, unsigned int nr_frames,
                         unsigned long gfn)
 {
     xenforeignmemory_resource_handle *res;
-    grant_entry_v1_t *gnttab;
+    grant_entry_v1_t *gnttab = NULL;
     size_t size;
     int rc;
     uint32_t refs[nr_frames], domids[nr_frames];
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 21 10:03:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 21 Feb 2022 10:03:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275958.471965 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM5XN-0000Oz-0O; Mon, 21 Feb 2022 10:03:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275958.471965; Mon, 21 Feb 2022 10:03:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM5XM-0000Os-Tc; Mon, 21 Feb 2022 10:03:20 +0000
Received: by outflank-mailman (input) for mailman id 275958;
 Mon, 21 Feb 2022 10:03:20 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=fvXl=TE=citrix.com=prvs=044a77a3b=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nM5XM-00008I-9z
 for xen-devel@lists.xenproject.org; Mon, 21 Feb 2022 10:03:20 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7d53d089-92fd-11ec-8eb8-a37418f5ba1a;
 Mon, 21 Feb 2022 11:03:18 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7d53d089-92fd-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645437798;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=59BUrJyJFYGfQ4z14Fv38dK7j3O8WgWr/hGqJtw6/PQ=;
  b=do3PdFAeGGpMg4CzR0+7slfvKAh/RilG8FJt7GAnY5S7HtIjbO26py+h
   5Gd4kHnLK3yDyVO6nPIfAd0nGtoJRfNprJ+koldngXFq+eNoUdlPCd/TQ
   wBXm/uHiLn2r9sROJIwG1dmlKOrfOJrttpQzTCyOf5dJZU4ZgrvSEGlXS
   Y=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 66881347
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:unQ4sqt6Z4XoIJeV/0Qy9JgrYufnVAZeMUV32f8akzHdYApBsoF/q
 tZmKWmEM6uCazHzeohyaYmwoUMCu5aGytZiTwo//Co3FHkX+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQzy4bVvqYy2YLjW1nX4
 IuryyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb
 /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo
 Oihu6BcRi8OOr3rseYHTyBYCgBZH58epoXgeFyg5Jn7I03uKxMAwt1rBUAye4YZ5vx2ESdF8
 vlwxDIlN07ZwbjsmfTiF7cq1p9LwMrDZevzvllJyz3DAOlgapfEW6jQvvdT3Ssqh9AIFvHbD
 yYcQWQxPESZOEEQUrsRILI7mrqSiGTGTzlZ61SJu6cSvWWP0yUkhdABN/KKI4fXFK25hH2wt
 m/Aumj0HBweHNie0iaetGKhgPfVmiH2U55UE6e3nsOGm3XKmDZVUkdPEwLm/7/p0SZSRu6zN
 WQz/joJhKoo6HWrV/jafS/g/kSj5zoDDo84//IB1CmBza/d4gC8D2cCTyJcZNFOiPLaVQDGx
 XfSwYq3WGUHXKm9DCvEq+zK9W/a1T09cDdaDRLoWzfp9DUKTGsbqhvUBuhuH6eu5jEeMWGhm
 mvaxMTSalh6sCLq60lZ1Q2d695PjsKQJuLQ2ukwdjj4hj6VnKb/O+SVBaHztJ6s1rqxQFibp
 2QjkMOD9u0IBpzlvHXTHLhWTO34uqfYamy0bbtT834JrWnFxpJeVdoIvGEWyLlBaa7ohgMFk
 GeM4FgMtfe/zVOhbLNtYpLZNijZ5fOIKDgRbdiNNoAmSsEoLGevpXgyDWbNjzGFuBV9yskXZ
 MbEGftA+F5HUMyLOhLtHLxDuVLqrwhjrV7uqWfTlUr/iuPGPCbPIVrHWXPXBt0EAGq/iF292
 75i2wGikH2zjMWWjvHrzLMu
IronPort-HdrOrdr: A9a23:VYWQmqPxKuRMEcBcTvmjsMiBIKoaSvp037Eqv3oedfUzSL3gqy
 nOpoV86faaslYssR0b9exofZPwJE80lqQFhrX5X43SPzUO0VHAROoJgLcKgQeQfxEWntQtrZ
 uIGJIeNDSfNzdHZL7BkWuFL+o=
X-IronPort-AV: E=Sophos;i="5.88,385,1635220800"; 
   d="scan'208";a="66881347"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>
Subject: [PATCH 3/3] CI: Coverity tweaks
Date: Mon, 21 Feb 2022 10:02:54 +0000
Message-ID: <20220221100254.13661-4-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220221100254.13661-1-andrew.cooper3@citrix.com>
References: <20220221100254.13661-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

 * Use workflow_dispatch to allow manual creation of the job.
 * Use parallel builds.  The workers have two vCPUs.
 * Shrink the dependency list further.  build-essential covers make and gcc,
   while bridge-utils and iproute2 are runtime dependencies not build
   dependencies.  Alter bzip2 to libbz2-dev.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Roger Pau Monné <roger.pau@citrix.com>
---
 .github/workflows/coverity.yml | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/.github/workflows/coverity.yml b/.github/workflows/coverity.yml
index 9d04b56fd31d..6e7b81e74f72 100644
--- a/.github/workflows/coverity.yml
+++ b/.github/workflows/coverity.yml
@@ -2,6 +2,7 @@ name: Coverity Scan
 
 # We only want to test official release code, not every pull request.
 on:
+  workflow_dispatch:
   schedule:
     - cron: '18 9 * * WED,SUN' # Bi-weekly at 9:18 UTC
 
@@ -11,11 +12,11 @@ jobs:
     steps:
     - name: Install build dependencies
       run: |
-        sudo apt-get install -y wget git gawk bridge-utils \
-          iproute2 bzip2 build-essential \
-          make gcc zlib1g-dev libncurses5-dev iasl \
-          libbz2-dev e2fslibs-dev git-core uuid-dev ocaml \
-          ocaml-findlib xz-utils libyajl-dev \
+        sudo apt-get install -y wget git gawk \
+          libbz2-dev build-essential \
+          zlib1g-dev libncurses5-dev iasl \
+          libbz2-dev e2fslibs-dev uuid-dev ocaml \
+          ocaml-findlib libyajl-dev \
           autoconf libtool liblzma-dev \
           python3-dev golang python-dev libsystemd-dev
 
@@ -31,7 +32,7 @@ jobs:
 
     - name: Pre build stuff
       run: |
-        make mini-os-dir
+        make -j`nproc` mini-os-dir
 
     - uses: vapier/coverity-scan-action@v1
       with:
@@ -39,3 +40,4 @@ jobs:
         project: XenProject
         email: ${{ secrets.COVERITY_SCAN_EMAIL }}
         token: ${{ secrets.COVERITY_SCAN_TOKEN }}
+        command: make -j`nproc` build
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 21 10:03:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 21 Feb 2022 10:03:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275957.471954 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM5XL-00008X-PF; Mon, 21 Feb 2022 10:03:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275957.471954; Mon, 21 Feb 2022 10:03:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM5XL-00008Q-MD; Mon, 21 Feb 2022 10:03:19 +0000
Received: by outflank-mailman (input) for mailman id 275957;
 Mon, 21 Feb 2022 10:03:18 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=fvXl=TE=citrix.com=prvs=044a77a3b=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nM5XJ-00008I-Vo
 for xen-devel@lists.xenproject.org; Mon, 21 Feb 2022 10:03:17 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7bb96691-92fd-11ec-8eb8-a37418f5ba1a;
 Mon, 21 Feb 2022 11:03:16 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7bb96691-92fd-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645437796;
  h=from:to:cc:subject:date:message-id:mime-version:
   content-transfer-encoding;
  bh=59Dpd1kU+lI30ewhyNN1BiYvjzWb2962wpSkkcHXHNc=;
  b=OlYYmi9ljC2bBZjicka7xRVndZ3XYEjL2pgqsKu4HZD7h5wLgWF3D0CI
   s+QCTy3QnkMcJp5tZUKiZv3O6h9Lwuo/iX8cXr9Y/WoLnzoOZyoRtTxG+
   c/mG4mDFnoKOfGR1TapeLbki7IAGwcQUCa0na1YpTwHLjEmsSFQM5aFYP
   I=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 64073850
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:/I0hzK5KT+R2Tu31kBTPHgxRtGjHchMFZxGqfqrLsTDasY5as4F+v
 jEcWmvTb6mJM2Lwct9/Pouzo0wOsZOByINiGwQ/r389Hi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFx2XqPp8Zj2tQy2YLjWlvU0
 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X
 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx
 umhurS2cT0OMqzCw9hGaANIAn0iPPRv3bD+dC3XXcy7lyUqclPpyvRqSko3IZcZ6qB8BmQmG
 f4wcW5XKErZ3qTvnez9GrIEascLdaEHOKs2vH16wC6fJvEhWZ3ZGI3B5MNC3Sd2jcdLdRrbT
 5RFMWU0PEmYC/FJEgY5JsM/l6SQvSTyfzcCr2yFopEM0XeGmWSd15CyaYGIK7RmX/59jkue4
 27L4Wn9KhUbL8CEjyqI9Gq2ge3Clj+9X5gdfIBU7dYz3gfVnDZKTkRLCx3r+pFVl3JSRfpZE
 3Yz9isg9pRpz1a7X4WhXkSRhXG960t0t8VrL8U27wSEy6zx6gmfB3QZQjMpVOHKpPPaVhRxi
 AbXwoqB6ShH9eTMFCnDruv8QSaaZHBNRVLucxPoWufsDzPLhIgoxizCQd94eEJepo2kQGqgq
 9xmQcVXulnysSLp//jhlbwkq2j1znQscuLSzl+KNl9JFisjOOaYi3WAsDA3F8poIoeDVUWmt
 3MZgcWY5+1mJcjTyHHWELlcQeD0vaft3NjgbblHRcRJythQ0yT7IdA4DM9Wfy+FzfroiRe2O
 RSO6Gu9FbdYPWewbL8fXm5CI59C8EQULvy8Dqq8RoMXOvBZLVbblAkzNR/49z28yyAEzPBgU
 ap3hO7xVB72/4w8l2HoLwrcuJd2rh0DKZT7H86jlE3/ieLEDJNXIJ9cWGazgikCxPvsiG3oH
 xx3baNmFz03vDXCXxTq
IronPort-HdrOrdr: A9a23:0L4eAaEoo0ruCPmxpLqE5MeALOsnbusQ8zAXP0AYc3Jom6uj5q
 eTdZUgpHvJYVkqOE3I9ertBEDiewK4yXcW2/hzAV7KZmCP0wHEEGgL1/qF/9SKIUzDH4Bmup
 uIC5IOauHNMQ==
X-IronPort-AV: E=Sophos;i="5.88,385,1635220800"; 
   d="scan'208";a="64073850"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH 0/3] Misc coverity fixes and tweaks
Date: Mon, 21 Feb 2022 10:02:51 +0000
Message-ID: <20220221100254.13661-1-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

Andrew Cooper (3):
  tests/resource: Initialise gnttab before
    xenforeignmemory_map_resource()
  xen: Rename asprintf() to xasprintf()
  CI: Coverity tweaks

 .github/workflows/coverity.yml       | 14 ++++++++------
 tools/tests/resource/test-resource.c |  2 +-
 xen/common/ioreq.c                   | 16 ++++++++++------
 xen/common/vsprintf.c                | 11 ++++++-----
 xen/include/xen/lib.h                |  4 ++--
 5 files changed, 27 insertions(+), 20 deletions(-)

-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 21 10:03:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 21 Feb 2022 10:03:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275960.471987 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM5XQ-0000wV-IG; Mon, 21 Feb 2022 10:03:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275960.471987; Mon, 21 Feb 2022 10:03:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM5XQ-0000wM-EP; Mon, 21 Feb 2022 10:03:24 +0000
Received: by outflank-mailman (input) for mailman id 275960;
 Mon, 21 Feb 2022 10:03:22 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=fvXl=TE=citrix.com=prvs=044a77a3b=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nM5XO-0000em-K2
 for xen-devel@lists.xenproject.org; Mon, 21 Feb 2022 10:03:22 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7e10aed3-92fd-11ec-8539-5f4723681683;
 Mon, 21 Feb 2022 11:03:20 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7e10aed3-92fd-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645437800;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=XhnhyXBfcCg1IFjeQ8rcSX9ITITWwAZ7WnOmhbzucr0=;
  b=OoeXe/j0jyaDDUlXZXWfwyxq17XQzunoQGwoCmig+qDxr1/9VO8hNGT/
   mToX6T0iWMCyJp9KVMMetEp++LY61i9qxqzr4QpX4ZnE0rnPc+wikRr6K
   owXubbTu56N+n25qwGYlIo+MDKBiwNMlj5bweaj7yIvMwO8O8YIsM1CGN
   c=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 65042091
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Jsln+6rziWGtcyAd+T1qgaCfildeBmIjZRIvgKrLsJaIsI4StFCzt
 garIBnUO6yKajPzLY1waYuy9h4AuZ/Uxt9gHQs9/Cg8H3hG+JuZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlVEliefQAOCU5NfsYkidfyc9IMsaoU8ly75RbrJA24DjWVvX4
 4qq+qUzBXf+s9JKGjNMg068gEsHUMTa4Fv0aXRnOJinFHeH/5UkJMp3yZOZdhMUcaENdgKOf
 M7RzanRw4/s10xF5uVJMFrMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKv+Zvrgc91Zk
 b1wWZKMpQgBDqHBxbokXwtkHjBiBaF44qGdIV24rpnGp6HGWyOEL/RGCUg3OcsT+/ptAHEI/
 vsdQNwPRknd3aTsmuv9E7QywJR4RCXoFNp3VnVI5DfVF/s5B7vERL3H/4Rw1zYsnMFeW/3ZY
 qL1bBIxMUycOUUeYz/7DroFnr+EhyGjdQRmk2mqnKkHxDSI0Q5+he2F3N39JYXRGJQ9clyjj
 n3C13T0BFcdLtP34TiY9nOhgMffkCW9X5gdfJWg/+NuqE2ewCoUEhJ+fUCgvfCzh0q6WtReA
 08Z4Cwjqe417kPDZsnwWVi0rWCJujYYWsFMCKsq5QeV0K3W7g2FQG8eQVZpacMknN87QyQw0
 V2ElM+vAiZg2JW3Y3+A8rafrRupJDMYa2QFYEc5oRAtuoe55ttp11SWE4glQPXdYsDJ9S/Y8
 zyH8XYHi6cvgN8X76mF506dgxeruc2cJuIq3Tn/UmWg5wJ/QYeqYY209FTWhcp9wJalokqp5
 yZdxZXHhAwaJdTUzXHWHr1RdF28z6vdaFXhbUhT847NHthH01qqZshu7T53Py+F2e5UKGayM
 Cc/Ve68jaK/3UdGj4cqOepd6OxwlMAM8OgJsdiOM7JzjmBZLlPvwc2XTRf4M5rRuEYti7ojH
 pyQbNyhC30XYYw+kmbrHLdBgOJ6m3pvrY82eXwc5076uYdymVbPEetVWLdwRrtRAFy4TPX9r
 I8EapriJ+R3W+zieCjHmbP/3nhRRUXX8ave8pQNHsbae1IOMDh4V5f5nONwE6Q4zv89vrqZo
 RmAtrpwlQOXaYvvcl7RNBiOqdrHAP5CkJ7MFXZyZQ3xgyB7O+5CLs43LvMKQFXuz8Q7pdYcc
 hXPU5zo7ihnItgfxwkgUA==
IronPort-HdrOrdr: A9a23:WtkwNakGjCxkVLRjy1Z+ifWYVffpDfIu3DAbv31ZSRFFG/Fxl6
 iV8sjztCWE8Qr5N0tBpTntAsW9qDbnhPtICOoqTNGftWvdyQiVxehZhOOIqVDd8m/Fh4pgPM
 9bAs9D4bbLbGSS4/yU3ODBKadD/OW6
X-IronPort-AV: E=Sophos;i="5.88,385,1635220800"; 
   d="scan'208";a="65042091"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap
	<George.Dunlap@eu.citrix.com>, Ian Jackson <iwj@xenproject.org>, Jan Beulich
	<JBeulich@suse.com>, Stefano Stabellini <sstabellini@kernel.org>, Wei Liu
	<wl@xen.org>, Julien Grall <julien@xen.org>, Paul Durrant <paul@xen.org>
Subject: [PATCH 2/3] xen: Rename asprintf() to xasprintf()
Date: Mon, 21 Feb 2022 10:02:53 +0000
Message-ID: <20220221100254.13661-3-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220221100254.13661-1-andrew.cooper3@citrix.com>
References: <20220221100254.13661-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

Coverity reports that there is a memory leak in
ioreq_server_alloc_rangesets().  This would be true if Xen's implementation of
asprintf() had glibc's return semantics, but it doesn't.

Rename to xasprintf() to reduce confusion for Coverity and other developers.

While at it, fix style issues.  Rearrange ioreq_server_alloc_rangesets() to
use a tabulated switch statement, and not to have a trailing space in the
rangeset name for an unknown range type.

Coverity-ID: 1472735
Coverity-ID: 1500265
Fixes: 780e918a2e54 ("add an implentation of asprintf() for xen")
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: George Dunlap <George.Dunlap@eu.citrix.com>
CC: Ian Jackson <iwj@xenproject.org>
CC: Jan Beulich <JBeulich@suse.com>
CC: Stefano Stabellini <sstabellini@kernel.org>
CC: Wei Liu <wl@xen.org>
CC: Julien Grall <julien@xen.org>
CC: Paul Durrant <paul@xen.org>
---
 xen/common/ioreq.c    | 16 ++++++++++------
 xen/common/vsprintf.c | 11 ++++++-----
 xen/include/xen/lib.h |  4 ++--
 3 files changed, 18 insertions(+), 13 deletions(-)

diff --git a/xen/common/ioreq.c b/xen/common/ioreq.c
index 689d256544c8..5c94e74293ce 100644
--- a/xen/common/ioreq.c
+++ b/xen/common/ioreq.c
@@ -501,13 +501,17 @@ static int ioreq_server_alloc_rangesets(struct ioreq_server *s,
 
     for ( i = 0; i < NR_IO_RANGE_TYPES; i++ )
     {
-        char *name;
+        char *name, *type;
 
-        rc = asprintf(&name, "ioreq_server %d %s", id,
-                      (i == XEN_DMOP_IO_RANGE_PORT) ? "port" :
-                      (i == XEN_DMOP_IO_RANGE_MEMORY) ? "memory" :
-                      (i == XEN_DMOP_IO_RANGE_PCI) ? "pci" :
-                      "");
+        switch ( i )
+        {
+        case XEN_DMOP_IO_RANGE_PORT:   type = " port";   break;
+        case XEN_DMOP_IO_RANGE_MEMORY: type = " memory"; break;
+        case XEN_DMOP_IO_RANGE_PCI:    type = " pci";    break;
+        default:                       type = "";        break;
+        }
+
+        rc = xasprintf(&name, "ioreq_server %d%s", id, type);
         if ( rc )
             goto fail;
 
diff --git a/xen/common/vsprintf.c b/xen/common/vsprintf.c
index 185a4bd5610a..b278961cc387 100644
--- a/xen/common/vsprintf.c
+++ b/xen/common/vsprintf.c
@@ -859,7 +859,7 @@ int scnprintf(char * buf, size_t size, const char *fmt, ...)
 EXPORT_SYMBOL(scnprintf);
 
 /**
- * vasprintf - Format a string and allocate a buffer to place it in
+ * xvasprintf - Format a string and allocate a buffer to place it in
  *
  * @bufp: Pointer to a pointer to receive the allocated buffer
  * @fmt: The format string to use
@@ -870,7 +870,7 @@ EXPORT_SYMBOL(scnprintf);
  * guaranteed to be null terminated. The memory is allocated
  * from xenheap, so the buffer should be freed with xfree().
  */
-int vasprintf(char **bufp, const char *fmt, va_list args)
+int xvasprintf(char **bufp, const char *fmt, va_list args)
 {
     va_list args_copy;
     size_t size;
@@ -891,7 +891,7 @@ int vasprintf(char **bufp, const char *fmt, va_list args)
 }
 
 /**
- * asprintf - Format a string and place it in a buffer
+ * xasprintf - Format a string and place it in a buffer
  * @bufp: Pointer to a pointer to receive the allocated buffer
  * @fmt: The format string to use
  * @...: Arguments for the format string
@@ -901,14 +901,15 @@ int vasprintf(char **bufp, const char *fmt, va_list args)
  * guaranteed to be null terminated. The memory is allocated
  * from xenheap, so the buffer should be freed with xfree().
  */
-int asprintf(char **bufp, const char *fmt, ...)
+int xasprintf(char **bufp, const char *fmt, ...)
 {
     va_list args;
     int i;
 
     va_start(args, fmt);
-    i=vasprintf(bufp,fmt,args);
+    i = xvasprintf(bufp, fmt, args);
     va_end(args);
+
     return i;
 }
 
diff --git a/xen/include/xen/lib.h b/xen/include/xen/lib.h
index c6987973bf88..aea60d292724 100644
--- a/xen/include/xen/lib.h
+++ b/xen/include/xen/lib.h
@@ -158,9 +158,9 @@ extern int scnprintf(char * buf, size_t size, const char * fmt, ...)
     __attribute__ ((format (printf, 3, 4)));
 extern int vscnprintf(char *buf, size_t size, const char *fmt, va_list args)
     __attribute__ ((format (printf, 3, 0)));
-extern int asprintf(char ** bufp, const char * fmt, ...)
+extern int xasprintf(char **bufp, const char *fmt, ...)
     __attribute__ ((format (printf, 2, 3)));
-extern int vasprintf(char ** bufp, const char * fmt, va_list args)
+extern int xvasprintf(char **bufp, const char *fmt, va_list args)
     __attribute__ ((format (printf, 2, 0)));
 
 long simple_strtol(
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 21 10:22:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 21 Feb 2022 10:22:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275991.472047 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM5pt-0005OH-Ug; Mon, 21 Feb 2022 10:22:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275991.472047; Mon, 21 Feb 2022 10:22:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM5pt-0005NJ-Nz; Mon, 21 Feb 2022 10:22:29 +0000
Received: by outflank-mailman (input) for mailman id 275991;
 Mon, 21 Feb 2022 10:22:28 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nM5ps-0005Ck-8L
 for xen-devel@lists.xenproject.org; Mon, 21 Feb 2022 10:22:28 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nM5pr-0002BM-W9; Mon, 21 Feb 2022 10:22:27 +0000
Received: from 54-240-197-232.amazon.com ([54.240.197.232]
 helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com)
 by xenbits.xenproject.org with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nM5pr-00070b-Oo; Mon, 21 Feb 2022 10:22:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References:
	In-Reply-To:Message-Id:Date:Subject:Cc:To:From;
	bh=sFYaVlLq15N1H/anRoXOtrE4yZfgYVYOPXSH6aKnS1c=; b=JwDq/w/csOKozdfgbxUMXi5DOG
	qsRCDVP8kNgM0ZZY1v42hOsAJxCK80gkaDYUgzlchR7Rc/WvhTL1k2Jdx7nr0560Xgq77Y0m07bpk
	92KNHKUdvP9o5WBxr+I/Cm8y5ltfFvdcHHiPgG5ekHlD+0wtfmEZ9JgIeiuAKqyaO+lU=;
From: Julien Grall <julien@xen.org>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	Julien Grall <jgrall@amazon.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH v3 05/19] xen/arm: mm: Add support for the contiguous bit
Date: Mon, 21 Feb 2022 10:22:04 +0000
Message-Id: <20220221102218.33785-6-julien@xen.org>
X-Mailer: git-send-email 2.32.0
In-Reply-To: <20220221102218.33785-1-julien@xen.org>
References: <20220221102218.33785-1-julien@xen.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Julien Grall <jgrall@amazon.com>

In follow-up patches, we will use xen_pt_update() (or its callers)
to handle large mappings (e.g. frametable, xenheap). They are also
not going to be modified once created.

The page-table entries have an hint to indicate that whether an
entry is contiguous to another 16 entries (assuming 4KB). When the
processor support the hint, one TLB entry will be created per
contiguous region.

For now this is tied to _PAGE_BLOCK. We can untie it in the future
if there are use-cases where we may want to use _PAGE_BLOCK without
setting the contiguous (couldn't think of any yet).

Note that to avoid extra complexity, mappings with the contiguous
bit set cannot be removed. Given the expected use, this restriction
ought to be fine.

Signed-off-by: Julien Grall <jgrall@amazon.com>

---
    Changes in v3:
        - New patch
---
 xen/arch/arm/include/asm/page.h |  4 ++
 xen/arch/arm/mm.c               | 80 ++++++++++++++++++++++++++++++---
 2 files changed, 77 insertions(+), 7 deletions(-)

diff --git a/xen/arch/arm/include/asm/page.h b/xen/arch/arm/include/asm/page.h
index 07998df47bac..e7cd62190c7f 100644
--- a/xen/arch/arm/include/asm/page.h
+++ b/xen/arch/arm/include/asm/page.h
@@ -70,6 +70,7 @@
  * [5]   Page present
  * [6]   Only populate page tables
  * [7]   Superpage mappings is allowed
+ * [8]   Set contiguous bit (internal flag)
  */
 #define PAGE_AI_MASK(x) ((x) & 0x7U)
 
@@ -86,6 +87,9 @@
 #define _PAGE_BLOCK_BIT     7
 #define _PAGE_BLOCK         (1U << _PAGE_BLOCK_BIT)
 
+#define _PAGE_CONTIG_BIT    8
+#define _PAGE_CONTIG        (1U << _PAGE_CONTIG_BIT)
+
 /*
  * _PAGE_DEVICE and _PAGE_NORMAL are convenience defines. They are not
  * meant to be used outside of this header.
diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
index 3af69b396bd1..fd16c1541ce2 100644
--- a/xen/arch/arm/mm.c
+++ b/xen/arch/arm/mm.c
@@ -1237,6 +1237,8 @@ static int xen_pt_update_entry(mfn_t root, unsigned long virt,
         /* Set permission */
         pte.pt.ro = PAGE_RO_MASK(flags);
         pte.pt.xn = PAGE_XN_MASK(flags);
+        /* Set contiguous bit */
+        pte.pt.contig = !!(flags & _PAGE_CONTIG);
     }
 
     write_pte(entry, pte);
@@ -1289,6 +1291,51 @@ static int xen_pt_mapping_level(unsigned long vfn, mfn_t mfn, unsigned long nr,
      return level;
 }
 
+#define XEN_PT_4K_NR_CONTIG 16
+
+/*
+ * Check whether the contiguous bit can be set. Return the number of
+ * contiguous entry allowed. If not allowed, return 1.
+ */
+static unsigned int xen_pt_check_contig(unsigned long vfn, mfn_t mfn,
+                                        unsigned int level, unsigned long left,
+                                        unsigned int flags)
+{
+    unsigned long nr_contig;
+
+    /*
+     * Allow the contiguous bit to set when the caller requests block
+     * mapping.
+     */
+    if ( !(flags & _PAGE_BLOCK) )
+        return 1;
+
+    /*
+     * We don't allow to remove mapping with the contiguous bit set.
+     * So shortcut the logic and directly return 1.
+     */
+    if ( mfn_eq(mfn, INVALID_MFN) )
+        return 1;
+
+    /*
+     * The number of contiguous entries varies depending on the page
+     * granularity used. The logic below assumes 4KB.
+     */
+    BUILD_BUG_ON(PAGE_SIZE != SZ_4K);
+
+    /*
+     * In order to enable the contiguous bit, we should have enough entries
+     * to map left and both the virtual and physical address should be
+     * aligned to the size of 16 translation tables entries.
+     */
+    nr_contig = BIT(XEN_PT_LEVEL_ORDER(level), UL) * XEN_PT_4K_NR_CONTIG;
+
+    if ( (left < nr_contig) || ((mfn_x(mfn) | vfn) & (nr_contig - 1)) )
+        return 1;
+
+    return XEN_PT_4K_NR_CONTIG;
+}
+
 static DEFINE_SPINLOCK(xen_pt_lock);
 
 static int xen_pt_update(unsigned long virt,
@@ -1322,6 +1369,12 @@ static int xen_pt_update(unsigned long virt,
         return -EINVAL;
     }
 
+    if ( flags & _PAGE_CONTIG )
+    {
+        mm_printk("_PAGE_CONTIG is an internal only flag.\n");
+        return -EINVAL;
+    }
+
     if ( !IS_ALIGNED(virt, PAGE_SIZE) )
     {
         mm_printk("The virtual address is not aligned to the page-size.\n");
@@ -1333,21 +1386,34 @@ static int xen_pt_update(unsigned long virt,
     while ( left )
     {
         unsigned int order, level;
+        unsigned int nr_contig;
+        unsigned int new_flags;
 
         level = xen_pt_mapping_level(vfn, mfn, left, flags);
         order = XEN_PT_LEVEL_ORDER(level);
 
         ASSERT(left >= BIT(order, UL));
 
-        rc = xen_pt_update_entry(root, pfn_to_paddr(vfn), mfn, level, flags);
-        if ( rc )
-            break;
+        /*
+         * Check if we can set the contiguous mapping and update the
+         * flags accordingly.
+         */
+        nr_contig = xen_pt_check_contig(vfn, mfn, level, left, flags);
+        new_flags = flags | ((nr_contig > 1) ? _PAGE_CONTIG : 0);
 
-        vfn += 1U << order;
-        if ( !mfn_eq(mfn, INVALID_MFN) )
-            mfn = mfn_add(mfn, 1U << order);
+        for ( ; nr_contig > 0; nr_contig-- )
+        {
+            rc = xen_pt_update_entry(root, pfn_to_paddr(vfn), mfn, level,
+                                     new_flags);
+            if ( rc )
+                break;
 
-        left -= (1U << order);
+            vfn += 1U << order;
+            if ( !mfn_eq(mfn, INVALID_MFN) )
+                mfn = mfn_add(mfn, 1U << order);
+
+            left -= (1U << order);
+        }
     }
 
     /*
-- 
2.32.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 21 10:22:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 21 Feb 2022 10:22:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275987.472004 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM5pp-0004Hi-Jg; Mon, 21 Feb 2022 10:22:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275987.472004; Mon, 21 Feb 2022 10:22:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM5pp-0004HM-Bt; Mon, 21 Feb 2022 10:22:25 +0000
Received: by outflank-mailman (input) for mailman id 275987;
 Mon, 21 Feb 2022 10:22:24 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nM5po-0004FP-7v
 for xen-devel@lists.xenproject.org; Mon, 21 Feb 2022 10:22:24 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nM5pn-0002AY-Ua; Mon, 21 Feb 2022 10:22:23 +0000
Received: from 54-240-197-232.amazon.com ([54.240.197.232]
 helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com)
 by xenbits.xenproject.org with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nM5pn-00070b-MY; Mon, 21 Feb 2022 10:22:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References:
	In-Reply-To:Message-Id:Date:Subject:Cc:To:From;
	bh=ACRkY4KhzmsVNHMcOkXHEpsxlBF8BKtVgEaQlfg0BNc=; b=55WepRFLg0bmiSYJclRhlTge7D
	MgBe3sFdk4LNDN/N9g7c556hnZI3Swp9dkMRo3B6xkB/Emt9NTSaqapqaom6QGkTgsUZkTHJbFzK2
	0x82I94h1yvGUi5rZBoFHXrQhllYxh0iLFsPkuLsl+fNvtPJo7InySh5mOOiucG0vl+U=;
From: Julien Grall <julien@xen.org>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	Julien Grall <jgrall@amazon.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH v3 01/19] xen/arm: lpae: Rename LPAE_ENTRIES_MASK_GS to LPAE_ENTRY_MASK_GS
Date: Mon, 21 Feb 2022 10:22:00 +0000
Message-Id: <20220221102218.33785-2-julien@xen.org>
X-Mailer: git-send-email 2.32.0
In-Reply-To: <20220221102218.33785-1-julien@xen.org>
References: <20220221102218.33785-1-julien@xen.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Julien Grall <jgrall@amazon.com>

Commit 05031fa87357 "xen/arm: guest_walk: Only generate necessary
offsets/masks" introduced LPAE_ENTRIES_MASK_GS. In a follow-up patch,
we will use it for to define LPAE_ENTRY_MASK.

This will lead to inconsistent naming. As LPAE_ENTRY_MASK is used in
many places, it is better to rename LPAE_ENTRIES_MASK_GS and avoid
some churn.

So rename LPAE_ENTRIES_MASK_GS to LPAE_ENTRY_MASK_GS.

Signed-off-by: Julien Grall <jgrall@amazon.com>

---
    Changes in v2:
        - New patch
---
 xen/arch/arm/include/asm/lpae.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/xen/arch/arm/include/asm/lpae.h b/xen/arch/arm/include/asm/lpae.h
index e94de2e7d8e8..4fb9a40a4ca9 100644
--- a/xen/arch/arm/include/asm/lpae.h
+++ b/xen/arch/arm/include/asm/lpae.h
@@ -180,7 +180,7 @@ static inline bool lpae_is_superpage(lpae_t pte, unsigned int level)
  */
 #define LPAE_SHIFT_GS(gs)         ((gs) - 3)
 #define LPAE_ENTRIES_GS(gs)       (_AC(1, U) << LPAE_SHIFT_GS(gs))
-#define LPAE_ENTRIES_MASK_GS(gs)  (LPAE_ENTRIES_GS(gs) - 1)
+#define LPAE_ENTRY_MASK_GS(gs)  (LPAE_ENTRIES_GS(gs) - 1)
 
 #define LEVEL_ORDER_GS(gs, lvl)   ((3 - (lvl)) * LPAE_SHIFT_GS(gs))
 #define LEVEL_SHIFT_GS(gs, lvl)   (LEVEL_ORDER_GS(gs, lvl) + (gs))
@@ -188,7 +188,7 @@ static inline bool lpae_is_superpage(lpae_t pte, unsigned int level)
 
 /* Offset in the table at level 'lvl' */
 #define LPAE_TABLE_INDEX_GS(gs, lvl, addr)   \
-    (((addr) >> LEVEL_SHIFT_GS(gs, lvl)) & LPAE_ENTRIES_MASK_GS(gs))
+    (((addr) >> LEVEL_SHIFT_GS(gs, lvl)) & LPAE_ENTRY_MASK_GS(gs))
 
 /* Generate an array @var containing the offset for each level from @addr */
 #define DECLARE_OFFSETS(var, addr)          \
-- 
2.32.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 21 10:22:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 21 Feb 2022 10:22:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275989.472025 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM5pr-0004ny-Az; Mon, 21 Feb 2022 10:22:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275989.472025; Mon, 21 Feb 2022 10:22:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM5pr-0004nL-2Z; Mon, 21 Feb 2022 10:22:27 +0000
Received: by outflank-mailman (input) for mailman id 275989;
 Mon, 21 Feb 2022 10:22:26 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nM5pq-0004cB-3l
 for xen-devel@lists.xenproject.org; Mon, 21 Feb 2022 10:22:26 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nM5pp-0002Ay-VE; Mon, 21 Feb 2022 10:22:25 +0000
Received: from 54-240-197-232.amazon.com ([54.240.197.232]
 helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com)
 by xenbits.xenproject.org with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nM5pp-00070b-Nh; Mon, 21 Feb 2022 10:22:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References:
	In-Reply-To:Message-Id:Date:Subject:Cc:To:From;
	bh=MXWuUJ4Gmt9SmtDQvOOz1c2o08azUVVOAJUW5p8Yymw=; b=QLO96n1xIu6/SHSb3SXM+I+P6F
	52Xx7khHqRnfeSkjkrvlruIRBxcGXkytgs7C0p+wVNyfG/mrykGKosZ780IoW9alQzdE2HJvn+77M
	e6Yd/5r9n2qbGkVTn32WCx+h3ojkIJ9ePXoZkNj9gefcCGHqDu2BfI/oIoItnyCICyIE=;
From: Julien Grall <julien@xen.org>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	Julien Grall <jgrall@amazon.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH v3 03/19] xen/arm: p2m: Replace level_{orders, masks} arrays with XEN_PT_LEVEL_{ORDER, MASK}
Date: Mon, 21 Feb 2022 10:22:02 +0000
Message-Id: <20220221102218.33785-4-julien@xen.org>
X-Mailer: git-send-email 2.32.0
In-Reply-To: <20220221102218.33785-1-julien@xen.org>
References: <20220221102218.33785-1-julien@xen.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Julien Grall <jgrall@amazon.com>

The array level_orders and level_masks can be replaced with the
recently introduced macros LEVEL_ORDER and LEVEL_MASK.

Signed-off-by: Julien Grall <jgrall@amazon.com>

---
    Changes in v3:
        - Fix clashes after prefixing the PT macros with XEN_PT_

    Changes in v2:
        - New patch

    The goal is to remove completely the static arrays so they
    don't need to be global (or duplicated) when adding superpage
    support for Xen PT.

    This also has the added benefits to replace a couple of loads
    with only a few instructions working on immediate.
---
 xen/arch/arm/p2m.c | 17 ++++++-----------
 1 file changed, 6 insertions(+), 11 deletions(-)

diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
index 493a1e25879a..1d1059f7d2bd 100644
--- a/xen/arch/arm/p2m.c
+++ b/xen/arch/arm/p2m.c
@@ -37,12 +37,6 @@ static unsigned int __read_mostly max_vmid = MAX_VMID_8_BIT;
  */
 unsigned int __read_mostly p2m_ipa_bits = 64;
 
-/* Helpers to lookup the properties of each level */
-static const paddr_t level_masks[] =
-    { ZEROETH_MASK, FIRST_MASK, SECOND_MASK, THIRD_MASK };
-static const uint8_t level_orders[] =
-    { ZEROETH_ORDER, FIRST_ORDER, SECOND_ORDER, THIRD_ORDER };
-
 static mfn_t __read_mostly empty_root_mfn;
 
 static uint64_t generate_vttbr(uint16_t vmid, mfn_t root_mfn)
@@ -233,7 +227,7 @@ static lpae_t *p2m_get_root_pointer(struct p2m_domain *p2m,
      * we can't use (P2M_ROOT_LEVEL - 1) because the root level might be
      * 0. Yet we still want to check if all the unused bits are zeroed.
      */
-    root_table = gfn_x(gfn) >> (level_orders[P2M_ROOT_LEVEL] +
+    root_table = gfn_x(gfn) >> (XEN_PT_LEVEL_ORDER(P2M_ROOT_LEVEL) +
                                 XEN_PT_LPAE_SHIFT);
     if ( root_table >= P2M_ROOT_PAGES )
         return NULL;
@@ -380,7 +374,7 @@ mfn_t p2m_get_entry(struct p2m_domain *p2m, gfn_t gfn,
     if ( gfn_x(gfn) > gfn_x(p2m->max_mapped_gfn) )
     {
         for ( level = P2M_ROOT_LEVEL; level < 3; level++ )
-            if ( (gfn_x(gfn) & (level_masks[level] >> PAGE_SHIFT)) >
+            if ( (gfn_x(gfn) & (XEN_PT_LEVEL_MASK(level) >> PAGE_SHIFT)) >
                  gfn_x(p2m->max_mapped_gfn) )
                 break;
 
@@ -423,7 +417,8 @@ mfn_t p2m_get_entry(struct p2m_domain *p2m, gfn_t gfn,
          * The entry may point to a superpage. Find the MFN associated
          * to the GFN.
          */
-        mfn = mfn_add(mfn, gfn_x(gfn) & ((1UL << level_orders[level]) - 1));
+        mfn = mfn_add(mfn,
+                      gfn_x(gfn) & ((1UL << XEN_PT_LEVEL_ORDER(level)) - 1));
 
         if ( valid )
             *valid = lpae_is_valid(entry);
@@ -434,7 +429,7 @@ out_unmap:
 
 out:
     if ( page_order )
-        *page_order = level_orders[level];
+        *page_order = XEN_PT_LEVEL_ORDER(level);
 
     return mfn;
 }
@@ -808,7 +803,7 @@ static bool p2m_split_superpage(struct p2m_domain *p2m, lpae_t *entry,
     /* Convenience aliases */
     mfn_t mfn = lpae_get_mfn(*entry);
     unsigned int next_level = level + 1;
-    unsigned int level_order = level_orders[next_level];
+    unsigned int level_order = XEN_PT_LEVEL_ORDER(next_level);
 
     /*
      * This should only be called with target != level and the entry is
-- 
2.32.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 21 10:22:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 21 Feb 2022 10:22:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275986.471998 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM5pp-0004Fc-7N; Mon, 21 Feb 2022 10:22:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275986.471998; Mon, 21 Feb 2022 10:22:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM5pp-0004FV-44; Mon, 21 Feb 2022 10:22:25 +0000
Received: by outflank-mailman (input) for mailman id 275986;
 Mon, 21 Feb 2022 10:22:23 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nM5pn-0004FJ-Lu
 for xen-devel@lists.xenproject.org; Mon, 21 Feb 2022 10:22:23 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nM5pn-0002AS-0I; Mon, 21 Feb 2022 10:22:23 +0000
Received: from 54-240-197-232.amazon.com ([54.240.197.232]
 helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com)
 by xenbits.xenproject.org with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nM5pm-00070b-NS; Mon, 21 Feb 2022 10:22:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:MIME-Version:
	Message-Id:Date:Subject:Cc:To:From;
	bh=4yA9Nr+hj5IU0/IE5qxpsEpm2+Op0kL5LsyBbZt/21Y=; b=wQ0vn/FgFMZs4XU85NDE+dCpUx
	wVoyzkWAzuEz78k23FqbvETjD+qdz2Py4qfxgnnONFpWKQs308YJV7RsY7HAt4mtVkxPNNSkm1K7X
	3uUJztNcz1Sw78ouUpfy+wJeevlvBUx6q8A33ZzRaREj9P3a1HdVGCm4Z1ahPe03WE9g=;
From: Julien Grall <julien@xen.org>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	Julien Grall <jgrall@amazon.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Wei Liu <wl@xen.org>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>
Subject: [PATCH v3 00/19] xen/arm: mm: Remove open-coding mappings
Date: Mon, 21 Feb 2022 10:21:59 +0000
Message-Id: <20220221102218.33785-1-julien@xen.org>
X-Mailer: git-send-email 2.32.0
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

From: Julien Grall <jgrall@amazon.com>

Hi all,

This series was originally sent as "xen/arm: mm: Add limited support
for superpages" [1] and finally has grown enough to remove most of
the open-coding mappings in the boot code.

This will help to:
    1) Get better compliance with the Arm memory model
    2) Pave the way to support other page size (64KB, 16KB)

The previous version was spent a few months ago. So I have decided
to remove all the acked-by/reviewed-by tags.

Cheers,

[1] <20201119190751.22345-1-julien@xen.org>
[2] <PA4PR08MB6253F49C13ED56811BA5B64E92479@PA4PR08MB6253.eurprd08.prod.outlook.com>

Julien Grall (18):
  xen/arm: lpae: Rename LPAE_ENTRIES_MASK_GS to LPAE_ENTRY_MASK_GS
  xen/arm: lpae: Use the generic helpers to defined the Xen PT helpers
  xen/arm: p2m: Replace level_{orders, masks} arrays with
    XEN_PT_LEVEL_{ORDER, MASK}
  xen/arm: mm: Allow other mapping size in xen_pt_update_entry()
  xen/arm: mm: Add support for the contiguous bit
  xen/arm: mm: Avoid flushing the TLBs when mapping are inserted
  xen/arm: mm: Don't open-code Xen PT update in remove_early_mappings()
  xen/arm: mm: Re-implement early_fdt_map() using map_pages_to_xen()
  xen/arm32: mm: Check if the virtual address is shared before updating
    it
  xen/arm32: mm: Re-implement setup_xenheap_mappings() using
    map_pages_to_xen()
  xen/arm: mm: Allocate xen page tables in domheap rather than xenheap
  xen/arm: mm: Allow page-table allocation from the boot allocator
  xen/arm: Move fixmap definitions in a separate header
  xen/arm: mm: Clean-up the includes and order them
  xen/arm: mm: Use the PMAP helpers in xen_{,un}map_table()
  xen/arm64: mm: Add memory to the boot allocator first
  xen/arm: mm: Rework setup_xenheap_mappings()
  xen/arm: mm: Re-implement setup_frame_table_mappings() with
    map_pages_to_xen()

Wei Liu (1):
  xen/arm: add Persistent Map (PMAP) infrastructure

 xen/arch/arm/Kconfig                    |   1 +
 xen/arch/arm/acpi/lib.c                 |   2 +
 xen/arch/arm/arm32/head.S               |  14 +-
 xen/arch/arm/arm64/head.S               |  14 +-
 xen/arch/arm/include/asm/config.h       |  10 +-
 xen/arch/arm/include/asm/early_printk.h |   1 +
 xen/arch/arm/include/asm/fixmap.h       |  41 ++
 xen/arch/arm/include/asm/lpae.h         |  85 ++--
 xen/arch/arm/include/asm/mm.h           |   4 -
 xen/arch/arm/include/asm/page.h         |   8 +
 xen/arch/arm/include/asm/pmap.h         |  33 ++
 xen/arch/arm/kernel.c                   |   1 +
 xen/arch/arm/mm.c                       | 530 +++++++++++++-----------
 xen/arch/arm/p2m.c                      |  28 +-
 xen/arch/arm/setup.c                    |  63 ++-
 xen/common/Kconfig                      |   3 +
 xen/common/Makefile                     |   1 +
 xen/common/pmap.c                       |  79 ++++
 xen/include/xen/acpi.h                  |  18 +-
 xen/include/xen/pmap.h                  |  16 +
 20 files changed, 613 insertions(+), 339 deletions(-)
 create mode 100644 xen/arch/arm/include/asm/fixmap.h
 create mode 100644 xen/arch/arm/include/asm/pmap.h
 create mode 100644 xen/common/pmap.c
 create mode 100644 xen/include/xen/pmap.h

-- 
2.32.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 21 10:22:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 21 Feb 2022 10:22:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275988.472020 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM5pq-0004lW-V3; Mon, 21 Feb 2022 10:22:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275988.472020; Mon, 21 Feb 2022 10:22:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM5pq-0004lL-QY; Mon, 21 Feb 2022 10:22:26 +0000
Received: by outflank-mailman (input) for mailman id 275988;
 Mon, 21 Feb 2022 10:22:25 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nM5pp-0004Fz-7X
 for xen-devel@lists.xenproject.org; Mon, 21 Feb 2022 10:22:25 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nM5pp-0002Am-04; Mon, 21 Feb 2022 10:22:25 +0000
Received: from 54-240-197-232.amazon.com ([54.240.197.232]
 helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com)
 by xenbits.xenproject.org with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nM5po-00070b-La; Mon, 21 Feb 2022 10:22:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References:
	In-Reply-To:Message-Id:Date:Subject:Cc:To:From;
	bh=kU4hAjZM1wdm5Xqt+UCg0gYAV4Ows97+OkKeN1riEcM=; b=ZRQT9wpIvJ8XngTAuCy2o98Zv9
	F1wRj4oruAZrLEbM/0UUOrDYR2UciO8hAf54JexWiiOk8mOWYwh3cZ7of4mIsgdTqpfOz+c9RfLi2
	arvH2hCu7ArcQQIOflrogwsYwsLDpv66HiawyWafsqv8lIbFtPNXaFE4D1SCU/655ewc=;
From: Julien Grall <julien@xen.org>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	Julien Grall <jgrall@amazon.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH v3 02/19] xen/arm: lpae: Use the generic helpers to defined the Xen PT helpers
Date: Mon, 21 Feb 2022 10:22:01 +0000
Message-Id: <20220221102218.33785-3-julien@xen.org>
X-Mailer: git-send-email 2.32.0
In-Reply-To: <20220221102218.33785-1-julien@xen.org>
References: <20220221102218.33785-1-julien@xen.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Julien Grall <jgrall@amazon.com>

Currently, Xen PT helpers are only working with 4KB page granularity
and open-code the generic helpers. To allow more flexibility, we can
re-use the generic helpers and pass Xen's page granularity
(PAGE_SHIFT).

As Xen PT helpers are used in both C and assembly, we need to move
the generic helpers definition outside of the !__ASSEMBLY__ section.

Take the opportunity to prefix LPAE_ENTRIES, LPAE_ENTRIES and
LPAE_ENTRIES_MASK with XEN_PT_.

Note the aliases for each level are still kept for the time being so we
can avoid a massive patch to change all the callers.

Signed-off-by: Julien Grall <jgrall@amazon.com>

---
    Changes in v3:
      - Prefix the new define with XEN_PT_

    Changes in v2:
        - New patch
---
 xen/arch/arm/arm32/head.S       | 14 +++----
 xen/arch/arm/arm64/head.S       | 14 +++----
 xen/arch/arm/include/asm/lpae.h | 73 ++++++++++++++++++---------------
 xen/arch/arm/mm.c               | 33 ++++++++-------
 xen/arch/arm/p2m.c              | 13 +++---
 5 files changed, 80 insertions(+), 67 deletions(-)

diff --git a/xen/arch/arm/arm32/head.S b/xen/arch/arm/arm32/head.S
index b5912d381b98..b1d209ea2842 100644
--- a/xen/arch/arm/arm32/head.S
+++ b/xen/arch/arm/arm32/head.S
@@ -375,7 +375,7 @@ ENDPROC(cpu_init)
  */
 .macro create_table_entry, ptbl, tbl, virt, shift, mmu=0
         lsr   r1, \virt, #\shift
-        mov_w r2, LPAE_ENTRY_MASK
+        mov_w r2, XEN_PT_LPAE_ENTRY_MASK
         and   r1, r1, r2             /* r1 := slot in \tlb */
         lsl   r1, r1, #3             /* r1 := slot offset in \tlb */
 
@@ -410,7 +410,7 @@ ENDPROC(cpu_init)
  * and be distinct.
  */
 .macro create_mapping_entry, ptbl, virt, phys, type=PT_MEM_L3, mmu=0
-        mov_w r2, LPAE_ENTRY_MASK
+        mov_w r2, XEN_PT_LPAE_ENTRY_MASK
         lsr   r1, \virt, #THIRD_SHIFT
         and   r1, r1, r2             /* r1 := slot in \tlb */
         lsl   r1, r1, #3             /* r1 := slot offset in \tlb */
@@ -465,7 +465,7 @@ create_page_tables:
 1:      strd  r2, r3, [r4, r1]       /* Map vaddr(start) */
         add   r2, r2, #PAGE_SIZE     /* Next page */
         add   r1, r1, #8             /* Next slot */
-        cmp   r1, #(LPAE_ENTRIES<<3) /* 512*8-byte entries per page */
+        cmp   r1, #(XEN_PT_LPAE_ENTRIES<<3) /* 512*8-byte entries per page */
         blo   1b
 
         /*
@@ -487,7 +487,7 @@ create_page_tables:
          * the second level.
          */
         lsr   r1, r9, #FIRST_SHIFT
-        mov_w r0, LPAE_ENTRY_MASK
+        mov_w r0, XEN_PT_LPAE_ENTRY_MASK
         and   r1, r1, r0              /* r1 := first slot */
         cmp   r1, #XEN_FIRST_SLOT
         beq   1f
@@ -502,7 +502,7 @@ create_page_tables:
          * it.
          */
         lsr   r1, r9, #SECOND_SHIFT
-        mov_w r0, LPAE_ENTRY_MASK
+        mov_w r0, XEN_PT_LPAE_ENTRY_MASK
         and   r1, r1, r0             /* r1 := second slot */
         cmp   r1, #XEN_SECOND_SLOT
         beq   virtphys_clash
@@ -573,7 +573,7 @@ remove_identity_mapping:
          * table if the slot is not XEN_FIRST_SLOT.
          */
         lsr   r1, r9, #FIRST_SHIFT
-        mov_w r0, LPAE_ENTRY_MASK
+        mov_w r0, XEN_PT_LPAE_ENTRY_MASK
         and   r1, r1, r0              /* r1 := first slot */
         cmp   r1, #XEN_FIRST_SLOT
         beq   1f
@@ -589,7 +589,7 @@ remove_identity_mapping:
          * table if the slot is not XEN_SECOND_SLOT.
          */
         lsr   r1, r9, #SECOND_SHIFT
-        mov_w r0, LPAE_ENTRY_MASK
+        mov_w r0, XEN_PT_LPAE_ENTRY_MASK
         and   r1, r1, r0             /* r1 := second slot */
         cmp   r1, #XEN_SECOND_SLOT
         beq   identity_mapping_removed
diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S
index 51b00ab0bea6..314b800b3f8e 100644
--- a/xen/arch/arm/arm64/head.S
+++ b/xen/arch/arm/arm64/head.S
@@ -509,7 +509,7 @@ ENDPROC(cpu_init)
  */
 .macro create_table_entry, ptbl, tbl, virt, shift, tmp1, tmp2, tmp3
         lsr   \tmp1, \virt, #\shift
-        and   \tmp1, \tmp1, #LPAE_ENTRY_MASK/* \tmp1 := slot in \tlb */
+        and   \tmp1, \tmp1, #XEN_PT_LPAE_ENTRY_MASK/* \tmp1 := slot in \tlb */
 
         load_paddr \tmp2, \tbl
         mov   \tmp3, #PT_PT                 /* \tmp3 := right for linear PT */
@@ -541,7 +541,7 @@ ENDPROC(cpu_init)
         and   \tmp3, \phys, #THIRD_MASK     /* \tmp3 := PAGE_ALIGNED(phys) */
 
         lsr   \tmp1, \virt, #THIRD_SHIFT
-        and   \tmp1, \tmp1, #LPAE_ENTRY_MASK/* \tmp1 := slot in \tlb */
+        and   \tmp1, \tmp1, #XEN_PT_LPAE_ENTRY_MASK/* \tmp1 := slot in \tlb */
 
         mov   \tmp2, #\type                 /* \tmp2 := right for section PT */
         orr   \tmp2, \tmp2, \tmp3           /*          + PAGE_ALIGNED(phys) */
@@ -586,7 +586,7 @@ create_page_tables:
 1:      str   x2, [x4, x1]           /* Map vaddr(start) */
         add   x2, x2, #PAGE_SIZE     /* Next page */
         add   x1, x1, #8             /* Next slot */
-        cmp   x1, #(LPAE_ENTRIES<<3) /* 512 entries per page */
+        cmp   x1, #(XEN_PT_LPAE_ENTRIES<<3) /* 512 entries per page */
         b.lt  1b
 
         /*
@@ -621,7 +621,7 @@ create_page_tables:
          * the second level.
          */
         lsr   x0, x19, #FIRST_SHIFT
-        and   x0, x0, #LPAE_ENTRY_MASK  /* x0 := first slot */
+        and   x0, x0, #XEN_PT_LPAE_ENTRY_MASK  /* x0 := first slot */
         cmp   x0, #XEN_FIRST_SLOT
         beq   1f
         create_table_entry boot_first, boot_second_id, x19, FIRST_SHIFT, x0, x1, x2
@@ -635,7 +635,7 @@ create_page_tables:
          * it.
          */
         lsr   x0, x19, #SECOND_SHIFT
-        and   x0, x0, #LPAE_ENTRY_MASK  /* x0 := first slot */
+        and   x0, x0, #XEN_PT_LPAE_ENTRY_MASK  /* x0 := first slot */
         cmp   x0, #XEN_SECOND_SLOT
         beq   virtphys_clash
         create_table_entry boot_second, boot_third_id, x19, SECOND_SHIFT, x0, x1, x2
@@ -715,7 +715,7 @@ remove_identity_mapping:
          * table if the slot is not XEN_FIRST_SLOT.
          */
         lsr   x1, x19, #FIRST_SHIFT
-        and   x1, x1, #LPAE_ENTRY_MASK  /* x1 := first slot */
+        and   x1, x1, #XEN_PT_LPAE_ENTRY_MASK  /* x1 := first slot */
         cmp   x1, #XEN_FIRST_SLOT
         beq   1f
         /* It is not in slot XEN_FIRST_SLOT, remove the entry. */
@@ -729,7 +729,7 @@ remove_identity_mapping:
          * table if the slot is not XEN_SECOND_SLOT.
          */
         lsr   x1, x19, #SECOND_SHIFT
-        and   x1, x1, #LPAE_ENTRY_MASK  /* x1 := first slot */
+        and   x1, x1, #XEN_PT_LPAE_ENTRY_MASK  /* x1 := first slot */
         cmp   x1, #XEN_SECOND_SLOT
         beq   identity_mapping_removed
         /* It is not in slot 1, remove the entry */
diff --git a/xen/arch/arm/include/asm/lpae.h b/xen/arch/arm/include/asm/lpae.h
index 4fb9a40a4ca9..8cf932b5c947 100644
--- a/xen/arch/arm/include/asm/lpae.h
+++ b/xen/arch/arm/include/asm/lpae.h
@@ -159,6 +159,17 @@ static inline bool lpae_is_superpage(lpae_t pte, unsigned int level)
 #define lpae_get_mfn(pte)    (_mfn((pte).walk.base))
 #define lpae_set_mfn(pte, mfn)  ((pte).walk.base = mfn_x(mfn))
 
+/* Generate an array @var containing the offset for each level from @addr */
+#define DECLARE_OFFSETS(var, addr)          \
+    const unsigned int var[4] = {           \
+        zeroeth_table_offset(addr),         \
+        first_table_offset(addr),           \
+        second_table_offset(addr),          \
+        third_table_offset(addr)            \
+    }
+
+#endif /* __ASSEMBLY__ */
+
 /*
  * AArch64 supports pages with different sizes (4K, 16K, and 64K).
  * Provide a set of generic helpers that will compute various
@@ -190,17 +201,6 @@ static inline bool lpae_is_superpage(lpae_t pte, unsigned int level)
 #define LPAE_TABLE_INDEX_GS(gs, lvl, addr)   \
     (((addr) >> LEVEL_SHIFT_GS(gs, lvl)) & LPAE_ENTRY_MASK_GS(gs))
 
-/* Generate an array @var containing the offset for each level from @addr */
-#define DECLARE_OFFSETS(var, addr)          \
-    const unsigned int var[4] = {           \
-        zeroeth_table_offset(addr),         \
-        first_table_offset(addr),           \
-        second_table_offset(addr),          \
-        third_table_offset(addr)            \
-    }
-
-#endif /* __ASSEMBLY__ */
-
 /*
  * These numbers add up to a 48-bit input address space.
  *
@@ -211,26 +211,35 @@ static inline bool lpae_is_superpage(lpae_t pte, unsigned int level)
  * therefore 39-bits are sufficient.
  */
 
-#define LPAE_SHIFT      9
-#define LPAE_ENTRIES    (_AC(1,U) << LPAE_SHIFT)
-#define LPAE_ENTRY_MASK (LPAE_ENTRIES - 1)
-
-#define THIRD_SHIFT    (PAGE_SHIFT)
-#define THIRD_ORDER    (THIRD_SHIFT - PAGE_SHIFT)
-#define THIRD_SIZE     (_AT(paddr_t, 1) << THIRD_SHIFT)
-#define THIRD_MASK     (~(THIRD_SIZE - 1))
-#define SECOND_SHIFT   (THIRD_SHIFT + LPAE_SHIFT)
-#define SECOND_ORDER   (SECOND_SHIFT - PAGE_SHIFT)
-#define SECOND_SIZE    (_AT(paddr_t, 1) << SECOND_SHIFT)
-#define SECOND_MASK    (~(SECOND_SIZE - 1))
-#define FIRST_SHIFT    (SECOND_SHIFT + LPAE_SHIFT)
-#define FIRST_ORDER    (FIRST_SHIFT - PAGE_SHIFT)
-#define FIRST_SIZE     (_AT(paddr_t, 1) << FIRST_SHIFT)
-#define FIRST_MASK     (~(FIRST_SIZE - 1))
-#define ZEROETH_SHIFT  (FIRST_SHIFT + LPAE_SHIFT)
-#define ZEROETH_ORDER  (ZEROETH_SHIFT - PAGE_SHIFT)
-#define ZEROETH_SIZE   (_AT(paddr_t, 1) << ZEROETH_SHIFT)
-#define ZEROETH_MASK   (~(ZEROETH_SIZE - 1))
+#define XEN_PT_LPAE_SHIFT         LPAE_SHIFT_GS(PAGE_SHIFT)
+#define XEN_PT_LPAE_ENTRIES       LPAE_ENTRIES_GS(PAGE_SHIFT)
+#define XEN_PT_LPAE_ENTRY_MASK    LPAE_ENTRY_MASK_GS(PAGE_SHIFT)
+
+#define XEN_PT_LEVEL_SHIFT(lvl)   LEVEL_SHIFT_GS(PAGE_SHIFT, lvl)
+#define XEN_PT_LEVEL_ORDER(lvl)   LEVEL_ORDER_GS(PAGE_SHIFT, lvl)
+#define XEN_PT_LEVEL_SIZE(lvl)    LEVEL_SIZE_GS(PAGE_SHIFT, lvl)
+#define XEN_PT_LEVEL_MASK(lvl)    (~(XEN_PT_LEVEL_SIZE(lvl) - 1))
+
+/* Convenience aliases */
+#define THIRD_SHIFT         XEN_PT_LEVEL_SHIFT(3)
+#define THIRD_ORDER         XEN_PT_LEVEL_ORDER(3)
+#define THIRD_SIZE          XEN_PT_LEVEL_SIZE(3)
+#define THIRD_MASK          XEN_PT_LEVEL_MASK(3)
+
+#define SECOND_SHIFT        XEN_PT_LEVEL_SHIFT(2)
+#define SECOND_ORDER        XEN_PT_LEVEL_ORDER(2)
+#define SECOND_SIZE         XEN_PT_LEVEL_SIZE(2)
+#define SECOND_MASK         XEN_PT_LEVEL_MASK(2)
+
+#define FIRST_SHIFT         XEN_PT_LEVEL_SHIFT(1)
+#define FIRST_ORDER         XEN_PT_LEVEL_ORDER(1)
+#define FIRST_SIZE          XEN_PT_LEVEL_SIZE(1)
+#define FIRST_MASK          XEN_PT_LEVEL_MASK(1)
+
+#define ZEROETH_SHIFT       XEN_PT_LEVEL_SHIFT(0)
+#define ZEROETH_ORDER       XEN_PT_LEVEL_ORDER(0)
+#define ZEROETH_SIZE        XEN_PT_LEVEL_SIZE(0)
+#define ZEROETH_MASK        XEN_PT_LEVEL_MASK(0)
 
 /* Calculate the offsets into the pagetables for a given VA */
 #define zeroeth_linear_offset(va) ((va) >> ZEROETH_SHIFT)
@@ -238,7 +247,7 @@ static inline bool lpae_is_superpage(lpae_t pte, unsigned int level)
 #define second_linear_offset(va) ((va) >> SECOND_SHIFT)
 #define third_linear_offset(va) ((va) >> THIRD_SHIFT)
 
-#define TABLE_OFFSET(offs) (_AT(unsigned int, offs) & LPAE_ENTRY_MASK)
+#define TABLE_OFFSET(offs) (_AT(unsigned int, offs) & XEN_PT_LPAE_ENTRY_MASK)
 #define first_table_offset(va)  TABLE_OFFSET(first_linear_offset(va))
 #define second_table_offset(va) TABLE_OFFSET(second_linear_offset(va))
 #define third_table_offset(va)  TABLE_OFFSET(third_linear_offset(va))
diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
index b1eae767c27c..515d0906f85b 100644
--- a/xen/arch/arm/mm.c
+++ b/xen/arch/arm/mm.c
@@ -71,10 +71,11 @@ mm_printk(const char *fmt, ...) {}
  *  in C).
  */
 #define DEFINE_BOOT_PAGE_TABLE(name)                                          \
-lpae_t __aligned(PAGE_SIZE) __section(".data.page_aligned") name[LPAE_ENTRIES]
+lpae_t __aligned(PAGE_SIZE) __section(".data.page_aligned")                   \
+    name[XEN_PT_LPAE_ENTRIES]
 
 #define DEFINE_PAGE_TABLES(name, nr)                    \
-lpae_t __aligned(PAGE_SIZE) name[LPAE_ENTRIES * (nr)]
+lpae_t __aligned(PAGE_SIZE) name[XEN_PT_LPAE_ENTRIES * (nr)]
 
 #define DEFINE_PAGE_TABLE(name) DEFINE_PAGE_TABLES(name, 1)
 
@@ -207,7 +208,7 @@ static void __init __maybe_unused build_assertions(void)
     BUILD_BUG_ON(zeroeth_table_offset(XEN_VIRT_START));
 #endif
     BUILD_BUG_ON(first_table_offset(XEN_VIRT_START));
-    BUILD_BUG_ON(second_linear_offset(XEN_VIRT_START) >= LPAE_ENTRIES);
+    BUILD_BUG_ON(second_linear_offset(XEN_VIRT_START) >= XEN_PT_LPAE_ENTRIES);
 #ifdef CONFIG_DOMAIN_PAGE
     BUILD_BUG_ON(DOMHEAP_VIRT_START & ~FIRST_MASK);
 #endif
@@ -256,7 +257,7 @@ void dump_pt_walk(paddr_t ttbr, paddr_t addr,
 
     for ( level = root_level; ; level++ )
     {
-        if ( offsets[level] > LPAE_ENTRIES )
+        if ( offsets[level] > XEN_PT_LPAE_ENTRIES )
             break;
 
         pte = mapping[offsets[level]];
@@ -395,15 +396,15 @@ static void __init create_mappings(lpae_t *second,
     ASSERT(!(base_mfn % granularity));
     ASSERT(!(nr_mfns % granularity));
 
-    count = nr_mfns / LPAE_ENTRIES;
+    count = nr_mfns / XEN_PT_LPAE_ENTRIES;
     p = second + second_linear_offset(virt_offset);
     pte = mfn_to_xen_entry(_mfn(base_mfn), MT_NORMAL);
-    if ( granularity == 16 * LPAE_ENTRIES )
+    if ( granularity == 16 * XEN_PT_LPAE_ENTRIES )
         pte.pt.contig = 1;  /* These maps are in 16-entry contiguous chunks. */
     for ( i = 0; i < count; i++ )
     {
         write_pte(p + i, pte);
-        pte.pt.base += 1 << LPAE_SHIFT;
+        pte.pt.base += 1 << XEN_PT_LPAE_SHIFT;
     }
     flush_xen_tlb_local();
 }
@@ -424,7 +425,7 @@ void *map_domain_page(mfn_t mfn)
 {
     unsigned long flags;
     lpae_t *map = this_cpu(xen_dommap);
-    unsigned long slot_mfn = mfn_x(mfn) & ~LPAE_ENTRY_MASK;
+    unsigned long slot_mfn = mfn_x(mfn) & ~XEN_PT_LPAE_ENTRY_MASK;
     vaddr_t va;
     lpae_t pte;
     int i, slot;
@@ -435,7 +436,7 @@ void *map_domain_page(mfn_t mfn)
      * entry is a 2MB superpage pte.  We use the available bits of each
      * PTE as a reference count; when the refcount is zero the slot can
      * be reused. */
-    for ( slot = (slot_mfn >> LPAE_SHIFT) % DOMHEAP_ENTRIES, i = 0;
+    for ( slot = (slot_mfn >> XEN_PT_LPAE_SHIFT) % DOMHEAP_ENTRIES, i = 0;
           i < DOMHEAP_ENTRIES;
           slot = (slot + 1) % DOMHEAP_ENTRIES, i++ )
     {
@@ -477,7 +478,7 @@ void *map_domain_page(mfn_t mfn)
 
     va = (DOMHEAP_VIRT_START
           + (slot << SECOND_SHIFT)
-          + ((mfn_x(mfn) & LPAE_ENTRY_MASK) << THIRD_SHIFT));
+          + ((mfn_x(mfn) & XEN_PT_LPAE_ENTRY_MASK) << THIRD_SHIFT));
 
     /*
      * We may not have flushed this specific subpage at map time,
@@ -513,7 +514,7 @@ mfn_t domain_page_map_to_mfn(const void *ptr)
     unsigned long va = (unsigned long)ptr;
     lpae_t *map = this_cpu(xen_dommap);
     int slot = (va - DOMHEAP_VIRT_START) >> SECOND_SHIFT;
-    unsigned long offset = (va>>THIRD_SHIFT) & LPAE_ENTRY_MASK;
+    unsigned long offset = (va>>THIRD_SHIFT) & XEN_PT_LPAE_ENTRY_MASK;
 
     if ( va >= VMAP_VIRT_START && va < VMAP_VIRT_END )
         return virt_to_mfn(va);
@@ -654,7 +655,8 @@ void __init setup_pagetables(unsigned long boot_phys_offset)
     /* Initialise first level entries, to point to second level entries */
     for ( i = 0; i < 2; i++)
     {
-        p[i] = pte_of_xenaddr((uintptr_t)(xen_second+i*LPAE_ENTRIES));
+        p[i] = pte_of_xenaddr((uintptr_t)(xen_second +
+                                          i * XEN_PT_LPAE_ENTRIES));
         p[i].pt.table = 1;
         p[i].pt.xn = 0;
     }
@@ -663,13 +665,14 @@ void __init setup_pagetables(unsigned long boot_phys_offset)
     for ( i = 0; i < DOMHEAP_SECOND_PAGES; i++ )
     {
         p[first_table_offset(DOMHEAP_VIRT_START+i*FIRST_SIZE)]
-            = pte_of_xenaddr((uintptr_t)(cpu0_dommap+i*LPAE_ENTRIES));
+            = pte_of_xenaddr((uintptr_t)(cpu0_dommap +
+                                         i * XEN_PT_LPAE_ENTRIES));
         p[first_table_offset(DOMHEAP_VIRT_START+i*FIRST_SIZE)].pt.table = 1;
     }
 #endif
 
     /* Break up the Xen mapping into 4k pages and protect them separately. */
-    for ( i = 0; i < LPAE_ENTRIES; i++ )
+    for ( i = 0; i < XEN_PT_LPAE_ENTRIES; i++ )
     {
         vaddr_t va = XEN_VIRT_START + (i << PAGE_SHIFT);
 
@@ -768,7 +771,7 @@ int init_secondary_pagetables(int cpu)
      * domheap mapping pages. */
     for ( i = 0; i < DOMHEAP_SECOND_PAGES; i++ )
     {
-        pte = mfn_to_xen_entry(virt_to_mfn(domheap+i*LPAE_ENTRIES),
+        pte = mfn_to_xen_entry(virt_to_mfn(domheap + i * XEN_PT_LPAE_ENTRIES),
                                MT_NORMAL);
         pte.pt.table = 1;
         write_pte(&first[first_table_offset(DOMHEAP_VIRT_START+i*FIRST_SIZE)], pte);
diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
index 02cf852d4cf1..493a1e25879a 100644
--- a/xen/arch/arm/p2m.c
+++ b/xen/arch/arm/p2m.c
@@ -233,7 +233,8 @@ static lpae_t *p2m_get_root_pointer(struct p2m_domain *p2m,
      * we can't use (P2M_ROOT_LEVEL - 1) because the root level might be
      * 0. Yet we still want to check if all the unused bits are zeroed.
      */
-    root_table = gfn_x(gfn) >> (level_orders[P2M_ROOT_LEVEL] + LPAE_SHIFT);
+    root_table = gfn_x(gfn) >> (level_orders[P2M_ROOT_LEVEL] +
+                                XEN_PT_LPAE_SHIFT);
     if ( root_table >= P2M_ROOT_PAGES )
         return NULL;
 
@@ -773,7 +774,7 @@ static void p2m_free_entry(struct p2m_domain *p2m,
     }
 
     table = map_domain_page(lpae_get_mfn(entry));
-    for ( i = 0; i < LPAE_ENTRIES; i++ )
+    for ( i = 0; i < XEN_PT_LPAE_ENTRIES; i++ )
         p2m_free_entry(p2m, *(table + i), level + 1);
 
     unmap_domain_page(table);
@@ -827,7 +828,7 @@ static bool p2m_split_superpage(struct p2m_domain *p2m, lpae_t *entry,
      * We are either splitting a first level 1G page into 512 second level
      * 2M pages, or a second level 2M page into 512 third level 4K pages.
      */
-    for ( i = 0; i < LPAE_ENTRIES; i++ )
+    for ( i = 0; i < XEN_PT_LPAE_ENTRIES; i++ )
     {
         lpae_t *new_entry = table + i;
 
@@ -850,7 +851,7 @@ static bool p2m_split_superpage(struct p2m_domain *p2m, lpae_t *entry,
     /* Update stats */
     p2m->stats.shattered[level]++;
     p2m->stats.mappings[level]--;
-    p2m->stats.mappings[next_level] += LPAE_ENTRIES;
+    p2m->stats.mappings[next_level] += XEN_PT_LPAE_ENTRIES;
 
     /*
      * Shatter superpage in the page to the level we want to make the
@@ -888,7 +889,7 @@ static int __p2m_set_entry(struct p2m_domain *p2m,
                            p2m_access_t a)
 {
     unsigned int level = 0;
-    unsigned int target = 3 - (page_order / LPAE_SHIFT);
+    unsigned int target = 3 - (page_order / XEN_PT_LPAE_SHIFT);
     lpae_t *entry, *table, orig_pte;
     int rc;
     /* A mapping is removed if the MFN is invalid. */
@@ -1142,7 +1143,7 @@ static void p2m_invalidate_table(struct p2m_domain *p2m, mfn_t mfn)
 
     table = map_domain_page(mfn);
 
-    for ( i = 0; i < LPAE_ENTRIES; i++ )
+    for ( i = 0; i < XEN_PT_LPAE_ENTRIES; i++ )
     {
         lpae_t pte = table[i];
 
-- 
2.32.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 21 10:22:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 21 Feb 2022 10:22:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275990.472042 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM5pt-0005Kq-I8; Mon, 21 Feb 2022 10:22:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275990.472042; Mon, 21 Feb 2022 10:22:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM5pt-0005Kb-Dd; Mon, 21 Feb 2022 10:22:29 +0000
Received: by outflank-mailman (input) for mailman id 275990;
 Mon, 21 Feb 2022 10:22:27 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nM5pr-0004rs-Bw
 for xen-devel@lists.xenproject.org; Mon, 21 Feb 2022 10:22:27 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nM5pr-0002BA-0w; Mon, 21 Feb 2022 10:22:27 +0000
Received: from 54-240-197-232.amazon.com ([54.240.197.232]
 helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com)
 by xenbits.xenproject.org with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nM5pq-00070b-Po; Mon, 21 Feb 2022 10:22:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References:
	In-Reply-To:Message-Id:Date:Subject:Cc:To:From;
	bh=vdk2f2XtwtCP7lnk+xz6BHSsXzbsgK1tvinW1UcZ8Xk=; b=kTPb7leRM9W9uI0SYo3zFhRB0e
	gnsx/mIbEeV/OzvpYoziEfEMN3JIi6icJkolvf5BDgq9JZKzaA9+XdC73c6L/v5Wqvz/Rd+KNXYzl
	i1R+wWU9eySsU9kaTqxrJTPud6L7wgWnARfWjlpvvKJdbcUSTrgimeW21uqbsHliqny8=;
From: Julien Grall <julien@xen.org>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	Julien Grall <julien.grall@arm.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Julien Grall <jgrall@amazon.com>
Subject: [PATCH v3 04/19] xen/arm: mm: Allow other mapping size in xen_pt_update_entry()
Date: Mon, 21 Feb 2022 10:22:03 +0000
Message-Id: <20220221102218.33785-5-julien@xen.org>
X-Mailer: git-send-email 2.32.0
In-Reply-To: <20220221102218.33785-1-julien@xen.org>
References: <20220221102218.33785-1-julien@xen.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Julien Grall <julien.grall@arm.com>

At the moment, xen_pt_update_entry() only supports mapping at level 3
(i.e 4KB mapping). While this is fine for most of the runtime helper,
the boot code will require to use superpage mapping.

We don't want to allow superpage mapping by default as some of the
callers may expect small mappings (i.e populate_pt_range()) or even
expect to unmap only a part of a superpage.

To keep the code simple, a new flag _PAGE_BLOCK is introduced to
allow the caller to enable superpage mapping.

As the code doesn't support all the combinations, xen_pt_check_entry()
is extended to take into account the cases we don't support when
using block mapping:
    - Replacing a table with a mapping. This may happen if region was
    first mapped with 4KB mapping and then later on replaced with a 2MB
    (or 1GB mapping).
    - Removing/modifying a table. This may happen if a caller try to
    remove a region with _PAGE_BLOCK set when it was created without it.

Note that the current restriction means that the caller must ensure that
_PAGE_BLOCK is consistently set/cleared across all the updates on a
given virtual region. This ought to be fine with the expected use-cases.

More rework will be necessary if we wanted to remove the restrictions.

Note that nr_mfns is now marked const as it is used for flushing the
TLBs and we don't want it to be modified.

Signed-off-by: Julien Grall <julien.grall@arm.com>
Signed-off-by: Julien Grall <jgrall@amazon.com>

---
    Changes in v3:
        - Fix clash after prefixing the PT macros with XEN_PT_
        - Fix typoes in the commit message
        - Support superpage mappings even if nr is not suitably aligned
        - Move the logic to find the level in a separate function

    Changes in v2:
        - Pass the target level rather than the order to
        xen_pt_update_entry()
        - Update some comments
        - Open-code paddr_to_pfn()
        - Add my AWS signed-off-by
---
 xen/arch/arm/include/asm/page.h |   4 ++
 xen/arch/arm/mm.c               | 108 ++++++++++++++++++++++++++------
 2 files changed, 94 insertions(+), 18 deletions(-)

diff --git a/xen/arch/arm/include/asm/page.h b/xen/arch/arm/include/asm/page.h
index c6f9fb0d4e0c..07998df47bac 100644
--- a/xen/arch/arm/include/asm/page.h
+++ b/xen/arch/arm/include/asm/page.h
@@ -69,6 +69,7 @@
  * [3:4] Permission flags
  * [5]   Page present
  * [6]   Only populate page tables
+ * [7]   Superpage mappings is allowed
  */
 #define PAGE_AI_MASK(x) ((x) & 0x7U)
 
@@ -82,6 +83,9 @@
 #define _PAGE_PRESENT    (1U << 5)
 #define _PAGE_POPULATE   (1U << 6)
 
+#define _PAGE_BLOCK_BIT     7
+#define _PAGE_BLOCK         (1U << _PAGE_BLOCK_BIT)
+
 /*
  * _PAGE_DEVICE and _PAGE_NORMAL are convenience defines. They are not
  * meant to be used outside of this header.
diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
index 515d0906f85b..3af69b396bd1 100644
--- a/xen/arch/arm/mm.c
+++ b/xen/arch/arm/mm.c
@@ -1063,9 +1063,10 @@ static int xen_pt_next_level(bool read_only, unsigned int level,
 }
 
 /* Sanity check of the entry */
-static bool xen_pt_check_entry(lpae_t entry, mfn_t mfn, unsigned int flags)
+static bool xen_pt_check_entry(lpae_t entry, mfn_t mfn, unsigned int level,
+                               unsigned int flags)
 {
-    /* Sanity check when modifying a page. */
+    /* Sanity check when modifying an entry. */
     if ( (flags & _PAGE_PRESENT) && mfn_eq(mfn, INVALID_MFN) )
     {
         /* We don't allow modifying an invalid entry. */
@@ -1075,6 +1076,13 @@ static bool xen_pt_check_entry(lpae_t entry, mfn_t mfn, unsigned int flags)
             return false;
         }
 
+        /* We don't allow modifying a table entry */
+        if ( !lpae_is_mapping(entry, level) )
+        {
+            mm_printk("Modifying a table entry is not allowed.\n");
+            return false;
+        }
+
         /* We don't allow changing memory attributes. */
         if ( entry.pt.ai != PAGE_AI_MASK(flags) )
         {
@@ -1090,7 +1098,7 @@ static bool xen_pt_check_entry(lpae_t entry, mfn_t mfn, unsigned int flags)
             return false;
         }
     }
-    /* Sanity check when inserting a page */
+    /* Sanity check when inserting a mapping */
     else if ( flags & _PAGE_PRESENT )
     {
         /* We should be here with a valid MFN. */
@@ -1099,18 +1107,28 @@ static bool xen_pt_check_entry(lpae_t entry, mfn_t mfn, unsigned int flags)
         /* We don't allow replacing any valid entry. */
         if ( lpae_is_valid(entry) )
         {
-            mm_printk("Changing MFN for a valid entry is not allowed (%#"PRI_mfn" -> %#"PRI_mfn").\n",
-                      mfn_x(lpae_get_mfn(entry)), mfn_x(mfn));
+            if ( lpae_is_mapping(entry, level) )
+                mm_printk("Changing MFN for a valid entry is not allowed (%#"PRI_mfn" -> %#"PRI_mfn").\n",
+                          mfn_x(lpae_get_mfn(entry)), mfn_x(mfn));
+            else
+                mm_printk("Trying to replace a table with a mapping.\n");
             return false;
         }
     }
-    /* Sanity check when removing a page. */
+    /* Sanity check when removing a mapping. */
     else if ( (flags & (_PAGE_PRESENT|_PAGE_POPULATE)) == 0 )
     {
         /* We should be here with an invalid MFN. */
         ASSERT(mfn_eq(mfn, INVALID_MFN));
 
-        /* We don't allow removing page with contiguous bit set. */
+        /* We don't allow removing a table */
+        if ( lpae_is_table(entry, level) )
+        {
+            mm_printk("Removing a table is not allowed.\n");
+            return false;
+        }
+
+        /* We don't allow removing a mapping with contiguous bit set. */
         if ( entry.pt.contig )
         {
             mm_printk("Removing entry with contiguous bit set is not allowed.\n");
@@ -1128,13 +1146,13 @@ static bool xen_pt_check_entry(lpae_t entry, mfn_t mfn, unsigned int flags)
     return true;
 }
 
+/* Update an entry at the level @target. */
 static int xen_pt_update_entry(mfn_t root, unsigned long virt,
-                               mfn_t mfn, unsigned int flags)
+                               mfn_t mfn, unsigned int target,
+                               unsigned int flags)
 {
     int rc;
     unsigned int level;
-    /* We only support 4KB mapping (i.e level 3) for now */
-    unsigned int target = 3;
     lpae_t *table;
     /*
      * The intermediate page tables are read-only when the MFN is not valid
@@ -1189,7 +1207,7 @@ static int xen_pt_update_entry(mfn_t root, unsigned long virt,
     entry = table + offsets[level];
 
     rc = -EINVAL;
-    if ( !xen_pt_check_entry(*entry, mfn, flags) )
+    if ( !xen_pt_check_entry(*entry, mfn, level, flags) )
         goto out;
 
     /* If we are only populating page-table, then we are done. */
@@ -1207,8 +1225,11 @@ static int xen_pt_update_entry(mfn_t root, unsigned long virt,
         {
             pte = mfn_to_xen_entry(mfn, PAGE_AI_MASK(flags));
 
-            /* Third level entries set pte.pt.table = 1 */
-            pte.pt.table = 1;
+            /*
+             * First and second level pages set pte.pt.table = 0, but
+             * third level entries set pte.pt.table = 1.
+             */
+            pte.pt.table = (level == 3);
         }
         else /* We are updating the permission => Copy the current pte. */
             pte = *entry;
@@ -1228,15 +1249,56 @@ out:
     return rc;
 }
 
+/* Return the level where mapping should be done */
+static int xen_pt_mapping_level(unsigned long vfn, mfn_t mfn, unsigned long nr,
+                                unsigned int flags)
+{
+    unsigned int level;
+    unsigned long mask;
+
+    /*
+      * Don't take into account the MFN when removing mapping (i.e
+      * MFN_INVALID) to calculate the correct target order.
+      *
+      * Per the Arm Arm, `vfn` and `mfn` must be both superpage aligned.
+      * They are or-ed together and then checked against the size of
+      * each level.
+      *
+      * `left` is not included and checked separately to allow
+      * superpage mapping even if it is not properly aligned (the
+      * user may have asked to map 2MB + 4k).
+      */
+     mask = !mfn_eq(mfn, INVALID_MFN) ? mfn_x(mfn) : 0;
+     mask |= vfn;
+
+     /*
+      * Always use level 3 mapping unless the caller request block
+      * mapping.
+      */
+     if ( likely(!(flags & _PAGE_BLOCK)) )
+         level = 3;
+     else if ( !(mask & (BIT(FIRST_ORDER, UL) - 1)) &&
+               (nr >= BIT(FIRST_ORDER, UL)) )
+         level = 1;
+     else if ( !(mask & (BIT(SECOND_ORDER, UL) - 1)) &&
+               (nr >= BIT(SECOND_ORDER, UL)) )
+         level = 2;
+     else
+         level = 3;
+
+     return level;
+}
+
 static DEFINE_SPINLOCK(xen_pt_lock);
 
 static int xen_pt_update(unsigned long virt,
                          mfn_t mfn,
-                         unsigned long nr_mfns,
+                         const unsigned long nr_mfns,
                          unsigned int flags)
 {
     int rc = 0;
-    unsigned long addr = virt, addr_end = addr + nr_mfns * PAGE_SIZE;
+    unsigned long vfn = virt >> PAGE_SHIFT;
+    unsigned long left = nr_mfns;
 
     /*
      * For arm32, page-tables are different on each CPUs. Yet, they share
@@ -1268,14 +1330,24 @@ static int xen_pt_update(unsigned long virt,
 
     spin_lock(&xen_pt_lock);
 
-    for ( ; addr < addr_end; addr += PAGE_SIZE )
+    while ( left )
     {
-        rc = xen_pt_update_entry(root, addr, mfn, flags);
+        unsigned int order, level;
+
+        level = xen_pt_mapping_level(vfn, mfn, left, flags);
+        order = XEN_PT_LEVEL_ORDER(level);
+
+        ASSERT(left >= BIT(order, UL));
+
+        rc = xen_pt_update_entry(root, pfn_to_paddr(vfn), mfn, level, flags);
         if ( rc )
             break;
 
+        vfn += 1U << order;
         if ( !mfn_eq(mfn, INVALID_MFN) )
-            mfn = mfn_add(mfn, 1);
+            mfn = mfn_add(mfn, 1U << order);
+
+        left -= (1U << order);
     }
 
     /*
-- 
2.32.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 21 10:22:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 21 Feb 2022 10:22:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275992.472053 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM5pu-0005Wb-Vb; Mon, 21 Feb 2022 10:22:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275992.472053; Mon, 21 Feb 2022 10:22:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM5pu-0005UD-C0; Mon, 21 Feb 2022 10:22:30 +0000
Received: by outflank-mailman (input) for mailman id 275992;
 Mon, 21 Feb 2022 10:22:29 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nM5pt-0005K5-3e
 for xen-devel@lists.xenproject.org; Mon, 21 Feb 2022 10:22:29 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nM5ps-0002Bb-VA; Mon, 21 Feb 2022 10:22:28 +0000
Received: from 54-240-197-232.amazon.com ([54.240.197.232]
 helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com)
 by xenbits.xenproject.org with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nM5ps-00070b-Nq; Mon, 21 Feb 2022 10:22:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References:
	In-Reply-To:Message-Id:Date:Subject:Cc:To:From;
	bh=0n6etsYqo9bTpW5hKB66bUfArotdLsp5P4nlJNvCktk=; b=hpgsGAWjKmB3nCSgB72nz6fMpj
	r5/GlFDET7YiB2drOVybCDihBpbWM3SlDyrUqXpruffX2XpjwkPE6cv4hWqvOVQCUIxsTt7LGN+38
	362aFG77G5lHwua6lUDhpNwJ3AxG30RyARIlXYyQuB4XK18ZGjEAJ6805oSnkYXwQdY8=;
From: Julien Grall <julien@xen.org>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	Julien Grall <jgrall@amazon.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH v3 06/19] xen/arm: mm: Avoid flushing the TLBs when mapping are inserted
Date: Mon, 21 Feb 2022 10:22:05 +0000
Message-Id: <20220221102218.33785-7-julien@xen.org>
X-Mailer: git-send-email 2.32.0
In-Reply-To: <20220221102218.33785-1-julien@xen.org>
References: <20220221102218.33785-1-julien@xen.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Julien Grall <jgrall@amazon.com>

Currently, the function xen_pt_update() will flush the TLBs even when
the mappings are inserted. This is a bit wasteful because we don't
allow mapping replacement. Even if we were, the flush would need to
happen earlier because mapping replacement should use Break-Before-Make
when updating the entry.

A single call to xen_pt_update() can perform a single action. IOW, it
is not possible to, for instance, mix inserting and removing mappings.
Therefore, we can use `flags` to determine what action is performed.

This change will be particularly help to limit the impact of switching
boot time mapping to use xen_pt_update().

Signed-off-by: Julien Grall <jgrall@amazon.com>

---
    Changes in v2:
        - New patch
---
 xen/arch/arm/mm.c | 17 ++++++++++++++---
 1 file changed, 14 insertions(+), 3 deletions(-)

diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
index fd16c1541ce2..7b4b9de8693e 100644
--- a/xen/arch/arm/mm.c
+++ b/xen/arch/arm/mm.c
@@ -1104,7 +1104,13 @@ static bool xen_pt_check_entry(lpae_t entry, mfn_t mfn, unsigned int level,
         /* We should be here with a valid MFN. */
         ASSERT(!mfn_eq(mfn, INVALID_MFN));
 
-        /* We don't allow replacing any valid entry. */
+        /*
+         * We don't allow replacing any valid entry.
+         *
+         * Note that the function xen_pt_update() relies on this
+         * assumption and will skip the TLB flush. The function will need
+         * to be updated if the check is relaxed.
+         */
         if ( lpae_is_valid(entry) )
         {
             if ( lpae_is_mapping(entry, level) )
@@ -1417,11 +1423,16 @@ static int xen_pt_update(unsigned long virt,
     }
 
     /*
-     * Flush the TLBs even in case of failure because we may have
+     * The TLBs flush can be safely skipped when a mapping is inserted
+     * as we don't allow mapping replacement (see xen_pt_check_entry()).
+     *
+     * For all the other cases, the TLBs will be flushed unconditionally
+     * even if the mapping has failed. This is because we may have
      * partially modified the PT. This will prevent any unexpected
      * behavior afterwards.
      */
-    flush_xen_tlb_range_va(virt, PAGE_SIZE * nr_mfns);
+    if ( !(flags & _PAGE_PRESENT) || mfn_eq(mfn, INVALID_MFN) )
+        flush_xen_tlb_range_va(virt, PAGE_SIZE * nr_mfns);
 
     spin_unlock(&xen_pt_lock);
 
-- 
2.32.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 21 10:22:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 21 Feb 2022 10:22:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275993.472074 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM5px-0006C9-0p; Mon, 21 Feb 2022 10:22:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275993.472074; Mon, 21 Feb 2022 10:22:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM5pw-00069E-M3; Mon, 21 Feb 2022 10:22:32 +0000
Received: by outflank-mailman (input) for mailman id 275993;
 Mon, 21 Feb 2022 10:22:30 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nM5pu-0005TR-6s
 for xen-devel@lists.xenproject.org; Mon, 21 Feb 2022 10:22:30 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nM5pu-0002Bn-0t; Mon, 21 Feb 2022 10:22:30 +0000
Received: from 54-240-197-232.amazon.com ([54.240.197.232]
 helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com)
 by xenbits.xenproject.org with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nM5pt-00070b-Pv; Mon, 21 Feb 2022 10:22:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References:
	In-Reply-To:Message-Id:Date:Subject:Cc:To:From;
	bh=gj6Tx1Ts6XYE8jhOQFSpNUB23rP/9Mj+pm8BtVXwdgI=; b=uVjIeenzjjYRsw54H1HNYmxQfw
	3v2o/47jmnPmphrWNR5brpLJwHw36oVfIHhVYQH/HTvGFTztGzzBTXDPQ4l4FHFzZkV0lnJXXR4g9
	on+BkY3BJRTt+4hUBLh0xl947Qr63WSRovux0mdJsfwxG8NGpG/GuF77r2jda4RwhMI4=;
From: Julien Grall <julien@xen.org>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	Julien Grall <julien.grall@arm.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Julien Grall <jgrall@amazon.com>
Subject: [PATCH v3 07/19] xen/arm: mm: Don't open-code Xen PT update in remove_early_mappings()
Date: Mon, 21 Feb 2022 10:22:06 +0000
Message-Id: <20220221102218.33785-8-julien@xen.org>
X-Mailer: git-send-email 2.32.0
In-Reply-To: <20220221102218.33785-1-julien@xen.org>
References: <20220221102218.33785-1-julien@xen.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Julien Grall <julien.grall@arm.com>

Now that xen_pt_update_entry() is able to deal with different mapping
size, we can replace the open-coding of the page-tables update by a call
to modify_xen_mappings().

As the function is not meant to fail, a BUG_ON() is added to check the
return.

Signed-off-by: Julien Grall <julien.grall@arm.com>
Signed-off-by: Julien Grall <jgrall@amazon.com>

---
    Changes in v2:
        - Stay consistent with how function name are used in the commit
        message
        - Add my AWS signed-off-by
---
 xen/arch/arm/mm.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
index 7b4b9de8693e..f088a4b2de96 100644
--- a/xen/arch/arm/mm.c
+++ b/xen/arch/arm/mm.c
@@ -599,11 +599,11 @@ void * __init early_fdt_map(paddr_t fdt_paddr)
 
 void __init remove_early_mappings(void)
 {
-    lpae_t pte = {0};
-    write_pte(xen_second + second_table_offset(BOOT_FDT_VIRT_START), pte);
-    write_pte(xen_second + second_table_offset(BOOT_FDT_VIRT_START + SZ_2M),
-              pte);
-    flush_xen_tlb_range_va(BOOT_FDT_VIRT_START, BOOT_FDT_SLOT_SIZE);
+    int rc;
+
+    rc = modify_xen_mappings(BOOT_FDT_VIRT_START, BOOT_FDT_VIRT_END,
+                             _PAGE_BLOCK);
+    BUG_ON(rc);
 }
 
 /*
-- 
2.32.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 21 10:22:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 21 Feb 2022 10:22:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275994.472080 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM5px-0006IG-Hp; Mon, 21 Feb 2022 10:22:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275994.472080; Mon, 21 Feb 2022 10:22:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM5px-0006HB-7k; Mon, 21 Feb 2022 10:22:33 +0000
Received: by outflank-mailman (input) for mailman id 275994;
 Mon, 21 Feb 2022 10:22:31 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nM5pv-0005iU-7R
 for xen-devel@lists.xenproject.org; Mon, 21 Feb 2022 10:22:31 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nM5pv-0002C8-37; Mon, 21 Feb 2022 10:22:31 +0000
Received: from 54-240-197-232.amazon.com ([54.240.197.232]
 helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com)
 by xenbits.xenproject.org with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nM5pu-00070b-S1; Mon, 21 Feb 2022 10:22:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References:
	In-Reply-To:Message-Id:Date:Subject:Cc:To:From;
	bh=m0aLEbK54kAkQt7srRGP8ZDAT2HpX86Y4s8RUrJJBLI=; b=z3x1rDlnxMesdj9WXzr3h3/heK
	Dlu/SsDx31w1y3YKAWXT4NuufWw+g6cm5+XJ0yg4LlcZz9s7rslvsZ11GlZ+CLEj6zsSzm1sagUg8
	54huy996LvdrKXYXtDPp9Ouvc7TEzOy8rCyt+hSJVxKGKhBmI9Qoi4t60d2r6Cfm2Vrs=;
From: Julien Grall <julien@xen.org>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	Julien Grall <julien.grall@arm.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Julien Grall <jgrall@amazon.com>
Subject: [PATCH v3 08/19] xen/arm: mm: Re-implement early_fdt_map() using map_pages_to_xen()
Date: Mon, 21 Feb 2022 10:22:07 +0000
Message-Id: <20220221102218.33785-9-julien@xen.org>
X-Mailer: git-send-email 2.32.0
In-Reply-To: <20220221102218.33785-1-julien@xen.org>
References: <20220221102218.33785-1-julien@xen.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Julien Grall <julien.grall@arm.com>

Now that map_pages_to_xen() has been extended to support 2MB mappings,
we can replace the create_mappings() calls by map_pages_to_xen() calls.

The mapping can also be marked read-only has Xen as no business to
modify the host Device Tree.

Signed-off-by: Julien Grall <julien.grall@arm.com>
Signed-off-by: Julien Grall <jgrall@amazon.com>

---
    Changes in v2:
        - Add my AWS signed-off-by
        - Fix typo in the commit message
---
 xen/arch/arm/mm.c | 18 +++++++++++++-----
 1 file changed, 13 insertions(+), 5 deletions(-)

diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
index f088a4b2de96..24de8dcb9042 100644
--- a/xen/arch/arm/mm.c
+++ b/xen/arch/arm/mm.c
@@ -559,6 +559,7 @@ void * __init early_fdt_map(paddr_t fdt_paddr)
     paddr_t offset;
     void *fdt_virt;
     uint32_t size;
+    int rc;
 
     /*
      * Check whether the physical FDT address is set and meets the minimum
@@ -574,8 +575,12 @@ void * __init early_fdt_map(paddr_t fdt_paddr)
     /* The FDT is mapped using 2MB superpage */
     BUILD_BUG_ON(BOOT_FDT_VIRT_START % SZ_2M);
 
-    create_mappings(xen_second, BOOT_FDT_VIRT_START, paddr_to_pfn(base_paddr),
-                    SZ_2M >> PAGE_SHIFT, SZ_2M);
+    rc = map_pages_to_xen(BOOT_FDT_VIRT_START, maddr_to_mfn(base_paddr),
+                          SZ_2M >> PAGE_SHIFT,
+                          PAGE_HYPERVISOR_RO | _PAGE_BLOCK);
+    if ( rc )
+        panic("Unable to map the device-tree.\n");
+
 
     offset = fdt_paddr % SECOND_SIZE;
     fdt_virt = (void *)BOOT_FDT_VIRT_START + offset;
@@ -589,9 +594,12 @@ void * __init early_fdt_map(paddr_t fdt_paddr)
 
     if ( (offset + size) > SZ_2M )
     {
-        create_mappings(xen_second, BOOT_FDT_VIRT_START + SZ_2M,
-                        paddr_to_pfn(base_paddr + SZ_2M),
-                        SZ_2M >> PAGE_SHIFT, SZ_2M);
+        rc = map_pages_to_xen(BOOT_FDT_VIRT_START + SZ_2M,
+                              maddr_to_mfn(base_paddr + SZ_2M),
+                              SZ_2M >> PAGE_SHIFT,
+                              PAGE_HYPERVISOR_RO | _PAGE_BLOCK);
+        if ( rc )
+            panic("Unable to map the device-tree\n");
     }
 
     return fdt_virt;
-- 
2.32.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 21 10:22:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 21 Feb 2022 10:22:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.275995.472085 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM5py-0006Pq-CR; Mon, 21 Feb 2022 10:22:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 275995.472085; Mon, 21 Feb 2022 10:22:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM5px-0006O3-Og; Mon, 21 Feb 2022 10:22:33 +0000
Received: by outflank-mailman (input) for mailman id 275995;
 Mon, 21 Feb 2022 10:22:32 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nM5pw-00062Y-9Z
 for xen-devel@lists.xenproject.org; Mon, 21 Feb 2022 10:22:32 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nM5pw-0002CP-22; Mon, 21 Feb 2022 10:22:32 +0000
Received: from 54-240-197-232.amazon.com ([54.240.197.232]
 helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com)
 by xenbits.xenproject.org with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nM5pv-00070b-R2; Mon, 21 Feb 2022 10:22:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References:
	In-Reply-To:Message-Id:Date:Subject:Cc:To:From;
	bh=f5eydWA/xrVr2E4ET4uKtIXdg9zT+/rA87h+Dp/T1XQ=; b=kGZXEvUvAbBP8RABHqRfsx1pWV
	Ri+mN6arLvsf1/9WTidhs68lId5bZsdZ5BKsSTGfV/LtrsypqKt8+0I5eaj3ZgJ4Puhwknk+wugJb
	qEw7W6bp4sIPOni6pCivbopojiCa7mIIg7d8ZQveDVkm9muFF7wEKgBMvy7udwNT/8Jc=;
From: Julien Grall <julien@xen.org>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	Julien Grall <jgrall@amazon.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH v3 09/19] xen/arm32: mm: Check if the virtual address is shared before updating it
Date: Mon, 21 Feb 2022 10:22:08 +0000
Message-Id: <20220221102218.33785-10-julien@xen.org>
X-Mailer: git-send-email 2.32.0
In-Reply-To: <20220221102218.33785-1-julien@xen.org>
References: <20220221102218.33785-1-julien@xen.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Julien Grall <jgrall@amazon.com>

Only the first 2GB of the virtual address space is shared between all
the page-tables on Arm32.

There is a long outstanding TODO in xen_pt_update() stating that the
function can only work with shared mapping. Nobody has ever called
the function with private mapping, however as we add more callers
there is a risk to mess things up.

Introduce a new define to mark the end of the shared mappings and use
it in xen_pt_update() to verify if the address is correct.

Note that on Arm64, all the mappings are shared. Some compiler may
complain about an always true check, so the new define is not introduced
for arm64 and the code is protected with an #ifdef.

Signed-off-by: Julien Grall <jgrall@amazon.com>

---
    Changes in v2:
        - New patch
---
 xen/arch/arm/include/asm/config.h |  4 ++++
 xen/arch/arm/mm.c                 | 11 +++++++++--
 2 files changed, 13 insertions(+), 2 deletions(-)

diff --git a/xen/arch/arm/include/asm/config.h b/xen/arch/arm/include/asm/config.h
index c7b77912013e..85d4a510ce8a 100644
--- a/xen/arch/arm/include/asm/config.h
+++ b/xen/arch/arm/include/asm/config.h
@@ -137,6 +137,10 @@
 
 #define XENHEAP_VIRT_START     _AT(vaddr_t,0x40000000)
 #define XENHEAP_VIRT_END       _AT(vaddr_t,0x7fffffff)
+
+/* The first 2GB is always shared between all the page-tables. */
+#define SHARED_VIRT_END        _AT(vaddr_t, 0x7fffffff)
+
 #define DOMHEAP_VIRT_START     _AT(vaddr_t,0x80000000)
 #define DOMHEAP_VIRT_END       _AT(vaddr_t,0xffffffff)
 
diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
index 24de8dcb9042..f18f65745595 100644
--- a/xen/arch/arm/mm.c
+++ b/xen/arch/arm/mm.c
@@ -1365,11 +1365,18 @@ static int xen_pt_update(unsigned long virt,
      * For arm32, page-tables are different on each CPUs. Yet, they share
      * some common mappings. It is assumed that only common mappings
      * will be modified with this function.
-     *
-     * XXX: Add a check.
      */
     const mfn_t root = virt_to_mfn(THIS_CPU_PGTABLE);
 
+#ifdef SHARED_VIRT_END
+    if ( virt > SHARED_VIRT_END ||
+         (SHARED_VIRT_END - virt) < nr_mfns )
+    {
+        mm_printk("Trying to map outside of the shared area.\n");
+        return -EINVAL;
+    }
+#endif
+
     /*
      * The hardware was configured to forbid mapping both writeable and
      * executable.
-- 
2.32.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 21 10:37:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 21 Feb 2022 10:37:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276062.472108 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM63x-0002qE-FX; Mon, 21 Feb 2022 10:37:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276062.472108; Mon, 21 Feb 2022 10:37:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM63x-0002q7-Bn; Mon, 21 Feb 2022 10:37:01 +0000
Received: by outflank-mailman (input) for mailman id 276062;
 Mon, 21 Feb 2022 10:37:00 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nM63w-0002px-9w; Mon, 21 Feb 2022 10:37:00 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nM63v-0002SA-W2; Mon, 21 Feb 2022 10:37:00 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nM63v-0008KU-EA; Mon, 21 Feb 2022 10:36:59 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nM63v-0004Ws-Dh; Mon, 21 Feb 2022 10:36:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=aPzNY9Dl8VefV9xPSt2kWOTeYpBKUvmYm2t+I26tc9Q=; b=I9d7cHAZEfFPlLBho/uEvdUOLc
	DYU/10m15UexjMUq5ZNhpVhmoqL3Rt2l3HRwJYBUQBRcCnBXKxDtYK/v9t57KxFQXmC0s/ll6Lqwv
	x43B94vPW7r1BLCR3HH2GsE8V1uGAIlkjWWBvxex5sLsmPAU2S61O8XkEu8qY5cQz568=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168182-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 168182: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-arm64-arm64-xl-seattle:xen-boot:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=686f13cfce1d95464ff39fb59ac1f85163cea03b
X-Osstest-Versions-That:
    xen=686f13cfce1d95464ff39fb59ac1f85163cea03b
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 21 Feb 2022 10:36:59 +0000

flight 168182 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168182/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-xl-seattle   8 xen-boot         fail in 168175 pass in 168182
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 168175

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168175
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168175
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168175
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168175
 test-armhf-armhf-xl-rtds     18 guest-start/debian.repeat    fail  like 168175
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168175
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168175
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168175
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168175
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168175
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168175
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168175
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168175
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  686f13cfce1d95464ff39fb59ac1f85163cea03b
baseline version:
 xen                  686f13cfce1d95464ff39fb59ac1f85163cea03b

Last test of basis   168182  2022-02-21 01:53:55 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Mon Feb 21 10:38:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 21 Feb 2022 10:38:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276074.472118 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM654-0003Sd-UT; Mon, 21 Feb 2022 10:38:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276074.472118; Mon, 21 Feb 2022 10:38:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM654-0003SW-RW; Mon, 21 Feb 2022 10:38:10 +0000
Received: by outflank-mailman (input) for mailman id 276074;
 Mon, 21 Feb 2022 10:38:09 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=vyL6=TE=citrix.com=prvs=04447c275=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nM653-0003SP-LB
 for xen-devel@lists.xenproject.org; Mon, 21 Feb 2022 10:38:09 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5b25f681-9302-11ec-8539-5f4723681683;
 Mon, 21 Feb 2022 11:38:08 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5b25f681-9302-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645439888;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=CmkBH10/xbV22qlXlAqN+ydnsL1j5/GBZV3vOSJT7po=;
  b=IJDoy/ieO1dGvPUZcirpbQ5mzNw5HzSa4ehCkUy+xNiGKQpcCtkBhaY/
   aKT0ZcUZLW2JBhpA5SF/i6CNWELrwtjId9o0jAOe2Ul3O8xakf1qtJ+Sq
   Usp9Ovzaor008Kb5xqDPKGVvXFvGg86yeKjU5vXWbGzo/nZLcHVDVhmoI
   M=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 65043832
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:tEO5FqIhtCmSzYEvFE+Rs5UlxSXFcZb7ZxGr2PjKsXjdYENShjAOz
 jAZDTuFOqnZNmWjc9tyaty+pBtXvpbTytNiGQNlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA180IMsdoUg7wbRh2NQx2YHR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 PZOi8GCFTsABZLjpMQfTztZCnk5J6ITrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBNPsM44F/Glp0BnSDOo8QICFSKLPjTNd9Glt3pwVTa2ED
 yYfQSVeYVOaTwRQBgs8KrRltqSMhz79ejIN/Tp5ooJoujOOnWSdyoPFINfTP9CHW8hRtkKZv
 X7duXT0BAkAM96SwibD9Wij7tIjhguiBthUTufhsKc33hvDnQT/FSH6S3OYosfkuBKCculgB
 HA0+DYMrLFqs1akG4yVswKDnFaIuRsVWtx1GuI86R2Qxqe83zt1FlToXRYaNoV46ZZeqSgCk
 wbQwoi3XWAHXKi9FCrFnop4uw9eLsT8wYUqQSYfBTUI7ND4yG3YpkKeF40zeEJZYzCcJN0R/
 9xohHVk71nwpZRSv0lewbwgq2jxzqUltiZvum3qspuNt2uVnrKNaY2y8kT85v1dNoufRVTpl
 CFax5XFvLxfUMDQzn3lrAAx8FaBvavtDdEhqQQ3Q8lJG8qFoBZPgry8EBkhfRw0Y67oiBfiY
 VPJuBM52XOgFCDCUEODWKroU55C5fG5TbzND6mIBvITMskZXFLWp0lGOB/Pt10BZWBxyMnTz
 7/AKp3yZZvbYIw6pAeLqxA1i+FznXlmnTuJLX05pjz+uYejiLeuYe5tGHOFb/wj7bPCpwPQ8
 t1FMNCNxQkZW+r7ChQ7O6ZJRbzWBRDX3azLlvE=
IronPort-HdrOrdr: A9a23:kwNzJaM6gQZB7MBcTyX155DYdb4zR+YMi2TDiHoedfUFSKOlfp
 6V8MjztSWVtN4QMEtQ/+xoHJPwPE80kqQFnbX5XI3SJjUO3VHIEGgM1/qG/9SNIVybygcZ79
 YeT0EcMqyBMbEZt7eD3ODQKb9Jq7PrgcPY59s2jU0dNj2CA5sQnjuRYTzra3GeKjM2YqbQQ/
 Gnl7R6TnebCD8qR/X+IkNAc/nIptXNmp6jSRkaByQ/4A3LqT+z8rb1HzWRwx9bClp0sPof2F
 mAtza8yrSosvm9xBOZ/2jP765OkN+k7tdYHsSDhuUcNz2poAe1Y4ZKXaGEoVkO0auSwWdvtO
 OJjwYrPsx15X+UVmapoSH10w2l6zoq42+K8y7vvVLT5ejCAB4qActIgoxUNjHD7VA7gd162K
 VXm0qEqpt+F3r77WrAzumNcysvulu/oHIkn+JWpWdYS5EiZLhYqpFa1F9JEa0HADnx5OkcYa
 ZT5fnnlbZrmG6hHjPkVjEF+q3vYp1zJGbLfqE6gL3V79AM90oJinfxx6Qk7wA9HdwGOt15Dt
 //Q9ZVfYF1P7wrhJ1GdZI8qOuMeyXwqEH3QSqvyWqOLtByB5uKke+x3IkI
X-IronPort-AV: E=Sophos;i="5.88,385,1635220800"; 
   d="scan'208";a="65043832"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=hmZTT3ll9Wof7104WfTTZr27YgMMVBE9CYnZGWjQ5W4LCiCA8hSrueot7dLUNrzEIKEvG8kgC0CcCKqomqbxoT3fATvqBNaeScUMbC6rg5JBJkkmP0htEeW5wCMzFXkUjsgKx7YbLnTbjsS0n0A6pjnHRqRvaW4dmlGGO6i2dFrKV0DaU8JDHPYwlLuGor5zjZFA5mivZbBRdq5T53Ch58a2Xfa4nryanRLxDErmP2kdrTaFl3O0YeGVcLamEogVMmmA8vLDEEPhnBEIpmvfp6wEHWQV65BUDfraOLxIrCeVPZ3lSfF6FoZuY0DKS13NuMjhbdyC9brb8x4x+vt4Lw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=HXqOQDBG0IhVUdxCG71KSOtrHMM7QX77cQFq/Ygmw94=;
 b=FKdZu2EDXdWTa0BuwCKjRNeAuAG3NoiCVstNJNBNJUmv0Ry00xs3lDY0vkMC+yxl5zY2KwZahKkFydg1sb8qEnC4EjpQkjNJp7r1lz8n8xsX3SFxfVS92wsi+SpZz/rwRE9FgJW5SrzST2geSEylssnyBBL0aYvwaacPUy0PejEq/5qYxQSSqT/odd2wTXMwMDYNyAzrueZZXKeAJlycIQBltDsfQo7/qxcmxrVxlSGSUisgUVC7YEdaLD0ei9JvPmenrpgI6ptFrqBOqQozUEL702Me8qj79mw1JK/wP4XNzoDQhEau44uc1HUTL2tnZ2WOjqCJF5xQCPXtHjWbkA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=HXqOQDBG0IhVUdxCG71KSOtrHMM7QX77cQFq/Ygmw94=;
 b=GobSDMsyEbZusFdLvTGlTc7GuCf5c915UVmeuQbEhEYL+zN3swWIdRI01E8gj36lmYmNvLpHaaBQ6Ruh3Q6AFYGizAXor6Oe0EqSIO5C+CX3Wf80DOuPED8Z5bCBaCCdrEHg+SpCXYYSTxVgF2Wc6cxi+sdKbz8pUkF67fVyRTY=
Date: Mon, 21 Feb 2022 11:37:58 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 3/3] CI: Coverity tweaks
Message-ID: <YhNrhuvBbZ43hcA6@Air-de-Roger>
References: <20220221100254.13661-1-andrew.cooper3@citrix.com>
 <20220221100254.13661-4-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220221100254.13661-4-andrew.cooper3@citrix.com>
X-ClientProxiedBy: LO4P123CA0208.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1a5::15) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: fcb0ba0a-c05f-479e-f1d2-08d9f5263ca3
X-MS-TrafficTypeDiagnostic: DM6PR03MB3945:EE_
X-Microsoft-Antispam-PRVS: <DM6PR03MB3945500D4A96FAC8B5CA54E48F3A9@DM6PR03MB3945.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: UPCMwgAsl/PvTOdQUjNHqBoEJM69lOYhNB+r3OFlr+I5ZW6wnnGphkux71OHBi62dQ9ViIV1Ma4pIHkPYjwlideUcpwohCi6TN/oV+8S7kbz2JwCxXRShUSWSfWdDvNTpeWl3lHXb2qX2MN2E2vc0PjXbH0fIiM/A9q2dkg9tFyR7AG6kPNGdzpUepmY/1r4MgxU8ZOSWfcOLB/57qmQFHFyZbT8bmIJWaVrxG8EjdXriIYQgcYuivjdDDo3FwPNFcQIWEx7TVvyRFnmlTGRea4jKBIwW+SLeyAna23p1DaZA7xacP0W1gUF94pyPJ4lOmE0lPoum+4SHqxAgdzbGIwgabjQEwDkm+d/GG+7lQcPYhUIxgNzU7R7xrwwZCPOUklnRJCZHJqMaeLJruqPbruo8Rk25AYaxCiUFjH7S1QUeVE3/g0QDEeORmOjOltLz3v+viGJtqrc7SiZiT5A0ByanbwMu/02zTkgPLJOO0QPh9z6CqaZJnwqw9t4k/lTsYCVkQx9EzAnQGRTA9EF7z/oytRTQRMrHGXa9FF54NV1A0pgXLDnOFrv9AqGu4oQC05/EtHW3cWjmjbgiH7cWolJjxyuk1FQNSa5Tj1CiupWzeXlpi55JrzYOk3VIlgrzuJvqRPvfb2Ji3bzfYOKTw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(9686003)(6666004)(6506007)(66556008)(6512007)(5660300002)(4326008)(6862004)(26005)(316002)(508600001)(85182001)(66946007)(66476007)(6486002)(6636002)(83380400001)(186003)(8676002)(8936002)(33716001)(38100700002)(82960400001)(2906002)(86362001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UVRiR2ZsV1hTQ3draWVsNGxaMmFURnJ4QTNQdXdSNEU0dDR5c2FrSlhjcE1u?=
 =?utf-8?B?UXk0RGpmUHFyMk9SRXhSUXdJbkh6TDZlKzJZd2s5TjlLaFhoTlFzRjJZQ2FE?=
 =?utf-8?B?STgveHRZK2IzY2hmZW1zeEJIOWNwOE0rbnNLcUpTMzdjYk0rYll6QStGalRI?=
 =?utf-8?B?YjBlcExlK21JWjFpcU5TZmFMYjFkUWdPODhSM2U2amRaZThzREUzeTFwMEpD?=
 =?utf-8?B?RmtxRXVqWTREeWFoank4MHNpd1VjYzdZZ2svNitIMVk3d0JDRFdnV0dmQW5q?=
 =?utf-8?B?Y0lHUkF6SVRXa3Q2Mk1RaWlYbGJuWGFRaGREdjBRMXNaWGcxTE5xYWNsNE12?=
 =?utf-8?B?WWZnUUxsNDN3c0M4WHNqS1p0bGg3ejIrK0RkYnlLOStOOVJhUkdMaFhNV3VL?=
 =?utf-8?B?K1RPWVBqUnBjLzdxN3A3SUE0VTZwR3RUbWlOU2NrdGtZNU5TdWdPbkVndWZO?=
 =?utf-8?B?ZDV5ZEFPaTBJd3dGZ3Z4dXlKWWNBd29yL3h3V0p5cUJEOUc4UW95V3hTeFJ4?=
 =?utf-8?B?eVJ5cm9TaURULzRyVm51Z2RWdVRreDhRSWk1aGFOcjl3ZGMxbTZUei9HeU1a?=
 =?utf-8?B?RTRjUE1aUEJPTlFXSTdWZnpySllCTVJqQTdJKy9sUkxvSkdwTXF4Q25WMHlX?=
 =?utf-8?B?amdFS2lNN0FBamtlVjM4THRtQzVGbjEzWVAvTkpsdUxpWXZRUzJEWmQvYXQ5?=
 =?utf-8?B?OWhlaG9FbS96ekYvQmhsanBibXQvMUU4SlpCbUxGR1FhVGJPZlkrMldjQjVY?=
 =?utf-8?B?b1BCUEd2cjRuNmsrblNKREdTMS9HemlJZU9QSmQveENKNGxoeVh2bjFOWUlX?=
 =?utf-8?B?SDk1TDlESExKT2M0dG9pT1Q5d0hpK1R4OEZjTG9qalhUaStNbkYzdGxucVZ2?=
 =?utf-8?B?WmRlSEtaRjllUTJJdjQvQ2NMV1dpSjlYcmQzd0d5cUlGQmgxeHd3Z2tCWjJm?=
 =?utf-8?B?U2JpV1hQaTlJM1VLY1pXVW5sbFl6VE5HVXU1TmVlbTBiK3lyK0dadEQwN1pr?=
 =?utf-8?B?K21iVUlMc0VENGg0OVFtRVduN1hCdlc3RTVIajJ5MVlCYWlJdmRyUnZlSU1P?=
 =?utf-8?B?enBuam14SEs4N3JSeE1qR29RWHVSNVRDc2VuYjZ2WEYyWXUzeU1jUWFCd0hY?=
 =?utf-8?B?QVExYTZZNGdSdExYdmFONE0wVWVlYmQ5eXNnTVBaMUllai9nSkYwVXZjcnJx?=
 =?utf-8?B?WmU0YXZ4WEZLZzV2cXc4bjRmU0pKcUV2RUFnSU9YTXVISEFuMHQzeGJOSFpG?=
 =?utf-8?B?OGFGbElMcGk5bGNGSkxOYVFDU1dPc2czNmFQRTVSbE1uUWhGSnlFMG1IMUx1?=
 =?utf-8?B?TFAvQUJEd0F0MEVUTlZta01XMm5Xcno3Y1ZreHlBcEY4THc3MVpKTXk0eSt2?=
 =?utf-8?B?VGRValpJNEFwMlZwcGxGVTJCU0dtWUk4N29mMEU1eUN0c2hMUmwxMTVLM1pQ?=
 =?utf-8?B?dThnK0xSaU9TLzYyS1RnamRqYVFLQ1YrRjdZdjdSMllGLytybS9YcUNhK0tI?=
 =?utf-8?B?bkZJZ1pZT1owc3JkRDQ0OWkyTXhsd3Q4alJERzVCYVcxTFdsV09BbG9CaTZP?=
 =?utf-8?B?TGdrRUZLckN1MmdWQnVHV3ZlOHovek10US9IMEtyUVh3MThEcXpXVmx4SXhz?=
 =?utf-8?B?WjZsWk9nOVl6WWRLbmNHUmdSeGVlY203d0hqa0gwMFRFbWJCUnpvUTVVRjBz?=
 =?utf-8?B?NUtTb3p3TlBrMTJodExlZmcyWHdGdG16V0hFb3NOV2VTZXo1aFNDcGladmtK?=
 =?utf-8?B?aWRoNE9oMVhJVXZZeHczdk5TbG5wMHRxNm5NdGJ4TkJWV3VUSi80OW1nRmdk?=
 =?utf-8?B?NmZQRTVEbGVGaGlNWVhUckphRHNaSDA1eTBHdXo0ZGhUSk1FMENobVpnVVVl?=
 =?utf-8?B?RFFZOG55RXRSOVpQUW1GK3BLUDB6Y1RWcEFnSjljRjc1L2dxQ0M2VFN4R251?=
 =?utf-8?B?cEo4UU80NjJmcDVhbjdMNzVYWGZPUy85M0s3QXJFOVp1NU4rTDA3Skp1SW9T?=
 =?utf-8?B?U2lpSDBZRjZwSlBOcDh5N2IremFQb2JTWVZFWFhQbGNzamFlM3k2eGRoSWZV?=
 =?utf-8?B?YXVyMWRzNkxIUUxzSHI2clc2MEZqSmtBcXdHRTRDT0hKM2N3Y0R0QktOblJF?=
 =?utf-8?B?enN4MmJoUVloZXpyR0o0KzhyVVRDenJkNEVJcGRzdGJlL25NcHEyRVl6K2VW?=
 =?utf-8?Q?rWjwDtQcfUnQL4tEc02quVU=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: fcb0ba0a-c05f-479e-f1d2-08d9f5263ca3
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2022 10:38:02.5825
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: byOX61qKQz95Xd9vgogJ7IIuicVHJyIQqNG2zeH0IItCW67+jD9vEfilND/QW0zRin+s/oPkCng8cpupulSggQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3945
X-OriginatorOrg: citrix.com

On Mon, Feb 21, 2022 at 10:02:54AM +0000, Andrew Cooper wrote:
>  * Use workflow_dispatch to allow manual creation of the job.
>  * Use parallel builds.  The workers have two vCPUs.
>  * Shrink the dependency list further.  build-essential covers make and gcc,
>    while bridge-utils and iproute2 are runtime dependencies not build
>    dependencies.  Alter bzip2 to libbz2-dev.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> ---
> CC: Roger Pau Monné <roger.pau@citrix.com>
> ---
>  .github/workflows/coverity.yml | 14 ++++++++------
>  1 file changed, 8 insertions(+), 6 deletions(-)
> 
> diff --git a/.github/workflows/coverity.yml b/.github/workflows/coverity.yml
> index 9d04b56fd31d..6e7b81e74f72 100644
> --- a/.github/workflows/coverity.yml
> +++ b/.github/workflows/coverity.yml
> @@ -2,6 +2,7 @@ name: Coverity Scan
>  
>  # We only want to test official release code, not every pull request.
>  on:
> +  workflow_dispatch:
>    schedule:
>      - cron: '18 9 * * WED,SUN' # Bi-weekly at 9:18 UTC
>  
> @@ -11,11 +12,11 @@ jobs:
>      steps:
>      - name: Install build dependencies
>        run: |
> -        sudo apt-get install -y wget git gawk bridge-utils \
> -          iproute2 bzip2 build-essential \
> -          make gcc zlib1g-dev libncurses5-dev iasl \
> -          libbz2-dev e2fslibs-dev git-core uuid-dev ocaml \
> -          ocaml-findlib xz-utils libyajl-dev \
> +        sudo apt-get install -y wget git gawk \
> +          libbz2-dev build-essential \
> +          zlib1g-dev libncurses5-dev iasl \
> +          libbz2-dev e2fslibs-dev uuid-dev ocaml \
> +          ocaml-findlib libyajl-dev \
>            autoconf libtool liblzma-dev \
>            python3-dev golang python-dev libsystemd-dev
>  
> @@ -31,7 +32,7 @@ jobs:
>  
>      - name: Pre build stuff
>        run: |
> -        make mini-os-dir
> +        make -j`nproc` mini-os-dir
>  
>      - uses: vapier/coverity-scan-action@v1
>        with:
> @@ -39,3 +40,4 @@ jobs:
>          project: XenProject
>          email: ${{ secrets.COVERITY_SCAN_EMAIL }}
>          token: ${{ secrets.COVERITY_SCAN_TOKEN }}
> +        command: make -j`nproc` build

There's already a 'command:' parameter set just before 'project:'. Are
we OK with using plain build?

If so we would have to disable docs build and stubdom? We don't want
to analyze all the newlib &c that's build as part of stubdoms?

Anyway, the switch from `make xen tools && make -C extras/mini-os/`
to `make build` needs to be explained in the commit message IMO.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Feb 21 10:43:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 21 Feb 2022 10:43:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276082.472130 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM6AV-0004vI-Jd; Mon, 21 Feb 2022 10:43:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276082.472130; Mon, 21 Feb 2022 10:43:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM6AV-0004vB-GI; Mon, 21 Feb 2022 10:43:47 +0000
Received: by outflank-mailman (input) for mailman id 276082;
 Mon, 21 Feb 2022 10:43:45 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=vyL6=TE=citrix.com=prvs=04447c275=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nM6AT-0004v4-L0
 for xen-devel@lists.xenproject.org; Mon, 21 Feb 2022 10:43:45 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 237bb0cc-9303-11ec-8539-5f4723681683;
 Mon, 21 Feb 2022 11:43:44 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 237bb0cc-9303-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645440224;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=FGIrWIm1gGF5yEgAkMubnMpD4HFLKoCcvsdO83bJzkU=;
  b=eU61hvG5sFiqDNCUOx0RpqCqk/Sflb6YTf/TxcbgZVmZXm1sfMYFAiZo
   mU7Q6yts1YHIpHjxTbqcVd5Xw9LaZ4nvHpGBQfd/J21AAqc+FuSJHdw1i
   UFI63QipOyINp/jxy6+NJ44ka5VNlW22vYJTqUttZNTBaA3XITEQhwKC9
   M=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 64638340
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:1jo0P60sIiF8z8lR5PbD5bFxkn2cJEfYwER7XKvMYLTBsI5bpzcGy
 DYcCmnUbqyDNGv8KN8lOdji8UNQv5eEyYdjTlY5pC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk0GE/NtTo5w7Rj2tQy2IDga++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /13lIOSUBVwZZfxleQhbRh1NiEmDZdZreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHxO4wSoDd4xCzxBvc6W5HTBa7N4Le02R9u2p4VTa2CP
 6L1bxJUZzvbT0ViOG5NDYobhfyHpiDbchhH/Qf9Sa0fvDGIkV0ZPKLWGMrYfJmGSNtYmm6cp
 3na5CLpDxcCLtudxDGZtHW2iYfycTjTAdxIUufir7gz3QPVljd75AAquUWTm9imqFesAollF
 kEUxhQvgI0yrHyRUYyoN/Gnm0KsshkZUttWNuQ17gCR16bZizqk6ng4oi1pM4J/6pJvLdA+/
 hrQxo6yW2Qz2FGAYS/Frt+pQSWO1T/5xIPoTQsNVkM77tbqu+nfZTqfH484QMZZYjAYcAwcI
 gxmTgBj3d3/buZRjs1XGGwrZBr2+/D0ovYdvFm/Y45cxloRiHSZT4Kp80PHyv1LMZyUSFKM1
 FBdxZTDt7BSXMzcyXbcKAnoIF1Oz6zYWAAwfHY1R8Vxn9hT0yXLkX9sDMFWex4yb5dslc7Ba
 07PowJBjKK/z1PxBZKbl7mZUpxwpYC5TIyNfqmNMrJmP8ggHCfarXoGTRPBgAjQfL0EzPhX1
 WGzKp33Ux73yM1PkVKLegvq+eV1nntnnTuLH/gWDX2PiNKjWZJccp9cWHOmZeEl9qKU5gLT9
 tdULcyRzBtDFub5Z0HqHUQ7dDjm8VBT6UjKlvFq
IronPort-HdrOrdr: A9a23:0LerX6r2Ae0rpbMfjSANKNUaV5vJL9V00zEX/kB9WHVpm5Oj+P
 xGzc526farslsssREb+OxpOMG7MBThHLpOkPMs1NCZLXTbUQqTXfpfBO7ZrQEIdBeOlNK1uZ
 0QFpSWTeeAcWSS7vyKkTVQcexQueVvmZrA7Yy1rwYPcegpUdAZ0+4QMHfkLqQcfnghOXNWLu
 v52iIRzADQBkj/I/7LTkUtbqzmnZnmhZjmaRkJC1oO7xSPtyqh7PrfHwKD1hkTfjtTyfN6mF
 K12TDR1+GGibWW2xXc32jc49B/n8bg8MJKAIiphtIOIjvhpw60bMBKWqGEvhoyvOazgWxa2+
 XkklMFBYBe+nnRdma6rV/E3BTh6i8n7zvYxVqRkRLY0LvEbQN/L/AEqZNScxPf5UZllsp7yr
 h302WQsIcSJQ/cnQzmjuK4GC1Cpw6Rmz4PgOQTh3tQXc81c7lKt7ES+0tTDdMpAD/60oY6C+
 NjZfusqMq+SWnqLkwxg1MfgOBFBh8Ib1S7qwk5y4GoOgFt7T5EJxBy/r1cop8CnKhNP6Wsqd
 60d5iAr4s+PfP+XZgNdNvpfvHHeFAlYSi8Rl56cm6XXZ3uBRr22uvKCfMOlaWXRKA=
X-IronPort-AV: E=Sophos;i="5.88,385,1635220800"; 
   d="scan'208";a="64638340"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=GwXS66QxG0h1KeU3krqz5cen2ea6bylUig2tAS9OioITbXr4Tq3D0pTrJGE00Gh37ltYukAnElk0SJbapE+8kS12l9le/9bYq3IcCuaLS5abzcs4G5lMx1IcRDbB7sq7UIUTzBgvw0WyaX/SvfUHHyfMXRgkMYT/1MCxpDrDa89bnoTvv1HjAvkp+005I+Lr+8pt2gqlkNn9TV8KgZ/AxxbH9cSh1dJKCCG7rzspSM47eMPYmtEPB5bqjIIGkuymAPD4lVzOB4ONn+q6BjSE2mKiji6qAt6ZbRz9Xi3PA/vgShccp4bkbSgh40lbqGzfDUBKT5Ru5r4/h8Mhh5QRsg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=VgPfmRmeN5J9fv2rp8St799o9ORvl2ij5ICCI8SDI8U=;
 b=hMjHFKMwS0NjpKYWnW3ytuit8wX0lsHNfmpM5EDkzNTnTEkjFj6+OfDEG5D82UT5kQaBp7KjbCxj1G4lp2a58WfJ4D/eM6rYbBFMvCJySz51Gxb7XciMOrOaLJqWYlE3amErlaxBoEZnIzvtXezkJwJMM5YPnSLtSeP41zJ1S/J7rLbx50iyan245uoamulprxMSHGC+/TTPAQfcIBx5p0o3WawoYhr9lN+S7L9Xz0UnssSmg/Uy97M2Ujpp6ixAWyY9g0/2onIyORpyFDBX2a/3C3aWSJ0mhD4D7nLgEH3fj1KZFqecrp04iWM7EVV5VgVWQZUGSIDOZrSIV/ip1w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=VgPfmRmeN5J9fv2rp8St799o9ORvl2ij5ICCI8SDI8U=;
 b=lhfKOXQqlny56A/tWk/uITa/nCGhKz/CueZuGMs/CT88dHJMISRUQGXa51gSiALk3ZZL1b5pp0ziAEliulQxlA6OD4XmsGTHwPm7lDbihUpi8FUtTB5lIYfJzm2+Vc67GBkX6X26v2RfIze8ytiXzTFtEwURk5cS1rAPo/Wo5WU=
Date: Mon, 21 Feb 2022 11:43:35 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 1/3] tests/resource: Initialise gnttab before
 xenforeignmemory_map_resource()
Message-ID: <YhNs14xZK0t6OwGN@Air-de-Roger>
References: <20220221100254.13661-1-andrew.cooper3@citrix.com>
 <20220221100254.13661-2-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220221100254.13661-2-andrew.cooper3@citrix.com>
X-ClientProxiedBy: LO4P123CA0224.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1a6::13) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 49ce92a2-fa92-422f-4f1a-08d9f527055c
X-MS-TrafficTypeDiagnostic: BN7PR03MB3474:EE_
X-Microsoft-Antispam-PRVS: <BN7PR03MB3474CE0906749BD8433641368F3A9@BN7PR03MB3474.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: YcchdAllAf5zHsULpBDjrOEd2IJFF4yYb0Y62A4qhBK+XGeVT32dH2RbjGciV/sjw4+E6NFyYfUsKYzolATB3THUBTvO8uM49QDIPWF1T/xX3tnGH7hR3fSKm4dWmLjvm+0ouTMQUTNEUi9x0NeGekBU/QGKvzD6aLVs0C79JgR2TnazpPac0VXgdSto8pqcFQ5LeDpMNUnvxc0TknOK5Pkv0JoNN+cv/uWGa39xvhTwVZS6FHtybse1E+UEFFhUlIKTV20ocMteOt3ZjTZj9fPuwS76GdMq/ZDE6SiNqcUqtsidluGzZBR14iz4TdIO8iWiy+CvsLpY09TJufCVej5ZsdkGtAgoLGx45JdWVjOXKb+yc3MBY23SPP+Y1iYboXkeavMOFLHJiqn4B//UndQTsrVpFqiYBJ9zTqgFOS5SqJDPG9rK2vVHdBEaZNABWHTpWVIcQ4lWaG+lSLZTwblvYr8lNDNGZ05O2PAYYbnxguz0aHf9RcsHcZVxC3BS3E4BHUjuPF+Ea0dyepVSS4wE81dduTIvxvk4VZ74Se/+3h9yk1AU6auTGk1FuVERUtAjdtqQLj0yVl1kMMxBPx3OKD10PPX+TsLy1hd84RKV4dx5Z15sokYH98tNIzeZgCm7Xr1bvUVrlm9kXFYDXQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(8676002)(4326008)(6862004)(66556008)(6486002)(66946007)(66476007)(6636002)(316002)(508600001)(33716001)(4744005)(6512007)(9686003)(8936002)(5660300002)(2906002)(82960400001)(6666004)(6506007)(86362001)(186003)(26005)(38100700002)(85182001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NmcwOUdrQWpxVlZOSVQ0ejZrSVN6aXpRWVdQc25ienY4VVJGUUIwSjllV28v?=
 =?utf-8?B?aFAzL1dUdTF0NlVMb0YrYnp5bnpadFZEdzFpQTVyYW1pakU3TVhuVHgvM1NB?=
 =?utf-8?B?T3NUMHBkOHdaOFFseVhxY0hnbEZEWGFzUnBpQlFrcVltVjkvbnhUaE03ellj?=
 =?utf-8?B?Um1FSjlOQXExWXczUGxpcWI2OCtia290TndsV0lIc2xxRjFkM3lhQkFLeEM1?=
 =?utf-8?B?cHJ1dmtiQjJlZDk0ZkUvRjZseDFMQVJsbTJ6b3NBREpXRHR4S0w5dXpZdjk2?=
 =?utf-8?B?RHk0azIwSk1lNlJ3V0VpTWhQTWRzazZocTRBMDR2cUdmajh3dHE1dVV2Mk9U?=
 =?utf-8?B?WCsxc1lpNjc5bTBsYkhRVWhibmxXa3FZWXQxUnA4SGpRVkxVL3ljM1RUQXJx?=
 =?utf-8?B?Y3VyWHduY1ZqZ2o5NTE5Ry94Rk1hRDFrNXh1YjhHSFVUTzc1K0JHZnM5eFVo?=
 =?utf-8?B?TWMwZEo3Wlo0ZldtbmUyVTZMQVNDcFFEakFBTkRqRkFaam5xanJVVERWRDhC?=
 =?utf-8?B?Z3M3WnM0K2tPUWFNZmgxTjB3R1h2dXk1UEtjcnNvOFFoR051UXlJTlJhTkNo?=
 =?utf-8?B?V3k5SDllM2I2ZHRBNkZ6STRmWmIzSlEzbFhaa3hCeElzOTBGYzQ5bXF6Snlv?=
 =?utf-8?B?aUp0L0VleTM2WmRpMnVhWmlGOXZXbHNldGYyL2E0SkU5QkFwQjY5eHFFOVRp?=
 =?utf-8?B?N3ZxaUtkT3pGOFpIUXpBK0ZFT0x0c0x5cmJoR25xazJYSWF2OUt3bWtvMk5X?=
 =?utf-8?B?cGNyRHNsTUQ3MmZCUE9jaml5STd0VHhYZEVxOGdhZFQ0V1NsUkdSdTFLWGtP?=
 =?utf-8?B?OWR4QjQ4dEc3N0pxeVUyc0tlMFZwRVRzUENoL2h2RXZpWUppZ0hQQXpoRzJZ?=
 =?utf-8?B?UTBKckcvelJneE9rYjdGL2pQUmhMYWZyYXB3ck9XL2MvdUpvSmRvSTdBc2pK?=
 =?utf-8?B?NDh3c2NXM1p5YVBsVGJiRUxIanE5eGJMY1puSUlZUUV4S1NscEMvRVFibVV3?=
 =?utf-8?B?dmZHTlR0aTFiYlMrZkM5WktkWWhIVkVJbkJqNlRoVTFjZTR4RzI3VGxYdUR4?=
 =?utf-8?B?c2lQQjhOYVdRcWVJUzVBNnBFSVNmQUlHbVhBY2VkR2VlNE0wYnJxWTlGYVY4?=
 =?utf-8?B?U0plblIyOXA2WnFNVlhTaW12QWx0VWwxeGFONFRNZ1NhVy9qVjRRU0ZzSGV4?=
 =?utf-8?B?UGFkNWM5bnBGSnRaK01oQ1NXNEdCTEs3cllmbTAwalROYStZOEZySWwzclkr?=
 =?utf-8?B?VWVIcTM4cHd6TmdGSjhDQkE5a1JvNi9LcWtHR1diNmxkWEZ2SU9tSVpXVDhi?=
 =?utf-8?B?R0xOcVR2N0h0MG80cWorbWJySk1vUG1UQVg5ZUNFZSt2MysraGx0WFkzYUtB?=
 =?utf-8?B?Y3ZCcXNuc2s1d2tEdkRKRnhqNXd3V0ZVS3lnclFSWTFGc3dOdEwyWWdXWVdv?=
 =?utf-8?B?YjlNaWVDMGlKckhIR3M2aG0zSzVCTDFocFNSYldjbmRDTm1LOTNqTEVPUW1O?=
 =?utf-8?B?SWlhYWhDS2x3OXdtbVhoYlhwTWNiWmwveWRMRFJQc1JpbUZuN0FNTjdHM05v?=
 =?utf-8?B?c0NDYlR2enBtYjJ6Sk9nRUgxWUlmT2tBOHBscVZGYWF1YllyNVRlWkFTSEFx?=
 =?utf-8?B?dTlxNmtlKzg4WDYvc3RjOVlhQlh3RGVrUVI1VUwvOXppOWRxa1J1MTYvcHpT?=
 =?utf-8?B?cTc5S3ZFV2llUVB0WTJRcWR4elc4YVlpS0dKYlZtWTNrTE9jd2g3ZFFFQjJr?=
 =?utf-8?B?SlVCUjR5YnBHa3N4K3NKUExYNVRhK1NKUWErWGhDQkdjUVlyZHhEaWNJd01W?=
 =?utf-8?B?cW9YcjFlN2x2U0puRzlreTIySDBEMCs0ZXQ3aWt3YXJEMjJGQzhJQXp0bDg1?=
 =?utf-8?B?bk92YTJGMmc4eTJxTTR0LzhoSm9Jb2g4ZCtNTnhnUUpEY29Kd2xYTUtMVnhK?=
 =?utf-8?B?Y29kK2pQOXl2SEdxNk02bWI2OWdqM2Z0cUNkSDZRcHcvVFNXTTZrb2RNWGp5?=
 =?utf-8?B?MmdzYUE0aDRCRVR2eFUrQy9MUzVBbkVnMjFFZ3loZWR4ZnFobkpPSWV2VjBN?=
 =?utf-8?B?d3czUnFWSU9hc3NJUU96NFZrY2xYcWFhbEI2b2VORGNRZXFVMXhVbk5mWDN6?=
 =?utf-8?B?SDlaVkF0bm5QREc2eUEyRldMeFV1cDBtZThscHFUa0N5RUxZd1pQLzlLK0Uz?=
 =?utf-8?Q?mW6JcgeGd/8lyTWttyajTQw=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 49ce92a2-fa92-422f-4f1a-08d9f527055c
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2022 10:43:39.3194
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: w+113Il728xElcLlJvPze8Gx/n6B6rmFo5CEm4b1gG/ceUqNDVTYrIlBl267Ot5OSEX7EuCUDVUXvlo2qld/zA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB3474
X-OriginatorOrg: citrix.com

On Mon, Feb 21, 2022 at 10:02:52AM +0000, Andrew Cooper wrote:
> It the 'addr' input to mmap(), and currently consuming stack rubble.
> 
> Coverity-ID: 1500115
> Fixes: c7a7f14b9299 ("tests/resource: Extend to check that the grant frames are mapped correctly")
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Feb 21 10:51:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 21 Feb 2022 10:51:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276093.472161 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM6HT-0006et-Nf; Mon, 21 Feb 2022 10:50:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276093.472161; Mon, 21 Feb 2022 10:50:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM6HT-0006bz-D3; Mon, 21 Feb 2022 10:50:59 +0000
Received: by outflank-mailman (input) for mailman id 276093;
 Mon, 21 Feb 2022 10:50:57 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nM6HR-0006Q5-Q7
 for xen-devel@lists.xenproject.org; Mon, 21 Feb 2022 10:50:57 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nM6HR-0002lf-Ff; Mon, 21 Feb 2022 10:50:57 +0000
Received: from 54-240-197-232.amazon.com ([54.240.197.232]
 helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com)
 by xenbits.xenproject.org with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nM5q2-00070b-Px; Mon, 21 Feb 2022 10:22:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References:
	In-Reply-To:Message-Id:Date:Subject:Cc:To:From;
	bh=ircv52tCd8GVVO1Y1H28ZgnoiMPLWO4TwQBUEqK5CEg=; b=Xv0S9neTaH+451IW1pwoDwNDfa
	vaXPqblQTGO6fwUSpEJkWaTW/1YQZQVLJ2+3ikbeIk7ouhtWqwWeJxYf4LuNS4Du2IMoSeoLdT6N6
	/yImBSUG0m8yuK9WMQfefLasIre8tUCoTAGpanTQ723A9yZMFN+UNsfPdowMrvnlV7cI=;
From: Julien Grall <julien@xen.org>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	Julien Grall <jgrall@amazon.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH v3 15/19] xen/arm: mm: Clean-up the includes and order them
Date: Mon, 21 Feb 2022 10:22:14 +0000
Message-Id: <20220221102218.33785-16-julien@xen.org>
X-Mailer: git-send-email 2.32.0
In-Reply-To: <20220221102218.33785-1-julien@xen.org>
References: <20220221102218.33785-1-julien@xen.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Julien Grall <jgrall@amazon.com>

The numbers of includes in mm.c has been growing quite a lot. However
some of them (e.g. xen/device_tree.h, xen/softirq.h) doesn't look
to be directly used by the file or other will be included by
larger headers (e.g asm/flushtlb.h will be included by xen/mm.h).

So trim down the number of includes. Take the opportunity to order
them with the xen headers first, then asm headers and last public
headers.

Signed-off-by: Julien Grall <jgrall@amazon.com>

---
    Changes in v3:
        - Patch added
---
 xen/arch/arm/mm.c | 27 ++++++++++-----------------
 1 file changed, 10 insertions(+), 17 deletions(-)

diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
index b7942464d4de..659bdf25e0ff 100644
--- a/xen/arch/arm/mm.c
+++ b/xen/arch/arm/mm.c
@@ -17,33 +17,26 @@
  * GNU General Public License for more details.
  */
 
-#include <xen/compile.h>
-#include <xen/types.h>
-#include <xen/device_tree.h>
-#include <xen/init.h>
-#include <xen/mm.h>
-#include <xen/preempt.h>
+#include <xen/domain_page.h>
 #include <xen/errno.h>
 #include <xen/grant_table.h>
-#include <xen/softirq.h>
-#include <xen/event.h>
 #include <xen/guest_access.h>
-#include <xen/domain_page.h>
-#include <xen/err.h>
-#include <asm/page.h>
-#include <asm/current.h>
-#include <asm/flushtlb.h>
-#include <public/memory.h>
+#include <xen/init.h>
+#include <xen/libfdt/libfdt.h>
+#include <xen/mm.h>
+#include <xen/pfn.h>
 #include <xen/sched.h>
+#include <xen/sizes.h>
+#include <xen/types.h>
 #include <xen/vmap.h>
+
 #include <xsm/xsm.h>
-#include <xen/pfn.h>
-#include <xen/sizes.h>
-#include <xen/libfdt/libfdt.h>
 
 #include <asm/fixmap.h>
 #include <asm/setup.h>
 
+#include <public/memory.h>
+
 /* Override macros from asm/page.h to make them work with mfn_t */
 #undef virt_to_mfn
 #define virt_to_mfn(va) _mfn(__virt_to_mfn(va))
-- 
2.32.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 21 10:51:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 21 Feb 2022 10:51:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276090.472144 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM6HS-0006QQ-GM; Mon, 21 Feb 2022 10:50:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276090.472144; Mon, 21 Feb 2022 10:50:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM6HS-0006QH-Az; Mon, 21 Feb 2022 10:50:58 +0000
Received: by outflank-mailman (input) for mailman id 276090;
 Mon, 21 Feb 2022 10:50:57 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nM6HR-0006Pn-I8
 for xen-devel@lists.xenproject.org; Mon, 21 Feb 2022 10:50:57 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nM6HR-0002lS-6D; Mon, 21 Feb 2022 10:50:57 +0000
Received: from 54-240-197-232.amazon.com ([54.240.197.232]
 helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com)
 by xenbits.xenproject.org with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nM5pw-00070b-Q2; Mon, 21 Feb 2022 10:22:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References:
	In-Reply-To:Message-Id:Date:Subject:Cc:To:From;
	bh=zEuypYbMOVU+QCEpQRIrLKSHSHuGJNjHPBiDujcG7MU=; b=oD4C8Xy85gKcZSzamwua69gzJh
	vwmWHW3VGsBHpotI4HnvBmxqIi3fJRGT/PtfWcILV3mCMobBjoTKgwF+P8BkoX4Z+NMHHFrMbh05t
	l82nYJCrb5EbAVvUVtuPLZVSqH4FEwWBlOgZJykIVF/kxIFvVb5hzb8a5B2LzLPYzL/Y=;
From: Julien Grall <julien@xen.org>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	Julien Grall <jgrall@amazon.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH v3 10/19] xen/arm32: mm: Re-implement setup_xenheap_mappings() using map_pages_to_xen()
Date: Mon, 21 Feb 2022 10:22:09 +0000
Message-Id: <20220221102218.33785-11-julien@xen.org>
X-Mailer: git-send-email 2.32.0
In-Reply-To: <20220221102218.33785-1-julien@xen.org>
References: <20220221102218.33785-1-julien@xen.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Julien Grall <jgrall@amazon.com>

Now that map_pages_to_xen() has been extended to support 2MB mappings,
we can replace the create_mappings() call by map_pages_to_xen() call.

Signed-off-by: Julien Grall <jgrall@amazon.com>

---
    Changes in v3:
        - Fix build when CONFIG_DEBUG=y

    Changes in v2:
        - New patch

    TODOs:
        - add support for contiguous mapping
---
 xen/arch/arm/mm.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
index f18f65745595..1e5c2c45dcf9 100644
--- a/xen/arch/arm/mm.c
+++ b/xen/arch/arm/mm.c
@@ -809,7 +809,12 @@ void mmu_init_secondary_cpu(void)
 void __init setup_xenheap_mappings(unsigned long base_mfn,
                                    unsigned long nr_mfns)
 {
-    create_mappings(xen_second, XENHEAP_VIRT_START, base_mfn, nr_mfns, MB(32));
+    int rc;
+
+    rc = map_pages_to_xen(XENHEAP_VIRT_START, _mfn(base_mfn), nr_mfns,
+                          PAGE_HYPERVISOR_RW | _PAGE_BLOCK);
+    if ( rc )
+        panic("Unable to setup the xenheap mappings.\n");
 
     /* Record where the xenheap is, for translation routines. */
     xenheap_virt_end = XENHEAP_VIRT_START + nr_mfns * PAGE_SIZE;
-- 
2.32.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 21 10:51:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 21 Feb 2022 10:51:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276091.472149 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM6HS-0006Su-Rv; Mon, 21 Feb 2022 10:50:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276091.472149; Mon, 21 Feb 2022 10:50:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM6HS-0006RM-Jb; Mon, 21 Feb 2022 10:50:58 +0000
Received: by outflank-mailman (input) for mailman id 276091;
 Mon, 21 Feb 2022 10:50:57 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nM6HR-0006Po-Hh
 for xen-devel@lists.xenproject.org; Mon, 21 Feb 2022 10:50:57 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nM6HR-0002lU-8Y; Mon, 21 Feb 2022 10:50:57 +0000
Received: from 54-240-197-232.amazon.com ([54.240.197.232]
 helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com)
 by xenbits.xenproject.org with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nM5py-00070b-R6; Mon, 21 Feb 2022 10:22:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References:
	In-Reply-To:Message-Id:Date:Subject:Cc:To:From;
	bh=f03/3Vf/UCt5JQLkCjdrbloKJVprsUR48KaiuBmSgTo=; b=hiMhKzUPL64NsMAqmJd0Lk1PkD
	DJSjYDBI5vU5yLcg4P1nWPCTuyPHBADK9kZ/irp1z9TFfuVQgpyvmiU9PsIxJkOpo9UcAkQPeWN90
	rr7vUIZAReVu/w4TKR92qz3FYyhvV8vcFgR1Q+m6BeyNaEEiM8b53E2fx65jka4DY1dQ=;
From: Julien Grall <julien@xen.org>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	Julien Grall <julien.grall@arm.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Julien Grall <jgrall@amazon.com>
Subject: [PATCH v3 12/19] xen/arm: mm: Allow page-table allocation from the boot allocator
Date: Mon, 21 Feb 2022 10:22:11 +0000
Message-Id: <20220221102218.33785-13-julien@xen.org>
X-Mailer: git-send-email 2.32.0
In-Reply-To: <20220221102218.33785-1-julien@xen.org>
References: <20220221102218.33785-1-julien@xen.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Julien Grall <julien.grall@arm.com>

At the moment, page-table can only be allocated from domheap. This means
it is not possible to create mapping in the page-tables via
map_pages_to_xen() if page-table needs to be allocated.

In order to avoid open-coding page-tables update in early boot, we need
to be able to allocate page-tables much earlier. Thankfully, we have the
boot allocator for those cases.

create_xen_table() is updated to cater early boot allocation by using
alloc_boot_pages().

Note, this is not sufficient to bootstrap the page-tables (i.e mapping
before any memory is actually mapped). This will be addressed
separately.

Signed-off-by: Julien Grall <julien.grall@arm.com>
Signed-off-by: Julien Grall <jgrall@amazon.com>

---
    Changes in v2:
        - New patch
---
 xen/arch/arm/mm.c | 20 ++++++++++++++------
 1 file changed, 14 insertions(+), 6 deletions(-)

diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
index 58364bb6c820..f70b8cc7ce87 100644
--- a/xen/arch/arm/mm.c
+++ b/xen/arch/arm/mm.c
@@ -1014,19 +1014,27 @@ static void xen_unmap_table(const lpae_t *table)
 
 static int create_xen_table(lpae_t *entry)
 {
-    struct page_info *pg;
+    mfn_t mfn;
     void *p;
     lpae_t pte;
 
-    pg = alloc_domheap_page(NULL, 0);
-    if ( pg == NULL )
-        return -ENOMEM;
+    if ( system_state != SYS_STATE_early_boot )
+    {
+        struct page_info *pg = alloc_domheap_page(NULL, 0);
+
+        if ( pg == NULL )
+            return -ENOMEM;
+
+        mfn = page_to_mfn(pg);
+    }
+    else
+        mfn = alloc_boot_pages(1, 1);
 
-    p = xen_map_table(page_to_mfn(pg));
+    p = xen_map_table(mfn);
     clear_page(p);
     xen_unmap_table(p);
 
-    pte = mfn_to_xen_entry(page_to_mfn(pg), MT_NORMAL);
+    pte = mfn_to_xen_entry(mfn, MT_NORMAL);
     pte.pt.table = 1;
     write_pte(entry, pte);
 
-- 
2.32.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 21 10:51:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 21 Feb 2022 10:51:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276092.472155 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM6HT-0006XX-9s; Mon, 21 Feb 2022 10:50:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276092.472155; Mon, 21 Feb 2022 10:50:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM6HS-0006VG-Vk; Mon, 21 Feb 2022 10:50:58 +0000
Received: by outflank-mailman (input) for mailman id 276092;
 Mon, 21 Feb 2022 10:50:57 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nM6HR-0006Pp-JL
 for xen-devel@lists.xenproject.org; Mon, 21 Feb 2022 10:50:57 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nM6HR-0002lW-AS; Mon, 21 Feb 2022 10:50:57 +0000
Received: from 54-240-197-232.amazon.com ([54.240.197.232]
 helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com)
 by xenbits.xenproject.org with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nM5q3-00070b-Ox; Mon, 21 Feb 2022 10:22:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References:
	In-Reply-To:Message-Id:Date:Subject:Cc:To:From;
	bh=WOeJ/LVD52L5YzIcVNL+IXQBycQP2W2GDSj+IqdQKo0=; b=x+HtDP7Wbuvk3vQTsEi+QK12Li
	yB+qv9oUO2OZ/C4B90il6KJSWmgKDLSYR6JqRakY7/h4RIZebuwkJiU+P9LtaJdF0feLie1xCPF5D
	/eoMlp7ZPl9eqyXZBaRfbtlGAruV/du5M6f2hjQyoe3xZ8hFu4/fk8yVutc4na/H1AzI=;
From: Julien Grall <julien@xen.org>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	Julien Grall <jgrall@amazon.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH v3 16/19] xen/arm: mm: Use the PMAP helpers in xen_{,un}map_table()
Date: Mon, 21 Feb 2022 10:22:15 +0000
Message-Id: <20220221102218.33785-17-julien@xen.org>
X-Mailer: git-send-email 2.32.0
In-Reply-To: <20220221102218.33785-1-julien@xen.org>
References: <20220221102218.33785-1-julien@xen.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Julien Grall <jgrall@amazon.com>

During early boot, it is not possible to use xen_{,un}map_table()
if the page tables are not residing the Xen binary.

This is a blocker to switch some of the helpers to use xen_pt_update()
as we may need to allocate extra page tables and access them before
the domheap has been initialized (see setup_xenheap_mappings()).

xen_{,un}map_table() are now updated to use the PMAP helpers for early
boot map/unmap. Note that the special case for page-tables residing
in Xen binary has been dropped because it is "complex" and was
only added as a workaround in 8d4f1b8878e0 ("xen/arm: mm: Allow
generic xen page-tables helpers to be called early").

Signed-off-by: Julien Grall <jgrall@amazon.com>

---
    Changes in v2:
        - New patch
---
 xen/arch/arm/mm.c | 33 +++++++++------------------------
 1 file changed, 9 insertions(+), 24 deletions(-)

diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
index 659bdf25e0ff..11b6b60a2bc1 100644
--- a/xen/arch/arm/mm.c
+++ b/xen/arch/arm/mm.c
@@ -25,6 +25,7 @@
 #include <xen/libfdt/libfdt.h>
 #include <xen/mm.h>
 #include <xen/pfn.h>
+#include <xen/pmap.h>
 #include <xen/sched.h>
 #include <xen/sizes.h>
 #include <xen/types.h>
@@ -964,27 +965,11 @@ void *ioremap(paddr_t pa, size_t len)
 static lpae_t *xen_map_table(mfn_t mfn)
 {
     /*
-     * We may require to map the page table before map_domain_page() is
-     * useable. The requirements here is it must be useable as soon as
-     * page-tables are allocated dynamically via alloc_boot_pages().
-     *
-     * We need to do the check on physical address rather than virtual
-     * address to avoid truncation on Arm32. Therefore is_kernel() cannot
-     * be used.
+     * During early boot, map_domain_page() may be unusable. Use the
+     * PMAP to map temporarily a page-table.
      */
     if ( system_state == SYS_STATE_early_boot )
-    {
-        if ( is_xen_fixed_mfn(mfn) )
-        {
-            /*
-             * It is fine to demote the type because the size of Xen
-             * will always fit in vaddr_t.
-             */
-            vaddr_t offset = mfn_to_maddr(mfn) - virt_to_maddr(&_start);
-
-            return (lpae_t *)(XEN_VIRT_START + offset);
-        }
-    }
+        return pmap_map(mfn);
 
     return map_domain_page(mfn);
 }
@@ -993,12 +978,12 @@ static void xen_unmap_table(const lpae_t *table)
 {
     /*
      * During early boot, xen_map_table() will not use map_domain_page()
-     * for page-tables residing in Xen binary. So skip the unmap part.
+     * but the PMAP.
      */
-    if ( system_state == SYS_STATE_early_boot && is_kernel(table) )
-        return;
-
-    unmap_domain_page(table);
+    if ( system_state == SYS_STATE_early_boot )
+        pmap_unmap(table);
+    else
+        unmap_domain_page(table);
 }
 
 static int create_xen_table(lpae_t *entry)
-- 
2.32.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 21 10:51:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 21 Feb 2022 10:51:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276095.472182 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM6HV-00077Z-5j; Mon, 21 Feb 2022 10:51:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276095.472182; Mon, 21 Feb 2022 10:51:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM6HU-00073Q-OT; Mon, 21 Feb 2022 10:51:00 +0000
Received: by outflank-mailman (input) for mailman id 276095;
 Mon, 21 Feb 2022 10:50:58 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nM6HS-0006QN-CA
 for xen-devel@lists.xenproject.org; Mon, 21 Feb 2022 10:50:58 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nM6HR-0002lY-C0; Mon, 21 Feb 2022 10:50:57 +0000
Received: from 54-240-197-232.amazon.com ([54.240.197.232]
 helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com)
 by xenbits.xenproject.org with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nM5px-00070b-P2; Mon, 21 Feb 2022 10:22:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References:
	In-Reply-To:Message-Id:Date:Subject:Cc:To:From;
	bh=hWjfevoUxZaDKcehRUZH+C4jM8zdEI8w51IWDQgtbOY=; b=RuUM164HznDXh6/dLShCUL7Lum
	EgpxRX1vKp5TmYi/aA/2lysuQY0Qdha+xIARUS7HqNl8nQjr9/2Nf1+AV/5IB7+NQMaTd0ueMU/Sj
	NV1g+ENGfjBa69WssNjj2ehEeY9/yty7yDBH+2WREYgwIIcfvU7MxEf4gKZMBEiLDmGo=;
From: Julien Grall <julien@xen.org>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	Julien Grall <jgrall@amazon.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH v3 11/19] xen/arm: mm: Allocate xen page tables in domheap rather than xenheap
Date: Mon, 21 Feb 2022 10:22:10 +0000
Message-Id: <20220221102218.33785-12-julien@xen.org>
X-Mailer: git-send-email 2.32.0
In-Reply-To: <20220221102218.33785-1-julien@xen.org>
References: <20220221102218.33785-1-julien@xen.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Julien Grall <jgrall@amazon.com>

xen_{un,}map_table() already uses the helper to map/unmap pages
on-demand (note this is currently a NOP on arm64). So switching to
domheap don't have any disavantage.

But this as the benefit:
    - to keep the page tables unmapped if an arch decided to do so
    - reduce xenheap use on arm32 which can be pretty small

Signed-off-by: Julien Grall <jgrall@amazon.com>
Acked-by: Stefano Stabellini <sstabellini@kernel.org>

---
    Changes in v3:
        - Add Stefano's acked-by

    Changes in v2:
        - New patch
---
 xen/arch/arm/mm.c | 36 +++++++++++++++++++++---------------
 1 file changed, 21 insertions(+), 15 deletions(-)

diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
index 1e5c2c45dcf9..58364bb6c820 100644
--- a/xen/arch/arm/mm.c
+++ b/xen/arch/arm/mm.c
@@ -972,21 +972,6 @@ void *ioremap(paddr_t pa, size_t len)
     return ioremap_attr(pa, len, PAGE_HYPERVISOR_NOCACHE);
 }
 
-static int create_xen_table(lpae_t *entry)
-{
-    void *p;
-    lpae_t pte;
-
-    p = alloc_xenheap_page();
-    if ( p == NULL )
-        return -ENOMEM;
-    clear_page(p);
-    pte = mfn_to_xen_entry(virt_to_mfn(p), MT_NORMAL);
-    pte.pt.table = 1;
-    write_pte(entry, pte);
-    return 0;
-}
-
 static lpae_t *xen_map_table(mfn_t mfn)
 {
     /*
@@ -1027,6 +1012,27 @@ static void xen_unmap_table(const lpae_t *table)
     unmap_domain_page(table);
 }
 
+static int create_xen_table(lpae_t *entry)
+{
+    struct page_info *pg;
+    void *p;
+    lpae_t pte;
+
+    pg = alloc_domheap_page(NULL, 0);
+    if ( pg == NULL )
+        return -ENOMEM;
+
+    p = xen_map_table(page_to_mfn(pg));
+    clear_page(p);
+    xen_unmap_table(p);
+
+    pte = mfn_to_xen_entry(page_to_mfn(pg), MT_NORMAL);
+    pte.pt.table = 1;
+    write_pte(entry, pte);
+
+    return 0;
+}
+
 #define XEN_TABLE_MAP_FAILED 0
 #define XEN_TABLE_SUPER_PAGE 1
 #define XEN_TABLE_NORMAL_PAGE 2
-- 
2.32.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 21 10:51:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 21 Feb 2022 10:51:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276094.472169 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM6HU-0006oX-9a; Mon, 21 Feb 2022 10:51:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276094.472169; Mon, 21 Feb 2022 10:51:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM6HT-0006mE-Sl; Mon, 21 Feb 2022 10:50:59 +0000
Received: by outflank-mailman (input) for mailman id 276094;
 Mon, 21 Feb 2022 10:50:58 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nM6HS-0006QB-15
 for xen-devel@lists.xenproject.org; Mon, 21 Feb 2022 10:50:58 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nM6HR-0002la-Dw; Mon, 21 Feb 2022 10:50:57 +0000
Received: from 54-240-197-232.amazon.com ([54.240.197.232]
 helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com)
 by xenbits.xenproject.org with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nM5q0-00070b-6H; Mon, 21 Feb 2022 10:22:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References:
	In-Reply-To:Message-Id:Date:Subject:Cc:To:From;
	bh=0MbMCc6Fc4nKPqui2STMDRF8WroiVRuB9EZOJsrT/c4=; b=oS0peln7Lspnp759qq8L0fNVa4
	8OeCfzCZhy2QJPHOQNYj48rY1uyWerg7d1ijkcAI8nRzwhY9YCCbEhK2m9L43ZGHsBmTa6cz9ZKrb
	Oky5hwhDLv793A14iRsks2Eh/CkzQM/6l1Gk3wDJgJ/Ko1kwiVT2j80bxMS3wjWYBgpY=;
From: Julien Grall <julien@xen.org>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	Julien Grall <jgrall@amazon.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Wei Liu <wl@xen.org>
Subject: [PATCH v3 13/19] xen/arm: Move fixmap definitions in a separate header
Date: Mon, 21 Feb 2022 10:22:12 +0000
Message-Id: <20220221102218.33785-14-julien@xen.org>
X-Mailer: git-send-email 2.32.0
In-Reply-To: <20220221102218.33785-1-julien@xen.org>
References: <20220221102218.33785-1-julien@xen.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Julien Grall <jgrall@amazon.com>

To use properly the fixmap definitions, their user would need
also new to include <xen/acpi.h>. This is not very great when
the user itself is not meant to directly use ACPI definitions.

Including <xen/acpi.h> in <asm/config.h> is not option because
the latter header is included by everyone. So move out the fixmap
entries definition in a new header.

Take the opportunity to also move {set, clear}_fixmap() prototypes
in the new header.

Note that most of the definitions in <xen/acpi.h> now need to be
surrounded with #ifndef __ASSEMBLY__ because <asm/fixmap.h> will
be used in assembly (see EARLY_UART_VIRTUAL_ADDRESS).

The split will become more helpful in a follow-up patch where new
fixmap entries will be defined.

Signed-off-by: Julien Grall <jgrall@amazon.com>

---
    Changes in v3:
        - Patch added
---
 xen/arch/arm/acpi/lib.c                 |  2 ++
 xen/arch/arm/include/asm/config.h       |  6 ------
 xen/arch/arm/include/asm/early_printk.h |  1 +
 xen/arch/arm/include/asm/fixmap.h       | 24 ++++++++++++++++++++++++
 xen/arch/arm/include/asm/mm.h           |  4 ----
 xen/arch/arm/kernel.c                   |  1 +
 xen/arch/arm/mm.c                       |  1 +
 xen/include/xen/acpi.h                  | 18 +++++++++++-------
 8 files changed, 40 insertions(+), 17 deletions(-)
 create mode 100644 xen/arch/arm/include/asm/fixmap.h

diff --git a/xen/arch/arm/acpi/lib.c b/xen/arch/arm/acpi/lib.c
index a59cc4074cfb..41d521f720ac 100644
--- a/xen/arch/arm/acpi/lib.c
+++ b/xen/arch/arm/acpi/lib.c
@@ -25,6 +25,8 @@
 #include <xen/init.h>
 #include <xen/mm.h>
 
+#include <asm/fixmap.h>
+
 static bool fixmap_inuse;
 
 char *__acpi_map_table(paddr_t phys, unsigned long size)
diff --git a/xen/arch/arm/include/asm/config.h b/xen/arch/arm/include/asm/config.h
index 85d4a510ce8a..51908bf9422c 100644
--- a/xen/arch/arm/include/asm/config.h
+++ b/xen/arch/arm/include/asm/config.h
@@ -175,12 +175,6 @@
 
 #endif
 
-/* Fixmap slots */
-#define FIXMAP_CONSOLE  0  /* The primary UART */
-#define FIXMAP_MISC     1  /* Ephemeral mappings of hardware */
-#define FIXMAP_ACPI_BEGIN  2  /* Start mappings of ACPI tables */
-#define FIXMAP_ACPI_END    (FIXMAP_ACPI_BEGIN + NUM_FIXMAP_ACPI_PAGES - 1)  /* End mappings of ACPI tables */
-
 #define NR_hypercalls 64
 
 #define STACK_ORDER 3
diff --git a/xen/arch/arm/include/asm/early_printk.h b/xen/arch/arm/include/asm/early_printk.h
index 8dc911cf48a3..c5149b2976da 100644
--- a/xen/arch/arm/include/asm/early_printk.h
+++ b/xen/arch/arm/include/asm/early_printk.h
@@ -11,6 +11,7 @@
 #define __ARM_EARLY_PRINTK_H__
 
 #include <xen/page-size.h>
+#include <asm/fixmap.h>
 
 #ifdef CONFIG_EARLY_PRINTK
 
diff --git a/xen/arch/arm/include/asm/fixmap.h b/xen/arch/arm/include/asm/fixmap.h
new file mode 100644
index 000000000000..1cee51e52ab9
--- /dev/null
+++ b/xen/arch/arm/include/asm/fixmap.h
@@ -0,0 +1,24 @@
+/*
+ * fixmap.h: compile-time virtual memory allocation
+ */
+#ifndef __ASM_FIXMAP_H
+#define __ASM_FIXMAP_H
+
+#include <xen/acpi.h>
+
+/* Fixmap slots */
+#define FIXMAP_CONSOLE  0  /* The primary UART */
+#define FIXMAP_MISC     1  /* Ephemeral mappings of hardware */
+#define FIXMAP_ACPI_BEGIN  2  /* Start mappings of ACPI tables */
+#define FIXMAP_ACPI_END    (FIXMAP_ACPI_BEGIN + NUM_FIXMAP_ACPI_PAGES - 1)  /* End mappings of ACPI tables */
+
+#ifndef __ASSEMBLY__
+
+/* Map a page in a fixmap entry */
+extern void set_fixmap(unsigned map, mfn_t mfn, unsigned attributes);
+/* Remove a mapping from a fixmap entry */
+extern void clear_fixmap(unsigned map);
+
+#endif /* __ASSEMBLY__ */
+
+#endif /* __ASM_FIXMAP_H */
diff --git a/xen/arch/arm/include/asm/mm.h b/xen/arch/arm/include/asm/mm.h
index 424aaf28230b..045a8ba4bb63 100644
--- a/xen/arch/arm/include/asm/mm.h
+++ b/xen/arch/arm/include/asm/mm.h
@@ -191,10 +191,6 @@ extern void mmu_init_secondary_cpu(void);
 extern void setup_xenheap_mappings(unsigned long base_mfn, unsigned long nr_mfns);
 /* Map a frame table to cover physical addresses ps through pe */
 extern void setup_frametable_mappings(paddr_t ps, paddr_t pe);
-/* Map a 4k page in a fixmap entry */
-extern void set_fixmap(unsigned map, mfn_t mfn, unsigned attributes);
-/* Remove a mapping from a fixmap entry */
-extern void clear_fixmap(unsigned map);
 /* map a physical range in virtual memory */
 void __iomem *ioremap_attr(paddr_t start, size_t len, unsigned attributes);
 
diff --git a/xen/arch/arm/kernel.c b/xen/arch/arm/kernel.c
index 8f43caa1866d..25ded1c056d9 100644
--- a/xen/arch/arm/kernel.c
+++ b/xen/arch/arm/kernel.c
@@ -15,6 +15,7 @@
 #include <xen/vmap.h>
 
 #include <asm/byteorder.h>
+#include <asm/fixmap.h>
 #include <asm/kernel.h>
 #include <asm/setup.h>
 
diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
index f70b8cc7ce87..d6a4b9407c43 100644
--- a/xen/arch/arm/mm.c
+++ b/xen/arch/arm/mm.c
@@ -41,6 +41,7 @@
 #include <xen/sizes.h>
 #include <xen/libfdt/libfdt.h>
 
+#include <asm/fixmap.h>
 #include <asm/setup.h>
 
 /* Override macros from asm/page.h to make them work with mfn_t */
diff --git a/xen/include/xen/acpi.h b/xen/include/xen/acpi.h
index 08834f140266..500aaa538551 100644
--- a/xen/include/xen/acpi.h
+++ b/xen/include/xen/acpi.h
@@ -28,6 +28,15 @@
 #define _LINUX
 #endif
 
+/*
+ * Fixmap pages to reserve for ACPI boot-time tables (see
+ * arch/x86/include/asm/fixmap.h or arch/arm/include/asm/fixmap.h),
+ * 64 pages(256KB) is large enough for most cases.)
+ */
+#define NUM_FIXMAP_ACPI_PAGES  64
+
+#ifndef __ASSEMBLY__
+
 #include <xen/list.h>
 
 #include <acpi/acpi.h>
@@ -39,13 +48,6 @@
 #define ACPI_MADT_GET_POLARITY(inti)	ACPI_MADT_GET_(POLARITY, inti)
 #define ACPI_MADT_GET_TRIGGER(inti)	ACPI_MADT_GET_(TRIGGER, inti)
 
-/*
- * Fixmap pages to reserve for ACPI boot-time tables (see
- * arch/x86/include/asm/fixmap.h or arch/arm/include/asm/config.h,
- * 64 pages(256KB) is large enough for most cases.)
- */
-#define NUM_FIXMAP_ACPI_PAGES  64
-
 #define BAD_MADT_ENTRY(entry, end) (                                        \
                 (!(entry)) || (unsigned long)(entry) + sizeof(*(entry)) > (end) ||  \
                 (entry)->header.length < sizeof(*(entry)))
@@ -207,4 +209,6 @@ void acpi_reboot(void);
 void acpi_dmar_zap(void);
 void acpi_dmar_reinstate(void);
 
+#endif /* __ASSEMBLY__ */
+
 #endif /*_LINUX_ACPI_H*/
-- 
2.32.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 21 10:51:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 21 Feb 2022 10:51:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276097.472192 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM6HV-0007HO-RO; Mon, 21 Feb 2022 10:51:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276097.472192; Mon, 21 Feb 2022 10:51:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM6HV-0007DS-7t; Mon, 21 Feb 2022 10:51:01 +0000
Received: by outflank-mailman (input) for mailman id 276097;
 Mon, 21 Feb 2022 10:50:58 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nM6HS-0006Sg-MD
 for xen-devel@lists.xenproject.org; Mon, 21 Feb 2022 10:50:58 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nM6HR-0002lr-Js; Mon, 21 Feb 2022 10:50:57 +0000
Received: from 54-240-197-232.amazon.com ([54.240.197.232]
 helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com)
 by xenbits.xenproject.org with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nM5q1-00070b-R0; Mon, 21 Feb 2022 10:22:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:MIME-Version:
	References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From;
	bh=vpQruBgrefHFrUQ/LCTSC1M9bnsWKZKjMmpBwte2ato=; b=jplxBhar50D+va8ChkMHyh1sg3
	+pfFUZKJIZ18i6/RxtGgSiUeLxNQWnPhIfBadRviVnTBhWKv2bsC0S1V1E79X4vRV9RqMAVHIAOIy
	0uGSPN1IdDUlJ4qiy8vaStWjEDHd8KOfkMJwJ46/7Dj35BCMNAHcJFucd9FZl4oFqWkw=;
From: Julien Grall <julien@xen.org>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	Wei Liu <wei.liu2@citrix.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Hongyan Xia <hongyxia@amazon.com>,
	Julien Grall <jgrall@amazon.com>,
	Jan Beulich <jbeulich@suse.com>,
	Wei Liu <wl@xen.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>
Subject: [PATCH v3 14/19] xen/arm: add Persistent Map (PMAP) infrastructure
Date: Mon, 21 Feb 2022 10:22:13 +0000
Message-Id: <20220221102218.33785-15-julien@xen.org>
X-Mailer: git-send-email 2.32.0
In-Reply-To: <20220221102218.33785-1-julien@xen.org>
References: <20220221102218.33785-1-julien@xen.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

From: Wei Liu <wei.liu2@citrix.com>

The basic idea is like Persistent Kernel Map (PKMAP) in Linux. We
pre-populate all the relevant page tables before the system is fully
set up.

We will need it on Arm in order to rework the arm64 version of
xenheap_setup_mappings() as we may need to use pages allocated from
the boot allocator before they are effectively mapped.

This infrastructure is not lock-protected therefore can only be used
before smpboot. After smpboot, map_domain_page() has to be used.

This is based on the x86 version [1] that was originally implemented
by Wei Liu.

The PMAP infrastructure is implemented in common code with some
arch helpers to set/clear the page-table entries and convertion
between a fixmap slot to a virtual address...

As mfn_to_xen_entry() now needs to be exported, take the opportunity
to swich the parameter attr from unsigned to unsigned int.

[1] <e92da4ad6015b6089737fcccba3ec1d6424649a5.1588278317.git.hongyxia@amazon.com>

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Signed-off-by: Hongyan Xia <hongyxia@amazon.com>
[julien: Adapted for Arm]
Signed-off-by: Julien Grall <jgrall@amazon.com>

---
    Changes in v3:
        - s/BITS_PER_LONG/BITS_PER_BYTE/
        - Move pmap to common code

    Changes in v2:
        - New patch

Cc: Jan Beulich <jbeulich@suse.com>
Cc: Wei Liu <wl@xen.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Roger Pau Monné <roger.pau@citrix.com>
---
 xen/arch/arm/Kconfig              |  1 +
 xen/arch/arm/include/asm/fixmap.h | 17 +++++++
 xen/arch/arm/include/asm/lpae.h   |  8 ++++
 xen/arch/arm/include/asm/pmap.h   | 33 +++++++++++++
 xen/arch/arm/mm.c                 |  7 +--
 xen/common/Kconfig                |  3 ++
 xen/common/Makefile               |  1 +
 xen/common/pmap.c                 | 79 +++++++++++++++++++++++++++++++
 xen/include/xen/pmap.h            | 16 +++++++
 9 files changed, 159 insertions(+), 6 deletions(-)
 create mode 100644 xen/arch/arm/include/asm/pmap.h
 create mode 100644 xen/common/pmap.c
 create mode 100644 xen/include/xen/pmap.h

diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
index ecfa6822e4d3..a89a67802aa9 100644
--- a/xen/arch/arm/Kconfig
+++ b/xen/arch/arm/Kconfig
@@ -14,6 +14,7 @@ config ARM
 	select HAS_DEVICE_TREE
 	select HAS_PASSTHROUGH
 	select HAS_PDX
+	select HAS_PMAP
 	select IOMMU_FORCE_PT_SHARE
 
 config ARCH_DEFCONFIG
diff --git a/xen/arch/arm/include/asm/fixmap.h b/xen/arch/arm/include/asm/fixmap.h
index 1cee51e52ab9..c46a15e59de4 100644
--- a/xen/arch/arm/include/asm/fixmap.h
+++ b/xen/arch/arm/include/asm/fixmap.h
@@ -5,12 +5,20 @@
 #define __ASM_FIXMAP_H
 
 #include <xen/acpi.h>
+#include <xen/pmap.h>
 
 /* Fixmap slots */
 #define FIXMAP_CONSOLE  0  /* The primary UART */
 #define FIXMAP_MISC     1  /* Ephemeral mappings of hardware */
 #define FIXMAP_ACPI_BEGIN  2  /* Start mappings of ACPI tables */
 #define FIXMAP_ACPI_END    (FIXMAP_ACPI_BEGIN + NUM_FIXMAP_ACPI_PAGES - 1)  /* End mappings of ACPI tables */
+#define FIXMAP_PMAP_BEGIN (FIXMAP_ACPI_END + 1) /* Start of PMAP */
+#define FIXMAP_PMAP_END (FIXMAP_PMAP_BEGIN + NUM_FIX_PMAP - 1) /* End of PMAP */
+
+#define FIXMAP_LAST FIXMAP_PMAP_END
+
+#define FIXADDR_START FIXMAP_ADDR(0)
+#define FIXADDR_TOP FIXMAP_ADDR(FIXMAP_LAST)
 
 #ifndef __ASSEMBLY__
 
@@ -19,6 +27,15 @@ extern void set_fixmap(unsigned map, mfn_t mfn, unsigned attributes);
 /* Remove a mapping from a fixmap entry */
 extern void clear_fixmap(unsigned map);
 
+#define fix_to_virt(slot) ((void *)FIXMAP_ADDR(slot))
+
+static inline unsigned int virt_to_fix(vaddr_t vaddr)
+{
+    BUG_ON(vaddr >= FIXADDR_TOP || vaddr < FIXADDR_START);
+
+    return ((vaddr - FIXADDR_START) >> PAGE_SHIFT);
+}
+
 #endif /* __ASSEMBLY__ */
 
 #endif /* __ASM_FIXMAP_H */
diff --git a/xen/arch/arm/include/asm/lpae.h b/xen/arch/arm/include/asm/lpae.h
index 8cf932b5c947..6099037da1c0 100644
--- a/xen/arch/arm/include/asm/lpae.h
+++ b/xen/arch/arm/include/asm/lpae.h
@@ -4,6 +4,7 @@
 #ifndef __ASSEMBLY__
 
 #include <xen/page-defs.h>
+#include <xen/mm-frame.h>
 
 /*
  * WARNING!  Unlike the x86 pagetable code, where l1 is the lowest level and
@@ -168,6 +169,13 @@ static inline bool lpae_is_superpage(lpae_t pte, unsigned int level)
         third_table_offset(addr)            \
     }
 
+/*
+ * Standard entry type that we'll use to build Xen's own pagetables.
+ * We put the same permissions at every level, because they're ignored
+ * by the walker in non-leaf entries.
+ */
+lpae_t mfn_to_xen_entry(mfn_t mfn, unsigned int attr);
+
 #endif /* __ASSEMBLY__ */
 
 /*
diff --git a/xen/arch/arm/include/asm/pmap.h b/xen/arch/arm/include/asm/pmap.h
new file mode 100644
index 000000000000..70eafe2891d7
--- /dev/null
+++ b/xen/arch/arm/include/asm/pmap.h
@@ -0,0 +1,33 @@
+#ifndef __ASM_PMAP_H__
+#define __ASM_PMAP_H__
+
+#include <xen/mm.h>
+
+/* XXX: Find an header to declare it */
+extern lpae_t xen_fixmap[XEN_PT_LPAE_ENTRIES];
+
+static inline void arch_pmap_map(unsigned int slot, mfn_t mfn)
+{
+    lpae_t *entry = &xen_fixmap[slot];
+    lpae_t pte;
+
+    ASSERT(!lpae_is_valid(*entry));
+
+    pte = mfn_to_xen_entry(mfn, PAGE_HYPERVISOR_RW);
+    pte.pt.table = 1;
+    write_pte(entry, pte);
+}
+
+static inline void arch_pmap_unmap(unsigned int slot)
+{
+    lpae_t pte = {};
+
+    write_pte(&xen_fixmap[slot], pte);
+
+    flush_xen_tlb_range_va_local(FIXMAP_ADDR(slot), PAGE_SIZE);
+}
+
+void arch_pmap_map_slot(unsigned int slot, mfn_t mfn);
+void arch_pmap_clear_slot(void *ptr);
+
+#endif /* __ASM_PMAP_H__ */
diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
index d6a4b9407c43..b7942464d4de 100644
--- a/xen/arch/arm/mm.c
+++ b/xen/arch/arm/mm.c
@@ -290,12 +290,7 @@ void dump_hyp_walk(vaddr_t addr)
     dump_pt_walk(ttbr, addr, HYP_PT_ROOT_LEVEL, 1);
 }
 
-/*
- * Standard entry type that we'll use to build Xen's own pagetables.
- * We put the same permissions at every level, because they're ignored
- * by the walker in non-leaf entries.
- */
-static inline lpae_t mfn_to_xen_entry(mfn_t mfn, unsigned attr)
+lpae_t mfn_to_xen_entry(mfn_t mfn, unsigned int attr)
 {
     lpae_t e = (lpae_t) {
         .pt = {
diff --git a/xen/common/Kconfig b/xen/common/Kconfig
index db687b1785e7..b6c55af2eb03 100644
--- a/xen/common/Kconfig
+++ b/xen/common/Kconfig
@@ -49,6 +49,9 @@ config HAS_KEXEC
 config HAS_PDX
 	bool
 
+config HAS_PMAP
+	bool
+
 config HAS_SCHED_GRANULARITY
 	bool
 
diff --git a/xen/common/Makefile b/xen/common/Makefile
index ca839118e4d1..8b42b0828134 100644
--- a/xen/common/Makefile
+++ b/xen/common/Makefile
@@ -28,6 +28,7 @@ obj-y += multicall.o
 obj-y += notifier.o
 obj-y += page_alloc.o
 obj-$(CONFIG_HAS_PDX) += pdx.o
+obj-bin-$(CONFIG_HAS_PMAP) += pmap.init.o
 obj-$(CONFIG_PERF_COUNTERS) += perfc.o
 obj-y += preempt.o
 obj-y += random.o
diff --git a/xen/common/pmap.c b/xen/common/pmap.c
new file mode 100644
index 000000000000..cea730ead545
--- /dev/null
+++ b/xen/common/pmap.c
@@ -0,0 +1,79 @@
+#include <xen/bitops.h>
+#include <xen/init.h>
+#include <xen/pmap.h>
+
+#include <asm/pmap.h>
+#include <asm/fixmap.h>
+
+/*
+ * Simple mapping infrastructure to map / unmap pages in fixed map.
+ * This is used to set up the page table for mapcache, which is used
+ * by map domain page infrastructure.
+ *
+ * This structure is not protected by any locks, so it must not be used after
+ * smp bring-up.
+ */
+
+/* Bitmap to track which slot is used */
+static unsigned long __initdata inuse;
+
+void *__init pmap_map(mfn_t mfn)
+{
+    unsigned long flags;
+    unsigned int idx;
+    unsigned int slot;
+
+    BUILD_BUG_ON(sizeof(inuse) * BITS_PER_BYTE < NUM_FIX_PMAP);
+
+    ASSERT(system_state < SYS_STATE_smp_boot);
+
+    local_irq_save(flags);
+
+    idx = find_first_zero_bit(&inuse, NUM_FIX_PMAP);
+    if ( idx == NUM_FIX_PMAP )
+        panic("Out of PMAP slots\n");
+
+    __set_bit(idx, &inuse);
+
+    slot = idx + FIXMAP_PMAP_BEGIN;
+    ASSERT(slot >= FIXMAP_PMAP_BEGIN && slot <= FIXMAP_PMAP_END);
+
+    /*
+     * We cannot use set_fixmap() here. We use PMAP when there is no direct map,
+     * so map_pages_to_xen() called by set_fixmap() needs to map pages on
+     * demand, which then calls pmap() again, resulting in a loop. Modify the
+     * PTEs directly instead. The same is true for pmap_unmap().
+     */
+    arch_pmap_map(slot, mfn);
+
+    local_irq_restore(flags);
+
+    return fix_to_virt(slot);
+}
+
+void __init pmap_unmap(const void *p)
+{
+    unsigned long flags;
+    unsigned int idx;
+    unsigned int slot = virt_to_fix((unsigned long)p);
+
+    ASSERT(system_state < SYS_STATE_smp_boot);
+    ASSERT(slot >= FIXMAP_PMAP_BEGIN && slot <= FIXMAP_PMAP_END);
+
+    idx = slot - FIXMAP_PMAP_BEGIN;
+    local_irq_save(flags);
+
+    __clear_bit(idx, &inuse);
+    arch_pmap_unmap(slot);
+
+    local_irq_restore(flags);
+}
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
diff --git a/xen/include/xen/pmap.h b/xen/include/xen/pmap.h
new file mode 100644
index 000000000000..93e61b10870e
--- /dev/null
+++ b/xen/include/xen/pmap.h
@@ -0,0 +1,16 @@
+#ifndef __XEN_PMAP_H__
+#define __XEN_PMAP_H__
+
+/* Large enough for mapping 5 levels of page tables with some headroom */
+#define NUM_FIX_PMAP 8
+
+#ifndef __ASSEMBLY__
+
+#include <xen/mm-frame.h>
+
+void *pmap_map(mfn_t mfn);
+void pmap_unmap(const void *p);
+
+#endif /* __ASSEMBLY__ */
+
+#endif /* __XEN_PMAP_H__ */
-- 
2.32.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 21 10:51:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 21 Feb 2022 10:51:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276098.472197 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM6HW-0007Sc-CH; Mon, 21 Feb 2022 10:51:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276098.472197; Mon, 21 Feb 2022 10:51:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM6HV-0007OX-UA; Mon, 21 Feb 2022 10:51:01 +0000
Received: by outflank-mailman (input) for mailman id 276098;
 Mon, 21 Feb 2022 10:50:58 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nM6HS-0006TD-Nq
 for xen-devel@lists.xenproject.org; Mon, 21 Feb 2022 10:50:58 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nM6HR-0002lv-Lv; Mon, 21 Feb 2022 10:50:57 +0000
Received: from 54-240-197-232.amazon.com ([54.240.197.232]
 helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com)
 by xenbits.xenproject.org with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nM5q6-00070b-S4; Mon, 21 Feb 2022 10:22:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References:
	In-Reply-To:Message-Id:Date:Subject:Cc:To:From;
	bh=9KLsMofNLy3j5de3pHJ2lPBADdkm64K7Ef3aTBPoXCg=; b=EjhcJAJOyC8rFVXQZJre5dJ2cS
	aBLNvlIDzKRFWDtl4HIrCxCQTl/vj3qIfuMKuwaZS5Zmy1QlE4m/ssrIA0gGmIHre40zkc2DYsiJU
	xPeoJ3octnCgPeYm83iM77GKyhZAIihkiqUTJLd/gO2W0jsEDkprdezTgf6Z22cIHuhA=;
From: Julien Grall <julien@xen.org>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	Julien Grall <julien.grall@arm.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Julien Grall <jgrall@amazon.com>
Subject: [PATCH v3 19/19] xen/arm: mm: Re-implement setup_frame_table_mappings() with map_pages_to_xen()
Date: Mon, 21 Feb 2022 10:22:18 +0000
Message-Id: <20220221102218.33785-20-julien@xen.org>
X-Mailer: git-send-email 2.32.0
In-Reply-To: <20220221102218.33785-1-julien@xen.org>
References: <20220221102218.33785-1-julien@xen.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Julien Grall <julien.grall@arm.com>

Now that map_pages_to_xen() has been extended to support 2MB mappings,
we can replace the create_mappings() call by map_pages_to_xen() call.

This has the advantage to remove the differences between 32-bit and
64-bit code.

Lastly remove create_mappings() as there is no more callers.

Signed-off-by: Julien Grall <julien.grall@arm.com>
Signed-off-by: Julien Grall <jgrall@amazon.com>

---
    Changes in v3:
        - Fix typo in the commit message
        - Remove the TODO regarding contiguous bit

    Changes in v2:
        - New patch
---
 xen/arch/arm/mm.c | 63 ++++-------------------------------------------
 1 file changed, 5 insertions(+), 58 deletions(-)

diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
index 4af59375d998..d73f49d5b6fc 100644
--- a/xen/arch/arm/mm.c
+++ b/xen/arch/arm/mm.c
@@ -354,40 +354,6 @@ void clear_fixmap(unsigned map)
     BUG_ON(res != 0);
 }
 
-/* Create Xen's mappings of memory.
- * Mapping_size must be either 2MB or 32MB.
- * Base and virt must be mapping_size aligned.
- * Size must be a multiple of mapping_size.
- * second must be a contiguous set of second level page tables
- * covering the region starting at virt_offset. */
-static void __init create_mappings(lpae_t *second,
-                                   unsigned long virt_offset,
-                                   unsigned long base_mfn,
-                                   unsigned long nr_mfns,
-                                   unsigned int mapping_size)
-{
-    unsigned long i, count;
-    const unsigned long granularity = mapping_size >> PAGE_SHIFT;
-    lpae_t pte, *p;
-
-    ASSERT((mapping_size == MB(2)) || (mapping_size == MB(32)));
-    ASSERT(!((virt_offset >> PAGE_SHIFT) % granularity));
-    ASSERT(!(base_mfn % granularity));
-    ASSERT(!(nr_mfns % granularity));
-
-    count = nr_mfns / XEN_PT_LPAE_ENTRIES;
-    p = second + second_linear_offset(virt_offset);
-    pte = mfn_to_xen_entry(_mfn(base_mfn), MT_NORMAL);
-    if ( granularity == 16 * XEN_PT_LPAE_ENTRIES )
-        pte.pt.contig = 1;  /* These maps are in 16-entry contiguous chunks. */
-    for ( i = 0; i < count; i++ )
-    {
-        write_pte(p + i, pte);
-        pte.pt.base += 1 << XEN_PT_LPAE_SHIFT;
-    }
-    flush_xen_tlb_local();
-}
-
 #ifdef CONFIG_DOMAIN_PAGE
 void *map_domain_page_global(mfn_t mfn)
 {
@@ -846,36 +812,17 @@ void __init setup_frametable_mappings(paddr_t ps, paddr_t pe)
     unsigned long frametable_size = nr_pdxs * sizeof(struct page_info);
     mfn_t base_mfn;
     const unsigned long mapping_size = frametable_size < MB(32) ? MB(2) : MB(32);
-#ifdef CONFIG_ARM_64
-    lpae_t *second, pte;
-    unsigned long nr_second;
-    mfn_t second_base;
-    int i;
-#endif
+    int rc;
 
     frametable_base_pdx = mfn_to_pdx(maddr_to_mfn(ps));
     /* Round up to 2M or 32M boundary, as appropriate. */
     frametable_size = ROUNDUP(frametable_size, mapping_size);
     base_mfn = alloc_boot_pages(frametable_size >> PAGE_SHIFT, 32<<(20-12));
 
-#ifdef CONFIG_ARM_64
-    /* Compute the number of second level pages. */
-    nr_second = ROUNDUP(frametable_size, FIRST_SIZE) >> FIRST_SHIFT;
-    second_base = alloc_boot_pages(nr_second, 1);
-    second = mfn_to_virt(second_base);
-    for ( i = 0; i < nr_second; i++ )
-    {
-        clear_page(mfn_to_virt(mfn_add(second_base, i)));
-        pte = mfn_to_xen_entry(mfn_add(second_base, i), MT_NORMAL);
-        pte.pt.table = 1;
-        write_pte(&xen_first[first_table_offset(FRAMETABLE_VIRT_START)+i], pte);
-    }
-    create_mappings(second, 0, mfn_x(base_mfn), frametable_size >> PAGE_SHIFT,
-                    mapping_size);
-#else
-    create_mappings(xen_second, FRAMETABLE_VIRT_START, mfn_x(base_mfn),
-                    frametable_size >> PAGE_SHIFT, mapping_size);
-#endif
+    rc = map_pages_to_xen(FRAMETABLE_VIRT_START, base_mfn,
+                          frametable_size >> PAGE_SHIFT, PAGE_HYPERVISOR_RW);
+    if ( rc )
+        panic("Unable to setup the frametable mappings.\n");
 
     memset(&frame_table[0], 0, nr_pdxs * sizeof(struct page_info));
     memset(&frame_table[nr_pdxs], -1,
-- 
2.32.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 21 10:51:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 21 Feb 2022 10:51:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276096.472206 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM6HX-0007c7-Am; Mon, 21 Feb 2022 10:51:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276096.472206; Mon, 21 Feb 2022 10:51:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM6HW-0007Xe-Ej; Mon, 21 Feb 2022 10:51:02 +0000
Received: by outflank-mailman (input) for mailman id 276096;
 Mon, 21 Feb 2022 10:50:58 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nM6HS-0006Ri-Iv
 for xen-devel@lists.xenproject.org; Mon, 21 Feb 2022 10:50:58 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nM6HR-0002lj-HW; Mon, 21 Feb 2022 10:50:57 +0000
Received: from 54-240-197-232.amazon.com ([54.240.197.232]
 helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com)
 by xenbits.xenproject.org with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nM5q4-00070b-Nt; Mon, 21 Feb 2022 10:22:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References:
	In-Reply-To:Message-Id:Date:Subject:Cc:To:From;
	bh=KXQhE4JwQVSql4G63vu+dVWvMWK9F9ZJUhgjQV+fnpo=; b=kiUDonnWYV5KI6PTUUqj8ctYcz
	yYikeIAMlHznE+6xc4wdf0yKc0TZbzy6bNEGTfh5589ds+XgSxqAtBAJr4wSgfAHvvBqAU/MQVsF6
	+sxKmRbotqkUxiJTby08Z8odVirrLOxreHSVhkGJejjb6rzwln9QUJJmmgIRz236QGrY=;
From: Julien Grall <julien@xen.org>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	Julien Grall <jgrall@amazon.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH v3 17/19] xen/arm64: mm: Add memory to the boot allocator first
Date: Mon, 21 Feb 2022 10:22:16 +0000
Message-Id: <20220221102218.33785-18-julien@xen.org>
X-Mailer: git-send-email 2.32.0
In-Reply-To: <20220221102218.33785-1-julien@xen.org>
References: <20220221102218.33785-1-julien@xen.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Julien Grall <jgrall@amazon.com>

Currently, memory is added to the boot allocator after the xenheap
mappings are done. This will break if the first mapping is more than
512GB of RAM.

In addition to that, a follow-up patch will rework setup_xenheap_mappings()
to use smaller mappings (e.g. 2MB, 4KB). So it will be necessary to have
memory in the boot allocator earlier.

Only free memory (e.g. not reserved or modules) can be added to the boot
allocator. It might be possible that some regions (including the first
one) will have no free memory.

So we need to add all the free memory to the boot allocator first
and then add do the mappings.

Signed-off-by: Julien Grall <jgrall@amazon.com>

---
    Changes in v3:
        - Patch added
---
 xen/arch/arm/setup.c | 63 +++++++++++++++++++++++++++++---------------
 1 file changed, 42 insertions(+), 21 deletions(-)

diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
index d5d0792ed48a..777cf96639f5 100644
--- a/xen/arch/arm/setup.c
+++ b/xen/arch/arm/setup.c
@@ -767,30 +767,18 @@ static void __init setup_mm(void)
     init_staticmem_pages();
 }
 #else /* CONFIG_ARM_64 */
-static void __init setup_mm(void)
+static void __init populate_boot_allocator(void)
 {
-    paddr_t ram_start = ~0;
-    paddr_t ram_end = 0;
-    paddr_t ram_size = 0;
-    int bank;
-
-    init_pdx();
+    unsigned int i;
+    const struct meminfo *banks = &bootinfo.mem;
 
-    total_pages = 0;
-    for ( bank = 0 ; bank < bootinfo.mem.nr_banks; bank++ )
+    for ( i = 0; i < banks->nr_banks; i++ )
     {
-        paddr_t bank_start = bootinfo.mem.bank[bank].start;
-        paddr_t bank_size = bootinfo.mem.bank[bank].size;
-        paddr_t bank_end = bank_start + bank_size;
+        const struct membank *bank = &banks->bank[i];
+        paddr_t bank_end = bank->start + bank->size;
         paddr_t s, e;
 
-        ram_size = ram_size + bank_size;
-        ram_start = min(ram_start,bank_start);
-        ram_end = max(ram_end,bank_end);
-
-        setup_xenheap_mappings(bank_start>>PAGE_SHIFT, bank_size>>PAGE_SHIFT);
-
-        s = bank_start;
+        s = bank->start;
         while ( s < bank_end )
         {
             paddr_t n = bank_end;
@@ -798,9 +786,7 @@ static void __init setup_mm(void)
             e = next_module(s, &n);
 
             if ( e == ~(paddr_t)0 )
-            {
                 e = n = bank_end;
-            }
 
             if ( e > bank_end )
                 e = bank_end;
@@ -809,6 +795,41 @@ static void __init setup_mm(void)
             s = n;
         }
     }
+}
+
+static void __init setup_mm(void)
+{
+    const struct meminfo *banks = &bootinfo.mem;
+    paddr_t ram_start = ~0;
+    paddr_t ram_end = 0;
+    paddr_t ram_size = 0;
+    unsigned int i;
+
+    init_pdx();
+
+    /*
+     * We need some memory to allocate the page-tables used for the xenheap
+     * mappings. But some regions may contain memory already allocated
+     * for other uses (e.g. modules, reserved-memory...).
+     *
+     * For simplify add all the free regions in the boot allocator.
+     */
+    populate_boot_allocator();
+
+    total_pages = 0;
+
+    for ( i = 0; i < banks->nr_banks; i++ )
+    {
+        const struct membank *bank = &banks->bank[i];
+        paddr_t bank_end = bank->start + bank->size;
+
+        ram_size = ram_size + bank->size;
+        ram_start = min(ram_start, bank->start);
+        ram_end = max(ram_end, bank_end);
+
+        setup_xenheap_mappings(PFN_DOWN(bank->start),
+                               PFN_DOWN(bank->size));
+    }
 
     total_pages += ram_size >> PAGE_SHIFT;
 
-- 
2.32.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 21 10:51:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 21 Feb 2022 10:51:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276099.472211 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM6HX-0007md-PD; Mon, 21 Feb 2022 10:51:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276099.472211; Mon, 21 Feb 2022 10:51:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM6HX-0007jC-5q; Mon, 21 Feb 2022 10:51:03 +0000
Received: by outflank-mailman (input) for mailman id 276099;
 Mon, 21 Feb 2022 10:50:58 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nM6HS-0006SR-Lr
 for xen-devel@lists.xenproject.org; Mon, 21 Feb 2022 10:50:58 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nM6HR-0002lx-NZ; Mon, 21 Feb 2022 10:50:57 +0000
Received: from 54-240-197-232.amazon.com ([54.240.197.232]
 helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com)
 by xenbits.xenproject.org with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nM5q5-00070b-Py; Mon, 21 Feb 2022 10:22:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References:
	In-Reply-To:Message-Id:Date:Subject:Cc:To:From;
	bh=D3nC49pPPlSt0jCvDVIcUQr1XjPlKjaXYX88znegfds=; b=L37qETmWZoIP8V+g5+NzwQbK8d
	+ku44VagmufwFIBsvMEhS6wCAM9s4Nd3ikoetMhu+1IbJ5C0XlMbBqyUzCXP+My7zgovNBNQG2ipB
	smt5znX4iM4F9lacP5KlWY1by0xFmKkRqnV6WaC4+ZRis5le88/xMhqN9HidHJVkRBPU=;
From: Julien Grall <julien@xen.org>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	Julien Grall <julien.grall@arm.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Julien Grall <jgrall@amazon.com>
Subject: [PATCH v3 18/19] xen/arm: mm: Rework setup_xenheap_mappings()
Date: Mon, 21 Feb 2022 10:22:17 +0000
Message-Id: <20220221102218.33785-19-julien@xen.org>
X-Mailer: git-send-email 2.32.0
In-Reply-To: <20220221102218.33785-1-julien@xen.org>
References: <20220221102218.33785-1-julien@xen.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Julien Grall <julien.grall@arm.com>

The current implementation of setup_xenheap_mappings() is using 1GB
mappings. This can lead to unexpected result because the mapping
may alias a non-cachable region (such as device or reserved regions).
For more details see B2.8 in ARM DDI 0487H.a.

map_pages_to_xen() was recently reworked to allow superpage mappings,
support contiguous mapping and deal with the use of pagge-tables before
they are mapped.

Most of the code in setup_xenheap_mappings() is now replaced with a
single call to map_pages_to_xen().

Signed-off-by: Julien Grall <julien.grall@arm.com>
Signed-off-by: Julien Grall <jgrall@amazon.com>

---
    Changes in v3:
        - Don't use 1GB mapping
        - Re-order code in setup_mm() in a separate patch

    Changes in v2:
        - New patch
---
 xen/arch/arm/mm.c | 87 ++++++++++-------------------------------------
 1 file changed, 18 insertions(+), 69 deletions(-)

diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
index 11b6b60a2bc1..4af59375d998 100644
--- a/xen/arch/arm/mm.c
+++ b/xen/arch/arm/mm.c
@@ -138,17 +138,6 @@ static DEFINE_PAGE_TABLE(cpu0_pgtable);
 static DEFINE_PAGE_TABLES(cpu0_dommap, DOMHEAP_SECOND_PAGES);
 #endif
 
-#ifdef CONFIG_ARM_64
-/* The first page of the first level mapping of the xenheap. The
- * subsequent xenheap first level pages are dynamically allocated, but
- * we need this one to bootstrap ourselves. */
-static DEFINE_PAGE_TABLE(xenheap_first_first);
-/* The zeroeth level slot which uses xenheap_first_first. Used because
- * setup_xenheap_mappings otherwise relies on mfn_to_virt which isn't
- * valid for a non-xenheap mapping. */
-static __initdata int xenheap_first_first_slot = -1;
-#endif
-
 /* Common pagetable leaves */
 /* Second level page tables.
  *
@@ -815,77 +804,37 @@ void __init setup_xenheap_mappings(unsigned long base_mfn,
 void __init setup_xenheap_mappings(unsigned long base_mfn,
                                    unsigned long nr_mfns)
 {
-    lpae_t *first, pte;
-    unsigned long mfn, end_mfn;
-    vaddr_t vaddr;
-
-    /* Align to previous 1GB boundary */
-    mfn = base_mfn & ~((FIRST_SIZE>>PAGE_SHIFT)-1);
+    int rc;
 
     /* First call sets the xenheap physical and virtual offset. */
     if ( mfn_eq(xenheap_mfn_start, INVALID_MFN) )
     {
+        unsigned long mfn_gb = base_mfn & ~((FIRST_SIZE >> PAGE_SHIFT) - 1);
+
         xenheap_mfn_start = _mfn(base_mfn);
         xenheap_base_pdx = mfn_to_pdx(_mfn(base_mfn));
+        /*
+         * The base address may not be aligned to the first level
+         * size (e.g. 1GB when using 4KB pages). This would prevent
+         * superpage mappings for all the regions because the virtual
+         * address and machine address should both be suitably aligned.
+         *
+         * Prevent that by offsetting the start of the xenheap virtual
+         * address.
+         */
         xenheap_virt_start = DIRECTMAP_VIRT_START +
-            (base_mfn - mfn) * PAGE_SIZE;
+            (base_mfn - mfn_gb) * PAGE_SIZE;
     }
 
     if ( base_mfn < mfn_x(xenheap_mfn_start) )
         panic("cannot add xenheap mapping at %lx below heap start %lx\n",
               base_mfn, mfn_x(xenheap_mfn_start));
 
-    end_mfn = base_mfn + nr_mfns;
-
-    /*
-     * Virtual address aligned to previous 1GB to match physical
-     * address alignment done above.
-     */
-    vaddr = (vaddr_t)__mfn_to_virt(base_mfn) & FIRST_MASK;
-
-    while ( mfn < end_mfn )
-    {
-        int slot = zeroeth_table_offset(vaddr);
-        lpae_t *p = &xen_pgtable[slot];
-
-        if ( p->pt.valid )
-        {
-            /* mfn_to_virt is not valid on the 1st 1st mfn, since it
-             * is not within the xenheap. */
-            first = slot == xenheap_first_first_slot ?
-                xenheap_first_first : mfn_to_virt(lpae_get_mfn(*p));
-        }
-        else if ( xenheap_first_first_slot == -1)
-        {
-            /* Use xenheap_first_first to bootstrap the mappings */
-            first = xenheap_first_first;
-
-            pte = pte_of_xenaddr((vaddr_t)xenheap_first_first);
-            pte.pt.table = 1;
-            write_pte(p, pte);
-
-            xenheap_first_first_slot = slot;
-        }
-        else
-        {
-            mfn_t first_mfn = alloc_boot_pages(1, 1);
-
-            clear_page(mfn_to_virt(first_mfn));
-            pte = mfn_to_xen_entry(first_mfn, MT_NORMAL);
-            pte.pt.table = 1;
-            write_pte(p, pte);
-            first = mfn_to_virt(first_mfn);
-        }
-
-        pte = mfn_to_xen_entry(_mfn(mfn), MT_NORMAL);
-        /* TODO: Set pte.pt.contig when appropriate. */
-        write_pte(&first[first_table_offset(vaddr)], pte);
-
-        mfn += FIRST_SIZE>>PAGE_SHIFT;
-        vaddr += FIRST_SIZE;
-    }
-
-    flush_xen_tlb_local();
+    rc = map_pages_to_xen((vaddr_t)__mfn_to_virt(base_mfn),
+                          _mfn(base_mfn), nr_mfns,
+                          PAGE_HYPERVISOR_RW | _PAGE_BLOCK);
+    if ( rc )
+        panic("Unable to setup the xenheap mappings.\n");
 }
 #endif
 
-- 
2.32.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 21 10:55:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 21 Feb 2022 10:55:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276160.472254 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM6Lr-0003zZ-1m; Mon, 21 Feb 2022 10:55:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276160.472254; Mon, 21 Feb 2022 10:55:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM6Lq-0003zS-TH; Mon, 21 Feb 2022 10:55:30 +0000
Received: by outflank-mailman (input) for mailman id 276160;
 Mon, 21 Feb 2022 10:55:30 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=3jq6=TE=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1nM6Lq-0003zM-0L
 for xen-devel@lists.xenproject.org; Mon, 21 Feb 2022 10:55:30 +0000
Received: from ppsw-40.csi.cam.ac.uk (ppsw-40.csi.cam.ac.uk [131.111.8.140])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c7229619-9304-11ec-8eb8-a37418f5ba1a;
 Mon, 21 Feb 2022 11:55:28 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:57080)
 by ppsw-40.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.138]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1nM6Ln-0010lg-jF (Exim 4.95) (return-path <amc96@srcf.net>);
 Mon, 21 Feb 2022 10:55:27 +0000
Received: from [192.168.1.10] (host-92-12-45-187.as13285.net [92.12.45.187])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id C3D781FB2D;
 Mon, 21 Feb 2022 10:55:26 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c7229619-9304-11ec-8eb8-a37418f5ba1a
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <085e64bd-b32f-6162-f5d0-69ac9d0e1a2c@srcf.net>
Date: Mon, 21 Feb 2022 10:55:26 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH 3/3] CI: Coverity tweaks
Content-Language: en-GB
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>
References: <20220221100254.13661-1-andrew.cooper3@citrix.com>
 <20220221100254.13661-4-andrew.cooper3@citrix.com>
 <YhNrhuvBbZ43hcA6@Air-de-Roger>
From: Andrew Cooper <amc96@srcf.net>
In-Reply-To: <YhNrhuvBbZ43hcA6@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 21/02/2022 10:37, Roger Pau Monné wrote:
> On Mon, Feb 21, 2022 at 10:02:54AM +0000, Andrew Cooper wrote:
>>  * Use workflow_dispatch to allow manual creation of the job.
>>  * Use parallel builds.  The workers have two vCPUs.
>>  * Shrink the dependency list further.  build-essential covers make and gcc,
>>    while bridge-utils and iproute2 are runtime dependencies not build
>>    dependencies.  Alter bzip2 to libbz2-dev.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>> ---
>> CC: Roger Pau Monné <roger.pau@citrix.com>
>> ---
>>  .github/workflows/coverity.yml | 14 ++++++++------
>>  1 file changed, 8 insertions(+), 6 deletions(-)
>>
>> diff --git a/.github/workflows/coverity.yml b/.github/workflows/coverity.yml
>> index 9d04b56fd31d..6e7b81e74f72 100644
>> --- a/.github/workflows/coverity.yml
>> +++ b/.github/workflows/coverity.yml
>> @@ -2,6 +2,7 @@ name: Coverity Scan
>>  
>>  # We only want to test official release code, not every pull request.
>>  on:
>> +  workflow_dispatch:
>>    schedule:
>>      - cron: '18 9 * * WED,SUN' # Bi-weekly at 9:18 UTC
>>  
>> @@ -11,11 +12,11 @@ jobs:
>>      steps:
>>      - name: Install build dependencies
>>        run: |
>> -        sudo apt-get install -y wget git gawk bridge-utils \
>> -          iproute2 bzip2 build-essential \
>> -          make gcc zlib1g-dev libncurses5-dev iasl \
>> -          libbz2-dev e2fslibs-dev git-core uuid-dev ocaml \
>> -          ocaml-findlib xz-utils libyajl-dev \
>> +        sudo apt-get install -y wget git gawk \
>> +          libbz2-dev build-essential \
>> +          zlib1g-dev libncurses5-dev iasl \
>> +          libbz2-dev e2fslibs-dev uuid-dev ocaml \
>> +          ocaml-findlib libyajl-dev \
>>            autoconf libtool liblzma-dev \
>>            python3-dev golang python-dev libsystemd-dev
>>  
>> @@ -31,7 +32,7 @@ jobs:
>>  
>>      - name: Pre build stuff
>>        run: |
>> -        make mini-os-dir
>> +        make -j`nproc` mini-os-dir
>>  
>>      - uses: vapier/coverity-scan-action@v1
>>        with:
>> @@ -39,3 +40,4 @@ jobs:
>>          project: XenProject
>>          email: ${{ secrets.COVERITY_SCAN_EMAIL }}
>>          token: ${{ secrets.COVERITY_SCAN_TOKEN }}
>> +        command: make -j`nproc` build
> There's already a 'command:' parameter set just before 'project:'.

Oh, so there is.

> Are
> we OK with using plain build?
>
> If so we would have to disable docs build and stubdom? We don't want
> to analyze all the newlib &c that's build as part of stubdoms?

The problem I was trying to work around there was that xen&tools turn
into *-install so we also spend time shuffling binaries around the build
environment.

What we actually want is:

make -j`nproc` build-xen build-tools && make -j`nproc` -C extras/mini-os/

~Andrew


From xen-devel-bounces@lists.xenproject.org Mon Feb 21 10:59:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 21 Feb 2022 10:59:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276171.472264 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM6Pw-0004eU-HH; Mon, 21 Feb 2022 10:59:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276171.472264; Mon, 21 Feb 2022 10:59:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM6Pw-0004eN-EI; Mon, 21 Feb 2022 10:59:44 +0000
Received: by outflank-mailman (input) for mailman id 276171;
 Mon, 21 Feb 2022 10:59:42 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1Uke=TE=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1nM6Pu-0004eH-Np
 for xen-devel@lists.xenproject.org; Mon, 21 Feb 2022 10:59:42 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 571a5b84-9305-11ec-8539-5f4723681683;
 Mon, 21 Feb 2022 11:59:29 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A2C281476;
 Mon, 21 Feb 2022 02:59:39 -0800 (PST)
Received: from e123311-lin.arm.com (unknown [10.57.3.163])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 343033F66F;
 Mon, 21 Feb 2022 02:59:38 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 571a5b84-9305-11ec-8539-5f4723681683
From: Michal Orzel <michal.orzel@arm.com>
To: xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>
Subject: [PATCH] xen/arm: Rename psr_mode_is_32bit to regs_mode_is_32bit
Date: Mon, 21 Feb 2022 11:59:31 +0100
Message-Id: <20220221105931.12028-1-michal.orzel@arm.com>
X-Mailer: git-send-email 2.29.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Following a discussion [1] it seems like that renaming work has
been forgotten. Perform renaming of psr_mode_is_32bit to
regs_mode_is_32bit as the function no longer takes psr parameter.

[1] https://marc.info/?l=xen-devel&m=156457538423787&w=2

Signed-off-by: Michal Orzel <michal.orzel@arm.com>
---
 xen/arch/arm/include/asm/regs.h |  2 +-
 xen/arch/arm/traps.c            | 30 +++++++++++++++---------------
 2 files changed, 16 insertions(+), 16 deletions(-)

diff --git a/xen/arch/arm/include/asm/regs.h b/xen/arch/arm/include/asm/regs.h
index ec091a28a2..04e821138a 100644
--- a/xen/arch/arm/include/asm/regs.h
+++ b/xen/arch/arm/include/asm/regs.h
@@ -13,7 +13,7 @@
 
 #define psr_mode(psr,m) (((psr) & PSR_MODE_MASK) == m)
 
-static inline bool psr_mode_is_32bit(const struct cpu_user_regs *regs)
+static inline bool regs_mode_is_32bit(const struct cpu_user_regs *regs)
 {
 #ifdef CONFIG_ARM_32
     return true;
diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c
index 9339d12f58..0db8e42d65 100644
--- a/xen/arch/arm/traps.c
+++ b/xen/arch/arm/traps.c
@@ -896,7 +896,7 @@ static void _show_registers(const struct cpu_user_regs *regs,
 
     if ( guest_mode )
     {
-        if ( psr_mode_is_32bit(regs) )
+        if ( regs_mode_is_32bit(regs) )
             show_registers_32(regs, ctxt, guest_mode, v);
 #ifdef CONFIG_ARM_64
         else
@@ -1631,7 +1631,7 @@ int check_conditional_instr(struct cpu_user_regs *regs, const union hsr hsr)
     {
         unsigned long it;
 
-        BUG_ON( !psr_mode_is_32bit(regs) || !(cpsr & PSR_THUMB) );
+        BUG_ON( !regs_mode_is_32bit(regs) || !(cpsr & PSR_THUMB) );
 
         it = ( (cpsr >> (10-2)) & 0xfc) | ((cpsr >> 25) & 0x3 );
 
@@ -1656,7 +1656,7 @@ int check_conditional_instr(struct cpu_user_regs *regs, const union hsr hsr)
 void advance_pc(struct cpu_user_regs *regs, const union hsr hsr)
 {
     register_t itbits, cond, cpsr = regs->cpsr;
-    bool is_thumb = psr_mode_is_32bit(regs) && (cpsr & PSR_THUMB);
+    bool is_thumb = regs_mode_is_32bit(regs) && (cpsr & PSR_THUMB);
 
     if ( is_thumb && (cpsr & PSR_IT_MASK) )
     {
@@ -2098,37 +2098,37 @@ void do_trap_guest_sync(struct cpu_user_regs *regs)
         advance_pc(regs, hsr);
         break;
     case HSR_EC_CP15_32:
-        GUEST_BUG_ON(!psr_mode_is_32bit(regs));
+        GUEST_BUG_ON(!regs_mode_is_32bit(regs));
         perfc_incr(trap_cp15_32);
         do_cp15_32(regs, hsr);
         break;
     case HSR_EC_CP15_64:
-        GUEST_BUG_ON(!psr_mode_is_32bit(regs));
+        GUEST_BUG_ON(!regs_mode_is_32bit(regs));
         perfc_incr(trap_cp15_64);
         do_cp15_64(regs, hsr);
         break;
     case HSR_EC_CP14_32:
-        GUEST_BUG_ON(!psr_mode_is_32bit(regs));
+        GUEST_BUG_ON(!regs_mode_is_32bit(regs));
         perfc_incr(trap_cp14_32);
         do_cp14_32(regs, hsr);
         break;
     case HSR_EC_CP14_64:
-        GUEST_BUG_ON(!psr_mode_is_32bit(regs));
+        GUEST_BUG_ON(!regs_mode_is_32bit(regs));
         perfc_incr(trap_cp14_64);
         do_cp14_64(regs, hsr);
         break;
     case HSR_EC_CP14_DBG:
-        GUEST_BUG_ON(!psr_mode_is_32bit(regs));
+        GUEST_BUG_ON(!regs_mode_is_32bit(regs));
         perfc_incr(trap_cp14_dbg);
         do_cp14_dbg(regs, hsr);
         break;
     case HSR_EC_CP10:
-        GUEST_BUG_ON(!psr_mode_is_32bit(regs));
+        GUEST_BUG_ON(!regs_mode_is_32bit(regs));
         perfc_incr(trap_cp10);
         do_cp10(regs, hsr);
         break;
     case HSR_EC_CP:
-        GUEST_BUG_ON(!psr_mode_is_32bit(regs));
+        GUEST_BUG_ON(!regs_mode_is_32bit(regs));
         perfc_incr(trap_cp);
         do_cp(regs, hsr);
         break;
@@ -2139,7 +2139,7 @@ void do_trap_guest_sync(struct cpu_user_regs *regs)
          * ARMv7 (DDI 0406C.b): B1.14.8
          * ARMv8 (DDI 0487A.d): D1-1501 Table D1-44
          */
-        GUEST_BUG_ON(!psr_mode_is_32bit(regs));
+        GUEST_BUG_ON(!regs_mode_is_32bit(regs));
         perfc_incr(trap_smc32);
         do_trap_smc(regs, hsr);
         break;
@@ -2147,7 +2147,7 @@ void do_trap_guest_sync(struct cpu_user_regs *regs)
     {
         register_t nr;
 
-        GUEST_BUG_ON(!psr_mode_is_32bit(regs));
+        GUEST_BUG_ON(!regs_mode_is_32bit(regs));
         perfc_incr(trap_hvc32);
 #ifndef NDEBUG
         if ( (hsr.iss & 0xff00) == 0xff00 )
@@ -2162,7 +2162,7 @@ void do_trap_guest_sync(struct cpu_user_regs *regs)
     }
 #ifdef CONFIG_ARM_64
     case HSR_EC_HVC64:
-        GUEST_BUG_ON(psr_mode_is_32bit(regs));
+        GUEST_BUG_ON(regs_mode_is_32bit(regs));
         perfc_incr(trap_hvc64);
 #ifndef NDEBUG
         if ( (hsr.iss & 0xff00) == 0xff00 )
@@ -2178,12 +2178,12 @@ void do_trap_guest_sync(struct cpu_user_regs *regs)
          *
          * ARMv8 (DDI 0487A.d): D1-1501 Table D1-44
          */
-        GUEST_BUG_ON(psr_mode_is_32bit(regs));
+        GUEST_BUG_ON(regs_mode_is_32bit(regs));
         perfc_incr(trap_smc64);
         do_trap_smc(regs, hsr);
         break;
     case HSR_EC_SYSREG:
-        GUEST_BUG_ON(psr_mode_is_32bit(regs));
+        GUEST_BUG_ON(regs_mode_is_32bit(regs));
         perfc_incr(trap_sysreg);
         do_sysreg(regs, hsr);
         break;
-- 
2.29.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 21 11:15:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 21 Feb 2022 11:15:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276182.472275 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM6es-0007Au-U2; Mon, 21 Feb 2022 11:15:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276182.472275; Mon, 21 Feb 2022 11:15:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM6es-0007An-Qh; Mon, 21 Feb 2022 11:15:10 +0000
Received: by outflank-mailman (input) for mailman id 276182;
 Mon, 21 Feb 2022 11:15:08 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=fvXl=TE=citrix.com=prvs=044a77a3b=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nM6eq-0007Ah-PA
 for xen-devel@lists.xenproject.org; Mon, 21 Feb 2022 11:15:08 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 85af6c6b-9307-11ec-8eb8-a37418f5ba1a;
 Mon, 21 Feb 2022 12:15:07 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 85af6c6b-9307-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645442107;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=bz3LYT5LcO5fV2QHfp3H6miIX/JdkycEPHStL4fNAlY=;
  b=e1mfgKV7725fK7ZdJEJmLmIXdM5nRMGxyXr+BV+cwGyNoVLsDHYxYFTW
   inzJDEKgrD1mUwYavBVfAeT+v2MTazNcS+9LCCbn9VHCBq9SWwS3ynyFM
   nZWdy0j1yrH7rfD0tWUa/41xTMGf0qg0hRNxH5+gUh4kFWJisWPHIuHQf
   0=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 64640921
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:GQyTKqNyYtmRSlXvrR31l8FynXyQoLVcMsEvi/4bfWQNrUpzhmZWn
 DAcCGqGbPaIa2SgeosnYNiwoUtQvZXSmINqGQto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FV8MpBsJ00o5wbZj2Ncw2LBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z+
 MxU8saUFxYSHoaSo6M3fx1yNwVCIvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALBc/nJo4A/FpnyinUF60OSpHfWaTao9Rf2V/cg+gQQaiCP
 5tDMFKDajzBID1UB3A+BKkOld6xolb1eDx1ukKa8P9fD2/7k1UqjemF3MDuUsyHQ4BZk1iVo
 krC/n/lGVcKOdqH0z2H/3mwwOjVkkvGtJk6TePisKQw2RvKmzJVWEZ+uUaHTeeRulenHIh7d
 V0v2gFwlu8Y2EiBav3BQEjtyJKbhSI0V91VGuw8zQiCzKvI/gqUblQ5oi59hM8O75FvG2Fzv
 rOdt5awXGE07uXJIZ6I3urM9VuP1T4pwXjujMPuZS8M+JHdrY46lXojpf4zQffu3rUZ9dwdq
 g1mTRTSZZ1O16bnNI3hpDgrZg5AQbCTE2YICv3/BD7N0++ATNfNi3aUwVba9+1cC42SU0OMu
 nMJ8+DHsrxTVsHRxXHcHb9cdF1M2xpiGGeB6WOD4rF7r2j9k5JdVds4DM5CyLdBbZ9fJG6Bj
 L77sgJN/p5DVEZGnocsC79d//8ClPC6ffy8D6i8RoMXPvBZKV/WlAkzNBX49z28zyARfVQXZ
 M7znTCEVi1BV8yKDVOeGo8g7FPc7npgnTiKHcijlXxKE9O2PRaodFvMC3PWBshR0U9OiFy9H
 wp3XydS9yhibQ==
IronPort-HdrOrdr: A9a23:4ljzcqFNb45GoKt5pLqE0MeALOsnbusQ8zAXP0AYc3Jom6uj5r
 mTdZUgpHnJYVkqOE3I9ertBEDEewK4yXcX2/h3AV7BZniEhILAFugLhuGO/9SjIVybygc079
 YZT0EUMrzN5DZB4voSmDPIceod/A==
X-IronPort-AV: E=Sophos;i="5.88,385,1635220800"; 
   d="scan'208";a="64640921"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>
Subject: [PATCH v2] CI: Coverity tweaks
Date: Mon, 21 Feb 2022 11:14:54 +0000
Message-ID: <20220221111454.2925-1-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220221100254.13661-4-andrew.cooper3@citrix.com>
References: <20220221100254.13661-4-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

 * Use workflow_dispatch to allow manual creation of the job.
 * Use parallel builds; the workers have two vCPUs.  Also, use the build-*
   targets rather than the ones which expand to dist-*.
 * Shrink the dependency list further.  build-essential covers make and gcc,
   while bridge-utils and iproute2 are runtime dependencies not build
   dependencies.  Alter bzip2 to libbz2-dev.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Roger Pau Monné <roger.pau@citrix.com>

v2:
 * Merge with existing command:
---
 .github/workflows/coverity.yml | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/.github/workflows/coverity.yml b/.github/workflows/coverity.yml
index 9d04b56fd31d..427fb86f947f 100644
--- a/.github/workflows/coverity.yml
+++ b/.github/workflows/coverity.yml
@@ -2,6 +2,7 @@ name: Coverity Scan
 
 # We only want to test official release code, not every pull request.
 on:
+  workflow_dispatch:
   schedule:
     - cron: '18 9 * * WED,SUN' # Bi-weekly at 9:18 UTC
 
@@ -11,11 +12,11 @@ jobs:
     steps:
     - name: Install build dependencies
       run: |
-        sudo apt-get install -y wget git gawk bridge-utils \
-          iproute2 bzip2 build-essential \
-          make gcc zlib1g-dev libncurses5-dev iasl \
-          libbz2-dev e2fslibs-dev git-core uuid-dev ocaml \
-          ocaml-findlib xz-utils libyajl-dev \
+        sudo apt-get install -y wget git gawk \
+          libbz2-dev build-essential \
+          zlib1g-dev libncurses5-dev iasl \
+          libbz2-dev e2fslibs-dev uuid-dev ocaml \
+          ocaml-findlib libyajl-dev \
           autoconf libtool liblzma-dev \
           python3-dev golang python-dev libsystemd-dev
 
@@ -31,11 +32,11 @@ jobs:
 
     - name: Pre build stuff
       run: |
-        make mini-os-dir
+        make -j`nproc` mini-os-dir
 
     - uses: vapier/coverity-scan-action@v1
       with:
-        command: make xen tools && make -C extras/mini-os/
+        command: make -j`nproc` build-xen build-tools && make -j`nproc` -C extras/mini-os/
         project: XenProject
         email: ${{ secrets.COVERITY_SCAN_EMAIL }}
         token: ${{ secrets.COVERITY_SCAN_TOKEN }}
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 21 11:17:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 21 Feb 2022 11:17:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276190.472287 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM6gk-0007nG-A7; Mon, 21 Feb 2022 11:17:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276190.472287; Mon, 21 Feb 2022 11:17:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM6gk-0007n9-6N; Mon, 21 Feb 2022 11:17:06 +0000
Received: by outflank-mailman (input) for mailman id 276190;
 Mon, 21 Feb 2022 11:17:05 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=3jq6=TE=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1nM6gj-0007n3-32
 for xen-devel@lists.xenproject.org; Mon, 21 Feb 2022 11:17:05 +0000
Received: from ppsw-30.csi.cam.ac.uk (ppsw-30.csi.cam.ac.uk [131.111.8.130])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id cb5a71fe-9307-11ec-8eb8-a37418f5ba1a;
 Mon, 21 Feb 2022 12:17:04 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:58164)
 by ppsw-30.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.136]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1nM6gg-000trs-eP (Exim 4.95) (return-path <amc96@srcf.net>);
 Mon, 21 Feb 2022 11:17:02 +0000
Received: from [192.168.1.10] (host-92-12-45-187.as13285.net [92.12.45.187])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 42EAB1FB2D;
 Mon, 21 Feb 2022 11:17:02 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cb5a71fe-9307-11ec-8eb8-a37418f5ba1a
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <13166754-a4c7-b81b-2300-aab8c12a22d3@srcf.net>
Date: Mon, 21 Feb 2022 11:17:02 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH] coverity: disable flight from crontab
Content-Language: en-GB
To: Roger Pau Monne <roger.pau@citrix.com>, xen-devel@lists.xenproject.org
Cc: iwj@xenproject.org
References: <20220221094800.54169-1-roger.pau@citrix.com>
From: Andrew Cooper <amc96@srcf.net>
In-Reply-To: <20220221094800.54169-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 21/02/2022 09:48, Roger Pau Monne wrote:
> We are currently doing the Coverity Scans using a github workflow.
>
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>

FWIW, Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>


From xen-devel-bounces@lists.xenproject.org Mon Feb 21 11:21:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 21 Feb 2022 11:21:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276197.472298 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM6kr-0000mM-Rc; Mon, 21 Feb 2022 11:21:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276197.472298; Mon, 21 Feb 2022 11:21:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM6kr-0000mF-O3; Mon, 21 Feb 2022 11:21:21 +0000
Received: by outflank-mailman (input) for mailman id 276197;
 Mon, 21 Feb 2022 11:21:21 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=vyL6=TE=citrix.com=prvs=04447c275=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nM6kr-0000m9-1X
 for xen-devel@lists.xenproject.org; Mon, 21 Feb 2022 11:21:21 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5cd1be96-9308-11ec-8539-5f4723681683;
 Mon, 21 Feb 2022 12:21:08 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5cd1be96-9308-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645442479;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=+TEyrVTQXFBVSM1Q9QxpNpJdYRg8WDQgf3eo/EPZlB0=;
  b=RBmZKFFwFNR6vuXYi9E3IcFiZn/16NZlJ9V0lGU0JYmrDZMyA1MSY3v+
   wZfu7vBiUxovw2JSFl2Lw5TaGHSpa4JloCOryZGUL8W5yOx0q+2IaOfxO
   uP92zP5sYgza/sH0tNbb9WwQwL8SbQIC470JL3HSVS92nS/XdMaXFIR3c
   A=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 66885205
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Y6NuaK7luhaOQg0i7WS+bQxRtO3HchMFZxGqfqrLsTDasY5as4F+v
 jQfXG+GaK6KMWv8LoxxPI2ypEsG78SExoU2G1BtqSA8Hi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFx2XqPp8Zj2tQy2YLjWlvU0
 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X
 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx
 umhurTuQh55DvzotN4ZThhoAidPObFdqY7udC3XXcy7lyUqclPpyvRqSko3IZcZ6qB8BmQmG
 f4wcW5XKErZ3qTvnez9GrIEascLdaEHOKsFvX5t13fBBOsOSpHfWaTao9Rf2V/cg+gQQ6aOO
 pBBNFKDajzFXyJsfQYTJ6s/hd+wiSH5XDQHq3Ss8P9fD2/7k1UqjemF3MDuUsOObdVYmACfv
 G2u12bkBhAXMvSPxDzD9Wij7sfXlD7/cJIfEvu/7PECqEaI2mUZBRkSVF26ifq0kEizX5RYM
 UN80jojq+0++VKmSvH5XgakuziUsxgEQd1SHuYmrgaXxcL84hmbLngJSCZbb94rv9NwQiYlv
 nertd70AT1ksJWOVGmQsLyTqFuP1TM9dDFYI3VeFE1cvoel8NpbYg/zoshLTqWs3u2kPR3Kx
 y2LnDk4trEPlp86/vDulbzYuA6Eqp/MRw8zwwzYWGO58w90DLKYi5yUBUvztqgZctvAJrWVl
 D1dwpXFsrhSZX2YvHHVGI0w8KeVC+Fp2dE2qXpmBNEf+juk4BZPlqgAsWgldC+F3ivpEAIFg
 XM/WysMvve/31PwNMebhr5d7OxwkMDd+SzNDKy8Uza3SsEZmPW71C9vf1WM+GvmjVIhl6oyU
 b/CL5rxViZGWPk2kWDnLwv47VPM7npjrV4/uLihl0j3uVZgTCX9pUg53KumMblisfLsTPT9+
 NdDLcqaoyizo8WlChQ7BbU7dAhQRVBiXMieg5UOKoarf1o3cEl8WqS56e5wJORYc1F9y76gE
 oeVARQDljISRBTvdG23V5yUQOmxBc0m9SpjZ0TB/z+AghAeXGpm149GH7Mfdrg77u1zi/lyS
 vgOYcKbBfpTDD/A/lwggVPV9eSOqDzDadqyAheY
IronPort-HdrOrdr: A9a23:1aWSGK2oTSye30xDLy0MqQqjBV5yeYIsimQD101hICG9Lfb2qy
 n+ppgmPEHP5Qr5OEtApTiBUJPwJk800aQFm7X5XI3SJzUO3VHHEGgM1/qB/9SNIVyaygcZ79
 YcT0EcMqyPMbEZt7eC3ODQKb9Jq7PmgcOVbKXlvg9QpGlRGt5dBmxCe2Cm+yNNNW177c1TLu
 vh2iMLnUvoRV0nKuCAQlUVVenKoNPG0LrgfB49HhYirC2Dlymh5rLWGwWRmk52aUIF/Z4StU
 z+1yDp7KSqtP+2jjfaym/o9pxT3P/s0MFKCsCggtUcbh/slgGrToJ8XKDqhkF8nMifrHIR1P
 XcqRYpOMp+r1vXY2GOuBPonzLt1T4/gkWSvWOwsD/Gm4jUVTg6A81OicZyaR3C8Xctu9l6ze
 Ziw3+Zn4A/N2KNoA3No/zzEz16nEu9pnQv1cQJiWZEbIcYYLhN6aQC4UJuFosaFi6S0vFrLA
 BXNrCT2B9qSyLaU5iA1VMfgOBEH05DVCtue3Jy9fB8iFNt7TNEJ0hx/r1rop5PzuN+d3B+3Z
 W1Dk1ZrsA+ciYoV9MPOA4ge7rBNoWfe2O7DIqtSW6XZp3vfUi97qLK3A==
X-IronPort-AV: E=Sophos;i="5.88,385,1635220800"; 
   d="scan'208";a="66885205"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ihsyA9IwRqPkNIvD3sngqwPAhdcVP7WCjL3Ux07LzDs1rLrgadeYoIzkUTRHnUC2485arSMB+Vdcn9g4NMcWjCFH4p4+8WdCAsntH0fwjTUZuS0sF9B0PNJPZNzaqWnQ9J8yHMrnxDuKJE6knqntl9acz8/qskoisKmqxiDPNFAGr7OMSFW8gaGylUSsZL3vRA5YozNBTCMn/xOas9kGpZt6VRzsWP4IXZjhBzz0WMZI+VmlMptI5OqHVrAJNrKgux1zXqdrw4TILazx3rAFGD5rqfTKcKSXcoPV9La8IsGX3oQupK4F+fQYsyOMQgkAF532wf3zkt/ToCXkiu/BHw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=7HJSCi6QRDFHBTnJs9UufTYNWmzrJqGJ4dR+pYk6nBI=;
 b=ZCgrRhx0Q8E7HrbWJTMqXs/scfu/4FA4DfY+wbI0cU6VP+S+xa3QqtovnIJr+H9mgPXDOcxxt16J7QWZq3+hif4DETLwdMMCII6d5UYxR/rUlVZdLBBgDUUckjMuGcAjHqvK5bVqDCMH21EWhlVjacI7MUQm7lRUj5HKK4NIa6AbCmyZHB7bowYxH17f8BNEdKQb+SDcNDvKYtBVrekMyphpRvNYivspbz5xjGQxUVFqTlsSQROliM/ir+PzgGZHEbLhaHkLPZSAS0E29fdtt0g/Vh8Y1PmdYw2lD32LVafuxP4KGXP+Nb8cstpRWp8veH1PPDbbaHDyrtmW1BCytw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=7HJSCi6QRDFHBTnJs9UufTYNWmzrJqGJ4dR+pYk6nBI=;
 b=GEVx6KEdB+OlVflYtcG5jswBJaelS4Nfj3oliegg+rlMxiBik5FaEeVhGhq8ec1/4Oeiq+krf13wWU+i0pAu0wMevF1xJOqo+GyA9MfsnLka/hsW6eu2kPtn7zO/YvoM5IiORSFcrZemzYdFqGtbwiNxjnWEIkqZvXRpy75qnEY=
Date: Mon, 21 Feb 2022 12:21:08 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, George Dunlap
	<George.Dunlap@eu.citrix.com>, Ian Jackson <iwj@xenproject.org>, Jan Beulich
	<JBeulich@suse.com>, Stefano Stabellini <sstabellini@kernel.org>, Wei Liu
	<wl@xen.org>, Julien Grall <julien@xen.org>, Paul Durrant <paul@xen.org>
Subject: Re: [PATCH 2/3] xen: Rename asprintf() to xasprintf()
Message-ID: <YhN1pJIDIiJscvjF@Air-de-Roger>
References: <20220221100254.13661-1-andrew.cooper3@citrix.com>
 <20220221100254.13661-3-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20220221100254.13661-3-andrew.cooper3@citrix.com>
X-ClientProxiedBy: LO4P123CA0504.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1ab::23) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 11b819c1-2634-4f0b-0a56-08d9f52c4503
X-MS-TrafficTypeDiagnostic: SN2PR03MB2238:EE_
X-Microsoft-Antispam-PRVS: <SN2PR03MB2238C4922A277DD655607B418F3A9@SN2PR03MB2238.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 0cbXuIAYsO8kDFajU/piHyWVJtdeyhGcjzl85kZHJ6fp5+o9/rrhyj7x88nJL4mrnGj1R/tcrfWzkNl6BDZY9o502GCmKy+/T1kzc6dtAeVG6fjamoKaHa7qUjRpvIInOAbgFi+vutHUC4GiakR7P493FUvKVlnH64barzP5I4skzSvqhqLeU4ERR8WfVNUA/csyj0CqhFSThZWVDoXx9HUwGTOLycO2PwYdaSQz+/CSnXF4Cd2Wb+Ku1rZRG7rUpTHhbnpQroQ8oYED5+U45xAtSqqkFTonI1RJyKexAXUjDvg4Gi9Cf6GdR3BN6iFZ+YjGVIR9ejgpe+VxQoAvVnbby+UtjLdcVD27Mvtx24rSYWc/CfF0LMkMpslRmPwT4DoHl/+dBbfm1iS/JI1hWgbphz9IhOsUtHS87fB0IvzPa44E1qnHUf77U81IKxhyr+3cN5qo1AkUdd/HYoQ2qBvVCbu+Kq0T4bq2C3TBmfT3Y0g4shoycuwnDstDAzdAcrcuuIjy4ewuxKdG8A8fh2kf1LgNECOZZSy1mSdUhC+ETsrSscY4f+J+PJq0HgfyWdBVCiJxt/3ehHM2gWZJh6KOKkzDo8NJe7oZJ9eiFjAlqgNFU6pGX0ac6NRVfkmixkknF1Y2sdqoXhX/etCgcA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(2906002)(6666004)(54906003)(6506007)(4744005)(8936002)(85182001)(6636002)(5660300002)(186003)(508600001)(6486002)(8676002)(26005)(4326008)(6862004)(66476007)(66556008)(66946007)(38100700002)(9686003)(6512007)(82960400001)(86362001)(316002)(33716001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YVhaUWVjL2lrOEZ3Tyt0RXRTYnB0eGc3WkVjTVhOa0J0ZDR4ZDVVUDR5S2Va?=
 =?utf-8?B?RUJnV2ZzQ0w3WjE5TVo2eHpuTUNjQ3M0UWlaUWEwU2RVMUJJeFl4MzVwSFh2?=
 =?utf-8?B?VkcyVVBxZlNRNkIwSzRWZFJzeXVIQXJwK2lsTWxrNUZKSEtrMCtVQjdDeStN?=
 =?utf-8?B?U2c1Wi9CZlRTQWhSYllMU2Z3MzdZT3ZWbWhqZXMwdmhVOHBvRGtMWkhvb240?=
 =?utf-8?B?NjdxSjZwMDY2Y295SUJ4blNJRDhYY3RWYmZzVGFLUnh0L2gzWUp6b3I1YlVt?=
 =?utf-8?B?ZVpvS0NvTWlJa3ZRWmpNU3Q0UUZudnVMbkhsVjNhQWtQd29vckFKa2Q4NlEw?=
 =?utf-8?B?ZmtraGxUWk8rdS9QblRsMEJNTnJLLy9XVlpQdC8rTVZHSnA0VkZVSWdoazVh?=
 =?utf-8?B?UnNjdGxCNE93d04zMlU0K0d1V25sbjBpTWpmSUVDRmtNUUhkVURCeHhLSkk1?=
 =?utf-8?B?S1ZsNE43VTZ3N1d0a3g5U0F0TzNEL01FMVJRbjY1TDZpam9LTGVOeVNTV1pQ?=
 =?utf-8?B?Z1NMd3Q4aEVWYmhjYU9YM3RHOHRIRjhQVTdHWkhIdWZDcndBWFJmOHBubDQv?=
 =?utf-8?B?cWEzbnEzUXR5T2xSMkZyT0RDaDBSaXY1akR2Yzd4MGFlTWJZQ2VyeFhYQXln?=
 =?utf-8?B?SkF3dVV0dTFLMnV2c1FmeUdZTmxtaWM2Vkd5WU9XOTFUZ0gwSDJyTVFBdGZ2?=
 =?utf-8?B?azhyWXpSQmRLWmF4c3YvdzA2YjJ0a245T0dRWjVrV1ZSdDNxMFcyc3JKYnJw?=
 =?utf-8?B?T0pBeDhYZThyUTVzWFAzckF0VkxCME54Y1dVM3dsSXg0YmhuandMT0VPbHk2?=
 =?utf-8?B?TVBMZTdOUnhCeldLQldHRG1vYzZicFpnMDlwOG1aVUQvV0gzakFPL2NwbTNY?=
 =?utf-8?B?bmFQL3gvWEFhRTZ6dVNIMndGV0Rka2h5c1EvL3RJNGpBMTRyOTc2ZEErRE16?=
 =?utf-8?B?ZFBJQVlkcjk2Zk9nNG9lYXhzTXJCZ1VuRHgrSW8vekswRS9JZWZ4WDlTK0Rx?=
 =?utf-8?B?RTUzNllLTm5qS3BYQzVrN2ZobmpERk5hMUNKSVJGQk5nTkFSSW43MDNHa0tm?=
 =?utf-8?B?UkxkUUpuMGEyUXliVHpycHJyWStqT0JsK3dxdEVUMXhyakd1ZVRieU1QcUw4?=
 =?utf-8?B?MWRZT1pyQXdRZDloZ3UvZE1xRGQvSGJIVFJGbnp3dzZxUU52Mm9GTFZncy9Y?=
 =?utf-8?B?amZJU2N1VkNrNElvNGphQW5vN201UU14emxIN0NySGsvVmx3NllTVUUzV3BG?=
 =?utf-8?B?Y2JwNkxCeW1mdVNKdDBlS2E0RmMyUXEyem9Bc1ZKYnNFditBblVJM1AxdG5y?=
 =?utf-8?B?RWR2SkdKanBpbGVZQ3hzTU9jYmdEWVRKcm1JMitKM3o3NFRIdlRHWmtNWWpK?=
 =?utf-8?B?MlFOWm5sRkY4RUd6QmV4L2VaQUhkRlY3SCtDT3lsVktxdG4vM1VHWUNxUHcw?=
 =?utf-8?B?TEV5b2J2K0pLQUxIc2JrSVFtb1ZvVUVOY3VTdEtBVGRKNmk4WWZRbDV1V0RU?=
 =?utf-8?B?S1pIZ2EyNE9Id0Nad2xPcVBjRlFTLytPSElMcENHMlNYWWc2VzNmcXh2WXV5?=
 =?utf-8?B?c2htS0c0NnlyN0xJcjYxVDJYN0hzUXhyNU5OZ2l2U2NXVG0xTllNNHVURzZ0?=
 =?utf-8?B?d3NoZHNlY3k4Y294QVYwRDMzclczaTQrWUtvTHpKem94NUZiMlgzRWc5RnlE?=
 =?utf-8?B?QUU0b0M2VzNGUTlmZDZQY1VGcU1kRDMreGVNSTZWbWFLazBTcENIUS9ITTNo?=
 =?utf-8?B?anpFUkJMSzlodE1xWXhpbzJNOGdFcDVMdjd0WFBmbS9xR0MwVTloY1Jvd3Y0?=
 =?utf-8?B?M2NNdUk5ZXZBT21RdkVRVGVDaytzRS9vaTBLMnF5STRmb2hNVzRBV2VSdjA2?=
 =?utf-8?B?VTkyY2tIUmdwMzBObnd4cG95bmJQZkVVZ2ZNQU1UTTVDcmhYd1dEWktoY0NO?=
 =?utf-8?B?TXl0WDkyWjV6L0FrTzRHeXJzNXF0ZEU4RTBDTGxxaHB6YWpNS3hkUDFnSjlE?=
 =?utf-8?B?T0tVT2x5QkdQYm12em13VE40NHZlZ1pqTTlwdW85MVF1Ni95NUV2ZnEwYnZL?=
 =?utf-8?B?OVkreE5LQ3hCSHNtNkx2YjZyd0RFeHIreWJWYVpaRkYvM0lhdm1XbFhIVy9V?=
 =?utf-8?B?VmJ1bUV5aDlJckVpSDF6OUZyUEt0eWtIWVBGdGtOcnRKQTBVNVZRcW5zWEJT?=
 =?utf-8?Q?w5BKK5gdczdzlpWqZLNrHIE=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 11b819c1-2634-4f0b-0a56-08d9f52c4503
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2022 11:21:13.5922
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: V8zAVZNyj8rnxsa+fz/202y9LJZpaJCaGEvpGDuHm/Q0fWxH0JtpCcyGk/TfzMHOBH3Jg9JkZ8f+cTvWYNNOGA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR03MB2238
X-OriginatorOrg: citrix.com

On Mon, Feb 21, 2022 at 10:02:53AM +0000, Andrew Cooper wrote:
> Coverity reports that there is a memory leak in
> ioreq_server_alloc_rangesets().  This would be true if Xen's implementation of
> asprintf() had glibc's return semantics, but it doesn't.
> 
> Rename to xasprintf() to reduce confusion for Coverity and other developers.

It would seem more natural to me to rename to asprintk. I assume
there's no way for Coverity to prevent overrides with builtin models?

I've been searching, but there doesn't seem to be any option to
prevent overrides by builtin models?

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Feb 21 11:23:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 21 Feb 2022 11:23:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276204.472309 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM6mX-0001Mc-6K; Mon, 21 Feb 2022 11:23:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276204.472309; Mon, 21 Feb 2022 11:23:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM6mX-0001MV-2y; Mon, 21 Feb 2022 11:23:05 +0000
Received: by outflank-mailman (input) for mailman id 276204;
 Mon, 21 Feb 2022 11:23:03 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=vyL6=TE=citrix.com=prvs=04447c275=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nM6mV-0001MN-7m
 for xen-devel@lists.xenproject.org; Mon, 21 Feb 2022 11:23:03 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a0298334-9308-11ec-8eb8-a37418f5ba1a;
 Mon, 21 Feb 2022 12:23:01 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a0298334-9308-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645442581;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=84dfLuUw48tLr8hcoJxS8VdICR95+uzTniCUobBpreA=;
  b=ACEHoPxAX4S/Sr2Gcb6fp6GssyNUbcnRn9FBaf6HmiqoLrJ8v6Fw1g6z
   Um0Jn/sDCr8CgweVuai8qy7I/mqH0QMnZ0wV4Nxs65KNjpQZKWegZgzfX
   8ymKMr/mKnTIXFPi5ErGem0cInnu+79jD0oViSnCY9iPaSZErymYFU7pc
   c=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: None
X-MesageID: 64077880
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:khOvWaBfy9rTAxVW/4vhw5YqxClBgxIJ4kV8jS/XYbTApDpwhTQPy
 zMZUD2FO/zcYmqneNB3YIvnoB8F7MXTz9dhQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YhFWeIdA970Ug5w7Rj29Yx6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhg1
 /hd7cy6ajsyJ4ORubg+TDt4M39XaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguw5K8bmJsUHs2xIxjDFF/c2B5vERs0m4PcGgG9v2ZAeRZ4yY
 eIWNztKPEribSRuYHYHBqoQut32vUDgJmgwRFW94PBfD3Lo5Bx81v3hPcTYfvSORN5JhQCIq
 2Te5WP7DxoGctuFxlK4HmmE37GV23mhAcRLSeP+pqUCbECv+1H/wSY+DDOTifK4llS/S5RYL
 UkV8TAptq886AqgSdyVYvFyiCLsUsI0MzaIL9AH1Q==
IronPort-HdrOrdr: A9a23:JaXjj6wtnthYrfD1PhXAKrPxzuskLtp133Aq2lEZdPULSKOlfp
 GV8MjziyWYtN9wYhAdcdDpAtjmfZr5z+8O3WB3B8beYOCGghrSEGgG1+XfKlLbak/DH4JmpM
 Jdmu1FeaHN5DtB/LfHCWuDYq8dKbC8mcjC74eurEuFDzsaE52Ihz0JdDpzeXcGIjWua6BJcK
 Z1saF81kWdkDksH4yGL0hAe9KGi8zAlZrgbxJDLxk76DOWhTftzLLhCRCX0joXTjsKmN4ZgC
 L4uj28wp/mn+Cwyxfa2WOWx5NKmOH5wt8GIMCXkMAaJhjllw7tToV8XL+puiwzvYiUmR0Xue
 iJhy1lE9V46nvXcG3wiRzx2zP42DJr0HPmwU/wuwqVneXJABYBT+ZRj4NQdRXUr2A6ustn7a
 5N12WF87JKEBLphk3Glpf1fiAvsnDxjWspkOYVgXAae5AZcqVtoYsW+14QOIscHRj99JssHI
 BVfY3hDc5tABKnhk3izylSKITGZAVxIv7GeDlOhiWt6UkZoJgjpHFohvD2nR87heYAotd/lq
 H5259T5cJzp/8tHNJA7dg6MLmK40z2MGTx2TGpUB3a/J9uAQO5l3ew2sRw2N2X
X-IronPort-AV: E=Sophos;i="5.88,385,1635220800"; 
   d="scan'208";a="64077880"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=fqAgtywIm0AF8gV7aA6rNTR/JgiTqQIDRUFqb+tfk9D0FOrQX8uQzLsym3HCH6ZmGfGbPrRLGmv7i+ireoNOB85v/uYknxsPBZsrBs8an2G/+VHFQ6nXmWcy46KQumm1kz1iTd/pvvGnF5XLo3fL3U1jivqCWeUXjJpUJXa2ysJYbHApSgPMVLTUMEtpp/WRRkdU95lzQWM4EB6+UrjMu8x27JTqa2yOaxusR4Y2pEsvAdM9VM4qns1MOtPqOPySR9NqEZRt2V+PwY1/QBAVIdaf0IKT4BbisgCBp4VbB+xVEgdRqojDf/OGD0u8GNykeNgVP0dynxuipJW2cZm4QQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=cyP3NvFc2eA+7KphrckpEBLZXRPXgZnfmA/PNygsoJ4=;
 b=C1XGfx7tFo+auNFRuYyqS8M5jwqRE1odSGkSPGqrYuMY6ztdeIMfNgYGrDQgJ7rS2Q4YKBSpwHzH2jY/Gq1l4tak0oqpr+covBtUhpBG3sTfzvPcZbFmhDVtXc7cJfRFgmAOI+lAWWvu2bvhEfRo4T74FvSu5Ovuxlo+CjtLf4gRm8ZsICauGg0No0VlguoQ9vicrK3O1YLswX6dEExyyYhCuBB2cUJ5olydWMbYAMgKrktcfUugf7aH2or0kQYLyiBou847IseQcKS+e3kSO0qYlV/tYYZOVeDY1G5oxRnwOLSF7zjpz4ANzRNKbPyGPy0LdRxeY7NY6CrNpdXSrw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=cyP3NvFc2eA+7KphrckpEBLZXRPXgZnfmA/PNygsoJ4=;
 b=YlW+1cjeOSrZ+Y5EmQNaCv72kHDydJl0lBU2QrgrPkEj+Hy1fHeZ8HUnfPFUXdJiJrE08dOrY/jh73ECoOcFC4LBCAP+7b6HnELSgpJGS8u46OlCCNA4osfVYq1Sm3Gc4dBdNtYPkmngz7yOODahTCdvh4FtEV1pbiZ1jStXgmI=
Date: Mon, 21 Feb 2022 12:22:51 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2] CI: Coverity tweaks
Message-ID: <YhN2C6flrMKJkrO3@Air-de-Roger>
References: <20220221100254.13661-4-andrew.cooper3@citrix.com>
 <20220221111454.2925-1-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220221111454.2925-1-andrew.cooper3@citrix.com>
X-ClientProxiedBy: LO3P123CA0007.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:ba::12) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 746cdbae-d255-47e5-e271-08d9f52c8209
X-MS-TrafficTypeDiagnostic: SN2PR03MB2238:EE_
X-Microsoft-Antispam-PRVS: <SN2PR03MB223839D40A27EEC92D7872A98F3A9@SN2PR03MB2238.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: crx0d2qyx9v2xGH4m4A5oS92Y+wZOf26GVYMjZgfc0QfZkdxtyHuZdxLT+s+qexmM6FWs9dVDn3QiqfSIc29TTAWJIAb32jepgwCtZFp7eha0M8g2SBFsQYhiKhOh4dGMrVBvecqg1MCr2iPtZjXoHIuLzE9qjazWDkTJ9M+4TC3vWi1S53Y38rYvkG+8WdZG7+0fKy3B8rV0WUs5L15Qg4bTm39nDlVDxg99TMNb1beCGkquvXMxUmfB1FrNz+WIifAwooTYhV9GcnQfATa5efDtQ7fww62Qkv38ar0u9rtJrwaWsg6HOws7WSK/Ga+nZHYdf9LjyfseCukY4sdJQfsZBItrINYv+zAIUpDMok5Mqi5mZGY4FMwRMPbw9IPLiRieRobkIP63GJoiwH+V4gWaLIjGHOq+E0gpqdm4IzXQ+FzOQN1NErVe6jhuCpJMMXbmqWY40FEngOmIa/9rlp2fyTLOKZyKUxeeHhxdthQJzJhcE997QI5I94uJPvRrQ8HSpNphF/ashPQTPC7tUgPJ62ihTv8WJbpqpStth4xLxa9ZNtuZNTIOmB2QnMehHx02yro8kr8u7TcpGK19da1wrq5hAgr7Sr8MeQfq9iB2wIpkpBviEriOt2Eu0vPuFuT1BqITZr/cEJ7JrBuaA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(2906002)(6666004)(6506007)(4744005)(8936002)(85182001)(6636002)(5660300002)(186003)(508600001)(6486002)(8676002)(26005)(4326008)(6862004)(66476007)(66556008)(66946007)(38100700002)(9686003)(6512007)(82960400001)(86362001)(316002)(33716001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UmZ5Y0ozTTFVbFF6T0lndlpmU21weEpuQkcrSzZtdm1RYkRzYkNiRW5EV1lF?=
 =?utf-8?B?ZEtkR3crdTgyWENYMlpBdmpDSFVKOW40aUU5b1BFbzZsU0RyaWN3VFZpaDRh?=
 =?utf-8?B?anBjUmFHYktmUWoxKzZ0YzFldFRmYVZRTy8ySjZWSkE1MVRzRjRRSlVSTXdU?=
 =?utf-8?B?YXFITjhSNEMrR1Azdktua3lGSSsxdXBPeXJ2Vi9BYUt5SmN1N3NqUlhYUUIy?=
 =?utf-8?B?Rng3U0psY2JldW9CS3lWZlE3UXRvMEdsQTlWN1lpNTlsODdCU2N5RGZsUnB2?=
 =?utf-8?B?WnA5U0czSWwrNStDejZ6S3hzMHE0a3B4L2ZkcE5qQVJCeTZlTy9GTDFIMmkr?=
 =?utf-8?B?OU41V3RoTFlkRzZPQWJpN1UzOW0vS09McUEyMVppb2l3RlE5RDNPRER2c052?=
 =?utf-8?B?S3dqeHVmWjFKWTVoZmVCUXkxa3Q1aEEzRDBMNmFXVHN4eGNEZWFOWHRzV21F?=
 =?utf-8?B?ano5K3RxYTl0ZkZZMWRLR0FFeXJMMEhTdmNJOEZWNlVadmFoWk05QkR4RGp5?=
 =?utf-8?B?enc4NCtoNmJlSWpQK0V3dzJORDlPOHBmREFwYTdwcjFuRENveGQ4eU1nU3dt?=
 =?utf-8?B?VG9ML3plbzMzUnYxSkFvUW9ZWmRnK3ZBVTdJTXdFTlYxR1VyU0tRMU5mZEda?=
 =?utf-8?B?SzVHc1NWbWRWVnI5VUg3VHFBeUdSYlFWRnRGMmE0RzJ4SXBmcDBLNVZnWlF5?=
 =?utf-8?B?UjE4bGhGN3lVeGVhenlBajVFUTl0U2JUMXhwWmRFRXB3U1ZwdDBQR2JlM2p0?=
 =?utf-8?B?bUZXbnZDVXBrZXNBWFphY3lSY0pTV0FIajBPSHNwOFdqM2MwRU9zdmswVitI?=
 =?utf-8?B?eDlCZUdYS1d3d0tlNThRUG1lL1ZmN1I5ZVhCRUdnOFFjRGJXZk5mZXFZMWxz?=
 =?utf-8?B?bnNhdm1LUHh2V0o3czN5cHZzdkZLdVRBMFBHY3hJZjVRRVphM0tabW94a3Jw?=
 =?utf-8?B?d0xnZWUzQUlsSVdDajIvZCtTdlg0U1VrME0wdjdKTk01T2IraDgzdUx6U0ln?=
 =?utf-8?B?NEhhQ3JLdjMyeFpNcHdPTlJMaXd1QWZaTGRsdTgwMXo4UnBiS3k2NE5VaXdC?=
 =?utf-8?B?WlExdFlwaGxiMkh4Y3NiSi9DQnBGWEdVNWdkeGlsOTA3UkNFb2xqREQrTm9T?=
 =?utf-8?B?ZHpXRDBTKzFVMjZzaS9ucXo3eHczVmpkcG5XOUE4TVV6UHd4UkZmczhFbHEy?=
 =?utf-8?B?bStoTmJnTFIrb2UvN0hpdGd2VmE5azM1ZXBjTE44akFRYmhuTU0vcFFjeDJy?=
 =?utf-8?B?RTdZUUdWY3BBQVlGMXd3Tjl1dE91OGRaR21XL0p5TDIxWGlJVlV6dVN1dll0?=
 =?utf-8?B?QUFIaStCbW41OHdNZ3lVZVNHOS8rckJwOVJPZlp1c294Umw4TFptWDVWc0o2?=
 =?utf-8?B?Y0YvOEFtUGhSOE1lRGlYR2lHSVBBQjNqTUF4NTRrS3hvUncwdHRHS1pWY0NI?=
 =?utf-8?B?c1NVWktsRUFTZmt1MVVwMjBrUmxETXh6ak9PVGVzQ2Nlbkl1YzBMQjY0S2ty?=
 =?utf-8?B?WExudHVpSDRtMWVVUi9rMnJveUgzSEFrNGJicHc5V0ptZXBnQVhFN0V4eDBs?=
 =?utf-8?B?OW83Z05QdEgxY1VUSnZTQWdINGxqdERoT2F1Qm5Xb2NSaHZJVllSSVBkalhw?=
 =?utf-8?B?SWd4V3hhK0R1NzMxMUxvanRJZS9iQjNCWnplYlF4a2ZlRmJPM1RPV1gxVmFq?=
 =?utf-8?B?Q3MrSWgvb0E0dlY0emJKbXF1WStZVVJiOFZqMEFsdGk5V2ZaekpzcmZpZUll?=
 =?utf-8?B?OXpjMTAxR0dXVFNjL2xCMXc2ZXQ5QUZJM1lBTDlFN09SUjhSWFd4cXNiMHh0?=
 =?utf-8?B?cU82c0RINVZHMHd0VkxBWFkwZlNNSktBbmFVU2ZRRjVadkhyMmNXQW05M2Y1?=
 =?utf-8?B?SUFLT0VUUDUzdDBPSk80UTJJVE9NbjV6QlJ4S0VvM1lTblJNV01VWmNGRkFW?=
 =?utf-8?B?eEZUNWR1c3VaQ3dYZDNzVVR5REhGZEtURTRYdWJZVUo3UEFXa2IyeEpOUmh4?=
 =?utf-8?B?azM0c0RvWG5HdHBMUTFKUW1LNVhKcnNaTGJaczh0UlBJZHlVYXM0YjdHRDd1?=
 =?utf-8?B?bW1nUmFrcGNVZFRLVjZmVTZaRDUrUm8wNWs0dFpkWU5BQTlscVhnL1RnNnNG?=
 =?utf-8?B?bDdFOG1waHU3bGN3Z2pmenFiMjBpdENWOGNJazU0NFVhbWVBdWlvTzloZWtT?=
 =?utf-8?Q?VtjNtXUlEXw+9cpR91QnpOE=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 746cdbae-d255-47e5-e271-08d9f52c8209
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2022 11:22:55.9312
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lry29v/p8vKTfVoa7xABIPEzs9kXZpu00wGpEGhE6Xf+kyKeu8MisF1QesaVPeD11Td2RCT6v2aJhxYqv+MJQg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR03MB2238
X-OriginatorOrg: citrix.com

On Mon, Feb 21, 2022 at 11:14:54AM +0000, Andrew Cooper wrote:
>  * Use workflow_dispatch to allow manual creation of the job.

I guess such manual creation requires some kind of superpower
credentials on the github repo?

>  * Use parallel builds; the workers have two vCPUs.  Also, use the build-*
>    targets rather than the ones which expand to dist-*.
>  * Shrink the dependency list further.  build-essential covers make and gcc,
>    while bridge-utils and iproute2 are runtime dependencies not build
>    dependencies.  Alter bzip2 to libbz2-dev.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Feb 21 11:29:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 21 Feb 2022 11:29:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276213.472320 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM6sD-00027T-05; Mon, 21 Feb 2022 11:28:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276213.472320; Mon, 21 Feb 2022 11:28:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM6sC-00027J-ST; Mon, 21 Feb 2022 11:28:56 +0000
Received: by outflank-mailman (input) for mailman id 276213;
 Mon, 21 Feb 2022 11:28:55 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=fvXl=TE=citrix.com=prvs=044a77a3b=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nM6sA-00026z-WD
 for xen-devel@lists.xenproject.org; Mon, 21 Feb 2022 11:28:55 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 722bc29b-9309-11ec-8eb8-a37418f5ba1a;
 Mon, 21 Feb 2022 12:28:53 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 722bc29b-9309-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645442933;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=n5apCjhoVMy71g7V5RBuAG/yN31n8pPIi39Bvc9yN5E=;
  b=Lm8EHMK/B0RcouA2DjSnsWN24fqgI3Mygw3W805lXAjf8YaHCJeujHnG
   I7Ccf33KayG0zztbltH+V5M02y8YhDintEHIEp75Vr7DZHevPZ1W5r0Oi
   q+78uIURleBJAiFSrvrI2ijgE+Ac/aYnJqoLzro+DkbhYD0eW1MlvWGl1
   k=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 66885553
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:hIPcV60FkxEPFO3GqfbD5QNxkn2cJEfYwER7XKvMYLTBsI5bpz0Ax
 zFKCzyAOq3bMDfyfoxzO4ripE1Q7cDQm9QwGQFspC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk0GE/NtTo5w7Rj2tQy2IDga++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /1Llqy9cCUEY5fyo+AYUh5AOGJfAoNvreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHCOo8Ft24m5jbeFfs8GrjIQrnQ5M8e1zA17ixLNaiAN
 5pENGc0BPjGSw9sNnRIS8xhpsKTql6hKxtlq2ynu7VitgA/yyQuieOwYbI5YOeiWsF9jkue4
 GXc8AzRAAweNdGZ4SqI9DSrnOCntTvyRYY6BLC+sPlwjzW73XcPARcbUV+6p/iRiUOkXd9bb
 UsO9UIGvaU0sUCmUNT5dxm5u2Kf+A4RXcJKFO834x3LzbDbiy6YGWosXjNHcMYhtsI9WXotz
 FDht/HDCCFrsbaVYWmA7brSpjS3URX5NkdbO3VCF1FcpYC+/sdj1XojU+qPDoazre34IBPdn
 gq0lyw7hrILpo0q6IuSqAWvby2XmrDFSQs85wPyV22j7x9kaIPNW7FE+WQ3/t4bct/HEwDpU
 Gws3pHHsbtQVc3leDmlHb1VdIxF8cppJ9E1bbRHO5A6vwqg9He4FWy7yGEvfRw5WirolNKAX
 aMyhe+zzMIJVJdJRfUuC25UNyjN5fK9fekJrtiOMrJzjmFZLWdrBh1Ga0+KxHzKm0Mxi6w5M
 przWZ/yUStBWfg2kWvrHbZ1PVoXKscWnz67eHwG507/jer2iIC9Et/pz2dinshmtfjZ8W05A
 v5UNteQygU3bQENSnK/zGLnFnhTdSJTLcmv86R/L7ffSiI7SDBJI6KAmtsJJt0695m5Y8+Vp
 xlRrGcDkwGh7ZAGQC3XAk1ehETHB8gn9itjZXR2VbtqslB6CbuSAG4kX8JfVZEs9fB5zO4yS
 P8Aes6aBe9IRCiB8DMYBaQRZqQ/HPh3rWpi5xaYXQU=
IronPort-HdrOrdr: A9a23:ScxaAaEfCic+8bEepLqFRpHXdLJyesId70hD6qkvc3Nom52j+/
 xGws536fatskdtZJkh8erwXZVp2RvnhNFICPoqTMuftW7dySWVxeBZnMffKljbdREWmdQtrJ
 uIH5IOa+EYSGIK9/oSgzPIUurIouP3iJxA7N22pxwGLGFXguNbnnxE426gYxZLrWJ9dP4E/e
 +nl6x6Tk2bCBMqh6qAdxs4dtmGg+eOuIPtYBYACRJiwhKJlymU5LnzFAXd9gsCUhtUqI1SsV
 Ttokjc3OGOovu7whjT2yv49JJNgubszdNFGYilltUVEDPxkQylDb4RGIFq/QpF4t1H2mxa1O
 UkkC1QePibLEmhOF1dlCGdnjUIFgxeskMKh2Xo2UcL6vaJOw7SQ/Ax+76xNCGpsXbI9esMoJ
 6ilQiixutqJAKFkyLn69fSURZ20kKyvHo5iOYWy2dSSI0EddZq3MciFW5uYd499RjBmcga+S
 hVfbXhzecTdUnfY2HSv2FpztDpVnMvHg2eSkxHvsCOyTBZkH1w0kNdnaUk7zo93YN4T4MB6/
 XPM6xumr0LRsgKbbhlDONERcesEGTCTR/FLWrXK1X6E6MMPW7LtvfMkf8IzfDvfIZNwIo5mZ
 zHXl8dvWkue1j2AcnLx5FP+gClehTKYd0s8LAo23FUgMyPeFOwC1zxdLkHqbrUn8ki
X-IronPort-AV: E=Sophos;i="5.88,385,1635220800"; 
   d="scan'208";a="66885553"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=WP/6U2nnyCnIiEfY0d60OP60WJgdSYpV2DEyiSyKk4XaBYD3kIdx7G5RHlz8yzFvbCHuiNlFtg9skVQbDyGIukVLjkXq3zDdoXCucKHOQmz5eCjgM4He9edQChIhuEiTHO1ZJWoHponD21cG+pyS5y3rMKq36LUe7cOu2qlRSagmbofU7c6bpWBx0xUC2ByKAeZLzyRDEFP3nnpHdRhXaBFg3584enJxD/QpzWFXHgGsV2iDpfMctM5IcQArtSJQ4lH/ZfcRdC6NOYMLsTZClIOworqO9R/UqRV2xookCIqgiHbJWOX8xertfvvfl79DL9vq55R5bzLkjVIDL/BJbw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=n5apCjhoVMy71g7V5RBuAG/yN31n8pPIi39Bvc9yN5E=;
 b=gQ83Plxt4URdOF8lz2K0t1b+UuKJLhUfsTQZ75kcflIQ0syBd7SzyxNW08xlqu81biZS60YX7/3VHai1fTaW6Gj9qv4Hv7lm9iJsTUuvIF6rRmnbddd/ueOMk9xxd1wWZDBzdWKclyGmLUYfTk+gCrhHrcBqEbduTAqON+dVn4Dc+9f9JQZYe62gRJomOvqQo74+P2KYeidTa3cpXnzczQWlBsjb0ZbUhoeA+Uukmssj/26kIFKKaiZccH3gUQ+9LOKd0BDqd7vT1b0ulPfyTjc4ACMhYZx0lICY3mdf7Rc35I5ooY9ut08IhBETdQH1YGuthvdhc78CsJuXByToWA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=n5apCjhoVMy71g7V5RBuAG/yN31n8pPIi39Bvc9yN5E=;
 b=tTQwYyO1wK7ybzsmrwOPuimJ4L+PTQDOoFHvgGuX1xPT8a4RsbA0JWwqOzni6bbhAZ7oTdpgAoamiKaLjhzneLJ9PBKtxlbROxjDbE6rhByA9YATAB0JKWDDykjjQfwu3nzy71icU1PEfPtDhp/tHkY31eVBqBnAUx2USJgzcrQ=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, George Dunlap
	<George.Dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>, Jan Beulich
	<JBeulich@suse.com>, Stefano Stabellini <sstabellini@kernel.org>, Wei Liu
	<wl@xen.org>, Julien Grall <julien@xen.org>, Paul Durrant <paul@xen.org>
Subject: Re: [PATCH 2/3] xen: Rename asprintf() to xasprintf()
Thread-Topic: [PATCH 2/3] xen: Rename asprintf() to xasprintf()
Thread-Index: AQHYJwpOs0szyq0MVUKA4rk1u5+GKayd3CkAgAACGQA=
Date: Mon, 21 Feb 2022 11:28:39 +0000
Message-ID: <ada67c6c-bcd5-9732-c3e0-76032692ad23@citrix.com>
References: <20220221100254.13661-1-andrew.cooper3@citrix.com>
 <20220221100254.13661-3-andrew.cooper3@citrix.com>
 <YhN1pJIDIiJscvjF@Air-de-Roger>
In-Reply-To: <YhN1pJIDIiJscvjF@Air-de-Roger>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: a22a1778-6975-4590-53d7-08d9f52d4eb1
x-ms-traffictypediagnostic: SN6PR03MB3936:EE_
x-microsoft-antispam-prvs: <SN6PR03MB39364F0A8AD49BCDCB9D208FBA3A9@SN6PR03MB3936.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: RJQjLRNdtImNVE81BkKyf8wSYWP2TJ12+FwyjeTNvE6GNOCgPx5fOXva23Fnx5UHRMBSh9uZ6m/WF1qnBCgjEfc/CW982I4iRxir9y07f8Kj7GNEy1CGoQbIm5otQVZheTsvs1suBd4iUXT9pIh1NrycYIH8cSw+qK0O16mDmb+YfdIttLoCQsexFTKVxXfr5XXVcIAKtCkClP7mOChyCTBX8DbXX3cpdWWVOs+h2+sHg1YQK9DeuqqwDrLKqIBABrnEStkB8TfWaHLVsn6mzCLcYF+fphDrU3Tbq0AW7bkRPUYdANdb0UlSqX41nfhS7sgrfLEWPCfXscKNymfXNWnCOa0YmILy1Bvqjawoul/qNG3I+e5nz3rJDra/ap+p/I97u/EHt57LcnasQ/+wFrrvtI5W5kgWQWCWRXs8+lGPnF4mmM2IZtNZh8heKmu28vSztgd5lhUIOejod8eb3kb6RsqUhqssFIQnY5ML7IW3wL8c+jY11BQgFOgZjaz1fyxbhAaT6dstApOKw9rBB0ATKpIw3tP68Oia+0c5SL6ITzNNuqJ/iya2W9QKn37sCnusjvgMuryEw76fz2DtbnBKERsjDle8EP62qQ4I0QqHcSUTgKDBV3NzKNEDvBmyG4gERqPyDYRYucK4HVulX/kLGsjWhsvvKqQwZbLfUatULBvzV6wQpX7qgCEhJLeV6lyUzRMDi5jjg582qS/Pj9CsIUcBniguP5i3Y7+as1wH5K9U63TD/apUamj309UCpd0RI6uGKNsxj5UsQdpb9A==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(36756003)(6506007)(71200400001)(508600001)(6486002)(38070700005)(6512007)(53546011)(31686004)(2616005)(2906002)(38100700002)(64756008)(6862004)(4744005)(5660300002)(186003)(6636002)(54906003)(37006003)(26005)(8936002)(316002)(122000001)(31696002)(86362001)(82960400001)(76116006)(66476007)(66556008)(91956017)(4326008)(8676002)(66446008)(66946007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?R2w0dmlDa3FoTXFVUjVHcWk5SGVrejlqN1I5NUJkVlFSc2lEU1lDbVB2ZFhj?=
 =?utf-8?B?UURhN29jV3k1TmM0Y0lrNUZKb2dJWktQclJjRXZwUi80ai9ZUGdncUZpTG4w?=
 =?utf-8?B?aWozeTRVSHN3Wm4yblRBUnRUZjhiR0kzSC8zcC9KWFZsNTRxbXRBZTFja3NF?=
 =?utf-8?B?L01DTEJPR2h4SlJXNzVzYWxNcTRpLzZlRWNnaWpKNWhYVDI3dzhORW01K3Bt?=
 =?utf-8?B?V3dFeFltTmwrYlVYM05GQmQzWWZNL3ZRcXJQYWNIWDdkT28zR2tYSjk3YWkx?=
 =?utf-8?B?UjR2UjlVZFBhb1FJWStxV0ZEZTY4MXUwb2FHNFNvYm9kWnR5Z3FwMnhKdGtN?=
 =?utf-8?B?S041cXNRSi8yekttczFsR2NmUnEvcmxTb0l6SzRnYWZFY3ROd3l4Yk9vclNZ?=
 =?utf-8?B?RzZDVVdhanVQM3BkeW82d3hDVmp0cFhqZExoN3NkOGJQNmZqM0V2aWxvUndz?=
 =?utf-8?B?Y1BMMUg5bWZJQW83V0ZQM2ZxcmIyOU0xdkdHNUJpcFRBbDZYUTVGYlgzTmR4?=
 =?utf-8?B?SkFXaCtyWHFUWEcxaUJDdlZzS1plc0VUcVp5dWxlNDg4bTFrTHJZa2xtMWh6?=
 =?utf-8?B?ZXdmaHJ0YmMxaVRmTVlQS05qaS9iK3h2aGYzU1BhdnZzQXRIN3VObWw3QkNV?=
 =?utf-8?B?OHdsOW9RLzI0Z25oeFBSWElNN1djcTBTalRqNDMzQVlIRnpzSWMzVFRhSUZW?=
 =?utf-8?B?OTVwVWJXTkdoa1JiWk9LVlEvMC9xTTl1U1ZCUkE4RHlMN201K0FLTk1FTUtG?=
 =?utf-8?B?TXJCYjJJUXZBZUJtWkpnYnRhNmhuaFZ1VHBSdUREdy9YekZBRFNDRGRmQmNj?=
 =?utf-8?B?a3hoRmlna0N2enFvT1E1M0VoTW1CdGFDb0FvMEpXMHBDR05xeTV5MW9ucTJz?=
 =?utf-8?B?S2pLRXpGVzQweEVsNVNDc013bi9yTEJ5UlR1MGFyTFJYeFMvUFl0OWxRRGY0?=
 =?utf-8?B?MUl5QWlCeWVxNy80OTR5aUM2NlBqL3IydGNZS1lMRWZNYndpNERuR0dabFJt?=
 =?utf-8?B?eDczWERhUG9ETTVvNGd0eTM0WU80ZkFCaWJha2UwZXpraG1MdVF6bEJlMDl1?=
 =?utf-8?B?ajM1UldrZGVxLytSMHBpTzBIZkVtOWxCMjJJTzEwOEh0dFNDUmIvOTBSbzRU?=
 =?utf-8?B?cDJ1em41MkwrNktEcjdvU0tNampIaVUxcDhMOXRkZzFQczQzSUlkTk9kTmhr?=
 =?utf-8?B?a0tkV0FDMjNEdC82ZW1LYlU5WlQrSHcrdnhoOWdMS0dTcnB6QUQ3WmlDTm9j?=
 =?utf-8?B?cWhmakEzR1g2MHpvYUxVbE5VNFNSWW90V05uZWhHRVg1MDFaM0FMK0F3cU9v?=
 =?utf-8?B?bmk3MWFkRzV6bnQyaHJ0R2xHU3NQTkRldUV5ckp5TVVXNWIzc2J3TmZRamlN?=
 =?utf-8?B?RFRkQjNJbGFDR0IzR0NYNVRjUnNETEM4N3FSY0NZQ3BjWTlRV1pPWXhJaENK?=
 =?utf-8?B?SGtYdTk5UkN3c3BrNWxEMnk3QXlHbkNxMUFvOFNjVVJqaHlPVHIxYjl1TXJk?=
 =?utf-8?B?WWdTNHNTdzBKaHYwTDRQNXp1cDFhVXpoNzRqTjlIL016bFJGN2NXN0hSNEtK?=
 =?utf-8?B?M2h4VG4zZnVCeGh4UTcwbFRWRnBZdkkvalNPMUZocUhieG1xTklZRCtnNmRF?=
 =?utf-8?B?K3lIQXJpdUtnb1d2MDhxdHpGYytQTWZTVkkybWkyaWRxMFNVcklQMlhDakE5?=
 =?utf-8?B?RWpGa3VtZXZEMWZFQlpPL2hBRGZHZC94ZFo5Vk9ucGxibm9USldHRjBoY3pD?=
 =?utf-8?B?eERhcHBiWnJkNXNxYzB5aDhDYm1ORU5FZG0rOGJHeUEvS1hlend0TlAyYzZs?=
 =?utf-8?B?SG5SVUxkdnhPenJHaE1CZHd4M3FVMVp5Mi92Ums4Rjl0dVN1NThHbm1reVFi?=
 =?utf-8?B?RkVaLzExTUhFZmtGVkcwWGxJOFlTS0ptMlFWVVMrTTVZYnFOT21hQXQrYWFt?=
 =?utf-8?B?MVZOQnZiQ2Y0bkIzU1ZSeVc0L01Tb1BGNVVPczRFdEJkK0FyY2psa0l1bFlt?=
 =?utf-8?B?ekJpYy9pTEJFM1YxYWExR2FHZ2RZbTh5QkhSeXlhTUhvcjhOQVBxTyt4aTJ3?=
 =?utf-8?B?elZIR0U5WWcxS2ZVcVhsWjJqMzM5bGdDQ0llR2x0YzB6OGNxdlVaVXBFQ2M1?=
 =?utf-8?B?dER1MXRnbmw0NFRIVmt2dlFVMnhMYkkwaVJraXRaWURkNUJaNjI0Zi9DL1NB?=
 =?utf-8?B?VlRxRTZMaTJVaW1Od1ljTHo5dmQ1cnR3MkppcFVDUy9BZVNlRlNPVzZXZVVa?=
 =?utf-8?B?bU1Vc3dTaHpQYzAzaU5INERLOStRPT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <CB09A935AF18434EA6B6DDB19DC4D9C2@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a22a1778-6975-4590-53d7-08d9f52d4eb1
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Feb 2022 11:28:39.1276
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: /3tZBDhy5DxtyY5g+5RIlkr0JXA9VJnVAnyBOnTz/xNhLT1SaJDkgp2+PfM7H3jvk4Q9pnVl1NUxuL7uRJtd5GGbZxUxOdI8prKLhrkmfUg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR03MB3936
X-OriginatorOrg: citrix.com

T24gMjEvMDIvMjAyMiAxMToyMSwgUm9nZXIgUGF1IE1vbm7DqSB3cm90ZToNCj4gT24gTW9uLCBG
ZWIgMjEsIDIwMjIgYXQgMTA6MDI6NTNBTSArMDAwMCwgQW5kcmV3IENvb3BlciB3cm90ZToNCj4+
IENvdmVyaXR5IHJlcG9ydHMgdGhhdCB0aGVyZSBpcyBhIG1lbW9yeSBsZWFrIGluDQo+PiBpb3Jl
cV9zZXJ2ZXJfYWxsb2NfcmFuZ2VzZXRzKCkuICBUaGlzIHdvdWxkIGJlIHRydWUgaWYgWGVuJ3Mg
aW1wbGVtZW50YXRpb24gb2YNCj4+IGFzcHJpbnRmKCkgaGFkIGdsaWJjJ3MgcmV0dXJuIHNlbWFu
dGljcywgYnV0IGl0IGRvZXNuJ3QuDQo+Pg0KPj4gUmVuYW1lIHRvIHhhc3ByaW50ZigpIHRvIHJl
ZHVjZSBjb25mdXNpb24gZm9yIENvdmVyaXR5IGFuZCBvdGhlciBkZXZlbG9wZXJzLg0KPiBJdCB3
b3VsZCBzZWVtIG1vcmUgbmF0dXJhbCB0byBtZSB0byByZW5hbWUgdG8gYXNwcmludGsuDQoNCldo
eT/CoCBUaGlzIGluZnJhc3RydWN0dXJlIGRvZXNuJ3QgZW1pdCB0aGUgc3RyaW5nIHRvIGFueSBj
b25zb2xlLg0KDQo+ICBJIGFzc3VtZQ0KPiB0aGVyZSdzIG5vIHdheSBmb3IgQ292ZXJpdHkgdG8g
cHJldmVudCBvdmVycmlkZXMgd2l0aCBidWlsdGluIG1vZGVscz8NCj4NCj4gSSd2ZSBiZWVuIHNl
YXJjaGluZywgYnV0IHRoZXJlIGRvZXNuJ3Qgc2VlbSB0byBiZSBhbnkgb3B0aW9uIHRvDQo+IHBy
ZXZlbnQgb3ZlcnJpZGVzIGJ5IGJ1aWx0aW4gbW9kZWxzPw0KDQpObywgYW5kIHdlIGFic29sdXRl
bHkgd291bGRuJ3Qgd2FudCB0byBza2lwIHRoZSBtb2RlbCBldmVuIGlmIHdlIGNvdWxkLA0KYmVj
YXVzZSB0aGF0IHdvdWxkIGJyZWFrIGFzcHJpbnRmKCkgYW5hbHlzaXMgZm9yIHVzZXJzcGFjZS4N
Cg0KfkFuZHJldw0K


From xen-devel-bounces@lists.xenproject.org Mon Feb 21 11:32:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 21 Feb 2022 11:32:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276220.472331 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM6vN-0003VT-FV; Mon, 21 Feb 2022 11:32:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276220.472331; Mon, 21 Feb 2022 11:32:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM6vN-0003VM-C8; Mon, 21 Feb 2022 11:32:13 +0000
Received: by outflank-mailman (input) for mailman id 276220;
 Mon, 21 Feb 2022 11:32:12 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=fvXl=TE=citrix.com=prvs=044a77a3b=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nM6vM-0003VG-S7
 for xen-devel@lists.xenproject.org; Mon, 21 Feb 2022 11:32:12 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e7f019ad-9309-11ec-8539-5f4723681683;
 Mon, 21 Feb 2022 12:32:11 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e7f019ad-9309-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645443131;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=NDW+edNc7cwQ7Hai0uYaItVGfstAr2EWt3rCGOJRaEg=;
  b=Ywp83ZfwZGrU56Tq7W/SoTTavhJltdWJE+L8Xc5SovHtMaLZYhKAb8ok
   IlJU4awCgt3hpd264/sf1AupsKFUhnmNxS70sIQLyMCEi0BRw4i9AIxa6
   G0sNvkEvIGruoF37BmlTwcKoHaSsfyqF/7i4IwzSFkcgjdeyRpCwLRKRC
   Y=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 64640817
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Smv5d6OHadSLz4nvrR3Ml8FynXyQoLVcMsEvi/4bfWQNrUpw1mAPn
 WVLWmqFa/mDM2vze9snYIiw9ktXsJXcnNJkTAto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FV8MpBsJ00o5wbZj2Ncw2LBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z0
 NBLkpqWaiIQZIbViM0Tel4DTQJOBPgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALBc/nJo4A/FpnyinUF60OSpHfWaTao9Rf2V/cg+gQQaiCP
 5pANlKDajzfOxJ3amgoVa4kkeW0vV/jUCxop3WK8P9fD2/7k1UqjemF3MDuUsyHQ4BZk1iVo
 krC/n/lGVcKOdqH0z2H/3mwwOjVkkvGtJk6TePisKQw2RvKmzJVWEZ+uUaHTeeRkku4fNR5C
 GktoAE3vYE83QvwEPrNZkjtyJKbhSI0V91VGuw8zQiCzKvI/gqUblQ5oi59hM8O75FvG2Fzv
 rOdt5awXGE07uXJIZ6I3urM9VuP1T4pwXjujMPuZS8M+JHdrY46lXojpf4zQffu3rUZ9dwdq
 g1mTRTSZZ1O16bnNI3hpDgrZg5AQbCTE2YICv3/BD7N0++ATNfNi3aUwVba9+1cC42SU0OMu
 nMJ8+DHsrxTVsHRxXHcHb9cdF1M2xpiGGeB6WOD4rF7r2j9k5JdVds4DM5CyLdBbZ9fJG6Bj
 L77sgJN/p5DVEZGnocsC79d//8ClPC6ffy8D6i8RoMXPvBZKV/WlAkzNBX49z28zyARfVQXZ
 M7znTCEVi1BV8yKDVOeGo8g7FPc7npgnTiKHcijlXxKE9O2PRaodFvMC3PXBsgR56KYugTFt
 dFZMsqB0RJEV+PiJCLQ9OYuwZoidBDX2bieRxRrS9O+
IronPort-HdrOrdr: A9a23:KKYoka8Q0QI4bU6EeVtuk+F2db1zdoMgy1knxilNoENuHfBwxv
 rDoB1E73LJYW4qKQwdcdDpAtjkfZtFnaQFrrX5To3SIDUO31HYYr2KjLGSjwEIfheRygcz79
 YYT0ETMqySMbE+t7eB3ODaKadg/DDkytHRuQ629R4EJmsKC52IrT0JcTpzencGHzWubqBJcK
 Z0k/A3wQZIDk5nCfhTaEN1PdTrlpnurtbLcBQGDxko5E2lljWz8oP3FBCew1M3Ty5P6a1Kyx
 mEryXJooGY992rwB7V0GHeq75MnsH699dFDMuQzuAINzTXjBqybogJYczAgNl1mpDs1L8Zqq
 iJn/4SBbU115oXRBDynfLZ4Xik7N/p0Q669bbXuwq6nSWzfkNENyMIv/MmTvKe0Tt7gDg06t
 M644rS3aAnfC/ojWDz4cPFWAptkVfxqX0+kfQLh3gaSocGbqRNxLZvt3+9Pa1wVR4S0rpXWN
 WGzfuskMp+YBefdTTUr2NvyNujUjA6GQqHWFELvoiQ3yJNlH50wkMEzIhH901wua4VWt1B/a
 DJI65onLZBQosfar98Hv4IRY+yBnbWSRzBPWqOKRDsFb0BOXjKt5nriY9Frt2CadgN1t8/iZ
 7BWFRXuSo7fF/vE9SH2NlR/hXEUAyGLELQIwFllu9EU5HHNcjW2He4OSMTeuOb0oAiPvE=
X-IronPort-AV: E=Sophos;i="5.88,385,1635220800"; 
   d="scan'208";a="64640817"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=DVNJFqDLu4vMzLP07XDzQYgyTls9w+M3/az71oPRlwXoH/AMmaDfs7kyATortI9k7W6nXHsz9+WAkcOrTeNQLWn2+/oxYe6nGCp3HphhVIiDqJgNH2MTIlhe3wNymLttI/ggKo6ZsHWeO1YksM9vP7B91aq1h7OTExSGlImNv4Q6MTEgQw08b6Nk5f2/pVbKwEVzLl2DTlqz8TF++wYSW6hkOr0bTyJDoZjZNHxA7OtjcYugcINC884jz2V7EPFCIzan4dQ4J6l0e+AaF4I5II5ppALjtKXD9qXqUvvCqSUk59GWno7790b0dCtjCvoN690N0a3VMgBSpHqujoL8fw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=NDW+edNc7cwQ7Hai0uYaItVGfstAr2EWt3rCGOJRaEg=;
 b=de+yKBX181YvYKVEbfnr0ZKtDHN0d5EwzaM72b47A9RefeJQuhVLKfWDcQITliD7O1j+vY2CGgslLrnn/pcBkSq23vDNR1xqgypoKWpS4bKhNpw6fGk8mGhk2ONFJ8IvZgwj9UdR1cv1P0KnjtOhyE20ZZmAF0FXRN01JZIFA88nEfhp0FqjaquDoG6qttre5HOBZ6QUnUEVkgcwVsoNvvNwBg1TWMB6fePnKMCN3oiRMKX6gCTOghidVWibBsfwJQ1KTmjAHc9w7GYd+lZqzjK2sQ5OtUyDnSl4GWW5GQ3/XAstpqp7w0PEfhXYPq4BATAla/yZugxnxR3m7CDACg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=NDW+edNc7cwQ7Hai0uYaItVGfstAr2EWt3rCGOJRaEg=;
 b=TQwibX+u8LqxfSp/uW0qForIMYlGKuUwOGD0ZVYxGbATlrnumciBsaXQ93KnLD38XI96S6mnWuIzmMcduTdBOmq+e9qGZ7gZs9zHT/X2VJrBEjrE5Fro4LC3UC6yDXpw+AXw6YlGXHAdNIGslGOCcEfXWTpoTmTNZX2g8wsSVMg=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2] CI: Coverity tweaks
Thread-Topic: [PATCH v2] CI: Coverity tweaks
Thread-Index: AQHYJxRLecmrcEQSW0+uB3pfnN/G7Kyd3JCAgAAClYA=
Date: Mon, 21 Feb 2022 11:32:06 +0000
Message-ID: <59f132c2-bc9f-f03e-ec3c-0df1d534986b@citrix.com>
References: <20220221100254.13661-4-andrew.cooper3@citrix.com>
 <20220221111454.2925-1-andrew.cooper3@citrix.com>
 <YhN2C6flrMKJkrO3@Air-de-Roger>
In-Reply-To: <YhN2C6flrMKJkrO3@Air-de-Roger>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: ac85b957-01dc-464c-a162-08d9f52dca4e
x-ms-traffictypediagnostic: BYAPR03MB3669:EE_
x-microsoft-antispam-prvs: <BYAPR03MB36694E250792C06A2E45DEDEBA3A9@BYAPR03MB3669.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: mCEykojyOhznKKyRycgfwoZyf4E/xPAXRRwXkgoZCRkky48wkpM6d4kakBt2P+wXbpy7R5n3Wz0l4bi98gGOiuePlgvV3prRMszkB4I0m434TsaJu7DNzz9Hkzhw7z127+avHGmdei2MlTsBPNB//wnEFMF6zkmOSZAw0WfjVlxuvz1yyUuXjpS82LH9bWskRx27CQ9N0D3uh3xXJgQgbnnb51XgUfVi/tFokC/dJx/+0n2iP7re3F85s/uJPu39JcrhfpP7LDWOLQJBRMd5zEdY9tB7gCMT0Kp8J9s34cGL6vTgQp71WgIw5KFYlgYg7f3Bo1EsFd6OUPMn+r5+LnG3kQ+3otfY/Wl9MGa47zMBbqHH2FPK3YIesnnXy8eNE+0Eq3WbBRz4DlafIn/YRbpntZtFy09IcQT4OF0D9zCsSORXl/H2w9vESeTXjsrM/Sa/tfQPL5QwJF75ZQZSQp3uo31kyz9MwaHj7M1lxrfe/Ok6r2vZHrpTITiXr11WYXqxCZTci6Y8GY+mhEZ5Ms6MGKTn/id6OB4h3bxnPpHOm08Fau4hKfFRMjHbhRpy+vjH6DeXcOtdvKb1WpabGmlS0WM7iR6VNp8HvRzB+B+rzjmwpr7Yv8lt2aUOARWqk+UTVByjRLfkfGcoNlBS5Mo6xXw++mVZc/bGlo0oORKA2DA93nsT2/ThO+ueXcvtmKVowWMfMQUZj94AUdpElDGMDcxvRMxYdtQCXB6VlTu0hDDaCIUEIjLAQWKMup35vQFPN2qMFKchRn6KBFWBSQ==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(316002)(6636002)(5660300002)(2616005)(71200400001)(86362001)(36756003)(37006003)(82960400001)(26005)(31696002)(186003)(31686004)(76116006)(66946007)(122000001)(6486002)(53546011)(8676002)(66556008)(66476007)(66446008)(64756008)(2906002)(91956017)(4326008)(4744005)(508600001)(6506007)(6512007)(6862004)(38070700005)(38100700002)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?TzE1WUtwWVo4ditQSm9TMytUNThsUkQ4RVlGYWJNa1VUWisrK1gyU2Z6czZ6?=
 =?utf-8?B?SzhPODg1NHAzZ3RTTFJZM05SSnZqanF5TW1OS3VhNTlNZWlKNnV0aEpGL0Yw?=
 =?utf-8?B?TUlVM1R0dXNLVjV5NkVwbHpGSjJIVEEvRitiRDR2T09waGtOMzREVG5vNHRI?=
 =?utf-8?B?WjhZeTF4OHMyREtVZWI4Rk41d1lmWG1GVjh2d3NMSTNncUxtaUgxVlRWTzgz?=
 =?utf-8?B?akVFNE4zRGxBMDlaZDVENjFpS1Zxa2VpTnNPRXNodEdUVDl1c29nMnJtc2lR?=
 =?utf-8?B?VUNjRmplK2xZOStFVG1nTWpGSEpwVjg5NEY1QUxXR2Y0UmdXdXFkSGN2VjFS?=
 =?utf-8?B?NngvRVNRQjhxbFEvRlpJVng1QzlJZ3JkejY5YWRSZm5FTTdyQXptc1Zwa3k5?=
 =?utf-8?B?RGcxVU1WZHNhTjd5MFdFQlY2Mk5QTFJpYndEbzZHTkgzaGJhcFZlSWZ4VUFI?=
 =?utf-8?B?b3lZUjdzNmF1UVR1KzZaUVE3NUhqdGowaXFxSElRUTd0Wmp5TFFDeE4wc0FR?=
 =?utf-8?B?emFuaUNja00vQWc3bVh3UnVCcytuTk9GN1JvKzBsYlk4S3cvMU1URzBJU2VM?=
 =?utf-8?B?aUhIaUUxU0x1bEg0M0U1QlVsdUFnaXY3VjV6NWV2aXZXZGlJc1I5Lzg1bW1j?=
 =?utf-8?B?OUlXWnM2eFBpcVpqbXB2d3o0bVZGUHh2RDY2RnVSakY1RllYYlBqS091MjBO?=
 =?utf-8?B?bHRtcXJSczY0TU95dTRNaEV5YW5veXdBeDNNMjU2enZJYzVLUGlwaWhiYVc3?=
 =?utf-8?B?eXJ4QU1hYUJGeTF0NFNJMzRZcEMwY1JhUUg5eW51OUlVNkhBTnRITEpPc2dR?=
 =?utf-8?B?QXF6dWJ5eE1vQkF1R2NWVEEvOVNvcC9xWklRVjFEVDdYZzN0U1pqVFVYRTVH?=
 =?utf-8?B?bmZPUkoxalFVT3lZaGNTd29IbVZzMVRiTUN0MWE1NFVjdDlrTm5xdHVWYWVF?=
 =?utf-8?B?dDMzdTlvZ3JoZnA2REovQXh1LzV2NkpJTnJNZXV4NG4zSjQ4VzdWczNyODFl?=
 =?utf-8?B?WHpCMnpydTNoMDRvQzFLYWpmY08zdGhCUGNFRTdVV1dGWG5mckgvM2N5VFc1?=
 =?utf-8?B?MDAxb1pQT0c2OE5WYXhjdTVWZDMxS09wTzk3U1F0WHAzdkRBMjBBZnU0S0FN?=
 =?utf-8?B?dHpyZ3MyZGdPcUxFMGYzUGtIb2wwRUw2NlZjNGxqaUQ5R2FJdDJGMG43c3Z6?=
 =?utf-8?B?aW0xYmlQQjVORFkvY210d0FEQ2hYcUZ2TnlaTFhwdDBsMkJrZk1xTFRLdEZ6?=
 =?utf-8?B?eUZ5VVJUWloyQ2Z5UGtvZ2N4dUhvdWUxeHpWUkczTm83UmI3VDAzVXpUZEdH?=
 =?utf-8?B?QmtSSlFVNHM3N0NUOE1WK2YvMFRHZXdaVDBGbHN1OEtWY2tkWHRuZVVTaC9M?=
 =?utf-8?B?dC9sV29aOVkwZ3B5MHZzbXExL2xKSTJEZ1NoZFZHcTl2NUZ0eEFkZ2F0Tkwr?=
 =?utf-8?B?Y2dnanc4ZHBRcXdCOVN0U1hNUjRjR2dKK3lCemphbHFrVVU4dUdUTmdUZXRi?=
 =?utf-8?B?ZWxtcXo2NnR3Tm9Fa3gvRnJNZ3M5YVJwOG4xREpMOXBqQkg1SXFvRDMwc2gw?=
 =?utf-8?B?UVdZMUE0WHQ1SGtSV3B3UXo5V2tHREtMOWFMbG03eEtHU1VGUk5oanNoQkFM?=
 =?utf-8?B?eHljNWJmZTRXdW8xQWs0SElTNW1xSlpjNW9zR1RCeSsyMXUrZ0dZbXpiRVFT?=
 =?utf-8?B?dU1sbWhIdThlUEFLMVFZY0I0TXFHKzVqQVZTM0c4ZW5ueUZDTmpVNTRPeVQr?=
 =?utf-8?B?YW9LS2pSbjVFODNqRXhzejFudEJXSTlBWUJUcEFGQjhRSllLWVVLSUdNR3kv?=
 =?utf-8?B?SldFWk1FWW5CZmhYc1F1VVVXTUUxQ2VTV2N4TkI1YWxCcEloa3hDUGFTaFNr?=
 =?utf-8?B?YTFKTldGRHJkTXlzdG9PN2toTStKdXFiSkxDZVNSSk96T25XZlRuMDNKZ0tm?=
 =?utf-8?B?aXVveFFHODRZM2NUK1RybmF6ZUwwYTEwemtpZVRaZUpmc3k2RmZWRGk4U1pS?=
 =?utf-8?B?MWx5N0Nsbm9CK1lNeDBJbkl1MEhzQ2psbmFBTnlkRlhTZXF4clBMSEdMa2lP?=
 =?utf-8?B?VlN6dW9TSjUwRERVMUdPYjlONFNTMUtoOTdiemlidlpHNm90Syt2RXByMC9C?=
 =?utf-8?B?TkZaOHljejJGcnlwWjRRWkU1MkphZmZmRnl6UG9qVkIyWEJlcGg2ZjBTME9x?=
 =?utf-8?B?cnN4UXNuMXUralRSTGRMQ0U2TTVWRk1uTkduc0tIdHF5UUNSTW5YVmI5aUlM?=
 =?utf-8?B?QVdrOEU3R1dmaHZJZndpR244dWNnPT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <B33123D8F6B2A240A2163F8381576723@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ac85b957-01dc-464c-a162-08d9f52dca4e
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Feb 2022 11:32:06.5182
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 1klvXuW2BsvwLjJtLAuLI0r3cTrSbBvx/1oD0QzkDHpI3abfFX2CP240aBM++v+MU8DC6hDaJOkkvwPcXyQ3K06nAWoBKgQ7DnkMNK1Hb4U=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB3669
X-OriginatorOrg: citrix.com

T24gMjEvMDIvMjAyMiAxMToyMiwgUm9nZXIgUGF1IE1vbm7DqSB3cm90ZToNCj4gT24gTW9uLCBG
ZWIgMjEsIDIwMjIgYXQgMTE6MTQ6NTRBTSArMDAwMCwgQW5kcmV3IENvb3BlciB3cm90ZToNCj4+
ICAqIFVzZSB3b3JrZmxvd19kaXNwYXRjaCB0byBhbGxvdyBtYW51YWwgY3JlYXRpb24gb2YgdGhl
IGpvYi4NCj4gSSBndWVzcyBzdWNoIG1hbnVhbCBjcmVhdGlvbiByZXF1aXJlcyBzb21lIGtpbmQg
b2Ygc3VwZXJwb3dlcg0KPiBjcmVkZW50aWFscyBvbiB0aGUgZ2l0aHViIHJlcG8/DQoNCkknZCBl
eHBlY3QgaXRzIG9wZW4gdG8gcHJvamVjdCBtZW1iZXJzLg0KDQo+PiAgKiBVc2UgcGFyYWxsZWwg
YnVpbGRzOyB0aGUgd29ya2VycyBoYXZlIHR3byB2Q1BVcy4gIEFsc28sIHVzZSB0aGUgYnVpbGQt
Kg0KPj4gICAgdGFyZ2V0cyByYXRoZXIgdGhhbiB0aGUgb25lcyB3aGljaCBleHBhbmQgdG8gZGlz
dC0qLg0KPj4gICogU2hyaW5rIHRoZSBkZXBlbmRlbmN5IGxpc3QgZnVydGhlci4gIGJ1aWxkLWVz
c2VudGlhbCBjb3ZlcnMgbWFrZSBhbmQgZ2NjLA0KPj4gICAgd2hpbGUgYnJpZGdlLXV0aWxzIGFu
ZCBpcHJvdXRlMiBhcmUgcnVudGltZSBkZXBlbmRlbmNpZXMgbm90IGJ1aWxkDQo+PiAgICBkZXBl
bmRlbmNpZXMuICBBbHRlciBiemlwMiB0byBsaWJiejItZGV2Lg0KPj4NCj4+IFNpZ25lZC1vZmYt
Ynk6IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+DQo+IFJldmlld2Vk
LWJ5OiBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT4NCg0KVGhhbmtzLA0K
DQp+QW5kcmV3DQo=


From xen-devel-bounces@lists.xenproject.org Mon Feb 21 11:34:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 21 Feb 2022 11:34:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276227.472342 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM6xg-00047k-UB; Mon, 21 Feb 2022 11:34:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276227.472342; Mon, 21 Feb 2022 11:34:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM6xg-00047d-PS; Mon, 21 Feb 2022 11:34:36 +0000
Received: by outflank-mailman (input) for mailman id 276227;
 Mon, 21 Feb 2022 11:34:36 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nM6xg-00047T-4g; Mon, 21 Feb 2022 11:34:36 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nM6xg-0003dI-23; Mon, 21 Feb 2022 11:34:36 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nM6xe-0001Pr-SH; Mon, 21 Feb 2022 11:34:34 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nM6xe-0000KV-Rn; Mon, 21 Feb 2022 11:34:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=GR5JUiQY37jLOdN8YV7Al98/287rWGpdZGclgkSJxFU=; b=CCqah/JpFxT60RJxBmdPnrRgBV
	94oV8FV7oOWX1sK6MlbyJ7Ytw+4bkTpVAIuepViG3LxexBb8hAQKpm64eziFyzlrEh7udD3bHAvkj
	2qxuVVUWAKTP+jkfqGD26vSON0BnMnjAjZViMMjGJAp1ktIsMrK/ZfVm17dyEebIQYb8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168184-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 168184: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=454b927d1e33a1fe9dca535db2c97300fdae62cc
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 21 Feb 2022 11:34:34 +0000

flight 168184 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168184/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              454b927d1e33a1fe9dca535db2c97300fdae62cc
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  591 days
Failing since        151818  2020-07-11 04:18:52 Z  590 days  572 attempts
Testing same since   168171  2022-02-19 04:18:57 Z    2 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brad Laue <brad@brad-x.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Christophe Fergeau <cfergeau@redhat.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Divya Garg <divya.garg@nutanix.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Emilio Herrera <ehespinosa57@gmail.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Ivan Teterevkov <ivan.teterevkov@nutanix.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jing Qi <jinqi@redhat.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Lubomir Rintel <lkundrak@v3.sk>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nicolas Lécureuil <neoclust@mageia.org>
  Nicolas Lécureuil <nicolas.lecureuil@siveo.net>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Rohit Kumar <rohit.kumar3@nutanix.com>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  shenjiatong <yshxxsjt715@gmail.com>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tu Qiang <tu.qiang35@zte.com.cn>
  Tuguoyi <tu.guoyi@h3c.com>
  tuqiang <tu.qiang35@zte.com.cn>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Vineeth Pillai <viremana@linux.microsoft.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yasuhiko Kamata <belphegor@belbel.or.jp>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 98477 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Feb 21 12:11:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 21 Feb 2022 12:11:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276244.472352 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM7XB-0008NA-UC; Mon, 21 Feb 2022 12:11:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276244.472352; Mon, 21 Feb 2022 12:11:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM7XB-0008N3-R7; Mon, 21 Feb 2022 12:11:17 +0000
Received: by outflank-mailman (input) for mailman id 276244;
 Mon, 21 Feb 2022 12:11:16 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nM7XA-0008Mt-6J; Mon, 21 Feb 2022 12:11:16 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nM7XA-0004JO-35; Mon, 21 Feb 2022 12:11:16 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nM7X9-0002FB-Mm; Mon, 21 Feb 2022 12:11:15 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nM7X9-00080U-ML; Mon, 21 Feb 2022 12:11:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=AnBQFHdm91d/M/wV5alF/4P8RrpM9wvdvvkeg/y5vZM=; b=J8A0WuLS9x1/8J/B5MeO+J6w7d
	kTqfAsflD139MRIJHKhhj1yX8ao1jSlZgr5ccw3cfLCWmliQowqKAoirKlGAyxWCM6AOEWfqrTmd5
	tsuS0wMWnFw0hrRmAA6W+9qEeuZzik2vENW+X3Us4z/FzD/KbeFLxf85FnCTs8lHHWso=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168183-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 168183: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=cfb92440ee71adcc2105b0890bb01ac3cddb8507
X-Osstest-Versions-That:
    linux=7f25f0412c9e2be6811e8aedbd10ef795fff85f2
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 21 Feb 2022 12:11:15 +0000

flight 168183 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168183/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168179
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168179
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168179
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168179
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168179
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168179
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168179
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168179
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                cfb92440ee71adcc2105b0890bb01ac3cddb8507
baseline version:
 linux                7f25f0412c9e2be6811e8aedbd10ef795fff85f2

Last test of basis   168179  2022-02-20 19:11:13 Z    0 days
Testing same since   168183  2022-02-21 02:00:50 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andy Lutomirski <luto@kernel.org>
  Benjamin Tissoires <benjamin.tissoires@redhat.com>
  Bjorn Andersson <bjorn.andersson@linaro.org>
  Borislav Petkov <bp@suse.de>
  Cheng Jui Wang <cheng-jui.wang@mediatek.com>
  Christophe JAILLET <christophe.jaillet@wanadoo.fr>
  Dave Hansen <dave.hansen@linux.intel.com>
  Dietmar Eggemann <dietmar.eggemann@arm.com>
  Dmitry Torokhov <dmitry.torokhov@gmail.com>
  Eliav Farber <farbere@amazon.com>
  Eric Anholt <eric@anholt.net>
  Florian Fainelli <f.fainelli@gmail.com>
  James Smart <jsmart2021@gmail.com>
  Jarkko Nikula <jarkko.nikula@linux.intel.com>
  Jiasheng Jiang <jiasheng@iscas.ac.cn>
  Jinyoung Choi <j-young.choi@samsung.com>
  Jiri Kosina <jkosina@suse.cz>
  José Expósito <jose.exposito89@gmail.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Linus Walleij <linus.walleij@linaro.org>
  Martin K. Petersen <martin.petersen@oracle.com>
  Miaoqian Lin <linmq006@gmail.com>
  Michal Simek <michal.simek@xilinx.com>
  Mike Christie <michael.christie@oracle.com>
  Oleksij Rempel <o.rempel@pengutronix.de>
  Peter Hutterer <peter.hutterer@who-t.net>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Peter Zijlstra <peterz@infradead.org>
  Rafał Miłecki <rafal@milecki.pl>
  Randy Dunlap <rdunlap@infradead.org>
  Reinette Chatre <reinette.chatre@intel.com>
  Sanjay R Mehta <sanju.mehta@amd.com>
  Sebastian Reichel <sebastian.reichel@collabora.com>
  Stefan Wahren <stefan.wahren@i2se.com>
  Tadeusz Struk <tadeusz.struk@linaro.org>
  Vinod Koul <vkoul@kernel.org>
  Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
  Wolfram Sang <wsa@kernel.org>
  Yang Li <yang.lee@linux.alibaba.com>
  Yang Yingliang <yangyingliang@huawei.com>
  Yongzhi Liu <lyz_cs@pku.edu.cn>
  Zhang Qiao <zhangqiao22@huawei.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   7f25f0412c9e..cfb92440ee71  cfb92440ee71adcc2105b0890bb01ac3cddb8507 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Mon Feb 21 12:23:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 21 Feb 2022 12:23:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276256.472364 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM7j3-0001RC-3z; Mon, 21 Feb 2022 12:23:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276256.472364; Mon, 21 Feb 2022 12:23:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM7j3-0001R5-0G; Mon, 21 Feb 2022 12:23:33 +0000
Received: by outflank-mailman (input) for mailman id 276256;
 Mon, 21 Feb 2022 12:23:32 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=vyL6=TE=citrix.com=prvs=04447c275=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nM7j2-0001Qz-1C
 for xen-devel@lists.xenproject.org; Mon, 21 Feb 2022 12:23:32 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 128e49dc-9311-11ec-8eb8-a37418f5ba1a;
 Mon, 21 Feb 2022 13:23:29 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 128e49dc-9311-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645446209;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=5jPyyPXBC9pciqFvumRfpd60WqSCMarqJjjgPUvXU+g=;
  b=Q/BdmV9yHWm+r4JQd5DvZOlrwR10ErQtWwW4Y0cUNXbzop6ye2MNYpNY
   Fe5rwynByvVO+7L+1XoIzwHh5xxn1GBX69748Uq66e6p98c9wXlIBtOXR
   DSrm8VzjdE9opZjTz2QT0jHpECnxyxDo89j6GG10JVc0a6t1sh/G4O/gF
   U=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 64644193
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:qMyuBKC9JK1A+RVW//zjw5YqxClBgxIJ4kV8jS/XYbTApDMq1DEOn
 WNLXzyEbvrcajGkL9Ajadjk90xS6pSAy94wQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YhFWeIdA970Ug5w7Rj29Yx6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhgl
 +4cj4W6WD5xL5XCs8I2D0hBKn9HaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguw5K8bmJsUHs2xIxjDFF/c2B5vERs0m4PcGgGls2pkfRp4yY
 eIlUShtRwuePidTGQspWZBmzMCvn13wJmgwRFW9+vNsvjm7IBZK+KfpGMrYfJqNX8o9tkSFo
 mPL+UzpDxdcM8aQoRKd+2+orv/Cm2X8Qo16PKaj6vdgjVmXx2oSIB4bT122pb++kEHWc8JSL
 QkY9zQjqYA29Ve3VZ/tUhugunmGsxUAHd1KHIUS6R6P4rrZ5R6DAWoJRSIHb8Yp3OcUbzE30
 l6Cn/vyGCdi9raSTBqgGqy89G3of3JPdClbOHFCHVBtD8TfTJ8bn030H+x6Gr+M1szNFxrW6
 GzbtRFgvuBG5SIU7JmT8VfCijOqg5HGSA8p+wnaNl6YAhNFiJ2NPNLxtwWChRpUBMPAFwTa4
 iBY8ySLxL1WVfmweDqxrPLh9V1Dz9KMK3XijFFmBPHNHBz9qif4Lei8DNyTTXqF0/romxe0O
 ic/WisLvfe/2UdGioctPuqM5zwCl/SIKDgcfqm8giBySpZwbhSb2ypleFSd2Wvg+GB1z/1iY
 sfHIJv9UCxLYUiC8NZRb71AuYLHOwhknT+DLXwF50/PPUWiiI69Fu5ebQrmghER56KYugTFm
 +uzxOPRoyizpNbWO3GNmaZKdAhiBSFiWfje9pwGHsbec1EOMDxwVJfsLUYJJtUNc1J9zbyTo
 BlQmyZwlTLCuJEwAV/UMis6MOu3B/6SbxsTZEQRALph4FB6Ca6H56YDbZonO74h8e1o1/lvS
 PcZPc6HB5xypv7volzxsbGVQFReSSmW
IronPort-HdrOrdr: A9a23:540en6Gb6XhYrdnWpLqFDJHXdLJyesId70hD6qkvc3Jom52j+P
 xGws526faVslYssHFJo6HnBEClewKgyXcT2/hsAV7CZnidhILMFuBfBOTZsljd8kHFh4pgPO
 JbAtdD4b7LfChHZKTBkXGF+r8bqbHtms3Y5pa9854ud3AQV0gJ1XYJNu/xKDwOeOApP+tfKH
 LKjfA32QZINE5nJfiTNz0gZazuttfLnJXpbVovAAMm0hCHiXeN5KThGxaV8x8CW3cXqI1SvF
 Ttokjc3OGOovu7whjT2yv66IlXosLozp9mCNaXgsYYBz3wgkKDZZhnWZeFoDcpydvfomoCoZ
 3pmVMNLs5z43TeciWcpgbs4RDp1HIU53rr2Taj8A3eiP28YAh/J9tKhIpffBecwVEnpstA3K
 VC2H/cn4ZLDDvb9R6NqeTgZlVPrA6ZsHAimekcgzh0So0FcoJcqoQZ4Qd8DIoAJiTn84oqed
 MeQ/003MwmMW9yUkqp/VWGmLeXLzYO91a9MwQ/U/WuonlrdCsT9Tpc+CQd9k1wg67VBaM0o9
 gsCZ4Y5o2mfvVmHp6VO91xNPdfKla9CC4kY1jiaWgOKsk8SgbwQtjMkfII2N0=
X-IronPort-AV: E=Sophos;i="5.88,385,1635220800"; 
   d="scan'208";a="64644193"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Q5+YJ8Ha/1StT8J82LoYLIVCFRav4rPjLBxkPHXKgLD+VYBhCicfBeNCd6ocmqG5haVBjbsCmxCT62eDrDx8do+0Fkfuj8WKE5YE4QEommeM7o9dKKmDI/U4fhtWn4ruAduF6w8mr2Y9d5ej7rDNvFYVt1JmQMQIK9E3+EPuPgVw2en9ZqDFL6Py9SP+OUT5sSNDEzcg8JnycBS7MjkBz3MlJK47uyw0+rgwEYbRRH/gCcR1siAy/6saohDsekjFXk0fl5wQT9/2bo1KfSjlN+ZFCmMgNLV5UmM1wNbV/e++2mfjySarvCnAqKsZQNbKiW/nmY2kRbj+KpcKbafbeg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=z5qw7GyUqOfvkUmhewwPcICWhpVo2EPenFNEiRf8KZU=;
 b=me1dx0s72z0x/BaPk4hD9lxeHdbOK8qieGrf8u87oF76QmvTVd3accsI7VqvY9+4piPFEsAU/mpb+e/k/W1UiF2+KarHNaLmfwElBIl6AHvs24y9n4OQon5XDP0l6MJ19hl1QJzHM07SOrVg/q/lGTycgQXG+eaRVeuXyISSqo51YSzCDdLTmD/cgEO/hZ0s++s13wJn94AFzdbRvMcQTv7O0RHmlLY9cazhtwYEQIhIobbQ2RsHrZhGSd/KscwP81w0KEhK1vTy0fJC383FifGPeFK/DKjnzhXIWjoFWjBzB+xVOO80XYQOa8AcUrvFwbgxGfqnMyA0OrkwUke9IA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=z5qw7GyUqOfvkUmhewwPcICWhpVo2EPenFNEiRf8KZU=;
 b=MQkvKp7HK8AmeiLfeq4RGT+wxWraXrUJg1u1M3WJNYSMAVnmsMSnsdxXxOKttTGK2iZNBBJrAulMDEWB44aocRGiMfFusATUnBhIlZH8co6vE7rcuqaVAyg/ffbht8iHQXKYVUQSvUxHsQdPxYZxaG5Is9RF/+864V/w5i/ePHE=
Date: Mon, 21 Feb 2022 13:23:16 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, George Dunlap
	<George.Dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>, Jan Beulich
	<JBeulich@suse.com>, Stefano Stabellini <sstabellini@kernel.org>, Wei Liu
	<wl@xen.org>, Julien Grall <julien@xen.org>, Paul Durrant <paul@xen.org>
Subject: Re: [PATCH 2/3] xen: Rename asprintf() to xasprintf()
Message-ID: <YhOENAz/08oSD7WK@Air-de-Roger>
References: <20220221100254.13661-1-andrew.cooper3@citrix.com>
 <20220221100254.13661-3-andrew.cooper3@citrix.com>
 <YhN1pJIDIiJscvjF@Air-de-Roger>
 <ada67c6c-bcd5-9732-c3e0-76032692ad23@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <ada67c6c-bcd5-9732-c3e0-76032692ad23@citrix.com>
X-ClientProxiedBy: LO4P123CA0221.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1a6::10) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 3deab174-ffec-46fb-1a39-08d9f534f371
X-MS-TrafficTypeDiagnostic: BYAPR03MB4773:EE_
X-Microsoft-Antispam-PRVS: <BYAPR03MB4773D869BA29D95725F8192F8F3A9@BYAPR03MB4773.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: hioEpByeDMm0q1aZHJ4lejGlxTL0PnVby6UwsYPzELOFyhaZCf/1HuU+qm/cUT6j5pS5czxvLDZlnBmyMRt7kYZH4HPZlDQqiH7cqHjIlqoAfLIqHP4/GUtM+l5zLbk8a39OS55wtB5L6v9Mi1/3O+ZI30F9gSxRvR1TpfDiphSK0hPZVKq5XBf7m1YnBn5i3Bi0bfoK9BhP1SLlaowExQI4D7Q4St2SDx7nztvvv51SFYyKvrz8hNBJe9iJv9V/DiUH6Jsfg9s9Z3ynvlTucbwR0ci1BuEMRW3QRGM3GkDcvYL5cfXiBmQpYm3QJw+nxtZIzzYTbKUd0UTo2TnGa3dzNPomQXu4NKLrcU7GIWNDVJDKxm/FeE5pqwjVf22wKhaNtKRnI1KZdMkAPFx6CcP2Q6b/+pgeYOWchkgpBKBzOUJSCXCVh/K3N3lljYsuvkfeiWj8eeg/GzSpxsM6VlxQCWAr0XiY0BzLNGf6fqbkrItBuyAgcyxbL8fPBbFSRdOdC0Og6p3CSYSMI6GAOO+FGyxlM8Cj7dzSD1ZQtpdY6RszQymA5MaXhVbjnxgyDRe68LCGly4dF/6roZ8y3vtntfrYP3I8+GU4EuNqQK4K+vsxJlPOzvxBAa5scUaXSgsagURWvaUoYRBVD4rNPg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(66476007)(66556008)(2906002)(6486002)(53546011)(66946007)(8676002)(4326008)(38100700002)(9686003)(6506007)(6512007)(6666004)(6862004)(8936002)(508600001)(86362001)(6636002)(316002)(33716001)(85182001)(5660300002)(186003)(26005)(82960400001)(54906003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OU1pQTRVLzNvOGJHT1FYTytkMklJcXBOWER0dmNkTjhhb1plNUdsMWc0dmNE?=
 =?utf-8?B?UDZrdHpueXlTaDIvWGJLWlh6eTgyZVkvaXlBVFlzcVVWVUIxR2dtVURxTGEr?=
 =?utf-8?B?Tm1MWXBzNlorMGdCNzFXUDdEaGVLcm5oNEI0WGp3enkvL3JPN2RSREpoM2xG?=
 =?utf-8?B?dEs0MnY3akhFZDEwRUdrcjlMRFk5QWdMY2YvMUg0RUVLVHdUaUVwOTBRK1RF?=
 =?utf-8?B?SHJ4NDExK0JpdXJ2dXdXTjRKRVIwaldqalgyYkhTd0pHWVloQXhjczg0TzhN?=
 =?utf-8?B?dFRjdnIrL1NlWVVnK1VmbVZ3UHFadFpnNXNUMU5VTUVpZXFKSG5zeEVPOEQ5?=
 =?utf-8?B?elBZMzBnZGRTT2d3TW5mUlJCd0hmRm5RcjZTVU5RaGhPbVVIWHQ4c3FhSGxV?=
 =?utf-8?B?eUhvSVdPTUtJa1ZSQjBaNUpQenFVbXhCNXM4U3N5SDhPdXl2WTg0ZFpKN3dw?=
 =?utf-8?B?eERwd2M4cTN6MW1LNUhHMFQzTURCV0NNNnFDUG41K2hVSDgyWThocmJobU9k?=
 =?utf-8?B?MXA1M1ZCR01Ta0JoYTVOS0Z5WHBNZFZhcHBLeUV4NC9ZYmxMUmdTU0RpQ1JL?=
 =?utf-8?B?bWxXTzJuOG52ZEVnd3RTMFR2VDM3MzVRVm9VS1lQSkc5S0tVM1VVSGtFK3Vj?=
 =?utf-8?B?U0U2elNGU0lGKzd5TnFjWk1JNDJsZU9jc3pXV1VLTG9vcVpUckV4cDF5K1pQ?=
 =?utf-8?B?MTZla2pzTjVEcjAvQmVzOVVPbDI1N0NxZXZNV1d5dkdhSVk5dWRZbjhtTUI1?=
 =?utf-8?B?N1Q2L3gySUFrSzJVV2daRWVnc3ZvbXlURWZoWmlzSXhrYjg5aXhKSjNiZ1pt?=
 =?utf-8?B?Q0JjQzBVMjRsckhGcldldFVSaVlxVkJLa1A2Nm10OE1lSkt2NmlvTVFTNXpw?=
 =?utf-8?B?bytUd1NaVW1YUDc4UTcwYVRGakZTTlc0eVFXNENON2FjQ2poY2N4SGxPekYv?=
 =?utf-8?B?ZmlFMjRRcDhNOUc5WndvV1I3dFVzV1lPcGhweDBEbzk3UEtKRFZWWXJwampK?=
 =?utf-8?B?ZzNPajlVMVJvY1BvU1hURktGQTlvZnUyZVY1c0ZYOG1ubFZwS1E4aW0zeFYv?=
 =?utf-8?B?WTQ0TXdrR1A4QzlqL0JZWlcrOVR6aU1WRlRxd3U3SVJSenVjVG9LSlFneWI3?=
 =?utf-8?B?dkV6NmpSM0VrNkd0NEpqR1hka3hHVGxIbW9HbjFCZ3pIcXRqVEwweEhjMFRP?=
 =?utf-8?B?THkrRS8rZlR0OUpnZk90dGY4anRDdjg3VTVvdHpCUkxTN292bG4xRTRaU0hC?=
 =?utf-8?B?cWx1WmtRVjk5dGVWdjBiQkw5VGlDL2ZmTjEweXA4NUQzcWJrQzdWakhSS3Jy?=
 =?utf-8?B?MVdzMFp5TUJkcENhRTBneVFkVGwyd2lMNWZFeEJLQUVUUG1FZFZRMXQ2VkVV?=
 =?utf-8?B?VzhsTStyVXdMSEUzWGZsQVp6RmFSZTR2WU15b0p6aUdwVmw5NjN2cDl5eW9L?=
 =?utf-8?B?VUZ6Q0h1NXlpK1ZHRjlwWTg3eEtiQ3RycXVEdkpTS1lLSnlERS83UW1KczQ0?=
 =?utf-8?B?eFV2RXNtZ2Rac1lzQlhRd2hqeFYzcU9QTlduazc4UlRkcjhpWEtna3E3SUtx?=
 =?utf-8?B?cURwajhVQzFYcjU1dHFhd09POWppTk5ERmFRbzZkT0RoY2lVeStpcFdqRmoy?=
 =?utf-8?B?TWFIYlI3TnJOVXhnTmY0U1NZNlBKZHNKem0xSSszRk5nK0pkaWRYKzJCd2Jz?=
 =?utf-8?B?d3NCelV1N3FIR1FMWTYveEJPYU04QjJTLzNnTHJkbEQzSlNGNkxVbE9yaEs1?=
 =?utf-8?B?QVhNSGh0WXJzdkxSNjNMSXdpaU9UTmNzR3NvbWlvU1V5NGttSWltQTBEMlNu?=
 =?utf-8?B?Umo0UHRzQzVhVW5WZjM1Nm05WmxiNlNIR1ZVbXdwckgydUN3R3Q2ZUdxelBq?=
 =?utf-8?B?d0NjTkhSWnMyN3NwU0JGYzdEVXF3TWNlS1BnNHJTRVU0Ulg0TmlSYkNhYk16?=
 =?utf-8?B?WnRRS1U4SGZPR3JzZ0lKWCs0OFNWRU9kNkE4ai9pQkZmL3hFd2NEM2lTYU1h?=
 =?utf-8?B?NGZPTTR3bXBNVVdNQktMS0did2o3aGZwYVdleW5GU25UdEhLUFNLZldZWlh3?=
 =?utf-8?B?N293d2Q0TUZRU0VZYmQ0WElzY1MzSWRKMDdqT242ZkNKa1pGQ3BrWklYVVR6?=
 =?utf-8?B?eGpoQ1c3enVpbVFkM1ZZLzh5SEtOTVpybHpUQjJEa1Bxd3hLeWpMYUNRbDU3?=
 =?utf-8?Q?HXr4BkAWYWpEa3mKHTQysmI=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 3deab174-ffec-46fb-1a39-08d9f534f371
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2022 12:23:22.3515
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0ydjV+RCe+Zk5Yy7vfjTRLTRJ+30HY68jluS6FGw4kf2EWnBPQuvtmegKdjLG88fcW/F3WcAE3dIISkz6KoKkw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4773
X-OriginatorOrg: citrix.com

On Mon, Feb 21, 2022 at 11:28:39AM +0000, Andrew Cooper wrote:
> On 21/02/2022 11:21, Roger Pau Monné wrote:
> > On Mon, Feb 21, 2022 at 10:02:53AM +0000, Andrew Cooper wrote:
> >> Coverity reports that there is a memory leak in
> >> ioreq_server_alloc_rangesets().  This would be true if Xen's implementation of
> >> asprintf() had glibc's return semantics, but it doesn't.
> >>
> >> Rename to xasprintf() to reduce confusion for Coverity and other developers.
> > It would seem more natural to me to rename to asprintk.
> 
> Why?  This infrastructure doesn't emit the string to any console.

Right, but the f in printf is for print formatted, not for where the
output is supposed to go. So printk is the outlier and should instead
be kprintf?

I can buy into using xasprintf (also because that's what Linux does
with kasprintf), but I don't think it's so obvious given the precedent
of having printk instead of printf.

> >  I assume
> > there's no way for Coverity to prevent overrides with builtin models?
> >
> > I've been searching, but there doesn't seem to be any option to
> > prevent overrides by builtin models?
> 
> No, and we absolutely wouldn't want to skip the model even if we could,
> because that would break asprintf() analysis for userspace.

Well, we could maybe find a way to only enable the flag for hypervisor
code build, but anyway, it's pointless to discus if there's no flag in
the first place.

Coverity could be clever enough to check if there's an implementation
provided for those, instead of unconditionally override with a
model.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Feb 21 12:42:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 21 Feb 2022 12:42:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276265.472375 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM81J-0003r2-Pp; Mon, 21 Feb 2022 12:42:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276265.472375; Mon, 21 Feb 2022 12:42:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM81J-0003qv-Mt; Mon, 21 Feb 2022 12:42:25 +0000
Received: by outflank-mailman (input) for mailman id 276265;
 Mon, 21 Feb 2022 12:42:25 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=tDfV=TE=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nM81J-0003qp-1V
 for xen-devel@lists.xenproject.org; Mon, 21 Feb 2022 12:42:25 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b78a7eeb-9313-11ec-8539-5f4723681683;
 Mon, 21 Feb 2022 13:42:23 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 0A06F21129;
 Mon, 21 Feb 2022 12:42:23 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B822413AC3;
 Mon, 21 Feb 2022 12:42:22 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id xmyHK66IE2KGawAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 21 Feb 2022 12:42:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b78a7eeb-9313-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1645447343; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=s5Ju/wj4WZBBr1h9srFDpm+oLA9XY5iSYL7QmbanTmQ=;
	b=cnaBYxgLooyCQggVuLUms0pmbYofbYEuILXoLP4NSurvgbTEGQTdxVjF+/5jqfsOFetbxF
	VJjD6XSpwUWDfIaN++T17mLPuTdkMKBMjqn0TW+U3xBSe0JKUirKgaMjPJUzvMxvm9uaVM
	h9+oxdeNH17E9VlTznRQkGJAZzPpPvk=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>
Subject: [PATCH] xen/include/public: add macro for invalid grant reference
Date: Mon, 21 Feb 2022 13:42:21 +0100
Message-Id: <20220221124221.10245-1-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Providing a macro for an invalid grant reference would be beneficial
for users, especially as some are using the wrong value "0" for that
purpose.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 xen/include/public/grant_table.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/xen/include/public/grant_table.h b/xen/include/public/grant_table.h
index 7fbd1c6d10..af00aacfd3 100644
--- a/xen/include/public/grant_table.h
+++ b/xen/include/public/grant_table.h
@@ -113,6 +113,8 @@
  */
 typedef uint32_t grant_ref_t;
 
+#define XEN_GRANT_REF_INVALID  ~0U
+
 /*
  * A grant table comprises a packed array of grant entries in one or more
  * page frames shared between Xen and a guest.
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Mon Feb 21 14:14:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 21 Feb 2022 14:14:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276274.472386 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM9S1-0004I9-Ue; Mon, 21 Feb 2022 14:14:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276274.472386; Mon, 21 Feb 2022 14:14:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM9S1-0004I2-Rf; Mon, 21 Feb 2022 14:14:05 +0000
Received: by outflank-mailman (input) for mailman id 276274;
 Mon, 21 Feb 2022 14:14:04 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=2HaM=TE=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nM9S0-0004Ht-Cv
 for xen-devel@lists.xenproject.org; Mon, 21 Feb 2022 14:14:04 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 84ecd807-9320-11ec-8539-5f4723681683;
 Mon, 21 Feb 2022 15:14:02 +0100 (CET)
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur03lp2058.outbound.protection.outlook.com [104.47.10.58]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-31-_4TdxAoDMYqexnxTYYPV5g-1; Mon, 21 Feb 2022 15:14:00 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM0PR04MB4162.eurprd04.prod.outlook.com (2603:10a6:208:60::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.27; Mon, 21 Feb
 2022 14:13:58 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.4995.027; Mon, 21 Feb 2022
 14:13:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 84ecd807-9320-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645452841;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=zp1I+RrgdDB2yriKTJYhFfVm2mtAsDk+R6DDnfd16UY=;
	b=V5+56WjESCkdn7sXRFW/rWS6EaSLKp1hFo1PUDPWdHT3CoZFRzhNoa8uiUB92jtiXf/R+Y
	ZGLgxedfxHzS+ET3mMUJ7QTfKEgveQB1ijYV+izJyOQci5hSLalwswkWtx2Pa691d4E/K0
	q8GdUF7m8HnYveOb5PUQIviqTAmhXmg=
X-MC-Unique: _4TdxAoDMYqexnxTYYPV5g-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=iUa7gIiidOQrOMazQIdPUdS2sQYjRzYIi+9aJ1m2SM2arm6YMuKUCPhq1i87SFK2GBBtjFyDdQSuLBJWQSbCO/vhLVodHGP38iPnOCZTZ3msZhhaEZUgQTUb6jZUsJlqE8Y3iFbvzHMHfKECQvcOSGOeiSoiGcJPn9tc8I/tBORi3LXcfYu+uvXceVud6RAnm2PPDkIEx3VIrf40LYS26+bJb6c0B5NYhOclYJXtTaw9hzuxMX09QXEP6HwnaqPGkr10bTVEui2YLvI6GHwGIjwLhCbrxajzFExr/gFPhk6i2qMm5252pRFo2IrBJ5dpRtF8qCzMqiPohHplwL8IgA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=zp1I+RrgdDB2yriKTJYhFfVm2mtAsDk+R6DDnfd16UY=;
 b=nsfQtQI3DoukJwoZxCALPezp5uUk+iWv1b/3wAP6Yin8L/gn0eGlE5+Bdc2RjF6Xc6+EFNfKUt7Jiw3X1nwWjBe/9MHl7MzfytKdhOGzP7BfCogP4ak3iYWdELUj/n8484jPXeocIL/Vhg10hYTXWyvghxJSazh5883tNXYe6KPYxjDNgzpUwwbWSMb2UGBXOFbNAXy9iSF8WvOJQomdm+uPMiemm97MnH2XTSjiIWE/LsHCogSFiEhZ+rQ9F9o3HRek08osoDYdSNcnZfumiRKlUCg5iR/Ju8cxLKym/IS2KtPhAFysg68nzPen9CnekAMnsjM/bpzPSHwa9YsDTg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <311ad8d4-0988-005c-93b7-6e24bda77a8b@suse.com>
Date: Mon, 21 Feb 2022 15:13:58 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH 2/3] xen: Rename asprintf() to xasprintf()
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>,
 Ian Jackson <iwj@xenproject.org>, Stefano Stabellini
 <sstabellini@kernel.org>, Wei Liu <wl@xen.org>, Julien Grall
 <julien@xen.org>, Paul Durrant <paul@xen.org>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20220221100254.13661-1-andrew.cooper3@citrix.com>
 <20220221100254.13661-3-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220221100254.13661-3-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR10CA0015.EURPRD10.PROD.OUTLOOK.COM
 (2603:10a6:209:89::28) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d63e0021-17e4-4ead-5bd7-08d9f54466a6
X-MS-TrafficTypeDiagnostic: AM0PR04MB4162:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB4162FDF1B99B02BF6C77C587B33A9@AM0PR04MB4162.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	nwKsuXTw1Tu/XG3BcRZterJnvMai0mI4B87+x+uDu9IUJATx0vM6s6cCuJXcDfwO6nuBNYsK3tlmqDusTwx4gdRm5Hgt8jfdpgxan6Mn0ZFQw3wagm84A7T1DpsJx9G+7zNmMjPMlZ4CiQZNOjId7SWT/1xaY2GiqkJFIpoZhm9wwi/xikJePjHwBwUEsZuYh+pF98iN4tL2q0YpqAbeSnEW/4ze8/Rvc4mBC3oDLwsdScsHimFLVcIsIcLI16xFqzP1UGW1n0JC3USfuztiAnhmB++qA5ZTNEcX59z13Ptr4aVo5RrSt2KbdrBeB5o3NAMIN4r0ovfmPUDlRxxoKL16uyGeIlIx/J4XnuE2UwiUY8OrDPoqKNz0MD94s3fYjzF6iG58ZkliRqsuhy2oyn00cgxuczSBkZVYuWPu5DPEIFyC3Yx8Ww565BLFQ/9I1/G3heKFCu4RRVFD5VVDmCE2p3Et+AEGAa5p9In1iudZbA88gZ+H4juOgWGR65moZxpHO2Niz2pRsoepTNnCKyDvrOFptUmu6WyvO+b+0Cd0ezMSwz9+Vczi7P+4ke3hz6Oom9dTBCQkgg6sPTsCxVkEhChfqeCmN/i3B0anHCUeVRgQpWlp9JRvHn/+I08fiATk/oPsXKJxGZqqtH4ggWhtOLsoWq1dRrDrHTm9Foo3Pq4PoCm13N/I4PHr6dImpi3dv6GDNWXirW32QMTRT0GFVojGx2z8A799DAGhd8c=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8676002)(6506007)(4326008)(66476007)(36756003)(66556008)(66946007)(186003)(38100700002)(31686004)(53546011)(26005)(6512007)(2906002)(6486002)(508600001)(5660300002)(316002)(2616005)(54906003)(4744005)(31696002)(86362001)(6916009)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?djIzcEVmMFM1YWdVMm5HZlVYcTlRMFV1V0xYeWlzcGZxN0lHMjFCa1pTTnJk?=
 =?utf-8?B?eWljaWtSalBMZXl5b0VScTVYZmN4aU04MEtkK3JvV1lzL2poSndjMTRjN0t6?=
 =?utf-8?B?M1VIbVRPUTJMR1VycVBIUDJPNE92QkhGanNaZElhWUpHZjJwMC9UVnVDS29R?=
 =?utf-8?B?V0RWOEp0Q2ErRyt4WDFQZU1ldm9CaGpBaFRyY0lmVHBwNEZuV0lJMG9wNkhU?=
 =?utf-8?B?YXZMYmluNHY4NkhmZ1ZCdjVlWlBlQXgwek04Vm1nZng3U3Y0SDNabncraEhT?=
 =?utf-8?B?L3FrMEY4UFQwaEYzVUZyTWNqaW1oOEgyY1hyWU41ZGVjaEVxc0lJeW13elRv?=
 =?utf-8?B?ZWQ5VGVZOTlSaE9ZSmNEdHN4MG9panpDMFNUbUpYdEcwaGlEU20vdzgzQ2dw?=
 =?utf-8?B?VWdSWGRWdGpFRzJUYU82eE9XOWNVTlRzU29JM1JnQWV3ZGV6S3VKWjlONFZM?=
 =?utf-8?B?S0xNTC9YTzF3UFBvTytaODJ5dko2Y2pWVHZPNzNBWSsvdTBNSmdDcmg1OFJi?=
 =?utf-8?B?bkF5R3FQZlB6NXhMNkpWWjRTc21aUkZYZWNKMyt1a0FwTzBlWGN5N2tvTVlF?=
 =?utf-8?B?VTh3MFVqUUhKUGR1OHY1cGJQOGdMVk9QM1pMcXI4TTV4VWFCY1lhajRGNGJV?=
 =?utf-8?B?YzVvbHNOS0xLTUFHelZiMDU1WEhVOTEvYUI3Y3VLZkpEUVFtaUU2RUtrdGVF?=
 =?utf-8?B?VDdwQWN4Z3QraU1xcnZOU2EvKy9zSDZsblF5YzhPWW5zUHAvQzVCQzh1SmYx?=
 =?utf-8?B?S0JrZ2FLbHJ0Ti9JVzl2WEV0d1Z2dURzSm5SbVRwQXJGRVZLamxPSndHd1R4?=
 =?utf-8?B?WUFQSUtWdXdDMkFOVHBla1h3cjZZdzBaZ01EY0Zac0xLeTF1ajdnSnFzYTBK?=
 =?utf-8?B?aWZIVXVESlZ1M0RUUnJyaFdUckNld3BSRnpHTFZZQmJhc2htVzNObHhlSXlh?=
 =?utf-8?B?SmowQVI0YXNEaWFuTTd1Y2tYNGltc1A1RHNrdk00V1JoekU4NjB0VHVWOW4z?=
 =?utf-8?B?K3dKcW5mVnIyVVAwSENFaGdLZ3RoWE93UHJidWtVRnNjYVRtdEJ5VWZRaWpu?=
 =?utf-8?B?UnVhdlc5cjZUSWlMV2hkdTFlTzNHYmkrWVhGNDRFeFdYQk1SZS9PUEJ1dTht?=
 =?utf-8?B?SVcvNndxNUp0d1JnMng0ZlFueUJTYU9SbDJGYkJBcEVndWxMRzU1aW5pWW1E?=
 =?utf-8?B?VlE2SHFHblVrOEQ0b0RML1lrTWhyZTVJZm5RN2tFNnh2cXcrQkRkK3Y1NWxT?=
 =?utf-8?B?OUY5UHdLWElZNVhSYXhpR3ZSbjRTTXJ2TURmUFV3WUV0UG5sSzJMem8zZW5i?=
 =?utf-8?B?cHZiYU9NZ2tqYkpZME03OUl2UkRpbVdiN1Y5Qyt1VFFmSkFPRXdkNUNuRWFS?=
 =?utf-8?B?TkViZTM0YW5NT043dmNzdFBDNFRNL1ZlR2pXUTBTVmp5emNoa2xXcC9pYTN1?=
 =?utf-8?B?dENkRURxZGFGc2s5U29Ra2RHNGRGaXNHUWdNU01ucjdlcGJDaWgzYS9kNnpa?=
 =?utf-8?B?Mm1talhFdkdTTVArNzh3SDdWc2Urc3pEMVY1cWxIR2JGR1JERTNEcFJzaEpK?=
 =?utf-8?B?MFBWWC9lU1hQRHpQaE9sRURMQ0s0VnBhYzl3SUw1UUJmc3dVcFF2YzJRbEl0?=
 =?utf-8?B?TURhUFdyOFloTUZybFVzb2dxbWxDd0FLVGhSL1ExRDIvUVEzUTVta0NjZWFa?=
 =?utf-8?B?ODJ3Sk0zTFNxRkpDci82U2VyL3FadkxINlJCQVNERWtLbkZlWVQ5U0pVbVlv?=
 =?utf-8?B?YWk5azI5amY2bmdmVHpQMGFqNVR4OHgweHFvTUhNWEdQVzVWY1JsWFRrZ3Nk?=
 =?utf-8?B?OHFEZVpCVmFrY2owMld0TlhXaXhjQld0WlA1UUJoOUJaYTF0MjdaNXdPVEI0?=
 =?utf-8?B?ZzAzalkwb1hBL1l0NjN3eGVhK25DZWV4L3JQNzZuUkV2Yi85b0V4Qk1NNHdq?=
 =?utf-8?B?S05rS3k5eFFXdXN1bUpuWXFucGtvak9Td0tFRTZ0RGNRTXpvV1ZTSWVURjlh?=
 =?utf-8?B?R0N5Y2pVcVlzcUNZc1lyWk0vZVdNcXcxYnFFM0pweEtia3ZIVm9IWXZjWVNG?=
 =?utf-8?B?QTdzTjBNeGFGVHdMMmtHdnY2SnZtRE5IRzZCbHNpLzh5a0JkMXE0L2k5RFEz?=
 =?utf-8?B?WHMvNjY1L0wrWEhuejE0WFFmbFFRb2UyZjlBV1NmN0luRVBLeVlHR255Mzl6?=
 =?utf-8?Q?al8Ow8ItiiP9OMJVLCQNEkg=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d63e0021-17e4-4ead-5bd7-08d9f54466a6
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2022 14:13:57.9801
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FOqlz6pw3dmN7G9l7cXvuCTSiCW8SMbgWLTjTjx70jnRvZM5dXeVZZ/um07Pck7/mRsCxKIvNURj1s5RUXUwnQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4162

On 21.02.2022 11:02, Andrew Cooper wrote:
> Coverity reports that there is a memory leak in
> ioreq_server_alloc_rangesets().  This would be true if Xen's implementation of
> asprintf() had glibc's return semantics, but it doesn't.
> 
> Rename to xasprintf() to reduce confusion for Coverity and other developers.
> 
> While at it, fix style issues.  Rearrange ioreq_server_alloc_rangesets() to
> use a tabulated switch statement, and not to have a trailing space in the
> rangeset name for an unknown range type.
> 
> Coverity-ID: 1472735
> Coverity-ID: 1500265
> Fixes: 780e918a2e54 ("add an implentation of asprintf() for xen")
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Mon Feb 21 14:18:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 21 Feb 2022 14:18:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276281.472397 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM9WF-0004y9-GG; Mon, 21 Feb 2022 14:18:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276281.472397; Mon, 21 Feb 2022 14:18:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM9WF-0004xc-CQ; Mon, 21 Feb 2022 14:18:27 +0000
Received: by outflank-mailman (input) for mailman id 276281;
 Mon, 21 Feb 2022 14:18:26 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=2HaM=TE=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nM9WE-0004xV-Eo
 for xen-devel@lists.xenproject.org; Mon, 21 Feb 2022 14:18:26 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 21eea363-9321-11ec-8539-5f4723681683;
 Mon, 21 Feb 2022 15:18:25 +0100 (CET)
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2058.outbound.protection.outlook.com [104.47.2.58]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-24-0XG_9FroO0eAlQN-FlefXw-1; Mon, 21 Feb 2022 15:18:24 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB7152.eurprd04.prod.outlook.com (2603:10a6:800:12b::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.27; Mon, 21 Feb
 2022 14:18:22 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.4995.027; Mon, 21 Feb 2022
 14:18:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 21eea363-9321-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645453105;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=XYRP3BhV7zvkGGTmEbeaVC0JEmiUIRVhHZ+PkCd1HWw=;
	b=Z0NDFxlpgCRKfOerK5/9WmEpKgzJr8VXuzZUKd97dVuk4aG7h87veDIUTVW6wiKcz/mEZq
	1rj5gqqc83OEtVCLnVJit7Ayfy6WneRHxfIpEsUBMZRCkq23sF9IDOYjJ7Sag69FMho9Rt
	kczpnNvwlw1KvMSAUYEXbmkkHO2rfVI=
X-MC-Unique: 0XG_9FroO0eAlQN-FlefXw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=SJx2KEPCFKjWtPLK3WeDv/uyQuHWxNhUZ1jPbs01HHV7rLTJbwHpaD2NexYdNXUi9YjUbGX1iYOeSqhzW8rYvXwf9p6R/TEube345WiUkV2E4nuXuMjRpcop31zGRm26zDmN7gBusl7CATPG14PXwk215VWoUOXZe1pe5ukIHWSQqjCcTKhCEcZxxwO88SUTvd+x5ZAy0CMEsJ+/YXibZM+H8ivykVcFYbvkYKBsQ6I3h7Jn+Nlbr7cP3whmC99vaWDKWrtrExqmvfDHpMy/3SRmmQEwISDbltyi0vAqqFcBUihBCgrrdlm2G0BsYWJ4eZntrE+hM99BY+TKVjvyow==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=XYRP3BhV7zvkGGTmEbeaVC0JEmiUIRVhHZ+PkCd1HWw=;
 b=QVcTMQEl6EBnvGZhIbquMt4uD3kaVDMEFS2BrILjg6se70T3Tf4ZzCfQT6LItBsVA1LgPi8PNk6ZX+8zqMGXsza/CHd5B1jJSDnTT749gyX/z+W6c9DA5cEWj4GhktOLIzNygEVQeFv410RffluMwchaoU9mV+j+PqCEp7y8uVRVHsgTQVHRwCJgrOcP26y3yh94EnDUuYFSKTydwBEDP46C3snbC1A8ZwTlsyAgKH6g7W8YpCd6Lw+HNBxCxVtMEMenOzA/5kimFC8d9xQMNZr8UdVadubXSJAeS+wnmJKlk8tthKDnbXsyNkDJNOOfEnSb6gV4bIBH8yhi16L3dg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <5bf7424a-c295-7aa5-4bf8-13136065a06b@suse.com>
Date: Mon, 21 Feb 2022 15:18:22 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH] xen/include/public: add macro for invalid grant reference
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220221124221.10245-1-jgross@suse.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220221124221.10245-1-jgross@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0070.eurprd06.prod.outlook.com
 (2603:10a6:20b:464::21) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d71abce7-0e7d-4c37-bd45-08d9f545042e
X-MS-TrafficTypeDiagnostic: VI1PR04MB7152:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB7152A83FE0864DF911C4914FB33A9@VI1PR04MB7152.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Ar6/BA9CLK7ikJmyTrqLzSrKFCV97AYNxe5w3CIIxQ08MsRUeCfk2nY8nGGe2JcgoBLod9OXdDkoLn53uYqCBuOPDAAUo1tsbGzDaYFJUrBY/ztxThxwg+vozNipDYwvuu47e8x5apMZ+9KQcVvp4atJufbER27qruXka9klAM5a1x9vY0yRYqypSgjUe3BQZn0ueV5EbYOTanv4RbSIJBYm/9soEYaMd7ZMQkFqq/d2AVj0YgRfsS0A0vBdvELNx56+SZplXWr8gLIUegigWFdXrIQnRKyt93X17o8C8Px+4AyG6heDoGLvbKDQp6eU3+7YmHNaKg1g983k56cZJKrW2ChI+Uo+mptsfytyFHCaDl+UYBy25w/9isBNF65cGnh4j+bG3GoWm6+gAuLJl1ih4Vpb8InYNBBiLvHk91Vf4Tsu67MW9tI0LtcKalnzx9RVrHEp2lEWLtG2f4g9STrWPtjP7LjHYOk7BKUjxGVu4oNJ0JqKzecb+jycpctpH44cG+Dss0Toi4+qVwYZ61QYBfJMugxM5Eyczmg84B3kEMBrpIYsyDnrn9Srib64RaGfu9TFRrCYiFY0XpF3IYfxHD5UJZdWzJWK59VikEXxOZDkG8d2CJYke0XQbStnd/o/zCVeG0+qkMC0mJJYdGwvmWjJR2agIN3+Wb9vtoIKj10SkDVKTGB6UjIAawjQXo5rALPUYhjJz9DubpJh0F4DCvQJwssMf7Z9ezKx89Js5SYxufF7x5sWoLPK1BjX
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6506007)(86362001)(2906002)(53546011)(186003)(26005)(31686004)(36756003)(38100700002)(66476007)(8676002)(66946007)(316002)(508600001)(54906003)(6636002)(37006003)(4326008)(6862004)(6486002)(66556008)(6512007)(31696002)(8936002)(4744005)(2616005)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?WlUwcU5NUWNocU4xYlVSbFFna1V4LzJvQldwNXJwMFZ6U0R6N0h0a3FTUitV?=
 =?utf-8?B?RmlVTko5VzFiNGdYTXMzeWFIZmlVT3krVDJ3b2lJbUdkanhDY3EwNjEvNjFI?=
 =?utf-8?B?RzlBdDdEVEdGNWVOY2hLQ2FubFk4OG9nWEZqSGY1a2c1MS9BY3Z5Nk5kZ2Ew?=
 =?utf-8?B?dGVrYXdoamhsN0JrOXM5SkNlTWpwL2JoNHI0dEd3NEZvUTJJZkhtRUlpUzNE?=
 =?utf-8?B?akp2aC9ocFp3M2ltTDh3RlFKbHpQRWR2aUZ1TUdTSkIvM0tYM2ZOYVYyNGFL?=
 =?utf-8?B?YzhWME1JUVB0bkxlMHptdjd2NVFHeVNieHBaWGVlbHVzcGNOSFljYmVDTGpk?=
 =?utf-8?B?cVhTbnVPc3ZjeFRqQUNmNWdRQ2U2UDk4QXdMYzN1dDFreVVLcHhlR2h5UFFS?=
 =?utf-8?B?ODI5OFZ1SG1ydzdWdXZZRldTOC9Ybk8zdW1NWEp4a2FnQjVlWldXV1FhNWxk?=
 =?utf-8?B?TmlxMkdFM05DQXpoODZBUDJ5aUdvb2drNXg3WEVKSlZvNHpkYmFLS0pRWmtq?=
 =?utf-8?B?RHF5VC81eTB2Yi9wdkNFZjZzL2FvLzhJdGkwNmRHUHNOZHdGSXVhdkpVTG52?=
 =?utf-8?B?cnpTYVFUVG9xK1dkQUVFb0NuZ0ZZRzVzZDFJM3hYNkVOYW5Ja0d0MzYrR2dG?=
 =?utf-8?B?SFVGaUlMTUNOZVZpK3h6Kzd6UTlYd3YweXVmMVpTVGZDSjlnZjhrdW5TNUtN?=
 =?utf-8?B?QkFqY2xsTnl2OEJYMWs2ekZyazRrRTBVRzIxRSszc3JUOGJYZE9tVjI3enVJ?=
 =?utf-8?B?Z205N2d5NDJXVGtFWUxOdjU3Wi9vMmFwSWV2USt1MDh3NDhyQzRKNHlFTEdV?=
 =?utf-8?B?MXRBei9OaUlweFBQTEtpRWV5d1BnQjlmZElUVXBYajloTGNDTkYwRlJEUGRN?=
 =?utf-8?B?V3VJNGxxTytCUDk3eVZxdExraVVuRFZheWVwaWJGRUYvdytTa0RMZTJVRmVY?=
 =?utf-8?B?SnZ0ZGdzenVJdTZSTk5ZUCtrei9iRzNSRm1pblg3cStJWk5NRUhQTmRBT0NT?=
 =?utf-8?B?Y1ByelNDUVhVYjJWcWtGL1V0R1hoTmZtS3o5SXZreVZpN2VHQ2FVei9vZEZE?=
 =?utf-8?B?SkJqMEZwRzg2UmlTVEpPcVFURjAyMndqT2IzT3YweFNSdHNXcnAxNjR0TE9k?=
 =?utf-8?B?aG0wajdqWWYrZXBBZUYya0RYZll0ZUJFejdkalhMN1FxeWxJc0x6dFlidlFR?=
 =?utf-8?B?bC8yTExPK0RoZFIwd0x1RlZKcnN2NEx3NDVNNnU5SVJZOHZDMHVWOG01Qk5p?=
 =?utf-8?B?bmtCRENOYmQ1OFZIQm1pSUdsdHlhdzNCUmxmTy8zdG5wT2g3SElJT2s2K1hq?=
 =?utf-8?B?S2w0TGJtZEVFUTduVVlWWFRTTmI5dkQ0M0ZqYnMzSWIrYlFuQU1lckhJVk1L?=
 =?utf-8?B?amswdENwN1dMTnhXV1BNWG1SRzdKSWFCODFLeDA1N3hDQ2ZFbHp4ZFBFekQ3?=
 =?utf-8?B?UWh2M2Q2ZkxZaEFCdVd3WmxUei9uUFFMakpWenVNdCtLVjZ4TEJZNkx5UzFG?=
 =?utf-8?B?WUJjWHhSWXI5b2JFeVZiQ1JIcm9QaTRLL3dQU3FJYkIwK1B3dEU2akhlZGNj?=
 =?utf-8?B?M0VjcHdhdlU5RDdBbWt6L2F0aU85YmU0SUZZc0xXM2NBRGtQTGVSUzB2SzZ3?=
 =?utf-8?B?cUdiTXFpRmpFcVU0MytEWW5UU1YwS2RYNmFRVjR5dG1SdlpoQ1dLeUFITTBP?=
 =?utf-8?B?Q1ZQR2E3WjJBS0JjVUFNVFhsZWcyVmtNRTRFdldTektGbVVDOWpYRnc2VlFy?=
 =?utf-8?B?WFNzM3dhb3o3NDVuVjBBUTdBalcvMDM5ZVFtQitDUlhDYWxZMmd6eExxRjdR?=
 =?utf-8?B?SUxVR0JVdm9zU0V3T1BXYlBiRmtxamp2cFg1MmFqVnFHck0zQlpLZWh3dXNu?=
 =?utf-8?B?WjYyOUQvVTJEWDdGeTNBbVRVL21qMmprS1NoNTFSbVRLbVVSVXd3N21lUjlW?=
 =?utf-8?B?MGtiNnZFb1ZKT29ob0cveGhOMTdLS2UxNTVHbW9HcU5JYVJuL3JyTFhHY3Bz?=
 =?utf-8?B?L2JkWThjVzBDalEvU29wY3lhdXdTN1ZnZTUrcVI4VVpKMG5BRDB1Uk1pUFBC?=
 =?utf-8?B?eWFvRlNzRlhlRHUvTmR3OEhDNTRRTHFJeEVoc0ZYY3F4K2xsSllXZDYwZ1lB?=
 =?utf-8?B?U1NYV1hnRWdyT056OWM5ckw4enQ3enc2QmgzZ1NOMzBIVGlMa1l1M0x3ZC9m?=
 =?utf-8?Q?b/NaGL2nXaA6/WtiBWV82mg=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d71abce7-0e7d-4c37-bd45-08d9f545042e
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2022 14:18:22.3231
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: G30+qytcccohb3/9R0fu7nQ67Gtlnr8wZtEN7gaR2Hkztjn8q80/lBrH0jw/wVopJZNCGVdwlg6PpJ1RaY/+tw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7152

On 21.02.2022 13:42, Juergen Gross wrote:
> Providing a macro for an invalid grant reference would be beneficial
> for users, especially as some are using the wrong value "0" for that
> purpose.
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>

Over the years I've been considering to add such to the public
interface, perhaps even more than once. But I'm afraid it's not that
easy. In principle 0xffffffff (which btw isn't necessarily ~0u) could
be a valid ref. It is really internal agreement by users of the
interface to set for themselves that they're not ever going to make
a valid grant behind that reference.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 21 14:20:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 21 Feb 2022 14:20:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276288.472407 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM9YG-0006Kd-Re; Mon, 21 Feb 2022 14:20:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276288.472407; Mon, 21 Feb 2022 14:20:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM9YG-0006KW-Ok; Mon, 21 Feb 2022 14:20:32 +0000
Received: by outflank-mailman (input) for mailman id 276288;
 Mon, 21 Feb 2022 14:20:31 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=fvXl=TE=citrix.com=prvs=044a77a3b=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nM9YF-0006KO-48
 for xen-devel@lists.xenproject.org; Mon, 21 Feb 2022 14:20:31 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6a58419b-9321-11ec-8eb8-a37418f5ba1a;
 Mon, 21 Feb 2022 15:20:28 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6a58419b-9321-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645453228;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=i1QC6A25OxxBe9hEOgbrdZsifJgbnoH/2o0b3shjwtA=;
  b=F8nTj5Vqrtyr913UDDzJd0fxveNac7ZaiXo9X445ulqd2BJsdT5PQEoc
   v1dI9DnxVauZCl4HCvo19ZXyphI/V731tl1rhJ7+2EFEuv9fAA/9vdGAn
   hqG5TdMrCefclj6sJYPXm1fT6ZCBVSrfLBh8s8Pq0ETzpWpiDuKMQqbcj
   A=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 64652013
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:C2lKo6DDDn1LChVW//njw5YqxClBgxIJ4kV8jS/XYbTApGsghWQAx
 zcdWjuFOvnfZmOgeI0naY209EkDsJaAn9dmQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YhFWeIdA970Ug5w7Rj29Yx6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPgq0
 8hq69u+YzwqEYeTodw4WQZ7PHpXaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguwKKsXxMZxZkXZn1TzDVt4tQIzZQrWM7thdtNs1rp4SQ6uEP
 5NCAdZpRDb+Zgd/OFYvM54nl76GmCnkfxEAjmvA8MLb5ECMlVcsgdABKuH9ZdiiVchT2EGCq
 Qru/Xn9AxwcHMySz3yC6H3ErvfGgCfTSI8UUrqi+ZZCm0aPz2YeDBkXU1qTovSjjEO6HdVFJ
 CQ86ico6KQ/6kGvZt38RAGj5m6JuAYGXNhdGPF87xuCooLV/ASxFmUCViRGatEtqIkxXzNC/
 n2jks7tBDdvmKaIUn/b/bCRxQ5eIgBMczVEP3VdC1JYvZ+z++nfky4jUP44C7OS0Jr7Mwrz7
 BrVlRAbjaowopUigvDTEU/8vxqgoZ3ATwgQ7wrRX3644g4RWLNJd7BE+nCAs68ecd/xok2p+
 SFdxpPAtLxm4YSlyXTVKNjhCo1F8Bps3Nf0pVd0V6cs+D22k5JIVdABuWouTKuF3yttRNMIX
 KMxkV4LjHOwFCHzBUOSX25WI553pZUM7fy/CpjpgiNmO/CdjjOv8iB0flK31GvwikUqmqxXE
 c7FLZv3XSpLVPU6lmveqwIhPVgDnH1W+I8ubcqjk0TPPUS2PxZ5tovpwHPRN7tkvctoUS3e8
 spFNtvi9vmseLaWX8UjyqZKdQpiBSFiXfje8pULHsbeclsOMDxwUJf5nOJ+E7GJaowIz48kC
 FnmARQGoLc+7FWaQTi3hodLMu23Bs8n9SphVcHuVH7xs0UejU+UxP53X7M8fKU99fwlyvhxT
 vIffN6HDOgJQTPCkwnxp7GmxGC+XHxHXT6zAhc=
IronPort-HdrOrdr: A9a23:CnN2+K09zul8CFstclIcjQqjBEgkLtp133Aq2lEZdPU0SKGlfg
 6V/MjztCWE7Ar5PUtLpTnuAsa9qB/nm6KdgrNhWItKPjOW21dARbsKheffKlXbcBEWndQtt5
 uIHZIeNDXxZ2IK8PoT4mODYqodKA/sytHWuQ/cpU0dMz2Dc8tbnmBE4p7wKDwMeOFBb6BJcq
 a01458iBeLX28YVci/DmltZZm4mzWa/KiWGCLvHnQcmXGzsQ8=
X-IronPort-AV: E=Sophos;i="5.88,385,1635220800"; 
   d="scan'208";a="64652013"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=I5bHhga9rzY/beaHejJa3cg9AwmXMKw7GjXUVBBet5Hu44xUoz/sP2T8q5GtnEQU2ART5oeV/U/COoBHfYSpZpSPCK9L9fqnE0beVm0kKn9wB6ZjtNt25Q+uyEP/LIlCMlbKX+AasZED/THhMa8KEfzooig+KIWSavgzt74Sfn7/tDEkqsiLLq2r32SNDwJTWmOaysn0wD+32AwTaW1c1MEUAVF6u9yRexLpItUrIae86iRX3DSwTS4Ktcv9mUEY391Xlsc40/x/HlQ8qOOWPh3NtYVcX2Is92uc7kUp51dp4Gu5xZUscbPg70bPyDbU+dOBmxyoo9HsxHeoF9p+Hg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=i1QC6A25OxxBe9hEOgbrdZsifJgbnoH/2o0b3shjwtA=;
 b=ZdeAZlCa9VcrSnBgMcpV7zElQVPTfXu5M0tfx7JU+7fslWmd8SqnS4bul97ToNEOu/eB5gxZJIwiHBIeRIzJfoPz9ckbd9VrXG4BDXE7sBjlYtcTwY79uogw9MX+jMkqiQWAqXJaiZOx2Q28BTNXjVXY9g2u3onMVAugAnY7/V3ql4IKnYmf2tAx4xXAYaj776G4a2Gw1UDoE7cncJqkFW3n0hDV48FRGGdoWR2YbE2Z/u9Pw1LISqMzKHleqQyFh222GC/mtag6G3+tyNhcVdRWJr2QLO09Fq3bSZU+u/9B9RmL9EeHIPE3SU2Q7y57b/06rSHwSl6xrUqnaDf26A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=i1QC6A25OxxBe9hEOgbrdZsifJgbnoH/2o0b3shjwtA=;
 b=vQKEUJZnMTvSVJ0UqKBDMq6h+J/WY0bN2T28r5emjq61Gb2JbF6U3aXox/2MffYQkBQIXF+aYucOP9/dgNe5l/RTO9w/fNZ0kCkXJjsXdzpJianhnh3kMXzJVtn9leHsd027kNi/j+d3n7VcwOEAiZRtm89LEmUhk5ylGxiJo2o=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, George Dunlap
	<George.Dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>, Jan Beulich
	<JBeulich@suse.com>, Stefano Stabellini <sstabellini@kernel.org>, Wei Liu
	<wl@xen.org>, Julien Grall <julien@xen.org>, Paul Durrant <paul@xen.org>
Subject: Re: [PATCH 2/3] xen: Rename asprintf() to xasprintf()
Thread-Topic: [PATCH 2/3] xen: Rename asprintf() to xasprintf()
Thread-Index: AQHYJwpOs0szyq0MVUKA4rk1u5+GKayd3CkAgAACGQCAAA9EAIAAILUA
Date: Mon, 21 Feb 2022 14:20:21 +0000
Message-ID: <f1b8cacb-54a4-0402-1302-7fece7e13292@citrix.com>
References: <20220221100254.13661-1-andrew.cooper3@citrix.com>
 <20220221100254.13661-3-andrew.cooper3@citrix.com>
 <YhN1pJIDIiJscvjF@Air-de-Roger>
 <ada67c6c-bcd5-9732-c3e0-76032692ad23@citrix.com>
 <YhOENAz/08oSD7WK@Air-de-Roger>
In-Reply-To: <YhOENAz/08oSD7WK@Air-de-Roger>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: cdd5bdfe-027e-43ec-220d-08d9f5454b68
x-ms-traffictypediagnostic: DM5PR03MB3241:EE_
x-microsoft-antispam-prvs: <DM5PR03MB3241E59465B029B81824D42DBA3A9@DM5PR03MB3241.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: K44Cs85S7H6zMl1F57h+YbrF0HXGIxuiTpYPe10RpTIGQf30QLrZ+O5hp5uQa2x7VwDtFSQDonMX4yNusSuCQHWFy3a1W0n9X8cWkKmkLsdnpuGv9MsIiXar+Go7YGOBg2/HHF0s8zotUixsc4mA9BAK6CaSPEpGPyclAdYL0z275Lwplfokv3fnglGjdyoMNALDU2WHoBOp0xvYXfmvHaDDO/UAxT/17RxZuZB3gcMt3j84ZT+ItRc92g6sNoo7voGLFV3U5jf0ygm1HBSgZqUXwaYOa9tSUIleqWznhdfIumPO1B/KkxmYst7LwuxFUxc7W0QH8qS+MpsUMF6k3MrUjvg049tPuENAva7LEyNwdGG9T4He+VqCvdHC9xGMWcZaWync0BJeJcuCo3C99b6vTlMth2rtZY5EhJoC+mIpzFpuvVF36bf2KAQms35qWIl5ZxHO2kjbxnVG/QsRy9OCMr7ZOEhPeXY3cZ0P833fRYpTb3eHTktYzuimRnxjW0uHx+1eNQDvYtzcCaDfsxDLtljpAQvC5/D/5GO6paGn8tT/cnPTHTXyD9nPfO/CGeinNV7ys47odLNUqniSTNb3AkuvKrRQ9MTOiAdHZsEkzjQrPkXj6qe0HntsVRsN5UetJFRKtxXTlg9XHDmphBDgF1KYjiMtoTRCtAZUcDcOJ0rzltq7Kv33/P7kceNcL4V2pr77WE7vXW0e4JGlHUI8ie+DFRey6BtZr8XOBnsJOQP8qXOTrQziXo4wI6ZY9waVxsz7PkKddnwfzEPgpQ==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6636002)(37006003)(54906003)(26005)(8676002)(5660300002)(4326008)(66946007)(8936002)(186003)(91956017)(6862004)(66476007)(66556008)(66446008)(64756008)(76116006)(31696002)(316002)(122000001)(86362001)(82960400001)(6506007)(2616005)(31686004)(508600001)(38070700005)(6486002)(36756003)(71200400001)(2906002)(38100700002)(53546011)(6512007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?d08yS05zbE9lWEJHbXdueVhHYlpnRW02aC9tUXRWeml3US9hc2RsOVpieUFK?=
 =?utf-8?B?ak5BLzErRmJaL3FKL3FYc1NFREVoaDNmak9VNmRta3lIU0Q1RzBuQjdMRC9K?=
 =?utf-8?B?RFRVbkorb0EwNzJYblBKT2ZWKytXTmVVNTVrUjJQU1g5SGh0bEZWMUhmQVdG?=
 =?utf-8?B?aEM5bm9jOUFsRTJaVGZqNGwrbnNqR1pKQlRhRHg3bFY5VjFweUVpa1N1K3oy?=
 =?utf-8?B?ZHdhMGt1Mzh2Rzk0QnJXUkVjN0EydmovQTZOVk5yQldiLzlrSWlmYWxHY29y?=
 =?utf-8?B?K0pCb2hwSG5ZOXptR2kyZ1lrNzVrODBYWUV5TEhWdW1EbG5vY09ac0ZDSzZq?=
 =?utf-8?B?RW4zY2E3cnJncjFWWENNUlF1ajR3VFhuRTdTdFlaN24zV0E2RUFwdEN3MGYy?=
 =?utf-8?B?ejdmTDZjU3pERGlZeU01OFZOeHQ3TGVpVFdZbitIRTFZS1d2a2daT0ozYzAy?=
 =?utf-8?B?Zkp1MnJZL2xJdjBkb2xtYWt3dU9CL1R3bjFoc280c1ptbjB2VTQvTkJ1M0Vw?=
 =?utf-8?B?K3ZWdDVabjdOTk05dUIvU0NoQ2hDTFB3c0R3cW5oT2JpQ0l3RmdWM25qOCtt?=
 =?utf-8?B?OE9NcXk2QmhBU0hFUHJ3cTQ4a3QyZUJmdmdObmlmcWVOZ2FiVFN2aHRDYzVD?=
 =?utf-8?B?UmR3U0xLdk5nNnpsWFlnRkZOWkdrellJWWgyc0ZqYUphbk9QQjg0YTQ4WUZO?=
 =?utf-8?B?S2kwWVJkdk83NEZNL1p6eVlMbEVHRkp1Mi8raDFQTmRaNjR5QWsxSWVnSmlx?=
 =?utf-8?B?RFAvZkdkTXhaLzY5SFFhNDVia3YyeTU3MjBwU1dvTGZGV1c0QW1GR3NSaUdD?=
 =?utf-8?B?K3JMc0o4emQzUzJiMkJOU2ZRRXpSWCt2WXJ3aDBHM2ZzUG1RRjZpOWxxNGsr?=
 =?utf-8?B?c25DVnhsOHRiY0lnTXZLbnphd2dHOFVVTnp3SGRrK2xVNTJhdDVCVmhvTWJ1?=
 =?utf-8?B?WTZHUWUxeTFwUUllN04vTE41MXVldFFjMjBYR3pRK3AxbWhBN3VsY1dDZ2tp?=
 =?utf-8?B?Ulh2WUFFQm5zSzlYM1FsNXd3R3FyeDVlVkNNUDh6WGdnMGw4dFJLY3JCeW5W?=
 =?utf-8?B?YmMwRmpPM2dXMzAzK0FNS2w0K1J4cTV2bDNhSEZLUFZKQU5KWmxsOFowNnRP?=
 =?utf-8?B?S2s4L0V0OGdoTXJDc1o3TjZXRVY3T0ZMT0lqbWZxbkU3aXg3b0h4eW92eEVo?=
 =?utf-8?B?MTBuRjdsY015M0ZkdVRpNlo4SHZJUTA3NVQ2Q1dCcWVwK2hpbDB3dnUzVyt5?=
 =?utf-8?B?ZmxSam9KNzRTTVcwVzQzbWFvb0JqRXU4UGVLa3lhWWlqWVcvSVl1VGhuMjRP?=
 =?utf-8?B?WVh0TXRUQmRuY0txNlRZbkNSa2trYVJoM1VxaGRJd3JmdGk1Z2Y0a2xIcHZ3?=
 =?utf-8?B?eCtMT3ZSbUQ3c2xGWW03ZzF5VFJQeHQ4Q0huTTlTK0RBMVU3ZWtMWHhMRFlp?=
 =?utf-8?B?NG1TaWVkRWtUUkNPRERnNzZoNEN4L1NpVDBsNVBqRHcweTZpRWdzQWRZZXhH?=
 =?utf-8?B?V0FsMUxLc1BuUFV1MzhJaGxEUkVnUnp4MDBhckRTekw1djgyVE9OUHMwbU12?=
 =?utf-8?B?WUF3N3Z2cVk4YmFXMmdrOFdhVXhwVDFWdThGSXIvYzM3QXlmQW9ER0laeERj?=
 =?utf-8?B?TW1WaUJxVTBEY1FIVXNQZ09LYnZseU8wZmRjTnBURE5XNFl2dzJSaE1rMHhB?=
 =?utf-8?B?KzM1RERJWkVLSklFT1VLdy95US80ZTBaaGNSRndZUHpodW4rUW1FbmRscEJV?=
 =?utf-8?B?aHRXUDFTY0dOQnFLUnJvMXc0T3I2TVpLVnhuYlo2a09nUG9qRWRybE5KZlk4?=
 =?utf-8?B?K0dZWFhBZVJYNlEzaHBJcnBlR2xORHBSNlEzbHdwRkw5UUQvSUd6Uk10QWMw?=
 =?utf-8?B?eTJmYzlnb1RBa0N1SWo3R1dzb01yZmN6NHJwNzhtY3pMY09HODMrZVNDQTV1?=
 =?utf-8?B?RzZDN3JVMGxFY3hGbk1EYXdBRnJvZGh2TkZ3bHV1dXlpS2E2clBtU3hJUm43?=
 =?utf-8?B?U1JqNnRFamxxSVZxN3hWRE1WVUEvRnlGZi9jN21vazNpL1E2emlBMWdGamdj?=
 =?utf-8?B?Vm82ckhyYzFkeXZaT2N6RzQzQ2NUV2lUNjFtMFVWN09BMXE2b2tUbjBJb3lj?=
 =?utf-8?B?YVpyRmJIZ2JyR2NERnVxb3h3UDJQeS9PbzJEeFFoMmNlWmljbkZDRVRLVU44?=
 =?utf-8?B?QjJ1dmFMN0Q2Nk8reE1iQ3NxMHF5K1Y2UlVjdjk2VzdFaTBHT0ZUWkNORTZT?=
 =?utf-8?B?QUdYalJXY2drQ05QQ24wa2NvbExnPT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <EE8663EEDAD2794B8BF0522A127CA4CC@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cdd5bdfe-027e-43ec-220d-08d9f5454b68
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Feb 2022 14:20:21.3175
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: jPP66eBiIVxIJPNJfoTNXPEvmPvTKn5suVbbKJ+J+CgxW6Qo+7E9hu6n3laoh4BfpeWYSXTd9fE9u93X+tV7n0gYTABStejDE8n+841zeHs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB3241
X-OriginatorOrg: citrix.com

T24gMjEvMDIvMjAyMiAxMjoyMywgUm9nZXIgUGF1IE1vbm5lIHdyb3RlOg0KPiBPbiBNb24sIEZl
YiAyMSwgMjAyMiBhdCAxMToyODozOUFNICswMDAwLCBBbmRyZXcgQ29vcGVyIHdyb3RlOg0KPj4g
T24gMjEvMDIvMjAyMiAxMToyMSwgUm9nZXIgUGF1IE1vbm7DqSB3cm90ZToNCj4+PiBPbiBNb24s
IEZlYiAyMSwgMjAyMiBhdCAxMDowMjo1M0FNICswMDAwLCBBbmRyZXcgQ29vcGVyIHdyb3RlOg0K
Pj4+PiBDb3Zlcml0eSByZXBvcnRzIHRoYXQgdGhlcmUgaXMgYSBtZW1vcnkgbGVhayBpbg0KPj4+
PiBpb3JlcV9zZXJ2ZXJfYWxsb2NfcmFuZ2VzZXRzKCkuICBUaGlzIHdvdWxkIGJlIHRydWUgaWYg
WGVuJ3MgaW1wbGVtZW50YXRpb24gb2YNCj4+Pj4gYXNwcmludGYoKSBoYWQgZ2xpYmMncyByZXR1
cm4gc2VtYW50aWNzLCBidXQgaXQgZG9lc24ndC4NCj4+Pj4NCj4+Pj4gUmVuYW1lIHRvIHhhc3By
aW50ZigpIHRvIHJlZHVjZSBjb25mdXNpb24gZm9yIENvdmVyaXR5IGFuZCBvdGhlciBkZXZlbG9w
ZXJzLg0KPj4+IEl0IHdvdWxkIHNlZW0gbW9yZSBuYXR1cmFsIHRvIG1lIHRvIHJlbmFtZSB0byBh
c3ByaW50ay4NCj4+IFdoeT/CoCBUaGlzIGluZnJhc3RydWN0dXJlIGRvZXNuJ3QgZW1pdCB0aGUg
c3RyaW5nIHRvIGFueSBjb25zb2xlLg0KPiBSaWdodCwgYnV0IHRoZSBmIGluIHByaW50ZiBpcyBm
b3IgcHJpbnQgZm9ybWF0dGVkLCBub3QgZm9yIHdoZXJlIHRoZQ0KPiBvdXRwdXQgaXMgc3VwcG9z
ZWQgdG8gZ28uIFNvIHByaW50ayBpcyB0aGUgb3V0bGllciBhbmQgc2hvdWxkIGluc3RlYWQNCj4g
YmUga3ByaW50Zj8NCj4NCj4gSSBjYW4gYnV5IGludG8gdXNpbmcgeGFzcHJpbnRmIChhbHNvIGJl
Y2F1c2UgdGhhdCdzIHdoYXQgTGludXggZG9lcw0KPiB3aXRoIGthc3ByaW50ZiksIGJ1dCBJIGRv
bid0IHRoaW5rIGl0J3Mgc28gb2J2aW91cyBnaXZlbiB0aGUgcHJlY2VkZW50DQo+IG9mIGhhdmlu
ZyBwcmludGsgaW5zdGVhZCBvZiBwcmludGYuDQoNClRoZSBuYW1pbmcgaXNuJ3QgaWRlYWwsIGJ1
dCB0aGlzIGlzIFhlbidzIGxvY2FsIHZlcnNpb24gb2YgdGhlIHRoaW5nDQpjYWxsZWQgYXNwcmlu
dGYoKSBpbiB1c2Vyc3BhY2UuDQoNCk5hbWluZyBpdCBhbnl0aGluZyBvdGhlciB0aGFuIHhhc3By
aW50ZigpIGlzIGdvaW5nIHRvIGJlIGV2ZW4gbW9yZQ0KY29uZnVzaW5nIGZvciBwZW9wbGUgdGhh
biB0aGlzIG1lc3MgYWxyZWFkeSBpcy4uLg0KDQo+Pj4gIEkgYXNzdW1lDQo+Pj4gdGhlcmUncyBu
byB3YXkgZm9yIENvdmVyaXR5IHRvIHByZXZlbnQgb3ZlcnJpZGVzIHdpdGggYnVpbHRpbiBtb2Rl
bHM/DQo+Pj4NCj4+PiBJJ3ZlIGJlZW4gc2VhcmNoaW5nLCBidXQgdGhlcmUgZG9lc24ndCBzZWVt
IHRvIGJlIGFueSBvcHRpb24gdG8NCj4+PiBwcmV2ZW50IG92ZXJyaWRlcyBieSBidWlsdGluIG1v
ZGVscz8NCj4+IE5vLCBhbmQgd2UgYWJzb2x1dGVseSB3b3VsZG4ndCB3YW50IHRvIHNraXAgdGhl
IG1vZGVsIGV2ZW4gaWYgd2UgY291bGQsDQo+PiBiZWNhdXNlIHRoYXQgd291bGQgYnJlYWsgYXNw
cmludGYoKSBhbmFseXNpcyBmb3IgdXNlcnNwYWNlLg0KPiBXZWxsLCB3ZSBjb3VsZCBtYXliZSBm
aW5kIGEgd2F5IHRvIG9ubHkgZW5hYmxlIHRoZSBmbGFnIGZvciBoeXBlcnZpc29yDQo+IGNvZGUg
YnVpbGQsIGJ1dCBhbnl3YXksIGl0J3MgcG9pbnRsZXNzIHRvIGRpc2N1cyBpZiB0aGVyZSdzIG5v
IGZsYWcgaW4NCj4gdGhlIGZpcnN0IHBsYWNlLg0KPg0KPiBDb3Zlcml0eSBjb3VsZCBiZSBjbGV2
ZXIgZW5vdWdoIHRvIGNoZWNrIGlmIHRoZXJlJ3MgYW4gaW1wbGVtZW50YXRpb24NCj4gcHJvdmlk
ZWQgZm9yIHRob3NlLCBpbnN0ZWFkIG9mIHVuY29uZGl0aW9uYWxseSBvdmVycmlkZSB3aXRoIGEN
Cj4gbW9kZWwuDQoNClRoZXJlIGlzIG5vIHdheSB0byBkaXNhYmxlIHRoZSBtb2RlbCBmb3IgYXNw
cmludGYoKS4NCg0KfkFuZHJldw0K


From xen-devel-bounces@lists.xenproject.org Mon Feb 21 14:27:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 21 Feb 2022 14:27:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276297.472418 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM9fH-00075Z-OV; Mon, 21 Feb 2022 14:27:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276297.472418; Mon, 21 Feb 2022 14:27:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM9fH-00075S-LR; Mon, 21 Feb 2022 14:27:47 +0000
Received: by outflank-mailman (input) for mailman id 276297;
 Mon, 21 Feb 2022 14:27:46 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=tDfV=TE=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nM9fG-00075M-Fn
 for xen-devel@lists.xenproject.org; Mon, 21 Feb 2022 14:27:46 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6fa00bc6-9322-11ec-8539-5f4723681683;
 Mon, 21 Feb 2022 15:27:45 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 0291E1F390;
 Mon, 21 Feb 2022 14:27:45 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C254813B2F;
 Mon, 21 Feb 2022 14:27:44 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id AgO1LWChE2JPJwAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 21 Feb 2022 14:27:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6fa00bc6-9322-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1645453665; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=gHOy4+ZNl8F5x6c7k6RvuYPUl6iZNZdlBsE1U2QBbPE=;
	b=YHr37gvU0WSo00gNrOpqez6sccdhoaO6huBk4DdWu77SdUThgJAPT+vEMAXhFVqZ+w3yaw
	+HvRh9g9gY/H2bH1Fj/YOSogrbNxuIsOpf+yTPnl1mhASBplKuVPxd6ME68foW63hJYJkr
	8XbhPA2Rc6QSFymmkp4RYbsosqM1QQA=
Message-ID: <7798d54a-0aa8-5c13-c8fe-50e3dca54b12@suse.com>
Date: Mon, 21 Feb 2022 15:27:44 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Content-Language: en-US
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220221124221.10245-1-jgross@suse.com>
 <5bf7424a-c295-7aa5-4bf8-13136065a06b@suse.com>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH] xen/include/public: add macro for invalid grant reference
In-Reply-To: <5bf7424a-c295-7aa5-4bf8-13136065a06b@suse.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------gWE6ZntGoPMa0s0w3Uj1ykpD"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------gWE6ZntGoPMa0s0w3Uj1ykpD
Content-Type: multipart/mixed; boundary="------------tReYW0wuT60qrgHyXFQBk6eK";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
Message-ID: <7798d54a-0aa8-5c13-c8fe-50e3dca54b12@suse.com>
Subject: Re: [PATCH] xen/include/public: add macro for invalid grant reference
References: <20220221124221.10245-1-jgross@suse.com>
 <5bf7424a-c295-7aa5-4bf8-13136065a06b@suse.com>
In-Reply-To: <5bf7424a-c295-7aa5-4bf8-13136065a06b@suse.com>

--------------tReYW0wuT60qrgHyXFQBk6eK
Content-Type: multipart/mixed; boundary="------------Cuvmf1mlx7LgFe7M4o3cfBS3"

--------------Cuvmf1mlx7LgFe7M4o3cfBS3
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMjEuMDIuMjIgMTU6MTgsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAyMS4wMi4yMDIy
IDEzOjQyLCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gUHJvdmlkaW5nIGEgbWFjcm8gZm9y
IGFuIGludmFsaWQgZ3JhbnQgcmVmZXJlbmNlIHdvdWxkIGJlIGJlbmVmaWNpYWwNCj4+IGZv
ciB1c2VycywgZXNwZWNpYWxseSBhcyBzb21lIGFyZSB1c2luZyB0aGUgd3JvbmcgdmFsdWUg
IjAiIGZvciB0aGF0DQo+PiBwdXJwb3NlLg0KPj4NCj4+IFNpZ25lZC1vZmYtYnk6IEp1ZXJn
ZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4NCj4gDQo+IE92ZXIgdGhlIHllYXJzIEkndmUg
YmVlbiBjb25zaWRlcmluZyB0byBhZGQgc3VjaCB0byB0aGUgcHVibGljDQo+IGludGVyZmFj
ZSwgcGVyaGFwcyBldmVuIG1vcmUgdGhhbiBvbmNlLiBCdXQgSSdtIGFmcmFpZCBpdCdzIG5v
dCB0aGF0DQo+IGVhc3kuIEluIHByaW5jaXBsZSAweGZmZmZmZmZmICh3aGljaCBidHcgaXNu
J3QgbmVjZXNzYXJpbHkgfjB1KSBjb3VsZA0KDQpJIGNhbiBjaGFuZ2UgdGhhdCB0byB1c2Ug
MHhmZmZmZmZmZiBleHBsaWNpdGx5Lg0KDQo+IGJlIGEgdmFsaWQgcmVmLiBJdCBpcyByZWFs
bHkgaW50ZXJuYWwgYWdyZWVtZW50IGJ5IHVzZXJzIG9mIHRoZQ0KPiBpbnRlcmZhY2UgdG8g
c2V0IGZvciB0aGVtc2VsdmVzIHRoYXQgdGhleSdyZSBub3QgZXZlciBnb2luZyB0byBtYWtl
DQo+IGEgdmFsaWQgZ3JhbnQgYmVoaW5kIHRoYXQgcmVmZXJlbmNlLg0KDQpBcyB0aGUgZ3Jh
bnQgcmVmZXJlbmNlIGlzIGFuIGluZGV4IGludG8gdGhlIGdyYW50IHRhYmxlIHRoaXMgd291
bGQNCmxpbWl0IHRoZSBzaXplIG9mIHRoZSBncmFudCB0YWJsZSB0byAib25seSIgVUlOVF9N
QVggLSAxLiBJIGRvbid0DQp0aGluayB0aGlzIHdpbGwgYmUgZXZlciBhIGNvbmNlcm4gKG90
aGVyIHRoYW4gYW4gYWNhZGVtaWNhbCBvbmUpLg0KDQoNCkp1ZXJnZW4NCg0K
--------------Cuvmf1mlx7LgFe7M4o3cfBS3
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------Cuvmf1mlx7LgFe7M4o3cfBS3--

--------------tReYW0wuT60qrgHyXFQBk6eK--

--------------gWE6ZntGoPMa0s0w3Uj1ykpD
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmIToWAFAwAAAAAACgkQsN6d1ii/Ey84
zwf/dYqGfLyJotSX/10nPat1LyqdAdyNu6x9oGxLQK5QCOqNtfHJeH0/5xNxYVzhU5B0+2OS2vkK
SlNSuyZhFdyRiqkakxlDWUcg/IJ7+oHAggh6oDGJMxHJPN4DpUHz0cmDndH/zvhxdihPJgE2/sPQ
YgZTML8DhYIQS0GwNCo87nSSmK/16+zwqfRC5luCpGFWy5VJ4qgJjO3Gi/fT82E/WPXfxcdQbB4j
uY4AKB39JJqKrtcRGU8znEBMcPug/wQRlJyY286qiVnAo1EVrKrd/8FGoynWaKNn3PsPB1RGuEas
kMHpPppFaPxGJSluCYbZOFUPLGR/lrYpEkf/oeNVjQ==
=/0gY
-----END PGP SIGNATURE-----

--------------gWE6ZntGoPMa0s0w3Uj1ykpD--


From xen-devel-bounces@lists.xenproject.org Mon Feb 21 14:32:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 21 Feb 2022 14:32:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276304.472429 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM9jN-0008T7-9n; Mon, 21 Feb 2022 14:32:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276304.472429; Mon, 21 Feb 2022 14:32:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nM9jN-0008T0-6p; Mon, 21 Feb 2022 14:32:01 +0000
Received: by outflank-mailman (input) for mailman id 276304;
 Mon, 21 Feb 2022 14:32:00 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=2HaM=TE=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nM9jM-0008Su-AD
 for xen-devel@lists.xenproject.org; Mon, 21 Feb 2022 14:32:00 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 06f3c7c9-9323-11ec-8539-5f4723681683;
 Mon, 21 Feb 2022 15:31:59 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2168.outbound.protection.outlook.com [104.47.17.168]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-29-uTQrAVnWNkifpebc_PwDZA-1; Mon, 21 Feb 2022 15:31:57 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DB7PR04MB4905.eurprd04.prod.outlook.com (2603:10a6:10:1b::15) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.27; Mon, 21 Feb
 2022 14:31:56 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.4995.027; Mon, 21 Feb 2022
 14:31:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 06f3c7c9-9323-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645453919;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=JPbR5anL9d5zoDh+33JiFb/Q5vt7Fou5lwbqeLbfqUQ=;
	b=Prl4raZ/kx6MV8onGoptkItTcoOm/kKEYBEIVgphLcfmxOpMQ/b1tF55NdueSAOVkCIkei
	lmvzAmDrFYioBlLup+V1mkWBq+fPum2za+JSiUFb70Bg/DPNmBav+EgQA8gGERiTU31ovp
	ekmtrEi19hWFvvrow8Exn8a3qrm+ES0=
X-MC-Unique: uTQrAVnWNkifpebc_PwDZA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ERg1qAZWy3h8VSiEI/GFMGrDwHe1qpGZNNd4DJeZXZ7wqgbFRLhCLzi3y/BM4A95f8+E65xGfgO9ngkMjQCYC0JTTlLkpTlqQWi5JKepw13oNDS4hxjHtcPMApxJ80OBBivLCOBtnxgZA93hNwO6r3qrjKIV2+uqT3miYPGolP8fVdF7YL1APx6SdVwtcAZ0JqNpoR6nsUTSTKTphKcyVYAtPJ1FdBzuktK7YX7tG1/BTUtyaAloncilO64OLXCLGhVU9WeZqFteXxWrM/q/zFNraSJSKLGvbgpTgPNwhBNGPZ/BwLZbf0YRkkHSbF2Jt+cLdBb5PKAn+sPHqjJ3dQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=JPbR5anL9d5zoDh+33JiFb/Q5vt7Fou5lwbqeLbfqUQ=;
 b=GvUWL0y4l9JF0uRnl+pBEIdxAoeasNP9lnq7zXLeM3KiPcHOdx4dXaxHYOFMK4IE9fWnCmFxRkRZK9GkZOASownhWTArMOVoiURIV4YkhR3i2N6tR+46QTmNBiv4VWdBjxQBJeIhssMtlzceirQeWM58nnAmhDyKVi3hGjrVqMQ67x0FQgSLl5a8NcHOGpFmwDVZafh6ZkRZhnpLnWgrOwt5URYjCYo49yyrh55jWyz3aHPgus5uN48HSt1oxqKuUVfy6zzPbbpCAL+jgwDgw44fihtgRTD+xNvJz7wb+yl7a2hR/UovJgOiuQxqO6Li6cIkMxpE25x5Ppf82SRQkQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <28f2b406-f36e-e115-d6ff-cdcdf22f68ec@suse.com>
Date: Mon, 21 Feb 2022 15:31:55 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH] xen/include/public: add macro for invalid grant reference
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220221124221.10245-1-jgross@suse.com>
 <5bf7424a-c295-7aa5-4bf8-13136065a06b@suse.com>
 <7798d54a-0aa8-5c13-c8fe-50e3dca54b12@suse.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <7798d54a-0aa8-5c13-c8fe-50e3dca54b12@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR08CA0031.eurprd08.prod.outlook.com
 (2603:10a6:20b:c0::19) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 0b47296d-7e40-4382-57c3-08d9f546e93b
X-MS-TrafficTypeDiagnostic: DB7PR04MB4905:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<DB7PR04MB4905BD64F924D9214DA39022B33A9@DB7PR04MB4905.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	a/g6FNtoGoi6xt89+XgnqralAB7YffSjbBgFlRM/OuNX3tp/SY8XhhF21Tzgr06fVlFPjO9k3E3jEu0jvbVyenJ0sGJNWn/eorg2PCUqFUi/562KIGyGJRNRQhHhPkc8h4//OoKRRkP9WxGH6UZtxHFX4hBOEhlbTsFHM8cyN9yHUKNwCM63vteHRjDOrLyovSRNg71Qm82l01TDH4td+sew84JC/34OJZ8Dmmz/fYyh4TicelIRJ7mf2Anf+k60lac9GRJ4zFuvAsXWJXf8t2xDYpI4zWRaLlVYu5qCGxv71wQck5tjd8/Qc7DH1JZRlIZlxfgJCTiBjosRykL4cg0mTJnqmraVdcDTNV3Mfs6O/iPvWfBmio9RGtTS8oLFLsGsmfk9BRyIBeuLw66+BFWwXSbdzT/j9YzoEYRTvHrIGCl0PFhMfV8VDYXbiX0SjAI7M85uwRzGXPrKXVlK5sTKn9YJ5lcPCLlOtvbrTF1DGI0ck3Nq0ICy/VEhqSYCNfUO8xUlKok5FVGq0qG2G92vyvJanCOsQp3aVkt4IFvxb74hTvUciezOwu/PbQfk+xvMaxRSDayTb/JhHbod1hsypk5E0ew6JHsdY81qdzYt+1f3pditH1Y8/E7iNOcGfY2hlzDzKsjwI6STjsaSiqPYWeS2ktv90ua3oWrGDT7WOKqv4q640cOh4pkIxXztw9xf9NvrVzOPmvdibGXXKOmS1VbzZ0XVjaVI9yG59Kmp9kqDxPKbIh2XXCVDSUc8
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(36756003)(508600001)(6506007)(6486002)(6512007)(53546011)(31686004)(2616005)(2906002)(38100700002)(4326008)(5660300002)(186003)(6636002)(8676002)(54906003)(37006003)(8936002)(26005)(316002)(31696002)(86362001)(83380400001)(66476007)(66946007)(66556008)(6862004)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Z0hiTnZFT0ZkUnlpRURuKzN5TWFJZTRyVjcxaDFMMnVFTTE5U0lLdlhkTXFo?=
 =?utf-8?B?Qi9FSVVDQlFxdGpMa2R1U1VPd0lxS3J0Q1J1VlYzc3lCdU5HdDNkdHE5ZFBY?=
 =?utf-8?B?cTFVRUtEbWtaMFZoM3YzMG4rY3Y2UUhOejNwNTZHdDFVUFdrYTN2WUdpZUht?=
 =?utf-8?B?dFFFZTFZUzhsWElmSlNaTlA3MG9jdEtPVDV1VWVydUdNWkVZMHc5V1M2ZTQw?=
 =?utf-8?B?WEJ5WG43ZlRTL1k4T3RJcHFkQURYa0tHdFJOZTRncklLTmpHa25wYjJsNnFO?=
 =?utf-8?B?QWt5Z29PWjcxdlhJMm9sNWRLSUpsR3l0ZHVOQmpNc0YxRkRjMUd3S3VCN1Jv?=
 =?utf-8?B?bVBhY2hUUkVNbjVOVW5lTDh5ZFNoVW1xM1ZCUS9CTnZuRTAzUzdkSW40blZC?=
 =?utf-8?B?bjk1bXNRZyswVE9DUXIzUk5jbVNmYmJQbk5DS2Q5VFRCbEFieXYvemt4Mk8v?=
 =?utf-8?B?M1lyRXdvSzNlS08xc1gxZVdaYlBpNm9KSExhVUp3bnhLQjBlMXR2YWZMNEVO?=
 =?utf-8?B?MnY1TGhoaXZTSVRnQzFsVkJXUzc1czREbHlMU2hwcUtIdlpVUWpxLzd3M1d1?=
 =?utf-8?B?TnB1R2lESHFoYnZLOVZNb1NDekh2YnY4MWg3b2tuMlNiOWp5RlNDNGMyQ1FO?=
 =?utf-8?B?ejVuWEhXL0N0ZzVmd2JkZGZhd3d4QjdZYTA4clY0Qmk5QUxNelNuSkFNYi9S?=
 =?utf-8?B?OWc0RWx2a1BMTzlONkFEV3crY3lGUWUzcUhabTVFVkdaczZVMDE3WmpPaEU1?=
 =?utf-8?B?dHJ1b1h6a3JjQytZTlUxMGM1ek82V0xxQ2VOMmZPaCtpMTFzUXJCL3ZWQ1c2?=
 =?utf-8?B?OGNoNDRJYjUwL1NJOU1rQ3FuZFdvMmhwUkZSSnFsTGtSdUJkc3ZYZVQ5dkdP?=
 =?utf-8?B?U05wdWgyQ1pRQXVyc2NidXpWNndMNWdUWDljUFVPRXNjQW95OXlyVjVrbnBZ?=
 =?utf-8?B?MWVyMDJnQUl4Z0F2RE5Yd3kraHNQUXM2dkJEbXlSYjBSKzhpVUtWMWVQdm5a?=
 =?utf-8?B?aFloMmRIMkl0VUtnZXVObU1vSWE0K3BNWjBVWk5EaXhOOEpTL0d5UkhSKzNQ?=
 =?utf-8?B?c016SUIyVEJFSjVwT0FWK2ttbjRIU3Q4SEJlZjI3OFVNMVZ1eUR4VDFMYm9J?=
 =?utf-8?B?cy81L1hrRnJ6eXFpbTJhT0FxUkhyaU9uRFV2VE1YYmwxLzIrd0NLTEhIdU5B?=
 =?utf-8?B?WHZhTFFoVUZydm5nSGJHZUEvcmVoTGhrWnBKbE4rTG1sa2FsSFo4cUQ2VTRy?=
 =?utf-8?B?dm51MHVydWo1TW5vZS9PL2F6Y0xlS1Q2MzBlTmVmSnBYNzNvaE12VWJzQ3B4?=
 =?utf-8?B?bUJhUVJJWEZram5XYXhQYjdnYlNOSW9DcElkQi9td0JoTXRaVTg1NXY5bGlM?=
 =?utf-8?B?V1ZzWmNiQVJBckovWHQzUmNEK0hCZlZJV3ZZUGxzbmx4ajBvTmw4bXBTY0Rm?=
 =?utf-8?B?QlpwK0cvTFZHVVBPTkd5ZkpFbWgzUm9MUE5ZK2ZObW8yK2VzU1llMWQyK3dG?=
 =?utf-8?B?Mjd2c1RPZ2QvendpQXRrMW1UYWpuZ1N2c3kwb3hxOVpPUnhKVTlIUEg1U2Zv?=
 =?utf-8?B?ckpmN1Rremp0UGhNTGk2NG5iRHBJM2RuOTRXSUUxWDErbWdsUUdxSEt2ek4w?=
 =?utf-8?B?QTN1dXFBTFVucm53citXRnRLRm1tWEN6MzJNQUsvbzJMWFptc0xZM09HOTF4?=
 =?utf-8?B?d2FaOS8wRmRHUVJPUFdVemtBVXgvZXNDK1Z6eExReUhEZHpQWURIbC9sYlR4?=
 =?utf-8?B?NHNqdXNqdDNBdkUxaHE2cDZnK3M2RURod2tGMEJ1aFhwMmtFR1lCYUdZRG8y?=
 =?utf-8?B?ZG5FVjJVN1FNT0NPOXAyaVAzWVJLaHNzSm1KMW1BYTB0MUdlZGduOVAybzFr?=
 =?utf-8?B?MVJKM1cvZUFsQ0tJWW5KQ0tKQmFTWVoxTER1Zk5FYzQ5SEtHRTdXWXBRY1M3?=
 =?utf-8?B?VUdDK0lrSXVZY0tpdDhzQ3ptT2lOWkRLK0hKWmdScTRZdm54c242Z2hKSnpp?=
 =?utf-8?B?Q0xSbi9tUHhXM2NUUXphZlFHeDdnTjRyeHAzMVlYVEJKS0p6TzhhKzFTM0Nm?=
 =?utf-8?B?bW9kc2tWaEFwSUR1L1JkN2ZkRm11NitCTFNtWmNwcGZYNHhIWW1mNVZwWkFw?=
 =?utf-8?B?Vy92TWhXdnoxNTFES1k3T1BocGdqNXMzTC9ScW9IRXY0dkpCMGVvRnF4WG5y?=
 =?utf-8?Q?jLCzeREEqQS4YhNWn9Bu3hY=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0b47296d-7e40-4382-57c3-08d9f546e93b
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2022 14:31:56.0538
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kOfpmZd4C9EhExPcd4LPAWoUhnij9poSb6LqFBZjyBYm8hen2IOMuJF4xSaTykGw+jieRBNNbXihsZQjRMAgiw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4905

On 21.02.2022 15:27, Juergen Gross wrote:
> On 21.02.22 15:18, Jan Beulich wrote:
>> On 21.02.2022 13:42, Juergen Gross wrote:
>>> Providing a macro for an invalid grant reference would be beneficial
>>> for users, especially as some are using the wrong value "0" for that
>>> purpose.
>>>
>>> Signed-off-by: Juergen Gross <jgross@suse.com>
>>
>> Over the years I've been considering to add such to the public
>> interface, perhaps even more than once. But I'm afraid it's not that
>> easy. In principle 0xffffffff (which btw isn't necessarily ~0u) could
> 
> I can change that to use 0xffffffff explicitly.
> 
>> be a valid ref. It is really internal agreement by users of the
>> interface to set for themselves that they're not ever going to make
>> a valid grant behind that reference.
> 
> As the grant reference is an index into the grant table this would
> limit the size of the grant table to "only" UINT_MAX - 1. I don't
> think this will be ever a concern (other than an academical one).

That wasn't my point. Limiting the table to one less entry is not a
big deal indeed. But we have no reason to mandate which gref(s) to
consider invalid. A guest could consider gref 0 the invalid one.
The hypervisor doesn't care. Imo this simply is an aspect which is
not in need of pinning down in the ABI. Yet if it was pinned down
like you do, then the hypervisor would need to make sure it refuses
to act on this mandated invalid gref.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 21 15:05:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 21 Feb 2022 15:05:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276311.472440 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMAG3-0003My-PG; Mon, 21 Feb 2022 15:05:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276311.472440; Mon, 21 Feb 2022 15:05:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMAG3-0003Mr-MO; Mon, 21 Feb 2022 15:05:47 +0000
Received: by outflank-mailman (input) for mailman id 276311;
 Mon, 21 Feb 2022 15:05:47 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=tDfV=TE=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nMAG2-0003Ml-Vx
 for xen-devel@lists.xenproject.org; Mon, 21 Feb 2022 15:05:46 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id be88e436-9327-11ec-8eb8-a37418f5ba1a;
 Mon, 21 Feb 2022 16:05:45 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 4B9051F390;
 Mon, 21 Feb 2022 15:05:45 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1483C13AF2;
 Mon, 21 Feb 2022 15:05:45 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id FymhA0mqE2KtPQAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 21 Feb 2022 15:05:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: be88e436-9327-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1645455945; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=cWjERW4ljFNpjdEzpedk++KR/uFyHQxScEQA0N8qaI0=;
	b=pnYP1oAzrkGS7f6HbKgIKI57U/F5wfoOIKOeYvv21HAvFL9Ik28etjZkGTrdtnsiKSY6Ml
	uRy4U1fGWsXfIaq/LMyopONnltRqH0iTtH7gIMVxR3GeHXxqHjhqj4RtZi1FT7yzcmfJUW
	37ta/aNr5maNn3R78udsNL/DhKxPbns=
Message-ID: <aaef1839-96b6-0d6c-df3b-d31cc7fa697d@suse.com>
Date: Mon, 21 Feb 2022 16:05:44 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Content-Language: en-US
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220221124221.10245-1-jgross@suse.com>
 <5bf7424a-c295-7aa5-4bf8-13136065a06b@suse.com>
 <7798d54a-0aa8-5c13-c8fe-50e3dca54b12@suse.com>
 <28f2b406-f36e-e115-d6ff-cdcdf22f68ec@suse.com>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH] xen/include/public: add macro for invalid grant reference
In-Reply-To: <28f2b406-f36e-e115-d6ff-cdcdf22f68ec@suse.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------rFmTfN1Q5vtPk0yf06cc16dJ"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------rFmTfN1Q5vtPk0yf06cc16dJ
Content-Type: multipart/mixed; boundary="------------pRbUI3m10g0G42TZ860RGg5f";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
Message-ID: <aaef1839-96b6-0d6c-df3b-d31cc7fa697d@suse.com>
Subject: Re: [PATCH] xen/include/public: add macro for invalid grant reference
References: <20220221124221.10245-1-jgross@suse.com>
 <5bf7424a-c295-7aa5-4bf8-13136065a06b@suse.com>
 <7798d54a-0aa8-5c13-c8fe-50e3dca54b12@suse.com>
 <28f2b406-f36e-e115-d6ff-cdcdf22f68ec@suse.com>
In-Reply-To: <28f2b406-f36e-e115-d6ff-cdcdf22f68ec@suse.com>

--------------pRbUI3m10g0G42TZ860RGg5f
Content-Type: multipart/mixed; boundary="------------hu0cDC8DC5duCEmwqb0Fzf60"

--------------hu0cDC8DC5duCEmwqb0Fzf60
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMjEuMDIuMjIgMTU6MzEsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAyMS4wMi4yMDIy
IDE1OjI3LCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gT24gMjEuMDIuMjIgMTU6MTgsIEph
biBCZXVsaWNoIHdyb3RlOg0KPj4+IE9uIDIxLjAyLjIwMjIgMTM6NDIsIEp1ZXJnZW4gR3Jv
c3Mgd3JvdGU6DQo+Pj4+IFByb3ZpZGluZyBhIG1hY3JvIGZvciBhbiBpbnZhbGlkIGdyYW50
IHJlZmVyZW5jZSB3b3VsZCBiZSBiZW5lZmljaWFsDQo+Pj4+IGZvciB1c2VycywgZXNwZWNp
YWxseSBhcyBzb21lIGFyZSB1c2luZyB0aGUgd3JvbmcgdmFsdWUgIjAiIGZvciB0aGF0DQo+
Pj4+IHB1cnBvc2UuDQo+Pj4+DQo+Pj4+IFNpZ25lZC1vZmYtYnk6IEp1ZXJnZW4gR3Jvc3Mg
PGpncm9zc0BzdXNlLmNvbT4NCj4+Pg0KPj4+IE92ZXIgdGhlIHllYXJzIEkndmUgYmVlbiBj
b25zaWRlcmluZyB0byBhZGQgc3VjaCB0byB0aGUgcHVibGljDQo+Pj4gaW50ZXJmYWNlLCBw
ZXJoYXBzIGV2ZW4gbW9yZSB0aGFuIG9uY2UuIEJ1dCBJJ20gYWZyYWlkIGl0J3Mgbm90IHRo
YXQNCj4+PiBlYXN5LiBJbiBwcmluY2lwbGUgMHhmZmZmZmZmZiAod2hpY2ggYnR3IGlzbid0
IG5lY2Vzc2FyaWx5IH4wdSkgY291bGQNCj4+DQo+PiBJIGNhbiBjaGFuZ2UgdGhhdCB0byB1
c2UgMHhmZmZmZmZmZiBleHBsaWNpdGx5Lg0KPj4NCj4+PiBiZSBhIHZhbGlkIHJlZi4gSXQg
aXMgcmVhbGx5IGludGVybmFsIGFncmVlbWVudCBieSB1c2VycyBvZiB0aGUNCj4+PiBpbnRl
cmZhY2UgdG8gc2V0IGZvciB0aGVtc2VsdmVzIHRoYXQgdGhleSdyZSBub3QgZXZlciBnb2lu
ZyB0byBtYWtlDQo+Pj4gYSB2YWxpZCBncmFudCBiZWhpbmQgdGhhdCByZWZlcmVuY2UuDQo+
Pg0KPj4gQXMgdGhlIGdyYW50IHJlZmVyZW5jZSBpcyBhbiBpbmRleCBpbnRvIHRoZSBncmFu
dCB0YWJsZSB0aGlzIHdvdWxkDQo+PiBsaW1pdCB0aGUgc2l6ZSBvZiB0aGUgZ3JhbnQgdGFi
bGUgdG8gIm9ubHkiIFVJTlRfTUFYIC0gMS4gSSBkb24ndA0KPj4gdGhpbmsgdGhpcyB3aWxs
IGJlIGV2ZXIgYSBjb25jZXJuIChvdGhlciB0aGFuIGFuIGFjYWRlbWljYWwgb25lKS4NCj4g
DQo+IFRoYXQgd2Fzbid0IG15IHBvaW50LiBMaW1pdGluZyB0aGUgdGFibGUgdG8gb25lIGxl
c3MgZW50cnkgaXMgbm90IGENCj4gYmlnIGRlYWwgaW5kZWVkLiBCdXQgd2UgaGF2ZSBubyBy
ZWFzb24gdG8gbWFuZGF0ZSB3aGljaCBncmVmKHMpIHRvDQo+IGNvbnNpZGVyIGludmFsaWQu
IEEgZ3Vlc3QgY291bGQgY29uc2lkZXIgZ3JlZiAwIHRoZSBpbnZhbGlkIG9uZS4NCg0KV2l0
aCB0aGUgZ3JlZiBiZWluZyBhbiBpbmRleCBzdGFydGluZyB3aXRoIDAgKGdyZWYgMCBpcyB2
YWxpZCwgYXMgaXQgaXMNCnVzZWQgZm9yIHRoZSBjb25zb2xlIHJpbmcgcGFnZSksIHRoZSBu
YXR1cmFsIGNob2ljZSBmb3IgYW4gaW52YWxpZA0KdmFsdWUgaXMgdGhlIGhpZ2hlc3Qgb25l
IGJlaW5nIHJlcHJlc2VudGFibGUuIEEgZ3JlZiBpcyBvZiB0eXBlIHVpbnQzMl90DQpyZXN1
bHRpbmcgaW4gdGhpcyB2YWx1ZSBiZWluZyAweGZmZmZmZmZmLg0KDQpXaGlsZSBpbiB0aGVv
cnkgYSBncmFudCB0YWJsZSBjb3VsZCBiZSB0aGF0IGxhcmdlLCBpbiBwcmFjdGljZSB0aGlz
DQp3aWxsIG5ldmVyIGhhcHBlbi4NCg0KPiBUaGUgaHlwZXJ2aXNvciBkb2Vzbid0IGNhcmUu
IEltbyB0aGlzIHNpbXBseSBpcyBhbiBhc3BlY3Qgd2hpY2ggaXMNCg0KVGhpcyBpc24ndCB0
cnVlLiBUaGUgaHlwZXJ2aXNvciBuZWVkcyB0byBhbGxvY2F0ZSByZXNvdXJjZXMgZm9yIGJl
aW5nDQphYmxlIHRvIGhhbmRsZSB0aGUgaGlnaGVzdCBwb3NzaWJsZSBncmVmIHZhbHVlIGZv
ciBhIGd1ZXN0LiBGb3IgYSB2MQ0KZ3JhbnQgdGFibGUgdGhpcyB3b3VsZCBtZWFuIDMyR0Ig
b2YgZ3JhbnQgdGFibGUgc2l6ZS4gQXJlIHlvdSByZWFsbHkNCmNvbmNlcm5lZCB3ZSB3aWxs
IGV2ZXIgaGl0IHRoaXMgbGltaXQ/IFRoaXMgaXNuJ3QgYXQgdGhlIGd1ZXN0J3MNCmNob2lj
ZSwgYWZ0ZXIgYWxsLCBhcyB0aGUgbWF4IGdyYW50IHRhYmxlIHNpemUgaXMgbGltaXRlZCBi
eSBYZW4uDQoNCj4gbm90IGluIG5lZWQgb2YgcGlubmluZyBkb3duIGluIHRoZSBBQkkuIFll
dCBpZiBpdCB3YXMgcGlubmVkIGRvd24NCj4gbGlrZSB5b3UgZG8sIHRoZW4gdGhlIGh5cGVy
dmlzb3Igd291bGQgbmVlZCB0byBtYWtlIHN1cmUgaXQgcmVmdXNlcw0KPiB0byBhY3Qgb24g
dGhpcyBtYW5kYXRlZCBpbnZhbGlkIGdyZWYuDQoNClRoaXMgaXMgYW4gZWFzeSBvbmUuIFdl
IGNvdWxkIGp1c3QgcmVmdXNlIHRvIGhhdmUgYSBncmFudCB0YWJsZSBvZg0KdGhhdCBzaXpl
LiBJIGNhbiBhZGQgdGhpcyB0byB0aGUgcGF0Y2ggaWYgeW91IHJlYWxseSB0aGluayBpdCBp
cw0KbmVjZXNzYXJ5Lg0KDQpUQkgsIEkgdGhpbmsgc3VjaCBjb21wbGV0ZWx5IHRoZW9yZXRp
Y2FsIGNvbmNlcm5zIHNob3VsZCBub3Qgc3RhbmQNCmluIHRoZSB3YXkgb2YgYWRkaXRpb25z
IHRvIHRoZSBBQkkgbWFraW5nIGxpZmUgZWFzaWVyIGZvciBjb25zdW1lcnMuDQoNCg0KSnVl
cmdlbg0K
--------------hu0cDC8DC5duCEmwqb0Fzf60
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------hu0cDC8DC5duCEmwqb0Fzf60--

--------------pRbUI3m10g0G42TZ860RGg5f--

--------------rFmTfN1Q5vtPk0yf06cc16dJ
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmITqkgFAwAAAAAACgkQsN6d1ii/Ey+N
cwf6A5JodOCKMstkXsJrdXzdeHtA5OQ8x6ry84sVpFd3GpNh/HjrmUuVIHlMTk7nKXqSAV4R+GxS
34wUcAhTpcginW3llmoEEOuUPnTt1iHlU1D6JtpV2qLoEXL2ivJ9KxAH/mDPVkLhceEXoLjNKhyk
86pHi5I/BhSOvv8FeqJatSbRqI9XZAPyySYYIRZ40kSu1r28cQkmH43BBLmTQeSQpi9SMjugREUa
2LSXcBvAS4l2YyFsoeHXOr6J0hMrNKpmppK0J5hYggcGcLQwcAG+bkhlTyQVQ9rDEF40siu0sXGD
lYD80q3bEoRoO8JRrp4+8gPAdtfr0owkp7caZZEhxQ==
=V0nf
-----END PGP SIGNATURE-----

--------------rFmTfN1Q5vtPk0yf06cc16dJ--


From xen-devel-bounces@lists.xenproject.org Mon Feb 21 15:32:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 21 Feb 2022 15:32:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276329.472456 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMAfG-0006iU-3C; Mon, 21 Feb 2022 15:31:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276329.472456; Mon, 21 Feb 2022 15:31:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMAfG-0006iN-01; Mon, 21 Feb 2022 15:31:50 +0000
Received: by outflank-mailman (input) for mailman id 276329;
 Mon, 21 Feb 2022 15:31:49 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=2HaM=TE=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nMAfF-0006iH-3o
 for xen-devel@lists.xenproject.org; Mon, 21 Feb 2022 15:31:49 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 61bc446f-932b-11ec-8539-5f4723681683;
 Mon, 21 Feb 2022 16:31:47 +0100 (CET)
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2051.outbound.protection.outlook.com [104.47.1.51]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-28-17qGHCAWMGiN693-Uthv9Q-1; Mon, 21 Feb 2022 16:31:45 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by PAXPR04MB8848.eurprd04.prod.outlook.com (2603:10a6:102:20f::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.27; Mon, 21 Feb
 2022 15:31:44 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.4995.027; Mon, 21 Feb 2022
 15:31:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 61bc446f-932b-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645457507;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=pRZEcBrAC7IGwEmJrmesAv8oAgOCtQTmkNdtX94df0A=;
	b=TqzSNuiSiNRVZxlhuZjRQufSZLC7fAmMpgBEgHXWrdxNN2Q28s110uKu4ZmlcJEQVeBxMe
	M0eglg03Mk2sTva40T0UXAQWb+L56CZ81WXqYF7O6lujpv5uHfn/IUx1hM+pgtKRdoXx3c
	NBHNu1H1hDH+7kA5xhP4fpf/NBOIGf0=
X-MC-Unique: 17qGHCAWMGiN693-Uthv9Q-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=U/BtWwfJmmktCCI8Z25RalB3Tt8Z6mUlhYzLu1dJl7ILcGLwBJ1N6r8JHixuGrrK01nJDS4ilXDBcmc7CR5avSvuTM6LMn++0cw7jo2A3V1rpxa+r/he7bMMLEPlRIY+yW4Jt7JfwAt9fJxHm9qgVpWwrtAtvla2XWwRrOsQeAoI2K/gzBUghincLQL3EASwZTeQhG6fm5S3pGiu+SdJDgsejvxHg4lmD+0Er8hoO8/7fRm9C2VTlvnIq+ALdpRoW4OE3WfI0At/2rAxPOD0OSOtrko/3RFp23i8LjpKlh3LKX8ks+cTEWihCnxF99WqvJP+xJu66JTtpVlBjNRAvA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=pRZEcBrAC7IGwEmJrmesAv8oAgOCtQTmkNdtX94df0A=;
 b=QAsET4po73mtZcHX0xJFhuCFSdZKrxxsW5nsn9/6GyJKzMJeRia65g1TCkljDiW6O14nKdrJD4vcNAJqeI8EagiDvRpy5aHxf2dPWX30FfnixK5AVcwm+mrSxYvjZ+oX2DZ4wLDPceuBHNI9UjP1HDRn2mHzijrgCc4JU5D1t9XKlxYCUZlvJCFmP7m+EU/3pKy6O6gC7U+tMRva/gHreMFe8ONUPQLBMX1Uo20kpH4Q8pxJkd94NjBjZ8m5R33+SUR/k7Jd0WF1q09Jv9WjwdNGoda4bVt2RVIdkr2cnBcbYZn1CakqdBZHmYcgN4WfBi0/pKWL41n8pBlinzHmew==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <e8a17311-1a56-23d1-7414-0f9ae18cc0e1@suse.com>
Date: Mon, 21 Feb 2022 16:31:41 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH] xen/include/public: add macro for invalid grant reference
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220221124221.10245-1-jgross@suse.com>
 <5bf7424a-c295-7aa5-4bf8-13136065a06b@suse.com>
 <7798d54a-0aa8-5c13-c8fe-50e3dca54b12@suse.com>
 <28f2b406-f36e-e115-d6ff-cdcdf22f68ec@suse.com>
 <aaef1839-96b6-0d6c-df3b-d31cc7fa697d@suse.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <aaef1839-96b6-0d6c-df3b-d31cc7fa697d@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR07CA0003.eurprd07.prod.outlook.com
 (2603:10a6:20b:451::18) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ae52f283-29b1-4da0-6448-08d9f54f43c7
X-MS-TrafficTypeDiagnostic: PAXPR04MB8848:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<PAXPR04MB88486B2D15C5BDDD950E6CAAB33A9@PAXPR04MB8848.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	LcjKLVbyLeK/CKMPQ6qLvyf2qLEIh9IMcoIDbaALZcZJwGmd7eHgPX/8pnBYs9wAScJ9K22d7GO4r7yz/qz26WNWpcN8w615n2f5FG6MV4f8QiBZMmZdPnTqBnFSvN+ms5e4k2m9thJw/1kYob3Srh7TzX9Yo+qUUYLzHvKDxcj5RoCmKSIzlXKHWgx1sniq/pw987GBTEhW3DMCaIirEUoueERR2JyRDv/TC9/H9l9g4h/T2Kol1eVHm7DZ6fme7F9Fboi1tDF2l1Xqst4jO7krQztJx+r3sH9I7/vB+0hhvLBh9CyRpwm5Xe016GLw4SAWQWiW0jYItOV/dttXz0kDKxptj4q9LhVo75WYAYxcOA1M3kIfnwajkfy0QdMzh+CK5dLbxsNBB/aNUZnrTc3M49m/ZCyVH/a1pdUOL3g7CYOKPzbMKl4T/OihPCmOXWxV8vui/AIq/uBA7ms7PWYePavYziU89KI3h3c8knoQwpnYtXHZbcpx+2PZ5oEkap34FJeTv8WqEAwyhSBDiyKqOvVPQhL+Zucx2AHqQ1A2GLG/E+NODqVgklbW6L2y33Ltwj1QK2fMI+ekvzQy1o+x2ttDLjD6CndlhmGPT9H85lPxbphxNzdrmYHE4aMQUgCc01xg8nkccz9vs4JPur/JDfQH5HCevj/X7e8ne1d9e/Wl0AnRL2lIEWNj7KBiFIjlaIpTCstC8NKUjghnApJr/MDD2fQy5p4D+4fkMvo=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66946007)(8676002)(6506007)(4326008)(38100700002)(36756003)(66556008)(186003)(6862004)(31686004)(66476007)(53546011)(26005)(6666004)(6486002)(6512007)(8936002)(508600001)(5660300002)(316002)(2616005)(37006003)(83380400001)(54906003)(6636002)(31696002)(2906002)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RUg2UENGNVRGMFBlTVZDcjN4Z2VPT2lIdysyT1lSTDZocnJ2eG85ODBtTisy?=
 =?utf-8?B?RERTWFBRZm9xbjNFRnE4NzF1WGU5TUpkTFFFbWVIZ0JtZGVSVnFGU1FPUjJM?=
 =?utf-8?B?YVc2MGhMQmhBOG0xYWVVMUZvaElxNWU5WDYxQXV6UEhTMGNzOUNtZXRmM2Qz?=
 =?utf-8?B?SGpuUCtrMWRxcXFRRXRQTGNPdUZsalFDK3hKNmlEZG5sMHNycEpIUU9pNG5a?=
 =?utf-8?B?eGVJaWFWNXZNM241UEc3aHQ3S3VqSExlYXhIZWJqQWYybGNKVERZOTg5elpD?=
 =?utf-8?B?YVEzN1hhaGZudDVGTXVnZlI5djZ2K2pXUWxXaEJNVERTSVFURDArb3pTOStL?=
 =?utf-8?B?dkY0NDhySjFLZlNDeWY2SEdsR2hRa0htbDlHRUlaYnl3bDhWRy80MWtXbnFz?=
 =?utf-8?B?bGFlUlZyZVllcWpDQXFvS0FMSENGQStUQWkzMjM4cmZUWk1LdVFLdnBLU1l4?=
 =?utf-8?B?N2NCaEZqd1Q5OWwyVWRiM1pjWEN2OWJTMkxhYjJRdWs4T05xL2lyMDNlb0lp?=
 =?utf-8?B?Rk1BTTV6NzFZL29ONDkrcXNlYzFqbGRTTndreHA0WS9HUXp2Vy92ejg3MzRx?=
 =?utf-8?B?cnJHNnFnbDc5T0RrMk52eWQvaldlMldPcTlodGhkTzgyZUR6Wm5NUm5LTzdz?=
 =?utf-8?B?NW1oMUt4TFMrb29ldzByYzdSOFNZK3orMzFwUVZDWGFycjhzd3J1UmVpekt6?=
 =?utf-8?B?UmpnM2V0SmI2R3AvZkVGMmxhMTJGNUJ1OC9qcU9tNm9XLzV6MUtGVXhiZkxU?=
 =?utf-8?B?ejY2NjBKRkF4TDNZbGo3dW1BMWF0b2ROR1k1RUR1MlByOVJYNTMvNVRIM1B2?=
 =?utf-8?B?aXZhRnhvblhhNXMxRHNuakt1a2NuRDljaTJ4aUoydS9TMnM5ZFBOZndyUC9C?=
 =?utf-8?B?R1F4azJOS05QZ1grWVMzbk5yQ1dWY01pTmZiL3dwVFNwUVpJTmhsVGVuNldz?=
 =?utf-8?B?YkF5RTlFRU4vVkJ0MmxFTlZFaWJvUmhZaXpZOStkOUo5Z2VLU0htak1KazN5?=
 =?utf-8?B?MFJVd3hMYnJjWWZMak9GNVBheTYraVV4a01vSFVMaHNpaGw4RUhPblFBQmtF?=
 =?utf-8?B?NUM1bEhHekErL3g2MDcyZUxqL3laOTVhT3JYa3ppMmJod1Zna0xXUTZRU0Zi?=
 =?utf-8?B?ZmJ3d2tKUXFySy9WNVRoMGpRQTlFUVRWL0hWS2RpTS9wU3ZCTVp1NGZteGUv?=
 =?utf-8?B?SnJqMklSVGpyTVVJenBwZ200UC9UNUNxYmNsR1BLaFRwQ055by9lNlJZR1Ez?=
 =?utf-8?B?bVBsSlhwUW5Cc1VPY3ZHMEo1N2xES1YwNjhidEJZSk1YZlBabzBUL25IazZR?=
 =?utf-8?B?MHp4SWVwbjhUMUlMZmZmUGdtQWFBV1VYbFYweE8wNk9oTTlrcGhaNU85UkhS?=
 =?utf-8?B?dnhWUkNNem5NVmcxMlVhUW1BbCt0ejlOU3RNQWZKOXVLRkVYU0VkSWRpYjBq?=
 =?utf-8?B?c1kydXRhN0dSUlg0em9DcTNEMFhXaXAydjhhaGR0MkZNdysvMVBKeGdSVUJ4?=
 =?utf-8?B?d3ZDcFkzb1hBWU9XSHBVQVgyZWxrai8vRzlsYlBOMFdCS0kyUXFHcWYrU2x5?=
 =?utf-8?B?RVVPWnlzU0xUSFd5UklGejROTUtyR2M1TFIvTmhPNHQ3YXBvN0x4MUtwZitp?=
 =?utf-8?B?cE9lNGJpalNwSnRocjB1aWtYblVxck5IK1ZFc0pGU01nT1MrWlRSbWk0OGR5?=
 =?utf-8?B?b2JvcjA1U0swNlRNVmtYQmV0a280UjIwSXk0UlVFc2VyU29CQ1oweTRLSHk2?=
 =?utf-8?B?T1FnWGZncnp0OCs1aFB3MHJGR2hDdUFRWXI3RVpROVk1ZG1WbHFrd3RFRmV2?=
 =?utf-8?B?WDdhZnFha1Q0eE9tS1Y2eHhTK3ZtQlp4bWh3RmhuOUxMNW1ESFZjeW90aHMw?=
 =?utf-8?B?ZkgxZlNrSk0rYVVqbXl3TVJpOWZDeWRaQ0dzTXQwNUNvUElRNS94MVYyR1NW?=
 =?utf-8?B?b09jZFhOSkhoOEZEblh4NmxIZzFzdlZPQ0FWaDlxUUVKa1BCUjFyaE1YWmg1?=
 =?utf-8?B?MmFlT0xFOUgrdmxZSTllNXZhdWdod05MVnExRmRubHhOaTZWaXVrNXlkVHRn?=
 =?utf-8?B?K1NZNCs0ZFNudm9RYjJublRBRVpBZFQ5dEF1YVJnUmdoTXRORFNRdHZyMG5S?=
 =?utf-8?B?c09EeGVxandaYUZjakRQSisrWHozWlgxb3BzaU1veno3NVExM3owUGlkUnly?=
 =?utf-8?Q?rUTAAbNtoKF4swI0GnO/DHQ=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ae52f283-29b1-4da0-6448-08d9f54f43c7
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2022 15:31:44.0029
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3ScB/ioBbXZ/NV9sj/r5Zz0IoO7Ba3BqhbAQBu7Ta7W6BYegQMnzEiPRc8Sv9NPiwJ39RJSp+BPnsMhj+KqxIA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8848

On 21.02.2022 16:05, Juergen Gross wrote:
> On 21.02.22 15:31, Jan Beulich wrote:
>> On 21.02.2022 15:27, Juergen Gross wrote:
>>> On 21.02.22 15:18, Jan Beulich wrote:
>>>> On 21.02.2022 13:42, Juergen Gross wrote:
>>>>> Providing a macro for an invalid grant reference would be beneficial
>>>>> for users, especially as some are using the wrong value "0" for that
>>>>> purpose.
>>>>>
>>>>> Signed-off-by: Juergen Gross <jgross@suse.com>
>>>>
>>>> Over the years I've been considering to add such to the public
>>>> interface, perhaps even more than once. But I'm afraid it's not that
>>>> easy. In principle 0xffffffff (which btw isn't necessarily ~0u) could
>>>
>>> I can change that to use 0xffffffff explicitly.
>>>
>>>> be a valid ref. It is really internal agreement by users of the
>>>> interface to set for themselves that they're not ever going to make
>>>> a valid grant behind that reference.
>>>
>>> As the grant reference is an index into the grant table this would
>>> limit the size of the grant table to "only" UINT_MAX - 1. I don't
>>> think this will be ever a concern (other than an academical one).
>>
>> That wasn't my point. Limiting the table to one less entry is not a
>> big deal indeed. But we have no reason to mandate which gref(s) to
>> consider invalid. A guest could consider gref 0 the invalid one.
> 
> With the gref being an index starting with 0 (gref 0 is valid, as it is
> used for the console ring page), the natural choice for an invalid
> value is the highest one being representable. A gref is of type uint32_t
> resulting in this value being 0xffffffff.
> 
> While in theory a grant table could be that large, in practice this
> will never happen.
> 
>> The hypervisor doesn't care. Imo this simply is an aspect which is
> 
> This isn't true. The hypervisor needs to allocate resources for being
> able to handle the highest possible gref value for a guest. For a v1
> grant table this would mean 32GB of grant table size. Are you really
> concerned we will ever hit this limit? This isn't at the guest's
> choice, after all, as the max grant table size is limited by Xen.

If we're not going to hit that limit, what's wrong with declaring the
entire upper half of uint32_t space "invalid" for use a gref? If we
won't ever go up to 32Gb, we quite certainly also won't ever reach
16Gb. Yes, you probably already guessed it, we can then repeat this
process iteratively until we reach 4kb.

>> not in need of pinning down in the ABI. Yet if it was pinned down
>> like you do, then the hypervisor would need to make sure it refuses
>> to act on this mandated invalid gref.
> 
> This is an easy one. We could just refuse to have a grant table of
> that size. I can add this to the patch if you really think it is
> necessary.

Since grant table size is measured in pages, you'd then have to
refuse use of more than just that single gref. This would still not
be an immediate problem, but demonstrates again that it's unclear
where to draw such a boundary, if one is to be artificially drawn.

> TBH, I think such completely theoretical concerns should not stand
> in the way of additions to the ABI making life easier for consumers.

In case it wasn't clear - my concern isn't that sacrificing this one
entry may cause a problem, or that we'd ever see grant tables grow
this big (albeit for the latter: you never really know). Instead my
concern is that it is conceptually wrong for us to (now) introduce
such a value.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 21 15:48:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 21 Feb 2022 15:48:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276336.472466 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMAus-0008Hk-G9; Mon, 21 Feb 2022 15:47:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276336.472466; Mon, 21 Feb 2022 15:47:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMAus-0008Hd-DB; Mon, 21 Feb 2022 15:47:58 +0000
Received: by outflank-mailman (input) for mailman id 276336;
 Mon, 21 Feb 2022 15:47:57 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TsHg=TE=alpha.franken.de=tsbogend@srs-se1.protection.inumbo.net>)
 id 1nMAur-0008HX-4x
 for xen-devel@lists.xenproject.org; Mon, 21 Feb 2022 15:47:57 +0000
Received: from elvis.franken.de (elvis.franken.de [193.175.24.41])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id a2c6ebb7-932d-11ec-8539-5f4723681683;
 Mon, 21 Feb 2022 16:47:55 +0100 (CET)
Received: from uucp (helo=alpha)
 by elvis.franken.de with local-bsmtp (Exim 3.36 #1)
 id 1nMAI2-0001zd-00; Mon, 21 Feb 2022 16:07:50 +0100
Received: by alpha.franken.de (Postfix, from userid 1000)
 id F02CFC25EA; Mon, 21 Feb 2022 15:42:02 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a2c6ebb7-932d-11ec-8539-5f4723681683
Date: Mon, 21 Feb 2022 15:42:02 +0100
From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Russell King <linux@armlinux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>, Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Sebastian Reichel <sre@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>, Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>, Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Pavel Machek <pavel@ucw.cz>,
	Lee Jones <lee.jones@linaro.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>, alankao@andestech.com,
	"K . C . Kuen-Chern Lin" <kclin@andestech.com>,
	=?utf-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= <mirq-linux@rere.qmqm.pl>,
	linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org,
	linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org, linux-acpi@vger.kernel.org,
	linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH v6 16/21] mips: Use do_kernel_power_off()
Message-ID: <20220221144202.GA17239@alpha.franken.de>
References: <20220130233718.21544-1-digetx@gmail.com>
 <20220130233718.21544-17-digetx@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220130233718.21544-17-digetx@gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)

On Mon, Jan 31, 2022 at 02:37:13AM +0300, Dmitry Osipenko wrote:
> Kernel now supports chained power-off handlers. Use do_kernel_power_off()
> that invokes chained power-off handlers. It also invokes legacy
> pm_power_off() for now, which will be removed once all drivers will
> be converted to the new power-off API.
> 
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
>  arch/mips/kernel/reset.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/arch/mips/kernel/reset.c b/arch/mips/kernel/reset.c
> index 6288780b779e..e7ce07b3e79b 100644
> --- a/arch/mips/kernel/reset.c
> +++ b/arch/mips/kernel/reset.c
> @@ -114,8 +114,7 @@ void machine_halt(void)
>  
>  void machine_power_off(void)
>  {
> -	if (pm_power_off)
> -		pm_power_off();
> +	do_kernel_power_off();
>  
>  #ifdef CONFIG_SMP
>  	preempt_disable();
> -- 
> 2.34.1

Ackey-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]


From xen-devel-bounces@lists.xenproject.org Mon Feb 21 15:57:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 21 Feb 2022 15:57:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276344.472477 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMB45-0001KT-Ds; Mon, 21 Feb 2022 15:57:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276344.472477; Mon, 21 Feb 2022 15:57:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMB45-0001KM-Ak; Mon, 21 Feb 2022 15:57:29 +0000
Received: by outflank-mailman (input) for mailman id 276344;
 Mon, 21 Feb 2022 15:57:28 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=tDfV=TE=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nMB44-0001KG-O0
 for xen-devel@lists.xenproject.org; Mon, 21 Feb 2022 15:57:28 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f7749abf-932e-11ec-8539-5f4723681683;
 Mon, 21 Feb 2022 16:57:27 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id D87ED2111A;
 Mon, 21 Feb 2022 15:57:26 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A4FE513B2F;
 Mon, 21 Feb 2022 15:57:26 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id d7MCJ2a2E2I4VwAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 21 Feb 2022 15:57:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f7749abf-932e-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1645459046; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=1A0gfhEuKVDQDqf9bChdIZuM4QAkI1Sm5403kO/AaiE=;
	b=T3U4dQ2EOUvGLusBS9AXYmSVapgIWVc//EzrigrvdbdHr4ZqONd8Cxdsltk8pWjg9sR1ew
	aMN/SXww2PHcIS2PhVC10vbByzc3SyYpGTbiuLU6sbx1anyw9JZ8l97/0SDihBfqQCSvG4
	/STxS3RFcn/jICb+8UCQkaFpYhjpFus=
Message-ID: <06890331-8c75-ddb9-57e8-284c47d4d562@suse.com>
Date: Mon, 21 Feb 2022 16:57:26 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Content-Language: en-US
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220221124221.10245-1-jgross@suse.com>
 <5bf7424a-c295-7aa5-4bf8-13136065a06b@suse.com>
 <7798d54a-0aa8-5c13-c8fe-50e3dca54b12@suse.com>
 <28f2b406-f36e-e115-d6ff-cdcdf22f68ec@suse.com>
 <aaef1839-96b6-0d6c-df3b-d31cc7fa697d@suse.com>
 <e8a17311-1a56-23d1-7414-0f9ae18cc0e1@suse.com>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH] xen/include/public: add macro for invalid grant reference
In-Reply-To: <e8a17311-1a56-23d1-7414-0f9ae18cc0e1@suse.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------g9q8BnPBMZPaXM4LwKqQOnko"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------g9q8BnPBMZPaXM4LwKqQOnko
Content-Type: multipart/mixed; boundary="------------nuwbFMD63OvCpq7mmzhltG0w";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
Message-ID: <06890331-8c75-ddb9-57e8-284c47d4d562@suse.com>
Subject: Re: [PATCH] xen/include/public: add macro for invalid grant reference
References: <20220221124221.10245-1-jgross@suse.com>
 <5bf7424a-c295-7aa5-4bf8-13136065a06b@suse.com>
 <7798d54a-0aa8-5c13-c8fe-50e3dca54b12@suse.com>
 <28f2b406-f36e-e115-d6ff-cdcdf22f68ec@suse.com>
 <aaef1839-96b6-0d6c-df3b-d31cc7fa697d@suse.com>
 <e8a17311-1a56-23d1-7414-0f9ae18cc0e1@suse.com>
In-Reply-To: <e8a17311-1a56-23d1-7414-0f9ae18cc0e1@suse.com>

--------------nuwbFMD63OvCpq7mmzhltG0w
Content-Type: multipart/mixed; boundary="------------q1lzEjwDYKv0yWnYKaAhRmvf"

--------------q1lzEjwDYKv0yWnYKaAhRmvf
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMjEuMDIuMjIgMTY6MzEsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAyMS4wMi4yMDIy
IDE2OjA1LCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gT24gMjEuMDIuMjIgMTU6MzEsIEph
biBCZXVsaWNoIHdyb3RlOg0KPj4+IE9uIDIxLjAyLjIwMjIgMTU6MjcsIEp1ZXJnZW4gR3Jv
c3Mgd3JvdGU6DQo+Pj4+IE9uIDIxLjAyLjIyIDE1OjE4LCBKYW4gQmV1bGljaCB3cm90ZToN
Cj4+Pj4+IE9uIDIxLjAyLjIwMjIgMTM6NDIsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+Pj4+
Pj4gUHJvdmlkaW5nIGEgbWFjcm8gZm9yIGFuIGludmFsaWQgZ3JhbnQgcmVmZXJlbmNlIHdv
dWxkIGJlIGJlbmVmaWNpYWwNCj4+Pj4+PiBmb3IgdXNlcnMsIGVzcGVjaWFsbHkgYXMgc29t
ZSBhcmUgdXNpbmcgdGhlIHdyb25nIHZhbHVlICIwIiBmb3IgdGhhdA0KPj4+Pj4+IHB1cnBv
c2UuDQo+Pj4+Pj4NCj4+Pj4+PiBTaWduZWQtb2ZmLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jv
c3NAc3VzZS5jb20+DQo+Pj4+Pg0KPj4+Pj4gT3ZlciB0aGUgeWVhcnMgSSd2ZSBiZWVuIGNv
bnNpZGVyaW5nIHRvIGFkZCBzdWNoIHRvIHRoZSBwdWJsaWMNCj4+Pj4+IGludGVyZmFjZSwg
cGVyaGFwcyBldmVuIG1vcmUgdGhhbiBvbmNlLiBCdXQgSSdtIGFmcmFpZCBpdCdzIG5vdCB0
aGF0DQo+Pj4+PiBlYXN5LiBJbiBwcmluY2lwbGUgMHhmZmZmZmZmZiAod2hpY2ggYnR3IGlz
bid0IG5lY2Vzc2FyaWx5IH4wdSkgY291bGQNCj4+Pj4NCj4+Pj4gSSBjYW4gY2hhbmdlIHRo
YXQgdG8gdXNlIDB4ZmZmZmZmZmYgZXhwbGljaXRseS4NCj4+Pj4NCj4+Pj4+IGJlIGEgdmFs
aWQgcmVmLiBJdCBpcyByZWFsbHkgaW50ZXJuYWwgYWdyZWVtZW50IGJ5IHVzZXJzIG9mIHRo
ZQ0KPj4+Pj4gaW50ZXJmYWNlIHRvIHNldCBmb3IgdGhlbXNlbHZlcyB0aGF0IHRoZXkncmUg
bm90IGV2ZXIgZ29pbmcgdG8gbWFrZQ0KPj4+Pj4gYSB2YWxpZCBncmFudCBiZWhpbmQgdGhh
dCByZWZlcmVuY2UuDQo+Pj4+DQo+Pj4+IEFzIHRoZSBncmFudCByZWZlcmVuY2UgaXMgYW4g
aW5kZXggaW50byB0aGUgZ3JhbnQgdGFibGUgdGhpcyB3b3VsZA0KPj4+PiBsaW1pdCB0aGUg
c2l6ZSBvZiB0aGUgZ3JhbnQgdGFibGUgdG8gIm9ubHkiIFVJTlRfTUFYIC0gMS4gSSBkb24n
dA0KPj4+PiB0aGluayB0aGlzIHdpbGwgYmUgZXZlciBhIGNvbmNlcm4gKG90aGVyIHRoYW4g
YW4gYWNhZGVtaWNhbCBvbmUpLg0KPj4+DQo+Pj4gVGhhdCB3YXNuJ3QgbXkgcG9pbnQuIExp
bWl0aW5nIHRoZSB0YWJsZSB0byBvbmUgbGVzcyBlbnRyeSBpcyBub3QgYQ0KPj4+IGJpZyBk
ZWFsIGluZGVlZC4gQnV0IHdlIGhhdmUgbm8gcmVhc29uIHRvIG1hbmRhdGUgd2hpY2ggZ3Jl
ZihzKSB0bw0KPj4+IGNvbnNpZGVyIGludmFsaWQuIEEgZ3Vlc3QgY291bGQgY29uc2lkZXIg
Z3JlZiAwIHRoZSBpbnZhbGlkIG9uZS4NCj4+DQo+PiBXaXRoIHRoZSBncmVmIGJlaW5nIGFu
IGluZGV4IHN0YXJ0aW5nIHdpdGggMCAoZ3JlZiAwIGlzIHZhbGlkLCBhcyBpdCBpcw0KPj4g
dXNlZCBmb3IgdGhlIGNvbnNvbGUgcmluZyBwYWdlKSwgdGhlIG5hdHVyYWwgY2hvaWNlIGZv
ciBhbiBpbnZhbGlkDQo+PiB2YWx1ZSBpcyB0aGUgaGlnaGVzdCBvbmUgYmVpbmcgcmVwcmVz
ZW50YWJsZS4gQSBncmVmIGlzIG9mIHR5cGUgdWludDMyX3QNCj4+IHJlc3VsdGluZyBpbiB0
aGlzIHZhbHVlIGJlaW5nIDB4ZmZmZmZmZmYuDQo+Pg0KPj4gV2hpbGUgaW4gdGhlb3J5IGEg
Z3JhbnQgdGFibGUgY291bGQgYmUgdGhhdCBsYXJnZSwgaW4gcHJhY3RpY2UgdGhpcw0KPj4g
d2lsbCBuZXZlciBoYXBwZW4uDQo+Pg0KPj4+IFRoZSBoeXBlcnZpc29yIGRvZXNuJ3QgY2Fy
ZS4gSW1vIHRoaXMgc2ltcGx5IGlzIGFuIGFzcGVjdCB3aGljaCBpcw0KPj4NCj4+IFRoaXMg
aXNuJ3QgdHJ1ZS4gVGhlIGh5cGVydmlzb3IgbmVlZHMgdG8gYWxsb2NhdGUgcmVzb3VyY2Vz
IGZvciBiZWluZw0KPj4gYWJsZSB0byBoYW5kbGUgdGhlIGhpZ2hlc3QgcG9zc2libGUgZ3Jl
ZiB2YWx1ZSBmb3IgYSBndWVzdC4gRm9yIGEgdjENCj4+IGdyYW50IHRhYmxlIHRoaXMgd291
bGQgbWVhbiAzMkdCIG9mIGdyYW50IHRhYmxlIHNpemUuIEFyZSB5b3UgcmVhbGx5DQo+PiBj
b25jZXJuZWQgd2Ugd2lsbCBldmVyIGhpdCB0aGlzIGxpbWl0PyBUaGlzIGlzbid0IGF0IHRo
ZSBndWVzdCdzDQo+PiBjaG9pY2UsIGFmdGVyIGFsbCwgYXMgdGhlIG1heCBncmFudCB0YWJs
ZSBzaXplIGlzIGxpbWl0ZWQgYnkgWGVuLg0KPiANCj4gSWYgd2UncmUgbm90IGdvaW5nIHRv
IGhpdCB0aGF0IGxpbWl0LCB3aGF0J3Mgd3Jvbmcgd2l0aCBkZWNsYXJpbmcgdGhlDQo+IGVu
dGlyZSB1cHBlciBoYWxmIG9mIHVpbnQzMl90IHNwYWNlICJpbnZhbGlkIiBmb3IgdXNlIGEg
Z3JlZj8gSWYgd2UNCj4gd29uJ3QgZXZlciBnbyB1cCB0byAzMkdiLCB3ZSBxdWl0ZSBjZXJ0
YWlubHkgYWxzbyB3b24ndCBldmVyIHJlYWNoDQo+IDE2R2IuIFllcywgeW91IHByb2JhYmx5
IGFscmVhZHkgZ3Vlc3NlZCBpdCwgd2UgY2FuIHRoZW4gcmVwZWF0IHRoaXMNCj4gcHJvY2Vz
cyBpdGVyYXRpdmVseSB1bnRpbCB3ZSByZWFjaCA0a2IuDQoNClRoaXMgcmVhc29uaW5nIGlz
IG5vbnNlbnNlLCBhbmQgeW91IGtub3cgaXQuDQoNCj4+PiBub3QgaW4gbmVlZCBvZiBwaW5u
aW5nIGRvd24gaW4gdGhlIEFCSS4gWWV0IGlmIGl0IHdhcyBwaW5uZWQgZG93bg0KPj4+IGxp
a2UgeW91IGRvLCB0aGVuIHRoZSBoeXBlcnZpc29yIHdvdWxkIG5lZWQgdG8gbWFrZSBzdXJl
IGl0IHJlZnVzZXMNCj4+PiB0byBhY3Qgb24gdGhpcyBtYW5kYXRlZCBpbnZhbGlkIGdyZWYu
DQo+Pg0KPj4gVGhpcyBpcyBhbiBlYXN5IG9uZS4gV2UgY291bGQganVzdCByZWZ1c2UgdG8g
aGF2ZSBhIGdyYW50IHRhYmxlIG9mDQo+PiB0aGF0IHNpemUuIEkgY2FuIGFkZCB0aGlzIHRv
IHRoZSBwYXRjaCBpZiB5b3UgcmVhbGx5IHRoaW5rIGl0IGlzDQo+PiBuZWNlc3NhcnkuDQo+
IA0KPiBTaW5jZSBncmFudCB0YWJsZSBzaXplIGlzIG1lYXN1cmVkIGluIHBhZ2VzLCB5b3Un
ZCB0aGVuIGhhdmUgdG8NCj4gcmVmdXNlIHVzZSBvZiBtb3JlIHRoYW4ganVzdCB0aGF0IHNp
bmdsZSBncmVmLiBUaGlzIHdvdWxkIHN0aWxsIG5vdA0KPiBiZSBhbiBpbW1lZGlhdGUgcHJv
YmxlbSwgYnV0IGRlbW9uc3RyYXRlcyBhZ2FpbiB0aGF0IGl0J3MgdW5jbGVhcg0KPiB3aGVy
ZSB0byBkcmF3IHN1Y2ggYSBib3VuZGFyeSwgaWYgb25lIGlzIHRvIGJlIGFydGlmaWNpYWxs
eSBkcmF3bi4NCg0KSXQgc2hvdWxkIGJlIGFzIGhpZ2ggYXMgcG9zc2libGUuIEkgd291bGRu
J3QgbWluZCBqdXN0IHJlZnVzaW5nIHRoZQ0KbGFzdCBwb3NzaWJsZSBncmVmLCBidXQgSSBk
b24ndCB0aGluayB0aGlzIGlzIG5lY2Vzc2FyeS4NCg0KPj4gVEJILCBJIHRoaW5rIHN1Y2gg
Y29tcGxldGVseSB0aGVvcmV0aWNhbCBjb25jZXJucyBzaG91bGQgbm90IHN0YW5kDQo+PiBp
biB0aGUgd2F5IG9mIGFkZGl0aW9ucyB0byB0aGUgQUJJIG1ha2luZyBsaWZlIGVhc2llciBm
b3IgY29uc3VtZXJzLg0KPiANCj4gSW4gY2FzZSBpdCB3YXNuJ3QgY2xlYXIgLSBteSBjb25j
ZXJuIGlzbid0IHRoYXQgc2FjcmlmaWNpbmcgdGhpcyBvbmUNCj4gZW50cnkgbWF5IGNhdXNl
IGEgcHJvYmxlbSwgb3IgdGhhdCB3ZSdkIGV2ZXIgc2VlIGdyYW50IHRhYmxlcyBncm93DQo+
IHRoaXMgYmlnIChhbGJlaXQgZm9yIHRoZSBsYXR0ZXI6IHlvdSBuZXZlciByZWFsbHkga25v
dykuIEluc3RlYWQgbXkNCj4gY29uY2VybiBpcyB0aGF0IGl0IGlzIGNvbmNlcHR1YWxseSB3
cm9uZyBmb3IgdXMgdG8gKG5vdykgaW50cm9kdWNlDQo+IHN1Y2ggYSB2YWx1ZS4NCg0KSSBo
YXZlIHVuZGVyc3Rvb2QgdGhhdCB0aGlzIGlzIHlvdXIgY29uY2Vybi4NCg0KSSBjb250aW51
ZSB0byB0aGluayB0aGF0IHRoaXMgY29uY2VybiBpcyBvZiBwdXJlbHkgYWNhZGVtaWNhbCBu
YXR1cmUuDQoNCg0KSnVlcmdlbg0K
--------------q1lzEjwDYKv0yWnYKaAhRmvf
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------q1lzEjwDYKv0yWnYKaAhRmvf--

--------------nuwbFMD63OvCpq7mmzhltG0w--

--------------g9q8BnPBMZPaXM4LwKqQOnko
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmITtmYFAwAAAAAACgkQsN6d1ii/Ey9f
5ggAkvBbvzVrTn64mdNX1SQKv9LxgZ5L9Vaf7nbydd4Xm7iaFbnOMdpKWB3oap9Hoxivm24eISCz
dIjowomw98HM1xkn0IuqYmZ1GZsbR0pwUvQkGFBzenbBhPkLGfNgxw55b8GbWwbAEzov/Kmzn5ET
ieaEWDeBMbDwTvb1aIOmwTPjUPDoutA0aHjGYUOlb05MX4g8heXEvm6EY/7D/wMxmgrvYjGqfghY
bQFb/SXPTKu8ESp2sYrw/9Y5Dm0MK7JSGdDRM8hU3NjSl8q6l0VBDBCVWMDRh0d+Cwj1jQFpuer6
uCg4ba1iTn96PzByW65DnWHb0lfRdSOembPcLxNr7w==
=g+Fm
-----END PGP SIGNATURE-----

--------------g9q8BnPBMZPaXM4LwKqQOnko--


From xen-devel-bounces@lists.xenproject.org Mon Feb 21 15:59:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 21 Feb 2022 15:59:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276352.472489 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMB5Z-0001yE-TA; Mon, 21 Feb 2022 15:59:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276352.472489; Mon, 21 Feb 2022 15:59:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMB5Z-0001y7-Pg; Mon, 21 Feb 2022 15:59:01 +0000
Received: by outflank-mailman (input) for mailman id 276352;
 Mon, 21 Feb 2022 15:59:00 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nMB5Y-0001xz-9F
 for xen-devel@lists.xenproject.org; Mon, 21 Feb 2022 15:59:00 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nMB5X-0000IS-Vs; Mon, 21 Feb 2022 15:58:59 +0000
Received: from [54.239.6.189] (helo=[192.168.5.64])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nMB5X-000390-Pw; Mon, 21 Feb 2022 15:58:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=Cyh3S6FyANJ9AdFKJ0JpDQ1uhmOVwLLun35IdbpvCUo=; b=3JjzOk6dtHyf5/p+T1PFyRMbWy
	izhb5wgJBR4WEh0Y9HfmALdQRnKlIBqZNnGqEC9AqmMB4aWsJ8Ht7oxC4V0bccMiRHqJ91zfcUnq6
	kUG6nlXnEEW7ABImuyev4dH4lM9C7/W95AUUSFh/yjXHEFk64UmtKQgskb6JRqnR3pH8=;
Message-ID: <1531f49d-c74c-8a41-a917-cfe76bee8e7d@xen.org>
Date: Mon, 21 Feb 2022 15:58:57 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.1
Subject: Re: [PATCH] xen/arm: Rename psr_mode_is_32bit to regs_mode_is_32bit
To: Michal Orzel <michal.orzel@arm.com>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <20220221105931.12028-1-michal.orzel@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220221105931.12028-1-michal.orzel@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Michal,

On 21/02/2022 10:59, Michal Orzel wrote:
> Following a discussion [1] it seems like that renaming work has
> been forgotten. 

This is in my todo list of clean-up I need to do for Xen. But I haven't 
yet had a chance to look at it. Thank you for taking a look!

> Perform renaming of psr_mode_is_32bit to
> regs_mode_is_32bit as the function no longer takes psr parameter.

If we modify psr_mode_is_32bit(), then we should also modify 
psr_mode_is_user() because they have the same prototype and we should 
keep the naming consistent.

> 
> [1] https://marc.info/?l=xen-devel&m=156457538423787&w=2

NIT: The first sentence and this link adds value for the review on the 
mailing list (we know where the request came from) but doesn't add any 
after the commit message (there are no extra information in them).

So I would move this information after ---. This will get dropped on commit.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Feb 21 17:06:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 21 Feb 2022 17:06:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276369.472504 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMC8W-0000zb-4I; Mon, 21 Feb 2022 17:06:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276369.472504; Mon, 21 Feb 2022 17:06:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMC8W-0000zU-1B; Mon, 21 Feb 2022 17:06:08 +0000
Received: by outflank-mailman (input) for mailman id 276369;
 Mon, 21 Feb 2022 17:06:06 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Nr+1=TE=xilinx.com=ayankuma@srs-se1.protection.inumbo.net>)
 id 1nMC8U-0000xl-30
 for xen-devel@lists.xenproject.org; Mon, 21 Feb 2022 17:06:06 +0000
Received: from NAM02-DM3-obe.outbound.protection.outlook.com
 (mail-dm3nam07on20614.outbound.protection.outlook.com
 [2a01:111:f400:7e83::614])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8a56e9aa-9338-11ec-8eb8-a37418f5ba1a;
 Mon, 21 Feb 2022 18:06:00 +0100 (CET)
Received: from BN9PR03CA0198.namprd03.prod.outlook.com (2603:10b6:408:f9::23)
 by SA2PR02MB7579.namprd02.prod.outlook.com (2603:10b6:806:144::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.16; Mon, 21 Feb
 2022 17:05:57 +0000
Received: from BN1NAM02FT043.eop-nam02.prod.protection.outlook.com
 (2603:10b6:408:f9:cafe::f8) by BN9PR03CA0198.outlook.office365.com
 (2603:10b6:408:f9::23) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.15 via Frontend
 Transport; Mon, 21 Feb 2022 17:05:57 +0000
Received: from xir-pvapexch01.xlnx.xilinx.com (149.199.80.198) by
 BN1NAM02FT043.mail.protection.outlook.com (10.13.2.154) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.4995.19 via Frontend Transport; Mon, 21 Feb 2022 17:05:56 +0000
Received: from xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) by
 xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2176.14; Mon, 21 Feb 2022 17:05:55 +0000
Received: from smtp.xilinx.com (172.21.105.197) by
 xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server id
 15.1.2176.14 via Frontend Transport; Mon, 21 Feb 2022 17:05:55 +0000
Received: from [10.71.117.205] (port=12515)
 by smtp.xilinx.com with esmtp (Exim 4.90)
 (envelope-from <ayan.kumar.halder@xilinx.com>)
 id 1nMC8I-0002CM-Qc; Mon, 21 Feb 2022 17:05:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8a56e9aa-9338-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=VM5wurANEL7HFq+6MmfMEZ1WQJRkMFnuB8lOJwwI9Qs2/rrp8m3ocQ5HZR6ZDmzPJ6mhtKW5eG5nXzJNFyIlIwLSV//Ql45wuSGNc+n3xX8X9XIQeE3AdK7askx8xMEICY0MKnBxcri8Hd6KqdJuLc2CshiPf59Ut1l1VTmfqfMUzxsMbj5dTVmMX7mY0tuT+rwUZWt+I6iuB3Mqif9GA7yhK8YI3UYnzyY8kFDxsHM+fMpwxLBqn/Lu+DRrQ0XDo2cwrcKbUBS10p1jx3nxqCQssl7DVxDqLZB1I3N9xwh2sY5p7UDFhRTh+2rkR2GcLvxkAoKcbsjFjQ9MEX9Rfw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=imW2pRAvC1J980x5pxuH6SKoABMyPwAvYEvZdAryobQ=;
 b=l65fgXBHpOL3TLZxLCGq85g96pEV19NAsLBjpWg+YpnwRMacCCRQo+1gQGOUJIdIxbigc/T9DYlWfpQCEB4q0ROCrY/XS1+dANbDORv660L/LkDlVGv5Nb9LmECBf362/R0iN3B3pQ5g5m9Vwa8ekGg33p3czauR6HhB6bTGPZJGgf6p473BqVAeN9f5LLEoMzRxj9jY6muOIy/nrOdeLtPv4U3bQa3H3it2wrXnb9JlkNK6ckFqaIqtirlNHG2X2EEfXP6HJYhC9G3POFFOCOvczqZCTPUGTtm6s+lXzCLLTozwnqpF2xv3DK6bzjLH4ULFe7/kdt9mUTo0AacUDg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 149.199.80.198) smtp.rcpttodomain=xen.org smtp.mailfrom=xilinx.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=imW2pRAvC1J980x5pxuH6SKoABMyPwAvYEvZdAryobQ=;
 b=UyJQSyScOQo1HR1ezhk6C2PVOBUr3Bt39Ih5O6R9KA0RhYacTX6S83jC2dZsqAhcrMUw4Y/aqJgV/PkliH74yhYCdpvJGUu6F0/cN1H8NWPo05UQTg0ZO6tP5qmPcHa5CzbRypBXVjUCCV/n6F1hNAZ54LtIaTYKcunTuKZc79I=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198)
 smtp.mailfrom=xilinx.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=xilinx.com;
Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates
 149.199.80.198 as permitted sender) receiver=protection.outlook.com;
 client-ip=149.199.80.198; helo=xir-pvapexch01.xlnx.xilinx.com;
Message-ID: <10cf253b-fc58-1afc-66ec-33ac3008bb0f@xilinx.com>
Date: Mon, 21 Feb 2022 17:05:54 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.0
Subject: Re: [XEN v8 2/2] xen/arm64: io: Support instructions (for which ISS
 is not valid) on emulated MMIO region using MMIO/ioreq handler
To: Julien Grall <julien@xen.org>, Ayan Kumar Halder
	<ayan.kumar.halder@xilinx.com>, <xen-devel@lists.xenproject.org>
CC: <sstabellini@kernel.org>, <stefanos@xilinx.com>,
	<Volodymyr_Babchuk@epam.com>, <bertrand.marquis@arm.com>
References: <20220212233433.46018-1-ayankuma@xilinx.com>
 <20220212233433.46018-3-ayankuma@xilinx.com>
 <1599e2f3-0a34-020a-dd42-5ba87dad555d@xen.org>
From: Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>
In-Reply-To: <1599e2f3-0a34-020a-dd42-5ba87dad555d@xen.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 955af48d-d35c-49d3-b544-08d9f55c6d53
X-MS-TrafficTypeDiagnostic: SA2PR02MB7579:EE_
X-Microsoft-Antispam-PRVS:
	<SA2PR02MB757910F64D7084F42187E32BB23A9@SA2PR02MB7579.namprd02.prod.outlook.com>
X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	MCsOXBJ49SUCTYEOlcgYqh4pdN0vCsRMQyhChYB8uFe9SDiY5armwwuaZO6mFc4dQv+aG3uSu12j4UpxqocnxXOU6ueKjdZAiYCtz8wYdaL38euxdp8PPMpKN1Lmy/wrWXiq6By+Ti6qcbB7LOdGTctAMK2n0pnrNk+L5PiquSBxMjGvkJlSXWn70bgvyjtnIPQ89mr9JqUb8+qzazVrPgxdCn82pGj9Yn+1PIn2nbMd1wQ0xP3onKac1zK7xzCxcsuK8ON8gCfcUj6Z+je2QXiVNuQGzlwQEPOFgvG1GcJwwYUqBccKQcS1476vF9byx+IAzGo98CPhKWcGipXCiX5fEnBeWJln0mRksJ83Vu5zOF6hFkaOs8uzfjO7mvzp/Bd/7M/zd0Y0E9LxBy6P/yE3jf05XpbKq/UvJCcpAh6sG4lu099JbQWN3QiqvpoStJzGSSNqNqyePk2jdBmjRDgoIRandF0SwBtp0jWv8K++sd8ZYnXN+Zh53lCq1EUapiZjcFLNnwxgxDerBL5JiZkdjYXu+WDe2GJ5UAFPnWdDw0+S4mGnGye5iI2599/Kf2C2eZ1m0HJxsTcaM/xfIU7mh44QMpOSf2WqIKVDXfuJ5UoBIQo4QCB8l9E8EfkhoLdI6dth5D44tD1hgWKXPqSQG5M3vrmZDHhIuNz2guJlwqeREN9DOCljLSoOqS4Mwqh6uQuG8TmXm0mHed0d7upTBFwVdIsML7Emvgwp6tpizRppqMC1XnAGmdMvxOGa+XUnwEJkVixZFINtIwAkKw==
X-Forefront-Antispam-Report:
	CIP:149.199.80.198;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:xir-pvapexch01.xlnx.xilinx.com;PTR:unknown-80-198.xilinx.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(53546011)(70206006)(40460700003)(31686004)(30864003)(70586007)(9786002)(8936002)(36756003)(83380400001)(336012)(186003)(4326008)(426003)(2616005)(5660300002)(8676002)(26005)(82310400004)(31696002)(36860700001)(110136005)(316002)(54906003)(47076005)(508600001)(356005)(2906002)(7636003)(50156003)(43740500002)(473944003);DIR:OUT;SFP:1101;
X-OriginatorOrg: xilinx.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2022 17:05:56.7915
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 955af48d-d35c-49d3-b544-08d9f55c6d53
X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.80.198];Helo=[xir-pvapexch01.xlnx.xilinx.com]
X-MS-Exchange-CrossTenant-AuthSource:
	BN1NAM02FT043.eop-nam02.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR02MB7579

Hi Julien,

Apprecciate your continuous help on this. Most of your comments make 
sense, but I need few clarifications as below :-

On 13/02/2022 12:19, Julien Grall wrote:
> Hi,
>
> On 12/02/2022 23:34, Ayan Kumar Halder wrote:
>>
>>   xen/arch/arm/arm32/traps.c        |  7 +++
>>   xen/arch/arm/arm64/traps.c        | 47 +++++++++++++++
>>   xen/arch/arm/decode.c             |  1 +
>>   xen/arch/arm/include/asm/domain.h |  4 ++
>>   xen/arch/arm/include/asm/mmio.h   | 15 ++++-
>>   xen/arch/arm/include/asm/traps.h  |  2 +
>>   xen/arch/arm/io.c                 | 98 ++++++++++++++++++++-----------
>>   xen/arch/arm/ioreq.c              |  7 ++-
>>   xen/arch/arm/traps.c              | 80 +++++++++++++++++++++----
>>   xen/arch/x86/include/asm/ioreq.h  |  3 +
>
> This change technically needs an ack from the x86 maintainers. And...
>
>>   xen/include/xen/sched.h           |  2 +
>
> this one for anyone from THE REST (Stefano and I are part of it). 
> Please use scripts/add_maintainers.pl to automatically add the 
> relevant maintainers in CC.
>
>>   11 files changed, 217 insertions(+), 49 deletions(-)
>>
>> diff --git a/xen/arch/arm/arm32/traps.c b/xen/arch/arm/arm32/traps.c
>> index 9c9790a6d1..70c6238196 100644
>> --- a/xen/arch/arm/arm32/traps.c
>> +++ b/xen/arch/arm/arm32/traps.c
>> @@ -18,9 +18,11 @@
>>     #include <xen/lib.h>
>>   #include <xen/kernel.h>
>> +#include <xen/sched.h>
>>     #include <public/xen.h>
>>   +#include <asm/mmio.h>
>>   #include <asm/processor.h>
>>   #include <asm/traps.h>
>>   @@ -82,6 +84,11 @@ void do_trap_data_abort(struct cpu_user_regs *regs)
>>           do_unexpected_trap("Data Abort", regs);
>>   }
>>   +void post_increment_register(const struct instr_details *instr)
>> +{
>> +    domain_crash(current->domain);
>
>
> Please add a comment explaning why this is resulting to a domain 
> crash. AFAICT, this is because this should not be reachable (yet) for 
> 32-bit.
>
>
>> +}
>> +
>>   /*
>>    * Local variables:
>>    * mode: C
>> diff --git a/xen/arch/arm/arm64/traps.c b/xen/arch/arm/arm64/traps.c
>> index 9113a15c7a..a6766689b3 100644
>> --- a/xen/arch/arm/arm64/traps.c
>> +++ b/xen/arch/arm/arm64/traps.c
>> @@ -23,6 +23,7 @@
>>   #include <asm/processor.h>
>>     #include <public/xen.h>
>> +#include <xen/sched.h>
>
> The headers should ordered so <xen/*.h> are first, then <asm/*.h>, 
> then <public/*.h>. They should then be ordered alphabetically within 
> each of the category.
>
> So, this new header should be included right after <xen/lib.h>
>
> [...]
>
>> diff --git a/xen/arch/arm/include/asm/mmio.h 
>> b/xen/arch/arm/include/asm/mmio.h
>> index 3354d9c635..745130b7fe 100644
>> --- a/xen/arch/arm/include/asm/mmio.h
>> +++ b/xen/arch/arm/include/asm/mmio.h
>> @@ -26,12 +26,22 @@
>>     #define MAX_IO_HANDLER  16
>>   +enum instr_decode_state
>> +{
>> +    INSTR_ERROR,                    /* Error encountered while 
>> decoding instr */
>> +    INSTR_VALID,                    /* ISS is valid, so no need to 
>> decode */
>> +    INSTR_LDR_STR_POSTINDEXING,     /* Instruction is decoded 
>> successfully.
>> +                                       It is ldr/str post indexing */
>
> Coding style: multiple-line comments for Xen should be:
>
> /*
>  * ...
>  * ...
>  */
>
> In this case, I would simply move the comment on top.
>
> [...]
>
>> diff --git a/xen/arch/arm/io.c b/xen/arch/arm/io.c
>> index a289d393f9..203466b869 100644
>> --- a/xen/arch/arm/io.c
>> +++ b/xen/arch/arm/io.c
>> @@ -95,57 +95,87 @@ static const struct mmio_handler 
>> *find_mmio_handler(struct domain *d,
>>       return handler;
>>   }
>>   +void try_decode_instruction(const struct cpu_user_regs *regs,
>> +                            mmio_info_t *info)
>> +{
>> +    int rc;
>> +
>> +    /*
>> +     * Erratum 766422: Thumb store translation fault to Hypervisor may
>> +     * not have correct HSR Rt value.
>> +     */
>> +    if ( check_workaround_766422() && (regs->cpsr & PSR_THUMB) &&
>> +         info->dabt.write )
>> +    {
>> +        rc = decode_instruction(regs, info);
>> +        if ( rc )
>> +        {
>> +            gprintk(XENLOG_DEBUG, "Unable to decode instruction\n");
>> +            info->dabt_instr.state = INSTR_ERROR;
>> +            return;
>> +        }
>> +    }
>
> At the moment, the errata would only be handled when the ISS is valid. 
> Now, you are moving it before we know if it is valid. Can you explain 
> why?
>
> [...]
>
>>   enum io_state try_handle_mmio(struct cpu_user_regs *regs,
>> -                              const union hsr hsr,
>> -                              paddr_t gpa)
>> +                              mmio_info_t *info)
>>   {
>>       struct vcpu *v = current;
>>       const struct mmio_handler *handler = NULL;
>> -    const struct hsr_dabt dabt = hsr.dabt;
>> -    mmio_info_t info = {
>> -        .gpa = gpa,
>> -        .dabt = dabt
>> -    };
>> +    int rc;
>>   -    ASSERT(hsr.ec == HSR_EC_DATA_ABORT_LOWER_EL);
>> +    ASSERT(info->dabt.ec == HSR_EC_DATA_ABORT_LOWER_EL);
>>   -    handler = find_mmio_handler(v->domain, info.gpa);
>> +    handler = find_mmio_handler(v->domain, info->gpa);
>>       if ( !handler )
>>       {
>> -        int rc;
>> -
>> -        rc = try_fwd_ioserv(regs, v, &info);
>> +        rc = try_fwd_ioserv(regs, v, info);
>>           if ( rc == IO_HANDLED )
>>               return handle_ioserv(regs, v);
>>             return rc;
>>       }
>>   -    /* All the instructions used on emulated MMIO region should be 
>> valid */
>> -    if ( !dabt.valid )
>> -        return IO_ABORT;
>> -
>
> AFAIU, the assumption is now try_handle_mmio() and try_fwd_ioserv() 
> will always be called when dabt.valid == 1. I think it would still be 
> good to check that assumption.
>
> So I would move the check at the beginning of try_handle_mmio() and 
> add an ASSERT_UNREACHABLE in the if(). Something like:
>
> if ( !dabt.valid )
> {
>     ASSERT_UNREACHABLE();
>     return IO_ABORT;
> }
>
>>       /*
>> -     * Erratum 766422: Thumb store translation fault to Hypervisor may
>> -     * not have correct HSR Rt value.
>> +     * At this point, we know that the instruction is either valid 
>> or has been
>> +     * decoded successfully. Thus, Xen should be allowed to execute the
>> +     * instruction on the emulated MMIO region.
>>        */
>> -    if ( check_workaround_766422() && (regs->cpsr & PSR_THUMB) &&
>> -         dabt.write )
>> -    {
>> -        int rc;
>> -
>> -        rc = decode_instruction(regs, &info);
>> -        if ( rc )
>> -        {
>> -            gprintk(XENLOG_DEBUG, "Unable to decode instruction\n");
>> -            return IO_ABORT;
>> -        }
>> -    }
>> -
>> -    if ( info.dabt.write )
>> -        return handle_write(handler, v, &info);
>> +    if ( info->dabt.write )
>> +        rc = handle_write(handler, v, info);
>>       else
>> -        return handle_read(handler, v, &info);
>> +        rc = handle_read(handler, v, info);
>> +
>> +    return rc;
>
> It looks like there are some left-over of the previous approach. It is 
> fine to return directly from each branch.
>
>
>>   }
>>     void register_mmio_handler(struct domain *d,
>> diff --git a/xen/arch/arm/ioreq.c b/xen/arch/arm/ioreq.c
>> index 308650b400..3c0a935ccf 100644
>> --- a/xen/arch/arm/ioreq.c
>> +++ b/xen/arch/arm/ioreq.c
>> @@ -47,6 +47,7 @@ enum io_state try_fwd_ioserv(struct cpu_user_regs 
>> *regs,
>>                                struct vcpu *v, mmio_info_t *info)
>>   {
>>       struct vcpu_io *vio = &v->io;
>> +    struct dabt_instr instr = info->dabt_instr;
>>       ioreq_t p = {
>>           .type = IOREQ_TYPE_COPY,
>>           .addr = info->gpa,
>> @@ -76,10 +77,8 @@ enum io_state try_fwd_ioserv(struct cpu_user_regs 
>> *regs,
>>       if ( !s )
>>           return IO_UNHANDLED;
>>   -    if ( !info->dabt.valid )
>> -        return IO_ABORT;
>> -
>
> For this one, I would switch to ASSERT(dabt.valid);
I see that try_fwd_ioserv() is invoked from try_handle_mmio() only. 
Thus, if I follow your suggestion of adding a check for dabt.valid at 
the beginning of try_handle_mmio(), then this ASSERT() is not required. 
Let me know if you agree ?
>
>>       vio->req = p;
>> +    vio->info.dabt_instr = instr;
>>         rc = ioreq_send(s, &p, 0);
>>       if ( rc != IO_RETRY || v->domain->is_shutting_down )
>> @@ -95,6 +94,7 @@ enum io_state try_fwd_ioserv(struct cpu_user_regs 
>> *regs,
>>   bool arch_ioreq_complete_mmio(void)
>>   {
>>       struct vcpu *v = current;
>> +    struct instr_details dabt_instr = v->io.info.dabt_instr;
>>       struct cpu_user_regs *regs = guest_cpu_user_regs();
>>       const union hsr hsr = { .bits = regs->hsr };
>>   @@ -106,6 +106,7 @@ bool arch_ioreq_complete_mmio(void)
>>         if ( handle_ioserv(regs, v) == IO_HANDLED )
>>       {
>> +        post_increment_register(&dabt_instr);
>>           advance_pc(regs, hsr);
>>           return true;
>>       }
>> diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c
>> index 9339d12f58..455e51cdbe 100644
>> --- a/xen/arch/arm/traps.c
>> +++ b/xen/arch/arm/traps.c
>> @@ -1893,6 +1893,21 @@ static bool try_map_mmio(gfn_t gfn)
>>       return !map_regions_p2mt(d, gfn, 1, mfn, p2m_mmio_direct_c);
>>   }
>>   +static inline bool check_p2m(bool is_data, paddr_t gpa)
>> +{
>> +    /*
>> +     * First check if the translation fault can be resolved by the 
>> P2M subsystem.
>> +     * If that's the case nothing else to do.
>> +     */
>> +    if ( 
>> p2m_resolve_translation_fault(current->domain,gaddr_to_gfn(gpa)) )
>
> Coding style: missing space before and after the comma.
>
>> +        return true;
>> +
>> +    if ( is_data && try_map_mmio(gaddr_to_gfn(gpa)) )
>> +        return true;
>> +
>> +    return false;
>> +}
>> +
>>   static void do_trap_stage2_abort_guest(struct cpu_user_regs *regs,
>>                                          const union hsr hsr)
>>   {
>> @@ -1906,6 +1921,7 @@ static void do_trap_stage2_abort_guest(struct 
>> cpu_user_regs *regs,
>>       paddr_t gpa;
>>       uint8_t fsc = xabt.fsc & ~FSC_LL_MASK;
>>       bool is_data = (hsr.ec == HSR_EC_DATA_ABORT_LOWER_EL);
>> +    mmio_info_t info;
>>         /*
>>        * If this bit has been set, it means that this stage-2 abort 
>> is caused
>> @@ -1959,6 +1975,25 @@ static void do_trap_stage2_abort_guest(struct 
>> cpu_user_regs *regs,
>>           return;
>>       }
>>       case FSC_FLT_TRANS:
>> +    {
>> +        info.gpa = gpa;
>> +        info.dabt = hsr.dabt;
>> +
>> +        /* Check that the ISS is invalid and it is not data abort. */
>
> This comment looks a bit pointless. You are writing literally what the 
> check is doing. But you don't really explain why. I think you want to 
> move some of the commint with the if here.
>
> However,...
>
>> +        if ( !hsr.dabt.valid && !is_data )
>
> ... this code can be reached by Instruction Abort and Data Abort. So 
> you can't use hsr.dabt. Instead, you should use xabt (or check is_data 
> first).
>
> If you use xabt, you will notice that the 'valid' bit is not existent
> because the instruction syndrome only exists for data abort.
>
> But then, I don't understand why this is only restricted to 
> instruction abort. As I wrote in the previous versions and on IRC, 
> there are valid use cases to trap a data abort with invalid syndrome. 
> Below...
>
>
>> +        {
>> +
>> +            /*
>> +             * Assumption :- Most of the times when we get a 
>> translation fault
>> +             * and the ISS is invalid, the underlying cause is that 
>> the page
>> +             * tables have not been set up correctly.
>> +             */
>> +            if ( check_p2m(is_data, gpa) )
>> +                return;
>> +            else
>> +                goto inject_abt;
>> +        }
>> +
>>           /*
>>            * Attempt first to emulate the MMIO as the data abort will
>>            * likely happen in an emulated region.
>> @@ -1967,13 +2002,45 @@ static void do_trap_stage2_abort_guest(struct 
>> cpu_user_regs *regs,
>>            */
>>           if ( is_data )
>>           {
>> -            enum io_state state = try_handle_mmio(regs, hsr, gpa);
>> +            enum io_state state;
>> +
>> +            try_decode_instruction(regs, &info);
>> +
>> +            /*
>> +             * If Xen could not decode the instruction for any 
>> reason, then it
>> +             * should ask the caller to abort the guest.
>> +             */
>> +            if ( info.dabt_instr.state == INSTR_ERROR )
>> +                goto inject_abt;
>
> ... this will inject a data abort to the guest when we can't decode. 
> This is not what we want. We should check whether this is a P2M 
> translation fault or we need to map an MMIO region.
>
> In pseudo-code, this would look like:
>
> if ( !is_data || hsr.dabt.valid )

I think you mean if ( !is_data || !hsr.dabt.valid )

The reason being if there is an instruction abort or a data abort (with 
ISV == 0), then it should try to configure the page tables.

> {
>     if ( check_p2m() )
>       return;
>
>
>     if ( !is_data )
>        goto inject_dabt;
>
>     decode_instruction();
>     if ( !dabt.invalid )
>       goto inject_dabt;
> }
>
> try_handle_mmio();
>
> if ( instruction was not decoded )
>   check_p2m();

If the instruction was not decoded, then there is no need to configure 
the page tables again. We have already done this before. So, it should 
be safe to abort the guest ?


So my understanding is as follows :-

         /* Check that it is instruction abort or ISS is invalid. */
         if ( !is_data || !info.dabt.valid )
         {
             /*
              * If the instruction was trapped due to access to stage 1 
translation
              * then Xen should try to resolve the page table entry for 
the stage 1
              * translation table with the assumption that the page 
tables are
              * present in the non MMIO region. If it is successful, 
then it should
              * ask the guest to retry the instruction.
              */
             if ( is_data && info.dabt.s1ptw )
             {
                 info.dabt_instr.state = INSTR_RETRY;
                 /* The translation tables are assumed to be in non MMIO 
region. */
                 is_data = false;
             }

             /*
              * Assumption :- Most of the times when we get a 
translation fault
              * and the ISS is invalid, the underlying cause is that the 
page
              * tables have not been set up correctly.
              */
             if ( check_p2m(is_data, gpa) )
                 return;

             /*
              * If the instruction abort or the data abort due to access 
to stage 1
              * translation tables could not be resolved by setting the 
appropriate
              * bits in the translation table, then Xen should abort the 
guest.
              */
             if ( !is_data || (info.dabt_instr.state == INSTR_RETRY) )
                 goto inject_abt;

             try_decode_instruction(regs, &info);

             /* Instruction could not be decoded, then abort the guest */

             if ( info.dabt_instr.state == INSTR_ERROR)
                 goto inject_abt;
         }

         state = try_handle_mmio(regs, &info);

         switch ( state )
         {
             case IO_ABORT:
                 goto inject_abt;
             case IO_HANDLED:
                 /*
                  * If the instruction was decoded and has executed 
successfully
                  * on the MMIO region, then Xen should execute the next 
part of
                  * the instruction. (for eg increment the rn if it is a
                  * post-indexing instruction.
                  */
                 post_increment_register(&info.dabt_instr);
                 advance_pc(regs, hsr);
                 return;
             case IO_RETRY:
                 /* finish later */
                 return;
             case IO_UNHANDLED:
                 /* IO unhandled, try another way to handle it. */
                 break;
         }

         if ( check_p2m(is_data, gpa) )
             return;


Please letme know if I am misunderstanding something.

- Ayan

>
> Cheers,
>


From xen-devel-bounces@lists.xenproject.org Mon Feb 21 17:33:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 21 Feb 2022 17:33:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276376.472515 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMCYh-0004Ar-97; Mon, 21 Feb 2022 17:33:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276376.472515; Mon, 21 Feb 2022 17:33:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMCYh-0004Ak-65; Mon, 21 Feb 2022 17:33:11 +0000
Received: by outflank-mailman (input) for mailman id 276376;
 Mon, 21 Feb 2022 17:33:09 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nMCYf-0004Aa-NL; Mon, 21 Feb 2022 17:33:09 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nMCYf-0002j2-MF; Mon, 21 Feb 2022 17:33:09 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nMCYf-0000wL-9J; Mon, 21 Feb 2022 17:33:09 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nMCYf-0003I0-8q; Mon, 21 Feb 2022 17:33:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=/QR9GFYOBcVJZp5owsMVDMJvKoMyyYsm5pWZTjhAFNQ=; b=H69yY7KQj9DGGwC1FD96AwDvKH
	42JA5bJQBA6GmcbYAmaRe5KAW1Y98SUdwyEEgFc7EOHEbETGNIx97CKc0ELzsr5ojjHIaY61vohy9
	DEeHKMVSVn8GqOd60466Jk6/bmxu803p1+LOusldbZG5ZA/Iz3+4h9wpQVNc71x4Ca8c=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168185-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 168185: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=b24306f15daa2ff8510b06702114724b33895d3c
X-Osstest-Versions-That:
    ovmf=8a576733162bb72afb4d1eb3012b0aef8d265018
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 21 Feb 2022 17:33:09 +0000

flight 168185 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168185/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 b24306f15daa2ff8510b06702114724b33895d3c
baseline version:
 ovmf                 8a576733162bb72afb4d1eb3012b0aef8d265018

Last test of basis   168131  2022-02-16 12:13:29 Z    5 days
Testing same since   168185  2022-02-21 15:43:05 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Heng Luo <heng.luo@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   8a57673316..b24306f15d  b24306f15daa2ff8510b06702114724b33895d3c -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Mon Feb 21 17:57:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 21 Feb 2022 17:57:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276389.472525 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMCw6-0006iG-Qj; Mon, 21 Feb 2022 17:57:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276389.472525; Mon, 21 Feb 2022 17:57:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMCw6-0006i9-Nm; Mon, 21 Feb 2022 17:57:22 +0000
Received: by outflank-mailman (input) for mailman id 276389;
 Mon, 21 Feb 2022 17:57:22 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nMCw6-0006i3-2e
 for xen-devel@lists.xenproject.org; Mon, 21 Feb 2022 17:57:22 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nMCw5-0003CZ-PV; Mon, 21 Feb 2022 17:57:21 +0000
Received: from [54.239.6.189] (helo=[192.168.5.64])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nMCw5-0007tb-J0; Mon, 21 Feb 2022 17:57:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=eB18/8J0cqV/Svq+HKVvvHntT2R2n2FcQK/gpo/qTIs=; b=AawMLZXwnOhGYhdGUddf9+mZCS
	pQGvooMQbJF005zDxGX5wMdkM+MuI24LZzV81nCBfxde3cnA1qDNA8kHxjjGYTgbnBt33ft/fTV5L
	w+E7fV04OeXuX1twxdRqSQZlHBQzJtgkAfN0uffcLK0wYgFtjNF+X87Q3RIJZZ1q3yMY=;
Message-ID: <576cf522-f002-afac-36b6-b31f87724dca@xen.org>
Date: Mon, 21 Feb 2022 17:57:19 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.1
Subject: Re: [XEN v8 2/2] xen/arm64: io: Support instructions (for which ISS
 is not valid) on emulated MMIO region using MMIO/ioreq handler
To: Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>,
 xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com,
 bertrand.marquis@arm.com
References: <20220212233433.46018-1-ayankuma@xilinx.com>
 <20220212233433.46018-3-ayankuma@xilinx.com>
 <1599e2f3-0a34-020a-dd42-5ba87dad555d@xen.org>
 <10cf253b-fc58-1afc-66ec-33ac3008bb0f@xilinx.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <10cf253b-fc58-1afc-66ec-33ac3008bb0f@xilinx.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit



On 21/02/2022 17:05, Ayan Kumar Halder wrote:
> Hi Julien,

Hi,

> On 13/02/2022 12:19, Julien Grall wrote:
>>>   }
>>>     void register_mmio_handler(struct domain *d,
>>> diff --git a/xen/arch/arm/ioreq.c b/xen/arch/arm/ioreq.c
>>> index 308650b400..3c0a935ccf 100644
>>> --- a/xen/arch/arm/ioreq.c
>>> +++ b/xen/arch/arm/ioreq.c
>>> @@ -47,6 +47,7 @@ enum io_state try_fwd_ioserv(struct cpu_user_regs 
>>> *regs,
>>>                                struct vcpu *v, mmio_info_t *info)
>>>   {
>>>       struct vcpu_io *vio = &v->io;
>>> +    struct dabt_instr instr = info->dabt_instr;
>>>       ioreq_t p = {
>>>           .type = IOREQ_TYPE_COPY,
>>>           .addr = info->gpa,
>>> @@ -76,10 +77,8 @@ enum io_state try_fwd_ioserv(struct cpu_user_regs 
>>> *regs,
>>>       if ( !s )
>>>           return IO_UNHANDLED;
>>>   -    if ( !info->dabt.valid )
>>> -        return IO_ABORT;
>>> -
>>
>> For this one, I would switch to ASSERT(dabt.valid);
> I see that try_fwd_ioserv() is invoked from try_handle_mmio() only. 
> Thus, if I follow your suggestion of adding a check for dabt.valid at 
> the beginning of try_handle_mmio(), then this ASSERT() is not required.

I agree that try_handle_mmio() is the only caller today. But we don't 
know how this is going to be used tomorrow.

The goal of this ASSERT() is to catch those new users that would call it 
wrongly.

[...]

>> ... this will inject a data abort to the guest when we can't decode. 
>> This is not what we want. We should check whether this is a P2M 
>> translation fault or we need to map an MMIO region.
>>
>> In pseudo-code, this would look like:
>>
>> if ( !is_data || hsr.dabt.valid )
> 
> I think you mean if ( !is_data || !hsr.dabt.valid )

You are right.

> 
> The reason being if there is an instruction abort or a data abort (with 
> ISV == 0), then it should try to configure the page tables.
> 
>> {
>>     if ( check_p2m() )
>>       return;
>>
>>
>>     if ( !is_data )
>>        goto inject_dabt;
>>
>>     decode_instruction();
>>     if ( !dabt.invalid )
>>       goto inject_dabt;
>> }
>>
>> try_handle_mmio();
>>
>> if ( instruction was not decoded )
>>   check_p2m();
> 
> If the instruction was not decoded, then there is no need to configure 
> the page tables again. We have already done this before.

Hmmmm... I think there are confusing about which sort of decoding I was 
referring to. In this case, I mean if we didn't decode the instruction 
manully, then it is not necessary to call check_p2m().

Do you agree with that?

> So my understanding is as follows :-
> 
>          /* Check that it is instruction abort or ISS is invalid. */

I have had a remark on this line before. Please have a look and address it.

>          if ( !is_data || !info.dabt.valid )
>          {
>              /*
>               * If the instruction was trapped due to access to stage 1 
> translation
>               * then Xen should try to resolve the page table entry for 
> the stage 1
>               * translation table with the assumption that the page 
> tables are
>               * present in the non MMIO region. If it is successful, 
> then it should
>               * ask the guest to retry the instruction.
>               */

I agree that we want to skip the MMIO mapping when s1ptw == 1. However, 
I am not sure this belongs to this patch because this is technically 
already a bug.

>              if ( is_data && info.dabt.s1ptw )
>              {
>                  info.dabt_instr.state = INSTR_RETRY;
>                  /* The translation tables are assumed to be in non MMIO 
> region. */
>                  is_data = false;

is_data is also used to decide which sort of abort we want to send to 
the guest (see after inject_dabt). So I don't think we could force set 
is_data here.

Instead, I would define a new local variable (maybe mmio_access_allowed) 
that will be set for instruction abort or when s1ptw is 1.

>              }
> 
>              /*
>               * Assumption :- Most of the times when we get a 
> translation fault
>               * and the ISS is invalid, the underlying cause is that the 
> page
>               * tables have not been set up correctly.
>               */

I think this comment make more sense on top of "if !is_data || 
!info.dabt.valid".

>              if ( check_p2m(is_data, gpa) )
>                  return;
> 
>              /*
>               * If the instruction abort or the data abort due to access 
> to stage 1
>               * translation tables could not be resolved by setting the 
> appropriate
>               * bits in the translation table, then Xen should abort the 
> guest.

IHMO, "abort the guest" means we are going to crash the guest. However, 
this not the case here. We are telling the guest that we couldn't handle 
the data/instruction request. It is up to the guest to decide whether it 
should panic or handle gracefully the error.

We should also avoid the term guest because it usually only refers to 
any domain but dom0.

Therefore, I would reword it to something like "Xen will forward the 
data/instruction abort to the domain".

>               */
>              if ( !is_data || (info.dabt_instr.state == INSTR_RETRY) )

The second part looks unnecessary.

>                  goto inject_abt;
> 
>              try_decode_instruction(regs, &info);
> 
>              /* Instruction could not be decoded, then abort the guest */
> 
>              if ( info.dabt_instr.state == INSTR_ERROR)
>                  goto inject_abt;
>          }
> 
>          state = try_handle_mmio(regs, &info);
> 
>          switch ( state )
>          {
>              case IO_ABORT:
>                  goto inject_abt;
>              case IO_HANDLED:
>                  /*
>                   * If the instruction was decoded and has executed 
> successfully
>                   * on the MMIO region, then Xen should execute the next 
> part of
>                   * the instruction. (for eg increment the rn if it is a
>                   * post-indexing instruction.
>                   */
>                  post_increment_register(&info.dabt_instr);
>                  advance_pc(regs, hsr);
>                  return;
>              case IO_RETRY:
>                  /* finish later */
>                  return;
>              case IO_UNHANDLED:
>                  /* IO unhandled, try another way to handle it. */
>                  break;
>          }
> 
>          if ( check_p2m(is_data, gpa) )

It is unnecessary to call check_p2M() if we manually decoded the 
instruction (see above why).

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Feb 21 18:04:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 21 Feb 2022 18:04:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276396.472537 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMD2q-0008CJ-Fb; Mon, 21 Feb 2022 18:04:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276396.472537; Mon, 21 Feb 2022 18:04:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMD2q-0008CC-Ch; Mon, 21 Feb 2022 18:04:20 +0000
Received: by outflank-mailman (input) for mailman id 276396;
 Mon, 21 Feb 2022 18:04:18 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=fvXl=TE=citrix.com=prvs=044a77a3b=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nMD2o-0008C6-HU
 for xen-devel@lists.xenproject.org; Mon, 21 Feb 2022 18:04:18 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id adf9a819-9340-11ec-8eb8-a37418f5ba1a;
 Mon, 21 Feb 2022 19:04:16 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: adf9a819-9340-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645466656;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=YlOjXF4k7rFwUbvZj0TZsWgDLG6n+/ToUDcdMAAvYXQ=;
  b=U5rBPfvYxzTI0Sq6p+Dq7s9Q0VLT+lG9dJIDeI1rIbicLHmbyQ9C4bhh
   Y83d8A9CmO8+lFOr8FzckMv2mEmNyeQTqbLrte6TjGUvW63zGwVPw4i+R
   Yo4mqgB+tEBhEXoQ60fTL6QM6zXhMBqyfrismrJ2OEHIzsAo7Fldfu6P3
   c=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 65071859
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:2sxRRKpEiiX/fMIumeWqTI496TReBmJpZRIvgKrLsJaIsI4StFCzt
 garIBmHOqyCNDD9KttxYNzj8U1Su5XXzYRnSgtlqyFnES9EopuZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlVEliefQAOCU5NfsYkidfyc9IMsaoU8ly75RbrJA24DjWVvX4
 4qq+aUzBXf+s9JKGjNMg068gEsHUMTa4Fv0aXRnOJinFHeH/5UkJMp3yZOZdhMUcaENdgKOf
 M7RzanRw4/s10xF5uVJMFrMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKv+Zvrgc91Zk
 b1wWZKMpQgBBqHQpKcHdARkDB50H6ZU1+PfGEKBrpnGp6HGWyOEL/RGCUg3OcsT+/ptAHEI/
 vsdQNwPRknd3aTsmuv9E7QywJR4RCXoFNp3VnVI5DfVF/s5B7vERL3H/4Rw1zYsnMFeW/3ZY
 qL1bBIxMUyfOk0Saz/7Droure2loSnVfAdq8nXKiZpw3zPS8CtIhe2F3N39JYXRGJQ9clyjj
 n3C13T0BFcdLtP34Riv/2+oh+TPtTjmQ49UH7q9ntZ6jVvWymENBRk+UVqgveL/mkO4Q8hYK
 UEf5mwpt6dayaCwZoCjBVvi+ifC50NCHYoLewEn1O2T4pLY/zraHE8ZciF+Yv4tpuBqXQUQ6
 EDcyrsFGgdTmLGSTHuc8JKdojWzJTUZIAc+WMMUcecWy4K9+d9u13ojWv4mSffo1YOtRVkc1
 hjX9HBWulkFsSIcO0xXF3jjiinkmJXGRxVdCu7/DjP8tVMRiGJIiuWVBbnnARRocdzxorqp5
 iFsdy2iAAcmV8zlqcB1aL9RdIxFHt7cWNEmvXZhHoM66xOm8GO5cIZb7VlWfRk1b51UJW60M
 RKJ6Gu9AaO/21PwMMdKj3+ZUZx2ncAM6/y+PhwrUja+SscoL1LWlM2fTUWRw3rsgCARfVIXY
 v+mnTKXJS9CU8xPlWPuL89EiOND7n1ulAv7GMGgpzz6gOX2WZJgYepcWLd4Rrtit/3sTcS82
 4s3CvZmPD0FDrWlO3GPqdR7wJJjBSFTOK0aYvd/LoarSjeK0kl4YxMN6dvNo7BYopk=
IronPort-HdrOrdr: A9a23:BwQZvK/aURGiZN8vzHluk+DcI+orL9Y04lQ7vn2ZLiYlFfBw9v
 re+MjzsCWetN9/Yh0dcLy7V5VoIkm9yXcW2+cs1N6ZNWGN1VdAR7sC0aLShxHmBi3i5qp8+M
 5bAs1D4QTLfDtHZBDBkWuFL+o=
X-IronPort-AV: E=Sophos;i="5.88,386,1635220800"; 
   d="scan'208";a="65071859"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>
Subject: [PATCH v2.1 8/7] x86/IOMMU: Use altcall, and __initconst_cf_clobber
Date: Mon, 21 Feb 2022 18:03:56 +0000
Message-ID: <20220221180356.13527-1-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125632.24563-1-andrew.cooper3@citrix.com>
References: <20220214125632.24563-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

Most IOMMU hooks are already altcall for performance reasons.  Convert the
rest of them so we can harden all the hooks in Control Flow Integrity
configurations.  This necessitates the use of iommu_{v,}call() in debug builds
too.

Move the root iommu_ops from __read_mostly to __ro_after_init now that the
latter exists.  There is no need for a forward declaration of vtd_ops any
more, meaning that __initconst_cf_clobber can be used for VTD and AMD.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>
---
 xen/arch/x86/include/asm/iommu.h            | 6 ++----
 xen/drivers/passthrough/amd/pci_amd_iommu.c | 2 +-
 xen/drivers/passthrough/iommu.c             | 7 ++++---
 xen/drivers/passthrough/vtd/iommu.c         | 3 +--
 xen/drivers/passthrough/x86/iommu.c         | 4 ++--
 5 files changed, 10 insertions(+), 12 deletions(-)

diff --git a/xen/arch/x86/include/asm/iommu.h b/xen/arch/x86/include/asm/iommu.h
index 8a96ba1f097f..a87f6d416252 100644
--- a/xen/arch/x86/include/asm/iommu.h
+++ b/xen/arch/x86/include/asm/iommu.h
@@ -72,7 +72,6 @@ struct arch_iommu
 
 extern struct iommu_ops iommu_ops;
 
-#ifdef NDEBUG
 # include <asm/alternative.h>
 # define iommu_call(ops, fn, args...) ({      \
     (void)(ops);                              \
@@ -83,7 +82,6 @@ extern struct iommu_ops iommu_ops;
     (void)(ops);                              \
     alternative_vcall(iommu_ops.fn, ## args); \
 })
-#endif
 
 static inline const struct iommu_ops *iommu_get_ops(void)
 {
@@ -106,7 +104,7 @@ int iommu_setup_hpet_msi(struct msi_desc *);
 static inline int iommu_adjust_irq_affinities(void)
 {
     return iommu_ops.adjust_irq_affinities
-           ? iommu_ops.adjust_irq_affinities()
+           ? iommu_call(iommu_ops, adjust_irq_affinities)
            : 0;
 }
 
@@ -122,7 +120,7 @@ int iommu_enable_x2apic(void);
 static inline void iommu_disable_x2apic(void)
 {
     if ( x2apic_enabled && iommu_ops.disable_x2apic )
-        iommu_ops.disable_x2apic();
+        iommu_vcall(iommu_ops, disable_x2apic);
 }
 
 int iommu_identity_mapping(struct domain *d, p2m_access_t p2ma,
diff --git a/xen/drivers/passthrough/amd/pci_amd_iommu.c b/xen/drivers/passthrough/amd/pci_amd_iommu.c
index e57f555d00d1..4b59a4efe9b6 100644
--- a/xen/drivers/passthrough/amd/pci_amd_iommu.c
+++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c
@@ -628,7 +628,7 @@ static void cf_check amd_dump_page_tables(struct domain *d)
                               hd->arch.amd.paging_mode, 0, 0);
 }
 
-static const struct iommu_ops __initconstrel _iommu_ops = {
+static const struct iommu_ops __initconst_cf_clobber _iommu_ops = {
     .init = amd_iommu_domain_init,
     .hwdom_init = amd_iommu_hwdom_init,
     .quarantine_init = amd_iommu_quarantine_init,
diff --git a/xen/drivers/passthrough/iommu.c b/xen/drivers/passthrough/iommu.c
index e220fea72c2f..c6b2c384d1dd 100644
--- a/xen/drivers/passthrough/iommu.c
+++ b/xen/drivers/passthrough/iommu.c
@@ -540,7 +540,7 @@ int __init iommu_setup(void)
 int iommu_suspend()
 {
     if ( iommu_enabled )
-        return iommu_get_ops()->suspend();
+        return iommu_call(iommu_get_ops(), suspend);
 
     return 0;
 }
@@ -548,7 +548,7 @@ int iommu_suspend()
 void iommu_resume()
 {
     if ( iommu_enabled )
-        iommu_get_ops()->resume();
+        iommu_vcall(iommu_get_ops(), resume);
 }
 
 int iommu_do_domctl(
@@ -578,7 +578,8 @@ void iommu_crash_shutdown(void)
         return;
 
     if ( iommu_enabled )
-        iommu_get_ops()->crash_shutdown();
+        iommu_vcall(iommu_get_ops(), crash_shutdown);
+
     iommu_enabled = false;
 #ifndef iommu_intremap
     iommu_intremap = iommu_intremap_off;
diff --git a/xen/drivers/passthrough/vtd/iommu.c b/xen/drivers/passthrough/vtd/iommu.c
index 56968a06a100..6a65ba1d8271 100644
--- a/xen/drivers/passthrough/vtd/iommu.c
+++ b/xen/drivers/passthrough/vtd/iommu.c
@@ -56,7 +56,6 @@ bool __read_mostly iommu_snoop = true;
 
 static unsigned int __read_mostly nr_iommus;
 
-static struct iommu_ops vtd_ops;
 static struct tasklet vtd_fault_tasklet;
 
 static int cf_check setup_hwdom_device(u8 devfn, struct pci_dev *);
@@ -2794,7 +2793,7 @@ static int __init cf_check intel_iommu_quarantine_init(struct domain *d)
     return rc;
 }
 
-static struct iommu_ops __initdata vtd_ops = {
+static const struct iommu_ops __initconst_cf_clobber vtd_ops = {
     .init = intel_iommu_domain_init,
     .hwdom_init = intel_iommu_hwdom_init,
     .quarantine_init = intel_iommu_quarantine_init,
diff --git a/xen/drivers/passthrough/x86/iommu.c b/xen/drivers/passthrough/x86/iommu.c
index ad5f44e13d98..17c0fe555dd0 100644
--- a/xen/drivers/passthrough/x86/iommu.c
+++ b/xen/drivers/passthrough/x86/iommu.c
@@ -27,7 +27,7 @@
 #include <asm/setup.h>
 
 const struct iommu_init_ops *__initdata iommu_init_ops;
-struct iommu_ops __read_mostly iommu_ops;
+struct iommu_ops __ro_after_init iommu_ops;
 bool __read_mostly iommu_non_coherent;
 
 enum iommu_intremap __read_mostly iommu_intremap = iommu_intremap_full;
@@ -129,7 +129,7 @@ int iommu_enable_x2apic(void)
     if ( !iommu_ops.enable_x2apic )
         return -EOPNOTSUPP;
 
-    return iommu_ops.enable_x2apic();
+    return iommu_call(iommu_ops, enable_x2apic);
 }
 
 void iommu_update_ire_from_apic(
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 21 18:39:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 21 Feb 2022 18:39:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276403.472547 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMDaf-00036U-6M; Mon, 21 Feb 2022 18:39:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276403.472547; Mon, 21 Feb 2022 18:39:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMDaf-00036N-3L; Mon, 21 Feb 2022 18:39:17 +0000
Received: by outflank-mailman (input) for mailman id 276403;
 Mon, 21 Feb 2022 18:39:15 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=S5yU=TE=epam.com=prvs=40514b27e2=oleksii_moisieiev@srs-se1.protection.inumbo.net>)
 id 1nMDad-00036H-28
 for xen-devel@lists.xenproject.org; Mon, 21 Feb 2022 18:39:15 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8f40fcf9-9345-11ec-8539-5f4723681683;
 Mon, 21 Feb 2022 19:39:13 +0100 (CET)
Received: from pps.filterd (m0174679.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 21LIV3ei010739;
 Mon, 21 Feb 2022 18:39:05 GMT
Received: from eur03-db5-obe.outbound.protection.outlook.com
 (mail-db5eur03lp2059.outbound.protection.outlook.com [104.47.10.59])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3ecg3900ky-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Mon, 21 Feb 2022 18:39:05 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com (2603:10a6:102:ea::23)
 by VI1PR03MB3582.eurprd03.prod.outlook.com (2603:10a6:803:34::24)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.27; Mon, 21 Feb
 2022 18:39:00 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::c1c:f98:9dd:86e0]) by PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::c1c:f98:9dd:86e0%5]) with mapi id 15.20.4995.027; Mon, 21 Feb 2022
 18:39:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8f40fcf9-9345-11ec-8539-5f4723681683
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XgdLDFaFyX3dsMVBhoy0S4tyFiHB3L7h9clgEGh8NW4m6N9NDsdu0A29cm82fvwvUXFGqsIE1cF/Dw947DixEDDLcMjSudgDnEXSl8uqe3giQZWLBilVKoUfWWctDSEYXa+AkXh593118VOwJ5sJJBGRl1wVHtvx9MXyNhsjVIlTvRfE9XX9DEW3s+ZcZe/N4cKdu/NVaGLz1CYhn/CHuVn+EYZp0zN4uOvs/k2jnMSBnxGXGKjq7imfCGFuLY8c5rSnBytC4Pe7ZmKddN1osqtIZK0EVsa1Ee5AfHfXXMZOxqirpBtwcCkbQdTrn1acjxqv/YvSe/R6oNfGGdv51g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=9aAKFgdGEsTa7WZqY3ARW9nutAOMip2HQvlx/JW81nw=;
 b=Las/vRN+CmzgWdpw/1bYBn/PaJq3LZyFyEKQ/gyhyjqxc9nn2KOWv6zcLz6Ew9Fs7+nImClg2Y5TbkK1qpSyBwyqX+YQKIo9nDXVHZgkD49stQmiTN4yyIpaMN/0g+3tKaem1qWi1gV7u5tjKbBLhBVuvD8Oyzam1E/Dt4eNmNDAJPUhNSuIEHHEOoyty//6V2MZcqEI/DbCnMDESwfz1Nw9JtmZ8+VFXrK94enPcKv40bRLgpMJ5HadmPdgraOxDRI4EXGEqnnb/jFXf05RLCBrtCRkQBN/EfOihIl3ya/9ijVdS75GTOEjoLaWYRz1gVgITQkUba/THm7m3x0mdw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=9aAKFgdGEsTa7WZqY3ARW9nutAOMip2HQvlx/JW81nw=;
 b=ILevcOuOq1o6/v1gEFmQku6GxxO1KyxKEq1zdeE5NVJGWHKEJShd7+oCh+Ps1jFTUFVMtSYzll1CQENY3Hk1NFoBX53cAIHF+2Tti0dloPMocRasfobwqVrjU1ZPA61FpPoH6kyuDkdQ1RjlroGH+YoUVCYCRAJKmPYP5t2K6EFCNdSnAnt6x71bN63ZUgdtNQcFYayDgDIKgHB64qrpXMc/rt7oqiet/MzBUFIvddtyruv+wKsFbynv0gvpY1OtY3mpaEuTEuTFz+NkeLyNd0YOcOYJU6WzzDUY6iOo2uchmE7jciOxN7fHPD75xZH/y0llofYFYsJHBFkfHP8tVQ==
From: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
To: Julien Grall <julien@xen.org>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        Wei Liu
	<wl@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>,
        George Dunlap
	<george.dunlap@citrix.com>,
        Jan Beulich <jbeulich@suse.com>,
        Stefano
 Stabellini <sstabellini@kernel.org>,
        Nick Rosbrook <rosbrookn@ainfosec.com>,
        Anthony PERARD <anthony.perard@citrix.com>,
        Juergen Gross <jgross@suse.com>, Paul Durrant <paul@xen.org>
Subject: Re: [RFC v2 6/8] tools/arm: Introduce force_assign_without_iommu
 option to xl.cfg
Thread-Topic: [RFC v2 6/8] tools/arm: Introduce force_assign_without_iommu
 option to xl.cfg
Thread-Index: AQHYHRW3O86755dYV0qSgPdVO9oeMayX6acAgAEsnQCAABEMgIAFQxiA
Date: Mon, 21 Feb 2022 18:39:00 +0000
Message-ID: <20220221183859.GA66126@EPUAKYIW015D>
References: <cover.1644341635.git.oleksii_moisieiev@epam.com>
 <d333126d12f2281f8df92e66cfba1c9eb2425dca.1644341635.git.oleksii_moisieiev@epam.com>
 <ab6d8d13-30cf-d322-668e-f3f5aaa56824@xen.org>
 <20220218091632.GA1486420@EPUAKYIW015D>
 <15ada062-2ec5-d8ff-6bd7-5c580939accc@xen.org>
In-Reply-To: <15ada062-2ec5-d8ff-6bd7-5c580939accc@xen.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 73171b87-d3e0-43f1-b191-08d9f5696d73
x-ms-traffictypediagnostic: VI1PR03MB3582:EE_
x-microsoft-antispam-prvs: 
 <VI1PR03MB3582BC9FD4470ABCEF5850F0E33A9@VI1PR03MB3582.eurprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 /bwrVmHMQPd0Qt1v5K4PXJ+RaB9rxJHMieOsN/+PIoXPM6z1vPJpyLW1saQ30mBJs5tGIRR7Svfjz7z7dufhY3hNuwrJbV9IZy7LXpfcPYS0vfUjepl3XABeg6NKBtO7T5zcg9NbsH5Kg6PZlUomraJNVtG8HFYOVC2qp6umOcMozlLphL01Kb//ABU1SUHbfrFTPwhxuQ/30eBYUoDBZ05s6OoJOVO1XzPmDwMPT87UE1PZtsg0GqFwVE9KTzGXmfPPIvBqwvifsHwoEfIafyZpZRMTRWfMthmJxNnGEta+hTZNDDgTf/LaE1g9r5mXg9X7aREiaK3+5z78GdAy6MH8Lc946bBA0WoWEADKkbVsIxwjW2r26pzCmkowBVS3oIOvPBhjkYd83nDRfxWqpaMAGThkzsp5r1ALwUjvgK2PCi3Symm9cf80udFb6UrFI6JgNgdSyQzRQ9OvMvBsfTHxBpsgxJF6TcZwlAniogx4X8QtkWmFwbqYpWQ/Z5m/GG9j7h/Y7ZCcPZi2NfnjaLKrToUU2NAbeSIbjiyGiel+sd1XF6weS9RLIbpvI8rkkbhhixv+VkJHoba49Xw1tfp0Vq6ccBaMCr6JaXLirawvs/CfOSsnnSmmwx4k+2YXa+y0Ylei//kgiq99izPVGtLf4Sf3xo2eHiFcs6oCILsr2XVVLEhfqt4eB1biWBGen0DWo3CLuYkXP5BJACB+qDs3Guck2m/97PAcyPnxnvR/ITrModCDTLLuCIzwhao15YYxmtQ8chQFOgt5eNekIJOWMpGGAqYvPI0MVijWaSs=
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR03MB7136.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(66476007)(6506007)(66446008)(9686003)(4326008)(66556008)(6512007)(2906002)(1076003)(86362001)(26005)(53546011)(5660300002)(186003)(66946007)(122000001)(6486002)(966005)(508600001)(38100700002)(8676002)(64756008)(71200400001)(8936002)(7416002)(91956017)(83380400001)(33716001)(38070700005)(6916009)(316002)(33656002)(54906003)(76116006);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?XXN946FvnROtrO+1CLTyor9hZBKJAcgtGIElVKD6Z3IsI53oyKdd2ypvFsz7?=
 =?us-ascii?Q?HKofHyMEJU+6JBpKM0pwhBv2kRC+pXYxO93nn0omSHJrrWjpvzaNOViu0uAv?=
 =?us-ascii?Q?iFjRiJROpBqMHaPHj95Wvsi3AUVLVMf1H58IOfov2rcB9ROPU9se/pN3ay8C?=
 =?us-ascii?Q?yAze5hwIz/5WsiYFlVOsX/hWnove859MFKoYTNgQkJWI5kwCFuGJt7vesO6K?=
 =?us-ascii?Q?5p9pUsLA/3OHULp9ZlnnMlcOugRhJ7e1tJc0BwJiyPcsfvpnXi8MTp57RmA+?=
 =?us-ascii?Q?/hj7rpp4UbSnnSDfFkpMnsgU7ARejz8+wLQAfv71eMOXUybLEkidThEU0w8A?=
 =?us-ascii?Q?IBbyU66qWL4JhazN/5qR7myU15nVYu1+g4EFi7D71y5gL3rhxvD0xiSlju8s?=
 =?us-ascii?Q?GVy+JQuyVlHK5HbVBjrbn1AO47jV4IJCDVUxSp5ueH1dsJ7skUXDG8cLi2zo?=
 =?us-ascii?Q?Mtv8g0KV1lhxdvOUeBx8+stH0egqFUj6oq7x5qWIJrC4wSTyZpRTOscJqPxo?=
 =?us-ascii?Q?a9y5LbGq4yh+GleeEdqvi41+OxMVd+eUnjio88Kd3kOnTFHgQu8azV5BFdzY?=
 =?us-ascii?Q?USQtQ9HzZ43WEKoDvUtrpqn0CmnB6Ysve1UuGhlNn2yHkFYqLS50UlCSgc3X?=
 =?us-ascii?Q?I1oD6dHMNCZltNyjnypuNHGSsHCfUyxgjmoWIy8eOk3F1/xZUAS0v+MiCy3F?=
 =?us-ascii?Q?teBQjkR4r+yhi6tPbq2HCfOiKNCaE77EumyowqDOCGlhoN9opW/xc7YwX0ME?=
 =?us-ascii?Q?L09VCoZjMUDDLZ83DsVZN8GLm+cy8ObNS6xSJ+deG3AIZ4op7qmP3wsRu7cH?=
 =?us-ascii?Q?dy0rhbQwsjAb7khlDx5TH5RntrqNShpQ0VNZ2RlSXW82Kp1HbWIppZuwJACa?=
 =?us-ascii?Q?UMAzAJoGVcpOTTOdfpvblKmV977qrPgQejmdqoBQFy+uJIBUJOJ0t8NJDGUW?=
 =?us-ascii?Q?eZp2+K8t8XPaYqZ6OmP9sTIcywpxnBzTc+WqZUEZAt5AoQEjYduT2rNs6GBP?=
 =?us-ascii?Q?sD+ZLiMi1Gu1nrceNb7hfgzaks5a7HYQC+UjsBovHjTZjfkCWCMXZER7yulb?=
 =?us-ascii?Q?RvJww0pbGT02T/VK17Ru9nQNI6XKupOuRRojV/gjCKMO1Rd+Lg1TGcC2bQf7?=
 =?us-ascii?Q?EW1F8vO90AV+MYtuPQYk6+jDhv/w713FaXe/jxPe93WUkGk47JIbDI8T+G4A?=
 =?us-ascii?Q?gVF0JjOcnHgcGKrgUAGm1yy4yuO4wPOLXKXM4Ak7K/KC+XMd3FopOiiQtJog?=
 =?us-ascii?Q?O8/S38EozC1iPYA8CFaIXBjyBTfuIYGsoyG10M+E/dqrJcJFTVkqZC0J2Ga/?=
 =?us-ascii?Q?h8eCXlndrL5CEINrCJN1140BpayKj4swImsohY+cheATtywfozBeO2sgAZfJ?=
 =?us-ascii?Q?83hC4ADB8vQapDIKR7G9As9aUYtK4fcvBbI80yIzp16Up7tEWLk/gJ11tCjy?=
 =?us-ascii?Q?VJmdEKfBkq2cqS9qYpMluevAgBCMnzwOaNZOfUeRb3G3YipkHKZY5QYvNpPu?=
 =?us-ascii?Q?mImp986rGmot9W969CBJkIq5q/jLqr5p6cYDs+BKRAmHHWK/DOqzYY6KcOTE?=
 =?us-ascii?Q?q9rDG9IeiR5PAqed578JGA395mMP/RK5XzLOWE1CrEbWlfSiTB521/vQHkca?=
 =?us-ascii?Q?IEMI5Em1GhsFOfGBU2cRNk8OS9CT8/iDjAxR+pImm/UnQAWKjdw9oSbfBbRR?=
 =?us-ascii?Q?y9oZtvWyfyDTZoru/J3tSFhDaQI=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <08E2A50F93F65749A6C202EE21114000@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR03MB7136.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 73171b87-d3e0-43f1-b191-08d9f5696d73
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Feb 2022 18:39:00.5524
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: tShoDLFbLtY527UfaXAquiAjo2XcPmPNsQmohhAqyWi4dMm87zkOXoorYvcYnDrDZ53+LVWeb9diOVJsB5pec9FqJbwyVGx3AhxxpfBMoqI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR03MB3582
X-Proofpoint-GUID: wzYD_0f3M7M9QnSjnhO0_MFiII_R37R8
X-Proofpoint-ORIG-GUID: wzYD_0f3M7M9QnSjnhO0_MFiII_R37R8
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-21_08,2022-02-21_02,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0
 lowpriorityscore=0 priorityscore=1501 mlxlogscore=999 phishscore=0
 adultscore=0 suspectscore=0 spamscore=0 mlxscore=0 clxscore=1015
 bulkscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202210110

Hi Julien,

On Fri, Feb 18, 2022 at 10:17:33AM +0000, Julien Grall wrote:
>=20
>=20
> On 18/02/2022 09:16, Oleksii Moisieiev wrote:
> > Hi Julien,
>=20
> Hi Oleksii,
>=20
> > On Thu, Feb 17, 2022 at 03:20:36PM +0000, Julien Grall wrote:
> > > >        xlu_cfg_get_defbool(config, "xend_suspend_evtchn_compat",
> > > > diff --git a/xen/common/domain.c b/xen/common/domain.c
> > > > index 093bb4403f..f1f19bf711 100644
> > > > --- a/xen/common/domain.c
> > > > +++ b/xen/common/domain.c
> > > > @@ -512,7 +512,7 @@ static int sanitise_domain_config(struct xen_do=
mctl_createdomain *config)
> > > >        if ( iommu )
> > > >        {
> > > > -        if ( config->iommu_opts & ~XEN_DOMCTL_IOMMU_no_sharept )
> > > > +        if ( config->iommu_opts >> XEN_DOMCTL_IOMMU_MAX )
> > >=20
> > > XEN_DOMCTL_IOMMU_MAX will be defined as:
> > >=20
> > > (1U << _XEN_DOMCTL_IOMMU_force_iommu)
> > >=20
> > > This means the shift will do the wrong thing. However, AFAICT, this n=
ew
> > > option will only be supported by Arm and likely only for platform dev=
ice for
> > > the time being.
> >=20
> > Thanks, I will fix that.
> >=20
> > >=20
> > > That said, I am not convinced this flag should be per-domain in Xen.
> > > Instead, I think it would be better to pass the flag via the device a=
ssign
> > > domctl.
> >=20
> > Do you mean that it's better to set this flag per device, not per
> > domain? > This will require setting this flag for each device which sho=
uld
> > require either changing the dtdev format in dom.cfg or setting
> > xen,force-assign-without-iommu in partial device-tree.
> >=20
> > Both of those ways will complicate the configuration. As was mentioned
> > before, we don't want to make domain configuration more complicated.
> > What do you think about that?
>=20
> We have two interfaces here:
>   1) User -> tools
>   2) tools -> Xen
>=20
> We can chose different policy for each interface.
>=20
> For the tools -> Xen interface, I think this should be per device (simila=
r
> to XEN_DOMCTL_DEV_RDM_RELAXED).
>=20
> For the User -> tools, I am open to discussion. One advantage with per
> device is the user explicitely vet each device. So it is harder to
> passthrough a device wrongly.
>=20
> But I agree this also complicates the interface. What do other thinks?
>=20

I see the following ways of User -> tools format:

a) Set force_assign_without_iommu =3D 1 in dom.cfg
b) Update dtdev format add force_iommu parameter, so dtdev will look
like this:
dtdev =3D [
    "/soc/dma-controller@e6700000",
    "/soc/gpio@e6055000,force_iommu",
    ...
]
c)...

Tools -> Xen possible ways:

d) Set force_assign_without_iommu to domain globally
e) Pass force_assign_without_iommu via device-assign domctl.

a) + d) is what we have in the patch series.

I think a) + e) can work for now so we will have an interface to make
force_assign_without_iommu per device in future.

What do you think about it?

> > >=20
> > > >            return -EOPNOTSUPP;
> > > > @@ -542,7 +545,7 @@ int iommu_do_domctl(
> > > >    #endif
> > > >    #ifdef CONFIG_HAS_DEVICE_TREE
> > > > -    if ( ret =3D=3D -ENODEV )
> > > > +    if ( ret =3D=3D -ENOSYS )
> > >=20
> > > AFAICT, none of the code (including callee) before ret have been modi=
fied.
> > > So why are you modifying the check here?
> > >=20
> >=20
> > Because this check will fail if we have CONFIG_HAS_DEVICE_TREE define,
> > but do not have CONFIG_HAS_PCI and iommu_do_dt_domctl will not be
> > called.
>=20
> Below the implementation of iommu_do_domctl() on staging:
>=20
> int iommu_do_domctl(
>     struct xen_domctl *domctl, struct domain *d,
>     XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl)
> {
>     int ret =3D -ENODEV;
>=20
>     if ( !is_iommu_enabled(d) )
>         return -EOPNOTSUPP;
>=20
> #ifdef CONFIG_HAS_PCI
>     ret =3D iommu_do_pci_domctl(domctl, d, u_domctl);
> #endif
>=20
> #ifdef CONFIG_HAS_DEVICE_TREE
>     if ( ret =3D=3D -ENODEV )
>         ret =3D iommu_do_dt_domctl(domctl, d, u_domctl);
> #endif
>=20
>     return ret;
> }
>=20
> 'ret' is initialized to -ENODEV. So for !CONFIG_HAS_PCI, then ret will no=
t
> be changed. Therefore the current check is correct.
>=20
> AFAICT, your patch is setting 'ret' so I don't expect any change here.
>=20
> > Same thing if switch/case inside iommu_do_pci_domctl go to default and
> > return -ENOSYS. This part looked strange for me. But I will definitely
> > go through this part once again.
> We use the same sub-op to assign/deassign a PCI and "DT" device. So we ar=
e
> not interested in -ENOSYS but -ENODEV that would be returned by the check=
s:
>=20
> if ( domct->u.assign_device.dev !=3D XEN_DOMCTL_DEV_PCI )
>=20
> At the moment, there are no sub-op specific to "DT" device. So it is not
> necessary for us to check -ENOSYS yet.
>=20
> I haven't looked at the rest of the series to see if we need it. But if w=
e
> do, then I think the check should be extended in the patch that requires =
it.
>=20

Thank you for the comment. I will refactor this code.

Also I wanted to share with you some thoughts about using SMC client_id
field to pass agent_id to the SCMI.
Posted question regarding this approach to trustedfirmware
phabricator [0].

I've found that ATF already has multiagent approach implemented for
stm32mp1 platform, see plat/st/stm32mp1/include/stm32mp1_smc.h [1].
It uses 2 funcids hardcoded for AGENT0 and AGENT1:
STM32_SIP_SMC_SCMI_AGENT0       0x82002000
STM32_SIP_SMC_SCMI_AGENT1       0x82002001

I think this approach will be very promising for SCI mediator.

Firmware defines a range of func_ids, let's say from 0x82000010 to 0x820000=
20,
where 0x82000010 is the base func_id for trusted agent. This func_id is
set in arm,scmi-smc node in Xen device-tree.

During startup Xen requests agent configuration and calculate func_id for
each channel the following way:

<Base Func_ID> + <channel_id>

Calculated func_id should be assigned to the Domain by setting it as
arm,scmi-id in arm,scmi-smc node. So for the Domain Xen will generate
the following nodes:

scmi {
   compatible =3D "arm,scmi-smc";
   arm,smc-id =3D <calculated func_id>;
   ...
   shmem =3D <&shmem_node>
};=20

shmem_node {
  compatible =3D "arm,scmi-shmem";
  ...
};

In this case each domain will get unique func_id to send SCMI commands.

I see the following advantages of this approach:
1) There is no need for Xen to intercept SMC requests. All requests from
agents will go directly to the Firmware, which can calculate agent_id
from func_id. This mean that there is no need for scmi_handle_call
function.
2) This approach already implemented for stm32mp1 board so it's more
likely to be accepted.

Another thing I want to discuss is how Xen should handle scmi related
nodes from xen device-tree.
Currently Xen device-tree includes arm,scmi-smc node and a list of
scmi-shmem nodes for the channels:
scmi {
   compatible =3D "arm,scmi-smc";
   ...
};

sram@0x53ff0000 {
    compatible =3D "mmio-sram";
    ...
    cpu_scp_shm: scp-shmem@0x0 {
        compatible =3D "arm,scmi-shmem";
        ...
    };
    scp-shmem@0x1000 {
        ...
    };

    ...

    scp-shmem@0xF000 {
        ...
    };

};

We do not want all of this nodes to be present in Dom0.
I suggest to set xen,passthrough for all this nodes to ensure that Dom0
will not get information about other channels and generate nodes
arm,scmi-shmem and arm,scmi-smc for Dom0.
I think this approach will be more secure.

What do you think about both suggested approaches?

[0] https://developer.trustedfirmware.org/T985
[1] https://review.trustedfirmware.org/TF-A/trusted-firmware-a=


From xen-devel-bounces@lists.xenproject.org Mon Feb 21 19:06:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 21 Feb 2022 19:06:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276412.472558 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nME0Z-0006P1-BW; Mon, 21 Feb 2022 19:06:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276412.472558; Mon, 21 Feb 2022 19:06:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nME0Z-0006Ou-8P; Mon, 21 Feb 2022 19:06:03 +0000
Received: by outflank-mailman (input) for mailman id 276412;
 Mon, 21 Feb 2022 19:06:02 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Nr+1=TE=xilinx.com=ayankuma@srs-se1.protection.inumbo.net>)
 id 1nME0Y-0006OT-Ga
 for xen-devel@lists.xenproject.org; Mon, 21 Feb 2022 19:06:02 +0000
Received: from NAM11-DM6-obe.outbound.protection.outlook.com
 (mail-dm6nam11on2062b.outbound.protection.outlook.com
 [2a01:111:f400:7eaa::62b])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4d7c8786-9349-11ec-8eb8-a37418f5ba1a;
 Mon, 21 Feb 2022 20:05:59 +0100 (CET)
Received: from BN0PR04CA0022.namprd04.prod.outlook.com (2603:10b6:408:ee::27)
 by SJ0PR02MB8861.namprd02.prod.outlook.com (2603:10b6:a03:3f4::5)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.22; Mon, 21 Feb
 2022 19:05:55 +0000
Received: from BN1NAM02FT055.eop-nam02.prod.protection.outlook.com
 (2603:10b6:408:ee:cafe::1e) by BN0PR04CA0022.outlook.office365.com
 (2603:10b6:408:ee::27) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.15 via Frontend
 Transport; Mon, 21 Feb 2022 19:05:54 +0000
Received: from xir-pvapexch01.xlnx.xilinx.com (149.199.80.198) by
 BN1NAM02FT055.mail.protection.outlook.com (10.13.2.163) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.4995.19 via Frontend Transport; Mon, 21 Feb 2022 19:05:54 +0000
Received: from xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) by
 xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2176.14; Mon, 21 Feb 2022 19:05:53 +0000
Received: from smtp.xilinx.com (172.21.105.197) by
 xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server id
 15.1.2176.14 via Frontend Transport; Mon, 21 Feb 2022 19:05:53 +0000
Received: from [10.71.117.205] (port=35928)
 by smtp.xilinx.com with esmtp (Exim 4.90)
 (envelope-from <ayan.kumar.halder@xilinx.com>)
 id 1nME0O-00083B-MV; Mon, 21 Feb 2022 19:05:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4d7c8786-9349-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=aDIl7LbZz2n8JKwKRBuGQrj+n/bQxk2CBgq4dqTYoGnMBTHLA2LG5pwS6Q6AtEI5CSNuUnhBilrlesSNiVl4fa8H1SLb1ngYcnYH64PlVvYBqBV1i0kOjCaKFxzcYmLKS241kVTg1yB8bW9DC+MMo4ExIssPxJAA7rLWzezpvS50nimOSCs07ZaCpEw8onKlWaY+SRj4Qf93X+e0InIq2RBQcMnq4neRVVW3vSToCwG7GzVrsyqJMmQ8uaXCCq0zxMl5tWleIZeIyvl3E+V2AWP0EFdMQWIyzUAtBWCSZpPmGlq+qBdsByUJAqCvLSVvyYRdG4kfS3keTKmHObBapw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=dGyQF80MFo4yZeo3vn42A1fN0nvkrzuMSCcOpoDcoEc=;
 b=MX3PTkKjXdbejTPEp2ssAW05sXbbk74Pcl3pkiWZtg/k/tlMMUv0V9bgmCeLRsgzTIWXdQav/TB2zYRxVpancZvdZo6GObPHjVAjHoXMSloeEAtIcLSzqypEbKzzyfwD54byjuIvoQpCsqLmdxe399d9qhZcN4DXzSCU1qN5FL79OZGjNyCZXMI+1NNlNd87dUCDe6dwqCYqSNyCIPyG4LF+oQ7fDdT7tUBxeWnggpNIK8sHaTi6QZoM90N0Hx3cRdU/xMGyGjeIalpcqlH2j+3ltKUpzu08nJNTiA+Yxmjk1lxOBpohMGivCcxYw8JbDIYMlZcmt0wyDBsz7IYC0w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 149.199.80.198) smtp.rcpttodomain=xen.org smtp.mailfrom=xilinx.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=dGyQF80MFo4yZeo3vn42A1fN0nvkrzuMSCcOpoDcoEc=;
 b=eJFTzayATDb9EdDHq1CIoj06M8Q3Kjf8uonhr0PVPUTUl9SQscQ4zeloGSSVa7Sj6ASCNOPB8V7C15WixKVEP/OPG0jr37aqU5UF3syVhvtiLmvVHmktVOl2VdeSOFvI78u0INnkyO5MHoC1gG2Kt6B9SojYng48ei3lQjzjCfs=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198)
 smtp.mailfrom=xilinx.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=xilinx.com;
Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates
 149.199.80.198 as permitted sender) receiver=protection.outlook.com;
 client-ip=149.199.80.198; helo=xir-pvapexch01.xlnx.xilinx.com;
Message-ID: <e53b1407-4701-f0f1-5f49-5bd8cbb6eb41@xilinx.com>
Date: Mon, 21 Feb 2022 19:05:52 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.0
Subject: Re: [XEN v8 2/2] xen/arm64: io: Support instructions (for which ISS
 is not valid) on emulated MMIO region using MMIO/ioreq handler
To: Julien Grall <julien@xen.org>, Ayan Kumar Halder
	<ayan.kumar.halder@xilinx.com>, <xen-devel@lists.xenproject.org>
CC: <sstabellini@kernel.org>, <stefanos@xilinx.com>,
	<Volodymyr_Babchuk@epam.com>, <bertrand.marquis@arm.com>
References: <20220212233433.46018-1-ayankuma@xilinx.com>
 <20220212233433.46018-3-ayankuma@xilinx.com>
 <1599e2f3-0a34-020a-dd42-5ba87dad555d@xen.org>
 <10cf253b-fc58-1afc-66ec-33ac3008bb0f@xilinx.com>
 <576cf522-f002-afac-36b6-b31f87724dca@xen.org>
From: Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>
In-Reply-To: <576cf522-f002-afac-36b6-b31f87724dca@xen.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ceba1dc2-d479-47a3-f2ea-08d9f56d2f56
X-MS-TrafficTypeDiagnostic: SJ0PR02MB8861:EE_
X-Microsoft-Antispam-PRVS:
	<SJ0PR02MB8861FA782B0C303F543FBA02B23A9@SJ0PR02MB8861.namprd02.prod.outlook.com>
X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	O43l7YTHznrcXF5SLgg17lgq/676NwjuQJcIk0iSXU/v1hzLLZT/8aRU2r02bW76HHeQpIFlHSLhjIFFOUeM19qLHR/gdwby7n1yqmX6pzsaoL+LQxRavZ0BaB5DodmBDRa8mhGZA86oEmxe8V2JSyHTxM2G1nz1XXCrmkt+L5hkRhGVhWaUt4LjXEWj9nS9KQA8IDdIoCKH4+GQxXPYMdBmxR9jqQo8U5IkczePSku8KeNr13YIcco1JY0wUwmVDZrKc/mOmRP2cTfRzCnDPGtPgoi2cu9xhUjNW4Il6MJIu4Bz2qix9uGxh4aYJd3++kl4FtlLquc25T6rp4GnV/g+VPcdQrrjRiTlRLeB8c2rhwb6yEDEUdw0VGMx/barcpFg8YgjtA9ZYIv53iIaMiuRMYVW4OjAiLs7v2B3zDh6zE9OxPd54537yNv0OTTQGnGSf3X57DlZbCXc1JNcAX/Si296VUo2cI96TRyWSvCabCxAmKu6aLSb2qdtiph+xTEgkS/+DL+GbBwxePi8TUaTVsdmk+qUpDjP/4y5nyBODiQNhznC7Yd3eJixGkPXa3kLFe3qCHPTvWEYLR7XVRTb4udbQ9WlpEquyVh69aZXPRFEgiVzdktT2+tojeYylHOyNwFyF+LIiYR2WNXsQv7NEBXrsKUGUqJ+FnZ940j6REYnAxxxUBir2HpMoeLq9sTVDdkxmJaQaY3Fo48VThU1Cx21rsJ3z6qH0kBJa8NLRPIKcvREIE3pZKPXeiJNWfpNsHNxezb1BRJcpLGdPxIBqi4Sgyq4jzqcTjaGTlU=
X-Forefront-Antispam-Report:
	CIP:149.199.80.198;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:xir-pvapexch01.xlnx.xilinx.com;PTR:unknown-80-198.xilinx.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(9786002)(5660300002)(2906002)(356005)(36756003)(70586007)(508600001)(31686004)(7636003)(83380400001)(8936002)(2616005)(426003)(40460700003)(316002)(54906003)(110136005)(47076005)(53546011)(31696002)(336012)(186003)(26005)(82310400004)(8676002)(4326008)(36860700001)(70206006)(50156003)(43740500002)(473944003)(414714003);DIR:OUT;SFP:1101;
X-OriginatorOrg: xilinx.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2022 19:05:54.2385
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: ceba1dc2-d479-47a3-f2ea-08d9f56d2f56
X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.80.198];Helo=[xir-pvapexch01.xlnx.xilinx.com]
X-MS-Exchange-CrossTenant-AuthSource:
	BN1NAM02FT055.eop-nam02.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR02MB8861


On 21/02/2022 17:57, Julien Grall wrote:
>
>
> On 21/02/2022 17:05, Ayan Kumar Halder wrote:
>> Hi Julien,
>
> Hi,
Hi Julien,
>
>> On 13/02/2022 12:19, Julien Grall wrote:
>>>>   }
>>>>     void register_mmio_handler(struct domain *d,
>>>> diff --git a/xen/arch/arm/ioreq.c b/xen/arch/arm/ioreq.c
>>>> index 308650b400..3c0a935ccf 100644
>>>> --- a/xen/arch/arm/ioreq.c
>>>> +++ b/xen/arch/arm/ioreq.c
>>>> @@ -47,6 +47,7 @@ enum io_state try_fwd_ioserv(struct cpu_user_regs 
>>>> *regs,
>>>>                                struct vcpu *v, mmio_info_t *info)
>>>>   {
>>>>       struct vcpu_io *vio = &v->io;
>>>> +    struct dabt_instr instr = info->dabt_instr;
>>>>       ioreq_t p = {
>>>>           .type = IOREQ_TYPE_COPY,
>>>>           .addr = info->gpa,
>>>> @@ -76,10 +77,8 @@ enum io_state try_fwd_ioserv(struct 
>>>> cpu_user_regs *regs,
>>>>       if ( !s )
>>>>           return IO_UNHANDLED;
>>>>   -    if ( !info->dabt.valid )
>>>> -        return IO_ABORT;
>>>> -
>>>
>>> For this one, I would switch to ASSERT(dabt.valid);
>> I see that try_fwd_ioserv() is invoked from try_handle_mmio() only. 
>> Thus, if I follow your suggestion of adding a check for dabt.valid at 
>> the beginning of try_handle_mmio(), then this ASSERT() is not required.
>
> I agree that try_handle_mmio() is the only caller today. But we don't 
> know how this is going to be used tomorrow.
>
> The goal of this ASSERT() is to catch those new users that would call 
> it wrongly.
>
> [...]
>
>>> ... this will inject a data abort to the guest when we can't decode. 
>>> This is not what we want. We should check whether this is a P2M 
>>> translation fault or we need to map an MMIO region.
>>>
>>> In pseudo-code, this would look like:
>>>
>>> if ( !is_data || hsr.dabt.valid )
>>
>> I think you mean if ( !is_data || !hsr.dabt.valid )
>
> You are right.
>
>>
>> The reason being if there is an instruction abort or a data abort 
>> (with ISV == 0), then it should try to configure the page tables.
>>
>>> {
>>>     if ( check_p2m() )
>>>       return;
>>>
>>>
>>>     if ( !is_data )
>>>        goto inject_dabt;
>>>
>>>     decode_instruction();
>>>     if ( !dabt.invalid )
>>>       goto inject_dabt;
>>> }
>>>
>>> try_handle_mmio();
>>>
>>> if ( instruction was not decoded )
>>>   check_p2m();
>>
>> If the instruction was not decoded, then there is no need to 
>> configure the page tables again. We have already done this before.
>
> Hmmmm... I think there are confusing about which sort of decoding I 
> was referring to. In this case, I mean if we didn't decode the 
> instruction manully, then it is not necessary to call check_p2m().
>
> Do you agree with that?

If we (ie Xen) didn't decode the instruction manually, then check_p2m() 
has not been invoked yet.  This is because of the following 
(info.dabt.valid == True) :-

         if ( !is_data || !info.dabt.valid )
         {

                 ...

                 if ( check_p2m(is_data, gpa) )
                     return;

                 ...

         }

So, in this scenario ( !info.dabt.valid), it would not be necessary to 
invoke check_p2m() after try_handle_mmio().

However, if we havenot decoded the instruction manually (ie 
info.dabt.valid == True), and try_handle_mmio() returns IO_UNHANDLED, 
then it will be necessary to invoke "check_p2m(is_data, gpa)"

- Ayan

>
>> So my understanding is as follows :-
>>
>>          /* Check that it is instruction abort or ISS is invalid. */
>
> I have had a remark on this line before. Please have a look and 
> address it.
>
>>          if ( !is_data || !info.dabt.valid )
>>          {
>>              /*
>>               * If the instruction was trapped due to access to stage 
>> 1 translation
>>               * then Xen should try to resolve the page table entry 
>> for the stage 1
>>               * translation table with the assumption that the page 
>> tables are
>>               * present in the non MMIO region. If it is successful, 
>> then it should
>>               * ask the guest to retry the instruction.
>>               */
>
> I agree that we want to skip the MMIO mapping when s1ptw == 1. 
> However, I am not sure this belongs to this patch because this is 
> technically already a bug.
>
>>              if ( is_data && info.dabt.s1ptw )
>>              {
>>                  info.dabt_instr.state = INSTR_RETRY;
>>                  /* The translation tables are assumed to be in non 
>> MMIO region. */
>>                  is_data = false;
>
> is_data is also used to decide which sort of abort we want to send to 
> the guest (see after inject_dabt). So I don't think we could force set 
> is_data here.
>
> Instead, I would define a new local variable (maybe 
> mmio_access_allowed) that will be set for instruction abort or when 
> s1ptw is 1.
>
>>              }
>>
>>              /*
>>               * Assumption :- Most of the times when we get a 
>> translation fault
>>               * and the ISS is invalid, the underlying cause is that 
>> the page
>>               * tables have not been set up correctly.
>>               */
>
> I think this comment make more sense on top of "if !is_data || 
> !info.dabt.valid".
>
>>              if ( check_p2m(is_data, gpa) )
>>                  return;
>>
>>              /*
>>               * If the instruction abort or the data abort due to 
>> access to stage 1
>>               * translation tables could not be resolved by setting 
>> the appropriate
>>               * bits in the translation table, then Xen should abort 
>> the guest.
>
> IHMO, "abort the guest" means we are going to crash the guest. 
> However, this not the case here. We are telling the guest that we 
> couldn't handle the data/instruction request. It is up to the guest to 
> decide whether it should panic or handle gracefully the error.
>
> We should also avoid the term guest because it usually only refers to 
> any domain but dom0.
>
> Therefore, I would reword it to something like "Xen will forward the 
> data/instruction abort to the domain".
>
>>               */
>>              if ( !is_data || (info.dabt_instr.state == INSTR_RETRY) )
>
> The second part looks unnecessary.
>
>>                  goto inject_abt;
>>
>>              try_decode_instruction(regs, &info);
>>
>>              /* Instruction could not be decoded, then abort the 
>> guest */
>>
>>              if ( info.dabt_instr.state == INSTR_ERROR)
>>                  goto inject_abt;
>>          }
>>
>>          state = try_handle_mmio(regs, &info);
>>
>>          switch ( state )
>>          {
>>              case IO_ABORT:
>>                  goto inject_abt;
>>              case IO_HANDLED:
>>                  /*
>>                   * If the instruction was decoded and has executed 
>> successfully
>>                   * on the MMIO region, then Xen should execute the 
>> next part of
>>                   * the instruction. (for eg increment the rn if it is a
>>                   * post-indexing instruction.
>>                   */
>>                  post_increment_register(&info.dabt_instr);
>>                  advance_pc(regs, hsr);
>>                  return;
>>              case IO_RETRY:
>>                  /* finish later */
>>                  return;
>>              case IO_UNHANDLED:
>>                  /* IO unhandled, try another way to handle it. */
>>                  break;
>>          }
>>
>>          if ( check_p2m(is_data, gpa) )
>
> It is unnecessary to call check_p2M() if we manually decoded the 
> instruction (see above why).
>
> Cheers,
>


From xen-devel-bounces@lists.xenproject.org Mon Feb 21 19:13:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 21 Feb 2022 19:13:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276419.472570 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nME7q-0007or-2W; Mon, 21 Feb 2022 19:13:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276419.472570; Mon, 21 Feb 2022 19:13:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nME7p-0007ok-Vl; Mon, 21 Feb 2022 19:13:33 +0000
Received: by outflank-mailman (input) for mailman id 276419;
 Mon, 21 Feb 2022 19:13:32 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nME7o-0007oe-Po
 for xen-devel@lists.xenproject.org; Mon, 21 Feb 2022 19:13:32 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nME7m-0004mf-OK; Mon, 21 Feb 2022 19:13:30 +0000
Received: from [54.239.6.189] (helo=[192.168.5.64])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nME7m-0004Ps-I0; Mon, 21 Feb 2022 19:13:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=JYqiO5ZeR4k8edLUhIFlT4qB0cgLLPLEkraSJOdVvJ8=; b=5DQKUee2jXxloMfvmscK8EOHTI
	sCiqwGA8NvgFdlMhTfoo5yWaceCzLgN+i3ZvTtGYXi+P3qmLQxzBE2BJ23eJoz5bD/NwYMWFACutZ
	Km4q8CbtuI3b+Cqcgtcl2l6ey0vBKqshTqG4bdM+xH2wJf2+brm9akD7/Bm9/SiGcx8E=;
Message-ID: <96610d30-0de2-96e9-e838-504acf83a8d8@xen.org>
Date: Mon, 21 Feb 2022 19:13:28 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.1
Subject: Re: [XEN v8 2/2] xen/arm64: io: Support instructions (for which ISS
 is not valid) on emulated MMIO region using MMIO/ioreq handler
To: Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>,
 xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com,
 bertrand.marquis@arm.com
References: <20220212233433.46018-1-ayankuma@xilinx.com>
 <20220212233433.46018-3-ayankuma@xilinx.com>
 <1599e2f3-0a34-020a-dd42-5ba87dad555d@xen.org>
 <10cf253b-fc58-1afc-66ec-33ac3008bb0f@xilinx.com>
 <576cf522-f002-afac-36b6-b31f87724dca@xen.org>
 <e53b1407-4701-f0f1-5f49-5bd8cbb6eb41@xilinx.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <e53b1407-4701-f0f1-5f49-5bd8cbb6eb41@xilinx.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit



On 21/02/2022 19:05, Ayan Kumar Halder wrote:
> If we (ie Xen) didn't decode the instruction manually, then check_p2m() 
> has not been invoked yet.  This is because of the following 
> (info.dabt.valid == True) :-
> 
>          if ( !is_data || !info.dabt.valid )
>          {
> 
>                  ...
> 
>                  if ( check_p2m(is_data, gpa) )
>                      return;
> 
>                  ...
> 
>          }
> 
> So, in this scenario ( !info.dabt.valid), it would not be necessary to 
> invoke check_p2m() after try_handle_mmio().
> 
> However, if we havenot decoded the instruction manually (ie 
> info.dabt.valid == True), and try_handle_mmio() returns IO_UNHANDLED, 
> then it will be necessary to invoke "check_p2m(is_data, gpa)"

Hmmm you are right. But this doesn't seem to match the code you wrote 
below. What did I miss?

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Feb 21 19:21:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 21 Feb 2022 19:21:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276426.472581 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMEFG-0000pk-T9; Mon, 21 Feb 2022 19:21:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276426.472581; Mon, 21 Feb 2022 19:21:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMEFG-0000pd-Pa; Mon, 21 Feb 2022 19:21:14 +0000
Received: by outflank-mailman (input) for mailman id 276426;
 Mon, 21 Feb 2022 19:21:13 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=fvXl=TE=citrix.com=prvs=044a77a3b=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nMEFF-0000pX-Gh
 for xen-devel@lists.xenproject.org; Mon, 21 Feb 2022 19:21:13 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6c572ccc-934b-11ec-8539-5f4723681683;
 Mon, 21 Feb 2022 20:21:11 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6c572ccc-934b-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645471271;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=uC0klHGT1wqSFpZrvxVI5rezQHtLRZtM72M9KVBJbGg=;
  b=dLDRZEeLSNmdwFyQ7Q01CVqnuQTmsktIl5pJNxtMYdQYDBnKMGRe3vJG
   wNcEeEjvUtZ+02PJVjqLhjW6sjMrjqQ7iJSTQ1nwmVtio02USaCxsFFN/
   kvUR7FOrTZE50iscVUVubyC1vYd2CKFnrkEhL1TULIAZoP7djZu9iK+8Y
   8=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 66916276
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:dpkYDaLD3d0hZW+DFE+RxJUlxSXFcZb7ZxGr2PjKsXjdYENSgzUEz
 GIWWGmHa/6JZjegKItxPdvk/U9Uv8DUydY1TVZlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA180IMsdoUg7wbRh2NQx2YLR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 NwKlLm+cAECBPSPv7stUBN+EWJEPaITrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBODtMJkSpTdLyjbBAOx9aZvCX7/L9ZlT2zJYasVmQ6iPP
 pRDNmQHgBLoXkNyIlUyDKICgPaxiyHjcRxbjFSEqv9ii4TU5FMoi+W8WDbPQfSaSMMQkkuGq
 2bu+2XiHgpcJNGZ0SCC8H+nmqnIhyyTcIAdDrqj7dZxnUaegGcUDXU+V1G2vP24gU6WQM9EJ
 gof/S9GkEQp3BX1FJ+nBUT++SPa+E5HMzZNLwEkwAjK64/a2gCyPDFHaWFxa9YAtowMRTN/g
 zdlgOjVLTBotbSUT1eU+bGVsS6+NEApEIMSWcMXZVBbuoe++enfmjqKF48+S/Dt0rUZDBmtm
 2jikcQou1kEYSfnPY2f9EuPvT+jr4OhouUdtlSOBTLNAu+UieeYi22UBbrzsKwowGWxFADpU
 J04dy+2tr1mMH11vHbRKNjh5Znwjxp/DBXSgER0A74q/Cm39niocOh4uW8ieRw5bpdZKGKzM
 Sc/XD+9A7cJYROXgVJfOdrtW6zGM4C7fTgaahwkRoUXOcUgHON21CpveVSRzwjQfLsEyskC1
 WOgWZ/0Vx4yUP0/pBLvHrt1+eJ7l0gWmDKILbimnkvP7FZrTCPMIVvzGADVNb5RAWLtiFi9z
 uuzwOPQlU0ECbWmOnO/HEx6BQliEEXXzKve8qR/XuWCPhBnCCcmDfrQyqkmYItrg+JekeKgw
 513chYwJIbX7ZEfFTi3Vw==
IronPort-HdrOrdr: A9a23:dNwuVKzcVXyr8Q5ItM1dKrPxjOskLtp133Aq2lEZdPULSKKlfp
 GV88jziyWZtN9IYgBdpTiBUJPwJU81bfZOkMcs1MSZLXbbUQyTXcBfBOrZsnLd8kjFl9K1up
 0QC5SWZOeAb2SSyPyKnTVQcOxQgOVvkprY/ts2pk0FJWoBBsEQjDuRSDzraHGeLDM2X6bRf6
 Dsgfav0gDQAEj/Gf7LYEXtMdKzwuHjpdbDW1orFhQn4A6BgXeD87jhCSWV2R8YTndm3aoi2X
 KtqX272oyT99WAjjPM3W7a6Jpb3PH7zMFYOcCKgs8Jbh3xlweTYph7UbHqhkF2nAjv0idurD
 D/mWZmAy1B0QKWQohzm2q15+DU6kdr15Yl8y7BvZKsm72jeNtwMbs+uWsQSGqp16NnhqAg7E
 sD5RPri3IcZymw7BjV9pzGUQpnmVGzpmdnmekPj2ZHWY9bc7NJq5cDlXklWqvoMRiKoLzPKt
 MeR/00JcwmBm+yfjTcpC1i0dasVnM8ElOPRVUDoNWc13xTkGpix0UVycQDljNYnahNB6Vs9q
 DBKOBlhbtORsgZYeZ0A/oAW9K+DijITQjXOGyfLFz7HOUMOm7LqZTw/LIpjdvaNaAg3d83gt
 DMQVlYvWk9dwbnDtCPxoRC9lTXTGC0TV3Wu4hjDlhCy8vBrZbQQFi+oQoV4rmdSt0kc7nmZ8
 o=
X-IronPort-AV: E=Sophos;i="5.88,386,1635220800"; 
   d="scan'208";a="66916276"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=j1AXjqzLtz1gmGKS4e2UYBsOFP4fWs43qlH3pUGiEN1Y27r9cUjwdnc9WLx8NgZEEFicz0TPqF/sT+cfq7JcM4TrvUGb5DnHE0c7Y3Ffiy5HwoYt7inLZB+21/c80gHyH0rTMtzOzPSXc7gBa/9dJLjtUNBfenD4BpGHeZyD4in/CZmYCAQot3gIws2dcOVMfR/uzV+dDNxxc4GHZSux5ePs0PffNE74LRNOrg3KV5jXhzlvYUzThOl3Evq8ni0lTM9jemRPfejLLI4eq5Ke0aTJ80O6MRPjhi4hlH+ouek+r62WHrIl0f86Z9FTk6g7t84Tdb7bExSUFsC7KkeM6A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=uC0klHGT1wqSFpZrvxVI5rezQHtLRZtM72M9KVBJbGg=;
 b=gbw1eBP74IUdYikXPY1aLQ5M/6du6bg28ckdx5QsDGza+VRW9tO+EN0ecbv2NU0fhMrMwWzGwPs1wnolbI57zKh3k6h6OXjdOSJkoS4lK/C4GUKn7N5sBwNc2j/k1GvVJ294DxAVzYEzt0S/VetgIyr6RfPKQt+ebvEBqhPUb4VGehPyifSy25ZXmrgngC2UAvnBKFsf6dm5KdKQX2hGP9vMDd4ykAXgyBXZ2IgpnBLYlLJ0dmtnnYl9b25COa9SydC0GfkrcXlGDmjY2bEW23m6L4uATqsz8D28eTK0RaCG4d2Un7pdZSUiWTGkqANn3FxANuURIbXGSDYTMk8u+A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=uC0klHGT1wqSFpZrvxVI5rezQHtLRZtM72M9KVBJbGg=;
 b=PxQAvGiD69y0Ks5SnWFdR5MqXP2KwE7eC+uFOmOkYExc+wWE9X7VKCEZRIRr+4J5eHCXHRcyfBSM9ks4DbiwKzyFqGFaAGEICXH4OV28qWZRVjnmjQu0X4wlHnmWpxQYgy43zyxMGjr+wrpDmdgK1hZcW8Uq40ql9uND3bCxMnc=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Juergen Gross <jgross@suse.com>, Xen-devel
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2 04/70] x86/pv-shim: Don't modify the hypercall table
Thread-Topic: [PATCH v2 04/70] x86/pv-shim: Don't modify the hypercall table
Thread-Index: AQHYIaGhGuRO8pqNlkK4xub7I1FLsayTC50AgAAE4YCAAAF7gIADsLoAgADKGoCABuBFAA==
Date: Mon, 21 Feb 2022 19:21:04 +0000
Message-ID: <f1a3e319-4810-49eb-7ae0-a044499e85a1@citrix.com>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
 <20220214125127.17985-5-andrew.cooper3@citrix.com>
 <4d8ab414-caf4-5a12-4cb7-a88c633cfd66@suse.com>
 <e18c0c5a-d00b-adf9-d4b0-28e702a18241@srcf.net>
 <6566bf52-58da-f804-f5c2-fca64c1f150c@suse.com>
 <f0889e93-aec0-443e-b3fc-081892edaf2b@citrix.com>
 <44e0ab16-e807-c8f5-deef-7094b7aecdeb@suse.com>
In-Reply-To: <44e0ab16-e807-c8f5-deef-7094b7aecdeb@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: ed3851b4-dfc3-47cf-3ed2-08d9f56f4deb
x-ms-traffictypediagnostic: SN4PR03MB6781:EE_
x-microsoft-antispam-prvs: <SN4PR03MB6781625FC64589AAB385C97BBA3A9@SN4PR03MB6781.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: LMOj0WprIAGDyf9ztQYHeTsE6Uq8+ayRV/AfswIOdzFi96o5UTFKm5kVys4S+kqx0dBQXEnCgY8jV2Ppm5cdcyHgVPy5kfZSCouZ4luNe5vkRWy3v7KBHeZwmEdSkrLV0Og7YK2y9BUjt9qtTL9X6hRNp4BQNIzQF4J7KYfoySp2G3Y2IIy9Y5BnbTxw93eUp9Yk/XPh7DjyQV0UOJy9sDwlywNuT76JwYYmbK6iKSbVchfwcqUCycxrPLMftgXCmQTwDmhZlHcd0mUaky5mzdkkSvylgs5j6o6KcZkSSUN+BsAjNfwPIbOk/qGLBStl52sqWZZPwfz+XggqMAHsuAwF7urVD/2T13dH4+tiwfR2Xf+LrDg2mmph6WBkX6ypogWi8SN+WswrAdGB9iYgiCP/qLGIgNY41PdHlMOVEFsV2TsJxpXaYIyeP+5ujgDx3GZ7ZS/tu5VnHC8YZeZp0tXnLcdi04O8xYyerWkyN95pDVLe0GyxIApSFHtkIwZKvT6qz4pM3ko0gnwCij/ThY1vhHKbGAx9Omt9Lw2wRDbPCyarJk8dBHbB9PDCEZMVrBdNvg/UDmuUI3ed5lizqKkxBzYtvteKGjX1P+Fj9Zq9iLA7pf9hPxiUxMMmZQBWo1bTITRSZDxd2afUn8ZQ2RHCw7jCMRdOnqO0B+3SViEAwLydefP9+9E/pUY7eVh9DG9PjAhNKr3sclpbZ5yBz5OAEVgbBwcjGFbfr9T0LKZc+OioC9Mh4uQbJHgBVuWMNxSsS46sFNuOKvx1y2mKZQ==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(31686004)(53546011)(2616005)(6486002)(26005)(38070700005)(316002)(6916009)(54906003)(186003)(66574015)(6506007)(6512007)(91956017)(36756003)(8936002)(76116006)(66476007)(66446008)(66946007)(66556008)(82960400001)(38100700002)(4326008)(83380400001)(122000001)(71200400001)(86362001)(31696002)(508600001)(5660300002)(8676002)(2906002)(64756008)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?YlhYWHJURXVhWDRIWngvcjZGb2pDLzdNU1Iwbk85UWxLM1p1dk5FNGFsRjhK?=
 =?utf-8?B?MGdsK3RwOER6WFMrT0dXUEJGbEVlblN4NkVkd0Q3WTRZc3NBMHA4TTMrSUVw?=
 =?utf-8?B?QlFSOHIzeTlYamFXMmk1akdzWkp6WWJuU2VoS3ZKT2tFeEVpcjBWWDFQN3BI?=
 =?utf-8?B?NWR4RUVEVy94akJTZVU1MERpUE9NQk04TERnZ2hmNi91VlhTOGNDTStNcTMv?=
 =?utf-8?B?MHpOYXVFOXlvcFNrcVRaN1haeHU2eUhBVFdnb0xscEJzRXJJVGFFRWFGS1ZR?=
 =?utf-8?B?OTZyQ2hMY0dVL3JhSllBTFpMTVoycDNmWmo5UjZ4MDZRWE5ETU5ENGVjMW93?=
 =?utf-8?B?Q0ZSRmtNeWp3UnRLTDdPLzl6bldLRkdHY0xGWVFZc2V3UDVwM0M3QmFmbFlZ?=
 =?utf-8?B?SzdkTGs0Y28ralZncGdUZ0VhYkxHdmZRUXhYTUhkTGJ1SVVPVnc3VGZ0VmFC?=
 =?utf-8?B?bWxQeTR1aHczRy92dTE1SW9QTmJ0aUk2MnBxV3BNOFhCMmt2Y3ArVFJzajR0?=
 =?utf-8?B?VHlOdFVjd1AreGJmdGYwQUdXL0JqWTJkRGIzWEZWMmg4NGp0MllWRjUyN3BK?=
 =?utf-8?B?VGg4S3ZmVzF2Mm03MjkvK0tqVUQ2SzI3elgvTk9jd2xZcUtNRW80Z0FhLzZE?=
 =?utf-8?B?U1dVMFBRQ3NHU3pPS1F5MGdGY1JZNXlJOERmQSttMldLM2s1dHJTOVFLZkNi?=
 =?utf-8?B?bHdMam5Lc0tnQzZPSC81U3V3NUtWS2FkdndYVktMNytHbDc4QURDMjRSOTM3?=
 =?utf-8?B?U1RBdHU2MENUNWlWL04zRXcwV2FnNFpEaTdXUnFMZW5QWUU4K3Bpb1NHY3Nn?=
 =?utf-8?B?b2NHWUVWcHUzTXJ1UU5tdEc4ZmFXL0tnZFZGNmRpOEhkWHRuT3VaeHpTTnlw?=
 =?utf-8?B?eHZqa3hEZXNsQWxPbVNIU1hZeFYyKzRVTlBhUjltZ0diTEVxRlNFazgySmlM?=
 =?utf-8?B?MEtvMk1FaUQvVUVqdG10QXh3U3h6c2xwblZsQndROUJVU2JuZDg3TFpRTmJJ?=
 =?utf-8?B?NnZ0RERsUmV2Q3dMZkdNNTlEY3RpeGorcmpZTnZER0VqYjdxLytvamtaOGE3?=
 =?utf-8?B?ZDBSdG4yVnh2ZmlIcTVBbkZCNzhOb25OaExUYnpKalBlWUIrcFJDR2JuQzdY?=
 =?utf-8?B?elpzT1FGSlhzTXpSM1l3SGhCdE9YZjRjNG5UTzdzckQrbTU2S1Y2SmVCU1lR?=
 =?utf-8?B?cUpCTnpIbkJKYk5YMnJaazJMd0Y4aFloc09IM0I1aUJhMmphdGxGd1Eycmhx?=
 =?utf-8?B?bnZtdWhkVXc2di85QzRHd3piUXpDSjBhN0xYMklaQnJ1Zm5idVFENEpLQ0ZE?=
 =?utf-8?B?dUtvK0ZYdlNMMnhCeHVIbHlzTE5xb1RuMXE1YUpFcmo5TzBvczRCTmQrYUN2?=
 =?utf-8?B?TzNKbjJhUFJ5VFk0N3dNZEFaanJPZGdGS1p2RHAvNG9SYTQzQURNQkR5ZW00?=
 =?utf-8?B?OHpGWVhHRWFIZDlMTytUQXdiZXlzeEk4R0Q3ellkNDJvVElYQ2tiNE11cDBC?=
 =?utf-8?B?ZVI5VCt2TmdvekhmcWR1R3N0SmhrSEZMQ1VqK0ROdVJxUVhDNktmRk4vM3ZC?=
 =?utf-8?B?bGx4Tmc0NEt2NHhRQ2lKcFB4TkV1YVBheGQ0anFscERuS1phU3ZuNjhOZHdh?=
 =?utf-8?B?UW9xWHdXc0tha0RGQlpPOXk2b3JyYXRBYysrQitLcHdzRW9oT3ZDU3JabHl6?=
 =?utf-8?B?TWREbWlhTmFmM3liZzZmbjRmcVVqcGpCSzJlYmtkdk5uQnNsZmw1M094MG5L?=
 =?utf-8?B?WFQyZ29JUXNkdDgzMGFZNmM3NVdzdnpIWkt3ZkUyazhnc29BZVZuTk9YdytE?=
 =?utf-8?B?K2xlSTdvS2krZlhnNjEvQ3JRbVpjUWllSk0vVU5nd0tiUlpPU0p2ZGtucWJm?=
 =?utf-8?B?djVNQ3hBc1BCTGNMczYzcXhrSmNNZkYzaE1jU0ZBTFJqeWw1cWg5TDN2TXN3?=
 =?utf-8?B?ODlBa2Y0ZEVOMTBERm9JMjY5UndvTk00S0FrVUVwbklyZWN2NE85eW5iSkRI?=
 =?utf-8?B?T0syQWxmY000cG94cFBETnhUV1Z6ZDcxNDVwd3pVWXZkYWpicjhrcTRqeXVO?=
 =?utf-8?B?TCtTY3M1Nmh6S3RZaGlKZXJ2TkVDdlozc1FBOHV1NE1zeXg0ZUN3bGtGRndG?=
 =?utf-8?B?bTFwVWJtZXlyNFFWKzJJV09rcG95b2ErdEpWajhZOE5NSE1PWDc2YVNrQlhU?=
 =?utf-8?B?ZGJWQUQ1NnVHQlp0SUNvazFEM2pKQXdjbnBxelhnM20xa3F5VFVlOGdqYW5S?=
 =?utf-8?B?TTlIdTlMdXMya0tndmJlRUorazh3PT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <79562BDB795EF74491B522A7C0F4E7EC@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ed3851b4-dfc3-47cf-3ed2-08d9f56f4deb
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Feb 2022 19:21:04.6448
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: y75dAZD0SmmIMU5lr67vEGOFeomJVmHqH/yZlV+9/WFtHpqc4Vxuh+tt/DC8+dek7L29WHGPfr6TbY/OfaHUjxSxIz13m2AowudmbB7UvrI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR03MB6781
X-OriginatorOrg: citrix.com

T24gMTcvMDIvMjAyMiAxMDoyMCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDE2LjAyLjIwMjIg
MjM6MTcsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBPbiAxNC8wMi8yMDIyIDEzOjU2LCBKYW4g
QmV1bGljaCB3cm90ZToNCj4+PiBPbiAxNC4wMi4yMDIyIDE0OjUwLCBBbmRyZXcgQ29vcGVyIHdy
b3RlOg0KPj4+PiBPbiAxNC8wMi8yMDIyIDEzOjMzLCBKYW4gQmV1bGljaCB3cm90ZToNCj4+Pj4+
IE9uIDE0LjAyLjIwMjIgMTM6NTAsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+Pj4+Pj4gRnJvbTog
SnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPg0KPj4+Pj4+DQo+Pj4+Pj4gV2hlbiBydW5u
aW5nIGFzIHB2LXNoaW0gdGhlIGh5cGVyY2FsbCBpcyBtb2RpZmllZCB0b2RheSBpbiBvcmRlciB0
bw0KPj4+Pj4+IHJlcGxhY2UgdGhlIGZ1bmN0aW9ucyBmb3IgX19IWVBFUlZJU09SX2V2ZW50X2No
YW5uZWxfb3AgYW5kDQo+Pj4+Pj4gX19IWVBFUlZJU09SX2dyYW50X3RhYmxlX29wIGh5cGVyY2Fs
bHMuDQo+Pj4+Pj4NCj4+Pj4+PiBDaGFuZ2UgdGhpcyB0byBjYWxsIHRoZSByZWxhdGVkIGZ1bmN0
aW9ucyBmcm9tIHRoZSBub3JtYWwgaGFuZGxlcnMNCj4+Pj4+PiBpbnN0ZWFkIHdoZW4gcnVubmlu
ZyBhcyBzaGltLiBUaGUgcGVyZm9ybWFuY2UgaW1wbGljYXRpb25zIGFyZSBub3QNCj4+Pj4+PiBy
ZWFsbHkgcmVsZXZhbnQsIGFzIGEgbm9ybWFsIHByb2R1Y3Rpb24gaHlwZXJ2aXNvciB3aWxsIG5v
dCBiZQ0KPj4+Pj4+IGNvbmZpZ3VyZWQgdG8gc3VwcG9ydCBzaGltIG1vZGUsIHNvIHRoZSByZWxh
dGVkIGNhbGxzIHdpbGwgYmUgZHJvcHBlZA0KPj4+Pj4+IGR1ZSB0byBvcHRpbWl6YXRpb24gb2Yg
dGhlIGNvbXBpbGVyLg0KPj4+Pj4+DQo+Pj4+Pj4gTm90ZSB0aGF0IGZvciB0aGUgQ09ORklHX1BW
X1NISU1fRVhDTFVTSVZFIGNhc2UgdGhlcmUgaXMgYSBkdW1teQ0KPj4+Pj4+IHdyYXBwZXIgZG9f
Z3JhbnRfdGFibGVfb3AoKSBuZWVkZWQsIGFzIGluIHRoaXMgY2FzZSBncmFudF90YWJsZS5jDQo+
Pj4+Pj4gaXNuJ3QgYmVpbmcgYnVpbHQuDQo+Pj4+Pj4NCj4+Pj4+PiBTaWduZWQtb2ZmLWJ5OiBK
dWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+DQo+Pj4+Pj4gU2lnbmVkLW9mZi1ieTogQW5k
cmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4NCj4+Pj4+IEkgZG9uJ3QgdGhp
bmsgeW91IHN5bmMtZWQgdGhpcyB3aXRoIErDvHJnZW4ncyB2My4gVGhlcmUgd2VyZSBvbmx5IG1p
bm9yDQo+Pj4+PiBjaGFuZ2VzIGJ1dCBoYXZpbmcgYSBzdGFsZSB2ZXJzaW9uIHNlbnQgdHdvIG1v
bnRocyBsYXRlciBpc24ndCB2ZXJ5DQo+Pj4+PiBuaWNlLg0KPj4+PiBJIGRpZCByZXN5bmMuwqAg
V2hhdCBkbyB5b3UgdGhpbmsgaXMgbWlzc2luZz8NCj4+PiBBIGZldyBsaWtlbHkoKSAvIHVubGlr
ZWx5KCkgYXMgZmFyIGFzIEkgY291bGQgc2VlLg0KPj4gT2ggdGhvc2UgdHdvLsKgIEkgYXBwZWFy
IHRvIGhhdmUgZm9yZ290IHRvIGVtYWlsLg0KPj4NCj4+IFRoZXkncmUgd3JvbmcgLSBvYnNlcnZl
IHRoZXkncmUgaW4gYW4gaWZuZGVmIGJsb2NrLCBub3QgYW4gaWZkZWYgYmxvY2suwqANCj4gSSBk
b24ndCBzZWUgaG93IHRoZSAodW5yZWxhdGVkKSAjaWZuZGVmIG1hdHRlcnMgaGVyZTogVGhlICNp
Zm5kZWYNCj4gaXMgYWJvdXQgZ3JhbnQgdGFibGUgYXZhaWxhYmlsaXR5LiBUaGUgdHdvIGxpa2Vs
eSgpIGFyZSBhYm91dA0KPiBydW5uaW5nIGFzIHNoaW0uIEknbSBvZiB0aGUgZmlybSBvcGluaW9u
IHRoYXQgYSBiaW5hcnkgYnVpbHQNCj4gd2l0aG91dCBQVl9TSElNX0VYQ0xVU0lWRSBpcyBmYXIg
bW9yZSBsaWtlbHkgdG8gYmUgdXNlZCBhcyBhIGJhcmUNCj4gbWV0YWwgaHlwZXJ2aXNvci4gQW5k
IGZvciBhIFBWX1NISU1fRVhDTFVTSVZFIGh5cGVydmlzb3IgdGhlDQo+IGNvbmRpdGlvbnMgYXJl
IGNvbnN0YW50IGFueXdheSwgYW5kIGhlbmNlIHRoZSB1bmxpa2VseSgpIGhhcyBubw0KPiBlZmZl
Y3QuDQo+DQo+IEFuZCBpZiB5b3VyIHdheSBzaG91bGQgcmVhbGx5IGJlIGZvbGxvd2VkLCB3aHkg
ZGlkIHlvdSBkZWVtIHRoZSB0d28NCj4gdW5saWtlbHkoKSBpbiBkb19ldmVudF9jaGFubmVsX29w
KCkgYW5kIGRvX2dyYW50X3RhYmxlX29wKCkgb2theT8NCg0KQmVjYXVzZSB0aG9zZSBhcmUgYXQg
bGVhc3Qgbm90IGluY29ycmVjdC7CoCAoSSBzdGlsbCB0aGluayB3ZSBoYXZlIGZhcg0KdG9vIG1h
bnkgYW5ub3RhdGlvbnMsIGFuZCBJIGRvdWJ0IHRoZXkncmUgYWxsIGhlbHBmdWwuKQ0KDQpUaGUg
Z250dGFiIHN0dWJzIGluIHRoZSAhR05UVEFCIGNhc2UgZXhpc3Qgc3RyaWN0bHkgZm9yIGNvbXBp
bGUgdGVzdHMNCih0aGVyZSdzIG5vIHN1Y2ggdGhpbmcgYXMgYSBwcm9kdWN0aW9uIGJ1aWxkIG9m
IFhlbiB3aXRob3V0IGdyYW50DQp0YWJsZXMpIGFuZCBQVl9TSElNX0VYQ0xVU0lWRSBidWlsZHMu
DQoNCkNvZGUgbGF5b3V0IG9ubHkgbWF0dGVycyBmb3IgY2FzZXMgd2hlcmUgd2UncmUgZXhlY3V0
aW5nIGNvZGUsIHdoaWNoIGlzDQp0aGUgUFYgU2hpbSBjYXNlLCBhdCB3aGljaCBwb2ludCB0aGUg
Y29uZGl0aW9uIGlzIGNvbnN0YW50IGFuZCBkb2Vzbid0DQpnZW5lcmF0ZSBhIGJyYW5jaC4NCg0K
QSBjb21waWxlciBvdWdodCB0byByYWlzZSBhIHdhcm5pbmcgb24gZmluZGluZyB0aGF0IF9fYnVp
bHRpbl9leHBlY3QoKQ0KaGFzIGEgY29uc3RhbnQgcGFyYW1ldGVyLCBiZWNhdXNlIGl0J3MgYSBu
b3AgaW4gb25lIGNhc2UsIGFuZA0KZGVtb25zdHJhYmx5IGZhbHNlIGluIHRoZSBvdGhlci4NCg0K
QXMgZm9yIHRoZSBmdW5jdGlvbiBpbiBxdWVzdGlvbiwgdGhlIGNvbXBpbGVkIHJlc3VsdCBpcyBh
biB1bmNvbmRpdGlvbmFsDQp0YWlsY2FsbCB0byBwdl9zaGltX2dyYW50X3RhYmxlX29wLg0KDQp+
QW5kcmV3DQo=


From xen-devel-bounces@lists.xenproject.org Mon Feb 21 21:11:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 21 Feb 2022 21:11:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276441.472615 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMFxf-000339-UH; Mon, 21 Feb 2022 21:11:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276441.472615; Mon, 21 Feb 2022 21:11:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMFxf-000332-R5; Mon, 21 Feb 2022 21:11:11 +0000
Received: by outflank-mailman (input) for mailman id 276441;
 Mon, 21 Feb 2022 21:11:10 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Nr+1=TE=xilinx.com=ayankuma@srs-se1.protection.inumbo.net>)
 id 1nMFxe-00032w-BT
 for xen-devel@lists.xenproject.org; Mon, 21 Feb 2022 21:11:10 +0000
Received: from NAM12-MW2-obe.outbound.protection.outlook.com
 (mail-mw2nam12on2061a.outbound.protection.outlook.com
 [2a01:111:f400:fe5a::61a])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c84c8e6b-935a-11ec-8eb8-a37418f5ba1a;
 Mon, 21 Feb 2022 22:11:07 +0100 (CET)
Received: from SN4PR0401CA0041.namprd04.prod.outlook.com
 (2603:10b6:803:2a::27) by BYAPR02MB5112.namprd02.prod.outlook.com
 (2603:10b6:a03:70::21) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.16; Mon, 21 Feb
 2022 21:11:02 +0000
Received: from SN1NAM02FT0037.eop-nam02.prod.protection.outlook.com
 (2603:10b6:803:2a:cafe::a2) by SN4PR0401CA0041.outlook.office365.com
 (2603:10b6:803:2a::27) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.14 via Frontend
 Transport; Mon, 21 Feb 2022 21:11:02 +0000
Received: from xir-pvapexch02.xlnx.xilinx.com (149.199.80.198) by
 SN1NAM02FT0037.mail.protection.outlook.com (10.97.4.243) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.4975.11 via Frontend Transport; Mon, 21 Feb 2022 21:11:01 +0000
Received: from xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) by
 xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2176.14; Mon, 21 Feb 2022 21:11:00 +0000
Received: from smtp.xilinx.com (172.21.105.197) by
 xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server id
 15.1.2176.14 via Frontend Transport; Mon, 21 Feb 2022 21:11:00 +0000
Received: from [10.71.117.142] (port=64147)
 by smtp.xilinx.com with esmtp (Exim 4.90)
 (envelope-from <ayan.kumar.halder@xilinx.com>)
 id 1nMFxT-0005TE-A9; Mon, 21 Feb 2022 21:10:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c84c8e6b-935a-11ec-8eb8-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=DJLpS6Yp5u5MhjWcSevWaMXOO8CU4DWH2VrnvGcs3XjPfhcBNmCRNIToFS5tLTiFr4w1+NIumVM0L4RWzecMThhQaUvyAai3TD2hdQFa56TA+LO8odMR6BZ0quKYGsDvIIo5ETR8RdVugA8ONkgFqHxbWL2GSNpgr/BzThH62IHIp1wjPtLlMD9Y7akkpB7D7reP2Sd9y2dc8QFa2n6oatWXhZETA0CmdmzafyKBuefVeQiVRMr76XTP7W9+ydOYL2d+eLb1QsstYb03oNF1Jh91bB8MkOnsPuYGSb5J2uynyEkU7DszZZ/AyVLsDr8c1fL8lbVURbcU8QII4c68VA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=gyMlo1JhMjgqSNxGOR52Qwwlj25T+FEOQ6sZi1F/wSE=;
 b=NLpEnWzAy3OW8NCu9WgDV/RAIjIP+VRWjQr7O3PkVOJjxkLrRvN2cZ6FZNaDbbC7mxmPW0qqZMQhmdUe5b8i/MqulCQ12+x0lKcZzku1+54i4TlbF0YT88H1+VvCIPKkbMhr4YIDLT0mMJO5PgIiejmvFpZTPIH/fNzlZAdoIgiLN+/hniQ71cXupmXHmmKpaUkW7TFdofXukKikNFGOKY4WDoR93RF4vK4m84ut6YDjJVsnQur5eFXkyLDX/jsQ1X6x3hnWulgccHorcWseuTdTU5gjj2XIMwfpKdH3FKyewc/upqLrVGgsCRcW9kUrVZIFsXT0CACZmSM8e9bDng==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 149.199.80.198) smtp.rcpttodomain=xen.org smtp.mailfrom=xilinx.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=gyMlo1JhMjgqSNxGOR52Qwwlj25T+FEOQ6sZi1F/wSE=;
 b=nPgLDwU+SemsM6U1IXwQRw4Oiee8fdQn/LmZG0oe1Wen/MAP4EXVouffGtw86+B4c96YC1ZfEa+QGzGU2sphzEozaiVVLN8DyL4f9zAVxQxIX32XDgbDrDEXYlWHs7NNWWImcpzLtwBAj1M9ecw+Zae7CRK3/GCeolV227yo0wk=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198)
 smtp.mailfrom=xilinx.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=xilinx.com;
Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates
 149.199.80.198 as permitted sender) receiver=protection.outlook.com;
 client-ip=149.199.80.198; helo=xir-pvapexch02.xlnx.xilinx.com;
Message-ID: <8c45a34c-9e54-1a9b-d894-f05f41412657@xilinx.com>
Date: Mon, 21 Feb 2022 21:10:58 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.0
Subject: Re: [XEN v8 2/2] xen/arm64: io: Support instructions (for which ISS
 is not valid) on emulated MMIO region using MMIO/ioreq handler
To: Julien Grall <julien@xen.org>, Ayan Kumar Halder
	<ayan.kumar.halder@xilinx.com>, <xen-devel@lists.xenproject.org>
CC: <sstabellini@kernel.org>, <stefanos@xilinx.com>,
	<Volodymyr_Babchuk@epam.com>, <bertrand.marquis@arm.com>
References: <20220212233433.46018-1-ayankuma@xilinx.com>
 <20220212233433.46018-3-ayankuma@xilinx.com>
 <1599e2f3-0a34-020a-dd42-5ba87dad555d@xen.org>
 <10cf253b-fc58-1afc-66ec-33ac3008bb0f@xilinx.com>
 <576cf522-f002-afac-36b6-b31f87724dca@xen.org>
 <e53b1407-4701-f0f1-5f49-5bd8cbb6eb41@xilinx.com>
 <96610d30-0de2-96e9-e838-504acf83a8d8@xen.org>
From: Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>
In-Reply-To: <96610d30-0de2-96e9-e838-504acf83a8d8@xen.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ff5120ef-308e-4d00-05e3-08d9f57eaa09
X-MS-TrafficTypeDiagnostic: BYAPR02MB5112:EE_
X-Microsoft-Antispam-PRVS:
	<BYAPR02MB51127F6EB407DA225690C4F8B23A9@BYAPR02MB5112.namprd02.prod.outlook.com>
X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	lHYS7x1RqKOEA8TUYnJdydqWNrp9DGLHoxOIj2qkNeXC4HQt4L2rZh1TTycGeYaSsj8xyzcTt3T/FG+31o7oH4HsZ8MprEZSwQUxBBh4w5tgKMkAT/Pw3NsneoJvnpiQpRHPGbCyaEgRNzpn1zydpg3hw8tXMpxJN2O/4CVdfhR/VKdGVkU5mfxcYHsobJY50W2e+NNHDETwovdsho9TExgm534AF/iS6tJKp7hU9aG05/7GwFxueCGFN9oAEODFVOESYKUdvIsgScgnurbRgV2Xo0WQ937UkA+H3sbN/n5q41+P/LCFq4zUxtLXnEm70nSsZ4XNRys6kReXnECkZAlalPVwGSyFw11s1y7UMrc6hQIP92+5kuHv8GgdlLCQLpzW0h15mZNabTkJ6O8AOeTSToRc/vOvnF3U1GG2C2JLBN6CLFe4FyFunRKEW6gS17B+SSr5yOsNE2w0D3y2GAaSyVDVJ6nCtrGHPSRkQ8hBoQxCURVfa02ep/sBTpARCrpcKGRdAv3dRy0jbSm5MVOb8NZT6j57FBys7cJETI9ZMWqDtky1ZfGOBlNm3BJBmlCWNBE5RlclwLG9iOFTsqst+aXIveBkcVcSiVU/6GMvdixHEEVgt+UBSlWsJKNBnQQO7dCnZBBoKRtn84cl/BFW+5Cv//T5JzCSg0eLhkNpcWueM4Z//pKPJ8dArxkodh0v68gD+7ur/BuM/p1OyQ==
X-Forefront-Antispam-Report:
	CIP:149.199.80.198;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:xir-pvapexch02.xlnx.xilinx.com;PTR:unknown-80-198.xilinx.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(31696002)(2906002)(356005)(26005)(186003)(31686004)(47076005)(54906003)(110136005)(9786002)(7636003)(8936002)(36756003)(82310400004)(316002)(36860700001)(508600001)(2616005)(5660300002)(53546011)(8676002)(426003)(4326008)(70206006)(70586007)(336012)(50156003)(43740500002);DIR:OUT;SFP:1101;
X-OriginatorOrg: xilinx.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2022 21:11:01.4226
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: ff5120ef-308e-4d00-05e3-08d9f57eaa09
X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.80.198];Helo=[xir-pvapexch02.xlnx.xilinx.com]
X-MS-Exchange-CrossTenant-AuthSource:
	SN1NAM02FT0037.eop-nam02.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR02MB5112

Hi Julien,

On 21/02/2022 19:13, Julien Grall wrote:
>
>
> On 21/02/2022 19:05, Ayan Kumar Halder wrote:
>> If we (ie Xen) didn't decode the instruction manually, then 
>> check_p2m() has not been invoked yet.  This is because of the 
>> following (info.dabt.valid == True) :-
>>
>>          if ( !is_data || !info.dabt.valid )
>>          {
>>
>>                  ...
>>
>>                  if ( check_p2m(is_data, gpa) )
>>                      return;
>>
>>                  ...
>>
>>          }
>>
>> So, in this scenario ( !info.dabt.valid), it would not be necessary 
>> to invoke check_p2m() after try_handle_mmio().
>>
>> However, if we havenot decoded the instruction manually (ie 
>> info.dabt.valid == True), and try_handle_mmio() returns IO_UNHANDLED, 
>> then it will be necessary to invoke "check_p2m(is_data, gpa)"
>
> Hmmm you are right. But this doesn't seem to match the code you wrote 
> below. What did I miss?

My code was not correct.  I have rectified it as below. Please let me 
know if it looks sane.

<snip>

     case FSC_FLT_TRANS:
     {
         info.gpa = gpa;
         info.dabt = hsr.dabt;

         /*
          * Assumption :- Most of the times when we get a data abort and 
the ISS
          * is invalid or an instruction abort, the underlying cause is 
that the
          * page tables have not been set up correctly.
          */
         if ( !is_data || !info.dabt.valid )
         {
             if ( check_p2m(is_data, gpa) )
                 return;

             /*
              * If the instruction abort could not be resolved by 
setting the
              * appropriate bits in the translation table, then Xen should
              * forward the abort to the guest.
              */
             if ( !is_data )
                 goto inject_abt;

             try_decode_instruction(regs, &info);

             /*
              * If Xen could not decode the instruction or encountered 
an error
              * while decoding, then it should forward the abort to the 
guest.
              */
             if ( info.dabt_instr.state == INSTR_ERROR )
                 goto inject_abt;
         }

         state = try_handle_mmio(regs, &info);

         switch ( state )
         {
             case IO_ABORT:
                 goto inject_abt;
             case IO_HANDLED:
                 /*
                  * If the instruction was decoded and has executed 
successfully
                  * on the MMIO region, then Xen should execute the next 
part of
                  * the instruction. (for eg increment the rn if it is a
                  * post-indexing instruction.
                  */
                 post_increment_register(&info.dabt_instr);
                 advance_pc(regs, hsr);
                 return;
             case IO_RETRY:
                 /* finish later */
                 return;
             case IO_UNHANDLED:
                 /* IO unhandled, try another way to handle it. */
                 break;
         }

         /*
          * If the instruction was valid but Xen could not emulate the 
instruction
          * then it should configure the page tables to set the correct 
page table
          * entry corresponding to the faulting address. If it was 
successful, it
          * should return to the guest to retry the instruction (hoping 
that the
          * instruction will not be trapped to Xen again).
          * However, if Xen was not successful in setting the page 
tables, then
          * it should forward the abort to the guest.
          */
         if ( info.dabt.valid && check_p2m(is_data, gpa) )
             return;

         break;
     }
     default:

<snip>

- Ayan

>
> Cheers,
>


From xen-devel-bounces@lists.xenproject.org Tue Feb 22 00:16:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 00:16:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276449.472627 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMIqG-0003JA-Rx; Tue, 22 Feb 2022 00:15:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276449.472627; Tue, 22 Feb 2022 00:15:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMIqG-0003J3-O6; Tue, 22 Feb 2022 00:15:44 +0000
Received: by outflank-mailman (input) for mailman id 276449;
 Tue, 22 Feb 2022 00:15:43 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=AYeZ=TF=invisiblethingslab.com=marmarek@srs-se1.protection.inumbo.net>)
 id 1nMIqE-0003Ix-Ts
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 00:15:43 +0000
Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com
 [64.147.123.20]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8f161849-9374-11ec-8eb8-a37418f5ba1a;
 Tue, 22 Feb 2022 01:15:40 +0100 (CET)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.46])
 by mailout.west.internal (Postfix) with ESMTP id EFD5E32020A4;
 Mon, 21 Feb 2022 19:15:34 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163])
 by compute2.internal (MEProxy); Mon, 21 Feb 2022 19:15:35 -0500
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon,
 21 Feb 2022 19:15:32 -0500 (EST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8f161849-9374-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-type:date:date:from:from
	:in-reply-to:in-reply-to:message-id:mime-version:references
	:reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy
	:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=rc93G4/qTvE1ZYiC5
	yWr1O2C0TkaoFvvFLrkTcp0OiU=; b=Y69o6eJC81KbBulRopMzp6lUJuZ9AISxP
	+1QcRCFA2Lymy2SX6QdNNij+bpUKjLI7JY4jk6B+bsTE4uvRYLBtYJQVtWxLXOF7
	MC7BrgMjs73uOxKJd9JXq/llwO7LemYllNLWxpBII5AYt1DEKRPBJVbzniAl47EV
	I9+klBHWuuqK0ub/hUfvoMiMtMxtH8+AXU2eUhu1qnegNWweYwBpOLP94gcFk3Ed
	/xZmjxfMLtm6ggHg69s6N6iJbAvkHiohXHuNcbXTJ0JCAuGZGUMILtklyzt0pOtX
	cCF3DmjcxDKdnzI5Gl1lgGvALIo1R+JX0RkT5U6LWasdG37Dbrdqw==
X-ME-Sender: <xms:JisUYrJ7-Kx2Gz-DcSLX6JUni2MkM8yWYJQp4AoCgn2hvNSgKKT9zA>
    <xme:JisUYvKy_JBBMxZSyUGE4ic2Ird8J5qQ0NkL0YVsZKDDDDr5YdhauOPKZEfTegD1y
    GXHtTTeqwQ4Cw>
X-ME-Received: <xmr:JisUYjv11Y6MM_noDbeYIUb00bL2l060gnp-_P2lzYgS7yb48dKXZo_tsjqwkhStKt7m7VELWr2YvwyH0hCdhxXSpyzovDUyiw>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrkeejgddvtdcutefuodetggdotefrodftvf
    curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
    uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
    fjughrpeffhffvuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrrhgvkhcu
    ofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinhhvih
    hsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepteevffei
    gffhkefhgfegfeffhfegveeikeettdfhheevieehieeitddugeefteffnecuvehluhhsth
    gvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghrvghksehi
    nhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh
X-ME-Proxy: <xmx:JisUYkbYs4yRQDuWPVpdWhTz-QMKtlgY3G4siF3Azf63M4nIiJq4Rg>
    <xmx:JisUYia-rc0nv9Ddr695FsbNsEykqpokrW3ZBB2ZlTMV7xRwvbrssA>
    <xmx:JisUYoC2vmtUkDy87UAuKxSdgXE1Y-PGs7AKNdt35uk5T5MudK5U5A>
    <xmx:JisUYq7doJGgZO5OJpN9rhB7hPF6DYbyZo9JLQQtjrg4kaKuGWyz8w>
Date: Tue, 22 Feb 2022 01:15:29 +0100
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: Juergen Gross <jgross@suse.com>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Antoine Tenart <atenart@kernel.org>,
	"moderated list:XEN HYPERVISOR INTERFACE" <xen-devel@lists.xenproject.org>,
	"open list:NETWORKING DRIVERS" <netdev@vger.kernel.org>
Subject: Re: [PATCH] xen/netfront: destroy queues before real_num_tx_queues
 is zeroed
Message-ID: <YhQrIWyJ4hhEVVNb@mail-itl>
References: <20220220134202.2187485-1-marmarek@invisiblethingslab.com>
 <3786b4ef-68e7-5735-0841-fcbae07f7e54@suse.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="+tkBggBQeIzPYW+u"
Content-Disposition: inline
In-Reply-To: <3786b4ef-68e7-5735-0841-fcbae07f7e54@suse.com>


--+tkBggBQeIzPYW+u
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Tue, 22 Feb 2022 01:15:29 +0100
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: Juergen Gross <jgross@suse.com>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Antoine Tenart <atenart@kernel.org>,
	"moderated list:XEN HYPERVISOR INTERFACE" <xen-devel@lists.xenproject.org>,
	"open list:NETWORKING DRIVERS" <netdev@vger.kernel.org>
Subject: Re: [PATCH] xen/netfront: destroy queues before real_num_tx_queues
 is zeroed

On Mon, Feb 21, 2022 at 07:27:32AM +0100, Juergen Gross wrote:
> I checked some of the call paths leading to xennet_close(), and all of
> those contained an ASSERT_RTNL(), so it seems the rtnl_lock is already
> taken here. Could you test with adding an ASSERT_RTNL() in
> xennet_destroy_queues()?

Tried that and no issues spotted.

> In case your test with the added ASSERT_RTNL() doesn't show any
> problem you can add my:
>=20
> Reviewed-by: Juergen Gross <jgross@suse.com>

Thanks.

--=20
Best Regards,
Marek Marczykowski-G=C3=B3recki
Invisible Things Lab

--+tkBggBQeIzPYW+u
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmIUKyEACgkQ24/THMrX
1yzoYwf9Gx9pcUVHvqm8ndGiV2gIwVCSdgcmDurruCiP0HW8l4A1u6WAWRPs1qRH
ZBdfn5OSBZwFZu0tVetXVnmWmMAKjqWAHNIF+DlptXue1GzEMa8QIy3NA5iplpOc
E4xTNf2rn4tEhz4lunfATqTeLKtju19I0w8CD/szjq5CcqOTyHbOV5PodTF2ZdhY
yAxGB/KTZUROG+8+orCaqmv9RTe0nob293WI8FpAGr4+QowJKuTsygIX+tryKzIA
2baSea6s+ZjOg0d4NSGSEbU9u8o0NibNiiuT5cAVRHVkVpUNwn4bs3H7K7P25fZe
RrtbyZfzDTeTV5TfKUQwWl9q6tORaw==
=Kebw
-----END PGP SIGNATURE-----

--+tkBggBQeIzPYW+u--


From xen-devel-bounces@lists.xenproject.org Tue Feb 22 00:18:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 00:18:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276456.472638 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMIsy-0003u1-9E; Tue, 22 Feb 2022 00:18:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276456.472638; Tue, 22 Feb 2022 00:18:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMIsy-0003tu-5s; Tue, 22 Feb 2022 00:18:32 +0000
Received: by outflank-mailman (input) for mailman id 276456;
 Tue, 22 Feb 2022 00:18:31 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=AYeZ=TF=invisiblethingslab.com=marmarek@srs-se1.protection.inumbo.net>)
 id 1nMIsx-0003tm-Nf
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 00:18:31 +0000
Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com
 [64.147.123.20]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f5889189-9374-11ec-8539-5f4723681683;
 Tue, 22 Feb 2022 01:18:30 +0100 (CET)
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44])
 by mailout.west.internal (Postfix) with ESMTP id 7647D3200E18;
 Mon, 21 Feb 2022 19:18:27 -0500 (EST)
Received: from mailfrontend1 ([10.202.2.162])
 by compute4.internal (MEProxy); Mon, 21 Feb 2022 19:18:28 -0500
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon,
 21 Feb 2022 19:18:25 -0500 (EST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f5889189-9374-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-transfer-encoding
	:content-type:date:date:from:from:in-reply-to:message-id
	:mime-version:reply-to:sender:subject:subject:to:to:x-me-proxy
	:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=V9Y0aM
	UYHoxDUjucoxLUoyDrdDFBnSbiTwU4Pu0uuFw=; b=Lk7v6cS86buxdL8uLglrJ8
	gc9GPXof0oIZU84PNZS0mRqvfXb64ccuVy9qySymDTnYJcySt/ZwrRz0HTeVk1CR
	l61CGJ2G87b0Pmmse9ZprfW4w2/RH/6jCsvVm61jxpFdSGc5RjuFjUeL2rNr5RDd
	ulmpGv/OUnMLQSxHyTbIRZStwuzcYkBsljArWHqMossMrQZUttPK/t2pHvrOjPuy
	6E1VIMgHN8sQnTbsOHtm6FuwU4Zxeh//vY9jr50+jJCSvZYMn7ouk1S09tIEsv0S
	YSaXnVWcxH0WIEAPaz0ZMsMN6fbmZ49DeZHEVxgKSVw9CR8N5QcZdtFF1lVZnadQ
	==
X-ME-Sender: <xms:0isUYhajOZif2OF11acXMQugW-NrH2b_uuhjTeHOte1ytVDE7J4LdA>
    <xme:0isUYoZQTk298bz6NhkJeJo7nh3pTWf_TqtPCeZqxGMcAvB8nZC98OnBF8stf414H
    _ra65IIJq8Q9g>
X-ME-Received: <xmr:0isUYj8Fma0A7ZZPlTu5Ohh-ivjB3OnThldADd9LeVck_MhkjSXkkBpMPGxEEqz1v9r9EtbJM8gDo4y_gW_AN_BwPIglIc29MWH1z2mccvDVaoiFxpg>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrkeejgddvtdcutefuodetggdotefrodftvf
    curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
    uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
    fjughrpefhvffufffkofggtghogfesthekredtredtjeenucfhrhhomhepofgrrhgvkhcu
    ofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinhhvih
    hsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhephefhfeet
    ueelvddvtedttdevieeluedtvedtfeejieelhedutdeuheduieejgfegnecuffhomhgrih
    hnpehkvghrnhgvlhdrohhrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhep
    mhgrihhlfhhrohhmpehmrghrmhgrrhgvkhesihhnvhhishhisghlvghthhhinhhgshhlrg
    gsrdgtohhm
X-ME-Proxy: <xmx:0isUYvpB1SHuZaVw5a9ZhadbYdSGae9vJeyV7K4x5gcIdddd6wJkkQ>
    <xmx:0isUYsp3z9sEfUZi6pmTXeG08t01qdZBkrZQzYGtyGS0gnvDoqmjNg>
    <xmx:0isUYlQZFBhIIe7JTbGpftfH5DnpbHB-9W_VdhqSgmxKUVbwYd-ktw>
    <xmx:0ysUYkIIpexJHEw0wIokCFdZ7Y1kjK8qUNuZ1i1wytH5LTyJUaaMIw>
From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: linux-kernel@vger.kernel.org
Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>,
	stable@vger.kernel.org,
	Michael Brown <mcb30@ipxe.org>,
	Wei Liu <wei.liu@kernel.org>,
	Paul Durrant <paul@xen.org>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	xen-devel@lists.xenproject.org (moderated list:XEN NETWORK BACKEND DRIVER),
	netdev@vger.kernel.org (open list:XEN NETWORK BACKEND DRIVER)
Subject: [PATCH v2 1/2] Revert "xen-netback: remove 'hotplug-status' once it has served its purpose"
Date: Tue, 22 Feb 2022 01:18:16 +0100
Message-Id: <20220222001817.2264967-1-marmarek@invisiblethingslab.com>
X-Mailer: git-send-email 2.31.1
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Organization: Invisible Things Lab
Content-Transfer-Encoding: 8bit

This reverts commit 1f2565780e9b7218cf92c7630130e82dcc0fe9c2.

The 'hotplug-status' node should not be removed as long as the vif
device remains configured. Otherwise the xen-netback would wait for
re-running the network script even if it was already called (in case of
the frontent re-connecting). But also, it _should_ be removed when the
vif device is destroyed (for example when unbinding the driver) -
otherwise hotplug script would not configure the device whenever it
re-appear.

Moving removal of the 'hotplug-status' node was a workaround for nothing
calling network script after xen-netback module is reloaded. But when
vif interface is re-created (on xen-netback unbind/bind for example),
the script should be called, regardless of who does that - currently
this case is not handled by the toolstack, and requires manual
script call. Keeping hotplug-status=connected to skip the call is wrong
and leads to not configured interface.

More discussion at
https://lore.kernel.org/xen-devel/afedd7cb-a291-e773-8b0d-4db9b291fa98@ipxe.org/T/#u

Cc: stable@vger.kernel.org
Signed-off-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
---
Cc: Michael Brown <mcb30@ipxe.org>
Changes in v2:
 - build fix, reported by kernel test robot <lkp@intel.com>

---
 drivers/net/xen-netback/xenbus.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/xen-netback/xenbus.c b/drivers/net/xen-netback/xenbus.c
index d24b7a7993aa..3fad58d22155 100644
--- a/drivers/net/xen-netback/xenbus.c
+++ b/drivers/net/xen-netback/xenbus.c
@@ -256,6 +256,7 @@ static void backend_disconnect(struct backend_info *be)
 		unsigned int queue_index;
 
 		xen_unregister_watchers(vif);
+		xenbus_rm(XBT_NIL, be->dev->nodename, "hotplug-status");
 #ifdef CONFIG_DEBUG_FS
 		xenvif_debugfs_delif(vif);
 #endif /* CONFIG_DEBUG_FS */
@@ -675,7 +676,6 @@ static void hotplug_status_changed(struct xenbus_watch *watch,
 
 		/* Not interested in this watch anymore. */
 		unregister_hotplug_status_watch(be);
-		xenbus_rm(XBT_NIL, be->dev->nodename, "hotplug-status");
 	}
 	kfree(str);
 }
-- 
2.31.1



From xen-devel-bounces@lists.xenproject.org Tue Feb 22 00:18:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 00:18:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276457.472648 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMIt1-0004Ak-HC; Tue, 22 Feb 2022 00:18:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276457.472648; Tue, 22 Feb 2022 00:18:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMIt1-0004Ab-E9; Tue, 22 Feb 2022 00:18:35 +0000
Received: by outflank-mailman (input) for mailman id 276457;
 Tue, 22 Feb 2022 00:18:34 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=AYeZ=TF=invisiblethingslab.com=marmarek@srs-se1.protection.inumbo.net>)
 id 1nMIsz-0003tm-Vs
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 00:18:34 +0000
Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com
 [64.147.123.20]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f79df940-9374-11ec-8539-5f4723681683;
 Tue, 22 Feb 2022 01:18:33 +0100 (CET)
Received: from compute3.internal (compute3.nyi.internal [10.202.2.43])
 by mailout.west.internal (Postfix) with ESMTP id EC12B32020A4;
 Mon, 21 Feb 2022 19:18:30 -0500 (EST)
Received: from mailfrontend1 ([10.202.2.162])
 by compute3.internal (MEProxy); Mon, 21 Feb 2022 19:18:31 -0500
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon,
 21 Feb 2022 19:18:28 -0500 (EST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f79df940-9374-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-transfer-encoding
	:content-type:date:date:from:from:in-reply-to:in-reply-to
	:message-id:mime-version:references:reply-to:sender:subject
	:subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
	:x-sasl-enc; s=fm2; bh=XmMT3EWtd+ciLfBzi+9TAwPbS18Eh5Hhy+YbNx2fX
	t0=; b=ClWyCP3Q0+m9yPFE7QpnuAWSp8luBTmJ3dLZy+53AyJh/Zew6r3VyamYI
	iIhemKxWThFxC9kjEGU4HTzWxms0kukrEJ21uNabiUgyw1CWTJB8I6V/Yajjg6aG
	gJi1YtMtbrm7sM9Erce+fv++TOxyyHvQDRqtgOQNB2w83NYj3DclV9DMyMOCCNsa
	4yZATPgb5G4jVwJtkfCtvFQN8JEHz6vt+tTs7J7HHu4aWtEHEEHMcn3ZO+9kB5jW
	VrLEjdY0doKSnZi71hE3tknHK7T/mwblYjPTeOwZu4g4jwtWSHWbG6ogEAKC9u+4
	UhNrMNXlgXOqMVRm3xFGpr2MkjzXA==
X-ME-Sender: <xms:1isUYnp-l1g2xVkAWM45cpnGjhFq1lLPA09vmSVMt2qLjxxAx_ooAQ>
    <xme:1isUYhqSkIDI7-B35lBCLYjTC-Cw6TELhPgxRZZL-Pc4HLqKzPRDwSojxmpyhwMVW
    zz5gQTN5jjdhA>
X-ME-Received: <xmr:1isUYkPpKdTxiNAu3PorE0HL9L-j9eE5zP6qjiW4hrnn84tT2QJrJW3wokxTjfxJcXz6ROhhMzcKZq9450PHhG5fGbMIESBVseNv8Z3x4rf6mvaZ-5g>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrkeejgddvtdcutefuodetggdotefrodftvf
    curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
    uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
    fjughrpefhvffufffkofgjfhggtghogfesthekredtredtjeenucfhrhhomhepofgrrhgv
    khcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinh
    hvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepffdt
    uefffeduhfelueegvdetheejvdehteelfeetfeekgfekkefggedtgefhieejnecuffhomh
    grihhnpehkvghrnhgvlhdrohhrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgr
    mhepmhgrihhlfhhrohhmpehmrghrmhgrrhgvkhesihhnvhhishhisghlvghthhhinhhgsh
    hlrggsrdgtohhm
X-ME-Proxy: <xmx:1isUYq7vEWZ-SE0XIvbz58gerzXTrCf3BlDiqPoxqk8ZPfjUnpgIjA>
    <xmx:1isUYm4lpafkKQCw-Ua0K26waSc4wfUPKHHETM0uuInsy1-cCGoHfg>
    <xmx:1isUYihgQCeVDr3-kAq_Mk3RudqD2Gr_o3pFtlkIFlymhmvjfN4pMQ>
    <xmx:1isUYtbWCqyVYZH2lMGASRpooP3YL8N-JPeOpnkdvnTqBcODn-1uRw>
From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: linux-kernel@vger.kernel.org
Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>,
	stable@vger.kernel.org,
	Michael Brown <mcb30@ipxe.org>,
	Wei Liu <wei.liu@kernel.org>,
	Paul Durrant <paul@xen.org>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	xen-devel@lists.xenproject.org (moderated list:XEN NETWORK BACKEND DRIVER),
	netdev@vger.kernel.org (open list:XEN NETWORK BACKEND DRIVER)
Subject: [PATCH v2 2/2] Revert "xen-netback: Check for hotplug-status existence before watching"
Date: Tue, 22 Feb 2022 01:18:17 +0100
Message-Id: <20220222001817.2264967-2-marmarek@invisiblethingslab.com>
X-Mailer: git-send-email 2.31.1
In-Reply-To: <20220222001817.2264967-1-marmarek@invisiblethingslab.com>
References: <20220222001817.2264967-1-marmarek@invisiblethingslab.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Organization: Invisible Things Lab
Content-Transfer-Encoding: 8bit

This reverts commit 2afeec08ab5c86ae21952151f726bfe184f6b23d.

The reasoning in the commit was wrong - the code expected to setup the
watch even if 'hotplug-status' didn't exist. In fact, it relied on the
watch being fired the first time - to check if maybe 'hotplug-status' is
already set to 'connected'. Not registering a watch for non-existing
path (which is the case if hotplug script hasn't been executed yet),
made the backend not waiting for the hotplug script to execute. This in
turns, made the netfront think the interface is fully operational, while
in fact it was not (the vif interface on xen-netback side might not be
configured yet).

This was a workaround for 'hotplug-status' erroneously being removed.
But since that is reverted now, the workaround is not necessary either.

More discussion at
https://lore.kernel.org/xen-devel/afedd7cb-a291-e773-8b0d-4db9b291fa98@ipxe.org/T/#u

Cc: stable@vger.kernel.org
Signed-off-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
---
I believe this is the same issue as discussed at
https://lore.kernel.org/xen-devel/20220113111946.GA4133739@dingwall.me.uk/
Cc: James Dingwall <james-xen@dingwall.me.uk
Cc: Michael Brown <mcb30@ipxe.org>
---
 drivers/net/xen-netback/xenbus.c | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/drivers/net/xen-netback/xenbus.c b/drivers/net/xen-netback/xenbus.c
index 3fad58d22155..990360d75cb6 100644
--- a/drivers/net/xen-netback/xenbus.c
+++ b/drivers/net/xen-netback/xenbus.c
@@ -824,15 +824,11 @@ static void connect(struct backend_info *be)
 	xenvif_carrier_on(be->vif);
 
 	unregister_hotplug_status_watch(be);
-	if (xenbus_exists(XBT_NIL, dev->nodename, "hotplug-status")) {
-		err = xenbus_watch_pathfmt(dev, &be->hotplug_status_watch,
-					   NULL, hotplug_status_changed,
-					   "%s/%s", dev->nodename,
-					   "hotplug-status");
-		if (err)
-			goto err;
+	err = xenbus_watch_pathfmt(dev, &be->hotplug_status_watch, NULL,
+				   hotplug_status_changed,
+				   "%s/%s", dev->nodename, "hotplug-status");
+	if (!err)
 		be->have_hotplug_status_watch = 1;
-	}
 
 	netif_tx_wake_all_queues(be->vif->dev);
 
-- 
2.31.1



From xen-devel-bounces@lists.xenproject.org Tue Feb 22 00:23:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 00:23:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276472.472659 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMIy4-0005wm-8b; Tue, 22 Feb 2022 00:23:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276472.472659; Tue, 22 Feb 2022 00:23:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMIy4-0005wf-5g; Tue, 22 Feb 2022 00:23:48 +0000
Received: by outflank-mailman (input) for mailman id 276472;
 Tue, 22 Feb 2022 00:23:47 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nMIy3-0005wV-4V; Tue, 22 Feb 2022 00:23:47 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nMIy2-0003OB-Te; Tue, 22 Feb 2022 00:23:46 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nMIy2-0002G3-C4; Tue, 22 Feb 2022 00:23:46 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nMIy2-00080y-Bb; Tue, 22 Feb 2022 00:23:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=SumYfNdGCl3ueVRa739UPAtex2thfD6ZXCu/SwgVB+w=; b=Aw4mtqmFsPiTGPn0RhZ/F8rK45
	AQ7ro6WyIMjqUPDLu8yY+bX7sR6JT/aSyn3u6v+Uu+CXJ2H8y0m4GJ0XWLPqRg5VMgNWWrqyggycD
	i3mgD+krW9HZnCDhqjYA/APyV6wsijKdv/1onkaQ9AhhQEuJ/+ANQRNNVa26OVZex414=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168186-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 168186: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=477c3b934a47adf7de285863f59d6e4503dd1a6d
X-Osstest-Versions-That:
    qemuu=e670f6d825d4dee248b311197fd4048469d6772b
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 22 Feb 2022 00:23:46 +0000

flight 168186 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168186/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168180
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168180
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168180
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168180
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168180
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168180
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168180
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168180
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                477c3b934a47adf7de285863f59d6e4503dd1a6d
baseline version:
 qemuu                e670f6d825d4dee248b311197fd4048469d6772b

Last test of basis   168180  2022-02-20 22:09:39 Z    1 days
Testing same since   168186  2022-02-21 17:36:59 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Akihiko Odaki <akihiko.odaki@gmail.com>
  Alexander Graf <agraf@csgraf.de>
  Ani Sinha <ani@anisinha.ca>
  Bernhard Beschow <shentey@gmail.com>
  Corey Minyard <cminyard@mvista.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Patrick Venture <venture@google.com>
  Pavel Dovgalyuk <Pavel.Dovgalyuk@ispras.ru>
  Peter Maydell <peter.maydell@linaro.org>
  Philippe Mathieu-Daudé <f4bug@amsat.org>
  Roman Bolshakov <r.bolshakov@yadro.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   e670f6d825..477c3b934a  477c3b934a47adf7de285863f59d6e4503dd1a6d -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Tue Feb 22 00:56:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 00:56:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276483.472671 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMJTc-0000mQ-UB; Tue, 22 Feb 2022 00:56:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276483.472671; Tue, 22 Feb 2022 00:56:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMJTc-0000mJ-Pn; Tue, 22 Feb 2022 00:56:24 +0000
Received: by outflank-mailman (input) for mailman id 276483;
 Tue, 22 Feb 2022 00:56:23 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nMJTb-0000m9-Jv; Tue, 22 Feb 2022 00:56:23 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nMJTb-00045w-Hw; Tue, 22 Feb 2022 00:56:23 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nMJTb-0003CD-6o; Tue, 22 Feb 2022 00:56:23 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nMJTb-0001Lx-6Q; Tue, 22 Feb 2022 00:56:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ek9W3IXSf0xh5Q0UAKWGZ2FMQKJEU1lxeFW3u694Dus=; b=ClsMomrSc4AbGaX4UrSEOD5pEA
	guWt9MovPHrSqY2xn0KF9Syhj7VwvG8/twWSCz6HjyD9aqcmDmiE8aetsrTbK6ssrPaRi1jx0RzP6
	NylkuhsKN8RNc5Bt9Vpspst630DlXfdqxrv3hAcoopFlKs15PUQm4dV0i5WDn4LaYrRQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168188-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 168188: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=95d9ab46143685f169f636cfdd7997e2fc630e86
X-Osstest-Versions-That:
    xen=686f13cfce1d95464ff39fb59ac1f85163cea03b
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 22 Feb 2022 00:56:23 +0000

flight 168188 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168188/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  95d9ab46143685f169f636cfdd7997e2fc630e86
baseline version:
 xen                  686f13cfce1d95464ff39fb59ac1f85163cea03b

Last test of basis   168167  2022-02-18 19:01:37 Z    3 days
Testing same since   168188  2022-02-21 21:01:44 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Roger Pau Monne <roger.pau@citrix.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   686f13cfce..95d9ab4614  95d9ab46143685f169f636cfdd7997e2fc630e86 -> smoke


From xen-devel-bounces@lists.xenproject.org Tue Feb 22 05:15:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 05:15:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276495.472682 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMNVu-0001ii-K8; Tue, 22 Feb 2022 05:15:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276495.472682; Tue, 22 Feb 2022 05:15:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMNVu-0001ia-DG; Tue, 22 Feb 2022 05:15:02 +0000
Received: by outflank-mailman (input) for mailman id 276495;
 Tue, 22 Feb 2022 05:15:00 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nMNVs-0001h7-Fy; Tue, 22 Feb 2022 05:15:00 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nMNVs-0003JB-Cv; Tue, 22 Feb 2022 05:15:00 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nMNVr-0003zO-LX; Tue, 22 Feb 2022 05:14:59 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nMNVr-0003wD-JO; Tue, 22 Feb 2022 05:14:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=QbGjmlk6Mzp+GbCPp///MA44Bt042D0eza6K0kZLe+Y=; b=Spy32hgmC0ZE0Kz0acxwO9lUKo
	QCjHOzvKEergctKN/ikZnLaXfk+VW7YW1FounuikOpjrP6/ReLU7SvvGX2f7en3mPNiZUulSHiJ/0
	dwumjkwaMQu83jhKPQWeJMbQ95AXs1VdfRF0C7mwV8wnj9ZaEucgFLEH/JfwQAgwWqYY=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168187-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 168187: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=038101e6b2cd5c55f888f85db42ea2ad3aecb4b6
X-Osstest-Versions-That:
    linux=cfb92440ee71adcc2105b0890bb01ac3cddb8507
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 22 Feb 2022 05:14:59 +0000

flight 168187 linux-linus real [real]
flight 168190 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/168187/
http://logs.test-lab.xenproject.org/osstest/logs/168190/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 168190-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168183
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168183
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168183
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168183
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168183
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168183
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168183
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168183
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                038101e6b2cd5c55f888f85db42ea2ad3aecb4b6
baseline version:
 linux                cfb92440ee71adcc2105b0890bb01ac3cddb8507

Last test of basis   168183  2022-02-21 02:00:50 Z    1 days
Testing same since   168187  2022-02-21 17:39:52 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Daniel Scally <djrscally@gmail.com>
  Hans de Goede <hdegoede@redhat.com>
  Linus Torvalds <torvalds@linux-foundation.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   cfb92440ee71..038101e6b2cd  038101e6b2cd5c55f888f85db42ea2ad3aecb4b6 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Tue Feb 22 07:07:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 07:07:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276509.472693 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMPGm-0003mp-Qc; Tue, 22 Feb 2022 07:07:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276509.472693; Tue, 22 Feb 2022 07:07:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMPGm-0003mi-Mk; Tue, 22 Feb 2022 07:07:32 +0000
Received: by outflank-mailman (input) for mailman id 276509;
 Tue, 22 Feb 2022 07:07:31 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=IN1Y=TF=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1nMPGl-0003mc-A0
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 07:07:31 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id 185f2d44-93ae-11ec-8eb8-a37418f5ba1a;
 Tue, 22 Feb 2022 08:07:29 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F0D1B1063;
 Mon, 21 Feb 2022 23:07:27 -0800 (PST)
Received: from [10.57.3.116] (unknown [10.57.3.116])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A924D3F70D;
 Mon, 21 Feb 2022 23:07:26 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 185f2d44-93ae-11ec-8eb8-a37418f5ba1a
Subject: Re: [PATCH] xen/arm: Rename psr_mode_is_32bit to regs_mode_is_32bit
To: Julien Grall <julien@xen.org>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <20220221105931.12028-1-michal.orzel@arm.com>
 <1531f49d-c74c-8a41-a917-cfe76bee8e7d@xen.org>
From: Michal Orzel <michal.orzel@arm.com>
Message-ID: <05b5877b-7dc0-3d35-f073-5721e1605321@arm.com>
Date: Tue, 22 Feb 2022 08:07:19 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <1531f49d-c74c-8a41-a917-cfe76bee8e7d@xen.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

Hi Julien,

On 21.02.2022 16:58, Julien Grall wrote:
> Hi Michal,
> 
> On 21/02/2022 10:59, Michal Orzel wrote:
>> Following a discussion [1] it seems like that renaming work has
>> been forgotten. 
> 
> This is in my todo list of clean-up I need to do for Xen. But I haven't yet had a chance to look at it. Thank you for taking a look!
> 
>> Perform renaming of psr_mode_is_32bit to
>> regs_mode_is_32bit as the function no longer takes psr parameter.
> 
> If we modify psr_mode_is_32bit(), then we should also modify psr_mode_is_user() because they have the same prototype and we should keep the naming consistent.
> 
Ok, I agree. Do you think this should be done in a separate patch?
FWICS, psr_mode_is_user is used in traps.c, vcpreg.c ,vtimer.c and vsysreg.c whereas psr_mode_is_32bit - only in traps.c.

>>
>> [1] https://marc.info/?l=xen-devel&m=156457538423787&w=2
> 
> NIT: The first sentence and this link adds value for the review on the mailing list (we know where the request came from) but doesn't add any after the commit message (there are no extra information in them).
> 
> So I would move this information after ---. This will get dropped on commit.
> 
Ok.
> Cheers,
> 

Cheers,
Michal


From xen-devel-bounces@lists.xenproject.org Tue Feb 22 08:32:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 08:32:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276525.472704 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMQaa-0004KG-7E; Tue, 22 Feb 2022 08:32:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276525.472704; Tue, 22 Feb 2022 08:32:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMQaa-0004K9-3t; Tue, 22 Feb 2022 08:32:04 +0000
Received: by outflank-mailman (input) for mailman id 276525;
 Tue, 22 Feb 2022 08:32:03 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=4CiU=TF=citrix.com=prvs=045c9559e=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nMQaY-0004K3-Rw
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 08:32:03 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e27d2683-93b9-11ec-8539-5f4723681683;
 Tue, 22 Feb 2022 09:31:54 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e27d2683-93b9-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645518717;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=8ECoz0hKxN6wB0prEA2JUvM7foOV7eNJF7DEQ1CBcPo=;
  b=F/CugjqP+fOhInPXv82/DTwlQUW8hyyLLav4iixD26A1Vn2qgSKWLD8v
   XBH99Y+kDcpP/k+nd3OQCnQvw/wwxzgB3Y3tlFDCZVgYoxWGmB0Vc1TyW
   /oU8wenqu4x4+eZqI9LbqMmMPW6H+mY+Jk6cqR811jb0dFySkhhnWQEB1
   s=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 64703492
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:1dA6L6JS5VF33+6hFE+Rb5UlxSXFcZb7ZxGr2PjKsXjdYENS0DQCn
 WJMD2yHb6mLZmOjctB1Pojg8UNUvZKHz4Q1TgJlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA180IMsdoUg7wbRh2NQy2YLR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 Mty6LqpdSUAB5zzsr4bD15oOSBEF5QTrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBNPsM44F/Glp0BnSDOo8QICFSKLPjTNd9Gls2ZgVQaeED
 yYfQQFUdimHejRAAxAwA4gsnue6lGfWKTIN/Tp5ooJoujOOnWSdyoPFPNPLd9miScxLk0Oco
 WzauWL0HnkyLNWCzRKV/3TqgfXA9Qv4RYgbPL617PhnhBuU3GN7IBsbSVe2v9GnhUOkHdFSM
 UoZ/mwpt6da3FymSJzxUgO1pFaAvwUAQJxAHusi8gaPx6HIpQGDCQAsSj9Hdcxjt8IsQzEu/
 kGGksmvBjF1trCRD3WH+d+8qDqoPCEPIGwqZCkaTBAE6d3uvIEyiB3USt9pVqWyi7XdAi35y
 TSHhDYxiq9VjsMR0ai/u1fdjFqEuZXICAo0+y3UU3ij4wc/Y5SqD6St4lKAtd5BNJaUCF6bs
 xA5d9O2tb5US8vXzWrUHbtLTOrBC+u53CP0n2EyOYAd1R2UykGJJ4YMpwFUJX1DC5NREdP2W
 3P7tQRU7Z5VGXKla65rfo68Y/gXIbjc+cfNDa6NMIcXCnRlXErepXw1OxbMt4z4uBV0yckC1
 YGnndFA5JrwIYBu13KISugUytfHLQhulDqIFfgXI/lKuIdyhUJ5q59YaDNijchjtctoRTk5F
 f4FbKNmLD0FDYXDjtH/q9J7ELzzBSFT6WrKg8JWbPWfBQFtBXssDfTcqZt4JdA4w/oEy7qSo
 ijlMqO99LYZrSecQeltQio+AI4DoL4l9S5rVcDSFQzAN4cfjXaHs/5EKspfkUgP/+1/1/9kJ
 8TpiO3basmjvg/vomxHBbGk9dQKXE3y2WqmYnr0CBBiLsUIb1GYpbfZkv7HqXBm4tyf7pBl/
 dVNF2rzHPI+euiVJJyIMKn2lwvp5xDwWotaBiP1HzWaQ221mKBCIC3tlP4nZcYKLBTI3DyB0
 AiKRxwfoIHwT0Udq4ehaXysx2txL9ZDIw==
IronPort-HdrOrdr: A9a23:fm6rjKhLHOF8QC3j4ROq6RqHqHBQXt4ji2hC6mlwRA09TyX+rb
 HIoB17726RtN91YhodcL+7VJVoLUmyyXcX2+ks1NWZMjUO0VHAROsO0WKI+VzdMhy72ulB1b
 pxN4hSYeeAaGSSVPyKgzVQxexQouW6zA==
X-IronPort-AV: E=Sophos;i="5.88,387,1635220800"; 
   d="scan'208";a="64703492"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cRA8TnYsZFZsJj9VD5at8Znpn1W1EGg0YE+MmUBQFvyfcHx5i77+Mlhlh0dzZp3mYwWo75YEbQ/z9K6qNur5LwrGZGb9bK34A5meOEtxrlNOZQ9Hh7GiVgxGdClxyUCYEWI1SUwtpHMBDBmee1p0oKGhng1WwV0gksOzE6weKfwfBVvi+YA0uuUOPtNQ3IaiuPMfJ6zhk53F2fhTk4lEgPWwRK1JDZhAhD0AL1WQOD+imFiPAEV8En1po6zUIod8g8+CpvhAZvD4cLgHZGlCBirjdA/RAzaJ3Mf1m36O0XmU70erTEj546WGBI/fsCKxl6FGSCpjJCjBMYJshz2NeA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=vE18hdZ9uVAnGW50XqiQx6/cqbsWACrD6meOYQdWLa8=;
 b=iSkkgr0dJJgtJz2/CzKnmzUKyNwHYOg7UTAAAQDZiszYcXLaWMX8lBfccHqisn1+R6DiBIPloB5lEtxFgUsorEfIHallqnOytqZDHIEpuPzES3Jj2jmU1pnHsDEs/x6XaCXF32tCW46cSmoc6y939eRIHvSTtm5f7axla5lGuR+j4doPEY/H1LHLp6WFU+9DlNd18XzbND9YfrKS49uMMse/H5E/ZNfIhLUEa8kqxM0sDFEWwRFSOJsLRN6fDhJJ6y9oDC714ZPPqX5J6CuTLBeIDErgA2+A0XdK8LJHUwUShKJCfdw5uuq128NGkOKhJu5J4q3BNCE83CEmPiDsiQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=vE18hdZ9uVAnGW50XqiQx6/cqbsWACrD6meOYQdWLa8=;
 b=xDOJD/pggOWKI2RhnfMs/AreKM6V+cZtBwn0R1YuLT8h+xC77aEgnTjFQiAWEB9UWsb9RIMBZ2mL1hp8PrOLvyd/Cej1CNIFYfMQ03nzODnxBEa8Uyp9+8PvO3jNDcw9SviEWDfk4pxIxJ/k+k96YTGVaNDjQsZBVPMhFTF1gO8=
Date: Tue, 22 Feb 2022 09:31:31 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?=
	<marmarek@invisiblethingslab.com>
CC: <linux-kernel@vger.kernel.org>, <stable@vger.kernel.org>, Michael Brown
	<mcb30@ipxe.org>, Wei Liu <wei.liu@kernel.org>, Paul Durrant <paul@xen.org>,
	"David S. Miller" <davem@davemloft.net>, Jakub Kicinski <kuba@kernel.org>,
	"moderated list:XEN NETWORK BACKEND DRIVER" <xen-devel@lists.xenproject.org>,
	"open list:XEN NETWORK BACKEND DRIVER" <netdev@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] Revert "xen-netback: Check for hotplug-status
 existence before watching"
Message-ID: <YhSfYyh3xU4HZKek@Air-de-Roger>
References: <20220222001817.2264967-1-marmarek@invisiblethingslab.com>
 <20220222001817.2264967-2-marmarek@invisiblethingslab.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220222001817.2264967-2-marmarek@invisiblethingslab.com>
X-ClientProxiedBy: LO2P265CA0183.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:a::27) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b16ef669-15ab-4cab-f397-08d9f5ddbe0f
X-MS-TrafficTypeDiagnostic: BN7PR03MB3777:EE_
X-Microsoft-Antispam-PRVS: <BN7PR03MB37779DA32F03C93B322DB5A78F3B9@BN7PR03MB3777.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 94j9Q1EY1Xj2FcJrricYavncdfA9i1E7cIhXV9ABXsUvOlzGbdOQjhsyDSsuUINo1W26RjgtNFxSEw82NW5WXFXq+oQ/ycCmVk0AeDg4aqrPHhGOo5KWHr4cAS+tvzr7Z230MecT675r/cYTJoFdEWg/mRM5UaZk7wjMLPGU0gvMzZhR+DS4zWwG3TRZg26ckefNrGlQvYpvfgjdOhnebLrfhvrp16lXfh8R9N7znAGe6bzQXtYWusmwPNV+zB18++0EWhxnSBQwI47eFfNM9CCTJ246jgaJCW5dAdGILok2d467CczilX9YSiomGqor6Q3CMqfnzb9u/pC8QZ2s+yPQ1DmGSyp5PlJO4fbQ7K/S3fZ7EJnar61QtIxR83V1ikmIxaLhB2kTTtLqzNIpTVeG6h4dIgoPoFj7rV9LKBFwymq6SpmxYyim6HKWt/3h9qS7PJczC22YITi6nkuC2I31BDU3d4FI46TiffrAjgTmooZQO3MU+uXG8u5OIwilaDORXmWqQL4yp1crdBANMNxySuDZKcBLUObs4/QtFB7Qd4ffFJnEEPNl1j+kjptS6ikJf1z07YyA6O4BOlvaRQpXBRtUqgE1RVLf2Ve8LL9zMQrvqvJA/Dx7vAezWyAADQiq+xAedrnaa5zJJNg+dS0fINzJ7PxtomqekSFi7XbFessUbcmmSDmuhwpHEAt7qBJKeKsDzFWWZipZUo3iSLBXohu/thMnAZ24JJ1UAn9loiYls0hULL4IfSROR+gEZ3veEG6IJVNZvhfe/vXu0A==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(66574015)(186003)(26005)(83380400001)(2906002)(6666004)(85182001)(7416002)(8936002)(9686003)(33716001)(6506007)(6512007)(966005)(508600001)(82960400001)(6486002)(38100700002)(66556008)(86362001)(4326008)(6916009)(316002)(5660300002)(54906003)(66946007)(8676002)(66476007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R2w1Q2lyWStUTWVMWGZUL3RCUDhURzlHSGdKN3lhS0czTFFuTWtBMzhOcmZN?=
 =?utf-8?B?TVdSNWI2cUM2R0MyQTQ4RUdhWTV4WERMMFk0SGhsYTZqbm11RHQ4TXRPZ1VW?=
 =?utf-8?B?dG8xZENlYWNQZFZVWGtkazZvQWVPZUx4R0lmRXNINDYzTTlQOHFTb0czbTRL?=
 =?utf-8?B?L3RBcVpVTURVUmVkOXZGRHhCQTNiWGZXak9mWXU0TU51L0pXMy9JWW5jMWlM?=
 =?utf-8?B?SDNWTmdQNE5QWkpOVFh5YUI3dkRZUFhFSlBNVURub2Y5VTdBTE5SVitVWHVU?=
 =?utf-8?B?M3pOSkI0NUVkNDZZMUVNd09sS0hBVVVGeHl3ZVJLUU1KeFJ5b1VURlRjZFlU?=
 =?utf-8?B?UytJOFMrd3Fjd2NJSmNpSVYwK0N3a3NabWRtZ08wV1M0REN6b0NZODBnUndw?=
 =?utf-8?B?NEd5em9nNm5Yd0U1aGNwVmNBQWFQVmNsOU1sZDRUc1RFYmUxYTVRVWpXQm5o?=
 =?utf-8?B?dVgxcURoL3FURVdEczdoalI0VHhtTE1QbnFGRlgzTTJQV1Nlb0ZWWjFDVURS?=
 =?utf-8?B?bk9uMXpqZFkrOG45VlpjZ3I0WkFsdmluTjJlaFBhSnkwZUVGUHkxSS84UUhi?=
 =?utf-8?B?bEZMQkNlcHUyeHJwbXp0Mi9wRHpIbXlOa25TcmxnTWZFN05lLzQvNEFTbWhP?=
 =?utf-8?B?WThHdkRhaDIzMFNIaXczcjIxSXJNdlAvT2Z4Q3dhclpsNXRuZEhaMU9GNHNk?=
 =?utf-8?B?VlVTZnNNZkJ0Y2NhcVNBT2pYRHlHaWIvSUkyUlN0OTZYbDBDdHU0YmlOdVVv?=
 =?utf-8?B?NWFUOG5vYnBOK3hrWElmS24wWko3N1ZMS1NDU0dESDlrMjM5djZvd2dyUXRP?=
 =?utf-8?B?bEoyaEZFTUZEb0NKM0NUb2dQL2lSb3lyUTJIWGtkdThJL2xtNThCUFVweVZU?=
 =?utf-8?B?YW5ibWo0V0FJUTk0KzNJMzlKMDYxWEVYd2RaMjU3L3B4TTQ2UXA1ZlVUa2FR?=
 =?utf-8?B?N0VhZG5zYVhYa3BnQ0V1S2k3ZFN4YWN4QUxLRDNjZDVKVDhEQkhOdWdhT1pO?=
 =?utf-8?B?TU5wZHR3Mi9tVU9NWUl0WVp3Y0IwV1dwdE8rdjBBRjhBRVRtZmNHSi9DclY4?=
 =?utf-8?B?cDBEUlpiaXllS3FJL3JRQ1FXaU9CMWRnSE5HZVNFdVYxeWZpeDRDTW5iOFdV?=
 =?utf-8?B?NUc3TjhrckFvaWlHSkRKTjNRSkl6QjFsS2tPWC9zV2ZuV240QnFiaG4zenZK?=
 =?utf-8?B?aXhseG9kZEVjU05VYWZhOVlsSnpMUHdnYTZEL2hBYmluRnh5eU5FTjR6ZFlR?=
 =?utf-8?B?aHc4eGV3cGVyNXJveXJicGVkTEhQZDFOcVFyZi94RnUyU2dJMEduOU4xeTVL?=
 =?utf-8?B?OGlUZm82WXhBSnIvT2FQOFhLdEU0ZnFBVUZ1M3JrMHhrSmFRZ0JaR24rYThH?=
 =?utf-8?B?dFdpRmRlWEpjNEE0NTN0bklZVXlvYTZ2QlhKT2VVUzJQTkpCUGtaQzRLRW9x?=
 =?utf-8?B?WG02UFN2clRTempzRWhCbXo2NGhuUWhucDJYdmZGNndhUUgwbDhYMHBCVlM4?=
 =?utf-8?B?UWJvMzdXVkNDQ0E4Mjh4cVU0RmpGeDhXc3h2V3NSczJwT3Z5RDdiNmMrT1p6?=
 =?utf-8?B?THZpS1k4cC9jaXVQS2hZTEVoV0FhTjJaeU9jVDFORGRiSWw4Y1RnMDdPTXNr?=
 =?utf-8?B?cFFpNG5TQkU5UndXTXBsOXJua3l0cW1IZ3Z6dWpEbzdxaGRRM21wZExRY1hY?=
 =?utf-8?B?dUFTUFpGVDBhQkF1WFJ0cjBLMWV2aks1cVhNRFFrajg3MHg3TTkxbDRoc1dQ?=
 =?utf-8?B?eVFOWDJJbzBtVjVvUnJEb0RUOEtwRmZDWTZGb3JLanMwdEI2SE9hUVJwb292?=
 =?utf-8?B?WnhhbWk5QTJBWHJvelU4a2ZSbFBmM2ZVVGp4RFFPL1orQ09KQ0cxdVBKRjlN?=
 =?utf-8?B?QlZUREo0VU1DUmdobmdYaTRGVVh5ZnhIcDdkMnhRMGFlU2grWmE0b01NVXd4?=
 =?utf-8?B?L1JqeDNJcXRlcVJ3MGRNYzMycTdnT1BmYTRweU1UVitQTWtNSWc1bGFZMU13?=
 =?utf-8?B?dHIrbFltajlnSUV2c1hYM3MwRXZvcE5OUzRwUGFWWGp0eGNpbHoydW5RNENx?=
 =?utf-8?B?RjJYenpBem1mMk9QTnBlakp5aHRoK3BhWFk2RzBERlkvT2NEa1B3c2Z3VXBu?=
 =?utf-8?B?NWJTdHVQSTB2cytuWUo5RG9hc1NxQWZMZ0lISEc0UWpERGp4MUhWR1lrVjkw?=
 =?utf-8?Q?ebXgxK985FP3xbOqmdiHQFk=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b16ef669-15ab-4cab-f397-08d9f5ddbe0f
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2022 08:31:37.8054
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Rp+rFYbXVPx9gDBg7y3pcMUyEyBqeYP2s3PXDo7Wz9oe94nMFY15FbonB2uKPXQNhw99IcBzkZ+TyJgWmWnDUw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB3777
X-OriginatorOrg: citrix.com

On Tue, Feb 22, 2022 at 01:18:17AM +0100, Marek Marczykowski-Górecki wrote:
> This reverts commit 2afeec08ab5c86ae21952151f726bfe184f6b23d.
> 
> The reasoning in the commit was wrong - the code expected to setup the
> watch even if 'hotplug-status' didn't exist. In fact, it relied on the
> watch being fired the first time - to check if maybe 'hotplug-status' is
> already set to 'connected'. Not registering a watch for non-existing
> path (which is the case if hotplug script hasn't been executed yet),
> made the backend not waiting for the hotplug script to execute. This in
> turns, made the netfront think the interface is fully operational, while
> in fact it was not (the vif interface on xen-netback side might not be
> configured yet).
> 
> This was a workaround for 'hotplug-status' erroneously being removed.
> But since that is reverted now, the workaround is not necessary either.
> 
> More discussion at
> https://lore.kernel.org/xen-devel/afedd7cb-a291-e773-8b0d-4db9b291fa98@ipxe.org/T/#u
> 
> Cc: stable@vger.kernel.org
> Signed-off-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
> ---
> I believe this is the same issue as discussed at
> https://lore.kernel.org/xen-devel/20220113111946.GA4133739@dingwall.me.uk/

Right - I believe we need to leave that workaround in place in libxl
in order to deal with bogus Linux netbacks?

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Feb 22 08:34:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 08:34:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276532.472715 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMQdC-0004ut-Lu; Tue, 22 Feb 2022 08:34:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276532.472715; Tue, 22 Feb 2022 08:34:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMQdC-0004um-IR; Tue, 22 Feb 2022 08:34:46 +0000
Received: by outflank-mailman (input) for mailman id 276532;
 Tue, 22 Feb 2022 08:34:45 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nMQdB-0004ua-Sc; Tue, 22 Feb 2022 08:34:45 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nMQdB-0007y3-Pd; Tue, 22 Feb 2022 08:34:45 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nMQdB-0004e0-Bm; Tue, 22 Feb 2022 08:34:45 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nMQdB-0006kS-BJ; Tue, 22 Feb 2022 08:34:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=vV+NfrK5ngZFIzL8rcJR2C22SER0I6D2rr36J5gpv7Q=; b=5UPs0ybMeu+sAz28juoIOR2QTe
	MuFOA9NOpc45qY5jhD2TyLx4nT11Kt5s7hGtwQ0NHYhK04Aq9ovEHcpXDJFC0MBAQK3RNKKwzEmm6
	v1sdYONW3bljY8gWcAOzfFtOec7VJkUs5NopJDFtghc+vy68gAT1seREB5QxgN/HiF+c=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168191-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 168191: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=54814c87f3706cc8eb894634ebef0f9cf7dabae6
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 22 Feb 2022 08:34:45 +0000

flight 168191 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168191/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              54814c87f3706cc8eb894634ebef0f9cf7dabae6
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  592 days
Failing since        151818  2020-07-11 04:18:52 Z  591 days  573 attempts
Testing same since   168191  2022-02-22 04:18:54 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brad Laue <brad@brad-x.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Christophe Fergeau <cfergeau@redhat.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Divya Garg <divya.garg@nutanix.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Emilio Herrera <ehespinosa57@gmail.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Ivan Teterevkov <ivan.teterevkov@nutanix.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jing Qi <jinqi@redhat.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Lubomir Rintel <lkundrak@v3.sk>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nicolas Lécureuil <neoclust@mageia.org>
  Nicolas Lécureuil <nicolas.lecureuil@siveo.net>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Rohit Kumar <rohit.kumar3@nutanix.com>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  shenjiatong <yshxxsjt715@gmail.com>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tu Qiang <tu.qiang35@zte.com.cn>
  Tuguoyi <tu.guoyi@h3c.com>
  tuqiang <tu.qiang35@zte.com.cn>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Vineeth Pillai <viremana@linux.microsoft.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yasuhiko Kamata <belphegor@belbel.or.jp>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 98654 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Feb 22 08:41:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 08:41:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276545.472725 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMQjy-0006RG-HD; Tue, 22 Feb 2022 08:41:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276545.472725; Tue, 22 Feb 2022 08:41:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMQjy-0006R9-EA; Tue, 22 Feb 2022 08:41:46 +0000
Received: by outflank-mailman (input) for mailman id 276545;
 Tue, 22 Feb 2022 08:41:44 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=QzH2=TF=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nMQjw-0006R3-LR
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 08:41:44 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 408c0029-93bb-11ec-8539-5f4723681683;
 Tue, 22 Feb 2022 09:41:39 +0100 (CET)
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2050.outbound.protection.outlook.com [104.47.1.50]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-33-9t1qKKhQMoOpJ8zaCSnxXw-1; Tue, 22 Feb 2022 09:41:41 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by PAXPR04MB9217.eurprd04.prod.outlook.com (2603:10a6:102:232::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.18; Tue, 22 Feb
 2022 08:41:38 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.4995.027; Tue, 22 Feb 2022
 08:41:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 408c0029-93bb-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645519302;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=CgZuVubWEYEkDiOQemGZNR53gEvIZpNrmDGouexPZXY=;
	b=D3vdTBh2zADnmRnzeWIjff58qPOmsGlRk39NSdUpJqoOWPi/5uMT/NkaEA5i+sC0QcqgmG
	UR8mnZOa/HbHrB6MpOrlO2PGMwbsM+MjQ2eThXFYhXd4kaaI1lxph83lhRhQlJV1ZCLx+v
	XwKnQdnlxxdL19R9llazV6Hgtaj18BI=
X-MC-Unique: 9t1qKKhQMoOpJ8zaCSnxXw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=axgG9mgdXXK10gGSimzF0EDIfTwQEy2pAlJWIJWUxAp6D8s8BcSIhR8VhY/9MRmYZNF5FTc0xGiqtfykgHvf2mUcQ5/fbKzSh3KppVQGmAsQqfBAh52gOfAZUgmRGO4WNWTAbrDEKYm23gVEfrN0gS31ZYOvEvCYeyjk7hCeHnEsNapyujg4GuuOncUevCQi21nhLhkx/0GcyvK6tSACI0sk1zX6eeZ5QLmvtUy/Jah+2qLUek7GHlc1R+0v7N2OXw9rNQSqmdWnslAxR/piw1iDpfLo/EpG6btzQCIJpPrw5SB1Nb7jcsVthEGz53WlUoyaUuKHgsJV9ulJfA51AA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=tyXx9UiAUGvels75721wCQ27S6D1TgkSnQqjevlwwMg=;
 b=QkHVAiNO9GRRZETe9Rrk5cE6bvg3+LaxHPh375pHMDXczvpsFIK/DzBX8qYxUkd0gjDLp9X1T4VuAadvRsQ7orgk6DLDylczHA2L0UzkOcgiX3bweWzs0no+LtPg2gPMmzhOF7fTutphQupy0oYht8i04P2FkoqbcQVveKbz0yrkpuT56axpABwg2GMM1bb/vWumVlAlY7k40jUdejcFzC7ALoeysXgcjD5bcFoOADuorZmeoP8h+07R6IMqshiEyWfOwGMKV8EpUjG3UINDhSkracgLspkkb4ILXzyWHh7n8eNDYX5bnsVwkyT6GEbzi6SPmUKaFnI4TZqNaRIK5g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <2fd2f479-575f-34db-ddd2-89df8eac81d7@suse.com>
Date: Tue, 22 Feb 2022 09:41:37 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v2 04/70] x86/pv-shim: Don't modify the hypercall table
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
CC: Juergen Gross <jgross@suse.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20220214125127.17985-1-andrew.cooper3@citrix.com>
 <20220214125127.17985-5-andrew.cooper3@citrix.com>
 <4d8ab414-caf4-5a12-4cb7-a88c633cfd66@suse.com>
 <e18c0c5a-d00b-adf9-d4b0-28e702a18241@srcf.net>
 <6566bf52-58da-f804-f5c2-fca64c1f150c@suse.com>
 <f0889e93-aec0-443e-b3fc-081892edaf2b@citrix.com>
 <44e0ab16-e807-c8f5-deef-7094b7aecdeb@suse.com>
 <f1a3e319-4810-49eb-7ae0-a044499e85a1@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <f1a3e319-4810-49eb-7ae0-a044499e85a1@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6PR10CA0099.EURPRD10.PROD.OUTLOOK.COM
 (2603:10a6:209:8c::40) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: bd76fe86-a5a2-4861-8d5f-08d9f5df2445
X-MS-TrafficTypeDiagnostic: PAXPR04MB9217:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<PAXPR04MB92177B5B3D50EB8E2E1C056FB33B9@PAXPR04MB9217.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	B2yvx5Y0P+VyTSp/UHF3S6pIbL1OUE4qAEW2SOJxDvHN2FQjkii7DgJrBImmCibYeaytx9gDJg5dkFyFYJGySPGNyxKLT+KpvfrtPDrzJ3nq44C3JgK1unqRhgyJixLzsvc6doW7PqJFETrwtxs7LtuDbnPYD2ZMfthezg/uJBTyq7bc61bpStwg9DU23l056rTF2lfQtjOC1x2ZC1IHD2RDA1N/m0hnlf7l6phyNFpEyCekjYIKvmH/PmS4YVGXsgmhqohLwS+fdDdne2/OVtO67I+2+oV4oTmSdyx6ztT0fKrhP+GPIor44gj73vAA1RcwdHmirocRodOpOIQVBajlM2kTarac0oTFHY4CxyGpfWLq8PETTKZUDPeaqw1/rR62W31upR83sAwSvt/4qK4gsrV400tBFhMnwTPFzqQjuFEMMq6GMs2371bqcDiXTuOtLYkMyfW8ROn/KfuA7unhd7P+/17NKE3sMvbQ6AVJ7MXmhgXLfL2+d91cF3oXj8WegvQlcYi9BECuj5OKAXrDOuW/HdlmtPT5fq06Ra4srjLvH+JktpIA1IEzBACLRe7IeCNWZV1D8x4C58SYbzuPqFTABf+03R4C6G2mIXRSL59uyRi3ciIlaLODtgYZeVXWfMD0GkLuk3ekq/xsAyuN+1WGIF+PHdwb0wEsCQ5K+/ujrAEeN7KPRUVd3O1j8k7fBwnLz3Q3oIFiUEVjAaPyOREeICY6Ze05OWMW67Ux7t4t0TdEfqiAvfmxvDWW
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(38100700002)(83380400001)(5660300002)(54906003)(6916009)(66476007)(316002)(66946007)(4326008)(66556008)(2906002)(6486002)(86362001)(36756003)(8676002)(186003)(26005)(2616005)(508600001)(6512007)(53546011)(31696002)(6506007)(66574015)(31686004)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?t4wuhFmnnx5YsUeotALLlZvRneYs/yZ2WtvfXwNWt3AY/naju5BBaCCvXs0E?=
 =?us-ascii?Q?bKdh0V3/5OLS19FpDAma8PMVw2MaaC0gQR95uC20RuUISEvPY/5uj+pJB1OG?=
 =?us-ascii?Q?puNQI2T2aW5hSoRIhsrFG4znkiMSaiSURwr3Rde81GwY8KTFegvrAqow0zF2?=
 =?us-ascii?Q?v5V+Mz69XRZjOk6BrnxIarVV9G59mXvKxgn3kOxJijUAoLY+P/bNXobNL/C8?=
 =?us-ascii?Q?oL0ZAUGW35skWinvyRxjo6l0dmgHbY0uP7EGxguOgUmvsQLroTN5mVdD0ppD?=
 =?us-ascii?Q?tLjYPIP2nSehgw/J87BCRKDAwfCYpytWEThXZmRApQhMuVM47hPFceE3KKTy?=
 =?us-ascii?Q?pXuKOiNw+fo7C1YqZRxqi0Zes90jXzmRDma386Gs2XOoyoDLZC+VoIKFoBz5?=
 =?us-ascii?Q?Plpz58bDYrC9Z9/kpV3IjoqrJ7QI2exbtUTK+JSyjGhK4zPKD3CC9xi9rnwu?=
 =?us-ascii?Q?N/inRC7+c9NvTr2XCnd91MRRak10jMsfM3CQdsuokLXMo8krqcQN1frgdttw?=
 =?us-ascii?Q?opgPuPdHmKrX+FmWrfgIIo2XL5dtbFq0PZzHbfdo5JsoP6hhHtJ+3CB4sPZ6?=
 =?us-ascii?Q?l9cd54iE1eDfzCewCGgHw7YTybs8ZdSZwBoFCPRcXlxRdYke2hmp6KLw2uhx?=
 =?us-ascii?Q?Rxt1To3+Md6Xs3LnobiMilktZX5Mx2OpMoCr5aSHoW+tkI0ChzVSeHg5dqdD?=
 =?us-ascii?Q?vb9BaBqYeNDlYFhy+oHZpajwStjWOJgH1G1zVX/isGstTklbL8TYVzkp7hwi?=
 =?us-ascii?Q?er8G/SuchlZWSyjaPGzQCGF79OuEI9q45nQF3u8vwcW1aV2VG5Eg2/ozJpHm?=
 =?us-ascii?Q?tYBysxJAs2TCd6D5EsXC5YUIJaloQ+ew5qeIg0YGsiYolg8LujIt/FQFPhji?=
 =?us-ascii?Q?A95R7G1THJyO/8LS7jPqLNI1KK0Z//bAMt5OsAnZ1I+uwQBwhhqFpdQQ7CB3?=
 =?us-ascii?Q?9FcQ4VeVZng3GiwmDjgGrnupLMqes03KTwcEgmftk0UGgJWRqRqyZ5yELi5G?=
 =?us-ascii?Q?ojt0Iicd4OAzXUjcG32uJEOPP++fp6M65SFc5n1DhRKS3FGN+s+B4MIj3Wy9?=
 =?us-ascii?Q?S/Lr/CzKaZKrwW3i6gDzE3Ol3ksRbNaN7sOSKMMeOKmyOP1kAu85A/MovH8I?=
 =?us-ascii?Q?dgxaeomURmwibe/MEwrLujvuUT9Grao+cmpT0bI0E8TbsOIv2OMg2vTeslA3?=
 =?us-ascii?Q?0eXysfijZ/AREQlRjLRCnXULM+0Hf27+9b++0WC+HqNmXPzH78urmjuwMhxc?=
 =?us-ascii?Q?hJq5hJCemAZpQP4bXoFafpzQdVv/J2tDN657MsNYtLhl2ti8V4jZBuYSpbF+?=
 =?us-ascii?Q?/8intHxmjGZ6wpqfdwWafZSQnHAYU8zv6k3H8ohvC4v3VTMe8IrmQhqZ+RaE?=
 =?us-ascii?Q?A+p3ZrVzNVub6kvmznTTMlxeKWIHkzWKq3hmu/Zv+szZRPtx7GHfBfUxWmBR?=
 =?us-ascii?Q?QJAq7HgPheBkJqp4/5/wStBW+6VbTlRMW+VgxfglpqbOSd0XqEHcOEgIFxBP?=
 =?us-ascii?Q?wvLWznqLSH6r5OqN2HKuz5E+MRrypZaRjIWfmguWhCXj2Ihfbk4rjDLruU5d?=
 =?us-ascii?Q?PjRBpUFEYhSX2OaOuJpUb/S0xlQoi0UIN9lmStcimRsERopX5ycHN+EnZoXK?=
 =?us-ascii?Q?1eVbRBlUK6yZ7TgyLI4SVGI=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bd76fe86-a5a2-4861-8d5f-08d9f5df2445
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2022 08:41:38.5779
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zQsu/glOZGEHUkPQtW/rs3mi583gRr99Yl7NQFcze+fJqhdNv6gJOzrJpjxwWun+74Ctn0oAiiK2BiMKzUyd+A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9217

On 21.02.2022 20:21, Andrew Cooper wrote:
> On 17/02/2022 10:20, Jan Beulich wrote:
>> On 16.02.2022 23:17, Andrew Cooper wrote:
>>> On 14/02/2022 13:56, Jan Beulich wrote:
>>>> On 14.02.2022 14:50, Andrew Cooper wrote:
>>>>> On 14/02/2022 13:33, Jan Beulich wrote:
>>>>>> On 14.02.2022 13:50, Andrew Cooper wrote:
>>>>>>> From: Juergen Gross <jgross@suse.com>
>>>>>>>
>>>>>>> When running as pv-shim the hypercall is modified today in order to
>>>>>>> replace the functions for __HYPERVISOR_event_channel_op and
>>>>>>> __HYPERVISOR_grant_table_op hypercalls.
>>>>>>>
>>>>>>> Change this to call the related functions from the normal handlers
>>>>>>> instead when running as shim. The performance implications are not
>>>>>>> really relevant, as a normal production hypervisor will not be
>>>>>>> configured to support shim mode, so the related calls will be dropp=
ed
>>>>>>> due to optimization of the compiler.
>>>>>>>
>>>>>>> Note that for the CONFIG_PV_SHIM_EXCLUSIVE case there is a dummy
>>>>>>> wrapper do_grant_table_op() needed, as in this case grant_table.c
>>>>>>> isn't being built.
>>>>>>>
>>>>>>> Signed-off-by: Juergen Gross <jgross@suse.com>
>>>>>>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>>>>>> I don't think you sync-ed this with J=C3=BCrgen's v3. There were onl=
y minor
>>>>>> changes but having a stale version sent two months later isn't very
>>>>>> nice.
>>>>> I did resync.=C2=A0 What do you think is missing?
>>>> A few likely() / unlikely() as far as I could see.
>>> Oh those two.=C2=A0 I appear to have forgot to email.
>>>
>>> They're wrong - observe they're in an ifndef block, not an ifdef block.=
=C2=A0
>> I don't see how the (unrelated) #ifndef matters here: The #ifndef
>> is about grant table availability. The two likely() are about
>> running as shim. I'm of the firm opinion that a binary built
>> without PV_SHIM_EXCLUSIVE is far more likely to be used as a bare
>> metal hypervisor. And for a PV_SHIM_EXCLUSIVE hypervisor the
>> conditions are constant anyway, and hence the unlikely() has no
>> effect.
>>
>> And if your way should really be followed, why did you deem the two
>> unlikely() in do_event_channel_op() and do_grant_table_op() okay?
>=20
> Because those are at least not incorrect.=C2=A0 (I still think we have fa=
r
> too many annotations, and I doubt they're all helpful.)

I'm afraid I'm completely lost then as to the (consistent) model you
want to see used. When putting them side by side:

@@ -3543,6 +3547,11 @@ do_grant_table_op(
     long rc;
     unsigned int opaque_in =3D cmd & GNTTABOP_ARG_MASK, opaque_out =3D 0;
=20
+#ifdef CONFIG_PV_SHIM
+    if ( unlikely(pv_shim) )
+        return pv_shim_grant_table_op(cmd, uop, count);
+#endif
+
     if ( (int)count < 0 )
         return -EINVAL;

and

long do_grant_table_op(unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) uop,
                       unsigned int count)
{
    if ( likely(!pv_shim) )
        return -ENOSYS;

    return pv_shim_grant_table_op(cmd, uop, count);
}

it is (to me at least) quite obvious that the unlikely() and likely()
both express _exactly_ the same thing.

> The gnttab stubs in the !GNTTAB case exist strictly for compile tests
> (there's no such thing as a production build of Xen without grant
> tables) and PV_SHIM_EXCLUSIVE builds.

If certain options (or combinations thereof) are not supposed to be
used in practice, why would we allow them in the first place? Sadly
the commit introducing the GRANT_TABLE option supplies no justification
at all as to _why_ this control is/was wanted.

> Code layout only matters for cases where we're executing code, which is
> the PV Shim case, at which point the condition is constant and doesn't
> generate a branch.
>=20
> A compiler ought to raise a warning on finding that __builtin_expect()
> has a constant parameter, because it's a nop in one case, and
> demonstrably false in the other.

Such a warning would imo be as appropriate (or not) as one for e.g.
"if ( 1 )".

> As for the function in question, the compiled result is an unconditional
> tailcall to pv_shim_grant_table_op.

For the "#define pv_shim true" case, I suppose. And then yes, as expected
for this particular case.

Anyway - once again in the interest of not blocking progress of the full
series, and once again contrary to my intention to not ever again do so
in situations like this one:
Reviewed-by: Jan Beulich <jbeulich@suse.com>
(with at least half a sentence said on the seemingly unrelated changes)

Jan



From xen-devel-bounces@lists.xenproject.org Tue Feb 22 08:48:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 08:48:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276552.472736 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMQqS-00076N-7V; Tue, 22 Feb 2022 08:48:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276552.472736; Tue, 22 Feb 2022 08:48:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMQqS-00076G-4a; Tue, 22 Feb 2022 08:48:28 +0000
Received: by outflank-mailman (input) for mailman id 276552;
 Tue, 22 Feb 2022 08:48:26 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/+sy=TF=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1nMQqQ-00076A-1o
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 08:48:26 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05on20612.outbound.protection.outlook.com
 [2a01:111:f400:7e1a::612])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2fa7fa44-93bc-11ec-8539-5f4723681683;
 Tue, 22 Feb 2022 09:48:21 +0100 (CET)
Received: from DB6PR0202CA0043.eurprd02.prod.outlook.com (2603:10a6:4:a5::29)
 by AM0PR08MB3345.eurprd08.prod.outlook.com (2603:10a6:208:5c::30)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.21; Tue, 22 Feb
 2022 08:48:22 +0000
Received: from DB5EUR03FT062.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:4:a5:cafe::7b) by DB6PR0202CA0043.outlook.office365.com
 (2603:10a6:4:a5::29) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.27 via Frontend
 Transport; Tue, 22 Feb 2022 08:48:22 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT062.mail.protection.outlook.com (10.152.20.197) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4995.20 via Frontend Transport; Tue, 22 Feb 2022 08:48:22 +0000
Received: ("Tessian outbound 341d209a0e52:v113");
 Tue, 22 Feb 2022 08:48:22 +0000
Received: from eed862d4cf73.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 2F0715CE-8FE0-40C4-803D-21198D27621B.1; 
 Tue, 22 Feb 2022 08:48:16 +0000
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id eed862d4cf73.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 22 Feb 2022 08:48:16 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by DBBPR08MB6283.eurprd08.prod.outlook.com (2603:10a6:10:1f7::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.16; Tue, 22 Feb
 2022 08:48:12 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::aca7:79c4:fa65:dac6]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::aca7:79c4:fa65:dac6%5]) with mapi id 15.20.5017.021; Tue, 22 Feb 2022
 08:48:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2fa7fa44-93bc-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=LyMy87wvyZ62c9vWLLoO71oN0aKj5HlXRnDLhTiB9DQ=;
 b=uaYXADQzbK3/+M9av+HEJWEx86P9i5zT6l8FKvRV32GrJAGFJn2mKnO+jhkiIN5ymOxkbefNV1mT+zky+NMVngQzCujvyvsIHMoYdAZ/1s2LaoC1a2KOCW59K1aw9f0kEMEmSBg6hUCmSaZc1AIXbHq1lqxQOU7MsKQpAp9D9Nw=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: fe5fcd5aaebcd0ba
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=K8IbaYsCrCahWyz0wUv9R1aou9A3fxqT+wfuq0VKck2/lXOiszVQToBl77YmOolxC0cQWYzugldsKA8WFfR2v727eGL1RWU8nA/aOHreVyMT6yZvq4ibwsMJU1cFVKYLHuBhh5llujPjgYtw6U80ae2CeC2FS+k/Vzl+9e6kxqsnLjfwhNh1JwPR3xAWNfs61EYbZaZqFF5qZhbuG3hpLuMpf4lZjBMcy6Uikx5M71w6nzW8TmO1i2+x4QmqKJ6CyZu8K15qw2J65P7izAam2+l9mxzW/LrGgPj7Ql+Fpt9/4PVKNPdHPxOxPWSMnEpUbElSUAzwA/nMmQeKc8w4cw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=LyMy87wvyZ62c9vWLLoO71oN0aKj5HlXRnDLhTiB9DQ=;
 b=ACxw5pB9+cFjB77vcfBqxN2EOhIbUYRsOjxB+8terEiNgNWIT3gOqzE/Q4nPx80mgA6LfXUelhTZPIcMzxRuNFHsNyMu/k3HJe5ndmqxm5TniivsRmMTd2aZI9UtotHDaH9OEzvWUofR3rWdPWF0OW1rqA5Qa+DANbQbRWwoJcDi8P+yjv5DTUZTadZGWnafj3EvtAXpIasPkyHTT3i+rjkqkICMUgiDxncP8fxV+zMGYSVEoL9fP9hFD1nCqk2yR4/6W7Q8MJRuC3NFmbSTDZteMKl/zJjKpb2yjJa1lRqe+Y/nTxYSDG25J5WTTjbot+9WbMSnTghr8PETOsxUkQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=LyMy87wvyZ62c9vWLLoO71oN0aKj5HlXRnDLhTiB9DQ=;
 b=uaYXADQzbK3/+M9av+HEJWEx86P9i5zT6l8FKvRV32GrJAGFJn2mKnO+jhkiIN5ymOxkbefNV1mT+zky+NMVngQzCujvyvsIHMoYdAZ/1s2LaoC1a2KOCW59K1aw9f0kEMEmSBg6hUCmSaZc1AIXbHq1lqxQOU7MsKQpAp9D9Nw=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Michal Orzel <Michal.Orzel@arm.com>
CC: Julien Grall <julien@xen.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, Stefano Stabellini
	<sstabellini@kernel.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH] xen/arm: Rename psr_mode_is_32bit to regs_mode_is_32bit
Thread-Topic: [PATCH] xen/arm: Rename psr_mode_is_32bit to regs_mode_is_32bit
Thread-Index: AQHYJxJCWcqEO5mjnU2pXdjeX/mYYqyeKbmAgAD9y4CAABwvgA==
Date: Tue, 22 Feb 2022 08:48:12 +0000
Message-ID: <A666192F-D43D-484D-8125-8908F45155BB@arm.com>
References: <20220221105931.12028-1-michal.orzel@arm.com>
 <1531f49d-c74c-8a41-a917-cfe76bee8e7d@xen.org>
 <05b5877b-7dc0-3d35-f073-5721e1605321@arm.com>
In-Reply-To: <05b5877b-7dc0-3d35-f073-5721e1605321@arm.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3693.60.0.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 4db849ea-ee2c-4a2e-5f48-08d9f5e014df
x-ms-traffictypediagnostic:
	DBBPR08MB6283:EE_|DB5EUR03FT062:EE_|AM0PR08MB3345:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR08MB3345EFF95EEE0CAD8585E7239D3B9@AM0PR08MB3345.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 2AuD050VJKj0LtHvKx3ArMxv1JFId7zC61tAfYBg21WiDjrrZeKabPglmWJPZFALn1KzGmicEJaSotNdR/rRaU3Fib5BcWGXFp5zn53miHR509aIcMG7Nm52Bt1CwUb0PrKuQD8E6yV2IPdZJkBHrexn+kQMjyCqFLYoJ62stQzlNNhrR74ZaZwGdg04S33os9MVPIqha+5XF55i4w/C5N0RGGGWgKwFdOcpQpUnOICgsm1xKmfMICv4LXIN2F4mLC99EwI7z16vRcKQTJ925q8lw8DBwegDuS2Kp/Qc7xcCNEC2giN+bOAnxYf1nhWAw5dA1on8ZlrI45S3svSPMun39EMcDSJ2+0b6jRnyPqNsP2l9wcD66/HwR68wgFKHjZoGjVI0Lv8kSonJnYfzV1UWEYDiXhpOwpfIDvV11jwW0klc9Pe8+t391kHgzj5FM6g49vhj2Q2LH+kMhCtaJ0iaek8uyaZ+S0pyd+wh+1rZdzXXI50t2ou1ugo5MDJQyO6vBKbBmUVYwdqXJ+de/RzznTjNcFXMisbUEVRt5kCuvZv6HYXRbT77i54STXKm+YPy2KnAgvC3PonPpiB8YlyZBgbVr1GEuM4FJZTm/Wjh3kJbs6SzHy4snhFwQKIIp4o4QkMnqYZhZQLCROAasGaA88GurT272etjNSK9kV/dYygbJwvufk17kWJt5HwQmluWqOWAPMYI8TDQTDxf8/d7IUKv7LKpRry/XBEA4iJdMhXrpimfu7Igco2jXVYXD6THoyChXrAALC4N+gL603Med6qx7sfT+pgeZ0bibOZnNpa9KM2doUvmRx2Ybg7b
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(316002)(71200400001)(2616005)(6636002)(5660300002)(86362001)(37006003)(54906003)(36756003)(26005)(83380400001)(186003)(66556008)(76116006)(66946007)(8676002)(122000001)(33656002)(66476007)(66446008)(64756008)(91956017)(2906002)(966005)(38070700005)(4326008)(508600001)(6862004)(38100700002)(6486002)(53546011)(8936002)(6506007)(6512007)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <C5C7C3B0E9307540B4D638C19A57B597@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6283
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT062.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	697f1dc6-57f4-4aae-02ae-08d9f5e00f15
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	EQftcHTVvjfODzi0z+FtUUGNO92qcQE6FaQ5icp0cLacuv3F4wYnZZKQulk7Kfp//k5MyQPGloiM6TlQiZ9KlPbN04IrraVSDOeGBY5x+M2mDr8Ylde6izkLtUUL2j+UcIPzWsHysDAQuicRAGdAuzPSSP8bwHfrIgqvPLbCi+PaR/2hrFNjPXY7PewsWGveQaTMc/WtZEmdux61xH6jHqempCDuS2jSogpwHajLUwJQr0KP59wrZcY7MGwJyqc3bGzCs77Lbhxin+WpbeKXcesoVOKL1Xy1VOt81j/+NoturHXZP9HtGI0DXjysIUHfxuxnOLsunFU/0uvRP0YTJiEavFzXMsmLQdI9jIdpYxYQtARdN4AXPBArmfAOU0s6VaviI8irOfS9HM8r2R5C2E6T+ebSnZxN9srZpdBeOW2KQT74DI4kwrCrBut/baaSZDQkGFtPvfJ96i4TgnN78QA1XhEmVH28Ux/qp5pH0SlGCYAs/1cT/TxjTzcb88sGqn9gPRHW3aIa+m/k8dA1Whn+JfkXvozy+8T9qi/PHoudIfmh8hWufgr1ZKqR7fakbD0fLGTC4q+gHmXaV7xk0mZ4v/wMREscZDmN4t4k+dJpgYqOpsSdFSmd5rG5osjGAtlgd7c0sF8+COylSMDmJ+mHYyOijCVgrJ3FwTDXK4STli+7a0/Sda3cuU9HFp+QikDy5QnHB5GWTL3bAnJRMC9rVIxwfULa8qY60WZvMlhMWGRBfCnDQPvbCuskuDga
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(83380400001)(47076005)(356005)(81166007)(86362001)(40460700003)(6636002)(6486002)(966005)(316002)(8676002)(70206006)(70586007)(54906003)(36756003)(37006003)(6862004)(4326008)(36860700001)(508600001)(107886003)(336012)(33656002)(2906002)(2616005)(53546011)(6506007)(82310400004)(8936002)(6512007)(26005)(186003)(5660300002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2022 08:48:22.1142
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 4db849ea-ee2c-4a2e-5f48-08d9f5e014df
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT062.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3345

Hi Michal,

> On 22 Feb 2022, at 07:07, Michal Orzel <michal.orzel@arm.com> wrote:
>=20
> Hi Julien,
>=20
> On 21.02.2022 16:58, Julien Grall wrote:
>> Hi Michal,
>>=20
>> On 21/02/2022 10:59, Michal Orzel wrote:
>>> Following a discussion [1] it seems like that renaming work has
>>> been forgotten.=20
>>=20
>> This is in my todo list of clean-up I need to do for Xen. But I haven't =
yet had a chance to look at it. Thank you for taking a look!
>>=20
>>> Perform renaming of psr_mode_is_32bit to
>>> regs_mode_is_32bit as the function no longer takes psr parameter.
>>=20
>> If we modify psr_mode_is_32bit(), then we should also modify psr_mode_is=
_user() because they have the same prototype and we should keep the naming =
consistent.
>>=20
> Ok, I agree. Do you think this should be done in a separate patch?
> FWICS, psr_mode_is_user is used in traps.c, vcpreg.c ,vtimer.c and vsysre=
g.c whereas psr_mode_is_32bit - only in traps.c.

I think it can be done in a separate patch.

Cheers
Bertrand

>=20
>>>=20
>>> [1] https://marc.info/?l=3Dxen-devel&m=3D156457538423787&w=3D2
>>=20
>> NIT: The first sentence and this link adds value for the review on the m=
ailing list (we know where the request came from) but doesn't add any after=
 the commit message (there are no extra information in them).
>>=20
>> So I would move this information after ---. This will get dropped on com=
mit.
>>=20
> Ok.
>> Cheers,
>>=20
>=20
> Cheers,
> Michal
>=20



From xen-devel-bounces@lists.xenproject.org Tue Feb 22 08:55:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 08:55:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276559.472747 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMQx0-00005L-Uy; Tue, 22 Feb 2022 08:55:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276559.472747; Tue, 22 Feb 2022 08:55:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMQx0-00005E-S1; Tue, 22 Feb 2022 08:55:14 +0000
Received: by outflank-mailman (input) for mailman id 276559;
 Tue, 22 Feb 2022 08:55:14 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=QzH2=TF=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nMQx0-000054-HI
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 08:55:14 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 24ed7f77-93bd-11ec-8eb8-a37418f5ba1a;
 Tue, 22 Feb 2022 09:55:12 +0100 (CET)
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur02lp2053.outbound.protection.outlook.com [104.47.4.53]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-10-IRqOZ6ezMqKtHG8znC0Ysg-1; Tue, 22 Feb 2022 09:55:10 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB2863.eurprd04.prod.outlook.com (2603:10a6:800:af::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.27; Tue, 22 Feb
 2022 08:55:09 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.4995.027; Tue, 22 Feb 2022
 08:55:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 24ed7f77-93bd-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645520112;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=VeimnAO2B+gBAQzv4gm6HY1fwYl8qIvfS9Wk3eT4Zv4=;
	b=Bu3iy9OlYiNMQyw+7EA8przZKoBSGDVUtSYWVbOfevSQ2krzQykg+FMlF8y+kfafdftvpp
	P18ltPOfYBBOGxGVkMYBomwR6zwrUjWcfn6cPS+6BwX1IjLynQhcjGhOwL1pdwQyWY3Dud
	ctzmhIQ3qy4Y0VKtboDXjDo8G6QqaLQ=
X-MC-Unique: IRqOZ6ezMqKtHG8znC0Ysg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=YXQiZZuSuW/gDRiC67hgNIcqZE3vG4M9KTOXrwei0hkAgTBd0risZwz/BMkc24foK4Ucaw+fkmgykoQCzRZFcDK5SRnwwnRGunwc9YE+XBWYooEqEOhtZL37zNd1Y3NPI5Cok3klp2xcaATOKpUJxQrtJKDrYUYZlKq1tEvbx6eyNzDUJvZZAV396tp9AxCd7wqqPiFiFCBbNIV5GmOPugCffSROaAN3Z7sKT0zn011fucUIAc3rroxsW1t8udXCSbRurrEfTLRrgKkPTgQq4zQn06Ehk5TKkBVxxso4AJdeHTB+xJXf4pBwsa7LMzxoqw4l9mq3jv13oL7cQyUebg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=VeimnAO2B+gBAQzv4gm6HY1fwYl8qIvfS9Wk3eT4Zv4=;
 b=jcUzxJ8R8z1hJQ3nWHy8rzt4aPKOVv8+MK8L4zX8zye1Wu+eU5VPh0Cg69KMp+3F2QlEgWzhh6wKb+JKnQQRSmtOCdw7ANXbeyLA60wmJ160P73fDHOqqoCNTfzMkxNhEmGRjYaCXc3sJ/qJn26knOoD0+LGLvj/G6EENCIfW2VAVChzQ/d5cidjZ9e8njV6vETZxW6xKxnivcW/5XYCSrNhVZqEnxAD/oIi3KGho3eKsMxkLpui/56gNaatQgvMcy1Ivv5572dBrphc16Fu7dn404tQPqIBm7nGgAWVCFDVkclRvA3mBW8/LJz76rjrlsKHNJtpqQdV3aCK/YnKdA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <fbd980cf-71c2-aa8b-4d23-acbb457431fd@suse.com>
Date: Tue, 22 Feb 2022 09:55:07 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH] xen/include/public: add macro for invalid grant reference
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220221124221.10245-1-jgross@suse.com>
 <5bf7424a-c295-7aa5-4bf8-13136065a06b@suse.com>
 <7798d54a-0aa8-5c13-c8fe-50e3dca54b12@suse.com>
 <28f2b406-f36e-e115-d6ff-cdcdf22f68ec@suse.com>
 <aaef1839-96b6-0d6c-df3b-d31cc7fa697d@suse.com>
 <e8a17311-1a56-23d1-7414-0f9ae18cc0e1@suse.com>
 <06890331-8c75-ddb9-57e8-284c47d4d562@suse.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <06890331-8c75-ddb9-57e8-284c47d4d562@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0178.eurprd06.prod.outlook.com
 (2603:10a6:20b:45c::10) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 298e2817-dce5-427a-1e69-08d9f5e1073c
X-MS-TrafficTypeDiagnostic: VI1PR0402MB2863:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB2863B02EAC9347C090E5A7B1B33B9@VI1PR0402MB2863.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	cw56wlfUwAN6xh/l8FUWORxk3aPMYd+TRDHnZjT9Jn7Aqs1SnH3TGwRjXvPgIHbh1U70WsBkUuNKGMJlsi241Mkr5ZonUXCES1xlKXLj7ugInQ7WdoRi4QC/goBH5amcs3ZDULn/OmunXHKP+l1MWze2NswJOFhUdVY89IRe2AdcYl7tgarcsZrsZADslycBqLndpu6FGgtt/bkHRMB5ioNwTqsNleqFgYxls6W6fGKipppedpt6YAPNsoBPBJM6+59n9ZJoIY7K0ZyNPTe22TJFlrwMXzZsl2Koi3zwT9pvMhN2v+ClAFXm4XLb9TPhgMTBivzledpeXTQGs4QTjjw8PrGVR5/hLxRmhW78H7vJEN4MkPHJ4af8QiodguN1eepMAeglt4RcyCgwLoy0mZlrgSGkzaL/gpSm9ANO2tBae+5sqLfyKx0nY5zHAvHtx/N4s4YAQUOybtc56dbxLs44n3iA8MQVBdSiinMi9tPcmg5Hne6Ikx2zwWZ0a96n7NzLxHrMOLJMWPxeeESoqfQ9w73EJpeHotozt15HtVg7sMGWVB2wF8U3vHNsPKtE89+ok3qH92k9/iXJAaIgYhn/hg6/S6gW0glf8l8MnzteQmwyPdVLSnJQF7ZfHz0Rflnqb76O970I5LzmSxIXRH67MQpSacGCFD3/CFXGPP+tx7ah97sdgsd3N6AXWVeYddKoB3fp2bR2nrzG7QDGfdC6YIOpLXNR/3hYumIjKe2Rt1iYVIwXFlISatjJZaEd
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(54906003)(37006003)(8676002)(4326008)(186003)(26005)(8936002)(66556008)(66476007)(6636002)(5660300002)(83380400001)(6862004)(66946007)(31696002)(316002)(86362001)(6506007)(2616005)(6486002)(36756003)(2906002)(38100700002)(6512007)(53546011)(508600001)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?U1lEejdtWXB0VUxZdDRWVVZPNnlyNnZwNjluRy9oVUJXVUR4Tm80YUJPQ2k2?=
 =?utf-8?B?U3ZwQ3gyMWgzN1ZqZ1lhcUtabCtLR1REZ3pQMDVsaDFqbVEzaWpnc0g2MEJw?=
 =?utf-8?B?bDJrVUYwakhsOVBBdzhLL0hENWtIQXltTG1RbHdUY2g4aW5SaXFIN292RERu?=
 =?utf-8?B?aDBKMkVwTVdFREk1b25EdTdRY1pLSVZsTStIL0hwZnRhUnlKMFNvTm1YN0tT?=
 =?utf-8?B?M0RCMVU5YjFGWENHQWNlTng1a1Q0MkFXeGpPNU9UTVVTeHFzQ1Nlemowc2tn?=
 =?utf-8?B?V3Q0djZ2dHZ5SHBzZ2xNMW8zN21tSDBPSTY2RVdKeUY4QVJPL203VVpWUUZv?=
 =?utf-8?B?aUViMURCL2JyRFlDYzZoYm44UmJzWU9WdzVJV2phcVpUd2t6K3l3R1l2YVhB?=
 =?utf-8?B?SDhWcWo2em16ZDF5REh3RlIrbWVrd1hrRkpBTkplSGVXeXRlL1F6N1doZWFF?=
 =?utf-8?B?UEdobEwyR0l6bnorV24yZ3Y0K2gwWVdEOS8yZElMa01rT2h3bzRIRXgxQ2Z5?=
 =?utf-8?B?MjBjQkx2MlJmaU1COEJUdkgyZ1JyTUhsS0xuSVUzV0NEb1NOZmd3eFJZSStJ?=
 =?utf-8?B?aTNnK3RSNk1sWFl3Y3pJbnF6T0RpOHJURGRPZ1o3cUNMeDFteGVNMVoyNksz?=
 =?utf-8?B?MG1JNWdyUTBTMFM3T0xoKzgrQ005S0dRRmpHZ092dCt4TE8yUHVmdjdqMEhX?=
 =?utf-8?B?NEQyMUk1MzdxcVlXQ1lncERtY2NOc0d3RU1ETlVPTFo0Yjc5dWFCdXZ1TUpv?=
 =?utf-8?B?RnVzNkNlYjRCdWFFM3JzSlhVcHZtNzVoRDVyY3h3dEtZTFRZK21zNFVSZFI0?=
 =?utf-8?B?UjBPYld6S1lZSUpRVEt4c3FRVVM4UXU0OFFKc3NMQXZyL01VdnBYRHZhczIz?=
 =?utf-8?B?YjRKSDJIZEVycjR5aThweHgyd3VTTmhySHdxUzNIY3NHd2ZkYVNxS3NKRkoz?=
 =?utf-8?B?NjNoUlMyRHNRSi9DcnpvQW1tQUpkSUpKNWlLcS9xQUVqZ3BtL3o2a2JVeHdm?=
 =?utf-8?B?WUFQUW5DTW16cFZSQnREa2dvYTB4MHFDa2NMMWRqSjBGRmgzdGpyeEQwKzAr?=
 =?utf-8?B?UGZjTGNQMlVjRWVzL1FCSnpCS0NZalJWdmd6VDZLQzVaVVBIaTdwMWR2V1Ja?=
 =?utf-8?B?N2xLazZTb0lsbmJxWDZmVUtyQ0Vxb25jVEYzUU9YS1IyRkZuWXdzMUYvYXpt?=
 =?utf-8?B?Tkx5TTlCRG9nQUs3N1RMSk1wUHhMbC9IcXFOKzFXSFRwcXV6Vjg0VGFwclpW?=
 =?utf-8?B?SjNlL1hrS3lRemxRcjNhUUR4WmdIaytxVEc1R0w4QnVzcURLbW8xdyswMUhQ?=
 =?utf-8?B?V1VOR2hrT0dLRkEvbmxXQ0J6eGFMNjNHRGUrWUtBSCtlcXM1ZFFOdlovcTNT?=
 =?utf-8?B?dHFIUngvSnFWM0cvc3JsSzZrNFBPL0xDeEw3Wk5qYU8rMEE1VGtuclRYdGI1?=
 =?utf-8?B?M1FsOW0xZW4rRnlVbG80dU1WM1hOYlBlZU9CbGdZcTRYSXVsc3M2U1JBay9J?=
 =?utf-8?B?WkZUbDNyMisvY05lVE9TbzNMNlBXaVlNMXB6dnhhcmZ1c214bHhGcGhPUVFl?=
 =?utf-8?B?NGRmNXFlN3FGaW9GZVBxUy9kVEcxWjI5QkQ0RFJHYU5XakpyRDhHNUF1d21Q?=
 =?utf-8?B?MHFYRHBDSml1Vm9EaFZrN2pFeFFmOSsxaWJrSjExYkdwb3J4SkYyT09BRHkz?=
 =?utf-8?B?RFppOHhNbzVURTVaU1RTU1JUeTN2aFVDRFFqbmhoUDltK3VRT2pzWUNIcWRF?=
 =?utf-8?B?UUhIUElRdTJ1WDRvL1pmQ3VocHNUdjNWb3R3R3dRUWNoMTloZ1JHaDFxejY1?=
 =?utf-8?B?a1BQMW1yOGdZUDhHV25jMFZka09ib1FtS2NlcFQ1VFE0Z0Q2RmhjWTU2UE5D?=
 =?utf-8?B?cDBqOUg2QzZMVElQcnhjNmw0ejh0MWNRSUpZcjVsY3JsRTFIamZxWVp1NWRP?=
 =?utf-8?B?WWliS3o0aXVMODhtZ2twOElLUDNKU3JFZFpQMjl6ZzZhWDljVEtNVmhyUVly?=
 =?utf-8?B?YUlBOHNRb1JDZmlpNzFxVkNjMklKQzhhYWtEaG5zT0pxMW94Znl4bmE1Y0ht?=
 =?utf-8?B?YVdHOE9GRFdHdG8zYldXd3dUblZiTUtuQ0lVS0tlVjJvejNsSTNXNm9wajlh?=
 =?utf-8?B?R0xvTTlQdkZSZ2JSZVJpRnpDa3pYcmhHdmUxakljNUg1UGw1OSs0TlFhWExG?=
 =?utf-8?Q?1Lcp916xaOeO7NpFKlHgjvI=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 298e2817-dce5-427a-1e69-08d9f5e1073c
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2022 08:55:08.9025
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vGAN3dKbmkj2uelkHTdSAazXKBFhnAOYO+4/ey9nFJH4NPnnj2KAhI5Pf8BYwnFX60Y2U4ThQ1i7W11qqNAWww==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB2863

On 21.02.2022 16:57, Juergen Gross wrote:
> On 21.02.22 16:31, Jan Beulich wrote:
>> On 21.02.2022 16:05, Juergen Gross wrote:
>>> On 21.02.22 15:31, Jan Beulich wrote:
>>>> On 21.02.2022 15:27, Juergen Gross wrote:
>>>>> On 21.02.22 15:18, Jan Beulich wrote:
>>>>>> On 21.02.2022 13:42, Juergen Gross wrote:
>>>>>>> Providing a macro for an invalid grant reference would be beneficial
>>>>>>> for users, especially as some are using the wrong value "0" for that
>>>>>>> purpose.
>>>>>>>
>>>>>>> Signed-off-by: Juergen Gross <jgross@suse.com>
>>>>>>
>>>>>> Over the years I've been considering to add such to the public
>>>>>> interface, perhaps even more than once. But I'm afraid it's not that
>>>>>> easy. In principle 0xffffffff (which btw isn't necessarily ~0u) could
>>>>>
>>>>> I can change that to use 0xffffffff explicitly.
>>>>>
>>>>>> be a valid ref. It is really internal agreement by users of the
>>>>>> interface to set for themselves that they're not ever going to make
>>>>>> a valid grant behind that reference.
>>>>>
>>>>> As the grant reference is an index into the grant table this would
>>>>> limit the size of the grant table to "only" UINT_MAX - 1. I don't
>>>>> think this will be ever a concern (other than an academical one).
>>>>
>>>> That wasn't my point. Limiting the table to one less entry is not a
>>>> big deal indeed. But we have no reason to mandate which gref(s) to
>>>> consider invalid. A guest could consider gref 0 the invalid one.
>>>
>>> With the gref being an index starting with 0 (gref 0 is valid, as it is
>>> used for the console ring page), the natural choice for an invalid
>>> value is the highest one being representable. A gref is of type uint32_t
>>> resulting in this value being 0xffffffff.
>>>
>>> While in theory a grant table could be that large, in practice this
>>> will never happen.
>>>
>>>> The hypervisor doesn't care. Imo this simply is an aspect which is
>>>
>>> This isn't true. The hypervisor needs to allocate resources for being
>>> able to handle the highest possible gref value for a guest. For a v1
>>> grant table this would mean 32GB of grant table size. Are you really
>>> concerned we will ever hit this limit? This isn't at the guest's
>>> choice, after all, as the max grant table size is limited by Xen.
>>
>> If we're not going to hit that limit, what's wrong with declaring the
>> entire upper half of uint32_t space "invalid" for use a gref? If we
>> won't ever go up to 32Gb, we quite certainly also won't ever reach
>> 16Gb. Yes, you probably already guessed it, we can then repeat this
>> process iteratively until we reach 4kb.
> 
> This reasoning is nonsense, and you know it.

Interesting. The underlying "where to draw a boundary" is far from
nonsense, I think. The only way to escape this question is to avoid
introduction of artificial boundaries. While it was me to submit
"SUPPORT.md: limit security support for hosts with very much memory",
I didn't do so because I thought it was a good thing to establish
such a boundary. Nor was I convinced in any way of the precise
value chosen. I merely took on carrying out what was discussed
with the security team in the context of XSA-385, when even that
discussion left it very much to me to pick an arbitrary value.

>>>> not in need of pinning down in the ABI. Yet if it was pinned down
>>>> like you do, then the hypervisor would need to make sure it refuses
>>>> to act on this mandated invalid gref.
>>>
>>> This is an easy one. We could just refuse to have a grant table of
>>> that size. I can add this to the patch if you really think it is
>>> necessary.
>>
>> Since grant table size is measured in pages, you'd then have to
>> refuse use of more than just that single gref. This would still not
>> be an immediate problem, but demonstrates again that it's unclear
>> where to draw such a boundary, if one is to be artificially drawn.
> 
> It should be as high as possible. I wouldn't mind just refusing the
> last possible gref, but I don't think this is necessary.
> 
>>> TBH, I think such completely theoretical concerns should not stand
>>> in the way of additions to the ABI making life easier for consumers.
>>
>> In case it wasn't clear - my concern isn't that sacrificing this one
>> entry may cause a problem, or that we'd ever see grant tables grow
>> this big (albeit for the latter: you never really know). Instead my
>> concern is that it is conceptually wrong for us to (now) introduce
>> such a value.
> 
> I have understood that this is your concern.
> 
> I continue to think that this concern is of purely academical nature.

Well, I'm not going to NAK the change if others agree with your view.
But I'm not going to put my name under it in any form. Academical or
not, it sets a(nother) wrong precedent.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Feb 22 09:08:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 09:08:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276568.472759 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMR9l-0001go-65; Tue, 22 Feb 2022 09:08:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276568.472759; Tue, 22 Feb 2022 09:08:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMR9l-0001gh-2t; Tue, 22 Feb 2022 09:08:25 +0000
Received: by outflank-mailman (input) for mailman id 276568;
 Tue, 22 Feb 2022 09:08:23 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=4CiU=TF=citrix.com=prvs=045c9559e=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nMR9j-0001gb-Ig
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 09:08:23 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id faa4ef12-93be-11ec-8539-5f4723681683;
 Tue, 22 Feb 2022 10:08:21 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: faa4ef12-93be-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645520901;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=G0yC55bS0sqN/tOVFAuf3P9vMcxoifgI3TwlFxeqjLk=;
  b=U/n45GF12imljsjNWCia2roEwtVjUNGVHIza/FDZ1WUiUNIybhPhmetK
   0ymH3otaFQ7vBjfnNfdoHFF4+TQoPfiA8beSpUJbqh+DI7VNISEHhdlDY
   2RdysXu2NczXYfVXstyO/osrlvSxXYcWxtVZRNmaBHS1YtuV/3tBVemfH
   c=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 66953380
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:fy0KR6wWNQwpTpPDbLh6t+cgxirEfRIJ4+MujC+fZmUNrF6WrkUFz
 zEcWDjQOfuONGb8ed4kPYu3/R8H68TXmtAyQAdkryAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGHdJZS5LwbZj2NYy24LhWWthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 NplqZGxVVx4Hvb2xr47a0B6DhljJIhvweqSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DJoQQt2sm1TjEJf0nXYrCU+PB4towMDIY2J4fQK2FN
 5JxhTxHTC2RewRWC20sJsgisO2MpnLFdA0JpwfAzUYwyzeKl1EguFT3C/LKfvSaSMMTmVyXz
 krW8mK8DhwEOdi3zTue7mnqluLJhTn8Wo8ZCPu/7PECqF+Zy3EXCRYWfUCmuvT/gUm7M++zM
 GRNpHBo9/JrshX2EJ+tBHVUvUJooDYAVttMSLwaszvTkIzsuiSEPnUdaxd4PYlOWNANeRQm0
 VqAntXMDDNpsaGIRX/1yop4vQ9eKgBOczZcOHZsoR8tpoC6/dpt1k6nosNLTfbt5uAZDw0c1
 NxjQMIWo7wIxfAG2Kyglbwsq2L9/8OZJuLZC+i+Y45E0u+bTNP9D2BLwQKChRqlEGp/ZgPa1
 JTjs5LDhN3i9bnXyESwrBwlRdlFHcqtPjzGmkJIFJI87Tmr8HPLVdkOvGwiehY0b5xYIGeBj
 KrvVeV5vsQ70JyCN/IfXm5MI55ykfiI+SrNDJg4keaikrAuLVTarUmClGab3nz3kVhErE3ME
 czzTCpYNl5DUf4P5GPvH481iOZ3rghjlTK7bc2qlHyPjOvBDEN5vJ9YaTNimMhit/jayOgUm
 v4CX/a3J+J3CrOmOXCPqdZJRb3IRFBiba3LRwVsXrfrCiJtGX07Cu+XxrUkeod/mL9SmPuO9
 Xa4MnK0AnKl7ZEbAW1mskxeVY4=
IronPort-HdrOrdr: A9a23:C/PmdKgQFcgEe350mLDb2PzmxXBQXzh13DAbv31ZSRFFG/FwyP
 rAoB1L73PJYWgqNU3I+ergBEGBKUmskqKdxbNhR4tKOzOWxVdATbsSlrcKpgePJ8SQzJ8+6U
 4NSdkaNDS0NykHsS+Y2njILz9D+qj/zEnAv463pB0MPGJXguNbnn9E426gYzNLrWJ9dPwE/f
 Snl656T23KQwVpUi33PAhMY8Hz4/nw0L72ax8PABAqrCGIkDOT8bb/VzyVxA0XXT9jyaortT
 GtqX2y2oyT99WAjjPM3W7a6Jpb3PPn19t4HcSJzuwYMC/lhAqEbJloH5eCoDc2iuey70tCqq
 iGnz4Qe+BIr1/BdGC8phXgnyHmzTYV8nfnjWSVhHPyyPaJMw4SOo5kv8Z0YxHZ400vsJVXy6
 RQxV+UsJJREFfpgDn9z8KgbWAkqmOE5V4Z1cIDhX1WVoUTLJVLq5YEwU9TGJAcWArn9YEcFv
 V0Bs203ocbTbqjVQGZgoBT+q3tYpxqdS32AXTq+/blngS+pUoJgXfxn6ck7zU9HJFUcegx2w
 2LCNUsqFh0dL5kUUtMPpZwfSKJMB2+ffvtChPlHb21LtBPB5ryw6SHlYndotvaPKA18A==
X-IronPort-AV: E=Sophos;i="5.88,387,1635220800"; 
   d="scan'208";a="66953380"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=B4Gb189I0O7cSnk6YGFQE79K/I8ebJXuI8erlv8XnhrJ/fgoUx1rvRXWsem2sgtFy92LoK/i83RLmI9yfpOCe2aZBgJ/XgnG8Gv8DcFPOYe4xa26LKWLZ2wo+iacsBj9QD4H2NjSmVmmSNPGpO4jwk6UMcOioPUbmyKsOEZMsV3k6AUJgwoKsYMWtmHH4vkB5v6xeapznw39OyxEFFIR/wBxpiT8W/7JHlDeFOeYZd0U9f36EUKgG0m/PMr288pFQD5hsigHYw8W2583V3lKOk9loWtgyA78Nlocz4QzZQvgnZevP5E4ZC6yPOR/SspY/5+KNIbwO8Qb4fh5zAagOQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=/dS/IeSJ8DSlTMyCGhRUeFVmOB5eHgZdLu+OSOPyKhU=;
 b=oUG8iRGAPRsoNo0RtNQhKnDFoqfBSU6Odl/xw/Uav6cw44aj6qj2hxwqAPHah1BDp5T1BwyR1C8sOjbOhFjBtRS+0H1diP/ZKmenRhu0exa2txFpFI/zjVSgj3ijbpj8jtCqpeO7HLZFsAru0FwLty0oJJAQvrSic/4kBwtViJxoGTRODp8uICgj27vUoF1e22V6KYXCc8362j7dSCIdM5QD38c6cK3zT3AV6F3PKW+HOBX/M4ZAoseXj+mpnS9Xp/m+ODaxXjMljcvYdXcN29hwJjaF6cL8+KjpMSMT2IcSVfr2QBMd3LjJZhrj/FsX8u2SkOT9Mplko5Q7y1/W8A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=/dS/IeSJ8DSlTMyCGhRUeFVmOB5eHgZdLu+OSOPyKhU=;
 b=r0IT/Lb3zd5x1ETMsB10F+Pfm23wmY6OzoxiKjDqRa5u0oKr0SAKUjWFEepCSS3zSspuPKN7OwkgsIaVw/pRkMPFfnfnTGDIJ1Wto+11xI5Pil8RLJEAV+mKJqELpsxaEMS8iNZSUTEKEAyZJKGdeBdTZuN+sXW+bqtKxv6GoMk=
Date: Tue, 22 Feb 2022 10:08:12 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v4] x86/mwait-idle: re-order state entry/exit code a
 little
Message-ID: <YhSn/Nsx6eElXpSU@Air-de-Roger>
References: <faff6a1e-9f00-e924-9766-deda8f0b38c1@suse.com>
 <2db7bc79-4fe4-abf6-9e5a-83055af9a78a@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <2db7bc79-4fe4-abf6-9e5a-83055af9a78a@suse.com>
X-ClientProxiedBy: LO4P123CA0377.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:18e::22) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 04d53a7e-8915-416e-6215-08d9f5e2dcaf
X-MS-TrafficTypeDiagnostic: SJ0PR03MB5424:EE_
X-Microsoft-Antispam-PRVS: <SJ0PR03MB5424A325F53D99D5408BB3108F3B9@SJ0PR03MB5424.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: ucTMvirhWPnR6ZV2GxojKeRlzk9onRA7R/mN83AFD9hAxpjRQ4LH2vsD6QQBEMH99tml4Ieq2SvTDWwehLRe0JmMxQfEzEP/ci7SiBRwwQk2P9Zb6AZPmJGmpRgFF/5BG/Ejfz9fQhceZBo+yLf/6kHpx9Ut8W0Ev/rtEYt7+dIISEBhhnKvawL2uNvMAX63PsQUZcX3LL+q7H/ENiMQ7uoCjpfdd33Oce6yWRK4XbbS8fIc0ZRJSvynj9uv8APMR8oFAhy49uvFzaAxNQ4Q32WjrEemLbppIzkPsR9Bn8RjW+bwiqmBLi23wO7tTuqDqpRy6igEundlQupbl3LWZvQcVm3res4DwcgpOdAEtwITfEp03i6Wb9GmpyBBcw51PVAw2IZHIYY8MBXCm+fAHnOCA+fmkBmeUTAtAVPeKgQ5V7PFwQO5ATeK2G7TBZfTWpKx2989Y7o+oqwleoektE6wzhStdsV1SuXsGOzllK3qIHL2nyA6jIiz/LIlnyvXPG79kQS+8rlvcOuRHNNOyKDDRaj9VukHopQRptX9wYHM6zATFOnO6Tw+1XnoqNP+VWdVbBddz9fNLgbWsK/CqBvIfy2g0xohs1TlOo5i+RKSZnbTIv67NltQb6Hf8D/5PFkiXL7WdgDt2FZFmszeJsMuxH1R6q2J1sxgwfvI3bUpam9ZFceBlN+H683EwG9Jvy4CBI7aF3oN+rwIzLzYIQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(9686003)(6666004)(85182001)(6506007)(6486002)(6512007)(508600001)(2906002)(38100700002)(66476007)(66556008)(33716001)(5660300002)(8676002)(4326008)(54906003)(6916009)(8936002)(26005)(186003)(316002)(86362001)(82960400001)(83380400001)(66946007)(169823001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?alpYOU9XNWFtbjV5RnhEQ3V1ZFJFL3FNbm9CTWZ4V1VRUlRHNUN3MW5KME5E?=
 =?utf-8?B?YjBYYkZ2RlJtaCs1U3BBWGgxZ1M4aWI1R2ZFVTFwclpueVhuRldhMkVjZDRz?=
 =?utf-8?B?eUtrQzRNbmJuYlUyK3VxZjI2TXRUOUJ5eXNUOEVORkh6RHVtNmlwd3I0bkZS?=
 =?utf-8?B?b0RNeTR6eW9FL3dpSnRHQjJna3ZEbGt4S2gvcERabjNoY0F5UDdTTnNPY1E0?=
 =?utf-8?B?S3BhSktiQ1FQUHJiZlVaZDljQXFVVld6bjd6UTdGODBueStEU0U2c3lJN0ov?=
 =?utf-8?B?VXQvMGxWZGN5ZFFGV2JaM2J3clNCWkZGYk5WbXBtTWZoU3daSGtnQTE0bENr?=
 =?utf-8?B?M3pPQzYxeW0vN3ExeC9uVVorYVVDSlRYQUwvMGtualUyUGljbVZtV1NiSFhh?=
 =?utf-8?B?Y2xiWS9pbThNYWdsa2Z1RGRmUXVYeS9WWXlTSmJHbno0VldRQ2s1T094UW90?=
 =?utf-8?B?b1BCTGVjbTAwbnkwd0VDaFJIcElucU9kRDB1aWxDRk1uU1FRTkZONzdyRDYv?=
 =?utf-8?B?cGxXUHA2bjBxb2RTSWljQy9hZjBYcXppa2FIVHc4WjFYSGJPV0tScjJMTUYx?=
 =?utf-8?B?bWZKZmdQZk1yQ29IMWxrVEIyTHpxcG9UWHUycXRCSDY2MGdBTDlSZjRIZzNo?=
 =?utf-8?B?T1UwaWU1MExKK3MxMkhUZlN6L2ZaTVBHRE9LLzVpWm55dFhjSm5zaUVmMHQ2?=
 =?utf-8?B?Qm40YURUaGFtK3F3VzA2RWFEc3IrektLOWplS0hGenlEeFpEY012NHc0VmNZ?=
 =?utf-8?B?RWZhM3A0Z1h1Z00vVDZzU0UvNUlyeUpzQWp5Z25FQ005VDR5NWVoQ1lqckNI?=
 =?utf-8?B?emtZbXhtSURTOUZnNm1oUjlYMUFXWTA4cmVaOXQ2RHVRN2N6NU42bE5yemRw?=
 =?utf-8?B?cWx0ZEdKdUdZQWZtVStBQVNoNnQrbUNYQ28rRktFSy95NE5BU29YZ3hJT3Bk?=
 =?utf-8?B?UEJFS1JyQmRjdC9Td3NWbXhvZVlodXRDbzlzZ2lISmNiUXVNcHc4b3ZHNFFF?=
 =?utf-8?B?VXE3WFhiZlJmaUQvU1k2UzlFellZL2dBMVN5NkE0S1p1M05iSHB6eG9tSnJD?=
 =?utf-8?B?TDdlSWZqcHNKcU00eVhKcWo2Z2lYRTZNcU00aitNS3lHY3JkeHN3bStwNVFG?=
 =?utf-8?B?OGhxNEpqMEt4azVSNXdaT2JERUN1a0ZaSTVZNzdyS0ZDNXFoOWw2bFJuRXJs?=
 =?utf-8?B?T3djYVNxSjBRNDF3b1lHWVR4TStZeFZCMU1sNm5FaFJvdCsxeHZSVWRsL2Zn?=
 =?utf-8?B?c0RyMXp5ZU9XbjA4b1VkUThmNGpkbGp2Y3FKbVRzV0ZzazhRNWZLdVQzMGdJ?=
 =?utf-8?B?cG5TUHpUdU84OEkwd3hzV0taaTlHM3FtN2cwb2RhYW5VU1I4Tk9kZlpWaGk2?=
 =?utf-8?B?aFEwbnh4V01udUlpVDZraW1NZDRkeGJIWEVUd014aWVXQWtXMzhNMzB2dVg1?=
 =?utf-8?B?MU9McDRSZjRKUitud25RS0xLWTNtZjhNaWMzR0RzMHU4OFc5eU5CNFo1Si8x?=
 =?utf-8?B?RVgxb3hkRXlPUmQ0WkZzcXpwTHQwMTMwY0hrOTJmTUFBK291OS9tZTZXOEty?=
 =?utf-8?B?bEloTUMvd1pjQ2RDT3A4bzloK1VKS055SUFETllyWU9RNDJicFFFR2kxYlM5?=
 =?utf-8?B?Slp5VVQyZlVXNG85U2FBejZHSWl0S0U0U2t2TW8zNTBGWmRVQnBCcGNFeHNR?=
 =?utf-8?B?Mm1Pa0hySEdZRVJJbXhTbVc5eXJFK2xMUll4RnBrNG1majlSTkRCZ1pVS000?=
 =?utf-8?B?QUxRWHovWHY2RXhOdWpmNjZxWHY0THdoN1BHYlI3YUxmQ2wydUhkRWwvWE5T?=
 =?utf-8?B?SlRCeHI2WGNtUUFTN0NuM3VYNUkzRFkrSFpIUHkrb05qVE5RQWpNZ0dLekRu?=
 =?utf-8?B?ZVAzajZhNmlSeUEvbk5vMWNXVzk1dE5vNTN5czBYY1RkWTRRVGFGS2Evc2RR?=
 =?utf-8?B?Z2dCazlmbU1sc2x3OWJXL1NyMkFQUDUxcGxZZEhWejNvenFhdHVDSUw4MllC?=
 =?utf-8?B?aTdBb1cwSml1RFRWMHczaFRMMjI5NWtGcFhONTZVUi80TXRmQmtCbWswbFpm?=
 =?utf-8?B?emwxWEJhTitJcG43TlViNW9wR3BOb0RxL1dhK1BkVnhsZWpwOWRQamFLem1S?=
 =?utf-8?B?aXJGTTYwb3g4QitoUUdFMlpZdkFTUTl2ai95MGFJUDhXUWhpRktnMzE4aXVZ?=
 =?utf-8?Q?diJEe5eHekMec280QWbcKUA=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 04d53a7e-8915-416e-6215-08d9f5e2dcaf
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2022 09:08:16.4624
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /vGbbWUfrZGZ+bhNvbCRvMkMQKiMu3H444JnKYp9ydeUZ73AEnHWJnCOygajSo5gXPaxgAv/Vl7KZ2ikq3FRag==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5424
X-OriginatorOrg: citrix.com

On Fri, Feb 18, 2022 at 09:35:10AM +0100, Jan Beulich wrote:
> The initial observation is that unlike the original ACPI idle driver we
> have a 2nd cpu_is_haltable() in here. By making the actual state entry
> conditional, the emitted trace records as well as the subsequent stats
> update are at least misleading in case the state wasn't actually entered.
> Hence they would want moving inside the conditional. At which point the
> cpuidle_get_tick() invocations could (and hence should) move as well.
> cstate_restore_tsc() also isn't needed if we didn't actually enter the
> state.
> 
> This leaves only the errata_c6_workaround() and lapic_timer_off()
> invocations outside the conditional. As a result it looks easier to
> drop the conditional (and come back in sync with the other driver again)
> than to move almost everything into the conditional.
> 
> While there also move the TRACE_6D() out of the IRQ-disabled region.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

> ---
> Moving the TRACE_6D() may be a little controversial, as this could lead
> to a sequence of trace records not actually representing the sequence of
> events, in case further records get emitted by interrupt handlers. But
> with us now conditionally enabling interrupts around MWAIT, that issue
> exists already anyway.

I think that's OK. We have to priority interrupt latency over trace
readability.

> Unlike said in the earlier outline of the alternative approach,
> errata_c6_workaround() cannot be moved: cpu_has_pending_apic_eoi() needs
> to be called when IRQs are already off.
> ---
> v4: Different approach (and title), as was previously outlined as an
>     alternative.
> v3: Also move cstate_restore_tsc() invocation and split ones to
>     update_idle_stats().
> v2: New.
> 
> --- a/xen/arch/x86/cpu/mwait-idle.c
> +++ b/xen/arch/x86/cpu/mwait-idle.c
> @@ -847,26 +847,25 @@ static void mwait_idle(void)
>  
>  	update_last_cx_stat(power, cx, before);
>  
> -	if (cpu_is_haltable(cpu)) {
> -		if (cx->irq_enable_early)
> -			local_irq_enable();
> +	if (cx->irq_enable_early)
> +		local_irq_enable();

Now that I look at this again, we need to be careful with the enabling
interrupts and the interaction with errata_c6_workaround.  Enabling
interrupts here could change the result of the check for pending EOIs,
and thus enter mwait with a condition that could trigger the erratas.
Hopefully CPUIDLE_FLAG_IRQ_ENABLE is only set for C1.

It might be prudent to only allow setting CPUIDLE_FLAG_IRQ_ENABLE for
states <= 2.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Feb 22 09:21:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 09:21:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276575.472770 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMRMh-0003w6-Dq; Tue, 22 Feb 2022 09:21:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276575.472770; Tue, 22 Feb 2022 09:21:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMRMh-0003vz-9s; Tue, 22 Feb 2022 09:21:47 +0000
Received: by outflank-mailman (input) for mailman id 276575;
 Tue, 22 Feb 2022 09:21:45 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=4CiU=TF=citrix.com=prvs=045c9559e=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nMRMf-0003vt-Ks
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 09:21:45 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d92ff154-93c0-11ec-8539-5f4723681683;
 Tue, 22 Feb 2022 10:21:44 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d92ff154-93c0-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645521704;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=ACa3DvRBh9KMcEYtqPqbWWXnOzdzKwiVElUtxnfxrIQ=;
  b=WXTSX9gfB4bwg9UYGu6u+qjchLN0HmM/f/XSOlsN0DzT3s/CGcb3tQZs
   Odo6xN0m8IynkV/rJs7q1GjEVHs6YvFHzY1//tbOFPZyPWaNFgcC0SPRE
   ROLeKxkKuANtG1CkYxvXv9XMnu4wh9NkXikkxfSQqdDM5Lr8geIhizZld
   8=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 66954165
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:kAxrSq76l+C78Uwh6gY2/AxRtC/HchMFZxGqfqrLsTDasY5as4F+v
 msWDD2APa2MZjPzfYx1PI61phxUsMXWnNAwS1Bp+S8yHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFx2XqPp8Zj2tQy2YLjWVvX0
 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X
 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx
 umhurSXYgZwFIPuqdg8eAEBAQ5nYKkX44DYdC3XXcy7lyUqclPpyvRqSko3IZcZ6qB8BmQmG
 f4wcW5XKErZ3qTvnez9GrIEascLdaEHOKsFvX5t13fBBOsOSpHfWaTao9Rf2V/cg+gQQ6eDO
 5NHNFKDajyZIA9mG289L6ljhaCrhFPCQyQH+Fes8P9fD2/7k1UqjemF3MDuUsOObdVYmACfv
 G2u13T0BFQWOcKSzRKB82mwnanfkCXjQoUQGbaksPlwjzW7xGYeFRkXXluTuuSihwi1XNc3F
 qAP0nNw9+5orhXtF4SjGU3jyJKZgvICc/17ErQQxiO89ov/+1+LKXFZSm9aV8Nz4afaWgcW/
 lOOmtroAxlmv7uUVW+R+9+okN+iBcQGBTRcPHFZFGPp9/Gm+dhu1UyXEr6PBYbo1oWdJN3m/
 9ydQMHSbZ03hNVD6ai09Euvb9mE9smQFV5dCuk6swuYAuJFiGyNOtTABbvzt68owGOlor+p5
 iNsdy+2tr1mMH11vHbRKNjh5Znwjxp/DBXSgER0A74q/Cm39niocOh4uW8ieRs3Y5tZI2OwO
 Cc/XD+9ArcJZxNGioctPuqM5zkCl/C8RbwJqNiOBjaxXnSBXFDep3w/DaJh92vsjFItgckC1
 WSzKq6R4YIhIf0/llKeHr5FuZdyn3xW7T6DFPjTkkX8uZLDNSH9dFvwGAbXBgzPxPjf+1u9H
 hc2H5bi9iizp8WkPHGMqNZLdQpiwLpSLcmelvG7v9Wre2JOMGogF+XQ0fUmfYlklL5SjeDG4
 je2XUow9bY1rSevxdmiApy7VI7SYA==
IronPort-HdrOrdr: A9a23:Di0qm6BaTHri7n3lHehOsceALOsnbusQ8zAXPh9KJiC9I/b1qy
 nxppkmPH/P6Qr4WBkb6Le90Y27MAnhHPlOkPQs1NaZLXLbUQ6TQr2KgrGSoQEIdxeOk9K1kJ
 0QD5SWa+eAfGSS7/yKmTVQeuxIqLLskNHKuQ6d9QYUcegDUdAf0+4TMHf8LqQZfngjOXJvf6
 Dsmfav6gDQMUg/X4CePD0oTuLDr9rEmNbPZgMHPQcu7E2rgSmz4LD3PhCE1lNGOgk/i4sKwC
 zgqUjU96+ju/a0xlv10HLS1Y1fnJ/ExsFYDMKBp8AJInHHixquZq5mR7qe1QpF692H2RIPqp
 3hsh0gN8N85zf4eXy0mwLk303a3DMn+xbZuCilqEqmhfa8aCMxCsJHi44cWADe8VAcsNZ117
 8O936FtrJMZCmw0xjV1pztbVVHh0C0qX0tnao4lHpES7YTb7dXsMg24F5VKpEdByj3gbpXXN
 WGNPuspcq+TGnqL0ww5gJUsZ+RtzUIb1q7q3E5y4KoO2M8pgE686MarPZv6kvouqhNDqWs3N
 60QZiApIs+PvP+UpgNdtvpYfHHfFAlEii8eV57HzzcZdQ60jT22trK3Ik=
X-IronPort-AV: E=Sophos;i="5.88,387,1635220800"; 
   d="scan'208";a="66954165"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Nd/E2N6hp0jayzZrqTW1FrEUxgEgCMgODZB3GrRay3F0haOj3KTPkx1vCe275UG8+avJl4wU8aC3gNnsCZhS8UcoQWUJyEPA1BhOeszmp0wN2eLSPYrB1FTGgooVqQFPTfeTNGF4QVMp/cWJrziN1Pm1UHH0gpfj2LXm22yuhuqhi7roQ9pv2FyHroyL0EwRxgyL8IAuWmyCZgtOPcYC0WbaD6onIOUC3ACfTwM6TLN/tPxMMeakV9yhCLdSumbXsrj1pGbPSqzNCXLw5O3EODDYb/WNqfMhagSOO2Wq0C45l8qTBuJzKMrQleRFChy09fbO86eksh+ekqANYI9PBQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=A+rDSTY7lRS5NQF2BOLMKBYxyt129NsK7YVVuf5nAxU=;
 b=BXmrpoapXRNEAhS60l7sQ9fWNuRe61WhpnkHJXTuxEAbtxNP9pVgM0cavuJU3SgR/tTQ7oxEeh7fjovGF4aq2604ClcwXuky28MTdKUi2x1r57CM1W9evT3VRUr8R5Ieeu/eINuCwDMmRbGl3XxkLTb6gmLkHw+EY03RZi0ukqkPkWc49k/4IVz58ZO6ZHQqVa1UASOdP/TpN50I5e8P6av33zQntvMffcwQ+GN8s8CLxVvjA3sUeF3kpDWyMcV3hkzB+nXpjB9fd1RIF7nNK9Daf5/celaBMRy5TKJsVJ+Hz0Ig4k3aKurh0dJoqXVcY9qQpGGYuvfTPcQBrAK5NA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=A+rDSTY7lRS5NQF2BOLMKBYxyt129NsK7YVVuf5nAxU=;
 b=JlxDXCGUR2Owea/2tHs2pSP5hmFlvcReWOOlCI716ArlwPl61/ldLgQ5/UmJtW2aezQN3AltYgurBqdcPl2hYv/xjtDzNBXCEAk1JlHTWM0lIiWnyapHFzy0NajK1vQV1I4FYIs7cXZwOBncyFEb+BVsWeVPdFskqXrN34aTm8E=
Date: Tue, 22 Feb 2022 10:21:28 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v2 2/3] SVM: sync VM-exit perf counters with known
 VM-exit reasons
Message-ID: <YhSrGECFFGafLehR@Air-de-Roger>
References: <ff461a77-93a0-5424-6565-2e947bec3912@suse.com>
 <00a9007c-62ef-8bad-5a92-67d0b880fda6@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <00a9007c-62ef-8bad-5a92-67d0b880fda6@suse.com>
X-ClientProxiedBy: LO2P265CA0442.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:e::22) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7c29d9d3-fa8d-4ee3-3b4e-08d9f5e4b780
X-MS-TrafficTypeDiagnostic: MW4PR03MB6394:EE_
X-Microsoft-Antispam-PRVS: <MW4PR03MB6394E0115C3C5BB170ACF1FF8F3B9@MW4PR03MB6394.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: m60agfg7r2wLp6BKX/KVtyV24XomfIDidMLQpCsjxC4g7oF4v8uATf+PCTBDyaZR/7jwJrc2IPM5CUuUEzWUkS6MQ82i2/RWdIg4VJDa8Lvh2WPtejUGXRqs2p8iBanKfsj8UB9jg2iSNI2Jlobq77WMYLQzp8jso3P7X70oC6cyUktUjfHak6XBpLPGr8nkWTyf5aRVn2bwTfzd47lTuJnyQUqIGYWRGz5uXelpm+mK/ekS+EeiSUeCTyq3ZQVnqvKTE8LRxD26TcgeprLU7cFKSie+5d/pJ/0lVTjl8hi1EzolKHe6QlWMYEA5RIL+0yAJJQAtORM1MVdaiwPETLCE1fw9lRKuNnL8MF6qatoMWoGBeoPgBFYQN+Tu94u3O2yXUGsXHD6i72OmOm19Qj+YBICeJe6yhvBrol+uwszZ+SG40zydI5jEQNRfxhTZWcytEIYaVDryfpwgz4bpRiaQlDiUoSb7AcdpPoWCO3RtVcnxw5Fp5iedXHoY9SJAZ64fbyowPZxVlCIKEKxtdq68aGyiCUUtkwKprl9/WxY8wDaifCQvt9qNWIjtxnn2tvET81fwMNVgc1D4r1SpHs2nwsbDmTAQE0lgiBEWoHWCiygOJ8GGCxUgA9nnDctZzJ4fK7zhZGnWjt8zDlqByg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(54906003)(508600001)(4744005)(8676002)(86362001)(26005)(85182001)(33716001)(6486002)(4326008)(66556008)(66476007)(38100700002)(8936002)(186003)(5660300002)(6512007)(6506007)(6916009)(6666004)(9686003)(82960400001)(66946007)(2906002)(316002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YVBPajdWOWgyNkpXWkhyZHJZOGx4U0Z6Rmo3bHRGSXBQQVRJNk1qcnE3Zmti?=
 =?utf-8?B?aGQxS01TWjVnNVJ1SVMzMy9CSm4xdkZKVDBTajJFanhodXRQV3ozNmNsY1Nu?=
 =?utf-8?B?RkhEU0RkSXZGN0o3dFVBcFNxQXh4ZHpnVUxDYTRiZ1NIejRpMldFa2dlb3JV?=
 =?utf-8?B?UFBMWFNtSHM3NlBzMVc5RGowNWk5K2N4YThLSFpBOFVLT0tmZ1hzWVVRbFE2?=
 =?utf-8?B?Q3RmZnRpRVhuOW1oNkdqYnZuZloxNGQycmxHa0YzeVNKS1VxUW5HRG1iMlhT?=
 =?utf-8?B?L3MwSDdqU1gyczdQcGxEajd0OUd3RXAwRFVzR0dnNit4NTZxUFFJblRQbDVB?=
 =?utf-8?B?T053VXFwUWRaWTJ4Y2lFOFlxK3AycVV0NkhHU2Y2Rk9GMEZJeVJ2TjJySS8x?=
 =?utf-8?B?RWI1S1NETmhtN1QwSUlaaWRaaXNoL1BWa2hzR043QlVMYTJlV2YwNE0wREJ3?=
 =?utf-8?B?QzB1RThzRTlQeEhnVkRJckR6Zy9BOUh3K0pIODdhajdMUmJQU2tXTUlaRk5Y?=
 =?utf-8?B?K3RISnJRNkxmN08rL3c3c29nRFUwTmFkcW9TbDVjOTVwYXM4OGV4RDJLbS80?=
 =?utf-8?B?VXNGS2ZLUFdaWWgvUXhncDlSYlIzZUVDQWdWVjBUdUp4VkZ3anVyY3paUlpr?=
 =?utf-8?B?b21SeGFRVjRMbENPOGNkTnBtWThoUllaMjk4b2xhcTJzc3hpRS9xa0dzWmdF?=
 =?utf-8?B?VFBvbExVZ1RTd3hLMFB3K3dJR3VrVEFTZXA2TUdXTzVRelhSN0NDRTluNnBY?=
 =?utf-8?B?UGxFNGFqdSt6OUlrV1d3dzZSc28vcHNWNGZOZHMwUCtuNnB3c1dEb1poOGRH?=
 =?utf-8?B?MVJLcTMrQU5LRDZsLzJHWEFUMW15SVFWY1RPT0UxcUl4MnFzRkVwdk12Z0Rp?=
 =?utf-8?B?ZGZYMzJXdjBncElRdmlJRUdCMXQxZTZEVGNWcjhkdkFQSUU4alN0SXRPRzJR?=
 =?utf-8?B?YnJRR2VyLzJMczlDWmZ4ak5aWTZzaDRCYXR1cURSdStZVmhOSlhqZS9uYnZm?=
 =?utf-8?B?T1dTTjFsODBoWC8zV1c3bThwOW9aNmZ2VXZkdXg4Tm5kNFlXMzFIVFY2NE1r?=
 =?utf-8?B?Tnk4eEhUNFpGMVl3R2VXOHU2YUZvSWxpSXpVSlZCWUowcXJCL2Jic1RNNkda?=
 =?utf-8?B?VWFDWEhjNTBSRnc0ZkNqR1Q2VU5UZHdCemVZUU9KWHZ3NEhhQlo0N1ZJa0F1?=
 =?utf-8?B?TE1qOHZ1S2Y0Z2Y0YWtxdGx0MmxCMUZjd3ZkNVM4SXNxaHJoS1hZOHAxSllN?=
 =?utf-8?B?OW5wOHhNOXd5SW13OW8wV2tPcDhDdGtZemFzeVF4RlV5d0VSMU5nTUpNWVB4?=
 =?utf-8?B?TiswTS9Gc21YRWowRUYvbHNoYXRXdEIwdDhINUNwOHBSZFRFV0hRdEVrUHpi?=
 =?utf-8?B?R3plaDk1NVdEQTM2VTNVanJLTUtJa0JzblFuRDBNZkJ0VkJYVTdrd0JWeUhW?=
 =?utf-8?B?TzFLMmNEak5XcmxVVjJOaldVT21JWFI3anFZdGJTVFBVSG03M2RGbDJua1V0?=
 =?utf-8?B?SUNoRlg0VWZPWlgrY1F2d2pnTGhrb2Rua2c5anRkQTZSd09yRXpiT0ZIY3BM?=
 =?utf-8?B?NDdHK29FeVFPaDVLSGZCeWVjNHJWYkx2R3JZdlVObDluRDd0TzhBaWl2L1hH?=
 =?utf-8?B?b3lWTkJtMm93TFhJbzJLWExIRUFJZ1NrOHhrYXhiNkRBaXlvQXV1dEFHemJZ?=
 =?utf-8?B?ZytBRnNSUHV6b1p5aVp0YXN2d3BuVkMwaVgyT2FKSnVPanNydm5rS1ZrNzJP?=
 =?utf-8?B?aXdPL3V3OVZqN0Q0bkF1SEVwc0thbWwzVkxoQml6bEYwMUlPTjNGQ3FwV1lG?=
 =?utf-8?B?ZnRxMVE1NUhURjBhSzhsbVdRcnVKMVhKRUNsRElKcERqY2dIaWM0V01IQ21h?=
 =?utf-8?B?N242aG0rMGRMTjhaK1B6RGNSdmRNQmVDOWNJdk1rZ0wvZTkxR1N6c2g4VkRv?=
 =?utf-8?B?Q3cyanZoT2NETGxJT05GU2x2Z1pXVEF1cFFJQitmRDVGNDlQMlZpYzl4R3Ir?=
 =?utf-8?B?clZubkwzcHB3S1N2QVFwbTBnY0tGUC9hQTh5ZzNOcEFnL0pDVVVJcmhZZUZh?=
 =?utf-8?B?R05HVEhzRmZuRldrcWc5a0Q0UjlhaGdOblEvZUhtL0t4ZkZSRmlhZUhUN1k5?=
 =?utf-8?B?TEtHWnNYcHQvMWoweEpCQ2I2eTM3QjNTUGdrbk4xUmdrWXVnQlVScWhyQXo1?=
 =?utf-8?Q?23HnzpwvwJGdKdjusrfn8WM=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7c29d9d3-fa8d-4ee3-3b4e-08d9f5e4b780
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2022 09:21:33.0868
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zi6HVNHTLY6ohKpT4xjwv+xxZrNti3xy1fd3031Mj1xhpYWxtJ6MEv/CWU8DCciSlTdPR/GO7y664CzVdT0SEw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR03MB6394
X-OriginatorOrg: citrix.com

On Wed, Jan 05, 2022 at 02:58:11PM +0100, Jan Beulich wrote:
> This has gone out of sync over time, resulting in NPF and XSETBV exits
> incrementing the same counter. Introduce a simplistic mechanism to
> hopefully keep things in better sync going forward.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Feb 22 09:30:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 09:30:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276582.472781 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMRUk-0005J7-A5; Tue, 22 Feb 2022 09:30:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276582.472781; Tue, 22 Feb 2022 09:30:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMRUk-0005J0-5g; Tue, 22 Feb 2022 09:30:06 +0000
Received: by outflank-mailman (input) for mailman id 276582;
 Tue, 22 Feb 2022 09:30:05 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=QzH2=TF=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nMRUi-00059y-Ut
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 09:30:04 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0399790f-93c2-11ec-8539-5f4723681683;
 Tue, 22 Feb 2022 10:30:03 +0100 (CET)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2110.outbound.protection.outlook.com [104.47.18.110]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-23-eqG4bk48PYudGDjzL3Exsw-1; Tue, 22 Feb 2022 10:30:02 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by PA4PR04MB7710.eurprd04.prod.outlook.com (2603:10a6:102:e6::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.26; Tue, 22 Feb
 2022 09:30:00 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.4995.027; Tue, 22 Feb 2022
 09:30:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0399790f-93c2-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645522203;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=UxGUja8wR0wdlRFQGPfsJs8qAIY2KjxDeviwEOwRZZ0=;
	b=YjHgoccoQh8ktsZCCqktC6Ze4Pgr+bDQNyAXRKu628hSkODC9ieJMnq9CAP14XxKjhPitf
	OxvZH7ceNK/H2i1+y75zIfh80/ufTKzTvuw3evKZMJy8xfax86eQsrWOVKYhDea+D5woPf
	GZ7k7tLcyCU966xyuC0y94XlMnMAvpE=
X-MC-Unique: eqG4bk48PYudGDjzL3Exsw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=nTq0/9HUQUUbSvb02ZYhG8NNcDrlpLQmaXic0bNqi0dFnKAai8q5PQTEU994Ih5FrUQtY9dLXNEyWtMeXkbzqXjs9QHi2U1YvSkxmoA1oAEzMbYE7BtxvfeBMKXK/kJneI+AMTVMhM8SJDc1/H0bbn0Qqk+qRJtSyfvYYG/t12ks1YGSLZ0prBTCCThcj9x1j61eHl9iJFQIYN6aeeT7xlwcOv8cKlAok6yojEvNK+q9W2gaUePTUfNjuy8TnfQs6S+mJXsucIgtMUnLWZdyfGzR+U73cNa4CqmI+wKD849jSwLT7a33m4AitTagHUuQ7TIcto2Xm+AicFScYSQ2Jg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=UxGUja8wR0wdlRFQGPfsJs8qAIY2KjxDeviwEOwRZZ0=;
 b=mRdcMH2ivgKtmytdDlMMSioe0cG2mHN+8915FMMFhLI6eKHGtiOJqWtfGrQWO1tMIw4EoxdskMm1m2c3Tumrm8juCPKks6oJKFJ9wUsln5jG5Hqz/FDO374Xxzair+Dd3os3yCkAkUmgXF/Z0jueHAdBdmxRrk5DkSJ7OMuD42/5p5srJFX5F0137Cn1b9vyk4pCxcycgRcduUHPB278cOYP2GcTfZltX/owwpLLC3gcDJPwpBC9+hlBN1WfseTFOSxX8+5ArYe2QMuDjsZBZm8qiEnUP04mHjlUMx034Uf+g9Hfkkz6JUjcKENYtZQqL/tKydV6shgLGs1DRqkAsQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <0c253fda-c5f6-b7ea-df6c-8b43b86c6a59@suse.com>
Date: Tue, 22 Feb 2022 10:29:58 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v2.1 8/7] x86/IOMMU: Use altcall, and
 __initconst_cf_clobber
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20220214125632.24563-1-andrew.cooper3@citrix.com>
 <20220221180356.13527-1-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220221180356.13527-1-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P194CA0032.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:209:90::45) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 97dfaaf0-3cd1-4dcf-2cdb-08d9f5e5e5f7
X-MS-TrafficTypeDiagnostic: PA4PR04MB7710:EE_
X-Microsoft-Antispam-PRVS:
	<PA4PR04MB7710372B77F097A8185F66AEB33B9@PA4PR04MB7710.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	yX6QBG9JCgKnIbh4oDDumcTWBgwtDQe/RyjyXDUTXE++CPxQL5gdLkpLoYmByEvzQS89t8vh0UdSAb0TdwORBIMfo6rZngoA5QhTWL00QsTlGcbJInSG5tWdRbu5hh5iK7FkTwyhUrwP8nv7GZi3PfF6oJ7QJUZYXExx/LUecRlBePVvm84rKvDhzNwt82bebDw0/63JFKuOk7xz1b00evyofjykD5AZSyJSj4i2a9XcEa5pXYLScQ6wJOacFcEiK83dxKh6A+aqUdlO+43LI8HRhTqf76Ls4pnWalOpnXkCdL1Xue8K888TQdTTHSzKtmSxnFR/cP/8gqFDQkwgjm3aS4GB7XvUTka07zabbJOwi308Ejr3riHsqeqdoZGLfayDyAiWP+KwSoc9E2HwA5uIkc06ZVCM9lc0hONjkVQbyRjrdtEv+NPp7EWd5pfHZ23f+OXy/q/KY2O1E3HOZcmvL4eaQ9z4gdPwy/rx41DonGcLrwvhQaIJ9TKRy3pMf+T0+LtJV+8RlXNEj/iRc59ZSSIg7Z7H6LRVbW9qxRQDLZ4LfkvzyQgCx5LlAHW/yDDIKRXN6d22fAjotyDcpUmoB8gdHfZJGKQDBQG6TcneChx9PF1krtqTK+G1mirvcBoUOJGz6K7Cfa0i4Ht+QIf6ec8SAk0FYYFjYg3JCyEjtu709xQ2OWhypLe6KxpqLKGNEQ1RHap8Jq207D8wQxJJ2av0qxMwNVrkgvCY3eXvdoUup7u/8EwkCmTIqrJf1csQxOqfRTn42PX29w0btREfqjyekFz0Zzpzv36NXhg=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(36756003)(6916009)(38100700002)(6506007)(6512007)(53546011)(186003)(26005)(2616005)(83380400001)(31686004)(6486002)(508600001)(5660300002)(8936002)(54906003)(86362001)(66556008)(316002)(31696002)(8676002)(66476007)(66946007)(4326008)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?OVBiRkJsVnZaenoxbXc4RWlwMVFBdytkdjZ6MWV1bmF2SWhOeEtxa2NGdm1m?=
 =?utf-8?B?V1d1S1l1VDRma2VLYTZkeDJsTjFKTnE4NzI0REZxb25DejY3VUdqeFJDaSt5?=
 =?utf-8?B?Q0pITDIycll2dGZaWVhLQ3Q4dDZYV1I3ZVRvTnA1cnFlbzlzSHArVkhCVmVE?=
 =?utf-8?B?QmZMU05sbVlPbVhkWFE1K1R5aHhPK1M5YWJldk5lemo3cUY2cFArNFZqS01N?=
 =?utf-8?B?R21Pa1RlU0pTdUNlYW1saEFPM3FRSThXR09PMzJYOTFEaDZTTWloVHYvRlov?=
 =?utf-8?B?K25UYXJhc014YlQ0QUJWQ1pLakk3R040bXhxaTBpUWRYM3NPZk9LcWgzbmk4?=
 =?utf-8?B?aFVpa3E0azBRK2UrYzFpeW1valRXMllYdW1DUXUrQXZGOU41S2pTVm9OMExU?=
 =?utf-8?B?cVZ4M01paCsvRnF1YmdPWmtRV2YvMm9BWEl1TmpjZVJoa201UE43V3FBbHNX?=
 =?utf-8?B?VUdjRW90aTFTYzFNNEpwRXRsaXNvSU0zZjF5NnhWdS9RcUZxcnZZMXJRMms5?=
 =?utf-8?B?Wkpvak5MTFhTZEpzYkVXYStnbzhMS0RDV2ErenNqVFl2YTl2RStSaTFmMkNh?=
 =?utf-8?B?MTVFVjdTeE1ncjlDanpoM21oUmxxeGs3WkJpdDVmTDNoOTI2TmNYcVJVUTJQ?=
 =?utf-8?B?ZUpMdHpPNWRlSERXVjB6S2plQlJCeG1ZTjl0aHo3emRJZDFjZ3BVSmIwbWll?=
 =?utf-8?B?bUltTUQyNFdXL09jUDNheVMvMnBhRnEvZm5jbFVnRmlZREIreWpPMlVwUjRM?=
 =?utf-8?B?NSt1VWl2N2l5WWZXenBjeEdjZzVtWE0yckExU3VybmdGQmJXUzRsRVhjUmVG?=
 =?utf-8?B?L2I1K0YwUzZYNEFza0pSYlA1VVZXUld0eS9sMEIxQ09HRWNMM29KaWwzSDVy?=
 =?utf-8?B?NEtsRDh2V3VONUJxNWJlcDRCSERPSU4wcEpHV0poSUpLOFlISUpzWUxyaXhQ?=
 =?utf-8?B?KzVOK1NmalliajdPUk9DZEVYNHZHeXpCSHo3WVYzVjNReUsycHF2K2syOEcz?=
 =?utf-8?B?UWVwZXhPVW1LaWkybHdHaENndWtha0dPcmxNMUdVTWFFUVNUUWxKeTM4akRk?=
 =?utf-8?B?NVhpeVlOeFhJMi9ncGw2eGloMG40MUxpNndXY0pZcnR2N292UUpSNjAwOGZT?=
 =?utf-8?B?b1NLYkd5eUpiam9IU283NUd3T21rVnJVYTBzYkhGVzJJT0RKb2pIMWdISHVB?=
 =?utf-8?B?RmZmVkxDaW5JWUhUU0R1VVJ6YXpWeXBBT3RvSnNERkVFWVdOZ0w3UENPQmFS?=
 =?utf-8?B?T0h1N2xXbEw1RzVPZ25yT3dZYjRmK1NQT1NSeGdBbThRaE9WRUJ2UW5uZTlI?=
 =?utf-8?B?d0d4MGRDcUlxQ2hQVXBPblNlVVMvbGRQdHlSNDJ0cXJNV0pPKy9MWXpvU1pM?=
 =?utf-8?B?eFFwTnZOZUloRS9aSHpFRlMwbFNUQVZjdFNUNXN3NklIOFBIeGNzSGJkYnBx?=
 =?utf-8?B?WFkzbWY1NWE1aWlBbS9CSGpaNHN4Y2VYSjgyYUZBTFVPM2pMZmx5cHlGdWp1?=
 =?utf-8?B?ZTA5VE9zREhZOEVxUm1FNEJwWGNKbEYwQlNmOVhpWmZNUzR0SXNaY3U4QmF2?=
 =?utf-8?B?Nm1mYW9LYlA3bzNTaWgyYkN2L2xhRW5FNnNNbmovaUc0ZEZSSjVTZjBmWXNI?=
 =?utf-8?B?NVZlMmhhQUp0bWR1T2pFOWozenBJNWQ3eXZhckxIWlZobWpDbUZtbmRQL0px?=
 =?utf-8?B?MkM3QnM1VU5wdmVseWRhQmpXdlNEdXNvbkl3WUNDd004dnA2dStNbVRTSUMw?=
 =?utf-8?B?eGRWZzIzSDVpQ0FnRHo1eXpaZ0hmNHpDdWg4QzNmQmhQVkFkcEVTYmtRbWNV?=
 =?utf-8?B?WHplM0w3SzZGa1ZhNkZ4UllQUE43cm4xR1VRRms1Tkl4ZmtyZHpoRDV0b0wz?=
 =?utf-8?B?WTVjMnk2dllIaEFCaE1Wa1ZMOVp4M2pCby9sTlhEaGhnVE5yUVJRaTgyOXhP?=
 =?utf-8?B?OUMzRDhJQ1gzb2J5clRtaVM4VEpJN3g4dUhvbmY5TWRQNmk0OE01cFJMRjBp?=
 =?utf-8?B?VzRmQU1ObHlpaFRqMGlISnkzSzZhL2xIRDF3cDM0TFV0dEdwTzB0NnMrR3d2?=
 =?utf-8?B?MWlHRmxMUU54bUNLbUloQjgvcWY4bTBaN3IybXUvclF4d3orbHBINVIwUmRX?=
 =?utf-8?B?QXNaaDY5TkdjR0RCTjNjZmdkVHFYQ1VqSGZmdkN0bERNTnQ3VFNkZ25DZTlu?=
 =?utf-8?Q?3B5DkjZPIwkN6yZdeVrm3FU=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 97dfaaf0-3cd1-4dcf-2cdb-08d9f5e5e5f7
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2022 09:30:00.6320
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Kam0QuTfoCaJQumX4NFsWVK9gNWkWrK/OloDYXeh/0MdCFIke7pXe7kEa13yLUWjHrKi1KZBeDGFq+TimdG8AQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7710

On 21.02.2022 19:03, Andrew Cooper wrote:
> Most IOMMU hooks are already altcall for performance reasons.  Convert the
> rest of them so we can harden all the hooks in Control Flow Integrity
> configurations.  This necessitates the use of iommu_{v,}call() in debug builds
> too.
> 
> Move the root iommu_ops from __read_mostly to __ro_after_init now that the
> latter exists.  There is no need for a forward declaration of vtd_ops any
> more, meaning that __initconst_cf_clobber can be used for VTD and AMD.

The connection between the forward declaration and the annotation addition
isn't really clear to me.

> --- a/xen/arch/x86/include/asm/iommu.h
> +++ b/xen/arch/x86/include/asm/iommu.h
> @@ -72,7 +72,6 @@ struct arch_iommu
>  
>  extern struct iommu_ops iommu_ops;
>  
> -#ifdef NDEBUG
>  # include <asm/alternative.h>
>  # define iommu_call(ops, fn, args...) ({      \
>      (void)(ops);                              \
> @@ -83,7 +82,6 @@ extern struct iommu_ops iommu_ops;
>      (void)(ops);                              \
>      alternative_vcall(iommu_ops.fn, ## args); \
>  })
> -#endif
>  
>  static inline const struct iommu_ops *iommu_get_ops(void)
>  {
> @@ -106,7 +104,7 @@ int iommu_setup_hpet_msi(struct msi_desc *);
>  static inline int iommu_adjust_irq_affinities(void)
>  {
>      return iommu_ops.adjust_irq_affinities
> -           ? iommu_ops.adjust_irq_affinities()
> +           ? iommu_call(iommu_ops, adjust_irq_affinities)

While this (and other instances below) is x86-only code, where - with
the removal of the #ifdef above - we now know the first argument is
always ignored, I think it would still better be of the correct type
(&iommu_ops). Perhaps the "(void)(ops)" in the macro definitions would
better become "ASSERT((ops) == &iommu_ops)", which would check both
type (compile time) and value (runtime).

> --- a/xen/drivers/passthrough/iommu.c
> +++ b/xen/drivers/passthrough/iommu.c
> @@ -540,7 +540,7 @@ int __init iommu_setup(void)
>  int iommu_suspend()
>  {
>      if ( iommu_enabled )
> -        return iommu_get_ops()->suspend();
> +        return iommu_call(iommu_get_ops(), suspend);

This use of iommu_get_ops() in such constructs is a pattern we didn't
have so far. Perhaps it just looks bogus, and all is fine in reality
(apart from the whole idea being wrong for Arm, or really any
environment where multiple dissimilar IOMMUs may be in use). Or wait,
there are pre-existing cases (just not immediately visible when
grep-ing for "iommu_v?call") in iommu_get_reserved_device_memory() and
iommu_setup_hpet_msi().

> --- a/xen/drivers/passthrough/vtd/iommu.c
> +++ b/xen/drivers/passthrough/vtd/iommu.c
> @@ -56,7 +56,6 @@ bool __read_mostly iommu_snoop = true;
>  
>  static unsigned int __read_mostly nr_iommus;
>  
> -static struct iommu_ops vtd_ops;
>  static struct tasklet vtd_fault_tasklet;
>  
>  static int cf_check setup_hwdom_device(u8 devfn, struct pci_dev *);
> @@ -2794,7 +2793,7 @@ static int __init cf_check intel_iommu_quarantine_init(struct domain *d)
>      return rc;
>  }
>  
> -static struct iommu_ops __initdata vtd_ops = {
> +static const struct iommu_ops __initconst_cf_clobber vtd_ops = {

Ah yes, the conversion to const (and the dropping of the forward decl)
could have been part of "VT-d / x86: re-arrange cache syncing".

With the missing &-s added and preferably with the description adjusted
a little
Reviewed-by: Jan Beulich <jbeulich@suse.com>

Jan



From xen-devel-bounces@lists.xenproject.org Tue Feb 22 09:33:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 09:33:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276591.472792 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMRXP-00062n-RA; Tue, 22 Feb 2022 09:32:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276591.472792; Tue, 22 Feb 2022 09:32:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMRXP-00062g-O5; Tue, 22 Feb 2022 09:32:51 +0000
Received: by outflank-mailman (input) for mailman id 276591;
 Tue, 22 Feb 2022 09:32:51 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=N+X7=TF=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nMRXP-00062a-6h
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 09:32:51 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 66818808-93c2-11ec-8eb8-a37418f5ba1a;
 Tue, 22 Feb 2022 10:32:49 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 449471F399;
 Tue, 22 Feb 2022 09:32:49 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 08CB213BA7;
 Tue, 22 Feb 2022 09:32:49 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id Xi3aAMGtFGKZXwAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 22 Feb 2022 09:32:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 66818808-93c2-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1645522369; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=RA2JQbvipU8RtguBS6Fx6ajIPHPHvPNYRaPJxCaD5FI=;
	b=JI0P0y0aSt3qMRtTHZ8SoGMok0Bv2LEVE8T6rRmI/REPB89pR6HPIwNuqxuaGJTr8+MwHU
	z2oJv4IK3ZgqxJQsdfAoFNC7vb+dPJYz+ds2yvl/kGe8PUfZYE9YFpwSWGXMuIETaENaKY
	cynehuD+j10afRNPzbegPjEtHB1JN3E=
Message-ID: <732382d7-2578-1644-f730-4b7776d26f22@suse.com>
Date: Tue, 22 Feb 2022 10:32:48 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Content-Language: en-US
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220221124221.10245-1-jgross@suse.com>
 <5bf7424a-c295-7aa5-4bf8-13136065a06b@suse.com>
 <7798d54a-0aa8-5c13-c8fe-50e3dca54b12@suse.com>
 <28f2b406-f36e-e115-d6ff-cdcdf22f68ec@suse.com>
 <aaef1839-96b6-0d6c-df3b-d31cc7fa697d@suse.com>
 <e8a17311-1a56-23d1-7414-0f9ae18cc0e1@suse.com>
 <06890331-8c75-ddb9-57e8-284c47d4d562@suse.com>
 <fbd980cf-71c2-aa8b-4d23-acbb457431fd@suse.com>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH] xen/include/public: add macro for invalid grant reference
In-Reply-To: <fbd980cf-71c2-aa8b-4d23-acbb457431fd@suse.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------vfM5YkAeu56D4ktMkZ23gtlE"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------vfM5YkAeu56D4ktMkZ23gtlE
Content-Type: multipart/mixed; boundary="------------of0fjyPoNZ4Cgev6ZCRit6RR";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
Message-ID: <732382d7-2578-1644-f730-4b7776d26f22@suse.com>
Subject: Re: [PATCH] xen/include/public: add macro for invalid grant reference
References: <20220221124221.10245-1-jgross@suse.com>
 <5bf7424a-c295-7aa5-4bf8-13136065a06b@suse.com>
 <7798d54a-0aa8-5c13-c8fe-50e3dca54b12@suse.com>
 <28f2b406-f36e-e115-d6ff-cdcdf22f68ec@suse.com>
 <aaef1839-96b6-0d6c-df3b-d31cc7fa697d@suse.com>
 <e8a17311-1a56-23d1-7414-0f9ae18cc0e1@suse.com>
 <06890331-8c75-ddb9-57e8-284c47d4d562@suse.com>
 <fbd980cf-71c2-aa8b-4d23-acbb457431fd@suse.com>
In-Reply-To: <fbd980cf-71c2-aa8b-4d23-acbb457431fd@suse.com>

--------------of0fjyPoNZ4Cgev6ZCRit6RR
Content-Type: multipart/mixed; boundary="------------I2mG9Uk8L00DeHksLDpP2bU4"

--------------I2mG9Uk8L00DeHksLDpP2bU4
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMjIuMDIuMjIgMDk6NTUsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAyMS4wMi4yMDIy
IDE2OjU3LCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gT24gMjEuMDIuMjIgMTY6MzEsIEph
biBCZXVsaWNoIHdyb3RlOg0KPj4+IE9uIDIxLjAyLjIwMjIgMTY6MDUsIEp1ZXJnZW4gR3Jv
c3Mgd3JvdGU6DQo+Pj4+IE9uIDIxLjAyLjIyIDE1OjMxLCBKYW4gQmV1bGljaCB3cm90ZToN
Cj4+Pj4+IE9uIDIxLjAyLjIwMjIgMTU6MjcsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+Pj4+
Pj4gT24gMjEuMDIuMjIgMTU6MTgsIEphbiBCZXVsaWNoIHdyb3RlOg0KPj4+Pj4+PiBPbiAy
MS4wMi4yMDIyIDEzOjQyLCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4+Pj4+Pj4gUHJvdmlk
aW5nIGEgbWFjcm8gZm9yIGFuIGludmFsaWQgZ3JhbnQgcmVmZXJlbmNlIHdvdWxkIGJlIGJl
bmVmaWNpYWwNCj4+Pj4+Pj4+IGZvciB1c2VycywgZXNwZWNpYWxseSBhcyBzb21lIGFyZSB1
c2luZyB0aGUgd3JvbmcgdmFsdWUgIjAiIGZvciB0aGF0DQo+Pj4+Pj4+PiBwdXJwb3NlLg0K
Pj4+Pj4+Pj4NCj4+Pj4+Pj4+IFNpZ25lZC1vZmYtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9z
c0BzdXNlLmNvbT4NCj4+Pj4+Pj4NCj4+Pj4+Pj4gT3ZlciB0aGUgeWVhcnMgSSd2ZSBiZWVu
IGNvbnNpZGVyaW5nIHRvIGFkZCBzdWNoIHRvIHRoZSBwdWJsaWMNCj4+Pj4+Pj4gaW50ZXJm
YWNlLCBwZXJoYXBzIGV2ZW4gbW9yZSB0aGFuIG9uY2UuIEJ1dCBJJ20gYWZyYWlkIGl0J3Mg
bm90IHRoYXQNCj4+Pj4+Pj4gZWFzeS4gSW4gcHJpbmNpcGxlIDB4ZmZmZmZmZmYgKHdoaWNo
IGJ0dyBpc24ndCBuZWNlc3NhcmlseSB+MHUpIGNvdWxkDQo+Pj4+Pj4NCj4+Pj4+PiBJIGNh
biBjaGFuZ2UgdGhhdCB0byB1c2UgMHhmZmZmZmZmZiBleHBsaWNpdGx5Lg0KPj4+Pj4+DQo+
Pj4+Pj4+IGJlIGEgdmFsaWQgcmVmLiBJdCBpcyByZWFsbHkgaW50ZXJuYWwgYWdyZWVtZW50
IGJ5IHVzZXJzIG9mIHRoZQ0KPj4+Pj4+PiBpbnRlcmZhY2UgdG8gc2V0IGZvciB0aGVtc2Vs
dmVzIHRoYXQgdGhleSdyZSBub3QgZXZlciBnb2luZyB0byBtYWtlDQo+Pj4+Pj4+IGEgdmFs
aWQgZ3JhbnQgYmVoaW5kIHRoYXQgcmVmZXJlbmNlLg0KPj4+Pj4+DQo+Pj4+Pj4gQXMgdGhl
IGdyYW50IHJlZmVyZW5jZSBpcyBhbiBpbmRleCBpbnRvIHRoZSBncmFudCB0YWJsZSB0aGlz
IHdvdWxkDQo+Pj4+Pj4gbGltaXQgdGhlIHNpemUgb2YgdGhlIGdyYW50IHRhYmxlIHRvICJv
bmx5IiBVSU5UX01BWCAtIDEuIEkgZG9uJ3QNCj4+Pj4+PiB0aGluayB0aGlzIHdpbGwgYmUg
ZXZlciBhIGNvbmNlcm4gKG90aGVyIHRoYW4gYW4gYWNhZGVtaWNhbCBvbmUpLg0KPj4+Pj4N
Cj4+Pj4+IFRoYXQgd2Fzbid0IG15IHBvaW50LiBMaW1pdGluZyB0aGUgdGFibGUgdG8gb25l
IGxlc3MgZW50cnkgaXMgbm90IGENCj4+Pj4+IGJpZyBkZWFsIGluZGVlZC4gQnV0IHdlIGhh
dmUgbm8gcmVhc29uIHRvIG1hbmRhdGUgd2hpY2ggZ3JlZihzKSB0bw0KPj4+Pj4gY29uc2lk
ZXIgaW52YWxpZC4gQSBndWVzdCBjb3VsZCBjb25zaWRlciBncmVmIDAgdGhlIGludmFsaWQg
b25lLg0KPj4+Pg0KPj4+PiBXaXRoIHRoZSBncmVmIGJlaW5nIGFuIGluZGV4IHN0YXJ0aW5n
IHdpdGggMCAoZ3JlZiAwIGlzIHZhbGlkLCBhcyBpdCBpcw0KPj4+PiB1c2VkIGZvciB0aGUg
Y29uc29sZSByaW5nIHBhZ2UpLCB0aGUgbmF0dXJhbCBjaG9pY2UgZm9yIGFuIGludmFsaWQN
Cj4+Pj4gdmFsdWUgaXMgdGhlIGhpZ2hlc3Qgb25lIGJlaW5nIHJlcHJlc2VudGFibGUuIEEg
Z3JlZiBpcyBvZiB0eXBlIHVpbnQzMl90DQo+Pj4+IHJlc3VsdGluZyBpbiB0aGlzIHZhbHVl
IGJlaW5nIDB4ZmZmZmZmZmYuDQo+Pj4+DQo+Pj4+IFdoaWxlIGluIHRoZW9yeSBhIGdyYW50
IHRhYmxlIGNvdWxkIGJlIHRoYXQgbGFyZ2UsIGluIHByYWN0aWNlIHRoaXMNCj4+Pj4gd2ls
bCBuZXZlciBoYXBwZW4uDQo+Pj4+DQo+Pj4+PiBUaGUgaHlwZXJ2aXNvciBkb2Vzbid0IGNh
cmUuIEltbyB0aGlzIHNpbXBseSBpcyBhbiBhc3BlY3Qgd2hpY2ggaXMNCj4+Pj4NCj4+Pj4g
VGhpcyBpc24ndCB0cnVlLiBUaGUgaHlwZXJ2aXNvciBuZWVkcyB0byBhbGxvY2F0ZSByZXNv
dXJjZXMgZm9yIGJlaW5nDQo+Pj4+IGFibGUgdG8gaGFuZGxlIHRoZSBoaWdoZXN0IHBvc3Np
YmxlIGdyZWYgdmFsdWUgZm9yIGEgZ3Vlc3QuIEZvciBhIHYxDQo+Pj4+IGdyYW50IHRhYmxl
IHRoaXMgd291bGQgbWVhbiAzMkdCIG9mIGdyYW50IHRhYmxlIHNpemUuIEFyZSB5b3UgcmVh
bGx5DQo+Pj4+IGNvbmNlcm5lZCB3ZSB3aWxsIGV2ZXIgaGl0IHRoaXMgbGltaXQ/IFRoaXMg
aXNuJ3QgYXQgdGhlIGd1ZXN0J3MNCj4+Pj4gY2hvaWNlLCBhZnRlciBhbGwsIGFzIHRoZSBt
YXggZ3JhbnQgdGFibGUgc2l6ZSBpcyBsaW1pdGVkIGJ5IFhlbi4NCj4+Pg0KPj4+IElmIHdl
J3JlIG5vdCBnb2luZyB0byBoaXQgdGhhdCBsaW1pdCwgd2hhdCdzIHdyb25nIHdpdGggZGVj
bGFyaW5nIHRoZQ0KPj4+IGVudGlyZSB1cHBlciBoYWxmIG9mIHVpbnQzMl90IHNwYWNlICJp
bnZhbGlkIiBmb3IgdXNlIGEgZ3JlZj8gSWYgd2UNCj4+PiB3b24ndCBldmVyIGdvIHVwIHRv
IDMyR2IsIHdlIHF1aXRlIGNlcnRhaW5seSBhbHNvIHdvbid0IGV2ZXIgcmVhY2gNCj4+PiAx
NkdiLiBZZXMsIHlvdSBwcm9iYWJseSBhbHJlYWR5IGd1ZXNzZWQgaXQsIHdlIGNhbiB0aGVu
IHJlcGVhdCB0aGlzDQo+Pj4gcHJvY2VzcyBpdGVyYXRpdmVseSB1bnRpbCB3ZSByZWFjaCA0
a2IuDQo+Pg0KPj4gVGhpcyByZWFzb25pbmcgaXMgbm9uc2Vuc2UsIGFuZCB5b3Uga25vdyBp
dC4NCj4gDQo+IEludGVyZXN0aW5nLiBUaGUgdW5kZXJseWluZyAid2hlcmUgdG8gZHJhdyBh
IGJvdW5kYXJ5IiBpcyBmYXIgZnJvbQ0KPiBub25zZW5zZSwgSSB0aGluay4gVGhlIG9ubHkg
d2F5IHRvIGVzY2FwZSB0aGlzIHF1ZXN0aW9uIGlzIHRvIGF2b2lkDQo+IGludHJvZHVjdGlv
biBvZiBhcnRpZmljaWFsIGJvdW5kYXJpZXMuIFdoaWxlIGl0IHdhcyBtZSB0byBzdWJtaXQN
Cg0KWW91ciByZWFzb25pbmcgdGhhdCB0YWtpbmcgYXdheSB0aGUgdXBwZXIgMC4wMDAwMDAw
MjUlIG9mIGdyYW50IHJlZg0Kc3BhY2UgaXMgc2ltaWxhciB0byB0YWtlIGF3YXkgNTAlIG9y
IGV2ZW4gOTkuOTk5OSUgaXMgbm9uc2Vuc2UuDQoNClRha2luZyBhd2F5IHRoZSBsYXN0IGVu
dHJ5IG9mIG1vcmUgdGhhbiA0IGJpbGxpb24gb25lcywgd2hpbGUgdG9kYXkNCm5vIHVzYWdl
IGV4Y2VlZGluZyAxIG1pbGxpb24gaXMga25vd24gKHRoZSBoaWdoZXN0IHZhbHVlIEkga25v
dyBvZg0KaXMgYWxsb3dpbmcgMjU2IGdyYW50IGZyYW1lcyBmb3IgYSBndWVzdCwgcmVzdWx0
aW5nIGluIDY1NTM2IGdyYW50DQpyZWZzKSwgaXMgaGFyZGx5IGEgcmVsZXZhbnQgbGltaXRh
dGlvbi4gVGhpcyBpcyBlc3BlY2lhbGx5IHRydWUsIGFzDQp0aGUgZ3JhbnQgcmVmIHNwYWNl
IGNhbid0IGJlIGV4dGVuZGVkIHRvIGhpZ2hlciB2YWx1ZXMgd2l0aG91dCBhDQpuZXcgaW50
ZXJmYWNlLg0KDQo+ICJTVVBQT1JULm1kOiBsaW1pdCBzZWN1cml0eSBzdXBwb3J0IGZvciBo
b3N0cyB3aXRoIHZlcnkgbXVjaCBtZW1vcnkiLA0KPiBJIGRpZG4ndCBkbyBzbyBiZWNhdXNl
IEkgdGhvdWdodCBpdCB3YXMgYSBnb29kIHRoaW5nIHRvIGVzdGFibGlzaA0KPiBzdWNoIGEg
Ym91bmRhcnkuIE5vciB3YXMgSSBjb252aW5jZWQgaW4gYW55IHdheSBvZiB0aGUgcHJlY2lz
ZQ0KPiB2YWx1ZSBjaG9zZW4uIEkgbWVyZWx5IHRvb2sgb24gY2Fycnlpbmcgb3V0IHdoYXQg
d2FzIGRpc2N1c3NlZA0KPiB3aXRoIHRoZSBzZWN1cml0eSB0ZWFtIGluIHRoZSBjb250ZXh0
IG9mIFhTQS0zODUsIHdoZW4gZXZlbiB0aGF0DQo+IGRpc2N1c3Npb24gbGVmdCBpdCB2ZXJ5
IG11Y2ggdG8gbWUgdG8gcGljayBhbiBhcmJpdHJhcnkgdmFsdWUuDQo+IA0KPj4+Pj4gbm90
IGluIG5lZWQgb2YgcGlubmluZyBkb3duIGluIHRoZSBBQkkuIFlldCBpZiBpdCB3YXMgcGlu
bmVkIGRvd24NCj4+Pj4+IGxpa2UgeW91IGRvLCB0aGVuIHRoZSBoeXBlcnZpc29yIHdvdWxk
IG5lZWQgdG8gbWFrZSBzdXJlIGl0IHJlZnVzZXMNCj4+Pj4+IHRvIGFjdCBvbiB0aGlzIG1h
bmRhdGVkIGludmFsaWQgZ3JlZi4NCj4+Pj4NCj4+Pj4gVGhpcyBpcyBhbiBlYXN5IG9uZS4g
V2UgY291bGQganVzdCByZWZ1c2UgdG8gaGF2ZSBhIGdyYW50IHRhYmxlIG9mDQo+Pj4+IHRo
YXQgc2l6ZS4gSSBjYW4gYWRkIHRoaXMgdG8gdGhlIHBhdGNoIGlmIHlvdSByZWFsbHkgdGhp
bmsgaXQgaXMNCj4+Pj4gbmVjZXNzYXJ5Lg0KPj4+DQo+Pj4gU2luY2UgZ3JhbnQgdGFibGUg
c2l6ZSBpcyBtZWFzdXJlZCBpbiBwYWdlcywgeW91J2QgdGhlbiBoYXZlIHRvDQo+Pj4gcmVm
dXNlIHVzZSBvZiBtb3JlIHRoYW4ganVzdCB0aGF0IHNpbmdsZSBncmVmLiBUaGlzIHdvdWxk
IHN0aWxsIG5vdA0KPj4+IGJlIGFuIGltbWVkaWF0ZSBwcm9ibGVtLCBidXQgZGVtb25zdHJh
dGVzIGFnYWluIHRoYXQgaXQncyB1bmNsZWFyDQo+Pj4gd2hlcmUgdG8gZHJhdyBzdWNoIGEg
Ym91bmRhcnksIGlmIG9uZSBpcyB0byBiZSBhcnRpZmljaWFsbHkgZHJhd24uDQo+Pg0KPj4g
SXQgc2hvdWxkIGJlIGFzIGhpZ2ggYXMgcG9zc2libGUuIEkgd291bGRuJ3QgbWluZCBqdXN0
IHJlZnVzaW5nIHRoZQ0KPj4gbGFzdCBwb3NzaWJsZSBncmVmLCBidXQgSSBkb24ndCB0aGlu
ayB0aGlzIGlzIG5lY2Vzc2FyeS4NCj4+DQo+Pj4+IFRCSCwgSSB0aGluayBzdWNoIGNvbXBs
ZXRlbHkgdGhlb3JldGljYWwgY29uY2VybnMgc2hvdWxkIG5vdCBzdGFuZA0KPj4+PiBpbiB0
aGUgd2F5IG9mIGFkZGl0aW9ucyB0byB0aGUgQUJJIG1ha2luZyBsaWZlIGVhc2llciBmb3Ig
Y29uc3VtZXJzLg0KPj4+DQo+Pj4gSW4gY2FzZSBpdCB3YXNuJ3QgY2xlYXIgLSBteSBjb25j
ZXJuIGlzbid0IHRoYXQgc2FjcmlmaWNpbmcgdGhpcyBvbmUNCj4+PiBlbnRyeSBtYXkgY2F1
c2UgYSBwcm9ibGVtLCBvciB0aGF0IHdlJ2QgZXZlciBzZWUgZ3JhbnQgdGFibGVzIGdyb3cN
Cj4+PiB0aGlzIGJpZyAoYWxiZWl0IGZvciB0aGUgbGF0dGVyOiB5b3UgbmV2ZXIgcmVhbGx5
IGtub3cpLiBJbnN0ZWFkIG15DQo+Pj4gY29uY2VybiBpcyB0aGF0IGl0IGlzIGNvbmNlcHR1
YWxseSB3cm9uZyBmb3IgdXMgdG8gKG5vdykgaW50cm9kdWNlDQo+Pj4gc3VjaCBhIHZhbHVl
Lg0KPj4NCj4+IEkgaGF2ZSB1bmRlcnN0b29kIHRoYXQgdGhpcyBpcyB5b3VyIGNvbmNlcm4u
DQo+Pg0KPj4gSSBjb250aW51ZSB0byB0aGluayB0aGF0IHRoaXMgY29uY2VybiBpcyBvZiBw
dXJlbHkgYWNhZGVtaWNhbCBuYXR1cmUuDQo+IA0KPiBXZWxsLCBJJ20gbm90IGdvaW5nIHRv
IE5BSyB0aGUgY2hhbmdlIGlmIG90aGVycyBhZ3JlZSB3aXRoIHlvdXIgdmlldy4NCj4gQnV0
IEknbSBub3QgZ29pbmcgdG8gcHV0IG15IG5hbWUgdW5kZXIgaXQgaW4gYW55IGZvcm0uIEFj
YWRlbWljYWwgb3INCj4gbm90LCBpdCBzZXRzIGEobm90aGVyKSB3cm9uZyBwcmVjZWRlbnQu
DQoNCkZhaXIgZW5vdWdoLg0KDQoNCkp1ZXJnZW4NCg==
--------------I2mG9Uk8L00DeHksLDpP2bU4
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------I2mG9Uk8L00DeHksLDpP2bU4--

--------------of0fjyPoNZ4Cgev6ZCRit6RR--

--------------vfM5YkAeu56D4ktMkZ23gtlE
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmIUrcAFAwAAAAAACgkQsN6d1ii/Ey+E
XAf/SEhQ4Dgh98GMCZEMvm7bW0YZzlQorCA4Co2zhJmThTY514B84AZ4I6A3OhZWdUU+ok7j3zyg
KyhNeMyWEsdaZBZHPMORaAA9YAZXGOWZEgrCP9CPvhXfv8xd82BN9QpVnVC2xWL/BDPjLjEfTPvG
JNOtGyxSWDphbVk82kK/0ivEtSmtnW2w5NM7zdWXtZNW2Op9luofMFiLOz8FFcbPOrf71VFVXh9j
pqbBNHvxGHWmsuNn8JcJiqQUjFVP2dm+y6bjNslDjoNMBGOlVi5C0eFhKMXOOa0fl2bfS2Uj6xYk
WmgWzmSEJQGGDsATgWgaZvhbgoQwCEqx4tmPnjDIWg==
=Nx38
-----END PGP SIGNATURE-----

--------------vfM5YkAeu56D4ktMkZ23gtlE--


From xen-devel-bounces@lists.xenproject.org Tue Feb 22 09:34:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 09:34:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276596.472803 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMRYr-0006bU-6e; Tue, 22 Feb 2022 09:34:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276596.472803; Tue, 22 Feb 2022 09:34:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMRYr-0006bN-35; Tue, 22 Feb 2022 09:34:21 +0000
Received: by outflank-mailman (input) for mailman id 276596;
 Tue, 22 Feb 2022 09:34:20 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=QzH2=TF=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nMRYq-0006bF-Hx
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 09:34:20 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9bf23f01-93c2-11ec-8eb8-a37418f5ba1a;
 Tue, 22 Feb 2022 10:34:19 +0100 (CET)
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2059.outbound.protection.outlook.com [104.47.1.59]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-19-5e8l2YBZOdO14T_G2GVWWw-1; Tue, 22 Feb 2022 10:34:17 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM0PR04MB7041.eurprd04.prod.outlook.com (2603:10a6:208:19a::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.21; Tue, 22 Feb
 2022 09:34:16 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.4995.027; Tue, 22 Feb 2022
 09:34:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9bf23f01-93c2-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645522459;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=0+Ton5Tc/dvlp2Of3R/Rsv2L2KyH2q3eE7zr3IJxprY=;
	b=HX+Y6EJSPX5eImV2o4nHAUGOVQr+H/MbzjOYKxMyfwOGXGm0Xa+3s7xM6vMuRjhOjKm6/j
	3ehADnXgr3/H6MlGrzJUH93/y+L2MdDXRIpw2FNqEBATNaTtt84yAty+v8j64H2Ti2S/7m
	DqmDUuqb5UcgY60bthEk4Bj7zAb1D0M=
X-MC-Unique: 5e8l2YBZOdO14T_G2GVWWw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=LYxP5x4yYuQA3SMXpwRBVTSwh+T0+6xU0RddGZbrnMULXS12/PNx0LlPBbZxP//zdqGeBxG/+yn+z3nevEueqWFcqVD4gp2yWdl32caHfBFYd0v0Qwcn37nldmtaSotLpPFF7Yrk3DNH4DfGAox9dmuB7zG1pKXdKInvQC1XLAa7DanVIPBOwdLEMT6Tc52l+gQtdotfz8IS/davbaZs+NXf2Y6hxcPimvQouSYS8sY228Ah6bcvH5L6jxk9t2hDV6Nyk38Pb4fDFfXNquIJdnJMRN5HQyt29P8ghGsEpyVzwOOdxXlcBY8Bo+jG0O5K/mesaYZ/jTWyT6xJk15EOg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=vQZFQ0RKooqx+lq1ZG82aYvUdpOr/u/zmOir6qvsIBA=;
 b=BRPXJVwPb+onu52ndEbtNd+RK6PxDS/j/l3kw44hwpe8mgWhEzR7KnVVR6dvoSVZHDrIdInKJK5z4U4rjRru0ZJWHbWoWmkA7EarGCi2ow6YrtihdYgxIrysGzC6C5ASsCTfqmwuLLyne2XDO0ysEvxBPIfY+FFL+wp/u+ibuTfEj24B2hkH64rYH/lNklXyatI9aQefh5f2OoSzxEN/fWAV8VTv5WeulsAY/q0KQtNm7lQx45MGdGjfCI1hA348td7saKUq+W6B/KglVi4m8EZKU4PNUMM5ffLtBadUmAJmJ6NVmfpOK/xciiqXNolG2XQo88BVut+ONLHZTeTO2w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <cce92dbc-8b45-2bce-6a04-3cabf1a19547@suse.com>
Date: Tue, 22 Feb 2022 10:34:14 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v4] x86/mwait-idle: re-order state entry/exit code a
 little
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
References: <faff6a1e-9f00-e924-9766-deda8f0b38c1@suse.com>
 <2db7bc79-4fe4-abf6-9e5a-83055af9a78a@suse.com>
 <YhSn/Nsx6eElXpSU@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YhSn/Nsx6eElXpSU@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS8PR04CA0021.eurprd04.prod.outlook.com
 (2603:10a6:20b:310::26) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: fe6bf521-58b4-4f38-8d3a-08d9f5e67e99
X-MS-TrafficTypeDiagnostic: AM0PR04MB7041:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB7041321892BC675FAE8CDE1DB33B9@AM0PR04MB7041.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	lzD2CyOxp1XFNhWmfOBDOtSHprEO0Thc7w9pnnqykS71JHpiXG0ZOCBaCheNGVZYDpkGfo3d0PYcRdLh5tojv0littVsUr9D/M6pNarjRQFOxk9Oj7+Dh7jNEaD1N6WjyxMyfqeT8NqNiWqR0nDXytuH54znUU2y1tS4VYwxzkNa8V0YFKudgSyJB5HieeB+nCiWZfASVWHZaPC54pRxM+agTKo0ALlvysQ4eX2TQ8+8cTJD4c6Ukji91VU8oE6JCfZR8tw8N3DsQifxCvWn9bH9eAbtherDuuK0douoQ1qrQZD5sExrJ/ScZO0aYj7pb/7DvTCETfSb5iroef0S2flmD+2p+H+vlP+0B9ho6ApVp4kEKK7O/urSuyD+HEjdLBIC4QDTLgoQUQ+ZWYB2rXZx3MIhpATtRxTfTIjzRu7DnZJLxo6KPTGriBEXwZzJHamNENJsc7z+hWNWlUtegmvhaKgOdKYOaOwoBZKyIC9JLZyIDriX4wGjIiRIUivWK7OfXQgZUgtDZyw7bmnatE0G+2+FWCcoDAq/MbroHvNwS6MxUl4P6S+WQkC/BeBUdghshYNU0S2FBMXPF/eMSaosyHZxY4w291AiUiHbasA9S58DXnP6ahcWQ/v66AKq7IQlmJ1XG51SlC4q1X240cZAbtgITZrk2xyivwhUGavFhcGPcrlzzNSalEheXIKte7EZxdJV7xSOlTJztUr6HfNH36ZF08joCNRa4XX9XcYWEPjxAmttvPhV8l5vYlxCF8uYQPr565rJ75/Paj7bPA==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(316002)(31686004)(8936002)(83380400001)(66556008)(66476007)(6486002)(66946007)(5660300002)(36756003)(4326008)(2906002)(8676002)(6916009)(54906003)(6512007)(508600001)(2616005)(53546011)(186003)(6506007)(26005)(86362001)(38100700002)(31696002)(169823001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?vuOyPuMcW6PeahlAzYm2nDONSUEeqhN/8bU3ztwHAUZtYiyUYZ6j8/S8XnSd?=
 =?us-ascii?Q?o1DrBfDx4fgzKdMBU2M0+kOsLUJs8gY8lXHSHxlCncuZYP2FIHSwMeVn7oRB?=
 =?us-ascii?Q?HSk6M47GxBimE7ox1K2yeENDhs854jrGxe+23YM0qpo56KxFRif5Q/89b/bI?=
 =?us-ascii?Q?VAKFGpLcKGeQlV6vkJXRwQ0o+PdblcU36xPLJymXEp7xg1iv76+Ji9vRHfUV?=
 =?us-ascii?Q?NQB4sQr4s9yM7Za/ImQntM2XhKesGAcOCrOZz804LP4fls4RcdVnbQFGHvY3?=
 =?us-ascii?Q?++MJlN5VEoa9w3RrAH3x5ing7obN+jrizHRXeskX8AVVB8Edgbeu+i0rZ8gi?=
 =?us-ascii?Q?Me+DC3vO2XcMBFGwoKLD8ou2lS1Z0Wywgp5jL3vIFrhJY7iHfizwFfHwT6oU?=
 =?us-ascii?Q?n3LAcj+i5FrOdoJ3rk06HUbQCacUPKc1SuenIIveKYqqu6zkJl4c5Mp0TyJu?=
 =?us-ascii?Q?wAEe6uW+pPTGLjb+414x2AhQjUrXVDuTY47nJN97rq7r8YQh49P/fpZn8B48?=
 =?us-ascii?Q?xNDihcf1ROB494UM2z20a4xZJAhEYMYc9QBMGehzrkNC7bte9UoX8Zo8EYfY?=
 =?us-ascii?Q?EPl8luE8H66kl8eTmCVN5b88fhHWteK5eY+jytSFlfBJJ3a4wC7kymAatmnV?=
 =?us-ascii?Q?7du720TWppQUwmIL4c1lazZjInMk4tgbFyrPgPbTuhXdbpsH4J1wCSO3yO5C?=
 =?us-ascii?Q?I77N314Ru5aO83vlyCKedbhMWX0vL+SIsrsn/E1IzackTsXiVnt6rRdZvn/l?=
 =?us-ascii?Q?RVz+a+fopiMkwKyMVujpEIdA+Mp8GJQ63HjEm/yYIYKALEOLKyVt8fxPtMXo?=
 =?us-ascii?Q?IWOM6JIUN+l5pQ/rEmBwlRxWek14T+xQGLa8ymKNSKdHp/YiIWlFL7dkTz7V?=
 =?us-ascii?Q?KCzfxVKpzRLDZkmQG7cy3k7m8RBGZwm+i13AIaO8O69fya7Qmcf5pNYxvs5l?=
 =?us-ascii?Q?KeVvs0igPFXs0mKvu7IMnX8vljAZ0KRjvPb7sVapLLkWYAcxr9KdOja5bghM?=
 =?us-ascii?Q?bymW0KNR119n/C01NmfcdjwSTjeFh51h6oBQc+1LktUyLqeESqbpaJF2Yf6z?=
 =?us-ascii?Q?+pcqcnkg0RUa2TOsauGPaWLdMxor2x+qigH0cVoeiRX0ZzS/T93e6PPsNJAC?=
 =?us-ascii?Q?ZmE4EFRRYCO6x6pvBj0VHIgrrMXi1cu/LCTWIhg0zdzbJSbuSFjnzPgKNEaX?=
 =?us-ascii?Q?Gt1UIdlHKYzvpjlRDeIQ8cpIdpg+KjO7/kiMdscZGpWXnbBYSI/nLgU+pJjO?=
 =?us-ascii?Q?Xr+u2ASP0OuFcWOlAVr7Erd8TyScUiAiP5V0Rdm3fbbUn88C6bLXP9XOgdCx?=
 =?us-ascii?Q?APs/y7qg23ZUiPpVkpDrhGvgrKcp/Vk73hGJS2WQoN0VTdKOj8QO5IBa4uEz?=
 =?us-ascii?Q?xFUR48r27N+JQ0mBJL5wbs82aIX+uiLxtrhg1/VBFRUlNKlrS9GtFnTUPQDt?=
 =?us-ascii?Q?IRFbF1RkumvKlw0Hg7qCjdKjVWjG/eizMOLcSmCc/Y0qHXwAuUn9cR2FuM8o?=
 =?us-ascii?Q?CgDSi0lLLBlHZ1HQ+DuOVBBRq5AjsjKwxwlwOdT8rhrCBSQivf6Cf6LFJBrw?=
 =?us-ascii?Q?NdIymv0MmAaJK4I4Sz3poiw5D9XjWi2mAaYUQGvIgGZ6HnUGVMHK+fry7GA/?=
 =?us-ascii?Q?h3/v8BsoDzSOL7ulj0diE18=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fe6bf521-58b4-4f38-8d3a-08d9f5e67e99
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2022 09:34:16.6005
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HSZKe5TgI+rjQAMjoMNZqFgo+XwjI68jg5gHp02k1UTo+9CQK4ClxPiFjUs2cCr57PL9u/V/gGHns6FLsWAy/Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB7041

On 22.02.2022 10:08, Roger Pau Monn=C3=A9 wrote:
> On Fri, Feb 18, 2022 at 09:35:10AM +0100, Jan Beulich wrote:
>> The initial observation is that unlike the original ACPI idle driver we
>> have a 2nd cpu_is_haltable() in here. By making the actual state entry
>> conditional, the emitted trace records as well as the subsequent stats
>> update are at least misleading in case the state wasn't actually entered=
.
>> Hence they would want moving inside the conditional. At which point the
>> cpuidle_get_tick() invocations could (and hence should) move as well.
>> cstate_restore_tsc() also isn't needed if we didn't actually enter the
>> state.
>>
>> This leaves only the errata_c6_workaround() and lapic_timer_off()
>> invocations outside the conditional. As a result it looks easier to
>> drop the conditional (and come back in sync with the other driver again)
>> than to move almost everything into the conditional.
>>
>> While there also move the TRACE_6D() out of the IRQ-disabled region.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>=20
> Reviewed-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>

Thanks.

>> --- a/xen/arch/x86/cpu/mwait-idle.c
>> +++ b/xen/arch/x86/cpu/mwait-idle.c
>> @@ -847,26 +847,25 @@ static void mwait_idle(void)
>> =20
>>  	update_last_cx_stat(power, cx, before);
>> =20
>> -	if (cpu_is_haltable(cpu)) {
>> -		if (cx->irq_enable_early)
>> -			local_irq_enable();
>> +	if (cx->irq_enable_early)
>> +		local_irq_enable();
>=20
> Now that I look at this again, we need to be careful with the enabling
> interrupts and the interaction with errata_c6_workaround.  Enabling
> interrupts here could change the result of the check for pending EOIs,
> and thus enter mwait with a condition that could trigger the erratas.
> Hopefully CPUIDLE_FLAG_IRQ_ENABLE is only set for C1.
>=20
> It might be prudent to only allow setting CPUIDLE_FLAG_IRQ_ENABLE for
> states <=3D 2.

Well, the justification for enabling was the low exit time. I don't
expect states > 2 to satisfy this criteria, so I think we're okay
without further precautions added right away.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Feb 22 09:40:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 09:40:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276605.472813 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMRem-00084M-SH; Tue, 22 Feb 2022 09:40:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276605.472813; Tue, 22 Feb 2022 09:40:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMRem-00084F-PG; Tue, 22 Feb 2022 09:40:28 +0000
Received: by outflank-mailman (input) for mailman id 276605;
 Tue, 22 Feb 2022 09:40:27 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=4CiU=TF=citrix.com=prvs=045c9559e=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nMRel-000849-In
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 09:40:27 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7587a318-93c3-11ec-8eb8-a37418f5ba1a;
 Tue, 22 Feb 2022 10:40:25 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7587a318-93c3-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645522825;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=6RHXfly5ARCcz3pjskSyCuwuoNYg+47abYSQdeN9YPI=;
  b=dVBKLJ2FSHqlZgycqs6/pdbkH0FBzL68IWanV6aVPxR2+6ijCyWNO1AD
   bDY3W90MFlrZyTVtioqV438z7B54+jCPjeD0ruLTAzJY3mGnNb5MQokGe
   /AAgwKE4Hm2qqt+Mtjl194Ggs36Y9Kh0oUSV7IL13kPFM+NOhc1nJOE0a
   I=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 64707532
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:BJD/I6OplIR9GBTvrR2yl8FynXyQoLVcMsEvi/4bfWQNrUp2hGcCy
 mROWTiPbv3eNGX9fYwnb4q3/R4C7JaHm4RiHQto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FV8MpBsJ00o5wbZj2NQw27BVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z4
 upH7pObdwIVPbScuuVCdxxoMT45FPgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALNs7kMZlZonh95TrYEewnUdbIRKCiCdpwgmtv3p8TRqy2i
 8wxRhd3fiTjIDh2OmwFFc15w935gWiiSmgNwL6SjfVuuDWCpOBr65DyNPLFd9rMQt9a9m6Iq
 2SD82nnDxUyMN2E1SHD4n+qnvXIny7wRMQVDrLQ3vxgjUCXx2cTIAYLTlb9qv684nNSQPoGd
 RZSoHB36/Fvqgr7FbERQiFUvlaugRRHVPFuFtE58VGvy/Xw5ja7GS8tG2sphMMdiOc6Qjkj1
 1msltzvBCByvLD9dU9x5ot4vhvpZ3FLcDZqiTssCFJcvoK9+N1bYgfnE447eJNZmOEZDt0ZL
 9qiiCElz4segscQv0lQ1QCW2mn8znQlo+Nc2+k2Yo5Hxl4hDGJGT9bxgbQ+0RqmBNzCJrVml
 CJZ8/VyFMhUUfmweNWlGY3h5o2B6fefKyH7ilVyBZQn/DnF0yf9Id0MvmAjeR01a55sldrVj
 Kn741g5CHh7ZibCUEOKS9jpV5RCIVbIT7wJqcw4nvIRO8MsJWdrDQllZFKK3nCFraTfufpXB
 HtvSu71VSxyIf0+lFKeHr5BuZd2lnFW7T6CHvjTkkX4uYdykVbIEN/pxnPVNbtnhE5FyS2Im
 +ti2zyikUsHC7SmOnGNmWPRRHhTRUUG6VnNg5U/XsaIIxZ8GXFnDPnUwLg7fJdikbgTneDNl
 kxRkGcBoLYjrRUr8Tm3V00=
IronPort-HdrOrdr: A9a23:Zd76H6OP7uaA7MBcTyX155DYdb4zR+YMi2TDiHoedfUFSKOlfp
 6V8MjztSWVtN4QMEtQ/+xoHJPwPE80kqQFnbX5XI3SJjUO3VHIEGgM1/qG/9SNIVybygcZ79
 YeT0EcMqyBMbEZt7eD3ODQKb9Jq7PrgcPY59s2jU0dNj2CA5sQnjuRYTzra3GeKjM2YqbQQ/
 Gnl7R6TnebCD8qR/X+IkNAc/nIptXNmp6jSRkaByQ/4A3LqT+z8rb1HzWRwx9bClp0sPof2F
 mAtza8yrSosvm9xBOZ/2jP765OkN+k7tdYHsSDhuUcNz2poAe1Y4ZKXaGEoVkO0auSwWdvtO
 OJjwYrPsx15X+UVmapoSH10w2l6zoq42+K8y7vvVLT5ejCAB4qActIgoxUNjHD7VA7gd162K
 VXm0qEqpt+F3r77WrAzumNcysvulu/oHIkn+JWpWdYS5EiZLhYqpFa1F9JEa0HADnx5OkcYa
 ZT5fnnlbZrmG6hHjPkVjEF+q3vYp1zJGbLfqE6gL3V79AM90oJinfxx6Qk7wA9HdwGOt15Dt
 //Q9ZVfYF1P7wrhJ1GdZI8qOuMeyXwqEH3QSqvyWqOLtByB5uKke+x3IkI
X-IronPort-AV: E=Sophos;i="5.88,387,1635220800"; 
   d="scan'208";a="64707532"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=YOCtQeYEQ3DcsaTTpnrU1LOSxmWmAnWpaZKyCtJfkcxwGT38syjgFsITKs9dWVf82NxzorfRXuaG4Ck0xb2vxJYIm57+AGEuhCPwl32sSbtqRVgPQM8ox8LbMJXJgGtxz9VDUiLT+pzjSm+dn/xQ1c/M9wGIc9p3rpbPMJ7aHd2RS63gCqZjnF1Znvn3zPcpd4e9WcoNI09tG+NZDRBQpJPzM9sCsbR+VD60+hbaWe4P42MN5S4/uzDyLNN9v0NpsO1Nn0xVBH+WdQ4tHnhoeDXGLp3vFM96P4KAMb4lp+0Vnnm7liaaqHnvhyuOAu/F1mjn1nnRCf+/TjcUW+ZfUA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=gS7/inIPKvQqZhZqlMazaIgUzDQJBDKHdhDYzlWVE6M=;
 b=ZudpLpowN8PrX3kK3BVU76u+c8R0wUA7NSxETxCvkLmLyRyualdR44jw68p5bJdGxcpX8BPOoy//1ri0g07aIW47n09iGM8DIZLE4QTAfaaf0QrrjApy4kaocKNt7jo9i1msfl2oWp60DS/kA6Cxv0AGi8KUOsAY/kYSih2PaVnY+/T0C/+zH04n5LQSSrcCFbWhH+TzVevrLDc+olPia/1jQFhmjUqY4FfE1ixg6ZymeMnAeMOHEWqwAxyKr97g4M1+f5ma0UfrJm5MaVPUX+LFr1Iv8rrcRxqjZD/k+fPwOgWFjA/f/VRoD+US46DxPbF3vBg1l5KcyDpZFfA4eQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=gS7/inIPKvQqZhZqlMazaIgUzDQJBDKHdhDYzlWVE6M=;
 b=XvIQUlLy1M0AlhXPgw6CG1pGeOy0wL/uX8bfm/vBrYqAP7xRdVWoH7mEctoiGamzkZBXLDZC886swKzKuUF/BxUWk1pSvANFU6iAqKLFjg7L433wRr5UgNWEfhAu6CRU3uh3Z3p8H5CzBpuTGzyFMpqgvqL887Svm8Nhs1ckHbA=
Date: Tue, 22 Feb 2022 10:40:08 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Andrew
 Cooper" <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v2 3/3] x86/perfc: fold HVM's VM-exit counter arrays
Message-ID: <YhSveDsp+3NW3hYX@Air-de-Roger>
References: <ff461a77-93a0-5424-6565-2e947bec3912@suse.com>
 <6a2a47af-4ae1-2fe9-1190-e15b6ce742e6@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <6a2a47af-4ae1-2fe9-1190-e15b6ce742e6@suse.com>
X-ClientProxiedBy: LO2P265CA0074.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:8::14) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 8f23efa4-2fbb-4bbb-a867-08d9f5e752f8
X-MS-TrafficTypeDiagnostic: MN2PR03MB5040:EE_
X-Microsoft-Antispam-PRVS: <MN2PR03MB50405DF6FE7231B1CBAEC30A8F3B9@MN2PR03MB5040.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: e4IJIvi5sua7kXFH7RS6aYhsI8qwSpHnlfafPUIETbBHFY8y3y9F1aGBxek21JiHIwiqiVUBJGMjNytKsCiHAVwVRyezO+Si5BmGeApM+YwTuznIfNhvgDzxOVkcRG378OyhRpsqZcUDIl4K5yHZwtP+KRSzPTN55SVwg/znUpyQMzYuxPM796iSlll81WlBudrK+ilL20wXbdG5Leosp3vUUlN5rXNVi499YoUN7mX9RYN7xuaOdQ+sPVW0xt4uNpdHIrcSm2+9F/GC/TFuQdS1ojJcLBMiwTcaDGvP8oHPdzZydzmgknz6zfz6wDwJkLcg6OfPuMG0zlNqft/XAkJ5lDyxMaXyjffI630qERxhBE6BFIulqchi41MRPL0IP/+faMN01wZcMcG3Dnx+2vZ+6KEB1fceoetD7wTtQvBehCEfdNOoYcC18GheAh0UVwvtKsXFpxSbfZqCiPyWlGu8nbJ26sbcF5jNOvzDhcYhaBlpA6iIUIGHnDwqFBeiq55sXdBNIfvBOA2suRQEbkx9dhOq5AhHUWMT50Y1vQEwpI+3BRiwZgyLzSvYy7jd3QDQ+u1CGjI0qngKH3P5K1K4nqJv3rleajbboyhd3L+1wBu3BT71iH+f94GwuOC6tGNhDrd1eCBgGEtfzEvyFcfJWqfMxuAJLIdSvBE/AwF1Wp10DHqPC3E3z0IYY/2kvgK6DyuKvu6Aehy8psZSKw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(186003)(26005)(66946007)(6512007)(9686003)(66556008)(6506007)(6486002)(6666004)(33716001)(86362001)(54906003)(66476007)(508600001)(316002)(6916009)(82960400001)(8676002)(83380400001)(4326008)(38100700002)(5660300002)(85182001)(8936002)(2906002)(4744005)(67856001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?em9UUFJmOCs1TW5aN09TajNTRVNqMmFNcmRxVWdvbUQxTTZVWkwyTVA5N21y?=
 =?utf-8?B?bjBWQ2dmTmcxOUZLb0JlN1IzK3JqK1BhTnRPajNSWXo5a2MrOVE2dDBjYzEv?=
 =?utf-8?B?enQvSXpxbWdvdlpHUkpBakw1eU4vTFpxZHhPdm5lcThUdjl4aTArN2l0ajVz?=
 =?utf-8?B?S3NHeGY4cnE1WjI0ZkxJTTd1OFFVSlZGTHF4bVk5UjFKK2R0Qm9ScU5qQVRh?=
 =?utf-8?B?S0NpaVJqSHVNUEdYQjhzMHhiRDN1L1N4eFV6aERrTlRzL2JNRWJoalJKcys2?=
 =?utf-8?B?ckk2bFp1bW5CdUhmN3ltNFNodXhWeWxpTy9oZlltUjd6S1hnL1ZDeDNGRUdU?=
 =?utf-8?B?ck55Zi9laDJCYVlKZmpCaVFVam9wdEp3aU5GM2JBUk9QanozMkpwWnZnbVRT?=
 =?utf-8?B?MmUwY1pDOW9Wa2JpbytEbTZYWDNGL3cwOWI2SmRSSHJMYUNxN2c3TFA0b3B6?=
 =?utf-8?B?SWVkVzJuVEpPQlduMUtwTjV0dGtvUnk5TkJ2eG1yTDlBVjVjazA0NWpHVzdX?=
 =?utf-8?B?bzV6WXdoTW5jc0RLN1lZRU5SYk9kQWRMZzRVVnA4c1pHY0F3aEZaQllNNVJu?=
 =?utf-8?B?WjhIZEZIUGJRZlM5bXRNQ240dTAxTWFad2dTWWkzUURzbmU0NTFNb2xtUWxq?=
 =?utf-8?B?VlZnbFQrY3BYZzBHNnVBQWo1UjhmSmtyWXVxZC9tSitqb2xTSmdyMngzeGU1?=
 =?utf-8?B?NWZkYnUvU3lSb2hOYTJQMHR1UDVjM3E4eFNCK0tkUTBONTRwdXJXWnVaaGJq?=
 =?utf-8?B?dWVpbmxSSzFxQTdCbk8zU2U5OWlqS0xZNEQzMlZmWmtueDlGUXJ2YUs3b3pK?=
 =?utf-8?B?cCt1dEs5MlFtTjBBc3FFRTMzb0QvOE1OZXpJamxEajIyQWcwZGpvYTJIcWNH?=
 =?utf-8?B?Nk44aEQ0UWNnb3N5NUUwVnZvWmc5TDhxUkFnVkFzTEdpVlFZeXJjbVNYUVlH?=
 =?utf-8?B?YlYrb2h0d0RUWlovZ2Q2OEk4QTJId0dRRzBsWUNsaUJkdHNoUUYvRU43R1RT?=
 =?utf-8?B?eFl1UzhFTzFsZVdJckYxbmV4V0puaGRWWUJPSVBBQnBpWjZjQ1lXc0x4cGlF?=
 =?utf-8?B?eTFsSlZMcGVrMXFaQTI1bXZSMS9nUGlnNWdSYi9PcEhOYzMxVjJMNWhlOW1y?=
 =?utf-8?B?SXJJOXRoZmhvNWtzQVdoMTVQcHk5QUdqek5WZVNuekNuaGxtcTFGQjNkWFMw?=
 =?utf-8?B?RlBlekNacXdtMnlUN1dCbzRTZmg5VGI1eGhYcDR5RjhDMWpyQ0xjOGVtSTRj?=
 =?utf-8?B?YjRJY2I4ZGFHWmZWdjRKdTZmZVJWd3JrZndtSm9Ba1hyMTJpc1U4QlgyQkJp?=
 =?utf-8?B?d05WNXBtK3lFV0NQLytpdW1zRTR3eFVqVmdNVnR0ejlhRG5GSS9XbkpnNXpT?=
 =?utf-8?B?M3BnOTBBTm16RWdWdm5ncCsvdXhRcHdkRHo2K3ErUjczaU1pU0svNGVGRWNn?=
 =?utf-8?B?SlRCUGtWZ0RXZUFjdFZ1Q2NuNUJrdURCQmNkZ1pSYzV4M0kxUlBwdlArWDBq?=
 =?utf-8?B?S1NQTldIT1RyazNrd20rNkRjNWVhUzNDTzlwalIxREM3NTFDVktnRXlBQlNp?=
 =?utf-8?B?Vy9LT3l3dDkyWXkvZjh1Y1l2dWZrME1ET0NZMnpOTzdSMk53TVN1d3FvOU1X?=
 =?utf-8?B?QXJFcSt3cmMwL0prUjd1eDgwL1p4c3F5TUIzeDlzRnlqMUtuZ3BvYTBGbTcr?=
 =?utf-8?B?UEh6Z2p1dEVJeFF0UlU1WmFHcWR1blNaK0trV3R0RTQ0T0NjWG54TVdYdEMx?=
 =?utf-8?B?cFB3ZjhocVZOYlY3YVhkYkw2UGcxUHR3MU96TmtGT2tIeTlKRkpjVER3ZTRO?=
 =?utf-8?B?a21SRWoxRmRhUGZoTE1MSlZjNU1YV2tWSm9ZcENtQ1d0Sjl3a0Y4bFh5TDBs?=
 =?utf-8?B?Y0xWQWkreHBEMURGZVhpaFN6bHJsYlVQa3g5ZSttcEtsL2tpL0MwOUNMMmM4?=
 =?utf-8?B?UlBhem1oN3JBZFgyZUZtVmNvRnBDcVl0MzZaZXJoTS9MUGdwVUg5WDAyUVlz?=
 =?utf-8?B?b01ST1Q2OHp6QjRzWUNtQVZoc1BNN2xEUk1TVG8rRjZzVEtGVFhEdDdyV0s2?=
 =?utf-8?B?d2hmZU1pZkw3T0Q4UldiS3NWNHR1TDZ3UTVxWEV3UWhadysvUklydGRvTHhE?=
 =?utf-8?B?VFN5VVplKzB3bmVhZ2hMTTVtQWIzazZhRHBKZG91S1N6QkR1T2EzTk16M1cz?=
 =?utf-8?Q?VaW5AjsFvB95SHQoFxKruP0=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8f23efa4-2fbb-4bbb-a867-08d9f5e752f8
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2022 09:40:12.9619
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: m++SaKh4IJ+KZxFDUx4C4PDydchh6Gsw2+kw6o8QsDIIgoymruRBXmo7ZE+xFFnegddx8b6HRKmXrTDPty4P+A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB5040
X-OriginatorOrg: citrix.com

On Wed, Jan 05, 2022 at 02:59:03PM +0100, Jan Beulich wrote:
> Only one of them can be in use at a time, so make the whole set union-
> like. While doing the rename in SVM code, combine the two perf_incra(),
> generalizing the range upwards of VMEXIT_NPF.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

> ---
> v2: New.
> 
> --- a/xen/arch/x86/hvm/svm/svm.c
> +++ b/xen/arch/x86/hvm/svm/svm.c
> @@ -2644,7 +2644,10 @@ void svm_vmexit_handler(struct cpu_user_
>          goto out;
>      }
>  
> -    perfc_incra(svmexits, exit_reason);
> +    perfc_incra(vmexits,
> +                exit_reason < VMEXIT_NPF
> +                ? exit_reason
> +                : exit_reason - VMEXIT_NPF + VMEXIT_NPF_PERFC);

Should we assert that the index used here < SVM_PERF_EXIT_REASON_SIZE?

Just so that adding new exit reasons without increasing
SVM_PERF_EXIT_REASON_SIZE is not likely to go unnoticed?

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Feb 22 09:59:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 09:59:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276615.472825 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMRwu-0001GP-K0; Tue, 22 Feb 2022 09:59:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276615.472825; Tue, 22 Feb 2022 09:59:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMRwu-0001GI-Gx; Tue, 22 Feb 2022 09:59:12 +0000
Received: by outflank-mailman (input) for mailman id 276615;
 Tue, 22 Feb 2022 09:59:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=QzH2=TF=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nMRws-0001Fw-K7
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 09:59:10 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 143334a9-93c6-11ec-8539-5f4723681683;
 Tue, 22 Feb 2022 10:59:09 +0100 (CET)
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2050.outbound.protection.outlook.com [104.47.1.50]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-20-cxJ1z3WXNWa26hBKBIcljQ-1; Tue, 22 Feb 2022 10:59:07 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4143.eurprd04.prod.outlook.com (2603:10a6:803:46::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.27; Tue, 22 Feb
 2022 09:59:06 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.4995.027; Tue, 22 Feb 2022
 09:59:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 143334a9-93c6-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645523949;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=3E4DN5wu9eAa042FEHvhQ4k1rLrdlQXI+GccYDoUlAI=;
	b=bS2gdlm3qcbCJ8X0otVl78Ht04Rte94GjIYNbL4H5XlgwE31+FSqviQtjoXrIxdaK9PuIr
	td1Uyp6p5NhLXPjXdLHoYCJreQ5Dg7t81HLIV4ued14yFSC29AhIW0DziLU8rOqdh8m6Ec
	zoO9H39c3Xev3rvPfCx2w2VF9UCWB9g=
X-MC-Unique: cxJ1z3WXNWa26hBKBIcljQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=bjfBmtCPoXXKd/O3hs9KhVKm9bpdHvtL4LqyKoSBWzy1Qp/+3Wz0QONuY4PMf/ozDuryb8zdVrGQseTaQjQLXBA6O4EGZr1+hWBlhMrBksduRySoCy0YfeTgf8Q1cSbZHhUHypApO2x/3wDqsWyq+ewkEkxmnR0y8ZcerQuoam5kwGKRoDAFYn2CqMuFdbA3ofLpri3sRJ+HrAIKm5LqemODWTZkaa3zojdhLj3W5H9Wmsp0mX0/3YGhtNr4xs2Mfh10oe90e2ljuN0ZfQgh7MCQq/9RY4kyjdAcSWE0Wzbv3QtK0Ube0aL0ZAj9Wg2bZEJ8jXN1pO/1IOKL4fK97g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=BIuneDHh5RZByOlHybUEbZOMV0xtuh2BkQFO0M0WPII=;
 b=cJ3w5mGB7w/b3/j1mGUdpSjZ9Lt2vc8VJLYBWNfHYHpuSzquvGAXV6ABF3x73kau9/BZ1JzLLRoD9w/MIF3AMmTAbpbM5/5HwJk9c1spd0/STmCV/0V4YaCM8jEj1lJe0/0Cxf0aMRvBcJIW5kUCa9yk/2b3SELFEBFvtiQbJw9T0EnibFUQbsP8oQzA4BsSj0Gp6N/lw5Ako8D7ITyrC0YJEp3xPaHfRxcDhLpDpbPR4fJ/w7frJ7CaJr7UtV6zG7LX1sK8PcOtXjdkqU8zPUsyTauNPO6CHMRBKYUoKjB/rAS3z+mXAzezWgBoT28uffAdo1vlWbAx8VMutRplDw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <5f52598e-d72b-7bd6-b47a-d4ee2faadf5e@suse.com>
Date: Tue, 22 Feb 2022 10:59:04 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v2 3/3] x86/perfc: fold HVM's VM-exit counter arrays
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
References: <ff461a77-93a0-5424-6565-2e947bec3912@suse.com>
 <6a2a47af-4ae1-2fe9-1190-e15b6ce742e6@suse.com>
 <YhSveDsp+3NW3hYX@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YhSveDsp+3NW3hYX@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM5PR0701CA0054.eurprd07.prod.outlook.com
 (2603:10a6:203:2::16) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 8f07c6c0-494d-4501-d9d3-08d9f5e9f67e
X-MS-TrafficTypeDiagnostic: VI1PR04MB4143:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB4143CD24788DB3E0E881CB5CB33B9@VI1PR04MB4143.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	rq7++xmmKfWnsO8v+XOJQPWulOGXOAgUTEmASZPbwaK0usQiZTDWgkQxvaV5Ah7CdV4d48FRdVDfFmNj/oDJqN4YlwAefZiNPJF2bNtWQfHBh3wOm3eMaap76Wb/ZruAByzhsTYzvX5M+VN7K0CCpvJ4o8BlihoY3Kf9JdSHm8wf+AO9Gh0gqGWxL5aq9TEIzTr2PH0Bd+QKHTmhVxLqwjPJTPn/DgTbmuthfhkkb3exqrFgVRR391Jpya7QdROneGubJPJHVeD830HSBhCwoQfC+cKzCNV87bWuLu7MM+Wr5I8G8DEIqMHAAiv/7ABpLt73XcsJkyLGf+A/uQ/umEXFgs6tMwE8tje02zcc6UQ7w+0JAjbsRXnE6iy+nsKgbitR6amn70d48T/8ZbzFzAve7TswgP8RTTpIx1QahyqYSy47Kw4BfE0sWnfI6ZXHz+XblDxqAbjX7VwxBuTilPZ5ORuieJ0y6NbwC5/st3KgkKp5qP4WJZFixAhhhh0oj/zIuZVrfIBrMa3hvvkSO/aO0yjIE3bvkXqArxnQOMXiyrjclMKeQpK3Vb10mlRTUA2ibpFwl8Q8HZTW6+AvGJc6OrZ93yDk/Td1Pp4+bXRcO3JVqw7HGG/vAuw2b+JqRiVOQi8M1JvJaH3TD2c5cUQi/N3PhYoYiYDPlNR5aow0SyGFqEbYW8cCqiesBZR+oOJi4YazbNf8FfBGJL0SKAN3luTdfrG72e4VU8BXunv7DWunx5kdi511/OgjkqtJ
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(316002)(2906002)(53546011)(2616005)(6506007)(66556008)(66946007)(66476007)(8676002)(4326008)(6512007)(31686004)(5660300002)(38100700002)(26005)(31696002)(6916009)(8936002)(36756003)(186003)(86362001)(6486002)(508600001)(54906003)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?EyJcmu8JsBvunNNEfejp4pfiZd1YevvDroxe7pwF4SF7S1nqfMwLLrc3wbEW?=
 =?us-ascii?Q?rrRQ79b7klGJAG43VR3XfQHvTIcCXWYogcO5Ujye/mEMIoo+lE2PNuPlDVjg?=
 =?us-ascii?Q?Uuywh+WHof7K29MSsB2XnzMIUpMfdKXt47btSJ2BenufHGRdOKZYkSALiLlQ?=
 =?us-ascii?Q?gjx7+TJ8YxVD/yKXQQB0YByumADOFZbj4e/r5xtHws8eVDvcY/XdyN38O6X7?=
 =?us-ascii?Q?kKVkenoZz6wIMBlWu09bVXwnWx2WtsRKq33kRf1ocVoQGJQ4A6Vnc127PB9Y?=
 =?us-ascii?Q?0jXkMAK1kLLimvyDn6I10sRVlEKRMKi0QHBcS4jxAomeJXG7odXOFLN2Z2PN?=
 =?us-ascii?Q?4AsdH6NUiM7x2+A8bY7ztoJCwU13m8N/QtoRHXSGUSW4exNoe2VsJY45OIqL?=
 =?us-ascii?Q?o2Eu8xQbmsskKwe+eKGGaKr+P85vFFLGp+4tj9auJ4k7TpYEkn2fDMyaNnuw?=
 =?us-ascii?Q?c7TobCj4bNxNJyKQqCz90seJ/30kRMq5djqQKKVRi5UvWeY8HUTvoEdCZXEl?=
 =?us-ascii?Q?JNEiLBOnMWNlrY1VAskmHQEG3B5ZS0GYVf9v/4JUQNoG4vWdwKsgNt5t5sZI?=
 =?us-ascii?Q?4dwKme1AfsmFzGVTwRgyD9e8tYhcfjnNMkmZp0A2I0S7rizCGH4Z3IpuMzOJ?=
 =?us-ascii?Q?bl3khuwWU8ocjkXqekSfIzKwWZQgZ0NagnhV/qNdCjTjqvvX6A37wdO1nr3V?=
 =?us-ascii?Q?esx2SMVd/MLZmUate/Li11WPhlfmug18NjtXuP7OkzEmyUUqsjoOochMi71V?=
 =?us-ascii?Q?vi32k/rkwAGi9YnvlmxFTB5QHWDa4DcY8tTAQOqUBhBWEs7hjj1K2g0IBuOL?=
 =?us-ascii?Q?MPo6sxP74ZUdsMdwkpS64YGfl/rL10wR+XJ1yFGxe0tPmHjje0U0lto0eEvE?=
 =?us-ascii?Q?UZ4Dp/451WtdHK6xVK324/BUpUC//2RBTsiD9zhUQN/aNQjEAN+TMNL+c04g?=
 =?us-ascii?Q?PY3u05EYHkGKAHu4KxLRFkMHlh8RyVvgwrJ+A3DTNNoogHbqhY4283/tr/q5?=
 =?us-ascii?Q?kNi/mw4hnzlVF5nXVZMhbrRz2NUpst6AukMnQN2tplDcoQigVAZJkVHEwG+O?=
 =?us-ascii?Q?st2IAxh7TyOR5uTK52mh/hBM29uNUoNCMOWESnpMjQ6Xs3tWBh6fGoMo17Eo?=
 =?us-ascii?Q?HIChHCGxGkXXjea2sW9oSzQm35hooC1i8BWy4kqhZ7qX3NwylbLP9tTrwrQg?=
 =?us-ascii?Q?Ly9FJ/xOVF5aW8Xr9Mm5/KvcDe8o4cz1O/NmtMRO4ZF3wlTA9TXZXm0xWeN0?=
 =?us-ascii?Q?Tlf2EsEgabWfeu8BcVknSBWNbYDwc2hyWpnFsQ00ic6NaH8pN6RrCZHqKkmU?=
 =?us-ascii?Q?4+Dqv/Lp/OxL2b0Vep3Gj0Db3+aVyMqZXdSRZnHI0oZ7t7YCz3RzTR1gVCKY?=
 =?us-ascii?Q?sel4X5VSmdSAxgiqQK6wyNk15nSi0Bl+ARRZxC3vYLXqL4O/aoffuN/kMt1a?=
 =?us-ascii?Q?p4KkF1j4HRiVH3zzifNxv5LPsxB7XecIdyLvHVElTqfIQuhfhC30ouWm7y1n?=
 =?us-ascii?Q?btG6QGthsdkuLUIxXFxVVXt0GkpJLI4NeFi32078Hi5CclhlsJh0kaPHEiXm?=
 =?us-ascii?Q?plM518f48UTPZ9dBnIfjfT9pLfoVzesuMK07QftPBbwsu9jv/XeO5KC95I+A?=
 =?us-ascii?Q?MJJSGV+sdVX+KK7emjT9FvA=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8f07c6c0-494d-4501-d9d3-08d9f5e9f67e
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2022 09:59:06.3516
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: irjIUk1qtMejn9x2NI4wLxO90tn7/ghKXYVu+mV6sxE3EMX0jyB01X1RDOEqsom1F5758UcDsZxjRukdAlxdYw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4143

On 22.02.2022 10:40, Roger Pau Monn=C3=A9 wrote:
> On Wed, Jan 05, 2022 at 02:59:03PM +0100, Jan Beulich wrote:
>> Only one of them can be in use at a time, so make the whole set union-
>> like. While doing the rename in SVM code, combine the two perf_incra(),
>> generalizing the range upwards of VMEXIT_NPF.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>=20
> Reviewed-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>

Thanks.

>> --- a/xen/arch/x86/hvm/svm/svm.c
>> +++ b/xen/arch/x86/hvm/svm/svm.c
>> @@ -2644,7 +2644,10 @@ void svm_vmexit_handler(struct cpu_user_
>>          goto out;
>>      }
>> =20
>> -    perfc_incra(svmexits, exit_reason);
>> +    perfc_incra(vmexits,
>> +                exit_reason < VMEXIT_NPF
>> +                ? exit_reason
>> +                : exit_reason - VMEXIT_NPF + VMEXIT_NPF_PERFC);
>=20
> Should we assert that the index used here < SVM_PERF_EXIT_REASON_SIZE?
>=20
> Just so that adding new exit reasons without increasing
> SVM_PERF_EXIT_REASON_SIZE is not likely to go unnoticed?

But that's what the comments are for that the previous patch adds.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Feb 22 10:05:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 10:05:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276622.472836 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMS3I-0002n3-BE; Tue, 22 Feb 2022 10:05:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276622.472836; Tue, 22 Feb 2022 10:05:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMS3I-0002mw-85; Tue, 22 Feb 2022 10:05:48 +0000
Received: by outflank-mailman (input) for mailman id 276622;
 Tue, 22 Feb 2022 10:05:47 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=IN1Y=TF=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1nMS3H-0002mq-00
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 10:05:47 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id ff67cd33-93c6-11ec-8eb8-a37418f5ba1a;
 Tue, 22 Feb 2022 11:05:44 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 89DB0106F;
 Tue, 22 Feb 2022 02:05:43 -0800 (PST)
Received: from [10.57.3.116] (unknown [10.57.3.116])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2E72C3F5A1;
 Tue, 22 Feb 2022 02:05:41 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ff67cd33-93c6-11ec-8eb8-a37418f5ba1a
Subject: Re: [PATCH] xen/arm: Rename psr_mode_is_32bit to regs_mode_is_32bit
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
Cc: Julien Grall <julien@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20220221105931.12028-1-michal.orzel@arm.com>
 <1531f49d-c74c-8a41-a917-cfe76bee8e7d@xen.org>
 <05b5877b-7dc0-3d35-f073-5721e1605321@arm.com>
 <A666192F-D43D-484D-8125-8908F45155BB@arm.com>
From: Michal Orzel <michal.orzel@arm.com>
Message-ID: <c38ed3e6-0667-010a-705a-3f0b7308afab@arm.com>
Date: Tue, 22 Feb 2022 11:05:30 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <A666192F-D43D-484D-8125-8908F45155BB@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

Hi Bertrand,

On 22.02.2022 09:48, Bertrand Marquis wrote:
> Hi Michal,
> 
>> On 22 Feb 2022, at 07:07, Michal Orzel <michal.orzel@arm.com> wrote:
>>
>> Hi Julien,
>>
>> On 21.02.2022 16:58, Julien Grall wrote:
>>> Hi Michal,
>>>
>>> On 21/02/2022 10:59, Michal Orzel wrote:
>>>> Following a discussion [1] it seems like that renaming work has
>>>> been forgotten.
>>>
>>> This is in my todo list of clean-up I need to do for Xen. But I haven't yet had a chance to look at it. Thank you for taking a look!
>>>
>>>> Perform renaming of psr_mode_is_32bit to
>>>> regs_mode_is_32bit as the function no longer takes psr parameter.
>>>
>>> If we modify psr_mode_is_32bit(), then we should also modify psr_mode_is_user() because they have the same prototype and we should keep the naming consistent.
>>>
>> Ok, I agree. Do you think this should be done in a separate patch?
>> FWICS, psr_mode_is_user is used in traps.c, vcpreg.c ,vtimer.c and vsysreg.c whereas psr_mode_is_32bit - only in traps.c.
> 
> I think it can be done in a separate patch.
> 
Ok, so I will push a patch series consisting of two patches.

> Cheers
> Bertrand
> 
>>
>>>>
>>>> [1] https://marc.info/?l=xen-devel&m=156457538423787&w=2
>>>
>>> NIT: The first sentence and this link adds value for the review on the mailing list (we know where the request came from) but doesn't add any after the commit message (there are no extra information in them).
>>>
>>> So I would move this information after ---. This will get dropped on commit.
>>>
>> Ok.
>>> Cheers,
>>>
>>
>> Cheers,
>> Michal
>>
> 

Cheers,
Michal


From xen-devel-bounces@lists.xenproject.org Tue Feb 22 10:12:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 10:12:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276629.472847 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMS9Y-0004CQ-36; Tue, 22 Feb 2022 10:12:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276629.472847; Tue, 22 Feb 2022 10:12:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMS9X-0004CJ-UZ; Tue, 22 Feb 2022 10:12:15 +0000
Received: by outflank-mailman (input) for mailman id 276629;
 Tue, 22 Feb 2022 10:12:14 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nMS9W-0004CB-Di
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 10:12:14 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nMS9V-0001P4-Ni; Tue, 22 Feb 2022 10:12:13 +0000
Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=[192.168.9.70])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nMS9V-00034J-Hd; Tue, 22 Feb 2022 10:12:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=M1G0fvJiOdsUQhk8JK3u8LuMlrfVoGz0NngWLNWF8wE=; b=2txrwz7q56EoOkylZ4ywyhDhx3
	cmA7CsiM+MWOdlH4RhEKEYV58NLcTjioMsnOcqHNF+ZE5nOFbseXtxZvNrrSlRs2bRxMpNjbcEjvo
	CYW8N36l0dsaPwnNbNCnqmkm/txzmempVBjO6LT24x6kWXV4UzUSvz4D/RGZ8Q7KA3Es=;
Message-ID: <0d089ace-f35f-b7ad-fe25-db937a00e802@xen.org>
Date: Tue, 22 Feb 2022 10:12:11 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.1
Subject: Re: [PATCH] xen/arm: Rename psr_mode_is_32bit to regs_mode_is_32bit
To: Michal Orzel <michal.orzel@arm.com>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <20220221105931.12028-1-michal.orzel@arm.com>
 <1531f49d-c74c-8a41-a917-cfe76bee8e7d@xen.org>
 <05b5877b-7dc0-3d35-f073-5721e1605321@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <05b5877b-7dc0-3d35-f073-5721e1605321@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit



On 22/02/2022 07:07, Michal Orzel wrote:
> Hi Julien,

Hi Michal,

> On 21.02.2022 16:58, Julien Grall wrote:
>> Hi Michal,
>>
>> On 21/02/2022 10:59, Michal Orzel wrote:
>>> Following a discussion [1] it seems like that renaming work has
>>> been forgotten.
>>
>> This is in my todo list of clean-up I need to do for Xen. But I haven't yet had a chance to look at it. Thank you for taking a look!
>>
>>> Perform renaming of psr_mode_is_32bit to
>>> regs_mode_is_32bit as the function no longer takes psr parameter.
>>
>> If we modify psr_mode_is_32bit(), then we should also modify psr_mode_is_user() because they have the same prototype and we should keep the naming consistent.
>>
> Ok, I agree. Do you think this should be done in a separate patch?

I am fine either way so long the two changes are committed together.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Feb 22 10:49:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 10:49:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276637.472857 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMSiu-0007TZ-UK; Tue, 22 Feb 2022 10:48:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276637.472857; Tue, 22 Feb 2022 10:48:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMSiu-0007TS-RG; Tue, 22 Feb 2022 10:48:48 +0000
Received: by outflank-mailman (input) for mailman id 276637;
 Tue, 22 Feb 2022 10:48:46 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=AYeZ=TF=invisiblethingslab.com=marmarek@srs-se1.protection.inumbo.net>)
 id 1nMSis-0007TI-Hl
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 10:48:46 +0000
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 00d88a5e-93cd-11ec-8eb8-a37418f5ba1a;
 Tue, 22 Feb 2022 11:48:44 +0100 (CET)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.46])
 by mailout.nyi.internal (Postfix) with ESMTP id 097C65C0194;
 Tue, 22 Feb 2022 05:48:43 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163])
 by compute2.internal (MEProxy); Tue, 22 Feb 2022 05:48:43 -0500
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue,
 22 Feb 2022 05:48:41 -0500 (EST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 00d88a5e-93cd-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-type:date:date:from:from
	:in-reply-to:in-reply-to:message-id:mime-version:references
	:reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy
	:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=DTcsRQMhHEsT227VK
	XKHQyOwB4dIKR9vzR6umqoiTuA=; b=K8S59BhMrGaVw44sfUv7enmQYQ1OVuGmQ
	lpQdCdIjz71gjc8sElBsakHzdjkF/fWn3d2LPUPcfAoivcwe+LV83yvizXy8vaL1
	XfMNOT3uVokxiK0Dva1CKvI7FSrewINC6IUECvQlEIoHu9w78/f2s1fKyDF0INbC
	HsSLcrmRrIJT5/+vRozrUSm9SO5w8lMCyFGd2ChhAXZh3hkFf0pXORVGYOZr7yVd
	GeRS8M7Rk4riPYq9RsXhn/5WS8f2iwWDDgYwCpcC03bJO/hvHEar5Wn/qy+5Rshm
	Z+nH9mO4qHq+ZgELZ0kT+6wttK1YoXw3Oispb/yo3+GGM8PXWifbQ==
X-ME-Sender: <xms:ir8UYjuEXGwrbqKlY20yqYFrw4YF0iLQqOk0_PB3zXdNqaovd-AkCw>
    <xme:ir8UYkdri5qEk2tUvb28L1LpdoqlMw3Iqe9DKG7bBlGIM6lMNdVAiaDTeCQO5UXoQ
    tVSU7hQzf_V2A>
X-ME-Received: <xmr:ir8UYmzPkn5aAbAi0LxhaIFC81fGs94iCGgv4Jo0uTDOx3FWBmZLEPbC2OdDIXU-pg-OrVu8cb-VucyP2GDx_yLlaJrXSNGQ0w>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrkeekgddulecutefuodetggdotefrodftvf
    curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
    uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
    fjughrpeffhffvuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrrhgvkhcu
    ofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinhhvih
    hsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepheevvdeu
    veehkeehhfevgffggfevudegteeugfeliedvhefgueeiuefgteetieffnecuffhomhgrih
    hnpehkvghrnhgvlhdrohhrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhep
    mhgrihhlfhhrohhmpehmrghrmhgrrhgvkhesihhnvhhishhisghlvghthhhinhhgshhlrg
    gsrdgtohhm
X-ME-Proxy: <xmx:ir8UYiPFUO_QAu-DIAtp-DLZkzErUXDnPkxfPLfVkL7M4yyF2MW6Gg>
    <xmx:ir8UYj8mCcn8tt4pgKNdOjsz4w8sY_tRUU12rDq9Sf9EyA_QQo8JWg>
    <xmx:ir8UYiV_PDaowG3PCoghYbuma6I3uze38hhFB1zjhmt03mAkH0A-xA>
    <xmx:i78UYkNV0oJsrIv2nwuuYBiVrEqvXd97V9QI6DwUM69aJGRhHIPadg>
Date: Tue, 22 Feb 2022 11:48:38 +0100
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	Michael Brown <mcb30@ipxe.org>, Wei Liu <wei.liu@kernel.org>,
	Paul Durrant <paul@xen.org>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	"moderated list:XEN NETWORK BACKEND DRIVER" <xen-devel@lists.xenproject.org>,
	"open list:XEN NETWORK BACKEND DRIVER" <netdev@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] Revert "xen-netback: Check for hotplug-status
 existence before watching"
Message-ID: <YhS/hvHQO335elw7@mail-itl>
References: <20220222001817.2264967-1-marmarek@invisiblethingslab.com>
 <20220222001817.2264967-2-marmarek@invisiblethingslab.com>
 <YhSfYyh3xU4HZKek@Air-de-Roger>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="0J0yTdf+LQeqmBEg"
Content-Disposition: inline
In-Reply-To: <YhSfYyh3xU4HZKek@Air-de-Roger>


--0J0yTdf+LQeqmBEg
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Tue, 22 Feb 2022 11:48:38 +0100
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	Michael Brown <mcb30@ipxe.org>, Wei Liu <wei.liu@kernel.org>,
	Paul Durrant <paul@xen.org>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	"moderated list:XEN NETWORK BACKEND DRIVER" <xen-devel@lists.xenproject.org>,
	"open list:XEN NETWORK BACKEND DRIVER" <netdev@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] Revert "xen-netback: Check for hotplug-status
 existence before watching"

On Tue, Feb 22, 2022 at 09:31:31AM +0100, Roger Pau Monn=C3=A9 wrote:
> On Tue, Feb 22, 2022 at 01:18:17AM +0100, Marek Marczykowski-G=C3=B3recki=
 wrote:
> > This reverts commit 2afeec08ab5c86ae21952151f726bfe184f6b23d.
> >=20
> > The reasoning in the commit was wrong - the code expected to setup the
> > watch even if 'hotplug-status' didn't exist. In fact, it relied on the
> > watch being fired the first time - to check if maybe 'hotplug-status' is
> > already set to 'connected'. Not registering a watch for non-existing
> > path (which is the case if hotplug script hasn't been executed yet),
> > made the backend not waiting for the hotplug script to execute. This in
> > turns, made the netfront think the interface is fully operational, while
> > in fact it was not (the vif interface on xen-netback side might not be
> > configured yet).
> >=20
> > This was a workaround for 'hotplug-status' erroneously being removed.
> > But since that is reverted now, the workaround is not necessary either.
> >=20
> > More discussion at
> > https://lore.kernel.org/xen-devel/afedd7cb-a291-e773-8b0d-4db9b291fa98@=
ipxe.org/T/#u
> >=20
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Marek Marczykowski-G=C3=B3recki <marmarek@invisiblething=
slab.com>
> > ---
> > I believe this is the same issue as discussed at
> > https://lore.kernel.org/xen-devel/20220113111946.GA4133739@dingwall.me.=
uk/
>=20
> Right - I believe we need to leave that workaround in place in libxl
> in order to deal with bogus Linux netbacks?

I'm afraid so, yes.

--=20
Best Regards,
Marek Marczykowski-G=C3=B3recki
Invisible Things Lab

--0J0yTdf+LQeqmBEg
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmIUv4YACgkQ24/THMrX
1yyKoggAg6fLt83xdWaCGP1TaH51wysnBj1sxuSzFeh7BUVHdyWYYlfTAQ+Ytghr
N4uCqUyXqTpheDM7BE/9pXSiuHH1WqmClAef7SF9MweHT0zvDkL0J7McMSqLBeG4
Qj67yHz4/C1yAhN3dAdP8933l4nmzvzOGNdG77D3P1IvU+41xtyoZPVfH5DDNscG
yfYwoeI/oYRNtvd1H7+UD3ANkwEjnmFIVGRtFcb7G+NH+d9vGQFbODww95oCbWWA
PfKL7gBFGNDuNnIABFCoI/RsF523zRSSeBesdAImUM+531IRapB9J9FYp4E6M3RA
Bt5hPaIrX6OFgur2u9aShGvIdH+FYQ==
=0A40
-----END PGP SIGNATURE-----

--0J0yTdf+LQeqmBEg--


From xen-devel-bounces@lists.xenproject.org Tue Feb 22 10:54:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 10:54:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276644.472869 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMSoW-0000RE-Jh; Tue, 22 Feb 2022 10:54:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276644.472869; Tue, 22 Feb 2022 10:54:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMSoW-0000R7-G9; Tue, 22 Feb 2022 10:54:36 +0000
Received: by outflank-mailman (input) for mailman id 276644;
 Tue, 22 Feb 2022 10:54:35 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Woib=TF=citrix.com=prvs=045a4fa17=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nMSoV-0000R1-6q
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 10:54:35 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d04b9e50-93cd-11ec-8539-5f4723681683;
 Tue, 22 Feb 2022 11:54:33 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d04b9e50-93cd-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645527273;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=GFaI6nSJKdNx7VzF9bzjMSUNMRy0c0wLRen1E+fsKDY=;
  b=HvEotSkD3ka7d/FEIQFodvSb0WaAN9wJ4uTnJ4uFugd9Ld6aE1I+0bCx
   MFWxLgPXFWMSlOJL9od6MKfFVxKnMmFcO0BWkfHd3WJ2Vmbe42oF7oUIA
   X03WZT677dYgQkSVyjwy/EbTTZ6/Xsj7l+QBTLVLk8zrQlWukMQu3G3Zh
   8=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 66959630
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:v3dIAqxb5j73/oRZMvZ6t+clxirEfRIJ4+MujC+fZmUNrF6WrkUOy
 TcYUDuCbKmIYjSmf9l/bI/k9UgOvpPcxtYwTQJoryAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGHdJZS5LwbZj2NYy24LhWWthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 Npltoe8c1xqIbPwvL49aRxbGAx/Jp1I0eqSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DFYUToHx/ixreCu4rW8vrSKTW/95Imjw3g6iiGN6AO
 ZtEOGQ0NHwsZTVvHl0dUJAjvN6RuUClKx9/jlCLjoMOtj27IAtZj+G2bYu9lsaxbdVYmAOUq
 3zL+0z9AwoGL5qPxDyd6HWui+TT2yThV+o6C7mQ5vNsxlqJyQQ7ChcbSF+6qvmRkVOlVpRUL
 El8x8Y1hfFsrgrxFIC7BkDm5i7f1vIBZzZOO+4h5DvWibXK3yLDJlIBTTVsaccWuuZjEFTGy
 WS1t9/uADVutpicRnSc6qqYoFuOBMQFEYMRTXRaFFVYurEPtKl210uSFYg7TMZZm/WoQWmY/
 tyckMQpa1z/Z+Yv3r7zw13IiinESnPhHl9svVW/so5IA2pEiG+Zi26AtACzARVodt/xory9U
 J4swZP2AAcmV8zlqcB1aL9RdIxFHt7cWNEmvXZhHoM66xOm8GO5cIZb7VlWfRk1b5paKGK0O
 hOK4Wu9AaO/2lPwNsebhKrrVqwXIVXIT4y5Bpg4kPIUCnSOSON31H43PhPBt4wcuEMtjbs+K
 f+mnTWEVh4n5VBc5GPuHY81iOZzrghnnD+7bc2rnnyPjOvFDFbIGOhtDbd7Rr1ghE9yiF6Oq
 Ig32grj40g3bdASlQGNr9ZIdAhSdSJT6FKfg5U/S9Nv6zFOQQkJI/TQ3akga8pimaFUnf3P5
 XazRglTz1+XuJENAVzihqxLAF83YatCkA==
IronPort-HdrOrdr: A9a23:lFLtTq3njdpy3Giuv8MF4AqjBRxyeYIsimQD101hICG9Lfb2qy
 n+ppgmPEHP5Qr5AEtQ5OxpOMG7MBbhHQYc2/hfAV7QZnibhILOFvAt0WKC+UytJ8SazIBgPM
 hbAtFD4bHLfDtHZIPBkXOF+rUbsZi6GcKT9J/jJh5WJGkAAcAB0+46MHfhLqQffngcOXNTLu
 v52iMznUvHRZ1hVLXdOpBqZZmgm/T70LbdJTIWDR8u7weDyRmy7qThLhSe1hACFxtS3LYL6w
 H+4kzEz5Tml8v+5g7X1mfV4ZgTssDm0MF/CMuFjdVQAinwizyveJ9qV9S5zXMISaCUmRQXee
 v30lMd1vdImjTsl6aO0F3QMjzboXMTArnZuAalaDXY0JTErXkBerV8bMpiA2XkAgwbzYtBOe
 twrhKkX9A8N2KwoA3to9fPTB1kjUyyvD4rlvMSlWVWVc8EZKZWtpF3xjIfLH4sJlOy1GkcKp
 gnMCgc3ocjTXqKK3TC+mV/yt2lWXo+Wh+AX0gZo8SQlzxbhmpwwUcUzNEW2i5ozuNxd7BUo+
 Dfdqh4nrBHScEbKap7GecaWMOyTmjAWwjFPm6eKUnuUKsHJ3XOoZjq56hd3pDhRLUYiJ8p3J
 jRWlJRsmA/P0roFM2VxZVOtgvARW2sNA6dvP22J6IJzYEUaICbQxFrEmpe4PdIi89vd/HmZw
 ==
X-IronPort-AV: E=Sophos;i="5.88,387,1635220800"; 
   d="scan'208";a="66959630"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=J6dmgfTAx1zDfqssuht7HC9ufb1N6DYi3GyoVJDRlEDUiRLoMTvQns+zuMDgCPH4mlFqtz+HOEvNtUoXClNUepAQXEq9MoTDSdxbttsuHZ6gLqcjNubqQt0obBv6b95p8/M+jV8Tu0aTtilZ4epsaIT+H3j64N+OrhFbXRlnBowcF5C005vedKsxpoCMBRyLTMt0DNuGj53JVcdhZmbNe6f6PtrKz8OMz8CW4MPrGdaliKBGIRLYHyg2e8biwfNzDvYnji6YTob7TDO4vCIb/jYJpkzfzeIAZ6w2/Z0y1gTobWDZwKdn9o/H9ibZA6KRid/aJxtLmGeBE2FEyAv7ZQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=GFaI6nSJKdNx7VzF9bzjMSUNMRy0c0wLRen1E+fsKDY=;
 b=Tlkialn8NpevDcIUzTW31Mv3q4k1QeMXntVsXh0m+YZo784kvb+8Mtw2xPVqzhaawOt3hUdLrFwISwFnbM64t6IeMDko63V0FnkSDVwdFhU3g1SQlW9XYR6t2HdWdBSax0x9dbsFWCfhXg3XrkV17+1SSylGOuVWIyXYls9DYVo+C2XPecJ6VhEddRq8mpg+eo+CZCw1Gdt7OUWIrWggoMAEGOSIRhZRhijEMW02vO206s5byWNqOmhT5zUl92mbaOTr7cHBsdCdAOPIunWD+hASEu/WqQC2EQJGdR26ww0YmH/nZ9LZA1orth/wVkxm0z/DjbeXylLccra7AheTPA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=GFaI6nSJKdNx7VzF9bzjMSUNMRy0c0wLRen1E+fsKDY=;
 b=Qw1ErGi8FiHthdOUj5/xDl4R/pvJgkF73h2GueyMTKAXSLFLufJmgSevzArrY3spv5bWXfKjU48b8ihQuDLNx/5SCRrqD2W986yguMalPHKvzO0yDJbqoSqQ+fh3GD8z4J9k30xQUgbL61BAhHn2PLekmO7NhRpm+GAdtt9mRKs=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>, Xen-devel
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2.1 8/7] x86/IOMMU: Use altcall, and
 __initconst_cf_clobber
Thread-Topic: [PATCH v2.1 8/7] x86/IOMMU: Use altcall, and
 __initconst_cf_clobber
Thread-Index: AQHYJ011tWngdwKc2UG3RuxDqKou56yfTukAgAAXlAA=
Date: Tue, 22 Feb 2022 10:54:22 +0000
Message-ID: <9e442a8d-ef71-3776-e655-8c8a226af706@citrix.com>
References: <20220214125632.24563-1-andrew.cooper3@citrix.com>
 <20220221180356.13527-1-andrew.cooper3@citrix.com>
 <0c253fda-c5f6-b7ea-df6c-8b43b86c6a59@suse.com>
In-Reply-To: <0c253fda-c5f6-b7ea-df6c-8b43b86c6a59@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: b93149d8-bfc4-42c8-0b1a-08d9f5f1af4c
x-ms-traffictypediagnostic: BN7PR03MB3810:EE_
x-microsoft-antispam-prvs: <BN7PR03MB3810DA600867636B9C247325BA3B9@BN7PR03MB3810.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 27T0ludaGsI3z0mRTJZV+v9PH6/jwcK0MQtv1EmPTiuOfAIydSl40aKrvMlCU4CepHPB7XjXFGDns1/M6nln9goX8Ok0gFEHsxJ9bnGCasazsUZ1+tM7EtUtMUny3Xr9/v2XPvnFNfvBbekL6AZWkX73rghAxeJ7F+hW0JrHJwaSxwf1HTf5eldVihY1Uczzkbpx7jzzytRHlJLCbpeP0M9pEXwnpNg+0ilgU4bM6t1pTFPugyjWjc25sVMDcc6rQmCfyHFxfvmB4OjxPnNvQNZKZ9JwjroiKGlfagy4tDJIk41ZowscBMvh9oLUXt7Av7VklC3/bR584lHbybRaQ/2FcFbwXEAaabkUf5JyGFBj0csqaCoJfTaYxV+g0v5te2BmBEmhFjZi29iOCPiHj4tsswv6mEVdRq4tUurXzDfY5jauhV+0f6LPaofJng5z9z0Xq436e2kB6zzLnOFueeS5ho6/h9Wm8U5CZ+IUHeH/5qJPSzMMhiqE7b0ZKY8Sszf/OG60PVF8PAoYfoNC7VwvgLfBYHB0LkDJqtiOhaAhqY4tFlA5a24uGPdSC7Ocr0EVnLmAMwkC3mUVu4+4jvUrXE5p4IM3amRP+0dwgSMyoamxvHcJnPWJCKwh1L+3sdbimdA6IIf3/V1e8YGwxhV0UmnRIC4YjHKzCdNABlRDG963WfEbfauNIDv5fgck5DdL61cb5CrsEcvq0GPfwP5yOp2VUruAQDFftoEP/nKIF3INm1ukHoPdQiFCksOS5Zxrwc3T4QyVa3Mwf8tymQ==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38100700002)(82960400001)(2906002)(122000001)(38070700005)(5660300002)(31686004)(8936002)(36756003)(83380400001)(6506007)(4326008)(31696002)(66446008)(66556008)(66946007)(64756008)(508600001)(66476007)(8676002)(6486002)(91956017)(76116006)(54906003)(6916009)(26005)(71200400001)(186003)(6512007)(316002)(2616005)(86362001)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?eGRkaGtPTkpFVFB1TkNqcUNoZVpNNEJBd3NDV3p2UFBCNFZZNGhDODh4N0cw?=
 =?utf-8?B?VUVBR3JQV1dRRWZ2YU41K3hzTFc2S2NROWt5ZVV1KzIxQjBjRk1rZHEyeEZU?=
 =?utf-8?B?SnBIZWMxNDFYUTJWZ25veVdZUHk0T0ttMHp2OGNWRGI5VG9vMGlHb0lxQlNQ?=
 =?utf-8?B?bUlXclFoNFMvYmFMQTU4K0hyVHF0MlJwd2pCOW9QZlBvV0JtQVFndjBxMXNw?=
 =?utf-8?B?L084VXBqeWNmaWxlUDNtRzg1M01aTUZ2eU5TOVRrV25XM3BESE0vczFiY0l4?=
 =?utf-8?B?OXRPRmEyZEd2SFFlaTk2dVF3NmZQTDdaS1hiZjdiZFdWVGtHNnNYVG1zcUR3?=
 =?utf-8?B?QUt3UVBRdVEvMk5RS29TakxIb3VKZnV3YUVBZnlpaGYyUUwxM2RiZnhCZTVS?=
 =?utf-8?B?YjRPNDhGN3l0WG15dzhjaEVQNGZyK3UrZTkvazBJOEJBZmt2WmZzZVV0WElW?=
 =?utf-8?B?MGRpMmZWeWo1WXNlNVhJazQzZ0ErTU5VYk15V3VjQWUxZmJ6NWFqR0JaVWdC?=
 =?utf-8?B?dWN5VkZJU0ZzQllQWXR3ZXJhbU5BbjVpaW5XTE95UEg4Z2kyQXdRRnFYeDJM?=
 =?utf-8?B?ZW9GQ1VUYnpReFBQZXlkVTYvcG1sYkEwRnNBRHpoUDNsQk80MThydmd0disy?=
 =?utf-8?B?Z3RweFhPZ0N3UXQvTHBJOHhPYTA1dUhpdUExUjNoeHBjRFM5QlFDcVppTHVn?=
 =?utf-8?B?WEk4NjFLSDB6d0Y3NTUyVTcxVWNpV0h2dHZnanRBSXc3bHd4N3NSRVU3TUhl?=
 =?utf-8?B?VGdSbHhWV2Fya3RSWlRJZmRRMEF6ZUpFREQrcS9IYndSQzVSWFlIV3JLUEp3?=
 =?utf-8?B?aU1QVTNCWXdVZC80ai9FWGVVTk82aFZGdkl0Q1VIY21pakQzclZLendVWWtX?=
 =?utf-8?B?aXFPMXBRT042K0ZHTGRVblB2Zy9FenZ6T1pFVngxUXlKVlROWjY0SCt6NnN4?=
 =?utf-8?B?LzVrV2lEV2xUL0xuMkx6RFNEVnkxWWg0Rkoxck95VUJweGJTUjhzREExUml4?=
 =?utf-8?B?Wlo4TWFwQVRoVkYxY0RObGU0enBSMjRVbG5YSzk0YjBtb205Y1BjOGlGS3Rn?=
 =?utf-8?B?TDBOdmtMZjNWVFdCbjd1eEVGM1h6Q0tmdnZ2MDUvbWFvcERkZDR4SlNaenEy?=
 =?utf-8?B?OWZaSGNPY1BiLzltUHBHQlN6RFVOT3ZVRDF5U2pGYW5paDVORCtnRXM5R01E?=
 =?utf-8?B?WkNpWE5sMC93OTBMKy9UVG5kcTlZS3MyRDh4ejl5TGNlN3FUMFNMOWVSMk8y?=
 =?utf-8?B?a2dXUTBrdTdqdUlTS29ybWpTRE1DZ3MxR1JBbUpyZW5Yamowa3JrbXhWOCtX?=
 =?utf-8?B?T3RkWVhkdk00MkJZVDN0WnE0Y2Iwa2hvYW82blRjY3BwZjdYcVJwVWJjck1h?=
 =?utf-8?B?ZTM2QnhqNXkzbG5WK1cvL2FObnV6MjBlTUpBdVY1WjhZYUtIaCsrbWluZDNL?=
 =?utf-8?B?VkJhVFMwZkwyQ1JhU0U3UmhuNnRzcjl5ZnlOVHZQd1ZjSkJaR3B3U0ZOak5J?=
 =?utf-8?B?Tm14R3drNER6R0pBalZST1cvY3ptdm8xV1hDYnVXa0l1VDNFby8yS2NjNUZY?=
 =?utf-8?B?cm91YTBSREF4VThNTGtucmpEMEg2NmRXNmtXN1NDRHRhTVhrNGlFcXN6SWg3?=
 =?utf-8?B?QWY3STNHbVdodUxLSXFZdzZQMnVvdG5DR1JLMHRiSDg4QnRJdnJjZ1lvMHpP?=
 =?utf-8?B?NnVESTFNY2FwdUhIS3RZY3V4SmZlLzVtMktWcVBTOXN2RFBJUTVHWkk3bXJn?=
 =?utf-8?B?Zk1XOWhOdkNKdTBLRzl1T2t2allIdGk4bTV1WERHT2VnNU1TcHZONldwc241?=
 =?utf-8?B?RE5qSTE4QjQ5Q2pXbU5vZUJSbGNmbElSNCtjTVA1blJBSkM5Nm0xbFFpWVY0?=
 =?utf-8?B?Wnh2eW5PZ3k1SU1VcUZlcWNrTFFuQityalhTbDJDdFBwSEJMVTZEMXE2RHg1?=
 =?utf-8?B?c3lLbzhldVo5ZVdmMWR3U0NSc0RrdGhJcUJEZSt5TURrZVRoWHQvbVFkRHdO?=
 =?utf-8?B?OUhoamNDTzNpTWVlRDJqTU5kTFhFai8rTUltODNZUU1wZjhVV1hFbUxPNXZI?=
 =?utf-8?B?Uy9uMEYyeFBkT1Vsd3FNdmo2V1ZadGk0TDYzN1pmUCtac09zUUhkN1hqbUNa?=
 =?utf-8?B?dm00NjFISXBjbkxESUY2aDVIRFllakpCSlhwVDQvbTc5QVVVRExnbXBLcjBq?=
 =?utf-8?B?a3d1aHVIZXNuZ0t0N0QvRmJySTdtRm4wZlAzbnlOVmpwd0xwdUlBUC8xQkFF?=
 =?utf-8?B?K3l5dENFaU04VFBrNitxK1ZTYzhnPT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <84BA569D4928074F9A6B403EDA98952A@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b93149d8-bfc4-42c8-0b1a-08d9f5f1af4c
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Feb 2022 10:54:22.5305
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: t/ZNiAcEHEoiVy+rSufw0rwJFb9GF7mxgmXs+E/82RKgpStMwU0CyklVvOrNe1zIDkQn86cKA9MckSMLqJuyHa5Kz0qB20Nn05hrPpGZ/tU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB3810
X-OriginatorOrg: citrix.com

T24gMjIvMDIvMjAyMiAwOToyOSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDIxLjAyLjIwMjIg
MTk6MDMsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBNb3N0IElPTU1VIGhvb2tzIGFyZSBhbHJl
YWR5IGFsdGNhbGwgZm9yIHBlcmZvcm1hbmNlIHJlYXNvbnMuICBDb252ZXJ0IHRoZQ0KPj4gcmVz
dCBvZiB0aGVtIHNvIHdlIGNhbiBoYXJkZW4gYWxsIHRoZSBob29rcyBpbiBDb250cm9sIEZsb3cg
SW50ZWdyaXR5DQo+PiBjb25maWd1cmF0aW9ucy4gIFRoaXMgbmVjZXNzaXRhdGVzIHRoZSB1c2Ug
b2YgaW9tbXVfe3YsfWNhbGwoKSBpbiBkZWJ1ZyBidWlsZHMNCj4+IHRvby4NCj4+DQo+PiBNb3Zl
IHRoZSByb290IGlvbW11X29wcyBmcm9tIF9fcmVhZF9tb3N0bHkgdG8gX19yb19hZnRlcl9pbml0
IG5vdyB0aGF0IHRoZQ0KPj4gbGF0dGVyIGV4aXN0cy4gIFRoZXJlIGlzIG5vIG5lZWQgZm9yIGEg
Zm9yd2FyZCBkZWNsYXJhdGlvbiBvZiB2dGRfb3BzIGFueQ0KPj4gbW9yZSwgbWVhbmluZyB0aGF0
IF9faW5pdGNvbnN0X2NmX2Nsb2JiZXIgY2FuIGJlIHVzZWQgZm9yIFZURCBhbmQgQU1ELg0KPiBU
aGUgY29ubmVjdGlvbiBiZXR3ZWVuIHRoZSBmb3J3YXJkIGRlY2xhcmF0aW9uIGFuZCB0aGUgYW5u
b3RhdGlvbiBhZGRpdGlvbg0KPiBpc24ndCByZWFsbHkgY2xlYXIgdG8gbWUuDQo+DQo+PiAtLS0g
YS94ZW4vYXJjaC94ODYvaW5jbHVkZS9hc20vaW9tbXUuaA0KPj4gKysrIGIveGVuL2FyY2gveDg2
L2luY2x1ZGUvYXNtL2lvbW11LmgNCj4+IEBAIC03Miw3ICs3Miw2IEBAIHN0cnVjdCBhcmNoX2lv
bW11DQo+PiAgDQo+PiAgZXh0ZXJuIHN0cnVjdCBpb21tdV9vcHMgaW9tbXVfb3BzOw0KPj4gIA0K
Pj4gLSNpZmRlZiBOREVCVUcNCj4+ICAjIGluY2x1ZGUgPGFzbS9hbHRlcm5hdGl2ZS5oPg0KPj4g
ICMgZGVmaW5lIGlvbW11X2NhbGwob3BzLCBmbiwgYXJncy4uLikgKHsgICAgICBcDQo+PiAgICAg
ICh2b2lkKShvcHMpOyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFwNCj4+IEBAIC04Myw3
ICs4Miw2IEBAIGV4dGVybiBzdHJ1Y3QgaW9tbXVfb3BzIGlvbW11X29wczsNCj4+ICAgICAgKHZv
aWQpKG9wcyk7ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXA0KPj4gICAgICBhbHRlcm5h
dGl2ZV92Y2FsbChpb21tdV9vcHMuZm4sICMjIGFyZ3MpOyBcDQo+PiAgfSkNCj4+IC0jZW5kaWYN
Cj4+ICANCj4+ICBzdGF0aWMgaW5saW5lIGNvbnN0IHN0cnVjdCBpb21tdV9vcHMgKmlvbW11X2dl
dF9vcHModm9pZCkNCj4+ICB7DQo+PiBAQCAtMTA2LDcgKzEwNCw3IEBAIGludCBpb21tdV9zZXR1
cF9ocGV0X21zaShzdHJ1Y3QgbXNpX2Rlc2MgKik7DQo+PiAgc3RhdGljIGlubGluZSBpbnQgaW9t
bXVfYWRqdXN0X2lycV9hZmZpbml0aWVzKHZvaWQpDQo+PiAgew0KPj4gICAgICByZXR1cm4gaW9t
bXVfb3BzLmFkanVzdF9pcnFfYWZmaW5pdGllcw0KPj4gLSAgICAgICAgICAgPyBpb21tdV9vcHMu
YWRqdXN0X2lycV9hZmZpbml0aWVzKCkNCj4+ICsgICAgICAgICAgID8gaW9tbXVfY2FsbChpb21t
dV9vcHMsIGFkanVzdF9pcnFfYWZmaW5pdGllcykNCj4gV2hpbGUgdGhpcyAoYW5kIG90aGVyIGlu
c3RhbmNlcyBiZWxvdykgaXMgeDg2LW9ubHkgY29kZSwgd2hlcmUgLSB3aXRoDQo+IHRoZSByZW1v
dmFsIG9mIHRoZSAjaWZkZWYgYWJvdmUgLSB3ZSBub3cga25vdyB0aGUgZmlyc3QgYXJndW1lbnQg
aXMNCj4gYWx3YXlzIGlnbm9yZWQsIEkgdGhpbmsgaXQgd291bGQgc3RpbGwgYmV0dGVyIGJlIG9m
IHRoZSBjb3JyZWN0IHR5cGUNCj4gKCZpb21tdV9vcHMpLiBQZXJoYXBzIHRoZSAiKHZvaWQpKG9w
cykiIGluIHRoZSBtYWNybyBkZWZpbml0aW9ucyB3b3VsZA0KPiBiZXR0ZXIgYmVjb21lICJBU1NF
UlQoKG9wcykgPT0gJmlvbW11X29wcykiLCB3aGljaCB3b3VsZCBjaGVjayBib3RoDQo+IHR5cGUg
KGNvbXBpbGUgdGltZSkgYW5kIHZhbHVlIChydW50aW1lKS4NCg0KSSdtIGhhcHB5IHRvIGZvbGQg
dGhhdCBjaGFuZ2UgaWYgeW91IHdhbnQuwqAgSXQgb3VnaHQgdG8gb3B0aW1pc2Ugb3V0DQpjb21w
bGV0ZWx5IGZvciBiZWluZw0KDQo+DQo+PiAtLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9p
b21tdS5jDQo+PiArKysgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9pb21tdS5jDQo+PiBAQCAt
NTQwLDcgKzU0MCw3IEBAIGludCBfX2luaXQgaW9tbXVfc2V0dXAodm9pZCkNCj4+ICBpbnQgaW9t
bXVfc3VzcGVuZCgpDQo+PiAgew0KPj4gICAgICBpZiAoIGlvbW11X2VuYWJsZWQgKQ0KPj4gLSAg
ICAgICAgcmV0dXJuIGlvbW11X2dldF9vcHMoKS0+c3VzcGVuZCgpOw0KPj4gKyAgICAgICAgcmV0
dXJuIGlvbW11X2NhbGwoaW9tbXVfZ2V0X29wcygpLCBzdXNwZW5kKTsNCj4gVGhpcyB1c2Ugb2Yg
aW9tbXVfZ2V0X29wcygpIGluIHN1Y2ggY29uc3RydWN0cyBpcyBhIHBhdHRlcm4gd2UgZGlkbid0
DQo+IGhhdmUgc28gZmFyLiBQZXJoYXBzIGl0IGp1c3QgbG9va3MgYm9ndXMsIGFuZCBhbGwgaXMg
ZmluZSBpbiByZWFsaXR5DQo+IChhcGFydCBmcm9tIHRoZSB3aG9sZSBpZGVhIGJlaW5nIHdyb25n
IGZvciBBcm0sIG9yIHJlYWxseSBhbnkNCj4gZW52aXJvbm1lbnQgd2hlcmUgbXVsdGlwbGUgZGlz
c2ltaWxhciBJT01NVXMgbWF5IGJlIGluIHVzZSkuIE9yIHdhaXQsDQo+IHRoZXJlIGFyZSBwcmUt
ZXhpc3RpbmcgY2FzZXMgKGp1c3Qgbm90IGltbWVkaWF0ZWx5IHZpc2libGUgd2hlbg0KPiBncmVw
LWluZyBmb3IgImlvbW11X3Y/Y2FsbCIpIGluIGlvbW11X2dldF9yZXNlcnZlZF9kZXZpY2VfbWVt
b3J5KCkgYW5kDQo+IGlvbW11X3NldHVwX2hwZXRfbXNpKCkuDQoNCkkgdGhpbmsgdGhpcyBtZWFu
cyB5b3VyIGhhcHB5KGlzaCkgd2l0aCB0aGUgY2hhbmdlPw0KDQpJIGFncmVlIHRoYXQgdGhpcyBp
cyBub25zZW5zZSBvbiBBUk0sIGJ1dCB0aGUgY29kZXBhdGggaXNuJ3QgdXNlZCB5ZXQNCmFuZCBz
b21lb25lJ3MgZ29pbmcgdG8gaGF2ZSB0byByZWNvbmNpbGUgdGhlIGNvbmZsaWN0aW5nIHZpZXdz
Lg0KDQo+PiAtLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC92dGQvaW9tbXUuYw0KPj4gKysr
IGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL2lvbW11LmMNCj4+IEBAIC01Niw3ICs1Niw2
IEBAIGJvb2wgX19yZWFkX21vc3RseSBpb21tdV9zbm9vcCA9IHRydWU7DQo+PiAgDQo+PiAgc3Rh
dGljIHVuc2lnbmVkIGludCBfX3JlYWRfbW9zdGx5IG5yX2lvbW11czsNCj4+ICANCj4+IC1zdGF0
aWMgc3RydWN0IGlvbW11X29wcyB2dGRfb3BzOw0KPj4gIHN0YXRpYyBzdHJ1Y3QgdGFza2xldCB2
dGRfZmF1bHRfdGFza2xldDsNCj4+ICANCj4+ICBzdGF0aWMgaW50IGNmX2NoZWNrIHNldHVwX2h3
ZG9tX2RldmljZSh1OCBkZXZmbiwgc3RydWN0IHBjaV9kZXYgKik7DQo+PiBAQCAtMjc5NCw3ICsy
NzkzLDcgQEAgc3RhdGljIGludCBfX2luaXQgY2ZfY2hlY2sgaW50ZWxfaW9tbXVfcXVhcmFudGlu
ZV9pbml0KHN0cnVjdCBkb21haW4gKmQpDQo+PiAgICAgIHJldHVybiByYzsNCj4+ICB9DQo+PiAg
DQo+PiAtc3RhdGljIHN0cnVjdCBpb21tdV9vcHMgX19pbml0ZGF0YSB2dGRfb3BzID0gew0KPj4g
K3N0YXRpYyBjb25zdCBzdHJ1Y3QgaW9tbXVfb3BzIF9faW5pdGNvbnN0X2NmX2Nsb2JiZXIgdnRk
X29wcyA9IHsNCj4gQWggeWVzLCB0aGUgY29udmVyc2lvbiB0byBjb25zdCAoYW5kIHRoZSBkcm9w
cGluZyBvZiB0aGUgZm9yd2FyZCBkZWNsKQ0KPiBjb3VsZCBoYXZlIGJlZW4gcGFydCBvZiAiVlQt
ZCAvIHg4NjogcmUtYXJyYW5nZSBjYWNoZSBzeW5jaW5nIi4NCj4NCj4gV2l0aCB0aGUgbWlzc2lu
ZyAmLXMgYWRkZWQgYW5kIHByZWZlcmFibHkgd2l0aCB0aGUgZGVzY3JpcHRpb24gYWRqdXN0ZWQN
Cj4gYSBsaXR0bGUNCj4gUmV2aWV3ZWQtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNv
bT4NCg0KVGhhbmtzLg0KDQp+QW5kcmV3DQoNCg0K


From xen-devel-bounces@lists.xenproject.org Tue Feb 22 10:56:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 10:56:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276653.472880 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMSqH-00017g-58; Tue, 22 Feb 2022 10:56:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276653.472880; Tue, 22 Feb 2022 10:56:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMSqH-00017Z-0k; Tue, 22 Feb 2022 10:56:25 +0000
Received: by outflank-mailman (input) for mailman id 276653;
 Tue, 22 Feb 2022 10:56:24 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=IN1Y=TF=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1nMSqG-00017R-7X
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 10:56:24 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id 128ca1e9-93ce-11ec-8eb8-a37418f5ba1a;
 Tue, 22 Feb 2022 11:56:22 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0F465106F;
 Tue, 22 Feb 2022 02:56:22 -0800 (PST)
Received: from e123311-lin.arm.com (unknown [10.57.3.116])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E8F113F70D;
 Tue, 22 Feb 2022 02:56:20 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 128ca1e9-93ce-11ec-8eb8-a37418f5ba1a
From: Michal Orzel <michal.orzel@arm.com>
To: xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH v2 0/2] Rename psr_mode_is_{32bit/user} to regs_mode_is_{32bit/user}
Date: Tue, 22 Feb 2022 11:56:11 +0100
Message-Id: <20220222105613.20668-1-michal.orzel@arm.com>
X-Mailer: git-send-email 2.29.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

The request to rename psr_mode_is_32bit to regs_mode_is_32bit was make during
a discussion [1]. Because psr_mode_is_user shares the same prototype, we should
rename it as well to keep the naming consistent.

[1] https://marc.info/?l=xen-devel&m=156457538423787&w=2

Michal Orzel (2):
  xen/arm: Rename psr_mode_is_32bit to regs_mode_is_32bit
  xen/arm: Rename psr_mode_is_user to regs_mode_is_user

 xen/arch/arm/arm64/vsysreg.c    |  4 ++--
 xen/arch/arm/include/asm/regs.h |  6 ++---
 xen/arch/arm/traps.c            | 42 ++++++++++++++++-----------------
 xen/arch/arm/vcpreg.c           |  4 ++--
 xen/arch/arm/vtimer.c           |  2 +-
 5 files changed, 29 insertions(+), 29 deletions(-)

-- 
2.29.0



From xen-devel-bounces@lists.xenproject.org Tue Feb 22 10:56:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 10:56:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276654.472890 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMSqJ-0001O6-CN; Tue, 22 Feb 2022 10:56:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276654.472890; Tue, 22 Feb 2022 10:56:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMSqJ-0001Nz-8r; Tue, 22 Feb 2022 10:56:27 +0000
Received: by outflank-mailman (input) for mailman id 276654;
 Tue, 22 Feb 2022 10:56:25 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=IN1Y=TF=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1nMSqH-00017i-G2
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 10:56:25 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 1363d55e-93ce-11ec-8539-5f4723681683;
 Tue, 22 Feb 2022 11:56:24 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7081D139F;
 Tue, 22 Feb 2022 02:56:23 -0800 (PST)
Received: from e123311-lin.arm.com (unknown [10.57.3.116])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 585163F70D;
 Tue, 22 Feb 2022 02:56:22 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1363d55e-93ce-11ec-8539-5f4723681683
From: Michal Orzel <michal.orzel@arm.com>
To: xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH v2 1/2] xen/arm: Rename psr_mode_is_32bit to regs_mode_is_32bit
Date: Tue, 22 Feb 2022 11:56:12 +0100
Message-Id: <20220222105613.20668-2-michal.orzel@arm.com>
X-Mailer: git-send-email 2.29.0
In-Reply-To: <20220222105613.20668-1-michal.orzel@arm.com>
References: <20220222105613.20668-1-michal.orzel@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Commit aa2f5aefa8de ("xen/arm: Rework psr_mode_is_32bit()") modified
the function to take a struct cpu_user_regs instead of psr.
Perform renaming of psr_mode_is_32bit to regs_mode_is_32bit to reflect
that change.

Signed-off-by: Michal Orzel <michal.orzel@arm.com>
---
This change was requested following up a discussion:
https://marc.info/?l=xen-devel&m=156457538423787&w=2

Changes since v1:
-modify commit message
---
 xen/arch/arm/include/asm/regs.h |  2 +-
 xen/arch/arm/traps.c            | 30 +++++++++++++++---------------
 2 files changed, 16 insertions(+), 16 deletions(-)

diff --git a/xen/arch/arm/include/asm/regs.h b/xen/arch/arm/include/asm/regs.h
index ec091a28a2..04e821138a 100644
--- a/xen/arch/arm/include/asm/regs.h
+++ b/xen/arch/arm/include/asm/regs.h
@@ -13,7 +13,7 @@
 
 #define psr_mode(psr,m) (((psr) & PSR_MODE_MASK) == m)
 
-static inline bool psr_mode_is_32bit(const struct cpu_user_regs *regs)
+static inline bool regs_mode_is_32bit(const struct cpu_user_regs *regs)
 {
 #ifdef CONFIG_ARM_32
     return true;
diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c
index 9339d12f58..0db8e42d65 100644
--- a/xen/arch/arm/traps.c
+++ b/xen/arch/arm/traps.c
@@ -896,7 +896,7 @@ static void _show_registers(const struct cpu_user_regs *regs,
 
     if ( guest_mode )
     {
-        if ( psr_mode_is_32bit(regs) )
+        if ( regs_mode_is_32bit(regs) )
             show_registers_32(regs, ctxt, guest_mode, v);
 #ifdef CONFIG_ARM_64
         else
@@ -1631,7 +1631,7 @@ int check_conditional_instr(struct cpu_user_regs *regs, const union hsr hsr)
     {
         unsigned long it;
 
-        BUG_ON( !psr_mode_is_32bit(regs) || !(cpsr & PSR_THUMB) );
+        BUG_ON( !regs_mode_is_32bit(regs) || !(cpsr & PSR_THUMB) );
 
         it = ( (cpsr >> (10-2)) & 0xfc) | ((cpsr >> 25) & 0x3 );
 
@@ -1656,7 +1656,7 @@ int check_conditional_instr(struct cpu_user_regs *regs, const union hsr hsr)
 void advance_pc(struct cpu_user_regs *regs, const union hsr hsr)
 {
     register_t itbits, cond, cpsr = regs->cpsr;
-    bool is_thumb = psr_mode_is_32bit(regs) && (cpsr & PSR_THUMB);
+    bool is_thumb = regs_mode_is_32bit(regs) && (cpsr & PSR_THUMB);
 
     if ( is_thumb && (cpsr & PSR_IT_MASK) )
     {
@@ -2098,37 +2098,37 @@ void do_trap_guest_sync(struct cpu_user_regs *regs)
         advance_pc(regs, hsr);
         break;
     case HSR_EC_CP15_32:
-        GUEST_BUG_ON(!psr_mode_is_32bit(regs));
+        GUEST_BUG_ON(!regs_mode_is_32bit(regs));
         perfc_incr(trap_cp15_32);
         do_cp15_32(regs, hsr);
         break;
     case HSR_EC_CP15_64:
-        GUEST_BUG_ON(!psr_mode_is_32bit(regs));
+        GUEST_BUG_ON(!regs_mode_is_32bit(regs));
         perfc_incr(trap_cp15_64);
         do_cp15_64(regs, hsr);
         break;
     case HSR_EC_CP14_32:
-        GUEST_BUG_ON(!psr_mode_is_32bit(regs));
+        GUEST_BUG_ON(!regs_mode_is_32bit(regs));
         perfc_incr(trap_cp14_32);
         do_cp14_32(regs, hsr);
         break;
     case HSR_EC_CP14_64:
-        GUEST_BUG_ON(!psr_mode_is_32bit(regs));
+        GUEST_BUG_ON(!regs_mode_is_32bit(regs));
         perfc_incr(trap_cp14_64);
         do_cp14_64(regs, hsr);
         break;
     case HSR_EC_CP14_DBG:
-        GUEST_BUG_ON(!psr_mode_is_32bit(regs));
+        GUEST_BUG_ON(!regs_mode_is_32bit(regs));
         perfc_incr(trap_cp14_dbg);
         do_cp14_dbg(regs, hsr);
         break;
     case HSR_EC_CP10:
-        GUEST_BUG_ON(!psr_mode_is_32bit(regs));
+        GUEST_BUG_ON(!regs_mode_is_32bit(regs));
         perfc_incr(trap_cp10);
         do_cp10(regs, hsr);
         break;
     case HSR_EC_CP:
-        GUEST_BUG_ON(!psr_mode_is_32bit(regs));
+        GUEST_BUG_ON(!regs_mode_is_32bit(regs));
         perfc_incr(trap_cp);
         do_cp(regs, hsr);
         break;
@@ -2139,7 +2139,7 @@ void do_trap_guest_sync(struct cpu_user_regs *regs)
          * ARMv7 (DDI 0406C.b): B1.14.8
          * ARMv8 (DDI 0487A.d): D1-1501 Table D1-44
          */
-        GUEST_BUG_ON(!psr_mode_is_32bit(regs));
+        GUEST_BUG_ON(!regs_mode_is_32bit(regs));
         perfc_incr(trap_smc32);
         do_trap_smc(regs, hsr);
         break;
@@ -2147,7 +2147,7 @@ void do_trap_guest_sync(struct cpu_user_regs *regs)
     {
         register_t nr;
 
-        GUEST_BUG_ON(!psr_mode_is_32bit(regs));
+        GUEST_BUG_ON(!regs_mode_is_32bit(regs));
         perfc_incr(trap_hvc32);
 #ifndef NDEBUG
         if ( (hsr.iss & 0xff00) == 0xff00 )
@@ -2162,7 +2162,7 @@ void do_trap_guest_sync(struct cpu_user_regs *regs)
     }
 #ifdef CONFIG_ARM_64
     case HSR_EC_HVC64:
-        GUEST_BUG_ON(psr_mode_is_32bit(regs));
+        GUEST_BUG_ON(regs_mode_is_32bit(regs));
         perfc_incr(trap_hvc64);
 #ifndef NDEBUG
         if ( (hsr.iss & 0xff00) == 0xff00 )
@@ -2178,12 +2178,12 @@ void do_trap_guest_sync(struct cpu_user_regs *regs)
          *
          * ARMv8 (DDI 0487A.d): D1-1501 Table D1-44
          */
-        GUEST_BUG_ON(psr_mode_is_32bit(regs));
+        GUEST_BUG_ON(regs_mode_is_32bit(regs));
         perfc_incr(trap_smc64);
         do_trap_smc(regs, hsr);
         break;
     case HSR_EC_SYSREG:
-        GUEST_BUG_ON(psr_mode_is_32bit(regs));
+        GUEST_BUG_ON(regs_mode_is_32bit(regs));
         perfc_incr(trap_sysreg);
         do_sysreg(regs, hsr);
         break;
-- 
2.29.0



From xen-devel-bounces@lists.xenproject.org Tue Feb 22 10:56:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 10:56:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276655.472902 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMSqK-0001fT-M3; Tue, 22 Feb 2022 10:56:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276655.472902; Tue, 22 Feb 2022 10:56:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMSqK-0001fG-H5; Tue, 22 Feb 2022 10:56:28 +0000
Received: by outflank-mailman (input) for mailman id 276655;
 Tue, 22 Feb 2022 10:56:27 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=IN1Y=TF=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1nMSqJ-00017R-2e
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 10:56:27 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id 1446d20e-93ce-11ec-8eb8-a37418f5ba1a;
 Tue, 22 Feb 2022 11:56:25 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 03C5B106F;
 Tue, 22 Feb 2022 02:56:25 -0800 (PST)
Received: from e123311-lin.arm.com (unknown [10.57.3.116])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BA8DE3F70D;
 Tue, 22 Feb 2022 02:56:23 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1446d20e-93ce-11ec-8eb8-a37418f5ba1a
From: Michal Orzel <michal.orzel@arm.com>
To: xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH v2 2/2] xen/arm: Rename psr_mode_is_user to regs_mode_is_user
Date: Tue, 22 Feb 2022 11:56:13 +0100
Message-Id: <20220222105613.20668-3-michal.orzel@arm.com>
X-Mailer: git-send-email 2.29.0
In-Reply-To: <20220222105613.20668-1-michal.orzel@arm.com>
References: <20220222105613.20668-1-michal.orzel@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Perform renaming of psr_mode_is_user to regs_mode_is_user in order to
reflect that it takes struct cpu_user_regs as a parameter and not
psr.

Signed-off-by: Michal Orzel <michal.orzel@arm.com>
---
Changes since v1:
-new patch
---
 xen/arch/arm/arm64/vsysreg.c    |  4 ++--
 xen/arch/arm/include/asm/regs.h |  4 ++--
 xen/arch/arm/traps.c            | 12 ++++++------
 xen/arch/arm/vcpreg.c           |  4 ++--
 xen/arch/arm/vtimer.c           |  2 +-
 5 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/xen/arch/arm/arm64/vsysreg.c b/xen/arch/arm/arm64/vsysreg.c
index cf55544081..758750983c 100644
--- a/xen/arch/arm/arm64/vsysreg.c
+++ b/xen/arch/arm/arm64/vsysreg.c
@@ -91,7 +91,7 @@ void do_sysreg(struct cpu_user_regs *regs,
      * ARMv8 (DDI 0487A.d): D7.2.1
      */
     case HSR_SYSREG_ACTLR_EL1:
-        if ( psr_mode_is_user(regs) )
+        if ( regs_mode_is_user(regs) )
             return inject_undef_exception(regs, hsr);
         if ( hsr.sysreg.read )
             set_user_reg(regs, regidx, v->arch.actlr);
@@ -206,7 +206,7 @@ void do_sysreg(struct cpu_user_regs *regs,
         return handle_raz_wi(regs, regidx, hsr.sysreg.read, hsr, 1);
     case HSR_SYSREG_PMUSERENR_EL0:
         /* RO at EL0. RAZ/WI at EL1 */
-        if ( psr_mode_is_user(regs) )
+        if ( regs_mode_is_user(regs) )
             return handle_ro_raz(regs, regidx, hsr.sysreg.read, hsr, 0);
         else
             return handle_raz_wi(regs, regidx, hsr.sysreg.read, hsr, 1);
diff --git a/xen/arch/arm/include/asm/regs.h b/xen/arch/arm/include/asm/regs.h
index 04e821138a..794721a103 100644
--- a/xen/arch/arm/include/asm/regs.h
+++ b/xen/arch/arm/include/asm/regs.h
@@ -33,7 +33,7 @@ static inline bool regs_mode_is_32bit(const struct cpu_user_regs *regs)
 
 #ifdef CONFIG_ARM_32
 #define hyp_mode(r)     psr_mode((r)->cpsr,PSR_MODE_HYP)
-#define psr_mode_is_user(r) usr_mode(r)
+#define regs_mode_is_user(r) usr_mode(r)
 #else
 #define hyp_mode(r)     (psr_mode((r)->cpsr,PSR_MODE_EL2h) || \
                          psr_mode((r)->cpsr,PSR_MODE_EL2t))
@@ -42,7 +42,7 @@ static inline bool regs_mode_is_32bit(const struct cpu_user_regs *regs)
  * Trap may have been taken from EL0, which might be in AArch32 usr
  * mode, or in AArch64 mode (PSR_MODE_EL0t).
  */
-#define psr_mode_is_user(r) \
+#define regs_mode_is_user(r) \
     (psr_mode((r)->cpsr,PSR_MODE_EL0t) || usr_mode(r))
 #endif
 
diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c
index 0db8e42d65..7a1b679b8c 100644
--- a/xen/arch/arm/traps.c
+++ b/xen/arch/arm/traps.c
@@ -561,7 +561,7 @@ static void inject_abt64_exception(struct cpu_user_regs *regs,
         .len = instr_len,
     };
 
-    if ( psr_mode_is_user(regs) )
+    if ( regs_mode_is_user(regs) )
         esr.ec = prefetch
             ? HSR_EC_INSTR_ABORT_LOWER_EL : HSR_EC_DATA_ABORT_LOWER_EL;
     else
@@ -1193,7 +1193,7 @@ void vcpu_show_execution_state(struct vcpu *v)
     vcpu_pause(v); /* acceptably dangerous */
 
     vcpu_show_registers(v);
-    if ( !psr_mode_is_user(&v->arch.cpu_info->guest_cpu_user_regs) )
+    if ( !regs_mode_is_user(&v->arch.cpu_info->guest_cpu_user_regs) )
         show_guest_stack(v, &v->arch.cpu_info->guest_cpu_user_regs);
 
     vcpu_unpause(v);
@@ -1560,7 +1560,7 @@ enum mc_disposition arch_do_multicall_call(struct mc_state *state)
                          multi->args[2], multi->args[3],
                          multi->args[4]);
 
-    return likely(!psr_mode_is_user(guest_cpu_user_regs()))
+    return likely(!regs_mode_is_user(guest_cpu_user_regs()))
            ? mc_continue : mc_preempt;
 }
 
@@ -1699,7 +1699,7 @@ void handle_raz_wi(struct cpu_user_regs *regs,
 {
     ASSERT((min_el == 0) || (min_el == 1));
 
-    if ( min_el > 0 && psr_mode_is_user(regs) )
+    if ( min_el > 0 && regs_mode_is_user(regs) )
         return inject_undef_exception(regs, hsr);
 
     if ( read )
@@ -1718,7 +1718,7 @@ void handle_wo_wi(struct cpu_user_regs *regs,
 {
     ASSERT((min_el == 0) || (min_el == 1));
 
-    if ( min_el > 0 && psr_mode_is_user(regs) )
+    if ( min_el > 0 && regs_mode_is_user(regs) )
         return inject_undef_exception(regs, hsr);
 
     if ( read )
@@ -1738,7 +1738,7 @@ void handle_ro_read_val(struct cpu_user_regs *regs,
 {
     ASSERT((min_el == 0) || (min_el == 1));
 
-    if ( min_el > 0 && psr_mode_is_user(regs) )
+    if ( min_el > 0 && regs_mode_is_user(regs) )
         return inject_undef_exception(regs, hsr);
 
     if ( !read )
diff --git a/xen/arch/arm/vcpreg.c b/xen/arch/arm/vcpreg.c
index dfc18d12ff..b5fbbe1cb8 100644
--- a/xen/arch/arm/vcpreg.c
+++ b/xen/arch/arm/vcpreg.c
@@ -224,7 +224,7 @@ void do_cp15_32(struct cpu_user_regs *regs, const union hsr hsr)
      * ARMv8 (DDI 0487A.d): G6.2.1
      */
     case HSR_CPREG32(ACTLR):
-        if ( psr_mode_is_user(regs) )
+        if ( regs_mode_is_user(regs) )
             return inject_undef_exception(regs, hsr);
         if ( cp32.read )
             set_user_reg(regs, regidx, v->arch.actlr);
@@ -296,7 +296,7 @@ void do_cp15_32(struct cpu_user_regs *regs, const union hsr hsr)
      */
     case HSR_CPREG32(PMUSERENR):
         /* RO at EL0. RAZ/WI at EL1 */
-        if ( psr_mode_is_user(regs) )
+        if ( regs_mode_is_user(regs) )
             return handle_ro_raz(regs, regidx, cp32.read, hsr, 0);
         else
             return handle_raz_wi(regs, regidx, cp32.read, hsr, 1);
diff --git a/xen/arch/arm/vtimer.c b/xen/arch/arm/vtimer.c
index 0196951af4..5bb5970f58 100644
--- a/xen/arch/arm/vtimer.c
+++ b/xen/arch/arm/vtimer.c
@@ -36,7 +36,7 @@
  * CNTKCTL_EL1_ bit name which gates user access
  */
 #define ACCESS_ALLOWED(regs, user_gate) \
-    ( !psr_mode_is_user(regs) || \
+    ( !regs_mode_is_user(regs) || \
       (READ_SYSREG(CNTKCTL_EL1) & CNTKCTL_EL1_##user_gate) )
 
 static void phys_timer_expired(void *data)
-- 
2.29.0



From xen-devel-bounces@lists.xenproject.org Tue Feb 22 11:02:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 11:02:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276674.472912 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMSvp-0003iq-7g; Tue, 22 Feb 2022 11:02:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276674.472912; Tue, 22 Feb 2022 11:02:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMSvp-0003ij-4l; Tue, 22 Feb 2022 11:02:09 +0000
Received: by outflank-mailman (input) for mailman id 276674;
 Tue, 22 Feb 2022 11:02:08 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Woib=TF=citrix.com=prvs=045a4fa17=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nMSvo-0003id-KI
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 11:02:08 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id de63a4ce-93ce-11ec-8eb8-a37418f5ba1a;
 Tue, 22 Feb 2022 12:02:06 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: de63a4ce-93ce-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645527726;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=kniru7UUq5sbp91+M9o0hzmiMH/8Lnx9Ms8q/C2jHjI=;
  b=PCdh7I0ebkIoQPme5baoCZW1E4Ozze6FJrykGnsQpA72RSEmf2GmP5kp
   JmP8yFo1gwcH6NNRf+HXHqXgP4Q97YEiwYrViI7cnxZti6aIzTXKV9RdA
   sOt7EAo9Zpp8dN/j6tPqc9pjU2q/G2Orho+n5fYUVhek+Ty1bkMozGvQ1
   k=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 66960173
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:3XDAaqrNupuwWC0cUSQXmLroRlZeBmIKZRIvgKrLsJaIsI4StFCzt
 garIBmGbKyOZWX9e9xzaoqw8B9XvceEy9VjTldp+3swRHgVpJuZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlVEliefQAOCU5NfsYkidfyc9IMsaoU8ly75RbrJA24DjWVvX4
 4mq+aUzBXf+s9JKGjNMg068gEsHUMTa4Fv0aXRnOJinFHeH/5UkJMp3yZOZdhMUcaENdgKOf
 M7RzanRw4/s10xF5uVJMFrMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKv+Zvrgc91Zk
 b1wWZKMpQgBO7DXw9ZaCh5jSjB8Hv1l/4XfHWiYmJnGp6HGWyOEL/RGCUg3OcsT+/ptAHEI/
 vsdQNwPRknd3aTsmuv9E7QywJR4RCXoFNp3VnVI5DfVF/s5B7vERL3H/4Rw1zYsnMFeW/3ZY
 qL1bBIxMkWeO0QQYT/7DroArLyGiXjZIwRKi27Oh6kTw2Hhwzxuhe2F3N39JYXRGJQ9clyjj
 nLL+SH1Dw8XMPSbyCGZ6TS8i+nXhyT5VYkOUrqi+ZZCn1m71mEVThoMWjOTo/O0l0q/UNJ3M
 FEP92wlqq1ayaCwZoCjBVvi+ifC50NCHYoLewEn1O2T4q/J+F2rQTEDdWdQav92l8gMXQA68
 XbcyrsFGgdTmLGSTHuc8JKdojWzJTUZIAc+WMMUcecWy4K9+d9u13ojWv4mSffo1YOtRVkc1
 hjX9HBWulkFsSIcO0xXF3jjiinkmJXGRxVdCu7/DjP8tVMRiGJIiuWVBbnnARRocd7xorqp5
 iFsdy2iAAYmV8rleMulGrhlIV1Rz6zZWAAweHY2d3Xbyxyj+mS4Yadb6yxkKUFiP64sIGG1P
 RON6F4MvsMKZBNGiJObharrUKzGKoC6SLzYug38NIISMvCdiifdlM2RWaJg9z+0yxV9+U3OE
 ZyabdytHR4n5VdPl1KLqxMm+eZznEgWnDqLLbiilkjP+efONRa9FOZeWHPTP79R0U9xiFiMm
 zqpH5DRkEs3vSyXSnS/zLP/2nhQcyBgXMiu85Y/myzqClMOJVzNwsT5mNsJU4dkg75UhqHP+
 HS8UVVf013xmTvMLgDiV5ypQOiHsUpXxZ7jARERAA==
IronPort-HdrOrdr: A9a23:A1PX16/MnZ7Eu+i/2SBuk+F2db1zdoMgy1knxilNoENuHfBwxv
 rDoB1E73LJYW4qKQwdcdDpAtjkfZtFnaQFrrX5To3SIDUO31HYYr2KjLGSjwEIfheRygcz79
 YYT0ETMqySMbE+t7eB3ODaKadg/DDkytHRuQ629R4EJmsKC52IrT0JcTpzencGHzWubqBJcK
 Z0k/A3wQZIDk5nCfhTaEN1PdTrlpnurtbLcBQGDxko5E2lljWz8oP3FBCew1M3Ty5P6a1Kyx
 mEryXJooGY992rwB7V0GHeq75MnsH699dFDMuQzuAINzTXjBqybogJYczAgNl1mpDs1L8Zqq
 iJn/4SBbU115oXRBDynfLZ4Xik7N/p0Q669bbXuwq6nSWzfkNENyMIv/MmTvKe0Tt7gDg06t
 M644rS3aAnfC/ojWDz4cPFWAptkVfxqX0+kfQLh3gaSocGbqRNxLZvt3+9Pa1wVR4S0rpXWN
 WGzfuskMp+YBefdTTUr2NvyNujUjA6GQqHWFELvoiQ3yJNlH50wkMEzIhH901wua4VWt1B/a
 DJI65onLZBQosfar98Hv4IRY+yBnbWSRzBPWqOKRDsFb0BOXjKt5nriY9Frt2CadgN1t8/iZ
 7BWFRXuSo7fF/vE9SH2NlR/hXEUAyGLELQIwFllu9EU5HHNcjW2He4OSMTeuOb0oAiPvE=
X-IronPort-AV: E=Sophos;i="5.88,387,1635220800"; 
   d="scan'208";a="66960173"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=fSI3nZYTiQeYs9Rifchpm5/IC8B3fG6bp1zkKEyd/3CJ+uOvoC8J27Ftkze7kvjXufIipmbuqL9IoxoB6NIWZ/OvyuiulOepjCtQLzGiRA3ey5Pm82pV9kCSS1gDZhCdtsWiNKhkCNX02oyGOSqGQ0zDxi9tyOXJoc1+50nDAAmz3nt+HRZpwz+5euPO/f46ntZCZvzXP/PnzGNexoaUy5ha/k51JQxuHvXOPGnHpoaqQbWU+TQsoDp+c/Gs36DL2qKo5YR5466q+00F0qLrXKa+TruEknCZQb0fLVrEGa7BQ2abPGf9bnFQXjukY4/OpFcLnc+okPNJ9K604AFyTg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=kniru7UUq5sbp91+M9o0hzmiMH/8Lnx9Ms8q/C2jHjI=;
 b=PZ+sa4LFKQb2z3nXeofuZ/vcnK0g/KtQWUQ6Qt5Bmk8lqUNOj5bK/k3QhN2Z5wcg8rzbaiKQmaCm722nrbtInRa0oLvZ1ZE7bIbiDYvwn+MiS5XCXGegZUsdIns15Drecu4V95HxnFpp+CnC/chP0uPsutK5wjBseBNCvLsP4wEAqzYXDgY+y57H7baW5ltrcnZSO07GMQwxIjDuQtRKsnQvAXrNQ2KybL2+KyOE6g6UlmzAWwrlvKWSheOjHkKMGq76mBY/4NzOop5Su308chofixt9kQs191cfa3alGzHbjsJdxfbi6oWVlR0DC/mo8y2qBRsWO373GI9WMOLOtA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=kniru7UUq5sbp91+M9o0hzmiMH/8Lnx9Ms8q/C2jHjI=;
 b=k7K1TivZFxTFFTja2p3P8AibUP8FNp72c8i2wx9h5yGrQExQj7e+yOXHO/fKu5CMBfDEBagJ3oWqBKONxRLoRKnCxs1eJUEKar/BLx5/tP+aCE5iWDIHjutfNVZt/E0U7VnH/DJaATUZk7WMQIFUKG6sF1f3cdJI1CnXda/PKts=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>, Xen-devel
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2.1 8/7] x86/IOMMU: Use altcall, and
 __initconst_cf_clobber
Thread-Topic: [PATCH v2.1 8/7] x86/IOMMU: Use altcall, and
 __initconst_cf_clobber
Thread-Index: AQHYJ011tWngdwKc2UG3RuxDqKou56yfTukAgAAXlACAAAIiAA==
Date: Tue, 22 Feb 2022 11:02:01 +0000
Message-ID: <61efbf17-b07e-d513-7430-d0549e1384d7@citrix.com>
References: <20220214125632.24563-1-andrew.cooper3@citrix.com>
 <20220221180356.13527-1-andrew.cooper3@citrix.com>
 <0c253fda-c5f6-b7ea-df6c-8b43b86c6a59@suse.com>
 <9e442a8d-ef71-3776-e655-8c8a226af706@citrix.com>
In-Reply-To: <9e442a8d-ef71-3776-e655-8c8a226af706@citrix.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 67c02972-56b4-4b11-e6f4-08d9f5f2c092
x-ms-traffictypediagnostic: DM5PR03MB2988:EE_
x-microsoft-antispam-prvs: <DM5PR03MB2988C58341602FBB62539AD5BA3B9@DM5PR03MB2988.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: Drw52C8CGp9B2uJGXdOKZsZvkkhGEx5fgNxmtneUcXiy28o6teuGsd6sPjLBYkCPUBQ2JdSt7yQ8cKNSDnazI5Xj+qx/suFs82Uaz9rNTU4E9C2nlydabGBJtMLCWy3H7dCUanNOvjetgH1QZfKzyL4dJ+9ep5TVbZmKrGxh8rZ/ENceIuO+fGsAaOI4JVEGfSWyaJ+CXj860auzvsiRuTRlI2jUmm3gsLIN7QYbscoSd4jh7ekoF7YREQAos876KzuEAm+Iu8tHFgrp0voVnWNaq2Jv8RqBxOzRm1kjmmBxWSiUy5x2yr/LVa8XETtGEKFBzTr3/MyLkwQtXWVpGTyJzgPE9TTBN13Po7iZlIFSDOSSqEPmCpKSMLYHXcsoNYbLW01NZRQILphfFvHiNmG2DY8JTZfRT0f4uf+MGHQqEhBHg9Rbd2ino3zNO2OZ4Mi4D1sRZK1rJY3SrKuvGbScgSZugkaaRlPP4rkHkixAEIWDuaooPCjxyM9aIkE8jnesmZc11lfnmbhHFK819d0eg36CrFF4byTFlyQ2JODwkjHLWHQmJRQLDz/beCRfWe5LbydK5XvAP3Q/jueG+bdHNAXEIlmPk8n5EmeW7zAZRbcHAW/px3jwQvKWOGuTwWVlgcu5AF9ivPgC7hxXlNU0hBHVhE0DbmMGjVcRnt3db444L1YPdo+jIFmIKXO7T8/OU1/2ZH4AjySUWam6cKcddn8gYED5Xycgmo6dUIciXZmCisJN5TUR9e/tLWmac9g7CPFLyzZCXSCH+SamFA==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6512007)(53546011)(36756003)(6506007)(508600001)(5660300002)(8936002)(38070700005)(38100700002)(82960400001)(2906002)(31686004)(66556008)(54906003)(66446008)(6486002)(4326008)(8676002)(71200400001)(2616005)(64756008)(91956017)(86362001)(122000001)(316002)(6916009)(31696002)(76116006)(66946007)(26005)(186003)(66476007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?ZUhvWXA1a0JDU0lUeVRYOXBCNUdaSjd0cE9hejBkMUVkNU1wbUVGeXVkUVoy?=
 =?utf-8?B?RzBKeHcrQUpIeThJSTlaZlRSeFJhL0IxRUFld3Q1NS9SOC9sWldHa1lkUU1h?=
 =?utf-8?B?QlQ1MHN3a2d1aUtGN0RXZko2Wk1IZ21ocUtrVHJkclU0WXlOdHUwdDZDVUh5?=
 =?utf-8?B?SFYxdXVYT2cxV1gyczhIN2dFaCs1L0JYSW5lZHdoQnQzcnB6dkpFTDRzb1hp?=
 =?utf-8?B?Sk5aMFRFclJ1aXg3RVRSMjN4c2k1VUE0WUJMWlRJNzAycC9DWDFaZlpBNDYw?=
 =?utf-8?B?S2hsTEZjUmM5OGhyZVhJd2p2Qm9CTjgwVi9YUHgxYm52Ukd0TmRrbFA2VnNl?=
 =?utf-8?B?dTFuNHg1MTlsNW1CRUtTdnNuZGVUZnRCZy81amtqNWJ2eVNLeXJqc2liUits?=
 =?utf-8?B?a1llUmt2MFVwTVR4bGVYK3lKdHZwK1hveGg3UW5FODhyQjdFTExrRE9VRDRo?=
 =?utf-8?B?TTNONGxucnR5NDM5T2dybnA1TE5VNE04bmlkZUIyckFFMlJ4M0o0aWlsU3BJ?=
 =?utf-8?B?YWYzdXROTHRweHh3U3VuQUJDK29mdEJ6dEJHbFhYa09ObjZIWXpPbWFzRlA5?=
 =?utf-8?B?djRDVnY5TXYybW9JV3NYdm8rS1JyWnFhUlE5cWZrT0tuYzFWa2pHMGFIMkhh?=
 =?utf-8?B?b2lubGEyTk13R3BQZUZrMXZGVGN5NjJ4eWZWd2EvY1hEQ1ozRGlma2pBQkVr?=
 =?utf-8?B?T1htc3RrbWlsaHhaK05wb2pCb3hSRW1vbGRKUE5BaU1pWWFvVFFvQ1QzZEpr?=
 =?utf-8?B?Zk1PWm9FQVA1MGIzeUFpRkg4dGUyOVlNRW0rRkovem82bVBOczJ0TllWOXJT?=
 =?utf-8?B?OVNraVQ0TCtCdlNzWmRBVTNKbCtabHhFNmN5N0h2UndTUFZCbjhUc1kzeGdB?=
 =?utf-8?B?ekd2OTIvZ0xoaG1XV3diN0VyUW9RMUxXY2FZQWw5aTFNbktvdUhKQWMrTlpu?=
 =?utf-8?B?SFgyU0ozTWRkaVNqYklXTnBKT1pyc1RuVTdHRGUzUExwSnc2OXpnUjRXbC82?=
 =?utf-8?B?UEVSSGcyaHFCMDBUMFNhYk01V0pscUVBdUNKWHgybGhYdVhoOTl3dCsxbHFz?=
 =?utf-8?B?eURqWjg4UkNoUCtwdG8vemdhWEE3NXpsM3dHVnRLd1lER0JBUUNESTlmcHo1?=
 =?utf-8?B?aTcwN2hrZWFlVXhUOStjK0xGZy9XcGFuSGlSK0FSREtLbGt2bWF6ektraTBO?=
 =?utf-8?B?WnU2cm1UeThKSUh5TzE1Z1NWNlFuTnNiZlZ5MTMzRHZ6bGtIOGpQK1hvZm9u?=
 =?utf-8?B?QjBiNXVvdXRMM1lvQ0ZKZ0Q2em4zQ2xPdkJPaU02cVFxUExiemhmYndLS0dN?=
 =?utf-8?B?dmhtbmMyTWVVWG1YZU5Fa2NranJNMHJiSWloUW9vejlpOFpuVXBEQXRoSDV3?=
 =?utf-8?B?OE5HMHBpZldsNFMvNzl1UW80NlUxWVBRcDRKTHAxZVQ3eWxNZHNPL0tsVVpK?=
 =?utf-8?B?YVk4d3ZydHo2bUZGUFU1cHhYOXRkdVNhc0pwdTR5OFJzc3F6Vlc5T1BvZTdU?=
 =?utf-8?B?czFCUDhRdXdVU1k3YklBSjZKV05tS0p2eG5VTFBTc0lPdTZOczkyQWZNOVh0?=
 =?utf-8?B?aTJMUS9adWlUTUZsK3crN3R5LzA4N256M0xOcEZzWGs5N0lRb0YvZ2VydWdx?=
 =?utf-8?B?UUxOdkxzdldXSXBNTGdKSGNSY25SK0JoekVIYkFaTXRCUkpZeWovOVBydFNm?=
 =?utf-8?B?TE9UMTFPcWZxa2lUMGtFVzkyWEJCcVRtZGMwZ0dlenpYTlZ0NXVweUJaVWNB?=
 =?utf-8?B?cUcyODFVaWd6UHpGSWlYR0VNdW1VbEs0aGxxNlR3bk1CenhaT2NiVUZUQUdR?=
 =?utf-8?B?OUZmRzl2clQ2V201NHZhTVIyNWVFampnejFxZGF3ei81Rnd6cEZJWmtBSnZ5?=
 =?utf-8?B?c01zOHd0dDE0SjJrL0ZyQmJ2SHR2WnJ5Z25Mc3pwNzA1WndGcnF1alBxNzVX?=
 =?utf-8?B?VXB2aFlib3JodGhyNU5tZDZjV2F2aUwyS1JzSlNnMzlxU3crQklNaWZhcm8z?=
 =?utf-8?B?QWJqS1V1YmVjSTBYOUFRWEJvM3UzV0lCWFU4dkUxRk1XZjZHbDJiY3RCaGp2?=
 =?utf-8?B?YSs3dkJLMHRtRTl6MnR5ZTBBOE8zZjNhNGNpRjhPeEZsRmZIS3pFUUxjNHUy?=
 =?utf-8?B?UWtONmxieGVUck5YeW1sTW5BelduQWxlRFVGNkhtWGd1cUl3c1JNL1RtdXFU?=
 =?utf-8?B?enBESWZTMXRlU015TDBZcWhZZGJheEpqZVFaVDN3UG85Sng4SFRNcEUxdTlU?=
 =?utf-8?B?UjV3SkRrSERwZ1BUODVCOW54UGFRPT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <AC9B7A6FD9C9FE459596A47EF90C3E54@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 67c02972-56b4-4b11-e6f4-08d9f5f2c092
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Feb 2022 11:02:01.0598
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ln/ASGgmzr98VXhBsEJwQmHkR3/tyzUBsFSPa2J/vO2n7byZML6TO6pBCClpTmoIw18KFDOLIZU+WPCQpNtchsj6nSx+/rTNiopR9K1R5xA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2988
X-OriginatorOrg: citrix.com

T24gMjIvMDIvMjAyMiAxMDo1NCwgQW5kcmV3IENvb3BlciB3cm90ZToNCj4gT24gMjIvMDIvMjAy
MiAwOToyOSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+PiBPbiAyMS4wMi4yMDIyIDE5OjAzLCBBbmRy
ZXcgQ29vcGVyIHdyb3RlOg0KPj4+IE1vc3QgSU9NTVUgaG9va3MgYXJlIGFscmVhZHkgYWx0Y2Fs
bCBmb3IgcGVyZm9ybWFuY2UgcmVhc29ucy4gIENvbnZlcnQgdGhlDQo+Pj4gcmVzdCBvZiB0aGVt
IHNvIHdlIGNhbiBoYXJkZW4gYWxsIHRoZSBob29rcyBpbiBDb250cm9sIEZsb3cgSW50ZWdyaXR5
DQo+Pj4gY29uZmlndXJhdGlvbnMuICBUaGlzIG5lY2Vzc2l0YXRlcyB0aGUgdXNlIG9mIGlvbW11
X3t2LH1jYWxsKCkgaW4gZGVidWcgYnVpbGRzDQo+Pj4gdG9vLg0KPj4+DQo+Pj4gTW92ZSB0aGUg
cm9vdCBpb21tdV9vcHMgZnJvbSBfX3JlYWRfbW9zdGx5IHRvIF9fcm9fYWZ0ZXJfaW5pdCBub3cg
dGhhdCB0aGUNCj4+PiBsYXR0ZXIgZXhpc3RzLiAgVGhlcmUgaXMgbm8gbmVlZCBmb3IgYSBmb3J3
YXJkIGRlY2xhcmF0aW9uIG9mIHZ0ZF9vcHMgYW55DQo+Pj4gbW9yZSwgbWVhbmluZyB0aGF0IF9f
aW5pdGNvbnN0X2NmX2Nsb2JiZXIgY2FuIGJlIHVzZWQgZm9yIFZURCBhbmQgQU1ELg0KPj4gVGhl
IGNvbm5lY3Rpb24gYmV0d2VlbiB0aGUgZm9yd2FyZCBkZWNsYXJhdGlvbiBhbmQgdGhlIGFubm90
YXRpb24gYWRkaXRpb24NCj4+IGlzbid0IHJlYWxseSBjbGVhciB0byBtZS4NCj4+DQo+Pj4gLS0t
IGEveGVuL2FyY2gveDg2L2luY2x1ZGUvYXNtL2lvbW11LmgNCj4+PiArKysgYi94ZW4vYXJjaC94
ODYvaW5jbHVkZS9hc20vaW9tbXUuaA0KPj4+IEBAIC03Miw3ICs3Miw2IEBAIHN0cnVjdCBhcmNo
X2lvbW11DQo+Pj4gIA0KPj4+ICBleHRlcm4gc3RydWN0IGlvbW11X29wcyBpb21tdV9vcHM7DQo+
Pj4gIA0KPj4+IC0jaWZkZWYgTkRFQlVHDQo+Pj4gICMgaW5jbHVkZSA8YXNtL2FsdGVybmF0aXZl
Lmg+DQo+Pj4gICMgZGVmaW5lIGlvbW11X2NhbGwob3BzLCBmbiwgYXJncy4uLikgKHsgICAgICBc
DQo+Pj4gICAgICAodm9pZCkob3BzKTsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBcDQo+
Pj4gQEAgLTgzLDcgKzgyLDYgQEAgZXh0ZXJuIHN0cnVjdCBpb21tdV9vcHMgaW9tbXVfb3BzOw0K
Pj4+ICAgICAgKHZvaWQpKG9wcyk7ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXA0KPj4+
ICAgICAgYWx0ZXJuYXRpdmVfdmNhbGwoaW9tbXVfb3BzLmZuLCAjIyBhcmdzKTsgXA0KPj4+ICB9
KQ0KPj4+IC0jZW5kaWYNCj4+PiAgDQo+Pj4gIHN0YXRpYyBpbmxpbmUgY29uc3Qgc3RydWN0IGlv
bW11X29wcyAqaW9tbXVfZ2V0X29wcyh2b2lkKQ0KPj4+ICB7DQo+Pj4gQEAgLTEwNiw3ICsxMDQs
NyBAQCBpbnQgaW9tbXVfc2V0dXBfaHBldF9tc2koc3RydWN0IG1zaV9kZXNjICopOw0KPj4+ICBz
dGF0aWMgaW5saW5lIGludCBpb21tdV9hZGp1c3RfaXJxX2FmZmluaXRpZXModm9pZCkNCj4+PiAg
ew0KPj4+ICAgICAgcmV0dXJuIGlvbW11X29wcy5hZGp1c3RfaXJxX2FmZmluaXRpZXMNCj4+PiAt
ICAgICAgICAgICA/IGlvbW11X29wcy5hZGp1c3RfaXJxX2FmZmluaXRpZXMoKQ0KPj4+ICsgICAg
ICAgICAgID8gaW9tbXVfY2FsbChpb21tdV9vcHMsIGFkanVzdF9pcnFfYWZmaW5pdGllcykNCj4+
IFdoaWxlIHRoaXMgKGFuZCBvdGhlciBpbnN0YW5jZXMgYmVsb3cpIGlzIHg4Ni1vbmx5IGNvZGUs
IHdoZXJlIC0gd2l0aA0KPj4gdGhlIHJlbW92YWwgb2YgdGhlICNpZmRlZiBhYm92ZSAtIHdlIG5v
dyBrbm93IHRoZSBmaXJzdCBhcmd1bWVudCBpcw0KPj4gYWx3YXlzIGlnbm9yZWQsIEkgdGhpbmsg
aXQgd291bGQgc3RpbGwgYmV0dGVyIGJlIG9mIHRoZSBjb3JyZWN0IHR5cGUNCj4+ICgmaW9tbXVf
b3BzKS4gUGVyaGFwcyB0aGUgIih2b2lkKShvcHMpIiBpbiB0aGUgbWFjcm8gZGVmaW5pdGlvbnMg
d291bGQNCj4+IGJldHRlciBiZWNvbWUgIkFTU0VSVCgob3BzKSA9PSAmaW9tbXVfb3BzKSIsIHdo
aWNoIHdvdWxkIGNoZWNrIGJvdGgNCj4+IHR5cGUgKGNvbXBpbGUgdGltZSkgYW5kIHZhbHVlIChy
dW50aW1lKS4NCj4gSSdtIGhhcHB5IHRvIGZvbGQgdGhhdCBjaGFuZ2UgaWYgeW91IHdhbnQuwqAg
SXQgb3VnaHQgdG8gb3B0aW1pc2Ugb3V0DQo+IGNvbXBsZXRlbHkgZm9yIGJlaW5nDQoNCkJhaCAt
IHNlbnQgdG9vIGVhcmx5LsKgICJmb3IgYmVpbmcgdGF1dG9sb2dpY2FsLiINCg0KfkFuZHJldw0K


From xen-devel-bounces@lists.xenproject.org Tue Feb 22 11:05:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 11:05:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276683.472923 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMSyf-0004Pz-Q2; Tue, 22 Feb 2022 11:05:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276683.472923; Tue, 22 Feb 2022 11:05:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMSyf-0004Ps-Mw; Tue, 22 Feb 2022 11:05:05 +0000
Received: by outflank-mailman (input) for mailman id 276683;
 Tue, 22 Feb 2022 11:05:04 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=QzH2=TF=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nMSye-0004Pm-PE
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 11:05:04 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 48df10a7-93cf-11ec-8eb8-a37418f5ba1a;
 Tue, 22 Feb 2022 12:05:03 +0100 (CET)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2104.outbound.protection.outlook.com [104.47.18.104]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-25-pYqfIgL-NZ-b7zKN3zcM3g-1; Tue, 22 Feb 2022 12:05:02 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM6PR04MB4056.eurprd04.prod.outlook.com (2603:10a6:209:4d::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.16; Tue, 22 Feb
 2022 11:05:01 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.4995.027; Tue, 22 Feb 2022
 11:05:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 48df10a7-93cf-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645527903;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=FvfCc6pd7XsMdZa6RKY+0prVe21M3C3KKFxAYVblUG0=;
	b=LeguXT6l6FmQ3U/CbFgMMlq3lD2k9smdjgtcYXTec/ms1oaMwRWyTyQv8J843kBmoy/GY2
	fGZ4fKHlQ1ifKFPM1l6eCSTbr+7JBIhEWMlvJECvC94DoCnqjy62lhG5NRnfmsbZEyyAE1
	DMqiLHF2bz6AJN0UQotZb2nlK5Ci/K8=
X-MC-Unique: pYqfIgL-NZ-b7zKN3zcM3g-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ZxebqtGCwZHhaCYDD4lDUjJ0aiP4StSRUqIsKPP0/zkIajg6IMsgsYSMzbwTXGVwRLP4jLGCb7fWamRcKUrv+ZqhR8PhR0UnvzUFz2TU3amYMTs2EZZOFhKeuKOsoqz+hS9buHlylf5nTtS3f+LRcZUT6+IVsKBsAmABqkBb9t2oRVF30T+P/igNHVLQQ5D0/mZdp1ElXaFZyE4Q1ebIlFG+ET/yQIfS1fftkqwdu7MgtmowgnViPQPrryKl2MKJslLJcBk988BbkzZoT4Py+ZXlhpUFtH0KvL9SicZX/jhBy/f2xLtf9tUOzdRbw68N5Y31Wr/U2NeF4WB8PstfxA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=FvfCc6pd7XsMdZa6RKY+0prVe21M3C3KKFxAYVblUG0=;
 b=JeN43FGpmTqoitdLIbgNBgCYLLe9Ri0EaKDfmskqAF9pV7H8i6UTY4oaZ8l8VfULxDaqUKathaTjvTNYMicyyrUZ1EOBQyfSc43hzsOjdwrUsd6QxEJZAQdIhMhkB1BoqSZ3kxHaXjW0ZIdorcn3/bRGI7QPQxy1Q5KY9DNmP+iLYypVF1HtlqXRnWkNQDUsf+ObVSp4i0yQtotvjeHq3P9k9akYzHrqEJjSt4hQQHyyoNynNQ7A/KniF+e0wazms4MVGx6wclT/u2ICcEhCUKH2f7lHs3V9BIbCImRhVKNFZo09ZGMP92tZzPyaQ94T1apNywp7VG5BjFomD2cKdw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <83fe9ea7-7947-9cc3-4e38-4d66fe428a1e@suse.com>
Date: Tue, 22 Feb 2022 12:04:58 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v2.1 8/7] x86/IOMMU: Use altcall, and
 __initconst_cf_clobber
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
Cc: Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20220214125632.24563-1-andrew.cooper3@citrix.com>
 <20220221180356.13527-1-andrew.cooper3@citrix.com>
 <0c253fda-c5f6-b7ea-df6c-8b43b86c6a59@suse.com>
 <9e442a8d-ef71-3776-e655-8c8a226af706@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <9e442a8d-ef71-3776-e655-8c8a226af706@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0701CA0004.eurprd07.prod.outlook.com
 (2603:10a6:203:51::14) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 91518122-a287-4437-e412-08d9f5f32b99
X-MS-TrafficTypeDiagnostic: AM6PR04MB4056:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB4056047DBF2E0D66103B0932B33B9@AM6PR04MB4056.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	KT03Rp15z2QzUpTfklYGxUeGABF0Lax6LPXXGkT4Aa8IeKw34e92ztluO9MIEGCA1C3TSXDr1rfOqkBhPXehWrMlsdGhyRcemJ4WADc+6fQstiwo0/SQZoGsnXhs9uGP4loDdVKVRlzumgsVCPZSmplZamgu88vtGCw01XR7p43tNkeMAzQtbtEsfp+Og6a7pxgwGYk//X3FPK264s+1J7LfLiWEa7ScdGf0JU0AI60hpSXmJRs3vDLkeKWrGIzvStPO8R2OjjyIaxmw40L3K9D8+pbQMWxv91bHWrW6K1H2+fHrxPXrFlt8olQxdqoJG1kKSova3Eev6/jNM4A2tXLM3mWI+6XiS9+dRa9n6Yxi5MRP3zYbyzTBmOvb0+dtuM4O9af4NlECk08jNRzmjkAcPliXMy9AfKpP9UacBpmf3AcsbVeHE5aiIQZUFexncg+bYYkl9QYiQt3K30UseO/2DZtfZdkrpfpaXOVrXISDas2YY66KtdgHTdV9Dm+9qmIqpC0FGVErVux01RU2yE2CHLSeHqiG3AHC9cB/5qhulEVjjptw1AzOS6D7/tBYiB8Wubjs0RCV7o/zU2GBzitX41Azcx426MuRuFIDMEb9ek9Gk9UglIddogwN2o5W9GBi7Ww0I6UsYqKvnK1Nei3FJUA1QVKRehEflbto9UwyqNQsTEsfW2W0zSvf2sbMzUoEqsRXvNkwB/szSSQ0LtOOCvPXuJebhuyT42J5zEWTU3rZPqMNrh7Qbym83S1O
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6916009)(38100700002)(86362001)(6512007)(508600001)(6486002)(6506007)(2616005)(31686004)(31696002)(26005)(54906003)(186003)(53546011)(66556008)(83380400001)(5660300002)(2906002)(8676002)(66946007)(316002)(8936002)(4326008)(66476007)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?QUo5cWRoR3R2VjFadURaL2t4KzN5bjVsZG9ENHFmRnEwY095TGlOOFBDVGhT?=
 =?utf-8?B?eEp3dFRCcmpabDlBTEpXUHQ3SjlEMEhJL0VSOCs2ZExaZEs2ZUJHd2xKdUs4?=
 =?utf-8?B?enh4MldKTDlVQzd0Sy9sYWNueGYxR3JiMW9kSDRPRnNuVENFSHFPR1BEK0ti?=
 =?utf-8?B?cUlYM0hyTlRpNk9PNSttWmNjamw2S0hvRGd4bDdTc2NMTVFxVGMzSGcrYmFz?=
 =?utf-8?B?UUZqeVFLaVMzSy8yZHdFd24wSFJ5VzJJeU0zZEY5WnU3UVpTUVg3QUZGYUZ4?=
 =?utf-8?B?dmg3NXJuV21OLzBldDdJNVAvRUhES09Tck9iMGxvRUl5bFJ4ZHFiZnZHSFRk?=
 =?utf-8?B?akNuMVB2cjd4TTU1NjdWZ0kxOGxaMVFUNThkdlFpcmo4RHh4VWJoTGdwY25C?=
 =?utf-8?B?ZGxnU1dPb0pYcGNJZGRZSUVpQ25qMXhKdTd5bDFPSGducktlcWs3TnBJNGpm?=
 =?utf-8?B?elZFRWFabVd0MXc2MFBHbUl5RlVjL0R4ait4SldweVNDcjBWTHNvZEhPQTlZ?=
 =?utf-8?B?bGpYeUNUL09sYUN3K1QxaDdEQWZRd09uRTFwclh3b1BuTXlYYnF3VlV5ZUlh?=
 =?utf-8?B?MzRNMFByeXo3eWs0UmZSR0Fkd2cxY0w5UjBVcmE2bVFvK051ejluRlNPOFRC?=
 =?utf-8?B?dzlteHlwNnE0U3o2Y1FORWZkd2Q2Z0d3ODgvNUwrOGFVQXhiSnU3VzU2NDkw?=
 =?utf-8?B?VmhmVUJVaEdON1JSYUhOdDREdHN2TVF6L2E3cUxtSmNhcmY1VnI2K1o3ZkNk?=
 =?utf-8?B?ZDhvcE5ibW9CdUtqcUNWYldmQXJPamg2TTh4b0oyVmtwTmZnSXVsUW8vNU04?=
 =?utf-8?B?NHVCWGFIenhXTXJyTk5KWDAwRXBYNlNKdCtveXVsM01oTlRVaHNVSGJVcm1q?=
 =?utf-8?B?SEFGYVFGbjRpRWZ0VS85d1o4ZythTHIrYktVb1J4K0tNYmFnNEFITGJBU2k2?=
 =?utf-8?B?RkY1WUF6Z3B3YWlKWG5IUzVkMHhuY2M4K3ZqVy9ucUtoaCtVc2pGZDF0UG4y?=
 =?utf-8?B?TlRkdW9TaGt0amQ2TzA5YVNYaDhXWGRwK2JZZ2ZjUFVqUnF0UFZZMm1CdE5p?=
 =?utf-8?B?bFZIT241OG5HM3lHN0g0WGZGYk1ycWMzelBRVUZER3Bad05DU2RvSHA4bzF1?=
 =?utf-8?B?azh4N2dhU0NZamJCOHA4U3o2M1Axb1NVeXk2VmJnZXgweDEwaktQYVFLMHhr?=
 =?utf-8?B?Rmh6SUJlNStwbnh6aTVVQXlkTFFSbm0wWThNbFFKTnhxaWpIQlJPbVIycmQy?=
 =?utf-8?B?T3UvMklhZTZ0SjBPN0JtVFUvMEVaMkxoWXNDLzBuUDdWZDU5WWk3MGFpYVBw?=
 =?utf-8?B?cW1uQW5hdzRxNE4xTWNMWHo1em82b3dXeWdEa1BsdlZLSHNUdCswYkpSSGNm?=
 =?utf-8?B?cFRGQjlobzM3QStYZTZ6QUF0S3piSGJaaDdzcFhJeXZLbEJsWUpBSFZ6V0xs?=
 =?utf-8?B?Z2p4bjl4ME9VNjczb1lqM0VWcWVsdWNaZXBRaWlpcmt2TS9QSElyeE9LaE5P?=
 =?utf-8?B?U1lQa294Nkt2czhNaFJLMFVRVUR2RS83U1RyZFlVUlk0NVd5ai92RVZ3MUkz?=
 =?utf-8?B?ZHdGaWVlSnR4cUJ2dFh2TmxXSXlUTUdLZUNid1FJbE8vQm9SckFCWXZXWkFR?=
 =?utf-8?B?WHVlMjJyTlNMVFUvZmpUMmxSWDdSdkZod21DVVMwMVZncWh3QzhtT1BCNUFP?=
 =?utf-8?B?V2pDVzBsVXlUb3pFcXRqdGFJYUYvc09QYUNxQXozVWNpME9XN08xaHpJYTFm?=
 =?utf-8?B?ZTgrazliZm9jZHdvSUFhMFVielJ5RFFyUjNXMzIvaXFVTGRDZU9GUHZLdXd0?=
 =?utf-8?B?TnhRUm9NaTN5Q2s2Z2pSNHdYaWFxazFiVlBxNGxGZlRUVnFwODZELzM4M1BN?=
 =?utf-8?B?TGxDdWw2QUQ3TFFNVE92cmlucnVBY1Q4SmdIY3ZUaXRMclEwWW5HMURpSkhh?=
 =?utf-8?B?TWkwczdpOUlNblh3anBJVDRSRkFzbElKMTAycUlQM3BaOWkwdkdUNnY0R1Ro?=
 =?utf-8?B?bnZhRXRnV2NOZVJzZFFRWkFNcHptWlFEQWg0T1dWWHgwdXdicU41S0tWcHFk?=
 =?utf-8?B?WWhhV1NpSEtYRE1zT09sUndhOFBYb1ZNRnZNUjhsaHdvUnJGRzk4TjBOMWtS?=
 =?utf-8?B?bm5VeG5GMFBiYWRRSGpBS3BoNXJwWGhsUFRTSWNYUW1jeGRxR3laN2JHRkp0?=
 =?utf-8?Q?67b938Hbjeo1N4k7GvOvteQ=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 91518122-a287-4437-e412-08d9f5f32b99
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2022 11:05:00.9186
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EPpcDISdVU6hgVAENk1M9L/6wwCa6BX+HRk56TLebSht7Y3sHv2a8Kw82c1n/qVgUvSN+0WUdURH5T4PDe5d1w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4056

On 22.02.2022 11:54, Andrew Cooper wrote:
> On 22/02/2022 09:29, Jan Beulich wrote:
>> On 21.02.2022 19:03, Andrew Cooper wrote:
>>> --- a/xen/drivers/passthrough/iommu.c
>>> +++ b/xen/drivers/passthrough/iommu.c
>>> @@ -540,7 +540,7 @@ int __init iommu_setup(void)
>>>  int iommu_suspend()
>>>  {
>>>      if ( iommu_enabled )
>>> -        return iommu_get_ops()->suspend();
>>> +        return iommu_call(iommu_get_ops(), suspend);
>> This use of iommu_get_ops() in such constructs is a pattern we didn't
>> have so far. Perhaps it just looks bogus, and all is fine in reality
>> (apart from the whole idea being wrong for Arm, or really any
>> environment where multiple dissimilar IOMMUs may be in use). Or wait,
>> there are pre-existing cases (just not immediately visible when
>> grep-ing for "iommu_v?call") in iommu_get_reserved_device_memory() and
>> iommu_setup_hpet_msi().
> 
> I think this means your happy(ish) with the change?

Yes. It looks a little odd, but since we have precedents this ought
to be fine.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Feb 22 11:06:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 11:06:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276689.472934 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMSzj-0004zJ-3a; Tue, 22 Feb 2022 11:06:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276689.472934; Tue, 22 Feb 2022 11:06:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMSzj-0004zC-0f; Tue, 22 Feb 2022 11:06:11 +0000
Received: by outflank-mailman (input) for mailman id 276689;
 Tue, 22 Feb 2022 11:06:10 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=QzH2=TF=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nMSzi-0004yy-1s
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 11:06:10 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6fece42a-93cf-11ec-8eb8-a37418f5ba1a;
 Tue, 22 Feb 2022 12:06:09 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2176.outbound.protection.outlook.com [104.47.17.176]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-36-MJxL8VwvOUy4O4FHexA6OQ-2; Tue, 22 Feb 2022 12:06:07 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM6PR04MB4056.eurprd04.prod.outlook.com (2603:10a6:209:4d::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.16; Tue, 22 Feb
 2022 11:06:04 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.4995.027; Tue, 22 Feb 2022
 11:06:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6fece42a-93cf-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645527968;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=5+FlNmGTJAP7ySZOtoSzd387XJPuUCqJKFUhMMsiLe4=;
	b=Y6qgAIuC4r2BS9aib3RBkySY7Epc//IhQFYywpG15hfj4UuPVZ/nHhx0NGlPCbU4KEKY5C
	Eg4b2pOtxz9qkSssdYEJfRH9EUEsnBarIMLfaoARHnyKCC1cLMOf4CFZ/fnz7TKIosec5p
	5YFzHSMN6IxvXAHpknqC+BYnLade3oU=
X-MC-Unique: MJxL8VwvOUy4O4FHexA6OQ-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=NmnEMerGkWh5DzpX1wYitapUly0N25vQmn1NxxXwqvuww4xiGGl5IESn0+CkKkoo3f9ZSKM5bxzKyFfG0WIVpHtN8n7QvLopXuAK6mRVoB6EIJY77EWz+yt/COFKbJGlhP+IdslHecMe/esvQa2+5sUOButIKEXhA+pUmAyUkrVTnpqO6wGkA5qFHcBQW3cmrmZsCjyvCWNZhBlfQowawrnHOMleCAWnrWjld20SiaDlw0xzTogu0q9C0YtBg0YKbOF0LEAOoPHbCPv4sMGsEloxd5L0loCp6HlaptWmRG07QpPk5DE6rH3vxiWYu00JCgEgDO8Xy0V525Uah1bH8A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=dFtFAO7JUprpOdWh9zZbXNzXCr8f+xnCmz3TMEOS+UY=;
 b=ZVa9b3VLh0MyWKjUGF/WgqjEBY8fBAp67l9py2MLHP5zkCnUh7iYkc9f60zmOOJbfOrAd4M9I2yncW3BzAtyel86DEM2h/9CdttUEX7EP7na5CuObU6RRYtuHu1xBbtgT7glJs1zXa/bPW3wzxcIED4pa2etQwPaNIeGDW1qW+Mdpewu7cEDgsajszaK2ZPIqprsa+Mbe5OuD4O8ESAc/bVlvGVrT7lZ0qvWdhlltt7aEPXszY7P06DQwyhBgzdBpDwFQLhteJEtIIRGq5Hs+UsqNdiG6jfNI+YxvawzXjfrEVYO0wDrDEw6Os2lTq9t8e3Vf3J6o4CHE5bznO4g+g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <493ed0e5-7121-c372-9a19-3ed0bb549ea6@suse.com>
Date: Tue, 22 Feb 2022 12:06:02 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v2.1 8/7] x86/IOMMU: Use altcall, and
 __initconst_cf_clobber
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
CC: Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20220214125632.24563-1-andrew.cooper3@citrix.com>
 <20220221180356.13527-1-andrew.cooper3@citrix.com>
 <0c253fda-c5f6-b7ea-df6c-8b43b86c6a59@suse.com>
 <9e442a8d-ef71-3776-e655-8c8a226af706@citrix.com>
 <61efbf17-b07e-d513-7430-d0549e1384d7@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <61efbf17-b07e-d513-7430-d0549e1384d7@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6PR04CA0032.eurprd04.prod.outlook.com
 (2603:10a6:20b:92::45) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: fa75ae84-f643-4110-8a34-08d9f5f3517e
X-MS-TrafficTypeDiagnostic: AM6PR04MB4056:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB4056557F2D347E59E11795C4B33B9@AM6PR04MB4056.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ZnEAoCA5qar7kBCNVbr9w4BtqpozyZPWtSgEmcQZxDpQeUXebXcwkvAEeDtbsm3SQlulY8NHU8/VH76ErNyo9zIwMdnMzPXKBRRDXpzqy0V8BmG5ppZugp702vYd9+8k00FW87EgMk3x0ssydU6xuEE1HNpMjHiKw8BQNxnCTNKhf1PMMcQvnZpND9sHiSMSlIcNk1xnsngSBIQvM/unXfDXGgsxaJMLheO4QKSOH5ASFK1KL8BLu+9ei1bufdDX7TJ9d8KKxKNKrBqPck3zHBgtpUzWUpM0sfV8USyJqkR7W9evM8mp7NBAKyBT0xqt3duPJt1K2A1Upv22ToWZ22Xxj4ypNgzrHFQfdcbYUAIk+zOpHv2/8a1YBjaLOwqBzZ/4v5RHRQnR2Eo3PO4k+REwT6wSGMApDSwc7XBleeWByUhpJlRndxQd64TSMH5YbnjsSvLpkWWauNYOfbsM3bRkHRYNWavLiDxXNOasjaN1oeCXXWrdD3HbEohuQ7fuUuc+rwJ7HrJhUZFYzGPNAQut2zCsiT+ii0SlFvw3F1IX4k/4D5mA9dp3Ted2VpWt5Y5K+CuK5tKEqOqYgoz42ZMaLLPs792XMINQPpHnOECosvB65ZlEMIp1YM04FeIZkxr/xXjrU4RzjSO6MVaS50xkOf9hfJPkqLK/iuu7jkScOUCTgoIQt6GPVOxaQzvxIDiYJpQMlnVbF/WZb15fSYzR0xv9UfsN1Lq6yalcAc1i9a8hJwn1uw3oC5KISm01
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6916009)(38100700002)(86362001)(6512007)(508600001)(6486002)(6506007)(2616005)(31686004)(31696002)(26005)(54906003)(186003)(53546011)(66556008)(5660300002)(2906002)(8676002)(66946007)(316002)(8936002)(4326008)(66476007)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?GHDtRJ45/U+KBM1WpxucZm1HuqZr+VpEcKlkXQtE3cgdAtoUJv9L55kukNin?=
 =?us-ascii?Q?KmqvSO9GesPng3AJ+jT4Bp/FVjqqAzJHOnFndxLn5Ub1vPNZsiVJN8l7down?=
 =?us-ascii?Q?rONMV8WAxYkOHKKqL0gfmnIGc+t0KdieEjysrZSuub2Q5GBNTVXEbfnoO3dt?=
 =?us-ascii?Q?03dkDXVzPXsGBytt2wn2vD5z3YUGouTKfXXxGpEmsk5/p4f+V3tvrVhxSt8q?=
 =?us-ascii?Q?b2tTcd/xMwYaCzCceWFL2R5EfCbtFoqjaPDPSSlwWpgNlTyIM/Tz2emTofiN?=
 =?us-ascii?Q?gCmIYg+KiRA/PotoKPv/eGePa3VAFDIm1vVjaEhtJcz+OvdEnpiiPmMMfuuJ?=
 =?us-ascii?Q?LoFlhWz7qb+e65vbr5BqkPj5Bug0KlxrZjZTXAcnnBrbQjwijOQRFXahew0P?=
 =?us-ascii?Q?u5v2MFiYqtf3agjL3osRcBM4bxedYfEhDllZ7OGQ8bAeZ5FavUGV8ReuSZGE?=
 =?us-ascii?Q?0+K8PyTIVg1Me2IugjxTgOhdOzYK8DnfEzj/frHCP39tz06H+YR2LhFhnYYb?=
 =?us-ascii?Q?FRSY4MMyRpvLImjJJkvBjV2JuaxK++oHe84DmW0Z8dZCsxXMSUVUY1Alrq8V?=
 =?us-ascii?Q?rydRScKygnmXUegxypVYHsHF4jbRnMx5HCmp2bafshbUKvK0+rlEsHLO+/FM?=
 =?us-ascii?Q?S53r7PEKoVuugbpxvBCDAKxbasEcPSmJyx7D65EaUNZm1zcgsiA3yMtL/Qas?=
 =?us-ascii?Q?LOeWeBH7Jeoci98mdzZoqBR9OEUjxG0sJs6QFRHfR+n2NyaxBJtSQBpvk22V?=
 =?us-ascii?Q?h9e+YHQGS83chGoKBosDe2HDBdmTtlQUUDhvNVopC6gDZN5HGmJdbdsE0Da+?=
 =?us-ascii?Q?XSZ0PoTIO+lQOzDgreywZFZnDf99stsNg3yRYvuaaXTCl3gtmKQHrULuBLCA?=
 =?us-ascii?Q?sJziKeAvWSU7W38WB7kCCMkDCwdOleF6ESzz2SbblOpg96lQaleGl+Id6ywq?=
 =?us-ascii?Q?eBtQKwuYxPAJXQxgQzp3cH14dG/PyTqt9vKo5skyL7tBLbwmBkOyoJdgeI2u?=
 =?us-ascii?Q?GkOC+luFzhJHLWisYx+FfIgGYN1zGWAGC4v1VAMu2doy5FUQw5+6oRf1PrYX?=
 =?us-ascii?Q?qd4QHO09bljmtjPwpyuENPGD4dsHeByPTe6pb4/kf1aWolAtHX1zQu67UvZs?=
 =?us-ascii?Q?DG1ZqQO0BP+b5pE51gbX8gIM6XGzVbiqsEu62EHLpw9bj9QbuVRnRJp5AuFQ?=
 =?us-ascii?Q?qoj+0U9DC5QmLpw/+p1zneWMXZUYhJqL8pZsSjntPQT8gIDJXUyI7KBpm1pO?=
 =?us-ascii?Q?ClYnfSDtWUj0nRzpDTM+68NcOw7asUlhmiDodjqEYQ1eIiUmOzWMmUJAI+NZ?=
 =?us-ascii?Q?pqKjzcwP1TntINp+mft/0gQnXwyRJ0TMDvZCrcJHwJfw8prx15GZKE6BOH6d?=
 =?us-ascii?Q?4hCySz1yy+PZW2nMfWcTjR6CDGME7oZWQ5EFbMA3Nf5+Dx9yCtEwksnRQz3Y?=
 =?us-ascii?Q?lhy2WbfqshZIa3nS90+uOSFJMHQjxdXiAmm6YHIQBvX+jT5AyrRQ3zcZx1ea?=
 =?us-ascii?Q?joSB+ZTBwQ2XNePVoKrwcX6ZRmp4jLBfEmIBjVGr5FvCr0jJGyYG4D6vcUes?=
 =?us-ascii?Q?xhXxQvsANqkreQy95PIbKr3ngzWdwDicfkBJyTFnXGSnM0+6YKI8dTLIAuSg?=
 =?us-ascii?Q?uDkPdUVjJf+ebIbvS9FFtgs=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fa75ae84-f643-4110-8a34-08d9f5f3517e
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2022 11:06:04.3991
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JPfAkQIWrFj/PqLdCSSegl+NZ6PBQxfzOIuIPimzTCu4c5nLzHAa2Mvc0FwE7U77fHvLqd5ecNoKqPLYW0nTQg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4056

On 22.02.2022 12:02, Andrew Cooper wrote:
> On 22/02/2022 10:54, Andrew Cooper wrote:
>> On 22/02/2022 09:29, Jan Beulich wrote:
>>> On 21.02.2022 19:03, Andrew Cooper wrote:
>>>> @@ -106,7 +104,7 @@ int iommu_setup_hpet_msi(struct msi_desc *);
>>>>  static inline int iommu_adjust_irq_affinities(void)
>>>>  {
>>>>      return iommu_ops.adjust_irq_affinities
>>>> -           ? iommu_ops.adjust_irq_affinities()
>>>> +           ? iommu_call(iommu_ops, adjust_irq_affinities)
>>> While this (and other instances below) is x86-only code, where - with
>>> the removal of the #ifdef above - we now know the first argument is
>>> always ignored, I think it would still better be of the correct type
>>> (&iommu_ops). Perhaps the "(void)(ops)" in the macro definitions would
>>> better become "ASSERT((ops) =3D=3D &iommu_ops)", which would check both
>>> type (compile time) and value (runtime).
>> I'm happy to fold that change if you want.=C2=A0 It ought to optimise ou=
t
>> completely for being
>=20
> Bah - sent too early.=C2=A0 "for being tautological."

It's tautological here, but not everywhere. But imo the ASSERT() is
good to have anyway, i.e. even if it leaves traces elsewhere in debug
builds.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Feb 22 11:13:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 11:13:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276697.472946 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMT6i-0006SJ-TW; Tue, 22 Feb 2022 11:13:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276697.472946; Tue, 22 Feb 2022 11:13:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMT6i-0006SC-PI; Tue, 22 Feb 2022 11:13:24 +0000
Received: by outflank-mailman (input) for mailman id 276697;
 Tue, 22 Feb 2022 11:13:23 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=pCta=TF=huawei.com=linmiaohe@srs-se1.protection.inumbo.net>)
 id 1nMT6h-0006S4-Lq
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 11:13:23 +0000
Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6f85945c-93d0-11ec-8eb8-a37418f5ba1a;
 Tue, 22 Feb 2022 12:13:19 +0100 (CET)
Received: from canpemm500002.china.huawei.com (unknown [172.30.72.56])
 by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4K2xLr5zVwz9sxm;
 Tue, 22 Feb 2022 19:11:32 +0800 (CST)
Received: from huawei.com (10.175.124.27) by canpemm500002.china.huawei.com
 (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Tue, 22 Feb
 2022 19:13:15 +0800
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6f85945c-93d0-11ec-8eb8-a37418f5ba1a
From: Miaohe Lin <linmiaohe@huawei.com>
To: <boris.ostrovsky@oracle.com>, <jgross@suse.com>
CC: <sstabellini@kernel.org>, <xen-devel@lists.xenproject.org>,
	<linux-kernel@vger.kernel.org>, <linmiaohe@huawei.com>
Subject: [PATCH] xen: use helper macro __ATTR_RW
Date: Tue, 22 Feb 2022 19:12:22 +0800
Message-ID: <20220222111222.56877-1-linmiaohe@huawei.com>
X-Mailer: git-send-email 2.23.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-Originating-IP: [10.175.124.27]
X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To
 canpemm500002.china.huawei.com (7.192.104.244)
X-CFilter-Loop: Reflected

Use helper macro __ATTR_RW to define hyp_sysfs_attr to make code more
clear. Minor readability improvement.

Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
 drivers/xen/sys-hypervisor.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/xen/sys-hypervisor.c b/drivers/xen/sys-hypervisor.c
index feb1d16252e7..5e842c88a13e 100644
--- a/drivers/xen/sys-hypervisor.c
+++ b/drivers/xen/sys-hypervisor.c
@@ -25,8 +25,7 @@
 static struct hyp_sysfs_attr  _name##_attr = __ATTR_RO(_name)
 
 #define HYPERVISOR_ATTR_RW(_name) \
-static struct hyp_sysfs_attr _name##_attr = \
-	__ATTR(_name, 0644, _name##_show, _name##_store)
+static struct hyp_sysfs_attr _name##_attr = __ATTR_RW(_name)
 
 struct hyp_sysfs_attr {
 	struct attribute attr;
-- 
2.23.0



From xen-devel-bounces@lists.xenproject.org Tue Feb 22 11:21:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 11:21:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276704.472957 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMTEF-0007uw-MU; Tue, 22 Feb 2022 11:21:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276704.472957; Tue, 22 Feb 2022 11:21:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMTEF-0007up-JE; Tue, 22 Feb 2022 11:21:11 +0000
Received: by outflank-mailman (input) for mailman id 276704;
 Tue, 22 Feb 2022 11:21:09 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nMTED-0007uf-Sr; Tue, 22 Feb 2022 11:21:09 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nMTED-0002fs-KG; Tue, 22 Feb 2022 11:21:09 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nMTED-0008PV-2o; Tue, 22 Feb 2022 11:21:09 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nMTED-0008TZ-2M; Tue, 22 Feb 2022 11:21:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Cz4OWc6XH6W400eYI88z9DHJlrgiOmk/VJfi4WyAAps=; b=YkF4zN4bU+IhBSGL3hbniqVIQu
	Trc4s4oUdaf4Ub9pGo5u3JLF+iOF1QVPuezsWFAHQGtYwa+mdFxfA93zDx0hi2NOIcx3bFNSo8OWE
	14R57XQdDOoHas/KDqMtpDONCVcOkAY9P/vugJ3lvS+dsbMjP7wzHDEdY/493i0SHDA8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168189-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 168189: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-armhf-armhf-libvirt-raw:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-armhf-armhf-xl-rtds:guest-start.2:fail:allowable
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=95d9ab46143685f169f636cfdd7997e2fc630e86
X-Osstest-Versions-That:
    xen=686f13cfce1d95464ff39fb59ac1f85163cea03b
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 22 Feb 2022 11:21:09 +0000

flight 168189 xen-unstable real [real]
flight 168192 xen-unstable real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/168189/
http://logs.test-lab.xenproject.org/osstest/logs/168192/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-armhf-armhf-libvirt-raw 17 guest-start/debian.repeat fail pass in 168192-retest

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds     19 guest-start.2            fail REGR. vs. 168173

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168182
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168182
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168182
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168182
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168182
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168182
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168182
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168182
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168182
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168182
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168182
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168182
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  95d9ab46143685f169f636cfdd7997e2fc630e86
baseline version:
 xen                  686f13cfce1d95464ff39fb59ac1f85163cea03b

Last test of basis   168182  2022-02-21 01:53:55 Z    1 days
Testing same since   168189  2022-02-22 01:08:05 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Roger Pau Monne <roger.pau@citrix.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   686f13cfce..95d9ab4614  95d9ab46143685f169f636cfdd7997e2fc630e86 -> master


From xen-devel-bounces@lists.xenproject.org Tue Feb 22 11:34:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 11:34:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276726.472992 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMTQr-0001LL-8x; Tue, 22 Feb 2022 11:34:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276726.472992; Tue, 22 Feb 2022 11:34:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMTQr-0001LE-5r; Tue, 22 Feb 2022 11:34:13 +0000
Received: by outflank-mailman (input) for mailman id 276726;
 Tue, 22 Feb 2022 11:34:11 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Woib=TF=citrix.com=prvs=045a4fa17=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nMTQp-0001Kp-FT
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 11:34:11 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 37611047-93d3-11ec-8539-5f4723681683;
 Tue, 22 Feb 2022 12:33:13 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 37611047-93d3-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645529649;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=tpzYAYIGtBlCj4TZTKnv7P9xIXLEigiuEVLZ+ryIB7s=;
  b=agt324C01TNeWnF6iaA+thSzqwSqu5KURZ/pBNL7IC88DZ/Xy5RzwwqD
   7jUj/bmsit62owIxjM5eGp+DvCnynnQo9dXEeYQjJO+IZYuydMGJrqQsq
   vBsluq+YAtSkvhueUva3D4gOrHtJRIo5Sdn0mWqsxJHCEUcIUJmLTWYPJ
   k=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 64714177
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:15rS7q+CmBcyoq8UTqodDrUDkn6TJUtcMsCJ2f8bNWPcYEJGY0x3x
 2QZCzrVMvuCazCnLtF/atiyp0IF7ZLWztAxHAZury88E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si+Fa+Sn9T8mvU2xbuKU5NTsY0idfic5Dndx4f5fs7Rh2NQw24LjW1nlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCnYSubgw0AredodY+AkJ+TB5QOaNs8bCSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFKoZtmtt0nfyCvE+TIqYa67L+cVZzHE7gcUm8fP2O
 ZZGMGY2M0uojxtna2UFK9FhmbyRm17QQj92q3CqiKMJyj2GpOB2+Oe0a4eEEjCQfu1Fk0Ddq
 m/Y8mDRBhABKMfZ2TeD6mirhOLEgWX8Qo16PKK83u5nhhuU3GN7IB8cWEa/oPK5olWjQN8ZI
 EsRkhfCtoBrqhbtFIOkGUTl/jjU5XbwRua8DcUi9iaG15bOsj+rJTlfaGF+RtgonsY5EGlCO
 kCyo/vlAjlmsbuwQH2b96uJoT7aBRX5PVPudgdfE1JbvoCLTJUby0uWE409SPLdYsjdRGmoq
 w1muhTSkFn6YSQj86ygtW7KjDu3znQiZl5kv16HNo5JA+4QWWJEW2BKwQWDhRqjBNzAJrVkg
 JTis5LFhAzpJcvQ/BFhuM1XQNmUCw+taVUwe2JHEZg77CiK8HW+Z41W6zwWDB43bptYJ260P
 RWP4Fs5CHpv0J2CN/Qfj2WZUZlC8EQdPY69CqC8giRmOPCdizNrDAkxPBXNjggBYWAnkL0lO
 IfzTCpfJS1yNEiT9xLvH711+eZynkgWnDqPLbimn0XP+efPPxa9FOZaWGZim8hktctoVi2Oq
 I0BXyZLoj0CONDDjt7/q9BLdglSdSBhbX00wuQOHtO+zsNdMDhJI9fawK87epwjmKJQl+zS+
 Wq6VFMew1367UAr4y3TApy/QNsDhapCkE8=
IronPort-HdrOrdr: A9a23:W2h3E6//8mfchfzfCVBuk+F2db1zdoMgy1knxilNoENuHfBwxv
 rDoB1E73LJYW4qKQwdcdDpAtjkfZtFnaQFrrX5To3SIDUO31HYYr2KjLGSjwEIfheRygcz79
 YYT0ETMqySMbE+t7eB3ODaKadg/DDkytHRuQ629R4EJmsKC52IrT0JcTpzencGHzWubqBJcK
 Z0k/A3wQZIDk5nCfhTaEN1PdTrlpnurtbLcBQGDxko5E2lljWz8oP3FBCew1M3Ty5P6a1Kyx
 mEryXJooGY992rwB7V0GHeq75MnsH699dFDMuQzuAINzTXjBqybogJYczAgNl1mpDs1L8Zqq
 iJn/4SBbU115oXRBDynfLZ4Xik7N/p0Q669bbXuwq6nSWzfkNENyMIv/MmTvKe0Tt7gDg06t
 M644rS3aAnfC/ojWDz4cPFWAptkVfxqX0+kfQLh3gaSocGbqRNxLZvt3+9Pa1wVR4S0rpXWN
 WGzfuskMp+YBefdTTUr2NvyNujUjA6GQqHWFELvoiQ3yJNlH50wkMEzIhH901wua4VWt1B/a
 DJI65onLZBQosfar98Hv4IRY+yBnbWSRzBPWqOKRDsFb0BOXjKt5nriY9Frt2CadgN1t8/iZ
 7BWFRXuSo7fF/vE9SH2NlR/hXEUAyGLELQIwFllu9EU5HHNcjW2He4OSMTeuOb0oAiPvE=
X-IronPort-AV: E=Sophos;i="5.88,387,1635220800"; 
   d="scan'208";a="64714177"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=iaIqluOBqEpgx4pybWig0HyQj7vthdUV1BR/Ub0sC+hdXV1jaAF0k+G5ff2YxlSSBu2tewqntYNcHwbwYGuDtIksjp6kyelHoSPiIsbJ78xtm+9B4O8WLibqUFWgpZytAzfQRPgCfSgNXxM4KCC9sO1Ft8eC3v7UAakFxCC9p5JVQkvSI1lTIZb/PcYInXd1i9iO7NvrPqI8nzSuWHJdAbOmLFIdCW6hQndzb+j9Mnc17oTSJdgvfjg0KP/WLxVsMDOiCui8Y1s+AyI7EvsUcN5LyNqriPLK20im/Zap20xW+042sJ5if/U0Kmxv9dizDAmejvFe0BsqQMhRl5ct6A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=tpzYAYIGtBlCj4TZTKnv7P9xIXLEigiuEVLZ+ryIB7s=;
 b=gMYRTqjDQJBIWY2KbLpwLxKQo2QETwYHosRTol9dJg8gUQbhBM6Tqh16oHSy9G/k35wM83qiMyscz1HPoNdb+nPWHE39ROuu3mTol2nH5y933BrqwzQYRv+f3l+5jfuIyWnxA+yiF8zxvaX+TdMGhut+ML4hSRmilQkLCA8SwKVZDpoYxynmAF4Ko07iN8AJNfiR1kJVfjGOX7V5Abuy+7Vd62TFqrA/yCSzgLbyl6DAb6z4BD/T+J5wupWzFOPfVxEjtlNkH1qqsQpi55BMLzkc4zGd/LpsbsZ/j4c93nu3nPzfRxGkJLFSJRhbWp00kpDMZHqDfyxtW65Lkb2r2A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=tpzYAYIGtBlCj4TZTKnv7P9xIXLEigiuEVLZ+ryIB7s=;
 b=uImmHGR5Uw2VleNyYrlke11YLzMuBvzVNKK1+1YGmEZXpBW2Clmb9kRNrteWFmvhLk5pnZdUhA/61JPsdbcFJWzlFk9RkDNq+dCjTzA/m2OsasOIh8/bbclt0pUYp4lFIGZK0TZDSpaPx8ourhfQ3As7nKX6UHsEcnOzr1D1YS0=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>, Xen-devel
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2.1 8/7] x86/IOMMU: Use altcall, and
 __initconst_cf_clobber
Thread-Topic: [PATCH v2.1 8/7] x86/IOMMU: Use altcall, and
 __initconst_cf_clobber
Thread-Index: AQHYJ011tWngdwKc2UG3RuxDqKou56yfTukAgAAXlACAAAIiAIAACPWA
Date: Tue, 22 Feb 2022 11:34:03 +0000
Message-ID: <bd88d0bf-1459-0600-ec22-a4b0797b8f32@citrix.com>
References: <20220214125632.24563-1-andrew.cooper3@citrix.com>
 <20220221180356.13527-1-andrew.cooper3@citrix.com>
 <0c253fda-c5f6-b7ea-df6c-8b43b86c6a59@suse.com>
 <9e442a8d-ef71-3776-e655-8c8a226af706@citrix.com>
 <61efbf17-b07e-d513-7430-d0549e1384d7@citrix.com>
In-Reply-To: <61efbf17-b07e-d513-7430-d0549e1384d7@citrix.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 06911ca3-011c-48d2-baca-08d9f5f73aad
x-ms-traffictypediagnostic: BN7PR03MB3889:EE_
x-microsoft-antispam-prvs: <BN7PR03MB38893EBA06A747BCEA5A6842BA3B9@BN7PR03MB3889.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: keJR2WLts+tK5OznMtS9RpxdxUbYAKRer5YZykXMrliXidfdf29ThSJXCt6tdkdCWeGTAvIIFUH+SVry7rUkjysCPOVxm7ES7uiyA0dhmqj05ReL22pByFudtp6xvvkUoith/mnBrQLNzvvES0dFwXQKjld9q9yae+vX/QUp1n897ESKF6m+vGEMZmKDLVGyJpgqRs7TkfPtnSFK4WSPXnCtLyyIivmR+zgzLfrrVZnhgpG/sKg5bUFO97QC43IerIlHHLByCdVejygKBILxVPuhBaNf49K7UiqDBZwV3x5M1gDU5rE+0X/kiFC0cmFjv6oa0v1JplQQ5OZpAue5Mubvx6nDBdiVuwXGvSnsmNHwLY172Md5IqvkXx7HASgkJ0Rn/tfErsgOtX2xNErQkdtr1mx7fyqXbKlOEMRh06sHV4FPYLyY6x53H6Es5qs7CWW5Z7y4B7T4EcZcBjngeLuMH8BMRy8DhO877tbhRDELBMWsgfb41drX2BrsAem12vPcaFVSUYCUHzdxsaJidoFnWO329P1AZRI/XyQf+dqngfUHIVH0kMpwHzG8azRbSDg04XKTWGm/YJIcc2LR/fFLZD6LLXy9OiMHWEIfwebb1m0i8MD3L9YlVY62JVfXgyGFKA2vEfwSg61Bc7k2qDDJ17IaABYGjoLdQVt4EeKAB7tVa63mKBvZf7dHueO2DKH2g1QgSI/5zjnL42DxnKrQuAWc50wcAnpTTGTsNgC97vKBQgaYP6cOdEOBScUk6NaNAwV2YDFDGVeNaOFDDQ==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(508600001)(6512007)(316002)(66476007)(66556008)(66946007)(91956017)(64756008)(4326008)(8676002)(76116006)(53546011)(6486002)(2616005)(5660300002)(6506007)(66446008)(186003)(71200400001)(26005)(82960400001)(38100700002)(31696002)(86362001)(8936002)(36756003)(6916009)(122000001)(2906002)(83380400001)(38070700005)(54906003)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?aFNNUlBpZklFYWI0eS9JY3lKQ3B4aVZ2Qy9TamNQRytJL2dUWk9iZ3ZPWWdP?=
 =?utf-8?B?c1M3dFI0MUhHQm1LT2tSTWMreWhEdWIyUjVhTmhQdEVLZnhlOU5CblRJdkpa?=
 =?utf-8?B?RzNRS0F2SUhWT0RuMWwzTmlCbjVPc2VlamVTazNQZWc4cXRuVjllNTNNdlJj?=
 =?utf-8?B?MFVGbC9DUTZyNWVnL1I1KzBidVlWdUQxQ0Z0bnJCcG45Ym9jSFhOenZJbTF5?=
 =?utf-8?B?bkZtbWJQUDRJQ1B0SDlaY3ZsVE9DaVJ2bDNURFVvcHZSNEloek9iemphWVgw?=
 =?utf-8?B?UkRIZm81N25pNHZkeW5rQ1loeHVDNHEzTE9MaUV0ZVdsSStNNDFmUGFiUmRN?=
 =?utf-8?B?WXN3M0tOQUdOUmtBNkkwbGkwT3M0NE5IWWhoeFNBNitwQU5TUVBpb1duZER4?=
 =?utf-8?B?MGYrN0JoMWIwNUFNSmpXY0UzMTNqc25URmpDZnJuKzhia3dWMGp1S25QYndz?=
 =?utf-8?B?ZkRoTGpWR08yUkdLaDhpVmswcnR4cGx3ZjlRUXF6OWJsU3pnL1NwVnNiMGk4?=
 =?utf-8?B?L0Jya3NOeDNOdWZoRXJSdFdlSTNmakFieXp4QS9ZUG12a3FRWHdaaGRYNENZ?=
 =?utf-8?B?ZFZDQ0Fkb2NpZEFxSUZRbDRVczR3a0pHb0JXQ2xhVVdlejhudzlxbEthODBK?=
 =?utf-8?B?eDJWQ1p2eGlwcjhJeEx0MUdLQkduMVdZMUljVjhYTWc4THlUdG5JQlRvNGV2?=
 =?utf-8?B?ZExRQ3oxWUNIZlhHYVk0VGtYaEl6TDdyUVhnSFlCa2FlOXBhYlJRSC82emU2?=
 =?utf-8?B?ckR3eVl5eXo5OTg0aFI4MVBmMVB5M1hyYUhQVjlvdzRXay9Xd1N5T29yTnZW?=
 =?utf-8?B?YlBtS0R5TFZYRElqdGVMc1EzelRqQW5KYm1hUHpNTFM2Vi9FZUZab25RNnBz?=
 =?utf-8?B?SUx3MHc5Vm1ZWmhzUlcyT0ZNSzhLMnI5U0htdW5pcDRYb3BWNWcyZ2p3Q0FB?=
 =?utf-8?B?MHZ0SDdvM1NUcGpJZFJDMEVQMzRIYWVsVVlpUXN6anBZK2V2eWZRaHlrZWMy?=
 =?utf-8?B?eDNwWVpSbjcrc0YzYmNsUEVNQW1lTXIxM1hoM2xuSkZ6dTE4L3dMQlIyTWFm?=
 =?utf-8?B?ZzJLTXlaQlpNUWFmK0pENHRtMU5hVUMrTUQ2bDRubHgyNThvbENXZ0Q5aVJN?=
 =?utf-8?B?aUtsR3g3a05NWFNWbEdPR09OVTF2VGM1UUZUZ0pzcU11Sy9OSzBYbVJvLzEw?=
 =?utf-8?B?TXU4UzZ0RHlyeFNMWTR6MXA1eGl5azRLQmdKRDVDV0dxeDJPNFVpUlRDb0RQ?=
 =?utf-8?B?Z0p3d0ZWK0c4TmNPZnJTSTBFcnFMZmVMcXFlTDJ0YW9Qd3VkazlpZHF1K3Az?=
 =?utf-8?B?L3FqVnlOUmZ2OEk4SHBVNkpwZnRZQ2FBK3RFZm5LcFVUeTBNR2FVdGhQeFhn?=
 =?utf-8?B?VlYvZTNaeHd6ZXJVZnhCMEp5SzRibUVWMU9TdUtJVmRNc0RqL0RCVTg3S05p?=
 =?utf-8?B?MGNYbTc5eU9EZjlJTHQ2Vm9iTHpEMnFBU0ovSXUydmp2SFhnRG1CelFiSXhS?=
 =?utf-8?B?cWpIVXdyVTgyV1lyak4wc3dnZTJUWWhVR2xLYmZXNkFnSis3alBhZEc1NHZp?=
 =?utf-8?B?a0tkVjg1L0FTM0swbnBUUWZsVUxzbHBtS1dLL25Xa01LRmtHY0ZMczJQK3pW?=
 =?utf-8?B?ZkU5eXpZVnI0NkpyU0dVSXV0V3grWW8zbGtMYmNwOHRGaEN3UlVMSmtHcDhE?=
 =?utf-8?B?MXZtaUduK0xPeTRXaTZLZ1lWTy9TTjF4VTlKVlRwd3RlMmZHdzE4c1orVHU0?=
 =?utf-8?B?Y0NQbytTMk5PU1NuWXFZT0NwNURhdHV3UHpSVnlQZzdQcm9XbjY5YzNJK3By?=
 =?utf-8?B?SVdSOEZZdS9TS2FkWGpadDV5VW9CdmV3cytnQXpPQkVZUmJKRktoZ05QU2tv?=
 =?utf-8?B?YnkzKzcrKy8zeURVajY5OUVuaVpVRll0aEJNSWF3OUhtaDc4NHpRWEpOUHVM?=
 =?utf-8?B?anY2WHJlZUhXUURQejdZM3lQVlNBeVM4azBMd2lKS09CU0JMeVh2SlY3RnZp?=
 =?utf-8?B?K0ZsbExDN1Y5d2x6NzNudmZ0TFI0RFdHeHZvSzc1SUw3SWFpOGhRek1URmZm?=
 =?utf-8?B?dmlJTW1GdXk1Sjduc0JNaVhORC9BcWYxNDlVN2FQWjdxNUx0cTc1OU10TjB4?=
 =?utf-8?B?QW43OXZDcG44d004TU1PcTN3VkVhaXFPN0JFeDVSajdKbHZUdFVzU3ErbVpm?=
 =?utf-8?B?cjE1eWZDMzd5YzJ1YTFLSnRCTFVSVHpiT0Irb3BCL3BnbmRqMm9rSGFXSDR3?=
 =?utf-8?B?cDlOaFZMall4Q0JJNllUbVRHMDdnPT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <A503DC3D223D74468CB4C0F80E571DE9@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 06911ca3-011c-48d2-baca-08d9f5f73aad
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Feb 2022 11:34:03.8733
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: kPwq5KfuJu3rcVcJ7/pTFAnRaKkZS5ywAjDkF70epzYJKckQoMkb7E4sBE7Dt8fupO6F7yHGS4JPWMFxdvavcTPYLTXoCYqhNj3Jth+q+aI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB3889
X-OriginatorOrg: citrix.com

T24gMjIvMDIvMjAyMiAxMTowMiwgQW5kcmV3IENvb3BlciB3cm90ZToNCj4gT24gMjIvMDIvMjAy
MiAxMDo1NCwgQW5kcmV3IENvb3BlciB3cm90ZToNCj4+IE9uIDIyLzAyLzIwMjIgMDk6MjksIEph
biBCZXVsaWNoIHdyb3RlOg0KPj4+IE9uIDIxLjAyLjIwMjIgMTk6MDMsIEFuZHJldyBDb29wZXIg
d3JvdGU6DQo+Pj4+IE1vc3QgSU9NTVUgaG9va3MgYXJlIGFscmVhZHkgYWx0Y2FsbCBmb3IgcGVy
Zm9ybWFuY2UgcmVhc29ucy4gIENvbnZlcnQgdGhlDQo+Pj4+IHJlc3Qgb2YgdGhlbSBzbyB3ZSBj
YW4gaGFyZGVuIGFsbCB0aGUgaG9va3MgaW4gQ29udHJvbCBGbG93IEludGVncml0eQ0KPj4+PiBj
b25maWd1cmF0aW9ucy4gIFRoaXMgbmVjZXNzaXRhdGVzIHRoZSB1c2Ugb2YgaW9tbXVfe3YsfWNh
bGwoKSBpbiBkZWJ1ZyBidWlsZHMNCj4+Pj4gdG9vLg0KPj4+Pg0KPj4+PiBNb3ZlIHRoZSByb290
IGlvbW11X29wcyBmcm9tIF9fcmVhZF9tb3N0bHkgdG8gX19yb19hZnRlcl9pbml0IG5vdyB0aGF0
IHRoZQ0KPj4+PiBsYXR0ZXIgZXhpc3RzLiAgVGhlcmUgaXMgbm8gbmVlZCBmb3IgYSBmb3J3YXJk
IGRlY2xhcmF0aW9uIG9mIHZ0ZF9vcHMgYW55DQo+Pj4+IG1vcmUsIG1lYW5pbmcgdGhhdCBfX2lu
aXRjb25zdF9jZl9jbG9iYmVyIGNhbiBiZSB1c2VkIGZvciBWVEQgYW5kIEFNRC4NCj4+PiBUaGUg
Y29ubmVjdGlvbiBiZXR3ZWVuIHRoZSBmb3J3YXJkIGRlY2xhcmF0aW9uIGFuZCB0aGUgYW5ub3Rh
dGlvbiBhZGRpdGlvbg0KPj4+IGlzbid0IHJlYWxseSBjbGVhciB0byBtZS4NCj4+Pg0KPj4+PiAt
LS0gYS94ZW4vYXJjaC94ODYvaW5jbHVkZS9hc20vaW9tbXUuaA0KPj4+PiArKysgYi94ZW4vYXJj
aC94ODYvaW5jbHVkZS9hc20vaW9tbXUuaA0KPj4+PiBAQCAtNzIsNyArNzIsNiBAQCBzdHJ1Y3Qg
YXJjaF9pb21tdQ0KPj4+PiAgDQo+Pj4+ICBleHRlcm4gc3RydWN0IGlvbW11X29wcyBpb21tdV9v
cHM7DQo+Pj4+ICANCj4+Pj4gLSNpZmRlZiBOREVCVUcNCj4+Pj4gICMgaW5jbHVkZSA8YXNtL2Fs
dGVybmF0aXZlLmg+DQo+Pj4+ICAjIGRlZmluZSBpb21tdV9jYWxsKG9wcywgZm4sIGFyZ3MuLi4p
ICh7ICAgICAgXA0KPj4+PiAgICAgICh2b2lkKShvcHMpOyAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgIFwNCj4+Pj4gQEAgLTgzLDcgKzgyLDYgQEAgZXh0ZXJuIHN0cnVjdCBpb21tdV9vcHMg
aW9tbXVfb3BzOw0KPj4+PiAgICAgICh2b2lkKShvcHMpOyAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgIFwNCj4+Pj4gICAgICBhbHRlcm5hdGl2ZV92Y2FsbChpb21tdV9vcHMuZm4sICMjIGFy
Z3MpOyBcDQo+Pj4+ICB9KQ0KPj4+PiAtI2VuZGlmDQo+Pj4+ICANCj4+Pj4gIHN0YXRpYyBpbmxp
bmUgY29uc3Qgc3RydWN0IGlvbW11X29wcyAqaW9tbXVfZ2V0X29wcyh2b2lkKQ0KPj4+PiAgew0K
Pj4+PiBAQCAtMTA2LDcgKzEwNCw3IEBAIGludCBpb21tdV9zZXR1cF9ocGV0X21zaShzdHJ1Y3Qg
bXNpX2Rlc2MgKik7DQo+Pj4+ICBzdGF0aWMgaW5saW5lIGludCBpb21tdV9hZGp1c3RfaXJxX2Fm
ZmluaXRpZXModm9pZCkNCj4+Pj4gIHsNCj4+Pj4gICAgICByZXR1cm4gaW9tbXVfb3BzLmFkanVz
dF9pcnFfYWZmaW5pdGllcw0KPj4+PiAtICAgICAgICAgICA/IGlvbW11X29wcy5hZGp1c3RfaXJx
X2FmZmluaXRpZXMoKQ0KPj4+PiArICAgICAgICAgICA/IGlvbW11X2NhbGwoaW9tbXVfb3BzLCBh
ZGp1c3RfaXJxX2FmZmluaXRpZXMpDQo+Pj4gV2hpbGUgdGhpcyAoYW5kIG90aGVyIGluc3RhbmNl
cyBiZWxvdykgaXMgeDg2LW9ubHkgY29kZSwgd2hlcmUgLSB3aXRoDQo+Pj4gdGhlIHJlbW92YWwg
b2YgdGhlICNpZmRlZiBhYm92ZSAtIHdlIG5vdyBrbm93IHRoZSBmaXJzdCBhcmd1bWVudCBpcw0K
Pj4+IGFsd2F5cyBpZ25vcmVkLCBJIHRoaW5rIGl0IHdvdWxkIHN0aWxsIGJldHRlciBiZSBvZiB0
aGUgY29ycmVjdCB0eXBlDQo+Pj4gKCZpb21tdV9vcHMpLiBQZXJoYXBzIHRoZSAiKHZvaWQpKG9w
cykiIGluIHRoZSBtYWNybyBkZWZpbml0aW9ucyB3b3VsZA0KPj4+IGJldHRlciBiZWNvbWUgIkFT
U0VSVCgob3BzKSA9PSAmaW9tbXVfb3BzKSIsIHdoaWNoIHdvdWxkIGNoZWNrIGJvdGgNCj4+PiB0
eXBlIChjb21waWxlIHRpbWUpIGFuZCB2YWx1ZSAocnVudGltZSkuDQo+PiBJJ20gaGFwcHkgdG8g
Zm9sZCB0aGF0IGNoYW5nZSBpZiB5b3Ugd2FudC7CoCBJdCBvdWdodCB0byBvcHRpbWlzZSBvdXQN
Cj4+IGNvbXBsZXRlbHkgZm9yIGJlaW5nDQo+IEJhaCAtIHNlbnQgdG9vIGVhcmx5LsKgICJmb3Ig
YmVpbmcgdGF1dG9sb2dpY2FsLiINCg0KU2FkbHksIGl0IHR1cm5zIG91dCBpdCdzIG5vdC4NCg0K
JCAuLi9zY3JpcHRzL2Jsb2F0LW8tbWV0ZXIgLWMgeGVuLXN5bXMtYmVmb3JlIHhlbi1zeW1zLWFm
dGVyDQphZGQvcmVtb3ZlOiAwLzAgZ3Jvdy9zaHJpbms6IDEzLzAgdXAvZG93bjogMzY5LzAgKDM2
OSkNCkZ1bmN0aW9uwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIG9sZMKgwqDCoMKgIG5ld8KgwqAgZGVsdGENCnBj
aV9hZGRfZGV2aWNlwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoCAxMzUywqDCoMKgIDE0MTbCoMKgwqDCoCArNjQNCnBjaV9yZW1vdmVfZGV2
aWNlwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
IDcxNsKgwqDCoMKgIDc2McKgwqDCoMKgICs0NQ0KaW9tbXVfbWFwwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAzNDHC
oMKgwqDCoCAzODLCoMKgwqDCoCArNDENCmlvbW11X2RvX3BjaV9kb21jdGzCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgMTY2NsKgwqDCoCAxNzA0wqDCoMKg
wqAgKzM4DQppb21tdV91bm1hcMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAyNzbCoMKgwqDCoCAzMTDCoMKgwqDCoCArMzQN
CmRlYXNzaWduX2RldmljZcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqAgMzUzwqDCoMKgwqAgMzg2wqDCoMKgwqAgKzMzDQppb21tdV9mcmVl
X3BndGFibGVzwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqAgMzEwwqDCoMKgwqAgMzI5wqDCoMKgwqAgKzE5DQppb21tdV9pb3RsYl9mbHVzaF9hbGzCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIDE4McKgwqDCoMKgIDE5
OcKgwqDCoMKgICsxOA0KaW9tbXVfaW90bGJfZmx1c2jCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgMjYwwqDCoMKgwqAgMjc4wqDCoMKgwqAgKzE4
DQppb21tdV9od2RvbV9pbml0wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoCA2OMKgwqDCoMKgwqAgODbCoMKgwqDCoCArMTgNCmlvbW11X2Rv
bWFpbl9kZXN0cm95wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqAgNTTCoMKgwqDCoMKgIDcwwqDCoMKgwqAgKzE2DQppb21tdV9sb29rdXBfcGFnZcKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIDUzwqDC
oMKgwqDCoCA2N8KgwqDCoMKgICsxNA0KaW9tbXVfZHVtcF9wYWdlX3RhYmxlc8KgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIDI2McKgwqDCoMKgIDI3MsKgwqDCoMKg
ICsxMQ0KVG90YWw6IEJlZm9yZT0yMTk0NzU2LCBBZnRlcj0yMTk1MTI1LCBjaGcgKzAuMDIlDQph
ZGQvcmVtb3ZlOiAwLzAgZ3Jvdy9zaHJpbms6IDAvMCB1cC9kb3duOiAwLzAgKDApDQpEYXRhwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqAgb2xkwqDCoMKgwqAgbmV3wqDCoCBkZWx0YQ0KVG90YWw6IEJl
Zm9yZT0xNjk5Mzg0LCBBZnRlcj0xNjk5Mzg0LCBjaGcgKzAuMDAlDQphZGQvcmVtb3ZlOiAwLzAg
Z3Jvdy9zaHJpbms6IDAvMCB1cC9kb3duOiAwLzAgKDApDQpSTyBEYXRhwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqAgb2xkwqDCoMKgwqAgbmV3wqDCoCBkZWx0YQ0KVG90YWw6IEJlZm9yZT0wLCBBZnRlcj0wLCBj
aGcgKzAuMDAlDQoNCmlzIHRoZSBkZWx0YSBpbiBkZWJ1ZyBidWlsZHMsIHdoaWxlDQoNCiQgLi4v
c2NyaXB0cy9ibG9hdC1vLW1ldGVyIC1jIHhlbi1zeW1zLWJlZm9yZSB4ZW4tc3ltcy1hZnRlcg0K
YWRkL3JlbW92ZTogMC8wIGdyb3cvc2hyaW5rOiAwLzMgdXAvZG93bjogMC8tNTcgKC01NykNCkZ1
bmN0aW9uwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgIG9sZMKgwqDCoMKgIG5ld8KgwqAgZGVsdGENCmlvbW11X3Jl
c3VtZcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoCAzNMKgwqDCoMKgwqAgMTbCoMKgwqDCoCAtMTgNCmlvbW11X3N1c3BlbmTC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgIDQywqDCoMKgwqDCoCAyM8KgwqDCoMKgIC0xOQ0KaW9tbXVfY3Jhc2hfc2h1dGRvd27C
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCA2NsKgwqDC
oMKgwqAgNDbCoMKgwqDCoCAtMjANClRvdGFsOiBCZWZvcmU9MjExMjI2MSwgQWZ0ZXI9MjExMjIw
NCwgY2hnIC0wLjAwJQ0KYWRkL3JlbW92ZTogMC8wIGdyb3cvc2hyaW5rOiAwLzAgdXAvZG93bjog
MC8wICgwKQ0KRGF0YcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIG9sZMKgwqDCoMKgIG5ld8KgwqAg
ZGVsdGENClRvdGFsOiBCZWZvcmU9MTcwOTQyNCwgQWZ0ZXI9MTcwOTQyNCwgY2hnICswLjAwJQ0K
YWRkL3JlbW92ZTogMC8wIGdyb3cvc2hyaW5rOiAwLzAgdXAvZG93bjogMC8wICgwKQ0KUk8gRGF0
YcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgIG9sZMKgwqDCoMKgIG5ld8KgwqAgZGVsdGENClRvdGFsOiBCZWZv
cmU9MCwgQWZ0ZXI9MCwgY2hnICswLjAwJQ0KDQppcyB0aGUgZGVsdGEgaW4gcmVsZWFzZSBidWls
ZHMuwqAgVGhpcyBpcyBhIGxpdHRsZSB3ZWlyZCAtIGl0J3MgYmVjYXVzZQ0KdGhlIEFTU0VSVCgp
LCBpbiByZWxlYXNlIGJ1aWxkcywgc2hvcnQgY2lyY3VpdHMgdGhlIGV2YWx1YXRpb24gb2YgaXRz
DQpjb25kaXRpb24sIG1lYW5pbmcgdGhhdCB0aGUgQlVHX09OKCkgaW5zaWRlIGlvbW11X2dldF9v
cHMoKSBkb2Vzbid0IGdldA0KZW1pdHRlZC4NCg0KSXJyaXRhdGluZ2x5LCB0aGVyZSdzIG5vIHdh
eSBJIGNhbiBzcG90IHRvIGRvIHRoaXMgY2hlY2sgd2l0aCBhDQpCVUlMRF9CVUdfT04oKSwgd2hp
Y2ggd291bGQgcmVkdWNlIHRoZSBpbXBhY3Qgb24gdGhlIGRlYnVnIGJ1aWxkcyB0b28uDQoNCn5B
bmRyZXcNCg==


From xen-devel-bounces@lists.xenproject.org Tue Feb 22 11:47:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 11:47:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276733.473003 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMTdv-0002s7-Gi; Tue, 22 Feb 2022 11:47:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276733.473003; Tue, 22 Feb 2022 11:47:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMTdv-0002s0-Dp; Tue, 22 Feb 2022 11:47:43 +0000
Received: by outflank-mailman (input) for mailman id 276733;
 Tue, 22 Feb 2022 11:47:42 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Woib=TF=citrix.com=prvs=045a4fa17=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nMTdu-0002ru-Bh
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 11:47:42 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 3c86a0d2-93d5-11ec-8eb8-a37418f5ba1a;
 Tue, 22 Feb 2022 12:47:40 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3c86a0d2-93d5-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645530460;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=phlUwsbqZvFVhfGNXBd5y7pzy7ybOvyPQbyz9iOge1U=;
  b=MniVbrbiF/SdxGUhosJjO7MaO2tQKUcrSwGcDwUdw83W6SVeymO1HTGP
   KiXFGZ4d9G5ujFM6GA2YsOQdD2BxKQ4fU5vnUZWtsMoXrEJ9LTMx/IVGX
   7Mi8oobJf7zFMsoUbP+ajSkTqCUCh/dy+5VmSgkLa5XLlZTfGiQkh7r7R
   M=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 64714683
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:6VkjBa4ujwyjwA84a0SU2AxRtD3HchMFZxGqfqrLsTDasY5as4F+v
 mdLDzuBaP3eZmPweNB/ad+19UwE6pTRz9ZiGQQ5qilgHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFx2XqPp8Zj2tQy2YLjWVvX0
 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X
 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx
 umhurSIb1YzArXymt5NeCMEIiZiIfRW0ZnIdC3XXcy7lyUqclPpyvRqSko3IZcZ6qB8BmQmG
 f4wcW5XKErZ3qTvnez9GrIEascLdaEHOKs2vH16wC6fJvEhWZ3ZGI3B5MNC3Sd2jcdLdRrbT
 5RFNmMzMkSbC/FJEnsSUZEGwLypuinAXgFUimiV9e0u40GGmWSd15CyaYGIK7RmX/59gUKwt
 m/AuWPjDXkyFvaS1D6E+XKEnfLUkGXwX4d6PK218LtmjUOewkQXCQYKTh2rrP+hkEm8VtlDb
 UsO9UITQbMarRLxCIOnBlvh/SDC7kV0t8ds//MS0Cfc0JbM3QSjVkM+Eg9GdMB/pOYQSml/v
 rOWpO/BCTtqubyTbHuS8LaIsD+/URQowX8+iTwsFlVcvYS6yG0npleWF4s4Tvbp5jHgMWyom
 1i3QD4Ca6L/ZCLh/4Gy5hj5jj2lvfAlpSZlt1yMDgpJAu6UDbNJhrBEC3CGtZ6sz67DFzFtW
 UTofeDEt4ji6rnXyUSwrB0lRu3B2hp8GGS0baRTN5cg7S+x3HWoYJpd5jpzTG8wbJpZJWG4P
 RKJ5VoJjHO2AJdMRfUsC25WI553pZUM6Py/DqyEBjawSsIZmPC7ENFGOhfLgjGFfLkEmqAjI
 5aLGftA/l5BYZmLOAGeHr9HuZdyn3hW7TqKGfjTkkT2uZLDNSX9YepUbzOzghURsfrsTPP9q
 I0EaaNnCnx3DYXDX8Ug2dRNdQtTdSBjX/gbaaV/L4a+H+avI0l5Y9e5/F/rU9UNc3h9/gsQw
 kyAZw==
IronPort-HdrOrdr: A9a23:e7ppQ6/l/7OFj9/9Y1xuk+DgI+orL9Y04lQ7vn2YSXRuHPBw8P
 re5cjztCWE7gr5N0tBpTntAsW9qDbnhPtICOoqTNCftWvdyQiVxehZhOOIqVDd8m/Fh4pgPM
 9bAtBD4bbLbGSS4/yU3ODBKadD/OW6
X-IronPort-AV: E=Sophos;i="5.88,387,1635220800"; 
   d="scan'208";a="64714683"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>
Subject: [PATCH v2.2 8/7] x86/IOMMU: Use altcall, and __initconst_cf_clobber
Date: Tue, 22 Feb 2022 11:47:11 +0000
Message-ID: <20220222114711.19209-1-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220214125632.24563-1-andrew.cooper3@citrix.com>
References: <20220214125632.24563-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

Most IOMMU hooks are already altcall for performance reasons.  Convert the
rest of them so we can harden all the hooks in Control Flow Integrity
configurations.  This necessitates the use of iommu_{v,}call() in debug builds
too.  Switch to using an ASSERT() as all forms should resolve to &iommu_ops.

Move the root iommu_ops from __read_mostly to __ro_after_init now that the
latter exists.

Since c/s 3330013e6739 ("VT-d / x86: re-arrange cache syncing"), vtd_ops is
not modified and doesn't need a forward declaration, so we can use
__initconst_cf_clobber for both VT-d and AMD.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>

v2.1:
 * New
v2.2:
 * Add ASSERT().  Fix indirection of the passed pointer in enable_x2apic().
 * Adjust commit message.
---
 xen/arch/x86/include/asm/iommu.h            | 10 ++++------
 xen/drivers/passthrough/amd/pci_amd_iommu.c |  2 +-
 xen/drivers/passthrough/iommu.c             |  7 ++++---
 xen/drivers/passthrough/vtd/iommu.c         |  3 +--
 xen/drivers/passthrough/x86/iommu.c         |  4 ++--
 5 files changed, 12 insertions(+), 14 deletions(-)

diff --git a/xen/arch/x86/include/asm/iommu.h b/xen/arch/x86/include/asm/iommu.h
index 8a96ba1f097f..d38c33408766 100644
--- a/xen/arch/x86/include/asm/iommu.h
+++ b/xen/arch/x86/include/asm/iommu.h
@@ -72,18 +72,16 @@ struct arch_iommu
 
 extern struct iommu_ops iommu_ops;
 
-#ifdef NDEBUG
 # include <asm/alternative.h>
 # define iommu_call(ops, fn, args...) ({      \
-    (void)(ops);                              \
+    ASSERT((ops) == &iommu_ops);              \
     alternative_call(iommu_ops.fn, ## args);  \
 })
 
 # define iommu_vcall(ops, fn, args...) ({     \
-    (void)(ops);                              \
+    ASSERT((ops) == &iommu_ops);              \
     alternative_vcall(iommu_ops.fn, ## args); \
 })
-#endif
 
 static inline const struct iommu_ops *iommu_get_ops(void)
 {
@@ -106,7 +104,7 @@ int iommu_setup_hpet_msi(struct msi_desc *);
 static inline int iommu_adjust_irq_affinities(void)
 {
     return iommu_ops.adjust_irq_affinities
-           ? iommu_ops.adjust_irq_affinities()
+           ? iommu_call(&iommu_ops, adjust_irq_affinities)
            : 0;
 }
 
@@ -122,7 +120,7 @@ int iommu_enable_x2apic(void);
 static inline void iommu_disable_x2apic(void)
 {
     if ( x2apic_enabled && iommu_ops.disable_x2apic )
-        iommu_ops.disable_x2apic();
+        iommu_vcall(&iommu_ops, disable_x2apic);
 }
 
 int iommu_identity_mapping(struct domain *d, p2m_access_t p2ma,
diff --git a/xen/drivers/passthrough/amd/pci_amd_iommu.c b/xen/drivers/passthrough/amd/pci_amd_iommu.c
index e57f555d00d1..4b59a4efe9b6 100644
--- a/xen/drivers/passthrough/amd/pci_amd_iommu.c
+++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c
@@ -628,7 +628,7 @@ static void cf_check amd_dump_page_tables(struct domain *d)
                               hd->arch.amd.paging_mode, 0, 0);
 }
 
-static const struct iommu_ops __initconstrel _iommu_ops = {
+static const struct iommu_ops __initconst_cf_clobber _iommu_ops = {
     .init = amd_iommu_domain_init,
     .hwdom_init = amd_iommu_hwdom_init,
     .quarantine_init = amd_iommu_quarantine_init,
diff --git a/xen/drivers/passthrough/iommu.c b/xen/drivers/passthrough/iommu.c
index e220fea72c2f..c6b2c384d1dd 100644
--- a/xen/drivers/passthrough/iommu.c
+++ b/xen/drivers/passthrough/iommu.c
@@ -540,7 +540,7 @@ int __init iommu_setup(void)
 int iommu_suspend()
 {
     if ( iommu_enabled )
-        return iommu_get_ops()->suspend();
+        return iommu_call(iommu_get_ops(), suspend);
 
     return 0;
 }
@@ -548,7 +548,7 @@ int iommu_suspend()
 void iommu_resume()
 {
     if ( iommu_enabled )
-        iommu_get_ops()->resume();
+        iommu_vcall(iommu_get_ops(), resume);
 }
 
 int iommu_do_domctl(
@@ -578,7 +578,8 @@ void iommu_crash_shutdown(void)
         return;
 
     if ( iommu_enabled )
-        iommu_get_ops()->crash_shutdown();
+        iommu_vcall(iommu_get_ops(), crash_shutdown);
+
     iommu_enabled = false;
 #ifndef iommu_intremap
     iommu_intremap = iommu_intremap_off;
diff --git a/xen/drivers/passthrough/vtd/iommu.c b/xen/drivers/passthrough/vtd/iommu.c
index 56968a06a100..6a65ba1d8271 100644
--- a/xen/drivers/passthrough/vtd/iommu.c
+++ b/xen/drivers/passthrough/vtd/iommu.c
@@ -56,7 +56,6 @@ bool __read_mostly iommu_snoop = true;
 
 static unsigned int __read_mostly nr_iommus;
 
-static struct iommu_ops vtd_ops;
 static struct tasklet vtd_fault_tasklet;
 
 static int cf_check setup_hwdom_device(u8 devfn, struct pci_dev *);
@@ -2794,7 +2793,7 @@ static int __init cf_check intel_iommu_quarantine_init(struct domain *d)
     return rc;
 }
 
-static struct iommu_ops __initdata vtd_ops = {
+static const struct iommu_ops __initconst_cf_clobber vtd_ops = {
     .init = intel_iommu_domain_init,
     .hwdom_init = intel_iommu_hwdom_init,
     .quarantine_init = intel_iommu_quarantine_init,
diff --git a/xen/drivers/passthrough/x86/iommu.c b/xen/drivers/passthrough/x86/iommu.c
index ad5f44e13d98..58a422fb5f88 100644
--- a/xen/drivers/passthrough/x86/iommu.c
+++ b/xen/drivers/passthrough/x86/iommu.c
@@ -27,7 +27,7 @@
 #include <asm/setup.h>
 
 const struct iommu_init_ops *__initdata iommu_init_ops;
-struct iommu_ops __read_mostly iommu_ops;
+struct iommu_ops __ro_after_init iommu_ops;
 bool __read_mostly iommu_non_coherent;
 
 enum iommu_intremap __read_mostly iommu_intremap = iommu_intremap_full;
@@ -129,7 +129,7 @@ int iommu_enable_x2apic(void)
     if ( !iommu_ops.enable_x2apic )
         return -EOPNOTSUPP;
 
-    return iommu_ops.enable_x2apic();
+    return iommu_call(&iommu_ops, enable_x2apic);
 }
 
 void iommu_update_ire_from_apic(
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Tue Feb 22 12:00:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 12:00:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276741.473014 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMTq6-0005B5-TQ; Tue, 22 Feb 2022 12:00:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276741.473014; Tue, 22 Feb 2022 12:00:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMTq6-0005Ay-Ol; Tue, 22 Feb 2022 12:00:18 +0000
Received: by outflank-mailman (input) for mailman id 276741;
 Tue, 22 Feb 2022 12:00:17 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=N+X7=TF=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nMTq5-0005AY-IP
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 12:00:17 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id dced82b7-93d6-11ec-8539-5f4723681683;
 Tue, 22 Feb 2022 12:59:18 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 40C8C2111A;
 Tue, 22 Feb 2022 12:00:14 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1974713BA0;
 Tue, 22 Feb 2022 12:00:14 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id VoR2BE7QFGKpLgAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 22 Feb 2022 12:00:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dced82b7-93d6-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1645531214; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=6BLb5XcbqZJtIcPXPva2CifELU1+vhtfmhwJQnQI+JU=;
	b=u6QI7nUAAYKc6EuB54do5upbsxnlTmmHfcDm0imKOzNn2I5TraVihxr4Kvl6ADb3XL+lT9
	tBNE+q97/D1fZz6E/Js2iGwCrJASlJZk0WZGE/72p0AEGXVijpKU6v170r62xjYJG0K5Ct
	fFya2JfLSobJ69hEdcwDshI0+TG8/2s=
Message-ID: <255e0ec0-f149-57a5-e427-c08e4e4ac089@suse.com>
Date: Tue, 22 Feb 2022 13:00:13 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH] xen: use helper macro __ATTR_RW
Content-Language: en-US
To: Miaohe Lin <linmiaohe@huawei.com>, boris.ostrovsky@oracle.com
Cc: sstabellini@kernel.org, xen-devel@lists.xenproject.org,
 linux-kernel@vger.kernel.org
References: <20220222111222.56877-1-linmiaohe@huawei.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <20220222111222.56877-1-linmiaohe@huawei.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------av7j8gkw3ZknX8slXpyTRAQc"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------av7j8gkw3ZknX8slXpyTRAQc
Content-Type: multipart/mixed; boundary="------------O0AnTHRyLwSCFZmZzLZB8kvb";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Miaohe Lin <linmiaohe@huawei.com>, boris.ostrovsky@oracle.com
Cc: sstabellini@kernel.org, xen-devel@lists.xenproject.org,
 linux-kernel@vger.kernel.org
Message-ID: <255e0ec0-f149-57a5-e427-c08e4e4ac089@suse.com>
Subject: Re: [PATCH] xen: use helper macro __ATTR_RW
References: <20220222111222.56877-1-linmiaohe@huawei.com>
In-Reply-To: <20220222111222.56877-1-linmiaohe@huawei.com>

--------------O0AnTHRyLwSCFZmZzLZB8kvb
Content-Type: multipart/mixed; boundary="------------c9jPJK05xZt7K9BVP0wUq03m"

--------------c9jPJK05xZt7K9BVP0wUq03m
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMjIuMDIuMjIgMTI6MTIsIE1pYW9oZSBMaW4gd3JvdGU6DQo+IFVzZSBoZWxwZXIgbWFj
cm8gX19BVFRSX1JXIHRvIGRlZmluZSBoeXBfc3lzZnNfYXR0ciB0byBtYWtlIGNvZGUgbW9y
ZQ0KPiBjbGVhci4gTWlub3IgcmVhZGFiaWxpdHkgaW1wcm92ZW1lbnQuDQo+IA0KPiBTaWdu
ZWQtb2ZmLWJ5OiBNaWFvaGUgTGluIDxsaW5taWFvaGVAaHVhd2VpLmNvbT4NCg0KUmV2aWV3
ZWQtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4NCg0KDQpKdWVyZ2VuDQo=

--------------c9jPJK05xZt7K9BVP0wUq03m
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------c9jPJK05xZt7K9BVP0wUq03m--

--------------O0AnTHRyLwSCFZmZzLZB8kvb--

--------------av7j8gkw3ZknX8slXpyTRAQc
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmIU0E0FAwAAAAAACgkQsN6d1ii/Ey8p
pQf7BTCdL1oioe61gyPLVoGdBlXS35F8/zIB/arzqcp6jVq7tMIh08sf2fUbBNj3zXK08fnbCiJk
c52NUUHfIOFCHJYr/Lu+Mjdl1QwkmZ4IW9d9Ez6dH5me5oU2xj6r0sf17Dufu2eLw8ZJpfbBNgFM
hmf4jv8j2r04dNBXXRLYor8EeJsNM6HGGGZbFr58K6sPWuPZmTH1IFRbFQ1PWRq/24/mE0D4ukFP
XpESILrQI8b2tR/wAKRfhcQsY7/n7WQRK7FO2CnQkY0H6jvIpZOVdwvoY3DWXiK1rZvbyRMfpMY1
khzEadik9eeuznzydmbhkqoJ4TgBbzTjJKcgLWNZYQ==
=E2UA
-----END PGP SIGNATURE-----

--------------av7j8gkw3ZknX8slXpyTRAQc--


From xen-devel-bounces@lists.xenproject.org Tue Feb 22 12:10:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 12:10:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276751.473025 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMU01-0006gb-Qo; Tue, 22 Feb 2022 12:10:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276751.473025; Tue, 22 Feb 2022 12:10:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMU01-0006gU-NV; Tue, 22 Feb 2022 12:10:33 +0000
Received: by outflank-mailman (input) for mailman id 276751;
 Tue, 22 Feb 2022 12:10:32 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=QzH2=TF=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nMU00-0006gO-74
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 12:10:32 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4c466d01-93d8-11ec-8539-5f4723681683;
 Tue, 22 Feb 2022 13:09:34 +0100 (CET)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2050.outbound.protection.outlook.com [104.47.12.50]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-29--tQ7vCIIOzyVDo8zK9234Q-1; Tue, 22 Feb 2022 13:10:29 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by PAXPR04MB9254.eurprd04.prod.outlook.com (2603:10a6:102:2bc::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.26; Tue, 22 Feb
 2022 12:10:28 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.4995.027; Tue, 22 Feb 2022
 12:10:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4c466d01-93d8-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645531830;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=EMSs3Mnykf+UVOFzLYEo/yZydukXZAZCFOlc+Trqxms=;
	b=AkMRoeYWRItECvdyMwT0n/6Br/naOztSfOF3OJ6e9xnVVi/NTs+DsKR6NoYlIJHaDaS1k0
	nfaE6HsXTA2VqbFegFBXRij3m76twhdEOr6qfZeeJ8OHKFnmnjP4Y/hg5d5U3LqsBq3p8l
	iNHehBfjKinkxEBwV79oh3i3Vev1G60=
X-MC-Unique: -tQ7vCIIOzyVDo8zK9234Q-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=IH+OBYVTQ+6+S5mKAPRp+zV6HtAlpCNLRLMgW5MeEIGS4CpA0EB9jxpMm69cdjxYxaZPVvFDg/X0wZ4Si32aNACglV3mMniRdnd9oW7K9gH+Tj6GhjN8EA+TVZcCT57HVYZd1oXzzNb3KbVnNpVpRveM16qdgI99ty4enQ4jZJI/u9IHkezvogf2f0TuaIq6SCVaDH2nXfMQ+yJ79Io43772ySW1DhDe79LPaO+NHzE5qNqzHtZ1TMhH8tBq2cCLcZ9KN2btuxNS2yHnX2DKITH82t/Jz9xyILl2wkj3FV7UXHtJmKZ4RwecvvZmNZhnIVIzU4T7mpu+VLDymdVezw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=EMSs3Mnykf+UVOFzLYEo/yZydukXZAZCFOlc+Trqxms=;
 b=Mdh40Yj6N0FLEizutUbQktv+bdLW/2dXeC08MfgE9mo2HTHC0eQepHyO4XssH02QguU4UESwqLtocB4W2i/yjD7I4M4zk/dfwrvB6yX3SUOCianRePWfqglR+H5nGU4F8zbBSWcno0GYa80eLCzM/4EmiD0Y4YqNyEmrT5ud54fDTnYNNMPmqa26aRatRZfY/K8ZeaBTa4DuLWmm2xVGeJpzPLOjxIOgU+Eh2W6YypreqfpFO7iBwl9AIyUapwGjQEwM8PHpdrSErtwu1h1kmfd4PLpfwuHjSuDJvpcj9/hLxeVZRGzIHlMu0Vp56711HKiy5i2nzJu0hTjSv09QlA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <877ea1c3-d542-de98-3863-86f559f4f6cc@suse.com>
Date: Tue, 22 Feb 2022 13:10:25 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v2.2 8/7] x86/IOMMU: Use altcall, and
 __initconst_cf_clobber
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20220214125632.24563-1-andrew.cooper3@citrix.com>
 <20220222114711.19209-1-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220222114711.19209-1-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR02CA0036.eurprd02.prod.outlook.com
 (2603:10a6:20b:6e::49) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 35494f43-8a74-4a41-26e1-08d9f5fc5039
X-MS-TrafficTypeDiagnostic: PAXPR04MB9254:EE_
X-Microsoft-Antispam-PRVS:
	<PAXPR04MB9254CF79703FCEF15CE2ADF1B33B9@PAXPR04MB9254.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Ohj9JscMkeRwyJUyuvccPqK/Zdtlt09TJ5NGGejQIdL3HX0j83q92B2CgQVTfQ9sQddTfRx62qe5hOb0NYAJakZlaivf/vhV9Z28PkwPRcADXIsye+DanJf2hSdd9FsgAkSzvrUWwwRb4q4XEC4xe7GTOc5Wb15Sgwx4BfHcPrSlPbbp8+MQ+6aeQnKxgMK4i0IQ6EGGg8kN5AROjSu0iKbkBxuHSNKPvPQ52PFgGMQYit1Pq146mVAcpq8On3yOUqwifXlQtrGYkDnCOJ4nCvOrTSSNMmiD5++ZE9OKFIIeT4N0A1ujGGOA8jS197nHNvD0IYUg2yClzfToj9bZSN8THEa31RHdGjE9fsWD5SrxzEr3pUybmdt+8btHael1UtD1xe/4AppeOgRO37zX4fYC36e2j6il3vIg7XG1r6Ny1Q22JrTkc+a7nCEo4vKjl61xoIUyOYrcNnANPcw57TXc+CpDP9g3NMxW0b1EEnZf4JemMJJeP9GsjsRKB1nLHMV7FaYCbtcrzpg0SmEKIxC5RqqLrrzTPlqZ7OJioOR6NLJAfzxjtnEsr3p55+PGdZ1Gyfq9lS/jHC3bYQZEKorSIKIFfffeVbaOKU/FpilycACkruQ8HcdzM5gYCJOvpflGEy53IL8l0KTLqgutQrjT6PoCaFekegpoYBQdnxmDLM6UFE5+SoA29NxipDwCFM9VHDyz6rCG7ezB8i0/bs9LQmxJPWCcJmX2B8W7ccs=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6506007)(6512007)(6486002)(6916009)(53546011)(316002)(508600001)(54906003)(2906002)(31686004)(2616005)(36756003)(4326008)(8676002)(186003)(26005)(4744005)(66946007)(66476007)(66556008)(8936002)(31696002)(86362001)(5660300002)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?WDRnK2I2UUdNQTNXRmNUYSsxakdQTnRYZDJnaW9UVklrYk9TVFQvRmFFTnRM?=
 =?utf-8?B?TFV0SUQ0SDJ3SkU0L2loWDQxRUpOYlBOYTQ0Q05xY3NnbnBCNXF4VTl5STdz?=
 =?utf-8?B?N2NCbUZCZ1c0dWlFNDJOM3JmMGV1T3h4RVVhVmlWdmJ5MWY2NXRLMnQ2Nmlz?=
 =?utf-8?B?b2wvUFpMTWI5TjFOTFdIaW1uUTM0RW1wa1E5VFZSSVd4V1FNNnl0YVBUdmNR?=
 =?utf-8?B?T2dYSzhWYVNaaVJZdlg3M0pUakxEVGI5ZkRIZ3BITWtNdGI0MGJjSlhQS0xs?=
 =?utf-8?B?WDE2ZUdQK0gzaUlEWjlqZ2d1aVpGQlNTVWJ1bWdQc2grbXR6d0poZ2tIWEdF?=
 =?utf-8?B?RnVaSGJBcWY3OXNqZnFxRG0wdXUvWEFadzFhMjJiK0Zqd3pKWEpFdC9hazhJ?=
 =?utf-8?B?Q2hhcXgyNkFGR3NpZkRwNEZaS3dnVHhwTFRLWFJ3Z3pPU3hOQU1pRi9TcWc0?=
 =?utf-8?B?alBSYnE5QUJUUXN0Y1N1bmhYTzdveHZiUDJ4K1QySWMzMCt3WndvWVZObVA2?=
 =?utf-8?B?M21EaTAvWlRpYkFLQVMybDBzeTFPMGxxSFNxdkovYUR2VGJiQkJnSlZURzVi?=
 =?utf-8?B?ZFRoVGFmTDR0SU9TODRncHlqM0NJQmdsdkdwYTk4ZUk4QWxHM1JJN0V0RnY4?=
 =?utf-8?B?djY3MXJwZUFFeDU2eDV5UTBPUWVTWDF5Tm1yM0FBeVlBd0JoNHNkaWNWaE8r?=
 =?utf-8?B?RWlsUThCcEdYMnVFWmtlMEowWGNWMHFWVEU2NG53N1cyL2lXeXgybngwZjhI?=
 =?utf-8?B?SGxXZlR6SHA5NzRxSDk3NmRIdys4Uys2QzM1emR6dDc5VTdqU2ovcEpUanlz?=
 =?utf-8?B?d2NwYWF1dUFBSExsaTA0S1E2WWF0OG10ZUcvZ3RnOFdQTFpNS2NGeUFDRURj?=
 =?utf-8?B?SFJmQVdvenYxR29JZVArZ1lldTdTRjJMVnFCY2l5YUJ5R21vNEVYdk00ZG4y?=
 =?utf-8?B?V21GS00zSG5UZU5sL1k4SHNjU1hXMjZwK0VwU0lYVlZvcEd2bUV5UGk2U3Ry?=
 =?utf-8?B?UnJRN2phMnc0K0FGeEtPNUszK3UxUEoxM3NLSzdrTHRuZVNOMG9zL0NJaDh5?=
 =?utf-8?B?Q0xsTURWdFlEVXVxYXM3dkFLL1pILzVvWjh1b0pIbUZCUlMrSHg3cUVLamRo?=
 =?utf-8?B?LzFHd1d4VDlNK2s2SGlNUFdiSjVwcHhSTGtMWnJscnNnNFdvY1h4R3FtT1Zu?=
 =?utf-8?B?enBEZk5jbmx4dFR5M1NCOGdRanFIV29KQnZXbTdib1o1eU1IWnRPTFcwL1ZT?=
 =?utf-8?B?bHhHSHM1VGxVRnN3cTNFRHpyV0ZXV3YzVVVQSWtadmlVaXhES0pJaDhtcU8z?=
 =?utf-8?B?bkV6NXpjMHl2azRuZ0JhQWZod2tINCtZMXVJQnhnTG02Z05MamdnQStNc1NX?=
 =?utf-8?B?a1pxc1ZUSGVTUk0wSE9PMVRJQXhJWlM2empOVnF6a1c3NFpFRWQ5aTlkRVNn?=
 =?utf-8?B?N3J6L3BKMndVUm1PVlRldHo1eG9uN2t1d3NPdnFDOUl1WWNKT0FYUlFmUmFu?=
 =?utf-8?B?TWJLb2dxdnZBNmNBaE91VVVuSmViZFZEaFdzK052Z2lqUUpoTXlBQlZ2b00x?=
 =?utf-8?B?b1NMdHVQMTYrWmVmemtIWWVPRk5vYVhtK1M4ZEFYY2lSOE5WV3dOVW5NZnlH?=
 =?utf-8?B?TUcxc3NtYmJhODRDaW1qT1JtM1NhL0xMTjdmOVlad3hUdWlMeS85aEErN296?=
 =?utf-8?B?UWpZSTlyNm1zOEp5enhHZkdMWmtESnlaV3doTXduN1IxVVN1ZVBnSE90V3Vk?=
 =?utf-8?B?WUdleWRjbWdKK3FyODBURnNmRk9FVS9CaGVvc0N1ZjJRUDV6UUlaRFhEdE1U?=
 =?utf-8?B?b0pEaVBVdnMvdkR3dUtzOTJuVDFSeTJvZjJReSsrNGoxRm1IZGhhZ212QzJx?=
 =?utf-8?B?a0NsTXlTaTZuQUc2NEN2d3U3QzlxdmlZSEFQdGpXelo4eEdheWdUSk1oRHhW?=
 =?utf-8?B?Sm9FVHNsd01LQlJRMStLUk9FY0lsVHo3YVQrMDZjYThjclZxaDdYR2E4ak5H?=
 =?utf-8?B?cjBtaFFpOGRYM0JOekZ2bUJMYTVsclNBSTZ6U0Jod0FjcmRDOXpxL3lsK2wy?=
 =?utf-8?B?OFJGMWhsZU4xdWt1SG5INGVIS2pwQUQxMHZ5anRvN0hEdzROcTkxclVVMGdM?=
 =?utf-8?B?RnhhQXFhdkpTejI1NXR0MTFSM2ppWUQ1ZGZmK3VFbUkwcFpCNHNhSS9uVnlX?=
 =?utf-8?Q?ARNiZgezvvrN7wSPhpRG2L0=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 35494f43-8a74-4a41-26e1-08d9f5fc5039
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2022 12:10:27.8309
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Tfi9WrSa9+Mmwizd9V9iMxKYLIpMzkKhWXJ+r1vwUsAI1DFcMtBd6tA7x1ckgZxN6iTmS8FeAG9YsREk8RsQUw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9254

On 22.02.2022 12:47, Andrew Cooper wrote:
> Most IOMMU hooks are already altcall for performance reasons.  Convert the
> rest of them so we can harden all the hooks in Control Flow Integrity
> configurations.  This necessitates the use of iommu_{v,}call() in debug builds
> too.  Switch to using an ASSERT() as all forms should resolve to &iommu_ops.
> 
> Move the root iommu_ops from __read_mostly to __ro_after_init now that the
> latter exists.
> 
> Since c/s 3330013e6739 ("VT-d / x86: re-arrange cache syncing"), vtd_ops is
> not modified and doesn't need a forward declaration, so we can use
> __initconst_cf_clobber for both VT-d and AMD.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Tue Feb 22 12:18:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 12:18:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276758.473036 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMU7S-0007MR-Jg; Tue, 22 Feb 2022 12:18:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276758.473036; Tue, 22 Feb 2022 12:18:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMU7S-0007MK-GY; Tue, 22 Feb 2022 12:18:14 +0000
Received: by outflank-mailman (input) for mailman id 276758;
 Tue, 22 Feb 2022 12:18:12 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=BO+H=TF=invisiblethingslab.com=woju@srs-se1.protection.inumbo.net>)
 id 1nMU7Q-0007Lt-KY
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 12:18:12 +0000
Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com
 [64.147.123.24]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7fa4b175-93d9-11ec-8539-5f4723681683;
 Tue, 22 Feb 2022 13:18:11 +0100 (CET)
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44])
 by mailout.west.internal (Postfix) with ESMTP id 658803201DE8;
 Tue, 22 Feb 2022 07:18:08 -0500 (EST)
Received: from mailfrontend1 ([10.202.2.162])
 by compute4.internal (MEProxy); Tue, 22 Feb 2022 07:18:09 -0500
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue,
 22 Feb 2022 07:18:06 -0500 (EST)
Received: by mail-itl.localdomain (Postfix, from userid 1000)
 id 9048588D3F; Tue, 22 Feb 2022 13:18:03 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7fa4b175-93d9-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-type:date:date:from:from
	:in-reply-to:in-reply-to:message-id:mime-version:references
	:reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy
	:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=kcYTy4s/XO5qMDwIt
	AUsf/XzBPXwIFt2A5ax0wPh15s=; b=fTBkdrbijoCmJCqImjrWMzRUW1fyjA7Wo
	t7D1EKwDqoLDr+OFTt39Ev3XfwA5flxIeWXzDmHEda0qlyuizMXyHKZ/aFFVPtMU
	Ba6bByWsaDy5u2NLwnxlb1BFjmp0rtfHFacPX7S1+Hj353/F1GYrE+HYSfbgqPvb
	Q+jK9VjG694+3VausSbWdrRXmQJwOht5vjKxGQfDwgO03tVnB8TtwBLFOqTKKyqb
	6BCOdpe4J0ZRUe5WTHehRRKPAMokn00tfnIHu0NT1cY9H5AdDw3HMUgqLM6kF/do
	/NTroXE0fju3vcpV4li2jxEyhPxjnn8mhzmTCU5r3GpFSy8/SjSbA==
X-ME-Sender: <xms:f9QUYnUEH8Bxpjad_niNS3aOEWUaLZM4wYXhu5xj_dBD2m-q6mTtjA>
    <xme:f9QUYvkfCIUGhnMFGocu71Bqp3vVHyl9cfNbftgg1o0rsRRLnCuCQxc9py3ZiVj5Q
    UVgZMusN6JKE7I>
X-ME-Received: <xmr:f9QUYjarG1AMXlCZTPLl5zo4HMrC_h2w8ney59lMUCx2vF2zlhaNDTtIVfXSlmqkWvE9nRgy3wWw8Z8wVI4umD6RjkYB2jcGV-p0Y4CyJg>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrkeekgdefjecutefuodetggdotefrodftvf
    curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
    uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
    fjughrpeffhffvuffkfhggtggujgesghdtreertddtjeenucfhrhhomhephghojhhtvghk
    ucfrohhrtgiihihkuceofihojhhusehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtg
    homheqnecuggftrfgrthhtvghrnheptddvffefjeeftddtieevueeigeehgeefheeluefh
    fffhveeuveelueelffejtdegnecuffhomhgrihhnpehrvghpohhlohhghidrohhrghdpgh
    hrrghphhgvnhgvphhrohhjvggtthdrihhonecuvehluhhsthgvrhfuihiivgeptdenucfr
    rghrrghmpehmrghilhhfrhhomhepfihojhhusehinhhvihhsihgslhgvthhhihhnghhslh
    grsgdrtghomh
X-ME-Proxy: <xmx:f9QUYiXWReafX3ELfPclN8Tu7E6eBrZPv_t4i-fGeOj0yqH6vZzMbA>
    <xmx:f9QUYhkwgYaNc12eHJnfSdKxVpDI0cevYkjUgeXW05r-NMXtK3Rmxg>
    <xmx:f9QUYveMKtzU880AlSfAAk_0iX82_uWtj3EkdkGW11hzc25o4ATjyg>
    <xmx:f9QUYvZwWpb7T1Cv75vVY-Lhw4gaQMdpIFpwXUqXAbb_9jHo1eNh2g>
Date: Tue, 22 Feb 2022 13:18:03 +0100
From: Wojtek Porczyk <woju@invisiblethingslab.com>
To: George Dunlap <George.Dunlap@citrix.com>
Cc: Jan Beulich <JBeulich@suse.com>, Ian Jackson <iwj@xenproject.org>,
	Committers <committers@xenproject.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Andrew Cooper <Andrew.Cooper3@citrix.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH] RFC: Version support policy
Message-ID: <YhTUe7K5/rlek4AA@invisiblethingslab.com>
Mail-Followup-To: George Dunlap <George.Dunlap@citrix.com>,
	Jan Beulich <JBeulich@suse.com>, Ian Jackson <iwj@xenproject.org>,
	Committers <committers@xenproject.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Andrew Cooper <Andrew.Cooper3@citrix.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
References: <20210813113727.6028-1-iwj@xenproject.org>
 <de32c6c4-5ad5-862e-3988-0e7310ec3ecb@suse.com>
 <C6A7B444-4CFB-43A7-8FA8-AD1049F83912@citrix.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="3UUv3tuJOjWd5m1S"
Content-Disposition: inline
In-Reply-To: <C6A7B444-4CFB-43A7-8FA8-AD1049F83912@citrix.com>


--3UUv3tuJOjWd5m1S
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Feb 14, 2022 at 09:50:25PM +0000, George Dunlap wrote:
> I think it=E2=80=99s too much effort to ask developers to try to find the=
 actual
> minimum version of each individual dependency as things evolve.

By "find the actual minimum version", do you mean to get to know the version
number, or install that version on developer's machine?

The first part is easy, may I recommend the excellent https://repology.org/
tool, which also has API to query the version yourself and render a table
yourself. If there's any interest, I could clean up and share a script to do
tables like this: https://noc.grapheneproject.io/~woju/distros/.

The second part very much depends on distro, but all of them have provisions
to install older versions of packages, though not all of them might carry a=
ll
the possible versions (i.e., it might be that you need version X, Distro A =
has
had versions X-1 and X+1, but never packaged version X). Again, if this is
a problem, it depends on the actual package and compatibility situation.


--=20
pozdrawiam / best regards
Wojtek Porczyk
Invisible Things Lab
=20
 I do not fear computers,
 I fear lack of them.
    -- Isaac Asimov

--3UUv3tuJOjWd5m1S
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEaO0VFfpr0tEF6hYkv2vZMhA6I1EFAmIU1HsACgkQv2vZMhA6
I1EMqw/7BeG66foOzv+3vFV0LkBV6NOqUm+TW5QPx6Qp1J+DSpQOZdOwKqwE17Vv
2502VuSExJ35F+So8u9uecylxCEfQPOCBwVXYOzhZJbRjYn9UGPFrZd9nhoUcR7K
5xc8/wD6lPFWqaX+uPp72pRwWKXBBCkOn8CawXos3X8uqF1ecjNRw/BqZ/DJs7AD
To11h6tRi4LF6DQstgiNM3Fa+Ub9REs6ljnO6F/8xClyTRLLjmtfRK1++hW3jeDO
bWrzfy4HrquRRG7UpqxG+bHIID1Gui/GhMdi1oBQ1NMWIB+jqIQHqraj3mfbgNsZ
1c5DzPcofrm27Rbt/d0YbfjCDyyDeQU+xxFbi6jIUC77hbBn+u0TIIdn1mEyf9RI
N3Ok/P+7jc6trik9ERoOZ/q6WtePlXWQrSjMIXIm8twS48uubmKf8gqag7dUciZC
iw4tYFpNw5kc4jh6Tus+FEdaya2qX3gKp5Vm7+2pTwWCIYibpv3ebgY0yro1fIcJ
EklbkWTOKqmEzfhATJkHZ1r8nM6uPzmpbBExAqJdLUwD9miqZ5y9fSOFU5uAYFmf
H83GkuYeLGSYWnc8WRWDJLJB+cGIojWhFl+Y8FwuPHNVrF399haTYp0jXSBfs+f4
0KBOe7sqJ+G35IjzKvTX4Il6anuBHzhxXyL6f83Q4apZEwYTt7U=
=POjU
-----END PGP SIGNATURE-----

--3UUv3tuJOjWd5m1S--


From xen-devel-bounces@lists.xenproject.org Tue Feb 22 12:35:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 12:35:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276767.473047 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMUNg-0001D7-4J; Tue, 22 Feb 2022 12:35:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276767.473047; Tue, 22 Feb 2022 12:35:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMUNg-0001D0-1A; Tue, 22 Feb 2022 12:35:00 +0000
Received: by outflank-mailman (input) for mailman id 276767;
 Tue, 22 Feb 2022 12:34:58 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=AYeZ=TF=invisiblethingslab.com=marmarek@srs-se1.protection.inumbo.net>)
 id 1nMUNe-0001Cu-JM
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 12:34:58 +0000
Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com
 [64.147.123.24]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id cda59c64-93db-11ec-8539-5f4723681683;
 Tue, 22 Feb 2022 13:34:40 +0100 (CET)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.46])
 by mailout.west.internal (Postfix) with ESMTP id 1B5CE3202138;
 Tue, 22 Feb 2022 07:34:48 -0500 (EST)
Received: from mailfrontend1 ([10.202.2.162])
 by compute2.internal (MEProxy); Tue, 22 Feb 2022 07:34:48 -0500
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue,
 22 Feb 2022 07:34:45 -0500 (EST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cda59c64-93db-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:content-type:date:date:from:from
	:in-reply-to:in-reply-to:message-id:mime-version:references
	:reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy
	:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=1cwBl3Dlc+eSuBKBr
	9u3an3V7I9uGGazK91w8bC07/A=; b=R8OYf1GCUkPqtX1I1HhuOeXepXZoq7VM7
	ledvyUv7l8aBz5SFWCIHJ7EJ56FVq1y/lFIwby+IDlVZJtcxSVJM13DPVUmixCPY
	1akR89XeewRQYnk/MkeR2gmou0cFBw54kYjdz4C+HVEYyUNwYccc40syFZ5IQqj1
	0YZZDZyRbn7JWPZeKqyZnz5Tx2LuFePn4DhQxsCyjRm8xLZRamWE1JU1pDO+wNP7
	Iz05gmph9WvRNgJ2Br7bvXA1ks29MAazzruHxOvR/Eh9RO2WUwL/XPk9fA9afLd9
	K8nK6ADOhwCVko6bG89ovRFACN8oZENuWIbSd4CezsI/ffmyQLHbQ==
X-ME-Sender: <xms:Z9gUYjyeO3jsuOzVO8_vdkmfCceBm4K_gkrDsduoCVZjhOBGc81bkA>
    <xme:Z9gUYrRj0vBJPAlB4EmsveA1VPlTjeBEzwFqqA7iApgydQS6IoNozp3JHwGB_Q0dJ
    4NNR8VC2-azfA>
X-ME-Received: <xmr:Z9gUYtWDeIhZuPMlaBGO3VKssPp3YmzhBtPaKKV9XpM4TEo1z2txFbb7EnhQ1BLXuRBmGf9RQVQFCOQitR4xdnHvCzBsDZIo1w>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrkeekgdegtdcutefuodetggdotefrodftvf
    curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
    uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
    fjughrpeffhffvuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrrhgvkhcu
    ofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinhhvih
    hsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepteevffei
    gffhkefhgfegfeffhfegveeikeettdfhheevieehieeitddugeefteffnecuvehluhhsth
    gvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghrvghksehi
    nhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh
X-ME-Proxy: <xmx:Z9gUYtjrAOUeRjeYgLesisLLIbUFOt6GnOPd_KiZDjAu2aZTC8_5xg>
    <xmx:Z9gUYlA_rEyYgQwpAuVMKjb8HtEMwqjF1rd9hwXZR4w6y8xM39ylnQ>
    <xmx:Z9gUYmJx36QZf8PiHII1ENQeUGMAeFP2n65bxcpjGi568aWKmHqL0A>
    <xmx:Z9gUYn0K_dyFh44nejx3-kFj-Posy9A6lVsDJTiy2LYSHYobG0Mi5g>
Date: Tue, 22 Feb 2022 13:34:42 +0100
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: George Dunlap <George.Dunlap@citrix.com>,
	Jan Beulich <JBeulich@suse.com>, Ian Jackson <iwj@xenproject.org>,
	Committers <committers@xenproject.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Andrew Cooper <Andrew.Cooper3@citrix.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH] RFC: Version support policy
Message-ID: <YhTYYven0PMcHM4P@mail-itl>
References: <20210813113727.6028-1-iwj@xenproject.org>
 <de32c6c4-5ad5-862e-3988-0e7310ec3ecb@suse.com>
 <C6A7B444-4CFB-43A7-8FA8-AD1049F83912@citrix.com>
 <YhTUe7K5/rlek4AA@invisiblethingslab.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="NKhGOpqXO9szl3YX"
Content-Disposition: inline
In-Reply-To: <YhTUe7K5/rlek4AA@invisiblethingslab.com>


--NKhGOpqXO9szl3YX
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Tue, 22 Feb 2022 13:34:42 +0100
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: George Dunlap <George.Dunlap@citrix.com>,
	Jan Beulich <JBeulich@suse.com>, Ian Jackson <iwj@xenproject.org>,
	Committers <committers@xenproject.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Andrew Cooper <Andrew.Cooper3@citrix.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH] RFC: Version support policy

On Tue, Feb 22, 2022 at 01:18:03PM +0100, Wojtek Porczyk wrote:
> On Mon, Feb 14, 2022 at 09:50:25PM +0000, George Dunlap wrote:
> > I think it=E2=80=99s too much effort to ask developers to try to find t=
he actual
> > minimum version of each individual dependency as things evolve.
>=20
> By "find the actual minimum version", do you mean to get to know the vers=
ion
> number, or install that version on developer's machine?

I think it's something else (closer to the second one): finding what
version is required for features actually used in the code.

--=20
Best Regards,
Marek Marczykowski-G=C3=B3recki
Invisible Things Lab

--NKhGOpqXO9szl3YX
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmIU2GMACgkQ24/THMrX
1yyNkAgAkI9gSWNLDTecG/HHJgZWgerwIptOlv7bOsxawbH4Z/07Gkzuv9kpcyRE
Lr2sa8E+CERvR9ys9n88LZOoGT6+iwOrpCYTksT9XjQFWlt7JIR4uMElLb+Kf4CQ
sgTAcQGHgckEarGmO2/34Z9sOlLQh3e06jl0fqkGZ7UKK0t1MSTs1RNV7iNuEkMI
sB1jkIcR2sFf50zegnBddlBaPXDc6wXAIkcRcpzBCiX9WjESthnNLibjvx3fFRYX
4ykWXsYCt04NET9Lcb62CKr24LNci4TRXmiM0lPaickbN9sGSbtLWTo4BL2L3rri
F301jzEN9fcntEcLhFqnKtY7yG8zKg==
=qQ6a
-----END PGP SIGNATURE-----

--NKhGOpqXO9szl3YX--


From xen-devel-bounces@lists.xenproject.org Tue Feb 22 13:30:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 13:30:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276776.473058 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMVFU-0007Dx-Gp; Tue, 22 Feb 2022 13:30:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276776.473058; Tue, 22 Feb 2022 13:30:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMVFU-0007Dq-DH; Tue, 22 Feb 2022 13:30:36 +0000
Received: by outflank-mailman (input) for mailman id 276776;
 Tue, 22 Feb 2022 13:30:35 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=IN1Y=TF=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1nMVFT-0007Dk-OR
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 13:30:35 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 336f70d4-93e3-11ec-8539-5f4723681683;
 Tue, 22 Feb 2022 14:27:37 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0ABE61063;
 Tue, 22 Feb 2022 05:30:32 -0800 (PST)
Received: from [10.57.3.116] (unknown [10.57.3.116])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E4A123F70D;
 Tue, 22 Feb 2022 05:30:30 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 336f70d4-93e3-11ec-8539-5f4723681683
Subject: Re: [PATCH v3 01/19] xen/arm: lpae: Rename LPAE_ENTRIES_MASK_GS to
 LPAE_ENTRY_MASK_GS
To: Julien Grall <julien@xen.org>, xen-devel@lists.xenproject.org
Cc: Julien Grall <jgrall@amazon.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20220221102218.33785-1-julien@xen.org>
 <20220221102218.33785-2-julien@xen.org>
From: Michal Orzel <michal.orzel@arm.com>
Message-ID: <c87e41d4-be73-665c-aa40-22798e254012@arm.com>
Date: Tue, 22 Feb 2022 14:30:24 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20220221102218.33785-2-julien@xen.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

Hi Julien,

On 21.02.2022 11:22, Julien Grall wrote:
> From: Julien Grall <jgrall@amazon.com>
> 
> Commit 05031fa87357 "xen/arm: guest_walk: Only generate necessary
> offsets/masks" introduced LPAE_ENTRIES_MASK_GS. In a follow-up patch,
> we will use it for to define LPAE_ENTRY_MASK.
> 
for is unneddded. Should be "we will use it to define..."

> This will lead to inconsistent naming. As LPAE_ENTRY_MASK is used in
> many places, it is better to rename LPAE_ENTRIES_MASK_GS and avoid
> some churn.
> 
> So rename LPAE_ENTRIES_MASK_GS to LPAE_ENTRY_MASK_GS.
> 
> Signed-off-by: Julien Grall <jgrall@amazon.com>
> 
> ---
>     Changes in v2:
>         - New patch
> ---
>  xen/arch/arm/include/asm/lpae.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/xen/arch/arm/include/asm/lpae.h b/xen/arch/arm/include/asm/lpae.h
> index e94de2e7d8e8..4fb9a40a4ca9 100644
> --- a/xen/arch/arm/include/asm/lpae.h
> +++ b/xen/arch/arm/include/asm/lpae.h
> @@ -180,7 +180,7 @@ static inline bool lpae_is_superpage(lpae_t pte, unsigned int level)
>   */
>  #define LPAE_SHIFT_GS(gs)         ((gs) - 3)
>  #define LPAE_ENTRIES_GS(gs)       (_AC(1, U) << LPAE_SHIFT_GS(gs))
> -#define LPAE_ENTRIES_MASK_GS(gs)  (LPAE_ENTRIES_GS(gs) - 1)
> +#define LPAE_ENTRY_MASK_GS(gs)  (LPAE_ENTRIES_GS(gs) - 1)

Incorrect indentation of (LPAE_ENTRIES_GS(gs) - 1)
> 
>  #define LEVEL_ORDER_GS(gs, lvl)   ((3 - (lvl)) * LPAE_SHIFT_GS(gs))
>  #define LEVEL_SHIFT_GS(gs, lvl)   (LEVEL_ORDER_GS(gs, lvl) + (gs))
> @@ -188,7 +188,7 @@ static inline bool lpae_is_superpage(lpae_t pte, unsigned int level)
>  
>  /* Offset in the table at level 'lvl' */
>  #define LPAE_TABLE_INDEX_GS(gs, lvl, addr)   \
> -    (((addr) >> LEVEL_SHIFT_GS(gs, lvl)) & LPAE_ENTRIES_MASK_GS(gs))
> +    (((addr) >> LEVEL_SHIFT_GS(gs, lvl)) & LPAE_ENTRY_MASK_GS(gs))
>  
>  /* Generate an array @var containing the offset for each level from @addr */
>  #define DECLARE_OFFSETS(var, addr)          \
> 

Cheers,
Michal


From xen-devel-bounces@lists.xenproject.org Tue Feb 22 13:56:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 13:56:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276783.473069 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMVer-0001Cg-NA; Tue, 22 Feb 2022 13:56:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276783.473069; Tue, 22 Feb 2022 13:56:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMVer-0001CZ-IX; Tue, 22 Feb 2022 13:56:49 +0000
Received: by outflank-mailman (input) for mailman id 276783;
 Tue, 22 Feb 2022 13:56:48 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=4CiU=TF=citrix.com=prvs=045c9559e=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nMVep-0001CS-T8
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 13:56:48 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 44b084b6-93e7-11ec-8539-5f4723681683;
 Tue, 22 Feb 2022 14:56:45 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 44b084b6-93e7-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645538205;
  h=from:to:cc:subject:date:message-id:
   content-transfer-encoding:mime-version;
  bh=MYRtT8uT8744+VKmxHIq/+avEby5jH4sm0atqcMiDUo=;
  b=eD0XLCwGGP96NzUABm0osiTo3K+gRAeJEpJ7X2P5HPXzGmP/YKDVtTdh
   5K2kT2TNl9Z6bKxZqKvCypbudfJdbrg/jJeLmugzVNbzMSKyKRMoBK4Gx
   6eKtbjP8ScKRl+80864lWhQEEwNoDXHyOy2u+gJkA19Zw+NsZvoaSBnYJ
   o=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 64723452
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:onZ+gKL21i660CYmFE+R7pUlxSXFcZb7ZxGr2PjKsXjdYENShmdTz
 2cWDW2EOv6CMWb1Ld5zPI3n8x8HvcTRm4VnHQdlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA180IMsdoUg7wbRh2NQy2YLR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 NNyr5q9ZgEVBbLrsrgfaDJHGgBVZbITrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBNPsM44F/Glp0BnSDOo8QICFSKLPjTNd9Gls2ZoVQauED
 yYfQRlDRxrySh5UBkweK4gkpd6ZgFjeSgQN/Tp5ooJoujOOnWSdyoPFK8HJc9aHQcFUmEewp
 W/c+Wn9RBYAO7S31j6t4n+qwOjVkkvTWp8WFbC+3u5nhhuU3GN7IA0bUx63rOe0jma6WslDM
 AoE9yw2t68w+Ue3CN7nUHWQonSJoxodUNp4CPAh5UeGza+83uqCLjFaFHgbMoVg7ZJoA2xxv
 rOUoz/3LTpQqruYZnShzaizh2+wAgMKJE4pPTBRGGPp/OLfiI00ixvOSPNqH6i0ksD5FFnM/
 tyakMQtr+5N1JBWjs1X6XiC2mvx/caREmbZ8y2KBjrN0+9vWGKyi2VEA3D/5O0IEouWR0LpU
 JMsy5nHt7Bm4X1geUWwrAQx8FOBuq7t3N702wcH83wdG9KFoSXLkWd4umwWGauRGpxYEQIFm
 WeK0e+r2LddPWGxcYh8aJ+rBsIhwMDITIq5C6yKP4cTOMQoLGdrGR2Cg2bKhAgBd2B2zMkC1
 WqzK57wXR7294w9pNZJewvt+eBynX1vrY8ibZv60w6mwdKjiI29Et843K+1Rrlhtsus+VyNm
 /4Gbpfi40gPAYXWP3iMmaZOfA9iEJTOLc2vwyChXrXYeVQO9aBII6K5/I7NjKQ/wfwOz7+Qp
 ivVt40x4AOXuEAr4D6iMxhLQLjuQYx+vTQ8OyktNkyvwH8tfcCk66J3Snf9VeBPGDBLpRKsc
 8Q4Rg==
IronPort-HdrOrdr: A9a23:1JRBiKsXCy1g3uTvJv3TJrP87skCgIMji2hC6mlwRA09TyXGra
 +TdaUguSMc1gx9ZJhBo7G90KnpewK5yXcT2/hqAV7CZnichILMFu9fBOTZslvd8kHFh4xgPM
 RbAtdD4b/LfCFHZK/BiWHSebZQo+VvmJrY+ds2pE0dKj2CBZsQijuQXW2gYzBLrUR9dOwEPa
 vZwvACiyureHwRYMj+Ln4ZX9Lbr9mOsJ79exYJCzMu9QHL1FqTmfbHOind+i1bfyJEwL8k/2
 SAuwvl5p+7u/X+7hPHzWfc47lfhdOk4NpeA86njNQTN1zX+0+VTbUkf4fHkCE+oemp5lpvuN
 7Qoy04N8A20H/VdnHdm2qZ5yDQlBIVr1Pyw16RhnXu5ebjQighNsZHjYVFNjPE9ksJprhHoe
 929lPck6ASIQLLnSz76dSNfQptjFCIrX0rlvNWp2BDULEZdKRaoeUkjQlo+a87bW3HAb0cYa
 dT5Jm23ocWTbraVQGTgoBX+q3hYpxpdS32AnTruaSuokprdT5CvgglLfck7wY9HaIGOud5Dt
 v/Q9RVfcl1P7crhIJGdZM8qJiMexvwqSylChPgHb2gLtBEB07w
X-IronPort-AV: E=Sophos;i="5.88,387,1635220800"; 
   d="scan'208";a="64723452"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=F5HPiAO8iVnuJlCZjy3m31OlVOMw0fLpKXQai2cks6KCFGBfNzoxFrGo7bCdhxj4tmymRF90pfHKZS1vy4meIIRKnfhYiP/khIc7IHb76qXepmd+23hHTQ7MPzGSRfsj2eUUhtbbWOHfwaQBqXVuWN4Jjt7hOjDSsPVAHAmeYCu8UMyMh2Ou+yL7NnHJ9smDv939m4pYb55LRhu9uVaazT8hgrMpNn9aEZC/NCLrJDEoBpOKVoNRNfDcVYlKR1ly7fsptLxfvVHtT1dRjkSfoa70x3UZZrcR74CjHeqKCOqI+G156E9shkoUbDfkDyb17HcxScS2AlyLRyUhkw2U+A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=cXgZLc8DG7SimeaGHF3QjfgAel9eg/yXjacOv/wVI3g=;
 b=JvJwAcguLxUpl+SSrgiGud2vLLW3SrsTi7s+eyqNfuAJk/1oEEfXDGgdw5ZAkrkL5YKcNC0aS4KLxOezbBJBZEYX2hxtqqh9Q/tdOCyIGy83u1YEHHK2wi3KBX2uFLVlbIzTAPZN0nkkv5cO9wMTgm3vMaHfrTMXr4B1B65z5Y/PDtwwWufUr0BqfKxMJLPi2v+eBfgF0QPTGsD7RaS96t76gOIRe2rfDYQWA+NKgmQmIaH07/RP4BSJi8h1E99CVp5vBsPwMxY+EnoUjQjW/OSz6H4xs085Pt+oMJlpEgjDpkvXAMKNthIBsr7L+r0ORv850jN4KUYyWP2//ZkrtQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=cXgZLc8DG7SimeaGHF3QjfgAel9eg/yXjacOv/wVI3g=;
 b=dlWpI/jyJEGm7hlTG1SMQjetwTpTV+fARugwQkwax8YtfI+rmOz3OW8Th9b2jvHl+2Liy6Dm4ALPvoNM+v4PfuvnxPNyIUztCkN8VPOuhr1SfdDsAEHrkL7TG3/x5vIGnk/Y+oBZ24QP3sltUltQ5lGcPi6w/UaIXhXB+6sdHxI=
From: Roger Pau Monne <roger.pau@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Roger Pau Monne <roger.pau@citrix.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, Jan
 Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>, Stefano
 Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Subject: [PATCH] cirrus: update FreeBSD to 12.3
Date: Tue, 22 Feb 2022 14:56:29 +0100
Message-ID: <20220222135629.68769-1-roger.pau@citrix.com>
X-Mailer: git-send-email 2.34.1
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO4P265CA0015.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:2ad::18) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 6ffb4936-069e-441a-ebee-08d9f60b26f3
X-MS-TrafficTypeDiagnostic: DS7PR03MB5381:EE_
X-Microsoft-Antispam-PRVS: <DS7PR03MB538198C3E0CB3C8C578214E78F3B9@DS7PR03MB5381.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: SARGb4ffxTayYeetzkorDpw2w9HSEWZGzZTXDg/Nr+LE3xJmRgI7ygP3+UBIkyavjDB3nCPtwS8T9Jbv/zQ5p3/SFEuTuOdED2xqlGy3wFGmXyavoTX8EX2G+7nOvqcAB9l4Oe/Gc0cAo0NhkInQ9F5j05ViT0Q+/c4KMdm8sCC2YX8Gfs8bTIUFaP3VzTlAdebNhPj6HPwh8FEROtJSlIJVeqg0n6ZMjimnMYXWH6V7WT9Jo0AFXsyXtmkqUmyH/r4V07YbY0zPzCK4v1X9JP98hYI9kpfuiMa860/bo0Yiei9buPw8S/txBludGXHh+bhei1UAXcP+EAuFIXiYAMsrxeD9vbIdIVY2USm+JP/6VsJc3DE68n9GIy7c5GUdDHTMdCl4F/onQDvZkxXOLg9SU23Nb3/VrULJ2YZDzERS/nuOhGK+fbInOijIQlhLIAXt5h+SUt73/34obSW77BwDQRzzBXoVC23806W2AkJWONt2XPhWo6D3LaSe2GlzqxE/kcgTGtGdRqY6c57VE2pB7DwfKD7sMfKViudSpYTygdemJe8DbrcWG7t6lOybI2CzQmaZDlOdp+aZ0TOTpNqQwIPM7/56dN103C6pc4R3Ot2zggPwtBvf++p7UrEAR7oxTOcn7efcxRy23e38Ng==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(186003)(1076003)(316002)(82960400001)(2906002)(6506007)(4326008)(8676002)(66946007)(66476007)(66556008)(36756003)(6666004)(26005)(83380400001)(54906003)(8936002)(6916009)(2616005)(5660300002)(6486002)(508600001)(86362001)(4744005)(38100700002)(6512007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MnFtQnlUYUFaN1RFRzJCdER5RERoN3JVYXI0bjhpS1ZTakNJc2JmbFB4Q09r?=
 =?utf-8?B?bnJuRE43WStBcStwbEtPYVEzY2l4WFZXM1YyZHRFczR2QTU3eDZudzNBeHdq?=
 =?utf-8?B?TzkxTWxGMHJ0ZU1YQUVyVERHZlg3Nk9UWk9jUVgzVDJ0dThBWDBXUGVoSlNJ?=
 =?utf-8?B?Y3lrb0Uva09nSXZnWXhvTndsR0lPTTRGeVJzNTAxWDlJMmhtaE0wMWRKNzFC?=
 =?utf-8?B?d1k3RWNiZ3d0VlpZU3NHd0xZZzMxNkg5Mlh6WGJ1V2xkS05YcEpNc0hkaTJR?=
 =?utf-8?B?TGdPWCtYYjRhekwvL0NFcWpkcU02YSs3YzFBeVVWaGR6NndBMDJkRzZIZ1lN?=
 =?utf-8?B?bExrM29XYnR6emRROVFmQlNqR3NRbzRHN1hFdnVtTVJYVlR2dUdHYjhhVXYw?=
 =?utf-8?B?Mk5rY0hxQVNqWGhONXIzNm42UjBEdUt3VDdPUW5BR1Y2YnhULzVUUEk1bXd2?=
 =?utf-8?B?dEhkbVZ4alRBRWI5eFZnQzdOODloQU15VHBIQkhKa1pyYXJ4L0FsdU9KeFI4?=
 =?utf-8?B?bTRpaWtqTGlNbDI2MGdwZlVDQk13dU9YZEM4WkJLdjl2UjRiamovUGcrenZP?=
 =?utf-8?B?R2w3Z004MHdVSWdJcCsrTWRDVHBrckZLVWRVMmNKekNUYnlldkRxcmg3NjM3?=
 =?utf-8?B?cWs1bTB1RE56NWxjV1pUaGdwSXd1Q3lMMEVWK0ZlVDBvYWY0WitEbmROZ3F0?=
 =?utf-8?B?TXArd3ZCMnZqMU5zTnprNmdTdGRxZ2E4NXlhZkRrSXRhVUJVSHpxT3cyK1pp?=
 =?utf-8?B?bkYxd1llbG80Kzg5SlVaZUxjZHdxSmdOSy9wREluU1NFVm1PUVhhVTRKYzd2?=
 =?utf-8?B?Mjl1TnFOSXBjS3g0Y0J0QnAxMkVhS1dOMWJyd0EybTVRQ1hER1FlRXlrYTMw?=
 =?utf-8?B?aG1xbXpCUzhnaExQVnBSdzBrV3ByS0F3bUozRXdrenRnMlVtWDk3VWkvMXlp?=
 =?utf-8?B?cmt3am40Q1ltbHB3QWZHTTIrTk5ROUpodDV1aW5MWHdMMUZXS3MxTG92WUEx?=
 =?utf-8?B?VWRWL0x1amRBaVZyQ3ZaeXIvQzhxcGdSUlBRWFNQb0ZDRVZ3L1daZ094Wldk?=
 =?utf-8?B?ZVMxWHRTT0x1RzdVK1FBUGlMblVXZXR1TnorZzZHNkpYUk9JRFhMV2JDcEto?=
 =?utf-8?B?aDlHZll6bVdHdmJmRE1XZ0JQN3htMk1TcUNCWUxUTG9XV2YzVnpWNnJzYnJ6?=
 =?utf-8?B?anBiYUFFQjRsUG1qT0d5T0l2dlBsOEZjVWpab3NKWFFZbmVDTldJL0tSVUpx?=
 =?utf-8?B?NFZXekYyVmFHR2FMeFFFUFE2ZjhaRFp3dzU1SzQ2akt6RWoxdktkRzAzaGJ1?=
 =?utf-8?B?ZWdzM1VzbkRHTDV6Z0RIM2FEcHlEQ0VURzNKb2IrTXRHbkQyS211aEt3Uk5L?=
 =?utf-8?B?NG80ZGVnZ2drejdkWUY4MmFidnZLelY1dTFuT0FRaDVjTTc0MUdyVDZZR01C?=
 =?utf-8?B?YzNaQ0lQT2ozbGpoU0FYWGRVbDJGSmc3R04xRGdFd2swSWMvbWJPWVlhZERR?=
 =?utf-8?B?OWlpS3oxQkNDTHJHZVJSaWl2d1RDaEo2SjVUbC84ODJiS1FuUVQ4aGVLMkJk?=
 =?utf-8?B?MHhUbDk3ZncweExyb0FKVTJjUEtWNjd4REh2K0FIczdITnV2N2tkQ3dpQnli?=
 =?utf-8?B?RDR5bVVVUDREa3prV0lUQk1KSDdSeFJ2MENwZTZXSVBhVnQxVC9kZVh1WFRs?=
 =?utf-8?B?OHFRZ3BRTFFrcWR5a0tyWHl1T3RzL0duc3RySUxYM1VRNEFCL3M0c1BaQzRl?=
 =?utf-8?B?VzV4aHdVYlg5L0hPU0tjUGlJUnFCVmxiWEJsbi9EZGJxM0hUTHJ5MXlCU044?=
 =?utf-8?B?djR3NmEvSG52S2lJQ2hjNGdQbmJYdDgwQ0EzRXFNUlh4ZUlDUDJvMS9mTUhi?=
 =?utf-8?B?M0NuVzhpMmU1eUIyUnM0MktxRzlhb21yWHFRTEhMajBHcjZiZFYrakQwWUhT?=
 =?utf-8?B?ZFV3d0h5M2NSUi9yRTdDVW0yMTZENnpvd3Q4ckFhK2lsTVhwQThVNktuWnF3?=
 =?utf-8?B?dm1oWW9Gb0o0SVJCWk91K1h3UUo3RFlqMzVEY2Y1OUpjaER2VjVuWVdxNXI2?=
 =?utf-8?B?b1pCWXovdXNHVGdwRDE3V0lMcTBpNXJjRmdsa0habHgwQ1g0MlYzTkdGNENu?=
 =?utf-8?B?Z1pwNjA5bUc3RVN6V2hYSytMUWJoVG8rc0FTZlppRjVEdzh5SzhoWFMzVitw?=
 =?utf-8?Q?Bcj9ZoX1c91UQ1uljtqkgDc=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6ffb4936-069e-441a-ebee-08d9f60b26f3
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2022 13:56:41.0897
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0LhV7Ca3DBRHRZlxuunUUWm/1Xb7y6A+/7mYjetHkiGFz0FMrBZXjZaPXfP0pi4pHluiamwIdw8BavaTdWBd7Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5381
X-OriginatorOrg: citrix.com

Switch from using a FreeBSD 12.2 to a 12.3 image.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
 .cirrus.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.cirrus.yml b/.cirrus.yml
index b17f0b6369..4ae719136e 100644
--- a/.cirrus.yml
+++ b/.cirrus.yml
@@ -16,7 +16,7 @@ freebsd_template: &FREEBSD_TEMPLATE
 task:
   name: 'FreeBSD 12'
   freebsd_instance:
-    image_family: freebsd-12-2
+    image_family: freebsd-12-3
   << : *FREEBSD_TEMPLATE
 
 task:
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Tue Feb 22 13:59:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 13:59:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276790.473080 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMVh0-0001nx-2g; Tue, 22 Feb 2022 13:59:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276790.473080; Tue, 22 Feb 2022 13:59:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMVgz-0001nq-Vy; Tue, 22 Feb 2022 13:59:01 +0000
Received: by outflank-mailman (input) for mailman id 276790;
 Tue, 22 Feb 2022 13:59:00 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=ghSa=TF=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1nMVgy-0001ng-DH
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 13:59:00 +0000
Received: from ppsw-41.csi.cam.ac.uk (ppsw-41.csi.cam.ac.uk [131.111.8.141])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 943a44cb-93e7-11ec-8539-5f4723681683;
 Tue, 22 Feb 2022 14:58:58 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:32862)
 by ppsw-41.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.139]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1nMVgn-000bFs-RB (Exim 4.95) (return-path <amc96@srcf.net>);
 Tue, 22 Feb 2022 13:58:49 +0000
Received: from [192.168.1.10] (host-92-12-45-187.as13285.net [92.12.45.187])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 23BF11FB82;
 Tue, 22 Feb 2022 13:58:49 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 943a44cb-93e7-11ec-8539-5f4723681683
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <405b80b3-2f9f-f6a1-1776-ca198f9fdc98@srcf.net>
Date: Tue, 22 Feb 2022 13:58:48 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH] cirrus: update FreeBSD to 12.3
Content-Language: en-GB
To: Roger Pau Monne <roger.pau@citrix.com>, xen-devel@lists.xenproject.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>
References: <20220222135629.68769-1-roger.pau@citrix.com>
From: Andrew Cooper <amc96@srcf.net>
In-Reply-To: <20220222135629.68769-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 22/02/2022 13:56, Roger Pau Monne wrote:
> Switch from using a FreeBSD 12.2 to a 12.3 image.
>
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>

Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>

I presume you've got a private run showing that this is fine?


From xen-devel-bounces@lists.xenproject.org Tue Feb 22 14:13:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 14:13:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276797.473091 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMVuQ-00048f-Be; Tue, 22 Feb 2022 14:12:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276797.473091; Tue, 22 Feb 2022 14:12:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMVuQ-00048Y-84; Tue, 22 Feb 2022 14:12:54 +0000
Received: by outflank-mailman (input) for mailman id 276797;
 Tue, 22 Feb 2022 14:12:52 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=4CiU=TF=citrix.com=prvs=045c9559e=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nMVuO-00048S-SW
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 14:12:52 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 84233f2d-93e9-11ec-8539-5f4723681683;
 Tue, 22 Feb 2022 15:12:51 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 84233f2d-93e9-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645539171;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=fFdVUZrEbRDXIWLIOsqjij4vtYjqFbDVQi8Ml+pSSNc=;
  b=USQCBwngDblf7bLBkVj18FP9Q/nVjhbZLzbCugslT+VV3MaYWWt/PijT
   DNBMyzzLowMM8vaW8OT9wP3YZpalKm+PM9c6J/kA7Sjjsx4oPJAatyYrD
   PG1YMIFCfFAaauDLQccylOjyiAx3S8eF8ynev4Umqmq0wjjz/wfEtDiWa
   A=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 65130497
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:AoFO2K2iedZUtbttR/bD5Rxxkn2cJEfYwER7XKvMYLTBsI5bp2YDy
 2cdXmmGOqneZjP1L9l2a9y1pxsEv5KBztZlQFBupC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk0GE/NtTo5w7Rj2tQy24Dja++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /1nsMyhcwg4HZT+s+VMeCd9DyxXAal/reqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHxO4wSoDd4xCzxBvc6W5HTBa7N4Le02R9u25kVRaqPO
 KL1bxJefkyYWw0UIG4MN9Efp7ej3mL8diRX/Qf9Sa0fvDGIkV0ZPKLWGNjIft2HQ+1Fk0Deo
 XjJl0ziGQ0TPtGbzTuD81qvi/XJkCe9X5gdfJWn8tZ6jVvVwXYcYDUfUFDq/9GikEWwHdRSN
 yQ86ico6KQ/6kGvZt38RAGj5m6JuAYGXNhdGPF87xuCooLW6QuEAmkPThZadccr8sQxQFQXO
 kShxo2zQ2Y16fvMFCzbpuz8QS6O1TY9B2pSdBULXCg80fLi8aoNqw7CZ+pnKfvg5jHqIg3Yz
 zePpSk4orwci88Xyqm2lWz6byKQSovhFVBsuFiONo6xxkYgPdP+OdT0gbTOxasYdO6kok+9U
 G/ociR0xMQHFtmzmSOEW43h95n5tq/eYFUwbbOCdqTNFghBGVb+Jei8AxkkfS+F1/ronxezO
 yc/XisLufdu0IOCN/MfXm5II51CIVLcPdrkTOvISdFFf4J8cgSKlAk3OxLNgz68zRV2zfhnU
 Xt+TSpKJSxBYUiA5GDrL9rxLJdxnnxurY8tbcqTI+ubPUq2OyfOFOZt3KqmZeEl9qKUyDg5A
 P4EX/ZmPy53CbWkCgGOqNZ7BQlTcRATWMCnw+QKJ7XrClc3Rwkc5wr5nOpJl3pNxP8OyI8lP
 xiVBydl9bYIrSeZcV7TMig7MtsCn/9X9BoGAMDlBn7xs1ALaoez9qYPMZwxeLgs7ut4yvBoC
 fICfq297j5nE1wrJxx1gUHBkbFf
IronPort-HdrOrdr: A9a23:QMJCTKG63yrk/yropLqFCpHXdLJyesId70hD6qkvc3Nom52j+/
 xGws536faVslcssHFJo6HmBEClewKnyXcT2/htAV7CZnichILMFu9fBOTZsl/d8kHFh4tgPO
 JbAtRD4b7LfClHZKTBkXCF+r8bqbHtmsDY5ts2jU0dNT2CA5sQkTuRYTzrdHGeKjM2YabQQ/
 Gnl7V6TnebCDwqR/X+IkNAc/nIptXNmp6jSRkaByQ/4A3LqT+z8rb1HzWRwx9bClp0sP0f2F
 mAtza8yrSosvm9xBOZ/2jP765OkN+k7tdYHsSDhuUcNz2poAe1Y4ZKXaGEoVkO0aqSwWdvtO
 OJjwYrPsx15X+UVmapoSH10w2l6zoq42+K8y7uvVLT5ejCAB4qActIgoxUNjHD7VA7gd162K
 VXm0qEqpt+F3r77WvAzumNcysvulu/oHIkn+JWpWdYS5EiZLhYqpFa1F9JEa0HADnx5OkcYa
 VT5fnnlbdrmG6hHjDkVjEF+q3uYp1zJGbKfqE6gL3a79AM90oJjXfxx6Qk7wM9HdwGOtx5Dt
 //Q9dVfYF1P78rhJ1GdZU8qOuMexrwqEH3QSuvyWqOLtBzB5uKke+y3IkI
X-IronPort-AV: E=Sophos;i="5.88,387,1635220800"; 
   d="scan'208";a="65130497"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=QXUj1Ew1GlFMdOhDBafxBcosOh2LPTFlY8bBpMt7sCEAFPXbhunqXFzkfEZE2HQtFLgZ2n1hFWHx9W/08J4JfAEChgdN7CKK08C0fiYf5CQBgrWOtZHdjb2SWpe4bkWs1mwtbKozkLCXgy1TVmYPOJGj6jkX2vP5V7izHToD59fEdpVDhCer+SRusWZHCtvMlUDHpEf8Q2qIClSBAEGx1m//aLy0cXNL7Xbvzef81sVThvjyNSZVWyEBqLRzyzW6owaEZ37gbB82DuDdOFqb8xa2/gdqEBZNHHynUbEPYE18ZX55CfWirI90Dp1Hk6t+x6zLT/k9Jzmj1osjH2Vq4A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ZDPe1jc3rzmEkrCyag7k4Ch3lKpvC3CtDvDjV5QbB2g=;
 b=D6ihuqQFXxbDiYREWsYVpsmhNaPwR3KML39IBqxZOEn/vwcFQpVkj6E17AUNxvtzNO8PNB/drRNhDnnNHRtM/1w35be9cjOnoYZjkrtKikFePmhNZm2Ur8ydrUMjGqCDRoXN0xqXv5UkpHOfaRhDBKUIVLKITDkNXPE4VsFmy4Rj0Ni1gdwG1PiGcGWC0SHx3eArbRE1IsDavXAc6mbpEEHnY944Ngd0tNWp9qc0hUq8RTC4hz71MYvKLagPg47X0MHD2eiFqEwTxroazigGXfoFAw+YxrKRuzJHl2N3EUb0VBJYR4FfQOdyJLP6LXE/ZchnaNt7wQVH0rYU+dfamA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ZDPe1jc3rzmEkrCyag7k4Ch3lKpvC3CtDvDjV5QbB2g=;
 b=ZiAGPOXyK7TLgtnTfcspeS92RrEw+268AfJ4pm0QtjPjGzSxW7Nw3X1Y3HJ1FHnrAm1Wv2pQBjyFvN2zwEQmpJh5OUohtfGfOMNOSgrVKu06aghVnZ6I93Vd19iNLkvBoOBugtJpu3mt6h3OHUuEw23zMvMUpHw2VpdxcDWFHDg=
Date: Tue, 22 Feb 2022 15:12:35 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Andrew Cooper <amc96@srcf.net>
CC: <xen-devel@lists.xenproject.org>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, Jan
 Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>, Stefano
 Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH] cirrus: update FreeBSD to 12.3
Message-ID: <YhTvU7bQiBNl9AeX@Air-de-Roger>
References: <20220222135629.68769-1-roger.pau@citrix.com>
 <405b80b3-2f9f-f6a1-1776-ca198f9fdc98@srcf.net>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <405b80b3-2f9f-f6a1-1776-ca198f9fdc98@srcf.net>
X-ClientProxiedBy: LO2P265CA0172.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:a::16) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2e15bfbc-8534-4f54-3500-08d9f60d62e9
X-MS-TrafficTypeDiagnostic: PH0PR03MB6365:EE_
X-Microsoft-Antispam-PRVS: <PH0PR03MB6365381176CC6A6C0EF003FA8F3B9@PH0PR03MB6365.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: cfpCVt8qpdLYR/FSbo5NGgjpLRM8H2r8V6RrS5XOtbUx/lkBkwPY4h6BwF+vsSgLZHpmCFSBChEOkPUtQaN4t4q842vJtWIO5fDKS0NnN8yzpaJ5qj+MUzgH7GVECKd75m+6CIZTbQAa/kEIXNPASdg6qgoMLqdHIH3WYHzCKV/oKloEWUUpb9B1scpLh/V3eMEXN8uwnPvJJhSeCF/PuAeosnDBUgXd5Nb3v3HmXnmELYbejqxTl6yb/sPayu2SvwHeO/dScJrHQphdJH2srOTzB2lMaf27YO9lqEmz6QYHid5YVIUAVvgu91tU+l+BKj7wA3/X7TKdJFHR9xGriG3pn43rPPveR7gaTJRggMHHfRZ5CiBx2J2tzU7q9I+cZxOcikF7EVN1YqYKVCilFibxCpl3anPkFvNj4owdKmlJjO7aHb1rCgdVuO+A/ERjwG7ppCnMIACz4wLedQGsSKuEPo5ItPFqhU3TATwTjBD/2bTILiecVK3df55AA4JpsHJVNRrTvkHHxjBo0aMBD2AOd5ebfYK71ydOHBUYNJr899EFD1ERtsn3NS9irJSXVbMTahaLA04k6edmGWFZcLkb8jRxSG5z0ekNZ4fUqA8U375/05mtmK2DGv5Kh4slHz2VfxHgnc3uPB8YjkT6AAkBnREC4licMEs9ybFNB+SUxRWHEevGHBZxGBsT8cYQKXG5m+uLcuEI1UDANegIBODKIQvjVtsqsmwjpOf9WrU=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(8936002)(966005)(5660300002)(6506007)(6486002)(2906002)(4744005)(6666004)(508600001)(86362001)(53546011)(6512007)(66556008)(66476007)(9686003)(8676002)(4326008)(66946007)(54906003)(82960400001)(186003)(38100700002)(6916009)(26005)(85182001)(33716001)(316002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L0xDaTNTaTVYUkNydGNPOTlSYXdraDRIeVZPc0NiOXlUM0d6ZzVEczllSlE4?=
 =?utf-8?B?UXpKYVh5bUd3WUdId1JjQnVVQmpVNU9RMHdQb0w3QlZXTWdDQWFOZXZSNGl0?=
 =?utf-8?B?QWEyQ29Yd3JIRU9ZZTZHN1hXN0FITVpTa21RdXV1d2RzeUp1QVk5Z2tYRXUy?=
 =?utf-8?B?QzJTQmtoZG1sWjdnVFdSSkxBMGFtVHNNakorZEFXTmdTRm82N3RiOThoUzRq?=
 =?utf-8?B?YklRTkRSZHpzZktXWm9pWllQTHBxWTU0cTlibDRBN3ZPT3FSY3lvd1ZyaVB6?=
 =?utf-8?B?RG9wbVMvQUh0ekxrTDRvc1VIRGRKZGZtTDQ3Qk5kbGNRSmRGelQrMDlaemQr?=
 =?utf-8?B?QlFDNXV5V2ZETXNmVUFlMEFmRGRKQm5TQVoydHRSYTZVMXU2UVdxWEgraHZh?=
 =?utf-8?B?alFHRHVFNjExS2xGODRUd2dpUFZMMjBuVGlQaTdDdTZWTkJQcWRubVFCYnhD?=
 =?utf-8?B?SHpZbGFuZEhWZUpjZkg3ZHRuTDhGaTJkMjkrMVpJK2FWYVg2aE9JdVAvNU5I?=
 =?utf-8?B?WXRwTTM2SzhUZnFhTC95TlhVak5TdWhkdUMvdjR2cjVjSzMwSjNzSmptQ0tE?=
 =?utf-8?B?UXB2Z2JCTUJ5MktlYlJOb3cvM09lMjE3Mzh0RzB1cG0wUmhDSVlyaEI3SjRu?=
 =?utf-8?B?ZkZVUFVCM2hFNTQvSExERTMwcGVwZzV2bXMwQTU5QUx0RkdjQkpROCttVFl3?=
 =?utf-8?B?Yi9HYkpJRytERENUVDlkamFWdFREZnNjeGREOUM5ejNnNlZha2srRTU4U1Vm?=
 =?utf-8?B?MHlmLzRIcURoY0UrcHZZTUgyd3E0cTdxYmJOSXhyM3N0Zk1WbjdFRVZ1OTVN?=
 =?utf-8?B?VW1OeDNoY0xuWmVnQTc2b29URXo1ckF4dVFnOUZvRkxVb1JXUmJldWpxVTlz?=
 =?utf-8?B?OUt6YjlQa0g3cE1COW1kTVVnbUpKZWZsZUhvYlp2QXFSYU50aC93R3FMeUpx?=
 =?utf-8?B?OFdOUjQydm9TcVRBTzd0TVNqZExBSDJJb0l1a0pCWTZLNVdmNE83eWRPRjUx?=
 =?utf-8?B?cnlRMUxZdCt6elMwbExldEJDbTl5cHExQ0w1S3Nlb0RxRnZMZUVQM2t6RzIw?=
 =?utf-8?B?T2hXSVBLM0psWlNxL1lPbGh3SEJSN1dmdmNtL1luVkloT1ZrbnAvOXhBdGE2?=
 =?utf-8?B?REJrUGw3czJvcFAzTVZRZHJleThIbkYwWXJjd3hRYTV6SkhjMllnMjgrWnhq?=
 =?utf-8?B?dFk4MnRsSW1QVFVRYk1qTUZEeDJFMlBlM0ZjWnVFZ0VJbDhVODFZUzB4MEhr?=
 =?utf-8?B?Sk1jYkxISWFJQVRoOGxCdncyb3BTckJQeTR6aFhuVnMyYkk4aUViUG83VEpV?=
 =?utf-8?B?RStoOUFCeXllOHFYOURKTFczTlRuQSt2V3JpOFJzR1VRcnR6bG83cUtaSmxx?=
 =?utf-8?B?K20yK3VXM29UM3BpNHZ6bVFLeENteFR6NjVFRE9HSkQvbWFFSnpwUUd6TURp?=
 =?utf-8?B?TG1EcjNNM1NUUUFHQy9tb2tIN1JIMlZRREplNmZ3SDV4Zk9pUDFtUmg4WDdx?=
 =?utf-8?B?ZkVjcHZUbDlMMld5eGVvUFoyYVgrMHIxSFpIRlZDSUkzbVVtL1NIL25hZ2cv?=
 =?utf-8?B?RW52R0pmcmlrRlpnN2NoU3lrcjljSE1HalZYL2ljbTdGemU1ZGpYOW1Hb3ly?=
 =?utf-8?B?NlVDZTZGOWJISVZhYnNnTVY5czZReFgwcFdYQzBoOTUvN21LZWYzYW05cVln?=
 =?utf-8?B?TWRNa1Z2S1VCRU84Zk5KSDFQdjhYd05tTnBzc0RxRFFHTW52NGFKZXU1MWZ0?=
 =?utf-8?B?KzZ6RjFmUCtqeVVrZWpKQkdLNW9pZngwSUVBSWNLZ2VVL0ZZK3ZiTWwwd09B?=
 =?utf-8?B?V2JmU0lFRDNkOFR0cy9ibHVFV3BQdFVCOVFmdWpYL3RTZ0JTTVhPdFNDNFI5?=
 =?utf-8?B?eGlpdGRCSTVPcWxDNzVvVWloMGJGcFpJTzFKZG8wc2txdDlvZXlCYmFzRUJ5?=
 =?utf-8?B?ZlN2UWE3RjIwKy9FTzdTaXhHdjB5VWtlUW5jUGRqSzF1MDlXS29XNXFVNFVs?=
 =?utf-8?B?RjhzVDVvcHNJQW5lUVJxOFROZHVyRHBHUEtyZ28vUmpmczBienpjNmt4ZFJM?=
 =?utf-8?B?K2UrYjZFMWR5SmViakJHb0VxY2FQWUxqKzdQOTEwbTBsTVFOS3RGa09lZ1hy?=
 =?utf-8?B?dTltQTNtN1krSTFtTTArZFF0MXBkd1BTVmxIVWwrM2ZYYWhHOEFyUzRiTWda?=
 =?utf-8?Q?x6NGJPx3MDkm7LvoD6z7j3Y=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 2e15bfbc-8534-4f54-3500-08d9f60d62e9
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2022 14:12:40.5187
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YTi//nnT+/irAfNE79FTAxClRiGNI9m4ANXvOkmH1nGq93XgKkg2ORtN8YQAgxlYr4qIDtzYdGl3UxS/OSZFWA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6365
X-OriginatorOrg: citrix.com

On Tue, Feb 22, 2022 at 01:58:48PM +0000, Andrew Cooper wrote:
> On 22/02/2022 13:56, Roger Pau Monne wrote:
> > Switch from using a FreeBSD 12.2 to a 12.3 image.
> >
> > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> 
> Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
> 
> I presume you've got a private run showing that this is fine?

Indeed, it's at:

https://github.com/royger/xen/runs/5288917938

Roger.


From xen-devel-bounces@lists.xenproject.org Tue Feb 22 14:26:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 14:26:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276806.473102 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMW7Z-0005j1-O5; Tue, 22 Feb 2022 14:26:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276806.473102; Tue, 22 Feb 2022 14:26:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMW7Z-0005iu-Jz; Tue, 22 Feb 2022 14:26:29 +0000
Received: by outflank-mailman (input) for mailman id 276806;
 Tue, 22 Feb 2022 14:26:28 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=IN1Y=TF=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1nMW7Y-0005il-FD
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 14:26:28 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 6b3b78ab-93eb-11ec-8539-5f4723681683;
 Tue, 22 Feb 2022 15:26:27 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 59839106F;
 Tue, 22 Feb 2022 06:26:26 -0800 (PST)
Received: from [10.57.3.116] (unknown [10.57.3.116])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4046E3F5A1;
 Tue, 22 Feb 2022 06:26:25 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6b3b78ab-93eb-11ec-8539-5f4723681683
Subject: Re: [PATCH v3 02/19] xen/arm: lpae: Use the generic helpers to
 defined the Xen PT helpers
To: Julien Grall <julien@xen.org>, xen-devel@lists.xenproject.org
Cc: Julien Grall <jgrall@amazon.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20220221102218.33785-1-julien@xen.org>
 <20220221102218.33785-3-julien@xen.org>
From: Michal Orzel <michal.orzel@arm.com>
Message-ID: <d7f1bf5e-db03-7ca2-41c3-9738fe4f2bce@arm.com>
Date: Tue, 22 Feb 2022 15:26:18 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20220221102218.33785-3-julien@xen.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

Hi Julien,

On 21.02.2022 11:22, Julien Grall wrote:
> From: Julien Grall <jgrall@amazon.com>
> 
> Currently, Xen PT helpers are only working with 4KB page granularity
> and open-code the generic helpers. To allow more flexibility, we can
> re-use the generic helpers and pass Xen's page granularity
> (PAGE_SHIFT).
> 
> As Xen PT helpers are used in both C and assembly, we need to move
> the generic helpers definition outside of the !__ASSEMBLY__ section.
> 
> Take the opportunity to prefix LPAE_ENTRIES, LPAE_ENTRIES and
> LPAE_ENTRIES_MASK with XEN_PT_.
> 
> Note the aliases for each level are still kept for the time being so we
> can avoid a massive patch to change all the callers.
> 
> Signed-off-by: Julien Grall <jgrall@amazon.com>
> 
> ---
>     Changes in v3:
>       - Prefix the new define with XEN_PT_
> 
>     Changes in v2:
>         - New patch
> ---
>  xen/arch/arm/arm32/head.S       | 14 +++----
>  xen/arch/arm/arm64/head.S       | 14 +++----
>  xen/arch/arm/include/asm/lpae.h | 73 ++++++++++++++++++---------------
>  xen/arch/arm/mm.c               | 33 ++++++++-------
>  xen/arch/arm/p2m.c              | 13 +++---
>  5 files changed, 80 insertions(+), 67 deletions(-)
> 

Reviewed-by: Michal Orzel <michal.orzel@arm.com>

Cheers,
Michal


From xen-devel-bounces@lists.xenproject.org Tue Feb 22 14:59:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 14:59:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276814.473117 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMWdB-0000Yv-6b; Tue, 22 Feb 2022 14:59:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276814.473117; Tue, 22 Feb 2022 14:59:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMWdB-0000Yo-38; Tue, 22 Feb 2022 14:59:09 +0000
Received: by outflank-mailman (input) for mailman id 276814;
 Tue, 22 Feb 2022 14:59:07 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=YNC0=TF=citrix.com=prvs=045033034=George.Dunlap@srs-se1.protection.inumbo.net>)
 id 1nMWd9-0000Yg-HG
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 14:59:07 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f884fc56-93ef-11ec-8539-5f4723681683;
 Tue, 22 Feb 2022 15:59:03 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f884fc56-93ef-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645541944;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:mime-version;
  bh=SbeBTOi8zaaTys40RYF1aJeUs/XRONXLB321RxFIz9U=;
  b=VFd1G1fuQKFtAdCiESOcVprurdoKS/t/jGHh0kPD+FXmmR2/v4OI/NTk
   zIny4Eudq58SIFJ0sQhiPTJs/mYVC8IFF+FspKkw34rWugP89InkxNAvD
   poAkgbbRwP7mP2FDnZ7B9orIQI9PEMrYfNC3NsGdRljtwto7z9U0T98Ng
   k=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=hardfail (body hash did not verify [final]) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 64620795
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:c9AFo6g4Ndh6w5hq0vJHkdY2X161HxcKZh0ujC45NGQN5FlGYwSy9
 lOraxnFY6jUMyawOYxoOc7lxf41yZLdmoA1QARs/y1jHngT8ZrPD4zHdB2vYHnNf8OcFxI74
 84TNtKRd81tECaG9xvwO+Cx9SYj3PGGF+X2BeCZNngZqWOIMMsEoUsLd7kR3t446TTAPz6wh
 D/SnyH+EAergWJ/Pj5I4vLc8xky4K/7s28TtAYyP/0V7Q+PmSdIXc4Tfa2/ESD1E9JedgKYq
 0cv710bEkfxpUpF5gaNy+6jGqEyaueOe1DI0BK6YoD66vR4jnVaPp0TabxMOS+7tx3Tx4ork
 I8X78TqIesUFvakdNo1AkEw/x5WZcWqyJefSZRomZXOp6FuWyKEL8RGVCnaD6VBkgpEKTgmG
 cgjACIMdni+a9eem9pXfAXOavMLd6EHNKtH0p1pIKqw4fwOGfgvSI2SjTNUMatZammj0p8ya
 uJAAQeDYigsbDUIA04YVL0mht6oqVShXgEAsFiwvu04tj27IAxZiNABMfLQc92OA85UglyZt
 iTN+GGR7hMybYLFj2DfqzT127GJzXiTtIE6TdVU8tZFjVqJyWFVJAAQUVKjifK4llS/S5RUL
 El8Fi8G8/RsrhT0H4SVsxuQsFi57hkyXupqLsYi2Dyi5qqL+12zGT1RJtJGQIN/75JnLdAw7
 XeLgtfoCDpHoLCTD3WH+d+8vT60fCQYM2IGTSsFVhcepcnuppkpiRDCRcolF7S65vXqHRngz
 jbMqzIx750IltIC3ai/+VHBghqvq4LPQwpz4R/YNkqHxA5kYI+uZ6Sz9EPWq/1HKe6xUV6Do
 VAFndaf9+EECZyRlC2LT/4JFbvv7PGAWBXXhltqHoU9+i62026ue5hK5zNzL1svNdwLERfof
 037qQ5X/IVUPnahcelweY3ZNigx5fG+T5K/DKmSN4cQJMgqHOOawM1wTQmpxm+xv1A2qKEQF
 Mm2TZ60B1MBTqsymVJaWNwh+bMswyk/w0baSpb60wmr3NKiWZKFdVsWGADQN75ktctotC2Qq
 o8CbJXSl32zRcWjOnG/zGIFEbwdwZHX77jSotcfSOOMKxEO9IoJW66ImuNJl2CIcs1oegb0E
 pOVBxcwJLnX3ySvxeC2hpZLMuiHsXFX9y9TAMDUFQz0s0XPmK72hEvlS7M5fKM86MtoxuNuQ
 v8Odq2oW6oTF2iZqmlAN8Wk9OSOkShHYyrUZEJJhxBlIvZdq/HhoIe4LmMDCgFUZsZIiSfOi
 +L5jV6KKXbybw9jENzXeJqSI6CZ5hAgdBZJdxKQeLF7IRy0mKAzcnCZpqJncqkkdESYrhPHh
 ln+PPvtjbSUy2PD2IKS3v7sQkbAO7YWI3e26EGBs+7tbHGCpjDLLE0peL/gQA0xnVjcpc2KT
 e5U0+v9ILsAmlNLuJB7CLFl0eQ14N6HmlOQ5l4M8KnjB7hzNo5dHw==
IronPort-HdrOrdr: A9a23:Ee/9p638nuGQIfYsMiCh7gqjBGkkLtp133Aq2lEZdPUMSL3+qy
 iv9M516faGskd2ZJhAo6H7BEDuewK+yXcY2+Qs1PKZLW3bUQiTXfxfBOnZsl/d8kTFn4Y3v5
 uIMZIObeEYZmIVsS+O2mmF+qEboeVvnprFuQ+ApE0dMT2CIJsQljuRQjzranGe7jM2eqbROq
 DsnfZ6mw==
X-IronPort-AV: E=Sophos;i="5.88,387,1635220800"; 
   d="asc'?scan'208";a="64620795"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=dX9GonJmCgrLORou+RDpQ8zLT6ctHaTDNhYEEeOcyPstDNRm+SCx8hr5o4lKgi+A56XNnDsCbgUU/+QpkSXbTs7n/dTOWVeCvzKH0Q5nHnxtpr5VcQ7lQeZCYBPhbIsNcl0PJhxURHScqWBCWnc9RJVwRL/KJQ2jAkBfvAbYPh39tJVTUYKVg7bz4nuZDRHtHcOn5wZmPn2kTgvXf3qwykOUvWLNELWbvt3Q3B+F50THNe/WzMYIhDGeUGykDeBW7LBxFVGimR5TxxhgoTm4PAbaFtd8ipVivkRk7APtJAXXJBnfnVlQM2MM084xL4EoX9VN8I1BMCQdbtnFeXzhJg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=bh+7nbr3vVoSl/lXmNsVSWw/L+iZ3INry1fsyem5orQ=;
 b=bJsutHcPUYPowQ3K3o24X/s9FfdBSVSvT650QEjQtbBq3icaMBwdRSwTf1btsVUQVh20hr0v9futCqUdarkHNXmWvSi07JmWHXmn6LLE+ncelV6Y2blyZDiLDvffjJ82xpHwykM66CVTqaSFTRZHHEb5R2HpT6jQ3YxrjM28oQmaeQkRHKFwWXIbpYovj5bOzA2Rfgz1ML8svViyFHiDRzsIEh6+1xO6f3QXQnU3W18vfgFCHeJEkuTDBcAzObkU9HiTUhwkGDbX0WpIR5NjPQf7GFQD0YUWjK4Mqr7ADdWHnFWHgiAylNRl+1lHMYAEQO4izLFSwP/TK2x5Kc24Bw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=bh+7nbr3vVoSl/lXmNsVSWw/L+iZ3INry1fsyem5orQ=;
 b=jzwnNviNdNlPEaCs4GNYdFy0OjoOSprpVz3ZO8wTm/SBWQMuI/l5ahuwUnjkEcG2IR/0VSGNCveC6CAxwADBX2WVvkRlo/ueQpsdrwVuBNZoF79pH/G+hV4nnXZ0Bx1Bd5+QW2slJvV467UDqkbffD5eCwuYhT7Aeqgc51SrnWE=
From: George Dunlap <George.Dunlap@citrix.com>
To: Wojtek Porczyk <woju@invisiblethingslab.com>
CC: Jan Beulich <JBeulich@suse.com>, Ian Jackson <iwj@xenproject.org>,
	Committers <committers@xenproject.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, Andrew Cooper <Andrew.Cooper3@citrix.com>,
	Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>
Subject: Re: [PATCH] RFC: Version support policy
Thread-Topic: [PATCH] RFC: Version support policy
Thread-Index: AQHXkDev9/QrG+8IgUOEs2JU9EeShqt6ldOAgRojewCAC/K9gIAALOIA
Date: Tue, 22 Feb 2022 14:58:58 +0000
Message-ID: <77CD0734-A343-45CF-8A44-5C53771E404A@citrix.com>
References: <20210813113727.6028-1-iwj@xenproject.org>
 <de32c6c4-5ad5-862e-3988-0e7310ec3ecb@suse.com>
 <C6A7B444-4CFB-43A7-8FA8-AD1049F83912@citrix.com>
 <YhTUe7K5/rlek4AA@invisiblethingslab.com>
In-Reply-To: <YhTUe7K5/rlek4AA@invisiblethingslab.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3693.60.0.1.1)
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 66ed190d-08ea-498f-566f-08d9f613db0b
x-ms-traffictypediagnostic: BN9PR03MB6172:EE_
x-microsoft-antispam-prvs: <BN9PR03MB61723BE4100485C5A73DD8C9993B9@BN9PR03MB6172.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: QgD4gWIVc5Iio+OLE+XkldW/H047JxpVYojnO7GHU0J0HLahCLKA8v97Z+hfVPPaDRLSWUNtK4+MRmtdvEjTIGlwMXe6AK53N+PxTPy9qIJenyw7JWIdPnGmbP/czISzLYAtQHw+UKPP8+4aL30Jf2tJWXq6GTN5fpAbbhyga7aM+fy95ul+ZgZSptG2rnxpo2LXfT9gbnH7M5pRFneNPtkQrDtAriLcCLfPHEQFEOEw8jTMYTwNs1J8w6WpxeCYmF/hJJcv5V0rOCr0MYvk8IjdCek6NLHqstp0GphkymB/UrZyNfi78Wzqd7H4XaJJ+mjpSEgF7QmuL8xeuEnHEWa3mb8oLJbBr4oss3ftisWoGiy9FBgCNjZ0NE/ysUjNIowu1BsPfJJJgz5FjU+j7V+P6eodJ0tHKZIVVhzG3+IRnCfaGIBOO0DShGuUQOP6NZ9R5gRIRihzlHH6u7alD3nNAdinKl4YG8ewiX86LD282iiJmqnYyBebFhzCsKMHVybqQcw0pJ+9yaf2QMrNjUNdwEhyMzHfSNxujyrbTzKNQokOEE594GNIfGoS6gsKkmUVKByfRFS3iDKozVzcU/HnNFBSZHeeuRIMt9UpAXLLUlTDAGO01XbtAIle0EcKO2NH2Lu4DJQsFv1JyiTbhe6QvN+lM+0tmnbHPbqNQgRF7KTiwudv2q+MxioCCC2Vnokcb6FKxVKJ4yB2OcB1LBi7rg9Y7Ryda6zDaUMUGYnTjjAyK2VTIEs0KUlM4+/O
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(99936003)(38100700002)(82960400001)(2906002)(122000001)(38070700005)(5660300002)(8936002)(36756003)(6506007)(66446008)(4326008)(66556008)(66946007)(64756008)(508600001)(66476007)(8676002)(6486002)(91956017)(76116006)(54906003)(6916009)(26005)(71200400001)(33656002)(186003)(316002)(2616005)(6512007)(86362001)(53546011)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?TWJiVW5JTFZzbUhhdzdJNm9yNWhmSnJkMXhlQ1g2Mk5KeUluaG9pRkc5dkhJ?=
 =?utf-8?B?anJXMXY0dFBUZ0lGYk5UT291VjZyQTMzamdKWU1uY3RxSlpadUxSRTVNWDh2?=
 =?utf-8?B?L0JpaG8zRmxPSnhTK2JKV1R4ODROL3dHQmtSMnJ5UG1qT0I1aGw1aUJSdHYx?=
 =?utf-8?B?V3BjNzV4MG84bFI0TzJvaURpd1pFZDk2eUZjcXl5ZGNzai80VXY1SGZFNmht?=
 =?utf-8?B?RXFHbFRUREtCUU9OTzFLL0tLc3hYYmRlYjhCYk9tVWNSbzZuQ2R2am5RNDM4?=
 =?utf-8?B?Q3FtZzNNRXRwQVFUTitrbGJGL2FmRUlDVWd3OTVTSWgyQVBjWWs5bnRuMUZ4?=
 =?utf-8?B?Y3dwNEpXamZZdHNUN2tlUGV5SitNMXQvZGVxOUFldjdlcEdMNFZ5TVplamU4?=
 =?utf-8?B?b21xY2VvcmtMVHp4YkVwZkFmN3ZBb2xuem8xSGMrWnFReWxndWh6clUrNTMx?=
 =?utf-8?B?aWFWOHU0dk0rVVBjU3owYlNzM0JMN2dlTEVYM3lrRERrQ3V4emwrVWR2dFFi?=
 =?utf-8?B?OEhkTjdmdUJmbHJJckdqMXhGb0NQTGRvRDBUYUUzdGMvYjhqMUttTlIya1Uz?=
 =?utf-8?B?UEFZR3RTR1lzOHJlM3NpMXdUa0dYZVNqbEFFT1JLcjBIMytkbkhkZThVM2FD?=
 =?utf-8?B?VlFaUHAwMUp1YWlFQWdvVFFCM3UwUHdXL3huNDQwWVpEU2RwWXJYanRIVWJu?=
 =?utf-8?B?Q0dGSWRjUkpUaitjQlZXaXZqWmVwWDRMTVFXVGZjTEVjQ1lUdjhVRmJ3eHI4?=
 =?utf-8?B?NVRCWHJKSDVEWHdVZm1rRENYbGlSdjJqd3NWUWtNNVBJVE1JTm0xQ2VWUlJo?=
 =?utf-8?B?eW5OVm1XNHJGUWtwdjdzV1pnZjNPc2ZPTndLRmFsVTBITzcrVllKRk1HNm1B?=
 =?utf-8?B?bCs4YW9qSEhrM2lhNjd4a2p6Q09nZlJldnBkTVh5Ym13Ukg2SThEcTR0NExW?=
 =?utf-8?B?QVBtdHVmVENZQnB0UFJPaXhMSENvUDZBYWdwNVVMRDlZMlB4Mmx0NzlML3V6?=
 =?utf-8?B?dVFNU1dodndTVnkxSTFWZWdUSXo0Q3puaEZrRU9OWHdBR3Q0TlVrVHBISjM2?=
 =?utf-8?B?M29zeU90WHY2WFpLeHNFTCs2bVhYejVaR3NNRDVYdUphcThOV1pZd0htTW5x?=
 =?utf-8?B?b2hsMDlKSHdqRzFUeis2dHczZngwZ2xhbEg1a3h3M1dMOTliNmtqcnBoenBE?=
 =?utf-8?B?RWV5MGtSWm5NWXMvYVlldEVpc2pXSVZ3ODF4MXpLWTR1MzNuTHhIdUd2OE1C?=
 =?utf-8?B?NHBjWnM4dmF0NWUyZGxCSmRDY212M1hobmpDazU0U1lEc1JnU2hvbzdFODVQ?=
 =?utf-8?B?VVpoMzBJbVhEdFBkZEsyU1NxdFh6YjNwdnVqeHEyeFpkajZLcVlzeDNTVk0w?=
 =?utf-8?B?dmlUbHdpN3YvMUNKWVB4bVpXek8rSWU5cVk2cUdUQlFXTmpwelVBNC8ybTZC?=
 =?utf-8?B?Zy9NUEpDTFB4RUw4cVExSEhqc3VqMHplS05Za3dWejgrb0hjYi8xN0dzTFZT?=
 =?utf-8?B?SHA2d2FXWkhXT2tMcXNudHlhU0IzWFZaSFdsNmg4YUp0UllVVmhOd2ZYckto?=
 =?utf-8?B?WlF2ZWVJMERkZlc2UXpFWXZoek55K3BDdHBMWnlJbE9MNG5GcXFaYlBmU3lz?=
 =?utf-8?B?SWZxb0tMT0RqT25WclQ5ck5OUE8yb2RwOExGd0tkT3FnbksyMm1iMXU0YW10?=
 =?utf-8?B?WlR6NFZMNHFOZGU3S1pGaEgrcDEvc3pkSjVORDl3WXdOSUo3OEF5VW9GdmEw?=
 =?utf-8?B?Y1pzRGtiRnpFdHgrVjhFM0w3WGw2SXMrRk5KYit2NENDbnYwVWw2cVJmbzJs?=
 =?utf-8?B?UUh0ajJkWGMzUHVDMVlEaU9aRUdZNWhpdTRRamZDQXJsZTZHakJSaHJpREQ4?=
 =?utf-8?B?Zmw3cnFUaHQ5b1ord29nbHNNUVBtZTdDTnhmcUI4aTlGK0UrS3dFMjF6Nnpk?=
 =?utf-8?B?N0NpYWg1N0FmanB6ZGpmNlhRREkvRGUvOHBDMzJqWW85alpOVTNhekxwU0tY?=
 =?utf-8?B?dDdKOXRCNHk4d0MxQmV3S0g1am1WSkRIUkpldWFFOXVxRFVpeE16TkxZaW5h?=
 =?utf-8?B?UjJjQnYwYnRCbHUybmNVeXMzUnVtQThTWkZ6RkRiOVFlZTJJSkdBSFVqVEF6?=
 =?utf-8?B?ZHRJSFFTYlcza2ZSVE5uelpwcmc5T2VNY01YTVdhZHhDN0lPUzA0NGVOSXM2?=
 =?utf-8?B?TXFubnFrZUo5bXFiTWM4OVduTVV1UUdYZENhVjRxSW5FOFduUy9kVitUa2JL?=
 =?utf-8?Q?ukkPMkJFPJjZ3xtUvCW2A83cZkAd25DpsAN9oG00B8=3D?=
Content-Type: multipart/signed;
	boundary="Apple-Mail=_A06E5F1B-5227-4CE9-905D-B5426099A5B7";
	protocol="application/pgp-signature";
	micalg=pgp-sha512
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 66ed190d-08ea-498f-566f-08d9f613db0b
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Feb 2022 14:58:58.8307
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: pLJwjfXQ4EPy80mxVFsuREdUnN+9AKKLI0cJffUnoAOtPwN8cw3Cuyy9I0kAUI5s0D2xMjOBsGbxSM6Eg6kMn1z+3FCdHPVVgMiZsalrZd8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR03MB6172
X-OriginatorOrg: citrix.com

--Apple-Mail=_A06E5F1B-5227-4CE9-905D-B5426099A5B7
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8



> On Feb 22, 2022, at 12:18 PM, Wojtek Porczyk =
<woju@invisiblethingslab.com> wrote:
>=20
> On Mon, Feb 14, 2022 at 09:50:25PM +0000, George Dunlap wrote:
>> I think it=E2=80=99s too much effort to ask developers to try to find =
the actual
>> minimum version of each individual dependency as things evolve.
>=20
> By "find the actual minimum version", do you mean to get to know the =
version
> number, or install that version on developer's machine?

Well suppose that a developer writes code that depends on an external =
library.  The external library on their own machine is 4.5; so they know =
that 4.5 works.  But will 4.4 work?  How about 4.0?  Or 3.9?  Or 2.2?  =
Maybe it works on 3.8+ and 2.13+, but not 2.0-2.12 or 3.0-3.7.

I don=E2=80=99t think it=E2=80=99s fair to ask people submitting patches =
to do the work of tracking down which exact versions actually work and =
which ones don=E2=80=99t actually work; particularly because...

> The second part very much depends on distro, but all of them have =
provisions
> to install older versions of packages, though not all of them might =
carry all
> the possible versions (i.e., it might be that you need version X, =
Distro A has
> had versions X-1 and X+1, but never packaged version X). Again, if =
this is
> a problem, it depends on the actual package and compatibility =
situation.

=E2=80=A6of things like this.

 -George

--Apple-Mail=_A06E5F1B-5227-4CE9-905D-B5426099A5B7
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="signature.asc"
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEj3+7SZ4EDefWZFyCshXHp8eEG+0FAmIU+iIACgkQshXHp8eE
G+3opggAs7aE+/IoOnjKhDxed/xNjPNO/ZwbLUh75a691PqpRNDYoXm0G3PeJW9k
Dtky70he5j+IhDv+1e76DjLsYT1tYSXrZpoDOG2VJ+ZerHWUEheO2lqxMZ0DRAxN
V8spUmFdRfuXiJdcsgID/0mDCLljGI7h1Tt8qd49aDOqhu1wzx2RxHUwid/syiNq
UuMtu2tZXlSApAEZoiSWamjF0rt5mwUqqEj9tgAsq3xc7R8aIhuAk3qQSTKwB+M/
qfgBnm6lb12ijOLd7kwxyPmYswkhagOlvnTuIlm0Jp+KYiVRSo0lasS1LH3XxOky
k5IH3Yr7AhCf57X/Qz8a/+UU7Wz21w==
=l2XJ
-----END PGP SIGNATURE-----

--Apple-Mail=_A06E5F1B-5227-4CE9-905D-B5426099A5B7--


From xen-devel-bounces@lists.xenproject.org Tue Feb 22 15:05:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 15:05:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276823.473128 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMWjG-00022S-UD; Tue, 22 Feb 2022 15:05:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276823.473128; Tue, 22 Feb 2022 15:05:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMWjG-00022L-RL; Tue, 22 Feb 2022 15:05:26 +0000
Received: by outflank-mailman (input) for mailman id 276823;
 Tue, 22 Feb 2022 15:05:26 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=QzH2=TF=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nMWjG-00022F-5o
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 15:05:26 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id dc83d54d-93f0-11ec-8539-5f4723681683;
 Tue, 22 Feb 2022 16:05:24 +0100 (CET)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2111.outbound.protection.outlook.com [104.47.18.111]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-39-Dhwefaj4Pdifxm4r8_QdxA-1; Tue, 22 Feb 2022 16:05:23 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by PAXPR04MB8687.eurprd04.prod.outlook.com (2603:10a6:102:21e::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.27; Tue, 22 Feb
 2022 15:05:22 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.4995.027; Tue, 22 Feb 2022
 15:05:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dc83d54d-93f0-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645542324;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=1cqXfdTdjqNxFES8K9KyGRQOYEZ0CBiUZwflHPlejhU=;
	b=KErO2s17o3YUuc0Ut+27hl9A1Q6Y/VLRI2eOa8XOE7b0Awv0YxTCa/dCejF352LelTOCYg
	gkgAHI3bOUh7dHXUvkOYZ5IJy4XlLd2Vd3/2And8YlBM1rdo/obCEvVAIDSttZcz1O4BJT
	rsgfxKPs6oPWTjbJVYBvfqofu1B1fAc=
X-MC-Unique: Dhwefaj4Pdifxm4r8_QdxA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=PGk9ncOoF8ehM6mnjLPfItl92S+PguH43f/xLL0JwkxC1mqJUgk2/vZjop7wLJqT9pwubRgUvmvyZW+iwpBUMJtMLMIQoQtETdEVIGLmoBclvgZEbKZibPq/0QnQltJWRlZxpVH5buHonIaZqEov6BgKw+YH4O2Dt9TY4w6SfpJKgD11X2DJQkHwBuN05601sFX6U4+lit0Ws+2apGZM30QBgSPqx8C9YoN0mL234ljVQgGIFSWOk4rpOH2ALpA/GX263XJygcuYKy2Wl3lu+QEzVY61ErPy/txRr6HU9IIjd2T8hfdhHrzEppvZodw3q34XQaLFrGSUUyNTZiH8Rw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=SdZoQxKhAUVuPLjmymg2wECbeaWHsOatd93AP/5RoZU=;
 b=it53A9e3cDdpizpr8CwcS9xd0qwInDOuUrPR3aSJLwqpN/BCqK0NASgmXUMZleNRaGc+OOmDmgz8rcidWXp8HGz34Xg03I/4bPOOShppqRcJbEnOL6C2UQQXipgryjVH0vnxw3wsBTHlgTiI/yympLoi6kFDDJ1hucYZeY705mqYaz92FhkFcGRqhrWwjWz5jKYjcLTOwWCecN6yncFwxa8nXG6M45gEmXwh6zC3EV8V+OArWdvIjl7WLMWBCTVy2N+jSTmFKTisdL2TW9gRLjoMJ/IhNbNCPgDFbrSfsSjqGnL69C7GUgblzWOXgJtvH60VpFsjlCL+sBtj+eySgA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <f5c50526-2fdc-029e-751d-eb05b29a8366@suse.com>
Date: Tue, 22 Feb 2022 16:05:19 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH] RFC: Version support policy
Content-Language: en-US
To: George Dunlap <George.Dunlap@citrix.com>
CC: Ian Jackson <iwj@xenproject.org>, Committers <committers@xenproject.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <Andrew.Cooper3@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Wojtek Porczyk <woju@invisiblethingslab.com>
References: <20210813113727.6028-1-iwj@xenproject.org>
 <de32c6c4-5ad5-862e-3988-0e7310ec3ecb@suse.com>
 <C6A7B444-4CFB-43A7-8FA8-AD1049F83912@citrix.com>
 <YhTUe7K5/rlek4AA@invisiblethingslab.com>
 <77CD0734-A343-45CF-8A44-5C53771E404A@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <77CD0734-A343-45CF-8A44-5C53771E404A@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0079.eurprd06.prod.outlook.com
 (2603:10a6:20b:464::13) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 6f5c8579-135d-4367-ad36-08d9f614bf38
X-MS-TrafficTypeDiagnostic: PAXPR04MB8687:EE_
X-Microsoft-Antispam-PRVS:
	<PAXPR04MB86878C8D7C330241C419E46EB33B9@PAXPR04MB8687.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	4qO0ZZ/SDLrC7W474MQtQK5HZDexLa9O8wsuUDaLTjtmccNSgCTQvo8WH1iC/CDTUCO3nR2eai754/odWk1PoVAAr6c0ImWEMZbHDW0dWABlNDAELaeqOantqXem+8kha50PMhkzu/Xv2xa6C3qRkU4A/zP5kTjmwqNK113nHevznDAlV6I3C6bQAWNZxmMgwe3jXOv58qU0urPa3raGAAMBr1RqlZqfHkQHsarfAk2/CSn+2kdsg3RhaOjoNlJ/jrepiadHhAPfTxqMTGaOAl/pEzkt9YO/YKi94+UHzQz+wkTAS2Wc8y6EyLDtVX6ybK+0zRLystlHWKgQ4G2zi/TcRTO8aNOsEFFiYD55EQ6b2A+cMlJSlSD7HTdT5/yPNS9RV8FDj97aCv7vgZPtYhxVqGc4Z7KGHWZwatE7fVFEeBidHdb7jJ96+zA7Yd2LMGpeaU0BfVNHHgJKKI+erkmZnHM7bjhDPx4J2YxUOSsq30pFzsJ8vqVv5ivSHxrBkYOp2uO8eqV+fr4GmUE/92hOpMlJEufObiLMZqqqbSKrZUMa0oBG/QE3N+R+xgKak69PKirtZIKFGKoIpW98YokN8tSq/u5eib4g2MJoV9BYfyz6kCghvtjGPfIv2Ct1psaLKqvZiJ7Fk7Z+kHYYUUA1NIx0qgwD8Ehpeiro4iI7o7yaVhR0PmHxASyFv1ahh/Y3iYUVrGTloya3i2AuWGTWkCbTIulvRKrubv00RyixxrGfjMccsPYHMwB+zw0j
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66476007)(38100700002)(6486002)(66946007)(66556008)(36756003)(54906003)(316002)(6916009)(8676002)(4326008)(31686004)(508600001)(2906002)(6666004)(53546011)(6506007)(8936002)(186003)(26005)(2616005)(86362001)(31696002)(6512007)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?TvX3Jusm623ZC5318BvXKelYVaK7eTJUltn8LBYHTcHPnFcjfzsJJTpU2JoQ?=
 =?us-ascii?Q?uoLHvq0eV+XInaEHQsbl0PZj/gN14DhhYeY74suoLsYNDNC3PbeFYuLUB20w?=
 =?us-ascii?Q?WIh3DR/C2JyH3UshnW35OdeIUbV5HuhNg6Ru/mdq/i9AWYPeZoTPQy0NyVlJ?=
 =?us-ascii?Q?3KOtd6uWxXv/XKiGuo/Dg/+7fdoOPjDi8l8AQYPhlnEx4KHopIt5t5HjPX2E?=
 =?us-ascii?Q?z71Y5l5qxsdP+rFQo72q6yG8D+B/R7x3UkEVNmQo5PTFdI8abnwubJDb+Tbf?=
 =?us-ascii?Q?ADvlVJYdKtNVrpHzUsobDYe8efuOsZhHRTsF+kVgEmQ/SQpfAJe/TmxQYW7V?=
 =?us-ascii?Q?eX/r078rr/b7cm5RvAPgmu54n6uGVJ4irrqU/DEPtcTKeVWQn/b0tKoAhvjG?=
 =?us-ascii?Q?yY6ww6K2MoFP4qDnM3L7mwXBYBnfkXrFBZxcHpkWSEHpIVcXo7mxtFPTMyx+?=
 =?us-ascii?Q?CIiTVyDSkgqp+dDr3TYynbvs5bcPXKDtKg0el7+A4grgY/JYtKpG60W0NaVm?=
 =?us-ascii?Q?VBBiU2Su/qToyp2znrDbzEaESshq1BSWwlTKKPwKi/Zlc2rGIcQAvSba8vRv?=
 =?us-ascii?Q?cweApPim3QeEP1JbKsHfzfIPjcBMIg0zbZIqgSzHxeXkbkoaAlbMOjZq0wrk?=
 =?us-ascii?Q?nbP9lKS4lhH7QTTVZLCk4aJg3EyWDpTBvm+y3ZTpQ9H/UPFLmDedNxvr9Xgo?=
 =?us-ascii?Q?QdjZVDt0vkvQhTqu0KPQvNP4MA2LRD7HhhDuGoYRaW/t/zhmFIWufXKOIgFl?=
 =?us-ascii?Q?OEHG1cxNTQGDYuYBEIMxTpPJsg4MdJdX1hLHF0+bdSiPn0CkiJDufGpN5Pl5?=
 =?us-ascii?Q?1fJpriNMciKXA8xG1GMjzMjfHyjv/eQHBWIoJLJM0L1Vsal5EIZ10GC6hKRp?=
 =?us-ascii?Q?d4ScuHWN1CCQ0g2hFbUv4eAjhMqmuwGum+0uZNE/xgBHonwJ1/AJyWkaxRQj?=
 =?us-ascii?Q?OyacYYCVNEhG1cCCbKszhCflY7swPpOxt2ikOwZ20UTjw+wRTkvfikXVsb0i?=
 =?us-ascii?Q?D5OHlCiJQfwO5+CBoI4USSEhwgi/2szeNqMPqoxZO3ru+NYdQ0yBb/o77sGH?=
 =?us-ascii?Q?/0FnG7pqhj8DlJe7gMeKGXrJEVf8asRirf+0WX1ieOTZy7nnHJsQvIyNesXU?=
 =?us-ascii?Q?TiyTN8hR8C2YNu/wGvDTTFrHyZZeLm9+LNTVeCQ3exiEnBJuIQl6nyAkvMrf?=
 =?us-ascii?Q?AWCcWbTorJDHTI8zb8ab8orcYkfOTOTj5dqva0hu/DVWualDaGQUGj/TlnQB?=
 =?us-ascii?Q?2UvD49woG5MhNdkn9EP7tXMb4anh9HBWn9P6Gk+kM0Puqs5DTlpCBrtKAnkJ?=
 =?us-ascii?Q?x3f8yKPnylj8tO6uU9w7Al65gI3AcMUjTHDAaB+qz0T55cV3aczdygS1Eumu?=
 =?us-ascii?Q?jnlS7TnDERwoIkmnDlXBKmkj9caS18MrTsas7VeMLkPDDUCu8eOIuhXiSx9J?=
 =?us-ascii?Q?MPTvEaA1v7yg6H0IE9xlUafruFDkb88glOejFs5ZSdE9gDXDDOyG2n4/S9FS?=
 =?us-ascii?Q?omUjQCpDGQQlfRCuuS0CpuSiGUcOhjReRoeBt/+LlY72uEojf8nakDJymQhf?=
 =?us-ascii?Q?ZcNAqLGMPIbft0ozNb/Lqqh7as7uDZPuCkfYephQFemBKVUqx9ah04foN1wn?=
 =?us-ascii?Q?kxp3naAjG4K0m+HG+cGJWpE=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6f5c8579-135d-4367-ad36-08d9f614bf38
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2022 15:05:21.8983
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hVdwH2jeyZdeVk3p6fEE3l5dM07vMmPiKdPhLSUe4rjrVf4ERXtxTf5SFm06oHGXCUIi6kqu8OFve1Bn5GvbCg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8687

On 22.02.2022 15:58, George Dunlap wrote:
>> On Feb 22, 2022, at 12:18 PM, Wojtek Porczyk <woju@invisiblethingslab.co=
m> wrote:
>> On Mon, Feb 14, 2022 at 09:50:25PM +0000, George Dunlap wrote:
>>> I think it=E2=80=99s too much effort to ask developers to try to find t=
he actual
>>> minimum version of each individual dependency as things evolve.
>>
>> By "find the actual minimum version", do you mean to get to know the ver=
sion
>> number, or install that version on developer's machine?
>=20
> Well suppose that a developer writes code that depends on an external lib=
rary.  The external library on their own machine is 4.5; so they know that =
4.5 works.  But will 4.4 work?  How about 4.0?  Or 3.9?  Or 2.2?  Maybe it =
works on 3.8+ and 2.13+, but not 2.0-2.12 or 3.0-3.7.
>=20
> I don=E2=80=99t think it=E2=80=99s fair to ask people submitting patches =
to do the work of tracking down which exact versions actually work and whic=
h ones don=E2=80=99t actually work;

But somebody will need to do this. If it's not done right away, someone
(else) will hit a build issue on a perhaps just slightly older platform.

Jan

> particularly because...
>=20
>> The second part very much depends on distro, but all of them have provis=
ions
>> to install older versions of packages, though not all of them might carr=
y all
>> the possible versions (i.e., it might be that you need version X, Distro=
 A has
>> had versions X-1 and X+1, but never packaged version X). Again, if this =
is
>> a problem, it depends on the actual package and compatibility situation.
>=20
> =E2=80=A6of things like this.
>=20
>  -George



From xen-devel-bounces@lists.xenproject.org Tue Feb 22 15:10:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 15:10:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276830.473139 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMWoN-0003RF-Hc; Tue, 22 Feb 2022 15:10:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276830.473139; Tue, 22 Feb 2022 15:10:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMWoN-0003R8-Cb; Tue, 22 Feb 2022 15:10:43 +0000
Received: by outflank-mailman (input) for mailman id 276830;
 Tue, 22 Feb 2022 15:10:42 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=QzH2=TF=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nMWoM-0003R0-BP
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 15:10:42 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9966822f-93f1-11ec-8eb8-a37418f5ba1a;
 Tue, 22 Feb 2022 16:10:41 +0100 (CET)
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2051.outbound.protection.outlook.com [104.47.8.51]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-41-K9TkBNYLOr66SrwZN1FCBg-1; Tue, 22 Feb 2022 16:10:39 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM6PR04MB6424.eurprd04.prod.outlook.com (2603:10a6:20b:fc::31)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.27; Tue, 22 Feb
 2022 15:10:38 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.4995.027; Tue, 22 Feb 2022
 15:10:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9966822f-93f1-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645542641;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=dwle2ZXWZAzJEDnA7YWLNnVgGg/0YIgqZybk8TMRx34=;
	b=Hjnuw92iTGLbjaQDKMRsmH+J1adm8Y/iQJAGG7YCKRvisFwdcn6hj/AoEeQXpzdXJR16nn
	5tRrcNGx9B2orozqydD03CeGfUBiBs3rOuQb9eQ2SbRxBFBiWcv8ntEYVY7mccHB4wetpD
	RmEWEhbG+lj/qfocPRmqJ+88eRC69PU=
X-MC-Unique: K9TkBNYLOr66SrwZN1FCBg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Wcrb5epgzK70DlCDNDtPEiBK612Yl5zYa6x7Sg4Tm+UGmBWRuiWMUdX4IKJzF31YCwDp3knGX0Ze5sfrVdUeOJambsIDm/uMVDTPZ+G8pHA5SCGRvipkXw72Vc+tvIh9OS8Yl7Cu+rngompvmczl7O5wTTzZBRKX59y1x7PpTjlsL89W78SwVq+e6wuEODiOSA77mfyKemXlbRwOoFgzPGcsAZKq4Ey84J8YV88QK37ImP4MPuqJzJxD+u+ta/4BXSimJpboshAw3h3NaqOObS95YZ633OMR08YjsCUbqOmJnWmOq8A8PqLu8PELlCoU98fMAXAxNdhX4oD1fko3MA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=dwle2ZXWZAzJEDnA7YWLNnVgGg/0YIgqZybk8TMRx34=;
 b=T8O4JwnlNPGaGG6F5ldExyTGN9zZdlUCwA2ZA07dqjvJg3h83g1aT+QI9Uq8rGsCHgDO4ww2XhnRYooL/eB3BXE7iSEC8KIElh2ygyc8DdvkO+ynJvZ/fgFbTxSiqpPD55HwuOhBKgc9mYOaZ68c60yFGuEjTMqNyLCvbopNSL+xe23ggfEbGvDCaYqzKRh5yTQ1nm+ixQfLIK7DRCXWmvErre7Hit2yd3b9Et3QhNa5gXB3YdOpfnCebSNAHMOBQ+yM0+g71+nXIVDQeP+x/PLIELsHzNHPdBY5zHIWiw75EaGMzNmnZodVyH6tO2OWaMnz/U2T2J1xPCwp1jkClA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <33dcff1c-ef64-952e-ef4d-b270b2f1d724@suse.com>
Date: Tue, 22 Feb 2022 16:10:36 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v3 13/19] xen/arm: Move fixmap definitions in a separate
 header
Content-Language: en-US
To: Julien Grall <julien@xen.org>
Cc: Julien Grall <jgrall@amazon.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220221102218.33785-1-julien@xen.org>
 <20220221102218.33785-14-julien@xen.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220221102218.33785-14-julien@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR04CA0012.eurprd04.prod.outlook.com
 (2603:10a6:206:1::25) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ed36a2ae-521a-42b2-190f-08d9f6157bde
X-MS-TrafficTypeDiagnostic: AM6PR04MB6424:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB64244E0A5A7F53E39B9CD836B33B9@AM6PR04MB6424.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	m/JrhKy6CIiqvnAyro8raE7rmfSD/vbGMHSOUu1ZnKezs42WyMV2woH+iwLohr1atIkPxAfq8XTIgS+av66pd80L79PrM5LZPu9/DPUVEW5U706TUnWrTXnlbROKtLxDiwORfP0JwwE9gwPayz8dOjyDP0ZvOC5dnjmMgGH2My9iZbMk97RoawQzlviD3qAZbH9GerIJrmXsdghnYbR+2xnluc8FjmYpasnrZjkXuWoJTOmf7ZQIZcDiSeosSXesHiN3sz4Auw6bQUgIgMcpcWbKxGLZa/xsAaZMjDUbSqifIaWxkJuGurdIHE56NM+nzfrlSWJfHRtTHQ2flU2uDBly+Gs12JiMjgczQHS94W/c15uXGeqeq+kq0guTOK/9sVwtKHKYmUsRCYPP9cirUyDYgwCAIB/wv6kX79fLVWkXJoqy8EnoWhQSghIJWQRqPNvP9jXmOFXykCjpFct3hlIgB0KWl4+gVBnFr+iozI6v+ovMw5YLMUg5s2600i78UM4SAe5F7GXb5vYApiI8cDlD4a0AugpIAOUo0nukRpuilrf3Xl0VDbK+e7I/BLtyt+J7VDwx5ohdYJamQPOlhv2P4BmdUwDcv/lpBDfGhxBHVSflKLVTu33nt+YEbrQBlj/KxtMGjP8LqT0ZP3H+Gy2ZYuXSXkcQTF43UfrZNcZdt9bTNEKbO3RGNsWZKbKUbszC5sD+rgiff3cwWEXlFc2AFKDT2wO+qwWoyYOAVUKqn9XZW6bVe5XIAM7uZXGy
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(4326008)(36756003)(6506007)(2616005)(66946007)(5660300002)(66556008)(6512007)(66476007)(508600001)(6916009)(6486002)(316002)(31686004)(4744005)(8676002)(8936002)(186003)(26005)(38100700002)(2906002)(31696002)(53546011)(54906003)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?azhYb2tKd05jV2cvYmRkeElVU0VlZUM4bzhqQ3ZSVkIzMFU4QjhhMTRWaWJ4?=
 =?utf-8?B?cmwvZ0pROXRkTzVBTFluRFA5MXlrTHBYQWFxN21KQkIzV3B1ZW0xSytuRjRT?=
 =?utf-8?B?eTk4ekVZY0pRdmNpeU1adldJMEc5NTBVOGtUZ3JrWi9uaDErbW9LTFdOUENn?=
 =?utf-8?B?MVo3Z0NLb1c3YlkxU3RhTVZueCtVeWdtVWFOTGsrU1ZpZTZCVVlJWHozdmF5?=
 =?utf-8?B?dzJ0eXg4Y1I3NTRyNEtDVzhCQ2p5RjlXSTZpdDdYWWt2WUd3dUJWS0NhS3Bi?=
 =?utf-8?B?azNLOFMvRWlVbDVzVXdpWFZCWVMwYjJyakNQL244eWtWZk00YXNnTnpzK0JI?=
 =?utf-8?B?N0I0WEo5VHU3TGpFcHB3cHAzelVMZ1U5Vm1ZMGhLTzVGWVFpV05WQzVONURM?=
 =?utf-8?B?QTJQM1E2WUV6NlczK0doS2dNdnF0OWpZZ1B2SGdxSStDQjYrcjBKaVhQZmJU?=
 =?utf-8?B?Wlc2VHgrNzBGYnh2Z21wVUEzNytHMHFra1A2YUU0VFdkdmlLU0VyTnltUThO?=
 =?utf-8?B?ZHNxdWwwdzRQcGlzYjZtZmxWdFkrNHVlazEwdmlXL3hObHFML0hZNG5IakFU?=
 =?utf-8?B?ZlRHbVpoYkN1ZlBaNzJoYjFjdVFPL0pZcGEzVmRVUzRPWHdmc1Fkbi8rdXdZ?=
 =?utf-8?B?bzNGaU1DVGFjM3Z3dlZ5b0twQUJnTmFFTDdIWmo1R2p6Y3hMZEg2OUVGdDF5?=
 =?utf-8?B?YlQvL2RRVTQvZWsyWGNlK3YvTFgzMzNWaUkzSUIzUllkcjlTcFZ3S1hBcURi?=
 =?utf-8?B?Z1FQb2FqcDhPTUNDYXNZcmdLQUhkZEhCa3puQ2lBN1hiQkVLcGE4eW1zQURl?=
 =?utf-8?B?Y1FqL0F4aG5yd3E0RjFyMGlmTzZickNvWUF5V2lPb2VVOXUvdnpGZGZlZkFU?=
 =?utf-8?B?Y3l3WGtKYmtBZ3FQTmp1T1FpMW9OUEpTOUF5c1QyV0xFS1EvcHFseW1wajVH?=
 =?utf-8?B?d09mVmxlVmVmcWxuMVFDNXl5cmlrSXlGTjQ2SlRpbWNubVA3NXdCaGVDS3gz?=
 =?utf-8?B?TDMrdm9oUmg3eE9OL2VLMVlrWkp6a0lLZ2xEeEx5aEthczNGbFZrQlZ5S3Mz?=
 =?utf-8?B?aHFmQXNrL3dxTEcwZHcrMndHYzRsRTExWDhPbU9jdFZnSjIwVGRRZFVacUVR?=
 =?utf-8?B?aGJUNzN6Nk1sUUN3MC9VaGJHT1RUczdXV0VzWCtFUjFXWkdJdHU1elFxU2s3?=
 =?utf-8?B?OFhGYUJRSXNodkpydWRPdVliZHMzbGgxY0R3TFBZQTRlcndta2liZm14NjBC?=
 =?utf-8?B?L0dRbUloZWE1U2pqNHl4d0lCeUl6UXJGWmkxNWRCZ3B5eGNMcGhFaVF1aVBH?=
 =?utf-8?B?NndrRGhLNlorRVBFRllWdDlnZWZYN21veDVLaHpNSDZaSEtZcHpSOHdUd3lB?=
 =?utf-8?B?NXBXT0RTR0pYNWtteVdscFF3bmpOL1pyU3FaaUtBU1dOUkNGempab2xqVUJZ?=
 =?utf-8?B?K1JjbGRDTUlDZHczdVhnYzlXZ01YTk9uSXcweElFSmRJN1gxS0o2QVJERloz?=
 =?utf-8?B?bnZFSklINjRUVzgvSnlSanVBSWhYdGduS3FpcGdrNW1adElIWEMxMld2QTdH?=
 =?utf-8?B?MVNOcWRNK2pBTy9nWW10VkdzR3gyZEdXUm9ET0s4aGRDVEdMUjJxWHY3VXlH?=
 =?utf-8?B?bVMrOHpYU1RsK2RRRjBDZ0VzYkE4TitNRmVFWmRWU1hvS3pOMEpaOWcxVmdp?=
 =?utf-8?B?Q1VvRzF1c3RiTEVvbHNRTDE3UWw5azBINlBqZUFpYm9lQTc4alFMaCtVbXFj?=
 =?utf-8?B?Ulg1UHp2c3BNYnlhNUhWdUx6Ung4NlhhRXFvU25LeEhHYWN4R0JZbWU1RFlv?=
 =?utf-8?B?aEpDTVljdy9qVWNKOHh4QTdFM1JhSWp3QXkraytIQVZ1VlVSWGVzK2dhamMz?=
 =?utf-8?B?RjhXV01nTHF5NmRqNlhTNWNxN2t3cllkN2FrVHY2dytuV01NK1NjNEc0aUU4?=
 =?utf-8?B?WDlROVNwUnliNkNLNWpPUXgzOTlYdjg3eGV1SU05U2EzaHRxQWxwUWI5ZTJa?=
 =?utf-8?B?elByNFJLQThsYTBBNGg3TlpQMEVLcGhNL0lQU0ZMWGYvcTI1SUpwNHh1eHZN?=
 =?utf-8?B?UVR2Y3F2TDVlVDN3b09vMjNjbUwzZ2RUM3YrZjhQczMrNlNFN0I5MUkvYllr?=
 =?utf-8?B?aUVlUDhrTnplSnFaQUFJeEg1QU5Ycm5EVlpwQUJ5TmpuWGFOZEVUNEtZNU41?=
 =?utf-8?Q?y8NldhVgrzU7DNRpyWtZS/c=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ed36a2ae-521a-42b2-190f-08d9f6157bde
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2022 15:10:38.4253
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TPSb/PNfh1CydVZXcFSRnolOxZNUaRZ6CsmT+dCvbFWY0TMh13VrWhlUWUArvqHvkTwcAMA9/0Ymr42MCcL5qQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB6424

On 21.02.2022 11:22, Julien Grall wrote:
> From: Julien Grall <jgrall@amazon.com>
> 
> To use properly the fixmap definitions, their user would need
> also new to include <xen/acpi.h>. This is not very great when
> the user itself is not meant to directly use ACPI definitions.
> 
> Including <xen/acpi.h> in <asm/config.h> is not option because
> the latter header is included by everyone. So move out the fixmap
> entries definition in a new header.
> 
> Take the opportunity to also move {set, clear}_fixmap() prototypes
> in the new header.
> 
> Note that most of the definitions in <xen/acpi.h> now need to be
> surrounded with #ifndef __ASSEMBLY__ because <asm/fixmap.h> will
> be used in assembly (see EARLY_UART_VIRTUAL_ADDRESS).
> 
> The split will become more helpful in a follow-up patch where new
> fixmap entries will be defined.
> 
> Signed-off-by: Julien Grall <jgrall@amazon.com>

Acked-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Tue Feb 22 15:21:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 15:21:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276839.473150 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMWz5-0004y5-N3; Tue, 22 Feb 2022 15:21:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276839.473150; Tue, 22 Feb 2022 15:21:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMWz5-0004xy-JC; Tue, 22 Feb 2022 15:21:47 +0000
Received: by outflank-mailman (input) for mailman id 276839;
 Tue, 22 Feb 2022 15:21:45 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/+sy=TF=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1nMWz3-0004xs-Lp
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 15:21:45 +0000
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur03on062c.outbound.protection.outlook.com
 [2a01:111:f400:fe09::62c])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 244c0b16-93f3-11ec-8539-5f4723681683;
 Tue, 22 Feb 2022 16:21:43 +0100 (CET)
Received: from FR0P281CA0003.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::8) by
 DBAPR08MB5861.eurprd08.prod.outlook.com (2603:10a6:10:1a3::8) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4995.16; Tue, 22 Feb 2022 15:21:39 +0000
Received: from VE1EUR03FT009.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:d10:15:cafe::4) by FR0P281CA0003.outlook.office365.com
 (2603:10a6:d10:15::8) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.21 via Frontend
 Transport; Tue, 22 Feb 2022 15:21:39 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT009.mail.protection.outlook.com (10.152.18.92) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4995.20 via Frontend Transport; Tue, 22 Feb 2022 15:21:38 +0000
Received: ("Tessian outbound 826a6d8e58c3:v113");
 Tue, 22 Feb 2022 15:21:37 +0000
Received: from 1da513be42aa.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 07908EFA-249C-4D96-85D2-07C563C75125.1; 
 Tue, 22 Feb 2022 15:21:22 +0000
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 1da513be42aa.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 22 Feb 2022 15:21:22 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by AS8PR08MB7338.eurprd08.prod.outlook.com (2603:10a6:20b:445::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.16; Tue, 22 Feb
 2022 15:21:20 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::aca7:79c4:fa65:dac6]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::aca7:79c4:fa65:dac6%5]) with mapi id 15.20.5017.021; Tue, 22 Feb 2022
 15:21:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 244c0b16-93f3-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=P1Sg6hmdGSK+VnQcAqi4CNwLfN1N+8PC0oP3vF7S+a0=;
 b=IYW6sqDnW0Tx1UO62Vrqk9WkTRg9YQ6+sHvtDYmjtrUFR4GiSqxcXP2Cj1elDdjDr9d6QExJ3SvJWwrO7I3w1qu0zhL3V9zllCvPMJDI4KB9rZEd0+bJ0mq96tNto0MQfk8Yt6ci7TYW1fBz/7Xmh1Rn7ePpPEoZetqc5NI1/og=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 8be3d795d342b181
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=BtlEFej1kKjLYlfduQO+GbCM215cmg5lQF0wh4dW0rHOtTVo3iKOEw56LxlhOrINGH2B85srkFPzbWHvLkIXdIB/qQnFDAau+thm3NcTaZOvC+DdQpKOSM8i/bYkVq5rmsYrf2S2NXi0aZemoNDtJOlwFJCKuHTl1XFpViPNotwieqM1kkzeRast0jiLiOLnYdCzWHg7TpByOn0WQgABbEBOJw2uYRJMTkgt72ruK+zPbRDq3NRaY30o1XcTaY7MfLDSL/BD8yEa+sJ6neFcQ+qU9TwA2NKGBV8mhKhYWK8UJhX7zdwnRtKrCBUKDGs/LBjeaVH8qTp9ZJd+lrxjFQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=P1Sg6hmdGSK+VnQcAqi4CNwLfN1N+8PC0oP3vF7S+a0=;
 b=iA5o+hXHPjhNLU/frNNdbRZB/aa4tvj3hL+mxZrDFcSl2XQP0bPPpE8N1W9ner7fJfqOhvY6bSTRiQ4ttGwBhKCyh7pWWsXIJST7c4lZB0ESuwKCzj9jsYZD1Pwk66PJZhLgeIoAl96IORcZy1Il58o7cCqp0kEjbJ8l0ufPYo44WZeVEcwC8A/ODKMRgxmYg8nBVl1wnfG1aGNGrkMnKYauCORV3KZvDjS1kCHsGm3x91OStciUQtjvCaZVPo9NbjrZRembUW69uuIHk9v95NkjrddROEvW/UQ6GkAkfgSGQudPI3N+Xxe0TS3B7H45hYdiq8ZlV4F3ze/mTI+xAg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=P1Sg6hmdGSK+VnQcAqi4CNwLfN1N+8PC0oP3vF7S+a0=;
 b=IYW6sqDnW0Tx1UO62Vrqk9WkTRg9YQ6+sHvtDYmjtrUFR4GiSqxcXP2Cj1elDdjDr9d6QExJ3SvJWwrO7I3w1qu0zhL3V9zllCvPMJDI4KB9rZEd0+bJ0mq96tNto0MQfk8Yt6ci7TYW1fBz/7Xmh1Rn7ePpPEoZetqc5NI1/og=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Julien Grall <julien@xen.org>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Julien
 Grall <jgrall@amazon.com>, Stefano Stabellini <sstabellini@kernel.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v3 01/19] xen/arm: lpae: Rename LPAE_ENTRIES_MASK_GS to
 LPAE_ENTRY_MASK_GS
Thread-Topic: [PATCH v3 01/19] xen/arm: lpae: Rename LPAE_ENTRIES_MASK_GS to
 LPAE_ENTRY_MASK_GS
Thread-Index: AQHYJwzyz49F2mM0IUmkmDU5Z+UrjKyfsZUA
Date: Tue, 22 Feb 2022 15:21:20 +0000
Message-ID: <5FD206B8-D32B-4AD1-92E7-31BAFCB73AFD@arm.com>
References: <20220221102218.33785-1-julien@xen.org>
 <20220221102218.33785-2-julien@xen.org>
In-Reply-To: <20220221102218.33785-2-julien@xen.org>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3693.60.0.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 923733b2-0f71-4efb-7ffd-08d9f617057e
x-ms-traffictypediagnostic:
	AS8PR08MB7338:EE_|VE1EUR03FT009:EE_|DBAPR08MB5861:EE_
X-Microsoft-Antispam-PRVS:
	<DBAPR08MB5861FE3DB961C451B73716329D3B9@DBAPR08MB5861.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 Jzp0s7q2D1EK3Ik28DdEygkjEjIBXM4BWkG8X9GOveXvYR0F6Q3nTfTWnBhlVb3jMDGPGrlCjpj+546WIixaMYzUaZE32XfQFLJ7Xah9Tm6MfwQuU6/lVzc22X1DZhTzgJkNha47ufwMGZZMk1hf3H4gPIB9fFlj+PZb4Ntana0SKdyvmO0h3bOnIGUwMmoxOOFJEewfZfECRjptjE28p93lCU55+3O4yiCIVv/JkmV4xQiMSHfCKnLjH1CgNPaJ669SloKYnuIafHKb0nCRAY0Ivj/Du5Ue6Bcvvd5LyqnbTC9VAw8TbgCVH6eu2QtBFSEg94a7w3rt9BS+SqjJfs/d/B4teJ8G9hYwEKKG532ECj3lyg/2L4AHZ1NilVXkGDBLQ6LREQ21z+6FbawoUKx/dxQtyJ91Ap0sBwFFF/ZfCQSSXCP3x09HvbFR3alYUiYnAfOIZ3Y8umI9PaHs/JcJYcAUInXveoA4FgLiwkGn/Fky9YYInNIV/I6FbT+eFoGB0Ahocl+Y3qZ8c2XWsuPiJYLICYrjKJZWf6wkqRrvKVx6dc5HRRqOnALhBQq0Kq8DVnzutfwNgdcE0pmcxtfsClDeHPKvYAghmOoG5wGiKH2K7UQ/FJeTfzMQf5dTF/P3IJSee6b1ch/2Nti4iIclUsjO/wx5gm75zYeMlbmg6E0HaSxBob782tsmSmrEbEWEvhwY7qrhZI1YGpD1GSLNHfDSsPRwu8WMWk2NqREhnkqUpXwOkwtqO31pLLvp
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38070700005)(186003)(5660300002)(2616005)(26005)(122000001)(6512007)(38100700002)(8936002)(86362001)(2906002)(316002)(76116006)(64756008)(66946007)(71200400001)(83380400001)(36756003)(66476007)(66446008)(91956017)(54906003)(6916009)(53546011)(6506007)(6486002)(33656002)(8676002)(508600001)(4326008)(66556008)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <A86A7EB0CAC66F45826C2A9DECE278B6@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7338
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT009.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	d3702f9d-ead1-4efa-a19b-08d9f616fad4
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	3G5aUHqYfrXq6/lGOjyGuftmBLstJZyj6VYtKk02CG37At980w7d16xRutOy7bU2AgtKYeC2fIPTVXFtj7BYdM2eTCFjNjVqAe1vrxUWLbPwwR9YmKFm4bz9VrZVl+zaythGjK0QBT0sdT+oVlKs99ig40uUcFGbyso40d77vU7swqNu0nHu55qz3C6SBD832LhZtwAtB0J3fL3rADy+B7DZAmHh48qFCkzF+AtajQ0JnjyrIvwBFUPQUcE+LKV8Qs48HJ/GIWEIAi+EMByoSkZ80XsR2qtEFxYoYG5uKZsiw8yiTjxh7WRtdcyEQzj6E/qrZkgfa3bZeo8ouaGy2I01Czi6UNi8qmvT+hLs1aeDQ+Xu6/RRz6H17sN48i5zBR1I6VbuXap8CyE8n49Hd6cU0JZp0tX1TTrU4B75LLvGDM5a2hi5B5ThrLA6yChhHtWjzldq8HWTiKfOdcRJ26x8rnty7+xPiXEKaQHfc5vupN0ipjnmC2ZTbJLrjobehpOiJz+OamHRsluaeMC3dIWnQmGFOQckWp8WdPPUk+npfLICQxsC/bW+lJjAA/k+Jlor5v10jJjW6rF+1KSAvirFS89jU4uvqs3KYc+uiewv4D5LE1eRrbl66WtKaMRIQTKqaBC9I3vZPLY+nI0OLZLH2y0kZiIDphf1q3QOlNDON3ejBpdsYK8BuygbruCY
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(336012)(33656002)(36860700001)(316002)(82310400004)(70206006)(70586007)(4326008)(6862004)(8676002)(6486002)(508600001)(2616005)(5660300002)(6506007)(53546011)(6512007)(186003)(83380400001)(26005)(356005)(81166007)(86362001)(107886003)(8936002)(36756003)(54906003)(2906002)(47076005)(40460700003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2022 15:21:38.5399
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 923733b2-0f71-4efb-7ffd-08d9f617057e
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT009.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5861

Hi Julien,

> On 21 Feb 2022, at 10:22, Julien Grall <julien@xen.org> wrote:
>=20
> From: Julien Grall <jgrall@amazon.com>
>=20
> Commit 05031fa87357 "xen/arm: guest_walk: Only generate necessary
> offsets/masks" introduced LPAE_ENTRIES_MASK_GS. In a follow-up patch,
> we will use it for to define LPAE_ENTRY_MASK.
>=20
> This will lead to inconsistent naming. As LPAE_ENTRY_MASK is used in
> many places, it is better to rename LPAE_ENTRIES_MASK_GS and avoid
> some churn.
>=20
> So rename LPAE_ENTRIES_MASK_GS to LPAE_ENTRY_MASK_GS.
>=20
> Signed-off-by: Julien Grall <jgrall@amazon.com>

With the 2 small fixes suggested by Michal, you can add my
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>

Cheers
Bertrand

>=20
> ---
>    Changes in v2:
>        - New patch
> ---
> xen/arch/arm/include/asm/lpae.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/xen/arch/arm/include/asm/lpae.h b/xen/arch/arm/include/asm/l=
pae.h
> index e94de2e7d8e8..4fb9a40a4ca9 100644
> --- a/xen/arch/arm/include/asm/lpae.h
> +++ b/xen/arch/arm/include/asm/lpae.h
> @@ -180,7 +180,7 @@ static inline bool lpae_is_superpage(lpae_t pte, unsi=
gned int level)
>  */
> #define LPAE_SHIFT_GS(gs)         ((gs) - 3)
> #define LPAE_ENTRIES_GS(gs)       (_AC(1, U) << LPAE_SHIFT_GS(gs))
> -#define LPAE_ENTRIES_MASK_GS(gs)  (LPAE_ENTRIES_GS(gs) - 1)
> +#define LPAE_ENTRY_MASK_GS(gs)  (LPAE_ENTRIES_GS(gs) - 1)
>=20
> #define LEVEL_ORDER_GS(gs, lvl)   ((3 - (lvl)) * LPAE_SHIFT_GS(gs))
> #define LEVEL_SHIFT_GS(gs, lvl)   (LEVEL_ORDER_GS(gs, lvl) + (gs))
> @@ -188,7 +188,7 @@ static inline bool lpae_is_superpage(lpae_t pte, unsi=
gned int level)
>=20
> /* Offset in the table at level 'lvl' */
> #define LPAE_TABLE_INDEX_GS(gs, lvl, addr)   \
> -    (((addr) >> LEVEL_SHIFT_GS(gs, lvl)) & LPAE_ENTRIES_MASK_GS(gs))
> +    (((addr) >> LEVEL_SHIFT_GS(gs, lvl)) & LPAE_ENTRY_MASK_GS(gs))
>=20
> /* Generate an array @var containing the offset for each level from @addr=
 */
> #define DECLARE_OFFSETS(var, addr)          \
> --=20
> 2.32.0
>=20



From xen-devel-bounces@lists.xenproject.org Tue Feb 22 15:22:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 15:22:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276842.473161 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMWzS-0005PI-W9; Tue, 22 Feb 2022 15:22:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276842.473161; Tue, 22 Feb 2022 15:22:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMWzS-0005OB-Se; Tue, 22 Feb 2022 15:22:10 +0000
Received: by outflank-mailman (input) for mailman id 276842;
 Tue, 22 Feb 2022 15:22:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=QzH2=TF=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nMWzR-0004xs-UB
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 15:22:10 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 33059cde-93f3-11ec-8539-5f4723681683;
 Tue, 22 Feb 2022 16:22:08 +0100 (CET)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2050.outbound.protection.outlook.com [104.47.12.50]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-20-EuGrLnZ8Px-WQTJXZQ1mgQ-1; Tue, 22 Feb 2022 16:22:07 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DB7PR04MB4170.eurprd04.prod.outlook.com (2603:10a6:5:19::29) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.26; Tue, 22 Feb
 2022 15:22:05 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.4995.027; Tue, 22 Feb 2022
 15:22:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 33059cde-93f3-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645543328;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=x7C1TYxIrM4iGA02CqMktBHSEKGII9ThfElLzKOxJ1s=;
	b=OBIs31DmGyQN5bPfBV+2AbPqkq6EIpwKoD+zdcHFR+LoqtvqCq4sHVzYp1k9B5r+DXVJ73
	dhWhj3pTijY1IJ91MGHItlpANkM7AWmbUPBZoujYMVddRiWFgZSfaiQl5kHs+n37ZGE4Yk
	B/crJ/R8o4EEFaw18j6lZZtKZ3MlNbk=
X-MC-Unique: EuGrLnZ8Px-WQTJXZQ1mgQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=HsNAORj5ejULJUUH+l2IRq/CSx2QjuvtulYYaRYO1LNI1ZAdBJkF/MbNjdKYLbiO+4XQUb21ivACGtmrg4ViYHAe/vmpSlbM7Tynw69WxwNOifja7ZvXi6Q/KhA8OQlqb7uGM6X2VJieqyazSSkmBVWzAJ8cVJUZTQVUXVBsFh0dT3Pbkm7k7v/3l1aXD2fA5XmIWHk0/gMwE8miiE680kczu8jnQrd1TiFtGrXJKD8MtEALh2Z6sqNjc9HqkE1j1lX5MfU0B0Hg2RNTmWZseuGEDd0DCoira+l/68htwRiKeawiceQbb/CisJHY46afEc/8V3E4VMIll0AJydUtDQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=x7C1TYxIrM4iGA02CqMktBHSEKGII9ThfElLzKOxJ1s=;
 b=TlpKhnzLrfaey7W2bVKxLR5tx35lc0exnxs+lkyUrqQPL+BRP1HchgSvgECdF3NVMmV0Pv9fr6mRfHfHJbnbwkftyf7N0rR73KrQzJT23SQ0JsVXT2X3NGwG+JgNDFOGdbbG9oKFfD+N5DlJ2EGgx3M6tVGLsKTpX+1skOyocRpTfUia7Tk7Qqo6xbDCZSDjsHg2tE4wx2Vy69gEmeE6N0gAjVzgcWpBQLC2WJSBA3gKcqHvMGyaLDwUNvE9i5reIpVZWuHbdxtjc+TJwrxXEltdscsM0otMKGpTYvluACK52/LOj+RvF5PviW+epwuCwpjP9RtSYxbwBxV0RNpPrA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <fea3b34c-d605-be27-f75e-722b39cc48e3@suse.com>
Date: Tue, 22 Feb 2022 16:22:03 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v3 14/19] xen/arm: add Persistent Map (PMAP)
 infrastructure
Content-Language: en-US
To: Julien Grall <julien@xen.org>
Cc: Wei Liu <wei.liu2@citrix.com>, Stefano Stabellini
 <sstabellini@kernel.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 George Dunlap <george.dunlap@citrix.com>, Hongyan Xia <hongyxia@amazon.com>,
 Julien Grall <jgrall@amazon.com>, Wei Liu <wl@xen.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 xen-devel@lists.xenproject.org
References: <20220221102218.33785-1-julien@xen.org>
 <20220221102218.33785-15-julien@xen.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220221102218.33785-15-julien@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR04CA0012.eurprd04.prod.outlook.com
 (2603:10a6:206:1::25) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 477b96bf-95ce-4ad3-38d8-08d9f6171558
X-MS-TrafficTypeDiagnostic: DB7PR04MB4170:EE_
X-Microsoft-Antispam-PRVS:
	<DB7PR04MB4170C9C1E8497CD58D71E112B33B9@DB7PR04MB4170.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	sIk1PX/YrWDaNB+/i79FXzD0g7VdhxFZG+plavQuz4eX7xFrrBUfTLVYmFvTlQBmX6+sWlI1jtranNWO8NmixKHkZYZJAFogc2S51vA5CjQsDdvz4vj3ghB1fJxquJ+4YmFusGgBlEU78Wg3hCpxVn5Ein3PAd+Ru+31Cd6DGg30nTWB1uOX7o+u9uLjgfV5vZqbSNnF5J6JrngKQZqQ9v9QliRpjpUfgPbMTXuT6eXRhhcy1Jd1EvH3lYwz6S0C0LEGEVkQdImUv9KT+nbY7pvHqok526Nf6w+Ywjyv3AucNE4An5ZjGkeTfIn2pt/F2OVjoYEYzSKeBMahCEIqQZsrBFH10PaVdxSCUqSaAyPPBU+aDx2NxrIcqPYFp4ZLBXXPbrnfrTxN3/jQ7MAuiC7hC+QHdcx0J+Ojb6wifLpUAvhwftHVvI3//Ge1RVgPwSujH+DLS1ylU9M0fVMfnd0AH3tesj55tTePYnc5YBmfhHPczMbKXWhU25c2/kB/q35w8TqJ7wIvgfv5095VTzY8waknsgavUh+atrQMjlAh3wb3Rug8oKPnEl+n5cVIWF1EhFjMAxNV0yHzuWrZBCNOh1Ul+5XjnsE78dRDEB0pSic5PbIjfZ+BJhWG7DFSoJpRSZ8pkHzcUlLSqGjQZYG+empjw2J561QEC3Xi+t4uYYv4zbPlrYtIk0d1x4x0a9Ipx98oPb0hGNWG530igT+cn+YbQz1mKXJ/VYYIC8zQmWhqDRoUE4myk0vs4a02
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(53546011)(6512007)(38100700002)(6916009)(508600001)(316002)(2906002)(36756003)(2616005)(186003)(26005)(6506007)(6486002)(31686004)(31696002)(66556008)(8676002)(66946007)(86362001)(83380400001)(7416002)(54906003)(5660300002)(8936002)(4326008)(66476007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NG0yYnRiQnZ6T2JWL1R5UXcwaVVya1pDaEkyZGovK3dMMGUwZjZublR5R0hB?=
 =?utf-8?B?cnJ4U1JHSlFYdDVyd3pnZVVVQytJQWY3cU54aWtrczhGOGIrZ1pSSGZqeW9O?=
 =?utf-8?B?QnFVQ2cwOWRzaHUveTV1bHdpRUlCbmFBMzBtZHNkRkhRcEpHckdxblRBVHFx?=
 =?utf-8?B?ZlNuQjR1WmcxQ2JZQlZ1bXNyOXJoekpxQjVyTFlUd0dKRHk0aHRlenhsNHor?=
 =?utf-8?B?c3VCczJpS29yMTBoL1F3YkswakRMdmV6bFBUSzB2aGlHb2hQYWVVQ0d1SUVX?=
 =?utf-8?B?YUkrQURDRUpVWkxpbGlvN1phSU1YaldhV2Z0QXVvT1FBc2ZCODlIVjhMSTR1?=
 =?utf-8?B?MjBnSHNpSXM4MFpQNWgrZzFnb2psTE9BemZYcUM2Z3BSZWNRbXV5NDdLM1BB?=
 =?utf-8?B?UXlkTk1abXU4Y1ZDdVAzQTdzZXNERGs2UGU5c3U2RngrRHdGZlBPaGNYLzVP?=
 =?utf-8?B?cUVDb0o3ZUlDZGhqRGdoTW84dkE3WDlsUjlpSDNsa2Q5ZmVLWmxXMnRZcTdj?=
 =?utf-8?B?UFg2WWlPZGUxRWEvNDlwTVdqUnovZmJ5NVpwYm1TWVlMd2s4VXdObHYrMENa?=
 =?utf-8?B?dlRmYW40ZHFTVHZUVjYvM1VoOHk0d2xFOXRIdjhPYXM1RnQ2R2pLQlVFWmhU?=
 =?utf-8?B?VVhIOEJ2T3hKV2w2dFlISmNBS05xSExKZUhYVWt6cmpYc2o4YzFuMXprcFV4?=
 =?utf-8?B?Mm5oSWMzTUY3L3NjYkxKRU1hVHRSRndISzR6Uy9JaUlTd09uaU93eERGRjkz?=
 =?utf-8?B?VW5rcWwrSVJKMlhGZGk1bHFNZFpRZi9MTDVxcFgva0tmZ205cTJtdUk1azhF?=
 =?utf-8?B?aHVxZ2llSGhuVUlseGt3dVhVT2dzZU9rMG5vQ3NIc0xrMXBEandDbmNiT1I1?=
 =?utf-8?B?SWtlYTFZQkNxdlNmWDhZaHFKMU0veG5JZTk3bmFHS2xGWCtWSEc5ZmZkYk15?=
 =?utf-8?B?YTRvU3VrUEhmaTdxR0Q2TkFMbC9GdzR3NDNQdGJpYlJUcm9iY1BPV0VXWE5K?=
 =?utf-8?B?R0gxN3JkOWprV2VvdVNCVEFSSVFaNkNsUys4V3FpRXZzSnN2RDVvV1hTa05r?=
 =?utf-8?B?aVZ4V1EwSUxjYzYvTzB3bHl3aE82REZRU3FvSDZWbFladTVFTE5ZR0F1ZkdC?=
 =?utf-8?B?elE2ZUxSazJJY3Y3ZGpWRDQ2Yy9rV3UvMzNtNFpPb3lvU1ZDOGlpTkswSVFh?=
 =?utf-8?B?dFJRTFFZQXNIamVLeGo4QWdqR3pwY3JsdjlqVUcyWWowcXh5eWtjZ09kZHhS?=
 =?utf-8?B?bUVCMllrUkYwYm5zRVF0dGtjcXBSRGV2WW9Pc1hYNzREWElVS1puWXlBdGZ6?=
 =?utf-8?B?KzBJU1NIbHVBQTZVYThYdEVRczE1UithUzNqU05lY0t0cTRmM0ZoQnFPTnl3?=
 =?utf-8?B?dXRBRk5ENi9pWGlhZjZVTWs0bWs3Vjc3K0hud2E0aExiUkFTZGhLQmxQZURz?=
 =?utf-8?B?VzNWRmtMUDk3Y3pseFllUTRiYURhaE4vWC9hR2t3TU96QUFBWjU1TElPZWZn?=
 =?utf-8?B?Y0p4NGR0ZkZJcGQ3OTgxTCtXK2pXd3poWUdEWEsxaWptT3QvRDZoODd4VFZC?=
 =?utf-8?B?MWJGVVFLaUxnMWVuclQ1ZzFGVUlmTXAyRU1zZ0FlU2lBd0FTV3gvRFNzUVZX?=
 =?utf-8?B?aHc4dFpkZE1TS0ZCNTRMdGp6NDNkbU1EV3NaN1VSbGdJUTJnTVV1VDZ0Qys1?=
 =?utf-8?B?Z3J0N2ZZZ1RzRW9vb2NKTzVRL2EraGYwbDJIQTZ6enlNNFNkdTZUdzlOdWpP?=
 =?utf-8?B?VVVUNHBXMFNPc2x2ZlBmRUtUSk1UMDkyb0ZHdTVMSzN0VW8rYlVITDlGM2cy?=
 =?utf-8?B?YmpYdExvRzVEazZHOUd1Y1JUU0tqUDRXMmpFd2lxMFJIeHdEbFljdDEwd0Rw?=
 =?utf-8?B?T1B2T25RcktTQzZPbmdBOU1xb0xSWEVXeGJIRXZBWHpTblN0SGg5eDllMzBl?=
 =?utf-8?B?dEFRR2IrQlRxeEFETUVyUnVEVjVKSWdhVDNlN0ZaOG5WTjdjMHhBNXJjWHky?=
 =?utf-8?B?bDRLbm5nMTBabkRBdXVYdk4wVVFLaC9ybERYbWlXdW9mSVU3dk5Od3hqNmpv?=
 =?utf-8?B?REFMbHZFTlkrRGp5WGZqNFpyUXpUUFpNUlNpeHVoUStsTjB1VGFWeVZJZU02?=
 =?utf-8?B?QS9OdDZjTXRtRzhVQk1ZaDI2dmhEQkpWRzFndXM3ZWpFMmp5Q2hKbHFmWjFD?=
 =?utf-8?Q?UQtBO3x6JUzAT8mzR044gdM=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 477b96bf-95ce-4ad3-38d8-08d9f6171558
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2022 15:22:05.3669
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zLpdyJAY/r3P5UB8JdaMilTNBkvCPB8akIvyWZBr/cqt8ylmf0Pw/zBGore8uLjAamk72W4O3/t7ry+0sf3xkg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4170

On 21.02.2022 11:22, Julien Grall wrote:
> --- a/xen/common/Makefile
> +++ b/xen/common/Makefile
> @@ -28,6 +28,7 @@ obj-y += multicall.o
>  obj-y += notifier.o
>  obj-y += page_alloc.o
>  obj-$(CONFIG_HAS_PDX) += pdx.o
> +obj-bin-$(CONFIG_HAS_PMAP) += pmap.init.o
>  obj-$(CONFIG_PERF_COUNTERS) += perfc.o
>  obj-y += preempt.o
>  obj-y += random.o

Nit: Please move the insertion one line further down.

> --- /dev/null
> +++ b/xen/common/pmap.c
> @@ -0,0 +1,79 @@
> +#include <xen/bitops.h>
> +#include <xen/init.h>
> +#include <xen/pmap.h>
> +
> +#include <asm/pmap.h>
> +#include <asm/fixmap.h>
> +
> +/*
> + * Simple mapping infrastructure to map / unmap pages in fixed map.
> + * This is used to set up the page table for mapcache, which is used
> + * by map domain page infrastructure.

Is this comment stale from its original x86 purpose?

> + * This structure is not protected by any locks, so it must not be used after
> + * smp bring-up.
> + */
> +
> +/* Bitmap to track which slot is used */
> +static unsigned long __initdata inuse;

I guess this wants to use DECLARE_BITMAP(), for ...

> +void *__init pmap_map(mfn_t mfn)
> +{
> +    unsigned long flags;
> +    unsigned int idx;
> +    unsigned int slot;
> +
> +    BUILD_BUG_ON(sizeof(inuse) * BITS_PER_BYTE < NUM_FIX_PMAP);
> +
> +    ASSERT(system_state < SYS_STATE_smp_boot);
> +
> +    local_irq_save(flags);
> +
> +    idx = find_first_zero_bit(&inuse, NUM_FIX_PMAP);

... this to be correct irrespective of how large NUM_FIX_PMAP is?
I think that's preferable over the BUILD_BUG_ON().

> +    if ( idx == NUM_FIX_PMAP )
> +        panic("Out of PMAP slots\n");
> +
> +    __set_bit(idx, &inuse);
> +
> +    slot = idx + FIXMAP_PMAP_BEGIN;
> +    ASSERT(slot >= FIXMAP_PMAP_BEGIN && slot <= FIXMAP_PMAP_END);
> +
> +    /*
> +     * We cannot use set_fixmap() here. We use PMAP when there is no direct map,
> +     * so map_pages_to_xen() called by set_fixmap() needs to map pages on
> +     * demand, which then calls pmap() again, resulting in a loop. Modify the
> +     * PTEs directly instead. The same is true for pmap_unmap().
> +     */
> +    arch_pmap_map(slot, mfn);

I'm less certain here, but like above I'm under the impression
that this comment may no longer be accurate.

> +    local_irq_restore(flags);

What is this IRQ save/restore intended to protect against, when
use of this function is limited to pre-SMP boot anyway?

Jan



From xen-devel-bounces@lists.xenproject.org Tue Feb 22 15:27:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 15:27:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276854.473183 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMX4T-0006T2-Uw; Tue, 22 Feb 2022 15:27:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276854.473183; Tue, 22 Feb 2022 15:27:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMX4T-0006St-RM; Tue, 22 Feb 2022 15:27:21 +0000
Received: by outflank-mailman (input) for mailman id 276854;
 Tue, 22 Feb 2022 15:27:20 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Woib=TF=citrix.com=prvs=045a4fa17=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nMX4R-0006Cs-Vk
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 15:27:20 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ea13a689-93f3-11ec-8539-5f4723681683;
 Tue, 22 Feb 2022 16:27:17 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ea13a689-93f3-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645543638;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=z51nQbh8p48webqvVUi7jB0qENb14nHisT5IueN7PE0=;
  b=g1k3X+DsaO6abeafnV8Eae1GLaSrS3fzViWLDxZhkH01RH7l4wGyEb04
   wzLK433f2hz71DgRCf+UB2rgb3fVn5y2ZK0H8HRd2Vi8illmltiQ5AS/i
   kV7ddZuwRQW3nXET93mNM8yB9is3P+s3LGxMlclKjSEk5ulguEa9x7uzG
   Q=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 65138256
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:iw+zoa4rhiI3rpnsPwwk8gxRtE/HchMFZxGqfqrLsTDasY5as4F+v
 jBNWmCCOfmPM2SheYtxYIjkpExVu8DUyNMxS1Fsqn1hHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFx2XqPp8Zj2tQy2YLjWVvX0
 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X
 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx
 umhurSTEigJGovcqN0UaB9+PDlzHodd1eDYdC3XXcy7lyUqclPpyvRqSko3IZcZ6qB8BmQmG
 f4wcW5XKErZ3qTvnez9GrIEascLdaEHOKs2vH16wC6fJvEhWZ3ZGI3B5MNC3Sd2jcdLdRrbT
 5REMGE/NkmeC/FJEgkMOrM0suqDvXj2dzlGtgKIjoss+UGGmWSd15CyaYGIK7RmX/59nEmCo
 Xnd13/kGRxcP9uaoRKV/3TpiuLRkCfTXIMJCKb+5vNsmEeUxGEYFFsRT1TTnBWiohfgAZQFc
 RVSo3dw6/hpnKC2cjXjdz7jj16gmA4sYtNrFcsV8Ayu4LH5vBnMUwDoUQV9QNAhscY3Qxkj2
 VmIg87lCFRTjVGFdZ6O3uzK9G3vYED5OUdHPHZZFlVdv7EPtalu1kqnczp1LEKiYjQZ8xnUy
 ivCkiUxjq57YSUjh/TipgCvb95BS/H0ou8JCuf/AzrNAuBRPtfNi2mUBb7zt60owGGxFATpg
 ZT8s5LChN3i9LnU/MB3fM0DHauy+9GOOyDGjFhkEvEJrmrxpiL9LN0Num0nfC+F1/ronxezO
 yc/XisLufdu0IaCN/crM+pd9exwpUQfKTgVfq+NNYcfCnSAXASG4DtvdSatM5PFyyARfVUEE
 c7DK66EVC9CYYw+lWbeb7pNgNcDm3FlrUuOFM+T8vhS+efHDJJjYexeawXmgyFQxP7snTg5B
 P4FaZPRkk0HCLeWj+u+2dd7EG3m5EMTXfjew/G7vMbZSua6MAnN08Ps/I4=
IronPort-HdrOrdr: A9a23:PR87bqiQBR3bAa2gSx7TzSvhb3BQXtgji2hC6mlwRA09TySZ//
 rBoB17726MtN9/YhEdcLy7VJVoBEmskKKdgrNhW4tKPjOW21dARbsKheCJrgEIWReOktK1vZ
 0QFJSWY+eQMbEVt6nHCXGDYrQd/OU=
X-IronPort-AV: E=Sophos;i="5.88,387,1635220800"; 
   d="scan'208";a="65138256"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Juergen Gross <jgross@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v3 03/70] x86/pv-shim: Don't modify the hypercall table
Date: Tue, 22 Feb 2022 15:26:32 +0000
Message-ID: <20220222152645.8844-3-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220222152645.8844-1-andrew.cooper3@citrix.com>
References: <20220222152645.8844-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

From: Juergen Gross <jgross@suse.com>

When running as pv-shim the hypercall is modified today in order to
replace the functions for __HYPERVISOR_event_channel_op and
__HYPERVISOR_grant_table_op hypercalls.

Change this to call the related functions from the normal handlers
instead when running as shim. The performance implications are not
really relevant, as a normal production hypervisor will not be
configured to support shim mode, so the related calls will be dropped
due to optimisation of the compiler.

Note that for the CONFIG_PV_SHIM_EXCLUSIVE case there is a dummy
wrapper do_grant_table_op() needed, as in this case grant_table.c
isn't being built.

Signed-off-by: Juergen Gross <jgross@suse.com>
[Split out of series.  Make compile in isolation]
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
v3:
 * Identify that it is modified as a side effect of pulling it out of the
   middle of Juergen's series.
---
 xen/arch/x86/include/asm/hypercall.h     |  4 ++-
 xen/arch/x86/include/asm/pv/shim.h       |  3 ++
 xen/arch/x86/pv/hypercall.c              |  2 +-
 xen/arch/x86/pv/shim.c                   | 54 ++++++++++++++++----------------
 xen/arch/x86/x86_64/platform_hypercall.c |  2 +-
 xen/common/compat/multicall.c            |  3 +-
 xen/common/event_channel.c               |  9 ++++++
 xen/common/grant_table.c                 |  9 ++++++
 8 files changed, 54 insertions(+), 32 deletions(-)

diff --git a/xen/arch/x86/include/asm/hypercall.h b/xen/arch/x86/include/asm/hypercall.h
index 5d394d492318..f004824f16b6 100644
--- a/xen/arch/x86/include/asm/hypercall.h
+++ b/xen/arch/x86/include/asm/hypercall.h
@@ -145,6 +145,7 @@ do_set_segment_base(
 
 #include <compat/arch-x86/xen.h>
 #include <compat/physdev.h>
+#include <compat/platform.h>
 
 extern int
 compat_physdev_op(
@@ -161,8 +162,9 @@ extern int compat_mmuext_op(
     XEN_GUEST_HANDLE_PARAM(uint) pdone,
     unsigned int foreigndom);
 
+DEFINE_XEN_GUEST_HANDLE(compat_platform_op_t);
 extern int compat_platform_op(
-    XEN_GUEST_HANDLE_PARAM(void) u_xenpf_op);
+    XEN_GUEST_HANDLE_PARAM(compat_platform_op_t) u_xenpf_op);
 
 extern long compat_callback_op(
     int cmd, XEN_GUEST_HANDLE(void) arg);
diff --git a/xen/arch/x86/include/asm/pv/shim.h b/xen/arch/x86/include/asm/pv/shim.h
index 8a91f4f9dfbf..6415f8068e5c 100644
--- a/xen/arch/x86/include/asm/pv/shim.h
+++ b/xen/arch/x86/include/asm/pv/shim.h
@@ -19,6 +19,7 @@
 #ifndef __X86_PV_SHIM_H__
 #define __X86_PV_SHIM_H__
 
+#include <xen/hypercall.h>
 #include <xen/types.h>
 
 #if defined(CONFIG_PV_SHIM_EXCLUSIVE)
@@ -45,6 +46,8 @@ domid_t get_initial_domain_id(void);
 uint64_t pv_shim_mem(uint64_t avail);
 void pv_shim_fixup_e820(struct e820map *e820);
 const struct platform_bad_page *pv_shim_reserved_pages(unsigned int *size);
+typeof(do_event_channel_op) pv_shim_event_channel_op;
+typeof(do_grant_table_op) pv_shim_grant_table_op;
 
 #else
 
diff --git a/xen/arch/x86/pv/hypercall.c b/xen/arch/x86/pv/hypercall.c
index ecdd58deea69..50cd219c18fc 100644
--- a/xen/arch/x86/pv/hypercall.c
+++ b/xen/arch/x86/pv/hypercall.c
@@ -64,7 +64,7 @@ const pv_hypercall_table_t pv_hypercall_table[] = {
     COMPAT_CALL(xen_version),
     HYPERCALL(console_io),
     COMPAT_CALL(physdev_op_compat),
-#ifdef CONFIG_GRANT_TABLE
+#if defined(CONFIG_GRANT_TABLE) || defined(CONFIG_PV_SHIM)
     COMPAT_CALL(grant_table_op),
 #endif
     HYPERCALL(vm_assist),
diff --git a/xen/arch/x86/pv/shim.c b/xen/arch/x86/pv/shim.c
index d9704121a739..7e891fe2f7a4 100644
--- a/xen/arch/x86/pv/shim.c
+++ b/xen/arch/x86/pv/shim.c
@@ -56,11 +56,6 @@ static DEFINE_SPINLOCK(balloon_lock);
 
 static struct platform_bad_page __initdata reserved_pages[2];
 
-static long pv_shim_event_channel_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg);
-static long pv_shim_grant_table_op(unsigned int cmd,
-                                   XEN_GUEST_HANDLE_PARAM(void) uop,
-                                   unsigned int count);
-
 /*
  * By default give the shim 1MB of free memory slack. Some users may wish to
  * tune this constants for better memory utilization. This can be achieved
@@ -203,7 +198,6 @@ void __init pv_shim_setup_dom(struct domain *d, l4_pgentry_t *l4start,
                               start_info_t *si)
 {
     bool compat = is_pv_32bit_domain(d);
-    pv_hypercall_table_t *rw_pv_hypercall_table;
     uint64_t param = 0;
     long rc;
 
@@ -249,23 +243,6 @@ void __init pv_shim_setup_dom(struct domain *d, l4_pgentry_t *l4start,
         consoled_set_ring_addr(page);
     }
 
-    /*
-     * Locate pv_hypercall_table[] (usually .rodata) in the directmap (which
-     * is writeable) and insert some shim-specific hypercall handlers.
-     */
-    rw_pv_hypercall_table = __va(__pa(pv_hypercall_table));
-    rw_pv_hypercall_table[__HYPERVISOR_event_channel_op].native =
-        (hypercall_fn_t *)pv_shim_event_channel_op;
-    rw_pv_hypercall_table[__HYPERVISOR_grant_table_op].native =
-        (hypercall_fn_t *)pv_shim_grant_table_op;
-
-#ifdef CONFIG_PV32
-    rw_pv_hypercall_table[__HYPERVISOR_event_channel_op].compat =
-        (hypercall_fn_t *)pv_shim_event_channel_op;
-    rw_pv_hypercall_table[__HYPERVISOR_grant_table_op].compat =
-        (hypercall_fn_t *)pv_shim_grant_table_op;
-#endif
-
     guest = d;
 
     /*
@@ -435,7 +412,7 @@ int pv_shim_shutdown(uint8_t reason)
     return 0;
 }
 
-static long pv_shim_event_channel_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
+long pv_shim_event_channel_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
 {
     struct domain *d = current->domain;
     struct evtchn_close close;
@@ -683,9 +660,9 @@ void pv_shim_inject_evtchn(unsigned int port)
 # define compat_handle_okay guest_handle_okay
 #endif
 
-static long pv_shim_grant_table_op(unsigned int cmd,
-                                   XEN_GUEST_HANDLE_PARAM(void) uop,
-                                   unsigned int count)
+long pv_shim_grant_table_op(unsigned int cmd,
+                            XEN_GUEST_HANDLE_PARAM(void) uop,
+                            unsigned int count)
 {
     struct domain *d = current->domain;
     long rc = 0;
@@ -845,6 +822,29 @@ static long pv_shim_grant_table_op(unsigned int cmd,
     return rc;
 }
 
+#ifndef CONFIG_GRANT_TABLE
+/* Thin wrapper(s) needed. */
+long do_grant_table_op(unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) uop,
+                       unsigned int count)
+{
+    if ( !pv_shim )
+        return -ENOSYS;
+
+    return pv_shim_grant_table_op(cmd, uop, count);
+}
+
+#ifdef CONFIG_PV32
+int compat_grant_table_op(unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) uop,
+                          unsigned int count)
+{
+    if ( !pv_shim )
+        return -ENOSYS;
+
+    return pv_shim_grant_table_op(cmd, uop, count);
+}
+#endif
+#endif
+
 long pv_shim_cpu_up(void *data)
 {
     struct vcpu *v = data;
diff --git a/xen/arch/x86/x86_64/platform_hypercall.c b/xen/arch/x86/x86_64/platform_hypercall.c
index fbba893a47cb..966fd27b5f22 100644
--- a/xen/arch/x86/x86_64/platform_hypercall.c
+++ b/xen/arch/x86/x86_64/platform_hypercall.c
@@ -6,8 +6,8 @@ EMIT_FILE;
 
 #include <xen/lib.h>
 #include <compat/platform.h>
+#include <xen/hypercall.h>
 
-DEFINE_XEN_GUEST_HANDLE(compat_platform_op_t);
 #define xen_platform_op     compat_platform_op
 #define xen_platform_op_t   compat_platform_op_t
 #define do_platform_op(x)   compat_platform_op(_##x)
diff --git a/xen/common/compat/multicall.c b/xen/common/compat/multicall.c
index a0e9918f4805..b17739d21829 100644
--- a/xen/common/compat/multicall.c
+++ b/xen/common/compat/multicall.c
@@ -5,7 +5,7 @@
 EMIT_FILE;
 
 #include <xen/types.h>
-#include <xen/multicall.h>
+#include <xen/hypercall.h>
 #include <xen/trace.h>
 
 #define COMPAT
@@ -19,7 +19,6 @@ static inline void xlat_multicall_entry(struct mc_state *mcs)
         mcs->compat_call.args[i] = mcs->call.args[i];
 }
 
-DEFINE_XEN_GUEST_HANDLE(multicall_entry_compat_t);
 #define multicall_entry      compat_multicall_entry
 #define multicall_entry_t    multicall_entry_compat_t
 #define do_multicall_call    compat_multicall_call
diff --git a/xen/common/event_channel.c b/xen/common/event_channel.c
index da88ad141a69..c9912122d1e5 100644
--- a/xen/common/event_channel.c
+++ b/xen/common/event_channel.c
@@ -31,6 +31,10 @@
 #include <public/event_channel.h>
 #include <xsm/xsm.h>
 
+#ifdef CONFIG_PV_SHIM
+#include <asm/guest.h>
+#endif
+
 #define ERROR_EXIT(_errno)                                          \
     do {                                                            \
         gdprintk(XENLOG_WARNING,                                    \
@@ -1189,6 +1193,11 @@ long do_event_channel_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
 {
     int rc;
 
+#ifdef CONFIG_PV_SHIM
+    if ( unlikely(pv_shim) )
+        return pv_shim_event_channel_op(cmd, arg);
+#endif
+
     switch ( cmd )
     {
     case EVTCHNOP_alloc_unbound: {
diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c
index 3d92fee59285..925ed7d6bee2 100644
--- a/xen/common/grant_table.c
+++ b/xen/common/grant_table.c
@@ -44,6 +44,10 @@
 #include <asm/flushtlb.h>
 #include <asm/guest_atomics.h>
 
+#ifdef CONFIG_PV_SHIM
+#include <asm/guest.h>
+#endif
+
 /* Per-domain grant information. */
 struct grant_table {
     /*
@@ -3561,6 +3565,11 @@ do_grant_table_op(
     long rc;
     unsigned int opaque_in = cmd & GNTTABOP_ARG_MASK, opaque_out = 0;
 
+#ifdef CONFIG_PV_SHIM
+    if ( unlikely(pv_shim) )
+        return pv_shim_grant_table_op(cmd, uop, count);
+#endif
+
     if ( (int)count < 0 )
         return -EINVAL;
 
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Tue Feb 22 15:27:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 15:27:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276856.473199 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMX4V-0006nW-No; Tue, 22 Feb 2022 15:27:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276856.473199; Tue, 22 Feb 2022 15:27:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMX4V-0006ml-Gu; Tue, 22 Feb 2022 15:27:23 +0000
Received: by outflank-mailman (input) for mailman id 276856;
 Tue, 22 Feb 2022 15:27:21 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Woib=TF=citrix.com=prvs=045a4fa17=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nMX4T-0006OK-LG
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 15:27:21 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ea50ebba-93f3-11ec-8eb8-a37418f5ba1a;
 Tue, 22 Feb 2022 16:27:18 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ea50ebba-93f3-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645543638;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=IDsziahYm5StEtLmipmAEeioRRBnvamhI9MkBfhV+eM=;
  b=GQxV541FBpaHBjI1J1eNLT5mo69+HK18P1aAXj/tqpruHXy/tpTAt4eE
   yuIWkJtEzKUCE47CzI9ldZI4RNs0qoUhnraJMIejOuf7+TYx384/m7HII
   Ekp563F1tjUjgD+duGcZH8xmVblEGKkU8oW2X4fRDDbmxXFUHtPF2yV8k
   c=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 66981777
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:lLhWxq5Q6TTlNTBcSNaFxgxRtFzHchMFZxGqfqrLsTDasY5as4F+v
 mAdXWDUMqyJZjb3c9Fzb9uxoU1X7cDTztQ1GQM5rXpgHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFx2XqPp8Zj2tQy2YLjWVvX0
 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X
 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx
 umhurSrUCF5M/P2ld4mCRB2DGZOF4JF+/zudC3XXcy7lyUqclPpyvRqSko3IZcZ6qB8BmQmG
 f4wcW5XKErZ3qTvnez9GrIEascLdaEHOKs2vH16wC6fJvEhWZ3ZGI3B5MNC3Sd2jcdLdRrbT
 5RHOGo2M0ufC/FJEl4nCsgksNuGuiL+VGVnhVePvfsy+2eGmWSd15CyaYGIK7RmX/59jkue4
 27L4Wn9KhUbL8CEjyqI9Gq2ge3Clj+9X5gdfIBU7dYz3gfVnDZKTkRLCx3r+pFVl3JSRfpEM
 mpE93QUoJIJrkWFUZ7NdTK7oz2t60t0t8VrL8U27wSEy6zx6gmfB3QZQjMpVOHKpPPaVhRxi
 AbXwoqB6ShH9eTMFCnDruv8QSaaZHBNRVLucxPoWufsDzPLhIgoxizCQd94eEJepo2kQGqgq
 9xmQcVXulnysSLp//jjlbwkq2j1znQscuLTzl+MNo5CxlkkDLNJn6TytTDmAQ9ode51tGWps
 nkegNS55+sTF5yLnyHlaLxTQOz1uafYbWeA2AYH83wdG9KFoSXLkWd4umwWGauUGpxcJW+Bj
 LH742u9G6O/zFP1NPQqMupd+uwhzLT6FMSNaxwnRoEmX3SFTyfepHsGTRfJhwjFyRFw+Ylia
 cbzWZv9Vh4yVPU4pAdass9AiNfHMAhlnjiNLX06pjz6uYejiIm9E+ldawLWNrhjhE5GyS2Mm
 +ti2wKx4003eIXDjuP/reb/8XhiwaAHOK3L
IronPort-HdrOrdr: A9a23:7qg4O6szDQ7rUJnHbE3Uy68D7skDjNV00zEX/kB9WHVpm6yj+v
 xGUs566faUskd0ZJhEo7q90ca7Lk80maQa3WBzB8bGYOCFghrKEGgK1+KLrwEIcxeUygc379
 YDT0ERMrzN5VgRt7eG3OG7eexQvOVuJsqT9JjjJ3QGd3AVV0l5hT0JbTpyiidNNXJ77ZxSLu
 v72uN34wCOVF4wdcqBCnwMT4H41qf2fMKPW29+O/Y/gjP+9Q+V1A==
X-IronPort-AV: E=Sophos;i="5.88,387,1635220800"; 
   d="scan'208";a="66981777"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v3 26/70] xen/iommu: CFI hardening
Date: Tue, 22 Feb 2022 15:26:37 +0000
Message-ID: <20220222152645.8844-8-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220222152645.8844-1-andrew.cooper3@citrix.com>
References: <20220222152645.8844-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

Control Flow Integrity schemes use toolchain and optionally hardware support
to help protect against call/jump/return oriented programming attacks.

Use cf_check to annotate function pointer targets for the toolchain.

AMD's parse_ppr_log_entry() has no external callers, so becomes static.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
v3:
 * Rebase over recent commits
---
 xen/common/compat/memory.c                  |  4 +-
 xen/drivers/passthrough/amd/iommu.h         | 41 ++++++++--------
 xen/drivers/passthrough/amd/iommu_init.c    | 22 ++++-----
 xen/drivers/passthrough/amd/iommu_intr.c    | 18 +++----
 xen/drivers/passthrough/amd/iommu_map.c     | 22 +++++----
 xen/drivers/passthrough/amd/pci_amd_iommu.c | 32 ++++++-------
 xen/drivers/passthrough/pci.c               |  7 +--
 xen/drivers/passthrough/vtd/dmar.c          |  3 +-
 xen/drivers/passthrough/vtd/extern.h        | 36 +++++++-------
 xen/drivers/passthrough/vtd/intremap.c      | 14 +++---
 xen/drivers/passthrough/vtd/iommu.c         | 73 +++++++++++++++--------------
 xen/drivers/passthrough/vtd/qinval.c        | 28 +++++------
 12 files changed, 152 insertions(+), 148 deletions(-)

diff --git a/xen/common/compat/memory.c b/xen/common/compat/memory.c
index ec8ba54bb66e..077ded4a754c 100644
--- a/xen/common/compat/memory.c
+++ b/xen/common/compat/memory.c
@@ -23,8 +23,8 @@ struct get_reserved_device_memory {
     unsigned int used_entries;
 };
 
-static int get_reserved_device_memory(xen_pfn_t start, xen_ulong_t nr,
-                                      u32 id, void *ctxt)
+static int cf_check get_reserved_device_memory(
+    xen_pfn_t start, xen_ulong_t nr, u32 id, void *ctxt)
 {
     struct get_reserved_device_memory *grdm = ctxt;
     uint32_t sbdf = PCI_SBDF3(grdm->map.dev.pci.seg, grdm->map.dev.pci.bus,
diff --git a/xen/drivers/passthrough/amd/iommu.h b/xen/drivers/passthrough/amd/iommu.h
index 99be9aafcc53..03811fedea57 100644
--- a/xen/drivers/passthrough/amd/iommu.h
+++ b/xen/drivers/passthrough/amd/iommu.h
@@ -236,25 +236,26 @@ int amd_iommu_init_late(void);
 int amd_iommu_update_ivrs_mapping_acpi(void);
 int cf_check iov_adjust_irq_affinities(void);
 
-int amd_iommu_quarantine_init(struct domain *d);
+int cf_check amd_iommu_quarantine_init(struct domain *d);
 
 /* mapping functions */
-int __must_check amd_iommu_map_page(struct domain *d, dfn_t dfn,
-                                    mfn_t mfn, unsigned int flags,
-                                    unsigned int *flush_flags);
-int __must_check amd_iommu_unmap_page(struct domain *d, dfn_t dfn,
-                                      unsigned int *flush_flags);
+int __must_check cf_check amd_iommu_map_page(
+    struct domain *d, dfn_t dfn, mfn_t mfn, unsigned int flags,
+    unsigned int *flush_flags);
+int __must_check cf_check amd_iommu_unmap_page(
+    struct domain *d, dfn_t dfn, unsigned int *flush_flags);
 int __must_check amd_iommu_alloc_root(struct domain *d);
 int amd_iommu_reserve_domain_unity_map(struct domain *domain,
                                        const struct ivrs_unity_map *map,
                                        unsigned int flag);
 int amd_iommu_reserve_domain_unity_unmap(struct domain *d,
                                          const struct ivrs_unity_map *map);
-int amd_iommu_get_reserved_device_memory(iommu_grdm_t *func, void *ctxt);
-int __must_check amd_iommu_flush_iotlb_pages(struct domain *d, dfn_t dfn,
-                                             unsigned long page_count,
-                                             unsigned int flush_flags);
-int __must_check amd_iommu_flush_iotlb_all(struct domain *d);
+int cf_check amd_iommu_get_reserved_device_memory(
+    iommu_grdm_t *func, void *ctxt);
+int __must_check cf_check amd_iommu_flush_iotlb_pages(
+    struct domain *d, dfn_t dfn, unsigned long page_count,
+    unsigned int flush_flags);
+int __must_check cf_check amd_iommu_flush_iotlb_all(struct domain *d);
 
 /* device table functions */
 int get_dma_requestor_id(uint16_t seg, uint16_t bdf);
@@ -282,21 +283,21 @@ void amd_iommu_flush_all_caches(struct amd_iommu *iommu);
 struct amd_iommu *find_iommu_for_device(int seg, int bdf);
 
 /* interrupt remapping */
-bool iov_supports_xt(void);
+bool cf_check iov_supports_xt(void);
 int amd_iommu_setup_ioapic_remapping(void);
 void *amd_iommu_alloc_intremap_table(
     const struct amd_iommu *, unsigned long **, unsigned int nr);
-int amd_iommu_free_intremap_table(
+int cf_check amd_iommu_free_intremap_table(
     const struct amd_iommu *, struct ivrs_mappings *, uint16_t);
 unsigned int amd_iommu_intremap_table_order(
     const void *irt, const struct amd_iommu *iommu);
-void amd_iommu_ioapic_update_ire(
+void cf_check amd_iommu_ioapic_update_ire(
     unsigned int apic, unsigned int reg, unsigned int value);
-unsigned int amd_iommu_read_ioapic_from_ire(
+unsigned int cf_check amd_iommu_read_ioapic_from_ire(
     unsigned int apic, unsigned int reg);
-int amd_iommu_msi_msg_update_ire(
+int cf_check amd_iommu_msi_msg_update_ire(
     struct msi_desc *msi_desc, struct msi_msg *msg);
-int amd_setup_hpet_msi(struct msi_desc *msi_desc);
+int cf_check amd_setup_hpet_msi(struct msi_desc *msi_desc);
 void cf_check amd_iommu_dump_intremap_tables(unsigned char key);
 
 extern struct ioapic_sbdf {
@@ -327,9 +328,9 @@ extern void *shared_intremap_table;
 extern unsigned long *shared_intremap_inuse;
 
 /* power management support */
-void amd_iommu_resume(void);
-int __must_check amd_iommu_suspend(void);
-void amd_iommu_crash_shutdown(void);
+void cf_check amd_iommu_resume(void);
+int __must_check cf_check amd_iommu_suspend(void);
+void cf_check amd_iommu_crash_shutdown(void);
 
 /* guest iommu support */
 #ifdef CONFIG_HVM
diff --git a/xen/drivers/passthrough/amd/iommu_init.c b/xen/drivers/passthrough/amd/iommu_init.c
index 34a9e49f1c5a..06b4d2b1fea0 100644
--- a/xen/drivers/passthrough/amd/iommu_init.c
+++ b/xen/drivers/passthrough/amd/iommu_init.c
@@ -258,8 +258,8 @@ static void register_iommu_exclusion_range(struct amd_iommu *iommu)
     writel(entry, iommu->mmio_base+IOMMU_EXCLUSION_BASE_LOW_OFFSET);
 }
 
-static void set_iommu_event_log_control(struct amd_iommu *iommu,
-                                        bool enable)
+static void cf_check set_iommu_event_log_control(
+    struct amd_iommu *iommu, bool enable)
 {
     /* Reset head and tail pointer manually before enablement */
     if ( enable )
@@ -275,8 +275,8 @@ static void set_iommu_event_log_control(struct amd_iommu *iommu,
     writeq(iommu->ctrl.raw, iommu->mmio_base + IOMMU_CONTROL_MMIO_OFFSET);
 }
 
-static void set_iommu_ppr_log_control(struct amd_iommu *iommu,
-                                      bool enable)
+static void cf_check set_iommu_ppr_log_control(
+    struct amd_iommu *iommu, bool enable)
 {
     /* Reset head and tail pointer manually before enablement */
     if ( enable )
@@ -527,7 +527,7 @@ static hw_irq_controller iommu_x2apic_type = {
     .set_affinity = set_x2apic_affinity,
 };
 
-static void parse_event_log_entry(struct amd_iommu *iommu, u32 entry[])
+static void cf_check parse_event_log_entry(struct amd_iommu *iommu, u32 entry[])
 {
     u32 code;
     static const char *const event_str[] = {
@@ -628,7 +628,7 @@ static void iommu_check_event_log(struct amd_iommu *iommu)
     spin_unlock_irqrestore(&iommu->lock, flags);
 }
 
-void parse_ppr_log_entry(struct amd_iommu *iommu, u32 entry[])
+static void cf_check parse_ppr_log_entry(struct amd_iommu *iommu, u32 entry[])
 {
 
     u16 device_id;
@@ -1243,7 +1243,7 @@ static int __init alloc_ivrs_mappings(u16 seg)
     return 0;
 }
 
-static int __init amd_iommu_setup_device_table(
+static int __init cf_check amd_iommu_setup_device_table(
     u16 seg, struct ivrs_mappings *ivrs_mappings)
 {
     struct amd_iommu_dte *dt = IVRS_MAPPINGS_DEVTAB(ivrs_mappings);
@@ -1543,7 +1543,7 @@ static void invalidate_all_domain_pages(void)
         amd_iommu_flush_all_pages(d);
 }
 
-static int _invalidate_all_devices(
+static int cf_check _invalidate_all_devices(
     u16 seg, struct ivrs_mappings *ivrs_mappings)
 {
     unsigned int bdf; 
@@ -1569,14 +1569,14 @@ static void invalidate_all_devices(void)
     iterate_ivrs_mappings(_invalidate_all_devices);
 }
 
-int amd_iommu_suspend(void)
+int cf_check amd_iommu_suspend(void)
 {
     amd_iommu_crash_shutdown();
 
     return 0;
 }
 
-void amd_iommu_crash_shutdown(void)
+void cf_check amd_iommu_crash_shutdown(void)
 {
     struct amd_iommu *iommu;
 
@@ -1584,7 +1584,7 @@ void amd_iommu_crash_shutdown(void)
         disable_iommu(iommu);
 }
 
-void amd_iommu_resume(void)
+void cf_check amd_iommu_resume(void)
 {
     struct amd_iommu *iommu;
 
diff --git a/xen/drivers/passthrough/amd/iommu_intr.c b/xen/drivers/passthrough/amd/iommu_intr.c
index e7804413c7f4..cebf9ceca74e 100644
--- a/xen/drivers/passthrough/amd/iommu_intr.c
+++ b/xen/drivers/passthrough/amd/iommu_intr.c
@@ -349,7 +349,7 @@ static int update_intremap_entry_from_ioapic(
     return 0;
 }
 
-void amd_iommu_ioapic_update_ire(
+void cf_check amd_iommu_ioapic_update_ire(
     unsigned int apic, unsigned int reg, unsigned int value)
 {
     struct IO_APIC_route_entry old_rte = { 0 };
@@ -455,7 +455,7 @@ void amd_iommu_ioapic_update_ire(
     }
 }
 
-unsigned int amd_iommu_read_ioapic_from_ire(
+unsigned int cf_check amd_iommu_read_ioapic_from_ire(
     unsigned int apic, unsigned int reg)
 {
     unsigned int idx;
@@ -608,7 +608,7 @@ static struct amd_iommu *_find_iommu_for_device(int seg, int bdf)
     return ERR_PTR(-EINVAL);
 }
 
-int amd_iommu_msi_msg_update_ire(
+int cf_check amd_iommu_msi_msg_update_ire(
     struct msi_desc *msi_desc, struct msi_msg *msg)
 {
     struct pci_dev *pdev = msi_desc->dev;
@@ -653,7 +653,7 @@ int amd_iommu_msi_msg_update_ire(
     return rc;
 }
 
-int amd_iommu_free_intremap_table(
+int cf_check amd_iommu_free_intremap_table(
     const struct amd_iommu *iommu, struct ivrs_mappings *ivrs_mapping,
     uint16_t bdf)
 {
@@ -727,7 +727,7 @@ void *amd_iommu_alloc_intremap_table(
     return tb;
 }
 
-bool __init iov_supports_xt(void)
+bool __init cf_check iov_supports_xt(void)
 {
     unsigned int apic;
 
@@ -756,7 +756,7 @@ bool __init iov_supports_xt(void)
     return true;
 }
 
-int __init amd_setup_hpet_msi(struct msi_desc *msi_desc)
+int __init cf_check amd_setup_hpet_msi(struct msi_desc *msi_desc)
 {
     const struct amd_iommu *iommu;
     spinlock_t *lock;
@@ -826,9 +826,9 @@ static void dump_intremap_table(const struct amd_iommu *iommu,
     }
 }
 
-static int dump_intremap_mapping(const struct amd_iommu *iommu,
-                                 struct ivrs_mappings *ivrs_mapping,
-                                 uint16_t unused)
+static int cf_check dump_intremap_mapping(
+    const struct amd_iommu *iommu, struct ivrs_mappings *ivrs_mapping,
+    uint16_t unused)
 {
     unsigned long flags;
 
diff --git a/xen/drivers/passthrough/amd/iommu_map.c b/xen/drivers/passthrough/amd/iommu_map.c
index b0330157eab5..bf5df5fe5d9a 100644
--- a/xen/drivers/passthrough/amd/iommu_map.c
+++ b/xen/drivers/passthrough/amd/iommu_map.c
@@ -276,8 +276,9 @@ static int iommu_pde_from_dfn(struct domain *d, unsigned long dfn,
     return 0;
 }
 
-int amd_iommu_map_page(struct domain *d, dfn_t dfn, mfn_t mfn,
-                       unsigned int flags, unsigned int *flush_flags)
+int cf_check amd_iommu_map_page(
+    struct domain *d, dfn_t dfn, mfn_t mfn, unsigned int flags,
+    unsigned int *flush_flags)
 {
     struct domain_iommu *hd = dom_iommu(d);
     int rc;
@@ -326,8 +327,8 @@ int amd_iommu_map_page(struct domain *d, dfn_t dfn, mfn_t mfn,
     return 0;
 }
 
-int amd_iommu_unmap_page(struct domain *d, dfn_t dfn,
-                         unsigned int *flush_flags)
+int cf_check amd_iommu_unmap_page(
+    struct domain *d, dfn_t dfn, unsigned int *flush_flags)
 {
     unsigned long pt_mfn = 0;
     struct domain_iommu *hd = dom_iommu(d);
@@ -370,9 +371,9 @@ static unsigned long flush_count(unsigned long dfn, unsigned long page_count,
     return end - start;
 }
 
-int amd_iommu_flush_iotlb_pages(struct domain *d, dfn_t dfn,
-                                unsigned long page_count,
-                                unsigned int flush_flags)
+int cf_check amd_iommu_flush_iotlb_pages(
+    struct domain *d, dfn_t dfn, unsigned long page_count,
+    unsigned int flush_flags)
 {
     unsigned long dfn_l = dfn_x(dfn);
 
@@ -410,7 +411,7 @@ int amd_iommu_flush_iotlb_pages(struct domain *d, dfn_t dfn,
     return 0;
 }
 
-int amd_iommu_flush_iotlb_all(struct domain *d)
+int cf_check amd_iommu_flush_iotlb_all(struct domain *d)
 {
     amd_iommu_flush_all_pages(d);
 
@@ -462,7 +463,8 @@ int amd_iommu_reserve_domain_unity_unmap(struct domain *d,
     return rc;
 }
 
-int amd_iommu_get_reserved_device_memory(iommu_grdm_t *func, void *ctxt)
+int cf_check amd_iommu_get_reserved_device_memory(
+    iommu_grdm_t *func, void *ctxt)
 {
     unsigned int seg = 0 /* XXX */, bdf;
     const struct ivrs_mappings *ivrs_mappings = get_ivrs_mappings(seg);
@@ -537,7 +539,7 @@ int amd_iommu_get_reserved_device_memory(iommu_grdm_t *func, void *ctxt)
     return 0;
 }
 
-int __init amd_iommu_quarantine_init(struct domain *d)
+int __init cf_check amd_iommu_quarantine_init(struct domain *d)
 {
     struct domain_iommu *hd = dom_iommu(d);
     unsigned long end_gfn =
diff --git a/xen/drivers/passthrough/amd/pci_amd_iommu.c b/xen/drivers/passthrough/amd/pci_amd_iommu.c
index 9642bba43a26..e57f555d00d1 100644
--- a/xen/drivers/passthrough/amd/pci_amd_iommu.c
+++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c
@@ -197,7 +197,7 @@ int __init acpi_ivrs_init(void)
     return 0;
 }
 
-static int __init iov_detect(void)
+static int __init cf_check iov_detect(void)
 {
     if ( !iommu_enable && !iommu_intremap )
         return 0;
@@ -217,7 +217,7 @@ static int __init iov_detect(void)
     return 0;
 }
 
-static int iov_enable_xt(void)
+static int cf_check iov_enable_xt(void)
 {
     int rc;
 
@@ -253,7 +253,7 @@ int amd_iommu_alloc_root(struct domain *d)
 unsigned int __read_mostly amd_iommu_max_paging_mode = 6;
 int __read_mostly amd_iommu_min_paging_mode = 1;
 
-static int amd_iommu_domain_init(struct domain *d)
+static int cf_check amd_iommu_domain_init(struct domain *d)
 {
     struct domain_iommu *hd = dom_iommu(d);
 
@@ -275,9 +275,9 @@ static int amd_iommu_domain_init(struct domain *d)
     return 0;
 }
 
-static int amd_iommu_add_device(u8 devfn, struct pci_dev *pdev);
+static int cf_check amd_iommu_add_device(u8 devfn, struct pci_dev *pdev);
 
-static void __hwdom_init amd_iommu_hwdom_init(struct domain *d)
+static void __hwdom_init cf_check amd_iommu_hwdom_init(struct domain *d)
 {
     const struct amd_iommu *iommu;
 
@@ -350,8 +350,9 @@ static void amd_iommu_disable_domain_device(const struct domain *domain,
         spin_unlock_irqrestore(&iommu->lock, flags);
 }
 
-static int reassign_device(struct domain *source, struct domain *target,
-                           u8 devfn, struct pci_dev *pdev)
+static int cf_check reassign_device(
+    struct domain *source, struct domain *target, u8 devfn,
+    struct pci_dev *pdev)
 {
     struct amd_iommu *iommu;
     int bdf, rc;
@@ -404,9 +405,8 @@ static int reassign_device(struct domain *source, struct domain *target,
     return 0;
 }
 
-static int amd_iommu_assign_device(struct domain *d, u8 devfn,
-                                   struct pci_dev *pdev,
-                                   u32 flag)
+static int cf_check amd_iommu_assign_device(
+    struct domain *d, u8 devfn, struct pci_dev *pdev, u32 flag)
 {
     struct ivrs_mappings *ivrs_mappings = get_ivrs_mappings(pdev->seg);
     int bdf = PCI_BDF2(pdev->bus, devfn);
@@ -435,7 +435,7 @@ static int amd_iommu_assign_device(struct domain *d, u8 devfn,
     return rc;
 }
 
-static void amd_iommu_clear_root_pgtable(struct domain *d)
+static void cf_check amd_iommu_clear_root_pgtable(struct domain *d)
 {
     struct domain_iommu *hd = dom_iommu(d);
 
@@ -444,13 +444,13 @@ static void amd_iommu_clear_root_pgtable(struct domain *d)
     spin_unlock(&hd->arch.mapping_lock);
 }
 
-static void amd_iommu_domain_destroy(struct domain *d)
+static void cf_check amd_iommu_domain_destroy(struct domain *d)
 {
     iommu_identity_map_teardown(d);
     ASSERT(!dom_iommu(d)->arch.amd.root_table);
 }
 
-static int amd_iommu_add_device(u8 devfn, struct pci_dev *pdev)
+static int cf_check amd_iommu_add_device(u8 devfn, struct pci_dev *pdev)
 {
     struct amd_iommu *iommu;
     u16 bdf;
@@ -525,7 +525,7 @@ static int amd_iommu_add_device(u8 devfn, struct pci_dev *pdev)
     return amd_iommu_setup_domain_device(pdev->domain, iommu, devfn, pdev);
 }
 
-static int amd_iommu_remove_device(u8 devfn, struct pci_dev *pdev)
+static int cf_check amd_iommu_remove_device(u8 devfn, struct pci_dev *pdev)
 {
     struct amd_iommu *iommu;
     u16 bdf;
@@ -562,7 +562,7 @@ static int amd_iommu_remove_device(u8 devfn, struct pci_dev *pdev)
     return 0;
 }
 
-static int amd_iommu_group_id(u16 seg, u8 bus, u8 devfn)
+static int cf_check amd_iommu_group_id(u16 seg, u8 bus, u8 devfn)
 {
     int bdf = PCI_BDF2(bus, devfn);
 
@@ -616,7 +616,7 @@ static void amd_dump_page_table_level(struct page_info *pg, int level,
     unmap_domain_page(table_vaddr);
 }
 
-static void amd_dump_page_tables(struct domain *d)
+static void cf_check amd_dump_page_tables(struct domain *d)
 {
     const struct domain_iommu *hd = dom_iommu(d);
 
diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
index 18af4e5088a0..22cb3872c22c 100644
--- a/xen/drivers/passthrough/pci.c
+++ b/xen/drivers/passthrough/pci.c
@@ -1098,7 +1098,7 @@ void pci_check_disable_device(u16 seg, u8 bus, u8 devfn)
  * scan pci devices to add all existed PCI devices to alldevs_list,
  * and setup pci hierarchy in array bus2bridge.
  */
-static int __init _scan_pci_devices(struct pci_seg *pseg, void *arg)
+static int __init cf_check _scan_pci_devices(struct pci_seg *pseg, void *arg)
 {
     struct pci_dev *pdev;
     int bus, dev, func;
@@ -1176,7 +1176,8 @@ static void __hwdom_init setup_one_hwdom_device(const struct setup_hwdom *ctxt,
                ctxt->d->domain_id, err);
 }
 
-static int __hwdom_init _setup_hwdom_pci_devices(struct pci_seg *pseg, void *arg)
+static int __hwdom_init cf_check _setup_hwdom_pci_devices(
+    struct pci_seg *pseg, void *arg)
 {
     struct setup_hwdom *ctxt = arg;
     int bus, devfn;
@@ -1333,7 +1334,7 @@ bool_t pcie_aer_get_firmware_first(const struct pci_dev *pdev)
 }
 #endif
 
-static int _dump_pci_devices(struct pci_seg *pseg, void *arg)
+static int cf_check _dump_pci_devices(struct pci_seg *pseg, void *arg)
 {
     struct pci_dev *pdev;
 
diff --git a/xen/drivers/passthrough/vtd/dmar.c b/xen/drivers/passthrough/vtd/dmar.c
index b8e91f5be1ae..63f8642e126a 100644
--- a/xen/drivers/passthrough/vtd/dmar.c
+++ b/xen/drivers/passthrough/vtd/dmar.c
@@ -1046,7 +1046,8 @@ bool_t __init platform_supports_x2apic(void)
     return cpu_has_x2apic && ((dmar_flags & mask) == ACPI_DMAR_INTR_REMAP);
 }
 
-int intel_iommu_get_reserved_device_memory(iommu_grdm_t *func, void *ctxt)
+int cf_check intel_iommu_get_reserved_device_memory(
+    iommu_grdm_t *func, void *ctxt)
 {
     struct acpi_rmrr_unit *rmrr, *rmrr_cur = NULL;
     unsigned int i;
diff --git a/xen/drivers/passthrough/vtd/extern.h b/xen/drivers/passthrough/vtd/extern.h
index ccf8df7be4f6..e6535548e1c1 100644
--- a/xen/drivers/passthrough/vtd/extern.h
+++ b/xen/drivers/passthrough/vtd/extern.h
@@ -33,9 +33,9 @@ void print_iommu_regs(struct acpi_drhd_unit *drhd);
 void print_vtd_entries(struct vtd_iommu *iommu, int bus, int devfn, u64 gmfn);
 keyhandler_fn_t cf_check vtd_dump_iommu_info;
 
-bool intel_iommu_supports_eim(void);
-int intel_iommu_enable_eim(void);
-void intel_iommu_disable_eim(void);
+bool cf_check intel_iommu_supports_eim(void);
+int cf_check intel_iommu_enable_eim(void);
+void cf_check intel_iommu_disable_eim(void);
 
 int enable_qinval(struct vtd_iommu *iommu);
 void disable_qinval(struct vtd_iommu *iommu);
@@ -51,15 +51,13 @@ int iommu_flush_iec_global(struct vtd_iommu *iommu);
 int iommu_flush_iec_index(struct vtd_iommu *iommu, u8 im, u16 iidx);
 void clear_fault_bits(struct vtd_iommu *iommu);
 
-int __must_check vtd_flush_context_reg(struct vtd_iommu *iommu, uint16_t did,
-                                       uint16_t source_id,
-                                       uint8_t function_mask, uint64_t type,
-                                       bool flush_non_present_entry);
-int __must_check vtd_flush_iotlb_reg(struct vtd_iommu *iommu, uint16_t did,
-                                     uint64_t addr, unsigned int size_order,
-                                     uint64_t type,
-                                     bool flush_non_present_entry,
-                                     bool flush_dev_iotlb);
+int __must_check cf_check vtd_flush_context_reg(
+    struct vtd_iommu *iommu, uint16_t did, uint16_t source_id,
+    uint8_t function_mask, uint64_t type, bool flush_non_present_entry);
+int __must_check cf_check vtd_flush_iotlb_reg(
+    struct vtd_iommu *iommu, uint16_t did, uint64_t addr,
+    unsigned int size_order, uint64_t type, bool flush_non_present_entry,
+    bool flush_dev_iotlb);
 
 struct vtd_iommu *ioapic_to_iommu(unsigned int apic_id);
 struct vtd_iommu *hpet_to_iommu(unsigned int hpet_id);
@@ -86,17 +84,19 @@ int domain_context_mapping_one(struct domain *domain, struct vtd_iommu *iommu,
                                u8 bus, u8 devfn, const struct pci_dev *);
 int domain_context_unmap_one(struct domain *domain, struct vtd_iommu *iommu,
                              u8 bus, u8 devfn);
-int intel_iommu_get_reserved_device_memory(iommu_grdm_t *func, void *ctxt);
+int cf_check intel_iommu_get_reserved_device_memory(
+    iommu_grdm_t *func, void *ctxt);
 
-unsigned int io_apic_read_remap_rte(unsigned int apic, unsigned int reg);
-void io_apic_write_remap_rte(unsigned int apic,
-                             unsigned int reg, unsigned int value);
+unsigned int cf_check io_apic_read_remap_rte(
+    unsigned int apic, unsigned int reg);
+void cf_check io_apic_write_remap_rte(
+    unsigned int apic, unsigned int reg, unsigned int value);
 
 struct msi_desc;
 struct msi_msg;
-int msi_msg_write_remap_rte(struct msi_desc *, struct msi_msg *);
+int cf_check msi_msg_write_remap_rte(struct msi_desc *, struct msi_msg *);
 
-int intel_setup_hpet_msi(struct msi_desc *);
+int cf_check intel_setup_hpet_msi(struct msi_desc *);
 
 int is_igd_vt_enabled_quirk(void);
 bool is_azalia_tlb_enabled(const struct acpi_drhd_unit *);
diff --git a/xen/drivers/passthrough/vtd/intremap.c b/xen/drivers/passthrough/vtd/intremap.c
index 01152f200664..e6ba89591b6f 100644
--- a/xen/drivers/passthrough/vtd/intremap.c
+++ b/xen/drivers/passthrough/vtd/intremap.c
@@ -142,7 +142,7 @@ static void set_hpet_source_id(unsigned int id, struct iremap_entry *ire)
     set_ire_sid(ire, SVT_VERIFY_SID_SQ, SQ_13_IGNORE_3, hpetid_to_bdf(id));
 }
 
-bool __init intel_iommu_supports_eim(void)
+bool __init cf_check intel_iommu_supports_eim(void)
 {
     struct acpi_drhd_unit *drhd;
     unsigned int apic;
@@ -414,7 +414,7 @@ static int ioapic_rte_to_remap_entry(struct vtd_iommu *iommu,
     return 0;
 }
 
-unsigned int io_apic_read_remap_rte(
+unsigned int cf_check io_apic_read_remap_rte(
     unsigned int apic, unsigned int reg)
 {
     unsigned int ioapic_pin = (reg - 0x10) / 2;
@@ -438,7 +438,7 @@ unsigned int io_apic_read_remap_rte(
         return (*(((u32 *)&old_rte) + 0));
 }
 
-void io_apic_write_remap_rte(
+void cf_check io_apic_write_remap_rte(
     unsigned int apic, unsigned int reg, unsigned int value)
 {
     unsigned int ioapic_pin = (reg - 0x10) / 2;
@@ -639,7 +639,7 @@ static int msi_msg_to_remap_entry(
     return 0;
 }
 
-int msi_msg_write_remap_rte(
+int cf_check msi_msg_write_remap_rte(
     struct msi_desc *msi_desc, struct msi_msg *msg)
 {
     struct pci_dev *pdev = msi_desc->dev;
@@ -651,7 +651,7 @@ int msi_msg_write_remap_rte(
                 : -EINVAL;
 }
 
-int __init intel_setup_hpet_msi(struct msi_desc *msi_desc)
+int __init cf_check intel_setup_hpet_msi(struct msi_desc *msi_desc)
 {
     struct vtd_iommu *iommu = hpet_to_iommu(msi_desc->hpet_id);
     unsigned long flags;
@@ -802,7 +802,7 @@ void disable_intremap(struct vtd_iommu *iommu)
  * This function is used to enable Interrupt remapping when
  * enable x2apic
  */
-int intel_iommu_enable_eim(void)
+int cf_check intel_iommu_enable_eim(void)
 {
     struct acpi_drhd_unit *drhd;
     struct vtd_iommu *iommu;
@@ -856,7 +856,7 @@ int intel_iommu_enable_eim(void)
  * This function is used to disable Interrupt remapping when
  * suspend local apic
  */
-void intel_iommu_disable_eim(void)
+void cf_check intel_iommu_disable_eim(void)
 {
     struct acpi_drhd_unit *drhd;
 
diff --git a/xen/drivers/passthrough/vtd/iommu.c b/xen/drivers/passthrough/vtd/iommu.c
index 42181e12be5a..1a1cf14785cb 100644
--- a/xen/drivers/passthrough/vtd/iommu.c
+++ b/xen/drivers/passthrough/vtd/iommu.c
@@ -59,7 +59,7 @@ static unsigned int __read_mostly nr_iommus;
 static struct iommu_ops vtd_ops;
 static struct tasklet vtd_fault_tasklet;
 
-static int setup_hwdom_device(u8 devfn, struct pci_dev *);
+static int cf_check setup_hwdom_device(u8 devfn, struct pci_dev *);
 static void setup_hwdom_rmrr(struct domain *d);
 
 static bool domid_mapping(const struct vtd_iommu *iommu)
@@ -426,9 +426,9 @@ static void iommu_flush_write_buffer(struct vtd_iommu *iommu)
 }
 
 /* return value determine if we need a write buffer flush */
-int vtd_flush_context_reg(struct vtd_iommu *iommu, uint16_t did,
-                          uint16_t source_id, uint8_t function_mask,
-                          uint64_t type, bool flush_non_present_entry)
+int cf_check vtd_flush_context_reg(
+    struct vtd_iommu *iommu, uint16_t did, uint16_t source_id,
+    uint8_t function_mask, uint64_t type, bool flush_non_present_entry)
 {
     unsigned long flags;
 
@@ -493,9 +493,10 @@ static int __must_check iommu_flush_context_device(struct vtd_iommu *iommu,
 }
 
 /* return value determine if we need a write buffer flush */
-int vtd_flush_iotlb_reg(struct vtd_iommu *iommu, uint16_t did, uint64_t addr,
-                        unsigned int size_order, uint64_t type,
-                        bool flush_non_present_entry, bool flush_dev_iotlb)
+int cf_check vtd_flush_iotlb_reg(
+    struct vtd_iommu *iommu, uint16_t did, uint64_t addr,
+    unsigned int size_order, uint64_t type, bool flush_non_present_entry,
+    bool flush_dev_iotlb)
 {
     int tlb_offset = ecap_iotlb_offset(iommu->ecap);
     uint64_t val = type | DMA_TLB_IVT;
@@ -704,10 +705,9 @@ static int __must_check iommu_flush_iotlb(struct domain *d, dfn_t dfn,
     return ret;
 }
 
-static int __must_check iommu_flush_iotlb_pages(struct domain *d,
-                                                dfn_t dfn,
-                                                unsigned long page_count,
-                                                unsigned int flush_flags)
+static int __must_check cf_check iommu_flush_iotlb_pages(
+    struct domain *d, dfn_t dfn, unsigned long page_count,
+    unsigned int flush_flags)
 {
     ASSERT(page_count && !dfn_eq(dfn, INVALID_DFN));
     ASSERT(flush_flags);
@@ -716,7 +716,7 @@ static int __must_check iommu_flush_iotlb_pages(struct domain *d,
                              page_count);
 }
 
-static int __must_check iommu_flush_iotlb_all(struct domain *d)
+static int __must_check cf_check iommu_flush_iotlb_all(struct domain *d)
 {
     return iommu_flush_iotlb(d, INVALID_DFN, 0, 0);
 }
@@ -1345,7 +1345,7 @@ void __init iommu_free(struct acpi_drhd_unit *drhd)
         agaw = 64;                              \
     agaw; })
 
-static int intel_iommu_domain_init(struct domain *d)
+static int cf_check intel_iommu_domain_init(struct domain *d)
 {
     struct domain_iommu *hd = dom_iommu(d);
 
@@ -1359,7 +1359,7 @@ static int intel_iommu_domain_init(struct domain *d)
     return 0;
 }
 
-static void __hwdom_init intel_iommu_hwdom_init(struct domain *d)
+static void __hwdom_init cf_check intel_iommu_hwdom_init(struct domain *d)
 {
     struct acpi_drhd_unit *drhd;
 
@@ -1808,7 +1808,7 @@ static int domain_context_unmap(struct domain *domain, u8 devfn,
     return ret;
 }
 
-static void iommu_clear_root_pgtable(struct domain *d)
+static void cf_check iommu_clear_root_pgtable(struct domain *d)
 {
     struct domain_iommu *hd = dom_iommu(d);
 
@@ -1817,7 +1817,7 @@ static void iommu_clear_root_pgtable(struct domain *d)
     spin_unlock(&hd->arch.mapping_lock);
 }
 
-static void iommu_domain_teardown(struct domain *d)
+static void cf_check iommu_domain_teardown(struct domain *d)
 {
     struct domain_iommu *hd = dom_iommu(d);
     const struct acpi_drhd_unit *drhd;
@@ -1835,9 +1835,9 @@ static void iommu_domain_teardown(struct domain *d)
     XFREE(hd->arch.vtd.iommu_bitmap);
 }
 
-static int __must_check intel_iommu_map_page(struct domain *d, dfn_t dfn,
-                                             mfn_t mfn, unsigned int flags,
-                                             unsigned int *flush_flags)
+static int __must_check cf_check intel_iommu_map_page(
+    struct domain *d, dfn_t dfn, mfn_t mfn, unsigned int flags,
+    unsigned int *flush_flags)
 {
     struct domain_iommu *hd = dom_iommu(d);
     struct dma_pte *page, *pte, old, new = {};
@@ -1906,8 +1906,8 @@ static int __must_check intel_iommu_map_page(struct domain *d, dfn_t dfn,
     return rc;
 }
 
-static int __must_check intel_iommu_unmap_page(struct domain *d, dfn_t dfn,
-                                               unsigned int *flush_flags)
+static int __must_check cf_check intel_iommu_unmap_page(
+    struct domain *d, dfn_t dfn, unsigned int *flush_flags)
 {
     /* Do nothing if VT-d shares EPT page table */
     if ( iommu_use_hap_pt(d) )
@@ -1922,8 +1922,8 @@ static int __must_check intel_iommu_unmap_page(struct domain *d, dfn_t dfn,
     return 0;
 }
 
-static int intel_iommu_lookup_page(struct domain *d, dfn_t dfn, mfn_t *mfn,
-                                   unsigned int *flags)
+static int cf_check intel_iommu_lookup_page(
+    struct domain *d, dfn_t dfn, mfn_t *mfn, unsigned int *flags)
 {
     struct domain_iommu *hd = dom_iommu(d);
     struct dma_pte *page, val;
@@ -1975,7 +1975,7 @@ static int __init vtd_ept_page_compatible(struct vtd_iommu *iommu)
            (ept_has_1gb(ept_cap) && opt_hap_1gb) <= cap_sps_1gb(vtd_cap);
 }
 
-static int intel_iommu_add_device(u8 devfn, struct pci_dev *pdev)
+static int cf_check intel_iommu_add_device(u8 devfn, struct pci_dev *pdev)
 {
     struct acpi_rmrr_unit *rmrr;
     u16 bdf;
@@ -2018,7 +2018,7 @@ static int intel_iommu_add_device(u8 devfn, struct pci_dev *pdev)
     return 0;
 }
 
-static int intel_iommu_enable_device(struct pci_dev *pdev)
+static int cf_check intel_iommu_enable_device(struct pci_dev *pdev)
 {
     struct acpi_drhd_unit *drhd = acpi_find_matched_drhd_unit(pdev);
     int ret = drhd ? ats_device(pdev, drhd) : -ENODEV;
@@ -2033,7 +2033,7 @@ static int intel_iommu_enable_device(struct pci_dev *pdev)
     return ret >= 0 ? 0 : ret;
 }
 
-static int intel_iommu_remove_device(u8 devfn, struct pci_dev *pdev)
+static int cf_check intel_iommu_remove_device(u8 devfn, struct pci_dev *pdev)
 {
     struct acpi_rmrr_unit *rmrr;
     u16 bdf;
@@ -2060,7 +2060,8 @@ static int intel_iommu_remove_device(u8 devfn, struct pci_dev *pdev)
     return domain_context_unmap(pdev->domain, devfn, pdev);
 }
 
-static int __hwdom_init setup_hwdom_device(u8 devfn, struct pci_dev *pdev)
+static int __hwdom_init cf_check setup_hwdom_device(
+    u8 devfn, struct pci_dev *pdev)
 {
     return domain_context_mapping(pdev->domain, devfn, pdev);
 }
@@ -2266,7 +2267,7 @@ static struct iommu_state {
     uint32_t fectl;
 } *__read_mostly iommu_state;
 
-static int __init vtd_setup(void)
+static int __init cf_check vtd_setup(void)
 {
     struct acpi_drhd_unit *drhd;
     struct vtd_iommu *iommu;
@@ -2401,7 +2402,7 @@ static int __init vtd_setup(void)
     return ret;
 }
 
-static int reassign_device_ownership(
+static int cf_check reassign_device_ownership(
     struct domain *source,
     struct domain *target,
     u8 devfn, struct pci_dev *pdev)
@@ -2479,7 +2480,7 @@ static int reassign_device_ownership(
     return ret;
 }
 
-static int intel_iommu_assign_device(
+static int cf_check intel_iommu_assign_device(
     struct domain *d, u8 devfn, struct pci_dev *pdev, u32 flag)
 {
     struct domain *s = pdev->domain;
@@ -2561,7 +2562,7 @@ static int intel_iommu_assign_device(
     return ret;
 }
 
-static int intel_iommu_group_id(u16 seg, u8 bus, u8 devfn)
+static int cf_check intel_iommu_group_id(u16 seg, u8 bus, u8 devfn)
 {
     u8 secbus;
 
@@ -2571,7 +2572,7 @@ static int intel_iommu_group_id(u16 seg, u8 bus, u8 devfn)
     return PCI_BDF2(bus, devfn);
 }
 
-static int __must_check vtd_suspend(void)
+static int __must_check cf_check vtd_suspend(void)
 {
     struct acpi_drhd_unit *drhd;
     struct vtd_iommu *iommu;
@@ -2614,7 +2615,7 @@ static int __must_check vtd_suspend(void)
     return 0;
 }
 
-static void vtd_crash_shutdown(void)
+static void cf_check vtd_crash_shutdown(void)
 {
     struct acpi_drhd_unit *drhd;
     struct vtd_iommu *iommu;
@@ -2635,7 +2636,7 @@ static void vtd_crash_shutdown(void)
     }
 }
 
-static void vtd_resume(void)
+static void cf_check vtd_resume(void)
 {
     struct acpi_drhd_unit *drhd;
     struct vtd_iommu *iommu;
@@ -2713,7 +2714,7 @@ static void vtd_dump_page_table_level(paddr_t pt_maddr, int level, paddr_t gpa,
     unmap_vtd_domain_page(pt_vaddr);
 }
 
-static void vtd_dump_page_tables(struct domain *d)
+static void cf_check vtd_dump_page_tables(struct domain *d)
 {
     const struct domain_iommu *hd = dom_iommu(d);
 
@@ -2723,7 +2724,7 @@ static void vtd_dump_page_tables(struct domain *d)
                               agaw_to_level(hd->arch.vtd.agaw), 0, 0);
 }
 
-static int __init intel_iommu_quarantine_init(struct domain *d)
+static int __init cf_check intel_iommu_quarantine_init(struct domain *d)
 {
     struct domain_iommu *hd = dom_iommu(d);
     struct page_info *pg;
diff --git a/xen/drivers/passthrough/vtd/qinval.c b/xen/drivers/passthrough/vtd/qinval.c
index 9f291f47e518..beeb65f0deec 100644
--- a/xen/drivers/passthrough/vtd/qinval.c
+++ b/xen/drivers/passthrough/vtd/qinval.c
@@ -322,9 +322,9 @@ int iommu_flush_iec_index(struct vtd_iommu *iommu, u8 im, u16 iidx)
     return queue_invalidate_iec_sync(iommu, IEC_INDEX_INVL, im, iidx);
 }
 
-static int __must_check flush_context_qi(struct vtd_iommu *iommu, u16 did,
-                                         u16 sid, u8 fm, u64 type,
-                                         bool flush_non_present_entry)
+static int __must_check cf_check flush_context_qi(
+    struct vtd_iommu *iommu, u16 did, u16 sid, u8 fm, u64 type,
+    bool flush_non_present_entry)
 {
     ASSERT(iommu->qinval_maddr);
 
@@ -346,11 +346,9 @@ static int __must_check flush_context_qi(struct vtd_iommu *iommu, u16 did,
                                          type >> DMA_CCMD_INVL_GRANU_OFFSET);
 }
 
-static int __must_check flush_iotlb_qi(struct vtd_iommu *iommu, u16 did,
-                                       u64 addr,
-                                       unsigned int size_order, u64 type,
-                                       bool flush_non_present_entry,
-                                       bool flush_dev_iotlb)
+static int __must_check cf_check flush_iotlb_qi(
+    struct vtd_iommu *iommu, u16 did, u64 addr, unsigned int size_order,
+    u64 type, bool flush_non_present_entry, bool flush_dev_iotlb)
 {
     u8 dr = 0, dw = 0;
     int ret = 0, rc;
@@ -461,18 +459,18 @@ int enable_qinval(struct vtd_iommu *iommu)
     return 0;
 }
 
-static int vtd_flush_context_noop(struct vtd_iommu *iommu, uint16_t did,
-                                  uint16_t source_id, uint8_t function_mask,
-                                  uint64_t type, bool flush_non_present_entry)
+static int cf_check vtd_flush_context_noop(
+    struct vtd_iommu *iommu, uint16_t did, uint16_t source_id,
+    uint8_t function_mask, uint64_t type, bool flush_non_present_entry)
 {
     WARN();
     return -EIO;
 }
 
-static int vtd_flush_iotlb_noop(struct vtd_iommu *iommu, uint16_t did,
-                                uint64_t addr, unsigned int size_order,
-                                uint64_t type, bool flush_non_present_entry,
-                                bool flush_dev_iotlb)
+static int cf_check vtd_flush_iotlb_noop(
+    struct vtd_iommu *iommu, uint16_t did, uint64_t addr,
+    unsigned int size_order, uint64_t type, bool flush_non_present_entry,
+    bool flush_dev_iotlb)
 {
     WARN();
     return -EIO;
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Tue Feb 22 15:27:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 15:27:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276853.473171 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMX4S-0006DA-Il; Tue, 22 Feb 2022 15:27:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276853.473171; Tue, 22 Feb 2022 15:27:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMX4S-0006D3-Fc; Tue, 22 Feb 2022 15:27:20 +0000
Received: by outflank-mailman (input) for mailman id 276853;
 Tue, 22 Feb 2022 15:27:19 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Woib=TF=citrix.com=prvs=045a4fa17=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nMX4R-0006Cs-7O
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 15:27:19 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ea382491-93f3-11ec-8539-5f4723681683;
 Tue, 22 Feb 2022 16:27:17 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ea382491-93f3-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645543637;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=bt4OX/67fRpjbPwMltvyGAYpZSijmRJZNzMcDVcps9k=;
  b=Gin1nKsn24MtUsdYUVAQe3JoEPsSmGWa6mx91S2IWMg2OdcqgKfdeN9p
   7AzY0utm9/xaKRWADwRcb6OJ5AYPKftCRx3Lf8wappBSVXCzFZT3BpR+W
   Xm9uGWdJ6SINh2vHaXqri9q7uz3ZCJgBQoti6bYo42pm4S7DxqTkWQvJ+
   0=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 64733393
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:3wLknax91XTxUE1eK+R6t+dTxirEfRIJ4+MujC+fZmUNrF6WrkUPz
 WIaWT+Haf7YZ2v3Ld91PN+0phgEu8fcx9ZrTVM+/CAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGHdJZS5LwbZj2NYy24LhWWthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 NpljKGNVywOL7P3wO0ZVl55DC9XMaZZ5+qSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DFYUToHx/ixreCu4rW8vrSKTW/95Imjw3g6iiGN6AO
 5VCMmE+N3wsZTVGC0VIDqkngt2N3GP4Lx8F9FOT/vAotj27IAtZj+G2bYu9lsaxbdVYmAOUq
 3zL+0z9AwoGL5qPxDyd6HWui+TT2yThV+ov+KaQr6AwxgfJnypKVUNQBQDTTeSFZlCWYu9iN
 Wcz6zQV9aE28QuKUdfUUxanvyvR1vIDYOZ4H+o/4QCL76Pb5QeFG2QJJgJ8hMwaWNweHmJzi
 ALQ9z/9LXk26eDOFyrBnluBhW7qYUAowXk+iTjopOfvy/3qu8kNgx3GVb6P+4bl34SuSVkcL
 91nxRXSZon/b+ZWj81XHnid2lpAQ6QlqCZvvW07uUr/s2tEiHaNPdDA1LQixa8owHylZleAp
 mMYvMOV8foDC5qA/ATUHrlQQO/4uqvfbGSE6bKKI3XH3272k5JEVdoNiAyS2W8zappUEdMXS
 BW7VfxtCG97YyLxMP4fj3OZAMU216nwfekJpdiPBueilqNZLVfdlAk3PBb49zm0zCAEzPFuU
 b/GIJ3EJStLVsxaIM+eGr51PUkDnXtlmws+hPnTknya7FZpTCTLEexcaAPWNIjULsqs+W3oz
 jqWDOPSoz03bQE0SnC/HVI7RbzSEUUGOA==
IronPort-HdrOrdr: A9a23:P1jCwK2tojv49pNqu0W3OgqjBIMkLtp133Aq2lEZdPUnSL3gqy
 nOpoV+6faaskdzZJhNo7y90ey7IE80lqQFhLX5X43SPjUO0VHAROpfBMnZrQEIcBefygcp79
 YHT0ERMrLN5cERt6zHCSqDYq4dKaG8gceVbTmy9RpQcT0=
X-IronPort-AV: E=Sophos;i="5.88,387,1635220800"; 
   d="scan'208";a="64733393"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v3 29/70] xen/misc: CFI hardening
Date: Tue, 22 Feb 2022 15:26:39 +0000
Message-ID: <20220222152645.8844-10-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220222152645.8844-1-andrew.cooper3@citrix.com>
References: <20220222152645.8844-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

Control Flow Integrity schemes use toolchain and optionally hardware support
to help protect against call/jump/return oriented programming attacks.

Use cf_check to annotate function pointer targets for the toolchain.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
v3
 * Annotations for gcov
---
 xen/arch/x86/mm.c                        | 6 ++++--
 xen/arch/x86/setup.c                     | 4 ++--
 xen/common/coverage/gcov.c               | 8 ++++----
 xen/common/domain.c                      | 2 +-
 xen/common/gdbstub.c                     | 5 ++---
 xen/common/livepatch.c                   | 7 +++----
 xen/common/memory.c                      | 4 ++--
 xen/common/page_alloc.c                  | 2 +-
 xen/common/radix-tree.c                  | 4 ++--
 xen/common/rangeset.c                    | 2 +-
 xen/common/spinlock.c                    | 6 +++---
 xen/common/vm_event.c                    | 6 +++---
 xen/common/xmalloc_tlsf.c                | 4 ++--
 xen/drivers/passthrough/amd/iommu_init.c | 2 +-
 xen/include/xen/domain.h                 | 2 +-
 15 files changed, 32 insertions(+), 32 deletions(-)

diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c
index a1b8737096c4..0665095d2309 100644
--- a/xen/arch/x86/mm.c
+++ b/xen/arch/x86/mm.c
@@ -835,7 +835,8 @@ struct mmio_emul_range_ctxt {
     unsigned long mfn;
 };
 
-static int print_mmio_emul_range(unsigned long s, unsigned long e, void *arg)
+static int cf_check print_mmio_emul_range(
+    unsigned long s, unsigned long e, void *arg)
 {
     const struct mmio_emul_range_ctxt *ctxt = arg;
 
@@ -4606,7 +4607,8 @@ static int _handle_iomem_range(unsigned long s, unsigned long e,
     return 0;
 }
 
-static int handle_iomem_range(unsigned long s, unsigned long e, void *p)
+static int cf_check handle_iomem_range(
+    unsigned long s, unsigned long e, void *p)
 {
     int err = 0;
 
diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c
index 3a4ec1fcfd04..a9a371336b36 100644
--- a/xen/arch/x86/setup.c
+++ b/xen/arch/x86/setup.c
@@ -2021,8 +2021,8 @@ int __hwdom_init xen_in_range(unsigned long mfn)
     return 0;
 }
 
-static int __hwdom_init io_bitmap_cb(unsigned long s, unsigned long e,
-                                     void *ctx)
+static int __hwdom_init cf_check io_bitmap_cb(
+    unsigned long s, unsigned long e, void *ctx)
 {
     struct domain *d = ctx;
     unsigned int i;
diff --git a/xen/common/coverage/gcov.c b/xen/common/coverage/gcov.c
index 3cc98728bfce..327bf8d646c0 100644
--- a/xen/common/coverage/gcov.c
+++ b/xen/common/coverage/gcov.c
@@ -120,7 +120,7 @@ static int gcov_info_dump_payload(const struct gcov_info *info,
 
 }
 
-static uint32_t gcov_get_size(void)
+static uint32_t cf_check gcov_get_size(void)
 {
     uint32_t total_size = sizeof(uint32_t); /* Magic number XCOV */
     struct gcov_info *info = NULL;
@@ -140,7 +140,7 @@ static uint32_t gcov_get_size(void)
     return total_size;
 }
 
-static void gcov_reset_all_counters(void)
+static void cf_check gcov_reset_all_counters(void)
 {
     struct gcov_info *info = NULL;
 
@@ -172,8 +172,8 @@ static int gcov_dump_one_record(const struct gcov_info *info,
     return gcov_info_dump_payload(info, buffer, off);
 }
 
-static int gcov_dump_all(XEN_GUEST_HANDLE_PARAM(char) buffer,
-                         uint32_t *buffer_size)
+static int cf_check gcov_dump_all(
+    XEN_GUEST_HANDLE_PARAM(char) buffer, uint32_t *buffer_size)
 {
     uint32_t off;
     uint32_t magic = XEN_GCOV_FORMAT_MAGIC;
diff --git a/xen/common/domain.c b/xen/common/domain.c
index f3d06df76c33..351029f8b239 100644
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -1803,7 +1803,7 @@ static void cf_check _free_pirq_struct(struct rcu_head *head)
     xfree(container_of(head, struct pirq, rcu_head));
 }
 
-void free_pirq_struct(void *ptr)
+void cf_check free_pirq_struct(void *ptr)
 {
     struct pirq *pirq = ptr;
 
diff --git a/xen/common/gdbstub.c b/xen/common/gdbstub.c
index 079c3ca9616a..d6872721dc0d 100644
--- a/xen/common/gdbstub.c
+++ b/xen/common/gdbstub.c
@@ -69,7 +69,7 @@ static void gdb_smp_resume(void);
 static char __initdata opt_gdb[30];
 string_param("gdb", opt_gdb);
 
-static void gdbstub_console_puts(const char *str, size_t nr);
+static void cf_check gdbstub_console_puts(const char *str, size_t nr);
 
 /* value <-> char (de)serialzers */
 static char
@@ -546,8 +546,7 @@ __gdb_ctx = {
 };
 static struct gdb_context *gdb_ctx = &__gdb_ctx;
 
-static void
-gdbstub_console_puts(const char *str, size_t nr)
+static void cf_check gdbstub_console_puts(const char *str, size_t nr)
 {
     const char *p;
 
diff --git a/xen/common/livepatch.c b/xen/common/livepatch.c
index e8714920dc8f..ec301a9f120c 100644
--- a/xen/common/livepatch.c
+++ b/xen/common/livepatch.c
@@ -157,10 +157,9 @@ unsigned long livepatch_symbols_lookup_by_name(const char *symname)
     return 0;
 }
 
-static const char *livepatch_symbols_lookup(unsigned long addr,
-                                            unsigned long *symbolsize,
-                                            unsigned long *offset,
-                                            char *namebuf)
+static const char *cf_check livepatch_symbols_lookup(
+    unsigned long addr, unsigned long *symbolsize, unsigned long *offset,
+    char *namebuf)
 {
     const struct payload *data;
     unsigned int i, best;
diff --git a/xen/common/memory.c b/xen/common/memory.c
index ede45c4af9db..69b0cd1e50de 100644
--- a/xen/common/memory.c
+++ b/xen/common/memory.c
@@ -1051,8 +1051,8 @@ struct get_reserved_device_memory {
     unsigned int used_entries;
 };
 
-static int get_reserved_device_memory(xen_pfn_t start, xen_ulong_t nr,
-                                      u32 id, void *ctxt)
+static int cf_check get_reserved_device_memory(
+    xen_pfn_t start, xen_ulong_t nr, u32 id, void *ctxt)
 {
     struct get_reserved_device_memory *grdm = ctxt;
     uint32_t sbdf = PCI_SBDF3(grdm->map.dev.pci.seg, grdm->map.dev.pci.bus,
diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c
index 3caf5c954b24..46357182375a 100644
--- a/xen/common/page_alloc.c
+++ b/xen/common/page_alloc.c
@@ -1238,7 +1238,7 @@ struct scrub_wait_state {
     bool drop;
 };
 
-static void scrub_continue(void *data)
+static void cf_check scrub_continue(void *data)
 {
     struct scrub_wait_state *st = data;
 
diff --git a/xen/common/radix-tree.c b/xen/common/radix-tree.c
index 33b47748ae49..adc3034222dc 100644
--- a/xen/common/radix-tree.c
+++ b/xen/common/radix-tree.c
@@ -52,7 +52,7 @@ struct rcu_node {
 	struct rcu_head rcu_head;
 };
 
-static struct radix_tree_node *rcu_node_alloc(void *arg)
+static struct radix_tree_node *cf_check rcu_node_alloc(void *arg)
 {
 	struct rcu_node *rcu_node = xmalloc(struct rcu_node);
 	return rcu_node ? &rcu_node->node : NULL;
@@ -65,7 +65,7 @@ static void cf_check _rcu_node_free(struct rcu_head *head)
 	xfree(rcu_node);
 }
 
-static void rcu_node_free(struct radix_tree_node *node, void *arg)
+static void cf_check rcu_node_free(struct radix_tree_node *node, void *arg)
 {
 	struct rcu_node *rcu_node = container_of(node, struct rcu_node, node);
 	call_rcu(&rcu_node->rcu_head, _rcu_node_free);
diff --git a/xen/common/rangeset.c b/xen/common/rangeset.c
index 885b6b15c229..a6ef2640462a 100644
--- a/xen/common/rangeset.c
+++ b/xen/common/rangeset.c
@@ -384,7 +384,7 @@ int rangeset_consume_ranges(struct rangeset *r,
     return rc;
 }
 
-static int merge(unsigned long s, unsigned long e, void *data)
+static int cf_check merge(unsigned long s, unsigned long e, void *data)
 {
     struct rangeset *r = data;
 
diff --git a/xen/common/spinlock.c b/xen/common/spinlock.c
index 25bfbf3c47f7..62c83aaa6a73 100644
--- a/xen/common/spinlock.c
+++ b/xen/common/spinlock.c
@@ -375,7 +375,7 @@ static void spinlock_profile_iterate(lock_profile_subfunc *sub, void *par)
     spin_unlock(&lock_profile_lock);
 }
 
-static void spinlock_profile_print_elem(struct lock_profile *data,
+static void cf_check spinlock_profile_print_elem(struct lock_profile *data,
     int32_t type, int32_t idx, void *par)
 {
     struct spinlock *lock = data->lock;
@@ -404,7 +404,7 @@ void cf_check spinlock_profile_printall(unsigned char key)
     spinlock_profile_iterate(spinlock_profile_print_elem, NULL);
 }
 
-static void spinlock_profile_reset_elem(struct lock_profile *data,
+static void cf_check spinlock_profile_reset_elem(struct lock_profile *data,
     int32_t type, int32_t idx, void *par)
 {
     data->lock_cnt = 0;
@@ -428,7 +428,7 @@ typedef struct {
     int                      rc;
 } spinlock_profile_ucopy_t;
 
-static void spinlock_profile_ucopy_elem(struct lock_profile *data,
+static void cf_check spinlock_profile_ucopy_elem(struct lock_profile *data,
     int32_t type, int32_t idx, void *par)
 {
     spinlock_profile_ucopy_t *p = par;
diff --git a/xen/common/vm_event.c b/xen/common/vm_event.c
index 70ab3ba406ff..84cf52636bc4 100644
--- a/xen/common/vm_event.c
+++ b/xen/common/vm_event.c
@@ -523,21 +523,21 @@ int __vm_event_claim_slot(struct domain *d, struct vm_event_domain *ved,
 
 #ifdef CONFIG_MEM_PAGING
 /* Registered with Xen-bound event channel for incoming notifications. */
-static void mem_paging_notification(struct vcpu *v, unsigned int port)
+static void cf_check mem_paging_notification(struct vcpu *v, unsigned int port)
 {
     vm_event_resume(v->domain, v->domain->vm_event_paging);
 }
 #endif
 
 /* Registered with Xen-bound event channel for incoming notifications. */
-static void monitor_notification(struct vcpu *v, unsigned int port)
+static void cf_check monitor_notification(struct vcpu *v, unsigned int port)
 {
     vm_event_resume(v->domain, v->domain->vm_event_monitor);
 }
 
 #ifdef CONFIG_MEM_SHARING
 /* Registered with Xen-bound event channel for incoming notifications. */
-static void mem_sharing_notification(struct vcpu *v, unsigned int port)
+static void cf_check mem_sharing_notification(struct vcpu *v, unsigned int port)
 {
     vm_event_resume(v->domain, v->domain->vm_event_share);
 }
diff --git a/xen/common/xmalloc_tlsf.c b/xen/common/xmalloc_tlsf.c
index e3f6886e6b62..d2ad909502d0 100644
--- a/xen/common/xmalloc_tlsf.c
+++ b/xen/common/xmalloc_tlsf.c
@@ -512,13 +512,13 @@ int xmem_pool_maxalloc(struct xmem_pool *pool)
 
 static struct xmem_pool *xenpool;
 
-static void *xmalloc_pool_get(unsigned long size)
+static void *cf_check xmalloc_pool_get(unsigned long size)
 {
     ASSERT(size == PAGE_SIZE);
     return alloc_xenheap_page();
 }
 
-static void xmalloc_pool_put(void *p)
+static void cf_check xmalloc_pool_put(void *p)
 {
     free_xenheap_page(p);
 }
diff --git a/xen/drivers/passthrough/amd/iommu_init.c b/xen/drivers/passthrough/amd/iommu_init.c
index 06b4d2b1fea0..cebcd68a6c04 100644
--- a/xen/drivers/passthrough/amd/iommu_init.c
+++ b/xen/drivers/passthrough/amd/iommu_init.c
@@ -1073,7 +1073,7 @@ static void * __init allocate_ppr_log(struct amd_iommu *iommu)
 #define IVRS_MAPPINGS_DEVTAB(m) (m)[ivrs_bdf_entries].intremap_table
 
 /* Gets passed to radix_tree_destroy(), so its param needs to be void *. */
-static void __init free_ivrs_mapping_callback(void *ptr)
+static void __init cf_check free_ivrs_mapping_callback(void *ptr)
 {
     const struct ivrs_mappings *ivrs_mappings = ptr;
 
diff --git a/xen/include/xen/domain.h b/xen/include/xen/domain.h
index 24eb4cc7d37e..1c3c88a14d6f 100644
--- a/xen/include/xen/domain.h
+++ b/xen/include/xen/domain.h
@@ -52,7 +52,7 @@ void free_vcpu_struct(struct vcpu *v);
 #ifndef alloc_pirq_struct
 struct pirq *alloc_pirq_struct(struct domain *);
 #endif
-void free_pirq_struct(void *);
+void cf_check free_pirq_struct(void *);
 
 /*
  * Initialise/destroy arch-specific details of a VCPU.
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Tue Feb 22 15:27:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 15:27:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276855.473194 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMX4V-0006jd-7m; Tue, 22 Feb 2022 15:27:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276855.473194; Tue, 22 Feb 2022 15:27:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMX4V-0006jE-4k; Tue, 22 Feb 2022 15:27:23 +0000
Received: by outflank-mailman (input) for mailman id 276855;
 Tue, 22 Feb 2022 15:27:21 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Woib=TF=citrix.com=prvs=045a4fa17=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nMX4T-0006Cs-00
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 15:27:21 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ebf94108-93f3-11ec-8539-5f4723681683;
 Tue, 22 Feb 2022 16:27:19 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ebf94108-93f3-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645543639;
  h=from:to:cc:subject:date:message-id:mime-version:
   content-transfer-encoding;
  bh=4K+rq1ET+69I5UkEpWtzBL2Q+U1T0lAFfJpGQ9h5iPw=;
  b=BLkwFL7+kJ/5lCby55LvUw6XyDoh7/t637ONuD0wjoYYxtpxUME3mMwu
   9Mf8qyTxPuf+l6yneCtm/S0qIhU09Hta0knk9flAEGKfws5FZ5uOs+6CX
   NHCsEFLgkail1EzK6zNuRja0KZyTjdHthhGa0yRGtLHlmXjm8mYg/EKr4
   I=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 65138254
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:URV+Pa3PZgj2FEbMz/bD5Qxxkn2cJEfYwER7XKvMYLTBsI5bp2NTm
 2QbUTrUPP2KMzT1eY0lbt+09BgAvpPVzd8xHQttpC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk0GE/NtTo5w7Rj2tQy24Dja++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /1PiZGxGQA1Y5TQhcI2WR9ZCyJGHIdZreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHCOo8Ft24m5jbeFfs8GrjIQrnQ5M8e1zA17ixLNaiDP
 pFJM2czBPjGSzJGAksIUZYnoPn23yjlIyJRiVmcg7VitgA/yyQuieOwYbI5YOeiZ+9Yg0KZr
 WLu5HniD1cRM9n34TiK6HW3ncfUgDj2HokVEdWQ8/dwhVSJy287CRsIVEC6q/20lk6/Xd1EL
 0UevCEpqMAa9lGvT9T7dw21pjiDpBF0c8pdFag25R+AzoLQ4h2FHS4UQzhZctskucQqAzsw2
 TehhMj1DDZitLmUT3O19bqOqz62fy8PIgcqeissXQYDpd75r+kOYgnnF4g5VvTv15usRG+2k
 2viQDUCa6s7j/IG1vW84Q3+ny+KjZLPTxY23iT9QTfwhu9mX7KNa4ut4FndyP9PKoeFU1WM1
 EQ5d9iiAPMmVs/UynHUKAkZNPTwvqvebmWA6bJ6N8R5r1yQF2ifkZe8Cd2UDGNgKY46dDDge
 yc/UisBtcYIbBNGgUKaCr9d6vjGL4C9TbwJtdiON7Kih6Sdkifdp0mCgmbKggjQfLAEy/1XB
 HtiWZ/E4YwmIapm1iGqYOwWzKUmwCszrUuKG8ymk0r2jOfEOCfNIVvgDLdoRrpihE9jiF+Im
 +uzyuPQk0kPOAEASnO/HXEvwaAiciFgWMGeRz1/fe+fOAt2cFzN+NeKqY7Nj7dNxvwP/s+Rp
 ynVchYBlDLX2C2WQS3XOysLQO6+Av5CQYcTYHVE0aCAgCN4P+5CLc43KvMKQFXQ3LY9laUtF
 6FdIa1twJ1nE1z6xtjUVrGlxKQKSfhhrVjm0/aNCNTnQ6Ndeg==
IronPort-HdrOrdr: A9a23:mG72gakbYRQXkSUCwT7JIxrn5lfpDfIg3DAbv31ZSRFFG/Fxl6
 iV8sjzsiWE7wr5OUtQ/exoV5PhfZqxz/JICOoqTNKftWvdyQiVxehZhOOIqVDd8kXFh4hgPM
 xbEpSWZueeMbEDt7eZ3DWF
X-IronPort-AV: E=Sophos;i="5.88,387,1635220800"; 
   d="scan'208";a="65138254"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, Stefano Stabellini <sstabellini@kernel.org>, Wei Liu
	<wl@xen.org>, Julien Grall <julien@xen.org>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>, Juergen Gross
	<jgross@suse.com>, =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?=
	<marmarek@invisiblethingslab.com>
Subject: [PATCH v3 00/70 (not all posted)] x86: Support for CET Indirect Branch Tracking
Date: Tue, 22 Feb 2022 15:26:30 +0000
Message-ID: <20220222152645.8844-1-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

To avoid spamming everyone, I have only re-sent patches with changes in v3.

CET Indirect Branch Tracking is a hardware feature designed to protect against
forward-edge control flow hijacking (Call/Jump oriented programming), and is a
companion feature to CET Shadow Stacks added in Xen 4.14.

Patches 1 thru 5 are prerequisites.  Patches 6 thru 59 are fairly mechanical
annotations of function pointer targets.  Patches 60 thru 70 are the final
enablement of CET-IBT.

This series functions correctly with GCC 9 and later, although an experimental
GCC patch is required to get more helpful typechecking at build time.  A
container with this fix has been added to CI.

Tested on a TigerLake NUC by me, and by Marek also.

CI pipelines:
  https://gitlab.com/xen-project/people/andyhhp/xen/-/pipelines/476819536
  https://cirrus-ci.com/build/4634902334275584

Andrew Cooper (67):
  xen/sort: Switch to an extern inline implementation
  xen/xsm: Move {do,compat}_flask_op() declarations into a header
  x86/kexec: Annotate embedded data with ELF metadata
  x86: Introduce support for CET-IBT
  xen: CFI hardening for x86 hypercalls
  xen: CFI hardening for custom_param()
  xen: CFI hardening for __initcall()
  xen: CFI hardening for notifier callbacks
  xen: CFI hardening for acpi_table_parse()
  xen: CFI hardening for continue_hypercall_on_cpu()
  xen: CFI hardening for init_timer()
  xen: CFI hardening for call_rcu()
  xen: CFI hardening for IPIs
  xen: CFI hardening for open_softirq()
  xsm/flask/ss: CFI hardening
  xsm: CFI hardening
  xen/sched: CFI hardening
  xen/evtchn: CFI hardening
  xen/hypfs: CFI hardening
  xen/tasklet: CFI hardening
  xen/keyhandler: CFI hardening
  xen/vpci: CFI hardening
  xen/decompress: CFI hardening
  xen/iommu: CFI hardening
  xen/video: CFI hardening
  xen/console: CFI hardening
  xen/misc: CFI hardening
  x86: CFI hardening for request_irq()
  x86/hvm: CFI hardening for hvm_funcs
  x86/hvm: CFI hardening for device emulation
  x86/emul: CFI hardening
  x86/ucode: CFI hardening
  x86/power: CFI hardening
  x86/apic: CFI hardening
  x86/nmi: CFI hardening
  x86/mtrr: CFI hardening
  x86/idle: CFI hardening
  x86/quirks: CFI hardening
  x86/hvmsave: CFI hardening
  x86/mce: CFI hardening
  x86/pmu: CFI hardening
  x86/cpu: CFI hardening
  x86/guest: CFI hardening
  x86/logdirty: CFI hardening
  x86/shadow: CFI hardening
  x86/hap: CFI hardening
  x86/p2m: CFI hardening
  x86/irq: CFI hardening
  x86/apei: CFI hardening
  x86/psr: CFI hardening
  x86/dpci: CFI hardening
  x86/pt: CFI hardening
  x86/time: CFI hardening
  x86/misc: CFI hardening
  x86/stack: CFI hardening
  x86/bugframe: CFI hardening
  x86: Use control flow typechecking where possible
  x86/setup: Read CR4 earlier in __start_xen()
  x86/alternatives: Clear CR4.CET when clearing CR0.WP
  x86/traps: Rework write_stub_trampoline() to not hardcode the jmp
  x86: Introduce helpers/checks for endbr64 instructions
  x86/emul: Update emulation stubs to be CET-IBT compatible
  x86/entry: Make syscall/sysenter entrypoints CET-IBT compatible
  x86/entry: Make IDT entrypoints CET-IBT compatible
  x86/setup: Rework MSR_S_CET handling for CET-IBT
  x86/efi: Disable CET-IBT around Runtime Services calls
  x86: Enable CET Indirect Branch Tracking

Juergen Gross (2):
  x86/pv-shim: Don't modify the hypercall table
  x86: Don't use the hypercall table for calling compat hypercalls

Marek Marczykowski-Górecki (1):
  x86: Build check for embedded endbr64 instructions

 Config.mk                                         |   1 -
 README                                            |   1 +
 automation/build/debian/buster-gcc-ibt.dockerfile |  66 ++++
 automation/gitlab-ci/build.yaml                   |   6 +
 automation/scripts/containerize                   |   1 +
 docs/misc/xen-command-line.pandoc                 |  16 +-
 tools/firmware/Makefile                           |   2 +
 tools/libs/guest/xg_dom_decompress_unsafe.h       |   2 +
 tools/tests/x86_emulator/x86-emulate.h            |   2 +
 xen/arch/arm/bootfdt.c                            |   9 +-
 xen/arch/arm/io.c                                 |   9 +-
 xen/arch/x86/Kconfig                              |  17 +
 xen/arch/x86/Makefile                             |   6 +
 xen/arch/x86/acpi/boot.c                          |  24 +-
 xen/arch/x86/acpi/cpu_idle.c                      |  43 ++-
 xen/arch/x86/acpi/cpufreq/cpufreq.c               |  24 +-
 xen/arch/x86/acpi/cpufreq/powernow.c              |  21 +-
 xen/arch/x86/acpi/cpuidle_menu.c                  |   6 +-
 xen/arch/x86/acpi/lib.c                           |   2 +-
 xen/arch/x86/acpi/power.c                         |   4 +-
 xen/arch/x86/acpi/wakeup_prot.S                   |  38 +-
 xen/arch/x86/alternative.c                        |  13 +-
 xen/arch/x86/apic.c                               |  12 +-
 xen/arch/x86/arch.mk                              |   7 +
 xen/arch/x86/boot/x86_64.S                        |  30 +-
 xen/arch/x86/compat.c                             |  21 +-
 xen/arch/x86/configs/pvshim_defconfig             |   1 +
 xen/arch/x86/cpu/amd.c                            |   8 +-
 xen/arch/x86/cpu/centaur.c                        |   2 +-
 xen/arch/x86/cpu/common.c                         |   3 +-
 xen/arch/x86/cpu/cpu.h                            |   2 +-
 xen/arch/x86/cpu/hygon.c                          |   2 +-
 xen/arch/x86/cpu/intel.c                          |   6 +-
 xen/arch/x86/cpu/mcheck/amd_nonfatal.c            |   4 +-
 xen/arch/x86/cpu/mcheck/mce.c                     |  22 +-
 xen/arch/x86/cpu/mcheck/mce.h                     |   2 +-
 xen/arch/x86/cpu/mcheck/mce_amd.c                 |   9 +-
 xen/arch/x86/cpu/mcheck/mce_amd.h                 |   4 +-
 xen/arch/x86/cpu/mcheck/mce_intel.c               |  49 ++-
 xen/arch/x86/cpu/mcheck/non-fatal.c               |   6 +-
 xen/arch/x86/cpu/mcheck/vmce.c                    |   4 +-
 xen/arch/x86/cpu/microcode/amd.c                  |   9 +-
 xen/arch/x86/cpu/microcode/core.c                 |  15 +-
 xen/arch/x86/cpu/microcode/intel.c                |  10 +-
 xen/arch/x86/cpu/mtrr/generic.c                   |  20 +-
 xen/arch/x86/cpu/mtrr/main.c                      |   4 +-
 xen/arch/x86/cpu/mtrr/mtrr.h                      |   8 +-
 xen/arch/x86/cpu/mwait-idle.c                     |  12 +-
 xen/arch/x86/cpu/shanghai.c                       |   2 +-
 xen/arch/x86/cpu/vpmu.c                           |  13 +-
 xen/arch/x86/cpu/vpmu_amd.c                       |  16 +-
 xen/arch/x86/cpu/vpmu_intel.c                     |  16 +-
 xen/arch/x86/cpuid.c                              |   8 +-
 xen/arch/x86/crash.c                              |   7 +-
 xen/arch/x86/dmi_scan.c                           |  10 +-
 xen/arch/x86/dom0_build.c                         |   8 +-
 xen/arch/x86/domain.c                             |  16 +-
 xen/arch/x86/emul-i8254.c                         |  14 +-
 xen/arch/x86/extable.c                            |  18 +-
 xen/arch/x86/genapic/bigsmp.c                     |   4 +-
 xen/arch/x86/genapic/delivery.c                   |  12 +-
 xen/arch/x86/genapic/probe.c                      |   2 +-
 xen/arch/x86/genapic/x2apic.c                     |  18 +-
 xen/arch/x86/guest/hyperv/hyperv.c                |  10 +-
 xen/arch/x86/guest/xen/xen.c                      |  15 +-
 xen/arch/x86/hpet.c                               |  29 +-
 xen/arch/x86/hvm/dm.c                             |   5 +-
 xen/arch/x86/hvm/dom0_build.c                     |  16 +-
 xen/arch/x86/hvm/emulate.c                        |  93 +++--
 xen/arch/x86/hvm/hpet.c                           |  12 +-
 xen/arch/x86/hvm/hvm.c                            |  47 +--
 xen/arch/x86/hvm/hypercall.c                      |   5 +-
 xen/arch/x86/hvm/intercept.c                      |  28 +-
 xen/arch/x86/hvm/io.c                             |  38 +-
 xen/arch/x86/hvm/ioreq.c                          |   2 +-
 xen/arch/x86/hvm/irq.c                            |  16 +-
 xen/arch/x86/hvm/mtrr.c                           |   8 +-
 xen/arch/x86/hvm/nestedhvm.c                      |   6 +-
 xen/arch/x86/hvm/pmtimer.c                        |  10 +-
 xen/arch/x86/hvm/quirks.c                         |   4 +-
 xen/arch/x86/hvm/rtc.c                            |  18 +-
 xen/arch/x86/hvm/stdvga.c                         |  19 +-
 xen/arch/x86/hvm/svm/nestedsvm.c                  |  22 +-
 xen/arch/x86/hvm/svm/svm.c                        | 404 +++++++++++-----------
 xen/arch/x86/hvm/svm/vmcb.c                       |   2 +-
 xen/arch/x86/hvm/vioapic.c                        |  12 +-
 xen/arch/x86/hvm/viridian/time.c                  |   2 +-
 xen/arch/x86/hvm/viridian/viridian.c              |  17 +-
 xen/arch/x86/hvm/vlapic.c                         |  25 +-
 xen/arch/x86/hvm/vmsi.c                           |  16 +-
 xen/arch/x86/hvm/vmx/intr.c                       |   2 +-
 xen/arch/x86/hvm/vmx/vmcs.c                       |  22 +-
 xen/arch/x86/hvm/vmx/vmx.c                        | 155 +++++----
 xen/arch/x86/hvm/vmx/vvmx.c                       |  16 +-
 xen/arch/x86/hvm/vpic.c                           |   8 +-
 xen/arch/x86/hvm/vpt.c                            |   2 +-
 xen/arch/x86/i8259.c                              |  10 +-
 xen/arch/x86/include/asm/asm-defns.h              |   6 +
 xen/arch/x86/include/asm/bug.h                    |  10 +-
 xen/arch/x86/include/asm/cpufeature.h             |   1 +
 xen/arch/x86/include/asm/cpufeatures.h            |   1 +
 xen/arch/x86/include/asm/cpuidle.h                |   4 +-
 xen/arch/x86/include/asm/current.h                |   6 +-
 xen/arch/x86/include/asm/endbr.h                  |  55 +++
 xen/arch/x86/include/asm/flushtlb.h               |   2 +-
 xen/arch/x86/include/asm/genapic.h                |  18 +-
 xen/arch/x86/include/asm/hpet.h                   |   8 +-
 xen/arch/x86/include/asm/hvm/emulate.h            |   8 +-
 xen/arch/x86/include/asm/hvm/save.h               |   2 +-
 xen/arch/x86/include/asm/hvm/svm/nestedsvm.h      |  18 +-
 xen/arch/x86/include/asm/hvm/svm/svm.h            |   1 -
 xen/arch/x86/include/asm/hvm/vioapic.h            |   2 +-
 xen/arch/x86/include/asm/hvm/vmx/vmcs.h           |   8 +-
 xen/arch/x86/include/asm/hvm/vmx/vmx.h            |   4 +-
 xen/arch/x86/include/asm/hvm/vmx/vvmx.h           |  18 +-
 xen/arch/x86/include/asm/hypercall.h              |  81 +++--
 xen/arch/x86/include/asm/irq.h                    |  24 +-
 xen/arch/x86/include/asm/machine_kexec.h          |   2 +-
 xen/arch/x86/include/asm/mm.h                     |  16 +-
 xen/arch/x86/include/asm/msi.h                    |   8 +-
 xen/arch/x86/include/asm/msr-index.h              |   1 +
 xen/arch/x86/include/asm/mtrr.h                   |   2 +-
 xen/arch/x86/include/asm/p2m.h                    |   4 +-
 xen/arch/x86/include/asm/paging.h                 |   2 +-
 xen/arch/x86/include/asm/processor.h              |   4 +-
 xen/arch/x86/include/asm/pv/domain.h              |   4 +-
 xen/arch/x86/include/asm/pv/shim.h                |  11 +-
 xen/arch/x86/include/asm/shadow.h                 |   2 +-
 xen/arch/x86/include/asm/smp.h                    |   6 +-
 xen/arch/x86/include/asm/tboot.h                  |   2 +-
 xen/arch/x86/include/asm/time.h                   |   6 +-
 xen/arch/x86/io_apic.c                            |  28 +-
 xen/arch/x86/ioport_emulate.c                     |   4 +-
 xen/arch/x86/irq.c                                |  28 +-
 xen/arch/x86/livepatch.c                          |   2 +-
 xen/arch/x86/machine_kexec.c                      |   2 +-
 xen/arch/x86/mm.c                                 |  35 +-
 xen/arch/x86/mm/hap/guest_walk.c                  |   4 +-
 xen/arch/x86/mm/hap/hap.c                         |  29 +-
 xen/arch/x86/mm/hap/nested_hap.c                  |   2 +-
 xen/arch/x86/mm/hap/private.h                     |  30 +-
 xen/arch/x86/mm/mem_sharing.c                     |   2 +-
 xen/arch/x86/mm/p2m-ept.c                         |  34 +-
 xen/arch/x86/mm/p2m-pt.c                          |  19 +-
 xen/arch/x86/mm/paging.c                          |   3 +-
 xen/arch/x86/mm/shadow/common.c                   |  33 +-
 xen/arch/x86/mm/shadow/hvm.c                      |  16 +-
 xen/arch/x86/mm/shadow/multi.c                    |  80 +++--
 xen/arch/x86/mm/shadow/multi.h                    |  20 +-
 xen/arch/x86/mm/shadow/none.c                     |  20 +-
 xen/arch/x86/mm/shadow/private.h                  |  12 +-
 xen/arch/x86/mm/shadow/pv.c                       |   4 +-
 xen/arch/x86/msi.c                                |  18 +-
 xen/arch/x86/nmi.c                                |  16 +-
 xen/arch/x86/numa.c                               |  10 +-
 xen/arch/x86/oprofile/nmi_int.c                   |  16 +-
 xen/arch/x86/oprofile/op_model_athlon.c           |  18 +-
 xen/arch/x86/oprofile/op_model_p4.c               |  14 +-
 xen/arch/x86/oprofile/op_model_ppro.c             |  26 +-
 xen/arch/x86/percpu.c                             |   6 +-
 xen/arch/x86/physdev.c                            |   2 +-
 xen/arch/x86/platform_hypercall.c                 |  11 +-
 xen/arch/x86/psr.c                                |  41 +--
 xen/arch/x86/pv/callback.c                        |  25 +-
 xen/arch/x86/pv/descriptor-tables.c               |  14 +-
 xen/arch/x86/pv/domain.c                          |  12 +-
 xen/arch/x86/pv/emul-gate-op.c                    |   9 +-
 xen/arch/x86/pv/emul-priv-op.c                    |  71 ++--
 xen/arch/x86/pv/emulate.h                         |   7 -
 xen/arch/x86/pv/hypercall.c                       |  11 +-
 xen/arch/x86/pv/iret.c                            |   4 +-
 xen/arch/x86/pv/misc-hypercalls.c                 |  10 +-
 xen/arch/x86/pv/ro-page-fault.c                   |  31 +-
 xen/arch/x86/pv/shim.c                            |  60 ++--
 xen/arch/x86/pv/traps.c                           |   2 +-
 xen/arch/x86/setup.c                              |  80 ++++-
 xen/arch/x86/shutdown.c                           |  10 +-
 xen/arch/x86/smp.c                                |  20 +-
 xen/arch/x86/smpboot.c                            |   2 +-
 xen/arch/x86/spec_ctrl.c                          |   6 +-
 xen/arch/x86/srat.c                               |   4 +-
 xen/arch/x86/sysctl.c                             |   4 +-
 xen/arch/x86/tboot.c                              |   2 +-
 xen/arch/x86/time.c                               |  68 ++--
 xen/arch/x86/traps.c                              |   8 +-
 xen/arch/x86/tsx.c                                |   2 +-
 xen/arch/x86/x86_64/acpi_mmcfg.c                  |   2 +-
 xen/arch/x86/x86_64/compat.c                      |   1 -
 xen/arch/x86/x86_64/compat/entry.S                |   1 +
 xen/arch/x86/x86_64/compat/mm.c                   |   7 +-
 xen/arch/x86/x86_64/entry.S                       |  49 ++-
 xen/arch/x86/x86_64/kexec_reloc.S                 |  23 +-
 xen/arch/x86/x86_64/mmconfig-shared.c             |  10 +-
 xen/arch/x86/x86_64/mmconfig.h                    |   2 +-
 xen/arch/x86/x86_64/platform_hypercall.c          |   2 +-
 xen/arch/x86/x86_64/traps.c                       |  42 ++-
 xen/arch/x86/x86_emulate.c                        |  34 +-
 xen/arch/x86/x86_emulate/x86_emulate.c            |  10 +-
 xen/arch/x86/x86_emulate/x86_emulate.h            |  33 +-
 xen/arch/x86/xen.lds.S                            |   3 +-
 xen/common/argo.c                                 |   6 +-
 xen/common/bunzip2.c                              |   2 +-
 xen/common/compat/domain.c                        |   3 +-
 xen/common/compat/grant_table.c                   |   5 +-
 xen/common/compat/kernel.c                        |   2 +-
 xen/common/compat/memory.c                        |   7 +-
 xen/common/compat/multicall.c                     |   3 +-
 xen/common/core_parking.c                         |  10 +-
 xen/common/coverage/gcov.c                        |   8 +-
 xen/common/cpu.c                                  |   4 +-
 xen/common/debugtrace.c                           |  10 +-
 xen/common/decompress.c                           |   2 +-
 xen/common/dm.c                                   |   6 +-
 xen/common/domain.c                               |  15 +-
 xen/common/domctl.c                               |   2 +-
 xen/common/efi/boot.c                             |   6 +-
 xen/common/efi/runtime.c                          |  18 +
 xen/common/event_2l.c                             |  21 +-
 xen/common/event_channel.c                        |  18 +-
 xen/common/event_fifo.c                           |  30 +-
 xen/common/gdbstub.c                              |   9 +-
 xen/common/grant_table.c                          |  29 +-
 xen/common/hypfs.c                                |  63 ++--
 xen/common/irq.c                                  |   6 +-
 xen/common/kernel.c                               |   6 +-
 xen/common/kexec.c                                |  18 +-
 xen/common/keyhandler.c                           |  47 +--
 xen/common/livepatch.c                            |  15 +-
 xen/common/memory.c                               |   8 +-
 xen/common/multicall.c                            |   2 +-
 xen/common/page_alloc.c                           |  14 +-
 xen/common/perfc.c                                |   4 +-
 xen/common/radix-tree.c                           |   8 +-
 xen/common/random.c                               |   2 +-
 xen/common/rangeset.c                             |   2 +-
 xen/common/rcupdate.c                             |   8 +-
 xen/common/sched/arinc653.c                       |  20 +-
 xen/common/sched/compat.c                         |   2 +-
 xen/common/sched/core.c                           |  40 +--
 xen/common/sched/cpupool.c                        |  35 +-
 xen/common/sched/credit.c                         |  59 ++--
 xen/common/sched/credit2.c                        |  55 ++-
 xen/common/sched/null.c                           |  60 ++--
 xen/common/sched/rt.c                             |  47 +--
 xen/common/spinlock.c                             |  12 +-
 xen/common/stop_machine.c                         |   6 +-
 xen/common/sysctl.c                               |   2 +-
 xen/common/tasklet.c                              |   4 +-
 xen/common/timer.c                                |   6 +-
 xen/common/trace.c                                |   4 +-
 xen/common/unlzma.c                               |   2 +-
 xen/common/vm_event.c                             |   6 +-
 xen/common/xenoprof.c                             |   2 +-
 xen/common/xmalloc_tlsf.c                         |   4 +-
 xen/common/zstd/zstd_common.c                     |   4 +-
 xen/common/zstd/zstd_internal.h                   |   4 +-
 xen/drivers/acpi/apei/apei-base.c                 |  32 +-
 xen/drivers/acpi/apei/apei-internal.h             |  20 +-
 xen/drivers/acpi/apei/erst.c                      |  57 ++-
 xen/drivers/acpi/apei/hest.c                      |   4 +-
 xen/drivers/acpi/numa.c                           |  10 +-
 xen/drivers/acpi/tables.c                         |   2 +-
 xen/drivers/char/console.c                        |  36 +-
 xen/drivers/char/ehci-dbgp.c                      |  28 +-
 xen/drivers/char/ns16550.c                        |  34 +-
 xen/drivers/cpufreq/cpufreq.c                     |   6 +-
 xen/drivers/cpufreq/cpufreq_misc_governors.c      |  22 +-
 xen/drivers/cpufreq/cpufreq_ondemand.c            |  10 +-
 xen/drivers/passthrough/amd/iommu.h               |  45 +--
 xen/drivers/passthrough/amd/iommu_acpi.c          |  15 +-
 xen/drivers/passthrough/amd/iommu_guest.c         |  12 +-
 xen/drivers/passthrough/amd/iommu_init.c          |  49 +--
 xen/drivers/passthrough/amd/iommu_intr.c          |  20 +-
 xen/drivers/passthrough/amd/iommu_map.c           |  22 +-
 xen/drivers/passthrough/amd/pci_amd_iommu.c       |  32 +-
 xen/drivers/passthrough/iommu.c                   |  56 ++-
 xen/drivers/passthrough/pci.c                     |  18 +-
 xen/drivers/passthrough/vtd/dmar.c                |   7 +-
 xen/drivers/passthrough/vtd/extern.h              |  38 +-
 xen/drivers/passthrough/vtd/intremap.c            |  14 +-
 xen/drivers/passthrough/vtd/iommu.c               |  94 ++---
 xen/drivers/passthrough/vtd/qinval.c              |  28 +-
 xen/drivers/passthrough/vtd/quirks.c              |   2 +-
 xen/drivers/passthrough/vtd/utils.c               |   2 +-
 xen/drivers/passthrough/vtd/x86/hvm.c             |   4 +-
 xen/drivers/passthrough/x86/hvm.c                 |  14 +-
 xen/drivers/video/lfb.c                           |   4 +-
 xen/drivers/video/lfb.h                           |   4 +-
 xen/drivers/video/vesa.c                          |   6 +-
 xen/drivers/video/vga.c                           |   6 +-
 xen/drivers/vpci/header.c                         |  18 +-
 xen/drivers/vpci/msi.c                            |  42 +--
 xen/drivers/vpci/msix.c                           |  20 +-
 xen/drivers/vpci/vpci.c                           |  16 +-
 xen/include/acpi/cpufreq/cpufreq.h                |   1 -
 xen/include/xen/acpi.h                            |   2 +-
 xen/include/xen/compiler.h                        |   6 +
 xen/include/xen/domain.h                          |   2 +-
 xen/include/xen/hypercall.h                       |  69 ++--
 xen/include/xen/hypfs.h                           |  49 ++-
 xen/include/xen/irq.h                             |   6 +-
 xen/include/xen/lib.h                             |   2 +-
 xen/include/xen/perfc.h                           |   4 +-
 xen/include/xen/sched.h                           |   2 +-
 xen/include/xen/sort.h                            |  55 ++-
 xen/include/xen/spinlock.h                        |   4 +-
 xen/include/xen/vpci.h                            |   8 +-
 xen/include/xsm/dummy.h                           | 211 +++++------
 xen/lib/sort.c                                    |  80 +----
 xen/tools/check-endbr.sh                          |  85 +++++
 xen/xsm/flask/avc.c                               |   2 +-
 xen/xsm/flask/flask_op.c                          |   8 +-
 xen/xsm/flask/hooks.c                             | 236 +++++++------
 xen/xsm/flask/private.h                           |   9 +
 xen/xsm/flask/ss/avtab.c                          |   4 +-
 xen/xsm/flask/ss/conditional.c                    |  10 +-
 xen/xsm/flask/ss/conditional.h                    |   6 +-
 xen/xsm/flask/ss/policydb.c                       |  53 +--
 xen/xsm/flask/ss/services.c                       |   6 +-
 xen/xsm/flask/ss/symtab.c                         |   5 +-
 xen/xsm/silo.c                                    |  24 +-
 xen/xsm/xsm_core.c                                |   6 +-
 322 files changed, 3316 insertions(+), 2739 deletions(-)
 create mode 100644 automation/build/debian/buster-gcc-ibt.dockerfile
 create mode 100644 xen/arch/x86/include/asm/endbr.h
 create mode 100755 xen/tools/check-endbr.sh
 create mode 100644 xen/xsm/flask/private.h

-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Tue Feb 22 15:27:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 15:27:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276857.473211 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMX4X-00074k-1A; Tue, 22 Feb 2022 15:27:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276857.473211; Tue, 22 Feb 2022 15:27:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMX4W-00072O-Fq; Tue, 22 Feb 2022 15:27:24 +0000
Received: by outflank-mailman (input) for mailman id 276857;
 Tue, 22 Feb 2022 15:27:23 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Woib=TF=citrix.com=prvs=045a4fa17=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nMX4U-0006OK-RK
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 15:27:22 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ed7f4077-93f3-11ec-8eb8-a37418f5ba1a;
 Tue, 22 Feb 2022 16:27:21 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ed7f4077-93f3-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645543641;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=l3vBrs4n2oJ7gLUw9ggixaQ0VXQruT/jeyOhQ2uTkmw=;
  b=fagQPc0U+nl2+kCUk+RSB1Ax8fP/YRoNE8iOdggNL+vI9PlESONBH04B
   uSmsgfkV/f+gQacAQfXH38qVjRfUHf9G7RBj6mpyGuAtRaEqhcAX+tdj3
   +fUcXATz3dZGnLHx3RMgeqrjLL1Hzly2hndiQ0aOpamdnRzPGT+yuc94+
   Q=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 66981789
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:1A3tjqqhn/zkLDuqHRQ4M39iTdVeBmIdZRIvgKrLsJaIsI4StFCzt
 garIBnUaK2NM2Cke9x+bo3g9kkO78SGy4c2GVQ9ri4zRXkRpZuZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlVEliefQAOCU5NfsYkidfyc9IMsaoU8ly75RbrJA24DjWVvX4
 4mq+aUzBXf+s9JKGjNMg068gEsHUMTa4Fv0aXRnOJinFHeH/5UkJMp3yZOZdhMUcaENdgKOf
 M7RzanRw4/s10xF5uVJMFrMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKv+Zvrgc91Zk
 b1wWZKMpQgBNbTQpLw5dCJhFyxZIrJv9bLEE2KciJnGp6HGWyOEL/RGCUg3OcsT+/ptAHEI/
 vsdQNwPRknd3aTsmuv9E7QywJR4RCXoFNp3VnVI5DfVF/s5B7vERL3H/4Rw1zYsnMFeW/3ZY
 qL1bBIxMkWQOkIfaz/7Drpll/fymFP+UgRfrQmFiJUy/FXNyzduhe2F3N39JYXRGJQ9clyjj
 n3C13T0BFcdLtP34Riv/2+oh+TPtTjmQ49UH7q9ntZ6jVvWymENBRk+UVqgveL/mkO4Q8hYK
 UEf5mwpt6dayaCwZoCjBVvi+ifC50NCHYoLewEn1O2T4qHN/zrBIk8/dzpMT8M5ncI7Rg4w9
 WbcyrsFGgdTmLGSTHuc8JKdojWzJTUZIAc+WMMUcecWy4K9+d9u13ojWv4mSffo1YOtRVkc1
 hjX9HBWulkFsSIcO0xXF3jjiinkmJXGRxVdCu7/DjP8tVMRiGJIiuWVBbnnARRocd7xorqp5
 iFsdy2iAAYmV8rleMulGrhlIV1Rz6zZWAAweHY2d3Xbyxyj+mS4Yadb6yxkKUFiP64sIGG1P
 RON6F4MvsMKZBNGiJObharrUKzGKoC6SLzYug38NIISMvCdiifdlM2RWaJg9z+0yxV9+U3OE
 ZyabdytHR4n5VdPl1KLqxMm+eZznEgWnDqLLbiilkjP+efONRa9FOZeWHPTP79R0U9xiFiMm
 zqpH5DRkEs3vSyXSnS/zLP/2nhQcyBgXMiu85Y/myzqClMOJVzNwsT5mdsJE7GJVYwP/gsU1
 hlRgnNl9Wc=
IronPort-HdrOrdr: A9a23:m0j6aKOQR0a/IcBcTvmjsMiBIKoaSvp037Eqv3oedfUzSL3gqy
 nOpoV86faaslYssR0b9exofZPwJE80lqQFhrX5X43SPzUO0VHAROoJgLcKgQeQfxEWntQtrZ
 uIGJIeNDSfNzdHZL7BkWuFL+o=
X-IronPort-AV: E=Sophos;i="5.88,387,1635220800"; 
   d="scan'208";a="66981789"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>
Subject: [PATCH v3 06/70] x86: Introduce support for CET-IBT
Date: Tue, 22 Feb 2022 15:26:34 +0000
Message-ID: <20220222152645.8844-5-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220222152645.8844-1-andrew.cooper3@citrix.com>
References: <20220222152645.8844-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

CET Indirect Branch Tracking is a hardware feature designed to provide
forward-edge control flow integrity, protecting against jump/call oriented
programming.

IBT requires the placement of ENDBR{32,64} instructions at the target of every
indirect call/jmp, and every entrypoint.

However, the default -fcf-protection=branch places an ENDBR on every function
which far more than necessary, and reduces the quantity of protection
afforded.  Therefore, we use manual placement using the cf_check attribute.

It is necessary to check for both compiler and assembler support, as the
notrack prefix can be emitted in certain cases.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>

Clang/LLVM support for -mmanual-endbr is in progress:
  https://reviews.llvm.org/D118355

v2:
 * Correct CONFIG_HAS_CC_CET_IBT to CONFIG_XEN_IBT in some places
 * Move cf_check compatibility into tools/tests/x86_emulator/x86-emulate.h
v3:
 * Extend commit message
 * Disable IBT for pvshim defconfig
---
 Config.mk                                   |  1 -
 tools/firmware/Makefile                     |  2 ++
 tools/libs/guest/xg_dom_decompress_unsafe.h |  2 ++
 tools/tests/x86_emulator/x86-emulate.h      |  2 ++
 xen/arch/x86/Kconfig                        | 17 +++++++++++++++++
 xen/arch/x86/arch.mk                        |  6 ++++++
 xen/arch/x86/configs/pvshim_defconfig       |  1 +
 xen/arch/x86/include/asm/asm-defns.h        |  6 ++++++
 xen/arch/x86/include/asm/cpufeature.h       |  1 +
 xen/arch/x86/include/asm/cpufeatures.h      |  1 +
 xen/include/xen/compiler.h                  |  6 ++++++
 11 files changed, 44 insertions(+), 1 deletion(-)

diff --git a/Config.mk b/Config.mk
index 95c053212ec3..f56f7dc33468 100644
--- a/Config.mk
+++ b/Config.mk
@@ -190,7 +190,6 @@ APPEND_CFLAGS += $(foreach i, $(APPEND_INCLUDES), -I$(i))
 
 EMBEDDED_EXTRA_CFLAGS := -nopie -fno-stack-protector -fno-stack-protector-all
 EMBEDDED_EXTRA_CFLAGS += -fno-exceptions -fno-asynchronous-unwind-tables
-EMBEDDED_EXTRA_CFLAGS += -fcf-protection=none
 
 XEN_EXTFILES_URL ?= http://xenbits.xen.org/xen-extfiles
 # All the files at that location were downloaded from elsewhere on
diff --git a/tools/firmware/Makefile b/tools/firmware/Makefile
index 345037b93b7f..53ed4f161edb 100644
--- a/tools/firmware/Makefile
+++ b/tools/firmware/Makefile
@@ -6,6 +6,8 @@ TARGET      := hvmloader/hvmloader
 INST_DIR := $(DESTDIR)$(XENFIRMWAREDIR)
 DEBG_DIR := $(DESTDIR)$(DEBUG_DIR)$(XENFIRMWAREDIR)
 
+EMBEDDED_EXTRA_CFLAGS += -fcf-protection=none
+
 SUBDIRS-y :=
 SUBDIRS-$(CONFIG_OVMF) += ovmf-dir
 SUBDIRS-$(CONFIG_SEABIOS) += seabios-dir
diff --git a/tools/libs/guest/xg_dom_decompress_unsafe.h b/tools/libs/guest/xg_dom_decompress_unsafe.h
index 4e0bf23aa587..ac6b94288d5e 100644
--- a/tools/libs/guest/xg_dom_decompress_unsafe.h
+++ b/tools/libs/guest/xg_dom_decompress_unsafe.h
@@ -8,6 +8,8 @@ typedef int decompress_fn(unsigned char *inbuf, unsigned int len,
                           void (*error)(const char *x));
 #endif
 
+#define cf_check /* No Control Flow Integriy checking */
+
 int xc_dom_decompress_unsafe(
     decompress_fn fn, struct xc_dom_image *dom, void **blob, size_t *size)
     __attribute__((visibility("internal")));
diff --git a/tools/tests/x86_emulator/x86-emulate.h b/tools/tests/x86_emulator/x86-emulate.h
index 7f60ef9e89ba..18ae40d01712 100644
--- a/tools/tests/x86_emulator/x86-emulate.h
+++ b/tools/tests/x86_emulator/x86-emulate.h
@@ -54,6 +54,8 @@
 #define likely(x)   __builtin_expect(!!(x), true)
 #define unlikely(x) __builtin_expect(!!(x), false)
 
+#define cf_check /* No Control Flow Integriy checking */
+
 #define container_of(ptr, type, member) ({             \
     typeof(((type *)0)->member) *mptr__ = (ptr);       \
     (type *)((char *)mptr__ - offsetof(type, member)); \
diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig
index 41198b0f96ed..8e70f9a44847 100644
--- a/xen/arch/x86/Kconfig
+++ b/xen/arch/x86/Kconfig
@@ -40,6 +40,11 @@ config HAS_AS_CET_SS
 	# binutils >= 2.29 or LLVM >= 6
 	def_bool $(as-instr,wrssq %rax$(comma)0;setssbsy)
 
+config HAS_CC_CET_IBT
+	# GCC >= 9 and binutils >= 2.29
+	# Retpoline check to work around https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93654
+	def_bool $(cc-option,-fcf-protection=branch -mmanual-endbr -mindirect-branch=thunk-extern) && $(as-instr,endbr64)
+
 menu "Architecture Features"
 
 source "arch/Kconfig"
@@ -125,6 +130,18 @@ config XEN_SHSTK
 	  When CET-SS is active, 32bit PV guests cannot be used.  Backwards
 	  compatiblity can be provided via the PV Shim mechanism.
 
+config XEN_IBT
+	bool "Supervisor Indirect Branch Tracking"
+	depends on HAS_CC_CET_IBT
+	default y
+	help
+	  Control-flow Enforcement Technology (CET) is a set of features in
+	  hardware designed to combat Return-oriented Programming (ROP, also
+	  call/jump COP/JOP) attacks.  Indirect Branch Tracking is one CET
+	  feature designed to provide function pointer protection.
+
+	  This option arranges for Xen to use CET-IBT for its own protection.
+
 config SHADOW_PAGING
 	bool "Shadow Paging"
 	default !PV_SHIM_EXCLUSIVE
diff --git a/xen/arch/x86/arch.mk b/xen/arch/x86/arch.mk
index edfc043dbbaf..f780c912a9cf 100644
--- a/xen/arch/x86/arch.mk
+++ b/xen/arch/x86/arch.mk
@@ -52,6 +52,12 @@ CFLAGS-$(CONFIG_CC_IS_GCC) += -fno-jump-tables
 CFLAGS-$(CONFIG_CC_IS_CLANG) += -mretpoline-external-thunk
 endif
 
+ifdef CONFIG_XEN_IBT
+CFLAGS += -fcf-protection=branch -mmanual-endbr
+else
+$(call cc-option-add,CFLAGS,CC,-fcf-protection=none)
+endif
+
 # If supported by the compiler, reduce stack alignment to 8 bytes. But allow
 # this to be overridden elsewhere.
 $(call cc-option-add,CFLAGS_stack_boundary,CC,-mpreferred-stack-boundary=3)
diff --git a/xen/arch/x86/configs/pvshim_defconfig b/xen/arch/x86/configs/pvshim_defconfig
index 787376df5a27..d0e92c2ded1f 100644
--- a/xen/arch/x86/configs/pvshim_defconfig
+++ b/xen/arch/x86/configs/pvshim_defconfig
@@ -8,6 +8,7 @@ CONFIG_NR_CPUS=32
 CONFIG_EXPERT=y
 # Disable features not used by the PV shim
 # CONFIG_XEN_SHSTK is not set
+# CONFIG_XEN_IBT is not set
 # CONFIG_GRANT_TABLE is not set
 # CONFIG_HYPFS is not set
 # CONFIG_BIGMEM is not set
diff --git a/xen/arch/x86/include/asm/asm-defns.h b/xen/arch/x86/include/asm/asm-defns.h
index 505f39ad5f76..8bd9007731d5 100644
--- a/xen/arch/x86/include/asm/asm-defns.h
+++ b/xen/arch/x86/include/asm/asm-defns.h
@@ -57,6 +57,12 @@
     INDIRECT_BRANCH jmp \arg
 .endm
 
+#ifdef CONFIG_XEN_IBT
+# define ENDBR64 endbr64
+#else
+# define ENDBR64
+#endif
+
 .macro guest_access_mask_ptr ptr:req, scratch1:req, scratch2:req
 #if defined(CONFIG_SPECULATIVE_HARDEN_GUEST_ACCESS)
     /*
diff --git a/xen/arch/x86/include/asm/cpufeature.h b/xen/arch/x86/include/asm/cpufeature.h
index a0ab6d7d78ea..f2c6f255ace9 100644
--- a/xen/arch/x86/include/asm/cpufeature.h
+++ b/xen/arch/x86/include/asm/cpufeature.h
@@ -152,6 +152,7 @@
 #define cpu_has_nscb            boot_cpu_has(X86_FEATURE_NSCB)
 #define cpu_has_xen_lbr         boot_cpu_has(X86_FEATURE_XEN_LBR)
 #define cpu_has_xen_shstk       boot_cpu_has(X86_FEATURE_XEN_SHSTK)
+#define cpu_has_xen_ibt         boot_cpu_has(X86_FEATURE_XEN_IBT)
 
 #define cpu_has_msr_tsc_aux     (cpu_has_rdtscp || cpu_has_rdpid)
 
diff --git a/xen/arch/x86/include/asm/cpufeatures.h b/xen/arch/x86/include/asm/cpufeatures.h
index b10154fc44bb..7413febd7ad8 100644
--- a/xen/arch/x86/include/asm/cpufeatures.h
+++ b/xen/arch/x86/include/asm/cpufeatures.h
@@ -39,6 +39,7 @@ XEN_CPUFEATURE(SC_VERW_PV,        X86_SYNTH(23)) /* VERW used by Xen for PV */
 XEN_CPUFEATURE(SC_VERW_HVM,       X86_SYNTH(24)) /* VERW used by Xen for HVM */
 XEN_CPUFEATURE(SC_VERW_IDLE,      X86_SYNTH(25)) /* VERW used by Xen for idle */
 XEN_CPUFEATURE(XEN_SHSTK,         X86_SYNTH(26)) /* Xen uses CET Shadow Stacks */
+XEN_CPUFEATURE(XEN_IBT,           X86_SYNTH(27)) /* Xen uses CET Indirect Branch Tracking */
 
 /* Bug words follow the synthetic words. */
 #define X86_NR_BUG 1
diff --git a/xen/include/xen/compiler.h b/xen/include/xen/compiler.h
index 696c7eb89e4c..933aec09a92d 100644
--- a/xen/include/xen/compiler.h
+++ b/xen/include/xen/compiler.h
@@ -37,6 +37,12 @@
 # define nocall
 #endif
 
+#ifdef CONFIG_XEN_IBT
+# define cf_check     __attribute__((__cf_check__))
+#else
+# define cf_check
+#endif
+
 #if (!defined(__clang__) && (__GNUC__ == 4) && (__GNUC_MINOR__ < 5))
 #define unreachable() do {} while (1)
 #else
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Tue Feb 22 15:27:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 15:27:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276858.473217 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMX4X-0007C3-Mr; Tue, 22 Feb 2022 15:27:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276858.473217; Tue, 22 Feb 2022 15:27:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMX4X-00079y-3i; Tue, 22 Feb 2022 15:27:25 +0000
Received: by outflank-mailman (input) for mailman id 276858;
 Tue, 22 Feb 2022 15:27:23 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Woib=TF=citrix.com=prvs=045a4fa17=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nMX4V-0006OK-Eb
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 15:27:23 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ed31e790-93f3-11ec-8eb8-a37418f5ba1a;
 Tue, 22 Feb 2022 16:27:22 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ed31e790-93f3-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645543642;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=7NU2F5oou3wTFQiiPS+nvCzwPrVqGrwa293dW8VmdiU=;
  b=BUr7H2GcEymCyhcxcz+3PODXhavp2cHwyCCN5W2o1cjYiuBWEFnKer+A
   2RbOG/lAKZKxhQqz7KjuCDf+ZgXHef+1bG5cwFFaLHETMka4Fo9KMcy5K
   i+Bz3BLIFSg7AGfbdd+Ejfh5kg9hFyzkF2K6wdPMdtF66rmUg47ppXEvB
   A=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 66981791
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:UpBYq6q74B7Zeqn7/MZsGuoFWeJeBmJ8ZRIvgKrLsJaIsI4StFCzt
 garIBmOPqmMajSmKtxyaoWx805X78XUm9c1TQRv/3ozFnsW+JuZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlVEliefQAOCU5NfsYkidfyc9IMsaoU8ly75RbrJA24DjWVvX4
 4mq+aUzBXf+s9JKGjNMg068gEsHUMTa4Fv0aXRnOJinFHeH/5UkJMp3yZOZdhMUcaENdgKOf
 M7RzanRw4/s10xF5uVJMFrMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKv+Zvrgc91Zk
 b1wWZKMpQgBAvfpsdoRdyZjGTwuEpBj+J6XE1+mrpnGp6HGWyOEL/RGCUg3OcsT+/ptAHEI/
 vsdQNwPRknd3aTsmuv9E7QywJR4RCXoFNp3VnVI5DfVF/s5B7vERL3H/4Rw1zYsnMFeW/3ZY
 qL1bBIxMkWQOkIeYz/7Dro0ucuq1nvhWQFCg3aev4UvwzPazVF+he2F3N39JYXRGJQ9clyjj
 nLL+SH1Dw8XMPSbyCGZ6TS8i+nXhyT5VYkOUrqi+ZZXbEa7nzJJTkdMDB3i/Kf/2hXWt89jx
 1I8xnALhJY+0HOQRMStcCCdoF/UjDkFRI8FewEl0z2lxq3R6gefI2ELSD9dddAr3PMLqSwWO
 kyhxI2wW2E22FGBYTfEr+rP82vuUcQABTJaPUc5oR05D84PSW3ZpjbGVZ5dHaG8lbUZ8hmgk
 mnR/EDSa1j+5PPnNplXH3ia21pARbCTF2bZAzk7uEr/tWuVg6b/OuSVBaDzt6ooEWpgZgDpU
 II4s8af9vsSKpqGiTaARu4AdJnwuarYbGON3AM1Q8B5n9hIx5JFVdoLiN2ZDB00WvvohBezO
 BOD0e+vzMU70ISWgV9fPNvqVpVCIVnIHtX5TPHEBueikbAqHDJrCBpGPBbKt0i0yRBEufhmZ
 f+zLJb9ZV5HWP8P5GfnGI8gPUoDm3lWKZX7HsugkXxKENO2ORaodFvyGAHQNrtgtPvc+m04M
 b93bqO39vmWa8WmCgG/zGLZBQtiwaQTbXwul/FqSw==
IronPort-HdrOrdr: A9a23:TF1Qn6kfkm7FaKieXPBbBf8n9knpDfIo3DAbv31ZSRFFG/Fxl6
 iV/cjztCWE8Ar5N0tQ+uxoVJPufZqYz+8Q3WBzB8baYOCFghrLEGgK1+KLqFeMdxEWtNQtsp
 uIG5IObuEYZmIbsS+V2meF+q4bsby6zJw=
X-IronPort-AV: E=Sophos;i="5.88,387,1635220800"; 
   d="scan'208";a="66981791"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v3 12/70] xen: CFI hardening for continue_hypercall_on_cpu()
Date: Tue, 22 Feb 2022 15:26:36 +0000
Message-ID: <20220222152645.8844-7-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220222152645.8844-1-andrew.cooper3@citrix.com>
References: <20220222152645.8844-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

Control Flow Integrity schemes use toolchain and optionally hardware support
to help protect against call/jump/return oriented programming attacks.

Use cf_check to annotate function pointer targets for the toolchain.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
v3:
 * Fix !CONFIG_PV_SHIM build.  Annotate pv_shim_cpu_{up,down}() stubs.
---
 xen/arch/x86/acpi/power.c          | 2 +-
 xen/arch/x86/cpu/microcode/core.c  | 2 +-
 xen/arch/x86/include/asm/pv/shim.h | 8 ++++----
 xen/arch/x86/include/asm/smp.h     | 6 +++---
 xen/arch/x86/platform_hypercall.c  | 4 ++--
 xen/arch/x86/pv/shim.c             | 4 ++--
 xen/arch/x86/smp.c                 | 4 ++--
 xen/arch/x86/sysctl.c              | 2 +-
 xen/common/core_parking.c          | 2 +-
 xen/common/kexec.c                 | 2 +-
 xen/common/sched/cpupool.c         | 2 +-
 11 files changed, 19 insertions(+), 19 deletions(-)

diff --git a/xen/arch/x86/acpi/power.c b/xen/arch/x86/acpi/power.c
index 912d4c4d62f4..c4e7e8698920 100644
--- a/xen/arch/x86/acpi/power.c
+++ b/xen/arch/x86/acpi/power.c
@@ -326,7 +326,7 @@ static int enter_state(u32 state)
     return error;
 }
 
-static long enter_state_helper(void *data)
+static long cf_check enter_state_helper(void *data)
 {
     struct acpi_sleep_info *sinfo = (struct acpi_sleep_info *)data;
     return enter_state(sinfo->sleep_state);
diff --git a/xen/arch/x86/cpu/microcode/core.c b/xen/arch/x86/cpu/microcode/core.c
index 46f55fe7f191..9631042190ab 100644
--- a/xen/arch/x86/cpu/microcode/core.c
+++ b/xen/arch/x86/cpu/microcode/core.c
@@ -558,7 +558,7 @@ struct ucode_buf {
     char buffer[];
 };
 
-static long microcode_update_helper(void *data)
+static long cf_check microcode_update_helper(void *data)
 {
     int ret;
     struct ucode_buf *buffer = data;
diff --git a/xen/arch/x86/include/asm/pv/shim.h b/xen/arch/x86/include/asm/pv/shim.h
index 6415f8068e5c..a43c3689b48a 100644
--- a/xen/arch/x86/include/asm/pv/shim.h
+++ b/xen/arch/x86/include/asm/pv/shim.h
@@ -38,8 +38,8 @@ void pv_shim_setup_dom(struct domain *d, l4_pgentry_t *l4start,
                        start_info_t *si);
 int pv_shim_shutdown(uint8_t reason);
 void pv_shim_inject_evtchn(unsigned int port);
-long pv_shim_cpu_up(void *data);
-long pv_shim_cpu_down(void *data);
+long cf_check pv_shim_cpu_up(void *data);
+long cf_check pv_shim_cpu_down(void *data);
 void pv_shim_online_memory(unsigned int nr, unsigned int order);
 void pv_shim_offline_memory(unsigned int nr, unsigned int order);
 domid_t get_initial_domain_id(void);
@@ -69,12 +69,12 @@ static inline void pv_shim_inject_evtchn(unsigned int port)
 {
     ASSERT_UNREACHABLE();
 }
-static inline long pv_shim_cpu_up(void *data)
+static inline long cf_check pv_shim_cpu_up(void *data)
 {
     ASSERT_UNREACHABLE();
     return 0;
 }
-static inline long pv_shim_cpu_down(void *data)
+static inline long cf_check pv_shim_cpu_down(void *data)
 {
     ASSERT_UNREACHABLE();
     return 0;
diff --git a/xen/arch/x86/include/asm/smp.h b/xen/arch/x86/include/asm/smp.h
index f7485f602efa..1747772d232e 100644
--- a/xen/arch/x86/include/asm/smp.h
+++ b/xen/arch/x86/include/asm/smp.h
@@ -57,10 +57,10 @@ int cpu_add(uint32_t apic_id, uint32_t acpi_id, uint32_t pxm);
 
 void __stop_this_cpu(void);
 
-long cpu_up_helper(void *data);
-long cpu_down_helper(void *data);
+long cf_check cpu_up_helper(void *data);
+long cf_check cpu_down_helper(void *data);
 
-long core_parking_helper(void *data);
+long cf_check core_parking_helper(void *data);
 bool core_parking_remove(unsigned int cpu);
 uint32_t get_cur_idle_nums(void);
 
diff --git a/xen/arch/x86/platform_hypercall.c b/xen/arch/x86/platform_hypercall.c
index 84566bbfaa3d..f5d7adc1e802 100644
--- a/xen/arch/x86/platform_hypercall.c
+++ b/xen/arch/x86/platform_hypercall.c
@@ -45,7 +45,7 @@ struct resource_access {
     xenpf_resource_entry_t *entries;
 };
 
-long cpu_frequency_change_helper(void *);
+long cf_check cpu_frequency_change_helper(void *);
 void check_resource_access(struct resource_access *);
 void resource_access(void *);
 
@@ -59,7 +59,7 @@ DEFINE_SPINLOCK(xenpf_lock);
 # undef guest_from_compat_handle
 # define guest_from_compat_handle(x,y) ((x)=(y))
 
-long cpu_frequency_change_helper(void *data)
+long cf_check cpu_frequency_change_helper(void *data)
 {
     return cpu_frequency_change((uint64_t)data);
 }
diff --git a/xen/arch/x86/pv/shim.c b/xen/arch/x86/pv/shim.c
index ae4d8913faa1..2ee290a3920d 100644
--- a/xen/arch/x86/pv/shim.c
+++ b/xen/arch/x86/pv/shim.c
@@ -845,7 +845,7 @@ int cf_check compat_grant_table_op(
 #endif
 #endif
 
-long pv_shim_cpu_up(void *data)
+long cf_check pv_shim_cpu_up(void *data)
 {
     struct vcpu *v = data;
     struct domain *d = v->domain;
@@ -883,7 +883,7 @@ long pv_shim_cpu_up(void *data)
     return 0;
 }
 
-long pv_shim_cpu_down(void *data)
+long cf_check pv_shim_cpu_down(void *data)
 {
     struct vcpu *v = data;
     long rc;
diff --git a/xen/arch/x86/smp.c b/xen/arch/x86/smp.c
index eef0f9c6cbf4..f4952a6bf9a5 100644
--- a/xen/arch/x86/smp.c
+++ b/xen/arch/x86/smp.c
@@ -399,7 +399,7 @@ void call_function_interrupt(struct cpu_user_regs *regs)
     smp_call_function_interrupt();
 }
 
-long cpu_up_helper(void *data)
+long cf_check cpu_up_helper(void *data)
 {
     unsigned int cpu = (unsigned long)data;
     int ret = cpu_up(cpu);
@@ -422,7 +422,7 @@ long cpu_up_helper(void *data)
     return ret;
 }
 
-long cpu_down_helper(void *data)
+long cf_check cpu_down_helper(void *data)
 {
     int cpu = (unsigned long)data;
     int ret = cpu_down(cpu);
diff --git a/xen/arch/x86/sysctl.c b/xen/arch/x86/sysctl.c
index aff52a13f373..1772f51f8f6e 100644
--- a/xen/arch/x86/sysctl.c
+++ b/xen/arch/x86/sysctl.c
@@ -79,7 +79,7 @@ static void l3_cache_get(void *arg)
         l3_info->size = info.size / 1024; /* in KB unit */
 }
 
-static long smt_up_down_helper(void *data)
+static long cf_check smt_up_down_helper(void *data)
 {
     bool up = (bool)data;
     unsigned int cpu, sibling_mask = boot_cpu_data.x86_num_siblings - 1;
diff --git a/xen/common/core_parking.c b/xen/common/core_parking.c
index 44a907abfd7f..4afad04f2f68 100644
--- a/xen/common/core_parking.c
+++ b/xen/common/core_parking.c
@@ -169,7 +169,7 @@ static unsigned int core_parking_power(unsigned int event)
     return cpu;
 }
 
-long core_parking_helper(void *data)
+long cf_check core_parking_helper(void *data)
 {
     uint32_t idle_nums = (unsigned long)data;
     unsigned int cpu;
diff --git a/xen/common/kexec.c b/xen/common/kexec.c
index 3b223cd03d75..b222a5fd782e 100644
--- a/xen/common/kexec.c
+++ b/xen/common/kexec.c
@@ -395,7 +395,7 @@ void kexec_crash(enum crash_reason reason)
     BUG();
 }
 
-static long kexec_reboot(void *_image)
+static long cf_check kexec_reboot(void *_image)
 {
     struct kexec_image *image = _image;
 
diff --git a/xen/common/sched/cpupool.c b/xen/common/sched/cpupool.c
index e5cfb03b857e..b9d4babd0d8a 100644
--- a/xen/common/sched/cpupool.c
+++ b/xen/common/sched/cpupool.c
@@ -544,7 +544,7 @@ static int cpupool_unassign_cpu_start(struct cpupool *c, unsigned int cpu)
     return ret;
 }
 
-static long cpupool_unassign_cpu_helper(void *info)
+static long cf_check cpupool_unassign_cpu_helper(void *info)
 {
     struct cpupool *c = info;
     long ret;
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Tue Feb 22 15:27:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 15:27:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276859.473223 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMX4Y-0007Jx-5p; Tue, 22 Feb 2022 15:27:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276859.473223; Tue, 22 Feb 2022 15:27:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMX4X-0007En-MW; Tue, 22 Feb 2022 15:27:25 +0000
Received: by outflank-mailman (input) for mailman id 276859;
 Tue, 22 Feb 2022 15:27:23 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Woib=TF=citrix.com=prvs=045a4fa17=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nMX4V-0006Cs-L5
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 15:27:23 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ecbaec81-93f3-11ec-8539-5f4723681683;
 Tue, 22 Feb 2022 16:27:21 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ecbaec81-93f3-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645543642;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=L045W9NEOuIRKd1S32sU0jL0uHWIuPgrAYtbmC4gyoY=;
  b=Et0i6TBuATWyVR2jJ4Z882ybRFKz7q6LVlibL2zAc5hZP+omQ7TLryaH
   pvvtmenUEmO6NAhi8eoquW3qOrqwutmDbjxED5aoOtbxKl9wfgkghVh8F
   ODwDAQO9IaoAd1Lzybvhv+nxnLj4b6XP+9C641icmzM5vHttq+nTh6Hrv
   s=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 64732553
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:EYviNKxYfnJII9KT8Kt6t+cyxirEfRIJ4+MujC+fZmUNrF6WrkVWz
 2odUWvQOvffNmSkfdwnOo+39hwCuJfVyYdmTlE/ryAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGHdJZS5LwbZj2NYy24LhWWthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 Npl9pyQEVx3Gbf2n8cjUhkFIR1DGIlf9+qSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DFYUToHx/ixreCu4rW8vrSKTW/95Imjw3g6iiGN6AO
 5VCM2cyN3wsZTVCPnIpGs5lkduYrSKua2xFq1mvipU4tj27IAtZj+G2bYu9lsaxbdpRtlaVo
 CTB5WuRKjMwOcGbyDGF2mmxneKJliT+MKoCGbv9+vN0jVm7wm0IFAZQRVa9ueO+iEO1R5RYM
 UN8x8Y1hfFsrgrxFIC7BkDm5i7f1vIBZzZOO646yFnWlI3O2QG6OGkEEwx9VfkCrcBjEFTGy
 WS1t9/uADVutpicRnSc6qqYoFuOBMQFEYMRTXRaFFVYurEPtKl210uSFYg7TMZZm/WoQWmY/
 tyckMQpa1z/Z+Yv3r7zw13IiinESnPhHl9svVW/so5IA2pEiG+Zi26AtACzARVodt/xory9U
 J4swZP2AAcmV8zlqcB1aL9RdIxFHt7cWNEmvXZhHoM66xOm8GO5cIZb7VlWfRk1b5paKGK0O
 hOK4Wu9AaO/2lPwNsebhKrrVqwXIVXIT4y5Bpg4kPIUCnSOSON31H43PhPBt4wcuEMtjbs+K
 f+mnTWEVh4n5VBc5GPuHY81iOZzrghnnD+7bc2rnnyPjOvFDFbIGOhtDbd7Rr1ghE9yiF6Oq
 Ig32grj40g3bdASlQGNr9ZIdAhSdSJT6FKfg5U/S9Nv6zFOQAkJY8I9C5t7E2C5t8y5Ttv1w
 0w=
IronPort-HdrOrdr: A9a23:wvbKHa5FasUdd7DxaAPXwPDXdLJyesId70hD6qhwISY6TiX+rb
 HWoB17726TtN9/YhEdcLy7VJVoBEmskKKdgrNhWotKPjOW21dARbsKheCJrgEIWReOktK1vZ
 0QC5SWY+eQMbEVt6nHCXGDYrQd/OU=
X-IronPort-AV: E=Sophos;i="5.88,387,1635220800"; 
   d="scan'208";a="64732553"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>
Subject: [PATCH v3 05/70] x86/kexec: Annotate embedded data with ELF metadata
Date: Tue, 22 Feb 2022 15:26:33 +0000
Message-ID: <20220222152645.8844-4-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220222152645.8844-1-andrew.cooper3@citrix.com>
References: <20220222152645.8844-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

Scanning for embedded endbranch instructions involves parsing the .text
disassembly.  Data in the kexec trampoline has no ELF metadata, so objdump
treats it as instructions and tries to disassemble.  Convert:

  ffff82d040396108 <compatibility_mode_far>:
  ffff82d040396108:       00 00                   add    %al,(%rax)
  ffff82d04039610a:       00 00                   add    %al,(%rax)
  ffff82d04039610c:       10 00                   adc    %al,(%rax)

  ffff82d04039610e <compat_mode_gdt_desc>:
  ffff82d04039610e:       17                      (bad)
          ...

  ffff82d040396118 <compat_mode_gdt>:
          ...
  ffff82d040396120:       ff                      (bad)
  ffff82d040396121:       ff 00                   incl   (%rax)
  ffff82d040396123:       00 00                   add    %al,(%rax)
  ffff82d040396125:       93                      xchg   %eax,%ebx
  ffff82d040396126:       cf                      iret
  ffff82d040396127:       00 ff                   add    %bh,%bh
  ffff82d040396129:       ff 00                   incl   (%rax)
  ffff82d04039612b:       00 00                   add    %al,(%rax)
  ffff82d04039612d:       9b                      fwait
  ffff82d04039612e:       cf                      iret
          ...

  ffff82d040396130 <compat_mode_idt>:
          ...

  ffff82d0403961b6 <kexec_reloc_size>:
  ffff82d0403961b6:       b6 01                   mov    $0x1,%dh
          ...

to:

  ffff82d040396108 <compatibility_mode_far>:
  ffff82d040396108:       00 00 00 00 10 00                               ......

  ffff82d04039610e <compat_mode_gdt_desc>:
  ffff82d04039610e:       17 00 00 00 00 00 00 00 00 00                   ..........

  ffff82d040396118 <compat_mode_gdt>:
          ...
  ffff82d040396120:       ff ff 00 00 00 93 cf 00 ff ff 00 00 00 9b cf 00 ................

  ffff82d040396130 <compat_mode_idt>:
  ffff82d040396130:       00 00 00 00 00 00                               ......

  ffff82d040396136 <reloc_stack>:
          ...

Most data just gains type and size metadata.

The reloc_stack label is the wrong end of the data block to have a size, so
move it to the lowest address and introduce .Lreloc_stack_base as a
replacement.  Also, fix the fact that it is misaligned by 2 bytes.

While kexec_reloc_size could gain metadata, it's use in the linker
assertion (while correct) is deeply confusing to follow.  Drop it entirely,
using a linker symbol instead to denote the end of the trampoline.

No functional change.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>

The remainder of the 32bit code has mode-invariant lengths, so disassembles
safely as 64bit.  The only differences come from 32/64bit implicit register
sizes.

v2.1:
 * New
v2.2:
 * Fix stack alignment
---
 xen/arch/x86/include/asm/machine_kexec.h |  2 +-
 xen/arch/x86/machine_kexec.c             |  2 +-
 xen/arch/x86/x86_64/kexec_reloc.S        | 23 ++++++++++++++++++-----
 xen/arch/x86/xen.lds.S                   |  3 ++-
 4 files changed, 22 insertions(+), 8 deletions(-)

diff --git a/xen/arch/x86/include/asm/machine_kexec.h b/xen/arch/x86/include/asm/machine_kexec.h
index ba0d469d077b..d4880818c1d9 100644
--- a/xen/arch/x86/include/asm/machine_kexec.h
+++ b/xen/arch/x86/include/asm/machine_kexec.h
@@ -9,7 +9,7 @@ extern void kexec_reloc(unsigned long reloc_code, unsigned long reloc_pt,
                         unsigned long ind_maddr, unsigned long entry_maddr,
                         unsigned long flags);
 
-extern unsigned int kexec_reloc_size;
+extern const char kexec_reloc_end[];
 
 #endif
 
diff --git a/xen/arch/x86/machine_kexec.c b/xen/arch/x86/machine_kexec.c
index 08ec9fd43b1d..751a9efcaf6a 100644
--- a/xen/arch/x86/machine_kexec.c
+++ b/xen/arch/x86/machine_kexec.c
@@ -117,7 +117,7 @@ int machine_kexec_load(struct kexec_image *image)
     }
 
     code_page = __map_domain_page(image->control_code_page);
-    memcpy(code_page, kexec_reloc, kexec_reloc_size);
+    memcpy(code_page, kexec_reloc, kexec_reloc_end - (char *)kexec_reloc);
     unmap_domain_page(code_page);
 
     /*
diff --git a/xen/arch/x86/x86_64/kexec_reloc.S b/xen/arch/x86/x86_64/kexec_reloc.S
index d488d127cfb9..89316bc3a7ac 100644
--- a/xen/arch/x86/x86_64/kexec_reloc.S
+++ b/xen/arch/x86/x86_64/kexec_reloc.S
@@ -34,7 +34,7 @@ ENTRY(kexec_reloc)
         movq    %rcx, %rbp
 
         /* Setup stack. */
-        leaq    (reloc_stack - kexec_reloc)(%rdi), %rsp
+        leaq    (.Lreloc_stack_base - kexec_reloc)(%rdi), %rsp
 
         /* Load reloc page table. */
         movq    %rsi, %cr3
@@ -175,10 +175,16 @@ compatibility_mode_far:
         .long 0x00000000             /* set in call_32_bit above */
         .word 0x0010
 
+        .type compatibility_mode_far, @object
+        .size compatibility_mode_far, . - compatibility_mode_far
+
 compat_mode_gdt_desc:
         .word .Lcompat_mode_gdt_end - compat_mode_gdt -1
         .quad 0x0000000000000000     /* set in call_32_bit above */
 
+        .type compat_mode_gdt_desc, @object
+        .size compat_mode_gdt_desc, . - compat_mode_gdt_desc
+
         .align 8
 compat_mode_gdt:
         .quad 0x0000000000000000     /* null                              */
@@ -186,16 +192,23 @@ compat_mode_gdt:
         .quad 0x00cf9b000000ffff     /* 0x0010 ring 0 code, compatibility */
 .Lcompat_mode_gdt_end:
 
+        .type compat_mode_gdt, @object
+        .size compat_mode_gdt, . - compat_mode_gdt
+
 compat_mode_idt:
         .word 0                      /* limit */
         .long 0                      /* base */
 
+        .type compat_mode_idt, @object
+        .size compat_mode_idt, . - compat_mode_idt
+
         /*
          * 16 words of stack are more than enough.
          */
-        .fill 16,8,0
+        .align 8
 reloc_stack:
+        .fill 16,8,0
+.Lreloc_stack_base:
 
-        .globl kexec_reloc_size
-kexec_reloc_size:
-        .long . - kexec_reloc
+        .type reloc_stack, @object
+        .size reloc_stack, . - reloc_stack
diff --git a/xen/arch/x86/xen.lds.S b/xen/arch/x86/xen.lds.S
index 82ad8feb6e99..7ffecd463070 100644
--- a/xen/arch/x86/xen.lds.S
+++ b/xen/arch/x86/xen.lds.S
@@ -84,6 +84,7 @@ SECTIONS
        _etextentry = .;
 
        *(.text.kexec)          /* Page aligned in the object file. */
+       kexec_reloc_end = .;
 
        *(.text.cold)
        *(.text.unlikely)
@@ -428,7 +429,7 @@ ASSERT(__2M_rwdata_end <= XEN_VIRT_END - XEN_VIRT_START + __XEN_VIRT_START -
        "Xen image overlaps stubs area")
 
 #ifdef CONFIG_KEXEC
-ASSERT(kexec_reloc_size - kexec_reloc <= PAGE_SIZE, "kexec_reloc is too large")
+ASSERT(kexec_reloc_end - kexec_reloc <= PAGE_SIZE, "kexec_reloc is too large")
 #endif
 
 /* The Multiboot setup paths relies on this to simplify superpage PTE creation. */
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Tue Feb 22 15:27:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 15:27:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276860.473234 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMX4Z-0007bg-E9; Tue, 22 Feb 2022 15:27:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276860.473234; Tue, 22 Feb 2022 15:27:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMX4Y-0007Yf-VE; Tue, 22 Feb 2022 15:27:26 +0000
Received: by outflank-mailman (input) for mailman id 276860;
 Tue, 22 Feb 2022 15:27:24 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Woib=TF=citrix.com=prvs=045a4fa17=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nMX4W-0006OK-El
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 15:27:24 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ed307a22-93f3-11ec-8eb8-a37418f5ba1a;
 Tue, 22 Feb 2022 16:27:23 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ed307a22-93f3-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645543643;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=N0ZI0nkwMH4pgo3uSdj8brsbvDtIU17yJ3AGUn36a0I=;
  b=gGnoZXpAYwjD/5KM9Wf+sEgXjWpjDnKnLQUY28EhAb4oVxJCM87cajWF
   lTUGJoJXba+9l9/NF9rZGn0V3tk1QR5l0L7JZKsc3ycvl3e0stGXSKHe/
   wX02dVNlrqjB7hAcfZnUX84xw94TvvYnh/a/74c0sjG2FcMilYo9BvPuI
   M=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 64170205
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:YL8mOauVmCFsvLprfuHyzmA/UOfnVDJeMUV32f8akzHdYApBsoF/q
 tZmKWyAOqmIZ2fxfoslO4vip0gEuJ7WmtM1TlZp+y1gFXxH+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQzy4bVvqYy2YLjW1nX4
 4uoyyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb
 /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo
 Oihu6BcRi83H5Lzg8A3TSViHj8lYINb4a3nA0Gw5Jn7I03uKxMAwt1rBUAye4YZ5vx2ESdF8
 vlwxDIlN07ZwbjsmfTiF7cq1p9LwMrDZevzvllJyz3DAOlgapfEW6jQvvdT3Ssqh9AIFvHbD
 yYcQWQzNUuYOUUSUrsRIIkjkd+xol/jSTp7+BHJhbEK4DTc0wMkhdABN/KKI4fXFK25hH2wt
 m/Aumj0HBweHNie0iaetGKhgPfVmiH2U55UE6e3nsOGm3XKmDZVUkdPEwLm/7/p0SZSRu6zN
 WQK2xURtowY6nCRQ8emAjOluWyknCcTDo84//IB1CmBza/d4gC8D2cCTyJcZNFOiPLaVQDGx
 XfSwYq3WGUHXKm9DCvEq+zK9W/a1T09cDdaDRLoWzfp9DUKTGsbqhvUBuhuH6eu5jEeMWGhm
 mvaxMTSalh6sCLq60lZ1Q2f695PjsKQJuLQ2ukxdjj+hu+eTNT4D7FEEXCBsZ59wH+xFzFtR
 kQslcmE9/wpBpqQjiGLS+hlNOj3u6vZbmyB3AQzRsFJG9GRF5iLJ9s4DNZWfhoBDyr5UWWxP
 B+7Vf15vve/w0dGnYcoOtnsWqzGPIDrFMj/V+C8Uza9SsMZSeNzxwk3PRT49zm0yCAEyPhjU
 b/GIZfEJStLUsxPkWvpL9rxJJd2n0jSM0uIHsulp/lmuJLDDEOopUAtagXWNblhtPveyOgXm
 v4GX/a3J9xkeLWWSkHqHUQ7djjm8VBT6UjKlvFq
IronPort-HdrOrdr: A9a23:n6mPX64mQ38icmHMlQPXwMrXdLJyesId70hD6qhwISY6TiX4rb
 HWoB1173/JYVoqNE3I3OrwXZVoIkmsk6Kdg7NhXotKNTOO0ADDQb2Kr7GSpwEIcxeOkdK1vp
 0AT0ERMrLN5CBB/KTH3DU=
X-IronPort-AV: E=Sophos;i="5.88,387,1635220800"; 
   d="scan'208";a="64170205"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v3 27/70] xen/video: CFI hardening
Date: Tue, 22 Feb 2022 15:26:38 +0000
Message-ID: <20220222152645.8844-9-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220222152645.8844-1-andrew.cooper3@citrix.com>
References: <20220222152645.8844-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

Control Flow Integrity schemes use toolchain and optionally hardware support
to help protect against call/jump/return oriented programming attacks.

Use cf_check to annotate function pointer targets for the toolchain.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
v3:
 * Rebase over recent commits
---
 xen/drivers/video/lfb.c  | 4 ++--
 xen/drivers/video/lfb.h  | 4 ++--
 xen/drivers/video/vesa.c | 4 ++--
 xen/drivers/video/vga.c  | 6 +++---
 4 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/xen/drivers/video/lfb.c b/xen/drivers/video/lfb.c
index 9254b5e9022a..a6fb837974f7 100644
--- a/xen/drivers/video/lfb.c
+++ b/xen/drivers/video/lfb.c
@@ -53,7 +53,7 @@ static void lfb_show_line(
 }
 
 /* Fast mode which redraws all modified parts of a 2D text buffer. */
-void lfb_redraw_puts(const char *s, size_t nr)
+void cf_check lfb_redraw_puts(const char *s, size_t nr)
 {
     unsigned int i, min_redraw_y = lfb.ypos;
 
@@ -98,7 +98,7 @@ void lfb_redraw_puts(const char *s, size_t nr)
 }
 
 /* Slower line-based scroll mode which interacts better with dom0. */
-void lfb_scroll_puts(const char *s, size_t nr)
+void cf_check lfb_scroll_puts(const char *s, size_t nr)
 {
     unsigned int i;
 
diff --git a/xen/drivers/video/lfb.h b/xen/drivers/video/lfb.h
index e743ccdd6b11..42161402d611 100644
--- a/xen/drivers/video/lfb.h
+++ b/xen/drivers/video/lfb.h
@@ -35,8 +35,8 @@ struct lfb_prop {
     unsigned int text_rows;
 };
 
-void lfb_redraw_puts(const char *s, size_t nr);
-void lfb_scroll_puts(const char *s, size_t nr);
+void cf_check lfb_redraw_puts(const char *s, size_t nr);
+void cf_check lfb_scroll_puts(const char *s, size_t nr);
 void lfb_carriage_return(void);
 void lfb_free(void);
 
diff --git a/xen/drivers/video/vesa.c b/xen/drivers/video/vesa.c
index c8f81a5cc5fc..c41f6b8d4028 100644
--- a/xen/drivers/video/vesa.c
+++ b/xen/drivers/video/vesa.c
@@ -17,7 +17,7 @@
 
 #define vlfb_info    vga_console_info.u.vesa_lfb
 
-static void lfb_flush(void);
+static void cf_check lfb_flush(void);
 
 static unsigned char *__read_mostly lfb;
 static const struct font_desc *__initdata font;
@@ -140,7 +140,7 @@ void __init vesa_init(void)
     video_puts = lfb_redraw_puts;
 }
 
-static void lfb_flush(void)
+static void cf_check lfb_flush(void)
 {
     __asm__ __volatile__ ("sfence" : : : "memory");
 }
diff --git a/xen/drivers/video/vga.c b/xen/drivers/video/vga.c
index 5e58f83c97ff..e624ebff4f8c 100644
--- a/xen/drivers/video/vga.c
+++ b/xen/drivers/video/vga.c
@@ -19,8 +19,8 @@ static int vgacon_keep;
 static unsigned int xpos, ypos;
 static unsigned char *video;
 
-static void vga_text_puts(const char *s, size_t nr);
-static void vga_noop_puts(const char *s, size_t nr) {}
+static void cf_check vga_text_puts(const char *s, size_t nr);
+static void cf_check vga_noop_puts(const char *s, size_t nr) {}
 void (*video_puts)(const char *, size_t nr) = vga_noop_puts;
 
 /*
@@ -179,7 +179,7 @@ void __init video_endboot(void)
     }
 }
 
-static void vga_text_puts(const char *s, size_t nr)
+static void cf_check vga_text_puts(const char *s, size_t nr)
 {
     for ( ; nr > 0; nr--, s++ )
     {
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Tue Feb 22 15:27:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 15:27:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276861.473241 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMX4a-0007pn-Ao; Tue, 22 Feb 2022 15:27:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276861.473241; Tue, 22 Feb 2022 15:27:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMX4Z-0007kE-QE; Tue, 22 Feb 2022 15:27:27 +0000
Received: by outflank-mailman (input) for mailman id 276861;
 Tue, 22 Feb 2022 15:27:25 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Woib=TF=citrix.com=prvs=045a4fa17=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nMX4W-0006Cs-Tr
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 15:27:25 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ee7f66ff-93f3-11ec-8539-5f4723681683;
 Tue, 22 Feb 2022 16:27:23 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ee7f66ff-93f3-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645543643;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=YvugFJaL6MOaaDvMEXxrAztfnWSnB+eJNt0lMJu1ZCI=;
  b=HsS/xpwXxSKHWjOATKlQ38wtnxiOvuzhN+xbbNEUqupr84YGyJ/bz++/
   nLf38GXGKHJp0BnFM1b13FBSAJgv8zPW/XNm+FismwEkGMUzs7M/v2UV0
   oJs2s71Gr+26ZPmw3PE9RjUXPTi/Cp7UxABzSEuv/Ia/KKfV+UgfcpJh6
   A=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 64732554
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:qmf2V688elTIP6AU6HKiDrUDW36TJUtcMsCJ2f8bNWPcYEJGY0x3n
 WMXWzyDa/qPNmKmc91zOonn90NS7cSEnNVnSlNt+X88E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si+Fa+Sn9T8mvU2xbuKU5NTsY0idfic5Dndx4f5fs7Rh2NQw24LjW1nlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCnZWLe0QmJPH2pLgAYSF7AxAhJa0a9YaSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFKoZtmtt0nfyCvE+TIqYa67L+cVZzHE7gcUm8fP2O
 ZZGMmAyMUiojxtnZHcOT5AnktqSgFL1SSZV+HGsj7c97D2GpOB2+Oe0a4eEEjCQfu1Xg0KZq
 2Tu72n/RBYAO7S39z2B9X69g/7VqgnyUokSCb6Q++ZjhRuYwWl7IBcbT0ehqP+1zEu3QctCK
 lc88zAr66M18SSDUd3VTxC+5nmesXY0S9dWVuE39gyJ4q7V+BqCQHgJSCZbb94rv9NwQiYlv
 nertd70AT1ksJWOVGmQsLyTqFuaIjMJJGUPYSsFSwot4NT5pow3yBXVQb5e/LWd14OvX2uqm
 nbT8XZ41+57YdM3O7uT9Gv1wD22+qL1EhMH3ibHbz297l90XdvwD2C30mTz4fFFJYefa1COu
 nkYhsSThNwz4YGxeD+lG7tUQuzwjxqRGHiF2AM0QcF9n9i40yP7JehtDCdCyFCF2yruURvge
 wfttAxY//e/11P6PPYsM+pd5ynHpJUM9OgJtNiJNrKigbArLWdrGR2Cg2bKhAgBd2B2zMkC1
 W+zK5rEMJrjIf0PIMCKb+kcy6Q34Ss12HneQ5v2pzz+j+bDOCDEFOpfbALWBgzc0E9iiF+Om
 zq4H5HXoyizrcWkOnWHmWLtBQpiwYcH6WDe9JUMK7/rzvtOE2A9Ef7BqY7NiKQ+95m5Ytzgp
 ynnMmcBkQKXrSSedW2iNyAyAJuyDM0XhS9qYkQR0aOAhiFLjXCHt/xEKfPavNAPqYRe8BKDZ
 6NbI57ZWqwXEFwqOV01NPHAkWCrTzzz7SrmAsZvSGJXk0JIL+ARxuLZQw==
IronPort-HdrOrdr: A9a23:XxPKoaw0wSuYcDlr499UKrPwFL1zdoMgy1knxilNoRw8SKKlfq
 eV7Y0mPH7P+VAssR4b+exoVJPtfZqYz+8R3WBzB8bEYOCFghrKEGgK1+KLqFeMJ8S9zJ846U
 4JSdkHNDSaNzlHZKjBjzVQa+xQouW6zA==
X-IronPort-AV: E=Sophos;i="5.88,387,1635220800"; 
   d="scan'208";a="64732554"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>
Subject: [PATCH v3 01/70] xen/sort: Switch to an extern inline implementation
Date: Tue, 22 Feb 2022 15:26:31 +0000
Message-ID: <20220222152645.8844-2-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220222152645.8844-1-andrew.cooper3@citrix.com>
References: <20220222152645.8844-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

There are exactly 3 callers of sort() in the hypervisor.  Callbacks in a tight
loop like this are problematic for performance, especially with Spectre v2
protections, which is why extern inline is used commonly by libraries.

Both ARM callers pass in NULL for the swap function, and while this might seem
like an attractive option at first, it causes generic_swap() to be used, which
forced a byte-wise copy.  Provide real swap functions so the compiler can
optimise properly, which is very important for ARM downstreams where
milliseconds until the system is up matters.

This is also important for Control Flow Integrity schemes (e.g. x86 CET-IBT,
ARM BTI), because tagged function(s) performing an arbitrary length swap of
two arbitrary pointers is a very valuable gadget for an attacker.

No functional change.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>
CC: Stefano Stabellini <sstabellini@kernel.org>
CC: Julien Grall <julien@xen.org>
CC: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
CC: Bertrand Marquis <bertrand.marquis@arm.com>

v2:
 * Adjust commit message
v3:
 * Adjust comment
 * Adjust commit message again
---
 xen/arch/arm/bootfdt.c |  9 +++++-
 xen/arch/arm/io.c      |  9 +++++-
 xen/include/xen/sort.h | 55 +++++++++++++++++++++++++++++++++-
 xen/lib/sort.c         | 80 ++------------------------------------------------
 4 files changed, 72 insertions(+), 81 deletions(-)

diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c
index afaa0e249b71..e318ef960386 100644
--- a/xen/arch/arm/bootfdt.c
+++ b/xen/arch/arm/bootfdt.c
@@ -448,6 +448,13 @@ static int __init cmp_memory_node(const void *key, const void *elem)
     return 0;
 }
 
+static void __init swap_memory_node(void *_a, void *_b, size_t size)
+{
+    struct membank *a = _a, *b = _b;
+
+    SWAP(*a, *b);
+}
+
 /**
  * boot_fdt_info - initialize bootinfo from a DTB
  * @fdt: flattened device tree binary
@@ -472,7 +479,7 @@ size_t __init boot_fdt_info(const void *fdt, paddr_t paddr)
      * the banks sorted in ascending order. So sort them through.
      */
     sort(bootinfo.mem.bank, bootinfo.mem.nr_banks, sizeof(struct membank),
-         cmp_memory_node, NULL);
+         cmp_memory_node, swap_memory_node);
 
     early_print_info();
 
diff --git a/xen/arch/arm/io.c b/xen/arch/arm/io.c
index 729287e37c59..1a066f9ae502 100644
--- a/xen/arch/arm/io.c
+++ b/xen/arch/arm/io.c
@@ -80,6 +80,13 @@ static int cmp_mmio_handler(const void *key, const void *elem)
     return 0;
 }
 
+static void swap_mmio_handler(void *_a, void *_b, size_t size)
+{
+    struct mmio_handler *a = _a, *b = _b;
+
+    SWAP(*a, *b);
+}
+
 static const struct mmio_handler *find_mmio_handler(struct domain *d,
                                                     paddr_t gpa)
 {
@@ -170,7 +177,7 @@ void register_mmio_handler(struct domain *d,
 
     /* Sort mmio handlers in ascending order based on base address */
     sort(vmmio->handlers, vmmio->num_entries, sizeof(struct mmio_handler),
-         cmp_mmio_handler, NULL);
+         cmp_mmio_handler, swap_mmio_handler);
 
     write_unlock(&vmmio->lock);
 }
diff --git a/xen/include/xen/sort.h b/xen/include/xen/sort.h
index a403652948e7..2f52ff85b9e4 100644
--- a/xen/include/xen/sort.h
+++ b/xen/include/xen/sort.h
@@ -3,8 +3,61 @@
 
 #include <xen/types.h>
 
+/*
+ * sort - sort an array of elements
+ * @base: pointer to data to sort
+ * @num: number of elements
+ * @size: size of each element
+ * @cmp: pointer to comparison function
+ * @swap: pointer to swap function
+ *
+ * This function does a heapsort on the given array. You may provide a
+ * swap function optimized to your element type.
+ *
+ * Sorting time is O(n log n) both on average and worst-case. While
+ * qsort is about 20% faster on average, it suffers from exploitable
+ * O(n*n) worst-case behavior and extra memory requirements that make
+ * it less suitable for kernel use.
+ */
+#ifndef SORT_IMPLEMENTATION
+extern gnu_inline
+#endif
 void sort(void *base, size_t num, size_t size,
           int (*cmp)(const void *, const void *),
-          void (*swap)(void *, void *, size_t));
+          void (*swap)(void *, void *, size_t))
+{
+    /* pre-scale counters for performance */
+    size_t i = (num / 2) * size, n = num * size, c, r;
+
+    /* heapify */
+    while ( i > 0 )
+    {
+        for ( r = i -= size; r * 2 + size < n; r = c )
+        {
+            c = r * 2 + size;
+            if ( (c < n - size) && (cmp(base + c, base + c + size) < 0) )
+                c += size;
+            if ( cmp(base + r, base + c) >= 0 )
+                break;
+            swap(base + r, base + c, size);
+        }
+    }
+
+    /* sort */
+    for ( i = n; i > 0; )
+    {
+        i -= size;
+        swap(base, base + i, size);
+        for ( r = 0; r * 2 + size < i; r = c )
+        {
+            c = r * 2 + size;
+            if ( (c < i - size) && (cmp(base + c, base + c + size) < 0) )
+                c += size;
+            if ( cmp(base + r, base + c) >= 0 )
+                break;
+            swap(base + r, base + c, size);
+        }
+    }
+}
 
 #endif /* __XEN_SORT_H__ */
diff --git a/xen/lib/sort.c b/xen/lib/sort.c
index 35ce0d7abdec..b7e78cc0e8d2 100644
--- a/xen/lib/sort.c
+++ b/xen/lib/sort.c
@@ -4,81 +4,5 @@
  * Jan 23 2005  Matt Mackall <mpm@selenic.com>
  */
 
-#include <xen/types.h>
-
-static void u32_swap(void *a, void *b, size_t size)
-{
-    uint32_t t = *(uint32_t *)a;
-
-    *(uint32_t *)a = *(uint32_t *)b;
-    *(uint32_t *)b = t;
-}
-
-static void generic_swap(void *a, void *b, size_t size)
-{
-    char t;
-
-    do {
-        t = *(char *)a;
-        *(char *)a++ = *(char *)b;
-        *(char *)b++ = t;
-    } while ( --size > 0 );
-}
-
-/*
- * sort - sort an array of elements
- * @base: pointer to data to sort
- * @num: number of elements
- * @size: size of each element
- * @cmp: pointer to comparison function
- * @swap: pointer to swap function or NULL
- *
- * This function does a heapsort on the given array. You may provide a
- * swap function optimized to your element type.
- *
- * Sorting time is O(n log n) both on average and worst-case. While
- * qsort is about 20% faster on average, it suffers from exploitable
- * O(n*n) worst-case behavior and extra memory requirements that make
- * it less suitable for kernel use.
- */
-
-void sort(void *base, size_t num, size_t size,
-          int (*cmp)(const void *, const void *),
-          void (*swap)(void *, void *, size_t size))
-{
-    /* pre-scale counters for performance */
-    size_t i = (num / 2) * size, n = num * size, c, r;
-
-    if ( !swap )
-        swap = (size == 4 ? u32_swap : generic_swap);
-
-    /* heapify */
-    while ( i > 0 )
-    {
-        for ( r = i -= size; r * 2 + size < n; r = c )
-        {
-            c = r * 2 + size;
-            if ( (c < n - size) && (cmp(base + c, base + c + size) < 0) )
-                c += size;
-            if ( cmp(base + r, base + c) >= 0 )
-                break;
-            swap(base + r, base + c, size);
-        }
-    }
-
-    /* sort */
-    for ( i = n; i > 0; )
-    {
-        i -= size;
-        swap(base, base + i, size);
-        for ( r = 0; r * 2 + size < i; r = c )
-        {
-            c = r * 2 + size;
-            if ( (c < i - size) && (cmp(base + c, base + c + size) < 0) )
-                c += size;
-            if ( cmp(base + r, base + c) >= 0 )
-                break;
-            swap(base + r, base + c, size);
-        }
-    }
-}
+#define SORT_IMPLEMENTATION
+#include <xen/sort.h>
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Tue Feb 22 15:27:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 15:27:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276862.473250 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMX4b-00084F-F0; Tue, 22 Feb 2022 15:27:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276862.473250; Tue, 22 Feb 2022 15:27:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMX4a-00081v-TB; Tue, 22 Feb 2022 15:27:28 +0000
Received: by outflank-mailman (input) for mailman id 276862;
 Tue, 22 Feb 2022 15:27:26 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Woib=TF=citrix.com=prvs=045a4fa17=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nMX4X-0006OK-Eo
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 15:27:25 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ee4fdfc9-93f3-11ec-8eb8-a37418f5ba1a;
 Tue, 22 Feb 2022 16:27:22 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ee4fdfc9-93f3-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645543642;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=e1ULosOfawLcYEINxUPh+g454GPdzkLF1+BQThMlbkY=;
  b=OmmE7qpCDKImuwHJiwzzw68rTuicobvwDU9OfE/rvFbFWtkCQ+Zt34CU
   W84H6arU+XQJKMdnJ/PaYoopKcTwKrkWdaWJHDt5vm6UH8IoUeIvkJZPg
   4QYgjMQ4oWCIT0Q0triG/pAQPRiLXjaWKhaFfgKrskAG6oEgOzmX+4D/p
   k=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 66981792
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:XIYB2av5haYTNnH91vsJJwe9AOfnVDJeMUV32f8akzHdYApBsoF/q
 tZmKTrQPfyPYDb9eoxxOo6xo0lXuJfUztBjHlBkqC09FCwa+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQzy4bVvqYy2YLjW1nX4
 4uoyyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb
 /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo
 Oihu6BcRi8SB/bppvowdCJgDnB+DapA95XFDHGw5Jn7I03uKxMAwt1rBUAye4YZ5vx2ESdF8
 vlwxDIlN07ZwbjsmfTiF7cq1p9LwMrDZevzvllJyz3DAOlgapfEW6jQvvdT3Ssqh9AIFvHbD
 yYcQWQxPUSZPEwVUrsRIM0+hNiKiCn8TxtRs32r+ptnsnWC7RMkhdABN/KKI4fXFK25hH2wt
 m/Aumj0HBweHNie0iaetGKhgPfVmiH2U55UE6e3nsOGm3XKmDZVUkdPEwLm/7/p0SZSRu6zN
 WQvw3ELk7Yf03eTU4j9bxq+r1SGkxcTDo84//IB1CmBza/d4gC8D2cCTyJcZNFOiPLaVQDGx
 XfSwYq3WGUHXKm9DCvEq+zK9W/a1T09cDdaDRLoWzfp9DUKTGsbqhvUBuhuH6eu5jEeMWGhm
 mvaxMTSalh6sCLq60lZ1Q2f695PjsKQJuLQ2ukxdjj+hu+eTNT4D7FEEXCBsZ59wH+xFzFtR
 kQslcmE9/wpBpqQjiGLS+hlNOj3u6vZbmyB3AQzRsFJG9GRF5iLJ9s4DNZWfhoBDyr5UWWxP
 B+7Vf15vve/w0dGnYcoOtnsWqzGPIDrFMj/V+C8Uza9SsMZSeNzxwk3PRT49zm0yCAEyPhjU
 b/GIZfEJStLUsxPkWvpL9rxJJd2n0jSM0uIHsulp/lmuJLDDEOopUAtagXWNblhtPveyOgXm
 v4GX/a3J9xkeLWWSkHqHUQ7djjm8VBT6UjKlvFq
IronPort-HdrOrdr: A9a23:WZ0UMqlz/L4Xwfpl3n0KXtc/+bvpDfIo3DAbv31ZSRFFG/Fxl6
 iV/cjztCWE8Ar5N0tQ+uxoVJPufZqYz+8Q3WBzB8baYOCFghrLEGgK1+KLqFeMdxEWtNQtsp
 uIG5IObuEYZmIbsS+V2meF+q4bsby6zJw=
X-IronPort-AV: E=Sophos;i="5.88,387,1635220800"; 
   d="scan'208";a="66981792"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v3 08/70] xen: CFI hardening for custom_param()
Date: Tue, 22 Feb 2022 15:26:35 +0000
Message-ID: <20220222152645.8844-6-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220222152645.8844-1-andrew.cooper3@citrix.com>
References: <20220222152645.8844-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

Control Flow Integrity schemes use toolchain and optionally hardware support
to help protect against call/jump/return oriented programming attacks.

Use cf_check to annotate function pointer targets for the toolchain.

The "watchdog_timeout" and "cpu_type" handlers were missing __init.

The "numa", "acpi", "irq_vector_map" and "flask" handlers can skip forward
declarations by altering the custom_param() position.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
v3:
 * Rebase over recent "vesa" changes.
---
 xen/arch/x86/acpi/cpu_idle.c             |  2 +-
 xen/arch/x86/acpi/power.c                |  2 +-
 xen/arch/x86/apic.c                      |  4 ++--
 xen/arch/x86/cpu/mcheck/mce.c            |  2 +-
 xen/arch/x86/cpu/microcode/core.c        |  2 +-
 xen/arch/x86/cpu/vpmu.c                  |  2 +-
 xen/arch/x86/cpuid.c                     |  8 ++++----
 xen/arch/x86/dom0_build.c                |  8 ++++----
 xen/arch/x86/genapic/probe.c             |  2 +-
 xen/arch/x86/hpet.c                      |  2 +-
 xen/arch/x86/hvm/viridian/viridian.c     |  2 +-
 xen/arch/x86/hvm/vmx/vmcs.c              |  8 ++++----
 xen/arch/x86/io_apic.c                   |  2 +-
 xen/arch/x86/irq.c                       |  6 ++----
 xen/arch/x86/mm.c                        |  2 +-
 xen/arch/x86/nmi.c                       |  4 ++--
 xen/arch/x86/numa.c                      |  6 ++----
 xen/arch/x86/oprofile/nmi_int.c          |  2 +-
 xen/arch/x86/psr.c                       |  2 +-
 xen/arch/x86/pv/domain.c                 |  8 ++++----
 xen/arch/x86/pv/shim.c                   |  2 +-
 xen/arch/x86/setup.c                     | 11 +++++------
 xen/arch/x86/shutdown.c                  |  2 +-
 xen/arch/x86/spec_ctrl.c                 |  6 +++---
 xen/arch/x86/time.c                      |  2 +-
 xen/arch/x86/tsx.c                       |  2 +-
 xen/arch/x86/x86_64/mmconfig-shared.c    |  2 +-
 xen/common/argo.c                        |  2 +-
 xen/common/core_parking.c                |  2 +-
 xen/common/debugtrace.c                  |  2 +-
 xen/common/domain.c                      |  2 +-
 xen/common/efi/boot.c                    |  2 +-
 xen/common/grant_table.c                 | 14 +++++++-------
 xen/common/kexec.c                       |  6 +++---
 xen/common/memory.c                      |  2 +-
 xen/common/page_alloc.c                  |  2 +-
 xen/common/sched/cpupool.c               |  2 +-
 xen/common/sched/credit2.c               |  2 +-
 xen/drivers/acpi/tables.c                |  2 +-
 xen/drivers/char/console.c               | 18 +++++++++---------
 xen/drivers/cpufreq/cpufreq.c            |  2 +-
 xen/drivers/passthrough/amd/iommu_acpi.c |  6 +++---
 xen/drivers/passthrough/iommu.c          |  4 ++--
 xen/drivers/passthrough/pci.c            |  4 ++--
 xen/drivers/passthrough/vtd/dmar.c       |  2 +-
 xen/drivers/passthrough/vtd/quirks.c     |  2 +-
 xen/drivers/video/vesa.c                 |  2 +-
 xen/xsm/flask/flask_op.c                 |  5 ++---
 xen/xsm/xsm_core.c                       |  2 +-
 49 files changed, 92 insertions(+), 98 deletions(-)

diff --git a/xen/arch/x86/acpi/cpu_idle.c b/xen/arch/x86/acpi/cpu_idle.c
index d788c8bffc84..5d73eb5917af 100644
--- a/xen/arch/x86/acpi/cpu_idle.c
+++ b/xen/arch/x86/acpi/cpu_idle.c
@@ -106,7 +106,7 @@ void (*__read_mostly pm_idle_save)(void);
 unsigned int max_cstate __read_mostly = UINT_MAX;
 unsigned int max_csubstate __read_mostly = UINT_MAX;
 
-static int __init parse_cstate(const char *s)
+static int __init cf_check parse_cstate(const char *s)
 {
     max_cstate = simple_strtoul(s, &s, 0);
     if ( *s == ',' )
diff --git a/xen/arch/x86/acpi/power.c b/xen/arch/x86/acpi/power.c
index 5eaa77f66a28..912d4c4d62f4 100644
--- a/xen/arch/x86/acpi/power.c
+++ b/xen/arch/x86/acpi/power.c
@@ -35,7 +35,7 @@
 
 uint32_t system_reset_counter = 1;
 
-static int __init parse_acpi_sleep(const char *s)
+static int __init cf_check parse_acpi_sleep(const char *s)
 {
     const char *ss;
     unsigned int flag = 0;
diff --git a/xen/arch/x86/apic.c b/xen/arch/x86/apic.c
index 583656158532..68e4d870c749 100644
--- a/xen/arch/x86/apic.c
+++ b/xen/arch/x86/apic.c
@@ -775,7 +775,7 @@ int lapic_resume(void)
  * Original code written by Keir Fraser.
  */
 
-static int __init lapic_disable(const char *str)
+static int __init cf_check lapic_disable(const char *str)
 {
     enable_local_apic = -1;
     setup_clear_cpu_cap(X86_FEATURE_APIC);
@@ -784,7 +784,7 @@ static int __init lapic_disable(const char *str)
 custom_param("nolapic", lapic_disable);
 boolean_param("lapic", enable_local_apic);
 
-static int __init apic_set_verbosity(const char *str)
+static int __init cf_check apic_set_verbosity(const char *str)
 {
     if (strcmp("debug", str) == 0)
         apic_verbosity = APIC_DEBUG;
diff --git a/xen/arch/x86/cpu/mcheck/mce.c b/xen/arch/x86/cpu/mcheck/mce.c
index eae08caa07cd..ea86d84481b2 100644
--- a/xen/arch/x86/cpu/mcheck/mce.c
+++ b/xen/arch/x86/cpu/mcheck/mce.c
@@ -63,7 +63,7 @@ struct mca_banks *mca_allbanks;
 #endif
 
 int mce_verbosity;
-static int __init mce_set_verbosity(const char *str)
+static int __init cf_check mce_set_verbosity(const char *str)
 {
     if ( strcmp("verbose", str) == 0 )
         mce_verbosity = MCE_VERBOSE;
diff --git a/xen/arch/x86/cpu/microcode/core.c b/xen/arch/x86/cpu/microcode/core.c
index ac3ceb567c41..95d35ca0f3f7 100644
--- a/xen/arch/x86/cpu/microcode/core.c
+++ b/xen/arch/x86/cpu/microcode/core.c
@@ -111,7 +111,7 @@ void __init microcode_set_module(unsigned int idx)
  * optional. If the EFI has forced which of the multiboot payloads is to be
  * used, only nmi=<bool> is parsed.
  */
-static int __init parse_ucode(const char *s)
+static int __init cf_check parse_ucode(const char *s)
 {
     const char *ss;
     int val, rc = 0;
diff --git a/xen/arch/x86/cpu/vpmu.c b/xen/arch/x86/cpu/vpmu.c
index 598291f4ece9..b10d6e2eb458 100644
--- a/xen/arch/x86/cpu/vpmu.c
+++ b/xen/arch/x86/cpu/vpmu.c
@@ -56,7 +56,7 @@ static unsigned vpmu_count;
 
 static DEFINE_PER_CPU(struct vcpu *, last_vcpu);
 
-static int __init parse_vpmu_params(const char *s)
+static int __init cf_check parse_vpmu_params(const char *s)
 {
     const char *ss;
     int rc = 0, val;
diff --git a/xen/arch/x86/cpuid.c b/xen/arch/x86/cpuid.c
index 7c638eff2bf4..bb554b06a73f 100644
--- a/xen/arch/x86/cpuid.c
+++ b/xen/arch/x86/cpuid.c
@@ -101,7 +101,7 @@ static int __init always_inline parse_cpuid(
     return rc;
 }
 
-static void __init _parse_xen_cpuid(unsigned int feat, bool val)
+static void __init cf_check _parse_xen_cpuid(unsigned int feat, bool val)
 {
     if ( !val )
         setup_clear_cpu_cap(feat);
@@ -110,7 +110,7 @@ static void __init _parse_xen_cpuid(unsigned int feat, bool val)
         setup_force_cpu_cap(X86_FEATURE_RDRAND);
 }
 
-static int __init parse_xen_cpuid(const char *s)
+static int __init cf_check parse_xen_cpuid(const char *s)
 {
     return parse_cpuid(s, _parse_xen_cpuid);
 }
@@ -120,13 +120,13 @@ static bool __initdata dom0_cpuid_cmdline;
 static uint32_t __initdata dom0_enable_feat[FSCAPINTS];
 static uint32_t __initdata dom0_disable_feat[FSCAPINTS];
 
-static void __init _parse_dom0_cpuid(unsigned int feat, bool val)
+static void __init cf_check _parse_dom0_cpuid(unsigned int feat, bool val)
 {
     __set_bit  (feat, val ? dom0_enable_feat  : dom0_disable_feat);
     __clear_bit(feat, val ? dom0_disable_feat : dom0_enable_feat );
 }
 
-static int __init parse_dom0_cpuid(const char *s)
+static int __init cf_check parse_dom0_cpuid(const char *s)
 {
     dom0_cpuid_cmdline = true;
 
diff --git a/xen/arch/x86/dom0_build.c b/xen/arch/x86/dom0_build.c
index a7fec05956c1..4d1c5c60e407 100644
--- a/xen/arch/x86/dom0_build.c
+++ b/xen/arch/x86/dom0_build.c
@@ -115,7 +115,7 @@ static int __init parse_amt(const char *s, const char **ps, struct memsize *sz)
     return 0;
 }
 
-static int __init parse_dom0_mem(const char *s)
+static int __init cf_check parse_dom0_mem(const char *s)
 {
     int ret;
 
@@ -144,7 +144,7 @@ custom_param("dom0_mem", parse_dom0_mem);
 static unsigned int __initdata opt_dom0_max_vcpus_min = 1;
 static unsigned int __initdata opt_dom0_max_vcpus_max = UINT_MAX;
 
-static int __init parse_dom0_max_vcpus(const char *s)
+static int __init cf_check parse_dom0_max_vcpus(const char *s)
 {
     if ( *s == '-' )                   /* -M */
         opt_dom0_max_vcpus_max = simple_strtoul(s + 1, &s, 0);
@@ -168,7 +168,7 @@ static __initdata unsigned int dom0_pxms[MAX_NUMNODES] =
     { [0 ... MAX_NUMNODES - 1] = ~0 };
 bool __initdata dom0_affinity_relaxed;
 
-static int __init parse_dom0_nodes(const char *s)
+static int __init cf_check parse_dom0_nodes(const char *s)
 {
     const char *ss;
     int rc = 0;
@@ -266,7 +266,7 @@ bool __initdata opt_dom0_pvh = !IS_ENABLED(CONFIG_PV);
 bool __initdata opt_dom0_verbose = IS_ENABLED(CONFIG_VERBOSE_DEBUG);
 bool __initdata opt_dom0_msr_relaxed;
 
-static int __init parse_dom0_param(const char *s)
+static int __init cf_check parse_dom0_param(const char *s)
 {
     const char *ss;
     int rc = 0;
diff --git a/xen/arch/x86/genapic/probe.c b/xen/arch/x86/genapic/probe.c
index 66bc5ce072dc..ad57912f506b 100644
--- a/xen/arch/x86/genapic/probe.c
+++ b/xen/arch/x86/genapic/probe.c
@@ -43,7 +43,7 @@ void __init generic_bigsmp_probe(void)
 		}
 }
 
-static int __init genapic_apic_force(const char *str)
+static int __init cf_check genapic_apic_force(const char *str)
 {
 	int i, rc = -EINVAL;
 
diff --git a/xen/arch/x86/hpet.c b/xen/arch/x86/hpet.c
index 2fe8b005a513..7a810e4e7171 100644
--- a/xen/arch/x86/hpet.c
+++ b/xen/arch/x86/hpet.c
@@ -65,7 +65,7 @@ u8 __initdata hpet_flags;
 static bool __initdata force_hpet_broadcast;
 boolean_param("hpetbroadcast", force_hpet_broadcast);
 
-static int __init parse_hpet_param(const char *s)
+static int __init cf_check parse_hpet_param(const char *s)
 {
     const char *ss;
     int val, rc = 0;
diff --git a/xen/arch/x86/hvm/viridian/viridian.c b/xen/arch/x86/hvm/viridian/viridian.c
index 8986b8e03c2e..7ebcaa1c899f 100644
--- a/xen/arch/x86/hvm/viridian/viridian.c
+++ b/xen/arch/x86/hvm/viridian/viridian.c
@@ -1186,7 +1186,7 @@ static int viridian_load_vcpu_ctxt(struct domain *d,
 HVM_REGISTER_SAVE_RESTORE(VIRIDIAN_VCPU, viridian_save_vcpu_ctxt,
                           viridian_load_vcpu_ctxt, 1, HVMSR_PER_VCPU);
 
-static int __init parse_viridian_version(const char *arg)
+static int __init cf_check parse_viridian_version(const char *arg)
 {
     const char *t;
     unsigned int n[3];
diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c
index 7ab15e07a0b2..f72a7db0453d 100644
--- a/xen/arch/x86/hvm/vmx/vmcs.c
+++ b/xen/arch/x86/hvm/vmx/vmcs.c
@@ -71,7 +71,7 @@ static bool __read_mostly opt_ept_pml = true;
 static s8 __read_mostly opt_ept_ad = -1;
 int8_t __read_mostly opt_ept_exec_sp = -1;
 
-static int __init parse_ept_param(const char *s)
+static int __init cf_check parse_ept_param(const char *s)
 {
     const char *ss;
     int val, rc = 0;
@@ -107,16 +107,16 @@ static void update_ept_param(void)
                  opt_ept_exec_sp);
 }
 
-static void __init init_ept_param(struct param_hypfs *par)
+static void __init cf_check init_ept_param(struct param_hypfs *par)
 {
     update_ept_param();
     custom_runtime_set_var(par, opt_ept_setting);
 }
 
-static int parse_ept_param_runtime(const char *s);
+static int cf_check parse_ept_param_runtime(const char *s);
 custom_runtime_only_param("ept", parse_ept_param_runtime, init_ept_param);
 
-static int parse_ept_param_runtime(const char *s)
+static int cf_check parse_ept_param_runtime(const char *s)
 {
     struct domain *d;
     int val;
diff --git a/xen/arch/x86/io_apic.c b/xen/arch/x86/io_apic.c
index 1c49a0fe1478..4135a9c06052 100644
--- a/xen/arch/x86/io_apic.c
+++ b/xen/arch/x86/io_apic.c
@@ -1601,7 +1601,7 @@ static unsigned int startup_level_ioapic_irq(struct irq_desc *desc)
     return 0; /* don't check for pending */
 }
 
-static int __init setup_ioapic_ack(const char *s)
+static int __init cf_check setup_ioapic_ack(const char *s)
 {
     if ( !strcmp(s, "old") )
     {
diff --git a/xen/arch/x86/irq.c b/xen/arch/x86/irq.c
index 67cbf6b979dc..84b174d0f51f 100644
--- a/xen/arch/x86/irq.c
+++ b/xen/arch/x86/irq.c
@@ -28,8 +28,6 @@
 #include <irq_vectors.h>
 #include <public/physdev.h>
 
-static int parse_irq_vector_map_param(const char *s);
-
 /* opt_noirqbalance: If true, software IRQ balancing/affinity is disabled. */
 bool __read_mostly opt_noirqbalance;
 boolean_param("noirqbalance", opt_noirqbalance);
@@ -40,7 +38,6 @@ integer_param("nr_irqs", nr_irqs);
 
 /* This default may be changed by the AMD IOMMU code */
 int __read_mostly opt_irq_vector_map = OPT_IRQ_VECTOR_MAP_DEFAULT;
-custom_param("irq_vector_map", parse_irq_vector_map_param);
 
 /* Max number of guests IRQ could be shared with */
 static unsigned char __read_mostly irq_max_guests;
@@ -66,7 +63,7 @@ static struct timer irq_ratelimit_timer;
 static unsigned int __read_mostly irq_ratelimit_threshold = 10000;
 integer_param("irq_ratelimit", irq_ratelimit_threshold);
 
-static int __init parse_irq_vector_map_param(const char *s)
+static int __init cf_check parse_irq_vector_map_param(const char *s)
 {
     const char *ss;
     int rc = 0;
@@ -90,6 +87,7 @@ static int __init parse_irq_vector_map_param(const char *s)
 
     return rc;
 }
+custom_param("irq_vector_map", parse_irq_vector_map_param);
 
 /* Must be called when irq disabled */
 void lock_vector_lock(void)
diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c
index cdbd04e19752..a1b8737096c4 100644
--- a/xen/arch/x86/mm.c
+++ b/xen/arch/x86/mm.c
@@ -189,7 +189,7 @@ static uint32_t base_disallow_mask;
 
 static s8 __read_mostly opt_mmio_relax;
 
-static int __init parse_mmio_relax(const char *s)
+static int __init cf_check parse_mmio_relax(const char *s)
 {
     if ( !*s )
         opt_mmio_relax = 1;
diff --git a/xen/arch/x86/nmi.c b/xen/arch/x86/nmi.c
index c515de63365a..515a3633e5aa 100644
--- a/xen/arch/x86/nmi.c
+++ b/xen/arch/x86/nmi.c
@@ -48,7 +48,7 @@ bool __initdata opt_watchdog;
 /* watchdog_force: If true, process unknown NMIs when running the watchdog. */
 bool watchdog_force;
 
-static int __init parse_watchdog(const char *s)
+static int __init cf_check parse_watchdog(const char *s)
 {
     if ( !*s )
     {
@@ -78,7 +78,7 @@ custom_param("watchdog", parse_watchdog);
 /* opt_watchdog_timeout: Number of seconds to wait before panic. */
 static unsigned int opt_watchdog_timeout = 5;
 
-static int parse_watchdog_timeout(const char *s)
+static int __init cf_check parse_watchdog_timeout(const char *s)
 {
     const char *q;
 
diff --git a/xen/arch/x86/numa.c b/xen/arch/x86/numa.c
index ce79ee44cefe..6be5a0c93322 100644
--- a/xen/arch/x86/numa.c
+++ b/xen/arch/x86/numa.c
@@ -19,9 +19,6 @@
 #include <xen/sched.h>
 #include <xen/softirq.h>
 
-static int numa_setup(const char *s);
-custom_param("numa", numa_setup);
-
 #ifndef Dprintk
 #define Dprintk(x...)
 #endif
@@ -294,7 +291,7 @@ void numa_set_node(int cpu, nodeid_t node)
 }
 
 /* [numa=off] */
-static __init int numa_setup(const char *opt)
+static int __init cf_check numa_setup(const char *opt)
 {
     if ( !strncmp(opt,"off",3) )
         numa_off = true;
@@ -321,6 +318,7 @@ static __init int numa_setup(const char *opt)
 
     return 0;
 } 
+custom_param("numa", numa_setup);
 
 /*
  * Setup early cpu_to_node.
diff --git a/xen/arch/x86/oprofile/nmi_int.c b/xen/arch/x86/oprofile/nmi_int.c
index a13bd82915ac..7842d95b95ea 100644
--- a/xen/arch/x86/oprofile/nmi_int.c
+++ b/xen/arch/x86/oprofile/nmi_int.c
@@ -340,7 +340,7 @@ static int __init p4_init(char ** cpu_type)
 
 static int force_arch_perfmon;
 
-static int force_cpu_type(const char *str)
+static int __init cf_check force_cpu_type(const char *str)
 {
 	if (!strcmp(str, "arch_perfmon")) {
 		force_arch_perfmon = 1;
diff --git a/xen/arch/x86/psr.c b/xen/arch/x86/psr.c
index d805b85dc60b..56916344cb1d 100644
--- a/xen/arch/x86/psr.c
+++ b/xen/arch/x86/psr.c
@@ -573,7 +573,7 @@ static bool __init parse_psr_bool(const char *s, const char *delim,
     return false;
 }
 
-static int __init parse_psr_param(const char *s)
+static int __init cf_check parse_psr_param(const char *s)
 {
     const char *ss, *val_delim;
     const char *q;
diff --git a/xen/arch/x86/pv/domain.c b/xen/arch/x86/pv/domain.c
index 6ad533183bcd..125c4561a7ea 100644
--- a/xen/arch/x86/pv/domain.c
+++ b/xen/arch/x86/pv/domain.c
@@ -20,7 +20,7 @@
 int8_t __read_mostly opt_pv32 = -1;
 #endif
 
-static __init int parse_pv(const char *s)
+static int __init cf_check parse_pv(const char *s)
 {
     const char *ss;
     int val, rc = 0;
@@ -63,16 +63,16 @@ static const char opt_pcid_2_string[][7] = {
     [PCID_NOXPTI] = "noxpti",
 };
 
-static void __init opt_pcid_init(struct param_hypfs *par)
+static void __init cf_check opt_pcid_init(struct param_hypfs *par)
 {
     custom_runtime_set_var(par, opt_pcid_2_string[opt_pcid]);
 }
 #endif
 
-static int parse_pcid(const char *s);
+static int cf_check parse_pcid(const char *s);
 custom_runtime_param("pcid", parse_pcid, opt_pcid_init);
 
-static int parse_pcid(const char *s)
+static int cf_check parse_pcid(const char *s)
 {
     int rc = 0;
 
diff --git a/xen/arch/x86/pv/shim.c b/xen/arch/x86/pv/shim.c
index 4c710ad8913f..ae4d8913faa1 100644
--- a/xen/arch/x86/pv/shim.c
+++ b/xen/arch/x86/pv/shim.c
@@ -73,7 +73,7 @@ static uint64_t __initdata shim_nrpages;
 static uint64_t __initdata shim_min_nrpages;
 static uint64_t __initdata shim_max_nrpages;
 
-static int __init parse_shim_mem(const char *s)
+static int __init cf_check parse_shim_mem(const char *s)
 {
     do {
         if ( !strncmp(s, "min:", 4) )
diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c
index 2f6e10d0cf77..3a4ec1fcfd04 100644
--- a/xen/arch/x86/setup.c
+++ b/xen/arch/x86/setup.c
@@ -81,8 +81,6 @@ unsigned long __read_mostly cr4_pv32_mask;
 /* "acpi=ht":     Limit ACPI just to boot-time to enable HT.        */
 /* "acpi=noirq":  Disables ACPI interrupt routing.                  */
 /* "acpi=verbose": Enables more verbose ACPI boot time logging.     */
-static int parse_acpi_param(const char *s);
-custom_param("acpi", parse_acpi_param);
 
 /* **** Linux config option: propagated to domain0. */
 /* noapic: Disable IOAPIC setup. */
@@ -104,7 +102,7 @@ static bool __initdata opt_xen_shstk = true;
 #define opt_xen_shstk false
 #endif
 
-static int __init parse_cet(const char *s)
+static int __init cf_check parse_cet(const char *s)
 {
     const char *ss;
     int val, rc = 0;
@@ -159,7 +157,7 @@ static s8 __initdata opt_smep = -1;
  */
 static struct domain *__initdata dom0;
 
-static int __init parse_smep_param(const char *s)
+static int __init cf_check parse_smep_param(const char *s)
 {
     if ( !*s )
     {
@@ -190,7 +188,7 @@ custom_param("smep", parse_smep_param);
 #define SMAP_HVM_ONLY (-2)
 static s8 __initdata opt_smap = -1;
 
-static int __init parse_smap_param(const char *s)
+static int __init cf_check parse_smap_param(const char *s)
 {
     if ( !*s )
     {
@@ -221,7 +219,7 @@ bool __read_mostly acpi_disabled;
 bool __initdata acpi_force;
 static char __initdata acpi_param[10] = "";
 
-static int __init parse_acpi_param(const char *s)
+static int __init cf_check parse_acpi_param(const char *s)
 {
     /* Interpret the parameter for use within Xen. */
     if ( !parse_bool(s, NULL) )
@@ -257,6 +255,7 @@ static int __init parse_acpi_param(const char *s)
 
     return 0;
 }
+custom_param("acpi", parse_acpi_param);
 
 static const module_t *__initdata initial_images;
 static unsigned int __initdata nr_initial_images;
diff --git a/xen/arch/x86/shutdown.c b/xen/arch/x86/shutdown.c
index acef03314372..a01354d93319 100644
--- a/xen/arch/x86/shutdown.c
+++ b/xen/arch/x86/shutdown.c
@@ -56,7 +56,7 @@ static int reboot_mode;
  */
 static enum reboot_type reboot_type = BOOT_INVALID;
 
-static int __init set_reboot_type(const char *str)
+static int __init cf_check set_reboot_type(const char *str)
 {
     int rc = 0;
 
diff --git a/xen/arch/x86/spec_ctrl.c b/xen/arch/x86/spec_ctrl.c
index db27bc3f6451..2d4cf5c7ef80 100644
--- a/xen/arch/x86/spec_ctrl.c
+++ b/xen/arch/x86/spec_ctrl.c
@@ -68,7 +68,7 @@ static bool __initdata cpu_has_bug_mds; /* Any other M{LP,SB,FB}DS combination.
 
 static int8_t __initdata opt_srb_lock = -1;
 
-static int __init parse_spec_ctrl(const char *s)
+static int __init cf_check parse_spec_ctrl(const char *s)
 {
     const char *ss;
     int val, rc = 0;
@@ -218,7 +218,7 @@ static __init void xpti_init_default(uint64_t caps)
     }
 }
 
-static __init int parse_xpti(const char *s)
+static int __init cf_check parse_xpti(const char *s)
 {
     const char *ss;
     int val, rc = 0;
@@ -264,7 +264,7 @@ custom_param("xpti", parse_xpti);
 int8_t __read_mostly opt_pv_l1tf_hwdom = -1;
 int8_t __read_mostly opt_pv_l1tf_domu = -1;
 
-static __init int parse_pv_l1tf(const char *s)
+static int __init cf_check parse_pv_l1tf(const char *s)
 {
     const char *ss;
     int val, rc = 0;
diff --git a/xen/arch/x86/time.c b/xen/arch/x86/time.c
index bc41a3aa37b2..818a42a406c5 100644
--- a/xen/arch/x86/time.c
+++ b/xen/arch/x86/time.c
@@ -2354,7 +2354,7 @@ int hwdom_pit_access(struct ioreq *ioreq)
  * tsc=skewed: Assume TSCs are individually reliable, but skewed across CPUs.
  * tsc=stable:socket: Assume TSCs are reliable across sockets.
  */
-static int __init tsc_parse(const char *s)
+static int __init cf_check tsc_parse(const char *s)
 {
     if ( !strcmp(s, "unstable") )
     {
diff --git a/xen/arch/x86/tsx.c b/xen/arch/x86/tsx.c
index be89741a2f6d..b156844cdec1 100644
--- a/xen/arch/x86/tsx.c
+++ b/xen/arch/x86/tsx.c
@@ -22,7 +22,7 @@ int8_t __read_mostly opt_tsx = -1;
 int8_t __read_mostly cpu_has_tsx_ctrl = -1;
 bool __read_mostly rtm_disabled;
 
-static int __init parse_tsx(const char *s)
+static int __init cf_check parse_tsx(const char *s)
 {
     int rc = 0, val = parse_bool(s, NULL);
 
diff --git a/xen/arch/x86/x86_64/mmconfig-shared.c b/xen/arch/x86/x86_64/mmconfig-shared.c
index 7c3ed64b4c6c..2fa7f3f0bc4b 100644
--- a/xen/arch/x86/x86_64/mmconfig-shared.c
+++ b/xen/arch/x86/x86_64/mmconfig-shared.c
@@ -29,7 +29,7 @@
 
 unsigned int pci_probe = PCI_PROBE_CONF1 | PCI_PROBE_MMCONF;
 
-static int __init parse_mmcfg(const char *s)
+static int __init cf_check parse_mmcfg(const char *s)
 {
     const char *ss;
     int rc = 0;
diff --git a/xen/common/argo.c b/xen/common/argo.c
index 1448faf65731..297f6d11f04d 100644
--- a/xen/common/argo.c
+++ b/xen/common/argo.c
@@ -78,7 +78,7 @@ DEFINE_COMPAT_HANDLE(compat_argo_iov_t);
 static bool __read_mostly opt_argo;
 static bool __read_mostly opt_argo_mac_permissive;
 
-static int __init parse_argo(const char *s)
+static int __init cf_check parse_argo(const char *s)
 {
     const char *ss;
     int val, rc = 0;
diff --git a/xen/common/core_parking.c b/xen/common/core_parking.c
index 411106c675c9..aa432ed2f57b 100644
--- a/xen/common/core_parking.c
+++ b/xen/common/core_parking.c
@@ -40,7 +40,7 @@ static enum core_parking_controller {
     PERFORMANCE_FIRST
 } core_parking_controller __initdata = POWER_FIRST;
 
-static int __init setup_core_parking_option(const char *str)
+static int __init cf_check setup_core_parking_option(const char *str)
 {
     if ( !strcmp(str, "power") )
         core_parking_controller = POWER_FIRST;
diff --git a/xen/common/debugtrace.c b/xen/common/debugtrace.c
index f3794b945376..29b11239f5a5 100644
--- a/xen/common/debugtrace.c
+++ b/xen/common/debugtrace.c
@@ -38,7 +38,7 @@ static bool debugtrace_buf_empty = true;
 static bool debugtrace_used;
 static DEFINE_SPINLOCK(debugtrace_lock);
 
-static int __init debugtrace_parse_param(const char *s)
+static int __init cf_check debugtrace_parse_param(const char *s)
 {
     unsigned long bytes;
 
diff --git a/xen/common/domain.c b/xen/common/domain.c
index ac2746d0d69a..dacd03254cb2 100644
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -354,7 +354,7 @@ static int late_hwdom_init(struct domain *d)
 static unsigned int __read_mostly extra_hwdom_irqs;
 static unsigned int __read_mostly extra_domU_irqs = 32;
 
-static int __init parse_extra_guest_irqs(const char *s)
+static int __init cf_check parse_extra_guest_irqs(const char *s)
 {
     if ( isdigit(*s) )
         extra_domU_irqs = simple_strtoul(s, &s, 0);
diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c
index 12fd0844bd55..f31f68fd4cd1 100644
--- a/xen/common/efi/boot.c
+++ b/xen/common/efi/boot.c
@@ -1417,7 +1417,7 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable)
 
 static bool __initdata efi_map_uc;
 
-static int __init parse_efi_param(const char *s)
+static int __init cf_check parse_efi_param(const char *s)
 {
     const char *ss;
     int rc = 0, val;
diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c
index 153332b7bfbe..b663845d9c6c 100644
--- a/xen/common/grant_table.c
+++ b/xen/common/grant_table.c
@@ -117,12 +117,12 @@ static void update_gnttab_par(unsigned int val, struct param_hypfs *par,
     custom_runtime_set_var_sz(par, parval, GRANT_CUSTOM_VAL_SZ);
 }
 
-static void __init gnttab_max_frames_init(struct param_hypfs *par)
+static void __init cf_check gnttab_max_frames_init(struct param_hypfs *par)
 {
     update_gnttab_par(opt_max_grant_frames, par, opt_max_grant_frames_val);
 }
 
-static void __init max_maptrack_frames_init(struct param_hypfs *par)
+static void __init cf_check max_maptrack_frames_init(struct param_hypfs *par)
 {
     update_gnttab_par(opt_max_maptrack_frames, par,
                       opt_max_maptrack_frames_val);
@@ -156,23 +156,23 @@ static int parse_gnttab_limit(const char *arg, unsigned int *valp,
     return 0;
 }
 
-static int parse_gnttab_max_frames(const char *arg);
+static int cf_check parse_gnttab_max_frames(const char *arg);
 custom_runtime_param("gnttab_max_frames", parse_gnttab_max_frames,
                      gnttab_max_frames_init);
 
-static int parse_gnttab_max_frames(const char *arg)
+static int cf_check parse_gnttab_max_frames(const char *arg)
 {
     return parse_gnttab_limit(arg, &opt_max_grant_frames,
                               param_2_parfs(parse_gnttab_max_frames),
                               opt_max_grant_frames_val);
 }
 
-static int parse_gnttab_max_maptrack_frames(const char *arg);
+static int cf_check parse_gnttab_max_maptrack_frames(const char *arg);
 custom_runtime_param("gnttab_max_maptrack_frames",
                      parse_gnttab_max_maptrack_frames,
                      max_maptrack_frames_init);
 
-static int parse_gnttab_max_maptrack_frames(const char *arg)
+static int cf_check parse_gnttab_max_maptrack_frames(const char *arg)
 {
     return parse_gnttab_limit(arg, &opt_max_maptrack_frames,
                               param_2_parfs(parse_gnttab_max_maptrack_frames),
@@ -191,7 +191,7 @@ static bool __ro_after_init opt_grant_transfer = true;
 #define opt_grant_transfer false
 #endif
 
-static int __init parse_gnttab(const char *s)
+static int __init cf_check parse_gnttab(const char *s)
 {
     const char *ss, *e;
     int val, rc = 0;
diff --git a/xen/common/kexec.c b/xen/common/kexec.c
index 8471590aeea2..6286c0bbf08b 100644
--- a/xen/common/kexec.c
+++ b/xen/common/kexec.c
@@ -104,7 +104,7 @@ static void *crash_heap_current = NULL, *crash_heap_end = NULL;
  * < and below are synonyomous, the latter being useful for grub2 systems
  * which would otherwise require escaping of the < option
  */
-static int __init parse_crashkernel(const char *str)
+static int __init cf_check parse_crashkernel(const char *str)
 {
     const char *cur;
     int rc = 0;
@@ -201,7 +201,7 @@ custom_param("crashkernel", parse_crashkernel);
  * - all will allocate additional structures such as domain and vcpu structs
  *       low so the crash kernel can perform an extended analysis of state.
  */
-static int __init parse_low_crashinfo(const char *str)
+static int __init cf_check parse_low_crashinfo(const char *str)
 {
 
     if ( !strlen(str) )
@@ -230,7 +230,7 @@ custom_param("low_crashinfo", parse_low_crashinfo);
  *
  * <addr> will be rounded down to the nearest power of two.  Defaults to 64G
  */
-static int __init parse_crashinfo_maxaddr(const char *str)
+static int __init cf_check parse_crashinfo_maxaddr(const char *str)
 {
     u64 addr;
     const char *q;
diff --git a/xen/common/memory.c b/xen/common/memory.c
index 38732dde6fd7..ede45c4af9db 100644
--- a/xen/common/memory.c
+++ b/xen/common/memory.c
@@ -62,7 +62,7 @@ static unsigned int __read_mostly hwdom_max_order = CONFIG_HWDOM_MAX_ORDER;
 static unsigned int __read_mostly ptdom_max_order = CONFIG_PTDOM_MAX_ORDER;
 #endif
 
-static int __init parse_max_order(const char *s)
+static int __init cf_check parse_max_order(const char *s)
 {
     if ( *s != ',' )
         domu_max_order = simple_strtoul(s, &s, 0);
diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c
index f8749b0787a6..ad06655158d2 100644
--- a/xen/common/page_alloc.c
+++ b/xen/common/page_alloc.c
@@ -179,7 +179,7 @@ enum bootscrub_mode {
  * https://bugs.llvm.org/show_bug.cgi?id=39707
  */
 static enum bootscrub_mode __read_mostly opt_bootscrub = BOOTSCRUB_IDLE;
-static int __init parse_bootscrub_param(const char *s)
+static int __init cf_check parse_bootscrub_param(const char *s)
 {
     /* Interpret 'bootscrub' alone in its positive boolean form */
     if ( *s == '\0' )
diff --git a/xen/common/sched/cpupool.c b/xen/common/sched/cpupool.c
index 8c6e6eb9ccd5..f0dd626054a6 100644
--- a/xen/common/sched/cpupool.c
+++ b/xen/common/sched/cpupool.c
@@ -93,7 +93,7 @@ static int sched_gran_get(const char *str, enum sched_gran *mode)
     return -EINVAL;
 }
 
-static int __init sched_select_granularity(const char *str)
+static int __init cf_check sched_select_granularity(const char *str)
 {
     return sched_gran_get(str, &opt_sched_granularity);
 }
diff --git a/xen/common/sched/credit2.c b/xen/common/sched/credit2.c
index 6396b38e044c..a5f073cda51e 100644
--- a/xen/common/sched/credit2.c
+++ b/xen/common/sched/credit2.c
@@ -456,7 +456,7 @@ static const char *const opt_runqueue_str[] = {
 };
 static int __read_mostly opt_runqueue = OPT_RUNQUEUE_SOCKET;
 
-static int __init parse_credit2_runqueue(const char *s)
+static int __init cf_check parse_credit2_runqueue(const char *s)
 {
     unsigned int i;
 
diff --git a/xen/drivers/acpi/tables.c b/xen/drivers/acpi/tables.c
index f39cd5eaac89..96ff96b84c66 100644
--- a/xen/drivers/acpi/tables.c
+++ b/xen/drivers/acpi/tables.c
@@ -472,7 +472,7 @@ int __init acpi_table_init(void)
 	return 0;
 }
 
-static int __init acpi_parse_apic_instance(const char *str)
+static int __init cf_check acpi_parse_apic_instance(const char *str)
 {
 	const char *q;
 
diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c
index a043e9521afd..4694be83db45 100644
--- a/xen/drivers/char/console.c
+++ b/xen/drivers/char/console.c
@@ -88,7 +88,7 @@ static const char con_timestamp_mode_2_string[][7] = {
     [TSM_RAW] = "raw",
 };
 
-static void con_timestamp_mode_upd(struct param_hypfs *par)
+static void cf_check con_timestamp_mode_upd(struct param_hypfs *par)
 {
     const char *val = con_timestamp_mode_2_string[opt_con_timestamp_mode];
 
@@ -98,7 +98,7 @@ static void con_timestamp_mode_upd(struct param_hypfs *par)
 #define con_timestamp_mode_upd(par)
 #endif
 
-static int parse_console_timestamps(const char *s);
+static int cf_check parse_console_timestamps(const char *s);
 custom_runtime_param("console_timestamps", parse_console_timestamps,
                      con_timestamp_mode_upd);
 
@@ -160,8 +160,8 @@ static int __read_mostly xenlog_guest_upper_thresh =
 static int __read_mostly xenlog_guest_lower_thresh =
     XENLOG_GUEST_LOWER_THRESHOLD;
 
-static int parse_loglvl(const char *s);
-static int parse_guest_loglvl(const char *s);
+static int cf_check parse_loglvl(const char *s);
+static int cf_check parse_guest_loglvl(const char *s);
 
 #ifdef CONFIG_HYPFS
 #define LOGLVL_VAL_SZ 16
@@ -176,13 +176,13 @@ static void xenlog_update_val(int lower, int upper, char *val)
     snprintf(val, LOGLVL_VAL_SZ, "%s/%s", lvl2opt[lower], lvl2opt[upper]);
 }
 
-static void __init xenlog_init(struct param_hypfs *par)
+static void __init cf_check xenlog_init(struct param_hypfs *par)
 {
     xenlog_update_val(xenlog_lower_thresh, xenlog_upper_thresh, xenlog_val);
     custom_runtime_set_var(par, xenlog_val);
 }
 
-static void __init xenlog_guest_init(struct param_hypfs *par)
+static void __init cf_check xenlog_guest_init(struct param_hypfs *par)
 {
     xenlog_update_val(xenlog_guest_lower_thresh, xenlog_guest_upper_thresh,
                       xenlog_guest_val);
@@ -240,7 +240,7 @@ static int _parse_loglvl(const char *s, int *lower, int *upper, char *val)
     return *s ? -EINVAL : 0;
 }
 
-static int parse_loglvl(const char *s)
+static int cf_check parse_loglvl(const char *s)
 {
     int ret;
 
@@ -251,7 +251,7 @@ static int parse_loglvl(const char *s)
     return ret;
 }
 
-static int parse_guest_loglvl(const char *s)
+static int cf_check parse_guest_loglvl(const char *s)
 {
     int ret;
 
@@ -793,7 +793,7 @@ static int printk_prefix_check(char *p, char **pp)
             ((loglvl < upper_thresh) && printk_ratelimit()));
 } 
 
-static int parse_console_timestamps(const char *s)
+static int cf_check parse_console_timestamps(const char *s)
 {
     switch ( parse_bool(s, NULL) )
     {
diff --git a/xen/drivers/cpufreq/cpufreq.c b/xen/drivers/cpufreq/cpufreq.c
index 419aae83eea6..36b079296235 100644
--- a/xen/drivers/cpufreq/cpufreq.c
+++ b/xen/drivers/cpufreq/cpufreq.c
@@ -65,7 +65,7 @@ enum cpufreq_controller cpufreq_controller = FREQCTL_xen;
 
 static int __init cpufreq_cmdline_parse(const char *s);
 
-static int __init setup_cpufreq_option(const char *str)
+static int __init cf_check setup_cpufreq_option(const char *str)
 {
     const char *arg = strpbrk(str, ",:");
     int choice;
diff --git a/xen/drivers/passthrough/amd/iommu_acpi.c b/xen/drivers/passthrough/amd/iommu_acpi.c
index b07fa4c40124..5ea227732821 100644
--- a/xen/drivers/passthrough/amd/iommu_acpi.c
+++ b/xen/drivers/passthrough/amd/iommu_acpi.c
@@ -704,7 +704,7 @@ static u16 __init parse_ivhd_device_extended_range(
     return dev_length;
 }
 
-static int __init parse_ivrs_ioapic(const char *str)
+static int __init cf_check parse_ivrs_ioapic(const char *str)
 {
     const char *s = str;
     unsigned long id;
@@ -742,7 +742,7 @@ static int __init parse_ivrs_ioapic(const char *str)
 }
 custom_param("ivrs_ioapic[", parse_ivrs_ioapic);
 
-static int __init parse_ivrs_hpet(const char *str)
+static int __init cf_check parse_ivrs_hpet(const char *str)
 {
     const char *s = str;
     unsigned long id;
@@ -1369,7 +1369,7 @@ int __init amd_iommu_get_supported_ivhd_type(void)
  * Format:
  * ivmd=<start>[-<end>][=<bdf1>[-<bdf1>'][,<bdf2>[-<bdf2>'][,...]]][;<start>...]
  */
-static int __init parse_ivmd_param(const char *s)
+static int __init cf_check parse_ivmd_param(const char *s)
 {
     do {
         unsigned long start, end;
diff --git a/xen/drivers/passthrough/iommu.c b/xen/drivers/passthrough/iommu.c
index fc18f63bd4ac..6ee267d2bfd4 100644
--- a/xen/drivers/passthrough/iommu.c
+++ b/xen/drivers/passthrough/iommu.c
@@ -64,7 +64,7 @@ bool_t __read_mostly amd_iommu_perdev_intremap = 1;
 
 DEFINE_PER_CPU(bool_t, iommu_dont_flush_iotlb);
 
-static int __init parse_iommu_param(const char *s)
+static int __init cf_check parse_iommu_param(const char *s)
 {
     const char *ss;
     int val, rc = 0;
@@ -135,7 +135,7 @@ static int __init parse_iommu_param(const char *s)
 }
 custom_param("iommu", parse_iommu_param);
 
-static int __init parse_dom0_iommu_param(const char *s)
+static int __init cf_check parse_dom0_iommu_param(const char *s)
 {
     const char *ss;
     int rc = 0;
diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
index 70b6684981c1..4b59b332f01f 100644
--- a/xen/drivers/passthrough/pci.c
+++ b/xen/drivers/passthrough/pci.c
@@ -146,7 +146,7 @@ static struct phantom_dev {
 } phantom_devs[8];
 static unsigned int nr_phantom_devs;
 
-static int __init parse_phantom_dev(const char *str)
+static int __init cf_check parse_phantom_dev(const char *str)
 {
     const char *s;
     unsigned int seg, bus, slot;
@@ -182,7 +182,7 @@ custom_param("pci-phantom", parse_phantom_dev);
 static u16 __read_mostly command_mask;
 static u16 __read_mostly bridge_ctl_mask;
 
-static int __init parse_pci_param(const char *s)
+static int __init cf_check parse_pci_param(const char *s)
 {
     const char *ss;
     int rc = 0;
diff --git a/xen/drivers/passthrough/vtd/dmar.c b/xen/drivers/passthrough/vtd/dmar.c
index 33a12b2ae976..b152f3da916b 100644
--- a/xen/drivers/passthrough/vtd/dmar.c
+++ b/xen/drivers/passthrough/vtd/dmar.c
@@ -1084,7 +1084,7 @@ int intel_iommu_get_reserved_device_memory(iommu_grdm_t *func, void *ctxt)
  * If a segment is specified for other than the first device, and it does not
  * match the one specified for the first one, an error will be reported.
  */
-static int __init parse_rmrr_param(const char *str)
+static int __init cf_check parse_rmrr_param(const char *str)
 {
     const char *s = str, *cur, *stmp;
     unsigned int seg, bus, dev, func, dev_count;
diff --git a/xen/drivers/passthrough/vtd/quirks.c b/xen/drivers/passthrough/vtd/quirks.c
index 52b47dd89325..0590ddeea7c4 100644
--- a/xen/drivers/passthrough/vtd/quirks.c
+++ b/xen/drivers/passthrough/vtd/quirks.c
@@ -308,7 +308,7 @@ void vtd_ops_postamble_quirk(struct vtd_iommu *iommu)
     }
 }
 
-static int __init parse_snb_timeout(const char *s)
+static int __init cf_check parse_snb_timeout(const char *s)
 {
     int t;
     const char *q = NULL;
diff --git a/xen/drivers/video/vesa.c b/xen/drivers/video/vesa.c
index 0342a3dedef0..c8f81a5cc5fc 100644
--- a/xen/drivers/video/vesa.c
+++ b/xen/drivers/video/vesa.c
@@ -29,7 +29,7 @@ integer_param("vesa-ram", vram_total);
 static unsigned int __initdata vram_remap;
 
 static unsigned int __initdata font_height;
-static int __init parse_font_height(const char *s)
+static int __init cf_check parse_font_height(const char *s)
 {
     if ( simple_strtoul(s, &s, 10) == 8 && (*s++ == 'x') )
         font_height = simple_strtoul(s, &s, 10);
diff --git a/xen/xsm/flask/flask_op.c b/xen/xsm/flask/flask_op.c
index bb3bebc30e01..2d7ca3abaecd 100644
--- a/xen/xsm/flask/flask_op.c
+++ b/xen/xsm/flask/flask_op.c
@@ -28,8 +28,6 @@
 #define _copy_from_guest copy_from_guest
 
 enum flask_bootparam_t __read_mostly flask_bootparam = FLASK_BOOTPARAM_ENFORCING;
-static int parse_flask_param(const char *s);
-custom_param("flask", parse_flask_param);
 
 bool __read_mostly flask_enforcing = true;
 
@@ -60,7 +58,7 @@ static int flask_security_make_bools(void);
 
 extern int ss_initialized;
 
-static int __init parse_flask_param(const char *s)
+static int __init cf_check parse_flask_param(const char *s)
 {
     if ( !strcmp(s, "enforcing") )
         flask_bootparam = FLASK_BOOTPARAM_ENFORCING;
@@ -75,6 +73,7 @@ static int __init parse_flask_param(const char *s)
 
     return (flask_bootparam == FLASK_BOOTPARAM_INVALID) ? -EINVAL : 0;
 }
+custom_param("flask", parse_flask_param);
 
 static int domain_has_security(struct domain *d, u32 perms)
 {
diff --git a/xen/xsm/xsm_core.c b/xen/xsm/xsm_core.c
index 5fc3a5f75478..2286a502e3e8 100644
--- a/xen/xsm/xsm_core.c
+++ b/xen/xsm/xsm_core.c
@@ -55,7 +55,7 @@ static enum xsm_bootparam __initdata xsm_bootparam =
     XSM_BOOTPARAM_DUMMY;
 #endif
 
-static int __init parse_xsm_param(const char *s)
+static int __init cf_check parse_xsm_param(const char *s)
 {
     int rc = 0;
 
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Tue Feb 22 15:30:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 15:30:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276914.473282 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMX7B-0004h7-DH; Tue, 22 Feb 2022 15:30:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276914.473282; Tue, 22 Feb 2022 15:30:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMX7B-0004h0-9t; Tue, 22 Feb 2022 15:30:09 +0000
Received: by outflank-mailman (input) for mailman id 276914;
 Tue, 22 Feb 2022 15:30:08 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=QzH2=TF=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nMX7A-0004gG-6q
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 15:30:08 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4f71da97-93f4-11ec-8eb8-a37418f5ba1a;
 Tue, 22 Feb 2022 16:30:05 +0100 (CET)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2050.outbound.protection.outlook.com [104.47.12.50]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-8-LdaQXLoiOVWhOHH88-alOw-1; Tue, 22 Feb 2022 16:30:03 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DB6PR04MB3237.eurprd04.prod.outlook.com (2603:10a6:6:c::33) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4995.27; Tue, 22 Feb 2022 15:30:00 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.4995.027; Tue, 22 Feb 2022
 15:30:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4f71da97-93f4-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645543805;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=9vcLcvHzkFV74O9UMXo3EGKnBtcR8W1+5sVbvWIVopk=;
	b=dZwt/CwUTFTESoAxKbm49EkGIHnz6qnIpONQ/cQ8kRAyDgN/jm1pzwiGstM6vcdV2y9lue
	ufF7E77iAaTHaw0P1nYAnoXNnVMHiOsXQ0bPc9xoHXINqgcJR+r3vSZS7l3B3SlPAUwSFF
	UdMVC7x1VWsVVHAariKL0OsovV7ws3U=
X-MC-Unique: LdaQXLoiOVWhOHH88-alOw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=C1d+KMh6HPcgwBuvwo+vAkckNmadagSbryStDmTISZ26MNqjfuyx6rFOtAeXIntcbjVsjc2bhSzCs7Q2JMVEXqNe+2VsdLQT3gE+Wv1/j6JA9zoDptflzj4gtDgGd3FhUT4eA3n07xuOINoXAuFR26boCxg//cne5xK9zqz1LDhBwWLoy+AC0HJfRLNFX/rE/wPZJuqWOOaShZqhgsRrVqkGZunThzr0wIui/mYi/kf9WtWDv7x8/gmwdRi+gTOKySTrhOTJkfwaeyUZ8J7lPCrXG2amGZIQuUOjncjmAbq+BA+jNRLYqyBKjKP1BhL9ZvGsEzhJOPzQ5s8e0y5oAA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=iS40/mvBXdWx80/i6q6CRvVbya1cY82Toy/CaYHieVs=;
 b=L8THG2k1OBRTSjuuiqIiPfnHJrymVTuU6ZpfqtVGUSWiNhjTEImiT6qxrutvjTJ6QABMOA8P9g/4AG0j87Vwei4SbnBaDfFvhqMIBlJ7MI9Js3VBj4OtJUbVdfX9eUVH0bx8ulsBjONO4BwnG6ddMPkhS4XKvkxs5Exmufd++0Q+7kTtlBX3oYV14QnuXwuGVzAnJtsKvernZuXy6hAhb1pncohBoV132Z6PkJbSwy41a8Yzav2cPnE0SN3qmUJaNa+EOik9M6p0lvhMEGyEoeGib9mImSplP+CzVwHdcQ7O/CQ1WFU63mllzcbIaAEvrJLzzzNvrOSLGl+J6Ul2BQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <a1106b26-ffa8-2b8e-5063-c2e1059b46fe@suse.com>
Date: Tue, 22 Feb 2022 16:29:59 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v3 00/70 (not all posted)] x86: Support for CET Indirect
 Branch Tracking
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Julien Grall <julien@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Juergen Gross <jgross@suse.com>,
 =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20220222152645.8844-1-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220222152645.8844-1-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: FR3P281CA0016.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:1d::21) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 75793c93-63ad-4c5a-6283-08d9f6183088
X-MS-TrafficTypeDiagnostic: DB6PR04MB3237:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<DB6PR04MB3237C4BC42DEB12932D575F2B33B9@DB6PR04MB3237.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	xOmcyrj3wbaUgV5tEY3E84c/B07DI6C4n4pItQ0LxGVFvYC6VQ6jVtcDpZ4AoZHuzKSaDYhDS6SVbieXUKKailtRuOrJs75NE45GgDeUv3Qs21hMrIjd2UBX0LjLv+vmwTMIn/+Fo++KBMJHwjk7LZ6jmooKvMwFvhikQor+tdYyR9/3lwIHIzC+HBVEY8RGhSVTG9EKll+9zleAV1VIOYlSo8sxZhXPjOx2YFz77Lka0/UKyWQZW3Yndakh0RIMrrbipG3eh0ndN3E+jae6gI8IwuZ5TU4eZFyVpwYMQmhirmabC8CX2Qd27NiYxfUJK8bbKfX+l4987Jgn4Cwao9Rch+oX4320C8DaN2oZXnngo6UGFW1nztkeYIQTS7Fz7Azzwwa/Cq9f0OCArTT60mDM6PELYhIGrc9J/Flam5Omq5reoQxhOLwosNyRe+s1fxWkGwelZdcOf0CJvPSrsOAf+xLrmuBFC3CX67dyWeB8R2JxV1oPwx+AZvG1jOLkpywMnj1JyjaitQxBTt8U4C9bSiKko998zv+73gb8INMZgDsXBnSgqN9q61Zak6tyObgd8DSUSPwgT5BZLgBV6nGhzzkoRSA3Od3GfUUKd2NKBrzX0F9sM39LDwosA8k7Z5+ghpRPCCDOgbiMxW+BvumEa4RbFmXygdnXIM7Kj0YbRrSVpCKPwg7I0/uWl35wHVb/HWjnnaYCAWwNUga7pS411d2ue+8GoFY8dOq1SRLJWI5wMt59wDT1ozHleWjgjoZVW6ihv8z8esvae3dqOkj3J9jg4BBC6eWxX366K6RT8avlVMyrLVBCOU4PASP5k79JpDY8aThHwqaBXqGEHw==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8936002)(6512007)(66574015)(508600001)(966005)(6486002)(31696002)(54906003)(2906002)(6916009)(30864003)(316002)(5660300002)(2616005)(83380400001)(86362001)(8676002)(31686004)(53546011)(38100700002)(6506007)(186003)(26005)(4326008)(66476007)(36756003)(66556008)(66946007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?NwHDJKpyjzFbiH4L+Yl1G1mhVXAuX5uuQIvFvYBdXsrb+7NgWklimQjrGR7K?=
 =?us-ascii?Q?LQ8vCG+V7Bx7/CAdFKK77TvsF433S95xOBziavxRXGcKEkYSBfHPEr9nM/2L?=
 =?us-ascii?Q?uKSktNj5u1cdojvSIPQEtiZVzFtvcXaj7iPZFzBQHfd9NFaA4QBKT+w3jC4+?=
 =?us-ascii?Q?Ztm2rBu4KEsmNpD7Al0lUjzl+KsulzWxYdfl3T26OdvF4nAh3qOIv86B1LUf?=
 =?us-ascii?Q?gW5o3by0BBP0ijYgPxGQB2XHvP9utpzNKwC39Af05Zj+/cgrv80V1DbsTvG4?=
 =?us-ascii?Q?mAM3JpHSk9Gl9pMjkMQ+AydxZgCeeI4/oCbQGxyBd+mMl35yjSxgh+KOHoy3?=
 =?us-ascii?Q?mUqhwAm1lLGM+f+QK3OQYRLNyK/6kp6Rah+stzUXcfICWAwIrIy3xMdFkkas?=
 =?us-ascii?Q?P7xmEDY7R0G/mFCDA9T0WFxOKtF7NTVmZHZ3qvFDpHwP7gR62dqZQ+DcUZpX?=
 =?us-ascii?Q?q1lgZMQe5DN6lL0XQ2tIdkXkhy/tP7j92qlbXJeT+gTwlTATEqAqh4EJDBxm?=
 =?us-ascii?Q?FQ4L6ZEoB605pO/mSdKcvkN0vQLsqvtLmDrNBW3xkeMfV7EAiq/x6VitwKrv?=
 =?us-ascii?Q?7XzdxqdEen8aAPjviDBpks5mDvtvMoHER3H/RKN3EPRDm6btUxmnEr9FbnvP?=
 =?us-ascii?Q?J6/qwsIHSU6QwssibQS6SDfXP5+FudVyET7jvwD2AlpsZ78+Vhv1avyb6Sl6?=
 =?us-ascii?Q?JFS9qGD7f20elXRWhp97qNU2cRIYxNlCk79Oo0b8tr4rU/G6V4pwOW3QLrSy?=
 =?us-ascii?Q?t7D31FbYp9sUX6c3nus5Jml2I4OCOqqVSrVk0/6AwmaRx0DXpEVcoBPbWqMo?=
 =?us-ascii?Q?tobgxwGfaVSPIF+i+5GXH1eSVk7qbTrmdVy+qtHRTIBm4FOgOmSD4BNQBGpc?=
 =?us-ascii?Q?C+kV/ShLlnybRfKmmqMN69VuVyCZAIMQDI6PeJZlmROqW7QDDpdbi5CdkJ6h?=
 =?us-ascii?Q?H+/onx0ugmMH3QGApT5HjfYubSpuSek74LvCTTEVrHTF0W5GfhAOHcNtWj/n?=
 =?us-ascii?Q?ANwRX0KhzyPfJ8VYgErgalvtMcu1+DkghGzCfpq9GQetvZj2sFUoD3SAnp/a?=
 =?us-ascii?Q?WEoUapzMtr2IT74L6B7ver+HzweHyxAlw88m+Kk8+Uy+jHLgx69RPlSSDErt?=
 =?us-ascii?Q?j9aQIl5SlebCJwd79MLVgv8jJfrO9ZpE754rUjVgXi960oLJ9Y4ZF+35Tt7y?=
 =?us-ascii?Q?WDIWtBKRbxxrDqUV5/DGGNfYJbMcRA3n8p4SVolimLCGr8mATroVAn1moVNe?=
 =?us-ascii?Q?Bqj5k8S2ZqKz8fHlJzFu1sSur0CyXuJAD5zEVboLglY0AkXUssCYzPZNkCwo?=
 =?us-ascii?Q?wzS72RRkjfgt2/6GPlPmMssdPFBIT+sa+J/s2fLT5cVJc2s0ajUXFTRMz01n?=
 =?us-ascii?Q?dVBOJbPOg8jE/5+n6FbIlrM9sBBHs2wcoLERGjHUKstd/Qs0ypipURpf1UkZ?=
 =?us-ascii?Q?oIyEsZ5xmSR4FUuRxrSagy2VIp0GzbJuuheiDV2/L9n8GodNm2NigsRJ6Efq?=
 =?us-ascii?Q?bqbM5Nfc9pYotzIX3xhNZvyrw0qr+ohW4cGXYOTvFfo4OkXFOidiT++Tr0Cb?=
 =?us-ascii?Q?LnWsB0g+LHoL2vqv5AMb4KdJC2Jm0JulkhhyxdTtTqx/tnPY92v+qKal2uaq?=
 =?us-ascii?Q?UJx7WeC+CV2ZZHElaIfhc5Y=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 75793c93-63ad-4c5a-6283-08d9f6183088
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2022 15:30:00.4934
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VkIWUqpHEUW6UqyYWOPeHHTU9w7+u9ZENnMpSaLBVHtLPnHXFjnNVsrhEg4Ryy0sM/OIulwglkbJEDpJ+Di+Uw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR04MB3237

On 22.02.2022 16:26, Andrew Cooper wrote:
> To avoid spamming everyone, I have only re-sent patches with changes in v=
3.

Could you enumerate which ones these are? Otherwise it's hard to tell
whether everything you did send did arrive in the recipients' mailboxes.

Thanks, Jan

> CET Indirect Branch Tracking is a hardware feature designed to protect ag=
ainst
> forward-edge control flow hijacking (Call/Jump oriented programming), and=
 is a
> companion feature to CET Shadow Stacks added in Xen 4.14.
>=20
> Patches 1 thru 5 are prerequisites.  Patches 6 thru 59 are fairly mechani=
cal
> annotations of function pointer targets.  Patches 60 thru 70 are the fina=
l
> enablement of CET-IBT.
>=20
> This series functions correctly with GCC 9 and later, although an experim=
ental
> GCC patch is required to get more helpful typechecking at build time.  A
> container with this fix has been added to CI.
>=20
> Tested on a TigerLake NUC by me, and by Marek also.
>=20
> CI pipelines:
>   https://gitlab.com/xen-project/people/andyhhp/xen/-/pipelines/476819536
>   https://cirrus-ci.com/build/4634902334275584
>=20
> Andrew Cooper (67):
>   xen/sort: Switch to an extern inline implementation
>   xen/xsm: Move {do,compat}_flask_op() declarations into a header
>   x86/kexec: Annotate embedded data with ELF metadata
>   x86: Introduce support for CET-IBT
>   xen: CFI hardening for x86 hypercalls
>   xen: CFI hardening for custom_param()
>   xen: CFI hardening for __initcall()
>   xen: CFI hardening for notifier callbacks
>   xen: CFI hardening for acpi_table_parse()
>   xen: CFI hardening for continue_hypercall_on_cpu()
>   xen: CFI hardening for init_timer()
>   xen: CFI hardening for call_rcu()
>   xen: CFI hardening for IPIs
>   xen: CFI hardening for open_softirq()
>   xsm/flask/ss: CFI hardening
>   xsm: CFI hardening
>   xen/sched: CFI hardening
>   xen/evtchn: CFI hardening
>   xen/hypfs: CFI hardening
>   xen/tasklet: CFI hardening
>   xen/keyhandler: CFI hardening
>   xen/vpci: CFI hardening
>   xen/decompress: CFI hardening
>   xen/iommu: CFI hardening
>   xen/video: CFI hardening
>   xen/console: CFI hardening
>   xen/misc: CFI hardening
>   x86: CFI hardening for request_irq()
>   x86/hvm: CFI hardening for hvm_funcs
>   x86/hvm: CFI hardening for device emulation
>   x86/emul: CFI hardening
>   x86/ucode: CFI hardening
>   x86/power: CFI hardening
>   x86/apic: CFI hardening
>   x86/nmi: CFI hardening
>   x86/mtrr: CFI hardening
>   x86/idle: CFI hardening
>   x86/quirks: CFI hardening
>   x86/hvmsave: CFI hardening
>   x86/mce: CFI hardening
>   x86/pmu: CFI hardening
>   x86/cpu: CFI hardening
>   x86/guest: CFI hardening
>   x86/logdirty: CFI hardening
>   x86/shadow: CFI hardening
>   x86/hap: CFI hardening
>   x86/p2m: CFI hardening
>   x86/irq: CFI hardening
>   x86/apei: CFI hardening
>   x86/psr: CFI hardening
>   x86/dpci: CFI hardening
>   x86/pt: CFI hardening
>   x86/time: CFI hardening
>   x86/misc: CFI hardening
>   x86/stack: CFI hardening
>   x86/bugframe: CFI hardening
>   x86: Use control flow typechecking where possible
>   x86/setup: Read CR4 earlier in __start_xen()
>   x86/alternatives: Clear CR4.CET when clearing CR0.WP
>   x86/traps: Rework write_stub_trampoline() to not hardcode the jmp
>   x86: Introduce helpers/checks for endbr64 instructions
>   x86/emul: Update emulation stubs to be CET-IBT compatible
>   x86/entry: Make syscall/sysenter entrypoints CET-IBT compatible
>   x86/entry: Make IDT entrypoints CET-IBT compatible
>   x86/setup: Rework MSR_S_CET handling for CET-IBT
>   x86/efi: Disable CET-IBT around Runtime Services calls
>   x86: Enable CET Indirect Branch Tracking
>=20
> Juergen Gross (2):
>   x86/pv-shim: Don't modify the hypercall table
>   x86: Don't use the hypercall table for calling compat hypercalls
>=20
> Marek Marczykowski-G=C3=B3recki (1):
>   x86: Build check for embedded endbr64 instructions
>=20
>  Config.mk                                         |   1 -
>  README                                            |   1 +
>  automation/build/debian/buster-gcc-ibt.dockerfile |  66 ++++
>  automation/gitlab-ci/build.yaml                   |   6 +
>  automation/scripts/containerize                   |   1 +
>  docs/misc/xen-command-line.pandoc                 |  16 +-
>  tools/firmware/Makefile                           |   2 +
>  tools/libs/guest/xg_dom_decompress_unsafe.h       |   2 +
>  tools/tests/x86_emulator/x86-emulate.h            |   2 +
>  xen/arch/arm/bootfdt.c                            |   9 +-
>  xen/arch/arm/io.c                                 |   9 +-
>  xen/arch/x86/Kconfig                              |  17 +
>  xen/arch/x86/Makefile                             |   6 +
>  xen/arch/x86/acpi/boot.c                          |  24 +-
>  xen/arch/x86/acpi/cpu_idle.c                      |  43 ++-
>  xen/arch/x86/acpi/cpufreq/cpufreq.c               |  24 +-
>  xen/arch/x86/acpi/cpufreq/powernow.c              |  21 +-
>  xen/arch/x86/acpi/cpuidle_menu.c                  |   6 +-
>  xen/arch/x86/acpi/lib.c                           |   2 +-
>  xen/arch/x86/acpi/power.c                         |   4 +-
>  xen/arch/x86/acpi/wakeup_prot.S                   |  38 +-
>  xen/arch/x86/alternative.c                        |  13 +-
>  xen/arch/x86/apic.c                               |  12 +-
>  xen/arch/x86/arch.mk                              |   7 +
>  xen/arch/x86/boot/x86_64.S                        |  30 +-
>  xen/arch/x86/compat.c                             |  21 +-
>  xen/arch/x86/configs/pvshim_defconfig             |   1 +
>  xen/arch/x86/cpu/amd.c                            |   8 +-
>  xen/arch/x86/cpu/centaur.c                        |   2 +-
>  xen/arch/x86/cpu/common.c                         |   3 +-
>  xen/arch/x86/cpu/cpu.h                            |   2 +-
>  xen/arch/x86/cpu/hygon.c                          |   2 +-
>  xen/arch/x86/cpu/intel.c                          |   6 +-
>  xen/arch/x86/cpu/mcheck/amd_nonfatal.c            |   4 +-
>  xen/arch/x86/cpu/mcheck/mce.c                     |  22 +-
>  xen/arch/x86/cpu/mcheck/mce.h                     |   2 +-
>  xen/arch/x86/cpu/mcheck/mce_amd.c                 |   9 +-
>  xen/arch/x86/cpu/mcheck/mce_amd.h                 |   4 +-
>  xen/arch/x86/cpu/mcheck/mce_intel.c               |  49 ++-
>  xen/arch/x86/cpu/mcheck/non-fatal.c               |   6 +-
>  xen/arch/x86/cpu/mcheck/vmce.c                    |   4 +-
>  xen/arch/x86/cpu/microcode/amd.c                  |   9 +-
>  xen/arch/x86/cpu/microcode/core.c                 |  15 +-
>  xen/arch/x86/cpu/microcode/intel.c                |  10 +-
>  xen/arch/x86/cpu/mtrr/generic.c                   |  20 +-
>  xen/arch/x86/cpu/mtrr/main.c                      |   4 +-
>  xen/arch/x86/cpu/mtrr/mtrr.h                      |   8 +-
>  xen/arch/x86/cpu/mwait-idle.c                     |  12 +-
>  xen/arch/x86/cpu/shanghai.c                       |   2 +-
>  xen/arch/x86/cpu/vpmu.c                           |  13 +-
>  xen/arch/x86/cpu/vpmu_amd.c                       |  16 +-
>  xen/arch/x86/cpu/vpmu_intel.c                     |  16 +-
>  xen/arch/x86/cpuid.c                              |   8 +-
>  xen/arch/x86/crash.c                              |   7 +-
>  xen/arch/x86/dmi_scan.c                           |  10 +-
>  xen/arch/x86/dom0_build.c                         |   8 +-
>  xen/arch/x86/domain.c                             |  16 +-
>  xen/arch/x86/emul-i8254.c                         |  14 +-
>  xen/arch/x86/extable.c                            |  18 +-
>  xen/arch/x86/genapic/bigsmp.c                     |   4 +-
>  xen/arch/x86/genapic/delivery.c                   |  12 +-
>  xen/arch/x86/genapic/probe.c                      |   2 +-
>  xen/arch/x86/genapic/x2apic.c                     |  18 +-
>  xen/arch/x86/guest/hyperv/hyperv.c                |  10 +-
>  xen/arch/x86/guest/xen/xen.c                      |  15 +-
>  xen/arch/x86/hpet.c                               |  29 +-
>  xen/arch/x86/hvm/dm.c                             |   5 +-
>  xen/arch/x86/hvm/dom0_build.c                     |  16 +-
>  xen/arch/x86/hvm/emulate.c                        |  93 +++--
>  xen/arch/x86/hvm/hpet.c                           |  12 +-
>  xen/arch/x86/hvm/hvm.c                            |  47 +--
>  xen/arch/x86/hvm/hypercall.c                      |   5 +-
>  xen/arch/x86/hvm/intercept.c                      |  28 +-
>  xen/arch/x86/hvm/io.c                             |  38 +-
>  xen/arch/x86/hvm/ioreq.c                          |   2 +-
>  xen/arch/x86/hvm/irq.c                            |  16 +-
>  xen/arch/x86/hvm/mtrr.c                           |   8 +-
>  xen/arch/x86/hvm/nestedhvm.c                      |   6 +-
>  xen/arch/x86/hvm/pmtimer.c                        |  10 +-
>  xen/arch/x86/hvm/quirks.c                         |   4 +-
>  xen/arch/x86/hvm/rtc.c                            |  18 +-
>  xen/arch/x86/hvm/stdvga.c                         |  19 +-
>  xen/arch/x86/hvm/svm/nestedsvm.c                  |  22 +-
>  xen/arch/x86/hvm/svm/svm.c                        | 404 +++++++++++-----=
------
>  xen/arch/x86/hvm/svm/vmcb.c                       |   2 +-
>  xen/arch/x86/hvm/vioapic.c                        |  12 +-
>  xen/arch/x86/hvm/viridian/time.c                  |   2 +-
>  xen/arch/x86/hvm/viridian/viridian.c              |  17 +-
>  xen/arch/x86/hvm/vlapic.c                         |  25 +-
>  xen/arch/x86/hvm/vmsi.c                           |  16 +-
>  xen/arch/x86/hvm/vmx/intr.c                       |   2 +-
>  xen/arch/x86/hvm/vmx/vmcs.c                       |  22 +-
>  xen/arch/x86/hvm/vmx/vmx.c                        | 155 +++++----
>  xen/arch/x86/hvm/vmx/vvmx.c                       |  16 +-
>  xen/arch/x86/hvm/vpic.c                           |   8 +-
>  xen/arch/x86/hvm/vpt.c                            |   2 +-
>  xen/arch/x86/i8259.c                              |  10 +-
>  xen/arch/x86/include/asm/asm-defns.h              |   6 +
>  xen/arch/x86/include/asm/bug.h                    |  10 +-
>  xen/arch/x86/include/asm/cpufeature.h             |   1 +
>  xen/arch/x86/include/asm/cpufeatures.h            |   1 +
>  xen/arch/x86/include/asm/cpuidle.h                |   4 +-
>  xen/arch/x86/include/asm/current.h                |   6 +-
>  xen/arch/x86/include/asm/endbr.h                  |  55 +++
>  xen/arch/x86/include/asm/flushtlb.h               |   2 +-
>  xen/arch/x86/include/asm/genapic.h                |  18 +-
>  xen/arch/x86/include/asm/hpet.h                   |   8 +-
>  xen/arch/x86/include/asm/hvm/emulate.h            |   8 +-
>  xen/arch/x86/include/asm/hvm/save.h               |   2 +-
>  xen/arch/x86/include/asm/hvm/svm/nestedsvm.h      |  18 +-
>  xen/arch/x86/include/asm/hvm/svm/svm.h            |   1 -
>  xen/arch/x86/include/asm/hvm/vioapic.h            |   2 +-
>  xen/arch/x86/include/asm/hvm/vmx/vmcs.h           |   8 +-
>  xen/arch/x86/include/asm/hvm/vmx/vmx.h            |   4 +-
>  xen/arch/x86/include/asm/hvm/vmx/vvmx.h           |  18 +-
>  xen/arch/x86/include/asm/hypercall.h              |  81 +++--
>  xen/arch/x86/include/asm/irq.h                    |  24 +-
>  xen/arch/x86/include/asm/machine_kexec.h          |   2 +-
>  xen/arch/x86/include/asm/mm.h                     |  16 +-
>  xen/arch/x86/include/asm/msi.h                    |   8 +-
>  xen/arch/x86/include/asm/msr-index.h              |   1 +
>  xen/arch/x86/include/asm/mtrr.h                   |   2 +-
>  xen/arch/x86/include/asm/p2m.h                    |   4 +-
>  xen/arch/x86/include/asm/paging.h                 |   2 +-
>  xen/arch/x86/include/asm/processor.h              |   4 +-
>  xen/arch/x86/include/asm/pv/domain.h              |   4 +-
>  xen/arch/x86/include/asm/pv/shim.h                |  11 +-
>  xen/arch/x86/include/asm/shadow.h                 |   2 +-
>  xen/arch/x86/include/asm/smp.h                    |   6 +-
>  xen/arch/x86/include/asm/tboot.h                  |   2 +-
>  xen/arch/x86/include/asm/time.h                   |   6 +-
>  xen/arch/x86/io_apic.c                            |  28 +-
>  xen/arch/x86/ioport_emulate.c                     |   4 +-
>  xen/arch/x86/irq.c                                |  28 +-
>  xen/arch/x86/livepatch.c                          |   2 +-
>  xen/arch/x86/machine_kexec.c                      |   2 +-
>  xen/arch/x86/mm.c                                 |  35 +-
>  xen/arch/x86/mm/hap/guest_walk.c                  |   4 +-
>  xen/arch/x86/mm/hap/hap.c                         |  29 +-
>  xen/arch/x86/mm/hap/nested_hap.c                  |   2 +-
>  xen/arch/x86/mm/hap/private.h                     |  30 +-
>  xen/arch/x86/mm/mem_sharing.c                     |   2 +-
>  xen/arch/x86/mm/p2m-ept.c                         |  34 +-
>  xen/arch/x86/mm/p2m-pt.c                          |  19 +-
>  xen/arch/x86/mm/paging.c                          |   3 +-
>  xen/arch/x86/mm/shadow/common.c                   |  33 +-
>  xen/arch/x86/mm/shadow/hvm.c                      |  16 +-
>  xen/arch/x86/mm/shadow/multi.c                    |  80 +++--
>  xen/arch/x86/mm/shadow/multi.h                    |  20 +-
>  xen/arch/x86/mm/shadow/none.c                     |  20 +-
>  xen/arch/x86/mm/shadow/private.h                  |  12 +-
>  xen/arch/x86/mm/shadow/pv.c                       |   4 +-
>  xen/arch/x86/msi.c                                |  18 +-
>  xen/arch/x86/nmi.c                                |  16 +-
>  xen/arch/x86/numa.c                               |  10 +-
>  xen/arch/x86/oprofile/nmi_int.c                   |  16 +-
>  xen/arch/x86/oprofile/op_model_athlon.c           |  18 +-
>  xen/arch/x86/oprofile/op_model_p4.c               |  14 +-
>  xen/arch/x86/oprofile/op_model_ppro.c             |  26 +-
>  xen/arch/x86/percpu.c                             |   6 +-
>  xen/arch/x86/physdev.c                            |   2 +-
>  xen/arch/x86/platform_hypercall.c                 |  11 +-
>  xen/arch/x86/psr.c                                |  41 +--
>  xen/arch/x86/pv/callback.c                        |  25 +-
>  xen/arch/x86/pv/descriptor-tables.c               |  14 +-
>  xen/arch/x86/pv/domain.c                          |  12 +-
>  xen/arch/x86/pv/emul-gate-op.c                    |   9 +-
>  xen/arch/x86/pv/emul-priv-op.c                    |  71 ++--
>  xen/arch/x86/pv/emulate.h                         |   7 -
>  xen/arch/x86/pv/hypercall.c                       |  11 +-
>  xen/arch/x86/pv/iret.c                            |   4 +-
>  xen/arch/x86/pv/misc-hypercalls.c                 |  10 +-
>  xen/arch/x86/pv/ro-page-fault.c                   |  31 +-
>  xen/arch/x86/pv/shim.c                            |  60 ++--
>  xen/arch/x86/pv/traps.c                           |   2 +-
>  xen/arch/x86/setup.c                              |  80 ++++-
>  xen/arch/x86/shutdown.c                           |  10 +-
>  xen/arch/x86/smp.c                                |  20 +-
>  xen/arch/x86/smpboot.c                            |   2 +-
>  xen/arch/x86/spec_ctrl.c                          |   6 +-
>  xen/arch/x86/srat.c                               |   4 +-
>  xen/arch/x86/sysctl.c                             |   4 +-
>  xen/arch/x86/tboot.c                              |   2 +-
>  xen/arch/x86/time.c                               |  68 ++--
>  xen/arch/x86/traps.c                              |   8 +-
>  xen/arch/x86/tsx.c                                |   2 +-
>  xen/arch/x86/x86_64/acpi_mmcfg.c                  |   2 +-
>  xen/arch/x86/x86_64/compat.c                      |   1 -
>  xen/arch/x86/x86_64/compat/entry.S                |   1 +
>  xen/arch/x86/x86_64/compat/mm.c                   |   7 +-
>  xen/arch/x86/x86_64/entry.S                       |  49 ++-
>  xen/arch/x86/x86_64/kexec_reloc.S                 |  23 +-
>  xen/arch/x86/x86_64/mmconfig-shared.c             |  10 +-
>  xen/arch/x86/x86_64/mmconfig.h                    |   2 +-
>  xen/arch/x86/x86_64/platform_hypercall.c          |   2 +-
>  xen/arch/x86/x86_64/traps.c                       |  42 ++-
>  xen/arch/x86/x86_emulate.c                        |  34 +-
>  xen/arch/x86/x86_emulate/x86_emulate.c            |  10 +-
>  xen/arch/x86/x86_emulate/x86_emulate.h            |  33 +-
>  xen/arch/x86/xen.lds.S                            |   3 +-
>  xen/common/argo.c                                 |   6 +-
>  xen/common/bunzip2.c                              |   2 +-
>  xen/common/compat/domain.c                        |   3 +-
>  xen/common/compat/grant_table.c                   |   5 +-
>  xen/common/compat/kernel.c                        |   2 +-
>  xen/common/compat/memory.c                        |   7 +-
>  xen/common/compat/multicall.c                     |   3 +-
>  xen/common/core_parking.c                         |  10 +-
>  xen/common/coverage/gcov.c                        |   8 +-
>  xen/common/cpu.c                                  |   4 +-
>  xen/common/debugtrace.c                           |  10 +-
>  xen/common/decompress.c                           |   2 +-
>  xen/common/dm.c                                   |   6 +-
>  xen/common/domain.c                               |  15 +-
>  xen/common/domctl.c                               |   2 +-
>  xen/common/efi/boot.c                             |   6 +-
>  xen/common/efi/runtime.c                          |  18 +
>  xen/common/event_2l.c                             |  21 +-
>  xen/common/event_channel.c                        |  18 +-
>  xen/common/event_fifo.c                           |  30 +-
>  xen/common/gdbstub.c                              |   9 +-
>  xen/common/grant_table.c                          |  29 +-
>  xen/common/hypfs.c                                |  63 ++--
>  xen/common/irq.c                                  |   6 +-
>  xen/common/kernel.c                               |   6 +-
>  xen/common/kexec.c                                |  18 +-
>  xen/common/keyhandler.c                           |  47 +--
>  xen/common/livepatch.c                            |  15 +-
>  xen/common/memory.c                               |   8 +-
>  xen/common/multicall.c                            |   2 +-
>  xen/common/page_alloc.c                           |  14 +-
>  xen/common/perfc.c                                |   4 +-
>  xen/common/radix-tree.c                           |   8 +-
>  xen/common/random.c                               |   2 +-
>  xen/common/rangeset.c                             |   2 +-
>  xen/common/rcupdate.c                             |   8 +-
>  xen/common/sched/arinc653.c                       |  20 +-
>  xen/common/sched/compat.c                         |   2 +-
>  xen/common/sched/core.c                           |  40 +--
>  xen/common/sched/cpupool.c                        |  35 +-
>  xen/common/sched/credit.c                         |  59 ++--
>  xen/common/sched/credit2.c                        |  55 ++-
>  xen/common/sched/null.c                           |  60 ++--
>  xen/common/sched/rt.c                             |  47 +--
>  xen/common/spinlock.c                             |  12 +-
>  xen/common/stop_machine.c                         |   6 +-
>  xen/common/sysctl.c                               |   2 +-
>  xen/common/tasklet.c                              |   4 +-
>  xen/common/timer.c                                |   6 +-
>  xen/common/trace.c                                |   4 +-
>  xen/common/unlzma.c                               |   2 +-
>  xen/common/vm_event.c                             |   6 +-
>  xen/common/xenoprof.c                             |   2 +-
>  xen/common/xmalloc_tlsf.c                         |   4 +-
>  xen/common/zstd/zstd_common.c                     |   4 +-
>  xen/common/zstd/zstd_internal.h                   |   4 +-
>  xen/drivers/acpi/apei/apei-base.c                 |  32 +-
>  xen/drivers/acpi/apei/apei-internal.h             |  20 +-
>  xen/drivers/acpi/apei/erst.c                      |  57 ++-
>  xen/drivers/acpi/apei/hest.c                      |   4 +-
>  xen/drivers/acpi/numa.c                           |  10 +-
>  xen/drivers/acpi/tables.c                         |   2 +-
>  xen/drivers/char/console.c                        |  36 +-
>  xen/drivers/char/ehci-dbgp.c                      |  28 +-
>  xen/drivers/char/ns16550.c                        |  34 +-
>  xen/drivers/cpufreq/cpufreq.c                     |   6 +-
>  xen/drivers/cpufreq/cpufreq_misc_governors.c      |  22 +-
>  xen/drivers/cpufreq/cpufreq_ondemand.c            |  10 +-
>  xen/drivers/passthrough/amd/iommu.h               |  45 +--
>  xen/drivers/passthrough/amd/iommu_acpi.c          |  15 +-
>  xen/drivers/passthrough/amd/iommu_guest.c         |  12 +-
>  xen/drivers/passthrough/amd/iommu_init.c          |  49 +--
>  xen/drivers/passthrough/amd/iommu_intr.c          |  20 +-
>  xen/drivers/passthrough/amd/iommu_map.c           |  22 +-
>  xen/drivers/passthrough/amd/pci_amd_iommu.c       |  32 +-
>  xen/drivers/passthrough/iommu.c                   |  56 ++-
>  xen/drivers/passthrough/pci.c                     |  18 +-
>  xen/drivers/passthrough/vtd/dmar.c                |   7 +-
>  xen/drivers/passthrough/vtd/extern.h              |  38 +-
>  xen/drivers/passthrough/vtd/intremap.c            |  14 +-
>  xen/drivers/passthrough/vtd/iommu.c               |  94 ++---
>  xen/drivers/passthrough/vtd/qinval.c              |  28 +-
>  xen/drivers/passthrough/vtd/quirks.c              |   2 +-
>  xen/drivers/passthrough/vtd/utils.c               |   2 +-
>  xen/drivers/passthrough/vtd/x86/hvm.c             |   4 +-
>  xen/drivers/passthrough/x86/hvm.c                 |  14 +-
>  xen/drivers/video/lfb.c                           |   4 +-
>  xen/drivers/video/lfb.h                           |   4 +-
>  xen/drivers/video/vesa.c                          |   6 +-
>  xen/drivers/video/vga.c                           |   6 +-
>  xen/drivers/vpci/header.c                         |  18 +-
>  xen/drivers/vpci/msi.c                            |  42 +--
>  xen/drivers/vpci/msix.c                           |  20 +-
>  xen/drivers/vpci/vpci.c                           |  16 +-
>  xen/include/acpi/cpufreq/cpufreq.h                |   1 -
>  xen/include/xen/acpi.h                            |   2 +-
>  xen/include/xen/compiler.h                        |   6 +
>  xen/include/xen/domain.h                          |   2 +-
>  xen/include/xen/hypercall.h                       |  69 ++--
>  xen/include/xen/hypfs.h                           |  49 ++-
>  xen/include/xen/irq.h                             |   6 +-
>  xen/include/xen/lib.h                             |   2 +-
>  xen/include/xen/perfc.h                           |   4 +-
>  xen/include/xen/sched.h                           |   2 +-
>  xen/include/xen/sort.h                            |  55 ++-
>  xen/include/xen/spinlock.h                        |   4 +-
>  xen/include/xen/vpci.h                            |   8 +-
>  xen/include/xsm/dummy.h                           | 211 +++++------
>  xen/lib/sort.c                                    |  80 +----
>  xen/tools/check-endbr.sh                          |  85 +++++
>  xen/xsm/flask/avc.c                               |   2 +-
>  xen/xsm/flask/flask_op.c                          |   8 +-
>  xen/xsm/flask/hooks.c                             | 236 +++++++------
>  xen/xsm/flask/private.h                           |   9 +
>  xen/xsm/flask/ss/avtab.c                          |   4 +-
>  xen/xsm/flask/ss/conditional.c                    |  10 +-
>  xen/xsm/flask/ss/conditional.h                    |   6 +-
>  xen/xsm/flask/ss/policydb.c                       |  53 +--
>  xen/xsm/flask/ss/services.c                       |   6 +-
>  xen/xsm/flask/ss/symtab.c                         |   5 +-
>  xen/xsm/silo.c                                    |  24 +-
>  xen/xsm/xsm_core.c                                |   6 +-
>  322 files changed, 3316 insertions(+), 2739 deletions(-)
>  create mode 100644 automation/build/debian/buster-gcc-ibt.dockerfile
>  create mode 100644 xen/arch/x86/include/asm/endbr.h
>  create mode 100755 xen/tools/check-endbr.sh
>  create mode 100644 xen/xsm/flask/private.h
>=20



From xen-devel-bounces@lists.xenproject.org Tue Feb 22 15:35:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 15:35:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276925.473314 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMXBt-0005tp-MG; Tue, 22 Feb 2022 15:35:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276925.473314; Tue, 22 Feb 2022 15:35:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMXBt-0005tT-Hc; Tue, 22 Feb 2022 15:35:01 +0000
Received: by outflank-mailman (input) for mailman id 276925;
 Tue, 22 Feb 2022 15:35:00 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Woib=TF=citrix.com=prvs=045a4fa17=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nMXBs-0005NF-8J
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 15:35:00 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id fd5e0568-93f4-11ec-8eb8-a37418f5ba1a;
 Tue, 22 Feb 2022 16:34:59 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fd5e0568-93f4-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645544099;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=4bBOiMpVdWF12ymMblnGk01vxKqLv1d+rpIj3W+2L6w=;
  b=b1ZUG1DPCFOo2el/7shHwNWKtlFhTkTHxhYS3jfTCsiIYEW/ZVfQ0z/e
   eYgXm2hrM+pPInTfS7PE+JL+lAQeSYI9c6xhuj0Gct0L4TjKM8ykEDGN3
   i9zg+x5NujiiDVRZLjpMSmn2I+AFj6YWgo/B8Z812rgk6WSFsHBVmIliF
   w=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 66982709
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:eP2spqkiMODgKh6tBgwoO/jo5gzlJkRdPkR7XQ2eYbSJt1+Wr1Gzt
 xIeWDuDOvmKZWanfNp3bISx9B8D6JLczIAwS1dr/H01HiMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2UILd9IR2NYy24DjWVnV4
 7senuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR
 v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ
 NtxWZOYZxV3NYzLv/onSzZTEHpGMLZk4ufcCC3q2SCT5xWun3rExvxvCAc9PJEC+/YxCmZLn
 RAaAGlTNFbZ3bvwme/lDLk37iggBJCD0Ic3k3ds1zzGS90hRojOWf7i7t5ExjYgwMtJGJ4yY
 uJHN2s/NkuYMnWjPH8qLcNvsb2xnELgci17rXDJhI9m+y/cmVkZPL/Fb4OOJ43iqd9utlaVo
 CfK8nr0BjkeNceD0nyV/3S0nOjNkCjnHoUIG9WFGuVC2QPJgDZJUVtPCAX98aLRZlOCt8x3B
 V5K8QspirYI7GOgTYLFUgaauiafl0tJMzZPKNES5AaIw6vSxg+WAGkYUzJMAOAbWN8KqS8Cj
 QHQwY6wbdB7mPjMEC/GqO/Ixd+nEXVNdQc/iTk4oRzpCjUJiKU6lVrxQ9lqC8ZZZfWlSGirk
 1hmQMXT7oj/bPLnNY3mpTgrYBr2//AlqzLZAC2NBQpJCSsjOeaYi3SAswSz0Bq5BN/xoqO9l
 HYFgdOCy+sFEIuAkieAKM1UQu30u6jUbWCG3Qc3d3XEy9hL0yT4FWy3yGsjTHqFz+5eIWO5C
 KMtkVk5CGBv0IuCMvYsPtPZ5zUCxqn8D9X1Ps04nfIVCqWdgDSvpXk0DWbJhjiFuBF1zckXZ
 MfKGe7xXC1yIfk2k1KLqxI1jOZDKtYWnjiIG/gWDn2PjNKjWZJiYe1baADXNrhhtstpYmz9q
 r5iCidD8D0HOMWWX8Ud2dd7wYwiRZTjOa3Llg==
IronPort-HdrOrdr: A9a23:ukfrnqzFx3ZIqSmF9LpJKrPwKL1zdoMgy1knxilNoRw8SK2lfq
 GV7YwmPHDP+VUssR0b9uxofZPwJU80lqQFmLX5X43SPjUO0VHAROoJgOffKn/bakrDH4ZmpM
 FdmsNFaOEYY2IVsS+D2njcL+od
X-IronPort-AV: E=Sophos;i="5.88,387,1635220800"; 
   d="scan'208";a="66982709"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v3 46/70] x86/logdirty: CFI hardening
Date: Tue, 22 Feb 2022 15:26:41 +0000
Message-ID: <20220222152645.8844-12-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220222152645.8844-1-andrew.cooper3@citrix.com>
References: <20220222152645.8844-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

Control Flow Integrity schemes use toolchain and optionally hardware support
to help protect against call/jump/return oriented programming attacks.

Use cf_check to annotate function pointer targets for the toolchain.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
v3:
 * Fix !CONFIG_SHADOW build.  Annotate targets in none.c
---
 xen/arch/x86/mm/hap/hap.c       |  6 +++---
 xen/arch/x86/mm/shadow/common.c | 12 ++++++------
 xen/arch/x86/mm/shadow/none.c   |  6 +++---
 3 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/xen/arch/x86/mm/hap/hap.c b/xen/arch/x86/mm/hap/hap.c
index de4b13565ab4..ed5112b00b63 100644
--- a/xen/arch/x86/mm/hap/hap.c
+++ b/xen/arch/x86/mm/hap/hap.c
@@ -180,7 +180,7 @@ int hap_track_dirty_vram(struct domain *d,
  * NB: Domain that having device assigned should not set log_global. Because
  * there is no way to track the memory updating from device.
  */
-static int hap_enable_log_dirty(struct domain *d, bool_t log_global)
+static int cf_check hap_enable_log_dirty(struct domain *d, bool log_global)
 {
     struct p2m_domain *p2m = p2m_get_hostp2m(d);
 
@@ -211,7 +211,7 @@ static int hap_enable_log_dirty(struct domain *d, bool_t log_global)
     return 0;
 }
 
-static int hap_disable_log_dirty(struct domain *d)
+static int cf_check hap_disable_log_dirty(struct domain *d)
 {
     paging_lock(d);
     d->arch.paging.mode &= ~PG_log_dirty;
@@ -228,7 +228,7 @@ static int hap_disable_log_dirty(struct domain *d)
     return 0;
 }
 
-static void hap_clean_dirty_bitmap(struct domain *d)
+static void cf_check hap_clean_dirty_bitmap(struct domain *d)
 {
     /*
      * Switch to log-dirty mode, either by setting l1e entries of P2M table to
diff --git a/xen/arch/x86/mm/shadow/common.c b/xen/arch/x86/mm/shadow/common.c
index 83dedc8870aa..071a19adce82 100644
--- a/xen/arch/x86/mm/shadow/common.c
+++ b/xen/arch/x86/mm/shadow/common.c
@@ -40,9 +40,9 @@
 
 DEFINE_PER_CPU(uint32_t,trace_shadow_path_flags);
 
-static int sh_enable_log_dirty(struct domain *, bool log_global);
-static int sh_disable_log_dirty(struct domain *);
-static void sh_clean_dirty_bitmap(struct domain *);
+static int cf_check sh_enable_log_dirty(struct domain *, bool log_global);
+static int cf_check sh_disable_log_dirty(struct domain *);
+static void cf_check sh_clean_dirty_bitmap(struct domain *);
 
 /* Set up the shadow-specific parts of a domain struct at start of day.
  * Called for every domain from arch_domain_create() */
@@ -3016,7 +3016,7 @@ static int shadow_test_disable(struct domain *d)
 /* Shadow specific code which is called in paging_log_dirty_enable().
  * Return 0 if no problem found.
  */
-static int sh_enable_log_dirty(struct domain *d, bool log_global)
+static int cf_check sh_enable_log_dirty(struct domain *d, bool log_global)
 {
     int ret;
 
@@ -3044,7 +3044,7 @@ static int sh_enable_log_dirty(struct domain *d, bool log_global)
 }
 
 /* shadow specfic code which is called in paging_log_dirty_disable() */
-static int sh_disable_log_dirty(struct domain *d)
+static int cf_check sh_disable_log_dirty(struct domain *d)
 {
     int ret;
 
@@ -3058,7 +3058,7 @@ static int sh_disable_log_dirty(struct domain *d)
 /* This function is called when we CLEAN log dirty bitmap. See
  * paging_log_dirty_op() for details.
  */
-static void sh_clean_dirty_bitmap(struct domain *d)
+static void cf_check sh_clean_dirty_bitmap(struct domain *d)
 {
     paging_lock(d);
     /* Need to revoke write access to the domain's pages again.
diff --git a/xen/arch/x86/mm/shadow/none.c b/xen/arch/x86/mm/shadow/none.c
index 79889b926a89..463a0e3e89c3 100644
--- a/xen/arch/x86/mm/shadow/none.c
+++ b/xen/arch/x86/mm/shadow/none.c
@@ -1,19 +1,19 @@
 #include <xen/mm.h>
 #include <asm/shadow.h>
 
-static int _enable_log_dirty(struct domain *d, bool log_global)
+static int cf_check _enable_log_dirty(struct domain *d, bool log_global)
 {
     ASSERT(is_pv_domain(d));
     return -EOPNOTSUPP;
 }
 
-static int _disable_log_dirty(struct domain *d)
+static int cf_check _disable_log_dirty(struct domain *d)
 {
     ASSERT(is_pv_domain(d));
     return -EOPNOTSUPP;
 }
 
-static void _clean_dirty_bitmap(struct domain *d)
+static void cf_check _clean_dirty_bitmap(struct domain *d)
 {
     ASSERT(is_pv_domain(d));
 }
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Tue Feb 22 15:35:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 15:35:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276924.473299 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMXBs-0005Qt-B4; Tue, 22 Feb 2022 15:35:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276924.473299; Tue, 22 Feb 2022 15:35:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMXBs-0005QE-3i; Tue, 22 Feb 2022 15:35:00 +0000
Received: by outflank-mailman (input) for mailman id 276924;
 Tue, 22 Feb 2022 15:34:58 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Woib=TF=citrix.com=prvs=045a4fa17=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nMXBq-0005NI-KY
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 15:34:58 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id fbaaac22-93f4-11ec-8539-5f4723681683;
 Tue, 22 Feb 2022 16:34:56 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fbaaac22-93f4-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645544096;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=WwoYSuUHQ+77Q76UGECZtS9P4GmDV6KJztxERQ3eZjc=;
  b=fSwBecEZ4Rz1USSUafIu/2AbHt7vHHaFw7Uv+Jr2NREt63xlhwFoEDs2
   1KzepW+eBeuEWrjIcfQjn3yVwWuQdNkkdNJE+ihhZnptLgW8+5moBjjPE
   AfyHWDNm0YZ+pkfiTSAJA+u6PY04GTq3VDQ9Wid17h80bgAVjcldKlBtD
   I=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 64171033
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:YAbKTargXmiA2b8cv29diABd3GpeBmJ8ZRIvgKrLsJaIsI4StFCzt
 garIBmBM/yONGujKIp3Otmx/E8OsZSGndRgTVdor31jFy4V9JuZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlVEliefQAOCU5NfsYkidfyc9IMsaoU8ly75RbrJA24DjWVvX4
 4mq+aUzBXf+s9JKGjNMg068gEsHUMTa4Fv0aXRnOJinFHeH/5UkJMp3yZOZdhMUcaENdgKOf
 M7RzanRw4/s10xF5uVJMFrMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKv+Zvrgc91Zk
 b1wWZKMpQgBEqLUk9seCRZkNjxOEPVBoYDWPlTmrpnGp6HGWyOEL/RGCUg3OcsT+/ptAHEI/
 vsdQNwPRknd3aTsmuv9E7QywJR4RCXoFNp3VnVI5DfVF/s5B7vERL3H/4Rw1zYsnMFeW/3ZY
 qL1bBIxME2fOkUUYT/7Dro5s+b2gkjSSwRDj3i1/oxnsnCI4CB+he2F3N39JYXRGJQ9clyjj
 nLL+SH1Dw8XMPSbyCGZ6TS8i+nXhyT5VYkOUrqi+ZZXbEa7nzJJTkdMDB3i/Kf/2hXWt89jx
 1I81iU2ppcxrkOXa8TNckW/+UGVoTJFRI8FewEl0z2lxq3R6gefI2ELSD9dddAr3PMLqSwWO
 kyhxI2wW2E22FGBYTfEr+rP82vuUcQABTJaPUc5oR05D84PSW3ZpjbGVZ5dHaG8lbUZ8hmgk
 mnR/EDSa1j+5PPnNplXH3ia21pARbCTF2bZAzk7uEr/tWuVg6b/OuSVBaDzt6ooEWpgZgDpU
 II4s8af9vsSKpqGiTaARu4AdJnwuarYbGON3AM1Q8B5n9hIx5JFVdoLiN2ZDB00WvvohBezO
 BOD0e+vzMU70ISWgV9fPNvqVpVCIVnIHtX5TPHEBueikbAqHDJrCBpGPBbKt0i0yRBEufhmZ
 f+zLJb9ZV5HWP8P5GfnGI8gPUoDm3lWKZX7HsugkXxKENO2ORaodFvyGAHQNrtgtPvc+m04M
 b93bqO39vmWa8WmCgG/zGLZBQliwaQTbXwul/FqSw==
IronPort-HdrOrdr: A9a23:TKgaYay65yVDsygskLhpKrPwLr1zdoMgy1knxilNoRw8SKKlfq
 GV7Y0mPHDP6Ar5NEtNpTnEAtjkfZq+z+8S3WByB8bAYOCOggLBR+sO0WKh+UyFJ8SXzJ876U
 4KSclD4bPLYmSS9fyKgjWFLw==
X-IronPort-AV: E=Sophos;i="5.88,387,1635220800"; 
   d="scan'208";a="64171033"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v3 47/70] x86/shadow: CFI hardening
Date: Tue, 22 Feb 2022 15:26:42 +0000
Message-ID: <20220222152645.8844-13-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220222152645.8844-1-andrew.cooper3@citrix.com>
References: <20220222152645.8844-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

Control Flow Integrity schemes use toolchain and optionally hardware support
to help protect against call/jump/return oriented programming attacks.

Use cf_check to annotate function pointer targets for the toolchain.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
v3:
 * Fix !CONFIG_SHADOW build.  Annotate targets in none.c
---
 xen/arch/x86/mm/shadow/common.c  | 11 +++---
 xen/arch/x86/mm/shadow/hvm.c     |  8 ++--
 xen/arch/x86/mm/shadow/multi.c   | 80 ++++++++++++++++++++--------------------
 xen/arch/x86/mm/shadow/multi.h   | 20 +++++-----
 xen/arch/x86/mm/shadow/none.c    | 14 +++----
 xen/arch/x86/mm/shadow/private.h | 12 +++---
 xen/arch/x86/mm/shadow/pv.c      |  4 +-
 7 files changed, 74 insertions(+), 75 deletions(-)

diff --git a/xen/arch/x86/mm/shadow/common.c b/xen/arch/x86/mm/shadow/common.c
index 071a19adce82..8f111901730f 100644
--- a/xen/arch/x86/mm/shadow/common.c
+++ b/xen/arch/x86/mm/shadow/common.c
@@ -1215,7 +1215,7 @@ void shadow_free(struct domain *d, mfn_t smfn)
  * This action is irreversible: the p2m mapping only ever grows.
  * That's OK because the p2m table only exists for translated domains,
  * and those domains can't ever turn off shadow mode. */
-static struct page_info *
+static struct page_info *cf_check
 shadow_alloc_p2m_page(struct domain *d)
 {
     struct page_info *pg;
@@ -1251,7 +1251,7 @@ shadow_alloc_p2m_page(struct domain *d)
     return pg;
 }
 
-static void
+static void cf_check
 shadow_free_p2m_page(struct domain *d, struct page_info *pg)
 {
     struct domain *owner = page_get_owner(pg);
@@ -2290,7 +2290,8 @@ void shadow_prepare_page_type_change(struct domain *d, struct page_info *page,
 /* Reset the up-pointers of every L3 shadow to 0.
  * This is called when l3 shadows stop being pinnable, to clear out all
  * the list-head bits so the up-pointer field is properly inititalised. */
-static int sh_clear_up_pointer(struct vcpu *v, mfn_t smfn, mfn_t unused)
+static int cf_check sh_clear_up_pointer(
+    struct vcpu *v, mfn_t smfn, mfn_t unused)
 {
     mfn_to_page(smfn)->up = 0;
     return 0;
@@ -2490,7 +2491,7 @@ static void sh_update_paging_modes(struct vcpu *v)
     v->arch.paging.mode->update_cr3(v, 0, false);
 }
 
-void shadow_update_paging_modes(struct vcpu *v)
+void cf_check shadow_update_paging_modes(struct vcpu *v)
 {
     paging_lock(v->domain);
     sh_update_paging_modes(v);
@@ -3075,7 +3076,7 @@ static bool flush_vcpu(const struct vcpu *v, const unsigned long *vcpu_bitmap)
 }
 
 /* Flush TLB of selected vCPUs.  NULL for all. */
-bool shadow_flush_tlb(const unsigned long *vcpu_bitmap)
+bool cf_check shadow_flush_tlb(const unsigned long *vcpu_bitmap)
 {
     static DEFINE_PER_CPU(cpumask_t, flush_cpumask);
     cpumask_t *mask = &this_cpu(flush_cpumask);
diff --git a/xen/arch/x86/mm/shadow/hvm.c b/xen/arch/x86/mm/shadow/hvm.c
index c90d326becb3..27dd99f1a12e 100644
--- a/xen/arch/x86/mm/shadow/hvm.c
+++ b/xen/arch/x86/mm/shadow/hvm.c
@@ -794,9 +794,9 @@ sh_remove_all_shadows_and_parents(struct domain *d, mfn_t gmfn)
      * It means extra emulated writes and slows down removal of mappings. */
 }
 
-static void sh_unshadow_for_p2m_change(struct domain *d, unsigned long gfn,
-                                       l1_pgentry_t old, l1_pgentry_t new,
-                                       unsigned int level)
+static void cf_check sh_unshadow_for_p2m_change(
+    struct domain *d, unsigned long gfn, l1_pgentry_t old, l1_pgentry_t new,
+    unsigned int level)
 {
     mfn_t omfn = l1e_get_mfn(old);
     unsigned int oflags = l1e_get_flags(old);
@@ -879,7 +879,7 @@ static void sh_unshadow_for_p2m_change(struct domain *d, unsigned long gfn,
 }
 
 #if (SHADOW_OPTIMIZATIONS & SHOPT_FAST_FAULT_PATH)
-static void
+static void cf_check
 sh_write_p2m_entry_post(struct p2m_domain *p2m, unsigned int oflags)
 {
     struct domain *d = p2m->domain;
diff --git a/xen/arch/x86/mm/shadow/multi.c b/xen/arch/x86/mm/shadow/multi.c
index bddef53163f5..b0b1c31ee033 100644
--- a/xen/arch/x86/mm/shadow/multi.c
+++ b/xen/arch/x86/mm/shadow/multi.c
@@ -369,7 +369,7 @@ static void sh_audit_gw(struct vcpu *v, const walk_t *gw)
 
 #if GUEST_PAGING_LEVELS == 2
 /* From one page of a multi-page shadow, find the next one */
-static inline mfn_t sh_next_page(mfn_t smfn)
+static inline mfn_t cf_check sh_next_page(mfn_t smfn)
 {
     struct page_info *pg = mfn_to_page(smfn), *next;
     struct page_list_head h = PAGE_LIST_HEAD_INIT(h);
@@ -399,8 +399,7 @@ guest_index(void *ptr)
     return (u32)((unsigned long)ptr & ~PAGE_MASK) / sizeof(guest_l1e_t);
 }
 
-static u32
-shadow_l1_index(mfn_t *smfn, u32 guest_index)
+static u32 cf_check shadow_l1_index(mfn_t *smfn, u32 guest_index)
 {
 #if (GUEST_PAGING_LEVELS == 2)
     ASSERT(mfn_to_page(*smfn)->u.sh.head);
@@ -412,8 +411,7 @@ shadow_l1_index(mfn_t *smfn, u32 guest_index)
 #endif
 }
 
-static u32
-shadow_l2_index(mfn_t *smfn, u32 guest_index)
+static u32 cf_check shadow_l2_index(mfn_t *smfn, u32 guest_index)
 {
 #if (GUEST_PAGING_LEVELS == 2)
     int i;
@@ -432,14 +430,12 @@ shadow_l2_index(mfn_t *smfn, u32 guest_index)
 
 #if GUEST_PAGING_LEVELS >= 4
 
-static u32
-shadow_l3_index(mfn_t *smfn, u32 guest_index)
+static u32 cf_check shadow_l3_index(mfn_t *smfn, u32 guest_index)
 {
     return guest_index;
 }
 
-static u32
-shadow_l4_index(mfn_t *smfn, u32 guest_index)
+static u32 cf_check shadow_l4_index(mfn_t *smfn, u32 guest_index)
 {
     return guest_index;
 }
@@ -924,7 +920,7 @@ do {                                                                    \
 /**************************************************************************/
 /* Create a shadow of a given guest page.
  */
-static mfn_t
+static mfn_t cf_check
 sh_make_shadow(struct vcpu *v, mfn_t gmfn, u32 shadow_type)
 {
     struct domain *d = v->domain;
@@ -1459,7 +1455,8 @@ void sh_unhook_64b_mappings(struct domain *d, mfn_t sl4mfn, int user_only)
  */
 
 #if GUEST_PAGING_LEVELS >= 4
-static int validate_gl4e(struct vcpu *v, void *new_ge, mfn_t sl4mfn, void *se)
+static int cf_check validate_gl4e(
+    struct vcpu *v, void *new_ge, mfn_t sl4mfn, void *se)
 {
     shadow_l4e_t new_sl4e;
     guest_l4e_t new_gl4e = *(guest_l4e_t *)new_ge;
@@ -1518,7 +1515,8 @@ static int validate_gl4e(struct vcpu *v, void *new_ge, mfn_t sl4mfn, void *se)
 }
 
 
-static int validate_gl3e(struct vcpu *v, void *new_ge, mfn_t sl3mfn, void *se)
+static int cf_check validate_gl3e(
+    struct vcpu *v, void *new_ge, mfn_t sl3mfn, void *se)
 {
     struct domain *d = v->domain;
     shadow_l3e_t new_sl3e;
@@ -1552,7 +1550,8 @@ static int validate_gl3e(struct vcpu *v, void *new_ge, mfn_t sl3mfn, void *se)
 }
 #endif // GUEST_PAGING_LEVELS >= 4
 
-static int validate_gl2e(struct vcpu *v, void *new_ge, mfn_t sl2mfn, void *se)
+static int cf_check validate_gl2e(
+    struct vcpu *v, void *new_ge, mfn_t sl2mfn, void *se)
 {
     struct domain *d = v->domain;
     shadow_l2e_t new_sl2e;
@@ -1599,7 +1598,8 @@ static int validate_gl2e(struct vcpu *v, void *new_ge, mfn_t sl2mfn, void *se)
     return result;
 }
 
-static int validate_gl1e(struct vcpu *v, void *new_ge, mfn_t sl1mfn, void *se)
+static int cf_check validate_gl1e(
+    struct vcpu *v, void *new_ge, mfn_t sl1mfn, void *se)
 {
     struct domain *d = v->domain;
     shadow_l1e_t new_sl1e;
@@ -2089,8 +2089,8 @@ static DEFINE_PER_CPU(int,trace_extra_emulation_count);
 #endif
 static DEFINE_PER_CPU(guest_pa_t,trace_emulate_write_val);
 
-static void trace_emulate_write_val(const void *ptr, unsigned long vaddr,
-                                    const void *src, unsigned int bytes)
+static void cf_check trace_emulate_write_val(
+    const void *ptr, unsigned long vaddr, const void *src, unsigned int bytes)
 {
 #if GUEST_PAGING_LEVELS == 3
     if ( vaddr == this_cpu(trace_emulate_initial_va) )
@@ -2144,9 +2144,8 @@ static inline void trace_shadow_emulate(guest_l1e_t gl1e, unsigned long va)
  * shadow code (and the guest should retry) or 0 if it is not (and the
  * fault should be handled elsewhere or passed to the guest). */
 
-static int sh_page_fault(struct vcpu *v,
-                          unsigned long va,
-                          struct cpu_user_regs *regs)
+static int cf_check sh_page_fault(
+    struct vcpu *v, unsigned long va, struct cpu_user_regs *regs)
 {
     struct domain *d = v->domain;
     walk_t gw;
@@ -2898,7 +2897,7 @@ static int sh_page_fault(struct vcpu *v,
  * instruction should be issued on the hardware, or false if it's safe not
  * to do so.
  */
-static bool sh_invlpg(struct vcpu *v, unsigned long linear)
+static bool cf_check sh_invlpg(struct vcpu *v, unsigned long linear)
 {
     mfn_t sl1mfn;
     shadow_l2e_t sl2e;
@@ -3030,9 +3029,8 @@ static bool sh_invlpg(struct vcpu *v, unsigned long linear)
 
 #ifdef CONFIG_HVM
 
-static unsigned long
-sh_gva_to_gfn(struct vcpu *v, struct p2m_domain *p2m,
-    unsigned long va, uint32_t *pfec)
+static unsigned long cf_check sh_gva_to_gfn(
+    struct vcpu *v, struct p2m_domain *p2m, unsigned long va, uint32_t *pfec)
 /* Called to translate a guest virtual address to what the *guest*
  * pagetables would map it to. */
 {
@@ -3196,8 +3194,7 @@ sh_update_linear_entries(struct vcpu *v)
  * Removes v->arch.paging.shadow.shadow_table[].
  * Does all appropriate management/bookkeeping/refcounting/etc...
  */
-static void
-sh_detach_old_tables(struct vcpu *v)
+static void cf_check sh_detach_old_tables(struct vcpu *v)
 {
     struct domain *d = v->domain;
     mfn_t smfn;
@@ -3216,8 +3213,7 @@ sh_detach_old_tables(struct vcpu *v)
     }
 }
 
-static void
-sh_update_cr3(struct vcpu *v, int do_locking, bool noflush)
+static void cf_check sh_update_cr3(struct vcpu *v, int do_locking, bool noflush)
 /* Updates vcpu->arch.cr3 after the guest has changed CR3.
  * Paravirtual guests should set v->arch.guest_table (and guest_table_user,
  * if appropriate).
@@ -3525,7 +3521,8 @@ int sh_rm_write_access_from_sl1p(struct domain *d, mfn_t gmfn,
 #endif /* OOS */
 
 #if defined(CONFIG_HVM) && (SHADOW_OPTIMIZATIONS & SHOPT_WRITABLE_HEURISTIC)
-static int sh_guess_wrmap(struct vcpu *v, unsigned long vaddr, mfn_t gmfn)
+static int cf_check sh_guess_wrmap(
+    struct vcpu *v, unsigned long vaddr, mfn_t gmfn)
 /* Look up this vaddr in the current shadow and see if it's a writeable
  * mapping of this gmfn.  If so, remove it.  Returns 1 if it worked. */
 {
@@ -3589,8 +3586,8 @@ static int sh_guess_wrmap(struct vcpu *v, unsigned long vaddr, mfn_t gmfn)
 }
 #endif
 
-int sh_rm_write_access_from_l1(struct domain *d, mfn_t sl1mfn,
-                               mfn_t readonly_mfn)
+int cf_check sh_rm_write_access_from_l1(
+    struct domain *d, mfn_t sl1mfn, mfn_t readonly_mfn)
 /* Excises all writeable mappings to readonly_mfn from this l1 shadow table */
 {
     shadow_l1e_t *sl1e;
@@ -3626,7 +3623,8 @@ int sh_rm_write_access_from_l1(struct domain *d, mfn_t sl1mfn,
 }
 
 
-int sh_rm_mappings_from_l1(struct domain *d, mfn_t sl1mfn, mfn_t target_mfn)
+int cf_check sh_rm_mappings_from_l1(
+    struct domain *d, mfn_t sl1mfn, mfn_t target_mfn)
 /* Excises all mappings to guest frame from this shadow l1 table */
 {
     shadow_l1e_t *sl1e;
@@ -3677,7 +3675,7 @@ void sh_clear_shadow_entry(struct domain *d, void *ep, mfn_t smfn)
     }
 }
 
-int sh_remove_l1_shadow(struct domain *d, mfn_t sl2mfn, mfn_t sl1mfn)
+int cf_check sh_remove_l1_shadow(struct domain *d, mfn_t sl2mfn, mfn_t sl1mfn)
 /* Remove all mappings of this l1 shadow from this l2 shadow */
 {
     shadow_l2e_t *sl2e;
@@ -3700,7 +3698,7 @@ int sh_remove_l1_shadow(struct domain *d, mfn_t sl2mfn, mfn_t sl1mfn)
 }
 
 #if GUEST_PAGING_LEVELS >= 4
-int sh_remove_l2_shadow(struct domain *d, mfn_t sl3mfn, mfn_t sl2mfn)
+int cf_check sh_remove_l2_shadow(struct domain *d, mfn_t sl3mfn, mfn_t sl2mfn)
 /* Remove all mappings of this l2 shadow from this l3 shadow */
 {
     shadow_l3e_t *sl3e;
@@ -3722,7 +3720,7 @@ int sh_remove_l2_shadow(struct domain *d, mfn_t sl3mfn, mfn_t sl2mfn)
     return done;
 }
 
-int sh_remove_l3_shadow(struct domain *d, mfn_t sl4mfn, mfn_t sl3mfn)
+int cf_check sh_remove_l3_shadow(struct domain *d, mfn_t sl4mfn, mfn_t sl3mfn)
 /* Remove all mappings of this l3 shadow from this l4 shadow */
 {
     shadow_l4e_t *sl4e;
@@ -3752,7 +3750,7 @@ int sh_remove_l3_shadow(struct domain *d, mfn_t sl4mfn, mfn_t sl3mfn)
  * and in the meantime we unhook its top-level user-mode entries. */
 
 #if GUEST_PAGING_LEVELS == 3
-static void sh_pagetable_dying(paddr_t gpa)
+static void cf_check sh_pagetable_dying(paddr_t gpa)
 {
     struct vcpu *v = current;
     struct domain *d = v->domain;
@@ -3833,7 +3831,7 @@ static void sh_pagetable_dying(paddr_t gpa)
     put_gfn(d, l3gfn);
 }
 #else
-static void sh_pagetable_dying(paddr_t gpa)
+static void cf_check sh_pagetable_dying(paddr_t gpa)
 {
     struct vcpu *v = current;
     struct domain *d = v->domain;
@@ -3932,7 +3930,7 @@ static const char *sh_audit_flags(struct vcpu *v, int level,
     return NULL;
 }
 
-int sh_audit_l1_table(struct vcpu *v, mfn_t sl1mfn, mfn_t x)
+int cf_check sh_audit_l1_table(struct vcpu *v, mfn_t sl1mfn, mfn_t x)
 {
     guest_l1e_t *gl1e, *gp;
     shadow_l1e_t *sl1e;
@@ -4000,7 +3998,7 @@ int sh_audit_l1_table(struct vcpu *v, mfn_t sl1mfn, mfn_t x)
     return done;
 }
 
-int sh_audit_fl1_table(struct vcpu *v, mfn_t sl1mfn, mfn_t x)
+int cf_check sh_audit_fl1_table(struct vcpu *v, mfn_t sl1mfn, mfn_t x)
 {
     guest_l1e_t *gl1e, e;
     shadow_l1e_t *sl1e;
@@ -4026,7 +4024,7 @@ int sh_audit_fl1_table(struct vcpu *v, mfn_t sl1mfn, mfn_t x)
     return 0;
 }
 
-int sh_audit_l2_table(struct vcpu *v, mfn_t sl2mfn, mfn_t x)
+int cf_check sh_audit_l2_table(struct vcpu *v, mfn_t sl2mfn, mfn_t x)
 {
     struct domain *d = v->domain;
     guest_l2e_t *gl2e, *gp;
@@ -4078,7 +4076,7 @@ int sh_audit_l2_table(struct vcpu *v, mfn_t sl2mfn, mfn_t x)
 }
 
 #if GUEST_PAGING_LEVELS >= 4
-int sh_audit_l3_table(struct vcpu *v, mfn_t sl3mfn, mfn_t x)
+int cf_check sh_audit_l3_table(struct vcpu *v, mfn_t sl3mfn, mfn_t x)
 {
     struct domain *d = v->domain;
     guest_l3e_t *gl3e, *gp;
@@ -4126,7 +4124,7 @@ int sh_audit_l3_table(struct vcpu *v, mfn_t sl3mfn, mfn_t x)
     return 0;
 }
 
-int sh_audit_l4_table(struct vcpu *v, mfn_t sl4mfn, mfn_t x)
+int cf_check sh_audit_l4_table(struct vcpu *v, mfn_t sl4mfn, mfn_t x)
 {
     struct domain *d = v->domain;
     guest_l4e_t *gl4e, *gp;
diff --git a/xen/arch/x86/mm/shadow/multi.h b/xen/arch/x86/mm/shadow/multi.h
index 0bd6a2d5b787..5bcd6ae1a8da 100644
--- a/xen/arch/x86/mm/shadow/multi.h
+++ b/xen/arch/x86/mm/shadow/multi.h
@@ -59,10 +59,10 @@ extern void
 SHADOW_INTERNAL_NAME(sh_unhook_64b_mappings, GUEST_LEVELS)
     (struct domain *d, mfn_t sl4mfn, int user_only);
 
-extern int
+int cf_check
 SHADOW_INTERNAL_NAME(sh_rm_write_access_from_l1, GUEST_LEVELS)
     (struct domain *d, mfn_t sl1mfn, mfn_t readonly_mfn);
-extern int
+int cf_check
 SHADOW_INTERNAL_NAME(sh_rm_mappings_from_l1, GUEST_LEVELS)
     (struct domain *d, mfn_t sl1mfn, mfn_t target_mfn);
 
@@ -70,30 +70,30 @@ extern void
 SHADOW_INTERNAL_NAME(sh_clear_shadow_entry, GUEST_LEVELS)
     (struct domain *d, void *ep, mfn_t smfn);
 
-extern int
+int cf_check
 SHADOW_INTERNAL_NAME(sh_remove_l1_shadow, GUEST_LEVELS)
     (struct domain *d, mfn_t sl2mfn, mfn_t sl1mfn);
-extern int
+int cf_check
 SHADOW_INTERNAL_NAME(sh_remove_l2_shadow, GUEST_LEVELS)
     (struct domain *d, mfn_t sl3mfn, mfn_t sl2mfn);
-extern int
+int cf_check
 SHADOW_INTERNAL_NAME(sh_remove_l3_shadow, GUEST_LEVELS)
     (struct domain *d, mfn_t sl4mfn, mfn_t sl3mfn);
 
 #if SHADOW_AUDIT & SHADOW_AUDIT_ENTRIES
-int
+int cf_check
 SHADOW_INTERNAL_NAME(sh_audit_l1_table, GUEST_LEVELS)
     (struct vcpu *v, mfn_t sl1mfn, mfn_t x);
-int
+int cf_check
 SHADOW_INTERNAL_NAME(sh_audit_fl1_table, GUEST_LEVELS)
     (struct vcpu *v, mfn_t sl1mfn, mfn_t x);
-int
+int cf_check
 SHADOW_INTERNAL_NAME(sh_audit_l2_table, GUEST_LEVELS)
     (struct vcpu *v, mfn_t sl2mfn, mfn_t x);
-int
+int cf_check
 SHADOW_INTERNAL_NAME(sh_audit_l3_table, GUEST_LEVELS)
     (struct vcpu *v, mfn_t sl3mfn, mfn_t x);
-int
+int cf_check
 SHADOW_INTERNAL_NAME(sh_audit_l4_table, GUEST_LEVELS)
     (struct vcpu *v, mfn_t sl4mfn, mfn_t x);
 #endif
diff --git a/xen/arch/x86/mm/shadow/none.c b/xen/arch/x86/mm/shadow/none.c
index 463a0e3e89c3..eaaa874b119f 100644
--- a/xen/arch/x86/mm/shadow/none.c
+++ b/xen/arch/x86/mm/shadow/none.c
@@ -30,34 +30,34 @@ int shadow_domain_init(struct domain *d)
     return is_hvm_domain(d) ? -EOPNOTSUPP : 0;
 }
 
-static int _page_fault(struct vcpu *v, unsigned long va,
-                       struct cpu_user_regs *regs)
+static int cf_check _page_fault(
+    struct vcpu *v, unsigned long va, struct cpu_user_regs *regs)
 {
     ASSERT_UNREACHABLE();
     return 0;
 }
 
-static bool _invlpg(struct vcpu *v, unsigned long linear)
+static bool cf_check _invlpg(struct vcpu *v, unsigned long linear)
 {
     ASSERT_UNREACHABLE();
     return true;
 }
 
 #ifdef CONFIG_HVM
-static unsigned long _gva_to_gfn(struct vcpu *v, struct p2m_domain *p2m,
-                                 unsigned long va, uint32_t *pfec)
+static unsigned long cf_check _gva_to_gfn(
+    struct vcpu *v, struct p2m_domain *p2m, unsigned long va, uint32_t *pfec)
 {
     ASSERT_UNREACHABLE();
     return gfn_x(INVALID_GFN);
 }
 #endif
 
-static void _update_cr3(struct vcpu *v, int do_locking, bool noflush)
+static void cf_check _update_cr3(struct vcpu *v, int do_locking, bool noflush)
 {
     ASSERT_UNREACHABLE();
 }
 
-static void _update_paging_modes(struct vcpu *v)
+static void cf_check _update_paging_modes(struct vcpu *v)
 {
     ASSERT_UNREACHABLE();
 }
diff --git a/xen/arch/x86/mm/shadow/private.h b/xen/arch/x86/mm/shadow/private.h
index e4db8d32546a..3dc024e30f20 100644
--- a/xen/arch/x86/mm/shadow/private.h
+++ b/xen/arch/x86/mm/shadow/private.h
@@ -420,15 +420,15 @@ static inline int sh_remove_write_access(struct domain *d, mfn_t readonly_mfn,
 #endif
 
 /* Functions that atomically write PV guest PT entries */
-void sh_write_guest_entry(struct vcpu *v, intpte_t *p, intpte_t new,
-                          mfn_t gmfn);
-intpte_t sh_cmpxchg_guest_entry(struct vcpu *v, intpte_t *p, intpte_t old,
-                                intpte_t new, mfn_t gmfn);
+void cf_check sh_write_guest_entry(
+    struct vcpu *v, intpte_t *p, intpte_t new, mfn_t gmfn);
+intpte_t cf_check sh_cmpxchg_guest_entry(
+    struct vcpu *v, intpte_t *p, intpte_t old, intpte_t new, mfn_t gmfn);
 
 /* Update all the things that are derived from the guest's CR0/CR3/CR4.
  * Called to initialize paging structures if the paging mode
  * has changed, and when bringing up a VCPU for the first time. */
-void shadow_update_paging_modes(struct vcpu *v);
+void cf_check shadow_update_paging_modes(struct vcpu *v);
 
 /* Unhook the non-Xen mappings in this top-level shadow mfn.
  * With user_only == 1, unhooks only the user-mode mappings. */
@@ -922,7 +922,7 @@ static inline int sh_check_page_has_no_refs(struct page_info *page)
 }
 
 /* Flush the TLB of the selected vCPUs. */
-bool shadow_flush_tlb(const unsigned long *vcpu_bitmap);
+bool cf_check shadow_flush_tlb(const unsigned long *vcpu_bitmap);
 
 #endif /* _XEN_SHADOW_PRIVATE_H */
 
diff --git a/xen/arch/x86/mm/shadow/pv.c b/xen/arch/x86/mm/shadow/pv.c
index f51f980f2694..ed10d5479c5e 100644
--- a/xen/arch/x86/mm/shadow/pv.c
+++ b/xen/arch/x86/mm/shadow/pv.c
@@ -28,7 +28,7 @@
  * Write a new value into the guest pagetable, and update the shadows
  * appropriately.
  */
-void
+void cf_check
 sh_write_guest_entry(struct vcpu *v, intpte_t *p, intpte_t new, mfn_t gmfn)
 {
     paging_lock(v->domain);
@@ -42,7 +42,7 @@ sh_write_guest_entry(struct vcpu *v, intpte_t *p, intpte_t new, mfn_t gmfn)
  * appropriately.  Returns the previous entry found, which the caller is
  * expected to check to see if the cmpxchg was successful.
  */
-intpte_t
+intpte_t cf_check
 sh_cmpxchg_guest_entry(struct vcpu *v, intpte_t *p, intpte_t old,
                        intpte_t new, mfn_t gmfn)
 {
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Tue Feb 22 15:35:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 15:35:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276923.473293 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMXBs-0005Na-0j; Tue, 22 Feb 2022 15:35:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276923.473293; Tue, 22 Feb 2022 15:34:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMXBr-0005NT-Sr; Tue, 22 Feb 2022 15:34:59 +0000
Received: by outflank-mailman (input) for mailman id 276923;
 Tue, 22 Feb 2022 15:34:58 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Woib=TF=citrix.com=prvs=045a4fa17=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nMXBq-0005NF-23
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 15:34:58 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id fb25b33a-93f4-11ec-8eb8-a37418f5ba1a;
 Tue, 22 Feb 2022 16:34:55 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fb25b33a-93f4-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645544095;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=8+CkbbuS9bZ1ruJ4foosAOZaPaI8PjQLHNVZvxxO99c=;
  b=gGbbDh6XZ2LesvGr3oQYaZKUbqoUFZKN/pWQGaPKXvFhn97CtG3nM2O8
   pc6CFPui3tDQA9Qin37N/Jl5HaswPVyaD41bY6MrC+NiRWvYt0VqZ87g2
   u0xYh3Anm32UHtxkI+tM6OUnCZSiMdDAkpZFCtMex/d7dL4ZbNdRHgVK3
   4=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 65138983
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:rDoBcqoaUbSo4Hco2c5MqHF6EC1eBmJ8ZRIvgKrLsJaIsI4StFCzt
 garIBmGPvqCajfxctkgYIiypk4EsZ/QyoJgQARk/n03RXga+JuZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlVEliefQAOCU5NfsYkidfyc9IMsaoU8ly75RbrJA24DjWVvX4
 4mq+aUzBXf+s9JKGjNMg068gEsHUMTa4Fv0aXRnOJinFHeH/5UkJMp3yZOZdhMUcaENdgKOf
 M7RzanRw4/s10xF5uVJMFrMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKv+Zvrgc91Zk
 b1wWZKMpQgBPrbiiO47aAhhHmIgG6MX6KWbLEK7mJnGp6HGWyOEL/RGCUg3OcsT+/ptAHEI/
 vsdQNwPRknd3aTsmuv9E7QywJR4RCXoFNp3VnVI5DfVF/s5B7vERL3H/4Rw1zYsnMFeW/3ZY
 qL1bBIxMU2bM0wfYT/7Drpildaxvna8LgRqsXe3n/QJ23DYxiBIhe2F3N39JYXRGJQ9clyjj
 nLL+SH1Dw8XMPSbyCGZ6TS8i+nXhyT5VYkOUrqi+ZZXbEa7nzJJTkdMDB3i/Kf/2hXWt89jx
 1I8+jEAvaIUz12SQ5qjeRPpsGTYsyQYco8FewEl0z2lxq3R6gefI2ELSD9dddAr3PMLqSwWO
 kyhxI2wW2E22FGBYTfEr+rP82vuUcQABTJaPUc5oR05D84PSW3ZpjbGVZ5dHaG8lbUZ8hmgk
 mnR/EDSa1j+5PPnNplXH3ia21pARbCTF2bZAzk7uEr/tWuVg6b/OuSVBaDzt6ooEWpgZgDpU
 II4s8af9vsSKpqGiTaARu4AdJnwuarYbGON3AM1Q8B5n9hIx5JFVdoLiN2ZDB00WvvohBezO
 BOD0e+vzMU70ISWgV9fPNvqVpVCIVnIHtX5TPHEBueikbAqHDJrCBpGPBbKt0i0yRBEufhmZ
 f+zLJb9ZV5HWP8P5GfnGI8gPUoDm3lWKZX7HsugkXxKENO2ORaodFvyGAHQNrtgtPvc+m04M
 b93bqO39vmWa8WmCgG/zGLZBQliwaQTbXwul/FqSw==
IronPort-HdrOrdr: A9a23:3Fby46qTUc5nl1ALAvBNyTEaV5opeYIsimQD101hICG8cqSj+f
 xG/c5rrCMc5wxwZJhNo7y90ey7MBbhHP1OkO8s1NWZLWrbUQKTRekIh+bfKn/baknDH4ZmpM
 BdmsNFaeEYY2IUsS+D2njbL+od
X-IronPort-AV: E=Sophos;i="5.88,387,1635220800"; 
   d="scan'208";a="65138983"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v3 33/70] x86/emul: CFI hardening
Date: Tue, 22 Feb 2022 15:26:40 +0000
Message-ID: <20220222152645.8844-11-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220222152645.8844-1-andrew.cooper3@citrix.com>
References: <20220222152645.8844-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

Control Flow Integrity schemes use toolchain and optionally hardware support
to help protect against call/jump/return oriented programming attacks.

Use cf_check to annotate function pointer targets for the toolchain.

pv_emul_is_mem_write() is only used in a single file.  Move it out of its
header file, so it doesn't risk being duplicated in multiple translation
units.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
v2:
 * Correct details in commit message.
v2:
 * Reword again.
---
 xen/arch/x86/hvm/emulate.c             | 72 +++++++++++++++++-----------------
 xen/arch/x86/hvm/hvm.c                 |  8 ++--
 xen/arch/x86/hvm/svm/svm.c             |  4 +-
 xen/arch/x86/include/asm/hvm/emulate.h |  8 ++--
 xen/arch/x86/include/asm/mm.h          | 16 +++-----
 xen/arch/x86/mm.c                      |  4 +-
 xen/arch/x86/mm/shadow/hvm.c           |  8 ++--
 xen/arch/x86/pv/emul-gate-op.c         |  9 +++--
 xen/arch/x86/pv/emul-priv-op.c         | 64 +++++++++++++++---------------
 xen/arch/x86/pv/emulate.h              |  7 ----
 xen/arch/x86/pv/ro-page-fault.c        | 31 +++++++++------
 xen/arch/x86/x86_emulate.c             | 21 +++++-----
 xen/arch/x86/x86_emulate/x86_emulate.c | 10 ++---
 xen/arch/x86/x86_emulate/x86_emulate.h | 33 ++++++++--------
 14 files changed, 148 insertions(+), 147 deletions(-)

diff --git a/xen/arch/x86/hvm/emulate.c b/xen/arch/x86/hvm/emulate.c
index 39dac7fd9d6d..e8d510e0be91 100644
--- a/xen/arch/x86/hvm/emulate.c
+++ b/xen/arch/x86/hvm/emulate.c
@@ -1272,7 +1272,7 @@ static int __hvmemul_read(
     return linear_read(addr, bytes, p_data, pfec, hvmemul_ctxt);
 }
 
-static int hvmemul_read(
+static int cf_check hvmemul_read(
     enum x86_segment seg,
     unsigned long offset,
     void *p_data,
@@ -1290,7 +1290,7 @@ static int hvmemul_read(
         container_of(ctxt, struct hvm_emulate_ctxt, ctxt));
 }
 
-int hvmemul_insn_fetch(
+int cf_check hvmemul_insn_fetch(
     unsigned long offset,
     void *p_data,
     unsigned int bytes,
@@ -1336,7 +1336,7 @@ int hvmemul_insn_fetch(
     return X86EMUL_OKAY;
 }
 
-static int hvmemul_write(
+static int cf_check hvmemul_write(
     enum x86_segment seg,
     unsigned long offset,
     void *p_data,
@@ -1384,7 +1384,7 @@ static int hvmemul_write(
     return X86EMUL_OKAY;
 }
 
-static int hvmemul_rmw(
+static int cf_check hvmemul_rmw(
     enum x86_segment seg,
     unsigned long offset,
     unsigned int bytes,
@@ -1437,7 +1437,7 @@ static int hvmemul_rmw(
     return rc;
 }
 
-static int hvmemul_blk(
+static int cf_check hvmemul_blk(
     enum x86_segment seg,
     unsigned long offset,
     void *p_data,
@@ -1478,7 +1478,7 @@ static int hvmemul_blk(
     return rc;
 }
 
-static int hvmemul_write_discard(
+static int cf_check hvmemul_write_discard(
     enum x86_segment seg,
     unsigned long offset,
     void *p_data,
@@ -1489,7 +1489,7 @@ static int hvmemul_write_discard(
     return X86EMUL_OKAY;
 }
 
-static int hvmemul_rep_ins_discard(
+static int cf_check hvmemul_rep_ins_discard(
     uint16_t src_port,
     enum x86_segment dst_seg,
     unsigned long dst_offset,
@@ -1500,7 +1500,7 @@ static int hvmemul_rep_ins_discard(
     return X86EMUL_OKAY;
 }
 
-static int hvmemul_rep_movs_discard(
+static int cf_check hvmemul_rep_movs_discard(
    enum x86_segment src_seg,
    unsigned long src_offset,
    enum x86_segment dst_seg,
@@ -1512,7 +1512,7 @@ static int hvmemul_rep_movs_discard(
     return X86EMUL_OKAY;
 }
 
-static int hvmemul_rep_stos_discard(
+static int cf_check hvmemul_rep_stos_discard(
     void *p_data,
     enum x86_segment seg,
     unsigned long offset,
@@ -1523,7 +1523,7 @@ static int hvmemul_rep_stos_discard(
     return X86EMUL_OKAY;
 }
 
-static int hvmemul_rep_outs_discard(
+static int cf_check hvmemul_rep_outs_discard(
     enum x86_segment src_seg,
     unsigned long src_offset,
     uint16_t dst_port,
@@ -1534,7 +1534,7 @@ static int hvmemul_rep_outs_discard(
     return X86EMUL_OKAY;
 }
 
-static int hvmemul_cmpxchg_discard(
+static int cf_check hvmemul_cmpxchg_discard(
     enum x86_segment seg,
     unsigned long offset,
     void *p_old,
@@ -1546,7 +1546,7 @@ static int hvmemul_cmpxchg_discard(
     return X86EMUL_OKAY;
 }
 
-static int hvmemul_read_io_discard(
+static int cf_check hvmemul_read_io_discard(
     unsigned int port,
     unsigned int bytes,
     unsigned long *val,
@@ -1555,7 +1555,7 @@ static int hvmemul_read_io_discard(
     return X86EMUL_OKAY;
 }
 
-static int hvmemul_write_io_discard(
+static int cf_check hvmemul_write_io_discard(
     unsigned int port,
     unsigned int bytes,
     unsigned long val,
@@ -1564,7 +1564,7 @@ static int hvmemul_write_io_discard(
     return X86EMUL_OKAY;
 }
 
-static int hvmemul_write_msr_discard(
+static int cf_check hvmemul_write_msr_discard(
     unsigned int reg,
     uint64_t val,
     struct x86_emulate_ctxt *ctxt)
@@ -1572,7 +1572,7 @@ static int hvmemul_write_msr_discard(
     return X86EMUL_OKAY;
 }
 
-static int hvmemul_cache_op_discard(
+static int cf_check hvmemul_cache_op_discard(
     enum x86emul_cache_op op,
     enum x86_segment seg,
     unsigned long offset,
@@ -1581,7 +1581,7 @@ static int hvmemul_cache_op_discard(
     return X86EMUL_OKAY;
 }
 
-static int hvmemul_cmpxchg(
+static int cf_check hvmemul_cmpxchg(
     enum x86_segment seg,
     unsigned long offset,
     void *p_old,
@@ -1675,7 +1675,7 @@ static int hvmemul_cmpxchg(
     return rc;
 }
 
-static int hvmemul_validate(
+static int cf_check hvmemul_validate(
     const struct x86_emulate_state *state,
     struct x86_emulate_ctxt *ctxt)
 {
@@ -1688,7 +1688,7 @@ static int hvmemul_validate(
            ? X86EMUL_OKAY : X86EMUL_UNHANDLEABLE;
 }
 
-static int hvmemul_rep_ins(
+static int cf_check hvmemul_rep_ins(
     uint16_t src_port,
     enum x86_segment dst_seg,
     unsigned long dst_offset,
@@ -1766,7 +1766,7 @@ static int hvmemul_rep_outs_set_context(
     return rc;
 }
 
-static int hvmemul_rep_outs(
+static int cf_check hvmemul_rep_outs(
     enum x86_segment src_seg,
     unsigned long src_offset,
     uint16_t dst_port,
@@ -1807,7 +1807,7 @@ static int hvmemul_rep_outs(
                                !!(ctxt->regs->eflags & X86_EFLAGS_DF), gpa);
 }
 
-static int hvmemul_rep_movs(
+static int cf_check hvmemul_rep_movs(
    enum x86_segment src_seg,
    unsigned long src_offset,
    enum x86_segment dst_seg,
@@ -1977,7 +1977,7 @@ static int hvmemul_rep_movs(
     return X86EMUL_UNHANDLEABLE;
 }
 
-static int hvmemul_rep_stos(
+static int cf_check hvmemul_rep_stos(
     void *p_data,
     enum x86_segment seg,
     unsigned long offset,
@@ -2105,7 +2105,7 @@ static int hvmemul_rep_stos(
     }
 }
 
-static int hvmemul_read_segment(
+static int cf_check hvmemul_read_segment(
     enum x86_segment seg,
     struct segment_register *reg,
     struct x86_emulate_ctxt *ctxt)
@@ -2122,7 +2122,7 @@ static int hvmemul_read_segment(
     return X86EMUL_OKAY;
 }
 
-static int hvmemul_write_segment(
+static int cf_check hvmemul_write_segment(
     enum x86_segment seg,
     const struct segment_register *reg,
     struct x86_emulate_ctxt *ctxt)
@@ -2141,7 +2141,7 @@ static int hvmemul_write_segment(
     return X86EMUL_OKAY;
 }
 
-static int hvmemul_read_io(
+static int cf_check hvmemul_read_io(
     unsigned int port,
     unsigned int bytes,
     unsigned long *val,
@@ -2158,7 +2158,7 @@ static int hvmemul_read_io(
     return hvmemul_do_pio_buffer(port, bytes, IOREQ_READ, val);
 }
 
-static int hvmemul_write_io(
+static int cf_check hvmemul_write_io(
     unsigned int port,
     unsigned int bytes,
     unsigned long val,
@@ -2167,7 +2167,7 @@ static int hvmemul_write_io(
     return hvmemul_do_pio_buffer(port, bytes, IOREQ_WRITE, &val);
 }
 
-static int hvmemul_read_cr(
+static int cf_check hvmemul_read_cr(
     unsigned int reg,
     unsigned long *val,
     struct x86_emulate_ctxt *ctxt)
@@ -2188,7 +2188,7 @@ static int hvmemul_read_cr(
     return X86EMUL_UNHANDLEABLE;
 }
 
-static int hvmemul_write_cr(
+static int cf_check hvmemul_write_cr(
     unsigned int reg,
     unsigned long val,
     struct x86_emulate_ctxt *ctxt)
@@ -2232,7 +2232,7 @@ static int hvmemul_write_cr(
     return rc;
 }
 
-static int hvmemul_read_xcr(
+static int cf_check hvmemul_read_xcr(
     unsigned int reg,
     uint64_t *val,
     struct x86_emulate_ctxt *ctxt)
@@ -2245,7 +2245,7 @@ static int hvmemul_read_xcr(
     return rc;
 }
 
-static int hvmemul_write_xcr(
+static int cf_check hvmemul_write_xcr(
     unsigned int reg,
     uint64_t val,
     struct x86_emulate_ctxt *ctxt)
@@ -2255,7 +2255,7 @@ static int hvmemul_write_xcr(
     return x86emul_write_xcr(reg, val, ctxt);
 }
 
-static int hvmemul_read_msr(
+static int cf_check hvmemul_read_msr(
     unsigned int reg,
     uint64_t *val,
     struct x86_emulate_ctxt *ctxt)
@@ -2268,7 +2268,7 @@ static int hvmemul_read_msr(
     return rc;
 }
 
-static int hvmemul_write_msr(
+static int cf_check hvmemul_write_msr(
     unsigned int reg,
     uint64_t val,
     struct x86_emulate_ctxt *ctxt)
@@ -2281,7 +2281,7 @@ static int hvmemul_write_msr(
     return rc;
 }
 
-static int hvmemul_cache_op(
+static int cf_check hvmemul_cache_op(
     enum x86emul_cache_op op,
     enum x86_segment seg,
     unsigned long offset,
@@ -2353,7 +2353,7 @@ static int hvmemul_cache_op(
     return X86EMUL_OKAY;
 }
 
-static int hvmemul_get_fpu(
+static int cf_check hvmemul_get_fpu(
     enum x86_emulate_fpu_type type,
     struct x86_emulate_ctxt *ctxt)
 {
@@ -2395,7 +2395,7 @@ static int hvmemul_get_fpu(
     return X86EMUL_OKAY;
 }
 
-static void hvmemul_put_fpu(
+static void cf_check hvmemul_put_fpu(
     struct x86_emulate_ctxt *ctxt,
     enum x86_emulate_fpu_type backout,
     const struct x86_emul_fpu_aux *aux)
@@ -2482,7 +2482,7 @@ static void hvmemul_put_fpu(
     }
 }
 
-static int hvmemul_tlb_op(
+static int cf_check hvmemul_tlb_op(
     enum x86emul_tlb_op op,
     unsigned long addr,
     unsigned long aux,
@@ -2539,7 +2539,7 @@ static int hvmemul_tlb_op(
     return rc;
 }
 
-static int hvmemul_vmfunc(
+static int cf_check hvmemul_vmfunc(
     struct x86_emulate_ctxt *ctxt)
 {
     int rc;
diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c
index 9e4924649077..e87e809a945d 100644
--- a/xen/arch/x86/hvm/hvm.c
+++ b/xen/arch/x86/hvm/hvm.c
@@ -3755,8 +3755,8 @@ void hvm_set_reg(struct vcpu *v, unsigned int reg, uint64_t val)
     }
 }
 
-static bool is_sysdesc_access(const struct x86_emulate_state *state,
-                              const struct x86_emulate_ctxt *ctxt)
+static bool cf_check is_sysdesc_access(
+    const struct x86_emulate_state *state, const struct x86_emulate_ctxt *ctxt)
 {
     unsigned int ext;
     int mode = x86_insn_modrm(state, NULL, &ext);
@@ -3796,8 +3796,8 @@ int hvm_descriptor_access_intercept(uint64_t exit_info,
     return X86EMUL_OKAY;
 }
 
-static bool is_cross_vendor(const struct x86_emulate_state *state,
-                            const struct x86_emulate_ctxt *ctxt)
+static bool cf_check is_cross_vendor(
+    const struct x86_emulate_state *state, const struct x86_emulate_ctxt *ctxt)
 {
     switch ( ctxt->opcode )
     {
diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c
index 4c4ebda5e6e4..dedb2848e6a1 100644
--- a/xen/arch/x86/hvm/svm/svm.c
+++ b/xen/arch/x86/hvm/svm/svm.c
@@ -2447,8 +2447,8 @@ static void svm_invlpg_intercept(unsigned long linear)
     paging_invlpg(current, linear);
 }
 
-static bool is_invlpg(const struct x86_emulate_state *state,
-                      const struct x86_emulate_ctxt *ctxt)
+static bool cf_check is_invlpg(
+    const struct x86_emulate_state *state, const struct x86_emulate_ctxt *ctxt)
 {
     unsigned int ext;
 
diff --git a/xen/arch/x86/include/asm/hvm/emulate.h b/xen/arch/x86/include/asm/hvm/emulate.h
index e67004060345..d8ba2df4e4a2 100644
--- a/xen/arch/x86/include/asm/hvm/emulate.h
+++ b/xen/arch/x86/include/asm/hvm/emulate.h
@@ -92,10 +92,10 @@ static inline bool handle_mmio(void)
     return hvm_emulate_one_insn(x86_insn_is_mem_access, "MMIO");
 }
 
-int hvmemul_insn_fetch(unsigned long offset,
-                       void *p_data,
-                       unsigned int bytes,
-                       struct x86_emulate_ctxt *ctxt);
+int cf_check hvmemul_insn_fetch(
+    unsigned long offset, void *p_data, unsigned int bytes,
+    struct x86_emulate_ctxt *ctxt);
+
 int hvmemul_do_pio_buffer(uint16_t port,
                           unsigned int size,
                           uint8_t dir,
diff --git a/xen/arch/x86/include/asm/mm.h b/xen/arch/x86/include/asm/mm.h
index bdde24d2cec3..f2f7b6902ce4 100644
--- a/xen/arch/x86/include/asm/mm.h
+++ b/xen/arch/x86/include/asm/mm.h
@@ -538,16 +538,12 @@ struct mmio_ro_emulate_ctxt {
         unsigned int seg, bdf;
 };
 
-extern int mmio_ro_emulated_write(enum x86_segment seg,
-                                  unsigned long offset,
-                                  void *p_data,
-                                  unsigned int bytes,
-                                  struct x86_emulate_ctxt *ctxt);
-extern int mmcfg_intercept_write(enum x86_segment seg,
-                                 unsigned long offset,
-                                 void *p_data,
-                                 unsigned int bytes,
-                                 struct x86_emulate_ctxt *ctxt);
+int cf_check mmio_ro_emulated_write(
+    enum x86_segment seg, unsigned long offset, void *p_data,
+    unsigned int bytes, struct x86_emulate_ctxt *ctxt);
+int cf_check mmcfg_intercept_write(
+    enum x86_segment seg, unsigned long offset, void *p_data,
+    unsigned int bytes, struct x86_emulate_ctxt *ctxt);
 
 int audit_adjust_pgtables(struct domain *d, int dir, int noisy);
 
diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c
index 0665095d2309..2befd0c191ae 100644
--- a/xen/arch/x86/mm.c
+++ b/xen/arch/x86/mm.c
@@ -4852,7 +4852,7 @@ long arch_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
     return 0;
 }
 
-int mmio_ro_emulated_write(
+int cf_check mmio_ro_emulated_write(
     enum x86_segment seg,
     unsigned long offset,
     void *p_data,
@@ -4873,7 +4873,7 @@ int mmio_ro_emulated_write(
     return X86EMUL_OKAY;
 }
 
-int mmcfg_intercept_write(
+int cf_check mmcfg_intercept_write(
     enum x86_segment seg,
     unsigned long offset,
     void *p_data,
diff --git a/xen/arch/x86/mm/shadow/hvm.c b/xen/arch/x86/mm/shadow/hvm.c
index f2991bc176f0..c90d326becb3 100644
--- a/xen/arch/x86/mm/shadow/hvm.c
+++ b/xen/arch/x86/mm/shadow/hvm.c
@@ -148,7 +148,7 @@ hvm_read(enum x86_segment seg,
     return X86EMUL_UNHANDLEABLE;
 }
 
-static int
+static int cf_check
 hvm_emulate_read(enum x86_segment seg,
                  unsigned long offset,
                  void *p_data,
@@ -161,7 +161,7 @@ hvm_emulate_read(enum x86_segment seg,
                     container_of(ctxt, struct sh_emulate_ctxt, ctxt));
 }
 
-static int
+static int cf_check
 hvm_emulate_insn_fetch(unsigned long offset,
                        void *p_data,
                        unsigned int bytes,
@@ -181,7 +181,7 @@ hvm_emulate_insn_fetch(unsigned long offset,
     return X86EMUL_OKAY;
 }
 
-static int
+static int cf_check
 hvm_emulate_write(enum x86_segment seg,
                   unsigned long offset,
                   void *p_data,
@@ -234,7 +234,7 @@ hvm_emulate_write(enum x86_segment seg,
     return X86EMUL_OKAY;
 }
 
-static int
+static int cf_check
 hvm_emulate_cmpxchg(enum x86_segment seg,
                     unsigned long offset,
                     void *p_old,
diff --git a/xen/arch/x86/pv/emul-gate-op.c b/xen/arch/x86/pv/emul-gate-op.c
index 68ec4d11f6bb..758a20ad9df4 100644
--- a/xen/arch/x86/pv/emul-gate-op.c
+++ b/xen/arch/x86/pv/emul-gate-op.c
@@ -96,8 +96,9 @@ struct gate_op_ctxt {
     bool insn_fetch;
 };
 
-static int read_mem(enum x86_segment seg, unsigned long offset, void *p_data,
-                    unsigned int bytes, struct x86_emulate_ctxt *ctxt)
+static int cf_check read_mem(
+    enum x86_segment seg, unsigned long offset, void *p_data,
+    unsigned int bytes, struct x86_emulate_ctxt *ctxt)
 {
     const struct gate_op_ctxt *goc =
         container_of(ctxt, struct gate_op_ctxt, ctxt);
@@ -163,8 +164,8 @@ static int read_mem(enum x86_segment seg, unsigned long offset, void *p_data,
     return X86EMUL_OKAY;
 }
 
-static int fetch(unsigned long offset, void *p_data,
-                 unsigned int bytes, struct x86_emulate_ctxt *ctxt)
+static int cf_check fetch(unsigned long offset, void *p_data,
+                          unsigned int bytes, struct x86_emulate_ctxt *ctxt)
 {
     return read_mem(x86_seg_cs, offset, p_data, bytes, ctxt);
 }
diff --git a/xen/arch/x86/pv/emul-priv-op.c b/xen/arch/x86/pv/emul-priv-op.c
index c78be6d92b21..c46c072f93db 100644
--- a/xen/arch/x86/pv/emul-priv-op.c
+++ b/xen/arch/x86/pv/emul-priv-op.c
@@ -358,8 +358,9 @@ static unsigned int check_guest_io_breakpoint(struct vcpu *v,
     return match;
 }
 
-static int read_io(unsigned int port, unsigned int bytes,
-                   unsigned long *val, struct x86_emulate_ctxt *ctxt)
+static int cf_check read_io(
+    unsigned int port, unsigned int bytes, unsigned long *val,
+    struct x86_emulate_ctxt *ctxt)
 {
     struct priv_op_ctxt *poc = container_of(ctxt, struct priv_op_ctxt, ctxt);
     struct vcpu *curr = current;
@@ -462,8 +463,9 @@ static void guest_io_write(unsigned int port, unsigned int bytes,
     }
 }
 
-static int write_io(unsigned int port, unsigned int bytes,
-                    unsigned long val, struct x86_emulate_ctxt *ctxt)
+static int cf_check write_io(
+    unsigned int port, unsigned int bytes, unsigned long val,
+    struct x86_emulate_ctxt *ctxt)
 {
     struct priv_op_ctxt *poc = container_of(ctxt, struct priv_op_ctxt, ctxt);
     struct vcpu *curr = current;
@@ -493,9 +495,9 @@ static int write_io(unsigned int port, unsigned int bytes,
     return X86EMUL_OKAY;
 }
 
-static int read_segment(enum x86_segment seg,
-                        struct segment_register *reg,
-                        struct x86_emulate_ctxt *ctxt)
+static int cf_check read_segment(
+    enum x86_segment seg, struct segment_register *reg,
+    struct x86_emulate_ctxt *ctxt)
 {
     /* Check if this is an attempt to access the I/O bitmap. */
     if ( seg == x86_seg_tr )
@@ -607,10 +609,10 @@ static int pv_emul_virt_to_linear(unsigned long base, unsigned long offset,
     return rc;
 }
 
-static int rep_ins(uint16_t port,
-                   enum x86_segment seg, unsigned long offset,
-                   unsigned int bytes_per_rep, unsigned long *reps,
-                   struct x86_emulate_ctxt *ctxt)
+static int cf_check rep_ins(
+    uint16_t port, enum x86_segment seg, unsigned long offset,
+    unsigned int bytes_per_rep, unsigned long *reps,
+    struct x86_emulate_ctxt *ctxt)
 {
     struct priv_op_ctxt *poc = container_of(ctxt, struct priv_op_ctxt, ctxt);
     struct vcpu *curr = current;
@@ -675,10 +677,10 @@ static int rep_ins(uint16_t port,
     return X86EMUL_OKAY;
 }
 
-static int rep_outs(enum x86_segment seg, unsigned long offset,
-                    uint16_t port,
-                    unsigned int bytes_per_rep, unsigned long *reps,
-                    struct x86_emulate_ctxt *ctxt)
+static int cf_check rep_outs(
+    enum x86_segment seg, unsigned long offset, uint16_t port,
+    unsigned int bytes_per_rep, unsigned long *reps,
+    struct x86_emulate_ctxt *ctxt)
 {
     struct priv_op_ctxt *poc = container_of(ctxt, struct priv_op_ctxt, ctxt);
     struct vcpu *curr = current;
@@ -744,8 +746,8 @@ static int rep_outs(enum x86_segment seg, unsigned long offset,
     return X86EMUL_OKAY;
 }
 
-static int read_cr(unsigned int reg, unsigned long *val,
-                   struct x86_emulate_ctxt *ctxt)
+static int cf_check read_cr(
+    unsigned int reg, unsigned long *val, struct x86_emulate_ctxt *ctxt)
 {
     const struct vcpu *curr = current;
 
@@ -787,8 +789,8 @@ static int read_cr(unsigned int reg, unsigned long *val,
     return X86EMUL_UNHANDLEABLE;
 }
 
-static int write_cr(unsigned int reg, unsigned long val,
-                    struct x86_emulate_ctxt *ctxt)
+static int cf_check write_cr(
+    unsigned int reg, unsigned long val, struct x86_emulate_ctxt *ctxt)
 {
     struct vcpu *curr = current;
 
@@ -871,8 +873,8 @@ static uint64_t guest_efer(const struct domain *d)
     return val;
 }
 
-static int read_msr(unsigned int reg, uint64_t *val,
-                    struct x86_emulate_ctxt *ctxt)
+static int cf_check read_msr(
+    unsigned int reg, uint64_t *val, struct x86_emulate_ctxt *ctxt)
 {
     struct vcpu *curr = current;
     const struct domain *currd = curr->domain;
@@ -1020,8 +1022,8 @@ static int read_msr(unsigned int reg, uint64_t *val,
     return ret;
 }
 
-static int write_msr(unsigned int reg, uint64_t val,
-                     struct x86_emulate_ctxt *ctxt)
+static int cf_check write_msr(
+    unsigned int reg, uint64_t val, struct x86_emulate_ctxt *ctxt)
 {
     struct vcpu *curr = current;
     const struct domain *currd = curr->domain;
@@ -1188,8 +1190,9 @@ static int write_msr(unsigned int reg, uint64_t val,
     return X86EMUL_UNHANDLEABLE;
 }
 
-static int cache_op(enum x86emul_cache_op op, enum x86_segment seg,
-                    unsigned long offset, struct x86_emulate_ctxt *ctxt)
+static int cf_check cache_op(
+    enum x86emul_cache_op op, enum x86_segment seg,
+    unsigned long offset, struct x86_emulate_ctxt *ctxt)
 {
     ASSERT(op == x86emul_wbinvd || op == x86emul_wbnoinvd);
 
@@ -1208,8 +1211,8 @@ static int cache_op(enum x86emul_cache_op op, enum x86_segment seg,
     return X86EMUL_OKAY;
 }
 
-static int validate(const struct x86_emulate_state *state,
-                    struct x86_emulate_ctxt *ctxt)
+static int cf_check validate(
+    const struct x86_emulate_state *state, struct x86_emulate_ctxt *ctxt)
 {
     switch ( ctxt->opcode )
     {
@@ -1258,10 +1261,9 @@ static int validate(const struct x86_emulate_state *state,
     return X86EMUL_UNHANDLEABLE;
 }
 
-static int insn_fetch(unsigned long offset,
-                      void *p_data,
-                      unsigned int bytes,
-                      struct x86_emulate_ctxt *ctxt)
+static int cf_check insn_fetch(
+    unsigned long offset, void *p_data, unsigned int bytes,
+    struct x86_emulate_ctxt *ctxt)
 {
     const struct priv_op_ctxt *poc =
         container_of(ctxt, struct priv_op_ctxt, ctxt);
diff --git a/xen/arch/x86/pv/emulate.h b/xen/arch/x86/pv/emulate.h
index 4b845b08e372..49a4d34832df 100644
--- a/xen/arch/x86/pv/emulate.h
+++ b/xen/arch/x86/pv/emulate.h
@@ -12,13 +12,6 @@ int pv_emul_read_descriptor(unsigned int sel, const struct vcpu *v,
 
 void pv_emul_instruction_done(struct cpu_user_regs *regs, unsigned long rip);
 
-static inline int pv_emul_is_mem_write(const struct x86_emulate_state *state,
-                                       struct x86_emulate_ctxt *ctxt)
-{
-    return x86_insn_is_mem_write(state, ctxt) ? X86EMUL_OKAY
-                                              : X86EMUL_UNHANDLEABLE;
-}
-
 /* Return a pointer to the GDT/LDT descriptor referenced by sel. */
 static inline const seg_desc_t *gdt_ldt_desc_ptr(unsigned int sel)
 {
diff --git a/xen/arch/x86/pv/ro-page-fault.c b/xen/arch/x86/pv/ro-page-fault.c
index ef4d146c1d9e..5963f5ee2d51 100644
--- a/xen/arch/x86/pv/ro-page-fault.c
+++ b/xen/arch/x86/pv/ro-page-fault.c
@@ -26,6 +26,13 @@
 #include "emulate.h"
 #include "mm.h"
 
+static int cf_check pv_emul_is_mem_write(
+    const struct x86_emulate_state *state, struct x86_emulate_ctxt *ctxt)
+{
+    return x86_insn_is_mem_write(state, ctxt) ? X86EMUL_OKAY
+                                              : X86EMUL_UNHANDLEABLE;
+}
+
 /*********************
  * Writable Pagetables
  */
@@ -35,9 +42,9 @@ struct ptwr_emulate_ctxt {
     l1_pgentry_t  pte;
 };
 
-static int ptwr_emulated_read(enum x86_segment seg, unsigned long offset,
-                              void *p_data, unsigned int bytes,
-                              struct x86_emulate_ctxt *ctxt)
+static int cf_check ptwr_emulated_read(
+    enum x86_segment seg, unsigned long offset, void *p_data,
+    unsigned int bytes, struct x86_emulate_ctxt *ctxt)
 {
     unsigned int rc = bytes;
     unsigned long addr = offset;
@@ -52,9 +59,9 @@ static int ptwr_emulated_read(enum x86_segment seg, unsigned long offset,
     return X86EMUL_OKAY;
 }
 
-static int ptwr_emulated_insn_fetch(unsigned long offset,
-                                    void *p_data, unsigned int bytes,
-                                    struct x86_emulate_ctxt *ctxt)
+static int cf_check ptwr_emulated_insn_fetch(
+    unsigned long offset, void *p_data, unsigned int bytes,
+    struct x86_emulate_ctxt *ctxt)
 {
     unsigned int rc = copy_from_guest_pv(p_data, (void *)offset, bytes);
 
@@ -218,9 +225,9 @@ static int ptwr_emulated_update(unsigned long addr, intpte_t *p_old,
     return X86EMUL_OKAY;
 }
 
-static int ptwr_emulated_write(enum x86_segment seg, unsigned long offset,
-                               void *p_data, unsigned int bytes,
-                               struct x86_emulate_ctxt *ctxt)
+static int cf_check ptwr_emulated_write(
+    enum x86_segment seg, unsigned long offset, void *p_data,
+    unsigned int bytes, struct x86_emulate_ctxt *ctxt)
 {
     intpte_t val = 0;
 
@@ -236,9 +243,9 @@ static int ptwr_emulated_write(enum x86_segment seg, unsigned long offset,
     return ptwr_emulated_update(offset, NULL, val, bytes, ctxt);
 }
 
-static int ptwr_emulated_cmpxchg(enum x86_segment seg, unsigned long offset,
-                                 void *p_old, void *p_new, unsigned int bytes,
-                                 bool lock, struct x86_emulate_ctxt *ctxt)
+static int cf_check ptwr_emulated_cmpxchg(
+    enum x86_segment seg, unsigned long offset, void *p_old, void *p_new,
+    unsigned int bytes, bool lock, struct x86_emulate_ctxt *ctxt)
 {
     intpte_t old = 0, new = 0;
     int rc;
diff --git a/xen/arch/x86/x86_emulate.c b/xen/arch/x86/x86_emulate.c
index 1e082e6f3b2d..60191a94dc18 100644
--- a/xen/arch/x86/x86_emulate.c
+++ b/xen/arch/x86/x86_emulate.c
@@ -53,8 +53,8 @@
 
 #include "x86_emulate/x86_emulate.c"
 
-int x86emul_read_xcr(unsigned int reg, uint64_t *val,
-                     struct x86_emulate_ctxt *ctxt)
+int cf_check x86emul_read_xcr(
+    unsigned int reg, uint64_t *val, struct x86_emulate_ctxt *ctxt)
 {
     switch ( reg )
     {
@@ -77,8 +77,8 @@ int x86emul_read_xcr(unsigned int reg, uint64_t *val,
 }
 
 /* Note: May be called with ctxt=NULL. */
-int x86emul_write_xcr(unsigned int reg, uint64_t val,
-                      struct x86_emulate_ctxt *ctxt)
+int cf_check x86emul_write_xcr(
+    unsigned int reg, uint64_t val, struct x86_emulate_ctxt *ctxt)
 {
     switch ( reg )
     {
@@ -100,8 +100,8 @@ int x86emul_write_xcr(unsigned int reg, uint64_t val,
 
 #ifdef CONFIG_PV
 /* Called with NULL ctxt in hypercall context. */
-int x86emul_read_dr(unsigned int reg, unsigned long *val,
-                    struct x86_emulate_ctxt *ctxt)
+int cf_check x86emul_read_dr(
+    unsigned int reg, unsigned long *val, struct x86_emulate_ctxt *ctxt)
 {
     struct vcpu *curr = current;
 
@@ -143,8 +143,8 @@ int x86emul_read_dr(unsigned int reg, unsigned long *val,
     return X86EMUL_OKAY;
 }
 
-int x86emul_write_dr(unsigned int reg, unsigned long val,
-                     struct x86_emulate_ctxt *ctxt)
+int cf_check x86emul_write_dr(
+    unsigned int reg, unsigned long val, struct x86_emulate_ctxt *ctxt)
 {
     struct vcpu *curr = current;
 
@@ -167,8 +167,9 @@ int x86emul_write_dr(unsigned int reg, unsigned long val,
 }
 #endif /* CONFIG_PV */
 
-int x86emul_cpuid(uint32_t leaf, uint32_t subleaf,
-                  struct cpuid_leaf *res, struct x86_emulate_ctxt *ctxt)
+int cf_check x86emul_cpuid(
+    uint32_t leaf, uint32_t subleaf, struct cpuid_leaf *res,
+    struct x86_emulate_ctxt *ctxt)
 {
     guest_cpuid(current, leaf, subleaf, res);
 
diff --git a/xen/arch/x86/x86_emulate/x86_emulate.c b/xen/arch/x86/x86_emulate/x86_emulate.c
index 2ba54c61511c..6c0d18954a5f 100644
--- a/xen/arch/x86/x86_emulate/x86_emulate.c
+++ b/xen/arch/x86/x86_emulate/x86_emulate.c
@@ -2524,7 +2524,7 @@ static void adjust_bnd(struct x86_emulate_ctxt *ctxt,
  done:;
 }
 
-int x86emul_unhandleable_rw(
+int cf_check x86emul_unhandleable_rw(
     enum x86_segment seg,
     unsigned long offset,
     void *p_data,
@@ -12320,7 +12320,7 @@ x86_insn_operand_ea(const struct x86_emulate_state *state,
  * memory operand (like POP), but it does not mean e.g. segment selector
  * loads, where the descriptor table access is considered an implicit one.
  */
-bool
+bool cf_check
 x86_insn_is_mem_access(const struct x86_emulate_state *state,
                        const struct x86_emulate_ctxt *ctxt)
 {
@@ -12412,7 +12412,7 @@ x86_insn_is_mem_access(const struct x86_emulate_state *state,
  * loads, where the (possible) descriptor table write is considered an
  * implicit access.
  */
-bool
+bool cf_check
 x86_insn_is_mem_write(const struct x86_emulate_state *state,
                       const struct x86_emulate_ctxt *ctxt)
 {
@@ -12584,7 +12584,7 @@ x86_insn_is_mem_write(const struct x86_emulate_state *state,
     return false;
 }
 
-bool
+bool cf_check
 x86_insn_is_portio(const struct x86_emulate_state *state,
                    const struct x86_emulate_ctxt *ctxt)
 {
@@ -12599,7 +12599,7 @@ x86_insn_is_portio(const struct x86_emulate_state *state,
     return false;
 }
 
-bool
+bool cf_check
 x86_insn_is_cr_access(const struct x86_emulate_state *state,
                       const struct x86_emulate_ctxt *ctxt)
 {
diff --git a/xen/arch/x86/x86_emulate/x86_emulate.h b/xen/arch/x86/x86_emulate/x86_emulate.h
index 419def8790a0..4732855c40ed 100644
--- a/xen/arch/x86/x86_emulate/x86_emulate.h
+++ b/xen/arch/x86/x86_emulate/x86_emulate.h
@@ -737,7 +737,7 @@ static inline unsigned long *decode_gpr(struct cpu_user_regs *regs,
 }
 
 /* Unhandleable read, write or instruction fetch */
-int
+int cf_check
 x86emul_unhandleable_rw(
     enum x86_segment seg,
     unsigned long offset,
@@ -766,16 +766,16 @@ x86_insn_immediate(const struct x86_emulate_state *state,
 unsigned int
 x86_insn_length(const struct x86_emulate_state *state,
                 const struct x86_emulate_ctxt *ctxt);
-bool
+bool cf_check
 x86_insn_is_mem_access(const struct x86_emulate_state *state,
                        const struct x86_emulate_ctxt *ctxt);
-bool
+bool cf_check
 x86_insn_is_mem_write(const struct x86_emulate_state *state,
                       const struct x86_emulate_ctxt *ctxt);
-bool
+bool cf_check
 x86_insn_is_portio(const struct x86_emulate_state *state,
                    const struct x86_emulate_ctxt *ctxt);
-bool
+bool cf_check
 x86_insn_is_cr_access(const struct x86_emulate_state *state,
                       const struct x86_emulate_ctxt *ctxt);
 
@@ -787,17 +787,18 @@ void x86_emulate_free_state(struct x86_emulate_state *state);
 
 #ifdef __XEN__
 
-int x86emul_read_xcr(unsigned int reg, uint64_t *val,
-                     struct x86_emulate_ctxt *ctxt);
-int x86emul_write_xcr(unsigned int reg, uint64_t val,
-                      struct x86_emulate_ctxt *ctxt);
-
-int x86emul_read_dr(unsigned int reg, unsigned long *val,
-                    struct x86_emulate_ctxt *ctxt);
-int x86emul_write_dr(unsigned int reg, unsigned long val,
-                     struct x86_emulate_ctxt *ctxt);
-int x86emul_cpuid(uint32_t leaf, uint32_t subleaf,
-                  struct cpuid_leaf *res, struct x86_emulate_ctxt *ctxt);
+int cf_check x86emul_read_xcr(
+    unsigned int reg, uint64_t *val, struct x86_emulate_ctxt *ctxt);
+int cf_check x86emul_write_xcr(
+    unsigned int reg, uint64_t val, struct x86_emulate_ctxt *ctxt);
+
+int cf_check x86emul_read_dr(
+    unsigned int reg, unsigned long *val, struct x86_emulate_ctxt *ctxt);
+int cf_check x86emul_write_dr(
+    unsigned int reg, unsigned long val, struct x86_emulate_ctxt *ctxt);
+int cf_check x86emul_cpuid(
+    uint32_t leaf, uint32_t subleaf, struct cpuid_leaf *res,
+    struct x86_emulate_ctxt *ctxt);
 
 #endif
 
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Tue Feb 22 15:35:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 15:35:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276926.473326 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMXBx-0006Eq-5C; Tue, 22 Feb 2022 15:35:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276926.473326; Tue, 22 Feb 2022 15:35:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMXBx-0006Eh-13; Tue, 22 Feb 2022 15:35:05 +0000
Received: by outflank-mailman (input) for mailman id 276926;
 Tue, 22 Feb 2022 15:35:03 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Woib=TF=citrix.com=prvs=045a4fa17=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nMXBv-0005NF-3g
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 15:35:03 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ffb73fde-93f4-11ec-8eb8-a37418f5ba1a;
 Tue, 22 Feb 2022 16:35:01 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ffb73fde-93f4-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645544101;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=h8j452T6Tw+1j6rlogEw/+HJLpPlGl8BUaxfVL2dCbE=;
  b=Mjz3mXhiwaMeE6vSglPaG7+k8Y0IIUAbVByOVxqXnJcBbWnHzOw2NInL
   TRBJnJBEQ1LUOXX42D3P5G9F4WNxpLKBs0x1sFcKNgkry3Nyy5TnBXBig
   S2NpPH58Tz2w/77WF2lXCV5POWsDvQBtb9ab2pmCtIphtHnM7KRGTaX8x
   Q=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 65138991
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:S4p2+a6PMK1nfApL6JsZmQxRtBzHchMFZxGqfqrLsTDasY5as4F+v
 mMaWm3TaK6CMGGjc41xPIS18k8Cvp7Xz9IySgU5qCtjHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFx2XqPp8Zj2tQy2YLjWVvX0
 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X
 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx
 umhurThEF4gJI+Lut00dDN6T3p1AYh23pn+dC3XXcy7lyUqclPpyvRqSko3IZcZ6qB8BmQmG
 f4wcW5XKErZ3qTvnez9GrIEascLdaEHOKs2vH16wC6fJvEhWZ3ZGI3B5MNC3Sd2jcdLdRrbT
 5REMGE/PUWZC/FJEmUNCJ0sp96Mvz6hbQBn9F+Sl7IW23eGmWSd15CyaYGIK7RmX/59vGyVu
 2bH9GTRGQwBOZqUzj/t2m2orv/Cm2X8Qo16PK218LtmjUOewkQXCQYKTh2rrP+hkEm8VtlDb
 UsO9UIGqKEo8UWxQ9rVXhumoWWFtBoRR9pRFeIh7AiHjKHT5m6k6nMsF2AbLoZ87YlvGGJsh
 gThc87V6SJH4eTMQGi/sZWthBSYG3ROJlMnVQkidF5QizX8m70bghXKR9dlNae6iNzpBD39q
 wy3QDgCa6Y71pBSifjilbzTq3f1/8WSEFZpjunCdj/9tmtEiJiZi5tEALQxxdJJN86nQ1aIp
 xDocODOvblVXflheMFgKdjh/Y1FBd7YaFUwYnY1RvHNEghBHVb5Jui8BxkkeS9U3j4sI2OBX
 aMqkVo5CGVvFHWrd7RrRIm6Ft4ny6Ptffy8CKyJMoQfP8UrKFbflM2LWaJ29zq2+KTLuftiU
 ap3jO72VSpKYUiZ5GDeqxghPU8DmXllmDK7qWHTxBW7y7uODEN5up9eWGZimtsRtfveyC2Mq
 o43H5LTl313Db2vCgGKoNV7BQ1bchAG6WXe9pU/mhireVE9RgnMypb5nNscRmCSt/4LzryRp
 inlACe1CjPX3BX6FOlDUVg7AJuHYHq1hStT0fAEVbpw50UeXA==
IronPort-HdrOrdr: A9a23:TQC3V64sn5kqz2+WCQPXwPDXdLJyesId70hD6qhwISY6TiX+rb
 HWoB17726TtN9/YhEdcLy7VJVoBEmskKKdgrNhWotKPjOW21dARbsKheCJrgEIWReOktK1vZ
 0QC5SWY+eQMbEVt6nHCXGDYrQd/OU=
X-IronPort-AV: E=Sophos;i="5.88,387,1635220800"; 
   d="scan'208";a="65138991"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?=
	<marmarek@invisiblethingslab.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	Jan Beulich <JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>
Subject: [PATCH v3 60/70] x86: Build check for embedded endbr64 instructions
Date: Tue, 22 Feb 2022 15:26:44 +0000
Message-ID: <20220222152645.8844-15-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220222152645.8844-1-andrew.cooper3@citrix.com>
References: <20220222152645.8844-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

From: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>

An interesting corner case occurs when the byte sequence making up endb64 ends
up on a non-instruction boundary.  Such embedded instructions mark legal
indirect branch targets as far as the CPU is concerned, which aren't legal as
far as the logic is concerned.

When CET-IBT is active, check for embedded byte sequences.  Example failures
look like:

  check-endbr.sh xen-syms Fail: Found 2 embedded endbr64 instructions
  0xffff82d040325677: test_endbr64 at /local/xen.git/xen/arch/x86/x86_64/entry.S:28
  0xffff82d040352da6: init_done at /local/xen.git/xen/arch/x86/setup.c:675

Signed-off-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>

v2:
 * New
v3:
 * Reposition to the end of the cf_check-ing, to retain bisectability
 * Reword commit message to explain 'embedded'
 * Use ${ADDR2LINE} if present in the environment
 * Use objdump -w
 * Explain the use of octal
 * Check the EFI build too.  Reposition to be last action, so all build
   artefacts remain in a failure case
 * Check for grep support and warn if missing
 * Replace strtonum() with int() to avoid gaining a gawk dependency
 * Replace `join` with `sort | uniq` to avoid adding a coreutils dependency
---
 README                   |  1 +
 xen/arch/x86/Makefile    |  6 ++++
 xen/tools/check-endbr.sh | 85 ++++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 92 insertions(+)
 create mode 100755 xen/tools/check-endbr.sh

diff --git a/README b/README
index 562b80808033..5e55047ffd9e 100644
--- a/README
+++ b/README
@@ -68,6 +68,7 @@ provided by your OS distributor:
 In addition to the above there are a number of optional build
 prerequisites. Omitting these will cause the related features to be
 disabled at compile time:
+    * Binary-search capable grep (if building Xen with CET support)
     * Development install of Ocaml (e.g. ocaml-nox and
       ocaml-findlib). Required to build ocaml components which
       includes the alternative ocaml xenstored.
diff --git a/xen/arch/x86/Makefile b/xen/arch/x86/Makefile
index db97ae8c07f0..b90146b75636 100644
--- a/xen/arch/x86/Makefile
+++ b/xen/arch/x86/Makefile
@@ -142,6 +142,9 @@ $(TARGET)-syms: $(BASEDIR)/prelink.o $(obj)/xen.lds
 		| $(BASEDIR)/tools/symbols --all-symbols --xensyms --sysv --sort \
 		>$(@D)/$(@F).map
 	rm -f $(@D)/.$(@F).[0-9]* $(@D)/..$(@F).[0-9]*
+ifeq ($(CONFIG_XEN_IBT),y)
+	$(SHELL) $(BASEDIR)/tools/check-endbr.sh $@
+endif
 
 $(obj)/note.o: $(TARGET)-syms
 	$(OBJCOPY) -O binary --only-section=.note.gnu.build-id $< $@.bin
@@ -212,6 +215,9 @@ endif
 	$(NM) -pa --format=sysv $(@D)/$(@F) \
 		| $(BASEDIR)/tools/symbols --all-symbols --xensyms --sysv --sort >$(@D)/$(@F).map
 	rm -f $(@D)/.$(@F).[0-9]* $(@D)/..$(@F).[0-9]*
+ifeq ($(CONFIG_XEN_IBT),y)
+	$(SHELL) $(BASEDIR)/tools/check-endbr.sh $@
+endif
 else
 $(TARGET).efi: FORCE
 	rm -f $@
diff --git a/xen/tools/check-endbr.sh b/xen/tools/check-endbr.sh
new file mode 100755
index 000000000000..85878353112a
--- /dev/null
+++ b/xen/tools/check-endbr.sh
@@ -0,0 +1,85 @@
+#!/bin/sh
+#
+# Usage ./$0 xen-syms
+#
+set -e
+
+# Prettyprint parameters a little for message
+MSG_PFX="${0##*/} ${1##*/}"
+
+OBJCOPY="${OBJCOPY:-objcopy} -j .text $1"
+OBJDUMP="${OBJDUMP:-objdump} -j .text $1"
+ADDR2LINE="${ADDR2LINE:-addr2line}"
+
+D=$(mktemp -d)
+trap "rm -rf $D" EXIT
+
+TEXT_BIN=$D/xen-syms.text
+VALID=$D/valid-addrs
+ALL=$D/all-addrs
+BAD=$D/bad-addrs
+
+# Check that grep can do binary searches.  Some, e.g. busybox, can't.  Leave a
+# warning but don't fail the build.
+echo "X" | grep -aob "X" -q 2>/dev/null ||
+    { echo "$MSG_PFX Warning: grep can't do binary searches" >&2; exit 0; }
+
+#
+# First, look for all the valid endbr64 instructions.
+# A worst-case disassembly, viewed through cat -A, may look like:
+#
+# ffff82d040337bd4 <endbr64>:$
+# ffff82d040337bd4:^If3 0f 1e fa          ^Iendbr64 $
+# ffff82d040337bd8:^Ieb fe                ^Ijmp    ffff82d040337bd8 <endbr64+0x4>$
+# ffff82d040337bda:^Ib8 f3 0f 1e fa       ^Imov    $0xfa1e0ff3,%eax$
+#
+# Want to grab the address of endbr64 instructions only, ignoring function
+# names/jump labels/etc, so look for 'endbr64' preceeded by a tab and with any
+# number of trailing spaces before the end of the line.
+#
+${OBJDUMP} -d -w | grep '	endbr64 *$' | cut -f 1 -d ':' > $VALID &
+
+#
+# Second, look for any endbr64 byte sequence
+# This has a couple of complications:
+#
+# 1) Grep binary search isn't VMA aware.  Copy .text out as binary, causing
+#    the grep offset to be from the start of .text.
+#
+# 2) dash's printf doesn't understand hex escapes, hence the use of octal.
+#
+# 3) AWK can't add 64bit integers, because internally all numbers are doubles.
+#    When the upper bits are set, the exponents worth of precision is lost in
+#    the lower bits, rounding integers to the nearest 4k.
+#
+#    Instead, use the fact that Xen's .text is within a 1G aligned region, and
+#    split the VMA in half so AWK's numeric addition is only working on 32 bit
+#    numbers, which don't lose precision.
+#
+eval $(${OBJDUMP} -h | awk '$2 == ".text" {printf "vma_hi=%s\nvma_lo=%s\n", substr($4, 1, 8), substr($4, 9, 16)}')
+
+${OBJCOPY} -O binary $TEXT_BIN
+grep -aob "$(printf '\363\17\36\372')" $TEXT_BIN |
+    awk -F':' '{printf "%s%x\n", "'$vma_hi'", int(0x'$vma_lo') + $1}' > $ALL
+
+# Wait for $VALID to become complete
+wait
+
+# Sanity check $VALID and $ALL, in case the string parsing bitrots
+val_sz=$(stat -c '%s' $VALID)
+all_sz=$(stat -c '%s' $ALL)
+[ "$val_sz" -eq 0 ]         && { echo "$MSG_PFX Error: Empty valid-addrs" >&2; exit 1; }
+[ "$all_sz" -eq 0 ]         && { echo "$MSG_PFX Error: Empty all-addrs" >&2; exit 1; }
+[ "$all_sz" -lt "$val_sz" ] && { echo "$MSG_PFX Error: More valid-addrs than all-addrs" >&2; exit 1; }
+
+# $BAD = $ALL - $VALID
+sort $VALID $ALL | uniq -u > $BAD
+nr_bad=$(wc -l < $BAD)
+
+# Success
+[ "$nr_bad" -eq 0 ] && exit 0
+
+# Failure
+echo "$MSG_PFX Fail: Found ${nr_bad} embedded endbr64 instructions" >&2
+${ADDR2LINE} -afip -e $1 < $BAD >&2
+exit 1
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Tue Feb 22 15:35:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 15:35:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276937.473337 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMXCD-0007DB-GW; Tue, 22 Feb 2022 15:35:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276937.473337; Tue, 22 Feb 2022 15:35:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMXCD-0007D2-C9; Tue, 22 Feb 2022 15:35:21 +0000
Received: by outflank-mailman (input) for mailman id 276937;
 Tue, 22 Feb 2022 15:35:20 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Woib=TF=citrix.com=prvs=045a4fa17=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nMXCC-0005NF-6f
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 15:35:20 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 09049ed6-93f5-11ec-8eb8-a37418f5ba1a;
 Tue, 22 Feb 2022 16:35:18 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 09049ed6-93f5-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645544118;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=9BMxMs0/UjXMNi6oqpZA+0tBs6ppueg9ifVrUwTcBD8=;
  b=ODa+BXCc3zKeX/vK7bZgMzYzYNLLJRbcMA0usGpI5QY0wIfLcYx+g3O2
   Wy9F9Up2AMc5Ujx4gNjhJkLQWsNS529S2cjQT/J87eBcQaX1dTeOLNDEt
   2F/iE75SVsvsKS63k4tFiDWc2JwGRAQUTOfyJ+MP1g40GoDcY+sC2U9uK
   8=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 64734288
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:9f87lqxvqKXxUqAZRPN6t+czxirEfRIJ4+MujC+fZmUNrF6WrkVUz
 zYXWWjTb6uPNDP9c91yOd7k8kpXvMOBn9c2SFE5rSAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGHdJZS5LwbZj2NYy24LhWWthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 Nplmca6ZwgFE4r3kfk/fxtdT3BGBvBN0eqSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DFYUToHx/ixreCu4rW8vrSKTW/95Imjw3g6iiGN6AO
 5VCNWA/PHwsZTVSH1A2AZ8lwNyumyOnLhZUqV2E/I4Otj27IAtZj+G2bYu9lsaxbdpRtlaVo
 CTB5WuRKjMwOcGbyDGF2mmxneKJliT+MKoCGbv9+vN0jVm7wm0IFAZQRVa9ueO+iEO1R5RYM
 UN8x8Y1hfFsrgrxFIC7BkDm5i7f1vIBZzZOO8Fg4i+C5ofz2A+EJEQGS2IQUOd7v+ZjEFTGy
 WS1t9/uADVutpicRnSc6qqYoFuOBMQFEYMRTXRaFFVYurEPtKl210uSFYg7TMZZm/WoQWmY/
 tyckMQpa1z/Z+Yv3r7zw13IiinESnPhHl9svVW/so5IA2pEiG+Zi26AtACzARVodt/xory9U
 J4swZP2AAcmV8zlqcB1aL9RdIxFHt7cWNEmvXZhHoM66xOm8GO5cIZb7VlWfRk1b5paKGK0O
 hOK4Wu9AaO/2lPwNsebhKrrVqwXIVXIT4y5Bpg4kPIUCnSOSON31H43PhPBt4wcuEMtjbs+K
 f+mnTWEVh4n5VBc5GPuHY81iOZzrghnnD+7bc2rnnyPjOvFDFbIGOhtDbd7Rr1ghE9yiF6Oq
 Ig32grj40g3bdASlQGNr9ZIdAhSdSJT6FKfg5U/S9Nv6zFOQAkJY8I9C5t4JOSJQ4w9ej/0w
 0yA
IronPort-HdrOrdr: A9a23:Ea+c66hT0RpqdHBmgBOp4kyCs3BQXuIji2hC6mlwRA09TySZ//
 rBoB19726MtN9xYgBHpTnuAsm9qB/nmaKdpLNhWItKPzOW31dATrsSjrcKqgeIc0aVm9K1l5
 0QF5SWYOeAdWSS5vya3ODXKbkdKaG8gcKVuds=
X-IronPort-AV: E=Sophos;i="5.88,387,1635220800"; 
   d="scan'208";a="64734288"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>
Subject: [PATCH v3 59/70] x86: Use control flow typechecking where possible
Date: Tue, 22 Feb 2022 15:26:43 +0000
Message-ID: <20220222152645.8844-14-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220222152645.8844-1-andrew.cooper3@citrix.com>
References: <20220222152645.8844-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

Now all callees have been annotated, turn on typechecking to catch issues in
the future.

This extension isn't in a released version of GCC yet, so provide a container
to use with the extention included, and add it to CI.  RANDCONFIG is necessary
because some stubs for compiled-out subsystems are used as function pointer
targets.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>

v3:
 * Provide container.  Already pushed to Gitlab.
---
 automation/build/debian/buster-gcc-ibt.dockerfile | 66 +++++++++++++++++++++++
 automation/gitlab-ci/build.yaml                   |  6 +++
 automation/scripts/containerize                   |  1 +
 xen/arch/x86/arch.mk                              |  1 +
 4 files changed, 74 insertions(+)
 create mode 100644 automation/build/debian/buster-gcc-ibt.dockerfile

diff --git a/automation/build/debian/buster-gcc-ibt.dockerfile b/automation/build/debian/buster-gcc-ibt.dockerfile
new file mode 100644
index 000000000000..441d9a9ab37a
--- /dev/null
+++ b/automation/build/debian/buster-gcc-ibt.dockerfile
@@ -0,0 +1,66 @@
+FROM debian:buster-slim AS builder
+
+ENV DEBIAN_FRONTEND=noninteractive
+ENV USER root
+
+RUN apt-get update && \
+    apt-get --quiet --yes install \
+        bison \
+        build-essential \
+        flex \
+        libc6-dev-i386 \
+        libgmp-dev \
+        libisl-dev \
+        libmpc-dev \
+        libmpfr-dev \
+        patch \
+        wget
+
+RUN mkdir /build
+WORKDIR /build
+
+RUN wget -q https://ftp.gnu.org/gnu/gcc/gcc-11.2.0/gcc-11.2.0.tar.xz -O - | tar xJ --strip=1
+RUN wget -q https://xenbits.xen.org/people/andrewcoop/gcc-11.2-Add-fcf-check-attribute-yes-no.patch -O - | patch -p1
+RUN ./configure \
+        --prefix=/opt/gcc-11-ibt \
+        --enable-languages=c \
+        --disable-nls \
+        --disable-threads \
+        --disable-bootstrap \
+        --disable-shared \
+        --disable-libmudflap \
+        --disable-libssp \
+        --disable-libgomp \
+        --disable-decimal-float \
+        --disable-libquadmath \
+        --disable-libatomic \
+        --disable-libcc1 \
+        --disable-libmpx
+RUN make -j`nproc` && make -j`nproc` install
+
+
+FROM debian:buster-slim
+COPY --from=builder /opt/gcc-11-ibt /opt/gcc-11-ibt
+
+LABEL maintainer.name="The Xen Project" \
+      maintainer.email="xen-devel@lists.xenproject.org"
+
+ENV DEBIAN_FRONTEND=noninteractive
+ENV USER root
+ENV PATH="/opt/gcc-11-ibt/bin:${PATH}"
+
+RUN mkdir /build
+WORKDIR /build
+
+RUN apt-get update && \
+    apt-get --quiet --yes install \
+        bison \
+        checkpolicy \
+        flex \
+        gawk \
+        make \
+        python3 \
+        && \
+        apt-get autoremove -y && \
+        apt-get clean && \
+        rm -rf /var/lib/apt/lists* /tmp/* /var/tmp/*
diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml
index fdd5c76582b3..cc36428cf55b 100644
--- a/automation/gitlab-ci/build.yaml
+++ b/automation/gitlab-ci/build.yaml
@@ -294,6 +294,12 @@ debian-stretch-32-gcc-debug:
   variables:
     CONTAINER: debian:stretch-i386
 
+debian-buster-gcc-ibt:
+  extends: .gcc-x86-64-build
+  variables:
+    CONTAINER: debian:buster-gcc-ibt
+    RANDCONFIG: y
+
 debian-unstable-clang:
   extends: .clang-x86-64-build
   variables:
diff --git a/automation/scripts/containerize b/automation/scripts/containerize
index 7682ccd34759..8992c67278ae 100755
--- a/automation/scripts/containerize
+++ b/automation/scripts/containerize
@@ -33,6 +33,7 @@ case "_${CONTAINER}" in
     _focal) CONTAINER="${BASE}/ubuntu:focal" ;;
     _jessie) CONTAINER="${BASE}/debian:jessie" ;;
     _stretch|_) CONTAINER="${BASE}/debian:stretch" ;;
+    _buster-gcc-ibt) CONTAINER="${BASE}/debian:buster-gcc-ibt" ;;
     _unstable|_) CONTAINER="${BASE}/debian:unstable" ;;
     _trusty) CONTAINER="${BASE}/ubuntu:trusty" ;;
     _xenial) CONTAINER="${BASE}/ubuntu:xenial" ;;
diff --git a/xen/arch/x86/arch.mk b/xen/arch/x86/arch.mk
index f780c912a9cf..92fd19811013 100644
--- a/xen/arch/x86/arch.mk
+++ b/xen/arch/x86/arch.mk
@@ -54,6 +54,7 @@ endif
 
 ifdef CONFIG_XEN_IBT
 CFLAGS += -fcf-protection=branch -mmanual-endbr
+$(call cc-option-add,CFLAGS,CC,-fcf-check-attribute=no)
 else
 $(call cc-option-add,CFLAGS,CC,-fcf-protection=none)
 endif
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Tue Feb 22 15:35:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 15:35:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276946.473348 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMXCK-0007qQ-Ob; Tue, 22 Feb 2022 15:35:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276946.473348; Tue, 22 Feb 2022 15:35:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMXCK-0007pF-Lb; Tue, 22 Feb 2022 15:35:28 +0000
Received: by outflank-mailman (input) for mailman id 276946;
 Tue, 22 Feb 2022 15:35:27 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Woib=TF=citrix.com=prvs=045a4fa17=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nMXCJ-0005NI-QX
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 15:35:27 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0d5b2200-93f5-11ec-8539-5f4723681683;
 Tue, 22 Feb 2022 16:35:26 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0d5b2200-93f5-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645544126;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=K/NDm/pt+CvfTKAUMdQObuq7L64t6cohDruqfCnhYqk=;
  b=BnTfPCzuulveZJSPCwGsvMXbJZepdwyvS2JyUyhpyYtWfB+RoyyZBgwr
   2d766Tn44KbAN90pL52HS2cTWQStzdKb6ouI+yLFOhBmwd3pH35Ufym4X
   DSPQ3jQBHHyxcW8xx5CZm3tUw0iJfqep9V20LQNw75F67d8hsDjjNvLJ9
   k=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 64171036
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:tQDIy6Jksh0CuJv8FE+R1JUlxSXFcZb7ZxGr2PjKsXjdYENS02EGm
 2BJWz2GPKqCYzT0ft4lPYjipEgG78Xcx4RnGgdlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA180IMsdoUg7wbRh2NQy2YLR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 Ntn5Y6LRzcyBPXJtLQlDBlYPwAhHrITrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBODtMJkSpTdLyjbBAOx9aZvCX7/L9ZlT2zJYasVmQ6qHO
 JNBMmQHgBLoby9QOVsVCK4EkuKFvyPTQWRptgmXnP9ii4TU5FMoi+W8WDbPQfSVQe1Fk0Deo
 XjJl0zbKBwHMN2UyRKe72mhwOTImEvTSI8UUbG16PNuqFmS3XAITg0bU0Ohpvu0gVL4XMhQQ
 3H44QJ38/J0rhbyCICgAVvo+xZooyLwRfJeOb0o0w+90ZCM5irJPjcEThJgN/854ZpeqSMR6
 neFmNbgBDpKubKTSG6A+rr8kQ5eKRT5PkdZO3ZaEFJtD83L5dhq00mRFooL/Lud04WtcQwc1
 Qxmu8TXa187qccQn5u28lnc695HjsiYF1Vljuk7s4/M0++YWGJHT9HwgbQ4xawZRGp8crVnl
 CJf8yR5xLpTZaxhbATXHI0w8EiBvp5pygH0j191BIUG/D+w4XOldo04yGggeBo1bJdZJGW1O
 Re7VeZtCHl7ZiDCgUhfOd/ZNijX5fK4SYSNug78NLKinaSdhCfYpXozNCZ8LkjmkVQ2kLFXB
 HtoWZ3EMJruMow+lGDeb75EidcDn3lirUuOFcGT50n2itK2OS/KIYrpxXPTN4jVGovf+16Lm
 zueXuPXoyhivBrWOHePqtdLdQhQRZX5bLivw/Fqmie4ClIOMAkc5zX5mtvNp6QNc3xpq9r1
IronPort-HdrOrdr: A9a23:Ubefqq2e2YVVx/emzWUmfgqjBIokLtp133Aq2lEZdPRUGvb3qy
 nIpoVj6faUskd2ZJhOo7C90cW7LU80sKQFhLX5Xo3SOzUO2lHYT72KhLGKq1aLdhEWtNQtsZ
 uIG5IOcOEYZmIasS+V2maF+q4bsbu6zJw=
X-IronPort-AV: E=Sophos;i="5.88,387,1635220800"; 
   d="scan'208";a="64171036"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>
Subject: [PATCH v3 64/70] x86: Introduce helpers/checks for endbr64 instructions
Date: Tue, 22 Feb 2022 15:26:45 +0000
Message-ID: <20220222152645.8844-16-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220222152645.8844-1-andrew.cooper3@citrix.com>
References: <20220222152645.8844-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

... to prevent the optimiser creating unsafe code.  See the code comment for
full details.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>

v3:
 * Introduce ENDBR64_LEN
v2:
 * Fix include to let the header be standalone
 * Add earlyclobber to asm
v1.1:
 * New
---
 xen/arch/x86/include/asm/endbr.h | 55 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 55 insertions(+)
 create mode 100644 xen/arch/x86/include/asm/endbr.h

diff --git a/xen/arch/x86/include/asm/endbr.h b/xen/arch/x86/include/asm/endbr.h
new file mode 100644
index 000000000000..6090afeb0bd8
--- /dev/null
+++ b/xen/arch/x86/include/asm/endbr.h
@@ -0,0 +1,55 @@
+/******************************************************************************
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; If not, see <http://www.gnu.org/licenses/>.
+ *
+ * Copyright (c) 2021-2022 Citrix Systems Ltd.
+ */
+#ifndef XEN_ASM_ENDBR_H
+#define XEN_ASM_ENDBR_H
+
+#include <xen/types.h>
+
+#define ENDBR64_LEN 4
+
+/*
+ * In some cases we need to inspect/insert endbr64 instructions.
+ *
+ * The naive way, mem{cmp,cpy}(ptr, "\xf3\x0f\x1e\xfa", 4), optimises unsafely
+ * by placing 0xfa1e0ff3 in an imm32 operand, and marks a legal indirect
+ * branch target as far as the CPU is concerned.
+ *
+ * gen_endbr64() is written deliberately to avoid the problematic operand, and
+ * marked __const__ as it is safe for the optimiser to hoist/merge/etc.
+ */
+static inline uint32_t __attribute_const__ gen_endbr64(void)
+{
+    uint32_t res;
+
+    asm ( "mov $~0xfa1e0ff3, %[res]\n\t"
+          "not %[res]\n\t"
+          : [res] "=&r" (res) );
+
+    return res;
+}
+
+static inline bool is_endbr64(const void *ptr)
+{
+    return *(const uint32_t *)ptr == gen_endbr64();
+}
+
+static inline void place_endbr64(void *ptr)
+{
+    *(uint32_t *)ptr = gen_endbr64();
+}
+
+#endif /* XEN_ASM_ENDBR_H */
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Tue Feb 22 15:36:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 15:36:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276964.473363 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMXD1-0000So-CP; Tue, 22 Feb 2022 15:36:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276964.473363; Tue, 22 Feb 2022 15:36:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMXD1-0000SG-7A; Tue, 22 Feb 2022 15:36:11 +0000
Received: by outflank-mailman (input) for mailman id 276964;
 Tue, 22 Feb 2022 15:36:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=CFyZ=TF=bombadil.srs.infradead.org=BATV+11ac0858211c0bd5236f+6757+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nMXCs-0005NI-RN
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 15:36:02 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 23026f3c-93f5-11ec-8539-5f4723681683;
 Tue, 22 Feb 2022 16:36:01 +0100 (CET)
Received: from [2001:4bb8:198:f8fc:c22a:ebfc:be8d:63c2] (helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nMXCY-00AH3K-TD; Tue, 22 Feb 2022 15:35:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 23026f3c-93f5-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=e5WrycmUWO29UJfUDorb7NMshMB8lzYVa/Mc+LVTrQY=; b=PVO9XcrDHa5m2ERE3jOCfMddZ8
	VgqNwjEPjMv/voqlXJPqq/Gijq6BadY/wUGg+lCdJIiS/Wm20KPvFL/fb3JaVsj9SgXTgKj/msBMc
	AUtnTN2/CsgeN7vGXwogaFALjfmJg6+5bVutlBng3wk3Vm1xTJf0dqCzaQiQ16e0PpRZ1TpwNrAb2
	Tbp9EBwVd/VQ5Bd719hErc8P9S8oE+PJN5a/LNV1F+lMJfD+HOKEg7jdT+jvqNbzCNX5haPiRafDS
	zkkrMaLQIzYbe/DL4RXwKjXZ7XEjARtDiWibLpsbJPdcqWJ1NV9wVAKal56Wpmncbpzif8mdAuBMT
	wzYHLs2Q==;
From: Christoph Hellwig <hch@lst.de>
To: iommu@lists.linux-foundation.org
Cc: x86@kernel.org,
	Stefano Stabellini <sstabellini@kernel.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Joerg Roedel <joro@8bytes.org>,
	David Woodhouse <dwmw2@infradead.org>,
	Lu Baolu <baolu.lu@linux.intel.com>,
	Robin Murphy <robin.murphy@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	xen-devel@lists.xenproject.org,
	linux-ia64@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	tboot-devel@lists.sourceforge.net,
	linux-pci@vger.kernel.org
Subject: [PATCH 09/11] swiotlb: add a SWIOTLB_ANY flag to lift the low memory restriction
Date: Tue, 22 Feb 2022 16:35:12 +0100
Message-Id: <20220222153514.593231-10-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220222153514.593231-1-hch@lst.de>
References: <20220222153514.593231-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Power SVM wants to allocate a swiotlb buffer that is not restricted to
low memory for the trusted hypervisor scheme.  Consolidate the support
for this into the swiotlb_init interface by adding a new flag.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 arch/powerpc/include/asm/svm.h       |  4 ----
 arch/powerpc/mm/mem.c                |  5 +----
 arch/powerpc/platforms/pseries/svm.c | 26 +-------------------------
 include/linux/swiotlb.h              |  1 +
 kernel/dma/swiotlb.c                 |  9 +++++++--
 5 files changed, 10 insertions(+), 35 deletions(-)

diff --git a/arch/powerpc/include/asm/svm.h b/arch/powerpc/include/asm/svm.h
index 7546402d796af..85580b30aba48 100644
--- a/arch/powerpc/include/asm/svm.h
+++ b/arch/powerpc/include/asm/svm.h
@@ -15,8 +15,6 @@ static inline bool is_secure_guest(void)
 	return mfmsr() & MSR_S;
 }
 
-void __init svm_swiotlb_init(void);
-
 void dtl_cache_ctor(void *addr);
 #define get_dtl_cache_ctor()	(is_secure_guest() ? dtl_cache_ctor : NULL)
 
@@ -27,8 +25,6 @@ static inline bool is_secure_guest(void)
 	return false;
 }
 
-static inline void svm_swiotlb_init(void) {}
-
 #define get_dtl_cache_ctor() NULL
 
 #endif /* CONFIG_PPC_SVM */
diff --git a/arch/powerpc/mm/mem.c b/arch/powerpc/mm/mem.c
index d99b8b5b40ca6..a4d65418c30a9 100644
--- a/arch/powerpc/mm/mem.c
+++ b/arch/powerpc/mm/mem.c
@@ -249,10 +249,7 @@ void __init mem_init(void)
 	 * back to to-down.
 	 */
 	memblock_set_bottom_up(true);
-	if (is_secure_guest())
-		svm_swiotlb_init();
-	else
-		swiotlb_init(ppc_swiotlb_enable, ppc_swiotlb_flags);
+	swiotlb_init(ppc_swiotlb_enable, ppc_swiotlb_flags);
 #endif
 
 	high_memory = (void *) __va(max_low_pfn * PAGE_SIZE);
diff --git a/arch/powerpc/platforms/pseries/svm.c b/arch/powerpc/platforms/pseries/svm.c
index c5228f4969eb2..3b4045d508ec8 100644
--- a/arch/powerpc/platforms/pseries/svm.c
+++ b/arch/powerpc/platforms/pseries/svm.c
@@ -28,7 +28,7 @@ static int __init init_svm(void)
 	 * need to use the SWIOTLB buffer for DMA even if dma_capable() says
 	 * otherwise.
 	 */
-	swiotlb_force = SWIOTLB_FORCE;
+	ppc_swiotlb_flags |= SWIOTLB_ANY | SWIOTLB_FORCE;
 
 	/* Share the SWIOTLB buffer with the host. */
 	swiotlb_update_mem_attributes();
@@ -37,30 +37,6 @@ static int __init init_svm(void)
 }
 machine_early_initcall(pseries, init_svm);
 
-/*
- * Initialize SWIOTLB. Essentially the same as swiotlb_init(), except that it
- * can allocate the buffer anywhere in memory. Since the hypervisor doesn't have
- * any addressing limitation, we don't need to allocate it in low addresses.
- */
-void __init svm_swiotlb_init(void)
-{
-	unsigned char *vstart;
-	unsigned long bytes, io_tlb_nslabs;
-
-	io_tlb_nslabs = (swiotlb_size_or_default() >> IO_TLB_SHIFT);
-	io_tlb_nslabs = ALIGN(io_tlb_nslabs, IO_TLB_SEGSIZE);
-
-	bytes = io_tlb_nslabs << IO_TLB_SHIFT;
-
-	vstart = memblock_alloc(PAGE_ALIGN(bytes), PAGE_SIZE);
-	if (vstart && !swiotlb_init_with_tbl(vstart, io_tlb_nslabs, false))
-		return;
-
-
-	memblock_free(vstart, PAGE_ALIGN(io_tlb_nslabs << IO_TLB_SHIFT));
-	panic("SVM: Cannot allocate SWIOTLB buffer");
-}
-
 int set_memory_encrypted(unsigned long addr, int numpages)
 {
 	if (!cc_platform_has(CC_ATTR_MEM_ENCRYPT))
diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h
index dcecf953f7997..ee655f2e4d28b 100644
--- a/include/linux/swiotlb.h
+++ b/include/linux/swiotlb.h
@@ -15,6 +15,7 @@ struct scatterlist;
 
 #define SWIOTLB_VERBOSE	(1 << 0) /* verbose initialization */
 #define SWIOTLB_FORCE	(1 << 1) /* force bounce buffering */
+#define SWIOTLB_ANY	(1 << 2) /* allow any memory for the buffer */
 
 /*
  * Maximum allowable number of contiguous slabs to map,
diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c
index ad604e5a0983d..ec200e40fc397 100644
--- a/kernel/dma/swiotlb.c
+++ b/kernel/dma/swiotlb.c
@@ -275,8 +275,13 @@ void __init swiotlb_init(bool addressing_limit, unsigned int flags)
 	if (swiotlb_force_disable)
 		return;
 
-	/* Get IO TLB memory from the low pages */
-	tlb = memblock_alloc_low(bytes, PAGE_SIZE);
+	/*
+	 * By default allocate the bonuce buffer memory from low memory.
+	 */
+	if (flags & SWIOTLB_ANY)
+		tlb = memblock_alloc(bytes, PAGE_SIZE);
+	else
+		tlb = memblock_alloc_low(bytes, PAGE_SIZE);
 	if (!tlb)
 		goto fail;
 	if (swiotlb_init_with_tbl(tlb, default_nslabs, flags))
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Tue Feb 22 15:36:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 15:36:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276963.473358 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMXD1-0000QV-1v; Tue, 22 Feb 2022 15:36:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276963.473358; Tue, 22 Feb 2022 15:36:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMXD0-0000QM-Ux; Tue, 22 Feb 2022 15:36:10 +0000
Received: by outflank-mailman (input) for mailman id 276963;
 Tue, 22 Feb 2022 15:36:09 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=CFyZ=TF=bombadil.srs.infradead.org=BATV+11ac0858211c0bd5236f+6757+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nMXCQ-0005NI-MM
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 15:35:34 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0f39d710-93f5-11ec-8539-5f4723681683;
 Tue, 22 Feb 2022 16:35:31 +0100 (CET)
Received: from [2001:4bb8:198:f8fc:c22a:ebfc:be8d:63c2] (helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nMXC9-00AGnS-1u; Tue, 22 Feb 2022 15:35:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0f39d710-93f5-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:
	Content-ID:Content-Description:In-Reply-To:References;
	bh=16nouNo24ejNp/bHBqFUpHpMmYYgIL88sf6fCnA5oxw=; b=Evl4OhdNJ9vFGI4KBDyMJ2uY4v
	ahlgofRSzpQsvpw+qbnrer3aKbB3W7rQQSWiEtHPv1GOLM+A33NRlrQJtcbKPQZsq8ZJ0Ur1vnRRo
	g3p2qbcU3jr70C8mOofs0g3hzUW4uVlAhWSisJaMMZC6wOX8A4tQ90Hk2vLNc+kmD6djArF9T8eoW
	9u4suY2drGIZP4mp6SqQGG0Ti0UU5XC5RKqrHf1fSU30Q1huprZkGdvFxmCo5kR0DDj/lBC1BQkHm
	KDzcPMMmVkYt9l5nGrPt5RR+4vvyTE3FSJuO351gMgi78pWHFgl6Edsr7ZHkmjhcz+ut06I1oIQyx
	rYiE4tRw==;
From: Christoph Hellwig <hch@lst.de>
To: iommu@lists.linux-foundation.org
Cc: x86@kernel.org,
	Stefano Stabellini <sstabellini@kernel.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Joerg Roedel <joro@8bytes.org>,
	David Woodhouse <dwmw2@infradead.org>,
	Lu Baolu <baolu.lu@linux.intel.com>,
	Robin Murphy <robin.murphy@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	xen-devel@lists.xenproject.org,
	linux-ia64@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	tboot-devel@lists.sourceforge.net,
	linux-pci@vger.kernel.org
Subject: cleanup swiotlb initialization
Date: Tue, 22 Feb 2022 16:35:03 +0100
Message-Id: <20220222153514.593231-1-hch@lst.de>
X-Mailer: git-send-email 2.30.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Hi all,

this series tries to clean up the swiotlb initialization, including
that of swiotlb-xen.  To get there is also removes the x86 iommu table
infrastructure that massively obsfucates the initialization path.

Git tree:

    git://git.infradead.org/users/hch/misc.git swiotlb-init-cleanup

Gitweb:

    http://git.infradead.org/users/hch/misc.git/shortlog/refs/heads/swiotlb-init-cleanup

Diffstat:
 arch/ia64/include/asm/iommu_table.h      |    7 -
 arch/x86/include/asm/iommu_table.h       |  102 -------------------
 arch/x86/include/asm/swiotlb.h           |   30 -----
 arch/x86/kernel/pci-iommu_table.c        |   77 --------------
 arch/x86/kernel/pci-swiotlb.c            |   77 --------------
 arch/x86/xen/pci-swiotlb-xen.c           |   96 ------------------
 b/arch/arm/mm/init.c                     |    6 -
 b/arch/arm/xen/mm.c                      |   23 ++--
 b/arch/arm64/mm/init.c                   |    6 -
 b/arch/ia64/mm/init.c                    |    4 
 b/arch/mips/cavium-octeon/dma-octeon.c   |   15 --
 b/arch/mips/loongson64/dma.c             |    2 
 b/arch/mips/pci/pci-octeon.c             |    2 
 b/arch/mips/sibyte/common/dma.c          |    2 
 b/arch/powerpc/include/asm/svm.h         |    4 
 b/arch/powerpc/include/asm/swiotlb.h     |    1 
 b/arch/powerpc/mm/mem.c                  |    6 -
 b/arch/powerpc/platforms/pseries/setup.c |    3 
 b/arch/powerpc/platforms/pseries/svm.c   |   26 ----
 b/arch/riscv/mm/init.c                   |    8 -
 b/arch/s390/mm/init.c                    |    3 
 b/arch/x86/include/asm/dma-mapping.h     |   12 --
 b/arch/x86/include/asm/gart.h            |    5 
 b/arch/x86/include/asm/iommu.h           |    8 +
 b/arch/x86/include/asm/xen/page.h        |    5 
 b/arch/x86/include/asm/xen/swiotlb-xen.h |    2 
 b/arch/x86/kernel/Makefile               |    2 
 b/arch/x86/kernel/amd_gart_64.c          |    5 
 b/arch/x86/kernel/aperture_64.c          |   14 --
 b/arch/x86/kernel/cpu/mshyperv.c         |    8 -
 b/arch/x86/kernel/pci-dma.c              |  114 +++++++++++++++++----
 b/arch/x86/kernel/tboot.c                |    1 
 b/arch/x86/kernel/vmlinux.lds.S          |   12 --
 b/arch/x86/mm/mem_encrypt_amd.c          |    3 
 b/arch/x86/pci/sta2x11-fixup.c           |    2 
 b/arch/x86/xen/Makefile                  |    2 
 b/drivers/iommu/amd/init.c               |    6 -
 b/drivers/iommu/amd/iommu.c              |    5 
 b/drivers/iommu/intel/dmar.c             |    6 -
 b/drivers/xen/swiotlb-xen.c              |  132 -------------------------
 b/include/linux/dmar.h                   |    6 -
 b/include/linux/swiotlb.h                |   22 ++--
 b/include/trace/events/swiotlb.h         |   29 +----
 b/include/xen/arm/page.h                 |    1 
 b/include/xen/swiotlb-xen.h              |    8 +
 b/kernel/dma/direct.h                    |    2 
 b/kernel/dma/swiotlb.c                   |  163 +++++++++++++++----------------
 47 files changed, 258 insertions(+), 817 deletions(-)


From xen-devel-bounces@lists.xenproject.org Tue Feb 22 15:36:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 15:36:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276968.473381 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMXD2-0000wL-UY; Tue, 22 Feb 2022 15:36:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276968.473381; Tue, 22 Feb 2022 15:36:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMXD2-0000vv-MV; Tue, 22 Feb 2022 15:36:12 +0000
Received: by outflank-mailman (input) for mailman id 276968;
 Tue, 22 Feb 2022 15:36:11 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=CFyZ=TF=bombadil.srs.infradead.org=BATV+11ac0858211c0bd5236f+6757+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nMXCP-0005NI-V9
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 15:35:34 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 11e0b600-93f5-11ec-8539-5f4723681683;
 Tue, 22 Feb 2022 16:35:32 +0100 (CET)
Received: from [2001:4bb8:198:f8fc:c22a:ebfc:be8d:63c2] (helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nMXCB-00AGo7-Po; Tue, 22 Feb 2022 15:35:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 11e0b600-93f5-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=XYJlVwldNVCJqO/+tuKojN3UlpP6EWuPoimLYHKi/jc=; b=PjYqXlXh0/xMADYjBN4lX4q5Ly
	AuFycvSAdpIXN9YbLSHqw0K2dYILwjr7wgIeGZEPaMgVELz5o/txiNNKILc4nXrxHan9rtYYBwlmt
	7GaftcZ0rDAFxBm9a1LqzQTCL93a6M9uf1PyDLGYGiRgPK7ZuYIRQDsrVP9eN9dOO9swFx1vDeZc+
	yZPvyf1fh6NCG0uMF/LNlnZNoPYsVTSxgQ7mhLCFFvpZJhhnjfKuephjOMuwK1KFrmapY7foUzQ7p
	05RnloFRKzpM7mJ1akDcM3wUeCLyhzdFOE+AL1st9GwnxOLIxR7uY8XZpOgAYp4TpNIfEYTRusOAm
	VVgxXFDQ==;
From: Christoph Hellwig <hch@lst.de>
To: iommu@lists.linux-foundation.org
Cc: x86@kernel.org,
	Stefano Stabellini <sstabellini@kernel.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Joerg Roedel <joro@8bytes.org>,
	David Woodhouse <dwmw2@infradead.org>,
	Lu Baolu <baolu.lu@linux.intel.com>,
	Robin Murphy <robin.murphy@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	xen-devel@lists.xenproject.org,
	linux-ia64@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	tboot-devel@lists.sourceforge.net,
	linux-pci@vger.kernel.org
Subject: [PATCH 01/11] dma-direct: use is_swiotlb_active in dma_direct_map_page
Date: Tue, 22 Feb 2022 16:35:04 +0100
Message-Id: <20220222153514.593231-2-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220222153514.593231-1-hch@lst.de>
References: <20220222153514.593231-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Use the more specific is_swiotlb_active check instead of checking the
global swiotlb_force variable.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 kernel/dma/direct.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/dma/direct.h b/kernel/dma/direct.h
index 4632b0f4f72eb..4dc16e08c7e1a 100644
--- a/kernel/dma/direct.h
+++ b/kernel/dma/direct.h
@@ -91,7 +91,7 @@ static inline dma_addr_t dma_direct_map_page(struct device *dev,
 		return swiotlb_map(dev, phys, size, dir, attrs);
 
 	if (unlikely(!dma_capable(dev, dma_addr, size, true))) {
-		if (swiotlb_force != SWIOTLB_NO_FORCE)
+		if (is_swiotlb_active(dev))
 			return swiotlb_map(dev, phys, size, dir, attrs);
 
 		dev_WARN_ONCE(dev, 1,
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Tue Feb 22 15:36:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 15:36:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276971.473392 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMXD5-0001I4-8U; Tue, 22 Feb 2022 15:36:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276971.473392; Tue, 22 Feb 2022 15:36:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMXD5-0001Ht-1C; Tue, 22 Feb 2022 15:36:15 +0000
Received: by outflank-mailman (input) for mailman id 276971;
 Tue, 22 Feb 2022 15:36:14 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=CFyZ=TF=bombadil.srs.infradead.org=BATV+11ac0858211c0bd5236f+6757+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nMXCw-0005NF-1R
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 15:36:06 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 24a969ef-93f5-11ec-8eb8-a37418f5ba1a;
 Tue, 22 Feb 2022 16:36:04 +0100 (CET)
Received: from [2001:4bb8:198:f8fc:c22a:ebfc:be8d:63c2] (helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nMXCb-00AH4p-Lb; Tue, 22 Feb 2022 15:35:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 24a969ef-93f5-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=MP133v1kwiW3c87+cPBpFDQUlQtDeX75p5kJbFoXYYs=; b=mQ9qW//6Cxq6fp2v+y0k83BlCl
	GTdHl2Yi4VXTsa/9OlEJ0bqFePJeG7UTfNRxQx80vp2FE55AN2IXeWPgz50xZ0a897v1bfsI+FoQC
	j8fFViIssX34Qs2bn4z0LTmuU+eIW6qKSfyZ8G6R77UHR3RNmyp5Py95tYTZ3XX6cnNIiy8Jr+Otv
	XMvu/dYxbmt96Sb4q38Z2Xg8sDoms9cUzYRFGgkj7hdhl+EwO/G2WQKCF+qfaX6hjmmRiSqkIUpqx
	bE2ISLDfZeJ57BsLZqwCiTIXh4QZ2KXBPLBjQ74kVwirBtAomdzrqLRCWBQkdjyqzyX/f5KefywDJ
	e7NcH08w==;
From: Christoph Hellwig <hch@lst.de>
To: iommu@lists.linux-foundation.org
Cc: x86@kernel.org,
	Stefano Stabellini <sstabellini@kernel.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Joerg Roedel <joro@8bytes.org>,
	David Woodhouse <dwmw2@infradead.org>,
	Lu Baolu <baolu.lu@linux.intel.com>,
	Robin Murphy <robin.murphy@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	xen-devel@lists.xenproject.org,
	linux-ia64@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	tboot-devel@lists.sourceforge.net,
	linux-pci@vger.kernel.org
Subject: [PATCH 10/11] swiotlb: merge swiotlb-xen initialization into swiotlb
Date: Tue, 22 Feb 2022 16:35:13 +0100
Message-Id: <20220222153514.593231-11-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220222153514.593231-1-hch@lst.de>
References: <20220222153514.593231-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Allow to pass a remap argument to the swiotlb initialization functions
to handle the Xen/x86 remap case.  ARM/ARM64 never did any remapping
from xen_swiotlb_fixup, so we don't even need that quirk.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 arch/arm/xen/mm.c               |  23 +++---
 arch/x86/include/asm/xen/page.h |   5 --
 arch/x86/kernel/pci-dma.c       |  27 ++++---
 arch/x86/pci/sta2x11-fixup.c    |   2 +-
 drivers/xen/swiotlb-xen.c       | 128 +-------------------------------
 include/linux/swiotlb.h         |   7 +-
 include/xen/arm/page.h          |   1 -
 include/xen/swiotlb-xen.h       |   8 +-
 kernel/dma/swiotlb.c            | 120 +++++++++++++++---------------
 9 files changed, 102 insertions(+), 219 deletions(-)

diff --git a/arch/arm/xen/mm.c b/arch/arm/xen/mm.c
index a7e54a087b802..58b40f87617d3 100644
--- a/arch/arm/xen/mm.c
+++ b/arch/arm/xen/mm.c
@@ -23,22 +23,20 @@
 #include <asm/xen/hypercall.h>
 #include <asm/xen/interface.h>
 
-unsigned long xen_get_swiotlb_free_pages(unsigned int order)
+static gfp_t xen_swiotlb_gfp(void)
 {
 	phys_addr_t base;
-	gfp_t flags = __GFP_NOWARN|__GFP_KSWAPD_RECLAIM;
 	u64 i;
 
 	for_each_mem_range(i, &base, NULL) {
 		if (base < (phys_addr_t)0xffffffff) {
 			if (IS_ENABLED(CONFIG_ZONE_DMA32))
-				flags |= __GFP_DMA32;
-			else
-				flags |= __GFP_DMA;
-			break;
+				return __GFP_DMA32;
+			return __GFP_DMA;
 		}
 	}
-	return __get_free_pages(flags, order);
+
+	return GFP_KERNEL;
 }
 
 static bool hypercall_cflush = false;
@@ -143,10 +141,15 @@ static int __init xen_mm_init(void)
 	if (!xen_swiotlb_detect())
 		return 0;
 
-	rc = xen_swiotlb_init();
 	/* we can work with the default swiotlb */
-	if (rc < 0 && rc != -EEXIST)
-		return rc;
+	if (!io_tlb_default_mem.nslabs) {
+		if (!xen_initial_domain())
+			return -EINVAL;
+		rc = swiotlb_init_late(swiotlb_size_or_default(),
+				       xen_swiotlb_gfp(), NULL);
+		if (rc < 0)
+			return rc;
+	}
 
 	cflush.op = 0;
 	cflush.a.dev_bus_addr = 0;
diff --git a/arch/x86/include/asm/xen/page.h b/arch/x86/include/asm/xen/page.h
index e989bc2269f54..1fc67df500145 100644
--- a/arch/x86/include/asm/xen/page.h
+++ b/arch/x86/include/asm/xen/page.h
@@ -357,9 +357,4 @@ static inline bool xen_arch_need_swiotlb(struct device *dev,
 	return false;
 }
 
-static inline unsigned long xen_get_swiotlb_free_pages(unsigned int order)
-{
-	return __get_free_pages(__GFP_NOWARN, order);
-}
-
 #endif /* _ASM_X86_XEN_PAGE_H */
diff --git a/arch/x86/kernel/pci-dma.c b/arch/x86/kernel/pci-dma.c
index 9576a02a2590f..b849f11a756d0 100644
--- a/arch/x86/kernel/pci-dma.c
+++ b/arch/x86/kernel/pci-dma.c
@@ -40,7 +40,6 @@ int iommu_detected __read_mostly = 0;
 #ifdef CONFIG_SWIOTLB
 bool x86_swiotlb_enable;
 static unsigned int x86_swiotlb_flags;
-static bool xen_swiotlb;
 
 /*
  * If 4GB or more detected (and iommu=off not set) or if SME is active
@@ -50,17 +49,16 @@ static void __init pci_swiotlb_detect_4gb(void)
 {
 #ifdef CONFIG_SWIOTLB_XEN
 	if (xen_pv_domain()) {
-		if (xen_initial_domain() || x86_swiotlb_enable) {
-			xen_swiotlb = true;
-			xen_swiotlb_init_early();
-			dma_ops = &xen_swiotlb_dma_ops;
+		if (xen_initial_domain())
+			x86_swiotlb_enable = true;
 
+		if (x86_swiotlb_enable) {
+			dma_ops = &xen_swiotlb_dma_ops;
 #ifdef CONFIG_PCI
 			/* Make sure ACS will be enabled */
 			pci_request_acs();
 #endif
 		}
-		x86_swiotlb_enable = false;
 		return;
 	}
 #endif /* CONFIG_SWIOTLB_XEN */
@@ -91,7 +89,8 @@ void __init pci_iommu_alloc(void)
 	amd_iommu_detect();
 	detect_intel_iommu();
 #ifdef CONFIG_SWIOTLB
-	swiotlb_init(x86_swiotlb_enable, x86_swiotlb_flags);
+	swiotlb_init_remap(x86_swiotlb_enable, x86_swiotlb_flags,
+			   xen_pv_domain() ? xen_swiotlb_fixup : NULL);
 #endif
 }
 
@@ -205,13 +204,17 @@ int pci_xen_swiotlb_init_late(void)
 {
 	int rc;
 
-	if (xen_swiotlb)
+	if (dma_ops == &xen_swiotlb_dma_ops)
 		return 0;
 
-	rc = xen_swiotlb_init();
-	if (rc)
-		return rc;
-
+	/* we can work with the default swiotlb */
+	if (!io_tlb_default_mem.nslabs) {
+		rc = swiotlb_init_late(swiotlb_size_or_default(),
+				       GFP_KERNEL, xen_swiotlb_fixup);
+		if (rc < 0)
+			return rc;
+	}
+ 
 	/* XXX: this switches the dma ops under live devices! */
 	dma_ops = &xen_swiotlb_dma_ops;
 #ifdef CONFIG_PCI
diff --git a/arch/x86/pci/sta2x11-fixup.c b/arch/x86/pci/sta2x11-fixup.c
index c7e6faf59a861..7368afc039987 100644
--- a/arch/x86/pci/sta2x11-fixup.c
+++ b/arch/x86/pci/sta2x11-fixup.c
@@ -57,7 +57,7 @@ static void sta2x11_new_instance(struct pci_dev *pdev)
 		int size = STA2X11_SWIOTLB_SIZE;
 		/* First instance: register your own swiotlb area */
 		dev_info(&pdev->dev, "Using SWIOTLB (size %i)\n", size);
-		if (swiotlb_init_late(size, GFP_DMA))
+		if (swiotlb_init_late(size, GFP_DMA, NULL))
 			dev_emerg(&pdev->dev, "init swiotlb failed\n");
 	}
 	list_add(&instance->list, &sta2x11_instance_list);
diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c
index c2da3eb4826e8..df8085b50df10 100644
--- a/drivers/xen/swiotlb-xen.c
+++ b/drivers/xen/swiotlb-xen.c
@@ -104,7 +104,7 @@ static int is_xen_swiotlb_buffer(struct device *dev, dma_addr_t dma_addr)
 	return 0;
 }
 
-static int xen_swiotlb_fixup(void *buf, unsigned long nslabs)
+int xen_swiotlb_fixup(void *buf, unsigned long nslabs)
 {
 	int rc;
 	unsigned int order = get_order(IO_TLB_SEGSIZE << IO_TLB_SHIFT);
@@ -130,132 +130,6 @@ static int xen_swiotlb_fixup(void *buf, unsigned long nslabs)
 	return 0;
 }
 
-enum xen_swiotlb_err {
-	XEN_SWIOTLB_UNKNOWN = 0,
-	XEN_SWIOTLB_ENOMEM,
-	XEN_SWIOTLB_EFIXUP
-};
-
-static const char *xen_swiotlb_error(enum xen_swiotlb_err err)
-{
-	switch (err) {
-	case XEN_SWIOTLB_ENOMEM:
-		return "Cannot allocate Xen-SWIOTLB buffer\n";
-	case XEN_SWIOTLB_EFIXUP:
-		return "Failed to get contiguous memory for DMA from Xen!\n"\
-		    "You either: don't have the permissions, do not have"\
-		    " enough free memory under 4GB, or the hypervisor memory"\
-		    " is too fragmented!";
-	default:
-		break;
-	}
-	return "";
-}
-
-int xen_swiotlb_init(void)
-{
-	enum xen_swiotlb_err m_ret = XEN_SWIOTLB_UNKNOWN;
-	unsigned long bytes = swiotlb_size_or_default();
-	unsigned long nslabs = bytes >> IO_TLB_SHIFT;
-	unsigned int order, repeat = 3;
-	int rc = -ENOMEM;
-	char *start;
-
-	if (io_tlb_default_mem.nslabs) {
-		pr_warn("swiotlb buffer already initialized\n");
-		return -EEXIST;
-	}
-
-retry:
-	m_ret = XEN_SWIOTLB_ENOMEM;
-	order = get_order(bytes);
-
-	/*
-	 * Get IO TLB memory from any location.
-	 */
-#define SLABS_PER_PAGE (1 << (PAGE_SHIFT - IO_TLB_SHIFT))
-#define IO_TLB_MIN_SLABS ((1<<20) >> IO_TLB_SHIFT)
-	while ((SLABS_PER_PAGE << order) > IO_TLB_MIN_SLABS) {
-		start = (void *)xen_get_swiotlb_free_pages(order);
-		if (start)
-			break;
-		order--;
-	}
-	if (!start)
-		goto exit;
-	if (order != get_order(bytes)) {
-		pr_warn("Warning: only able to allocate %ld MB for software IO TLB\n",
-			(PAGE_SIZE << order) >> 20);
-		nslabs = SLABS_PER_PAGE << order;
-		bytes = nslabs << IO_TLB_SHIFT;
-	}
-
-	/*
-	 * And replace that memory with pages under 4GB.
-	 */
-	rc = xen_swiotlb_fixup(start, nslabs);
-	if (rc) {
-		free_pages((unsigned long)start, order);
-		m_ret = XEN_SWIOTLB_EFIXUP;
-		goto error;
-	}
-	rc = swiotlb_late_init_with_tbl(start, nslabs);
-	if (rc)
-		return rc;
-	return 0;
-error:
-	if (nslabs > 1024 && repeat--) {
-		/* Min is 2MB */
-		nslabs = max(1024UL, ALIGN(nslabs >> 1, IO_TLB_SEGSIZE));
-		bytes = nslabs << IO_TLB_SHIFT;
-		pr_info("Lowering to %luMB\n", bytes >> 20);
-		goto retry;
-	}
-exit:
-	pr_err("%s (rc:%d)\n", xen_swiotlb_error(m_ret), rc);
-	return rc;
-}
-
-#ifdef CONFIG_X86
-void __init xen_swiotlb_init_early(void)
-{
-	unsigned long bytes = swiotlb_size_or_default();
-	unsigned long nslabs = bytes >> IO_TLB_SHIFT;
-	unsigned int repeat = 3;
-	char *start;
-	int rc;
-
-retry:
-	/*
-	 * Get IO TLB memory from any location.
-	 */
-	start = memblock_alloc(PAGE_ALIGN(bytes),
-			       IO_TLB_SEGSIZE << IO_TLB_SHIFT);
-	if (!start)
-		panic("%s: Failed to allocate %lu bytes\n",
-		      __func__, PAGE_ALIGN(bytes));
-
-	/*
-	 * And replace that memory with pages under 4GB.
-	 */
-	rc = xen_swiotlb_fixup(start, nslabs);
-	if (rc) {
-		memblock_free(start, PAGE_ALIGN(bytes));
-		if (nslabs > 1024 && repeat--) {
-			/* Min is 2MB */
-			nslabs = max(1024UL, ALIGN(nslabs >> 1, IO_TLB_SEGSIZE));
-			bytes = nslabs << IO_TLB_SHIFT;
-			pr_info("Lowering to %luMB\n", bytes >> 20);
-			goto retry;
-		}
-		panic("%s (rc:%d)", xen_swiotlb_error(XEN_SWIOTLB_EFIXUP), rc);
-	}
-
-	if (swiotlb_init_with_tbl(start, nslabs, SWIOTLB_VERBOSE))
-		panic("Cannot allocate SWIOTLB buffer");
-}
-#endif /* CONFIG_X86 */
-
 static void *
 xen_swiotlb_alloc_coherent(struct device *hwdev, size_t size,
 			   dma_addr_t *dma_handle, gfp_t flags,
diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h
index ee655f2e4d28b..919cf82ed978e 100644
--- a/include/linux/swiotlb.h
+++ b/include/linux/swiotlb.h
@@ -34,10 +34,11 @@ struct scatterlist;
 /* default to 64MB */
 #define IO_TLB_DEFAULT_SIZE (64UL<<20)
 
-int swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, unsigned int flags);
 unsigned long swiotlb_size_or_default(void);
-extern int swiotlb_late_init_with_tbl(char *tlb, unsigned long nslabs);
-int swiotlb_init_late(size_t size, gfp_t gfp_mask);
+int swiotlb_init_late(size_t size, gfp_t gfp_mask,
+		int (*remap)(void *tlb, unsigned long nslabs));
+void __init swiotlb_init_remap(bool addressing_limit, unsigned int flags,
+		int (*remap)(void *tlb, unsigned long nslabs));
 extern void __init swiotlb_update_mem_attributes(void);
 
 phys_addr_t swiotlb_tbl_map_single(struct device *hwdev, phys_addr_t phys,
diff --git a/include/xen/arm/page.h b/include/xen/arm/page.h
index ac1b654705631..7e199c6656b90 100644
--- a/include/xen/arm/page.h
+++ b/include/xen/arm/page.h
@@ -115,6 +115,5 @@ static inline bool set_phys_to_machine(unsigned long pfn, unsigned long mfn)
 bool xen_arch_need_swiotlb(struct device *dev,
 			   phys_addr_t phys,
 			   dma_addr_t dev_addr);
-unsigned long xen_get_swiotlb_free_pages(unsigned int order);
 
 #endif /* _ASM_ARM_XEN_PAGE_H */
diff --git a/include/xen/swiotlb-xen.h b/include/xen/swiotlb-xen.h
index b3e647f86e3e2..590ceb923f0c8 100644
--- a/include/xen/swiotlb-xen.h
+++ b/include/xen/swiotlb-xen.h
@@ -10,8 +10,12 @@ void xen_dma_sync_for_cpu(struct device *dev, dma_addr_t handle,
 void xen_dma_sync_for_device(struct device *dev, dma_addr_t handle,
 			     size_t size, enum dma_data_direction dir);
 
-int xen_swiotlb_init(void);
-void __init xen_swiotlb_init_early(void);
+#ifdef CONFIG_SWIOTLB_XEN
+int xen_swiotlb_fixup(void *buf, unsigned long nslabs);
+#else
+#define xen_swiotlb_fixup NULL
+#endif
+
 extern const struct dma_map_ops xen_swiotlb_dma_ops;
 
 #endif /* __LINUX_SWIOTLB_XEN_H */
diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c
index ec200e40fc397..35ee2318ea563 100644
--- a/kernel/dma/swiotlb.c
+++ b/kernel/dma/swiotlb.c
@@ -234,40 +234,17 @@ static void swiotlb_init_io_tlb_mem(struct io_tlb_mem *mem, phys_addr_t start,
 	return;
 }
 
-int __init swiotlb_init_with_tbl(char *tlb, unsigned long nslabs,
-		unsigned int flags)
-{
-	struct io_tlb_mem *mem = &io_tlb_default_mem;
-	size_t alloc_size;
-
-	if (swiotlb_force_disable)
-		return 0;
-
-	/* protect against double initialization */
-	if (WARN_ON_ONCE(mem->nslabs))
-		return -ENOMEM;
-
-	alloc_size = PAGE_ALIGN(array_size(sizeof(*mem->slots), nslabs));
-	mem->slots = memblock_alloc(alloc_size, PAGE_SIZE);
-	if (!mem->slots)
-		panic("%s: Failed to allocate %zu bytes align=0x%lx\n",
-		      __func__, alloc_size, PAGE_SIZE);
-
-	swiotlb_init_io_tlb_mem(mem, __pa(tlb), nslabs, false);
-	mem->force_bounce = flags & SWIOTLB_FORCE;
-
-	if (flags & SWIOTLB_VERBOSE)
-		swiotlb_print_info();
-	return 0;
-}
-
 /*
  * Statically reserve bounce buffer space and initialize bounce buffer data
  * structures for the software IO TLB used to implement the DMA API.
  */
-void __init swiotlb_init(bool addressing_limit, unsigned int flags)
+void __init swiotlb_init_remap(bool addressing_limit, unsigned int flags,
+		int (*remap)(void *tlb, unsigned long nslabs))
 {
-	size_t bytes = PAGE_ALIGN(default_nslabs << IO_TLB_SHIFT);
+	struct io_tlb_mem *mem = &io_tlb_default_mem;
+	unsigned long nslabs = default_nslabs;
+	size_t alloc_size = PAGE_ALIGN(array_size(sizeof(*mem->slots), nslabs));
+	size_t bytes;
 	void *tlb;
 
 	if (!addressing_limit && !swiotlb_force_bounce)
@@ -275,23 +252,48 @@ void __init swiotlb_init(bool addressing_limit, unsigned int flags)
 	if (swiotlb_force_disable)
 		return;
 
+	/* protect against double initialization */
+	if (WARN_ON_ONCE(mem->nslabs))
+		return;
+
 	/*
 	 * By default allocate the bonuce buffer memory from low memory.
 	 */
+retry:
+	bytes = PAGE_ALIGN(default_nslabs << IO_TLB_SHIFT);
 	if (flags & SWIOTLB_ANY)
 		tlb = memblock_alloc(bytes, PAGE_SIZE);
 	else
 		tlb = memblock_alloc_low(bytes, PAGE_SIZE);
 	if (!tlb)
-		goto fail;
-	if (swiotlb_init_with_tbl(tlb, default_nslabs, flags))
-		goto fail_free_mem;
-	return;
+		panic("%s: failed to allocate tlb structure\n", __func__);
+
+	if (remap && remap(tlb, nslabs) < 0) {
+		memblock_free(tlb, PAGE_ALIGN(bytes));
+
+		/* Min is 2MB */
+		if (nslabs <= 1024)
+			panic("%s: Failed to remap %zu bytes\n",
+			      __func__, bytes);
+		nslabs = max(1024UL, ALIGN(nslabs >> 1, IO_TLB_SEGSIZE));
+		goto retry;
+	}
+
+	mem->slots = memblock_alloc(alloc_size, PAGE_SIZE);
+	if (!mem->slots)
+		panic("%s: Failed to allocate %zu bytes align=0x%lx\n",
+		      __func__, alloc_size, PAGE_SIZE);
 
-fail_free_mem:
-	memblock_free(tlb, bytes);
-fail:
-	pr_warn("Cannot allocate buffer");
+	swiotlb_init_io_tlb_mem(mem, __pa(tlb), default_nslabs, false);
+	mem->force_bounce = flags & SWIOTLB_FORCE;
+
+	if (flags & SWIOTLB_VERBOSE)
+		swiotlb_print_info();
+}
+
+void __init swiotlb_init(bool addressing_limit, unsigned int flags)
+{
+	return swiotlb_init_remap(addressing_limit, flags, NULL);
 }
 
 /*
@@ -299,8 +301,10 @@ void __init swiotlb_init(bool addressing_limit, unsigned int flags)
  * initialize the swiotlb later using the slab allocator if needed.
  * This should be just like above, but with some error catching.
  */
-int swiotlb_init_late(size_t size, gfp_t gfp_mask)
+int swiotlb_init_late(size_t size, gfp_t gfp_mask,
+		int (*remap)(void *tlb, unsigned long nslabs))
 {
+	struct io_tlb_mem *mem = &io_tlb_default_mem;
 	unsigned long nslabs = ALIGN(size >> IO_TLB_SHIFT, IO_TLB_SEGSIZE);
 	unsigned long bytes;
 	unsigned char *vstart = NULL;
@@ -310,9 +314,14 @@ int swiotlb_init_late(size_t size, gfp_t gfp_mask)
 	if (swiotlb_force_disable)
 		return 0;
 
+	/* protect against double initialization */
+	if (WARN_ON_ONCE(mem->nslabs))
+		return -ENOMEM;
+
 	/*
 	 * Get IO TLB memory from the low pages
 	 */
+retry:
 	order = get_order(nslabs << IO_TLB_SHIFT);
 	nslabs = SLABS_PER_PAGE << order;
 	bytes = nslabs << IO_TLB_SHIFT;
@@ -333,33 +342,28 @@ int swiotlb_init_late(size_t size, gfp_t gfp_mask)
 			(PAGE_SIZE << order) >> 20);
 		nslabs = SLABS_PER_PAGE << order;
 	}
-	rc = swiotlb_late_init_with_tbl(vstart, nslabs);
-	if (rc)
-		free_pages((unsigned long)vstart, order);
-
-	return rc;
-}
-
-int
-swiotlb_late_init_with_tbl(char *tlb, unsigned long nslabs)
-{
-	struct io_tlb_mem *mem = &io_tlb_default_mem;
-	unsigned long bytes = nslabs << IO_TLB_SHIFT;
 
-	if (swiotlb_force_disable)
-		return 0;
+	if (remap)
+		rc = remap(vstart, nslabs);
+	if (rc) {
+		free_pages((unsigned long)vstart, order);
 
-	/* protect against double initialization */
-	if (WARN_ON_ONCE(mem->nslabs))
-		return -ENOMEM;
+		/* Min is 2MB */
+		if (nslabs <= 1024)
+			return rc;
+		nslabs = max(1024UL, ALIGN(nslabs >> 1, IO_TLB_SEGSIZE));
+		goto retry;
+	}
 
 	mem->slots = (void *)__get_free_pages(GFP_KERNEL | __GFP_ZERO,
 		get_order(array_size(sizeof(*mem->slots), nslabs)));
-	if (!mem->slots)
+	if (!mem->slots) {
+		free_pages((unsigned long)vstart, order);
 		return -ENOMEM;
+	}
 
-	set_memory_decrypted((unsigned long)tlb, bytes >> PAGE_SHIFT);
-	swiotlb_init_io_tlb_mem(mem, virt_to_phys(tlb), nslabs, true);
+	set_memory_decrypted((unsigned long)vstart, bytes >> PAGE_SHIFT);
+	swiotlb_init_io_tlb_mem(mem, virt_to_phys(vstart), nslabs, true);
 
 	swiotlb_print_info();
 	return 0;
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Tue Feb 22 15:36:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 15:36:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276972.473398 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMXD5-0001Ps-SS; Tue, 22 Feb 2022 15:36:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276972.473398; Tue, 22 Feb 2022 15:36:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMXD5-0001Nw-M6; Tue, 22 Feb 2022 15:36:15 +0000
Received: by outflank-mailman (input) for mailman id 276972;
 Tue, 22 Feb 2022 15:36:14 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=CFyZ=TF=bombadil.srs.infradead.org=BATV+11ac0858211c0bd5236f+6757+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nMXCR-0005NI-8D
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 15:35:35 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 11ff3c82-93f5-11ec-8539-5f4723681683;
 Tue, 22 Feb 2022 16:35:33 +0100 (CET)
Received: from [2001:4bb8:198:f8fc:c22a:ebfc:be8d:63c2] (helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nMXCE-00AGpk-IC; Tue, 22 Feb 2022 15:35:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 11ff3c82-93f5-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=hwGHho6vVoG5zxL+r+gO/HrLW55gSYiZK1xOFy8bPWY=; b=EXbyg4oElbNBCkXxF5PHE19cjU
	Fhh8CM69nTRceyzTldor3WTO4HGvmvQXWPAh2WGra1WaTbxlQ5XzvwoMBUILahCpilzLJA96AAAkQ
	TxbPVjzqLsMLHXjWbfzEQdEzhkxzcS9SI8zzxJt5k4gy+nwhAHszCs3y9seiMTLWuA8wDaiKoiqC5
	R2eiLkkdWQMz990U+MVaVkdNuIk/Vpp0/S/BdvNauv1e7YcyxIPyfk9ydUE1i1051hAU9G59sMV3x
	I/UwQdy2sd/TJAeypMn9AZP0W9cKSL4qQ8b8g2Cf7svHpTJvkKFLcjADA+rDauJKsTjC/CcM8rhTP
	BJ9+5XEA==;
From: Christoph Hellwig <hch@lst.de>
To: iommu@lists.linux-foundation.org
Cc: x86@kernel.org,
	Stefano Stabellini <sstabellini@kernel.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Joerg Roedel <joro@8bytes.org>,
	David Woodhouse <dwmw2@infradead.org>,
	Lu Baolu <baolu.lu@linux.intel.com>,
	Robin Murphy <robin.murphy@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	xen-devel@lists.xenproject.org,
	linux-ia64@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	tboot-devel@lists.sourceforge.net,
	linux-pci@vger.kernel.org
Subject: [PATCH 02/11] swiotlb: make swiotlb_exit a no-op if SWIOTLB_FORCE is set
Date: Tue, 22 Feb 2022 16:35:05 +0100
Message-Id: <20220222153514.593231-3-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220222153514.593231-1-hch@lst.de>
References: <20220222153514.593231-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

If force bouncing is enabled we can't release the bufffers.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 kernel/dma/swiotlb.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c
index f1e7ea160b433..36fbf1181d285 100644
--- a/kernel/dma/swiotlb.c
+++ b/kernel/dma/swiotlb.c
@@ -378,6 +378,9 @@ void __init swiotlb_exit(void)
 	unsigned long tbl_vaddr;
 	size_t tbl_size, slots_size;
 
+	if (swiotlb_force == SWIOTLB_FORCE)
+		return;
+
 	if (!mem->nslabs)
 		return;
 
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Tue Feb 22 15:36:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 15:36:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276976.473414 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMXD8-0001x5-6H; Tue, 22 Feb 2022 15:36:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276976.473414; Tue, 22 Feb 2022 15:36:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMXD8-0001wn-0e; Tue, 22 Feb 2022 15:36:18 +0000
Received: by outflank-mailman (input) for mailman id 276976;
 Tue, 22 Feb 2022 15:36:17 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=CFyZ=TF=bombadil.srs.infradead.org=BATV+11ac0858211c0bd5236f+6757+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nMXCg-0005NF-Co
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 15:35:50 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 19a3145d-93f5-11ec-8eb8-a37418f5ba1a;
 Tue, 22 Feb 2022 16:35:47 +0100 (CET)
Received: from [2001:4bb8:198:f8fc:c22a:ebfc:be8d:63c2] (helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nMXCP-00AGwT-S1; Tue, 22 Feb 2022 15:35:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 19a3145d-93f5-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=2LuLtS1efSBZ06JRKs3rwu/XDIHFFEkeBlwKrISdqYE=; b=Vf12//P1cJJG7r7sSMYd3RKUpR
	1iyqvtcz1vvg2fulY2+WGMc8nNqZ0MlrzDhxAp14OnNMko2kMFYfcU0rlmFA2OCUpO2mFz7P7lvKg
	ALp0Z8CYzL61sODI1ktyZxnyHDkcqBaBsxGE7/O/0yEeje/VzIYseB2EMSkX0NSBzVGeetdBnWPlq
	h4ARmCowLPrC/KwkX0h+EeItmZFyxYuayW3LABiVBWVYx9p142xpp5CdMhN6o16cO+9maNRgWoIhF
	/De8ZYV8h4SrIxdVqDfFAtgqSO7aIGNMgslI44A+n4/vknBhdvQqpOCR4L4Wpy966WPbClzjKYvUC
	fRljMIDw==;
From: Christoph Hellwig <hch@lst.de>
To: iommu@lists.linux-foundation.org
Cc: x86@kernel.org,
	Stefano Stabellini <sstabellini@kernel.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Joerg Roedel <joro@8bytes.org>,
	David Woodhouse <dwmw2@infradead.org>,
	Lu Baolu <baolu.lu@linux.intel.com>,
	Robin Murphy <robin.murphy@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	xen-devel@lists.xenproject.org,
	linux-ia64@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	tboot-devel@lists.sourceforge.net,
	linux-pci@vger.kernel.org
Subject: [PATCH 06/11] MIPS/octeon: use swiotlb_init instead of open coding it
Date: Tue, 22 Feb 2022 16:35:09 +0100
Message-Id: <20220222153514.593231-7-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220222153514.593231-1-hch@lst.de>
References: <20220222153514.593231-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Use the generic swiotlb initialization helper instead of open coding it.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 arch/mips/cavium-octeon/dma-octeon.c | 15 ++-------------
 arch/mips/pci/pci-octeon.c           |  2 +-
 2 files changed, 3 insertions(+), 14 deletions(-)

diff --git a/arch/mips/cavium-octeon/dma-octeon.c b/arch/mips/cavium-octeon/dma-octeon.c
index df70308db0e69..fb7547e217263 100644
--- a/arch/mips/cavium-octeon/dma-octeon.c
+++ b/arch/mips/cavium-octeon/dma-octeon.c
@@ -186,15 +186,12 @@ phys_addr_t dma_to_phys(struct device *dev, dma_addr_t daddr)
 	return daddr;
 }
 
-char *octeon_swiotlb;
-
 void __init plat_swiotlb_setup(void)
 {
 	phys_addr_t start, end;
 	phys_addr_t max_addr;
 	phys_addr_t addr_size;
 	size_t swiotlbsize;
-	unsigned long swiotlb_nslabs;
 	u64 i;
 
 	max_addr = 0;
@@ -236,15 +233,7 @@ void __init plat_swiotlb_setup(void)
 	if (OCTEON_IS_OCTEON2() && max_addr >= 0x100000000ul)
 		swiotlbsize = 64 * (1<<20);
 #endif
-	swiotlb_nslabs = swiotlbsize >> IO_TLB_SHIFT;
-	swiotlb_nslabs = ALIGN(swiotlb_nslabs, IO_TLB_SEGSIZE);
-	swiotlbsize = swiotlb_nslabs << IO_TLB_SHIFT;
-
-	octeon_swiotlb = memblock_alloc_low(swiotlbsize, PAGE_SIZE);
-	if (!octeon_swiotlb)
-		panic("%s: Failed to allocate %zu bytes align=%lx\n",
-		      __func__, swiotlbsize, PAGE_SIZE);
 
-	if (swiotlb_init_with_tbl(octeon_swiotlb, swiotlb_nslabs, 1) == -ENOMEM)
-		panic("Cannot allocate SWIOTLB buffer");
+	swiotlb_adjust_size(swiotlbsize);
+	swiotlb_init(1);
 }
diff --git a/arch/mips/pci/pci-octeon.c b/arch/mips/pci/pci-octeon.c
index fc29b85cfa926..e457a18cbdc59 100644
--- a/arch/mips/pci/pci-octeon.c
+++ b/arch/mips/pci/pci-octeon.c
@@ -664,7 +664,7 @@ static int __init octeon_pci_setup(void)
 
 		/* BAR1 movable regions contiguous to cover the swiotlb */
 		octeon_bar1_pci_phys =
-			virt_to_phys(octeon_swiotlb) & ~((1ull << 22) - 1);
+			io_tlb_default_mem.start & ~((1ull << 22) - 1);
 
 		for (index = 0; index < 32; index++) {
 			union cvmx_pci_bar1_indexx bar1_index;
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Tue Feb 22 15:36:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 15:36:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276983.473425 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMXDH-0002j2-GV; Tue, 22 Feb 2022 15:36:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276983.473425; Tue, 22 Feb 2022 15:36:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMXDH-0002ik-B9; Tue, 22 Feb 2022 15:36:27 +0000
Received: by outflank-mailman (input) for mailman id 276983;
 Tue, 22 Feb 2022 15:36:25 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=CFyZ=TF=bombadil.srs.infradead.org=BATV+11ac0858211c0bd5236f+6757+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nMXCh-0005NF-Cq
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 15:35:51 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1b83f524-93f5-11ec-8eb8-a37418f5ba1a;
 Tue, 22 Feb 2022 16:35:49 +0100 (CET)
Received: from [2001:4bb8:198:f8fc:c22a:ebfc:be8d:63c2] (helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nMXCS-00AGyX-Qo; Tue, 22 Feb 2022 15:35:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1b83f524-93f5-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=0baUdiWGkzyTvEY5+fZBb0HhsV2XDbo//o8EVwPiM1Y=; b=VtTenidmqW4UpX88iEoqOwMYvm
	x+9MjXNmAo75jNOkt/cwKED1m3dzeUunCcmEKcnPuG6lgGjK7HW9ee5stFdj931ZwWulNdT0wkSWp
	5dp29pncEFZRSorU+Nxkcg42I/j7R400Ldy3dqpKfN9ZcLAqQjsmPVGoCsaQcpmgXqBhASG6gIqq1
	z6Yxjxu/nu7YjD7z1AXbqHYa77ijtEm3sixNLzVVL6qBZUhX8N3I/8du4g1Nm6iOYNfdtZPiYX9L1
	Pla3BFEVSrUBX4+ZWJIV8uiOZ3kU4LlApgXtCYTikl0iwBnD3aCWivJ/iQnjRh9Tlu2yd96M/j25V
	WwvNuu4Q==;
From: Christoph Hellwig <hch@lst.de>
To: iommu@lists.linux-foundation.org
Cc: x86@kernel.org,
	Stefano Stabellini <sstabellini@kernel.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Joerg Roedel <joro@8bytes.org>,
	David Woodhouse <dwmw2@infradead.org>,
	Lu Baolu <baolu.lu@linux.intel.com>,
	Robin Murphy <robin.murphy@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	xen-devel@lists.xenproject.org,
	linux-ia64@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	tboot-devel@lists.sourceforge.net,
	linux-pci@vger.kernel.org
Subject: [PATCH 07/11] x86: remove the IOMMU table infrastructure
Date: Tue, 22 Feb 2022 16:35:10 +0100
Message-Id: <20220222153514.593231-8-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220222153514.593231-1-hch@lst.de>
References: <20220222153514.593231-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

The IOMMU table tries to separate the different IOMMUs into different
backends, but actually requires various cross calls.

Rewrite the code to do the generic swiotlb/swiotlb-xen setup directly
in pci-dma.c and then just call into the IOMMU drivers.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 arch/ia64/include/asm/iommu_table.h    |   7 --
 arch/x86/include/asm/dma-mapping.h     |   1 -
 arch/x86/include/asm/gart.h            |   5 +-
 arch/x86/include/asm/iommu.h           |   6 ++
 arch/x86/include/asm/iommu_table.h     | 102 ----------------------
 arch/x86/include/asm/swiotlb.h         |  30 -------
 arch/x86/include/asm/xen/swiotlb-xen.h |   2 -
 arch/x86/kernel/Makefile               |   2 -
 arch/x86/kernel/amd_gart_64.c          |   5 +-
 arch/x86/kernel/aperture_64.c          |  14 ++--
 arch/x86/kernel/pci-dma.c              | 112 ++++++++++++++++++++-----
 arch/x86/kernel/pci-iommu_table.c      |  77 -----------------
 arch/x86/kernel/pci-swiotlb.c          |  77 -----------------
 arch/x86/kernel/tboot.c                |   1 -
 arch/x86/kernel/vmlinux.lds.S          |  12 ---
 arch/x86/xen/Makefile                  |   2 -
 arch/x86/xen/pci-swiotlb-xen.c         |  96 ---------------------
 drivers/iommu/amd/init.c               |   6 --
 drivers/iommu/amd/iommu.c              |   5 +-
 drivers/iommu/intel/dmar.c             |   6 +-
 include/linux/dmar.h                   |   6 +-
 21 files changed, 115 insertions(+), 459 deletions(-)
 delete mode 100644 arch/ia64/include/asm/iommu_table.h
 delete mode 100644 arch/x86/include/asm/iommu_table.h
 delete mode 100644 arch/x86/include/asm/swiotlb.h
 delete mode 100644 arch/x86/kernel/pci-iommu_table.c
 delete mode 100644 arch/x86/kernel/pci-swiotlb.c
 delete mode 100644 arch/x86/xen/pci-swiotlb-xen.c

diff --git a/arch/ia64/include/asm/iommu_table.h b/arch/ia64/include/asm/iommu_table.h
deleted file mode 100644
index cc96116ac276a..0000000000000
--- a/arch/ia64/include/asm/iommu_table.h
+++ /dev/null
@@ -1,7 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0 */
-#ifndef _ASM_IA64_IOMMU_TABLE_H
-#define _ASM_IA64_IOMMU_TABLE_H
-
-#define IOMMU_INIT_POST(_detect)
-
-#endif /* _ASM_IA64_IOMMU_TABLE_H */
diff --git a/arch/x86/include/asm/dma-mapping.h b/arch/x86/include/asm/dma-mapping.h
index bb1654fe0ce74..256fd8115223d 100644
--- a/arch/x86/include/asm/dma-mapping.h
+++ b/arch/x86/include/asm/dma-mapping.h
@@ -9,7 +9,6 @@
 
 #include <linux/scatterlist.h>
 #include <asm/io.h>
-#include <asm/swiotlb.h>
 
 extern int iommu_merge;
 extern int panic_on_overflow;
diff --git a/arch/x86/include/asm/gart.h b/arch/x86/include/asm/gart.h
index 3185565743459..5af8088a10df6 100644
--- a/arch/x86/include/asm/gart.h
+++ b/arch/x86/include/asm/gart.h
@@ -38,7 +38,7 @@ extern int gart_iommu_aperture_disabled;
 extern void early_gart_iommu_check(void);
 extern int gart_iommu_init(void);
 extern void __init gart_parse_options(char *);
-extern int gart_iommu_hole_init(void);
+void gart_iommu_hole_init(void);
 
 #else
 #define gart_iommu_aperture            0
@@ -51,9 +51,8 @@ static inline void early_gart_iommu_check(void)
 static inline void gart_parse_options(char *options)
 {
 }
-static inline int gart_iommu_hole_init(void)
+static inline void gart_iommu_hole_init(void)
 {
-	return -ENODEV;
 }
 #endif
 
diff --git a/arch/x86/include/asm/iommu.h b/arch/x86/include/asm/iommu.h
index bf1ed2ddc74bd..dba89ed40d38d 100644
--- a/arch/x86/include/asm/iommu.h
+++ b/arch/x86/include/asm/iommu.h
@@ -9,6 +9,12 @@
 extern int force_iommu, no_iommu;
 extern int iommu_detected;
 
+#ifdef CONFIG_SWIOTLB
+extern bool x86_swiotlb_enable;
+#else
+#define x86_swiotlb_enable false
+#endif
+
 /* 10 seconds */
 #define DMAR_OPERATION_TIMEOUT ((cycles_t) tsc_khz*10*1000)
 
diff --git a/arch/x86/include/asm/iommu_table.h b/arch/x86/include/asm/iommu_table.h
deleted file mode 100644
index 1fb3fd1a83c25..0000000000000
--- a/arch/x86/include/asm/iommu_table.h
+++ /dev/null
@@ -1,102 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0 */
-#ifndef _ASM_X86_IOMMU_TABLE_H
-#define _ASM_X86_IOMMU_TABLE_H
-
-#include <asm/swiotlb.h>
-
-/*
- * History lesson:
- * The execution chain of IOMMUs in 2.6.36 looks as so:
- *
- *            [xen-swiotlb]
- *                 |
- *         +----[swiotlb *]--+
- *        /         |         \
- *       /          |          \
- *    [GART]     [Calgary]  [Intel VT-d]
- *     /
- *    /
- * [AMD-Vi]
- *
- * *: if SWIOTLB detected 'iommu=soft'/'swiotlb=force' it would skip
- * over the rest of IOMMUs and unconditionally initialize the SWIOTLB.
- * Also it would surreptitiously initialize set the swiotlb=1 if there were
- * more than 4GB and if the user did not pass in 'iommu=off'. The swiotlb
- * flag would be turned off by all IOMMUs except the Calgary one.
- *
- * The IOMMU_INIT* macros allow a similar tree (or more complex if desired)
- * to be built by defining who we depend on.
- *
- * And all that needs to be done is to use one of the macros in the IOMMU
- * and the pci-dma.c will take care of the rest.
- */
-
-struct iommu_table_entry {
-	initcall_t	detect;
-	initcall_t	depend;
-	void		(*early_init)(void); /* No memory allocate available. */
-	void		(*late_init)(void); /* Yes, can allocate memory. */
-#define IOMMU_FINISH_IF_DETECTED (1<<0)
-#define IOMMU_DETECTED		 (1<<1)
-	int		flags;
-};
-/*
- * Macro fills out an entry in the .iommu_table that is equivalent
- * to the fields that 'struct iommu_table_entry' has. The entries
- * that are put in the .iommu_table section are not put in any order
- * hence during boot-time we will have to resort them based on
- * dependency. */
-
-
-#define __IOMMU_INIT(_detect, _depend, _early_init, _late_init, _finish)\
-	static const struct iommu_table_entry				\
-		__iommu_entry_##_detect __used				\
-	__attribute__ ((unused, __section__(".iommu_table"),		\
-			aligned((sizeof(void *)))))	\
-	= {_detect, _depend, _early_init, _late_init,			\
-	   _finish ? IOMMU_FINISH_IF_DETECTED : 0}
-/*
- * The simplest IOMMU definition. Provide the detection routine
- * and it will be run after the SWIOTLB and the other IOMMUs
- * that utilize this macro. If the IOMMU is detected (ie, the
- * detect routine returns a positive value), the other IOMMUs
- * are also checked. You can use IOMMU_INIT_POST_FINISH if you prefer
- * to stop detecting the other IOMMUs after yours has been detected.
- */
-#define IOMMU_INIT_POST(_detect)					\
-	__IOMMU_INIT(_detect, pci_swiotlb_detect_4gb,  NULL, NULL, 0)
-
-#define IOMMU_INIT_POST_FINISH(detect)					\
-	__IOMMU_INIT(_detect, pci_swiotlb_detect_4gb,  NULL, NULL, 1)
-
-/*
- * A more sophisticated version of IOMMU_INIT. This variant requires:
- *  a). A detection routine function.
- *  b). The name of the detection routine we depend on to get called
- *      before us.
- *  c). The init routine which gets called if the detection routine
- *      returns a positive value from the pci_iommu_alloc. This means
- *      no presence of a memory allocator.
- *  d). Similar to the 'init', except that this gets called from pci_iommu_init
- *      where we do have a memory allocator.
- *
- * The standard IOMMU_INIT differs from the IOMMU_INIT_FINISH variant
- * in that the former will continue detecting other IOMMUs in the call
- * list after the detection routine returns a positive number, while the
- * latter will stop the execution chain upon first successful detection.
- * Both variants will still call the 'init' and 'late_init' functions if
- * they are set.
- */
-#define IOMMU_INIT_FINISH(_detect, _depend, _init, _late_init)		\
-	__IOMMU_INIT(_detect, _depend, _init, _late_init, 1)
-
-#define IOMMU_INIT(_detect, _depend, _init, _late_init)			\
-	__IOMMU_INIT(_detect, _depend, _init, _late_init, 0)
-
-void sort_iommu_table(struct iommu_table_entry *start,
-		      struct iommu_table_entry *finish);
-
-void check_iommu_entries(struct iommu_table_entry *start,
-			 struct iommu_table_entry *finish);
-
-#endif /* _ASM_X86_IOMMU_TABLE_H */
diff --git a/arch/x86/include/asm/swiotlb.h b/arch/x86/include/asm/swiotlb.h
deleted file mode 100644
index ff6c92eff035a..0000000000000
--- a/arch/x86/include/asm/swiotlb.h
+++ /dev/null
@@ -1,30 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0 */
-#ifndef _ASM_X86_SWIOTLB_H
-#define _ASM_X86_SWIOTLB_H
-
-#include <linux/swiotlb.h>
-
-#ifdef CONFIG_SWIOTLB
-extern int swiotlb;
-extern int __init pci_swiotlb_detect_override(void);
-extern int __init pci_swiotlb_detect_4gb(void);
-extern void __init pci_swiotlb_init(void);
-extern void __init pci_swiotlb_late_init(void);
-#else
-#define swiotlb 0
-static inline int pci_swiotlb_detect_override(void)
-{
-	return 0;
-}
-static inline int pci_swiotlb_detect_4gb(void)
-{
-	return 0;
-}
-static inline void pci_swiotlb_init(void)
-{
-}
-static inline void pci_swiotlb_late_init(void)
-{
-}
-#endif
-#endif /* _ASM_X86_SWIOTLB_H */
diff --git a/arch/x86/include/asm/xen/swiotlb-xen.h b/arch/x86/include/asm/xen/swiotlb-xen.h
index 66b4ddde77430..e5a90b42e4dde 100644
--- a/arch/x86/include/asm/xen/swiotlb-xen.h
+++ b/arch/x86/include/asm/xen/swiotlb-xen.h
@@ -3,10 +3,8 @@
 #define _ASM_X86_SWIOTLB_XEN_H
 
 #ifdef CONFIG_SWIOTLB_XEN
-extern int __init pci_xen_swiotlb_detect(void);
 extern int pci_xen_swiotlb_init_late(void);
 #else
-#define pci_xen_swiotlb_detect NULL
 static inline int pci_xen_swiotlb_init_late(void) { return -ENXIO; }
 #endif
 
diff --git a/arch/x86/kernel/Makefile b/arch/x86/kernel/Makefile
index 6aef9ee28a394..2851d4f0aa0d2 100644
--- a/arch/x86/kernel/Makefile
+++ b/arch/x86/kernel/Makefile
@@ -71,7 +71,6 @@ obj-y			+= bootflag.o e820.o
 obj-y			+= pci-dma.o quirks.o topology.o kdebugfs.o
 obj-y			+= alternative.o i8253.o hw_breakpoint.o
 obj-y			+= tsc.o tsc_msr.o io_delay.o rtc.o
-obj-y			+= pci-iommu_table.o
 obj-y			+= resource.o
 obj-y			+= irqflags.o
 obj-y			+= static_call.o
@@ -136,7 +135,6 @@ obj-$(CONFIG_PCSPKR_PLATFORM)	+= pcspeaker.o
 
 obj-$(CONFIG_X86_CHECK_BIOS_CORRUPTION) += check.o
 
-obj-$(CONFIG_SWIOTLB)			+= pci-swiotlb.o
 obj-$(CONFIG_OF)			+= devicetree.o
 obj-$(CONFIG_UPROBES)			+= uprobes.o
 
diff --git a/arch/x86/kernel/amd_gart_64.c b/arch/x86/kernel/amd_gart_64.c
index ed837383de5c8..194d54eed5376 100644
--- a/arch/x86/kernel/amd_gart_64.c
+++ b/arch/x86/kernel/amd_gart_64.c
@@ -38,11 +38,9 @@
 #include <asm/iommu.h>
 #include <asm/gart.h>
 #include <asm/set_memory.h>
-#include <asm/swiotlb.h>
 #include <asm/dma.h>
 #include <asm/amd_nb.h>
 #include <asm/x86_init.h>
-#include <asm/iommu_table.h>
 
 static unsigned long iommu_bus_base;	/* GART remapping area (physical) */
 static unsigned long iommu_size;	/* size of remapping area bytes */
@@ -808,7 +806,7 @@ int __init gart_iommu_init(void)
 	flush_gart();
 	dma_ops = &gart_dma_ops;
 	x86_platform.iommu_shutdown = gart_iommu_shutdown;
-	swiotlb = 0;
+	x86_swiotlb_enable = false;
 
 	return 0;
 }
@@ -842,4 +840,3 @@ void __init gart_parse_options(char *p)
 		}
 	}
 }
-IOMMU_INIT_POST(gart_iommu_hole_init);
diff --git a/arch/x86/kernel/aperture_64.c b/arch/x86/kernel/aperture_64.c
index af3ba08b684b5..7a5630d904b23 100644
--- a/arch/x86/kernel/aperture_64.c
+++ b/arch/x86/kernel/aperture_64.c
@@ -392,7 +392,7 @@ void __init early_gart_iommu_check(void)
 
 static int __initdata printed_gart_size_msg;
 
-int __init gart_iommu_hole_init(void)
+void __init gart_iommu_hole_init(void)
 {
 	u32 agp_aper_base = 0, agp_aper_order = 0;
 	u32 aper_size, aper_alloc = 0, aper_order = 0, last_aper_order = 0;
@@ -401,11 +401,11 @@ int __init gart_iommu_hole_init(void)
 	int i, node;
 
 	if (!amd_gart_present())
-		return -ENODEV;
+		return;
 
 	if (gart_iommu_aperture_disabled || !fix_aperture ||
 	    !early_pci_allowed())
-		return -ENODEV;
+		return;
 
 	pr_info("Checking aperture...\n");
 
@@ -491,10 +491,8 @@ int __init gart_iommu_hole_init(void)
 			 * and fixed up the northbridge
 			 */
 			exclude_from_core(last_aper_base, last_aper_order);
-
-			return 1;
 		}
-		return 0;
+		return;
 	}
 
 	if (!fallback_aper_force) {
@@ -527,7 +525,7 @@ int __init gart_iommu_hole_init(void)
 			panic("Not enough memory for aperture");
 		}
 	} else {
-		return 0;
+		return;
 	}
 
 	/*
@@ -561,6 +559,4 @@ int __init gart_iommu_hole_init(void)
 	}
 
 	set_up_gart_resume(aper_order, aper_alloc);
-
-	return 1;
 }
diff --git a/arch/x86/kernel/pci-dma.c b/arch/x86/kernel/pci-dma.c
index de234e7a8962e..32c9cd9d7c257 100644
--- a/arch/x86/kernel/pci-dma.c
+++ b/arch/x86/kernel/pci-dma.c
@@ -7,13 +7,16 @@
 #include <linux/memblock.h>
 #include <linux/gfp.h>
 #include <linux/pci.h>
+#include <linux/amd-iommu.h>
 
 #include <asm/proto.h>
 #include <asm/dma.h>
 #include <asm/iommu.h>
 #include <asm/gart.h>
 #include <asm/x86_init.h>
-#include <asm/iommu_table.h>
+
+#include <xen/xen.h>
+#include <xen/swiotlb-xen.h>
 
 static bool disable_dac_quirk __read_mostly;
 
@@ -34,24 +37,63 @@ int no_iommu __read_mostly;
 /* Set this to 1 if there is a HW IOMMU in the system */
 int iommu_detected __read_mostly = 0;
 
-extern struct iommu_table_entry __iommu_table[], __iommu_table_end[];
+#ifdef CONFIG_SWIOTLB
+bool x86_swiotlb_enable;
+static bool xen_swiotlb;
 
-void __init pci_iommu_alloc(void)
+/*
+ * If 4GB or more detected (and iommu=off not set) or if SME is active
+ * then set swiotlb to 1 and return 1.
+ */
+static void __init pci_swiotlb_detect_4gb(void)
 {
-	struct iommu_table_entry *p;
-
-	sort_iommu_table(__iommu_table, __iommu_table_end);
-	check_iommu_entries(__iommu_table, __iommu_table_end);
-
-	for (p = __iommu_table; p < __iommu_table_end; p++) {
-		if (p && p->detect && p->detect() > 0) {
-			p->flags |= IOMMU_DETECTED;
-			if (p->early_init)
-				p->early_init();
-			if (p->flags & IOMMU_FINISH_IF_DETECTED)
-				break;
+#ifdef CONFIG_SWIOTLB_XEN
+	if (xen_pv_domain()) {
+		if (xen_initial_domain() || x86_swiotlb_enable ||
+		    swiotlb_force == SWIOTLB_FORCE) {
+			xen_swiotlb = true;
+			xen_swiotlb_init_early();
+			dma_ops = &xen_swiotlb_dma_ops;
+
+#ifdef CONFIG_PCI
+			/* Make sure ACS will be enabled */
+			pci_request_acs();
+#endif
 		}
+		x86_swiotlb_enable = false;
+		return;
 	}
+#endif /* CONFIG_SWIOTLB_XEN */
+
+	/* don't initialize swiotlb if iommu=off (no_iommu=1) */
+	if (!no_iommu && max_possible_pfn > MAX_DMA32_PFN)
+		x86_swiotlb_enable = true;
+
+	/*
+	 * Set swiotlb to 1 so that bounce buffers are allocated and used for
+	 * devices that can't support DMA to encrypted memory.
+	 */
+	if (cc_platform_has(CC_ATTR_HOST_MEM_ENCRYPT))
+		x86_swiotlb_enable = true;
+
+	if (swiotlb_force == SWIOTLB_FORCE)
+		x86_swiotlb_enable = true;
+}
+#else
+static inline void __init pci_swiotlb_detect_4gb(void)
+{
+}
+#endif /* CONFIG_SWIOTLB */
+
+void __init pci_iommu_alloc(void)
+{
+	pci_swiotlb_detect_4gb();
+	gart_iommu_hole_init();
+	amd_iommu_detect();
+	detect_intel_iommu();
+
+	if (x86_swiotlb_enable)
+		swiotlb_init(0);
 }
 
 /*
@@ -102,7 +144,7 @@ static __init int iommu_setup(char *p)
 		}
 #ifdef CONFIG_SWIOTLB
 		if (!strncmp(p, "soft", 4))
-			swiotlb = 1;
+			x86_swiotlb_enable = 1;
 #endif
 		if (!strncmp(p, "pt", 2))
 			iommu_set_default_passthrough(true);
@@ -121,14 +163,18 @@ early_param("iommu", iommu_setup);
 
 static int __init pci_iommu_init(void)
 {
-	struct iommu_table_entry *p;
-
 	x86_init.iommu.iommu_init();
 
-	for (p = __iommu_table; p < __iommu_table_end; p++) {
-		if (p && (p->flags & IOMMU_DETECTED) && p->late_init)
-			p->late_init();
+#ifdef CONFIG_SWIOTLB
+	/* An IOMMU turned us off. */
+	if (x86_swiotlb_enable) {
+		printk(KERN_INFO "PCI-DMA: "
+		       "Using software bounce buffering for IO (SWIOTLB)\n");
+		swiotlb_print_info();
+	} else {
+		swiotlb_exit();
 	}
+#endif
 
 	return 0;
 }
@@ -154,3 +200,27 @@ static void via_no_dac(struct pci_dev *dev)
 DECLARE_PCI_FIXUP_CLASS_FINAL(PCI_VENDOR_ID_VIA, PCI_ANY_ID,
 				PCI_CLASS_BRIDGE_PCI, 8, via_no_dac);
 #endif
+
+#ifdef CONFIG_SWIOTLB_XEN
+int pci_xen_swiotlb_init_late(void)
+{
+	int rc;
+
+	if (xen_swiotlb)
+		return 0;
+
+	rc = xen_swiotlb_init();
+	if (rc)
+		return rc;
+
+	/* XXX: this switches the dma ops under live devices! */
+	dma_ops = &xen_swiotlb_dma_ops;
+#ifdef CONFIG_PCI
+	/* Make sure ACS will be enabled */
+	pci_request_acs();
+#endif
+
+	return 0;
+}
+EXPORT_SYMBOL_GPL(pci_xen_swiotlb_init_late);
+#endif /* CONFIG_SWIOTLB_XEN */
diff --git a/arch/x86/kernel/pci-iommu_table.c b/arch/x86/kernel/pci-iommu_table.c
deleted file mode 100644
index 42e92ec62973b..0000000000000
--- a/arch/x86/kernel/pci-iommu_table.c
+++ /dev/null
@@ -1,77 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0
-#include <linux/dma-mapping.h>
-#include <asm/iommu_table.h>
-#include <linux/string.h>
-#include <linux/kallsyms.h>
-
-static struct iommu_table_entry * __init
-find_dependents_of(struct iommu_table_entry *start,
-		   struct iommu_table_entry *finish,
-		   struct iommu_table_entry *q)
-{
-	struct iommu_table_entry *p;
-
-	if (!q)
-		return NULL;
-
-	for (p = start; p < finish; p++)
-		if (p->detect == q->depend)
-			return p;
-
-	return NULL;
-}
-
-
-void __init sort_iommu_table(struct iommu_table_entry *start,
-			     struct iommu_table_entry *finish) {
-
-	struct iommu_table_entry *p, *q, tmp;
-
-	for (p = start; p < finish; p++) {
-again:
-		q = find_dependents_of(start, finish, p);
-		/* We are bit sneaky here. We use the memory address to figure
-		 * out if the node we depend on is past our point, if so, swap.
-		 */
-		if (q > p) {
-			tmp = *p;
-			memmove(p, q, sizeof(*p));
-			*q = tmp;
-			goto again;
-		}
-	}
-
-}
-
-#ifdef DEBUG
-void __init check_iommu_entries(struct iommu_table_entry *start,
-				struct iommu_table_entry *finish)
-{
-	struct iommu_table_entry *p, *q, *x;
-
-	/* Simple cyclic dependency checker. */
-	for (p = start; p < finish; p++) {
-		q = find_dependents_of(start, finish, p);
-		x = find_dependents_of(start, finish, q);
-		if (p == x) {
-			printk(KERN_ERR "CYCLIC DEPENDENCY FOUND! %pS depends on %pS and vice-versa. BREAKING IT.\n",
-			       p->detect, q->detect);
-			/* Heavy handed way..*/
-			x->depend = NULL;
-		}
-	}
-
-	for (p = start; p < finish; p++) {
-		q = find_dependents_of(p, finish, p);
-		if (q && q > p) {
-			printk(KERN_ERR "EXECUTION ORDER INVALID! %pS should be called before %pS!\n",
-			       p->detect, q->detect);
-		}
-	}
-}
-#else
-void __init check_iommu_entries(struct iommu_table_entry *start,
-				       struct iommu_table_entry *finish)
-{
-}
-#endif
diff --git a/arch/x86/kernel/pci-swiotlb.c b/arch/x86/kernel/pci-swiotlb.c
deleted file mode 100644
index 814ab46a0dada..0000000000000
--- a/arch/x86/kernel/pci-swiotlb.c
+++ /dev/null
@@ -1,77 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0
-
-#include <linux/pci.h>
-#include <linux/cache.h>
-#include <linux/init.h>
-#include <linux/swiotlb.h>
-#include <linux/memblock.h>
-#include <linux/dma-direct.h>
-#include <linux/cc_platform.h>
-
-#include <asm/iommu.h>
-#include <asm/swiotlb.h>
-#include <asm/dma.h>
-#include <asm/xen/swiotlb-xen.h>
-#include <asm/iommu_table.h>
-
-int swiotlb __read_mostly;
-
-/*
- * pci_swiotlb_detect_override - set swiotlb to 1 if necessary
- *
- * This returns non-zero if we are forced to use swiotlb (by the boot
- * option).
- */
-int __init pci_swiotlb_detect_override(void)
-{
-	if (swiotlb_force == SWIOTLB_FORCE)
-		swiotlb = 1;
-
-	return swiotlb;
-}
-IOMMU_INIT_FINISH(pci_swiotlb_detect_override,
-		  pci_xen_swiotlb_detect,
-		  pci_swiotlb_init,
-		  pci_swiotlb_late_init);
-
-/*
- * If 4GB or more detected (and iommu=off not set) or if SME is active
- * then set swiotlb to 1 and return 1.
- */
-int __init pci_swiotlb_detect_4gb(void)
-{
-	/* don't initialize swiotlb if iommu=off (no_iommu=1) */
-	if (!no_iommu && max_possible_pfn > MAX_DMA32_PFN)
-		swiotlb = 1;
-
-	/*
-	 * Set swiotlb to 1 so that bounce buffers are allocated and used for
-	 * devices that can't support DMA to encrypted memory.
-	 */
-	if (cc_platform_has(CC_ATTR_HOST_MEM_ENCRYPT))
-		swiotlb = 1;
-
-	return swiotlb;
-}
-IOMMU_INIT(pci_swiotlb_detect_4gb,
-	   pci_swiotlb_detect_override,
-	   pci_swiotlb_init,
-	   pci_swiotlb_late_init);
-
-void __init pci_swiotlb_init(void)
-{
-	if (swiotlb)
-		swiotlb_init(0);
-}
-
-void __init pci_swiotlb_late_init(void)
-{
-	/* An IOMMU turned us off. */
-	if (!swiotlb)
-		swiotlb_exit();
-	else {
-		printk(KERN_INFO "PCI-DMA: "
-		       "Using software bounce buffering for IO (SWIOTLB)\n");
-		swiotlb_print_info();
-	}
-}
diff --git a/arch/x86/kernel/tboot.c b/arch/x86/kernel/tboot.c
index f9af561c3cd4f..0c1154a1c4032 100644
--- a/arch/x86/kernel/tboot.c
+++ b/arch/x86/kernel/tboot.c
@@ -24,7 +24,6 @@
 #include <asm/processor.h>
 #include <asm/bootparam.h>
 #include <asm/pgalloc.h>
-#include <asm/swiotlb.h>
 #include <asm/fixmap.h>
 #include <asm/proto.h>
 #include <asm/setup.h>
diff --git a/arch/x86/kernel/vmlinux.lds.S b/arch/x86/kernel/vmlinux.lds.S
index 27f830345b6f0..bbe910c15b293 100644
--- a/arch/x86/kernel/vmlinux.lds.S
+++ b/arch/x86/kernel/vmlinux.lds.S
@@ -306,18 +306,6 @@ SECTIONS
 		*(.altinstr_replacement)
 	}
 
-	/*
-	 * struct iommu_table_entry entries are injected in this section.
-	 * It is an array of IOMMUs which during run time gets sorted depending
-	 * on its dependency order. After rootfs_initcall is complete
-	 * this section can be safely removed.
-	 */
-	.iommu_table : AT(ADDR(.iommu_table) - LOAD_OFFSET) {
-		__iommu_table = .;
-		*(.iommu_table)
-		__iommu_table_end = .;
-	}
-
 	. = ALIGN(8);
 	.apicdrivers : AT(ADDR(.apicdrivers) - LOAD_OFFSET) {
 		__apicdrivers = .;
diff --git a/arch/x86/xen/Makefile b/arch/x86/xen/Makefile
index 4953260e281c3..3c5b52fbe4a7f 100644
--- a/arch/x86/xen/Makefile
+++ b/arch/x86/xen/Makefile
@@ -47,6 +47,4 @@ obj-$(CONFIG_XEN_DEBUG_FS)	+= debugfs.o
 
 obj-$(CONFIG_XEN_PV_DOM0)	+= vga.o
 
-obj-$(CONFIG_SWIOTLB_XEN)	+= pci-swiotlb-xen.o
-
 obj-$(CONFIG_XEN_EFI)		+= efi.o
diff --git a/arch/x86/xen/pci-swiotlb-xen.c b/arch/x86/xen/pci-swiotlb-xen.c
deleted file mode 100644
index 46df59aeaa06a..0000000000000
--- a/arch/x86/xen/pci-swiotlb-xen.c
+++ /dev/null
@@ -1,96 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0
-
-/* Glue code to lib/swiotlb-xen.c */
-
-#include <linux/dma-map-ops.h>
-#include <linux/pci.h>
-#include <xen/swiotlb-xen.h>
-
-#include <asm/xen/hypervisor.h>
-#include <xen/xen.h>
-#include <asm/iommu_table.h>
-
-
-#include <asm/xen/swiotlb-xen.h>
-#ifdef CONFIG_X86_64
-#include <asm/iommu.h>
-#include <asm/dma.h>
-#endif
-#include <linux/export.h>
-
-static int xen_swiotlb __read_mostly;
-
-/*
- * pci_xen_swiotlb_detect - set xen_swiotlb to 1 if necessary
- *
- * This returns non-zero if we are forced to use xen_swiotlb (by the boot
- * option).
- */
-int __init pci_xen_swiotlb_detect(void)
-{
-
-	if (!xen_pv_domain())
-		return 0;
-
-	/* If running as PV guest, either iommu=soft, or swiotlb=force will
-	 * activate this IOMMU. If running as PV privileged, activate it
-	 * irregardless.
-	 */
-	if (xen_initial_domain() || swiotlb || swiotlb_force == SWIOTLB_FORCE)
-		xen_swiotlb = 1;
-
-	/* If we are running under Xen, we MUST disable the native SWIOTLB.
-	 * Don't worry about swiotlb_force flag activating the native, as
-	 * the 'swiotlb' flag is the only one turning it on. */
-	swiotlb = 0;
-
-#ifdef CONFIG_X86_64
-	/* pci_swiotlb_detect_4gb turns on native SWIOTLB if no_iommu == 0
-	 * (so no iommu=X command line over-writes).
-	 * Considering that PV guests do not want the *native SWIOTLB* but
-	 * only Xen SWIOTLB it is not useful to us so set no_iommu=1 here.
-	 */
-	if (max_pfn > MAX_DMA32_PFN)
-		no_iommu = 1;
-#endif
-	return xen_swiotlb;
-}
-
-static void __init pci_xen_swiotlb_init(void)
-{
-	if (xen_swiotlb) {
-		xen_swiotlb_init_early();
-		dma_ops = &xen_swiotlb_dma_ops;
-
-#ifdef CONFIG_PCI
-		/* Make sure ACS will be enabled */
-		pci_request_acs();
-#endif
-	}
-}
-
-int pci_xen_swiotlb_init_late(void)
-{
-	int rc;
-
-	if (xen_swiotlb)
-		return 0;
-
-	rc = xen_swiotlb_init();
-	if (rc)
-		return rc;
-
-	dma_ops = &xen_swiotlb_dma_ops;
-#ifdef CONFIG_PCI
-	/* Make sure ACS will be enabled */
-	pci_request_acs();
-#endif
-
-	return 0;
-}
-EXPORT_SYMBOL_GPL(pci_xen_swiotlb_init_late);
-
-IOMMU_INIT_FINISH(pci_xen_swiotlb_detect,
-		  NULL,
-		  pci_xen_swiotlb_init,
-		  NULL);
diff --git a/drivers/iommu/amd/init.c b/drivers/iommu/amd/init.c
index b10fb52ea4428..721300cf90207 100644
--- a/drivers/iommu/amd/init.c
+++ b/drivers/iommu/amd/init.c
@@ -27,7 +27,6 @@
 #include <asm/apic.h>
 #include <asm/gart.h>
 #include <asm/x86_init.h>
-#include <asm/iommu_table.h>
 #include <asm/io_apic.h>
 #include <asm/irq_remapping.h>
 #include <asm/set_memory.h>
@@ -3237,11 +3236,6 @@ __setup("ivrs_ioapic",		parse_ivrs_ioapic);
 __setup("ivrs_hpet",		parse_ivrs_hpet);
 __setup("ivrs_acpihid",		parse_ivrs_acpihid);
 
-IOMMU_INIT_FINISH(amd_iommu_detect,
-		  gart_iommu_hole_init,
-		  NULL,
-		  NULL);
-
 bool amd_iommu_v2_supported(void)
 {
 	return amd_iommu_v2_present;
diff --git a/drivers/iommu/amd/iommu.c b/drivers/iommu/amd/iommu.c
index 461f1844ed1fb..4f9672b18ad1a 100644
--- a/drivers/iommu/amd/iommu.c
+++ b/drivers/iommu/amd/iommu.c
@@ -1834,7 +1834,10 @@ void amd_iommu_domain_update(struct protection_domain *domain)
 
 static void __init amd_iommu_init_dma_ops(void)
 {
-	swiotlb = (iommu_default_passthrough() || sme_me_mask) ? 1 : 0;
+	if (iommu_default_passthrough() || sme_me_mask) 
+		x86_swiotlb_enable = true;
+	else
+		x86_swiotlb_enable = false;
 }
 
 int __init amd_iommu_init_api(void)
diff --git a/drivers/iommu/intel/dmar.c b/drivers/iommu/intel/dmar.c
index 915bff76fe965..29bee4b210c5b 100644
--- a/drivers/iommu/intel/dmar.c
+++ b/drivers/iommu/intel/dmar.c
@@ -30,7 +30,6 @@
 #include <linux/numa.h>
 #include <linux/limits.h>
 #include <asm/irq_remapping.h>
-#include <asm/iommu_table.h>
 #include <trace/events/intel_iommu.h>
 
 #include "../irq_remapping.h"
@@ -913,7 +912,7 @@ dmar_validate_one_drhd(struct acpi_dmar_header *entry, void *arg)
 	return 0;
 }
 
-int __init detect_intel_iommu(void)
+void __init detect_intel_iommu(void)
 {
 	int ret;
 	struct dmar_res_callback validate_drhd_cb = {
@@ -946,8 +945,6 @@ int __init detect_intel_iommu(void)
 		dmar_tbl = NULL;
 	}
 	up_write(&dmar_global_lock);
-
-	return ret ? ret : 1;
 }
 
 static void unmap_iommu(struct intel_iommu *iommu)
@@ -2165,7 +2162,6 @@ static int __init dmar_free_unused_resources(void)
 }
 
 late_initcall(dmar_free_unused_resources);
-IOMMU_INIT_POST(detect_intel_iommu);
 
 /*
  * DMAR Hotplug Support
diff --git a/include/linux/dmar.h b/include/linux/dmar.h
index 45e903d847335..cbd714a198a0a 100644
--- a/include/linux/dmar.h
+++ b/include/linux/dmar.h
@@ -121,7 +121,7 @@ extern int dmar_remove_dev_scope(struct dmar_pci_notify_info *info,
 				 u16 segment, struct dmar_dev_scope *devices,
 				 int count);
 /* Intel IOMMU detection */
-extern int detect_intel_iommu(void);
+void detect_intel_iommu(void);
 extern int enable_drhd_fault_handling(void);
 extern int dmar_device_add(acpi_handle handle);
 extern int dmar_device_remove(acpi_handle handle);
@@ -197,6 +197,10 @@ static inline bool dmar_platform_optin(void)
 	return false;
 }
 
+static inline void detect_intel_iommu(void)
+{
+}
+
 #endif /* CONFIG_DMAR_TABLE */
 
 struct irte {
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Tue Feb 22 15:36:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 15:36:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276984.473431 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMXDI-0002ss-A7; Tue, 22 Feb 2022 15:36:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276984.473431; Tue, 22 Feb 2022 15:36:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMXDI-0002rc-2X; Tue, 22 Feb 2022 15:36:28 +0000
Received: by outflank-mailman (input) for mailman id 276984;
 Tue, 22 Feb 2022 15:36:26 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=CFyZ=TF=bombadil.srs.infradead.org=BATV+11ac0858211c0bd5236f+6757+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nMXCw-0005NI-1q
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 15:36:06 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 24fcf85c-93f5-11ec-8539-5f4723681683;
 Tue, 22 Feb 2022 16:36:04 +0100 (CET)
Received: from [2001:4bb8:198:f8fc:c22a:ebfc:be8d:63c2] (helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nMXCe-00AH73-Qo; Tue, 22 Feb 2022 15:35:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 24fcf85c-93f5-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=zCMW1Q+QCPXYuvBuEGOZUQKFwE9OwdLFtYhltvQ29K4=; b=UivVJu0xfBlRElPO98LGgBvic3
	FgFkBA8tXOAwbzm4ASFviz4SOlLZ2Xk5ojd8aBpgvcYaCCrlUt0AmrI5QXz9BLb9cU7dErlkZgnz3
	IzVqfHy80xQHgtYs4YtsJIktFe5xVp6loPXsAhY+LqtEtDSPdoKeEjZiqWlkk7Equu3WmJaFkQpSY
	nCZa1Oyt2hQQICm8D2KgV+1H1RPCuXGZ7ggZgJ+BM2gIRjfpfUXSW4OsSGdg/5dox+XsD7+FHqwZ8
	loSXrmeHFqVxP2h0pkLAiL/0DZ/bH24KlkPtKONU0U65lHnthcy9X8oVbBAOSQMLGRq8tZSF7/H/x
	UnbZJ7Dg==;
From: Christoph Hellwig <hch@lst.de>
To: iommu@lists.linux-foundation.org
Cc: x86@kernel.org,
	Stefano Stabellini <sstabellini@kernel.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Joerg Roedel <joro@8bytes.org>,
	David Woodhouse <dwmw2@infradead.org>,
	Lu Baolu <baolu.lu@linux.intel.com>,
	Robin Murphy <robin.murphy@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	xen-devel@lists.xenproject.org,
	linux-ia64@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	tboot-devel@lists.sourceforge.net,
	linux-pci@vger.kernel.org
Subject: [PATCH 11/11] x86: remove cruft from <asm/dma-mapping.h>
Date: Tue, 22 Feb 2022 16:35:14 +0100
Message-Id: <20220222153514.593231-12-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220222153514.593231-1-hch@lst.de>
References: <20220222153514.593231-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

<asm/dma-mapping.h> gets pulled in by all drivers using the DMA API.
Remove x86 internal variables and unnecessary includes from it.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 arch/x86/include/asm/dma-mapping.h | 11 -----------
 arch/x86/include/asm/iommu.h       |  2 ++
 2 files changed, 2 insertions(+), 11 deletions(-)

diff --git a/arch/x86/include/asm/dma-mapping.h b/arch/x86/include/asm/dma-mapping.h
index 256fd8115223d..1c66708e30623 100644
--- a/arch/x86/include/asm/dma-mapping.h
+++ b/arch/x86/include/asm/dma-mapping.h
@@ -2,17 +2,6 @@
 #ifndef _ASM_X86_DMA_MAPPING_H
 #define _ASM_X86_DMA_MAPPING_H
 
-/*
- * IOMMU interface. See Documentation/core-api/dma-api-howto.rst and
- * Documentation/core-api/dma-api.rst for documentation.
- */
-
-#include <linux/scatterlist.h>
-#include <asm/io.h>
-
-extern int iommu_merge;
-extern int panic_on_overflow;
-
 extern const struct dma_map_ops *dma_ops;
 
 static inline const struct dma_map_ops *get_arch_dma_ops(struct bus_type *bus)
diff --git a/arch/x86/include/asm/iommu.h b/arch/x86/include/asm/iommu.h
index dba89ed40d38d..0bef44d30a278 100644
--- a/arch/x86/include/asm/iommu.h
+++ b/arch/x86/include/asm/iommu.h
@@ -8,6 +8,8 @@
 
 extern int force_iommu, no_iommu;
 extern int iommu_detected;
+extern int iommu_merge;
+extern int panic_on_overflow;
 
 #ifdef CONFIG_SWIOTLB
 extern bool x86_swiotlb_enable;
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Tue Feb 22 15:36:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 15:36:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276987.473437 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMXDI-0002yv-Tw; Tue, 22 Feb 2022 15:36:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276987.473437; Tue, 22 Feb 2022 15:36:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMXDI-0002w3-Gk; Tue, 22 Feb 2022 15:36:28 +0000
Received: by outflank-mailman (input) for mailman id 276987;
 Tue, 22 Feb 2022 15:36:27 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=CFyZ=TF=bombadil.srs.infradead.org=BATV+11ac0858211c0bd5236f+6757+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nMXCY-0005NI-2l
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 15:35:42 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 16adb339-93f5-11ec-8539-5f4723681683;
 Tue, 22 Feb 2022 16:35:40 +0100 (CET)
Received: from [2001:4bb8:198:f8fc:c22a:ebfc:be8d:63c2] (helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nMXCH-00AGql-BP; Tue, 22 Feb 2022 15:35:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 16adb339-93f5-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=UFY4OZ6N/wy4hplyc9bnUfbK5AWbWfDm8QyseyxAO7o=; b=fXLXkO/oMmt1SoC45j8cVI580X
	KhuFotBP7XRh1oq2KCz6EchruRdwnkzG4ZcxTnbQVLtkq3kP2o5DFjJjp56+EH5PM1LDnIBiNrybS
	yQgfvP08+rABWoTJ05VSkwYH1ChMrs8k845H67bcAAmAfZ2U+9r21GydfLpSXQ3lBsZ0pS+9fQ2rm
	x+/NGz/GeXDT55Ba85crPsBVglG4OptgiOE0FHEv133Jj4hb0w76PzYW/SyPTmW0iJSGmUv/UNt3V
	uX6eXmBV81r3cKZJvL2MwoIe7oP37qXr7iKycKKD7WtFBxOdwsBGT1Xe9tvqC7DOpEjl7fUemw/0l
	uz8xIoBw==;
From: Christoph Hellwig <hch@lst.de>
To: iommu@lists.linux-foundation.org
Cc: x86@kernel.org,
	Stefano Stabellini <sstabellini@kernel.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Joerg Roedel <joro@8bytes.org>,
	David Woodhouse <dwmw2@infradead.org>,
	Lu Baolu <baolu.lu@linux.intel.com>,
	Robin Murphy <robin.murphy@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	xen-devel@lists.xenproject.org,
	linux-ia64@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	tboot-devel@lists.sourceforge.net,
	linux-pci@vger.kernel.org
Subject: [PATCH 03/11] swiotlb: simplify swiotlb_max_segment
Date: Tue, 22 Feb 2022 16:35:06 +0100
Message-Id: <20220222153514.593231-4-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220222153514.593231-1-hch@lst.de>
References: <20220222153514.593231-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Remove the bogus Xen override that was usually larger than the actual
size and just calculate the value on demand.  Note that
swiotlb_max_segment still doesn't make sense as an interface and should
eventually be removed.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 drivers/xen/swiotlb-xen.c |  2 --
 include/linux/swiotlb.h   |  1 -
 kernel/dma/swiotlb.c      | 20 +++-----------------
 3 files changed, 3 insertions(+), 20 deletions(-)

diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c
index 47aebd98f52f5..485cd06ed39e7 100644
--- a/drivers/xen/swiotlb-xen.c
+++ b/drivers/xen/swiotlb-xen.c
@@ -202,7 +202,6 @@ int xen_swiotlb_init(void)
 	rc = swiotlb_late_init_with_tbl(start, nslabs);
 	if (rc)
 		return rc;
-	swiotlb_set_max_segment(PAGE_SIZE);
 	return 0;
 error:
 	if (nslabs > 1024 && repeat--) {
@@ -254,7 +253,6 @@ void __init xen_swiotlb_init_early(void)
 
 	if (swiotlb_init_with_tbl(start, nslabs, true))
 		panic("Cannot allocate SWIOTLB buffer");
-	swiotlb_set_max_segment(PAGE_SIZE);
 }
 #endif /* CONFIG_X86 */
 
diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h
index f6c3638255d54..9fb3a568f0c51 100644
--- a/include/linux/swiotlb.h
+++ b/include/linux/swiotlb.h
@@ -164,7 +164,6 @@ static inline void swiotlb_adjust_size(unsigned long size)
 #endif /* CONFIG_SWIOTLB */
 
 extern void swiotlb_print_info(void);
-extern void swiotlb_set_max_segment(unsigned int);
 
 #ifdef CONFIG_DMA_RESTRICTED_POOL
 struct page *swiotlb_alloc(struct device *dev, size_t size);
diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c
index 36fbf1181d285..519e363097190 100644
--- a/kernel/dma/swiotlb.c
+++ b/kernel/dma/swiotlb.c
@@ -75,12 +75,6 @@ struct io_tlb_mem io_tlb_default_mem;
 
 phys_addr_t swiotlb_unencrypted_base;
 
-/*
- * Max segment that we can provide which (if pages are contingous) will
- * not be bounced (unless SWIOTLB_FORCE is set).
- */
-static unsigned int max_segment;
-
 static unsigned long default_nslabs = IO_TLB_DEFAULT_SIZE >> IO_TLB_SHIFT;
 
 static int __init
@@ -104,18 +98,12 @@ early_param("swiotlb", setup_io_tlb_npages);
 
 unsigned int swiotlb_max_segment(void)
 {
-	return io_tlb_default_mem.nslabs ? max_segment : 0;
+	if (!io_tlb_default_mem.nslabs)
+		return 0;
+	return rounddown(io_tlb_default_mem.nslabs << IO_TLB_SHIFT, PAGE_SIZE);
 }
 EXPORT_SYMBOL_GPL(swiotlb_max_segment);
 
-void swiotlb_set_max_segment(unsigned int val)
-{
-	if (swiotlb_force == SWIOTLB_FORCE)
-		max_segment = 1;
-	else
-		max_segment = rounddown(val, PAGE_SIZE);
-}
-
 unsigned long swiotlb_size_or_default(void)
 {
 	return default_nslabs << IO_TLB_SHIFT;
@@ -267,7 +255,6 @@ int __init swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, int verbose)
 
 	if (verbose)
 		swiotlb_print_info();
-	swiotlb_set_max_segment(mem->nslabs << IO_TLB_SHIFT);
 	return 0;
 }
 
@@ -368,7 +355,6 @@ swiotlb_late_init_with_tbl(char *tlb, unsigned long nslabs)
 	swiotlb_init_io_tlb_mem(mem, virt_to_phys(tlb), nslabs, true);
 
 	swiotlb_print_info();
-	swiotlb_set_max_segment(mem->nslabs << IO_TLB_SHIFT);
 	return 0;
 }
 
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Tue Feb 22 15:36:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 15:36:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276989.473449 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMXDK-0003UV-OB; Tue, 22 Feb 2022 15:36:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276989.473449; Tue, 22 Feb 2022 15:36:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMXDK-0003Ry-BO; Tue, 22 Feb 2022 15:36:30 +0000
Received: by outflank-mailman (input) for mailman id 276989;
 Tue, 22 Feb 2022 15:36:28 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=CFyZ=TF=bombadil.srs.infradead.org=BATV+11ac0858211c0bd5236f+6757+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nMXCY-0005NI-M0
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 15:35:42 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 16ffa7fc-93f5-11ec-8539-5f4723681683;
 Tue, 22 Feb 2022 16:35:41 +0100 (CET)
Received: from [2001:4bb8:198:f8fc:c22a:ebfc:be8d:63c2] (helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nMXCN-00AGuY-3o; Tue, 22 Feb 2022 15:35:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 16ffa7fc-93f5-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=k7VCAGgZLUopw8ZEUPa9uXgMMuu7kLgWtRRokFUkJX4=; b=L5ktqXpI6cZSlh8wcsM0xrs2Ne
	mNy7uHJeF8Am2B81b2lUuNqXfVXRQiDA/YDxQ3DyO/TCY7060j0/iiI9u74Za8JoAdB2LKavmo/ix
	r2hZpcyv2rFPn4dvMposvZSexDcbi5I5j0Zldfh+Bqk4AbjW1Z3dRIIANefzQQItFgbYDcEh9ZdYX
	9P+7KoFzGpvYI4Upc4Tzf5sk6FEHIfk+7cnqz5GIDCrlIm6ZPtNgwSECO+3b1EPmIBLHz4NrReE5H
	ZtiBkLSC+9L2lTKI6dTd3fAo0Uu3x7Qqaiqb1s+SSBoqN0Ltq6eKyTYYc6mE0gZOzn1a6Qvh682jQ
	HOy0PXtw==;
From: Christoph Hellwig <hch@lst.de>
To: iommu@lists.linux-foundation.org
Cc: x86@kernel.org,
	Stefano Stabellini <sstabellini@kernel.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Joerg Roedel <joro@8bytes.org>,
	David Woodhouse <dwmw2@infradead.org>,
	Lu Baolu <baolu.lu@linux.intel.com>,
	Robin Murphy <robin.murphy@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	xen-devel@lists.xenproject.org,
	linux-ia64@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	tboot-devel@lists.sourceforge.net,
	linux-pci@vger.kernel.org
Subject: [PATCH 05/11] swiotlb: pass a gfp_mask argument to swiotlb_init_late
Date: Tue, 22 Feb 2022 16:35:08 +0100
Message-Id: <20220222153514.593231-6-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220222153514.593231-1-hch@lst.de>
References: <20220222153514.593231-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Let the caller chose a zone to allocate from.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 arch/x86/pci/sta2x11-fixup.c | 2 +-
 include/linux/swiotlb.h      | 2 +-
 kernel/dma/swiotlb.c         | 4 ++--
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/x86/pci/sta2x11-fixup.c b/arch/x86/pci/sta2x11-fixup.c
index e0c039a75b2db..c7e6faf59a861 100644
--- a/arch/x86/pci/sta2x11-fixup.c
+++ b/arch/x86/pci/sta2x11-fixup.c
@@ -57,7 +57,7 @@ static void sta2x11_new_instance(struct pci_dev *pdev)
 		int size = STA2X11_SWIOTLB_SIZE;
 		/* First instance: register your own swiotlb area */
 		dev_info(&pdev->dev, "Using SWIOTLB (size %i)\n", size);
-		if (swiotlb_init_late(size))
+		if (swiotlb_init_late(size, GFP_DMA))
 			dev_emerg(&pdev->dev, "init swiotlb failed\n");
 	}
 	list_add(&instance->list, &sta2x11_instance_list);
diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h
index b48b26bfa0edb..1befd6b2ccf5e 100644
--- a/include/linux/swiotlb.h
+++ b/include/linux/swiotlb.h
@@ -40,7 +40,7 @@ extern void swiotlb_init(int verbose);
 int swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, int verbose);
 unsigned long swiotlb_size_or_default(void);
 extern int swiotlb_late_init_with_tbl(char *tlb, unsigned long nslabs);
-int swiotlb_init_late(size_t size);
+int swiotlb_init_late(size_t size, gfp_t gfp_mask);
 extern void __init swiotlb_update_mem_attributes(void);
 
 phys_addr_t swiotlb_tbl_map_single(struct device *hwdev, phys_addr_t phys,
diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c
index 5f64b02fbb732..a653fcf1fe6c2 100644
--- a/kernel/dma/swiotlb.c
+++ b/kernel/dma/swiotlb.c
@@ -290,7 +290,7 @@ swiotlb_init(int verbose)
  * initialize the swiotlb later using the slab allocator if needed.
  * This should be just like above, but with some error catching.
  */
-int swiotlb_init_late(size_t size)
+int swiotlb_init_late(size_t size, gfp_t gfp_mask)
 {
 	unsigned long nslabs = ALIGN(size >> IO_TLB_SHIFT, IO_TLB_SEGSIZE);
 	unsigned long bytes;
@@ -309,7 +309,7 @@ int swiotlb_init_late(size_t size)
 	bytes = nslabs << IO_TLB_SHIFT;
 
 	while ((SLABS_PER_PAGE << order) > IO_TLB_MIN_SLABS) {
-		vstart = (void *)__get_free_pages(GFP_DMA | __GFP_NOWARN,
+		vstart = (void *)__get_free_pages(gfp_mask | __GFP_NOWARN,
 						  order);
 		if (vstart)
 			break;
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Tue Feb 22 15:36:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 15:36:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.276993.473462 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMXDM-0003xn-F8; Tue, 22 Feb 2022 15:36:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 276993.473462; Tue, 22 Feb 2022 15:36:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMXDM-0003vT-0K; Tue, 22 Feb 2022 15:36:32 +0000
Received: by outflank-mailman (input) for mailman id 276993;
 Tue, 22 Feb 2022 15:36:29 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=CFyZ=TF=bombadil.srs.infradead.org=BATV+11ac0858211c0bd5236f+6757+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nMXCW-0005NI-Lr
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 15:35:40 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 15d6f2f3-93f5-11ec-8539-5f4723681683;
 Tue, 22 Feb 2022 16:35:39 +0100 (CET)
Received: from [2001:4bb8:198:f8fc:c22a:ebfc:be8d:63c2] (helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nMXCK-00AGsO-44; Tue, 22 Feb 2022 15:35:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 15d6f2f3-93f5-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=9PCjPLhSqZcgfJRctho4koItZMxPltxaP4qWUl/wyyA=; b=JJUHrcNZ1kNN3tSzob4t5R7t3+
	PCuRgk9xbWb6yWLBGmK+6JZ+jGFCksYQ71JCwFj9uzkGkNY9GP6CZ1wJXzFdC9wpqOz30KMw8BUTe
	GcY3b6EojVBIUW73wf4VLvrgni1cfsMV+C4o4VPLhWjGDwoXSWonErbuai3Y1J8976p6Bx6tsquww
	atmJGFG7584Is3iOa9A6/Juz52RncXNayc7j9jWnMF/k1pdXyanbovW4sSjUSpkVN1Xq8e9kpgsCO
	cohitJNqLLdD2vC4Xax4YFjUr59Q5CoLzU0PbqT5Cs+k9BeWFonUmBnnDxkzQdDt1FwAfxKcQQnQ4
	jUjHEj0A==;
From: Christoph Hellwig <hch@lst.de>
To: iommu@lists.linux-foundation.org
Cc: x86@kernel.org,
	Stefano Stabellini <sstabellini@kernel.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Joerg Roedel <joro@8bytes.org>,
	David Woodhouse <dwmw2@infradead.org>,
	Lu Baolu <baolu.lu@linux.intel.com>,
	Robin Murphy <robin.murphy@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	xen-devel@lists.xenproject.org,
	linux-ia64@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	tboot-devel@lists.sourceforge.net,
	linux-pci@vger.kernel.org
Subject: [PATCH 04/11] swiotlb: rename swiotlb_late_init_with_default_size
Date: Tue, 22 Feb 2022 16:35:07 +0100
Message-Id: <20220222153514.593231-5-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220222153514.593231-1-hch@lst.de>
References: <20220222153514.593231-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

swiotlb_late_init_with_default_size is an overly verbose name that
doesn't even catch what the function is doing, given that the size is
not just a default but the actual requested size.

Rename it to swiotlb_init_late.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 arch/x86/pci/sta2x11-fixup.c | 2 +-
 include/linux/swiotlb.h      | 2 +-
 kernel/dma/swiotlb.c         | 6 ++----
 3 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/arch/x86/pci/sta2x11-fixup.c b/arch/x86/pci/sta2x11-fixup.c
index 101081ad64b6d..e0c039a75b2db 100644
--- a/arch/x86/pci/sta2x11-fixup.c
+++ b/arch/x86/pci/sta2x11-fixup.c
@@ -57,7 +57,7 @@ static void sta2x11_new_instance(struct pci_dev *pdev)
 		int size = STA2X11_SWIOTLB_SIZE;
 		/* First instance: register your own swiotlb area */
 		dev_info(&pdev->dev, "Using SWIOTLB (size %i)\n", size);
-		if (swiotlb_late_init_with_default_size(size))
+		if (swiotlb_init_late(size))
 			dev_emerg(&pdev->dev, "init swiotlb failed\n");
 	}
 	list_add(&instance->list, &sta2x11_instance_list);
diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h
index 9fb3a568f0c51..b48b26bfa0edb 100644
--- a/include/linux/swiotlb.h
+++ b/include/linux/swiotlb.h
@@ -40,7 +40,7 @@ extern void swiotlb_init(int verbose);
 int swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, int verbose);
 unsigned long swiotlb_size_or_default(void);
 extern int swiotlb_late_init_with_tbl(char *tlb, unsigned long nslabs);
-extern int swiotlb_late_init_with_default_size(size_t default_size);
+int swiotlb_init_late(size_t size);
 extern void __init swiotlb_update_mem_attributes(void);
 
 phys_addr_t swiotlb_tbl_map_single(struct device *hwdev, phys_addr_t phys,
diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c
index 519e363097190..5f64b02fbb732 100644
--- a/kernel/dma/swiotlb.c
+++ b/kernel/dma/swiotlb.c
@@ -290,11 +290,9 @@ swiotlb_init(int verbose)
  * initialize the swiotlb later using the slab allocator if needed.
  * This should be just like above, but with some error catching.
  */
-int
-swiotlb_late_init_with_default_size(size_t default_size)
+int swiotlb_init_late(size_t size)
 {
-	unsigned long nslabs =
-		ALIGN(default_size >> IO_TLB_SHIFT, IO_TLB_SEGSIZE);
+	unsigned long nslabs = ALIGN(size >> IO_TLB_SHIFT, IO_TLB_SEGSIZE);
 	unsigned long bytes;
 	unsigned char *vstart = NULL;
 	unsigned int order;
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Tue Feb 22 15:39:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 15:39:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277043.473480 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMXFk-0007HV-Li; Tue, 22 Feb 2022 15:39:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277043.473480; Tue, 22 Feb 2022 15:39:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMXFk-0007HO-Hb; Tue, 22 Feb 2022 15:39:00 +0000
Received: by outflank-mailman (input) for mailman id 277043;
 Tue, 22 Feb 2022 15:38:59 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/+sy=TF=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1nMXFj-0007HH-I2
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 15:38:59 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on20628.outbound.protection.outlook.com
 [2a01:111:f400:7d00::628])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8d16333d-93f5-11ec-8eb8-a37418f5ba1a;
 Tue, 22 Feb 2022 16:38:58 +0100 (CET)
Received: from AS9PR06CA0235.eurprd06.prod.outlook.com (2603:10a6:20b:45e::34)
 by AS8PR08MB6518.eurprd08.prod.outlook.com (2603:10a6:20b:33d::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.26; Tue, 22 Feb
 2022 15:38:49 +0000
Received: from AM5EUR03FT003.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:45e:cafe::54) by AS9PR06CA0235.outlook.office365.com
 (2603:10a6:20b:45e::34) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.16 via Frontend
 Transport; Tue, 22 Feb 2022 15:38:49 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT003.mail.protection.outlook.com (10.152.16.149) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4995.20 via Frontend Transport; Tue, 22 Feb 2022 15:38:49 +0000
Received: ("Tessian outbound 31aeb3346a45:v113");
 Tue, 22 Feb 2022 15:38:49 +0000
Received: from 91edb6eec672.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 7BB290E9-CBAE-4604-8996-015F12530EE6.1; 
 Tue, 22 Feb 2022 15:38:41 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 91edb6eec672.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 22 Feb 2022 15:38:41 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by AM0PR08MB4227.eurprd08.prod.outlook.com (2603:10a6:208:13d::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.16; Tue, 22 Feb
 2022 15:38:39 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::aca7:79c4:fa65:dac6]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::aca7:79c4:fa65:dac6%5]) with mapi id 15.20.5017.021; Tue, 22 Feb 2022
 15:38:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8d16333d-93f5-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=hG5hZwxHduifyNasqAErtaQe++stu5mAH0gYYcFyQ0s=;
 b=accGXiKZHqeQTNDio8pfui21sEvp+xXb8xZ/h3KW0DEmJ6xEasZPjTe7jwZCbn75xgY7Ki2wXB9QplWvv6TGF1veftYhzWdZNwX8oWZtW60r6gKrzWjNQG6pGfHCf5TBi+uxsRvaQgK+B3g7H0tiEfiBwPFA6XBrewAqPo/i+lU=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 19ace998aa105b60
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=BSTIMpp42BCzLCOkXQTRtlPaPynV1R1uMR4iSxNyAM4nfoMGceRK1y7gT8LdaGq5L/Ouw0rALYOkUDpzSxFMinGlVhIpWb17Ann2P2SNzfus8+rbHzTevZ9NXjQ7XqT3cWA3OInO8+292ssP6Ue9o47aYnfloga92I+0PWzdcNM5hc+LnPJ26XsJ7FQ15m08GEOk5Is1Ttwcj5H9pAJTSku1e9Fe71rwPQwESwgkh5NeNJQMRxcgse6FMqnM0UTvE/pvbOJkgJYIWR/xxUU0pKW/MqM9G5nw/2qLvWlHNWarx5EhxYsD6rOWlY/+dqVFiikpKqVyw59szzUm2Rk9iQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=hG5hZwxHduifyNasqAErtaQe++stu5mAH0gYYcFyQ0s=;
 b=DwlpXCFArkJrIf0OmX2gv/oo5PF7gcH++4m+J5xdVAFXgiienFJsstaW8YyT7sPeGKst7V76KyBUFMYt/zcYNCIXBIWvQzoQkuXq1LMpg79+sqC2e49pGnPyAQRn1aPsDXzXMo1who8LJobd4+3M2h8E0ch7vltRwnZcP/xiuR4uZgQVLQTE/vtT+AooHKAR5tdDyywvfWhr7iG7q71T2dtAJ+f5Tge2Iz2+nPkRqLq9nJi1JCz4Kl0KiuzingibjpnrnAl64HvWV87ZvJwRMRjBXhPh+uhlOo5Bzc3qUYjk/kxfzah7aUivFozhoRESJ+QkUjkz8PDSxATf94J0Uw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=hG5hZwxHduifyNasqAErtaQe++stu5mAH0gYYcFyQ0s=;
 b=accGXiKZHqeQTNDio8pfui21sEvp+xXb8xZ/h3KW0DEmJ6xEasZPjTe7jwZCbn75xgY7Ki2wXB9QplWvv6TGF1veftYhzWdZNwX8oWZtW60r6gKrzWjNQG6pGfHCf5TBi+uxsRvaQgK+B3g7H0tiEfiBwPFA6XBrewAqPo/i+lU=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Julien Grall <julien@xen.org>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Julien
 Grall <jgrall@amazon.com>, Stefano Stabellini <sstabellini@kernel.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v3 02/19] xen/arm: lpae: Use the generic helpers to
 defined the Xen PT helpers
Thread-Topic: [PATCH v3 02/19] xen/arm: lpae: Use the generic helpers to
 defined the Xen PT helpers
Thread-Index: AQHYJwzzAwNINZlSVEGzkyGeEn5gtayftmsA
Date: Tue, 22 Feb 2022 15:38:38 +0000
Message-ID: <2DB6D0E3-E220-47C1-BB01-E4679AFA34EC@arm.com>
References: <20220221102218.33785-1-julien@xen.org>
 <20220221102218.33785-3-julien@xen.org>
In-Reply-To: <20220221102218.33785-3-julien@xen.org>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3693.60.0.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 2d94aa4b-cdb7-42f4-22b6-08d9f6196c22
x-ms-traffictypediagnostic:
	AM0PR08MB4227:EE_|AM5EUR03FT003:EE_|AS8PR08MB6518:EE_
X-Microsoft-Antispam-PRVS:
	<AS8PR08MB6518FC6004D7D2822233FDC69D3B9@AS8PR08MB6518.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 DOA2iP8sUc9vaEQaCbBBqh7ctN7Rmz5/xXm3SxtWry31F+SBN7JuenOzIE9ShCv5gi+Fu3Jt7fpt2EquV+1YOP8grRuAbofzji/oeXyvfK0gmss0pCAgGPaWiHU/+h+dFSfGPKFyCjj49ibBGsiUQQ/sGHqyHjUccSNEToX6dzDbuxp34SwpekX7IblSreBBIvJ6+MsH+SvpE6ZIhq6zljGNFj9mYXjvUahI7BBWqTBE8M3IIr0Xy16Bi2GFg1TdUxkf6uQxn1gravxYu9l94/2u/9qnCMyQSpx9iFSFrhtCfnxhtF/v+u6DXEPpalXV8T99DbF9Rw12atbL1hwPNRzMMEuu4aSQBvYvW1IpekmM9tF4kIPbEvLPu1arXYpSkxt4R8EVpz9JCuZVtvnUB46NuYqORrMTgYvkwh9kY8Lub7Zqx3X0Z8G0mVnBTtgLoArKVgTkdnDiYyYnlWMNBVn9QaP4IN440Yp5I+6dqvjp6Q0qOiAKdV7ecXq8nn/fBLl+PSu4dvFdTdjeUipIU6QHM6wz32iZQCye53Bl3W5RB+GV2qjqwROnLnpW5ktE7mIS6AmGWYgBm64nStjqL0QzMnvS7tPDWaP8g2iLpkNEckQAte9RZ0YqvYHAa6xo0RcMjkUFxtaqLDSo0QJ9tQpNoWYQL/QfOJwQGRh/muCvypS90udpT6fEBx0M//M3VIgp0KK1qK15+f8w3fKBTXbmRJBcJj6O2xHNxcY2GSyqGtb+RWdewzdIIrmo9TXyX8K/GrwR8yHqQDKVUSeB1g==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6512007)(53546011)(36756003)(6506007)(508600001)(5660300002)(8936002)(38070700005)(38100700002)(30864003)(2906002)(54906003)(66446008)(66556008)(66476007)(6486002)(4326008)(8676002)(71200400001)(2616005)(64756008)(83380400001)(91956017)(86362001)(122000001)(316002)(6916009)(33656002)(76116006)(26005)(66946007)(186003)(41533002)(45980500001)(579004);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <B79978626E662C4E8FBE64F3CCC4FCA0@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4227
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT003.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	660cdf9b-d3d0-4823-728f-08d9f61965a3
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	w+ZIlY7oAHBl7UZYNgvM1wjLkzca9/uBGF4+n3BuKDhxacmTkPzihjxhmllADwP17pn3vMKK8hfQJUAcL/thPn3rr4EImWjgWfTAe6cvs9x/pb127aPA2J7TOz4XiB1h1G/xHjbReUPxJuRWo35NeMyHrMUNlfzRv0Jt66C24FfBEeOtVaNvUx/4XSZzTsbRICrwGg23KAi8RHyv1hB7cmoUDcu0J2O9fc+x15Thkal1iW0pp4YRQfAat/Nlu+Nex3qWCdamEbknqYQGg9P5cy/s1nNarEey5Jb8IBvw40H9pLTU0vY1dZM95+AsT8qp5z7J4XzWcnna3VOuZ2kz6QeX/6rjusuj0Ci20wxZ2kZyCILsY0ZFcx7s8Kz5M9mZ9POvt7qECT0+zUUGtCtjmOXD8VPj8a6WdZDX2WfKRp1rKzi4Oy5dlTeVowFoztaGeaRAUgGk0YyTsUM0VnBdpFu7WwsJSdy2CpsGkjUJLBH0685cne5j0ACh9G3aE4mPZiJ4VeVNq3v/q2SDMHT/CHyqaFuJiXofuUDBI/pQHtw9JMy+7XqgGWIfeZr+DfrQxCAtsiBcpIgKidc6fRccjQiMtyEVN04RdZXRVykFHFcxi1p1hpxskOIEaOkeySlbXBZJNfSPu7XpGmwLSj+bHApZglU820stQnTsMefMJR8gnL9RSLbFlkljU22h42j+njglrfA5mgoKMFINQ0MefA==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(36756003)(30864003)(2906002)(40460700003)(54906003)(83380400001)(53546011)(6506007)(336012)(8936002)(47076005)(36860700001)(5660300002)(70206006)(186003)(70586007)(8676002)(82310400004)(6486002)(107886003)(2616005)(81166007)(4326008)(6862004)(33656002)(356005)(6512007)(508600001)(86362001)(26005)(316002)(41533002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2022 15:38:49.7802
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 2d94aa4b-cdb7-42f4-22b6-08d9f6196c22
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT003.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6518

Hi Julien,

> On 21 Feb 2022, at 10:22, Julien Grall <julien@xen.org> wrote:
>=20
> From: Julien Grall <jgrall@amazon.com>
>=20
> Currently, Xen PT helpers are only working with 4KB page granularity
> and open-code the generic helpers. To allow more flexibility, we can
> re-use the generic helpers and pass Xen's page granularity
> (PAGE_SHIFT).
>=20
> As Xen PT helpers are used in both C and assembly, we need to move
> the generic helpers definition outside of the !__ASSEMBLY__ section.
>=20
> Take the opportunity to prefix LPAE_ENTRIES, LPAE_ENTRIES and
> LPAE_ENTRIES_MASK with XEN_PT_.

The list needs to be fixed to be SHIFT, ENTRIES and ENTRY_MASK.

>=20
> Note the aliases for each level are still kept for the time being so we
> can avoid a massive patch to change all the callers.
>=20
> Signed-off-by: Julien Grall <jgrall@amazon.com>

With this fixed:
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>

Cheers
Bertrand

>=20
> ---
>    Changes in v3:
>      - Prefix the new define with XEN_PT_
>=20
>    Changes in v2:
>        - New patch
> ---
> xen/arch/arm/arm32/head.S       | 14 +++----
> xen/arch/arm/arm64/head.S       | 14 +++----
> xen/arch/arm/include/asm/lpae.h | 73 ++++++++++++++++++---------------
> xen/arch/arm/mm.c               | 33 ++++++++-------
> xen/arch/arm/p2m.c              | 13 +++---
> 5 files changed, 80 insertions(+), 67 deletions(-)
>=20
> diff --git a/xen/arch/arm/arm32/head.S b/xen/arch/arm/arm32/head.S
> index b5912d381b98..b1d209ea2842 100644
> --- a/xen/arch/arm/arm32/head.S
> +++ b/xen/arch/arm/arm32/head.S
> @@ -375,7 +375,7 @@ ENDPROC(cpu_init)
>  */
> .macro create_table_entry, ptbl, tbl, virt, shift, mmu=3D0
>         lsr   r1, \virt, #\shift
> -        mov_w r2, LPAE_ENTRY_MASK
> +        mov_w r2, XEN_PT_LPAE_ENTRY_MASK
>         and   r1, r1, r2             /* r1 :=3D slot in \tlb */
>         lsl   r1, r1, #3             /* r1 :=3D slot offset in \tlb */
>=20
> @@ -410,7 +410,7 @@ ENDPROC(cpu_init)
>  * and be distinct.
>  */
> .macro create_mapping_entry, ptbl, virt, phys, type=3DPT_MEM_L3, mmu=3D0
> -        mov_w r2, LPAE_ENTRY_MASK
> +        mov_w r2, XEN_PT_LPAE_ENTRY_MASK
>         lsr   r1, \virt, #THIRD_SHIFT
>         and   r1, r1, r2             /* r1 :=3D slot in \tlb */
>         lsl   r1, r1, #3             /* r1 :=3D slot offset in \tlb */
> @@ -465,7 +465,7 @@ create_page_tables:
> 1:      strd  r2, r3, [r4, r1]       /* Map vaddr(start) */
>         add   r2, r2, #PAGE_SIZE     /* Next page */
>         add   r1, r1, #8             /* Next slot */
> -        cmp   r1, #(LPAE_ENTRIES<<3) /* 512*8-byte entries per page */
> +        cmp   r1, #(XEN_PT_LPAE_ENTRIES<<3) /* 512*8-byte entries per pa=
ge */
>         blo   1b
>=20
>         /*
> @@ -487,7 +487,7 @@ create_page_tables:
>          * the second level.
>          */
>         lsr   r1, r9, #FIRST_SHIFT
> -        mov_w r0, LPAE_ENTRY_MASK
> +        mov_w r0, XEN_PT_LPAE_ENTRY_MASK
>         and   r1, r1, r0              /* r1 :=3D first slot */
>         cmp   r1, #XEN_FIRST_SLOT
>         beq   1f
> @@ -502,7 +502,7 @@ create_page_tables:
>          * it.
>          */
>         lsr   r1, r9, #SECOND_SHIFT
> -        mov_w r0, LPAE_ENTRY_MASK
> +        mov_w r0, XEN_PT_LPAE_ENTRY_MASK
>         and   r1, r1, r0             /* r1 :=3D second slot */
>         cmp   r1, #XEN_SECOND_SLOT
>         beq   virtphys_clash
> @@ -573,7 +573,7 @@ remove_identity_mapping:
>          * table if the slot is not XEN_FIRST_SLOT.
>          */
>         lsr   r1, r9, #FIRST_SHIFT
> -        mov_w r0, LPAE_ENTRY_MASK
> +        mov_w r0, XEN_PT_LPAE_ENTRY_MASK
>         and   r1, r1, r0              /* r1 :=3D first slot */
>         cmp   r1, #XEN_FIRST_SLOT
>         beq   1f
> @@ -589,7 +589,7 @@ remove_identity_mapping:
>          * table if the slot is not XEN_SECOND_SLOT.
>          */
>         lsr   r1, r9, #SECOND_SHIFT
> -        mov_w r0, LPAE_ENTRY_MASK
> +        mov_w r0, XEN_PT_LPAE_ENTRY_MASK
>         and   r1, r1, r0             /* r1 :=3D second slot */
>         cmp   r1, #XEN_SECOND_SLOT
>         beq   identity_mapping_removed
> diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S
> index 51b00ab0bea6..314b800b3f8e 100644
> --- a/xen/arch/arm/arm64/head.S
> +++ b/xen/arch/arm/arm64/head.S
> @@ -509,7 +509,7 @@ ENDPROC(cpu_init)
>  */
> .macro create_table_entry, ptbl, tbl, virt, shift, tmp1, tmp2, tmp3
>         lsr   \tmp1, \virt, #\shift
> -        and   \tmp1, \tmp1, #LPAE_ENTRY_MASK/* \tmp1 :=3D slot in \tlb *=
/
> +        and   \tmp1, \tmp1, #XEN_PT_LPAE_ENTRY_MASK/* \tmp1 :=3D slot in=
 \tlb */
>=20
>         load_paddr \tmp2, \tbl
>         mov   \tmp3, #PT_PT                 /* \tmp3 :=3D right for linea=
r PT */
> @@ -541,7 +541,7 @@ ENDPROC(cpu_init)
>         and   \tmp3, \phys, #THIRD_MASK     /* \tmp3 :=3D PAGE_ALIGNED(ph=
ys) */
>=20
>         lsr   \tmp1, \virt, #THIRD_SHIFT
> -        and   \tmp1, \tmp1, #LPAE_ENTRY_MASK/* \tmp1 :=3D slot in \tlb *=
/
> +        and   \tmp1, \tmp1, #XEN_PT_LPAE_ENTRY_MASK/* \tmp1 :=3D slot in=
 \tlb */
>=20
>         mov   \tmp2, #\type                 /* \tmp2 :=3D right for secti=
on PT */
>         orr   \tmp2, \tmp2, \tmp3           /*          + PAGE_ALIGNED(ph=
ys) */
> @@ -586,7 +586,7 @@ create_page_tables:
> 1:      str   x2, [x4, x1]           /* Map vaddr(start) */
>         add   x2, x2, #PAGE_SIZE     /* Next page */
>         add   x1, x1, #8             /* Next slot */
> -        cmp   x1, #(LPAE_ENTRIES<<3) /* 512 entries per page */
> +        cmp   x1, #(XEN_PT_LPAE_ENTRIES<<3) /* 512 entries per page */
>         b.lt  1b
>=20
>         /*
> @@ -621,7 +621,7 @@ create_page_tables:
>          * the second level.
>          */
>         lsr   x0, x19, #FIRST_SHIFT
> -        and   x0, x0, #LPAE_ENTRY_MASK  /* x0 :=3D first slot */
> +        and   x0, x0, #XEN_PT_LPAE_ENTRY_MASK  /* x0 :=3D first slot */
>         cmp   x0, #XEN_FIRST_SLOT
>         beq   1f
>         create_table_entry boot_first, boot_second_id, x19, FIRST_SHIFT, =
x0, x1, x2
> @@ -635,7 +635,7 @@ create_page_tables:
>          * it.
>          */
>         lsr   x0, x19, #SECOND_SHIFT
> -        and   x0, x0, #LPAE_ENTRY_MASK  /* x0 :=3D first slot */
> +        and   x0, x0, #XEN_PT_LPAE_ENTRY_MASK  /* x0 :=3D first slot */
>         cmp   x0, #XEN_SECOND_SLOT
>         beq   virtphys_clash
>         create_table_entry boot_second, boot_third_id, x19, SECOND_SHIFT,=
 x0, x1, x2
> @@ -715,7 +715,7 @@ remove_identity_mapping:
>          * table if the slot is not XEN_FIRST_SLOT.
>          */
>         lsr   x1, x19, #FIRST_SHIFT
> -        and   x1, x1, #LPAE_ENTRY_MASK  /* x1 :=3D first slot */
> +        and   x1, x1, #XEN_PT_LPAE_ENTRY_MASK  /* x1 :=3D first slot */
>         cmp   x1, #XEN_FIRST_SLOT
>         beq   1f
>         /* It is not in slot XEN_FIRST_SLOT, remove the entry. */
> @@ -729,7 +729,7 @@ remove_identity_mapping:
>          * table if the slot is not XEN_SECOND_SLOT.
>          */
>         lsr   x1, x19, #SECOND_SHIFT
> -        and   x1, x1, #LPAE_ENTRY_MASK  /* x1 :=3D first slot */
> +        and   x1, x1, #XEN_PT_LPAE_ENTRY_MASK  /* x1 :=3D first slot */
>         cmp   x1, #XEN_SECOND_SLOT
>         beq   identity_mapping_removed
>         /* It is not in slot 1, remove the entry */
> diff --git a/xen/arch/arm/include/asm/lpae.h b/xen/arch/arm/include/asm/l=
pae.h
> index 4fb9a40a4ca9..8cf932b5c947 100644
> --- a/xen/arch/arm/include/asm/lpae.h
> +++ b/xen/arch/arm/include/asm/lpae.h
> @@ -159,6 +159,17 @@ static inline bool lpae_is_superpage(lpae_t pte, uns=
igned int level)
> #define lpae_get_mfn(pte)    (_mfn((pte).walk.base))
> #define lpae_set_mfn(pte, mfn)  ((pte).walk.base =3D mfn_x(mfn))
>=20
> +/* Generate an array @var containing the offset for each level from @add=
r */
> +#define DECLARE_OFFSETS(var, addr)          \
> +    const unsigned int var[4] =3D {           \
> +        zeroeth_table_offset(addr),         \
> +        first_table_offset(addr),           \
> +        second_table_offset(addr),          \
> +        third_table_offset(addr)            \
> +    }
> +
> +#endif /* __ASSEMBLY__ */
> +
> /*
>  * AArch64 supports pages with different sizes (4K, 16K, and 64K).
>  * Provide a set of generic helpers that will compute various
> @@ -190,17 +201,6 @@ static inline bool lpae_is_superpage(lpae_t pte, uns=
igned int level)
> #define LPAE_TABLE_INDEX_GS(gs, lvl, addr)   \
>     (((addr) >> LEVEL_SHIFT_GS(gs, lvl)) & LPAE_ENTRY_MASK_GS(gs))
>=20
> -/* Generate an array @var containing the offset for each level from @add=
r */
> -#define DECLARE_OFFSETS(var, addr)          \
> -    const unsigned int var[4] =3D {           \
> -        zeroeth_table_offset(addr),         \
> -        first_table_offset(addr),           \
> -        second_table_offset(addr),          \
> -        third_table_offset(addr)            \
> -    }
> -
> -#endif /* __ASSEMBLY__ */
> -
> /*
>  * These numbers add up to a 48-bit input address space.
>  *
> @@ -211,26 +211,35 @@ static inline bool lpae_is_superpage(lpae_t pte, un=
signed int level)
>  * therefore 39-bits are sufficient.
>  */
>=20
> -#define LPAE_SHIFT      9
> -#define LPAE_ENTRIES    (_AC(1,U) << LPAE_SHIFT)
> -#define LPAE_ENTRY_MASK (LPAE_ENTRIES - 1)
> -
> -#define THIRD_SHIFT    (PAGE_SHIFT)
> -#define THIRD_ORDER    (THIRD_SHIFT - PAGE_SHIFT)
> -#define THIRD_SIZE     (_AT(paddr_t, 1) << THIRD_SHIFT)
> -#define THIRD_MASK     (~(THIRD_SIZE - 1))
> -#define SECOND_SHIFT   (THIRD_SHIFT + LPAE_SHIFT)
> -#define SECOND_ORDER   (SECOND_SHIFT - PAGE_SHIFT)
> -#define SECOND_SIZE    (_AT(paddr_t, 1) << SECOND_SHIFT)
> -#define SECOND_MASK    (~(SECOND_SIZE - 1))
> -#define FIRST_SHIFT    (SECOND_SHIFT + LPAE_SHIFT)
> -#define FIRST_ORDER    (FIRST_SHIFT - PAGE_SHIFT)
> -#define FIRST_SIZE     (_AT(paddr_t, 1) << FIRST_SHIFT)
> -#define FIRST_MASK     (~(FIRST_SIZE - 1))
> -#define ZEROETH_SHIFT  (FIRST_SHIFT + LPAE_SHIFT)
> -#define ZEROETH_ORDER  (ZEROETH_SHIFT - PAGE_SHIFT)
> -#define ZEROETH_SIZE   (_AT(paddr_t, 1) << ZEROETH_SHIFT)
> -#define ZEROETH_MASK   (~(ZEROETH_SIZE - 1))
> +#define XEN_PT_LPAE_SHIFT         LPAE_SHIFT_GS(PAGE_SHIFT)
> +#define XEN_PT_LPAE_ENTRIES       LPAE_ENTRIES_GS(PAGE_SHIFT)
> +#define XEN_PT_LPAE_ENTRY_MASK    LPAE_ENTRY_MASK_GS(PAGE_SHIFT)
> +
> +#define XEN_PT_LEVEL_SHIFT(lvl)   LEVEL_SHIFT_GS(PAGE_SHIFT, lvl)
> +#define XEN_PT_LEVEL_ORDER(lvl)   LEVEL_ORDER_GS(PAGE_SHIFT, lvl)
> +#define XEN_PT_LEVEL_SIZE(lvl)    LEVEL_SIZE_GS(PAGE_SHIFT, lvl)
> +#define XEN_PT_LEVEL_MASK(lvl)    (~(XEN_PT_LEVEL_SIZE(lvl) - 1))
> +
> +/* Convenience aliases */
> +#define THIRD_SHIFT         XEN_PT_LEVEL_SHIFT(3)
> +#define THIRD_ORDER         XEN_PT_LEVEL_ORDER(3)
> +#define THIRD_SIZE          XEN_PT_LEVEL_SIZE(3)
> +#define THIRD_MASK          XEN_PT_LEVEL_MASK(3)
> +
> +#define SECOND_SHIFT        XEN_PT_LEVEL_SHIFT(2)
> +#define SECOND_ORDER        XEN_PT_LEVEL_ORDER(2)
> +#define SECOND_SIZE         XEN_PT_LEVEL_SIZE(2)
> +#define SECOND_MASK         XEN_PT_LEVEL_MASK(2)
> +
> +#define FIRST_SHIFT         XEN_PT_LEVEL_SHIFT(1)
> +#define FIRST_ORDER         XEN_PT_LEVEL_ORDER(1)
> +#define FIRST_SIZE          XEN_PT_LEVEL_SIZE(1)
> +#define FIRST_MASK          XEN_PT_LEVEL_MASK(1)
> +
> +#define ZEROETH_SHIFT       XEN_PT_LEVEL_SHIFT(0)
> +#define ZEROETH_ORDER       XEN_PT_LEVEL_ORDER(0)
> +#define ZEROETH_SIZE        XEN_PT_LEVEL_SIZE(0)
> +#define ZEROETH_MASK        XEN_PT_LEVEL_MASK(0)
>=20
> /* Calculate the offsets into the pagetables for a given VA */
> #define zeroeth_linear_offset(va) ((va) >> ZEROETH_SHIFT)
> @@ -238,7 +247,7 @@ static inline bool lpae_is_superpage(lpae_t pte, unsi=
gned int level)
> #define second_linear_offset(va) ((va) >> SECOND_SHIFT)
> #define third_linear_offset(va) ((va) >> THIRD_SHIFT)
>=20
> -#define TABLE_OFFSET(offs) (_AT(unsigned int, offs) & LPAE_ENTRY_MASK)
> +#define TABLE_OFFSET(offs) (_AT(unsigned int, offs) & XEN_PT_LPAE_ENTRY_=
MASK)
> #define first_table_offset(va)  TABLE_OFFSET(first_linear_offset(va))
> #define second_table_offset(va) TABLE_OFFSET(second_linear_offset(va))
> #define third_table_offset(va)  TABLE_OFFSET(third_linear_offset(va))
> diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
> index b1eae767c27c..515d0906f85b 100644
> --- a/xen/arch/arm/mm.c
> +++ b/xen/arch/arm/mm.c
> @@ -71,10 +71,11 @@ mm_printk(const char *fmt, ...) {}
>  *  in C).
>  */
> #define DEFINE_BOOT_PAGE_TABLE(name)                                     =
     \
> -lpae_t __aligned(PAGE_SIZE) __section(".data.page_aligned") name[LPAE_EN=
TRIES]
> +lpae_t __aligned(PAGE_SIZE) __section(".data.page_aligned")             =
      \
> +    name[XEN_PT_LPAE_ENTRIES]
>=20
> #define DEFINE_PAGE_TABLES(name, nr)                    \
> -lpae_t __aligned(PAGE_SIZE) name[LPAE_ENTRIES * (nr)]
> +lpae_t __aligned(PAGE_SIZE) name[XEN_PT_LPAE_ENTRIES * (nr)]
>=20
> #define DEFINE_PAGE_TABLE(name) DEFINE_PAGE_TABLES(name, 1)
>=20
> @@ -207,7 +208,7 @@ static void __init __maybe_unused build_assertions(vo=
id)
>     BUILD_BUG_ON(zeroeth_table_offset(XEN_VIRT_START));
> #endif
>     BUILD_BUG_ON(first_table_offset(XEN_VIRT_START));
> -    BUILD_BUG_ON(second_linear_offset(XEN_VIRT_START) >=3D LPAE_ENTRIES)=
;
> +    BUILD_BUG_ON(second_linear_offset(XEN_VIRT_START) >=3D XEN_PT_LPAE_E=
NTRIES);
> #ifdef CONFIG_DOMAIN_PAGE
>     BUILD_BUG_ON(DOMHEAP_VIRT_START & ~FIRST_MASK);
> #endif
> @@ -256,7 +257,7 @@ void dump_pt_walk(paddr_t ttbr, paddr_t addr,
>=20
>     for ( level =3D root_level; ; level++ )
>     {
> -        if ( offsets[level] > LPAE_ENTRIES )
> +        if ( offsets[level] > XEN_PT_LPAE_ENTRIES )
>             break;
>=20
>         pte =3D mapping[offsets[level]];
> @@ -395,15 +396,15 @@ static void __init create_mappings(lpae_t *second,
>     ASSERT(!(base_mfn % granularity));
>     ASSERT(!(nr_mfns % granularity));
>=20
> -    count =3D nr_mfns / LPAE_ENTRIES;
> +    count =3D nr_mfns / XEN_PT_LPAE_ENTRIES;
>     p =3D second + second_linear_offset(virt_offset);
>     pte =3D mfn_to_xen_entry(_mfn(base_mfn), MT_NORMAL);
> -    if ( granularity =3D=3D 16 * LPAE_ENTRIES )
> +    if ( granularity =3D=3D 16 * XEN_PT_LPAE_ENTRIES )
>         pte.pt.contig =3D 1;  /* These maps are in 16-entry contiguous ch=
unks. */
>     for ( i =3D 0; i < count; i++ )
>     {
>         write_pte(p + i, pte);
> -        pte.pt.base +=3D 1 << LPAE_SHIFT;
> +        pte.pt.base +=3D 1 << XEN_PT_LPAE_SHIFT;
>     }
>     flush_xen_tlb_local();
> }
> @@ -424,7 +425,7 @@ void *map_domain_page(mfn_t mfn)
> {
>     unsigned long flags;
>     lpae_t *map =3D this_cpu(xen_dommap);
> -    unsigned long slot_mfn =3D mfn_x(mfn) & ~LPAE_ENTRY_MASK;
> +    unsigned long slot_mfn =3D mfn_x(mfn) & ~XEN_PT_LPAE_ENTRY_MASK;
>     vaddr_t va;
>     lpae_t pte;
>     int i, slot;
> @@ -435,7 +436,7 @@ void *map_domain_page(mfn_t mfn)
>      * entry is a 2MB superpage pte.  We use the available bits of each
>      * PTE as a reference count; when the refcount is zero the slot can
>      * be reused. */
> -    for ( slot =3D (slot_mfn >> LPAE_SHIFT) % DOMHEAP_ENTRIES, i =3D 0;
> +    for ( slot =3D (slot_mfn >> XEN_PT_LPAE_SHIFT) % DOMHEAP_ENTRIES, i =
=3D 0;
>           i < DOMHEAP_ENTRIES;
>           slot =3D (slot + 1) % DOMHEAP_ENTRIES, i++ )
>     {
> @@ -477,7 +478,7 @@ void *map_domain_page(mfn_t mfn)
>=20
>     va =3D (DOMHEAP_VIRT_START
>           + (slot << SECOND_SHIFT)
> -          + ((mfn_x(mfn) & LPAE_ENTRY_MASK) << THIRD_SHIFT));
> +          + ((mfn_x(mfn) & XEN_PT_LPAE_ENTRY_MASK) << THIRD_SHIFT));
>=20
>     /*
>      * We may not have flushed this specific subpage at map time,
> @@ -513,7 +514,7 @@ mfn_t domain_page_map_to_mfn(const void *ptr)
>     unsigned long va =3D (unsigned long)ptr;
>     lpae_t *map =3D this_cpu(xen_dommap);
>     int slot =3D (va - DOMHEAP_VIRT_START) >> SECOND_SHIFT;
> -    unsigned long offset =3D (va>>THIRD_SHIFT) & LPAE_ENTRY_MASK;
> +    unsigned long offset =3D (va>>THIRD_SHIFT) & XEN_PT_LPAE_ENTRY_MASK;
>=20
>     if ( va >=3D VMAP_VIRT_START && va < VMAP_VIRT_END )
>         return virt_to_mfn(va);
> @@ -654,7 +655,8 @@ void __init setup_pagetables(unsigned long boot_phys_=
offset)
>     /* Initialise first level entries, to point to second level entries *=
/
>     for ( i =3D 0; i < 2; i++)
>     {
> -        p[i] =3D pte_of_xenaddr((uintptr_t)(xen_second+i*LPAE_ENTRIES));
> +        p[i] =3D pte_of_xenaddr((uintptr_t)(xen_second +
> +                                          i * XEN_PT_LPAE_ENTRIES));
>         p[i].pt.table =3D 1;
>         p[i].pt.xn =3D 0;
>     }
> @@ -663,13 +665,14 @@ void __init setup_pagetables(unsigned long boot_phy=
s_offset)
>     for ( i =3D 0; i < DOMHEAP_SECOND_PAGES; i++ )
>     {
>         p[first_table_offset(DOMHEAP_VIRT_START+i*FIRST_SIZE)]
> -            =3D pte_of_xenaddr((uintptr_t)(cpu0_dommap+i*LPAE_ENTRIES));
> +            =3D pte_of_xenaddr((uintptr_t)(cpu0_dommap +
> +                                         i * XEN_PT_LPAE_ENTRIES));
>         p[first_table_offset(DOMHEAP_VIRT_START+i*FIRST_SIZE)].pt.table =
=3D 1;
>     }
> #endif
>=20
>     /* Break up the Xen mapping into 4k pages and protect them separately=
. */
> -    for ( i =3D 0; i < LPAE_ENTRIES; i++ )
> +    for ( i =3D 0; i < XEN_PT_LPAE_ENTRIES; i++ )
>     {
>         vaddr_t va =3D XEN_VIRT_START + (i << PAGE_SHIFT);
>=20
> @@ -768,7 +771,7 @@ int init_secondary_pagetables(int cpu)
>      * domheap mapping pages. */
>     for ( i =3D 0; i < DOMHEAP_SECOND_PAGES; i++ )
>     {
> -        pte =3D mfn_to_xen_entry(virt_to_mfn(domheap+i*LPAE_ENTRIES),
> +        pte =3D mfn_to_xen_entry(virt_to_mfn(domheap + i * XEN_PT_LPAE_E=
NTRIES),
>                                MT_NORMAL);
>         pte.pt.table =3D 1;
>         write_pte(&first[first_table_offset(DOMHEAP_VIRT_START+i*FIRST_SI=
ZE)], pte);
> diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
> index 02cf852d4cf1..493a1e25879a 100644
> --- a/xen/arch/arm/p2m.c
> +++ b/xen/arch/arm/p2m.c
> @@ -233,7 +233,8 @@ static lpae_t *p2m_get_root_pointer(struct p2m_domain=
 *p2m,
>      * we can't use (P2M_ROOT_LEVEL - 1) because the root level might be
>      * 0. Yet we still want to check if all the unused bits are zeroed.
>      */
> -    root_table =3D gfn_x(gfn) >> (level_orders[P2M_ROOT_LEVEL] + LPAE_SH=
IFT);
> +    root_table =3D gfn_x(gfn) >> (level_orders[P2M_ROOT_LEVEL] +
> +                                XEN_PT_LPAE_SHIFT);
>     if ( root_table >=3D P2M_ROOT_PAGES )
>         return NULL;
>=20
> @@ -773,7 +774,7 @@ static void p2m_free_entry(struct p2m_domain *p2m,
>     }
>=20
>     table =3D map_domain_page(lpae_get_mfn(entry));
> -    for ( i =3D 0; i < LPAE_ENTRIES; i++ )
> +    for ( i =3D 0; i < XEN_PT_LPAE_ENTRIES; i++ )
>         p2m_free_entry(p2m, *(table + i), level + 1);
>=20
>     unmap_domain_page(table);
> @@ -827,7 +828,7 @@ static bool p2m_split_superpage(struct p2m_domain *p2=
m, lpae_t *entry,
>      * We are either splitting a first level 1G page into 512 second leve=
l
>      * 2M pages, or a second level 2M page into 512 third level 4K pages.
>      */
> -    for ( i =3D 0; i < LPAE_ENTRIES; i++ )
> +    for ( i =3D 0; i < XEN_PT_LPAE_ENTRIES; i++ )
>     {
>         lpae_t *new_entry =3D table + i;
>=20
> @@ -850,7 +851,7 @@ static bool p2m_split_superpage(struct p2m_domain *p2=
m, lpae_t *entry,
>     /* Update stats */
>     p2m->stats.shattered[level]++;
>     p2m->stats.mappings[level]--;
> -    p2m->stats.mappings[next_level] +=3D LPAE_ENTRIES;
> +    p2m->stats.mappings[next_level] +=3D XEN_PT_LPAE_ENTRIES;
>=20
>     /*
>      * Shatter superpage in the page to the level we want to make the
> @@ -888,7 +889,7 @@ static int __p2m_set_entry(struct p2m_domain *p2m,
>                            p2m_access_t a)
> {
>     unsigned int level =3D 0;
> -    unsigned int target =3D 3 - (page_order / LPAE_SHIFT);
> +    unsigned int target =3D 3 - (page_order / XEN_PT_LPAE_SHIFT);
>     lpae_t *entry, *table, orig_pte;
>     int rc;
>     /* A mapping is removed if the MFN is invalid. */
> @@ -1142,7 +1143,7 @@ static void p2m_invalidate_table(struct p2m_domain =
*p2m, mfn_t mfn)
>=20
>     table =3D map_domain_page(mfn);
>=20
> -    for ( i =3D 0; i < LPAE_ENTRIES; i++ )
> +    for ( i =3D 0; i < XEN_PT_LPAE_ENTRIES; i++ )
>     {
>         lpae_t pte =3D table[i];
>=20
> --=20
> 2.32.0
>=20



From xen-devel-bounces@lists.xenproject.org Tue Feb 22 15:41:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 15:41:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277052.473491 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMXI4-0000Gz-7u; Tue, 22 Feb 2022 15:41:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277052.473491; Tue, 22 Feb 2022 15:41:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMXI4-0000Gs-42; Tue, 22 Feb 2022 15:41:24 +0000
Received: by outflank-mailman (input) for mailman id 277052;
 Tue, 22 Feb 2022 15:41:22 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Woib=TF=citrix.com=prvs=045a4fa17=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nMXI2-0000Gm-P7
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 15:41:22 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e1023c65-93f5-11ec-8539-5f4723681683;
 Tue, 22 Feb 2022 16:41:20 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e1023c65-93f5-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645544481;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=j//yNoyEQH6EQXePyPv7c9hng7R+Q3F6KxnLiVtvXSA=;
  b=KA+G+SOoBSN4+Stp5TJDyqeukXvHPH4XmuQVRjzDJfV2Y6s9TJp7Q8pw
   NarVTlIxh32iQnHnfsikh30hGlJpXfdXmqKBbuZFMNYkbKJFANWubXoNU
   NHWHWiQYXPwCEdggW+OkzlY4AshdZAoowO9GGLO7NRcRXctXvfsAl167n
   w=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 65139587
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:uyQOZKLgy8oyK8HyFE+RJZUlxSXFcZb7ZxGr2PjKsXjdYENSgTBRx
 mJNUGiEa/nfNGegKNB3aouy80IA68TRxtFgQAFlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA180IMsdoUg7wbRh2NQy2YLR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 Mp9kbKBTRc3B7PNutkYXEdnFRNBYKITrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBODtMJkSpTdLyjbBAOx9aZvCX7/L9ZlT2zJYasVmQ6uHP
 JtEOWUHgBLobR8THFMcGc8HxcS0g0vVWABHsWu+nP9ii4TU5FMoi+W8WDbPQfSISt9ShV2wv
 X/d8iLyBRRyHNmW0z+M6H+vru7JgyLgWYgWGaG49/hlm1mazCoYDxh+fUu2p7y1h1CzX/pbK
 lcI4Ww+oK4q7kupQ9LhGRqirxasvAMYWtdWO/037keK0KW8ywSTC3UATzVBQMc7r8JwTjsvv
 neShM/gDzFrtLyTSFqe+62SoDf0PjIaRUcdYQcUQA1D5MPsyLzflTqWEIwlSvTsyISoR3egm
 FhmsRTSmZ0Mveol5qGr42nZghCRo5eXcQgH2VjYCzfNAhxCWKapYImh6F7+5PlGLZqEQlTpg
 EXoi/Ry/8hVU8jTyXXlrPElWejwuq3baGG0bUtHQsF5nwlB7UJPamy5DNtWAE5yevgJdjbyC
 KM4kVMAvcQDVJdGgEIeXm5QNyjI5fW4fTgGfqqNBjarXnSXXFXclM2JTRTNt10BaGB2zckC1
 W6zKK5A90oyB6V91yaRTOwAy7ItzS1W7TqNGc2nkUX6jODCPSb9pVI53L2mNLtRAESs+li9z
 jqiH5HSl0U3vBPWOEE7DrL/3XhVdCNmVPgaWuRcd/KZIxoOJY3SI6S5/F/VQKQ8x/49vr6Rp
 hmVAxYEoHKi1SyvAVjbMRhLNeKwNauTWFpmZETAy37zgCN9CWtuhY9CH6YKkU4PrrI7lqcsF
 6FfEyhCa9wWIgn6F/0mRcCVhKRpdQixhBLIOCygYTMleIVnSRCP8djhFjYDPgFXZsZrnaPSe
 4Gd6z4=
IronPort-HdrOrdr: A9a23:6cbn66iTzJ8irOh5yuoY/yT95HBQX3R13DAbv31ZSRFFG/FwyP
 rAoB1L73PJYWgqNU3IwerwRZVpQRvnhPtICRF4B8bsYOCUghrVEGgE1/qt/9SAIVyzygc578
 ldmsdFeaTN5DRB/KXHCUyDYqwdKbq8geGVbIXlvg9QpGhRAskKhWYYNu/YKDwMeOAvP+tjKH
 P23Lsim9PUQwVwUi3NPAhjYwGsnayoqLvWJTo9QzI34giHij2lrJTgFQKD4xsYWzRThZ8/7G
 nsiWXCl+WemsD+7iWZ+37Y7pxQltek4MBEHtawhs8cLSipohq0Zb5mR6aJsFkO0aKSARcR4Z
 vxSiUbToBOAkDqDyaISNzWqk/dOQMVmjrfIJmj8CLeSILCNWoH4oF69P1km1PimjQdVZdHof
 h2Niuixupq5VmrplWN2/HYEx5tjUa6unwkjKoaiGFeS5IXbPtLoZUY5149KuZKIMvW0vFvLA
 BVNrCV2B+WSyLvU1nJ+m10hNC8VHU6GRmLBkAEp8yOyjBT2HR01VERysATlmoJsMtVcegI28
 3UdqBz0L1eRM4faqxwQO8HXMusE2TIBRbBKnibL1jrHLwOf3jNt5n06rMo4/zCQu1D8LIi3J
 DaFF9Iv287fEzjTcWIwZ1Q6xjIBH6wWDz8o/sukaSReoeMM4YDHRfzOmzGyfHQ0Mn3KverLs
 qOBA==
X-IronPort-AV: E=Sophos;i="5.88,387,1635220800"; 
   d="scan'208";a="65139587"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gz5/IA60GEyyu2qKUdRbxrHn7LUfs97ToTIz+lYAgKbiywOtyguSwZ88/8El6IiHj0dRAdhUd6Nu8GsPqn8jdUQWtvlYPa7jqnemiLcwIgVYttQa3SVMk3hQosRUivOfRTmb7/GKFIivLZOg678xZ/vQFxmI1Mtwyz9UKb4Cw6hQIYQi/+0fPRRxV9obLIcZWDvM65xr1tkhFMRPId/+Utbku7c6pd5Fi22r8Q8fE0dcHO83bkqKyKLXBG0KlzwbxPYeaUd8LvFrKC1uJqh1QxMEJJy2VCF4AJbnt6eRAjqJsdAT6C/lmBmvh4WvGfoIVVVRkPSYUyQjLcXJ97v8gA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=j//yNoyEQH6EQXePyPv7c9hng7R+Q3F6KxnLiVtvXSA=;
 b=JXHdfJtv0uu94b+/7yOdzIyHDQ0JCa42jcZJ9ksYzc6OPGkzPl6mp3spH9+wu0KIvtcqVjrEI3f/9bNUIcxYaz8tiVxGTRJPdQIMGuQPLrFDE078WoK1O7dRau8scwR6voGibzRP3gaOrI/X+kG1BYZO1SRJnQr4wIrzMwxmFxkBtjOR/3DLpQbGsbdcf3+MwXtnTZFxSxJ+ZABJbmc69iQu7I0axoJyAd+zVxqYEjKaKEVXeJjoWmaS9QnRgNAd0Kv4UseyOfnnpvylmif7RRma9F5UTtlNSpffj/H4Zz5EDcowf+iNPW7/h4lvpXvXgk3RPgx5XFiorPlSW13VTQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=j//yNoyEQH6EQXePyPv7c9hng7R+Q3F6KxnLiVtvXSA=;
 b=Tul+K62tPWSlIsn7cqrq0HzNEM4QytbA3iZ2Zhdb9uIruRsmJWS1RsWFH7eZrpT/ekHg+R4Fys15FxL1S4+3wvzubZx+u1mAiNWNn9aHMNC9XzWEfeDE1vkNXR2wcU1PMlEJ5wWDdAFFSCoSCCxXDrvyPoage0yp7H8eG+qilkU=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>, "Julien
 Grall" <julien@xen.org>, Roger Pau Monne <roger.pau@citrix.com>, Juergen
 Gross <jgross@suse.com>, =?utf-8?B?TWFyZWsgTWFyY3p5a293c2tpLUfDs3JlY2tp?=
	<marmarek@invisiblethingslab.com>, Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v3 00/70 (not all posted)] x86: Support for CET Indirect
 Branch Tracking
Thread-Topic: [PATCH v3 00/70 (not all posted)] x86: Support for CET Indirect
 Branch Tracking
Thread-Index: AQHYKADEI2PNE2WXy0mcZVRJyiMFGKyfshiAgAADJoA=
Date: Tue, 22 Feb 2022 15:41:16 +0000
Message-ID: <bbb08d2d-f76d-c21f-34bb-9f6bf711505d@citrix.com>
References: <20220222152645.8844-1-andrew.cooper3@citrix.com>
 <a1106b26-ffa8-2b8e-5063-c2e1059b46fe@suse.com>
In-Reply-To: <a1106b26-ffa8-2b8e-5063-c2e1059b46fe@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 50c2df19-8116-446b-1289-08d9f619c35d
x-ms-traffictypediagnostic: CO1PR03MB5745:EE_
x-microsoft-antispam-prvs: <CO1PR03MB5745EE385409F6DC08C257FFBA3B9@CO1PR03MB5745.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: iuzXYhEt/aUqr2mFlLPcFItadsLjyC7RnWqbbJSOxm8sz8geILkc2ux0NE/Noe/8yaD4lVCnzWjLr6bjyhEA385FkDdn3k6rnPxYHK9I9pfDDGT1VczkjUc0PRm+dyKZf6i2CM0u3jtFz3U/Jzgk8LU95QrN+uOZl+CJ92WXzQvR7ynYKqs1lGE+sC6emEn3yY5w1Yxy2zl9fuoqPS2pgWFu2AYNvDUKLfCocEHuCm7A87x7DYnWvq3erpDbbDktIAcA4Zil1fGyqcggmpEp5+3u4+oSERGHn01giETbX/y6aMDY5QypUFTvZd+uTGdsii57/zI1eeRqb6gBoRkS8AW94cybvgSMEdKWVX5Rx8YrbKp+pPt87lpP71don7+Ikk1yJx6Qkzdfhhm/bWsXKtAQ13HbrHut/9YIUhOv7ZaUOjMP72OPvGeaR5BLEaoL+e1paFNW2pLcl31LvZyPGFlNRvUbxuMj6OFN0ZV0g0y11XSjQER5cvBt0zfGb/ohGwrcPZRUk3e8QVGLj13HnDm0nBdd2hgObvDKbRVo4fnv8ydAcywtnZZ1g0Lu1uBmCs/2N6AYqisE93f6gJcWBFh77LMIhgp+El2f1200TSg0SgrYg2upRcd2dauET7ZTwjtxug5LXtaovfW4HNDvfq5Q8Aap0slFtU0bzFvPRR8MhRt+8q90HMfDdv9gFCx4oRqDWlsiohETgtFRUrPa4ZVxTUgLnFA5Z215EjpPhGqFDT6czrPwCZbn2rAFH4oACOjlhQGm5rlrnGm6hiA3jg==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(8936002)(6916009)(31686004)(31696002)(6506007)(54906003)(53546011)(6512007)(186003)(2906002)(86362001)(71200400001)(508600001)(26005)(316002)(2616005)(36756003)(6486002)(8676002)(76116006)(82960400001)(5660300002)(4326008)(38100700002)(38070700005)(91956017)(122000001)(66946007)(64756008)(66446008)(66476007)(66556008)(4744005)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?UmMxSDgrRUxESGxIY2t5KzRXV3BCaUYyTG5uTU03aDlJWFd6S1NNV09vYXBi?=
 =?utf-8?B?M3FaZ0RpNjJiT1VKTTNvL2kzZHNPaHAxU1hEamRjT1prdDdyZC91Wk04S1di?=
 =?utf-8?B?aXVLVWJyUjByT3RxOGNXaFI4a2hqd3J5UkJESU1palZicy9pYmhEQ1hEYUhr?=
 =?utf-8?B?YTJxdzhHdlNSM2RuR2FEallrNnNuZGhjNldVQzM5V3M2RUFSSHBVT3ZEZlNx?=
 =?utf-8?B?azdCbTZQT0pwOWJvN2ExYWpUY0VqLzhiM0VQMXF6UnRjK1ZtK2I4eFQ4aXlH?=
 =?utf-8?B?WXBLYmhwQ2xNY0I3RTVwTVo5K0FxcjFPUUdqNVdNS1NzL09helNyb3FYMW1u?=
 =?utf-8?B?bW5iZ2RxM1NWbmMrakxMSnMwYlcxTEFpb0tYTHhIRmhrQVpUV1h1MmMxYkU4?=
 =?utf-8?B?L1daOXN6bFE4TWNKZUFKend1TVhTOHl4a3VrdDZsT3ljNVYvMlc3OG9jd2h4?=
 =?utf-8?B?VDhkTXIrTGJSWjc2aEpiajZPbnF2UDJ3aHdsaWpPSk5wTkJobElMWW9ucVlq?=
 =?utf-8?B?MitOdVpQZEp5UlJFZHptajBpcG12RU5ld1F0TGpaZDZrL09zZ2FqYU1hdGs2?=
 =?utf-8?B?cFBvNjNPKzRxeUt3djVnZE5aYnFDS2d1NldWNFlGMFVVV2w3QVZqeFp1VWoy?=
 =?utf-8?B?ZStrSHdjT3dKcXVpZmZ6WmxIdTVoNmNLRWVJYWovOGdDazd1UkpjTU95MDB0?=
 =?utf-8?B?ZzI3T2U1cElUVnQzbWtBQVZ1aFdsclVtOUdQR21Yc0tpOXBZMFpybGU4L09p?=
 =?utf-8?B?QlZrYWcrczNCOTBDOWpkeER0S1lOakI2eEVwMEs0U3RIOHZBUFoxdXhxRFpy?=
 =?utf-8?B?QStkV2d5RG1pTzJIYWVOWGhOcmRlNVpzdkNEcHdCRkRFUXdLdzc3ZzdvSjZP?=
 =?utf-8?B?RjlRVzl6MFhybTlIM1U1R2QwNHBnWkUrR29GdzVCV1d0ZEIvK3NUcEZBR2NM?=
 =?utf-8?B?SXl1ZU95NmlnVXJ2b2MyMmpUZ1M1aGU2Z05mTFVOSVJnNmR3NjF0NHoxcDRJ?=
 =?utf-8?B?QXlzNVRBYUZGNjZzK3kxdlNiQkEvQm9BQytIWEJ1c3duenM4UlBqTXlTZVpN?=
 =?utf-8?B?dTNsTkFrQUxiRjlFQS8wSEtQNTJyTFJrZ3p5OXY1MXM1bE8zUk9yU2pvWFJU?=
 =?utf-8?B?enQ0bFptWlZhcXhKd0RKZE03cElOM2QzeURRVUlNVDlNWFZMdW4yR05OelVX?=
 =?utf-8?B?cE55UkQ1ZElUQnRqbXBpMWdiN0UwYStDZmNqK2ltODBlbXdCU25YOWkvcExo?=
 =?utf-8?B?R0Q1QzFCc25qZ3Z2WEJub25xeVlPTi8vNXBXM1JmMlBuenVDaFhXQTJBVzJI?=
 =?utf-8?B?QVd3WEpUc2k5NU5wV3JReDFFbVRSVFh1dVlOb0g4Q0IyT3RjcUwzRHQ5d2pX?=
 =?utf-8?B?bkkrOExEN29SQWc3UWhHd09WeTMwZWNZcHBYVTNpci9MNVd3TjAyUlJDc1RS?=
 =?utf-8?B?NU5rRmtRbGlSZVNmMDQ4bk5MSjk3R3ZoTThROGRQVithYXNqb2swZWR2TEp6?=
 =?utf-8?B?S1F3N3ZDV1o5RWVSczJYc3hoa0t0WlY1Vmt5aWVFeDBCZDk5ZWU0aGV4cTFU?=
 =?utf-8?B?RDQvMTBkbEtzSkJGcHFwR1lrN3piQkUxZS9sRGFNUXN1d2hoaVNYZXdJcG5u?=
 =?utf-8?B?YUVEcldEYzljcTBoanl5RkRHajFCREZaa05NZmkzOWozZW4zRE0zUldJTDZB?=
 =?utf-8?B?REYrNzFWU0RLTk5WZXR4TUN0UXFNWExEeUl3K1NDNWtsZkZvSVhEM0tFTmlm?=
 =?utf-8?B?a2lESXJEckdFQWpmaVVicFRqbXJGeXZrcGM4UzltZXdUZnNZcWFtR2E1alg2?=
 =?utf-8?B?Z09MT3A1cXhBQUsrcDFnUnlEUk5iQjQrR1Y1OHdWTzZUVU5idFB4TS93azc0?=
 =?utf-8?B?K29EVjhsalgwMjRQS2piSGxSZFlmYUxYbGtmUTNoZmVRT092eUVSUVlUS3Yv?=
 =?utf-8?B?dlNjdC9GeWR4Tkx3bXV0a05iMys2YnRaNnVuT2tZOStnNHRjN1hMTHV2VVor?=
 =?utf-8?B?RytFeHZLRENxNGgwbDg5dDdZdXg4OUhUKy9ZMVFPQlpKeC9ZdkxMa0d5OVhs?=
 =?utf-8?B?R0Fhd3V0R1lSdURZVkJXSE5KQmJFZ2pRSjd0YjNBaWQzM01sc3JUbXQxc1BZ?=
 =?utf-8?B?TU5zdWdSblVXOFpjOUdieFMyaSt6WVJrWDRrdDIvbFF5WjBJYzVyaGdpdU1O?=
 =?utf-8?B?WGlrUWl0QTU0TVV0dFFqV2JYMVBFa2xaR05FWmU5c1drSWU0TGJtSjVvSkM1?=
 =?utf-8?B?eUpyeGozb0JPMVozcDVUUE1TZVh3PT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <D1B8F4BED09064499197A05DAFC9B28D@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 50c2df19-8116-446b-1289-08d9f619c35d
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Feb 2022 15:41:16.0970
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: b29hfncY5q6IH936eD8JHz/uDTRhGTFJS9b+gC0uSVn7JDnrLrbX8YJB9HcopjTqfIJhv7w1b3Ae6Nfr5R9uBn3fIh9kYyGna64uMWuULv8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR03MB5745
X-OriginatorOrg: citrix.com

T24gMjIvMDIvMjAyMiAxNToyOSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDIyLjAyLjIwMjIg
MTY6MjYsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBUbyBhdm9pZCBzcGFtbWluZyBldmVyeW9u
ZSwgSSBoYXZlIG9ubHkgcmUtc2VudCBwYXRjaGVzIHdpdGggY2hhbmdlcyBpbiB2My4NCj4gQ291
bGQgeW91IGVudW1lcmF0ZSB3aGljaCBvbmVzIHRoZXNlIGFyZT8gT3RoZXJ3aXNlIGl0J3MgaGFy
ZCB0byB0ZWxsDQo+IHdoZXRoZXIgZXZlcnl0aGluZyB5b3UgZGlkIHNlbmQgZGlkIGFycml2ZSBp
biB0aGUgcmVjaXBpZW50cycgbWFpbGJveGVzLg0KDQpPb3BzIHNvcnJ5LsKgIDEsIDMsIDUsIDYs
IDgsIDEyLCAyNiwgMjcsIDI5LCAzMywgNDYsIDQ3LCA1OSwgNjAsIDY0Lg0KDQpBbGwgdGhhdCBJ
J20gZXhwZWN0aW5nIHRvIHNlZSBoYXZlIGFwcGVhcmVkIG9uIHRoZSBsaXN0Lg0KDQp+QW5kcmV3
DQo=


From xen-devel-bounces@lists.xenproject.org Tue Feb 22 15:42:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 15:42:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277059.473502 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMXJY-0000rV-Im; Tue, 22 Feb 2022 15:42:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277059.473502; Tue, 22 Feb 2022 15:42:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMXJY-0000rO-Fe; Tue, 22 Feb 2022 15:42:56 +0000
Received: by outflank-mailman (input) for mailman id 277059;
 Tue, 22 Feb 2022 15:42:54 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=AYeZ=TF=invisiblethingslab.com=marmarek@srs-se1.protection.inumbo.net>)
 id 1nMXJW-0000rG-K3
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 15:42:54 +0000
Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com
 [64.147.123.20]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 17913ba8-93f6-11ec-8eb8-a37418f5ba1a;
 Tue, 22 Feb 2022 16:42:52 +0100 (CET)
Received: from compute3.internal (compute3.nyi.internal [10.202.2.43])
 by mailout.west.internal (Postfix) with ESMTP id 2F8ED3201F7B;
 Tue, 22 Feb 2022 10:42:49 -0500 (EST)
Received: from mailfrontend1 ([10.202.2.162])
 by compute3.internal (MEProxy); Tue, 22 Feb 2022 10:42:50 -0500
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue,
 22 Feb 2022 10:42:46 -0500 (EST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 17913ba8-93f6-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-type:date:date:from:from
	:in-reply-to:in-reply-to:message-id:mime-version:references
	:reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy
	:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=TvzTOxlzTQYiBD7Kb
	rVOKZYbr3DHkC1A336ECdR5YJQ=; b=YmB7WvNkiq2aWj2jga7BUiMleRz3sNhys
	qL8adOKldOXiDFQE/E6WYKApT2yMJEMc2z4Jto6pSGmHMNrB6qjx98GrrG6L0+hj
	DfNfrPDtbz4+mbNCAod76C/91Yok5rcgOa0luQSxeFfobeQiCfh/2WDrd+AttE1U
	6UyrvvHzwG1vEe9pBdClz9JnmNNYdQf3t5kAfeJdyRyD9P4yP4LG7mzX+HIzD0Hr
	5hBMSLciK83txiCM0m/BJB5u8lDV4L1nPyOUihhJDYvTDJjgG13uHpB5S0u6YuJL
	rr4GqAiMIleOnoo/CEfBGw1Cyb9J2DifRVD60P09l4NrbolxqUqWw==
X-ME-Sender: <xms:eAQVYuRZpWBuYNxSjqTtekB4DcJ3RVeQJ0sEZzTxMGP7OsnMoVKfQA>
    <xme:eAQVYjw6UJNbY8reE5YEou6hvrKUh3L19MwwGe84uG5KfVgwLAEkUUZODjmao4Vik
    V9fB1qXkb50YQ>
X-ME-Received: <xmr:eAQVYr0LK3yCR9uUfJ2SfrEj8t5NI3qOGyFKCv8ArgB0Ukb_oFzRyAfbW-pWNedOU3JfkD4RZzH2WPPEfFWMSOvMN7bJJBEe6w>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrkeekgdejkecutefuodetggdotefrodftvf
    curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
    uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
    fjughrpeffhffvuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrrhgvkhcu
    ofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinhhvih
    hsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepteevffei
    gffhkefhgfegfeffhfegveeikeettdfhheevieehieeitddugeefteffnecuvehluhhsth
    gvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghrvghksehi
    nhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh
X-ME-Proxy: <xmx:eAQVYqA5_4emoEtXmS5DDZdeIbIvKLcsdj1D6EMljH-gUWwDGE4fIQ>
    <xmx:eAQVYngNNVEliAO85sdZUXYSNGfV3zIo2IpWD8OMA9dgdC4rBOq5bw>
    <xmx:eAQVYmooNzmtDTmAGP6fR6XVYrU1lteUd4oNin-CrQguhhVDKNb6nA>
    <xmx:eAQVYnjLbN2LvspRVTxl1A53jI65BiJ6cvHHNyRlJBrhmHu2NFHaFw>
Date: Tue, 22 Feb 2022 16:42:43 +0100
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: George Dunlap <George.Dunlap@citrix.com>,
	Ian Jackson <iwj@xenproject.org>,
	Committers <committers@xenproject.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Andrew Cooper <Andrew.Cooper3@citrix.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
	Wojtek Porczyk <woju@invisiblethingslab.com>
Subject: Re: [PATCH] RFC: Version support policy
Message-ID: <YhUEc+Ztwf312ZRx@mail-itl>
References: <20210813113727.6028-1-iwj@xenproject.org>
 <de32c6c4-5ad5-862e-3988-0e7310ec3ecb@suse.com>
 <C6A7B444-4CFB-43A7-8FA8-AD1049F83912@citrix.com>
 <YhTUe7K5/rlek4AA@invisiblethingslab.com>
 <77CD0734-A343-45CF-8A44-5C53771E404A@citrix.com>
 <f5c50526-2fdc-029e-751d-eb05b29a8366@suse.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="3eQzeHILK6IAXKa5"
Content-Disposition: inline
In-Reply-To: <f5c50526-2fdc-029e-751d-eb05b29a8366@suse.com>


--3eQzeHILK6IAXKa5
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Tue, 22 Feb 2022 16:42:43 +0100
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: George Dunlap <George.Dunlap@citrix.com>,
	Ian Jackson <iwj@xenproject.org>,
	Committers <committers@xenproject.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Andrew Cooper <Andrew.Cooper3@citrix.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
	Wojtek Porczyk <woju@invisiblethingslab.com>
Subject: Re: [PATCH] RFC: Version support policy

On Tue, Feb 22, 2022 at 04:05:19PM +0100, Jan Beulich wrote:
> On 22.02.2022 15:58, George Dunlap wrote:
> >> On Feb 22, 2022, at 12:18 PM, Wojtek Porczyk <woju@invisiblethingslab.=
com> wrote:
> >> On Mon, Feb 14, 2022 at 09:50:25PM +0000, George Dunlap wrote:
> >>> I think it=E2=80=99s too much effort to ask developers to try to find=
 the actual
> >>> minimum version of each individual dependency as things evolve.
> >>
> >> By "find the actual minimum version", do you mean to get to know the v=
ersion
> >> number, or install that version on developer's machine?
> >=20
> > Well suppose that a developer writes code that depends on an external l=
ibrary.  The external library on their own machine is 4.5; so they know tha=
t 4.5 works.  But will 4.4 work?  How about 4.0?  Or 3.9?  Or 2.2?  Maybe i=
t works on 3.8+ and 2.13+, but not 2.0-2.12 or 3.0-3.7.
> >=20
> > I don=E2=80=99t think it=E2=80=99s fair to ask people submitting patche=
s to do the work of tracking down which exact versions actually work and wh=
ich ones don=E2=80=99t actually work;
>=20
> But somebody will need to do this. If it's not done right away, someone
> (else) will hit a build issue on a perhaps just slightly older platform.

That's why declare what version _should_ work (and test that via CI),
instead of trying to find what is the minimum version that is actually
required. This may result in saying "you need libfoo 3.4" while in
practice 3.3 would be fine too, but I think that's reasonable
compromise.

--=20
Best Regards,
Marek Marczykowski-G=C3=B3recki
Invisible Things Lab

--3eQzeHILK6IAXKa5
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmIVBHMACgkQ24/THMrX
1yweeQgAmvT9pWRGVqmMSYl0rG9LSaXF+UMbdd+oBszhF3PFAMfpwKcTzLgWIYUL
vEvo7TwAC/iLNkJArIjUUDE//+mgQKzqcE2iXsBzi1ansM5na47/jDQ52xQYfICb
GrW+K5SmRW3Cu5ojoV8y52wMd/HZrSfbRnp5vtrHjlC9hAfrqjSO9Pr05fZ6RP0a
92iStHDOLa3frC5DslQlVqdXtnnXAPlOiD0NUyz/rLHMaETIFozLaW+DeXWHciRp
FrlNJvaTUkInFC7/Yv2LClQFW+TciY7GXeaeH5Sh6Ft0wXyw0anZNUNuDg+Ay07+
6e74+sPes1MiogtClzZzXISoJXinVw==
=imTr
-----END PGP SIGNATURE-----

--3eQzeHILK6IAXKa5--


From xen-devel-bounces@lists.xenproject.org Tue Feb 22 15:46:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 15:46:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277067.473513 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMXN3-0001X9-2w; Tue, 22 Feb 2022 15:46:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277067.473513; Tue, 22 Feb 2022 15:46:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMXN2-0001X2-W2; Tue, 22 Feb 2022 15:46:32 +0000
Received: by outflank-mailman (input) for mailman id 277067;
 Tue, 22 Feb 2022 15:46:31 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=CFyZ=TF=bombadil.srs.infradead.org=BATV+11ac0858211c0bd5236f+6757+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nMXD3-0005NI-0f
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 15:36:13 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2890854b-93f5-11ec-8539-5f4723681683;
 Tue, 22 Feb 2022 16:36:10 +0100 (CET)
Received: from [2001:4bb8:198:f8fc:c22a:ebfc:be8d:63c2] (helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nMXCV-00AH1Q-Ry; Tue, 22 Feb 2022 15:35:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2890854b-93f5-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=DqS5ph1Ek/KtSGhSgZyNX599d4kE7n6xsWBemrqs+4c=; b=HE/+MqbXvuhjtZ8naMnADRTRnM
	zaRSxcvXd6keb2lImziRztwjI5Zw9XLx2RO57SlzeD9/1+1YyTxQUjrcaXtmT3c/8UDWG5MGxMyza
	CpqXopymU+G00ApgSt4VzYlEDa/ZDaPjJ/WiEn0TLOmJ4VAf3i8mcXDsqTOnVqXiRHzQlbw8e6pZP
	1hPJ0b5qqTWgyQ8//LO85egfXW+xwPM5p4vDiUjq/JHkCdONEI1alUcpf1TkyS1L/vKRqVdY73FXa
	RXeshBky+c6yH+6jaxAj3KSo7mhAtfPnFnLjwdvCoHEsK9WQT5CYUk2+3MTAvUJ/8/xsbdc9mUpt3
	BhPsXTlg==;
From: Christoph Hellwig <hch@lst.de>
To: iommu@lists.linux-foundation.org
Cc: x86@kernel.org,
	Stefano Stabellini <sstabellini@kernel.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Joerg Roedel <joro@8bytes.org>,
	David Woodhouse <dwmw2@infradead.org>,
	Lu Baolu <baolu.lu@linux.intel.com>,
	Robin Murphy <robin.murphy@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	xen-devel@lists.xenproject.org,
	linux-ia64@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	tboot-devel@lists.sourceforge.net,
	linux-pci@vger.kernel.org
Subject: [PATCH 08/11] swiotlb: make the swiotlb_init interface more useful
Date: Tue, 22 Feb 2022 16:35:11 +0100
Message-Id: <20220222153514.593231-9-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220222153514.593231-1-hch@lst.de>
References: <20220222153514.593231-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Pass a bool to pass if swiotlb needs to be enabled based on the
addressing needs and replace the verbose argument with a set of
flags, including one to force enable bounce buffering.

Note that this patch removes the possibility to force xen-swiotlb
use using swiotlb=force on the command line on x86 (arm and arm64
never supported that), but this interface will be restored shortly.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 arch/arm/mm/init.c                     |  6 +----
 arch/arm64/mm/init.c                   |  6 +----
 arch/ia64/mm/init.c                    |  4 +--
 arch/mips/cavium-octeon/dma-octeon.c   |  2 +-
 arch/mips/loongson64/dma.c             |  2 +-
 arch/mips/sibyte/common/dma.c          |  2 +-
 arch/powerpc/include/asm/swiotlb.h     |  1 +
 arch/powerpc/mm/mem.c                  |  3 ++-
 arch/powerpc/platforms/pseries/setup.c |  3 ---
 arch/riscv/mm/init.c                   |  8 +-----
 arch/s390/mm/init.c                    |  3 +--
 arch/x86/kernel/cpu/mshyperv.c         |  8 ------
 arch/x86/kernel/pci-dma.c              | 17 ++++++-------
 arch/x86/mm/mem_encrypt_amd.c          |  3 ---
 drivers/xen/swiotlb-xen.c              |  4 +--
 include/linux/swiotlb.h                | 15 ++++++-----
 include/trace/events/swiotlb.h         | 29 ++++++++-------------
 kernel/dma/swiotlb.c                   | 35 ++++++++++++++------------
 18 files changed, 57 insertions(+), 94 deletions(-)

diff --git a/arch/arm/mm/init.c b/arch/arm/mm/init.c
index 6d0cb0f7bc54b..73f30d278b565 100644
--- a/arch/arm/mm/init.c
+++ b/arch/arm/mm/init.c
@@ -312,11 +312,7 @@ static void __init free_highpages(void)
 void __init mem_init(void)
 {
 #ifdef CONFIG_ARM_LPAE
-	if (swiotlb_force == SWIOTLB_FORCE ||
-	    max_pfn > arm_dma_pfn_limit)
-		swiotlb_init(1);
-	else
-		swiotlb_force = SWIOTLB_NO_FORCE;
+	swiotlb_init(max_pfn > arm_dma_pfn_limit, SWIOTLB_VERBOSE);
 #endif
 
 	set_max_mapnr(pfn_to_page(max_pfn) - mem_map);
diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c
index db63cc885771a..52102adda3d28 100644
--- a/arch/arm64/mm/init.c
+++ b/arch/arm64/mm/init.c
@@ -373,11 +373,7 @@ void __init bootmem_init(void)
  */
 void __init mem_init(void)
 {
-	if (swiotlb_force == SWIOTLB_FORCE ||
-	    max_pfn > PFN_DOWN(arm64_dma_phys_limit))
-		swiotlb_init(1);
-	else if (!xen_swiotlb_detect())
-		swiotlb_force = SWIOTLB_NO_FORCE;
+	swiotlb_init(max_pfn > PFN_DOWN(arm64_dma_phys_limit), SWIOTLB_VERBOSE);
 
 	/* this will put all unused low memory onto the freelists */
 	memblock_free_all();
diff --git a/arch/ia64/mm/init.c b/arch/ia64/mm/init.c
index 5d165607bf354..3c3e15b22608f 100644
--- a/arch/ia64/mm/init.c
+++ b/arch/ia64/mm/init.c
@@ -437,9 +437,7 @@ mem_init (void)
 		if (iommu_detected)
 			break;
 #endif
-#ifdef CONFIG_SWIOTLB
-		swiotlb_init(1);
-#endif
+		swiotlb_init(true, SWIOTLB_VERBOSE);
 	} while (0);
 
 #ifdef CONFIG_FLATMEM
diff --git a/arch/mips/cavium-octeon/dma-octeon.c b/arch/mips/cavium-octeon/dma-octeon.c
index fb7547e217263..9fbba6a8fa4c5 100644
--- a/arch/mips/cavium-octeon/dma-octeon.c
+++ b/arch/mips/cavium-octeon/dma-octeon.c
@@ -235,5 +235,5 @@ void __init plat_swiotlb_setup(void)
 #endif
 
 	swiotlb_adjust_size(swiotlbsize);
-	swiotlb_init(1);
+	swiotlb_init(true, SWIOTLB_VERBOSE);
 }
diff --git a/arch/mips/loongson64/dma.c b/arch/mips/loongson64/dma.c
index 364f2f27c8723..8220a1bc0db64 100644
--- a/arch/mips/loongson64/dma.c
+++ b/arch/mips/loongson64/dma.c
@@ -24,5 +24,5 @@ phys_addr_t dma_to_phys(struct device *dev, dma_addr_t daddr)
 
 void __init plat_swiotlb_setup(void)
 {
-	swiotlb_init(1);
+	swiotlb_init(true, SWIOTLB_VERBOSE);
 }
diff --git a/arch/mips/sibyte/common/dma.c b/arch/mips/sibyte/common/dma.c
index eb47a94f3583e..c5c2c782aff68 100644
--- a/arch/mips/sibyte/common/dma.c
+++ b/arch/mips/sibyte/common/dma.c
@@ -10,5 +10,5 @@
 
 void __init plat_swiotlb_setup(void)
 {
-	swiotlb_init(1);
+	swiotlb_init(true, SWIOTLB_VERBOSE);
 }
diff --git a/arch/powerpc/include/asm/swiotlb.h b/arch/powerpc/include/asm/swiotlb.h
index 3c1a1cd161286..4203b5e0a88ed 100644
--- a/arch/powerpc/include/asm/swiotlb.h
+++ b/arch/powerpc/include/asm/swiotlb.h
@@ -9,6 +9,7 @@
 #include <linux/swiotlb.h>
 
 extern unsigned int ppc_swiotlb_enable;
+extern unsigned int ppc_swiotlb_flags;
 
 #ifdef CONFIG_SWIOTLB
 void swiotlb_detect_4g(void);
diff --git a/arch/powerpc/mm/mem.c b/arch/powerpc/mm/mem.c
index 8e301cd8925b2..d99b8b5b40ca6 100644
--- a/arch/powerpc/mm/mem.c
+++ b/arch/powerpc/mm/mem.c
@@ -17,6 +17,7 @@
 #include <linux/suspend.h>
 #include <linux/dma-direct.h>
 
+#include <asm/swiotlb.h>
 #include <asm/machdep.h>
 #include <asm/rtas.h>
 #include <asm/kasan.h>
@@ -251,7 +252,7 @@ void __init mem_init(void)
 	if (is_secure_guest())
 		svm_swiotlb_init();
 	else
-		swiotlb_init(0);
+		swiotlb_init(ppc_swiotlb_enable, ppc_swiotlb_flags);
 #endif
 
 	high_memory = (void *) __va(max_low_pfn * PAGE_SIZE);
diff --git a/arch/powerpc/platforms/pseries/setup.c b/arch/powerpc/platforms/pseries/setup.c
index 83a04d967a59f..45d637ab58261 100644
--- a/arch/powerpc/platforms/pseries/setup.c
+++ b/arch/powerpc/platforms/pseries/setup.c
@@ -838,9 +838,6 @@ static void __init pSeries_setup_arch(void)
 	}
 
 	ppc_md.pcibios_root_bridge_prepare = pseries_root_bridge_prepare;
-
-	if (swiotlb_force == SWIOTLB_FORCE)
-		ppc_swiotlb_enable = 1;
 }
 
 static void pseries_panic(char *str)
diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c
index c27294128e182..6cdbb62672fe5 100644
--- a/arch/riscv/mm/init.c
+++ b/arch/riscv/mm/init.c
@@ -118,13 +118,7 @@ void __init mem_init(void)
 	BUG_ON(!mem_map);
 #endif /* CONFIG_FLATMEM */
 
-#ifdef CONFIG_SWIOTLB
-	if (swiotlb_force == SWIOTLB_FORCE ||
-	    max_pfn > PFN_DOWN(dma32_phys_limit))
-		swiotlb_init(1);
-	else
-		swiotlb_force = SWIOTLB_NO_FORCE;
-#endif
+	swiotlb_init(max_pfn > PFN_DOWN(dma32_phys_limit), SWIOTLB_VERBOSE);
 	high_memory = (void *)(__va(PFN_PHYS(max_low_pfn)));
 	memblock_free_all();
 
diff --git a/arch/s390/mm/init.c b/arch/s390/mm/init.c
index 86ffd0d51fd59..6fb6bf64326f9 100644
--- a/arch/s390/mm/init.c
+++ b/arch/s390/mm/init.c
@@ -185,8 +185,7 @@ static void pv_init(void)
 		return;
 
 	/* make sure bounce buffers are shared */
-	swiotlb_force = SWIOTLB_FORCE;
-	swiotlb_init(1);
+	swiotlb_init(true, SWIOTLB_FORCE | SWIOTLB_VERBOSE);
 	swiotlb_update_mem_attributes();
 }
 
diff --git a/arch/x86/kernel/cpu/mshyperv.c b/arch/x86/kernel/cpu/mshyperv.c
index 5a99f993e6392..568274917f1cd 100644
--- a/arch/x86/kernel/cpu/mshyperv.c
+++ b/arch/x86/kernel/cpu/mshyperv.c
@@ -336,14 +336,6 @@ static void __init ms_hyperv_init_platform(void)
 			swiotlb_unencrypted_base = ms_hyperv.shared_gpa_boundary;
 #endif
 		}
-
-#ifdef CONFIG_SWIOTLB
-		/*
-		 * Enable swiotlb force mode in Isolation VM to
-		 * use swiotlb bounce buffer for dma transaction.
-		 */
-		swiotlb_force = SWIOTLB_FORCE;
-#endif
 	}
 
 	if (hv_max_functions_eax >= HYPERV_CPUID_NESTED_FEATURES) {
diff --git a/arch/x86/kernel/pci-dma.c b/arch/x86/kernel/pci-dma.c
index 32c9cd9d7c257..9576a02a2590f 100644
--- a/arch/x86/kernel/pci-dma.c
+++ b/arch/x86/kernel/pci-dma.c
@@ -39,6 +39,7 @@ int iommu_detected __read_mostly = 0;
 
 #ifdef CONFIG_SWIOTLB
 bool x86_swiotlb_enable;
+static unsigned int x86_swiotlb_flags;
 static bool xen_swiotlb;
 
 /*
@@ -49,8 +50,7 @@ static void __init pci_swiotlb_detect_4gb(void)
 {
 #ifdef CONFIG_SWIOTLB_XEN
 	if (xen_pv_domain()) {
-		if (xen_initial_domain() || x86_swiotlb_enable ||
-		    swiotlb_force == SWIOTLB_FORCE) {
+		if (xen_initial_domain() || x86_swiotlb_enable) {
 			xen_swiotlb = true;
 			xen_swiotlb_init_early();
 			dma_ops = &xen_swiotlb_dma_ops;
@@ -73,11 +73,10 @@ static void __init pci_swiotlb_detect_4gb(void)
 	 * Set swiotlb to 1 so that bounce buffers are allocated and used for
 	 * devices that can't support DMA to encrypted memory.
 	 */
-	if (cc_platform_has(CC_ATTR_HOST_MEM_ENCRYPT))
-		x86_swiotlb_enable = true;
-
-	if (swiotlb_force == SWIOTLB_FORCE)
+	if (cc_platform_has(CC_ATTR_HOST_MEM_ENCRYPT)) {
 		x86_swiotlb_enable = true;
+		x86_swiotlb_flags |= SWIOTLB_FORCE;
+	}
 }
 #else
 static inline void __init pci_swiotlb_detect_4gb(void)
@@ -91,9 +90,9 @@ void __init pci_iommu_alloc(void)
 	gart_iommu_hole_init();
 	amd_iommu_detect();
 	detect_intel_iommu();
-
-	if (x86_swiotlb_enable)
-		swiotlb_init(0);
+#ifdef CONFIG_SWIOTLB
+	swiotlb_init(x86_swiotlb_enable, x86_swiotlb_flags);
+#endif
 }
 
 /*
diff --git a/arch/x86/mm/mem_encrypt_amd.c b/arch/x86/mm/mem_encrypt_amd.c
index 2b2d018ea3450..a72942d569cf9 100644
--- a/arch/x86/mm/mem_encrypt_amd.c
+++ b/arch/x86/mm/mem_encrypt_amd.c
@@ -191,9 +191,6 @@ void __init sme_early_init(void)
 	/* Update the protection map with memory encryption mask */
 	for (i = 0; i < ARRAY_SIZE(protection_map); i++)
 		protection_map[i] = pgprot_encrypted(protection_map[i]);
-
-	if (cc_platform_has(CC_ATTR_GUEST_MEM_ENCRYPT))
-		swiotlb_force = SWIOTLB_FORCE;
 }
 
 void __init sev_setup_arch(void)
diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c
index 485cd06ed39e7..c2da3eb4826e8 100644
--- a/drivers/xen/swiotlb-xen.c
+++ b/drivers/xen/swiotlb-xen.c
@@ -251,7 +251,7 @@ void __init xen_swiotlb_init_early(void)
 		panic("%s (rc:%d)", xen_swiotlb_error(XEN_SWIOTLB_EFIXUP), rc);
 	}
 
-	if (swiotlb_init_with_tbl(start, nslabs, true))
+	if (swiotlb_init_with_tbl(start, nslabs, SWIOTLB_VERBOSE))
 		panic("Cannot allocate SWIOTLB buffer");
 }
 #endif /* CONFIG_X86 */
@@ -376,7 +376,7 @@ static dma_addr_t xen_swiotlb_map_page(struct device *dev, struct page *page,
 	/*
 	 * Oh well, have to allocate and map a bounce buffer.
 	 */
-	trace_swiotlb_bounced(dev, dev_addr, size, swiotlb_force);
+	trace_swiotlb_bounced(dev, dev_addr, size);
 
 	map = swiotlb_tbl_map_single(dev, phys, size, size, 0, dir, attrs);
 	if (map == (phys_addr_t)DMA_MAPPING_ERROR)
diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h
index 1befd6b2ccf5e..dcecf953f7997 100644
--- a/include/linux/swiotlb.h
+++ b/include/linux/swiotlb.h
@@ -13,11 +13,8 @@ struct device;
 struct page;
 struct scatterlist;
 
-enum swiotlb_force {
-	SWIOTLB_NORMAL,		/* Default - depending on HW DMA mask etc. */
-	SWIOTLB_FORCE,		/* swiotlb=force */
-	SWIOTLB_NO_FORCE,	/* swiotlb=noforce */
-};
+#define SWIOTLB_VERBOSE	(1 << 0) /* verbose initialization */
+#define SWIOTLB_FORCE	(1 << 1) /* force bounce buffering */
 
 /*
  * Maximum allowable number of contiguous slabs to map,
@@ -36,8 +33,7 @@ enum swiotlb_force {
 /* default to 64MB */
 #define IO_TLB_DEFAULT_SIZE (64UL<<20)
 
-extern void swiotlb_init(int verbose);
-int swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, int verbose);
+int swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, unsigned int flags);
 unsigned long swiotlb_size_or_default(void);
 extern int swiotlb_late_init_with_tbl(char *tlb, unsigned long nslabs);
 int swiotlb_init_late(size_t size, gfp_t gfp_mask);
@@ -126,13 +122,16 @@ static inline bool is_swiotlb_force_bounce(struct device *dev)
 	return mem && mem->force_bounce;
 }
 
+void swiotlb_init(bool addressing_limited, unsigned int flags);
 void __init swiotlb_exit(void);
 unsigned int swiotlb_max_segment(void);
 size_t swiotlb_max_mapping_size(struct device *dev);
 bool is_swiotlb_active(struct device *dev);
 void __init swiotlb_adjust_size(unsigned long size);
 #else
-#define swiotlb_force SWIOTLB_NO_FORCE
+static inline void swiotlb_init(bool addressing_limited, unsigned int flags)
+{
+}
 static inline bool is_swiotlb_buffer(struct device *dev, phys_addr_t paddr)
 {
 	return false;
diff --git a/include/trace/events/swiotlb.h b/include/trace/events/swiotlb.h
index 705be43b71ab0..da05c9ebd224a 100644
--- a/include/trace/events/swiotlb.h
+++ b/include/trace/events/swiotlb.h
@@ -8,20 +8,15 @@
 #include <linux/tracepoint.h>
 
 TRACE_EVENT(swiotlb_bounced,
-
-	TP_PROTO(struct device *dev,
-		 dma_addr_t dev_addr,
-		 size_t size,
-		 enum swiotlb_force swiotlb_force),
-
-	TP_ARGS(dev, dev_addr, size, swiotlb_force),
+	TP_PROTO(struct device *dev, dma_addr_t dev_addr, size_t size),
+	TP_ARGS(dev, dev_addr, size),
 
 	TP_STRUCT__entry(
-		__string(	dev_name,	dev_name(dev)		)
-		__field(	u64,	dma_mask			)
-		__field(	dma_addr_t,	dev_addr		)
-		__field(	size_t,	size				)
-		__field(	enum swiotlb_force,	swiotlb_force	)
+		__string(dev_name, dev_name(dev))
+		__field(u64, dma_mask)
+		__field(dma_addr_t, dev_addr)
+		__field(size_t, size)
+		__field(bool, force)
 	),
 
 	TP_fast_assign(
@@ -29,19 +24,15 @@ TRACE_EVENT(swiotlb_bounced,
 		__entry->dma_mask = (dev->dma_mask ? *dev->dma_mask : 0);
 		__entry->dev_addr = dev_addr;
 		__entry->size = size;
-		__entry->swiotlb_force = swiotlb_force;
+		__entry->force = is_swiotlb_force_bounce(dev);
 	),
 
-	TP_printk("dev_name: %s dma_mask=%llx dev_addr=%llx "
-		"size=%zu %s",
+	TP_printk("dev_name: %s dma_mask=%llx dev_addr=%llx size=%zu %s",
 		__get_str(dev_name),
 		__entry->dma_mask,
 		(unsigned long long)__entry->dev_addr,
 		__entry->size,
-		__print_symbolic(__entry->swiotlb_force,
-			{ SWIOTLB_NORMAL,	"NORMAL" },
-			{ SWIOTLB_FORCE,	"FORCE" },
-			{ SWIOTLB_NO_FORCE,	"NO_FORCE" }))
+		__entry->force ? "FORCE" : "NORMAL")
 );
 
 #endif /*  _TRACE_SWIOTLB_H */
diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c
index a653fcf1fe6c2..ad604e5a0983d 100644
--- a/kernel/dma/swiotlb.c
+++ b/kernel/dma/swiotlb.c
@@ -69,7 +69,8 @@
 
 #define INVALID_PHYS_ADDR (~(phys_addr_t)0)
 
-enum swiotlb_force swiotlb_force;
+static bool swiotlb_force_bounce;
+static bool swiotlb_force_disable;
 
 struct io_tlb_mem io_tlb_default_mem;
 
@@ -88,9 +89,9 @@ setup_io_tlb_npages(char *str)
 	if (*str == ',')
 		++str;
 	if (!strcmp(str, "force"))
-		swiotlb_force = SWIOTLB_FORCE;
+		swiotlb_force_bounce = true;
 	else if (!strcmp(str, "noforce"))
-		swiotlb_force = SWIOTLB_NO_FORCE;
+		swiotlb_force_disable = true;
 
 	return 0;
 }
@@ -211,7 +212,7 @@ static void swiotlb_init_io_tlb_mem(struct io_tlb_mem *mem, phys_addr_t start,
 	mem->index = 0;
 	mem->late_alloc = late_alloc;
 
-	if (swiotlb_force == SWIOTLB_FORCE)
+	if (swiotlb_force_bounce)
 		mem->force_bounce = true;
 
 	spin_lock_init(&mem->lock);
@@ -233,12 +234,13 @@ static void swiotlb_init_io_tlb_mem(struct io_tlb_mem *mem, phys_addr_t start,
 	return;
 }
 
-int __init swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, int verbose)
+int __init swiotlb_init_with_tbl(char *tlb, unsigned long nslabs,
+		unsigned int flags)
 {
 	struct io_tlb_mem *mem = &io_tlb_default_mem;
 	size_t alloc_size;
 
-	if (swiotlb_force == SWIOTLB_NO_FORCE)
+	if (swiotlb_force_disable)
 		return 0;
 
 	/* protect against double initialization */
@@ -252,8 +254,9 @@ int __init swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, int verbose)
 		      __func__, alloc_size, PAGE_SIZE);
 
 	swiotlb_init_io_tlb_mem(mem, __pa(tlb), nslabs, false);
+	mem->force_bounce = flags & SWIOTLB_FORCE;
 
-	if (verbose)
+	if (flags & SWIOTLB_VERBOSE)
 		swiotlb_print_info();
 	return 0;
 }
@@ -262,20 +265,21 @@ int __init swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, int verbose)
  * Statically reserve bounce buffer space and initialize bounce buffer data
  * structures for the software IO TLB used to implement the DMA API.
  */
-void  __init
-swiotlb_init(int verbose)
+void __init swiotlb_init(bool addressing_limit, unsigned int flags)
 {
 	size_t bytes = PAGE_ALIGN(default_nslabs << IO_TLB_SHIFT);
 	void *tlb;
 
-	if (swiotlb_force == SWIOTLB_NO_FORCE)
+	if (!addressing_limit && !swiotlb_force_bounce)
+		return;
+	if (swiotlb_force_disable)
 		return;
 
 	/* Get IO TLB memory from the low pages */
 	tlb = memblock_alloc_low(bytes, PAGE_SIZE);
 	if (!tlb)
 		goto fail;
-	if (swiotlb_init_with_tbl(tlb, default_nslabs, verbose))
+	if (swiotlb_init_with_tbl(tlb, default_nslabs, flags))
 		goto fail_free_mem;
 	return;
 
@@ -298,7 +302,7 @@ int swiotlb_init_late(size_t size, gfp_t gfp_mask)
 	unsigned int order;
 	int rc = 0;
 
-	if (swiotlb_force == SWIOTLB_NO_FORCE)
+	if (swiotlb_force_disable)
 		return 0;
 
 	/*
@@ -337,7 +341,7 @@ swiotlb_late_init_with_tbl(char *tlb, unsigned long nslabs)
 	struct io_tlb_mem *mem = &io_tlb_default_mem;
 	unsigned long bytes = nslabs << IO_TLB_SHIFT;
 
-	if (swiotlb_force == SWIOTLB_NO_FORCE)
+	if (swiotlb_force_disable)
 		return 0;
 
 	/* protect against double initialization */
@@ -362,7 +366,7 @@ void __init swiotlb_exit(void)
 	unsigned long tbl_vaddr;
 	size_t tbl_size, slots_size;
 
-	if (swiotlb_force == SWIOTLB_FORCE)
+	if (swiotlb_force_bounce)
 		return;
 
 	if (!mem->nslabs)
@@ -708,8 +712,7 @@ dma_addr_t swiotlb_map(struct device *dev, phys_addr_t paddr, size_t size,
 	phys_addr_t swiotlb_addr;
 	dma_addr_t dma_addr;
 
-	trace_swiotlb_bounced(dev, phys_to_dma(dev, paddr), size,
-			      swiotlb_force);
+	trace_swiotlb_bounced(dev, phys_to_dma(dev, paddr), size);
 
 	swiotlb_addr = swiotlb_tbl_map_single(dev, paddr, size, size, 0, dir,
 			attrs);
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Tue Feb 22 15:52:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 15:52:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277103.473523 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMXSU-0003AB-Rx; Tue, 22 Feb 2022 15:52:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277103.473523; Tue, 22 Feb 2022 15:52:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMXSU-0003A4-P9; Tue, 22 Feb 2022 15:52:10 +0000
Received: by outflank-mailman (input) for mailman id 277103;
 Tue, 22 Feb 2022 15:52:09 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nMXST-00039y-Fl
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 15:52:09 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nMXST-0007yb-4e; Tue, 22 Feb 2022 15:52:09 +0000
Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=[192.168.9.70])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nMXSS-000321-U3; Tue, 22 Feb 2022 15:52:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=HpekjQHQOvnEKBKtofVotHDgwg2wwhLiAdI4dGWecl0=; b=H4qWuT4rI67L0div2JcxZi5O0W
	I0k464T0GioqqSgWmGo0tpN1EEj/SIbNCqncM5SFZUwU1FzdEPRbmc0CZd6o5/m1hEDEMaaXhjg3K
	OyWahugQvk2VpzIjD9lGEpJzwzslycWq9hynAzLXlMeVzoNICkGgUib0F0LVQpXZoKR4=;
Message-ID: <74edb8fc-3103-78eb-6877-2d2d6bdfa86f@xen.org>
Date: Tue, 22 Feb 2022 15:52:06 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.1
Subject: Re: [PATCH v3 01/70] xen/sort: Switch to an extern inline
 implementation
To: Andrew Cooper <andrew.cooper3@citrix.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
Cc: Jan Beulich <JBeulich@suse.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Wei Liu <wl@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <20220222152645.8844-1-andrew.cooper3@citrix.com>
 <20220222152645.8844-2-andrew.cooper3@citrix.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220222152645.8844-2-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 22/02/2022 15:26, Andrew Cooper wrote:
> There are exactly 3 callers of sort() in the hypervisor.  Callbacks in a tight
> loop like this are problematic for performance, especially with Spectre v2
> protections, which is why extern inline is used commonly by libraries.
> 
> Both ARM callers pass in NULL for the swap function, and while this might seem
> like an attractive option at first, it causes generic_swap() to be used, which
> forced a byte-wise copy.  Provide real swap functions so the compiler can
> optimise properly, which is very important for ARM downstreams where
> milliseconds until the system is up matters.
After the previous discussion, I was expecting the sentence "Provide 
real..." to be completely dropped. Instead the change should be 
justified with...

> This is also important for Control Flow Integrity schemes (e.g. x86 CET-IBT,
> ARM BTI), because tagged function(s) performing an arbitrary length swap of
> two arbitrary pointers is a very valuable gadget for an attacker.

... this one as this is the real reason of the change. Not the 
performance (unless you have numbers proving it).

> 
> No functional change.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Reviewed-by: Jan Beulich <jbeulich@suse.com>
> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>

To be pedantic, my Nacked-by hasn't been yet revoked (see [1]). So you 
should have kept it in the new version.

Anyway, given that the patch makes sense for BTI, I am willing to 
replace the Nacked-by with an Acked-by:

Acked-by: Julien Grall <jgrall@amazon.com>

[1] 
https://lore.kernel.org/xen-devel/70824a0c-cc48-b064-695c-35c2d06c0ad1@xen.org/

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Feb 22 15:56:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 15:56:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277110.473535 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMXWI-0003ng-D4; Tue, 22 Feb 2022 15:56:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277110.473535; Tue, 22 Feb 2022 15:56:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMXWI-0003nZ-9X; Tue, 22 Feb 2022 15:56:06 +0000
Received: by outflank-mailman (input) for mailman id 277110;
 Tue, 22 Feb 2022 15:56:05 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/+sy=TF=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1nMXWH-0003nR-7y
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 15:56:05 +0000
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur03on0608.outbound.protection.outlook.com
 [2a01:111:f400:fe09::608])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f01e285b-93f7-11ec-8539-5f4723681683;
 Tue, 22 Feb 2022 16:56:04 +0100 (CET)
Received: from AS8P250CA0020.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:330::25)
 by VI1PR08MB5486.eurprd08.prod.outlook.com (2603:10a6:803:13b::8)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.16; Tue, 22 Feb
 2022 15:56:01 +0000
Received: from AM5EUR03FT043.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:330:cafe::eb) by AS8P250CA0020.outlook.office365.com
 (2603:10a6:20b:330::25) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.27 via Frontend
 Transport; Tue, 22 Feb 2022 15:56:01 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT043.mail.protection.outlook.com (10.152.17.43) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4995.20 via Frontend Transport; Tue, 22 Feb 2022 15:56:00 +0000
Received: ("Tessian outbound 31aeb3346a45:v113");
 Tue, 22 Feb 2022 15:56:00 +0000
Received: from dc9c918bfe2a.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 65346AE2-B0A3-400F-A789-9C262FBD1106.1; 
 Tue, 22 Feb 2022 15:55:54 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id dc9c918bfe2a.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 22 Feb 2022 15:55:54 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by DB7PR08MB3132.eurprd08.prod.outlook.com (2603:10a6:5:1c::24) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.15; Tue, 22 Feb
 2022 15:55:52 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::aca7:79c4:fa65:dac6]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::aca7:79c4:fa65:dac6%5]) with mapi id 15.20.5017.021; Tue, 22 Feb 2022
 15:55:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f01e285b-93f7-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Q96EPRLN6lOCNXhoIsVcJhkAY3USlWnDsqaneI8vgz4=;
 b=rRYzK7LH7nuthG+zYZYDz9xA6r/WapHStNSmKcbfulxZy4V2JqYVwLvxSzcg3Pal2olv6Trnw00betP81usxyKTJBkc1RRnEH47e1ut+Dc0Z4fg9jDMiNYTQlpSd9jvIfIqmQVB6EWcOjdoR0IT7ndoIOHktp7w9eeMnydJi/+A=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 949761d3e2e41497
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=oKspROY1vWnGi2pQPWaMwaTuhHxt1wY0VuIn1jtz9NV/2CSOY54BEsfiswIEDTS4vrlmE2D3zOdIamSUNdFTY37i5Yk+eTPKfwchLgD3monqqSW8ra/ZT0MHNiRCnGWOEFcv+u4PEFIq6/F2dW8WZuLRueV3fjrIbpZqTuENs25BOgamww4Wlzv7EJSDIqq76nAvi+oEtKBHGzX5vdZZxPLHkJfQ9J2xmztthBFbfc2vFlPXc4LmHF4WAtXcqs2cF6GEwYvHaSsyF/9DAuhFMI1c47TtcNqtq/sO7+6PvJ8EXLf4A9yXO3UfRHL+4amx15fuO647JXQA17xEcilZuQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Q96EPRLN6lOCNXhoIsVcJhkAY3USlWnDsqaneI8vgz4=;
 b=WJgfk7TEGoNN2IhcbRYA8+nrboV0izVdnEnBmuDSOTeLb6zsUO/9xnSR/wXSr/QFcbP0Zu5doTiTOklI9+0nT7zlhbRaHwuoSUvpmssKknrSMB6Zw2iyHIAfYt5xrugkk3qD0TlDiCZ/4vJEifSE/LUpeWXL2D6oXNC+qNgISsG23P41dW59ctgyIdBVVhBwETnyVY2eFp3DUB00aNc/GXwH4RMN1xq6Q7SSJiz052yVHIfhO0cty4WteKa/60RBUrJakvxfk0DnfEdi1aioiEvyW1zrAilfNCBaZG3nFaDjN3MNnyuUSQlGb6MWSVc5hjUcE+bLbGFQ2e92wmKgXQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Q96EPRLN6lOCNXhoIsVcJhkAY3USlWnDsqaneI8vgz4=;
 b=rRYzK7LH7nuthG+zYZYDz9xA6r/WapHStNSmKcbfulxZy4V2JqYVwLvxSzcg3Pal2olv6Trnw00betP81usxyKTJBkc1RRnEH47e1ut+Dc0Z4fg9jDMiNYTQlpSd9jvIfIqmQVB6EWcOjdoR0IT7ndoIOHktp7w9eeMnydJi/+A=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Julien Grall <julien@xen.org>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Julien
 Grall <jgrall@amazon.com>, Stefano Stabellini <sstabellini@kernel.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v3 03/19] xen/arm: p2m: Replace level_{orders, masks}
 arrays with XEN_PT_LEVEL_{ORDER, MASK}
Thread-Topic: [PATCH v3 03/19] xen/arm: p2m: Replace level_{orders, masks}
 arrays with XEN_PT_LEVEL_{ORDER, MASK}
Thread-Index: AQHYJwz3/5rVW4vmxU2XDig/F0ROyKyfuzqA
Date: Tue, 22 Feb 2022 15:55:52 +0000
Message-ID: <66B2C3AB-A61C-4CC7-8249-AA925B2774FD@arm.com>
References: <20220221102218.33785-1-julien@xen.org>
 <20220221102218.33785-4-julien@xen.org>
In-Reply-To: <20220221102218.33785-4-julien@xen.org>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3693.60.0.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: be5778bf-31dc-44bd-4577-08d9f61bd297
x-ms-traffictypediagnostic:
	DB7PR08MB3132:EE_|AM5EUR03FT043:EE_|VI1PR08MB5486:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR08MB548684782C48EA6360EABEC49D3B9@VI1PR08MB5486.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 HpZlxlUtn6Dz59QGXFmrcDI0nUx0e82yqeihGJXEq5D3s+29T7W8RGgN2PgApv6Qe3sHTwqtOyo+jI74tFqgK7UKqy7yhlqppLKi9cfsTWcdkxI7VXPh48G4Qp0mg82mJAZQiAkITN8cnIdaxk4gwBIouGxsPo8FcO3RVnGr0M6cmagjgHrK/8AZK89kL2DUicBofMMXNnPD0GF1XE9ZMJg0IvRPNZdITaCUH7aSvWt5MVWwEp4sUyjWAOYwkVB0GfzDJLNJ3P8k49oUvZ0GqnDt2syHoc7PsEV7ZM2p6rtfmaejjT6JKWkZ62pv7WxakwH+niH3r2wcUR/Q8CaMklSo0l/w1X3Exjhp4hRexrOSdVYSMyoPR4b9ean23LElRgGk68rFtvJ3wzCXez8GKPILjx+NUwjfZaXE7fMN/20rdLNJtpqVI0nltfamGliJJML80QVltlmWDg8aGJofK7LpgVja3whdz9ITD+Of1fbwcecog2zSANjSmLJvi8WRRfhmyYqnOSAKl/2bHXt3O1R0A96sHuw9FcB+cHF1oJY4UXksQdUgha/oM+o2Qvf5EvsyHRcx2i1WWbLlnGkgGB2A5hRTf7ElmaZ3zvkU5kT+ATEuNlGhMMYnyHjdq4ARmbNpzq0SlFE9nQxATLEPMHbqijlgT7zB3gZpOWhP6i62JsT/tc9lRplQxB3FtcZD38Nnim8F3g00LUmBid6jA1sPOoqv2H7saO9ymv975QjD+nOZuEuLr/LiGsFTM4h5
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(86362001)(64756008)(66556008)(38100700002)(66446008)(38070700005)(6486002)(8676002)(122000001)(66476007)(66946007)(91956017)(5660300002)(6916009)(316002)(4326008)(54906003)(76116006)(83380400001)(2906002)(8936002)(36756003)(2616005)(33656002)(71200400001)(186003)(26005)(508600001)(53546011)(6512007)(6506007)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <6279783AE37A9848A8F08CBEB4363C38@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3132
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT043.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	5bc82c72-af39-4a5b-3e78-08d9f61bcd8f
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	iM8NJBTTKjYIT/DRQvwPUbJIhzdX0YUiIyoBc4erk0KowV321XOYT1+UQAsRWeEoz/GFgoXMRqjjQSbUYMSa28qILFfSzIab7T89EEep/Cqz/tWVbMFAhtkDK9q+HSzPXj2X6E3uhzKF262AzQoo5pQl/zKH2/i1CAqFeQC5FeePmY5NyLN5qcr/2LwK+h1ErIPwc9LyWcuR28tC5sjC169V7766sqMgmCdyzQVVor0tbqXCyG/JnWIiVufHzbrtVUYSWE2Go4sBSDfWbEcSsPVsvNHtfT9rieZ59OBA84UKGnyvSBA8zSdYrLp2eHHKcMq0dCzvGO7rM7Pve8lqFDR9dXmnRfOOIEuEsBcUHFhdRNQ0qNS0sXKErwlBIAJCi9b1JjKot6RCpBGYku0Ovf8fGFhVMFqyV0B1/6BzdEYHROAi5keUB3h0f/GREltenBSyBR4zoDo7nEhE2n7/fDoksNtt+zkVOo2vXBNHEBx3rF7vnT29qRyAhta0wAXKuvBbtOQXUkWxRkUr+bVb5Y8dpZkHDNbOFNmubSFAEoqHBRCWt+6psl1oIgGu5+FQMcnY8gsvbydYWb57klMB+3gNMT+vMMQSLXvGlIxVjK9hggoHoB88vU4/K/da5zKO6W6Q7mAT0gpqcT0NDCI2gC4y49WUT1EBJgTncmV2Kh64l4t3pr0y4DJ9eDpfsQjm
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(36756003)(2616005)(40460700003)(33656002)(6486002)(6506007)(6512007)(53546011)(107886003)(508600001)(47076005)(36860700001)(2906002)(186003)(5660300002)(4326008)(54906003)(8936002)(26005)(8676002)(316002)(356005)(82310400004)(86362001)(336012)(81166007)(70586007)(70206006)(83380400001)(6862004);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2022 15:56:00.6689
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: be5778bf-31dc-44bd-4577-08d9f61bd297
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT043.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5486

Hi Julien,

> On 21 Feb 2022, at 10:22, Julien Grall <julien@xen.org> wrote:
>=20
> From: Julien Grall <jgrall@amazon.com>
>=20
> The array level_orders and level_masks can be replaced with the
> recently introduced macros LEVEL_ORDER and LEVEL_MASK.
>=20
> Signed-off-by: Julien Grall <jgrall@amazon.com>

Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>

One open question: At this stage the convenience aliases that you
kept in include/asm/lpae.h are used in a very limited number of places.
Could we remove those and use only XEN_PT_LEVEL_* to make the
code a bit more coherent.

Not something to do here but could be done in a following patch after
this serie

Cheers
Bertrand

>=20
> ---
>    Changes in v3:
>        - Fix clashes after prefixing the PT macros with XEN_PT_
>=20
>    Changes in v2:
>        - New patch
>=20
>    The goal is to remove completely the static arrays so they
>    don't need to be global (or duplicated) when adding superpage
>    support for Xen PT.
>=20
>    This also has the added benefits to replace a couple of loads
>    with only a few instructions working on immediate.
> ---
> xen/arch/arm/p2m.c | 17 ++++++-----------
> 1 file changed, 6 insertions(+), 11 deletions(-)
>=20
> diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
> index 493a1e25879a..1d1059f7d2bd 100644
> --- a/xen/arch/arm/p2m.c
> +++ b/xen/arch/arm/p2m.c
> @@ -37,12 +37,6 @@ static unsigned int __read_mostly max_vmid =3D MAX_VMI=
D_8_BIT;
>  */
> unsigned int __read_mostly p2m_ipa_bits =3D 64;
>=20
> -/* Helpers to lookup the properties of each level */
> -static const paddr_t level_masks[] =3D
> -    { ZEROETH_MASK, FIRST_MASK, SECOND_MASK, THIRD_MASK };
> -static const uint8_t level_orders[] =3D
> -    { ZEROETH_ORDER, FIRST_ORDER, SECOND_ORDER, THIRD_ORDER };
> -
> static mfn_t __read_mostly empty_root_mfn;
>=20
> static uint64_t generate_vttbr(uint16_t vmid, mfn_t root_mfn)
> @@ -233,7 +227,7 @@ static lpae_t *p2m_get_root_pointer(struct p2m_domain=
 *p2m,
>      * we can't use (P2M_ROOT_LEVEL - 1) because the root level might be
>      * 0. Yet we still want to check if all the unused bits are zeroed.
>      */
> -    root_table =3D gfn_x(gfn) >> (level_orders[P2M_ROOT_LEVEL] +
> +    root_table =3D gfn_x(gfn) >> (XEN_PT_LEVEL_ORDER(P2M_ROOT_LEVEL) +
>                                 XEN_PT_LPAE_SHIFT);
>     if ( root_table >=3D P2M_ROOT_PAGES )
>         return NULL;
> @@ -380,7 +374,7 @@ mfn_t p2m_get_entry(struct p2m_domain *p2m, gfn_t gfn=
,
>     if ( gfn_x(gfn) > gfn_x(p2m->max_mapped_gfn) )
>     {
>         for ( level =3D P2M_ROOT_LEVEL; level < 3; level++ )
> -            if ( (gfn_x(gfn) & (level_masks[level] >> PAGE_SHIFT)) >
> +            if ( (gfn_x(gfn) & (XEN_PT_LEVEL_MASK(level) >> PAGE_SHIFT))=
 >
>                  gfn_x(p2m->max_mapped_gfn) )
>                 break;
>=20
> @@ -423,7 +417,8 @@ mfn_t p2m_get_entry(struct p2m_domain *p2m, gfn_t gfn=
,
>          * The entry may point to a superpage. Find the MFN associated
>          * to the GFN.
>          */
> -        mfn =3D mfn_add(mfn, gfn_x(gfn) & ((1UL << level_orders[level]) =
- 1));
> +        mfn =3D mfn_add(mfn,
> +                      gfn_x(gfn) & ((1UL << XEN_PT_LEVEL_ORDER(level)) -=
 1));
>=20
>         if ( valid )
>             *valid =3D lpae_is_valid(entry);
> @@ -434,7 +429,7 @@ out_unmap:
>=20
> out:
>     if ( page_order )
> -        *page_order =3D level_orders[level];
> +        *page_order =3D XEN_PT_LEVEL_ORDER(level);
>=20
>     return mfn;
> }
> @@ -808,7 +803,7 @@ static bool p2m_split_superpage(struct p2m_domain *p2=
m, lpae_t *entry,
>     /* Convenience aliases */
>     mfn_t mfn =3D lpae_get_mfn(*entry);
>     unsigned int next_level =3D level + 1;
> -    unsigned int level_order =3D level_orders[next_level];
> +    unsigned int level_order =3D XEN_PT_LEVEL_ORDER(next_level);
>=20
>     /*
>      * This should only be called with target !=3D level and the entry is
> --=20
> 2.32.0
>=20



From xen-devel-bounces@lists.xenproject.org Tue Feb 22 16:25:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 16:25:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277117.473546 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMXyN-0007c1-MI; Tue, 22 Feb 2022 16:25:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277117.473546; Tue, 22 Feb 2022 16:25:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMXyN-0007bu-IE; Tue, 22 Feb 2022 16:25:07 +0000
Received: by outflank-mailman (input) for mailman id 277117;
 Tue, 22 Feb 2022 16:25:06 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=QzH2=TF=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nMXyL-0007bo-SU
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 16:25:05 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id fcf9a394-93fb-11ec-8539-5f4723681683;
 Tue, 22 Feb 2022 17:25:03 +0100 (CET)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2055.outbound.protection.outlook.com [104.47.12.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-32-K4EhoJ7LPSucR139jvCoSg-2; Tue, 22 Feb 2022 17:25:02 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4926.eurprd04.prod.outlook.com (2603:10a6:803:51::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.27; Tue, 22 Feb
 2022 16:24:59 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.4995.027; Tue, 22 Feb 2022
 16:24:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fcf9a394-93fb-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645547103;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=x1Lcjih1S+OG9gAoBIRvmSRkRdhhFQtriojez0BN0kA=;
	b=hNsHz548bFHAGIGleX1g2pTlLrAOGbPvtCrjkK0me7213vkH12rloqnNQG1e+wWEGmkNxl
	z9C0n3NBM8vP2AVbLWeuJvT/DQ1MRNc5p8ZC6UqXKZlxbTrEedcte9nfm9Hw+8R0ptnoEL
	WhftWYUvwwc+sdWFjmhsxekTMiNzNvc=
X-MC-Unique: K4EhoJ7LPSucR139jvCoSg-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Nt+PcRA+OSC/nLIsO/GRBFjrvV/R0tGL9Jqa5OGsjJBGjzJNJQCb95U0xye9VY2lImkeFFPs9IHcjaGtMcRwMmitAVhkggwhHwfL2nAj4ktNZavdXIaWlwo3SmqmoCdW2QtZccXmrdHoCY+ivqDyVWbi9mbeW2TgrBOfbGoV8HT1NGkE15elP7OmzSpPfxBillmKUNMQ3eKxXUrCjhfqtsSQuEJsP+hMuo7iPHQUeOerUnSuD21/AvxEz279GjeVqDnwX2HUACYwRQ3T75Lr1G7m5KVC0IX0iWRZ5MoFqWMQpdGWWsFoadEapdf3FE3qBZwggQOMoQhMN8TcZ5kTXg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=7NdjwQVYqTQok97A0/KcCSmBYeB9IWDJXx/VY5gpWZs=;
 b=N6ejXkQryEAEY5gYbfehho6PyE25HRcFd1LlhVCTNX7WjCsuTFBw3A99IXn5DCgYU678EYff6Ya7udtPe491cOoTGT7i8ytVoKJqsKRqUcJUhZLyleB+8fqsY169OmibvvHXthQ2jqVYb196dTS/kIJqpWRmcztLbFD6E3qpz14Muckqz60wPJHe0n9bkiJWh4TrfmgFKpaaDLF/BOS/otfXbrEDWEIxKnjUTFW99tL9S3QGO1t+rd5ZGKueYpb66bs2rahmEgx/TPExCimn9tnilFno5cFYRmcjEMlYMgua5KS7aLBv8R7QbYoFY6cPhcULyStVyDskQJh63T42RQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <c8c6be89-d880-f5d4-b382-0d8e06a7de0e@suse.com>
Date: Tue, 22 Feb 2022 17:24:57 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v3 03/70] x86/pv-shim: Don't modify the hypercall table
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Juergen Gross <jgross@suse.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20220222152645.8844-1-andrew.cooper3@citrix.com>
 <20220222152645.8844-3-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220222152645.8844-3-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6P193CA0082.EURP193.PROD.OUTLOOK.COM
 (2603:10a6:209:88::23) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7006844f-1704-45af-152b-08d9f61fdece
X-MS-TrafficTypeDiagnostic: VI1PR04MB4926:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB4926A1E3B4B0CA53AB373627B33B9@VI1PR04MB4926.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Igg+sT4pkL754o21TJ4o1gChRHQn7p+RWlGQ7MyRX9yu/jgMdxcDjdFBEJLEZLUOCIWdrsZHWajoCVw2+Q/S19s6GrZzoQkc3ncYGZ+W/MrEdP4MgOTq3rgD5jReHb2vEA0a+RmT83h3KAtBLxHkxzPG81QRM8jWlIKiJnN45A8RZxLSjwjqAKQUQrZBg/nKnnCZ0vvY+lF93ybepv7o3hcTuAHgPFt/Bk7z67dQ76LkJtx11EHzPr2oWWOyRqYWzOyEEp5OebXW7/FOP6UBXoqBtRwk787niXuvb4xRHAomj1N/30/tWBJ5l0tw4briP6rQB5boUQhKr6drkrJUxGg6+OCcCaCozUg8g1Jqtgd9FliKeBmnpqvZsLRQEMkkz7dW2bOxUTjK/k47Vzrpzzzhq2qSKIzsHkNLPnAm1bGC8nxLKAOh7FOAF+Vco9eJQ+nbhY1aMuXUpd5BP16O8/bAC0glEEGpJ3ZTykXZGvTYnOySEcyM/gJJpMGFucDqSamB+8d2o76SWeOIBJiOgdlvHOFvrOmt2Ve+ZKLekewr7XWIMdAXiMDaMxcBIANmGcknL5usH7Ce+lypsNdJNEr4W6Ige241Z2dysFohqduat2dRT4GU/STm3jWn7F8SzCpE2YdMzmg8l/ipBXhkqBcegmsTTlciA0C5KQtWs4HSlM70+uCAJVd6AqvWTaOFjITatzFw3WaotbLbtAvOBIjvSrrv4OOuIJWRHsMwauhjS1emD1Qv40CZKD8hJtuj
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8936002)(508600001)(36756003)(5660300002)(31686004)(6486002)(26005)(186003)(6512007)(4326008)(8676002)(6916009)(54906003)(38100700002)(86362001)(6506007)(53546011)(66574015)(2906002)(66556008)(66946007)(66476007)(2616005)(316002)(31696002)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?G39FspoNqFJ9cvueYI/pFUPP0j6hW5t4RzI4RWG0oUwhSVWA/wuRq5Gi+A7o?=
 =?us-ascii?Q?p7UNIicVTCeCG8QHbHaXN3VK+T4KdkLjxPJX62XRfpJDaKUqkpJmMOQnHs2Y?=
 =?us-ascii?Q?/K3HhOkshwts6JOTCli/GQd/cbsOrbqJXDVpFMhcg2Kvzg2D46Kxb+gF3sQA?=
 =?us-ascii?Q?gEhkd/4KSosYkuCNHd98u62d7BbEGq6PzZptUmaJVNICQwaQmD2ebPsq4xMX?=
 =?us-ascii?Q?ub/6wniJHl0NT/z5HL28bInsCsD4h57FwOxz11d/ZIB156y7SUuTHCLvHUq3?=
 =?us-ascii?Q?+mfDTWctyVwpbPaIzOkgKPSL1s9pcDDrwnTrJ+6wtTgZWkr7lzBR6rIyTKE/?=
 =?us-ascii?Q?65wnLmkeJi/Bgj2JAXZjTp9jq8utf+8IwyE7DST2k01IVruwUVB21ktudXiH?=
 =?us-ascii?Q?qxpZUzOJwtxrtT3L78NN4pa5fPrTBLN84jIKwbhCm40YIZ1YZ9MM/mDOTwmx?=
 =?us-ascii?Q?LN7wt1qZCBQLmUkwN+8H/zqPn7KyLPEgmz9POXYMR3EVcCp7TSm4jqJtrCoY?=
 =?us-ascii?Q?IotU58goqMTW1xsqsZGDlJhbMgbZ9T4Y9uZAA3AVO2jszSpphd0ij8of0PgM?=
 =?us-ascii?Q?vJ0/vHDx8ytKZXvjJ141RkxmY2znUlRNt0rpOdG5pRNGPBYaD8ofbqhCFZQy?=
 =?us-ascii?Q?0QHkTVqQki1XYJn1H74hDqCLRG4U8foRQD9lDywHIOYUpexZYKfL9n/H0RWI?=
 =?us-ascii?Q?WGysq1a/jhEVpdUV9zQ9bNTNEKk0wfqMNf2nccWiRemMzBDK6ByUXFAg+3I1?=
 =?us-ascii?Q?tvZh5ajXYCOCcsI5TvTGEQAM/oG0soGkOnPt1gMuDEkZo+AqJTkkGqVQsB9k?=
 =?us-ascii?Q?rxdgsJrF2xSDP1+YG8RW6Uuw2I4dYLx0sqviyj0xMus2ejpjkSvtxj9A6cWL?=
 =?us-ascii?Q?Y1o7SIr8Df/tivZFKmUEEMqRp3rg+Gfed1kcBkGmzEPeXi7tFi5i23J2Sokq?=
 =?us-ascii?Q?PF67uucOgwwUKep1uXul7cisAmHEuFc3dCuAQAP42w7MqIcwuTqLnbUT6W24?=
 =?us-ascii?Q?D4MG1NDEdhhmdOLrcq+aQLOobNF26/iHIQn6EhWx0TaFvmk2DXnu1y27dXXq?=
 =?us-ascii?Q?q2ffwtHG3PwiGyFbxDfr3iUsTZiccmtEpk1mBvOL1gLlmBHp/8XZwUgNPHyq?=
 =?us-ascii?Q?1Co/y2CCwE2jhHMXllzJDXJAhUAStNbxpVMkHnYcyw9gpkQ0QJzRGRrzA8bI?=
 =?us-ascii?Q?Nl699mPYd+YO9xXXtEgGnEtTvRFEVzSGiRCORWsPn5Y4R0U0ly+YEYxaPh/Y?=
 =?us-ascii?Q?KViUZywaA7vSl6LaSo3e3u//+cVUpENFm/gM/1GmBs81IWE+mhZtV++Oa7sj?=
 =?us-ascii?Q?G8FhnuxiQfGHud52HF5nUEjJZZZpTBq2PALtFhBmN1RugxNWufpSCMa1XGIu?=
 =?us-ascii?Q?2ISR9sANhnVkc7kwmx9IH6i34j0/fS702ELc2bHpO6pWT2GkydcYiatSQrqP?=
 =?us-ascii?Q?sPhNNYKZe0p973pbhEF4h48YEQItaIpvWQBQKYxBYfK2SNNeVd1LqOMps140?=
 =?us-ascii?Q?x2TBPt2I5YUTSr4784ybxy1QmcK3132DxjgP8ep63myxIiWMhOr2BU3OjAxv?=
 =?us-ascii?Q?CEaUVl2cOw+onFeIH/pq9/DePpNl4FG0vO288R+NP00mxlzEWYwVaMVM1Hnq?=
 =?us-ascii?Q?UjPxPVwYndKFfOdp73zbz+A=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7006844f-1704-45af-152b-08d9f61fdece
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2022 16:24:59.4133
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xC99x3qPZlZcqGa/lj5t/eZaI2ToGi2gbGho7uAMTje39WLym4Nc5vyK7TERnpqeARYdlNV8SZWQJaaNR57ufA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4926

On 22.02.2022 16:26, Andrew Cooper wrote:
> From: Juergen Gross <jgross@suse.com>
>=20
> When running as pv-shim the hypercall is modified today in order to
> replace the functions for __HYPERVISOR_event_channel_op and
> __HYPERVISOR_grant_table_op hypercalls.
>=20
> Change this to call the related functions from the normal handlers
> instead when running as shim. The performance implications are not
> really relevant, as a normal production hypervisor will not be
> configured to support shim mode, so the related calls will be dropped
> due to optimisation of the compiler.
>=20
> Note that for the CONFIG_PV_SHIM_EXCLUSIVE case there is a dummy
> wrapper do_grant_table_op() needed, as in this case grant_table.c
> isn't being built.
>=20
> Signed-off-by: Juergen Gross <jgross@suse.com>
> [Split out of series.  Make compile in isolation]
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

As said, somewhat hesitantly
Reviewed-by: Jan Beulich <jbeulich@suse.com>

"Make compile in isolation", while describing the changes which weren't
in J=C3=BCrgen's original patch, is quite terse. But anyway.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Feb 22 17:34:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 17:34:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277126.473556 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMZ3e-00061r-QT; Tue, 22 Feb 2022 17:34:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277126.473556; Tue, 22 Feb 2022 17:34:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMZ3e-00061k-Mv; Tue, 22 Feb 2022 17:34:38 +0000
Received: by outflank-mailman (input) for mailman id 277126;
 Tue, 22 Feb 2022 17:34:37 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=6+Aw=TF=chiark.greenend.org.uk=ijackson@srs-se1.protection.inumbo.net>)
 id 1nMZ3d-00061e-7i
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 17:34:37 +0000
Received: from chiark.greenend.org.uk (v6.chiark.greenend.org.uk
 [2001:ba8:1e3::]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b26e0011-9405-11ec-8539-5f4723681683;
 Tue, 22 Feb 2022 18:34:35 +0100 (CET)
Received: by chiark.greenend.org.uk (Debian Exim 4.89 #1) with local
 (return-path ijackson@chiark.greenend.org.uk)
 id 1nMZ3Y-0004Zc-U7; Tue, 22 Feb 2022 17:34:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b26e0011-9405-11ec-8539-5f4723681683
From: Ian Jackson <ijackson@chiark.greenend.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <25109.7848.755943.430643@chiark.greenend.org.uk>
Date: Tue, 22 Feb 2022 17:34:32 +0000
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] coverity: disable flight from crontab
In-Reply-To: <20220221094800.54169-1-roger.pau@citrix.com>
References: <20220221094800.54169-1-roger.pau@citrix.com>
X-Mailer: VM 8.2.0b under 24.4.1 (i586-pc-linux-gnu)

Roger Pau Monne writes ("[PATCH] coverity: disable flight from crontab"):
> We are currently doing the Coverity Scans using a github workflow.

Acked-by: Ian Jackson <ijackson@chiark.greenend.org.uk>


-- 
Ian Jackson <ijackson@chiark.greenend.org.uk>   These opinions are my own.  

Pronouns: they/he.  If I emailed you from @fyvzl.net or @evade.org.uk,
that is a private address which bypasses my fierce spamfilter.


From xen-devel-bounces@lists.xenproject.org Tue Feb 22 18:20:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 18:20:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277133.473567 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMZm3-0002fy-BK; Tue, 22 Feb 2022 18:20:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277133.473567; Tue, 22 Feb 2022 18:20:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMZm3-0002fr-8R; Tue, 22 Feb 2022 18:20:31 +0000
Received: by outflank-mailman (input) for mailman id 277133;
 Tue, 22 Feb 2022 18:20:30 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nMZm2-0002fh-0L; Tue, 22 Feb 2022 18:20:30 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nMZm1-0002lf-VU; Tue, 22 Feb 2022 18:20:29 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nMZm1-0001AN-GX; Tue, 22 Feb 2022 18:20:29 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nMZm1-00076H-G7; Tue, 22 Feb 2022 18:20:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=/J2AX4b371HKEk9fDXizi3uTwWh3hGEoUBMotr06taI=; b=gbjnJs3aQRurwrfRitbZwo6toD
	Qw7Y7vhLfuo9OwqZEILICKLERfQ1P7HA6gzne/fzZIUWyT0V4WWUICLpAG06M6SHq75cBofLZG2I2
	qm/nZxYDXN5MxD0Igsa/rteOrzY3pcoymytRNXNtOVbgsZr9Mm0c5abjqTVREBusM2i0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168195-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 168195: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=210f27e55abd2a57c01105992bc10bc4d7b8132d
X-Osstest-Versions-That:
    xen=95d9ab46143685f169f636cfdd7997e2fc630e86
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 22 Feb 2022 18:20:29 +0000

flight 168195 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168195/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  210f27e55abd2a57c01105992bc10bc4d7b8132d
baseline version:
 xen                  95d9ab46143685f169f636cfdd7997e2fc630e86

Last test of basis   168188  2022-02-21 21:01:44 Z    0 days
Testing same since   168195  2022-02-22 15:01:45 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Roger Pau Monne <roger.pau@citrix.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   95d9ab4614..210f27e55a  210f27e55abd2a57c01105992bc10bc4d7b8132d -> smoke


From xen-devel-bounces@lists.xenproject.org Tue Feb 22 18:52:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 18:52:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277144.473579 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMaH8-0005vL-T1; Tue, 22 Feb 2022 18:52:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277144.473579; Tue, 22 Feb 2022 18:52:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMaH8-0005vD-QB; Tue, 22 Feb 2022 18:52:38 +0000
Received: by outflank-mailman (input) for mailman id 277144;
 Tue, 22 Feb 2022 18:52:37 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=lqcG=TF=wind.enjellic.com=greg@srs-se1.protection.inumbo.net>)
 id 1nMaH7-0005v7-AO
 for xen-devel@lists.xen.org; Tue, 22 Feb 2022 18:52:37 +0000
Received: from wind.enjellic.com (wind.enjellic.com [76.10.64.91])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 97730dc9-9410-11ec-8539-5f4723681683;
 Tue, 22 Feb 2022 19:52:33 +0100 (CET)
Received: from wind.enjellic.com (localhost [127.0.0.1])
 by wind.enjellic.com (8.15.2/8.15.2) with ESMTP id 21MIqVOD015731;
 Tue, 22 Feb 2022 12:52:31 -0600
Received: (from greg@localhost)
 by wind.enjellic.com (8.15.2/8.15.2/Submit) id 21MIqUfg015730;
 Tue, 22 Feb 2022 12:52:30 -0600
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 97730dc9-9410-11ec-8539-5f4723681683
Date: Tue, 22 Feb 2022 12:52:30 -0600
From: "Dr. Greg" <greg@enjellic.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: xen-devel@lists.xen.org
Subject: Re: IGD pass-through failures since 4.10.
Message-ID: <20220222185230.GA15532@wind.enjellic.com>
Reply-To: "Dr. Greg" <greg@enjellic.com>
References: <20220214060011.GA24404@wind.enjellic.com> <198ef291-4dee-ddac-aef6-8451bc1e880c@suse.com> <20220217201534.GA29303@wind.enjellic.com> <dc1a4483-7dca-aa72-6b86-4217e6840efb@suse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <dc1a4483-7dca-aa72-6b86-4217e6840efb@suse.com>
User-Agent: Mutt/1.4i
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.2.3 (wind.enjellic.com [127.0.0.1]); Tue, 22 Feb 2022 12:52:31 -0600 (CST)

On Fri, Feb 18, 2022 at 08:04:14AM +0100, Jan Beulich wrote:

Good morning, I hope the week is advancing well for everyone.

> On 17.02.2022 21:15, Dr. Greg wrote:
> > On Mon, Feb 14, 2022 at 09:56:34AM +0100, Jan Beulich wrote:
> >> On 14.02.2022 07:00, Dr. Greg wrote:
> >>> It appears to be a problem with mapping interrupts back to dom0 given
> >>> that we see the following:
> >>>
> >>> Feb 10 08:16:05 hostname kernel: xhci_hcd 0000:00:14.0: xen map irq failed -19 for 32752 domain
> >>>
> >>> Feb 10 08:16:05 hostname kernel: i915 0000:00:02.0: xen map irq failed -19 for 32752 domain
> >>>
> >>> Feb 10 08:16:12 hostname kernel: xhci_hcd 0000:00:14.0: Error while assigning device slot ID
> > 
> >> Just on this one aspect: It depends a lot what precisely you've used
> >> as 4.10 before. Was this the plain 4.10.4 release, or did you track
> >> the stable branch, accumulating security fixes?
> > 
> > It was based on the Xen GIT tree with a small number of modifications
> > that had been implemented by Intel to support their IGD
> > virtualization.
> > 
> > We did not end up using 'IGD virtualization', for a number of
> > technical reasons, instead we reverted back to using straight device
> > passthrough with qemu-traditional that we had previously been using.
> > 
> > If it would up being useful, we could come up with a diff between the
> > stock 4.10.4 tag and the codebase we used.
> > 
> > One of the purposes of the infrastructure upgrade was to try and get
> > on a completely mainline Xen source tree.

> Depending on the size of the diff, this may or may not be helpful.
> What you sadly didn't state is at least the precise base version.

The stack that is in use is 18 patches beyond what is tagged as the
Xen 4.10 release.

I can generate the diff but most of the patches appear to be
infrastructure changes to support the VGT virtual display devices.

> >> would suspect device quarantining to get getting in your way. In
> >> which case it would be relevant to know what exactly "re-attach to
> >> the Dom0" means in your case.
> > 
> > Re-attach to Dom0 means to unbind the device from the pciback driver
> > and then bind the device to its original driver.  In the logs noted
> > above, the xhci_hcd driver to the USB controller and the i915 driver
> > to the IGD hardware.
> > 
> > It is the same strategy, same script actually, that we have been using
> > for 8+ years.

> Right, but in the meantime quarantining has appeared. That wasn't
> intended to break "traditional" usage, but ...

We just finished testing the 4.15.2 release and we got one successful
execution of the Windows VM under qemu-traditional.  We still have not
gotten the VM to boot and run under upstream qemu.

Testing the upstream qemu version has resulted in the VM not wanting
to boot under anything at this point.  We are now getting a VIDEO_TDR
error out of Windows and are trying to untangle that.

> > In the case of the logs above, the following command sequence is being
> > executed upon termination of the domain:
> > 
> > # Unbind devices.
> > echo 0000:00:14.0 >| /sys/bus/pci/drivers/pciback/unbind
> > echo 0000:00:02.0 >| /sys/bus/pci/drivers/pciback/unbind
> > 
> > # Rebind devices.
> > echo 0000:00:14.0 >| /sys/bus/pci/drivers/xhci_hcd/bind
> > echo 0000:00:02.0 >| /sys/bus/pci/drivers/i915/bind

> ... you may still want to try replacing these with
> "xl pci-assignable-add ..." / "xl pci-assignable-remove ...".

We tested using the 'xl pci-assignable-add/remove' sequences and we
believe this may have resulted in the proper return of the devices to
dom0 but haven't been able to verify that since the Windows VM is now
throwing the VIDEO_TDR error.

Unless we are misunderstanding something the 'xl
pci-assignable-remove' sequence requires the manual re-binding of the
devices to their dom0 drivers.

This seems a bit odd given that the 'xl pci-assignable-add' invocation
on a device that does not have a driver gives an indication that no
driver was found and the device would not be re-bound to its driver.

This needs a bit more testing after we get the basic VM implementation
running once again.

> > Starting with the stock 4.11.4 release, the Dom0 re-attachment fails
> > with the 'xen_map_irq' failures being logged.
> > 
> >> Which brings me to this more general remark: What you describe sounds
> >> like a number of possibly independent problems. I'm afraid it'll be
> >> difficult for anyone to help without you drilling further down into
> >> what lower level operations are actually causing trouble. It also feels
> >> as if things may have ended up working for you on 4.10 just by
> >> chance.
> > 
> > I think the issue comes down to something that the hypervisor does, on
> > behalf of the domain doing the passthrough, as part of whatever
> > qemu-traditional needs to do in order to facilitate the attachment of
> > the PCI devices to the domain.
> > 
> > Running the detach/re-attach operation works perfectly in absence of
> > qemu-traditional being started in the domain.  The failure to
> > re-attach only occurs after qemu-traditional has been run in the
> > domain.

> Interesting. This suggests missing cleanup somewhere in the course
> of tearing down assignment to the DomU. Without full (and full
> verbosity) logs there's unlikely to be a way forward. Even the
> there's no promise that the logs would have useful data.

As soon as we the VM running again we will deploy a debug enabled
hypervisor.

> Of course with qemu-trad now being neither security supported nor
> recommended to use, you will want (need) to look into moving to
> upstream qemu anyway, trying to deal with problems there instead.

We have had virtually no luck whatsoever with upstream qemu at this
point, all the way from 4.10 forward to 4.15 at this point.

There are a host of PCI options in the XL configuration file that may
be impacting this but we have not yet to find any good references on
this.

> >> I'm sorry that I'm not really of any help here,
> > 
> > Actually your reflections have been helpful.
> > 
> > Perhaps the most important clarification that we could get, for posterity
> > in this thread, is whether or not IGD pass-through is actually
> > supported in the mind of the Xen team.
> > 
> > According to the Xen web-site, IGD PCI pass-through is documented as
> > working with the following combinations:
> > 
> > Xen 4.11.x: QEMU >= 3.1
> > 
> > Xen 4.14.x: QEMU >= 5.2
> > 
> > We are currently having IGD pass-through with qemu-dm (3.1/5.2) fail
> > completely in those combinations.

> I wonder on what basis these statements were added.

I don't know but you can find them at the following URL:

https://wiki.xenproject.org/wiki/Xen_VGA_Passthrough

Under the following heading.

'Status of VGA graphics passthru in Xen'

The section is quite prescriptive with respect to what is supposed to
work.

That document gave us the impression that we would be on solid ground
moving to more recent versions of the stack including upstream QEMU
but that currently has not been our experience.

Unfortunately we are now in a position where testing seems to have
resulted in a virtual machine that no longer works on the 4.10.x
stack.... :-(

> Jan

Have a good day.

Dr. Greg

As always,
Dr. G.W. Wettstein, Ph.D.   Enjellic Systems Development, LLC.
4206 N. 19th Ave.           Specializing in information infra-structure
Fargo, ND  58102            development.
PH: 701-281-1686            EMAIL: greg@enjellic.com
------------------------------------------------------------------------------
"On the other hand, the Linux philosophy is 'laugh in the face of
 danger'.  Oops.  Wrong one.  'Do it yourself'.  Thats it."
                                -- Linus Torvalds


From xen-devel-bounces@lists.xenproject.org Tue Feb 22 19:37:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 19:37:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277151.473590 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMaxw-0001la-2i; Tue, 22 Feb 2022 19:36:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277151.473590; Tue, 22 Feb 2022 19:36:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMaxv-0001lT-UG; Tue, 22 Feb 2022 19:36:51 +0000
Received: by outflank-mailman (input) for mailman id 277151;
 Tue, 22 Feb 2022 19:36:50 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nMaxu-0001lJ-Lh; Tue, 22 Feb 2022 19:36:50 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nMaxu-000443-Hy; Tue, 22 Feb 2022 19:36:50 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nMaxu-0003eM-21; Tue, 22 Feb 2022 19:36:50 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nMaxu-0004sk-1V; Tue, 22 Feb 2022 19:36:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=J9c070JdG9zGCNxKMxFPau7gJzT0lJOJmat0Pp/XV2s=; b=puVF2FS6JuKxuYTUlI0FU6abrS
	GcfVFFoSfgQEm/obaFsFOhuYILG3I4eviWg5MMzsHAvXsGha72Lvye73ln24LnnFnrMAPpC8ZUwGI
	s0ElG62b4R4V29jWhjSU2DhfIyDMqaUoc20/R5Mu4MKkdiG/o3sbxNrdSJhUZKl17SLo=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168193-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 168193: regressions - FAIL
X-Osstest-Failures:
    xen-unstable:build-i386:xen-build:fail:regression
    xen-unstable:test-armhf-armhf-libvirt-raw:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:debian-hvm-install:fail:heisenbug
    xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-i386-livepatch:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-migrupgrade:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-pair:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-qemut-rhel6hvm-amd:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-qemut-rhel6hvm-intel:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-qemuu-rhel6hvm-amd:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-qemuu-rhel6hvm-intel:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-xl:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-debianhvm-amd64:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-xl-shadow:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-xl-vhd:build-check(1):blocked:nonblocking
    xen-unstable:build-i386-libvirt:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-coresched-i386-xl:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-examine:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-examine-bios:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-examine-uefi:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-freebsd10-amd64:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-freebsd10-i386:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:guest-start.2:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=95d9ab46143685f169f636cfdd7997e2fc630e86
X-Osstest-Versions-That:
    xen=95d9ab46143685f169f636cfdd7997e2fc630e86
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 22 Feb 2022 19:36:50 +0000

flight 168193 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168193/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-i386                    6 xen-build                fail REGR. vs. 168189

Tests which are failing intermittently (not blocking):
 test-armhf-armhf-libvirt-raw 17 guest-start/debian.repeat fail in 168189 pass in 168193
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10     fail pass in 168189
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 12 debian-hvm-install fail pass in 168189
 test-armhf-armhf-xl-rtds     18 guest-start/debian.repeat  fail pass in 168189

Tests which did not succeed, but are not blocking:
 test-amd64-i386-livepatch     1 build-check(1)               blocked  n/a
 test-amd64-i386-migrupgrade   1 build-check(1)               blocked  n/a
 test-amd64-i386-pair          1 build-check(1)               blocked  n/a
 test-amd64-i386-qemut-rhel6hvm-amd  1 build-check(1)               blocked n/a
 test-amd64-i386-qemut-rhel6hvm-intel  1 build-check(1)             blocked n/a
 test-amd64-i386-qemuu-rhel6hvm-amd  1 build-check(1)               blocked n/a
 test-amd64-i386-qemuu-rhel6hvm-intel  1 build-check(1)             blocked n/a
 test-amd64-i386-xl            1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-pvshim     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-qemut-debianhvm-amd64  1 build-check(1)         blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64  1 build-check(1)         blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow  1 build-check(1)  blocked n/a
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-win7-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-ws16-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-shadow     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-vhd        1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-qemut-win7-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemut-ws16-amd64  1 build-check(1)              blocked n/a
 test-amd64-coresched-i386-xl  1 build-check(1)               blocked  n/a
 test-amd64-i386-examine       1 build-check(1)               blocked  n/a
 test-amd64-i386-examine-bios  1 build-check(1)               blocked  n/a
 test-amd64-i386-examine-uefi  1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-amd64  1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-i386  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail in 168189 blocked in 168193
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail in 168189 blocked in 168193
 test-armhf-armhf-xl-rtds     19 guest-start.2 fail in 168189 blocked in 168193
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail in 168189 blocked in 168193
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail in 168189 blocked in 168193
 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail in 168189 never pass
 test-amd64-i386-libvirt     15 migrate-support-check fail in 168189 never pass
 test-amd64-i386-xl-pvshim    14 guest-start          fail in 168189 never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail in 168189 never pass
 test-amd64-i386-libvirt-raw 14 migrate-support-check fail in 168189 never pass
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168189
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168189
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168189
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168189
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168189
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168189
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168189
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168189
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  95d9ab46143685f169f636cfdd7997e2fc630e86
baseline version:
 xen                  95d9ab46143685f169f636cfdd7997e2fc630e86

Last test of basis   168193  2022-02-22 11:23:02 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   fail    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           blocked 
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           blocked 
 test-amd64-coresched-i386-xl                                 blocked 
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           blocked 
 test-amd64-i386-qemuu-rhel6hvm-amd                           blocked 
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     blocked 
 test-amd64-i386-freebsd10-amd64                              blocked 
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          blocked 
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          blocked 
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 blocked 
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        fail    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         blocked 
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      blocked 
 test-amd64-i386-freebsd10-i386                               blocked 
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         blocked 
 test-amd64-i386-qemuu-rhel6hvm-intel                         blocked 
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    blocked 
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  blocked 
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         blocked 
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 blocked 
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    blocked 
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              blocked 
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    blocked 
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 blocked 
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Tue Feb 22 20:03:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 20:03:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277165.473603 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMbNO-000572-AF; Tue, 22 Feb 2022 20:03:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277165.473603; Tue, 22 Feb 2022 20:03:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMbNO-00056v-7H; Tue, 22 Feb 2022 20:03:10 +0000
Received: by outflank-mailman (input) for mailman id 277165;
 Tue, 22 Feb 2022 20:03:08 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=QjoF=TF=kernel.org=kuba@srs-se1.protection.inumbo.net>)
 id 1nMbNM-00056p-Kp
 for xen-devel@lists.xenproject.org; Tue, 22 Feb 2022 20:03:08 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org
 [2604:1380:4641:c500::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 720c71c7-941a-11ec-8eb8-a37418f5ba1a;
 Tue, 22 Feb 2022 21:03:06 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id D269D61667;
 Tue, 22 Feb 2022 20:03:03 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id E44D2C340E8;
 Tue, 22 Feb 2022 20:03:02 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 720c71c7-941a-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1645560183;
	bh=bARya+5AojzCiqimk+yisv0RgHtnw56CKKTarijTxmI=;
	h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
	b=Y/AhqouUMfcglgJ6gxXppwvkehVW7t0SWEsn6Kupq2EIQ9rTu4WOY9fum5gOylfr8
	 pG8K2RVIBnpbKnOBgEc67J5/4ghNPan17C4eNnpIdAYRM04B6SweKkmkJHpi83gRf+
	 3Exn0pPGoe4tcRVzkuYMpHRWsFz4uz8GGenF8ziOxCjDa/54lio8Yjl4f0BSeASGAT
	 yCAdjKdlMU7ebNthUBFt07J8+AEEyIRLeSNmn2fDMjOaKTV8b2udtC/e0L/GsxSksk
	 HFmovAgOFO5oJHu1WuHwLUc3opu+FbnXzCeqEWIR6c/rp8UnvMTixfpsbAnVdGbM2t
	 9U8zDZOC67y6w==
Date: Tue, 22 Feb 2022 12:03:01 -0800
From: Jakub Kicinski <kuba@kernel.org>
To: Juergen Gross <jgross@suse.com>, Marek =?UTF-8?B?TWFyY3p5a293c2tpLUc=?=
 =?UTF-8?B?w7NyZWNraQ==?= <marmarek@invisiblethingslab.com>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Boris Ostrovsky
 <boris.ostrovsky@oracle.com>, Stefano Stabellini <sstabellini@kernel.org>,
 "David S. Miller" <davem@davemloft.net>, Antoine Tenart
 <atenart@kernel.org>, "moderated list:XEN HYPERVISOR INTERFACE"
 <xen-devel@lists.xenproject.org>, "open list:NETWORKING DRIVERS"
 <netdev@vger.kernel.org>
Subject: Re: [PATCH] xen/netfront: destroy queues before real_num_tx_queues
 is zeroed
Message-ID: <20220222120301.10af2737@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <3786b4ef-68e7-5735-0841-fcbae07f7e54@suse.com>
References: <20220220134202.2187485-1-marmarek@invisiblethingslab.com>
	<3786b4ef-68e7-5735-0841-fcbae07f7e54@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Mon, 21 Feb 2022 07:27:32 +0100 Juergen Gross wrote:
> On 20.02.22 14:42, Marek Marczykowski-G=C3=B3recki wrote:
> > xennet_destroy_queues() relies on info->netdev->real_num_tx_queues to
> > delete queues. Since d7dac083414eb5bb99a6d2ed53dc2c1b405224e5
> > ("net-sysfs: update the queue counts in the unregistration path"),
> > unregister_netdev() indirectly sets real_num_tx_queues to 0. Those two
> > facts together means, that xennet_destroy_queues() called from
> > xennet_remove() cannot do its job, because it's called after
> > unregister_netdev(). This results in kfree-ing queues that are still
> > linked in napi, which ultimately crashes:
> >=20
> >      BUG: kernel NULL pointer dereference, address: 0000000000000000
> >      #PF: supervisor read access in kernel mode
> >      #PF: error_code(0x0000) - not-present page
> >      PGD 0 P4D 0
> >      Oops: 0000 [#1] PREEMPT SMP PTI
> >      CPU: 1 PID: 52 Comm: xenwatch Tainted: G        W         5.16.10-=
1.32.fc32.qubes.x86_64+ #226
> >      RIP: 0010:free_netdev+0xa3/0x1a0
> >      Code: ff 48 89 df e8 2e e9 00 00 48 8b 43 50 48 8b 08 48 8d b8 a0 =
fe ff ff 48 8d a9 a0 fe ff ff 49 39 c4 75 26 eb 47 e8 ed c1 66 ff <48> 8b 8=
5 60 01 00 00 48 8d 95 60 01 00 00 48 89 ef 48 2d 60 01 00
> >      RSP: 0000:ffffc90000bcfd00 EFLAGS: 00010286
> >      RAX: 0000000000000000 RBX: ffff88800edad000 RCX: 0000000000000000
> >      RDX: 0000000000000001 RSI: ffffc90000bcfc30 RDI: 00000000ffffffff
> >      RBP: fffffffffffffea0 R08: 0000000000000000 R09: 0000000000000000
> >      R10: 0000000000000000 R11: 0000000000000001 R12: ffff88800edad050
> >      R13: ffff8880065f8f88 R14: 0000000000000000 R15: ffff8880066c6680
> >      FS:  0000000000000000(0000) GS:ffff8880f3300000(0000) knlGS:000000=
0000000000
> >      CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> >      CR2: 0000000000000000 CR3: 00000000e998c006 CR4: 00000000003706e0
> >      Call Trace:
> >       <TASK>
> >       xennet_remove+0x13d/0x300 [xen_netfront]
> >       xenbus_dev_remove+0x6d/0xf0
> >       __device_release_driver+0x17a/0x240
> >       device_release_driver+0x24/0x30
> >       bus_remove_device+0xd8/0x140
> >       device_del+0x18b/0x410
> >       ? _raw_spin_unlock+0x16/0x30
> >       ? klist_iter_exit+0x14/0x20
> >       ? xenbus_dev_request_and_reply+0x80/0x80
> >       device_unregister+0x13/0x60
> >       xenbus_dev_changed+0x18e/0x1f0
> >       xenwatch_thread+0xc0/0x1a0
> >       ? do_wait_intr_irq+0xa0/0xa0
> >       kthread+0x16b/0x190
> >       ? set_kthread_struct+0x40/0x40
> >       ret_from_fork+0x22/0x30
> >       </TASK>
> >=20
> > Fix this by calling xennet_destroy_queues() from xennet_close() too,
> > when real_num_tx_queues is still available. This ensures that queues are
> > destroyed when real_num_tx_queues is set to 0, regardless of how
> > unregister_netdev() was called.
> >=20
> > Originally reported at
> > https://github.com/QubesOS/qubes-issues/issues/7257
> >=20
> > Fixes: d7dac083414eb5bb9 ("net-sysfs: update the queue counts in the un=
registration path")
> > Cc: stable@vger.kernel.org # 5.16+
> > Signed-off-by: Marek Marczykowski-G=C3=B3recki <marmarek@invisiblething=
slab.com>
> >=20
> > ---
> > While this fixes the issue, I'm not sure if that is the correct thing
> > to do. xennet_remove() calls xennet_destroy_queues() under rtnl_lock,
> > which may be important here? Just moving xennet_destroy_queues() before=
 =20
>=20
> I checked some of the call paths leading to xennet_close(), and all of
> those contained an ASSERT_RTNL(), so it seems the rtnl_lock is already
> taken here. Could you test with adding an ASSERT_RTNL() in
> xennet_destroy_queues()?
>=20
> > unregister_netdev() in xennet_remove() did not helped - it crashed in
> > another way (use-after-free in xennet_close()). =20
>=20
> Yes, this would need to basically do the xennet_close() handling in
> xennet_destroy() instead, which I believe is not really an option.

I think the patch makes open/close asymmetric, tho. After ifup ; ifdown;
the next ifup will fail because queues are already destroyed, no?
IOW xennet_open() expects the queues were created at an earlier stage.

Maybe we can move the destroy to ndo_uninit? (and create to ndo_init?)


From xen-devel-bounces@lists.xenproject.org Tue Feb 22 21:40:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 22 Feb 2022 21:40:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277172.473615 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMctM-0006K4-Ba; Tue, 22 Feb 2022 21:40:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277172.473615; Tue, 22 Feb 2022 21:40:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMctM-0006Jx-8j; Tue, 22 Feb 2022 21:40:16 +0000
Received: by outflank-mailman (input) for mailman id 277172;
 Tue, 22 Feb 2022 21:40:14 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nMctK-0006Jn-N9; Tue, 22 Feb 2022 21:40:14 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nMctK-0006I1-JQ; Tue, 22 Feb 2022 21:40:14 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nMctK-0001Ca-3z; Tue, 22 Feb 2022 21:40:14 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nMctK-0005Xy-0F; Tue, 22 Feb 2022 21:40:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=U3o5Niw7jMR9fheq5gAQcqtWBc5l5JxangZdxqb2Evs=; b=DXjvEJNtwlKVEPm9Pgjsj/h/c8
	IQ1TbzPi3X2Y45nruL8+5CPkjYsbwdzwOUXqN7uHKD3uVHDXh6muV58BSdQ+LGIAS6Js8iz1r9jJv
	PM2qNg7NDvmVZIjW7btlhM5W4anpbWtFYV8/8Paw6hL1zUAU4HAGKProx4JGuISbgNak=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168194-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 168194: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=922268067fe4181d6edcfccd689e908e4d1243ad
X-Osstest-Versions-That:
    qemuu=477c3b934a47adf7de285863f59d6e4503dd1a6d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 22 Feb 2022 21:40:14 +0000

flight 168194 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168194/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168186
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168186
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168186
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168186
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168186
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168186
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168186
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168186
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                922268067fe4181d6edcfccd689e908e4d1243ad
baseline version:
 qemuu                477c3b934a47adf7de285863f59d6e4503dd1a6d

Last test of basis   168186  2022-02-21 17:36:59 Z    1 days
Testing same since   168194  2022-02-22 13:38:11 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Gareth Webb <gareth.webb@umbralsoftware.co.uk>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Peter Maydell <peter.maydell@linaro.org>
  Peter Xu <peterx@redhat.com>
  Thomas Huth <thuth@redhat.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   477c3b934a..922268067f  922268067fe4181d6edcfccd689e908e4d1243ad -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Wed Feb 23 03:37:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 23 Feb 2022 03:37:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277185.473626 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMiTB-0007a9-Tx; Wed, 23 Feb 2022 03:37:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277185.473626; Wed, 23 Feb 2022 03:37:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMiTB-0007Zh-MJ; Wed, 23 Feb 2022 03:37:37 +0000
Received: by outflank-mailman (input) for mailman id 277185;
 Wed, 23 Feb 2022 03:37:35 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nMiT9-0007ZX-Qb; Wed, 23 Feb 2022 03:37:35 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nMiT9-0006fk-NG; Wed, 23 Feb 2022 03:37:35 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nMiT9-0003Ab-B2; Wed, 23 Feb 2022 03:37:35 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nMiT9-0001F9-9q; Wed, 23 Feb 2022 03:37:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=a0RYkCgUSaMqTjEPWeATq0TgbKp34Y/jx9502V3BU/Q=; b=6sa9ABIYgTxM+yKrrHqO1X4WEZ
	cuZulJCsHWMCLXqVxjcXXtDS2FiOEwDGrcFlGYNc30ElUgF3PmaUwXS/usmQOQFyjoRaVmfLwH0rm
	X+VwafTClKxfit4lcADFQN3B9hRbJXmtmzEzNrewXMQIpEDmJDu6u/pU8j2gyPeSftQ8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168196-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 168196: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:guest-localmigrate/x10:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=917bbdb107f8767cb78f24e7d6725a2f93b9effe
X-Osstest-Versions-That:
    linux=038101e6b2cd5c55f888f85db42ea2ad3aecb4b6
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 23 Feb 2022 03:37:35 +0000

flight 168196 linux-linus real [real]
flight 168200 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/168196/
http://logs.test-lab.xenproject.org/osstest/logs/168200/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 18 guest-localmigrate/x10 fail pass in 168200-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168187
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168187
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168187
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168187
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168187
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168187
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168187
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168187
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                917bbdb107f8767cb78f24e7d6725a2f93b9effe
baseline version:
 linux                038101e6b2cd5c55f888f85db42ea2ad3aecb4b6

Last test of basis   168187  2022-02-21 17:39:52 Z    1 days
Testing same since   168196  2022-02-22 18:39:54 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Al Viro <viro@zeniv.linux.org.uk>
  Linus Torvalds <torvalds@linux-foundation.org>
  Max Kellermann <max.kellermann@ionos.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        fail    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   038101e6b2cd..917bbdb107f8  917bbdb107f8767cb78f24e7d6725a2f93b9effe -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Wed Feb 23 05:58:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 23 Feb 2022 05:58:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277200.473640 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMkeo-0004N1-Ik; Wed, 23 Feb 2022 05:57:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277200.473640; Wed, 23 Feb 2022 05:57:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMkeo-0004Mu-FO; Wed, 23 Feb 2022 05:57:46 +0000
Received: by outflank-mailman (input) for mailman id 277200;
 Wed, 23 Feb 2022 05:57:44 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nMkem-0004Mk-RQ; Wed, 23 Feb 2022 05:57:44 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nMkem-0001Dv-P2; Wed, 23 Feb 2022 05:57:44 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nMkem-0001ah-9O; Wed, 23 Feb 2022 05:57:44 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nMkem-0004kK-8u; Wed, 23 Feb 2022 05:57:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=C4Mn4JBRXRBlRsWOgD9scJFJrnTWYV5SMdaLRX6lii8=; b=E5ExyC9YUstuixSgxQHR9xY/Ba
	F5eyHkqRR0//JH5Zcqnh9CcmU+GSZFAN5Vj4FYPgRm/f8AHIh6a0Sm7oxMJT46cdgo8B/6zEgCc/K
	iR2SM01V/AKgNOCYtB4BTgAQhvgeWWJ7izBAKZORTLJIvo4myG1dEOyZfZ2yH7sVFF8E=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168198-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 168198: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=210f27e55abd2a57c01105992bc10bc4d7b8132d
X-Osstest-Versions-That:
    xen=95d9ab46143685f169f636cfdd7997e2fc630e86
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 23 Feb 2022 05:57:44 +0000

flight 168198 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168198/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168189
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168189
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168189
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168189
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10       fail  like 168193
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168193
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168193
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168193
 test-armhf-armhf-xl-rtds     18 guest-start/debian.repeat    fail  like 168193
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168193
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168193
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168193
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168193
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168193
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  210f27e55abd2a57c01105992bc10bc4d7b8132d
baseline version:
 xen                  95d9ab46143685f169f636cfdd7997e2fc630e86

Last test of basis   168193  2022-02-22 11:23:02 Z    0 days
Testing same since   168198  2022-02-22 20:09:28 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Roger Pau Monne <roger.pau@citrix.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   95d9ab4614..210f27e55a  210f27e55abd2a57c01105992bc10bc4d7b8132d -> master


From xen-devel-bounces@lists.xenproject.org Wed Feb 23 09:00:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 23 Feb 2022 09:00:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277219.473652 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMnV6-0004Zh-Rk; Wed, 23 Feb 2022 08:59:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277219.473652; Wed, 23 Feb 2022 08:59:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMnV6-0004Za-Od; Wed, 23 Feb 2022 08:59:56 +0000
Received: by outflank-mailman (input) for mailman id 277219;
 Wed, 23 Feb 2022 08:59:56 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=DZ7u=TG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nMnV6-0004ZU-14
 for xen-devel@lists.xen.org; Wed, 23 Feb 2022 08:59:56 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f7f6e217-9486-11ec-8539-5f4723681683;
 Wed, 23 Feb 2022 09:59:55 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2051.outbound.protection.outlook.com [104.47.14.51]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-5-ZxRWhlfoPyCCctOMqGaDrA-1; Wed, 23 Feb 2022 09:59:53 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM5PR0401MB2578.eurprd04.prod.outlook.com (2603:10a6:203:3b::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.24; Wed, 23 Feb
 2022 08:59:51 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.022; Wed, 23 Feb 2022
 08:59:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f7f6e217-9486-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645606794;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=wHR1n0jidhM72oXQtgLnkz3IrAumUW4H9ri90d8hkj0=;
	b=H0G648wq3JDdZT4jxKG2Eqx6SBXnMwwS4FdHBWNf8B5zDtkQVfeClXoIY8FEZ7jrI7lvqe
	LARPQYQlRh9QGerJhqnkvdKaB5HWosflhbY1ltB7WBd23L0a7ZSHWzIMHUUra2I9INlsqt
	rvoikHu2i55abYzb6srepLECKZ6U/iw=
X-MC-Unique: ZxRWhlfoPyCCctOMqGaDrA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ldIFZPXhEwGlMWKlef/qzERM8o+SG3qLvPd4whIe2RBnhVgxR7z3/nb5T1vdZ2hXYytvtHZFX9R6gbUXce0TzQjSVEKtpC579TqXNBQYuNpfT1hveIHyUqwHD/Z/yXo5/DZrDAeuAOVV4dlbQxM4JAQV2CgPLMtaraJCETDsR6Fh8+W21gZDdhfgYPzIo8UYOVgIt1ZKyFKcYurJ/74yBph37dAGK+tWeW1f69ZJsq8CvfDy0HqCOsdxyetVZOA+szi8f/vkECg3Pa0GdXbyBgcJVXjYzesC/epwkyoh9RCmfmy4zOfZXhJX7Hix6es+p78AmBlllz/nvJ2xwgJmww==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=wHR1n0jidhM72oXQtgLnkz3IrAumUW4H9ri90d8hkj0=;
 b=GTclnySA9Nj38vTTDDotgnCclHPt9kZdHYolIqrd20tHX8j9b8eOO8emAqAMXdxjAMyvaFQa+bgxPe3KmgsodU2mCq6ibFH4Jnh9mQ8/fy7MRlrOKFWaUGP0PAZDU44cjJAPj1TDKAQqVp8v3AMrUzpr2dQbywhBwUiRsomyoAGPX0xZFR0pvFavkIe/G22jGdnqfZKceX+RIw7R5I58iKSzbfHFOKhbApDJZFJdUnVZQIGQeuwD1xMLjh0c3tpQYuJV+rmgh/UyrhEOHUpdUyjqaF0zNTjJo4m9/hULOQJ7u8koMKaY/nuUT/0cbfKJm7VHfrWbgaEALLk7VilcRQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <b9a77707-5d93-050a-f9ee-da284dbd0eac@suse.com>
Date: Wed, 23 Feb 2022 09:59:48 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: IGD pass-through failures since 4.10.
Content-Language: en-US
To: "Dr. Greg" <greg@enjellic.com>
Cc: xen-devel@lists.xen.org
References: <20220214060011.GA24404@wind.enjellic.com>
 <198ef291-4dee-ddac-aef6-8451bc1e880c@suse.com>
 <20220217201534.GA29303@wind.enjellic.com>
 <dc1a4483-7dca-aa72-6b86-4217e6840efb@suse.com>
 <20220222185230.GA15532@wind.enjellic.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220222185230.GA15532@wind.enjellic.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR07CA0037.eurprd07.prod.outlook.com
 (2603:10a6:20b:459::9) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ffa592c0-a270-4d5b-7702-08d9f6aad9b1
X-MS-TrafficTypeDiagnostic: AM5PR0401MB2578:EE_
X-Microsoft-Antispam-PRVS:
	<AM5PR0401MB257895DDD8AE5AA489E7DD6FB33C9@AM5PR0401MB2578.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ZzinOooHTJbDp9qdV5VKPB21tqygmDkNtz+bJSMg6qS+Z14TFedRJvtL2fnPPeSOpjlNRY2dmCnL9luVg7YmRTZjhveSWbey41RkUvy3TcVhs1ilMPYUzNZNJFsYyB688Hk27YtwhOpGt4ZFVTBDNo/csn5fPA6drem7f/1W05wfuMafQw94FZAbhJokZN1LyCH7FweDdVYKvPYRh05j+pfUuzgLgr9wOmOzEaU2O7IexqXBAZONsFPKXG1wlKtw0WvbwjhukHBBOFvgT5p+rT89TjRWjzRvg3RTXFZTtUz4pcvzy9HXlbWpWOyxntPvWRp+/FF8MIYNbo6XAnVK3b0ipXbeXLYXKAl7xYdS0G2Q5pBL7Kce9kP6ShHowK8UOTnHiZDJs3pnsvM4IdwoYVXsJnd6Gv8zh34Yw8lrTantc2SiNhDrR+ADfk/PFXFAzteForIRiDxSgvl94gHajXhcz0r/lbHniwLl3bUWnwOnWEHKvH7eTWjfqlExFp2K8mLjVyK3Uxm4Hq2Fo9XMhR2SiEtHbhjB2YHyZPO/Gk9XrXo48FDfBuHxOI6TwBDbsb5N9M3KDMR+jpMMmp+DXP/teZnWk07f9xqivoo7MTLDJNPdJkIuIyo7DkUZanemj8akrmVY/g48yoHOcF0aHI4b8zAKiISCnUaVQ5VnSHQnfd8Jhx0uTZoXaQ8ZgTBXlOv1pdaXooZSO/K/kLxcgfvebjdLK/OA4V2oKPOLGQXba7eu9ZlqBebVkMEuYkEB
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(53546011)(6506007)(508600001)(6916009)(31696002)(6486002)(6512007)(83380400001)(86362001)(316002)(2616005)(38100700002)(5660300002)(4326008)(66476007)(8676002)(2906002)(36756003)(66556008)(8936002)(31686004)(186003)(66946007)(26005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?WUN1ME1SMDRCaUlWTlVJNFhnZ1dnWTJ2K09BQWF4UUIwWXdCLytNOGJvdkg4?=
 =?utf-8?B?VTNLUUx4NDEwczVpdWlEdWdqWmd1QTlrSFV0KzMwZEVVYXkwQVZ2VHFiVHpK?=
 =?utf-8?B?aWx2cjZIYUFTRlJjRmE5OGdxTTFoTWhXMDN3R2NETGQzbGhnODgwd09icmh1?=
 =?utf-8?B?d3FUWWdLQWYvYVV4MUhyQmhVQUFtcmoxTkwzTHVKQjlCYnE1T3A0SjdZbk5p?=
 =?utf-8?B?NTFtUVpQTmFqYmZoU2YvZTdTRFdPdkw3WnZZN1Z4dVRBUWljZzBTSWtQN09p?=
 =?utf-8?B?WUxxbk53THd4N0ZCTnN3OFNXZWI2ZTZQK1ZxSFVrZUlIQXA4NzVkMUoyVG40?=
 =?utf-8?B?SjhVYWJ4czVQSkJwWDI4MDBBVmVMcmRBTGxrcmdOcGl3T0p6U0owMC9VWkxr?=
 =?utf-8?B?T3VzN1ZMNmJTelVzZ0x2UnppTSt2Z2dmOWVGaXdkakV0bHRxeEQrWUdTZmNw?=
 =?utf-8?B?L3FZQ0lDVXlCdnVSb1R3eDBFa2tqWjFXSEtHN1V0aDI4dGVNNDh6bGUwYkJ5?=
 =?utf-8?B?eE5vRSt5bFArMTVMeGV4N1RwNjlzR1Nwenp4Sm8rK2dPTDB3d0szOVRNQWFv?=
 =?utf-8?B?ZGRJbFB3SE5ncnJld0tIZjZkaStVY0NhN09JeWRDNmZJMmpKM0dlUFNTRmYy?=
 =?utf-8?B?cW9qdFJOMjE0RUZkRTk0M3Z3aTREaFV1VE4rUTg2M1FQdXh3T2xwTHpQWTJH?=
 =?utf-8?B?TW40M1FmL2M4ZHJpbUc3K25oYnVxdXBneEhZTnk0d1dCdklWamdHZVJOdjZy?=
 =?utf-8?B?WHlxVG9Wbm9SSXB2WklsczcxR1YxUG5wYzlBNnJUbWgreEw2cFhzWnZsNUlk?=
 =?utf-8?B?Lzlab2dBMWE2bXNMSHF2aDNiYUNiRjFleStiR3JvbFNFZFcyR2JiTEdjNGR2?=
 =?utf-8?B?amU0UzUyVDRmR1lGRE5GbHdtZVVjUHdNS2FjaHBPS3hTejd0TmlVeEhITS9a?=
 =?utf-8?B?V3NnY0VXUVprQWZ4RUwrUFZJNkpxQWZoTjl0RlhsTVRtN3Y4UEVSMU12bSsw?=
 =?utf-8?B?OEc3UG9Va2dVZUh3M2hnZHRWSndtSExkZ2VqWjI4dzI4MkkyTzZ5VmNDTmhV?=
 =?utf-8?B?K2haUHN2MHVUYWQvWmxmQi92WjdBQnhDdWVJUlBRbXYzNUx1UlFLaXdqS1lI?=
 =?utf-8?B?QkN2OVVsNEQ3UlZGVnE1ZzhDbDVlSWtQUjhIVlp0bFJ2cmRZN243cXE2N1Rt?=
 =?utf-8?B?TjRpK3JybS8wS3lwMlE4Nnk3aE02bHFkeE9Ib0wxRlUyWE05eVdFTzFVeHZB?=
 =?utf-8?B?b2JITEFVc1JSYTZLWERndEIxVkxaSSthU2lXazlrb3ltR1prWlVNdnBpZmVo?=
 =?utf-8?B?dmRwN1E2dHN0U3IwOXdLVnpMdlVidmdncDUyelo2U3cxL1JvcGlHUkVodytV?=
 =?utf-8?B?NGhvVW1OMUxpeDBmSEUxdmxBQWFtZDJtYTJZOUIxM1JkRWR2RzFYcWVMVGMw?=
 =?utf-8?B?K1dEdmhmYk4zYVlrOUlSMDBsaXdJcUtsVzZSM3RNMU5kZ3FBZFNQbDFNN1JU?=
 =?utf-8?B?VHpudWczaEtRMjhuRXM0YkZQcXNzUUFtT0ZwemozbHhNSVVxZ3VuVTFOdHJx?=
 =?utf-8?B?T3ZnVG85a2xMS2JFdWFZSjBWcWh5NXlNREMzc3V5OVJsUEJOVDB5b3VFTTJE?=
 =?utf-8?B?ZXJMeGlQWnlUUk9tcGNNQVQyL3hUSFFYMzJ3ZHhkQTl3UDJSb1g0VkVVUWEv?=
 =?utf-8?B?NGN1Y1h0TmdneFE5cVZjNVRGQXJpeFh4eWdtQTBySEFzMHA5d3d5cWkrK25w?=
 =?utf-8?B?eUsyaE91NGQ5QWwzR0xGaWpaZ2dxVkZDSWI4eGhlN0pjSG9FMW1GL05RWnhD?=
 =?utf-8?B?SElzMUJ1WnFnNW45eEh6UEovcDV5akpkdkZQblB0SGVTc2RYQUJJQSsxci9Y?=
 =?utf-8?B?ODdqcXpXcDk3WjhTdDJLSEI1YVc4UzYzemdMNlVUWHhpbUxDRzB1TWRuc2hy?=
 =?utf-8?B?eE9UbXVLN0s0aStHYWRRNm1sd2FnN0FIdy9sNnVlZ1c0bGZOSThEemF1STMw?=
 =?utf-8?B?SlN6WjhDQnloVGNYUjRYYXpZeVMyYUZlSnFvVC83YVlPNkx1Y0E0Wno1dG9v?=
 =?utf-8?B?am9jem9mTXMyMGdpckNqM0Npek9ZbU8zM2U4aWpNTGNXclVTYVNwNG1HOTdU?=
 =?utf-8?B?NDRzb21COXEzRDJ6Smt0SFZJZGNvTkRNUDRkNG1JSGMxdHc3MlFSekV1aHZL?=
 =?utf-8?Q?TPBCo+jQo7LUXv0YnCfZAm0=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ffa592c0-a270-4d5b-7702-08d9f6aad9b1
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2022 08:59:50.8670
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EcLusdkafBhtyFIG5DOZRnMgMwj01GbGNWXfmDb25kQi7xW9fEiQNmrjHmMr7H7oPVhjv0gbmYcaGox73Vv4Pw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0401MB2578

On 22.02.2022 19:52, Dr. Greg wrote:
> On Fri, Feb 18, 2022 at 08:04:14AM +0100, Jan Beulich wrote:
>> On 17.02.2022 21:15, Dr. Greg wrote:
>>> On Mon, Feb 14, 2022 at 09:56:34AM +0100, Jan Beulich wrote:
>>> In the case of the logs above, the following command sequence is being
>>> executed upon termination of the domain:
>>>
>>> # Unbind devices.
>>> echo 0000:00:14.0 >| /sys/bus/pci/drivers/pciback/unbind
>>> echo 0000:00:02.0 >| /sys/bus/pci/drivers/pciback/unbind
>>>
>>> # Rebind devices.
>>> echo 0000:00:14.0 >| /sys/bus/pci/drivers/xhci_hcd/bind
>>> echo 0000:00:02.0 >| /sys/bus/pci/drivers/i915/bind
> 
>> ... you may still want to try replacing these with
>> "xl pci-assignable-add ..." / "xl pci-assignable-remove ...".
> 
> We tested using the 'xl pci-assignable-add/remove' sequences and we
> believe this may have resulted in the proper return of the devices to
> dom0 but haven't been able to verify that since the Windows VM is now
> throwing the VIDEO_TDR error.
> 
> Unless we are misunderstanding something the 'xl
> pci-assignable-remove' sequence requires the manual re-binding of the
> devices to their dom0 drivers.

Hmm, I thought drivers would be rebound, but I'm not a tool stack person.
Looking at libxl__device_pci_assignable_remove() at least support this
assumption of mine. You did use the command's -r option, didn't you?

Jan



From xen-devel-bounces@lists.xenproject.org Wed Feb 23 09:15:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 23 Feb 2022 09:15:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277231.473663 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMnjp-0006xr-Cn; Wed, 23 Feb 2022 09:15:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277231.473663; Wed, 23 Feb 2022 09:15:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMnjp-0006xk-9f; Wed, 23 Feb 2022 09:15:09 +0000
Received: by outflank-mailman (input) for mailman id 277231;
 Wed, 23 Feb 2022 09:15:08 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nMnjo-0006xa-GD; Wed, 23 Feb 2022 09:15:08 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nMnjo-0005Df-BL; Wed, 23 Feb 2022 09:15:08 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nMnjo-00022t-04; Wed, 23 Feb 2022 09:15:08 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nMnjn-000714-Vn; Wed, 23 Feb 2022 09:15:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=OBlhk30W7N7/lv0srtJ93wcJwhWFQviCg7FmBUziquo=; b=vviD8WYMhQCLCRPyCfjYa4882W
	adTWGo1z/DuVRqaLlfzgUgXPFllYMjg9BXhJ3fytWqk85igi8H8hYkCYR/ZZTADKc2fbWOHeRa90Y
	ZTdfT1K928dGkeyPMXmUuL2Y1SjFOTwR1ds2re3ntxGDzLYnpuNOnnF8n8wH6dW7RGTs=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168199-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 168199: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=5abccc7922ca5291327b0a1e84ace526d97c633b
X-Osstest-Versions-That:
    qemuu=922268067fe4181d6edcfccd689e908e4d1243ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 23 Feb 2022 09:15:07 +0000

flight 168199 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168199/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168194
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168194
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168194
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168194
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168194
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168194
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168194
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168194
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                5abccc7922ca5291327b0a1e84ace526d97c633b
baseline version:
 qemuu                922268067fe4181d6edcfccd689e908e4d1243ad

Last test of basis   168194  2022-02-22 13:38:11 Z    0 days
Testing same since   168199  2022-02-22 22:07:11 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Dr. David Alan Gilbert <dgilbert@redhat.com>
  Eric Auger <eric.auger@redhat.com>
  Laurent Vivier <lvivier@redhat.com>
  Michael S. Tsirkin <mst@redhat.com>
  Peter Maydell <peter.maydell@linaro.org>
  Philippe Mathieu-Daudé <f4bug@amsat.org>
  Thomas Huth <thuth@redhat.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   922268067f..5abccc7922  5abccc7922ca5291327b0a1e84ace526d97c633b -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Wed Feb 23 09:51:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 23 Feb 2022 09:51:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277242.473673 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMoJ5-0002ZF-AE; Wed, 23 Feb 2022 09:51:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277242.473673; Wed, 23 Feb 2022 09:51:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMoJ5-0002Z8-6s; Wed, 23 Feb 2022 09:51:35 +0000
Received: by outflank-mailman (input) for mailman id 277242;
 Wed, 23 Feb 2022 09:51:34 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nMoJ4-0002Yy-2h; Wed, 23 Feb 2022 09:51:34 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nMoJ3-0005tg-Un; Wed, 23 Feb 2022 09:51:33 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nMoJ3-00049A-IC; Wed, 23 Feb 2022 09:51:33 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nMoJ3-00016s-Hk; Wed, 23 Feb 2022 09:51:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=zPgU9Cx1SQLn4pAQQad4QrbkaTz832YXzo57BdmOVRE=; b=X8fwaRYJPURT6V4dgCY7KuN7Tr
	BliqcNNfGlg3ryljfKUBBoBxmZ4RrnrEdowT5GL0Jf7Cu55m4j9Dj0AN5L0srzz46pzcjqNA8JhyT
	IYQM546MeHzgRRfUZqDHXhLXsZde/0o4SA/hLG7wWCmia4GDvVf6Mw10MIzLynhDFfGo=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168204-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-coverity test] 168204: all pass - PUSHED
X-Osstest-Versions-This:
    xen=210f27e55abd2a57c01105992bc10bc4d7b8132d
X-Osstest-Versions-That:
    xen=686f13cfce1d95464ff39fb59ac1f85163cea03b
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 23 Feb 2022 09:51:33 +0000

flight 168204 xen-unstable-coverity real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168204/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 xen                  210f27e55abd2a57c01105992bc10bc4d7b8132d
baseline version:
 xen                  686f13cfce1d95464ff39fb59ac1f85163cea03b

Last test of basis   168177  2022-02-20 09:19:40 Z    3 days
Testing same since   168204  2022-02-23 09:20:59 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Roger Pau Monne <roger.pau@citrix.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 coverity-amd64                                               pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   686f13cfce..210f27e55a  210f27e55abd2a57c01105992bc10bc4d7b8132d -> coverity-tested/smoke


From xen-devel-bounces@lists.xenproject.org Wed Feb 23 10:11:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 23 Feb 2022 10:11:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277253.473685 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMoc6-0004zJ-2H; Wed, 23 Feb 2022 10:11:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277253.473685; Wed, 23 Feb 2022 10:11:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMoc5-0004zC-V5; Wed, 23 Feb 2022 10:11:13 +0000
Received: by outflank-mailman (input) for mailman id 277253;
 Wed, 23 Feb 2022 10:11:12 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=DZ7u=TG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nMoc4-0004z6-7i
 for xen-devel@lists.xenproject.org; Wed, 23 Feb 2022 10:11:12 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ebdc2305-9490-11ec-8eb8-a37418f5ba1a;
 Wed, 23 Feb 2022 11:11:11 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2058.outbound.protection.outlook.com [104.47.14.58]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-26--3-GMgKSP-Obv7AdpR7oKw-1; Wed, 23 Feb 2022 11:11:07 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM6PR0402MB3944.eurprd04.prod.outlook.com (2603:10a6:209:1c::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.21; Wed, 23 Feb
 2022 10:11:06 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.022; Wed, 23 Feb 2022
 10:11:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ebdc2305-9490-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645611069;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=oZXHA9bbcKY5LHV6iVNy+eglUHCbFFEz4iwrktrCMPg=;
	b=SbxPgE64H9Sb+vIRTMtimWUMYwEBAnhfYezJAonzDUpORrnafX+hMNPkRvnm5l4CBqR2+D
	3qMBmp9FsQ+HpU6gMHXgP0o40Y6vrbDDuEU32RB+IlUpfy/C9YJ8nxE4KNqhRfl945urWu
	e9is90PGVBU93K5hdX+PLfOSwDQYU5o=
X-MC-Unique: -3-GMgKSP-Obv7AdpR7oKw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=DFIm1JKiH05MNyhofzaF16rxJYic5gA0DegUIdcDraWxo02/yAL1/lLglD2S8ZfBjB8/dT+1WdoptV9hjEhLUZbH2kdAYdzdGyH1CJAETl982rqkfgjwuejDyPBje/6l6thAsyw/PfznrA+y6HZQMFaZvYtzwRVeSuxKTqCT4b8g3WzcXPlgw2RXyhO0z9UmbHooYzZ3VdTw0mZ0Mh9jk/qu+3x1KzcKlczFiZ+6s+DgkpAW4pzy3DeaObRniNOW3rQy9334PaHAwR3CIB/newhfvFGsOd5wWfwTjfxU2AiIY44K3o/Gefgp1eNUe36j1eCeIbgDk4c5ZXBBMV8F5Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=oZXHA9bbcKY5LHV6iVNy+eglUHCbFFEz4iwrktrCMPg=;
 b=az8nWDxS8pcUJz12aXumtgwLlOGpdre1lDA2oXzCDOphbYiWj/NWU3rQAD5W3o5EPnoaVvf/JNp+/DEM+nVFMmbBWW/HngcSL+eIAyFFyYrKWXwfmko8VhFmUcx/RyPhwDoVm/sN/kXUiCQsnjafgDDislVhNe2Da2Np+ZwiEoWzbNXHDQP0s/3ljMny1dF8r58eAr8anays3TZJR7f38eJKh22oo8FfS+yr6aWgjjm1PszqgJYU8kx4kbR/8lTs5x1Af6pDYrDhcdfVeuQyN5jib6Z+w/8MLsHsl+4tjdDOWPt74ixP93hlpOaAeEvG7+i2t7EJLpQYp8wYLGhkYg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <91935ffd-a270-f1a1-28f1-645fa4167fcd@suse.com>
Date: Wed, 23 Feb 2022 11:11:03 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Content-Language: en-US
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH 0/3] x86: correct fencing around CLFLUSH (+some tidying)
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P193CA0113.EURP193.PROD.OUTLOOK.COM
 (2603:10a6:209:85::18) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 8728d829-765c-4ad5-f3b3-08d9f6b4cdbe
X-MS-TrafficTypeDiagnostic: AM6PR0402MB3944:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR0402MB3944E0EE8ED110A35FE07819B33C9@AM6PR0402MB3944.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	tvh/c+Mn/WAmGOUvlDi1jeFHmYkImzp8q0xJa+aTZEblVkYmMj9fFBu9sjgBdiRS0kbqqabFC76zaius+4AhKTCog3EAEt+km78iSkITb2sraCh1adnemnmV4Y3diCf3a5XqKcZ8+oKuXcndmrPqxfHUOVLUbZGUXupqJMdxsnh79u07FC65z34+jWFoa6bObhBkxsBVyg7l7+pS7XtRvqKAA3sgLUedIJnFVcdpv/h5owunbQxfrfyx/LF4q9AaluKwFcV/elvh/SudjsWG3uiEACcvzeYuMYvHxOMuOijyaxqOx040w+QDyUMj/Ecm+z3qe8TIm6RTZoWVIjmINTEfDnr3c36DTvW2nZ7a6URFT5IuA/8owroQb/ca+8O38BG39jPmX5DfHHCcGTnlMG1IkDITqDARwizAwrwZTdN217SBwtPE3S9kz7s55tyW9zVvDTW85oVBQ98nAUOpC8FDmrXtUecZCS30m6exb1U/3hqNyb7Bsrr/QTi2DQSw5o0W9Lfe3ZQaIvDFINg0ib7tzhX3K3qEsBZVTC4+pw1Iuml1TpfrKq75jTYAEOPYp8W1xPsv2/YLwa+PwJPTDe+ORmyDixe6pg7sXUe/jEBuZRPM8Aampz4b3hb0EK6HokRsQjcowb1Ngjvkm8N+8dbKt5mU2FgDKPWKzSU2fFVhcriVm/VjDZjqd0uGPAI8rnHa8e5Z/TAqF+yDax55bPlhkN47r/ebw+FikSULIHk=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(31696002)(86362001)(6916009)(2906002)(316002)(54906003)(8936002)(31686004)(26005)(186003)(2616005)(4326008)(6512007)(66556008)(6486002)(6506007)(66946007)(36756003)(508600001)(8676002)(38100700002)(5660300002)(558084003)(66476007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UTBnbVVUUm53UGRWTEpqQXZibzQvb3NLemMzZHp3c3M1R0trSHAxOVVZSWZ3?=
 =?utf-8?B?eWRReE41TS96aGJkRkpWa1JXcUQ0QjVCQTBwMlF5V0N0SUI4bEozWW9rMzY0?=
 =?utf-8?B?Vk1kWXJFZ0xDNE1LOTRmWnA2MmF6WXA2RzJyYmlUYTdJbEFBV00wNlJ1L3Q2?=
 =?utf-8?B?OVFVS1d1VnBPSEpoMGdqb2gweGtSYlE0ajcvMEhRV3VSZWRYOS90ZGsvQzBJ?=
 =?utf-8?B?UFg3eFE5anE2YUc0QXdqOEZ1amdDbHh1UUxueExjWC9tQmZVWVNQZDVEQmZy?=
 =?utf-8?B?czFnWFlqRk9GWVNtRXB6NjhGaDNHcGJ6VWF6TEJ4NS9uVVNmSEphSmtzaFo3?=
 =?utf-8?B?eXRKZ2ZyQzJiM0V5RXprMjRmeXFJSnorYmVHSCtGYTc4ZHNzbWo1c3AzS0Zl?=
 =?utf-8?B?WTZXd0NMUnhsU1dqUGcrSk1QeiszVXNkMnFUZjJTckZCN2FWNHE3QXJEZWpS?=
 =?utf-8?B?R29QWGV6RkNiK2ZuZklncmh6bUxLZVExbGNzU0hqZzJTNHVxUWFndUtabTNX?=
 =?utf-8?B?WnZkZ1dXbDVRbnRVN2luOFdCVzRJdStQTEEwMEQvVnI5UVhpMFZ1MWY0U3pn?=
 =?utf-8?B?aURZWklhbGtEcTVtMFpldHdTRkZXWVhqMjM0Q2Y3WXVZUzdtcjFPcTRqd3VJ?=
 =?utf-8?B?K1czNjVxVm9kSWFRZ1EzMlEwaWhXeVFSU3JXQmk1WlBpM2wrSEtyb3lpYlZ3?=
 =?utf-8?B?RFVCVFNVL2ZWT3VFZElRbi9kdnVJNGVHNlIxdGJYWnNaeGdwdFVMQWptV0hX?=
 =?utf-8?B?emhZVzFSR1V3Vjc0WWNDV0dieDNsOVdpZkN6aFhUcUlkalNQR21Fc2kza0Jv?=
 =?utf-8?B?d3BxZWRPVDVWc0docmxxM3RLR2QzajlXM2g1azMwVThNcFozK2VWdlJDR1dH?=
 =?utf-8?B?MkJaL0tCNkYrZTN6L1FHbmhYMGp1OXVwZDY5dzVxazNneldQMlpPZ205MnMz?=
 =?utf-8?B?dHdTTCtnaVBHSXFBb0JBZ0c3VzUvNjNSL2RyNmtyclpTdUd1cHFDaVdQOFBK?=
 =?utf-8?B?ekVyWlVXeVlld1hEQjgvOG1sS0Z6cHlKNmljN3pDZ1c4VHRJV2ZnMlRXaTZj?=
 =?utf-8?B?b1hvMWpHS1BGbENYSk9jMWZqaW9pbWw3UmZnT2hQckt5WnZxU3NUQ2h2Mmhh?=
 =?utf-8?B?UkYxdG01WjBMVi9MQ2Jrc1BtenRLSjJReG9vTHd2aEFhcGZnNC9kaGhhdUFR?=
 =?utf-8?B?UFhUT3BuQ0ZhRzRaQXpzZnVmWHF5ZUNiRkNaL2Mvajh5cWNsb3dzVVlaSFo4?=
 =?utf-8?B?MW80dm5ab3ZKaWRHY29DNWZVcU9NcWpVUUhiNkpuZHhBL0JnYXQxNFN5NGg1?=
 =?utf-8?B?TWtJRzU5RDNrdmFSd0VYR2I4M3RCUWNlUUp2N1ROa2xkM1daVnRvSU53SG5C?=
 =?utf-8?B?SDFvYW16WFNKS3FXWkI4UlgwNm8xZEhRKzdRMElPWHlPMWR5U3RrUDVxQVcy?=
 =?utf-8?B?TEY2emdBU215YTNoekZMUHREM3Vnd2xCcDVkVVhNenBhbFhaVGRBK1hPcS8w?=
 =?utf-8?B?bTRxbHBFRE4zSzI5bkdMZ1dISjFIVW1nMGNCMllEYkJnS0pkbndOMWJiakNq?=
 =?utf-8?B?b0kyR0NWUmxNc2hjTWd1STlWMWlib2RKVUxxRUtMS1ZDSVhCcTBKdzRJMGdt?=
 =?utf-8?B?S0Ivb2I4L1o2WWtEb3hPL29mT0sxTFNsWjk4d1lWZHI5ZGs1UXNYZElHM0xo?=
 =?utf-8?B?S2ZOajMzMXN3NlU0TG9ZVWZsSVh1S0lzTVZXblJlWVJ2YWM4U1c1TDlsL2x2?=
 =?utf-8?B?T3gyczBYVXhkMjhnZ0Rqam01UkxPQUd3a1VuTVpVVlhrdUJrdGFkZ2ZlVG9j?=
 =?utf-8?B?eUhXT2ErNFZTbmMzK1E1Z1dVRFdzWlFvUi85R0pFRDVRQ25adVZQdENnSW1Z?=
 =?utf-8?B?dnpzRjN0c09ybXU0Nnl4VC9TV1ZKVjc1bVB4UGwzSk1PU1VkV05pUy9wcjV5?=
 =?utf-8?B?ZFpCUTU2M2h2NGppZ3lFMUh5Z01BRU9weDZwOENsdzErY0hGc2o3elM3WUQ4?=
 =?utf-8?B?S1loRmxJSzBZM2FiOVlJN250bCtwOUxpcmNOZjVRSnNYTjdKUFRTN1RoMGxH?=
 =?utf-8?B?ZUh6a2hsdWt2RUhOUDk0Q2daOVRLd2VuUW5jWjB4a2VmaXB4TEFySjBDRjlV?=
 =?utf-8?B?NlF0amhtU2JCQ25mUHA3TUxabWVTdXdJSGMxRmRhRnlXa1lBVklYdlN2Ynlx?=
 =?utf-8?Q?rREbYFAt5WvIwKCFA6sPojs=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8728d829-765c-4ad5-f3b3-08d9f6b4cdbe
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2022 10:11:05.8681
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: B0otYrWB5zlE674kOF5Py8YzJbqpE91cJBBKF0GKkNLogj0FwuZ4Jgi/eb8RHswbFkMDJskAk5vRGyCjGyizrw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR0402MB3944

While it'll make backporting of the last patch a little harder,
it seemed better to me to do some cleanup first this time round.

1: drop NOP_DS_PREFIX
2: cpuid: replace more cpufeat_word() uses
3: correct fencing around CLFLUSH

Jan



From xen-devel-bounces@lists.xenproject.org Wed Feb 23 10:12:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 23 Feb 2022 10:12:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277261.473696 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nModR-0005bS-GO; Wed, 23 Feb 2022 10:12:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277261.473696; Wed, 23 Feb 2022 10:12:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nModR-0005bL-DK; Wed, 23 Feb 2022 10:12:37 +0000
Received: by outflank-mailman (input) for mailman id 277261;
 Wed, 23 Feb 2022 10:12:36 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=DZ7u=TG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nModQ-0005b9-6s
 for xen-devel@lists.xenproject.org; Wed, 23 Feb 2022 10:12:36 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1eb8cc47-9491-11ec-8539-5f4723681683;
 Wed, 23 Feb 2022 11:12:35 +0100 (CET)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2051.outbound.protection.outlook.com [104.47.12.51]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-35-edIydqH7MR2OtKPIzJmdsg-1; Wed, 23 Feb 2022 11:12:33 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by HE1PR04MB3004.eurprd04.prod.outlook.com (2603:10a6:7:1f::22) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Wed, 23 Feb
 2022 10:12:32 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.022; Wed, 23 Feb 2022
 10:12:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1eb8cc47-9491-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645611154;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=LI5XIykVTVe8uWmfaLRy4nPxEkgSqXOP7UAzhSepRo8=;
	b=bv1yK9+Ekcbop+xlAZ63wz3H3kdBRWjYJlKb88NCJS1gdGJvZDTwBPusYRH3/GsbyN+Gbi
	tEqJNjp+4wu0HEwuqS5W5tbvHxoEZVRs0UF6f1hZI80vQJ0Z3syNDMnTUlNepa/XYYjFNX
	TSmUgB+mOZ7IIrazcFI4Tx/hbh3HlN4=
X-MC-Unique: edIydqH7MR2OtKPIzJmdsg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=I8cJ3SunquUDnonYw6Ockk+aAATSSc52wp8pvvENqGSgjOVd73W0ccfD2SdVpEEZXJ+IQW10oscfLJmMK41kiFVxbQa+im+x7iLjHjUd2izuQ6O9Kjc5Tyk25MGf9JEElKFJAsg/xj0j4EHuOJ8XGNs+2mzKIJeztzdGYCoRWKn0jRJDql+8nZbdEnjteGnFGwIIcltlwkGj/RfGG0RZJRkbU1ofCJ6XRBSDdYLVf6v9MsTmz6yR6ZF51sBWzuVx/Joz3Dgs0k/OQbaLgKqgtJ+9zLDk2gKxR64Ha0RopRAe9da+kU+28ebcb9vWB4JtKIXTiadZATVoQKwZR6efIA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=LI5XIykVTVe8uWmfaLRy4nPxEkgSqXOP7UAzhSepRo8=;
 b=MQfWo27d7mIgjjnQGS7Z25Qy6FxRjutcbfQLnL2d2TcexSI0PjmJ6mXhirglBBrd68rDlpCoL8Kv9rpZFeDv0gnNhMk3FHN7hGCRxL+ZZ8UhtxqPDf84wigBf5/fJDIjS0gim8i1KQxe7sxAgWzgK6MY6uw3vqAeDlx32qnwvaWc4JxODpo+tRrNmdJG5eX4yPi06p6MaiciIfPneNSlQWy5mv/lma7jaxBxpe8kADGSp1FpZ6F6ub3HLJC2FskxXIcLCgYFVpQKe0r0qEWchFZrktD6vbuJtYvOUdCaB8xNOygSW50JIC85qByucb4yIl0fYQ3D4kmq3q2aMILLFg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <96f493ee-a360-ce46-7a61-5f55ca436295@suse.com>
Date: Wed, 23 Feb 2022 11:12:29 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: [PATCH 1/3] x86: drop NOP_DS_PREFIX
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <91935ffd-a270-f1a1-28f1-645fa4167fcd@suse.com>
In-Reply-To: <91935ffd-a270-f1a1-28f1-645fa4167fcd@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P195CA0002.EURP195.PROD.OUTLOOK.COM
 (2603:10a6:209:81::15) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: dfe5c7f8-e711-4ede-e782-08d9f6b5011a
X-MS-TrafficTypeDiagnostic: HE1PR04MB3004:EE_
X-Microsoft-Antispam-PRVS:
	<HE1PR04MB3004CCA75603E11F10FB0EC3B33C9@HE1PR04MB3004.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	nJ+6sQlvvNzyDeK2OqB4mBbs6UNNm/RXXDSt1Xwe5XOZ9biLHxAxkUy1Uv/02mevbUaE4AJjnr/s9U3iNM7/JBvOIL8FwTfAXDiyebn6ef7JXVQBsuG0vd/+rMnICktG4GrlQBxTfIPJ6XGyoeWCLVK4c5chvLYENKnUHQROESaTNbQS4xUS5HCCK0FwbbuQbbv05cNXDMJEo7pNMBG6eiFRC2ECq79Bx+XLeTzcOLLjxH6pVtCPlNYBgQKt29soQo6ej2Wkgm2OuZleZ9nPybCtrY1av7m8C4ehLR169d1myCLwgXbARgeHqWov+cGn3ZkWKvt935AgHvSa95qsbkDlM5uvNUd792pqn1WlGKiZ/o/5vK2i+8xFTT2RxtcwAFBauv6QgTkoCqzMBST0F6+Vf97Y6ZuqkpLjI3BERvkU4Et4HodIeytgy2jEmbt9GiAFIm3M0BdxJkEbE2/Ym6AYRkMxEA7ri+zZP7jd3Hl9l0/ZRPjf2G0Q0HPY6+0zv/q4CpZZJiN3K0NM4NwSzmGtsajLMcH7hoxHfkYsvKoNiynx9vz78hhuTGor7ypMwoZdo1r6A6tnin5DG/LklcOVgG505ntQ3cp06AKwCvvZkZ4ot1+YQziEnXSBkaYw661uEgDczJuQf5AnxX6GB6rhJiI1yG81xME7M5iJytv97xgElOSqORaQoX5kfIv7zbmKsgRqiwWbM2eqHxJXo5OEXNWLM6WKNS0IEWujGR1/xIHdNDivuHXoE4BQpUia
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8936002)(54906003)(8676002)(6916009)(508600001)(38100700002)(2906002)(2616005)(86362001)(5660300002)(186003)(26005)(31696002)(4326008)(66476007)(66556008)(66946007)(6512007)(6506007)(6666004)(31686004)(6486002)(36756003)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RFZlVkxpZ2xHeXpreVo2b2VSTGRGbGNMQVhvYy9HQjA2ejlBaWhtOEh6NkNS?=
 =?utf-8?B?Q2FXYVV2bDBkaWhnSzB6Y0RLaFdWdXgvb0ZGSDB4SXdiZDBSdWtGeG84UjNE?=
 =?utf-8?B?RVluWHBWbUNFVmtsMjgzV21JNzVQT1dadG82TFRiMVgwQ1ZUS1pKc2hYcG9B?=
 =?utf-8?B?TUkyeUl5MHN6T05tdTRjQjVyRjhOb0FCS0d6b1J3RTZ4L01hUUtpb0NqbUhL?=
 =?utf-8?B?RlhicEZxb0JPb0xIN2dOaGNvSE1XMEMrZlA1ZDJ6WlR2dENnR0tWeFNpcExD?=
 =?utf-8?B?cktLdGlqVERwV3d5azBKL2c5eFVWOVMzSGQ5RHVmdjFvUmkvNmpScmNUdUM5?=
 =?utf-8?B?L2tLUWd5cWh4NTEvazBIU2V3eDg0bXNmZTRld0R6T05GSE1aejIrOUQzeDlj?=
 =?utf-8?B?Sk9IMWJlazdjak8vTmZjMzFRRHNuSVQ4RWVGS0xGUG1JT1cwQXFPTFVQNjNv?=
 =?utf-8?B?alArMnl3KzFwUTEvQWFZMlJoUVQ2aE4zdHQzODFiZ2VscFBmYU9iTzlzWFY2?=
 =?utf-8?B?WUdCQmVJeVVGcnp1bnc4Z2VTejJOQ1B2ZDVEVmxZV3preHI3ejhGS0FHdDEv?=
 =?utf-8?B?RFlyUVovUGF6YWFBWXBhNlZmMTVyZEd6TWRZY0JSQWk5SVVhZzRHTzZUVkZC?=
 =?utf-8?B?MFpnLzM2MVB1U3FEbDZwY0JUN1hENnhNcFp3dGZvNFdBbm1NRHBvQ2NRRm45?=
 =?utf-8?B?T3ozKzJ6WS9RaVpuZlN3a3Q2Y2g2cFA4ZE5YVFc2WU9RSnFrNlFxbGEycDZ1?=
 =?utf-8?B?V0p2cXM2Tnd5bnVCNTVKSVlqR1JUZDNvdEtSQWY4WlpiM00zMnFyM3NhK0dR?=
 =?utf-8?B?dnpVTEZPMWM5c3diZnlxNWcrM0xYU3J6S013QXE4NHE3TW5NYmcvckNrQ254?=
 =?utf-8?B?WFo1Y0lYM3dlbmF5MCtCV1EveUc1a1B0UmdQcWZoSXRCdGp0SWRKTlhyNElr?=
 =?utf-8?B?ZHMrZS9lNUgrMDZPTGcxUXJGTThEMWg1OE9TWGNTWGZ0c2kvMGFXeklXL0ZB?=
 =?utf-8?B?S2l4SGl3Uk5JNEVXVDU1K05wL1VLY2Z5eHp2T0oyNi9wRFR2WjBWK2hUclRS?=
 =?utf-8?B?c3FITTV3aHJhOXQzZG5NckpwZ3NsVlZRdU8yNFJhTlhJVTg0UERRbGdNR05i?=
 =?utf-8?B?Tld6K0s5UEVBRWw1SkU5TGZ2SjZyYWtJa2NEV3FtanRRRjdVRkhGUWhDVmNI?=
 =?utf-8?B?MHM4QTQ3aFQ0QTlvSDFha0Z4cFJkWXZlM0hpUG5xUDEzUFo1RGJHWHdRRmk1?=
 =?utf-8?B?Yk5ZR1YrRUJmV1ZsVGczdU9FTktWSkp1c29FTnloZ0RlM3R1bVRKcUdranNk?=
 =?utf-8?B?UGVCRU0vY0UwUFMzOHJrd1Ywb3pKaVdPbFFGZExvaEY4Vi9QZHpDVkY3TXNX?=
 =?utf-8?B?Yk9Fd3VjaENFT1RaOE5lOStrUmZGMTlHWmR4bENaN3ZwTVN1Y0k1ZzI2c0lF?=
 =?utf-8?B?dVZOb3pSU2E2Qml2UW9oZCtjTS9wYjgxUEpkZ0FhMjY5UG4zdnRDQWd5TkZo?=
 =?utf-8?B?Q01PdkNSMzExT0xFelYrUTdkUWRTUDE4OGhRYnlMODNsWWJacHRRM3MweEJO?=
 =?utf-8?B?MGpTdnpTMUtnRnZsR0pIdEpXUlluSE1VR2VRNjIrSXY0ditTalhCa3NQNWlM?=
 =?utf-8?B?cVd4TEVaQ3lCaTFsbHZrTzZFK05pNnpkRnJqUEhCcHNQSklrUWV6TDRUb2Ri?=
 =?utf-8?B?QVRsdU9Zb0tURFBrYVJPK1NJQTdKWEtjMHlmUGNST0NEN3ZpQ1RyQXdWVUJ2?=
 =?utf-8?B?OERnRjh5NDVmZ2ozcEcxRytKRVN0bHlDU3l1RUdHeWVGT3JNLytLSmRxbk0w?=
 =?utf-8?B?cHVxQ1p0RllSTGtMbnpHOWluRXBpSFI0TTFoNVhuYnFyeXB2MTJIdnpwajYr?=
 =?utf-8?B?SHQ4Z25ZaGF5MHVrejR5VHY0U1NjWkM3enVacUo1WDlUQTVqTEJ5TUlwcUlr?=
 =?utf-8?B?YlVLd082eFYxMWxQZ3lDM1F3M1Y1ekZ4V2FWRzlqVTMzcFZzdkxBT3lFSlFt?=
 =?utf-8?B?ZkYxd3EvaWtBQVIwaFdyZnB1NkxNblZLUHJpb3hONjFWQS92clhrV1V0WjV0?=
 =?utf-8?B?YnhpTEI1ekQvQkV1N24zRVZrTGpicmxFSFlvRXBURnAzdENkNHpWT1BMUnB6?=
 =?utf-8?B?R2NrWVRoMWY0eGxLUzNaMzA3Z2Jxak5CQ05ieG5uckRzZ2tTajI4cnc0Qk4r?=
 =?utf-8?Q?1ULUuIrNqVJt+X+I6d8yyDk=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dfe5c7f8-e711-4ede-e782-08d9f6b5011a
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2022 10:12:31.9720
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4hi36XRmL0zsmTTDijtBhNBLeIhmg+9KlJ7pPxnBqnMro7Z4pp0dKWd4ijLCMcrcgvX3LGEgMTlQ+UlixTv7Fg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR04MB3004

This wasn't really necessary to introduce: The binutils change
permitting use of standalone "ds" (and "cs") in 64-bit code predates
the minimum binutils version we support.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
In fact we could patch _just_ the opcode prefix in flush_area_local().

--- a/xen/arch/x86/flushtlb.c
+++ b/xen/arch/x86/flushtlb.c
@@ -247,8 +247,7 @@ unsigned int flush_area_local(const void
         {
             alternative("", "sfence", X86_FEATURE_CLFLUSHOPT);
             for ( i = 0; i < sz; i += c->x86_clflush_size )
-                alternative_input(".byte " __stringify(NOP_DS_PREFIX) ";"
-                                  " clflush %0",
+                alternative_input("ds; clflush %0",
                                   "data16 clflush %0",      /* clflushopt */
                                   X86_FEATURE_CLFLUSHOPT,
                                   "m" (((const char *)va)[i]));
@@ -298,11 +297,11 @@ void cache_writeback(const void *addr, u
 # define INPUT(addr) "a" (addr), BASE_INPUT(addr)
 #endif
         /*
-         * Note regarding the use of NOP_DS_PREFIX: it's faster to do a clflush
+         * Note regarding the "ds" prefix use: it's faster to do a clflush
          * + prefix than a clflush + nop, and hence the prefix is added instead
          * of letting the alternative framework fill the gap by appending nops.
          */
-        alternative_io_2(".byte " __stringify(NOP_DS_PREFIX) "; clflush %[p]",
+        alternative_io_2("ds; clflush %[p]",
                          "data16 clflush %[p]", /* clflushopt */
                          X86_FEATURE_CLFLUSHOPT,
                          CLWB_ENCODING,
--- a/xen/arch/x86/include/asm/nops.h
+++ b/xen/arch/x86/include/asm/nops.h
@@ -5,8 +5,6 @@
  * Define nops for use with alternative().
  */
 
-#define NOP_DS_PREFIX 0x3e
-
 /*
  * Opteron 64bit nops
  * 1: nop



From xen-devel-bounces@lists.xenproject.org Wed Feb 23 10:12:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 23 Feb 2022 10:12:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277263.473707 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nModl-00065E-Pz; Wed, 23 Feb 2022 10:12:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277263.473707; Wed, 23 Feb 2022 10:12:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nModl-000657-Mq; Wed, 23 Feb 2022 10:12:57 +0000
Received: by outflank-mailman (input) for mailman id 277263;
 Wed, 23 Feb 2022 10:12:56 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=DZ7u=TG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nModk-00063c-HP
 for xen-devel@lists.xenproject.org; Wed, 23 Feb 2022 10:12:56 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2af43107-9491-11ec-8eb8-a37418f5ba1a;
 Wed, 23 Feb 2022 11:12:55 +0100 (CET)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2052.outbound.protection.outlook.com [104.47.12.52]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-11-1qtB_w43ORWL5V3XoRAkvw-1; Wed, 23 Feb 2022 11:12:54 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by HE1PR04MB3004.eurprd04.prod.outlook.com (2603:10a6:7:1f::22) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Wed, 23 Feb
 2022 10:12:52 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.022; Wed, 23 Feb 2022
 10:12:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2af43107-9491-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645611175;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Xh7f+LBqpvIMNCjCDOJiXb25hwsGdct++TnJN1+j8lY=;
	b=dqeXxKdKqyzLVlffWW0mvShefVhNQl9ecmh8kfZOH6EpwjDLsjcFsmB05DctUEDLAeJQF+
	ZHf1LRt35IH217yief9frulbnbwwWw/92y567C4OHY1ApeSD2tg86RWNZsIQMGC9ao9JIA
	atuaX1OZdbStpB2TgdKE4voa+ZsU5yA=
X-MC-Unique: 1qtB_w43ORWL5V3XoRAkvw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=VYSWRom+mbYbqITaeiPawAaNs1fYsxB3aeWUas25CSyX/GlE4q8cMY4MAxpXz4vfBCQZvOyZZET99KwR5cGUzAtf8/nzZXqnEv5mviAXjnuAAtl+DnhsdAVrrPL0UADUjAwwt8gPbhQHXhi0IRej1DWWTzbMJ4svjyqqS3B4q8UfiHitO+nk4e4veF2116zFJq61HXHUxEMb2B+BEQW3qr5tFd/avw/Rrxz7JQasrEo66ESObEn62LKYRcUxkb1brP9Lwwiim7pMiZLfvVh4WEeGua98DAn6wokTo8RcCwD4p2pRUmQpz/LHnkccMVyhlDqiy39DPjr7bLKTAuigCg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Xh7f+LBqpvIMNCjCDOJiXb25hwsGdct++TnJN1+j8lY=;
 b=aQuZMXX/VId8N2/9y14DSvJd8W7wDHGzE2rB2PZEXSYrQaGWS/NSQZszSDgAqCkrYwhAw1PxkUvqw6VnKNX5X1Z1vxvXhuq/eAD9EUmVTjbexXz58ekbCxkldQTg8siMi0SsA1dmtNrqkMDAPcvsqC1tI8Urif8GKKTt28tiTlqHoU9BBjVjzXsic6R3tqKHeHWcdQ1XlHiiOBxYB4RFHX6rNwjZ3nlNk++ySsQWXtug4F4YMUhKDH/fZCABcO3QWplZN2E2tRV8J5DoktIPpBV/i8wTUDWApc+KgQmGuBrUg2II3fuLkpbA/Qj1NJCOtzJC+qo74+0kZnD9dmX4rQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <2c1f9c24-a07e-b5b6-2f20-18eacb835763@suse.com>
Date: Wed, 23 Feb 2022 11:12:51 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: [PATCH 2/3] x86/cpuid: replace more cpufeat_word() uses
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <91935ffd-a270-f1a1-28f1-645fa4167fcd@suse.com>
In-Reply-To: <91935ffd-a270-f1a1-28f1-645fa4167fcd@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P195CA0016.EURP195.PROD.OUTLOOK.COM
 (2603:10a6:209:81::29) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 13411b8e-f3f3-456e-21fe-08d9f6b50d74
X-MS-TrafficTypeDiagnostic: HE1PR04MB3004:EE_
X-Microsoft-Antispam-PRVS:
	<HE1PR04MB3004F9F84CE5D742E31DEBF6B33C9@HE1PR04MB3004.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	+yHwTHIzSfCoOJYxZ8nHPXEL5Fx+X+axAwR7fS5yV6sY+jLlViOwVuUtT5AD680mtbFgl0dpFpu0vz4dfSN2zZwWmJb5PCrGLn/T19/kg3wukwOwU9dDQqe38mO1KAJFSEWU0KrR8nk8V8la0+uURUa7t/nulGluhErlZ/JJv+0xmoa6vWNWLbdmrNkTB+U5foljpNV9Kzh/0etGePk4Nnh1JLvShyH639cKtG1TQ32F5sJvR38L9/cGAtwDegrYmhQ8uXnBt+MZ93RXO1S3Sg27aVD/iERyPp5D/nWopwa6MoO7tw/Gg+bwuiipI4jjWHB2ACQV0MBXnPrmiA3nAqegY1Uc/cZh5hZYdc9qOVYTJN9PUV/+AmXg2dtBrD8Q/lA7Ab5Dt2bN7Wk1GHaJOUdFeuyqnYkoas2zG2znddlBeDvZidFjIdJRwPJ4JI4mWG6RlvhPIoqqMj4TtqNZnUktlzJqRN0ZRVWhhmd+H96IeCMDDVFpHT3htovorIBq52FV5X2cO/9KTq0x6uklAYQqsdzDScOUBizRfMEU8FH1b2l1/toBh+QhvFwUjFvADMVj8KwJbYOH1CBDB6z2Z4+9tLltGIukv291b/+1laacqpOn1FKBaUDsy1v4sgnokvWgUCDwiVhqWTWy1k/DD0Ngih74HwbH093ma+cfJCGCi20iRSoX8fTvThe9CbmYB3c+CsBE3dwH80uLEfzWW17k+b4ZhEDgB6EhHToSOsnq2TA/9Sf1Q2RmAuFQe2tw
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8936002)(54906003)(8676002)(6916009)(508600001)(38100700002)(2906002)(2616005)(86362001)(5660300002)(186003)(26005)(31696002)(4326008)(66476007)(66556008)(66946007)(6512007)(6506007)(31686004)(6486002)(36756003)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RVViMG8wWkN4TzNuMEFTNEdFeVNNc0dvUHA1b011VkFYSVdSWXR1OFF5VTZP?=
 =?utf-8?B?NnpIYTBXcEhwbTU0TWRyOUJMOWEwU2thdVRSMEkyQnlKeVpwMHpSdjZjd1F2?=
 =?utf-8?B?aEFrWUt4RzdrZlI4VE9EUG1YckJHblZlcHR4NTljNTByNXVkem5mMnRxbWw3?=
 =?utf-8?B?VGF2VytGb0dOS0VXQ0t6MlpqUVFEb1NKOHNnYmJoTVB0TitvWkVMYWwrWHRC?=
 =?utf-8?B?bk5qMUZZZXgxYklVM0pzQmk5VXBDcjhKa0pwZ2VYUlMxL2kzU0R3cE1pV2NF?=
 =?utf-8?B?ZEZZTHRTaFErMDgyd2ZleHZJODR0NURjNHIxM3lyRmVFTUdVeURUQjFLRzBB?=
 =?utf-8?B?ZlFFVVAvTEI4TU1VSmJ2QlVScnNjUmlMdmJRa0JHODlvb3NEMytXU0JoQWh5?=
 =?utf-8?B?V0E0OFNTQWx0b1dUbUtkdHBHUVlTQzE2eUJQVFJ3d2N1ZXNKN1B1TnNMdElF?=
 =?utf-8?B?L0c0bk8xWHV4VG9hb0piT25Ta3VVSU9BLzcrWndjRzdVOXVpK2U0T2ZKV0hQ?=
 =?utf-8?B?aWc3akFQNjNTMXdvd1Y5dVdwdnJvSU8vQ0dYVzVUOFgzNElXV2J6N1F6a1ov?=
 =?utf-8?B?ZDNNSEVXZGNiVnhFNWg5QkYyWFZ1VFBSSC9VR2lDQUxFRzlZc2VVeHZxczdl?=
 =?utf-8?B?VG9FNlQ5YUVwUkU5K3haRXRCdktkMUtPVXhjZCttdWtINjBUbzc2aWlqdUM2?=
 =?utf-8?B?UzMrWk9SemZWVlVFVGg4b2trZVVKYlNXN3lJeldFNG5oZ0dOV0FWamo0MHRv?=
 =?utf-8?B?cmlVNVJwa0dRUzJvSWEvRC9hM2RKclpVY2JGOXVlYUJSaUJBTjZGK1dLSXQw?=
 =?utf-8?B?UUdXMTBxbXVYZU1DM3NNR0lzWlUrZGpwQTdmWDN5NFhIeHRDTzczOHQxaDBs?=
 =?utf-8?B?V1pXaG1CY1BEenIwbHgyeVQ5dUUvSG9PSnJSKzNkd3Z2YUpJRGtCWGRsV0xY?=
 =?utf-8?B?blArc0hFKzZWVmF6NnJlNURTTFhhNE9TRjI2ZDJlejRBcUZlQktySzVSOUht?=
 =?utf-8?B?VFlSalFuR284Ny9uZnc5U05tZEt5dkhURXY4QTNIQjBnTzU1RUN4WUc1SXND?=
 =?utf-8?B?ZlAvUVIyZUFSd3VsVVNwUk0vT0VVZUVVRUgwK29tMkN2WExxTXRnL01hRDVI?=
 =?utf-8?B?alFjRVVMQlVZZzdaSHRmeUtiL0oxdnltT2pJY1VCSVZiTGFJK1RjWGJCZFh4?=
 =?utf-8?B?SVhPc2VncTNlNGl6VWJmUXR2bWttcFcwZG9TRFFCQjV2MkdZbnBHZm9ibWh4?=
 =?utf-8?B?SDBUWStSWU0wdnJEZ1JaYzRQQloyTVJQY0hOOFlYUnhxZUcwbjR1VUZCaGJi?=
 =?utf-8?B?RTM0d0RUVGNjM1VrMDNhWW8zVmt5OFJyRFc1WVMwQld1ZlpJbWNUcTZlTnNj?=
 =?utf-8?B?Nk43eDZ3WkYxY0h3OWY2ME9ESWcxZUdpV1Y5VGZJaFEwTjdyU2FUMXRIa3Qx?=
 =?utf-8?B?RWw2U0haTmNnOGE5ZmxFZlRnelg4UWFDaWhsMkVwank4UjZHWnZMN0JQeUpw?=
 =?utf-8?B?NkpSRGh6QitSaFgvNHBjdXRqTnpSdWtkaEszR0lrUEdsWFJYcGFMRVo2QnNM?=
 =?utf-8?B?YmJiaitoV01FMlF4V0lVY3U4dElId0VBRFJEMGx5MDhnNFdMQ05jZ1N1aTM0?=
 =?utf-8?B?TUphb1ArR241OUF1MWViZVJCSEo5MDBzemk5RkNQZHZpSTE2MUtjcXlzaXVF?=
 =?utf-8?B?Z0pEc2d0TmltT0Qyc0JoVXAvUVFwUndIdXU4bGV2Ym5vVEVjL1VQNlUzNEs1?=
 =?utf-8?B?YnV6enhNeVBCK09LQkZNcFBsRjdUUFJQeSthZFh3OFFGaTc3Uk1tcjZ4and5?=
 =?utf-8?B?RnQ3SjU4N0lrY240MVdnQWM4am1NenBSUFZqL2NDaHlwK0ZZYWV5TWw5cTVi?=
 =?utf-8?B?RVNOUGFCSTlXNnhjcXFkbnJ4THdmSDIwdGJrMkFJUnVGZStFNlIzaUlRWnd6?=
 =?utf-8?B?YWVJc1VSSkRsc3dYWi9DdEN6dXlpRmd3M0JOT1lmeXlLT2RHdkdURHc3VXJi?=
 =?utf-8?B?NlFrdFVrYktLNHQrcGMvRXVJT2NtNWpueWoweUZoQ1NxbnRwUUEzQUQ2aTFJ?=
 =?utf-8?B?K0w3N3haNDk0OTlZZWQwTjN5SEZrMGpDaW4zdnZRRW5OYW9UdC9CeFpueVBT?=
 =?utf-8?B?NGNhWi9TWUJ2L2RlOVRZZ1Z0ZDNnRFdzYzF1V2Fqb0pmdXF1V2lyS3VUZkZl?=
 =?utf-8?Q?DN8b5NHvRZmoLyR3azhMPLg=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 13411b8e-f3f3-456e-21fe-08d9f6b50d74
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2022 10:12:52.6113
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VE56K4lXdCdfzizju23qQECTxIbhQJS5VfR+hjTPpMn0eLm5fo1NVJrZRh4XkZ5g57rO1yNRquW1J6nm6Q6+oA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR04MB3004

Complete what e3662437eb43 ("x86/cpuid: Disentangle logic for new
feature leaves") has begun:

"Switch to using FEATURESET_* just like the policy/featureset helpers.  This
 breaks the cognitive complexity of needing to know which leaf a specifically
 named feature should reside in, and is shorter to write.  It is also far
 easier to identify as correct at a glance, given the correlation with the
 CPUID leaf being read."

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/arch/x86/cpu/common.c
+++ b/xen/arch/x86/cpu/common.c
@@ -332,23 +332,22 @@ void __init early_cpu_init(void)
 	cpuid(0x00000001, &eax, &ebx, &ecx, &edx);
 	c->x86 = get_cpu_family(eax, &c->x86_model, &c->x86_mask);
 
-	edx &= ~cleared_caps[cpufeat_word(X86_FEATURE_FPU)];
-	ecx &= ~cleared_caps[cpufeat_word(X86_FEATURE_SSE3)];
+	edx &= ~cleared_caps[FEATURESET_1d];
+	ecx &= ~cleared_caps[FEATURESET_1c];
 	if (edx & cpufeat_mask(X86_FEATURE_CLFLUSH))
 		c->x86_cache_alignment = ((ebx >> 8) & 0xff) * 8;
 	/* Leaf 0x1 capabilities filled in early for Xen. */
-	c->x86_capability[cpufeat_word(X86_FEATURE_FPU)] = edx;
-	c->x86_capability[cpufeat_word(X86_FEATURE_SSE3)] = ecx;
+	c->x86_capability[FEATURESET_1d] = edx;
+	c->x86_capability[FEATURESET_1c] = ecx;
 
 	printk(XENLOG_INFO
 	       "CPU Vendor: %s, Family %u (%#x), Model %u (%#x), Stepping %u (raw %08x)\n",
 	       x86_cpuid_vendor_to_str(c->x86_vendor), c->x86, c->x86,
 	       c->x86_model, c->x86_model, c->x86_mask, eax);
 
-	if (c->cpuid_level >= 7) {
-		cpuid_count(7, 0, &eax, &ebx, &ecx, &edx);
-		c->x86_capability[cpufeat_word(X86_FEATURE_CET_SS)] = ecx;
-	}
+	if (c->cpuid_level >= 7)
+		cpuid_count(7, 0, &eax, &ebx,
+                            &c->x86_capability[FEATURESET_7c0], &edx);
 
 	eax = cpuid_eax(0x80000000);
 	if ((eax >> 16) == 0x8000 && eax >= 0x80000008) {
--- a/xen/arch/x86/efi/efi-boot.h
+++ b/xen/arch/x86/efi/efi-boot.h
@@ -685,11 +685,11 @@ static void __init efi_arch_cpu(void)
 
     boot_tsc_stamp = rdtsc();
 
-    caps[cpufeat_word(X86_FEATURE_HYPERVISOR)] = cpuid_ecx(1);
+    caps[FEATURESET_1c] = cpuid_ecx(1);
 
     if ( (eax >> 16) == 0x8000 && eax > 0x80000000 )
     {
-        caps[cpufeat_word(X86_FEATURE_SYSCALL)] = cpuid_edx(0x80000001);
+        caps[FEATURESET_e1d] = cpuid_edx(0x80000001);
 
         if ( cpu_has_nx )
             trampoline_efer |= EFER_NXE;
--- a/xen/arch/x86/mpparse.c
+++ b/xen/arch/x86/mpparse.c
@@ -516,7 +516,7 @@ static inline void __init construct_defa
 				   (boot_cpu_data.x86_model << 4) |
 				   boot_cpu_data.x86_mask;
 	processor.mpc_featureflag =
-            boot_cpu_data.x86_capability[cpufeat_word(X86_FEATURE_FPU)];
+            boot_cpu_data.x86_capability[FEATURESET_1d];
 	processor.mpc_reserved[0] = 0;
 	processor.mpc_reserved[1] = 0;
 	for (i = 0; i < 2; i++) {
--- a/xen/arch/x86/tsx.c
+++ b/xen/arch/x86/tsx.c
@@ -48,7 +48,7 @@ void tsx_init(void)
         bool has_rtm_always_abort;
 
         if ( boot_cpu_data.cpuid_level >= 7 )
-            boot_cpu_data.x86_capability[cpufeat_word(X86_FEATURE_ARCH_CAPS)]
+            boot_cpu_data.x86_capability[FEATURESET_7d0]
                 = cpuid_count_edx(7, 0);
 
         if ( cpu_has_arch_caps )



From xen-devel-bounces@lists.xenproject.org Wed Feb 23 10:13:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 23 Feb 2022 10:13:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277274.473718 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMoeg-0006lO-3v; Wed, 23 Feb 2022 10:13:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277274.473718; Wed, 23 Feb 2022 10:13:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMoeg-0006lG-0J; Wed, 23 Feb 2022 10:13:54 +0000
Received: by outflank-mailman (input) for mailman id 277274;
 Wed, 23 Feb 2022 10:13:52 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=DZ7u=TG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nMoee-0006l4-Kv
 for xen-devel@lists.xenproject.org; Wed, 23 Feb 2022 10:13:52 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4c64d1f8-9491-11ec-8eb8-a37418f5ba1a;
 Wed, 23 Feb 2022 11:13:51 +0100 (CET)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2104.outbound.protection.outlook.com [104.47.17.104]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-4-GfFDp9XRNV6Kqbx2eU2lwQ-1; Wed, 23 Feb 2022 11:13:49 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM6PR0402MB3944.eurprd04.prod.outlook.com (2603:10a6:209:1c::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.21; Wed, 23 Feb
 2022 10:13:48 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.022; Wed, 23 Feb 2022
 10:13:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4c64d1f8-9491-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645611231;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=+vFchMkCIGjXqw4WIqVN7N88HXvbjRZMQ+krXE3zHAw=;
	b=mxKNUioZZMy4wGx79AWeaVdO+aSaToomCZG1S8fZo/CjxXG48jiuW/G5aH04waDWg0OxPV
	/vQ/UVJy3nJIsfDNfbY5UeOHROLl/igTx3utqgXKEgleLFMZIQmFHrZxnWIrmoAse+jrdS
	lb1psGv3jqQbENQQrWt4PrtPsa/vquo=
X-MC-Unique: GfFDp9XRNV6Kqbx2eU2lwQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=kcwFmDds1+ioIa1QmD5Xw2vg2viIfhaTzEEfFwDob+Ifz+l0vslujZidvsfL45p4LXYU5AsVnzvwwUs6NK8qL+8Koiw+dmE+AP5F1mmx18gDPAMaKdDOokbjoScHQoC9tLgylGLbilV0H7Ayw+B0yIw17INwCzFiplHgFOin9V7N3UEtRgmSNSAXRtFgyEVevVrxo/OuU+icjhTrrDxNuLuhzCE/9oeU9vS6001fQSdOg/cGYEAUZ03HdR4NfZo66KzUeT06mO4L9tc3g7YjiI8Cft5O22SptX5x+ORcdrxQs+ZB0efoDprIybz93fAcvfPI6Q+nkinj18Rtj3TYww==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=+vFchMkCIGjXqw4WIqVN7N88HXvbjRZMQ+krXE3zHAw=;
 b=U4XIfWQ2IMccEo4G2R162NAsUrDVB2Lpd6Yr9W1Q9/7l3nx3VprLgjrbNZ7aFLfJZxrnrhGc1GSKrvIrz9JRhh+/B4o7Kxq9tGP+E0CffRIXUcpKWh5shhAR1PgaHPrh5HyC9AtjTgTfjwef2Nc4ouInqbBA64mGfhZkqzML/oo5BUIrRHoZIuSXeMZEuzMFaenS80SWaxPdFu5tNxta18majcczQGogqQZAMOw/3mIsxknoi2zngvjuRZ8iOblfwdUH7+52H2fFzIOZmm+9j+3TvzcGQxK/HuRKKsV26lS6ZLK/aJ8xa8wTGFInhWGAJS37Aox+IpW8uGkew4PCYw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <7026f7df-1f70-0018-a6eb-b7e043b279d8@suse.com>
Date: Wed, 23 Feb 2022 11:13:46 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: [PATCH 3/3] x86: correct fencing around CLFLUSH
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <91935ffd-a270-f1a1-28f1-645fa4167fcd@suse.com>
In-Reply-To: <91935ffd-a270-f1a1-28f1-645fa4167fcd@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0361.eurprd06.prod.outlook.com
 (2603:10a6:20b:460::13) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 80afe333-36c1-45b7-7170-08d9f6b52ea2
X-MS-TrafficTypeDiagnostic: AM6PR0402MB3944:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR0402MB3944B6526F30BD8664E049F0B33C9@AM6PR0402MB3944.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	i3f0j+l1BXYm63Llx2q90YUDZKFvmc1FK0a2q96chVbmbkcVdJCbjkK0FhhxJRRIL5VnOkt4LETM0zMnRboZceFs1grngGIbZFSXz5Be/rNzZuXp7Docsv0OUxMpytysH26sFpfTGNqYKWyWzJjhAJk9aOocuHpNmvslj1mzeRmhvbrVNIibqIZ+LHcbFTSpaWq64TDIQr244R0pgsrvUjJiqfzbCQD2E/9Tvu82pvfaQjebepVgl/2l6KvbiTnMOfafmjlrYRdyrbaxsvh4H/gtM9+gzQbpkzg6EyUE/n6/U726o7fSnOmWG0mIpVazJM14GS+af2Z9Gy34cOQATgEqBQaSPM12dOOn6iBJ/dudepdLDC+UWM/eFMZK2qTjTuHEOoiE3efk7xXKcHdCkYd1TCOv2si8e7M725XYa+2z+rvMZ2NptCbnrFziMOtUDO6f+rcR5EBEEDR/gw3NpYGdf+vuktbjnB1aO4Jn0Px8a1NvDq4Ms2xi/zoT91nXNTdQrZ7UgmClw7y5rGedLwNZ53d7xMQA8sqBg0GoiUikjN8gT2VJ5wZ41emDCn7NVXeB/IuirsDrPLYgcdE4qrwn+1Bxx8dEbCeZWbVKbuOBol5OX6umSzdO/ndTldLpsq0p98AdipVwxE3i7HzjM8Ufi8Tot0IzJJftrrzkWM47g7nwefeUwvNe5zOsClxuAomE0vDDqW2o3mjh6EfKfEBtj2D+baz0PEsU/IA5LuTM54H7YjJ1LW9PFJqbo3rs
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(31696002)(86362001)(6916009)(2906002)(316002)(54906003)(8936002)(31686004)(26005)(186003)(2616005)(4326008)(6512007)(66556008)(6486002)(6506007)(66946007)(36756003)(508600001)(8676002)(38100700002)(5660300002)(66476007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?MmJlTzZNTDRwSUQ4VVNzYkk3QU0vU1VkSjM0bWNFWDk5WUlZbHJZTGpDdXN3?=
 =?utf-8?B?R0FHTnNrZXJSSU90Q3E4eHllWEt1NlNiNmJ6c29BMEJXRWVWM3lPcFpUT1Jw?=
 =?utf-8?B?ZjRjTmFIM2MvZG9iZ2dyQTZ2Vk5YTXI2TUR5MlYyMFF5ZXltQnJqY0Fwb1dL?=
 =?utf-8?B?bjV1YzlwMXRZUnBmaVB0WjF6ZE5GRzJrdlBuV01VZEtrbzNmTHgxN2VVRy9E?=
 =?utf-8?B?SjlXa3JURTM1RS8rNHRGSWJvMTlNR3l1RzJtMU8ycUh0cENlcUZWQUd1ajU1?=
 =?utf-8?B?NUVxQ3RlM3IyMnpnd3ByeTZwNVY4blN2UG1hVmYvY0tGSUtuQlprNGd3dlhB?=
 =?utf-8?B?YVhSWHZQTjQzeHZDUzc5S3hpRFQ1Nm9HQzRsTlJoKzZneEMvRndlQ2tGVzRX?=
 =?utf-8?B?SzIxU3I5UXlBa1Fvc04zYzkxdlU1Z3hObEdqUkNTZHJXak5HWUJnVW5PeE1G?=
 =?utf-8?B?SkxiSTdrZzFCNG1VSGV5VTFnMnl1QnppdmMyVlR5b3Z2cnh0bkFVRmxMcXoy?=
 =?utf-8?B?WGE4bXNMTzNGcGtrbjB0SWNCMDV3OEsxcDhSTkphQ2xRNFFVNTFjQlgvMjM3?=
 =?utf-8?B?OVdSTVdkVy9hR2phOUFickpaRjV1Zkk4cVB6K203RWs1K21iOFkzQmJGSVZ3?=
 =?utf-8?B?ayt0Yit0bnhDeU0rNW8xczVOS0JKSHI0dTVnRnBud0xGT0lKSCtZRnJFL2pQ?=
 =?utf-8?B?OEZWTW1Gd2RqSkhYK2x4WUgvSTdXUFNaL2l4UVE3Um5iQVlxajUyajNQVks3?=
 =?utf-8?B?QlNFYTIyaWxDS21kRWlmK1hiT0JtUUVFbXgrU2MvcmFaamhKYjJMR3pWVXJu?=
 =?utf-8?B?OFR2V1dHVUkzTkVRZ1JtZlI2bE50UnE0UG5xWmlyaXp1YjFiRkRhWldiSnJz?=
 =?utf-8?B?aHdjLzJ6NS9wMC9nbmVzbHVURU1QQ1JEeUVvZ1FaVW5OMGlHWFBnRlVMNWJv?=
 =?utf-8?B?bzM2QUliVTJRbU05dEFKNFpCRTdQZTBaeXc2b1RNeHE0T3cyaUlrbnpXdENS?=
 =?utf-8?B?RVJ2dUhpYmhGb2d5SlgxQ3RNZzMxQnkxb3JlUjZuTm1CcjF5ZndTUlR3aGxL?=
 =?utf-8?B?OFlEZWQvVGxqOHNVZUM4cUZpYnNwYXZZTld4VnNENit6SE1qblljejRwN20x?=
 =?utf-8?B?NG5neFFtMkx5MDV5MitILysyU2N5SEhveGV2ekJGdmVsdFBmbTZWaDc2aC82?=
 =?utf-8?B?TE03N3pYWGsrMjVhNit1YlRneFgyWXNkcmthOGlpd0FBSFVxTkxDK0lpYmln?=
 =?utf-8?B?U0pKVXN6dnZWY1BiS0I3ZGlkdHNSdTc5OE1lUTdXaDNDSjExTHlVaXp6bVdt?=
 =?utf-8?B?T0VQcVV6Zm92VW5Rbkh6anpUTzYwbndBM2lnQ0tBUnloTXJzaWQvLzRZbmU1?=
 =?utf-8?B?TnNLUmxlYkJWTThiUWhjKzdHRkkxaHEybHQvRXVYS3l0WEFLQVpoakNuNEI5?=
 =?utf-8?B?NHNXQVloRk9aVkVsME9VSVF3K2E1b29Pbk5ucGdzdUdocHR6bEpGRGNPRHEx?=
 =?utf-8?B?TWhsanRPUU15L2EvRGRaM1M5NUlaYlNjRTh4UjVFMVNlc0NQaCtLc1BSWGZM?=
 =?utf-8?B?NDZ1VEVPcGtoVm0rc21Ia2JQN3REc2RQdU4xOTJqVm5vZ3gzOUpuakJvVFNR?=
 =?utf-8?B?a3dsQkxnbUo5MXRKcXMyWktXUnFXT1lKUmEwQmhiYitnOXBkcEJpUVRFaUxQ?=
 =?utf-8?B?MWprdjZtdTJYdHpKaHZaSnRoVUU5c2o2ckRCc3pHdDVsWDFUOHpPN3FNM05n?=
 =?utf-8?B?Vm1LWVdaVFFqWERHMjkvbzljS1N1dzRUTlNjUW9vc2Q3cDlaam9kNkNQUzJZ?=
 =?utf-8?B?eTJET3lKL1lMenZYTCtGWHpSR3Q3alpBdFVMdUVFbmZEUDZrWHh4R1BTZ2hN?=
 =?utf-8?B?V2EreHZXNm94bytVTW9iaVFFR1hYOHd6K2hlYmZObDV5Qm54Ym12dk1UYkFM?=
 =?utf-8?B?RXIzby90UnFkSDlnNmNTOHR0aVBINkxNOXNXTzBmaHI3bzRBWlhrdURmQ3Ni?=
 =?utf-8?B?dDZjRmtYZCtGWVhIYWhTY0FxZHdOYjlQRnZkTnczSUlHSHQ5Z0pzMnRHazZ1?=
 =?utf-8?B?NDZ2RkpISWVsaklaeWJjSW9jVTFOOEp4SEJvQ3J4amhKaDVhWmhWdmlyZHhx?=
 =?utf-8?B?YkZtbGJUOERSUzIwc1BLb2g4QmRiL3lObGlIWmJxUXV1bmg2QWZqNUVWYjBK?=
 =?utf-8?Q?No7Rmj+VGG7/7498iDZYbvM=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 80afe333-36c1-45b7-7170-08d9f6b52ea2
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2022 10:13:48.2953
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lCSPMnGN90FqVsojaQuh7oCjVREzxu6IoC6UjpwOSUf2mgf7r8W1bRUUPJRtjp+hTKA6MmlCICU4mVEReOPbwA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR0402MB3944

As noted in the context of 3330013e6739 ("VT-d / x86: re-arrange cache
syncing"): While cache_writeback() has the SFENCE on the correct side of
CLFLUSHOPT, flush_area_local() doesn't. While I can't prove it due to
lacking a copy of the old SDM version, I can only assume this placement
was a result of what had been described there originally. In any event
recent versions of the SDM hve been telling us otherwise.

For AMD (and Hygon, albeit there it's benign, since all their CPUs are
expected to support CLFLUSHOPT) the situation is more complex: MFENCE is
needed ahead and/or after CLFLUSH when the CPU doesn't also support
CLFLUSHOPT. (It's "and" in our case, as we cannot know what the caller's
needs are.)

Fixes: 623c720fc8da3 ("x86: use CLFLUSHOPT when available")
Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/arch/x86/cpu/common.c
+++ b/xen/arch/x86/cpu/common.c
@@ -346,9 +346,14 @@ void __init early_cpu_init(void)
 	       c->x86_model, c->x86_model, c->x86_mask, eax);
 
 	if (c->cpuid_level >= 7)
-		cpuid_count(7, 0, &eax, &ebx,
+		cpuid_count(7, 0, &eax,
+                            &c->x86_capability[FEATURESET_7b0],
                             &c->x86_capability[FEATURESET_7c0], &edx);
 
+	if (!(c->x86_vendor & (X86_VENDOR_AMD | X86_VENDOR_HYGON)) ||
+	    cpu_has(c, X86_FEATURE_CLFLUSHOPT))
+		setup_force_cpu_cap(X86_FEATURE_CLFLUSH_NO_MFENCE);
+
 	eax = cpuid_eax(0x80000000);
 	if ((eax >> 16) == 0x8000 && eax >= 0x80000008) {
 		ebx = eax >= 0x8000001f ? cpuid_ebx(0x8000001f) : 0;
--- a/xen/arch/x86/flushtlb.c
+++ b/xen/arch/x86/flushtlb.c
@@ -245,12 +245,15 @@ unsigned int flush_area_local(const void
              c->x86_clflush_size && c->x86_cache_size && sz &&
              ((sz >> 10) < c->x86_cache_size) )
         {
-            alternative("", "sfence", X86_FEATURE_CLFLUSHOPT);
+            alternative("mfence", , X86_FEATURE_CLFLUSH_NO_MFENCE);
             for ( i = 0; i < sz; i += c->x86_clflush_size )
                 alternative_input("ds; clflush %0",
                                   "data16 clflush %0",      /* clflushopt */
                                   X86_FEATURE_CLFLUSHOPT,
                                   "m" (((const char *)va)[i]));
+            alternative_2("mfence",
+                          , X86_FEATURE_CLFLUSH_NO_MFENCE,
+                          "sfence", X86_FEATURE_CLFLUSHOPT);
             flags &= ~FLUSH_CACHE;
         }
         else
@@ -274,6 +277,8 @@ void cache_writeback(const void *addr, u
     unsigned int clflush_size = current_cpu_data.x86_clflush_size ?: 16;
     const void *end = addr + size;
 
+    alternative("mfence", , X86_FEATURE_CLFLUSH_NO_MFENCE);
+
     addr -= (unsigned long)addr & (clflush_size - 1);
     for ( ; addr < end; addr += clflush_size )
     {
--- a/xen/arch/x86/include/asm/cpufeatures.h
+++ b/xen/arch/x86/include/asm/cpufeatures.h
@@ -24,7 +24,7 @@ XEN_CPUFEATURE(APERFMPERF,        X86_SY
 XEN_CPUFEATURE(MFENCE_RDTSC,      X86_SYNTH( 9)) /* MFENCE synchronizes RDTSC */
 XEN_CPUFEATURE(XEN_SMEP,          X86_SYNTH(10)) /* SMEP gets used by Xen itself */
 XEN_CPUFEATURE(XEN_SMAP,          X86_SYNTH(11)) /* SMAP gets used by Xen itself */
-/* Bit 12 - unused. */
+XEN_CPUFEATURE(CLFLUSH_NO_MFENCE, X86_SYNTH(12)) /* No MFENCE needed to serialize CLFLUSH */
 XEN_CPUFEATURE(IND_THUNK_LFENCE,  X86_SYNTH(13)) /* Use IND_THUNK_LFENCE */
 XEN_CPUFEATURE(IND_THUNK_JMP,     X86_SYNTH(14)) /* Use IND_THUNK_JMP */
 XEN_CPUFEATURE(SC_NO_BRANCH_HARDEN, X86_SYNTH(15)) /* (Disable) Conditional branch hardening */



From xen-devel-bounces@lists.xenproject.org Wed Feb 23 10:25:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 23 Feb 2022 10:25:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277285.473730 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMopo-0008N1-DB; Wed, 23 Feb 2022 10:25:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277285.473730; Wed, 23 Feb 2022 10:25:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMopo-0008Mu-7d; Wed, 23 Feb 2022 10:25:24 +0000
Received: by outflank-mailman (input) for mailman id 277285;
 Wed, 23 Feb 2022 10:25:23 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=DZ7u=TG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nMopn-0008Mo-Dt
 for xen-devel@lists.xenproject.org; Wed, 23 Feb 2022 10:25:23 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e78129c4-9492-11ec-8eb8-a37418f5ba1a;
 Wed, 23 Feb 2022 11:25:21 +0100 (CET)
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2058.outbound.protection.outlook.com [104.47.2.58]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-10-wCpIZxJYPzevN5BJVaAoWQ-1; Wed, 23 Feb 2022 11:25:19 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM5PR0401MB2451.eurprd04.prod.outlook.com (2603:10a6:203:36::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Wed, 23 Feb
 2022 10:25:18 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.022; Wed, 23 Feb 2022
 10:25:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e78129c4-9492-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645611921;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=uyq5jRdiVF1X+9pbX0NPbLU4H6z7c+4VAkBhIZM4KEA=;
	b=Kjzjn0KfcQNSWF6DjMNmVrcijDCHwORuKHbkjimoRqauucRB7vIKKTdmfYWQC2bl2XY8aA
	pumDhaI0194UEwsSXypKs5HRVViiJjGU70v8F3ZBKIdccRdGJmtVaOMVNRosovNTGYY1kT
	zSZDLfwRzL7+WdgKZ+fM2+S339UakLI=
X-MC-Unique: wCpIZxJYPzevN5BJVaAoWQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=dgBy7Vic4U/GQSnsXjBhdVHnh6VZ0jdCuYbIraSKnT29AJmQEjRGIQYQfO2P8rgUcXNqekZOKEZh1e4LuTehUHMlJ2hWNJlhIFASCUn1ZkOYILbzxI1IEH/xmXCLTsYprPv7BDjMcBu4Js3SiyfhOksfWKB1gxh5sz5ZpsD7CupMc0R1nxhz4gMsIODbEJRxQL6W5+F6AiCvWr+crnT/51wSEBTKy90sSD24Krrv78Av4lD69qvk195xoc2JUXZvtTXsmkDapf5/S9DCs6AkxHbcXkDAJIfs3Z/M8dKI/4Ha1eWNj2OCGFpoK5zNh783c/5T7RCjT/wkr3y0xqU32g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=uyq5jRdiVF1X+9pbX0NPbLU4H6z7c+4VAkBhIZM4KEA=;
 b=VkeRRzgnQ8lPys55FEObCuqGdJli9uv0tzq4OH6xioOS3WvBsvV7jl1+ZKLsvUSVxt8Az8GH8Ao9PGRs5w6oN4BSy4G+fECxvU8v+S40E178iDuaNpauvHdUGpQghK5cgUxZ8csLXf38hnAeD4alEMVbc0hSdxjUIXix/UjRLmlEo1o4a7vMBji/EGQdaUNOC3E9Ay6xC5Drb/bx45P3aqL4h7aA8+qumEiombwU+uv5fZvzsz7w3kVmYhNe7B75aXaBAr/Mb8KDo4U7MV4C0i/4+yM0XUE5SjAEkSCBxZUnTc69CwcMFeeB6Dqhz+dSvhmZ2AixQdpe/50QqpdC5A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <fab0ba40-9840-9bde-e4da-822d797985f1@suse.com>
Date: Wed, 23 Feb 2022 11:25:15 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v3 29/70] xen/misc: CFI hardening
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
References: <20220222152645.8844-1-andrew.cooper3@citrix.com>
 <20220222152645.8844-10-andrew.cooper3@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220222152645.8844-10-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0701CA0059.eurprd07.prod.outlook.com
 (2603:10a6:203:2::21) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a9f338c5-4952-4747-fdee-08d9f6b6c9bf
X-MS-TrafficTypeDiagnostic: AM5PR0401MB2451:EE_
X-Microsoft-Antispam-PRVS:
	<AM5PR0401MB24511B8761A0B8F63E3BE3ADB33C9@AM5PR0401MB2451.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ctKIdqfoav6/IVhzJiQkvrm4G1/gxl7842Zgpl0HPz7jfaKqn+ffSDpgkxE/8nlrQe4CTnZPBNIhY3qLvzxf+9zF7NGpIz5yewrIvxk+lxS8jm85YbCFDtBoVcM9W/9doNtPvBNgg6C30XNaZ6FJXaCpJ1TavakXJ7TDj9HSlhO/MgMt2noXIi5hUvbDIEMB6T/noF+BRr+RRxif5Cr2BwAG6Q3jvIzpsJ2V4/z/Xq8Ozf3goKDGMhMC9QzFQUSL0YSAf/904x/48BQwMpkEy8NhEa2R3jJLBM+M/B6935oOjP46zwbuqmxDBs18p4U8Z8GwxPfXlN0kBeZIgrws5YUhyPk4WhoJUgkLjlJky9JJ3qGufL4fTR0wEk8APRPi9x/FKM5UjMyBvrjnnZjeeAp49R5MqB/ElXXDDtXyhYUXJSrPlwqAzkQg1M9p7yvcA6sR6tw9G+cX1ET5ahw6HwgYIq+ge6vYKEPsIdGWiHnN/MexE60rX2wbbNK5RCjRQ3b6dSE2MG/dVG0fTkLl2M0KX9RtHxQz9LxX4iHYpmsTEuQMRji+tlAPK148KPHOynhHEhjw+HYGfpQw1ERUgEnoFBzBH1Mg0Bkre90WeFzHoMOLVwwHSx43hWqqkoNnCBVZDzCpYru6Gd4115zsBy/eW/Qqs/a4qjP7EMqmT9v7m7dmtOGAl8Pg8A1b/baXIc9kQRzyuo7F361h+zXmdKfelJ5LUddN/lv+QUXMJNsfjuA/gQL7c13pN8xZNtEh
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(31696002)(5660300002)(4744005)(38100700002)(8936002)(86362001)(316002)(4326008)(8676002)(6916009)(508600001)(66476007)(66946007)(66556008)(53546011)(36756003)(31686004)(6666004)(6506007)(6512007)(26005)(2616005)(186003)(2906002)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Q3dVbkpUdU1oMk5vSEM2QWlVZTE2eldjU05uZTRqSC81ajc5KzdEL1B2UzVJ?=
 =?utf-8?B?REkwUlR0Wmg0MDQ2c2tOQXRFbHgyYkVwVWV0ZkZLNjJEbi90b1FZeEpsTE9Z?=
 =?utf-8?B?VWEwU2U4WkQ1bzZONVNjOFhKRENUclRYajdPNWVRZTdhS0I1UDZhRmFNTjQy?=
 =?utf-8?B?aTF1eTdqMUZ5OWQzVlNKdjUremZKY2xxR1NvZFMwYVNQeGhuTkVLU0lZb29U?=
 =?utf-8?B?VmV2V0NqaE0zWThrV0JBYzluQU1LN01HZ05BS2ZpRExOWWI4VmVmMnFSaTRJ?=
 =?utf-8?B?czZEbVFkQVlSTGsrZ3Y0bnptWG5aU3hYSHhpTFVRK2pQS1p3Wlhndm9RN3FT?=
 =?utf-8?B?a0JSU2RralAxSG4yV2R4ZXJFQldEbmswczlFSDBkL210ZmIzeVFMdWdpUnhG?=
 =?utf-8?B?MGtTSzdodkxTUGd0ZEhpRzJScDVVUHRSaVlaVTBJdU9tOXFSZkU0YmVLWGcw?=
 =?utf-8?B?TlBmbVV4QitsNHVnTWNGNVJNR04vYzd3RjdOdVI2eDlIS0FKcS9tU2NIQnBW?=
 =?utf-8?B?cWtrYzhnM250clRqUEtOVFl0OERnZ2J5bW9CTXorQTdmd1BtTm1ZVWNaWmVP?=
 =?utf-8?B?eWR4S2hEZUxWMytyNVh6dHIxQ3d4eWdIMnJSaVZqLzhjc1dPTXJ4cUJuY05O?=
 =?utf-8?B?MlVtbSt2UWZhQTNNTm9sYkxXcWZKSUlNNFVOOEFUTnYxbGVvR0xkdGZ4NnBk?=
 =?utf-8?B?WjR4UTZ2aTUvOHp0RGZVZCttM1kwd3E0NmhXTWpZTDJaQU5EdUVBQmdPWnps?=
 =?utf-8?B?QUI4ODByRTVmYXFzYkVDRTlXR056cStlbGwrYkorV2p1dnF4Ull2Y25mNytJ?=
 =?utf-8?B?bG1LOEd3YjFzS3dJTDdHNVRCNW9hV0NaNkgzS3V5NEQ5SFJNUDkxN3lGTlFE?=
 =?utf-8?B?QzVQRnJuQlZ6ajMzSVJsOHhjNFZybmJ1WkN6V042STJQQ0RsTTk1WmtMNjdp?=
 =?utf-8?B?eUJMTzhmOVdoK1Q4MWIreDl2QVhlYVg3UGJOc0tRWjJGMFlEM3lnYVdHeGRu?=
 =?utf-8?B?R1RrVmVoU2Nid2N1Yys4ZlQ4R1ptZ3pLendObEZoNGdIMEJENE83bE9ZZTNR?=
 =?utf-8?B?cVBnb1dNcGVsZUtjam9Eb0EwSlowUDhVWWx0V3U5VTNyR2RYdTVjT3dDTDFV?=
 =?utf-8?B?QTRRcDJtdHhzTkRoQTJMUFJ3S29BTkYyR3pJU1F3bE5kZ1hncnZuRmhxcG54?=
 =?utf-8?B?QXh3bXNRdktFU1FPUWpDWW1Lb01iczJMZ2FSdzBMZFFtbkhYMUtuN1IvMjdn?=
 =?utf-8?B?NlJydUNuWEUwT2x6QlBrbEJHOVlaZUNINXB6UkhDanBhUlZIZGYxd3IwYUZU?=
 =?utf-8?B?dTB5R01Xa05LNWt4SzZSZ2xYVkZRa3lYZUJINVJoRnhPRDRXN1hkc1lYMDNH?=
 =?utf-8?B?N1U1enB5OXdOcnczMUFDb0VOTENzTHQ4UHh3eWpZcjNlaWdBY3ZKZUVkaG5C?=
 =?utf-8?B?Y2hnWkdVV1FLa2FqWnlmVTdSZXgrRnRCN2pOMWR4M01YR3VwT0J3UnRKZzFj?=
 =?utf-8?B?WityYjg0UzQybGVMT1VWVTlzUzJLV2owVllIK2dLNFVJeWtDdFFtNHVmQnJO?=
 =?utf-8?B?S2RjeCs0T3FRdDFNKzdEZjJqbHdpaVc3VDNybmowcWtXZ3d3VkNqOXlCcXA0?=
 =?utf-8?B?enJwUzNHS0N4ME9tVmhUMURXaWNkTjlseStnV0poOVBsMWNkZjRJeVIvc2pB?=
 =?utf-8?B?Vy9ESmljNUUzNFduVk0wMHo2eWVUN1Mrc0xOWVZ1QTNTT2JtK1pUaGZramFE?=
 =?utf-8?B?bzBibVR0M2ozeXVMSHRjYkxqeDdZZGlmZmhGMXNjUGVkckd3Smo1WFhIdnlE?=
 =?utf-8?B?Z3E2RUliN3ZwVDFLZ3pvMUJ6M2xDMmFkNVNzcEVHd0s0OTA4b1RVcHZoZXBm?=
 =?utf-8?B?MmlWclA4ZmhHcHgyWndjd3lkMWRUTXFwR0V2T204ZWhmdVh3YnhKclpqNHU3?=
 =?utf-8?B?b2VRbXB3QWEwZm9TTDlyTzVWRWlQeEgzYUhxcGRVQWtWSmtxdlMyRlJDdEt1?=
 =?utf-8?B?TDJFU2lYdmVEN1AreHgzd2tsV2FkaUtTZjdKd01ZaHlwcnJGeFlacXZjWTFp?=
 =?utf-8?B?RE9US25WOXZYOEN2citOOWVZYktXUE43L0ZDRWtVeVpwbWcxUzR2QnJHYk9M?=
 =?utf-8?B?NWdEelAyYnFYYUxURWtmVjFnZElVZ3pVbHlTYldleVBkQTV0djc4TFFhS1Bs?=
 =?utf-8?Q?GKBS01Qso8tXvS4AWyPMoyk=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a9f338c5-4952-4747-fdee-08d9f6b6c9bf
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2022 10:25:18.1262
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gElPREU+4jauy5RjKrxpmKNnqzGAc0RhKiw3eRhLWRotaZYHss+PeZjtc0jqd2kYf7bMMEdRC+YaAHRASCt5kw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0401MB2451

On 22.02.2022 16:26, Andrew Cooper wrote:
> Control Flow Integrity schemes use toolchain and optionally hardware support
> to help protect against call/jump/return oriented programming attacks.
> 
> Use cf_check to annotate function pointer targets for the toolchain.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Acked-by: Jan Beulich <jbeulich@suse.com>
> ---
> v3
>  * Annotations for gcov

Hmm, ...

> ---
>  xen/arch/x86/mm.c                        | 6 ++++--
>  xen/arch/x86/setup.c                     | 4 ++--
>  xen/common/coverage/gcov.c               | 8 ++++----

... what about llvm.c then?

Jan



From xen-devel-bounces@lists.xenproject.org Wed Feb 23 10:34:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 23 Feb 2022 10:34:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277292.473739 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMoyP-0001Mf-9a; Wed, 23 Feb 2022 10:34:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277292.473739; Wed, 23 Feb 2022 10:34:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMoyP-0001MY-5z; Wed, 23 Feb 2022 10:34:17 +0000
Received: by outflank-mailman (input) for mailman id 277292;
 Wed, 23 Feb 2022 10:34:16 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=PMTg=TG=citrix.com=prvs=046033a78=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nMoyO-0001MS-9J
 for xen-devel@lists.xenproject.org; Wed, 23 Feb 2022 10:34:16 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2490e881-9494-11ec-8eb8-a37418f5ba1a;
 Wed, 23 Feb 2022 11:34:14 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2490e881-9494-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645612454;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=xnBbGmMvvqr742lxz/97xnbS6iPLtn5CQAdCTkMymAM=;
  b=G+q0qJQAXogOoI1uMIBRf0O3+B/y34xmQ7zSDOEV7qDVwE0Z3zJ//x/a
   UmFB4DU0wms2S2nakUgsOZAd5CGueHZJ1UvXqyG6tHBbXzQE3OrtKsC8o
   wtKE+Hk9B3BAA9gDTc39fp/w3azvlL0PUJb7gymZRBsCe4UYBS3DK3xfq
   Y=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 64689618
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:HjR5WK2aQ5YQX+NL+PbD5d1xkn2cJEfYwER7XKvMYLTBsI5bpzIBn
 2obUGiHa/fZazfyLtFwbo/jo0kPuJXQzd5lTwZspC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk0GE/NtTo5w7Rj2tQy2oDga++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /10uJiyZgsEL5HBs8Y5TSlDE2ZsfrV/reqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHCOo8Ft24m5jbeFfs8GrjIQrnQ5M8e1zA17ixLNaiCO
 ZpIN2M/BPjGSzIVO1kzUoJ9oPWXvVbAai1mknG0rKVitgA/yyQuieOwYbI5YOeiVchT20qVu
 G/C12D4GQ0BcsySzyKf9XChjfOJmjn0MKoQHrCl8v9hgHWI23ceThYRUDOGTeKR0xDkHYgFc
 gpNp3Ro/fNaGFGXosfVZhC8olGIkw8gVvFyN/MK8wHK2OnM2lPMboQbdQJpZNsjvc4wYDUl0
 F6Vgt/kbQBSXK2ppWG1renN827rUcQBBSpbPHJfE1NZizX2iNxr1nryosBf/LlZZzEfMRX52
 Hi0oSc3nN3/ZuZbhvzgrTgrb99Bz6UlrzLZBC2KBgpJDSsjPeZJgrBED3CBsZ6sy67DEzG8U
 IAswZT20Qz3JcjleNaxaOsMBqq1wP2OLSfRh1Vid7F4qWjwpiP9JdAKvG4uTKuMDiriUWW1C
 KM0kVkMjKK/wVPwNfMnC25PI55CIVfc+STNCamPM4smjmlZfw6b5iB+DXN8LEi2+HXAZZoXY
 M/BGe71VC5yIf0+kFKeGrdMuZd2l3tW7T6CGvjGI+GPjOP2iIi9EuxebjNjr4kRscu5neki2
 4wBb5DTk00HCoUToED/qOYuELzDFlBibbjeoM1LbO+TZA1gHWAqEfjKxr09PYdimsxoei3gp
 BlRhmcwJILDuED6
IronPort-HdrOrdr: A9a23:bhHi0q7Ds+Cu1CcV1QPXwWaBI+orL9Y04lQ7vn2ZFiY7TiXIra
 yTdaoguCMc0AxhJU3Jmbi7Scy9qeu1z+873WBjB8bfYOCAghrnEGgC1/qv/9SEIUPDH4FmpN
 5dmsRFeb7N5B1B/LzHCWqDYpcdKbu8gdiVbI7lph8HJ2ALV0gj1XYDNu/yKDwseOAsP+tcKH
 Po3Lsgm9PWQwVxUi3UPAhmY8Hz4/nw0L72ax8PABAqrCOUiymz1bL8Gx+Emj8DTjJm294ZgC
 j4uj28wp/mn+Cwyxfa2WOWxY9RgsHdxtxKA9HJotQJKw/rlh2jaO1aKv6/VXEO0aOSAWQR4Z
 3xSiQbToNOArTqDyeISC7WqkzdOfAVmibfIBGj8CPeSIfCNU0H4oJ69Pxkm13imhAdVZhHod
 J2NyjyjesnMTrQ2Cv6/NTGTBdsiw69pmcji/caizhFXZIZc6I5l/1VwKp5KuZIIMvB0vFuLA
 CuNrCp2N9GNVeBK3zJtGhmx9KhGnw1AxedW0AH/siYySJfknx1x1YRgJV3pAZMyLstD51fo+
 jUOKVhk79DCscQcKJmHe8EBc+6EHbETx7AOH+bZV7nCKYEMXTQrIOf2sR+2Mi6PJgTiJcikp
 XIV11V8WY0ZkL1EMWLmIZG9xjcKV/NKwgFCvsukKSRloeMNoYDaxfzO2zGu/HQ1skiPg==
X-IronPort-AV: E=Sophos;i="5.88,390,1635220800"; 
   d="scan'208";a="64689618"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=CInNwboxKGQAgv85lCnk9GuOlRPG89bHzvum3nqG3hwgUTogHysNVKiuEH0+sgKh/c4vzhoaxreCEC/xowlWZCzbqhJtQN0M27bUvyqdgrprCb9L6T6KROOql8rdaTvX8hc1Emp3aZI39pgv5Bcq7bYxVKKq90sOiZmCwOCjS3qQH8+QAQeK2vq70k+Xqc+uP2g0H8z4GJBjrI4vgXehhqqx/+y+Dknq5uSAmUhuVix6wG0mWBBowcmKBa/G6ykvGEjnM+TLrnW+wIurvIIn0yCtg2igD1mXKqEZdh64v4hBZ2bl7wLFmMviQZGdEcAlrn1pDU1nhqNDOgC4m83lpw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=xnBbGmMvvqr742lxz/97xnbS6iPLtn5CQAdCTkMymAM=;
 b=faj6XOSIDPsLlcHe/zAfD/ajhqROA4UUbUeZfI5Hs6nRKNzDYw3DYyHfnabXT3uHxE7/4qTG35bYVIutn1AgmfDwzSaOf0qr7kY+Q6fBIWsugImN7qVSRqwT2hrEydnKU9u+OQXQpajhRxWwb6QFXQESUsLgmeSul1i3UuJYSCalDX/DdC/FBTAMbXjbGd6d+HpMiHl9Ep4uV0LNPXeYK1+xDhQkB5Xqko3iQc5nFI3kZjhMmoy5rOswkI4M5SUOH2i8U0ECE7CJe/e1ww+VGMFtVnaV30bG1e0nH0zC4JJHsGXt65aN3AxWce2w07gt9C6OmJLdT+ybjRV8ZAhiMQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=xnBbGmMvvqr742lxz/97xnbS6iPLtn5CQAdCTkMymAM=;
 b=nDqeHj0MLWNXHVL6ZTsOKCqw2bjUh90MoDk8+brbD1RffYqGTFiZEEJaZmY+MWYo4bJpT2p0IHR9mQB/uR44NvgZ5pFusD+BlIeLA3bKwm4mdeTL8akwAI4HqafLR/PAEyH3eSJe+c6KuGP3LPw/NuVM4vembLDl2NzYbqlxROs=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v3 29/70] xen/misc: CFI hardening
Thread-Topic: [PATCH v3 29/70] xen/misc: CFI hardening
Thread-Index: AQHYKAC1Wg3VwzQSaUqtYiPtXsy9Payg70mAgAACdoA=
Date: Wed, 23 Feb 2022 10:34:04 +0000
Message-ID: <8b28c6e2-c953-5693-a198-27f013ceb347@citrix.com>
References: <20220222152645.8844-1-andrew.cooper3@citrix.com>
 <20220222152645.8844-10-andrew.cooper3@citrix.com>
 <fab0ba40-9840-9bde-e4da-822d797985f1@suse.com>
In-Reply-To: <fab0ba40-9840-9bde-e4da-822d797985f1@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: a3cab140-fd76-4f4e-1e69-08d9f6b80394
x-ms-traffictypediagnostic: SA0PR03MB5452:EE_
x-microsoft-antispam-prvs: <SA0PR03MB54525424C6A2878473CA5915BA3C9@SA0PR03MB5452.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: sbpkxrOGSvJvL+Tn+PGtkjm9cNneUaa6FEjiMvjEZAKAthVshWOPYwaoXb7qiCyIDG3NAXswmiKEeqOu3oxWX7VtR9FSkaKLttW3FFFZrer51aULCY5u0Nx24nS5fijtJlythD3Eed7b07LrwcSVtC62r8ifof0VvlmFb4h2W1Y91vAz9TXF4qPhpMLY6L9O7kPA0CEQtq6VljD6UtkW+3mon9czCydoI1bTqwaLBR9GdzlU3BQtB9YKQ3cyuJNiNdLHMBvijIaz2IZQy6BneaQblRJqiMACLbNEjeZdq/OwE3kcp/sUVYq1NOrDlBR9gmDCzK8+pff687ytmNVyU1pa/cEPKnuxO9ZuMd+52zY1AXLIa+588cSq/0b5eVx8AUg/eeX/uw6Ue69aoTxfbr3k/haFr9ps9G//IOPuWMyM/TdUiRJeYSIBkBWdRpikmdmCnspW+75fI3FHQWiLiZsKXDuPPJq8B70G07ac/esEyMMSYEpBYFALQvgLO5e3mAoa/A9tkhJp8yqy5b/GV3ecLT4cmEEczRAOvvYWQWqcurD0loQDuFyUo6DCxbsgjtM+tR30kI/u58BOBEE79dx6KfCBUYQ+DPOb4udDofNF/VBOQWPv922i7PBr/5w8n5I67yAAre39JaDAv3tJ+QZavUTFubtJy9o/C4qNtLzrCuJZ4hl46NXp3rYx0tz263LmOgWuVtQRpLpSvgF9ZLjnoMO+6rEr6pO5cARHB8d8btESiTygIB/tg1jGmDkvH/9Mv16S37bZTZlCnkV/Xw==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66476007)(6486002)(66556008)(186003)(31696002)(8676002)(26005)(4326008)(122000001)(6916009)(316002)(86362001)(91956017)(66946007)(64756008)(76116006)(2616005)(71200400001)(66446008)(508600001)(82960400001)(36756003)(5660300002)(6512007)(6506007)(53546011)(38070700005)(38100700002)(31686004)(2906002)(4744005)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?aFF2MXl2R01RelI4dUpNK1lYSmQ1WVlISEF4eUtaakV6M05iTHJzUHFuUHJr?=
 =?utf-8?B?akcrM1Q1S2J6U1FSdkdwNUhVZUZkWGM1bUYzbEVSNm5yb2VTR3dOYzZrTEtM?=
 =?utf-8?B?RDl3TGx4azR1U3RFWjF6WHV1TVRtbGVxMG52bVFxb3BlSmhmMXVscmhYa3Fj?=
 =?utf-8?B?SXA1VnpZOHFlL1JkU3MwR245YjBHc09SZDBrVEV2NXpvRDRpT01idXpKVFRj?=
 =?utf-8?B?VEZuYnBDUS9IMGlUV2pTWlc4R2lQS2lyTVJKTU1UN2VsTDA5anlvNElnbno2?=
 =?utf-8?B?UjEwNDhhNTRlWkMwTGJpSWhvcTM3eml5MWt3THVldmlqNGlXa3gxTFRnaldW?=
 =?utf-8?B?RGhNQkowLzJhOUFzZTJrRzBLZ1pDWkY5b0p0eTBVMklxK2s2ZWlEZVE0bzM0?=
 =?utf-8?B?dE12cVU1YWNhbndEcHk2NUNJS2ZNeS9UOE9DRmhKTHp6SnNHd0Y1RU9XNWc4?=
 =?utf-8?B?NUs3VVc2elpsSTQzQ0FRUzRlZWR4SndYOENBTDdxM0dBVVR1eUZUWlMzeG94?=
 =?utf-8?B?MFFFZ0lhUktCc2VraEtSUGxSKzlqZEltaGh5a01nY09uN2o0YXFQVXdUWVZ1?=
 =?utf-8?B?eUNLOS9jS2tiZjcwSjhRUFJDYUxtcEo0eUlCZ3NMTXF5dXRRUHZneXF2dVZv?=
 =?utf-8?B?V2lPYmtOdGJSRnh3NEgxZ2JMdWxsVUw5cWs4VGpFU0o0ZHoxekt1U3FsZHBK?=
 =?utf-8?B?YnAvZ1dtTkRWZlIxTG5xYkhSVDNvRy82ZGgzemtwcWVyTnI2eCsxamwyZHVV?=
 =?utf-8?B?Q3FPVWlhNGx0RnRJb1FWd3ppTm43d2FiK0doL2tUUEQ3dnpTYkpPWWJrZm1j?=
 =?utf-8?B?V1EzUEpoYnpkZTVVckUwanFoSTZ0bUphWmV1WkVueERkZVVobGxEWXd0QVlY?=
 =?utf-8?B?S1VLV2V3SGFqYkZQbWRCN0owT28ydjJSb1pFa09PbHdMcTkzRHlYajNuaHpB?=
 =?utf-8?B?ckdRcG5TUVN1VTgrTTEwem5QY0ZNY0RJWWtEOHpJV2gwSGt6K0hCSnc1eURv?=
 =?utf-8?B?N25JQkFqNTNDWEpJM0dqUGRJYnJST2YyL293K1czLzdLZnZsL3BiS3dIUHJW?=
 =?utf-8?B?ZzRjYXpSQXViYkltQ1NUV2VZMlpndHd4d3J3ODBpcm9VcXFhQjFxZEJQbjVP?=
 =?utf-8?B?QnB5SURhVHZ5eURYY0N3YS94a1pQQUdNcy9TM1NsQ2hjVHhKSmk5emhMRUVW?=
 =?utf-8?B?dVVvVFN6cXk0NDVaZFNMM3o5Q0dFVW1RWXU1eEhyaG1tY3g2MG8weTRSekt0?=
 =?utf-8?B?aUFaaXg2WGxoWSttTDJYa3RtZzV1cmZXVmpxNm5tVXg4L0s1WlFqV3hVL1dk?=
 =?utf-8?B?MjhJREpkTWRmQms3UUtSMmNrOXhacWt3M2hpeGdRQVNtZUh1MGVLU0RNMDhv?=
 =?utf-8?B?a2pQbkg4clpGNkpVSGNNbExkb1NpU1ZBZlpoUTJORUMyQlJoM0FUMHA3QzdO?=
 =?utf-8?B?djYzZWpQaC9HSnNadUdlSzJseFBrRVZyRlc5eHcxUDJ4WXUxYm9VTW9CQXhY?=
 =?utf-8?B?R0prQkorbSs0bm0xd3N2V3dnMnI0a3VKbjRUM1dwOVpSdk95TWdBZ1FieDhF?=
 =?utf-8?B?VUs0TC9uVlQrSmVkZFV5U1oxVXYvOFpON1p2U3EydW9FRE4raHVzaEJXODJU?=
 =?utf-8?B?VG5jL3I3eHRNY3BPQVdrN0lPREZRcWx4TzJZeEFPdFFkWDVNSitPSzBqOUxk?=
 =?utf-8?B?cENBeDVPaTg1MUw5cERIN3lZclhNVXg3RnRvUWppVGNEcDloZStKcjhtUExQ?=
 =?utf-8?B?bWxXT3pCcXhKMXRIRUs1WkgrZDNEaFhlcTRlM1VHUW1YUmFBTU1wRUJZVGhj?=
 =?utf-8?B?UEd4NGN6WU5nenN5UGJDYkRLVUdzNHVTSGdWTWJjSWlDTWU5WURpbUVxNnYy?=
 =?utf-8?B?Z1J4RnNqSFZFTE9MQWNIZVpIM0lGZUMzdS9GSis5M0JiQ3B2a2Q2YkhvSFNa?=
 =?utf-8?B?NkVmQXpGcFhtOVl3VDdseWxDQ0R5WU9Wd0xkQ3lIVkNrUVd2NldMTXZRQTJM?=
 =?utf-8?B?SWNqQU9nS0QwcU5yU0hSK2NqK3BGeGJFZzgzSzFpZldpaVZzdkhqQlZCd3dH?=
 =?utf-8?B?RmwrMlplT09FTW5RUFJGY2JaQ0I1aDZnTDd2MUdCYjk2V3BYdXgzenIwbFl2?=
 =?utf-8?B?ejd5K3B0NW91RTJaL1NLdGlqVktnTjJEc1M5Q0FnTW5ja3M2dDlDWkFmalZW?=
 =?utf-8?B?Z1Rkd0FsOVdEa2FMZThpeFJzaFlXNWQzUnkwUXBMbnZDRFcvVUFoc0llbENi?=
 =?utf-8?B?VzJ4WExUdmVTTkRvcUloRDhteGNRPT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <55ECE487850C324494F2D24570457999@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a3cab140-fd76-4f4e-1e69-08d9f6b80394
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Feb 2022 10:34:04.3464
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Tv2wX1s4AhmoaZrXCMHBSSXhAzE4LsulzH27g5rL38dv1CgE2p0FD7vBXfGFt0gJM926SRjH8qgPe3q36DXuIFN4AkYFvPlHopTkofqgEkQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR03MB5452
X-OriginatorOrg: citrix.com

T24gMjMvMDIvMjAyMiAxMDoyNSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDIyLjAyLjIwMjIg
MTY6MjYsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBDb250cm9sIEZsb3cgSW50ZWdyaXR5IHNj
aGVtZXMgdXNlIHRvb2xjaGFpbiBhbmQgb3B0aW9uYWxseSBoYXJkd2FyZSBzdXBwb3J0DQo+PiB0
byBoZWxwIHByb3RlY3QgYWdhaW5zdCBjYWxsL2p1bXAvcmV0dXJuIG9yaWVudGVkIHByb2dyYW1t
aW5nIGF0dGFja3MuDQo+Pg0KPj4gVXNlIGNmX2NoZWNrIHRvIGFubm90YXRlIGZ1bmN0aW9uIHBv
aW50ZXIgdGFyZ2V0cyBmb3IgdGhlIHRvb2xjaGFpbi4NCj4+DQo+PiBTaWduZWQtb2ZmLWJ5OiBB
bmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPg0KPj4gQWNrZWQtYnk6IEph
biBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4+IC0tLQ0KPj4gdjMNCj4+ICAqIEFubm90
YXRpb25zIGZvciBnY292DQo+IEhtbSwgLi4uDQo+DQo+PiAtLS0NCj4+ICB4ZW4vYXJjaC94ODYv
bW0uYyAgICAgICAgICAgICAgICAgICAgICAgIHwgNiArKysrLS0NCj4+ICB4ZW4vYXJjaC94ODYv
c2V0dXAuYyAgICAgICAgICAgICAgICAgICAgIHwgNCArKy0tDQo+PiAgeGVuL2NvbW1vbi9jb3Zl
cmFnZS9nY292LmMgICAgICAgICAgICAgICB8IDggKysrKy0tLS0NCj4gLi4uIHdoYXQgYWJvdXQg
bGx2bS5jIHRoZW4/DQoNCkdvb2QgcG9pbnQuwqAgSSdsbCBmaXggdXAuDQoNClRoZXJlJ3MgY3Vy
cmVudGx5IG5vIENsYW5nIHRvb2xjaGFpbiBjYXBhYmxlIG9mIHNwb3R0aW5nL2NvbXBsYWluaW5n
IGF0DQp0aGlzLCBidXQgdGhlIENsYW5nIGRldnMgYXJlIHdvcmtpbmcgb24gdGhpcy4NCg0KfkFu
ZHJldw0K


From xen-devel-bounces@lists.xenproject.org Wed Feb 23 10:41:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 23 Feb 2022 10:41:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277299.473750 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMp52-0002oV-24; Wed, 23 Feb 2022 10:41:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277299.473750; Wed, 23 Feb 2022 10:41:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMp51-0002oO-Ug; Wed, 23 Feb 2022 10:41:07 +0000
Received: by outflank-mailman (input) for mailman id 277299;
 Wed, 23 Feb 2022 10:41:06 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nMp50-0002oE-Pu; Wed, 23 Feb 2022 10:41:06 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nMp50-0006r4-MN; Wed, 23 Feb 2022 10:41:06 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nMp50-0007C6-8r; Wed, 23 Feb 2022 10:41:06 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nMp50-0004tw-8Q; Wed, 23 Feb 2022 10:41:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=EMdK9+xw94wR6uqWXcovV54HOxeOlp0AZka1oK0sxbc=; b=3EoAkhwGilyUnayiM333fadIAL
	ANP9LwDHxg28i1sHVZV0UsgRr1qBdS8UsgBJM2Bwt+yrVx7c98I7PRod+h4jfQlsq/uuYpfWo68dM
	zCNTI7XrU5tZ+G320f1jLq8YbNEcuPR0oR4zwohGPAtKLP/96ySGXZ+i0BV87GfyF33k=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168202-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 168202: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=a6929d62cf5ca6bef076876f3354375f3a719df0
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 23 Feb 2022 10:41:06 +0000

flight 168202 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168202/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              a6929d62cf5ca6bef076876f3354375f3a719df0
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  593 days
Failing since        151818  2020-07-11 04:18:52 Z  592 days  574 attempts
Testing same since   168202  2022-02-23 04:20:13 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brad Laue <brad@brad-x.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Christophe Fergeau <cfergeau@redhat.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Divya Garg <divya.garg@nutanix.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Emilio Herrera <ehespinosa57@gmail.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Ivan Teterevkov <ivan.teterevkov@nutanix.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jing Qi <jinqi@redhat.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Lubomir Rintel <lkundrak@v3.sk>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nicolas Lécureuil <neoclust@mageia.org>
  Nicolas Lécureuil <nicolas.lecureuil@siveo.net>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Rohit Kumar <rohit.kumar3@nutanix.com>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  shenjiatong <yshxxsjt715@gmail.com>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tu Qiang <tu.qiang35@zte.com.cn>
  Tuguoyi <tu.guoyi@h3c.com>
  tuqiang <tu.qiang35@zte.com.cn>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Vineeth Pillai <viremana@linux.microsoft.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yasuhiko Kamata <belphegor@belbel.or.jp>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 98804 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Feb 23 10:55:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 23 Feb 2022 10:55:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277313.473762 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMpIW-0004RH-FZ; Wed, 23 Feb 2022 10:55:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277313.473762; Wed, 23 Feb 2022 10:55:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMpIW-0004RA-CU; Wed, 23 Feb 2022 10:55:04 +0000
Received: by outflank-mailman (input) for mailman id 277313;
 Wed, 23 Feb 2022 10:55:02 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=PMTg=TG=citrix.com=prvs=046033a78=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nMpIU-0004Qq-Tn
 for xen-devel@lists.xenproject.org; Wed, 23 Feb 2022 10:55:02 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0b699167-9497-11ec-8eb8-a37418f5ba1a;
 Wed, 23 Feb 2022 11:55:01 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0b699167-9497-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645613701;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=kpPF6xDDLuQWj+BKNENicyzQmEuv9NVwrzNrMbausI8=;
  b=MEDFgEtYIlzHezFkcqoH3aczbci1wjhySNclgi5eMaQmXX4ueXrFL+6f
   AyhUo3O/0bdDqL2xqerADlTZa7YAwrlzAYZi7hLt1/qysOjSVVKX6xWLe
   4YM5HPyeS+REfyE0/KYLWF7EuMypoE4nn6ZJtFMq6xNJDRiHUpEfcex+O
   E=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 64237353
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:UMMul69RWzf9px/Iee11DrUDkn6TJUtcMsCJ2f8bNWPcYEJGY0x3y
 2dLUWzQMqqDNmanKYpzPo/l8UpS7JGAxtAwGVQ5+X88E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si+Fa+Sn9T8mvU2xbuKU5NTsY0idfic5Dndx4f5fs7Rh2NQw24LiW1rlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCnbzqcDkxAoDFo7UQUCdgNzheEY5d4YaSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFKoZtmtt0nfyCvE+TIqYa67L+cVZzHE7gcUm8fP2O
 ZZDMmU0MU+ojxtnJXkNBYMat7eUokbAIzZZtwPPoa9p2j2GpOB2+Oe0a4eEEjCQfu1Kmm6Iq
 2SA+H72ajkKOdraxTeb/3aEgu7UgTi9SI8UDKe/9PNhnBuU3GN7IB8cWEa/oPK5olWjQN8ZI
 EsRkhfCtoBrqhbtFIOkGUTl/jjU5XbwRua8DcUasjiz0pb56j3IC2s6dhpYSPAFr9YPEGlCO
 kCyo/vlAjlmsbuwQH2b96uJoT7aBRX5PVPudgdfE1JbvoCLTJUby0uWE409SPLdYsjdRGmoq
 w1muhTSkFn6YSQj86ygtW7KjDu3znQiZl5kv16HNo5JA+4QWWJEW2BKwQWDhRqjBNzAJrVkg
 JTis5LChAzpJcvQ/BFhuM1XQNmUCw+taVUwe2JHEZg77CiK8HW+Z41W6zwWDB43bptZJGGxM
 BWP5lM5CHpv0J2CN/Mfj2WZUZlC8EQdPY69CqC8giRmOPCdizNrDAkxPBXNjggBYWAnkL0lO
 IfzTCpfJS1yNEiT9xLvH711+eZynkgWnDqPLbimn0XP+efPPxa9FOZaWGZim8hktctoVi2Oq
 I0BXyZLoj0CONDDjt7/q9BLdglSdSBhbX00wuQOHtO+zsNdMDhJI9fawK87epwjmKJQl+zS+
 Wq6VFMew1367UAr4y3TApy/QNsDhapCkE8=
IronPort-HdrOrdr: A9a23:rofde6oD51j/JgTTw9JsXr8aV5uFL9V00zEX/kB9WHVpm5Oj+P
 xGzc526farslsssSkb6K290KnpewK4yXbsibNhcotKLzOWxFdAS7sSo7cKogeQVxEWk9Qy6U
 4OSdkGNDSdNykYsS++2njDLz9C+qjHzEnLv5an854Fd2gDAMsAjzuRSDzraXGeLDM2XqbRf6
 Dsgvav0gDQH0j/Gf7LYUXtMdKzxeHjpdbDW1orFhQn4A6BgXeD87jhCSWV2R8YTndm3aoi2X
 KtqX242oyT99WAjjPM3W7a6Jpb3PH7zMFYOcCKgs8Jbh3xlweTYph7UbHqhkF3nAjv0idprD
 D/mWZlAy1B0QKXQohzm2qq5+DU6kdq15Yl8y7AvZKsm72geNtwMbs/uWsQSGqm16NnhqAn7E
 sD5RPoi3IcZymw7RjV9pzGUQpnmVGzpmdnmekPj2ZHWY9bc7NJq5cDlXklW6voMRiKobzPKt
 MeRP00JcwmBW+yfjTcpC1i0dasVnM8ElOPRVUDoNWc13xTkGpix0UVycQDljNYnahNBqVs9q
 DBKOBlhbtORsgZYeZ0A/oAW9K+DijITQjXOGyfLFz7HOUMOm7LqZTw/LIpjdvaMqAg3d83gt
 DMQVlYvWk9dwbnDtCPxoRC9lTXTGC0TV3Wu7djDlhCy8rBrZbQQF++oQoV4ridSt0kc7jmZ8
 o=
X-IronPort-AV: E=Sophos;i="5.88,390,1635220800"; 
   d="scan'208";a="64237353"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=mcfcm9KgYTfAOAJT4sTJaVIA+tkjgHYt7ChEj/P2jzAxUyIDUzaPDX+2xEptJCbGTC8gRuOT086Xqjph+kDrnd5RLZf3dDCAJbL0Wr08juW0+Q4jPmdKHJYQ1DB/16390oo5STcuqYHrDbBviO/2wdYEl58a0uUrhE0tftehY+44fGD6aURGWc/uhX+vr2jbZ23VCEgl6zvn95Fp5ZPpgbzO+SZHtswOOQ2+HZyg40AolPTq90x7L3G8Jw2yJ5j84wurJdpOoiRBuXPtGT8meMs58shu5NwSBlA3/vxtv8bjspv8vTWfksJTHpOfqp5sqI0FmQKw82j2R79b5BqXtQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=kpPF6xDDLuQWj+BKNENicyzQmEuv9NVwrzNrMbausI8=;
 b=cAwK5apd/m0EXHLUUp7TNGCocHNMlIQd+r8MsIlqCs+Yy1o3VCh6shId523jJIBAVFhmwmpQicq6DDGiQ8HJyUqaSNnsAOQErZ7nyJIvo3a7EkvRmE7Xe0N9n85dfXfOIeKGTL+Bqma+24iiGqMBDTmdrSenPZGgQrWy0MJBLdLZ6vpHJBl5hqK+cJlW0woimF7C1P6RykVdr/sMNgSpBYIO44P+AsEEbR/d/8eXy5AsVEhPCYD/s/OH4pAfwgPNBMwaBA7F8vN1wHei1i5dHiKdcFZ4WH87LV0647Ik+tQZ062l+lRyC1qPd2tjO91KCOjCJeF4MrjUYSdTpshAbQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=kpPF6xDDLuQWj+BKNENicyzQmEuv9NVwrzNrMbausI8=;
 b=wxY+dcGZsq8Tr2Wz5GUsDm4wDVlGu39tJA1k82/p4oxQmrj61jU8wvp6SFI3k1X1fuiLtCN7TerWeFjoCQp998Qd0y9PBEohmahVw8dq5YlLCgEJjtl5YQcNht0jAxyMESCHeQDh8PaBZJ/StTa+ug+sPiM6PMTQRmKsiP1dLdY=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Wei Liu <wl@xen.org>, Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH 1/3] x86: drop NOP_DS_PREFIX
Thread-Topic: [PATCH 1/3] x86: drop NOP_DS_PREFIX
Thread-Index: AQHYKJ3kfYMYavVLu0efzdcMu0mAtKyg9laA
Date: Wed, 23 Feb 2022 10:54:53 +0000
Message-ID: <f0214b33-09c0-f15b-e2ca-51cba5fd9ac5@citrix.com>
References: <91935ffd-a270-f1a1-28f1-645fa4167fcd@suse.com>
 <96f493ee-a360-ce46-7a61-5f55ca436295@suse.com>
In-Reply-To: <96f493ee-a360-ce46-7a61-5f55ca436295@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: e3702c04-7be9-4992-f55b-08d9f6baec62
x-ms-traffictypediagnostic: SJ0PR03MB5918:EE_
x-microsoft-antispam-prvs: <SJ0PR03MB59189154943B471287231C74BA3C9@SJ0PR03MB5918.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: v74dT8aQfuDNta+NXlRkIQ1O/7ZtfVkbRz/eK9PZOcuB1X3KruMA8aOFJ/lOF247XaIQbc9pJLfyXIILvyGQMBTeEOtHN/kKKj2pfJGQdIW/+ObD7mD91TPZE8qiS7alMa1QFXQ7sV0Y0BJBuu/aIl4ArR6Tux5+g+Zr3hVd5wq+OoGnTIGqANMcMOF7dSUKtBUNZemIegScPQEYcyCAtpLibHzrIV3ltHLk2+APP/lZ1T80e6FuiesippLntqewZTzAMXUiP0QSkCOvmCqFFNbwgP9+IlTQ2C4l9xWiUODFXzPeIqywxoXKSLwn39lCpMS7M0QnsHegHQ7+CixRx3Ame1fwwPa46dqFO6+dYF7pUzVHW1eOBbsrfU+uL1hu2L4tlU5LVmYLSOfNUg+q1oP6103EbjZ/zBpGjGaEddyg1cB/ATCpyV8NceGATJOHfc9rMLYqpSuFXjyQi5E6Y3Gtmiw382XjdtdZRPFFNDLAoSfHgBU9qLhtBQ4mA8QFG/+NqWVF1rDWDCf4pT1j61xiqxKbhLGjCCbloF0EF5meS39kADKrCC37yCcJcql4215g5bMmVMZU1BjUteREBaqsyCTy8xAUxESznHTFNdjo90f7vn9h7q4nwsDo9GhhDFw3G7jwKJruq0ByxBlaQE6gHZpG+uTGiQbUwp5MOpte8/8cGP6tPa+oqKRXCMkLVZgucsigru4hHJL7ZeV/ZGGSBYI3Ae5Jv8edcUKoeeCeTmBTZNR2B4cu+aWYpu7cZ1iSorPco+5i1DUbsS8rBw==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(82960400001)(66446008)(66946007)(64756008)(2616005)(53546011)(6506007)(122000001)(2906002)(54906003)(110136005)(31686004)(76116006)(91956017)(66556008)(66476007)(6486002)(316002)(86362001)(4326008)(5660300002)(36756003)(8676002)(508600001)(71200400001)(26005)(31696002)(107886003)(186003)(38100700002)(6512007)(38070700005)(8936002)(4744005)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?YVZPTHRTSWhtRW5YQzJDYW5vKzgzOStGeEhpRm9VbUxtQlBzUy8vNkRxZUxv?=
 =?utf-8?B?WE0reW1KVWNoUS9ZazdVejV3b29uam9NUnZuZUtHWjJILzhJcWtNcDBNRlVw?=
 =?utf-8?B?bzJ1MkxIc2dpcEZtVnlBTXNndi84MHkrdWVoQVBCSk5iVmd2NlhUcHFKNTVi?=
 =?utf-8?B?dENyRzNzUU45Njd2WmJZNEh1Zi8yZ1Z5M1dNYUMrYlA0RDRzOGY4Z0V0MlZN?=
 =?utf-8?B?MUN0T0tKZWZkNzJ1MWxTY0ZDMVczQ1dSOFNGY3BTZVYvWGVYdlpoZkJ5K21I?=
 =?utf-8?B?RElWdGNVcmk1TU11S0xTOStRNmg4ZFp6V202NVA3ekZIWkxlQjBWNnFJT2hY?=
 =?utf-8?B?bnhJM2FEQ0dEU3hLRElLWXZiTjlIYnRQam1PK0dxcmN4ZVNXamZvaVJHY0Rv?=
 =?utf-8?B?cDRRbk1raENieUllS283emFvdDkrQWVOWElEcTc5a09XUFFWVW5Wd2RRaXVw?=
 =?utf-8?B?Y3ZQTVVkQm9ZNk1ld2d2S25pN3RaanhkWUs1UjQvNUo4b0VSNVNJUVF4VGhW?=
 =?utf-8?B?NjZhM3N1MjVpcVAvY3pXZ3E1RXdpUThOOHRPejBQU1Buc25JS1lGS2U4NGli?=
 =?utf-8?B?TTdMQ3o4Uk82Z1UzbmdTalphczVIYllTdXV1YXhRYUhqNXAycUNITDNBeldq?=
 =?utf-8?B?bDV3SEdvL2ZnNDdlRERub3NxSDhlVVIxQ0pLSFFHeUt2QjIrK2FoLzRsdGdh?=
 =?utf-8?B?Qyt3UVI0N1piandtRjM1TjFHcFRLcmhTVnBTeDYxZ3JrNm41eTJaVTh1bkZ6?=
 =?utf-8?B?Umd2a0NXS25aV0NQRjNjRnhVSUpxVzdGbFZ3VCt4SVhlbzZtOWFGWUhuZEZu?=
 =?utf-8?B?MkxoOWhpZXRkRUdkQjhJY0R3MXB1VnYrSGZncmZxb05sb0E3MkNvOWZKQjl2?=
 =?utf-8?B?NGt3eUxsZnlJYUgvc2tQdlo0Tml5Z3VnRVJBSWVxbGd6ekp4SHl5MVZ0WDVI?=
 =?utf-8?B?UGQ5QjBDd0M5ZmZxQ2RTU1pZbG9pMWh6TUVHNHNQUmluM01wM21wSmdoT3RI?=
 =?utf-8?B?aXZzazJJNk1abXBzZlR6MTQ5RUtueDJYNlIxdSthNGdoRy9zMmF4bjNWb1kx?=
 =?utf-8?B?UmcvT3ByVTMxZVliUE5LcS9uMWdaMmxkWm5HaCtpaUthN2orK0JyaVJEUlYy?=
 =?utf-8?B?TDZSakw0ajlHTHIzbkU2RkFWRmdldHpjckY2OG00TCtjdUdQM0dsaUdvL21O?=
 =?utf-8?B?UXdyajlJSVN5bE0rWWUzWjNlbllwV3dqYlBYZ29Cblk1ZE5zWGZmWTBVcmcz?=
 =?utf-8?B?UW1jbU40ZUNaVUh2N0lvOVg1aE14MFZTdm5LaXVsekxKM2RHbkdYSUpBb2ph?=
 =?utf-8?B?RVhZZ0JUWEFZMkpOUjZ1WGJ5QkxNOGo3ZWl4ODdMbjc4enJkWS8yTWFHNktD?=
 =?utf-8?B?NTF1eXFBUHRhc1gzVzhvOTBaYXZ3VjdQMGsyelZhRmFSL2tKaUdaVm9CNTVz?=
 =?utf-8?B?Rk5hVFdYMHBmeEYxVm5xRzhhb3NqdTkzSE1ZcFE5bk52Y2xYb1BibEVoZWhF?=
 =?utf-8?B?TGJQcDF2TG4rWVBWK0FZempKZVZFVStFbHBRWjY2WkVST2p0YU82SHd6Y3FJ?=
 =?utf-8?B?eWdrSzg2ZjZxOUlVTENYcko5dUIvbUpUWWZWS1lPKzZVWjVmREN5alhTRlVP?=
 =?utf-8?B?ZkZSOUVScU9qcmJPQUsxN0xCYU9KVEY1RVMzQWdjTG1uNzVKZHJXN0lIU1pM?=
 =?utf-8?B?dTc5aHRHVnFPMlFTYUtZL0U3Q0hkV3pLOVd4Y3QrR2dZdlpyZ3hMOTBva0pD?=
 =?utf-8?B?ZzgwV3BxZ2ZRbUFPaUZSZDBybWIxUThMUDNVVmNGVVI1cm9SMDhRVzVSN0c0?=
 =?utf-8?B?R29UNEJCcEVYTUlEQW9hcnN5MGZFd1JYd0NrRVpIekcwaFFxbTFTbWx1ZE0x?=
 =?utf-8?B?RElBRlRscDNMYUZzY0RrTkV2UE1PQWpxdTlpUlhVdmNXRlFWMUk1aFV0Rjdn?=
 =?utf-8?B?bTIwazhGTlhVRlBzem1SZko3aDl1eCs1NUkrQkY4TWlsbmdSZ012VnZVUmo1?=
 =?utf-8?B?Wk1MckhFM3FaZzJjTXROTkZXczVFVlJuQy92NGpDOW5Pb1g2azM0clFiVWp1?=
 =?utf-8?B?Vlp5SHU5b2xWOXh6N3NCN1JWVEJqZ091Zi9kVmNqdXkyMWxpMHZkaVlHTW9O?=
 =?utf-8?B?RXYrL2l6YzRYNTEwZkJTNnJQeDZxUjJNRWFyVFFZckxCYng0eEF2Ri8xWFhH?=
 =?utf-8?B?WWhoQ1ExSkYycSt5c3ZxQ2R1QWRvcEl3eTRjVExiQnFEQWEvL1padGhBdTlD?=
 =?utf-8?B?eUY4SWZybW9vRFh2QnRXQkdldWVRPT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <39FFF82D74EC2047AD69E7FCE3A2A63E@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e3702c04-7be9-4992-f55b-08d9f6baec62
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Feb 2022 10:54:53.9112
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 1QEMJXDxloeqxbv1QxO7Zh9yT1cmhtxBW0BPpw6l7eHE1v4x9z0xQbvRFeontP8cN+TihiIKMQuGslkhl98it186K6Mr8mMoQ9P5b6d1mik=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5918
X-OriginatorOrg: citrix.com

T24gMjMvMDIvMjAyMiAxMDoxMiwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IFRoaXMgd2Fzbid0IHJl
YWxseSBuZWNlc3NhcnkgdG8gaW50cm9kdWNlOiBUaGUgYmludXRpbHMgY2hhbmdlDQo+IHBlcm1p
dHRpbmcgdXNlIG9mIHN0YW5kYWxvbmUgImRzIiAoYW5kICJjcyIpIGluIDY0LWJpdCBjb2RlIHBy
ZWRhdGVzDQo+IHRoZSBtaW5pbXVtIGJpbnV0aWxzIHZlcnNpb24gd2Ugc3VwcG9ydC4NCj4NCj4g
U2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KDQpBY2tlZC1i
eTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4NCg0KSSB3YXMgbmV2
ZXIgYSBmYW4gb2YgTk9QX0RTX1BSRUZJWC7CoCBGYXIgdG9vIHZlcmJvc2UgZm9yIHdoYXQgaXQn
cyBkb2luZy4NCg0KPiAtLS0NCj4gSW4gZmFjdCB3ZSBjb3VsZCBwYXRjaCBfanVzdF8gdGhlIG9w
Y29kZSBwcmVmaXggaW4gZmx1c2hfYXJlYV9sb2NhbCgpLg0KPg0KPiAtLS0gYS94ZW4vYXJjaC94
ODYvZmx1c2h0bGIuYw0KPiArKysgYi94ZW4vYXJjaC94ODYvZmx1c2h0bGIuYw0KPiBAQCAtMjQ3
LDggKzI0Nyw3IEBAIHVuc2lnbmVkIGludCBmbHVzaF9hcmVhX2xvY2FsKGNvbnN0IHZvaWQNCj4g
ICAgICAgICAgew0KPiAgICAgICAgICAgICAgYWx0ZXJuYXRpdmUoIiIsICJzZmVuY2UiLCBYODZf
RkVBVFVSRV9DTEZMVVNIT1BUKTsNCj4gICAgICAgICAgICAgIGZvciAoIGkgPSAwOyBpIDwgc3o7
IGkgKz0gYy0+eDg2X2NsZmx1c2hfc2l6ZSApDQo+IC0gICAgICAgICAgICAgICAgYWx0ZXJuYXRp
dmVfaW5wdXQoIi5ieXRlICIgX19zdHJpbmdpZnkoTk9QX0RTX1BSRUZJWCkgIjsiDQo+IC0gICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIiBjbGZsdXNoICUwIiwNCj4gKyAgICAgICAg
ICAgICAgICBhbHRlcm5hdGl2ZV9pbnB1dCgiZHM7IGNsZmx1c2ggJTAiLA0KDQpCaW51dGlscyBh
cHBlYXJzIHRvIGJlIGhhcHB5IHdpdGggImRzIGNsZmx1c2giLCBpLmUuIHRyZWF0aW5nIGl0IGxp
a2UgYQ0KcHJvcGVyIHByZWZpeCBvbiB0aGUgaW5zdHJ1Y3Rpb24uwqAgRHJvcCB0aGUgc2VtaWNv
bG9uIGF0IHRoZSBzYW1lIHRpbWU/DQoNCn5BbmRyZXcNCg==


From xen-devel-bounces@lists.xenproject.org Wed Feb 23 10:57:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 23 Feb 2022 10:57:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277319.473773 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMpKf-00052W-Um; Wed, 23 Feb 2022 10:57:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277319.473773; Wed, 23 Feb 2022 10:57:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMpKf-00052P-Qi; Wed, 23 Feb 2022 10:57:17 +0000
Received: by outflank-mailman (input) for mailman id 277319;
 Wed, 23 Feb 2022 10:57:16 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=PMTg=TG=citrix.com=prvs=046033a78=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nMpKe-00052H-J4
 for xen-devel@lists.xenproject.org; Wed, 23 Feb 2022 10:57:16 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5adf361c-9497-11ec-8eb8-a37418f5ba1a;
 Wed, 23 Feb 2022 11:57:14 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5adf361c-9497-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645613834;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=EUi43xVVzgsLCdi1JHTfT24uDri7YIzDb2sJiSnh0Lo=;
  b=LxBALXRD2gK19brXELxD7fwkNRzyONazLOSdfcMeCQIcwb2ycWsV64OG
   wOsT5SpoFQtzmk7hfgYVGjgwZrANRhFTXIPD9aJS4LFgHH8z1t4dx+d8c
   aMd2TJUi1HR3uP0HDk0ysU77nytmE9hpsyRJCAHh3+FKYrThB/+Mx3p5A
   A=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 67054062
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:xql2R6+WlxEVg1SJJV4UDrUDkn6TJUtcMsCJ2f8bNWPcYEJGY0x3z
 mcbWmjVb/nZamXwfdF0a4nio0hQvZaDyNBnTAZqr388E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si+Fa+Sn9T8mvU2xbuKU5NTsY0idfic5Dndx4f5fs7Rh2NQw24LiW1rlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCnazpFUQ7Bvbpor8ADDZoMSNXMY9i5IaSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFKoZtmtt0nfyCvE+TIqYa67L+cVZzHE7gcUm8fP2O
 ZVBNGY3Mk6ojxtnNn07MI0Tp/qR3kbtaSZUhGmQvKsl2j2GpOB2+Oe0a4eEEjCQfu1Kmm6Iq
 2SA+H72ajkKOdraxTeb/3aEgu7UgTi9SI8UDKe/9PNhnBuU3GN7IB8cWEa/oPK5olWjQN8ZI
 EsRkhfCtoBrqhbtFIOkGUTl/jjU5XbwRua8DcUKsV3O2JKPxjzCGzcrfhxDQdAEkNMPEGlCO
 kCyo/vlAjlmsbuwQH2b96uJoT7aBRX5PVPudgdfE1JbvoCLTJUby0uWE409SPLdYsjdRGmoq
 w1muhTSkFn6YSQj86ygtW7KjDu3znQiZl5kv16HNo5JA+4QWWJEW2BKwQWDhRqjBNzAJrVkg
 JTis5LChAzpJcvQ/BFhuM1XQNmUCw+taVUwe2JHEZg77CiK8HW+Z41W6zwWDB43bptZJGGxM
 BWP5lM5CHpv0J2CN/Mfj2WZUZlC8EQdPY69CqC8giRmOPCdizNrDAkxPBXNjggBYWAnkL0lO
 IfzTCpfJS1yNEiT9xLvH711+eZynkgWnDqPLbimn0XP+efPPxa9FOZaWGZim8hktctoVi2Oq
 I0BXyZLoj0CONDDjt7/q9BLdglSdSBhbX00wuQOHtO+zsNdMDhJI9fawK87epwjmKJQl+zS+
 Wq6VFMew1367UAr4y3TApy/QNsDhapCkE8=
IronPort-HdrOrdr: A9a23:IbXMr6CLc2Jp55DlHegCsceALOsnbusQ8zAXPh9KJiC9I/b1qy
 nxppkmPEfP+UsssHFJo6HkBEEZKUmsuqKdkrNhQYtKOzOW9ldATbsSobcKpgePJ8SQzJ8l6U
 4NSdkcNDS0NykBsS+Y2nj4Lz9D+qj+zEnAv463pB0NLT2CKZsQlDuRYjzrSXGeLzM2YabRYa
 DsgPav0ADQHkj/AP7LZEUtbqzmnZnmhZjmaRkJC1oM8w+Vlw6l77b8Dlyxwgoeeykn+8ZjzU
 H11yjCoomzufCyzRHRk0XJ6Y5NpdfnwtxfQOSRl8kuLCn2gArAXvUjZ1TChkF2nAic0idvrD
 D+mWZmAy210QKWQoiBm2qp5+An6kd215at8y7BvZKpm72HeNtzMbs+uWseSGqC16NohqAN7E
 oAtVjpxqZ/HFfOmj/w6MPPUAwvnk2ooWA6mepWlHBHV5ACAYUh5rD30XklWavoJhiKoLzP0d
 MeeP309bJTaxeXfnrZtm5gzJilWWkyBA6PRgwHttaO2zZbkXhlxw9ArfZv00so5dY4Ud1J9u
 7EOqNnmPVHSdIXd7t0AKMETdGsAmLATBrQOCaZIEjhFqsAJ3XRwqSHqokd9aWvYtgF3ZEykJ
 POXBdRsnMzYVvnDYmU0JhC4nn2MROAtPTWu7ZjDrRCy8/BreDQQF6+oXgV4r6dn8k=
X-IronPort-AV: E=Sophos;i="5.88,390,1635220800"; 
   d="scan'208";a="67054062"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=fe1aa+nW1gwCYzxmjDVEe+HuFlLMnDEsoDJLXDOk6gnr/+h8Sj1swPSYZztIx7H4xS2486AGO9mc+sa+KHHWOD+o3gPpktwy6cb+X3/YUQSzk94btFdXriU5eWZgEwU+DK6vI8rbfDER1jXIJntzfyD7Xr6q1Ptdp3rsilO6efDNuulo69n/oaDqAmSbZPGMfOVI7H8a3BlwgUOG9rgS5/PonjIIL5tiwwf00DkujNB/CxW1FtLcyIHr7XNXSOBYJ7iz0pQAqaZlk7Ij/RT4vYY8huQnf/n5/CWD34eP/KyAdlcUM7+iyQYWbH5BVb85WKqgDv7npznFsVr0R0m7XQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=EUi43xVVzgsLCdi1JHTfT24uDri7YIzDb2sJiSnh0Lo=;
 b=BtmtnUKQUCcXPVRJMEWZH/hNfY2uVWtd0LA1G3EAPhLNquATKa/l621PCvFG/oSvU4SvarKYc2AMugB4H73xCancJKw8YiIGlMop7srWh172v/D0Kky3E3RhqraXow9oWumjFgyp04x0KzR0wHgAIjTfR4PRdQ48X4Rmh1q4tRn5GYI8zlcYoyyoA5Fb+2NjCeZW12eLf9vGxMuE2OPtBlpYPzue7+XxVDznRtzqfnPZ4OJHSwnWB0pNooiZ/+ffu1WsN7GMIlZA6sBA8i3BO9yOFx0vAEy7AwAN4PYj/7fTAxGOTYPkMtwYqDaKhNk94f7p3dINNXHrTDIYoXA9wg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=EUi43xVVzgsLCdi1JHTfT24uDri7YIzDb2sJiSnh0Lo=;
 b=L6OIyGxj4YRBAm1VOu1ScPGgxUcDLu3U5I453g8lkPMvwGp2VOWkDRdTeLF8i2oXZHGxXvi81M0yy57RNZmGzAVsBZGJZ1EIYeT3kTePSnUtPLdpDx5I5UZ4an8GZ4uQQbtk9caRG/IX7B3BI0JjMbpgJyqfmV72iCPU2c7x8Ic=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Wei Liu <wl@xen.org>, Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH 2/3] x86/cpuid: replace more cpufeat_word() uses
Thread-Topic: [PATCH 2/3] x86/cpuid: replace more cpufeat_word() uses
Thread-Index: AQHYKJ3yxw44MvRAME+HWfLX8yy7K6yg9viA
Date: Wed, 23 Feb 2022 10:57:09 +0000
Message-ID: <b350f070-e324-b624-29d8-1999c435f2d8@citrix.com>
References: <91935ffd-a270-f1a1-28f1-645fa4167fcd@suse.com>
 <2c1f9c24-a07e-b5b6-2f20-18eacb835763@suse.com>
In-Reply-To: <2c1f9c24-a07e-b5b6-2f20-18eacb835763@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: c7ce0725-da50-49ba-b7b7-08d9f6bb3d41
x-ms-traffictypediagnostic: SJ0PR03MB5918:EE_
x-microsoft-antispam-prvs: <SJ0PR03MB59184849A4895071A969580FBA3C9@SJ0PR03MB5918.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: I3HVJf96Hc9YrXt17tK5n5vDPFnMc295x8eldVmin7lam9uyJ0jo9EGcs8ifFUPEeQehm2KcQB4djLoiO3m0dPrchO0E2MizmwNSINb6PM9A4AVG+/nEBE21EuitceU62UjKqsDjFe/jVf5y5q7MswWuRX9yE8E05Xqo7DVly22r2Yx/uA8XGHcn9irjQwqxGQd1WhXU/5YxXjBAWe5/2f7X2cyrgczXOKb23VX4Yd+yQrpIQzoGm1hKRjrsgt3Z4dqFmd/1KTDCP0fWN0Zfs92wOXouVPYe0bS8+jw+RZFaUA1ChdtT6dmaxwfM1RWnOvjGxA2FO4tnrgmGAAiCwkM1o5QOvzkpPcMTCVEVJGzTBigePS5/oDEbWOMcE6RxXb0eQp7J+2WUKa+7d443qbbSaKjJD3+tM3E2YUcz3ySJm2JO3tP7mUeLXIY1Of7LS3d5QTbGRVZa8HlIgL2oBWpNgi6WzkAKB5It7E9mCeRv7fBxluNMHg6RKOKifrK28Px2Cj2OgkbP5wMTeK/zf/VptlaqSrOWFYBKZANq29uIEQzr4W3QX4p9WMdB3zR/aLHHlDXgEwbLNyEllxOA1EttLAbYVPDyj+Va99DM9cKpv2aWJmG2AKkFL9GIKuoBxL/ExM46r1LAQ+IpgM8ciF9p6JwwHStp8ID9F8ERGs+NusCfoKVpdX7r/+MO9W1fpGAXG30g4ROfXPtav+2yS8EW6Mwi9lcPv5KZ3SFbC03zf/SrX2PPEpC3xi5W+3HkAkXmb2wQGKUWZWuEVDYTbQ==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(82960400001)(66446008)(66946007)(64756008)(2616005)(53546011)(6506007)(122000001)(2906002)(54906003)(110136005)(31686004)(76116006)(91956017)(66556008)(66476007)(6486002)(316002)(86362001)(4326008)(5660300002)(36756003)(8676002)(508600001)(71200400001)(26005)(31696002)(107886003)(186003)(38100700002)(6512007)(38070700005)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?RGlraTFXNVdudkl3Vmo5aFFhY2JpaUVldTYyMGRqMEJDUFV3cUpNUGgvSDhC?=
 =?utf-8?B?b05BQU9uVmF4K00wVGdRcnB2MW5CNit3WkRmOTNvREdNNEZ0MzBkaStZSld1?=
 =?utf-8?B?YzJHVzg3ZmtMcXZwMkhNVUM3clc5Q3JnOXlBbHNGOU1ScDJwOGo0MnVyM1Fn?=
 =?utf-8?B?ZlNMc3FwMDJsb3cxUkMxV2FDblZ2VURvTEdlNkVxVm1nRkZDR0x4T1dpMGRL?=
 =?utf-8?B?elZMU2RJRCtyVGVNVkVmbUhsajRRaW5XbW9qdTBrQVlUWUM4NGRLMDQ5YnpV?=
 =?utf-8?B?a0pTQkpibUo1WXZEWnlnSDFaQ3BEeU1UWHl2cDhOblBoNmVQdzl4emxmaEJC?=
 =?utf-8?B?UUorWEVSZzhVSWRxaklacGFCK2Q0NmhsdUplRllkTlI1MWZQK09BeW51dWhl?=
 =?utf-8?B?WU5MNXpibHRrbWRrSWlTZ1lGWVpYSnNWSVAwU0VZODRKRHNScjdPdTl4Qmt6?=
 =?utf-8?B?MjB4Wmw1OGFZcnpETVc2eG10Um1DS2JNRyswaWNsUTRvRHZPVVlaSTRoektn?=
 =?utf-8?B?Y2dpYkVRSGwzTEVWU2NjMk9pSFpvV0RpeG5vN3hjL0ZaeUsxNE0zY0l4dXJJ?=
 =?utf-8?B?WEd0V2s0ZmpEREVHRUF0TGJsb09oVXkwYXFFc2JUWUoyd2Y5VHdvZ2tVbml2?=
 =?utf-8?B?dnJzSkd2THJTVWE5TWNXMDhRRkF6ZmQ2a1hxK2g0M3B4WWxQaThVMDIxL3pp?=
 =?utf-8?B?cUpPbVZ1Tis4L2ZUZHNoNzk3SjZyV2ZrdGRjMDVDT1JCYnV5ZUplMzVPV2ts?=
 =?utf-8?B?RHk4ZGFuNkJxSHZQWE1WaXovWFBKZ3NkTWZCNDcxY2pSdzRhWGptWGpSa1Uw?=
 =?utf-8?B?OUVUMzlUdUEvanI1SXlTMCtYakE4cnAwa3NVaWZ4Y1p2V1VnRm5sV3pEYVJQ?=
 =?utf-8?B?UFVDNkptQjQ1SGJ2SmlLcXZaMThJMjRHTlNrSEdsT0orektFVWNVTmZKL2hE?=
 =?utf-8?B?amVJa3pXRDk4NEU0czAralo5SXB6ZEJqOXNxdjVKVGJad0dubHljNmRGR0JV?=
 =?utf-8?B?ZTYrbmxoUEc2bjhQN0NWK29uZ01YeFg1eXQyOU51RHFPVTlydTJ6Z3QxbVNx?=
 =?utf-8?B?eGJHdUx5WWZ4UHNNdGdydzJybEE3UWZVZWhtQWVqYTF1ZTd1ZkpLZUg3Ry8z?=
 =?utf-8?B?d0xtVzJScS8zNTFLMkhjTkVSb1Y5c2pBamdpampEc3B5dWF0ekowcFk2QkVX?=
 =?utf-8?B?ME5TVW82NUdNbVo2bUxkVk9jMUhlSENLdnVrWWhGMkhmdXkrTkNTdUNEWjcr?=
 =?utf-8?B?bURtYlUvVUFEYzVnK3ZPN1RpWEJyaXloTkw4QTJiSjRneVczV0hwaGUxeWtN?=
 =?utf-8?B?ek9HMVhUdTE3QmZTL1ROYWl5NUFBT3JpczZ0NDBJTzNZaDJBeWNibHRpNEt0?=
 =?utf-8?B?U3ZjZWhWWXhTc1AySWJIOWl1Q3R6RHBBcjN5cmt3K3dFOFNHWlBRYWViN2Ux?=
 =?utf-8?B?OVlUbkxPNnc2U2xPVzZvTWpJdndkSFhuZm5GZ3kvZFJUeHFPZjJhVGplcWwx?=
 =?utf-8?B?NldBZTZnbEpDbCt1TGRRTG83OFhVT044bTE2KzZpMWhkdW1DY3dUSUNhRVVs?=
 =?utf-8?B?NGJpTzJPa3B1T3J0RXhuMnVmUDA5TlZwUzhDVzExODNzSWI5SXdCSGZCU01Y?=
 =?utf-8?B?NlF6cExHNE5pQlViMFllY1A3aGNiQXE0NWQzMGZBdUtLb1Bxb3B2MGhSTkFP?=
 =?utf-8?B?cUFLbTJ5alo2MUZnSGdnMDhIUE9Rcm1pcmlYM0hnMlNtK2NNOGJVNWhIZ0dp?=
 =?utf-8?B?cmFIMThpOWF1dC9iTUVNQ3hpNWNXT0xWaE9TU3pvVE5oZmxtRE9mRmxHRGl3?=
 =?utf-8?B?a29UQlIwNHQxU2hEWGtaSmIyV1VCeDNIbTNJdmdhZFhVclV3Z3VCSzR1bFhP?=
 =?utf-8?B?YkRCdTVremJHVGtqMXFCb0JsaHdSSjh6VE5VeXMxRFBJZWlkOWJ1Nmp4dnhP?=
 =?utf-8?B?L0RtUWVnZnZWSFVEcHRaVmtwWkdzOTg2UllqMjU2MkVwc2tWZUVwemFCM0F3?=
 =?utf-8?B?UjgrNTJ6cWREeWFDNDJoc1hpZDBsMVlUZkd4b3VKODlnbUJsT3VSSEwwWnVI?=
 =?utf-8?B?V3ZHQmtpSW5qSk9FNUdZTnJCQUhsUUpNZGE0bHVpeXgyUVE0S1Y1SmNRdlFB?=
 =?utf-8?B?SWZhdkdWOGtDYU5NdFNBY3ozNVVENE9sSzRPaWhoUHhIeEgwWDhkL2JFYXA3?=
 =?utf-8?B?Sjk4SGVhLzVYQmNvUmxVeWlOby9rNGpPSFdXTjBzZDBHNzBWT3g2eEpoZDB1?=
 =?utf-8?B?QllxTi9nK1JtYllkb1kvV3NNbUtBPT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <922DE90C96E334408531249F38F000E5@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c7ce0725-da50-49ba-b7b7-08d9f6bb3d41
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Feb 2022 10:57:09.5888
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: hTZbow+pCG3WlEVSBDX06rbSLQ8cPT276ClJFlCEo1PV9VKe+zQiSwinqcovgWlVJJ+ioPMjfE1CPhUav6VpALHfFKhJzfLPT0nTIQtScPs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5918
X-OriginatorOrg: citrix.com

T24gMjMvMDIvMjAyMiAxMDoxMiwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IC0tLSBhL3hlbi9hcmNo
L3g4Ni9jcHUvY29tbW9uLmMNCj4gKysrIGIveGVuL2FyY2gveDg2L2NwdS9jb21tb24uYw0KPiBA
QCAtMzMyLDIzICszMzIsMjIgQEAgdm9pZCBfX2luaXQgZWFybHlfY3B1X2luaXQodm9pZCkNCj4g
IAljcHVpZCgweDAwMDAwMDAxLCAmZWF4LCAmZWJ4LCAmZWN4LCAmZWR4KTsNCj4gIAljLT54ODYg
PSBnZXRfY3B1X2ZhbWlseShlYXgsICZjLT54ODZfbW9kZWwsICZjLT54ODZfbWFzayk7DQo+ICAN
Cj4gLQllZHggJj0gfmNsZWFyZWRfY2Fwc1tjcHVmZWF0X3dvcmQoWDg2X0ZFQVRVUkVfRlBVKV07
DQo+IC0JZWN4ICY9IH5jbGVhcmVkX2NhcHNbY3B1ZmVhdF93b3JkKFg4Nl9GRUFUVVJFX1NTRTMp
XTsNCj4gKwllZHggJj0gfmNsZWFyZWRfY2Fwc1tGRUFUVVJFU0VUXzFkXTsNCj4gKwllY3ggJj0g
fmNsZWFyZWRfY2Fwc1tGRUFUVVJFU0VUXzFjXTsNCj4gIAlpZiAoZWR4ICYgY3B1ZmVhdF9tYXNr
KFg4Nl9GRUFUVVJFX0NMRkxVU0gpKQ0KPiAgCQljLT54ODZfY2FjaGVfYWxpZ25tZW50ID0gKChl
YnggPj4gOCkgJiAweGZmKSAqIDg7DQo+ICAJLyogTGVhZiAweDEgY2FwYWJpbGl0aWVzIGZpbGxl
ZCBpbiBlYXJseSBmb3IgWGVuLiAqLw0KPiAtCWMtPng4Nl9jYXBhYmlsaXR5W2NwdWZlYXRfd29y
ZChYODZfRkVBVFVSRV9GUFUpXSA9IGVkeDsNCj4gLQljLT54ODZfY2FwYWJpbGl0eVtjcHVmZWF0
X3dvcmQoWDg2X0ZFQVRVUkVfU1NFMyldID0gZWN4Ow0KPiArCWMtPng4Nl9jYXBhYmlsaXR5W0ZF
QVRVUkVTRVRfMWRdID0gZWR4Ow0KPiArCWMtPng4Nl9jYXBhYmlsaXR5W0ZFQVRVUkVTRVRfMWNd
ID0gZWN4Ow0KPiAgDQo+ICAJcHJpbnRrKFhFTkxPR19JTkZPDQo+ICAJICAgICAgICJDUFUgVmVu
ZG9yOiAlcywgRmFtaWx5ICV1ICglI3gpLCBNb2RlbCAldSAoJSN4KSwgU3RlcHBpbmcgJXUgKHJh
dyAlMDh4KVxuIiwNCj4gIAkgICAgICAgeDg2X2NwdWlkX3ZlbmRvcl90b19zdHIoYy0+eDg2X3Zl
bmRvciksIGMtPng4NiwgYy0+eDg2LA0KPiAgCSAgICAgICBjLT54ODZfbW9kZWwsIGMtPng4Nl9t
b2RlbCwgYy0+eDg2X21hc2ssIGVheCk7DQo+ICANCj4gLQlpZiAoYy0+Y3B1aWRfbGV2ZWwgPj0g
Nykgew0KPiAtCQljcHVpZF9jb3VudCg3LCAwLCAmZWF4LCAmZWJ4LCAmZWN4LCAmZWR4KTsNCj4g
LQkJYy0+eDg2X2NhcGFiaWxpdHlbY3B1ZmVhdF93b3JkKFg4Nl9GRUFUVVJFX0NFVF9TUyldID0g
ZWN4Ow0KPiAtCX0NCj4gKwlpZiAoYy0+Y3B1aWRfbGV2ZWwgPj0gNykNCj4gKwkJY3B1aWRfY291
bnQoNywgMCwgJmVheCwgJmVieCwNCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAmYy0+
eDg2X2NhcGFiaWxpdHlbRkVBVFVSRVNFVF83YzBdLCAmZWR4KTsNCg0KU3BhY2VzIHZzIHRhYnMg
aGVyZS7CoCBUaGlzIGh1bmsgaW50ZXJhY3RzIHdpdGggdGhlIENFVC1JQlQgc2VyaWVzICh3aGlj
aA0KY29sbGVjdHMgZWR4IHRvbyksIGJ1dCB0aGUgcmViYXNlIGVpdGhlciB3YXkgYXJvdW5kIGlz
IGVhc3kuDQoNCkFja2VkLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXgu
Y29tPg0K


From xen-devel-bounces@lists.xenproject.org Wed Feb 23 11:11:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 23 Feb 2022 11:11:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277327.473784 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMpYc-0007Kn-84; Wed, 23 Feb 2022 11:11:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277327.473784; Wed, 23 Feb 2022 11:11:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMpYc-0007Kg-51; Wed, 23 Feb 2022 11:11:42 +0000
Received: by outflank-mailman (input) for mailman id 277327;
 Wed, 23 Feb 2022 11:11:41 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=DZ7u=TG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nMpYb-0007Ka-7p
 for xen-devel@lists.xenproject.org; Wed, 23 Feb 2022 11:11:41 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5f639e4a-9499-11ec-8539-5f4723681683;
 Wed, 23 Feb 2022 12:11:40 +0100 (CET)
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2050.outbound.protection.outlook.com [104.47.2.50]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-31-dyN-6EgYOLWGu8w2NrJ4xw-1; Wed, 23 Feb 2022 12:11:38 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by PA4PR04MB9247.eurprd04.prod.outlook.com (2603:10a6:102:2a2::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Wed, 23 Feb
 2022 11:11:36 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.022; Wed, 23 Feb 2022
 11:11:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5f639e4a-9499-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645614699;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=f2LW45OR9QyB/xv/GQypej6z4yNDHqrFv6fZ+6Ynb5g=;
	b=BTZg7Gd1c8YxQVdElOr0rA+5AYWcBbSv5rY5yIAUUWt0SaztpOQ6z1yEheOBVlvwSWK1ji
	lnLnp1NgknFXM8j9tbtdgTiiUVRZ7EdjDHq4NVGPXTtHsZ5fmpyAugY1DFYUW2tM6LIpB1
	7NKAqSKagV3wGU/VwUtvFYSz+AA17+k=
X-MC-Unique: dyN-6EgYOLWGu8w2NrJ4xw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=KpdoFjZy3b8/LHegeRiLsJrLDgrpJL90wcbACqrmTaf0rhATQnbhHSOJtp3kMg0q/NEgT2JyeUs0tPI5OyCVbFEe04mfseBRPm4kymeGrS31p/VKcggudz+N7ZTuwiItpTvxo3Vf0D7ywiOdu/8vXQOuF0tMEBqp6mCsaknhEp8usQ+Pk1AuDPhyK79qU8Crl1eysuK7l1ErxVAnsbC6iyDduUBX49FttUCGCLWW5mmonF4Y0Xls4JFijczZ4CxVwNqK28Vat5jhsHsOqR19THvDOmdOVDYY19H7GEvRvBNbK1ooG1MRGelSXh/OvSgXNawTBRrMuEylovN32lR7uQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=E5rtqIYRQyrk6uH1BJMVlZRSirGX8jY1S+9ht0rwAa4=;
 b=F+tVVK2TLL0LArofk0X/mLnk5sC/nvKzaeQsYHcgLl8HCcJHFl60vXnqedqaWepDlY1F4YLumHEm3FZtWG2oJAw4IkyP6hhW8Inx3v9Z9OTnSn06BvJ05WBCyZh/vlbqOPUtXHxFMe+IBN7Jq/LmcP80nlNYr/Ulq5Ntd8FjoBCd7hKoF1+J0F9D5x7GfmJarVa3eoy9ZpxXJdip++AiwjVIc2pGBbeqzKDdUVMQ1fH6Hqrw6OlQET+bh4rqQ2MFhbFRjugNuLAeMBWshVu6lqgIdNGLHzFcRP+j8uhLsh4ebkg+iyJFSzdhBvAqsuL3f5/Tl7lYZMCS0qmmBIsa8Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <4b90f99b-08db-8f1d-bede-d541df05799c@suse.com>
Date: Wed, 23 Feb 2022 12:11:34 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH 1/3] x86: drop NOP_DS_PREFIX
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
CC: Wei Liu <wl@xen.org>, Roger Pau Monne <roger.pau@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <91935ffd-a270-f1a1-28f1-645fa4167fcd@suse.com>
 <96f493ee-a360-ce46-7a61-5f55ca436295@suse.com>
 <f0214b33-09c0-f15b-e2ca-51cba5fd9ac5@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <f0214b33-09c0-f15b-e2ca-51cba5fd9ac5@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6P193CA0065.EURP193.PROD.OUTLOOK.COM
 (2603:10a6:209:8e::42) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9729f07c-32a5-46b0-525b-08d9f6bd41ad
X-MS-TrafficTypeDiagnostic: PA4PR04MB9247:EE_
X-Microsoft-Antispam-PRVS:
	<PA4PR04MB92472FE9093423F9B265550FB33C9@PA4PR04MB9247.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	79gYuePeT8mwnt1fSeHJZ80I4EvMwgVkYkBG1JiGYJC2o9biiIiQVoRVMILKaBoySSlzC1MY/v+Rz+mR82JJRLY7wC64nb07VgMivU8Z96r63A8WcxU8NHsi89fpRuJmRvkv6yA4GCSXj9b3WjefRuOvaz5LYpyGktFRWbTEpxTL48gtYlUyF+t4XL1s/M+HYTTyK69AqnatawgzlmnXEdTp6pxRN8J/MLvkXHp8TFCvfpx1UjeAkePwqbxYBuPuXsGBIEFzu/NlIo2yhe/PvvL9M91aKKbHRxMD3CRzTo/OQkOxta1GO6hVYiIvJv9XxzTwqruvSIboRsPsAGlhotNcxM01TdtF+zcK8tNTlKD3Q1zM0hKReOMNdCH4DkXgYofWaGXl5E6W+sIFC4L/G0wMeC/Eh3Jf7mu3q4aeyf4Z36TG4cE07XSOaHujsL9+zAbWqBTdIZPHJpBcvYW488L3uESYcCNS0rRLopB+NHopr7NyFOLT0hlfYbCuI0Swh4hqWo+OP+klBTVakuuRPQRzOFZf7Wy2kNh0BsjVlo3TPvoz3upS2EclIQ4w5zjKqABZ6s3wRhzzYAWjUZ0sFQOQF19UMkr3O2zwxk7I0Wd6DIPJyXd8AzndUvR9n0dKHX2xR52egGJqqFqtMdWAEUJMsN+AQbYrF5qWaUcY5JBBMwRfga8qzgxaSBo32422xYvL+Pk1ImolRL2+VGaC8unXiIeEGcgR0iJPvEMPodRK5hqPFxBqlaI903sWEG1V
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(31686004)(508600001)(6916009)(316002)(186003)(8936002)(2616005)(6506007)(4326008)(66476007)(54906003)(66556008)(8676002)(6486002)(66946007)(6512007)(31696002)(86362001)(53546011)(38100700002)(26005)(5660300002)(36756003)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?MyWUTw6v0PDMPQwR7AzzqO7eeN3gYxWYO/lCYhqumccaXetubi3tVRiMlgMB?=
 =?us-ascii?Q?AX6QIsygxyuAWeZf71pqgP0SBIVVWWIpAc61vKl6Y6nB/gGM1vDd+8X67ljA?=
 =?us-ascii?Q?/gZIB35LexYmTZ0afBcYPN0q85cwHLws5ADiqKqWXShD+CzMv/PF1/sODd3E?=
 =?us-ascii?Q?nfnq6Ypp9fM+1D+NO1Gj6uAoBXI3J1LhPwGsGkXLSgdgkFEnfpAtYDU9B59P?=
 =?us-ascii?Q?OZpOb9imrc3ONR+Nn/DAaigubRjKAQLXhuTo7mH2tDBHpqdHyBIldoD++JJK?=
 =?us-ascii?Q?z8956fhykpZVs+PoY8SSXuYCH46GuZb0dWddAqvHHtV0UpyYQsCnmdzdvWoT?=
 =?us-ascii?Q?KhFBG2QXtAHMbaOMMFPk36W3hBEBbSN3zuiZwtvVS7/KLI729KktIdBa2+BU?=
 =?us-ascii?Q?eLupo6VwtuSgSBuUClRh+lGBX2ULLm/qXbp2i8cGW/sLIjNyhVOkLbsjzkO1?=
 =?us-ascii?Q?0EvOP6Jh7fSnVBDk9vlgC2SktT6oreB4k8E2LHWZFRUVUp3RKkhsh4C/jkRx?=
 =?us-ascii?Q?SpbF6t7gd+WCvXfOpSGKnhLd/4AOHQC5rTf0h0chqv/Te/qQ0LaMZdanYMPT?=
 =?us-ascii?Q?LTrAhincibvZt2GWTFpO15Oz3NHrfluUv99mtnX1kePuvXw2xZtLeagX2TUP?=
 =?us-ascii?Q?D06Jv8IVqWeftRuoFMqqkSjt3nXYyGZTX8hd30EjNltupWXL7SD/Wa+F8Y42?=
 =?us-ascii?Q?1WRJ1OhVRc4WWlRucbqUDlfF56Oy/d0f74t1PF5E/JXOrd/O0V9EC2UpXyUF?=
 =?us-ascii?Q?HLN/nA7RZ+Nai6Z/OqddkP0tlowdZnXs4re4djG5QwPF22yRWwhK8oGf2H9e?=
 =?us-ascii?Q?JJYzbwMdaSshFveT/PJQ4KzwFw+kyLytRJenLKWrHvDpMePIvWJc1QlYYJdP?=
 =?us-ascii?Q?Cq6yXRgITfUWQuUgIymM1WYzQp/QMSsCzbE25KVtxCsbI6MUIkl899k06AcD?=
 =?us-ascii?Q?3i3rA1snd87FmsZL7Ttu3tD5YnohMxBfoNGApFhyYPbr1NjIQvztEt2rnGDh?=
 =?us-ascii?Q?Uvt68OqlEufpSIUn3Bd5ED4TzAMA/qbsYb6Zxkgbc49O0H6q9TtKq+sa0ZSZ?=
 =?us-ascii?Q?DJ4+dBLJmWjfRtsJg8CYBJx2J5qlmgNGAJlxX1Vny2hR5a9aMw76eGR7ww1Y?=
 =?us-ascii?Q?4Glc8RctrCWPIhnmLydO/nJdpwUOzu6nAyhwGv0/jinOJd6Woa4Ddw/beqKI?=
 =?us-ascii?Q?bGD8MOsmlnCfMgwrOdeUqYRavdBXzUjA+AzUcNmZCHku/6RNx4+Dfw+qO1zL?=
 =?us-ascii?Q?AcoaDcweR99bxp2hEY719TIVWACiplfjUQGV8ghHstWEaLdp4wznjHji6b7n?=
 =?us-ascii?Q?vAG3OhHEXr67gDQMK78FpV13IV8bbmfuWpb6N0tkVLh/PGyGsNtwXEih7kCR?=
 =?us-ascii?Q?ro2Dl36eHtISO+Y7AaA+jKU3khPdO2QL7DMzm6QbGkgt/WmLFaRkc8+PJ5m7?=
 =?us-ascii?Q?fwDO1VJx0Fi4W8qenb/6x2Qdg31OmaQCTJJGySbb4/Ca9vgCS5j+zUfZymoa?=
 =?us-ascii?Q?9Oz+sVQbsVAULTXc6lcOxllJsDoV+EeYkMY77vu68Aq1QS5q6NJ6OPeCNVj6?=
 =?us-ascii?Q?8j9qzM5hdfEegBvcyl1z5tPdsm/lGuHUEAEn+VjPDStjAhnmIer5bL+0rRg/?=
 =?us-ascii?Q?Dd//5AKAC+SpwKkVh9qgg0c=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9729f07c-32a5-46b0-525b-08d9f6bd41ad
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2022 11:11:36.2640
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OTwoY5pbwLFM1q9eGidl+BcN43FUCupiSQsVXrqP5uvr3mfUSj4oBmMlr6sWH/VR32iO0AUjGYRndwqgdRxOYA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9247

On 23.02.2022 11:54, Andrew Cooper wrote:
> On 23/02/2022 10:12, Jan Beulich wrote:
>> This wasn't really necessary to introduce: The binutils change
>> permitting use of standalone "ds" (and "cs") in 64-bit code predates
>> the minimum binutils version we support.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>=20
> Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>

Thanks.

> I was never a fan of NOP_DS_PREFIX.=C2=A0 Far too verbose for what it's d=
oing.
>=20
>> ---
>> In fact we could patch _just_ the opcode prefix in flush_area_local().
>>
>> --- a/xen/arch/x86/flushtlb.c
>> +++ b/xen/arch/x86/flushtlb.c
>> @@ -247,8 +247,7 @@ unsigned int flush_area_local(const void
>>          {
>>              alternative("", "sfence", X86_FEATURE_CLFLUSHOPT);
>>              for ( i =3D 0; i < sz; i +=3D c->x86_clflush_size )
>> -                alternative_input(".byte " __stringify(NOP_DS_PREFIX) "=
;"
>> -                                  " clflush %0",
>> +                alternative_input("ds; clflush %0",
>=20
> Binutils appears to be happy with "ds clflush", i.e. treating it like a
> proper prefix on the instruction.=C2=A0 Drop the semicolon at the same ti=
me?

I'd rather not. A clever assembler may eliminate the prefix as redundant
when the base register isn't stack or frame pointer. In 64-bit mode an
assembler might even decide to eliminate all non-standalone segment
overrides using the pre-386 segment registers.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Feb 23 11:31:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 23 Feb 2022 11:31:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277336.473795 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMprp-0001Ie-1I; Wed, 23 Feb 2022 11:31:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277336.473795; Wed, 23 Feb 2022 11:31:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMpro-0001IX-Th; Wed, 23 Feb 2022 11:31:32 +0000
Received: by outflank-mailman (input) for mailman id 277336;
 Wed, 23 Feb 2022 11:31:31 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=DZ7u=TG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nMprm-0001IR-Q2
 for xen-devel@lists.xenproject.org; Wed, 23 Feb 2022 11:31:31 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 242634e7-949c-11ec-8539-5f4723681683;
 Wed, 23 Feb 2022 12:31:28 +0100 (CET)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2110.outbound.protection.outlook.com [104.47.18.110]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-2-MN91TbUtP5W9FgCEHB7WeA-1; Wed, 23 Feb 2022 12:31:26 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DB9PR04MB8137.eurprd04.prod.outlook.com (2603:10a6:10:244::9) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Wed, 23 Feb
 2022 11:31:25 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.022; Wed, 23 Feb 2022
 11:31:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 242634e7-949c-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645615888;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=HiokagSwW7oft5YfoUtY1q5MIq5PaNW8aRtwexB10Dc=;
	b=m6EOszrLOrOX8Hq6R6Q7CoqO0syvmoTQvg0ynm7c9SRephkq5aYvDkQ5DJCjWunUPJ3Ze5
	ZIN0Yj1cBK3V/CUhAqnjzEFWokgkpk72snaCJrs4rHb1m44RvykOjZLN1IUWzoRzyqej4w
	7/oZnrWY3ClijuFgzI1qSf9MKwtBL5M=
X-MC-Unique: MN91TbUtP5W9FgCEHB7WeA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=LTK0BQbJ1QP2vfmlmV+Vs7yGu4zhNETzuwXLSAxh6Fau+GjcpISy7T/3hrpjC4UPAi9VQhswm3BDSBV0DQN9LjQtYNdCfVbWvkNBXu6vHKF7IaYx6VQHJXKPWni0LEynsISYXpqM1WqKnP3r+7jXjf4v6OVkEvpO73ijTGJhkySQmV8CJ3H+Nce/OFn1XBiZ33HWBGDi3ur0VXOgZ/EAayd8OuMO/TcMtYu4cfGz5H9iuuSty2xjadD5KXDgu7Olf14mAFi8iyxEDRip/thYBDcYnMlK/Hl1iFfO0ZqfAr5wT4rypctRh1+Avpnk9hrUzPFiWsmXAH+aRcVLR0M0JQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=aTT5nBsFvcPRM7gkaZ9hXwUhZEF54Jsjj4N4/hO/hxE=;
 b=f70gOQRYFeV5uGom1KnaotP78+GV/+s/GwDapB42noznrdfSc3+da+jKAW9FahDAZjKOVxOwN/9qiZMUvNzIZ7iCJL2f/y32z5v7YsVd4EcBCZMCjAu2f+6vv74MjDXyeTX7w0qGcKUR1v05WW0QiyQmS4de8Fgd7pN6ww6lrCHqeM17Q3LofdNVscpMewTAPs+ZrxJkKU51ycU8dy8A9CTXKIc6ghpU9RFrhvD5KWhGel4r1gXHvMbAGrjTESKTE6NfSw6BllLKLXjlszcC8diiszT51AJ6yy4cE7PajiWxyfrOZLttMpbonHsqr1auDCnETI8qSbL9NJjdGyzgrA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <48241c60-294b-782f-7217-45a3dc929c38@suse.com>
Date: Wed, 23 Feb 2022 12:31:24 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v3 60/70] x86: Build check for embedded endbr64
 instructions
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
CC: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Wei Liu <wl@xen.org>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20220222152645.8844-1-andrew.cooper3@citrix.com>
 <20220222152645.8844-15-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220222152645.8844-15-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: FR3P281CA0059.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:4b::21) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e37ec452-7e7b-409a-e525-08d9f6c006af
X-MS-TrafficTypeDiagnostic: DB9PR04MB8137:EE_
X-Microsoft-Antispam-PRVS:
	<DB9PR04MB8137E306EF12643BB44548E7B33C9@DB9PR04MB8137.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	yzGi1T2nv89fOPy/xvfzCCOXkTD4E3wAvE5A5cEBaSDaLVSsOuD7eFFvVEanTdQqRVTG4ud73/8JDmEVOL5tWhKZ+IEk8+3zK+7G+Zs75XRGONagKVsuodsy+ikt177qJLc5MrNmiYBqE8821Nfb4mBS7ZAJrRqGafWUXMjhTjurrM7YjJYH5hlzMVgwaH1CVxPmllzoPDS9BWukkdD1ZRXKL9tEMmjrNCfcBEFKVUqcDXTq+kzg89iMa/Ykr3nbB1iqS2I2RNwG2A3xZ467qU74fbO+ZF6yEM46eO24fgPKs/JEEXUjnwMRWj5DGsPis6tqcyCaFl+5DeRAHAvMnR+jvefhbLOOUehPRudGetBsThlvpjbYieJESXvl+Jc8ydV8pmrqKAmPwz6U7A+EA7qhW/tcR1e/1YAaVUYk+VrvLRLqF05jPJTki8cBSZ9t99fZSbDbavbzFlz8YrLC4mn2QY/mMTkfGpqsWlfPal9PCh5y/BzLOa72WszPn7svGDfjUmrr08mBI05Y87AIkzaZSxovLx62lmp8tiShdZAvueqM1weHopUqVSKBbbyGruTH8q4K9Ey76JpFfCpBaQToH/oxmVo2m3YzwbMN/IEo9NvMCPoNoNYFGavWJymluMFLJc0KLoTWgKICW7DJ9m/5YzmUO0n3I+467wq/5Xz6Lyk34r6APiEt9Ns7W6HvBWbTnyx9URRYvOX8Q24bDgl5exme38ACQMAnCwKkpcr4mFOLaOX5dX3cH3pZiZIF
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66946007)(4326008)(508600001)(8676002)(316002)(31696002)(86362001)(54906003)(6916009)(66476007)(66556008)(5660300002)(6486002)(31686004)(38100700002)(2906002)(8936002)(66574015)(2616005)(6506007)(6512007)(83380400001)(53546011)(36756003)(26005)(186003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?4v6cGmNcLuw6hlFg36I0pHxWVRCT7WdrbPl6NbePHgtJGy7pdwGF3jYlFhI4?=
 =?us-ascii?Q?vaQRAmsmCfl8Rxfim+rZaa3PeB2Nzfg6d2SSxjBPpu8Ql5JjeSb2UuQ3u9EZ?=
 =?us-ascii?Q?9qxUhubK2kLFp7bGxAxNt/hBwlBosL6Ni5WLCxrYFs4vk3MKGM/YKWAbmM9+?=
 =?us-ascii?Q?ryuJUWqQFMjVahl3MJrYswGoV1OOPFHS5sNAGYmR7ltWZfT+H50mT/P6LTcl?=
 =?us-ascii?Q?UeqAKjHdccpUDza/2qecMIyziavI0bTBh7TOyOyTleT2P23ROqaSB8vgMcyY?=
 =?us-ascii?Q?qgTJkafu+2hQToQvA6hHiaVpeZvI0WKAzfJ1Iqr6dvenucVJ2nLS8mMo2tuu?=
 =?us-ascii?Q?Y2DRsh4h2V6OqmrXSs5lnxuxVzWU1lAlXZwo1EF/MEWxykQxcc+Dl25ZzIa1?=
 =?us-ascii?Q?CEZ4F1zkCC4LrFGWFeaSFVaRGac4+12guL8uMwoOMO83Y4T+/jGO33AuqqV4?=
 =?us-ascii?Q?1TEL5zaq3eubu8QHMEC9dcNYpuq/I3viMXk363W+lsYuFspvC7PjPGlxee54?=
 =?us-ascii?Q?gKd2AwEshsTWg957kzRiOTudfCuEi69nQQgFyi2wznPjqyBsLhwtU6t6VEYm?=
 =?us-ascii?Q?GfI7yMvZxh0lspkHLkFbMpjzB+TFnOD/sF7cJweWSj3uEMl3GVmoxlv/Qzw9?=
 =?us-ascii?Q?jTR+AKqBwcAiMTqWTuJhXLSAd03T57lBjIYBxpLEvK36qdFNxk3qATjkU8Jd?=
 =?us-ascii?Q?1mEusfhZMZ4d5DIPzklSdiQNQHe7u8vkrbV3imSfhW5HrErSx2a5MPS81IgK?=
 =?us-ascii?Q?6kTzLLw0PBoU2FeNFkWOnsLijf9zCxt8apFJXyGI/B8VDuZJli6IMPlnzRF0?=
 =?us-ascii?Q?tRp++fnfBL2XUhdXlX/Anjc6n79ZOu/vbDU2LXlm+EhLk98IMtOHFRQsrN4H?=
 =?us-ascii?Q?2xMFSXIXEnfU4JtC5sjoquCMhe59WnDakQrXSodX/1lLwYFWm7SqyOMvoe/C?=
 =?us-ascii?Q?hcqRWEqPqB0tyne4aSZ5ymPccuzW7Q5ZgKUBFseHIfKzKCB7C1f61jvzpJPV?=
 =?us-ascii?Q?wvWCJnZkhyh5Q2VXSBCW902suGUm9/LcW/Y8E35Z4SF6Q66sllrLqb82g3JI?=
 =?us-ascii?Q?JyiH8S0p1rz9L8JHEv86Jlj6bb44ebJWwLkZ8nq6451nrk8C7YhzTDhqBRZK?=
 =?us-ascii?Q?18588EzK//L4AHQLCOACAife96qqDlt4Nx3TW2zKoSGNNKj1PSmdkOHWIQil?=
 =?us-ascii?Q?7E+6ADBhSDa7IZKe0DYwcQBhycS92I4SSrRzuGIPaxQIOmBgpiye5jJcFNF1?=
 =?us-ascii?Q?lwGhU/MfE41sepOTqOhiAEN+gs4UpGPFyVUzdmlB32p2L76W9UvOofpZiQfn?=
 =?us-ascii?Q?cnBcPQ4dt0PvIuW4bFhgWK1th9YujLGl+gz+M7evFJ99KhkP/C9O6cRUlK4Y?=
 =?us-ascii?Q?o9k9W/PybpuFY4CtXxgiDnGxxclP60r0CqSdoQGxo2leyplkr37fspOjjT2L?=
 =?us-ascii?Q?277vIGj+g3a5/+/6gu0IuZjDDiXeCxK/CYgeTbpXEr2IYGv4kyTgPbmL0kVQ?=
 =?us-ascii?Q?nPchTUsZvekpFa7lg7Af22P6dpo03eCpykt6rBcqop1mONvt1tlJO+HebmsA?=
 =?us-ascii?Q?5VWJv/hKca17D5R78gUYzmv0nDVRt9n48m8Xymuz5f/hwLs3Ow3yqLrjxQzT?=
 =?us-ascii?Q?oiUbCiWgFD5U/GOFeUMMuiA=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e37ec452-7e7b-409a-e525-08d9f6c006af
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2022 11:31:25.7542
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +syzSNgB/f73vFM4AOvVERTM6YoKr/HkPDuarM2H6uAnOY2WWcEsZsLZzDsr0pAaoocyPlFN1AplGs3tYG63hg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8137

On 22.02.2022 16:26, Andrew Cooper wrote:
> From: Marek Marczykowski-G=C3=B3recki <marmarek@invisiblethingslab.com>
>=20
> An interesting corner case occurs when the byte sequence making up endb64=
 ends

Nit: For grep-ability it would be nice to spell this "endbr64".

> up on a non-instruction boundary.  Such embedded instructions mark legal
> indirect branch targets as far as the CPU is concerned, which aren't lega=
l as
> far as the logic is concerned.

Thinking about it: Wouldn't it be yet slightly more reassuring to also
look for ENDBR32?

> When CET-IBT is active, check for embedded byte sequences.  Example failu=
res
> look like:
>=20
>   check-endbr.sh xen-syms Fail: Found 2 embedded endbr64 instructions
>   0xffff82d040325677: test_endbr64 at /local/xen.git/xen/arch/x86/x86_64/=
entry.S:28
>   0xffff82d040352da6: init_done at /local/xen.git/xen/arch/x86/setup.c:67=
5
>=20
> Signed-off-by: Marek Marczykowski-G=C3=B3recki <marmarek@invisiblethingsl=
ab.com>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>

> --- a/README
> +++ b/README
> @@ -68,6 +68,7 @@ provided by your OS distributor:
>  In addition to the above there are a number of optional build
>  prerequisites. Omitting these will cause the related features to be
>  disabled at compile time:
> +    * Binary-search capable grep (if building Xen with CET support)

Nit: With this (maybe this was the case already earlier though)
s/will/may/ in the previous sentence?

> --- /dev/null
> +++ b/xen/tools/check-endbr.sh
> @@ -0,0 +1,85 @@
> +#!/bin/sh
> +#
> +# Usage ./$0 xen-syms
> +#
> +set -e
> +
> +# Prettyprint parameters a little for message
> +MSG_PFX=3D"${0##*/} ${1##*/}"
> +
> +OBJCOPY=3D"${OBJCOPY:-objcopy} -j .text $1"
> +OBJDUMP=3D"${OBJDUMP:-objdump} -j .text $1"

While embedding the arguments here shortens the lines where these are
used, the appearance especially of $OBJCOPY with a single file name
argument ...

> +ADDR2LINE=3D"${ADDR2LINE:-addr2line}"
> +
> +D=3D$(mktemp -d)
> +trap "rm -rf $D" EXIT
> +
> +TEXT_BIN=3D$D/xen-syms.text
> +VALID=3D$D/valid-addrs
> +ALL=3D$D/all-addrs
> +BAD=3D$D/bad-addrs
> +
> +# Check that grep can do binary searches.  Some, e.g. busybox, can't.  L=
eave a
> +# warning but don't fail the build.
> +echo "X" | grep -aob "X" -q 2>/dev/null ||
> +    { echo "$MSG_PFX Warning: grep can't do binary searches" >&2; exit 0=
; }
> +
> +#
> +# First, look for all the valid endbr64 instructions.
> +# A worst-case disassembly, viewed through cat -A, may look like:
> +#
> +# ffff82d040337bd4 <endbr64>:$
> +# ffff82d040337bd4:^If3 0f 1e fa          ^Iendbr64 $
> +# ffff82d040337bd8:^Ieb fe                ^Ijmp    ffff82d040337bd8 <end=
br64+0x4>$
> +# ffff82d040337bda:^Ib8 f3 0f 1e fa       ^Imov    $0xfa1e0ff3,%eax$
> +#
> +# Want to grab the address of endbr64 instructions only, ignoring functi=
on
> +# names/jump labels/etc, so look for 'endbr64' preceeded by a tab and wi=
th any
> +# number of trailing spaces before the end of the line.
> +#
> +${OBJDUMP} -d -w | grep '	endbr64 *$' | cut -f 1 -d ':' > $VALID &
> +
> +#
> +# Second, look for any endbr64 byte sequence
> +# This has a couple of complications:
> +#
> +# 1) Grep binary search isn't VMA aware.  Copy .text out as binary, caus=
ing
> +#    the grep offset to be from the start of .text.
> +#
> +# 2) dash's printf doesn't understand hex escapes, hence the use of octa=
l.
> +#
> +# 3) AWK can't add 64bit integers, because internally all numbers are do=
ubles.
> +#    When the upper bits are set, the exponents worth of precision is lo=
st in
> +#    the lower bits, rounding integers to the nearest 4k.
> +#
> +#    Instead, use the fact that Xen's .text is within a 1G aligned regio=
n, and
> +#    split the VMA in half so AWK's numeric addition is only working on =
32 bit
> +#    numbers, which don't lose precision.
> +#
> +eval $(${OBJDUMP} -h | awk '$2 =3D=3D ".text" {printf "vma_hi=3D%s\nvma_=
lo=3D%s\n", substr($4, 1, 8), substr($4, 9, 16)}')
> +
> +${OBJCOPY} -O binary $TEXT_BIN

..., like here, is then somewhat misleading considering that the tool
can take one or two filenames as arguments.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Feb 23 11:42:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 23 Feb 2022 11:42:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277344.473806 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMq1y-0002ms-0v; Wed, 23 Feb 2022 11:42:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277344.473806; Wed, 23 Feb 2022 11:42:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMq1x-0002ml-U4; Wed, 23 Feb 2022 11:42:01 +0000
Received: by outflank-mailman (input) for mailman id 277344;
 Wed, 23 Feb 2022 11:42:00 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nMq1w-0002ma-5R; Wed, 23 Feb 2022 11:42:00 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nMq1w-00080g-0Y; Wed, 23 Feb 2022 11:42:00 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nMq1v-00020t-JQ; Wed, 23 Feb 2022 11:41:59 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nMq1v-0001EW-Ir; Wed, 23 Feb 2022 11:41:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=wXF+C+6Ar5DcZ1XGYT0oPQk2lEzFfnts8xxkxNfHx6Q=; b=SKtDC+iJ60J5kPhLiywFpdniXI
	FZvpwgffF7OABUKaGBvf+xuyZAfxKq1B9mjB0fGs1aiXRIAoP6d1IrOr34fceCZx0aDYwQv9tOZOU
	YxMu0AWUbvi/z4B3B1pA2YfFloe3RrgsGWVoLQtD57XYgutl40YoOK2maeA8XOkkqu1I=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168201-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 168201: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=5c1ee569660d4a205dced9cb4d0306b907fb7599
X-Osstest-Versions-That:
    linux=917bbdb107f8767cb78f24e7d6725a2f93b9effe
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 23 Feb 2022 11:41:59 +0000

flight 168201 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168201/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168196
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168196
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168196
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168196
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168196
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168196
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168196
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168196
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                5c1ee569660d4a205dced9cb4d0306b907fb7599
baseline version:
 linux                917bbdb107f8767cb78f24e7d6725a2f93b9effe

Last test of basis   168196  2022-02-22 18:39:54 Z    0 days
Testing same since   168201  2022-02-23 03:40:46 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Christian Brauner <brauner@kernel.org>
  Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Michal Koutný <mkoutny@suse.com>
  Tejun Heo <tj@kernel.org>
  Waiman Long <longman@redhat.com>
  Zhang Qiao <zhangqiao22@huawei.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   917bbdb107f8..5c1ee569660d  5c1ee569660d4a205dced9cb4d0306b907fb7599 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Wed Feb 23 12:05:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 23 Feb 2022 12:05:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277357.473817 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMqOV-0005HN-VT; Wed, 23 Feb 2022 12:05:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277357.473817; Wed, 23 Feb 2022 12:05:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMqOV-0005HG-SC; Wed, 23 Feb 2022 12:05:19 +0000
Received: by outflank-mailman (input) for mailman id 277357;
 Wed, 23 Feb 2022 12:05:18 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=PMTg=TG=citrix.com=prvs=046033a78=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nMqOU-0005HA-HW
 for xen-devel@lists.xenproject.org; Wed, 23 Feb 2022 12:05:18 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id dbc5a87c-94a0-11ec-8539-5f4723681683;
 Wed, 23 Feb 2022 13:05:16 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dbc5a87c-94a0-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645617916;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=WbsRgmoUasaXVoGoDDiAqVNaSlHnpV7a6AYVQIYHgVI=;
  b=Rn4niwT+4l2j6y2dd004hAcDgjRmrKhNNI2S4C1UWRZYdWBZJwmRpl7P
   KWTokEYbyK8SsPg+6vNzJRYCCLL5Ingh55/tRUEKymnwb2QfRSc90c6sJ
   3pZZFPojyNno6QYwDVkS5EfknP5VBE8Z1ntgixX21t9tJawSFpkwHgVI8
   E=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 65210068
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:xZGv1K/1DZiQyzFaS5TKDrUDvX6TJUtcMsCJ2f8bNWPcYEJGY0x3z
 zAeWm/Sb6zYZWT1eNtxOYTn8BlVv8PTnIdiHVA9pX08E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si+Fa+Sn9T8mvU2xbuKU5NTsY0idfic5Dndx4f5fs7Rh2NQw24LiW1rlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCnaG5RQ0uLIT9pN1DDwZ5Azp4HIda9paSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFKoZtmtt0nfyCvE+TIqYa67L+cVZzHE7gcUm8fP2O
 ZdDMGI3MkSojxtnAXpOMKA1s/uUm1bdYzlIpFO3obEm/D2GpOB2+Oe0a4eEEjCQfu1Kmm6Iq
 2SA+H72ajkKOdraxTeb/3aEgu7UgTi9SI8UDKe/9PNhnBuU3GN7IB8cWEa/oPK5olWjQN8ZI
 EsRkgIrpLI3/VamTfH8WQO5u3+OuhMAW9tWHPY+4QvLwa3Rizt1HUBdEGQHMoZ/8pZrG3p6j
 Tdlgu8FGxRSubGfTmC0x4ut82+tGDgOK04oeSEtGF5tD8bYnKk/iRfGT9BGGaGzj8HoFTyY/
 w1mvBTSlJ1I05dVivzTEUTvxmv1+8OXFlJdChD/Azr9hj6VcrJJcGBBBbLzyf9bZLiUQVCa1
 JTvs5jPtbteZX1hecHkfQnsIF1Lz6vdWNE/qQQ2d3XEy9hL0yT/FWy3yGsjTHqFyu5eJVfUj
 Lb74Gu9HqN7MnqwdrNQaImsEcksxqWIPY27Cq2JM4QWMsItK1/vEMRSiai4hTyFfK8Ey/xXB
 HtmWZz0USZy5VpPllJauNvxIZd0n3tjlAs/tLjwzgi90Kr2WZJmYextDbd6VchgtPnsiFyMq
 753bpLWoz0CALyWSnSGquY7cAFVRUXX8Lir8qS7gMbYeVE4cIzgYteMqY4cl3tNxfoNzb6Qp
 innMqKaoXKm7UD6xcyxQikLQJvkXIplrGJ9OiopPF2y3GMkb5rp56AaH6bbt5F8nAC/5ZaYl
 8U4Rvg=
IronPort-HdrOrdr: A9a23:i73QNKnsQpMREVDdDpieYIjlL+/pDfOCimdD5ihNYBxZY6Wkfp
 +V88jzhCWZtN9OYhwdcIi7SdS9qXO1z+8R3WGIVY3SEzUOy1HYUL2KirGSjQEIeheOutK1sJ
 0PT0EQMqyIMbEXt7eY3OD8Kadb/DDlytHouQ699QYUcegCUcgJhG0ZajpzUHcGPzWubaBJT6
 Z0jfA3wwZIDE5nCPhTcUN1ONQryee79q7OUFojPVoK+QOOhTSn5PrRCB6DxCoTVDtJ3PML7X
 XFuxaR3NTij9iLjjvnk0PD5ZVfn9XsjvFZAtaXt8QTIjLwzi61eYVaXaGYtjxdmpDt1L9qqq
 iPn/4TBbU215rjRBDznfIr4Xin7N8a0Q6m9bZfuwq7nSW2fkNjNyMLv/MnTvKQ0TtfgDg76t
 MQ44vRjesmMfuL9h6NluTgRlVkkFG5rmEllvNWh3tDUZEGYLsUtoAH+lhJea1wVx4SxbpXWd
 WGNvusrMq+sGnqG0zxry1q2pihT34zFhCJTgwLvdGUySFfmDR8w1EDzMISk38c/NZlIqM0qt
 jsI+BtjvVDX8UWZaVyCKMIRta2EHXERVbJPHiJKVrqGakbMzbGqoLx4r8y+Oa2EaZ4hqcaid
 DEShdVpGQyc0XhBYmH24BK6AnERCGnUTHk2qhllu5EU33HNc3W2AG4OSITepGb0oYi6+XgKo
 OOBK4=
X-IronPort-AV: E=Sophos;i="5.88,390,1635220800"; 
   d="scan'208";a="65210068"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=SFXnxPjfppIrvzEXF3fOlJXNkJuyDB0YD0Bfne4YZqgkXPcKGg7p8NPZT+8RBgKuzcyy+rG3vuUUeB3Na6/XFNMOHU0AYl/dvWYgNJvYpOLEjlgHuL50PK2nyPDKGYM1ZmahE3d4emnYsonnsxanp+DZR5oaXAnCuNPwtXXd0NrlV4JmK5ZRPRzc8Rp31KVbepXUKWsmNU2mfHkWR30A6+q/+XwPnkKD61YpVzwPRwhaxkHt4xZgTInG5CfESkpZdjaSk9AsdwklemYWMflZ4bpFMadW69YXB9RmiW7Vnqm6LdqQtHSKevfLWCtHBCUfUfTk4QOi1tou50zoBwBKrQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=WbsRgmoUasaXVoGoDDiAqVNaSlHnpV7a6AYVQIYHgVI=;
 b=kpKGRBnoU/i7QJs+1XzOmxTiJn0HBNP6PouB01MgQZthE+95jRC87XA4CWAmwtC3a2E3A9tKBVUgE0aA7LHY/+SBCh1NSPmOjmEDrQ4qwSZZE+w/RMjmbD2hmompqrvHAhNyyQCgUGmpRgM2jpM4BE0lGMKC4sOi+E2PL/mpdc9vco0OerQ0/r4l0jaz7Xz3y35WJud/FyHlPMj8Gbp7PUXo93UmAPUM6jRjVWQwjaGZMBLVpN0UExMny+JDw/Ks7mZNTSvLRz2TIXBA2Wrk1zY/HEG1jH0zQb5NhlmAEeP+PrjfUg7bSHJbS83rMi1BlLSumtpz6sJj8JbZxjDFAA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=WbsRgmoUasaXVoGoDDiAqVNaSlHnpV7a6AYVQIYHgVI=;
 b=OeZGjzGNpGx92lcd5UT2hkCLdZcMjTJlt570YIWQZmqdYB/cFNoIkC18sWLRfJHFg00STjt4QORauYiGKS7l7Ky1zdb6jV2BpB0GWQOn1WEWGbFw3PaP8/ViQGlmKP9Wk+p4gS90aUVgsyqL6beDA+a93la9lcDgDBpUKh8QkYo=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: =?utf-8?B?TWFyZWsgTWFyY3p5a293c2tpLUfDs3JlY2tp?=
	<marmarek@invisiblethingslab.com>, Roger Pau Monne <roger.pau@citrix.com>,
	Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v3 60/70] x86: Build check for embedded endbr64
 instructions
Thread-Topic: [PATCH v3 60/70] x86: Build check for embedded endbr64
 instructions
Thread-Index: AQHYKAHJByKzjV/vxUOU3yFx/Fz376yhAcIAgAAJbQA=
Date: Wed, 23 Feb 2022 12:05:09 +0000
Message-ID: <505a8553-5930-762b-ed07-f8f49df20064@citrix.com>
References: <20220222152645.8844-1-andrew.cooper3@citrix.com>
 <20220222152645.8844-15-andrew.cooper3@citrix.com>
 <48241c60-294b-782f-7217-45a3dc929c38@suse.com>
In-Reply-To: <48241c60-294b-782f-7217-45a3dc929c38@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: bedd024b-67bd-4fd3-1f53-08d9f6c4bd01
x-ms-traffictypediagnostic: SN6PR03MB3693:EE_
x-microsoft-antispam-prvs: <SN6PR03MB3693F847BCC092CF9E64D9F6BA3C9@SN6PR03MB3693.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: PZyEM/jL2Vy42F10KON+t+8UIppzz80/wwiRxVSr12dVunDA4cRttzeQ6ozi0ERzsJQjxV9qwZYx9A/eLZU2j3n3W6XsamW1lP8UiJLsqtivdD4mksbcglrFlsujmUX15nVy7v0PEDJ5b9VIa9+gv6+ag9AUWcApOAtv0s5/NTfRkyWYZtW1mdLaNoxaoAkMztHG5Wkyz+vXnzXZZqkLHwOziC050HVjr2T202LHU0PR4ht1oXuB4IWiT1br9a6fRDR6CRLS4Q7lfbFwMGvuOUrSiXW4mSXplFy5N/8ZSbDYKcFOk6aTO66kinB1LIsxn6z06HTuCplh/Ogr/jcBlkSrK+2iATLViQPrMCCCajP7evdiGYUbgn82VWut5jQN0v9Ez8JKbP1RngSy62cy/q/MEbThkwY4HkvjyI5xjCxVk46H9OAfMnM1SMmSGILbyh/Km9GH3lorm2hswQc6koMAdkH6cmPIerYjP95VgqqXBI6ZFu96HwHZ/4tKUIiyPkSqS111oFSPA9Wso/Dz6e3LylGnH/kioOPoyHVGXtJ0+7IxUbXaS7q/XPpNjtVrRbZn+YMdk1i5/YVo4re1Pm7FtfetqLJVf7i7w/tIPDy7XaRMrrqV0pgugC4LlgGK+bLjL4cnEQYgoDZXMkqkBbB4s5uKlxqz7c9zUKCp5gms+8xF/TUcnE4rb4l6aWBGQbq2q0iukzP/IxwWfNoBWZ0ztLPxy/DZ3ojAa7G91PlBoXjDGDbVVxC4ic6yaGyY4gy4ihVB1Gq/hqFtEsPtPA==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6512007)(83380400001)(86362001)(2616005)(26005)(186003)(38070700005)(2906002)(91956017)(66574015)(6916009)(76116006)(31686004)(54906003)(66946007)(66476007)(4326008)(66446008)(66556008)(8676002)(38100700002)(64756008)(8936002)(6506007)(508600001)(36756003)(31696002)(53546011)(6486002)(71200400001)(316002)(5660300002)(122000001)(82960400001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?ZDc2ZDQ4Z2RXZGp1cHpUNEg3c1Ayb0tIK0FLRk04R0NQSm5vbENRdnhjRC90?=
 =?utf-8?B?R0F1NUM3SGVGOVhObE4vdVBHdkNOanhuUzZ4Ti9lQU1RSmJ3bkwvYVpub0M0?=
 =?utf-8?B?ZmQwL0h3di9IR0FYMmtveGZmQWtZcFppdWx1U0d4Nnp1Nk9IdjQwOGY0RXE0?=
 =?utf-8?B?WDlFa1dnRDdoZUcrWFZJaENGek9NdHRFdXFMUjNnV2IyY2ZSUm9MQUp1aUdF?=
 =?utf-8?B?TE1nM3FVWERwYk94dHAvcVBBUkp1cHR1bzBWWDlIbzMyZE9oL1hGU245cnZa?=
 =?utf-8?B?NUlUbUJxTGZpMERNS2grbHA2SG1uNFdlU3dTQTZab2J2TXZtTlZTVU5uVm9j?=
 =?utf-8?B?dzNmZml5SnR1N3JyODAxTlNLdGNBQlY1ZldVZS9qalF1c0x4VVhqbVpJR1pU?=
 =?utf-8?B?UVdYSWZzTzBlcTZJcnlLQVRGSFJFdVdZdGJzK0NJRDVSY1VEdzFCUk4vYVdQ?=
 =?utf-8?B?emxTNDUvMWUzWTRFSk9tM1V3Rk5XRFRBM2kxWUpnKzhwZENsODlVU0VaSVE5?=
 =?utf-8?B?L0NBOTdiVURXeTVLcmdzV1k3WDFFM1hwSWdXNFpIcXZBSm1iOXNBeWJaWWI2?=
 =?utf-8?B?RkFSRndvZzZhdC81OHNEZGRRemxBL3hvT1hmb1dsQTh6cFJyMFhCZm1tVmx2?=
 =?utf-8?B?TUoxWlVZdDc2K3JFVXN5cytBcWdrWkFPVE1DR0g2K3Rob2lnSzBxOTNuOFkx?=
 =?utf-8?B?UkhWdjVmVnc2blN4QVZ5b3E1c0tnOFlUUGxSWnJPakZuQk8yenlSZGpWSWli?=
 =?utf-8?B?aGgrQXY5TnNTRlhCREc0WGZkbFhaVFpVcnVkT2pIc3RaN0lWYkN4aFVFRmVs?=
 =?utf-8?B?ek9uaEVzMkFFTmc1Y3RhOTBrL2ZZZEZUQlFjT3p3RTQ4UGYyTlVPN05rTjlH?=
 =?utf-8?B?bGIyZG1nS1F1eG5wckhHOWRneUxEclpYYkowalU3SDhFeHlJNmRuWFV3RUdI?=
 =?utf-8?B?djRWMFFyMEFUNUJzQmJ3V1FTaTVuWXA4Y0l2b3FzZEJjQWpLMnM5aG96cTQ5?=
 =?utf-8?B?dkZRbWtDcGZkZVA1cytDeVNFdnpNS09oS0RCR1hnUlBCeG1qcDlwc1ZTeTVG?=
 =?utf-8?B?YkIrU2dWTlZnUTNNbk5pMEYxT3FLalRzL2Nab3ZHQ1dQKzNFbkhTQUd3RnRS?=
 =?utf-8?B?cGJwMlUyWmY1UXFSa2ZiTTNMRWx6cERsWTdjYnpOUzY3NHFLUzlES1R2SlZZ?=
 =?utf-8?B?aDNMTjIrT3A5eVZlaEdReUV0VlBwa2NkekhYUVJPNi82eTlvM05FZUN4UG1p?=
 =?utf-8?B?dXBkN0xUdlIzZllEOVdacW44TlhWaHNBeThPTDJSeUp0eThKZlZtZFhzVG01?=
 =?utf-8?B?N29SMWNSTGVNUjVJVGNmbWlZRFdHek1xbjV0eG5yellSOWVZdzVyNW9mQm1B?=
 =?utf-8?B?YkVvM3Q4S1g3cjBxdFpyd3lMNmwxb3dQSXAzQjNnNjE1SWVIQnB4NE9tMTd4?=
 =?utf-8?B?RXp0aXlsRy9XbjJRdUZzVklzUlJjK1NEdVhxVGNuWGRNcmp2aGpKNEpud3Ux?=
 =?utf-8?B?Qm0zWUFnS0ZrUFBlZWZldlBnaVVJQUZFenhJU0Eza3Z3K1lEQUNVZ3NkT2ND?=
 =?utf-8?B?SkIrem55WnJ0ZDQvRm9GeFZGQlgwUkhPRFNsUTRtY0dkNzVVRHJyaDU5R1Fy?=
 =?utf-8?B?ak56YnFYZUtzcDJRUGxHc041M3A4dkE5bHkzOGhnSVVGN3RnejBvVWkxZDRp?=
 =?utf-8?B?RndXa3FpMXljbm9GRFllUFR6UW1jKzB5SktLY3JTQkgrdHpWb2ZNbkkxQkN2?=
 =?utf-8?B?Z0JTSkZkdFhYdWJLbXlnTExpMWtMK3JOU2FCNUVLRVhRWUNEZzVrUGE2YUV4?=
 =?utf-8?B?TXpPeCtFNElzelNZUVMvRFI0Z1hob2RITVh5NTNqMDRJcTg0eWxIdStVa1FO?=
 =?utf-8?B?QWZmQWR0Mk5Hemh1Qkd6QlZRSEpVQVB4RzJPM01BamtzWVc1ZmwrK21sampm?=
 =?utf-8?B?M3RKcFR6aUs3YjFwcDgwaTZIVWJHUmhMcVk3eDh5YkVKNkJDeVBWZWhKN3dx?=
 =?utf-8?B?NzR3eG5ML21xMThDd2J1eEtOZ1laM1ZZSTdGd05Nc1pYcWdyQ01lMWF4YnZE?=
 =?utf-8?B?ZGh6SDkzV3ZablZ1SHdVRmc5ZkhZVFlHWGFGcHlONnVuUTdCZ09rcG42c0Vi?=
 =?utf-8?B?cS81RmhYUUNCLzBIOEtoc3d5TUdYbmhQZ1RUV1JWSk5vZ1pGRVg4VDdnNzh5?=
 =?utf-8?B?Sm1CcDZKQkh2NmhORE5QSEcrUjZTMGNrMDE1MDNKeFArY2d0OWxRMUpsVllU?=
 =?utf-8?B?UnR5Nkc4Ry92U0tRYm5Gc2c4S3hRPT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <443FEEFF97EE13409DF0464DBF1C76C3@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bedd024b-67bd-4fd3-1f53-08d9f6c4bd01
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Feb 2022 12:05:09.3688
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: S/hrMHJ4SQ8jUqIkplH5FRdADX0MTr8qP5sK+gsUeYQx9R42zOUoqEQ5YmfB5s+ztZMRy0XIif6BpF+3ARs+kQPaRMmSdwpuvmW/PXyqxVI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR03MB3693
X-OriginatorOrg: citrix.com

T24gMjMvMDIvMjAyMiAxMTozMSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDIyLjAyLjIwMjIg
MTY6MjYsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiB1cCBvbiBhIG5vbi1pbnN0cnVjdGlvbiBi
b3VuZGFyeS4gIFN1Y2ggZW1iZWRkZWQgaW5zdHJ1Y3Rpb25zIG1hcmsgbGVnYWwNCj4+IGluZGly
ZWN0IGJyYW5jaCB0YXJnZXRzIGFzIGZhciBhcyB0aGUgQ1BVIGlzIGNvbmNlcm5lZCwgd2hpY2gg
YXJlbid0IGxlZ2FsIGFzDQo+PiBmYXIgYXMgdGhlIGxvZ2ljIGlzIGNvbmNlcm5lZC4NCj4gVGhp
bmtpbmcgYWJvdXQgaXQ6IFdvdWxkbid0IGl0IGJlIHlldCBzbGlnaHRseSBtb3JlIHJlYXNzdXJp
bmcgdG8gYWxzbw0KPiBsb29rIGZvciBFTkRCUjMyPw0KDQpJIGNvbnNpZGVyZWQgdGhhdCwgYnV0
IGl0J3MgYXdrd2FyZCB0byBkbyBhbmQgZG91YmxlcyB0aGUgbGVuZ3RoIG9mIHRoaXMNCmFscmVh
ZHkgfjAuN3MgKHgyIGZvciBlZmkgYmVjYXVzZSB0aGlzIHN0ZXAgaXNuJ3QgcGVyZm9ybWVkIGlu
IHBhcmFsbGVsKQ0KZGVsYXkgdG8gdGhlIGJ1aWxkLg0KDQpXZSBkbyBub3QgaGF2ZSBfX0hZUEVS
VklTT1JfQ1MzMiwgc28gRU5EQlIzMiB3aWxsIHlpZWxkICNDUFtlbmRicl0gaWYNCmVuY291bnRl
cmVkLg0KDQpJZiBhbiBhdHRhY2tlciBoYXMgbWFuYWdlZCB0byBlZGl0IHRoZSBHRFQgdG8gaW5z
ZXJ0IGEgY29tcGF0aWJpbGl0eQ0KY29kZSBzZWdtZW50LCBhbmQgaGlqYWNrZWQgYSBmYXIgdHJh
bnNmZXIgdG8gdXNlIGl0LCB0aGVuIHRoZSBhYnNlbmNlIG9mDQpFTkRCUjMyJ3MgaW4gdGhlIGJp
bmFyeSBpc24ndCBnb2luZyB0byBiZSBhbiBpbXBlZGltZW50Lg0KDQo+DQo+PiBXaGVuIENFVC1J
QlQgaXMgYWN0aXZlLCBjaGVjayBmb3IgZW1iZWRkZWQgYnl0ZSBzZXF1ZW5jZXMuICBFeGFtcGxl
IGZhaWx1cmVzDQo+PiBsb29rIGxpa2U6DQo+Pg0KPj4gICBjaGVjay1lbmRici5zaCB4ZW4tc3lt
cyBGYWlsOiBGb3VuZCAyIGVtYmVkZGVkIGVuZGJyNjQgaW5zdHJ1Y3Rpb25zDQo+PiAgIDB4ZmZm
ZjgyZDA0MDMyNTY3NzogdGVzdF9lbmRicjY0IGF0IC9sb2NhbC94ZW4uZ2l0L3hlbi9hcmNoL3g4
Ni94ODZfNjQvZW50cnkuUzoyOA0KPj4gICAweGZmZmY4MmQwNDAzNTJkYTY6IGluaXRfZG9uZSBh
dCAvbG9jYWwveGVuLmdpdC94ZW4vYXJjaC94ODYvc2V0dXAuYzo2NzUNCj4+DQo+PiBTaWduZWQt
b2ZmLWJ5OiBNYXJlayBNYXJjenlrb3dza2ktR8OzcmVja2kgPG1hcm1hcmVrQGludmlzaWJsZXRo
aW5nc2xhYi5jb20+DQo+PiBTaWduZWQtb2ZmLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29v
cGVyM0BjaXRyaXguY29tPg0KPiBSZXZpZXdlZC1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1
c2UuY29tPg0KDQpUaGFua3MuDQoNCj4NCj4+IC0tLSBhL1JFQURNRQ0KPj4gKysrIGIvUkVBRE1F
DQo+PiBAQCAtNjgsNiArNjgsNyBAQCBwcm92aWRlZCBieSB5b3VyIE9TIGRpc3RyaWJ1dG9yOg0K
Pj4gIEluIGFkZGl0aW9uIHRvIHRoZSBhYm92ZSB0aGVyZSBhcmUgYSBudW1iZXIgb2Ygb3B0aW9u
YWwgYnVpbGQNCj4+ICBwcmVyZXF1aXNpdGVzLiBPbWl0dGluZyB0aGVzZSB3aWxsIGNhdXNlIHRo
ZSByZWxhdGVkIGZlYXR1cmVzIHRvIGJlDQo+PiAgZGlzYWJsZWQgYXQgY29tcGlsZSB0aW1lOg0K
Pj4gKyAgICAqIEJpbmFyeS1zZWFyY2ggY2FwYWJsZSBncmVwIChpZiBidWlsZGluZyBYZW4gd2l0
aCBDRVQgc3VwcG9ydCkNCj4gTml0OiBXaXRoIHRoaXMgKG1heWJlIHRoaXMgd2FzIHRoZSBjYXNl
IGFscmVhZHkgZWFybGllciB0aG91Z2gpDQo+IHMvd2lsbC9tYXkvIGluIHRoZSBwcmV2aW91cyBz
ZW50ZW5jZT8NCg0KSSdtIHBsYW5uaW5nIGEgc2VwYXJhdGUgb3ZlcmhhdWwgdG8gUkVBRE1FIGJl
Y2F1c2UgYml0cyBvZiBpdCBhcmUgcXVpdGUNCndyb25nLCBpbmNsdWRpbmcgbG90cyBvZiB0aGlz
IHNlY3Rpb24uwqAgVGhpcyB3YXMgdGhlIGxlYWQgYmFkIGFkZGl0aW9uIEkNCmNvdWxkIGNvbWUg
dXAgd2l0aCB0aGF0IGRpZG4ndCBpbnZvbHZlIGEgbWFqb3IgcmV3cml0ZS4NCg0KPj4gLS0tIC9k
ZXYvbnVsbA0KPj4gKysrIGIveGVuL3Rvb2xzL2NoZWNrLWVuZGJyLnNoDQo+PiBAQCAtMCwwICsx
LDg1IEBADQo+PiArIyEvYmluL3NoDQo+PiArIw0KPj4gKyMgVXNhZ2UgLi8kMCB4ZW4tc3ltcw0K
Pj4gKyMNCj4+ICtzZXQgLWUNCj4+ICsNCj4+ICsjIFByZXR0eXByaW50IHBhcmFtZXRlcnMgYSBs
aXR0bGUgZm9yIG1lc3NhZ2UNCj4+ICtNU0dfUEZYPSIkezAjIyovfSAkezEjIyovfSINCj4+ICsN
Cj4+ICtPQkpDT1BZPSIke09CSkNPUFk6LW9iamNvcHl9IC1qIC50ZXh0ICQxIg0KPj4gK09CSkRV
TVA9IiR7T0JKRFVNUDotb2JqZHVtcH0gLWogLnRleHQgJDEiDQo+IFdoaWxlIGVtYmVkZGluZyB0
aGUgYXJndW1lbnRzIGhlcmUgc2hvcnRlbnMgdGhlIGxpbmVzIHdoZXJlIHRoZXNlIGFyZQ0KPiB1
c2VkLCB0aGUgYXBwZWFyYW5jZSBlc3BlY2lhbGx5IG9mICRPQkpDT1BZIHdpdGggYSBzaW5nbGUg
ZmlsZSBuYW1lDQo+IGFyZ3VtZW50IC4uLg0KPg0KPj4gK0FERFIyTElORT0iJHtBRERSMkxJTkU6
LWFkZHIybGluZX0iDQo+PiArDQo+PiArRD0kKG1rdGVtcCAtZCkNCj4+ICt0cmFwICJybSAtcmYg
JEQiIEVYSVQNCj4+ICsNCj4+ICtURVhUX0JJTj0kRC94ZW4tc3ltcy50ZXh0DQo+PiArVkFMSUQ9
JEQvdmFsaWQtYWRkcnMNCj4+ICtBTEw9JEQvYWxsLWFkZHJzDQo+PiArQkFEPSREL2JhZC1hZGRy
cw0KPj4gKw0KPj4gKyMgQ2hlY2sgdGhhdCBncmVwIGNhbiBkbyBiaW5hcnkgc2VhcmNoZXMuICBT
b21lLCBlLmcuIGJ1c3lib3gsIGNhbid0LiAgTGVhdmUgYQ0KPj4gKyMgd2FybmluZyBidXQgZG9u
J3QgZmFpbCB0aGUgYnVpbGQuDQo+PiArZWNobyAiWCIgfCBncmVwIC1hb2IgIlgiIC1xIDI+L2Rl
di9udWxsIHx8DQo+PiArICAgIHsgZWNobyAiJE1TR19QRlggV2FybmluZzogZ3JlcCBjYW4ndCBk
byBiaW5hcnkgc2VhcmNoZXMiID4mMjsgZXhpdCAwOyB9DQo+PiArDQo+PiArIw0KPj4gKyMgRmly
c3QsIGxvb2sgZm9yIGFsbCB0aGUgdmFsaWQgZW5kYnI2NCBpbnN0cnVjdGlvbnMuDQo+PiArIyBB
IHdvcnN0LWNhc2UgZGlzYXNzZW1ibHksIHZpZXdlZCB0aHJvdWdoIGNhdCAtQSwgbWF5IGxvb2sg
bGlrZToNCj4+ICsjDQo+PiArIyBmZmZmODJkMDQwMzM3YmQ0IDxlbmRicjY0PjokDQo+PiArIyBm
ZmZmODJkMDQwMzM3YmQ0Ol5JZjMgMGYgMWUgZmEgICAgICAgICAgXkllbmRicjY0ICQNCj4+ICsj
IGZmZmY4MmQwNDAzMzdiZDg6XkllYiBmZSAgICAgICAgICAgICAgICBeSWptcCAgICBmZmZmODJk
MDQwMzM3YmQ4IDxlbmRicjY0KzB4ND4kDQo+PiArIyBmZmZmODJkMDQwMzM3YmRhOl5JYjggZjMg
MGYgMWUgZmEgICAgICAgXkltb3YgICAgJDB4ZmExZTBmZjMsJWVheCQNCj4+ICsjDQo+PiArIyBX
YW50IHRvIGdyYWIgdGhlIGFkZHJlc3Mgb2YgZW5kYnI2NCBpbnN0cnVjdGlvbnMgb25seSwgaWdu
b3JpbmcgZnVuY3Rpb24NCj4+ICsjIG5hbWVzL2p1bXAgbGFiZWxzL2V0Yywgc28gbG9vayBmb3Ig
J2VuZGJyNjQnIHByZWNlZWRlZCBieSBhIHRhYiBhbmQgd2l0aCBhbnkNCj4+ICsjIG51bWJlciBv
ZiB0cmFpbGluZyBzcGFjZXMgYmVmb3JlIHRoZSBlbmQgb2YgdGhlIGxpbmUuDQo+PiArIw0KPj4g
KyR7T0JKRFVNUH0gLWQgLXcgfCBncmVwICcJZW5kYnI2NCAqJCcgfCBjdXQgLWYgMSAtZCAnOicg
PiAkVkFMSUQgJg0KPj4gKw0KPj4gKyMNCj4+ICsjIFNlY29uZCwgbG9vayBmb3IgYW55IGVuZGJy
NjQgYnl0ZSBzZXF1ZW5jZQ0KPj4gKyMgVGhpcyBoYXMgYSBjb3VwbGUgb2YgY29tcGxpY2F0aW9u
czoNCj4+ICsjDQo+PiArIyAxKSBHcmVwIGJpbmFyeSBzZWFyY2ggaXNuJ3QgVk1BIGF3YXJlLiAg
Q29weSAudGV4dCBvdXQgYXMgYmluYXJ5LCBjYXVzaW5nDQo+PiArIyAgICB0aGUgZ3JlcCBvZmZz
ZXQgdG8gYmUgZnJvbSB0aGUgc3RhcnQgb2YgLnRleHQuDQo+PiArIw0KPj4gKyMgMikgZGFzaCdz
IHByaW50ZiBkb2Vzbid0IHVuZGVyc3RhbmQgaGV4IGVzY2FwZXMsIGhlbmNlIHRoZSB1c2Ugb2Yg
b2N0YWwuDQo+PiArIw0KPj4gKyMgMykgQVdLIGNhbid0IGFkZCA2NGJpdCBpbnRlZ2VycywgYmVj
YXVzZSBpbnRlcm5hbGx5IGFsbCBudW1iZXJzIGFyZSBkb3VibGVzLg0KPj4gKyMgICAgV2hlbiB0
aGUgdXBwZXIgYml0cyBhcmUgc2V0LCB0aGUgZXhwb25lbnRzIHdvcnRoIG9mIHByZWNpc2lvbiBp
cyBsb3N0IGluDQo+PiArIyAgICB0aGUgbG93ZXIgYml0cywgcm91bmRpbmcgaW50ZWdlcnMgdG8g
dGhlIG5lYXJlc3QgNGsuDQo+PiArIw0KPj4gKyMgICAgSW5zdGVhZCwgdXNlIHRoZSBmYWN0IHRo
YXQgWGVuJ3MgLnRleHQgaXMgd2l0aGluIGEgMUcgYWxpZ25lZCByZWdpb24sIGFuZA0KPj4gKyMg
ICAgc3BsaXQgdGhlIFZNQSBpbiBoYWxmIHNvIEFXSydzIG51bWVyaWMgYWRkaXRpb24gaXMgb25s
eSB3b3JraW5nIG9uIDMyIGJpdA0KPj4gKyMgICAgbnVtYmVycywgd2hpY2ggZG9uJ3QgbG9zZSBw
cmVjaXNpb24uDQo+PiArIw0KPj4gK2V2YWwgJCgke09CSkRVTVB9IC1oIHwgYXdrICckMiA9PSAi
LnRleHQiIHtwcmludGYgInZtYV9oaT0lc1xudm1hX2xvPSVzXG4iLCBzdWJzdHIoJDQsIDEsIDgp
LCBzdWJzdHIoJDQsIDksIDE2KX0nKQ0KPj4gKw0KPj4gKyR7T0JKQ09QWX0gLU8gYmluYXJ5ICRU
RVhUX0JJTg0KPiAuLi4sIGxpa2UgaGVyZSwgaXMgdGhlbiBzb21ld2hhdCBtaXNsZWFkaW5nIGNv
bnNpZGVyaW5nIHRoYXQgdGhlIHRvb2wNCj4gY2FuIHRha2Ugb25lIG9yIHR3byBmaWxlbmFtZXMg
YXMgYXJndW1lbnRzLg0KDQpJIGNhbiByZS1leHBhbmQgdGhlbSBpZiB5b3UnZCBwcmVmZXIuwqAg
VGhpcyB3b3VsZCBiZSB0aGUgZGVsdGE6DQoNCmRpZmYgLS1naXQgYS94ZW4vdG9vbHMvY2hlY2st
ZW5kYnIuc2ggYi94ZW4vdG9vbHMvY2hlY2stZW5kYnIuc2gNCmluZGV4IDg1ODc4MzUzMTEyYS4u
MzAxOWNhMWM3ZGIwIDEwMDc1NQ0KLS0tIGEveGVuL3Rvb2xzL2NoZWNrLWVuZGJyLnNoDQorKysg
Yi94ZW4vdG9vbHMvY2hlY2stZW5kYnIuc2gNCkBAIC03LDggKzcsOCBAQCBzZXQgLWUNCsKgIyBQ
cmV0dHlwcmludCBwYXJhbWV0ZXJzIGEgbGl0dGxlIGZvciBtZXNzYWdlDQrCoE1TR19QRlg9IiR7
MCMjKi99ICR7MSMjKi99Ig0KwqANCi1PQkpDT1BZPSIke09CSkNPUFk6LW9iamNvcHl9IC1qIC50
ZXh0ICQxIg0KLU9CSkRVTVA9IiR7T0JKRFVNUDotb2JqZHVtcH0gLWogLnRleHQgJDEiDQorT0JK
Q09QWT0iJHtPQkpDT1BZOi1vYmpjb3B5fSINCitPQkpEVU1QPSIke09CSkRVTVA6LW9iamR1bXB9
Ig0KwqBBRERSMkxJTkU9IiR7QUREUjJMSU5FOi1hZGRyMmxpbmV9Ig0KwqANCsKgRD0kKG1rdGVt
cCAtZCkNCkBAIC0zNyw3ICszNyw3IEBAIGVjaG8gIlgiIHwgZ3JlcCAtYW9iICJYIiAtcSAyPi9k
ZXYvbnVsbCB8fA0KwqAjIG5hbWVzL2p1bXAgbGFiZWxzL2V0Yywgc28gbG9vayBmb3IgJ2VuZGJy
NjQnIHByZWNlZWRlZCBieSBhIHRhYiBhbmQNCndpdGggYW55DQrCoCMgbnVtYmVyIG9mIHRyYWls
aW5nIHNwYWNlcyBiZWZvcmUgdGhlIGVuZCBvZiB0aGUgbGluZS4NCsKgIw0KLSR7T0JKRFVNUH0g
LWQgLXcgfCBncmVwICfCoMKgwqDCoMKgIGVuZGJyNjQgKiQnIHwgY3V0IC1mIDEgLWQgJzonID4g
JFZBTElEICYNCiske09CSkRVTVB9IC1qIC50ZXh0ICQxIC1kIC13IHwgZ3JlcCAnwqAgZW5kYnI2
NCAqJCcgfCBjdXQgLWYgMSAtZCAnOicgPg0KJFZBTElEICYNCsKgDQrCoCMNCsKgIyBTZWNvbmQs
IGxvb2sgZm9yIGFueSBlbmRicjY0IGJ5dGUgc2VxdWVuY2UNCkBAIC01Niw5ICs1NiwxMCBAQCAk
e09CSkRVTVB9IC1kIC13IHwgZ3JlcCAnwqDCoMKgIGVuZGJyNjQgKiQnIHwgY3V0IC1mIDENCi1k
ICc6JyA+ICRWQUxJRCAmDQrCoCPCoMKgwqAgc3BsaXQgdGhlIFZNQSBpbiBoYWxmIHNvIEFXSydz
IG51bWVyaWMgYWRkaXRpb24gaXMgb25seSB3b3JraW5nIG9uDQozMiBiaXQNCsKgI8KgwqDCoCBu
dW1iZXJzLCB3aGljaCBkb24ndCBsb3NlIHByZWNpc2lvbi4NCsKgIw0KLWV2YWwgJCgke09CSkRV
TVB9IC1oIHwgYXdrICckMiA9PSAiLnRleHQiIHtwcmludGYNCiJ2bWFfaGk9JXNcbnZtYV9sbz0l
c1xuIiwgc3Vic3RyKCQ0LCAxLCA4KSwgc3Vic3RyKCQ0LCA5LCAxNil9JykNCitldmFsICQoJHtP
QkpEVU1QfSAtaiAudGV4dCAkMSAtaCB8DQorwqDCoMKgIGF3ayAnJDIgPT0gIi50ZXh0IiB7cHJp
bnRmICJ2bWFfaGk9JXNcbnZtYV9sbz0lc1xuIiwgc3Vic3RyKCQ0LCAxLA0KOCksIHN1YnN0cigk
NCwgOSwgMTYpfScpDQrCoA0KLSR7T0JKQ09QWX0gLU8gYmluYXJ5ICRURVhUX0JJTg0KKyR7T0JK
Q09QWX0gLWogLnRleHQgJDEgLU8gYmluYXJ5ICRURVhUX0JJTg0KwqBncmVwIC1hb2IgIiQocHJp
bnRmICdcMzYzXDE3XDM2XDM3MicpIiAkVEVYVF9CSU4gfA0KwqDCoMKgwqAgYXdrIC1GJzonICd7
cHJpbnRmICIlcyV4XG4iLCAiJyR2bWFfaGknIiwgaW50KDB4JyR2bWFfbG8nKSArICQxfScgPg0K
JEFMTA0KwqANCg0KfkFuZHJldw0K


From xen-devel-bounces@lists.xenproject.org Wed Feb 23 12:33:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 23 Feb 2022 12:33:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277365.473828 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMqpT-0000NA-8z; Wed, 23 Feb 2022 12:33:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277365.473828; Wed, 23 Feb 2022 12:33:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMqpT-0000N3-4F; Wed, 23 Feb 2022 12:33:11 +0000
Received: by outflank-mailman (input) for mailman id 277365;
 Wed, 23 Feb 2022 12:33:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=PMTg=TG=citrix.com=prvs=046033a78=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nMqpS-0000Mx-69
 for xen-devel@lists.xenproject.org; Wed, 23 Feb 2022 12:33:10 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c0380aed-94a4-11ec-8539-5f4723681683;
 Wed, 23 Feb 2022 13:33:07 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c0380aed-94a4-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645619587;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=1Wetn+zddTJITpG8eRN2BGHMe/qZpbS3LX2iByw6EHY=;
  b=cWjDkJ5PXOyeCDfHnlubF2dc31o2Gz2NJNM8sW6P0gYfh6aHUZdvd+2G
   uIKVyNuY8cuCdEPK6aEf+X+y6N0F2XG5lbI8/JH/aDX/DSpGJYjGFOG3V
   ao8mGEik5XBi9LnhHx0mqTBdaAEil/DgMjFg96IyZK9BUglIzDRLCWTPE
   g=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 64805068
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:ptcQAawYHrn08QnTwGt6t+clxirEfRIJ4+MujC+fZmUNrF6WrkUHm
 GIZUG3SP66NZzH8eYxzYI6yp04Bu8fSnIAwT1Zo+yAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGHdJZS5LwbZj2NYy24PhWmthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 Nplj7qBVDkmPof1qt8dXkJnCRF+MKJk5+qSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DFYUToHx/ixreCu4rW8vrSKTW/95Imjw3g6iiGN6AO
 5pBNGIxPHwsZTVjFQZGEIMHv9zxg2PDImJpl3y34po4tj27IAtZj+G2bYu9lsaxbdpRtlaVo
 CTB5WuRKgEXMpmTxCSI9lqoh/TThmXrVYQKDrq6+/V2xlqJyQQ7ChcbSF+6qvmRkVOlVpRUL
 El8x8Y1hfFsrgrxFIC7BkDm5i7f1vIBZzZOO9cc2Ryzxar+2jSiBmVfcSRxaNEpltBjEFTGy
 WS1t9/uADVutpicRnSc6qqYoFuOBMQFEYMRTXRaFFVYurEPtKl210uSFYg7TMZZm/WoQWmY/
 tyckMQpa1z/Z+Yv3r7zw13IiinESnPhHl9svVW/so5IA2pEiG+Zi26AtACzARVodt/xory9U
 J4swZT2AAcmV8zlqcB1aL9RdIxFHt7cWNEmvXZhHoM66xOm8GO5cIZb7VlWfRk1b5tZJ2e5O
 hOM6Wu9AaO/2lPwMcebhKrrVqwXIVXIT4y5Bpg4kPIUCnSOSON31H43PhPBt4wcuEMtjbs+K
 f+mnTWEVh4n5VBc5GPuHY81iOZzrghnnD+7bc2rnnyPjOvFDFbIGOhtDbd7Rr1ghE9yiF6Oq
 Ig32grj40g3bdASlQGNr9ZIdAhSdSJT6FKfg5U/S9Nv6zFOQQkJI/TQ3akga8pimaFUnf3P5
 XazRglTz1+XuJENAV7ihqxLAF83YatCkA==
IronPort-HdrOrdr: A9a23:RfFN9q+3nNB3z/oIF1Fuk+F2db1zdoMgy1knxilNoENuHfBwxv
 rDoB1E73LJYW4qKQwdcdDpAtjkfZtFnaQFrrX5To3SIDUO31HYYr2KjLGSjwEIfheRygcz79
 YYT0ETMqySMbE+t7eB3ODaKadg/DDkytHRuQ629R4EJmsKC52IrT0JcTpzencGHzWubqBJcK
 Z0k/A3wQZIDk5nCfhTaEN1PdTrlpnurtbLcBQGDxko5E2lljWz8oP3FBCew1M3Ty5P6a1Kyx
 mEryXJooGY992rwB7V0GHeq75MnsH699dFDMuQzuAINzTXjBqybogJYczAgNl1mpDs1L8Zqq
 iJn/4SBbU115oXRBDynfLZ4Xik7N/p0Q669bbXuwq6nSWzfkNENyMIv/MmTvKe0Tt7gDg06t
 M644rS3aAnfC/ojWDz4cPFWAptkVfxqX0+kfQLh3gaSocGbqRNxLZvt3+9Pa1wVR4S0rpXWN
 WGzfuskMp+YBefdTTUr2NvyNujUjA6GQqHWFELvoiQ3yJNlH50wkMEzIhH901wua4VWt1B/a
 DJI65onLZBQosfar98Hv4IRY+yBnbWSRzBPWqOKRDsFb0BOXjKt5nriY9Frt2CadgN1t8/iZ
 7BWFRXuSo7fF/vE9SH2NlR/hXEUAyGLELQIwFllu9EU5HHNcjW2He4OSMTeuOb0oAiPvE=
X-IronPort-AV: E=Sophos;i="5.88,390,1635220800"; 
   d="scan'208";a="64805068"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=TBuwGofTIRDemmoqwuT9LZpFne1P4sgX5MSVXEGIbj2bnQdc3xGgKt5gWUDlaPi2gJlh3dQKXKctWEKHswE+sywNoDxbfO79t1hkXgg0gyw8G3CybL6uzZXqBjpsDGx5+3efWkKEZS5kKwbJztIBnAEoHCBVZt0eE5mklqSjaXES4P59hSrjUY1rZwMcvkyqOrAWi9Rtpff0sE3GodRqls2/sDCVeSSRFlgc1scWrR2IMn195eIQ7ia6j9u1VglxXuSuApX6WRchbFg6suV/Rcv2zogEXz0U5cllc7ajB5lw6Xt6PxymCtc/4MhMQalpX+TPfVZCxSbAg93/hJvzCQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=1Wetn+zddTJITpG8eRN2BGHMe/qZpbS3LX2iByw6EHY=;
 b=ZJsSuQMPwby0hq9JQWbS9zpai4H70XaMGsZstJEgDfrgwDaPyoIVhkEb/W4h0AKh697ApN0Tg++XkNtB+GQ8QigYMUfKpgPFzLmn2af4Ym65pT1z3IQvtKo5IZDgJ8d7K0M5ie/li+4+valmajO8paMMsklfP6/CtvRORYdAC6oM36bvogj/j06WiMFRY8EHzDiMnZUblEieni6A+o/aoLDdZyTW7lz6OG7JnYdxGO8MF6qcUDcWQZTgurckLcD48Mvgu1kphJAdq8ENCn74Ia3SgZKlv2BLrx2fDyZILfqm6BTjbshdmLSAD26uqdKUj502xv0LrOecm1VmeplYFw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=1Wetn+zddTJITpG8eRN2BGHMe/qZpbS3LX2iByw6EHY=;
 b=HAN276tSslO8dw0W5Q6thTsaY3ISglZsPreZ63awx72pVDPpcw7F8EDHpp+cb0ZufWsU6P640z+58q9JOkuXLnkhQK+jL5+2rNHOzMw4IEOqL8sGS5E/PADQM85X84UsLD0QXpift9C9XZxpnbXCLlqcKu/w382BvPkNhBx+A5c=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Wei Liu <wl@xen.org>, Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH 3/3] x86: correct fencing around CLFLUSH
Thread-Topic: [PATCH 3/3] x86: correct fencing around CLFLUSH
Thread-Index: AQHYKJ4ejcG5b0mVokmgaQG/G3Z+sqyhEcAA
Date: Wed, 23 Feb 2022 12:33:00 +0000
Message-ID: <e81ea521-b0fb-e1b8-5db8-025d35077cc3@citrix.com>
References: <91935ffd-a270-f1a1-28f1-645fa4167fcd@suse.com>
 <7026f7df-1f70-0018-a6eb-b7e043b279d8@suse.com>
In-Reply-To: <7026f7df-1f70-0018-a6eb-b7e043b279d8@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 46bcadbc-128e-4e9d-fbfb-08d9f6c8a122
x-ms-traffictypediagnostic: BN6PR03MB3060:EE_
x-microsoft-antispam-prvs: <BN6PR03MB30608B0B8F460EF4C0B067AFBA3C9@BN6PR03MB3060.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: lczfjsMMkvL7o4zPD03UAJhmwNvadLVKVHlqW/vGCAjkFbF5JoJ3DDFXD+wwJpaYd71DFhqX+mA6IXtdhL7PJm3oYt/2gGH559MsnH8aU7VcKw2ArsNArnTJLMs+2yP61RO3b9gll3j+6d6L3EqOBcd/oLaUBGsIsv87ntCSgG3ycrGpX0bb3oJvfFFzz3vi4CZbhlMVssNUXHJYK5+sGKBdXOzamA0/Cx7UAa4js3CYGctsq56KeI15OJcVsdwGJn8aEyQyN3SG4D9IoAs2uu3rn3vSIF9XIC4+7tOJZdckzBit7turnz5CiDoASrGtpNoOBe9BxVRWafVPcVig1JzRYMyI2F926KgiT/m16GeVU8dpkLbdxNLsBfzxjY5+p9UlT6Ie4Wck9AJv3/C7zJAbBSuq4xv27K0E4JF+LtGiFjRsD7iPRAud+CPZyPnieTptIPEm54QJ5my6M0xxK8pYuBETtpfsjmZrlEXAeH+IUr4htMArX8wI2HgrTYlrxiz8qci7v92z+OldDxZau8ZSJgvcOSGZMi4x8H6OvN74WD+Uu6q1msRDw1o2hSUXfAG077uUlo5b4tzYiNcQ0qvvO0+Cm+EGpgvxpJD0fcLXSmg6SnrqhMJ7WavSnOkh9iKpOjScYBmuC4Rqt9rZL0VjCFEVCrmJM3bm5XDdkTLkT5Vo71tGtqfAeXDPh9yf7Saga1GdEknDXfk16qjTTenTUPp0aXnjeIKUExT8TCyWiANJolmX8xbi0THUb7Q/Om8VVPa2a/7+lQWqbhH4HA==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(83380400001)(86362001)(31696002)(508600001)(31686004)(26005)(6486002)(91956017)(186003)(5660300002)(8676002)(107886003)(71200400001)(36756003)(64756008)(66556008)(66446008)(76116006)(66946007)(4326008)(2616005)(66476007)(38070700005)(53546011)(82960400001)(6506007)(2906002)(54906003)(110136005)(122000001)(6512007)(38100700002)(8936002)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?VWRJQ1FMeTBKa1ZUcEhKNTlzYjNRamk2TllkVzJ3UW1jZXJXdjc5Y2pYem13?=
 =?utf-8?B?YmlKNkw1Qjd0ZFZ5NTVqTUNlU2VkZEtxU1BZZURvcW41TFRtMHFIZzhTNGJr?=
 =?utf-8?B?dlEyOGZXSTBoMnNuSlpBTHlNK2tYRXpxbEQ1NjVncHpLN2ViM1pMUk52SWhy?=
 =?utf-8?B?QTViallJZDM0YVlQTGVEMURCNllNdm1Gdyt3ZUlrbDE0aTBiamJPV1J4d1dn?=
 =?utf-8?B?a1h0cDZxQ1dBTHJJMlEwR2RUb1pvaDYzVkROMEh5aTFnVW1FZWhXdWRNZ0tF?=
 =?utf-8?B?UmRINXplL1EzSWNrWWtqNk1HMzF2N042dW5lM2JQLzRBSWtNeWc4TkxDZFRP?=
 =?utf-8?B?R05xeERiQjJ3ME5kbzdxTndxc25qWm9hUVhwdnk4YjdZVXlHcWh5OEJiV0R2?=
 =?utf-8?B?TzBYK2JvdDN2cndtR1dvSnlkanV1dldVOTBoMkRWUUJPVTY5YVNUSThVbmEw?=
 =?utf-8?B?ZWRKdWVCcElOazdpdWR3N2xtRFlGdmxtMUdZMTZHaUJ6RXV4eXFJeXVwc2h4?=
 =?utf-8?B?WTJkRkNoTzYzYnJJUWpFYWhGWkNHWFBYSnB0d0ZEMnZxTld6L0Fnb0x2aUVt?=
 =?utf-8?B?R1RHYWRlalBPbGRraTR2S2g3b280QXlqYVBDNVh4dENKRFRMbXFramU3K01J?=
 =?utf-8?B?VzBpMzlNOUphUnFkRDl0OVJKMGpqVy9TY3E0MHd3cVRsRnRMM200d0t6cFVx?=
 =?utf-8?B?aThYWXRrSUllQkdkMkJXUzdnYkxlaFRNNzhJQTl6UEh2WmdhYXpWMnhBVmxV?=
 =?utf-8?B?QVg5QU1zdmpLRmpnUDNVTGJuREhFTDJYV1VLU1pMWndGRHhBTVR5d1RDVEkz?=
 =?utf-8?B?czNzZ21zbXBsMkVBdWZtMXRFUVM3R3luNHA2T0p5Q240YkY1VzVYT1JnMGlL?=
 =?utf-8?B?aWxvdDdtZlFKam5SNzFTdEprZjVLWThxMkNXZUl6WjJ2RWc2WGhGS3hBd09G?=
 =?utf-8?B?emgrUlU1Nng5c2VEc2FlZWpEY3lNcitOZk9tZk5IN1dIZ0N5QmlQZjI2ZTVX?=
 =?utf-8?B?RVgyeVM0dW5HTm1PV1RDalZXTEpFWWZ0NzczbUZqYkNuSXdKanJyQVFhellK?=
 =?utf-8?B?VEQ2NGFQZ05IeEdjd0tUdFVCYm1uVmptWTJ3ODZaWUVBM3p6WUM5NFRqcmVD?=
 =?utf-8?B?SXhvakErZGJhdC9qRVlmOUdMWCs2eDVmWGhUSlp3VklPSGlhSUsrQjRMdFlX?=
 =?utf-8?B?VjVhb0EydG52a3Axa3R6YWZJYnBaTk9wQmZDYVVJdDY2T0lRdkxIWXNkK25N?=
 =?utf-8?B?QkNEQmZHVnRpaXBzZGlBdFhWcXZ0d3IvbWxwOTJmalVocFRCZkhVeUR3UFg0?=
 =?utf-8?B?THYvdXJKYWp3b09ZeE5OMEhhRmk4MTlwM2NiUmJjSW1aSnVVQUZEVUcwcWow?=
 =?utf-8?B?QUpidWFBSS82SU51bk93VjRIU0xEdTdFaVZqOUI2aURqZkthUnh1dVFJemJt?=
 =?utf-8?B?emNxZWRPMkx1bWxMY2piL1lENTVvMVQ5cGpwNStCVmpoZkdiWm9YVzlRMm5x?=
 =?utf-8?B?UTZVNElHcURkbVVlUm5qNjBXcnF3cmYyUzlIR3RpbmFVMFBnc3NySDIrY1hm?=
 =?utf-8?B?THVwM0FKMFVUQjM2Tkw5RTBpam5rNkNjNlNDTUV6dUF1MDIvOWg2TVR2TDZE?=
 =?utf-8?B?c0g0S3FYbGFCSE1uWEwxSnRqTmM4NG9jL1FNaGZScE9uNVVZOCtURFNsVmJq?=
 =?utf-8?B?STdhS3hQdlpKM1RSQ0pxZ3BvSDR5VDBLWHZpbWo1b0J4V25PMUd6MG5OaHpr?=
 =?utf-8?B?cGUwcTlFbU42NGs3cHducVBKSUpwTm01a1o0RUZWSmVIWWUwLzZydHVwNFhw?=
 =?utf-8?B?ZWJ0TFBoNk9ybFplREJPWmNOVjZ0Y01BeWRHOE9NVkpPYWVnampmam9BWDkw?=
 =?utf-8?B?aTlMbTdyK2kxcnZ5VTRjMUUrM05yYmR1L2pCNUFpZStJSTIvcy9QVitRUUtS?=
 =?utf-8?B?L3dKclRxOHB3Y1pLZVc1d1RCNTh5RFgxdlhWMzlVeE1CVFBtZjF1Z2l4cXln?=
 =?utf-8?B?cHBZSFZXWkpUbzRFY0hXbjU1bC9QTEZubzlIUW9wWStCV2FUdGo1cGFOWWlm?=
 =?utf-8?B?d1F4SCtXVHFXa3BJOUNGc1VaNlRGcDdvN05hWXFDd1pVdjVLOWs2NExmRFBw?=
 =?utf-8?B?elpENTVudnJBTVRpQ3F3NXp5TkNpSzh3YTcvazk2WitjRElrUVdRQmVaWU9N?=
 =?utf-8?B?M3VHQ0d2T1FlZWJya05HUmszamhOc2NrOHZ3VHNqT204bVNSMUhGM013RkR5?=
 =?utf-8?B?dDg2VHVRbVJVVElmL1k5aVl0VXl3PT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <956EAA7E84EDC347A70636A25CAA2C91@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 46bcadbc-128e-4e9d-fbfb-08d9f6c8a122
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Feb 2022 12:33:00.5702
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: zjVN7VL3CpkgFEjruM/vT2czMstWF52O5Y5axIwcJJAMtYlhWkOedK5DrjnMx+rOL2wB4tUfelL3x6WDmRa7ehddYW2xblCF/n4QFNIxH5c=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB3060
X-OriginatorOrg: citrix.com

T24gMjMvMDIvMjAyMiAxMDoxMywgSmFuIEJldWxpY2ggd3JvdGU6DQo+IEFzIG5vdGVkIGluIHRo
ZSBjb250ZXh0IG9mIDMzMzAwMTNlNjczOSAoIlZULWQgLyB4ODY6IHJlLWFycmFuZ2UgY2FjaGUN
Cj4gc3luY2luZyIpOiBXaGlsZSBjYWNoZV93cml0ZWJhY2soKSBoYXMgdGhlIFNGRU5DRSBvbiB0
aGUgY29ycmVjdCBzaWRlIG9mDQo+IENMRkxVU0hPUFQsIGZsdXNoX2FyZWFfbG9jYWwoKSBkb2Vz
bid0LiBXaGlsZSBJIGNhbid0IHByb3ZlIGl0IGR1ZSB0bw0KPiBsYWNraW5nIGEgY29weSBvZiB0
aGUgb2xkIFNETSB2ZXJzaW9uLCBJIGNhbiBvbmx5IGFzc3VtZSB0aGlzIHBsYWNlbWVudA0KPiB3
YXMgYSByZXN1bHQgb2Ygd2hhdCBoYWQgYmVlbiBkZXNjcmliZWQgdGhlcmUgb3JpZ2luYWxseS4g
SW4gYW55IGV2ZW50DQo+IHJlY2VudCB2ZXJzaW9ucyBvZiB0aGUgU0RNIGh2ZSBiZWVuIHRlbGxp
bmcgdXMgb3RoZXJ3aXNlLg0KPg0KPiBGb3IgQU1EIChhbmQgSHlnb24sIGFsYmVpdCB0aGVyZSBp
dCdzIGJlbmlnbiwgc2luY2UgYWxsIHRoZWlyIENQVXMgYXJlDQo+IGV4cGVjdGVkIHRvIHN1cHBv
cnQgQ0xGTFVTSE9QVCkgdGhlIHNpdHVhdGlvbiBpcyBtb3JlIGNvbXBsZXg6IE1GRU5DRSBpcw0K
PiBuZWVkZWQgYWhlYWQgYW5kL29yIGFmdGVyIENMRkxVU0ggd2hlbiB0aGUgQ1BVIGRvZXNuJ3Qg
YWxzbyBzdXBwb3J0DQo+IENMRkxVU0hPUFQuIChJdCdzICJhbmQiIGluIG91ciBjYXNlLCBhcyB3
ZSBjYW5ub3Qga25vdyB3aGF0IHRoZSBjYWxsZXIncw0KPiBuZWVkcyBhcmUuKQ0KPg0KPiBGaXhl
czogNjIzYzcyMGZjOGRhMyAoIng4NjogdXNlIENMRkxVU0hPUFQgd2hlbiBhdmFpbGFibGUiKQ0K
PiBTaWduZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+DQo+IC0t
LSBhL3hlbi9hcmNoL3g4Ni9jcHUvY29tbW9uLmMNCj4gKysrIGIveGVuL2FyY2gveDg2L2NwdS9j
b21tb24uYw0KPiBAQCAtMzQ2LDkgKzM0NiwxNCBAQCB2b2lkIF9faW5pdCBlYXJseV9jcHVfaW5p
dCh2b2lkKQ0KPiAgCSAgICAgICBjLT54ODZfbW9kZWwsIGMtPng4Nl9tb2RlbCwgYy0+eDg2X21h
c2ssIGVheCk7DQo+ICANCj4gIAlpZiAoYy0+Y3B1aWRfbGV2ZWwgPj0gNykNCj4gLQkJY3B1aWRf
Y291bnQoNywgMCwgJmVheCwgJmVieCwNCj4gKwkJY3B1aWRfY291bnQoNywgMCwgJmVheCwNCj4g
KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAmYy0+eDg2X2NhcGFiaWxpdHlbRkVBVFVSRVNF
VF83YjBdLA0KPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICZjLT54ODZfY2FwYWJpbGl0
eVtGRUFUVVJFU0VUXzdjMF0sICZlZHgpOw0KPiAgDQo+ICsJaWYgKCEoYy0+eDg2X3ZlbmRvciAm
IChYODZfVkVORE9SX0FNRCB8IFg4Nl9WRU5ET1JfSFlHT04pKSB8fA0KPiArCSAgICBjcHVfaGFz
KGMsIFg4Nl9GRUFUVVJFX0NMRkxVU0hPUFQpKQ0KPiArCQlzZXR1cF9mb3JjZV9jcHVfY2FwKFg4
Nl9GRUFUVVJFX0NMRkxVU0hfTk9fTUZFTkNFKTsNCg0KVGhpcyBpcyBzb21ld2hhdCB1Z2x5LCBu
b3Qgb25seSBiZWNhdXNlIGl0IHByZXN1bWVzIHRoYXQgdGhlIGVhcmx5IEFNRA0KaW1wbGVtZW50
YXRpb24gcGVjdWxpYXJpdGllcyBhcmUgY29tbW9uLg0KDQpJdCBhbHNvIGhhcyBhIGNvcm5lciBj
YXNlIHRoYXQgZ29lcyB3cm9uZyB3aGVuIHRoZSBCU1AgZW51bWVyYXRlcw0KQ0xGTFVTSE9QVCBi
dXQgbGF0ZXIgQ1BVcyBkb24ndC7CoCBJbiB0aGlzIGNhc2UgdGhlIHdvcmthcm91bmQgd2lsbCBi
ZQ0KZGlzZW5nYWdlZCBldmVuIHdoZW4gaXQncyBub3Qgc2FmZSB0by4NCg0KTW9zdCBpbXBvcnRh
bnRseSBob3dldmVyLCBpdCBtYWtlcyB0aGUgb25lIGN1cnJlbnQgc2xvdyB1c2VjYXNlIChWVC1k
IG9uDQplYXJseSBJbnRlbCB3aXRoIG9ubHkgQ0xGTFVTSCkgZXZlbiBzbG93ZXIuDQoNCg0KSSBz
dWdnZXN0IGludmVydGluZyB0aGlzIHdvcmthcm91bmQgKGFuZCBJTU8sIHVzaW5nIHRoZSBidWcN
CmluZnJhc3RydWN0dXJlLCBiZWNhdXNlIHRoYXQncyBleGFjdGx5IHdoYXQgaXQgaXMpIGFuZCBs
ZWF2aW5nIGEgYmlnDQp3YXJuaW5nIGJ5IHRoZSBmdW5jdGlvbiBzYXlpbmcgImRvbid0IHVzZSBv
biBBTUQgYmVmb3JlIGFsdGVybmF0aXZlcw0KaGF2ZSBydW4iIG9yIHNvbWV0aGluZy7CoCBJdCdz
IHF1aXRlIHBvc3NpYmx5IGEgcHJvYmxlbSB3ZSdsbCBuZXZlciBuZWVkDQp0byBzb2x2ZSBpbiBw
cmFjdGljZSwgYWx0aG91Z2ggbXkgcGxhbnMgZm9yIG92ZXJoYXVsaW5nIENQVUlEIHNjYW5uaW5n
DQp3aWxsIHByb2JhYmx5IGZpeCBpdCBiZWNhdXNlIHdlIGNhbiBtb3ZlIHRoZSBmaXJzdCBhbHRl
cm5hdGl2ZXMgcGFzcyBmYXINCmVhcmxpZXIgYXMgYSBjb25zZXF1ZW5jZS4NCg0KDQo+ICsNCj4g
IAllYXggPSBjcHVpZF9lYXgoMHg4MDAwMDAwMCk7DQo+ICAJaWYgKChlYXggPj4gMTYpID09IDB4
ODAwMCAmJiBlYXggPj0gMHg4MDAwMDAwOCkgew0KPiAgCQllYnggPSBlYXggPj0gMHg4MDAwMDAx
ZiA/IGNwdWlkX2VieCgweDgwMDAwMDFmKSA6IDA7DQo+IC0tLSBhL3hlbi9hcmNoL3g4Ni9mbHVz
aHRsYi5jDQo+ICsrKyBiL3hlbi9hcmNoL3g4Ni9mbHVzaHRsYi5jDQo+IEBAIC0yNDUsMTIgKzI0
NSwxNSBAQCB1bnNpZ25lZCBpbnQgZmx1c2hfYXJlYV9sb2NhbChjb25zdCB2b2lkDQo+ICAgICAg
ICAgICAgICAgYy0+eDg2X2NsZmx1c2hfc2l6ZSAmJiBjLT54ODZfY2FjaGVfc2l6ZSAmJiBzeiAm
Jg0KPiAgICAgICAgICAgICAgICgoc3ogPj4gMTApIDwgYy0+eDg2X2NhY2hlX3NpemUpICkNCj4g
ICAgICAgICAgew0KPiAtICAgICAgICAgICAgYWx0ZXJuYXRpdmUoIiIsICJzZmVuY2UiLCBYODZf
RkVBVFVSRV9DTEZMVVNIT1BUKTsNCj4gKyAgICAgICAgICAgIGFsdGVybmF0aXZlKCJtZmVuY2Ui
LCAsIFg4Nl9GRUFUVVJFX0NMRkxVU0hfTk9fTUZFTkNFKTsNCg0KQW4gYW4gYXNpZGUsIHRoZSBh
YnNlbmNlIG9mICIiIGlzIHZlcnkgd2VpcmQgcGFyc2UsIGFuZCBvbmx5IGNvbXBpbGVzDQpiZWNh
dXNlIHRoaXMgaXMgYSBtYWNybyByYXRoZXIgdGhhbiBhIGZ1bmN0aW9uLg0KDQpJJ2QgcmVxdWVz
dCB0aGF0IGl0IHN0YXlzLCBzaW1wbHkgdG8gbWFrZSB0aGUgY29kZSByZWFkIG1vcmUgbGlrZSBy
ZWd1bGFyIEMuDQoNCn5BbmRyZXcNCg==


From xen-devel-bounces@lists.xenproject.org Wed Feb 23 13:20:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 23 Feb 2022 13:20:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277374.473838 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMrZN-0005S9-II; Wed, 23 Feb 2022 13:20:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277374.473838; Wed, 23 Feb 2022 13:20:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMrZN-0005S2-Ej; Wed, 23 Feb 2022 13:20:37 +0000
Received: by outflank-mailman (input) for mailman id 277374;
 Wed, 23 Feb 2022 13:20:36 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Kuj0=TG=citrix.com=prvs=04643f8d1=George.Dunlap@srs-se1.protection.inumbo.net>)
 id 1nMrZM-0005Rw-Fq
 for xen-devel@lists.xenproject.org; Wed, 23 Feb 2022 13:20:36 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 604c7cd6-94ab-11ec-8eb8-a37418f5ba1a;
 Wed, 23 Feb 2022 14:20:33 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 604c7cd6-94ab-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645622434;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:mime-version;
  bh=t9Abt5HptcfiUIJQojnXAevW1MtOFNqCDIv2Owt+/UU=;
  b=DJSb7ea7qgn3+Ho5PnluPKUMXtqbnwSQFBKz9AbeWsY//Auvg4jE7f+L
   1TtWhnR7yrNAim8I0fbSacKrB4UH308Y0DR7fwYOXiHF/4QTNDNjkKsLx
   owkSg9S9+Fy9Kh5/5bNtSRtTyBXFzAmWgetWv2oYnwjP+eG8kSsZKATs0
   0=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=hardfail (body hash did not verify [final]) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 64698782
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:pdBA56JmW5LMRAodFE+Rz5IlxSXFcZb7ZxGr2PjLsTEM7AuW5UVEl
 zVBCC3DeKqUMyGmS21FGIS3phgF7JOGnNQwSgBsqSpjHysQ8MCaX4vBdBf6NHjNd5zIHRw5t
 MhONYaQdcw5RXSMrxmgaea58HIm2PmEF7aU5IIoQsxUbVYMpHAJ1UIz8wJAvrNVvDSZP++sk
 d35/pDRYgX70mErY25Et/vb8U8+5K2r42oSsw1iNK1A7QPSz3UbMskSdPq7R5farii4PQIYq
 8LrluzRErbxpk91Yj+duu+nNBVMGNY+BCDW4pZsc/HKbiNq+2pigs7XCNJGMR0N02/TxIgro
 DlwncfYpTkBb/WkdNs1C3G0IwkmVUGR0OaaSZQXmZX7I3zuKxMA8d03ZK0FFdRwFtJMKXNP7
 ZQlxAUlNXhvsQ4ULIWTEYGAjux7RCXi0Rh2VntIlVk1Bt5+KXzPrjmjCXa1E17ci+gXdcsya
 fb1ZhI3dDPLZB5rCmtNJ5UuxuLyqnz0eDtH/Qf9SaofuwA/zSR02bnpdtHUZsaLVYNemUPwS
 mDupjqjREtAbZrGlGTDoinEauznxEsXXKo9Gbqi+fMsrECVwmULIBYXSUG6sb+yjUvWt9d3d
 RBKq3px/fJaGEqDXNWlYQaei0K94TFMS9VZENYY8C+/4/+Bi+qeLjddFWMQADA8j+ctXiAj3
 FKNm9LvBBRsvaeTRHbb8a2bxRuwJCwUIGkqdSICCwwf7LHLv4YxkzrOSMhiC6+/itDpGTD2z
 CuOpSJ4jLIW5eYU042r8FaBhCijzrDZQwhw6gjJU2aN6gJieJXjd4Gu8ULc7/tLMMCeVFbpl
 HoOltWa7esOJYqQjyHLS+IIdJms7uyAOSfRgnZuGYcg7DWn/3O/fYFW7yp6LU0vOcEBERfiZ
 0rWuB9N6YVIFGuna7dtZIC8ANhsyrLvffzkSfL8ftdIeoJ2dgKM4Gdpf0H44oz2uBFyy+dlY
 87dKJvySyZBYUh68Naob78F9rQsxQQO+Tn8QoChyk6L1LGVYmHAHN/pL2CyRuw+6aqFpiDc/
 NBeK9aGxn1jbQHuXsXE2dVNdA5XdBDXEbiz8pUKLbDbfmKKDUl8U6e5/F83R2Byc025fM/s9
 2r1ZEJXwUGXaZbveVTTMSALhF8CsP9CQZMH0c4EYA7AN5sLO9/HAEIjm30fJ+VPGAtLl6Mcc
 hX9U5/casmjsxyek9jnUbHzrZZ5aDOgjh+UMiyubVAXJsA8GlGUpIe0JFewpEHi6xZbU+Nk/
 9VMMSuBHPI+q/lKVp6KOJpDMXvr1ZTipA6CdxSReYQCEKkd2INrNzbwnpcKzzIkcn3+Ks+h/
 1/OW38w/LCVy6dsqYWhrf3U/u+BTroldmIHTjaz0FpDHXSDloZV6dQbC7jgkPG0fD6cxZhOk
 s0PkamnaaVfxAwiXkgVO+8D8J/SLuDH+tdy5g9lAG/KfxKsDLZhKWOBxs5BqutGwboxhOd8c
 hnnFgVyUVlRBP7YLQ==
IronPort-HdrOrdr: A9a23:ijFVu65kvhcQ6rMLsQPXwXmBI+orL9Y04lQ7vn2ZFiY7TiXIra
 yTdaoguCMc0AxhJU3Jmbi7Scy9qADnhOJICOgqTPuftWzd1ldAQ7sSlLcKrweQeBEWs9Qtr5
 uIEJIOR+EYb2IK9foSiTPQe71Lobm6GeKT9JzjJh9WPFhXgspbnmNE43OgYytLrX59dP0E/f
 Snl6h6jgvlXU5SQtWwB3EDUeSGjcbMjojabRkPAANiwBWSjBuzgYSKXSSw71M7aXdi0L0i+W
 /Kn0jS/aO4qcy2zRfayiv684lWot380dFObfb8y/T9aw+cyjpAVr4RGYFqjwpF5d1HL2xa1O
 Ukli1QfPibLUmhOV1d7yGdnTUImwxelEMKgWXo/0cL5/aJHA7SQvAx9b5xY1/X7VEts8p717
 8O12WFt4BPBReFhyjl4cPUPisa3XZdMRIZ4J8uZlFkIMIjgYVq3MQiFYJuYeM9NTO/7JpiHP
 hlDcna6voTeVSGb2rBtm0qxNC3RHw8EhqPX0BH46WuonVrtWE8y1FdyN0Un38G+p54Q55Y5/
 7cOqAtkL1VVMcZYa90Ge9ES8qqDW7GRw7KLQupUB7aPbBCP2iIp4/84b0z6u3vcJsUzIEqkJ
 CES19cvX5aQTOZNSRP5uw9zvngehTOYd228LAs23FQgMyIeIbW
X-IronPort-AV: E=Sophos;i="5.88,391,1635220800"; 
   d="asc'?scan'208";a="64698782"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=It9xbV0zvEBNBAocYozZ0r12hVOuj+dMe5Zn2XTLFJomH2Cogmd+wk5FGg2opC58Eckbtb4/t1kBp/wHCGZ0PGpvRX7BhsNTZPYJPV9+OXvPnLoyKUEXn1Ntvmd2p+KV4XX4bJU7/ndSkzN6IMGOAgqDCKTglu1RV4hc/xvtWHVYuMAK+WwAdl2c8K7Gz+aUxUjaZRtnXUZdA83NdnXfKg2tF5hj6fg07ydcq8jaUCds5tltsHZEskPT1o38+HWu532DBi7C5IXrw0XVCks92Pt7DHZl07SrNVYyZjf0eb1H1iF2igVzIqvwOXzMLriN94ece2dzsQ1CDHZa2lgj7g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=YaA0pvouXxcedgS0dwikwDh+3s3XQh7JbYVRgKIjLFE=;
 b=H+j73V/UIc18gZW1BklmLcEzffuNXisHvw0c4GsKgmKUOPOV8zRd5k8hCX6hd227QGMtdkqltZ7jTi9uhvd0eIKVEFVfCyldKWFPU/Z0tYDTu9Iddx79OvKhhxaiHa2lz6yLGpDpHj2YvhowM1H4laaT1hxz56Wvzv7Ey+vzQT5QQ+BIyrOmrRwinqBXPSLuRpJ8cO/waZPDVSI5zwT9uALgh5KEk7WJoQxpzlPHPefB9kmBJGW7kL3I6lkzlFr9LuZ0yTDKY++5j0Wvm3exg1iMPezfxmHz4qw8cno1fWkEHAZeB1xBsqEd6mZTk3GkE8TxvgOLKloQI+anixnWFQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=YaA0pvouXxcedgS0dwikwDh+3s3XQh7JbYVRgKIjLFE=;
 b=vtu3Z5znwi2Sser42YmXi/gTifLtRIDDwaeIXPueaZfBY1EIRrS8Z3mF7g1EaYb0NX0vYCUensRictU5k6YBsxelbdy1GED+y/OzGOMbUs8+qEO5THp66QEvAT3ULf5ClnvH0fiaefMJidZKbLxFplJY/ePYHWKFcsALuY5iu1Y=
From: George Dunlap <George.Dunlap@citrix.com>
To: =?utf-8?B?TWFyZWsgTWFyY3p5a293c2tpLUfDs3JlY2tp?=
	<marmarek@invisiblethingslab.com>
CC: Jan Beulich <jbeulich@suse.com>, Ian Jackson <iwj@xenproject.org>,
	Committers <committers@xenproject.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, Andrew Cooper <Andrew.Cooper3@citrix.com>,
	Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>, Wojtek Porczyk <woju@invisiblethingslab.com>
Subject: Re: [PATCH] RFC: Version support policy
Thread-Topic: [PATCH] RFC: Version support policy
Thread-Index: AQHXkDev9/QrG+8IgUOEs2JU9EeShqt6ldOAgRojewCAC/K9gIAALOIAgAAB2YCAAApzgIABanSA
Date: Wed, 23 Feb 2022 13:20:26 +0000
Message-ID: <17643780-C062-4565-B05C-7D42745B5BC0@citrix.com>
References: <20210813113727.6028-1-iwj@xenproject.org>
 <de32c6c4-5ad5-862e-3988-0e7310ec3ecb@suse.com>
 <C6A7B444-4CFB-43A7-8FA8-AD1049F83912@citrix.com>
 <YhTUe7K5/rlek4AA@invisiblethingslab.com>
 <77CD0734-A343-45CF-8A44-5C53771E404A@citrix.com>
 <f5c50526-2fdc-029e-751d-eb05b29a8366@suse.com> <YhUEc+Ztwf312ZRx@mail-itl>
In-Reply-To: <YhUEc+Ztwf312ZRx@mail-itl>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3693.60.0.1.1)
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 4bc1e77a-919a-482a-fd6d-08d9f6cf416e
x-ms-traffictypediagnostic: DM5PR03MB2764:EE_
x-microsoft-antispam-prvs: <DM5PR03MB27641DE9FA0EB973E3305111993C9@DM5PR03MB2764.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 0cpV8xfashwERsrrCEVGn8x0l77DBeEac6SrT+TlG2jeb71DKLjohay8GWcy+ntTmPajfB4byycr8eH8fvGyTk/3J2DKqLSK14RExIFdO5GDonx09/GDW+hcj46FeO3HEH3XezgE4lArE3J8pxeBzUB0Xi/bwdT5yGO3jtzz1ZOE2SBrn0CuL8TrqxGmVUDhtILfkelDgeV7N/DZgUa+WARrWLE6S6OIoz2TojWxcMMvWbJMIPmpziR7WQI44YP5tDsIZ2g1hpbHTa4zrwIJwQf5aZ9+13XwxWMCanBtmPrHOTQvAvFVmBx7ep5iII/BLnl4EPIg0PB61jAYeryuji6Ks4n42KkbLXGz6WapfJ3NGZL8xPKaGE9c/xt5ifxQafWK0A3YhuZr0Qi6SFw0AaZsrv4Le980O4hmuh5K8j9sWWDj/TEuoExNUA7pikcIKAPiDISqd0+x78KilCyPhMjApdqIhiJY30QIv/RR7RnTu0TBGcVUlf4/P02EzExFa0W3Em26gFs9rZDXWJkevQ9tcoeCvu0I7QAaj5SGX2MQ794UVo51ip42tm11FMOAyZWfZ5bPWOB2BAuUJWPwMobk10JcZF1lM9ENTXINL2uU3gJubxOpNJpRgzUq+COs9iMpf8MMNwf18IN/ctutqTKf+BgCdEzDyzV3tvAhWLQ31mto8hDwUrCmlGODuLJE5pSog40YSS+lFt43m+pDClKkBjiZayJ0bJISN4wYm+g=
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(82960400001)(2906002)(2616005)(122000001)(33656002)(38100700002)(186003)(26005)(99936003)(38070700005)(64756008)(66446008)(6512007)(8676002)(4326008)(66476007)(66556008)(91956017)(66946007)(76116006)(8936002)(36756003)(6506007)(6916009)(54906003)(71200400001)(508600001)(6486002)(53546011)(5660300002)(86362001)(316002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?RnJNNVNwN2RGZVRwMTdMMDdKb0d3SjFwY1VFODV4OGFqQUZXZVk3Nm9NUGZQ?=
 =?utf-8?B?eHFCTFQyM0xDaWpMNHYrUndnaXpNMHpOK1F0Vk1MWlNKbE54Z3hkbE9IZzRY?=
 =?utf-8?B?aXllTnhsNG9ydU9lTGI2YzZOTG93cHhrTlh2dG50NkFSSENsOVVzeEFEMHAv?=
 =?utf-8?B?S1lQMnhPdlM5WkhMTm1TaTU5YU9ua0lkZGtTUjdzTGF6WlZtWjhoK0lxN0R6?=
 =?utf-8?B?WE1EQ2hkaHdFQjZkYXJkYzNWUUpPdldDaFVMcm5vNmVwMVZid0RVSGNwU2U2?=
 =?utf-8?B?R3BNRzRtVkk1NnhaYjRTVUgrK0dFNHArNUVLRzlzeTJJWGxYcTlkaHRPbkZa?=
 =?utf-8?B?UEoxb0tRMHllRVRyZlV2VkNNeVVQU1pqVWh1a01NVVdWRmNBTS9ZeklYL1Ji?=
 =?utf-8?B?Vkxnd3ZMUkxSbUp5SDBYR0FMMFZVMXJPRFNRdmJrUG9VcFZLT0x4SUtDVlpQ?=
 =?utf-8?B?TXZrYnd3U0F4WkpacDhkV0RPbU9sODFlT3lJb0gwM0lCZ09EZzJieWpqdVpo?=
 =?utf-8?B?OHNOMW14TXVhWVFpajhHamtXaUlHbGR3R1hGVG96SGFnWm9FdWg4MndSWFp2?=
 =?utf-8?B?QkVscmdXOFhyNVkweFkzaXhmUFd3VjJINWMxSUYrNi9kN05aOFlCTUo4enpz?=
 =?utf-8?B?Q2dyd1krRjQ3bStaNVFuWGxnRnFETUdUSUxWaXVId09OaFpHd3NqbVhCNGtJ?=
 =?utf-8?B?QzdyWXA1eTVuQUhKd1piT3lJWFpnSS9SQTF6bUJCTFRvd3p0cUpWWDBqamNa?=
 =?utf-8?B?VXd2ckJhUkY4NC9Ecnd1R3ZUcDBpOWp4dUJEUlpoSHRDbERaTUxVS3YydnVX?=
 =?utf-8?B?UVlzZndma2ljK1JVNUQ1bTRFMlpIeWtsdU9lSG1lMEpwYlBkc2wyYkEyR2lp?=
 =?utf-8?B?QnBERGxJekgrZVQyajZEdnBlbHBRNHhzbC9Qdys3WHZpVXhOeDZNR1F6NU5P?=
 =?utf-8?B?NlhNTnNOdzg0dEdvQWNWV0RJVXNMaC9OOUlnU2FqdkZIdkFVMnQzdWtrQVZC?=
 =?utf-8?B?L2RaVGxzeXl3NTdrZ1E5bFJpc1cyY01PSzlyNVVobEVWS3poWlVWV3BYMk45?=
 =?utf-8?B?M0kvRE05cXhLTVBlR3ZQc0piQkE5aCtITUdzTVorcC9BVFB3ZFovT2llVFVn?=
 =?utf-8?B?QXQ4c25RcUExMVpYbGZsTEtxVzVjcXBncmlTbFFlY3RrMGxRaWp6TEZISlcx?=
 =?utf-8?B?eTBIdmFTNGtpVlNoNlc3b3dFc1hNdEV3cjJyUXYzMkJmdENUU0ZRMW5pNStU?=
 =?utf-8?B?OHIyWGdtVklERW1BSUtDaG5DaUgxeFN4eE9MZytGOHhJdFVjUnFrcHQxWHVJ?=
 =?utf-8?B?VVJaTWFRQUJWRHVoSEtLSS9lT21JUWVMZm5TZ1kvVFFCQkN0MDJJTG9Rd1RT?=
 =?utf-8?B?ZFZqYVZHRmtTR2drTHYxZnNjakViVVhHTS9yS3ltRVV6Q2xpUzZUTHVwZ0tt?=
 =?utf-8?B?Mzh0REsvRE45U3R5ZGpLZjA0aWtxN25QZytCRUtvRS83SkdzajNDRnREakJQ?=
 =?utf-8?B?OEp2c0t4eGh4aUlRNit1Y3pZSFRMS28zSGd6Wm9UaGVGMzFhNVdtK0dXSElM?=
 =?utf-8?B?Q01OWVZRWmhMZnhyZnh3ZFk2eFIweE1rQUZCS09NTDVvZmh5Qjk2WVJFblI2?=
 =?utf-8?B?enA3Tm5OVEhnc1VEWm9mWGhGdW8xNEI5UlY1ZHcwcGVoQSt4bGxuSWdZWlN1?=
 =?utf-8?B?OEZ4dWllblBqSkgyOGl1WGVwemNyMXE0U0RrUVJ6OURpMWxpUmx4MjBNZlJu?=
 =?utf-8?B?OG55ZXlCQlhUYnF0YTNkNmlrVmE5emFhYVJYZExXS0t3cUwwclBsNWY0OGVo?=
 =?utf-8?B?M1h2K3JpR1BPZ3FZRDRvNXVFdGJYd3M3bGhQNkF4OHBIWjJIWEpqdHZSWXp3?=
 =?utf-8?B?Z3dWcWhEWmcySTBTZGJjZTJtR1dIRjRqOXEyTEoxQ3V3MzhueVNsazZKWmNU?=
 =?utf-8?B?aEl4UTBlVlMvbG8ybFcxT3BBd0swSHZtc2UwK1FXbEkxbGx3NGN6bFVkYjIv?=
 =?utf-8?B?YjZWbXd2QWlKZ0J6aHlBaFVEMGRCeVBPZk00VmZFdFI5eHJmYkFoN3RQYUJT?=
 =?utf-8?B?SU0xcGtlakpwYktyT1V5R1ZuNlh3VG43ekJDWjNvbHgrU3dNUjNoSG84ZzZs?=
 =?utf-8?B?V1IvSnZkVEZEUmRSclRDVHZWRThVbUxEbVZUeTAwOWx6cXR0VjYzWWRaNFlB?=
 =?utf-8?B?TWIwbzZ2WHNpOW8xblU2TXJ1anZNNlpkZEtNckVUME5DOVdaR2ZwQXpPYWYw?=
 =?utf-8?Q?AW7+lbyuIuRjMGEVnz6wKP6Z81oe6NRUWovDHJiawk=3D?=
Content-Type: multipart/signed;
	boundary="Apple-Mail=_372F4DE3-3004-4217-9581-4FC9E2631BEB";
	protocol="application/pgp-signature";
	micalg=pgp-sha512
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4bc1e77a-919a-482a-fd6d-08d9f6cf416e
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Feb 2022 13:20:26.4204
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: WXsSL9pW86x6CJ0OWOnEZdnyl/2CvdSDymYw1J6PHCn9UT5G14hv+6vNMoRBjV/RVUJQkN+a0lh+t/tCMWzDz1Aa8cDvS+u0VkJ7PaeGNQs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2764
X-OriginatorOrg: citrix.com

--Apple-Mail=_372F4DE3-3004-4217-9581-4FC9E2631BEB
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8



> On Feb 22, 2022, at 3:42 PM, Marek Marczykowski-G=C3=B3recki =
<marmarek@invisiblethingslab.com> wrote:
>=20
> On Tue, Feb 22, 2022 at 04:05:19PM +0100, Jan Beulich wrote:
>> On 22.02.2022 15:58, George Dunlap wrote:
>>>> On Feb 22, 2022, at 12:18 PM, Wojtek Porczyk =
<woju@invisiblethingslab.com> wrote:
>>>> On Mon, Feb 14, 2022 at 09:50:25PM +0000, George Dunlap wrote:
>>>>> I think it=E2=80=99s too much effort to ask developers to try to =
find the actual
>>>>> minimum version of each individual dependency as things evolve.
>>>>=20
>>>> By "find the actual minimum version", do you mean to get to know =
the version
>>>> number, or install that version on developer's machine?
>>>=20
>>> Well suppose that a developer writes code that depends on an =
external library.  The external library on their own machine is 4.5; so =
they know that 4.5 works.  But will 4.4 work?  How about 4.0?  Or 3.9?  =
Or 2.2?  Maybe it works on 3.8+ and 2.13+, but not 2.0-2.12 or 3.0-3.7.
>>>=20
>>> I don=E2=80=99t think it=E2=80=99s fair to ask people submitting =
patches to do the work of tracking down which exact versions actually =
work and which ones don=E2=80=99t actually work;
>>=20
>> But somebody will need to do this. If it's not done right away, =
someone
>> (else) will hit a build issue on a perhaps just slightly older =
platform.
>=20
> That's why declare what version _should_ work (and test that via CI),
> instead of trying to find what is the minimum version that is actually
> required. This may result in saying "you need libfoo 3.4" while in
> practice 3.3 would be fine too, but I think that's reasonable
> compromise.

This paragraph is a little unclear; you say =E2=80=9Cshould=E2=80=9D, =
but then talk about what has been tested to work.

To me =E2=80=9Cwhat version should work=E2=80=9D means you track down =
the version of the library where the relied-upon functionality was =
introduced; in your libfoo example, it would be 3.3.  I think we should =
only include versions that have been tested to work.  If the CI loop =
only tests libfoo 3.4, then we should list 3.4 as the requirement.  If =
someone else tests 3.3 themselves and reports that it works, then we can =
use 3.3.

 -George

--Apple-Mail=_372F4DE3-3004-4217-9581-4FC9E2631BEB
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="signature.asc"
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEj3+7SZ4EDefWZFyCshXHp8eEG+0FAmIWNH8ACgkQshXHp8eE
G+04swgAskndD01oPcO8uMbLpgXpT6AoMLTlG4V+SDQOGgZEHr/or9kqt5S6dLlQ
m16AgUJnnGnfD4daFMxchBJ+yRJIjn8ib3Lm/NbyV18pkmXTIvPe2nArfghOJzKQ
ehR3gPog+nx1DrclANBEjok9wyoy6HrcsydeA0M6TvA+m+SDG/Ayg7tLZ44XFTqj
kHwWH+Zf6Uak+ib+Kwb1YQDgGGYCUvEWjdYSXXWMwo8o+R53oQ2jmqGHkMOGNi/j
Qt5Hy3N0dgKBGRRXnXdwTUnlc43B7AR2qD6hT9SmZpfHxUpdUuHK/q+dFomhPlJH
2tI++XCTiSlDBznBp9TQxruzRVI2Gg==
=5k5I
-----END PGP SIGNATURE-----

--Apple-Mail=_372F4DE3-3004-4217-9581-4FC9E2631BEB--


From xen-devel-bounces@lists.xenproject.org Wed Feb 23 14:22:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 23 Feb 2022 14:22:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277381.473849 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMsWg-0002yV-7C; Wed, 23 Feb 2022 14:21:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277381.473849; Wed, 23 Feb 2022 14:21:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMsWg-0002yO-3q; Wed, 23 Feb 2022 14:21:54 +0000
Received: by outflank-mailman (input) for mailman id 277381;
 Wed, 23 Feb 2022 14:21:52 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=DZ7u=TG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nMsWe-0002yI-7C
 for xen-devel@lists.xenproject.org; Wed, 23 Feb 2022 14:21:52 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f039b7e6-94b3-11ec-8539-5f4723681683;
 Wed, 23 Feb 2022 15:21:49 +0100 (CET)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2053.outbound.protection.outlook.com [104.47.13.53]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-7-1uSaRqjlPDCnrPYpNyqmXw-1; Wed, 23 Feb 2022 15:21:47 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AS8PR04MB7526.eurprd04.prod.outlook.com (2603:10a6:20b:299::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Wed, 23 Feb
 2022 14:21:46 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.022; Wed, 23 Feb 2022
 14:21:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f039b7e6-94b3-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645626109;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=u9mErHoWBNXlU4c6ehoUvC5L0ONmTsuIw67G/LF2Lo4=;
	b=KU4omN5QrJKh3oMDMJyG8uwISFn1wpEq6rGoWp3kcX84pRWjAkM6mbUoBj+RkPuxh0PQhD
	atmvX7dlLUS8kvHbeH9WKxO+NQueN6xlPNHnHBG5HmMxPLivY34Xakj+LqzUcQ2VgTtxvV
	aUV9nqy9TOH7LYuxEOiq3nFtnVSf9PQ=
X-MC-Unique: 1uSaRqjlPDCnrPYpNyqmXw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=kJY8aa4C4ZdvCoQT2oUJbd394hd+HhfgLn1LAgBZMDGpc5UsCAybi8P0BRE9K/9wjd54DoZzLedu0piccxc5X7HLqVCuWdMRbC6EJa+H8acVRwWNKmI5Xn6VAYLs4qL4GNmWbRRGaQHLzN7YyqoGp3TsIl8gTTMNnCPT8NsAPJ232JaTvWmg8+th56Z7ocvOHf0ElI6hEDd3R63Zx+PR6VgurK+hRAekOuCAYJooBSuBmc36V8TvlOiWgNQ6zYfKgdDMNuTXLXbFa6eeMig39+uplPROIaSj4IfKbu0RhsbgKzZmBtowE0rJcLYL8ZWcclZiGHQ2PVvCi/mq9u+cNA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Ej7z5zi7D8K89Nvw/xyrnIcxV2VEYFlVY6IgcY0QquQ=;
 b=egpuUz21ggxuXZzpx6/sKQ89NumcHlTYxOCAWBIHIU/dZQQZlEdS4g4uEzalfD3abi0s/j0x52WlVmqkUhT1rk19/tNpgMDMq4y8GKBVfLGTw+Y22w7IlX9IkuLco+uGeJa0dk48ULI1GNIbL0C4aGfrvXqO8hNSXFQIAO5TyJOWneyFj95pyQLJiDrWwx1uiF9lKi0Rep9TkJ22+5VvZoBtqBuMMBHxeV4dQ1fs0ry+nQZzsRYtFx9pNuqlDw/Za6Iof9RtIZK1Z4WbHilzzgZCXOT5QZIzeEo8tFsM2TIIMQrT5Z2/Xf98Kh+r12HXLepjuYrWBkQtXnYl7EbgTA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <d376a457-ef35-4fcb-38d9-d495b385fb65@suse.com>
Date: Wed, 23 Feb 2022 15:21:44 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v3 59/70] x86: Use control flow typechecking where
 possible
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
CC: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20220222152645.8844-1-andrew.cooper3@citrix.com>
 <20220222152645.8844-14-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220222152645.8844-14-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS8P250CA0009.EURP250.PROD.OUTLOOK.COM
 (2603:10a6:20b:330::14) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ed4196e6-30be-4330-9147-08d9f6d7d25e
X-MS-TrafficTypeDiagnostic: AS8PR04MB7526:EE_
X-Microsoft-Antispam-PRVS:
	<AS8PR04MB75269032987840F929AC62E8B33C9@AS8PR04MB7526.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	NUlBoZAkvbBNpRVCDLXQAXkAU4PFRd1TcB5FUZ4qF87a2ei2U0z0x3hc5DFuuZHwh9T6VDKX/FHi1YVfk8H7Py9vQBzlHvrl1OIp6P47sKGYNVG/We5erPIi8R2vmvROvCXNQKQp4wUS7qQ+qSiflER/asge1iq2ybLl5lp8ihvvYm5d964Ob/qX4blFKdlxbcMKTbiEVjSvTp7lFq1LunuGg12wdvDXc0xhrKncmt9koapEaj6RSHwA9F0m3/Nm1bymJhf97nucpT6GKNpkvzvnGB/XVF/sjM3wS2sSw3mDR4Xytw21g1iJIUL/n4Pgju8Kf/CUm/lzNhMDk/fWS0pxNLxtYvoU2UyElWqCh5/jMd03oGXA6plWP5wPYUcxYyAVIdPhzuKfcNB5rB9zpGSu9tj/oBoUcBi4ko2uD/Q2m5/MFHb3aAp0p3u+EDFJpck7Ra/yTZTSK2aDdhiV4kw4mmuvhn7dLbb2gTSElMemr0Z2CAYYLTYYlkpMzGexZJvNwVgqODi//FjLVIZoZ6sG1oo8IUr8w5sZ38q6V7VOIAeKzyYpbDJaw4SVsp6WMxgxy08c3pKKvu9zeQIEcQ1mdkF0w28e4cFjN5+642PM3XXCVu5cZ3JrZUfW2gp9pZUKGWiQwZ5/Juct1iybF6qT0zdLHJH+lJ6yKQPeO6lD/Npnf4sv3UPZTl4U0izj7PLFy+ZkfeJLJtA7uw1KR7vHl4qloOWTpU58HZIrobtawDtvEhutaURVBHyYOLPDkkovMAPqrj9BR8ovY3iIaZijk1vpAjsDvpV7nRmU+QDbgun44c/9iC8vkp+DSOea
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66946007)(4326008)(8676002)(508600001)(31696002)(86362001)(316002)(54906003)(6916009)(66476007)(66556008)(966005)(6486002)(5660300002)(31686004)(38100700002)(2906002)(8936002)(186003)(26005)(6512007)(6506007)(83380400001)(2616005)(53546011)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?NiVDPauOCakg9UQBPMvPplEPJPqxHZM33pnOBr1uiEST/X6fTr+x1LDULIqc?=
 =?us-ascii?Q?MIkvLPMEvMDVVlIZaPDaWo5B7uDdILikFjTF2gfebP6a3nbpDh4kp3EcaNql?=
 =?us-ascii?Q?4IzokIyQ3dNZoWgmwGFgP1QMg30mya7CQyZypr0YwYYD8l4KSCfi7ROo0o8B?=
 =?us-ascii?Q?iZPFCjKrB68pf5oUuM4CnTDPO3jl/mmVPU1Q8sQ45wVqsr8ODmAAlwpPYxwZ?=
 =?us-ascii?Q?f002qcPCwkAoUTWT78opN45XzQfJb7W/YJ8O1hpUA7Hbm3LklUVOXAmSLaNs?=
 =?us-ascii?Q?JOAP7iNm4dmjAKwkknjfOwQkvI/fImEzqnqxUzpXhQRuAO2e3RQSFTd1f9fs?=
 =?us-ascii?Q?XKmTK0HNhxnVbfaDmFGq0yEKSdrenW4aZBWxCxoFnMsX2tuHCTaIYvCZdr1X?=
 =?us-ascii?Q?iNrKNHm7lR7Gu40Ij/XgzVq6113UpI2qKPNXSyN/g3/ARCh1TBlfloujSlgm?=
 =?us-ascii?Q?IDdra8aJrid+PaCCDENoAlOu2fx/Yr0Zv64Pl4xNBJ1itY1F8u4obFiGhCLC?=
 =?us-ascii?Q?LFVbXTBqXflA/kSPCGIQ9WQPGBuzPDpH73pJg086VBznhP6ayI9LEaLGNmKP?=
 =?us-ascii?Q?QU3pdyqzIo8LqkM/gFRGjv1nZu68tLzJwmKwnYITquX/5dcji4I+emOT3fxK?=
 =?us-ascii?Q?amq0YThr/MIUiQcTQQqMYpafus+oCY7VIt+RP9CVYtO2ZMgCWi3XA2Ccr1Rn?=
 =?us-ascii?Q?AHf9gPTaqQCstSKVjb/PSWyl5BrpI3mwjhmdU6lYG5mdwTOq+HNT4s4bOKeH?=
 =?us-ascii?Q?TC8UW7JsowiCAo4uQV9lA7azr4lwQ5ueIY0luiFfXk0eCCAb0ISDlwdQq5FS?=
 =?us-ascii?Q?nsdbN95u/sRsCzxZoWwDj9YfPdfMPQz4MzP0rVeOZ13afDD5bVyY1klpEUv4?=
 =?us-ascii?Q?jq+1yicqC1r8ICdhUahfH2LZ0uxbDHCtiOIt9QtWBpOYMQoTu8wZHAjX6N7K?=
 =?us-ascii?Q?eKOCznzF72EW8oDoXVAH3bmhPWggevj3LnYkoYwog4B+V6DhjEXMdkvXDjAt?=
 =?us-ascii?Q?WEQDOr/+bxtd0x/hXsPGjiCltssI2n0jsmOWr1Rj1saL9Uni2eksqZFsBuMh?=
 =?us-ascii?Q?97+LbOgdzNmW92SyztqJ/d/PAenZAzDFPzpMkby7RaAUDDtqEpQf9Owulv27?=
 =?us-ascii?Q?lYw9EJ/Oj1U/laxd/jGj4Y6IP0ehlCZ0kgVd/klk5x/lDYNOz6B6ELQxW+4/?=
 =?us-ascii?Q?AXfRc103MhS3LtuEU9CnNdo8s948xQFPWJ38k9xAjuukKuukT9izG6VdtoLl?=
 =?us-ascii?Q?V8Hv2tyhGnMD2NxcLb20b3ZJrjyvpyWCywpvjwsozGzI5MjtRUJ2kEvqMFoe?=
 =?us-ascii?Q?UNF29GeTuMLD621zXlTThC84h8svgZU/dyaBzZWQ8jKjk/Lt63u1VASSLkY7?=
 =?us-ascii?Q?QHVxumXhhTXjgqWRolhMVtSa5iA7TAMpXt+SB33E2GMbM+SCfy6m40POsl0/?=
 =?us-ascii?Q?dry8Uflq8b6oPOU81h2lI5vsolrN5b7bhkQRH87oRSzDUN15zRLIEmadyg3G?=
 =?us-ascii?Q?m1ToZ/59yaJQPpl63LPxSnrC0VaL2qJd7b3RpUUBuVPiW3wLuP/CntZQW7I1?=
 =?us-ascii?Q?e7oItf6GaGi/9hBXv0w1av7hBFySrqSkHQgCKqdJ7ILXoo1YQkCNpfJyB1AS?=
 =?us-ascii?Q?IqPsJptaY/iBz4BS056pdDk=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ed4196e6-30be-4330-9147-08d9f6d7d25e
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2022 14:21:45.9012
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EsrwQ/pj663YwpH/wG/1wKorILUbZQr55JG3a2qiVB5AcXAwziY3WGr/QfUmzozcAgdRnWIA33TVRQsHXDnQ+g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7526

On 22.02.2022 16:26, Andrew Cooper wrote:
> Now all callees have been annotated, turn on typechecking to catch issues=
 in
> the future.
>=20
> This extension isn't in a released version of GCC yet, so provide a conta=
iner
> to use with the extention included, and add it to CI.  RANDCONFIG is nece=
ssary
> because some stubs for compiled-out subsystems are used as function point=
er
> targets.
>=20
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

I certainly see that we will want to have this extra level of safety.
Hence feel free to add
Acked-by: Jan Beulich <jbeulich@suse.com>

But I'd like us to form a plan in case the change doesn't get committed
relatively soon after gcc re-opens for general development after gcc12
was branched off. We don't want to get into the position of needing to
maintain a gcc patch. Do you have any insight as to what is actually
blocking the committing of that change, seeing that it has been around
for a while?

Jan

> ---
> CC: Jan Beulich <JBeulich@suse.com>
> CC: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>
> CC: Wei Liu <wl@xen.org>
>=20
> v3:
>  * Provide container.  Already pushed to Gitlab.
> ---
>  automation/build/debian/buster-gcc-ibt.dockerfile | 66 +++++++++++++++++=
++++++
>  automation/gitlab-ci/build.yaml                   |  6 +++
>  automation/scripts/containerize                   |  1 +
>  xen/arch/x86/arch.mk                              |  1 +
>  4 files changed, 74 insertions(+)
>  create mode 100644 automation/build/debian/buster-gcc-ibt.dockerfile
>=20
> diff --git a/automation/build/debian/buster-gcc-ibt.dockerfile b/automati=
on/build/debian/buster-gcc-ibt.dockerfile
> new file mode 100644
> index 000000000000..441d9a9ab37a
> --- /dev/null
> +++ b/automation/build/debian/buster-gcc-ibt.dockerfile
> @@ -0,0 +1,66 @@
> +FROM debian:buster-slim AS builder
> +
> +ENV DEBIAN_FRONTEND=3Dnoninteractive
> +ENV USER root
> +
> +RUN apt-get update && \
> +    apt-get --quiet --yes install \
> +        bison \
> +        build-essential \
> +        flex \
> +        libc6-dev-i386 \
> +        libgmp-dev \
> +        libisl-dev \
> +        libmpc-dev \
> +        libmpfr-dev \
> +        patch \
> +        wget
> +
> +RUN mkdir /build
> +WORKDIR /build
> +
> +RUN wget -q https://ftp.gnu.org/gnu/gcc/gcc-11.2.0/gcc-11.2.0.tar.xz -O =
- | tar xJ --strip=3D1
> +RUN wget -q https://xenbits.xen.org/people/andrewcoop/gcc-11.2-Add-fcf-c=
heck-attribute-yes-no.patch -O - | patch -p1
> +RUN ./configure \
> +        --prefix=3D/opt/gcc-11-ibt \
> +        --enable-languages=3Dc \
> +        --disable-nls \
> +        --disable-threads \
> +        --disable-bootstrap \
> +        --disable-shared \
> +        --disable-libmudflap \
> +        --disable-libssp \
> +        --disable-libgomp \
> +        --disable-decimal-float \
> +        --disable-libquadmath \
> +        --disable-libatomic \
> +        --disable-libcc1 \
> +        --disable-libmpx
> +RUN make -j`nproc` && make -j`nproc` install
> +
> +
> +FROM debian:buster-slim
> +COPY --from=3Dbuilder /opt/gcc-11-ibt /opt/gcc-11-ibt
> +
> +LABEL maintainer.name=3D"The Xen Project" \
> +      maintainer.email=3D"xen-devel@lists.xenproject.org"
> +
> +ENV DEBIAN_FRONTEND=3Dnoninteractive
> +ENV USER root
> +ENV PATH=3D"/opt/gcc-11-ibt/bin:${PATH}"
> +
> +RUN mkdir /build
> +WORKDIR /build
> +
> +RUN apt-get update && \
> +    apt-get --quiet --yes install \
> +        bison \
> +        checkpolicy \
> +        flex \
> +        gawk \
> +        make \
> +        python3 \
> +        && \
> +        apt-get autoremove -y && \
> +        apt-get clean && \
> +        rm -rf /var/lib/apt/lists* /tmp/* /var/tmp/*
> diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build=
.yaml
> index fdd5c76582b3..cc36428cf55b 100644
> --- a/automation/gitlab-ci/build.yaml
> +++ b/automation/gitlab-ci/build.yaml
> @@ -294,6 +294,12 @@ debian-stretch-32-gcc-debug:
>    variables:
>      CONTAINER: debian:stretch-i386
> =20
> +debian-buster-gcc-ibt:
> +  extends: .gcc-x86-64-build
> +  variables:
> +    CONTAINER: debian:buster-gcc-ibt
> +    RANDCONFIG: y
> +
>  debian-unstable-clang:
>    extends: .clang-x86-64-build
>    variables:
> diff --git a/automation/scripts/containerize b/automation/scripts/contain=
erize
> index 7682ccd34759..8992c67278ae 100755
> --- a/automation/scripts/containerize
> +++ b/automation/scripts/containerize
> @@ -33,6 +33,7 @@ case "_${CONTAINER}" in
>      _focal) CONTAINER=3D"${BASE}/ubuntu:focal" ;;
>      _jessie) CONTAINER=3D"${BASE}/debian:jessie" ;;
>      _stretch|_) CONTAINER=3D"${BASE}/debian:stretch" ;;
> +    _buster-gcc-ibt) CONTAINER=3D"${BASE}/debian:buster-gcc-ibt" ;;
>      _unstable|_) CONTAINER=3D"${BASE}/debian:unstable" ;;
>      _trusty) CONTAINER=3D"${BASE}/ubuntu:trusty" ;;
>      _xenial) CONTAINER=3D"${BASE}/ubuntu:xenial" ;;
> diff --git a/xen/arch/x86/arch.mk b/xen/arch/x86/arch.mk
> index f780c912a9cf..92fd19811013 100644
> --- a/xen/arch/x86/arch.mk
> +++ b/xen/arch/x86/arch.mk
> @@ -54,6 +54,7 @@ endif
> =20
>  ifdef CONFIG_XEN_IBT
>  CFLAGS +=3D -fcf-protection=3Dbranch -mmanual-endbr
> +$(call cc-option-add,CFLAGS,CC,-fcf-check-attribute=3Dno)
>  else
>  $(call cc-option-add,CFLAGS,CC,-fcf-protection=3Dnone)
>  endif



From xen-devel-bounces@lists.xenproject.org Wed Feb 23 14:28:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 23 Feb 2022 14:28:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277390.473861 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMscn-0003hT-1I; Wed, 23 Feb 2022 14:28:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277390.473861; Wed, 23 Feb 2022 14:28:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMscm-0003hM-Tm; Wed, 23 Feb 2022 14:28:12 +0000
Received: by outflank-mailman (input) for mailman id 277390;
 Wed, 23 Feb 2022 14:28:11 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=PMTg=TG=citrix.com=prvs=046033a78=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nMscl-0003hG-C7
 for xen-devel@lists.xenproject.org; Wed, 23 Feb 2022 14:28:11 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d1ec6091-94b4-11ec-8eb8-a37418f5ba1a;
 Wed, 23 Feb 2022 15:28:09 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d1ec6091-94b4-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645626489;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=RA0ILhZuTpVOi+KqJSsnRkAhY0YJ6fwIDoCuAqpglBw=;
  b=NkuYmmmw+qBX2ynmIJ9XDqo6oVk4nfbJpg+jZ2shlDfHq/rChHc8xmdy
   f+NcMGNRRDNKoMfCJeJwPugXPLsNWBU4i9pu2ESpj5pXDrcDzGqqKnJn4
   G3Q1Pm45cFNFl30sD9fnozv1XcyLVhZSk7RC30Gc78XaHijRJocez7BUo
   0=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 65222664
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:ejaLeK7bVXT/zGMQ4siLPgxRtCrHchMFZxGqfqrLsTDasY5as4F+v
 mBOUTvVa/aIMTOked5yaonio0wO65HRzNE1GlZurSoxHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFx2XqPp8Zj2tQy2YLjWFvX0
 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X
 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx
 umhurSgFDcyEoD3kt1ETjdDSwVvMqdlxLb+dC3XXcy7lyUqclPpyvRqSko3IZcZ6qB8BmQmG
 f4wcW5XKErZ3qTvnez9GrIEascLdaEHOKs2vH16wC6fJvEhWZ3ZGI3B5MNC3Sd2jcdLdRrbT
 5REM2A1MkqcC/FJEg1IJYt9svuPv1P6NCcbs1aJ+LQz6kGGmWSd15CyaYGIK7RmX/59jkue4
 27L4Wn9KhUbL8CEjyqI9Gq2ge3Clj+9X5gdfJWn8tZ6jVvVwXYcYDUUX1ampfiyimalRslSb
 UcT/0ITQbMarRLxCIOnBlvh/SDC7kV0t8ds//MS+Fy90Yb52AygX3UqVWZledMsl/M/fGl/v
 rOWpO/BCTtqubyTbHuS8LaIsD+/URQowX8+iTwsFlVcvYS6yG0npleWF4s4Tvbp5jHgMWyom
 1i3QD4Ca6L/ZCLh/4Gy5hj5jj2lvfAlpSZlt1yMDgpJAu6UDbNJhrBEC3CGtZ6sz67DFzFtW
 UTofeDEsIji6rnXyUSwrB0lRu3B2hp8GGS0baRTN5cg7S+x3HWoYJpd5jpzTG8wbJpZJGK3O
 B+J5VwBjHO2AJdMRfUrC25WI553pZUM6Py/DqyEBjawSsIZmPC7ENFGOhfLgjGFfLkEmqAjI
 5aLGftA/l5BYZmLOAGeHr9HuZdyn3hW7TqKGfjTkkT2uZLDNSX9YepUbzOzghURsfrsTPP9q
 I0EaaNnCnx3DYXDX8Ug2dRNdQtTdSBjX/gbaaV/L4a+H+avI0l4Y9f5yrI9YY112aNTk+bD5
 HamXUFEjlH4gBX6xc+iMxiPtJuHsU5DkE8G
IronPort-HdrOrdr: A9a23:UuC6B6xuWDeeZaRTSkslKrPxguskLtp133Aq2lEZdPULSKOlfp
 GV8MjziyWYtN9IYgBcpTiBUJPwJE81bfZOkMYs1MSZLXXbUQyTXc9fBOrZsnHd8kjFmNK1up
 0QCpSWZOeAbmSSyPyKmjVQcOxQgeVvkprY/ds2pk0FJWoBCsFdBkVCe32m+yVNNVJ77PECZf
 6hD7981lydkAMsH6OG7xc+Lor+juyOsKijTQ8NBhYh5gXLpyiv8qTGHx+R2Qpbey9TwJ85mF
 K10zDR1+GGibWW2xXc32jc49B9g9360OZOA8SKl4w8NijssAC1f45sMofy/wzd4dvfqmrCou
 O85yvIDP4DrE85uVvF5ycF7jOQlQrGLUWSkGNwz0GT+fARDwhKdPapzbgpDCcxrXBQ5u2UmZ
 g7r15w/fBsfGL9tTW46N7SWx5wkE2o5XIkjO4IlnRaFZATcblLsOUkjQho+bo7bWvHAbocYa
 FT5QDnlYJrWELfa2qcsnhkwdSqUHh2FhCaQlIassjQ1zRNhnh2w0YR2cRaxx47hd8AYogB4/
 6BPrVjlblIQMNTZaVhBP0ZSc/yDmDWWxrDPG+bPFyiHqAaPHDGrYLx/dwOlauXUY1NyIF3lI
 XKUVteu2J3c0XyCdeW1JkO6RzJSHXVZ0Wa9iif3ekPhlTRfsuYDcTYciFcryKJmYRrPvHm
X-IronPort-AV: E=Sophos;i="5.88,391,1635220800"; 
   d="scan'208";a="65222664"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=WjyHZ/4OscJxZ03QrRC8WDoIgLH65ozSZm6Kn8aTlJOOj50PEO2jbVXLNqIcfHO8ri0i4Smxy7bYSPRCyKg+WngZOyi2dQ2xw0mUA0A07lp1n3kcKNXcs4rlptWzRzLx8ap1cTbd8OU+sLgVOq8obdv2MZ8lh25tQBlvhMx41PJE7yQzTvC11UsSod0CDVbrwDOzvKUCQNr5PbB1NbI0v/j31k0qr7sbGoa+yeL38ZcyUXX6hccVFu9sWfNQJGLcs6QhXgH0uNrmDppDQP6G2rQMbLhN95FsCCtn92SEhRdSQnk/HdOCn9X9HbPWFleInWC0H9oIDSD9IGAfBuKvsQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=RA0ILhZuTpVOi+KqJSsnRkAhY0YJ6fwIDoCuAqpglBw=;
 b=l11eSGK6CvFwtJR8R88ZJZh0GLMBjuwzCWKXPHAoRqB6MfehIcFsuDKYF0XtU4P0sRTkC0VQVoPc1+puY3vMcIk0oMDq162HHYJGR82vNxsUgxIhl2MxE7GSfIKoHNfrtEpLtLcp3RVC/hoV+K93snm4zjUl4nqbPkL1pgusa2HE7LItQSRmyEXJl3lcU5dpI8WO5vg4myJ1SEBFiT0Gif1ZlqCNQ7Mu7crtwLJQdn61HiBF4hKuIkHmTDt3Wzokv24RlD2duIqx+MehHQ8iL0cZ2iR0r6xNWNCU70UXRiintw5yTNYjnatGgQRKLf0YdOGk3UGeAC0Y9jijZ7q+JQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=RA0ILhZuTpVOi+KqJSsnRkAhY0YJ6fwIDoCuAqpglBw=;
 b=ZoWIs9SnPhfdoJlie6GRLMbwH4rNxfJFfwbLuPkYUuqlVz8SMRI5nC0tv1gtH39oGSYqDDz2mX+/g62fL0fnBQAM2Sky9qfHgy9z554TtmL5i/xfUNGHCgpAwNU2FjRlSc+WTbTqbWPvqLavz3MRL7k4hPyeZEMUofWfL6ekDCg=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>, Xen-devel
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v3 59/70] x86: Use control flow typechecking where
 possible
Thread-Topic: [PATCH v3 59/70] x86: Use control flow typechecking where
 possible
Thread-Index: AQHYKAHbjTqwtJQGsk6N9L2AW8SaT6yhMVoAgAABwgA=
Date: Wed, 23 Feb 2022 14:28:02 +0000
Message-ID: <4adfa206-752b-a5b4-2d57-04933d47467d@citrix.com>
References: <20220222152645.8844-1-andrew.cooper3@citrix.com>
 <20220222152645.8844-14-andrew.cooper3@citrix.com>
 <d376a457-ef35-4fcb-38d9-d495b385fb65@suse.com>
In-Reply-To: <d376a457-ef35-4fcb-38d9-d495b385fb65@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 6974d5d3-3946-45eb-f4ca-08d9f6d8b332
x-ms-traffictypediagnostic: BL0PR03MB4211:EE_
x-microsoft-antispam-prvs: <BL0PR03MB4211D46E303360C7B3CD1F0FBA3C9@BL0PR03MB4211.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: TWW14A7lBAK+4M1Nt2cAUdNY7Z6QVEsxuQwVBZBAwD5NQYM2JiyZy4cXlxgdJ9tk51EJ+2Gqw35WIBIxVBWKGsU62GqIY33JI4L2ujkHWoqt5xRgwwcUaq0kWEVW5ywvlkD6v9/HZ9yv6t+tajca1xe/xgWG9jYCTBDEPQvhDej/WkCvW6YWU+5HbfNsReO1LPgQ0hdt4MFsILoIO8CSGRRqsskdotV0Ku9Dm44VpNbCB5aN3rGrhL/34sKTtXbX4vmLKc6XyrGRN3ATaK5Ufx8oKn6c4Dm/SdrwQkh+Y4ONAUZZJNHCabpl9H6ok4L4coqk7fTpG1A3Qe09uGd2E13CuZy7iolPHm1waimguDwssCRy7QAeq3mBOYOEgotUpL5KHisad8G/64OjtGQLJVl9CmZ7Alz6htP6h+w6a0OEJmTAAK79HO3hbRG8SGOPwOkKsj1hfFycfUk5vpLj5Chci/6kNSQjpAQk4YVjJ0Hr11trrCl4KCZ63llOn9fEG6f6ft7DlV6Uj1X+KLx0Dkpb1ffe6Y7AK2y3M+uOix5tMeIw8kKDwthaapo4PLUgEXv+1yIkFL2rYdDEzbXJ6TFkLOxO7mm6cBuv/q64Bepo3URkvwUraL3AJj6N/qDWqI2SsGcdnRBn7RTfTPmq/C24LsGX3Y8VtFtEAWZySmb/ZPLJvq9pgJM11W6LoTp9OnWX60dj5WRkka2FG0g68T/rs143PJezegjaDVEBDPk1Ht+tPG+tVVJfQsYkaDZN8C6rFkfxu33t2WQsST5x9w==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(186003)(26005)(122000001)(8936002)(316002)(6916009)(54906003)(86362001)(2616005)(38100700002)(91956017)(76116006)(8676002)(4326008)(66446008)(66476007)(66556008)(66946007)(83380400001)(64756008)(82960400001)(31686004)(71200400001)(6486002)(6506007)(53546011)(38070700005)(2906002)(36756003)(5660300002)(31696002)(508600001)(6512007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?NENXZW1OaEJHOXUxM1Q3a2FFdjNoVmVsTzdwbDdjcmtnY0habkNoV0RhT3d0?=
 =?utf-8?B?T2c0MGtUTGUzYkRlcWtYR0pybWZYc3R3OXlvVGpBV1dHOW1FbG9KZTRZK1hH?=
 =?utf-8?B?S0hOeEJIRTlZWUJicCtYV2ZsZThiT1Z5MGhlT2c5QTJFM1JyaGNzb2NTSmZl?=
 =?utf-8?B?bHMzc2EwVTYxczhVZjhDTnZvcE9kZ0xvdTA2R0NncG5TYlVuU2R1cjFnbkM0?=
 =?utf-8?B?RHMxZERuT2pId3lMK1J1Mmhoa0tJelhhSm9HRTNya2pHMTBQWi9ucGhmRlhz?=
 =?utf-8?B?a1B4T3plNUxWTFgzRStiZjNpSUhuRk5FMTgrWStERXpjQm9EeUpkOE9tY3dO?=
 =?utf-8?B?bE9meElaRDdzNmV6bk82UEJPUFNWVFZiR1hlYmRPSEx4SFdxRmNubWFUdjlr?=
 =?utf-8?B?ZFNNR0V2V2hZY3RGZUpBY1l4UDJBQXNYRjFTcFFJNXl5c2ZicHV3MXJSN3Zk?=
 =?utf-8?B?NHJxNEJpUGVRVHpYVkhDYXd0akVVcFJYWkhydjN4dTF4TU9wSUZhQXBqZEFU?=
 =?utf-8?B?K0NKUjdsOEFDQWl3U05iZjQyNkxacE5INGdQMWxvK09zT0JoYUZiaDRLOWgz?=
 =?utf-8?B?b0p4cGZvRXI4OWpKN1RWMEZYZ2M1L0R5dllLWkdjUi9tem1kK2NRZFpLUWJ3?=
 =?utf-8?B?NUJXL1NxM3N1STZBVitiQVZBSVBFTmU4Q0xvTm1USjhpQ1d2M0tlemxOcnFr?=
 =?utf-8?B?WHFraGFsOExPR1FsSzVoK01kcFp4MXgzUGd2SThPRmNoa3B0bHdBbkYrby9s?=
 =?utf-8?B?cHkxK1JlSzU4QlZKcUl2blEwZGtVT2Q2VTRlOGpZYlhaUHprQ0FjSHlNUXNN?=
 =?utf-8?B?QnZEUERDZEFmV0FEVTJMTXRsUm91V2dyK3djSnBBa0J4TUxtQlNLTy8yelZZ?=
 =?utf-8?B?S2lhcWpjdXg0TmMvN1NUOXVGaW95VUw0cmx2L1VQQ1Zya1d4SUcxU2ZDY0VH?=
 =?utf-8?B?bHdxNFYzYXdCZDFmSTJVL1pjMXBCcUovUGVJQ2pCYjU5WWNRUnBKTkxTQWpL?=
 =?utf-8?B?MVJhWGpNNkQ5VGp3MmF0WXlPM0RNZTZUZEtuc1Z6VnNOdVNSbHNkSmQ3aWxP?=
 =?utf-8?B?QnI1cWFRRXlaaE1peWZOVW9ubXlxZ2VIZTBZc3RxV2ZpcXkreWsyWk1oS0pN?=
 =?utf-8?B?V0QwVWRYN29abGIyY3YxL0pPNE9ZWGJkaUtXV0lFSEFmSG1lREJQelJ1NDg0?=
 =?utf-8?B?VkxSSDFXYkl0VjFtY3RiT2F6aitwZTBocnMrSzZHZjJ5RTkvejE2M0FvdFUw?=
 =?utf-8?B?QjhhM1FZTmtxOWVURmxDdXVZRldRRnJIY3VtZjYrSFRBZ1VSOFN4eTNYazdm?=
 =?utf-8?B?RzZoMWtFV2p3UFJENWsrUlJlKzRxYVRBcmZYM041Q3hyWGFvMVprM3NjamFh?=
 =?utf-8?B?bXgxUUJrS3dtcTV6QUY4RTlZaC9TRXJoTkp6VDIrbklaSmhHOHBaVzFhM1BW?=
 =?utf-8?B?bTBBaGFsY0pOazg2OXhvWERwMTNXaUM4K2ZzQ3hXQ0FTZ3RXWHRGZ2pNYlEx?=
 =?utf-8?B?VkQwbFAyOGRvSGlEMWYvMzdSVVp1UEpUeHNubG5NKzdMdE5DYTZxMFRDSDEx?=
 =?utf-8?B?MDlROC9nL2VDVDNpVGlIemNXcUZYSW5sbzc5U0wxWjNGTVUvYjJDL1Zxdys0?=
 =?utf-8?B?RTYrVi9xYTZMa2Yxam54cWVlOVZIQjFIM1JZMC9maXM4UnRSYnN4cUU3SlpS?=
 =?utf-8?B?Z1dDbGRMZzBzOXRzNFE0SFlUbzd5cFhWOTd0Ymh4UU1QY3dWMThmNU41OUhT?=
 =?utf-8?B?Wjh5a2ZLSmEzbzQ5cGdTQW1xNWNYRExQWEZ4cHJ2bTg4NngrZmo5eWdKSmFy?=
 =?utf-8?B?eWx5QmM3Qm05RWhpN0M3L2F0dkdTa0hXRlQ5blVEeVJFTVNIMm80UlBnSU9y?=
 =?utf-8?B?NERxWkhXcWJDU1c4Y1RRK1BSODRrelZYanFhZDU3OUZlWnRpQWdzeWxvKzRU?=
 =?utf-8?B?ZFVqSTZrV3ZvUFJVVEtqVGJ5bUVLbDhkaWlrMUFBaWR5cjhiUmMxRG1ZYjdX?=
 =?utf-8?B?VjVoVHVwNG9GbllSVGsvUTdOTlBxd3EzQkZGa3JlZHVPY3hCZW90blhIYnZq?=
 =?utf-8?B?UHp4SC9NTWh2WE9OYkxIaG1zUThZdkg4aXRYT3gxclJ4U1hSakhPMGQwRzVh?=
 =?utf-8?B?NDV1SUUzTllHd09wTGxzQzI4S1MvQXFJOXIyd1IzczgrRVVHbGQ1cXoxRTI0?=
 =?utf-8?B?emkyNVhUb0RySmkyZlJKb28yckxETW1jM2xmaUp5LzRmWFUyakl0aUJ3bC96?=
 =?utf-8?B?b05scVRKWkkzZ1pSRDlva0E2TmRnPT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <1E1C1F5B28E3BF47ADDB6960874D05DE@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6974d5d3-3946-45eb-f4ca-08d9f6d8b332
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Feb 2022 14:28:02.8216
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 7oy4CuUe+eaC0f/dRZp/9c4iij9ad/5MX3Wzsx46/hSmWE81q1SFnQD0HLS+vgK1xKYNWCVQvxA/8jFMQ6ymrl8Ht68IrZBjhiXG9gXEszA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR03MB4211
X-OriginatorOrg: citrix.com

T24gMjMvMDIvMjAyMiAxNDoyMSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDIyLjAyLjIwMjIg
MTY6MjYsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBOb3cgYWxsIGNhbGxlZXMgaGF2ZSBiZWVu
IGFubm90YXRlZCwgdHVybiBvbiB0eXBlY2hlY2tpbmcgdG8gY2F0Y2ggaXNzdWVzIGluDQo+PiB0
aGUgZnV0dXJlLg0KPj4NCj4+IFRoaXMgZXh0ZW5zaW9uIGlzbid0IGluIGEgcmVsZWFzZWQgdmVy
c2lvbiBvZiBHQ0MgeWV0LCBzbyBwcm92aWRlIGEgY29udGFpbmVyDQo+PiB0byB1c2Ugd2l0aCB0
aGUgZXh0ZW50aW9uIGluY2x1ZGVkLCBhbmQgYWRkIGl0IHRvIENJLiAgUkFORENPTkZJRyBpcyBu
ZWNlc3NhcnkNCj4+IGJlY2F1c2Ugc29tZSBzdHVicyBmb3IgY29tcGlsZWQtb3V0IHN1YnN5c3Rl
bXMgYXJlIHVzZWQgYXMgZnVuY3Rpb24gcG9pbnRlcg0KPj4gdGFyZ2V0cy4NCj4+DQo+PiBTaWdu
ZWQtb2ZmLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPg0KPiBJ
IGNlcnRhaW5seSBzZWUgdGhhdCB3ZSB3aWxsIHdhbnQgdG8gaGF2ZSB0aGlzIGV4dHJhIGxldmVs
IG9mIHNhZmV0eS4NCj4gSGVuY2UgZmVlbCBmcmVlIHRvIGFkZA0KPiBBY2tlZC1ieTogSmFuIEJl
dWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KDQpUaGFua3MuDQoNCj4gQnV0IEknZCBsaWtlIHVz
IHRvIGZvcm0gYSBwbGFuIGluIGNhc2UgdGhlIGNoYW5nZSBkb2Vzbid0IGdldCBjb21taXR0ZWQN
Cj4gcmVsYXRpdmVseSBzb29uIGFmdGVyIGdjYyByZS1vcGVucyBmb3IgZ2VuZXJhbCBkZXZlbG9w
bWVudCBhZnRlciBnY2MxMg0KPiB3YXMgYnJhbmNoZWQgb2ZmLiBXZSBkb24ndCB3YW50IHRvIGdl
dCBpbnRvIHRoZSBwb3NpdGlvbiBvZiBuZWVkaW5nIHRvDQo+IG1haW50YWluIGEgZ2NjIHBhdGNo
LiBEbyB5b3UgaGF2ZSBhbnkgaW5zaWdodCBhcyB0byB3aGF0IGlzIGFjdHVhbGx5DQo+IGJsb2Nr
aW5nIHRoZSBjb21taXR0aW5nIG9mIHRoYXQgY2hhbmdlLCBzZWVpbmcgdGhhdCBpdCBoYXMgYmVl
biBhcm91bmQNCj4gZm9yIGEgd2hpbGU/DQoNCkknbGwgZm9sbG93IHVwIGFuZCB0cnkgdG8gdW5i
bG9jay4NCg0KfkFuZHJldw0K


From xen-devel-bounces@lists.xenproject.org Wed Feb 23 14:29:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 23 Feb 2022 14:29:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277395.473872 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMseK-0004Gm-CI; Wed, 23 Feb 2022 14:29:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277395.473872; Wed, 23 Feb 2022 14:29:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMseK-0004Gf-8k; Wed, 23 Feb 2022 14:29:48 +0000
Received: by outflank-mailman (input) for mailman id 277395;
 Wed, 23 Feb 2022 14:29:47 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=DZ7u=TG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nMseI-0004GQ-Tw
 for xen-devel@lists.xenproject.org; Wed, 23 Feb 2022 14:29:47 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0c219ba0-94b5-11ec-8539-5f4723681683;
 Wed, 23 Feb 2022 15:29:45 +0100 (CET)
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur02lp2056.outbound.protection.outlook.com [104.47.5.56]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-13-cY13-Bf5Pt6PboSycw268g-1; Wed, 23 Feb 2022 15:29:44 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DB7PR04MB5947.eurprd04.prod.outlook.com (2603:10a6:10:83::33) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Wed, 23 Feb
 2022 14:29:42 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.022; Wed, 23 Feb 2022
 14:29:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0c219ba0-94b5-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645626585;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=xIdKrvfeB4WO/QYtbzJorRsITmpWIWfeO53pg3NB/78=;
	b=cNiUszxSNixcIxJEXk2hUayHFK8vpWyvM/9N+523EkyATx+GrSzED0wGFCK/bjTAeyziKR
	R6WeAOvMJQpzJj2YfeAlFQvwbyyaRAB5YGBjqJeEQbEmKQohFnZYJ6IN7DumezJLi+vDDy
	1xsCt8xEhJtVq/PYEveo8CQx6bli4X4=
X-MC-Unique: cY13-Bf5Pt6PboSycw268g-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=W3DpNYxzkPwZDMqdO57iMMQIGaQULiuUXt/fY5uQ3SofD6Ravt61Q2Dar3NaNFT88ZdkPAlCzojcv2K0FC2OflKl15ZhTvyNnXYGQ4elNlfE3mlOBVLzmAzw0IW2cYRtUuARLmE0zbY1beiYjRrGyr2rHHmW1TsglmBqAk8IDPPbBjiTTj1Bzs6x1QbrN7ysC+tzQpf0tRtJUGbR/HMga6Jtsjh3pkmh+LdpQr2CeKjCrZ53bfK/mPcqNlehD7dIF9mzv0dG5fZEcZpba6SLK2rcMxR79R47zLpC8xPONVW9PlI2aEfH+G0f0KCCjybeLlhwASSZV53Xh473S8vJgw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=4AP0wv/rDw8QLXhERmaitdBAiW7jkpfZhtNATeW13Ko=;
 b=CA8pzuirXKY1OBtkZnRdCQmthyhkbh4YJbRMbbhdwLsFNmx/DJ9/l8TZqucdsQgFQRINmOebA2t6j/mU6qXlysjs56zVXjem444VUvHA2wPircJPQKb6zlwCq+fyVeSy8ojpE979otVKdUQ7GiIj9A2zxuQYPzHEgrdyxIeaqBtj3QldYxSDMXovoaLFqLsZFMi4cEaodKQdDCrr9Wo66FanoJ770mFUWIzNcyChQmdeRqmiavnWmFf3gR686BOTNrMoYgwHc75s/OjYVCUhfnRfSppDiLuQm4rhGQddXZjiDbaqmUmQCUYhfAoiwo+NylQnq36cm8y+PYJR5ib5VQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <29040861-0b89-d376-101c-35d749653837@suse.com>
Date: Wed, 23 Feb 2022 15:29:40 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v3 60/70] x86: Build check for embedded endbr64
 instructions
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
CC: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>, Roger Pau Monne <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20220222152645.8844-1-andrew.cooper3@citrix.com>
 <20220222152645.8844-15-andrew.cooper3@citrix.com>
 <48241c60-294b-782f-7217-45a3dc929c38@suse.com>
 <505a8553-5930-762b-ed07-f8f49df20064@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <505a8553-5930-762b-ed07-f8f49df20064@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS8PR04CA0010.eurprd04.prod.outlook.com
 (2603:10a6:20b:310::15) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 0845c134-ee3f-4162-9b07-08d9f6d8ee7f
X-MS-TrafficTypeDiagnostic: DB7PR04MB5947:EE_
X-Microsoft-Antispam-PRVS:
	<DB7PR04MB59477FEBCCEDBE91E31EDF78B33C9@DB7PR04MB5947.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	hkNUGPN/mhdQjCTbC7XIilpshpcIgYYt+cWNsH4hpx4XlzPWyI3WV0M0s2af+GjmlkbOo6/ygC9pgYc+8StZSX6kzEThsllBh8fL23ppZhx25FdOLfuyXr2Om+Ljy8mGiwfhVYe0/ekJVGSMjDUuH/+H1RLjCoxCVwoWom+SKl0i3rqVitQbiwvSou7uM1yrx3Fpd3Ej+uXrwVjZgqheLjyeMwrxeTzhQpsmJCmGUCy+Y3WkXDmo5BKlai9aNoxkmuW6EoOnjvNA3Yeqzu6TZcweqRwMMw3xBo3zUh5xG16/VVIod9BWk4eOj36BZuhyti7cub0nkl5ye1cJtjIdr5LUmRc1cRmqAaMbHHrYCLt+nDWDkoReSpGPnyCylIv6sN0OnA2UgmRigHGTGdO8W20HxNtjBFA1E5SjxuyzCP4wPUB9LSIqT7yIM3hpmprtbxGXIGxlL/wbRqwixR2BalVJkBjNn+3zgF0Fx2X+VNDbMm8+UWAA4Pj3gWkJD9lP4ua/xRTiQtnTcqzyjdnvaywGZwl0PeBJttVVo113ciBagy6iG7sUK8y4qnZuTGXuIps2u4zX2Ad012m5LH6qGG62tCy5jEl/fBiB1RYp0w/h4rRipbWupwG+lVqsejoeYgimaH0JZAJ9FJKfqFsp9t2KVIO+94meomVL3kdUGgxlx760NeQa34RTDADbwcVbwr0dfMiDG1DAAGHQg7MbM/e5Os1QaQH82BcOk6fyT3L1a6O9T09UwLHDI61V3TOt
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(53546011)(31686004)(54906003)(508600001)(26005)(6916009)(8936002)(6506007)(5660300002)(38100700002)(186003)(316002)(36756003)(6486002)(66946007)(2616005)(66556008)(66476007)(4326008)(86362001)(6512007)(8676002)(31696002)(83380400001)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?q6RViBvRvt5a2lveMtRY6opMrz1F+WTn7fdAAqPOOJorIhLL37pORp0mwjco?=
 =?us-ascii?Q?/zM4RdtuFbM8lvsJ1n4/okfgUq9njoZjH7q1WoE7RGkvSCiEvrxqgI8Z51pr?=
 =?us-ascii?Q?V4NIb9zUv6u+wnoyzyfdu6vBCS1tYFMPYUxs7j4ahx2IfzZ3Avy6WOsLDfm9?=
 =?us-ascii?Q?NmgCIKqGeLg645m5FQS489+97vu3ZEELt7+sLOIjh+oSA6i2qBxx4Ux5Uky+?=
 =?us-ascii?Q?7KkGpQKLpgxIc+tVQCGJzAeA4EWbr2BG9Yfz+OfRcZV5eq+CXFdD6rQmAtPk?=
 =?us-ascii?Q?TG7GHYDVm/ULAR8d2b1M4J2A570DeWGoOIEGBJrERi+cfSERs21aYA/9O8/S?=
 =?us-ascii?Q?I3gPLADz0EIV0EfSS/lEKGID7ogGvB6F30UtbJRBbztjlV/t1nKVDHQVNQrN?=
 =?us-ascii?Q?ANV7Hze+VihFmVHRE1x41GaOfHEkapm6J8esyjxlH1zRgs+yYd3f7h7OvZqG?=
 =?us-ascii?Q?P+K8StwNVAO5CwyStg9h0s0KySh08zDBFn+6gpHNR5iJPlf/LWDwrGNCJA+h?=
 =?us-ascii?Q?jIvanAMK8YNo/YMx5BMilAoO70RECs9PVioka1z4dvh8RDAONrl9NTmJV6HA?=
 =?us-ascii?Q?/uLoOfzeUeXZLZTfPHMEL/zed16WboXWk1KIs2q6UiAmz0lEf9vVW5tp9Alz?=
 =?us-ascii?Q?g0fIUgZ0U6rjaQI8res9yMAa80Xsog2vlZaMr3liOvpi3p8+faPp8SbqQVCr?=
 =?us-ascii?Q?SN/LKDn+PYT4SBzeVgF5vhBGHr15htphh436djNaP4tPDRfV4SPMdn8jSi15?=
 =?us-ascii?Q?4uRY+vRWB8zW1QB4Iez/jvmn72mLouz31qsiYjbB8unsaKp3aDuJ0Dxib/g3?=
 =?us-ascii?Q?y7/84GZa5i4BhJbjAgQ988dmvQLa+0M1JGRx0vd/OWu87ISQiswe7klRtHGW?=
 =?us-ascii?Q?6TVICTa1puN3nNHKLQ14WmJuqByHi168erb6BGmXk0Vcu87apZ8im4jF7V4o?=
 =?us-ascii?Q?61VijTuNz4qni6AQUDHf1GgptoXPJiUg7btQACX+GykeGrUEp6SzVU/J4Ast?=
 =?us-ascii?Q?RmX+NujvMlWzyFlOQypzUjTJDyuhkQGx3uwx5Qh4i3x49w3hOOmPQKyRZxtK?=
 =?us-ascii?Q?CVZDlCTeha62zsqbynLyGDGeLa7Ju1Uwpq6mb2IP7WfXwXW0WJeawrYipqu9?=
 =?us-ascii?Q?hBn0b4WouXNaeBq4L9+p23CGs5XkuiJcrYloAZ6b4EtuUHMqjj3rbRfDA3HX?=
 =?us-ascii?Q?CzM/dAOfVIB4wgrO20NyrUZdu47cvr2ODeBQnOMlNmdGjeigZBWFBd+ir+wu?=
 =?us-ascii?Q?fUp4bbIDnv/S9YGhC5e92U50K9ygS8JcIGmnjQMfYLlXjfuySw4zRIKaSuhL?=
 =?us-ascii?Q?8YgMoGXy6JvcnVkHKDi9PYrVD3vLJcqeqMGeQ0vpVzoWgnmkmPqWKYYrlxU3?=
 =?us-ascii?Q?EvNIKA17CQjvwzwekq/ujdUw+sJl0IgV1Omntjm8Bsi+pK8SIYwV99on8omH?=
 =?us-ascii?Q?nM8YaxEgK/UbmJvCcxyuzEHujJsu0m2+kxmRGRXSf2X3ejBGMq3svBaICmRg?=
 =?us-ascii?Q?71hLsANGfjq1g/FiWRc1QzrmWLQPNweeaUqjike2fyViwR1tbP1QAONzYaZ+?=
 =?us-ascii?Q?EfOWGpT+DKPCTgYrhSA523djYeBjHabbp0eo4qwpFbqbhWzNenzYvW7L3h4g?=
 =?us-ascii?Q?wWWghvQFO0/Mgo6cf/pzezM=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0845c134-ee3f-4162-9b07-08d9f6d8ee7f
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2022 14:29:42.6063
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6uHfbOlQ8m/AZ44dE+ashUNg3Mguqhy5Ri/Rv8LVPnH37xTUijI9Mbz+zHE0QGYDSpV+/mN6QFYso9RchunaJA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB5947

On 23.02.2022 13:05, Andrew Cooper wrote:
> On 23/02/2022 11:31, Jan Beulich wrote:
>> On 22.02.2022 16:26, Andrew Cooper wrote:
>>> up on a non-instruction boundary.  Such embedded instructions mark lega=
l
>>> indirect branch targets as far as the CPU is concerned, which aren't le=
gal as
>>> far as the logic is concerned.
>> Thinking about it: Wouldn't it be yet slightly more reassuring to also
>> look for ENDBR32?
>=20
> I considered that, but it's awkward to do and doubles the length of this
> already ~0.7s (x2 for efi because this step isn't performed in parallel)
> delay to the build.

(Side note: In general the two linking steps can occur in parallel. An
exception is when the note.o need to be extracted from xen-syms for use
by xen.efi. But that should happen only with old binutils.)

> We do not have __HYPERVISOR_CS32, so ENDBR32 will yield #CP[endbr] if
> encountered.
>=20
> If an attacker has managed to edit the GDT to insert a compatibility
> code segment, and hijacked a far transfer to use it, then the absence of
> ENDBR32's in the binary isn't going to be an impediment.

True.

>>> --- /dev/null
>>> +++ b/xen/tools/check-endbr.sh
>>> @@ -0,0 +1,85 @@
>>> +#!/bin/sh
>>> +#
>>> +# Usage ./$0 xen-syms
>>> +#
>>> +set -e
>>> +
>>> +# Prettyprint parameters a little for message
>>> +MSG_PFX=3D"${0##*/} ${1##*/}"
>>> +
>>> +OBJCOPY=3D"${OBJCOPY:-objcopy} -j .text $1"
>>> +OBJDUMP=3D"${OBJDUMP:-objdump} -j .text $1"
>> While embedding the arguments here shortens the lines where these are
>> used, the appearance especially of $OBJCOPY with a single file name
>> argument ...
>>
>>> +ADDR2LINE=3D"${ADDR2LINE:-addr2line}"
>>> +
>>> +D=3D$(mktemp -d)
>>> +trap "rm -rf $D" EXIT
>>> +
>>> +TEXT_BIN=3D$D/xen-syms.text
>>> +VALID=3D$D/valid-addrs
>>> +ALL=3D$D/all-addrs
>>> +BAD=3D$D/bad-addrs
>>> +
>>> +# Check that grep can do binary searches.  Some, e.g. busybox, can't. =
 Leave a
>>> +# warning but don't fail the build.
>>> +echo "X" | grep -aob "X" -q 2>/dev/null ||
>>> +    { echo "$MSG_PFX Warning: grep can't do binary searches" >&2; exit=
 0; }
>>> +
>>> +#
>>> +# First, look for all the valid endbr64 instructions.
>>> +# A worst-case disassembly, viewed through cat -A, may look like:
>>> +#
>>> +# ffff82d040337bd4 <endbr64>:$
>>> +# ffff82d040337bd4:^If3 0f 1e fa          ^Iendbr64 $
>>> +# ffff82d040337bd8:^Ieb fe                ^Ijmp    ffff82d040337bd8 <e=
ndbr64+0x4>$
>>> +# ffff82d040337bda:^Ib8 f3 0f 1e fa       ^Imov    $0xfa1e0ff3,%eax$
>>> +#
>>> +# Want to grab the address of endbr64 instructions only, ignoring func=
tion
>>> +# names/jump labels/etc, so look for 'endbr64' preceeded by a tab and =
with any
>>> +# number of trailing spaces before the end of the line.
>>> +#
>>> +${OBJDUMP} -d -w | grep '	endbr64 *$' | cut -f 1 -d ':' > $VALID &
>>> +
>>> +#
>>> +# Second, look for any endbr64 byte sequence
>>> +# This has a couple of complications:
>>> +#
>>> +# 1) Grep binary search isn't VMA aware.  Copy .text out as binary, ca=
using
>>> +#    the grep offset to be from the start of .text.
>>> +#
>>> +# 2) dash's printf doesn't understand hex escapes, hence the use of oc=
tal.
>>> +#
>>> +# 3) AWK can't add 64bit integers, because internally all numbers are =
doubles.
>>> +#    When the upper bits are set, the exponents worth of precision is =
lost in
>>> +#    the lower bits, rounding integers to the nearest 4k.
>>> +#
>>> +#    Instead, use the fact that Xen's .text is within a 1G aligned reg=
ion, and
>>> +#    split the VMA in half so AWK's numeric addition is only working o=
n 32 bit
>>> +#    numbers, which don't lose precision.
>>> +#
>>> +eval $(${OBJDUMP} -h | awk '$2 =3D=3D ".text" {printf "vma_hi=3D%s\nvm=
a_lo=3D%s\n", substr($4, 1, 8), substr($4, 9, 16)}')
>>> +
>>> +${OBJCOPY} -O binary $TEXT_BIN
>> ..., like here, is then somewhat misleading considering that the tool
>> can take one or two filenames as arguments.
>=20
> I can re-expand them if you'd prefer.=C2=A0 This would be the delta:

I'd actually be happy to keep "-j .text" where you had it, and merely
move the file arguments to the actual invocation lines. But the way
you have it with the incremental diff is of course even less
"unexpected".

Jan

> diff --git a/xen/tools/check-endbr.sh b/xen/tools/check-endbr.sh
> index 85878353112a..3019ca1c7db0 100755
> --- a/xen/tools/check-endbr.sh
> +++ b/xen/tools/check-endbr.sh
> @@ -7,8 +7,8 @@ set -e
> =C2=A0# Prettyprint parameters a little for message
> =C2=A0MSG_PFX=3D"${0##*/} ${1##*/}"
> =C2=A0
> -OBJCOPY=3D"${OBJCOPY:-objcopy} -j .text $1"
> -OBJDUMP=3D"${OBJDUMP:-objdump} -j .text $1"
> +OBJCOPY=3D"${OBJCOPY:-objcopy}"
> +OBJDUMP=3D"${OBJDUMP:-objdump}"
> =C2=A0ADDR2LINE=3D"${ADDR2LINE:-addr2line}"
> =C2=A0
> =C2=A0D=3D$(mktemp -d)
> @@ -37,7 +37,7 @@ echo "X" | grep -aob "X" -q 2>/dev/null ||
> =C2=A0# names/jump labels/etc, so look for 'endbr64' preceeded by a tab a=
nd
> with any
> =C2=A0# number of trailing spaces before the end of the line.
> =C2=A0#
> -${OBJDUMP} -d -w | grep '=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 endbr64 *$' | cu=
t -f 1 -d ':' > $VALID &
> +${OBJDUMP} -j .text $1 -d -w | grep '=C2=A0 endbr64 *$' | cut -f 1 -d ':=
' >
> $VALID &
> =C2=A0
> =C2=A0#
> =C2=A0# Second, look for any endbr64 byte sequence
> @@ -56,9 +56,10 @@ ${OBJDUMP} -d -w | grep '=C2=A0=C2=A0=C2=A0 endbr64 *$=
' | cut -f 1
> -d ':' > $VALID &
> =C2=A0#=C2=A0=C2=A0=C2=A0 split the VMA in half so AWK's numeric addition=
 is only working on
> 32 bit
> =C2=A0#=C2=A0=C2=A0=C2=A0 numbers, which don't lose precision.
> =C2=A0#
> -eval $(${OBJDUMP} -h | awk '$2 =3D=3D ".text" {printf
> "vma_hi=3D%s\nvma_lo=3D%s\n", substr($4, 1, 8), substr($4, 9, 16)}')
> +eval $(${OBJDUMP} -j .text $1 -h |
> +=C2=A0=C2=A0=C2=A0 awk '$2 =3D=3D ".text" {printf "vma_hi=3D%s\nvma_lo=
=3D%s\n", substr($4, 1,
> 8), substr($4, 9, 16)}')
> =C2=A0
> -${OBJCOPY} -O binary $TEXT_BIN
> +${OBJCOPY} -j .text $1 -O binary $TEXT_BIN
> =C2=A0grep -aob "$(printf '\363\17\36\372')" $TEXT_BIN |
> =C2=A0=C2=A0=C2=A0=C2=A0 awk -F':' '{printf "%s%x\n", "'$vma_hi'", int(0x=
'$vma_lo') + $1}' >
> $ALL
> =C2=A0
>=20
> ~Andrew



From xen-devel-bounces@lists.xenproject.org Wed Feb 23 14:53:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 23 Feb 2022 14:53:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277404.473882 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMt11-0007PO-Bw; Wed, 23 Feb 2022 14:53:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277404.473882; Wed, 23 Feb 2022 14:53:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMt11-0007PH-8t; Wed, 23 Feb 2022 14:53:15 +0000
Received: by outflank-mailman (input) for mailman id 277404;
 Wed, 23 Feb 2022 14:53:13 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=zdyb=TG=invisiblethingslab.com=woju@srs-se1.protection.inumbo.net>)
 id 1nMt0z-0007PB-KE
 for xen-devel@lists.xenproject.org; Wed, 23 Feb 2022 14:53:13 +0000
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 510ef2bf-94b8-11ec-8eb8-a37418f5ba1a;
 Wed, 23 Feb 2022 15:53:11 +0100 (CET)
Received: from compute3.internal (compute3.nyi.internal [10.202.2.43])
 by mailout.nyi.internal (Postfix) with ESMTP id 3993B5C0036;
 Wed, 23 Feb 2022 09:53:09 -0500 (EST)
Received: from mailfrontend1 ([10.202.2.162])
 by compute3.internal (MEProxy); Wed, 23 Feb 2022 09:53:09 -0500
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed,
 23 Feb 2022 09:53:07 -0500 (EST)
Received: by mail-itl.localdomain (Postfix, from userid 1000)
 id D0DAB88E8D; Wed, 23 Feb 2022 15:52:55 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 510ef2bf-94b8-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-type:date:date:from:from
	:in-reply-to:in-reply-to:message-id:mime-version:references
	:reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy
	:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=4MMpDRkWVS7qXiWDn
	I+dQpJrE0JMn5HzgVdL+Q8qz2E=; b=bsJg0HZU1Nr9Bm8ngLMoU+E/mCdgieYgb
	FTdVQM8Zzlun+4qkBW86lsKSxGd0m1OQtvIrC+LdAUjw0bk+/EfirHbMzNK5xX5m
	Wgm6QbNDZlQ2PREI7bPxD+5XJm9+V28P/kPL/v43p62UH6vd1TmlOb8QAlkbQNec
	df082aS/8iwZTlwgnowlrgQW29H9XYkLnC4VACF6F1vV9GppHe3fQARmnN2fdUME
	RNEdlIeu3+v3v9L5UphiDNP2TgESl0/Eu5Bp25HeUaRL+U7hftK8lsDT6ACH7WEU
	Ub/zkOt2y9YoirG0b6aXG6FVlH1GjW9eZNesppiWSaHxYvwhY1NGA==
X-ME-Sender: <xms:VEoWYs64Ln6UWAIsMdBwyzjYACMzPiFt-eZGMPi8HUmL_hdESeQ0PQ>
    <xme:VEoWYt7fy_03EDafYavBd5KKdcy_mUk1c_9I3wXzCFIV_XXDJo_tc2jNVgJjZOOHL
    e7c-LQ2RY-dEtM>
X-ME-Received: <xmr:VEoWYrcd-BbWKnVU5yTkmbflq80mnChgCSXSjcoqkMmxmvus4KUNg86Z7GXasSkgqKNm6EOx-KhzYR47D_DxEFP8a1N5HUOiEU-IBDIWGw>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrledtgdeikecutefuodetggdotefrodftvf
    curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
    uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
    fjughrpeffhffvuffkfhggtggujgesghdtreertddtjeenucfhrhhomhephghojhhtvghk
    ucfrohhrtgiihihkuceofihojhhusehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtg
    homheqnecuggftrfgrthhtvghrnhepfeejieetvddugfekfeeitdffudefheekvedvjeet
    ffdtkefftdejkeffveejjedvnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpe
    hmrghilhhfrhhomhepfihojhhusehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtgho
    mh
X-ME-Proxy: <xmx:VEoWYhJ97g1KfvHQdSLCucev8z8UDCl5N4Yi8ZYzC5q1hJL1YPhycA>
    <xmx:VEoWYgIxxVdwjTxjZgrn9ulPtsYsDk6nnMoz6NN0na4TxKOETIyi7w>
    <xmx:VEoWYixGvPM_qrLLf-Q9AYiAqZji6WlZTvzeXu7sYphVFh2qDdtuXg>
    <xmx:VUoWYpodhav9lnlxtA_qBvYMrr2xh9ssU7kdY82rFTRxY2zgmd1bGw>
Date: Wed, 23 Feb 2022 15:52:55 +0100
From: Wojtek Porczyk <woju@invisiblethingslab.com>
To: George Dunlap <George.Dunlap@citrix.com>
Cc: Marek =?iso-8859-1?Q?Marczykowski-G=F3recki?= <marmarek@invisiblethingslab.com>,
	Jan Beulich <jbeulich@suse.com>, Ian Jackson <iwj@xenproject.org>,
	Committers <committers@xenproject.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Andrew Cooper <Andrew.Cooper3@citrix.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH] RFC: Version support policy
Message-ID: <YhZKR46LDNHgmkQN@invisiblethingslab.com>
Mail-Followup-To: George Dunlap <George.Dunlap@citrix.com>,
	Marek =?iso-8859-1?Q?Marczykowski-G=F3recki?= <marmarek@invisiblethingslab.com>,
	Jan Beulich <jbeulich@suse.com>, Ian Jackson <iwj@xenproject.org>,
	Committers <committers@xenproject.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Andrew Cooper <Andrew.Cooper3@citrix.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
References: <20210813113727.6028-1-iwj@xenproject.org>
 <de32c6c4-5ad5-862e-3988-0e7310ec3ecb@suse.com>
 <C6A7B444-4CFB-43A7-8FA8-AD1049F83912@citrix.com>
 <YhTUe7K5/rlek4AA@invisiblethingslab.com>
 <77CD0734-A343-45CF-8A44-5C53771E404A@citrix.com>
 <f5c50526-2fdc-029e-751d-eb05b29a8366@suse.com>
 <YhUEc+Ztwf312ZRx@mail-itl>
 <17643780-C062-4565-B05C-7D42745B5BC0@citrix.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="y0J7VvKM6hLIg08/"
Content-Disposition: inline
In-Reply-To: <17643780-C062-4565-B05C-7D42745B5BC0@citrix.com>


--y0J7VvKM6hLIg08/
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Feb 23, 2022 at 01:20:26PM +0000, George Dunlap wrote:
> > On Feb 22, 2022, at 3:42 PM, Marek Marczykowski-G=C3=B3recki <marmarek@=
invisiblethingslab.com> wrote:
> >=20
> > On Tue, Feb 22, 2022 at 04:05:19PM +0100, Jan Beulich wrote:
> >> On 22.02.2022 15:58, George Dunlap wrote:
> >>>> On Feb 22, 2022, at 12:18 PM, Wojtek Porczyk <woju@invisiblethingsla=
b.com> wrote:
> >>>> On Mon, Feb 14, 2022 at 09:50:25PM +0000, George Dunlap wrote:
> >>>>> I think it=E2=80=99s too much effort to ask developers to try to fi=
nd the actual
> >>>>> minimum version of each individual dependency as things evolve.
> >>>>=20
> >>>> By "find the actual minimum version", do you mean to get to know the=
 version
> >>>> number, or install that version on developer's machine?
> >>>=20
> >>> Well suppose that a developer writes code that depends on an external=
 library.  The external library on their own machine is 4.5; so they know t=
hat 4.5 works.  But will 4.4 work?  How about 4.0?  Or 3.9?  Or 2.2?  Maybe=
 it works on 3.8+ and 2.13+, but not 2.0-2.12 or 3.0-3.7.
> >>>=20
> >>> I don=E2=80=99t think it=E2=80=99s fair to ask people submitting patc=
hes to do the work of tracking down which exact versions actually work and =
which ones don=E2=80=99t actually work;
> >>=20
> >> But somebody will need to do this. If it's not done right away, someone
> >> (else) will hit a build issue on a perhaps just slightly older platfor=
m.
> >=20
> > That's why declare what version _should_ work (and test that via CI),
> > instead of trying to find what is the minimum version that is actually
> > required. This may result in saying "you need libfoo 3.4" while in
> > practice 3.3 would be fine too, but I think that's reasonable
> > compromise.
>=20
> This paragraph is a little unclear; you say =E2=80=9Cshould=E2=80=9D, but=
 then talk about what has been tested to work.
>=20
> To me =E2=80=9Cwhat version should work=E2=80=9D means you track down the=
 version of the
> library where the relied-upon functionality was introduced; in your libfoo
> example, it would be 3.3.  I think we should only include versions that h=
ave
> been tested to work.  If the CI loop only tests libfoo 3.4, then we should
> list 3.4 as the requirement.  If someone else tests 3.3 themselves and
> reports that it works, then we can use 3.3.

I don't think there should be much "tracking down" involved, at least not=
=20
to the level of bisecting. Instead a simple statement of "tested with
dependency $D version $V from distro $L", and the reviewer checks if it's t=
he
oldest supported version, or the relevant API didn't significantly divert.

Also, there's nothing wrong with declaring a later version for availability
reasons like "it's in one of the distros we use in CI". In the example: we
know that technically 3.3 works, but we don't test it, so to be safe we
"require" 3.4.

Distro-related availability reasons tend to be correlated between CI and
developer's boxen, so if we test 3.4 and not 3.3, chances are, it will be
easier to set up a 3.4 version on dev's workstation. Again, without specific
example it's hard to say, but if it's relatively easy to set up version 3.4,
then it might be reasonable to ask contributors to test against that versio=
n,
which I think is the answer your concern.

If anyone badly needs 3.3, it's his/her burden to argue why the project and
every single contributor needs to do extra work to acquire 3.3, because the
differential (compile themselves vs apt-get install) is what might cause
testing that version to be unfair for everone else. Other side of the coin =
is
pretty similar: if anyone needs a feature from 3.5, it's his/her duty to
convince everone why the dependency needs to be bumped.


--=20
pozdrawiam / best regards
Wojtek Porczyk
Gramine / Invisible Things Lab
=20
 I do not fear computers,
 I fear lack of them.
    -- Isaac Asimov

--y0J7VvKM6hLIg08/
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEaO0VFfpr0tEF6hYkv2vZMhA6I1EFAmIWSkYACgkQv2vZMhA6
I1EK5A/+KtW8lrLeGhbqqqxCrScOXFxWUE6IyiYfb/WHNqZOieJyeZSnZCl2GdmU
XngChV7w9tDrkKdd14NEXFpVQHn0UxAemZiIAS7XlrlWTgJs3NB/fWzF7H4+HUs/
eLFiYV4aNaMS4YBYRYln8RzAlkuL1g55KWmMpHcZwm0R5y4+hBqreXG+54/q4aaD
xSPzsvCoF/mcppDbZ0rzUaY5+C+zgjzGlOTrULI3CikFC8oHg9Se554V1atiIjP4
awHNknORN33SHARu0iOwM1XEJjgVptrGqwzoe+yGkd6zD0RC6dLi8ks8Iek3KL8d
Vf/VIcuybGUQyt4+legskFTG6ZlBb1CBhWLcet/NTnWXMqb18JB66zj43tkCqPQ8
rADhgnrN+3Vi148Bg6M4JgaZ7qvgB5lMUTJSHxzNzzGt0i13+45H2r+zA78movSJ
qusxzXpoZLhT0NikGkbvhho081ZDBAoeUT3YxgCEkJNKn39enLF7uCdO5c8JZ1QZ
Qf3lVPiiTARhemaXtNj5WlvJ2JbjsM4YEBLCDJrOiJw3ZGAkGDoiRCGcfFuiJ6Lg
k+1BCHRwsd/SwtgJttyxeGDGbBwY5GmaWLySp33uc5+1EH9IX5iQtn8z4BW+SGwM
lx7GZMCzum7h5h2cPgmPVZ0kO/NOtGuNgKkc04NIZ9AFZuMOSnw=
=Fc2b
-----END PGP SIGNATURE-----

--y0J7VvKM6hLIg08/--


From xen-devel-bounces@lists.xenproject.org Wed Feb 23 15:13:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 23 Feb 2022 15:13:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277413.473893 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMtKo-0001P3-4z; Wed, 23 Feb 2022 15:13:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277413.473893; Wed, 23 Feb 2022 15:13:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMtKo-0001Ow-1v; Wed, 23 Feb 2022 15:13:42 +0000
Received: by outflank-mailman (input) for mailman id 277413;
 Wed, 23 Feb 2022 15:13:41 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=DZ7u=TG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nMtKn-0001Oq-5h
 for xen-devel@lists.xenproject.org; Wed, 23 Feb 2022 15:13:41 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2e4e2295-94bb-11ec-8539-5f4723681683;
 Wed, 23 Feb 2022 16:13:40 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2177.outbound.protection.outlook.com [104.47.17.177]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-15-DBelr5nwOkSGbXflt4APhg-1; Wed, 23 Feb 2022 16:13:38 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4624.eurprd04.prod.outlook.com (2603:10a6:803:72::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.26; Wed, 23 Feb
 2022 15:13:37 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.022; Wed, 23 Feb 2022
 15:13:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2e4e2295-94bb-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645629219;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=DfA+KoDOZk7fiA1yr/ZaD1BDBKAQ3tEWWMbgEIRy8qw=;
	b=E0McH2BcnF/ICe2wMVlbe+wpPLe+vZr46n8RHrw9WfkPvv+kGGtyZS1bM4sf9tJ09qIRf3
	w3PIKujfivGVnbaOtXbxFRhv4UYhBUxnLMAHY878jt4VeKKKwZK2vA8PZS3gI6mOvKD+JF
	5G+nRpuYGRTeKNLhd/XpBraIUjIquRs=
X-MC-Unique: DBelr5nwOkSGbXflt4APhg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=WaFrPXEV8QwP/RKJa4xN4uiWyXchaobomLcYNjOAxmdw/uXIyy9zOhnnWdia7U0FRs94zrMxatLsDL6NKtPRMg59CV5Cg6EkVO1/v/7l9QT8T6fdOuQ5IhyyeZ5vR+kHrUsoy1SJEI4p4TWhSH3JoifWYeUoH28U1V4oHci97mHHNNbd5MV6AquDt3FF6i1piQIdmlxZVPAJ4gvJOLz/zgNjMj90N3L4n7dYEs9PqVgEN/zQRToOwmOonup8ycxa6H+V4Y6pJTlCQhZpiiLHLVKjeXAQbMexH97FTExwEb2rGwpMkgaFL/ISoz2ob1+FhN9p1BWoockzAtSOeaqQIQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=DfA+KoDOZk7fiA1yr/ZaD1BDBKAQ3tEWWMbgEIRy8qw=;
 b=lFLUVToitTjeianCoMI2CiZpdnpqP5r4TF7S6L9VNiaoi0Iy8x7UMz3Z6z1P+m/+jA+YSNHvTYOW3B7lvWhJywm67KHfI5pteaad/YicpiAH79Ttvm89ISZrl4rU0u+uXRqj7CPyDzmzLZAb4/inRzSZhn93XBFdSBbwleVj/wwTsMhvshrGg8Zw/qydO1jbr/8AXjzBqVgwjr93EPIfgBW6Z1U2i1NYGtWOWWhOmVEe7f9ef6cHtlQpwttl9+9B6Jv4PR8wCRjo8+WZZzBm8Os1rFgLI5eEwXzWlc4t/GyqnXPkbOxg5b4v0GStb/Am7ft1h40xaT98vaYOe0pwlQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <32526b73-25f7-e6b0-208b-669a7648ee44@suse.com>
Date: Wed, 23 Feb 2022 16:13:35 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Content-Language: en-US
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH 0/2] x86/p2m: type checking adjustments
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0190.eurprd04.prod.outlook.com
 (2603:10a6:20b:2f3::15) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f3d66da9-dd66-47bb-eb96-08d9f6df10a5
X-MS-TrafficTypeDiagnostic: VI1PR04MB4624:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB46245EE55ADF81F9683197EFB33C9@VI1PR04MB4624.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	F+u/irnt+CXc9cuNMQYEKaSZSyfVrR5GqtSrB3zVP4ATKtv2+te8X72Q/KajMhpj/zv67Inl5dr/g4WwTk/nItJDbL/zRxdz368Pb1WYMxSWU/qlVxr3oroS3d73LYpghdnXQ7n38DGAT6irESBaQJcZ0uqF+uIBdkdGOzwccK+My87nprg42ku2QgZ5RCZrMDtcGNo1IzreL2zg7PTmkiYVWyQ15ot7LezFQ3rxh9zv0bxqkvE7czkMIxiZikIAk61ToD3+i/BNURq4duftjUjKNjd83897eB4Nf/Ysxz3uxYaQmKw+fRH1z2U197sUjJ9aMNLjIv61MXVN5nHaccrzUWnMKx50z3c9vhzwHn1c2Rr+tpH5fU1GveIUceE8deM2KjkwPHf/ilqHEXH+F+jAASQU8OyiMNEH6smk30C8C3KRY0ABeAUfQPAjQpy57Z5b2uigi+ewZLJe4v8eOGFDVYBqO2e0RWQTU/8Qwx83IO0L+ogc4SPb9paq+goDGdLt0CKjrs7OLeWq+XaNLpFiEDbu34sAUE0DEd992ecS86cb96SIJ1MbcEg42XlLj9nDWdgv6hgGzrKHQMNo/XykjfzvCXq8NtVzbHedScvhXqP3S682t9jiIjWxJauk2O/bgxIDCcOA0s0KgR1EmhXSrNUE7KnR0/hO0fLBjClqVc3GcfwK65BBHsE528WFAk+MV51gKlJo1iLRO513WkKAXmgbx1enIBfXaWI1HSY=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(186003)(2616005)(38100700002)(26005)(86362001)(31696002)(54906003)(4744005)(5660300002)(8676002)(316002)(6916009)(66556008)(66476007)(66946007)(2906002)(4326008)(508600001)(31686004)(6486002)(36756003)(6506007)(6512007)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TGRaSW83ZHFKaXJzOTkrT3BlTWtob1pFQ3p4UDA1ditDKzdQYS9kN3F4NlI3?=
 =?utf-8?B?SUNoZjQxTHB3eHFyRVB4R3VFaGlGVDNVeWRMT2pTelZ3YUtsQzAyV0labUd6?=
 =?utf-8?B?V0dDWVJhcVV6UUt5RTdkOUlGUnkrQXNXTjBBdTRlb3dGN3Vud1dZL2M3U2JV?=
 =?utf-8?B?VTdmOG1Bcmd4TXZ1bmJTSGFLbDFkOW56N1ZMcXg0YXdMbXZKZWZVcHg1aUUv?=
 =?utf-8?B?ak9wMVAvYUZoUDBqbTdwZzE4RDJHblZ5cEtsZEdjOC96bjZBSTJkY0l2dG92?=
 =?utf-8?B?OUlmV2FMRTNYZms2Wis1a1NtZ25rT2ptUDEvclEydWxjYzVEK0tGNVFaQUtT?=
 =?utf-8?B?b0lhbzdXYlFmTFZGbFJ2N05neHgwMVlrS0x4RE5VL1NWYU9CR3doK1Y2VVdj?=
 =?utf-8?B?aitueVVGTy9hR21qVzE0ekFUU01FS1dTNElESDM3aG0yTllPa3EwMS92ZzMr?=
 =?utf-8?B?K0ZIMWszcndUOHZVcnNVU3lXZHgyeEEzUXkxQWh3eGNQenpHSTZVeVdBQmhD?=
 =?utf-8?B?VnZBQnhMd1R2VGJQZDlKYS9ZbjZRWFNybUEzcHZSRUJSVmh0TDU5K0VZc2U5?=
 =?utf-8?B?czZmU3pEV09mSldqeCsxTlo1MHpYa05QOHlld1hLL29jaEJER21zS0JhckRR?=
 =?utf-8?B?L1lRK3p4ZzJtbnExL0dpZjYzMDU4MUlFNEJpM0JRSkNYZmhLbEFNclpQNWZj?=
 =?utf-8?B?cTk4ODExWFhVY0pPY2dPcTBtdGxuVkpzd2hLQlJDYTF3aWlnTkNzNncxa3Vz?=
 =?utf-8?B?ZzV4NnUrTEFUVEZZeVQ0SFJwc2F1d3BsYStFb3BuR01SYXhOc1Z6Y2FZZ3A0?=
 =?utf-8?B?U3BCcnJsL2g5WGxkSDFmT3FEVS9nNW0wTmJPOXBncnBYNHdOcllJeXhJNVZM?=
 =?utf-8?B?bW1MSjNyRWxiVlZlWk9EK1ZwTTRYSG9xY09qRHhRQkxPb1NMWkYzbjR5V1cx?=
 =?utf-8?B?SHNyS1NTMEVnSmh0aHBHMUd1NHdhMTdVNVpUU1QxVTE4cVBjY0tIemNPY2pq?=
 =?utf-8?B?UHhjN0pUc2dXc0xnQkpCeTZNcWZtVUtsdmN4eUhYUWFtNG1JWDNUVUt3SER1?=
 =?utf-8?B?OGl3ODF6YkR5RnFpeFRLdGZXYVJ5S1hCZHZiQnRLRXRGdFRVMXo2OEdmNEE3?=
 =?utf-8?B?Y2xoSjI5eC80ZW90RFp4aW1TRFZkU1kwemd2MVdxblZmMlN1eVNKQkp3b1hC?=
 =?utf-8?B?d1UrZGpOSTJCd0pVYVh5c05MNnZjN2lxVXJrWVJsZ3djSWNtcGFpMHY1U0lw?=
 =?utf-8?B?RDA1RW0rN1JxOVhxbzlWMG1IaWZJRit2OTZ6bENOS2hKMmp1SENya3RzeDlW?=
 =?utf-8?B?VEZ0Ym4xMi9JOVhxaVFScW5teWxDOURqUzJnMjkvRG1naEJFcEY3SzFodTc4?=
 =?utf-8?B?NzlRaUpQTjkvd2tKcndYNWd5SW13NDg2S1h6VnNxOWYxUVNOUkhoeFhoTjZt?=
 =?utf-8?B?ZzFTZEhtZS83UU12R01aSktkNVY0b2ljalBBQjVFTm1rd3FGQ0cxUmpVZXFZ?=
 =?utf-8?B?SVJxZHVmakFhMWM3cTdpZHRLd0ozZFZHZTZmZ0lxS3EzSGQvdkNuYzFzNjZF?=
 =?utf-8?B?RDlJbXJSVElCWXBxMUVHcnRzUXBuRXRzVERHY1BtMGFuMlpJWks0eWlxbkFF?=
 =?utf-8?B?bzhIT1lIWk5rS3lCQVNmemF0RVNXcGxhWTJySGdaNk5MVmtRNXpZL2M0VzBV?=
 =?utf-8?B?WGU3MHFSTERoWlhYc2twamVpQVEwb0E2MDJ4bXRFTTdQRnVrQUJpdTRHQncx?=
 =?utf-8?B?bEh3eUZiZU9SOU5sZmJVRVJvblRxWDc0NHNHV3RXSWd0K2ZLUlhJRURXVmJ2?=
 =?utf-8?B?T2xwMWlKVG43UCs0bmxpNlA4MzhHaE9oZjNVcHNSbWlOVUw4dVcyQ2pkMFpE?=
 =?utf-8?B?NmI1MGFkY01ZMWJsLysvWjNETDJMaDgxeW9EdGFqWXhDaXVuRVJhcGVDaWo3?=
 =?utf-8?B?UXFRMEh6eTJaN0lsLzAwZ0laamh6TjJLdGdrblkyOUo5U25JVDUwbzdYN2dq?=
 =?utf-8?B?RWxNVW1sbkdUZjFSMzhDQWhuUGtRN3pyVXNaZWhueWx3Nk96YXQ4TGg2blFW?=
 =?utf-8?B?RmlrTjhDR3hwWFZFbmdROVZmeFh5WHltSCt4ZXkwSHRyQytQdUE2cjUxR2Nh?=
 =?utf-8?B?VGtJUVZwdHk1aWZjditqTVhXVjg2cldSOHIxcUREWkJPYnRrdnJzbElrTUJy?=
 =?utf-8?Q?Vy/ybRTd4v8d1wD1muzXkPI=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f3d66da9-dd66-47bb-eb96-08d9f6df10a5
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2022 15:13:36.8803
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ica0JdBLUobpD9wpLCD7RRaJrhZrakRQBYOD/h257dI57TxIQkTaY9y9fo9Ew5rc/NylQSa1ypCfBqV+0bRG1Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4624

While the first change is a bug fix (for, admittedly, a case which
apparently hasn't occurred in practice, or else we would have had
bug reports), it already puts in place an instance of what the 2nd
patch is proposing for perhaps wider use.

1: make p2m_get_page_from_gfn() handle grant and shared cases better
2: aid the compiler in folding p2m_is_...()

Jan



From xen-devel-bounces@lists.xenproject.org Wed Feb 23 15:15:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 23 Feb 2022 15:15:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277419.473905 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMtM6-0001zT-Go; Wed, 23 Feb 2022 15:15:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277419.473905; Wed, 23 Feb 2022 15:15:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMtM6-0001z4-Cp; Wed, 23 Feb 2022 15:15:02 +0000
Received: by outflank-mailman (input) for mailman id 277419;
 Wed, 23 Feb 2022 15:15:01 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=DZ7u=TG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nMtM5-0001xo-Gc
 for xen-devel@lists.xenproject.org; Wed, 23 Feb 2022 15:15:01 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5e46f61d-94bb-11ec-8eb8-a37418f5ba1a;
 Wed, 23 Feb 2022 16:15:00 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2174.outbound.protection.outlook.com [104.47.17.174]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-27-QyKErOFPMvuwCLrVRxdJrw-1; Wed, 23 Feb 2022 16:14:59 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4624.eurprd04.prod.outlook.com (2603:10a6:803:72::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.26; Wed, 23 Feb
 2022 15:14:57 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.022; Wed, 23 Feb 2022
 15:14:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5e46f61d-94bb-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645629300;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=st09De5AhrTxtdqW5QYgoa+DjF7F0kOPM0aXdyBYarM=;
	b=VhLilorMbEjZS+D/HH82XbAqqEHEm6pdaxtdFHnsK05Wx15gC8tFD8Gqyb8dL42l5/8CE+
	KMGWScs7HlZa1XUyxCBKdM6w+4yjSsVk1RpYkfGyqJa/LYQ/33r/lusJlJggfsqJmDfOrN
	V1wH1a6Elt0tHQ4KbSpx5j3C4j05Cbw=
X-MC-Unique: QyKErOFPMvuwCLrVRxdJrw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=JIfAxmIMAJeqOtVHyS5LYz9eBwzWXekExKRqJizoEc7CGUnEHjcFrbyBcmLf997yA1OiIQgayPxpAvMtx3fWFdLNge82iWHEL7+mWOa+JWU5tLGAEIxmKU9Y0EXqS5mmSBCjQIMymDhXBofTRUzZUb9dCnSfy6YCOEZFxenpnZpR/9WmtxjE4OhlgzAa9stVd/6qWCzIUqbtqDCbyGk9VreJqwLUB5+2QkpiLszL+j609ziZ1nYx9U2ywLMj6rEqAyGKcMMxdHh6QFb3DYyWbVMn8R0g67H11tN3GB1A80CmIm1xAQq/yV4oBKtlnQPy5x9jrONnBLq0GYzupT0sqQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=st09De5AhrTxtdqW5QYgoa+DjF7F0kOPM0aXdyBYarM=;
 b=HSj84r02CbY+xmuKm5mTllNjAIX1oF5YfGBA8oP6/ZSFRSmbT0Qk8NkfIGdYIpgRoa2kiNmNx4e1lAgeBwlJIDrjdnqVEhvM1Y4FIeDd9imkO9ztWpOdYnUvvm2vHf8FDZizdo9BeB5UpgqP3UZy74NNCWSU+sLwlE5lob0WXdNb5kmeQZlGKS4txWZrcUxFUYS6DdckVPAPoeMeAX4+qe0f/93m1DKMVr0lGBpumayoDUsKywY4C73jPCU9KpjsN0MgRRrMo+k8lM85pl/RB/PD7QPxpV4qI5KtIjBgBglJhLOg338xWgnHf+XDQAITROv6KtsxqUWA/PvHChGESQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <5a8c1f9e-e91a-a7f5-8c8a-025ab6a39908@suse.com>
Date: Wed, 23 Feb 2022 16:14:55 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: [PATCH 1/2] x86/p2m: make p2m_get_page_from_gfn() handle grant and
 shared cases better
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Tamas K Lengyel <tamas@tklengyel.com>
References: <32526b73-25f7-e6b0-208b-669a7648ee44@suse.com>
In-Reply-To: <32526b73-25f7-e6b0-208b-669a7648ee44@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR05CA0015.eurprd05.prod.outlook.com
 (2603:10a6:20b:311::20) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2f341c8c-ac06-4f8e-6496-08d9f6df40cb
X-MS-TrafficTypeDiagnostic: VI1PR04MB4624:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB4624166E13ED5046976D52DBB33C9@VI1PR04MB4624.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	LENeZugZTYcDC8iqmEYrWAdyiPRXg6/a4IwqZnesTjxQ1cJiEpFDvG7gTdsE+05hFmiYoyPB2qdye3gaNHzBaehykW5w9iR+JpbexDHwk7bASKXosjAOAeALzyY873Wwb8pOiWGQkQt8T/OAyF8hyeyFqLCclikb7Imqjp2iDy7GmYjIbjQrpKq5Gg8GHUpe3e2eUb0ixlRKGpB4a5XoDy5N1MbIjCyN5s5HMuwU9rx1rllW48XgYApbZ9s+JKSdoo0kEEyUlKlq71lQrCwXUekd4qh6SbgL3wQVHyo5ntJa812FPlM5fjt793q+kzAbTELwxRWdxhvRM/M9zQxMZaD81XwmCpV/YTAjwSlEMrfmKaAaSiirVVs9J6BIPOzeQUCdf8slVBtqhaF5OJRhrUA+gHjZiXtMc8atKSdjdLG9udeWoSa0U8FctzyaLHd8H6bAlla5Cvr/6Q3j5qsQvhAEV1NkAe5dpaQoi2jr7nSpj6eq7bWJuC3f3vKFOG3oBDCcYvEx0f5RXdzL6fjwnmuSQYPRcJdufJPAG57Kc5zooIPK/MiK3mjrQ7caaGck9Pw4kWuCmj+E9zhBE967N0rWY17HJDfxcEHINnb6Htu0Nmlrs41ZmabwlU8xqEmcwaWZZKTz0Q3d95Lhz+wzqxzuqEwqgG+ya7bqYk1kXEKul2kPr6pYPQwAyL2wpHmiqtH1TJhuj9u1GR12ro2E/VyQDD4ejiBdgNKpQdd4M2qaQZG7DOKvfXbwLWyYasyM
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(186003)(2616005)(38100700002)(26005)(86362001)(31696002)(83380400001)(54906003)(5660300002)(8676002)(316002)(6916009)(66556008)(66476007)(66946007)(2906002)(4326008)(508600001)(31686004)(6486002)(36756003)(6506007)(6512007)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UmNaYmdscHJmNzFnNkk5YlRVb0NOV253VklNTlRsaXIvMDR0YkRYZExCdkVU?=
 =?utf-8?B?dUVuWmU2RTl4ZmpBeHI4RTUvR1B2TXFRM1hjamlpWnlFOEtaNDB0WHFQQzhl?=
 =?utf-8?B?cDdPM3VDQlpLUUJrM3RoYk91VnFRazBFclBNNG5ITWhzWHg4azgxNGY0Mk0r?=
 =?utf-8?B?aGJFR2l3R1V0WWkvNmhqTW41MDZUdDNmQTNaVWtOZDBjUFdvRjF0bExJT0ta?=
 =?utf-8?B?eXlqWUdMdkIzbVV3aERGbGRSeS9RM0lKTXVYbkJtL3dRKzVZYmZjc0QySUlj?=
 =?utf-8?B?RmhJOTI5bDkrRkdxdmN6cFV1TTQ2YmNQQVFjYmIzNWJ5OE1pcHVKSWNrMTRz?=
 =?utf-8?B?aWYyZExRMm9rSmhwRGd2WUoxZWlKbHNvdVlYcENyOWRialp4cmZrVE1BaW41?=
 =?utf-8?B?VTlFbjRXTU9CS1JndVQ0V1A3ZnllejMvY2FvbkhKMm90SmxsaFpJN3N1K2RY?=
 =?utf-8?B?UnlCMnVFVWRaalMrVDYweGlQTVNIL2hIWk42aUF4R0tXNjJnSVpZSzZGZ2Ez?=
 =?utf-8?B?amx4dGdVUGpScmE2TCtNeXJoNm5vYXp5MEpGVEJGUFdvR2hqMTNpL2YvTDJF?=
 =?utf-8?B?YlNocVB3QXMzOHB3N0xZMElSZ0xQK01LTE5RRk5jeUVPaTMrdXpNNk9MajNG?=
 =?utf-8?B?a2p4Z3RLeG5rUmJIeGtjQUk5OGtRL3FpR3FSKy81NWt1RDEwcDRtckNmQWlO?=
 =?utf-8?B?SU10YW9oTU5PNEdIT292UDhCQXJqZTdzUXJ4NW1oMk9mZ0N3TWtWdS9QOGlS?=
 =?utf-8?B?U2dPYzlaSzN6R1QybWZybVJ0bElKUGZrNmgyNmNtUmQ2UXFZOVJCNnhRNW9j?=
 =?utf-8?B?b2I4WVpLWmhlWU1mTW95TXVqSnVTZlpBQ0hZempiem16T1ZJbFptcEU4YitK?=
 =?utf-8?B?NXZaOXlSLzBaVTE5b1c0WWVPQ3plQUNUS1NpZFd5UXJLc29oUDR5aytWdENW?=
 =?utf-8?B?TWdhRnI3ODl0L3FPcnRXbktkZlZ0OW5YWmVPc2JCd0xiZWlSZGhTZlBZdGdn?=
 =?utf-8?B?OEhPYkpTdmpJNXlST01QVG9iTERjSEZTTUVXZ2NGd1Fud2RHVzNVSkFvaWNF?=
 =?utf-8?B?aTN0dzR1aGt5UE9nWm1HVUYxRmdBU1lPT1Erd2tLMFk0OWF1b2VZeURIakZG?=
 =?utf-8?B?UTBmMFVpbXF6eW9jWFJKbjFJVDFXUGFIMnZPVHNHNnVNVkd2bFRYVEFDZWtI?=
 =?utf-8?B?WlhBTjZHdmhuL2hrRGNkOVgvSzR5L2sraHJod1BvSFY4N09ZZ2tDTDhEQVFB?=
 =?utf-8?B?c2t5S1V0d0V0SkFKOWRadXR3QkIveDdxQ1R2RWFQbmlBb1RLSFFFUCtMWkt2?=
 =?utf-8?B?dWxzWWFubnRpSDlxUVNrSkM3SllaK3ZjVk51SVRNQ3I5TlNuUFdXMlZrUHUy?=
 =?utf-8?B?YTZLQ2RNYVJscjNITG90a3cxNDYwdkQ5ZERmQU4vVXdoRkkxN24xWVJVckRv?=
 =?utf-8?B?NGVJRDY2VlpjbGZHd1VHdW1JNHlSMy8xRkI4c0hBNmxEMk1nY0dVbW1GR1Ay?=
 =?utf-8?B?TzZJeXJRRkljSjAvd0ppKzJOVHFSdkRUa1VCeGpzU2ZWMXdsbzVOTkJBV3Qv?=
 =?utf-8?B?djdOWm5EcDVSRGQ4djNlZ2JZcG9kYnBBQyt1NXY4L3cvYkVnOTlLMDdOTzhI?=
 =?utf-8?B?KzFBQ1U2WTkzMTA4RjNPVUdLc2RROUtiS1RiNU1Bd2RwQ2xidHk0Ly9mM21n?=
 =?utf-8?B?TGFQcnVwbzdKekRwSzVXUEx3ZHBQUlJaaVNYUmkzRTloUkNJcDA0cGlNV2ow?=
 =?utf-8?B?d2kwVGdycEVYdFRnaGpxTWVlQXVyMzZzZkRXbWVyMVViMVJVZmpWK1YvL2dN?=
 =?utf-8?B?d2JZckJUREV1UTZKc3F5MFpmQXhiaW1GQjV6VkpmcEV3YXliUHNPMjBxUDdO?=
 =?utf-8?B?bXRneEVjb1o3MTZUbHcrcFFDMDRVeDhDbm1BQWNHckkwdUZxSVZEZUNHU3hk?=
 =?utf-8?B?MFVmUzJvS2dMOFNuQmtWQmxyVkJjVzZNa3RINFVzaGRieHdZZmYvR0NRU0NR?=
 =?utf-8?B?NVhKNW1EaFkxb3Z1NnI1UXovZytSZ2JRNEthOFNva3E2ei91bWdidXNoby94?=
 =?utf-8?B?SHg1WUp0K2p0QmFkSVFHRUV1dk4xT0ZhWExwZUZUazlFcUdBWW5JM0xaM3g4?=
 =?utf-8?B?UDU3WUoxY2w0cjg1Y2w3dUN5N285d203SHV5ZzhLZVVZK2JQY2ZaYkNVQnh1?=
 =?utf-8?Q?vobZ6as4bEMPjhEBtUzxXs4=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2f341c8c-ac06-4f8e-6496-08d9f6df40cb
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2022 15:14:57.6097
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 22Upqrmy8rnUs+MW3vAIqtXHIZbXBNwnk3dZnYBHTi3OnGbmvxuj8ezLzNAYq9pde8ygFlfegoWh0WoSd8YhwA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4624

Grant P2M entries, which are covered by p2m_is_any_ram(), wouldn't pass
the get_page() unless the grant was a local one. These need to take the
same path as foreign entries. Just the assertion there is not valid for
local grants, and hence it triggering needs to be avoided.

Shared entries, when unshare is requested, would bypass the retrieval of
"page" and thus always take the error path rather than actually trying
to unshare by taking the slow path.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
Using | instead of || helps the compiler fold the two p2m_is_*().

--- a/xen/arch/x86/mm/p2m.c
+++ b/xen/arch/x86/mm/p2m.c
@@ -584,11 +584,11 @@ struct page_info *p2m_get_page_from_gfn(
              && !((q & P2M_UNSHARE) && p2m_is_shared(*t)) )
         {
             page = mfn_to_page(mfn);
-            if ( unlikely(p2m_is_foreign(*t)) )
+            if ( unlikely(p2m_is_foreign(*t) | p2m_is_grant(*t)) )
             {
                 struct domain *fdom = page_get_owner_and_reference(page);
 
-                ASSERT(fdom != p2m->domain);
+                ASSERT(!p2m_is_foreign(*t) || fdom != p2m->domain);
                 if ( fdom == NULL )
                     page = NULL;
             }
@@ -607,6 +607,7 @@ struct page_info *p2m_get_page_from_gfn(
 
         /* Error path: not a suitable GFN at all */
         if ( !p2m_is_ram(*t) && !p2m_is_paging(*t) && !p2m_is_pod(*t) &&
+             (!p2m_is_shared(*t) || !(q & P2M_UNSHARE)) &&
              !mem_sharing_is_fork(p2m->domain) )
             return NULL;
     }



From xen-devel-bounces@lists.xenproject.org Wed Feb 23 15:15:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 23 Feb 2022 15:15:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277425.473916 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMtMa-0002Y5-P6; Wed, 23 Feb 2022 15:15:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277425.473916; Wed, 23 Feb 2022 15:15:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMtMa-0002Xy-LU; Wed, 23 Feb 2022 15:15:32 +0000
Received: by outflank-mailman (input) for mailman id 277425;
 Wed, 23 Feb 2022 15:15:31 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=DZ7u=TG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nMtMZ-0001xo-KR
 for xen-devel@lists.xenproject.org; Wed, 23 Feb 2022 15:15:31 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 70639974-94bb-11ec-8eb8-a37418f5ba1a;
 Wed, 23 Feb 2022 16:15:30 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2169.outbound.protection.outlook.com [104.47.17.169]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-35-3dQJ3TB0NpCTqpojnSG21g-1; Wed, 23 Feb 2022 16:15:29 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4624.eurprd04.prod.outlook.com (2603:10a6:803:72::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.26; Wed, 23 Feb
 2022 15:15:28 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.022; Wed, 23 Feb 2022
 15:15:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 70639974-94bb-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645629330;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=juNOMnTTaHYlj1GzEVqLULFZt9qHfroO97X6sGnQeak=;
	b=JCjfno2Q+m+5NNs+lhBer8yZhmOZEY3ExCpzdNszbsS/bymiO+McQ6OqLDKzVp3OiV5XUP
	A3XT7ztvlU6zZgOUIP3ZFC+RXdfRFT6QBz9L2HK3t0yIA69Ru79YJD1IpbdFz4LfOtXMkh
	adHcSFyEEKh1JiE+XxSpscNHgesNPVU=
X-MC-Unique: 3dQJ3TB0NpCTqpojnSG21g-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=NIVaUBF7YAcQAIFyN3rLPE2mXM3gkyPE+WI3IlTzB+l04gNhbd5gU01PsYa6h8E3vX3KejMfjJYXVpRGJV+53AnSY7kb30O519xNGaOrZ74lNcVfwzd0LM2/eYi+tS4YFkjECk97U8zdbqP5KrgxFBzSeQf1IXdpWMPBnrmp0Jh2D7Jp9YBSAE8Jm8JiO4O/2WZm0393XMsNwWnFyQI+1SktvXYWPAUHOsHBqF3c+W78EvoKTjkp6+yboCK5xkKICquGcxI4/eUOufHvjjuWPOmcGno9DDONdSI6CeeUQT3YVHKjXDGZVZfWOiCOX0n2Cibm06u1/PBtkAe3Dfbv2g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=juNOMnTTaHYlj1GzEVqLULFZt9qHfroO97X6sGnQeak=;
 b=mxWQJaWfT87S89A/JU4FoATAQB2xWAqR2MWw0Hnf/n7XkdZq/pYMazFmxsvP6JVtb1Jyc2v2/Ye6O3mLqN9Mh2ADug4wnhb4Y5t9wdhOj074Xdj24mvd9bqZvMPDAk2cxn6RCF7twhFlvrzQHUSUpiahDaTAgU0tGQR/VMOUkE38Qd+ZABJf8dSd6d+avG5mdT7n1VHjWedp9CpnVYJNmBKSfi74BT5nVMEjOmUFVOP3KNrEfu6B/Az8SMk92IzpTfB6bBOPvTGiECPNaN9k9pjIw7qrg+xhhMIdefff7W+PlVkvblhM4RCcsxDRE4KMaDZAlP5T1JGoMhy5ag9Ydg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <0273a69d-0c51-cbd6-e5e9-da861d14cb06@suse.com>
Date: Wed, 23 Feb 2022 16:15:26 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: [PATCH RFC 2/2] x86/p2m: aid the compiler in folding p2m_is_...()
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>
References: <32526b73-25f7-e6b0-208b-669a7648ee44@suse.com>
In-Reply-To: <32526b73-25f7-e6b0-208b-669a7648ee44@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR05CA0022.eurprd05.prod.outlook.com
 (2603:10a6:20b:311::27) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ad62a710-c668-476e-dd3e-08d9f6df532f
X-MS-TrafficTypeDiagnostic: VI1PR04MB4624:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB4624E6889EA38BC6F527E679B33C9@VI1PR04MB4624.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	kWY5kXiURfwJAi82lGTxa33Zn33gFFmGWCyOLAb3Ve5hBgElGSVsSfxs/4I6HDvTOtjU3IfSa0vGNeh3cMP46V+bfbxuQyv6Gz7ZhY1KlAmokD2uaJPCvUXGEwrGf4dA+GLjTfkadvKGsOBSrd+Z+I+Kb3eYgqGOE3VNF+7h8K/3X1EahX6jC7in+TIi7BOZN6o8IgRphsX3/9PrCZorICq/HsDaME9cxsQYeC5dlq4sj5ID/iaBKm81lgB8gF5IBEUwGTJFzsnMO/dfGxEZpto30cNppaohOc5AAZDNTTbFRpU+YE3WUprVxzd0SQDFfEyeH3u4vuOXpCvlfw5H5PZyc8v7iOUEIVdAs0HKx4kVziGD0Q4W5npW9yCJ9PwFd4Jj6xfRS4YfshHYZN3Fd24ILCJ0u+l7vjZvwO339OMT9+BxS/zx8b35q+dF6JS3jWbgE3a0Bopop7oPnhverTAfXMDUz+MlYiLXOzhKDrmGeRceNDucFOgS552IgtKwESRgEict4jWoKIGvu0M7rMhFpz0QhXNcw8VX38ITTohS0St3cE7wtpr7ahtr1PxG0MSjn5Cs3nK+63leENK27uBoQ2hj5CStM/o3OMCdcgOchRyaIUrC9EPn9W2t/NvX4KcNIoiMVQdHz0kjB1RvAMW+IkgDNUra0vvqgNMYWBMInbb2+mbwIoViZ7ZPJqc6DQEKO7f7XC6fe1WvI0LDSOXJCj8aVar3d1J/2//fogI=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(186003)(2616005)(38100700002)(26005)(86362001)(31696002)(83380400001)(54906003)(5660300002)(8676002)(316002)(6916009)(66556008)(66476007)(66946007)(2906002)(4326008)(508600001)(31686004)(6486002)(36756003)(6506007)(6512007)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VDRtYXIxeVlTYVd0bmxmcHhIQUNwU0p0NW1meE5WeWNtU29EVWZQb2p2VXBv?=
 =?utf-8?B?OXRoQ0ZoOWN2UXdDeGJaNXBqUndDeXB6ZGhCMENTVWdkYzFLTjZEbm1tOUov?=
 =?utf-8?B?TUl3T3Q2Q0ZQWU95R0JaTUxBL0pjQmhQT3V6K2lFZ2NnajJVczI4amd2T0xD?=
 =?utf-8?B?M1loVUtacEJWWW5DU3E3Z0gxRzBjRVgwRXFFQ0l4a1ZqZmY4SnB1VVRjNDFU?=
 =?utf-8?B?WThsdXJraEQ1ZVJBYmdmWXhCdUkwaVcxRGU2bDA1K2dKanlDdkFPTjhqWTlY?=
 =?utf-8?B?am1ZdS9kK2d3cmR5TnVuZXR6WjdzcWwycmprN2x0emdXN1dhVUpUa1J5ZEpW?=
 =?utf-8?B?MUUyV0RMN2NVV2k5d1hGZGxBNFNKQzdjaloyZXJqdVlzaTlTK280UkhPdjQz?=
 =?utf-8?B?MXZXMG9iMTJYTStBS2tHVHJIdVpTY2R2VU13QlE2Y1lKUlFjSyszZ2VWc2h0?=
 =?utf-8?B?QnowSWdibjc5SEQ1dml5OXp3aDJtUlZCZFAxWG1wbFN2R0JjUVdFUGZVbzVh?=
 =?utf-8?B?NCtmci93eGkrR2JlR1JCNjhjM0g1Q3lCZUY4bkJRQTVyRnNXbTF1VWU3SnpM?=
 =?utf-8?B?a052N3BEMGNPV2xHNEtQL3dRTDFOVjU3bVdBRFVXV09ZL2lMZUY1NElXbGlt?=
 =?utf-8?B?MlJXOElvSlZzVVd5d0trNS9tdXM0Sm4vQ1dsYlhuNng0RW5KUUsvWUphc20y?=
 =?utf-8?B?MnVZc1EzUklTNk9iMVhndDdSWWh0TTBHS0o0WWxhcmJzbi8vczM0VXk2eDBM?=
 =?utf-8?B?TlZvUWZONk5mbnFzM1dtM2NwSXljcUp2UEJFQ0czNTIwN2N4SVNFTkR3ZVV4?=
 =?utf-8?B?NEJHZm5rSGQxU25pMGNoZWx1a200NWRvelhrWE9JajB6cGt3VVlHcjZyTXMx?=
 =?utf-8?B?WDRGVHo3RWFibG1FbGxUa0c4Z2VSSWpKaWxFWFpsWGZpNEhYUGFWczdNaXlO?=
 =?utf-8?B?MEorUFRJaXZ3dEMydFpIUWFCK3FJbG5ucmFOMkZtYW8rNkZsYTVPcnFYMjNO?=
 =?utf-8?B?L20veEFQMTlTZnBISy9WWVliK0lDU1dPYlAzY3U5NVhXbFdzMkZkR2Z0Mm9D?=
 =?utf-8?B?cnZWREJQMzdpaUVUak9IR3VXQk9FMGpCNm5aU0FqcnRrc2drY3VzZHdkUUR1?=
 =?utf-8?B?SDFBOE84UVlnaVducHdNdmVnV1VRdjIzQlR3ZGFpT0wxOHJGcnM2dWpYL2Zy?=
 =?utf-8?B?a1dCTXA0SEs4UWRXcEZZZk1LaGN3ZzlYQ2dXMGdDQWJnZ2ROUTduWml2Tmdz?=
 =?utf-8?B?UnJZQkN3c011aXkvNWVWcTh6ekZIQ05UeTdNNkxvQm5uSXNSZHhpNHUyc21q?=
 =?utf-8?B?SnBOeEpadDJFMWZDNUl0SlhIbVNyWWp1OFFaWlVwc0JBQ1F0cU1qUzU2MlNO?=
 =?utf-8?B?SEd4SlNZcTJ0QmJyWWx3c0RTZGhFcXZ0VzFVV21ra2NENFU2bHJLWXUwWExI?=
 =?utf-8?B?enBKZVNETzlKTVlCYkd5N0t3OXFUVHhFQ0tNMmtJcDVzVmZ0MmJ6ZmZ2WFd1?=
 =?utf-8?B?S1k4cjJiZFZLOUNwNUYwemVqZXkzaFJ4TDdBZlhUK2dxSGhScGxQYllZS0JJ?=
 =?utf-8?B?V04xckQ2QUwxaW4xRFVvRzFQUTZXclVoSmFXNk4xQ1dsYW0rZmVzMi9xQ0No?=
 =?utf-8?B?Mkt6aTVLeit1bUl3ek01NXJ3WnlXdndsZGtVYzJkRWtqMytkbmZmdEtnRW41?=
 =?utf-8?B?d0d3S2h5NzlYL1l3NXFlZFpnemM2UnJFdTRFSWxQVWxudm9IWnhpTTZ1eHl4?=
 =?utf-8?B?Qml3TzZBeDhOamtzVzgyTlBSZTNpdnF0V2ZTSHZLTmxDYW50TDIreDh2Nzgv?=
 =?utf-8?B?MWZjeDIrbENOQzI3dW9oK21DUHc5QnYyUjBQRW53alZ5amJ2YUdkTFBiaksx?=
 =?utf-8?B?Zzl6ckduZCtjQnUvUGdEVjVMWWx4T3NsYXplTURlK2dweUpVVUJRbGtWNnZN?=
 =?utf-8?B?N1FEbCtudDBxbGZPVFlINjJzQ1J3NmpxWUI0a3M0Tmo1cnByMHM4L2o3V0Rn?=
 =?utf-8?B?R2R3UXR2ek9ESG93VkpoYUVSbnZUR2h0SzN5bGQ4dFJjT0ltWWZMYllXelZJ?=
 =?utf-8?B?M3d4cUpBQ0t6dFFKem5rUUlqV3NTUFZJbU12c3JnZUFZNVdPY2k2TFJ6TCtX?=
 =?utf-8?B?N3JjVGtrTzdNVHJpanBEcU1CSVMzdWp2M3d6WEt1b0V6VEV3SDlrenQ3Z3Rt?=
 =?utf-8?Q?yArU86idvDzFyJAmjhvFw54=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ad62a710-c668-476e-dd3e-08d9f6df532f
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2022 15:15:28.4515
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aIiUXxWVjq+7PVi8HpT6nMDjEC+LT5wTt74BTQOEFnkPQUVSA1g5lQThNJEPHoK25i31uOnEfIZJCAnjyYw8Ew==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4624

By using | instead of || or (in the negated form) && chances increase
for the compiler to recognize that both predicates can actually be
folded into an expression requiring just a single branch (via OR-ing
together the respective P2M_*_TYPES constants).

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
RFC: The 3-way checks look to be a general problem for gcc, but even in
     some 2-way cases it doesn't manage to fold the expressions. Hence
     it's worth considering to go farther with this transformation, as
     long as the idea isn't disliked in general.

--- a/xen/arch/x86/mm/p2m.c
+++ b/xen/arch/x86/mm/p2m.c
@@ -606,7 +606,7 @@ struct page_info *p2m_get_page_from_gfn(
             return page;
 
         /* Error path: not a suitable GFN at all */
-        if ( !p2m_is_ram(*t) && !p2m_is_paging(*t) && !p2m_is_pod(*t) &&
+        if ( !(p2m_is_ram(*t) | p2m_is_paging(*t) | p2m_is_pod(*t)) &&
              (!p2m_is_shared(*t) || !(q & P2M_UNSHARE)) &&
              !mem_sharing_is_fork(p2m->domain) )
             return NULL;
@@ -840,7 +840,7 @@ p2m_remove_page(struct p2m_domain *p2m,
     for ( i = 0; i < (1UL << page_order); ++i )
     {
         p2m->get_entry(p2m, gfn_add(gfn, i), &t, &a, 0, NULL, NULL);
-        if ( !p2m_is_hole(t) && !p2m_is_special(t) && !p2m_is_shared(t) )
+        if ( !(p2m_is_hole(t) | p2m_is_special(t) | p2m_is_shared(t)) )
         {
             set_gpfn_from_mfn(mfn_x(mfn) + i, gfn_x(gfn) + i);
             paging_mark_pfn_dirty(p2m->domain, _pfn(gfn_x(gfn) + i));



From xen-devel-bounces@lists.xenproject.org Wed Feb 23 15:39:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 23 Feb 2022 15:39:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277436.473927 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMtjL-00055c-Ri; Wed, 23 Feb 2022 15:39:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277436.473927; Wed, 23 Feb 2022 15:39:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMtjL-00055V-OM; Wed, 23 Feb 2022 15:39:03 +0000
Received: by outflank-mailman (input) for mailman id 277436;
 Wed, 23 Feb 2022 15:39:02 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qKPW=TG=gmail.com=this.is.a0lson@srs-se1.protection.inumbo.net>)
 id 1nMtjJ-00055L-W7
 for xen-devel@lists.xenproject.org; Wed, 23 Feb 2022 15:39:02 +0000
Received: from mail-qv1-xf35.google.com (mail-qv1-xf35.google.com
 [2607:f8b0:4864:20::f35])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b7a8b0b7-94be-11ec-8539-5f4723681683;
 Wed, 23 Feb 2022 16:38:59 +0100 (CET)
Received: by mail-qv1-xf35.google.com with SMTP id fc19so8898112qvb.7
 for <xen-devel@lists.xenproject.org>; Wed, 23 Feb 2022 07:38:59 -0800 (PST)
Received: from development (c-73-166-253-254.hsd1.tx.comcast.net.
 [73.166.253.254])
 by smtp.gmail.com with ESMTPSA id 69sm549784qkd.91.2022.02.23.07.38.57
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 23 Feb 2022 07:38:57 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b7a8b0b7-94be-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=message-id:subject:from:to:date:in-reply-to:references:user-agent
         :mime-version:content-transfer-encoding;
        bh=UrgR76SYCaiOabtaLMgHsrffACqxzmT9Cz1A/iSOws4=;
        b=NqPNRTaESp+kt20APAkd1YiBzthR7DTT5aUkuYgY/UsS8l8loKsgQvDNPGFex15QCG
         ChQsLJbkR0nIoVwhvkvrhG0AU+IebID2MKUSt3heoE5Rtgk8051jqMT9TfDI5sgvj6EJ
         tQu5BJO/J4dGTv9Lw96ybfaDi/yxjYxK31AZPMTw1PZWd+zgL/XB3lfR6boXoY/zQEI2
         Irx4nGXOAMf1kmfapHC253NNolB2gmnvHzMg9bIyiNIYfan3u7iUyEXKMONpHV2SIg5L
         t6yqRst5Egbzfqdyi3t6W+byS8ce/96Czk6h12YiEJta+AQNHS4Vg6HqHMM3Etxxz8Eb
         9tvA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to
         :references:user-agent:mime-version:content-transfer-encoding;
        bh=UrgR76SYCaiOabtaLMgHsrffACqxzmT9Cz1A/iSOws4=;
        b=W4jzYCX3N0KDnBMknfMGxlTm0tEZC19+VWGVnJ6wZhEmsZ0xUPcsJkHa6cBQwTP4mE
         3FH9mFh6yEBK6hsnEvGN4ZgafqZ0DOqfhR0Vb9T8D1gTa2wsyIKCIKv4A/hYWIVzvaFm
         JMCvNmRiXuXpHtR1MGEM6MOJdl3F48Rct9eTGaMA40JRXlL7y1ilUi7Qw2Dr/RsGXu3E
         hBOPb3ScxCIi+lvhdPLZEWH1epeTKnC7TPakOtZzEx2QoG1mZtfnY11+HKg6RoEpsyHQ
         GcMlWx4QkLzc0AkVp7Jsu6i1LtBSWeIEPiVdtRrQAphXvk/rxrxyb5bN/4Jyl3Z6V3Ra
         gPHw==
X-Gm-Message-State: AOAM5331jq0LWixq1OPkfnZl4+Xub0n939W4U9LABX5odOqwd0pInD29
	5xp1mwa1fwOXx6ogQvq5nWU=
X-Google-Smtp-Source: ABdhPJy4h6ut5/pesPAU0gGiA3QyeE5sDpE4nuMu3vn4F5jmMm0MHOUSxsXRH2fpUIRFltanNt8vCA==
X-Received: by 2002:ac8:5853:0:b0:2d6:8a16:753c with SMTP id h19-20020ac85853000000b002d68a16753cmr235274qth.401.1645630738212;
        Wed, 23 Feb 2022 07:38:58 -0800 (PST)
Message-ID: <d11e54d47776008c17762458e6abbd44ab0beed5.camel@gmail.com>
Subject: Re: [RFC] Avoid dom0/HVM performance penalty from MSR access
 tightening
From: Alex Olson <this.is.a0lson@gmail.com>
To: Andrew Cooper <Andrew.Cooper3@citrix.com>, 
	"xen-devel@lists.xenproject.org"
	 <xen-devel@lists.xenproject.org>
Date: Wed, 23 Feb 2022 09:38:56 -0600
In-Reply-To: <a1099ae9-9e0d-cf54-e786-835c13f2ba40@citrix.com>
References: <949b4776e23e4607776685a7e2705b9e77f5b717.camel@gmail.com>
	 <a1099ae9-9e0d-cf54-e786-835c13f2ba40@citrix.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.36.5-0ubuntu1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit

I appreciate your interest, apologies for not replying right away. I've been
digging deeper to have a more meaningful resposne.

I had attempted to instrument the MSR reads, but only saw a small number reads
being blocked by the code change. They appear to be the list below and the
others seem fairly harmless:

0x00000034	MSR_SMI_COUNT
0x0000019a	IA32_CLOCK_MODULATION/MSR_IA32_THERM_CONTROL MSR
0x000003f8	MSR_PKG_C3_RESIDENCY
0x000003f9	MSR_PKG_C6_RESIDENCY
0x000003fa	MSR_PKG_C7_RESIDENCY
0x00000606	MSR_RAPL_POWER_UNIT
0x0000060d	MSR_PKG_C2_RESIDENCY
0x00000611	MSR_PKG_ENERGY_STATUS
0x00000619	MSR_DRAM_ENERGY_STATUS
0x00000630	MSR_PKG_C8_RESIDENCY
0x00000631	MSR_PKG_C9_RESIDENCY
0x00000632	MSR_PKG_C10_RESIDENCY
0x00000639	MSR_PP0_ENERGY_STATUS
0x00000641	MSR_PP1_ENERGY_STATUS

As for my test program, it is just a crude loop compiled with "gcc -O3",
normally takes about 10 seconds to execute:
int main()
{
    for (volatile int i=1; i!=0; ++i){}
    return 0;
}

The relative changes in execution time of the test program and also that  HVM
guest startup time (associated with the "qemu" process being busy) completely
agreed.  I also observed the same changes under a PVH guest for the test
program.

Thus, it seemed like the CPU was somehow operating a different frequency than
expected, rather than faults consuming execution time.

-- (after a lot more investigation) --

Further instrumentation showed that the
IA32_CLOCK_MODULATION/MSR_IA32_THERM_CONTROL MSR initially had value
"0x10"  which appears to be invalid both in the Intel Software Developer's
manual and what I think I'm seeing in the ACPI tables.

In dom0 Linux 5.2.38,  this value seems to have caused the
acpi_processor_get_throttling_ptc() function to see an invalid result from
acpi_get_throttling_state() and thus execute __acpi_processor_set_throttling()
which wrote the MSR with a value of zero and had the side effect of disabling
throttling (restoring normal performance).  (This all happened as the CPUs were
detected).

When the unknown MSR reads are blocked, the call to
__acpi_processor_set_throttling() did not occur since the MSR read did not
result in the invalid value -- thus the CPU remained in a throttling state.

So far, this seems to explain the dom0 performance issues I saw.

The domU observation was related... In some of my testing, dom0 was limited (via
Xen command-line) to a small number of cores so that the others could be
dedicated to other domains.  When a domU VM was launched on the others (not used
by dom0), its MSR remained at the original value resulting in low performance
since dom0 hadn't a chance to rewrite it...   Thus, I saw different domU
behavior based on the number of cores allocated to dom0.


-- summary --

In desparation, I ended up resetting BIOS settings to defaults and mysteriously
this issue doesn't occur anymore.  Not sure what could have gone wrong before as
the original settings were not far from defaults.  It seems my issues stemmed
from the server's BIOS setting the throttling MSR to an invalid value but it had
illuminated some unusual behaviors under Xen...

It seems to me there are a few findings useful to the Xen developers from
venturing down this rabbithole:

1) For conditions in which MSR registers are writeable from PV guests (such as
dom0),  they should probably be readable well, looks like MSR_IA32_THERM_CONTROL
is currently one of a small number of "unreadable" but writeable
MSRs.  Otherwise seemingly valid read-(check/modify)-write operations will
behave incorrectly under Xen.

2) As Xen controls CPU frequency and c-states,  might there be benefit to it
being extended to manage Clock Modulation / Throttling? (I wasn't expecting dom0
to be able to influence this!)

3) Perhaps PV domains (such as dom0) should not be allowed to modify such MSRs
at all since it would result in unintended effects depending on how CPU pools
and dom0 are managed?

Regards,

-Alex



On Thu, 2022-02-10 at 18:27 +0000, Andrew Cooper wrote:
> On 10/02/2022 17:27, Alex Olson wrote:
> > I'm seeing strange performance issues under Xen on a Supermicro server with
> > a Xeon D-1541 CPU caused by an MSR-related commit.
> > 
> > Commit 322ec7c89f6640ee2a99d1040b6f786cf04872cf 'x86/pv: disallow access to
> > unknown MSRs'
> > surprisingly introduces a severe performance penality where dom0 has about
> > 1/8th
> > the normal CPU performance. Even even when 'xenpm' is used to select the
> > performance governor and operate the CPU at maximum frequency, actual CPU
> > performance is still 1/2 of normal (as well as using
> > "cpufreq=xen,performance").
> > 
> > The patch below fixes it but I don't fully understand why.
> > 
> > Basically, when *reads* of MSR_IA32_THERM_CONTROL are blocked, dom0 and
> > guests (pinned to other CPUs) see the performance issues.
> > 
> > For benchmarking purposes, I built a small C program that runs a "for
> > loop" 
> > 4Billion iterations and timed its execution. In dom0, the
> > performance issues
> > also cause HVM guest startup time to go from 9-10
> > seconds to almost 80 seconds.
> > 
> > I assumed Xen was managing CPU frequency and thus blocking related MSR
> > access by dom0 (or any other domain). However,  clearly something else
> > is happening and I don't understand why.
> > 
> > I initially attempted to copy the same logic as the write MSR case. This
> > was effective at fixing the dom0 performance issue, but still left other
> > domains running at 1/2 speed. Hence, the change below has no access control.
> > 
> > 
> > If anyone has any insight as to what is really happening, I would be all
> > ears
> > as I am unsure if the change below is a proper solution.
> 
> Well that's especially entertaining...
> 
> So your patch edits pv/emul-priv-op.c#read_msr(), so is only changing
> the behaviour for PV dom0.
> 
> What exactly is your small C program doing?
> 
> 
> The change that that patch made was to turn a read which previously
> succeeded into a #GP fault.
> 
> The read has already been bogus, even if they appeared to work before. 
> When dom0 is scheduled around, it no longer knows which MSR it is
> actually reading, so at the best, the data being read is racy as to
> which CPU you're instantaneously scheduled on.
> 
> 
> At a guess, something in Linux is doing something especially dumb when
> given #GP and is falling into a tight loop of trying to read the MSR. 
> Do you happen to know which of those two is the more dominating factor?
> 
> ~Andrew





From xen-devel-bounces@lists.xenproject.org Wed Feb 23 15:44:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 23 Feb 2022 15:44:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277443.473938 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMtoM-0006T9-FH; Wed, 23 Feb 2022 15:44:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277443.473938; Wed, 23 Feb 2022 15:44:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMtoM-0006T2-Bf; Wed, 23 Feb 2022 15:44:14 +0000
Received: by outflank-mailman (input) for mailman id 277443;
 Wed, 23 Feb 2022 15:44:13 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qKPW=TG=gmail.com=this.is.a0lson@srs-se1.protection.inumbo.net>)
 id 1nMtoL-0006Sw-Gm
 for xen-devel@lists.xenproject.org; Wed, 23 Feb 2022 15:44:13 +0000
Received: from mail-qk1-x736.google.com (mail-qk1-x736.google.com
 [2607:f8b0:4864:20::736])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 71fb25f3-94bf-11ec-8539-5f4723681683;
 Wed, 23 Feb 2022 16:44:12 +0100 (CET)
Received: by mail-qk1-x736.google.com with SMTP id c7so4676218qka.7
 for <xen-devel@lists.xenproject.org>; Wed, 23 Feb 2022 07:44:12 -0800 (PST)
Received: from development (c-73-166-253-254.hsd1.tx.comcast.net.
 [73.166.253.254])
 by smtp.gmail.com with ESMTPSA id w4sm1967338qko.123.2022.02.23.07.44.10
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 23 Feb 2022 07:44:10 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 71fb25f3-94bf-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=message-id:subject:from:to:cc:date:in-reply-to:references
         :user-agent:mime-version:content-transfer-encoding;
        bh=qPOo47PyG8X2d4eUbL3FNOFSsot7fkINAnAp6Uq4U1A=;
        b=PviQguxOcYzUm+3Mvg2QHe2aHw7ClrLL/dIOj0XHD4eTl43eHIicNUew2wMhy6pttQ
         clvUgWz8U43gKZuI+ky6cMOPge6RNIpUoVyK0JYyGzK7KTFmK65v99TfbBwnEJr29aPt
         1Li8dtxR9xqqGcN/FHzGYY7cCnL7+B8/vxLR8ZFXK0ExXtPuM5fJXSTIL4cnMPlhxVhu
         9qTXfJs7EzmEERlSf/otFjAO4gR4/sO6fTShsLH6CK6aOm/PQqTH3fNgxYJyZ3+TVZzf
         B7aSJ/fus01fOzcTGvfVDmOlRcukwbv7qALchWHFnXoRVw+UFTX9iXQEPS7ktAt9Sag1
         SNeQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to
         :references:user-agent:mime-version:content-transfer-encoding;
        bh=qPOo47PyG8X2d4eUbL3FNOFSsot7fkINAnAp6Uq4U1A=;
        b=gZ7P/gDaAUPwSrFR8K3b3f4qErnfsiDUEZMfIYgeu4uDcjdt36AmVNvf6wkjY8yMDf
         PMhUEt+YMhgvO768YRhW5555H2DyhsWIwb56XIHpHPCCCADxJKz+5GIUYb0Ft5W4DYgq
         IAnZ6Dl7vCGMyBY0JDIyKKbRePveSYlFinELJF4wa1YdqgibgGFIQrPaE7la2TU5ZkL3
         CxgSHAc1330gysTUqVvkby0hOAyIhgDXFq9CM+wW7BWS2XMNr2QY+WUQQsV9evgObFBi
         QAOV9x8CxDXV+QAIWDu4pIIGb83dxEFn7Lc5y5mkKjiMikKygqeQ2BtHxsHxnmWRgK7M
         rkAQ==
X-Gm-Message-State: AOAM533ibm/iq5mebtGridRV9nOomUDdZYGKnX1iEQPnU3S4/4tgDBWh
	lq2kY1nvM/X3sEJSOs+QFst4UuCIHELrgQ==
X-Google-Smtp-Source: ABdhPJydNPy9+Juy42iIpE056BYTtL2Wd+D6Ef3AkK1Ye5BwT1EQFmZnR59VD4wxrselnJWjC+beGA==
X-Received: by 2002:a37:bd81:0:b0:47d:7533:1578 with SMTP id n123-20020a37bd81000000b0047d75331578mr150092qkf.732.1645631050901;
        Wed, 23 Feb 2022 07:44:10 -0800 (PST)
Message-ID: <c33c785601ad03e3fd02b3cb792f2333d46441c9.camel@gmail.com>
Subject: Re: [RFC] Avoid dom0/HVM performance penalty from MSR access
 tightening
From: Alex Olson <this.is.a0lson@gmail.com>
To: Roger Pau =?ISO-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>
Cc: xen-devel@lists.xenproject.org
Date: Wed, 23 Feb 2022 09:44:09 -0600
In-Reply-To: <YgYeHSm1RO03yy/t@Air-de-Roger>
References: <949b4776e23e4607776685a7e2705b9e77f5b717.camel@gmail.com>
	 <YgYeHSm1RO03yy/t@Air-de-Roger>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.36.5-0ubuntu1 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Hi Roger,

See my other reply which is more detailed.  While enabling reads of
"MSR_IA32_ENERGY_PERF_BIAS" did not cause any effect in my case, it is one of a
handful of exceptions in which MSRs are writeable but not readable. I believe
this may result in potentially unexpected behavior in  read-check/modify-write
cases.

As such, I now see that my original patch of making these MSRs globally readable
is too lenient and the conditions should likely be restricted to the same as
those in which writes are allowed.

In my particular case, it looks like all my troubles resulted from the BIOS
setting MSR_IA32_THERM_CONTROL to an invalid value and the recent code change
prevented dom0 from seeing (and correcting) it...

Regards,

-Alex


On Fri, 2022-02-11 at 09:28 +0100, Roger Pau Monné wrote:
> On Thu, Feb 10, 2022 at 11:27:15AM -0600, Alex Olson wrote:
> > I'm seeing strange performance issues under Xen on a Supermicro server with
> > a Xeon D-1541 CPU caused by an MSR-related commit.
> > 
> > Commit 322ec7c89f6640ee2a99d1040b6f786cf04872cf 'x86/pv: disallow access to
> > unknown MSRs'
> > surprisingly introduces a severe performance penality where dom0 has about
> > 1/8th
> > the normal CPU performance. Even even when 'xenpm' is used to select the
> > performance governor and operate the CPU at maximum frequency, actual CPU
> > performance is still 1/2 of normal (as well as using
> > "cpufreq=xen,performance").
> > 
> > The patch below fixes it but I don't fully understand why.
> > 
> > Basically, when *reads* of MSR_IA32_THERM_CONTROL are blocked, dom0 and
> > guests (pinned to other CPUs) see the performance issues.
> 
> You only mention MSR_IA32_THERM_CONTROL here...
> 
> > For benchmarking purposes, I built a small C program that runs a "for
> > loop" 
> > 4Billion iterations and timed its execution. In dom0, the
> > performance issues
> > also cause HVM guest startup time to go from 9-10
> > seconds to almost 80 seconds.
> > 
> > I assumed Xen was managing CPU frequency and thus blocking related MSR
> > access by dom0 (or any other domain). However,  clearly something else
> > is happening and I don't understand why.
> > 
> > I initially attempted to copy the same logic as the write MSR case. This
> > was effective at fixing the dom0 performance issue, but still left other
> > domains running at 1/2 speed. Hence, the change below has no access control.
> > 
> > 
> > If anyone has any insight as to what is really happening, I would be all
> > ears
> > as I am unsure if the change below is a proper solution.
> > 
> > Thanks
> > 
> > -Alex
> > 
> > ---
> > ---
> >  xen/arch/x86/pv/emul-priv-op.c | 12 ++++++++++++
> >  1 file changed, 12 insertions(+)
> > 
> > diff --git a/xen/arch/x86/pv/emul-priv-op.c b/xen/arch/x86/pv/emul-priv-op.c
> > index 7f4279a051..f254479bda 100644
> > --- a/xen/arch/x86/pv/emul-priv-op.c
> > +++ b/xen/arch/x86/pv/emul-priv-op.c
> > @@ -970,6 +970,18 @@ static int read_msr(unsigned int reg, uint64_t *val,
> >          *val = 0;
> >          return X86EMUL_OKAY;
> >  
> > +    /* being unable to read MSR_IA32_THERM_CONTROL seems to significantly
> > affect
> > +     * dom0 and thus HVM guest startup performance, as well as PVH VMs.
> > +     */
> > +    case MSR_IA32_THERM_CONTROL:
> > +    case MSR_IA32_ENERGY_PERF_BIAS:
> 
> ...yet in the patch you also allow access to
> MSR_IA32_ENERGY_PERF_BIAS, which makes me wonder whether
> MSR_IA32_THERM_CONTROL is the only required one.
> 
> It could help to post full logs Xen + Linux dmesgs.
> 
> Is this reproducible with different Linux versions?
> 
> Thanks, Roger.



From xen-devel-bounces@lists.xenproject.org Wed Feb 23 15:55:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 23 Feb 2022 15:55:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277450.473948 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMtz8-0007xa-GJ; Wed, 23 Feb 2022 15:55:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277450.473948; Wed, 23 Feb 2022 15:55:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMtz8-0007xT-DF; Wed, 23 Feb 2022 15:55:22 +0000
Received: by outflank-mailman (input) for mailman id 277450;
 Wed, 23 Feb 2022 15:55:21 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=DZ7u=TG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nMtz7-0007xN-9o
 for xen-devel@lists.xenproject.org; Wed, 23 Feb 2022 15:55:21 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0053ff81-94c1-11ec-8539-5f4723681683;
 Wed, 23 Feb 2022 16:55:20 +0100 (CET)
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2056.outbound.protection.outlook.com [104.47.2.56]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-38-I3TMdkYmPgaJYTFoRZcTFg-1; Wed, 23 Feb 2022 16:55:18 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DB3PR0402MB3770.eurprd04.prod.outlook.com (2603:10a6:8:12::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.28; Wed, 23 Feb
 2022 15:55:17 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.022; Wed, 23 Feb 2022
 15:55:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0053ff81-94c1-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645631719;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=g+BTFWIs5BREDQuHeksaFpukJARFbQB7XnYaw9EUK8g=;
	b=Z1NmeTU+hhzTQK//6FPHSy6ERg1XhNjxOH2dsjeRKPeOh+2zpEFO8upMoLfOthN/bGSG/c
	q+qeRxzoOPwGysKhWwyALc37NV4vyar9bUMZnHBJGrIAoljkUvasXrvmDQ2izFBk+D3OOi
	Ws4zQWtH/sxMdcE/3cNSng4t8nsp2mc=
X-MC-Unique: I3TMdkYmPgaJYTFoRZcTFg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=CBKMuFmL5gijmuf1DFI20LqKddvnpWrJWsATkUic4PgHvrRWiELfr7i1jmLDZ23rshFg4l+f2axSliv5t4J0M0h+yxoNRrg2sJIQQ7wuvGa4OZRu9rRmH3Wx4wOSY37QOJ5bhHU5hDg/oHMf+tOscqNhUj8ZfjONBgfpQvcwE70SzKBblHpoHe1qkxQBhIq2H6m345nVlZTe4fkQWxLLOPIC+00JNsEO8EgNtDbsuCFO04zpOHI1GS3q5LIaRZ5U3cb6Ed7jdm66F3VFmIsoFeOdS6NSJbO/7GuhJ/S4cYyPWYKE1YBl8v905qQZSjYXL/ScytMmYzKQB9TMFxZ/bA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=g+BTFWIs5BREDQuHeksaFpukJARFbQB7XnYaw9EUK8g=;
 b=lx8ybm60RHbRhH5JAFYJlixYR1i6qme6NNaIv8mfIrVZdavw8jacuEh6EpK7iLumx8gnsIBX2uvkdVKs8+crT4mAQsXlbZwlVht2ZfA4CnMoj5cPikNKDn7idYV8gYb3dJPZyDrATbdxFJGtL+Njk3M19xueR23STyTM//1DWslNs9tYZqFMvJLA/W2X0ETyDxkxRwM2DrzvJ7NP6syBveL12rXAyfFUB6W8uIrgYaqwVgu520I7cYkpFMBqdFpPHswgDJ5Gf9BYZPjhDXvItVtgzt3ltd/ynbBo6bepYfU7MBnjlfRlpcGto8VZEdnq5j50cuEusWwoY4Vtpfv/cg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <f4e3bc16-2983-6f5b-37e8-26ac385d4d72@suse.com>
Date: Wed, 23 Feb 2022 16:55:15 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH v2 00/14] x86/mm: large parts of P2M code and struct
 p2m_domain are HVM-only
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0127.eurprd06.prod.outlook.com
 (2603:10a6:20b:467::32) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 05710b94-906c-4f43-dd42-08d9f6e4e301
X-MS-TrafficTypeDiagnostic: DB3PR0402MB3770:EE_
X-Microsoft-Antispam-PRVS:
	<DB3PR0402MB377066B626D9317860AA11CAB33C9@DB3PR0402MB3770.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	dDS/I7+amyGQrCrlM2zg8RZO+DvKj+T3es6rxJFMt10VMsyqdfL1zY/Xlfxa7lw0pF1csVrtJvpomcBEM0qNoX0+pe8I4ON/tohi2vf5phw+b9i3wYKKQc76Wyx/ErCJWHLtvs3OpAYkUH6OsJryY9bQ8GzFa6759Zs8AlcNStuNNRAuGZUVI+LpriEtxUsKCGT8tZIXGf5vD1OmLi078Ta0RdIM7vYFqGY3vwCjORFJZkX3gz0KmB65TIWHEB5jejI+CrFN5x2NkxQuY+s+9uNlKTDmEalTfcnMXg1BKF/3w4r9Xx0gz37DY7tf+OxQC+buVJ2Af5VBB7ba9Tk408Js8PmOvN4yDjNw/HmArVw5D9kZN8IMmAqFjq27h79Du4oG5otDFzhEIoE4fvTiIyGw+vSZz36qTehbEBoNcMthoY9tOmCcMwiWensL0ebJ6AEx9DGg+/1UQEF3cz4kIxVVAy9Rn4fP7BJ//NCbWgqZf7zHlrflajL++zGk4lsiTxgN23W5n3PMl8diinEeZkjHTIoTs24kMJ5D327UA3vxb7h1USi8z3DV4/5Q7sXz5nlUcVhLPEcIwERR9itZvVrl+8HFIAVLr21yIisrGit10ARXUI/3TncSXjVwuiJcDMy7fqTK5d6H63XNamVT2HKa8hNR6T7cj0LmUJqNyFBcbj6n19FqIuttOt6IkeFp3Cf+mcsMxx8WpOZkJre641pKS31tH7P9Fpe93GppDaE=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2906002)(2616005)(26005)(38100700002)(186003)(83380400001)(6512007)(31686004)(8676002)(4326008)(8936002)(66476007)(66556008)(66946007)(6506007)(36756003)(6916009)(54906003)(31696002)(86362001)(508600001)(6486002)(316002)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RXFSMzNEMStRZzBDblN2eDBwQkFnK01XZGxoWTc3MlBMRlBicnFTS0I2VDQ4?=
 =?utf-8?B?NTFuRHdMVFlISWx3bjdNWUdUQk5WTTRPQzZibVBVVGtGdFViWTZ4cEE4d0lY?=
 =?utf-8?B?RVU0dlppTjRXT2hSblgycHZWU0Y3NitOdFh3WkU3UytYSWtmNTVHYStjY1hx?=
 =?utf-8?B?K1ppWU5rK1ArVGhSMUE4ckFwcFpkNUUrbVlxKzRFOGlGUmRjSEZ6MVBZWlA0?=
 =?utf-8?B?WVdhUkZ0c1ZJN3l3dXRBbWY3aFh3Z1k4aTU4bzBuSnBRc01ZTHZRYktCQVZO?=
 =?utf-8?B?OVBZSm53ZDhBVWRNeHhHa2Rwb2xYV2ticWk2aExmYkd5M3U2UUF5UHgyR2xN?=
 =?utf-8?B?VmpLLzUvZ2pXVHhncWZ6N2hYSHBZRi8zdHBETzNuNFhKTnBZVWdiQUNuamdS?=
 =?utf-8?B?NW5sMG02eXFFc2JheksvQjZ1TStFeGZoRGdUTUdENnVZMEg5ZUIzNk9HTDhL?=
 =?utf-8?B?OHVhMTQ5TDI4ZG9ORFRQeE8zRlhocnNUdTcwOGV0Y3VXVHQvS0tzTHBtM08r?=
 =?utf-8?B?U3BJZ014L2k4djlvZnRBbUQ4NFhOWmhmcUJmaVlhVVdxZzlHNE9zODFUcXpM?=
 =?utf-8?B?dXJVT3U0Nis5RUlmekxXcDJqMmRYcVNaOWs2aW4raXBMUkQ1RUh6OWNnemNE?=
 =?utf-8?B?UG9aNmNJWVdUTEhzbjJhNkV3dHczalVTbFIxcHhJK0xYRXY4WStVS05hYml5?=
 =?utf-8?B?R2R1YlJZcGdRazkvUGx3NHA4UzlieElCaE56dDlqaHQxYm8zTTc5dmNyUDN1?=
 =?utf-8?B?VHVxU2tZaU1LbFFBRmxVQVVIWUJFRXpDNkhXMG1FUFFjdEpuY3BybW9vV2Zp?=
 =?utf-8?B?OXpReDA1RkxRUjR5RENGM2RaQVo1VFVNL0xpMjh3VVE5UnRlY3F2SUdabVpT?=
 =?utf-8?B?WmFpMis4di81b3VsSEpmWGRaZ3RDMEY3a3pMc0tsL0xuRVNsT0tMazVaT0tK?=
 =?utf-8?B?R3hBdWRIZmx4R3BmVFpwQ0pLRmp5dmdaWWgxVkt2UzF4YVlLRGZ1NnUwWTZs?=
 =?utf-8?B?bEU2NEV2M2Eza2xURlhWS0lnTDhYeWRjZXhJWGdpTkNaNVNaV0lQbkd3VS9R?=
 =?utf-8?B?L0ZKa1dpajRVQUdPcUhaNHZNSmZJT2FKdis3UXNBNkh3OTBKalE3OE11WFl3?=
 =?utf-8?B?Lzl0TUtzSFgxemlBVXh1RldmYzlwZ0lNY1NtNWU0SXNOYldKdTFad0R5Snlu?=
 =?utf-8?B?L1gxWmlnQzRVd01pcmcrRXh5TGJVU1puOTRGVEhyUXlBeFMzeDFTaTMvUEVn?=
 =?utf-8?B?VjVYckdTanFaTzYyMjk0Q1AwOTZWZzdNcVRIbzFsVnNLMDExY0RUUTZFNWZl?=
 =?utf-8?B?OXEyeWwvaTV1Ykk3Z3p2dkwxckpROHZXMXZJVG14bVNpSHp6L0h2NlY5NCtM?=
 =?utf-8?B?eEgvRWRGTVdMalFxK2t2c3lROXhmbEVGZjh1V3pIUUY0eXpySjlCUGxWWUps?=
 =?utf-8?B?OHBZSlJxWWs0ZjFibDFDT0pHRTlWR0pXTVVuTGkvWDJPZWl4MUVmNlVUQlFH?=
 =?utf-8?B?cEZvU0U5eDVNK3phamlTRzdwOXAyQXd5SExUTklLNGc3N0M1VEhwL0xSNHkz?=
 =?utf-8?B?bDJ0aFFtVENBeXhzODUydVFWL21oNHhlS3lwZHVHQUxpQWxsTlEwWjVySkJD?=
 =?utf-8?B?SWhpMmdXSEt4bFg5anVWZFNIa0JXTFYrWDJ3dm1xQVpoWUZyV3dZL3RCUGRG?=
 =?utf-8?B?dXhvbW9Zd3dwM041Tm1RRUxNZEg0ZWRsU2swaWxqb2ZwcFNkcXl6ak9vWVNY?=
 =?utf-8?B?bmxlejdvdkJhK1RNdXNqOE5VM3JvWmcxMFpzZEM0NTIxTVdIYlFUdm0yRkd5?=
 =?utf-8?B?UEExQ2xZL3ZlTnhMLzNmVDNweE0vZmJOcUs1OStSakRvOE5QTS85Q0lFOExK?=
 =?utf-8?B?M0V3OWdCVlQxS0RZMkYxdTF6TCs0UWVFWW1DQysvTllsdm9BcG9lTkdQNm1T?=
 =?utf-8?B?UVZ4bjNlZmVGRVh3SittRjNMYi9ROEUwVDZSL0c1eEZLMzI0TTlZc3ZDWTFU?=
 =?utf-8?B?TGJQc1ozV2lnK1Fjenhla05oQkZMV3RsdG16QTh0MFdubzFIcFI2d01rOEI0?=
 =?utf-8?B?dVBLQUZHYTVIMU9sajdub09XT2Y1OCtQSUwvd3AzbjIrK1hmWnd5UjJDVHh3?=
 =?utf-8?B?NGI1dExxb2oxazExZUdPMldWSHo0c08rTmZKMkdwNGsramc5UTNKQXJOeVo2?=
 =?utf-8?Q?/h2DI34IZadS1cBJyQ/Q97s=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 05710b94-906c-4f43-dd42-08d9f6e4e301
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2022 15:55:17.3037
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bnLCNw/v68FrqP3adHbXyYU/p6pgniMp0lvzOueAigXm9uHi01JCQLOa5NKFEnrRZEqM2iPnv9cG/N8ZGFFfew==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0402MB3770

The primary goal of this series is to leave p2m.c with, as its leading
comment suggests, just code for "physical-to-machine mappings for
automatically-translated domains". This requires splitting a few
functions, with their non-HVM parts moved elsewhere.

There aren't many changes in v2, mostly from re-basing. See individual
patches for details.

01: x86/P2M: rename p2m_remove_page()
02: x86/P2M: introduce p2m_{add,remove}_page()
03: x86/mm: move guest_physmap_{add,remove}_page()
04: x86/mm: split set_identity_p2m_entry() into PV and HVM parts
05: x86/P2M: p2m_{alloc,free}_ptp() and p2m_alloc_table() are HVM-only
06: x86/P2M: PoD, altp2m, and nested-p2m are HVM-only
07: x86/P2M: split out init/teardown functions
08: x86/P2M: p2m_get_page_from_gfn() is HVM-only
09: x86/P2M: derive a HVM-only variant from __get_gfn_type_access()
10: x86/p2m: re-arrange {,__}put_gfn()
11: shr_pages field is MEM_SHARING-only
12: paged_pages field is MEM_PAGING-only
13: x86/P2M: p2m.c is HVM-only
14: x86/P2M: the majority for struct p2m_domain's fields are HVM-only

Jan



From xen-devel-bounces@lists.xenproject.org Wed Feb 23 15:58:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 23 Feb 2022 15:58:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277457.473960 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMu1g-00008G-TS; Wed, 23 Feb 2022 15:58:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277457.473960; Wed, 23 Feb 2022 15:58:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMu1g-000089-QM; Wed, 23 Feb 2022 15:58:00 +0000
Received: by outflank-mailman (input) for mailman id 277457;
 Wed, 23 Feb 2022 15:58:00 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=DZ7u=TG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nMu1g-000083-0k
 for xen-devel@lists.xenproject.org; Wed, 23 Feb 2022 15:58:00 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5f3ad3c3-94c1-11ec-8539-5f4723681683;
 Wed, 23 Feb 2022 16:57:59 +0100 (CET)
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur03lp2055.outbound.protection.outlook.com [104.47.9.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-19-SQzgJmp3NryWrBBt5thgAw-1; Wed, 23 Feb 2022 16:57:57 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DB3PR0402MB3770.eurprd04.prod.outlook.com (2603:10a6:8:12::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.28; Wed, 23 Feb
 2022 15:57:56 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.022; Wed, 23 Feb 2022
 15:57:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5f3ad3c3-94c1-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645631878;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=+aFyYLBG+wsL1hFDXE2XB3gg/hIZf4QnUWxpT0OEYsQ=;
	b=lHBmmS6P6PH3J3TOR17keKx2dAwglPwF4UEa0cCTOHpXOHDAdzggDSE8zvSc1H9Pg2XapF
	EQBZIv2n3a6XyxF4qLikjuvILXtM1s+FQesgkOK/341HjJh/kOJLzT9zjBWaiONs/06FxR
	NUVIoDmyMx/fU9ZjaYxL8rh3HNnD4mA=
X-MC-Unique: SQzgJmp3NryWrBBt5thgAw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jPm1eBKfko+0msEY4Srou/jjGn3g1iQ2VfaGtWZDCwZ8OoGd03wpWzyoRwdCAjk3xi1ij8+OMJonAfsg58NrpqMiPheKXIn6XQFmg6vUhuDpPp/yzrIOuXhJdalQqAZvbNbt302Z5S7qYyMelCvuF5JHNNyBHnvctQQ/XGkIeWVgfitxWwZlTeKFrmJBj7ngWIKpLsg6QiRn8i5HzIvNRkqzBJiNUOEnuJGXKArR1jgWiI7wZeNSr6QIfFg0ftEBs5RddEvGF5T4ExH7QotGcgdxys6PXLLJMS9w72zs6n6wPblbdJYtS/NJs43xhamHaYydDaaB2WxB5MA+FgGGxQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=+aFyYLBG+wsL1hFDXE2XB3gg/hIZf4QnUWxpT0OEYsQ=;
 b=mS97rn069Ede95/TcGHwN8fy7CC446CWe4n7tl+YDPUS9oHiPpqbqLdtsmMGRhvN02RGNJI9s8ZZyyujHuzmTpUfcBTSwk9HWOpeRZ+NmW5oIkXYCu54K/B7Y7vsM+UXFzapCe5+PKP+CRhpmy7iQ01fdJ/BMhlTIvMkLmKfrq/40VoKQUDhdVk+KnjKc9OKfZ4m7vwzsIGvvJ/9AmP+/CAO5S5+J6/5525U6sMi9abYnQ+ERd8e8f9qY/8QUr4nJxTtbQotzqxdu78Jl8a8cvU5NdpYdBybEWyAREJAQqU1T38J0mbMvPdB2C2LSrQR/OtoZf+XPJXEJqdPjoWfFA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <2353ed37-e62a-4e34-7442-0638bb92dc2c@suse.com>
Date: Wed, 23 Feb 2022 16:57:53 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: [PATCH v2 01/14] x86/P2M: rename p2m_remove_page()
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>
References: <f4e3bc16-2983-6f5b-37e8-26ac385d4d72@suse.com>
In-Reply-To: <f4e3bc16-2983-6f5b-37e8-26ac385d4d72@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR04CA0103.eurprd04.prod.outlook.com
 (2603:10a6:20b:50e::14) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5f9a0e0e-c011-4b7e-c8c2-08d9f6e541c5
X-MS-TrafficTypeDiagnostic: DB3PR0402MB3770:EE_
X-Microsoft-Antispam-PRVS:
	<DB3PR0402MB3770F4E152C552B7FF72A646B33C9@DB3PR0402MB3770.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	7G/HNfygm3MNpj2kD5dxbOsbERLa9Y/VF2MB8MqzFwu6msYEnUReAXXg6dAUy24BrVwcc9uE/IhATLpWJcSYc/ixgIouTZmV5/9F09sN3Ps8PMxjniBD49jGi4ZpCg0jecc0MvbR3MzhreH3BZNTkL37kQ8fvhVYWtxC/fE+VAkQp4h2b5KJau0bDt8vqGAP//D6ALTQlAVojjP63oUub581AD1UUPnsOyPqfEfJEjpxG/1An0JyoG/MAwxYJCgiIWExnR9Hj/l6zxBsYQoQiR8eZSvmhtfjudVsbljeVwve3BSLZoshBsE47tL/yx1NCrCdNPH0E1HUUjLStwtSFadI14TVEtg82jK/oI+3opcuskeevCcCV+FMg++sIn2xI0fv9K7auQugxKWonZacPEc4o3AsJ8i4AFRVTAykhNJS7Zwq3C4kh/AoVMSeRsC4h1Iehh7gujIE4mrMZmpxiqq/HRbW1+1gzXY1gXYb1rdJJHHliNAD7vuXqkXJFskKBFOlQJxBiDeERJmEkUEr2F125JMM5DKumS2rtzHRIy19jR3XaVfPv8NjyWtnxzefzwO09KcWNB3gWv2/S55yGjdeBxQX40i3cjaOAfx6YfnpaBEaJrw2F38WA4s1R6aY4OS3oFiEJDPYyDVcG73APKKru8NEYwIXkWS4Tq2hteqfJdIh1LGvXx3SkT27uPfFEexzXzWKn55BJqjD9uVjp5tut80SNuv5H/K66xP99rbX12zttcTO3dzCOQwykogq
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66476007)(66556008)(66946007)(4326008)(8676002)(8936002)(36756003)(6506007)(31686004)(6512007)(316002)(6486002)(5660300002)(6916009)(54906003)(31696002)(6666004)(508600001)(86362001)(2906002)(2616005)(83380400001)(26005)(38100700002)(186003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZldwZUxFaGJTeDRJQkdpZlYyLzJkWkNZbEc0RlFLaU9MVnUwSUlIRW1jZ2Nn?=
 =?utf-8?B?NWRzczhIUGZiVUJHeVZRd0JSakNuTWt4RXlWVng5VmJmSlRuLy9BZ0N6aTRD?=
 =?utf-8?B?NHBYWmh3elZmRG1uTER6YmZNZ3FJVEVRYmk1NTdFSlJ0VCtZNmZrdXhxNE8z?=
 =?utf-8?B?Tkc2TmMrQWEvVlpibmswUEF1VkpUQjQwYWxkeC9CQUNnM3hmRlVTRDhQTExy?=
 =?utf-8?B?K1JuTGlHZFFQS3l4d2tHU1ZqYTBZQ0RPdmowNElQZG1Ed3VmWlNNeC93OFpa?=
 =?utf-8?B?cDNPb2ZFc25yaGRyejZiNWt2VS9CS2pYL2FKa0tLMENzNThiWEJ3Z0VFNWx5?=
 =?utf-8?B?M0hYVHp0WE41ZHd1KzYxeVVJMjFxWEFqSnJKaGRVdVpPVVBWNnNLd2hneWUv?=
 =?utf-8?B?aEM4NmhmTmMyTTNOVEVqQklVV2Nwcy9ma2ZnZm15N3h5djd2VmRQZXJ3QmVs?=
 =?utf-8?B?c1VJenRpOFl5RVJwaHlEVzBrNFhWSkhxK0ZNRGg1KzI3S2lvUlFUT1hNZXI5?=
 =?utf-8?B?dmRTVnM4TGtMUUtVMjlFd2NGaHJvVmJ4SG0yM2dzUnhYMm1xdnFibVE1dHFx?=
 =?utf-8?B?dnZwWVF4WHdSVE9sRjNHTU5qN2kzK1FDc1VUTTVnaDVUVmJMK055TGtva0Jh?=
 =?utf-8?B?bTJUeGhUTFpvU01jQ1lFSnA3c01ybWMyR0RFL3ZpQ1JOS0p4MzdhdDdCUWgy?=
 =?utf-8?B?R2lrUDJobUhEcUNOb2lMcWtGQ1Jza2NOdUJobmtLcFhoa0RhdjNhcUYzS05u?=
 =?utf-8?B?ZlFyWmZET2VqMnA2eXlPNnVMQklab1pxZnk3YTFBNVdSQUpYMGZtanBUU3FZ?=
 =?utf-8?B?a0lTdGhCa1hNVEZlYURKTFpxUWNFKzNvNjc3S0lwWnIzWTJXTldHOFJoVUhK?=
 =?utf-8?B?dGxteUc0Z082Um9wQ1VBR2Z3WDQvVjBvVXN1SC8vRVJ1TUo3RDJGT2pTY3Vx?=
 =?utf-8?B?cXN6dWVSM1VqcHRZNkwxc0JXT0dVMHNCazEvUG5jS21WZmtBbURSQklqZDdq?=
 =?utf-8?B?UXRoWUZvRXk3TDFneTVyamVTNDBZSlZGWEIxVWVZRWpmSTlmNjlZcmZpblFr?=
 =?utf-8?B?V1NLMHFXNG9VeTdqRUptZ1A1TGhYVnNUVWh4SnZDeXdsS1RYU0JzUTZLRUlx?=
 =?utf-8?B?UFE2MzhrZUlTQk4xOHliYVBCNExGaFl4Z2lROXdqWGQrcFBHbm9JR0VSR3RT?=
 =?utf-8?B?ZkVxVHR3UFVoTEZTeUp1VXYwTEhoMUNlNkcrSHNGNkVtUGVzaVQ0MTRtSnhw?=
 =?utf-8?B?K0tIVmVzb1A0Z1d1c20yOXZqQ2NpNXdjZTRlRThRMFVlNEx0NDRlREZMK2J5?=
 =?utf-8?B?L0tKZUY4ZVpyeG1IV2huVFdwdDQxZFBtdk8rWHQ3QXJrOFNlalNiR05MTmhE?=
 =?utf-8?B?am9nMzl4SkJySVN6VmM2b215OHdrNks4VXppTGsvbGJBKzhwbE1ISkhNWnhr?=
 =?utf-8?B?b08rK2VRN1ZqQW9MbDhTR0ErUWZ2ME5GWVo2ejc2WXZUMzQxSUhXZW1Qa1ph?=
 =?utf-8?B?K0pkWnFRZ2ZnTDcwSEF6bVBkK0doa2dqVzlkYXZvcUZHVFlsZFk5U3d4QnlC?=
 =?utf-8?B?TE1zUExJMjBBNmdSOGlYeThmZmx4Z3ZXYXI0T0orVEp6aUhzQVJOSzYvVXlr?=
 =?utf-8?B?ZExUd0FYV1k1MWFJUWtvc2hWbEJFOGxnMjZoOUcwUVVJUFplZzdGRXdMSjkw?=
 =?utf-8?B?QW1IbExJZ1ZPVlByT1o4S21peXpnQ2RqYWV5cnpVUU9zWGJaQ2lITG9sbnFM?=
 =?utf-8?B?N1RTVjgvZm1lZ2RyM08wMHgwYW5kMjZibk5RR2pGajBNdDM0RktOTWV2VTNl?=
 =?utf-8?B?UnpwNWNWN3ByS2o4UVBzZjlHdURaTEVjdUdWamRWOFJlMGtwRzduQlA3YXV3?=
 =?utf-8?B?ZzhIRFBvY2dkYmFzMVAzWVZoOCs0TkhoZEQwWXBQQzFzYm9aOGJMdldld2xu?=
 =?utf-8?B?UDY1Y004alV1Zm1iTDlOdkpZeTY4UFE0ZlBPd3FwUDU3blN5OTlaSnRqY3Iz?=
 =?utf-8?B?SXpCK2hwRTlVQURaODFwVHpjSGNLalJ1SmpzQzUzazcyd2s2MEJwc1lTcWxZ?=
 =?utf-8?B?QWsyeHFIdm9ZRVYvWlVPaDZhSHFBM0RXbmlHd1NkL3hnM2MrcWFGK3RUSEh3?=
 =?utf-8?B?RS9ET09KOWhzbENUVW5tMy9BMks3dmRqSEErci9VZmpSWGtWR0pUdVQxcHJD?=
 =?utf-8?Q?Y8N08vJMOnRYKlKpN/ug//o=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5f9a0e0e-c011-4b7e-c8c2-08d9f6e541c5
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2022 15:57:56.2310
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 66J6X4yg94OJC5Sx0LWHMCdwjgOUe/FMe+ZfB2cL5yAt7c3LPuni4lZvViKy2ZOvRSl/rU3lBjMzwl4jUQg24w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0402MB3770

This is in preparation to re-using the original name.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/arch/x86/mm/p2m.c
+++ b/xen/arch/x86/mm/p2m.c
@@ -788,8 +788,8 @@ void p2m_final_teardown(struct domain *d
 #ifdef CONFIG_HVM
 
 static int __must_check
-p2m_remove_page(struct p2m_domain *p2m, gfn_t gfn, mfn_t mfn,
-                unsigned int page_order)
+p2m_remove_entry(struct p2m_domain *p2m, gfn_t gfn, mfn_t mfn,
+                 unsigned int page_order)
 {
     unsigned long i;
     p2m_type_t t;
@@ -861,7 +861,7 @@ guest_physmap_remove_page(struct domain
         return 0;
 
     gfn_lock(p2m, gfn, page_order);
-    rc = p2m_remove_page(p2m, gfn, mfn, page_order);
+    rc = p2m_remove_entry(p2m, gfn, mfn, page_order);
     gfn_unlock(p2m, gfn, page_order);
 
     return rc;
@@ -1034,7 +1034,7 @@ guest_physmap_add_entry(struct domain *d
                 P2M_DEBUG("old gfn=%#lx -> mfn %#lx\n",
                           gfn_x(ogfn) , mfn_x(omfn));
                 if ( mfn_eq(omfn, mfn_add(mfn, i)) &&
-                     (rc = p2m_remove_page(p2m, ogfn, omfn, 0)) )
+                     (rc = p2m_remove_entry(p2m, ogfn, omfn, 0)) )
                     goto out;
             }
         }
@@ -2444,7 +2444,7 @@ int p2m_change_altp2m_gfn(struct domain
     {
         mfn = ap2m->get_entry(ap2m, old_gfn, &t, &a, 0, NULL, NULL);
         rc = mfn_valid(mfn)
-             ? p2m_remove_page(ap2m, old_gfn, mfn, PAGE_ORDER_4K)
+             ? p2m_remove_entry(ap2m, old_gfn, mfn, PAGE_ORDER_4K)
              : 0;
         goto out;
     }



From xen-devel-bounces@lists.xenproject.org Wed Feb 23 15:58:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 23 Feb 2022 15:58:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277462.473971 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMu28-0000fr-9b; Wed, 23 Feb 2022 15:58:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277462.473971; Wed, 23 Feb 2022 15:58:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMu28-0000fk-5v; Wed, 23 Feb 2022 15:58:28 +0000
Received: by outflank-mailman (input) for mailman id 277462;
 Wed, 23 Feb 2022 15:58:27 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=DZ7u=TG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nMu26-000083-UU
 for xen-devel@lists.xenproject.org; Wed, 23 Feb 2022 15:58:27 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6f4c82fc-94c1-11ec-8539-5f4723681683;
 Wed, 23 Feb 2022 16:58:26 +0100 (CET)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2108.outbound.protection.outlook.com [104.47.17.108]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-3-Zm6pYrUGPle-SJIaBPcs8A-1; Wed, 23 Feb 2022 16:58:24 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0401MB2479.eurprd04.prod.outlook.com (2603:10a6:800:53::8)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Wed, 23 Feb
 2022 15:58:22 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.022; Wed, 23 Feb 2022
 15:58:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6f4c82fc-94c1-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645631905;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=UcksslQkFnjukx7/qYD/769exeJYXe3uEWi/y4UhXP8=;
	b=I2WVD+bKt7OphxsKNTrcGgt55gQGf6RyzwBg1ZQYLgTmWG73jqj9/aZFl0PyrfKfK/D3gZ
	s1vMlskfNEV+F7q2x4SJCeO0AVaakiD77DgCXHdCjlaNnZvSUDoMjr4vpXQ38ZScDkZ+wO
	P3O0P6DMr6LMWpSPxsN/8GUeeCl/wiA=
X-MC-Unique: Zm6pYrUGPle-SJIaBPcs8A-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=OTkmp3eUsu+niUJ8vaY04/O94scbFhQpwOAkTC0uN1TE62IECYiLvpxkwJyXdYogd99jnmBbzCuZBrc0Pzh0XI6o0/iYgFRp1Bt28swjIysef2Ex9C+/crNZ6MRiTEtSveXDe0qnH8QSLiQeszoH3jQ5GuC/JbUtR+tjmRGTBjTWrkxqBsADzC/5iy0EGGK+Ued//VvVERJeDi6oprcuavTWrPa133HU6MZ0GCjdGC6eWNr7k/Ep0qFz9Exm7RPlQVxwCx/HZCT2XjH0RhsY1pTqxUXY14fdk43P+vHz0fVSSvHKoSCJPcOHghGc5QNgcoK0l83ro6ci+tVVydOmAA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=UcksslQkFnjukx7/qYD/769exeJYXe3uEWi/y4UhXP8=;
 b=JIUGLUacf0gy7AXabk3vQv2+mrJ1S3UyApcqdAZaiSfzRYopSPsinic9iVzrNT49hpSDNNOoWNg5WFPchRY7Oa1Mqlt+EKdxfHak1kTWmp+jaOcCDdp3axrAzG9UTLS6ySumb9KybjyFpww44Hnzjdsqa8ktM1wAkSgAI39BJimaYUob1V8PsrvZTmtACcVtJSg+gB6PODoD7YnY9jEM46IEN4Z+fs4C4T6VCv7A3LsWmvQRfldiNOT8GNwGll7V6NDDdRgIfDWhy0eZZoLAYC0op+Pgluovg4De45sRWLCm1JVIEuOMFXt0t1loWo0UEFfgA0MWOvt2tjIM+HpmKA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <c8ad290d-65ba-8437-276b-5d5f1d4d225b@suse.com>
Date: Wed, 23 Feb 2022 16:58:19 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: [PATCH v2 02/14] x86/P2M: introduce p2m_{add,remove}_page()
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>
References: <f4e3bc16-2983-6f5b-37e8-26ac385d4d72@suse.com>
In-Reply-To: <f4e3bc16-2983-6f5b-37e8-26ac385d4d72@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR04CA0087.eurprd04.prod.outlook.com
 (2603:10a6:20b:50e::9) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b2401632-ba8f-4e18-c1d4-08d9f6e550f3
X-MS-TrafficTypeDiagnostic: VI1PR0401MB2479:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0401MB2479D2A799AFDE50662D12A0B33C9@VI1PR0401MB2479.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	yjw9wy2M5E9JsbLrU4e+tchVyP22l5Ka1irAt6Qzpo3cFATgJqMy2gaJpQDXvEQ01Kb42wqkpElDtuzHX9fOx28YUd+eJ2w6/JUJh3vQhC4HTkR0MBUncCucAiulK3GY6Fa2u9yunSB75aQyKNAcub2bwEw2V7s7KcGzfQ/N2Tk+2LHWzYZG60UtEAnnHmzp05jmjcwzcVZ9QvT5cPbIUDkeu+/aQ/9vLPEPAPZSTYsm2r4FNAwFBR1CJM6dmwYgazL1Isg79D/bUmiUUdtO+T3rn4oWX+x3aUbtgI1l/N+jMFvWAwymKLx4C8WNNT8w3tdc8qO6mSt2M43zX3OkoukUnCbAIUmYgupNOpayIb4mIMLo/CVDh9hsSrxEBx1w99vJu7+Sj6iERnc+l20mQjk2GRBhH3MtQnBMzgaaxqAZXLbzxjPmxNN2gXpmKYz00cTVa6dsgAn10h6WdTwot7UCZ4Kd++0ulcTR7qRG15B0YbXJMUGDu0H5atCYAihW8eEkDCBbNRShwYyDyALGTN0L5J7O37qY+Vve4pUiN4CLd2rUEDfUI+b6WySY7DLwRmwZDWCComYehgIC+z+BnYKBXx/qd9GwJrmpdsQYiTJ/3NSgfXbj5GNzEqiY4tKTcnKXSL/Fk1uTY8p1ZuXJBhP0yCy5bQwYQ2DbsbWnOaHVkeCOoB1Q89xtwto5rxwVS7tYgaByo1GF1xgDx23TRkwMejxutTET3X7Z0hdoyiD5I/s2hnYjGgKi6hnsfMuA
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66476007)(66556008)(8676002)(4326008)(26005)(66946007)(186003)(6512007)(2616005)(2906002)(6486002)(508600001)(6506007)(31686004)(316002)(8936002)(6916009)(31696002)(86362001)(38100700002)(5660300002)(83380400001)(54906003)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TmtpSHNvTW96RDZuZSsvdVdRcTZweE0vbjdoOWtETWRhSlFCQ3RiQTVwTlk4?=
 =?utf-8?B?L2FvSkUrQ25OcHdNTU1QR1BPRCt6K0o2TVhNc2VvOVRpNUpETnJGM2V0elp6?=
 =?utf-8?B?d05ZcXpvcU1OVWt0M0g0d1htck5iQ2c1L1owQkFPUzZnYkpJZEdwdjVzL3lQ?=
 =?utf-8?B?ejVrdWhZQ3YzZ3FQc2dOSUZhNEdzQXJMbEg5UC82Vkl3UUQxQkcxUGZNQVBp?=
 =?utf-8?B?a3VYU0hzaThCZE5CYy9ZQWFIMFJxRm9ZZnkvMk5FTnhPNS8zS2VjTHhVU3Js?=
 =?utf-8?B?REpEelIyVm14S2lZQ3hpdm1nd0pydTVObUVRODFyWkwveC9Ud3krNVB5VEpq?=
 =?utf-8?B?Q21tNi9oUmhrY1IvcWc3dC9MUERwOEVIU25TSFNjNVZXVi9FaFZ2VUtCeHQy?=
 =?utf-8?B?eCt5bHVtNWNsYWV2MnhRTXZHc21QWkN0WkRHUDlnQld1MGdweUlkRituWUdI?=
 =?utf-8?B?cmNCNXZCWGI2MENjUnd3dW0vUVhXRDk1ZlRRcUF0WXJjL1F4bytpc2poc2NN?=
 =?utf-8?B?K1BQSCtpVmRmT0U4ejQwMjFJRTRFS3B5bHQxNXhwMEZ2NGx0SDBCV1laNnhk?=
 =?utf-8?B?SVdkL3dmZTZOU1JLNkxoVkEzZ1FFeFZHb3NTZXRiNzU3dksyTS9aT0txNVlQ?=
 =?utf-8?B?QnpwcUFaRjk2RTl0eDNSQjA4cnVmYW9ROEFFWkdJbEsyMkpocC9nSnRSUndO?=
 =?utf-8?B?U2drUUJKQjdLak9KNzZnYkF0YXNWY0VBenRneENYR2xkV3A1MWE1ODBCeFQy?=
 =?utf-8?B?SWdHNkluTkFpZVgrdXpqay9ZbENYSnFkTG96bmIzVGVDNzlTYzR2MjV5UkJL?=
 =?utf-8?B?MExUek16eWtWOEQvZDQzQjl4WlRCQm9jZmJaYVBhZ2UwaTQ2dzQ1OEFkUnlw?=
 =?utf-8?B?OGpJZEtVUXNHMitjUmtwZEtjWUxDU1hFS05penpqOEV0QUhNdTV5QVBJUEtW?=
 =?utf-8?B?WkYzSFpUclR5K0NEYVExTzkzRkhNOGtWcDJvbWlSU1d6OFhaQnh5T2liVUY5?=
 =?utf-8?B?OHQrSWp0dVhPNlViWFlNV1A3OHZGb0hBbWQyWUhFNHJxY3ltcGZYOTQzTzVx?=
 =?utf-8?B?eWg5ZDRjR1lkNmlrdVNQeVJ4MDllODVrSThsaDN6bmRLQXpLR2xrVWk3OWtP?=
 =?utf-8?B?OGwrWlpyNkMxUi92cFRReU1HWVVmUmgzNjZyOTRlVGdhc0krUUhpdVhoeVdV?=
 =?utf-8?B?L08xWFBvZ0o2RXhYdThpQkEzaWlkTkJQcjN6WlJITGh6NmxzNDR2eTdaWmxS?=
 =?utf-8?B?YXVGK1dubGl4Qyt5cklET1JHc2N5UWNMU1VMMXJqVFBpRjlOUVBDcnRTZGVC?=
 =?utf-8?B?SCtQTmRBdncvaldKMjJZd2ZqR0hsMWlzMzZmQjM5anZzRGhSeVdUVGtPOE13?=
 =?utf-8?B?N2puUm9YeXR6OGdWZWVueUprbXVjT1dhTTFRMGYyZkxhcHRPbEdycEwvLzlx?=
 =?utf-8?B?L1dqbzdDcDF5Zk9zaUNOOWxHZjFFb1hvS3VrcVlMSXNvSEJhWm12aXpnaUFN?=
 =?utf-8?B?eWdQbmM5czkzcUM1WmZKUnViYnFUbnpQc0hDQ04wS1IyL2ZQQ3JEL1R6MnlI?=
 =?utf-8?B?RXRDb3phNEFPRmZ0VjVPdkl5aHNVTlBNWlk4R2w5dkNyWEYrbCtWd1ZpYTJm?=
 =?utf-8?B?N2ZtODI2OXF6Skh1Q1hLMUdtdExQOTFHS1hGWDRybjh0aVFtSlFIQldYZk5y?=
 =?utf-8?B?UDJZbDB4NE5xRnJJSE82SVRhMHI4TU5ST3h0T2VUcmRGMjlGTi9BZS9QaU9G?=
 =?utf-8?B?V3Q5K2JLejF4ZnFuMlV0YTY4YzR1SG0rK090c1dKMW1Hb3oweTd1dTF1L2cy?=
 =?utf-8?B?YmtCU0psTE50K210UGdSeDZZRGdvU3d3bDBjWXVOTXRycGVFZDVyTDBtcWpa?=
 =?utf-8?B?a3B0MXZoOTZ6YWNmaXFwSEhMZStxakZrdWVFU3FsNitUWFZKSnZsOGVldEh3?=
 =?utf-8?B?bWhGRE1vSXhQOXhmUDB5a0pKZEt0ZnFvVEdwNmhZU0pubDJBeXlUQmdvSDgy?=
 =?utf-8?B?cTdqcXRFZGw1c0xpcDZBQlI4cVpWY2pGK1BsNmF2MFhleTJIQ0xpeWM3dFU5?=
 =?utf-8?B?aUx3c0JXYmlMeDRkWVNRNzVJallTNFd3UDV2MzRBOTQzQXVuNGwrejk2MnNj?=
 =?utf-8?B?SEFQaC9McFZDRnNnU0xvMm1scHgvRlFUanhmVU1rR2xCZWJ4VWdTVjZOR1NO?=
 =?utf-8?Q?hh6Xv8EJIVBcZViPnZLLKRo=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b2401632-ba8f-4e18-c1d4-08d9f6e550f3
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2022 15:58:21.8231
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: s+NkDB1vovupwkMp3XZTRieGTc5miDaMCztCt6vo0rypIgUOPBUNwGMEss4IyPV9dYprXudVp03a89lqTB5ttA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2479

Rename guest_physmap_add_entry() to p2m_add_page(); make
guest_physmap_remove_page() a trivial wrapper around p2m_remove_page().
This way callers can use suitable pairs of functions (previously
violated by hvm/grant_table.c).

In HVM-specific code further avoid going through the guest_physmap_*()
layer, and instead use the two new/renamed functions directly.

Ultimately the goal is to have guest_physmap_...() functions cover all
types of guests, but p2m_...() dealing only with translated ones.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Paul Durrant <paul@xen.org>
---
v2: Re-base. Adjust description.

--- a/xen/arch/x86/hvm/dom0_build.c
+++ b/xen/arch/x86/hvm/dom0_build.c
@@ -173,8 +173,7 @@ static int __init pvh_populate_memory_ra
             continue;
         }
 
-        rc = guest_physmap_add_page(d, _gfn(start), page_to_mfn(page),
-                                    order);
+        rc = p2m_add_page(d, _gfn(start), page_to_mfn(page), order, p2m_ram_rw);
         if ( rc != 0 )
         {
             printk("Failed to populate memory: [%#lx,%#lx): %d\n",
--- a/xen/arch/x86/hvm/grant_table.c
+++ b/xen/arch/x86/hvm/grant_table.c
@@ -39,9 +39,8 @@ int create_grant_p2m_mapping(uint64_t ad
         p2mt = p2m_grant_map_ro;
     else
         p2mt = p2m_grant_map_rw;
-    rc = guest_physmap_add_entry(current->domain,
-                                 _gfn(addr >> PAGE_SHIFT),
-                                 frame, PAGE_ORDER_4K, p2mt);
+    rc = p2m_add_page(current->domain, _gfn(addr >> PAGE_SHIFT),
+                      frame, PAGE_ORDER_4K, p2mt);
     if ( rc )
         return GNTST_general_error;
     else
@@ -68,7 +67,7 @@ int replace_grant_p2m_mapping(uint64_t a
                  type, mfn_x(old_mfn), mfn_x(frame));
         return GNTST_general_error;
     }
-    if ( guest_physmap_remove_page(d, _gfn(gfn), frame, PAGE_ORDER_4K) )
+    if ( p2m_remove_page(d, _gfn(gfn), frame, PAGE_ORDER_4K) )
     {
         put_gfn(d, gfn);
         return GNTST_general_error;
--- a/xen/arch/x86/hvm/ioreq.c
+++ b/xen/arch/x86/hvm/ioreq.c
@@ -188,8 +188,7 @@ static void hvm_remove_ioreq_gfn(struct
     if ( gfn_eq(iorp->gfn, INVALID_GFN) )
         return;
 
-    if ( guest_physmap_remove_page(d, iorp->gfn,
-                                   page_to_mfn(iorp->page), 0) )
+    if ( p2m_remove_page(d, iorp->gfn, page_to_mfn(iorp->page), 0) )
         domain_crash(d);
     clear_page(iorp->va);
 }
@@ -205,8 +204,7 @@ static int hvm_add_ioreq_gfn(struct iore
 
     clear_page(iorp->va);
 
-    rc = guest_physmap_add_page(d, iorp->gfn,
-                                page_to_mfn(iorp->page), 0);
+    rc = p2m_add_page(d, iorp->gfn, page_to_mfn(iorp->page), 0, p2m_ram_rw);
     if ( rc == 0 )
         paging_mark_pfn_dirty(d, _pfn(gfn_x(iorp->gfn)));
 
--- a/xen/arch/x86/mm/p2m.c
+++ b/xen/arch/x86/mm/p2m.c
@@ -850,15 +850,17 @@ p2m_remove_entry(struct p2m_domain *p2m,
 }
 
 int
-guest_physmap_remove_page(struct domain *d, gfn_t gfn,
-                          mfn_t mfn, unsigned int page_order)
+p2m_remove_page(struct domain *d, gfn_t gfn, mfn_t mfn,
+                unsigned int page_order)
 {
     struct p2m_domain *p2m = p2m_get_hostp2m(d);
     int rc;
 
-    /* IOMMU for PV guests is handled in get_page_type() and put_page(). */
     if ( !paging_mode_translate(d) )
-        return 0;
+    {
+        ASSERT_UNREACHABLE();
+        return -EPERM;
+    }
 
     gfn_lock(p2m, gfn, page_order);
     rc = p2m_remove_entry(p2m, gfn, mfn, page_order);
@@ -867,6 +869,17 @@ guest_physmap_remove_page(struct domain
     return rc;
 }
 
+int
+guest_physmap_remove_page(struct domain *d, gfn_t gfn,
+                          mfn_t mfn, unsigned int page_order)
+{
+    /* IOMMU for PV guests is handled in get_page_type() and put_page(). */
+    if ( !paging_mode_translate(d) )
+        return 0;
+
+    return p2m_remove_page(d, gfn, mfn, page_order);
+}
+
 #endif /* CONFIG_HVM */
 
 int
@@ -905,14 +918,14 @@ guest_physmap_add_page(struct domain *d,
         return 0;
     }
 
-    return guest_physmap_add_entry(d, gfn, mfn, page_order, p2m_ram_rw);
+    return p2m_add_page(d, gfn, mfn, page_order, p2m_ram_rw);
 }
 
 #ifdef CONFIG_HVM
 
 int
-guest_physmap_add_entry(struct domain *d, gfn_t gfn, mfn_t mfn,
-                        unsigned int page_order, p2m_type_t t)
+p2m_add_page(struct domain *d, gfn_t gfn, mfn_t mfn,
+             unsigned int page_order, p2m_type_t t)
 {
     struct p2m_domain *p2m = p2m_get_hostp2m(d);
     unsigned long i;
@@ -2724,7 +2737,7 @@ static int p2m_add_foreign(struct domain
     {
         if ( is_special_page(mfn_to_page(prev_mfn)) )
             /* Special pages are simply unhooked from this phys slot */
-            rc = guest_physmap_remove_page(tdom, _gfn(gpfn), prev_mfn, 0);
+            rc = p2m_remove_page(tdom, _gfn(gpfn), prev_mfn, 0);
         else
             /* Normal domain memory is freed, to avoid leaking memory. */
             rc = guest_remove_page(tdom, gpfn);
@@ -2732,7 +2745,7 @@ static int p2m_add_foreign(struct domain
             goto put_both;
     }
     /*
-     * Create the new mapping. Can't use guest_physmap_add_page() because it
+     * Create the new mapping. Can't use p2m_add_page() because it
      * will update the m2p table which will result in  mfn -> gpfn of dom0
      * and not fgfn of domU.
      */
@@ -2846,7 +2859,7 @@ int xenmem_add_to_physmap_one(
     {
         if ( is_special_page(mfn_to_page(prev_mfn)) )
             /* Special pages are simply unhooked from this phys slot. */
-            rc = guest_physmap_remove_page(d, gpfn, prev_mfn, PAGE_ORDER_4K);
+            rc = p2m_remove_page(d, gpfn, prev_mfn, PAGE_ORDER_4K);
         else if ( !mfn_eq(mfn, prev_mfn) )
             /* Normal domain memory is freed, to avoid leaking memory. */
             rc = guest_remove_page(d, gfn_x(gpfn));
@@ -2854,11 +2867,11 @@ int xenmem_add_to_physmap_one(
 
     /* Unmap from old location, if any. */
     if ( !rc && old_gpfn != INVALID_M2P_ENTRY && !gfn_eq(_gfn(old_gpfn), gpfn) )
-        rc = guest_physmap_remove_page(d, _gfn(old_gpfn), mfn, PAGE_ORDER_4K);
+        rc = p2m_remove_page(d, _gfn(old_gpfn), mfn, PAGE_ORDER_4K);
 
     /* Map at new location. */
     if ( !rc )
-        rc = guest_physmap_add_page(d, gpfn, mfn, PAGE_ORDER_4K);
+        rc = p2m_add_page(d, gpfn, mfn, PAGE_ORDER_4K, p2m_ram_rw);
 
  put_all:
     put_gfn(d, gfn_x(gpfn));
--- a/xen/arch/x86/include/asm/p2m.h
+++ b/xen/arch/x86/include/asm/p2m.h
@@ -577,10 +577,11 @@ int p2m_alloc_table(struct p2m_domain *p
 void p2m_teardown(struct p2m_domain *p2m);
 void p2m_final_teardown(struct domain *d);
 
-/* Add a page to a domain's p2m table */
-int guest_physmap_add_entry(struct domain *d, gfn_t gfn,
-                            mfn_t mfn, unsigned int page_order,
-                            p2m_type_t t);
+/* Add/remove a page to/from a domain's p2m table. */
+int p2m_add_page(struct domain *d, gfn_t gfn, mfn_t mfn,
+                 unsigned int page_order, p2m_type_t t);
+int p2m_remove_page(struct domain *d, gfn_t gfn, mfn_t mfn,
+                    unsigned int page_order);
 
 /* Untyped version for RAM only, for compatibility and PV. */
 int __must_check guest_physmap_add_page(struct domain *d, gfn_t gfn, mfn_t mfn,



From xen-devel-bounces@lists.xenproject.org Wed Feb 23 15:58:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 23 Feb 2022 15:58:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277470.473982 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMu2Y-0001Fw-I1; Wed, 23 Feb 2022 15:58:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277470.473982; Wed, 23 Feb 2022 15:58:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMu2Y-0001Fp-EE; Wed, 23 Feb 2022 15:58:54 +0000
Received: by outflank-mailman (input) for mailman id 277470;
 Wed, 23 Feb 2022 15:58:52 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=DZ7u=TG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nMu2W-000083-JD
 for xen-devel@lists.xenproject.org; Wed, 23 Feb 2022 15:58:52 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7e8ea6a3-94c1-11ec-8539-5f4723681683;
 Wed, 23 Feb 2022 16:58:51 +0100 (CET)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2111.outbound.protection.outlook.com [104.47.17.111]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-29-zU7gkAc4PgqNKoLYXq-eyA-1; Wed, 23 Feb 2022 16:58:50 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0401MB2479.eurprd04.prod.outlook.com (2603:10a6:800:53::8)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Wed, 23 Feb
 2022 15:58:45 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.022; Wed, 23 Feb 2022
 15:58:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7e8ea6a3-94c1-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645631931;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Absf33xo61iOtxqb/+8Eu6L66vlBNlW2G4hE8J6Sq7o=;
	b=PqAPjUGtAceYdQRviw961lJiU11Jf6C59vrit+3rMXZCvtHHLDh+N5VYTeQ/epH2RBrAGX
	JbOn1+u/US+iLSXP/7k+9ANySfeu5S+YVu5u8QPumfkXqCGof0WkmP3l/Z/OKGqoNls7ax
	Gky+QAtvV47fFQHOVrA7U35x6SbxsGk=
X-MC-Unique: zU7gkAc4PgqNKoLYXq-eyA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=WGvqI8lY7T3PBBTL5P2rrn9cyf77+7GvTxPiIbgNQMErHX/MCsgB0+dFKhzvdwzRy+03eQs7zGlyTgwKHKAMAak8bAUVimKA/EZGEDz+8IZTC9vqkbmdjFgPslcR6e27Ms+j0uzo8J+HuYV+9qqb9QtGJ+PlwtIdXl1tObNpTKz3BvuzN+CbrVsYWcPG0um6efkIIJjcNVfw9SK42ilWE6OcbetAeAdAMHO+ex63PAjzFQ98+Cj+l80pgQbCHjSjaVcRunk5zAGAwqJq7cUCW+x0+livy+jowYYoBhm0VFBosu68sZErUCuw+hrXFSmWHDodJ+qhEK5A8+9P65ETPw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Absf33xo61iOtxqb/+8Eu6L66vlBNlW2G4hE8J6Sq7o=;
 b=I8D7EbBgxBaBfszSBub3/rkec2CUJV9chcxyvXDV9FynTk0ZHj2zFsLipI0kBG3PHVQI67GmObZ74aAMvaneMbMDTqsa3q1PmQN61cwltyCT3dukz98deSmZnnSc28H51QbUMxglHgaKDiqJtUlZ8Tx6hBUZ92wmBdEoJ3AlzS1veQ8ibGzUC4+E9PtW9Vj0Zlmy8JD5/E0a+s6LUWDloYbgKoJ2k7WVVD/CyNp+RXZnwOKBTnQGF8XjkfAiUpZtA17ZEfK0d9j7mNksIbgaGqwWNrVjnU0owYQrVq36xjQAdbL0Z2ikGPfoq4laNhS/QuOxdWEUNa0F/a0OHT2w4g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <c61adefa-bcfd-5792-8017-72403f3f0920@suse.com>
Date: Wed, 23 Feb 2022 16:58:44 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: [PATCH v2 03/14] x86/mm: move guest_physmap_{add,remove}_page()
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>
References: <f4e3bc16-2983-6f5b-37e8-26ac385d4d72@suse.com>
In-Reply-To: <f4e3bc16-2983-6f5b-37e8-26ac385d4d72@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0355.eurprd06.prod.outlook.com
 (2603:10a6:20b:466::22) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e5795b0e-57da-4f2b-a191-08d9f6e55f41
X-MS-TrafficTypeDiagnostic: VI1PR0401MB2479:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0401MB2479512CE5B72045A9C5BB0EB33C9@VI1PR0401MB2479.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	WABS4NcpsqIOvX/u/RMoLxxGAwmzGlIny8Vn/d0YWRwPz9fcFZKcvOquP7EeXByTDwIuK7rqGVb/UXmDyZkw5cws7p59BikH8Jdrl3hNASQAZstsGRj1bz8r0ypkhmlmwqdDWrZoaHo2s7C58K7O5WCJUyIcBNeksZCiwOw2cEF8D6WFpfEkAQyxCBocLuXhqSWgf9YViTduPpB5x3uqXvt5chlgeBkWdxSXfO6ymqoT+TCAzxJv3ZOn0Xa7RaSvF4QTntz8WfAzmdVMG7oXxjeQKylAkROX53kF7hq7q7BEHW/8iAX7MGpKVyvUUatmuUfGCXtcQAiSp7+fyOXRMWf3v1y5xGHWFr7qx/zVAcHaP9Q4yUJpropajWY7es5doa6X89IRZRji1ILVKTeFrbW4nXWHSkpaQ73X5n06lt85ZtjKaG79+Td9+1yTVd3Fz+8aeI4I2JEsRekhs9BFC86IVz1AwOuCKtdqi4FGt4zWRwzgxKDX8xDfQFOaSbihkgBJe5C2ATF/Bg+Xu5JGqcgNZl2bgyqaMEoleJmuBmPgfqB8m3n2VsLQdNEYPz/4EZUXTNBE9JVvwWEkqGgXSMuvXGuTrCyBJA9dImSrsQHSz7Qkm00LIQdnL63VO1Z2arhpq7h3Q8F8/bz/0tIVXngQhTm8K58+wZUMJIAM/BaQFd50+uzzq7l2BvR1TEUBpe+vlcbxa2b4iX3F+2+JlsUCgsY6p55wzk9C2ww9/bCmCTnTo9nQg8CJEnPnrN1+XllIDU6j2tq3zOF1wMxScsFKmonlpIHUSZ+OFbmsTVPAGcPaeSEnf5tdUfiM762oieo/HnvNr0rgc7x2sXeXwA==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66476007)(66556008)(8676002)(4326008)(26005)(66946007)(186003)(6512007)(2616005)(2906002)(6486002)(508600001)(6506007)(31686004)(316002)(8936002)(6916009)(31696002)(86362001)(38100700002)(5660300002)(83380400001)(54906003)(36756003)(2004002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VWJiYkl3U1VSZk1DL0QweW9XbmRCUEkrQ0NuZklzYUU0RUdYZTNHZ3IxRDRN?=
 =?utf-8?B?WmE3U3hrZkFzWThZNWxQTXJ6OUFqbmhWM3YwTkk1SzAwYm1GbjFvWlUvR1FJ?=
 =?utf-8?B?L0k0MEJFanpySTJLRFhlR2c0R1JnTTZZZWtmaVI5VEZUeVdMQkF1b2NTTWxr?=
 =?utf-8?B?aXIrbG9FUWxlZ3BkMm5VQVFldTVnN3JKek9PbW1nOFl4RFl1OWV5YkFnTXFB?=
 =?utf-8?B?Ym5HaERrTy93SUlteHFpQ1JJaEIzTEZycVZBK2IxMkVuOVNMMHBQRHdaQk12?=
 =?utf-8?B?OENiTGxXalgyeUdmSnB1ZmhyOUQ1S2ZTRzl0cnhiVGJmZS8xTUlPemNDMnJ6?=
 =?utf-8?B?RWU1VmFMMUJzOURtSFhMZnV5WTJEVUZIRXhLaU0ycUthcXQ1OW0zckkxN0lZ?=
 =?utf-8?B?WTgzcEVuMjZWWjVrcER0SWVXelFSbUtxaXpDSEREVks1dDVMUzRnakZjUmhu?=
 =?utf-8?B?bUdxalY5ZUthUHVJZS9yM2txTG9BbUo0T0FySjdlVk5KN3lKSGl6NUNrSXhM?=
 =?utf-8?B?T205OXh3UXJ4elA1N2FpRStPbmxQWEdMcXY0N2tWOHpRZitJb1l3UzZIOUNp?=
 =?utf-8?B?eUc3VC9CYVgrU3RweGw1TzFpYk12NnYySWtSdGZsS25aWHB5M0VXb2E5emMx?=
 =?utf-8?B?bkZDN3paUGVrd3NNVFkxZitFcUJORTcvNzRxT2QxdlZLMGpsaHVJUjU5R25q?=
 =?utf-8?B?RGlwWXFtSlEzWXhhTXMzL1RScEM4eGpDTXNJWXIrL1cxUXVhMHBxVDhSN2VJ?=
 =?utf-8?B?cU0vVXZ5dWdyWnNITmhHaVhjR0piSzF6UnMrbi82ckpVR1IwOUQzaVQrZG5Q?=
 =?utf-8?B?K1R2bnA5b090L3JQN1U2dXJSR3R2cVBIdGFWbjU3RXdlM3dydmZ4eUR3SG1m?=
 =?utf-8?B?d284V0x2ZldUZER1TlZtbkI3Q3JGSEZhb2x6dUJOemZNOExyNng3VERCbVlM?=
 =?utf-8?B?Y0FZRC9abzJTNUsyOU4rRmRyemw4ZjBpTjB1RjBmWHRYVHpkUWxFQnFQSFhJ?=
 =?utf-8?B?bzRScDJDc3FMQktEcnp4SFU3TXkwZTBOd1RUcWx6SmRkK09URmwreGlndEsy?=
 =?utf-8?B?S1MycmZIS1IvZzNJdlU2UHMzeXBvcWdCSXJnZXBrR3VQMFI3UHh0RGJ5OGdP?=
 =?utf-8?B?M3lpU3laU0NSSW1lY0F1T0ErRDFJd1VFa0VtRUZ0Nnc4cVE0TmJGaWUrbEFZ?=
 =?utf-8?B?d3ZjZ2hRc2txQTJmTjFIbktadHdWNWk2ZnhYUzlZY0dQTkZwdTU4SHlhbjFL?=
 =?utf-8?B?RnBXUDBCUndPdWlheFg1WENLckJKOTNHcnQvclU5L3NFdk5HQnJtWFNrQnYw?=
 =?utf-8?B?RmlNZmNYdXAwS2s4WUhsWTFzM3Z5RFRFOEVLeWR0S2hJdktzQlFDbDROM2Rp?=
 =?utf-8?B?cXhJMnJWRG1NdElKUThtdjRtY1IzTk1Qa1BjNnF0dkR1ZEMzU0d1YlFwR0s3?=
 =?utf-8?B?ZlFPVmhwdFBNVGg1aEo0b2hNa0tzT0NnVjVVNzBBNlgyemdMMUJ3Y2NUc2pl?=
 =?utf-8?B?TWdXdGtGYlorL2VJcm56R1VzQk9ObG5Qa2N5VlYyYmtSUGJVWmQ4LzVwaGFS?=
 =?utf-8?B?RTIxblNkMFd1VmlCMGErZXo4K2twV3k3UE52WVN5NEhUSEUwRmRySEx2Z1U2?=
 =?utf-8?B?WnhPeUd0TEJzZGxzbURQY1dNcUlXaW9TSTNZUWlLVkFHbzhsNndNSGl3Wkxp?=
 =?utf-8?B?ajdLR2RWWGhiekx3YmFpSzZ4M3k0Q200K3I2bWcydGQvRzhBNm9HcGplZ2FO?=
 =?utf-8?B?QTlGeWxqSjRQNTVsYmVJMGZuMzBuVCtDSU9GOHBJcWhFOXFlWk5SckZVN3Nq?=
 =?utf-8?B?M3BocVdxZXNKN2pPVGswWmJkZ0FQV2NpNDYyNlhMN053UzVYWkc2Zms1Yzk2?=
 =?utf-8?B?N0tZZm1pQ3RHeE1YTVl1Sm1Jejc5SzIrL0RTZlR3RkMyanlRaEg1V25NYTc3?=
 =?utf-8?B?cUdtcStkWWRYRVZiV2NPRE9HR2xieU1relZGY0VOejlNYjNLdTdmZnh4VC9V?=
 =?utf-8?B?djN4bXdjdEpIUnNkWm1ON2w4c2hLVU1WdmN2eEhuMUJVdE5yZHNKaTdqelNM?=
 =?utf-8?B?TU5IOGFMb0laWWxWeE5WcldjZ0RJS2czRzNxc0NMcmtQZWx6MWIxcElVdW15?=
 =?utf-8?B?VU9iUGNYSHVnWnc5Wk5RVUNNNDhacTd3Ykp1bUxSQUZFS2hzZXFsc3lST3N6?=
 =?utf-8?Q?ds6oL/oMsFh+53nuota1DVg=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e5795b0e-57da-4f2b-a191-08d9f6e55f41
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2022 15:58:45.7278
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CvyFsYc8ownQ1/EGeS4qc3C+pgthdYbarHFA0wTgKjdSk3AqKqDNzyheg+KHEyVbjy1Z4C9THSAyFZVHFwz8EA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2479

... to a new file, separating the functions from their HVM-specific
backing ones, themselves only dealing with the non-translated case.

To avoid having a new CONFIG_HVM conditional in there, do away with
the inline placeholder.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: George Dunlap <george.dunlap@citrix.com>
---
v2: Re-base.

--- a/xen/arch/x86/mm/Makefile
+++ b/xen/arch/x86/mm/Makefile
@@ -10,3 +10,4 @@ obj-$(CONFIG_MEM_SHARING) += mem_sharing
 obj-y += p2m.o
 obj-$(CONFIG_HVM) += p2m-ept.o p2m-pod.o p2m-pt.o
 obj-y += paging.o
+obj-y += physmap.o
--- a/xen/arch/x86/mm/p2m.c
+++ b/xen/arch/x86/mm/p2m.c
@@ -870,60 +870,6 @@ p2m_remove_page(struct domain *d, gfn_t
 }
 
 int
-guest_physmap_remove_page(struct domain *d, gfn_t gfn,
-                          mfn_t mfn, unsigned int page_order)
-{
-    /* IOMMU for PV guests is handled in get_page_type() and put_page(). */
-    if ( !paging_mode_translate(d) )
-        return 0;
-
-    return p2m_remove_page(d, gfn, mfn, page_order);
-}
-
-#endif /* CONFIG_HVM */
-
-int
-guest_physmap_add_page(struct domain *d, gfn_t gfn, mfn_t mfn,
-                       unsigned int page_order)
-{
-    /* IOMMU for PV guests is handled in get_page_type() and put_page(). */
-    if ( !paging_mode_translate(d) )
-    {
-        struct page_info *page = mfn_to_page(mfn);
-        unsigned long i;
-
-        /*
-         * Our interface for PV guests wrt IOMMU entries hasn't been very
-         * clear; but historically, pages have started out with IOMMU mappings,
-         * and only lose them when changed to a different page type.
-         *
-         * Retain this property by grabbing a writable type ref and then
-         * dropping it immediately.  The result will be pages that have a
-         * writable type (and an IOMMU entry), but a count of 0 (such that
-         * any guest-requested type changes succeed and remove the IOMMU
-         * entry).
-         */
-        for ( i = 0; i < (1UL << page_order); ++i, ++page )
-        {
-            if ( !need_iommu_pt_sync(d) )
-                /* nothing */;
-            else if ( get_page_and_type(page, d, PGT_writable_page) )
-                put_page_and_type(page);
-            else
-                return -EINVAL;
-
-            set_gpfn_from_mfn(mfn_x(mfn) + i, gfn_x(gfn) + i);
-        }
-
-        return 0;
-    }
-
-    return p2m_add_page(d, gfn, mfn, page_order, p2m_ram_rw);
-}
-
-#ifdef CONFIG_HVM
-
-int
 p2m_add_page(struct domain *d, gfn_t gfn, mfn_t mfn,
              unsigned int page_order, p2m_type_t t)
 {
--- /dev/null
+++ b/xen/arch/x86/mm/physmap.c
@@ -0,0 +1,85 @@
+/******************************************************************************
+ * arch/x86/mm/physmap.c
+ *
+ * Parts of this code are Copyright (c) 2009 by Citrix Systems, Inc. (Patrick Colp)
+ * Parts of this code are Copyright (c) 2007 by Advanced Micro Devices.
+ * Parts of this code are Copyright (c) 2006-2007 by XenSource Inc.
+ * Parts of this code are Copyright (c) 2006 by Michael A Fetterman
+ * Parts based on earlier work by Michael A Fetterman, Ian Pratt et al.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#include <asm/p2m.h>
+
+#include "mm-locks.h"
+
+int
+guest_physmap_add_page(struct domain *d, gfn_t gfn, mfn_t mfn,
+                       unsigned int page_order)
+{
+    /* IOMMU for PV guests is handled in get_page_type() and put_page(). */
+    if ( !paging_mode_translate(d) )
+    {
+        struct page_info *page = mfn_to_page(mfn);
+        unsigned long i;
+
+        /*
+         * Our interface for PV guests wrt IOMMU entries hasn't been very
+         * clear; but historically, pages have started out with IOMMU mappings,
+         * and only lose them when changed to a different page type.
+         *
+         * Retain this property by grabbing a writable type ref and then
+         * dropping it immediately.  The result will be pages that have a
+         * writable type (and an IOMMU entry), but a count of 0 (such that
+         * any guest-requested type changes succeed and remove the IOMMU
+         * entry).
+         */
+        for ( i = 0; i < (1UL << page_order); ++i, ++page )
+        {
+            if ( !need_iommu_pt_sync(d) )
+                /* nothing */;
+            else if ( get_page_and_type(page, d, PGT_writable_page) )
+                put_page_and_type(page);
+            else
+                return -EINVAL;
+
+            set_gpfn_from_mfn(mfn_x(mfn) + i, gfn_x(gfn) + i);
+        }
+
+        return 0;
+    }
+
+    return p2m_add_page(d, gfn, mfn, page_order, p2m_ram_rw);
+}
+
+int
+guest_physmap_remove_page(struct domain *d, gfn_t gfn,
+                          mfn_t mfn, unsigned int page_order)
+{
+    /* IOMMU for PV guests is handled in get_page_type() and put_page(). */
+    if ( !paging_mode_translate(d) )
+        return 0;
+
+    return p2m_remove_page(d, gfn, mfn, page_order);
+}
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
--- a/xen/include/xen/p2m-common.h
+++ b/xen/include/xen/p2m-common.h
@@ -8,18 +8,9 @@ int set_foreign_p2m_entry(struct domain
                           unsigned long gfn, mfn_t mfn);
 
 /* Remove a page from a domain's p2m table */
-#ifdef CONFIG_HVM
 int __must_check
 guest_physmap_remove_page(struct domain *d, gfn_t gfn, mfn_t mfn,
                           unsigned int page_order);
-#else
-static inline int
-guest_physmap_remove_page(struct domain *d, gfn_t gfn, mfn_t mfn,
-                          unsigned int page_order)
-{
-    return 0;
-}
-#endif
 
 /* Map MMIO regions in the p2m: start_gfn and nr describe the range in
  *  * the guest physical address space to map, starting from the machine



From xen-devel-bounces@lists.xenproject.org Wed Feb 23 15:59:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 23 Feb 2022 15:59:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277480.473993 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMu3S-0001z0-08; Wed, 23 Feb 2022 15:59:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277480.473993; Wed, 23 Feb 2022 15:59:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMu3R-0001yt-SO; Wed, 23 Feb 2022 15:59:49 +0000
Received: by outflank-mailman (input) for mailman id 277480;
 Wed, 23 Feb 2022 15:59:48 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=DZ7u=TG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nMu3Q-000083-HH
 for xen-devel@lists.xenproject.org; Wed, 23 Feb 2022 15:59:48 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9ff2ad84-94c1-11ec-8539-5f4723681683;
 Wed, 23 Feb 2022 16:59:47 +0100 (CET)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2104.outbound.protection.outlook.com [104.47.18.104]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-10-abkoG7xhPoqmV5MEq1IFFQ-1; Wed, 23 Feb 2022 16:59:46 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VE1PR04MB7277.eurprd04.prod.outlook.com (2603:10a6:800:1b3::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Wed, 23 Feb
 2022 15:59:44 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.022; Wed, 23 Feb 2022
 15:59:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9ff2ad84-94c1-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645631987;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=rxOvYBPuwcs53bD4+mtzB6XcLqkGKt/WncfF3FQQLbQ=;
	b=d4ajpPmOPofNs+OPBpiFx0MBBSAzq0z86m1kPc3v1VEf4ywCiXYzkynxSxvaBR0+xVxoPs
	BWGtW7zGL0U2RRsD+UUkkgdNmPAtk1JXnQK2xyIeVpxrec4c7YszryRqq5EFWYywX81Ot2
	9e7+VfWcOBqf6LctQrW+vkZBPV/yQIE=
X-MC-Unique: abkoG7xhPoqmV5MEq1IFFQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=RqtXOWrC85AhXLlQO37mlPRuNqBbvTpvf8XGeHMXnCB4+B3kKRODde6m9ZbYD0juFpJ5F4LTcRNYrh5tbZynUj51QJh5KmWXSebMvOe5stzvJnbbsuEcuaRlG+BwEVbq+cjKeS9UJnflDfB4Gj7owWOxycDbk06ZyzRYzbikmhyMmdIQ/PIXesyKScnXb9n2AM1LlbNzB8B+w5PAL6so/pBAZ3yZGh5Qcd7QgJX8sguO9jeAiPMq0KCX6sDQW++jyFJi/956V9MlCePPsukpSrEAX8nNTsiIQTN9mp9+iDsSU0VBu/oAalZuahJZYKJOZdD5YHwm+X9y+bP+F8OREw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=rxOvYBPuwcs53bD4+mtzB6XcLqkGKt/WncfF3FQQLbQ=;
 b=k12nXV9WZS0/4y9XCBm0gu2xmJo5TTdnf0pcmp3izAFpPXzUTg3hZJl01UOJyrgUvObpCETUhl4Ph40wBKEFzizbqZBcqs5wvooTzPWZwn6xWkgwHigbYK3TMCPCzKDlfZlqR6VQmsfpnIR6kLDjQbEohju3uN9CeXaiFfI52QxeWha3ce84MYfvBgZh9t90YTDUj7+lBN5J3ybGPYytGFEAoKu3yuhYv56LExrIJDsJxRy3U01u6Q3sTDOjS157KK/aMRyP+sgyMHga93dh0DTRMBYT2gxWYCCjfIvmTWxlK0X+RW9bfHfoOWPEtNW6I64zKnPmW/K0LBE2ipIdtA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <69623630-cda7-9b2b-4f2f-09a83d5dc22a@suse.com>
Date: Wed, 23 Feb 2022 16:59:42 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: [PATCH v2 04/14] x86/mm: split set_identity_p2m_entry() into PV and
 HVM parts
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Paul Durrant <paul@xen.org>
References: <f4e3bc16-2983-6f5b-37e8-26ac385d4d72@suse.com>
In-Reply-To: <f4e3bc16-2983-6f5b-37e8-26ac385d4d72@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0701CA0010.eurprd07.prod.outlook.com
 (2603:10a6:203:51::20) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 74362b95-35ae-40e6-5e4f-08d9f6e5822b
X-MS-TrafficTypeDiagnostic: VE1PR04MB7277:EE_
X-Microsoft-Antispam-PRVS:
	<VE1PR04MB7277923295A8289DB075C890B33C9@VE1PR04MB7277.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	O6GhJO9JSlCfTRRpTRHJv96TDo1klnDLYdOiA0zJXOupuPHTJ8P8mihdKjlpFlkRg613p7vjQOgMoujI211QBbg50Dp0HJZ82O2rSdQguftlsfGYr0wzLacOB1xZWIeqneYAOKVSaPUsR7wSTjOLD5L0GT7b53eQ/wYULsAjVffgr1ZYk6vZZDBtpekQoDJKUz4jRRb+dW52MPvxz6f9nVb7V1vL0riq/m7YZvO11l4b2larSMo+9ifXQ3DmY8ae2rAoDPZhxNfZQUqaT8TBcT/yATH9HJmnbovfiKHbth4DHtJVGvORGYs8t8Cv3vn52jnq32Q2E2eouuqhPzbamcvdBlwp4Q0965GJvWQQLGNFIP9xTimnk8nHe52s8h68Bbx5AWGOUuf1A4PqnPlgCg2BjiHN8k9SPHBrLK0bhDahixW1blCHmg4wW8GriPI25RYpzxiIsqrdPdo84vpdwcaLhenE4VCe0s+N8rCbLpYJXDRMBZbkaZvvGAJ8AXDUEMtH33EEKuRw8MjrdDenBXfpfSj+NOPqq2JENIlTmSc3FV4tipc/MHLcr1GhXYYcARx1YysLveYUumEV5HB3tuUzntSWSyrfhgGkpirnEKcNP2rzYXOfpx6QRC7zWt5QO0ryVJ8AbVEd3ovpfWlnWzl6XYc6T3TmIEJPSswBRLCZowlAotB/mkwxrI2YPII/8KLF1wl1I7hePQGyI9fUIK4ewlJxi4/pP0Xp9JieUNdGDbKzH7sugokGMU6ePcFsrcLy06KbpLDNA1enedNCMceth5AzxWZCKTahS+mH7ytS6acBHZmC5KHt/4OcPV8iygo+dwDgxYkfXLSU0JzA9fOTqj4q8ImxbeOgkRsj9Vw=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66476007)(186003)(2616005)(8676002)(4326008)(26005)(66556008)(66946007)(6512007)(2906002)(6486002)(508600001)(6506007)(31686004)(8936002)(6916009)(31696002)(86362001)(5660300002)(83380400001)(36756003)(316002)(38100700002)(54906003)(70780200001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VnlSeVhyVTd4enE5a0VKbFlqa0xMcXdvMThYeFpOYnhMaGZzZkJXcjBteTV0?=
 =?utf-8?B?Z1VnVHFQbDhXUUdRTmd3N3RrZDBrNndDOHpXUFUxTWhUcjNDRkNWNVFENXBZ?=
 =?utf-8?B?OG51V0RTV2piSS9JZ0Ixa3V4djJFOGpCZUlOZlVzNElOOTNPY0JIVTh6N2Va?=
 =?utf-8?B?WTZER0R1b1loZzF5S2VBVFo5Y1Q5bXBBV0d5cXpyMTAxQUM2SjcrZGFZRjlx?=
 =?utf-8?B?YXJjVEVGNzdFYTlVUk15ZWdaMGJpNG94emlGKzBlZk4yNCtGQWZvcE9FT05W?=
 =?utf-8?B?citScGFwZ2RmalRCSm1vTFllNE5TY2NRcDh3NUg2RkdCZ0VvOUU4VFVPckl4?=
 =?utf-8?B?RFo0S3h2VWQwZTZqbUV4d0wzbXI5dHMvbmMvbzdmME9tWERkMTlZUVpSaGI0?=
 =?utf-8?B?VHdRbUdma2hHZXRWMzVNVUI4OXJzUjRBUzBBUHBQc3o5VmRGVWE2NXM4QTRW?=
 =?utf-8?B?aUZpbURWYndSZE4rY2Yyb1lnM1RPMFpqMytodmx2eG1qUjBBUFNmYzBxazY5?=
 =?utf-8?B?UHVwaU9CVEVFamllUkF0UXN6eTFDMnFSTkJ6Y05vMldBSHRSRHZyV2ZUNGNt?=
 =?utf-8?B?bWRTRkVZMFNNMnRuQk5tcWJHczJrWWFoSTF1S3U4MGlyRDNjdHhNMTkvYzk2?=
 =?utf-8?B?MC9sZk56dTFzOHdNTGJCWkJzZXpGbUtsa3lKMmpEUXVrdjVobktEVmY2Ynov?=
 =?utf-8?B?S3ptY3ZWQkRIVlhaR1NDeXpOOUYzQ0tXUDlERzQ2SGNFNkRPTnBTMk1aazBW?=
 =?utf-8?B?L2haZTdIak9MbDhncktMM3dxSXVsZDJpYWRld1dQUk5KK05DQkVxSEpSZEVr?=
 =?utf-8?B?R29sMFZxcjB1bE1JL0FMVWJDRllQTlZTSWw1dVdad2FPOElZbkpTK2xhcEw0?=
 =?utf-8?B?c1htL1V0NFgxTUJvUmsrSnVkMjMrcURoZk9OWGRvWU5qd2JPMkRtWlBubFlW?=
 =?utf-8?B?V1FGdTRIcnlQODgwanY0eTAzVWp2MjM5TDhVL3hoYkJJM09DNDFhKzU2UXkv?=
 =?utf-8?B?c25yUGdjL0k2U3R4NVc2NDNSQWNCQWlCbFJoOFUwSENrMmFrbkpIWnUveWw3?=
 =?utf-8?B?WDRMOWxwNld3RHVockN1b251WVAzZk5qdWlUZnhXZlRwdGhqbFNDZEppZmE1?=
 =?utf-8?B?Uy9jbFR3MnBNWnBxZVlwSnEycCt0MmJkbVNmaWxXd3JabENHVmdYczJYTXZR?=
 =?utf-8?B?ZkNQNUJzMVh6UGtxVEdYL3dnblZYMlZmdXZDQUZyK2tQRG0yTTI5VHBBTElR?=
 =?utf-8?B?SE9SUjcvVGhDRGo4a3UzemtRZ2ZPa0RzUi84M29FZ1QyTVUxeGJJamN5OFhJ?=
 =?utf-8?B?OTVmZytuWXRFN2FDZm9pWURCSkZZQ1dPdEYreVV2TWRML3NqSVdSQ0lIR0h5?=
 =?utf-8?B?N3IrZEt0UElERldBeDRSUTVQaDRUWXdRa0hhU3FKV2kwenpmVmFaUTFsL0xW?=
 =?utf-8?B?cDlBaE1Bd0E0c0hVY2JJUjYrNmxxd3UwR1dOVi80cm5KNGt2V1FvRFc5bWZT?=
 =?utf-8?B?UUFDT1BRdkxMM2dRT2p2dXhsU3g5TzJRKzJNMHdyOHVkeGNSRDA5dC9YR2JP?=
 =?utf-8?B?c0J3OEFHMGlEOHRqRHd0RVpwRTM1WkszVisxSUlxb29ocjhheGJ3ZEExSncr?=
 =?utf-8?B?cW9GcmlUUGhNWSsxa3ZoQSsxRWlGenRYVHAxOVV6aHBjS3BJVlpaTFZlbnUw?=
 =?utf-8?B?OGJYOUxOaEU2RjBhWVlvU3UwVU54dzRTY3VrVlU3TjlYN29ETEJsVWFhRU5v?=
 =?utf-8?B?L1hLRkRxUnJ4ODA1dmRCUE9jUmp3Rzh2WEs5M0xOSWJiUUljb1E1QnZnVmR5?=
 =?utf-8?B?SXJEVlBPQWgrL0o3bkxlREF2UFJYK25DbzQrYUhMLzlKMUpsVWl6a2tQem92?=
 =?utf-8?B?b3doaE9XNzMzNkc4cHBodHFKaEc0bGtSazdKTGduUDdYbXJRZGNRMWJYaUxU?=
 =?utf-8?B?VHpWN0srcmpLaW1VblRLTEVZRnhnSDFnQ1NwUEVoYUlaRG9Pc0RBUTZubXNw?=
 =?utf-8?B?MnRITkxzVldmVFFHYkZzbHhDY3MvTGdocEtKbE0rVVBEdHcyZjRreXNSV0ZK?=
 =?utf-8?B?Zjh2VUdpT08wb0xISmpDS3lWd0E1T0dCelVlenJFUWxNNkxLSi9EbXNEKysv?=
 =?utf-8?B?cXdOMlF6bzY2QjltYUhTVThGU2UyY1NmS090a3FUckw3UElOR0VmdE13NDdY?=
 =?utf-8?Q?F5TEc9PEWV5NpXoOpxWQKkQ=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 74362b95-35ae-40e6-5e4f-08d9f6e5822b
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2022 15:59:44.3022
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Mb30VvWdbv7CEnZjD0OY3IzCl/JfeLaFI26VUJc7Mrg/7YCmGHTIHD9zAsI3ekiM5ul35AWIK1F5vEvKDBj3oA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7277

..., moving the former into the new physmap.c. Also call the new
functions directly from arch_iommu_hwdom_init() and
vpci_make_msix_hole(), as the PV/HVM split is explicit there.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: George Dunlap <george.dunlap@ctirix.com>
---
v2: Change arch_iommu_hwdom_init() and vpci_make_msix_hole().

--- a/xen/arch/x86/mm/p2m.c
+++ b/xen/arch/x86/mm/p2m.c
@@ -1473,12 +1473,9 @@ static int clear_mmio_p2m_entry(struct d
     return rc;
 }
 
-#endif /* CONFIG_HVM */
-
-int set_identity_p2m_entry(struct domain *d, unsigned long gfn_l,
+int p2m_add_identity_entry(struct domain *d, unsigned long gfn_l,
                            p2m_access_t p2ma, unsigned int flag)
 {
-#ifdef CONFIG_HVM
     p2m_type_t p2mt;
     p2m_access_t a;
     gfn_t gfn = _gfn(gfn_l);
@@ -1488,13 +1485,8 @@ int set_identity_p2m_entry(struct domain
 
     if ( !paging_mode_translate(d) )
     {
-#endif
-        if ( !is_iommu_enabled(d) )
-            return 0;
-        return iommu_legacy_map(d, _dfn(gfn_l), _mfn(gfn_l),
-                                1ul << PAGE_ORDER_4K,
-                                p2m_access_to_iommu_flags(p2ma));
-#ifdef CONFIG_HVM
+        ASSERT_UNREACHABLE();
+        return -EPERM;
     }
 
     gfn_lock(p2m, gfn, 0);
@@ -1520,12 +1512,10 @@ int set_identity_p2m_entry(struct domain
 
     gfn_unlock(p2m, gfn, 0);
     return ret;
-#endif
 }
 
-int clear_identity_p2m_entry(struct domain *d, unsigned long gfn_l)
+int p2m_remove_identity_entry(struct domain *d, unsigned long gfn_l)
 {
-#ifdef CONFIG_HVM
     p2m_type_t p2mt;
     p2m_access_t a;
     gfn_t gfn = _gfn(gfn_l);
@@ -1535,11 +1525,8 @@ int clear_identity_p2m_entry(struct doma
 
     if ( !paging_mode_translate(d) )
     {
-#endif
-        if ( !is_iommu_enabled(d) )
-            return 0;
-        return iommu_legacy_unmap(d, _dfn(gfn_l), 1ul << PAGE_ORDER_4K);
-#ifdef CONFIG_HVM
+        ASSERT_UNREACHABLE();
+        return -EPERM;
     }
 
     gfn_lock(p2m, gfn, 0);
@@ -1561,7 +1548,6 @@ int clear_identity_p2m_entry(struct doma
     }
 
     return ret;
-#endif
 }
 
 #ifdef CONFIG_MEM_SHARING
@@ -1606,8 +1592,6 @@ int set_shared_p2m_entry(struct domain *
 
 #endif /* CONFIG_MEM_SHARING */
 
-#ifdef CONFIG_HVM
-
 static struct p2m_domain *
 p2m_getlru_nestedp2m(struct domain *d, struct p2m_domain *p2m)
 {
--- a/xen/arch/x86/mm/physmap.c
+++ b/xen/arch/x86/mm/physmap.c
@@ -21,6 +21,7 @@
  * along with this program; If not, see <http://www.gnu.org/licenses/>.
  */
 
+#include <xen/iommu.h>
 #include <asm/p2m.h>
 
 #include "mm-locks.h"
@@ -75,6 +76,33 @@ guest_physmap_remove_page(struct domain
     return p2m_remove_page(d, gfn, mfn, page_order);
 }
 
+int set_identity_p2m_entry(struct domain *d, unsigned long gfn,
+                           p2m_access_t p2ma, unsigned int flag)
+{
+    if ( !paging_mode_translate(d) )
+    {
+        if ( !is_iommu_enabled(d) )
+            return 0;
+        return iommu_legacy_map(d, _dfn(gfn), _mfn(gfn),
+                                1ul << PAGE_ORDER_4K,
+                                p2m_access_to_iommu_flags(p2ma));
+    }
+
+    return p2m_add_identity_entry(d, gfn, p2ma, flag);
+}
+
+int clear_identity_p2m_entry(struct domain *d, unsigned long gfn)
+{
+    if ( !paging_mode_translate(d) )
+    {
+        if ( !is_iommu_enabled(d) )
+            return 0;
+        return iommu_legacy_unmap(d, _dfn(gfn), 1ul << PAGE_ORDER_4K);
+    }
+
+    return p2m_remove_identity_entry(d, gfn);
+}
+
 /*
  * Local variables:
  * mode: C
--- a/xen/drivers/passthrough/x86/iommu.c
+++ b/xen/drivers/passthrough/x86/iommu.c
@@ -373,7 +373,7 @@ void __hwdom_init arch_iommu_hwdom_init(
         if ( !hwdom_iommu_map(d, pfn, max_pfn) )
             rc = 0;
         else if ( paging_mode_translate(d) )
-            rc = set_identity_p2m_entry(d, pfn, p2m_access_rw, 0);
+            rc = p2m_add_identity_entry(d, pfn, p2m_access_rw, 0);
         else
             rc = iommu_map(d, _dfn(pfn), _mfn(pfn), 1ul << PAGE_ORDER_4K,
                            IOMMUF_readable | IOMMUF_writable, &flush_flags);
--- a/xen/drivers/vpci/msix.c
+++ b/xen/drivers/vpci/msix.c
@@ -409,7 +409,7 @@ int vpci_make_msix_hole(const struct pci
             case p2m_mmio_direct:
                 if ( mfn_x(mfn) == start )
                 {
-                    clear_identity_p2m_entry(d, start);
+                    p2m_remove_identity_entry(d, start);
                     break;
                 }
                 /* fallthrough. */
--- a/xen/arch/x86/include/asm/p2m.h
+++ b/xen/arch/x86/include/asm/p2m.h
@@ -637,6 +637,10 @@ int set_mmio_p2m_entry(struct domain *d,
 int set_identity_p2m_entry(struct domain *d, unsigned long gfn,
                            p2m_access_t p2ma, unsigned int flag);
 int clear_identity_p2m_entry(struct domain *d, unsigned long gfn);
+/* HVM-only callers can use these directly: */
+int p2m_add_identity_entry(struct domain *d, unsigned long gfn,
+                           p2m_access_t p2ma, unsigned int flag);
+int p2m_remove_identity_entry(struct domain *d, unsigned long gfn);
 
 /* 
  * Populate-on-demand



From xen-devel-bounces@lists.xenproject.org Wed Feb 23 16:00:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 23 Feb 2022 16:00:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277487.474004 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMu4F-0003tF-A4; Wed, 23 Feb 2022 16:00:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277487.474004; Wed, 23 Feb 2022 16:00:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMu4F-0003t8-5g; Wed, 23 Feb 2022 16:00:39 +0000
Received: by outflank-mailman (input) for mailman id 277487;
 Wed, 23 Feb 2022 16:00:38 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=DZ7u=TG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nMu4D-000083-Pp
 for xen-devel@lists.xenproject.org; Wed, 23 Feb 2022 16:00:38 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id bd5c63a5-94c1-11ec-8539-5f4723681683;
 Wed, 23 Feb 2022 17:00:37 +0100 (CET)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2057.outbound.protection.outlook.com [104.47.13.57]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-19-6uulGi0aMkiUDrCb_-IcGg-2; Wed, 23 Feb 2022 17:00:35 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DBAPR04MB7477.eurprd04.prod.outlook.com (2603:10a6:10:1a9::8) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Wed, 23 Feb
 2022 16:00:32 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.022; Wed, 23 Feb 2022
 16:00:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bd5c63a5-94c1-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645632036;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=XB8iGCGqs8PHapYbAltMnTIf3L+ULvxt+u5ysAKSY4A=;
	b=npRSJUupycm1feeGAKEssoYMuQU5h2FHTxOnmnh1Rp8QUoFQ+dDCMIfGXsFglQx8MzbXb5
	Q/8o86C4yhPq3/uvDrHIAaMex7GE8K1Zdcs8dVePNSSor3mhurLFHg0/feS+zLfxfqTZlV
	20DQvRFnOnojASm/skBsW8bzlBAsfD0=
X-MC-Unique: 6uulGi0aMkiUDrCb_-IcGg-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Ta0Q2CS5xPVH6PK5Dns7ddodwo/13k6SHOE816p2YYpHgdl5Rj5NtJjggzxB0omBryvVcr7PKBWJ6YfZqKcd+tOiTgQsNXPkjS+vVIskUra+Zbra5W7qMx1DITgoW4lAd5nvFnGNkTyBS++nnvcGkIoBNqJImMq1Ag6OSmdjsVWqJk7GKrUuNMjDqO98Rl3qdR8VFnqKgYZeX3oYEy4AV+R9DgG/CQdBahpx43detnIIPrKl7zyDe84Nii1yg4epcmIKuBtyd+Ti55U2QkCtwJTtwB2lxz9EzmthtW2PWKNlCS7yL34c81YXf7kAQAmlUDvbaWh1jO0nd6GvRPzSgg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=XB8iGCGqs8PHapYbAltMnTIf3L+ULvxt+u5ysAKSY4A=;
 b=lodkDBsp/t6haZR0x+LCuzXj9MkpqvAQjcqjLwRHzEcHr0MzpmwAwVguIAP0SL3BcaJbXqcF07FlHm5q6tvEnZDHj5ebhpqUg1Mfk/69BmB5D6Uth/7JCFOnNnsRXHo4SDS7QBN43nOFGiX8iP5H1AX1wGdP9c2Sxd6BgITGTidGMwhuAfB/jyH6nNXKKTNUubhejWFAgbmqev3ET6c1i4V0k6aok7LQFC+S7m1DeMSloiJkSBt67vE+5VrqMuo8+NG/Wc8Kh2DCZ+RbfesQTu3GMcmca1Zfy3QDh/ph+jeHZKnsF8Ps+/H/M9h2jz6ZWnfBqmE3JhKVS09n8gWzMg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <0c3d463d-80fa-cd19-22b6-6335fd69bd11@suse.com>
Date: Wed, 23 Feb 2022 17:00:30 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: [PATCH v2 05/14] x86/P2M: p2m_{alloc,free}_ptp() and
 p2m_alloc_table() are HVM-only
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>
References: <f4e3bc16-2983-6f5b-37e8-26ac385d4d72@suse.com>
In-Reply-To: <f4e3bc16-2983-6f5b-37e8-26ac385d4d72@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0362.eurprd06.prod.outlook.com
 (2603:10a6:20b:460::9) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4457a6a9-e610-4491-2e56-08d9f6e59ef9
X-MS-TrafficTypeDiagnostic: DBAPR04MB7477:EE_
X-Microsoft-Antispam-PRVS:
	<DBAPR04MB747725123F984C6034A7A409B33C9@DBAPR04MB7477.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	2zgOHG295iw2Sedcr4OJG3j/GbeAnEW96HDS0TNykkgjAULuWW6G+1OiNjqJggvC1CgqXF289e5ocKL0hfHKltyyUT78s9w7a298eUICryk7g8y7A+lkxxoWZQazDEHc+UCIGIdzXWLSc6mW/khESwJg/OmqSs9fMuFySAwwooCnytB7nvdOjpSv+2qWhqCnupbvgXgcUmcXwp/CL15/g1Tz40Wf45C2xi9nUJ4ibLMScW/YNoX7grY0/kTglKL5aDXCiilGW2XZybzK/tUWmTHHSA7XW1ztaEAGZfe1QMe4yrFjJ82hWgONrZKrhN15409kamaGy1S0Ljf9i/xdP+DxlwllbGiCWDF5St1TXSSVSEEDoYnJfxLhE7rpvqQhgGr4aCIuoT1+ZZPKPzymbOkaUmgdvE+YcYPX6siS2QqJ9Ln8mZDN0DfTixDRnCdovCSCms01Jg/OXO7tytxnj1dcbLaYQjlWERfGE3oFgszIzGq8CaTihzI8M57UYnOZrWWHGjRGl0btMGOzWsmCQonyNi3cWQGJ/amieqJsRi4sNvjCF11dECRVG9Mfn/m4vcklIXr83APZJQYEjZTXMUPSyI0KnaVdn/PkukWvXrwdCY9xxfnWHefmv0u1Xv/GYQxg5vaipYIEWRb+hlkJUzkjlNgE5KxqN25Xlbkg/KF+vl1SAdec4tU6gdTIgv42QAyqGxhn0UxVbhqorrA+dQfUFEiYGVLc7BmGAOSfqzL4VBYf2lLSXHNfrqTnVtRi
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(31686004)(2906002)(5660300002)(4326008)(36756003)(8676002)(38100700002)(8936002)(186003)(83380400001)(6486002)(26005)(2616005)(66556008)(66946007)(66476007)(6506007)(6916009)(316002)(31696002)(86362001)(54906003)(508600001)(6512007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?eXVlNGxxWUtlV3QxVzFhUVFGWFBMYlhrSWViMkpGZ1pvenR2WTgweHBEYlRG?=
 =?utf-8?B?QUZJSVcxMEVyOThpWS9LRURDQjBsbWFqWFh2L28ya2FLUnUzbGNPUCtYK2tC?=
 =?utf-8?B?dW8xUXczVnRUV3BQbmRFZUdxR3E1ZWVWc1cxMHA4aGZKN1hMaDQyTC8wSVEx?=
 =?utf-8?B?R2x0VEQ3emZsckJubGcwY0VQMDQxWGRMeHovRXlEMC80WTk1bVMxeXFzdnZN?=
 =?utf-8?B?bXNteE01dy90djlFQ2NpVjhRWGw3SGxhNGM0bWNwWDAyWHBEdEx3S1dSN3RO?=
 =?utf-8?B?MTZIQ0VSc3VhRUVzUnVXc3FJdU00aGx5VitxMmx6Smprbk92RStlUXlXbHNa?=
 =?utf-8?B?UG81Y3F6d3NPQ3N1eWNQdS9Mc1lQeWtsTm5iRnp4YXRMeDNic2dMU1VoOGVR?=
 =?utf-8?B?aERlaW5ZMlhlN1N0UTlHdW1zaTNraC9Uc1JlYzBKSVovSTlKblRyKzB5SnF5?=
 =?utf-8?B?bXZFQjZ2aUFsNjdEc1FzN2xNb1FKblUvMjNVZ0lJNTRMUk5WSE1FYlpiVDZ2?=
 =?utf-8?B?YmhkLzBvbzcxYWFXQkpEQ016WVB0OUswMW51aHJqdnVjTENpa3l5c3FkdWFW?=
 =?utf-8?B?ZkNCM01tNUlHNnVBYmsza3kwb2FxS3N0TlRPUlFoTFY1c2pNNnRwa1RXcjMr?=
 =?utf-8?B?cW1SSDVYOU9ia0NqbFR0ZWpWQmhSbjhSNmlneTFpUEJkUm1rSlEyR1NiYnk1?=
 =?utf-8?B?aHZ1M2k1TEl2WXhIbVJEUjUwbzVsUW9PdmlQaGt1Wm5CdEtSMm5FclhLOHYy?=
 =?utf-8?B?azVraG9Bbmc0d2owL1ZoNUk4a1VrWGU1RFNSUjhRUUhwSmlMNFFuV2RXdXNk?=
 =?utf-8?B?TmZxcTN4V21MTEIybVNTaTVYQStmZHRvU1pmc2ZQZ3F1R1ZIRUpHajA3RTZv?=
 =?utf-8?B?U1kxUEcvSmlXbVQ3RVdab0lxU0RoQXBvVTlMZ3B3bTBhVDJVbFNyaXN5UmZ3?=
 =?utf-8?B?L3JDVkZKVVo2TzVYTjMxTmF3VngvcFZCZzdGVklMblFMNWxiRXIzNHlaNTBZ?=
 =?utf-8?B?UzhXc2o3b084elMzZGN4cEoxMTd6T2RSTG0weVc0MVhEbEQ2Z0hPWHE0Mno2?=
 =?utf-8?B?RVQrYlNkRmFTOXM4OVk5N242VE5BU0FIdm8rZXcyL0JWNHdxS2FPSFhTWTla?=
 =?utf-8?B?VjJ2OUpKVlRwSHZNYjF0Qm1wVk9JQ3hXL3VobXlKZWtKbnludURJQmRoeGE2?=
 =?utf-8?B?TllMbWlOaU5UZ0E2NEpqMVJVc3FSRFRxU0NVbS9MQXdlMHFGellFSjBnWDFa?=
 =?utf-8?B?VUZIRjVlK2hjZ0p0anFYTEw2a3EyckFYN01jWTlaRDlSZmgzd2xGQ3lDckRq?=
 =?utf-8?B?MEh6a3dJMG9KYUd6ekFzZk5sMmZpZURDV0xUM2QrdVlpNEVDbnMxeVFQb0Qx?=
 =?utf-8?B?VVAvMytmVllhWTNhNXhqb0xpMm1SZDloRFpZNEM1T21KazVZZVlTVnhNZFRR?=
 =?utf-8?B?NUl1dml1QzQ0bngxNHRkcGNla3ZvSzFVc1g5djI5TEFOU043L1RIYUIvOG5P?=
 =?utf-8?B?SkZndFROc2ViVjBYNXBNd2pMbW02UUJsZ0tSR1U1d0dRZmV6SkpJYW9HNm9i?=
 =?utf-8?B?TmhxYVNncTZwelVVdHViSGdXcTN3YTNWbVdxV2tpMG4ySHgvQnZNQVAyTUpz?=
 =?utf-8?B?ZnpLRkg3UFl1VWpraTk2ZGN4UkQ5UkFORXBoWlpXOHJWZVFYcW1GeGorSHpX?=
 =?utf-8?B?dW91ZHY4WFRwUFdtZGh4V1dxek1NaVhEeVB4RmlKWlQ5TVBqTG9PdUNKTXJl?=
 =?utf-8?B?c01ycDZBclhsTjk0dVZmVDQ4YmJkTnZiQTk4VzVoZUNUKzBXc2ZzMGlKc0R1?=
 =?utf-8?B?bjI2bVptVFJpWUZjSzRKNkhMZWd6TFdRckkrWGhtSkg4MFZrVFB5UWIrMlRH?=
 =?utf-8?B?RGRYTHVHQUJhTHk2UWdVS2RVT0dwdUd3NlJDcjdpckRsczNyVkZtWVkyNk1M?=
 =?utf-8?B?bjdST1R6RVNXRkdzQkhxSVZBWHMvNkFsMmJZZlNubHFrN1lpTW04YnZ1RHZT?=
 =?utf-8?B?V3ZwUTdTcVBNL2JyVGZDZ0hJUWVBZkNIZlpqQ3A0WFJqeURYaFNIVmJKM3VN?=
 =?utf-8?B?SG15enkwUFpxSExhN0VDM1hCUTYvODJyVm1LMDhsQXNscWgrQzJWTnBjMHcv?=
 =?utf-8?B?ci9KRkI2SGY1citSV1pwUkVzY3FZVXlBY3VJMTZqU01XTFk0OGxTWSs3R2RE?=
 =?utf-8?Q?xrJjOCRWxJ7S1ILnDw3NCuE=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4457a6a9-e610-4491-2e56-08d9f6e59ef9
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2022 16:00:32.6741
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eKRP3niiXXK+JF9FbjeqmfxEA4ZiN7TmuEDxBj1Z+Zg2SA0bofQvwy0krljCPVlGb8FOkBFv6IEH75SUinCRyw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7477

This also includes the two p2m related fields.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Kevin Tian <kevin.tian@intel.com>
Reviewed-by: George Dunlap <george.dunlap@citrix.com>
---
v2: Re-base.

--- a/xen/arch/x86/mm/p2m.c
+++ b/xen/arch/x86/mm/p2m.c
@@ -93,7 +93,9 @@ static int p2m_initialise(struct domain
     int ret = 0;
 
     mm_rwlock_init(&p2m->lock);
+#ifdef CONFIG_HVM
     INIT_PAGE_LIST_HEAD(&p2m->pages);
+#endif
 
     p2m->domain = d;
     p2m->default_access = p2m_access_rwx;
@@ -627,6 +629,7 @@ struct page_info *p2m_get_page_from_gfn(
 }
 
 #ifdef CONFIG_HVM
+
 /* Returns: 0 for success, -errno for failure */
 int p2m_set_entry(struct p2m_domain *p2m, gfn_t gfn, mfn_t mfn,
                   unsigned int page_order, p2m_type_t p2mt, p2m_access_t p2ma)
@@ -666,7 +669,6 @@ int p2m_set_entry(struct p2m_domain *p2m
 
     return rc;
 }
-#endif
 
 mfn_t p2m_alloc_ptp(struct p2m_domain *p2m, unsigned int level)
 {
@@ -745,6 +747,8 @@ int p2m_alloc_table(struct p2m_domain *p
     return 0;
 }
 
+#endif /* CONFIG_HVM */
+
 /*
  * hvm fixme: when adding support for pvh non-hardware domains, this path must
  * cleanup any foreign p2m types (release refcnts on them).
@@ -753,7 +757,9 @@ void p2m_teardown(struct p2m_domain *p2m
 /* Return all the p2m pages to Xen.
  * We know we don't have any extra mappings to these pages */
 {
+#ifdef CONFIG_HVM
     struct page_info *pg;
+#endif
     struct domain *d;
 
     if (p2m == NULL)
@@ -762,11 +768,16 @@ void p2m_teardown(struct p2m_domain *p2m
     d = p2m->domain;
 
     p2m_lock(p2m);
+
     ASSERT(atomic_read(&d->shr_pages) == 0);
+
+#ifdef CONFIG_HVM
     p2m->phys_table = pagetable_null();
 
     while ( (pg = page_list_remove_head(&p2m->pages)) )
         d->arch.paging.free_page(d, pg);
+#endif
+
     p2m_unlock(p2m);
 }
 
--- a/xen/arch/x86/mm/shadow/common.c
+++ b/xen/arch/x86/mm/shadow/common.c
@@ -2700,8 +2700,10 @@ int shadow_enable(struct domain *d, u32
  out_locked:
     paging_unlock(d);
  out_unlocked:
+#ifdef CONFIG_HVM
     if ( rv != 0 && !pagetable_is_null(p2m_get_pagetable(p2m)) )
         p2m_teardown(p2m);
+#endif
     if ( rv != 0 && pg != NULL )
     {
         pg->count_info &= ~PGC_count_mask;
--- a/xen/drivers/passthrough/vtd/iommu.c
+++ b/xen/drivers/passthrough/vtd/iommu.c
@@ -370,6 +370,7 @@ static uint64_t domain_pgd_maddr(struct
 
     ASSERT(spin_is_locked(&hd->arch.mapping_lock));
 
+#ifdef CONFIG_HVM
     if ( iommu_use_hap_pt(d) )
     {
         pagetable_t pgt = p2m_get_pagetable(p2m_get_hostp2m(d));
@@ -377,6 +378,7 @@ static uint64_t domain_pgd_maddr(struct
         pgd_maddr = pagetable_get_paddr(pgt);
     }
     else
+#endif
     {
         if ( !hd->arch.vtd.pgd_maddr )
         {
--- a/xen/arch/x86/include/asm/p2m.h
+++ b/xen/arch/x86/include/asm/p2m.h
@@ -208,9 +208,6 @@ struct p2m_domain {
     /* Lock that protects updates to the p2m */
     mm_rwlock_t           lock;
 
-    /* Shadow translated domain: p2m mapping */
-    pagetable_t        phys_table;
-
     /*
      * Same as a domain's dirty_cpumask but limited to
      * this p2m and those physical cpus whose vcpu's are in
@@ -229,9 +226,6 @@ struct p2m_domain {
      */
     p2m_access_t default_access;
 
-    /* Pages used to construct the p2m */
-    struct page_list_head pages;
-
     /* Host p2m: Log-dirty ranges registered for the domain. */
     struct rangeset   *logdirty_ranges;
 
@@ -239,6 +233,12 @@ struct p2m_domain {
     bool               global_logdirty;
 
 #ifdef CONFIG_HVM
+    /* Translated domain: p2m mapping */
+    pagetable_t        phys_table;
+
+    /* Pages used to construct the p2m */
+    struct page_list_head pages;
+
     /* Alternate p2m: count of vcpu's currently using this p2m. */
     atomic_t           active_vcpus;
 



From xen-devel-bounces@lists.xenproject.org Wed Feb 23 16:01:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 23 Feb 2022 16:01:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277493.474015 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMu4u-0004RD-Ic; Wed, 23 Feb 2022 16:01:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277493.474015; Wed, 23 Feb 2022 16:01:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMu4u-0004R6-Ed; Wed, 23 Feb 2022 16:01:20 +0000
Received: by outflank-mailman (input) for mailman id 277493;
 Wed, 23 Feb 2022 16:01:18 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=DZ7u=TG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nMu4s-0004Fn-MP
 for xen-devel@lists.xenproject.org; Wed, 23 Feb 2022 16:01:18 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d5b427a3-94c1-11ec-8eb8-a37418f5ba1a;
 Wed, 23 Feb 2022 17:01:17 +0100 (CET)
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur03lp2056.outbound.protection.outlook.com [104.47.9.56]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-24-x1nm9-4WNM6dlw1HnPAvaA-2; Wed, 23 Feb 2022 17:01:16 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DU2PR04MB9179.eurprd04.prod.outlook.com (2603:10a6:10:2f6::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.21; Wed, 23 Feb
 2022 16:01:14 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.022; Wed, 23 Feb 2022
 16:01:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d5b427a3-94c1-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645632077;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=2rZGfRwylNtAPsQ5UVyxgV9uPoIoLBQeDGzPZv56WOI=;
	b=MeY32wDFRHRbuA39k8rYQBh8XSVRkiUulFX+SVYoFi4FAK0WRxww85qqpmTbjZW8D7nq9D
	heuR+vsrkBckGP14M+myhklE9BlkL0HFHUs5BfKITseBGDoKnjHi44mawyyRgl9k+0p9eN
	2WJghh/B8/rzhOjqJQ3cwr8kCdKSBMQ=
X-MC-Unique: x1nm9-4WNM6dlw1HnPAvaA-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=RcVBFhziv4YjjpxvCkhrDnq3RhXBZAk1bgPBcsRv8+8iZphoNkeSKfkB+owjdb8Pz3CAIVNUQIFlRRx1IiVTVK/aPgz4qMhFMjD/ZqcjmGe02CU0YYe4wwtNoBtQMA6So3Pf/vatwWageX/4q3I52a1nrGhvVhu/yJjwIVkMKSf2gHd10ftvKHZwsJ08yoFzWaSsl09ySwNbb2whk0Vz5g2GkTYBGw8aCeXvhFhqChgBa5CGaz8UUYAhMvpIv7327MP9QHpwactc6a/PtN7zz84yJALZoy8NqRcfUjZyUQ4f/OVDRGbObUY70GheAS3256/t/P060LqWEpVUASQrpg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=2rZGfRwylNtAPsQ5UVyxgV9uPoIoLBQeDGzPZv56WOI=;
 b=lqWnLKiXzqTim2tsz0fMe/9N4JM1Atmz/3RZXaJF7EIv6Ov8q6bcWuaxX9f4uL/GixgdNHpa5sYmWPUPgcvJa5ITlcOvt3B09AXvbscJjN8ky91xR072Q8QdgvsXRGLPX03WRNIdVeKuM7hadoeC337xbKcf6FhvpkISzVJ7Bckorxc+zEeaqfS6YTT4qpJU6KnpXqJU4RH05KFilHXGo6mRpSIHFmhp8ZnOhfItHckCfVqmdys7G3B/mSXxgjyebiSNh3NtvZxnBbwU90Gq/0yWiI3AhoOh4I6ISYvlvm7yNtilCgtsco87EUCok2DjIk4dyfQCAvlPQukWQI8y6g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <556f793f-e4c2-8f05-44e9-edf8b300777d@suse.com>
Date: Wed, 23 Feb 2022 17:01:12 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: [PATCH v2 06/14] x86/P2M: PoD, altp2m, and nested-p2m are HVM-only
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>
References: <f4e3bc16-2983-6f5b-37e8-26ac385d4d72@suse.com>
In-Reply-To: <f4e3bc16-2983-6f5b-37e8-26ac385d4d72@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0251.eurprd06.prod.outlook.com
 (2603:10a6:20b:45f::28) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2f68c61e-8e29-42fe-57d2-08d9f6e5b7db
X-MS-TrafficTypeDiagnostic: DU2PR04MB9179:EE_
X-Microsoft-Antispam-PRVS:
	<DU2PR04MB9179E8893B15A8C83935E094B33C9@DU2PR04MB9179.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	2MMwojvcXXA7wozS4kgd12WMgQ0MUCZA2JXvAvEkD6Aei2DzIl3CxhRiIFiPWycirlBaV8LRzR9Ei1WwNQCJweKQ4L38pwaKvD4LP3GIOPHsqHQPhD29X4qH4OSjncSAGPNmT66lMeULN5dOZWoHByzsaM23B6fRoYUrzQXy6GW3Jt2PVRMIB1/8iVimKgd6F5qMRx4piGE8mdJOK5SQbNAK+BWV1Kbo1vRGquilirjvSMU9yRK4jnCxkchf9jYY2UaXAaPog1v73H659Gdjgy72KQNDq+T/ZhE93kGDXEOdw7ezlE1eRrJmHIMrkiP8eAG4JtT4e42frHhlMQ9RIqanvue2gcAvReSnXnLe9xJ5hzW152DBH1t/W6Y+zNG/GfcU1meB7BTDFDci8cQBFaP4achkSfsziUhRF7Ck9iUjSp72JbKKr5ncaHl4Ehg+jOOzGi5hnqbi8M5uUg3OBm46gDi0v9+J7eUOI2cio2lDAuqkeRY+Ot0lFCQbJiWAzDuDsgdgPLU20Kpo0AYLXK05j4xA8JAnuPinwuROZmGqvsuk8AZY6s09UDlGJY/XrynSlipxLb6cRZIH01+1euop1SzbSo5ycC2lMCM0DWDZLVi4viELtCScX1+kihLbAKbaQxbEVl4AuMapmGWT0w3lS2iMXghztmDP+hnf5t4ELXbKLHUcTbF7ybdtBTRdhLuv7kZDdTgOuDBkpRhnDmJcbVxa/EkbWqDGlzEowruE8OPILmhey+0RvKMlYAyfoN+URtucBW76MXBi7jH5T8ceBKSUu1smFpoRErjA1/1eEe93PSJAN8MEKPD9KQ2r4De2cCV8mkXEWICKR6R5CQ==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(86362001)(66476007)(66556008)(31696002)(6512007)(8676002)(66946007)(54906003)(4326008)(38100700002)(6916009)(316002)(186003)(508600001)(83380400001)(31686004)(6486002)(6506007)(8936002)(26005)(2906002)(2616005)(5660300002)(36756003)(2004002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZkU1TWYyem80WmtzeTdDS21lamFjSXNGK0VQQW5tenpOMEdDRUdid0FPZ29L?=
 =?utf-8?B?Rkl5eURzTDdWeitJNXc3VGxaWE5JNlN4L0puZjErdkxuWlV2S2dxVkkzL3V4?=
 =?utf-8?B?MWNLSnNRODVackROT1VlSTRnOHUybGlzaDVYQ0d6N09DY2ROZUFEQkttampQ?=
 =?utf-8?B?U2NMNyttcmJFQy9wQ0tSVThyMmNlbTczSDdteGNHY3BJSnd0UGhjdCtNbUlV?=
 =?utf-8?B?VDlIYmNJWXJJK1FPUUJITTRqcExVTTRsc1N1SmNyTE1KVG84c3JHc1VqWi9V?=
 =?utf-8?B?aDhSbDJ0ZHVlT3JJVVVyalVtN3psS3oxWE5iVFEyQVBlVkJMQjdGbUEweW5H?=
 =?utf-8?B?UGxJUUdxSUJtL3lFTTVnOVdWSnlza1RXOGwyN25VVi9QQThQRGpmQ1ZaWkpi?=
 =?utf-8?B?NTA4ak5xTlo1SUxJVWhYNmorR2NpOTB0ZU1WOTNubXhSbENiZC8xdjFGMk9X?=
 =?utf-8?B?VVVnakdVZmd4dDc4VDYwMFMzdVQwWmdyTGxmSUhIeE9VWkw3eVlGejdJeXpM?=
 =?utf-8?B?Nm5pOVU1NHVoTzd5UlZBWFlpNVNlc3RpSUVvUWIwbzNVL3NqSXVFVnlhYmh0?=
 =?utf-8?B?OWlxeWZZUjBCQ3RtWWlWaFp0T2YwdU50WXJzWGp4bC9XSXQ1V1B3a1llSlVT?=
 =?utf-8?B?ZXNiSks2b1VBNTBRRVAvM2JhRGYyKzZwUlhpSjRhTE4vRFlzNEVJZ0FZZWM2?=
 =?utf-8?B?Z3VRMjFja3ZoWXN2TFJReStGVzBoTjdaYnNrN21TeVdXNXkzdmtiYlZQM3Zh?=
 =?utf-8?B?MUxwOHBRbUpLTVJrZFBRT0lwWDBZd0hVdURIWlVHNGt6eTZKdHpmdVVBaThS?=
 =?utf-8?B?UlUzZW02NHJnLzFndnYzNmJNeHBYcFhEWnBiOXVYTnVvZkRmL2lXeEpNR0JD?=
 =?utf-8?B?TFBOV1J4T0s1T3VXVnpzcDFJWUF3QWRFNEVVT2ZGdTArN1RpbzFYRVNsMUVv?=
 =?utf-8?B?cmNRcnVVRGFXOTl5cDI0QzVTVzNaSzFVSEQzcFV5VE9PSmZmMkF0NTBqdXdJ?=
 =?utf-8?B?eG9DVzI4bmpYcFFMalZOdFdRQitMWjN1emJ1cURWRUR0T2dSSkphSG9yamlO?=
 =?utf-8?B?WUluN1hpamJGcExiNUFqNFBSY25QOHFQQjQyMGxxODBramM4RTE3OU9sVXAw?=
 =?utf-8?B?Ni9zWUY0T2M4YW0xeWMxYUx2WGo4aGk0REVBaksrb2NRcHU3NnJmcUJGeXBq?=
 =?utf-8?B?aFJxM1A1dHFwUHBwU0RwL1Q1RFc2QVJWb1orbjFXTlVpZjlBc2xjTmRSVldN?=
 =?utf-8?B?ZVpNdlVLb1BUQUgrMEJhK0RDVEZSb1FwOGExNWZDVzRBQWZuYW1ZL0h2c3d4?=
 =?utf-8?B?YU5YRG1TR2lrb2JtbzUvZmxTaTlwcnMyd21JcUQzeVVKbHl4ODREQWc3TkFl?=
 =?utf-8?B?MEoxZ09pMXR0cGZWQVJ6ZE83WjRKSzZmVFVSTzFlaHRtcStJbUZqMXNnS21O?=
 =?utf-8?B?cXdkNlRydVA1YUJOTlllcER3MXVMcXZlWjhTVmF0d2s4NFpNYlMzZzJMVnZE?=
 =?utf-8?B?NXdiMFVPa0l3SFFlYU9uVy9wcDFGOVh2OE5LTG02R1c3Z1FUc25OOW0zOWQv?=
 =?utf-8?B?U1BuNVU5TlprL1VjUTlWekpLeEhnUWpYNFhDbTc5MU5NTEtHMm44M1NRc1hu?=
 =?utf-8?B?bVcyTXZQOGxZRGlLbzZLaWJMbkdWSktRZ201czFnMk94OXd3WU93b2FnanZm?=
 =?utf-8?B?VWtqc3lIV3ZINDVDcHpxZE5zS05aSGpTTkRwTFhGV05JZkpwWFhrWmNUOUtX?=
 =?utf-8?B?NHh3cWpsUkk1cGJTL0E0bjUzaVJZNi9idWd4STVnZklydEZKNWQ5U2lPYmNs?=
 =?utf-8?B?K01xc3REKzJvbVhpN0NIUGExZGVXTDRMQ1hXRVhpWmJZWXcyN0pmQUszRWFD?=
 =?utf-8?B?VmhKZEVvNXhmR2Z0Yk5jMEhnMm43ZTJCOC9BRGJLcW9IRE1lTkthZnNQSjB5?=
 =?utf-8?B?VEdFbEFqU0JRRS9oL2p3c3BVZFFQRzBtbkdCZXRoUW5QMm0zZTdYc1J2dDJU?=
 =?utf-8?B?d3RIR2llUVNRREcwM3BRSm5QR1NDMi9CKzZMaHk1RnZkcU9VNTRaWStybU00?=
 =?utf-8?B?eC9oMkYwZUZaZkRNTkZjOVJUOFhKQnViaFo5RlBwQjZWU0oxaWxBVE0rd091?=
 =?utf-8?B?WG5taFVoYW1CZysvNUFEamVPWlJiNlhpTmd1QmwydFpKQ1JpQWtSUVU2M3VS?=
 =?utf-8?Q?IBMWfknG9mk+PNTPuVcTHnE=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2f68c61e-8e29-42fe-57d2-08d9f6e5b7db
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2022 16:01:14.3903
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 54kOxSZlZIbZ0cgNTSDnJ+jR+wqok+ZFOfpE94HyAqyZZp04s/75ezskm1rm/jzpBNEH1ZQlhg7J+H1D+rGxHw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB9179

There's no need to initialize respective data for PV domains. Note that
p2m_teardown_{alt,nested}p2m() will handle the lack-of-initialization
case fine.

As a result, despite PV domains having a host P2M associated with them
and hence using XENMEM_get_pod_target on such may not be a real problem,
calling p2m_pod_set_mem_target() for a PV domain is surely wrong, even
if benign at present. Add a guard there as well.

In p2m_pod_demand_populate() the situation is a little different: This
function is reachable only for HVM domains anyway, but following from
other PoD functions only ever acting on the host P2M (and hence PoD
entries only ever existing in host P2Ms), assert and bail from there for
non-host-P2Ms.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
v2: Also guard XENMEM_{get,set}_pod_target handling. Re-base over wider
    p2m_add_identity_entry() exposure in earlier patch. Add missing
    inclusion of "p2m.h". Mention the p2m_pod_demand_populate()
    adjustment separately in the description.
---
Perhaps p2m_pod_init() could be invoked from p2m_init_hostp2m(), leaving
all other p2m's PoD state uninitialized. Of course at that point the
question would be whether the PoD pieces of struct p2m_domain wouldn't
better move into a separate structure, present only for host P2Ms.
Together with the p2m_pod_demand_populate() adjustment this might then
better be a separate change ...

--- a/xen/arch/x86/mm/p2m.c
+++ b/xen/arch/x86/mm/p2m.c
@@ -43,6 +43,7 @@
 #include <xsm/xsm.h>
 
 #include "mm-locks.h"
+#include "p2m.h"
 
 /* Override macro from asm/page.h to make work with mfn_t */
 #undef virt_to_mfn
@@ -101,6 +102,9 @@ static int p2m_initialise(struct domain
     p2m->default_access = p2m_access_rwx;
     p2m->p2m_class = p2m_host;
 
+    if ( !is_hvm_domain(d) )
+        return 0;
+
     p2m_pod_init(p2m);
     p2m_nestedp2m_init(p2m);
 
@@ -258,7 +262,7 @@ int p2m_init(struct domain *d)
     int rc;
 
     rc = p2m_init_hostp2m(d);
-    if ( rc )
+    if ( rc || !is_hvm_domain(d) )
         return rc;
 
 #ifdef CONFIG_HVM
--- /dev/null
+++ b/xen/arch/x86/mm/p2m.h
@@ -0,0 +1,27 @@
+/******************************************************************************
+ * arch/x86/mm/p2m.h
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; If not, see <http://www.gnu.org/licenses/>.
+ */
+
+void p2m_pod_init(struct p2m_domain *p2m);
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
--- a/xen/arch/x86/mm/p2m-pod.c
+++ b/xen/arch/x86/mm/p2m-pod.c
@@ -30,6 +30,7 @@
 #include <asm/p2m.h>
 
 #include "mm-locks.h"
+#include "p2m.h"
 
 #define superpage_aligned(_x)  (((_x)&(SUPERPAGE_PAGES-1))==0)
 
@@ -1162,6 +1163,12 @@ p2m_pod_demand_populate(struct p2m_domai
     mfn_t mfn;
     unsigned long i;
 
+    if ( !p2m_is_hostp2m(p2m) )
+    {
+        ASSERT_UNREACHABLE();
+        return false;
+    }
+
     ASSERT(gfn_locked_by_me(p2m, gfn));
     pod_lock(p2m);
 
--- a/xen/arch/x86/mm.c
+++ b/xen/arch/x86/mm.c
@@ -4810,7 +4810,9 @@ long arch_memory_op(unsigned long cmd, X
         if ( d == NULL )
             return -ESRCH;
 
-        if ( cmd == XENMEM_set_pod_target )
+        if ( !is_hvm_domain(d) )
+            rc = -EINVAL;
+        else if ( cmd == XENMEM_set_pod_target )
         {
             rc = xsm_set_pod_target(XSM_PRIV, d);
             if ( rc )
--- a/xen/arch/x86/include/asm/p2m.h
+++ b/xen/arch/x86/include/asm/p2m.h
@@ -679,8 +679,6 @@ static inline long p2m_pod_entry_count(c
     return p2m->pod.entry_count;
 }
 
-void p2m_pod_init(struct p2m_domain *p2m);
-
 #else
 
 static inline bool
@@ -709,8 +707,6 @@ static inline long p2m_pod_entry_count(c
     return 0;
 }
 
-static inline void p2m_pod_init(struct p2m_domain *p2m) {}
-
 #endif
 
 



From xen-devel-bounces@lists.xenproject.org Wed Feb 23 16:01:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 23 Feb 2022 16:01:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277501.474026 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMu5S-0004xe-VY; Wed, 23 Feb 2022 16:01:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277501.474026; Wed, 23 Feb 2022 16:01:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMu5S-0004xW-RR; Wed, 23 Feb 2022 16:01:54 +0000
Received: by outflank-mailman (input) for mailman id 277501;
 Wed, 23 Feb 2022 16:01:53 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=DZ7u=TG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nMu5Q-0004wX-W5
 for xen-devel@lists.xenproject.org; Wed, 23 Feb 2022 16:01:53 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e9bb3574-94c1-11ec-8eb8-a37418f5ba1a;
 Wed, 23 Feb 2022 17:01:51 +0100 (CET)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2106.outbound.protection.outlook.com [104.47.18.106]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-33-LkOjBEtmMImzsigRdtK4dg-1; Wed, 23 Feb 2022 17:01:49 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DB6PR0401MB2358.eurprd04.prod.outlook.com (2603:10a6:4:51::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.27; Wed, 23 Feb
 2022 16:01:47 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.022; Wed, 23 Feb 2022
 16:01:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e9bb3574-94c1-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645632111;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=kfo3pz5C0VU61envUYqryzUUTaf8SbibABEgwXmQS1A=;
	b=To/TDaUDsDXdOYRqaNhhJB/eFoFahlSA/4CgfpvonTKgePSbNyDwwMQw7SKiURpIwc/78d
	iMVSFvoNuBsFo5iW1AE7rJV3sCDtEowOelgd+BIfwH7PeHnnpT6wZSLYPN+m1dL2zO00bI
	7T2wnUWu3k3L+7iLjt2c/W4yIIFsoN0=
X-MC-Unique: LkOjBEtmMImzsigRdtK4dg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=fb7R63YCslDyguUIQvOAwRdmtRrETXPnQb83PxVSl9SuaTZwpQZ2W7vunu1iGbdmkn1lhNmVeox/CZkOaFh00yDh1iKgqAzrHi9NydrMrBXnj18vMrQb5/HcWOJ51oNdftKn7/I/G63U9bl344DzD6aoaXzk5mSg/N6dl3g6V97p4UxeExklGV6NOw7JPqGHP20KwNCKQSK7HlhPoCITQve9dpulPywGx7XfAz/spMpS+W+TiLOlUeRN/uh/8r28iKEP1BCMX6fhlZuz0deyNZtbDpAtX4YdajO55XOu8S9mGUoUs3ohHoWLqCcmnqPe41YS8EWoLn/1ClrCg066+Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=kfo3pz5C0VU61envUYqryzUUTaf8SbibABEgwXmQS1A=;
 b=KBhjcWzUcuyz6mD9aUXDak2WPiyjuBnlmxKPWg07p+C5QKlZSaEJqfJh4BMJ0DuXH9AAjASpZ3Fc8B+YaPs2CpSxbj2kKqRHP8JRp47HWybXI4FxNHLQhqrvrZd0EvVC1LZzbs9GpYJObSnxfwmGDfI7gaVjFdQKFhLAuXv6UXbgFrY6KfWpxgJcc+i5yOqeutBsQVwOBhuEcGx4/UVAA3N6WVl+a21EkY5eNM7+yH1TZzES1mNqrRVzuRJQpoAAiNtB+EQWoJPw1sqocHGccMFGpaswe17YGOvY4huUCm/Dl+26+mliuxxaTDk8N+1uRKHpHz+pzCvWJId01rvooA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <88109672-c829-e083-5084-b12fc68ae39b@suse.com>
Date: Wed, 23 Feb 2022 17:01:44 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: [PATCH v2 07/14] x86/P2M: split out init/teardown functions
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Kevin Tian <kevin.tian@intel.com>,
 Jun Nakajima <jun.nakajima@intel.com>
References: <f4e3bc16-2983-6f5b-37e8-26ac385d4d72@suse.com>
In-Reply-To: <f4e3bc16-2983-6f5b-37e8-26ac385d4d72@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P194CA0069.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:209:84::46) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 589884bb-04b3-4ada-67af-08d9f6e5cb35
X-MS-TrafficTypeDiagnostic: DB6PR0401MB2358:EE_
X-Microsoft-Antispam-PRVS:
	<DB6PR0401MB2358575E15CB2B15C27FB6C7B33C9@DB6PR0401MB2358.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	RKuZlGQSLig8OeXUsVYkt44fLNwk/yCmIrfvvR01DUzhySt8pnlJe3SzCf1IxuMI2QMu3LWBB0cf6QYschvrg9h7WauquL8R40Y/pCcSwu7O1WoqXwfmroqGDWsF5YfQEycgi40kw9KchxYnhWU2Kr9y5NW0sGUkQ7FUA+EJQwBljcl85wk7+9103jXRKS6uPVG0iip6jegHuQNXhR37S49GjSOxkOy+O61Wj0b4+FVvwN+BZkX8Jy5yEb030G0DcQXlHQnO3H7fpHEIL+YBbuDv6SyOJuEuf5RUUS/M/Ag1ew+Mv1aLQuikPqdlTlhrbUQRx0DoAo/E4YROgUJnq3oh9IZRT1MAG2jSEq/1nDeajWFLkoO10m6skAh1qPK3Xmdh8m9iqyVt6PeEsHOS4tMsFXfmOREFuj3SCv7DJuWxqYHkDFUTCmCONVX5l2YdtymX49vB40DhRglid+2MKMuJ4oeRSzOST0kTE6ZX4p7J2XeEifq/Spkk6ggNYUoWM3BQlhH2Ur2+KAk5ZQMzMHFfhfwNgWk3/ETjnLuF+ZweFVUqxag+i+xYqygpbAUH6v6AT9IQHdZGnN1wf7g2yw8DX/1J1xiO8foQ9mSXZWDkcP6lWTwoB+aynWMyqMVuj2qnawPWSwiKVtnekIJ19o0xGhRopeU5g+cvE7LCSigRzB3OWlKQ888x/qsjAzgBYulWK7CVOkMOq/b9AAVAnzaqDzX2LE9oZ+wdnjIy5ZYKG3LksC7JafxdOMSBuXuP6PJEdNM0b6aRiBkD6iJCgorE6/3vlzytHOiaaUdZUGlTn5E+tgSS0t1dv32C0kcYPvhH4Zq3vzosGor2JtjbTw==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2616005)(6506007)(66946007)(8676002)(5660300002)(6512007)(83380400001)(4326008)(66556008)(186003)(6486002)(66476007)(316002)(26005)(508600001)(31686004)(36756003)(30864003)(54906003)(2906002)(6916009)(31696002)(86362001)(38100700002)(6666004)(8936002)(2004002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?WkllQWdwdFVKMmwxQjd4a0cwSXBKUVZsaUxNRXFJUzBzeGlWeDliRk9RemJB?=
 =?utf-8?B?NVdIcUVYOWcvRXBOYk0yZE10eitYbEMyZ1piOXo0MVFnMlFqNjNQT1FoTWM1?=
 =?utf-8?B?TGZtYVpMRGpUU2Jjai9nWVllOW5VMFZCUTJmOVh5K1dnZ2lJRWhLSlVaL05r?=
 =?utf-8?B?RDRTa0oxeGM4Z0JqRlE5TmtadzhCdFJkNlpGNEJQaXdXYUlxUjlzd3R6NVps?=
 =?utf-8?B?ejRDMFdFZXl2VjlmWUhTMGtVT2ZhRlRqTEtGcjhMdzdsaHk0VUFVSmc3UE5k?=
 =?utf-8?B?MkRGZlBxNlhUeFB2ZzBSclBWeXVXbTdVcW9rSE1xRFZRVSs2TjBKczluQnQ2?=
 =?utf-8?B?NVpqcVUySXZVdmhNQ3BrYlpHdFJsOXVJdytwbURIVXpEWWZUSnc4NytUZkhI?=
 =?utf-8?B?WTNlaWsvT3JrRWJYY0ZOYU5lYWJTS1ZFaitmb25RN1pNemtzMUJmZDBlMktE?=
 =?utf-8?B?ZUw3S1dHN0VzRGl0YytXeUtYRjFhRFBwN0oyblNBSEw2bHU1YStjTDZhMWk5?=
 =?utf-8?B?SG1jaEZhWFA4ZmFISE1tUS8zdmIyNHVVMjlMaXVxRWx1SUNwMjZFaTVzckZR?=
 =?utf-8?B?K0Fud3ZFd1UvaXJkSlA5SWY1bTg2ZlhBeXpRVnJram5wM2xVNlBnNVVaTmRj?=
 =?utf-8?B?L3ZlQmQ2KytkSnpFZDFoZXpXYTJCOUtJdXZlTENGZ09Bb0RGWXBsc1ArVHJP?=
 =?utf-8?B?aC9jZWwvWWdjK3N5cFpodm14YXE3dWtxS2crUCtUckRTaTV0UnlScVU2ajdK?=
 =?utf-8?B?MDd3L3FLVjIzWCt3NGJaTDczRjR3QnU3UzZIRVZtNjB1dXJjTVNtQzErT2N4?=
 =?utf-8?B?Rzh0TW9hYnd5SzZPc08yMTdDcEJqVXo5dGhhN1Y3M2pxYUZpejcwSjgrRVFa?=
 =?utf-8?B?Y3hJM2x5TkUwUEdMc0NncVZzOHhCeTdmbHRJbU5DYnRBVTB5THhZaW5qMU1M?=
 =?utf-8?B?QWthZzQwd3RCek5mTndiSDY4MWRHdSt0RTcyQ2lNNzZna01HTzIvek9taUVu?=
 =?utf-8?B?NnlVVSttRHVGWUhNbkx3aW56WmN0ZkV2NnJLZFNob3JDZHF5RHdqbkNiTXV2?=
 =?utf-8?B?bzZjdmZlcno4dDFTSlZXUjc3ZFd4bkZNMUlvMWtTRUtTV3dIZzBabVU4aHdt?=
 =?utf-8?B?T29SQzBYamxTZllyeHF5ekpkRVF5Q3hEVHo4UndzRllNNU00TW1CclVGcFNv?=
 =?utf-8?B?UkxLZml3eW93U3g1TjFkclZWT2ozM1kzdjFKZXFJb1lsb0JjNEpTQ3RUQ242?=
 =?utf-8?B?ZDl3ejBpWDNWdXBuWEZTbXIremlNMTVHeXM1aHc3YW5DM1JncnZKemZOOWxa?=
 =?utf-8?B?RDJabDVYNkZRaVo2Z2N2bXpRREZaczRvejlVa1hqeWw1Zk1WOUpZelc5dUl2?=
 =?utf-8?B?ekNCMCthUzE3UEQ3NytrVEJ3UmFCWmQ5ZFphcUF1dW1UU0kyTGtaY1FTbHcz?=
 =?utf-8?B?amZacUQ3QW5PVEFnSlczZ1B3VDUrczcrMCt0a0xnQ0ZocmhNL2FoWTlkRGh5?=
 =?utf-8?B?dGtxZU95TGtLL0V1VW1hc1VvMW9aN2dvZVBId0ZhNGNNTUphaXRPOTJCWTNJ?=
 =?utf-8?B?WFZpTzFod0Y3bVdQYkV2ektHOGFEckRpZW40a2RSUExZZUkyMURXOTJ1SytY?=
 =?utf-8?B?TDE4NHE1cm5nVkRHeGZUQjhWVUVaMk5lcm9vMytZOWwxaEFtRHJTVEZWMzN5?=
 =?utf-8?B?dS9oQzAwdzRzdlE1MjVXQUxiNlF5cU00dlNDNGk0SjVjd2ZpV1NhOEhzMElz?=
 =?utf-8?B?L0RTVjJtdFhSc0pVeVUxUTd0QmRJTTVHUGhqdFgxS3VVcFFoSVQzWkdWcFFm?=
 =?utf-8?B?NWRFeURXTkozMTNiam5ZY1dhOTlkY1FTTUJyNTRFSnRUWG9pcDFQOHJSTHhm?=
 =?utf-8?B?UUZrOXNxSGJidXliRG1RTExGdDNndnFZZFhMbWVCTnBFeGk4aFQyVEoxVlIr?=
 =?utf-8?B?RUV4TUtualhEUDd3MmpJbkdVTEhuK0tCMTlKOUI5WEYxTUxXbDBrekIyeURk?=
 =?utf-8?B?aDl1RkhwZTdGNUxCeGUwcnRvWXVYbnp0YUxVZFJ5UUVZbUlxL2ROUXp2dy9Z?=
 =?utf-8?B?VzJyZlFLalRBZUxacGdnQ3N1ZU55dXBhemgrVi91UDhuUU9tbTRtS1c0MTln?=
 =?utf-8?B?aHFvaDVjOFdHWm5nVVd5dElHUE0yV2NSVDA2WXFIM3RFYW9hQjZGeW5pTkNX?=
 =?utf-8?Q?9Iz2FEUy2eKLFwoRt9kO4Pc=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 589884bb-04b3-4ada-67af-08d9f6e5cb35
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2022 16:01:46.8104
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xx/eBZ9fyL2DRKznAJZ6Sjjub6W9q0KbPrftzL757t/93pDbtIo+sFd8BmxdSajgj3MlpauhiDx6O/AeodxI2g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0401MB2358

Mostly just code movement, and certainly no functional change intended.
In p2m_final_teardown() the calls to p2m_teardown_{alt,nested}p2m() need
to be guarded by an is_hvm_domain() check now, though. This matches
p2m_init(). And p2m_is_logdirty_range() also gets moved inside the (so
far) adjacent #ifdef.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: George Dunlap <george.dunlap@citrix.com>
---
v2: Re-base over wider p2m_add_identity_entry() exposure in earlier
    patch.

--- a/xen/arch/x86/mm/Makefile
+++ b/xen/arch/x86/mm/Makefile
@@ -7,7 +7,9 @@ obj-$(CONFIG_SHADOW_PAGING) += guest_wal
 obj-$(CONFIG_MEM_ACCESS) += mem_access.o
 obj-$(CONFIG_MEM_PAGING) += mem_paging.o
 obj-$(CONFIG_MEM_SHARING) += mem_sharing.o
+obj-$(CONFIG_HVM) += nested.o
 obj-y += p2m.o
+obj-y += p2m-basic.o
 obj-$(CONFIG_HVM) += p2m-ept.o p2m-pod.o p2m-pt.o
 obj-y += paging.o
 obj-y += physmap.o
--- a/xen/arch/x86/mm/altp2m.c
+++ b/xen/arch/x86/mm/altp2m.c
@@ -19,6 +19,8 @@
 #include <asm/hvm/hvm.h>
 #include <asm/p2m.h>
 #include <asm/altp2m.h>
+#include "mm-locks.h"
+#include "p2m.h"
 
 void
 altp2m_vcpu_initialise(struct vcpu *v)
@@ -123,6 +125,44 @@ void altp2m_vcpu_disable_ve(struct vcpu
     }
 }
 
+int p2m_init_altp2m(struct domain *d)
+{
+    unsigned int i;
+    struct p2m_domain *p2m;
+    struct p2m_domain *hostp2m = p2m_get_hostp2m(d);
+
+    mm_lock_init(&d->arch.altp2m_list_lock);
+    for ( i = 0; i < MAX_ALTP2M; i++ )
+    {
+        d->arch.altp2m_p2m[i] = p2m = p2m_init_one(d);
+        if ( p2m == NULL )
+        {
+            p2m_teardown_altp2m(d);
+            return -ENOMEM;
+        }
+        p2m->p2m_class = p2m_alternate;
+        p2m->access_required = hostp2m->access_required;
+        _atomic_set(&p2m->active_vcpus, 0);
+    }
+
+    return 0;
+}
+
+void p2m_teardown_altp2m(struct domain *d)
+{
+    unsigned int i;
+    struct p2m_domain *p2m;
+
+    for ( i = 0; i < MAX_ALTP2M; i++ )
+    {
+        if ( !d->arch.altp2m_p2m[i] )
+            continue;
+        p2m = d->arch.altp2m_p2m[i];
+        d->arch.altp2m_p2m[i] = NULL;
+        p2m_free_one(p2m);
+    }
+}
+
 /*
  * Local variables:
  * mode: C
--- a/xen/arch/x86/mm/mm-locks.h
+++ b/xen/arch/x86/mm/mm-locks.h
@@ -25,8 +25,6 @@
 #ifndef _MM_LOCKS_H
 #define _MM_LOCKS_H
 
-#include <asm/mem_sharing.h>
-
 /* Per-CPU variable for enforcing the lock ordering */
 DECLARE_PER_CPU(int, mm_lock_level);
 
--- /dev/null
+++ b/xen/arch/x86/mm/nested.c
@@ -0,0 +1,74 @@
+/******************************************************************************
+ * arch/x86/mm/nested.c
+ *
+ * Parts of this code are Copyright (c) 2009 by Citrix Systems, Inc. (Patrick Colp)
+ * Parts of this code are Copyright (c) 2007 by Advanced Micro Devices.
+ * Parts of this code are Copyright (c) 2006-2007 by XenSource Inc.
+ * Parts of this code are Copyright (c) 2006 by Michael A Fetterman
+ * Parts based on earlier work by Michael A Fetterman, Ian Pratt et al.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#include <xen/sched.h>
+#include <asm/p2m.h>
+#include "mm-locks.h"
+#include "p2m.h"
+
+void p2m_nestedp2m_init(struct p2m_domain *p2m)
+{
+    INIT_LIST_HEAD(&p2m->np2m_list);
+
+    p2m->np2m_base = P2M_BASE_EADDR;
+    p2m->np2m_generation = 0;
+}
+
+int p2m_init_nestedp2m(struct domain *d)
+{
+    unsigned int i;
+    struct p2m_domain *p2m;
+
+    mm_lock_init(&d->arch.nested_p2m_lock);
+    for ( i = 0; i < MAX_NESTEDP2M; i++ )
+    {
+        d->arch.nested_p2m[i] = p2m = p2m_init_one(d);
+        if ( p2m == NULL )
+        {
+            p2m_teardown_nestedp2m(d);
+            return -ENOMEM;
+        }
+        p2m->p2m_class = p2m_nested;
+        p2m->write_p2m_entry_pre = NULL;
+        p2m->write_p2m_entry_post = nestedp2m_write_p2m_entry_post;
+        list_add(&p2m->np2m_list, &p2m_get_hostp2m(d)->np2m_list);
+    }
+
+    return 0;
+}
+
+void p2m_teardown_nestedp2m(struct domain *d)
+{
+    unsigned int i;
+    struct p2m_domain *p2m;
+
+    for ( i = 0; i < MAX_NESTEDP2M; i++ )
+    {
+        if ( !d->arch.nested_p2m[i] )
+            continue;
+        p2m = d->arch.nested_p2m[i];
+        list_del(&p2m->np2m_list);
+        p2m_free_one(p2m);
+        d->arch.nested_p2m[i] = NULL;
+    }
+}
--- a/xen/arch/x86/mm/p2m.c
+++ b/xen/arch/x86/mm/p2m.c
@@ -35,7 +35,6 @@
 #include <asm/page.h>
 #include <asm/paging.h>
 #include <asm/p2m.h>
-#include <asm/hvm/vmx/vmx.h> /* ept_p2m_init() */
 #include <asm/mem_sharing.h>
 #include <asm/hvm/nestedhvm.h>
 #include <asm/altp2m.h>
@@ -56,17 +55,9 @@ boolean_param("hap_2mb", opt_hap_2mb);
 
 DEFINE_PERCPU_RWLOCK_GLOBAL(p2m_percpu_rwlock);
 
-static void p2m_nestedp2m_init(struct p2m_domain *p2m)
-{
 #ifdef CONFIG_HVM
-    INIT_LIST_HEAD(&p2m->np2m_list);
 
-    p2m->np2m_base = P2M_BASE_EADDR;
-    p2m->np2m_generation = 0;
-#endif
-}
-
-static int p2m_init_logdirty(struct p2m_domain *p2m)
+int p2m_init_logdirty(struct p2m_domain *p2m)
 {
     if ( p2m->logdirty_ranges )
         return 0;
@@ -79,7 +70,7 @@ static int p2m_init_logdirty(struct p2m_
     return 0;
 }
 
-static void p2m_free_logdirty(struct p2m_domain *p2m)
+void p2m_free_logdirty(struct p2m_domain *p2m)
 {
     if ( !p2m->logdirty_ranges )
         return;
@@ -88,205 +79,6 @@ static void p2m_free_logdirty(struct p2m
     p2m->logdirty_ranges = NULL;
 }
 
-/* Init the datastructures for later use by the p2m code */
-static int p2m_initialise(struct domain *d, struct p2m_domain *p2m)
-{
-    int ret = 0;
-
-    mm_rwlock_init(&p2m->lock);
-#ifdef CONFIG_HVM
-    INIT_PAGE_LIST_HEAD(&p2m->pages);
-#endif
-
-    p2m->domain = d;
-    p2m->default_access = p2m_access_rwx;
-    p2m->p2m_class = p2m_host;
-
-    if ( !is_hvm_domain(d) )
-        return 0;
-
-    p2m_pod_init(p2m);
-    p2m_nestedp2m_init(p2m);
-
-    if ( hap_enabled(d) && cpu_has_vmx )
-        ret = ept_p2m_init(p2m);
-    else
-        p2m_pt_init(p2m);
-
-    spin_lock_init(&p2m->ioreq.lock);
-
-    return ret;
-}
-
-static struct p2m_domain *p2m_init_one(struct domain *d)
-{
-    struct p2m_domain *p2m = xzalloc(struct p2m_domain);
-
-    if ( !p2m )
-        return NULL;
-
-    if ( !zalloc_cpumask_var(&p2m->dirty_cpumask) )
-        goto free_p2m;
-
-    if ( p2m_initialise(d, p2m) )
-        goto free_cpumask;
-    return p2m;
-
-free_cpumask:
-    free_cpumask_var(p2m->dirty_cpumask);
-free_p2m:
-    xfree(p2m);
-    return NULL;
-}
-
-static void p2m_free_one(struct p2m_domain *p2m)
-{
-    p2m_free_logdirty(p2m);
-    if ( hap_enabled(p2m->domain) && cpu_has_vmx )
-        ept_p2m_uninit(p2m);
-    free_cpumask_var(p2m->dirty_cpumask);
-    xfree(p2m);
-}
-
-static int p2m_init_hostp2m(struct domain *d)
-{
-    struct p2m_domain *p2m = p2m_init_one(d);
-    int rc;
-
-    if ( !p2m )
-        return -ENOMEM;
-
-    rc = p2m_init_logdirty(p2m);
-
-    if ( !rc )
-        d->arch.p2m = p2m;
-    else
-        p2m_free_one(p2m);
-
-    return rc;
-}
-
-static void p2m_teardown_hostp2m(struct domain *d)
-{
-    /* Iterate over all p2m tables per domain */
-    struct p2m_domain *p2m = p2m_get_hostp2m(d);
-
-    if ( p2m )
-    {
-        p2m_free_one(p2m);
-        d->arch.p2m = NULL;
-    }
-}
-
-#ifdef CONFIG_HVM
-static void p2m_teardown_nestedp2m(struct domain *d)
-{
-    unsigned int i;
-    struct p2m_domain *p2m;
-
-    for ( i = 0; i < MAX_NESTEDP2M; i++ )
-    {
-        if ( !d->arch.nested_p2m[i] )
-            continue;
-        p2m = d->arch.nested_p2m[i];
-        list_del(&p2m->np2m_list);
-        p2m_free_one(p2m);
-        d->arch.nested_p2m[i] = NULL;
-    }
-}
-
-static int p2m_init_nestedp2m(struct domain *d)
-{
-    unsigned int i;
-    struct p2m_domain *p2m;
-
-    mm_lock_init(&d->arch.nested_p2m_lock);
-    for ( i = 0; i < MAX_NESTEDP2M; i++ )
-    {
-        d->arch.nested_p2m[i] = p2m = p2m_init_one(d);
-        if ( p2m == NULL )
-        {
-            p2m_teardown_nestedp2m(d);
-            return -ENOMEM;
-        }
-        p2m->p2m_class = p2m_nested;
-        p2m->write_p2m_entry_pre = NULL;
-        p2m->write_p2m_entry_post = nestedp2m_write_p2m_entry_post;
-        list_add(&p2m->np2m_list, &p2m_get_hostp2m(d)->np2m_list);
-    }
-
-    return 0;
-}
-
-static void p2m_teardown_altp2m(struct domain *d)
-{
-    unsigned int i;
-    struct p2m_domain *p2m;
-
-    for ( i = 0; i < MAX_ALTP2M; i++ )
-    {
-        if ( !d->arch.altp2m_p2m[i] )
-            continue;
-        p2m = d->arch.altp2m_p2m[i];
-        d->arch.altp2m_p2m[i] = NULL;
-        p2m_free_one(p2m);
-    }
-}
-
-static int p2m_init_altp2m(struct domain *d)
-{
-    unsigned int i;
-    struct p2m_domain *p2m;
-    struct p2m_domain *hostp2m = p2m_get_hostp2m(d);
-
-    mm_lock_init(&d->arch.altp2m_list_lock);
-    for ( i = 0; i < MAX_ALTP2M; i++ )
-    {
-        d->arch.altp2m_p2m[i] = p2m = p2m_init_one(d);
-        if ( p2m == NULL )
-        {
-            p2m_teardown_altp2m(d);
-            return -ENOMEM;
-        }
-        p2m->p2m_class = p2m_alternate;
-        p2m->access_required = hostp2m->access_required;
-        _atomic_set(&p2m->active_vcpus, 0);
-    }
-
-    return 0;
-}
-#endif
-
-int p2m_init(struct domain *d)
-{
-    int rc;
-
-    rc = p2m_init_hostp2m(d);
-    if ( rc || !is_hvm_domain(d) )
-        return rc;
-
-#ifdef CONFIG_HVM
-    /* Must initialise nestedp2m unconditionally
-     * since nestedhvm_enabled(d) returns false here.
-     * (p2m_init runs too early for HVM_PARAM_* options) */
-    rc = p2m_init_nestedp2m(d);
-    if ( rc )
-    {
-        p2m_teardown_hostp2m(d);
-        return rc;
-    }
-
-    rc = p2m_init_altp2m(d);
-    if ( rc )
-    {
-        p2m_teardown_hostp2m(d);
-        p2m_teardown_nestedp2m(d);
-    }
-#endif
-
-    return rc;
-}
-
 int p2m_is_logdirty_range(struct p2m_domain *p2m, unsigned long start,
                           unsigned long end)
 {
@@ -298,8 +90,6 @@ int p2m_is_logdirty_range(struct p2m_dom
     return 0;
 }
 
-#ifdef CONFIG_HVM
-
 static void change_entry_type_global(struct p2m_domain *p2m,
                                      p2m_type_t ot, p2m_type_t nt)
 {
@@ -751,57 +541,6 @@ int p2m_alloc_table(struct p2m_domain *p
     return 0;
 }
 
-#endif /* CONFIG_HVM */
-
-/*
- * hvm fixme: when adding support for pvh non-hardware domains, this path must
- * cleanup any foreign p2m types (release refcnts on them).
- */
-void p2m_teardown(struct p2m_domain *p2m)
-/* Return all the p2m pages to Xen.
- * We know we don't have any extra mappings to these pages */
-{
-#ifdef CONFIG_HVM
-    struct page_info *pg;
-#endif
-    struct domain *d;
-
-    if (p2m == NULL)
-        return;
-
-    d = p2m->domain;
-
-    p2m_lock(p2m);
-
-    ASSERT(atomic_read(&d->shr_pages) == 0);
-
-#ifdef CONFIG_HVM
-    p2m->phys_table = pagetable_null();
-
-    while ( (pg = page_list_remove_head(&p2m->pages)) )
-        d->arch.paging.free_page(d, pg);
-#endif
-
-    p2m_unlock(p2m);
-}
-
-void p2m_final_teardown(struct domain *d)
-{
-#ifdef CONFIG_HVM
-    /*
-     * We must teardown both of them unconditionally because
-     * we initialise them unconditionally.
-     */
-    p2m_teardown_altp2m(d);
-    p2m_teardown_nestedp2m(d);
-#endif
-
-    /* Iterate over all p2m tables per domain */
-    p2m_teardown_hostp2m(d);
-}
-
-#ifdef CONFIG_HVM
-
 static int __must_check
 p2m_remove_entry(struct p2m_domain *p2m, gfn_t gfn, mfn_t mfn,
                  unsigned int page_order)
--- a/xen/arch/x86/mm/p2m.h
+++ b/xen/arch/x86/mm/p2m.h
@@ -15,8 +15,30 @@
  * along with this program; If not, see <http://www.gnu.org/licenses/>.
  */
 
+struct p2m_domain *p2m_init_one(struct domain *d);
+void p2m_free_one(struct p2m_domain *p2m);
+
 void p2m_pod_init(struct p2m_domain *p2m);
 
+#ifdef CONFIG_HVM
+int p2m_init_logdirty(struct p2m_domain *p2m);
+void p2m_free_logdirty(struct p2m_domain *p2m);
+#else
+static inline int p2m_init_logdirty(struct p2m_domain *p2m) { return 0; }
+static inline void p2m_free_logdirty(struct p2m_domain *p2m) {}
+#endif
+
+int p2m_init_altp2m(struct domain *d);
+void p2m_teardown_altp2m(struct domain *d);
+
+void p2m_nestedp2m_init(struct p2m_domain *p2m);
+int p2m_init_nestedp2m(struct domain *d);
+void p2m_teardown_nestedp2m(struct domain *d);
+
+int ept_p2m_init(struct p2m_domain *p2m);
+void ept_p2m_uninit(struct p2m_domain *p2m);
+void p2m_init_altp2m_ept(struct domain *d, unsigned int i);
+
 /*
  * Local variables:
  * mode: C
--- /dev/null
+++ b/xen/arch/x86/mm/p2m-basic.c
@@ -0,0 +1,207 @@
+/******************************************************************************
+ * arch/x86/mm/p2m-basic.c
+ *
+ * Basic P2M management largely applicable to all domain types.
+ *
+ * Parts of this code are Copyright (c) 2009 by Citrix Systems, Inc. (Patrick Colp)
+ * Parts of this code are Copyright (c) 2007 by Advanced Micro Devices.
+ * Parts of this code are Copyright (c) 2006-2007 by XenSource Inc.
+ * Parts of this code are Copyright (c) 2006 by Michael A Fetterman
+ * Parts based on earlier work by Michael A Fetterman, Ian Pratt et al.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#include <xen/types.h>
+#include <asm/p2m.h>
+#include "mm-locks.h"
+#include "p2m.h"
+
+/* Init the datastructures for later use by the p2m code */
+static int p2m_initialise(struct domain *d, struct p2m_domain *p2m)
+{
+    int ret = 0;
+
+    mm_rwlock_init(&p2m->lock);
+#ifdef CONFIG_HVM
+    INIT_PAGE_LIST_HEAD(&p2m->pages);
+#endif
+
+    p2m->domain = d;
+    p2m->default_access = p2m_access_rwx;
+    p2m->p2m_class = p2m_host;
+
+    if ( !is_hvm_domain(d) )
+        return 0;
+
+    p2m_pod_init(p2m);
+    p2m_nestedp2m_init(p2m);
+
+    if ( hap_enabled(d) && cpu_has_vmx )
+        ret = ept_p2m_init(p2m);
+    else
+        p2m_pt_init(p2m);
+
+    spin_lock_init(&p2m->ioreq.lock);
+
+    return ret;
+}
+
+struct p2m_domain *p2m_init_one(struct domain *d)
+{
+    struct p2m_domain *p2m = xzalloc(struct p2m_domain);
+
+    if ( !p2m )
+        return NULL;
+
+    if ( !zalloc_cpumask_var(&p2m->dirty_cpumask) )
+        goto free_p2m;
+
+    if ( p2m_initialise(d, p2m) )
+        goto free_cpumask;
+    return p2m;
+
+ free_cpumask:
+    free_cpumask_var(p2m->dirty_cpumask);
+ free_p2m:
+    xfree(p2m);
+    return NULL;
+}
+
+void p2m_free_one(struct p2m_domain *p2m)
+{
+    p2m_free_logdirty(p2m);
+    if ( hap_enabled(p2m->domain) && cpu_has_vmx )
+        ept_p2m_uninit(p2m);
+    free_cpumask_var(p2m->dirty_cpumask);
+    xfree(p2m);
+}
+
+static int p2m_init_hostp2m(struct domain *d)
+{
+    struct p2m_domain *p2m = p2m_init_one(d);
+    int rc;
+
+    if ( !p2m )
+        return -ENOMEM;
+
+    rc = p2m_init_logdirty(p2m);
+
+    if ( !rc )
+        d->arch.p2m = p2m;
+    else
+        p2m_free_one(p2m);
+
+    return rc;
+}
+
+static void p2m_teardown_hostp2m(struct domain *d)
+{
+    /* Iterate over all p2m tables per domain */
+    struct p2m_domain *p2m = p2m_get_hostp2m(d);
+
+    if ( p2m )
+    {
+        p2m_free_one(p2m);
+        d->arch.p2m = NULL;
+    }
+}
+
+int p2m_init(struct domain *d)
+{
+    int rc;
+
+    rc = p2m_init_hostp2m(d);
+    if ( rc || !is_hvm_domain(d) )
+        return rc;
+
+    /*
+     * Must initialise nestedp2m unconditionally
+     * since nestedhvm_enabled(d) returns false here.
+     * (p2m_init runs too early for HVM_PARAM_* options)
+     */
+    rc = p2m_init_nestedp2m(d);
+    if ( rc )
+    {
+        p2m_teardown_hostp2m(d);
+        return rc;
+    }
+
+    rc = p2m_init_altp2m(d);
+    if ( rc )
+    {
+        p2m_teardown_hostp2m(d);
+        p2m_teardown_nestedp2m(d);
+    }
+
+    return rc;
+}
+
+/*
+ * Return all the p2m pages to Xen.
+ * We know we don't have any extra mappings to these pages.
+ *
+ * hvm fixme: when adding support for pvh non-hardware domains, this path must
+ * cleanup any foreign p2m types (release refcnts on them).
+ */
+void p2m_teardown(struct p2m_domain *p2m)
+{
+#ifdef CONFIG_HVM
+    struct page_info *pg;
+#endif
+    struct domain *d;
+
+    if ( !p2m )
+        return;
+
+    d = p2m->domain;
+
+    p2m_lock(p2m);
+
+    ASSERT(atomic_read(&d->shr_pages) == 0);
+
+#ifdef CONFIG_HVM
+    p2m->phys_table = pagetable_null();
+
+    while ( (pg = page_list_remove_head(&p2m->pages)) )
+        d->arch.paging.free_page(d, pg);
+#endif
+
+    p2m_unlock(p2m);
+}
+
+void p2m_final_teardown(struct domain *d)
+{
+    if ( is_hvm_domain(d) )
+    {
+        /*
+         * We must tear down both of them unconditionally because
+         * we initialise them unconditionally.
+         */
+        p2m_teardown_altp2m(d);
+        p2m_teardown_nestedp2m(d);
+    }
+
+    /* Iterate over all p2m tables per domain */
+    p2m_teardown_hostp2m(d);
+}
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
--- a/xen/arch/x86/mm/p2m-ept.c
+++ b/xen/arch/x86/mm/p2m-ept.c
@@ -35,6 +35,7 @@
 #include <xen/softirq.h>
 
 #include "mm-locks.h"
+#include "p2m.h"
 
 #define atomic_read_ept_entry(__pepte)                              \
     ( (ept_entry_t) { .epte = read_atomic(&(__pepte)->epte) } )
--- a/xen/arch/x86/include/asm/hvm/vmx/vmx.h
+++ b/xen/arch/x86/include/asm/hvm/vmx/vmx.h
@@ -594,15 +594,11 @@ unsigned int vmx_get_cpl(void);
 void vmx_inject_extint(int trap, uint8_t source);
 void vmx_inject_nmi(void);
 
-int ept_p2m_init(struct p2m_domain *p2m);
-void ept_p2m_uninit(struct p2m_domain *p2m);
-
 void ept_walk_table(struct domain *d, unsigned long gfn);
 bool_t ept_handle_misconfig(uint64_t gpa);
 int epte_get_entry_emt(struct domain *d, gfn_t gfn, mfn_t mfn,
                        unsigned int order, bool *ipat, p2m_type_t type);
 void setup_ept_dump(void);
-void p2m_init_altp2m_ept(struct domain *d, unsigned int i);
 /* Locate an alternate p2m by its EPTP */
 unsigned int p2m_find_altp2m_by_eptp(struct domain *d, uint64_t eptp);
 



From xen-devel-bounces@lists.xenproject.org Wed Feb 23 16:02:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 23 Feb 2022 16:02:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277510.474037 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMu6K-0005hh-8b; Wed, 23 Feb 2022 16:02:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277510.474037; Wed, 23 Feb 2022 16:02:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMu6K-0005ha-5a; Wed, 23 Feb 2022 16:02:48 +0000
Received: by outflank-mailman (input) for mailman id 277510;
 Wed, 23 Feb 2022 16:02:47 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=DZ7u=TG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nMu6J-0004uA-8j
 for xen-devel@lists.xenproject.org; Wed, 23 Feb 2022 16:02:47 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0a9503e7-94c2-11ec-8539-5f4723681683;
 Wed, 23 Feb 2022 17:02:46 +0100 (CET)
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur03lp2054.outbound.protection.outlook.com [104.47.9.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-8-UhdHrXFQPNGFmR2seDZxmA-1; Wed, 23 Feb 2022 17:02:45 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DBBPR04MB6156.eurprd04.prod.outlook.com (2603:10a6:10:cd::13) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.27; Wed, 23 Feb
 2022 16:02:43 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.022; Wed, 23 Feb 2022
 16:02:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0a9503e7-94c2-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645632166;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=W6vAYToK8QO3swRu/19GKo63qRHFt41aiy10HV87R7U=;
	b=FKtt+k/mt/W+HNiCn7IqiNH/mvosaAO0HkT6eWGF+gI3PTZZDpnP85jOD/gac/qvNi+lZW
	T+ZVPiWq2VSNfOdnd1mMfyN33bLItT3TWGabeve+rQVemnuRlcbO3LYIyG7srQiZbHks7H
	A2r7L8XINSNXVCkq+DYZsVv+lt5OkYM=
X-MC-Unique: UhdHrXFQPNGFmR2seDZxmA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=lE4M7Y/E/EP4dRAhwGVx8/HAqVZLMIdBfzh7Mjn73NQPOCKJX6BDq7NC3euvsWkcOwmW5KoYv7CkEKMnMc43qqz+QrnqxWV6nfOr4dNxLz4b+DZZWTq46++M7ywXhV5GyYL7eniXhlRv5pTgg2c7CHvO7koqLguMMqtg1EOfoLhSyJlayKp6xwQ96vsoQfEIvXnpu4BvZfA0867nyfYKRhaqB5LOWB0vOohh4K7cN7RUjyHfk+919pe5d9ajPyTsBAXlgSBRIou0QjiE3u3BwgPUJOEJHKAC/rclBFX7A94BneWZiNcCHOeChpKw7JENVNqaLm0oVuOzpl/0J3scEw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=W6vAYToK8QO3swRu/19GKo63qRHFt41aiy10HV87R7U=;
 b=anDDHc1VaUb5kZu1bNmewLVkzc8jAVze05qw7bfD3BZADPX4sSWrEMOR3ftTqbl99nvIyIHdvVWgDAO8hIgCLvTmje0WWJrdAdQJoMe7iMPrvhL+qPrB4gdjk/lu6cWQcYDiCN6sBdOMhBwyy18GHG3ElXk1AMXRjlO9k/G/F3Dgzn34vuBlSwjrVjwb6ltr1V+qy5XUaMWyqO0/2lqGIz5Fxpewb2yYP/Cnj2rtOtfIU8EiMbCv8rcHlgnlrm8wJfOvds6ZGywnAZMbLmdzSUXyR4KZ4C13Sw9Cry4M/aYsknq/o0+GaZ6uZAOufhYsRZceW0to5DWVqMDC3es6Xg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <04b5ed35-ba53-a0d5-3583-a474f7d08c06@suse.com>
Date: Wed, 23 Feb 2022 17:02:40 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: [PATCH v2 08/14] x86/P2M: p2m_get_page_from_gfn() is HVM-only
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>
References: <f4e3bc16-2983-6f5b-37e8-26ac385d4d72@suse.com>
In-Reply-To: <f4e3bc16-2983-6f5b-37e8-26ac385d4d72@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0108.eurprd04.prod.outlook.com
 (2603:10a6:20b:31e::23) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 102f8c07-b6a1-4031-99a6-08d9f6e5ecb9
X-MS-TrafficTypeDiagnostic: DBBPR04MB6156:EE_
X-Microsoft-Antispam-PRVS:
	<DBBPR04MB61564711C0CA7E3DCF657100B33C9@DBBPR04MB6156.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	AklIItO4QQvKgTTeBw0ZzGpv/xr35tCmmrbmra+xRNjeyaL1RX925QaO8wWp93JWLYGD/GI95oFMtWSeOcNWE2CwpO3UCpdVUJhydtpbSc9CSVUNlR+OWIx7jnS4o7EqQetL56z48n58Eo7F6/koREEmPou2EQoWU2q3us9iWtN4bvD1YpdW2TcMRxfldYPVYxKprlbWYfaPRbYZinJT7YKzzDEK/Q9X8jNkqrKpP1q1SX93GMj661F0MKMGujbzgcA2hCdGQuSGu3MBP4N+8LS23OtR2kPZRjKZ0YAbJa99a4jZKZZdIYG3kJRRCr/pGdeCbL8fHxyTIakqppH0GA9iJXYguUNynKFQYiuj07rLOb05kMNS8imllH3vg9V8AJOF6UVY+SIbzz8P5btiUcQmXrckoUgVfpT46BilGnSuMZy4IEMVcdEE3nZzaPwLJW8tfU3eo1ajnZsLLElvFwBsVz0EHJ1YM5qYtC89opGcXxQmJMwM4IteaPgPNbl8S0/rllQInRtYzzRIS0YlHihmHVwtFM5o57NLyTvi/YnKq84nF1VhPbtZj2KXiaNKoq9citnVrRiocF0Hom/PSNCZ8JlJ+xMdybkjiRFatC4IjsWjSvQ36JEGdF6AsNvGrnPK0GTZR4hZLbn8AHUymA/+LqOd/nu+Vi353Eesj2sHmebMS5U3I0h+VdtAoLmfy3E3xkuFtBq3AV9qendC6hQ3RE/BKCm5JQXtcKr2FfZ19P9S8Ec7XYTYf+UIT9yu
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(36756003)(6506007)(2616005)(6486002)(508600001)(31686004)(6512007)(2906002)(38100700002)(66556008)(66476007)(4326008)(5660300002)(54906003)(6916009)(8936002)(26005)(8676002)(316002)(31696002)(86362001)(186003)(83380400001)(66946007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?R2RLM0RTaENxaTJWR29BV3dsWDl6UzBZUHh4bUUvL1owMlBIRzNWWko4cDBj?=
 =?utf-8?B?NzZmYlFCUzNNYWVGeGg2WlhhWlZsS1BOc1p6bHV5SDg3TjVpNFUyc0ZRQnls?=
 =?utf-8?B?UVVuZVhLQm0raTZNL0tlS3V4QzNmenBDeFUyWEEyZVkvWTlEZ1NYMzJ2ZXpO?=
 =?utf-8?B?OG9ybE1oM3NuQzZqbWRVSlBvbHRnT1gwNFJpN0NsZklGYzV0bGRUS3RBTTc4?=
 =?utf-8?B?eHhlWGJ3RWpTOGdDbEdYd0xOV1l0c0dIanJzWllsMUJYN1U0NjB5YkFJck8x?=
 =?utf-8?B?TWJJR0JBVEFoUDZET1A5dXZiWkF2dEE3bm9BWDRCd2trNUcwaFpZVjJicUo4?=
 =?utf-8?B?dW1tREVnRUNrNk0wZ0VMMVV0S0l5bjl1Wlhyc1FlUzJZRVNGcXd4RTBOQllI?=
 =?utf-8?B?TnAwdms0M0hEN3RMZzFmNTV1WHZ5VHpWdTViS1phcEJ6YkNZQ1d0VGVxR0NF?=
 =?utf-8?B?UzZpcFJHMlIrdC9RREtTUEpoZDIxenRwZHgvU0xXS1hEaXhhTC9hL05KZkpQ?=
 =?utf-8?B?SWE0Wkh0dldUOGtzazZkV2ZkQW44ZTN5NE5FQkZ4NisyN3VNbW5yODR6LzA1?=
 =?utf-8?B?V3M4emplcXRyblNWMlNwRmsyT1BkRG1USDN4aHdUMlMzaXRiNlkxRUNiWXky?=
 =?utf-8?B?b2Vyd0N3TTZTd2MrOFpPZ0F2RjVpRHp3cmVmdXE3RVdDM3RQcTAwNEpPMlVM?=
 =?utf-8?B?cENCREd6U1VsMUpBUmtiT01sR1RXdkcrTTZ1enFVRzJBaHhhWStzV29ReW96?=
 =?utf-8?B?TSt6bnlaZlUwRHY5UUFYZGtHSjlESmgyNVEzWk11TkNYdzBSSGhEczhtazkv?=
 =?utf-8?B?UzdwUUxhYmhVRmdvSTBjK3E1THRSNkd3MXB4N3VvcmhucW5tZXYzbkV5R1ph?=
 =?utf-8?B?bTJraWxoYUhDWktBdWtLdXczVS9kSkxNQVBaTnhjRTBoTTdlOUFObzZlTlNE?=
 =?utf-8?B?YWpTN1BmdkV6NnBNM0xuaDA3YVByVzdvK2Q3cTZjWW1GRDY4Z0JZQThyTHcy?=
 =?utf-8?B?VW1tL0wyQm9ubE1UVW5JalBmclBvTUdzSWVBNjlrbHB5SjZhN3hTdDZsandC?=
 =?utf-8?B?aHZxaEltZXpEc0VjejJhMDFyTThrODRCa3NLVEVLUkpuTERVSGdiMWRIcjY5?=
 =?utf-8?B?VXdkcnBVc3FnQklTanZMWDFYczR2Z0pOeW14NUlsSlNEaDNBLzFQaG5lcll2?=
 =?utf-8?B?OWhEaTkzQzVOMXRrcVk4VEpvUFNBR25JYVpvay80Q01QbFA1YlIxUVJaY1R5?=
 =?utf-8?B?c1FkcFI2ekR0N3k3bDNvV3JETDl4TjhnR3o3N0plNldoaWRMc21rTDJKVXJ5?=
 =?utf-8?B?VWljd2ZKcEJqMzJIR3lwQzdUZGk0cDFXSUR5NWZ3eXdJWHZRWUc1bEVEK0c1?=
 =?utf-8?B?dllkSEUzVHNMVVZEMEdrR0FYNFcyRWs3WjNIakJKM3R4OUxOU1RubUcxTWw3?=
 =?utf-8?B?V2tKMXJmQnVVVlptekUxY252WGlCYkFBbGpKeFJoMkhFeVJlbElGaFpmOEts?=
 =?utf-8?B?OWI2ZGl3MjI1QThoUktSRVorblRXNGRIU0FTTGR2VmRONVNvZjl5cEorbk94?=
 =?utf-8?B?RlpaM3grTUdPbVU3K1pWVkFIeSs3V21jYTR3RFhJTmFHODcyU3M1MXovaHRQ?=
 =?utf-8?B?WGpzMEFwSTdvNW9OZ3B0L1BxUkVjYzhxUCtjNnVwZnN5NCtNK08rYVVjaXVa?=
 =?utf-8?B?SjRVZ25Xa21tK2ZJSk0yR3VobXJWSzV2TXNSeG04dG5vU2FLeUxqN1F2SGYx?=
 =?utf-8?B?S2VuZXJkVXVGV2w0Q3ZJKyt3T202NUQ3SFhCdkowVVpYb0U4L1Z0OHZmVk5p?=
 =?utf-8?B?Q3VpeFJseURiTTVxNW5hek5IZUlVOVdkcmhyUG5weTZUWlBNdjJ3Um1LS1J2?=
 =?utf-8?B?bDBGaHZkUXc2NGdKN0VBcFcvTHpGNEw4cm9HWHVHek0xVTlaSVRXZlMvQlFw?=
 =?utf-8?B?Rm1BSXdVOHYxUi9aUVNRVVhKTmRqVmE2YXpWR2hVQXVMa0JJVFFnMG1Na3JP?=
 =?utf-8?B?TU9tUFpoclYvZ3ZXNjZoMGZCVkZrYU9BZFRMMlJ4SkNrRVphTzhKWjBYZFFN?=
 =?utf-8?B?R1RDb0czbk4rVHhJcmNKYTZFUDV5QkxRdXBJSE9PWitvRHNINnBVTEIzZFp5?=
 =?utf-8?B?Sk9NbHdkcS9LYWVPMWczU2gvQnFSeWVmMEtRQ0tvOGp0cG40RWpic1g3ZTNN?=
 =?utf-8?Q?YGh29J4sQ144/W9EYCbJNXY=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 102f8c07-b6a1-4031-99a6-08d9f6e5ecb9
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2022 16:02:43.0415
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: d7r7BMLJVeBVTuOyTEHvE65g7wqLrA2T3jp2n7795gWI9ZpKJYqUgcqJtnXvhHieD6KoWE77fspG5YZnxy9DZA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB6156

This function is the wrong layer to go through for PV guests. It happens
to work, but produces results which aren't fully consistent with
get_page_from_gfn(). The latter function, however, cannot be used in
map_domain_gfn() as it may not be the host P2M we mean to act on.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: George Dunlap <george.dunlap@citrix.com>

--- a/xen/arch/x86/mm/guest_walk.c
+++ b/xen/arch/x86/mm/guest_walk.c
@@ -551,7 +551,9 @@ void *map_domain_gfn(struct p2m_domain *
     }
 
     /* Translate the gfn, unsharing if shared. */
-    page = p2m_get_page_from_gfn(p2m, gfn, &p2mt, NULL, q);
+    page = paging_mode_translate(p2m->domain)
+           ? p2m_get_page_from_gfn(p2m, gfn, &p2mt, NULL, q)
+           : get_page_from_gfn(p2m->domain, gfn_x(gfn), &p2mt, q);
     if ( p2m_is_paging(p2mt) )
     {
         ASSERT(p2m_is_hostp2m(p2m));
--- a/xen/arch/x86/mm/p2m.c
+++ b/xen/arch/x86/mm/p2m.c
@@ -357,6 +357,8 @@ void __put_gfn(struct p2m_domain *p2m, u
     gfn_unlock(p2m, gfn, 0);
 }
 
+#ifdef CONFIG_HVM
+
 /* Atomically look up a GFN and take a reference count on the backing page. */
 struct page_info *p2m_get_page_from_gfn(
     struct p2m_domain *p2m, gfn_t gfn,
@@ -422,8 +424,6 @@ struct page_info *p2m_get_page_from_gfn(
     return page;
 }
 
-#ifdef CONFIG_HVM
-
 /* Returns: 0 for success, -errno for failure */
 int p2m_set_entry(struct p2m_domain *p2m, gfn_t gfn, mfn_t mfn,
                   unsigned int page_order, p2m_type_t p2mt, p2m_access_t p2ma)



From xen-devel-bounces@lists.xenproject.org Wed Feb 23 16:03:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 23 Feb 2022 16:03:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277518.474047 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMu6z-0006Kv-Mw; Wed, 23 Feb 2022 16:03:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277518.474047; Wed, 23 Feb 2022 16:03:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMu6z-0006Kn-JQ; Wed, 23 Feb 2022 16:03:29 +0000
Received: by outflank-mailman (input) for mailman id 277518;
 Wed, 23 Feb 2022 16:03:28 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=DZ7u=TG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nMu6y-00064O-AZ
 for xen-devel@lists.xenproject.org; Wed, 23 Feb 2022 16:03:28 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 22e118cd-94c2-11ec-8eb8-a37418f5ba1a;
 Wed, 23 Feb 2022 17:03:27 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2175.outbound.protection.outlook.com [104.47.17.175]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-40-MZVb_loDP-adKvBNPFmRnA-1; Wed, 23 Feb 2022 17:03:26 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB6335.eurprd04.prod.outlook.com (2603:10a6:803:f9::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.27; Wed, 23 Feb
 2022 16:03:24 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.022; Wed, 23 Feb 2022
 16:03:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 22e118cd-94c2-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645632207;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=ldFCmhVgf2hohYtDOIo5qnNRmC9eRJje8GLGX9RkTuY=;
	b=Y8yGCLBwNj02hEid5RUUJ2DraOdirHDFEt3emNUBautuNIDO3RsA4QiQUPKKgBQGyrD8Tv
	g8bZPosCPJVO0ADjdbjVxR1MqkBsDsqJHNyw3hMVInfxHpqYAEXYxHAcKN+Lxm73ZY9Zec
	Tb86FWYjIcVPFwvLLL+wwssypxV7iu8=
X-MC-Unique: MZVb_loDP-adKvBNPFmRnA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=dPkIcQVyhHbPH9XYk++KieGKiHzaI2VGt7PWwB0Xo2sOQp0Vg2MW0O48bJAHGRDq0W8UnTOOkFSk+4xOek0aFYHymD47Qq0WpGD1MCjoHXfmzvP+v/g51Mv+X/DWh3O2gPCrgR7uhc9l88onX8Qon7D4/BSDdHAXce78qCyTjuCgbLqiSYbGwcFF5e8TkEtA96qXqIin1dtq40+jjp/Xv8q91xMJa/4cw4XGkjYuMGEJyL04c7spmZBSbnDEgvGDk8fxADP3n6FjdNYu16hc3JSkQb6k39L0Ojc2YK1Ccv/vxrwb9o7BexjdNVuqNaioiuT5Lwscokkz4RUWRm7+oQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ldFCmhVgf2hohYtDOIo5qnNRmC9eRJje8GLGX9RkTuY=;
 b=CDotKA3uMoCbkamW6h1Yzkv8IV94uw3fORH99R18nQA1tSr8a1c7aljXSZGrgp0HGsJVcVdp6QCczQuVVQvjy4LkS/MeakY2sbQJtT2XF/9A9TPV/hytrtKEhHCFbmBox/e6EKiVDIcGuHIjKj3xCcRvdH5jPPqhSlLvn25YRQuuDzXq1jp4Gcj0B5j5D/tOyqmFg7Vc9x/7tASqPteHDu8tpOoKzPdJIZKRGXER//UYn1/InhERQtLDfiHuyfShr7CNcEWXuptNK6HI17xkZvONgllu4azhhcCVRsTsFsbdosZE/nKwqefkcGtTB8dx4hMdhC2bhhawXEZ4wu5tew==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <12673497-72ca-3b24-f35f-0d93c645e11b@suse.com>
Date: Wed, 23 Feb 2022 17:03:22 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: [PATCH v2 09/14] x86/P2M: derive HVM-only variant from
 __get_gfn_type_access()
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Tamas K Lengyel <tamas@tklengyel.com>
References: <f4e3bc16-2983-6f5b-37e8-26ac385d4d72@suse.com>
In-Reply-To: <f4e3bc16-2983-6f5b-37e8-26ac385d4d72@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P192CA0107.EURP192.PROD.OUTLOOK.COM
 (2603:10a6:209:8d::48) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 27f82c7a-3633-4bfd-e1e7-08d9f6e60513
X-MS-TrafficTypeDiagnostic: VI1PR04MB6335:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB63353367D6A330C7B5A0A7D1B33C9@VI1PR04MB6335.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	1xXFtTr9vmZ42FxJeDi5QwVUnyn3nWp2oGd7DqdzoRAOJoZ/cj9c1gvEPHZFsQqE5K0It6OB42FjY7n/ABaxtvNnF1OudbR5aMhODuvt2rlOMNw3J1AM9bQprViy2ItxEh1GzSnMy+HmjmDcqFteJ3NvQsAbCRSiysiekxSBMqac2fU0q8Rmj1FiLXDYEaF7WEfY118S7YyhPwh4XE9esW4bbYfM3H4xxyn8cbW16Oe8mpg/w6cqmiYvPguQS+rYpjkNyby0LYF78mYbfB95gJMMYC8WsRmMdYFk0y+LFnvhK0GkHHhUu8L5vWku6DhtnejFYzaf0WZWO/gef6X+O/CMwf40oa8bZqR11xYMTkrxlGpLUi/ZSreu7mF58S/U7k7tW07k6Fq7EyYonVkBFMU/8jtKEPZuhTT1fKUQMwOHzOyl6oF43mosteTBLY/YiMQpZIoAj/A8IzZRLn2iqsjMoh4nIR2i+ghjNd+8DOJ7jI9j5XAgiSVloTYiteX3dxS42FXujGU5V0rBPGblozjGCyLiyThpypuY1kvDrXa+F03J92L6JcYbiQ2Cr4bSLYF6qmqZ1pGB+HCkfSgm3qAPo9MMns+FRnPxTZ9W6aNBOcxGBYmhiJD2nigmE4FYNdnVNuDtVPBCU1kWRlKsmEnWw1ctfyGkk5zBEF9peDdvxRBrF98atSdaAVVWWUAUPp8QJt4Mnz+0uobY7rEu0RGWUy9Yg750tFa/SIXHh8EHpyfDGgskp6rwHhsMMKOw
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(31686004)(66476007)(54906003)(6916009)(66556008)(66946007)(83380400001)(4326008)(36756003)(8676002)(508600001)(6486002)(6506007)(86362001)(186003)(31696002)(26005)(5660300002)(2906002)(8936002)(316002)(2616005)(6512007)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bG1VTGpWRG9FSC9aWWtUb3dMKzl2ZjJDYUZKZkJLelVFQXFQaUl4UjZ1blg5?=
 =?utf-8?B?RVNteUtiTXhScU0ySE4zRktKeXNPZVMrdXovQ3lrUSsraG5UWFFpVmoxOTN0?=
 =?utf-8?B?S2hMVER0WksvcFkwQndGWFczMFV4NGVoNkJMRWRNNDkyWDlTUXpHeVlSeDNt?=
 =?utf-8?B?SzFzdEN6NHBQNzJ6cGJKUURqVlBkVDFYSjZkWHVzenNDS3NYMFEySXF0NmRU?=
 =?utf-8?B?VjhTd1ZEd1JROTg1Sm1BV2NKaXN3TkgwQmh1bHNWcnVYclhTdUhOdUl5aFEw?=
 =?utf-8?B?Y0ZqcjgxUHQ1WFhNc3dGaGh0NDhicUdFM3MrUC9Cb1ZDeHN0TnY2UjFlMkF4?=
 =?utf-8?B?WG1kUElqdjlQbzVsNncwOGVvT0w1UVM1WTljZm1aZHFrNHVMVTNHUURURHB5?=
 =?utf-8?B?RmE3aUQ3eUg4a1A2NDdlbUwxeXdBK3pkdDZFQnUwVTJPNVVhbnVKVjA3UzlD?=
 =?utf-8?B?NGJqdit5TlMrRVpKSWYrcWMxQTU1dk5zZlI1c1JKbDlYUzhWdnF0bk50cm9k?=
 =?utf-8?B?QVF4WGRXSEZlVytMMWxUTjkyN296Vy9GVHlYOWhiZXpFNzN2N3RnVnE2T21Z?=
 =?utf-8?B?dW15Mmkyd3JrR2dKVU5EcmtFRDRWaC9vU1VyMkNMcDRLaDNKQkRSWEJBaUta?=
 =?utf-8?B?QzYyWEk0TVVXTmtZOGUwTmxEWjhUNXVuMEZqSnA2V1RVUmVlQjhNZmw4anhz?=
 =?utf-8?B?VlVheXd6ZERMdEwvbkJRbXFUWE8xL0xvalVkUDQ4ek44Nm1NUHdjL1BTcEFH?=
 =?utf-8?B?R3RqU1o2RVdwKzNwOWp2TDFBbmpaN3JPSmJHV2JwMGFqQ3cvQVcwK01pWFNv?=
 =?utf-8?B?eVRJZUozUk9rZWxJdDdpZXRCcUIvbE9UeVlxUmlWL0lhZEcyQjRGazczc1BU?=
 =?utf-8?B?THN0dW9LeUtnTi8xR3dSaXVXKzYyNDZtQU43NnltNHN6Ly9WcVY5ZVNuemF3?=
 =?utf-8?B?UUIxQmVjRjdQamcza01BUDU4N2VaTStvREYvOVZKRnMxSXVQWDR4MjNhZW5y?=
 =?utf-8?B?Z1orK2RSaHhYWHZYME1nZGx0TXRIdnBNWXZkMXNRS3NONzVOQ1ZXd2F3TTAx?=
 =?utf-8?B?dTRkY09QZHoydms4VFRua3JqeTRES04ybEcvQUgzZlZsWFRlV2FlZkdhSmFD?=
 =?utf-8?B?QnpveHM3Y0JGSU5kMEpPK1BFdyt1blVVWU81dXNTN21sb0NCbkovWnB5NFhh?=
 =?utf-8?B?M3NVbDVHNmwrYllJcDdFdjFmWFh6d0JMQitxb0JFSXNlVTRBbDhxWkdxRmRN?=
 =?utf-8?B?UldBQmFoQVgzQUJnQ2x0RXgwZmdlK1pVMTJlK1JZWDhnWnlzY2JRVTJHcjlX?=
 =?utf-8?B?QU1heitpSDljdlRNK210SU9zOTVuaTNmcDZoekhydXVCaG84MTlYUmRaYjNO?=
 =?utf-8?B?VHBOeWJvV09haHZTWkZ3Ym1sb2daUTV4V2Z3aXk1Y2E5UFNUNng1Y3BOZENm?=
 =?utf-8?B?UGRONDQ4K09UTVE4V2l6aGxNTHJVVGttMTF3ZDN1VGJiWDFCMTN1YnpYcWRN?=
 =?utf-8?B?T0FSSkNNOTFkMVgwNjlCVHZsMzMzRHJlNHZtODl1TnVLM0xYVkxiT3N6cFlx?=
 =?utf-8?B?bmZIRFZ3bGxZTkRJSHVSU0treStlNTRFWGNScUtyNlViSVhyTWxqVUF1OUxr?=
 =?utf-8?B?Q0h0OWFOTFlzQVFCajlTa29mTy94RitMSjdnaFNyRTczMnZUM0ExNm1MakVT?=
 =?utf-8?B?RGZoNFNlRWdPblNkbHF3VnBrUVdLT3YrbGNjSkZuaVJ3SzhnNUU0dDNDNHU4?=
 =?utf-8?B?eUhobGViVi8vbmRTaGdhRndPZktOYWVDS2V3Q3lSOHhJZ2pQSko4NUpTZUU0?=
 =?utf-8?B?Mmllc1BsblFjOEowaWZYRGdERGtKQ2FaWXlWdlRKWjd4YWk5dXNLdTNXczJV?=
 =?utf-8?B?WHIxZzR5UGJoY0VVSWFFRS9qR1NKbjVPeWpqOEQ1Mzl1YnBPT0prNnBmZGpE?=
 =?utf-8?B?bG4vLytacnNoSmVpcXIvTVpvaFI4Q1JTL05XS3h6VFlQekJjcTFEdUJra0Q3?=
 =?utf-8?B?TnB6Z3BJRkM1dVdjb05BeStVMzI0ZlVFWEVzWEJDeW94NW5hSEZJQ2d0RzJZ?=
 =?utf-8?B?ckJsWDFCNHVYZ09MNGdsZ0gwOGhKWVE2ZjVDTUVzUnFXakl3SFhvQkFhMDA0?=
 =?utf-8?B?M2RUd2N1Mm9ueFZQM1ZDb3ppd3B1QjlZU3hyY2tzdTZnMkV2N2xNeGdKS29z?=
 =?utf-8?Q?IScFz/HNM80EJn0KwyNhO5o=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 27f82c7a-3633-4bfd-e1e7-08d9f6e60513
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2022 16:03:23.8985
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bv0YSkwOPcVrPb5WpNy1OlcqjHLeK6v8WJwM/IfCXUCm7tL9tL4Tf/F9FD5SjEfkxHDuJ2DIvnX1bhCCaebNLA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6335

Introduce an inline wrapper dealing with the non-translated-domain case,
while stripping that logic from the main function, which gets renamed to
p2m_get_gfn_type_access(). HVM-only callers can then directly use the
main function.

Along with renaming the main function also make its and the new inline
helper's GFN parameters type-safe.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: George Dunlap <george.dunlap@citrix.com>

--- a/xen/arch/x86/hvm/svm/svm.c
+++ b/xen/arch/x86/hvm/svm/svm.c
@@ -1716,7 +1716,7 @@ static void svm_do_nested_pgfault(struct
         } _d;
 
         p2m = p2m_get_p2m(v);
-        mfn = __get_gfn_type_access(p2m, gfn, &p2mt, &p2ma, 0, NULL, 0);
+        mfn = p2m_get_gfn_type_access(p2m, _gfn(gfn), &p2mt, &p2ma, 0, NULL, 0);
 
         _d.gpa = gpa;
         _d.qualification = 0;
@@ -1741,7 +1741,7 @@ static void svm_do_nested_pgfault(struct
     if ( p2m == NULL )
     {
         p2m = p2m_get_p2m(v);
-        mfn = __get_gfn_type_access(p2m, gfn, &p2mt, &p2ma, 0, NULL, 0);
+        mfn = p2m_get_gfn_type_access(p2m, _gfn(gfn), &p2mt, &p2ma, 0, NULL, 0);
     }
     gdprintk(XENLOG_ERR,
          "SVM violation gpa %#"PRIpaddr", mfn %#lx, type %i\n",
--- a/xen/arch/x86/include/asm/p2m.h
+++ b/xen/arch/x86/include/asm/p2m.h
@@ -459,10 +459,27 @@ void p2m_unlock_and_tlb_flush(struct p2m
  * After calling any of the variants below, caller needs to use
  * put_gfn. ****/
 
-mfn_t __nonnull(3, 4) __get_gfn_type_access(
-    struct p2m_domain *p2m, unsigned long gfn, p2m_type_t *t,
+mfn_t __nonnull(3, 4) p2m_get_gfn_type_access(
+    struct p2m_domain *p2m, gfn_t gfn, p2m_type_t *t,
     p2m_access_t *a, p2m_query_t q, unsigned int *page_order, bool_t locked);
 
+static inline mfn_t __nonnull(3, 4) _get_gfn_type_access(
+    struct p2m_domain *p2m, gfn_t gfn, p2m_type_t *t,
+    p2m_access_t *a, p2m_query_t q, unsigned int *page_order, bool_t locked)
+{
+    if ( !p2m || !paging_mode_translate(p2m->domain) )
+    {
+        /*
+         * Not necessarily true, but for non-translated guests we claim
+         * it's the most generic kind of memory.
+         */
+        *t = p2m_ram_rw;
+        return _mfn(gfn_x(gfn));
+    }
+
+    return p2m_get_gfn_type_access(p2m, gfn, t, a, q, page_order, locked);
+}
+
 /* Read a particular P2M table, mapping pages as we go.  Most callers
  * should _not_ call this directly; use the other get_gfn* functions
  * below unless you know you want to walk a p2m that isn't a domain's
@@ -474,7 +491,7 @@ static inline mfn_t __nonnull(3, 4) get_
     struct p2m_domain *p2m, unsigned long gfn, p2m_type_t *t,
     p2m_access_t *a, p2m_query_t q, unsigned int *page_order)
 {
-    return __get_gfn_type_access(p2m, gfn, t, a, q, page_order, true);
+    return _get_gfn_type_access(p2m, _gfn(gfn), t, a, q, page_order, true);
 }
 
 /* General conversion function from gfn to mfn */
@@ -515,7 +532,8 @@ static inline mfn_t get_gfn_query_unlock
                                            p2m_type_t *t)
 {
     p2m_access_t a;
-    return __get_gfn_type_access(p2m_get_hostp2m(d), gfn, t, &a, 0, NULL, 0);
+    return _get_gfn_type_access(p2m_get_hostp2m(d), _gfn(gfn), t, &a, 0,
+                                NULL, 0);
 }
 
 /* Atomically look up a GFN and take a reference count on the backing page.
--- a/xen/arch/x86/mm/mem_access.c
+++ b/xen/arch/x86/mm/mem_access.c
@@ -299,8 +299,9 @@ static int set_mem_access(struct domain
     {
         p2m_access_t _a;
         p2m_type_t t;
-        mfn_t mfn = __get_gfn_type_access(p2m, gfn_x(gfn), &t, &_a,
-                                          P2M_ALLOC, NULL, false);
+        mfn_t mfn = p2m_get_gfn_type_access(p2m, gfn, &t, &_a,
+                                            P2M_ALLOC, NULL, false);
+
         rc = p2m->set_entry(p2m, gfn, mfn, PAGE_ORDER_4K, t, a, -1);
     }
 
--- a/xen/arch/x86/mm/mem_sharing.c
+++ b/xen/arch/x86/mm/mem_sharing.c
@@ -478,12 +478,12 @@ do {
 #undef assign_pointers
 
     /* Now do the gets. */
-    *first_mfn  = __get_gfn_type_access(p2m_get_hostp2m(rval->first_domain),
-                                        gfn_x(rval->first_gfn), first_t,
-                                        first_a, q, NULL, lock);
-    *second_mfn = __get_gfn_type_access(p2m_get_hostp2m(rval->second_domain),
-                                        gfn_x(rval->second_gfn), second_t,
-                                        second_a, q, NULL, lock);
+    *first_mfn  = p2m_get_gfn_type_access(p2m_get_hostp2m(rval->first_domain),
+                                          rval->first_gfn, first_t,
+                                          first_a, q, NULL, lock);
+    *second_mfn = p2m_get_gfn_type_access(p2m_get_hostp2m(rval->second_domain),
+                                          rval->second_gfn, second_t,
+                                          second_a, q, NULL, lock);
 }
 
 static void put_two_gfns(const struct two_gfns *arg)
@@ -936,8 +936,8 @@ static int nominate_page(struct domain *
             if ( !ap2m )
                 continue;
 
-            amfn = __get_gfn_type_access(ap2m, gfn_x(gfn), &ap2mt, &ap2ma,
-                                         0, NULL, false);
+            amfn = p2m_get_gfn_type_access(ap2m, gfn, &ap2mt, &ap2ma,
+                                           0, NULL, false);
             if ( mfn_valid(amfn) && (!mfn_eq(amfn, mfn) || ap2ma != p2ma) )
             {
                 altp2m_list_unlock(d);
--- a/xen/arch/x86/mm/p2m.c
+++ b/xen/arch/x86/mm/p2m.c
@@ -286,25 +286,13 @@ void p2m_unlock_and_tlb_flush(struct p2m
         mm_write_unlock(&p2m->lock);
 }
 
-mfn_t __get_gfn_type_access(struct p2m_domain *p2m, unsigned long gfn_l,
-                    p2m_type_t *t, p2m_access_t *a, p2m_query_t q,
-                    unsigned int *page_order, bool_t locked)
-{
 #ifdef CONFIG_HVM
-    mfn_t mfn;
-    gfn_t gfn = _gfn(gfn_l);
 
-    if ( !p2m || !paging_mode_translate(p2m->domain) )
-    {
-#endif
-        /*
-         * Not necessarily true, but for non-translated guests we claim
-         * it's the most generic kind of memory.
-         */
-        *t = p2m_ram_rw;
-        return _mfn(gfn_l);
-#ifdef CONFIG_HVM
-    }
+mfn_t p2m_get_gfn_type_access(struct p2m_domain *p2m, gfn_t gfn,
+                              p2m_type_t *t, p2m_access_t *a, p2m_query_t q,
+                              unsigned int *page_order, bool_t locked)
+{
+    mfn_t mfn;
 
     /* Unshare makes no sense without populate. */
     if ( q & P2M_UNSHARE )
@@ -329,8 +317,8 @@ mfn_t __get_gfn_type_access(struct p2m_d
          * Try to unshare. If we fail, communicate ENOMEM without
          * sleeping.
          */
-        if ( mem_sharing_unshare_page(p2m->domain, gfn_l) < 0 )
-            mem_sharing_notify_enomem(p2m->domain, gfn_l, false);
+        if ( mem_sharing_unshare_page(p2m->domain, gfn_x(gfn)) < 0 )
+            mem_sharing_notify_enomem(p2m->domain, gfn_x(gfn), false);
         mfn = p2m->get_entry(p2m, gfn, t, a, q, page_order, NULL);
     }
 
@@ -343,9 +331,10 @@ mfn_t __get_gfn_type_access(struct p2m_d
     }
 
     return mfn;
-#endif
 }
 
+#endif /* CONFIG_HVM */
+
 void __put_gfn(struct p2m_domain *p2m, unsigned long gfn)
 {
     if ( !p2m || !paging_mode_translate(p2m->domain) )
@@ -377,7 +366,7 @@ struct page_info *p2m_get_page_from_gfn(
     {
         /* Fast path: look up and get out */
         p2m_read_lock(p2m);
-        mfn = __get_gfn_type_access(p2m, gfn_x(gfn), t, a, 0, NULL, 0);
+        mfn = p2m_get_gfn_type_access(p2m, gfn, t, a, 0, NULL, 0);
         if ( p2m_is_any_ram(*t) && mfn_valid(mfn)
              && !((q & P2M_UNSHARE) && p2m_is_shared(*t)) )
         {
@@ -1775,8 +1764,8 @@ int altp2m_get_effective_entry(struct p2
         unsigned int page_order;
         int rc;
 
-        *mfn = __get_gfn_type_access(hp2m, gfn_x(gfn), t, a,
-                                     P2M_ALLOC | P2M_UNSHARE, &page_order, 0);
+        *mfn = p2m_get_gfn_type_access(hp2m, gfn, t, a, P2M_ALLOC | P2M_UNSHARE,
+                                       &page_order, 0);
 
         rc = -ESRCH;
         if ( !mfn_valid(*mfn) || *t != p2m_ram_rw )



From xen-devel-bounces@lists.xenproject.org Wed Feb 23 16:03:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 23 Feb 2022 16:03:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277524.474059 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMu7Q-0006qC-06; Wed, 23 Feb 2022 16:03:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277524.474059; Wed, 23 Feb 2022 16:03:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMu7P-0006q3-Sm; Wed, 23 Feb 2022 16:03:55 +0000
Received: by outflank-mailman (input) for mailman id 277524;
 Wed, 23 Feb 2022 16:03:54 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=DZ7u=TG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nMu7O-0006oT-F4
 for xen-devel@lists.xenproject.org; Wed, 23 Feb 2022 16:03:54 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3277c14a-94c2-11ec-8539-5f4723681683;
 Wed, 23 Feb 2022 17:03:53 +0100 (CET)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2050.outbound.protection.outlook.com [104.47.6.50]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-25-EznRuw0VMlmRQgSV7fuLvg-1; Wed, 23 Feb 2022 17:03:52 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM0PR04MB5921.eurprd04.prod.outlook.com (2603:10a6:208:123::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.21; Wed, 23 Feb
 2022 16:03:50 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.022; Wed, 23 Feb 2022
 16:03:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3277c14a-94c2-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645632233;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=gz3zvRiEWYkf7LDrZ0GXIkTScZJf9PYhQI0iXwQf+w8=;
	b=KgJjdGIXL4Y/4HqVXyis53AGeWBnx8I6lJ+uzdMqZ6YUjib0UBvHK5m159Ln9SHmABCOEy
	8l8/LVBSOCJJxvarZ1TUeZ8HZX01JqtB07SCpWj44cg2/KvHqh6JFcrUIRGr7JPu+NWfby
	Tb/aaWAUURlgALumGmFUBz8QwF8sdUQ=
X-MC-Unique: EznRuw0VMlmRQgSV7fuLvg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=NHG+aAk22uie8LA+AXU1k0xkPThoEL6+363srUsCo3+pRU/s06yUo+AvUOWaKE0Rus7xAAF3qt5d7/X0LcKpVr/csfwTwpTVwNezxJoUf1UxH6ImX+TVUSQNXLc+vQe5dwVnXRT3x6LUShz00WKfuPYsxRg2esMnWbL/RcTSdtwvheTGtgJXP2Iy9NivDRUJcH9+LQWHs2jHlL8UHb7Q0V++BuwpgfS2cLfAycfr3Vt58gpkl7Yidq78B7UqtIsHQBVFq7Zm2wr+vmVk1xXUU5rAy6DuP/EsaE6nCsRQcz5W3xK5veGQrqBMBz/rrI1YGmIHb9FxUFGh6to48mVs7g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=gz3zvRiEWYkf7LDrZ0GXIkTScZJf9PYhQI0iXwQf+w8=;
 b=Gqv+/s9ev9P7wC2KGShPWjxCmG8ITGhN9zrV8Hcsq5TmDD3esuKlJfK7VM+EfJQAxhSwLtKVJNUyy4leoUoP17BiGISFsldEDnaHPOoYG+w2rb4nsFucURLZAy3MLxQFCNADKs/ZI5d2hS7tsPX2bw68fbpov3bfHpIQDBKSlCVUVTtlagHMwTgwAWc58vWYKKevBZU5b5pWC8dJeKYwuDvt9NIYNcBFQkNuuUSe1VqMb1OiVM9ZJBesdIjEofpS0ygVdzjkTbHlDhbeifplPhnpOlD+Sx/M3rBjTdL0qIOvhnhoIG1HFK+Ya+jLFO3XoIVRyFkqKTzRftxRSeoIxw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <7834a4ea-3b39-5557-28ce-138084f21c31@suse.com>
Date: Wed, 23 Feb 2022 17:03:49 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: [PATCH v2 10/14] x86/p2m: re-arrange {,__}put_gfn()
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>
References: <f4e3bc16-2983-6f5b-37e8-26ac385d4d72@suse.com>
In-Reply-To: <f4e3bc16-2983-6f5b-37e8-26ac385d4d72@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR05CA0030.eurprd05.prod.outlook.com
 (2603:10a6:20b:488::24) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 1576fe68-b70f-4874-d2d6-08d9f6e6151a
X-MS-TrafficTypeDiagnostic: AM0PR04MB5921:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB5921FC80503B5181CDF39CF5B33C9@AM0PR04MB5921.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	l2N0jbVMnd3qfjhrZ8PdCAVEgki6jQy4PX8x7Zdp7pDmYCznJEcWZpIU/wsHbc/agfaHg2uoue6havCBpkctuvwG4Snfz5CPEXzKFos9vLbpm4EGCV2AfuxzEQZIOJutCrfIPAJ72ql43G1Xd9FX8cIKQdyl9Fh5UmJJRbJDzBykp65PbGZLhHlZxNP+O/jk4s/I/VnW0KqVexVCHFIa942VL/Wa2MRGbu049zDxXzAS0KU7FC4pY783r/Xp6E/rxzrSJPM73lXw3P3aKxJU8QsN/0McCRhBRnyR/pTifBb7n9g98BGJeB+s+juw154BErVZgsGx6XdKohKH8vo8vwVVVTFMc77WuA8ciJjhZ3wBjk/q0usmjcYThhhW6/K6tZRiz4YtoDoE2TvdXYx66VQIG6Yj27PP6W3hBZneCs8bR/prgPOetwA2vcLoV3tj878a+Go/AelF7DigQFq4BED8HBaBLa7VPDV9pipeOGix467SoS8dKY3+KCG+eLSaava3yIEsUDneqwFBJjVbU7czxOaJduHpfnx2e4eNuic68LQfXK/37EphcTGYJDIoHOxTlhiLkNzHNe94ERfXw57sUUj7wc+yqFtDhAOV2uiCilo1J8FODQqUDV82zrHPU9jN97gDGzyo0Llb7HSXqxYCxl0pXbn7MjZdKaVrzK0xf7XUOJyaV+jjJUeNgxzofa0WzGqm/hjCbijmuXkuXuH8lerVCOqVIhpEFEoaoIrY+8NZ99uZLbA3SiaEzD4c
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(316002)(31686004)(2906002)(8936002)(5660300002)(66476007)(6486002)(66946007)(36756003)(8676002)(66556008)(83380400001)(4326008)(6916009)(54906003)(186003)(6506007)(26005)(2616005)(86362001)(38100700002)(31696002)(6512007)(508600001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?b2FZSVRzYk1IZFkyUVRHa0VPNUVQZ0RLaUNzRTMxNnhXZXBMTHZzTG9VUFUv?=
 =?utf-8?B?ZHJFeUtWNVZpWFJadDJIenNaTTVseEp3d2RQV1RMWkVxcWhhOFJVb0ZzU1BY?=
 =?utf-8?B?TW9rYVl1THdHSnhmQ09UcWR2K2ErVlVxeUhISG5leUJtb2lWcngwOXZpWjVV?=
 =?utf-8?B?cHF2ck9tYkxCUm5RK0U2cDExSVh0WXR3Njhac0dHOHhNZzNURmdyVWtPWFpj?=
 =?utf-8?B?amNkYUpXaTl3Rk5MUUUxOXgyalJMQkZpM0daek5QRVgyektYQVRYUkpVMHBZ?=
 =?utf-8?B?dGpVazZubzNPcW9jOE1LU2xyS2Z1amlOUnJzaGVSSHRGNTQ4WTNkTi9KZVFN?=
 =?utf-8?B?MkNvc3YxWTRaVzlaNGJWMmhkYWtSTzQ5NG1zVGZ1QXdaSFh2K0lUVHhld3Vm?=
 =?utf-8?B?RHFpdTZTZ2RkOWNnU2JmUWZvOTlCc3BxZDdzZ3d0Uk9TeVJOenhJdDNsYW5h?=
 =?utf-8?B?T1FxVGI4OXoyc3J0SDJuN3NIeExZRzlSdEY5RzlBdVVhOFNUcFB4elIzb2xj?=
 =?utf-8?B?Z0JIWEl4V1A1am5Hdi9MVThxY3NXVTJJU2Q5bVBDaE9uUzg3ZXlJeHB0MnJ2?=
 =?utf-8?B?WXNMNUhXdFBpWkhlUldQdWQrWEtNTGk4cjdBcHY4TUN4VllpUnNKdkJEQmZ1?=
 =?utf-8?B?a1NsNGovV1FTYjB5anorNHIyZEIrZXJlYWpQNjRVdFhKLzU3YTBZK2tJenRF?=
 =?utf-8?B?M1hIRlFGeFJaaWE3WXRsVDllckdVVEgrWWtSR3hya2dLUW14SmhRMGN2WFgx?=
 =?utf-8?B?K3NyczJYNEppaTdvS0x1TjZ4N1FaR1pwWHMyVVZjY0dxeFM2bmkvdEVnVHZK?=
 =?utf-8?B?TDR5U3JIK3F0OVJNVms3MFZnWXZUYmo1aGVDRUttQUp1cHRZY3FCZnhQMlhK?=
 =?utf-8?B?NnR3SWs0bngzb2ZJK1Via1VVZkE2YTk3dWpvdnlWZGg4dllPcmR2VkQzLy9S?=
 =?utf-8?B?S1J0dVR6a0Z2U3JMRnptQitodFNRS3l6elZzNUdDbTFpRFBOME53dkk0Unpo?=
 =?utf-8?B?SktvUUpsOWxXaE1nTE93SmdnUXFPSjZpQXIyb1lzR0tMZElKb0NzLytGamFa?=
 =?utf-8?B?bmQyenhUcnhWc2Y2d0JaVGRVaTc1VDdZQmNUMUVzRjVyZ1lEd3d0T1hPb3hO?=
 =?utf-8?B?UHRLMjluQ09XcFBpcTlmR1JtcnVHUllPQUdaT1ZrSUw5YTIzSFNQTy9rMkhz?=
 =?utf-8?B?OGMrWVhVWjlUcmQzNGNaWjlVU041aDBIczFIalNQSE4xWVZqT2x1M1NxRWdF?=
 =?utf-8?B?dXJzMzhBRGhsdE01MkgxRGZtNTdKdk1lNUk5SnE0djN4K0dFclJ2VXgvVmJC?=
 =?utf-8?B?ckIyNTRocUZvZjhGcWdXcWY0VFczTFE1QmRBTTgxRUxGMm43ak9oMGZNeHRy?=
 =?utf-8?B?U0R3MC9jT1h2UDFPQUpTS3dodEZvbXVMV1lUbE53ZHpkTU5DM21DNUdaNGZq?=
 =?utf-8?B?VHpNUWdpT21FbldBOE44b2RvY3N4dUhPaXloK1ZVam1EL0dRVmJvaVFvTjJR?=
 =?utf-8?B?TExLQTN2WGloSDhuOEI2N2xlZXFyeVA3SjFTNGE1eEczaUFzTTU3a2dGVk9J?=
 =?utf-8?B?Umt4QjBxWTE0S1k1c0FUejlVVjA2NlRQeFBiaEVnYmcwNXBrZFM2YTBuSVNs?=
 =?utf-8?B?RzlWK2QxV3NSSUZzODJuY0ZkZDEwWUpzcWJnY3FkVUdJODIzeU9kVkJSSVNs?=
 =?utf-8?B?VXprR1V6WUlhR2VMSFAxS3NLSThtYjJIcmJmWVNYSFpudXpZSVFlMVBvRlJa?=
 =?utf-8?B?SnVzM211QWpyeVhaMHcwbnNKK0dIN2xSc3hoS3VmTHd4c3lNMXJibVRqZjAy?=
 =?utf-8?B?V0pRL3VWS09jS2l0bXNnY0ZOY1VObktBMzZMb2hGZm80d0t2M0dURVJRZERU?=
 =?utf-8?B?WW5CYytHTThRMENlUHdXM2V6Q1BrMnRSeWtCRWdWYW1JWi80MjYyN0VlUTBI?=
 =?utf-8?B?cWd4a05pKy91ZGw4dWlINGxwR2lKYXR5b013VzBveGYzUnQvbE4wYTBFRVha?=
 =?utf-8?B?bkJ4M1ZFbExmL0E3d3Y0bWdHU0xFM0tmRm5BMEJHZDdPcTFzU1Y2TDJINTZW?=
 =?utf-8?B?RXpaa3Vnc0UxVytiZWZwdlhQWlRXWmQxcFByei9idWpxU2FaWXZPbE9aU1hz?=
 =?utf-8?B?YzZQZGFWaXBqQVlKb0ZTUlpWbXdVenVabjU2YmFDQ095U0xhMEFFckRpYTRJ?=
 =?utf-8?Q?Ww6ywJmwGo6oNzQ/i7YJ5p4=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1576fe68-b70f-4874-d2d6-08d9f6e6151a
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2022 16:03:50.7719
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FkRqybpzQRugmbY06uaPz1s3s73T8g6aRoIM/nxeu/1TFN3wHufwfjDcOAKBw3Z1bUcVT6kapoq/NQ3mOcY9kw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5921

All explicit callers of __put_gfn() are in HVM-only code and hold a valid
P2M pointer in their hands. Move the paging_mode_translate() check out of
there into put_gfn(), renaming __put_gfn() and making its GFN parameter
type-safe.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: George Dunlap <george.dunlap@citrix.com>
---
v2: Re-base over XSA-388 follow-up.

--- a/xen/arch/x86/hvm/hvm.c
+++ b/xen/arch/x86/hvm/hvm.c
@@ -1955,9 +1955,9 @@ int hvm_hap_nested_page_fault(paddr_t gp
              * altp2m_list lock.
              */
             if ( p2m != hostp2m )
-                __put_gfn(p2m, gfn);
+                p2m_put_gfn(p2m, _gfn(gfn));
             p2m_change_type_one(currd, gfn, p2m_ram_logdirty, p2m_ram_rw);
-            __put_gfn(hostp2m, gfn);
+            p2m_put_gfn(hostp2m, _gfn(gfn));
 
             goto out;
         }
@@ -1979,8 +1979,8 @@ int hvm_hap_nested_page_fault(paddr_t gp
 
  out_put_gfn:
     if ( p2m != hostp2m )
-        __put_gfn(p2m, gfn);
-    __put_gfn(hostp2m, gfn);
+        p2m_put_gfn(p2m, _gfn(gfn));
+    p2m_put_gfn(hostp2m, _gfn(gfn));
  out:
     /*
      * All of these are delayed until we exit, since we might
--- a/xen/arch/x86/include/asm/p2m.h
+++ b/xen/arch/x86/include/asm/p2m.h
@@ -509,9 +509,16 @@ static inline mfn_t __nonnull(3) get_gfn
                                               P2M_ALLOC | P2M_UNSHARE)
 
 /* Will release the p2m_lock for this gfn entry. */
-void __put_gfn(struct p2m_domain *p2m, unsigned long gfn);
+void p2m_put_gfn(struct p2m_domain *p2m, gfn_t gfn);
 
-#define put_gfn(d, gfn) __put_gfn(p2m_get_hostp2m((d)), (gfn))
+static inline void put_gfn(struct domain *d, unsigned long gfn)
+{
+    if ( !paging_mode_translate(d) )
+        /* Nothing to do in this case */
+        return;
+
+    p2m_put_gfn(p2m_get_hostp2m(d), _gfn(gfn));
+}
 
 /* The intent of the "unlocked" accessor is to have the caller not worry about
  * put_gfn. They apply to very specific situations: debug printk's, dumps 
--- a/xen/arch/x86/mm/hap/nested_hap.c
+++ b/xen/arch/x86/mm/hap/nested_hap.c
@@ -149,7 +149,7 @@ static int nestedhap_walk_L0_p2m(
 direct_mmio_out:
     *L0_gpa = (mfn_x(mfn) << PAGE_SHIFT) + (L1_gpa & ~PAGE_MASK);
 out:
-    __put_gfn(p2m, L1_gpa >> PAGE_SHIFT);
+    p2m_put_gfn(p2m, gaddr_to_gfn(L1_gpa));
     return rc;
 }
 
--- a/xen/arch/x86/mm/p2m.c
+++ b/xen/arch/x86/mm/p2m.c
@@ -333,21 +333,13 @@ mfn_t p2m_get_gfn_type_access(struct p2m
     return mfn;
 }
 
-#endif /* CONFIG_HVM */
-
-void __put_gfn(struct p2m_domain *p2m, unsigned long gfn)
+void p2m_put_gfn(struct p2m_domain *p2m, gfn_t gfn)
 {
-    if ( !p2m || !paging_mode_translate(p2m->domain) )
-        /* Nothing to do in this case */
-        return;
-
-    ASSERT(gfn_locked_by_me(p2m, gfn));
+    ASSERT(gfn_locked_by_me(p2m, gfn_x(gfn)));
 
-    gfn_unlock(p2m, gfn, 0);
+    gfn_unlock(p2m, gfn_x(gfn), 0);
 }
 
-#ifdef CONFIG_HVM
-
 /* Atomically look up a GFN and take a reference count on the backing page. */
 struct page_info *p2m_get_page_from_gfn(
     struct p2m_domain *p2m, gfn_t gfn,
@@ -2201,7 +2193,7 @@ int p2m_altp2m_propagate_change(struct d
             else
             {
                 /* At least 2 altp2m's impacted, so reset everything */
-                __put_gfn(p2m, gfn_x(gfn));
+                p2m_put_gfn(p2m, gfn);
 
                 for ( i = 0; i < MAX_ALTP2M; i++ )
                 {
@@ -2225,7 +2217,7 @@ int p2m_altp2m_propagate_change(struct d
                 ret = rc;
         }
 
-        __put_gfn(p2m, gfn_x(gfn));
+        p2m_put_gfn(p2m, gfn);
     }
 
     altp2m_list_unlock(d);
@@ -2310,7 +2302,7 @@ void audit_p2m(struct domain *d,
              * blow away the m2p entry. */
             set_gpfn_from_mfn(mfn, INVALID_M2P_ENTRY);
         }
-        __put_gfn(p2m, gfn);
+        p2m_put_gfn(p2m, _gfn(gfn));
 
         P2M_PRINTK("OK: mfn=%#lx, gfn=%#lx, p2mfn=%#lx\n",
                        mfn, gfn, mfn_x(p2mfn));



From xen-devel-bounces@lists.xenproject.org Wed Feb 23 16:04:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 23 Feb 2022 16:04:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277531.474069 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMu86-0007Wx-C0; Wed, 23 Feb 2022 16:04:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277531.474069; Wed, 23 Feb 2022 16:04:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMu86-0007Wq-8t; Wed, 23 Feb 2022 16:04:38 +0000
Received: by outflank-mailman (input) for mailman id 277531;
 Wed, 23 Feb 2022 16:04:37 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=DZ7u=TG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nMu85-00064O-10
 for xen-devel@lists.xenproject.org; Wed, 23 Feb 2022 16:04:37 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4bee537c-94c2-11ec-8eb8-a37418f5ba1a;
 Wed, 23 Feb 2022 17:04:36 +0100 (CET)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2052.outbound.protection.outlook.com [104.47.13.52]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-16-ST5p_GrHNC20dxGWWejDcQ-1; Wed, 23 Feb 2022 17:04:34 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DB3PR0402MB3803.eurprd04.prod.outlook.com (2603:10a6:8:e::26) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Wed, 23 Feb
 2022 16:04:32 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.022; Wed, 23 Feb 2022
 16:04:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4bee537c-94c2-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645632275;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=c0HTObp3YJHfE/uo6Cw54yUOSGjrcQcQ2DoP9QPbuT4=;
	b=MzfkmX9mSAA8fG2Kk7xA9vQkN+R+/1dd/a6dbeVWIocd11KNYQlfJv50+n6x2nGPB2iQaS
	BlWulrb7USHOhbe/6nuI6wFwJRTk/Cb2TEpZZJQ3IxW5Lbmw5EYJcab+UBnA//vc8vYMSz
	InFCN4BZ5+HaJSNI63ObtChHDphTA1s=
X-MC-Unique: ST5p_GrHNC20dxGWWejDcQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=DnoGcvjpGOCw2/KNiC75fZjWsUL6EVBZdVidcg6OXrpMjR44lVZovtzTBYIKe8ghYoVnMmA3c7b1APMJlZNiFfv6LhSYwfjdVhcP61Kp++sTrHh4DG0EVQOrXX/8A3MSGl14wEknZeDrKXrEPahNOCHBLdUTRqBDYkQG+CAs5ejclkpwMn1J6Wc0DwiXBtieTxjLj1Q1cR0I2mcEx6+PD+7OiKcSexznqA0mVw0JQBZN0NQU+c3/uanwatWsqjw8OmBg1FZq3aRymjdH8naLBbgB8t1xif/BQ2OXXOCqvvWb5tAoxFTXDaQqNslXcu6s+kCRr/cPuCnFinGKmRplPw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=c0HTObp3YJHfE/uo6Cw54yUOSGjrcQcQ2DoP9QPbuT4=;
 b=WrDHh2h4pIv+lDQzuL9521foq7aOShXKvDvQQ7k0Lke7Fb5dLEQEoUJvjc0ymn6z7riHpgeQrvabgZ0YbeocnDEuJLG5rday55b6oyAR+TvUQV9rlsMr2o8myEIPzRX2znj8jdh69mOnuozb0fdNTWxKiJvMdfWu48HRus+3AgsycY7SttjmBs5yQIqkVyeDRgDYYoN1BQGbxcZZzl3YtgiF3hwBbyOiz0uJXinUFi9TVHa1IvrDtH3gdkhunC5sSuAkEQpwJdpbwD1C/mJE4eiOBsn1AATIEvmHFuogM77Fmq4EwRgAeH3Iv7cwWGc61HT0HP+jcDmRtJoIYrRY4Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <f103baf9-ee1b-e440-8fa9-f5009a56442c@suse.com>
Date: Wed, 23 Feb 2022 17:04:30 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: [PATCH v2 11/14] shr_pages field is MEM_SHARING-only
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
References: <f4e3bc16-2983-6f5b-37e8-26ac385d4d72@suse.com>
In-Reply-To: <f4e3bc16-2983-6f5b-37e8-26ac385d4d72@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM7PR02CA0012.eurprd02.prod.outlook.com
 (2603:10a6:20b:100::22) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4e192341-4fe7-4004-4c74-08d9f6e62dec
X-MS-TrafficTypeDiagnostic: DB3PR0402MB3803:EE_
X-Microsoft-Antispam-PRVS:
	<DB3PR0402MB3803A973FA708019ADFBBC3BB33C9@DB3PR0402MB3803.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	s6lpIxStBEmhwTnParHSK0fvUq/209veCbXgl6W7GoQzqCfpW7AHe/VqjoW++6twYKwiGnlO/8OThFbI1sCMj19BF+PVAMp0Cz4bpIrtxsp017m8cD4FlxJQa32yg3UWwbCy4O9/z4MsRDQjpyH06YJbHHSEN+35wRJAjur2GaoyALQTC+8OYmuUFHCkKPSGCoXtQANsMBNkrAmJYVJu43I5Aio/a1pJCUdLIn2qiwWl8EXt5rZgAbyjnoZSjivGxGSnn4FPDO5VdjNCoClG2wTLXWdAsYQMSkIQ2G1HKJtQDpwyh7X6UMGjErT/T1c7CMfJylF4K4Uycrclaux+lN2FAMhE1DQYsSODVWkN2zX0dVSFtihn7RyfD5Juj/YPvyDnQOjlZVjGseZ2fi59oiaEAwXr3Adrx2+oTZBLtQ5Uwq8Ols1mR5p0/u6/CBIMnXTS9U6LluenR6E0By9LyEz9YMvz1dbUaA4P29BRwt2Xh+PhfC97j33asvjiaKl+mtWnIOJx6iIthvfu6YXdkcoXNWS9+GCN5XoiwU1KUWXhGSuMIj3qPKXhGyz3hiv8r/eKhYwW/rcAeGarCHNjlKpUy4uKm/60yhlYkWqpeMWD4cItKaRWA/fqtTE26QVzLy1nrMIktf4xC3VyMFBB4cuzTTih8is6B7EdnuXOgXRLBxtW1GKnPEEvzXxRTOAW/90N1y8pRRC3kQwH9+/TzbFFD8nD/pMOQ7lTcB1eHF87hF1ObqhRUtmr8JdCzzMd
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6512007)(66476007)(8676002)(6916009)(6506007)(31686004)(86362001)(8936002)(31696002)(6486002)(316002)(66556008)(508600001)(66946007)(26005)(5660300002)(36756003)(83380400001)(4326008)(38100700002)(186003)(2906002)(54906003)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VkR6K0M3WlRGYmZRdkVqVXB2TDZyRUNSQzNXMjRqelkwcURYZE40b242L2dS?=
 =?utf-8?B?allGc1VHdkd3MlRHWCtzMHppQW50ZlBuTVJPeUxKN01mWlpmczk1Z2hxdzVN?=
 =?utf-8?B?Vk94S2NWME16QUt4MjZhMDFqQ0tYOWcxeFpoSXlKZHN5dnJTOFVtb1J5MFda?=
 =?utf-8?B?eFBXZllIL09sT2NBVVF0THZPR2diNWJhRlB6ZENIMnhqZVBncHN2ZWR3emVR?=
 =?utf-8?B?aHFBaUt6bHNjbkVhdUdoL0N4TGtodXFFT2NhUHhpbXN6MEJ5ZmhVOXUrLzFu?=
 =?utf-8?B?c1F4QmtFakk5Yy9XYUJpN2g2UzlQQ1d5R3kwc3B0UUlIa0JhOE5JMjZGbFhO?=
 =?utf-8?B?RmhLTnUrYnM2RHJGYnFoNzltbExjd09SVzdjaGQrRDlsVWdFTURVeU01dytJ?=
 =?utf-8?B?WUY4eEtzdCswRTZrSG5tWjJ5Ry9McUM0Uk0rTXFocnVIcCs3S2FGUW5UalNi?=
 =?utf-8?B?Q0EzZWVidmFocXVHTTZ5M3hzNVpBOVFIQ2V4WDFNQUkrS1J6NWEvdldtTmhl?=
 =?utf-8?B?QzZkZUE2QUIxNFZaMEJpZXlvSWQrZ2dKNG5tMmdEMUpFNHQxUjdUbkVPZU00?=
 =?utf-8?B?aWVlWXFKZlBGL1h0VUF2b25ZNHFKLy9zMHFOVjdsZ1FGUWE3QWlIUkplL1ZZ?=
 =?utf-8?B?d0E3MXcvVWIxd25mOGNjTmtmb3RtYnplSCtlbU1UeXc5MHFhZFdudkQ0ODlp?=
 =?utf-8?B?amhNbmlVYkVmZngxY0lnMlJ0aUhOcjJ2dFZ3ZXNObE5LbGxKaDZXbUdYWnRP?=
 =?utf-8?B?TW1ROWxXS0s3UEtwMWdmZUNBSDZOclFjTlVIY0dDTVNnTUx3d1Y5MSt0WU1y?=
 =?utf-8?B?cU1JQjRaRnFyeUlYOG9VRTFFQnA0V1UxZTJPRXd4UW5TcGw0QnZVcysvZFFa?=
 =?utf-8?B?YTgyRS9zaEdENThwM1lmSHBmbEYxVVdhNkcvZzBnWnVCdENjOGpyRGd6aEdP?=
 =?utf-8?B?YTBDNkl2SzlwRFhMakVKVklPUEx0WXpNQ0JjUWUyRFhEYkZZYUtPTjdoRCtL?=
 =?utf-8?B?QmpNK0o1ZFVRcjl0VEtKa01TTThIYjlBSnJWMUFIUDBzNzJObmR4VklxOXZp?=
 =?utf-8?B?TnJMVXdVbjdRdFhnRUdURHpocWsvSnVmRTRYWXh1VzNIRFg0aUFqRXVXZUVP?=
 =?utf-8?B?QkZaTU9qZWsrMzluMitxQTJtK1dOc0JYK3NXUWFNdG5JOEswamRjcGlpaHBV?=
 =?utf-8?B?OGJXZ3MvMW5rR2NyQkJWVDhSN1QvT3JxTWhaMi9QOXdacW44MWNESjdKN3Fo?=
 =?utf-8?B?alFsYyt4YnNrQW40V2NDLzBtN1FFYkYxQmFiR3dOR1ZqbGNhK09GYVZEVGhZ?=
 =?utf-8?B?UGhScHN2TFB4eUdzOHdvN0FvK0FxQzFsNDQvWnd2TlVBSnV5TE1BOFd6VmJI?=
 =?utf-8?B?ZzlMUlZmNkcxRmRSQk5tWWtmZzI4U0NGRTBmRGg1TnVUcFlRbjUwSkpDOGNP?=
 =?utf-8?B?Q3kxYi9seFBzTmdjdlBDYlJ3cktORFFDbHFvYldLd3pCUTV3NHhGQi9BVzAx?=
 =?utf-8?B?WVl2aEMzUkpzVFhsYkgrLzNHc1JUNmxDbXZpQS9zTWFncnM3S2hKWkRFLzNk?=
 =?utf-8?B?M1Z4ZVRzT3ZVSE12eC84WFFqazR1em54Y2VFRXJudXZZdmhHRmxxSjN3TGUv?=
 =?utf-8?B?RjVJNFU2UzZ1cmNrbE5ncFBuZDY4UkxVYWJNcWo5dGNTN0htVHhOV2Vtbnp3?=
 =?utf-8?B?cklKN1pFT241M2tEVnVibU9MSThTTTZYVTJFdW84UUpBRlVDU0pFV0tlWjdN?=
 =?utf-8?B?U2c3M2JyWFhlM0xpa3pmbjc4SHB4R3p6dkUrRUlvSVZxU3N4SnNXN2p2VG5O?=
 =?utf-8?B?WnFOK01IK2tSb3ZmNXgxVnRvR0tqTmlwR3RERkx2OWtORllzTGZyL1U0QkRl?=
 =?utf-8?B?S0tqemVBYitaUEZjYWFUamthbVBqVDdxWTUzdE9KczlSbFFSWjY3NU94TU4z?=
 =?utf-8?B?V2hNRE1kSkZLZk5NVGpzV0pZYVJmeXRpZit5T2Zhc2hNVDdoU3JodlUwNVVa?=
 =?utf-8?B?bFV4MlVLZGFRYlZJL2p3bTdSbGJqakhYMlppR0pPRWxOeWc1c3VlM0MvYWdH?=
 =?utf-8?B?dTR0aFgreVhjdXk0TzA1U3lQTThOQit4VnNpdTdjcElQWXBtTkIwa2JwdWE4?=
 =?utf-8?B?aTQyeHFmSUNuR0FUZlMrYlVtWmxydVIxelZTNWMxOWhNZ2pIUTlmQUd5SDhw?=
 =?utf-8?Q?MQOpuodnSObfiXDRXIcGwyg=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4e192341-4fe7-4004-4c74-08d9f6e62dec
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2022 16:04:32.4413
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SFyDBtjzEiPkhQH2+gxfHn/6ZS3qcSPMmWf/RP3QWkaND0RL/lodLlhzTxqsOG/uMfOC2bNjJ5JHhfrzYszpqg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0402MB3803

Conditionalize it and its uses accordingly. The main goal though is to
demonstrate that x86's p2m_teardown() is now empty when !HVM, which in
particular means the last remaining use of p2m_lock() in this cases goes
away.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Tamas K Lengyel <tamas@tklengyel.com>
Reviewed-by: George Dunlap <george.dunlap@citrix.com>
---
I was on the edge of introducing a helper for atomic_read(&d->shr_pages)
but decided against because of dump_domains() not being able to use it
sensibly (I really want to omit the output field altogether there when
!MEM_SHARING).

--- a/xen/arch/x86/mm/p2m-basic.c
+++ b/xen/arch/x86/mm/p2m-basic.c
@@ -159,7 +159,6 @@ void p2m_teardown(struct p2m_domain *p2m
 {
 #ifdef CONFIG_HVM
     struct page_info *pg;
-#endif
     struct domain *d;
 
     if ( !p2m )
@@ -169,16 +168,17 @@ void p2m_teardown(struct p2m_domain *p2m
 
     p2m_lock(p2m);
 
+#ifdef CONFIG_MEM_SHARING
     ASSERT(atomic_read(&d->shr_pages) == 0);
+#endif
 
-#ifdef CONFIG_HVM
     p2m->phys_table = pagetable_null();
 
     while ( (pg = page_list_remove_head(&p2m->pages)) )
         d->arch.paging.free_page(d, pg);
-#endif
 
     p2m_unlock(p2m);
+#endif
 }
 
 void p2m_final_teardown(struct domain *d)
--- a/xen/common/domctl.c
+++ b/xen/common/domctl.c
@@ -109,7 +109,9 @@ void getdomaininfo(struct domain *d, str
     info->tot_pages         = domain_tot_pages(d);
     info->max_pages         = d->max_pages;
     info->outstanding_pages = d->outstanding_pages;
+#ifdef CONFIG_MEM_SHARING
     info->shr_pages         = atomic_read(&d->shr_pages);
+#endif
     info->paged_pages       = atomic_read(&d->paged_pages);
     info->shared_info_frame =
         gfn_x(mfn_to_gfn(d, _mfn(virt_to_mfn(d->shared_info))));
--- a/xen/common/keyhandler.c
+++ b/xen/common/keyhandler.c
@@ -274,9 +274,16 @@ static void dump_domains(unsigned char k
         printk("    refcnt=%d dying=%d pause_count=%d\n",
                atomic_read(&d->refcnt), d->is_dying,
                atomic_read(&d->pause_count));
-        printk("    nr_pages=%d xenheap_pages=%d shared_pages=%u paged_pages=%u "
-               "dirty_cpus={%*pbl} max_pages=%u\n",
-               domain_tot_pages(d), d->xenheap_pages, atomic_read(&d->shr_pages),
+        printk("    nr_pages=%u xenheap_pages=%u"
+#ifdef CONFIG_MEM_SHARING
+               " shared_pages=%u"
+#endif
+               " paged_pages=%u"
+               " dirty_cpus={%*pbl} max_pages=%u\n",
+               domain_tot_pages(d), d->xenheap_pages,
+#ifdef CONFIG_MEM_SHARING
+               atomic_read(&d->shr_pages),
+#endif
                atomic_read(&d->paged_pages), CPUMASK_PR(d->dirty_cpumask),
                d->max_pages);
         printk("    handle=%02x%02x%02x%02x-%02x%02x-%02x%02x-"
--- a/xen/include/xen/sched.h
+++ b/xen/include/xen/sched.h
@@ -385,7 +385,11 @@ struct domain
     unsigned int     outstanding_pages; /* pages claimed but not possessed */
     unsigned int     max_pages;         /* maximum value for domain_tot_pages() */
     unsigned int     extra_pages;       /* pages not included in domain_tot_pages() */
+
+#ifdef CONFIG_MEM_SHARING
     atomic_t         shr_pages;         /* shared pages */
+#endif
+
     atomic_t         paged_pages;       /* paged-out pages */
 
     /* Scheduling. */



From xen-devel-bounces@lists.xenproject.org Wed Feb 23 16:05:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 23 Feb 2022 16:05:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277542.474081 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMu9E-0008E6-MZ; Wed, 23 Feb 2022 16:05:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277542.474081; Wed, 23 Feb 2022 16:05:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMu9E-0008Dz-JY; Wed, 23 Feb 2022 16:05:48 +0000
Received: by outflank-mailman (input) for mailman id 277542;
 Wed, 23 Feb 2022 16:05:47 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=DZ7u=TG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nMu9D-0008Dl-Qp
 for xen-devel@lists.xenproject.org; Wed, 23 Feb 2022 16:05:47 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 76017dca-94c2-11ec-8eb8-a37418f5ba1a;
 Wed, 23 Feb 2022 17:05:46 +0100 (CET)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2053.outbound.protection.outlook.com [104.47.13.53]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-34-aLZRpbzcPm-R-iu9EkuZDQ-1; Wed, 23 Feb 2022 17:05:45 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DB3PR0402MB3803.eurprd04.prod.outlook.com (2603:10a6:8:e::26) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Wed, 23 Feb
 2022 16:05:43 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.022; Wed, 23 Feb 2022
 16:05:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 76017dca-94c2-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645632346;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=9KYg7EGIpsPMfdCGhpfXXPnI+8C1a2jFdZUo/dNcjvI=;
	b=UdaPDpzPKhozyJIW2OBIUqw+4pt5NQLgJjXMjRDy1LORQyEU5IUOOToN+gW5fDi1Xfutxr
	5jyAmfboeqYsVuZWuxaqIrBW5vhWjqQ/nZrHQ8j8BgK6oWCKEQVyD88Y+2Ff2dkzo1+eHf
	Wi8LWsbQSHN6evMm8LSUHs0M3cMC7lk=
X-MC-Unique: aLZRpbzcPm-R-iu9EkuZDQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cNz5jjzW1OhytF9f2xN0YITudhK29hMyD0g4CBatFM3ux5Wi8JLbRl1fqODTN4w6wz+9th/9vjg2Ty0uP7+kWMont1ZOqABatZjJabcaNLE0z6ByDcSk/4G88zgIYepj3FGwnE4uEo8cxhld1jOM2PziC3QXq0LsiUOnIn3CuFSWRd0yrtxI1BRTJsNW6Oz6G/eDcKY48O+PGGDk2Rchp5dZDwxbgAdzWvwOkLSHC1nyY1Vl094rKaFEQWnR6f/8YazyyRVuGiP4TNxKzuEcuUu/rAOC/xQfukeobK6bM0WaehFRqbzYeIhGj9flLxXDp+OGhBu1WKl81B7/cok4hQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=9KYg7EGIpsPMfdCGhpfXXPnI+8C1a2jFdZUo/dNcjvI=;
 b=Wj5z+y3xarQOXN9BLfIcEie3N6ZzT56TE2Ora/Et7o7aCalvGVRVkGNtPZe2FUPLDLvKLrfh/bspFzhTSET6bOwUIWtXfa94WuAwgwNORyjlQ0mDsyIDx0eIlr+dfl4kdhtufDvAxB+LURyLknRS1IeCK1R0n1JRA8IQf9P6v57o6XHkbDKAmMATiOzpyOIa4lFSu+Df62GVcHtstClAtHPprAtKp9XJu2b70cBG4+pV5x5olmjRooKiRkToa5kfR5xXvsSrbromP6EsiXWGEG5ZtYIl5GWAqaM8XGuvvZGe7sRfq6B/KW2JgYs5GEJAVii/Q/OlBqMKXhHO4OycNg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <c2902c6d-d432-5800-9da0-055ed390250c@suse.com>
Date: Wed, 23 Feb 2022 17:05:41 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: [PATCH v2 12/14] paged_pages field is MEM_PAGING-only
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
References: <f4e3bc16-2983-6f5b-37e8-26ac385d4d72@suse.com>
In-Reply-To: <f4e3bc16-2983-6f5b-37e8-26ac385d4d72@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0251.eurprd06.prod.outlook.com
 (2603:10a6:20b:45f::28) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 92ff817d-7971-4327-2449-08d9f6e65861
X-MS-TrafficTypeDiagnostic: DB3PR0402MB3803:EE_
X-Microsoft-Antispam-PRVS:
	<DB3PR0402MB380301746692426D1C1013BCB33C9@DB3PR0402MB3803.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	pVWyEOGGrTZ2tSpsOHz0mMAuDpkyRIXV2wOEaBPLi3EVORr69LZiGcP0WPOHzXSRYj+c6lT8hxgrmTlpd/hyFqU0SUsUnvaGdS3ND+35FdOwiCIdKRsJh7pjUM8SdGKvU7hWuPJdtB4/SyL0Y4pQ0aQSqDjHI478oToo0JAsH370/l0rfNRrZDeOcDBAWEkxbu1hkuI4ORONffl59YXzb3yQ6SP95C9dkzJzSqXcagMqm4kA3cXehcROB4QEpeFtz8lBVQk20ef8zlZOPbsWOggUJC4pZqkN31ocJWVvty/jaXIVdXEbWGg1HjnlsSSb6tXOZgCYt+afnULyezpRvvW9iw5tloTctRPCcPesonRMfrSlL+OHIDdKYBsNMJMGWp1HaJW9Pcn3KYqw2Oj2MyZ/FB0d37jjBjhhforBtLC9WM4deY1bCp6YTBbIMflAQ8y9/M7ACSXFyjot8JczX7VaYPIrfxHfJ84euXw54LbEVTpo8HbH8M3+WctwCG59lX5o8ZH5YoA4Q4iY77uniiqmOd6CCLKnFJJzACYUkTcITuNr+P2Fs/QRtTy/JV4zDvE6dYk5lpsHiIsU70ccQSIo3ecvZEvsdOrTv9kBt6ocEUv7BkrV2e7UVEDKuszLyRCe1fuKtbx5fEu+os7ivReFsHHHEsdsjoimlkoE6z8i0aBUwFbZR52XXkFSZ6E5Srxy4D8pSo11uakwTc1lhKRX1x+rJUIpIjx0cRJw3qdfDTpfUFQAIHSVlr9mlFSG
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6512007)(66476007)(8676002)(6916009)(6506007)(31686004)(86362001)(8936002)(31696002)(6486002)(316002)(66556008)(508600001)(66946007)(26005)(5660300002)(36756003)(4326008)(38100700002)(186003)(2906002)(54906003)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bk1PZmRYeWZweUZaZWd6ZEdnYjkvQmtvVUl1STNPU3BDd3ZoQmdQSjBEVk00?=
 =?utf-8?B?dGFwYlcrdWYrb2wvT3k5N3lWdnNiLzJnZy9kOHdLb09POTdlbWJ0Z0RVZXQ0?=
 =?utf-8?B?TSttS1VYd3VZQXRFS3c0cHYvMmhwdEJ1MVJ4dFhPRndFSlAzS2dINU5xMGV5?=
 =?utf-8?B?UUhPRDlOQlVWcVFNTGJhYm8xVUxQZXJCK0ZKNVh0S05Oc2M5UnZpNXhXZVlo?=
 =?utf-8?B?WE1PemJQSmNMdmJqWkJLeTJOWC96Wkl6ZGlrVDlKUkJ0dm5TZE8zNldnSEd5?=
 =?utf-8?B?R0R3MDJjNFljajBueWZjL1I1bjlmMW92WjdOTWREci94UHF0blE2bzdtMERY?=
 =?utf-8?B?dnFENm9tTFNkMXY3TFBhV0RLT3BWbGR5dUY5WmE3dVQxc3pIbXl1WnJ3S0hi?=
 =?utf-8?B?ckRESGxKZURLYm1oL3lSMzJMc1VlUU9NUVFXM1hQbjZLTEMxSG4xeWhpUkkv?=
 =?utf-8?B?dGljWnhMNzlXbmZBYTd2dStuOVkySGRPelZyYmlNQmJLK1N5ZWttTWNzWkZZ?=
 =?utf-8?B?eFJhNGNoc2JQZndZN056eGVOTjBoMFl4TUl3TkowTkZ2RFl5UnF5citSYXVt?=
 =?utf-8?B?WndKY2lMck1VSDFjVlYrZmtEQldQcVZCMXVocWNqcFBtTVhQSnV0cTJVeVJ1?=
 =?utf-8?B?TjVtM2dPU1UzY1RBMUZoYmpaTGY5YTFGdFRTWWVxZE1iNXVJR3l6NjZqbnkv?=
 =?utf-8?B?ZTdlaFkwTTBlNjRRSzVJSjE3czFORy9wWDRzWkFxNW9kdUh6M2V2ZnE0bDB5?=
 =?utf-8?B?cWtNQ0piNC80UHdVWks3bXQ1N0FzZzAvUTNsOTd0Z0QrbHo0VUxZeXlhMDZv?=
 =?utf-8?B?UHFWeU5xdjhmMWE2bHR1UW5LZnVGV29IMThjV1N1VG9Zd1ZiK2FHRmVxQXB1?=
 =?utf-8?B?L3R4QVdqYU83Ymc4L1JxSFVxa1E4Wk5iTlVBSzlkTE9ic09QY1BXR2MxdHJ2?=
 =?utf-8?B?YU5UNnZZTkhMZnRvR2NnS0RvTDh1NnZTU0FqRml3b0c0ZHhTSVhxUnNrTXF4?=
 =?utf-8?B?L1gvQlJaTHkvbXQxUjdtcWJESC9XZGVnLzNWeGhoRThqNmgva0gwcWE4a21H?=
 =?utf-8?B?ck1lK2FBcGpZa2pRbEx4di9qS0Z6TUNXVnpsbkJSQkd2aERnbjhEbnJtSDZD?=
 =?utf-8?B?Y3l1alNIbG5mOEUxRzY1WWthbjlHSURGMnpKcFI5L2Ura0kvY1d0bjNQOTho?=
 =?utf-8?B?emIweit3emxJN3Awd2M1UVoxTG9ZSEUvcDc4VGxhZnFKQ01xUVFZN0M4MXZp?=
 =?utf-8?B?ckNUUmJGVUxTWDJDWlRvMDc3SmVhNVBqd2Z3OHArUU5FZ0V2U2VhOTBreTlo?=
 =?utf-8?B?cWViSDc3Vkh0Rm5zWFNkSjArNWdUN0VUUzU0YndsTHlQSi9obWRRZkVKTVBT?=
 =?utf-8?B?d0h6bEp2MU5VdTY5ZEJRa0d5ZjJZS01NQWdSRjFGYzhLdzdacEtuRDNuWlVF?=
 =?utf-8?B?T0k5ZjRXa0huR0xORHhNQzRncW14Q01MUXBOUkpDVWhBVFN5cGUrWHJ5NEw5?=
 =?utf-8?B?VUJDdmljeWpNUCttVVpCYVQrVDBkaFhEOFdJOG04ZnAvSDVDY21uVXl0MEk4?=
 =?utf-8?B?THI2OGZaSzNrUFZEeGdsTkhHdUxzd3IyMnhrUUxsbHNVOW5xL214dERuT2JP?=
 =?utf-8?B?REY5ZkNmTnNuVjl0SFF3U0kwckh2ZnFib0pYejVGenVzY3Mzdk9qRDJKWmZF?=
 =?utf-8?B?YXEzV0E3eWlYeDJ4ekhYeVFCaWdFZy9KTzdaV01qNWpoa2pWY2piQzd2UVlq?=
 =?utf-8?B?Y3ZmQm5hSkNkTmk3eU1zMXhzRkxSdHFySXlQaFJEQjcwUm1pTmpnNlBWaVpW?=
 =?utf-8?B?Wm1IL0xaL0lUd1FmeG85L0JmYnNpRkd5SS9odllJZ01wWkpoVC9OVkhlSVhy?=
 =?utf-8?B?VUpERFRGZjV0cEJOOVNqNGxUY0JtMVBkbVZXeGx5YkhhRTlEYTEwQU8xZjlm?=
 =?utf-8?B?ZngzQnlpRi95eVViRzRVSzFPNU5odXJ5UWhzcUthUDZRUFEwR01wTDV4RC9p?=
 =?utf-8?B?dlUrVkdRaCt6dnJ6NHVlQWRoQzhDL2t1TEZiVmNFdC9welF3VFlGL3Y5eTVJ?=
 =?utf-8?B?bGpsYm1NS1F6b1NjT2lXZkUzelJRLzBJSXlMMmxCRklqaHd3dU9MZnNyRzFL?=
 =?utf-8?B?dmxSZDFxUk1QN3NRMjM5VXNRMGpnM1diQm5PVW1iNE1IdlQ5SVBDUG1rbWtl?=
 =?utf-8?Q?sGstDxuNTTjox+DEaawb3dU=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 92ff817d-7971-4327-2449-08d9f6e65861
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2022 16:05:43.6558
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GfBDFdq3wXdxM63wyfIfXILJ18GdRjL7NxradvD5OYMHcoV6xlevPHrCQGSQm4+W50oT37yU9eu5qtcP3Ir3JA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0402MB3803

Conditionalize it and its uses accordingly.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Tamas K Lengyel <tamas@tklengyel.com>
Reviewed-by: George Dunlap <george.dunlap@citrix.com>
---
v2: Re-base (drop clearing of field in getdomaininfo()).
---
I was on the edge of introducing a helper for
atomic_read(&d->paged_pages) but decided against because of
dump_domains() not being able to use it sensibly (I really want to omit
the output field altogether there when !MEM_PAGING).

--- a/xen/arch/x86/mm/mem_sharing.c
+++ b/xen/arch/x86/mm/mem_sharing.c
@@ -1213,6 +1213,7 @@ int add_to_physmap(struct domain *sd, un
     }
     else
     {
+#ifdef CONFIG_MEM_PAGING
         /*
          * There is a chance we're plugging a hole where a paged out
          * page was.
@@ -1238,6 +1239,7 @@ int add_to_physmap(struct domain *sd, un
                 put_page(cpage);
             }
         }
+#endif
     }
 
     atomic_inc(&nr_saved_mfns);
--- a/xen/arch/x86/mm/p2m.c
+++ b/xen/arch/x86/mm/p2m.c
@@ -691,11 +691,13 @@ p2m_add_page(struct domain *d, gfn_t gfn
             /* Count how man PoD entries we'll be replacing if successful */
             pod_count++;
         }
+#ifdef CONFIG_MEM_PAGING
         else if ( p2m_is_paging(ot) && (ot != p2m_ram_paging_out) )
         {
             /* We're plugging a hole in the physmap where a paged out page was */
             atomic_dec(&d->paged_pages);
         }
+#endif
     }
 
     /* Then, look for m->p mappings for this range and deal with them */
--- a/xen/common/domctl.c
+++ b/xen/common/domctl.c
@@ -112,7 +112,9 @@ void getdomaininfo(struct domain *d, str
 #ifdef CONFIG_MEM_SHARING
     info->shr_pages         = atomic_read(&d->shr_pages);
 #endif
+#ifdef CONFIG_MEM_PAGING
     info->paged_pages       = atomic_read(&d->paged_pages);
+#endif
     info->shared_info_frame =
         gfn_x(mfn_to_gfn(d, _mfn(virt_to_mfn(d->shared_info))));
     BUG_ON(SHARED_M2P(info->shared_info_frame));
--- a/xen/common/keyhandler.c
+++ b/xen/common/keyhandler.c
@@ -278,14 +278,18 @@ static void dump_domains(unsigned char k
 #ifdef CONFIG_MEM_SHARING
                " shared_pages=%u"
 #endif
+#ifdef CONFIG_MEM_PAGING
                " paged_pages=%u"
+#endif
                " dirty_cpus={%*pbl} max_pages=%u\n",
                domain_tot_pages(d), d->xenheap_pages,
 #ifdef CONFIG_MEM_SHARING
                atomic_read(&d->shr_pages),
 #endif
-               atomic_read(&d->paged_pages), CPUMASK_PR(d->dirty_cpumask),
-               d->max_pages);
+#ifdef CONFIG_MEM_PAGING
+               atomic_read(&d->paged_pages),
+#endif
+               CPUMASK_PR(d->dirty_cpumask), d->max_pages);
         printk("    handle=%02x%02x%02x%02x-%02x%02x-%02x%02x-"
                "%02x%02x-%02x%02x%02x%02x%02x%02x vm_assist=%08lx\n",
                d->handle[ 0], d->handle[ 1], d->handle[ 2], d->handle[ 3],
--- a/xen/include/xen/sched.h
+++ b/xen/include/xen/sched.h
@@ -390,7 +390,9 @@ struct domain
     atomic_t         shr_pages;         /* shared pages */
 #endif
 
+#ifdef CONFIG_MEM_PAGING
     atomic_t         paged_pages;       /* paged-out pages */
+#endif
 
     /* Scheduling. */
     void            *sched_priv;    /* scheduler-specific data */



From xen-devel-bounces@lists.xenproject.org Wed Feb 23 16:06:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 23 Feb 2022 16:06:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277548.474092 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMu9i-0000IZ-WC; Wed, 23 Feb 2022 16:06:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277548.474092; Wed, 23 Feb 2022 16:06:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMu9i-0000IS-Sk; Wed, 23 Feb 2022 16:06:18 +0000
Received: by outflank-mailman (input) for mailman id 277548;
 Wed, 23 Feb 2022 16:06:18 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=DZ7u=TG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nMu9i-0008Dl-2g
 for xen-devel@lists.xenproject.org; Wed, 23 Feb 2022 16:06:18 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 883359fc-94c2-11ec-8eb8-a37418f5ba1a;
 Wed, 23 Feb 2022 17:06:17 +0100 (CET)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2056.outbound.protection.outlook.com [104.47.13.56]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-15-isKHM8ZCMuaq6KkTn66bwg-1; Wed, 23 Feb 2022 17:06:15 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DB3PR0402MB3803.eurprd04.prod.outlook.com (2603:10a6:8:e::26) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Wed, 23 Feb
 2022 16:06:14 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.022; Wed, 23 Feb 2022
 16:06:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 883359fc-94c2-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645632377;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=r/iLJGRiDWz9znYj5kxZFXueDDoLEYeNTD/fTL9rUek=;
	b=MjbbkCOAdbaRuyKRPfDEAhvFYWcOseXFKUFoT5CdyaiXoFAOKhEsm6IRuuL907oveLsDoS
	NvdZ7LRg2ORKjFMXT/SZOZi+lv5jOuVNdDk3wgml9X3VS+ORQD+redyt464Im/LPMul+33
	yVKUwhXOgfZlYdR+h0LIZm+PG4rdN5Y=
X-MC-Unique: isKHM8ZCMuaq6KkTn66bwg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=MOSpUC6ycuWhrZeTCAM7GqfkxSruI5Z7cFNBmtA6couBH9+M+3ldPF4I+QD2gbMdGJP0bQEROnnWrD1a0RCyx6zqjqr+ub6dhSfSt/Xg9gAUfTBzsX0lXnBww5spe1xqy1cjBK2O5ZFhMC/JoxXnqZtefErTRUpaCK43yM2ogTRvE0Uq8j9xP5ECDeczyP0AiK0F4Yo7HXI1V4Eqm52RK5BZAXnyWg9BAR936EMWHURzBtln4rNE5NdA+yM72+i8juokuYsdrYcOPO/qXbt653hQ52gWehZJXcJ6WRbed7OiTvVWTFsXoHfNkSrZENS6HkiIMQTFS4KJL0lURtLEHg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=r/iLJGRiDWz9znYj5kxZFXueDDoLEYeNTD/fTL9rUek=;
 b=E82CXA6ZD+NvavlLzI+1qr1hsNCBVe7yucN3osD9m4l6ZaUhHMu6NNb9fZ1v4m9bfldc58juFdinlOsboZSonbimRXz3wc1yflP2Kuu30z6BIJ+oXYbytA8NRev89j4oHP2QyATJPnRqMUGA/XSECCaj5WbFOjpqbl7t+UEwVbpkdZhf8BLm+P+MgN1ZO9tLMp0FO6JbxqeCqN+Jz7HoFpBz9qNyzi+AC5kXtgAtqX9pDqMR0P/YdQrmYjyNh69dN18OeETtXP4OACZ2cFQtB1jaU2cZURPgmLBQ+OLgfLv8M/2wgS93igyCYC7r1YZ+4Oa2FJ/MqYZHttAiwZAG1A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <3908bf69-f560-6a71-1a66-74ba1f9f3696@suse.com>
Date: Wed, 23 Feb 2022 17:06:12 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: [PATCH v2 13/14] x86/P2M: p2m.c is HVM-only
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>
References: <f4e3bc16-2983-6f5b-37e8-26ac385d4d72@suse.com>
In-Reply-To: <f4e3bc16-2983-6f5b-37e8-26ac385d4d72@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0260.eurprd06.prod.outlook.com
 (2603:10a6:20b:45f::25) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9614b131-30b4-41d0-2bb0-08d9f6e66a91
X-MS-TrafficTypeDiagnostic: DB3PR0402MB3803:EE_
X-Microsoft-Antispam-PRVS:
	<DB3PR0402MB3803DBD9EF0DB44A9F366656B33C9@DB3PR0402MB3803.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ZPw6vMM43BJb4v8ZSNENfUizhR1HWNR/L/6O8FaxJpu9QZ0BlZNr2KOv/t1iZ4+o72tbQxf7WJigmifrAAw3NPqpPkkrgTMPK2aDNqBqFxNmIqP05vO1i4Pdix85GbW+DET5HAP5N/dcCp8q1GpvnePRlAIucULdBnaJgKyolKUBUKajsW3DmvCXHln+dUoZi/fP1shT+0G+RHcgJJs1rFGa1KOpOzPz3HjCFcxbbJ2baC3itagg2y0f12RyRTqFKOZ4cSYdGyrY9qx7ZkqoFL2fHvYq3gJlYZyk74Nq5I0rmDMNr7ts9sTAtz87wFGqKSIdxRgULoh5y+fup+7A0wrjTQcvkSOXJOahTeSYDVuslLNrqUGQE8ejwwcnVm+jq9hY00Fd71fBI6tedOI2nJhxb7T7CFfj3OIO8p+NLA8m/9F2HimHNMVS+2BsSqSN3baox4xxp6tJSdMoTwcGBDlGWK9DBRXQcPBn2L9bKFXPiUqHV3DIVyLwi/om7vqrU4GAiFXXUz8ZMeQ43QODO83TV2Zvim5oLnq1/pdI1IS2DyUS57I206rdXkQS3a539y16xqSiItMJSczNUomtbHVw3FOhU1hw7M7JVSaQIn/3flZPiHDV8RXoBOZFw3tdrTGR/Ann/Fgsk4Y/bKnJW8+dzBjdYC6fNOBhbHzKj3jRmrYO50BQ+Gj/YlNSgdQxDB8s3NCd7cX853ZrbUD2VtQNS8vZIcS0ocGg5ffF2sk=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6512007)(66476007)(8676002)(6916009)(6506007)(31686004)(86362001)(8936002)(31696002)(6486002)(316002)(66556008)(508600001)(66946007)(26005)(5660300002)(36756003)(83380400001)(4326008)(38100700002)(186003)(2906002)(54906003)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?S3VKWHM3RkMyTzFENnVYeUFMd3hFeTVrZGovYWRoRStJeXV3OTI0SFp0eUNI?=
 =?utf-8?B?SWN1ZlRYZGg4L3I1WlJ4a0orTzF5UUZKUTEwb2MvdmdGRldCNjF2VjRZNGpx?=
 =?utf-8?B?NUZPcGdRNW9hdHZ6ckZhMExkb1VibHZRSzAwOE9mVXE0cHlMSHRJTUNnQWd4?=
 =?utf-8?B?OUQ4dmVLVndDa3B2TE5KWVRld3R2K3p1Mm0ycmxVcE0yL3hZanRoRnVWOURo?=
 =?utf-8?B?Z3ZZbG9aNUpNM0gyeEltdUtnditmTXFuTFRHSEx2RmVmWHZhTW4wY2pYUk12?=
 =?utf-8?B?NkR1ZStXT0lNbk9wSUZtMjVJdkpkdEdzTWQ4VEVpNzhwZjM2Zk14QTlWSDd0?=
 =?utf-8?B?QlVrV3ZwTlRWSlR1SExFR0R1ZHBqczVNUTcvWDQzYU1ueEd5WklUZTcwakU1?=
 =?utf-8?B?eUpFZG13QWNkaFFtTlZpUVZndG9XdXlNSTJPL1N6eWVSc3FTKzUxb01JbkJm?=
 =?utf-8?B?V3pzM2xnRTdKVjI1ekh6aHJYT0hldTAraUh3aG5ZR2l1cnlrNTZZbE9zK1B3?=
 =?utf-8?B?TUZKblBuU3B1Q1RTdWZkRm1qbExwa2o3Q2hJeS9iblpZbVVaOGMvVkpxZVhh?=
 =?utf-8?B?dnc1cWo2NTNmUTdmVURPR1R4RWFnOU9OSFpVZGhEeSt6d2lkUGpMcWUzYTA0?=
 =?utf-8?B?eWN5c2xYb1JaNkEwZDR3aTJwR3lMdWoyYmF4dTJybWJ2YW5yVkYvZDdzMFV2?=
 =?utf-8?B?Qkp4OHhpekJzNEFoU1JKbVpYNHNGd0RqNlpLMzhSbVoxOXlMMTVwUDVMMVNa?=
 =?utf-8?B?R3hHaFRhS3I2SXEzRWFZT0t4QVYrK1lGUnUrbCtGVjZHeDlyRmdrNmRYK2VV?=
 =?utf-8?B?UFV0ZXRzdnR0YXVnbEZjaXBMZGhiamIxeGJYYUdXalRtazIrRmVyMFFtYWpu?=
 =?utf-8?B?Rjc4V2xjeVV4eUxvSjNGSVFkaXRVNEtLekZlZVFDcG9nRVZoVHJxKzFzMWc0?=
 =?utf-8?B?SFkyOE1KZjAwQURiMzhyQ1g4RGZGVGd2WGRoaHN1eVFBYVRQVFBXZkhRQ3hz?=
 =?utf-8?B?VmxFUVQ3WE1XQUJCclFsSjEzazNUdDhIMWtOQ3M3QU5ZTHNoNDFUTzJBQTBv?=
 =?utf-8?B?WHNtR1o1V0VldGdFejFUUldxODVJYXVaNWdFeDZXMllVYmVGYzdqZ0R4Syt6?=
 =?utf-8?B?THBCZksvR1BUZThiTTB1SER5T0RxOTY1eFJld0s0TjVJcE81YVFNOGpVMVgw?=
 =?utf-8?B?dU1sUk0rcTV6bFZ1a0FwVUg2RVo2Z0tPbFhQL1VXd05McCtHVS9kZXc0M0xT?=
 =?utf-8?B?cjdvN2N2M1dQUEtXTEJUUDdwaFg4aFo2MjQwM2szYUU2Q1JCRmxueWJUVFFq?=
 =?utf-8?B?YXJFa29FcW9FajRQa20vUi9YaDBHOFd4NXltK0tQeTJGbEdtS2liWmR2WXF0?=
 =?utf-8?B?b3BHVnF3TXlQVU5VNWtISldIVHdBMTFZWW5pMDk1bjNQSkVGMGZBRWMrY2Q1?=
 =?utf-8?B?bVVySlQ1akJwZ2ZBSWwwd1Y5RW5rbVg4SDVBSCt6Ymp2UlovcWlzL1NEN04y?=
 =?utf-8?B?cTRzcTRzYmNiNWhpYU80RDVKRmhIRnNoSno1THVkSlRqL3BWKzJiNUxPdXFS?=
 =?utf-8?B?NGQwQWFERktyZ1ZQZlBNNnZ0MnpTMFg1UmltVzh4ODAxdkM5c2hLd09mVGpk?=
 =?utf-8?B?bXp0TXhKd0dubkNpSUJBeC83TU1lcnlURDBiNkw1aWYvUzIvZ1pPMVRmeTgx?=
 =?utf-8?B?NGxnZEx6Q21kcncwY0d5d3RwZnR4Y2tkU3E3bUN3MS90MnlGTXFoazA5S2FK?=
 =?utf-8?B?SHZZYUVFdlFLWHhuSXFDTFdYYW82NUozR2FpQy8xL3FxK0hOaFBWYWc3NnEw?=
 =?utf-8?B?QXB1bHdBUjBsTmh3K2RNU1pUK3lVU3Y2dk02WkY0TkxoQzRBZDZTQlZTdG13?=
 =?utf-8?B?NVRNcStCZGZvVjhnZzQ4eDdESWl1UW5LMll0MU1KKytMY2VvaFRqVmJQOGVB?=
 =?utf-8?B?RTBNUUlKVlZtYlpucGNMODRWZkhvK0pBZCt2Yy9BdHUvQTlmL3FlbTRiWFEv?=
 =?utf-8?B?VFZ2SUQ4WmlKNEd4RnJlN2VlcWJ1b2txNzlpT2UyV0tKRjIvZVk4ZitqaWw4?=
 =?utf-8?B?a2hhYmZaWU9mWlRKcWhXMTEvNVpabE9sdExrNHdWTEZ3dkZMTGJxRjRKZFBM?=
 =?utf-8?B?dWgrdXpGcURDL0pIaDJDUjFZUUZRV2dRVkdFbzdBRHBTeDN0TExxNjgwUU91?=
 =?utf-8?Q?aVDjN2vk4IGpXWzNDbiPkxk=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9614b131-30b4-41d0-2bb0-08d9f6e66a91
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2022 16:06:14.1851
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: m9GciQwZqb1/k288cPFOl36/iS+JvWvdw2kpN4NmqtfmxuLYGCZ7blQ+FOGNmxjtnumY+/WIAbeS4MhA/39tEg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0402MB3803

This only requires moving p2m_percpu_rwlock elsewhere (ultimately I
think all P2M locking should go away as well when !HVM, but this looks
to require further code juggling). The two other unguarded functions are
already unneeded (by virtue of DCE) when !HVM.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: George Dunlap <george.dunlap@citrix.com>

--- a/xen/arch/x86/mm/Makefile
+++ b/xen/arch/x86/mm/Makefile
@@ -8,7 +8,7 @@ obj-$(CONFIG_MEM_ACCESS) += mem_access.o
 obj-$(CONFIG_MEM_PAGING) += mem_paging.o
 obj-$(CONFIG_MEM_SHARING) += mem_sharing.o
 obj-$(CONFIG_HVM) += nested.o
-obj-y += p2m.o
+obj-$(CONFIG_HVM) += p2m.o
 obj-y += p2m-basic.o
 obj-$(CONFIG_HVM) += p2m-ept.o p2m-pod.o p2m-pt.o
 obj-y += paging.o
--- a/xen/arch/x86/mm/p2m.c
+++ b/xen/arch/x86/mm/p2m.c
@@ -53,10 +53,6 @@ bool_t __initdata opt_hap_1gb = 1, __ini
 boolean_param("hap_1gb", opt_hap_1gb);
 boolean_param("hap_2mb", opt_hap_2mb);
 
-DEFINE_PERCPU_RWLOCK_GLOBAL(p2m_percpu_rwlock);
-
-#ifdef CONFIG_HVM
-
 int p2m_init_logdirty(struct p2m_domain *p2m)
 {
     if ( p2m->logdirty_ranges )
@@ -258,8 +254,6 @@ void p2m_flush_hardware_cached_dirty(str
     }
 }
 
-#endif /* CONFIG_HVM */
-
 /*
  * Force a synchronous P2M TLB flush if a deferred flush is pending.
  *
@@ -286,8 +280,6 @@ void p2m_unlock_and_tlb_flush(struct p2m
         mm_write_unlock(&p2m->lock);
 }
 
-#ifdef CONFIG_HVM
-
 mfn_t p2m_get_gfn_type_access(struct p2m_domain *p2m, gfn_t gfn,
                               p2m_type_t *t, p2m_access_t *a, p2m_query_t q,
                               unsigned int *page_order, bool_t locked)
@@ -2718,8 +2710,6 @@ int p2m_set_altp2m_view_visibility(struc
     return rc;
 }
 
-#endif /* CONFIG_HVM */
-
 /*
  * Local variables:
  * mode: C
--- a/xen/arch/x86/mm/p2m-basic.c
+++ b/xen/arch/x86/mm/p2m-basic.c
@@ -28,6 +28,8 @@
 #include "mm-locks.h"
 #include "p2m.h"
 
+DEFINE_PERCPU_RWLOCK_GLOBAL(p2m_percpu_rwlock);
+
 /* Init the datastructures for later use by the p2m code */
 static int p2m_initialise(struct domain *d, struct p2m_domain *p2m)
 {



From xen-devel-bounces@lists.xenproject.org Wed Feb 23 16:06:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 23 Feb 2022 16:06:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277555.474103 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMuAK-0000xl-Dk; Wed, 23 Feb 2022 16:06:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277555.474103; Wed, 23 Feb 2022 16:06:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMuAK-0000xe-AN; Wed, 23 Feb 2022 16:06:56 +0000
Received: by outflank-mailman (input) for mailman id 277555;
 Wed, 23 Feb 2022 16:06:54 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=DZ7u=TG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nMuAI-0000w1-6i
 for xen-devel@lists.xenproject.org; Wed, 23 Feb 2022 16:06:54 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9d746bdb-94c2-11ec-8eb8-a37418f5ba1a;
 Wed, 23 Feb 2022 17:06:53 +0100 (CET)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2050.outbound.protection.outlook.com [104.47.13.50]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-38-OgQyaPfSOMqLrBABE6INEg-1; Wed, 23 Feb 2022 17:06:51 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DB3PR0402MB3803.eurprd04.prod.outlook.com (2603:10a6:8:e::26) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Wed, 23 Feb
 2022 16:06:49 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.022; Wed, 23 Feb 2022
 16:06:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9d746bdb-94c2-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645632412;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=qlmDT6QYqTFfeFQW5rElaxTqCBQLlgaE3LTl1YDteaU=;
	b=VAe75CrWyOGfLMQlt3P7rrpJuNuTw8ohUOj4SAm9vepWS8iHAdpicoz6A0K9sHiwpGpNaj
	OUuQ2EPtSlhSGjoQ3MfZJ5ubrmctvP4q9+atYN3VT3rIiYvifpbnhWycKxtaxz0oBdsFaX
	pj/24GLs+kEZEQdvmCp1GUpi+s6/SxM=
X-MC-Unique: OgQyaPfSOMqLrBABE6INEg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=T0rWpJ3adE5GqoNa9SgQTtaJ+eUpHtkVXTZzjce326XuoKPTI5Slm7mCYmITPQ+L73bjI+TycUnxW16yaR5uWd6GESJvRsAJzYrS2423QqziQLT0VWHz9RbSN9NX7b/YT21+GxE82mgS3mc5pNNxN/wj8+ziL42VmnQ6cb9CnNCBqDZ2usgSmddwWp8iZxj1beVvBRJFWMmtCDiDYmF/SLx26xZL8425Zp3ASgpUc1uyRGRZn3rPI3r71ioGMJ9Deb4PYJIvNT3AoufEhwIQfHuHTYapXV2sPkAgXz/1QSM8twqF8GcfUQb76PsZLSommwRINmd2QBTlomFLyPhfuQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=qlmDT6QYqTFfeFQW5rElaxTqCBQLlgaE3LTl1YDteaU=;
 b=cF8jCESKRZkmQ+OcyrH9TQuev1Ri87bop1VEnASVIoyteix53WsOCJSDnxr2gBefU9ZsriwxWjML27gJpiyDqniWWm+mtDubzxkKD2pf3kQE/yO/D1KNUdNuHwCB9S0kOSuNPDI3Afqb6NIfK3EMKZiMFnL5RF25pRK84R9zmPLylYBdLA+P3AicHyyzj/+Yr7nYQx7ZuCYu2Rm6u5sw5cd9ooyDrl/DQNCDgcrbGoWhFMBfeJpQp1TAGOqL7Xys8HTeRF8Ya9OFloJeVX3gA8qEvX1D40bljk4Oc5uvLrsaJ6PtvJRijHxYe7ZnQHN8GwxBEvreYMYzMlzk5IQA0w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <9b964afe-635f-3320-ceee-2845ed079332@suse.com>
Date: Wed, 23 Feb 2022 17:06:48 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: [PATCH v2 14/14] x86/P2M: the majority for struct p2m_domain's fields
 are HVM-only
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Paul Durrant <paul@xen.org>
References: <f4e3bc16-2983-6f5b-37e8-26ac385d4d72@suse.com>
In-Reply-To: <f4e3bc16-2983-6f5b-37e8-26ac385d4d72@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0601CA0025.eurprd06.prod.outlook.com
 (2603:10a6:203:68::11) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 409846ce-b77a-49d3-02ac-08d9f6e67fc8
X-MS-TrafficTypeDiagnostic: DB3PR0402MB3803:EE_
X-Microsoft-Antispam-PRVS:
	<DB3PR0402MB38039F9FA2FE926233DBCDFDB33C9@DB3PR0402MB3803.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	8fwQCb6RFUx6V1ZzmK51tmdr339Y2T5qd7aqZ8Re5PnWpFpyJQ5wuzXut35hgVA54tb35v3rnXa8m0MX9LCTWcjAVfwF/Y9EoMZ3F3eGpAlBaN9QZiUNc4mDG/Gr2LSvRhgpgTffFizazcn2k45XE5t7pP2cQRlVkNFlIhSuxdHPCFhdlsCyRQTamXRcH6oPDa/8142WUvisi1BH11fWrj4R3gBeGN6kpFXm/z36wdUBbsU4+8aVWMsU4Gs58/ceqZktq9tNVUJJMy4rbzsNL/SxNRsyDVHFkzApnf3WDJTZOvsqQd2Csm9YauhmLtAhpxAhwIY79rIhUvAZbwzDloY7SbU9hWMSotErfbVakivQBqGldRO+G+JSaJ/aI5b4dUex+T6qJ7jdBhGzRsnZXEs22JYyEnwVu7ZmrSfyXXUtsNbllIMZXgYSH2mITwgF5AfyDC8g0ozG6yqrp0ANiGOrWduPpo05EiHAADtRTxad0Q/rwKcZwA4FPiJhrjmpubwWeBfcZFADlT7v3UWXxgx2BJH4C8AIEanDp7qLpJ9FcDIAzmuQ60tP3VOM4SX0tuBD47xGjcz+upwU4drGExniczfogqcC81E9bB1Ul8FqgahlL84b3fxMqcKY5SJA9T/6rTe3waGwYwkMW3gNTLhUiWJ3QtAXS/G8+9tdxZHEEceGKuwE8lTH+d/Sf0GrqTTbxd6A3EZE5Jr3E4U484xFEDlj2hFo0CCe1NcrndI=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6512007)(66476007)(8676002)(6916009)(6506007)(31686004)(86362001)(8936002)(31696002)(6486002)(316002)(66556008)(508600001)(66946007)(26005)(5660300002)(36756003)(83380400001)(4326008)(38100700002)(186003)(2906002)(54906003)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?OXkvbnhEQytZYVFtWUN0NWZaK0J3S0pvd2dsTHJOUFRZdFdHQ0hXWTduQkJB?=
 =?utf-8?B?V1dxOUNmRWxrdkUwQTZ6YTB0bkNkbStjMFd6NzNDRVdoN1IxQkszTFJyYTk5?=
 =?utf-8?B?OUdqdlVxLzdYV0RNUkJCdit1ZU9vZkRlbUlER25UcEVxbVkzNmtia3R0MExw?=
 =?utf-8?B?Q1ZPZlQ0elUya1lNcDR6dTZIT1ByWUpRaVk4clZIK3VFVTExUm5KWktOYzNW?=
 =?utf-8?B?cjRHQndmVXMwa05NQkU4SEJUa0dnNjc0Q1JobjlrOFkxNktwSUZlREdsckVB?=
 =?utf-8?B?UGMzc1p3RXJRWWtvSDducWFQcW1uektxaXVUYitDMGMxTGNzL2pIZFN2Rm9U?=
 =?utf-8?B?VHpmVDUwK3ViNmxPclZ4a0tsT2lCcEVvTDI0SWxLcS9lTjdtZlJNUzM5RHhx?=
 =?utf-8?B?aUxVRTJsbEFxMGhIUzkzL1VGWklPUTFQd3h5SSsrSStIVmgwcGVCckFTOG9z?=
 =?utf-8?B?SVlpWEF0SVRGWUhlNzZURVIyN3ZqUXVGK0RVdEM5YjZmZzN3Mkllam44d2E3?=
 =?utf-8?B?OWZPUDhSdUVKOFM1V01YZkVrN2M3ZmxpQnErVlVhN0s5bUYzaGdWczVUemFM?=
 =?utf-8?B?YXNpTGl3TjJ3RDF2ejk3R3F6dEZHcGs1cy83K1l3OFREbVkrTW4zRGNKSzN3?=
 =?utf-8?B?ZTRRQUI3VmNRcWN5ekgxcHFkeUZVY2N1TGtSSFltSVpYZkoyTTBhMkpFUlVx?=
 =?utf-8?B?R1VmeWk2cXF3VkRFcDNmM0xkWXV2NHdGRkV0dFU3SEJZTVRpR3NneXVJTHky?=
 =?utf-8?B?THIyNWMxcExOcHdialZDNkhrUVBoQ2xXdTRoWUR2VEFmYjhYZmVYaktObzdR?=
 =?utf-8?B?MkFSMVJqTDZLdTVROUhkd1BMMURaNDBTSTRtbXFKZ212Yy9Eb09sMnNkVXlQ?=
 =?utf-8?B?VWl5RnRqMTB4OGZPZG5zME9leXdqMW5BTUQ3czBGay9GUVBuOFRvOVY4RnBT?=
 =?utf-8?B?Zlk2R28vSXdPeHBOc3ZWK09Dd21PeWErUXVVS1VhM1BBaFFGMUwwL1NCOXRx?=
 =?utf-8?B?N2pBUlJxL3NlcHB3Ymw5Z1ptME9GT1plYzVZTXVYVXhHajhreGgydVFSU1Y0?=
 =?utf-8?B?UWMvc2FOcEROR1Z4bkFDOTd4RGVNZUpuRm9hL1dhYXV2emQ3QUh6Y3dzSWtm?=
 =?utf-8?B?aTZMbzlLVU80cWlSMzV4TW5VWlRYRzRKMXpJUURLYlVlUFd6bG4yU1Z3ZVJU?=
 =?utf-8?B?NG1mKzV4bEp5dW1ZQytoM1h0aEhDa3Q4V3NJOGFrWDR4WnQ0S1R6TVRUZU13?=
 =?utf-8?B?NVZOVHVabEtXMTdmV0lGR3crOWxNN2ROZXV6cXJqTmp0N1ZieEVlQ2tuOUNP?=
 =?utf-8?B?V0x0S0grSVdocVRLNWM5WTk5N1lnRzVLb2J2dzdMb0FlelNxS3NWOXZPNzJs?=
 =?utf-8?B?YXY1Kzh6U1JSZnc4VjRYRTRka1NZRWRvMVFTQmQzclRHYUNNYm0yQURXZ0lH?=
 =?utf-8?B?UHNCVUlHMi8yTStHM1dPbGFlYlZ0aUJaLzZKWVdtUkRYVExmanpWK2hacnU0?=
 =?utf-8?B?WElqVTNwSXd5VUFNbEc0YThkSDJiclBBeDRqWTVmMG5Ld1Z5RnRsOFhsKzVD?=
 =?utf-8?B?NGx1dk4zb1NUSmVPK1I2WjFhMk9DNHBLM3hPNnRVZjdmTmFBcWhxZVMrNnll?=
 =?utf-8?B?TDV6NkVSVVpKdTZhOHRiNU5ObjhDcHB2bEI1SGtncGhITlh6a3k5QWd2QTVv?=
 =?utf-8?B?U21DSlNvODVaRGZXZ1lwNDU1S2RHMklna0d5dE10RW8rNHpLT1BOeUtySmpR?=
 =?utf-8?B?KzJldjJ2N2srTkRsT2VQYXJicTFWZkdxSUc3NzRoV0pCNmdjVUtRblZZU2Ju?=
 =?utf-8?B?SGZoajh6Tm9Mc0ZGVWZUWHhIRytPNDd6ZTZhOWZVSVRVYUVQWlBRYWlmT1VX?=
 =?utf-8?B?MWZrcVJWblVmNUJjOThmRVA2SWMrUTdlYmFuK0tDZTZ3L3Z0ZUY2Vy95bnVj?=
 =?utf-8?B?R080RHJrNjVaVVE5bVRhOTNPeXpycUJQVVhYbEgrVkpnZU94c00vbWpLS3Jl?=
 =?utf-8?B?Q0FXTW9kTS9LUnVjd1pXWld0RzVHMSt4SjdVQnpHdmhBUHpWM0hFYkkyL3kv?=
 =?utf-8?B?cEtSUjk0M3J3bjNkQmJTUGJYMFlrZEpUTHZMWW4wZjdlNHdEV2ZqcGVUeGl5?=
 =?utf-8?B?T2NvazZ5TGFrKzd1OGNoV3BERC9FQlZCVnNLN1c2cm5qSnNueTIzaUhCZG5V?=
 =?utf-8?Q?unWBFNoJ8Z5q2BL3llg/DOg=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 409846ce-b77a-49d3-02ac-08d9f6e67fc8
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2022 16:06:49.7611
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Blpzr+W413RLbPKOOTb1kU9EJAOdM2VfEMhOqNc7KBAnDlIoAWB4Tqhx1+MPov0sCgh4qSxusKrByejwX+YJGg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0402MB3803

..., as are the majority of the locks involved. Conditionalize things
accordingly.

Also adjust the ioreq field's indentation at this occasion.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Paul Durrant <paul@xen.org>
Reviewed-by: George Dunlap <george.dunlap@citrix.com>
---
v2: Adjust a comment.

--- a/xen/arch/x86/mm.c
+++ b/xen/arch/x86/mm.c
@@ -481,8 +481,11 @@ unsigned int page_get_ram_type(mfn_t mfn
 
 unsigned long domain_get_maximum_gpfn(struct domain *d)
 {
+#ifdef CONFIG_HVM
     if ( is_hvm_domain(d) )
         return p2m_get_hostp2m(d)->max_mapped_pfn;
+#endif
+
     /* NB. PV guests specify nr_pfns rather than max_pfn so we adjust here. */
     return (arch_get_max_pfn(d) ?: 1) - 1;
 }
--- a/xen/arch/x86/mm/mm-locks.h
+++ b/xen/arch/x86/mm/mm-locks.h
@@ -237,6 +237,8 @@ static inline void mm_enforce_order_unlo
  *                                                                      *
  ************************************************************************/
 
+#ifdef CONFIG_HVM
+
 /* Nested P2M lock (per-domain)
  *
  * A per-domain lock that protects the mapping from nested-CR3 to
@@ -354,6 +356,8 @@ declare_mm_lock(pod)
 #define pod_unlock(p)         mm_unlock(&(p)->pod.lock)
 #define pod_locked_by_me(p)   mm_locked_by_me(&(p)->pod.lock)
 
+#endif /* CONFIG_HVM */
+
 /* Page alloc lock (per-domain)
  *
  * This is an external lock, not represented by an mm_lock_t. However,
--- a/xen/arch/x86/mm/p2m.c
+++ b/xen/arch/x86/mm/p2m.c
@@ -48,6 +48,8 @@
 #undef virt_to_mfn
 #define virt_to_mfn(v) _mfn(__virt_to_mfn(v))
 
+DEFINE_PERCPU_RWLOCK_GLOBAL(p2m_percpu_rwlock);
+
 /* Turn on/off host superpage page table support for hap, default on. */
 bool_t __initdata opt_hap_1gb = 1, __initdata opt_hap_2mb = 1;
 boolean_param("hap_1gb", opt_hap_1gb);
--- a/xen/arch/x86/mm/p2m-basic.c
+++ b/xen/arch/x86/mm/p2m-basic.c
@@ -28,16 +28,15 @@
 #include "mm-locks.h"
 #include "p2m.h"
 
-DEFINE_PERCPU_RWLOCK_GLOBAL(p2m_percpu_rwlock);
-
 /* Init the datastructures for later use by the p2m code */
 static int p2m_initialise(struct domain *d, struct p2m_domain *p2m)
 {
     int ret = 0;
 
-    mm_rwlock_init(&p2m->lock);
 #ifdef CONFIG_HVM
+    mm_rwlock_init(&p2m->lock);
     INIT_PAGE_LIST_HEAD(&p2m->pages);
+    spin_lock_init(&p2m->ioreq.lock);
 #endif
 
     p2m->domain = d;
@@ -55,8 +54,6 @@ static int p2m_initialise(struct domain
     else
         p2m_pt_init(p2m);
 
-    spin_lock_init(&p2m->ioreq.lock);
-
     return ret;
 }
 
--- a/xen/drivers/passthrough/x86/iommu.c
+++ b/xen/drivers/passthrough/x86/iommu.c
@@ -459,7 +459,7 @@ bool arch_iommu_use_permitted(const stru
     return d == dom_io ||
            (likely(!mem_sharing_enabled(d)) &&
             likely(!mem_paging_enabled(d)) &&
-            likely(!p2m_get_hostp2m(d)->global_logdirty));
+            likely(!p2m_is_global_logdirty(d)));
 }
 
 /*
--- a/xen/arch/x86/include/asm/p2m.h
+++ b/xen/arch/x86/include/asm/p2m.h
@@ -205,8 +205,10 @@ typedef enum {
 
 /* Per-p2m-table state */
 struct p2m_domain {
+#ifdef CONFIG_HVM
     /* Lock that protects updates to the p2m */
     mm_rwlock_t           lock;
+#endif
 
     /*
      * Same as a domain's dirty_cpumask but limited to
@@ -226,13 +228,14 @@ struct p2m_domain {
      */
     p2m_access_t default_access;
 
+#ifdef CONFIG_HVM
+
     /* Host p2m: Log-dirty ranges registered for the domain. */
     struct rangeset   *logdirty_ranges;
 
     /* Host p2m: Global log-dirty mode enabled for the domain. */
     bool               global_logdirty;
 
-#ifdef CONFIG_HVM
     /* Translated domain: p2m mapping */
     pagetable_t        phys_table;
 
@@ -275,7 +278,6 @@ struct p2m_domain {
                                               unsigned int level);
     void               (*write_p2m_entry_post)(struct p2m_domain *p2m,
                                                unsigned int oflags);
-#endif
 #if P2M_AUDIT
     long               (*audit_p2m)(struct p2m_domain *p2m);
 #endif
@@ -310,7 +312,6 @@ struct p2m_domain {
     unsigned long min_remapped_gfn;
     unsigned long max_remapped_gfn;
 
-#ifdef CONFIG_HVM
     /* Populate-on-demand variables
      * All variables are protected with the pod lock. We cannot rely on
      * the p2m lock if it's turned into a fine-grained lock.
@@ -367,27 +368,27 @@ struct p2m_domain {
      * threaded on in LRU order.
      */
     struct list_head   np2m_list;
-#endif
 
     union {
         struct ept_data ept;
         /* NPT-equivalent structure could be added here. */
     };
 
-     struct {
-         spinlock_t lock;
-         /*
-          * ioreq server who's responsible for the emulation of
-          * gfns with specific p2m type(for now, p2m_ioreq_server).
-          */
-         struct ioreq_server *server;
-         /*
-          * flags specifies whether read, write or both operations
-          * are to be emulated by an ioreq server.
-          */
-         unsigned int flags;
-         unsigned long entry_count;
-     } ioreq;
+    struct {
+        spinlock_t lock;
+        /*
+         * ioreq server who's responsible for the emulation of
+         * gfns with specific p2m type(for now, p2m_ioreq_server).
+         */
+        struct ioreq_server *server;
+        /*
+         * flags specifies whether read, write or both operations
+         * are to be emulated by an ioreq server.
+         */
+        unsigned int flags;
+        unsigned long entry_count;
+    } ioreq;
+#endif /* CONFIG_HVM */
 };
 
 /* get host p2m table */
@@ -651,6 +652,15 @@ int p2m_finish_type_change(struct domain
                            gfn_t first_gfn,
                            unsigned long max_nr);
 
+static inline bool p2m_is_global_logdirty(const struct domain *d)
+{
+#ifdef CONFIG_HVM
+    return p2m_get_hostp2m(d)->global_logdirty;
+#else
+    return false;
+#endif
+}
+
 int p2m_is_logdirty_range(struct p2m_domain *, unsigned long start,
                           unsigned long end);
 
@@ -792,6 +802,8 @@ extern void audit_p2m(struct domain *d,
 #define P2M_DEBUG(f, a...) do { (void)(f); } while(0)
 #endif
 
+#ifdef CONFIG_HVM
+
 /*
  * Functions specific to the p2m-pt implementation
  */
@@ -852,7 +864,7 @@ void nestedp2m_write_p2m_entry_post(stru
 /*
  * Alternate p2m: shadow p2m tables used for alternate memory views
  */
-#ifdef CONFIG_HVM
+
 /* get current alternate p2m table */
 static inline struct p2m_domain *p2m_get_altp2m(struct vcpu *v)
 {
@@ -905,10 +917,10 @@ int p2m_altp2m_propagate_change(struct d
 /* Set a specific p2m view visibility */
 int p2m_set_altp2m_view_visibility(struct domain *d, unsigned int idx,
                                    uint8_t visible);
-#else
+#else /* !CONFIG_HVM */
 struct p2m_domain *p2m_get_altp2m(struct vcpu *v);
 static inline void p2m_altp2m_check(struct vcpu *v, uint16_t idx) {}
-#endif
+#endif /* CONFIG_HVM */
 
 /* p2m access to IOMMU flags */
 static inline unsigned int p2m_access_to_iommu_flags(p2m_access_t p2ma)
@@ -972,6 +984,8 @@ static inline unsigned int p2m_get_iommu
     return flags;
 }
 
+#ifdef CONFIG_HVM
+
 int p2m_set_ioreq_server(struct domain *d, unsigned int flags,
                          struct ioreq_server *s);
 struct ioreq_server *p2m_get_ioreq_server(struct domain *d,
@@ -1036,6 +1050,8 @@ static inline int p2m_entry_modify(struc
     return 0;
 }
 
+#endif /* CONFIG_HVM */
+
 #endif /* _XEN_ASM_X86_P2M_H */
 
 /*



From xen-devel-bounces@lists.xenproject.org Wed Feb 23 16:07:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 23 Feb 2022 16:07:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277566.474114 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMuB8-0001dB-PF; Wed, 23 Feb 2022 16:07:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277566.474114; Wed, 23 Feb 2022 16:07:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMuB8-0001d2-LN; Wed, 23 Feb 2022 16:07:46 +0000
Received: by outflank-mailman (input) for mailman id 277566;
 Wed, 23 Feb 2022 16:07:45 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=DZ7u=TG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nMuB7-0000w1-7q
 for xen-devel@lists.xenproject.org; Wed, 23 Feb 2022 16:07:45 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id bc23d6cb-94c2-11ec-8eb8-a37418f5ba1a;
 Wed, 23 Feb 2022 17:07:44 +0100 (CET)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2057.outbound.protection.outlook.com [104.47.12.57]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-39-Mp5ajS8cPXuCHFl2xmGJ2w-1; Wed, 23 Feb 2022 17:07:43 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DB3PR0402MB3803.eurprd04.prod.outlook.com (2603:10a6:8:e::26) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Wed, 23 Feb
 2022 16:07:41 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.022; Wed, 23 Feb 2022
 16:07:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bc23d6cb-94c2-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645632464;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=dk/wJhaCBPsVN834p80E6Rx8B0I9ymHYeAZt7XTwLVE=;
	b=B2IxzWMeCA3lBnTGKItqKzvytOyAH1rwSTwDffGCIyfgAYsFI5uZJ7d6cQ5Rl53iZCW2dH
	gt51cZkX9E6aELamYgo2D04woBXfUsIeBZazhxAkS89wG3RmIq4blifiCCS383EJU0t4Pg
	pKqTL8titQbOpUDtbouw9lfsnMCJjOI=
X-MC-Unique: Mp5ajS8cPXuCHFl2xmGJ2w-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=REkXlgEfNQZTJhYzhD5pFP194TG9ZyuUZi/icszPoQb4jMtEzacANdbCh3psAKjNB6yPJjxDwcfMIOsLW/YQZ6KX2Bo87lv6oCh93U7+TDuOyYWuhHLW25ro2wEaCSksIAY/MVgpsFwPYNkbHSKldjvArlBTOYcc+ZywPZgIw8EolaMmmdznlXjpPveh61oJVsWSZhuUeS6CbQuEq4+DcLYCIVegcShx8yXzTdci2p46A7Q2yk1QXIbaTdNGpItHjkKFb6n9mqYUKNylXj3+m/uidB0O5ajVe/OPg7o6JhlWz4Pwkss0t7rtyax3Uk3hNUrXfCx/l4ZZ2xRmZOKcog==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=dk/wJhaCBPsVN834p80E6Rx8B0I9ymHYeAZt7XTwLVE=;
 b=bQHQBOJxcQUJjfBshn3SiU9inATEkk9E84+HNDAvMRmjrcUdL8/q2r3lJWGvqYYvk1sffA5XCTaIREzIFuYUxVIVa4qqMWx//upjOodMnJA0gIRyC3/iB0PwRTamwRn60V7JdRFnnHKE0rrrq8ftTlYE0oswOmpREOnqqrYPSI09wBZ53MmPblhIUG5xrPNUAfpR458UiJZhtt55rbqrqdzRYjLj7OxfHIRhBsuI3WeGbEE4/jXCvDOpzlE2XCBnb6PDBQns2ZOwUqDVnVQ1FoQM7XdJikE2f0d7JyyL0ntWajA7DOUznmEQiWuCIitEghUGg0j537PxLZev7qqDiQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <68f3aede-a740-99b6-8398-35d642cbc654@suse.com>
Date: Wed, 23 Feb 2022 17:07:39 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v2 11/14] shr_pages field is MEM_SHARING-only
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
References: <f4e3bc16-2983-6f5b-37e8-26ac385d4d72@suse.com>
 <f103baf9-ee1b-e440-8fa9-f5009a56442c@suse.com>
In-Reply-To: <f103baf9-ee1b-e440-8fa9-f5009a56442c@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0049.eurprd04.prod.outlook.com
 (2603:10a6:20b:312::24) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c26360f6-187f-4c8f-65fb-08d9f6e69eb5
X-MS-TrafficTypeDiagnostic: DB3PR0402MB3803:EE_
X-Microsoft-Antispam-PRVS:
	<DB3PR0402MB3803658F5D90C30C47BCD245B33C9@DB3PR0402MB3803.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	QSiJjvDzqBRj6fzN3s5U1X3+8zBzuL4SaCz+uZHsbFC/UYGl0CCf4PE24FxqwCGCBla4rKjQmF/yvVSfS5LAWqMJ4WPeyuExGdptKwJ5UEIZQu1kejqqLddPyicsqZwBVDcRUP8Yjpum4zg/SpslcPFORhas3CIxfXj4L93Mo/iCJ3WNN/r26LJOrLduifLBCnjZSvn7I3csOIKc11s3HHB1ECeAtlWG4kfRUSdvHKfQHqYHupWpJOKotNcRJhtFjg2ABqOg7kKFNylsEO4FGLAecRyz4NwNbpIcpnAVif2jPojNLNLr+qo+RXM508GWFbfMi/6geum/TfZdRLvAIevUK9oLMRD+/XmRYovWajqP+CKNmtbBEzLMqNtqWOCL9m2Crhu5T87+KgcEPwt+lSHCNF1mkBBPlxSH7vePrDSf1hc+CuvvHiin01/ltS3ItQZxNYoOM0TWlGx7sQUurVT48JFzSNGqM1F4xc/wgKiLdRsCfSz3U4cfeBd2Z68jzm7i9FdNXRs7vTf45YHRKYnOrJ98gZxmD43gG75OWzb7Fc7SDO9yj6h8L2ZanuJL+4lH5ld7KjlTrcOQYesh/EZU0ZPUlGUPkCJY4PYmD2X56WN7m7aJqlgiN/N57qhdgm97PVMrnNu4SzV63eNqxh9VGdMkWMeoFRSaVp8e10345osJ124S0EZFopgHF5JhakwEFArBHy1y2VjAL8ZImdJm8Erneu9GG70b8dgXU/r3iFLy/YDP0fVvysg9TMue
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6512007)(66476007)(8676002)(6916009)(6506007)(31686004)(53546011)(86362001)(8936002)(31696002)(6486002)(316002)(66556008)(508600001)(66946007)(26005)(5660300002)(36756003)(83380400001)(4326008)(38100700002)(186003)(2906002)(54906003)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bUZ5Z0YwMXF3SkZpK0VGaW1MNTEzbVg3dWRnVGNHN3l3cmtLamIxN3FKdEtj?=
 =?utf-8?B?c2xRTUdqVUN0U1dpTnlTTkowVTd2QXd0cnZmcG1XK1ZnSnd3ZUdHSHpUa3BN?=
 =?utf-8?B?eHFCYVc3ZTRIc3VwVkJTUFhBRmx4eHdIMVlEblRkQW13OHgzVWhNcjk0Mi93?=
 =?utf-8?B?ME52VVUzL3lBZERGS3JKNzZMMk1YOFk5UUZDYmpuQU1kMGhmYjFHVUMyVTNH?=
 =?utf-8?B?MjcwM1ZmVmx6V1JKbUR6bUp6alpWMVEvcmJTVnFaT29qOU5QRnZucFJWZ2hv?=
 =?utf-8?B?eFozWnFuMFFZUjhaM2szMEdLVDBpZ3A3L1pZalJtN3EyQzIzU2kvdTFOV0tK?=
 =?utf-8?B?Wi9uUHlDWWlxekl4b05la05FbW16UUpxQnNBYlovZmh3U3hTakh0TWJCYlJC?=
 =?utf-8?B?bTRNcFFnbkpNUXRMSEl3cUlHT1BabU4yTm1YY0kySEgzcVR5VmtUSEt2SmF4?=
 =?utf-8?B?cHFKc1c0OUNXT0RJd2lZZ2dVd3BrSjkrb0JNZGNQUFVpMUtOa1NLZDNLQnNq?=
 =?utf-8?B?RXZNb2FLbTgvOGdoa3lOQTJvK0VYejQ3eXhnY3V0UGpGL1JGRE9kcjJnL3lR?=
 =?utf-8?B?QmhDWGJYMUNRNTdlVW9ka252b0lsNU93NHhEckNXYTl3NFRIUUMvZVNZRGRq?=
 =?utf-8?B?OWw2aXlYUlRzaytyZEFoVTh2dmhPVklhQnRLdmQ0VTRrdCtGc1M1bWkwV2Zs?=
 =?utf-8?B?c3ZtZ1pmaHJZQlRjR2w0TkRuZys5bTg2Ynlxa3BtQmEyT2o0UGpRN2Vlc3Ry?=
 =?utf-8?B?SWZiU1ZNNmNQb2VWOUpHRFo0NTNUQ3hIUW1WdmhDTmc5TVI0QldyUDVMbU5I?=
 =?utf-8?B?eStrNndVRlI1enJjdVZROVkzcVhUcmwrRkRzNGJpRTlUcHRqWGtIaW04UzZ1?=
 =?utf-8?B?U1QxYjhrTFFPekgwL0pOSVFjamNZeUUycEUzTk9ibUJQS3FNQXg4eUhqMm8x?=
 =?utf-8?B?VnV3elhnY0JVSVBpTmw5dGZHdllCU0tzV0RWN2dJQlpaYkR5VGdqTTNYZnNJ?=
 =?utf-8?B?RHE0NDNkSzNMQnIzK3IrczgzQk5aZjBnQ0R1RnVVL3ZaRUpsSk9kU3hIT085?=
 =?utf-8?B?Z1FXUTlzdjZMMDJqUVZmWFQwcXFxYkNTVmUwQnJaZ1hDQk96YU5OTk12TW9n?=
 =?utf-8?B?dHBGdTc5LzEyZEErUzZjdDZrWmUzWDN3ZHhBcitiNkJUUDRFVWhCRGpSakRh?=
 =?utf-8?B?MWhiMzh5RTBqZzJPY3BSVGdNNVgrZnJTdVBqZTlNdXdXRWRRaXRLOG1NeGUz?=
 =?utf-8?B?UlJGbHArbWE4ZGg5NGJ3bDU2OGFyRmI1L1pyemRXYXJYMHk3YVFud3l3ZDVz?=
 =?utf-8?B?RDQweENBamdMUXdleEN2ZlMvRFZJY2w3VVVkQnNMdjBRakZzZ1VwbXVVdzgy?=
 =?utf-8?B?WWs4cUp4UFdFdloyQTNlQjd6TGtReS9FM0c5Z3Uva1RMeXltS1RtN0UzZ0Fr?=
 =?utf-8?B?UlNDYkRCNXZ6cW1QdDArRkU5Rk50RGtvUjVqd0lvM21TdXhDeGg5ZFp5NTFr?=
 =?utf-8?B?L2ZLYmtuMkNTUUtLZ3AzM3VZU3g0S1RHd0RseWZiSmphVzFJbkhyaVRCVjN3?=
 =?utf-8?B?czdOUW1Da0tXak5FZDNWd1lwZTNqWFhXcXhvMTI5NldoZFhVbGJSaWNvN0Ru?=
 =?utf-8?B?WDJzcmJQdEJVanlGb0ZkUUR4YXZPcVQ3TU44MTRtMml3S1g0bS8wazVZdnlF?=
 =?utf-8?B?M0ZHVXBZTVYzQTlTNTQ2TDJ3bGoyVFo0ZEZJdks5WXVkTWd4RU15ZXNSVWlL?=
 =?utf-8?B?VDVXL3dhMWZJMUI5TG8vUWhZa2FNS3lLRUw3d28vcnQzbzcwSEFrOGJnZkUw?=
 =?utf-8?B?d1g2L3FIbk13WmJzUTFLNDBmS05JN1pCVXBPY21KcXcrUXVsZnZTc1BPaFdq?=
 =?utf-8?B?ZVdxL1gvMGRkeStrbTNKT3d0aTFIdzJLazVHb0tYcGNJWGMyY29VbDBqOEFu?=
 =?utf-8?B?dGVJaUZjUDd2OHdkRDBlUjZGMk1mY0NRNDBFbG1ETk9OOVI2V3FKNEJ2aXJ6?=
 =?utf-8?B?SjdPUkkrYldaTVZjZTVwRUdYS0pXTVU0L2tOQ1NKaWdOZC9XMXNWSDFpQ2NT?=
 =?utf-8?B?TVI2cWc5V1dxNGp2Uk8yNlZQUGRsYXpiMkEzdnZyd00zYUdQanllRTZWYkZp?=
 =?utf-8?B?ck9mMW5vdFI0NHlqZm5wU2wyVWVWb25Rb3dkS2cwelNoNGw3V1JVT2thZFI3?=
 =?utf-8?Q?GG2FiKwGvt/rx0jrKIQoNUQ=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c26360f6-187f-4c8f-65fb-08d9f6e69eb5
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2022 16:07:41.8047
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nVL+4POp0YtKyH/JQt9ZV/KwZ6Jsz2xAO8ikrEs/NuVacGuwlGfidaRjw1avQvjaI6UXkbH7pkVb4DTNY6xVqw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0402MB3803

On 23.02.2022 17:04, Jan Beulich wrote:
> Conditionalize it and its uses accordingly. The main goal though is to
> demonstrate that x86's p2m_teardown() is now empty when !HVM, which in
> particular means the last remaining use of p2m_lock() in this cases goes
> away.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> Reviewed-by: Tamas K Lengyel <tamas@tklengyel.com>
> Reviewed-by: George Dunlap <george.dunlap@citrix.com>

Forgot to add here:

---
v2: Re-base (drop clearing of field in getdomaininfo()).

Jan

> ---
> I was on the edge of introducing a helper for atomic_read(&d->shr_pages)
> but decided against because of dump_domains() not being able to use it
> sensibly (I really want to omit the output field altogether there when
> !MEM_SHARING).
> 
> --- a/xen/arch/x86/mm/p2m-basic.c
> +++ b/xen/arch/x86/mm/p2m-basic.c
> @@ -159,7 +159,6 @@ void p2m_teardown(struct p2m_domain *p2m
>  {
>  #ifdef CONFIG_HVM
>      struct page_info *pg;
> -#endif
>      struct domain *d;
>  
>      if ( !p2m )
> @@ -169,16 +168,17 @@ void p2m_teardown(struct p2m_domain *p2m
>  
>      p2m_lock(p2m);
>  
> +#ifdef CONFIG_MEM_SHARING
>      ASSERT(atomic_read(&d->shr_pages) == 0);
> +#endif
>  
> -#ifdef CONFIG_HVM
>      p2m->phys_table = pagetable_null();
>  
>      while ( (pg = page_list_remove_head(&p2m->pages)) )
>          d->arch.paging.free_page(d, pg);
> -#endif
>  
>      p2m_unlock(p2m);
> +#endif
>  }
>  
>  void p2m_final_teardown(struct domain *d)
> --- a/xen/common/domctl.c
> +++ b/xen/common/domctl.c
> @@ -109,7 +109,9 @@ void getdomaininfo(struct domain *d, str
>      info->tot_pages         = domain_tot_pages(d);
>      info->max_pages         = d->max_pages;
>      info->outstanding_pages = d->outstanding_pages;
> +#ifdef CONFIG_MEM_SHARING
>      info->shr_pages         = atomic_read(&d->shr_pages);
> +#endif
>      info->paged_pages       = atomic_read(&d->paged_pages);
>      info->shared_info_frame =
>          gfn_x(mfn_to_gfn(d, _mfn(virt_to_mfn(d->shared_info))));
> --- a/xen/common/keyhandler.c
> +++ b/xen/common/keyhandler.c
> @@ -274,9 +274,16 @@ static void dump_domains(unsigned char k
>          printk("    refcnt=%d dying=%d pause_count=%d\n",
>                 atomic_read(&d->refcnt), d->is_dying,
>                 atomic_read(&d->pause_count));
> -        printk("    nr_pages=%d xenheap_pages=%d shared_pages=%u paged_pages=%u "
> -               "dirty_cpus={%*pbl} max_pages=%u\n",
> -               domain_tot_pages(d), d->xenheap_pages, atomic_read(&d->shr_pages),
> +        printk("    nr_pages=%u xenheap_pages=%u"
> +#ifdef CONFIG_MEM_SHARING
> +               " shared_pages=%u"
> +#endif
> +               " paged_pages=%u"
> +               " dirty_cpus={%*pbl} max_pages=%u\n",
> +               domain_tot_pages(d), d->xenheap_pages,
> +#ifdef CONFIG_MEM_SHARING
> +               atomic_read(&d->shr_pages),
> +#endif
>                 atomic_read(&d->paged_pages), CPUMASK_PR(d->dirty_cpumask),
>                 d->max_pages);
>          printk("    handle=%02x%02x%02x%02x-%02x%02x-%02x%02x-"
> --- a/xen/include/xen/sched.h
> +++ b/xen/include/xen/sched.h
> @@ -385,7 +385,11 @@ struct domain
>      unsigned int     outstanding_pages; /* pages claimed but not possessed */
>      unsigned int     max_pages;         /* maximum value for domain_tot_pages() */
>      unsigned int     extra_pages;       /* pages not included in domain_tot_pages() */
> +
> +#ifdef CONFIG_MEM_SHARING
>      atomic_t         shr_pages;         /* shared pages */
> +#endif
> +
>      atomic_t         paged_pages;       /* paged-out pages */
>  
>      /* Scheduling. */
> 
> 



From xen-devel-bounces@lists.xenproject.org Wed Feb 23 16:12:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 23 Feb 2022 16:12:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277582.474149 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMuFH-0003Pk-Oq; Wed, 23 Feb 2022 16:12:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277582.474149; Wed, 23 Feb 2022 16:12:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMuFH-0003Pd-KI; Wed, 23 Feb 2022 16:12:03 +0000
Received: by outflank-mailman (input) for mailman id 277582;
 Wed, 23 Feb 2022 16:12:02 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=SA1M=TG=citrix.com=prvs=046235e00=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nMuFG-0003PN-6e
 for xen-devel@lists.xenproject.org; Wed, 23 Feb 2022 16:12:02 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 53b1d626-94c3-11ec-8eb8-a37418f5ba1a;
 Wed, 23 Feb 2022 17:12:00 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 53b1d626-94c3-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645632719;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=7xbFPH2Li6TZCQyrZw7+GvHiHu6zB9SvWjpmMapUFEs=;
  b=fCCmq1hMYNfjJYBQEfjmirnwQi/Fzk1yW93KQRX3BnLJemfZU8t6Ya7D
   1cKYtAYYLJTQhTfbuizVl+nK940utnsIVr/Ju9GmIl8A7mhwgjGpuXJcD
   1IqvVUXKdnj967kntfSZNpWNH75/TBJteP9qeBnSpe9h1VZ14cajroAgI
   g=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 64266158
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:mBGom6yFoI1sKJGK5UR6t+c/xirEfRIJ4+MujC+fZmUNrF6WrkVVy
 WJLWWDXaf3bY2rxctAjOoS3o0lVvMCDy4ViS1ForCAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGHdJZS5LwbZj2NYy24PhWWthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 Npl9qyoEQUzNJL1tc8NUQtJUApAYYZl0eqSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DJoQQt2sm1TjEJf0nXYrCU+PB4towMDIY2JwUQ6iHO
 ppxhTxHMj6aYQ9NOnUuM58Tt+Op1yf0cQEJkQfAzUYwyzeKl1EguFT3C/LFd9rPSchLk0Kwo
 mPd43+/EhwcLMaYyzeO7jSrnOCntT/7WZlUFab+/6Zum1qV7mMWARwSE1C8pJGEZlWWAowFb
 RZOo2x38PZ0pBfDosTBswOQ406c5hwGUeVpPsYq6hOciYHqvy26Lz1RJtJeU+AOuMgzTD0s8
 1aGmdL1GDBi2IGopWKhGqS89m3rZ3VMRYMWTWpdFFZevYG/yG0mpk+XFr5e/LiJYsoZ8N0a6
 xSDt2AAiroalqbnPI3rrAmc01pASnUkJzPZBzk7vEr4tmuVh6b/PuREDGQ3C94acO51qXHb4
 RA5dzC2trxmMH10vHXlrB8xNL+o/e2ZFzbXnERiGZIsnxz0pSL+IN0OuGEkeBg5WirhRdMPS
 BWP0e+2zMUOVEZGkIctO97hYyjU5fKI+SvZugD8MYMVP8kZmP6v9yByf0+At10BY2B3+ZzTz
 ayzKJ72ZV5DUPwP5GPvG481jO96rghjlDi7bc2qkHyaPU+2OSf9pUEtawDVMIjULcqs/W3oz
 jqoH5HUk04GCLWmOEE6M+c7dDg3EJTyPrivw+R/fe+fOAt2XmYnDv7a27Q6fIJ52a9Sk4/1E
 ruVACe0FHKXaaX7FDi3
IronPort-HdrOrdr: A9a23:FGqhw6HXRh1aaZ+GpLqFBJHXdLJyesId70hD6qkvc3Nom52j+/
 xGws536faVslcssHFJo6HmBEClewKnyXcV2/hrAV7GZmfbUQSTXeNfBOfZsljd8mjFh5NgPM
 RbAtZD4b/LfCFHZK/BiWHSebZQo+VvsprY/ds2p00dMj2CAJsQiTuRZDzrdnGfE2J9dOYE/d
 enl4N6jgvlXU5SQtWwB3EDUeSGj9rXlKj+aRpDIxI88gGBgR6h9ba/SnGjr1wjegIK5Y1n3X
 nOkgT/6Knmm/anyiXE32uWy5hNgtPuxvZKGcTJoMkILTfHjBquee1aKvW/lQFwhNvqxEchkd
 HKrRtlF8Nv60nJdmXwmhfp0xmI6kdb11bSjXujxVfzq83wQzw3T+Bbg5hCTxff4008+Plhza
 NixQuixtZqJCKFuB64y8nDVhlsmEbxi2Eli/Qvg3tWVpZbQKNNrLYY4FheHP47bW/HAbgcYa
 dT5fznlbdrmQvwVQGYgoAv+q3nYp0LJGbIfqBY0fblkAS/nxhCvj4lLYIk7zU9HakGOul5Dt
 T/Q9VVfY51P7wrhIJGdZA8qJiMexrwqSylChPhHb2gLtBDB07w
X-IronPort-AV: E=Sophos;i="5.88,391,1635220800"; 
   d="scan'208";a="64266158"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Dm0VmABYKOvW7td/RVFj6m7TkdsOvsAKcPbhs3mpXLhJPX9znC0lyMaWVQ8/swBPtAB/5GRuIPA1iCI1XCMMYtUiGaZqMSZPxOreFolr0yQnzxyOIjGSkNR12wUa68T+CGGvxc3I9SzGV0hskE8m3gQizcN2bZ5OfmrXZ5ebY52kmw64GEN2P0gzkCECLwgXbmyzqHfJRTnWVzABLZX2F5nOiKnIwbJ7jcM2LwaDWTmNODsKB1ZEQA318Wu5IApEF4gDIDMREC+wejIATK4hd0FE6yx1GOjac85UsTrMNTPPNBvEiYQvOMYx7enBAcq+kdo9Pc1wOAbakg5yvsyToA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=yanYrsGJL/uOVrabryc0fZ4FDX9w63P6n48/TQkTPlk=;
 b=ZAcOr0GevjZgNef2NCivQ09UYgSjf1wWXzS7m/WBN5vd7fR9L30gFcc3l/vC4hi1Z2W21aLUSaEopf6o+5Mh+Dx8sp6cM/kPfflBYYqjyG7fnmnIra7Tij5CqiTO8kNSlhp3IlIzeXGQusmTlWmnaD1/5lZgOPiIMw5EW7k+B4dTPKoWFtinLxfCZARIu0QGn6r9LBFHLH4wQlTZyE02JrkHO1YGhXFp4vOKns1h0an53HVJmAkiiun6Y1WRhFtYlAC5M9SLh7gF7efKqwi3pxmEKhvNLgaCSs1lzc4MpXBcKSG8WXZtBhx62PBm6Qqi1JUr2otDo8vKrwu6BdS4HA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=yanYrsGJL/uOVrabryc0fZ4FDX9w63P6n48/TQkTPlk=;
 b=Q/Bh16SEmfcyWslVcw+2KuaJDBABOAdN10AzuGVRKfwpB8Z4JVZbrrNcMQ7jZdQYJ2lBH3CzwA22UqboBxitPHkb6i4GAJbhSkv1fq/bT+A1GxHEdN3/Pz4S66hkjelGoig66/1OmEaI+qwT2JWywmAUIyxjzoLByUSi05yeJCY=
Date: Wed, 23 Feb 2022 17:11:50 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Alex Olson <this.is.a0lson@gmail.com>
CC: Andrew Cooper <Andrew.Cooper3@citrix.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [RFC] Avoid dom0/HVM performance penalty from MSR access
 tightening
Message-ID: <YhZcxkY/BgPy/MTh@Air-de-Roger>
References: <949b4776e23e4607776685a7e2705b9e77f5b717.camel@gmail.com>
 <a1099ae9-9e0d-cf54-e786-835c13f2ba40@citrix.com>
 <d11e54d47776008c17762458e6abbd44ab0beed5.camel@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <d11e54d47776008c17762458e6abbd44ab0beed5.camel@gmail.com>
X-ClientProxiedBy: LO2P265CA0457.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:a2::13) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 07274b30-0621-4243-5a97-08d9f6e73600
X-MS-TrafficTypeDiagnostic: DM6PR03MB5276:EE_
X-Microsoft-Antispam-PRVS: <DM6PR03MB52766363386C90A6D06F8F648F3C9@DM6PR03MB5276.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 7flEBygXz6MYabB9B0aqgr9iEt4fyp7+z9jUgpjtGosVTSGz/W2TBizUMaFve4SIOwcLWbA0UjK3OWyre9NYag6Y4jmadHnw/c+JIDuprBYkPy3GcxhhiXaJmrjOxKk2/gRAwXUY525xAZqMB5W2FvCRCg4r/hH7M2Q+lCL7zpAdHSALQJHrQZoy1Tih8ztAwARrn2rK4eEGAdMW+9nYtKVsi7BZAz/mOfvh51/y0wF8BGj/DjFSQz5ci1V78CyxEYWT7qZv+uF5JKKdGrkUJcKNjWw0pzLf8KEiHUAwNMOWYVC8j4q0n7u3Ek4MQNIzCM9mHQhsEV89pBjjEVar9xKG5u8x2N013aEetqNkZbtXiH8XJiVgguB48ARXHLVrdJLzxpT/0mUwTTit7mICXv2hbihpACSnEnCqdHNLTyQShPgDzMorIODWn+LGbtOMfqnUea+NlcvHeaynIfxeRH8gWGnzMi+6ML4l3gHItQBrWs5nSN45VVd6y6JiGgdQcDtBsTkuqCEOCeyI31bnYprkyHnqT2IOgYVeZ2j1bu3IL9sBcTnmFMngidqKIJEjCSQ7SIfLw3+sJpbPEvf54n139DDAz/IP6bNC9WxuLihpKl7CLD4zpdDYqOUCbRKgnPwkiiLAUARDMplOc5Tc9A==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(85182001)(83380400001)(186003)(82960400001)(6916009)(26005)(2906002)(316002)(54906003)(38100700002)(4326008)(6506007)(6512007)(9686003)(6666004)(5660300002)(6486002)(8676002)(8936002)(33716001)(86362001)(508600001)(66946007)(66556008)(66476007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZDdqMFNXOE11b1Fub2gvaEZGbEdWVVFxUnI2aUtRbHBRYmFHWHlVcUJHT0Jx?=
 =?utf-8?B?cG84dnhmaFVaNHlTaHB2dWlUbmNGS24yVzBvNlZNekNvZjJBVG1lYUlZb1Aw?=
 =?utf-8?B?eE1MdHVVRE9QSmlYYUJCdWkvNHMxS3VDMVZEYkR1VjVNUGhyaWJWbVlWSk9I?=
 =?utf-8?B?Yy9YTDNuNFE4RXRrWnZwVnpTTXorNTdPRXJmcG13OEtRaDJILytKcWIybkxu?=
 =?utf-8?B?UVJTOXJQbmEreHhPTVBiWjBxeHloTm14VjRmQ1NpZk9OU1NHeHFhOWZDSjBJ?=
 =?utf-8?B?bHlQdnpuQk5IY1p4aEVxbytNOEZLOHYra1krZXM1M25pVVB3SC9xT0ZWMkFa?=
 =?utf-8?B?dHdVRTE0SXJaUVpFRCtoSk83bGRnbzR3VXFaTXc5aDNhRlB1Q2JMY3ZTdG1h?=
 =?utf-8?B?U25WNk1RTDNFYk4wWDF5UVJIYU1HY0VUVU9uUEtwQWUrWWVaaTNTM0xFdWtt?=
 =?utf-8?B?QzFmd1A0RThkaHRmRzgxYk5YeHc3WkJtNTQ4M09HS01tL3FabThkSTJGNnIz?=
 =?utf-8?B?ZDFhWEYzcHZlVVgrUGFOYmk3bHRJYnY4OExFb0JzODBsMXQrZVlVR2dCQytW?=
 =?utf-8?B?NkdSL1lPZENUZmtPU1Y4Tk9VNDQ3UzZZaENoVkZyZC9pZk5JVVMwNzhIYytC?=
 =?utf-8?B?MXN3cWRUeklENGdKVWZjTmdZYWE0aEFSNG9ENUtjZlJPcVRpN2NvWVA4Vm11?=
 =?utf-8?B?eEN1ZTkvYmVWRVpxRWhPUWM2N2lxa21MOEZiWHlGclY3cnFqTjhDYmgwN1Ar?=
 =?utf-8?B?VkZtZlRjYkxhN09OSHk2YW13bE5tNXo4dEN1QWYyZTVYZ3NkUjJKSmswQm9a?=
 =?utf-8?B?UzVKR3FnbXB2bURJK2J2WUtSVk9ZRmw1emQ1OUo1TmUvaVRPQ2R2anJhOUNG?=
 =?utf-8?B?Wm5YSTFnZkpkOVNKYW8xblRWTHhPZGxETU1mMGRUZi9zTmF1cUI5eEhiU2Yz?=
 =?utf-8?B?UWhEN3lwS0Jkc045eUFGTXJnN2RYR3JVQkk0Zm1OWktGbkpSdW0yRmM3RVNL?=
 =?utf-8?B?cnByc2psdUFiNDVHSlpRVG9USmtHQmgwQWRsRUEzK2xyc0J4WWZqK1AxK2Jh?=
 =?utf-8?B?U0FUK3hNSTlUcjNnVE9lSzVNaFpxKzFWU2tvNkFLQXpjNEpaV3hndlE0OTNW?=
 =?utf-8?B?RUNxR2UxbVRUYVV5czlvVnI3QlhPY2FjNStVTnJTQy9QMVNja3podUJCeXBl?=
 =?utf-8?B?dzQ4eEhITmdWYk1uUFpxUW9rK00zZElxSTV1alRpOGxKUHpWc3JXeEVsNHJa?=
 =?utf-8?B?eDdhR0loaGVwWit1aDF3UWtVYm5LVWxpSlZQWHdlTEM0MldWTUliN2VBbGt5?=
 =?utf-8?B?UEozdzl4dXJqVUd5VmZBdG1XY0RMSEtoc1hzT0d3VlpCRkFuQVhvYnBqZkwr?=
 =?utf-8?B?bzU0ZXlHYU9YY2NyY3N1d1V2WmRRQTJsNkIxRkpvYitNQk1ieTJjbkhNSEQ1?=
 =?utf-8?B?WnlkRTJPZzR5QXkxNUtXUHdZeHhjalVEK0hrdXBqdS94UTdnL3lCeWMvYjBT?=
 =?utf-8?B?NEJHRUswdGlnVklEYng0aDgyUTBMNStkVFc5MyswNXF5UFZVTjJ5QnM5VFVu?=
 =?utf-8?B?cEw1Y2hIdGNqb0VaSTlENzNLQkgvVEllSjhxVWtTQkVwdW1renBaczlndTBK?=
 =?utf-8?B?SlVYR0U2M1Bjb3RyN1VzTU5MUkVockVuZThMaWVMeFRiU0tYN2pCdjE1dkI2?=
 =?utf-8?B?VEdCb3NSMmwvc3hObCs0WWMrSGtPYzN0VVZnS2ZSZ3BqemlJY0xqUmhTc1RM?=
 =?utf-8?B?ZW5kOXA1MU9YeG1kMDdtL2lJTkJNelNyWC9pUGhpb2QzMVRTMHVXNGtNdUx2?=
 =?utf-8?B?TG5JVHBhaTRYd2lMS3I3K2RHa3JlRU1zZWZXcVdmajRjM2o4V2orQ3BjUzla?=
 =?utf-8?B?QnFqSGR1dk1yaGIzRFZHaHFHTUNkd0EvWXpaOUZ4dm9LcStSQUdpeUlMRHgz?=
 =?utf-8?B?VFhvcG9JTDEwUTNRSTVGZHJCOG1mR1dJdW9jT1k1aVMwcHJybFFqd0VCSHZo?=
 =?utf-8?B?MG9PbXNGemJaWVhSa0ljL25qQUhHZWxwaUx3TVY2M3lqaGRrQTJaMkdDZmV3?=
 =?utf-8?B?UEw5bFpoeXFKNWVWMkRIbWNrcUVlVVVxR3RPVjBXU2I0MUsyMkR2UFo2clpH?=
 =?utf-8?B?RnM4SHlIckM4WERoMGZyY1JsQmlVL1E3bXhLdDZFQjgrZ29tTURRVHF5bzVr?=
 =?utf-8?Q?OiICTSGMbyY8iUG9YzGImW0=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 07274b30-0621-4243-5a97-08d9f6e73600
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2022 16:11:55.5225
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: M/Kx6a7bRhHbhbBmui0xdEaWq/1vMnDcMzIbSub2TWInxYAJZvbrCABJ0JFJPwF8+Zcjuknb5vNlSyQMVdmnBA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5276
X-OriginatorOrg: citrix.com

On Wed, Feb 23, 2022 at 09:38:56AM -0600, Alex Olson wrote:
> I appreciate your interest, apologies for not replying right away. I've been
> digging deeper to have a more meaningful resposne.
> 
> I had attempted to instrument the MSR reads, but only saw a small number reads
> being blocked by the code change. They appear to be the list below and the
> others seem fairly harmless:
> 
> 0x00000034	MSR_SMI_COUNT
> 0x0000019a	IA32_CLOCK_MODULATION/MSR_IA32_THERM_CONTROL MSR
> 0x000003f8	MSR_PKG_C3_RESIDENCY
> 0x000003f9	MSR_PKG_C6_RESIDENCY
> 0x000003fa	MSR_PKG_C7_RESIDENCY
> 0x00000606	MSR_RAPL_POWER_UNIT
> 0x0000060d	MSR_PKG_C2_RESIDENCY
> 0x00000611	MSR_PKG_ENERGY_STATUS
> 0x00000619	MSR_DRAM_ENERGY_STATUS
> 0x00000630	MSR_PKG_C8_RESIDENCY
> 0x00000631	MSR_PKG_C9_RESIDENCY
> 0x00000632	MSR_PKG_C10_RESIDENCY
> 0x00000639	MSR_PP0_ENERGY_STATUS
> 0x00000641	MSR_PP1_ENERGY_STATUS
> 
> As for my test program, it is just a crude loop compiled with "gcc -O3",
> normally takes about 10 seconds to execute:
> int main()
> {
>     for (volatile int i=1; i!=0; ++i){}
>     return 0;
> }
> 
> The relative changes in execution time of the test program and also that  HVM
> guest startup time (associated with the "qemu" process being busy) completely
> agreed.  I also observed the same changes under a PVH guest for the test
> program.
> 
> Thus, it seemed like the CPU was somehow operating a different frequency than
> expected, rather than faults consuming execution time.
> 
> -- (after a lot more investigation) --
> 
> Further instrumentation showed that the
> IA32_CLOCK_MODULATION/MSR_IA32_THERM_CONTROL MSR initially had value
> "0x10"  which appears to be invalid both in the Intel Software Developer's
> manual and what I think I'm seeing in the ACPI tables.
> 
> In dom0 Linux 5.2.38,  this value seems to have caused the
> acpi_processor_get_throttling_ptc() function to see an invalid result from
> acpi_get_throttling_state() and thus execute __acpi_processor_set_throttling()
> which wrote the MSR with a value of zero and had the side effect of disabling
> throttling (restoring normal performance).  (This all happened as the CPUs were
> detected).
> 
> When the unknown MSR reads are blocked, the call to
> __acpi_processor_set_throttling() did not occur since the MSR read did not
> result in the invalid value -- thus the CPU remained in a throttling state.
> 
> So far, this seems to explain the dom0 performance issues I saw.
> 
> The domU observation was related... In some of my testing, dom0 was limited (via
> Xen command-line) to a small number of cores so that the others could be
> dedicated to other domains.  When a domU VM was launched on the others (not used
> by dom0), its MSR remained at the original value resulting in low performance
> since dom0 hadn't a chance to rewrite it...   Thus, I saw different domU
> behavior based on the number of cores allocated to dom0.
> 
> 
> -- summary --
> 
> In desparation, I ended up resetting BIOS settings to defaults and mysteriously
> this issue doesn't occur anymore.  Not sure what could have gone wrong before as
> the original settings were not far from defaults.  It seems my issues stemmed
> from the server's BIOS setting the throttling MSR to an invalid value but it had
> illuminated some unusual behaviors under Xen...
> 
> It seems to me there are a few findings useful to the Xen developers from
> venturing down this rabbithole:
> 
> 1) For conditions in which MSR registers are writeable from PV guests (such as
> dom0),  they should probably be readable well, looks like MSR_IA32_THERM_CONTROL
> is currently one of a small number of "unreadable" but writeable
> MSRs.  Otherwise seemingly valid read-(check/modify)-write operations will
> behave incorrectly under Xen.

So it's one of those MSRs that's only writable when dom0 has it's
vCPUs pinned. We could allow dom0 to read from it in that case (that's
an oversight of the MSR handling rework), but it would seem better to
just remove access to it altogether: it's bogus to allow dom0 to play
with the MSR in the first place IMO, and it won't really solve issues
like the one reported here unless dom0 vCPUs == pCPUs and all are
pinned, so that dom0 can fix the MSR in all CPUs.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Feb 23 16:27:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 23 Feb 2022 16:27:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277664.474448 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMuU2-0008RL-Tb; Wed, 23 Feb 2022 16:27:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277664.474448; Wed, 23 Feb 2022 16:27:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMuU2-0008RE-QN; Wed, 23 Feb 2022 16:27:18 +0000
Received: by outflank-mailman (input) for mailman id 277664;
 Wed, 23 Feb 2022 16:27:17 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=DZ7u=TG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nMuU1-0008R8-Iy
 for xen-devel@lists.xenproject.org; Wed, 23 Feb 2022 16:27:17 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 76b88c9a-94c5-11ec-8539-5f4723681683;
 Wed, 23 Feb 2022 17:27:16 +0100 (CET)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2107.outbound.protection.outlook.com [104.47.17.107]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-28-HbQXPRPDNSK_r68BxkW_3Q-1; Wed, 23 Feb 2022 17:27:14 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AS8PR04MB7862.eurprd04.prod.outlook.com (2603:10a6:20b:2a1::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Wed, 23 Feb
 2022 16:27:13 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.022; Wed, 23 Feb 2022
 16:27:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 76b88c9a-94c5-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645633636;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=ZHvaPd6DZRY/CUTgr7uDsFTCgjGjrQW4ENvwC/TxBmU=;
	b=D7u2z7jr1VdQQ/CWN2Nbw7ZsX+On0Dn8LfUuBzXZUmP7hgDth/mQgs3pdNmm6bX6Qx/f9L
	j/7X11Mtuyz6/NNtuMfAwVDqO+LErtMk4HwdpCc7rWdrsnkJD7PPKaqv+H8ukoeY5ogwer
	f2+lbpaR8zmQI7Lexy3iJvP4qNyK1yc=
X-MC-Unique: HbQXPRPDNSK_r68BxkW_3Q-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=M+QHMRBBLJatEsNQCEJv8efy/r8y2l2i2a1RdWH45udgynlBYT1DwdhQ7hJ9+B9Iguk+uulwfVp5+2Uub0lgVBPQEtjXRcdr5Ulq++BhvWeZDyl4yyR3nQCd8MWmcRw81NK9qgzAddQqcnnWunsrqyD8vDHaCyNghRPsshMd3Pc7SyuznHfaLU2oyhyqqq02ut4ns8AVkzTBY+VP4DTrDqMf03rhiINIgh1iFOes+H/EbbVMTf/BZgL44TdF1nF3xHoyYte+gS6CTSn9D/5bGx6xizS019sjBV+SITd3olYlj7VHIAN3vwPBp6vkhfYFxfo0iL8ZQeEQ5Z2wNirTWw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ZHvaPd6DZRY/CUTgr7uDsFTCgjGjrQW4ENvwC/TxBmU=;
 b=PG/8IhbSVGI9uOkqnQiFGId97U/8Asrpvni+r44gTL1E3A1i9Rg4sHZmvtdRGq9au7Z7jcqkCZugTSXmtHAg2eX8f3I36p0XHMsiP06/X9zAwNsBvWSZFX7BS8otmEM5WvAdk5LXFmh9bN8FuiXkPS+TOKNVMIQ6u0TY3p2Es4O26vgPEsMCID0Rl0bQv+XvEKVEp6IU0Dr+/P0XeaLZ0oU4gsRtu0kJJStL9na/HYYnFsHAF9MtPIRqm9fc0GkbBTr/mjdEa+Swl/C6U16CQ6fu267k49jfYOB/QujumzL1KAzsVlGZPt5xCqCAbxr6eSHewiOQLzYTKsKkZ3K23w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <e0004cd1-6082-853b-a6e4-9dbd530fcce2@suse.com>
Date: Wed, 23 Feb 2022 17:27:11 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [RFC] Avoid dom0/HVM performance penalty from MSR access
 tightening
Content-Language: en-US
To: Alex Olson <this.is.a0lson@gmail.com>
References: <949b4776e23e4607776685a7e2705b9e77f5b717.camel@gmail.com>
 <a1099ae9-9e0d-cf54-e786-835c13f2ba40@citrix.com>
 <d11e54d47776008c17762458e6abbd44ab0beed5.camel@gmail.com>
From: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <Andrew.Cooper3@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
In-Reply-To: <d11e54d47776008c17762458e6abbd44ab0beed5.camel@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM7PR03CA0020.eurprd03.prod.outlook.com
 (2603:10a6:20b:130::30) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a01bf03d-cb31-4195-1f67-08d9f6e958f6
X-MS-TrafficTypeDiagnostic: AS8PR04MB7862:EE_
X-Microsoft-Antispam-PRVS:
	<AS8PR04MB7862879B45DC01B7D7AD082DB33C9@AS8PR04MB7862.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	QSk7uVxafBn2JzxjemVYbo+AYvIHvySFvD+I4q/dMlVdvAMc4M3jdPeK6MGp8b5fUmwOCb8ah2PsIfPMzeHfezYMk2LSahAZJJ05M0C2CpNxAoppKxA7CNvE4trWGzdIRqBu1JIT/8aNsRFTYLF9xlLgu3CfaoY3Ax/s10LzYMNXhWpW8Om2RmAJ3nj4UXFioFsUyod3r1HgejWU8d8YweiKO4P18jYhEZzO9HV+GZ4evIOARYWOACM/viGfHY3bkG7ZfI7Nxg6ipzS1O4VMKMIsaPBvrj27hJxy2VDWHto6FdZpV7qLkhEkLDVAei2T0TZs1uAq2E13O77Bjy+4CMl7+Xx3I5tCnJetibJLsIN1R1oLNSwxkQ5+Kkchk4eTeKq6cZJWzSWTvd0ZW1tlRltj/inLdbk6MWCzCjDUnaX8hO1NbFletXQCeNeti4gnpxbBkImvtPkz6Qp7Uk3vgyv5nReobm6GpzE7fHBa3VH5vUXzRsz+69R7Va/cfFOoQhIWdR4jBgLugJZjmzKEvbZk/5+92cnNWJxTcSvlWtnGhucK4/7BTb2hLvwISXxE2bTM36RSCjavA24odlXp79g0BA2sV6rmktpqukdCpnArzsaxxJqyywir+lFgeNbtXgCkw8+9i1OliNq4HaZPatnIYLeYi9NAhVgoGarXQK67Gx9eVjDXJv6CGDpQa2Xd0JgZyJDZhsAzQGiexqdVsxxyU+mb23B+l3hp6zmc1Fg=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66476007)(4326008)(6486002)(8676002)(2906002)(83380400001)(31686004)(66946007)(186003)(26005)(8936002)(5660300002)(36756003)(38100700002)(66556008)(54906003)(6916009)(508600001)(316002)(53546011)(6512007)(86362001)(2616005)(6506007)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VGJKSksrb25uTlVJL3E1b1ZGNkF2cERMallMeXVmcjdFQk9TeGVyY2M0b3BE?=
 =?utf-8?B?aktadWFmMTFCQnJySThSN3BvYVZ4UFJ5MG1PaVZpVGNvMER1QThyc1pGNTdy?=
 =?utf-8?B?cThrU1U2TGduUndGTmIxSFB3NDcvSFFlcGVFL3lYalE1OW5yK3RLUzNwM1N0?=
 =?utf-8?B?SkRHcVRpNE56T2w3V3ZCbE8zK3pXU1psZmVCdlJ6WjJKdWh5MkMzUnlUalVI?=
 =?utf-8?B?dmRBYm5sSnNFRHJTUjZ1aDdQMTQ3L1R1K2JVQzVzN05DemlmcGVjQTBiMldn?=
 =?utf-8?B?Ulp2K1cxaTZqVllwZHhZeE9iNGVoRTZSMHpaVTJ4YmlvQnNtb3NVVFdLR056?=
 =?utf-8?B?MEVOZkozRDNyOUwzZVZGV29FYndsbmtMb3JMbys5N2N5YkpHK2NEaHZrMWpu?=
 =?utf-8?B?ZjMxT1ZlU25GdHdGWndHM1hrZUlkY3I3MG1mQmtDRWpoZi9wdmh6VGhVZ1dR?=
 =?utf-8?B?cCs5YkEzKzFVV1diS1pabTYraE1meXEzTncwRHpOSzY4YmU0MW1YeUtIcTFw?=
 =?utf-8?B?MVluUXhmcTl2dDZLUjdJeW9LWVd3K2tRblJtRjk5am1WMHphbzZ0akpSUXlB?=
 =?utf-8?B?TVlaTFJvRFJZY2JIU3NRRUlOdkhuUi9OTiswVXBKQ2dBQVRuUWcxL1lnZDdv?=
 =?utf-8?B?UXdHQVdwUzVQcldySlhGenRVN1JNV2lscUlTQXRzTjhxanp1VkdnQkNPL0Vl?=
 =?utf-8?B?MlRVR3Y1a0tUUlVIanNjd3JwQXhLMTEyWUR5TkpsTUU0MzBwbjdFczZaS1E5?=
 =?utf-8?B?NDk5RjcyZWJNSnpRZHVqM0pWUy9Ic0pNV3gvbFJobjM0MEphVFB5WlFpUlVQ?=
 =?utf-8?B?UTl3Q01uSmVBVG4reng1cUxMOWVuQ2FrRXJKWGhRN0h2WjExdWlORlZmOS83?=
 =?utf-8?B?S2h0ZVpBWnVHUzdueWlkdnd1UWJtakZEOTJoTUYxTU8vbkdNMjZINlpqSFZx?=
 =?utf-8?B?dFJVc2xKNTlyeFl1VUpEOVo4Qmt3c3NHRXNBTEtaYWJmOHNQemxZM0hmUGJo?=
 =?utf-8?B?NFdRSWdmWE8rN1FObFhEa2VuVDMxeE5DQ1RQT0ZBWUdrazgyV01LYXhycVdr?=
 =?utf-8?B?OUZjUmNzZmFYNFBmaFRrN1R4RzljcitBZjd5WlhvamxpTWszNWk5V0M2L2dU?=
 =?utf-8?B?M29hK3k4ZW1pVW5uaFJYcG43Ry9mSmwyNUZpL3ZjMlMrTCszRVRmOS9aSDVz?=
 =?utf-8?B?cFhjWDI4L3dvaGRTcFlwZ2QwM1c5b1NWRVVycldoSWNwR3pHTTU0cVlUakJN?=
 =?utf-8?B?NmR3YloxR0xwZmNRdlpEMEZSakE2SEx0U1pBYWZOUGt3ZFM4U0wySmFQR2NI?=
 =?utf-8?B?VS8vWk5jRTZCeVZCQ0hiUitDc2FlaE52RzNiQkZBdXZJRG1rVFBHODduTTdz?=
 =?utf-8?B?Sm9RbHZ2UlpmZFJrNzhKS1poZXJIaFZPWnFZUVEySTRtRit0M1ZObXQvNjlr?=
 =?utf-8?B?akV2VXdNLzBpRTBkbDNybk94NFVka0x6Nk1yc204VTh0Rnc1YnNsZEwva3NW?=
 =?utf-8?B?d1BSOG9tNisvSnR6Y0VkYjU0aVg5bEp0SHUwTDN5bk8yR2Q0bXpNcTFlUFVh?=
 =?utf-8?B?R2Z3d3JsSlNIcDNWYUdpSlhieFk1Nk1Sa0s2Qmx2d0ZBWUVTWU9TVmx6dFpJ?=
 =?utf-8?B?NlViNGZjWDhySWJEdXlFcGFDSTMvVEhTS3NJcGgrakl2V3dIRlNpZ3dNeDE0?=
 =?utf-8?B?SGZYa1dzb05Fd05zeWtVSW83TE5GZUVWMGM0UVl4RTR3cmhSdnhMaHZodlhV?=
 =?utf-8?B?WXBJN1J1WmsvQUE2Q0JMcm5TK2FQMURIN3BOejZLR0lqQktqNjBKUVk1T2tR?=
 =?utf-8?B?aVJMSGRTRW5vVFhRYXBqZDdMTTVKdC9JbStEenpNajdrZ2lISmYxc2hGVVYr?=
 =?utf-8?B?R1dBeEIvYXVLcUJGQ0dZUENmdmlJaG9ndGxVM1dFcjRDbENxZkxpeFNMaDl3?=
 =?utf-8?B?VDRUU1UwNnFTZEc1NEQ2RGkyV3dHaEsvc0tCT1dHNXYvZjlnS0YzNUdZeUFM?=
 =?utf-8?B?eFlaVFZUN0pPVEFjN0RFZDFqMFhQR0d2ZU1xY05DNm9OWkwrYzRZSEFvQ3Ft?=
 =?utf-8?B?Nkp6T250VEdGSHlaZUE0YXQvTng0WDhFZXNIeXlSbGttOXhRSWdGcVpITDFz?=
 =?utf-8?B?K0JDZ29TdVVUV0JIMHlXZktjRVVDNUJQM0tBZEFUbTZ6amJ1NWQyVjZzM1Nw?=
 =?utf-8?Q?MyD70hZJpVseAxXMka4GJ90=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a01bf03d-cb31-4195-1f67-08d9f6e958f6
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2022 16:27:13.1692
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uF4BxrAHQVZaHTGq7gHM6Uv4UdLEV1eZcYWk/ljG9boe68Y6MDZK0HX/lHlfOGHOx+QuZW4F5SQOlTF7SlNZ/Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7862

On 23.02.2022 16:38, Alex Olson wrote:
> It seems to me there are a few findings useful to the Xen developers from
> venturing down this rabbithole:
> 
> 1) For conditions in which MSR registers are writeable from PV guests (such as
> dom0),  they should probably be readable well, looks like MSR_IA32_THERM_CONTROL
> is currently one of a small number of "unreadable" but writeable
> MSRs.  Otherwise seemingly valid read-(check/modify)-write operations will
> behave incorrectly under Xen.

Hmm, this is indeed odd, just like for the adjacent MSR_IA32_ENERGY_PERF_BIAS.
But changing the behavior for such things requires (a) doing archaeology and
(b) being certain that no old Dom0 may be affected by an adjustment. Quite
likely this write-only behavior is a result from removing read access in the
general case. IOW I think we want to re-add read access for these two MSRs
(and any others fitting this pattern) for Dom0. Care to make a patch?

It's perhaps worth noting that (write) access to these two MSRs sits behind
is_hwdom_pinned_vcpu(). This is a mode we generally recommend against using
anyway. I'm not even sure we consider it (security) supported.

> 2) As Xen controls CPU frequency and c-states,  might there be benefit to it
> being extended to manage Clock Modulation / Throttling? (I wasn't expecting dom0
> to be able to influence this!)

This had been the plan many, many years ago. Yet no-one ever came forward
with any code, afaik.

> 3) Perhaps PV domains (such as dom0) should not be allowed to modify such MSRs
> at all since it would result in unintended effects depending on how CPU pools
> and dom0 are managed?

Well, the general rule already is to limit what can be written. So wrong
cases now need to really be dealt with per individual MSR.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Feb 23 16:32:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 23 Feb 2022 16:32:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277672.474459 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMuYb-0001Oa-FS; Wed, 23 Feb 2022 16:32:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277672.474459; Wed, 23 Feb 2022 16:32:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMuYb-0001OT-CE; Wed, 23 Feb 2022 16:32:01 +0000
Received: by outflank-mailman (input) for mailman id 277672;
 Wed, 23 Feb 2022 16:31:59 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=DZ7u=TG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nMuYZ-0001ON-F4
 for xen-devel@lists.xenproject.org; Wed, 23 Feb 2022 16:31:59 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1ec7061d-94c6-11ec-8539-5f4723681683;
 Wed, 23 Feb 2022 17:31:58 +0100 (CET)
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur03lp2051.outbound.protection.outlook.com [104.47.9.51]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-32-kNM6g99mP_aF5sUTHif4QQ-1; Wed, 23 Feb 2022 17:31:56 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AS8PR04MB7862.eurprd04.prod.outlook.com (2603:10a6:20b:2a1::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Wed, 23 Feb
 2022 16:31:55 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.022; Wed, 23 Feb 2022
 16:31:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1ec7061d-94c6-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645633918;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=gtwUw8rnXiypn7xfoHzom6f+crNiHCzj+k2uF+Ojhyg=;
	b=Feey89o1Z5vLnfC1Q1Z/5wTD9G/WpiMAI+11ukqPb/j8KdzfGdX0LibeBLL1v4RMi9bAqx
	9+gpbL4wSP1JN9HZF8f//uUeFpkyYd/dllfBav6uUH0TDPOYjm7ln5AbIa5dc1JOXa0eA/
	6epmIzwvrSGMVgzccei4ApTNwEYSbAk=
X-MC-Unique: kNM6g99mP_aF5sUTHif4QQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XsdEFtuuUWHdRZ2rRDw9qPEjqhQ1qMA38Rq/A/h/GUZH5CKqOiDQw2//69HKncESFSGqRYyMGQdJ+m4b52qdCaSOEs0DU02WJ5hjimt2NUI2C8aKwLaPZJOWamMR9Vnj1EtkwGeyOXowv4pvuuCdHBK8ALaczDUXgF1AKxZbeY91EftfnWwMl8Jn0/hasEvB0STrUQ1HKWbPEh0MknNJK8G03L8bG76yAG6e1P76jzMMEmXhw3HIRufE69u5u7yu2EnzNnflmjziNJIerQj2rg1vQZJdSHgi40mduAvsB2mKvQgZXFDoZ5Ad7/36lbJyEfgNV8qvwSto64qAhgkuug==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=+Tg4BZHzs8/tGsoflF5x3K6sr4inZ33dxpzy5J8Eeyc=;
 b=kuhTAoAIpnDcEdh62qiARK3Qg0RE9EJpD2Zw4Vb3ZadG3sqGhDD/ijEnKE1oC56XGMMAKurVUuckik719tWj8bi6hphJLg73AopQ/xY8tsSCPgv5XrIIOqQXdA9q3WnhyR7HUj1Zhx97GIwUsfH6ElYifju7BwMef+lS2IM0wa+85b41/y84Nt3klv3aN8bCa665uaUR4fdVl6KD6IsLjdiiTWdIdJ/OS8TxQRuKb2HZL4eE3If3Ck3016epbplglrIKyKhn4y0ZPI4K516SM5t5C8r0+YLu7bWw1079BIKwJVsuHEyDWnihO5CPmrrFpUyiAq2eUnZg5S6JRx+7QQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <40942f98-5caf-43b8-5763-81b59a7b800c@suse.com>
Date: Wed, 23 Feb 2022 17:31:53 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [RFC] Avoid dom0/HVM performance penalty from MSR access
 tightening
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: Andrew Cooper <Andrew.Cooper3@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Alex Olson <this.is.a0lson@gmail.com>
References: <949b4776e23e4607776685a7e2705b9e77f5b717.camel@gmail.com>
 <a1099ae9-9e0d-cf54-e786-835c13f2ba40@citrix.com>
 <d11e54d47776008c17762458e6abbd44ab0beed5.camel@gmail.com>
 <YhZcxkY/BgPy/MTh@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YhZcxkY/BgPy/MTh@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: FR3P281CA0046.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:4a::12) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: fe6bca25-90c3-4bda-3540-08d9f6ea0179
X-MS-TrafficTypeDiagnostic: AS8PR04MB7862:EE_
X-Microsoft-Antispam-PRVS:
	<AS8PR04MB78627DC43890682D04F3063EB33C9@AS8PR04MB7862.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	L9Qgd2F07wVMcvgM+9y5FYlhSFb+LedRVp7tYzBaraJhbPH35DPbnRlKCTynyTs/9eDGNmwRE2FdnD8YLLvVe/wVYdbZm/xWwafBbIZnjzu4hevzXvcfJT9KhUzWLP9/tnj9lrxRLJY27QF9+LVVrB7eUGKtW2sFJ5j5QMI1gJ/ss8XpHml0YxyjlAW28f7a/A4aBheAdyA1d1S4NAYk+5qOvornYDLycA6bfRuCaQ3dzAcMZyG8ORpveGTW2rC71PNy3sXgxMcnxXqfZtGmXTOqA/k0VswNco2SX1pf4nDIRUqPybNdaqr0V/oN82ipuIC2/NY7UnY7Q0MZjEpbeiitViXiv0TqfNvvb9WYqkJvf99zQI84XIZXVCAuctuDH0uiLmiCwN5pIpA5Vm/Y0EgVbH/yfGop6jZbxELZRQI4/djshrSpxvNQkPTwDgpCyQONZNLDW41ZGbmwslXxoTdh/BI0NA/WRGO0XVzzteWtuBswUePymeBT8Af7SniZskaR7itF2w/NpF4iXWvxFjCu5m8bzLEWW2AH0U+udEX9fjsMskOJ0I8kYHl+GKFJxrQOHvjjmpwlNFc7O2rSO/RX9KypzD47R3GW/y5e7nIHNPX9BW7WEy5LZalXnxTQR1SoNmndaasqbQQDIBZz+IbBceN4isPZ0bjwiLEPKIYkEdqhEPnjaOd1meWLaQNWUAtTMoYR7rz+NEG1y0go+fw4MpFCmzW1zzhG6JCqYPw=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(316002)(508600001)(6916009)(54906003)(2616005)(86362001)(31696002)(6506007)(53546011)(6512007)(31686004)(83380400001)(66556008)(66476007)(8676002)(2906002)(4326008)(6486002)(5660300002)(38100700002)(36756003)(8936002)(66946007)(186003)(26005)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?c4ZXYokAwSSRxtj9ybFY37RjDrBmTs39GdNmRV0G/GfhccjfdBC8fMDsQOGK?=
 =?us-ascii?Q?xeh0T6ZIzx7rEPPHGNJxvYhQwhX2E3LcTjGXp3jMZIPZHPu6KN17FZYLdAVy?=
 =?us-ascii?Q?dgES55bLN0vs8AMZUXIlmieyoMiSHHmreG0oOo8BiC746ZeixCld6+wyFxB+?=
 =?us-ascii?Q?kUf8yPTaj9u3047Jy8WbMNw1gcfiDou2Tajbph+KOLYpVPTjrYFZKGL3ONMV?=
 =?us-ascii?Q?fMHSh32yuYK1932dMxk9GXpw+UqndrkUn8P+gmjMX0rKmGlNGbyfBm9DNONe?=
 =?us-ascii?Q?tPwctxbTkrYo2ES4QsHXAi/MwGMiP1BjDf9686QA8eH9nOfOHmhyrlsfY40T?=
 =?us-ascii?Q?BWHQPIUGxldSdMH+ahohK60OD7UfbaA1i/BiS7dVExRehzstMLTqCKKEDo4M?=
 =?us-ascii?Q?XbmvnKZRhnUCb4YIDQsqXXAUdOO9G3INOb2PiJ2hZr5ibF5Bc9SMurMBRd0G?=
 =?us-ascii?Q?fvEdvX63Nqlw+xSX/hYTmGBZUUZf/gmVPwjWhGtvkIW/26w1AZikPqX7f6+I?=
 =?us-ascii?Q?WFcsdaPhBKcEtyAbLpiIqgqpb7r/WZgNHIjK03NeAiSaQqbAYIA4bCqVqkob?=
 =?us-ascii?Q?xmfVFojA1Lo32LMwUUCAWOptyle9OLTs2uiIBVYl+ks4v8fwyxPkBEkG3R7J?=
 =?us-ascii?Q?q7dxBdERRvu7OXv94RqFr7A+wa8zPw4i/u19eshDylrec31FWuM0bClawkvL?=
 =?us-ascii?Q?eGsxsjZaRf7xog6x6s9NLsrELvduToGUM2NahHvjDlZS16bRJYH/2KgB7mAy?=
 =?us-ascii?Q?ZOvuWk3onTm2Obzd0g0/shLSZI6avZCaOky36bFPIRq/qeRLCNriFiJdYiHg?=
 =?us-ascii?Q?SxqwZJ0FiBvJorNLUGpvfMPejddIYAMR+Q2DOh2wHhHibEYyzGSlk7BLBu39?=
 =?us-ascii?Q?Yi4S7qSNeQICIfRiGBqXqO0d6cLrLhC5t0HbhmKX7wzhdp1cZgVjn19HrJAZ?=
 =?us-ascii?Q?0niTF75P3lUoqAx1wThJEm5EJDpbEsYR2SdN2+QT5R2ozmYkO0WuD4TJbdl3?=
 =?us-ascii?Q?oCOPnRVDhusVcByaVyhlcXsOriSSDbCDFoycNkF55icIaiJ3QU/uaEmoTyIb?=
 =?us-ascii?Q?izFUTM7c+clvY0rvY+40sGigT4777IEHJfzJeUGeJn1TpMyrQQ88kbrOxZKZ?=
 =?us-ascii?Q?owGlFXJFZ+up5MMln02RuFoT/ZA48TNxRs24cghHjwkp/ejMNS/27w01R0gA?=
 =?us-ascii?Q?ER8n/AoxlOncKT2TJ6RMJz9sTEe1kCBGqd/t+7VS19MTITP3Onvp5UEg6o47?=
 =?us-ascii?Q?42VMalVSlfZUHPqsDiwBhkMuU+ULYQ7HOelQlWgKwAevfBo6OIXhAGfMf1cY?=
 =?us-ascii?Q?TVyFnFa3tiwieSgJfLQyh8X77O5I4IyhVXf+vmAl3ajTtA3GqHyrHUN20/ub?=
 =?us-ascii?Q?fbiGmgVgZNvuEL9/BisW29y3G3vJFRCE7It7CDhEhKUIZ0HQbYOPFh74pVAO?=
 =?us-ascii?Q?jOPGNkTQA70b/zS+m7eDnLohEmmTQehYrbJodK81NkScekA9JAN4ScM1NWhu?=
 =?us-ascii?Q?WsxkdCb9kBW3Kgpz6nVoZwqL8aDfLuRqgVxos9TzDquOBe1VC/NZrCox61JC?=
 =?us-ascii?Q?ALYsrfHoPsnDC4swHuidUfasX4zPZDCvzmtXmVI0ymWB7oGiKYKWj6n27xad?=
 =?us-ascii?Q?25dObhRAnbNBA8WaOrHSEiY=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fe6bca25-90c3-4bda-3540-08d9f6ea0179
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2022 16:31:55.8542
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Bz7hhSDWKo5hM3rjOujm3GeajwGqep3csiXGr4aTaSfuJx/fe3O3joQm8gFjzoq3PjGWcLL/0aKdbPLWLgf20g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7862

On 23.02.2022 17:11, Roger Pau Monn=C3=A9 wrote:
> On Wed, Feb 23, 2022 at 09:38:56AM -0600, Alex Olson wrote:
>> 1) For conditions in which MSR registers are writeable from PV guests (s=
uch as
>> dom0),  they should probably be readable well, looks like MSR_IA32_THERM=
_CONTROL
>> is currently one of a small number of "unreadable" but writeable
>> MSRs.  Otherwise seemingly valid read-(check/modify)-write operations wi=
ll
>> behave incorrectly under Xen.
>=20
> So it's one of those MSRs that's only writable when dom0 has it's
> vCPUs pinned. We could allow dom0 to read from it in that case (that's
> an oversight of the MSR handling rework), but it would seem better to
> just remove access to it altogether: it's bogus to allow dom0 to play
> with the MSR in the first place IMO, and it won't really solve issues
> like the one reported here unless dom0 vCPUs =3D=3D pCPUs and all are
> pinned, so that dom0 can fix the MSR in all CPUs.

Dropping this is imo only legitimate if we decide to do away with
"cpufreq=3Ddom0-kernel" and alike. This limited access permission to
certain MSRs was largely if not exclusively to make this extended
Dom0 control work (which as a prereq took pinning Dom0's vCPU-s).

Jan



From xen-devel-bounces@lists.xenproject.org Wed Feb 23 18:06:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 23 Feb 2022 18:06:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277683.474474 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMw1j-0001lH-Bf; Wed, 23 Feb 2022 18:06:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277683.474474; Wed, 23 Feb 2022 18:06:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMw1j-0001lA-7N; Wed, 23 Feb 2022 18:06:11 +0000
Received: by outflank-mailman (input) for mailman id 277683;
 Wed, 23 Feb 2022 18:06:09 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nMw1h-0001l0-HI; Wed, 23 Feb 2022 18:06:09 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nMw1h-0007M3-E3; Wed, 23 Feb 2022 18:06:09 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nMw1g-0004lQ-VR; Wed, 23 Feb 2022 18:06:09 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nMw1g-0002qh-Uh; Wed, 23 Feb 2022 18:06:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=iWZtZf3yzAU6J7Z61gBFZpi1R2umOPboh94BdNooiOk=; b=B8SHS9KKnNO/yA1S7bVMUfVj5E
	cHfJ9r3z0qYAh3Lz6co4fvJiFGhgl5bqNDEhK3jFXHzBbCRYbsjna8syos5cU6S8SPEphO632Zlvz
	qjMbcjjL/OL4pfzlx1XfqgbqA67sVd+LCUnBpOHL88qt5CSO5e8gXhUIagFYGw/a43dE=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168203-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 168203: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=210f27e55abd2a57c01105992bc10bc4d7b8132d
X-Osstest-Versions-That:
    xen=210f27e55abd2a57c01105992bc10bc4d7b8132d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 23 Feb 2022 18:06:08 +0000

flight 168203 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168203/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168198
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168198
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168198
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168198
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168198
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168198
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168198
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168198
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168198
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168198
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168198
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168198
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  210f27e55abd2a57c01105992bc10bc4d7b8132d
baseline version:
 xen                  210f27e55abd2a57c01105992bc10bc4d7b8132d

Last test of basis   168203  2022-02-23 05:59:50 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Wed Feb 23 18:12:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 23 Feb 2022 18:12:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277695.474485 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMw7O-0003Ap-1P; Wed, 23 Feb 2022 18:12:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277695.474485; Wed, 23 Feb 2022 18:12:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMw7N-0003Ai-TJ; Wed, 23 Feb 2022 18:12:01 +0000
Received: by outflank-mailman (input) for mailman id 277695;
 Wed, 23 Feb 2022 18:12:00 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=p4bB=TG=tklengyel.com=tamas@srs-se1.protection.inumbo.net>)
 id 1nMw7M-0003Ac-Im
 for xen-devel@lists.xenproject.org; Wed, 23 Feb 2022 18:12:00 +0000
Received: from MTA-12-4.privateemail.com (mta-12-4.privateemail.com
 [198.54.127.107]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 167cfa10-94d4-11ec-8eb8-a37418f5ba1a;
 Wed, 23 Feb 2022 19:11:58 +0100 (CET)
Received: from mta-12.privateemail.com (localhost [127.0.0.1])
 by mta-12.privateemail.com (Postfix) with ESMTP id A937D18000AA
 for <xen-devel@lists.xenproject.org>; Wed, 23 Feb 2022 13:11:56 -0500 (EST)
Received: from mail-yb1-f175.google.com (unknown [10.20.151.184])
 by mta-12.privateemail.com (Postfix) with ESMTPA id 8414318000A6
 for <xen-devel@lists.xenproject.org>; Wed, 23 Feb 2022 13:11:56 -0500 (EST)
Received: by mail-yb1-f175.google.com with SMTP id w63so28447924ybe.10
 for <xen-devel@lists.xenproject.org>; Wed, 23 Feb 2022 10:11:56 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 167cfa10-94d4-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=tklengyel.com;
	s=default; t=1645639916;
	bh=qwrc5zDHxf+s1Vl0L0xZOhffYHDVP4usVAVJQRXwQhE=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=F5inXcfzTpdLSd26fmpWAL/mdsoHQhMxcOV9O0ExYAIkHRQS6g3quCPzV0QjjI9qw
	 1swXfdLPnbDXkd3nsb8Y3oqL1t4W74uMx1E0l0NnOr9pB22wTDrYVQoLA0MIpA2yhO
	 I/gLwb4XbXljiA6hIjBgnlkk9qsnXfkrtwHinA/ThUdsK4kfYqnkQIB4btPyGAEq0I
	 bqJ2P8cd0oWrOn/4cYiuAD14Sksqqd4ShWR8Eolp6Yh7HFUOmWSk+PQsjOldeWoOaW
	 HU+gCsOkOS3nn8a2kguwEu+zjsKD4XWaBlqpB4RV0dkxrieFCBl08sQfNojsmbnrw/
	 U32stVnl/K8fw==
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=tklengyel.com;
	s=default; t=1645639916;
	bh=qwrc5zDHxf+s1Vl0L0xZOhffYHDVP4usVAVJQRXwQhE=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=F5inXcfzTpdLSd26fmpWAL/mdsoHQhMxcOV9O0ExYAIkHRQS6g3quCPzV0QjjI9qw
	 1swXfdLPnbDXkd3nsb8Y3oqL1t4W74uMx1E0l0NnOr9pB22wTDrYVQoLA0MIpA2yhO
	 I/gLwb4XbXljiA6hIjBgnlkk9qsnXfkrtwHinA/ThUdsK4kfYqnkQIB4btPyGAEq0I
	 bqJ2P8cd0oWrOn/4cYiuAD14Sksqqd4ShWR8Eolp6Yh7HFUOmWSk+PQsjOldeWoOaW
	 HU+gCsOkOS3nn8a2kguwEu+zjsKD4XWaBlqpB4RV0dkxrieFCBl08sQfNojsmbnrw/
	 U32stVnl/K8fw==
X-Gm-Message-State: AOAM531gF1dawS3hVGSmQoaZoxw9yd4PNPUT8m7iOeWDU4yGxXMJTM0a
	/oC98oq3RuWclkKmOk6C1AUbkQM/4nI8XVC4KLQ=
X-Google-Smtp-Source: ABdhPJz0PM95C/6lfPEiHSR+3lrZbyDp6JNQG7+8I3ZlQiT57jGelVC5lAksqC2Cz2ALTp0gZELGObjQU2MzWTY1hng=
X-Received: by 2002:a25:ec01:0:b0:61d:917f:66f0 with SMTP id
 j1-20020a25ec01000000b0061d917f66f0mr893783ybh.22.1645639915740; Wed, 23 Feb
 2022 10:11:55 -0800 (PST)
MIME-Version: 1.0
References: <32526b73-25f7-e6b0-208b-669a7648ee44@suse.com> <5a8c1f9e-e91a-a7f5-8c8a-025ab6a39908@suse.com>
In-Reply-To: <5a8c1f9e-e91a-a7f5-8c8a-025ab6a39908@suse.com>
From: Tamas K Lengyel <tamas@tklengyel.com>
Date: Wed, 23 Feb 2022 13:11:19 -0500
X-Gmail-Original-Message-ID: <CABfawh=Eh==cadaQX+n9BzuK5RE=sud7sjLtbAzpp5ouMYGCdQ@mail.gmail.com>
Message-ID: <CABfawh=Eh==cadaQX+n9BzuK5RE=sud7sjLtbAzpp5ouMYGCdQ@mail.gmail.com>
Subject: Re: [PATCH 1/2] x86/p2m: make p2m_get_page_from_gfn() handle grant
 and shared cases better
To: Jan Beulich <JBeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
	Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>, 
	=?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>, 
	George Dunlap <george.dunlap@citrix.com>
Content-Type: text/plain; charset="UTF-8"
X-Virus-Scanned: ClamAV using ClamSMTP

> @@ -607,6 +607,7 @@ struct page_info *p2m_get_page_from_gfn(
>
>          /* Error path: not a suitable GFN at all */
>          if ( !p2m_is_ram(*t) && !p2m_is_paging(*t) && !p2m_is_pod(*t) &&
> +             (!p2m_is_shared(*t) || !(q & P2M_UNSHARE)) &&
>               !mem_sharing_is_fork(p2m->domain) )
>              return NULL;
>      }

I don't follow what this is fixing. A shared entry would return true
to p2m_is_ram() - p2m_ram_shared is listed under P2M_RAM_TYPES - so
the rest of the if statement would never be checked. So if we get past
that check we know we definitely don't have a shared entry, ie
p2m_is_shared must be false ie the check for P2M_UNSHARE is dead code.
Am I missing something?

Tamas

Tamas


From xen-devel-bounces@lists.xenproject.org Wed Feb 23 18:38:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 23 Feb 2022 18:38:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277702.474496 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMwX6-0005bG-2J; Wed, 23 Feb 2022 18:38:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277702.474496; Wed, 23 Feb 2022 18:38:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMwX5-0005b9-VE; Wed, 23 Feb 2022 18:38:35 +0000
Received: by outflank-mailman (input) for mailman id 277702;
 Wed, 23 Feb 2022 18:38:35 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nMwX5-0005b3-6g
 for xen-devel@lists.xenproject.org; Wed, 23 Feb 2022 18:38:35 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nMwX4-0007sk-Qe; Wed, 23 Feb 2022 18:38:34 +0000
Received: from 54-240-197-224.amazon.com ([54.240.197.224]
 helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com)
 by xenbits.xenproject.org with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nMwX4-00011Z-HL; Wed, 23 Feb 2022 18:38:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:
	Subject:Cc:To:From; bh=db7wQhcHM2KaSYp1tp69mT23OXkzBHsFL2ieMLVezOk=; b=spwTFC
	65CC+Z+WizJsZSAGziIK92DnA031XRMW3/SgHYcZFFZrxZ5eNehyrnW/YVxUtxluUP55QSN9BHvdM
	+FXdCxks+hM3jMeQyKzxPQagot0AjOtWsaEIMzPCrGiIgHR4QqzFin5HrVRPBCd/7Tst3YMUqVBP3
	J0DccSyY/C8=;
From: Julien Grall <julien@xen.org>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	Julien Grall <jgrall@amazon.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>
Subject: [PATCH] xen/mm: Remove always true ASSERT() in free_heap_pages()
Date: Wed, 23 Feb 2022 18:38:31 +0000
Message-Id: <20220223183831.5951-1-julien@xen.org>
X-Mailer: git-send-email 2.32.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Julien Grall <jgrall@amazon.com>

free_heap_pages() has an ASSERT() checking that node is >= 0. However
node is defined as an unsigned int. So it cannot be negative.

Therefore remove the check as it will always be true.

Signed-off-by: Julien Grall <jgrall@amazon.com>

---

I have looked at the history. AFAICT, node has always be defined
as unsigned int. So the ASSERT() may have never been useful (?).
---
 xen/common/page_alloc.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c
index 46357182375a..e971bf91e0be 100644
--- a/xen/common/page_alloc.c
+++ b/xen/common/page_alloc.c
@@ -1441,7 +1441,6 @@ static void free_heap_pages(
     unsigned int zone = page_to_zone(pg);
 
     ASSERT(order <= MAX_ORDER);
-    ASSERT(node >= 0);
 
     spin_lock(&heap_lock);
 
-- 
2.32.0



From xen-devel-bounces@lists.xenproject.org Wed Feb 23 18:41:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 23 Feb 2022 18:41:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277709.474507 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMwZe-0006xv-HS; Wed, 23 Feb 2022 18:41:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277709.474507; Wed, 23 Feb 2022 18:41:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMwZe-0006xo-D4; Wed, 23 Feb 2022 18:41:14 +0000
Received: by outflank-mailman (input) for mailman id 277709;
 Wed, 23 Feb 2022 18:41:13 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nMwZd-0006xi-P5
 for xen-devel@lists.xenproject.org; Wed, 23 Feb 2022 18:41:13 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nMwZd-0007ws-IE; Wed, 23 Feb 2022 18:41:13 +0000
Received: from 54-240-197-232.amazon.com ([54.240.197.232]
 helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com)
 by xenbits.xenproject.org with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nMwZd-0001AZ-A0; Wed, 23 Feb 2022 18:41:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:
	Subject:Cc:To:From; bh=gZuPgiqxjVfP/Y7/jxgEUCCMKOsAyvpkD31FqQ8FjqY=; b=A6rgHd
	bgozl/Q+QTO+Qdv5ULWSn4GQSesSUxGCc07L8ClPm5WD/WmnBitB52UhZokGC2vxq5MuuMWqj88z9
	/j958oQYcw2xBZaF3J5u8tbcGRy9bNykbTPLj86avjTDO/jI6RH4HLVQACV4BPqPqsz0U4BxCgZTf
	WD5P16IigGA=;
From: Julien Grall <julien@xen.org>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	Julien Grall <jgrall@amazon.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>
Subject: [PATCH] xen/mm: pg_offlined can be defined as bool in free_heap_pages()
Date: Wed, 23 Feb 2022 18:41:10 +0000
Message-Id: <20220223184110.7941-1-julien@xen.org>
X-Mailer: git-send-email 2.32.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Julien Grall <jgrall@amazon.com>

The local variable pg_offlined in free_heap_pages() can only take two
values. So switch it to a bool.

Signed-off-by: Julien Grall <jgrall@amazon.com>
---
 xen/common/page_alloc.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c
index e971bf91e0be..72e6cac2365d 100644
--- a/xen/common/page_alloc.c
+++ b/xen/common/page_alloc.c
@@ -1437,8 +1437,9 @@ static void free_heap_pages(
 {
     unsigned long mask;
     mfn_t mfn = page_to_mfn(pg);
-    unsigned int i, node = phys_to_nid(mfn_to_maddr(mfn)), pg_offlined = 0;
+    unsigned int i, node = phys_to_nid(mfn_to_maddr(mfn));
     unsigned int zone = page_to_zone(pg);
+    bool pg_offlined = true;
 
     ASSERT(order <= MAX_ORDER);
 
@@ -1447,7 +1448,7 @@ static void free_heap_pages(
     for ( i = 0; i < (1 << order); i++ )
     {
         if ( mark_page_free(&pg[i], mfn_add(mfn, i)) )
-            pg_offlined = 1;
+            pg_offlined = true;
 
         if ( need_scrub )
         {
-- 
2.32.0



From xen-devel-bounces@lists.xenproject.org Wed Feb 23 18:50:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 23 Feb 2022 18:50:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277720.474518 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMwih-0008VH-Kn; Wed, 23 Feb 2022 18:50:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277720.474518; Wed, 23 Feb 2022 18:50:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMwih-0008VA-Ho; Wed, 23 Feb 2022 18:50:35 +0000
Received: by outflank-mailman (input) for mailman id 277720;
 Wed, 23 Feb 2022 18:50:34 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nMwig-0008V4-9z
 for xen-devel@lists.xenproject.org; Wed, 23 Feb 2022 18:50:34 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nMwie-00087t-Oj; Wed, 23 Feb 2022 18:50:32 +0000
Received: from 54-240-197-224.amazon.com ([54.240.197.224]
 helo=[10.95.122.138]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nMwie-0001lQ-IC; Wed, 23 Feb 2022 18:50:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=ketT44OH08st78q8FuF99ppIz2kkPUsJg4CPMJHWlls=; b=Ev+5j5ebPwKo+c1Zr/6Sh/O3ph
	haunwpU5hOT1oPNwUloLt1RGSveHKkXAtpj+CRyyklQ0tnEO3GKEnpl894AYCiYiCP5OpKL1/W/16
	LJrqAHrpmzkUNaRhc5s8GIOm3G9xAELtBbqTDVt6NDfzNf3iPjcKI5nk0VNApJbZL0mA=;
Message-ID: <064fe4a6-42b4-14b7-2dcd-752af5afc473@xen.org>
Date: Wed, 23 Feb 2022 18:50:30 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.1
Subject: Re: [PATCH RFC 1/3] xen/efi: Always query the console information and
 get GOP
To: Daniel Kiper <daniel.kiper@oracle.com>
Cc: ehem+xen@m5p.com, Julien Grall <jgrall@amazon.com>,
 xen-devel@lists.xenproject.org, Daniel Kiper <daniel.kiper@oracle.com>,
 Jan Beulich <jbeulich@suse.com>
References: <20220206192839.75711-1-julien@xen.org>
 <20220206192839.75711-2-julien@xen.org>
 <88741681-929f-4cda-e841-023bdbf8f772@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <88741681-929f-4cda-e841-023bdbf8f772@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Daniel,

Gentle ping. Your feedback on this approach would be helpful.

On 07/02/2022 08:46, Jan Beulich wrote:
> On 06.02.2022 20:28, Julien Grall wrote:
>> From: Julien Grall <jgrall@amazon.com>
>>
>> Currently, the EFI stub will only query the console information and
>> get the GOP when using the configuration file.
>>
>> However, GRUB is never providing the a configuration file. So the
>> EFI framebuffer will not be usable at least on Arm (support will
>> be added in a follow-up patch).
>>
>> Move out the code outside of the configuration file section.
>>
>> Take the opportunity to remove the variable 'size' which was
>> set but never used (interestingly GCC is only complaining if it is
>> initialization when declaring the variable).
>>
>> With this change, GCC 8.3 will complain of argc potentially been
>> used unitiatlized. I suspect this is because the argc will
>> be iniitalized and used in a different if code-blocks. Yet they
>> are using the same check.
> 
> I'm inclined to suggest this wants to be a separate change, with its
> own justification. You're not touching any use of argc here, after
> all.
> 
>> Signed-off-by: Julien Grall <jgrall@amazon.com>
>>
>> ----
>>
>> It is not entirely clear to me why the GOP was only fetched when
>> the configuration file is used.
>>
>> I have tested this on RPI4 and it seems to work. Any chance this
>> was done to workaround an x86 platform?
> 
> This was done so in the context of making the code work for Arm. See
> commit c38cf865ec82 ("EFI: ignore EFI commandline, skip console setup
> when booted from GRUB"), the description of which explicitly says
> 
> "Don't do EFI console or video configuration when booted by GRUB.  The EFI boot
>   code does some console and video initialization to support native EFI boot from
>   the EFI boot manager or EFI shell.  This initlization should not be done when
>   booted using GRUB."
> 
> What you say now is effectively the opposite (and unlike back then
> x86 is now able to use this code path as well, so needs considering
> too). Cc-ing Daniel for possibly having a GrUB-side opinion.
> 
> Jan
> 
>> --- a/xen/common/efi/boot.c
>> +++ b/xen/common/efi/boot.c
>> @@ -1129,9 +1129,11 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable)
>>       static EFI_GUID __initdata shim_lock_guid = SHIM_LOCK_PROTOCOL_GUID;
>>       EFI_LOADED_IMAGE *loaded_image;
>>       EFI_STATUS status;
>> -    unsigned int i, argc;
>> +    /* Initialize argc to stop GCC complaining */
>> +    unsigned int i, argc = 0;
>>       CHAR16 **argv, *file_name, *cfg_file_name = NULL, *options = NULL;
>> -    UINTN gop_mode = ~0;
>> +    UINTN gop_mode = ~0, cols = 0, rows = 0;
>> +
>>       EFI_SHIM_LOCK_PROTOCOL *shim_lock;
>>       EFI_GRAPHICS_OUTPUT_PROTOCOL *gop = NULL;
>>       union string section = { NULL }, name;
>> @@ -1219,18 +1221,16 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable)
>>   
>>       efi_arch_relocate_image(0);
>>   
>> +    if ( StdOut->QueryMode(StdOut, StdOut->Mode->Mode,
>> +                           &cols, &rows) == EFI_SUCCESS )
>> +        efi_arch_console_init(cols, rows);
>> +
>> +    gop = efi_get_gop();
>> +
>>       if ( use_cfg_file )
>>       {
>>           EFI_FILE_HANDLE dir_handle;
>> -        UINTN depth, cols, rows, size;
>> -
>> -        size = cols = rows = depth = 0;
>> -
>> -        if ( StdOut->QueryMode(StdOut, StdOut->Mode->Mode,
>> -                               &cols, &rows) == EFI_SUCCESS )
>> -            efi_arch_console_init(cols, rows);
>> -
>> -        gop = efi_get_gop();
>> +        UINTN depth = 0;
>>   
>>           /* Get the file system interface. */
>>           dir_handle = get_parent_handle(loaded_image, &file_name);
> 

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Feb 23 18:51:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 23 Feb 2022 18:51:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277726.474529 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMwjm-0000dg-UU; Wed, 23 Feb 2022 18:51:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277726.474529; Wed, 23 Feb 2022 18:51:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMwjm-0000dZ-Qy; Wed, 23 Feb 2022 18:51:42 +0000
Received: by outflank-mailman (input) for mailman id 277726;
 Wed, 23 Feb 2022 18:51:41 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nMwjl-0000dP-63
 for xen-devel@lists.xenproject.org; Wed, 23 Feb 2022 18:51:41 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nMwjk-00088k-Qm; Wed, 23 Feb 2022 18:51:40 +0000
Received: from 54-240-197-224.amazon.com ([54.240.197.224]
 helo=[10.95.122.138]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nMwjk-0001ns-L0; Wed, 23 Feb 2022 18:51:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=M8y2Cbi8sMqZS7YrZOhxtZGRGgFxvEhtUxDAs1IbX6U=; b=Tp1ldhX3PllYLYfjaOtliVSV/7
	ieAObzouxBlxEx7OrS9uOzVgj9Z0E+44973zS208BN7/DaMgtlGqpjYOc+nW6VOHWMv9bKBZc8Z3u
	3nudlQ/5tEHz8RX8Dh/uj6UlBzRbmt3ibvKhr2YPC0UCehaFI/8odDvMMs4Zvoi2zPE0=;
Message-ID: <8e3c0abc-3abe-51f8-fc65-3e92a78205fb@xen.org>
Date: Wed, 23 Feb 2022 18:51:38 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.1
Subject: Re: [PATCH v2 1/2] xen/arm: Rename psr_mode_is_32bit to
 regs_mode_is_32bit
To: Michal Orzel <michal.orzel@arm.com>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20220222105613.20668-1-michal.orzel@arm.com>
 <20220222105613.20668-2-michal.orzel@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220222105613.20668-2-michal.orzel@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Michal,

On 22/02/2022 10:56, Michal Orzel wrote:
> Commit aa2f5aefa8de ("xen/arm: Rework psr_mode_is_32bit()") modified
> the function to take a struct cpu_user_regs instead of psr.
> Perform renaming of psr_mode_is_32bit to regs_mode_is_32bit to reflect
> that change.
> 
> Signed-off-by: Michal Orzel <michal.orzel@arm.com>

Acked-by: Julien Grall <jgrall@amazon.com>

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Feb 23 18:52:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 23 Feb 2022 18:52:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277732.474541 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMwkH-0001A8-AC; Wed, 23 Feb 2022 18:52:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277732.474541; Wed, 23 Feb 2022 18:52:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMwkH-0001A1-46; Wed, 23 Feb 2022 18:52:13 +0000
Received: by outflank-mailman (input) for mailman id 277732;
 Wed, 23 Feb 2022 18:52:12 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nMwkG-00019r-9g
 for xen-devel@lists.xenproject.org; Wed, 23 Feb 2022 18:52:12 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nMwkF-00089f-UN; Wed, 23 Feb 2022 18:52:11 +0000
Received: from 54-240-197-224.amazon.com ([54.240.197.224]
 helo=[10.95.122.138]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nMwkF-0001oe-Op; Wed, 23 Feb 2022 18:52:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=19ZNXz6V8Ks1uqrdtl1sYxOuUbaoqkjQNiIah/IksnI=; b=JJHUCbha9AP5YKD2xAPcieaf5t
	zdUIZVmIMI9uUFNHA5DOnkkRTKXzGV6Yg7De2g/SBbml00eYfBSA/lQ/kiR00ylZnuUtLaZKuaENM
	sfThimjvgs5LlTO7fOrGj6DsNwffSS5KWMhPea7jFJJ6xu+SzsHCXyn+KyjrV1RT55yo=;
Message-ID: <af1aa9e0-a937-d209-8144-d39585b48ecb@xen.org>
Date: Wed, 23 Feb 2022 18:52:10 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.1
Subject: Re: [PATCH v2 2/2] xen/arm: Rename psr_mode_is_user to
 regs_mode_is_user
To: Michal Orzel <michal.orzel@arm.com>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20220222105613.20668-1-michal.orzel@arm.com>
 <20220222105613.20668-3-michal.orzel@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220222105613.20668-3-michal.orzel@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Michal,

On 22/02/2022 10:56, Michal Orzel wrote:
> Perform renaming of psr_mode_is_user to regs_mode_is_user in order to
> reflect that it takes struct cpu_user_regs as a parameter and not
> psr.
> 
> Signed-off-by: Michal Orzel <michal.orzel@arm.com>

Acked-by: Julien Grall <jgrall@amazon.com>

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Feb 23 19:04:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 23 Feb 2022 19:04:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277741.474551 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMwvl-0002m7-Dx; Wed, 23 Feb 2022 19:04:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277741.474551; Wed, 23 Feb 2022 19:04:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMwvl-0002m0-8n; Wed, 23 Feb 2022 19:04:05 +0000
Received: by outflank-mailman (input) for mailman id 277741;
 Wed, 23 Feb 2022 19:04:04 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=eMz3=TG=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1nMwvk-0002ls-GV
 for xen-devel@lists.xenproject.org; Wed, 23 Feb 2022 19:04:04 +0000
Received: from ppsw-31.csi.cam.ac.uk (ppsw-31.csi.cam.ac.uk [131.111.8.131])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5c31f363-94db-11ec-8eb8-a37418f5ba1a;
 Wed, 23 Feb 2022 20:04:02 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:58280)
 by ppsw-31.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.137]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1nMwvX-000Jqc-LQ (Exim 4.95) (return-path <amc96@srcf.net>);
 Wed, 23 Feb 2022 19:03:51 +0000
Received: from [192.168.1.10] (host-92-12-45-187.as13285.net [92.12.45.187])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 1DF8E1FAE7;
 Wed, 23 Feb 2022 19:03:51 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5c31f363-94db-11ec-8eb8-a37418f5ba1a
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <2978f831-5bed-d2d1-afc4-965a6c9770fb@srcf.net>
Date: Wed, 23 Feb 2022 19:03:50 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH] xen/mm: pg_offlined can be defined as bool in
 free_heap_pages()
Content-Language: en-GB
To: Julien Grall <julien@xen.org>, xen-devel@lists.xenproject.org
Cc: Julien Grall <jgrall@amazon.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
References: <20220223184110.7941-1-julien@xen.org>
From: Andrew Cooper <amc96@srcf.net>
In-Reply-To: <20220223184110.7941-1-julien@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 23/02/2022 18:41, Julien Grall wrote:
> From: Julien Grall <jgrall@amazon.com>
>
> The local variable pg_offlined in free_heap_pages() can only take two
> values. So switch it to a bool.
>
> Signed-off-by: Julien Grall <jgrall@amazon.com>
> ---
>  xen/common/page_alloc.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c
> index e971bf91e0be..72e6cac2365d 100644
> --- a/xen/common/page_alloc.c
> +++ b/xen/common/page_alloc.c
> @@ -1437,8 +1437,9 @@ static void free_heap_pages(
>  {
>      unsigned long mask;
>      mfn_t mfn = page_to_mfn(pg);
> -    unsigned int i, node = phys_to_nid(mfn_to_maddr(mfn)), pg_offlined = 0;
> +    unsigned int i, node = phys_to_nid(mfn_to_maddr(mfn));
>      unsigned int zone = page_to_zone(pg);
> +    bool pg_offlined = true;

= false ?

~Andrew

>  
>      ASSERT(order <= MAX_ORDER);
>  
> @@ -1447,7 +1448,7 @@ static void free_heap_pages(
>      for ( i = 0; i < (1 << order); i++ )
>      {
>          if ( mark_page_free(&pg[i], mfn_add(mfn, i)) )
> -            pg_offlined = 1;
> +            pg_offlined = true;
>  
>          if ( need_scrub )
>          {



From xen-devel-bounces@lists.xenproject.org Wed Feb 23 19:05:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 23 Feb 2022 19:05:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277748.474561 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMwxY-0003Nf-Ng; Wed, 23 Feb 2022 19:05:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277748.474561; Wed, 23 Feb 2022 19:05:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMwxY-0003NY-Kl; Wed, 23 Feb 2022 19:05:56 +0000
Received: by outflank-mailman (input) for mailman id 277748;
 Wed, 23 Feb 2022 19:05:55 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nMwxX-0003NQ-9C
 for xen-devel@lists.xenproject.org; Wed, 23 Feb 2022 19:05:55 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nMwxV-0008Px-P0; Wed, 23 Feb 2022 19:05:53 +0000
Received: from 54-240-197-224.amazon.com ([54.240.197.224]
 helo=[10.95.122.138]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nMwxV-0002mw-Gs; Wed, 23 Feb 2022 19:05:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=5IszUqZNjYgVAlproL7eMfi10ABrxZmEo7SvnGmAxwU=; b=LHDO1SOMnsU4InsAHC9j004FjL
	LkCIniZqmg8b9WFraeJLXKiSQlmHUC+i2uxswZGYB3MMjegvFWBjFiMU4oQ/Q9Z8e/4HVD1GuYPki
	phjVRNIPUHObK6L4Vz/qacos+MF8Wpzl1uiP+/yAbqfsZ2GayJf+iQ+OIeCcKzccx7Pk=;
Message-ID: <db9ee22b-22fa-46ff-9cf0-190628f1329b@xen.org>
Date: Wed, 23 Feb 2022 19:05:51 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.1
Subject: Re: [PATCH] xen/mm: pg_offlined can be defined as bool in
 free_heap_pages()
To: Andrew Cooper <amc96@srcf.net>, xen-devel@lists.xenproject.org
Cc: Julien Grall <jgrall@amazon.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
References: <20220223184110.7941-1-julien@xen.org>
 <2978f831-5bed-d2d1-afc4-965a6c9770fb@srcf.net>
From: Julien Grall <julien@xen.org>
In-Reply-To: <2978f831-5bed-d2d1-afc4-965a6c9770fb@srcf.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 23/02/2022 19:03, Andrew Cooper wrote:
> On 23/02/2022 18:41, Julien Grall wrote:
>> From: Julien Grall <jgrall@amazon.com>
>>
>> The local variable pg_offlined in free_heap_pages() can only take two
>> values. So switch it to a bool.
>>
>> Signed-off-by: Julien Grall <jgrall@amazon.com>
>> ---
>>   xen/common/page_alloc.c | 5 +++--
>>   1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c
>> index e971bf91e0be..72e6cac2365d 100644
>> --- a/xen/common/page_alloc.c
>> +++ b/xen/common/page_alloc.c
>> @@ -1437,8 +1437,9 @@ static void free_heap_pages(
>>   {
>>       unsigned long mask;
>>       mfn_t mfn = page_to_mfn(pg);
>> -    unsigned int i, node = phys_to_nid(mfn_to_maddr(mfn)), pg_offlined = 0;
>> +    unsigned int i, node = phys_to_nid(mfn_to_maddr(mfn));
>>       unsigned int zone = page_to_zone(pg);
>> +    bool pg_offlined = true;
> 
> = false ?

Whoops. Yes.

I will resend the patch.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Feb 23 19:08:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 23 Feb 2022 19:08:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277755.474572 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMx09-000418-5F; Wed, 23 Feb 2022 19:08:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277755.474572; Wed, 23 Feb 2022 19:08:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMx09-000411-2O; Wed, 23 Feb 2022 19:08:37 +0000
Received: by outflank-mailman (input) for mailman id 277755;
 Wed, 23 Feb 2022 19:08:35 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nMx07-00040v-NW
 for xen-devel@lists.xenproject.org; Wed, 23 Feb 2022 19:08:35 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nMx07-0008S9-ML; Wed, 23 Feb 2022 19:08:35 +0000
Received: from 54-240-197-232.amazon.com ([54.240.197.232]
 helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com)
 by xenbits.xenproject.org with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nMx07-0002xC-DE; Wed, 23 Feb 2022 19:08:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:
	Subject:Cc:To:From; bh=ms66EeFpnDlrLxveB85xTVbo3f8VYA2lVaSo3C96Zkc=; b=af0ZqY
	zr4NI5IHb3MKBxe8s6LSrQ1XyhnsTgXN/Uff88qARXBwTkw49ILRlVC9Q8JuK9mX/OhMl3NPSQTA8
	b62TTssQZV5S8o0+XaJapUjaH3W9Tq6/DS/pLdmCeMHn1jpgh/YoeSMMDGsw3J0+manMydS+GLirZ
	yUj6F1hDNg8=;
From: Julien Grall <julien@xen.org>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	Julien Grall <jgrall@amazon.com>
Subject: [PATCH v2] xen/mm: pg_offlined can be defined as bool in free_heap_pages()
Date: Wed, 23 Feb 2022 19:08:33 +0000
Message-Id: <20220223190833.24710-1-julien@xen.org>
X-Mailer: git-send-email 2.32.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Julien Grall <jgrall@amazon.com>

The local variable pg_offlined in free_heap_pages() can only take two
values. So switch it to a bool.

Signed-off-by: Julien Grall <jgrall@amazon.com>

---
    Changes in v2:
        - pg_offlined should be initialized to false rather than true
---
 xen/common/page_alloc.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c
index e971bf91e0be..319029140f30 100644
--- a/xen/common/page_alloc.c
+++ b/xen/common/page_alloc.c
@@ -1437,8 +1437,9 @@ static void free_heap_pages(
 {
     unsigned long mask;
     mfn_t mfn = page_to_mfn(pg);
-    unsigned int i, node = phys_to_nid(mfn_to_maddr(mfn)), pg_offlined = 0;
+    unsigned int i, node = phys_to_nid(mfn_to_maddr(mfn));
     unsigned int zone = page_to_zone(pg);
+    bool pg_offlined = false;
 
     ASSERT(order <= MAX_ORDER);
 
@@ -1447,7 +1448,7 @@ static void free_heap_pages(
     for ( i = 0; i < (1 << order); i++ )
     {
         if ( mark_page_free(&pg[i], mfn_add(mfn, i)) )
-            pg_offlined = 1;
+            pg_offlined = true;
 
         if ( need_scrub )
         {
-- 
2.32.0



From xen-devel-bounces@lists.xenproject.org Wed Feb 23 19:19:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 23 Feb 2022 19:19:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277762.474583 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMxAV-0005VJ-5q; Wed, 23 Feb 2022 19:19:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277762.474583; Wed, 23 Feb 2022 19:19:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMxAV-0005VC-2r; Wed, 23 Feb 2022 19:19:19 +0000
Received: by outflank-mailman (input) for mailman id 277762;
 Wed, 23 Feb 2022 19:19:17 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nMxAT-0005V6-3d
 for xen-devel@lists.xenproject.org; Wed, 23 Feb 2022 19:19:17 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nMxAS-0000DD-Nz; Wed, 23 Feb 2022 19:19:16 +0000
Received: from 54-240-197-224.amazon.com ([54.240.197.224]
 helo=[10.95.122.138]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nMxAS-0003VF-Hd; Wed, 23 Feb 2022 19:19:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=JUjFZTkHyv0ldXPReND+ZBWvggKmkNWUS9Mifmc1krQ=; b=PoSeKBuTc83daU/Fn4xjCqNJb/
	TPJA5cgOBUPCqAbWg+W7P4LgsOBekaaJ+bHN8/Dl+0zzGfc6PyyICrzWLBA4VkL4puOAIpChE38WY
	UpN8FHU1OZZ73eJP6rGTz8/czzapgcEfrtqTfHBRO5/zlmTLW9AH3PCKi796qnjFNjlQ=;
Message-ID: <252bc55a-8975-72c9-95f1-abeb6ab607c2@xen.org>
Date: Wed, 23 Feb 2022 19:19:14 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.1
Subject: Re: [XEN v8 2/2] xen/arm64: io: Support instructions (for which ISS
 is not valid) on emulated MMIO region using MMIO/ioreq handler
To: Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>,
 xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com,
 bertrand.marquis@arm.com
References: <20220212233433.46018-1-ayankuma@xilinx.com>
 <20220212233433.46018-3-ayankuma@xilinx.com>
 <1599e2f3-0a34-020a-dd42-5ba87dad555d@xen.org>
 <10cf253b-fc58-1afc-66ec-33ac3008bb0f@xilinx.com>
 <576cf522-f002-afac-36b6-b31f87724dca@xen.org>
 <e53b1407-4701-f0f1-5f49-5bd8cbb6eb41@xilinx.com>
 <96610d30-0de2-96e9-e838-504acf83a8d8@xen.org>
 <8c45a34c-9e54-1a9b-d894-f05f41412657@xilinx.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <8c45a34c-9e54-1a9b-d894-f05f41412657@xilinx.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit



On 21/02/2022 21:10, Ayan Kumar Halder wrote:
> Hi Julien,

Hi,

> 
> On 21/02/2022 19:13, Julien Grall wrote:
>>
>>
>> On 21/02/2022 19:05, Ayan Kumar Halder wrote:
>>> If we (ie Xen) didn't decode the instruction manually, then 
>>> check_p2m() has not been invoked yet.  This is because of the 
>>> following (info.dabt.valid == True) :-
>>>
>>>          if ( !is_data || !info.dabt.valid )
>>>          {
>>>
>>>                  ...
>>>
>>>                  if ( check_p2m(is_data, gpa) )
>>>                      return;
>>>
>>>                  ...
>>>
>>>          }
>>>
>>> So, in this scenario ( !info.dabt.valid), it would not be necessary 
>>> to invoke check_p2m() after try_handle_mmio().
>>>
>>> However, if we havenot decoded the instruction manually (ie 
>>> info.dabt.valid == True), and try_handle_mmio() returns IO_UNHANDLED, 
>>> then it will be necessary to invoke "check_p2m(is_data, gpa)"
>>
>> Hmmm you are right. But this doesn't seem to match the code you wrote 
>> below. What did I miss?
> 
> My code was not correct.  I have rectified it as below. Please let me 
> know if it looks sane.

This looks good to me with one remark below.

> 
> <snip>
> 
>      case FSC_FLT_TRANS:
>      {
>          info.gpa = gpa;
>          info.dabt = hsr.dabt;
> 
>          /*
>           * Assumption :- Most of the times when we get a data abort and 
> the ISS
>           * is invalid or an instruction abort, the underlying cause is 
> that the
>           * page tables have not been set up correctly.
>           */
>          if ( !is_data || !info.dabt.valid )
>          {
>              if ( check_p2m(is_data, gpa) )
>                  return;
> 
>              /*
>               * If the instruction abort could not be resolved by 
> setting the
>               * appropriate bits in the translation table, then Xen should
>               * forward the abort to the guest.
>               */
>              if ( !is_data )
>                  goto inject_abt;
> 
>              try_decode_instruction(regs, &info);
> 
>              /*
>               * If Xen could not decode the instruction or encountered 
> an error
>               * while decoding, then it should forward the abort to the 
> guest.
>               */
>              if ( info.dabt_instr.state == INSTR_ERROR )
>                  goto inject_abt;
>          }
> 
>          state = try_handle_mmio(regs, &info);
> 
>          switch ( state )
>          {
>              case IO_ABORT:
>                  goto inject_abt;
>              case IO_HANDLED:
>                  /*
>                   * If the instruction was decoded and has executed 
> successfully
>                   * on the MMIO region, then Xen should execute the next 
> part of
>                   * the instruction. (for eg increment the rn if it is a
>                   * post-indexing instruction.
>                   */
>                  post_increment_register(&info.dabt_instr);
>                  advance_pc(regs, hsr);
>                  return;
>              case IO_RETRY:
>                  /* finish later */
>                  return;
>              case IO_UNHANDLED:
>                  /* IO unhandled, try another way to handle it. */
>                  break;
>          }
> 
>          /*
>           * If the instruction was valid but Xen could not emulate the 
> instruction
>           * then it should configure the page tables to set the correct 
> page table
>           * entry corresponding to the faulting address. If it was 
> successful, it
>           * should return to the guest to retry the instruction (hoping 
> that the
>           * instruction will not be trapped to Xen again).
>           * However, if Xen was not successful in setting the page 
> tables, then
>           * it should forward the abort to the guest.
>           */

I would shorten to:

If the instruction syndrome was invalid, then we already checked if this 
was due to a P2M fault. So no point to check again as the result will be 
the same.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Feb 23 19:30:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 23 Feb 2022 19:30:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277771.474594 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMxLW-0007oT-Aq; Wed, 23 Feb 2022 19:30:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277771.474594; Wed, 23 Feb 2022 19:30:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMxLW-0007oM-7w; Wed, 23 Feb 2022 19:30:42 +0000
Received: by outflank-mailman (input) for mailman id 277771;
 Wed, 23 Feb 2022 19:30:41 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=PMTg=TG=citrix.com=prvs=046033a78=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nMxLV-0007oG-BR
 for xen-devel@lists.xenproject.org; Wed, 23 Feb 2022 19:30:41 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1407c3dc-94df-11ec-8eb8-a37418f5ba1a;
 Wed, 23 Feb 2022 20:30:39 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1407c3dc-94df-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645644639;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:mime-version;
  bh=lnk8BhE0euBbgas7NdN9bZypxmnI+nHh98BTxTV/fUA=;
  b=Wnu4pzyuZTDwC7f0qruohgm2cOdy1CoSI4+bFnt/4iWnvryTe5lQKoax
   1lCMLTpX8etGQYRnXUnqzj7kxejup+EJ6e2F6jEkMfU1gk6aCSAVaAw9N
   UVrLxyWCFnPoBuvuky+KRihtrEmirwqrg6CFgL2MTBHTqwKL/1blFj3tR
   U=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 65254828
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:PM/kvav8SJKwblH0Z+LXR8+pqufnVIFeMUV32f8akzHdYApBsoF/q
 tZmKWCPO6mDMTb3LdxyOom/9k9Uv5PRx95nGwI4rXw2Hn5A+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQzy4bVvqYy2YLjW1nX4
 ouoyyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb
 /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo
 Oihu6BcRi9wYJ3CvesgfSNGAhNTLaIZwpHHAUmw5Jn7I03uKxMAwt1rBUAye4YZ5vx2ESdF8
 vlwxDIlN07ZwbjsmfTiF7cq1p9LwMrDZevzvllJyz3DAOlgapfEW6jQvvdT3Ssqh9AIFvHbD
 yYcQWQyNkmcM0cfUrsRILIEw73wuEnTShZBjmCTjvYOyjD36gMkhdABN/KKI4fXFK25hH2wp
 GjL4mD4CREyL8GExHyO9XfErvTUgSrxVYYWFbu53v1nmluewioUEhJ+fUS/iem0jAi5Qd03A
 04J/isjq4Ai+UrtScPyNzWorXjBshMCVt54F+wh9BrL2qfS+xyeBGUPUnhGctNOnM05XzUu0
 neAmtr7Ajopu7qQIU9x7Z/N82n0Y3JMazZfO2lUFmPp/uUPvqlq0CLBa9lePpSrn+/YCT6v+
 R6KjBkx0uB7YdEw6423+lXOgjSJr5fPTxIo6gi/Yl9J/j+Vd6b+OdX2tAGzAeJoad/AEwLf5
 CRsd922sbhWZaxhghBhVwnk8FuBw/+eeAPRjld0d3XK32T8oiXzFWy8DdwXGauIDirmUWKxC
 KMwkVkIjHO2AJdMRfUrC25WI553pZUM7fy/CpjpgiNmO/CdjjOv8iB0flK31GvwikUqmqxXE
 c7FLZvxUChCWf47k2reqwIhPVkDnHxWKYT7H82T8vha+eDGOC79pUktajNikdzVHIvb+V6Io
 r6zxuOByglFUf2WX8Uk2dV7ELz+FlBiXcqeg5UOLoare1M6cEl8W6656e5wIORNwvUK/tokC
 1ngAye0PnKk3iaZQehLA1g+AI7SsWFX9yxjZnV0ZQ7ys5XhCK72hJoim1IMVeBP3MRozOJuT
 ulDfMOFA/9VTS/A9ShbZp74xLGOvjzy7e5SF0JJuAQCQqM=
IronPort-HdrOrdr: A9a23:0U8IdK/sJxOgUI9JPhBuk+Fpdb1zdoMgy1knxilNoENuHfBwxv
 rDoB1E73LJYW4qKQwdcdDpAtjkfZquz+8I3WBxB8bvYOCCggWVxe5ZnPLfKlHbak7DH6tmpN
 1dmstFeZLN5DpB/L7HCWCDer5KqrjmzEnrv5ak854Ed3AyV0gK1XYcNu/vKDwReOAwP+tfKH
 Pz3LskmxOQPVAsKuirDHgMWObO4/fRkoj9XBIADxk7rCGTkDKB8tfBYlal9yZbdwkK7aYp8G
 DDnQC8zL6kqeuHxhjV0HKWx4hKmeHm1sBICKW3+4kow3TX+0aVjbZaKv+/VQMO0aSSAZER4Z
 3xSiIbTodOArXqDyaISFXWqk/dOX0VmgDfIBej8AXeSIrCNWoH4oN69PJkmlGy0TtQgPhslK
 1MxG6XrJxREFfJmzn8/cHBU1VwmlOzumdKq59Zs5Vza/pWVFZql/1WwKqVKuZ1IAvqrIQ8VO
 V+BsDV4/hbNVuccnDCp2FqhNihRG46EBuKSlUL/pX96UkaoFlpi08DgMAPlHYJ85wwD5FC+u
 TfK6xt0LVDVNUfY65xDPoIBcG3FmvOSxTRN3/6GyWsKIgXf3bW75Ln6rQ84++nPJQO0ZspgZ
 zEFEhVsGYjEnief/FmHKc7hSwlbF/NLwgFkPsulKSRkoeMMYbWDQ==
X-IronPort-AV: E=Sophos;i="5.88,391,1635220800"; 
   d="scan'208,217";a="65254828"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=PaJL+GugevdS6AyUL1F+rYiOEVAdMO40Q/hXsg2EjiOIiaz+RIW6z18St2QplhUDd+99GrHbyp6y5bevXNnIhr+nFC7oxPZ28/akj17FOTHvm9X0uXovuX2ZtjZCtDP6Qc+JS1JODXELKbb+IEndyff+7vFDEH+uJpiZvkm1ke7DmEqOobYKJHo1XZDuZH3aiQEFKrabFolKzLFltLmnA3jv6s5oO8UjyR8CwAQ53KWi10b13zRy7aAmtI4QDh1jNgwY0RWilTq0+O8NzosG4Ghxc7nAhlOj4crw4HhymFCzOeQe59EAcvVAHH15L8GB1fEfoJh2up0BfwgL7e2egA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=lnk8BhE0euBbgas7NdN9bZypxmnI+nHh98BTxTV/fUA=;
 b=T5yhXWtMw9/o19iqGFKWBftYWQpvZFSV9r8LRDekTUgop6CEfulLOBYF4BQYSxeKlZ0WcbO1LZaL5b5UoL1gNpB4yTBiSCGuNPeHlxTlE1Sobto/tetHrRpQrf65fjpPJHBDWwgt+ZxKkWRSTycMFcfz1TEhp4CHxz0nUiUnZFLNUn7+4LDdNHV27HNFjEKGSgtFJkfXmgX12l0J6OvUOTg79XlbNKeKn+6XlP966v96r4t+jCkI0DKHrjhtqjcP5G9OKDcSCFxwc14BabGaKOD3EA+ljCMVLN3gl8SDClylbBNUP7vI8Knt97+vOFwZmP7qHO4d9/S1Mwb+FkczCA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=lnk8BhE0euBbgas7NdN9bZypxmnI+nHh98BTxTV/fUA=;
 b=JXQmvWmUKNQ9ixpyvlWq1X/ucDlXA6TDYc2o/v5Smfnv4DCyG6tJzaoWvAN2ZyNq71Plc067w4LsTfSz87VUxjpMrZi5gdCzJ5s6gYTQejMjKJ8vjtSzF7mb3GPwtuxKBqoPOSVtAon9gyUhUWLEvo25t9vhiv34qphFZ4mkzhM=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Julien Grall <julien@xen.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Julien Grall <jgrall@amazon.com>, George Dunlap
	<George.Dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH] xen/mm: Remove always true ASSERT() in free_heap_pages()
Thread-Topic: [PATCH] xen/mm: Remove always true ASSERT() in free_heap_pages()
Thread-Index: AQHYKOShk/ueVOZf6kGfV3gTr3FtFKyhhdyA
Date: Wed, 23 Feb 2022 19:30:33 +0000
Message-ID: <a3f52f29-3280-89b6-5db5-de224dd037cc@citrix.com>
References: <20220223183831.5951-1-julien@xen.org>
In-Reply-To: <20220223183831.5951-1-julien@xen.org>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 2672ea3d-587a-4b0a-bddf-08d9f702f602
x-ms-traffictypediagnostic: DM6PR03MB4122:EE_
x-microsoft-antispam-prvs: <DM6PR03MB41226A856DE555515AA26F81BA3C9@DM6PR03MB4122.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: sRLkhVlP0hphv24CdQD2ZKCCqNmjuLOsoZEgTzH4jGcMzZ0p+dnUcP+1lfUCT+k7FU5KhrUcEvPWKm64vs7ykhjS3CqG0bUmyYMYYfXBFqUIdsNtiFs7opS2EXagaOYWQXZJdPiqeMT3KTCyVtaBIVsitywv0BgislQVnkVI83aJy+ZQ/lUBQx6EW3HBKO5KSiqe6wSHz9JFSqn0Jlft+HboCTMDSCogZyZgBE9aRrnXTnAA5CJ4+q4/HkRTMS6chyv6pHZtohl+SLMISdb6RgqRRdqV5DWiiAnR3Cgcy61SRbO7QHqnrzmEvR2UddyVYMP36GjCuW1OJUd6WIm+2d3OBvpWQ0r95NqDe3ZR5zItuckK//aUzcy/5d2VS//sTqH02fSu/uAsY0QwQKTdVilXTAWwF3Q6m7plGO4+k5WxOGDacJuG2GnDaktLFixvJhZHB3G2/afojlAucOX0zsd+1htv6ibOT29L6gztfPghIC9/d/k8bd39Ifaaj/spAb5eLyh0XO7DUnlHrMGROH1aFpkQLuvNb6L8ZPeOFNvA/GYqefP44GAXB1n/+qe3uDe35xh08qvtXK41cwS8J0shNvzhmRO+2B8wdtlVY0pCmGN2Tk359i6TTCoFkXmeBLXT1aQl/S27znmm7YJqFNKs7fIFeSX3tBUuLIi+oKyYUR2hVtcpe0+bve6AnLwCkgfCzSHdgrHg1MEWS8hZnG4nC8DuSfYHsgRVN4c6gdLbzQoZXncTTtBMEM1acj8H2TQyG+aoWiHmnNWwFFh4KA==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(4326008)(36756003)(4744005)(38100700002)(8936002)(38070700005)(5660300002)(2906002)(31686004)(71200400001)(110136005)(76116006)(316002)(6486002)(8676002)(66446008)(508600001)(186003)(26005)(6512007)(66946007)(66556008)(122000001)(82960400001)(66476007)(53546011)(54906003)(31696002)(86362001)(6506007)(2616005)(91956017)(64756008)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?aUoxbkFCVSt2VjJCdWNORms0eTJFNnV5SWhob3ZqbEZmak5pN081MnRPYnJB?=
 =?utf-8?B?N0QzS25xeVFpNjN3ZEF4REhsNUFJNUpPeG5IRjJGQWNFa3BIZjVGeElFSkxq?=
 =?utf-8?B?NTBXWUo5NzBud2pkUTZKTjMxcEY1UEZla1h3eWoxaXN3UVRpUUNabTZhZkhO?=
 =?utf-8?B?RVVNWGlQSzd3SVI4dzVVeVNsRy9Bdng1cGhibG8vTW9UV0NsSE1SSXZSbE1z?=
 =?utf-8?B?OURBVU15Q2RyQ0tyNTNGZUM5aERSWjJzRmwwZkVPaGZ3OTdMTjlQdTVKUW1V?=
 =?utf-8?B?YmhubURYVW1qaWw4OTVOMm1aN1BtelI4eFZRR2ZQK3NhVWNwZFNtZk1VQnYy?=
 =?utf-8?B?ZFp6ZGZPYU9LVmc3M0pXOVhRcGYwUWxoaGRyZGRKc3hDS1VzdU9oeldJZ2Nk?=
 =?utf-8?B?WUJaZXA0QlJqSktydG14a1Fsekgzb3N5cW9hYW5JM2gzUm16djlIUGdPdXo1?=
 =?utf-8?B?VE03YjRiRmxPNlByVWVValcvSjZJREVkY2l3SGdGcUZ5clM0aEE0S0k3MHY0?=
 =?utf-8?B?WDZXQVhweGd0NmFmL09kNVpjTTVRRm1QYVZtSTBIUEVZK2pmZy8zUDkyRlAx?=
 =?utf-8?B?b0RXb0dLUFpEckNlbThNWVZJUlg2dWdmemZhM0NvbWVTbnArT252SEQzSStG?=
 =?utf-8?B?UVB6ODBvUDBEZ3lMNExKZ29YRUZlbFFiK1NLaXlLbmRlYWdudUNtWi9aaUxV?=
 =?utf-8?B?STZFdWQwZG03d1JBRFVvdnR4L2pEbitYdWZZWWV3eXJDQzRLNjVqM3RjUzNL?=
 =?utf-8?B?bXRGL042UnVsQVJFU3IzVXl0WENVVHkxSHRrMzhFV1c3MjViWWRSZ2pBQVJP?=
 =?utf-8?B?WlZlSjR3VUFsSHJ1NGVqNm4rOUJDTW5iVlVxYzZZWDN1c25ESWpIVGZUb3ky?=
 =?utf-8?B?b1R6dDVqSHoyYTh4SlRXSGFaRXdwYllHWUd3QXQ4SzdBcTJxcVhoOTB4L1dQ?=
 =?utf-8?B?Tkw4VGV3MUxBR1RkL1NOV1RUMms3TXMxYWREbGFabm5MUm9nNTRPRldmT0ll?=
 =?utf-8?B?ZmxIR0JFMUx0QUxMUk1WR1ZiOUluZmVBYkFLTnVtNjJkL1hqT3prR0ZseFlB?=
 =?utf-8?B?aDd3bjRMODVEVHJsaUU1aFFFSTN4M1NvbnV1MFVFYVplNmJIVFFmVTFzSHk1?=
 =?utf-8?B?M0N1b3ZsbUxtTCtoYU81TGI4VHNMR2l4ZlFnVXhwNnFXVFpIeXJSTHVJVU1F?=
 =?utf-8?B?Q1ZlaEVDWVU1VmRHbTdJNEpWZm01VEJnU3crZzRGYThDMnZuOFM2VHNMcDds?=
 =?utf-8?B?dHYyQ2lVa3pkQzJIdHF5UUhLSzRab3JxeHc3SmVYS0FqU21qVmFlbURwM0Qr?=
 =?utf-8?B?ci92MUJ3QVJjQXh4WkNHRk1NZVNFeTlmekxnU3h3aUhwdnkzOGJiWEM5cmZD?=
 =?utf-8?B?cGxiS3BvbzZRdjYyTTdQOUEzMHNZME0rM2pnMGxRc2gvUzdYQk1ZV0owa3NN?=
 =?utf-8?B?VzlWcC9vR2o2WjhmTFU5V2JPMTZUTVRnZWlLcFdFTGo5cnhNK2tqYzJFblgv?=
 =?utf-8?B?SjFLK0tpalU1MGNQY3dSV0thTmMzVmpKU2R2YUZ3dlBUVFBGNVR0NENEQnhy?=
 =?utf-8?B?Qlh5RHlqSzNneEZGM1NYQmRpdzRLcy9BMTY4eVhQdGNVWG1hYzNUdWRibm9B?=
 =?utf-8?B?S3k2RlB5YWdSMWk2eVlwanVpblIwR0ozM1p2ckY4b3oxYjdTSTh2WEJ1UlpT?=
 =?utf-8?B?YWZFTHEyT1ZMU1hSS0FqUGcyZDRoYmIyVm9NMUFQdDBZcml0cmE3S2pSWS8r?=
 =?utf-8?B?SmxraWdLRllEelNMSWhYMkFJeDJXcm13aUFVYzRGcUhYNEhWck1welN6czV6?=
 =?utf-8?B?YXlnRGFoenFLQ25haDhQczJxdVJLWU1XZ1QwOXZ5WjJFQUZBejlCTlQrc1Nw?=
 =?utf-8?B?ZnpOd2dVZ1NzTndaZ0hqYnJTVDIrVmJpZmFDb1dSQ2NESEVUQWxMYnhNTXow?=
 =?utf-8?B?ZWYvTWorc2RyS0x3bUExVWhBaEp1bHExUjh0S2MwZzgwQ09MaDF2bkx4dURz?=
 =?utf-8?B?dHN3bUFHYnQ0ZzBBOXBoazdpTG5hOHJ2bkIzdXBZdHhGUzZOcGhCYzViRlZR?=
 =?utf-8?B?TGl4UTFlV09NMnZFMWVLVVlObFgxOXZiZ2hCQWg1SUtEdzJsR20yR3RuRVRz?=
 =?utf-8?B?cmZaT084MDdSTHFNbEVPQ1VvUWhPeUtpWVRNVU00TXlQTEtZcExycWdvWmFI?=
 =?utf-8?B?eGZOdjNtcGxNcThtODJFbk80eVpicW14cFBqS0xZNHFodE9rYlh6R3AxRXhW?=
 =?utf-8?B?Titna2pZMFJmdGVQbFN2OU1iSGlBPT0=?=
Content-Type: multipart/alternative;
	boundary="_000_a3f52f29328089b65db5de224dd037cccitrixcom_"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2672ea3d-587a-4b0a-bddf-08d9f702f602
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Feb 2022 19:30:33.6506
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 3sx+1z1SopUNYXO1vm6edb19n84CEVgBS0G3+zwaaniFb7e7EQd7AVW99IX+SmoddRFwDoaWYuFWEcoG+/v2VT2HH71/DVAytFlgT0vtOOM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4122
X-OriginatorOrg: citrix.com

--_000_a3f52f29328089b65db5de224dd037cccitrixcom_
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64

T24gMjMvMDIvMjAyMiAxODozOCwgSnVsaWVuIEdyYWxsIHdyb3RlOg0KDQpGcm9tOiBKdWxpZW4g
R3JhbGwgPGpncmFsbEBhbWF6b24uY29tPjxtYWlsdG86amdyYWxsQGFtYXpvbi5jb20+DQoNCmZy
ZWVfaGVhcF9wYWdlcygpIGhhcyBhbiBBU1NFUlQoKSBjaGVja2luZyB0aGF0IG5vZGUgaXMgPj0g
MC4gSG93ZXZlcg0Kbm9kZSBpcyBkZWZpbmVkIGFzIGFuIHVuc2lnbmVkIGludC4gU28gaXQgY2Fu
bm90IGJlIG5lZ2F0aXZlLg0KDQpUaGVyZWZvcmUgcmVtb3ZlIHRoZSBjaGVjayBhcyBpdCB3aWxs
IGFsd2F5cyBiZSB0cnVlLg0KDQoNCkNvdmVyaXR5LUlEOiAxMDU1NjMxDQoNCg0KU2lnbmVkLW9m
Zi1ieTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNvbT48bWFpbHRvOmpncmFsbEBhbWF6
b24uY29tPg0KDQpBY2tlZC1ieTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4
LmNvbT48bWFpbHRvOmFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+DQo=

--_000_a3f52f29328089b65db5de224dd037cccitrixcom_
Content-Type: text/html; charset="utf-8"
Content-ID: <699729DBBAC8274195917B8A0EBCEDF6@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64

PGh0bWw+DQo8aGVhZD4NCjxtZXRhIGh0dHAtZXF1aXY9IkNvbnRlbnQtVHlwZSIgY29udGVudD0i
dGV4dC9odG1sOyBjaGFyc2V0PXV0Zi04Ij4NCjwvaGVhZD4NCjxib2R5Pg0KPGRpdiBjbGFzcz0i
bW96LWNpdGUtcHJlZml4Ij5PbiAyMy8wMi8yMDIyIDE4OjM4LCBKdWxpZW4gR3JhbGwgd3JvdGU6
PGJyPg0KPC9kaXY+DQo8YmxvY2txdW90ZSB0eXBlPSJjaXRlIiBjaXRlPSJtaWQ6MjAyMjAyMjMx
ODM4MzEuNTk1MS0xLWp1bGllbkB4ZW4ub3JnIj4NCjxwcmUgY2xhc3M9Im1vei1xdW90ZS1wcmUi
IHdyYXA9IiI+RnJvbTogSnVsaWVuIEdyYWxsIDxhIGNsYXNzPSJtb3otdHh0LWxpbmstcmZjMjM5
NkUiIGhyZWY9Im1haWx0bzpqZ3JhbGxAYW1hem9uLmNvbSI+Jmx0O2pncmFsbEBhbWF6b24uY29t
Jmd0OzwvYT4NCg0KZnJlZV9oZWFwX3BhZ2VzKCkgaGFzIGFuIEFTU0VSVCgpIGNoZWNraW5nIHRo
YXQgbm9kZSBpcyAmZ3Q7PSAwLiBIb3dldmVyDQpub2RlIGlzIGRlZmluZWQgYXMgYW4gdW5zaWdu
ZWQgaW50LiBTbyBpdCBjYW5ub3QgYmUgbmVnYXRpdmUuDQoNClRoZXJlZm9yZSByZW1vdmUgdGhl
IGNoZWNrIGFzIGl0IHdpbGwgYWx3YXlzIGJlIHRydWUuDQo8L3ByZT4NCjwvYmxvY2txdW90ZT4N
Cjxicj4NCkNvdmVyaXR5LUlEOiA8c3BhbiBjbGFzcz0iZGVmZWN0LXRleHQiPjEwNTU2MzE8L3Nw
YW4+PGJyPg0KPGJyPg0KPGJsb2NrcXVvdGUgdHlwZT0iY2l0ZSIgY2l0ZT0ibWlkOjIwMjIwMjIz
MTgzODMxLjU5NTEtMS1qdWxpZW5AeGVuLm9yZyI+DQo8cHJlIGNsYXNzPSJtb3otcXVvdGUtcHJl
IiB3cmFwPSIiPlNpZ25lZC1vZmYtYnk6IEp1bGllbiBHcmFsbCA8YSBjbGFzcz0ibW96LXR4dC1s
aW5rLXJmYzIzOTZFIiBocmVmPSJtYWlsdG86amdyYWxsQGFtYXpvbi5jb20iPiZsdDtqZ3JhbGxA
YW1hem9uLmNvbSZndDs8L2E+PC9wcmU+DQo8L2Jsb2NrcXVvdGU+DQo8YnI+DQpBY2tlZC1ieTog
QW5kcmV3IENvb3BlciA8YSBjbGFzcz0ibW96LXR4dC1saW5rLXJmYzIzOTZFIiBocmVmPSJtYWls
dG86YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbSI+DQombHQ7YW5kcmV3LmNvb3BlcjNAY2l0cml4
LmNvbSZndDs8L2E+PGJyPg0KPC9ib2R5Pg0KPC9odG1sPg0K

--_000_a3f52f29328089b65db5de224dd037cccitrixcom_--


From xen-devel-bounces@lists.xenproject.org Wed Feb 23 19:38:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 23 Feb 2022 19:38:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277778.474606 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMxSu-0008UP-51; Wed, 23 Feb 2022 19:38:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277778.474606; Wed, 23 Feb 2022 19:38:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMxSu-0008UI-15; Wed, 23 Feb 2022 19:38:20 +0000
Received: by outflank-mailman (input) for mailman id 277778;
 Wed, 23 Feb 2022 19:38:18 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=PMTg=TG=citrix.com=prvs=046033a78=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nMxSs-0008UC-Bo
 for xen-devel@lists.xenproject.org; Wed, 23 Feb 2022 19:38:18 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 24cf2dae-94e0-11ec-8eb8-a37418f5ba1a;
 Wed, 23 Feb 2022 20:38:16 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 24cf2dae-94e0-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645645096;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=OsNSTOAFzRvtTZXg+Ac4XNrjMuDp1cbY+Z5tYgitLv4=;
  b=QD1pRo2+zE/Hd7FSh4fr1t4eW7b1lqziTWMjxRd3NdDbjIcoO4cVs3/1
   i3cqNSOFOjeci69Cu5HL0PgQpbc5nb/h/cDL4O6IcwaGWpEpnn/vCgqn+
   L1f1vPRJdQz5uGMls52yzmmFMAB2wJwovyFtbE2amPVPhdR1tN0DhCgjb
   k=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 64849239
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:qHT7la/lwAab0UsfnDREDrUDnn6TJUtcMsCJ2f8bNWPcYEJGY0x3y
 jAZXGyDPvjfYzHwfo8ibty09h5UvpaBnIdlTVNpryo8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si+Fa+Sn9T8mvU2xbuKU5NTsY0idfic5Dndx4f5fs7Rh2NQw24LiW1nlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCnaawe1obGof1o7siXEBbNgd4foBhwrCSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFKoZtmtt0nfyCvE+TIqYa67L+cVZzHE7gcUm8fP2O
 ZZJNWs1N0WojxtnHA8uOr4Vv8GRmyfNVAN/gluKnrhn7D2GpOB2+Oe0a4eEEjCQfu1XkVyRo
 mbu9mHwEBYccteYzFKt4n+qw+PCgy7/cIYTD6GjsO5nhkWJwW4eAwFQUkG0ydG7l0q/VtR3O
 0ESvC00osAPGFeDF4enGUfi+Tjd40BaC4E4//AGBB+l8KrmvjS9LFE/EQFOMd8Dksl1aBsQ2
 Qrc9z/2PgBHvLqQQHOb076bqzKuJCQYRVM/iT84oRgtuIe6/txq5v7bZpM6SfPu0IWpcd3l6
 23S9EADa6MvYdnnPklR1XTOmHqSq5fAVWbZDS2HDzv+vmuViGNIDrFECGQ3D94ddO51rXHb5
 RDofvRyCshUUflhcwTXHY0w8EmBvartDdElqQcH82Md3zqs4WW/Wotb/StzIkxkWu5dJ2O0P
 RKN4VMLuMADVJdPUUORS9jtYyjN5fK9fekJq9iONoYeCnSPXFXvEN5Sib64gDm2zRlEfVAXM
 paHa8e8ZUv2+ow8pAdas9w1iOdxrghnnDu7bcmik3yPjOrPDFbIGOxtGAbfMYgEAFas/Vy9H
 yB3bJDRlX2ykYTWP0HqzGLkBQpUdSNiXciu8aS6tIere2JbJY3oMNeIqZsJcI15haVF0ODO+
 3C2QEhDz1Tjw3bALG23hrpLNdsDgb4XQaoHABER
IronPort-HdrOrdr: A9a23:CQndjKk1BmQF8JH05TtBfNYgYuTpDfOCimdD5ihNYBxZY6Wkfp
 +V88jzhCWZtN9OYhwdcIi7SdS9qXO1z+8R3WGIVY3SEzUOy1HYUL2KirGSjQEIeheOutK1sJ
 0PT0EQMqyIMbEXt7eY3OD8Kadb/DDlytHouQ699QYUcegCUcgJhG0ZajpzUHcGPzWubaBJT6
 Z0jfA3wwZIDE5nCPhTcUN1ONQryee79q7OUFojPVoK+QOOhTSn5PrRCB6DxCoTVDtJ3PML7X
 XFuxaR3NTij9iLjjvnk0PD5ZVfn9XsjvFZAtaXt8QTIjLwzi61eYVaXaGYtjxdmpDt1L9qqq
 iPn/4TBbU215rjRBDznfIr4Xin7N8a0Q6m9bZfuwq7nSW2fkNjNyMLv/MnTvKQ0TtfgDg76t
 MQ44vRjesmMfuL9h6NluTgRlVkkFG5rmEllvNWh3tDUZEGYLsUtoAH+lhJea1wVx4SxbpXWd
 WGNvusrMq+sGnqG0zxry1q2pihT34zFhCJTgwLvdGUySFfmDR8w1EDzMISk38c/NZlIqM0qt
 jsI+BtjvVDX8UWZaVyCKMIRta2EHXERVbJPHiJKVrqGakbMzbGqoLx4r8y+Oa2EaZ4hqcaid
 DEShdVpGQyc0XhBYmH24BK6AnERCGnUTHk2qhllu5EU33HNc3W2AG4OSITepGb0oYi6+XgKo
 OOBK4=
X-IronPort-AV: E=Sophos;i="5.88,391,1635220800"; 
   d="scan'208";a="64849239"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=PiPvpQ1sZUOjAvX7RrzmCzhcjT7bFe+hjustFkG5Xi0aVHMsJ8usdINU0WsC1EyweoD2USHbqYYzxUWTLNP50SLDO1Sac5g1/LBErWG84dW8Gyt59R73pm+WOl4H2Xbdp3/L5MJ6hh0h8cQclZ0dFdqR5o1vrcUEhr4ZJdHbfP9VJuGtwlKDMsybHXQVHH6z5wQlL5Ny3dyUYnzGeuP+1AbjeNup1BF5hYNdCAR/w0UWgmNbkApTlekqJYEi0kVuFlA9g+SKX1nKcCRO5k5Unv/g9ZTEc4lTbXb0fPjyaLkXVwJM3wRewYuP8+IzzLyiid73SJWEmzB+xSbllfhHdw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=OsNSTOAFzRvtTZXg+Ac4XNrjMuDp1cbY+Z5tYgitLv4=;
 b=jr+nwk6DMpimgIRhqYAEBGh3hUDHrsMdegCiNwuIMljf+npcO1aSs9GJxRaceWP0Tq6T48bK0yPkCUV+BCINnJutSpyXE2VsAlo8M0omKnWJSAFBgw9XRYDJGuC8MJ60dzoHNr6AIrzCe7sIBpkSK+rl7KTd6voF2pKhS6NzcBbq0tTjI9EGCEiNBPuu2/jJgmuBzaqOOT5oEP3t+tB2QVsm66dAFQ/MuFUUv6cJQX9mUEH/6AI89mxoXSnpTefVT2IsSaKR4bnqB1mgizJ8naS5G0pnAiJQDclveLWV5r05s9Nxu628TI9Kqd8UvIEJUX9VcqO8ZwB70dJEMpu0Ug==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=OsNSTOAFzRvtTZXg+Ac4XNrjMuDp1cbY+Z5tYgitLv4=;
 b=FnRdXtCc1Hm2AIHcLZY5aMJWpWg8u1PmhOmQPPZIC48nM/Lri4CE0Ms/A/DW3kvO1z8jcOK/jHWDBH5wuJlPXXhx0AXw0LxIvIH4GIb3q/eU1rieU8BI/M5SmvfuxE62lhS1Buo6xhCcaHGn22M1D6SagEocYSyvA8RPQdv1zxY=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Julien Grall <julien@xen.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Julien Grall <jgrall@amazon.com>
Subject: Re: [PATCH v2] xen/mm: pg_offlined can be defined as bool in
 free_heap_pages()
Thread-Topic: [PATCH v2] xen/mm: pg_offlined can be defined as bool in
 free_heap_pages()
Thread-Index: AQHYKOjWJCDx2mm9mk6Wd3Mq36vJRKyhh/cA
Date: Wed, 23 Feb 2022 19:38:12 +0000
Message-ID: <27fd5c5f-591c-42c4-abed-95a9e5829d56@citrix.com>
References: <20220223190833.24710-1-julien@xen.org>
In-Reply-To: <20220223190833.24710-1-julien@xen.org>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 26ce85f0-6a9c-4df3-f30f-08d9f704076a
x-ms-traffictypediagnostic: SJ0PR03MB5856:EE_
x-microsoft-antispam-prvs: <SJ0PR03MB58568C1DD3FDEF71B7E902C2BA3C9@SJ0PR03MB5856.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: h8a9lgbd6PR+aRz8/l5HVxx6l6bYouabcxlnEwKnsVP8f15u1iFiATGKyooJTcPmuEwED7j6cdNDd5FpaIIr2neq7ucGkcO1E7TJymddONjx/pUAtgY7piBRK09MDWQ6zrYgqEdww5027VU1i7HW6NBogYDKA3h59FVuLSlG7EUxvR7jlJwL2ml1XPnvGqtbbgazkC5S/klP1EwQt1aOVt++CduXHNWVjTPmc3hSV1A0PEjPw5MyD4Ensy4lxVnNjlL3X6ok0BmUEqhXF1Do3MiL5r67rzEvruCZVdeQYmdR2xXUEHCew7Og2MzYQ12TjvHzln2kO2SkIgjZL6N0WMDH4A4FDjlepBKIjsIRwOURmaGJSohXoPw2Ajm4RUbjqeivnzNCah8BOD8Enj9UEDidfQvDZ4RMwcDb+ycspZAUFv0jqBPJgQ/NyrUbp7k1bfiJdjyOm1n7WiuLKpAnpx2YT7thchX+lEmqbcKq1CiWVXDPyqpZhxddJRsgkde9mMMLYEO4xMGBXVk9WgLcwIN25Alp3qXCD7cmBmSt6o3DiJB43MyQbwrrV9KGG40PmpB0+txjRG1ThnXX0pgJMvHlkEm2nRQsH7M0wzTszfbXjz4WL6oawHyaAAA5b5tdFWVUlVcSw3Jsy/qnWwYd/2Vixlo2iVfezu0tuUZ4OQlYl5NlcLrj1sq3VbQyHhm4GUZOtrDyOXhOi6WN9DjrKhL1RIZj1CcOb6ExwnTIdcPk273Lo4mKjz0TbMfMgM4UrLrM5nEtnvcSU0KULkiHcg==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(2906002)(38100700002)(122000001)(82960400001)(66476007)(66556008)(66446008)(64756008)(66946007)(91956017)(8936002)(76116006)(8676002)(4326008)(38070700005)(53546011)(508600001)(6512007)(31686004)(4744005)(6486002)(71200400001)(110136005)(31696002)(86362001)(2616005)(26005)(5660300002)(36756003)(6506007)(186003)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?dzIyRzREWTJsWktkL0NXcVNGMHFkUnRpczg5c29XWnBoSllMVDhuMWJuVjJY?=
 =?utf-8?B?dXlxTEkwaHZ0UC82TVhmYXRhQTBwaGd3WnlDUG1xWDNOSE8vNEpXYkpkV1Vm?=
 =?utf-8?B?WmNYd0t1clpRZDRSdEFEN1BXM0NYdVh4R2NwUFEzVkxQUW9vWkQ4enBaVjJ5?=
 =?utf-8?B?ODlEUnorN25Hd2xsVUhvcXZGQ1ZVdmp3cVVQZDVNYmtzQjR3aWhEcXlIakVR?=
 =?utf-8?B?UmI5dmtlYzJncXFobUlyc0U0ZldJWEc1Qk1zOU55Z0tma09mTHVZRG4xaklX?=
 =?utf-8?B?WU40TG0vY3dKQ2liMmVnNUgxcUZsSlpOY1FmdGY2MHdxQTJWbDdmM3VRM0lw?=
 =?utf-8?B?d2p4NWFRbnFtcjQ0cHkvb21kd3pzOWZrTmZ3STRNbGdpU2VROGRHWnpidXB1?=
 =?utf-8?B?bEZhNE83Y0ZKdG5PaFZVUTZLRjVzL2kzd3c2NVkwSkNkVHMreGYzZWlqeFJT?=
 =?utf-8?B?bWtzeXFFem1NTTdwSmJTeE0vRDArdHJzb0JmMWtMODBPUURROXRkeEFpSG5C?=
 =?utf-8?B?dUU0R29ua3Fjak83VHVxWFg5cHpDbFFYWTluNkl1MEpLRU1oaDlHWUFRYWox?=
 =?utf-8?B?VzA4cFpPOWdKb29xRzNmR0VFL3VWeGdZWWROWjRYcmFldHVEYmkzL1hnTkQ0?=
 =?utf-8?B?WnNWWi90T1Bra3lDOFd0M1FMUTJldm9rbHk1YVdmMU8zK0E4VTZKR3ZtZG9v?=
 =?utf-8?B?OEc4djFiQTZKN0xYT0hHSG9aYmRZZm9LYllxQmVoSkxRclUyU1dWOU8rWlZk?=
 =?utf-8?B?TUl2NGpabC9IZUFsaWtqb0hIQ1BWU0RxdUgrcmZEcVpiWlZrSDM4UzEvVnFj?=
 =?utf-8?B?OExJc2FUcGQxZzlhQ3JwTkw3S0RpaGo5K1BDSWtOQXVMdTBOckJmd3NMU05I?=
 =?utf-8?B?ODMwdFFZd3lYSHM3aWlEZ0szSktwS2d0QVVpK24rQ09sbXFqVXdxejNkbDVE?=
 =?utf-8?B?UmVpbkU5WVN1SGdJRnFwM29DZzdzSFRSQkxRaUZEUHJ0SUpNQXdLU1pKY1pu?=
 =?utf-8?B?OXdocC8zWUVuZDM0NnZSdWsxcWN3dmliRFlaVU04eTFaeU1nMThHaE1LWi9y?=
 =?utf-8?B?WGsrMzVCSWxXTUd4MFpEdHdiYnI0bTU1NGNibVQrQnZzTEVtNnJ6OXNmTEpk?=
 =?utf-8?B?Q1lycEZud1J4Y3VWd1ZQalFBTlV5cmpuRFBQeE9Wcmw4SHVrZHl6UXFjK1FS?=
 =?utf-8?B?cXBGcU5jV0RLcHdJZGF3Z1pCa1dlOEhYdmtVNUY3Um9HSlBMOHhpVDBxbUFN?=
 =?utf-8?B?Q3Jyb0ltWExaVVFNZ2VwSXIrMkZWQTltbEt2bEk1Q3YrYXlkdDhlZ0J1NDRh?=
 =?utf-8?B?MnZ4VFVCQUpoRnZMWHRXaFVMRzNlUW9oVlk3bkJ0WTMvSmNGYnFqSGRKa2oz?=
 =?utf-8?B?UnNiQi9WSlM4SDVOdVFmYkhCMGFXOVdDVERTOE5PN0pycUdkZHhRanZxcVYw?=
 =?utf-8?B?TUR2NTBqZEt6MWJEY3Izb295WkpuRXNGa1ZmY2tnbU9xM1JHd3FlWS80SDBP?=
 =?utf-8?B?MTZkWEpKcDl5Z0JqSmJJTXJaRlVrdVpOQjI3QnRGRUcwbnVkdTJ3cjFWcFJy?=
 =?utf-8?B?OWpCVFVLallrQ0pnQXh3UktMdnM3UGwzYWRPa3k2QjduK21FSGVqN3JyNTly?=
 =?utf-8?B?OFVucmpPdEI3aUtXa2l3c2JKUFduMHN2b2NZL1pNKzlrSHJhQjRrRWs0VEJN?=
 =?utf-8?B?UVRyWlpUZEZCbDBSTkc0NGdKK3hwcW0yTWFsUFRWNTYxZFNHTzJOZTNGZWlw?=
 =?utf-8?B?UlI4UVhSU1FtUDVXM0lwWU5sSi8rZWxKT3B6c0lUSTdIb1NtTFNReUhnTEY3?=
 =?utf-8?B?UlZuMW9wQ24rVVJIajZ0Z2ZyWEVuVWxzU1pwUks0ZGpjVTlUMTZiZklPNVcv?=
 =?utf-8?B?UllySmQ2dGJ1ZVBBZHVGUFdHUnRpL204bHRCWUFUR2ZNWXpkcThVbjdCbVAr?=
 =?utf-8?B?bi9oWm9OTERpTUN4VjlaWHVLZFZhNFgzMUt3Z2UxLzRJelZQTjRQSEpVNDJH?=
 =?utf-8?B?ZjRpZnU2TjJxT3lTZklVTGk1SVhOYk1YT3MrK1hEVy94TGJnYnRZaHJyS1hq?=
 =?utf-8?B?QUxaY3pjSVJuRW9MMjRic1hhSytIQXRucDlYN21pZ2hraFdBRFFoSWRFZ2dG?=
 =?utf-8?B?eG5yTTcxWWdncDgzSlRuZlRORTJiQjY5c3lidituaW10WVdGUHlUV2dLZXA5?=
 =?utf-8?B?V0pVdDk1cDVMM2FvQ0FVOVdFeHUwamx5VGNXSnZqMWRRNG9kVmpad3JnQU1y?=
 =?utf-8?B?Y3VKTHZFc1JzY3liUElYRU1BSDV3PT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <3F25AF936AD2944CBC3A0B60483F9934@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 26ce85f0-6a9c-4df3-f30f-08d9f704076a
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Feb 2022 19:38:12.4609
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: /vXA8WbE5RUjQl37E6tBMI4EE3H6F/9DmYHwoIPS5eBbdqmSHXfqlVV0rynstiU37OvbqxmWR2+e9hLD2Vc6XxIykJhBLG296FeHD7kiU0I=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5856
X-OriginatorOrg: citrix.com

T24gMjMvMDIvMjAyMiAxOTowOCwgSnVsaWVuIEdyYWxsIHdyb3RlOg0KPiBGcm9tOiBKdWxpZW4g
R3JhbGwgPGpncmFsbEBhbWF6b24uY29tPg0KPg0KPiBUaGUgbG9jYWwgdmFyaWFibGUgcGdfb2Zm
bGluZWQgaW4gZnJlZV9oZWFwX3BhZ2VzKCkgY2FuIG9ubHkgdGFrZSB0d28NCj4gdmFsdWVzLiBT
byBzd2l0Y2ggaXQgdG8gYSBib29sLg0KPg0KPiBTaWduZWQtb2ZmLWJ5OiBKdWxpZW4gR3JhbGwg
PGpncmFsbEBhbWF6b24uY29tPg0KDQpJJ2QgYXJndWUgdGhpcyBtaWdodCB3YW50IHRvIGdvIGFz
IGZhciBhcyBkZWNsYXJpbmcgRml4ZXM6IDI4OTYxMDQ4M2ZjNDMNCndoaWNoIHJlYWxseSBkaWQg
aW50cm9kdWNlIG9uZSBib29sIHBnX29mZmxpbmVkIGFuZCBvbmUgdW5zaWduZWQgaW50DQpwZ19v
ZmZsaW5lZCB3aGljaCB3ZXJlIHRoZSBzYW1lIHRoaW5nLg0KDQpFaXRoZXIgd2F5LCBBY2tlZC1i
eTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4NCg==


From xen-devel-bounces@lists.xenproject.org Wed Feb 23 20:42:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 23 Feb 2022 20:42:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277785.474616 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMyT7-0006qP-2M; Wed, 23 Feb 2022 20:42:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277785.474616; Wed, 23 Feb 2022 20:42:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMyT6-0006qI-Vo; Wed, 23 Feb 2022 20:42:36 +0000
Received: by outflank-mailman (input) for mailman id 277785;
 Wed, 23 Feb 2022 20:42:35 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nMyT5-0006q6-Jt; Wed, 23 Feb 2022 20:42:35 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nMyT5-0001iD-Im; Wed, 23 Feb 2022 20:42:35 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nMyT5-0003Pc-4D; Wed, 23 Feb 2022 20:42:35 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nMyT5-0002Yt-3j; Wed, 23 Feb 2022 20:42:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Pe6wldPeJpKu0MGeFo2fbkEDg9FU9dvRcfj7uUiRjUM=; b=jB9m4WqtZmFZ6j8iucZ5HRNSGz
	iF5NMRUSiurTtfF1tnz+edNrBeUVbE9jPVEPZS1jc/XCn6T6zzIX6I/0L6iO6BdHz7yld+JrUgNBp
	JOByjQ+2rDUffZg4PwJkzNlBaiM6f5ecP0w0xfxQE39gz9/ycLldtXhp9V8buAyzEjrk=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168208-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 168208: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=f04231775c179b3424fca45d64f29e226a41a610
X-Osstest-Versions-That:
    xen=210f27e55abd2a57c01105992bc10bc4d7b8132d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 23 Feb 2022 20:42:35 +0000

flight 168208 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168208/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  f04231775c179b3424fca45d64f29e226a41a610
baseline version:
 xen                  210f27e55abd2a57c01105992bc10bc4d7b8132d

Last test of basis   168195  2022-02-22 15:01:45 Z    1 days
Testing same since   168208  2022-02-23 17:00:29 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Dario Faggioli <dfaggioli@suse.com>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Julien Grall <jgrall@amazon.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   210f27e55a..f04231775c  f04231775c179b3424fca45d64f29e226a41a610 -> smoke


From xen-devel-bounces@lists.xenproject.org Wed Feb 23 21:15:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 23 Feb 2022 21:15:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277798.474628 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMyyS-0001m4-Q1; Wed, 23 Feb 2022 21:15:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277798.474628; Wed, 23 Feb 2022 21:15:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMyyS-0001lx-Mj; Wed, 23 Feb 2022 21:15:00 +0000
Received: by outflank-mailman (input) for mailman id 277798;
 Wed, 23 Feb 2022 21:15:00 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=SrHI=TG=invisiblethingslab.com=marmarek@srs-se1.protection.inumbo.net>)
 id 1nMyyR-0001lr-Sr
 for xen-devel@lists.xenproject.org; Wed, 23 Feb 2022 21:15:00 +0000
Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com
 [64.147.123.20]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a651e0a6-94ed-11ec-8eb8-a37418f5ba1a;
 Wed, 23 Feb 2022 22:14:58 +0100 (CET)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.46])
 by mailout.west.internal (Postfix) with ESMTP id 0CF4F3201DD2;
 Wed, 23 Feb 2022 16:14:53 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163])
 by compute2.internal (MEProxy); Wed, 23 Feb 2022 16:14:54 -0500
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed,
 23 Feb 2022 16:14:51 -0500 (EST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a651e0a6-94ed-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-type:date:date:from:from
	:in-reply-to:in-reply-to:message-id:mime-version:references
	:reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy
	:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=yUW5NrWp4eORsmlcX
	ZcclcuZif21PYwZWhbYlB+pCAg=; b=LDh3Dk9bE/KQViGQM63rqvL1VMc8uoeO5
	pVlkzEyX/cva7uEIe39Dj2GWrHB3wtzPMO2FhnQO2jlMy00pRAPiifXu8zNuO7eX
	lWjCgxiuBfiWCrtoIAPbIB0tDBXTQkB5o6yE7jgvWWyYc/zfsx93kfAtb7EZf0Rn
	q2nJ86xhAWtGOmxx5G1seFrcoRsBB6zGpOkzrWIDKLgDnvK0GQvw9x1q5Lwa33yH
	13gIW9nXb7Zl9PV8wmKkeLcfjVoy0Su0YxUHgNdQqdqdtFs2zAOuVsfFtBy2n2y0
	BquISaVeFQVhjQvBpqedFHME0bzeVYJkMykrHG5Cluc5ojaJOaXTg==
X-ME-Sender: <xms:zaMWYpir3nWLCMfuLnodtoS9s1yOyEtthSOuLCrqqI5xPYxIKRr0PA>
    <xme:zaMWYuC7D4Zf6mn3CbX4j-IRJQCArQNAMiex2dE-KEGuNyy5SKQNfpkfii8qZZWYF
    I5iJQLIUBk0Mg>
X-ME-Received: <xmr:zaMWYpGWXqF5RVCrj-JxQAx3Xfx0ft0W1AFyOMI2gcnsdM8NNqlDjwxFPWoxkqToW_z95stGNV5jM9dj-7MtCtKQ6pQDo07qgA>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrledtgddugeegucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
    cujfgurhepfffhvffukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeforghrvghk
    ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh
    hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeekgedt
    gfdvieehhfehtddvleeiieeuteevheetffejjeejvdeijeevhfeufeefgeenucffohhmrg
    hinhepghhithhhuhgsrdgtohhmnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghm
    pehmrghilhhfrhhomhepmhgrrhhmrghrvghksehinhhvihhsihgslhgvthhhihhnghhslh
    grsgdrtghomh
X-ME-Proxy: <xmx:zaMWYuTNG4Ei3q1O0xQhFzBGrX1pFxfw7jLnYUmfPoEvUdG-NqK_7A>
    <xmx:zaMWYmxGRbakm2kphG-zfIm6GYS4I108VixjYL-MpTGM-wt1Dp5BRg>
    <xmx:zaMWYk6gOu0k7Amx-u0-Yn3IVI8bW95fzAnBTuzCyMy95ck2THSG5Q>
    <xmx:zaMWYhz-Xz0Mb_o3gFA2yf1wCB6g5u51TGVRYJ9NmBvlI1fTUiuFjA>
Date: Wed, 23 Feb 2022 22:14:48 +0100
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Juergen Gross <jgross@suse.com>, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Antoine Tenart <atenart@kernel.org>,
	"moderated list:XEN HYPERVISOR INTERFACE" <xen-devel@lists.xenproject.org>,
	"open list:NETWORKING DRIVERS" <netdev@vger.kernel.org>
Subject: Re: [PATCH] xen/netfront: destroy queues before real_num_tx_queues
 is zeroed
Message-ID: <YhajyDmotYNQLx9J@mail-itl>
References: <20220220134202.2187485-1-marmarek@invisiblethingslab.com>
 <3786b4ef-68e7-5735-0841-fcbae07f7e54@suse.com>
 <20220222120301.10af2737@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="Uax9XTxqAklV2iNX"
Content-Disposition: inline
In-Reply-To: <20220222120301.10af2737@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>


--Uax9XTxqAklV2iNX
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Wed, 23 Feb 2022 22:14:48 +0100
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Juergen Gross <jgross@suse.com>, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Antoine Tenart <atenart@kernel.org>,
	"moderated list:XEN HYPERVISOR INTERFACE" <xen-devel@lists.xenproject.org>,
	"open list:NETWORKING DRIVERS" <netdev@vger.kernel.org>
Subject: Re: [PATCH] xen/netfront: destroy queues before real_num_tx_queues
 is zeroed

On Tue, Feb 22, 2022 at 12:03:01PM -0800, Jakub Kicinski wrote:
> On Mon, 21 Feb 2022 07:27:32 +0100 Juergen Gross wrote:
> > On 20.02.22 14:42, Marek Marczykowski-G=C3=B3recki wrote:
> > > xennet_destroy_queues() relies on info->netdev->real_num_tx_queues to
> > > delete queues. Since d7dac083414eb5bb99a6d2ed53dc2c1b405224e5
> > > ("net-sysfs: update the queue counts in the unregistration path"),
> > > unregister_netdev() indirectly sets real_num_tx_queues to 0. Those two
> > > facts together means, that xennet_destroy_queues() called from
> > > xennet_remove() cannot do its job, because it's called after
> > > unregister_netdev(). This results in kfree-ing queues that are still
> > > linked in napi, which ultimately crashes:
> > >=20
> > >      BUG: kernel NULL pointer dereference, address: 0000000000000000
> > >      #PF: supervisor read access in kernel mode
> > >      #PF: error_code(0x0000) - not-present page
> > >      PGD 0 P4D 0
> > >      Oops: 0000 [#1] PREEMPT SMP PTI
> > >      CPU: 1 PID: 52 Comm: xenwatch Tainted: G        W         5.16.1=
0-1.32.fc32.qubes.x86_64+ #226
> > >      RIP: 0010:free_netdev+0xa3/0x1a0
> > >      Code: ff 48 89 df e8 2e e9 00 00 48 8b 43 50 48 8b 08 48 8d b8 a=
0 fe ff ff 48 8d a9 a0 fe ff ff 49 39 c4 75 26 eb 47 e8 ed c1 66 ff <48> 8b=
 85 60 01 00 00 48 8d 95 60 01 00 00 48 89 ef 48 2d 60 01 00
> > >      RSP: 0000:ffffc90000bcfd00 EFLAGS: 00010286
> > >      RAX: 0000000000000000 RBX: ffff88800edad000 RCX: 0000000000000000
> > >      RDX: 0000000000000001 RSI: ffffc90000bcfc30 RDI: 00000000ffffffff
> > >      RBP: fffffffffffffea0 R08: 0000000000000000 R09: 0000000000000000
> > >      R10: 0000000000000000 R11: 0000000000000001 R12: ffff88800edad050
> > >      R13: ffff8880065f8f88 R14: 0000000000000000 R15: ffff8880066c6680
> > >      FS:  0000000000000000(0000) GS:ffff8880f3300000(0000) knlGS:0000=
000000000000
> > >      CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> > >      CR2: 0000000000000000 CR3: 00000000e998c006 CR4: 00000000003706e0
> > >      Call Trace:
> > >       <TASK>
> > >       xennet_remove+0x13d/0x300 [xen_netfront]
> > >       xenbus_dev_remove+0x6d/0xf0
> > >       __device_release_driver+0x17a/0x240
> > >       device_release_driver+0x24/0x30
> > >       bus_remove_device+0xd8/0x140
> > >       device_del+0x18b/0x410
> > >       ? _raw_spin_unlock+0x16/0x30
> > >       ? klist_iter_exit+0x14/0x20
> > >       ? xenbus_dev_request_and_reply+0x80/0x80
> > >       device_unregister+0x13/0x60
> > >       xenbus_dev_changed+0x18e/0x1f0
> > >       xenwatch_thread+0xc0/0x1a0
> > >       ? do_wait_intr_irq+0xa0/0xa0
> > >       kthread+0x16b/0x190
> > >       ? set_kthread_struct+0x40/0x40
> > >       ret_from_fork+0x22/0x30
> > >       </TASK>
> > >=20
> > > Fix this by calling xennet_destroy_queues() from xennet_close() too,
> > > when real_num_tx_queues is still available. This ensures that queues =
are
> > > destroyed when real_num_tx_queues is set to 0, regardless of how
> > > unregister_netdev() was called.
> > >=20
> > > Originally reported at
> > > https://github.com/QubesOS/qubes-issues/issues/7257
> > >=20
> > > Fixes: d7dac083414eb5bb9 ("net-sysfs: update the queue counts in the =
unregistration path")
> > > Cc: stable@vger.kernel.org # 5.16+
> > > Signed-off-by: Marek Marczykowski-G=C3=B3recki <marmarek@invisiblethi=
ngslab.com>
> > >=20
> > > ---
> > > While this fixes the issue, I'm not sure if that is the correct thing
> > > to do. xennet_remove() calls xennet_destroy_queues() under rtnl_lock,
> > > which may be important here? Just moving xennet_destroy_queues() befo=
re =20
> >=20
> > I checked some of the call paths leading to xennet_close(), and all of
> > those contained an ASSERT_RTNL(), so it seems the rtnl_lock is already
> > taken here. Could you test with adding an ASSERT_RTNL() in
> > xennet_destroy_queues()?
> >=20
> > > unregister_netdev() in xennet_remove() did not helped - it crashed in
> > > another way (use-after-free in xennet_close()). =20
> >=20
> > Yes, this would need to basically do the xennet_close() handling in
> > xennet_destroy() instead, which I believe is not really an option.
>=20
> I think the patch makes open/close asymmetric, tho. After ifup ; ifdown;
> the next ifup will fail because queues are already destroyed, no?
> IOW xennet_open() expects the queues were created at an earlier stage.

Right.

> Maybe we can move the destroy to ndo_uninit? (and create to ndo_init?)

It looks like talk_to_netback(), which currently create queues, needs
them for for quite some work. It is also called when reconnecting (and
netdev is _not_ re-registered in this case), so that would be a
significant refactor.
But, moving destroy to ndo_uninit() should be fine. It works, including
after ifup;ifdown;ifup case too. I'll send v2 shortly.

--=20
Best Regards,
Marek Marczykowski-G=C3=B3recki
Invisible Things Lab

--Uax9XTxqAklV2iNX
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmIWo8gACgkQ24/THMrX
1yy8TQf/fTgM2gqArLzbOD4YE+NC3A/kn5VWlNVJOnvRlmtUyoc1WUTqqsENYBGA
4E81gq+MF/m7dVdq54oQpBKXPL+b1xE5MUBOs8MXkJTCRuRCKGJFU2APU4CF95he
w3kAGC6JYyCnnHUoQLWkvJsMPtj2Ldsx7fw1EkcMXJjsXTQka4bMpDbgvoM0YDJG
HzJ5GlBbAEzLp8op2KaW0XKKc/wtlTrwxRxZE24AizaA+5zvykOsUdtvtZvC6dC1
DgGYZ9gKFeFTP41eeyr0ZtwKqRv1vhqEUFcqpej/UQUYorxld7uPy8YwlQgXc/SQ
dJxzm21BpI1tEcpdStGoMYD9TPcxOQ==
=QCDX
-----END PGP SIGNATURE-----

--Uax9XTxqAklV2iNX--


From xen-devel-bounces@lists.xenproject.org Wed Feb 23 21:20:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 23 Feb 2022 21:20:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277805.474638 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMz3c-0003E2-Do; Wed, 23 Feb 2022 21:20:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277805.474638; Wed, 23 Feb 2022 21:20:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nMz3c-0003Dv-AX; Wed, 23 Feb 2022 21:20:20 +0000
Received: by outflank-mailman (input) for mailman id 277805;
 Wed, 23 Feb 2022 21:20:19 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=SrHI=TG=invisiblethingslab.com=marmarek@srs-se1.protection.inumbo.net>)
 id 1nMz3b-0003Dp-GU
 for xen-devel@lists.xenproject.org; Wed, 23 Feb 2022 21:20:19 +0000
Received: from wnew4-smtp.messagingengine.com (wnew4-smtp.messagingengine.com
 [64.147.123.18]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 651bbb6a-94ee-11ec-8539-5f4723681683;
 Wed, 23 Feb 2022 22:20:17 +0100 (CET)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailnew.west.internal (Postfix) with ESMTP id 19BF52B001F4;
 Wed, 23 Feb 2022 16:20:14 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163])
 by compute1.internal (MEProxy); Wed, 23 Feb 2022 16:20:15 -0500
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed,
 23 Feb 2022 16:20:10 -0500 (EST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 651bbb6a-94ee-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-transfer-encoding
	:content-type:date:date:from:from:in-reply-to:message-id
	:mime-version:reply-to:sender:subject:subject:to:to:x-me-proxy
	:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=FgfAeo
	xPVPg0MdvPEZQn4ZDYWo1iiSPBcOv7dVpbcZk=; b=bUT6caj46S8Y5uir73PdHp
	VeSZBsQs2ia89NwbEoWUE5jKz56+1HvcKMM/1Xsok9Wu9Uv2ZV/HQK+EAjwN8ID6
	BB39M2IyVs4stGSP4TGQpviphhzW+pGgOP2t88/SvuoW5ewOw2GGN+6/tOs0HZfb
	lzKPzsz+mnAOLCLetL33TYLnAq+UIzmNVkdr7ZAcQlcvyt/khgC1pd6hjNtUXdev
	DHGk8AekGNQspcmrhH2iX1WAQbI25PhOYOr31Qn1dS+W8AsU9q9nORUgcT2zpOx2
	09hOTMHJulMFQKWK3JGTPGJa60Mw2FrX3hwi81rLy1IwVFb3A47UkV0K9JUFvVSw
	==
X-ME-Sender: <xms:DKUWYrQDmdgl1gpXMU3457DPpHxOUl1wg7J6gGapJ1x9PcmhAexRlA>
    <xme:DKUWYsxnYHws0m4VBnlLmVdJNgglXhp4FNjNWxnsxDuzfXc_qQH3NllqcL6Yxcj3u
    AQGSx0sdU31wQ>
X-ME-Received: <xmr:DKUWYg3SvSGGUK2sYsq46aFBlnA8ZPuSG2Vzh4Eyb724vYl_ihPOFs4dq2-3B9IjEXrZRggSba7uyMaZdAwJfh1k4wQynOD3f70gSzpohGZGm2cFoFY>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrledtgddugeeiucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
    cujfgurhephffvufffkffogggtohfgsehtkeertdertdejnecuhfhrohhmpeforghrvghk
    ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh
    hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeegvdef
    hfdtgfekfeevteekhfeivdeuvdejffeugfegfeffvdeuffevgfeuleetheenucffohhmrg
    hinhepghhithhhuhgsrdgtohhmnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghm
    pehmrghilhhfrhhomhepmhgrrhhmrghrvghksehinhhvihhsihgslhgvthhhihhnghhslh
    grsgdrtghomh
X-ME-Proxy: <xmx:DKUWYrCJaRde3MQNUsM2eZENESX8A3l9HQB4-NSrF5Ut0L3IvOJpYQ>
    <xmx:DKUWYkiEJ5R_OHhlHmL2V4YMRZeerA2w10C07gzVEfkCLBAtow9DtQ>
    <xmx:DKUWYvqe8nh36FCPyaRt8mNUaB1tqjWKMKKAvNwpm-4DH300mYx_iA>
    <xmx:DKUWYtVXaVIq97oididxrnUJGFMTCH8n8pFWDolQ2SbS1TnseyLocA8VNQ8>
From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: linux-kernel@vger.kernel.org
Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>,
	stable@vger.kernel.org,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Antoine Tenart <atenart@kernel.org>,
	xen-devel@lists.xenproject.org (moderated list:XEN HYPERVISOR INTERFACE),
	netdev@vger.kernel.org (open list:NETWORKING DRIVERS)
Subject: [PATCH v2] xen/netfront: destroy queues before real_num_tx_queues is zeroed
Date: Wed, 23 Feb 2022 22:19:54 +0100
Message-Id: <20220223211954.2506824-1-marmarek@invisiblethingslab.com>
X-Mailer: git-send-email 2.31.1
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Organization: Invisible Things Lab
Content-Transfer-Encoding: 8bit

xennet_destroy_queues() relies on info->netdev->real_num_tx_queues to
delete queues. Since d7dac083414eb5bb99a6d2ed53dc2c1b405224e5
("net-sysfs: update the queue counts in the unregistration path"),
unregister_netdev() indirectly sets real_num_tx_queues to 0. Those two
facts together means, that xennet_destroy_queues() called from
xennet_remove() cannot do its job, because it's called after
unregister_netdev(). This results in kfree-ing queues that are still
linked in napi, which ultimately crashes:

    BUG: kernel NULL pointer dereference, address: 0000000000000000
    #PF: supervisor read access in kernel mode
    #PF: error_code(0x0000) - not-present page
    PGD 0 P4D 0
    Oops: 0000 [#1] PREEMPT SMP PTI
    CPU: 1 PID: 52 Comm: xenwatch Tainted: G        W         5.16.10-1.32.fc32.qubes.x86_64+ #226
    RIP: 0010:free_netdev+0xa3/0x1a0
    Code: ff 48 89 df e8 2e e9 00 00 48 8b 43 50 48 8b 08 48 8d b8 a0 fe ff ff 48 8d a9 a0 fe ff ff 49 39 c4 75 26 eb 47 e8 ed c1 66 ff <48> 8b 85 60 01 00 00 48 8d 95 60 01 00 00 48 89 ef 48 2d 60 01 00
    RSP: 0000:ffffc90000bcfd00 EFLAGS: 00010286
    RAX: 0000000000000000 RBX: ffff88800edad000 RCX: 0000000000000000
    RDX: 0000000000000001 RSI: ffffc90000bcfc30 RDI: 00000000ffffffff
    RBP: fffffffffffffea0 R08: 0000000000000000 R09: 0000000000000000
    R10: 0000000000000000 R11: 0000000000000001 R12: ffff88800edad050
    R13: ffff8880065f8f88 R14: 0000000000000000 R15: ffff8880066c6680
    FS:  0000000000000000(0000) GS:ffff8880f3300000(0000) knlGS:0000000000000000
    CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
    CR2: 0000000000000000 CR3: 00000000e998c006 CR4: 00000000003706e0
    Call Trace:
     <TASK>
     xennet_remove+0x13d/0x300 [xen_netfront]
     xenbus_dev_remove+0x6d/0xf0
     __device_release_driver+0x17a/0x240
     device_release_driver+0x24/0x30
     bus_remove_device+0xd8/0x140
     device_del+0x18b/0x410
     ? _raw_spin_unlock+0x16/0x30
     ? klist_iter_exit+0x14/0x20
     ? xenbus_dev_request_and_reply+0x80/0x80
     device_unregister+0x13/0x60
     xenbus_dev_changed+0x18e/0x1f0
     xenwatch_thread+0xc0/0x1a0
     ? do_wait_intr_irq+0xa0/0xa0
     kthread+0x16b/0x190
     ? set_kthread_struct+0x40/0x40
     ret_from_fork+0x22/0x30
     </TASK>

Fix this by calling xennet_destroy_queues() from xennet_uninit(),
when real_num_tx_queues is still available. This ensures that queues are
destroyed when real_num_tx_queues is set to 0, regardless of how
unregister_netdev() was called.

Originally reported at
https://github.com/QubesOS/qubes-issues/issues/7257

Fixes: d7dac083414eb5bb9 ("net-sysfs: update the queue counts in the unregistration path")
Cc: stable@vger.kernel.org
Signed-off-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>

---
Changes in v2:
 - use xennet_uninit, as suggested by Jakub Kicinski
---
 drivers/net/xen-netfront.c | 39 ++++++++++++++++++++++----------------
 1 file changed, 23 insertions(+), 16 deletions(-)

diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
index d514d96027a6..039ca902c5bf 100644
--- a/drivers/net/xen-netfront.c
+++ b/drivers/net/xen-netfront.c
@@ -842,6 +842,28 @@ static int xennet_close(struct net_device *dev)
 	return 0;
 }
 
+static void xennet_destroy_queues(struct netfront_info *info)
+{
+	unsigned int i;
+
+	for (i = 0; i < info->netdev->real_num_tx_queues; i++) {
+		struct netfront_queue *queue = &info->queues[i];
+
+		if (netif_running(info->netdev))
+			napi_disable(&queue->napi);
+		netif_napi_del(&queue->napi);
+	}
+
+	kfree(info->queues);
+	info->queues = NULL;
+}
+
+static void xennet_uninit(struct net_device *dev)
+{
+	struct netfront_info *np = netdev_priv(dev);
+	xennet_destroy_queues(np);
+}
+
 static void xennet_set_rx_rsp_cons(struct netfront_queue *queue, RING_IDX val)
 {
 	unsigned long flags;
@@ -1611,6 +1633,7 @@ static int xennet_xdp(struct net_device *dev, struct netdev_bpf *xdp)
 }
 
 static const struct net_device_ops xennet_netdev_ops = {
+	.ndo_uninit          = xennet_uninit,
 	.ndo_open            = xennet_open,
 	.ndo_stop            = xennet_close,
 	.ndo_start_xmit      = xennet_start_xmit,
@@ -2103,22 +2126,6 @@ static int write_queue_xenstore_keys(struct netfront_queue *queue,
 	return err;
 }
 
-static void xennet_destroy_queues(struct netfront_info *info)
-{
-	unsigned int i;
-
-	for (i = 0; i < info->netdev->real_num_tx_queues; i++) {
-		struct netfront_queue *queue = &info->queues[i];
-
-		if (netif_running(info->netdev))
-			napi_disable(&queue->napi);
-		netif_napi_del(&queue->napi);
-	}
-
-	kfree(info->queues);
-	info->queues = NULL;
-}
-
 
 
 static int xennet_create_page_pool(struct netfront_queue *queue)
-- 
2.31.1



From xen-devel-bounces@lists.xenproject.org Wed Feb 23 22:21:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 23 Feb 2022 22:21:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277812.474650 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nN00K-0000jO-2A; Wed, 23 Feb 2022 22:21:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277812.474650; Wed, 23 Feb 2022 22:21:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nN00J-0000jH-Us; Wed, 23 Feb 2022 22:20:59 +0000
Received: by outflank-mailman (input) for mailman id 277812;
 Wed, 23 Feb 2022 22:20:58 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nN00I-0000j7-Qa; Wed, 23 Feb 2022 22:20:58 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nN00I-0003Ph-O9; Wed, 23 Feb 2022 22:20:58 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nN00I-0008Gm-3l; Wed, 23 Feb 2022 22:20:58 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nN00I-00082e-3H; Wed, 23 Feb 2022 22:20:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=3LdQMyxUf1kY8+PEdiqOlQPya2uEQ6LK4ikUAO6xGTo=; b=ik/t05q4zlTv2IDbWM2NaIfq1q
	g4xOPI1FzY6XDEHErNblpcJTEIE6op2EMeFtqhnzxScsKZDJ0J1kEvswIU9mnwCE2tTwYXL3+uBPO
	1ZkQ+V8LjF6ICxLjgS8msl1NIfAyoiz1sqU89JgZG3dWnMOq9pT6Y2RaRfU3x4tN7g94=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168205-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 168205: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=31e3caf21b6cdf54d11f3744b8b341f07a30b5d7
X-Osstest-Versions-That:
    qemuu=5abccc7922ca5291327b0a1e84ace526d97c633b
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 23 Feb 2022 22:20:58 +0000

flight 168205 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168205/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168199
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168199
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168199
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168199
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168199
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168199
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168199
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168199
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                31e3caf21b6cdf54d11f3744b8b341f07a30b5d7
baseline version:
 qemuu                5abccc7922ca5291327b0a1e84ace526d97c633b

Last test of basis   168199  2022-02-22 22:07:11 Z    1 days
Testing same since   168205  2022-02-23 09:37:25 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Eugenio Pérez <eperezma@redhat.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Jason Wang <jasowang@redhat.com>
  Laurent Vivier <laurent@vivier.eu>
  Laurent Vivier <lvivier@redhat.com>
  Noah Bergbauer <noah@statshelix.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Patrick Venture <venture@google.com>
  Peter Maydell <peter.maydell@linaro.org>
  Philippe Mathieu-Daudé <f4bug@amsat.org>
  Samuel Thibault <samuel.thibault@ens-lyon.org>
  Thomas Huth <thuth@redhat.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   5abccc7922..31e3caf21b  31e3caf21b6cdf54d11f3744b8b341f07a30b5d7 -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Wed Feb 23 22:31:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 23 Feb 2022 22:31:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277825.474660 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nN0Aa-0002H8-4w; Wed, 23 Feb 2022 22:31:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277825.474660; Wed, 23 Feb 2022 22:31:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nN0Aa-0002H1-20; Wed, 23 Feb 2022 22:31:36 +0000
Received: by outflank-mailman (input) for mailman id 277825;
 Wed, 23 Feb 2022 22:31:35 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=gSY2=TG=dingwall.me.uk=james@srs-se1.protection.inumbo.net>)
 id 1nN0AZ-0002Gu-LU
 for xen-devel@lists.xenproject.org; Wed, 23 Feb 2022 22:31:35 +0000
Received: from smarthost01b.ixn.mail.zen.net.uk
 (smarthost01b.ixn.mail.zen.net.uk [212.23.1.21])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 59a0ec8f-94f8-11ec-8eb8-a37418f5ba1a;
 Wed, 23 Feb 2022 23:31:32 +0100 (CET)
Received: from [217.155.64.189] (helo=mail0.xen.dingwall.me.uk)
 by smarthost01b.ixn.mail.zen.net.uk with esmtpsa
 (TLS1.0:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1)
 (envelope-from <james@dingwall.me.uk>) id 1nN0AV-0007ER-IA
 for xen-devel@lists.xenproject.org; Wed, 23 Feb 2022 22:31:31 +0000
Received: from localhost (localhost [IPv6:::1])
 by mail0.xen.dingwall.me.uk (Postfix) with ESMTP id F3F312E32C5
 for <xen-devel@lists.xenproject.org>; Wed, 23 Feb 2022 22:31:30 +0000 (GMT)
Received: from mail0.xen.dingwall.me.uk ([127.0.0.1])
 by localhost (mail0.xen.dingwall.me.uk [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id ECmEUpid7VVP for <xen-devel@lists.xenproject.org>;
 Wed, 23 Feb 2022 22:31:30 +0000 (GMT)
Received: from ghoul.dingwall.me.uk (ghoul.dingwall.me.uk
 [IPv6:2a02:8010:698e:302::c0a8:1c8])
 by dingwall.me.uk (Postfix) with ESMTP id DE85A2E32C0
 for <xen-devel@lists.xenproject.org>; Wed, 23 Feb 2022 22:31:30 +0000 (GMT)
Received: by ghoul.dingwall.me.uk (Postfix, from userid 1000)
 id DB18A72C; Wed, 23 Feb 2022 22:31:30 +0000 (GMT)
Resent-From: James Dingwall <james@dingwall.me.uk>
Resent-Date: Wed, 23 Feb 2022 22:31:30 +0000
Resent-Message-ID: <20220223223130.GB1752541@dingwall.me.uk>
Resent-To: xen-devel@lists.xenproject.org
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 59a0ec8f-94f8-11ec-8eb8-a37418f5ba1a
X-Virus-Scanned: Debian amavisd-new at dingwall.me.uk
Date: Wed, 23 Feb 2022 18:08:59 +0000
From: James Dingwall <james-xen@dingwall.me.uk>
To: xen-devel@lists.xenproject.org
Subject: [RFC] kernel: xenfs parameter to hide deprecated files
Message-ID: <20220223180859.GA1412216@dingwall.me.uk>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="fdj2RfSjLxBAspz7"
Content-Disposition: inline
X-Originating-smarthost01b-IP: [217.155.64.189]
Feedback-ID: 217.155.64.189


--fdj2RfSjLxBAspz7
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Hi,

I have been investigating a very intermittent issue we have with xenstore
access hanging.  Typically it seems to happen when all domains are stopped
prior to a system reboot.  xenstore is running in a stubdom and using the
hypervisor debug keys indicates the domain is still there.

I have come across some old list threads which suggested access via
/proc/xen/xenbus could cause problems but it seems patches went in to the
kernel for 4.10.  However to eliminate this entirely as a possibility
I came up with this kernel patch to hide deprecated entries in xenfs.

I found this old thread for a similar change where the entries were made
conditional on kernel config options instead of a module parameter but
this was never merged.

https://lkml.org/lkml/2015/11/30/761

If this would be a useful feature I would welcome feedback.

Thanks,
James

--fdj2RfSjLxBAspz7
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="xenfs_hide_deprecated.patch"

diff --git a/drivers/xen/xenfs/super.c b/drivers/xen/xenfs/super.c
index d7d64235010d..d02c451f6a4d 100644
--- a/drivers/xen/xenfs/super.c
+++ b/drivers/xen/xenfs/super.c
@@ -3,6 +3,11 @@
  *  xenfs.c - a filesystem for passing info between the a domain and
  *  the hypervisor.
  *
+ * 2022-02-12  James Dingwall   Introduce hide_deprecated module parameter to
+ *                              mask:
+ *                              - xenbus (deprecated in xen 4.6.0)
+ *                              - privcmd (deprecated in xen 4.7.0)
+ *
  * 2008-10-07  Alex Zeffertt    Replaced /proc/xen/xenbus with xenfs filesystem
  *                              and /proc/xen compatibility mount point.
  *                              Turned xenfs into a loadable module.
@@ -28,6 +33,13 @@
 MODULE_DESCRIPTION("Xen filesystem");
 MODULE_LICENSE("GPL");
 
+static bool __read_mostly hide_deprecated = 0;
+module_param(hide_deprecated, bool, 0444);
+MODULE_PARM_DESC(hide_deprecated,
+	"Allow deprecated files to be hidden in xenfs.\n"\
+	"  0 - (default) show deprecated xenfs files."\
+	"  1 - hide deprecated xenfs files [xenbus, privcmd].\n");
+
 static ssize_t capabilities_read(struct file *file, char __user *buf,
 				 size_t size, loff_t *off)
 {
@@ -69,8 +81,32 @@ static int xenfs_fill_super(struct super_block *sb, struct fs_context *fc)
 			xen_initial_domain() ? xenfs_init_files : xenfs_files);
 }
 
+static int xenfs_fill_super_hide_deprecated(struct super_block *sb, struct fs_context *fc)
+{
+	static const struct tree_descr xenfs_files[] = {
+		[2] = { "capabilities", &capabilities_file_ops, S_IRUGO },
+		{""},
+	};
+
+	static const struct tree_descr xenfs_init_files[] = {
+		[2] = { "capabilities", &capabilities_file_ops, S_IRUGO },
+		{ "xsd_kva", &xsd_kva_file_ops, S_IRUSR|S_IWUSR},
+		{ "xsd_port", &xsd_port_file_ops, S_IRUSR|S_IWUSR},
+#ifdef CONFIG_XEN_SYMS
+		{ "xensyms", &xensyms_ops, S_IRUSR},
+#endif
+		{""},
+	};
+
+	return simple_fill_super(sb, XENFS_SUPER_MAGIC,
+			xen_initial_domain() ? xenfs_init_files : xenfs_files);
+}
+
 static int xenfs_get_tree(struct fs_context *fc)
 {
+	if(hide_deprecated)
+		return get_tree_single(fc, xenfs_fill_super_hide_deprecated);
+
 	return get_tree_single(fc, xenfs_fill_super);
 }
 

--fdj2RfSjLxBAspz7--


From xen-devel-bounces@lists.xenproject.org Thu Feb 24 00:24:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 00:24:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277832.474672 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nN1vw-0004w8-Ed; Thu, 24 Feb 2022 00:24:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277832.474672; Thu, 24 Feb 2022 00:24:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nN1vw-0004w1-AE; Thu, 24 Feb 2022 00:24:36 +0000
Received: by outflank-mailman (input) for mailman id 277832;
 Thu, 24 Feb 2022 00:24:35 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nN1vv-0004vr-0x; Thu, 24 Feb 2022 00:24:35 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nN1vu-000681-VT; Thu, 24 Feb 2022 00:24:34 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nN1vu-0004bV-KW; Thu, 24 Feb 2022 00:24:34 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nN1vu-0000Qk-K6; Thu, 24 Feb 2022 00:24:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=y1OFknZsUZUc3wI+MMy/rzSZNL/cmbO/VuK++Dy0hvM=; b=TKcfsThqkOJBOZlg0l8xuVpxR0
	8Ln7qV1t/dPLZtKy+9S8TeqHYZvELoBW47TVt4TTnxVKQVm574f6ZddP6UotywxQBAJuCpDOVXJUN
	xv4wSDu9LfdhkVN960p3fEi24L6+ym35khzjSF2cQ6/iJ3XovnPu8WX8XR16IYnULQVo=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168210-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 168210: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=fe60fab0424b93c6688d285bd7995226a96937d4
X-Osstest-Versions-That:
    xen=f04231775c179b3424fca45d64f29e226a41a610
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 24 Feb 2022 00:24:34 +0000

flight 168210 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168210/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  fe60fab0424b93c6688d285bd7995226a96937d4
baseline version:
 xen                  f04231775c179b3424fca45d64f29e226a41a610

Last test of basis   168208  2022-02-23 17:00:29 Z    0 days
Testing same since   168210  2022-02-23 21:01:36 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   f04231775c..fe60fab042  fe60fab0424b93c6688d285bd7995226a96937d4 -> smoke


From xen-devel-bounces@lists.xenproject.org Thu Feb 24 00:59:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 00:59:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277844.474683 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nN2T8-0008HZ-44; Thu, 24 Feb 2022 00:58:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277844.474683; Thu, 24 Feb 2022 00:58:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nN2T8-0008HS-0f; Thu, 24 Feb 2022 00:58:54 +0000
Received: by outflank-mailman (input) for mailman id 277844;
 Thu, 24 Feb 2022 00:58:53 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=FHEV=TH=oracle.com=boris.ostrovsky@srs-se1.protection.inumbo.net>)
 id 1nN2T6-0008HM-7f
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 00:58:53 +0000
Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com
 [205.220.177.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ec7b9ea4-950c-11ec-8eb8-a37418f5ba1a;
 Thu, 24 Feb 2022 01:58:49 +0100 (CET)
Received: from pps.filterd (m0246630.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 21NNwseF010340; 
 Thu, 24 Feb 2022 00:57:59 GMT
Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80])
 by mx0b-00069f02.pphosted.com with ESMTP id 3ecvar5km5-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 24 Feb 2022 00:57:59 +0000
Received: from pps.filterd (userp3030.oracle.com [127.0.0.1])
 by userp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 21O0jgHX084496;
 Thu, 24 Feb 2022 00:57:58 GMT
Received: from nam10-dm6-obe.outbound.protection.outlook.com
 (mail-dm6nam10lp2108.outbound.protection.outlook.com [104.47.58.108])
 by userp3030.oracle.com with ESMTP id 3eannwnghg-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 24 Feb 2022 00:57:58 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10)
 by SN6PR10MB2815.namprd10.prod.outlook.com (2603:10b6:805:d1::28)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Thu, 24 Feb
 2022 00:57:55 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::6d20:6694:a16:56f7]) by BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::6d20:6694:a16:56f7%3]) with mapi id 15.20.5017.024; Thu, 24 Feb 2022
 00:57:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ec7b9ea4-950c-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date :
 subject : to : cc : references : from : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2021-07-09;
 bh=kjsHYyUGUqhofVt9G6M3BjkWcNnLrpgEeRq0S2D3wC0=;
 b=piKgrJUz+K8Ja+RJ1MwZu4nqzVCRD2bn+YLDjzK1c6rkDGqv8NQmMCo7/lHdz1TSB8lg
 LOKyF0XVV3iPzQ9VPsd32dYv8IWlCePSAN+r1eBJZeJvz422jB7dSgqXngrtctRpq4zU
 DMqfbPRQOBv5dQeSZpyi1dRAewZZ46F0TrN/ym4lzKcD2QlxBRc+go2pf3AGs9ERt/Sc
 /N+9q5ag+f9VhFYh5N+9En/1QI4a0qX4b8F18nWQa2Tx1c0aEbK0gbFY5ci6enJmZXjr
 7v4oXw6NdPDPfWE/bnRnOFNpI82S3O6wEXHcwmINhmRWFwI6uYWFazUoDJatC30YUx9q ww== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=InlK+QGWLbO/KNOqUWZRnIK/wQMZisJ81vRILGTKDCLmdgUllU3WPEM0u0fF9zefBI9GcE6n24f/t8dbGplvtXis37wtas8Az69vYN8uBdLaUYWyYLfVGGislkh10KBMKcs8+AHyWIf9n0dUyGWzBSuWPSTKT6D1cEPW8RjnZ4VZRlt0czuKiEQMNZvOArXCBMY2c3O2Ug8HjTf6b5Mj4dCIhAw7nWeoRmUkRm9NcLyZxXvcVJ2xbFbsrgBqxEQO+EucaqadlL4JQrdgXnNeKGnGXLd8rn6Vui+POEFxsi4GVPS6Kuw9leb1YEmUGdvbG3NksDI7wp5yXOdh+1PBvA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=kjsHYyUGUqhofVt9G6M3BjkWcNnLrpgEeRq0S2D3wC0=;
 b=FJ23ufPoASGS7iQQzMA+GvA8Uw5VTlraxgqt02WkX9bHXImEpWIS4RusTmErVIRX+V/c0hOA5BPVmAWcmoMLJwTIpjDt8+e4DfTWGm1Ihcw8uR2ixDUGTGE3GjOdWLJVhHvGgi4TLF260HyvEMoxHHkyLj7GcmCLTpNNKyMNUPspaOY1zNSH9h3lcfvur84Qloa1+MSET5hgYxmRSRH/QpJRIQj181rLne0y9OO2BznEj0aQUt3eMlIR67WXbpChoRtO87xE/hVfCTIO0zSXpNlumv3dkA+FZkGqWslm0Ik4XuYJDe04PCpiDVtBrfQ4zqnGWE6bk/e8zTGsvVocQw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=kjsHYyUGUqhofVt9G6M3BjkWcNnLrpgEeRq0S2D3wC0=;
 b=UrhESG0LYGJf9Nwtt08/44jyIzTRDyHKNN/gKlpYDM5TQ1GWJRPCl6xBaWMSUJICKAMlvgSbgrRU/4xqjRhFE4vOLs2IJDdwu/MQ+qedZ01XaVgbyyOY04coVgFKrozH8Yd0GJbQOpfFtpZfl0CZU/bjvcpG8eveh621I44a1oI=
Message-ID: <09cb4ad3-88e7-3744-b4b8-a6d745ecea9e@oracle.com>
Date: Wed, 23 Feb 2022 19:57:49 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.1
Subject: Re: cleanup swiotlb initialization
Content-Language: en-US
To: Christoph Hellwig <hch@lst.de>, iommu@lists.linux-foundation.org
Cc: x86@kernel.org, Stefano Stabellini <sstabellini@kernel.org>,
        Juergen Gross <jgross@suse.com>, Joerg Roedel <joro@8bytes.org>,
        David Woodhouse <dwmw2@infradead.org>,
        Lu Baolu <baolu.lu@linux.intel.com>,
        Robin Murphy <robin.murphy@arm.com>,
        linux-arm-kernel@lists.infradead.org, xen-devel@lists.xenproject.org,
        linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org,
        linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org,
        linux-s390@vger.kernel.org, linux-hyperv@vger.kernel.org,
        tboot-devel@lists.sourceforge.net, linux-pci@vger.kernel.org
References: <20220222153514.593231-1-hch@lst.de>
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <20220222153514.593231-1-hch@lst.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: SA0PR12CA0010.namprd12.prod.outlook.com
 (2603:10b6:806:6f::15) To BLAPR10MB5009.namprd10.prod.outlook.com
 (2603:10b6:208:321::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ce6beb6e-deeb-44ea-059b-08d9f730b0c7
X-MS-TrafficTypeDiagnostic: SN6PR10MB2815:EE_
X-Microsoft-Antispam-PRVS: 
	<SN6PR10MB28152A54E63B81D29015FA8F8A3D9@SN6PR10MB2815.namprd10.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	FGzq+TKGdGcDhu9q4HayTzQgtGDKsO5UNbH5NtF76/uFi27aZoiinIYQgPiCfFDC6XqirAkiROpo3XwYgvIP8wozjrrqmpr93oumyIKluaTl0bySY+a99Cavlc6bvPNWJ6hYNURUlQxsqQ1/4qIDUENiJ7+RpU1Pf0eP7KFYkMAtgjS56qQz9thyteOfA4sZNFIFWCskg6pfLUWHcPlH2tkv9cnTdAmXoJlrKluSlvsYkSmv0r5JceHCFOWX5FmjJvcE2nMltZxt/vYN1naPTzY5EOeEDVYUVtyBBw9JaRnM5MZb2D//4toQfhNzttuAoBciU58t3fxearQXXBMvikSjKJhwp2flpPzQHEE8ZjS8vDuurFN/Rxqq+d1PaIh7wOi32lJU2gllIxnMrzQMlL3PdrYU354WvtBHbivxcEkQjBMD+P2C+NECHo2+d2h8JEFHyO/fxenzEjWD++0m+KTpvHUUDo1Vso6U1vPvdQjs3D+aMccdpi1wP+qVXKULvb77fyKSoEdUdQwnulk29J9lCJ4h1eHPsxutWrXOsHTSrd1S9xMCvP410Z1XS6vbYbV+MIZu0wA/sTBUAwNrvztukpF0LY7JEjXs58BL176sWSWBGEtds3MUfCa+VQLbaS+UYKN4EATvMvxOdx9yp/pS10Qc/FSIWx3FYC83pzTJdeMPPop4FrzOlMbcxZW4Iqfe4wHDdZuif8uYOQaaItHBNhHBHCDf6bNyPL9gO41XOgAThLPCbIfiKDjCfYOR
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6506007)(53546011)(36756003)(508600001)(6666004)(45080400002)(2616005)(6486002)(38100700002)(26005)(86362001)(31686004)(316002)(31696002)(83380400001)(54906003)(186003)(6512007)(66476007)(44832011)(66946007)(3480700007)(8936002)(5660300002)(8676002)(4326008)(66556008)(2906002)(7416002)(7116003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?QlNZMTZ2YjAwd28rRjVsSkxiZHErcHpjUFpWNGhWalhQZkxiVkJvNjhwRFFw?=
 =?utf-8?B?KzJ4ZTFsbitOMFBiVEIzdEQ3WkRaYzkzc0xGTXd1eUZ3b2dvY095Vmd3cmJh?=
 =?utf-8?B?Q0JPVGZzckVqSlJ3b1pMbExlNjRyTUJQMXgvREZ2ZklCcW1uK2Y3aXprMXQx?=
 =?utf-8?B?VGRnNDUwN282ckhVZjBUVVFrNVd3bDIrTzFmcFVrbTRVOC81VUdhUk1Yakgr?=
 =?utf-8?B?QXJVcVZRTEVaeWR0U0pZVmI0ckUvYzY0ZHBUWGhSK1M2MmZsa2wrRlFERVQv?=
 =?utf-8?B?VUVzS0RvVk1rRlpsdzQ3eGVVbkE5Z0RwcG85Q3FtZDZHbDJGZjRuVm41K2ZV?=
 =?utf-8?B?R2gvMXUyeGtCaHB0RlZaQ0NCdjZseEY4NWgrUGtlbVJhbmppQ3BybGtYWGM3?=
 =?utf-8?B?ZTl0aDdXc0NzM3JtQndBQ1BlS2xlaHkzQjdJU21Rd29VSUNBdWRWUllFMnNj?=
 =?utf-8?B?RkRWM3FiOFU2eTlLS3ZObVZqUnRoRHRiU1phODVqTjVzTXJiVzQ2UEZvRzBa?=
 =?utf-8?B?UzMwVnZJYTNQMEdSSkIwaXgrUDBMK3hlUzhjT21rTTNjTERpd3ZKNUFDdDNU?=
 =?utf-8?B?Q0J5WURzeGdpdk1UeDVncjZQRmsrckhyTUdTY3RVWXlLcGRNYXhQNzlFTFQ1?=
 =?utf-8?B?NkJKSm8yNXkxdDNRSG9URWljVm1MRGtwVmJrOE1Fd2Jod3YzdnVJN2tKQW14?=
 =?utf-8?B?c1ZWaTF0VXYybXdJUTFzRlhNdE1YRkJ4d1JGOFhLRVNyemdlK2dDQlV5ZlJj?=
 =?utf-8?B?b0dOYVM5VGFwUVNCMGRWVUVxODVaVUx1MEMzMFAyNStuSWFoMGJMeUordklt?=
 =?utf-8?B?S2Z3WEIzVHA0dUc2SFlqRWROUk9mTFVxWHdTdzkrWkpKU25QRmNCNHRuTVZY?=
 =?utf-8?B?MVVCMUNtNHJCOG1wVDlPZ1Z2cExOYWFEUGE0YVdRVUdzUUFvQ3plTERCRFBk?=
 =?utf-8?B?S1QyMjBodTZuMTRTUVAzb29CVEVrNVQzbEhUUjhrUnAwS1RkQjlramNJOGNB?=
 =?utf-8?B?Yzl5Y3cxWnRPcDg3WFJ0TWk3UmxPeEJoYlkxQ0pCOXF5Q3hDNUFreldUVFR6?=
 =?utf-8?B?UEhTZHJMN055NHhEUUdpZlp0SEptczFsZFR4ZHllWk4zWWdvTHJMaVRueHFv?=
 =?utf-8?B?MXFiT1J2dGYxaGxYZlE0MG11Y1BUdW5vNy9MSHdMZzU2Z3pjcENWRGRqa3hM?=
 =?utf-8?B?YUY1YkxzVzMwbm5NUzhmenBVUmUrUGxoZStDTWxIdkNpVTFzSkV2aW05L3lZ?=
 =?utf-8?B?WW9jTmwwaDlkbXJpYmhTS29WYktNSWRuQ3p0dG1hMDV0SFVYOTNWVzdrSUI0?=
 =?utf-8?B?ZVF2TTBORlRpU0tGT2JKTy9YTlhpUitwK0JLV1FrRTlndnEzSXhDUDFYVzdk?=
 =?utf-8?B?dzFGMnZmVStLSDRNMWdCeGZoZDBkeDM5Nk1EdHFHQTlkbm9pMXoxbmlTaS9a?=
 =?utf-8?B?NVVNQXYrbDJvc2M1WjFwRUNjeGljT29TVFZhNGROOVBaT1FOaG9YbTZ0dk4x?=
 =?utf-8?B?NHppV3ZWQlBmZWNHNVNXbHpZSkk2ajJOSktyUysyS1dubDU5SnNTc1hrb0FM?=
 =?utf-8?B?dllvSkhGRWhaaUpaekdYY2I0d0lHV3BueUVqdVpWZFpHNVRyZWJhbUFTakJz?=
 =?utf-8?B?dnpaRU1ZZExlOXZVNnVoNWU5Q2U1TU9YUHJSaTZIWHVuUFJ2K0JOY2hsTEl4?=
 =?utf-8?B?L1I3QXh3RWZQenFvemRQZm1icUVrKzRBdDBVbmtucGx1WWV0MmdvU0IyN0RD?=
 =?utf-8?B?YzhCZ1N4aW82dE9KUThheVVqeWEvVFBGMnlweTRHYmN4OXlidWpPbTIzdXdL?=
 =?utf-8?B?REYzM1NaRzdaZm15dDE0dXJEdmNOT1NvbWxjbEtMODBGS3JOU284bzJOeFVn?=
 =?utf-8?B?U1ltcGlhL2J5WUd2SnZTUVh6MHUrakp5UnJCTkNTYTFhQm54UlQxaUVlcW91?=
 =?utf-8?B?SktLeDR0SXNyaVp1Tyt5WnlIVm9TanNXVHFDT2xQYTJ0cXdHeVp2alIwbVlF?=
 =?utf-8?B?akI0d1J3WWthcnRmTDBxREVhOWVhaElNcFBwckZOV0xuRTRvY29jWkI5WXBY?=
 =?utf-8?B?VTVPVDVBQU1Nbnh5bWhSSk56bHI4T0U1N1ZyaHJtajNEV0dhc3loV3U3UkRD?=
 =?utf-8?B?TFZCUVJoZDgwZmpKcFU3dzQwNmIxNDNJaEk1b0pHUHR5YitnNWlNWDVrL2tq?=
 =?utf-8?B?clgzVzkwZnkrVEIyU3BOejVnd3pLTWFwcStJaUxBbjZpSitxMnpSZFluRVRK?=
 =?utf-8?Q?XnhKan/a00Saat5GnF+5ja5TG5nIIz3g4MVrrXJDAs=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ce6beb6e-deeb-44ea-059b-08d9f730b0c7
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2022 00:57:54.8615
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5KOvD01bFYIaznvbYZcMYEtKGp982/dqKmebzGFd0X3wvF2ppb2np1oeGZg98uq6U1SNviRK/AjzOxFiUL4fOVsVizt/giBEAJad/EDY10I=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR10MB2815
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10267 signatures=681306
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 adultscore=0
 malwarescore=0 phishscore=0 mlxlogscore=856 mlxscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2202240002
X-Proofpoint-GUID: ONDMCBVpPbgmCxR9AdTAk7m45vieR2vz
X-Proofpoint-ORIG-GUID: ONDMCBVpPbgmCxR9AdTAk7m45vieR2vz


On 2/22/22 10:35 AM, Christoph Hellwig wrote:
> Hi all,
>
> this series tries to clean up the swiotlb initialization, including
> that of swiotlb-xen.  To get there is also removes the x86 iommu table
> infrastructure that massively obsfucates the initialization path.
>
> Git tree:
>
>      git://git.infradead.org/users/hch/misc.git swiotlb-init-cleanup


I haven't had a chance to look at this yet but this crashes as dom0:


[   37.377313] BUG: unable to handle page fault for address: ffffc90042880018
[   37.378219] #PF: supervisor read access in kernel mode
[   37.378219] #PF: error_code(0x0000) - not-present page
[   37.378219] PGD 7c2f2ee067 P4D 7c2f2ee067 PUD 7bf019b067 PMD 105a30067 PTE 0
[   37.378219] Oops: 0000 [#1] PREEMPT SMP NOPTI
[   37.378219] CPU: 14 PID: 1 Comm: swapper/0 Not tainted 5.17.0-rc5swiotlb #9
[   37.378219] Hardware name: Oracle Corporation ORACLE SERVER E1-2c/ASY,Generic,SM,E1-2c, BIOS 49004900 12/23/2020
[   37.378219] RIP: e030:init_iommu_one+0x248/0x2f0
[   37.378219] Code: 48 89 43 68 48 85 c0 74 c4 be 00 20 00 00 48 89 df e8 ea ee ff ff 48 89 43 78 48 85 c0 74 ae c6 83 98 00 00 00 00 48 8b 43 38 <48> 8b 40 18 a8 01 74 07 83 8b a8 04 00 00 01 f6 83 a8 04 00 00 01
[   37.378219] RSP: e02b:ffffc9004044bd18 EFLAGS: 00010286
[   37.378219] RAX: ffffc90042880000 RBX: ffff888107260800 RCX: 0000000000000000
[   37.378219] RDX: 0000000080000000 RSI: ffffea00041cab80 RDI: 00000000ffffffff
[   37.378219] RBP: ffffc9004044bd38 R08: 0000000000000901 R09: ffffea00041cab00
[   37.378219] R10: 0000000000000002 R11: 0000000000000000 R12: ffffc90040435008
[   37.378219] R13: 0000000000080000 R14: 00000000efa00000 R15: 0000000000000000
[   37.378219] FS:  0000000000000000(0000) GS:ffff88fef4180000(0000) knlGS:0000000000000000
[   37.378219] CS:  e030 DS: 0000 ES: 0000 CR0: 0000000080050033
[   37.378219] CR2: ffffc90042880018 CR3: 000000000260a000 CR4: 0000000000050660
[   37.378219] Call Trace:
[   37.378219]  <TASK>
[   37.378219]  early_amd_iommu_init+0x3c5/0x72d
[   37.378219]  ? iommu_setup+0x284/0x284
[   37.378219]  state_next+0x158/0x68f
[   37.378219]  ? iommu_setup+0x284/0x284
[   37.378219]  iommu_go_to_state+0x28/0x2d
[   37.378219]  amd_iommu_init+0x15/0x4b
[   37.378219]  ? iommu_setup+0x284/0x284
[   37.378219]  pci_iommu_init+0x12/0x37
[   37.378219]  do_one_initcall+0x48/0x210
[   37.378219]  kernel_init_freeable+0x229/0x28c
[   37.378219]  ? rest_init+0xe0/0xe0
[   37.963966]  kernel_init+0x1a/0x130
[   37.979415]  ret_from_fork+0x22/0x30
[   37.991436]  </TASK>
[   37.999465] Modules linked in:
[   38.007413] CR2: ffffc90042880018
[   38.019416] ---[ end trace 0000000000000000 ]---
[   38.023418] RIP: e030:init_iommu_one+0x248/0x2f0
[   38.023418] Code: 48 89 43 68 48 85 c0 74 c4 be 00 20 00 00 48 89 df e8 ea ee ff ff 48 89 43 78 48 85 c0 74 ae c6 83 98 00 00 00 00 48 8b 43 38 <48> 8b 40 18 a8 01 74 07 83 8b a8 04 00 00 01 f6 83 a8 04 00 00 01
[   38.023418] RSP: e02b:ffffc9004044bd18 EFLAGS: 00010286
[   38.023418] RAX: ffffc90042880000 RBX: ffff888107260800 RCX: 0000000000000000
[   38.155413] RDX: 0000000080000000 RSI: ffffea00041cab80 RDI: 00000000ffffffff
[   38.175965] Freeing initrd memory: 62640K
[   38.155413] RBP: ffffc9004044bd38 R08: 0000000000000901 R09: ffffea00041cab00
[   38.155413] R10: 0000000000000002 R11: 0000000000000000 R12: ffffc90040435008
[   38.155413] R13: 0000000000080000 R14: 00000000efa00000 R15: 0000000000000000
[   38.155413] FS:  0000000000000000(0000) GS:ffff88fef4180000(0000) knlGS:0000000000000000
[   38.287414] CS:  e030 DS: 0000 ES: 0000 CR0: 0000000080050033
[   38.309557] CR2: ffffc90042880018 CR3: 000000000260a000 CR4: 0000000000050660
[   38.332403] Kernel panic - not syncing: Fatal exception
[   38.351414] Rebooting in 20 seconds..



-boris



From xen-devel-bounces@lists.xenproject.org Thu Feb 24 01:30:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 01:30:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277852.474695 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nN2xo-0005yS-Ov; Thu, 24 Feb 2022 01:30:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277852.474695; Thu, 24 Feb 2022 01:30:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nN2xo-0005yL-H3; Thu, 24 Feb 2022 01:30:36 +0000
Received: by outflank-mailman (input) for mailman id 277852;
 Thu, 24 Feb 2022 01:30:34 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=85Ek=TH=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1nN2xm-0005xm-PN
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 01:30:34 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 5add9651-9511-11ec-8539-5f4723681683;
 Thu, 24 Feb 2022 02:30:32 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E279C1063;
 Wed, 23 Feb 2022 17:30:30 -0800 (PST)
Received: from entos-skylake.shanghai.arm.com (entos-skylake.shanghai.arm.com
 [10.169.212.207])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 8671B3F5A1;
 Wed, 23 Feb 2022 17:30:28 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5add9651-9511-11ec-8539-5f4723681683
From: Henry Wang <Henry.Wang@arm.com>
To: xen-devel@lists.xenproject.org,
	sstabellini@kernel.org,
	julien@xen.org
Cc: Bertrand.Marquis@arm.com,
	wei.chen@arm.com,
	penny.zheng@arm.com,
	Henry.Wang@arm.com
Subject: [RFC PATCH 0/2] Introduce reserved Xenheap
Date: Thu, 24 Feb 2022 01:30:21 +0000
Message-Id: <20220224013023.50920-1-Henry.Wang@arm.com>
X-Mailer: git-send-email 2.17.1

The reserved Xenheap, or statically configured Xenheap, refers to parts
of RAM reserved in the beginning for Xenheap. Like the static memory
allocation, such reserved Xenheap regions are reserved by configuration
in the device tree using physical address ranges.

This feature is useful to run Xen on Arm MPU systems, where only a
finite number of memory protection regions are available. The limited
number of protection regions places requirement on planning the use of
MPU protection regions and one or more MPU protection regions needs to
be reserved only for Xenheap.

Therefore, this patch series is sent as RFC for comments from the
community. The first patch introduces the reserved Xenheap and the
device tree processing code. The second patch adds the implementation of
the reserved Xenheap pages handling in boot and heap allocator on Arm64.

Henry Wang (2):
  docs, xen/arm: Introduce reserved Xenheap memory
  xen/arm: Handle reserved Xenheap pages in boot/heap allocator

 docs/misc/arm/device-tree/booting.txt | 43 ++++++++++++++++++++++
 xen/arch/arm/bootfdt.c                | 52 +++++++++++++++++++++------
 xen/arch/arm/include/asm/setup.h      |  3 ++
 xen/arch/arm/setup.c                  | 52 +++++++++++++++++++--------
 4 files changed, 125 insertions(+), 25 deletions(-)

-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Thu Feb 24 01:30:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 01:30:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277853.474704 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nN2xq-0006EQ-2i; Thu, 24 Feb 2022 01:30:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277853.474704; Thu, 24 Feb 2022 01:30:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nN2xp-0006EJ-Uw; Thu, 24 Feb 2022 01:30:37 +0000
Received: by outflank-mailman (input) for mailman id 277853;
 Thu, 24 Feb 2022 01:30:36 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=85Ek=TH=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1nN2xo-0005yB-F8
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 01:30:36 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id 5c91a113-9511-11ec-8eb8-a37418f5ba1a;
 Thu, 24 Feb 2022 02:30:34 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B9A671509;
 Wed, 23 Feb 2022 17:30:33 -0800 (PST)
Received: from entos-skylake.shanghai.arm.com (entos-skylake.shanghai.arm.com
 [10.169.212.207])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 6798D3F5A1;
 Wed, 23 Feb 2022 17:30:31 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5c91a113-9511-11ec-8eb8-a37418f5ba1a
From: Henry Wang <Henry.Wang@arm.com>
To: xen-devel@lists.xenproject.org,
	sstabellini@kernel.org,
	julien@xen.org
Cc: Bertrand.Marquis@arm.com,
	wei.chen@arm.com,
	penny.zheng@arm.com,
	Henry.Wang@arm.com
Subject: [RFC PATCH 1/2] docs, xen/arm: Introduce reserved Xenheap memory
Date: Thu, 24 Feb 2022 01:30:22 +0000
Message-Id: <20220224013023.50920-2-Henry.Wang@arm.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20220224013023.50920-1-Henry.Wang@arm.com>
References: <20220224013023.50920-1-Henry.Wang@arm.com>

This commit introduces the reserved Xenheap memory, which is parts
of RAM reserved in the beginning of the boot time for Xenheap.

A new boolean field `xen_heap` in `struct membank` is added to store
the configuration telling if the memory bank is reserved as Xenheap
through `xen,static-mem` in device tree `chosen` node.

Also, this commit introduces the logic to parse the reserved Xenheap
configuation in device tree by reusing the device tree entry definition
of the static memory allocation feature:

- Add a boolean parameter `xen_heap` to `device_tree_get_meminfo`
to reflect whether the memory bank is reserved as the Xenheap.

- Use `device_tree_get_meminfo` to parse the reserved Xenheap
configuation in `chosen` node of the device tree.

- In order to reuse the function `device_tree_get_meminfo`, the
return type of `process_chosen_node` is changed from void to int.

A documentation section is added, describing the definition of
reserved Xenheap memory and the method of enabling the reserved
Xenheap memory through device tree on AArch64 at boot time.

Signed-off-by: Henry Wang <Henry.Wang@arm.com>
Signed-off-by: Penny Zheng <penny.zheng@arm.com>
---
For reviewers:
The name of the device tree property was chosen because we want to
reuse as much as the device tree parsing helpers from the static
memory allocation feature, but we would like to hear the upstream
reviewers' opinion about if using "xen,static-heap" is better,
although this will add another checking path in `early_scan_node`.
---
 docs/misc/arm/device-tree/booting.txt | 43 +++++++++++++++++++++++
 xen/arch/arm/bootfdt.c                | 50 +++++++++++++++++++++------
 xen/arch/arm/include/asm/setup.h      |  1 +
 3 files changed, 84 insertions(+), 10 deletions(-)

diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt
index a94125394e..c8c4a90bf4 100644
--- a/docs/misc/arm/device-tree/booting.txt
+++ b/docs/misc/arm/device-tree/booting.txt
@@ -355,3 +355,46 @@ device-tree:
 
 This will reserve a 512MB region starting at the host physical address
 0x30000000 to be exclusively used by DomU1.
+
+
+Reserved Xenheap Memory
+=======================
+
+The reserved Xenheap memory (also known as statically configured Xenheap)
+refers to parts of RAM reserved in the beginning for Xenheap. The memory is
+reserved by configuration in the device tree using physical address ranges.
+
+The definition of reserved Xenheap memory in the device tree indicates:
+
+(1) Only the defined reserved memory areas will be used as Xenheap.
+
+(2) The defined reserved heap areas shall always go to the heap allocator
+and only be used as Xenheap.
+
+The reserved Xenheap memory is an optional feature and can be enabled by
+adding a device tree property in the `chosen` node. Currently, this feature
+is only supported on AArch64 and this feature reuses the static memory
+allocation device tree configuration.
+
+The dtb property should look like as follows:
+
+- property name
+
+    "xen,static-mem" (Should be used in the `chosen` node)
+
+- cells
+
+    Specify the start address and the length of the reserved Xenheap memory.
+    The number of cells for the address and the size should be defined
+    using the properties `#xen,static-mem-address-cells` and
+    `#xen,static-mem-size-cells` respectively.
+
+Below is an example on how to specify the reserved Xenheap in device tree:
+
+        chosen {
+                #xen,static-mem-address-cells = <0x2>;
+                #xen,static-mem-size-cells = <0x2>;
+                xen,static-mem = <0x0 0x30000000 0x0 0x40000000>;
+        };
+
+RAM at 0x30000000 of 1G size will be reserved as Xenheap.
diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c
index e318ef9603..cc360cfd07 100644
--- a/xen/arch/arm/bootfdt.c
+++ b/xen/arch/arm/bootfdt.c
@@ -66,7 +66,8 @@ void __init device_tree_get_reg(const __be32 **cell, u32 address_cells,
 static int __init device_tree_get_meminfo(const void *fdt, int node,
                                           const char *prop_name,
                                           u32 address_cells, u32 size_cells,
-                                          void *data, bool xen_domain)
+                                          void *data, bool xen_domain,
+                                          bool xen_heap)
 {
     const struct fdt_property *prop;
     unsigned int i, banks;
@@ -98,6 +99,7 @@ static int __init device_tree_get_meminfo(const void *fdt, int node,
         mem->bank[mem->nr_banks].start = start;
         mem->bank[mem->nr_banks].size = size;
         mem->bank[mem->nr_banks].xen_domain = xen_domain;
+        mem->bank[mem->nr_banks].xen_heap = xen_heap;
         mem->nr_banks++;
     }
 
@@ -187,7 +189,7 @@ static int __init process_memory_node(const void *fdt, int node,
                                       void *data)
 {
     return device_tree_get_meminfo(fdt, node, "reg", address_cells, size_cells,
-                                   data, false);
+                                   data, false, false);
 }
 
 static int __init process_reserved_memory_node(const void *fdt, int node,
@@ -295,7 +297,7 @@ static void __init process_multiboot_node(const void *fdt, int node,
                      kind, start, domU);
 }
 
-static void __init process_chosen_node(const void *fdt, int node,
+static int __init process_chosen_node(const void *fdt, int node,
                                        const char *name,
                                        u32 address_cells, u32 size_cells)
 {
@@ -303,16 +305,41 @@ static void __init process_chosen_node(const void *fdt, int node,
     paddr_t start, end;
     int len;
 
+    printk("Checking for reserved Xenheap in /chosen\n");
+
+    if ( fdt_get_property(fdt, node, "xen,static-mem", NULL) )
+    {
+        u32 address_cells = device_tree_get_u32(fdt, node,
+                                                "#xen,static-mem-address-cells",
+                                                0);
+        u32 size_cells = device_tree_get_u32(fdt, node,
+                                             "#xen,static-mem-size-cells", 0);
+        int rc;
+
+        if ( address_cells < 1 || size_cells < 1 )
+        {
+            printk("fdt: node `%s': invalid #xen,static-mem-address-cells or #xen,static-mem-size-cells\n",
+                   name);
+            return -EINVAL;
+        }
+
+        rc = device_tree_get_meminfo(fdt, node, "xen,static-mem", address_cells,
+                                     size_cells, &bootinfo.reserved_mem, false,
+                                     true);
+        if ( rc )
+            return rc;
+    }
+
     printk("Checking for initrd in /chosen\n");
 
     prop = fdt_get_property(fdt, node, "linux,initrd-start", &len);
     if ( !prop )
         /* No initrd present. */
-        return;
+        return 0;
     if ( len != sizeof(u32) && len != sizeof(u64) )
     {
         printk("linux,initrd-start property has invalid length %d\n", len);
-        return;
+        return -EINVAL;
     }
     start = dt_read_number((void *)&prop->data, dt_size_to_cells(len));
 
@@ -320,12 +347,12 @@ static void __init process_chosen_node(const void *fdt, int node,
     if ( !prop )
     {
         printk("linux,initrd-end not present but -start was\n");
-        return;
+        return -EINVAL;
     }
     if ( len != sizeof(u32) && len != sizeof(u64) )
     {
         printk("linux,initrd-end property has invalid length %d\n", len);
-        return;
+        return -EINVAL;
     }
     end = dt_read_number((void *)&prop->data, dt_size_to_cells(len));
 
@@ -333,12 +360,14 @@ static void __init process_chosen_node(const void *fdt, int node,
     {
         printk("linux,initrd limits invalid: %"PRIpaddr" >= %"PRIpaddr"\n",
                   start, end);
-        return;
+        return -EINVAL;
     }
 
     printk("Initrd %"PRIpaddr"-%"PRIpaddr"\n", start, end);
 
     add_boot_module(BOOTMOD_RAMDISK, start, end-start, false);
+
+    return 0;
 }
 
 static int __init process_domain_node(const void *fdt, int node,
@@ -360,7 +389,8 @@ static int __init process_domain_node(const void *fdt, int node,
                                      "#xen,static-mem-size-cells", 0);
 
     return device_tree_get_meminfo(fdt, node, "xen,static-mem", address_cells,
-                                   size_cells, &bootinfo.reserved_mem, true);
+                                   size_cells, &bootinfo.reserved_mem, true,
+                                   false);
 }
 
 static int __init early_scan_node(const void *fdt,
@@ -380,7 +410,7 @@ static int __init early_scan_node(const void *fdt,
               device_tree_node_compatible(fdt, node, "multiboot,module" )))
         process_multiboot_node(fdt, node, name, address_cells, size_cells);
     else if ( depth == 1 && device_tree_node_matches(fdt, node, "chosen") )
-        process_chosen_node(fdt, node, name, address_cells, size_cells);
+        rc = process_chosen_node(fdt, node, name, address_cells, size_cells);
     else if ( depth == 2 && device_tree_node_compatible(fdt, node, "xen,domain") )
         rc = process_domain_node(fdt, node, name, address_cells, size_cells);
 
diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h
index 7a1e1d6798..188a85c51c 100644
--- a/xen/arch/arm/include/asm/setup.h
+++ b/xen/arch/arm/include/asm/setup.h
@@ -27,6 +27,7 @@ struct membank {
     paddr_t start;
     paddr_t size;
     bool xen_domain; /* whether the memory bank is bound to a Xen domain. */
+    bool xen_heap;   /* whether the memory bank is reserved as Xenheap. */
 };
 
 struct meminfo {
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Thu Feb 24 01:30:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 01:30:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277854.474716 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nN2xr-0006Tj-AR; Thu, 24 Feb 2022 01:30:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277854.474716; Thu, 24 Feb 2022 01:30:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nN2xr-0006T7-6j; Thu, 24 Feb 2022 01:30:39 +0000
Received: by outflank-mailman (input) for mailman id 277854;
 Thu, 24 Feb 2022 01:30:38 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=85Ek=TH=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1nN2xq-0005xm-9N
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 01:30:38 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 5e47312f-9511-11ec-8539-5f4723681683;
 Thu, 24 Feb 2022 02:30:37 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9318E1063;
 Wed, 23 Feb 2022 17:30:36 -0800 (PST)
Received: from entos-skylake.shanghai.arm.com (entos-skylake.shanghai.arm.com
 [10.169.212.207])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 3FF063F5A1;
 Wed, 23 Feb 2022 17:30:34 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5e47312f-9511-11ec-8539-5f4723681683
From: Henry Wang <Henry.Wang@arm.com>
To: xen-devel@lists.xenproject.org,
	sstabellini@kernel.org,
	julien@xen.org
Cc: Bertrand.Marquis@arm.com,
	wei.chen@arm.com,
	penny.zheng@arm.com,
	Henry.Wang@arm.com
Subject: [RFC PATCH 2/2] xen/arm: Handle reserved Xenheap pages in boot/heap allocator
Date: Thu, 24 Feb 2022 01:30:23 +0000
Message-Id: <20220224013023.50920-3-Henry.Wang@arm.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20220224013023.50920-1-Henry.Wang@arm.com>
References: <20220224013023.50920-1-Henry.Wang@arm.com>

This commit firstly adds a global variable `reserved_heap`.
This newly introduced global variable is set at the device tree
parsing time if the reserved Xenheap ranges are defined in the
device tree chosen node.

In `setup_mm`, If the reserved Xenheap is enabled and used, we
make sure that these reserved Xenheap pages are added to the boot
allocator. Otherwise there would be a case that if all available
memory is used for the reserved Xenheap, the boot allocator will
contain zero page at boot time and eventually cause failures.

These reserved Xenheap pages in the boot allocator are added to the
heap allocator at `end_boot_allocator()`.

If the reserved Xenheap is disabled, we stick to the current page
allocation strategy at boot time.

Also, this commit removes some unneeded brackets in `setup_mm`
following the Xen coding style.

Signed-off-by: Henry Wang <Henry.Wang@arm.com>
---
 xen/arch/arm/bootfdt.c           |  2 ++
 xen/arch/arm/include/asm/setup.h |  2 ++
 xen/arch/arm/setup.c             | 52 +++++++++++++++++++++++---------
 3 files changed, 41 insertions(+), 15 deletions(-)

diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c
index cc360cfd07..588f1e3aeb 100644
--- a/xen/arch/arm/bootfdt.c
+++ b/xen/arch/arm/bootfdt.c
@@ -328,6 +328,8 @@ static int __init process_chosen_node(const void *fdt, int node,
                                      true);
         if ( rc )
             return rc;
+
+        reserved_heap = true;
     }
 
     printk("Checking for initrd in /chosen\n");
diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h
index 188a85c51c..fef9d0f378 100644
--- a/xen/arch/arm/include/asm/setup.h
+++ b/xen/arch/arm/include/asm/setup.h
@@ -92,6 +92,8 @@ extern struct bootinfo bootinfo;
 
 extern domid_t max_init_domid;
 
+extern bool reserved_heap;
+
 void copy_from_paddr(void *dst, paddr_t paddr, unsigned long len);
 
 size_t estimate_efi_size(int mem_nr_banks);
diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
index d5d0792ed4..2bb20deac5 100644
--- a/xen/arch/arm/setup.c
+++ b/xen/arch/arm/setup.c
@@ -73,6 +73,8 @@ integer_param("xenheap_megabytes", opt_xenheap_megabytes);
 
 domid_t __read_mostly max_init_domid;
 
+bool reserved_heap;
+
 static __used void init_done(void)
 {
     /* Must be done past setting system_state. */
@@ -772,41 +774,61 @@ static void __init setup_mm(void)
     paddr_t ram_start = ~0;
     paddr_t ram_end = 0;
     paddr_t ram_size = 0;
+    paddr_t bank_start = ~0;
+    paddr_t bank_size = 0;
+    paddr_t bank_end = 0;
     int bank;
 
     init_pdx();
 
+    if ( reserved_heap )
+    {
+        for ( bank = 0 ; bank < bootinfo.reserved_mem.nr_banks; bank++ )
+        {
+            if ( bootinfo.reserved_mem.bank[bank].xen_heap )
+            {
+                bank_start = bootinfo.reserved_mem.bank[bank].start;
+                bank_size = bootinfo.reserved_mem.bank[bank].size;
+                bank_end = bank_start + bank_size;
+
+                init_boot_pages(bank_start, bank_end);
+            }
+        }
+    }
+
     total_pages = 0;
     for ( bank = 0 ; bank < bootinfo.mem.nr_banks; bank++ )
     {
-        paddr_t bank_start = bootinfo.mem.bank[bank].start;
-        paddr_t bank_size = bootinfo.mem.bank[bank].size;
-        paddr_t bank_end = bank_start + bank_size;
         paddr_t s, e;
 
+        bank_start = bootinfo.mem.bank[bank].start;
+        bank_size = bootinfo.mem.bank[bank].size;
+        bank_end = bank_start + bank_size;
+
         ram_size = ram_size + bank_size;
         ram_start = min(ram_start,bank_start);
         ram_end = max(ram_end,bank_end);
 
         setup_xenheap_mappings(bank_start>>PAGE_SHIFT, bank_size>>PAGE_SHIFT);
 
-        s = bank_start;
-        while ( s < bank_end )
+        if ( !reserved_heap )
         {
-            paddr_t n = bank_end;
+            s = bank_start;
+            while ( s < bank_end )
+            {
+                paddr_t n = bank_end;
 
-            e = next_module(s, &n);
+                e = next_module(s, &n);
 
-            if ( e == ~(paddr_t)0 )
-            {
-                e = n = bank_end;
-            }
+                if ( e == ~(paddr_t)0 )
+                    e = n = bank_end;
 
-            if ( e > bank_end )
-                e = bank_end;
+                if ( e > bank_end )
+                    e = bank_end;
 
-            fw_unreserved_regions(s, e, init_boot_pages, 0);
-            s = n;
+                fw_unreserved_regions(s, e, init_boot_pages, 0);
+                s = n;
+            }
         }
     }
 
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Thu Feb 24 01:57:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 01:57:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277875.474727 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nN3NO-0001Gl-AA; Thu, 24 Feb 2022 01:57:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277875.474727; Thu, 24 Feb 2022 01:57:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nN3NO-0001Ge-6e; Thu, 24 Feb 2022 01:57:02 +0000
Received: by outflank-mailman (input) for mailman id 277875;
 Thu, 24 Feb 2022 01:57:01 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nN3NN-0001GU-3x; Thu, 24 Feb 2022 01:57:01 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nN3NM-0000qL-UZ; Thu, 24 Feb 2022 01:57:00 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nN3NM-0001Vr-AT; Thu, 24 Feb 2022 01:57:00 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nN3NM-0000rj-9z; Thu, 24 Feb 2022 01:57:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=5CbWPH3h3qhNm47Bw3MmsMCsQ/umGAHMQ+z/BjV1ECs=; b=MTAim2VkFfKhygI+cD3PgmtjMQ
	qt7+aOohRj0pfmRsiXmG9hZAirq11K65eGP+FAo1cjXBVz2KxY0QRJMyumNvKnrWAkUkjDLbL9TwB
	oZKSKRk2H3GqsXo9RoTNJZOfsQogDN6lTnMyKNM6AdqPpuRLJYzblClAUdgZUINBdLPE=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168206-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-5.4 test] 168206: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-5.4:test-armhf-armhf-xl-rtds:guest-start.2:fail:allowable
    linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=b6e8856b8a5f7fb8b2fc10636aa05cffed1781b9
X-Osstest-Versions-That:
    linux=7b3eb66d0daf61e91cccdb2fe5d271ae5adc5a76
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 24 Feb 2022 01:57:00 +0000

flight 168206 linux-5.4 real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168206/

Failures :-/ but no regressions.

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds     19 guest-start.2            fail REGR. vs. 168130

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168130
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168130
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168130
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168130
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168130
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168130
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168130
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168130
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168130
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168130
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168130
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168130
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                b6e8856b8a5f7fb8b2fc10636aa05cffed1781b9
baseline version:
 linux                7b3eb66d0daf61e91cccdb2fe5d271ae5adc5a76

Last test of basis   168130  2022-02-16 12:13:29 Z    7 days
Testing same since   168206  2022-02-23 11:14:00 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  "Eric W. Biederman" <ebiederm@xmission.com>
  Al Viro <viro@zeniv.linux.org.uk>
  Alex Deucher <alexander.deucher@amd.com>
  Alexander Aring <aahringo@redhat.com>
  Alexandre Belloni <alexandre.belloni@bootlin.com>
  Amit Daniel Kachhap <amit.kachhap@arm.com>
  Anders Roxell <anders.roxell@linaro.org>
  Anna Schumaker <Anna.Schumaker@Netapp.com>
  Arnaldo Carvalho de Melo <acme@redhat.com>
  Benjamin Tissoires <benjamin.tissoires@redhat.com>
  Bjørn Mork <bjorn@mork.no>
  Borislav Petkov <bp@suse.de>
  Brenda Streiff <brenda.streiff@ni.com>
  Bryan O'Donoghue <bryan.odonoghue@linaro.org>
  Chris Leech <cleech@redhat.com>
  Christian Brauner <brauner@kernel.org>
  Christian Eggers <ceggers@arri.de>
  Christian Hewitt <christianshewitt@gmail.com>
  Christian König <christian.koenig@amd.com>
  Christian Loehle <cloehle@hyperstone.com>
  Christian Löhle <CLoehle@hyperstone.com>
  Conor Dooley <conor.dooley@microchip.com>
  Damien Le Moal <damien.lemoal@opensource.wdc.com>
  Darrick J. Wong <djwong@kernel.org>
  david regan <dregan@mail.com>
  David S. Miller <davem@davemloft.net>
  David Sterba <dsterba@suse.com>
  Donald Buczek <buczek@molgen.mpg.de>
  Duoming Zhou <duoming@zju.edu.cn>
  Dāvis Mosāns <davispuh@gmail.com>
  Eliav Farber <farbere@amazon.com>
  Eric Dumazet <edumazet@google.com>
  Eric W. Biederman <ebiederm@xmission.com>
  Florian Fainelli <f.fainelli@gmail.com>
  Florian Westphal <fw@strlen.de>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Guenter Roeck <linux@roeck-us.net>
  Guo Ren <guoren@linux.alibaba.com>
  Hans de Goede <hdegoede@redhat.com>
  Harini Katakam <harini.katakam@xilinx.com>
  Heiko Stuebner <heiko@sntech.de>
  Helge Deller <deller@gmx.de>
  Hulk Robot <hulkrobot@huawei.com>
  Igor Pylypiv <ipylypiv@google.com>
  JaeSang Yoo <js.yoo.5b@gmail.com>
  JaeSang Yoo <jsyoo5b@gmail.com>
  Jakub Kicinski <kuba@kernel.org>
  Jamal Hadi Salim <jhs@mojatatu.com>
  James Smart <jsmart2021@gmail.com>
  Jay Vosburgh <jay.vosburgh@canonical.com>
  Jens Axboe <axboe@kernel.dk>
  Jiasheng Jiang <jiasheng@iscas.ac.cn>
  Jim Mattson <jmattson@google.com>
  Jing Leng <jleng@ambarella.com>
  Johannes Berg <johannes.berg@intel.com>
  John David Anglin <dave.anglin@bell.net>
  Jon Hunter <jonathanh@nvidia.com>
  Josh Poimboeuf <jpoimboe@redhat.com>
  Justin M. Forbes <jforbes@fedoraproject.org>
  Kalle Valo <kvalo@kernel.org>
  Kees Cook <keescook@chromium.org>
  Kees Kook <keescook@chromium.org>
  Laibin Qiu <qiulaibin@huawei.com>
  Leah Rumancik <leah.rumancik@gmail.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Linux Kernel Functional Testing <lkft@linaro.org>
  Luca Coelho <luciano.coelho@intel.com>
  Mans Rullgard <mans@mansr.com>
  Marc St-Amand <mstamand@ciena.com>
  Marc Zyngier <maz@kernel.org>
  Mark Brown <broonie@kernel.org>
  Mark Rutland <mark.rutland@arm.com>
  Martin K. Petersen <martin.petersen@oracle.com>
  Masahiro Yamada <masahiroy@kernel.org>
  Max Kellermann <max.kellermann@ionos.com>
  Miaoqian Lin <linmq006@gmail.com>
  Michael Ellerman <mpe@ellerman.id.au>
  Mickael GARDET <m.gardet@overkiz.com>
  Ming Lei <ming.lei@rehdat.com>
  Miquel Raynal <miquel.raynal@bootlin.com>
  Nathan Chancellor <nathan@kernel.org>
  Neil Armstrong <narmstrong@baylibre.com>
  Nicholas Bishop <nicholasbishop@google.com>
  Nicolas Ferre <nicolas.ferre@microchip.com>
  Nícolas F. R. A. Prado <nfraprado@collabora.com>
  Pablo Neira Ayuso <pablo@netfilter.org>
  Paolo Bonzini <pbonzini@redhat.com>
  Rafał Miłecki <rafal@milecki.pl>
  Randy Dunlap <rdunlap@infradead.org>
  Sagi Grimberg <sagi@grimberg.me>
  Samuel Holland <samuel@sholland.org>
  Sascha Hauer <s.hauer@pengutronix.de>
  Sasha Levin <sashal@kernel.org>
  Sean Christopherson <seanjc@google.com>
  Sergio Costas <rastersoft@gmail.com>
  Seth Forshee <sforshee@digitalocean.com>
  Shuah Khan <skhan@linuxfoundation.org>
  Slade Watkins <slade@sladewatkins.com>
  Slark Xiao <slark_xiao@163.com>
  Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
  Stefan Schmidt <stefan@datenfreihafen.org>
  Steven Rostedt (Google) <rostedt@goodmis.org>
  Steven Rostedt (VMware) <rostedt@goodmis.org>
  Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
  Sudip Mukherjee <sudipm.mukherjee@gmail.com>
  Sven Schnelle <svens@stackframe.org>
  Takashi Iwai <tiwai@suse.de>
  Tejun Heo <tj@kernel.org>
  Theodore Ts'o <tytso@mit.edu>
  Tony Lindgren <tony@atomide.com>
  Torsten Duwe <duwe@suse.de>
  Trond Myklebust <trond.myklebust@hammerspace.com>
  Tudor Ambarus <tudor.ambarus@microchip.com>
  Ulf Hansson <ulf.hansson@linaro.org>
  Valdis Klētnieks <valdis.kletnieks@vt.edu>
  Vinod Koul <vkoul@kernel.org>
  Waiman Long <longman@redhat.com>
  Wan Jiabing <wanjiabing@vivo.com>
  Wei Liu <wei.liu@kernel.org>
  Wolfram Sang <wsa@kernel.org>
  Xin Long <lucien.xin@gmail.com>
  Yang Xu <xuyang2018.jy@fujitsu.com>
  Ye Guojin <ye.guojin@zte.com.cn>
  Zhang Changzhong <zhangchangzhong@huawei.com>
  Zhang Yi <yi.zhang@huawei.com>
  Zoltán Böszörményi <zboszor@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   7b3eb66d0daf..b6e8856b8a5f  b6e8856b8a5f7fb8b2fc10636aa05cffed1781b9 -> tested/linux-5.4


From xen-devel-bounces@lists.xenproject.org Thu Feb 24 03:44:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 03:44:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277888.474738 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nN53U-0003eB-AH; Thu, 24 Feb 2022 03:44:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277888.474738; Thu, 24 Feb 2022 03:44:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nN53U-0003e4-7K; Thu, 24 Feb 2022 03:44:36 +0000
Received: by outflank-mailman (input) for mailman id 277888;
 Thu, 24 Feb 2022 03:44:34 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=wSSe=TH=kernel.org=kuba@srs-se1.protection.inumbo.net>)
 id 1nN53S-0003dy-GN
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 03:44:34 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1246a3f2-9524-11ec-8eb8-a37418f5ba1a;
 Thu, 24 Feb 2022 04:44:32 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id AD986B821B2;
 Thu, 24 Feb 2022 03:44:29 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0EE95C340E9;
 Thu, 24 Feb 2022 03:44:28 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1246a3f2-9524-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1645674268;
	bh=jZ6awLcE6M5IwYTyD00u231l2Hv6lyuBrW+r29jU1AU=;
	h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
	b=InANoN3hy8jAhaH2B3j97Zd8hO6j23VdWyYcfJ9Wsp07n9vZdFBPvgkMSpv6u4jCV
	 xfPjW2tmBsKmRAbyVSDNWHleKvVxbtWB5XL/i9djj0io+zeo0rXe9KPzvgP37/y7Ii
	 hmXRoo2wrXQazsfVWHejRSM/TplI4Qk3/Tu/DXwS8k6Z5uiLopl/4l+zrTbB5tgTcX
	 KckeDPWP5At6RQWXepyTRojXoFjQ22mcOAEL7S4T4/5EBjTjbTngreaeDTg2RGYhpo
	 QXSiNFsOuq1S1/JjueU14B2dynucftb9jssvKCpbbuwEmDIyp09sVSLY08VfzD4IJz
	 YyAUofYAHx3Wg==
Date: Wed, 23 Feb 2022 19:44:26 -0800
From: Jakub Kicinski <kuba@kernel.org>
To: Marek =?UTF-8?B?TWFyY3p5a293c2tpLUfDs3JlY2tp?=
 <marmarek@invisiblethingslab.com>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Michael Brown
 <mcb30@ipxe.org>, Wei Liu <wei.liu@kernel.org>, Paul Durrant
 <paul@xen.org>, "David S. Miller" <davem@davemloft.net>,
 xen-devel@lists.xenproject.org (moderated list:XEN NETWORK BACKEND DRIVER),
 netdev@vger.kernel.org (open list:XEN NETWORK BACKEND DRIVER)
Subject: Re: [PATCH v2 1/2] Revert "xen-netback: remove 'hotplug-status'
 once it has served its purpose"
Message-ID: <20220223194426.6948b28c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <20220222001817.2264967-1-marmarek@invisiblethingslab.com>
References: <20220222001817.2264967-1-marmarek@invisiblethingslab.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Tue, 22 Feb 2022 01:18:16 +0100 Marek Marczykowski-G=C3=B3recki wrote:
> This reverts commit 1f2565780e9b7218cf92c7630130e82dcc0fe9c2.
>=20
> The 'hotplug-status' node should not be removed as long as the vif
> device remains configured. Otherwise the xen-netback would wait for
> re-running the network script even if it was already called (in case of
> the frontent re-connecting). But also, it _should_ be removed when the
> vif device is destroyed (for example when unbinding the driver) -
> otherwise hotplug script would not configure the device whenever it
> re-appear.
>=20
> Moving removal of the 'hotplug-status' node was a workaround for nothing
> calling network script after xen-netback module is reloaded. But when
> vif interface is re-created (on xen-netback unbind/bind for example),
> the script should be called, regardless of who does that - currently
> this case is not handled by the toolstack, and requires manual
> script call. Keeping hotplug-status=3Dconnected to skip the call is wrong
> and leads to not configured interface.
>=20
> More discussion at
> https://lore.kernel.org/xen-devel/afedd7cb-a291-e773-8b0d-4db9b291fa98@ip=
xe.org/T/#u
>=20
> Cc: stable@vger.kernel.org
> Signed-off-by: Marek Marczykowski-G=C3=B3recki <marmarek@invisiblethingsl=
ab.com>

Wei, Paul, do these look good?


From xen-devel-bounces@lists.xenproject.org Thu Feb 24 06:02:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 06:02:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277896.474749 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nN7CR-0000VT-0x; Thu, 24 Feb 2022 06:01:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277896.474749; Thu, 24 Feb 2022 06:01:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nN7CQ-0000VM-Sr; Thu, 24 Feb 2022 06:01:58 +0000
Received: by outflank-mailman (input) for mailman id 277896;
 Thu, 24 Feb 2022 06:01:56 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=qVig=TH=arm.com=Wei.Chen@srs-se1.protection.inumbo.net>)
 id 1nN7CO-0000VG-C9
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 06:01:56 +0000
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur02on060f.outbound.protection.outlook.com
 [2a01:111:f400:fe05::60f])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4303583e-9537-11ec-8eb8-a37418f5ba1a;
 Thu, 24 Feb 2022 07:01:52 +0100 (CET)
Received: from FR3P281CA0059.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::21)
 by DB9PR08MB7220.eurprd08.prod.outlook.com (2603:10a6:10:2bf::20) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.21; Thu, 24 Feb
 2022 06:01:50 +0000
Received: from VE1EUR03FT020.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:d10:4b:cafe::db) by FR3P281CA0059.outlook.office365.com
 (2603:10a6:d10:4b::21) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.9 via Frontend
 Transport; Thu, 24 Feb 2022 06:01:50 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT020.mail.protection.outlook.com (10.152.18.242) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5017.22 via Frontend Transport; Thu, 24 Feb 2022 06:01:49 +0000
Received: ("Tessian outbound 2877e54fe176:v113");
 Thu, 24 Feb 2022 06:01:49 +0000
Received: from c510226caf09.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 E57D2EE4-F221-471F-9754-A9D52FBA74F6.1; 
 Thu, 24 Feb 2022 06:01:43 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c510226caf09.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 24 Feb 2022 06:01:43 +0000
Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9)
 by PR2PR08MB4844.eurprd08.prod.outlook.com (2603:10a6:101:1d::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.21; Thu, 24 Feb
 2022 06:01:41 +0000
Received: from PAXPR08MB7420.eurprd08.prod.outlook.com
 ([fe80::fd0c:a29b:557a:64e1]) by PAXPR08MB7420.eurprd08.prod.outlook.com
 ([fe80::fd0c:a29b:557a:64e1%5]) with mapi id 15.20.4995.027; Thu, 24 Feb 2022
 06:01:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4303583e-9537-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=0zy+sRm7f7bg6N49i7EYVBkY4uR4fCbeK+auPx9SF2k=;
 b=lt0j4+PDKieOA7IQPCvwExTDfXlvcNU6aigbGbztFWVI6/hnnLhxrNQtNrhgwzmmsKTuB9tMLaJcdxGNfW8l7f3HRLSAlqsUwX+5lYEGnR8oeZqIefRr6v95AmG2f/z5DEiKhKH//fWnJXgOrAj3ZCZDsGf8a2JbENYAUBQmJ8k=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gcIS4jzK+WkYEJtKly0ytEBxKtxvjpvYfRp8xUYwI5iuAQFdUpuPUqdrlmiLWcQK12T6fI4s6sJ/rz0nHuM9OBqiUbI6i8ZT3KRwkrb+kvg7yhahUoRGrs9zIyKe/1D2QVE3koeACcGYKlBzXy8xi2tz8wMNTaia4FWXTSekaK2ya8mXL3wNcJd0ODFch1Vp3yVWlUGKKvFZmCcpOqfpV3pyVB1g54AoyV0MCtp+703+1uctNRwO9CWU+uGdFKUA6pEHWSdlx4FVynW0iXjk2auV8z0TQdpmATL7I3C3inn1spiZz7qzOUEE0GQdF8AsCYuoQZJyLmY8fNdMjBU5eA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=0zy+sRm7f7bg6N49i7EYVBkY4uR4fCbeK+auPx9SF2k=;
 b=XqEJsnTzZFatakDq/cklcmKbglLINUqWp3+29oRD/6xVsEooQZMMUSUxTt0+I7gfmogrGfFxf6gv7QpG5QE1hmf649cYNTDI+mJ+i0nCc039rCK2DY/CZ3b1ADsbSM8Y+VnHBla33dBlGfZ4hg/pAco1anpx6qwedbgYfAQOEOWc1Hg1Epf00E3Ut9GXaPx5gzvG7InZlQCmg0cyBZCDgg4oRU+tHq+zcazbsR6/9AzGPz/O9U3F285QY6a09bwYcEa2gOeBPBYlsjfm4dsYt6MZCSGrvmosn6cJyglgJqAvMEetG6HbL5iMc4ulAqNZC+6QnKZGnKNNwy9MG6NSZA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=0zy+sRm7f7bg6N49i7EYVBkY4uR4fCbeK+auPx9SF2k=;
 b=lt0j4+PDKieOA7IQPCvwExTDfXlvcNU6aigbGbztFWVI6/hnnLhxrNQtNrhgwzmmsKTuB9tMLaJcdxGNfW8l7f3HRLSAlqsUwX+5lYEGnR8oeZqIefRr6v95AmG2f/z5DEiKhKH//fWnJXgOrAj3ZCZDsGf8a2JbENYAUBQmJ8k=
From: Wei Chen <Wei.Chen@arm.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"julien@xen.org" <julien@xen.org>, Stefano Stabellini
	<sstabellini@kernel.org>
CC: Bertrand Marquis <Bertrand.Marquis@arm.com>, Penny Zheng
	<Penny.Zheng@arm.com>, Henry Wang <Henry.Wang@arm.com>, nd <nd@arm.com>
Subject: Proposal for Porting Xen to Armv8-R64 - DraftA
Thread-Topic: Proposal for Porting Xen to Armv8-R64 - DraftA
Thread-Index: AdgpQxtXwh7LkfydTgiYk9bhMgU+og==
Date: Thu, 24 Feb 2022 06:01:40 +0000
Message-ID:
 <PAXPR08MB7420A01809B84E04E196793F9E3D9@PAXPR08MB7420.eurprd08.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: BCEB5F1DC7DA0B43BCF65CB127519D1D.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 365374da-553d-40b2-9f80-08d9f75b25b3
x-ms-traffictypediagnostic:
	PR2PR08MB4844:EE_|VE1EUR03FT020:EE_|DB9PR08MB7220:EE_
X-Microsoft-Antispam-PRVS:
	<DB9PR08MB7220F4288084469E21D4EF349E3D9@DB9PR08MB7220.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 aCl9Fd7kIKAUJJy/MC4M1Y1ZiiXXczxmmQ61d5fNjpohRgHwJShRrhKuHrzwjkIzS3WpgkNR5BWQwb+JzUaaLpAkjbKfkNc6fIbn6ODkvTZdLU9YSY6dHjMXdsVgBquJniQ/BGJm88kl/1Bkup8gYgCAm/kX6Rof1CYew3o3qEpKann87ZzD0VQW8uT46DEwfQ1UVGMx7mfGL0/9j42Ea6AgWA9c95JYqHszXBBdaBFkqdItAuVwxgHPCBV+v/5BQ5jhcUpA1KFkuPmrnTPR/k/1MYxqeKUBM2qcOPpg6ilHpD6SvaIkecq3ooxhEJoxgMbuyhblfnvAt0MyQG9vR8Qwt2QN6vzALr11jEW1L4LftAi8oUkoiQgWn/jlBZg7SxLq/FkhVqBGh6veA1wVLlzZBVQ7JpHpxp8fbYYqiJyUr6Ex7EH9NiQN8dM9j6HTTSuuPtPbjHO6i5HDomljuxGJNrSKfCRSITDKW/SZR7TsFNZFfIK3hVosrBYWuMH3svP0wOknaUHst4UK6PW1+iIZVTvh+cOD13OEBQO+2oSz3G+4NkeZ1diYVI/cCI+qOxvH1Scxqa6FxsLpHTL0MU+FVZ5hF/xaWaStry6b14S3A5wKhXvzq8BA2UA7/2TJTLQeOJDOY9s6uQzMfQnb3wR+wHeXNWQSNd0sUCFo9Mza4lEkqoRRrzGCrQGJRGC0k+jMVlxcIFan5RAWZN25KuP3PDFkzz7IQEAp5wEaMmZfQmGBCdF4V/1Jl7qGznEY2EgzpJhrQBgz62JykjO/eR95f8TBG3ef5UbREH7cDBtB1fHPuA7vFMd9BhrdG4PsiEt140lvSUks4tiym35vAQ==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(316002)(26005)(9686003)(186003)(38070700005)(76116006)(66946007)(8676002)(33656002)(66446008)(66476007)(66556008)(64756008)(55016003)(71200400001)(38100700002)(122000001)(4326008)(7696005)(508600001)(6506007)(52536014)(8936002)(5660300002)(2906002)(83380400001)(110136005)(54906003)(86362001)(30864003)(559001)(579004);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR2PR08MB4844
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT020.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	799ad695-0f50-4291-7c6b-08d9f75b2075
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	CQ3yQrfdHU2DUV7o4Tge2IsoMT9EkhBVlXz7G1s05xiL47X59xW4Whn0JdHln4Pu/SPbuZlNp0Y5jCxagG0PnjM+JHSZB1nGPHljt89HB2O15Km6EwHgc+RnUcoIly8vp+N7AE24sjAClKV7AUgXRQEnsu7G1LlERW4OaS8WJPt4/NZgzzLAf62FS5Y3ugbRv28mFEQd/vf/j0REBAQRhN1vytDTh9oP3PEd8f7oGsDxR+vq4h+fDbEfrcSqi3XspFwcBWwJxuZKrsA0ZiC620lYFQnMtfD2DJTNtQw3Bv2go8Eaxkin2BNSR3KvF6dMrafu1mW7XhC6xfPOsT9dqphotHIqEmESZP3wtqoCjCnto1rKoonKfhP3D9aqVSk11eebLYL20WYuQDa7qlz48AcsDgM/Gjfz16dZsP1ubClprG9BnVLAmLVN5zCcFjoI1R13RF9Xup8njTtbXkL5iC+yVFuJ+PIgtgVxsDgKpoVHHz97vOhvWXswn5Ekz1N7pxAvYmTjYHoH6fW959qCNK/1YGKSzXmPzju4AMMP/ohHH6k9zt89vjXLq/gf5z3CLKGIpVUO6pWHCrajyqrPyA7gCkiw+VzLYxBkVxUsNeKjWYoOcVvm6AGudAQkXHlDQvSDEObEDSUfudu5eg/JygNqgv7VY8HW4gw7Jm1toaKNRkbKNDLWFD+t5yD3yiBDoBN1nDw7fAION+fAQVTaepoOzRq448NQaS9pRB9KZcjlybT/8KSfKIXeCs/JgEclI5sSxfPVN/24Owa2nCA76glCZZvShbDt2T+K7pmQsI0=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(33656002)(9686003)(47076005)(55016003)(83380400001)(6506007)(82310400004)(7696005)(508600001)(40460700003)(356005)(70586007)(81166007)(8936002)(54906003)(52536014)(2906002)(316002)(70206006)(8676002)(110136005)(30864003)(5660300002)(86362001)(336012)(186003)(4326008)(26005)(36860700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2022 06:01:49.4843
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 365374da-553d-40b2-9f80-08d9f75b25b3
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT020.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7220

# Proposal for Porting Xen to Armv8-R64

This proposal will introduce the PoC work of porting Xen to Armv8-R64,
which includes:
- The changes of current Xen capability, like Xen build system, memory
  management, domain management, vCPU context switch.
- The expanded Xen capability, like static-allocation and direct-map.

***Notes:***
1. ***This proposal only covers the work of porting Xen to Armv8-R64***
   ***single CPU. Xen SMP support on Armv8-R64 relates to Armv8-R***
   ***Trusted-Frimware (TF-R). This is an external dependency,***
   ***so we think the discussion of Xen SMP support on Armv8-R64***
   ***should be started when single-CPU support is complete.***
2. ***This proposal will not touch xen-tools. In current stage,***
   ***Xen on Armv8-R64 only support dom0less, all guests should***
   ***be booted from device tree.***

## 1. Essential Background

### 1.1. Armv8-R64 Profile
The Armv-R architecture profile was designed to support use cases that
have a high sensitivity to deterministic execution. (e.g. Fuel Injection,
Brake control, Drive trains, Motor control etc)

Arm announced Armv8-R in 2013, it is the latest generation Arm architecture
targeted at the Real-time profile. It introduces virtualization at the high=
est
security level while retaining the Protected Memory System Architecture (PM=
SA)
based on a Memory Protection Unit (MPU). In 2020, Arm announced Cortex-R82,
which is the first Arm 64-bit Cortex-R processor based on Armv8-R64.

- The latest Armv8-R64 document can be found here:
  [Arm Architecture Reference Manual Supplement - Armv8, for Armv8-R AArch6=
4 architecture profile](https://developer.arm.com/documentation/ddi0600/lat=
est/).

- Armv-R Architecture progression:
  Armv7-R -> Armv8-R AArch32 -> Armv8 AArch64
  The following figure is a simple comparison of "R" processors based on
  different Armv-R Architectures.
  ![image](https://drive.google.com/uc?export=3Dview&id=3D1nE5RAXaX8zY2KPZ8=
imBpbvIr2eqBguEB)

- The Armv8-R architecture evolved additional features on top of Armv7-R:
    - An exception model that is compatible with the Armv8-A model
    - Virtualization with support for guest operating systems
        - PMSA virtualization using MPUs In EL2.
- The new features of Armv8-R64 architecture
    - Adds support for the 64-bit A64 instruction set, previously Armv8-R
      only supported A32.
    - Supports up to 48-bit physical addressing, previously up to 32-bit
      addressing was supported.
    - Optional Arm Neon technology and Advanced SIMD
    - Supports three Exception Levels (ELs)
        - Secure EL2 - The Highest Privilege, MPU only, for firmware, hyper=
visor
        - Secure EL1 - RichOS (MMU) or RTOS (MPU)
        - Secure EL0 - Application Workloads
    - Optionally supports Virtual Memory System Architecture at S-EL1/S-EL0=
.
      This means it's possible to run rich OS kernels - like Linux - either
      bare-metal or as a guest.
- Differences with the Armv8-A AArch64 architecture
    - Supports only a single Security state - Secure. There is not Non-Secu=
re
      execution state supported.
    - EL3 is not supported, EL2 is mandatory. This means secure EL2 is the
      highest EL.
    - Supports the A64 ISA instruction
        - With a small set of well-defined differences
    - Provides a PMSA (Protected Memory System Architecture) based
      virtualization model.
        - As opposed to Armv8-A AArch64's VMSA based Virtualization
        - Can support address bits up to 52 if FEAT_LPA is enabled,
          otherwise 48 bits.
        - Determines the access permissions and memory attributes of
          the target PA.
        - Can implement PMSAv8-64 at EL1 and EL2
            - Address translation flat-maps the VA to the PA for EL2 Stage =
1.
            - Address translation flat-maps the VA to the PA for EL1 Stage =
1.
            - Address translation flat-maps the IPA to the PA for EL1 Stage=
 2.
    - PMSA in EL1 & EL2 is configurable, VMSA in EL1 is configurable.

### 1.2. Xen Challenges with PMSA Virtualization
Xen is PMSA unaware Type-1 Hypervisor, it will need modifications to run
with an MPU and host multiple guest OSes.

- No MMU at EL2:
    - No EL2 Stage 1 address translation
        - Xen provides fixed ARM64 virtual memory layout as basis of EL2
          stage 1 address translation, which is not applicable on MPU syste=
m,
          where there is no virtual addressing. As a result, any operation
          involving transition from PA to VA, like ioremap, needs modificat=
ion
          on MPU system.
    - Xen's run-time addresses are the same as the link time addresses.
        - Enable PIC (position-independent code) on a real-time target
          processor probably very rare.
    - Xen will need to use the EL2 MPU memory region descriptors to manage
      access permissions and attributes for accesses made by VMs at EL1/0.
        - Xen currently relies on MMU EL1 stage 2 table to manage these
          accesses.
- No MMU Stage 2 translation at EL1:
    - A guest doesn't have an independent guest physical address space
    - A guest can not reuse the current Intermediate Physical Address
      memory layout
    - A guest uses physical addresses to access memory and devices
    - The MPU at EL2 manages EL1 stage 2 access permissions and attributes
- There are a limited number of MPU protection regions at both EL2 and EL1:
    - Architecturally, the maximum number of protection regions is 256,
      typical implementations have 32.
    - By contrast, Xen does not need to consider the number of page table
      entries in theory when using MMU.
- The MPU protection regions at EL2 need to be shared between the hyperviso=
r
  and the guest stage 2.
    - Requires careful consideration - may impact feature 'fullness' of bot=
h
      the hypervisor and the guest
    - By contrast, when using MMU, Xen has standalone P2M table for guest
      stage 2 accesses.

## 2. Proposed changes of Xen
### **2.1. Changes of build system:**

- ***Introduce new Kconfig options for Armv8-R64***:
  Unlike Armv8-A, because lack of MMU support on Armv8-R64, we may not
  expect one Xen binary to run on all machines. Xen images are not common
  across Armv8-R64 platforms. Xen must be re-built for different Armv8-R64
  platforms. Because these platforms may have different memory layout and
  link address.
    - `ARM64_V8R`:
      This option enables Armv8-R profile for Arm64. Enabling this option
      results in selecting MPU. This Kconfig option is used to gate some
      Armv8-R64 specific code except MPU code, like some code for Armv8-R64
      only system ID registers access.

    - `ARM_MPU`
      This option enables MPU on ARMv8-R architecture. Enabling this option
      results in disabling MMU. This Kconfig option is used to gate some
      ARM_MPU specific code. Once when this Kconfig option has been enabled=
,
      the MMU relate code will not be built for Armv8-R64. The reason why
      not depends on runtime detection to select MMU or MPU is that, we don=
't
      think we can use one image for both Armv8-R64 and Armv8-A64. Another
      reason that we separate MPU and V8R in provision to allow to support =
MPU
      on 32bit Arm one day.

    - `XEN_START_ADDRESS`
      This option allows to set the custom address at which Xen will be
      linked. This address must be aligned to a page size. Xen's run-time
      addresses are the same as the link time addresses. Different platform=
s
      may have differnt memory layout. This Kconfig option provides users
      the ability to select proper link addresses for their boards.
      ***Notes: Fixed link address means the Xen binary could not be***
      ***relocated by EFI loader. So in current stage, Xen could not***
      ***be launched as an EFI application on Armv8-R64.***

    - `ARM_MPU_NORMAL_MEMORY_START` and `ARM_MPU_NORMAL_MEMORY_END`
      `ARM_MPU_DEVICE_MEMORY_START` and `ARM_MPU_DEVICE_MEMORY_END`
      These Kconfig options allow to set memory regions for Xen code, data
      and device memory. Before parsing memory information from device tree=
,
      Xen will use the values that stored in these options to setup boot-ti=
me
      MPU configuration. Why we need a boot-time MPU configuration?
      1. More deterministic: Arm MPU supports background regions,
         if we don't configure the MPU regions and don't enable MPU.
         We can enable MPU background regions. But that means all RAM
         is RWX. Random values in RAM or maliciously embedded data can
         be exploited. Using these Kconfig options allow users to have
         a deterministic RAM area to execute code.
      2. More compatible: On some Armv8-R64 platforms, if the MPU is
         disabled, the `dc zva` instruction will make the system halt.
         And this instruction will be embedded in some built-in functions,
         like `memory set`. If we use `-ddont_use_dc` to rebuild GCC,
         the built-in functions will not contain `dc zva`. However, it is
         obviously unlikely that we will be able to recompile all GCC
         for ARMv8-R64.
      3. One optional idea:
          We can map `XEN_START_ADDRESS` to `XEN_START_ADDRESS + 2MB` or
          `XEN_START_ADDRESS` to `XEN_START_ADDRESS + image_end` for
          MPU normal memory. It's enough to support Xen run in boot time.

- ***Define new system registers for compilers***:
  Armv8-R64 is based on Armv8.4. That means we will use some Armv8.4
  specific system registers. As Armv8-R64 only have secure state, so
  at least, `VSTCR_EL2` and `VSCTLR_EL2` will be used for Xen. And the
  first GCC version that supports Armv8.4 is GCC 8.1. In addition to
  these, PMSA of Armv8-R64 introduced lots of MPU related system registers:
  `PRBAR_ELx`, `PRBARx_ELx`, `PRLAR_ELx`, `PRLARx_ELx`, `PRENR_ELx` and
  `MPUIR_ELx`. But the first GCC version to support these system registers
  is GCC 11. So we have two ways to make compilers to work properly with
  these system registers.
  1. Bump GCC version to GCC 11.
     The pros of this method is that, we don't need to encode these
     system registers in macros by ourselves. But the cons are that,
     we have to update Makefiles to support GCC 11 for Armv8-R64.
     1.1. Check the GCC version 11 for Armv8-R64.
     1.2. Add march=3Darmv8r to CFLAGS for Armv8-R64.
     1.3. Solve the confliction of march=3Darmv8r and mcpu=3Dgeneric
    These changes will affect common Makefiles, not only Arm Makefiles.
    And GCC 11 is new, lots of toolchains and Distro haven't supported it.

  2. Encode new system registers in macros ***(preferred)***
        ```
        /* Virtualization Secure Translation Control Register */
        #define VSTCR_EL2  S3_4_C2_C6_2
        /* Virtualization System Control Register */
        #define VSCTLR_EL2 S3_4_C2_C0_0
        /* EL1 MPU Protection Region Base Address Register encode */
        #define PRBAR_EL1  S3_0_C6_C8_0
        ...
        /* EL2 MPU Protection Region Base Address Register encode */
        #define PRBAR_EL2  S3_4_C6_C8_0
        ...
        ```
     If we encode all above system registers, we don't need to bump GCC
     version. And the common CFLAGS Xen is using still can be applied to
     Armv8-R64. We don't need to modify Makefiles to add specific CFLAGS.

### **2.2. Changes of the initialization process**
In general, we still expect Armv8-R64 and Armv8-A64 to have a consistent
initialization process. In addition to some architecture differences, there
is no more than reusable code that we will distinguish through CONFIG_ARM_M=
PU
or CONFIG_ARM64_V8R. We want most of the initialization code to be reusable
between Armv8-R64 and Armv8-A64.

- We will reuse the original head.s and setup.c of Arm. But replace the
  MMU and page table operations in these files with configuration operation=
s
  for MPU and MPU regions.

- We provide a boot-time MPU configuration. This MPU configuration will
  support Xen to finish its initialization. And this boot-time MPU
  configuration will record the memory regions that will be parsed from
  device tree.

  In the end of Xen initialization, we will use a runtime MPU configuration
  to replace boot-time MPU configuration. The runtime MPU configuration wil=
l
  merge and reorder memory regions to save more MPU regions for guests.
  ![img](https://drive.google.com/uc?export=3Dview&id=3D1wTFyK2XfU3lTlH1PqR=
DoacQVTwUtWIGU)

- Defer system unpausing domain.
  When Xen initialization is about to end, Xen unpause guests created
  during initialization. But this will cause some issues. The unpause
  action occurs before free_init_memory, however the runtime MPU configurat=
ion
  is built after free_init_memory.

  So if the unpaused guests start executing the context switch at this
  point, then its MPU context will base on the boot-time MPU configuration.
  Probably it will be inconsistent with runtime MPU configuration, this
  will cause unexpected problems (This may not happen in a single core
  system, but on SMP systems, this problem is foreseeable, so we hope to
  solve it at the beginning).

### **2.3. Changes to reduce memory fragmentation**

In general, memory in Xen system can be classified to 4 classes:
`image sections`, `heap sections`, `guest RAM`, `boot modules (guest Kernel=
,
initrd and dtb)`

Currently, Xen doesn't have any restriction for users how to allocate
memory for different classes. That means users can place boot modules
anywhere, can reserve Xen heap memory anywhere and can allocate guest
memory anywhere.

In a VMSA system, this would not be too much of a problem, since the
MMU can manage memory at a granularity of 4KB after all. But in a
PMSA system, this will be a big problem. On Armv8-R64, the max MPU
protection regions number has been limited to 256. But in typical
processor implementations, few processors will design more than 32
MPU protection regions. Add in the fact that Xen shares MPU protection
regions with guest's EL1 Stage 2. It becomes even more important
to properly plan the use of MPU protection regions.

- An ideal of memory usage layout restriction:
![img](https://drive.google.com/uc?export=3Dview&id=3D1kirOL0Tx2aAypTtd3kXA=
td75XtrngcnW)
1. Reserve proper MPU regions for Xen image (code, rodata and data + bss).
2. Reserve one MPU region for boot modules.
   That means the placement of all boot modules, include guest kernel,
   initrd and dtb, will be limited to this MPU region protected area.
3. Reserve one or more MPU regions for Xen heap.
   On Armv8-R64, the guest memory is predefined in device tree, it will
   not be allocated from heap. Unlike Armv8-A64, we will not move all
   free memory to heap. We want Xen heap is dertermistic too, so Xen on
   Armv8-R64 also rely on Xen static heap feature. The memory for Xen
   heap will be defined in tree too. Considering that physical memory
   can also be discontinuous, one or more MPU protection regions needs
   to be reserved for Xen HEAP.
4. If we name above used MPU protection regions PART_A, and name left
   MPU protection regions PART_B:
   4.1. In hypervisor context, Xen will map left RAM and devices to PART_B.
        This will give Xen the ability to access whole memory.
   4.2. In guest context, Xen will create EL1 stage 2 mapping in PART_B.
        In this case, Xen just need to update PART_B in context switch,
        but keep PART_A as fixed.

***Notes: Static allocation will be mandatory on MPU based systems***

**A sample device tree of memory layout restriction**:
```
chosen {
    ...
    /*
     * Define a section to place boot modules,
     * all boot modules must be placed in this section.
     */
    mpu,boot-module-section =3D <0x10000000 0x10000000>;
    /*
     * Define a section to cover all guest RAM. All guest RAM must be locat=
ed
     * within this section. The pros is that, in best case, we can only hav=
e
     * one MPU protection region to map all guest RAM for Xen.
     */
    mpu,guest-memory-section =3D <0x20000000 0x30000000>;
    /*
     * Define a memory section that can cover all device memory that
     * will be used in Xen.
     */
    mpu,device-memory-section =3D <0x80000000 0x7ffff000>;
    /* Define a section for Xen heap */
    xen,static-mem =3D <0x50000000 0x20000000>;

    domU1 {
        ...
        #xen,static-mem-address-cells =3D <0x01>;
        #xen,static-mem-size-cells =3D <0x01>;
        /* Statically allocated guest memory, within mpu,guest-memory-secti=
on */
        xen,static-mem =3D <0x30000000 0x1f000000>;

        module@11000000 {
            compatible =3D "multiboot,kernel\0multiboot,module";
            /* Boot module address, within mpu,boot-module-section */
            reg =3D <0x11000000 0x3000000>;
            ...
        };

        module@10FF0000 {
                compatible =3D "multiboot,device-tree\0multiboot,module";
                /* Boot module address, within mpu,boot-module-section */
                reg =3D <0x10ff0000 0x10000>;
                ...
        };
    };
};
```

### **2.4. Changes of memory management**
Xen is coupled with VMSA, in order to port Xen to Armv8-R64, we have to
decouple Xen from VMSA. And give Xen the ability to manage memory in PMSA.

1. ***Use buddy allocator to manage physical pages for PMSA***
   From the view of physical page, PMSA and VMSA don't have any difference.
   So we can reuse buddy allocator on Armv8-R64 to manage physical pages.
   The difference is that, in VMSA, Xen will map allocated pages to virtual
   addresses. But in PMSA, Xen just convert the pages to physical address.

2. ***Can not use virtual address for memory management***
   As Armv8-R64 only has PMSA in EL2, Xen loses the ability of using virtua=
l
   address to manage memory. This brings some problems, some virtual addres=
s
   based features could not work well on Armv8-R64, like `FIXMAP`, `vmap/vu=
map`,
   `ioremap` and `alternative`.

   But the functions or macros of these features are used in lots of common
   code. So it's not good to use `#ifdef CONFIG_ARM_MPU` to gate relate cod=
e
   everywhere. In this case, we propose to use stub helpers to make the cha=
nges
   transparently to common code.
   1. For `FIXMAP`, we will use `0` in `FIXMAP_ADDR` for all fixmap operati=
ons.
      This will return physical address directly of fixmapped item.
   2. For `vmap/vumap`, we will use some empty inline stub helpers:
        ```
        static inline void vm_init_type(...) {}
        static inline void *__vmap(...)
        {
            return NULL;
        }
        static inline void vunmap(const void *va) {}
        static inline void *vmalloc(size_t size)
        {
            return NULL;
        }
        static inline void *vmalloc_xen(size_t size)
        {
            return NULL;
        }
        static inline void vfree(void *va) {}
        ```

   3. For `ioremap`, it depends on `vmap`. As we have make `vmap` to always
      return `NULL`, they could not work well on Armv8-R64 without changes.
      `ioremap` will return input address directly.
        ```
        static inline void *ioremap_attr(...)
        {
            /* We don't have the ability to change input PA cache attribute=
s */
            if ( CACHE_ATTR_need_change )
                return NULL;
            return (void *)pa;
        }
        static inline void __iomem *ioremap_nocache(...)
        {
            return ioremap_attr(start, len, PAGE_HYPERVISOR_NOCACHE);
        }
        static inline void __iomem *ioremap_cache(...)
        {
            return ioremap_attr(start, len, PAGE_HYPERVISOR);
        }
        static inline void __iomem *ioremap_wc(...)
        {
            return ioremap_attr(start, len, PAGE_HYPERVISOR_WC);
        }
        void *ioremap(...)
        {
            return ioremap_attr(pa, len, PAGE_HYPERVISOR_NOCACHE);
        }

        ```
    4. For `alternative`, it depends on `vmap` too. We will simply disable
       it on Armv8-R64 in current stage. How to implement `alternative`
       on Armv8-R64 is better to be discussed after basic functions of Xen
       on Armv8-R64 work well.
       But simply disable `alternative` will make `cpus_have_const_cap` alw=
ays
       return false.
        ```
        * System capability check for constant cap */
        #define cpus_have_const_cap(num) ({                \
               register_t __ret;                           \
                                                           \
               asm volatile (ALTERNATIVE("mov %0, #0",     \
                                         "mov %0, #1",     \
                                         num)              \
                             : "=3Dr" (__ret));              \
                                                           \
                unlikely(__ret);                           \
                })
        ```
        So, before we have an PMSA `alternative` implementation, we have to
        implement a separate `cpus_have_const_cap` for Armv8-R64:
        ```
        #define cpus_have_const_cap(num) cpus_have_cap(num)
        ```

### **2.5. Changes of guest management**
Armv8-R64 only supports PMSA in EL2, but it supports configurable
VMSA or PMSA in EL1. This means Xen will have a new type guest on
Armv8-R64 - MPU based guest.

1. **Add a new domain type - MPU_DOMAIN**
   When user want to create a guest that will be using MPU in EL1, user
   should add a `mpu` property in device tree `domU` node, like following
   example:
    ```
    domU2 {
        compatible =3D "xen,domain";
        direct-map;
        mpu; --> Indicates this domain will use PMSA in EL1.
        ...
    };
    ```
    Corresponding to `mpu` property in device tree, we also need to introdu=
ce
    a new flag `XEN_DOMCTL_CDF_INTERNAL_mpu` for domain to mark itself as a=
n
    MPU domain. This flag will be used in domain creation and domain doing
    vCPU context switch.
    1. Domain creation need this flag to decide enable PMSA or VMSA in EL1.
    2. vCPU context switch need this flag to decide save/restore MMU or MPU
       related registers.

2. **Add MPU registers to vCPU save EL1 MPU context**
   Current Xen only support MMU based guest, so it hasn't considered to
   save/restore MPU context. In this case, we need to add MPU registers
   to `arch_vcpu`:
    ```
    struct arch_vcpu
    {
    #ifdef CONFIG_ARM_MPU
        /* Virtualization Translation Control Register */
        register_t vtcr_el2;

        /* EL1 MPU regions' registers */
        pr_t mpu_regions[CONFIG_ARM_MPU_EL1_PROTECTION_REGIONS];
    #endif
    }
    ```
    Armv8-R64 can support max to 256 MPU regions. But that's just theoretic=
al.
    So we don't want to define `pr_t mpu_regions[256]`, this is a memory wa=
ste
    in most of time. So we decided to let the user specify through a Kconfi=
g
    option. `CONFIG_ARM_MPU_EL1_PROTECTION_REGIONS` default value can be `3=
2`,
    it's a typical implementation on Armv8-R64. Users will recompile Xen wh=
en
    their platform changes. So when the MPU changes, respecifying the MPU
    protection regions number will not cause additional problems.

3. **MPU based P2M table management**
   Armv8-R64 EL2 doesn't have EL1 stage 2 address translation. But through
   PMSA, it still has the ability to control the permissions and attributes
   of EL1 stage 2. In this case, we still hope to keep the interface
   consistent with MMU based P2M as far as possible.

   p2m->root will point to an allocated memory. In Armv8-A64, this memory
   is used to save the EL1 stage 2 translation table. But in Armv8-R64,
   this memory will be used to store EL2 MPU protection regions that are
   used by guest. During domain creation, Xen will prepare the data in
   this memory to make guest can access proper RAM and devices. When the
   guest's vCPU will be scheduled in, this data will be written to MPU
   protection region registers.

### **2.6. Changes of exception trap**
As Armv8-R64 has compatible exception mode with Armv8-A64, so we can reuse =
most
of Armv8-A64's exception trap & handler code. But except the trap based on =
EL1
stage 2 translation abort.

In Armv8-A64, we use `FSC_FLT_TRANS`
```
    case FSC_FLT_TRANS:
        ...
        if ( is_data )
        {
            enum io_state state =3D try_handle_mmio(regs, hsr, gpa);
            ...
        }
```
But for Armv8-R64, we have to use `FSC_FLT_PERM`
```
    case FSC_FLT_PERM:
        ...
        if ( is_data )
        {
            enum io_state state =3D try_handle_mmio(regs, hsr, gpa);
            ...
        }
```

### **2.5. Changes of device driver**
1. Because Armv8-R64 only has single secure state, this will affect some
devices that have two secure state, like GIC. But fortunately, most
vendors will not link a two secure state GIC to Armv8-R64 processors.
Current GIC driver can work well with single secure state GIC for Armv8-R64=
.
2. Xen should use secure hypervisor timer in Secure EL2. We will introduce
a CONFIG_ARM_SECURE_STATE to make Xen to use secure registers for timer.=20

### **2.7. Changes of virtual device**
Currently, we only support pass-through devices in guest. Because event
channel, xen-bus, xen-storage and other advanced Xen features haven't been
enabled in Armv8-R64.

--
Cheers,
Wei Chen



From xen-devel-bounces@lists.xenproject.org Thu Feb 24 07:44:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 07:44:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277905.474759 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nN8nb-0001kI-Kj; Thu, 24 Feb 2022 07:44:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277905.474759; Thu, 24 Feb 2022 07:44:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nN8nb-0001kB-HW; Thu, 24 Feb 2022 07:44:27 +0000
Received: by outflank-mailman (input) for mailman id 277905;
 Thu, 24 Feb 2022 07:44:26 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nN8na-0001k1-E5; Thu, 24 Feb 2022 07:44:26 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nN8na-0007fY-96; Thu, 24 Feb 2022 07:44:26 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nN8nZ-0005vI-Ro; Thu, 24 Feb 2022 07:44:25 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nN8nZ-0000SO-RK; Thu, 24 Feb 2022 07:44:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=xvBjF/l0b8U7IZnTDyCRpaMFry6m/QQKAJQQeNX35kU=; b=6GVKGtqxrY18kNK5ISb0Pjyj9S
	3TpBL7tzuIpT04kif4W0+5sOpvqRLqdMDKA0pExrU0T3X1HljCa/uly4/ifahZGkC2NkMjPcQ79O7
	N/Aa2ZMLc0qBFDl+LnyRUYX8QoFrd0OCO0Vx1q7wpblRMzufjW2HLH7K0Ty263xK3vR8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168209-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 168209: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=23d04328444a8fa0ca060c5e532220dac8e8bc26
X-Osstest-Versions-That:
    linux=5c1ee569660d4a205dced9cb4d0306b907fb7599
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 24 Feb 2022 07:44:25 +0000

flight 168209 linux-linus real [real]
flight 168213 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/168209/
http://logs.test-lab.xenproject.org/osstest/logs/168213/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 168213-retest
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 168213-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168201
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168201
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168201
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168201
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168201
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168201
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168201
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168201
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                23d04328444a8fa0ca060c5e532220dac8e8bc26
baseline version:
 linux                5c1ee569660d4a205dced9cb4d0306b907fb7599

Last test of basis   168201  2022-02-23 03:40:46 Z    1 days
Testing same since   168209  2022-02-23 20:12:18 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  David Rientjes <rientjes@google.com>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Guenter Roeck <linux@roeck-us.net>
  Helge Deller <deller@gmx.de>
  Jon Hunter <jonathanh@nvidia.com>
  Kees Cook <keescook@chromium.org>
  Linus Torvalds <torvalds@linux-foundation.org>
  Linus Walleij <linus.walleij@linaro.org>
  Nick Desaulniers <ndesaulniers@google.com>
  Roman Gushchin <guro@fb.com>
  Vasily Averin <vvs@virtuozzo.com>
  Vikash Chandola <vikash.chandola@linux.intel.com>
  Vlastimil Babka <vbabka@suse.cz>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 fail    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   5c1ee569660d..23d04328444a  23d04328444a8fa0ca060c5e532220dac8e8bc26 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Thu Feb 24 07:54:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 07:54:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277916.474771 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nN8x0-0003FA-Ix; Thu, 24 Feb 2022 07:54:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277916.474771; Thu, 24 Feb 2022 07:54:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nN8x0-0003F3-Fo; Thu, 24 Feb 2022 07:54:10 +0000
Received: by outflank-mailman (input) for mailman id 277916;
 Thu, 24 Feb 2022 07:54:09 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=VLhp=TH=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nN8wz-0003Ev-0n
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 07:54:09 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f1aa89ad-9546-11ec-8539-5f4723681683;
 Thu, 24 Feb 2022 08:54:07 +0100 (CET)
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2053.outbound.protection.outlook.com [104.47.1.53]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-41-uYnziiY-N0mBcRKRSTRsLw-1; Thu, 24 Feb 2022 08:54:06 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DBBPR04MB7546.eurprd04.prod.outlook.com (2603:10a6:10:1f7::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.24; Thu, 24 Feb
 2022 07:54:03 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.024; Thu, 24 Feb 2022
 07:54:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f1aa89ad-9546-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645689247;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=XlB7GjP4r9JbdA3p80n5siQ79+EBx92wRl/zmg2Hfyo=;
	b=d19rPG9s8LuqWG4LCjdE97+uU7u78MfofcdYagMEi28SRYY+meBGa0OcJJvZ+8t8T8VIhK
	NDa7RCbp46cPXSVnYVwlefGBFxujmcvYrlBx70ov4J4CgcWMBemFTTi/N2KB+R8MVivdO6
	hblREgqiQ4R2ubFKlLu+achYeW3VKCo=
X-MC-Unique: uYnziiY-N0mBcRKRSTRsLw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=BeMjWI1RJqkDfvNjUCBgwzldVAczXu07Y71EL6afFqnhVH6CDd6iTtEmQv8wYjygQtLB/ExG7Z2RmWQTJDvPB4XWr7GE1ypjH3C2tm9U75HzKrFb3oPuOWVIeMu5gt4rdD2Zx1OnfRQkSkMGRFG9eFJtb5mNvWn/aJzY+ZeUp5zADK2Es28LtWrg0N/0aElyjDajl06z/+XyfFPkrtzi7FZv1nW3l/9me7mVVrnXpxZCHE6weJwE2c3DmVay5srKLc7toh2wxWLrgJIf9JarUO7nzAxGNmjJAkxwQ8oZtMVh7ijuwRUK8ve5hSFpzFdhjZuVBQVmc9nGxb1/KidwEA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=XlB7GjP4r9JbdA3p80n5siQ79+EBx92wRl/zmg2Hfyo=;
 b=F40pREI1IDhAV6rS99za5djklWR/dVvOo4UI1TtwOMLpZIu8FgsIptbGrRO+FZDV8sclSso+axaY4hBOlmHXEbNKgOe662dU3TSTnBTpP99BVHmOpWQ9DV05q486bv3+3SC+/YujkswAz8qqS4BwkNvfEz5KvAc0WVR4xVH8vfzbJWPOWTAiEjRY3/hsbBgTPvoj21a6jeTOff4YdkNn7AbOP7ZJe0KjGcrO4eAuJ0PpD+lUg3lw9fIYa04mWE9mafEE7Mw0Wvbm8JAyqO3iiyiJ/iN44GBuI5mr5Y1cKOCTNifjCax4WRuCbf5v3LpVy4zK0unJH7b9pNIDjI4KrQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <ab5c32e8-93bb-234f-f38a-1eadbc107d70@suse.com>
Date: Thu, 24 Feb 2022 08:54:01 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH 1/2] x86/p2m: make p2m_get_page_from_gfn() handle grant
 and shared cases better
Content-Language: en-US
To: Tamas K Lengyel <tamas@tklengyel.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>
References: <32526b73-25f7-e6b0-208b-669a7648ee44@suse.com>
 <5a8c1f9e-e91a-a7f5-8c8a-025ab6a39908@suse.com>
 <CABfawh=Eh==cadaQX+n9BzuK5RE=sud7sjLtbAzpp5ouMYGCdQ@mail.gmail.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <CABfawh=Eh==cadaQX+n9BzuK5RE=sud7sjLtbAzpp5ouMYGCdQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0013.eurprd04.prod.outlook.com
 (2603:10a6:20b:310::18) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 04684200-af32-455d-d03b-08d9f76ad2ed
X-MS-TrafficTypeDiagnostic: DBBPR04MB7546:EE_
X-Microsoft-Antispam-PRVS:
	<DBBPR04MB7546FD6072A2C942C75FD49EB33D9@DBBPR04MB7546.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	YLCctp6XTf+3LYHDAohXZ4tAMC4leaTD25z/y2i1n5rS/gHMCiNgLIxKJgHDq7aHooidsxmr178gj2YJJLP37EuKlJJEADPgo2GCiG+VP/Rt/Do7oeiTGPkJRGYWr8GqYL5gm653gWAiL7uK9fRlw4bDGnc3Vz/wdJ111zgd3JF6VJ+jF2fj0EiWXGQulxCWUThVhNc8Q9aNzbyEEz9s1LJaG2Cj4EqwZzLgmEf6eIntrj63DELXfPk2V/JOUesFRaQCyG8yEBBR3biprOcg14GJwWED+s7jt616MbnIUSYPRqnlvTEwCJWGikzLpSle34ieRaH4TKVzfCvfhk9qPEIPLnWBHAzUTaDzTCzLYMZzqchYHvUVHMtaZV4SIbK8twuD8Ecs62fZwyi5hoYRa+RKcdQl1gaOoG53cvyt0CCTr6CfNE3Ny2qeiKx1KvBxOQ6J9wvKlFJwXSgUCKBvafByY5EXbVACGSDJlmvH60kHVcldoOeSjtVIWYgDIchOxh00LlEigN2f4wbLa596QRoR7GWMTBU710q5OOB0DuSyMjKjJ1/c+mFP9/ESZI+xsPl0BTv9yN9NFX2Rlak/Brw+bzpf3oFrU42ehcD4gB5Kq03eNgSZarpfQ3pnBgji0j46j7Hfzp+KXqr96t54KZ1YETbHjMyViDwQ2R5crpUEMieW5JpVezc5H1UCVmNCrOyYhSA6tGSV5SnJ0LEMJ+uJO3MgTYEmL+QIFDXZ1H0=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8676002)(31686004)(86362001)(26005)(36756003)(31696002)(186003)(2616005)(6512007)(38100700002)(6506007)(2906002)(8936002)(6486002)(508600001)(5660300002)(66946007)(66556008)(66476007)(4326008)(53546011)(6916009)(54906003)(316002)(4744005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RkZWUnZZWlJyeXhDL1RJeFVvTkFNS0U1RlNJTjhKbmp2L3duODVnQmNXeXNZ?=
 =?utf-8?B?Y2dvSHZuUjhHVDU5N0N6aFhOelR5NkxjZmhkNnpuQ2ZITm1zN3ZEUU10S0lv?=
 =?utf-8?B?cURmNmVuWEhTNEhxczFCVUNNc25LZTRxbDJmdEpDOE80YXdUSnlTU0J1OWtm?=
 =?utf-8?B?VktOZFpiUmJKU0N1UFRpVkFEZ01EZitVdEhXSUs2TzZnNzg3NDNqVWxKdngz?=
 =?utf-8?B?WWpGYWM0WEZHTnduN3BmZVFmR0dyc2hVbkhYUVREVi9nNmErdU1kYjM0OVJJ?=
 =?utf-8?B?RVVqS0xWVnA5Qm1Ncml2M3RpbVY4Qk5vVzdNYXZrVFRBVFFDNkxtakVPMlA1?=
 =?utf-8?B?WXlxYlhvcy9Jd1djTDFkMFNpVmNoZ0RQTUpOT2pvNkN2WSs3VVc0OE9lTW1k?=
 =?utf-8?B?VjFUT3cvaWtGdjJqb2F4TFp2RkZjaExwNk1ZMnpvLy9mRjRpR1ZoQkdVOFN0?=
 =?utf-8?B?NXlBNC9BYk56NzdpZTNYelJrM3pKanZ0SHh4KzFwOW9CcE5GdzlMZVlvaG9B?=
 =?utf-8?B?Ukk1SkdhK0duSWRkaUdlSXVhQ0wyMThFTldEZk0yS3FPR1RlYUNGRWpQSFZ5?=
 =?utf-8?B?Z2NnQWVHTU8xMitTN0lmZnpsZWNJVndjY2lxc0JMSnhlS3NsRldXa1pQeFBM?=
 =?utf-8?B?Q05FSStYRnZnSEJlWUYrb3luS2NMSE15MTYyQjdFRVdPR3RJOGU5WWYreWND?=
 =?utf-8?B?aEJvYklKa2V4S213S1ArVVRnWFJETW9Uc0lpTGVYOU9zcGF0eUZHbE0wMVU2?=
 =?utf-8?B?K08vQUpJT1NlVUhRTWNLanYrcjR5S01CbmFVREJuT1NHRXZuZG5JOEFZcFM2?=
 =?utf-8?B?dStacy9TclhhU3JPcWI2djljWjdLRnk2Q1hhTUlxY1pFTG8relkwc3hzd2Uw?=
 =?utf-8?B?QnlhcjlyUDVFenRIeVNWWjZXeG5tbjRwamVNUEJDcXBrSTRNdGw5RUlpOVhj?=
 =?utf-8?B?dWlvUWwyUkt3M2ZZU3FkSWg0N0RHZFRxTG1VZmFuRUFvc1JOS3ZYR1o3OXNp?=
 =?utf-8?B?TlBGS0ZZMVM0WmdGNGNCUWh1MjY0b05IY05TNFdkUUdyY3BCNDlNOHVldktB?=
 =?utf-8?B?NnhreTFQMjR6UEltNGo5d1VWc3BqZVcwTERxTDlqM1lwRWI0V0MvLy9nM2Vz?=
 =?utf-8?B?WHpIaXdTNXJYOWF2WTNMOStmbDM3ZTh2Wkd6R1lBNUFPeXhtL2p0TlhGNmNH?=
 =?utf-8?B?QXduMHBVajJOWFhSU0NOMlFwZndERDlBczMyVUJST2NCSnhRbE9FMlNqeVFO?=
 =?utf-8?B?bk1DdU5zRTlldnJISGxZSC8yd3Y0SkhjUGtGNi9UVk45bjEwalEwbEZJRXk3?=
 =?utf-8?B?VFUzTTRBRkNaSFd1OUdHU1V3QWtJdE1iUURlSzU4V1FHOEZKb0dvai9tTTd2?=
 =?utf-8?B?V1BaZDB1OElkK0lmR2dLUkN4cjdzVUFEQWxWUDhFMGZwQkw0VklKT0hUSVBL?=
 =?utf-8?B?Q24vTDIwYVYrWmR4b0NZajJlVStvV0FtMjJIbS9mNDJwZ0NPc3FYaGtzNENQ?=
 =?utf-8?B?elkzeXdHTmkzZWU2U2M3RjZqSVhqUFhiNWhGWUdWc1d0TEU4czMrVDBwTEdY?=
 =?utf-8?B?c0grYVdrcnNSck5MVXhlbkNoNTRzQ2kxdXM3cEZrdjdHOTAwN0tVSk42UlZi?=
 =?utf-8?B?aVdMZDlsUnlUTXZCNnkvWnpSd01pbzRkNWF2U3VWcDE4d3M5ZHcyazV1ckMr?=
 =?utf-8?B?bWFlQUNNNUxFNllhK1cyeEFsbFlTNVlBOEdVek0vUk1Uck9HRUtIZTI4ZFlp?=
 =?utf-8?B?aFBsU2UrQlgvM3MyNHE1ODJFcUZVYkpvUXJBRzBIK2ovajFmR1JkMEFOcnNR?=
 =?utf-8?B?RTdmTmx2d3hXeVc5cEtZN2hIZUVrMDA4SEVwdGlTeEZLQ3lRUVFrSWdvaFJF?=
 =?utf-8?B?OEltaUFEL3FiaC9xb3dYV3k4dlZXMy9DTDU1UkwyTkFWTU9WSFdIQy80RWtv?=
 =?utf-8?B?TmpZdWhQQ01ma21BZDN2VVQ5NmhSYTJkMGJiMTdPRFY4bmdZclhHU3VaQmlm?=
 =?utf-8?B?R052bmJYT3VNWjJnWXNpdUFDc1owdTFkOGpKM0kxZG1pRFR5WWJaaU16RzF5?=
 =?utf-8?B?OUVTd3NjcDdmemhQQXcxa3VEdlN6UmZvSUtqQWtFbnMzQ2l0bXZoM1FMcVpC?=
 =?utf-8?B?WTlzZXhTZVBmdks0OE42MnBQdEMwTTBqL0hmRGt6b0dSaGU0Yk90TDcvT2Jy?=
 =?utf-8?Q?dNaYZDg5wgVSpc8wpmXK1RU=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 04684200-af32-455d-d03b-08d9f76ad2ed
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2022 07:54:02.8749
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: b8RFfF9JcmRrGFq/PLcXh6qfBV7TBsB5CikDBqPIO0CU6tirr6W0bx+l5OyqZM811QSWTDwlbmcIEz582aQU6g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7546

On 23.02.2022 19:11, Tamas K Lengyel wrote:
>> @@ -607,6 +607,7 @@ struct page_info *p2m_get_page_from_gfn(
>>
>>          /* Error path: not a suitable GFN at all */
>>          if ( !p2m_is_ram(*t) && !p2m_is_paging(*t) && !p2m_is_pod(*t) &&
>> +             (!p2m_is_shared(*t) || !(q & P2M_UNSHARE)) &&
>>               !mem_sharing_is_fork(p2m->domain) )
>>              return NULL;
>>      }
> 
> I don't follow what this is fixing. A shared entry would return true
> to p2m_is_ram() - p2m_ram_shared is listed under P2M_RAM_TYPES - so
> the rest of the if statement would never be checked. So if we get past
> that check we know we definitely don't have a shared entry, ie
> p2m_is_shared must be false ie the check for P2M_UNSHARE is dead code.
> Am I missing something?

No, I am. I mistakenly took p2m_is_any_ram() to include the shared case,
but p2m_is_ram() to not do so. Thanks for pointing out, and I'm actually
happy to be able to droop this hunk.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Feb 24 07:54:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 07:54:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277917.474782 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nN8xA-0003YY-RR; Thu, 24 Feb 2022 07:54:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277917.474782; Thu, 24 Feb 2022 07:54:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nN8xA-0003YR-NN; Thu, 24 Feb 2022 07:54:20 +0000
Received: by outflank-mailman (input) for mailman id 277917;
 Thu, 24 Feb 2022 07:54:19 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=bEeT=TH=gmail.com=xadimgnik@srs-se1.protection.inumbo.net>)
 id 1nN8x8-0003XH-VT
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 07:54:19 +0000
Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com
 [2a00:1450:4864:20::42f])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f7724bf7-9546-11ec-8eb8-a37418f5ba1a;
 Thu, 24 Feb 2022 08:54:17 +0100 (CET)
Received: by mail-wr1-x42f.google.com with SMTP id s13so1618065wrb.6
 for <xen-devel@lists.xenproject.org>; Wed, 23 Feb 2022 23:54:17 -0800 (PST)
Received: from ?IPV6:2a00:23c5:5785:9a01:b013:cd66:72b0:92c8?
 ([2a00:23c5:5785:9a01:b013:cd66:72b0:92c8])
 by smtp.gmail.com with ESMTPSA id v7sm591707wrr.41.2022.02.23.23.54.16
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Wed, 23 Feb 2022 23:54:16 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f7724bf7-9546-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=message-id:date:mime-version:user-agent:reply-to:subject
         :content-language:to:cc:references:from:in-reply-to
         :content-transfer-encoding;
        bh=P/QdCt/Tgr1NhGv8Wt2qx0d+ksy5gHYVcGOQ9sIcJi4=;
        b=FC1gu07hwptBvAiJyvyQlIWguTtl6iYIN+0yCgXNTS8HoKUXnb0lI7ElLjogLeRCrJ
         nyyndEgk+C2pAA1WJTMmQluBDA7+WKtQYmpr+7PVQffjR+HSjvY5W5xN/ubBgu2JuT6k
         fnvE2+w0d8dirZbj1nl2o9Xe4ZQ6/lfFmmV3nrvfOQaQ0Hy6+3GxjD4yTNSs7lv/FECs
         /sZ6jQj7Cb3dCNq/dxlZrW77WfG9jNlC/t8oWdrGTimv80iIHkh015FByHVRFiVEK7i+
         LBolPGJrQdcUswi/xfW9kC5Cb+O9fxLZdwU8hjKG7tAvaE5PwU3YZRC4t7NyIwtScsgT
         fZgQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:message-id:date:mime-version:user-agent:reply-to
         :subject:content-language:to:cc:references:from:in-reply-to
         :content-transfer-encoding;
        bh=P/QdCt/Tgr1NhGv8Wt2qx0d+ksy5gHYVcGOQ9sIcJi4=;
        b=S1BjQQZEsLb8lUTi7KPvq+lCaNYPCds0aATc6AhAvMTzssYv4sacFULDTw8ZSjzAh+
         h8vtiCGdS7bEQKwP45IN7tIB/U0Gmi8bXUvYRRU8suMtSO4cyj9k5nQOxFOWAcQGXF2g
         9elcn4kt2E+o4YVwoDzm1doW7y9vkIlIP227m/n+mmNsS7xXiVa0V+n1530C/DKTxmjB
         wkV0Z49GzxaQpkNNrWUWZwE0Jnj4cT/257TN5I/P1T0kLV54mvtnze9VDUvg0BTMKRHM
         nKFmrD3plSFzOp8iZoDREptPWRxD2YB8VDeAjn5f25GEpvc1/8rSc2AuuKlp04wy3epb
         fcCQ==
X-Gm-Message-State: AOAM530p782+N/VifEqzpQf9Z8a7XJLqoxxtqLHOVGRn0TY2GUjBHrZv
	teEhE38ij65pol9bHcytZaA=
X-Google-Smtp-Source: ABdhPJy1SdIn3EKk8TBCGbyeJk5RfTnMOzot3SLzXajRYRUsTBYg6N0saeU2O/sDUJjf2kIWIm0WTg==
X-Received: by 2002:a5d:64c6:0:b0:1e8:ee04:e8fb with SMTP id f6-20020a5d64c6000000b001e8ee04e8fbmr1172924wri.518.1645689256968;
        Wed, 23 Feb 2022 23:54:16 -0800 (PST)
Message-ID: <dae477f8-1593-4eda-adb1-fa6845e5f993@gmail.com>
Date: Thu, 24 Feb 2022 07:54:15 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Reply-To: paul@xen.org
Subject: Re: [PATCH v2 1/2] Revert "xen-netback: remove 'hotplug-status' once
 it has served its purpose"
Content-Language: en-US
To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>, linux-kernel@vger.kernel.org
Cc: stable@vger.kernel.org, Michael Brown <mcb30@ipxe.org>,
 Wei Liu <wei.liu@kernel.org>, Paul Durrant <paul@xen.org>,
 "David S. Miller" <davem@davemloft.net>, Jakub Kicinski <kuba@kernel.org>,
 "moderated list:XEN NETWORK BACKEND DRIVER"
 <xen-devel@lists.xenproject.org>,
 "open list:XEN NETWORK BACKEND DRIVER" <netdev@vger.kernel.org>
References: <20220222001817.2264967-1-marmarek@invisiblethingslab.com>
From: "Durrant, Paul" <xadimgnik@gmail.com>
In-Reply-To: <20220222001817.2264967-1-marmarek@invisiblethingslab.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 22/02/2022 00:18, Marek Marczykowski-Górecki wrote:
> This reverts commit 1f2565780e9b7218cf92c7630130e82dcc0fe9c2.
> 
> The 'hotplug-status' node should not be removed as long as the vif
> device remains configured. Otherwise the xen-netback would wait for
> re-running the network script even if it was already called (in case of
> the frontent re-connecting). But also, it _should_ be removed when the
> vif device is destroyed (for example when unbinding the driver) -
> otherwise hotplug script would not configure the device whenever it
> re-appear.
> 
> Moving removal of the 'hotplug-status' node was a workaround for nothing
> calling network script after xen-netback module is reloaded. But when
> vif interface is re-created (on xen-netback unbind/bind for example),
> the script should be called, regardless of who does that - currently
> this case is not handled by the toolstack, and requires manual
> script call. Keeping hotplug-status=connected to skip the call is wrong
> and leads to not configured interface.
> 
> More discussion at
> https://lore.kernel.org/xen-devel/afedd7cb-a291-e773-8b0d-4db9b291fa98@ipxe.org/T/#u
> 
> Cc: stable@vger.kernel.org
> Signed-off-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>

Reviewed-by: Paul Durrant <paul@xen.org>


From xen-devel-bounces@lists.xenproject.org Thu Feb 24 07:56:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 07:56:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277932.474792 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nN8z8-0004XS-Au; Thu, 24 Feb 2022 07:56:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277932.474792; Thu, 24 Feb 2022 07:56:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nN8z8-0004XL-7z; Thu, 24 Feb 2022 07:56:22 +0000
Received: by outflank-mailman (input) for mailman id 277932;
 Thu, 24 Feb 2022 07:56:21 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=bEeT=TH=gmail.com=xadimgnik@srs-se1.protection.inumbo.net>)
 id 1nN8z7-0004XA-D9
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 07:56:21 +0000
Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com
 [2a00:1450:4864:20::432])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 40b8cbe6-9547-11ec-8eb8-a37418f5ba1a;
 Thu, 24 Feb 2022 08:56:20 +0100 (CET)
Received: by mail-wr1-x432.google.com with SMTP id n14so1252945wrq.7
 for <xen-devel@lists.xenproject.org>; Wed, 23 Feb 2022 23:56:20 -0800 (PST)
Received: from ?IPV6:2a00:23c5:5785:9a01:b013:cd66:72b0:92c8?
 ([2a00:23c5:5785:9a01:b013:cd66:72b0:92c8])
 by smtp.gmail.com with ESMTPSA id x14sm2352487wru.0.2022.02.23.23.56.19
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Wed, 23 Feb 2022 23:56:19 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 40b8cbe6-9547-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=message-id:date:mime-version:user-agent:reply-to:subject
         :content-language:to:cc:references:from:in-reply-to
         :content-transfer-encoding;
        bh=75MxyoNLX+jup+3IZc6uzyBIvH5fg0GcSMBv0gLbqp0=;
        b=H/k93g5NLzzNzoxwKfe8LDJebraiMpZshak6/6jcSf6DsqkHkkV04+FC8w+9g4X5O4
         i67rWmn6FZzAaPLQOfopBkul41ZHkuq00QhdDDMqGX8M3JlCV3a8Y1rd7cCQ36tnAWDm
         2PCOHNQgY19f9sETQeDKCUzMKN8iGa9AmkvQbdtzTRhT1y3hqXhY6Ov+grh4i6snLmy9
         YZ4Zp4zMStYeQQvxHizbceIgiugE+u93IalzdR1zeea2lDN+nvICdisUCtxCH2HFrFXg
         SMijirS44Gbqxa7cfV1p1qlGwE4HtKgVkBegRQXpPSjp1enh1CnANa4XgIpVHZjHSPDg
         itqw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:message-id:date:mime-version:user-agent:reply-to
         :subject:content-language:to:cc:references:from:in-reply-to
         :content-transfer-encoding;
        bh=75MxyoNLX+jup+3IZc6uzyBIvH5fg0GcSMBv0gLbqp0=;
        b=FtZ/bhluh/pH56OjBS4Tu+ugSTFMKWc07qIyo4M3oc2l11eEc69xSM2MO2S2umA6hW
         k7einVD15PyqA+tCZngqDnMKiImcGg0pL9yL//ZOJFATwxcDTOgR11O+dYDHPWu1WloS
         8Y9zAL4tUonBsrfEp/GGCTW4bD14SDtIMCYkabJfaA2+Od8KATwvwDljedLGcNzjmjKg
         VL9+f/1pceYUgeksdJJe1WVQUaPi98eqActlguewA+O8x0sNMLDHXw0JrgrLQFwPr3oQ
         JC8jBqUHJdT+U42eEOAaGNUEs796SK2JGoWhgocaDPyzKsucqbmtECr263BNa/xZrU9v
         9DXg==
X-Gm-Message-State: AOAM530JZ1LRcWgCYbu6JHr8aJr8gczN0JnlRnBbpqk0xTw07aWO9VhC
	CFpZC6vmTj0ROIgnjjGiVyn1kBrE6/e2Lg==
X-Google-Smtp-Source: ABdhPJyx+djfyMcrNLUFaHnhzbfJAxxXHv1T/rgX4SDnFbAEIFbr1U7OG74bMhel4A/hupIb0z20qw==
X-Received: by 2002:a05:6000:18ad:b0:1e8:cbe1:afd with SMTP id b13-20020a05600018ad00b001e8cbe10afdmr1188474wri.352.1645689380036;
        Wed, 23 Feb 2022 23:56:20 -0800 (PST)
Message-ID: <d9969551-77ca-fda7-b30a-da5d9e1dfcd6@gmail.com>
Date: Thu, 24 Feb 2022 07:56:18 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Reply-To: paul@xen.org
Subject: Re: [PATCH v2 2/2] Revert "xen-netback: Check for hotplug-status
 existence before watching"
Content-Language: en-US
To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>, linux-kernel@vger.kernel.org
Cc: stable@vger.kernel.org, Michael Brown <mcb30@ipxe.org>,
 Wei Liu <wei.liu@kernel.org>, Paul Durrant <paul@xen.org>,
 "David S. Miller" <davem@davemloft.net>, Jakub Kicinski <kuba@kernel.org>,
 "moderated list:XEN NETWORK BACKEND DRIVER"
 <xen-devel@lists.xenproject.org>,
 "open list:XEN NETWORK BACKEND DRIVER" <netdev@vger.kernel.org>
References: <20220222001817.2264967-1-marmarek@invisiblethingslab.com>
 <20220222001817.2264967-2-marmarek@invisiblethingslab.com>
From: "Durrant, Paul" <xadimgnik@gmail.com>
In-Reply-To: <20220222001817.2264967-2-marmarek@invisiblethingslab.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 22/02/2022 00:18, Marek Marczykowski-Górecki wrote:
> This reverts commit 2afeec08ab5c86ae21952151f726bfe184f6b23d.
> 
> The reasoning in the commit was wrong - the code expected to setup the
> watch even if 'hotplug-status' didn't exist. In fact, it relied on the
> watch being fired the first time - to check if maybe 'hotplug-status' is
> already set to 'connected'. Not registering a watch for non-existing
> path (which is the case if hotplug script hasn't been executed yet),
> made the backend not waiting for the hotplug script to execute. This in
> turns, made the netfront think the interface is fully operational, while
> in fact it was not (the vif interface on xen-netback side might not be
> configured yet).
> 
> This was a workaround for 'hotplug-status' erroneously being removed.
> But since that is reverted now, the workaround is not necessary either.
> 
> More discussion at
> https://lore.kernel.org/xen-devel/afedd7cb-a291-e773-8b0d-4db9b291fa98@ipxe.org/T/#u
> 
> Cc: stable@vger.kernel.org
> Signed-off-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>

Reviewed-by: Paul Durrant <paul@xen.org>


From xen-devel-bounces@lists.xenproject.org Thu Feb 24 08:27:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 08:27:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277949.474804 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nN9TM-0008Pj-5d; Thu, 24 Feb 2022 08:27:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277949.474804; Thu, 24 Feb 2022 08:27:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nN9TM-0008Pc-2V; Thu, 24 Feb 2022 08:27:36 +0000
Received: by outflank-mailman (input) for mailman id 277949;
 Thu, 24 Feb 2022 08:27:34 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=VLhp=TH=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nN9TK-0008PW-Rn
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 08:27:34 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9d249100-954b-11ec-8eb8-a37418f5ba1a;
 Thu, 24 Feb 2022 09:27:33 +0100 (CET)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2053.outbound.protection.outlook.com [104.47.12.53]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-27-EH9uR_soNnWnWzKDoRUcqQ-1; Thu, 24 Feb 2022 09:27:31 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB2910.eurprd04.prod.outlook.com (2603:10a6:800:b6::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.24; Thu, 24 Feb
 2022 08:27:30 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.024; Thu, 24 Feb 2022
 08:27:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9d249100-954b-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645691253;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=YFAFeSNMQrwq3dvf2PS+dxBgCGLjZYvktWV37T+uqIo=;
	b=d2FDS69kPERUWjX27bqw1Ay7kV9ej2rEZxjYmbwJbikE5WeSYawl5l0H1iQee0LxhxzKEY
	/NJtoKh301Neyq7pC4sTEsRMiDDWl4bcpXxhnRjqAiUBDX1S9Ft3FBFWwGwWo/M96MW+zs
	T5vKLh8C80g3FCtPv7bw/XqZyU0yDjA=
X-MC-Unique: EH9uR_soNnWnWzKDoRUcqQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=FL90oqCK1YPCR6eg8wnEqtT8io3+S5yosXCanlBpqVPaWxamNY2f4JH9e9N1USvC4wabw4edqG97Iu5qpmoao5OToE952QwI9tKZealQl1YRhTvq3VSczNUqt+I4E+mSQgA++2vNn5XfdzP0qxCLMyB/Ic0l4mzyM0IwnV/yxszVZEtUCd0BPraJJg2LadR4d744VtrBuk2NAF3cJXNTwdR4ojgZZ91Qn/DmpiXLcUstj04G1MAB9GuBma1LiJRDv27v0bd5f9hZJLryPNJ+6ydEo7N1NzaeRqhVcEllbAgTuaJ0LazdN+az0Hfv1W51sqloSTw6wbGpePoXlPAMgQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=YFAFeSNMQrwq3dvf2PS+dxBgCGLjZYvktWV37T+uqIo=;
 b=YGON3ZGYXEzuY7DQs5LaAsed95yk4YC/MhTLk3Vj2VI35AP5kuiXi43aXq2ho5Sw/TkNlhc72vrkTxVJrnNSCMLRGIMjAEJPKxACu6wv65LGjM5o/gR0ThNZ99IB8KelUrMiVH8V5zFsONFl9UXYj6w6DkAQe1POcQZ7jwj+THhHKYAF5hkYoXTZiYC1UkLH97i+xfIVolyvLqyvyArmKLVXtqHlX6ctej2RQoVUW+KnE3dB/KyXYFmeK7k8ToJ5Y+IbfkI1u9tks2tkw+h64gdOrI8P6m64ZeNiRpTSa9TXYWJdJz4dY+gXqid+y+Tj/RGrzfMutXEYomOXUOANXQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <6befff41-528d-015c-3c41-f643c0b98530@suse.com>
Date: Thu, 24 Feb 2022 09:27:27 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH] xen/mm: Remove always true ASSERT() in free_heap_pages()
Content-Language: en-US
To: Julien Grall <julien@xen.org>
Cc: Julien Grall <jgrall@amazon.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220223183831.5951-1-julien@xen.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220223183831.5951-1-julien@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P194CA0087.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:209:8f::28) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: de09a04d-8c43-4360-0e40-08d9f76f7f4c
X-MS-TrafficTypeDiagnostic: VI1PR0402MB2910:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB29102506BEE0902B4A0C11FCB33D9@VI1PR0402MB2910.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	SlfLFoYPWpy91Tp56n8RoiKUP3wgBWTGP3DBz1mobPPsaRHmtDrY7XreThglwyiiH+/cKoxa/uEvmZyWMhV6LjcHAt97PtB+BX6jQDmSMdRipsZ1u6tr78sVb5Dn6IEygGqqHIHGVgHBl5wlG1nQDDlyVk6NIbwJU1KPO+0GvrLxQD7MZh18HMjnfz4A9iQZhT1hKlxmnBrswSIkskQa+lPaZp0lGKWgEsIiXFsSU7DeuNu5zhy7pMUjSloTGjICzO6ZUKnlpns3oFWV2e0GesU2hh9zW8aKT8rqILWbii+0gZrnaOmQVMFkyHu1lUtWGLpPOwGc3iZm4rmj+pa6oGK2oEXQZCwf4ytSMMQiY4qX2+BpFbMO4cbKGw6HXy98dAbFGBo+Cd7Ilgh/OyvpCHhn0N2sXQOVE9XowgYd2MJhl7e7xIN9vCk1UJUnqNzQkZwWlhFgeoW81fYRVrAJ2jbfEDCEGxIs7YNqLC7f9n/gaz6rZkfZBmeE9tTFipTHxXf79wbL1my5d+WSxL+KaMPC3igyf8dO3qj0UgElr9r8x0h/lFwbgtCG6nJdXH+sKHodEeba3YibHfOK+hr/w3DSsPHPjIRRBDfDgfcOtVGH2QusS/hd2aGoZcnfiOFj88ykLXFYCg0x637R2ETsYquXFhVOOLUI4oWdnSMzq+MFmFzR7y43VgZKGOQIaL1oTejT7pHg4NVgce0iwcOCqT12fT38vDuy25goV2nkok8=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2616005)(6916009)(6512007)(6486002)(4326008)(66946007)(8676002)(66476007)(66556008)(54906003)(31696002)(86362001)(316002)(6666004)(508600001)(38100700002)(53546011)(6506007)(4744005)(186003)(2906002)(26005)(8936002)(31686004)(36756003)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aE9valk3R1ZpTGxaQ2EraHEySU55eTduU0NUS3ZWU2kveW1GaTNheUxqTHF3?=
 =?utf-8?B?WlJleGpvN3F5VUhQRHA3Nmc4ZTNZaWdhZHVkNWVPZTNNaEF6NSsrUHdQZnB5?=
 =?utf-8?B?UzFNREVydk1xYmpJa015d0IreHV1YVB1Q3NBY3Eyd0xLeDVhZ0prT1hENlZ6?=
 =?utf-8?B?VE1oR2RFQ3pJbjZjSDZRY29GMVl4MWNwcnVDUEtFUGlsWS9XejA4ZjdPUjFK?=
 =?utf-8?B?L2t4dHFTMFJhdHJHcmpNOW5pbTRsUnRDRis0YnBDM2VzL3pYVmwwQmFtc0Fp?=
 =?utf-8?B?SHNYeHRqSHppalE5OWQ2U2hoL1pMNHRWQnQ1UTB1ZnJ2OTFYYUNjY1Z3WTRP?=
 =?utf-8?B?cVlmbTlJSWNhKy9TMkU5UHBOd0pQd1BCMEdFZHd2R3FwUzhTMEVieXNHM3lj?=
 =?utf-8?B?Q1NTNkFGYnhxOWhWWDU2c2ZscE5jcWFwd3VuNnVhakduTGZTWUE3bFFOWmZK?=
 =?utf-8?B?amdFL08rWnJBNjZmT3lPelVOSllHYWlKL0tiY2NjRzdZT2t6eFZKTHJCZWt4?=
 =?utf-8?B?OWEveWtPeDY3ak4zNktJamRvNlZTbTBHYWdCaHNKZWUzVzdNdWp2eWtFRlU2?=
 =?utf-8?B?Rk04cVp2ai9INk1UVjJQZWoyT01CdHIvWmxSTFE2UklzTDAwVGtMYXRqb0hq?=
 =?utf-8?B?MUg4RkJvNEN4dm9ERVluUWZybDhxcWNpdndtSjhkWGNtOUw0a2xqL0YwbFFH?=
 =?utf-8?B?ZFFKZnRyVXJaZTJzQ29pSWZYR3ZkTSswZCtueEgvZUFYYWhqUG0yay81aDFn?=
 =?utf-8?B?c0pudUJFS2xzSGlvWHFtb08yeUZyK2dJT2luN0lOS1ZSQmhOZGR0YkJhQU0y?=
 =?utf-8?B?bS9WVnhqbjMzRHN1cXhlc3JhYWU3akNpVk5PTE9MR3dKb2lyamM3dDZjbEVR?=
 =?utf-8?B?VEtCSVdjMEx0bTVzeTR2RERRU0ZTQzRpM1gwRlJMMThRNFZVaVZvOXpnNG96?=
 =?utf-8?B?a1B0bEZhc3BiRm5IRTJlZEQ1cFk5U1o4Z0ZiK0dXa2d3MkF6Z0p5VVZHUENK?=
 =?utf-8?B?MnE5cysyNU5wbzVDT2g2L0V2Sm4xSzFJUkNILzhzek9TTmhIMzBhQVlSckNl?=
 =?utf-8?B?MU1NYWYxOUxZdWo4WW1kZ2lIZHRhV3hkL3R3aU4zbjdRUHd3VG9RTTVlRWhy?=
 =?utf-8?B?YmIraytkZFdYd3RHU3dyWGJVRWQ1b1J2MXN2OE5kQ1k1M2NqT0dWZ1c4aFl4?=
 =?utf-8?B?TFRFdFN1S0N0dmVDZVluVWNqdkQ1eGJVMjJRRnlJQStGS3BzKzd6SDl4S1BB?=
 =?utf-8?B?SVJ3cUY3UDNNUGFVUWwvQWw0L0ZseFh4YUttTlZDclNkVGJmY05rWnJVb2hy?=
 =?utf-8?B?R0dNOEppbFV4TWhHUnEwZUFRdFZxSzJ6ZnBnbzlydmNxT1hSZldBOTltdHlH?=
 =?utf-8?B?cXJrREluUUp0RTdzU1FpRlZBRVRKS1FRYUZzUDJpTnZXWlVjV05WWG1rNmwx?=
 =?utf-8?B?RWpNWURlKzVtTmJUWUZzZnphSWtsRXdnMXJnSk5CWHRQb29wdWM5TlpTM3lq?=
 =?utf-8?B?cHgyVmhIVVZWZWVQY3dYZndPM3lpT0YrRnUzUHBYNSs3eXVLT1lLejIvSVhF?=
 =?utf-8?B?NndabVhSektKU0FqU2pibURkYzNvTE9tUE5MTlNvRnFGTHdFOUs5aUxpcVlh?=
 =?utf-8?B?WW1BNWxsekRtTUNGTmhCSENTZ0Zpci9sdjZZQm1QV2hOMnNydXFqZFAwL25r?=
 =?utf-8?B?MTZweVFicW55bnhtL3hVb29NQXRES3B0K016SlBSZTFmVVdka1c4TWtYelVu?=
 =?utf-8?B?QlZCZnlxTGJ4K0xTRkRwR25YUFE4aWtIR29DcU1FcXExK2Jiblp5NWRSVWM3?=
 =?utf-8?B?bmI2bEVjRWVRRlFLWDdON1ZkdkJRWVArdlFocXNCdkhJQkp2MXNMZ3RXdzRG?=
 =?utf-8?B?THNWT0FVTVdHRmxHL3ZsRU13d0o1cXB4VE5tQm5ReEpGN2FOVkVIMmt3QjND?=
 =?utf-8?B?YmV4N2Yyb3JUSVd5S0NXOXdFay9BblBlaFg2cjNvWXJBeG9GSFRxQy9nd2tE?=
 =?utf-8?B?dEJUcFpBNmFodkJMVnkzbk9nSHhXZjJMOFZ2UlJ1d0x4M0pWS1d5K2RKcDlR?=
 =?utf-8?B?enJyemdKK0hldVo5VlYxcDhJRW5RUGxoNTM5eGRLVkZ0VEpVK1NWcG1ncU15?=
 =?utf-8?B?b1pOYi9KYXlQUzFxUjN4YmoySWJqQVN6UXp3blJTbkcxS2xXNk03QjlPZkpL?=
 =?utf-8?Q?V95T5FoG/BhLQeYrht0+KKA=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: de09a04d-8c43-4360-0e40-08d9f76f7f4c
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2022 08:27:30.0007
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ftIX/X8kiVTWkqNzIujCU5GrThHESXmV/ijr/tPMFNGrlSXBDOvHkWJjHacVnfAAEgixY6JwTZbVnl99m0ZngA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB2910

On 23.02.2022 19:38, Julien Grall wrote:
> From: Julien Grall <jgrall@amazon.com>
> 
> free_heap_pages() has an ASSERT() checking that node is >= 0. However
> node is defined as an unsigned int. So it cannot be negative.
> 
> Therefore remove the check as it will always be true.
> 
> Signed-off-by: Julien Grall <jgrall@amazon.com>
> 
> ---
> 
> I have looked at the history. AFAICT, node has always be defined
> as unsigned int. So the ASSERT() may have never been useful (?).

Commit f0738d2d3f81 introduced "node" as a local variable of type
"int". Along with this commit f1c6ac275100 introduced ia64's
paddr_to_nid() (backing phys_to_nid()), which was able to return -1.
Hence at the time the assertion fulfilled a purpose. I should have
dropped it in bd3e1195d694.

Acked-by: Jan Beulich <jbeulich@suse.com>

Jan



From xen-devel-bounces@lists.xenproject.org Thu Feb 24 08:47:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 08:47:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.277977.474895 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nN9mW-0003Iz-V1; Thu, 24 Feb 2022 08:47:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 277977.474895; Thu, 24 Feb 2022 08:47:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nN9mW-0003Is-Rv; Thu, 24 Feb 2022 08:47:24 +0000
Received: by outflank-mailman (input) for mailman id 277977;
 Thu, 24 Feb 2022 08:47:23 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nN9mU-0003IT-V4; Thu, 24 Feb 2022 08:47:22 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nN9mU-0000zn-Sq; Thu, 24 Feb 2022 08:47:22 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nN9mU-0007RI-FB; Thu, 24 Feb 2022 08:47:22 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nN9mU-0007Qw-Ei; Thu, 24 Feb 2022 08:47:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=tFscTXEg8UxMdCqEJzEo5flKj+efQJLr0xyj3K7Ox+s=; b=FQaft3kRRnbwfP6j67zBu38bc0
	6fDcGhKWbnckSTTxPCUGLp1YlgHQ2yQ3C6UDHiJMgPoHSfMO2bPAg3EzN3PnTmrbi13TGv8Hs4z9v
	nlfzDtH0F45flr5MAar5E+jhh73XfC2aWxBe5W0cUHv7Wm/EPEXS5V9Y9PiMg50Ay1rc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168211-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 168211: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=f04231775c179b3424fca45d64f29e226a41a610
X-Osstest-Versions-That:
    xen=210f27e55abd2a57c01105992bc10bc4d7b8132d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 24 Feb 2022 08:47:22 +0000

flight 168211 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168211/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10       fail  like 168198
 test-armhf-armhf-xl-rtds     18 guest-start/debian.repeat    fail  like 168198
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168203
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168203
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168203
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168203
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168203
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168203
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168203
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168203
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168203
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168203
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168203
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168203
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  f04231775c179b3424fca45d64f29e226a41a610
baseline version:
 xen                  210f27e55abd2a57c01105992bc10bc4d7b8132d

Last test of basis   168203  2022-02-23 05:59:50 Z    1 days
Testing same since   168211  2022-02-23 21:07:13 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Dario Faggioli <dfaggioli@suse.com>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Julien Grall <jgrall@amazon.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   210f27e55a..f04231775c  f04231775c179b3424fca45d64f29e226a41a610 -> master


From xen-devel-bounces@lists.xenproject.org Thu Feb 24 08:53:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 08:53:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278025.475042 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nN9rx-0006My-KN; Thu, 24 Feb 2022 08:53:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278025.475042; Thu, 24 Feb 2022 08:53:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nN9rx-0006Mp-Gx; Thu, 24 Feb 2022 08:53:01 +0000
Received: by outflank-mailman (input) for mailman id 278025;
 Thu, 24 Feb 2022 08:53:00 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=gX/V=TH=citrix.com=prvs=047ddeb39=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nN9rv-0006LK-Vy
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 08:53:00 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 28d2dd0d-954f-11ec-8539-5f4723681683;
 Thu, 24 Feb 2022 09:52:57 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 28d2dd0d-954f-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645692778;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=QFtYiwqGKrxsokiVRlNx+Fyl2G/YwI/C5+xbSq7EDyQ=;
  b=MG2YLeF4fE2M7v+nadgkLDenVyCr3JuQMvJe9KHSmdrKRiyjSIe0+mbO
   A6+XFgA5z8lS524VMU3KUOQTKcVFa365ONVt8WVfxj0ddZYBdB1+g/dZq
   edIBRpaf2NlypmLVrKs7lyhynFErqdjkbuk6IgZb/6lF8tfujNoOZjE7B
   Q=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 64887340
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:XiZuSatxwydn6nELnuBS1XMzBOfnVHNeMUV32f8akzHdYApBsoF/q
 tZmKWqOOq6PNjake9l2a9u0/EoG65fWzd5jTARo+3g2EHsT+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQzy4bVvqYy2YLjW1nX5
 YuryyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb
 /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo
 Oihu6BcRi8JJO78xOYPcCVfDhs9I4xp/YLEJnWG5Jn7I03uKxMAwt1rBUAye4YZ5vx2ESdF8
 vlwxDIlN07ZwbjsmfTiF7cq1p9LwMrDZevzvll6yj7UF7A+SI3rSKTW/95Imjw3g6iiGN6AO
 5pJNmEzNHwsZTVCF3Y0Fq4RkNuUm0H7KjB0llS7o/c4tj27IAtZj+G2bYu9lsaxbdlVn13ep
 3mA9jz9GRYcHNOawDuBtHmrg4fnjS79HY4fCrC83vprm0GIgHweDgUMUlm2quX/jVSxM/pdI
 UEJ/islrYAp6VemCNL6WnWFTGWs50BGHYAKSqtjtV/LmvG8Dxul6nYsbiQCWIAkpuwKQiEQl
 UGosNbUBjtiiejAIZ6CzYu8oTS3MCkTCGYNYy4YUAcIi+XeTJEPYgHnFYg6TvPs5jHhMXSpm
 m3R8nBi71kGpZNTj82GEUb7byVAT3QjZio8/U3pU22s9WuVj6b1NtXzuTA3ARutRbt1r2VtX
 lBZw6ByD8hUVPlhcRBhps1XQtlFAN7fbVXhbaZHRcVJythU0yfLkXpsyD9/Plx1Fc0PZCXkZ
 kTe0SsIusMOYifwMfUsPNrqYyjP8UQGPY67PhwzRoATCqWdiSfdpH0+DaJu9zqFfLcQfVEXZ
 s7ALJfE4YcyAqV71jumL9rxIpdwrh3SMVj7HMihpzz+iOL2TCfMFd8tbQvfBshkvfjsiFiEr
 L5i2z6ilkw3vBvWOXKMr+b+7DkicBAGOHwBg5YJLrXaelI+QgnMyZb5mNscRmCspIwM/s/g9
 XChQE5Ijl35gHzMMwKRbX5/LrjoWP5CQbgTZ0TA4X7AN6AfXLuS
IronPort-HdrOrdr: A9a23:n0AUpavR9DdeJyMd/akZm1UO7skDjNV00zEX/kB9WHVpm6yj+v
 xGUs566faUskd0ZJhEo7q90ca7Lk80maQa3WBzB8bGYOCFghrKEGgK1+KLrwEIcxeUygc379
 YDT0ERMrzN5VgRt7eG3OG7eexQvOVuJsqT9JjjJ3QGd3AVV0l5hT0JbTpyiidNNXJ77ZxSLu
 v72uN34wCOVF4wdcqBCnwMT4H41qf2fMKPW29+O/Y/gjP+9Q+V1A==
X-IronPort-AV: E=Sophos;i="5.88,393,1635220800"; 
   d="scan'208";a="64887340"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=KHaC65uYW1ZjA8MHlZvtfHtvhh1o+ukBNZlXBpxMgeFcYvkq+uA5FbKUkOT2pxUcLDCKa+55LH9jvZ17Jgj0ZYaSNTkOESoqfKAU92UKVLZJwTwN/ZGoiIkrhIxFE29IZKHSdC+kwZdnDeLc/K4laLQ6H0hQ8hjfvIgIk0ib5K7VIf3LGvgHb1tB22Qm2a3jlsnEHohFpr+6npYPrDZcyBt+SIV/YmYa1TyziCz6mfWRU8EDONmIcY8tFnPMoI3imWPuMFowKFvXKCT4wcN2DfH+kOkGc4LPjSuOvjzgd/pz5FhaZBNws3ziyUx464ac5dLU+W1HngeX7QKIoNkxeQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=muXJK6EoVtkgr7j9P3+dhgM5a16YrMk6iISD3fXVho4=;
 b=TGnNU8bUzw7JTP1FyaLM4b0qmdq5/dN+OkgSjAO5jK0BxPpIlS0tksfdrYrG6PkwMHmhltNmhfw0+23u0qtTQVHipnBgM+u87UfJHCA9NNwQ+tBuAKp4H5u1vhD2LsV9ZqWIp/n+qCIEkriQtdQ9vfYvwTR5Vypwx/5ERV+b3T3e6Cwrbp4Vjr0P4d6WkY8rGoL8GtMGYO5GV1/rlCd6DgPU8MViD7fxXBdAXffe71IINxwYxU+UM32cVhfxNFIgIbIUNxZz70/lDRv+Sq7GrGInW9lFAfEjfi9xVMX5M3ngv2CawEM5mEDA94Hiv6ZMxEhZj1/3P7IYWj+L06Wf6w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=muXJK6EoVtkgr7j9P3+dhgM5a16YrMk6iISD3fXVho4=;
 b=LqYf4mYp9U+YBamoV02ijGEpQE6luQlJW0KGkABZEJB/MBesUk/b49Y3taHcEZmV3QE+vlRBnub0kBi6vPmMdE+E1M4a2vgrwyRYxmPxXFKAUBc9P8vcSiXUIKK2p9Ec4Tz1PHGYDKkhAQWDFR09OvvRGzNhMvBpvKW2mYOAbxI=
Date: Thu, 24 Feb 2022 09:52:45 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Andrew Cooper <Andrew.Cooper3@citrix.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Alex Olson
	<this.is.a0lson@gmail.com>
Subject: Re: [RFC] Avoid dom0/HVM performance penalty from MSR access
 tightening
Message-ID: <YhdHXc9zF1vnlYF+@Air-de-Roger>
References: <949b4776e23e4607776685a7e2705b9e77f5b717.camel@gmail.com>
 <a1099ae9-9e0d-cf54-e786-835c13f2ba40@citrix.com>
 <d11e54d47776008c17762458e6abbd44ab0beed5.camel@gmail.com>
 <YhZcxkY/BgPy/MTh@Air-de-Roger>
 <40942f98-5caf-43b8-5763-81b59a7b800c@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <40942f98-5caf-43b8-5763-81b59a7b800c@suse.com>
X-ClientProxiedBy: LNXP265CA0021.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:5e::33) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 27f0d4aa-e87f-4b73-6bcd-08d9f7730a63
X-MS-TrafficTypeDiagnostic: BL1PR03MB6088:EE_
X-Microsoft-Antispam-PRVS: <BL1PR03MB6088AD23C448FD94570130228F3D9@BL1PR03MB6088.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 5eDBEgHqQv88iNoPqspxeXItW0n3EjTsSoIFOpjDbLJQItNjQQO61EhakF3uOmcCnsyQcFW0j6BnV+GfJyUbaWp7/v/8qG8RztJJOQdVpoI/FX4NY7ED/9MhieYQIpFDBPSHcWcAmm47ZoKSsbxs1OsR40lVqHSVFt7O2atSpSFq382BYx9kmX7K6nOT/lguhDyTTwN2KC/qhg+WOV4A1Fp22Jk7UVErO+E/ENdUk/233V7zKKtMJJJu6SulLJj7aVpFlnqpvt3zY6+pF/PnfmL3nyWnAs2WE3WgyoTzQpuVke3Mn1DRNa7NvUZjl2bMNicGCi6rY+aURuRlvw2Kfp9I6wa4DNSQf6KVpz8AtoD5DOkiU0gAIuWKIftnEqY1LqypiiM6j9DE8UVb1WZuMG9EwL3NBrug7IUWKij2uBlVlf9oVslxzMEF6P0akN7tdF2mRA5lU+XE0kTXsGexVHkkv7OR6wBbLsP9EqIo2puroeam3xHhK66vp+kho2QQtrjkkx0Ib2GXsdH58AgZLF9DqIS45VlqqpvrugKZZXOZuRzAgiOTBpqvxaoI/8R580slqujNJeqXTYmpPZStGxm05vgb6RoNbbcvRiwi9Pc3NQhO43nR3CYYUoEIQtcC4wL+Foytf1usn4i2i5/Tkw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(85182001)(33716001)(54906003)(6916009)(316002)(186003)(26005)(6666004)(82960400001)(6506007)(5660300002)(83380400001)(2906002)(6512007)(4326008)(6486002)(86362001)(8676002)(66946007)(66556008)(66476007)(9686003)(38100700002)(508600001)(53546011)(8936002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dk1zTTd2VGJwWUdKL1cwNE9MZGd4OVp2RC9wdWVnVVdOWGwyQkxQOHgrL1gz?=
 =?utf-8?B?Nlo3MXl3eFcvK3lwYnZKNldyRXRRWndsQURjMzkwZkJTRVZZSDJlOUhZeWlK?=
 =?utf-8?B?NXE3VldoaXFHNjJ6NjJiZ2dtMDVjV2hRbHR0dG1IenRGZnRLSEtNZXhrc3hJ?=
 =?utf-8?B?TW0xNWhOS2hpUXVOSGcrQmxaVFZ2a204RzFaTXYvd1ZnVW1NbFZjMm5hV096?=
 =?utf-8?B?RHVaMDVpY3pwSW5PcW9JeXBGMzkzQllJUlNMOE9VYzBUcERaRVhOUVFCc0ZF?=
 =?utf-8?B?UW1mK2xMR1pmbUZDYXpmOFlPUG9WNEpZMHVCbkE1T0twM0lHdUdDd0VNcTB2?=
 =?utf-8?B?Qis1b1A4VzIvOWZWL1BBckEzR3A5K1A1QTl5MTU0NWRTUmEvcFV0TkRwNUFn?=
 =?utf-8?B?cjBha0FMS2tRY2tvMkI2R09EVVBRWWs4b3ZVNGhhSzdlOEdlVVhuS1d3V1Z5?=
 =?utf-8?B?RlF1RDgzMjd5elpEU1N1bFJ3WnlONWVMNkZxcGRid2puRE5IM3JoSjkzVHNF?=
 =?utf-8?B?bllGUjZJRnEvTHhlRnZiaktOcVNLQ0V6Uy84ZW1WbUtaeXo5UW43bDUrVXpl?=
 =?utf-8?B?bXAvbUxJS3o0VVU1YWFTSGN6RGJ0d200cCtmMTdOWTJ1OXdnREgxd2ZqOW9E?=
 =?utf-8?B?cXNZOG5BcG5FL0VRUEJyRkdCZHFUVnRXUUUwUXIybXFVSm1VWUxuc29CaW16?=
 =?utf-8?B?WGZweVhKYlV2d3dxSVl4WnRySklnNWg4ZlYyMDUrWS9QVGVpVU1rMVJ3MEJP?=
 =?utf-8?B?SVphQzB2cnowajJHTHZNRWZpOG91Yk1wRU1BbUpHOVJJRW91OUJRT1ZEMWZw?=
 =?utf-8?B?MFd6QjIzWGF2L1dhRnRXLzVkb0g4Y21EVE9CVitLcEE5QjhOSE1YckxNWFNW?=
 =?utf-8?B?eTg2RXZSMkdEV3lDcDc2bnY1YU1EVDVtVERRWVBpVzFZcXBiemdKdDgzVnAz?=
 =?utf-8?B?eGJaQmNOaFZ1YmMwSE1lSVpLa051QnB1VHBnc3dLUHB2YVg5TDJVR2srYnM2?=
 =?utf-8?B?WVRTbkFSSUZlYm5RanpRMFB4cmd3bXdlaGVxV3FkUnZCdU5LTUE1NU5RQnpo?=
 =?utf-8?B?WWw1Sm1DY2NRTDZacXppdk9uZ2crM29TN2MwMlB0WEYzdW5mTGJSdWtLRU5i?=
 =?utf-8?B?ck10T1h4N2hYaFNtU25nNTlQcmdXSytuL0NSNVMzdFpVZFA2MGZYNTAweE5q?=
 =?utf-8?B?dDI3NWRBNnU1OStiVW1sVHd1VDAvUGFmdjREWjg1MGFzZEQ2UXBkNnQzdTF5?=
 =?utf-8?B?elpNaHRIdytHS0s2aWJlbitlVmE1aDZlYndvaWVqbnUrNlVNYm1SNG1LVE9o?=
 =?utf-8?B?ZlAzeVhHcnYwSFd1TGxNQktsekZsSmdaUE5qemZ2ZGdadko5bFlvRzRablVU?=
 =?utf-8?B?R0N1WFVlR3hQbFZYeHV3WFNEdHFlbTdTTU5SVnRXUmF6M3BuTEV4NVVrOVpp?=
 =?utf-8?B?bDZhaVlFNGVEcm1vVWxFU2gzbTRFdDZtQU5PSDZtbFJFUXZaMTRXbmdtMm9N?=
 =?utf-8?B?dHVGNHJlYmVXWW9hM2tRekxXRGtMcVFqNTh5TWRLQ29kc1VsWFVlaUVEUmFC?=
 =?utf-8?B?YkdiQWxUZjNIazhmZk1va1hRNXQ2VjU4RHFCUUFHSUNUMklXUEtRaG42a2FI?=
 =?utf-8?B?L3I1YnpEdm9obWkrQ0VHakMranJ4ajJzMkVYNkZCYnBPOElacXZzQzBydnF3?=
 =?utf-8?B?Sko4VDFwSzc1c29WTTQ1MTNtOHNTWEgzL0FQWlBpSGZwcHh1RitWNldWMzFK?=
 =?utf-8?B?Zkt4Ym9Lb3B0czc5bGVCY2ZRNUhuTDVXLy9kK05lYk1aN25TY0hneElEQzZj?=
 =?utf-8?B?MTVaTlI0V2E5cmRsbmZqTk9hMW0vcE05Nm1udUcyM2VDaDcxQmM0SG1rRTBV?=
 =?utf-8?B?RWd2d0Z6ZWxIS3V0a0x0cUhGbjI1cVlyeDlIVjFLdVhDNEt6b3FJTTBjeXI0?=
 =?utf-8?B?R010YWtIckRkWDJmTG5NRVIyZUROQWdHcEkrNWpFS1BDWnJZR2E5WmJzb21J?=
 =?utf-8?B?SWx4NjFwU29ZWlZmTmQyakdxd1Z3U0FHZ214cnBTeGlPWkhGcUVWd25TbXpx?=
 =?utf-8?B?b2RGbmxqdmZXaEhLWVkvOTAxUk96SlNRa1hIb3NwYkpRclBFTWZqYUs1L0VB?=
 =?utf-8?B?NnFFelZkd3ZuQzNCMGQ3c3BCV0IzSU5wZXBkcU9NYTUyV3k3NHkyaFZUNXlh?=
 =?utf-8?Q?/0wbWAio/QFiueJXHPdb49s=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 27f0d4aa-e87f-4b73-6bcd-08d9f7730a63
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2022 08:52:51.9723
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1W0GB6EtH96KF0PiiETtlnBUI+RGUGpKL3f9vpcFINpqu/oF4zuvKf3xPDbeBeu7CfvWWpZL46n2WHM4VvLV7A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR03MB6088
X-OriginatorOrg: citrix.com

On Wed, Feb 23, 2022 at 05:31:53PM +0100, Jan Beulich wrote:
> On 23.02.2022 17:11, Roger Pau Monné wrote:
> > On Wed, Feb 23, 2022 at 09:38:56AM -0600, Alex Olson wrote:
> >> 1) For conditions in which MSR registers are writeable from PV guests (such as
> >> dom0),  they should probably be readable well, looks like MSR_IA32_THERM_CONTROL
> >> is currently one of a small number of "unreadable" but writeable
> >> MSRs.  Otherwise seemingly valid read-(check/modify)-write operations will
> >> behave incorrectly under Xen.
> > 
> > So it's one of those MSRs that's only writable when dom0 has it's
> > vCPUs pinned. We could allow dom0 to read from it in that case (that's
> > an oversight of the MSR handling rework), but it would seem better to
> > just remove access to it altogether: it's bogus to allow dom0 to play
> > with the MSR in the first place IMO, and it won't really solve issues
> > like the one reported here unless dom0 vCPUs == pCPUs and all are
> > pinned, so that dom0 can fix the MSR in all CPUs.
> 
> Dropping this is imo only legitimate if we decide to do away with
> "cpufreq=dom0-kernel" and alike.

I would be fine with that. I think the mode is bogus anyway: dom0
doesn't have enough knowledge to take meaningful decisions, and it
would require that dom0 vCPUs == pCPUs, or else it's only acting on a
subset of CPUs which is already bogus IMO.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Thu Feb 24 09:01:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 09:01:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278057.475149 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNA03-0000aj-JP; Thu, 24 Feb 2022 09:01:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278057.475149; Thu, 24 Feb 2022 09:01:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNA03-0000ac-FK; Thu, 24 Feb 2022 09:01:23 +0000
Received: by outflank-mailman (input) for mailman id 278057;
 Thu, 24 Feb 2022 09:01:22 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=x4ms=TH=ipxe.org=mcb30@srs-se1.protection.inumbo.net>)
 id 1nNA02-0000aW-4m
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 09:01:22 +0000
Received: from blyat.fensystems.co.uk (blyat.fensystems.co.uk [54.246.183.96])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 550cbd1d-9550-11ec-8539-5f4723681683;
 Thu, 24 Feb 2022 10:01:20 +0100 (CET)
Received: from pudding.home (unknown
 [IPv6:2a00:23c6:5486:8700:eaa7:4ea6:88e4:6f0e])
 by blyat.fensystems.co.uk (Postfix) with ESMTPSA id 314E643912;
 Thu, 24 Feb 2022 09:01:17 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 550cbd1d-9550-11ec-8539-5f4723681683
Subject: Re: [PATCH v2 2/2] Revert "xen-netback: Check for hotplug-status
 existence before watching"
To: paul@xen.org, =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>, linux-kernel@vger.kernel.org
Cc: stable@vger.kernel.org, Wei Liu <wei.liu@kernel.org>,
 "David S. Miller" <davem@davemloft.net>, Jakub Kicinski <kuba@kernel.org>,
 "moderated list:XEN NETWORK BACKEND DRIVER"
 <xen-devel@lists.xenproject.org>,
 "open list:XEN NETWORK BACKEND DRIVER" <netdev@vger.kernel.org>
References: <20220222001817.2264967-1-marmarek@invisiblethingslab.com>
 <20220222001817.2264967-2-marmarek@invisiblethingslab.com>
 <d9969551-77ca-fda7-b30a-da5d9e1dfcd6@gmail.com>
From: Michael Brown <mcb30@ipxe.org>
Message-ID: <a10683f1-59ef-93e1-150a-f755bf470602@ipxe.org>
Date: Thu, 24 Feb 2022 09:01:17 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <d9969551-77ca-fda7-b30a-da5d9e1dfcd6@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00
	autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
	blyat.fensystems.co.uk

On 24/02/2022 07:56, Durrant, Paul wrote:
> On 22/02/2022 00:18, Marek Marczykowski-Górecki wrote:
>> This reverts commit 2afeec08ab5c86ae21952151f726bfe184f6b23d.
>>
>> The reasoning in the commit was wrong - the code expected to setup the
>> watch even if 'hotplug-status' didn't exist. In fact, it relied on the
>> watch being fired the first time - to check if maybe 'hotplug-status' is
>> already set to 'connected'. Not registering a watch for non-existing
>> path (which is the case if hotplug script hasn't been executed yet),
>> made the backend not waiting for the hotplug script to execute. This in
>> turns, made the netfront think the interface is fully operational, while
>> in fact it was not (the vif interface on xen-netback side might not be
>> configured yet).
>>
>> This was a workaround for 'hotplug-status' erroneously being removed.
>> But since that is reverted now, the workaround is not necessary either.
>>
>> More discussion at
>> https://lore.kernel.org/xen-devel/afedd7cb-a291-e773-8b0d-4db9b291fa98@ipxe.org/T/#u 
>>
>>
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Marek Marczykowski-Górecki 
>> <marmarek@invisiblethingslab.com>
> 
> Reviewed-by: Paul Durrant <paul@xen.org>

In conjunction with patch 1/2 (which reverts the patch that caused the 
original problem):

Reviewed-by: Michael Brown <mbrown@fensystems.co.uk>

Thanks,

Michael



From xen-devel-bounces@lists.xenproject.org Thu Feb 24 10:14:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 10:14:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278064.475160 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNB8v-0007f9-La; Thu, 24 Feb 2022 10:14:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278064.475160; Thu, 24 Feb 2022 10:14:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNB8v-0007f2-HA; Thu, 24 Feb 2022 10:14:37 +0000
Received: by outflank-mailman (input) for mailman id 278064;
 Thu, 24 Feb 2022 10:14:36 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=VLhp=TH=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nNB8u-0007ew-GZ
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 10:14:36 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 90173fa3-955a-11ec-8539-5f4723681683;
 Thu, 24 Feb 2022 11:14:34 +0100 (CET)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2113.outbound.protection.outlook.com [104.47.18.113]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-28-qneMBb3ROPuLRAaKgdR9LQ-1; Thu, 24 Feb 2022 11:14:32 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM6PR0402MB3333.eurprd04.prod.outlook.com (2603:10a6:209:5::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.16; Thu, 24 Feb
 2022 10:14:31 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.024; Thu, 24 Feb 2022
 10:14:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 90173fa3-955a-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645697673;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=zhkz7XUOfkbAUL6lSDSMSMGj4W9BquadB21UquNDilc=;
	b=i+5BeWil7q53c6DoocXePIWaAkTQk4CQdXMBrdBOl7Eeru6w1MTNKEZ3kc0GchqS8PTKAd
	MKwEQ5vyY9QdMwVxTn1aGnQbTKGGcawAKXpDO4RE3GCoO85KU4M7GM3XcEGRTSmhvREdoC
	cfj3JHJNQIaWG8Tr4Fn3kEj6bPrxy30=
X-MC-Unique: qneMBb3ROPuLRAaKgdR9LQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=a78V4y121wmd+tF3k8ppQNxQn/Vh6NTmEKb7uWB+le14cSgoljhI/GF4Pf3OcpNhkkY7bLrxw2p1WpaklySNmeGg0WHXSDfAIcIRg0Zm2i/4uYEyT1H4MzQEVOFsfOX1rxlbwloa310c37NdsXhTr4VR9Cn6TJ2qsKwxxH+540yQ+PRNURIxZDWunRkfR/o42XXbS0VJZNWNG5OQvPN8YfquFpq6w8d0Wm+ej7I/SGXBdjGCvqycfCk2K7YHUc7OcfIr6fd2JP+k/5+CniNogoheaoKGD7HoNG54LkvMZcu4xV066nLgIrf86qrZchFAj9u6GNG+g+tEA9Ain7RFmg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=zhkz7XUOfkbAUL6lSDSMSMGj4W9BquadB21UquNDilc=;
 b=Tf8k2IZfk1B+UshpGS9g+W8J9EcS9onXa0Tn1J6IHEfKWWfuf4bhWxCZN7NwbjCvIXx7gg1ip0LDLPIc0WBjdhrIcVT86fggi8Meb2LzpoMv1xg4tcs38nEsxXIc6dph65G4flxwKJg0u81xvdInD7fM1VYXN+nFucyds++LDDgZWWyjHA6vZd85I7AMmoCgtbzBcthehxvx4X3JnfipNLDJGfpy+Y8CCMkbvXGGDA1bjHUq603Emj033xQyN5D1UzBinXNdV7fbwibluOw6BfG49lQiHxBSV2SpOm3OlSMKld4nTiL9jhL/l7QDgbnrKQwJTAzQq/Q6Yhjwygv44w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <ceaae3c8-0c35-efc1-c7bc-f44364ce29e4@suse.com>
Date: Thu, 24 Feb 2022 11:14:28 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Content-Language: en-US
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH] x86: make embedded endbr64 check compatible with older GNU
 grep
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P191CA0023.EURP191.PROD.OUTLOOK.COM
 (2603:10a6:209:8b::36) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 37c28d98-85a2-4853-c663-08d9f77e728d
X-MS-TrafficTypeDiagnostic: AM6PR0402MB3333:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR0402MB3333F2BBDFE752823231EAF3B33D9@AM6PR0402MB3333.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	BNME5yBQb56fm5pKl0OqFZsmARUVQLmrDI/XbnHzWS9aHzEFsXyXUXWzcxEMFtz7ABoPBhPE2ZgDcrX0jYeIb9eWekXBOF/JMioETt/MR9aieK4oLGD+BFg+P+RwrB8WT0g8OBtgi5Hu4qcWhLil6UZ3DiMLQ8BpAeWMGpi1CingWlJdByaidbcpqzJ3+TW1N47uQ/yVJijqYenrYWRb5ixRl08Cgu/vlUDF+o+y9Urzhyj0nhyFoVYOejS93jKJxbZaG0JWuBFiLa73GX/E67KeythbhWmTgk+yiCZs7lD2FV5Adu261QfXYnyhMACcl1O2xHTRr6+tA0r7JB3M3T78DsLX6A21HMZflfe48zngrA5Ry26DllAJnkrhKXo1PVmm3N1MLc/KAWqCocnaiu9NNlI4fFPxJ3EkABoxMwnMH5v+cSjX7YvpAGb5ij851CovDLS6ZjSg7jo0o2a7y9/nP71REFZ25kn37K1YNFlBwH9A2FMpx32uGr/Lo+pg4tnEiBWI234ZSCVFjzc3j9XhKSrTZdenMWw2jwtMS9pv/5b+nDRmHqY093BrpQRlerrd1n/Dbe0Y6IUVy5kCW0+RHmhHgM5/hFDSwhVogHeICWyK/hAOUmoNPmc/s0jYt3fOQSr2yjxaACakUw01uSn7Alo2Ovz7Fkq2X66iACPmzfyHc2Mx9BLIXR8earMwUaPwzHop6Yca1/+hF6dMA1n6UjoPpur6t36We8ZxRF0=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2616005)(66476007)(36756003)(186003)(508600001)(31686004)(8936002)(83380400001)(6666004)(2906002)(6486002)(31696002)(6512007)(5660300002)(6916009)(66556008)(38100700002)(54906003)(316002)(4326008)(66946007)(8676002)(86362001)(26005)(6506007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?L3ZSOW1wQkQvN3k1NXZvQ3lQdEtvL2ZxT0MxRExWT1A0Z2lhRXZkREZSdEh6?=
 =?utf-8?B?ZFBCWno1OFR4aU1remVSaEpvcyt4U0VPQWFFQ1ptU0VpRXlFbkIwRTg1TGNC?=
 =?utf-8?B?eERQZjhQRTd1OUVCbDc1ZVByZ3RtM3FaVGZ6Z0xSMmtyZ2c4T2hxVnZmblJQ?=
 =?utf-8?B?NEZ6aUJudGdYQ3Q4dzEwWGRJQVBKdnpXQVA5S0dJOW02SWJxMnZZYUdEcWlU?=
 =?utf-8?B?VEFlTE8vaEx0ZGpJM0didjhvR3ZhOUROMWVJQlBmL2g0NXB0dlFtN0V5NFN5?=
 =?utf-8?B?YzBoSzlEb3FkNzFQc3ZUN3VjWHArTmwrWlRMdXpFMFI2eHlGenl1QXpoSW15?=
 =?utf-8?B?VlJzUGkrb1FBenNlTFV1UTJxL3F1U2wwZkpDVndUWEM5OVFkVjBxWlozSjdG?=
 =?utf-8?B?QjU5QTJTbktzUDFsQWZ4QXZLbG9EN1dIZFM2ZnJEdGxGNFNIU2NBKzBpVkRQ?=
 =?utf-8?B?WUZVTFdQd3lXV2E3N1psR2JoN2gxaERML1JiVkFYOUxnWUJtMkFhUWlLWmtq?=
 =?utf-8?B?ZHFtM2cxWUhJQnoxdXNwWFNQbU1mL3preU5YZnQ4eGRkWmJGbksrN05FdGl1?=
 =?utf-8?B?SWRMdkMrWkxBaTk2UXdmZjBkc08xV3lRbklISGU4U1RVUWF5dEpmZE42eHJk?=
 =?utf-8?B?cnNKZWxOd2tpdHVhOEJlYkQ4Z1lZYytLM1hZZHZKNWFPejQ3Ym5wWG9uQUd5?=
 =?utf-8?B?WjVoYzFTeXNxYkR5SlVLenBSNXc0dnE5UlY0Wlc1MTVxU2JLa2ZwelJzNWpw?=
 =?utf-8?B?b1h0YkJkaXhrcGU3Z0ZWeHRnR1Q0dUxuY3B6ck9XUEdFYlBIVnNrOGIzOTNh?=
 =?utf-8?B?MHpBL0RCSjE2Zi9JTklKREs3QURaNkEvNmVtcDdXYUxOZWNxT0xSQ1N1V0du?=
 =?utf-8?B?RERBVHF0R1dKV1NMZFJpc1JYL1dhMnZPWFJIcDFhajFId21MTCs0U1M0ZFJU?=
 =?utf-8?B?QmN2R1hzWnNkSXNkZTBRaEVDckhrSzFQQzdTeDdlOEFkK0wzck14dTBYd2F4?=
 =?utf-8?B?aXhteUxYVGdLcWh4akkza3ZlVmozNy9lQlowNVpvYkN5TVIxUjc4SmloNFE2?=
 =?utf-8?B?SnB5dFFaKzJiQllIbkpRY2pDb1RNMmdBcllkb0s0cmlPdkdPcDVrYXFQR0Mz?=
 =?utf-8?B?U0ZmRW5sbWRMU0VtUE91dVdFQlFybEZpRFlFUjZmVUV5ZnBXK0Z1RkFUYmRs?=
 =?utf-8?B?YTFMQnRDZ2JEM01PKzFvamhOZGw4ejVjRGV0SjZ6dngrdmpTS0g4K2hJUnZV?=
 =?utf-8?B?Nng1ZUx3aFVQbWZaajg4Rnp3RVFDY211T05BSHFiZTFYUUVkZVIwajNnM3dH?=
 =?utf-8?B?OG1qYi9zTmdVT2NzK2syd2thWXRBcHhzdWI1ZzdaZzFGN29iSFN1N3FNd0s3?=
 =?utf-8?B?RlFFZGpmOVZhQjBvdU9YR2VqTFd4Z1NOVzkwK3lhRVBxMXY5ZFB3R1liZE5J?=
 =?utf-8?B?Y05lOVpNY2YxZklYMzN0QVVuQ2RuVGVUMHpBSVhKRGRFMU9rd0tTWWNUR0FK?=
 =?utf-8?B?enlPU2NtcUdUSGd0Y1E1MEltL0JkY1pQSy82Q00zU3FuVzJBemY2dGJkOVdQ?=
 =?utf-8?B?Q0NZRGFCSld2SDZ0T2x6d0RZeHpJTjkyUVNVZlZmdmVlRnRsZ2t1Snowbm9v?=
 =?utf-8?B?RXBNZ3lQV1ExaWo4cUpXRXlOOG1ock5TRE11MVZienFIWGNvd2tPY3dNeFV3?=
 =?utf-8?B?d2tzVGxjT1hUeUFJSC9RYWdCVzZrMzVRc3lmNGhmeXBQcGM4OXZJKzVubjIy?=
 =?utf-8?B?d3lKS3FDSmNqU2VqRTBBN1JJR1BKenl2Ym5nZXM1OEZlYUJ3UllJR05MakR5?=
 =?utf-8?B?U0EwMTBuSjB4R2xMejFoK2Z6YTk5QS9Zb1dPWHRSQWpEYmpGSE9oTmpVR2xF?=
 =?utf-8?B?cnI1NE5iYlVMTFBKTmk3ajBzNkdySVAzVlppL1VIRWJIQkZVZmoxaGx2Ui9q?=
 =?utf-8?B?aVByaHhDWEt5NkwzdnhjcWc3aENhdi85Yk0vY1dSR3NCZ0tvMVdwaFJud0M4?=
 =?utf-8?B?OTd0R1d6LzNMNGwrV0VHZzFwbldieXJ6TlFpYVRUdkh2eXprb3Z4NFF6ckty?=
 =?utf-8?B?d1BSdk5UMUQ2MnBYWnV6Y3hUT2Q5T25USzZOaEFUSHVNSTJ3WFlaekVPK1Mw?=
 =?utf-8?B?V281eXVFb1JJelBDd1RjZlR5V0lnNTBZOWp2SCtTVTFzM21Jc2tYVHp6Ny93?=
 =?utf-8?Q?Njy5IKioMHi0bWwkPfjTu4o=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 37c28d98-85a2-4853-c663-08d9f77e728d
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2022 10:14:31.0719
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gCMby4O4FQSbL1+dmus2rPXuQ8CCPmoAH7Doh3yIpTWCj7QQAxkaJA7NJjbEfp61z+sdBdATfB1QKAR3fRhj5A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR0402MB3333

With version 2.7 I'm observing support for binary searches, but
unreliable results: Only a subset of the supposed matches is actually
reported; for our pattern I've never observed any match. This same
version works fine when handing it a Perl regexp using hex or octal
escapes. Probe for support of -P and prefer that over the original
approach.

Fixes: 4d037425dccf ("x86: Build check for embedded endbr64 instructions")
Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
If we were to fear -P having a different meaning elsewhere, we may need
to switch to the respective long option (--perl-regexp).

--- a/xen/tools/check-endbr.sh
+++ b/xen/tools/check-endbr.sh
@@ -24,6 +24,11 @@ BAD=$D/bad-addrs
 echo "X" | grep -aob "X" -q 2>/dev/null ||
     { echo "$MSG_PFX Warning: grep can't do binary searches" >&2; exit 0; }
 
+# Check whether grep supports Perl regexps. Older GNU grep doesn't reliably
+# find binary patterns otherwise.
+perl_re=true
+echo "X" | grep -aobP "\130" -q 2>/dev/null || perl_re=false
+
 #
 # First, look for all the valid endbr64 instructions.
 # A worst-case disassembly, viewed through cat -A, may look like:
@@ -60,8 +65,12 @@ eval $(${OBJDUMP} -j .text $1 -h |
     awk '$2 == ".text" {printf "vma_hi=%s\nvma_lo=%s\n", substr($4, 1, 8), substr($4, 9, 16)}')
 
 ${OBJCOPY} -j .text $1 -O binary $TEXT_BIN
-grep -aob "$(printf '\363\17\36\372')" $TEXT_BIN |
-    awk -F':' '{printf "%s%x\n", "'$vma_hi'", int(0x'$vma_lo') + $1}' > $ALL
+if $perl_re
+then
+    LC_ALL=C grep -aobP '\363\17\36\372' $TEXT_BIN
+else
+    grep -aob "$(printf '\363\17\36\372')" $TEXT_BIN
+fi | awk -F':' '{printf "%s%x\n", "'$vma_hi'", int(0x'$vma_lo') + $1}' > $ALL
 
 # Wait for $VALID to become complete
 wait



From xen-devel-bounces@lists.xenproject.org Thu Feb 24 10:17:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 10:17:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278071.475171 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNBBK-0008H1-2A; Thu, 24 Feb 2022 10:17:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278071.475171; Thu, 24 Feb 2022 10:17:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNBBJ-0008Gu-VL; Thu, 24 Feb 2022 10:17:05 +0000
Received: by outflank-mailman (input) for mailman id 278071;
 Thu, 24 Feb 2022 10:17:04 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=hD/W=TH=arm.com=anshuman.khandual@srs-se1.protection.inumbo.net>)
 id 1nNBBI-0008Gm-M7
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 10:17:04 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id e8a231ef-955a-11ec-8eb8-a37418f5ba1a;
 Thu, 24 Feb 2022 11:17:03 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E30E4ED1;
 Thu, 24 Feb 2022 02:17:01 -0800 (PST)
Received: from [10.163.48.178] (unknown [10.163.48.178])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E609A3F70D;
 Thu, 24 Feb 2022 02:16:54 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e8a231ef-955a-11ec-8eb8-a37418f5ba1a
From: Anshuman Khandual <anshuman.khandual@arm.com>
Subject: Re: [PATCH 10/11] swiotlb: merge swiotlb-xen initialization into
 swiotlb
To: Christoph Hellwig <hch@lst.de>, iommu@lists.linux-foundation.org
Cc: x86@kernel.org, Stefano Stabellini <sstabellini@kernel.org>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>, Juergen Gross
 <jgross@suse.com>, Joerg Roedel <joro@8bytes.org>,
 David Woodhouse <dwmw2@infradead.org>, Lu Baolu <baolu.lu@linux.intel.com>,
 Robin Murphy <robin.murphy@arm.com>, linux-arm-kernel@lists.infradead.org,
 xen-devel@lists.xenproject.org, linux-ia64@vger.kernel.org,
 linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
 linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org,
 linux-hyperv@vger.kernel.org, tboot-devel@lists.sourceforge.net,
 linux-pci@vger.kernel.org
References: <20220222153514.593231-1-hch@lst.de>
 <20220222153514.593231-11-hch@lst.de>
Message-ID: <e5564871-694e-58ea-a355-5d0c3ce5d025@arm.com>
Date: Thu, 24 Feb 2022 15:46:55 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20220222153514.593231-11-hch@lst.de>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 2/22/22 9:05 PM, Christoph Hellwig wrote:
> Allow to pass a remap argument to the swiotlb initialization functions
> to handle the Xen/x86 remap case.  ARM/ARM64 never did any remapping
> from xen_swiotlb_fixup, so we don't even need that quirk.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  arch/arm/xen/mm.c               |  23 +++---
>  arch/x86/include/asm/xen/page.h |   5 --
>  arch/x86/kernel/pci-dma.c       |  27 ++++---
>  arch/x86/pci/sta2x11-fixup.c    |   2 +-
>  drivers/xen/swiotlb-xen.c       | 128 +-------------------------------
>  include/linux/swiotlb.h         |   7 +-
>  include/xen/arm/page.h          |   1 -
>  include/xen/swiotlb-xen.h       |   8 +-
>  kernel/dma/swiotlb.c            | 120 +++++++++++++++---------------
>  9 files changed, 102 insertions(+), 219 deletions(-)

checkpatch.pl has some warnings here.

ERROR: trailing whitespace
#151: FILE: arch/x86/kernel/pci-dma.c:217:
+ $

WARNING: please, no spaces at the start of a line
#151: FILE: arch/x86/kernel/pci-dma.c:217:
+ $

total: 1 errors, 1 warnings, 470 lines checked


From xen-devel-bounces@lists.xenproject.org Thu Feb 24 10:19:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 10:19:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278081.475182 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNBDG-0000WE-Ib; Thu, 24 Feb 2022 10:19:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278081.475182; Thu, 24 Feb 2022 10:19:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNBDG-0000W7-FV; Thu, 24 Feb 2022 10:19:06 +0000
Received: by outflank-mailman (input) for mailman id 278081;
 Thu, 24 Feb 2022 10:19:05 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=hD/W=TH=arm.com=anshuman.khandual@srs-se1.protection.inumbo.net>)
 id 1nNBDF-0000W1-7g
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 10:19:05 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id 30f6b1f7-955b-11ec-8eb8-a37418f5ba1a;
 Thu, 24 Feb 2022 11:19:04 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 44D891476;
 Thu, 24 Feb 2022 02:19:03 -0800 (PST)
Received: from [10.163.48.178] (unknown [10.163.48.178])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BAE743F70D;
 Thu, 24 Feb 2022 02:18:56 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 30f6b1f7-955b-11ec-8eb8-a37418f5ba1a
From: Anshuman Khandual <anshuman.khandual@arm.com>
Subject: Re: [PATCH 07/11] x86: remove the IOMMU table infrastructure
To: Christoph Hellwig <hch@lst.de>, iommu@lists.linux-foundation.org
Cc: x86@kernel.org, Stefano Stabellini <sstabellini@kernel.org>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>, Juergen Gross
 <jgross@suse.com>, Joerg Roedel <joro@8bytes.org>,
 David Woodhouse <dwmw2@infradead.org>, Lu Baolu <baolu.lu@linux.intel.com>,
 Robin Murphy <robin.murphy@arm.com>, linux-arm-kernel@lists.infradead.org,
 xen-devel@lists.xenproject.org, linux-ia64@vger.kernel.org,
 linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
 linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org,
 linux-hyperv@vger.kernel.org, tboot-devel@lists.sourceforge.net,
 linux-pci@vger.kernel.org
References: <20220222153514.593231-1-hch@lst.de>
 <20220222153514.593231-8-hch@lst.de>
Message-ID: <ff355270-b389-0f7a-e384-7c8a9ed9c615@arm.com>
Date: Thu, 24 Feb 2022 15:48:59 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20220222153514.593231-8-hch@lst.de>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit


On 2/22/22 9:05 PM, Christoph Hellwig wrote:
> The IOMMU table tries to separate the different IOMMUs into different
> backends, but actually requires various cross calls.
> 
> Rewrite the code to do the generic swiotlb/swiotlb-xen setup directly
> in pci-dma.c and then just call into the IOMMU drivers.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  arch/ia64/include/asm/iommu_table.h    |   7 --
>  arch/x86/include/asm/dma-mapping.h     |   1 -
>  arch/x86/include/asm/gart.h            |   5 +-
>  arch/x86/include/asm/iommu.h           |   6 ++
>  arch/x86/include/asm/iommu_table.h     | 102 ----------------------
>  arch/x86/include/asm/swiotlb.h         |  30 -------
>  arch/x86/include/asm/xen/swiotlb-xen.h |   2 -
>  arch/x86/kernel/Makefile               |   2 -
>  arch/x86/kernel/amd_gart_64.c          |   5 +-
>  arch/x86/kernel/aperture_64.c          |  14 ++--
>  arch/x86/kernel/pci-dma.c              | 112 ++++++++++++++++++++-----
>  arch/x86/kernel/pci-iommu_table.c      |  77 -----------------
>  arch/x86/kernel/pci-swiotlb.c          |  77 -----------------
>  arch/x86/kernel/tboot.c                |   1 -
>  arch/x86/kernel/vmlinux.lds.S          |  12 ---
>  arch/x86/xen/Makefile                  |   2 -
>  arch/x86/xen/pci-swiotlb-xen.c         |  96 ---------------------
>  drivers/iommu/amd/init.c               |   6 --
>  drivers/iommu/amd/iommu.c              |   5 +-
>  drivers/iommu/intel/dmar.c             |   6 +-
>  include/linux/dmar.h                   |   6 +-
>  21 files changed, 115 insertions(+), 459 deletions(-)
>  delete mode 100644 arch/ia64/include/asm/iommu_table.h
>  delete mode 100644 arch/x86/include/asm/iommu_table.h
>  delete mode 100644 arch/x86/include/asm/swiotlb.h
>  delete mode 100644 arch/x86/kernel/pci-iommu_table.c
>  delete mode 100644 arch/x86/kernel/pci-swiotlb.c
>  delete mode 100644 arch/x86/xen/pci-swiotlb-xen.c

checkpatch.pl has some warnings here.

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#44: 
deleted file mode 100644

WARNING: Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(...  to printk(KERN_INFO ...
#496: FILE: arch/x86/kernel/pci-dma.c:171:
+               printk(KERN_INFO "PCI-DMA: "

WARNING: quoted string split across lines
#497: FILE: arch/x86/kernel/pci-dma.c:172:
+               printk(KERN_INFO "PCI-DMA: "
+                      "Using software bounce buffering for IO (SWIOTLB)\n");

ERROR: trailing whitespace
#881: FILE: drivers/iommu/amd/iommu.c:1837:
+^Iif (iommu_default_passthrough() || sme_me_mask) $

total: 1 errors, 3 warnings, 389 lines checked


From xen-devel-bounces@lists.xenproject.org Thu Feb 24 10:21:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 10:21:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278089.475193 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNBFg-0001tk-21; Thu, 24 Feb 2022 10:21:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278089.475193; Thu, 24 Feb 2022 10:21:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNBFf-0001td-Tf; Thu, 24 Feb 2022 10:21:35 +0000
Received: by outflank-mailman (input) for mailman id 278089;
 Thu, 24 Feb 2022 10:21:34 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nNBFe-0001tT-IN; Thu, 24 Feb 2022 10:21:34 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nNBFe-0002r0-DN; Thu, 24 Feb 2022 10:21:34 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nNBFd-000376-Om; Thu, 24 Feb 2022 10:21:33 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nNBFd-0005QP-O0; Thu, 24 Feb 2022 10:21:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=92t2Oa2Xus0BGYz+kW+LVMPELTZ3Zt8Cc4C+dlBM4Y4=; b=nRbglzp7KZwvpYrzfoSiYmee/A
	EqheWyuLG9ZQyrFYS2ixUOV1IN52FjO4aixwwoymfjur32LCHlbMTzCoVqZqNacVNl1BeQYUaoP9Z
	YBjWH0fDszb59E20s1H/xAKkAXR4WgO6dVpo3ryNSo7Yrz1LMjEgXpQfzSJWm9tsrJVY=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168212-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 168212: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=32b9d8b0ae00669555f01f91ee11612a636c4b69
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 24 Feb 2022 10:21:33 +0000

flight 168212 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168212/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              32b9d8b0ae00669555f01f91ee11612a636c4b69
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  594 days
Failing since        151818  2020-07-11 04:18:52 Z  593 days  575 attempts
Testing same since   168212  2022-02-24 04:21:36 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brad Laue <brad@brad-x.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Christophe Fergeau <cfergeau@redhat.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Divya Garg <divya.garg@nutanix.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Emilio Herrera <ehespinosa57@gmail.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Ivan Teterevkov <ivan.teterevkov@nutanix.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jing Qi <jinqi@redhat.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Lubomir Rintel <lkundrak@v3.sk>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nicolas Lécureuil <neoclust@mageia.org>
  Nicolas Lécureuil <nicolas.lecureuil@siveo.net>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Rohit Kumar <rohit.kumar3@nutanix.com>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  shenjiatong <yshxxsjt715@gmail.com>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tu Qiang <tu.qiang35@zte.com.cn>
  Tuguoyi <tu.guoyi@h3c.com>
  tuqiang <tu.qiang35@zte.com.cn>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Vineeth Pillai <viremana@linux.microsoft.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yasuhiko Kamata <belphegor@belbel.or.jp>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 98975 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Feb 24 10:22:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 10:22:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278099.475204 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNBGJ-0002QS-BG; Thu, 24 Feb 2022 10:22:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278099.475204; Thu, 24 Feb 2022 10:22:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNBGJ-0002QL-8D; Thu, 24 Feb 2022 10:22:15 +0000
Received: by outflank-mailman (input) for mailman id 278099;
 Thu, 24 Feb 2022 10:22:14 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=oTFz=TH=citrix.com=prvs=047b345d9=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nNBGH-0002Ks-NP
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 10:22:13 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9fda5e1c-955b-11ec-8eb8-a37418f5ba1a;
 Thu, 24 Feb 2022 11:22:11 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9fda5e1c-955b-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645698131;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=0FwQSj+Arevjf2KS6yFNQQyXSOwzVDu7YgXqdMuQvho=;
  b=WDLJAepD8Qyw5PTWoQlHi4PXOxMO93gql8UqO4V0Kd5W3DN7RSKByOLu
   CPCkoTkqNw/anD7CLanLRbAKmPtkGPR7Ciid5qe/AQhswlHrJHfQGfUQC
   i+H0qsb06+UwzuA23JbHUf/o7o4oFK/tVDU71GPCtiiXTC+e2lAZugG+d
   g=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 64890043
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:d0daLqBvWLRfJRVW/zvjw5YqxClBgxIJ4kV8jS/XYbTApG5w0zMFx
 2ZJCmuGb/2NM2Dyfoh2a9i+o0IDv5KGmNcyQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YhFWeIdA970Ug5w7Rj3tYx6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhWl
 fVTm7OLRj4IYI+Rn9ZHQwNVN35XaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguwKKsXxMZxZkXZn1TzDVt4tQIzZQrWM7thdtNs1rp4STaeGP
 5ZCAdZpRAXLRRJ/PUotMbAdx9qEqXflNCN3713A8MLb5ECMlVcsgdABKuH9ZdiiVchT2EGCq
 Qru72n/Rx0XKtGb4T6E6W63wP/CmzvhX4AfH6H+8eRl6HWRzGEODBwdVXOgvOK0zEW5Xrpix
 1c8o3R06/JorQryE4e7D0bQTGO4UgA0fIdwDcMV0w606/T2vgGrXHgeQxoeQYlz3CMpfgAC2
 liMltLvIDVgtryJVH6QnoupQSOO1Ts9djFbO3JdJecRy5y6+dxo0EqTJjp2OPPt1rXI9SfML
 ydmRcTUr5EaloY12qqy5jgraBr898GSHmbZCug6N19JDz+Vhqb4P+RECnCBtJ6sybp1qHHb4
 hDofODEsYgz4WmlznDlfQn0NOjBCwy5GDPdm0VzOJIq6i6g/XWuFagJvm0jehszbpxfJmeyC
 KM2he+3zMUNVJdNRfUqC79d9uxwlfSwfTgbfqq8giVyjmhZK1bcoXAGib+41GHxikk8+ZzTy
 r/AGftA+U0yUPw9pBLvHr91+eZymkgWmDOCLbimnk/P+efPOxaopUItbQLmghYRt/jf/m04M
 r93aqO39vmoeLegOnKOqdZLdzjn7xETXPjLliCeTcbaSiJOE2A9Ef7Bh7Qnfo1uhaNOkenUu
 Hq6XydlJJDX1RUr9S3ihqhfVY7S
IronPort-HdrOrdr: A9a23:gCm0D6v3G+wgFp4pQDIFceJ27skC2IMji2hC6mlwRA09TyXGra
 +TdaUguSMc1gx9ZJh5o6H8BEGBKUmskKKceeEqTPiftXrdyReVxeZZnMXfKlzbamHDH4tmu5
 uIHJIOceEYYWIK7voSpTPIaerIo+P3sZxA592ut0uFJDsCA8oLjmdE40SgYzZLrWF9dMEE/f
 Gnl656Tk+bCBIqh7OAdx44tob41r/2vaOjRSRDKw8s6QGIgz/twqX9CQKk0hAXVC4K6as+8E
 De+jaJppmLgrWe8FvxxmXT55NZlJ/K0d1YHvGBjcATN3HFlhuoXoJ8QLeP1QpF491HqWxa0u
 UkkS1Qe/ib2EmhOV1dZiGdnTUI5QxerkMKD2Xo2EcL7/aJHA7SQPAx+r6xOiGplXbI+usMip
 6jlljpx6a+R3n77VXAzsmNWBdwmkWup30+1eYVknxESIMbLKRctIoF4SpuYdw99Q/Bmcka+d
 NVfYnhDTdtACenRmGcunMqzM2nX3w1EBvDSk8eutaN2zwTmHxi1UMXyMEWg39FrfsGOtR5zv
 WBNr4tmKBFT8cQY644DOAdQdGvAmiIRR7XKmqdLVnuCalCMXPQrJz85qkz+YiRCdY15Yp3nI
 6EXEJTtGY0dU6rAcqS3IdT+hSIW2m5VSSF8LAp23G4gMyKeFPGC1zwdLl1qbrSnxw2OLyvZ8
 qO
X-IronPort-AV: E=Sophos;i="5.88,393,1635220800"; 
   d="scan'208";a="64890043"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=M4p4D4qXCDRo5/FcmycoEEaA1DhBPII7bzeIIEpi1vTzWgMgH1iaeyg+19b7wh6l+mFwD/7iZ1xnK0/LueimtXcltmRJEfYBPG4ZXrsR7Y5ZWQ2+zm2jaRRmykU7HB6sgLoqIKiPt7Th59B3A9n0Yj82MQgHtyNaVilZaD5dAABecCa4cIiBIagwX/5axmjVA6TAWvISqtFlarEm5BABJWgE2IcSOWk/Io/eLAW5BHBhrL5yzNqqVrGnbeGH3bNGJDmPpOFrj1l2TWuP5uDYOw9eBW05tLmh+FYfYUMVWCUEEFwtqrvPYCIYMGP2w7sH0OB3HEptJ1+TwGSitpFwgw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=0FwQSj+Arevjf2KS6yFNQQyXSOwzVDu7YgXqdMuQvho=;
 b=av0ybdnZDvpbDYYfsT7ncs6mSb9IuC+8orJv1R9m1Ui+fIVNg+D76WmHpNAkk0TC0bcV250Yt5d5WLyCpFzQNNFXmmHo95y7faULCyRRIqEJSbpeFLhpBGJRw/yazzpVyg0KPfgBscQvaUTj/ja5h0cU95pMlMl/pK6ZncHaoLxZ0aTTuVi/rfpfak+/Z1ApjhKFsEB0p6qP4wYOOuE4dqWVHcBvWjIZLSAh/6i+kzvNidn99qTEv9ye5U8U9bmH0xMW40mEtbUz3lYalYJ0YfrRQVRXKdsfooK9f/H/QPHlegFpnwW63dMRBac0y49OoOdCViVT98bjHOAaBAFRaQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=0FwQSj+Arevjf2KS6yFNQQyXSOwzVDu7YgXqdMuQvho=;
 b=fLFOtQ6dqCQlVYa2W6g1JBeUmC7yAxInWUPi5eeBncima5oiu3LgmLfIaQMI9DrktTxJOxt7kNEot20WEJbPPkI50ZuBM72aUs5tpfkchiFPqJkD8UvgCWaNwPbU6vIlIItAvZL3hGwN70U+h2uSaHW4BUbYYKWXC/mrbg7srx4=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Wei Liu <wl@xen.org>, Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH] x86: make embedded endbr64 check compatible with older
 GNU grep
Thread-Topic: [PATCH] x86: make embedded endbr64 check compatible with older
 GNU grep
Thread-Index: AQHYKWdr96DvHtmiCE6n5nuoqf1KFayifeMA
Date: Thu, 24 Feb 2022 10:21:56 +0000
Message-ID: <cced4ec0-f522-9273-b10c-0e652bcc5aa3@citrix.com>
References: <ceaae3c8-0c35-efc1-c7bc-f44364ce29e4@suse.com>
In-Reply-To: <ceaae3c8-0c35-efc1-c7bc-f44364ce29e4@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 41b8c0a2-f772-48ef-7a33-08d9f77f7c17
x-ms-traffictypediagnostic: BN9PR03MB5977:EE_
x-microsoft-antispam-prvs: <BN9PR03MB5977EDB5F0C0E6A88038BBDFBA3D9@BN9PR03MB5977.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: IFvSDjWHvV3eDOvGGzOMHpDYp5liAb1Z5oQ4sCu1qVb9aAeFFD8tQl+5r1cYG20O9p78nMneunSVwjx4ieRXHGIywxVTeQlykbKjsMSXfwtDHifykTuWGb5DVBZHZfbei5ehHhSNANZlzEAs5Hk67htK9tAK0tdW4AD3o0dmBWZIY6y/rszUD72swsdIWJPM1qYim/R7vjHb5u6kQkAH8/D6QuWk1AQTaFxtlxtnTNWkUDG7EaBExLV8NFfWim/IS4p/89v6+kYdaEPTPuhsNI3V5xoFL9hdDRZOwFOEzPe9d4HAX/O8ZK5mB7i+GJj7N+TavnMZRaQO9Nx9x1qO1DVhedBQbixOYQNAd6nj3IhHWrCXWSCNVVkoYogkweqiYsYqHwPJepwbAu65Al3cpXtPsWcWVU4JaDqTfVN96Sp5CcxCbqkGaNFFmzy11CLDdhQYNDRbAn1VStIHWLCWCu4s4SaBoyv/DUeSzuPkdGjiGPUqLjxpDGUvj6ta3+0L9MTpwTUKaAsXbCM6J2/AjlFDQVtcLom4AITjwD7dqb/Fq61pLINczGkVrIb3QnesYP4sZyrLCDVgx5MefJAa8URDqj9GJImZBuy/tMnUX2sX0g727C57SMIMZHOjsr2vnLHt0tI9Pv56gEV+eWKn2U2FrmlViXCPKJLCxO6JpLlpkxEzrJDcZE877Dkz4cOOwZV6PR5/tpIg/jG51Ieg0+t81FDggVmBkpABLN4mPOgCeUl8m/0kEglvzTx1/E7Vz5LC4EK8KnWA9aK0XC2beA==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(122000001)(2616005)(26005)(53546011)(186003)(4744005)(6506007)(6512007)(107886003)(36756003)(71200400001)(5660300002)(110136005)(54906003)(86362001)(316002)(31696002)(66476007)(66946007)(38070700005)(4326008)(508600001)(76116006)(2906002)(38100700002)(82960400001)(31686004)(8936002)(64756008)(66446008)(66556008)(6486002)(91956017)(8676002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?dEZrL25CZjc2OElMeWR6c1I4Z256UTB3c0ViT1lqQ1RZMkhmTzJBSDFWTXBC?=
 =?utf-8?B?cHZmdStyL2hzNnUyOXdIcU9kckJmZDZSRTN1VHdLaEU2eXFnbTg3dXNpRWtD?=
 =?utf-8?B?YkYybmpWRFNrU1JMbmpvYnhxNmJWWDV6bEcvWlBvZE15YVUzbjlJRFMwWVZ2?=
 =?utf-8?B?dVZBODFvaFVsejVsQlQwMThHVUI2aUFvWU1oelNtWms0dUtWdENmTTRmWHJw?=
 =?utf-8?B?U3VjdHhxOTAremZHczlrbVp1NERuQmM5bEUrb1hIK1VXbEhVWEswWVBoZGhW?=
 =?utf-8?B?YmVJVmlkRUlYZkh3OGtTQUZ2SzR2SW9sZDdobmorN0s2bVp3a1FvMmo2cnhE?=
 =?utf-8?B?M3dRV2VONW02SmVEZ1ZaNnhLOFY3TWdsM1RzQkFGMmpPRDVyMStpZW9ReURh?=
 =?utf-8?B?aXZQTElhS3YyYWh1TkF0eWwvOEkxSExJVXh5OUpELzZISElSMXpDOVNOeTNL?=
 =?utf-8?B?K29uMitWN2tnOVV3K0R0aFZiVFAwYmZvaEpVTTBnQ1dFMHJLS3BwVWRlb2xG?=
 =?utf-8?B?Y1g3U1puOS9SR1NKRjhvMWtXK1pHcmNGVUtFeFM3ZDJnc3F2Rml5Ry84Zyt2?=
 =?utf-8?B?ak5pK251WmRIRCtiUy83MGxaV1E1SFF6Vy9PZ1NPd05acFF3Z0pyekFzQlJ4?=
 =?utf-8?B?Yit2ODJhMjlEQVhKTjlpV1pYMlF0MUFhS1J5ZCtEVHhRMTgvYnk2bmFKR2hQ?=
 =?utf-8?B?WnRWMkNiVkswckFmRnAvYVQ1dC84UU9lNzlTYzlYZnVscnJEN1FzZXlVa25m?=
 =?utf-8?B?M2xxNWpzdXRwdmI5Qk1pK3puaFRSaUVJUSs4Z3N5NEVibDh2VnBjUXgzQk5S?=
 =?utf-8?B?RldHWFAxWE5XNFR5UGNLVW1ZRE5iZFBNWi82K0JqYkUvYTVSZkNXcmk5SXdC?=
 =?utf-8?B?cy9XamhaaGc1N0NiOE8rdHRaUXdscitRUlB1WEtMNjBOemZZdFlUV3kramg5?=
 =?utf-8?B?VmhRMVZDNEhwZTFxZUlobjhrbm1KeVUwa1JCVGdoMGRScjNJeS9lbjlBVjlS?=
 =?utf-8?B?akJNODJZSEpRSVdYRk1nRjFIWDB1VWUveGxqK29CUTYwMktSMVYwZlRGNFJV?=
 =?utf-8?B?ODRwTHhQY3daMnRKMEhEdG9QSGo0ekU1WEw1U0VGVTF1b1ptbndLb01xQkpZ?=
 =?utf-8?B?ZHpLdXN4d3dPRzRTbEN0TjB6RU5jaHlCbEJ1S1lqUlBrVHR2YmliendnaGNn?=
 =?utf-8?B?N3F3OEN0ek1yVXZiS2ttZWJRbDVWOWtuKzgrNUJvN1dORlZRY2UwSjV0c0pB?=
 =?utf-8?B?Y3UwSEZjQWYrd05FZnVNemFER1VyR2RNQlozVnRRaFBRNGNqV1pSOE5kSWpx?=
 =?utf-8?B?eTViUGN6QjFYNktaTjRGbHhkNHFpaE1tc1p5N3E3RVY3WE5ZRXoyN2E3djkz?=
 =?utf-8?B?T0w3dTUzMjJBc1FrWUZvYWxhUVF0czlJai9DMzZpdTU2NGpkUWxtYW9tOFBV?=
 =?utf-8?B?aXBuZmc5azkwSkhydmwwZ0FkTU9WZ1RPeHB3NE1HdlVPbCtZdkg3UW1MTlYv?=
 =?utf-8?B?ZGUzMDFFdkFZWTFVckw2Tkxkdk11UUdUYW5UMENlejF0OHlVL3Ixa0ZLNzlt?=
 =?utf-8?B?Nkg3RWJ5S3o4TDFINVBRTHlPc3JTK2RnQVlVWXNoUGFVV0VGUW8xZjVPTHpE?=
 =?utf-8?B?bS9JbWEzb1EraTQ3WG5BYlVvckU4YlRWemNybkkvMmU2bG5yOFhFdDBCVU9p?=
 =?utf-8?B?bXZ4UWZGSWVYZllVKzg5cTE4ZUJKa3k0WkVOSW5lQlRGUmJUV1kwNXl3OS9Z?=
 =?utf-8?B?aXM2Tm9hbkIwNGFPVHBWTjA1SUJYZUFaSXZVUU9iOWczTWlOMHZ2RFgzNDQ1?=
 =?utf-8?B?UVIvcUxLVTlTbEV2Vm90RisrQ2lvakVmOWRkbUZ0cW50NnN5Z2F5Ukl2Zmcv?=
 =?utf-8?B?SmJueDg2NDErdVRCZ2FsU3Y3L2NFWmV5R2xQbGhKVm9ZVXk5ZlZiTWk1RWEx?=
 =?utf-8?B?Z2FDRERDTk9iUVBUYnJtMFVhNTRoanFDdzFkdzRkWEx6dnpBTFRUbXNLb3BL?=
 =?utf-8?B?STdjMlRDUlF5ancxQkEyVkNWSWIybVVDY3JjSUpleXVTV0MyYkNhRHg0dXZj?=
 =?utf-8?B?TmYxdVdMMmZsTGVST2ZYK0lRT01VdThVeDZtZ2RoS2RjUFhFV0Q0a1J0dUJr?=
 =?utf-8?B?TGNYZHhoK2JKZGhwWmxkdUVuSzcydGkwdWhQZDFXcnFaSzJzRnRmVW11ZEVR?=
 =?utf-8?B?T0RCR0NyWnpUemxhMWRrU3lrQ3NBNjEzSGlNVWlEK0NzMVhpbms2My9ISzRl?=
 =?utf-8?B?QkkveDJoczRlK21pdkFBd056blVBPT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <56944AD7B3533B43853EA5D4235514CC@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 41b8c0a2-f772-48ef-7a33-08d9f77f7c17
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Feb 2022 10:21:56.3675
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: m8g/XYEblcPda+tkZkyFn1LVAFKsKReQEwzNmcJflZdHdhByvA+tzsjPQz6JZ4Awzt5sI0Ik4jIVDhlFj+5UJTe9fprq42blIKu4tjGVCzg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR03MB5977
X-OriginatorOrg: citrix.com

T24gMjQvMDIvMjAyMiAxMDoxNCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IFdpdGggdmVyc2lvbiAy
LjcgSSdtIG9ic2VydmluZyBzdXBwb3J0IGZvciBiaW5hcnkgc2VhcmNoZXMsIGJ1dA0KPiB1bnJl
bGlhYmxlIHJlc3VsdHM6IE9ubHkgYSBzdWJzZXQgb2YgdGhlIHN1cHBvc2VkIG1hdGNoZXMgaXMg
YWN0dWFsbHkNCj4gcmVwb3J0ZWQ7IGZvciBvdXIgcGF0dGVybiBJJ3ZlIG5ldmVyIG9ic2VydmVk
IGFueSBtYXRjaC4gVGhpcyBzYW1lDQo+IHZlcnNpb24gd29ya3MgZmluZSB3aGVuIGhhbmRpbmcg
aXQgYSBQZXJsIHJlZ2V4cCB1c2luZyBoZXggb3Igb2N0YWwNCj4gZXNjYXBlcy4gUHJvYmUgZm9y
IHN1cHBvcnQgb2YgLVAgYW5kIHByZWZlciB0aGF0IG92ZXIgdGhlIG9yaWdpbmFsDQo+IGFwcHJv
YWNoLg0KPg0KPiBGaXhlczogNGQwMzc0MjVkY2NmICgieDg2OiBCdWlsZCBjaGVjayBmb3IgZW1i
ZWRkZWQgZW5kYnI2NCBpbnN0cnVjdGlvbnMiKQ0KPiBTaWduZWQtb2ZmLWJ5OiBKYW4gQmV1bGlj
aCA8amJldWxpY2hAc3VzZS5jb20+DQoNCkxvb2tzIHBsYXVzaWJsZS7CoCBUZW50YXRpdmUgYWNr
LCBidXQgdGhpcyBkZWZpbml0ZWx5IG5lZWRzIGEgZnVsbCBydW4NCnRocm91Z2ggQ0kgYmVmb3Jl
IGNvbW1pdHRpbmcuwqAgTGV0IG1lIGtpY2sgc29tZXRoaW5nIG9mZi4NCg0KPiAtLS0NCj4gSWYg
d2Ugd2VyZSB0byBmZWFyIC1QIGhhdmluZyBhIGRpZmZlcmVudCBtZWFuaW5nIGVsc2V3aGVyZSwg
d2UgbWF5IG5lZWQNCj4gdG8gc3dpdGNoIHRvIHRoZSByZXNwZWN0aXZlIGxvbmcgb3B0aW9uICgt
LXBlcmwtcmVnZXhwKS4NCg0KV2UgY2FuIHByb2JhYmx5IGdldCBhd2F5IHdpdGggLVAuDQoNCn5B
bmRyZXcNCg==


From xen-devel-bounces@lists.xenproject.org Thu Feb 24 10:27:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 10:27:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278109.475215 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNBKx-0003Fm-1C; Thu, 24 Feb 2022 10:27:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278109.475215; Thu, 24 Feb 2022 10:27:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNBKw-0003Ff-UO; Thu, 24 Feb 2022 10:27:02 +0000
Received: by outflank-mailman (input) for mailman id 278109;
 Thu, 24 Feb 2022 10:27:02 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=hD/W=TH=arm.com=anshuman.khandual@srs-se1.protection.inumbo.net>)
 id 1nNBKw-0003FZ-As
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 10:27:02 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id 4d735ccf-955c-11ec-8eb8-a37418f5ba1a;
 Thu, 24 Feb 2022 11:27:01 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 98A7B14BF;
 Thu, 24 Feb 2022 02:27:00 -0800 (PST)
Received: from [10.163.48.178] (unknown [10.163.48.178])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4B93F3F70D;
 Thu, 24 Feb 2022 02:26:54 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4d735ccf-955c-11ec-8eb8-a37418f5ba1a
From: Anshuman Khandual <anshuman.khandual@arm.com>
Subject: Re: [PATCH 01/11] dma-direct: use is_swiotlb_active in
 dma_direct_map_page
To: Christoph Hellwig <hch@lst.de>, iommu@lists.linux-foundation.org
Cc: x86@kernel.org, Stefano Stabellini <sstabellini@kernel.org>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>, Juergen Gross
 <jgross@suse.com>, Joerg Roedel <joro@8bytes.org>,
 David Woodhouse <dwmw2@infradead.org>, Lu Baolu <baolu.lu@linux.intel.com>,
 Robin Murphy <robin.murphy@arm.com>, linux-arm-kernel@lists.infradead.org,
 xen-devel@lists.xenproject.org, linux-ia64@vger.kernel.org,
 linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
 linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org,
 linux-hyperv@vger.kernel.org, tboot-devel@lists.sourceforge.net,
 linux-pci@vger.kernel.org
References: <20220222153514.593231-1-hch@lst.de>
 <20220222153514.593231-2-hch@lst.de>
Message-ID: <29452ad3-9db9-49d5-f91c-cb8507633ec0@arm.com>
Date: Thu, 24 Feb 2022 15:56:56 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20220222153514.593231-2-hch@lst.de>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit



On 2/22/22 9:05 PM, Christoph Hellwig wrote:
> Use the more specific is_swiotlb_active check instead of checking the
> global swiotlb_force variable.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  kernel/dma/direct.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/dma/direct.h b/kernel/dma/direct.h
> index 4632b0f4f72eb..4dc16e08c7e1a 100644
> --- a/kernel/dma/direct.h
> +++ b/kernel/dma/direct.h
> @@ -91,7 +91,7 @@ static inline dma_addr_t dma_direct_map_page(struct device *dev,
>  		return swiotlb_map(dev, phys, size, dir, attrs);
>  
>  	if (unlikely(!dma_capable(dev, dma_addr, size, true))) {
> -		if (swiotlb_force != SWIOTLB_NO_FORCE)
> +		if (is_swiotlb_active(dev))
>  			return swiotlb_map(dev, phys, size, dir, attrs);
>  
>  		dev_WARN_ONCE(dev, 1,
> 

Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>


From xen-devel-bounces@lists.xenproject.org Thu Feb 24 10:29:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 10:29:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278116.475226 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNBMy-0003qb-Cc; Thu, 24 Feb 2022 10:29:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278116.475226; Thu, 24 Feb 2022 10:29:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNBMy-0003qU-9b; Thu, 24 Feb 2022 10:29:08 +0000
Received: by outflank-mailman (input) for mailman id 278116;
 Thu, 24 Feb 2022 10:29:06 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=hD/W=TH=arm.com=anshuman.khandual@srs-se1.protection.inumbo.net>)
 id 1nNBMw-0003qJ-HE
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 10:29:06 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id 977fa540-955c-11ec-8eb8-a37418f5ba1a;
 Thu, 24 Feb 2022 11:29:05 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CDCB91509;
 Thu, 24 Feb 2022 02:29:04 -0800 (PST)
Received: from [10.163.48.178] (unknown [10.163.48.178])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5F68A3F70D;
 Thu, 24 Feb 2022 02:28:58 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 977fa540-955c-11ec-8eb8-a37418f5ba1a
From: Anshuman Khandual <anshuman.khandual@arm.com>
Subject: Re: [PATCH 02/11] swiotlb: make swiotlb_exit a no-op if SWIOTLB_FORCE
 is set
To: Christoph Hellwig <hch@lst.de>, iommu@lists.linux-foundation.org
Cc: x86@kernel.org, Stefano Stabellini <sstabellini@kernel.org>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>, Juergen Gross
 <jgross@suse.com>, Joerg Roedel <joro@8bytes.org>,
 David Woodhouse <dwmw2@infradead.org>, Lu Baolu <baolu.lu@linux.intel.com>,
 Robin Murphy <robin.murphy@arm.com>, linux-arm-kernel@lists.infradead.org,
 xen-devel@lists.xenproject.org, linux-ia64@vger.kernel.org,
 linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
 linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org,
 linux-hyperv@vger.kernel.org, tboot-devel@lists.sourceforge.net,
 linux-pci@vger.kernel.org
References: <20220222153514.593231-1-hch@lst.de>
 <20220222153514.593231-3-hch@lst.de>
Message-ID: <b769ddc8-5ba3-b7a9-b295-92507a73c0d6@arm.com>
Date: Thu, 24 Feb 2022 15:59:00 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20220222153514.593231-3-hch@lst.de>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit



On 2/22/22 9:05 PM, Christoph Hellwig wrote:
> If force bouncing is enabled we can't release the bufffers.

typo							^^^^

> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  kernel/dma/swiotlb.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c
> index f1e7ea160b433..36fbf1181d285 100644
> --- a/kernel/dma/swiotlb.c
> +++ b/kernel/dma/swiotlb.c
> @@ -378,6 +378,9 @@ void __init swiotlb_exit(void)
>  	unsigned long tbl_vaddr;
>  	size_t tbl_size, slots_size;
>  
> +	if (swiotlb_force == SWIOTLB_FORCE)
> +		return;
> +
>  	if (!mem->nslabs)
>  		return;
>  
> 

Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>


From xen-devel-bounces@lists.xenproject.org Thu Feb 24 10:34:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 10:34:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278130.475261 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNBRr-0005Xl-8E; Thu, 24 Feb 2022 10:34:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278130.475261; Thu, 24 Feb 2022 10:34:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNBRr-0005Xc-4y; Thu, 24 Feb 2022 10:34:11 +0000
Received: by outflank-mailman (input) for mailman id 278130;
 Thu, 24 Feb 2022 10:34:09 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=hD/W=TH=arm.com=anshuman.khandual@srs-se1.protection.inumbo.net>)
 id 1nNBRp-0005XU-IY
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 10:34:09 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 4b69642c-955d-11ec-8539-5f4723681683;
 Thu, 24 Feb 2022 11:34:07 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B8EB31476;
 Thu, 24 Feb 2022 02:34:06 -0800 (PST)
Received: from [10.163.48.178] (unknown [10.163.48.178])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6169E3F70D;
 Thu, 24 Feb 2022 02:34:00 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4b69642c-955d-11ec-8539-5f4723681683
From: Anshuman Khandual <anshuman.khandual@arm.com>
Subject: Re: [PATCH 03/11] swiotlb: simplify swiotlb_max_segment
To: Christoph Hellwig <hch@lst.de>, iommu@lists.linux-foundation.org
Cc: x86@kernel.org, Stefano Stabellini <sstabellini@kernel.org>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>, Juergen Gross
 <jgross@suse.com>, Joerg Roedel <joro@8bytes.org>,
 David Woodhouse <dwmw2@infradead.org>, Lu Baolu <baolu.lu@linux.intel.com>,
 Robin Murphy <robin.murphy@arm.com>, linux-arm-kernel@lists.infradead.org,
 xen-devel@lists.xenproject.org, linux-ia64@vger.kernel.org,
 linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
 linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org,
 linux-hyperv@vger.kernel.org, tboot-devel@lists.sourceforge.net,
 linux-pci@vger.kernel.org
References: <20220222153514.593231-1-hch@lst.de>
 <20220222153514.593231-4-hch@lst.de>
Message-ID: <9ef33986-eba0-01ee-28b6-1104e60c313d@arm.com>
Date: Thu, 24 Feb 2022 16:04:02 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20220222153514.593231-4-hch@lst.de>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit



On 2/22/22 9:05 PM, Christoph Hellwig wrote:
> Remove the bogus Xen override that was usually larger than the actual
> size and just calculate the value on demand.  Note that
> swiotlb_max_segment still doesn't make sense as an interface and should
> eventually be removed.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  drivers/xen/swiotlb-xen.c |  2 --
>  include/linux/swiotlb.h   |  1 -
>  kernel/dma/swiotlb.c      | 20 +++-----------------
>  3 files changed, 3 insertions(+), 20 deletions(-)
> 
> diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c
> index 47aebd98f52f5..485cd06ed39e7 100644
> --- a/drivers/xen/swiotlb-xen.c
> +++ b/drivers/xen/swiotlb-xen.c
> @@ -202,7 +202,6 @@ int xen_swiotlb_init(void)
>  	rc = swiotlb_late_init_with_tbl(start, nslabs);
>  	if (rc)
>  		return rc;
> -	swiotlb_set_max_segment(PAGE_SIZE);
>  	return 0;
>  error:
>  	if (nslabs > 1024 && repeat--) {
> @@ -254,7 +253,6 @@ void __init xen_swiotlb_init_early(void)
>  
>  	if (swiotlb_init_with_tbl(start, nslabs, true))
>  		panic("Cannot allocate SWIOTLB buffer");
> -	swiotlb_set_max_segment(PAGE_SIZE);
>  }
>  #endif /* CONFIG_X86 */
>  
> diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h
> index f6c3638255d54..9fb3a568f0c51 100644
> --- a/include/linux/swiotlb.h
> +++ b/include/linux/swiotlb.h
> @@ -164,7 +164,6 @@ static inline void swiotlb_adjust_size(unsigned long size)
>  #endif /* CONFIG_SWIOTLB */
>  
>  extern void swiotlb_print_info(void);
> -extern void swiotlb_set_max_segment(unsigned int);
>  
>  #ifdef CONFIG_DMA_RESTRICTED_POOL
>  struct page *swiotlb_alloc(struct device *dev, size_t size);
> diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c
> index 36fbf1181d285..519e363097190 100644
> --- a/kernel/dma/swiotlb.c
> +++ b/kernel/dma/swiotlb.c
> @@ -75,12 +75,6 @@ struct io_tlb_mem io_tlb_default_mem;
>  
>  phys_addr_t swiotlb_unencrypted_base;
>  
> -/*
> - * Max segment that we can provide which (if pages are contingous) will
> - * not be bounced (unless SWIOTLB_FORCE is set).
> - */
> -static unsigned int max_segment;
> -
>  static unsigned long default_nslabs = IO_TLB_DEFAULT_SIZE >> IO_TLB_SHIFT;
>  
>  static int __init
> @@ -104,18 +98,12 @@ early_param("swiotlb", setup_io_tlb_npages);
>  
>  unsigned int swiotlb_max_segment(void)
>  {
> -	return io_tlb_default_mem.nslabs ? max_segment : 0;
> +	if (!io_tlb_default_mem.nslabs)
> +		return 0;
> +	return rounddown(io_tlb_default_mem.nslabs << IO_TLB_SHIFT, PAGE_SIZE);
>  }
>  EXPORT_SYMBOL_GPL(swiotlb_max_segment);
>  
> -void swiotlb_set_max_segment(unsigned int val)
> -{
> -	if (swiotlb_force == SWIOTLB_FORCE)
> -		max_segment = 1;
> -	else
> -		max_segment = rounddown(val, PAGE_SIZE);
> -}
> -
>  unsigned long swiotlb_size_or_default(void)
>  {
>  	return default_nslabs << IO_TLB_SHIFT;
> @@ -267,7 +255,6 @@ int __init swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, int verbose)
>  
>  	if (verbose)
>  		swiotlb_print_info();
> -	swiotlb_set_max_segment(mem->nslabs << IO_TLB_SHIFT);
>  	return 0;
>  }
>  
> @@ -368,7 +355,6 @@ swiotlb_late_init_with_tbl(char *tlb, unsigned long nslabs)
>  	swiotlb_init_io_tlb_mem(mem, virt_to_phys(tlb), nslabs, true);
>  
>  	swiotlb_print_info();
> -	swiotlb_set_max_segment(mem->nslabs << IO_TLB_SHIFT);
>  	return 0;
>  }
>  

Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>


From xen-devel-bounces@lists.xenproject.org Thu Feb 24 10:36:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 10:36:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278137.475272 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNBTk-0006AS-Ka; Thu, 24 Feb 2022 10:36:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278137.475272; Thu, 24 Feb 2022 10:36:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNBTk-0006AK-Gk; Thu, 24 Feb 2022 10:36:08 +0000
Received: by outflank-mailman (input) for mailman id 278137;
 Thu, 24 Feb 2022 10:36:07 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=hD/W=TH=arm.com=anshuman.khandual@srs-se1.protection.inumbo.net>)
 id 1nNBTj-00069Z-9u
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 10:36:07 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id 921ea0b1-955d-11ec-8eb8-a37418f5ba1a;
 Thu, 24 Feb 2022 11:36:06 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 560AAED1;
 Thu, 24 Feb 2022 02:36:05 -0800 (PST)
Received: from [10.163.48.178] (unknown [10.163.48.178])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 13A2D3F70D;
 Thu, 24 Feb 2022 02:35:58 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 921ea0b1-955d-11ec-8eb8-a37418f5ba1a
From: Anshuman Khandual <anshuman.khandual@arm.com>
Subject: Re: [PATCH 04/11] swiotlb: rename swiotlb_late_init_with_default_size
To: Christoph Hellwig <hch@lst.de>, iommu@lists.linux-foundation.org
Cc: x86@kernel.org, Stefano Stabellini <sstabellini@kernel.org>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>, Juergen Gross
 <jgross@suse.com>, Joerg Roedel <joro@8bytes.org>,
 David Woodhouse <dwmw2@infradead.org>, Lu Baolu <baolu.lu@linux.intel.com>,
 Robin Murphy <robin.murphy@arm.com>, linux-arm-kernel@lists.infradead.org,
 xen-devel@lists.xenproject.org, linux-ia64@vger.kernel.org,
 linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
 linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org,
 linux-hyperv@vger.kernel.org, tboot-devel@lists.sourceforge.net,
 linux-pci@vger.kernel.org
References: <20220222153514.593231-1-hch@lst.de>
 <20220222153514.593231-5-hch@lst.de>
Message-ID: <fa35ecc4-414c-f647-ed96-2baf8282ad5b@arm.com>
Date: Thu, 24 Feb 2022 16:06:01 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20220222153514.593231-5-hch@lst.de>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit



On 2/22/22 9:05 PM, Christoph Hellwig wrote:
> swiotlb_late_init_with_default_size is an overly verbose name that
> doesn't even catch what the function is doing, given that the size is
> not just a default but the actual requested size.
> 
> Rename it to swiotlb_init_late.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  arch/x86/pci/sta2x11-fixup.c | 2 +-
>  include/linux/swiotlb.h      | 2 +-
>  kernel/dma/swiotlb.c         | 6 ++----
>  3 files changed, 4 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/x86/pci/sta2x11-fixup.c b/arch/x86/pci/sta2x11-fixup.c
> index 101081ad64b6d..e0c039a75b2db 100644
> --- a/arch/x86/pci/sta2x11-fixup.c
> +++ b/arch/x86/pci/sta2x11-fixup.c
> @@ -57,7 +57,7 @@ static void sta2x11_new_instance(struct pci_dev *pdev)
>  		int size = STA2X11_SWIOTLB_SIZE;
>  		/* First instance: register your own swiotlb area */
>  		dev_info(&pdev->dev, "Using SWIOTLB (size %i)\n", size);
> -		if (swiotlb_late_init_with_default_size(size))
> +		if (swiotlb_init_late(size))
>  			dev_emerg(&pdev->dev, "init swiotlb failed\n");
>  	}
>  	list_add(&instance->list, &sta2x11_instance_list);
> diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h
> index 9fb3a568f0c51..b48b26bfa0edb 100644
> --- a/include/linux/swiotlb.h
> +++ b/include/linux/swiotlb.h
> @@ -40,7 +40,7 @@ extern void swiotlb_init(int verbose);
>  int swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, int verbose);
>  unsigned long swiotlb_size_or_default(void);
>  extern int swiotlb_late_init_with_tbl(char *tlb, unsigned long nslabs);
> -extern int swiotlb_late_init_with_default_size(size_t default_size);
> +int swiotlb_init_late(size_t size);
>  extern void __init swiotlb_update_mem_attributes(void);
>  
>  phys_addr_t swiotlb_tbl_map_single(struct device *hwdev, phys_addr_t phys,
> diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c
> index 519e363097190..5f64b02fbb732 100644
> --- a/kernel/dma/swiotlb.c
> +++ b/kernel/dma/swiotlb.c
> @@ -290,11 +290,9 @@ swiotlb_init(int verbose)
>   * initialize the swiotlb later using the slab allocator if needed.
>   * This should be just like above, but with some error catching.
>   */
> -int
> -swiotlb_late_init_with_default_size(size_t default_size)
> +int swiotlb_init_late(size_t size)
>  {
> -	unsigned long nslabs =
> -		ALIGN(default_size >> IO_TLB_SHIFT, IO_TLB_SEGSIZE);
> +	unsigned long nslabs = ALIGN(size >> IO_TLB_SHIFT, IO_TLB_SEGSIZE);
>  	unsigned long bytes;
>  	unsigned char *vstart = NULL;
>  	unsigned int order;
> 

Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>


From xen-devel-bounces@lists.xenproject.org Thu Feb 24 10:41:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 10:41:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278144.475283 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNBZD-0007bF-90; Thu, 24 Feb 2022 10:41:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278144.475283; Thu, 24 Feb 2022 10:41:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNBZD-0007b8-3t; Thu, 24 Feb 2022 10:41:47 +0000
Received: by outflank-mailman (input) for mailman id 278144;
 Thu, 24 Feb 2022 10:41:45 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=hD/W=TH=arm.com=anshuman.khandual@srs-se1.protection.inumbo.net>)
 id 1nNBZB-0007b2-Qh
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 10:41:45 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 5be7ba71-955e-11ec-8539-5f4723681683;
 Thu, 24 Feb 2022 11:41:44 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DB6B0ED1;
 Thu, 24 Feb 2022 02:41:43 -0800 (PST)
Received: from [10.163.48.178] (unknown [10.163.48.178])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1BF8A3F70D;
 Thu, 24 Feb 2022 02:41:36 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5be7ba71-955e-11ec-8539-5f4723681683
From: Anshuman Khandual <anshuman.khandual@arm.com>
Subject: Re: [PATCH 05/11] swiotlb: pass a gfp_mask argument to
 swiotlb_init_late
To: Christoph Hellwig <hch@lst.de>, iommu@lists.linux-foundation.org
Cc: x86@kernel.org, Stefano Stabellini <sstabellini@kernel.org>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>, Juergen Gross
 <jgross@suse.com>, Joerg Roedel <joro@8bytes.org>,
 David Woodhouse <dwmw2@infradead.org>, Lu Baolu <baolu.lu@linux.intel.com>,
 Robin Murphy <robin.murphy@arm.com>, linux-arm-kernel@lists.infradead.org,
 xen-devel@lists.xenproject.org, linux-ia64@vger.kernel.org,
 linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
 linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org,
 linux-hyperv@vger.kernel.org, tboot-devel@lists.sourceforge.net,
 linux-pci@vger.kernel.org
References: <20220222153514.593231-1-hch@lst.de>
 <20220222153514.593231-6-hch@lst.de>
Message-ID: <e3eb6441-129e-35fe-b07c-fea86908222c@arm.com>
Date: Thu, 24 Feb 2022 16:11:39 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20220222153514.593231-6-hch@lst.de>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit



On 2/22/22 9:05 PM, Christoph Hellwig wrote:
> Let the caller chose a zone to allocate from.

This is being used later via xen_swiotlb_gfp() on arm platform.

> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  arch/x86/pci/sta2x11-fixup.c | 2 +-
>  include/linux/swiotlb.h      | 2 +-
>  kernel/dma/swiotlb.c         | 4 ++--
>  3 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/x86/pci/sta2x11-fixup.c b/arch/x86/pci/sta2x11-fixup.c
> index e0c039a75b2db..c7e6faf59a861 100644
> --- a/arch/x86/pci/sta2x11-fixup.c
> +++ b/arch/x86/pci/sta2x11-fixup.c
> @@ -57,7 +57,7 @@ static void sta2x11_new_instance(struct pci_dev *pdev)
>  		int size = STA2X11_SWIOTLB_SIZE;
>  		/* First instance: register your own swiotlb area */
>  		dev_info(&pdev->dev, "Using SWIOTLB (size %i)\n", size);
> -		if (swiotlb_init_late(size))
> +		if (swiotlb_init_late(size, GFP_DMA))
>  			dev_emerg(&pdev->dev, "init swiotlb failed\n");
>  	}
>  	list_add(&instance->list, &sta2x11_instance_list);
> diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h
> index b48b26bfa0edb..1befd6b2ccf5e 100644
> --- a/include/linux/swiotlb.h
> +++ b/include/linux/swiotlb.h
> @@ -40,7 +40,7 @@ extern void swiotlb_init(int verbose);
>  int swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, int verbose);
>  unsigned long swiotlb_size_or_default(void);
>  extern int swiotlb_late_init_with_tbl(char *tlb, unsigned long nslabs);
> -int swiotlb_init_late(size_t size);
> +int swiotlb_init_late(size_t size, gfp_t gfp_mask);
>  extern void __init swiotlb_update_mem_attributes(void);
>  
>  phys_addr_t swiotlb_tbl_map_single(struct device *hwdev, phys_addr_t phys,
> diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c
> index 5f64b02fbb732..a653fcf1fe6c2 100644
> --- a/kernel/dma/swiotlb.c
> +++ b/kernel/dma/swiotlb.c
> @@ -290,7 +290,7 @@ swiotlb_init(int verbose)
>   * initialize the swiotlb later using the slab allocator if needed.
>   * This should be just like above, but with some error catching.
>   */
> -int swiotlb_init_late(size_t size)
> +int swiotlb_init_late(size_t size, gfp_t gfp_mask)
>  {
>  	unsigned long nslabs = ALIGN(size >> IO_TLB_SHIFT, IO_TLB_SEGSIZE);
>  	unsigned long bytes;
> @@ -309,7 +309,7 @@ int swiotlb_init_late(size_t size)
>  	bytes = nslabs << IO_TLB_SHIFT;
>  
>  	while ((SLABS_PER_PAGE << order) > IO_TLB_MIN_SLABS) {
> -		vstart = (void *)__get_free_pages(GFP_DMA | __GFP_NOWARN,
> +		vstart = (void *)__get_free_pages(gfp_mask | __GFP_NOWARN,
>  						  order);
>  		if (vstart)
>  			break;
> 

Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>


From xen-devel-bounces@lists.xenproject.org Thu Feb 24 10:54:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 10:54:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278153.475310 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNBlm-0000yT-UZ; Thu, 24 Feb 2022 10:54:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278153.475310; Thu, 24 Feb 2022 10:54:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNBlm-0000yB-Pe; Thu, 24 Feb 2022 10:54:46 +0000
Received: by outflank-mailman (input) for mailman id 278153;
 Thu, 24 Feb 2022 10:54:45 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=l9RI=TH=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nNBll-0000gP-1N
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 10:54:45 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2c0ab764-9560-11ec-8539-5f4723681683;
 Thu, 24 Feb 2022 11:54:43 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id E7D8A212B6;
 Thu, 24 Feb 2022 10:54:42 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A85BA13A79;
 Thu, 24 Feb 2022 10:54:42 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id uPbOJ/JjF2L2SQAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 24 Feb 2022 10:54:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2c0ab764-9560-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1645700082; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=URIjccjwM+WJARLadPEaWbGGRJrYXRvtFlWn552mtiI=;
	b=fLIXfWbRb3zjBOqhts86DZqCB04UL0o2z9JifLcWZ6kaGZy/vV/jBOjbJ53bCqxq2o6eIm
	n/Zk19ePskoyZNPKLmVdL6fMrGRySTYHM96AZ1k6f1zmFx1CgXykOA1xMQwJ9i4xlFbT2Y
	wmUlgkBcSspxhYVOKBW7mD+eAvMNghQ=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Wei Liu <wl@xen.org>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: [PATCH 2/2] xen/spinlock: merge recurse_cpu and debug.cpu fields in struct spinlock
Date: Thu, 24 Feb 2022 11:54:36 +0100
Message-Id: <20220224105436.1480-3-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220224105436.1480-1-jgross@suse.com>
References: <20220224105436.1480-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Instead of having two fields in struct spinlock holding a cpu number,
just merge them. For this purpose get rid of union lock_debug and use a
32 bit sized union for cpu, recurse_cnt and the two debug booleans.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 xen/arch/x86/mm/mm-locks.h |  6 ++---
 xen/common/spinlock.c      | 48 +++++++++++++++++++++-----------------
 xen/include/xen/spinlock.h | 43 ++++++++++++++++++----------------
 3 files changed, 52 insertions(+), 45 deletions(-)

diff --git a/xen/arch/x86/mm/mm-locks.h b/xen/arch/x86/mm/mm-locks.h
index fcfd4706ba..01cf3a820d 100644
--- a/xen/arch/x86/mm/mm-locks.h
+++ b/xen/arch/x86/mm/mm-locks.h
@@ -42,7 +42,7 @@ static inline void mm_lock_init(mm_lock_t *l)
 
 static inline bool mm_locked_by_me(const mm_lock_t *l)
 {
-    return (l->lock.recurse_cpu == current->processor);
+    return (l->lock.data.cpu == current->processor);
 }
 
 static inline int _get_lock_level(void)
@@ -94,7 +94,7 @@ static inline void _mm_lock(const struct domain *d, mm_lock_t *l,
     if ( !((mm_locked_by_me(l)) && rec) )
         _check_lock_level(d, level);
     spin_lock_recursive(&l->lock);
-    if ( l->lock.recurse_cnt == 1 )
+    if ( l->lock.data.recurse_cnt == 1 )
     {
         l->locker_function = func;
         l->unlock_level = _get_lock_level();
@@ -209,7 +209,7 @@ static inline void mm_read_unlock(mm_rwlock_t *l)
 
 static inline void mm_unlock(mm_lock_t *l)
 {
-    if ( l->lock.recurse_cnt == 1 )
+    if ( l->lock.data.recurse_cnt == 1 )
     {
         l->locker_function = "nobody";
         _set_lock_level(l->unlock_level);
diff --git a/xen/common/spinlock.c b/xen/common/spinlock.c
index 53d6ab6853..33e6aaab1c 100644
--- a/xen/common/spinlock.c
+++ b/xen/common/spinlock.c
@@ -17,8 +17,6 @@ void check_lock(spinlock_t *lock, bool try)
 {
     bool irq_safe = !local_irq_is_enabled();
 
-    BUILD_BUG_ON(LOCK_DEBUG_PAD_BITS <= 0);
-
     if ( unlikely(atomic_read(&spin_debug) <= 0) )
         return;
 
@@ -49,12 +47,12 @@ void check_lock(spinlock_t *lock, bool try)
     if ( try && irq_safe )
         return;
 
-    if ( unlikely(lock->debug.irq_safe != irq_safe) )
+    if ( unlikely(lock->data.irq_safe != irq_safe) )
     {
-        union lock_debug seen, new = { 0 };
+        spinlock_data_t seen, new = { 0 };
 
         new.irq_safe = irq_safe;
-        seen.val = cmpxchg(&lock->debug.val, LOCK_DEBUG_INITVAL, new.val);
+        seen.val = cmpxchg(&lock->data.val, SPINLOCK_DATA_INITVAL, new.val);
 
         if ( !seen.unseen && seen.irq_safe == !irq_safe )
         {
@@ -81,19 +79,19 @@ static void check_barrier(spinlock_t *lock)
      * However, if we spin on an IRQ-unsafe lock with IRQs disabled then that
      * is clearly wrong, for the same reason outlined in check_lock() above.
      */
-    BUG_ON(!local_irq_is_enabled() && !lock->debug.irq_safe);
+    BUG_ON(!local_irq_is_enabled() && !lock->data.irq_safe);
 }
 
 static void got_lock(spinlock_t *lock)
 {
-    lock->debug.cpu = smp_processor_id();
+    lock->data.cpu = smp_processor_id();
 }
 
 static void rel_lock(spinlock_t *lock)
 {
     if ( atomic_read(&spin_debug) > 0 )
-        BUG_ON(lock->debug.cpu != smp_processor_id());
-    lock->debug.cpu = SPINLOCK_NO_CPU;
+        BUG_ON(lock->data.cpu != smp_processor_id());
+    lock->data.cpu = SPINLOCK_NO_CPU;
 }
 
 void spin_debug_enable(void)
@@ -230,9 +228,9 @@ int _spin_is_locked(spinlock_t *lock)
      * "false" here, making this function suitable only for use in
      * ASSERT()s and alike.
      */
-    return lock->recurse_cpu == SPINLOCK_NO_CPU
+    return lock->data.cpu == SPINLOCK_NO_CPU
            ? lock->tickets.head != lock->tickets.tail
-           : lock->recurse_cpu == smp_processor_id();
+           : lock->data.cpu == smp_processor_id();
 }
 
 int _spin_trylock(spinlock_t *lock)
@@ -296,22 +294,24 @@ int _spin_trylock_recursive(spinlock_t *lock)
 {
     unsigned int cpu = smp_processor_id();
 
-    /* Don't allow overflow of recurse_cpu field. */
+    /* Don't allow overflow of cpu field. */
     BUILD_BUG_ON(NR_CPUS > SPINLOCK_NO_CPU);
     BUILD_BUG_ON(SPINLOCK_RECURSE_BITS < 3);
 
     check_lock(lock, true);
 
-    if ( likely(lock->recurse_cpu != cpu) )
+    if ( likely(lock->data.cpu != cpu) )
     {
         if ( !spin_trylock(lock) )
             return 0;
-        lock->recurse_cpu = cpu;
+#ifndef CONFIG_DEBUG_LOCKS
+        lock->data.cpu = cpu;
+#endif
     }
 
     /* We support only fairly shallow recursion, else the counter overflows. */
-    ASSERT(lock->recurse_cnt < SPINLOCK_MAX_RECURSE);
-    lock->recurse_cnt++;
+    ASSERT(lock->data.recurse_cnt < SPINLOCK_MAX_RECURSE);
+    lock->data.recurse_cnt++;
 
     return 1;
 }
@@ -320,22 +320,26 @@ void _spin_lock_recursive(spinlock_t *lock)
 {
     unsigned int cpu = smp_processor_id();
 
-    if ( likely(lock->recurse_cpu != cpu) )
+    if ( likely(lock->data.cpu != cpu) )
     {
         _spin_lock(lock);
-        lock->recurse_cpu = cpu;
+#ifndef CONFIG_DEBUG_LOCKS
+        lock->data.cpu = cpu;
+#endif
     }
 
     /* We support only fairly shallow recursion, else the counter overflows. */
-    ASSERT(lock->recurse_cnt < SPINLOCK_MAX_RECURSE);
-    lock->recurse_cnt++;
+    ASSERT(lock->data.recurse_cnt < SPINLOCK_MAX_RECURSE);
+    lock->data.recurse_cnt++;
 }
 
 void _spin_unlock_recursive(spinlock_t *lock)
 {
-    if ( likely(--lock->recurse_cnt == 0) )
+    if ( likely(--lock->data.recurse_cnt == 0) )
     {
-        lock->recurse_cpu = SPINLOCK_NO_CPU;
+#ifndef CONFIG_DEBUG_LOCKS
+        lock->data.cpu = SPINLOCK_NO_CPU;
+#endif
         spin_unlock(lock);
     }
 }
diff --git a/xen/include/xen/spinlock.h b/xen/include/xen/spinlock.h
index 5b6b73732f..61731b5d29 100644
--- a/xen/include/xen/spinlock.h
+++ b/xen/include/xen/spinlock.h
@@ -6,26 +6,34 @@
 #include <asm/spinlock.h>
 #include <asm/types.h>
 
-#define SPINLOCK_CPU_BITS  12
+#define SPINLOCK_CPU_BITS      12
+#define SPINLOCK_NO_CPU        ((1u << SPINLOCK_CPU_BITS) - 1)
+#define SPINLOCK_RECURSE_BITS  (16 - SPINLOCK_CPU_BITS)
+#define SPINLOCK_MAX_RECURSE   ((1u << SPINLOCK_RECURSE_BITS) - 1)
+#define SPINLOCK_PAD_BITS      (30 - SPINLOCK_CPU_BITS - SPINLOCK_RECURSE_BITS)
 
-#ifdef CONFIG_DEBUG_LOCKS
-union lock_debug {
-    uint16_t val;
-#define LOCK_DEBUG_INITVAL 0xffff
+typedef union {
+    u32 val;
     struct {
-        uint16_t cpu:SPINLOCK_CPU_BITS;
-#define LOCK_DEBUG_PAD_BITS (14 - SPINLOCK_CPU_BITS)
-        uint16_t :LOCK_DEBUG_PAD_BITS;
+        u32 cpu:SPINLOCK_CPU_BITS;
+        u32 recurse_cnt:SPINLOCK_RECURSE_BITS;
+        u32 pad:SPINLOCK_PAD_BITS;
+#ifdef CONFIG_DEBUG_LOCKS
         bool irq_safe:1;
         bool unseen:1;
+#define SPINLOCK_DEBUG_INITVAL 0xc0000000
+#else
+        u32 debug_pad:2;
+#define SPINLOCK_DEBUG_INITVAL 0x00000000
+#endif
     };
-};
-#define _LOCK_DEBUG { LOCK_DEBUG_INITVAL }
+} spinlock_data_t;
+#define SPINLOCK_DATA_INITVAL (SPINLOCK_NO_CPU | SPINLOCK_DEBUG_INITVAL)
+
+#ifdef CONFIG_DEBUG_LOCKS
 void spin_debug_enable(void);
 void spin_debug_disable(void);
 #else
-union lock_debug { };
-#define _LOCK_DEBUG { }
 #define spin_debug_enable() ((void)0)
 #define spin_debug_disable() ((void)0)
 #endif
@@ -92,7 +100,7 @@ struct lock_profile_qhead {
     static struct lock_profile * const __lock_profile_##name                  \
     __used_section(".lockprofile.data") =                                     \
     &__lock_profile_data_##name
-#define _SPIN_LOCK_UNLOCKED(x) { { 0 }, SPINLOCK_NO_CPU, 0, _LOCK_DEBUG, x }
+#define _SPIN_LOCK_UNLOCKED(x) { { 0 }, { SPINLOCK_DATA_INITVAL }, x }
 #define SPIN_LOCK_UNLOCKED _SPIN_LOCK_UNLOCKED(NULL)
 #define DEFINE_SPINLOCK(l)                                                    \
     spinlock_t l = _SPIN_LOCK_UNLOCKED(NULL);                                 \
@@ -134,7 +142,7 @@ extern void cf_check spinlock_profile_reset(unsigned char key);
 
 struct lock_profile_qhead { };
 
-#define SPIN_LOCK_UNLOCKED { { 0 }, SPINLOCK_NO_CPU, 0, _LOCK_DEBUG }
+#define SPIN_LOCK_UNLOCKED { { 0 }, { SPINLOCK_DATA_INITVAL } }
 #define DEFINE_SPINLOCK(l) spinlock_t l = SPIN_LOCK_UNLOCKED
 
 #define spin_lock_init_prof(s, l) spin_lock_init(&((s)->l))
@@ -156,12 +164,7 @@ typedef union {
 
 typedef struct spinlock {
     spinlock_tickets_t tickets;
-    u16 recurse_cpu:SPINLOCK_CPU_BITS;
-#define SPINLOCK_NO_CPU        ((1u << SPINLOCK_CPU_BITS) - 1)
-#define SPINLOCK_RECURSE_BITS  (16 - SPINLOCK_CPU_BITS)
-    u16 recurse_cnt:SPINLOCK_RECURSE_BITS;
-#define SPINLOCK_MAX_RECURSE   ((1u << SPINLOCK_RECURSE_BITS) - 1)
-    union lock_debug debug;
+    spinlock_data_t data;
 #ifdef CONFIG_DEBUG_LOCK_PROFILE
     struct lock_profile *profile;
 #endif
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Thu Feb 24 10:54:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 10:54:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278152.475304 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNBlm-0000wS-LI; Thu, 24 Feb 2022 10:54:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278152.475304; Thu, 24 Feb 2022 10:54:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNBlm-0000wL-I3; Thu, 24 Feb 2022 10:54:46 +0000
Received: by outflank-mailman (input) for mailman id 278152;
 Thu, 24 Feb 2022 10:54:44 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=l9RI=TH=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nNBlk-0000gJ-Pv
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 10:54:44 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2bebc759-9560-11ec-8eb8-a37418f5ba1a;
 Thu, 24 Feb 2022 11:54:43 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id A1A5121136;
 Thu, 24 Feb 2022 10:54:42 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 68F2713A79;
 Thu, 24 Feb 2022 10:54:42 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id CI5gGPJjF2L2SQAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 24 Feb 2022 10:54:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2bebc759-9560-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1645700082; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=ojjdlGbMc95KyfFklDt/mHMPcKnQ5SgYlPEfROv8euA=;
	b=FZ3VVQKQ9N5KZGY3CNBPoQN1p/zbYprrswdaoV6yeJORXSDKet60wfyv/NQpmwX8+bE9Np
	FeX9q0eH6FZN39XM9nDMkzizWXCYN7kr/xxMr0KmfHZ4mSu3tt5nvZT2sNXslubpJrO11N
	jKpjcXsuem5DcyfXfNoKB5FOTEvCMEo=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>
Subject: [PATCH 1/2] xen/spinlock: use lock address for lock debug functions
Date: Thu, 24 Feb 2022 11:54:35 +0100
Message-Id: <20220224105436.1480-2-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220224105436.1480-1-jgross@suse.com>
References: <20220224105436.1480-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Instead of only passing the lock_debug address to check_lock() et al
use the address of the spinlock.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 xen/common/spinlock.c      | 34 +++++++++++++++++-----------------
 xen/include/xen/rwlock.h   | 10 +++++-----
 xen/include/xen/spinlock.h | 10 ++++++++--
 3 files changed, 30 insertions(+), 24 deletions(-)

diff --git a/xen/common/spinlock.c b/xen/common/spinlock.c
index 62c83aaa6a..53d6ab6853 100644
--- a/xen/common/spinlock.c
+++ b/xen/common/spinlock.c
@@ -13,7 +13,7 @@
 
 static atomic_t spin_debug __read_mostly = ATOMIC_INIT(0);
 
-void check_lock(union lock_debug *debug, bool try)
+void check_lock(spinlock_t *lock, bool try)
 {
     bool irq_safe = !local_irq_is_enabled();
 
@@ -49,12 +49,12 @@ void check_lock(union lock_debug *debug, bool try)
     if ( try && irq_safe )
         return;
 
-    if ( unlikely(debug->irq_safe != irq_safe) )
+    if ( unlikely(lock->debug.irq_safe != irq_safe) )
     {
         union lock_debug seen, new = { 0 };
 
         new.irq_safe = irq_safe;
-        seen.val = cmpxchg(&debug->val, LOCK_DEBUG_INITVAL, new.val);
+        seen.val = cmpxchg(&lock->debug.val, LOCK_DEBUG_INITVAL, new.val);
 
         if ( !seen.unseen && seen.irq_safe == !irq_safe )
         {
@@ -65,7 +65,7 @@ void check_lock(union lock_debug *debug, bool try)
     }
 }
 
-static void check_barrier(union lock_debug *debug)
+static void check_barrier(spinlock_t *lock)
 {
     if ( unlikely(atomic_read(&spin_debug) <= 0) )
         return;
@@ -81,19 +81,19 @@ static void check_barrier(union lock_debug *debug)
      * However, if we spin on an IRQ-unsafe lock with IRQs disabled then that
      * is clearly wrong, for the same reason outlined in check_lock() above.
      */
-    BUG_ON(!local_irq_is_enabled() && !debug->irq_safe);
+    BUG_ON(!local_irq_is_enabled() && !lock->debug.irq_safe);
 }
 
-static void got_lock(union lock_debug *debug)
+static void got_lock(spinlock_t *lock)
 {
-    debug->cpu = smp_processor_id();
+    lock->debug.cpu = smp_processor_id();
 }
 
-static void rel_lock(union lock_debug *debug)
+static void rel_lock(spinlock_t *lock)
 {
     if ( atomic_read(&spin_debug) > 0 )
-        BUG_ON(debug->cpu != smp_processor_id());
-    debug->cpu = SPINLOCK_NO_CPU;
+        BUG_ON(lock->debug.cpu != smp_processor_id());
+    lock->debug.cpu = SPINLOCK_NO_CPU;
 }
 
 void spin_debug_enable(void)
@@ -164,7 +164,7 @@ void inline _spin_lock_cb(spinlock_t *lock, void (*cb)(void *), void *data)
     spinlock_tickets_t tickets = SPINLOCK_TICKET_INC;
     LOCK_PROFILE_VAR;
 
-    check_lock(&lock->debug, false);
+    check_lock(lock, false);
     preempt_disable();
     tickets.head_tail = arch_fetch_and_add(&lock->tickets.head_tail,
                                            tickets.head_tail);
@@ -176,7 +176,7 @@ void inline _spin_lock_cb(spinlock_t *lock, void (*cb)(void *), void *data)
         arch_lock_relax();
     }
     arch_lock_acquire_barrier();
-    got_lock(&lock->debug);
+    got_lock(lock);
     LOCK_PROFILE_GOT;
 }
 
@@ -204,7 +204,7 @@ unsigned long _spin_lock_irqsave(spinlock_t *lock)
 void _spin_unlock(spinlock_t *lock)
 {
     LOCK_PROFILE_REL;
-    rel_lock(&lock->debug);
+    rel_lock(lock);
     arch_lock_release_barrier();
     add_sized(&lock->tickets.head, 1);
     arch_lock_signal();
@@ -240,7 +240,7 @@ int _spin_trylock(spinlock_t *lock)
     spinlock_tickets_t old, new;
 
     preempt_disable();
-    check_lock(&lock->debug, true);
+    check_lock(lock, true);
     old = observe_lock(&lock->tickets);
     if ( old.head != old.tail )
     {
@@ -259,7 +259,7 @@ int _spin_trylock(spinlock_t *lock)
      * cmpxchg() is a full barrier so no need for an
      * arch_lock_acquire_barrier().
      */
-    got_lock(&lock->debug);
+    got_lock(lock);
 #ifdef CONFIG_DEBUG_LOCK_PROFILE
     if (lock->profile)
         lock->profile->time_locked = NOW();
@@ -274,7 +274,7 @@ void _spin_barrier(spinlock_t *lock)
     s_time_t block = NOW();
 #endif
 
-    check_barrier(&lock->debug);
+    check_barrier(lock);
     smp_mb();
     sample = observe_lock(&lock->tickets);
     if ( sample.head != sample.tail )
@@ -300,7 +300,7 @@ int _spin_trylock_recursive(spinlock_t *lock)
     BUILD_BUG_ON(NR_CPUS > SPINLOCK_NO_CPU);
     BUILD_BUG_ON(SPINLOCK_RECURSE_BITS < 3);
 
-    check_lock(&lock->debug, true);
+    check_lock(lock, true);
 
     if ( likely(lock->recurse_cpu != cpu) )
     {
diff --git a/xen/include/xen/rwlock.h b/xen/include/xen/rwlock.h
index 0cc9167715..188fc809dc 100644
--- a/xen/include/xen/rwlock.h
+++ b/xen/include/xen/rwlock.h
@@ -56,7 +56,7 @@ static inline int _read_trylock(rwlock_t *lock)
     u32 cnts;
 
     preempt_disable();
-    check_lock(&lock->lock.debug, true);
+    check_lock(&lock->lock, true);
     cnts = atomic_read(&lock->cnts);
     if ( likely(_can_read_lock(cnts)) )
     {
@@ -90,7 +90,7 @@ static inline void _read_lock(rwlock_t *lock)
     if ( likely(_can_read_lock(cnts)) )
     {
         /* The slow path calls check_lock() via spin_lock(). */
-        check_lock(&lock->lock.debug, false);
+        check_lock(&lock->lock, false);
         return;
     }
 
@@ -169,7 +169,7 @@ static inline void _write_lock(rwlock_t *lock)
     if ( atomic_cmpxchg(&lock->cnts, 0, _write_lock_val()) == 0 )
     {
         /* The slow path calls check_lock() via spin_lock(). */
-        check_lock(&lock->lock.debug, false);
+        check_lock(&lock->lock, false);
         return;
     }
 
@@ -206,7 +206,7 @@ static inline int _write_trylock(rwlock_t *lock)
     u32 cnts;
 
     preempt_disable();
-    check_lock(&lock->lock.debug, true);
+    check_lock(&lock->lock, true);
     cnts = atomic_read(&lock->cnts);
     if ( unlikely(cnts) ||
          unlikely(atomic_cmpxchg(&lock->cnts, 0, _write_lock_val()) != 0) )
@@ -341,7 +341,7 @@ static inline void _percpu_read_lock(percpu_rwlock_t **per_cpudata,
     else
     {
         /* All other paths have implicit check_lock() calls via read_lock(). */
-        check_lock(&percpu_rwlock->rwlock.lock.debug, false);
+        check_lock(&percpu_rwlock->rwlock.lock, false);
     }
 }
 
diff --git a/xen/include/xen/spinlock.h b/xen/include/xen/spinlock.h
index 961891bea4..5b6b73732f 100644
--- a/xen/include/xen/spinlock.h
+++ b/xen/include/xen/spinlock.h
@@ -21,13 +21,11 @@ union lock_debug {
     };
 };
 #define _LOCK_DEBUG { LOCK_DEBUG_INITVAL }
-void check_lock(union lock_debug *debug, bool try);
 void spin_debug_enable(void);
 void spin_debug_disable(void);
 #else
 union lock_debug { };
 #define _LOCK_DEBUG { }
-#define check_lock(l, t) ((void)0)
 #define spin_debug_enable() ((void)0)
 #define spin_debug_disable() ((void)0)
 #endif
@@ -189,6 +187,14 @@ int _spin_trylock_recursive(spinlock_t *lock);
 void _spin_lock_recursive(spinlock_t *lock);
 void _spin_unlock_recursive(spinlock_t *lock);
 
+#ifdef CONFIG_DEBUG_LOCKS
+void check_lock(spinlock_t *lock, bool try);
+#else
+static inline void check_lock(spinlock_t *lock, bool try)
+{
+}
+#endif
+
 #define spin_lock(l)                  _spin_lock(l)
 #define spin_lock_cb(l, c, d)         _spin_lock_cb(l, c, d)
 #define spin_lock_irq(l)              _spin_lock_irq(l)
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Thu Feb 24 10:54:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 10:54:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278151.475293 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNBll-0000h0-Bx; Thu, 24 Feb 2022 10:54:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278151.475293; Thu, 24 Feb 2022 10:54:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNBll-0000gt-8v; Thu, 24 Feb 2022 10:54:45 +0000
Received: by outflank-mailman (input) for mailman id 278151;
 Thu, 24 Feb 2022 10:54:44 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=l9RI=TH=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nNBlk-0000gJ-2G
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 10:54:44 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2bebbe0e-9560-11ec-8eb8-a37418f5ba1a;
 Thu, 24 Feb 2022 11:54:43 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 62AAF1F37F;
 Thu, 24 Feb 2022 10:54:42 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2258E13A79;
 Thu, 24 Feb 2022 10:54:42 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id LvENB/JjF2L2SQAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 24 Feb 2022 10:54:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2bebbe0e-9560-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1645700082; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=NoMWvYoXeFUJUeVEWMst2TYHSjWrHZfKY2PIDx5QSCo=;
	b=RSKAWO1sYuGsWqAc/ZFWYVq9vG+99/SGIh9NsJ31sT2wFbkSqY/0B4W5KsRBHc1aKPgVpj
	H4ewfp/OJnVaUQoYYHxxEfZ+1q/JPw3niwvwyNvAmwKbsRC2Sbf/Pyj2OQm0qNsiB8U4/N
	5Da3R3Zt9Z/NxWnOLD+lX3TmZuG7bI4=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>
Subject: [PATCH 0/2] xen/spinlock: cleanup struct spinlock
Date: Thu, 24 Feb 2022 11:54:34 +0100
Message-Id: <20220224105436.1480-1-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

The spinlock data structure contains two cpu fields for storing the
cpu number of the lock holder (one for debug purposes and one for
recursive spinlocks). Merging them removes a build time limitation for
supporting higher cpu numbers than today.

This series is NOT using more bits for storing the cpu number, but
doing that would now be possible. Taking rwlocks into account it would
be possible now to use 14 bits for the cpu, allowing up to 16383 cpus
without growing the lock related data types.

Juergen Gross (2):
  xen/spinlock: use lock address for lock debug functions
  xen/spinlock: merge recurse_cpu and debug.cpu fields in struct
    spinlock

 xen/arch/x86/mm/mm-locks.h |  6 ++--
 xen/common/spinlock.c      | 70 ++++++++++++++++++++------------------
 xen/include/xen/rwlock.h   | 10 +++---
 xen/include/xen/spinlock.h | 53 +++++++++++++++++------------
 4 files changed, 76 insertions(+), 63 deletions(-)

-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Thu Feb 24 11:22:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 11:22:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278174.475327 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNCCa-0005EI-CK; Thu, 24 Feb 2022 11:22:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278174.475327; Thu, 24 Feb 2022 11:22:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNCCa-0005EB-8h; Thu, 24 Feb 2022 11:22:28 +0000
Received: by outflank-mailman (input) for mailman id 278174;
 Thu, 24 Feb 2022 11:22:27 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=oTFz=TH=citrix.com=prvs=047b345d9=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nNCCY-0005E5-Tt
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 11:22:27 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0939efe3-9564-11ec-8eb8-a37418f5ba1a;
 Thu, 24 Feb 2022 12:22:24 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0939efe3-9564-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645701744;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=PP5ZeioIF4xFGvxeh3WqJzqQDY3AtgMV8UlX+LI3gwI=;
  b=A+m+moxWEd3aEAoCb8x3ARk6AU5xwdanR3Qiq28De1copNVwl3cuUth6
   cmGuqZr3CY2TgfJX7MiriYV5dCM1v8xUWzQYhz3p1NOz20TBUvnSbUe3t
   fBr5v4UnX8Fn9kfh5EW51I147xKuiKWhxuo3df3LEpBGwosNfNINH7vFm
   Y=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 64895913
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:2+vDZqIHYiIyHaVGFE+Rw5UlxSXFcZb7ZxGr2PjKsXjdYENSgzcFy
 zMaD2vUOqyMZmTyLd9wPt+39h9XsJKEzoBrTgplqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA180IMsdoUg7wbRh2NQ02YHR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 PMRhbHsUwAjBPXNocUmCUd9E2Y5I6ITrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBODtMJkSpTdLyjbBAOx9aZvCX7/L9ZlT2zJYasVmQ6qON
 pdIMGEHgBLocyFpB08lCsIHtsD0j0GiWCRnjkKHnP9ii4TU5FMoi+W8WDbPQfSVQe1Fk0Deo
 XjJl0zpDxdfONGBxD6t9nO3mvSJjS79QJgVFrCz6rhtmlL77m4ZBQASVFC7ieKkkUP4UNVaQ
 3H44QJ38/J0rhbyCICgAVvo+xZooyLwRfJ2T90XtBuKwJCM4j+4PTJaaz4GL8Ip4ZpeqSMR6
 neFmNbgBDpKubKTSG6A+rr8kQ5eKRT5PkdZO3ZaEFJtD83L5dhq00mRFooL/Lud04WtcQwc1
 Qxmu8TXa187qccQn5u28lnc695HjsiYF1Vljuk7s4/M0++YWGJHT9HwgbQ4xawZRGp8crVnl
 CJa8yR5xLpTZaxhbATXHI0w8EiBvp5pygH0j191BIUG/D+w4XOldo04yGggeBo3bpxYI2S2O
 BS7VeZtCHl7ZiXCgUhfOd/ZNijX5fK4SYSNug78NLKinaSdhCfYpXozNCZ8LkjmkVQ2kLFXB
 HtoWZ3EMJruMow+lGDeb75EidcDn3lirUuOFcGT50n2itK2OS/KIYrpxXPTN4jVGovf+16Lm
 zueXuPXoyhivBrWOHePqtdLdQhQRZX5bLivw/Fqmie4ClMOMEkqCuPLwKNnfIpgnq9PkfzP8
 G37UUhdoGcTT1WdQelWQhiPsI/SYKs=
IronPort-HdrOrdr: A9a23:xU8p4avF+4PRrZ8utSZWVjHn7skDctV00zEX/kB9WHVpm6uj5q
 eTdZUgpHvJYVMqM03I9urtBEDtexzhHP1OgbX5X43NYOCOggLBRuxfBODZogHIKmnT8fNcyL
 clU4UWMqyUMbGit7eY3OBvKadD/OW6
X-IronPort-AV: E=Sophos;i="5.88,393,1635220800"; 
   d="scan'208";a="64895913"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=P24ve/cuFPPg0A5c491iHpt+sXbZ+9Vq37cSJgGxzAdNm8e9wOuWxg0y5E9UKNkJDSap+XDCh2z+INs/SD9jMGnZBT2hiAwUnrcOdPowzFh2UtBK9nrqOguutE2u/7i4kKD4M3+udtf6N+wqDrPYhsMJY/6MJp9QyQuW6NiSVkLwXkkSUcD21uWcLnZ7bKnRRQZjg3UcNcoOZML7R3GUCKhacb10chDQLpic7wc+1aa4VrPa7MdUntkLME5QFFfhV6SexgXuLLHZwjSKmoIoz5o6QDd+N/pj2eyZ5XzxQd71L9pDs2flu1v0vZb8+kwMSYy9PjuVK4muLuZLXwO+vA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=PP5ZeioIF4xFGvxeh3WqJzqQDY3AtgMV8UlX+LI3gwI=;
 b=FxevyrEAiPqDhple4mVp3luu3hhYlMYblFQH9aMaBKzsIqF8+zHtuTa6hvsUiHOmD+yEoTgWDOZNQxZv96alie5nVL0YNhRTw9Op9il1tGUtTjuQrLGfukvZtanpHbI8SsuMfgHIx53/VVdAOJpSCR7UsfPCOjrkFlEX0FP7M28X5jLTRF54yEYjyVxoJJXTyESuRzTvafwgM3z8fqGiw82TdW85Zv8h/1ODbMv8of1xKFnRC6gKgfhAsNVCexEhI0brXKvOvhfyufT4yIJ/VDjfd/IIsfwfrWyZZ+Kcfok4a4eh5d6U+f46n5oWjXIlmLb3Hd5eYrqyZkljZWam9Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=PP5ZeioIF4xFGvxeh3WqJzqQDY3AtgMV8UlX+LI3gwI=;
 b=XUeYhN8RJaZUcs3j1K3b+9xP70OS3ldWubWmfNxNPgsLV6kP4tgy2yZn3J+j7V5v+RrlxplecTbek8M17FeXUzn3tGzx9qcwAlVqoLvcyWz1t7hII16R2gnM3c1ho12cupxnJzL0xLRTfV+4hpwmc3lc4JDhL+DPDJTcPUl+fUY=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Wei Liu <wl@xen.org>, Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH] x86: make embedded endbr64 check compatible with older
 GNU grep
Thread-Topic: [PATCH] x86: make embedded endbr64 check compatible with older
 GNU grep
Thread-Index: AQHYKWdr96DvHtmiCE6n5nuoqf1KFayifeMAgAAQ3YA=
Date: Thu, 24 Feb 2022 11:22:17 +0000
Message-ID: <d6392c5c-b70d-6efd-f49e-567e703d64a3@citrix.com>
References: <ceaae3c8-0c35-efc1-c7bc-f44364ce29e4@suse.com>
 <cced4ec0-f522-9273-b10c-0e652bcc5aa3@citrix.com>
In-Reply-To: <cced4ec0-f522-9273-b10c-0e652bcc5aa3@citrix.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: ed36e512-cfdf-4adb-e393-08d9f787eab5
x-ms-traffictypediagnostic: MN2PR03MB4815:EE_
x-microsoft-antispam-prvs: <MN2PR03MB4815234421439A3C139815F5BA3D9@MN2PR03MB4815.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: YPk/nl9FYVo5Jg2HA08yLJR/eTpIAXMjMo+jUAkGTGdNCw7qFZPbtSSRVbREuGtb8gTk+59h3DCUC3gGTcgg7rmTJL6ASUaOlUFzcQF5D4EpPo0xl68dITAPA6vHA8GY960GUOFwQ9tPXf8WucS1izNKR3AuzfZjVsuiUIR68NJ+V3FCu5BNZdpa0Ih7vPiB98wWmIToqUGHtI6to1grIs2l4Dvnp1n82SIQiirwMguMOtzY7KdToUT71LUjbpZmaLgv/0GCrbk5zCsbLeD+aaApa5rEDc+7znvso5g4nhOKEWF7BdElbdTSEU+vJV71XgsF61ND4c6P7nM8uE2rW4/4gfD3M9nIDj1nFy1vRcVFKz7ZZ4npZdf5VGdgF1lnDyfo9zf9T3mugggcwD/M19+a1Mhg6qO9bdjpdIV/q3HAH0lddU7wWkBGFgMHzHjugpyr4hauiqUSLI+hnKE2wBZnI83uftkN/Mgmwl2cQ3an04LxWnTbes8XWUywyl1UiR7yeFCG8eaaM9tYizf4a4PVc+otFdePStN3Q9SvHE4jCJw8UClCkfEiL7p6XW7h8AsCZxwdNuEn7PDO7gUuwoehdJBW3/qbecSTDIpk8MXOacmgszJiS4u6WYH2dt3g7qEwqZegPPy/MgWfSpO/uRQrVEJgXQg2DR09N8eNX0lj+PoXihFiylM6GcFGrKo0ncwh3kO8CwRcaiZ1rsL2ptAT25CixtKpqGYHQWnFhgvJG5naeGjUm30nKIaFdEsWU9m7O/i578++XbOguF3MHeDch0W2epniSfqxPzQQamJOpV66k8aYGAiqRJwXiHYpxAUsN4M1Bq/ueihu3DH3hBv/iOC2Rum9jGs0UZI1SDg=
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(53546011)(6512007)(36756003)(107886003)(186003)(2616005)(26005)(8936002)(31686004)(6506007)(71200400001)(316002)(5660300002)(38070700005)(508600001)(66476007)(122000001)(91956017)(66556008)(66446008)(76116006)(66946007)(82960400001)(8676002)(966005)(64756008)(4326008)(54906003)(6486002)(4744005)(38100700002)(86362001)(2906002)(110136005)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?d2hXU3N0TmJlUmVNLys2czEyL2ZqSHRLeVVuNDZ4OEhlMmtrWFhUY3EyTmcz?=
 =?utf-8?B?Q085VTQzN0FUTnkwSEtUb05XQUQ0cG5SOHVTU1h0bDI1ZDBQcnpKem5IM1Bw?=
 =?utf-8?B?WnpaQVVnbW1NSG42Y1kxQTByU29RQUs3eUsvNmY1eVdtVlJaRVdLTXV0RXo3?=
 =?utf-8?B?cXhuNkx3VVdDVVBKVXl5R01lTWg4WU5wWTM3WjNocXZvODZueGRBRUVNcWtQ?=
 =?utf-8?B?NjdGWXFFVTFocC9hSTZZMkNOdTk5ZFVYdHN6cmUxK3BxVndnVldQWDZOMlRV?=
 =?utf-8?B?QzJPQTk5RVJKenpjSTVZNzFzV1FQZVJkVkJUZnVtMkxSMGx5dXFNYzZ3cllI?=
 =?utf-8?B?eVFST1VBRXFVcmplWHkvSXZNc1E0V08xNzFaanhOZHF0Z253K2NEWStzY0pp?=
 =?utf-8?B?clRWWkN0MFBsaHJWSml1S2hJdkp2cXNwM1psc3pzS0RXM1JrcElVZHQzR2Jl?=
 =?utf-8?B?Rkk1K2FxL2FWKzArU202cDRGbGZGODUwbnhRMFlPbVh2OEJVYVFFVUtlbUZx?=
 =?utf-8?B?WXB4cHE3T29GVXhjT0R6Yi9tYXRWSGVkaGVoMERFNjBncWdTdEVXVlN1QnZC?=
 =?utf-8?B?cnBIaWdabjJicHVIbWp5NDZqWTRUeWxKYnQ4NmFrN3EydHd2dGRyZy95dmt1?=
 =?utf-8?B?cldHenFvbi9HTmNEanlnOW1YVlZxNjJvQ01KZnNpRlBVdDMvd0R5b0UyQ1Jh?=
 =?utf-8?B?aUoyWGdZSVNCUU5odXdaTGVRczJGZXFnS25scWhzZE9VeHEyeGx6WWdSVFRV?=
 =?utf-8?B?YjRKMndpU0FkeE9nSXdDaTdRUnJtY2Y4eHN5bzFqczUvM1dVcFIyUlY3ZVlM?=
 =?utf-8?B?cURCWGhFTnlsZkYzdUlQcTZhb2pyYXZBZmV0ekhlQzdmckhpYjBCZDRKYnBP?=
 =?utf-8?B?SmUvSGJLWjZ3VndXSkhrL2h1cEpoby8yZ09aR01LYVlzenRmb3NwMkwvLzgx?=
 =?utf-8?B?S1FYOGJyWW82eDVrZm5uaVhmTzJRWFlVSWdCbjdubm40WWxkL3lIV3dkaTd5?=
 =?utf-8?B?Mndua01Qdm1ldFBOSEZIWmFuTGk3eTJnN2NCNGFqYjBsQXpOKzFyUHdIajQ3?=
 =?utf-8?B?M0N5S1V3Z1IvQXFteVJUUG8zTHM1ZzNlSDFoald5SXJJV2NrT214bS90YlJ0?=
 =?utf-8?B?dHBIUnROS2VVQnpzMUtxTmEyLzZCU1JUTTBTZ2pPOXNvdVk5Tmh6N2laUFhz?=
 =?utf-8?B?OTR6YU8vZTNFRzEwWFRiVUNrSkw3MjQ4bTlwc1BnTERiaHkxWUt5RStJNkZj?=
 =?utf-8?B?RWdtWmxuUkdVdk4yYktBMGYwT1c3SHVoYzhGMjQyM2JEOUlHV0luaGdsSUFG?=
 =?utf-8?B?dWZMT2ppaysxdDFDU05MZktWTG5NT0lYMDFubDVYS01NY24zTGdCaDd3MjBC?=
 =?utf-8?B?ZExUcFA5YVJvemkwQ3lBdmp1TE0wS0V0SXdUb00rZDViMHlJdHZzL2JxZndJ?=
 =?utf-8?B?TXI1cmR5RWdyK2I2U29LSUFKbVhJODAzT1ozVzV5T1lnVUZNcjJPdGQwZEI1?=
 =?utf-8?B?TlJMKzRRa2FaSThJS3E3VEg0Q1MzQUhwb1FnSXh0L2dXTlNKNDVzYlc0bWlz?=
 =?utf-8?B?bTROdExIMytNMUVCSHBCUVpFM2VoS25leUdDR282S0NhUkhubDZFOHlQbnRP?=
 =?utf-8?B?WkFQMWMzRW5xbEMwTkJmZ2FaeTFUaUp6MWVLMlBmSWJPVkVJRjY3VWhxd0h4?=
 =?utf-8?B?NndHRXNSekdYakpZMTJESjRuZERZcHRncUN1QTViQjNwOHU0SEhHdWFIa1ZP?=
 =?utf-8?B?eDllTHJHOTBGbSt3YXcrbXV2R2VRZTNzNDJ3aTZZT0VFWnd3Sm9waDhIWEJr?=
 =?utf-8?B?M0hsQW16bU5tWUthTHBtM0ZZZ3lDaXpDZThFRExBZVdTZkNlNUlpSERDWmJN?=
 =?utf-8?B?WEdxRjNackNQWDNYOXNENnVWK0VPR01DNlA1dG9rVFFnRmJSY2Z0RWUrVWY5?=
 =?utf-8?B?Zjl1TVJqblIzQ01BdTN6K1AzVU1jT1ZLRlVvU3RtcnNUSGhvME9xS3VNQnhD?=
 =?utf-8?B?RFQrZStKY0RoeXBwN0ErNjlUWnl6QTVuclZsdHlpUHdRa08rY0FxL0RDSDJY?=
 =?utf-8?B?VGJlMHowUGNpYjY2VWlEdTg5b3FTdCt1RzNyWHRQbWhPcXZ0WHJYbXNLdWlV?=
 =?utf-8?B?RW5vR3A0aCtFQWIxenQ4NU1TMVNIb1pIYWZHaFoxVkhWSVAxZWttTUZKL0Nu?=
 =?utf-8?B?WEVWV2xHeUZGN2dxbHk1eEpuRGEwNWRSUnZJTnJEVFlHYnBZdWhJc1JCYjNK?=
 =?utf-8?B?RGwraG55S1NHQjJVMHNCciszeS9RPT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <DE1F37170044C842B5086F5798019C7B@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ed36e512-cfdf-4adb-e393-08d9f787eab5
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Feb 2022 11:22:17.8976
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ZKSO7j9zx85vOauA/Id9y72CewJFjbFrsHNfDuUcnNpqN6YxHVWTmWvTKrnvOP0Qr6D754+TQha66mrxBYqQQCcMQU/ytOymKlbwnQyj/1A=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB4815
X-OriginatorOrg: citrix.com

T24gMjQvMDIvMjAyMiAxMDoyMSwgQW5kcmV3IENvb3BlciB3cm90ZToNCj4gT24gMjQvMDIvMjAy
MiAxMDoxNCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+PiBXaXRoIHZlcnNpb24gMi43IEknbSBvYnNl
cnZpbmcgc3VwcG9ydCBmb3IgYmluYXJ5IHNlYXJjaGVzLCBidXQNCj4+IHVucmVsaWFibGUgcmVz
dWx0czogT25seSBhIHN1YnNldCBvZiB0aGUgc3VwcG9zZWQgbWF0Y2hlcyBpcyBhY3R1YWxseQ0K
Pj4gcmVwb3J0ZWQ7IGZvciBvdXIgcGF0dGVybiBJJ3ZlIG5ldmVyIG9ic2VydmVkIGFueSBtYXRj
aC4gVGhpcyBzYW1lDQo+PiB2ZXJzaW9uIHdvcmtzIGZpbmUgd2hlbiBoYW5kaW5nIGl0IGEgUGVy
bCByZWdleHAgdXNpbmcgaGV4IG9yIG9jdGFsDQo+PiBlc2NhcGVzLiBQcm9iZSBmb3Igc3VwcG9y
dCBvZiAtUCBhbmQgcHJlZmVyIHRoYXQgb3ZlciB0aGUgb3JpZ2luYWwNCj4+IGFwcHJvYWNoLg0K
Pj4NCj4+IEZpeGVzOiA0ZDAzNzQyNWRjY2YgKCJ4ODY6IEJ1aWxkIGNoZWNrIGZvciBlbWJlZGRl
ZCBlbmRicjY0IGluc3RydWN0aW9ucyIpDQo+PiBTaWduZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8
amJldWxpY2hAc3VzZS5jb20+DQo+IExvb2tzIHBsYXVzaWJsZS7CoCBUZW50YXRpdmUgYWNrLCBi
dXQgdGhpcyBkZWZpbml0ZWx5IG5lZWRzIGEgZnVsbCBydW4NCj4gdGhyb3VnaCBDSSBiZWZvcmUg
Y29tbWl0dGluZy7CoCBMZXQgbWUga2ljayBzb21ldGhpbmcgb2ZmLg0KDQpTdGFydGVkIG5vdzoN
Cg0KaHR0cHM6Ly9naXRsYWIuY29tL3hlbi1wcm9qZWN0L3Blb3BsZS9hbmR5aGhwL3hlbi8tL3Bp
cGVsaW5lcy80Nzg1MDg0NTkNCmh0dHBzOi8vY2lycnVzLWNpLmNvbS9idWlsZC82MjU1MTk2MDE4
ODM1NDU2DQoNCldlJ3JlIGdldHRpbmcgY2hyb25pYyBuZXR3b3JraW5nIHByb2JsZW1zIGluIGdp
dGxhYiByaWdodCBub3cgc28gdGhhdA0KbWlnaHQgcmVxdWlyZSBhIGxvdCBvZiBwZXJzdWFzaW9u
IHRvIGJlIHVzZWZ1bC4NCg0KfkFuZHJldw0K


From xen-devel-bounces@lists.xenproject.org Thu Feb 24 11:25:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 11:25:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278181.475338 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNCFe-0005wY-Qj; Thu, 24 Feb 2022 11:25:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278181.475338; Thu, 24 Feb 2022 11:25:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNCFe-0005wP-Nb; Thu, 24 Feb 2022 11:25:38 +0000
Received: by outflank-mailman (input) for mailman id 278181;
 Thu, 24 Feb 2022 11:25:37 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=VLhp=TH=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nNCFd-0005vy-9r
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 11:25:37 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7c263a3f-9564-11ec-8eb8-a37418f5ba1a;
 Thu, 24 Feb 2022 12:25:35 +0100 (CET)
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur01lp2051.outbound.protection.outlook.com [104.47.0.51]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-41-s1oWWFv0Od2u7TP4L29G0g-1; Thu, 24 Feb 2022 12:25:34 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DBBPR04MB7819.eurprd04.prod.outlook.com (2603:10a6:10:1e9::5) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.24; Thu, 24 Feb
 2022 11:25:32 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.024; Thu, 24 Feb 2022
 11:25:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7c263a3f-9564-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645701935;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=xVhLCFxOs03sXQgHjR3yfZCmm0yisoVBHJMEff/v1K0=;
	b=hhrG0q6ez4NOuBIlY9Q4k86LJFx4I12rW9IjwBfDjtKnJnvFYEQCrKjAJrMXI4kla2nnTK
	oEzNfyFo3k45vQs1IZbzF1xxFP62oEpgGad8ARBjFvfXR+NVFCgx/8gocimWZ8543XBehb
	kF0IBLDFtCKJsuI2tlHLokRr8qNr8vs=
X-MC-Unique: s1oWWFv0Od2u7TP4L29G0g-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=K9K0m1RrgPXZU/DKVYyukCLMx13iwkgG4wLDQZxv58uRhhTRobsul57XgiEjpUyPhjqdMv0NISW819a5j801YvZMM3NHJr27R4xg6CZJQYbqXJ7wu4OlGqEdHzhlUovBygajt/+y3kxjxwIQX9e9ujP1jf532/fZibWrWse1kEziCddcO7tPBOl9GjIunG1NmKGF0mm11WWh4DCi/Oio07giuZqgNoabcg/wHcZtmfWdqlVtBAyCC1O3TLbADB+Pmdn3lgaDVgs8q+eKhB+yCdgqBlTMcYzkoFMi5aW6ZzOGq2u7BKmRO6e/77yXUlXmeEGYIrg6byxRhDn4f5YxHQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=xVhLCFxOs03sXQgHjR3yfZCmm0yisoVBHJMEff/v1K0=;
 b=gxYklretn385tupXiRBrSVW+ZoYDJ/cD1yizYH5+UMeeIOFUJGpYNysiXhR9NrLEcTU7EHH5QArTC2uShHisuTtzEswyxw9zCGUT53Gx/xo69nukTwB/6T+DPsSFtTS0aL35+MigCVkqN8uaP7Rbt2ym6SMHOsBP5seM1DA0o5u3bLy2p0woxeT0Vs300YtPxpbaE23n2HA9Nra3lZmKp7i3AvVDI9qqsS3FRYo1orW5pmIsPCGsUFwK6k/QH/Va1UlOeIwRvLC8O7A/tDCIkDFnis+G9D+ChVGTpKmLdd/+vWbzP4Wkl0Caj45byYYC1ahV8dtHczPYZP/pfVrd/Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <68d40be4-9ced-01bf-8bc3-585f11827504@suse.com>
Date: Thu, 24 Feb 2022 12:25:30 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Ping: [PATCH v2] x86/time: switch platform timer hooks to altcall
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <5f1f49e6-1380-73bf-d68f-6eb9dd05cad6@suse.com>
In-Reply-To: <5f1f49e6-1380-73bf-d68f-6eb9dd05cad6@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR01CA0048.eurprd01.prod.exchangelabs.com
 (2603:10a6:20b:e0::25) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c57a7236-55a4-45f0-e45e-08d9f7885e5f
X-MS-TrafficTypeDiagnostic: DBBPR04MB7819:EE_
X-Microsoft-Antispam-PRVS:
	<DBBPR04MB7819636E42AD2C4255134332B33D9@DBBPR04MB7819.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	4ch5IdvR69PT8OKUsB/u6Y9llsD+ztPLsMTplw0H///Eg7fou5su0BYZ2vFI3Hcwf8kcK8CCyI02A1TF+HNbIXWdRNxYHHPkh99XlkjLsw+o1Dj+uSKpChC/BEzSI681c9nWjmk/nzNQAXlK8jXxgvRXDoZwJXN8nD4/OLGzlx4WuIZQZeI6aHoUa8wRpdA2qoHNkoj5IPFktfjjOfO0Q6lzTq3xGIQndlmYTaayLrQmp9qezZ9cYtonQBZ9PbzIr6o09uFfOgwqtl8mCOe0r6p1RRKdrwLL6a/m/SU1K4PnVVncuClzWt5sOl89FsvXrPQXUX4+iyev23ib9etFyHTmtoALfvTlN0kj6jF/o84g0EKJjsaFyeBslwtCHZm08ttsoyNre5wFl2zgJnjTS2f0lLLItVhJBi7zd61sdhsnF6Ro5ZMvBQEb5YIPu2rhdO8O75ZuLbent9loOYGQuFi+t3N579sN11bKyfurJbTth2VjmpUIeSV7+ZHLJS3V79PH34UHhkPBJoWnlqOVLb3PPSo1X4gAWKZhxaP9NZypMxRY6fzp5op4qlzbjQRr15EH/8UW8sL9Uc8y4MLr6T5PUPofmcCenn5908gP1R9mbEKzORDCwr0tGiSTSZ2d+rAHk8ioOzX54D38SVEV3osNebD7av5t5bfBMZgH6AxxhayQ5Gvtm13QfRnMD+k7FrHORERKzVpachP+1dQpz7PhTGJSCAH+nr45jk/3+vs=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(186003)(2616005)(83380400001)(26005)(36756003)(31696002)(31686004)(316002)(8936002)(86362001)(2906002)(6506007)(53546011)(508600001)(54906003)(66556008)(5660300002)(4326008)(66946007)(6512007)(66476007)(6916009)(8676002)(38100700002)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?WFdRdlJpVGJjRzFHRGhKTkI1WFRQNFNxU3dqbFFIZUtHQ3QvV0toS3hkNUJS?=
 =?utf-8?B?eG5BRnprQXZnMnZ4VEUyODhrTi9ReHRucTRqZUJtemwzUE9RVzgybG8yQWFw?=
 =?utf-8?B?c0U5cURhbWN2dXZ1RVZDNTRZYm13ekxFOUY0czVIRTFzcjZWTHFGOVRSWnR1?=
 =?utf-8?B?NkZYakErMHFUK21CeXNiaFFhcnVrdE5WbzhRbHJqNktzUXQwODJBejcxNWVa?=
 =?utf-8?B?d3VLR2twcFhBY0R1S21XSlJleXgvZHI4UDRONnRQdTFPTUJHTVhTOU1lNGZB?=
 =?utf-8?B?emhudnErZXNrL3BDMmZSam96YjN4RldWdG8raXNGeWJaSUhGREhLdzRjd3NH?=
 =?utf-8?B?VGVtbHJDcllTODRRdDR0K1MwLzU2KzkwaVRmWERvNWlsUUZTNTcrbjZzWDBz?=
 =?utf-8?B?Yk1oUXJ3bTFVRlFlcW8vVEU4QURFM3pYR2s4TVREZjBZOU1DWEpJWEczNVRZ?=
 =?utf-8?B?QjdrRXN3bzFZcTlJVFJ3clJSM0drU2RCdXVndUJ1TFhHL3Ztb2xnSC9oeVRi?=
 =?utf-8?B?NUJRczlmTkF1TVMyRW1VZnYwTFJpQWw5U3hSSzRmQ0JEQVRHK3dYZjJENnRJ?=
 =?utf-8?B?eTJ4TmJZTDJsSVJ1M3F0S1JVM1FVb0V3S1Z4NFVLMXRYdGR1RUhGcHV6Z216?=
 =?utf-8?B?SXNiSHlUNXpBL2tRMTkxdE5qZ1QrcnkvcHBNTHZpWjJWc2xldi9VRzY0dWFa?=
 =?utf-8?B?cFJhbGRkaUdPZTZXKzFCVkNTUWRDeUhGR0hXVHRma2pVeFBLdTlUU08yUVgy?=
 =?utf-8?B?aEJISWk4NitFanI5eGpyejgwazBqeDk2Nm9PMExLbUV1WnlHWlNialU4bGtB?=
 =?utf-8?B?NWFIMDdIbHgrZVJnYzJtT2t0cTRvN2RjVTE4aWZRRmU2SFFnZ01mVEZHY1dx?=
 =?utf-8?B?OFdPVmtGVm9aYnlzb2x0SG13cEUrK2VGQko5V2Fvd3FYOE8wS1hLbmJGejRH?=
 =?utf-8?B?Y05SVkUwTm5nWUQyMVVGTTFXNjUzeWpBVUxWQ2s3V2k1RDNoWWJwVFZsOHFG?=
 =?utf-8?B?WTd3WlppejBLaUpwSTV0YWo2anVheGdyRHViNDFiWCtvRUJlY2VURjduejhm?=
 =?utf-8?B?bFdROC9iZTVXYW1kdndtL21sd3VzTmY0R0U0NDdiZU12UmEydjZXZTNsUkIx?=
 =?utf-8?B?VFVpZWI4Q0NYU0taQnJOOEx0cVJUcEVLSFRKUGJLZGljdnh5OHdBVUdjdDlB?=
 =?utf-8?B?MCsrYkdqWjBzSEtrQWV2WG5tR3Z5cUp6ZzhJS3hGT3NGRFpTYmQvazVWcVA2?=
 =?utf-8?B?RXl6emV5djRIemxlTUFvYXJHb25wVGdTVUs2aWRWQWM3dURXN29xang3YXdm?=
 =?utf-8?B?U0prNFI2K004bVZZOCtZNjBNb0JTQ0l3dkNyQnh1ZG5xeUNlOEFSb3g0dXhs?=
 =?utf-8?B?SXlyTzVlblRVcmYvb0pXd1JuT1ZQZForWU85dWpIeU9CU3lwRUt2dW5IVS9q?=
 =?utf-8?B?anVYNjZJNDg0dUljZ1l4SUJSTWFIWk94czZSOS8yK2hEdDhGVWQ0TklMQTZB?=
 =?utf-8?B?dVlaUCtRS0czc2E1bFBoM3RiYWtPTTlySmdQQ3ZFdStaUG41U0lkcVlTRFpx?=
 =?utf-8?B?Zm9WK2xNYVN3aTRkVVRmc00rQkp5NjJ5Z0FLYWRhTFhvOCtjMkhZaVllRE5W?=
 =?utf-8?B?YWV1ZnJFelQ1N2hTY0VCUms1OHVPTzRSRGhKZlU3ZjlZTDdWdTdRZFRHMk9i?=
 =?utf-8?B?Q2RQcERxa2xKODFlQWJDZFFlK2dORFdFZHBQdjBHeDVVZ3krMGozZUVSRDlH?=
 =?utf-8?B?SFNsTlgyYjBQbldKdFovc0VRTmJoMzdKRzRHS25pYmRVZ0NQREsyWlZROUFu?=
 =?utf-8?B?Zlc3Tm44d3hueTd0U0ZPS2R4UzFGYUVDMS9JY0lSRitrTjJmL2t1azJiTWRS?=
 =?utf-8?B?YXRLQjFOL2pab3VkRmhJZ0FOQ00xc0p2eldaV1JtRTdXdGJ5S0FaYzRqTzBv?=
 =?utf-8?B?c2JhZ3JMZDdLUys1REFZSFVOcmFBWnkxM010YUQyVUdJalJGWDRuL3FHeVc3?=
 =?utf-8?B?cmJybUVxRko5aC9Jd0ZxcWF3TmRQVG9RejJzOVczbUxHQnBkL2w3cFlQQ21I?=
 =?utf-8?B?MGp5UzZaVllIejIxTm53c1NGQ1lIRE53M3VWa2lkT0M4aWJIUyswRG5sTmhK?=
 =?utf-8?B?Sm5OL25pZG1oVFpmemNVbGwvQkR5SHdzbVBXMU5Qc29Ob1AzcStyV2NLMFh2?=
 =?utf-8?Q?lEg7BR7Ch5TByn/uhQxEdgw=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c57a7236-55a4-45f0-e45e-08d9f7885e5f
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2022 11:25:32.2935
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /oUJljZznaujQMfvTmPCzHfSykPpbvTcqC1FufuP6KL3Ge9Ebvfs6e7SJ+dlYu/7FrHcEwtjcqAAqkVdShKaUA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7819

On 13.01.2022 14:17, Jan Beulich wrote:
> Except in the "clocksource=tsc" case we can replace the indirect calls
> involved in accessing the platform timers by direct ones, as they get
> established once and never changed. To also cover the "tsc" case, invoke
> what read_tsc() resolves to directly. In turn read_tsc() then becomes
> unreachable and hence can move to .init.*.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

As this actually amends the IBT work, I would have hoped for it to be
viewed as useful. Of course if accepted in general, it would now want
to have __initconst_cf_clobber annotation addition included. Albeit
there's a slight complication: Some of the structures are written to,
so those couldn't really be "const".

Jan

> ---
> v2: Avoid altcall patching becoming conditional.
> 
> --- a/xen/arch/x86/time.c
> +++ b/xen/arch/x86/time.c
> @@ -66,6 +66,7 @@ struct platform_timesource {
>      char *id;
>      char *name;
>      u64 frequency;
> +    /* This hook may only be invoked via the read_counter() wrapper! */
>      u64 (*read_counter)(void);
>      s64 (*init)(struct platform_timesource *);
>      void (*resume)(struct platform_timesource *);
> @@ -578,7 +579,7 @@ static s64 __init init_tsc(struct platfo
>      return ret;
>  }
>  
> -static u64 read_tsc(void)
> +static uint64_t __init read_tsc(void)
>  {
>      return rdtsc_ordered();
>  }
> @@ -810,6 +811,18 @@ static s_time_t __read_platform_stime(u6
>      return (stime_platform_stamp + scale_delta(diff, &plt_scale));
>  }
>  
> +static uint64_t read_counter(void)
> +{
> +    /*
> +     * plt_tsc is put in use only after alternatives patching has occurred,
> +     * hence we can't invoke read_tsc() that way. Special case it here, open-
> +     * coding the function call at the same time.
> +     */
> +    return plt_src.read_counter != read_tsc
> +           ? alternative_call(plt_src.read_counter)
> +           : rdtsc_ordered();
> +}
> +
>  static void plt_overflow(void *unused)
>  {
>      int i;
> @@ -818,7 +831,7 @@ static void plt_overflow(void *unused)
>  
>      spin_lock_irq(&platform_timer_lock);
>  
> -    count = plt_src.read_counter();
> +    count = read_counter();
>      plt_stamp64 += (count - plt_stamp) & plt_mask;
>      plt_stamp = count;
>  
> @@ -854,7 +867,7 @@ static s_time_t read_platform_stime(u64
>      ASSERT(!local_irq_is_enabled());
>  
>      spin_lock(&platform_timer_lock);
> -    plt_counter = plt_src.read_counter();
> +    plt_counter = read_counter();
>      count = plt_stamp64 + ((plt_counter - plt_stamp) & plt_mask);
>      stime = __read_platform_stime(count);
>      spin_unlock(&platform_timer_lock);
> @@ -872,7 +885,7 @@ static void platform_time_calibration(vo
>      unsigned long flags;
>  
>      spin_lock_irqsave(&platform_timer_lock, flags);
> -    count = plt_stamp64 + ((plt_src.read_counter() - plt_stamp) & plt_mask);
> +    count = plt_stamp64 + ((read_counter() - plt_stamp) & plt_mask);
>      stamp = __read_platform_stime(count);
>      stime_platform_stamp = stamp;
>      platform_timer_stamp = count;
> @@ -883,10 +896,10 @@ static void resume_platform_timer(void)
>  {
>      /* Timer source can be reset when backing from S3 to S0 */
>      if ( plt_src.resume )
> -        plt_src.resume(&plt_src);
> +        alternative_vcall(plt_src.resume, &plt_src);
>  
>      plt_stamp64 = platform_timer_stamp;
> -    plt_stamp = plt_src.read_counter();
> +    plt_stamp = read_counter();
>  }
>  
>  static void __init reset_platform_timer(void)
> 
> 



From xen-devel-bounces@lists.xenproject.org Thu Feb 24 11:52:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 11:52:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278191.475348 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNCfU-0000sr-33; Thu, 24 Feb 2022 11:52:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278191.475348; Thu, 24 Feb 2022 11:52:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNCfU-0000sk-03; Thu, 24 Feb 2022 11:52:20 +0000
Received: by outflank-mailman (input) for mailman id 278191;
 Thu, 24 Feb 2022 11:52:18 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=YdJg=TH=xilinx.com=ayankuma@srs-se1.protection.inumbo.net>)
 id 1nNCfS-0000se-GI
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 11:52:18 +0000
Received: from NAM02-SN1-obe.outbound.protection.outlook.com
 (mail-sn1anam02on20602.outbound.protection.outlook.com
 [2a01:111:f400:7ea9::602])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 33f82212-9568-11ec-8539-5f4723681683;
 Thu, 24 Feb 2022 12:52:14 +0100 (CET)
Received: from DM6PR21CA0019.namprd21.prod.outlook.com (2603:10b6:5:174::29)
 by MWHPR02MB3263.namprd02.prod.outlook.com (2603:10b6:301:67::29) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Thu, 24 Feb
 2022 11:52:10 +0000
Received: from DM3NAM02FT061.eop-nam02.prod.protection.outlook.com
 (2603:10b6:5:174:cafe::d5) by DM6PR21CA0019.outlook.office365.com
 (2603:10b6:5:174::29) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.9 via Frontend
 Transport; Thu, 24 Feb 2022 11:52:10 +0000
Received: from xir-pvapexch01.xlnx.xilinx.com (149.199.80.198) by
 DM3NAM02FT061.mail.protection.outlook.com (10.13.4.230) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5017.22 via Frontend Transport; Thu, 24 Feb 2022 11:52:09 +0000
Received: from xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) by
 xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2176.14; Thu, 24 Feb 2022 11:52:08 +0000
Received: from smtp.xilinx.com (172.21.105.198) by
 xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server id
 15.1.2176.14 via Frontend Transport; Thu, 24 Feb 2022 11:52:08 +0000
Received: from [10.71.117.160] (port=52939)
 by smtp.xilinx.com with esmtp (Exim 4.90)
 (envelope-from <ayan.kumar.halder@xilinx.com>)
 id 1nNCfI-0004Q2-1V; Thu, 24 Feb 2022 11:52:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 33f82212-9568-11ec-8539-5f4723681683
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=abQ1ypetRZK3kvIjehD/4iqKAoCEsH6TOv+kzm+bqFh/TTKKqHbLVqAUB/On5O43qnW3lrwnB+FHMhfurOah6UplnW0Z+jsr1KX2U68f+HJZaR7SqZB82IlI2UwxveGQwbW8Q95vG/Hb1T1qTGErAlE+CfCHBFNBhVB1Mekci1lishNMAmIZQrTeZ1lfME6a5SyXKMfEV8/wMhnsIq7ZGJbGGUwyafEsEgIRPip4RdHs0sXwk0+QvPwd8nZ1y6S57WPrVjZDRQYNcULMZbifKwyn37fegxF2F10HJLZfShxLTrk616z7BbXLJRu6W+aU323y/UhOS7BnHwG4ykC4Ww==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=xVrjslPv3gt8iFlmxkUL7Svwo3yvaf6VhUzZ7WVUCsQ=;
 b=PyEmFDouJvCGz3hu/391ulGmT+zoO+Ics0dOJl+5HPPXUrVOBxD4yusjcH8xuPlxr15VEQcvBLTROLY6skrUj2DeQEAaro0Q5vEx12rBTxUV6dJCFMqA3q/xwr1YmundQnMk7tFtyyzPT5k2td0NR6mY4CQ+t0iCk6Ix1AWdPZxrdh9vBfAJ70xY3H43FMdeMAK7Cwq4xQImHKWjaP4ic7P6Ld6SPQYuwsEIm4KixSYyjfuxVUKL5OagVlsMSgkCwxJMMn30M7PhfRYh0usZydeGvaRym7gDjOtjfNJmPtoEdEBegi1Y1FJKO1owH+Ml9MaqAFXNuGdsSm9CItinDA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 149.199.80.198) smtp.rcpttodomain=arm.com smtp.mailfrom=xilinx.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=xVrjslPv3gt8iFlmxkUL7Svwo3yvaf6VhUzZ7WVUCsQ=;
 b=Bnp1COZBEa2Fj08kZpRoA0OiDOFFZVTPlywVkhXJqRmILnK8h3Ys5D6/lOXFyLOi7j+LvlNDn67WCy1//nCqAU+EhZ6WlOdnV+vthcM0XaCWw6thBt6kvhHI3Lm5428oQAtrVeZRlR6lZbBqjNho1tLcl+FD764LJ1aChxAEywM=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198)
 smtp.mailfrom=xilinx.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=xilinx.com;
Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates
 149.199.80.198 as permitted sender) receiver=protection.outlook.com;
 client-ip=149.199.80.198; helo=xir-pvapexch01.xlnx.xilinx.com;
Message-ID: <a0c4c458-152e-750b-9e26-63a6d544e836@xilinx.com>
Date: Thu, 24 Feb 2022 11:52:07 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.1
Subject: Re: Proposal for Porting Xen to Armv8-R64 - DraftA
To: Wei Chen <Wei.Chen@arm.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "julien@xen.org" <julien@xen.org>, Stefano
 Stabellini <sstabellini@kernel.org>
CC: Bertrand Marquis <Bertrand.Marquis@arm.com>, Penny Zheng
	<Penny.Zheng@arm.com>, Henry Wang <Henry.Wang@arm.com>, nd <nd@arm.com>
References: <PAXPR08MB7420A01809B84E04E196793F9E3D9@PAXPR08MB7420.eurprd08.prod.outlook.com>
From: Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>
In-Reply-To: <PAXPR08MB7420A01809B84E04E196793F9E3D9@PAXPR08MB7420.eurprd08.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 75101160-a114-48ee-824b-08d9f78c16ca
X-MS-TrafficTypeDiagnostic: MWHPR02MB3263:EE_
X-Microsoft-Antispam-PRVS:
	<MWHPR02MB326398A494E171648CD86CDEB23D9@MWHPR02MB3263.namprd02.prod.outlook.com>
X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	VxHYoTLIP/gzkkt/Y59lVNf5lOQg5cEqpCFbQ/OMoYKMMKab3uwgqDdsrHOwXHm0M5o1OrxstrJwBR+2u+Tlxi9256D3bXyj4oxokqYIGeCpBJhIZZcOz5E8TRcemgmcWnuLnVD4PZ6T54GAsg0UeHW0i4RaccU1Q9wTuauiBhRgr8Snzyw2TA/TJWT/8gDsbVAZ2qrJk769f4ShCQfgw6xMsMc5SZ8uwyTtxFfTge8ZZ6EJOXg+GgTOjra/dPyK5CsyWMxYQk+wqg657tKU+VnyZVNYVhMy88yZnRkBOJN/5SS/KDn2DXKI1K4C4b7Fpx6NATYGhUy+uKp6jDDNpulY3k2x9gieYxZ1aEVCbEsdjCY8l1G9Rd0JYReDqaT1iNea/xulAGFE+DL7mlclVZWIlzX9+LJg60ZJRMOdI4DIsqHqr3RjtqQutQxALC8peJQkVBbXqdW5ljKb4ZmtgPPvEyIS5WQkkV5WS+JBz+5aNn0PI/dbLLc04xL1GynYLXmRUbXVQyZUyr0ZAsX3f6AFBuTwppTy4QSk9gQcExzE8SFJL5CRDE75CjBkJG5WW+LTpcA9R6zOGWLuWaFFLxt/fURpaip1D9cSNeaaEVCYaR3PPrgxoPXEWpcy3t55YKDMCaaP9ykW9bpLttZ3HJ4ogiKcT9/mPe06Lmjlb6nzTslxxRzdHNkT89Q8dzcsi0M8F7itOvNmj7ATMk3qbH4rNNUNoShftQteQ/zeVBCWLYUSPva0b5Mf6MEwvupS6MMqwVRa6ZnblYoExHvWbn3oLJFX744O9LNgZtqf7ynT1hm4wV8d8YbBS10FggCu9O3OWRt6//lAD7vk7ruWTGcWpJYSOdbLWom/XQ7FqnY=
X-Forefront-Antispam-Report:
	CIP:149.199.80.198;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:xir-pvapexch01.xlnx.xilinx.com;PTR:unknown-80-198.xilinx.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(8676002)(26005)(186003)(53546011)(31696002)(82310400004)(336012)(30864003)(83380400001)(70586007)(8936002)(426003)(5660300002)(70206006)(2616005)(9786002)(4326008)(40460700003)(47076005)(31686004)(36860700001)(36756003)(508600001)(316002)(7636003)(356005)(110136005)(54906003)(2906002)(50156003)(43740500002);DIR:OUT;SFP:1101;
X-OriginatorOrg: xilinx.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2022 11:52:09.7301
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 75101160-a114-48ee-824b-08d9f78c16ca
X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.80.198];Helo=[xir-pvapexch01.xlnx.xilinx.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DM3NAM02FT061.eop-nam02.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR02MB3263

Hi Wei,

This is a nice writeup. I have a few initial queries.

On 24/02/2022 06:01, Wei Chen wrote:
> # Proposal for Porting Xen to Armv8-R64
>
> This proposal will introduce the PoC work of porting Xen to Armv8-R64,
> which includes:
> - The changes of current Xen capability, like Xen build system, memory
>    management, domain management, vCPU context switch.
> - The expanded Xen capability, like static-allocation and direct-map.
>
> ***Notes:***
> 1. ***This proposal only covers the work of porting Xen to Armv8-R64***
>     ***single CPU. Xen SMP support on Armv8-R64 relates to Armv8-R***
>     ***Trusted-Frimware (TF-R). This is an external dependency,***
>     ***so we think the discussion of Xen SMP support on Armv8-R64***
>     ***should be started when single-CPU support is complete.***
> 2. ***This proposal will not touch xen-tools. In current stage,***
>     ***Xen on Armv8-R64 only support dom0less, all guests should***
>     ***be booted from device tree.***
>
> ## 1. Essential Background
>
> ### 1.1. Armv8-R64 Profile
> The Armv-R architecture profile was designed to support use cases that
> have a high sensitivity to deterministic execution. (e.g. Fuel Injection,
> Brake control, Drive trains, Motor control etc)
>
> Arm announced Armv8-R in 2013, it is the latest generation Arm architecture
> targeted at the Real-time profile. It introduces virtualization at the highest
> security level while retaining the Protected Memory System Architecture (PMSA)
> based on a Memory Protection Unit (MPU). In 2020, Arm announced Cortex-R82,
> which is the first Arm 64-bit Cortex-R processor based on Armv8-R64.

Is there some good document explaining the difference between MPU and 
MMU ? And when do we need one vs other.

>
> - The latest Armv8-R64 document can be found here:
>    [Arm Architecture Reference Manual Supplement - Armv8, for Armv8-R AArch64 architecture profile](https://developer.arm.com/documentation/ddi0600/latest/).
>
> - Armv-R Architecture progression:
>    Armv7-R -> Armv8-R AArch32 -> Armv8 AArch64
>    The following figure is a simple comparison of "R" processors based on
>    different Armv-R Architectures.
>    ![image](https://drive.google.com/uc?export=view&id=1nE5RAXaX8zY2KPZ8imBpbvIr2eqBguEB)
>
> - The Armv8-R architecture evolved additional features on top of Armv7-R:
>      - An exception model that is compatible with the Armv8-A model
>      - Virtualization with support for guest operating systems
>          - PMSA virtualization using MPUs In EL2.
> - The new features of Armv8-R64 architecture
>      - Adds support for the 64-bit A64 instruction set, previously Armv8-R
>        only supported A32.
>      - Supports up to 48-bit physical addressing, previously up to 32-bit
>        addressing was supported.
>      - Optional Arm Neon technology and Advanced SIMD
>      - Supports three Exception Levels (ELs)
>          - Secure EL2 - The Highest Privilege, MPU only, for firmware, hypervisor
>          - Secure EL1 - RichOS (MMU) or RTOS (MPU)
>          - Secure EL0 - Application Workloads
>      - Optionally supports Virtual Memory System Architecture at S-EL1/S-EL0.
>        This means it's possible to run rich OS kernels - like Linux - either
>        bare-metal or as a guest.
> - Differences with the Armv8-A AArch64 architecture
>      - Supports only a single Security state - Secure. There is not Non-Secure
>        execution state supported.

If so, then I guess there is no Trustzone kind of protection available. 
I mean where application is normal world can request for data to be 
processed in secure world (by switching the NS bit on AXI).

Also, does Armv8-R support Trustzone controller 400 which helps to 
partition memory into different protected enclaves based on NSAID ?

(Apologies if my queries are irrelevant, I am asking this purely out of 
my own interest :) )

>      - EL3 is not supported, EL2 is mandatory. This means secure EL2 is the
>        highest EL.
>      - Supports the A64 ISA instruction
>          - With a small set of well-defined differences
>      - Provides a PMSA (Protected Memory System Architecture) based
>        virtualization model.
>          - As opposed to Armv8-A AArch64's VMSA based Virtualization
>          - Can support address bits up to 52 if FEAT_LPA is enabled,
>            otherwise 48 bits.
>          - Determines the access permissions and memory attributes of
>            the target PA.
>          - Can implement PMSAv8-64 at EL1 and EL2
>              - Address translation flat-maps the VA to the PA for EL2 Stage 1.
>              - Address translation flat-maps the VA to the PA for EL1 Stage 1.
>              - Address translation flat-maps the IPA to the PA for EL1 Stage 2.
>      - PMSA in EL1 & EL2 is configurable, VMSA in EL1 is configurable.
>
> ### 1.2. Xen Challenges with PMSA Virtualization
> Xen is PMSA unaware Type-1 Hypervisor, it will need modifications to run
> with an MPU and host multiple guest OSes.
>
> - No MMU at EL2:
>      - No EL2 Stage 1 address translation
>          - Xen provides fixed ARM64 virtual memory layout as basis of EL2
>            stage 1 address translation, which is not applicable on MPU system,
>            where there is no virtual addressing. As a result, any operation
>            involving transition from PA to VA, like ioremap, needs modification
>            on MPU system.
>      - Xen's run-time addresses are the same as the link time addresses.
>          - Enable PIC (position-independent code) on a real-time target
>            processor probably very rare.
>      - Xen will need to use the EL2 MPU memory region descriptors to manage
>        access permissions and attributes for accesses made by VMs at EL1/0.
>          - Xen currently relies on MMU EL1 stage 2 table to manage these
>            accesses.
> - No MMU Stage 2 translation at EL1:
>      - A guest doesn't have an independent guest physical address space
>      - A guest can not reuse the current Intermediate Physical Address
>        memory layout
>      - A guest uses physical addresses to access memory and devices
>      - The MPU at EL2 manages EL1 stage 2 access permissions and attributes
> - There are a limited number of MPU protection regions at both EL2 and EL1:
>      - Architecturally, the maximum number of protection regions is 256,
>        typical implementations have 32.
>      - By contrast, Xen does not need to consider the number of page table
>        entries in theory when using MMU.
> - The MPU protection regions at EL2 need to be shared between the hypervisor
>    and the guest stage 2.
>      - Requires careful consideration - may impact feature 'fullness' of both
>        the hypervisor and the guest
>      - By contrast, when using MMU, Xen has standalone P2M table for guest
>        stage 2 accesses.
So, can it support running both RTOS and Linux as guests ? My 
understanding is no as we can't enable MPU (for RTOS) and MMU (for 
Linux) at the same time. There needs to be two separate images of Xen. 
Please confirm.
>
> ## 2. Proposed changes of Xen
> ### **2.1. Changes of build system:**
>
> - ***Introduce new Kconfig options for Armv8-R64***:
>    Unlike Armv8-A, because lack of MMU support on Armv8-R64,
But Armv8-R64 supports VMSA (Refer
ARM DDI 0600A.d ID120821, B1.2.2,
Virtual Memory System Architecture, VMSAv8-64). So it should support 
MMU, isn't it ?

- Ayan
> we may not
>    expect one Xen binary to run on all machines. Xen images are not common
>    across Armv8-R64 platforms. Xen must be re-built for different Armv8-R64
>    platforms. Because these platforms may have different memory layout and
>    link address.
>      - `ARM64_V8R`:
>        This option enables Armv8-R profile for Arm64. Enabling this option
>        results in selecting MPU. This Kconfig option is used to gate some
>        Armv8-R64 specific code except MPU code, like some code for Armv8-R64
>        only system ID registers access.
>
>      - `ARM_MPU`
>        This option enables MPU on ARMv8-R architecture. Enabling this option
>        results in disabling MMU. This Kconfig option is used to gate some
>        ARM_MPU specific code. Once when this Kconfig option has been enabled,
>        the MMU relate code will not be built for Armv8-R64. The reason why
>        not depends on runtime detection to select MMU or MPU is that, we don't
>        think we can use one image for both Armv8-R64 and Armv8-A64. Another
>        reason that we separate MPU and V8R in provision to allow to support MPU
>        on 32bit Arm one day.
>
>      - `XEN_START_ADDRESS`
>        This option allows to set the custom address at which Xen will be
>        linked. This address must be aligned to a page size. Xen's run-time
>        addresses are the same as the link time addresses. Different platforms
>        may have differnt memory layout. This Kconfig option provides users
>        the ability to select proper link addresses for their boards.
>        ***Notes: Fixed link address means the Xen binary could not be***
>        ***relocated by EFI loader. So in current stage, Xen could not***
>        ***be launched as an EFI application on Armv8-R64.***
>
>      - `ARM_MPU_NORMAL_MEMORY_START` and `ARM_MPU_NORMAL_MEMORY_END`
>        `ARM_MPU_DEVICE_MEMORY_START` and `ARM_MPU_DEVICE_MEMORY_END`
>        These Kconfig options allow to set memory regions for Xen code, data
>        and device memory. Before parsing memory information from device tree,
>        Xen will use the values that stored in these options to setup boot-time
>        MPU configuration. Why we need a boot-time MPU configuration?
>        1. More deterministic: Arm MPU supports background regions,
>           if we don't configure the MPU regions and don't enable MPU.
>           We can enable MPU background regions. But that means all RAM
>           is RWX. Random values in RAM or maliciously embedded data can
>           be exploited. Using these Kconfig options allow users to have
>           a deterministic RAM area to execute code.
>        2. More compatible: On some Armv8-R64 platforms, if the MPU is
>           disabled, the `dc zva` instruction will make the system halt.
>           And this instruction will be embedded in some built-in functions,
>           like `memory set`. If we use `-ddont_use_dc` to rebuild GCC,
>           the built-in functions will not contain `dc zva`. However, it is
>           obviously unlikely that we will be able to recompile all GCC
>           for ARMv8-R64.
>        3. One optional idea:
>            We can map `XEN_START_ADDRESS` to `XEN_START_ADDRESS + 2MB` or
>            `XEN_START_ADDRESS` to `XEN_START_ADDRESS + image_end` for
>            MPU normal memory. It's enough to support Xen run in boot time.
>
> - ***Define new system registers for compilers***:
>    Armv8-R64 is based on Armv8.4. That means we will use some Armv8.4
>    specific system registers. As Armv8-R64 only have secure state, so
>    at least, `VSTCR_EL2` and `VSCTLR_EL2` will be used for Xen. And the
>    first GCC version that supports Armv8.4 is GCC 8.1. In addition to
>    these, PMSA of Armv8-R64 introduced lots of MPU related system registers:
>    `PRBAR_ELx`, `PRBARx_ELx`, `PRLAR_ELx`, `PRLARx_ELx`, `PRENR_ELx` and
>    `MPUIR_ELx`. But the first GCC version to support these system registers
>    is GCC 11. So we have two ways to make compilers to work properly with
>    these system registers.
>    1. Bump GCC version to GCC 11.
>       The pros of this method is that, we don't need to encode these
>       system registers in macros by ourselves. But the cons are that,
>       we have to update Makefiles to support GCC 11 for Armv8-R64.
>       1.1. Check the GCC version 11 for Armv8-R64.
>       1.2. Add march=armv8r to CFLAGS for Armv8-R64.
>       1.3. Solve the confliction of march=armv8r and mcpu=generic
>      These changes will affect common Makefiles, not only Arm Makefiles.
>      And GCC 11 is new, lots of toolchains and Distro haven't supported it.
>
>    2. Encode new system registers in macros ***(preferred)***
>          ```
>          /* Virtualization Secure Translation Control Register */
>          #define VSTCR_EL2  S3_4_C2_C6_2
>          /* Virtualization System Control Register */
>          #define VSCTLR_EL2 S3_4_C2_C0_0
>          /* EL1 MPU Protection Region Base Address Register encode */
>          #define PRBAR_EL1  S3_0_C6_C8_0
>          ...
>          /* EL2 MPU Protection Region Base Address Register encode */
>          #define PRBAR_EL2  S3_4_C6_C8_0
>          ...
>          ```
>       If we encode all above system registers, we don't need to bump GCC
>       version. And the common CFLAGS Xen is using still can be applied to
>       Armv8-R64. We don't need to modify Makefiles to add specific CFLAGS.
>
> ### **2.2. Changes of the initialization process**
> In general, we still expect Armv8-R64 and Armv8-A64 to have a consistent
> initialization process. In addition to some architecture differences, there
> is no more than reusable code that we will distinguish through CONFIG_ARM_MPU
> or CONFIG_ARM64_V8R. We want most of the initialization code to be reusable
> between Armv8-R64 and Armv8-A64.
>
> - We will reuse the original head.s and setup.c of Arm. But replace the
>    MMU and page table operations in these files with configuration operations
>    for MPU and MPU regions.
>
> - We provide a boot-time MPU configuration. This MPU configuration will
>    support Xen to finish its initialization. And this boot-time MPU
>    configuration will record the memory regions that will be parsed from
>    device tree.
>
>    In the end of Xen initialization, we will use a runtime MPU configuration
>    to replace boot-time MPU configuration. The runtime MPU configuration will
>    merge and reorder memory regions to save more MPU regions for guests.
>    ![img](https://drive.google.com/uc?export=view&id=1wTFyK2XfU3lTlH1PqRDoacQVTwUtWIGU)
>
> - Defer system unpausing domain.
>    When Xen initialization is about to end, Xen unpause guests created
>    during initialization. But this will cause some issues. The unpause
>    action occurs before free_init_memory, however the runtime MPU configuration
>    is built after free_init_memory.
>
>    So if the unpaused guests start executing the context switch at this
>    point, then its MPU context will base on the boot-time MPU configuration.
>    Probably it will be inconsistent with runtime MPU configuration, this
>    will cause unexpected problems (This may not happen in a single core
>    system, but on SMP systems, this problem is foreseeable, so we hope to
>    solve it at the beginning).
>
> ### **2.3. Changes to reduce memory fragmentation**
>
> In general, memory in Xen system can be classified to 4 classes:
> `image sections`, `heap sections`, `guest RAM`, `boot modules (guest Kernel,
> initrd and dtb)`
>
> Currently, Xen doesn't have any restriction for users how to allocate
> memory for different classes. That means users can place boot modules
> anywhere, can reserve Xen heap memory anywhere and can allocate guest
> memory anywhere.
>
> In a VMSA system, this would not be too much of a problem, since the
> MMU can manage memory at a granularity of 4KB after all. But in a
> PMSA system, this will be a big problem. On Armv8-R64, the max MPU
> protection regions number has been limited to 256. But in typical
> processor implementations, few processors will design more than 32
> MPU protection regions. Add in the fact that Xen shares MPU protection
> regions with guest's EL1 Stage 2. It becomes even more important
> to properly plan the use of MPU protection regions.
>
> - An ideal of memory usage layout restriction:
> ![img](https://drive.google.com/uc?export=view&id=1kirOL0Tx2aAypTtd3kXAtd75XtrngcnW)
> 1. Reserve proper MPU regions for Xen image (code, rodata and data + bss).
> 2. Reserve one MPU region for boot modules.
>     That means the placement of all boot modules, include guest kernel,
>     initrd and dtb, will be limited to this MPU region protected area.
> 3. Reserve one or more MPU regions for Xen heap.
>     On Armv8-R64, the guest memory is predefined in device tree, it will
>     not be allocated from heap. Unlike Armv8-A64, we will not move all
>     free memory to heap. We want Xen heap is dertermistic too, so Xen on
>     Armv8-R64 also rely on Xen static heap feature. The memory for Xen
>     heap will be defined in tree too. Considering that physical memory
>     can also be discontinuous, one or more MPU protection regions needs
>     to be reserved for Xen HEAP.
> 4. If we name above used MPU protection regions PART_A, and name left
>     MPU protection regions PART_B:
>     4.1. In hypervisor context, Xen will map left RAM and devices to PART_B.
>          This will give Xen the ability to access whole memory.
>     4.2. In guest context, Xen will create EL1 stage 2 mapping in PART_B.
>          In this case, Xen just need to update PART_B in context switch,
>          but keep PART_A as fixed.
>
> ***Notes: Static allocation will be mandatory on MPU based systems***
>
> **A sample device tree of memory layout restriction**:
> ```
> chosen {
>      ...
>      /*
>       * Define a section to place boot modules,
>       * all boot modules must be placed in this section.
>       */
>      mpu,boot-module-section = <0x10000000 0x10000000>;
>      /*
>       * Define a section to cover all guest RAM. All guest RAM must be located
>       * within this section. The pros is that, in best case, we can only have
>       * one MPU protection region to map all guest RAM for Xen.
>       */
>      mpu,guest-memory-section = <0x20000000 0x30000000>;
>      /*
>       * Define a memory section that can cover all device memory that
>       * will be used in Xen.
>       */
>      mpu,device-memory-section = <0x80000000 0x7ffff000>;
>      /* Define a section for Xen heap */
>      xen,static-mem = <0x50000000 0x20000000>;
>
>      domU1 {
>          ...
>          #xen,static-mem-address-cells = <0x01>;
>          #xen,static-mem-size-cells = <0x01>;
>          /* Statically allocated guest memory, within mpu,guest-memory-section */
>          xen,static-mem = <0x30000000 0x1f000000>;
>
>          module@11000000 {
>              compatible = "multiboot,kernel\0multiboot,module";
>              /* Boot module address, within mpu,boot-module-section */
>              reg = <0x11000000 0x3000000>;
>              ...
>          };
>
>          module@10FF0000 {
>                  compatible = "multiboot,device-tree\0multiboot,module";
>                  /* Boot module address, within mpu,boot-module-section */
>                  reg = <0x10ff0000 0x10000>;
>                  ...
>          };
>      };
> };
> ```
>
> ### **2.4. Changes of memory management**
> Xen is coupled with VMSA, in order to port Xen to Armv8-R64, we have to
> decouple Xen from VMSA. And give Xen the ability to manage memory in PMSA.
>
> 1. ***Use buddy allocator to manage physical pages for PMSA***
>     From the view of physical page, PMSA and VMSA don't have any difference.
>     So we can reuse buddy allocator on Armv8-R64 to manage physical pages.
>     The difference is that, in VMSA, Xen will map allocated pages to virtual
>     addresses. But in PMSA, Xen just convert the pages to physical address.
>
> 2. ***Can not use virtual address for memory management***
>     As Armv8-R64 only has PMSA in EL2, Xen loses the ability of using virtual
>     address to manage memory. This brings some problems, some virtual address
>     based features could not work well on Armv8-R64, like `FIXMAP`, `vmap/vumap`,
>     `ioremap` and `alternative`.
>
>     But the functions or macros of these features are used in lots of common
>     code. So it's not good to use `#ifdef CONFIG_ARM_MPU` to gate relate code
>     everywhere. In this case, we propose to use stub helpers to make the changes
>     transparently to common code.
>     1. For `FIXMAP`, we will use `0` in `FIXMAP_ADDR` for all fixmap operations.
>        This will return physical address directly of fixmapped item.
>     2. For `vmap/vumap`, we will use some empty inline stub helpers:
>          ```
>          static inline void vm_init_type(...) {}
>          static inline void *__vmap(...)
>          {
>              return NULL;
>          }
>          static inline void vunmap(const void *va) {}
>          static inline void *vmalloc(size_t size)
>          {
>              return NULL;
>          }
>          static inline void *vmalloc_xen(size_t size)
>          {
>              return NULL;
>          }
>          static inline void vfree(void *va) {}
>          ```
>
>     3. For `ioremap`, it depends on `vmap`. As we have make `vmap` to always
>        return `NULL`, they could not work well on Armv8-R64 without changes.
>        `ioremap` will return input address directly.
>          ```
>          static inline void *ioremap_attr(...)
>          {
>              /* We don't have the ability to change input PA cache attributes */
>              if ( CACHE_ATTR_need_change )
>                  return NULL;
>              return (void *)pa;
>          }
>          static inline void __iomem *ioremap_nocache(...)
>          {
>              return ioremap_attr(start, len, PAGE_HYPERVISOR_NOCACHE);
>          }
>          static inline void __iomem *ioremap_cache(...)
>          {
>              return ioremap_attr(start, len, PAGE_HYPERVISOR);
>          }
>          static inline void __iomem *ioremap_wc(...)
>          {
>              return ioremap_attr(start, len, PAGE_HYPERVISOR_WC);
>          }
>          void *ioremap(...)
>          {
>              return ioremap_attr(pa, len, PAGE_HYPERVISOR_NOCACHE);
>          }
>
>          ```
>      4. For `alternative`, it depends on `vmap` too. We will simply disable
>         it on Armv8-R64 in current stage. How to implement `alternative`
>         on Armv8-R64 is better to be discussed after basic functions of Xen
>         on Armv8-R64 work well.
>         But simply disable `alternative` will make `cpus_have_const_cap` always
>         return false.
>          ```
>          * System capability check for constant cap */
>          #define cpus_have_const_cap(num) ({                \
>                 register_t __ret;                           \
>                                                             \
>                 asm volatile (ALTERNATIVE("mov %0, #0",     \
>                                           "mov %0, #1",     \
>                                           num)              \
>                               : "=r" (__ret));              \
>                                                             \
>                  unlikely(__ret);                           \
>                  })
>          ```
>          So, before we have an PMSA `alternative` implementation, we have to
>          implement a separate `cpus_have_const_cap` for Armv8-R64:
>          ```
>          #define cpus_have_const_cap(num) cpus_have_cap(num)
>          ```
>
> ### **2.5. Changes of guest management**
> Armv8-R64 only supports PMSA in EL2, but it supports configurable
> VMSA or PMSA in EL1. This means Xen will have a new type guest on
> Armv8-R64 - MPU based guest.
>
> 1. **Add a new domain type - MPU_DOMAIN**
>     When user want to create a guest that will be using MPU in EL1, user
>     should add a `mpu` property in device tree `domU` node, like following
>     example:
>      ```
>      domU2 {
>          compatible = "xen,domain";
>          direct-map;
>          mpu; --> Indicates this domain will use PMSA in EL1.
>          ...
>      };
>      ```
>      Corresponding to `mpu` property in device tree, we also need to introduce
>      a new flag `XEN_DOMCTL_CDF_INTERNAL_mpu` for domain to mark itself as an
>      MPU domain. This flag will be used in domain creation and domain doing
>      vCPU context switch.
>      1. Domain creation need this flag to decide enable PMSA or VMSA in EL1.
>      2. vCPU context switch need this flag to decide save/restore MMU or MPU
>         related registers.
>
> 2. **Add MPU registers to vCPU save EL1 MPU context**
>     Current Xen only support MMU based guest, so it hasn't considered to
>     save/restore MPU context. In this case, we need to add MPU registers
>     to `arch_vcpu`:
>      ```
>      struct arch_vcpu
>      {
>      #ifdef CONFIG_ARM_MPU
>          /* Virtualization Translation Control Register */
>          register_t vtcr_el2;
>
>          /* EL1 MPU regions' registers */
>          pr_t mpu_regions[CONFIG_ARM_MPU_EL1_PROTECTION_REGIONS];
>      #endif
>      }
>      ```
>      Armv8-R64 can support max to 256 MPU regions. But that's just theoretical.
>      So we don't want to define `pr_t mpu_regions[256]`, this is a memory waste
>      in most of time. So we decided to let the user specify through a Kconfig
>      option. `CONFIG_ARM_MPU_EL1_PROTECTION_REGIONS` default value can be `32`,
>      it's a typical implementation on Armv8-R64. Users will recompile Xen when
>      their platform changes. So when the MPU changes, respecifying the MPU
>      protection regions number will not cause additional problems.
>
> 3. **MPU based P2M table management**
>     Armv8-R64 EL2 doesn't have EL1 stage 2 address translation. But through
>     PMSA, it still has the ability to control the permissions and attributes
>     of EL1 stage 2. In this case, we still hope to keep the interface
>     consistent with MMU based P2M as far as possible.
>
>     p2m->root will point to an allocated memory. In Armv8-A64, this memory
>     is used to save the EL1 stage 2 translation table. But in Armv8-R64,
>     this memory will be used to store EL2 MPU protection regions that are
>     used by guest. During domain creation, Xen will prepare the data in
>     this memory to make guest can access proper RAM and devices. When the
>     guest's vCPU will be scheduled in, this data will be written to MPU
>     protection region registers.
>
> ### **2.6. Changes of exception trap**
> As Armv8-R64 has compatible exception mode with Armv8-A64, so we can reuse most
> of Armv8-A64's exception trap & handler code. But except the trap based on EL1
> stage 2 translation abort.
>
> In Armv8-A64, we use `FSC_FLT_TRANS`
> ```
>      case FSC_FLT_TRANS:
>          ...
>          if ( is_data )
>          {
>              enum io_state state = try_handle_mmio(regs, hsr, gpa);
>              ...
>          }
> ```
> But for Armv8-R64, we have to use `FSC_FLT_PERM`
> ```
>      case FSC_FLT_PERM:
>          ...
>          if ( is_data )
>          {
>              enum io_state state = try_handle_mmio(regs, hsr, gpa);
>              ...
>          }
> ```
>
> ### **2.5. Changes of device driver**
> 1. Because Armv8-R64 only has single secure state, this will affect some
> devices that have two secure state, like GIC. But fortunately, most
> vendors will not link a two secure state GIC to Armv8-R64 processors.
> Current GIC driver can work well with single secure state GIC for Armv8-R64.
> 2. Xen should use secure hypervisor timer in Secure EL2. We will introduce
> a CONFIG_ARM_SECURE_STATE to make Xen to use secure registers for timer.
>
> ### **2.7. Changes of virtual device**
> Currently, we only support pass-through devices in guest. Because event
> channel, xen-bus, xen-storage and other advanced Xen features haven't been
> enabled in Armv8-R64.
>
> --
> Cheers,
> Wei Chen
>
>


From xen-devel-bounces@lists.xenproject.org Thu Feb 24 12:14:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 12:14:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278200.475359 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nND0Z-0003N3-Tj; Thu, 24 Feb 2022 12:14:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278200.475359; Thu, 24 Feb 2022 12:14:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nND0Z-0003Mw-Qp; Thu, 24 Feb 2022 12:14:07 +0000
Received: by outflank-mailman (input) for mailman id 278200;
 Thu, 24 Feb 2022 12:14:07 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=VLhp=TH=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nND0Z-0003Mq-E0
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 12:14:07 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 42f07dde-956b-11ec-8539-5f4723681683;
 Thu, 24 Feb 2022 13:14:06 +0100 (CET)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2058.outbound.protection.outlook.com [104.47.13.58]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-41-3mQ9okiAO5y3IQ7vVgFEGQ-1; Thu, 24 Feb 2022 13:14:04 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM6PR04MB5368.eurprd04.prod.outlook.com (2603:10a6:20b:9c::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.24; Thu, 24 Feb
 2022 12:14:02 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.024; Thu, 24 Feb 2022
 12:14:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 42f07dde-956b-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645704845;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=iFcbKiV7pDgtimIQ5qREMlAmdkexDbuSeafI/p4F8GQ=;
	b=L2HHDF+GIGnEXaeo2Y+dvCUI4WEOd1nyaqtbTJH2HszIq7uzgCPm+N6vN8HidraAt1EYq1
	v52uLdnGmShMyOGTs+FuBAo9XjgzyINqycJpgGJY4tC9zrfiDVWxESQNQZlW8OqHOD67A/
	4H35k6yeBWzt3Fk98KJz/t+P6MGwe0A=
X-MC-Unique: 3mQ9okiAO5y3IQ7vVgFEGQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jZ3JLovKXemRbOocRmVLgAV28HXH1mb0jgciHb/pxJYtUIl7mriXxwr2qJhJoWVaoDcdcjjsn8ja+NLJwZhO/k2CIB026cKIRmd8rH+96w5J1KMhAZ/r8wrh0NxTpwRv5PSPJEUrzuoqFGCJnR9xOV6ZNDHtahBimTdAVW5jQKrQV9mParGpNWC2GtBXd+1YyYHIoDd9ZY/tfT+o9Ya44ojqr+Wp9fjx2qHriaCImz+V2BffDAktN+QQQPhYf5naYNTwPGIXNs+VcYrmhdXiuRXTGtyVZBZUVE78+OT1TCqcxQYLTz+BJ9ybvq5kWC1vphQYZ2xbh0x+p3bzjTTHHA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=EDRMnn1WlVPsQo4HiQVGtzR/ZsNf/YV2+9KXlUXXe/A=;
 b=aqlogofA7RPnGcSZupZPakcLovhXFU5v3vKgCLBOXKLq7RXoeyEtEu7KVr32qEnAEIx+PevklG/Gq3XDtK8p3AVynjsQwJzovkCsZ91moRidlGP5u+ILuYDM4nAsxL2KgfSbuHf9IB1O+8fkAK4JZ3ruejzcSKO3uTg9rObGLg4AIeZEzeKGYKg+T6+dbi347+qs58Ub4gsv62XE2aeCX8s9yPp7dS4JWaMnkfCcGInxB4puxbjt9Az4ywZw/jSzPmVZm5i7c+TiTmyLrH0BdL3C7F96/9tQm5nRtHQQOvoHGy9mFJZSav6MlNIzH6r0ztIW8XpQlYQVdNO9k2Y4QA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <2c977e0c-9a9c-74a6-df20-a804ff3a9b6f@suse.com>
Date: Thu, 24 Feb 2022 13:13:58 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH 3/3] x86: correct fencing around CLFLUSH
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
CC: Wei Liu <wl@xen.org>, Roger Pau Monne <roger.pau@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <91935ffd-a270-f1a1-28f1-645fa4167fcd@suse.com>
 <7026f7df-1f70-0018-a6eb-b7e043b279d8@suse.com>
 <e81ea521-b0fb-e1b8-5db8-025d35077cc3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <e81ea521-b0fb-e1b8-5db8-025d35077cc3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6P194CA0046.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:209:84::23) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5286f17a-1e92-4ffe-9c46-08d9f78f24c5
X-MS-TrafficTypeDiagnostic: AM6PR04MB5368:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB53682229FC9F78F56CBF49FAB33D9@AM6PR04MB5368.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ZifrYQTxYw92XJHI4syMJGJSzjPitg4lfGwqCjFWN88Avxny0aOXPQTMc1bx/N/xe8Erp3kTbQMFkqzO2oXcSNDDbnIODgnbi0f11mjnxqEBRnHLVbCBZa8J95147BD512ehBmg8UsMea7fh9O8ZsOkD16PH84IuKgBm96vtdNlDsFqPTl5mLhJ1uzZMEXmWZ9HBqxX3ra3tLTMkSy0FXgyhRbEdWsSYdNNMWZGEq8IKUnEyTv7vHlOeOj3Dx1+YD6/BD1Z3QZqL/9Ew428QsHbsOM5IXPgTfe7yr1qiVchv69/Bef2E4LevMbRanKotM2WithqaKnMYQujiUXQf5aZB/JZ9/gzPaXqpcYAh/bqfeX5vQamg8uq+5azN2ZBYIlD6P+QhXLVfjggNeHkmBcoBx0ltT1SR1TuIgaSYEM4RM/1VwLlVz++p5cKvWu0hdp3lOfop1kmtjD6AEl10Xlwp8w+2Np2vIB9Y3C1ZVPDKGBfKId2agXTkCmjCYEwkJyKriWMymhsJJqTA7SQx6u4D3aY07vmpNZLc5WL99F1EaRUFS99bMb6KFq2OrBU81eg0F0AH/kUeCG4ggOL9bLFlaC7c5m5J1X3T/9N3OQ6+2gjP6K9v+NiJKBIGF9lrCrw7f4YFdfKNpCay7EvuViuY7+Yq0rtC/SAlhKtfwms6XQuDOCQ9OEjTet05bOHHhmbzsxb4ehEOXMabK08M0Tx5zRGXwFFRueAqjT4+BR8=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(31686004)(26005)(316002)(6916009)(6666004)(5660300002)(83380400001)(66946007)(36756003)(86362001)(8676002)(4326008)(6506007)(53546011)(508600001)(6486002)(8936002)(66556008)(66476007)(2906002)(38100700002)(54906003)(186003)(6512007)(31696002)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?qMORDpr9Wna3JwZZZQlRmStI54pWbIxLYgQZgnrtluCUDLuyj6FOA4k7nJNO?=
 =?us-ascii?Q?IO+0lS9P3wjZHPCmNp33GV929KNVyAPVIw8IPcSYFErZnQbb2sJa/yb0/T7E?=
 =?us-ascii?Q?4IaSwF52VFimaB4hZk83ivDSH21OoJbWfkuWv2AKy4tK1PL2fDPjSxn5160m?=
 =?us-ascii?Q?zPTLT8lQK03D4g/5R0JwVOjKopNrHKQFkuskVtzN6pD/0PYW+baXX0wa0San?=
 =?us-ascii?Q?YK89JVXiuFNgSYdVV/YcY64tfxUma4rP0/t1LTUTr0qiKKhkONO9GNFnXjBU?=
 =?us-ascii?Q?644mLC/4w0mMIe1QJHFegaFcQsWN00QpDyp6IKQhGkQ8nYfqU7N21lZCUXKf?=
 =?us-ascii?Q?5lHKxw0xp9RLiqCihLv0k/uzocU2ZcTAxfKVVa9kDcEZnSQYO+6Vx0U0lBkQ?=
 =?us-ascii?Q?6OrO/Rf5znBJeYQZghLobzK29pccnAxGtVav6mLLixVsfLz6XRRezbdNmoLe?=
 =?us-ascii?Q?PFhbgF7AJqG1DUS3UnoeEc7QdU+m6cyrdcuYOaN75HP3BvE71sF5oV9AKmcm?=
 =?us-ascii?Q?B7pAkMtFE/I8P3ZLCOaOUZY5ciITx0hbl939OYsGOn7nvqQRBo3LN0MIhqg4?=
 =?us-ascii?Q?Es2wtGsWiOX/Y4KAjpQnV75KCTToZ3Bb/EYfJmqnQPsOOmHJygUizac2+ael?=
 =?us-ascii?Q?QM25lPzr37J6v25wXJ6F0a7Kg4BkVyDkMazuxpo8Bf5v3/69RBIpUQsoRIEz?=
 =?us-ascii?Q?K1NOxr/++oisOG2DWipAjQlA8Hf0rP3jnRL8P1A467aqW4eppT268Sv8GJUR?=
 =?us-ascii?Q?VC/vGRK2xmITszCMvn+Jbf9VCN2pY3D7xsMfOh04FZLkjAcjHVvkH9zdFfi/?=
 =?us-ascii?Q?hOFWuenejfQGeiDqFeRtyFX0cNFHNgQVtU3HcDo36aa0DZPhofMg8pY9Ys9h?=
 =?us-ascii?Q?W/EW5OLp/FAi608331pbNuaj7qm/ttNfIxroJiO0oy5H4lIgLMYcmVCv8n+j?=
 =?us-ascii?Q?dFI51CjxD+AJgZkzn5Sc+LTNzOWGXDzPm4yEa+tAedptqro7gg1cabSGXDL9?=
 =?us-ascii?Q?WuINRT8sfpEjvP1uDO58WT7w7VYLtF2n1JkQIpIkHrIEU2lNZ6MX4iq9EChF?=
 =?us-ascii?Q?5ETnmEmV+0BIbdD7DDg1MWx3Fd3Z6JGfvrb57XNnTvVT2y0uSYHohZliUYZG?=
 =?us-ascii?Q?Hk+XenPy3Srq/4xZdaiG/7bI92jiLFg5zXHDXqfssFOlDqPYTApnTMpxHfu7?=
 =?us-ascii?Q?0dgJBOBJjtylGs9MmaSyLCJaN0HdSdhae88eC4vA7fLodQEQv1LViYfB4Bf9?=
 =?us-ascii?Q?Asv+AY7M50jdW0TCyUdOXxanZmZYItFN/vBHTehV+EcKJbjKpomkDUTfl1X4?=
 =?us-ascii?Q?63v5XPsYZXpdlqucR2T0OexS8zc8mKV96wNQWAUHQ4HaMDZdt+KTmtxKfM4n?=
 =?us-ascii?Q?GAq5V7DnYLsrzwosC4jZ+juWs+EoE2J31nZmEWXLTYGzVRpt+UI2Ne8ryUYT?=
 =?us-ascii?Q?erFP7VmjXW79Fp0EQUWoG/AydhNUt3ZMNSrsJVEpJGrUxuzxtQiK3AKdAOSq?=
 =?us-ascii?Q?phdXfTBntyBLiApFQHZd4z3m9Gv6+JH45CFLryXWI90iqBCsS0fIxQ/AHsfz?=
 =?us-ascii?Q?wR9IV+RInWFrKqC02cDb6eWgxkUMmYF7xC63e3fdyu0mhhOXQd2uw7/AIedI?=
 =?us-ascii?Q?gC3dSoDRbbPywzMv9+xvOgY=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5286f17a-1e92-4ffe-9c46-08d9f78f24c5
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2022 12:14:02.1450
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PMggpYv9Q5djykgrCA16qzKsoXJwq++8J8ZcS0lkTTtChmybs3gdbTOO8mEZ7OPp52CdTrbzdZ9Bf2yHvGvRxg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5368

On 23.02.2022 13:33, Andrew Cooper wrote:
> On 23/02/2022 10:13, Jan Beulich wrote:
>> --- a/xen/arch/x86/cpu/common.c
>> +++ b/xen/arch/x86/cpu/common.c
>> @@ -346,9 +346,14 @@ void __init early_cpu_init(void)
>>  	       c->x86_model, c->x86_model, c->x86_mask, eax);
>> =20
>>  	if (c->cpuid_level >=3D 7)
>> -		cpuid_count(7, 0, &eax, &ebx,
>> +		cpuid_count(7, 0, &eax,
>> +                            &c->x86_capability[FEATURESET_7b0],
>>                              &c->x86_capability[FEATURESET_7c0], &edx);
>> =20
>> +	if (!(c->x86_vendor & (X86_VENDOR_AMD | X86_VENDOR_HYGON)) ||
>> +	    cpu_has(c, X86_FEATURE_CLFLUSHOPT))
>> +		setup_force_cpu_cap(X86_FEATURE_CLFLUSH_NO_MFENCE);
>=20
> This is somewhat ugly, not only because it presumes that the early AMD
> implementation peculiarities are common.
>=20
> It also has a corner case that goes wrong when the BSP enumerates
> CLFLUSHOPT but later CPUs don't.=C2=A0 In this case the workaround will b=
e
> disengaged even when it's not safe to.

You realize though that this cannot be taken care of when alternatives
patching is involved? Are you suggesting to not use patching just to
deal with an asymmetry we don't really deal with anywhere else?

> Most importantly however, it makes the one current slow usecase (VT-d on
> early Intel with only CLFLUSH) even slower.
>=20
>=20
> I suggest inverting this workaround (and IMO, using the bug
> infrastructure, because that's exactly what it is) and leaving a big
> warning by the function saying "don't use on AMD before alternatives
> have run" or something.=C2=A0 It's quite possibly a problem we'll never n=
eed
> to solve in practice, although my plans for overhauling CPUID scanning
> will probably fix it because we can move the first alternatives pass far
> earlier as a consequence.

I've switched to marking this BUG, but I'm not sure about such a
comment: It really depends on the use whether it would be safe
without the MFENCEs. (We also aren't aware of problems, despite them
having been missing forever.) Furthermore it's not overly likely for
anyone to look here when adding a new use of FLUSH_CACHE. I'd
therefore rather consider it best effort behavior until patching has
taken place.

>> --- a/xen/arch/x86/flushtlb.c
>> +++ b/xen/arch/x86/flushtlb.c
>> @@ -245,12 +245,15 @@ unsigned int flush_area_local(const void
>>               c->x86_clflush_size && c->x86_cache_size && sz &&
>>               ((sz >> 10) < c->x86_cache_size) )
>>          {
>> -            alternative("", "sfence", X86_FEATURE_CLFLUSHOPT);
>> +            alternative("mfence", , X86_FEATURE_CLFLUSH_NO_MFENCE);
>=20
> An an aside, the absence of "" is very weird parse, and only compiles
> because this is a macro rather than a function.
>=20
> I'd request that it stays, simply to make the code read more like regular=
 C.

To be honest I was half expecting this feedback. For now I've put
back the quotes, but I have a change halfway ready which will
eliminate the need for quotes in the same cases where the
assembler macros don't require their use (as you may guess: by
using the assembler macros instead of maintaining redundant C
infrastructure). I guess at that point it would become a little
inconsistent if quotes were present just to express "empty". Also
if I'm not mistaken this isn't the only place where we make use of
macro arguments being allowed to be empty.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Feb 24 12:44:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 12:44:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278208.475371 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNDU3-0006gF-CC; Thu, 24 Feb 2022 12:44:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278208.475371; Thu, 24 Feb 2022 12:44:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNDU3-0006g8-8S; Thu, 24 Feb 2022 12:44:35 +0000
Received: by outflank-mailman (input) for mailman id 278208;
 Thu, 24 Feb 2022 12:44:33 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=gX/V=TH=citrix.com=prvs=047ddeb39=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nNDU1-0006g2-G3
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 12:44:33 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 812f46a0-956f-11ec-8539-5f4723681683;
 Thu, 24 Feb 2022 13:44:30 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 812f46a0-956f-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645706670;
  h=from:to:cc:subject:date:message-id:
   content-transfer-encoding:mime-version;
  bh=lGxRk9A5yMbQlhmYLkG9mwdJ6empyG6N7zD9TZXNuJQ=;
  b=VfA3E0vX/39c7U920MXNEtgPzPN8UfQD9vjQi8sxav1iCuKQmIS6/X2Z
   CY7x3o1nBl+NTLmwjwxbm1zcHOPgX+XvbeYtz67cxpqaDgGLrDBfNa3qh
   sHsJzTOCPGicIIlL6nTZJbMTis2QaEOk4TtdeP2q3eP2t6HtoBY3lH/2Y
   o=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 64897704
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:ysAyCKP3uvljGDTvrR1Sl8FynXyQoLVcMsEvi/4bfWQNrUp30GRWy
 mIXWG/Xa6mJN2fzf4t3YNuyoB9V7ZTVm4RrSwto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FV8MpBsJ00o5wbZj2NIw27BVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zw
 tRXpL+iVyIQM5bHt+8GegkCKAxUFPgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALNs7kMZlZonh95TrYEewnUdbIRKCiCdpwgmtg158RRaq2i
 8wxdWVwbDbKTTx2B3hGMNFlo7+Fr2HjfGgNwL6SjfVuuDWCpOBr65DyNPLFd9rMQt9a9m6Dv
 X7P9Wn9BhAcNfScxCCD/3bqgfXA9QvyXo4ITuXgrtZlhVSSwioYDxh+fVi2v/i/zFK/UtR3K
 koI9y5opq83nGSpRNTgWxyzoFafowURHdFXFoUS+AyLj6bZ/QudLmwFVSJaLswrstcsQj4n3
 UPPmMnmbRRtrbmURHS15rqS6zSoNkA9NWYfYQcUQA1D5MPsyLzflTqWEIwlSvTsyISoR3egm
 FhmsRTSmZ0ZjNQa9Lel2GnKuDmDrYPgXlQOyy/+CzfNAhxCWKapYImh6F7+5PlGLZqEQlTpg
 EXoi/Ry/8hVU8jTyXXlrPElWejwuq3baGG0bUtHQsF5nwlB7UJPamy5DNtWAE5yevgJdjbyC
 KM4kVMAvcQDVJdGgEIeXm5QNyjI5fW4fTgGfqqNBjarXnSXXFXZlM2JTRTNt10BaGB2zckC1
 W6zKK5A90oyB6V91yaRTOwAy7ItzS1W7TqNGc2lk077i+HBPCX9pVI53L2mNL5RAESs+li9z
 jqiH5HSl0U3vBPWOEE7DrL/3XhVdCNmVPgaWuRcd/KZIxoOJY3SI6S5/F/VQKQ8x/49vr6Rp
 hmVAxYEoHKi1SyvAVjbMRhLNeKwNauTWFpmZETAy37zgCN9CWtuhY9CH6YKkU4PrrI7lqcsF
 6FfEyhCa9wWIgn6F/0mRcCVhKRpdQixhBLIOCygYTMleIVnSRCP8djhFjYDPgFVZsZrnaPSe
 4Gd6z4=
IronPort-HdrOrdr: A9a23:xGFen6zJl412aCnvF66pKrPxweskLtp133Aq2lEZdPULSKOlfp
 GV8MjziyWYtN9wYhAdcdDpAtjlfZq6z+8O3WBxB8bYYOCCggWVxe5ZnO3fKlHbak/DH41mpN
 hdmspFeaTN5DFB5K6QimnIcOrIqOP3jJxA7t2uqEuFIzsaDp2JuGxCe3um+wBNNUB77d1TLu
 vu2uN34x6bPVgHZMWyAXcIG8DFut3wjZrjJToLHQQu5gWihS6hrOeSKWnS4j4uFxd0hZsy+2
 nMlAL0oo2lrvGA0xfZk0ve9Y5fltfNwsZKQOaMls8WADPxjRvAXvUoZ5Sy+BQO5M2/4lcjl9
 fB5z8mIsRI8nvUOlq4pBP8sjOQpAoG2jvH8xu1kHHjqcv2SHYREMxan79UdRPf9g4JoMx8+L
 gj5RPUi7NnSTf72Ajt7dnBUB9n0mCup2A5rOIVh3tDFaMDdb5qq5AF9k89KuZMIMvD0vFoLA
 BSNrCc2B4PGmnqL0wx/1MfiuBEZ05DUStvGSM5y4+oOzs/pgEN86JX/r1cop46zuNNd3B13Z
 W7Dk1WrsA/ciZvV9MEOA4ge7rBNoWfe2O7DIqtSW6XZp3vfUi97qLK3A==
X-IronPort-AV: E=Sophos;i="5.88,133,1635220800"; 
   d="scan'208";a="64897704"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=m5kJLBAeNRCNoQt2iRc81q/mvldhHe5oZ86M4shxZtJS11IY8FKAR6NB5YGZICiUtplSQ39ZJ6KHi5jvKfHWZ82dUkPKqhCIXMXDaEJCC0uBHsXWNEZweCnHW790PDyRCJvC6LkfaN1lTD6OT72HW7X2yJFLAmrcfTN4ofDiueUk/sN5zL7e3KSyc+71MToyoaKRt65qtCFFYGyZl6AFwqqSXBWLQMkV96XCMgvjPTKA/1+pE47joCzrO5BJQf0P98wdLxZzjJVPVvp8aj8DMpeCZ5ADCHWsnEibTifsdvWXMLSre3wE98IsWZ810+sRrY89hB9numM4et6Mv5B5Og==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=5jXTgjdRJs365AwCkKuWOBqmkndkRkK1qNIbfym/3+k=;
 b=afd/3Oul+Dr409B+R28TQihcTYE3Zfe7BT0wlMGXGx0kn4NAsc3+bpXZXD4yp1Aprm4GoZ/1GDXriAbIAHlwxyKNliNcaLSxy2MBD5Yf5BB4xzU+w1VuvPZkURnqcAQrH41oR9IWU0gRe6bxGNv79ebA6IPRXfY0Ik8KKfB5ek3csul3LdoRyr+1CHFVKvYz/Hng8TetqnW7z1IdhkzBMuC3FHO62UCkyMqhlgNz9rxqk4fwLxOaB9A7iC2Mqm/j7y7rjjHGo46m5GeSW1FttfXEubDwRGTg4zC9gDDKjgYjg3d4lnhvym+o9Hdb1KExeGX0G/E02GNPKJcLp8bMyA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=5jXTgjdRJs365AwCkKuWOBqmkndkRkK1qNIbfym/3+k=;
 b=acyWNWea9oeb8g1V0wFEYYUu7T4MJx6oWSIJyGJKGQU7/1MLpmhSWDtbBgdtgQWNB4yzssO0KtkSGfMejohDpXcPp5OLzTFmSWIqWgd9bXoh61lST7V5LA6k2HiIkArPowacxp0KpNKGG8teXATc8SBFXuju7b7aQksSR58APCc=
From: Roger Pau Monne <roger.pau@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Roger Pau Monne <roger.pau@citrix.com>, Jan Beulich <jbeulich@suse.com>,
	Paul Durrant <paul@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>, Kevin Tian
	<kevin.tian@intel.com>, Oleksandr Andrushchenko <andr2000@gmail.com>
Subject: [PATCH RFC] pci/ats: do not allow broken devices to be assigned
Date: Thu, 24 Feb 2022 13:43:44 +0100
Message-ID: <20220224124344.86192-1-roger.pau@citrix.com>
X-Mailer: git-send-email 2.34.1
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO2P265CA0356.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:d::32) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c9aedf9e-d055-43f6-b665-08d9f7935de3
X-MS-TrafficTypeDiagnostic: PH0PR03MB5926:EE_
X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
X-Microsoft-Antispam-PRVS: <PH0PR03MB5926CB3D1840E42A3A3B7B728F3D9@PH0PR03MB5926.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: AsmucvI0XyplzdGeYcZcLYKCbqNMfo2V4x9B/1hqOmo82dS70HH1deavqoJD8IYuE2PlI8l1fShN1JDpPKRJdroDYgie5uPo75ifhNvmbZ4ksLgFOWCR8PndKtvZa61NeZPW6d4sGWpFed2hAc6C2iPM09q/1J4utUCNY21L5rCLOyo0WbbuFH88w+HhDbv3cUT1gg6aqfBLRyYQZEZk+acEqHZWepZearqG9kL9ufuBqQwiJXjWXU/jwtGHzA19kvwpj6mLfx9ng1NQDoiLRkMNfs487Qz0ux3oXIleN2h1oQXARDjKfMn/PYP9kIxuCsskFJYdNJ4wrtRJ4wuBOMRcUjdaRCQEpNteeGEaJHl8eLhs6fbSJ5NwJvTZagvq19TvJE92d/GUPQ8b1uaqEzkMiAfxyGaY63WvKJbJ2FzKUhHjVXMNM09rhlyMui56LuCCwglFZP+dNCq4MS32Tx8O/gtldWfEwCAKl6kTY5c+oZFqcKCa8ZHWfWbb2Mbm8asC0A8da6R/nlkFA9EF/4xq1fjmtzT1LErsVeRcL9q+Gj8vvDTqZyUKWYfkHHyFkP+09OXSYaAFu91gUUga078savCgGYGZox7kO2YOTJM9+kbdrVwYpdTu9CoLLyuBUb1YdCRxKEQpycEofGAygg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(2906002)(66556008)(8676002)(4326008)(36756003)(66476007)(8936002)(38100700002)(5660300002)(86362001)(82960400001)(66946007)(6506007)(6512007)(54906003)(6666004)(2616005)(1076003)(83380400001)(316002)(6486002)(186003)(26005)(508600001)(6916009);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NSt5eHoyNVdZekE5WFM1TGFGNjRJREltQjZQdUQvNFhLbmdJUjZacDZrU2Vs?=
 =?utf-8?B?bENDak5XaFJVVTczZElzQnUzM0U0V2RvZWFuckdPVDUxYzcvaW5NQXAvdlhW?=
 =?utf-8?B?c1VsS2U0UVNYYW5qdForK08vZVlZZENRSDdjQjBkeEp1dVl2bDdSSFFCQW5D?=
 =?utf-8?B?NllSYkEzSzM2cEhzS0tNallWVmN5YnhQQmlHWURQNWlKTmFKTDJvd252VnYw?=
 =?utf-8?B?MEZKNjM1Ri9iWkFRcjlMTnBUOG5wN016M3o4Vkw1Ty91eVFCcUhrUzFqR2hl?=
 =?utf-8?B?UzU1alJhVlM5VmZBTXlJMGdkM01KdFI0OU9PbHI3L3JDRHZZNFVkSFU2WUVk?=
 =?utf-8?B?NXlpK0JsR0lmR0dJSisvdllITzdmc2VvbmVkOVkxb1pFbW8vTE5RQ1dZejhz?=
 =?utf-8?B?aGprdi95RHMyUFh3R1NhaG9wWjZEWjlYaThKYTEzRHBMdjBJUk1vNVFpbTF4?=
 =?utf-8?B?NXZiRmNnaXAzcDNYZnA5WDFGcVEwUTJ2ajNxMml3cDRWQzMwVnR6Wmgyb29w?=
 =?utf-8?B?QUZxT0U0Nkl6b0hYSDJpYUMyWGpWMEN3a08xSHVhUmtnSC9DNW43ang3RzRh?=
 =?utf-8?B?L29NTVJwNmprUm44QUhlc0w1RWNHNVR0dGt2SDBib2M5VnBaWktsOURpZDY0?=
 =?utf-8?B?Qk1DWGVjRGZ4WERuVisrc3UxNFQyNG1wdGljMC8xTHZQL3BkYmo5anhoT20x?=
 =?utf-8?B?ZFpGMkRBUW5iZmZ1UjRFUmFKcUFYM0Z2d3BZNHc0ZUxxdXV4eHNLN1RJMnBo?=
 =?utf-8?B?NGxwR2cwUi9pczBZS25aZm43L21XMm5pRjRPOVg3MmZsUENMdWFxVGJFZFdq?=
 =?utf-8?B?WDhNaFlZNHAxdG41MFBIeTdHY2t1TlRiM2laU0RCeW5KTDFxRkRXVFVlWVdp?=
 =?utf-8?B?aW1PRDFsWmdoRWx5K0NRZEUrd1M4Z0tjVFd0SC9WUUlXNGJrUHZZYmppaHlu?=
 =?utf-8?B?bEorYlFmenpvem5sUHdJMlBWY0JFVktrV1lNR2pXbHNCeDJQOFZQbnZMQ2FN?=
 =?utf-8?B?YzJtc2ZJQVM4T1gwTzk5bWU5MFNOcC91ZXFiZVpRTEN0WEhXMlBsYWFPVXpF?=
 =?utf-8?B?RDE5dEowSGJYTGdGN2MrdnppTkh6MExsRWtsVzRiazhNWThsOHFYdXNKWjVU?=
 =?utf-8?B?cGYrb3ZRSThvUE14YUZiREJiYXVaOWhrSHZxQW1WSFdtcG1vMTdXaUVobk5T?=
 =?utf-8?B?QUpFY2hnU24wc2t3WUZPZmVGOHExTHh5dHE3dUNndzBxNDNvWTZyeVRUUHlS?=
 =?utf-8?B?MXV0a1hTbk8zZ0ZXY2o5amRlVTU0cWNOL3I3dG0vV3QrVFRZZTJwTStqT240?=
 =?utf-8?B?dTRTbFNBWmpoVmxveDYxQ0xFVG1HZmN0NDRDaktIQW95VGdmVC9LcUE0ZERQ?=
 =?utf-8?B?YnllazNmMFYwY2RicWxoaVhYaDlRM1djRHJPOS9qRDBoaWh5Rkl3MjhTcnla?=
 =?utf-8?B?ZXpMbDFaVGsrdTg3czUxOEdiVE9uVDVxcnNtWGFSbkFRTWlZUHIxT0ZpZ0F6?=
 =?utf-8?B?ZjlRT25TUnE4VDQzZlhhRjdtRjhCSUR5bGkyYTRNRkYrSlRWVUlZK3R3a1k2?=
 =?utf-8?B?YWJxOUIwNUxLa3Izc3JnMzdDS0FZTFhncDlPeVduZFpqZWMrbFpZcTkvV0NX?=
 =?utf-8?B?Z0c1VGhjN0l0WnF5TUJXS1BiYW54UktrRkt4SHBtcWpkeUJ1UVMwNEd3b1gv?=
 =?utf-8?B?RzNxNWJZTzcxQWtDTithMTNvRjhnSnowdDI3RTFOQksxb0t1Z3VOdHVuYlhJ?=
 =?utf-8?B?OGJqeDRNL1ZGQnJBcEc4RmNvQjZMTFBOSCtnQUs4dTBFUHhQL05ZMCt5NTl5?=
 =?utf-8?B?anE0SjhPOXhKMUkxRm1GbzJoWkc2S0p2T1JtWmZRVWt0NjJHa0hpRTZKcklz?=
 =?utf-8?B?VzRPdjhzR1VQM040a2NLV3dFL3ZSTlFYM0JNSXRlSkdFRHhoZ3QzRzdBWWJz?=
 =?utf-8?B?VFFCZGVrZ09RWHZ5OWxKa3RJODFwWjVFVTVQa0syN3BDU2N0T0lybEZVTTBn?=
 =?utf-8?B?Y2psdEU2YytxbnBnaENyTHRBK0VZSFl2aFBuaDBhbEk0Sk5RUURHNmN3cW1x?=
 =?utf-8?B?U2VuQUNQRUdZdVRHYlB2RThhZlp0bjJLcW1iSjdKd0M3NXE2TTZSdzF6NGlK?=
 =?utf-8?B?eVgyc2JXcTVESmZKWVRLcG5GcGl2ZTBHQ21oSktxT3BVMDVvUlRRRElPRmNW?=
 =?utf-8?Q?KEssPVLiCXLgZr7eq0Am2Ek=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c9aedf9e-d055-43f6-b665-08d9f7935de3
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2022 12:44:15.8343
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 46YHoTGXBI2szIbBFAZqDncDzVpRGkcM610pRE3OaUifE1QwonacV/523B7Fi/Kp6p9OpTYvQiwf1MCwHjxrDQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB5926
X-OriginatorOrg: citrix.com

Introduce a new field to mark devices as broken: having it set
prevents the device from being assigned to domains. Use the field in
order to mark ATS devices that have failed a flush as broken, thus
preventing them to be assigned to any guest.

This allows the device IOMMU context entry to be cleaned up properly,
as calling _pci_hide_device will just change the ownership of the
device, but the IOMMU context entry of the device would be left as-is.
It would also leak a Domain ID, as removing the device from it's
previous owner will allow releasing the DID used by the device without
having cleaned up the context entry.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
RFC: I haven't tested the code path, as I have no ATS devices on the
box I'm currently testing on. In any case, ATS is not supported, and
removing the call to _pci_hide_device in iommu_dev_iotlb_flush_timeout
should allow to remove the dependency on recursive pcidevs lock.

TBD: it's unclear whether we still need the pcidevs_lock in
iommu_dev_iotlb_flush_timeout. The caller of
iommu_dev_iotlb_flush_timeout is already bogus as it iterates over a
list of pdevs without holding the pcidevs_lock.

TBD: getting rid of ATS altogether could also be an option, but it's
more work.
---
Cc: Oleksandr Andrushchenko <andr2000@gmail.com>
---
 xen/drivers/passthrough/pci.c        | 11 +++++++----
 xen/drivers/passthrough/vtd/qinval.c |  8 +++++++-
 xen/include/xen/pci.h                |  3 +++
 3 files changed, 17 insertions(+), 5 deletions(-)

diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
index 70b6684981..4b81c1c04a 100644
--- a/xen/drivers/passthrough/pci.c
+++ b/xen/drivers/passthrough/pci.c
@@ -501,7 +501,7 @@ static void free_pdev(struct pci_seg *pseg, struct pci_dev *pdev)
     xfree(pdev);
 }
 
-static void _pci_hide_device(struct pci_dev *pdev)
+static void __init _pci_hide_device(struct pci_dev *pdev)
 {
     if ( pdev->domain )
         return;
@@ -1487,6 +1487,11 @@ static int assign_device(struct domain *d, u16 seg, u8 bus, u8 devfn, u32 flag)
     ASSERT(pdev && (pdev->domain == hardware_domain ||
                     pdev->domain == dom_io));
 
+    /* Do not allow broken devices to be assigned. */
+    rc = -EBADF;
+    if ( pdev->broken )
+        goto done;
+
     rc = pdev_msix_assign(d, pdev);
     if ( rc )
         goto done;
@@ -1585,9 +1590,7 @@ void iommu_dev_iotlb_flush_timeout(struct domain *d, struct pci_dev *pdev)
         return;
     }
 
-    list_del(&pdev->domain_list);
-    pdev->domain = NULL;
-    _pci_hide_device(pdev);
+    pdev->broken = true;
 
     if ( !d->is_shutting_down && printk_ratelimit() )
         printk(XENLOG_ERR "dom%d: ATS device %pp flush failed\n",
diff --git a/xen/drivers/passthrough/vtd/qinval.c b/xen/drivers/passthrough/vtd/qinval.c
index 9f291f47e5..4436c22c05 100644
--- a/xen/drivers/passthrough/vtd/qinval.c
+++ b/xen/drivers/passthrough/vtd/qinval.c
@@ -227,7 +227,7 @@ static int __must_check dev_invalidate_sync(struct vtd_iommu *iommu,
 
     ASSERT(iommu->qinval_maddr);
     rc = queue_invalidate_wait(iommu, 0, 1, 1, 1);
-    if ( rc == -ETIMEDOUT )
+    if ( rc == -ETIMEDOUT && !pdev->broken )
     {
         struct domain *d = rcu_lock_domain_by_id(did_to_domain_id(iommu, did));
 
@@ -241,6 +241,12 @@ static int __must_check dev_invalidate_sync(struct vtd_iommu *iommu,
         iommu_dev_iotlb_flush_timeout(d, pdev);
         rcu_unlock_domain(d);
     }
+    else if ( rc == -ETIMEDOUT )
+        /*
+         * The device is already marked as broken, ignore the error in order to
+         * allow deassign to succeed.
+         */
+        rc = 0;
 
     return rc;
 }
diff --git a/xen/include/xen/pci.h b/xen/include/xen/pci.h
index b6d7e454f8..00b44e8487 100644
--- a/xen/include/xen/pci.h
+++ b/xen/include/xen/pci.h
@@ -108,6 +108,9 @@ struct pci_dev {
     /* Device with errata, ignore the BARs. */
     bool ignore_bars;
 
+    /* Device misbehaving, prevent assigning it. */
+    bool broken;
+
     enum pdev_type {
         DEV_TYPE_PCI_UNKNOWN,
         DEV_TYPE_PCIe_ENDPOINT,
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Thu Feb 24 12:58:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 12:58:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278215.475381 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNDhf-0008Dy-K3; Thu, 24 Feb 2022 12:58:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278215.475381; Thu, 24 Feb 2022 12:58:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNDhf-0008Dr-H8; Thu, 24 Feb 2022 12:58:39 +0000
Received: by outflank-mailman (input) for mailman id 278215;
 Thu, 24 Feb 2022 12:58:38 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=VLhp=TH=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nNDhe-0008Dl-GV
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 12:58:38 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7aee8a81-9571-11ec-8539-5f4723681683;
 Thu, 24 Feb 2022 13:58:37 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2051.outbound.protection.outlook.com [104.47.14.51]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-30-5U85C_0nPRef3YmUT8ezrg-1; Thu, 24 Feb 2022 13:58:35 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by PAXPR04MB8624.eurprd04.prod.outlook.com (2603:10a6:102:21b::5)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.24; Thu, 24 Feb
 2022 12:58:34 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.024; Thu, 24 Feb 2022
 12:58:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7aee8a81-9571-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645707516;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=6UZ94uHQ+9OLCPOGsPzHIN2ucdat6bBz3ZQM5mOmP40=;
	b=JO/sUiD6t2Eyf3ikSCbJwcclytPzUkhmTRfrBS1cRgSANUWJnmxgwlZ91Avgsr44jZ+3PW
	4L8frHRbIMPM/cULAS5wHG0reMlvGGIewKJznw2TJoDRkB2IoCqTI5aHHTBp+4C/rqz5Bt
	TqrfOc+ErEK8G39TLIkvoneq/CmSwOg=
X-MC-Unique: 5U85C_0nPRef3YmUT8ezrg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Le5O/5UmblZxSPYVtcrgtGk4kr0AITyou8ND4rLE0wIKMfqg4UKY+lq2hS5rk2bdCcdJkoy80wQLqdVRsJ9p356eEsO4rTC9173XtTGXfnldE2aPClHBKU/6iTsxQj5kIuQd0EAUMoayqR/7nN2VIKCiFRDslzJpld/uxXymuooO982DmX/CiBc7szT6a4SDbK3W3laSuN2yRG/G7vW9OdIo/iMVqbPa4iirWVg7FosxzIAZ+2PPgXPUZqSdwmR3w/RcX5+RmYycjn4+7qotZ+YDwiLbSWobgjKKKl4MsW2Si8vFS9/xPPVglVEe1Xy5gE+wm/eSvhXYNCqOA/mbsQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=WjpLk9EzMqLrv4I7VyEkS5pYbehDb2Yx0JN2Qh2mtOE=;
 b=aeyy1zzz9RXwMafXCzCEgCQjwQwSk944m/ELUnMRI6nTCfhGVWtWKwZck6YgE2fp0W9KPxwQRgZG95EkALk/6gt3hIhx1lZ87NhB57KpdXue59wsBBNDjS6HfqGB4WR0KPlBZm/Hij9vOCTtSLYXBASrVcLKQglEd9nGrtwnziAt554x8a9TaSqBVkzJHrriZ2m27AIy+yybS4lPoDZcAnaW6y4todWVZdbIwU9htl0LjzLQmFnSd4SwB4i73nTd8NS1XHRzSon/3E7q8hKUho3f7MxqqV1ezTDD52AMk3bRW72ssaBjumkom+BYs6COUDV5M6jtF6ZDCG+G3acFMg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <3eb5e059-b37c-27c9-5c1b-0ed92b9edfd0@suse.com>
Date: Thu, 24 Feb 2022 13:58:31 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH RFC] pci/ats: do not allow broken devices to be assigned
Content-Language: en-US
To: Roger Pau Monne <roger.pau@citrix.com>
CC: Paul Durrant <paul@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Kevin Tian <kevin.tian@intel.com>,
 Oleksandr Andrushchenko <andr2000@gmail.com>, xen-devel@lists.xenproject.org
References: <20220224124344.86192-1-roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220224124344.86192-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6P193CA0070.EURP193.PROD.OUTLOOK.COM
 (2603:10a6:209:8e::47) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: de577601-9ad5-4d9c-ceec-08d9f7955d39
X-MS-TrafficTypeDiagnostic: PAXPR04MB8624:EE_
X-Microsoft-Antispam-PRVS:
	<PAXPR04MB8624491052135792E384C4CEB33D9@PAXPR04MB8624.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	UuhOucOq3c4k8UbaQo2wH7BkaljmqSqMNX7lH61fzvWJJB0C9kD56GnIVLcps0kk1jXduOIo8COSjOC8xE3JJLEilP0ABV4F8Luqapuuri88Jj24fycfUMVWr0hF+21q1I3cL2CWapfld5Bql4h/GZxetHNyPufxobb9uTq5xaiKU0NIocmWWIGNZ0YTBB7nTPbPGwJxWv2xnV9lRfFZxBzfd4yq0adJSWXBquQHQi2LopHS6UNRNKU3M/SUPYhtEIeGwfDUJj3rP03N6FBqj/Cnx9eqjMQQGFoFOSR3Y0VeOZWW/pCnDEsLx2jEtudZBDLwwj0+Zhs846W2LU3X++TAdbNPPGwWH240WclS7LfxM8Gnw5mQk4FwLBW70Wb96WCw4RZbmLQmseWCLflam0R2B2VQov0Hhf0D0c+3Yc0OvJ5Khg+uJ2Kgnwz5S9O29ew5zZYvymP1lMOh2U6T9AWXdx0snIgqHKASZgExGEL4sSS/qC2ES7EWQWj47MLLo/PnJmkzJy1yfd3TSc5Lqdte6cs6lRikN+QoxD6L/yLodrYVWvJ9+9nD+KHDGwm8AqoaB7S7+hVQloOUbAyXPoEFlP2mj3PUMojBj3RQKv6UY/f4xzcKqoKJ8bLsTMPZz5MrZ40XTaiE9Q5FzV0/36rqdITWBkyfxFFNsbPD1wDJBevgYGbrkSG0H8IqBQ4sSOjgFQ6IoqoW+ia5Y1bCh7QeCXTo4bZYPl00N/KL6SlaAyYDcJ6wB2/JTbjp4JJ6
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66946007)(31686004)(6486002)(508600001)(36756003)(83380400001)(8676002)(4326008)(66556008)(66476007)(5660300002)(54906003)(6916009)(31696002)(316002)(86362001)(8936002)(186003)(26005)(2616005)(2906002)(7416002)(38100700002)(6512007)(6506007)(53546011)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?Sz7pbSVY048SNSMux+TCT+7IqlupeyZK07MYeYca+yyav41BqdeBwf4rVnIb?=
 =?us-ascii?Q?DsdPEalCuwn2xE0lCsTJqHUd8NHJGN5kjjGeJUW7U8fhSI6AVhW77PSlHmfW?=
 =?us-ascii?Q?dlI8Lfa0K/wFHJV1ux5YEJJ7IKkTwtQsIhY3NfMJMQndkSP7xgQChiJyKTx3?=
 =?us-ascii?Q?gMzl/1UB6UOyymHdDRVJAA3iLYa6r7ldnWL3PB8C7FTc6vEB9tL2lYU8RMiu?=
 =?us-ascii?Q?3TrZaDlJ/uDvlpzdCkBDQBC0DisgquJzM6oR2xtByXyEF1N6ENcB1626MWCO?=
 =?us-ascii?Q?F+5bKJdj2eJ7WQK1MSLCp9QlizLo61IcaCYY/MX0d+0VVFPyxAkEZRwhk8i2?=
 =?us-ascii?Q?79nr9m0WVyjr1JRCF3sgKuYUqkfnF3tezYqRYWAPHYQ2m43xGt21NKfpncZI?=
 =?us-ascii?Q?4WanakciST58J1szEVmh3+NuUox2yHoKS4hN0dv6C4MQbftjD4uPWbK7meJn?=
 =?us-ascii?Q?Td3eY+UCQZiRgzydgbFFFIXV2KXOUE450TXHETmdObXCjmBQzj9wUDVaTND1?=
 =?us-ascii?Q?34aeSwebBAB8EA2jotFL/2xYgHPF57Kchif6wHxGeVdnPE6fZnMrn2xC0dVO?=
 =?us-ascii?Q?0oSQjYXiS01SdBhNXmbN+EqnxUg8IPlADXQDpliMFt8yvmqi2sIzl16f5gN5?=
 =?us-ascii?Q?iYs+fM6ASBQYs9qHR4l24zhy317rn+sbEaAnPdX39ZIzRXmQODCtE7rCwg4O?=
 =?us-ascii?Q?WmC7kKjTkMK3dUeiFbmcPDRP9FfsU04fFj4VGQCoUNdBaFMvY+mS5OjzQOVN?=
 =?us-ascii?Q?RTONIaPrXAeFF+Gsq/Y8+K8yBP2Rx1gBbdP2NPnujX/CDNbSpIyg2f6qG7sJ?=
 =?us-ascii?Q?qtUXQSEomb+s4Ji6rbwuav81wGcQQXaXjd862XHnhy/ABr/NOJ43R6mR8L2r?=
 =?us-ascii?Q?Dm3LS5zcjrHdLbUDSWCFJDepqWUOe5DGRTefUaFR9ejSgYt2RKTWWfZJBkVk?=
 =?us-ascii?Q?MYzD41l7Ob+xnm8A+1a9ntA8hlSNHPtxJ7pfQgQpLpHa7+ezJDO3Ajvt3fXn?=
 =?us-ascii?Q?GJ1nHJKASOembvR4JUv7cq/QAnIGyzcE0rzEjeo5igP3e7Wb4zAasW7car+B?=
 =?us-ascii?Q?30GZO7o8BDmZ2IkaaSdSim05M+0vj18tfbkAjJB+pDzYLLb/Mifg7UMKwd6b?=
 =?us-ascii?Q?hodQLdNOM4HO8lKwof1m394BTi5Pg55/foforMbfsmHZxcUH32dNc3fszTsB?=
 =?us-ascii?Q?Kgz3EUCfjasvRQvH9j7Ips4FMp2bA96Inywfwt2VkEnh4uTK4+YQksUbvlBN?=
 =?us-ascii?Q?c5yDonhG8FiIZ+0uXlrxRflqqkK1h8ZpZJOo4DY6eUWCnF14eKeP8XdgiDOA?=
 =?us-ascii?Q?fOYS/RBxejwPn4De4TY6k9n4m6z1iBZIqUkHa9GbLlfsqYo+FqXQmSNfBK/L?=
 =?us-ascii?Q?XEMF6AI+jI2/BMTGnW2jgsYpGKklrnapaO/L50JUnPBiUkjf1vZ520xxFX+0?=
 =?us-ascii?Q?ytr+7cgXlPknttnQYDtZliLpo3Dhc5Wc8+vNqlv2WiR28ZxqXwRdNeP+M8aR?=
 =?us-ascii?Q?Iv+CshzA5fzc27eW3Pce/pL7fwkTmf+wao5hsPwgqtciE/DXXj3zUdxs8oyu?=
 =?us-ascii?Q?CqSryxJ6vMj5jJ9H7huRaPInL8cuVf7jW/l9OEYf5OU8SSkJrVOw62MI2Nxt?=
 =?us-ascii?Q?6HAELuNhf17Q1tCdk5vBRq8=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: de577601-9ad5-4d9c-ceec-08d9f7955d39
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2022 12:58:33.7455
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wCse2OVU6rkS0eGol+L/jgKd5fP96Apn+d+p59bZuz27r9uL6YY2VgoJWFoNSk2mZ07qE/c/sB1P6/IpFFnQQw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8624

On 24.02.2022 13:43, Roger Pau Monne wrote:
> Introduce a new field to mark devices as broken: having it set
> prevents the device from being assigned to domains. Use the field in
> order to mark ATS devices that have failed a flush as broken, thus
> preventing them to be assigned to any guest.
>=20
> This allows the device IOMMU context entry to be cleaned up properly,
> as calling _pci_hide_device will just change the ownership of the
> device, but the IOMMU context entry of the device would be left as-is.
> It would also leak a Domain ID, as removing the device from it's
> previous owner will allow releasing the DID used by the device without
> having cleaned up the context entry.
>=20
> Signed-off-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>
> ---
> RFC: I haven't tested the code path, as I have no ATS devices on the
> box I'm currently testing on. In any case, ATS is not supported, and
> removing the call to _pci_hide_device in iommu_dev_iotlb_flush_timeout
> should allow to remove the dependency on recursive pcidevs lock.

No objection in principle. Whether this is the only dependency on
recursive pcidevs lock isn't really know though, is it?

> TBD: it's unclear whether we still need the pcidevs_lock in
> iommu_dev_iotlb_flush_timeout. The caller of
> iommu_dev_iotlb_flush_timeout is already bogus as it iterates over a
> list of pdevs without holding the pcidevs_lock.

Analysis of whether / where recursive uses are needed should imo
include cases where the lock ought to be held, but currently isn't
(like apparently this case).

> @@ -1487,6 +1487,11 @@ static int assign_device(struct domain *d, u16 seg=
, u8 bus, u8 devfn, u32 flag)
>      ASSERT(pdev && (pdev->domain =3D=3D hardware_domain ||
>                      pdev->domain =3D=3D dom_io));
> =20
> +    /* Do not allow broken devices to be assigned. */
> +    rc =3D -EBADF;
> +    if ( pdev->broken )
> +        goto done;

I think this wants exceptions for Dom0 and DomIO. An admin may be
able to fix things in Dom0, e.g. by updating device firmware.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Feb 24 13:02:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 13:02:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278225.475392 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNDlK-0001IS-7O; Thu, 24 Feb 2022 13:02:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278225.475392; Thu, 24 Feb 2022 13:02:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNDlK-0001IL-4K; Thu, 24 Feb 2022 13:02:26 +0000
Received: by outflank-mailman (input) for mailman id 278225;
 Thu, 24 Feb 2022 13:02:24 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=VLhp=TH=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nNDlI-0001IF-Hf
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 13:02:24 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0200af39-9572-11ec-8539-5f4723681683;
 Thu, 24 Feb 2022 14:02:23 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2055.outbound.protection.outlook.com [104.47.14.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-23-deP1I083M8GJ6McpGPNGAg-1; Thu, 24 Feb 2022 14:02:22 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM4PR0401MB2225.eurprd04.prod.outlook.com (2603:10a6:200:4e::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.24; Thu, 24 Feb
 2022 13:02:21 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.024; Thu, 24 Feb 2022
 13:02:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0200af39-9572-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645707743;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=YEpt8K81dSGr7Jz7vUqsd2S4FoBoc3q7IOZcYJczdMs=;
	b=HJHjjUd2SdPLGcpN8d14GeSAg3AOYpSXTq9y59mR0IB7vqJQ8JxX91tFlPtVWquHpWSZn4
	M+3/EVIQFA3jYCeuJsWPg7vp8SuBMJgpRn1M/acBFsSeDcvhiku+DbwYAl3H7CVce3G56+
	PuP5TIqrOsimk/6VjmF1lM1SKvRGV5s=
X-MC-Unique: deP1I083M8GJ6McpGPNGAg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ehzs+ytTb5iCQacaI3+3H1AX1LV0WZ5E6Xjpu4P8eNAIInYbrOT6gHjzGLkdbA8nFmPSu53sEIdfWJXQ4T6ds+8E9eDyoU4pKo/hKlr67EvRiUYfLaoJDa+wBUpoNAvNduMryk0t5czcsdxr7XW2nxrtdQdjCUSyIexGegNGZt6podb1AbWgcC3qyZpnvrOsXLXkoiQptL8R4JNbOaFI2b3V3ir1ZnXf7vQRNFnF0e9tWW5ctEHQa7nMVbJrIId3VCNgwvh0rd6rN8/LYUDnC9qyu5jlRC3Pzb0HhyWSjJLLzyNCa5o9Bnz1te3Wxg8zasijZdGmxzqb1TeCBbfF4Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=YEpt8K81dSGr7Jz7vUqsd2S4FoBoc3q7IOZcYJczdMs=;
 b=e94J7XkEDBeng+rI1tL/cEYNfgrvgzbrqkgSlDJtyc48QAzQx/4WlgaVN/+F5mbdupgNb3shQ+zdhYnud9/fStmL1Az7O2tDv4JPEdXxl1wjYU+gWyXVWcRDsRsvio80AnYWIWm0HXIBbaGLKvTrdx18ykpuOOECCyh4vHyTpk7WMWfp5+ZC9Bfp2gHyAUY4K6b9/afHjwPUuJ4lOqEG+pIRkbVBO+hlDdwNYQWbiNKdv4v8hw3nK9HwhKncxERNyQKetKL2TR6oXtEKqwTlzMuuFI3to7DiMXe7acTSa6X90+S2Rxri64rwFl+BA+/Ly7/dFobBm3JlEXk7w0h8nQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <c9c27f92-9bbf-9d21-b3e1-f4985a29652e@suse.com>
Date: Thu, 24 Feb 2022 14:02:19 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: =?UTF-8?Q?Ping=c2=b2=3a_=5bPATCH_v2_1/3=5d_x86/PoD=3a_simplify_/_im?=
 =?UTF-8?Q?prove_p2m=5fpod=5fcache=5fadd=28=29?=
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, George Dunlap <george.dunlap@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <e9257e96-ede9-2809-9a77-fd4dc206badc@suse.com>
 <0c61e460-122c-6486-00b7-22a9a24ee1fc@suse.com>
 <d60d879b-faa8-415e-cffa-c7e05da2814a@suse.com>
In-Reply-To: <d60d879b-faa8-415e-cffa-c7e05da2814a@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR1001CA0072.EURPRD10.PROD.OUTLOOK.COM
 (2603:10a6:206:15::49) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7b0a494c-c7a8-498f-5061-08d9f795e49f
X-MS-TrafficTypeDiagnostic: AM4PR0401MB2225:EE_
X-Microsoft-Antispam-PRVS:
	<AM4PR0401MB222562CE54E541874902C82DB33D9@AM4PR0401MB2225.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	QpT7W/h5KLtE3HcfTbNhkiLXuzejGggL49Jf8bXVmIUAXbtbEsPprwedgmqkzbNktKcOUCLXGs/Dz7e9/VAWV8cQE1Ds/kzYnypYUO8a7eZOAY63qyA6jrIIMN0bu89gUJACtyLL6+OqCNjRKQubaIhkZTOby0tP2B9lXc84KBByMndBoTT8JnvB1wVpfe1yWHwYFmFdtmPTJPlHMewRqbNoYyQ/WiwH3IA4XO3Fj7Sk1xnObhq+cy39FpfLX9GyNnTjOVrvoWG7wLaQOyRoFu9WtnL7rEkVa/l9CvSt8/m8d2JtIn50NiDyvJe1OQdRCbcxPNpYB7nTQsYqlF/89CXiDjrW73OlVLNL+7rwHxcVsGxGhWG9HwwakMufnYmN/cpC8eVkeSr6dyoj5MiklEhabfUsDqJTbfeO1Yxj6lKZRY2qnPOxYgTv8biTxJv9MusFH3P/ZmzgCeVu7Y4rk2PytjiVL/kQsu1ZNztQXaprqDRPuvz3aFaGNxbtzsbYogR+rmcKKT1ut2ebrc7ti9Z0u3sOWde4uENYa5hAOoXZkm4E2djvhLZ5sDUKpl44Xr5w3HpUOPQT1GpdjDAqfDSPOuZoiwZG6preoJfVTlkXtLXSoddYesponaXwEIJkEhxjvN5sachesx36PRWjTevl7QW5gHeBHUwYKqmXd5VRn/AnZtz9g9FpKKjcQBV4bnnLPBX/1wJPi2AxWSdqU6yAPqcxFqV/G2We/kfGZ1qNVmzss8Ua06v2IVoSYTfK
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2616005)(186003)(6486002)(26005)(86362001)(66946007)(83380400001)(31686004)(6916009)(54906003)(2906002)(66476007)(66556008)(4326008)(53546011)(36756003)(31696002)(508600001)(8936002)(5660300002)(6506007)(6512007)(38100700002)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RFdSbmFTZWp2RmI5YlczOGxiSGlKbUFEcXhUZjV2VE5UZjI1Q0pIcWREWGZQ?=
 =?utf-8?B?L2RSdDVZaHg3Sm5lbVhjSldCTGI2bG9RS2J6bHFOQzl2MWhOdUNNQjBYdmtH?=
 =?utf-8?B?VVdnV2thNlFOYllVdkxZajA2RDBva2xSRitNeGFpT3Y4UjhieFE2RGtNQ2dh?=
 =?utf-8?B?KzhNbGVTTjI4cTVKbTFTL3lOUWZJcWZhZGNrUzUvNUR2RHNqUlNGVkRjLzFV?=
 =?utf-8?B?YndCWTlsZWJ2V05ESDM5RXNENk5JUE5EUVhocVgvNXZMUXJjcDNHcEJUakNp?=
 =?utf-8?B?cWlJaTljTVNGeW9Dcm5tSVR5TW9MUmtKV2I3Yldjdy9IaWY2bTcvU3JuQ3Mr?=
 =?utf-8?B?U1pHQkxBbHIrS21aY1dCQzErY2FaRCtxdWsrT2JBNDQ1ZCtqZXNsc1EyYWpr?=
 =?utf-8?B?L2s0c0VrWmJnRU4ySUZGWmJQbG9PaXZWNVhJVlRBYVZDdmdMTjcvSENuQU1Y?=
 =?utf-8?B?ekxIQjFNcFJoenZxOEhBY0RBdzBaQ1NRQlQyaSsvT0NtcnpXb2ZWNTRhM0lK?=
 =?utf-8?B?WkVOU3MzNkFBay9MVWUzd25FS0NWV0xxRndiaTlZOVVPNFhRUkdneHBtcHF6?=
 =?utf-8?B?UjZmVEFHemlnWFlRUWZVMGZtZTM5TmVkaVhhSGVNemdVckQxM2ZuRWtJRTk0?=
 =?utf-8?B?Uk10bHloZjE3SEVoQkphL0hpYzJtNnArZkZneHo5WFhiNTNWTjNmN2FmVUww?=
 =?utf-8?B?d3VOT0V4Rlphd21sS2gvRXQrKzZ1blkxT0oyWGFQaXpIeHZUVnRJZ1YyVWRI?=
 =?utf-8?B?QjEzTGk4QzN4WE1XTkhiWGZEUVNEV29CRWFNTk5lb3g2azd6eExPelZaVEl5?=
 =?utf-8?B?QWZ6am9tYzZHc0x3a3BvSXJyOWxjSk9TeTdmRi9Rc0JqUGJqMllzTEM1OEpU?=
 =?utf-8?B?TmdmaWZaL215Y1NEcVFVdVVpYUp3a1ZuNG1ReWE2d0pWaXZuc2lFT0FiNmpI?=
 =?utf-8?B?bnJFb0FEZ3Y4ODVmTHdzRHRwT1AzcVJrQU9RVW41czJLalRHVVlTdmF3ZWF0?=
 =?utf-8?B?SXVsejBHZnpzUFZuQ0s5MnhROE5SYTZjNjd5MU9BZmgzNHl3MGRKUkdkdmZL?=
 =?utf-8?B?dmliS0ZCUDJZc0Q0aW5aejJjc2hPL2QxSGZCNHpjcnQwdmprZnUwN3hxTHRn?=
 =?utf-8?B?THdRays4R08ydTFKZS80R3BTajVmTHVBTzB5S3M0dWtqOWx2VkFtNkdlRW1r?=
 =?utf-8?B?V0JsTFRLUXJiWHpVbWk0clI5SnFGa2ppTnAyd3llcGtpN2g1QUhYaTRkL1hG?=
 =?utf-8?B?VjVwOS8vRmZDN3BsdVFEL0hON25PRGZudnRZWTljVCtHSHFKa1VQVlA0Nlpp?=
 =?utf-8?B?QzBLV25iRWJHZStYL0UvM1dpdEVvcGVObm16N2VSeVJGbjJvTGRDWGlJK1M3?=
 =?utf-8?B?V0tDZWpIWTJ5MjdJTVArekp5ZjBMY05iSm84MnRLWjBOMytlNHJtVVAyT1l5?=
 =?utf-8?B?YWZpRHJsVloyZGl1NksrSGxOd0M3ZkVIOTFLQjZteDBVNGdGWWpwR2VQMXh1?=
 =?utf-8?B?dWFhSGRQQkZLTGRpempQa2F1MWZwMmc4T1lsREk3enpUS2VtbDVLQnRKQ2JO?=
 =?utf-8?B?S1NubS83NmJkYXNPcVdZRTRGK2t6K0RJRjBhamVtb0ZrRk1aL1ZZaWo5c0dn?=
 =?utf-8?B?b3FXZkZETXQyTGhxQWZYVEJyNVJHWHJWQVJlSGhaeUx2US9XV0tBUmJ0L0cy?=
 =?utf-8?B?dnNNKzlORk1FZTBBdUNxSEJuRS9LU0lnaFN4Y0M4b04zZjNjYnZiZzU0WUln?=
 =?utf-8?B?YTQwY2EvN1VuVFZzN0hMVE5aL3ZoSnFkSVlwbWk3Z2VFU2NCdllGUDE4NVo2?=
 =?utf-8?B?Q3BadVJ1akdsam9HM2hPS1ZDUzJyMjUvUlBDckljcjVXeXZQdmdFK20rOUEv?=
 =?utf-8?B?cXR3eGdtZi9XYXBGL0R2bTlOcUVjKzZjc0hVS2ZTS0dSeHNHZzcrUTFUQjQ4?=
 =?utf-8?B?T20vODJnL0Z1NHJ1bERJOWxtTGtxV1kxdVE0c09OdXZqRG4rQ1hmRHpZcXln?=
 =?utf-8?B?ZTF2ZVN5aDI1aXd3TzN0dDlMZGFxRVN0NGJsOGJ1eFlUTVY1UWkyaExDNFZq?=
 =?utf-8?B?YjFaNjNyRDRaU05XdFJDMGRjZVREMnI1akl5OTdBRE12ZldBKy9YOXZDaXYy?=
 =?utf-8?B?bE45dWlBQ1RzbVFDMmZkOGFQRDlZUUJwZVArYkloWGhma2lxMlJZTWwzL2d3?=
 =?utf-8?Q?lGDtsgVf2PDqAO7m9Xhmxxc=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7b0a494c-c7a8-498f-5061-08d9f795e49f
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2022 13:02:20.9188
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /knJe35nCtrDoEjR7jO6K657Es68HmcCWasS4mbb4xL63onWQHV7sLauYDurPbqOkXYcw8+v/iHFuc5kbM3ZzA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0401MB2225

On 27.01.2022 16:04, Jan Beulich wrote:
> On 04.01.2022 10:48, Jan Beulich wrote:
>> Avoid recurring MFN -> page or page -> MFN translations. Drop the pretty
>> pointless local variable "p". Make sure the MFN logged in a debugging
>> error message is actually the offending one. Return negative errno
>> values rather than -1 (presently no caller really cares, but imo this
>> should change). Adjust style.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> ---
>> v2: Return -errno. Drop exclamation mark from log message.
> 
> Ping?

Another 4 weeks have passed ...

Thanks for feedback either way, Jan

>> --- a/xen/arch/x86/mm/p2m-pod.c
>> +++ b/xen/arch/x86/mm/p2m-pod.c
>> @@ -58,34 +58,27 @@ p2m_pod_cache_add(struct p2m_domain *p2m
>>                    unsigned int order)
>>  {
>>      unsigned long i;
>> -    struct page_info *p;
>>      struct domain *d = p2m->domain;
>> +    mfn_t mfn = page_to_mfn(page);
>>  
>>  #ifndef NDEBUG
>> -    mfn_t mfn;
>> -
>> -    mfn = page_to_mfn(page);
>> -
>>      /* Check to make sure this is a contiguous region */
>>      if ( mfn_x(mfn) & ((1UL << order) - 1) )
>>      {
>>          printk("%s: mfn %lx not aligned order %u! (mask %lx)\n",
>>                 __func__, mfn_x(mfn), order, ((1UL << order) - 1));
>> -        return -1;
>> +        return -EINVAL;
>>      }
>>  
>> -    for ( i = 0; i < 1UL << order ; i++)
>> +    for ( i = 0; i < (1UL << order); i++)
>>      {
>> -        struct domain * od;
>> +        const struct domain *od = page_get_owner(page + i);
>>  
>> -        p = mfn_to_page(mfn_add(mfn, i));
>> -        od = page_get_owner(p);
>>          if ( od != d )
>>          {
>> -            printk("%s: mfn %lx expected owner d%d, got owner d%d!\n",
>> -                   __func__, mfn_x(mfn), d->domain_id,
>> -                   od ? od->domain_id : -1);
>> -            return -1;
>> +            printk("%s: mfn %lx owner: expected %pd, got %pd\n",
>> +                   __func__, mfn_x(mfn) + i, d, od);
>> +            return -EACCES;
>>          }
>>      }
>>  #endif
>> @@ -98,16 +91,12 @@ p2m_pod_cache_add(struct p2m_domain *p2m
>>       * promise to provide zero pages. So we scrub pages before using.
>>       */
>>      for ( i = 0; i < (1UL << order); i++ )
>> -        clear_domain_page(mfn_add(page_to_mfn(page), i));
>> +        clear_domain_page(mfn_add(mfn, i));
>>  
>>      /* First, take all pages off the domain list */
>>      lock_page_alloc(p2m);
>> -    for ( i = 0; i < 1UL << order ; i++ )
>> -    {
>> -        p = page + i;
>> -        page_list_del(p, &d->page_list);
>> -    }
>> -
>> +    for ( i = 0; i < (1UL << order); i++ )
>> +        page_list_del(page + i, &d->page_list);
>>      unlock_page_alloc(p2m);
>>  
>>      /* Then add to the appropriate populate-on-demand list. */
>>
>>
> 



From xen-devel-bounces@lists.xenproject.org Thu Feb 24 13:04:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 13:04:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278232.475404 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNDn2-0001sc-JF; Thu, 24 Feb 2022 13:04:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278232.475404; Thu, 24 Feb 2022 13:04:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNDn2-0001sV-GJ; Thu, 24 Feb 2022 13:04:12 +0000
Received: by outflank-mailman (input) for mailman id 278232;
 Thu, 24 Feb 2022 13:04:11 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=VLhp=TH=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nNDn1-0001sN-KS
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 13:04:11 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 41d304ca-9572-11ec-8539-5f4723681683;
 Thu, 24 Feb 2022 14:04:10 +0100 (CET)
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur02lp2059.outbound.protection.outlook.com [104.47.5.59]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-26-XSM-1TjPNPmOSlRJz3gR3Q-1; Thu, 24 Feb 2022 14:04:09 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by PA4PR04MB7662.eurprd04.prod.outlook.com (2603:10a6:102:f2::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.24; Thu, 24 Feb
 2022 13:04:07 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.024; Thu, 24 Feb 2022
 13:04:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 41d304ca-9572-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645707850;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=2WuumZucJz4sXSydEPYHjq1IVRJ/Q3Li9fOh+beuZHg=;
	b=Ezj1cahYm4PxcFcLfNtrfoqzBNLiHPn1ER1lFoN3wfHTnkK18Rdeh461tR2NSuECLwa9CS
	saWeep+ucLmjEghalCIYUxwj6vTY4Xbw14cD/ncP5/xNYqxTWerOfNMom4rEgCRYkxSQV7
	65KBdFRuwrkC4pN7OI0LnErkUk6YPNE=
X-MC-Unique: XSM-1TjPNPmOSlRJz3gR3Q-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=KVYYBms1Hg+0If4Sp+qhFJlma5lC8uhAytHqQKHbOib1OPmg1JBqQrVoR9+BfhczkJjIgXX00Yfk8R/gBgmXWrr8187RljMzATPg35PasyV5zIboI4WAOub91uFIQXGuIhOly9nMNgDqJ0xxgAlgVqvk8S+8ZAi/h8uthfkDlg6dm8+BJ4gibjm/oOOYS4b+PT2j59myWGacnlV03ThHwuML1Fenesb9jNYCTrsyv/8gES9WDtdMdfHxBffj3BwzdB7bcC5Wb8a9ohcXwXm+oSESdimC/McYP9XNnu5G3qnT/afaphHQhG87WhLo4uDBkpHFqdPVCuTyE0PMO26oLA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=2WuumZucJz4sXSydEPYHjq1IVRJ/Q3Li9fOh+beuZHg=;
 b=BpvU5Ljpc/dynrO6aXtZtPaAOQURbAdubGUvJ+o/ryUqt4UgNiBEWORk4UjVXYWQb6pEvdaPdzCejEvrtngUyk8PmA4CbcUtxdanr8s1S3YQ6ISVwqY2SWPRnV2GvmHH4/KjC1bYgBBM+lteNM8nt8d8q5ZGlReaQo/3YYqqY3iTA2gq40VG/RXrGswhXDJDxhjgUS0LMCLWnaH0s224B5KPPx6AMHHoFs0uBA0Y47W5YOoXx2VSXg+swTMzf6fHjlxTWSLEv7syhzHbWMCvVdVwaFUDR4wD89aCyf8wC+G+pTkVRY5DXaRochAUxE10EKPdPE3E+MlwO752s1FYlA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <9a335545-f8dd-b676-0b6d-4b29b786e466@suse.com>
Date: Thu, 24 Feb 2022 14:04:05 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: =?UTF-8?Q?Ping=c2=b2=3a_=5bPATCH_v2=5d_x86/PoD=3a_move_increment_of?=
 =?UTF-8?Q?_entry_count?=
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, George Dunlap <george.dunlap@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <ac46f25b-e669-f309-b36e-c4760e10479e@suse.com>
 <5b3f46f3-3c9f-57fb-00a5-94128f41e34a@suse.com>
 <b3a79f29-e3ec-6b3f-e569-5d2679a5edef@suse.com>
In-Reply-To: <b3a79f29-e3ec-6b3f-e569-5d2679a5edef@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5P194CA0020.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:203:8f::30) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 6b94022d-477c-472d-9adf-08d9f7962429
X-MS-TrafficTypeDiagnostic: PA4PR04MB7662:EE_
X-Microsoft-Antispam-PRVS:
	<PA4PR04MB7662AAAE3B0630A558FBEDA0B33D9@PA4PR04MB7662.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	6NdAtK5TLNIw38b0k199eiCxg0oS577AXUrQe+Ai8gocp3AIgVv5sqmj+v86P41rPnrTTbi9e01fWka5AT1oF0wSgt0n+Pb21VWj7KrvJRpYtLTIOe4d63nGWeNQMR1doNqf4xbcsFhoEB+Kxdr3RNvIXnE4uJf3McW5bBziAurl13SUW4aXCrJ3kTSmo/tIg4TOa0WaMOsv6+WLrzxbATPpPYPbUK0nQuNfR0tP8zQ0gw3ntFcJP2v6vIIf8RaNdElQtlsYJl1iQQQiOY3DLdISdegkIYRnsnwYXW7YMb6kWemG+vR3WjqWYOSCn1SGlnbhz3kPSkNMgJUcoUKSf94oJwJGgnRBjhuWDzFaG/4Z0VnivRqVr/sTygjxb7DjATmhqmrRlCKBJyB42GJgvdcsvrKATBW3fWADcwXLk2GobMwx9wwbe1PYQZ2kLXnb9VNYNhJFnrVaagxzV1kZzmDi6Ra+zPlsGt+0NSBh2yHEoFysY7xXw5qYnyahk8Jb6N8Z5Zp45tHfBJ4/TQpdfaqxlkVrrMh8QDnYZrEG3wnijGiJtyp0IxOMmb0twzqRizQsiNIi8tdiHV7gOz/gTwFJ5ywIgzctX8Z0pVgzzHM6oWh2ZWCAJaxO23FxVOjgHk40n7RaS4Qnc+v0r7mkS0WfQ468kxcsXGxFQiB7Kaq4iyg1rJDs4o5LcXpMINZMZy2RDJsJx0iX/CpA3oy7HwpgzSpbT81qoqmXfmFWX44J/tD4p9lYNEBx9gXEa02Z
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(38100700002)(66476007)(4326008)(5660300002)(66556008)(66946007)(6486002)(6506007)(26005)(186003)(316002)(86362001)(31696002)(6916009)(53546011)(8936002)(508600001)(36756003)(31686004)(2906002)(83380400001)(54906003)(2616005)(6512007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UWEwSDBuQVoyeUZ2dnhHK0RTNXZKbXRqY0xKY1p3Z2xHNG9mbkEyR3dBbXM1?=
 =?utf-8?B?T2g0RjkxbURGQUp5c3RkOGJFalhnaUpYZnVNYlVGYnh6ZkMrRzBNOThrcFp2?=
 =?utf-8?B?cmhXWTBVYWtVQndOZTBMNVBNaGRJU0tJVnQvY0g4ODBNRkpvMURYTTJYVDIy?=
 =?utf-8?B?V3VuWFh4N2M0VE1hU2Jua0VLVTRrZ29rWW9KOHRBOXFHYUNTdDJHYXA3bUxj?=
 =?utf-8?B?QkhZbFh1RGYrd054R0hyOG5sbS9pWFQ0VXlkUDEvcitlcm1yWGZxdm9GbGFs?=
 =?utf-8?B?dnNDUVRVbEExUUdRdkY1eDZOZjlqVk9jYWFxeklCby9zUWhieC9lT3RPcjRX?=
 =?utf-8?B?dkF0cDFib1lXSXJxSGV1VHZ3MTJBWEtsRmhYNUduNUlaNHIzYUcyRG4xMW5Z?=
 =?utf-8?B?QkNtVGNrazRTNUVJVjgzN3FPRE40Q1p5QmcwRDJ1MEFjUEVUQ3pYekFkcFRH?=
 =?utf-8?B?SDBGMzBLZnRLaEhRMEdmQ2xJanoyekIreTN6VGhUbEM5L2puZ0szUWgzUE1U?=
 =?utf-8?B?cExvT3pDNkRKZWJrTTJVNCttbjFtZEZFWnlvNndpZ2ZIRlpRWkFvMkpGbnYz?=
 =?utf-8?B?UHlUZ3ZLQWpNOVpmYnZaUG1lMXBkdXBuN3k5bHkvTDFGY2hvQkZ3SUdLbXlm?=
 =?utf-8?B?aTY2THFUOEY0ZjVCOGVtSGk1NlRkTHBzUlEvY3RBZ3FGZElZUUdYbjVnWjZN?=
 =?utf-8?B?cFFLY08wMHE4Sy90c29wRXJDOUtpODBlK1FrS0o3STBGMjNidGx2cEtzdVdX?=
 =?utf-8?B?VE9BcjRBZWFBSlREZlFDRkZZZjFoV0dLb2JVZ01xQzR1M1VpVlFmdk5TS3lL?=
 =?utf-8?B?a3FZMzk3WHZoVE1rUStNM0M3MXcyNVRMM1l3SUNJWjRpZnF1ZFdkanJMeVpi?=
 =?utf-8?B?dktwQlBUazJiZGFIc09hR2V5bDl6ZUlaRVdCKzVicmxqeVA1MnZ4RnFTcFV5?=
 =?utf-8?B?QVZCQTlyUFFqdTY3c1VjSWhFSDE5SzdBaEFOcWhVUlpZdGt5dGMvbDJWeHVU?=
 =?utf-8?B?cjliajFXcm5ZWHYzVzhNM0hXKzBNVmppM2Y2c29kdHVvZjcvMHFNSWhGVy9n?=
 =?utf-8?B?cjY5bm5IMnFYcTZ1YUVZSWI1ejAxQkJhTW9uZDlYRGpFQnd1YkxwMVpYczJ3?=
 =?utf-8?B?T3RaS3M4NUNLeWJNVFBCY0xWTk1lZHk3UkxySDM2UEljbkZPNGN5RUVuUEVq?=
 =?utf-8?B?TFdOSW1WVm0wUTBIclFuUkVQQ2JKL3FyQVFoTDZTV1lCWEcwOU5xVW40cTlw?=
 =?utf-8?B?ZmNzQU1YUkJ1by9OV25scXFxWWdKUnZqQk8vRktGWGVVbFl3dUtXWGN3WnZO?=
 =?utf-8?B?cHVlMVUybExyaGdYaXcrWkRQa3plR2VlU1RWUzZ3NVQrTjl5ZDI3VlN6cldD?=
 =?utf-8?B?YithSmd4RDhWeXdIWnIvUWZmTU1jWmJDei80RkNvZWo4ZGtIN24wRkJWTDBw?=
 =?utf-8?B?NVBwUHhhdHhGYTBuekRZT2JuQzIvQTRmTGdOWFFLUkIraTR2NmhBcEo4NmNH?=
 =?utf-8?B?c0JsTzVmaHo0azBsMS9nNzYvQTV2MG5UYURQTWVDR1o3V1VQMHh2eHJseXlG?=
 =?utf-8?B?QXd4SUJuMHdwdlNSb3FTOGZkRGZKTVdWdFA4SDdYMDFVaFVmUWdnUWZYcE9p?=
 =?utf-8?B?SXJqQ2JMRm5pS2pKRHFqck9IWEplSSs5ZUJUY2NWM3BtZ1UvWkpoU3Y2TUlz?=
 =?utf-8?B?NEt0Uy85ODcrUDJlTWtCRWlkdEhxc1FsY0VYelZxdDdETzI3c0V2OFpKVUUz?=
 =?utf-8?B?YUdrOEllTHNDN1lYcm92dFhKdnA1Y1h4cGlGRmZva1RiaE9BUlBkZkdhNFhU?=
 =?utf-8?B?ZStKNmZLNW1VMlNIRGhScUVsc0VDZDFRUEszQk9CM0V0SjRqWlhMOFg1eURL?=
 =?utf-8?B?YjR1SFQvWFMvV2pGcHJjeDlqSFRlY21rcVlkT1dWZlhZM0xkRVVEL1FnUjVU?=
 =?utf-8?B?bXczRzdROGRSdWtqTGRidU5mQ0pNVlplc1dJaCtQTXFrWmZOVlVYREYxek5G?=
 =?utf-8?B?TzAxcTVQZUIweGN0Y2ZiRUVIcmRudlZwUVFEMEtVWHFvWDVNeGJuN1lOMXdD?=
 =?utf-8?B?ZmdidXlnWnJieVVuMEplMUJPMnNmODgvSHphVnJYT1k2MXVMY0RKYVFGYjND?=
 =?utf-8?B?WTRSYlRmTlkvSHlRTzNNa1Y0RVM5OVdZd3VTUHM1MXZLQmRnM0VoMUdITlV1?=
 =?utf-8?Q?XNR1Lk3INwJ6TMR4SRBCnLk=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6b94022d-477c-472d-9adf-08d9f7962429
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2022 13:04:07.5059
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9+jmYhLCZlr2D/rn5mXHaUxXyIKytSu5THcNwCq69u2Bh2BsAA3Z5lbX5jDgY1yp073ZX9ru0650FqdI18s96g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7662

On 27.01.2022 16:04, Jan Beulich wrote:
> On 04.01.2022 11:57, Jan Beulich wrote:
>> When not holding the PoD lock across the entire region covering P2M
>> update and stats update, the entry count should indicate too large a
>> value in preference to a too small one, to avoid functions bailing early
>> when they find the count is zero. Hence increments should happen ahead
>> of P2M updates, while decrements should happen only after. Deal with the
>> one place where this hasn't been the case yet.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> ---
>> v2: Add comments.
> 
> Ping?

Similarly here: Another 4 weeks have passed ...

Thanks for feedback either way, Jan

>> ---
>> While it might be possible to hold the PoD lock over the entire
>> operation, I didn't want to chance introducing a lock order violation on
>> a perhaps rarely taken code path.
>>
>> --- a/xen/arch/x86/mm/p2m-pod.c
>> +++ b/xen/arch/x86/mm/p2m-pod.c
>> @@ -1342,19 +1342,22 @@ mark_populate_on_demand(struct domain *d
>>          }
>>      }
>>  
>> +    /*
>> +     * Without holding the PoD lock across the entire operation, bump the
>> +     * entry count up front assuming success of p2m_set_entry(), undoing the
>> +     * bump as necessary upon failure.  Bumping only upon success would risk
>> +     * code elsewhere observing entry count being zero despite there actually
>> +     * still being PoD entries.
>> +     */
>> +    pod_lock(p2m);
>> +    p2m->pod.entry_count += (1UL << order) - pod_count;
>> +    pod_unlock(p2m);
>> +
>>      /* Now, actually do the two-way mapping */
>>      rc = p2m_set_entry(p2m, gfn, INVALID_MFN, order,
>>                         p2m_populate_on_demand, p2m->default_access);
>>      if ( rc == 0 )
>> -    {
>> -        pod_lock(p2m);
>> -        p2m->pod.entry_count += 1UL << order;
>> -        p2m->pod.entry_count -= pod_count;
>> -        BUG_ON(p2m->pod.entry_count < 0);
>> -        pod_unlock(p2m);
>> -
>>          ioreq_request_mapcache_invalidate(d);
>> -    }
>>      else if ( order )
>>      {
>>          /*
>> @@ -1366,6 +1369,14 @@ mark_populate_on_demand(struct domain *d
>>                 d, gfn_l, order, rc);
>>          domain_crash(d);
>>      }
>> +    else if ( !pod_count )
>> +    {
>> +        /* Undo earlier increment; see comment above. */
>> +        pod_lock(p2m);
>> +        BUG_ON(!p2m->pod.entry_count);
>> +        --p2m->pod.entry_count;
>> +        pod_unlock(p2m);
>> +    }
>>  
>>  out:
>>      gfn_unlock(p2m, gfn, order);
>>
>>
> 



From xen-devel-bounces@lists.xenproject.org Thu Feb 24 13:08:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 13:08:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278241.475414 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNDrG-0002YD-4V; Thu, 24 Feb 2022 13:08:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278241.475414; Thu, 24 Feb 2022 13:08:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNDrG-0002Y6-1E; Thu, 24 Feb 2022 13:08:34 +0000
Received: by outflank-mailman (input) for mailman id 278241;
 Thu, 24 Feb 2022 13:08:32 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=VLhp=TH=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nNDrE-0002Y0-HP
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 13:08:32 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id dd6542b4-9572-11ec-8539-5f4723681683;
 Thu, 24 Feb 2022 14:08:31 +0100 (CET)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2054.outbound.protection.outlook.com [104.47.12.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-32-FqY1RuRGOM2NKg8FhVPpPg-1; Thu, 24 Feb 2022 14:08:30 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM6PR04MB6295.eurprd04.prod.outlook.com (2603:10a6:20b:72::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Thu, 24 Feb
 2022 13:08:28 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.024; Thu, 24 Feb 2022
 13:08:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dd6542b4-9572-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645708111;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=OD6me/iHS9h2m3dA0IrLXXQNaO671RgMeWQa7RgByt4=;
	b=j863uh4vyMIo6vvQusKlX2fOouMrjFDtjyVkT7tD+aVrXfFoLd9dFoU9tTNQWPO7/oUAay
	hhjdGNqiIIjyR67MPExpaSK0Zn48y2jgDNauW7rAi5mRspfKBsUw8za8jRjEJP/nr2zVrH
	Mdjf09yF9cbXgZ8OnG6KNX0CsCNLRWY=
X-MC-Unique: FqY1RuRGOM2NKg8FhVPpPg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=MxnyS9JjPd2mmRS9GtyMLTB8aA0p2J7Inew/qGUMZ9b+2pBnY1utNbp3wt+ydv0TkhzXPT3hd9XzEnxncm3YPdDGBOLdQR3xE/vIGlBBz4loqjaq+5TgcX722FK4B/vUtpHrKhEi00GovoVpf/rSRxrqwrAmO608xVYfo2i5zAYAEFpO0DDqduHxWMRTEJlRqlfYbzqPimU5y6/8qb7eKP5at6n6INpX0eky9gHVVvYA7RgXJozbnvU6AP7Md/YNJkV5Ph54gWlss/XcAOrQKo9BFniAFbR5tWGWPKOibJOKk6jAp0Pii8s3CtRvSgcASJNpQSCeJBwBaPwygVC0UQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=gesGas7EcP9vw5Ssd1oG9f3IkHkO20rbqqAzhzDJDaA=;
 b=jXoAnEI1qt+WiFH54OLOcyxcE4w7hXm78RV3nmtHffod8FFSh/mEs5H5xmbXY5UWw+lvjrM91ojswKep8aHNMkAs8Ff4HpX/sHYhKpW9iikd7Xc3RRlBi7AFux/dD6KuYexVYvOAJrZG+Hns8hQd9F5corZa1S3hPpkbFSd3Qa+TNeW+5S1fCZ7Ox7oaROvmpx9/WsWtjYONM980Mc4X9sdokuijNpxHpyb/8FSP57sDevi9jEkNnT9ZVSmxVc3aKsw9zkrq4+WgZuSZv8Yi+4vjxmItol/Q8ElimDVqwEfFz0P8NfsHIDE0tPo6X9k4g26uYyHXlVwtXswSsVIcVQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <6270f203-c839-e54a-3f94-7db88759ed0d@suse.com>
Date: Thu, 24 Feb 2022 14:08:25 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Ping: [PATCH v2] MAINTAINERS: update TXT section
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Wei Liu <wl@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 =?UTF-8?Q?Mateusz_M=c3=b3wka?= <mateusz.mowka@intel.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <4f26b785-ae03-34a7-7dfc-d36121a44ac2@suse.com>
In-Reply-To: <4f26b785-ae03-34a7-7dfc-d36121a44ac2@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM5PR0301CA0030.eurprd03.prod.outlook.com
 (2603:10a6:206:14::43) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f7a5c070-72af-4e37-4134-08d9f796bf59
X-MS-TrafficTypeDiagnostic: AM6PR04MB6295:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB62958975FF90C521700ADB2EB33D9@AM6PR04MB6295.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	V89MaHtaUOcXrxbYge8GbIuG8DLJ7Ox3plhgrWbtWApTUPyRGlNtiGQIWsJFmo7aoA4kexYuQoynzk6tyIA1UKxFmXq6ejwA4z8ze1VigJG1xRysrcCu9sZZ99ts0wEs+JVCKRnhCv9Z65IWqoy48DWZ8aZgVXxpGkgOyv0uSI1lVzQvI/2yDrq3CBJ9LxFNegkAE+aB132gB151d7+d56TwzfHVZ1z0Gr9zPFvQqbVUrttKv+waYQN4VMkhtqJVvH93APjUZ8Lfee4WOXMXEyaU12luuoT91CXv+qUJuqICXgIS5rbkpzZpiXXO5c54lo7giIzXKJ5RJ+uEn20sn6LWRHxjtvXJtJ5c5QankjLF4iUwja1pW1CN4Oe4Mu3Fax7nGG1aYpzrcgPypd2ipwVitrXf/wNXt1/gosQ/9GS6Y9YgTCz4v89epTfDBDcazvDsEkeSTFEhkoDObT/YIcOP4RYXv7hSrEokcA7K9yGG+5zPzpPHwRTvjU6euJv/YoHg8zrXJmwwX3/99k992PWhlQaux6hb+QPzCJrwn1lSNk6qXQXcH6Al5GD3JxzUhtCFpBEmXxgymTntCxMDlFPIjhGpTWtMhQNLfUTTXNUpzJcfWaf6q+6k1x1y9F5IzUoWVkr43jfjhiZ6b4oqEGcDFlnOSiDRkIPyb/mVU2dKS+KUlUg+xS9hCSlG6SgkdwnJomOwvpNMk5NvtipWzA63F6NMjmyf9gGvJMGcOTDY+N8UoaNOr8FP6m765KGv
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2906002)(26005)(186003)(2616005)(31686004)(4744005)(36756003)(6512007)(53546011)(6506007)(8676002)(4326008)(508600001)(38100700002)(316002)(8936002)(110136005)(6666004)(5660300002)(66946007)(86362001)(31696002)(66476007)(6486002)(66556008)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?zTPzv2cKwRCZaX2t1RoNhPUEZ/o9VSK+ENzthl1BjNXwcadRCoPhBPH5qTVi?=
 =?us-ascii?Q?o/fom8CN+WoTPcNfYXhGEr9ZBpuDlY0y5tCopuj7XB6uG0jJ+RbNeaZ/p2UX?=
 =?us-ascii?Q?ZfbSjXpVz5c/HDqpIEC86hBlxsCZX6jTHi7wZgtZmunSIzdPtJZMzlmlx33r?=
 =?us-ascii?Q?ZqJ7reHrULzcsJQQdsGjgQQENwMtOrpaLGuzRKJfC2baQn6XjGauty98q/gY?=
 =?us-ascii?Q?Vqzds0RRkm4I5JY5IUM2GGtSg1oee75M5tJqn3oHWkgPQAGxBGR3RiQnc8sG?=
 =?us-ascii?Q?hiDF5FMcrw4ixqdCn7NDK+BypecVWGEI0vFEB6hhVqq45hxmveS9ZtmYs+q2?=
 =?us-ascii?Q?zCFzNVAzxIbAFdzaPWns/ahBaXhsiGg3a86zhrowqkrTPlDmcjyuCzjlQ5+1?=
 =?us-ascii?Q?36syJWpWZzHshP58mi+9E2GPEGTmmVCqQCjX00oZqIKD3bQQ2ybL5Zc1U95n?=
 =?us-ascii?Q?frN+DgRC+X2UOgWQtb7qYU+cu+AMdS/xfHZzqFKrUlQO9aPVnQ4hEyhaOEvw?=
 =?us-ascii?Q?qSr6jmKrtMpTelncDSwKKFU9vukXVptr7wdkhBv4DPNZnsieiicoJuChiOY+?=
 =?us-ascii?Q?XLgsHTMGEAyYDRBs+i3t6EIdVdhK0a5Au0K4QV5VikRUb+mpfXOL18p4JEwd?=
 =?us-ascii?Q?p4fp2uQ8koqn/8V0NLA3BrhPn3QCGIJ40AsJCeSWG142DCMN4j8TCwQ9+Fd+?=
 =?us-ascii?Q?eb/Q5kSisQh+jXLNUFaVWSElfbpqMJIit3nFI7zaULGtA9qKVongNeCpBuwQ?=
 =?us-ascii?Q?1xtB5nPxAmq6uXU88auWFqyc13hFnDmY72ALrSPq9awtdzl8WCKGFn9Uvhu9?=
 =?us-ascii?Q?LHr4md2D3thG/yq/QAqdCvyVB4J3xJ5PhEy2VOSlV5V3/wdgGeaUrXon3mi9?=
 =?us-ascii?Q?5qVXtuzyqbEiLvBt51J++2ep7xAYRnZISbh2A3FNqOzkzBLs8M6P0zZujGLK?=
 =?us-ascii?Q?KYKc9wWPBsbronPYtqgEmTvWc4dmHOF2TG5OHLn4SWvrr1sFtJzXLhczOhWt?=
 =?us-ascii?Q?fS53SiWHbglYNg4bYBjVZTjJsGLfDYGeT+POYEqw0rEKRmOf7owQ16Yh/KRu?=
 =?us-ascii?Q?33RlXiEiExILZMC7r2JlL9TgIDFBsrh+Tf+nuL1y0tIMhYNxsZiYqkbtCUye?=
 =?us-ascii?Q?276jRwhUOWmiSU90Kznzi4+yHyAGOWw9H/I7KVo3mNFFoH+YeNyx3ufOmZ/6?=
 =?us-ascii?Q?B6aKfI4Rfw9cwUyLbP0p0ir+iYhkotXjUmYX9n8M6LRse2/BVALAURIkOCZp?=
 =?us-ascii?Q?Fnjxb7nKhaN0miVcTGI3K6XcVsC0W7h8douqtIKSzy/VORkLrOwVi6xtbu0B?=
 =?us-ascii?Q?mq7QirplhGKiArzkQgvblOK1OrrOLC6SVQITrKUxAYMeF83Fr1HHVajOmheE?=
 =?us-ascii?Q?VfhOTU9jf/Lw+m29aOUEGVsham+OWa8b4RsVvWJcywlT6sI6TWOnRy9Gq9rg?=
 =?us-ascii?Q?7fTIZhQZeE8TIkwZxI2UuOiSiGiZnXnbuPK/pXOjxtTz24/zdrUYhxXKj4x/?=
 =?us-ascii?Q?LWXQy7aJXlHOmZrBNDXTcHhM3oYij1x5Yt5x//uZYj4gF9q50jxvktwF09vr?=
 =?us-ascii?Q?9nQrVjxO+Dw9elTLnRH67TaIMFK6/N5qpVof8xPuP//fhuLAkGmiQ1/q6XEL?=
 =?us-ascii?Q?uy9j6W2l5puz6VkeTc3/tIU=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f7a5c070-72af-4e37-4134-08d9f796bf59
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2022 13:08:28.6306
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5IfmxPO072q3Z2crr8CnwOuN3s8T5kQkIpjT7BDFopsngL4fp2Jc3PAGND2midmCosc3ejJp6KYm3bCHl042SA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB6295

On 17.02.2022 18:02, Jan Beulich wrote:
> Since Lukasz has left Intel, they have suggested a replacement contact.
>=20
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

May I ask for an ack here please?

Mateusz, it would be good to have your ack too, considering it wasn't you
who proposed the addition.

Jan

> ---
> v2: Only add Mateusz, and only as reviewer.
>=20
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -318,6 +318,7 @@ F:	xen/common/hypfs.c
>  INTEL(R) TRUSTED EXECUTION TECHNOLOGY (TXT)
>  R:	Lukasz Hawrylko <lukasz@hawrylko.pl>
>  R:	Daniel P. Smith <dpsmith@apertussolutions.com>
> +R:	Mateusz M=C3=B3wka <mateusz.mowka@intel.com>
>  S:	Odd Fixes
>  F:	xen/arch/x86/include/asm/tboot.h
>  F:	xen/arch/x86/tboot.c
>=20
>=20



From xen-devel-bounces@lists.xenproject.org Thu Feb 24 13:10:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 13:10:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278251.475425 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNDtM-0003yW-LS; Thu, 24 Feb 2022 13:10:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278251.475425; Thu, 24 Feb 2022 13:10:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNDtM-0003yP-IV; Thu, 24 Feb 2022 13:10:44 +0000
Received: by outflank-mailman (input) for mailman id 278251;
 Thu, 24 Feb 2022 13:10:42 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=VLhp=TH=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nNDtK-0003yH-M2
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 13:10:42 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2abafd45-9573-11ec-8539-5f4723681683;
 Thu, 24 Feb 2022 14:10:41 +0100 (CET)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2057.outbound.protection.outlook.com [104.47.6.57]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-17-ARcgID_DMXiUqg0GfxOb1w-1; Thu, 24 Feb 2022 14:10:40 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DU2PR04MB8855.eurprd04.prod.outlook.com (2603:10a6:10:2e2::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.24; Thu, 24 Feb
 2022 13:10:37 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.024; Thu, 24 Feb 2022
 13:10:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2abafd45-9573-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645708241;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=65Jw6tko6YOMlN6w48nY0CrnwYys20i28VYVtCOCsxM=;
	b=VbjO24jvqiNJKYKviG8xxAf5XD6CCH8+nGnn6tDFRpbHgEhAREu7N3EdJeSGFsZJfIKo3h
	Wv2wNuF0H3HVBhPDfL0ki4QAGJkb/51HMWWTSxJZ7eRFwgfJNIZBO/Hoa3VzqSVFfU3iwp
	wSMteHVSop1jADa1EjKPsY87aTqDPxk=
X-MC-Unique: ARcgID_DMXiUqg0GfxOb1w-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=LUG7PJGfEhmxMzJtcye30Vr6sreVoWvKI7TezXZcow4HVj5xvgCluywbfzWwIqJWwoOi5Qa/o8lM4nglKLf+eeNG2E1CfktJv/yiEhP56a73Rneu/jIWlsxs3vJK3Evqg9WCMfZaMblB+umSOsoHyVSxt+jgzcR5Y74X4mennZd0pgrym6Ufw5a1yEvNk178kgTeE4CMTJXk6RNnPlPPV/sY90QRsCRRTB3N+GEYknmVJEGM4lMGkOwyLz/4t0no8HWsEAhJCmzL1u54Kn0pWbH0TtgX5GgieG3bzKWepZBvXeQkgOmvnp/w2w4IyaUws8V6901MLXEOI+x6wcwVZg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=65Jw6tko6YOMlN6w48nY0CrnwYys20i28VYVtCOCsxM=;
 b=W7eVeoNK/sG7yZdNvHaj/L2i0U5m8llOHcL4Cy+mmKTS3dtEMFdCBpvOpL+NrRqem7KATqLESSjPLnZa0HX3W4ifmcrvZKYX3gYAB2NMMjhCkWEc7vCqw5FqttnqIYJOpb9lfE+vDmFqIZFl8epLZB4WZLq+Esbw6pSLVhDbd7P4ACuvC4CAatXIAVcUhfO/o9DjjvIjIC4ACT74WLV5Ag0VWmW6Mx90ERc5EuqI0+Kc9FZoo/uF2Xxjpshle5N89GPrdpLOLPHnZ5hJTRxoqF5gFvRcpV9hGy7Mf5TXq+/c1Vu3/U/ptjkF+pHgJJxK9nY2FPYEKMbzT4cXEO6q5A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <30592690-ee08-1886-b6ba-b3309659d29c@suse.com>
Date: Thu, 24 Feb 2022 14:10:35 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Ping: [PATCH v4] x86/altp2m: p2m_altp2m_propagate_change() should
 honor present page order
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: Tamas K Lengyel <tamas@tklengyel.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Petre Pircalabu <ppircalabu@bitdefender.com>,
 Alexandru Isaila <aisaila@bitdefender.com>,
 George Dunlap <george.dunlap@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <b3564fe0-e375-b386-df0d-a5c2b54d1299@suse.com>
In-Reply-To: <b3564fe0-e375-b386-df0d-a5c2b54d1299@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P195CA0057.EURP195.PROD.OUTLOOK.COM
 (2603:10a6:209:87::34) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ec01ebe8-78a5-46ca-299c-08d9f7970c88
X-MS-TrafficTypeDiagnostic: DU2PR04MB8855:EE_
X-Microsoft-Antispam-PRVS:
	<DU2PR04MB8855C759621F4AA77C91B760B33D9@DU2PR04MB8855.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	2MOVFNq9ao/1/JFBybJ/PrJ93ioz6H/jK7K2zijsok1zI1ZPZ/6G2octs/uIel6gv+k4DbozPKmSPExiNppS1zy5VD471pQkQvpspPOS+P/Y/c71/qvtYeqFYIcRPpz1BBApC9wwaL2SPhyeHyMplwnz1VlRyO52CP7ngVzbC/1XW31DWPtz1gQVY537VIvfpn3XSOVXCq3eStaesFiyFi5i9sufB3r4XZZk5FZNd2KBVRsx6JH+Dd/maab2qvLqp0R7Ex0Ok3pTTfA7awosCSD8mku9Hc7My+qMDMoPjEOY89TUehKdlUhoXfjF7I2GHtPcf5YsC4KKalhX6Oo1S1X1cwIt1lw3qIaDzuaEMVoIDC0YoGvXfCLzBraQUR8juC3aWH2ds3ozI12+Wv3NrQX/amA2hGKEojTficmEOG4M95lbLYr79UjmGP0kSFYXSBOLfuTbNCwYe3Gn4b9QxnpZzo4aNGNsGUaNdFpLeJJcdCGJtATpjV8v6RcbKRYIYNp8wkt5q5DgsP7052sKOYSAykjs9KOoracqOEcZKVbQoqC2zgMf5MORycakax2DlSC4zRWKcpLZInMafc1ubIa8bmF6OUq73/dAR2VNFY1x2GiO0wk8VXlSWnZHjRz3VoF7zXrqcEyIFPwzpXrzezRujOeq7Evp8IaoBVW32+SZaX89TAe36/UT06mwAec9iWtO4mK8x0vn0VL4OWv2olIq//qr82FirRghqTFWtGBfsxuXjgO+NeDt/8/qjHni
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66556008)(66946007)(66476007)(316002)(6486002)(36756003)(4326008)(8676002)(110136005)(53546011)(31686004)(83380400001)(54906003)(186003)(508600001)(38100700002)(8936002)(5660300002)(26005)(2616005)(31696002)(2906002)(6506007)(6512007)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TVJZcnhKM0t3U1pNZDJzYWcwNHN2WGRlVG5pRUU4ZmwxOXZMcXp3OEZzZ0U0?=
 =?utf-8?B?RnBkQlYyczlvb3JqbmdBc2pMdHpyeGRpTE9ocEtyMFNCQVBkNysvTzMwK2lQ?=
 =?utf-8?B?MjhkM3hKR3h0WlRVck0wc0NWa3N1YVhOSDYwd09GdVUweHFZMnJ0dmlnbnB5?=
 =?utf-8?B?UHU2Qmc5QXpNemdhc0VjUnVjQlU4TDkzSkpjaDhuRVRtUXYrZHNRejkyUENJ?=
 =?utf-8?B?M2VXMkR4MVQvYVpsN3VRWVMwdnRsT2lzSDIxZ3dMcHh5WnY0blJKT2JxclNM?=
 =?utf-8?B?RzU1d3h3YmZBVHhvZEVQVzBpU2JnZUkwWnBSWTM1ajlONVppTWlrMzZDZ0J3?=
 =?utf-8?B?OWZwQU5tQWNDOEk4cnpaYzF4YWVhbU9FWmd3V3NwY3IyVldZcmNBMVdCa1pi?=
 =?utf-8?B?SnZSbnNXUC9PYmJJbkl6RU5iL0tUUDhqYXE5S05RQ21KSzZ4Y2ZqUEJNWWZu?=
 =?utf-8?B?SlBFeEU5d09wR0FFN3JyU1ZQUE1TalBEL2hsdGpUQXl1OFJkWnpZTWJSRkc0?=
 =?utf-8?B?d0l0Sy9BclVhSVJrMWhxSWdMY1EwcElyOXNORnA5ei9mcE9YcDF0SjJNUDVr?=
 =?utf-8?B?ZHNNMmNEUVhGejYzMzdBd0hXM0pGakVncGlZQjVLMXdkR0UwMkd4bmxnQ0hn?=
 =?utf-8?B?SFlaQXhVTmppb3pIL1VRSS9zVHJtRytURTBaak03L2pjbFhaejdTWlZIbUdT?=
 =?utf-8?B?TVkzblJrRUVZSWZ2NVZrVG9UUG1jV3IvUU9wMjc4WFQrZmZ2eXdYVnRhUUZM?=
 =?utf-8?B?N3BaVDlENmdnOGF5eGVxZ2hXUEI2SlUvbUNhUWtPczErTlkwcjUwTWNtMGlX?=
 =?utf-8?B?MS9sKzJlaHFHcVBjbDhHWUhNMHJyZ0p1T0N6eEd3K3NxaVFnUVVhK0RPNk5H?=
 =?utf-8?B?S0s5UDZBcW9seXhHalU2cnJpTzF4blZQMzh1SkNtT3ViQ1ozd2RBOWhBZ0hy?=
 =?utf-8?B?c0ZRbkJpWE5MMGM2UWMzVUgxdDFWVVdJK0tWaXkyUzdDRStCNis4UHltQzdm?=
 =?utf-8?B?VTdidlNLRDNHaWVCRDRqbEt3R0tNWWQ1NlNVa1NRcnI4QnpNc0NmaVBDRWdI?=
 =?utf-8?B?bUNRZW1IVmRHMVpaYmErNk5XeHpKeXEyL0crcTFjZ0FqbVlIWDljTWE2dWIv?=
 =?utf-8?B?cy8ycFVkRjFHNnY4UXhiR0FGVjMwYUpKaHA4L1dGZ09wL25CRVJxYVh3U25O?=
 =?utf-8?B?MXpSNVc2TWk4OW9qZk5lK3pmbXBqdWhRS3IwOVJoQm9LOTJOS2xTZHRXSXFU?=
 =?utf-8?B?MlU0QnhpeDN6MklZVnVHbWY1Q2ZUT0ZMaXhxVG9VZWlvZW5WUEgzSEtvNTZ1?=
 =?utf-8?B?dFhPR0FmSTluN2Y4MTdUNjNQdmdJanhHSFdCYjJIRW1MNWc0Znl1U2lhalFF?=
 =?utf-8?B?Wmp2RTF6ZENLOU54V3I5Z243TWt5dWdsUlJFOStrTWhQSVB4cXpXMDM4QldI?=
 =?utf-8?B?TWhXdlBCVG5MTVVpc3prL1FUbjF6aXpqMWR0VWQ5M0dyZU50aER0cm8xZnho?=
 =?utf-8?B?ZnlCM0ZRZTlXN3NqaytQTHhvMDRPQ1pTczdUdVR3MkRTbmtsK3hta0F3Wm9G?=
 =?utf-8?B?QUt5aFpxODV6dVBESVQyTWtBUnUyV1RQRkt6UmhDM3VubHlrK3ZNdUZ0Z0xH?=
 =?utf-8?B?bzhjU2YycVZRQW9RSytZL1d2WlR6VFFmZ3JZMDByOElMQWFnVUgySVllbTM2?=
 =?utf-8?B?NXp5QXJQTlpGS1BGOGJrVWp2TVJVblNUZC9Od0tCMGhETUxtTktrT3BVZkpE?=
 =?utf-8?B?MHorRk5FU2ZybTcyMk1iRjUxdy83ZXUyZWZ5T3hvTnI0Z28xR2UzSHJBMnY3?=
 =?utf-8?B?Wm9kTkU1WndCTGtEejJPQ0FJcUVUVGRZZDY3eFNRSGFoZjFjVm0vYXZtcHRL?=
 =?utf-8?B?OU9BNGNkK045NUpQdWdrV0RmeGRxVmw4NWcrZ28wSUh6K1hCZi9GSjZYbFlQ?=
 =?utf-8?B?d2tzQUlTUGpMTnJHczBXUEhKRytzWUZ3RmdUL0tMVmR0bDBMUFJtV2pzbWJG?=
 =?utf-8?B?aGFWTFprNllZNFhSZE55b3U1L1pzV1JXOHZsTHRzUTdOUnpYZXZBdzAzNGpm?=
 =?utf-8?B?YkxwWHJqVlpTYnlncVRvVENNT0pINEExWGN3WWdHWjhJaUxhSmMvZlp3VHhw?=
 =?utf-8?B?NUpUdXROVzZ0eXZlalV2NVR1dDJpLzQ4REtZNVAzVVkreGlIWWJXb0FRRUt4?=
 =?utf-8?Q?mGDUF3eXgcSwlx0mMXiJk+k=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ec01ebe8-78a5-46ca-299c-08d9f7970c88
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2022 13:10:37.4039
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hRtt//WpLMbHFWAnyEKyI8z6SrvvBocJ6PXUOBgK91WMZrFfb0vNJ+YDObJ8fVdd5vj4fVwb38ZgRgo0SOtuvg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8855

On 03.02.2022 14:57, Jan Beulich wrote:
> For higher order mappings the comparison against p2m->min_remapped_gfn
> needs to take the upper bound of the covered GFN range into account, not
> just the base GFN. Otherwise, i.e. when dropping a mapping overlapping
> the remapped range but the base GFN outside of that range, an altp2m may
> wrongly not get reset.
> 
> Note that there's no need to call get_gfn_type_access() ahead of the
> check against the remapped range boundaries: None of its outputs are
> needed earlier, and p2m_reset_altp2m() doesn't require the lock to be
> held. In fact this avoids a latent lock order violation: With per-GFN
> locking p2m_reset_altp2m() not only doesn't require the GFN lock to be
> held, but holding such a lock would actually not be allowed, as the
> function acquires a P2M lock.
> 
> Local variables are moved into the more narrow scope (one is deleted
> altogether) to help see their actual life ranges.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> Note that this addresses only half of the problem: get_gfn_type_access()
> would also need invoking for all of the involved GFNs, not just the 1st
> one.
> ---
> v4: Restore mistakenly dropped mfn_eq(mfn, INVALID_MFN).

I think this was the only open item I needed to deal with. Any chance
I could get an ack or R-b here, please?

Thanks, Jan

> v3: Don't pass the minimum of both orders to p2m_set_entry() (as was the
>     case in the original code). Restore get_gfn_type_access() return
>     value checking.
> 
> --- a/xen/arch/x86/mm/p2m.c
> +++ b/xen/arch/x86/mm/p2m.c
> @@ -2534,9 +2534,6 @@ int p2m_altp2m_propagate_change(struct d
>                                  p2m_type_t p2mt, p2m_access_t p2ma)
>  {
>      struct p2m_domain *p2m;
> -    p2m_access_t a;
> -    p2m_type_t t;
> -    mfn_t m;
>      unsigned int i;
>      unsigned int reset_count = 0;
>      unsigned int last_reset_idx = ~0;
> @@ -2549,15 +2546,17 @@ int p2m_altp2m_propagate_change(struct d
>  
>      for ( i = 0; i < MAX_ALTP2M; i++ )
>      {
> +        p2m_type_t t;
> +        p2m_access_t a;
> +
>          if ( d->arch.altp2m_eptp[i] == mfn_x(INVALID_MFN) )
>              continue;
>  
>          p2m = d->arch.altp2m_p2m[i];
> -        m = get_gfn_type_access(p2m, gfn_x(gfn), &t, &a, 0, NULL);
>  
>          /* Check for a dropped page that may impact this altp2m */
>          if ( mfn_eq(mfn, INVALID_MFN) &&
> -             gfn_x(gfn) >= p2m->min_remapped_gfn &&
> +             gfn_x(gfn) + (1UL << page_order) > p2m->min_remapped_gfn &&
>               gfn_x(gfn) <= p2m->max_remapped_gfn )
>          {
>              if ( !reset_count++ )
> @@ -2568,8 +2566,6 @@ int p2m_altp2m_propagate_change(struct d
>              else
>              {
>                  /* At least 2 altp2m's impacted, so reset everything */
> -                __put_gfn(p2m, gfn_x(gfn));
> -
>                  for ( i = 0; i < MAX_ALTP2M; i++ )
>                  {
>                      if ( i == last_reset_idx ||
> @@ -2583,16 +2579,19 @@ int p2m_altp2m_propagate_change(struct d
>                  break;
>              }
>          }
> -        else if ( !mfn_eq(m, INVALID_MFN) )
> +        else if ( !mfn_eq(get_gfn_type_access(p2m, gfn_x(gfn), &t, &a, 0,
> +                                              NULL), INVALID_MFN) )
>          {
>              int rc = p2m_set_entry(p2m, gfn, mfn, page_order, p2mt, p2ma);
>  
>              /* Best effort: Don't bail on error. */
>              if ( !ret )
>                  ret = rc;
> -        }
>  
> -        __put_gfn(p2m, gfn_x(gfn));
> +            __put_gfn(p2m, gfn_x(gfn));
> +        }
> +        else
> +            __put_gfn(p2m, gfn_x(gfn));
>      }
>  
>      altp2m_list_unlock(d);
> 
> 



From xen-devel-bounces@lists.xenproject.org Thu Feb 24 13:13:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 13:13:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278261.475436 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNDvs-0004aa-5Z; Thu, 24 Feb 2022 13:13:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278261.475436; Thu, 24 Feb 2022 13:13:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNDvs-0004aT-2S; Thu, 24 Feb 2022 13:13:20 +0000
Received: by outflank-mailman (input) for mailman id 278261;
 Thu, 24 Feb 2022 13:13:18 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=VLhp=TH=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nNDvq-0004aL-KT
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 13:13:18 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 87e2f18e-9573-11ec-8539-5f4723681683;
 Thu, 24 Feb 2022 14:13:17 +0100 (CET)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2058.outbound.protection.outlook.com [104.47.12.58]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-32-WNhWgLYYPHGM4Sc2JWNt1A-1; Thu, 24 Feb 2022 14:13:16 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DB3PR0402MB3801.eurprd04.prod.outlook.com (2603:10a6:8:3::19) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Thu, 24 Feb
 2022 13:13:15 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.024; Thu, 24 Feb 2022
 13:13:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 87e2f18e-9573-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645708397;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=6ldNnLZxgDbRv3TQOK+PsRGVxo7aLgLet9MNUXPz8RY=;
	b=Z0cEW+FFnW/EDs/L4kCcknkrOqFHKdRTGVEk8y/Ukkv7S6QKNaPGRsuelyUAls8mFpes4X
	RMAYrHrN2jCX1UVqQccOQ3J7rgVMRPG3Gnnj9RKBEAZdnB7dOYlwPk9GzGBojMlzGLCFN8
	J25t+olG7fntbTlsTMW0hqrM+MC8q30=
X-MC-Unique: WNhWgLYYPHGM4Sc2JWNt1A-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=lMTv47V+6nbgQAQUKubWsA5Pgo7HS+fivxoUIpbeFzSqCdbelCP5mifGLoNSKPQ9gjxY00c5vD3mg/cuyGZR9ZJakaxsiWnqhqa3H3h4tk8Cz9ZjOML8k/qayZMNmhRq8uNSbRwGhNJ+kzmQE417w0jfvYZZ19vLJy4GI4hXpND5bxjxuCg4UwAGA1AOgbRNfk7bDfj819oiOEpFofczA/J8BXVa6iMuX9mCE1rc0uDM9NdjNY8/ukjKxGUQJy8WO+Ch7tN/259cuAxqdu4UzdsVt5jKiVSFatj/VVcJVYsY5sFHC1v0tXNaDV78w9ftAAdUbGYQ+8vuCsTjyF5d1Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=aBPxUrxJuBaqwevMOmg3j4INynDVpKuyOSxMiVUiCxs=;
 b=m40inwvQrQuOMiu23Xm5Ku0JyftveGzqXytapUjBR8zQKWxZ3Dpco+GFi0DUZ0JK8NQpSAJYeX8gy6ahkavDFUcu/4kMQSIb/y0zpu9tFFLD1WihBSRDDCbp9RUgvc3t2QGYMFHUM70GM+LDnEU3FqgXV1/X1f+3XE+0IM5dwktZ2kThzWckUtpTMP0KPZ5BpmEsLIXugDgafN7zsU+8X+UiCM+rqeBoQGwjU4QOH/b77QodZhK4kBzgkYWnRhLHjExZO27nFyCLznSei1eevUlYkiYzdxFQ4lYXo+AIGZaEE1vtZLW9PZwFftaq0Q2xcJ8vS4rGFR03lnouo8AEdQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <d4c11b46-4ce6-b3ea-3674-d306fa6cd0a2@suse.com>
Date: Thu, 24 Feb 2022 14:13:13 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: Ping: [PATCH v2] MAINTAINERS: update TXT section
Content-Language: en-US
To: "Mowka, Mateusz" <mateusz.mowka@intel.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "Cooper, Andrew" <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Wei Liu <wl@xen.org>, Stefano Stabellini <sstabellini@kernel.org>
References: <4f26b785-ae03-34a7-7dfc-d36121a44ac2@suse.com>
 <6270f203-c839-e54a-3f94-7db88759ed0d@suse.com>
 <PH0PR11MB51424E3A85B78876690C9D5AFF3D9@PH0PR11MB5142.namprd11.prod.outlook.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <PH0PR11MB51424E3A85B78876690C9D5AFF3D9@PH0PR11MB5142.namprd11.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6PR05CA0035.eurprd05.prod.outlook.com
 (2603:10a6:20b:2e::48) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7aab71f0-235d-405b-2b8e-08d9f7976a92
X-MS-TrafficTypeDiagnostic: DB3PR0402MB3801:EE_
X-Microsoft-Antispam-PRVS:
	<DB3PR0402MB38019DFA1AE4A1969764F480B33D9@DB3PR0402MB3801.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	uwfRUMVNB1a7CbQz79adpB9wihAuxDZb6fukl/3xDWTjRhM3+IUltIZ447qHejFVjf9OyV4c7md65jRPCU9OnQsqijtJIGSYZ3Pvx9xaBiDn1wkx2B5V8ROQLH+iiVW762+W7TugMQ9/Y3VR2qDsAkd7YQt8qrzfD+fawNhWqROYiwtqHvrRlxVvhVIv8U4fCYQmFp6ZbqYjH/0UKyqV6RYuHMya39ymPKcJeELW2zb2Hcy2o06FlqulsI5LGopiyA3dtChGz4BgVtN5mgE98IdY5f5/sNARliSCCAqUBsz7pEr/kZAWuqmyBZca35AMfcu5pdjrEvHNO+2iJSHDHIZtEjR1NEOvAnpVGJmqIJ+ALiUTePRJ9KgWdWJncn2TR3Y4aHN1cCqinB7h3Q+2WSo2IibzvB/oMTSiH3rojjjE7i0QHWzETzFOFHD1VvbxVU1WTxWGGXDvgSmg9RyM8KjbqKin5vVflpQd/fU2E6OJacSyRZTcFKlpuyOivWJme4BMNkmcCg6UezxtTtWDw1/c+T4tcdKQ/DTpEXMy4NaW4lUsG78G2sjqGR8Xnu+5Oceuwviy+0npHboPHD7sF99OhbutQW77kOAVo2OjH37BnqZ7yp85pbaDIYfzirfbrWL0n7Rc4py7NTZyu1HoKyiFuf1YPlpKFLZzt+oeqRJN4hSH5vGsagpWPUIaHEEk7BZO/ERXakjkbFc5NWCkoHkf3l6RK8Ke+y5P0tYx5LSIYLRWkJWVwD4gE4UJxgi6
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66556008)(6512007)(6506007)(8676002)(66476007)(53546011)(6916009)(31686004)(86362001)(8936002)(31696002)(6486002)(5660300002)(66946007)(316002)(508600001)(26005)(2906002)(4326008)(38100700002)(83380400001)(36756003)(66574015)(15650500001)(186003)(2616005)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?x9b6d1hlfI80gS+5hHidIfJ3ba0xr+rSXmvCDStUlqwnxtJ3mJc5j5YJl9H9?=
 =?us-ascii?Q?gDZMkiepbzf2x4MhNmwvMZZmQVMF1HF8mzzsVjA99a8Ul/DqLVi7KO97aDzi?=
 =?us-ascii?Q?QD+iaZk8l+pLGmZhTCuhmYs9YSTkx1rnKuys+9rQYMGjmCC79eGxvwzv3ZCJ?=
 =?us-ascii?Q?1kcjfaXfNiR9zQ1Iy8qDdKGPvJGgK6VIMP0yUQvcxW9UMy7keeqTxgJEXlqy?=
 =?us-ascii?Q?u0czmGB6X4GUhv8kn5Cg85i9PbEzWz2nl2Jy+V65tGSARfo0FrG2uhZThBCS?=
 =?us-ascii?Q?lODrhop7AiuZZ7ykOIIINbMkjL/ved3vr8fh3oL6WKKFH/bVOVmPFoTor7Un?=
 =?us-ascii?Q?ab7EPYlHzsLiRi3GKNQzQWKWZ7sZlrDy2FcomBLy55s9kvGS5R6R307HpG+B?=
 =?us-ascii?Q?c5ctRb8vSXSLIgsfdzhJ1Lx7dVHtKiVVk3Li2Qq+DgpJLMHhWg0ehtsbEFI+?=
 =?us-ascii?Q?K6e3MYO0ViF5Gmnr8hin+8tgvIBjjN36xyeNun4ozyQLEBiljuMvr3fcy6Vm?=
 =?us-ascii?Q?IrFM8ZhsOZVE6vM5WzUf5UfXxVMQ0VgqTCYXw1Dd2LncHj36ZCPaYyDPGayW?=
 =?us-ascii?Q?g1MJbIvvSyC5TO07N7Kb2WLSK7r/Tt/0ktd2OySUT/G3TBS4qxX+jqcb8S41?=
 =?us-ascii?Q?9b34FvdzXlRIQPtLLGrHoCZKkPA0OAVBeMJIbnjR0zvNoiEN83Sn7rzoJ0UH?=
 =?us-ascii?Q?D8eIofduL0DMJ6nCGRhj0dxwfESECns1fUMtGOQfA7qNj6BigxD6FwGfqOhA?=
 =?us-ascii?Q?vG7S9GkEzNX9YfhaXsWmbgfkPF+VLZIoR2j2BYM1dllLbQrr6TS9vn1/9HMk?=
 =?us-ascii?Q?MKzoLqm2S1xYMhKvm/YFLWTZWsZ4gsFHAyXuz1TyR794rwRq6kTvi0P3bcw5?=
 =?us-ascii?Q?hZWouwTmsgEcZr5dk56nDfQOvtt/LAnGj8cd0r5q5f9pSo/ctY4UJUiXWdao?=
 =?us-ascii?Q?hXzldFi/sqI1jPso4p7cvCVUhoFN0LeF2y3Q5UiZo7J9JTeW4gDM3j1ZtHtF?=
 =?us-ascii?Q?Vi7KtuZSTebxyYhf279P2bcT6EgtEt0Ys7uYY/zNClkSGkW9l3xQQMgMBjYv?=
 =?us-ascii?Q?bMb837dUIfFM9CoHnoFBMaStN2eRvgn8E0lUcFIzEH3dJIvLxFk0dH594Fn4?=
 =?us-ascii?Q?m7zjNCJ1ipC2CxnbNtxDhc5AI5ni0e1CuHQnLKMysGgV/LAtjCebnhiQWeGB?=
 =?us-ascii?Q?L+p9lIADmlg+PSidb7Etc2urbPSsPH+Z3x0U++0nyy6kellDwioZfb20CxO/?=
 =?us-ascii?Q?mnVpBt2Te+nJaCkAxKgTlrmtSdHhDLywv6+jdoP5UN6sUooCsK6wr06ubaTk?=
 =?us-ascii?Q?rBmqSj4KGbrTfHP/71WtfqHzffVJOlPHpSfLaJCUx9tx7XRln/6Xv4iLgZ7i?=
 =?us-ascii?Q?SOjBrcgeEAk3yQJHaecewm6BZ17u1Jf2kntKGAKu+nS2cBcfMPW3t6YRYBUC?=
 =?us-ascii?Q?pRjMYDcAT5n4JiD87elaV0MnhzBhX+drMvBesqzU4V6Oad7Q7YDaNYGsB9J7?=
 =?us-ascii?Q?gp7jBX4NIBmLs3FFa8m5vgo+aOlAHCKYUwe9WZUdPiE1T3ijdQZzXxsYl8wV?=
 =?us-ascii?Q?y39qd1uDHFQltrL3fo2jxZB8PIj3bRwjUSTlxZ2Ic5mZ5wBTbvg/pr3AYcV0?=
 =?us-ascii?Q?5a0ia0PlMJnTxSr97HOBqDE=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7aab71f0-235d-405b-2b8e-08d9f7976a92
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2022 13:13:15.1128
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YQTh4KilkKY2c0vd6dtRkbxN3y3Gx0tTQ6wEHDc4fHW2VxE7QFeNQ7/MoNXPiorSIoEhKtrDA4snb4ucpiocqQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0402MB3801

On 24.02.2022 14:12, Mowka, Mateusz wrote:
> Yes I will be acting as the contact point for tboot.
>=20
> Best regards,
> Mateusz

I'll take the liberty to translate this to an Acked-by: then.

Jan

> -----Original Message-----
> From: Jan Beulich <jbeulich@suse.com>=20
> Sent: Thursday, February 24, 2022 2:08 PM
> To: Cooper, Andrew <andrew.cooper3@citrix.com>; George Dunlap <george.dun=
lap@citrix.com>; Julien Grall <julien@xen.org>; Wei Liu <wl@xen.org>; Stefa=
no Stabellini <sstabellini@kernel.org>; Mowka, Mateusz <mateusz.mowka@intel=
.com>
> Cc: xen-devel@lists.xenproject.org
> Subject: Ping: [PATCH v2] MAINTAINERS: update TXT section
>=20
> On 17.02.2022 18:02, Jan Beulich wrote:
>> Since Lukasz has left Intel, they have suggested a replacement contact.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>=20
> May I ask for an ack here please?
>=20
> Mateusz, it would be good to have your ack too, considering it wasn't you=
 who proposed the addition.
>=20
> Jan
>=20
>> ---
>> v2: Only add Mateusz, and only as reviewer.
>>
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -318,6 +318,7 @@ F:	xen/common/hypfs.c
>>  INTEL(R) TRUSTED EXECUTION TECHNOLOGY (TXT)
>>  R:	Lukasz Hawrylko <lukasz@hawrylko.pl>
>>  R:	Daniel P. Smith <dpsmith@apertussolutions.com>
>> +R:	Mateusz M=C3=B3wka <mateusz.mowka@intel.com>
>>  S:	Odd Fixes
>>  F:	xen/arch/x86/include/asm/tboot.h
>>  F:	xen/arch/x86/tboot.c
>>
>>
>=20
> ---------------------------------------------------------------------
> Intel Technology Poland sp. z o.o.
> ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wy=
dzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-=
316 | Kapital zakladowy 200.000 PLN.
> Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresa=
ta i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej =
wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jaki=
ekolwiek przegladanie lub rozpowszechnianie jest zabronione.
> This e-mail and any attachments may contain confidential material for the=
 sole use of the intended recipient(s). If you are not the intended recipie=
nt, please contact the sender and delete all copies; any review or distribu=
tion by others is strictly prohibited.



From xen-devel-bounces@lists.xenproject.org Thu Feb 24 13:22:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 13:22:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278258.475449 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNE4v-00065t-5r; Thu, 24 Feb 2022 13:22:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278258.475449; Thu, 24 Feb 2022 13:22:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNE4u-00065l-WE; Thu, 24 Feb 2022 13:22:41 +0000
Received: by outflank-mailman (input) for mailman id 278258;
 Thu, 24 Feb 2022 13:12:14 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=V6aw=TH=intel.com=mateusz.mowka@srs-se1.protection.inumbo.net>)
 id 1nNDuo-0004YD-6f
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 13:12:14 +0000
Received: from mga17.intel.com (mga17.intel.com [192.55.52.151])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5ef2cfc6-9573-11ec-8539-5f4723681683;
 Thu, 24 Feb 2022 14:12:10 +0100 (CET)
Received: from fmsmga006.fm.intel.com ([10.253.24.20])
 by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 24 Feb 2022 05:12:08 -0800
Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81])
 by fmsmga006.fm.intel.com with ESMTP; 24 Feb 2022 05:12:08 -0800
Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by
 fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.21; Thu, 24 Feb 2022 05:12:07 -0800
Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by
 fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.21 via Frontend Transport; Thu, 24 Feb 2022 05:12:07 -0800
Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.47) by
 edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.1.2308.20; Thu, 24 Feb 2022 05:12:07 -0800
Received: from PH0PR11MB5142.namprd11.prod.outlook.com (2603:10b6:510:39::20)
 by MWHPR11MB1871.namprd11.prod.outlook.com (2603:10b6:300:111::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.17; Thu, 24 Feb
 2022 13:12:05 +0000
Received: from PH0PR11MB5142.namprd11.prod.outlook.com
 ([fe80::6903:ac9a:d1b5:d99f]) by PH0PR11MB5142.namprd11.prod.outlook.com
 ([fe80::6903:ac9a:d1b5:d99f%8]) with mapi id 15.20.5017.023; Thu, 24 Feb 2022
 13:12:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5ef2cfc6-9573-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
  d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
  t=1645708331; x=1677244331;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:mime-version:content-transfer-encoding;
  bh=mNCBq8svLvkZHHn4yMzKpg42ucC+IFFAAbGK4zEBU1Q=;
  b=dCdCxWp1S8gBZS4ViM+nkrQ6WdRt45qXW5WXQqA0BV6XyMC8nQht0hEA
   wluRC1zqpFd3mbi2Q3ZZ5cq6I6CC0BN38lUuBv5XJc69xlwUWZJQ7niNA
   XyqMStk/VOrPRsoppuASCF8wPMtL0srDHjta+t26mHv3qIX3LaK7b6S06
   gBFffhnxdVLSVP/hvlQKhG0KNkS5RnZUPUTbk0HgzLOlsPRw5xYsP1jXY
   muiZMuUXHpjQi1bUE0LTaulC0qZIsrwQwCJztXXlwhGNIuj4JuBZHPhRq
   NzTKnvyIxn+sP5E5dUR7Szsrbe7KV3+rWq5yJ8RbUZSnAGvvdmxVcEs+d
   A==;
X-IronPort-AV: E=McAfee;i="6200,9189,10267"; a="232852025"
X-IronPort-AV: E=Sophos;i="5.90,134,1643702400"; 
   d="scan'208";a="232852025"
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.90,134,1643702400"; 
   d="scan'208";a="777049966"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ZBqV79Hck6v33rcVw2NudWrjaKInehRHpHwZxL4AXYo8IHt1p4p5/l6l62ks+Mukgp1uZcA1Xez3KO1iBknQDI8XMH7n+t56A0jrFADyeT7b5OCNuvzAcraQumg6Xad44WO7l8xStQJyQ0yMubmqjBdTBdPIPtffkzjf3RStmEJIZLWFjfoRjAHR+gAfAaKB5KGHWdED0a+Vb4+lZW2j3kpIta+Ni/PFNEgHuUEqeu6j5JMrDLn4WjlqbnlFhGqygTd+2Or9puG3wOPNz9gfCQOVfZ9RxrXgMEfwLys1171r/f+C96nD4nRYC/kDQnMmD38cwMfrzUdcBdolYuVVgA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=FAu4XZIjHWAr0v7JfXdoXUKgXBHeQOem368qH6nFmTg=;
 b=F7lcVYsxVqNVMEf5gc71YV813HrbNwO/cBGKOTWQrouF7tsUsLcpyZBjghUdNMJn+fnOXmSvMpT/PYwrjzJg3SwqPCG7bNSaMndNGeHZKRkN0B4Fzc8+SbJPZ6Uy0ZKRlasdxgG3V8W8aegd+tysHFPxwQKu9+3tw/UAa0jad+lLGGEX9gtYfIhXhbqpsfZ18xRKfwoXlsn+bJKG+5gDA9HyfKlXyN0bT/oHY+ra9YaACjWDSEd1QXA+DYSBgdVOC9+2ZPah6Q8Nrwd5BFBLfF0T5riEggxbDtwh5T24kWqMI3y5ZQjrZZzIbStsiF5aWpa+YTZmjKQm29fn0GwXpA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
 dkim=pass header.d=intel.com; arc=none
From: "Mowka, Mateusz" <mateusz.mowka@intel.com>
To: "Beulich, Jan" <JBeulich@suse.com>, "Cooper, Andrew"
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, Julien
 Grall <julien@xen.org>, Wei Liu <wl@xen.org>, Stefano Stabellini
	<sstabellini@kernel.org>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: RE: Ping: [PATCH v2] MAINTAINERS: update TXT section
Thread-Topic: Ping: [PATCH v2] MAINTAINERS: update TXT section
Thread-Index: AQHYJCBLPiOV2LeuHUWNWAbVtoiwwKyitvWAgAAA0ZA=
Date: Thu, 24 Feb 2022 13:12:04 +0000
Message-ID: <PH0PR11MB51424E3A85B78876690C9D5AFF3D9@PH0PR11MB5142.namprd11.prod.outlook.com>
References: <4f26b785-ae03-34a7-7dfc-d36121a44ac2@suse.com>
 <6270f203-c839-e54a-3f94-7db88759ed0d@suse.com>
In-Reply-To: <6270f203-c839-e54a-3f94-7db88759ed0d@suse.com>
Accept-Language: pl-PL, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.6.200.16
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=intel.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: ab6af04d-f58c-405c-4149-08d9f7974120
x-ms-traffictypediagnostic: MWHPR11MB1871:EE_
x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr
x-microsoft-antispam-prvs: <MWHPR11MB18714D3643C6008305914981FF3D9@MWHPR11MB1871.namprd11.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: ZyLara71FYk9zfzNOr41Twb3+xyEw+/SlnjknzfsITEv8m66hBpWa0z9NR7+IwbDaEfwSd5pO7j/hUjJVFqgDMUDwNmlpAofNi9pj0d59o5Tg6/HU5aaCf0GesjxdZQUDPRPXgK+cAKuObH7xC3hQLo1th+v/C4F7gS/ComGmSP2FGJGMMBofVCiK2V3wa8YnzD/Ho/Ah8+x0pmj9gNL9obqYGJX4EAYUvA2ilfy6WmbkAv2mAHYms/4j2XBif1gz2Z/xjYRDUH+stSMSOZjsD8UyaqmyDCsfHONAtXrU26XqfnfFpDCzjy4cQfjI2ShrTSmadQ8vFujL8Q/z6umYzBr9y7bkFXpR0ODRwUyaZuYhBo3wn+VeY2Z+5SK8Jhe5cJpKC4uhMO8q25Yu4nvdeiiEXJAYrMj2MpLPh9e5r93qPRJu3SIUVQLc7OfafgdK1ci4T+IRdwLmg/0mpoU78ASxKv1RE/FuGSFL5jlMnxQxgnymlaoqk/l9ow9CTzcLS1j2qd1zE+hEOeiV96957E/lNh0lF2WTH3Ytvp7L7i9bFwNvEKebXgBvusMv2GGRkZKkoKatmbAdub3BbWX4EKsGt/fBtTXyGQ7wZTKV3jAYKnllgVH1eny1BBwCovYFzAYRaa92A9ZP5DjjrqSSKMmePknvLj9cWgCXh769wX+fUXbaQi8Y0HrJeTh3NoUxtYk50AIBLhWiWImueEaqw==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5142.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66574015)(5660300002)(122000001)(15650500001)(53546011)(2906002)(52536014)(6506007)(7696005)(4744005)(9686003)(8936002)(82960400001)(55016003)(83380400001)(33656002)(66946007)(66476007)(66446008)(64756008)(8676002)(66556008)(4326008)(71200400001)(76116006)(186003)(38070700005)(316002)(38100700002)(508600001)(86362001)(26005)(110136005);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?SjJhd0Mxa3JSY1RnWDM4a2ZJNUkzNHFqWEc0NmVCbjFGY1RrNUxwRkJzOTlN?=
 =?utf-8?B?MnM1L3dIaGxJV3J0bzBITW5OUHM1dG9ic2hua2tRdHg3L3hZWmtOUENoYmJU?=
 =?utf-8?B?dGRoTE5UN2RVMjBrMnB2YkZvNlVMUmNEMC9TSFhIbzVXOG9iZFBFNmhwL3FB?=
 =?utf-8?B?cUFQYUhkc045ZzJaQ2pMVXlRTHFrWnBDNktGNzgzK2p6TmRxcW1jM2xnaWFn?=
 =?utf-8?B?ZW9SaGpmZ3NlNXJpUStMYWpEWUVWNG5Ec3BBT0o3Nmd2UzNVd0JRUFY1NUN6?=
 =?utf-8?B?UHd1dmQ5OUZ2Z2RrQTdBMjlZZG96NHM4QW9ZU21ya3N1OFE4dEhFWUdCWjBl?=
 =?utf-8?B?TWhyVVBFejYrNDhIbTdwL0FVTndXTGVGa0dnaTFBTW1uUSsxVXR4ellIbzRo?=
 =?utf-8?B?MzNsTVB4TEEyZENiaUVlTm9jRlcwUFc4OXBUVHhSYWZobG5EUUpjVDRSbjJS?=
 =?utf-8?B?a2IvUjh2R1l3TjNIN1QvaGRac2ZxZmYvditpWWM5bG5mM1R1T3RWZ0JKSVVQ?=
 =?utf-8?B?TzFFaEU2aG1ROXJSUFdZaDBRYnMzWmVxTzRqNEFlVTNEU01XV2duSUlDd0l4?=
 =?utf-8?B?bHFtcDV3Qk5jdWQwMW5xLzNDMDloSHVJcHJyYmx5eFM2NFFRcHpjNFpaK05w?=
 =?utf-8?B?VWlCTEl4U3pFdFJFc0lKVFAxemFzamJWRjNqY2xFRnFSaHp4UWVYM1FtQUN6?=
 =?utf-8?B?OS81RGY0bDRQRTFKaFdxK2VGSmdFVHlUMVViYXp1bWxnUThsZXNNbm4vUlVN?=
 =?utf-8?B?VllJdlFFV0g4ay96U241WjBrTnVBUk5iTFdoRG9pcWU1WS83OWJGSHAxaTQy?=
 =?utf-8?B?OWdKMnFjcXQxdU9yc0V4Tncxck56MkQ3aTZHWG5MeHp3OSs0ZXdaSXFGKys3?=
 =?utf-8?B?MDVvMVhxMDU0akFVdmpMa3NYa1EranhVTm56Q21MWWtlOU5rdUtCdG91QWtX?=
 =?utf-8?B?YkRYZ1dkZ3lnZGRzTVJJcENodUtBYktUK0RvL3IydEpNbEQycHJGUmZYRTZB?=
 =?utf-8?B?eHM0Vm9IeXBtc2xMKzlKeUJydVV0QmVRTW5NRkt1NHVzQk5kMHVGUlA5cEsy?=
 =?utf-8?B?V3VpR0VXeUZ4Ukk0T3lzcTA3NmJZSEFUSmxmSDVxbEVXUXM4VnFWcUI1SFdU?=
 =?utf-8?B?dmRIOEMzZHpuUDBPekJNWU5HWml1Y013RXZ0Njc3NjE2TWYrTFZVSVhoWXpu?=
 =?utf-8?B?TmUweGJvSGFIRk5DNVBiY1VJNGJJM0dvR2NBRU8wOEZKOVI4QnJtOUhKK0F2?=
 =?utf-8?B?N1lWNi85ZjlMcktNNTJEVnJmWEZGOXNlL083ZWpBUERYNWo1WkkvVTNXL0lJ?=
 =?utf-8?B?RDlqazRETnNYREFiK0l4MWlsTy9Tc0QwOVZIRkcwVWZnRU92cXJrenZxYkV1?=
 =?utf-8?B?ejJKYVVZSlVSbnNpbTVNcHc4cVovblNlTzM3T2lVTUN3cEYzVHI0U0IzNFU3?=
 =?utf-8?B?NU14ZzZaMFp5UWdLN3ZXaHc5YlJheUhSV01nME53L05scElvcno4d25KVEoz?=
 =?utf-8?B?WVhidU45Rzk1dVRDSmpZb1pHWCtXN3U3aElRUmE4VWJNRWloOXZIRW92NWRP?=
 =?utf-8?B?QUxIUUY3b2VHc1Frbjl6Qk5ranYxUUk3ZG1qNkh5RTV6Z0xvREl2eDRpK3RO?=
 =?utf-8?B?cEdVRmgzL25TZENNcytDQTJwRUZrL25Uai9IR0pCZWU0UGdhSkhmOEdyZzNt?=
 =?utf-8?B?TlVZNWpkTGxJUEJoWGFjT1F3UkJLbWZpQnNTcWFjRzBqVjAxWXlhZ2kvR1dp?=
 =?utf-8?B?bXliYTFpMzhqdEtmblRIMGQxZDB3YWZnbVg0NTBmUTZnazJOOFFUaHN6SkR4?=
 =?utf-8?B?d1daZDRSaEIzS1BVT28ycUtjNkhVYnpnc2hvZjBMUFBUM2VnWnVZMW5Ec2ow?=
 =?utf-8?B?aFRDVGM2WEpjMC9kRjJDSHArZ28vL3VCTDFuRkYwbGdlR3BWcmM3alBPcHNK?=
 =?utf-8?B?UUJYMHIzN1JOSmx0UjNoZnNZdDRuWVNQcHk2RVAwSVN6aUJkdjFGZDJaL2pj?=
 =?utf-8?B?eUpkNjFjNnJuTDVWUllET1lwU205UmFzVnRXL1F1MnpTQUtwdXh6ckREOUp0?=
 =?utf-8?B?bW9Yb09WZTNMTEs2Yld0Wjl5ajlTclBSejNiVVZtRkVQc2R1S2tmZno3cWF0?=
 =?utf-8?B?YXNvTW9TejdhaVZXZXRUKzdkOExlaE9tZkVyZWJjdHVlVXJPdkZSYllmZzF1?=
 =?utf-8?B?MVE9PQ==?=
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5142.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ab6af04d-f58c-405c-4149-08d9f7974120
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Feb 2022 13:12:04.5161
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ynV7QzZ3r0c9c7M7+BBzAjkK05nBmJFVidFqzcb113wEr2Sriw6ryFmo0GQ7May4sljy6NVu1zI8+8dUEUruFQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1871
X-OriginatorOrg: intel.com
Content-Transfer-Encoding: base64

SGksDQoNClllcyBJIHdpbGwgYmUgYWN0aW5nIGFzIHRoZSBjb250YWN0IHBvaW50IGZvciB0Ym9v
dC4NCg0KQmVzdCByZWdhcmRzLA0KTWF0ZXVzeg0KDQotLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0t
LQ0KRnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPiANClNlbnQ6IFRodXJzZGF5
LCBGZWJydWFyeSAyNCwgMjAyMiAyOjA4IFBNDQpUbzogQ29vcGVyLCBBbmRyZXcgPGFuZHJldy5j
b29wZXIzQGNpdHJpeC5jb20+OyBHZW9yZ2UgRHVubGFwIDxnZW9yZ2UuZHVubGFwQGNpdHJpeC5j
b20+OyBKdWxpZW4gR3JhbGwgPGp1bGllbkB4ZW4ub3JnPjsgV2VpIExpdSA8d2xAeGVuLm9yZz47
IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz47IE1vd2thLCBNYXRl
dXN6IDxtYXRldXN6Lm1vd2thQGludGVsLmNvbT4NCkNjOiB4ZW4tZGV2ZWxAbGlzdHMueGVucHJv
amVjdC5vcmcNClN1YmplY3Q6IFBpbmc6IFtQQVRDSCB2Ml0gTUFJTlRBSU5FUlM6IHVwZGF0ZSBU
WFQgc2VjdGlvbg0KDQpPbiAxNy4wMi4yMDIyIDE4OjAyLCBKYW4gQmV1bGljaCB3cm90ZToNCj4g
U2luY2UgTHVrYXN6IGhhcyBsZWZ0IEludGVsLCB0aGV5IGhhdmUgc3VnZ2VzdGVkIGEgcmVwbGFj
ZW1lbnQgY29udGFjdC4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGlj
aEBzdXNlLmNvbT4NCg0KTWF5IEkgYXNrIGZvciBhbiBhY2sgaGVyZSBwbGVhc2U/DQoNCk1hdGV1
c3osIGl0IHdvdWxkIGJlIGdvb2QgdG8gaGF2ZSB5b3VyIGFjayB0b28sIGNvbnNpZGVyaW5nIGl0
IHdhc24ndCB5b3Ugd2hvIHByb3Bvc2VkIHRoZSBhZGRpdGlvbi4NCg0KSmFuDQoNCj4gLS0tDQo+
IHYyOiBPbmx5IGFkZCBNYXRldXN6LCBhbmQgb25seSBhcyByZXZpZXdlci4NCj4gDQo+IC0tLSBh
L01BSU5UQUlORVJTDQo+ICsrKyBiL01BSU5UQUlORVJTDQo+IEBAIC0zMTgsNiArMzE4LDcgQEAg
RjoJeGVuL2NvbW1vbi9oeXBmcy5jDQo+ICBJTlRFTChSKSBUUlVTVEVEIEVYRUNVVElPTiBURUNI
Tk9MT0dZIChUWFQpDQo+ICBSOglMdWthc3ogSGF3cnlsa28gPGx1a2FzekBoYXdyeWxrby5wbD4N
Cj4gIFI6CURhbmllbCBQLiBTbWl0aCA8ZHBzbWl0aEBhcGVydHVzc29sdXRpb25zLmNvbT4NCj4g
K1I6CU1hdGV1c3ogTcOzd2thIDxtYXRldXN6Lm1vd2thQGludGVsLmNvbT4NCj4gIFM6CU9kZCBG
aXhlcw0KPiAgRjoJeGVuL2FyY2gveDg2L2luY2x1ZGUvYXNtL3Rib290LmgNCj4gIEY6CXhlbi9h
cmNoL3g4Ni90Ym9vdC5jDQo+IA0KPiANCg0KLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCkludGVsIFRlY2hub2xvZ3kg
UG9sYW5kIHNwLiB6IG8uby4KdWwuIFNsb3dhY2tpZWdvIDE3MyB8IDgwLTI5OCBHZGFuc2sgfCBT
YWQgUmVqb25vd3kgR2RhbnNrIFBvbG5vYyB8IFZJSSBXeWR6aWFsIEdvc3BvZGFyY3p5IEtyYWpv
d2VnbyBSZWplc3RydSBTYWRvd2VnbyAtIEtSUyAxMDE4ODIgfCBOSVAgOTU3LTA3LTUyLTMxNiB8
IEthcGl0YWwgemFrbGFkb3d5IDIwMC4wMDAgUExOLgpUYSB3aWFkb21vc2Mgd3JheiB6IHphbGFj
em5pa2FtaSBqZXN0IHByemV6bmFjem9uYSBkbGEgb2tyZXNsb25lZ28gYWRyZXNhdGEgaSBtb3pl
IHphd2llcmFjIGluZm9ybWFjamUgcG91Zm5lLiBXIHJhemllIHByenlwYWRrb3dlZ28gb3Ryenlt
YW5pYSB0ZWogd2lhZG9tb3NjaSwgcHJvc2lteSBvIHBvd2lhZG9taWVuaWUgbmFkYXdjeSBvcmF6
IHRyd2FsZSBqZWogdXN1bmllY2llOyBqYWtpZWtvbHdpZWsgcHJ6ZWdsYWRhbmllIGx1YiByb3pw
b3dzemVjaG5pYW5pZSBqZXN0IHphYnJvbmlvbmUuClRoaXMgZS1tYWlsIGFuZCBhbnkgYXR0YWNo
bWVudHMgbWF5IGNvbnRhaW4gY29uZmlkZW50aWFsIG1hdGVyaWFsIGZvciB0aGUgc29sZSB1c2Ug
b2YgdGhlIGludGVuZGVkIHJlY2lwaWVudChzKS4gSWYgeW91IGFyZSBub3QgdGhlIGludGVuZGVk
IHJlY2lwaWVudCwgcGxlYXNlIGNvbnRhY3QgdGhlIHNlbmRlciBhbmQgZGVsZXRlIGFsbCBjb3Bp
ZXM7IGFueSByZXZpZXcgb3IgZGlzdHJpYnV0aW9uIGJ5IG90aGVycyBpcyBzdHJpY3RseSBwcm9o
aWJpdGVkLgo=



From xen-devel-bounces@lists.xenproject.org Thu Feb 24 13:23:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 13:23:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278275.475459 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNE5b-0006ea-Fu; Thu, 24 Feb 2022 13:23:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278275.475459; Thu, 24 Feb 2022 13:23:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNE5b-0006eR-CK; Thu, 24 Feb 2022 13:23:23 +0000
Received: by outflank-mailman (input) for mailman id 278275;
 Thu, 24 Feb 2022 13:23:22 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=VLhp=TH=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nNE5a-0006TH-9B
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 13:23:22 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id efc28a13-9574-11ec-8eb8-a37418f5ba1a;
 Thu, 24 Feb 2022 14:23:21 +0100 (CET)
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur01lp2053.outbound.protection.outlook.com [104.47.0.53]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-6-pr-1GSuRM1un-WgVWk45yA-1; Thu, 24 Feb 2022 14:23:20 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM9PR04MB8114.eurprd04.prod.outlook.com (2603:10a6:20b:3b7::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.24; Thu, 24 Feb
 2022 13:23:18 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.024; Thu, 24 Feb 2022
 13:23:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: efc28a13-9574-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645709001;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=+YodAfqsPKICzS0Dp2bGIso17g1NohmT0LbRbyRij88=;
	b=bcdbUzJqsRLNHgorC3Ct19HY43ifQ3K4Zhhn873+jZk1UxPZm3pAEoMxoF404jObWeq5++
	qsUVDoClrNRSAbD3sFolgm03cqgSZSBS/fgQNaSjzvN84dyWPyA+9WCjY+Jigpqc3L+nXW
	yyiuj6CAitp5RS4muO8vxFCp8u34oQE=
X-MC-Unique: pr-1GSuRM1un-WgVWk45yA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=TNMUMznUgBa0K9agSGpU/mVlU1/ep/aqVFt5xDR6kPSepP6WBnqYDNhMirfHnr2ATl81GZzM5eqZACrEd69hgorE9sKNSX7gr6nJ1wg8qJHS51YwhqYydv8iBFv8k15eqwJse4QoI9h31vO2QeNR9jFBDTBqpWJYiSuTF5ar+yuhPP/zB7ovv7/k3Tbgeu1u2nTYu5LYBeJJQ1twxtzd+tb47N89YUR18d81u1PDnsxlnmDue/MCiHw9VcjoRbhVo2vuLbZTkLCXVG+Z1QmL8OoolK93cL4XQ0qiecI/pScAm8OJ42Kk5cowxwkoNFz0A4uS7gbosx8+FOiBKJ71iA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=+YodAfqsPKICzS0Dp2bGIso17g1NohmT0LbRbyRij88=;
 b=cv2Upzs0/mG48IMq0cGVA2J5eo0sOShcsROrYyEuI7UY8dXSB2SLZN4CyKPYUQiMaFEB4PTyskJ9UCXGBxTI88pn62q6TVZdkYsMddCHtR23nltlXpHr4NtnKccdgV23lSVGInY1P8WAGGuWUhkLHA2ofORt0Z+fHKJnALjHgJi2ktF2LC4spFooASQXBIxkWILfKfm8llGYfTSPr/pvpaCilQREpZA5RaAjDuiBpuhnJC4Em9ElLORZge0vBzHkO7wRpCiykXTHiqo9FGYgDwRgUv9AebfE0j6+uNMSBJgZNsqYVAqNfiueIEAL7TvXn3Pc23XEvFVlHdZ1AD8N0g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <265e87fa-0f05-7953-1bce-34999119d3c4@suse.com>
Date: Thu, 24 Feb 2022 14:23:11 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH v2 0/2] x86: correct fencing around CLFLUSH (+some tidying)
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0006.eurprd04.prod.outlook.com
 (2603:10a6:20b:310::11) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f9327b4b-8802-41ed-7a54-08d9f798d25d
X-MS-TrafficTypeDiagnostic: AM9PR04MB8114:EE_
X-Microsoft-Antispam-PRVS:
	<AM9PR04MB8114B9154A4AE907E9409519B33D9@AM9PR04MB8114.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	vBgelroo1j2MeD5jY+6E8ydPo4r0qIhxMmIAMfxHlyRlqNEFDwXrUtDV7XFj9cPiIuzBgLvQsEJ/wEkIhmzHN6w+nrYBJq3UWXtTxtGgiPey2Nofh25K9S6JqtghfEPV0aideWeEKcLDbUdd52+mO0zlGtlaSPdsv28/kbT6M4x3WzMYm/It/YRud2Tx3WiZUr8TxdZrHJFrmV8B90Pu2kt4LYe9GMv/wJdn63spJR8NnN0w7AxaYdbFQnv066pALXcSBUvbH4siNJWqY4bEoUypHcnxwLhO9ctriCABVDErCMFSJADT5azGHHsRT3/1N1bR4vqQWqDnZSgl1+LCcyK2A1wTyusgT3W29gTfh0qthGzxdApVM086A5NUy1ghnkWGMoERT9uvyOrWEmLgB9fw3Lhkge4zf6OdLPMkIknQCfAjPmB20HUOoFzeP3+wgtu3789eHdFdvBOZXhWUv+h6Wl0cZcmuVeZZ+ghk1GblgM51LTQnwBoO37QLB+mnnynhCFgs7gAC+acxbiDiKOKeCspJX9vWJZF2ow9ew0xvwocG68+SjosaW7hcxFmAOaTwrc2rmySnxbo33qLaDWn/dydpFVu70cCrfW3xdXN25cY3nDDAVUjP0K9rMy46ce0ahskArRb5iegz/HsiKkHojCVqZV+day5rscuHsaYlpDwRkj28Uws+DViywryQmCMHqh2otcLMhjd9vL3y4mlEvW2tcj2ntXnjGj5uDTs=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(186003)(31686004)(2906002)(36756003)(508600001)(26005)(2616005)(54906003)(4326008)(66946007)(316002)(66556008)(6916009)(8936002)(6512007)(5660300002)(6506007)(66476007)(86362001)(6666004)(31696002)(8676002)(38100700002)(6486002)(558084003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?K3Nsd3R1UzcrMGptQVlOelpPTVZ5alFoWFlTRTA4TkptVW5NL0NMazRHcTJE?=
 =?utf-8?B?eDBDaFZYdHVJT2dRUyttZEdwdjhubnlweDFBc1lkSHkyZWwvRU1hY1hSV0xE?=
 =?utf-8?B?Z2Q2YXcrZVVhL3FqUkNFZERoZnBwWW1wS2EzZkxFdkR6Nnl6anhJL2RKa1cv?=
 =?utf-8?B?OUx2RzErd052S1RuejJSOStDWmNML0lWd1pBcjMvT0xDM0FxY3lydWc2SmZI?=
 =?utf-8?B?NTBUa283NnR3MktJZFlKeDNjbEFnL2F4VW91YUR4WW9rT01jWSt2WStLbFJD?=
 =?utf-8?B?NVBacVJrTXBudnlqSFhKU3BYSEViQVFQaDN2U3A3VHVhZ0Z0b1BIaDB3ZmNy?=
 =?utf-8?B?SDZFdDlmQ1ZqcVdqVnYvRkN5N21nREoreVAvOVZXaUZUcTVheGpJQWY1bEEr?=
 =?utf-8?B?ZUJJTkRZVlhwQUoreG5TcFpSSm5Semg0OTQxWDczczFpLzhScWxuYlpETEdo?=
 =?utf-8?B?cDR5b0RKeXhSNTMwVnZWeVovZ1Fnc2UwamRaN1YvakM3dzMzN2NzMTljUDBD?=
 =?utf-8?B?RTFYc1J1MGlIWDQvRXE4TnNuRm5Ia2VTSG1NbHA2THIzcHgxZ21PenFPN0pa?=
 =?utf-8?B?VEdUV3NzMS85WTVZeTZOSTVQa2l3M01HdnA4U2VqNjJoUGJiejYrMURDVE9H?=
 =?utf-8?B?dGcxQUlWZHRLaldlb2Fxa0JKR0xBUWkya2pXS214S2RsMHJiaDE3M3hnb1dQ?=
 =?utf-8?B?YlBpUHdJTStxbGsySXhKc1hwT3Z6RStUK0N6SitkNVVVanc3WkljZ0NsVlpI?=
 =?utf-8?B?bW54YkxDR2p0NS9LUCt0UFd2RzZvNkZydXFVV2pIaVJSUnNBQ3ZPT3VKWGM2?=
 =?utf-8?B?WW5NSEZSYmFQUENRbllTRnBOUS81L1RTR3ZGcmtGLythN0pOeHJXSW1GRnNF?=
 =?utf-8?B?TFk1RzBmdHdNbThIckhTUXZYM3paZUlseURnVVVzK1JoUzlVaDNOdTJadXEy?=
 =?utf-8?B?UGpPdjA3dnFreWhRRmJoNWpyOTg5a0xvM2tIYzRoQ3RYTk1IaVludW9kN3Js?=
 =?utf-8?B?S2hLTDB5SVNrbnQ5MHh3WDEyRk45MWl3d2kvaElPdHFqK2duakFabFp1S2E1?=
 =?utf-8?B?cVo5ZFZsWVJBMm9TRWRNOTF1cjU1Nm4ybXdETFBBekVlYVQ4TnFSMzFPaHRR?=
 =?utf-8?B?MTdOVlVXVlJuajhhRVRscW5uYlNLRDdZUCtwQnJpaXpMSkNhQzJzUHBnRHpZ?=
 =?utf-8?B?S3hSNFd3dC9RUDZpWWVEWitnYnd4SlRPZGx0THBrZ01weWpldG8xT2FOV1hI?=
 =?utf-8?B?ODkxdHBPcnZzMy9MaW5aUHdnUm9pR3ZmTVZnbTVrbitoUDlVSzYxanNZV0Rm?=
 =?utf-8?B?WmNRLzVLS0l1NEgvNGpkNkFFd1NqdlRVNTloUW5LUVlXNVVLV1ZYYU50Rit3?=
 =?utf-8?B?TlhKamRUdEE4VnJvcWI5WnMrV01RR2FVOTZMdjlrUFliUzZVVzZFQjVvbWpC?=
 =?utf-8?B?ZGtnTXdhSFd6SGU5ZEhGU3NTRXRVcHhmeFhrVE1IYkg4SjlicWo1UTNaZnBL?=
 =?utf-8?B?aktnN0tRR2FNM0xqZmRGWERIdGpQdndLNnk3S3pqMjFlTFlwdEdPVjcyN1VZ?=
 =?utf-8?B?eFRsbXdDUk9nbmw5ZTJNSkIrUE11Z25EQUE5VFlMZ0gzMDFyYkJwVWhJNEMy?=
 =?utf-8?B?WnRuRHBDSWhUSzZyMmcxMEo5dFRzV1ZjaTBWUUtJcHZsMkl3WHV2cVhTdEly?=
 =?utf-8?B?YTM2TlBNYlo0YUlia2pEYWlIRUdkZG8raWlvdzMvMktwVFFHaTNmMlZpNTcx?=
 =?utf-8?B?a05mOThaWm04V2djd3p4Und0V1BhVEVsdnozcHlzd1E5eXl4cDRLMVJJZkJY?=
 =?utf-8?B?VFJaKytmN3dUdWJGckxKV3ZnZlB3Nnk1SjNNUkNCTnpmUGpycUpBb29PTUpj?=
 =?utf-8?B?SWJvZ1NOcTNTS0JVaGlCNjFsU2FWcURtOHJsN3lqbG9KcTZOcDlTT1g2U0pY?=
 =?utf-8?B?Z1FwNFVXaXJFeTI3ZjNqanZGWTFXUzVERk1iMGxnZmZUMnE4VEEwbE1rNW1S?=
 =?utf-8?B?VlpkQzk5a0FhU010RlV1Sm1WblZBdUpOMWhXQkVSb1ZhTURrL0FUSWNldjBW?=
 =?utf-8?B?cXlMVEhyNFo5WElWTkcvMEpITkJqY0RIU1lHdGZOTFJ3MmZ4WFVPekU5QUdX?=
 =?utf-8?B?ZXdSVzNxMkUrVjlwMTRWTklKSzRzSVRpS1MzS0liT2JCa1pCNk5WdDdQRDEy?=
 =?utf-8?Q?Megnst8P9o6RbdmAqdO8tIw=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f9327b4b-8802-41ed-7a54-08d9f798d25d
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2022 13:23:18.8410
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LtZL8nPqtG2+vkOeRKoS9ch3DwO/h19dSvUfHR70MswmH77JvOqMSctlAPW8oRBR/MRsmPhSbWXo5Fu3CUqadQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8114

1: AMD: collect checking for bugs in a single function
2: correct fencing around CLFLUSH

Jan



From xen-devel-bounces@lists.xenproject.org Thu Feb 24 13:24:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 13:24:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278283.475470 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNE6g-0007It-Q1; Thu, 24 Feb 2022 13:24:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278283.475470; Thu, 24 Feb 2022 13:24:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNE6g-0007Im-Mf; Thu, 24 Feb 2022 13:24:30 +0000
Received: by outflank-mailman (input) for mailman id 278283;
 Thu, 24 Feb 2022 13:24:29 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=VLhp=TH=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nNE6f-0007EL-1i
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 13:24:29 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 17149470-9575-11ec-8eb8-a37418f5ba1a;
 Thu, 24 Feb 2022 14:24:27 +0100 (CET)
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur03lp2059.outbound.protection.outlook.com [104.47.10.59]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-35-W-oIVrtENIWH0bYKBIOQmA-1; Thu, 24 Feb 2022 14:24:26 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM6PR04MB4614.eurprd04.prod.outlook.com (2603:10a6:20b:18::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.14; Thu, 24 Feb
 2022 13:24:24 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.024; Thu, 24 Feb 2022
 13:24:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 17149470-9575-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645709067;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=JAvTe/e7XAafZqd6Q/V4UD2oE01PCz2b1CUIOkE7Ztg=;
	b=CIZXaIBvf0b/6189RUQfleAXfJ1eZMgYjwgdNqpAUHEX1mveQO95fkU8aULftRnUENzHVU
	/lv5tDoEJWPiUEgNFxFRSyhfjlGKCG5DnrQhdsODR9Gc1L/+MJ8iT9qvrKdSYX78ij40nT
	iSWLH6ZmXlPsP2gU8dfx9G8HDcRuoHc=
X-MC-Unique: W-oIVrtENIWH0bYKBIOQmA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Ll47Pd8EGqMCrXWDdU72cFFso9loZfAvqSQd7FnawSTMJXO+8gwhA5FbLVIg3QCAALxBEXJHNDZ9X8s+KhqmhwXWimSG4H8oz/xK25dFPLeZko6YmN1f9/O56eVAKNscPt/h/Rc9rygal9Te0pD/m4BpvXC0jd6hQwXUttBNDvacEi2ZNxMnG752gRJfjj/mzdRo7n8NtD9jn8dxKTOV1Moo4T5nf5vxGzt0muzVeemVtHFrUgqts+hrNCHiLGA9QsGluVnNk2sQHHWJUVE5xYS7CpnnMPF0cZL33hWUGWkyyGkPY6IXuIDuY5P+6RPjwuhwrj6GF/ag94l9Qp665w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=JAvTe/e7XAafZqd6Q/V4UD2oE01PCz2b1CUIOkE7Ztg=;
 b=jMFtamwTkqUz0NXPwWgg1TZ2pG5C/WvduWAJhawYzc6PH5LY1M+3/qjwWTKFwKh44ygWNNIUEBVAE8tTZSxqgJ7nUj/J467OUtEnDakBfQ+G03eEgctrxNoJAJE3ptkEv3cOcomEoQDnBvSRm2yITbcmlP4OzdvM2oAptBVnRvkEjpmnjDBch/kXsghXO9ZgZr4ToZoQkRkzUKihbnSrGZnG3s9iVLf2BV/8GJ9Hx1fOA7XJq4CUMhTGEznW2jBBGyN2Ch/BftnLPmSqxAGa8JjrttuFKNqKhykdsL47U1WzQhYolOp6Ir6tDPLXIzJWpgmgthfu32NxWyyH8o8xZQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <afbcedb8-82b8-7c92-4bb8-8ceb597a2f1f@suse.com>
Date: Thu, 24 Feb 2022 14:24:23 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: [PATCH v2 1/2] x86/AMD: collect checking for bugs in a single
 function
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <265e87fa-0f05-7953-1bce-34999119d3c4@suse.com>
In-Reply-To: <265e87fa-0f05-7953-1bce-34999119d3c4@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR04CA0077.eurprd04.prod.outlook.com
 (2603:10a6:20b:48b::13) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b5abd7a7-0a89-4b99-f7d9-08d9f798f9c1
X-MS-TrafficTypeDiagnostic: AM6PR04MB4614:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB4614F9BD2C40C000B16EECE4B33D9@AM6PR04MB4614.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	wl4vs5H3thqR12HM/bUrOlhMQpZK+3DmD0oo6PK613VMQS0GzfeaPUsdvr10RHdCLMMiZ+Z6w55fbOyJWzK7oL+vDuu62Dre4Ry1MuzHQjSaY8gETVFAXllTKnTWYb0yKVNmiNdsgCSV4f4Hee+I6dcS8JzKvG13eMb2qqqwR1Bypdzi3juPWvITArvaIbPiZ6hwYsI+CUDZsY8JaEKjftV6b96/9hH9SpzCtESq4Q3Kqi7IZ/5fREbQEjR6OZTm2Zcv8NnBKeZUxRpDQNDEiGvhca8JbwPUbZ7P85pPOCA1Hdx8Q5pb9yE7hB2Ut/YOofT0k3FxyYVhXy5kE1fYcX90slMPC5xHp0PpX327ihs1f+h8U7X3gT0GyuwPMvn+W6Qk+6RLDQDmkZCsgjfhiAvufV6JAcTURX43ol2W5ONeMORMLHsTA9uIV6NbpXMTrkgfp2GWkeWvtSfLBwaSRG2TbRAvBMVpK7nqazWBV1iD/fvPNV4eTuoVY6YeDGto1a57eH2mEWel5dV9QQYgLNVrKv+wRv93xSsXUf8fL5C5wXUUWrNKj9M5TVYanZWpnh7/lOmWn94654jPxqJGoz/NfTbVaS9DUUWv89zp655moEpQZLdihU+qscBxaRQuv+sOJmL7n4g5/uh6GAFZzR3JVik+LQ3oVxM/ciME04xb2cnfSoQHqFw1/HhFOBog0Gtih1MvcGNAu8vVIO+1USm5TGkhdq4k4Z2R/IRm4gEBwVQhzjdqY8pZTFTxAjuN
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6512007)(6506007)(4326008)(8676002)(316002)(5660300002)(8936002)(31686004)(508600001)(38100700002)(2906002)(36756003)(66556008)(66476007)(66946007)(26005)(2616005)(186003)(6486002)(31696002)(86362001)(54906003)(6916009)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TXA3RW9TY3BJV3lBUkdoOXNqZE0xOEorRlFSVHFLdFhnQlFOVFVXZUlvaGdR?=
 =?utf-8?B?YUEyMTJJMTA4Rk1sTEZvNzNWdXBzN3RVd0thOG1QZ1F5RE1reTJLUlBDQllu?=
 =?utf-8?B?RkV6bDB2M2VFMDJwNWt0Q24zaE9BWjdya3kveWQwUEJXMDFjN3FIRVZ4dnJU?=
 =?utf-8?B?dVhGSkxYT01ON2gzS0RraHdjTC8wM005dXNFQXlqQlluNjBWRUZQQzdsQUNk?=
 =?utf-8?B?cEhuSC9IRzhVRnhFQTVKbHcwbjZuNzdpVjhvK2hvdEhBc2RXM2Rreml4S0Yy?=
 =?utf-8?B?U0o2aVpEV3k2TXEvaS9qWGZIdU1JTHFUMGZNTzhkSXlJdXFsV3lpTGtZc0R5?=
 =?utf-8?B?MTBNaTA5cXNWYSs2QzR0S2hBTTl6Y242Y2ZjZ04vUjJndngxaVVpM1dEazBh?=
 =?utf-8?B?dmtGcVZKdzcxM2RqdkxFTEFSd2hMOSs4VXBiTHp0d1N3ejNGMCtKQjZaR3ZW?=
 =?utf-8?B?bHdZdVBPcy9OaWxpVzVLOXVZQm1ENG5GMmRJbDhEWFp5c3VlRFVMZVY3ZHJR?=
 =?utf-8?B?WDB0RlluR29Vd1Q5SWpxUzRSWkwyK0hEZ2xGd2FxMGRpM09IWTRMaEJqRXFR?=
 =?utf-8?B?UU5mSDZJaEVQZWxXUjRvcEc0OVFQUkVVZnVrM1NkRkQ3b1lybmpMbnczVVpL?=
 =?utf-8?B?Q0RlY1l6Q2NSSTY5dkFrSXE2c1J2VzM5azY0V2NteVRTZmxLYjUybGxrcjNq?=
 =?utf-8?B?dnVleGI2TXJDQXVieHlQbTI4YWp1QXVZQXJUT1RpYjFSM0ZpSU1rRStlNzI1?=
 =?utf-8?B?TkI2ZDZqc3Zna0U1dFF0OUJDSUx4K0N1SGxaWHB4MWtRK3ZmRDc0R0ZuOGxo?=
 =?utf-8?B?eGRqcDVQeHF4bWc0TXBudVNiRmhIWGRPTTRvMjMrcTBqQmRRRzk1cHA0MERQ?=
 =?utf-8?B?RFBZMzJCeHBJY0NGTU5FUkVDekRORHF6RVhBamJxVWx4dkhmTTRKKzdBS2s3?=
 =?utf-8?B?RFVnak1TU2M2SFI4bzVMZ0w0UkJFWFV0eDU1NW5xbldUK1FrTmpPQUVuRWNO?=
 =?utf-8?B?cHpUWDdnZ3ZVMDJ6cy9pbFRCUHZaUlRxcXc1TlpOZkFBSlRhYlpIQ09KYjFx?=
 =?utf-8?B?TXQ0WVNvREFlVXlZS2lTdEY5YkxONU94ZFFhQlV3VmFKZ2tnVUsySmZ4cHhs?=
 =?utf-8?B?U1EzYlhOKzZBZGdqRXdLamlGUHRXdlZnYkdCVTZ5aUxuRXZQN1RnV1BUQzAz?=
 =?utf-8?B?VUIvZHlreGFYa1lIZnh2OUNLUnp3bHVFV2dpWVM3anpYYlkyNjdvYlR5NlJp?=
 =?utf-8?B?L21qQ2h4cFh0RDY4Mi9TTkNYZE0vb1JPUVNiMm5wVkhYNmFid3pXOFhqZWQ1?=
 =?utf-8?B?dlA2QXl4SVFZU245aThCMmIzSjh1bUsyKytuK1NyN1pEamFWM0N0dHFMMmt1?=
 =?utf-8?B?QWozcmVLaXdMWm5uMW9vTmcwd082ajk2NkZpNzFpOWxyTXc4aU1DMm1ybnFY?=
 =?utf-8?B?dkNFaThxdTVXWFdNY0ZONGs0SGVEU295blhCTU10cU42cTFiaFBsZDlNREJ2?=
 =?utf-8?B?VW4rc3k5Z2RxVjB4dlN0bHVBR1pTVkF3cU4xbEdSdERqQVNOZzRNL1I1R2Z0?=
 =?utf-8?B?cDZDaVg2MHZUSGpVV2hLd0dheVA1RFlUYlhKSjBxR0JOZWdDOFY3c1Ivd3Mz?=
 =?utf-8?B?L0hISE5qLy84QlloQ2g3VWRsOVJhUktDaEJtY3dJMGhRaW1NNk10SDc5a0pw?=
 =?utf-8?B?RXdEMVdtd0J2QmROU1pTTmxQNTRUTjVlWGFKUmlPWlE5RkZsZGdGZHFmdjM0?=
 =?utf-8?B?MVYyRkc5cEFvSEFiNDFNOEZiblREL1hnYm9hbWsxVktseVB4eVEzM1lQZmhi?=
 =?utf-8?B?d3NrTHdYcDNrSExSSFZQT1k0YjRhVi80SWp1RjFTbE5LYU1lUnQwSVVxUTNu?=
 =?utf-8?B?cWhJWW9uaUVKYWtPeEM3M211UmtlYi9JQWRWUDF2U2Nxem5RcmxrV25iZ0Na?=
 =?utf-8?B?ajZGZlZIbVVMY3VQRUtPUS9ZTEpCbjBsblc0QlNKTHdzMGljdWdIVC8ra3l3?=
 =?utf-8?B?WStGaTY2RmVkL1lsV09SZFNxQkcrWTlhanluQTB2d01PSEZrcE9IekhydUhW?=
 =?utf-8?B?U0w2aWhKMFV4NzA4b1JEUVRTd1MxWkhZOXNFV1dsSTVqOWYydGhkdm1abXg4?=
 =?utf-8?B?bTQ3blZxVnpZdElHam5qM0FIWE9VTnhmMlQ4emE0RmJJYkFMT3ZiM2xuQzFH?=
 =?utf-8?Q?/v3g//PPHcoYcDzS2WfXWeI=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b5abd7a7-0a89-4b99-f7d9-08d9f798f9c1
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2022 13:24:24.8057
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3NSBnCVwPYiy/Xom5DYK+QWd6cEVIPwU3j76qPv09dUVErX+ROX5Bf6aD6BHgDD9rsnAlRDjRzRlzVO6ScQq9g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4614

Besides keeping things centralized and reducing (by folding) a few
conditionals, this also allows this helper to be put in .init.text.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
v2: New.

--- a/xen/arch/x86/cpu/amd.c
+++ b/xen/arch/x86/cpu/amd.c
@@ -744,6 +744,23 @@ void __init detect_zen2_null_seg_behavio
 
 }
 
+static void __init noinline detect_bugs(const struct cpuinfo_x86 *c)
+{
+	/*
+	 * Older AMD CPUs don't save/load FOP/FIP/FDP unless an FPU exception
+	 * is pending.  Xen works around this at (F)XRSTOR time.
+	 */
+	if (!cpu_has(c, X86_FEATURE_RSTR_FP_ERR_PTRS))
+		setup_force_cpu_cap(X86_BUG_FPU_PTRS);
+
+	/*
+	 * AMD CPUs before Zen2 don't clear segment bases/limits when loading
+	 * a NULL selector.
+	 */
+	if (!cpu_has_nscb)
+		setup_force_cpu_cap(X86_BUG_NULL_SEG);
+}
+
 static void cf_check init_amd(struct cpuinfo_x86 *c)
 {
 	u32 l, h;
@@ -781,13 +805,6 @@ static void init_amd(struct cpuinfo_x86
 			wrmsr_amd_safe(0xc001100d, l, h & ~1);
 	}
 
-	/*
-	 * Older AMD CPUs don't save/load FOP/FIP/FDP unless an FPU exception
-	 * is pending.  Xen works around this at (F)XRSTOR time.
-	 */
-	if (c == &boot_cpu_data && !cpu_has(c, X86_FEATURE_RSTR_FP_ERR_PTRS))
-		setup_force_cpu_cap(X86_BUG_FPU_PTRS);
-
 	if (c->x86 == 0x0f || c->x86 == 0x11)
 		/* Always dispatch serialising on this hardare. */
 		__set_bit(X86_FEATURE_LFENCE_DISPATCH, c->x86_capability);
@@ -796,17 +813,13 @@ static void init_amd(struct cpuinfo_x86
 
 	amd_init_ssbd(c);
 
-	/* Probe for NSCB on Zen2 CPUs when not virtualised */
-	if (!cpu_has_hypervisor && !cpu_has_nscb && c == &boot_cpu_data &&
-	    c->x86 == 0x17)
-		detect_zen2_null_seg_behaviour();
+	if (c == &boot_cpu_data) {
+		/* Probe for NSCB on Zen2 CPUs when not virtualised */
+		if (!cpu_has_hypervisor && !cpu_has_nscb && c->x86 == 0x17)
+			detect_zen2_null_seg_behaviour();
 
-	/*
-	 * AMD CPUs before Zen2 don't clear segment bases/limits when loading
-	 * a NULL selector.
-	 */
-	if (c == &boot_cpu_data && !cpu_has_nscb)
-		setup_force_cpu_cap(X86_BUG_NULL_SEG);
+		detect_bugs(c);
+	}
 
 	/* MFENCE stops RDTSC speculation */
 	if (!cpu_has_lfence_dispatch)



From xen-devel-bounces@lists.xenproject.org Thu Feb 24 13:25:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 13:25:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278291.475481 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNE7G-0007rR-2Z; Thu, 24 Feb 2022 13:25:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278291.475481; Thu, 24 Feb 2022 13:25:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNE7F-0007rK-VX; Thu, 24 Feb 2022 13:25:05 +0000
Received: by outflank-mailman (input) for mailman id 278291;
 Thu, 24 Feb 2022 13:25:04 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=VLhp=TH=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nNE7D-0007q3-UC
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 13:25:04 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2c3d5eaa-9575-11ec-8539-5f4723681683;
 Thu, 24 Feb 2022 14:25:03 +0100 (CET)
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2053.outbound.protection.outlook.com [104.47.1.53]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-7-gj4dPI3HOky1O1Tkms3XBQ-1; Thu, 24 Feb 2022 14:25:01 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM0PR04MB5971.eurprd04.prod.outlook.com (2603:10a6:208:114::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.23; Thu, 24 Feb
 2022 13:25:00 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.024; Thu, 24 Feb 2022
 13:25:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2c3d5eaa-9575-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645709102;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=hJj7Nd1zQ5C3uR5AotGLWuOQOjAHBSXWP97Y2JLCbGE=;
	b=aAQfIFptKYIKqGc9PWkCFUJrATvk1gnJ29+7deT9cIYDakXvANus0pRgKTg8iOs4UhysZ1
	EsMfpYtsIIM/BG6P9hdxvX/Zx0mIHcTE468rZ5I7D4ZudFs/E01nuKNcwaVgz8x72v1pa0
	Gs0RWLX1C60bOkYFQm5bVJoLJs3HQWg=
X-MC-Unique: gj4dPI3HOky1O1Tkms3XBQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=BCOgu/EhVO5gB8Z0g8wfEuDIikrY2SN+Yt3tfCwfxziXFKa2RAeeLHoj2FtnDKkvp7mCc0JkcCGNIUMA62PwARkoq8Pc8XzOEf9nyCgLLVBun7EcgFPgirvtqUC3VvSnQyTmoCMQa/10lOkDAW1UZ3O2Uw1QnrE3K3nD+s2OEXI2AiJzDo/VN3Hw3jf62ZBLM0y+duU+Hm1nI4KMAlZhuLwRoFD1ahKkm3DhrYSZagUsZdi8eY50VDQoK2cKcxjLSu4xyRvivbgw1Tj5XovD9AyelMNOKR0sBKRDvK2A/e5YDHCBwrb8Ik/kiDuDsM/xRgSUf0GXnqdC8QxRDPIh2A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=hJj7Nd1zQ5C3uR5AotGLWuOQOjAHBSXWP97Y2JLCbGE=;
 b=BadaGglrufTEw1s7lHHbwtwPce1gtObUFokR8nAC/P1du50v3FsuN+RfjtjfhyoLRJH7BSXcMYQ/QZxpgmoChXa/S80omn9GQ9PU4QBX/NdFr9JtQ3b7ubyxsEEzzFu1dVtUopd7N8FzFjXGtRQ3vXOc6eF4NSOdYk6oVQBGgkgIo1vxsiYlDQ8nH9OBUVLIBtX7albbmhA/NNkhcyeB+xjxgadDeqk0Ft2zLboHDG1Mi1yIx26kO7IO2oH6HntNkdrXUsyR5TY9CdjacShNYm172Rvtv51aGm2EW5lwLGi0u4gWASmtGH3qwG6jFR5wTQbPCwz/TCtlQXTXLi/RrA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <58f9bf8a-a086-4c23-75d6-f490df2e0718@suse.com>
Date: Thu, 24 Feb 2022 14:24:59 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: [PATCH v2 2/2] x86: correct fencing around CLFLUSH
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <265e87fa-0f05-7953-1bce-34999119d3c4@suse.com>
In-Reply-To: <265e87fa-0f05-7953-1bce-34999119d3c4@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR04CA0077.eurprd04.prod.outlook.com
 (2603:10a6:20b:48b::13) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a530dd74-bf7a-48e7-8192-08d9f7990eea
X-MS-TrafficTypeDiagnostic: AM0PR04MB5971:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB5971B101E10F0095F84794DCB33D9@AM0PR04MB5971.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	AFHENVLP144M/g5csPuqyN0DyG93UWW9QiPWDxTWiqJfCCwiXH/lzsWJSJwIwfnMIFMgtUtJptUvCCLXi4wg1nnfJG4kNy+cIEb0s5+7RVXEVsU9eJ5bWc/8xbBy2vP/bX8Xe+BnPgA2SwB/td31OjUsyaeEUOmWtsohgFq7BjZ6LCDk/rRxacbxk86Wi4tmSG5GMHBRd7dOpqBF3tlihOZnQP5u8H1F+V1opkfOLdcDEMw8dLKv1NEO87NjkzqkeDUmrsbYxuCLWEMyPXj+UOyTfsjWsFjulZXMXn5hxtGnP9NjXJA7BvBhEw8ZjH0QK5ifpe/iaGU2hROuDKiMchfjlnFwnPMh6nS76hdYtut2jS/XzLvNuoeUx/ww8ijsDBkIG+o7leKFwrXhbQ/FM/ZYzv4eTQE78gO9zGuH3+an8mopOq2V5AbOZUPmp6A77faNwdkdRiwQlgcXEin69bpf8vyWO2CnXGFwK9KI7MDvIOqyWj5J0OXlbeeACoCgqot6wLvtiWaaNdtIrCr5xuYk7v4WJ6PDOarJEssl0Q/NBef+XCZ5U5va53yrjoWP6p+KRy+KpvcS/N6wjXfAo4MwVxiG8/0bcYB1agRV35FPzY7v0KelZKYQ5gQUENfqrj0hRe/k931oNiFe+j7GMEqoaPiG8mMDkzQYnkqSKqwndIH1UFIsvRxz505LJyWnHuMCWEp+fsKFo1WkModqhNAm0NWU67+D1q5RNkJbbt4=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(54906003)(31686004)(86362001)(508600001)(36756003)(6506007)(31696002)(6512007)(38100700002)(8676002)(6916009)(186003)(2906002)(5660300002)(66476007)(316002)(8936002)(26005)(4326008)(2616005)(6486002)(83380400001)(66946007)(66556008)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?U1ZBZW5BbVRKNldNdTY2bnFaeUZ4cXJMczlBYnByK2F3THFTS3BoRTlWaTRa?=
 =?utf-8?B?UGM2ZmlaNnVISytJZUJOUFdaQmlMbU42RjIwM0xFeDVIdHYrcTFOR3RCdGNt?=
 =?utf-8?B?TWpOb3BmM3liREIzLy9zanlxa0lZY3g0Q0lxUHlxZEx4MU9Ha0lkbDJ5eTk3?=
 =?utf-8?B?U2FrRklwdjcyU3F4S3U1WDhwcEEzTWl4VXBnOHNQSk8vdEZsa2VrZTZSQmkx?=
 =?utf-8?B?RHBGK0h1RDZQRFNZVmUraXdqWlBmaFVtL0VUcXJDVXljVzNJQ3BORVZydUp1?=
 =?utf-8?B?WCtUay84MUhhMTBTRUxVdU15Y3RyM1g3aWp6VUpCMys0ZWozQys0Rks3QjFB?=
 =?utf-8?B?blBLRWxYb0FDVHhpd0dYVkJyZzd2Rk5BdUE5aFQrd1BxaU81b1J2aTU5andD?=
 =?utf-8?B?ZVBIc2hXZExZdkVrQUNRNWhjTTlIcGtxSzhpSUFNZFltT3Nvd0M1bjE3eVhZ?=
 =?utf-8?B?SzBJOFRGSGlHYWVRT0s0L0RLS0RnQlF1TmNWY0E1UWZ4TG1oWWFUOHN0UEZV?=
 =?utf-8?B?eWNZakk1cTRvVkltaGhDVkNFSkRncVdHbFNRVkJidUlDVmppenRKZXh0NWds?=
 =?utf-8?B?V3gzSjFHYUYyMTJJcEp5anEzSFZEVkppR2hScUg1RzEzTjVHcm1qVnBOYitt?=
 =?utf-8?B?OGx0eE03NFVqNXc4Tkl2QndmdHluQUwrOWF5ZnZHcWpMRDdGY0s2VWFwWjlx?=
 =?utf-8?B?RXNFamYyTmYzQVJPWmtqb09uanZ0SDI2ZlBzUmR3RUdRUHAyOEoyUHdGV3h1?=
 =?utf-8?B?NVI5NHZOaFZxR3h4OTVYS1RlM2FCY2VBNDZvUDAyeWNRVDZLeWlVdjh0ejQ4?=
 =?utf-8?B?VHdPODVJQzlzMEVLRzVQeEpSKzV2VktTY3kybzlrQU9EYnMyUG56NGNLQUk3?=
 =?utf-8?B?MnZyd3dIQVAyV0l3ejE3VUNkUUY3Rm8rVVRLNnYxaURsdkxhcUtZQjNHLzNu?=
 =?utf-8?B?WUxvRnMvN045eG0wS2ZMMGJRRTN3NExSaGZwVFRhV1dxQ3UzdHJOaVdDODZO?=
 =?utf-8?B?WGlEUFBLU2Fab3NTeEQvYkdmQzNzaXptNGMyK21ETEpVaHFuL2ZiMVUxOE9G?=
 =?utf-8?B?RUFaS0Q0YlBWSm5YYy9XV3FtcTBKNFpPYTY2UTdVOUlENWFDTmJXVnN0c2ky?=
 =?utf-8?B?M1UzT2xtRERlcVBQeWZYTFI3cEhSa2ZTZnRtQ1U3cE5nWWVrSzBuUDAvdk8y?=
 =?utf-8?B?T3Z5Ykw0Z2kyRzVONUlISHdBck9jb3VHRU5vZ2dCb0p5NnErZnk1RjdZQmJp?=
 =?utf-8?B?MHg5R2JtVGtIOStSeW91bVJoanpmL3VSRGNuV3N1Lyt2Sml2dzdtck9YUnM4?=
 =?utf-8?B?R0lPajk5NTRmb2pQdUpNQjliSDFaeFVUYU9KZitYNDJQemdQTDVEcitPTTdm?=
 =?utf-8?B?a1hmd0ZYMUtzV3UrREFvQ2ZaWkZvOVJmcGNyNFBOY3daMlowWGh2NGQyWTRt?=
 =?utf-8?B?VzJHazh2NnViZEtiM3A3SUVuTjZteGVMZXdhb2QvOEVHZGI3WXljTkdwKzdE?=
 =?utf-8?B?blZNVTYrZTFOVUdXclpiMU1WaTJldVhHWjFBV1U3cnB0YlZBQkhWbGtUdzlC?=
 =?utf-8?B?V2VtcW4rd3Z4blpURVBGOWRYUG5VMW02VjA1by9xSm0xdklKZm8vU0lEZVd4?=
 =?utf-8?B?emRzVlA2bXd5Y2JuSHpxaUZ3Z2dRY1A0MktObk5GMnkzUDFBMXFHS0J1UUJY?=
 =?utf-8?B?aUJYeFRVMHlONHkrbG9IZ0NhMHllc1JJYzB1SVYyMmJKY0xIZDF4OXg3S3RE?=
 =?utf-8?B?Tk8xL3VlNFNDaUVFNjVPUUx3cllGdDhvYWUyNHF0bWFvK2cxZ3B0U3BYcVFw?=
 =?utf-8?B?c0sxTlNvdGlUZ0xLQ2VVWWRVRFpZY0JRRGt0RmtmWC9BTHdMREIvWlgyQXNK?=
 =?utf-8?B?VndUMiswWmpPWFNWVXU4a2dhVHM4enE2c2FLbTFGek9wVnY4MnhRZU5ucSs4?=
 =?utf-8?B?RmpVZUh1WURtMHlRbyt6QXUrUTV1MThLd3BISURsUXF6MzRTckhNM0pKM01O?=
 =?utf-8?B?S1duQWw5UXNzYXVqemVCYzI2SGZMek4vUUdPVDdrWlpORDFVTnc4Ti9iVTMx?=
 =?utf-8?B?REs3YjJqbW5mYmcvRldJVkhWZDVOT2huN2V0dUlWRlgvTVhyV21ud1lhSEsw?=
 =?utf-8?B?Nmk1QnJFVXJxSy9Oa3REN0IzRjM1blVpQ1Eyc2dwWmsvbkxTb3dpd0VScitI?=
 =?utf-8?Q?B/uegxezQzfpEBKHqcNZt+c=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a530dd74-bf7a-48e7-8192-08d9f7990eea
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2022 13:25:00.3348
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: H+5trbyvSpiWi7KOnqNv7WgLR6c1r78D3tzFDr8uZO14VligxG+lgyQuJiBmmZMZXHuLX3UhFXPf9KMl15/mkQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5971

As noted in the context of 3330013e6739 ("VT-d / x86: re-arrange cache
syncing"): While cache_writeback() has the SFENCE on the correct side of
CLFLUSHOPT, flush_area_local() doesn't. While I can't prove it due to
lacking a copy of the old SDM version, I can only assume this placement
was a result of what had been described there originally. In any event
recent versions of the SDM hve been telling us otherwise.

For AMD the situation is more complex: MFENCE is needed ahead and/or
after CLFLUSH when the CPU doesn't also support CLFLUSHOPT. (It's "and"
in the flush_area_local() case, as we cannot know what the caller's
needs are. For cache_writeback() fencing ahead of the flush is
sufficient.)

Fixes: 623c720fc8da3 ("x86: use CLFLUSHOPT when available")
Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
TBD: I'd be okay with not touching cache_writeback(), for only being
     used by VT-d right now.
---
v2: Mark AMD behavior as a bug rather than a feature. Retain quotes.

--- a/xen/arch/x86/cpu/amd.c
+++ b/xen/arch/x86/cpu/amd.c
@@ -761,6 +761,13 @@ static void __init noinline detect_bugs(
 	 */
 	if (!cpu_has_nscb)
 		setup_force_cpu_cap(X86_BUG_NULL_SEG);
+
+	/*
+	 * AMD CPUs not supporting CLFLUSHOPT require MFENCE to serialize
+	 * CLFLUSH against other memory accesses.
+	 */
+	if (!cpu_has_clflushopt)
+		setup_force_cpu_cap(X86_BUG_CLFLUSH_MFENCE);
 }
 
 static void init_amd(struct cpuinfo_x86 *c)
--- a/xen/arch/x86/flushtlb.c
+++ b/xen/arch/x86/flushtlb.c
@@ -245,12 +245,15 @@ unsigned int flush_area_local(const void
              c->x86_clflush_size && c->x86_cache_size && sz &&
              ((sz >> 10) < c->x86_cache_size) )
         {
-            alternative("", "sfence", X86_FEATURE_CLFLUSHOPT);
+            alternative("", "mfence", X86_BUG_CLFLUSH_MFENCE);
             for ( i = 0; i < sz; i += c->x86_clflush_size )
                 alternative_input("ds; clflush %0",
                                   "data16 clflush %0",      /* clflushopt */
                                   X86_FEATURE_CLFLUSHOPT,
                                   "m" (((const char *)va)[i]));
+            alternative_2("",
+                          "sfence", X86_FEATURE_CLFLUSHOPT,
+                          "mfence", X86_BUG_CLFLUSH_MFENCE);
             flags &= ~FLUSH_CACHE;
         }
         else
@@ -274,6 +277,8 @@ void cache_writeback(const void *addr, u
     unsigned int clflush_size = current_cpu_data.x86_clflush_size ?: 16;
     const void *end = addr + size;
 
+    alternative("", "mfence", X86_BUG_CLFLUSH_MFENCE);
+
     addr -= (unsigned long)addr & (clflush_size - 1);
     for ( ; addr < end; addr += clflush_size )
     {
--- a/xen/arch/x86/include/asm/cpufeatures.h
+++ b/xen/arch/x86/include/asm/cpufeatures.h
@@ -47,6 +47,7 @@ XEN_CPUFEATURE(RET_SIMPLE,        X86_SY
 
 #define X86_BUG_FPU_PTRS          X86_BUG( 0) /* (F)X{SAVE,RSTOR} doesn't save/restore FOP/FIP/FDP. */
 #define X86_BUG_NULL_SEG          X86_BUG( 1) /* NULL-ing a selector preserves the base and limit. */
+#define X86_BUG_CLFLUSH_MFENCE    X86_BUG( 2) /* MFENCE needed to serialize CLFLUSH */
 
 /* Total number of capability words, inc synth and bug words. */
 #define NCAPINTS (FSCAPINTS + X86_NR_SYNTH + X86_NR_BUG) /* N 32-bit words worth of info */



From xen-devel-bounces@lists.xenproject.org Thu Feb 24 14:09:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 14:09:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278303.475491 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNEna-0003uk-Ik; Thu, 24 Feb 2022 14:08:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278303.475491; Thu, 24 Feb 2022 14:08:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNEna-0003ud-Fi; Thu, 24 Feb 2022 14:08:50 +0000
Received: by outflank-mailman (input) for mailman id 278303;
 Thu, 24 Feb 2022 14:08:49 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=VLhp=TH=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nNEnZ-0003uQ-8p
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 14:08:49 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4866d23d-957b-11ec-8eb8-a37418f5ba1a;
 Thu, 24 Feb 2022 15:08:47 +0100 (CET)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2105.outbound.protection.outlook.com [104.47.18.105]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-36-OQOdiJDrMB2PcIafJHdfvQ-1; Thu, 24 Feb 2022 15:08:45 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AS8PR04MB7557.eurprd04.prod.outlook.com (2603:10a6:20b:294::5)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.24; Thu, 24 Feb
 2022 14:08:44 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.024; Thu, 24 Feb 2022
 14:08:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4866d23d-957b-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645711726;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=twAYqpfIAWzpQBv+rZQzOTUhOvvrZrIE/diNjvuKhno=;
	b=Uxdrr31i5FBXXANoo+Nbmgz+njdjDSlhK+0jD8QNFY20K7X88MeFNxPwY/ZjEyPeX4HOZT
	AyD88m32qSuJhqOf/PI3wSoQrzbVL/QPSdmBB356VeRACKknZF0ZmMFELrP3CMY/yP6bpo
	jwoiNFaMSTwuHEXFA33ho5bKaBAxw+c=
X-MC-Unique: OQOdiJDrMB2PcIafJHdfvQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Ou7y4gg5SFQctGjGmWJ6S52jla420mZXDRuo/FrhXCXLzOELgjKNz+K6KsaOUKBclo7fPNthnVV+3Bn89d6d9KBaa1QkbCL6loJ0XXD0lGpu7FynnLB8r1o/UqmYIZdueG41a70paPgaUwKY41Th+tx93L/wVQz0aFMB5L9sTx9xjt3y+NTAAEya4WIlAfFX3pK6xBX8J8qYCCeAwjhYsLuGdkpuvRsfTaXd0LOzKpWAJBRgdKAifu4rCxov7SyAP3FKKuByL0w+H5tFn60NEtrxCit/1neL/+FxrIWpZ6scL61aR15zK0YbGf7alAEA7qcDmcv7G1pZSKpHfdreYA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=twAYqpfIAWzpQBv+rZQzOTUhOvvrZrIE/diNjvuKhno=;
 b=cHrkvCcNM/+ZH7T0D4u+EH9/cSfIHJuFXg0OCRg6bPiggRitRzs+B8mKCp1Fge5l6zoWcrpAMWc20iC/Ai6OZwtLlxa95DEliO9x1JWJkqzIKgWMReXKvFixgIejUeB0TJAInzbRGAFJoAAopvz/DSAtP1waDM8ug+gO7xhLRJs3zb2wtNOU/rVLssMhlk4YC84npuKIupzbJrgIdyO1AtaS5ftNnk7/RyNTk3iLsk01d6sywe4s5CIbrCLCY/7p+F/nGZa258djNj8bhn2lyOg2AHR+Yp/k+sjdSHEmiLPMRrlauy74xc5rOiRDcbT66RI+b2JiaysDDGkJwaGQ9Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <0a31970c-c0f8-c995-ce04-67523a4a830a@suse.com>
Date: Thu, 24 Feb 2022 15:08:41 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v3 1/2] xen+tools: Report Interrupt Controller
 Virtualization capabilities on x86
Content-Language: en-US
To: Jane Malalane <jane.malalane@citrix.com>
Cc: Wei Liu <wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>,
 Juergen Gross <jgross@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Jun Nakajima <jun.nakajima@intel.com>, Kevin Tian <kevin.tian@intel.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20220218172943.12182-1-jane.malalane@citrix.com>
 <20220218172943.12182-2-jane.malalane@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220218172943.12182-2-jane.malalane@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR08CA0021.eurprd08.prod.outlook.com
 (2603:10a6:20b:b2::33) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 66a92330-d722-45c1-de7c-08d9f79f2af4
X-MS-TrafficTypeDiagnostic: AS8PR04MB7557:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<AS8PR04MB755798A5D145B8936323F094B33D9@AS8PR04MB7557.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	scZtbggFA9uIIDXqmSyzHYXoBWtItiETmWFxOEmo59+IKU/rlZzeAu/Uan+dBvuPXYmIPtGFZCZG7f3a/GyBV0pvJFS51IOpp4tJZlk4xxI6GpaquYx5R/8O5WXaZXVFwdHFtENLjzkcSynyOQklDbzy2J68ivJWNvnUSsrgamCJSILjPsgZq4k/KOL7fFeN+OqKNpngcLVNiLYOeuq2K0DtuE4dYO8ygEvbTiooypfRc5nGRlmVL2eFTNbJjx5nO7F0YJGXCCQBor6W2WYuNUoy+NsB+y1a2e9mpoOnx8lCnrEtgbMR0XbrzhBTWeIAoIYkOfYMe587To0c7UU/ndwmd1XX4t7SVXE8SjgIj3rtwagdBBRALvzZnBWNZ+lHyLiMysxG6ydFhMtETjeg95zuFd1qCpQbxgzdgnxWHzIcGDqnnsJew5smDqH3tPx8SQYujySkZai0HIMlNn6a9h7fqaZdUkzdI8t+nXQp4pYVkbEvHcFaubwVDdIoOa+QerkhIJuu1cHpoBz5RfW768dOtA/Ba4vFfOGt/kF98q94rb3t8o4papdRiS3u1GhHYQbqGMqvTLzAgA0oP+GTMHRBYx3oLPOlYhsYrgsJYlIcNqPk5utIsv2hTzeaQODrBMHSFdH/AMOY10T1UNTy3YYLtBQKYXTNvPwq5HIC8acnLOtkMb7YJSfw6dHGh5tW+G18TYH1R6Q5K0dIH/9ywTSEPxEi8B7ygwZ9xutARUE=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6512007)(6486002)(508600001)(186003)(6916009)(6506007)(53546011)(6666004)(36756003)(316002)(26005)(54906003)(8676002)(7416002)(66946007)(2616005)(38100700002)(66476007)(66556008)(5660300002)(31696002)(31686004)(4326008)(86362001)(2906002)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?cHYwMUdtSlFod2N6RHJlajc0eUJTVCtsVksxNkg3SzVtNEZGckEvWlYvdDdU?=
 =?utf-8?B?WWpvai9FVU9mbm5DdGY1eEp5VU44NHJXc2VrUkdlSks2TzhQSmpVWDE0dStV?=
 =?utf-8?B?cnBoNE11R3VNd1JTVlE0aUpmWDlETUcxanRPVzhJcTd1V2d3M2FKRGphQkNu?=
 =?utf-8?B?emEzb0RselpHRzhub1phY2huQjJVdGZDekZFTTlPNUwva3J0a2xsODFPUFZ1?=
 =?utf-8?B?SWlnbW1semFjcThpZ2NMNzBJUmRjenlFcWp0WC9rVXpVdU4vNlVsMjBnam9z?=
 =?utf-8?B?c0JYNFpXY1hUNlBUZEw5Y2ZESEtpOTBSOHFaRkdJQUtkTkN0WkFiUXRvVmpa?=
 =?utf-8?B?eTdNcHZwaDNuM1gwUENraTVmMHpaZGJmY0hRVk9Qa0NycmVYWjVZdUx3MEVV?=
 =?utf-8?B?T3dRRmMxWDNwbk5MWTFmQnFiL3l3V3BNeDZuMk5uZ2o0aWUrcHk2TVRjTFgr?=
 =?utf-8?B?M0xNSjU4N2xPb0RqbVkwZDdCVDBzT1hYU2ZXVVN0NDJQM3V0U3ljNTVmclhZ?=
 =?utf-8?B?YTI4ZDhldlBKRDlVS0prUXpPYWljVVE0ZkhXOWd4TnJWVHg4ZkdnNXRnM0Zy?=
 =?utf-8?B?MUdPcXpaL2pqbC9hRVlTOVRZdDRwZFRYN29wUCttbzliQmUrSDBVRjZWTFRX?=
 =?utf-8?B?ZTd0YW5NM0w4dTdoemFHVDlKN2gxdi9Fb3NCRWU0aWVkSXFtQWY3ZVdjSmZO?=
 =?utf-8?B?YzlvdnhRKy9LdjFJbmJta09NSENNUi9nalgrRUtCbDFUeEVwWE1GeDhTNnAy?=
 =?utf-8?B?cGtrWWNRMWdLU0lxbDUrNzJHVVJTT25Hckx3R1VJRS84QnZROGxmUFloWllJ?=
 =?utf-8?B?MWdaaG1JTzlINlZJRk5CTEtPSFhDTmdOYzU4VW45dldSTWhRZmlpQ3dpaVlq?=
 =?utf-8?B?RFRFTnpDdkRPT2RHaTRXb29VUXFaOGx1WjhDTkUySG9UYjFJZFlueGhDYzNx?=
 =?utf-8?B?cWc0NG5SNTQ0ME9nUUp6MCtJZFFtaS9iOVNOUEFzNTQ2MDNMSjZCcVBTQ0o1?=
 =?utf-8?B?RFF4L2hGcEt0M0dEbEl4WG9mUU5vVDVpS25UVDBZWlVVODd5a012Q09QK2VL?=
 =?utf-8?B?ZzVDS2tlcDBrcnVlaHhYajVOWXM4dmhJWHRwOW5pWW0rT05WSy9aa0NLRS9h?=
 =?utf-8?B?MEt6dlhlSDFyRnhTdXhWNEd3QkpsSHdtSjNWVkVhUE00M3lQa25YbDZrdHEr?=
 =?utf-8?B?T0FCbmVJdTkwRlVzRkJDU2NScS95WjNscXc5aUpjNmFUVW5RaHZjNWRsNnVD?=
 =?utf-8?B?QmZVajdBVVRiM21CUExwcG5ZSHNoazhHNEt6ZzBoZVl3ckkrNEpOa1dOVUYx?=
 =?utf-8?B?azdNVG9NVlNtSitzYXNsMk5HRDhaZUN2WTRaZmZqdnF2ekYvZXl6NS9UWHdk?=
 =?utf-8?B?a1Q0WVlnR1N1ZkJjMFlPbzUvcE85cDBMbmNVUFJ6MGQxTHcyMHNjWmhpeXQw?=
 =?utf-8?B?OEUvN2NPSHpnMDVmYS9PV0JDclBRSUhJdGJ2c3QrK3NqSkhrNCt1VUc2KzI3?=
 =?utf-8?B?QUc3eHBCUUt0enFIVWNnWWtaMXpEdDRLeGlabTQ2Y2gwVXRzNEplQ3BjTjlk?=
 =?utf-8?B?eFBZZ3MyMjdBaHhHTVdwcnIrN3Y1TlZvUlZXeUYvKzJKZDVjQ0hPTTIxM1RL?=
 =?utf-8?B?VlhIRjBvdHNWSVdxTXNYQVdHbG95YWg3cllkTXpXYzBmOG96YkVoNU5zQXFx?=
 =?utf-8?B?UisvYTgzS2dDTjdWNFcrZGtqaHp6ajZyc0JGUWd4RVRQN2hoYlo2MDdNNWhB?=
 =?utf-8?B?WkdaNk1sUUVoN1V3Y203TWVCNy9JWmdmVTNLS2lJMnBGdnlQMDhiNXpOQmVn?=
 =?utf-8?B?c3lHQTRXZE1zaG1oTlNTb1g1MUZtWC9ZVmpFVDczYUJEd0cxTmptMXFLaVhM?=
 =?utf-8?B?ZTJodU1uTDUyTjJuT1lkdURpcUptd3ZWRXNCQktscXM3ekRJbzliV25ELzdI?=
 =?utf-8?B?SXNYQmdITCs3VjUzbkVTWUdaaGE0Nm1Ob3RyQkk1NkpjUEJxRjlzSEMrTUww?=
 =?utf-8?B?bFZoUUQ5dThLd0c4eEZ2VVRSMTFheFlqYXBLcXZ1WDBvOU5yZDQ3RkVxVkdK?=
 =?utf-8?B?R1o5cXpEcXhiaGJrTGZtWFNNa0dVZWczQ3NkQmYyK2JyS1V6S2xEa1dweThy?=
 =?utf-8?B?VmpxaDJyc3JueDVrVWVQR1hhdTVER3l4ZGgrREMrVXBvVk1Tenh1MHJuNW9M?=
 =?utf-8?Q?SeZf+5ggFG3IqYnw3E5GwjQ=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 66a92330-d722-45c1-de7c-08d9f79f2af4
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2022 14:08:44.4530
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2wLWyIRXncu3ChdX2b4vkDr1ksXYXlaQ1YQwf7C0J0M1zDjfxEr+T33yHZKLETGoViP7E9KugwPDQz09XJpsGA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7557

On 18.02.2022 18:29, Jane Malalane wrote:
> Add XEN_SYSCTL_PHYSCAP_ARCH_ASSISTED_xapic and
> XEN_SYSCTL_PHYSCAP_ARCH_ASSISTED_x2apic to report accelerated xapic
> and x2apic, on x86 hardware.
> No such features are currently implemented on AMD hardware.
> 
> For that purpose, also add an arch-specific "capabilities" parameter
> to struct xen_sysctl_physinfo.
> 
> Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Signed-off-by: Jane Malalane <jane.malalane@citrix.com>
> ---
> v3:
>  * Define XEN_SYSCTL_PHYSCAP_ARCH_MAX for ABI checking and actually
>    set arch_capbilities, via a call to c_bitmap_to_ocaml_list()
>  * Have assisted_x2apic_available only depend on
>    cpu_has_vmx_virtualize_x2apic_mode

I understand this was the result from previous discussion, but this
needs justifying in the description. Not the least because it differs
from when XEN_HVM_CPUID_X2APIC_VIRT would be set as well as from what
vmx_vlapic_msr_changed() does. The difference between those two is
probably intended (judging from a comment there), but the further
difference to what you add isn't obvious.

Which raises another thought: If that hypervisor leaf was part of the
HVM feature set, the tool stack could be able to obtain the wanted
information without altering sysctl (assuming the conditions to set
the respective bits were the same). And I would view it as generally
reasonable for there to be a way for tool stacks to know what
hypervisor leaves guests are going to get to see (at the maximum and
by default).

> --- a/xen/include/public/sysctl.h
> +++ b/xen/include/public/sysctl.h
> @@ -35,7 +35,7 @@
>  #include "domctl.h"
>  #include "physdev.h"
>  
> -#define XEN_SYSCTL_INTERFACE_VERSION 0x00000014
> +#define XEN_SYSCTL_INTERFACE_VERSION 0x00000015
>  
>  /*
>   * Read console content from Xen buffer ring.
> @@ -111,6 +111,13 @@ struct xen_sysctl_tbuf_op {
>  /* Max XEN_SYSCTL_PHYSCAP_* constant.  Used for ABI checking. */
>  #define XEN_SYSCTL_PHYSCAP_MAX XEN_SYSCTL_PHYSCAP_gnttab_v2
>  
> +/* The platform supports x{2}apic hardware assisted emulation. */
> +#define XEN_SYSCTL_PHYSCAP_X86_ASSISTED_XAPIC  (1u << 0)
> +#define XEN_SYSCTL_PHYSCAP_X86_ASSISTED_X2APIC (1u << 1)
> +
> +/* Max XEN_SYSCTL_PHYSCAP_X86{ARM}__* constant. Used for ABI checking. */
> +#define XEN_SYSCTL_PHYSCAP_ARCH_MAX XEN_SYSCTL_PHYSCAP_X86_ASSISTED_X2APIC

Doesn't this then need to be a per-arch constant? The ABIs would differ
unless we required that every bit may only be used for a single purpose.
IOW it would want to be named XEN_SYSCTL_PHYSCAP_X86_MAX.

> @@ -120,6 +127,8 @@ struct xen_sysctl_physinfo {
>      uint32_t max_node_id; /* Largest possible node ID on this host */
>      uint32_t cpu_khz;
>      uint32_t capabilities;/* XEN_SYSCTL_PHYSCAP_??? */
> +    uint32_t arch_capabilities;/* XEN_SYSCTL_PHYSCAP_X86{ARM}_??? */
> +    uint32_t pad; /* Must be zero. */

If this was an input field (or could potentially become one), the
comment would be applicable. But the whole struct is OUT-only, so
either omit the comment or use e.g. "will" or better "reserved" (as
people shouldn't make themselves dependent on the field being zero).

Jan



From xen-devel-bounces@lists.xenproject.org Thu Feb 24 14:10:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 14:10:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278310.475503 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNEou-0005E5-TQ; Thu, 24 Feb 2022 14:10:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278310.475503; Thu, 24 Feb 2022 14:10:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNEou-0005Dy-QJ; Thu, 24 Feb 2022 14:10:12 +0000
Received: by outflank-mailman (input) for mailman id 278310;
 Thu, 24 Feb 2022 14:10:12 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=gX/V=TH=citrix.com=prvs=047ddeb39=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nNEot-0005Dm-SX
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 14:10:12 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 78e24426-957b-11ec-8539-5f4723681683;
 Thu, 24 Feb 2022 15:10:10 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 78e24426-957b-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645711809;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=HO8d3Iy+0MObli41qHjfUvXIzSVy6pokjBaXj4EM0T4=;
  b=fkPgfW10n8MOqLqJPdXIO/PMCpF3qNZ7b7PL/PA04Da54si135011FST
   +5SasELJBo8hF1E06fBjfp7Bi8QdINADG5fPNsJIPx7VcB26t379xsN1B
   arMmsXWv9heOtQnIzoEJUvhbwZMGbgjPfygnMIHBBLsx3KR2y5EU+QidC
   k=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 64796963
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:HdP6uK6NAodK4EofwljI+wxRtC/HchMFZxGqfqrLsTDasY5as4F+v
 mFMCGiCbPrYYWf0fdpwPInkp0xX6JPdyYAxSgI+pHtkHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0XqPp8Zj2tQy2YLjX1vW0
 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X
 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx
 umhurSZRyp4YvbInd8jfEZ+LCtzDIhbpbnudC3XXcy7lyUqclPpyvRqSko3IZcZ6qB8BmQmG
 f4wcW5XKErZ3qTvnez9GrIEascLdaEHOKsFvX5t13fBBOsOSpHfWaTao9Rf2V/cg+gQQamPO
 ZtHMlKDajyYOTkRJUcoWKs1gcDv2lTGLR1Xlg6s8P9fD2/7k1UqjemF3MDuUsOObdVYmACfv
 G2u13T0BFQWOcKSzRKB82mwnanfkCXjQoUQGbaksPlwjzW7xGYeFRkXXluTuuSihwi1XNc3F
 qAP0nNw9+5orhXtF4SjGU3jyJKZgvICc/NePrxmswWI8ZT7vCCmDGU1ayMcbvVz4afaWgcW/
 lOOmtroAxlmv7uUVW+R+9+okN+iBcQGBTRcPHFZFGPp9/Gm+dhu1UyXEr6PBYbo1oWdJN3m/
 9ydQMHSbZ03hNVD6ai09Euvb9mE9smQFV5dCuk6swuYAuJFiGyNOtTABbvzt68owGOlor+p5
 iZsdy+2tr1mMH11vHbRKNjh5Znwjxp/DBXSgER0A74q/Cm39niocOh4uW8ieRk1aJpeImCxO
 yc/XD+9ArcJYhNGioctPuqM5zkCl/C8RbwJqNiOBjaxXnSBXFDep3w/DaJh92vsjFItgckC1
 WSzKq6R4YIhIf0/llKeHr5FuZdyn3xW7T6DFPjTkkX8uZLDNSH9dFvwGAbXBgzPxPjf+1u9H
 hc2H5bi9iizp8WkPHGMqNZLdQpiwLpSLcmelvG7v9Wre2JOMGogF+XQ0fUmfYlklL5SjeDG4
 je2XUow9bY1rSSvxdmiApy7VI7SYA==
IronPort-HdrOrdr: A9a23:BbhWQ6jugE0EZHBLfg/jzfA9b3BQXz513DAbv31ZSRFFG/FwyP
 rBoB1L73DJYWgqNE3I+erhBEGBKUmsk6KdxbNhQItKOzOWxFdATbsSl7cKpgeAJ8SQzJ856U
 4NSdkbNDS0NykEsS+Y2njJLz9D+qj+zEnAv463pB0BPGIaCZ2IrT0JcTpzencGNTWubqBJba
 Z0iPA3wAZJLh8sH7qG7zQ+LqP+juyOsKijTQ8NBhYh5gXLpTS06ITiGxzd+hsFSTtAzZor7G
 CAymXCl+iemsD+7iWZ+37Y7pxQltek4txfBPaUgsxQDjn3kA6naKloRrXHljEop+OE7kosjb
 D30l0dFvU2z0mUUnC+oBPr1QWl+DEy60X6wVvdunfnqdyRfkNNN+NxwaZiNjfJ4Uspu99xlI
 hR2XiCipZRBRTc2Azg+tnhTXhR5wSJiEtntdRWo21UUIMYZrMUh5cY5llpHJAJGz+/wJw7Ed
 NpENrX6J9tABynhkjizylSKeGXLzcO9k/seDlBhiXV6UkboJlB9TpY+CRF9U1wsa7USPF/lp
 P52+pT5fVzp/QtHNBA7dc6MLiK41P2MGfx2UKpUB3a/fI8SjrwQ6Ce2sRA2AjtQu1O8KcP
X-IronPort-AV: E=Sophos;i="5.90,134,1643691600"; 
   d="scan'208";a="64796963"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Zsqd6xnAMBiXmwBzY8FGLugqGsYpYofLTJTYPdSDNtgdOgAThrPMJew6tfq8kfGOoQqpoeAV/MhTKmUeXBL/fzygFMzGknWDyTYxNCj3Lk62GkPXtMRAqd/4Me4F21gjw7dgi9a9ywG0+2Gr9VwnksmY8fYkFOqVttB2wcg87IPAcIf9Nax9pCNtEXlrd0MNLoMG7uVMQcqoImtSVA1lRJ1GgZIVoX+TZElhqQ/RuSHPC0HJfZ7YWpDgmkJBdNK8llT8ospmjUMuE5rKSTOclo5JwI/gNjHtdEo7V/bMTkuw71iImaByCC6RDvGvbNCfLdP47DTfJPyRbfoehA/edg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=WK2wEGyyPtiRAwLzmuL1Xx7dgmiNnWcwAFWR0DlvWUc=;
 b=OCX0p8y6h4irYJqF5GND0PAriz2TAH9harWztld6Ih0+nADA59iXDUSP6rzYvGnZs5Ks5IoQ82LvV/MFevbtH+Ad3zHjFBlBez68xFF8oAtWNi3/Yjr8axjLA+RYH70zoOOkzaq+pVPG3DyopodEBbC4BtJveMylsxe3kN28k5XJ31hrihiKVDSw1belH2urHHGXShZvxvRMGwWxDauGmxKHWhWf84X9ZXqkMxtAuASVYTxTlMBwztpZ/2GkjqdB/OPu0bx0X3yR+tQszsHUzNL3HaA3Gmq4M1xJHH+VsvDyq2XkZ79+Hez9vk9ixh3crQGrci7sAOB+rjruBi9qxQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=WK2wEGyyPtiRAwLzmuL1Xx7dgmiNnWcwAFWR0DlvWUc=;
 b=tuRl269dfaqTx/Z2LD6esPxu6WbfD9nBbLNBvN9QwyPgsqJo+dw0gI22zMT3Ze7/S4YvAEyoW/bypw4SelcJKsOqZilyKa0/agrg5J/+LUXgtAaAisFgo7C2/66XekcPuHGa4lRoMZyWxjDmge1TVQPcocAbH9HYxthxGdIfwfc=
Date: Thu, 24 Feb 2022 15:09:58 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Andrew
 Cooper" <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v2] x86/time: switch platform timer hooks to altcall
Message-ID: <YheRtlnodHjyQuYW@Air-de-Roger>
References: <5f1f49e6-1380-73bf-d68f-6eb9dd05cad6@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <5f1f49e6-1380-73bf-d68f-6eb9dd05cad6@suse.com>
X-ClientProxiedBy: LO4P123CA0499.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1ab::18) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: dad1d80f-5282-4aab-1ed0-08d9f79f5aa8
X-MS-TrafficTypeDiagnostic: DS7PR03MB5509:EE_
X-Microsoft-Antispam-PRVS: <DS7PR03MB55096DE628170EDD804854FA8F3D9@DS7PR03MB5509.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 14X2l+zCImwq8NYtwRAXEvXAZCirB3CPeQPkxpoMGgLghjNLmw0+vcrwUoyzDUdLYooa8AfF8p11H5/eRX+tAvgunb4h1aI9AKrgRXuWnGI/rx5h/Ec66dDY/Mx7EfIiqZ3IsNC610T52qjy5GQ4CpqQ19ssl+nITvbhoPIZM+vApHzCpTrk1aTb5bBrVgDStVyKuJJZF3KuNr4Apnxhfb9oCzk95ZRFbv0N+3KdNT3i+Cf/WvKJtOR5aqaUpn7ltXSG+xXATY0U/Vo+agv7i000BclxCy1tIsG06XLkuZxyZ2T3aifUCVSf3JsTQ685Z0wx2EtZhioid0KHBv/BHm64GLoU+x5ru8O2p0ZQ2SEXJOER/JPZ03QSdsRwUF89HXKaTkoW6V89Sojt7DNorKrM/9GOiksiB+eaFotcfvnJnOK7ihfU275q0b2J1UpC/Sp7YZJ07mGIDwBhEmea3L8qr9XHicHYVHwu9Tl0D/fu8Rl2q0Ss9aJSIJQ/jAG77WkMh+Y2ExZ/fXixU1tIOTOkwnhfLbPMklwqV4RwHBIFm+G8k2Squ8l7wCCDk/kpyK8x/YePStt8HmDSy0lGWE+mxyeE0sXRb42Z22Xj5HUHZCE38hoOyf6BG762HwEyB9f8aaaub8X0VD1sQqkdCQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(8676002)(508600001)(4326008)(38100700002)(6486002)(6916009)(66946007)(86362001)(66476007)(54906003)(316002)(5660300002)(66556008)(2906002)(82960400001)(8936002)(85182001)(4744005)(9686003)(6506007)(6666004)(83380400001)(6512007)(26005)(186003)(33716001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K3puRzdLYS8zWnNLVkpqNEI4eEd5clMwT2w0RmVwTUhwYWtPVUlreEN1ZWtn?=
 =?utf-8?B?ODhjWitsWjBSVjBuNUNWd3lsOXNSSGhicXJybFlxZjdadWwzUHBVakhOZzdE?=
 =?utf-8?B?eWlyZTRVQndwcmZNUU04ZG1DaXgzNFEwS1lsUm96dG9kcldNT3ovdHN3OUtv?=
 =?utf-8?B?aU9lb1ZXNGk0V1lWUEtHZktpMmtJZnA0dnpyem4yaDNGbGVFNVhIQmpvYVBI?=
 =?utf-8?B?K3dYcnlsaXk3U3o4S2xjb28rUGpFRjZkNkdiNnFGV0gwSklTTlZ3cTFORUlj?=
 =?utf-8?B?SVRUTHFYUTg1RHBUQjIvNzMzUGxGRVJDUzEwbU5mMFNCYnhlZ284dHMrVm90?=
 =?utf-8?B?QjJGbkE1bGxEVXo5Qzk5UjlpZFA0MXBhS1h1SURYVitVazRWV1ZQTlVrd2Iw?=
 =?utf-8?B?N0RaNHo2NnV2RlBaeTFuMUI0TTl4QnJNeGZKR082dHQrblFkREFMTzljRGpv?=
 =?utf-8?B?bWlrL0lqQnhtMkx6amFtRThobUM4VzdPUEJNbThJc081cE9NTGJsTlZJRXY1?=
 =?utf-8?B?Mlo5M1JHNnY1ZVdyTlVVd0NCSGlXcEZSN2ZqRGJ1YVg1RGF0QzFqaHJudTFz?=
 =?utf-8?B?bFJob1NaL000RWlKUFlxNkRzUEhmRlpTVHhMTUdLZVlvUW1adzRMUEVKMm9j?=
 =?utf-8?B?eEVscFdJeXNxUjQveExiTlJIclFrT1FUajN2aWRwS1E2U2ZCYW9YMGxHZnFF?=
 =?utf-8?B?UmpZUmdLS2NnSFN0aHpWdTZNY2hZa3hYeVJQUjgzL013VGVwNVd4OXpvUmFO?=
 =?utf-8?B?REtZc2JHaGR0TU1nRDZ3cmJlVGs0OWs2K2Y1dDF6UGdoblVnK2lEendxb2hB?=
 =?utf-8?B?N0V3T2Ixd0ZZMnpjeUNYWG9UMTVwa1lIUFp2YTlFcU1NTDdMTEMwOUpQSHlX?=
 =?utf-8?B?amxTS0NPQ2hmT3BSZXNGSUVOOUsvenNSbWo0QmorZ1lKNzF5bHpDd3hUOFU0?=
 =?utf-8?B?VW53bzc0eURia3pTWkZ5QjhBbHZPWHk5cnlrVWlNL3F2RWFXb05COERvTjRH?=
 =?utf-8?B?M2FiUEtGakpUMzRlK3I2V1JmcTgzeWpsUlFWTnFzSTRXR3RaUG9Bekh0M1pU?=
 =?utf-8?B?c3RKNVQ1REVNMjVGZnZGS1VNd0lqcEVEbitFU1N2bExkdU84VHphSEdjK1gr?=
 =?utf-8?B?K1ArdEdZekZwYnBnbURsNTBsZFZMalVsOG9veWk2U0R1ZW9YN1cyNDh1M1ZT?=
 =?utf-8?B?T0RuL0NwZ3plQi9vOFJuVkFhMmFKTjlOWGNRbHh0U2tSd1FRaDZ2ZkU2c05T?=
 =?utf-8?B?TURkdmpwOXh0QjB1L0ZtMGs0TUM3VWNpNnB1dUtRaUVXQ2JJQkU5SjN2MHpQ?=
 =?utf-8?B?RVREdi85dDVZaXdaeEtJWXd0MWxuTTRSMHB4N0w3RjhlUkp1YStNMmt4dlZR?=
 =?utf-8?B?QURhOGlTMTc5VnB1RDlaQmw0SjlJM2JpNnQwTVp2TExmTUN6VDU2bENZbEtl?=
 =?utf-8?B?RGJXWXZrTTFOMXV1R1NDUmI3SjZsc09pM1lpUFZMNm1IZDBKU0FXaG5sVmRp?=
 =?utf-8?B?dE1TdjZPNlhvdUxKVHo5Tk1Pb0ZXVmdPSHRsTnB1UWhsdXMwbzFtOTJRdW5o?=
 =?utf-8?B?c1NORGtkU1RGTHlEcTBZRnM3TU9BZGttSmtNYW5rQ0lzbHpYVXFvcWJ1aEdp?=
 =?utf-8?B?NWZ0a3FTZ1FwbjN3M0VTZVNFZFcvV2x3cHhiWE9oR2QweHFHM1lSc2pvZ3ls?=
 =?utf-8?B?RTExVGtSdGxkZUN6cWFLZWlEM2VMWnMxMVR6SElLQWUxTHBCWWlDb3Y0eUwx?=
 =?utf-8?B?NTcvVGE1blBoTEdzcFF5Z2x0VzVEVVI1c3JyTEFFR0Q0QVNtU0JUN3lUbHlK?=
 =?utf-8?B?czJMSFNLdnpBOXVhRVlWUzdlZmVPclljVkhWNSt2ZFd1QTBuWWY4eFBONXM3?=
 =?utf-8?B?ZEh5YjZDajJpb3FlTTZMeEV5eUpQTDZaNnZxMjYyZ0c2eHhQOXlSZ0d3V203?=
 =?utf-8?B?VStSd0UzMk14VEZlRHlMS3I4YWozMys5c3I4cCtHMHdVNTNFMThFaVBhaVN2?=
 =?utf-8?B?Nm9OL241bnl5Z1JMMmo1aXlUZ2p2aGhiSi9UNk1SOGZkdHQvcFNNaFpIdGJs?=
 =?utf-8?B?WERRRk5XYlJKMjRZYUZVMkRIeFlQUnFpdDMzeEVpeUNqMUJpUTRzWkxTVGxG?=
 =?utf-8?B?QVJwc21GYU96SW5YZkNFLy8yZjZ1dUMxZnlHZDdFZE1UY1RYU1FobmJMYVZJ?=
 =?utf-8?Q?LtqmKF+yjoDPf+yoNOURryU=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: dad1d80f-5282-4aab-1ed0-08d9f79f5aa8
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2022 14:10:04.3401
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KOTxbLUHLED+nUynXDgs3yzvjNTD9VpV86Ado6+OGjFmhDIdizvqiU+T5kDhdKHSis0JJt+QhVnlHKTKwsvpRQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5509
X-OriginatorOrg: citrix.com

On Thu, Jan 13, 2022 at 02:17:18PM +0100, Jan Beulich wrote:
> Except in the "clocksource=tsc" case we can replace the indirect calls
> involved in accessing the platform timers by direct ones, as they get
> established once and never changed. To also cover the "tsc" case, invoke
> what read_tsc() resolves to directly. In turn read_tsc() then becomes
> unreachable and hence can move to .init.*.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

> ---
> TBD: Instead of adding __init to read_tsc() we could also ditch the
>      function altogether, using a dedicated (non-canonical) pointer
>      constant instead for the .read_counter initializer and the two
>      comparisons done on plt_src.read_counter.

I was going to suggest adding an ASSERT_UNREACHABLE, but not sure it
makes much sense if the function is init only.

I would be fine with using a non-canonical pointer.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Thu Feb 24 14:16:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 14:16:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278319.475514 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNEuo-0005zC-Jp; Thu, 24 Feb 2022 14:16:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278319.475514; Thu, 24 Feb 2022 14:16:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNEuo-0005z5-FA; Thu, 24 Feb 2022 14:16:18 +0000
Received: by outflank-mailman (input) for mailman id 278319;
 Thu, 24 Feb 2022 14:16:17 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=VLhp=TH=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nNEum-0005yz-VN
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 14:16:16 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 53d7e077-957c-11ec-8539-5f4723681683;
 Thu, 24 Feb 2022 15:16:15 +0100 (CET)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2053.outbound.protection.outlook.com [104.47.13.53]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-7-9wXxfC1kN4S2oaTK5brpdA-2; Thu, 24 Feb 2022 15:16:14 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DB7PR04MB4777.eurprd04.prod.outlook.com (2603:10a6:10:15::23) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.24; Thu, 24 Feb
 2022 14:16:11 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.024; Thu, 24 Feb 2022
 14:16:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 53d7e077-957c-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645712175;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=PM/GDhpfC64e+DXbihrc4fpa1OhHEQcfKhNwcLWZrhQ=;
	b=lCg+IZkjvYMPXUoDd8yrZJNXMVy97iukF3TrrTeruCxzaH1OL9Iv+d148am+Y574wj3SMN
	jZwPqJIQbJlFqibatelfTkeX24A6ysh0ABD5HTsA/YncJCH+7koqyLbDx/57BEQ93TGYuB
	0GlyUeU1//Zf08r/qBow400a328ocJ0=
X-MC-Unique: 9wXxfC1kN4S2oaTK5brpdA-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=LOW/zDNk34gQKHntulfifCnAraKbj4so/acFxeh6iA6ffWr9zJHykQwO6Ywf6SBK8lKE1GX25sYVTIJJCnG7M12FhcEPMqrspmgxHL1Y6rV0Ad8vMsjof0A4fh8Y8oroQ+EthPU/jk0BJCkCwUjxxcGmuBJMo8XQJrC2qvmg5DS2OxrHPMiIN64afuIgH/C9blaik5UBv+tWZWxFRhYDcpedoxc8TUqOHrCIffeznkCc4q2i8i8TCiP6gjkjmVw+QFOVm08H0UUgmcwBcO2ogEDEITbLcVOlypHtRtH84fpWo4Cfy8E5BOMROoQ6SvZE6QUZ5chO2vr7KOnxuCjpag==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=PM/GDhpfC64e+DXbihrc4fpa1OhHEQcfKhNwcLWZrhQ=;
 b=NOrLWH8Cd11JpvziSI/3VHmSoPRbzuk71vGt9SuMbX1kd1wtl0NeHn6nRhqfSFc45BiJ9T61vkJH0TDorYJBp595c0wyH98uI+Fwx5N6VHuImcLt+e5mbEaIOUNImf47JyTR0OCzM17H6B/gTC2d61hKzb7+ZIFHsW/Z/SkGPOkWlWwRaXodXFR63hz/SkpBtb7760JOL4AQn4p/ckD2R4YbCK/cLSt35uWKLY1+e7UsVhqBHItErYTcX8jYxZoNikWJGI+ymbimBqHB4IjUmJHQufjDVp4EP+bZYlVQjx4s39K2xkJokPKICTxA1IKKWt/cGio4p5cF4pceGP1O/Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <b83773ec-c97a-7aea-e61a-c2e34b270816@suse.com>
Date: Thu, 24 Feb 2022 15:16:08 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v3 2/2] x86/xen: Allow per-domain usage of hardware
 virtualized APIC
Content-Language: en-US
To: Jane Malalane <jane.malalane@citrix.com>
Cc: Wei Liu <wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>,
 Juergen Gross <jgross@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Christian Lindig <christian.lindig@citrix.com>, David Scott
 <dave@recoil.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20220218172943.12182-1-jane.malalane@citrix.com>
 <20220218172943.12182-3-jane.malalane@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220218172943.12182-3-jane.malalane@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR05CA0040.eurprd05.prod.outlook.com
 (2603:10a6:20b:489::23) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 8776d6d0-2718-4bf3-9b5c-08d9f7a03528
X-MS-TrafficTypeDiagnostic: DB7PR04MB4777:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<DB7PR04MB47776DE5FBB8004817C91D44B33D9@DB7PR04MB4777.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	U/pb9r8PjY9mUp8DehDwMlSFU1hY7NGASAfMbozoLuhsSnzORNhv69XJvx4lzOKLVUfmyqpAoIyclWoHkzv8Qteyv4S8mqPsDQT/mIw3Kk4+BvhuWlol+gLn7QCz/f7PTQH1OxEJvCjBxCTzLjaloApLMos/TQzeHD0p6Z7jMdmb4NNHEvpootoTwCWYCzvLXRHAf2zpCEW/ANeHu6w1ecUWypSca/I1jkCFDZzAumb4vmRyfWyPfOLa2IMWYNQnWIzfp/a3840yHcyseszET926jQa2Z1tS51WFDZJci8sQQFarkfnkL4Dy2mcXRDcqDr/zpbsfKkqfKuwMbdXl6y3zkjqaHXos+VAlq7BczaHB4xVKfnPKC6FspEWKjSWopIsaq3u4ls5vjIB2vIWNi43QP1J0PewF32DNP8itab5edYQX/Cym8PS27gQQzPFBuKlDLc6jdlw8MTkxr/JJonIYWpdvB9DdbHV37ot67AKZ/EWUb1GYtgesFPL/voUy3mcA5u2c+ZyG8PEla9PKw8z5lIzkpZvDbvMBazKFzGCe2oDOkrsStHwCFxTfYJQaaLG1aluxjK41fRY/eWmlLR7V/ezgAhSlemWzXFq4RS/93IDD8mFiCDoiMog7CJJrzQbieWdM2RHqXeAJ/SgCkc5d70f0dYDNyYM5oJVt3RReCUHQrFkZVR/sgplcfOi3CdjGDG3SPC3hOB15NorWWoZquoACNk8Dw2abPQ/O5Vnvd394XGbuEqfHP579NWCS
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2906002)(26005)(2616005)(36756003)(6512007)(8936002)(186003)(86362001)(6506007)(7416002)(31686004)(6486002)(8676002)(66556008)(83380400001)(5660300002)(54906003)(508600001)(53546011)(4326008)(66476007)(66946007)(6666004)(31696002)(38100700002)(6916009)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aVVKd2lqVE5rMmhoTUFsb08xTDhOTWVDY1BMeGtYTWJNSGRYQXAxNmVtZVh4?=
 =?utf-8?B?d1oxQXdTbHQxMFBzRUcwb2x4OGg0eW9mUzFPNGRUMCtTSW8zUGc0UTlCbk9p?=
 =?utf-8?B?dWZGZ0xFeHVwRkRPcklGNUp1K1R6N3puQ0xHKzF0RXRSUzdwdEFLcGF0R3Br?=
 =?utf-8?B?SGduS1ZObVp5OUJZVEpiK08wZThieUxzZlBBbkNRaDhVeUNLQWVDNmdNZkNa?=
 =?utf-8?B?dmFOdjFlSmFPdWhkL0tIb29jQWlod0lCVFpmYjZQT2c3dnpjdm1zcVpEYnBs?=
 =?utf-8?B?T3hKanN3WjN1YUZsb1JhWmZrRWIzc2ZCV0I4RTZzUlJPMEV3QndhUDQ1NjhV?=
 =?utf-8?B?TjJQVDZxN29RQUtJTys1VWZPN1o2U3JOZkxsUmoyazFsR0NMTmFXNnJjZ0Uz?=
 =?utf-8?B?N01XbUlWL3U5TC9GWTUzS1FwM3M5UFhGWkI0K3ZsRU9RaWZtUkdJdi8wTlcx?=
 =?utf-8?B?c2I4dDVKdWRZdC9hNUs3YzJ2SGtuSVRLd1pZR3J5ZkZsUzNRTmlJdlRjbkVp?=
 =?utf-8?B?dmtCVDdFVTRGd2FGRnBqQ2gvM1h3cXpXZDZMU041OTRxS1BnZzNJS09ndksr?=
 =?utf-8?B?bmEzSjQvMnlDN25XRFdURjBhMHRtWVZMRFVzdTcxY1pGc2hIdG1rTUE4R0VG?=
 =?utf-8?B?MmJEc0xITHNiRU9VeHFuVmpTbmtaRDNPUStUVW5MWnkyODFWS2VlcmhVWjZr?=
 =?utf-8?B?b0pqbXo1dlVGb1BOVTRyaXFUd0EwcEIrdXdwdEdDelJ0Z3FFdGk5REFIMzFP?=
 =?utf-8?B?S0VueHV5K1JBTDNZNE5RTFpwUlpHdnQwWEJwZUhqTnlrQ25NMk5HSjNGcGxL?=
 =?utf-8?B?eEhmeVdLSC8ydXFuOWV3ZjRXbmJ4S1hpeWYraG5ZSmZlZTVqa2JDOXNBQ0Vx?=
 =?utf-8?B?aGxKcW1vZmRZcDlqcXRwZkVzeUFUcXVMa2NPR3dsYlJuN0Q2VkJGZTQ5T0lj?=
 =?utf-8?B?bi9PUFI2STlocTlWSzExU2tFNjFBM1k1ZjRlNUt6TEFEbVF1Rm0reGczajYx?=
 =?utf-8?B?SlJBemxzVHhvL0pHM2hjVnMvZFE4d2xZS3AyMHZyZ3hzaUc4RVV3anI0cnV5?=
 =?utf-8?B?dkFlVFBMVitHQTdKd0MyMG83VS9UakJ6YnppMmpPSlMwSnVBa080VVpGUjUv?=
 =?utf-8?B?UW5BZnowT01DV2hGcHBrY2J2RkdVTW10U1RVSnBHS2I3RitXUjJ3TEtwZEh4?=
 =?utf-8?B?VWdZMEdGWkY4bnJYak45M1JrUjdYM1p4anhxSGJpcWVZRmlQUytOQ3ZMU2c3?=
 =?utf-8?B?SzMvTFhwcVg3Y08ySGI2NVZ0bExoRXAxZ3VLWUlCT0dnVEt2aGowTzFyTDZw?=
 =?utf-8?B?ZGo0R2RjRUhKbGpwMTJ6bzU3VUgwdSs0QjRiVVJyWmdhRU5xb3VCYTVVc3Nr?=
 =?utf-8?B?RC8yTHVLV3NKMmVJbU5TZG9FbW1zV0xaRGhBUTNFd3R0bm9UeFBNeG85RHZ3?=
 =?utf-8?B?Uys0RjhudXdEcFJBcXFDZWVoZ1lOMk9rMjhsRlY3b0I0WEZaVWk1bUF5aC8z?=
 =?utf-8?B?N2tQNERqU2NFUWZFYk8wYjcyUjdHUVJqbHBYU0Q4SmFqOC9tSTNhTnRKLy8v?=
 =?utf-8?B?U0FlNURvR2lRRTNiaGU3Z0hyQ3hTc3UrSHBZd1FmK3lVSmN5eXdwMkFTYnBr?=
 =?utf-8?B?VHMxeElWQmllMFZPaHpXTkZ3UURVQnRIR3h6UHlZaE1NT0cveGZYU202NldW?=
 =?utf-8?B?UzBuSVg5aVIxbS85WHpHNHRKL1gyV2FLREc3QjR2Y29hZ3RGdmhFUkRaa3lt?=
 =?utf-8?B?ZHJPdTN4azgzY28ybUs5dlR1Q200cUJ2S0RsVlBGOGRQSUVDcElYeHIvdEE5?=
 =?utf-8?B?ZnpUM0NqZW9DZS9tOEJNR2tmd0hFQS92OUJVZUhUMTA4bElINVFCT2UyYzU5?=
 =?utf-8?B?TGMwbHRNMC9MdjRacm5xT2dsN2t5eTVzaG01MmxIeENGQkoxT2VvS1ZRS1ls?=
 =?utf-8?B?RWQ0SXZwZ1V3cFpTcklEbTVBQ045Y0pCUURyY0RSMmlUQXJHMXRRZFRnQmRj?=
 =?utf-8?B?MmgzMzlERUxCbXBneHdNc1U4S0hnbTQ1Y05ueWZ5bG4wV3BPNE5WTXVTdEhx?=
 =?utf-8?B?NEFCOUhiN0s5OXdic0FCbTQ1MzdhZ3IyYjZ2RHhFVlR0YXh4bnUxblRjNkY0?=
 =?utf-8?B?WngxTWw5dE1mcnlCQWJjd2ZpYkh1NHZPZ0ExWWxOV0U3VnEyR3BNVy8xakFw?=
 =?utf-8?Q?U8wUkfNmfmbl5An7X6CgYc0=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8776d6d0-2718-4bf3-9b5c-08d9f7a03528
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2022 14:16:11.1442
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: W58BZoSCaNiv8WWmdeE3kHd6kHiu6MktkAaRnEHkeSjei0/7LymgOo6E7QWVOR1QwTiFcwCvWDFDk4bobko00g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4777

On 18.02.2022 18:29, Jane Malalane wrote:
> --- a/xen/arch/x86/hvm/vmx/vmx.c
> +++ b/xen/arch/x86/hvm/vmx/vmx.c
> @@ -3333,15 +3333,15 @@ static void vmx_install_vlapic_mapping(struct vcpu *v)
>  
>  void vmx_vlapic_msr_changed(struct vcpu *v)
>  {
> -    int virtualize_x2apic_mode;
> +    bool virtualize_x2apic_mode;
>      struct vlapic *vlapic = vcpu_vlapic(v);
>      unsigned int msr;
>  
>      virtualize_x2apic_mode = ( (cpu_has_vmx_apic_reg_virt ||
>                                  cpu_has_vmx_virtual_intr_delivery) &&
> -                               cpu_has_vmx_virtualize_x2apic_mode );
> +                               v->domain->arch.hvm.assisted_x2apic );

Following from my comment on patch 1, I'd expect this to become a simple
assignment of v->domain->arch.hvm.assisted_x2apic (at which point the
local variable could go away), just like ...

> -    if ( !cpu_has_vmx_virtualize_apic_accesses &&
> +    if ( !v->domain->arch.hvm.assisted_xapic &&
>           !virtualize_x2apic_mode )
>          return;

... here.

> @@ -1124,9 +1125,8 @@ void cpuid_hypervisor_leaves(const struct vcpu *v, uint32_t leaf,
>           * and wrmsr in the guest will run without VMEXITs (see
>           * vmx_vlapic_msr_changed()).
>           */
> -        if ( cpu_has_vmx_virtualize_x2apic_mode &&
> -             cpu_has_vmx_apic_reg_virt &&
> -             cpu_has_vmx_virtual_intr_delivery )
> +        if ( cpu_has_vmx_apic_reg_virt && cpu_has_vmx_virtual_intr_delivery &&
> +             v->domain->arch.hvm.assisted_x2apic )
>              res->a |= XEN_HVM_CPUID_X2APIC_VIRT;

While within the 80 cols limit, I think it would help readability if you
kept it at one sub-condition per line.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Feb 24 14:42:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 14:42:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278329.475525 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNFJl-0000oA-Og; Thu, 24 Feb 2022 14:42:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278329.475525; Thu, 24 Feb 2022 14:42:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNFJl-0000o3-LL; Thu, 24 Feb 2022 14:42:05 +0000
Received: by outflank-mailman (input) for mailman id 278329;
 Thu, 24 Feb 2022 14:42:04 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=VLhp=TH=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nNFJk-0000nx-2v
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 14:42:04 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ede06cd8-957f-11ec-8539-5f4723681683;
 Thu, 24 Feb 2022 15:42:02 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2053.outbound.protection.outlook.com [104.47.14.53]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-27-Wni-O_7xPAOn37SUJ0MucQ-2; Thu, 24 Feb 2022 15:42:01 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by PAXPR04MB8814.eurprd04.prod.outlook.com (2603:10a6:102:20d::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.24; Thu, 24 Feb
 2022 14:41:59 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.024; Thu, 24 Feb 2022
 14:41:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ede06cd8-957f-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645713722;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=BNpsONnuuYEHWystxacrr26pfEyNCoQQXi5U/YMjpOc=;
	b=CciO4LguZHaKgm1ye8mLLRuHMiZU+iEjcZF4fUl8iPOEvJkXaEZtiVhAD5bDGZxCAhTs06
	sMmuMr/LnWLakouVdoCoBOb8EbgItOxkqJ52rO79AVIDmHaQsyvTHFWfSAvWVst5fv5x8x
	UgHLNMc7RqrTFxkHYHepdeCc01/XaEA=
X-MC-Unique: Wni-O_7xPAOn37SUJ0MucQ-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Ph0vZoWiFGZl3hDfI+X0in0CkzlLjUJj7hrLjizb+8+SOc0NvpiguXBSfmBPXj0Vuv7b/yNT2GrBnHLxVmtkVMjOptlNm6rIk3bTZtIW28IECT95/cGr6z+pcN3s3qXF6Emcrkas3yc6iBw7Rdd3G2+T6Ze4Ni6hF48De7kHL2mudevL7dCPyTngPGUllVlAvDzJpyvVpRyaJVpWF4JYPcgGHse5oUae4kBGX3WjZTXDHdxqe1l8zt7pet2NIpt+yPj7cfD1ovb7lyKvD5BQqEFewl/HKUWthxAj5e5HR/fh6cAcKQWasQ1gw8Nu7ERodGSWlkKqpJyxz3dskEEaKQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Q2B+OsETm8MxC47cmWXt2pUmYY+TrnfqvkDqckVSlsk=;
 b=FKViJIhQ83uL4UXegLbwyfeSdX2aEExG/7WU6Bc6ta+XgJD/ZPyvSmrhT6l6mWv+Vk5RefPpkY+YODoak3F47N7REqjeF73bsFHZd7fFzAHhR71yehCB9KjgYS9kPmylWCTf8/wTTNCEjq3gaGVzQBQT5CMFPlvrE+KHZdRHV5LDVW0daJzJsD811w6+CH7dM1RnhZQTZhcYijy2nSvHWoUp8h9kJ5w3kh9FMBIS+XqlpXgnrZ6OHukPgbQmdhMuyHM7FYDJdl1Wu26PBOcJZK/LqBKGQWoKbdezucgsZ09qx6Ib45dGDE4e9p47hHILPLYvNBNXvupl2yJtOQx7uA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <367aa0c2-1ab5-fb62-e8b1-42fb20394081@suse.com>
Date: Thu, 24 Feb 2022 15:41:57 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v2] x86/time: switch platform timer hooks to altcall
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
References: <5f1f49e6-1380-73bf-d68f-6eb9dd05cad6@suse.com>
 <YheRtlnodHjyQuYW@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YheRtlnodHjyQuYW@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM7PR02CA0015.eurprd02.prod.outlook.com
 (2603:10a6:20b:100::25) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a56df8de-8847-4b44-dffe-08d9f7a3d011
X-MS-TrafficTypeDiagnostic: PAXPR04MB8814:EE_
X-Microsoft-Antispam-PRVS:
	<PAXPR04MB88142AB046051CC718E4D537B33D9@PAXPR04MB8814.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	pSCf1mSwvElT1Wv9kKUTucOvphCT9hOteJttFemBuvDzAP0Od+CpaoeRlTYiZ9gBbBEwnZ5tvmrEQgVOSVRMkkg5d3oRvCOtw6PJOdMhUafbK3UjVw6ipCOfdUpAtjDHEm5kIXaD/ZJHJ2RSAGtjBiF9kH0PprDIu3irH9tO/OryJPa2SjFdDq2RLrL4tvpB9+Pj+Tr4UIA89B/7Lw5BLAXcxLr/FTGT//9R5cYsXNa1VKR0Z4ANSyw4gmUJM8gyWtIBfl71fsrXDbBNaGrcAokFgkA6iR9i2sch/bf4l4Xk7kK0tWuNn1uaz35UllO96RHA7OpLrsSg3HhVStR5oM6euUgHHhsw47RX44ZqZIaWdv+2Jz2RdC725qaIMMvEPp8OZV1feG+1TICeq3M1BjfUK30G7mWbI13Br0g1fpp0VxpysqRReGrbfjPnDI7cRgWjLLkpHUN3QQA+e1VNtND4pT9cxmXP/825B2qWwG8D/IEyGbXgTS8ANpym2U08oU41n/JEV0p9OeU1c1DatduIXUoElEO2XV18kahwCkhG9DYfLf0mc5QdiJVg3jPI4WjJtEiZp7Hwgkw51MMbx30LZERs7ZbL5aRyLzHH2Jj7XgT9ZVwJ0pBuwRbDQrUpZM68AGH8XUUWK5TekikAiRMjktCWbkiAZCe11SjScBhPVu5dxPV0woNYGLKjAH2StbcasOD5aC28DWbhYZWB6vabdEHKDK5mltA0Vj70K22tctd8or4rdEqBrfFauLl0
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(86362001)(31696002)(8936002)(8676002)(54906003)(6916009)(316002)(66946007)(6506007)(66476007)(66556008)(4326008)(38100700002)(186003)(26005)(53546011)(6486002)(5660300002)(6512007)(31686004)(83380400001)(2616005)(2906002)(508600001)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?zWlJBwSBqtVjySK3dlGEeEWfTPiBLMyik+JTX6+BRoMFCmCBJU/ug9ANeXi4?=
 =?us-ascii?Q?k8FBgqwRLDgI8Tj0oPLHnbAjRtvw7xT9i3T+swZF4PII3skJZhiB72FIFdeZ?=
 =?us-ascii?Q?bNHOAnMcbZMnfpLslhJErXu3AWRD3GaniT0H9vKqvyHWTA6TRFBgGtHuwMOX?=
 =?us-ascii?Q?g7ms7hklYcP9x7LIKULxpBN5KobHkQGcFG2sSzEK6Es9FzCz7C3lr8d3vHqP?=
 =?us-ascii?Q?SpAgFdzmO9qkouRJVvQmMADmYxzIjP+Jr7jANTIUaFMVDudDnfIs0FYAImZJ?=
 =?us-ascii?Q?LhjC4hD5OokyLMWb5t+r2FEIlSEbqEcVCgpaF9FbhdoYFyB1NO1ebIvuKu3V?=
 =?us-ascii?Q?wIXQVt0B5N9skEdztwg/vCbDsKv+/zNBIZNCeyKqxrE0fWKDwxbgilu2cdYh?=
 =?us-ascii?Q?z+Ye4EvzqeN77Y4m0FpkHVvwyNQg5RUYUiuzLiChnQ7dNHTLuE6EXNZnw1/q?=
 =?us-ascii?Q?ZG7+qZFvhMGwr5BEBBPODqYKw1/nTeDRLkXqVID553TdrzpjzDNahamXHMtj?=
 =?us-ascii?Q?6m6tXowlnTJaz0etikIQazOuPIIKlpfp9nfMwGLTTJvvsZYpRjJuyKdsbRRy?=
 =?us-ascii?Q?H1HiqwJKIF9RqKfHCZyH4IGL7kX5aqlYRQsfhwnGMDlnazEaiX4m++aGm6/g?=
 =?us-ascii?Q?TxRi5Fuk91AZZtVmqlpIMAyyATBCi1TAXR/rpbPVfqRXQR2GCvCtmrvYlIm9?=
 =?us-ascii?Q?0C/XQOwoCgyRfe8xRJ3QbQmAS5vKmvfxpliTV7Q0xWqiPU6GhhBnGFy9ubQU?=
 =?us-ascii?Q?wTKybjjc62vm8Rifks9jw3WcogWGVWGP1lIowwRKnrrWaPlAtL7EzeZ87NK5?=
 =?us-ascii?Q?X9WfDUESj4euSCbUhJkQ/F1ietzHRJoj08uQEXagWvpPJrfckv+2sEqB/IKK?=
 =?us-ascii?Q?FPwGRzRmtW+SWYkhWpf18vsxP6CvojVuIPSksL3idpihnk9y9U5441KlW9SN?=
 =?us-ascii?Q?xwqvqrPiXol2+a3muLlqr7WZG1RcMzxRMGZNvF2V49LvGTerdh9+0lcnDD4y?=
 =?us-ascii?Q?+XCUYw/VXS1HYHWHydVOfPh647TE1vRt001mtZNgwd4Y9DqovlvPe/MceRLS?=
 =?us-ascii?Q?8fiFoVYUylVnKGJhGMU0XaYgiLpp58WycicQDK/dH1DEcSVgkI+7pv0ZUvan?=
 =?us-ascii?Q?zhDCNAbmSwS43iOPgazpEu7ipPIl2YHKFNPUTx7J59pICckWhfgikwWgNKiz?=
 =?us-ascii?Q?JQqoUrX+dtVWi7zTgPH/VgUHH7kATFN1CGxldy/muOrYtu3/q57R8MzMkQ0b?=
 =?us-ascii?Q?VfgzxlzF7Ud5Cd4gn9DRhJ9qj8G6KMf9OHM032Cregswgak+jFUDqzt0lzi2?=
 =?us-ascii?Q?ZNEgHdCoA4HYwWUiHqz5QSVeS86au+/mJwBFejBJDUifhVxxaJgPBvEh3Stc?=
 =?us-ascii?Q?dFidOqMeyuCvjj0roHfYzLCVaGp0m7lWnhHnfkujCWtq4xxvwA4HZA4nB34Y?=
 =?us-ascii?Q?ZqRYdgrWuApk3Bt58KQ6BlaShNizkcE5xTzwEuWVpBkP5ZRK4qBARMJa0fyc?=
 =?us-ascii?Q?kYVjZabJJeQ3/51iOT8JFqv49gkzWQuutSSHQVIgZdE8A5TBp4fBUZfegmg7?=
 =?us-ascii?Q?6V8sWIee05dAp+aht+MgPx+bAlJGKc9UfzxmkU0g5tx8Zeh05M7o5buUpjot?=
 =?us-ascii?Q?wwjRkY39OYNF/7TtGuseoPE=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a56df8de-8847-4b44-dffe-08d9f7a3d011
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2022 14:41:59.3448
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pY0w2mppMqjFzJCh9eTCRgJj5uwteqvRa+rKkx1b4CyNyj6mWINDzrFmCHMi0Os4d9id3grGQ0U69ajninq8Ow==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8814

On 24.02.2022 15:09, Roger Pau Monn=C3=A9 wrote:
> On Thu, Jan 13, 2022 at 02:17:18PM +0100, Jan Beulich wrote:
>> Except in the "clocksource=3Dtsc" case we can replace the indirect calls
>> involved in accessing the platform timers by direct ones, as they get
>> established once and never changed. To also cover the "tsc" case, invoke
>> what read_tsc() resolves to directly. In turn read_tsc() then becomes
>> unreachable and hence can move to .init.*.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>=20
> Reviewed-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>

Thanks.

>> ---
>> TBD: Instead of adding __init to read_tsc() we could also ditch the
>>      function altogether, using a dedicated (non-canonical) pointer
>>      constant instead for the .read_counter initializer and the two
>>      comparisons done on plt_src.read_counter.
>=20
> I was going to suggest adding an ASSERT_UNREACHABLE, but not sure it
> makes much sense if the function is init only.
>=20
> I would be fine with using a non-canonical pointer.

I guess I'll put in the patch as is and do the conversion in a follow-up
change adding __initconst_cf_clobber (once it's clear what to do about
structures which are written to).

Jan



From xen-devel-bounces@lists.xenproject.org Thu Feb 24 14:54:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 14:54:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278337.475536 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNFVG-0002It-S7; Thu, 24 Feb 2022 14:53:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278337.475536; Thu, 24 Feb 2022 14:53:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNFVG-0002Im-Oy; Thu, 24 Feb 2022 14:53:58 +0000
Received: by outflank-mailman (input) for mailman id 278337;
 Thu, 24 Feb 2022 14:53:58 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=gX/V=TH=citrix.com=prvs=047ddeb39=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nNFVG-0002Id-1Q
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 14:53:58 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 963e4043-9581-11ec-8eb8-a37418f5ba1a;
 Thu, 24 Feb 2022 15:53:56 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 963e4043-9581-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645714436;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=yiAZxBXHR3X4ZzNbpc9Jm8d4cNxdGTj9ugxuePGrrlo=;
  b=XoL8E1uRXOY9fxL+Yjx1uK4k45u/aPkiefqDiSRmp4aC/TOfC0AJcwLu
   E0BiA2v4FbZgcbwk6HcL2A4hbv3j4UgWqLp5196ZFIq2LU+4C688LN15m
   TLyjXMQ/WSL2pk11j7xYFKhLHvTFe2rCVoBK06hAp8/5Di6hzJZeDJqPO
   U=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 64910182
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Fc2FVKhkJ3XOC6ZOLAOV8dgcX161lhAKZh0ujC45NGQN5FlHY01je
 htvCzjSbveMZGL3f9B2PtnnoBkDuZ6GzYcwHgpt/C0zRHgb9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M78wIFqtQw24LhWVnR4
 YiaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV
 efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9
 TlDiXC/YQMqO72SquBeagBzSAJbA5Nl45P2cGfq5KR/z2WeG5ft6/BnDUVwNowE4OdnR2pJ8
 JT0KhhUMErF3bjvhuvmFK883azPL+GyVG8bkmtnwjzDS+4vXLjIQrnQ5M8e1zA17ixLNaiCN
 pNBMGo1BPjGSy9uYlgLDLwVoNqXlz68XxZK8niqmpNitgA/yyQuieOwYbI5YOeiRshLn0Deu
 mPP+Uz4BA0XMJqUzj/t2m2orv/Cm2X8Qo16PK218LtmjUOewkQXCQYKTh2rrP+hkEm8VtlDb
 UsO9UIGpK4+7hbzFoHVUBixoXrCtRkZM/JIGvA+wBGAzOzT+QnxLmoOQyNFadcmnNQrXjFs3
 ViM9/vyHiBmurCRTXOb95+XoCm0NCxTKnUNDQcGUA8E7t/LsIw1yBXVQb5e/LWd14OvX2uqm
 nbT8XZ41+57YdM3O7uT+VPCk2yeotvwVyVuxSDpYEG+wjIoe9vwD2C30mTz4fFFJYefa1COu
 nkYhsSThNwz4YGxeD+lG7tUQuzwjxqRGHiF2AM0QcF9n9i40yP7JehtDCdCyFCF2yruURvge
 wfttAxY//e/11P6PPYsM+pd5ynHpJUM9OgJtNiJNrKigbArLWdrGR2Cg2bKgQgBd2B2zMkC1
 W+zK5rEMJrjIf0PIMCKb+kcy6Q34Ss12HneQ5v2pzz+j+bDOiLPFe1ebwPVBgzc0E9iiF+Lm
 zq4H5HXoyizrcWkOnWHmWLtBQpiwYcH6WDe9JUMK7/rzvtOE2A9Ef7BqY7NiKQ+95m5Ytzgp
 ynnMmcBkQKXrSSedW2iNyAyAJuyDM0XhS9qYkQR0aOAhiFLjXCHt/xEKfPavNAPqYRe8BKDZ
 6NbI57ZWqwXEFwqOV01NPHAkWCrTzzy7SqmNCu5ejkvOZlmQg3C4Nj/eQXzsiIJC0KKWQEW+
 eHIOt/zKXbbezlfMQ==
IronPort-HdrOrdr: A9a23:GI4coKD3WRSd4i/lHeg1sceALOsnbusQ8zAXPh9KJiC9I/b1qy
 nxppkmPH/P6Qr4WBkb6Le90Y27MAnhHPlOkPQs1NaZLXLbUQ6TQr2KgrGSoQEIdxeOk9K1kJ
 0QD5SWa+eAfGSS7/yKmTVQeuxIqLLskNHKuQ6d9QYUcegDUdAf0+4TMHf8LqQZfngjOXJvf6
 Dsmfav6gDQMkj+Ka+Adww4dtmGg+eOuIPtYBYACRJiwA6SjQmw4Lq/NxSDxB8RXx5G3L9nqA
 H+4kHEz5Tml8v+5g7X1mfV4ZgTsNz9yuFbDMjJrsQOMD3jhiuheYwkcbyfuzIepv2p9T8R4Z
 PxiiZlG/42x2Laf2mzrxeo8w780Aw243un8lOciWuLm72OeBsKT+56wa5JeBrQ7EQt+Ptm1r
 hQ4m6fv51LSTvdgSXU/bHzJl9Xv3vxhUBnvf8YjnRZX4dbQqRWt5Yj8ERcF4pFND7m6bogDP
 JlAKjnlblrmGuhHjDkV1RUsZ+RtixZJGbFfqFCgL3Y79FupgE586NCr/Zv20vp9/oGOu55Dq
 r/Q+BVfYp1P7wrhJJGdZc8qPSMex7wqDL3QSuvyAfcZek600ykke+C3Fxy3pDsRKA1
X-IronPort-AV: E=Sophos;i="5.90,134,1643691600"; 
   d="scan'208";a="64910182"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jUdxex0QcaVl3WAnHng/161OnUUIZ8puZJaBN6rzr/ybZ2WswtJB7BpsW+kX50xNCxcCje91MCiIxMxwHHd4cwNEEQr5BG4cY6iHx/IOBAsdGDW5Cbg94UCeeLaicFEzw9Evlrbg3+vUTw9BeECSRVqnTkohMAPQ6vVmlTq2wNw25l19n+i9bqzTJQZ5cudQl2Rnfs2P68hQXgFpnYiaJn4ONCj4z/llYGqZQinNFHU8gD6YfB+hxKregdaruNCBnI0qXco/6aJc1hHrmFu6pHbVv4Dtesz4yjbtAJWKugnX1ii1OlaMkEIyJzCtG+pJyAvaPaMuvpXgz4OJ3M0JaA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=u6OFIDOaIaj/zUecjHYavG6hXt6oRTmZOnzyaM9GqfM=;
 b=YPBRReCQiW3d70hUcnN0+YiRg4/v/KfrS4V816dwDlk7s1c8JLjPQzE2ygv1dZBS2IEu+gRX0zrd95Z04nmxZdjGEEEyvuDyxPtiU0o4VHkvBd3Ra711M7wzv2DeRHFyVax3z/vqruzQAppwt/kmnGc406BJgAZfehmslSdaDGt5qEDM03WMqfHQG7iJC0CxOLrub2yelbdzJylC34zWIt82qo8g1IJ8hH7SK/NOisw7NmTfCMIZ2E94euVBG3m3Hff7D3AwbXnaZJxfX9fvFjxyhtMf/de0fo981cq01Bp3cRf6mvo0ndjmIglgQ46JvOsoHOz1uSFZGS+D69UqBw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=u6OFIDOaIaj/zUecjHYavG6hXt6oRTmZOnzyaM9GqfM=;
 b=idPnTq5ao7UTBNDkeUYAGiHpEOz0riykgeS3k0gzAH7qj3VP4x+Mk84yvKm5YOUO22xNBZM+4/O6+Nhba+ky5a27D5x68cPLT3Id40959s681Ug/TuNoHuz0NVYP+FdBMUXRf4ru1OnlMqc02nkH62zVIwxPqJvSVbNWpGL6dsI=
Date: Thu, 24 Feb 2022 15:53:37 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Paul Durrant <paul@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>, Kevin Tian
	<kevin.tian@intel.com>, Oleksandr Andrushchenko <andr2000@gmail.com>,
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH RFC] pci/ats: do not allow broken devices to be assigned
Message-ID: <Yheb8Z2oNwypwHFd@Air-de-Roger>
References: <20220224124344.86192-1-roger.pau@citrix.com>
 <3eb5e059-b37c-27c9-5c1b-0ed92b9edfd0@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <3eb5e059-b37c-27c9-5c1b-0ed92b9edfd0@suse.com>
X-ClientProxiedBy: LO4P123CA0508.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:272::10) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 891d14ef-9fff-48c9-1889-08d9f7a5732e
X-MS-TrafficTypeDiagnostic: CY4PR03MB2440:EE_
X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
X-Microsoft-Antispam-PRVS: <CY4PR03MB24407F32FF7D9B66D56082A28F3D9@CY4PR03MB2440.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 41J9V6WDPW5CWwjz4Gw2aEmXPc1EEFvV9J/Szql3rnws3vYC6J2oQfUN5c9XmrVUE+ydwLxEQrRsWbq/nRluuxCD8QNrS41BVEDRn43z8MH64a0FBYPDYEzT7EoYolZbLgPmHlbEo4k9Ji0Ob6eaBUdNcVCGgDshRZi+joi28DtHUtd5XVnnTls6UH+JCvN7XbESWdSq8eRgwXemYBgq3DwxxgslO8tciJMl/hl9DQ/sMF7yxve5fJCkOXWf0WTbu9XW9fkSmzF04qFR4XEGkXzfr/WwgRnBzAEKVx9jnib15F3eVH3eZP3zsjqETQSMQw26WxQx0HrZ17Nwitr9uimxXHk6ATX9N4zgRz8r0E5BtSUuy/DsJdPOnjw4vJ4w6azGgs2zb5wYQzEgHeiPU77G6cmTTgWBzMlOh2Ys7WfBVF5QqQGvp4bN2CgGKOidNcAJvCGKlg/7hCRUqYovS2jEsOczBTmbKPtdIcM/rgr0O23jogdwTYbIbjDKxBSXXvzvbKwXrOEAQbg7YWHehlFnqgZLIFlUD1juCSyf3Jb6KCtB3duXCsRdoRXj6tZzPxjREzQmxspwuLG2IMKRDhnAwnzOjT2zYbKUbvtjINvrO5Emzk1iZELjaDm7XqfiCoUgBv3PBKrCZ19H/HjNQg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(5660300002)(53546011)(83380400001)(6916009)(2906002)(6506007)(6666004)(8936002)(54906003)(85182001)(6486002)(4326008)(66556008)(66946007)(26005)(33716001)(38100700002)(9686003)(6512007)(316002)(82960400001)(86362001)(8676002)(508600001)(186003)(66476007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eUxESlRzQnRrNGd6d2dVcDlFbi9lME5RQ0xndWp4SXdJb2lLWjlnd1dxb2tY?=
 =?utf-8?B?MVBBclRJK05ZREptQi9pUlVtdk5Mc24ySlN6WE9kWGZzWEkyaWJHNmdmZi9H?=
 =?utf-8?B?VTdya1Uxb2lIbGNsWjIvcVlmVEU1eXBFT2h6cE9lNmhENUswaS81bmFzUmNs?=
 =?utf-8?B?L3o0TmZxSDBmcm15dEo0ZlZkZEJ0aWRSM1NYQy9Kc0gwcWNka2cvekN4WllP?=
 =?utf-8?B?cWFjbUxDM3U5MVNoZ0h1NkUrUHkrMmxvSkQzdWVOdUEvUGRnTXVhc1lWUmNZ?=
 =?utf-8?B?ektXeko5TTBjQ3I0b25XU0FKTktaSktZN0pvMS9qZk1vczlBbWhXa05DMGxF?=
 =?utf-8?B?RCtHU0lqS3RtUXpZdFNab1NQcElnNDZMaHNLNGZRQi80Y0ErdmQ1S2QzdkJy?=
 =?utf-8?B?THk2djhwVjlDWnlnWmROMG12dDZvVTZMN0VYN3dFNUdicUJaNjE0MFJXN3RK?=
 =?utf-8?B?WjJueGRYcjJuTjA2NzFtaW1HRnJkNnhhM1FRNVpnUEl0VlFvdGZlRVhnbndy?=
 =?utf-8?B?aUdDaytBckt1bVlMZThnV2JUeVZuQzRPNUxmMWtoL1ZrR2Y1eCtuUjAreEww?=
 =?utf-8?B?c2t2OEJoM1BZMUtvMFUrSVJsS0dGK1h0SzJkdlVjbEJISklSNStlM1l3OXJq?=
 =?utf-8?B?M2s2ZUs1aytPSTcvSWkzSStyVlhBcmRVL2ltUExnTGpIODhBdGpMbUNQNlRR?=
 =?utf-8?B?Yi9USHY5dzJJVWxEbjJzczl0czBrR0J5NjBpc0VsNHI5LzFxMEN6dmdaaTBL?=
 =?utf-8?B?VU5IRDRjTGtuV0xyL1ZPMmNQcnR0V0EwMmY2ck9PaXVFcG1UcG4zNXhLbDk5?=
 =?utf-8?B?TS9DN1VQUVFvQWtlSVdoczM2TWVhYXNUVHYzTnZnajVlc1Q1WFE1WDhDOEtQ?=
 =?utf-8?B?STBhc1c5akRHU2VVYkNtNUxURnpPdGo3VDE1TU1wZlhzRS9TSlQ3SkFpSk5F?=
 =?utf-8?B?SlRzYkVsUWtYTkVLTWNLaHNWTjBQYW56SkcvV2FuRThGYWRqcEZzUHJkREp2?=
 =?utf-8?B?eGNUenIvR0VnZmIwODM4ZkgzczdBY015OEZyRWZKVXRxWkFHbW9wWDVVY20x?=
 =?utf-8?B?cTRyTEsvV2JtQjFsVnMzRWcyZ0pBSTRtdDFZZGd6ak5aN3F3eHNJc2FSRUJz?=
 =?utf-8?B?U1Bpa0dnNVFES3NhZmx1UHhXZnAvUTdhWnFOSm5hT2ZlRmhRaGhLVjR5WlIv?=
 =?utf-8?B?SEJHN1Bwc3REQ1VCTnRyMG1OTHFPdkI2TDl0WEJDYU9MRE8vbFJSNDF6M1B2?=
 =?utf-8?B?Um9wSmxiaDhmb3p4endsdFFVOGZ5Q2h6Y3NqR3hva0ZiQmZ4Qk5BdFRiUFZZ?=
 =?utf-8?B?Q0h6WFFhb1plN2JvYW9odXN4ajRTOTJVRnVMOG1UODcrdjdiZGg0TS9nRWU5?=
 =?utf-8?B?dlcwNFAzZS9lTSsrWDRjQTBqV2ZwOVFkKy84dFlUWU84TnJzeUdzY253THl2?=
 =?utf-8?B?OGtNK3Y1S0JSOWFadGtaTmlOOUZVTk5oTmtOTGxJOUs3SE05a3hGYnpEbmdk?=
 =?utf-8?B?cnRDWUg4KzYzNW95MkxkdXpZSWdpVHNkcHZyei82L3pUd2tSSHFQWm1Vemor?=
 =?utf-8?B?RlZxRU1pWi9sS1hDUGxlMEFCYzIzVUlIZ2JJU2ZiZ09HQkR3cm1CYk9lN2JZ?=
 =?utf-8?B?Qmx0VTJvK3VNVCt2bVVDUElpR2F2bnJaRUIzSytneS8vcFV2STd0c21qVW1h?=
 =?utf-8?B?V0ZheGkvM0dSMEdvUGFwTkIySlJXcHFQRHN4RXo4WXBPTFNhWEg0NFpLQ0hL?=
 =?utf-8?B?UWdONUUyMm5qYllZcm5zcXF2RlNnMm5POWhPQWI4b0Y5MDg5dXBQV2Y0M3Q5?=
 =?utf-8?B?RnhFbzdOUU1Qa0hnMDNWckR2QUkzcE5KQXdPUVRvRHRHL1ZxOGwzS3RRaml6?=
 =?utf-8?B?TEw4V3kyM0o0NytLTThSckpGRjZGSjZLNG5aeUpSejZLUVEzR2VSZ0FzaEUx?=
 =?utf-8?B?V2R1TFo2VngxVVd0YzdWZ2VCSjZNVmV6NmpxU1VlWDY1RmVrTURBenZkZjRq?=
 =?utf-8?B?S1E2RU5leVdvMkUxRU83UUpUZWEvbDJrY3VHL1UyREpKNUhnVjVCNFZob2Fz?=
 =?utf-8?B?bDVXSlM1VTg4Q0FkUWM3bUVSZGRwcWJLelBUUFVDWFd3U08vMlRxOU8zK1ZE?=
 =?utf-8?B?OGtMRUhPb1loMnNyYjc2YjA1R3dVQ0RRMyt2U3dUTzZiRitnLy8rWWlwaURL?=
 =?utf-8?Q?cvyF+x57AvQ9OoIqis4FZy0=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 891d14ef-9fff-48c9-1889-08d9f7a5732e
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2022 14:53:42.5263
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iCABRVlsXPlqcwsQZvA1zn/Y1sSBEjr6uiJyvuP5oCfTQ+PRoQR9pw8nAbfnPtXXnb0Q0DO2IW3V2Xvq52TQSg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR03MB2440
X-OriginatorOrg: citrix.com

On Thu, Feb 24, 2022 at 01:58:31PM +0100, Jan Beulich wrote:
> On 24.02.2022 13:43, Roger Pau Monne wrote:
> > Introduce a new field to mark devices as broken: having it set
> > prevents the device from being assigned to domains. Use the field in
> > order to mark ATS devices that have failed a flush as broken, thus
> > preventing them to be assigned to any guest.
> > 
> > This allows the device IOMMU context entry to be cleaned up properly,
> > as calling _pci_hide_device will just change the ownership of the
> > device, but the IOMMU context entry of the device would be left as-is.
> > It would also leak a Domain ID, as removing the device from it's
> > previous owner will allow releasing the DID used by the device without
> > having cleaned up the context entry.
> > 
> > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> > ---
> > RFC: I haven't tested the code path, as I have no ATS devices on the
> > box I'm currently testing on. In any case, ATS is not supported, and
> > removing the call to _pci_hide_device in iommu_dev_iotlb_flush_timeout
> > should allow to remove the dependency on recursive pcidevs lock.
> 
> No objection in principle. Whether this is the only dependency on
> recursive pcidevs lock isn't really know though, is it?

Indeed. I didn't word this clearly. The recursive lock was introduced
for this specific use case. Whether we have gained more recursive
paths in the meantime I haven't assessed.

> > TBD: it's unclear whether we still need the pcidevs_lock in
> > iommu_dev_iotlb_flush_timeout. The caller of
> > iommu_dev_iotlb_flush_timeout is already bogus as it iterates over a
> > list of pdevs without holding the pcidevs_lock.
> 
> Analysis of whether / where recursive uses are needed should imo
> include cases where the lock ought to be held, but currently isn't
> (like apparently this case).

Well, I'm not opposed to that. I think just aiming to get the current
usages analyzed will already be hard.

> > @@ -1487,6 +1487,11 @@ static int assign_device(struct domain *d, u16 seg, u8 bus, u8 devfn, u32 flag)
> >      ASSERT(pdev && (pdev->domain == hardware_domain ||
> >                      pdev->domain == dom_io));
> >  
> > +    /* Do not allow broken devices to be assigned. */
> > +    rc = -EBADF;
> > +    if ( pdev->broken )
> > +        goto done;
> 
> I think this wants exceptions for Dom0 and DomIO. An admin may be
> able to fix things in Dom0, e.g. by updating device firmware.

Doesn't a device get assigned to DomIO (or Dom0 if not using quarantine
mode), and then when deassigned from DomIO gets assigned to Dom0?

So there's no usage of assign_device in the path that (re)assigns a
device used by a guest into Dom0?

Or would you rather imply that pdev->broken should get cleared at some
point (ie: when the device is assigned back to Dom0)?

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Thu Feb 24 14:56:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 14:56:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278343.475546 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNFXh-0002we-8q; Thu, 24 Feb 2022 14:56:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278343.475546; Thu, 24 Feb 2022 14:56:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNFXh-0002wX-5h; Thu, 24 Feb 2022 14:56:29 +0000
Received: by outflank-mailman (input) for mailman id 278343;
 Thu, 24 Feb 2022 14:56:28 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nNFXg-0002wR-29
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 14:56:28 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nNFXd-0007sA-AV; Thu, 24 Feb 2022 14:56:25 +0000
Received: from 54-240-197-225.amazon.com ([54.240.197.225] helo=[10.7.239.15])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nNFXd-00007b-4S; Thu, 24 Feb 2022 14:56:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=6u5CC6sXY7MiFuExm3CiWvMNcdHodeFsJMFX7cjkLFk=; b=yZy55ahaUKtCNviYayfmyj8I7V
	X3EZd9QTsi4+J/+obvl3dLb3Ayh/Oh9OLxRR5K9BzumcmM+qwIqZFZyiTw1FrOfEtcnLUJu0kV/f/
	6pA0midppevoyR1lQIlnU2jUQPHB06w2Xiq8sdLJ3EnNph8CbUAHDFCupoNAh1i09DLc=;
Message-ID: <2a041673-c9ab-2699-a080-b170acc8df25@xen.org>
Date: Thu, 24 Feb 2022 14:56:23 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.1
Subject: Re: [PATCH] xen/mm: Remove always true ASSERT() in free_heap_pages()
To: Jan Beulich <jbeulich@suse.com>
Cc: Julien Grall <jgrall@amazon.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220223183831.5951-1-julien@xen.org>
 <6befff41-528d-015c-3c41-f643c0b98530@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <6befff41-528d-015c-3c41-f643c0b98530@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Jan,

On 24/02/2022 08:27, Jan Beulich wrote:
> On 23.02.2022 19:38, Julien Grall wrote:
>> From: Julien Grall <jgrall@amazon.com>
>>
>> free_heap_pages() has an ASSERT() checking that node is >= 0. However
>> node is defined as an unsigned int. So it cannot be negative.
>>
>> Therefore remove the check as it will always be true.
>>
>> Signed-off-by: Julien Grall <jgrall@amazon.com>
>>
>> ---
>>
>> I have looked at the history. AFAICT, node has always be defined
>> as unsigned int. So the ASSERT() may have never been useful (?).
> 
> Commit f0738d2d3f81 introduced "node" as a local variable of type
> "int". Along with this commit f1c6ac275100 introduced ia64's
> paddr_to_nid() (backing phys_to_nid()), which was able to return -1.
> Hence at the time the assertion fulfilled a purpose. I should have
> dropped it in bd3e1195d694.

Thanks for the information. It looks like I need to brush my git-blame 
skill :).

> 
> Acked-by: Jan Beulich <jbeulich@suse.com>

Thanks!

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Feb 24 14:57:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 14:57:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278349.475558 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNFYc-0003Vt-Ig; Thu, 24 Feb 2022 14:57:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278349.475558; Thu, 24 Feb 2022 14:57:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNFYc-0003Vm-FE; Thu, 24 Feb 2022 14:57:26 +0000
Received: by outflank-mailman (input) for mailman id 278349;
 Thu, 24 Feb 2022 14:57:25 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nNFYb-0003Va-Dw
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 14:57:25 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nNFYb-0007tE-4v; Thu, 24 Feb 2022 14:57:25 +0000
Received: from 54-240-197-225.amazon.com ([54.240.197.225] helo=[10.7.239.15])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nNFYa-00009p-VO; Thu, 24 Feb 2022 14:57:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=xN44zTEGexWQoSVGQ2gdhImddspwnroyGtYceSVk6bk=; b=2S+SyKTmhNnB7WndeyfZTntLgG
	ESM654DtshuLE8aaaB0Lxfvk1iY9gFF/bzriH16/oLpF8BdmpvCKB6lS+R7y35tyGQ3rQCfi7b1aV
	KOk78/KQ4Zo/arwlYTjt1Rnphm+h1PubYFr85AuQE63oZfg5gXDizh89jYaFg635P16I=;
Message-ID: <79604328-4e3b-49f9-35ab-afe9afa40d64@xen.org>
Date: Thu, 24 Feb 2022 14:57:23 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.1
Subject: Re: [PATCH] xen/mm: Remove always true ASSERT() in free_heap_pages()
To: Andrew Cooper <Andrew.Cooper3@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Julien Grall <jgrall@amazon.com>, George Dunlap
 <George.Dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
References: <20220223183831.5951-1-julien@xen.org>
 <a3f52f29-3280-89b6-5db5-de224dd037cc@citrix.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <a3f52f29-3280-89b6-5db5-de224dd037cc@citrix.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Andrew,

On 23/02/2022 19:30, Andrew Cooper wrote:
> On 23/02/2022 18:38, Julien Grall wrote:
>> From: Julien Grall<jgrall@amazon.com>
>>
>> free_heap_pages() has an ASSERT() checking that node is >= 0. However
>> node is defined as an unsigned int. So it cannot be negative.
>>
>> Therefore remove the check as it will always be true.
> 
> Coverity-ID: 1055631

I will add it while committing.

> 
>> Signed-off-by: Julien Grall<jgrall@amazon.com>
> 
> Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>

Thanks!

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Feb 24 14:57:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 14:57:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278350.475569 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNFYn-0003s0-UM; Thu, 24 Feb 2022 14:57:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278350.475569; Thu, 24 Feb 2022 14:57:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNFYn-0003ro-QG; Thu, 24 Feb 2022 14:57:37 +0000
Received: by outflank-mailman (input) for mailman id 278350;
 Thu, 24 Feb 2022 14:57:36 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=VLhp=TH=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nNFYm-0003qa-17
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 14:57:36 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 194ff52b-9582-11ec-8539-5f4723681683;
 Thu, 24 Feb 2022 15:57:34 +0100 (CET)
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2058.outbound.protection.outlook.com [104.47.1.58]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-14-nppXZKK8NYC3cCTVSdAEXw-1; Thu, 24 Feb 2022 15:57:33 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM6PR04MB4390.eurprd04.prod.outlook.com (2603:10a6:20b:26::29)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.24; Thu, 24 Feb
 2022 14:57:31 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.024; Thu, 24 Feb 2022
 14:57:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 194ff52b-9582-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645714654;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=1WxRjnE3iiiG2IlHgxZ2cvxARg4aOt8ZNoyJJ+P09Wc=;
	b=j1qfAHzhE/mPDnHuvlxd8nu3nS6mGW8LCXVqFYEO0VYBLeeFj2NG/FaIc1BSHGhFtpx1zF
	qN4fALnqoj/p4mRvnBT2XUS+oZUk2I6BlVnDqnk9H6gdQvqiKusOW/ROP5F2kFXAHHnwa1
	u/gu4rgysKQO08Qn12qVD8FRmggBx74=
X-MC-Unique: nppXZKK8NYC3cCTVSdAEXw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=NmubvLDdHLqURyfHrnsIJ0Sb2rRbsLIOIVuWO8OFQMJCW2MslIeSnYTH9DaYmldY1OEQL5ylXMpB8B6VrtpXFbrSqdv2eDP6rGfsO5ya/vX32B1sPSvNPTduBOFiaa25Tl+e6LcXZ4EX0pC/lLASsucTRIBQrRjz9IfkcPsrQKWDgNVqFZ2AYyjBreSa7GvfQSXbM9GrR7Hmq4Y34FmxieOQ+h7xqYYbNX81/+LKZObCzEC9Mir3hktgnKVih8cmidwZHhXPuGDmjccSD0HuOoilbpobTip4S/lPAfIK6vD4AIME2IDDkv3ie0eUXX4OQkSGdWmRaHl1uSivS3Excg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=1WxRjnE3iiiG2IlHgxZ2cvxARg4aOt8ZNoyJJ+P09Wc=;
 b=Awn5gS3dVCs4Jn12lTZZbuCYgKsUXTUq5ynTje2emQBKbychjXcMUjTIDmQ9Gt6+DULlxpbDAhZiqv2gJRhPAJMbZQ61wtR4ewrDwz8j2KvMV6tLv+fyD+Xu6cCzqur7nzraewyFmwbhNRBfM84eVTkudwl2imV7xVX+pSFambTbmMGeIRyBDrbT92FFBTl8sNYs3OfZiR+02FekTziCSnVICmWSuANzqwrC0Ot2Z9kE4rtWYB+k0PWB9t/DfJmZ2up+TvauTnapqtlNKsYMHF0pwC9GeqbDGMMDinkxk+eiOcCE4UXwuF0yTtnT2UeOEzUvwX64iv8P7fJaaCYs2A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <6e188f87-7e4c-00ee-dd0c-373d42acec34@suse.com>
Date: Thu, 24 Feb 2022 15:57:29 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v2 1/3] xen/vpci: msix: move x86 specific code to x86 file
Content-Language: en-US
To: Rahul Singh <rahul.singh@arm.com>
Cc: bertrand.marquis@arm.com, Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, George Dunlap <george.dunlap@citrix.com>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 xen-devel@lists.xenproject.org
References: <cover.1644937405.git.rahul.singh@arm.com>
 <4d2a727ba218468e4f347dc12ca051a0534fe205.1644937405.git.rahul.singh@arm.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <4d2a727ba218468e4f347dc12ca051a0534fe205.1644937405.git.rahul.singh@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR01CA0038.eurprd01.prod.exchangelabs.com
 (2603:10a6:20b:e0::15) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 32c190d1-4b38-4837-2170-08d9f7a5fbc6
X-MS-TrafficTypeDiagnostic: AM6PR04MB4390:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB439062EE61DC9E98EBB4FAAAB33D9@AM6PR04MB4390.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	lMgsOTtKfy7znAk/xmqUK/hUVe5s6IHU6pP3iesAk1DZM/+eOJ9+wsWMw0fZJsfjICq61aaKfyhFsaAECOKh7XBgdoDny8AW+LtRS7YkifoH9pm5xW6WGb+KvXpW/+6n2ybY+yRDp9kel7h52Rpt9CvRte2U/C1lEoT8Oz85NVkw38kJSMLyKoAGMyXaPBvJpneQBaJTARwXZ2//oGZN/b+KffbyodK4p5CAnYerZT1NuuDLLfSrgSgM3R7qxGN/a3W/IYardEx/sxBJkN7QLxsGuM7rqltQWtkw/4shxPxLj4fGxglntuMJQzymoggTji4vdX2DqbAcOcXpYFmT6vhKAGVEW98fJNe3pi+oOMskXTy6Uddl/qhMO0YOSlxeYepSqd+D8Lec3Jg8kTsfTJ63+JKFIgeBuylsheQ99Tn/NvgntZ2x/2J2Ju85H7EM2tTJLGhgdzznjEW9NjDRZ8DpT0Vl3lN7Z1O3/EktcHCY3YtFd/81AFSGHBXL3xqcooHA0/bZarDtwNAvQB7xa1wXjDHWf56dlFrUX741xHoj7Zz1U8oz8kqJTaSmSpHGf2mhJdQL/YlCAt1SxxZuvB4EavEUBXruAZOAFcR+FnOH8ihkA05L5ZPYTviY9BGK5hT3XPg27ymF28e0RK86fabfgcG8pNRaN8y07/TdDA/gzINIEGVMSWKtIEA+vZXQ1uWLAlpM6pkjsP1oyYk8b7zhf390kR8pSxIcakgnQClLGoSo53fTMBrouXjE6YFK7WS/qGwlErIU8NiLKHgWzQ==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6512007)(8676002)(2616005)(66556008)(36756003)(5660300002)(316002)(66946007)(8936002)(66476007)(26005)(38100700002)(186003)(31686004)(6486002)(53546011)(6506007)(31696002)(6916009)(54906003)(2906002)(508600001)(86362001)(83380400001)(4326008)(45980500001)(43740500002)(309714004);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZDV3ZUswTlRiMHBOckJVdFYxbW1tQmROWmovZjFIT2pwazhEZXFDS3lYWjRZ?=
 =?utf-8?B?ZjdidkZ0aXo0SEpLQ1BYMWppMWtlOC9VWXNmVllJaXpCSURKb1dVTm5FNFdV?=
 =?utf-8?B?ZDUyZjBXVDlPaFpPMDZQY2VQcXp3T1ExVmt2dys2ZjBCQ1l4OTFVVC90cXBy?=
 =?utf-8?B?RXhkWE53aW52TnVsNFhlakdBNEI0UW0rNkZza1ZWZkJ3ZjY5aE12QVQ2RnRl?=
 =?utf-8?B?by80UDJRSSt3ekNwMUx1cDBxcjVDeUh4b282MlVYNmxVTlU2Vm1BR0tTaUFm?=
 =?utf-8?B?V3BXL3cwTm5oZlBpTWdzZFJXQ3IxQ2FiK29sYUZPSDA2U09zSmFLM254V2pP?=
 =?utf-8?B?RWplQkEwQ2RjTWp5bjd6eGp4MFIxeEI2YXlwMzdPY0FkWkFFTzRCTnlOR2tT?=
 =?utf-8?B?YUhFRStPa2xjOUN3ZkFQdnVCL0ZYT2czMUJwam5MbGF4U0k5SWRHR1FmZGlu?=
 =?utf-8?B?L1JqZnN3VzlUeFQxRytFNTYxZis2R201M1FBV2l0NVdVWmN0S3pia2x6RHVN?=
 =?utf-8?B?R0NUTXJQdWtuRkVkcnZvNmRQbEhYYWhhdmQzSDlwV2orY3Y0M1k5aGJRSEtK?=
 =?utf-8?B?ZHJ2V0hycDlzMndRTlk0VytFZGpFWUxCL01uRFZkVmlnOWFuS2p0Q29BdFRR?=
 =?utf-8?B?NHZNRHdwMWYrVFRBam9WYXJsN0ZtN0wrckFYSWo3TjB1bEM5WWFETFhqYzZM?=
 =?utf-8?B?eXU5QXJyclBibjNuaGUvZTYwbVk4aWpQYmdGZWRTT2JZLzBDcC8vR2ZWQ3Yx?=
 =?utf-8?B?ZnFvKzlsY28zemJXZ1huOUU2YkZnelUySzVVUlBjWGk0S3pDK0JNSjg3bzdQ?=
 =?utf-8?B?RnNjYjhVZGZuTnVhM1R5UWRMekpMcjYrTFdFY09qRHlzL1EvRk9jdFYwZUVi?=
 =?utf-8?B?OUliU2s5VnMyR0RaZ0lPdTJscHBRTmNUdTllMXpYaVBsQS9xbnBxcThKbkhk?=
 =?utf-8?B?RWRmdVRsOERteHhRSFJHRGVvbGlheVVGQ1BjR0pNNXV3bXBvMEtIckd4RTk1?=
 =?utf-8?B?aUQza1NJaTJXTFgzWmppb2pTV0xZVGVtTjE4ZHh3eTk5N2dCc1F3N3A2dmk3?=
 =?utf-8?B?VUJCWUpaQ21zTEY0Mldja1FNN0o4NklIMmhIbHQ1YmZVbVlWUmM4c1VNNVlu?=
 =?utf-8?B?RjJXS0xNZTJKYzlnbEh4c01Cb0RvVFdqZ09EVW9nbjZvS2xvVHJSWWlpM0dw?=
 =?utf-8?B?Z0kxK2NLWEVnK2VoMDZlMVlodlBFak5ZZVF4VVVGSHpUU1NpTXVLSCtrK2Jo?=
 =?utf-8?B?WHdmS0taa2tjRVltWXA2ZmdiTnVWT2hhQ25jTmpWeUtPZkt3ZWcvdFlrckN1?=
 =?utf-8?B?ZlMzWUhPNzlhR1B6cWRnK1J1N2pCL0xDMWVpeERkNWd2VXR6WG1NcTQrUE1D?=
 =?utf-8?B?Y29JamErTzk3ZldkeXpYMXd2TTE0OVpHS212bDZNa09MWEpORi9ZZ1MvNWRt?=
 =?utf-8?B?d0hLV29Qa2djR1pMUXBzZ2ljWjNYOTh5eFM3MHErZDQ1KzVuMURDVmNXRHVp?=
 =?utf-8?B?ZUF3aU16Z3ZnMGFCYk1rQkE1bzE3dVJnMDhWZzJ4MlFIOTlQdFhXcStMSFMw?=
 =?utf-8?B?Y21RK3BaUXFIL3VhdkdrZ0EvY1FteW92YXV5VS9WeWlERDFEa3lCWkVGaU9q?=
 =?utf-8?B?YktBdUJXVFFHbUM3WGt2ZUhFMmZvT05pNEhhK2hKQVk0QWk2UDVpNlBnVlNt?=
 =?utf-8?B?THNaR0doVjdBVThvSEJ1V1Z6RFdCWnJOMHVOazlTRkpvOHBzdkI5aHVmcndU?=
 =?utf-8?B?THhGb0F3bjN4ZmxXU1VwRGt2dUdyZ010alBQMnJxYWpVQW1OSWlHU0g0R2pt?=
 =?utf-8?B?RklzOTd6UTMyL2JvaWZ3VDc2cnFqZkdtRkZaV2lLZXNEQU9VZEU3WEtoSWlW?=
 =?utf-8?B?SklMQWV3VmZZQXFmRXUzMk0rNmZ3V0dzUjl3Tm5YcmJCaEtxNDcrazhIVjZS?=
 =?utf-8?B?SFVhUUZHNWpKSnJmclNHOFBEQ0swT3ZMTktQYWZVL1VVVVJJMFFqZUJ1SEVW?=
 =?utf-8?B?a3J0Vy9idnNsb3ZDU25JV2NxK1V0b21FRDhwSk5qOWhkVjFYNW9wMnBEbkNO?=
 =?utf-8?B?a1Q0dnVTVTUzZzg2Yzd0QXk5RDhSVkdTVkp2YzR6UzlNbndiaWxRQloxNVlS?=
 =?utf-8?B?b3lzNENDSjd0VEpGT09kVG5NUVpVMVAxdnJrSXByd2pkelBiZ3Zzc0lnYXRE?=
 =?utf-8?Q?W57K3VgUKJd7y7wvV5H1s0Q=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 32c190d1-4b38-4837-2170-08d9f7a5fbc6
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2022 14:57:31.6772
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: otEhQANci150vu2+bmRQZc6r3enz6+QLDMobVV22AHYucXr0EBaTiwWOa5asLnLsqa73BBRj+oqi8e+jeG+XiQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4390

On 15.02.2022 16:25, Rahul Singh wrote:
> vpci/msix.c file will be used for arm architecture when vpci msix
> support will be added to ARM, but there is x86 specific code in this
> file.
> 
> Move x86 specific code to the x86/hvm/vmsi.c file to make sure common
> code will be used for other architecture.

Could you provide some criteria by which code is considered x86-specific
(or not)? For example ...

> --- a/xen/arch/x86/hvm/vmsi.c
> +++ b/xen/arch/x86/hvm/vmsi.c
> @@ -925,4 +925,106 @@ int vpci_msix_arch_print(const struct vpci_msix *msix)
>  
>      return 0;
>  }
> +
> +int vpci_make_msix_hole(const struct pci_dev *pdev)
> +{
> +    struct domain *d = pdev->domain;
> +    unsigned int i;
> +
> +    if ( !pdev->vpci->msix )
> +        return 0;
> +
> +    /* Make sure there's a hole for the MSIX table/PBA in the p2m. */
> +    for ( i = 0; i < ARRAY_SIZE(pdev->vpci->msix->tables); i++ )
> +    {
> +        unsigned long start = PFN_DOWN(vmsix_table_addr(pdev->vpci, i));
> +        unsigned long end = PFN_DOWN(vmsix_table_addr(pdev->vpci, i) +
> +                                     vmsix_table_size(pdev->vpci, i) - 1);
> +
> +        for ( ; start <= end; start++ )
> +        {
> +            p2m_type_t t;
> +            mfn_t mfn = get_gfn_query(d, start, &t);
> +
> +            switch ( t )
> +            {
> +            case p2m_mmio_dm:
> +            case p2m_invalid:
> +                break;
> +            case p2m_mmio_direct:
> +                if ( mfn_x(mfn) == start )
> +                {
> +                    clear_identity_p2m_entry(d, start);
> +                    break;
> +                }
> +                /* fallthrough. */
> +            default:
> +                put_gfn(d, start);
> +                gprintk(XENLOG_WARNING,
> +                        "%pp: existing mapping (mfn: %" PRI_mfn
> +                        "type: %d) at %#lx clobbers MSIX MMIO area\n",
> +                        &pdev->sbdf, mfn_x(mfn), t, start);
> +                return -EEXIST;
> +            }
> +            put_gfn(d, start);
> +        }
> +    }
> +
> +    return 0;
> +}

... nothing in this function looks to be x86-specific, except maybe
functions like clear_identity_p2m_entry() may not currently be available
on Arm. But this doesn't make the code x86-specific.

> +struct vpci_msix *vpci_msix_find(const struct domain *d, unsigned long addr)
> +{
> +    struct vpci_msix *msix;
> +
> +    list_for_each_entry ( msix, &d->arch.hvm.msix_tables, next )
> +    {
> +        const struct vpci_bar *bars = msix->pdev->vpci->header.bars;
> +        unsigned int i;
> +
> +        for ( i = 0; i < ARRAY_SIZE(msix->tables); i++ )
> +            if ( bars[msix->tables[i] & PCI_MSIX_BIRMASK].enabled &&
> +                 VMSIX_ADDR_IN_RANGE(addr, msix->pdev->vpci, i) )
> +                return msix;
> +    }
> +
> +    return NULL;
> +}

Or take this one - I don't see anything x86-specific in here. The use
of d->arch.hvm merely points out that there may be a field which now
needs generalizing.

> +static int x86_msix_accept(struct vcpu *v, unsigned long addr)
> +{
> +    return !!vpci_msix_find(v->domain, addr);
> +}
> +
> +static int x86_msix_write(struct vcpu *v, unsigned long addr, unsigned int len,
> +                          unsigned long data)
> +{
> +    const struct domain *d = v->domain;
> +    struct vpci_msix *msix = vpci_msix_find(d, addr);
> +
> +    return vpci_msix_write(msix, addr, len, data);
> +}
> +
> +static int x86_msix_read(struct vcpu *v, unsigned long addr, unsigned int len,
> +                         unsigned long *data)
> +{
> +    const struct domain *d = v->domain;
> +    struct vpci_msix *msix = vpci_msix_find(d, addr);
> +
> +    return vpci_msix_read(msix, addr, len, data);
> +}
> +
> +static const struct hvm_mmio_ops vpci_msix_table_ops = {
> +    .check = x86_msix_accept,
> +    .read = x86_msix_read,
> +    .write = x86_msix_write,
> +};

I don't see the need to add x86_ prefixes to static functions while
you're moving them. Provided any of this is really x86-specific in
the first place.

> +void vpci_msix_arch_register(struct vpci_msix *msix, struct domain *d)
> +{
> +    if ( list_empty(&d->arch.hvm.msix_tables) )
> +        register_mmio_handler(d, &vpci_msix_table_ops);

This is perhaps the only thing which I could see would better live
in arch-specific code.

> --- a/xen/arch/x86/msi.c
> +++ b/xen/arch/x86/msi.c
> @@ -20,10 +20,10 @@
>  #include <xen/iocap.h>
>  #include <xen/keyhandler.h>
>  #include <xen/pfn.h>
> +#include <xen/msi.h>
>  #include <asm/io.h>
>  #include <asm/smp.h>
>  #include <asm/desc.h>
> -#include <asm/msi.h>

Just like you do here and elsewhere, ...

> --- a/xen/drivers/passthrough/amd/iommu.h
> +++ b/xen/drivers/passthrough/amd/iommu.h
> @@ -26,6 +26,7 @@
>  #include <xen/tasklet.h>
>  #include <xen/sched.h>
>  #include <xen/domain_page.h>
> +#include <xen/msi.h>
>  
>  #include <asm/msi.h>

... I think you want to remove this now redundant #include as well.

> --- a/xen/include/xen/msi.h
> +++ b/xen/include/xen/msi.h
> @@ -3,6 +3,34 @@
>  
>  #include <xen/pci.h>
>  
> +#define msi_control_reg(base)       (base + PCI_MSI_FLAGS)
> +#define msi_lower_address_reg(base) (base + PCI_MSI_ADDRESS_LO)
> +#define msi_upper_address_reg(base) (base + PCI_MSI_ADDRESS_HI)
> +#define msi_data_reg(base, is64bit) \
> +	( (is64bit) ? (base) + PCI_MSI_DATA_64 : (base) + PCI_MSI_DATA_32 )
> +#define msi_mask_bits_reg(base, is64bit) \
> +	( (is64bit) ? (base) + PCI_MSI_MASK_BIT : (base) + PCI_MSI_MASK_BIT - 4)
> +#define msi_pending_bits_reg(base, is64bit) \
> +	( (is64bit) ? (base) + PCI_MSI_MASK_BIT + 4 : (base) + PCI_MSI_MASK_BIT)
> +#define msi_disable(control)        control &= ~PCI_MSI_FLAGS_ENABLE
> +#define multi_msi_capable(control) \
> +	(1 << ((control & PCI_MSI_FLAGS_QMASK) >> 1))
> +#define multi_msi_enable(control, num) \
> +	control |= (((fls(num) - 1) << 4) & PCI_MSI_FLAGS_QSIZE);
> +#define is_64bit_address(control)   (!!(control & PCI_MSI_FLAGS_64BIT))
> +#define is_mask_bit_support(control)    (!!(control & PCI_MSI_FLAGS_MASKBIT))
> +#define msi_enable(control, num) multi_msi_enable(control, num); \
> +	control |= PCI_MSI_FLAGS_ENABLE
> +
> +#define msix_control_reg(base)      (base + PCI_MSIX_FLAGS)
> +#define msix_table_offset_reg(base) (base + PCI_MSIX_TABLE)
> +#define msix_pba_offset_reg(base)   (base + PCI_MSIX_PBA)
> +#define msix_enable(control)        control |= PCI_MSIX_FLAGS_ENABLE
> +#define msix_disable(control)       control &= ~PCI_MSIX_FLAGS_ENABLE
> +#define msix_table_size(control)    ((control & PCI_MSIX_FLAGS_QSIZE)+1)
> +#define msix_unmask(address)        (address & ~PCI_MSIX_VECTOR_BITMASK)
> +#define msix_mask(address)          (address | PCI_MSIX_VECTOR_BITMASK)

Why did you put these not ...

>  #ifdef CONFIG_HAS_PCI_MSI

.. below here?

Also the movement of these is quite the opposite of what the title
says. IOW this likely wants to be a separate change.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Feb 24 15:02:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 15:02:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278369.475584 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNFd3-0005dV-Ge; Thu, 24 Feb 2022 15:02:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278369.475584; Thu, 24 Feb 2022 15:02:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNFd3-0005dO-CS; Thu, 24 Feb 2022 15:02:01 +0000
Received: by outflank-mailman (input) for mailman id 278369;
 Thu, 24 Feb 2022 15:02:00 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=duXj=TH=citrix.com=prvs=047162a35=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nNFd2-0005dI-3g
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 15:02:00 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b56c2f9a-9582-11ec-8539-5f4723681683;
 Thu, 24 Feb 2022 16:01:58 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b56c2f9a-9582-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645714918;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:content-transfer-encoding:in-reply-to;
  bh=21F2oz9/DK47nSrfizyO+gjgcDYAtK4qeOHlEwA5G/E=;
  b=PAvIEHOH7Q99Ya+UD2n26pwD3oKW2F/9cJx0xF5Z8/xYHhooV315p1Ff
   yUgV/cyvk4A/oU9IDADzdDkQDR5SVRs3+7CGpF+fyj1iQCia1OTqor57F
   X7RRp9DuhAQ+ri66gFj/wtM2rSSvcdQwocrGGn8lRKDy+/Mw2k/UxaMfS
   s=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 64912939
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:5VPE1K+fJgfYizZ4apgsDrUDl36TJUtcMsCJ2f8bNWPcYEJGY0x3m
 DQbC2/XPfqPNGv2Ltt3OYXjoBtSvMfdn9NmGwNrq3s8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si+Fa+Sn9T8mvU2xbuKU5NTsY0idfic5DnZ54f5fs7Rh2NQw24LlW1jlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCnZ2PeBkNYaeLod8UYUFUTXBVF4pN6KCSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFIoZpnFnyyCfFfs8SIrPa67L+cVZzHE7gcUm8fP2O
 ZZIMGA+N0WojxtnfW45UYA6svyS3SfFSQRIlHLWqI4N/D2GpOB2+Oe0a4eEEjCQfu1XkVyfv
 Xnu5HniD1cRM9n34SqI9Degi/HCmQv/WZkOD/uo+/hymlqRy2cPThoMWjOTo/O0l0q/UNJ3M
 FEP92wlqq1a3FOvZsnwWVu/unHsg/IHc4MOSatgsljLk/eKpVbCboQZctJfQN0ZhdESGjZt7
 2SArYvlW21EmpqeWW3Io994sgiOESQSKGYDYwoNQg0E/8TvrekPs/7fcjpwOPXr14OoQFkc1
 xjP9XFj3OtL0abnwo3mpQivvt66mnTeoufZDC3zV3nt0A52bZXNi2eAuQmCtqYowGp0ozC8U
 Jk4dyq2sbhm4XKlznXlrAAx8FeBvajt3Nr02wMHInXZ327xk0NPhKgJiN2EGG9nM9wfZRjia
 1LJtAVa6fd7ZSX2MPErOd7rUJtylsAM8OgJsNiOMLKihbArKWe6ENxGPxbMjwgBbmB2+U3AB
 XtrWZn1VitLYUiW5DG3W/0cwdcWKtMWngvuqWTA503/i9K2PSfNIZ9caQfmRr1pvcus/VSOm
 /4CZpTi9vmqeLCnCsUh2dVIdg5iwLlSLc2elvG7gcbZfFI9QTl5U6W5LHFIU9UNopm5X9zgp
 hmVMnK0AnKm2BUr9S3ihqhfVY7S
IronPort-HdrOrdr: A9a23:I81Pk6q1I8JRWKciXjr6a4waV5oteYIsimQD101hICG8cqSj+f
 xGuM5rsSMc7wxhP03I+OrwXZVoLkmwyXcY2+Us1PKZLW/bUQiTXeNfBOnZowEIcheWnoU26U
 4jSdkcNDSZNykCsS+Q2miF+rgbr+W6zA==
X-IronPort-AV: E=Sophos;i="5.90,134,1643691600"; 
   d="scan'208";a="64912939"
Date: Thu, 24 Feb 2022 15:01:31 +0000
From: Anthony PERARD <anthony.perard@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Wei Liu <wl@xen.org>, Juergen Gross <jgross@suse.com>,
	<xen-devel@lists.xenproject.org>, Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH v3] tools/libxl: don't allow IOMMU usage with PoD
Message-ID: <YhedyyraKbiMo/Zp@perard.uk.xensource.com>
References: <20220217140923.22485-1-roger.pau@citrix.com>
 <e59dc35d-013d-1db6-a61e-c2e4504952b1@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <e59dc35d-013d-1db6-a61e-c2e4504952b1@suse.com>

On Fri, Feb 18, 2022 at 09:06:35AM +0100, Jan Beulich wrote:
> On 17.02.2022 15:09, Roger Pau Monne wrote:
> > Prevent libxl from creating guests that attempts to use PoD together
> > with an IOMMU, even if no devices are actually assigned.
> > 
> > While the hypervisor could support using PoD together with an IOMMU as
> > long as no devices are assigned, such usage seems doubtful. There's no
> > guarantee the guest has PoD no longer be active, and thus a later
> > assignment of a PCI device to such domain could fail.
> > 
> > Preventing the usage of PoD together with an IOMMU at guest creation
> > avoids having to add checks for active PoD entries in the device
> > assignment paths.
> > 
> > Signed-off-by: Roger Pau Monn� <roger.pau@citrix.com>
> > Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>
> 
> I'm inclined to queue this for the stable trees. Thoughts?

Yes, I think that sound good.

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Thu Feb 24 15:18:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 15:18:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278376.475595 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNFt9-0007Ei-Ve; Thu, 24 Feb 2022 15:18:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278376.475595; Thu, 24 Feb 2022 15:18:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNFt9-0007Eb-SR; Thu, 24 Feb 2022 15:18:39 +0000
Received: by outflank-mailman (input) for mailman id 278376;
 Thu, 24 Feb 2022 15:18:39 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=VLhp=TH=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nNFt9-0007EV-5G
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 15:18:39 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 09b07c72-9585-11ec-8eb8-a37418f5ba1a;
 Thu, 24 Feb 2022 16:18:37 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2050.outbound.protection.outlook.com [104.47.14.50]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-34-mmivI7VcOvG3eiIZ9-pZjA-1; Thu, 24 Feb 2022 16:18:35 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM0PR04MB5905.eurprd04.prod.outlook.com (2603:10a6:208:125::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.24; Thu, 24 Feb
 2022 15:18:33 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.024; Thu, 24 Feb 2022
 15:18:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 09b07c72-9585-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645715916;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=7beCHNBUSqMcb2FL3XYvk/0DsVD+l0nbGSQWf8CZ6uQ=;
	b=Dohw2OL4aRJCT4fwQ1pC4phBemw6WXFSh5HoOt0Z6Gt9SbKjfeuPMOsmioSbibLrLxcQD3
	rzZOWaUM9mFNlDI79CcdNM5a3QEdvMuaO/UYzpFfkGbVM7D5l5vBLbLsolNFx6jkXH6VUN
	0ImbWT35XCAOzB9wRuRq8KuEAS8GCHQ=
X-MC-Unique: mmivI7VcOvG3eiIZ9-pZjA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ducSf9fkaRqFtwuCqa1v/sSXXkRBvrRWI7vjWtWcuSvxut+czL97QEGeS82vDyosamAcgmaX62g3dc0mrjTP5Fo0dNwlnyn8JEMFxWvQDmMPMriDRtC7DMjetjZnRQXmzui+sZz5wafjGbHGJaSMHCf2dglO5u7lPR2CuLQ/Q62C8PjHYvIcQT1tXLvk4xuRy1TiORLkMhdpFr7Xr6pIzWw9aE3VEJO8YJkJ4j1C9LW4bqWqdz1pCn25flDK0tRkF7b4cLCQNVf5TpmGKy4Z+mECx6DiLXyNVkYDqbZMZeurOW34FS981J+v8h6Tu+O5/GkbCbqsGDq9Jd/uXvQZLA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=7beCHNBUSqMcb2FL3XYvk/0DsVD+l0nbGSQWf8CZ6uQ=;
 b=BWCJEjmYpD2rY0fASX9It+OU7Jbdki6rYOyqB8nijMZrayys7tHIWlhvPX8ObqpN01/MdErb6uR4bfpNQeUtesK6oQ6endgp7b8h0mGKbIDkg7BcF5T4UQlvZY/WW+NHP3TpoSvZ6uS4grhnpoqVDcebUSwxFZpL7azVcEsblXYafomzpZQKHxME0/eSVuXcm6OyOAar9XZRIAvfF94hwO89NRWHUNeyB84hFsWMqpyjA5iliCo2RUGF4hjRiZif+QpMvBbxVfJITd9SLYPPYa7PsJsYAbAG7OjXsz9S+QD3JBcSwZDR/KB5RfYW4tZpNo20aAlBHHrTCnkGyA3Pjg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <c8f54e83-95c9-04aa-d788-da755e284c42@suse.com>
Date: Thu, 24 Feb 2022 16:18:31 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v2 3/3] xen/vpci: msix: move read/write call to MSI-X PBA
 entry to arch file
Content-Language: en-US
To: Rahul Singh <rahul.singh@arm.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>
Cc: bertrand.marquis@arm.com, Andrew Cooper <andrew.cooper3@citrix.com>,
 Wei Liu <wl@xen.org>, xen-devel@lists.xenproject.org
References: <cover.1644937405.git.rahul.singh@arm.com>
 <3e47316052dce3c85bde04ab6b72ba4f48fa0bb8.1644937405.git.rahul.singh@arm.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <3e47316052dce3c85bde04ab6b72ba4f48fa0bb8.1644937405.git.rahul.singh@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0152.eurprd04.prod.outlook.com
 (2603:10a6:20b:331::7) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f3a0e2ed-ce1b-44c1-bba3-08d9f7a8eb90
X-MS-TrafficTypeDiagnostic: AM0PR04MB5905:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB590594F766EE7DCA929ECE04B33D9@AM0PR04MB5905.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	IFyXnlNs0Pd0mF4QI1i2Acs2rN5mfTyZ1qjXwGaKAvX7+ehooSwaMT7mRjC2T1rNE7GtmHwJ+ugjjGfQSofF+0uCvg3TjJQk+LGOeQ6fIMPcs6rbXrQ5f3tLWxcRIdC/EzQ/mchykGOKYMwCS8HU/zo5tEVS+YHUAlex8HRLhgvUdP42IRdwc8uOEY/uJwwCYszcy07R5U4KbFxEhmCTA0k+t14QIrpdY9EFhH1p7M/VTTqVsxTYV0RyrnEIV8SuqMOQlHQoXfMv5HmBucL3U4sm9ugptaDsVYb12K2rCGv4kfgfi62JQCNJizFoqox2MqQImU4QaxoqybWxjALJcNOLCNSC5ZPPmA4mjdEZchXNwAAytRZQbNymW2Aw8ODoszCj52xs6QQxB/+N+b3VWe2BhbjT2kWPLgGWMsKam202qaUMbEBIgSNk2Dnc/hPTN63edB6NVwpue2A+CM72iWsSDECAP6apBoj5qY68s9kzzyWIfA4UshcFoDPrcP/c4w+Lqc6Ott8pG8u4Vk00UuCfS9R05yrjVt4GFXm02VUdiu7e6ZRzsojFNUICzMamvCmwLXR0EveoPIDRxjvPjuyyVjOyQFjlopZe2rpFcVPwWX7IyUFFK4LrFiayXEHHpJ7Wn5cVChMrHSbXPUaXkIvj5OqeHB55TjyBcE9ugv3aG1oC1z2fNojcyjru/CLX5Plg8L+cxOFJfy1nnULZJYO0iA9gMpiBZh6C20t4CcmzOtLjoJxZNlKD3LsuIdtG
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6486002)(8936002)(26005)(6512007)(6506007)(186003)(508600001)(31696002)(36756003)(110136005)(2616005)(38100700002)(83380400001)(5660300002)(66946007)(2906002)(86362001)(316002)(66476007)(66556008)(53546011)(54906003)(8676002)(31686004)(4326008)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZGZxNkwrVmhaTWgyd1FYSmxPOXQ2QzFSREFhTVZ0MjMycDdHNVBRNTV4cEta?=
 =?utf-8?B?bm0vUUFnWGFTMXB6SUlJSU9jUEwxbTNuTkRkQTFMMTkyTnpXL0NRRW0wUUVY?=
 =?utf-8?B?aEk2RktYRUF0dUFnK2Z4cDVxK0REbjRGakh4Ky8rdG5RRnZHUVpVZkhUd2JT?=
 =?utf-8?B?dGJxeENGQjlOTUEwWFovdHVEcXY5NEFKclZibWdCalhxYzFZWUNMSWp6bW9l?=
 =?utf-8?B?aWpmam9ibnZHa2xLSjlRNnJQeXVlZjdPaFFoeEQ5bS9hL09OVFgvWlpmZ2Yy?=
 =?utf-8?B?bE1ya3BJTXQzTy9JYVBUWFo2S2RjN0dzQkJwRXl6dlduNnlrMHZqZWdYbXdl?=
 =?utf-8?B?dmpvbXdJVnF2Yko0dXVINVpSYTQ3QmMrZTlaRThUakZWUFk3VDJ2QTRIcDA2?=
 =?utf-8?B?VHZTSE1UUDJSaW5Ta0dvUTVFSXM2UkF5alh2cFpPaVp5aXdvWjkyMnkrcmRS?=
 =?utf-8?B?VGxPcjdZczZJaVhyMWhXWTVvb21DakpINGpPOW9XSnBUS3M2OStNbk9BYmVI?=
 =?utf-8?B?VjBid1lhVmNUclhVRkVzeS9VQXZ4eThkY3k4VlVWdy9FMFp0ZU85WUhELzd5?=
 =?utf-8?B?NGtUVVhab0ZFcE9VaVFLelVUU2RBV04rUG5oQlF0dzRUSCtGTmJrZE9YQU1a?=
 =?utf-8?B?QkoyYXBQUXNRL0hQSkQ3NHlBWVJrRktQUmkxZ0JvME42T2dDVXJzSVVJcjdC?=
 =?utf-8?B?MG93VE9RS2Q1SDdJSHhGeEF0Vm9DMG5QMUFlR0hTNkFXQ3V6Y3ZzRnVLTy8z?=
 =?utf-8?B?bHZwY0I1YWo3eDcrblVVYUpsbFkxTEVWOUdQOUJGVDN3OHRhM3Z4aFA3WjNI?=
 =?utf-8?B?dU9aTkVxSElsQ2pCK0pMdGhjUGovZTZPZzhlQW1KUlFLZHlIbjBoR1pLSUk3?=
 =?utf-8?B?czVrdWdxZDNuaFpOS0hKUm55VHVMRE1wbXROVmlaY2ZLbkdSUzlqL1JTMWVX?=
 =?utf-8?B?UkxQU1hyM2FBQjBEMDBzeG80cTllOVg1ZnY3L054RkhGclRBMk1iQlVxTWVC?=
 =?utf-8?B?T2VZRmhPbERwblVDSTJlVTBKb3Z2aGdjb0pybUY4aGRySkNtREoxNFpvTjhl?=
 =?utf-8?B?T1JJQ0ROaVFHVld2ejR5Y0JHY0VxbDQwSUtQQ0VhSGNMeVcvNFlocmIyVmt5?=
 =?utf-8?B?a0d6enE2VkQ0ZDQyWHVwbzdjNnkzTjFoSTJKV0FjazhjK2R1ek00K2hTSGdw?=
 =?utf-8?B?cFFKVU5sM2czODcyVFBIOUZqNTM4bXdOcm14bGswZHd3UnU1U1N2STcwSlBl?=
 =?utf-8?B?dVRZNVlSZk01RkNzd2JOS0tPeUhpRDlRZ1RBM1FoN3RsbGRscTkyTFQ2N3NB?=
 =?utf-8?B?N2JvbURLVU84R3l4YzhjQ3BvTUpKa2h4eEYrNkpHM1FrRmxqNjlHNVdtNDJU?=
 =?utf-8?B?dWZNakdoTE1jR0YyNHJZWmZXM3ZjbEhSVzhDcU5Eb29xYkhwUGZzdU1SMnoz?=
 =?utf-8?B?cVVENVRrS1doMnJTTDdramtMS3FocG1tSFVBSGhneG9pWnZvd1lQU3o4dmpq?=
 =?utf-8?B?ckNLRmVhaGpCeTRxNnZZUys0VWR0Um55cGk3ZlMrRTMrRS85SUJqTkpRbGFq?=
 =?utf-8?B?ZTNHaFVKZlNvNjFSbWd5ZEIzVFc4VWs5cTFXSkszV3VtVnZFMHZ2eG1MUXdO?=
 =?utf-8?B?NjZNdnBqRDQ3SHRTUDBjVGx6OWtxV1cyYko1aFZSQTB4c0QwTjMyTmRVTzZU?=
 =?utf-8?B?WnRtQktjNU1CeFFsZkgzbGtVanZzY2ZwRXhhOExtMUtSdGsyUUNIcnZ6cXVD?=
 =?utf-8?B?NXBQa21nSFRzVXNRWXdPUWdsMHRVRE5IS1kxOHZhaTNQL3ZsQ2lMT2NyLytm?=
 =?utf-8?B?NTZ0czlNV2lsRnVyWFN5bmxjNUExdDl6b3p5dWEzcHJQV3VDeTNKenpMU2dz?=
 =?utf-8?B?RmlhR2cyRVRDVDY0MTg2aVRqM3pnUDlxWS9pUE1TVUNWSkpsREdpcGRNbERB?=
 =?utf-8?B?UkpXVmFjbVFPUlhTbm1RdCtDSU00K0x4SWNhaWV3M0xlOHFrOEt1SUlTZW41?=
 =?utf-8?B?S01jMzZ0S3AyeVFJUTJXdVFrTm9qV0QyVmdEVDJTTFJOL2ZYRzE3VGdtdkdC?=
 =?utf-8?B?RnpYcmFCM1h3dmVhVS9WaFduWUNyNEtHZW1WOXlmTnE0bkxKUllSYmUvUThD?=
 =?utf-8?B?dWkvL0toZXdpazhkT0FoZmRXR29laC9YWnljQWgrTVQzZnU4bWppMDNuTXZB?=
 =?utf-8?Q?JE21sdW0ROhZdiin0m1gVxY=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f3a0e2ed-ce1b-44c1-bba3-08d9f7a8eb90
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2022 15:18:33.0364
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7f+hFp8MqJ0qwwKG2vfFoSnUU2jMBPFzjTxgg5HfkDndQHrc/sC+4FGpuy6V3IVGnxtBZHYaNUHyN3hV/xqNPw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5905

On 15.02.2022 16:25, Rahul Singh wrote:
> {read,write}{l,q} function argument is different for ARM and x86.
> ARM {read,wrie}(l,q} function argument is pointer whereas X86
> {read,wrie}(l,q} function argument is address itself.

I'm afraid I don't follow: x86 has

#define readl(x) (*(volatile uint32_t *)(x))
#define readq(x) (*(volatile uint64_t *)(x))

That's no different from Arm64:

#define readl(c)                ({ u32 __v = readl_relaxed(c); __iormb(); __v; })

#define readl_relaxed(c)        ({ u32 __v = le32_to_cpu((__force __le32)__raw_readl(c)); __v; })

static inline u32 __raw_readl(const volatile void __iomem *addr)

The difference is whether the address is expressed as a pointer, or
_may_ also be expressed as unsigned long. IOW the x86 variant is
perfectly fine to be passed e.g. a void * (preferably qualified
appropriately). The conversion from unsigned long to a pointer type
is actually expressed ...

> @@ -170,31 +170,7 @@ bool vpci_msix_read(struct vpci_msix *msix, unsigned long addr,
>          return true;
>  
>      if ( VMSIX_ADDR_IN_RANGE(addr, msix->pdev->vpci, VPCI_MSIX_PBA) )
> -    {
> -        /*
> -         * Access to PBA.
> -         *
> -         * TODO: note that this relies on having the PBA identity mapped to the
> -         * guest address space. If this changes the address will need to be
> -         * translated.
> -         */
> -        switch ( len )
> -        {
> -        case 4:
> -            *data = readl(addr);
> -            break;
> -
> -        case 8:
> -            *data = readq(addr);
> -            break;
> -
> -        default:
> -            ASSERT_UNREACHABLE();
> -            break;
> -        }

... in the comment ahead of this switch() (and the assumption is likely
wrong for DomU).

But then, Roger: What "identity mapped" is meant here? Surely not GVA ->
GPA, but rather GPA -> HPA? The address here is a guest physical one,
but read{l,q}() act on (host) virtual addresses. This would have been
easier to notice as wrong if read{l,q}() weren't allowing unsigned long
arguments to be passed to them.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Feb 24 15:19:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 15:19:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278378.475605 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNFtY-0007hO-Aa; Thu, 24 Feb 2022 15:19:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278378.475605; Thu, 24 Feb 2022 15:19:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNFtY-0007hH-7S; Thu, 24 Feb 2022 15:19:04 +0000
Received: by outflank-mailman (input) for mailman id 278378;
 Thu, 24 Feb 2022 15:19:03 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nNFtX-0007gw-37
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 15:19:03 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nNFtW-0008Ia-Nu; Thu, 24 Feb 2022 15:19:02 +0000
Received: from 54-240-197-226.amazon.com ([54.240.197.226] helo=[10.7.236.14])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nNFtW-0001jh-I5; Thu, 24 Feb 2022 15:19:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:
	References:Cc:To:From:Subject:MIME-Version:Date:Message-ID;
	bh=IwLZCFnhujonOevLJT+dR1g+s6GliwijhPausKgPrFI=; b=5y1wwG5ewDAnwr//f2IhkND79p
	hVa0UXBx15D47gZsIG/biUGJe3ENQUhHydcvwfUqfb7OkPZZQ11J0XVf/zy8aadBxeaTjrhjT/vo5
	ZWV+aYZ7nIdJt+vvsXKe5YqX/aOXj1xQVCyQQu2vFZizmjH/695vRoXYSxJACiMSPBLg=;
Message-ID: <6e2e15ad-024d-09f8-f80d-b437ab958ed0@xen.org>
Date: Thu, 24 Feb 2022 15:19:00 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.1
Subject: Re: [PATCH v2] docs: add some clarification to xenstore-migration.md
From: Julien Grall <julien@xen.org>
To: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
References: <20220217114726.8994-1-jgross@suse.com>
 <5f1d5525-3c3f-bad9-3448-c266d0ad5004@xen.org>
In-Reply-To: <5f1d5525-3c3f-bad9-3448-c266d0ad5004@xen.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 17/02/2022 19:38, Julien Grall wrote:
> On 17/02/2022 11:47, Juergen Gross wrote:
>> The Xenstore migration document is missing the specification that a
>> node record must be preceded by the record of its parent node in case
>> of live update.
> The patch also cover normal migration. So I think you want to drop " in 
> case of live update".
> 
> I can do the modification on commit:
> 
> Acked-by: Julien Grall <jgrall@amazon.com>

I have committed the patch.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Feb 24 15:21:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 15:21:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278392.475616 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNFwL-0000pR-O3; Thu, 24 Feb 2022 15:21:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278392.475616; Thu, 24 Feb 2022 15:21:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNFwL-0000pK-L9; Thu, 24 Feb 2022 15:21:57 +0000
Received: by outflank-mailman (input) for mailman id 278392;
 Thu, 24 Feb 2022 15:21:56 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nNFwK-0000pA-EL; Thu, 24 Feb 2022 15:21:56 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nNFwK-0008Mq-DZ; Thu, 24 Feb 2022 15:21:56 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nNFwK-0000sX-1O; Thu, 24 Feb 2022 15:21:56 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nNFwK-0004hA-0x; Thu, 24 Feb 2022 15:21:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=7t6F+ZBR1Ih2EeQAKpHzEVFpp0BrihdpCPaMGUAtfXE=; b=CUq5s/FwYKHp/Te2yHoTJS5wcE
	ECkNRskJXad5+BmgrMmAueNi/cCU5LZafNfkUBSY4MiSG8vMQS1y1QvNe98zqb2L9tlUtQoPCNMb7
	yTL5bgkCRCMLTRjDKuyW6odFFOcDDSq++mSCGXRtnUaVqxFxJD4QEccjRrk55DL8hYqM=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168216-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 168216: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=93189e8c8b93e2c4658156e785a9b78b61e71a64
X-Osstest-Versions-That:
    xen=fe60fab0424b93c6688d285bd7995226a96937d4
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 24 Feb 2022 15:21:56 +0000

flight 168216 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168216/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  93189e8c8b93e2c4658156e785a9b78b61e71a64
baseline version:
 xen                  fe60fab0424b93c6688d285bd7995226a96937d4

Last test of basis   168210  2022-02-23 21:01:36 Z    0 days
Testing same since   168216  2022-02-24 11:01:39 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Jan Beulich <jbeulich@suse.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   fe60fab042..93189e8c8b  93189e8c8b93e2c4658156e785a9b78b61e71a64 -> smoke


From xen-devel-bounces@lists.xenproject.org Thu Feb 24 15:23:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 15:23:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278404.475631 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNFxl-0001Sz-5j; Thu, 24 Feb 2022 15:23:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278404.475631; Thu, 24 Feb 2022 15:23:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNFxl-0001Ss-2k; Thu, 24 Feb 2022 15:23:25 +0000
Received: by outflank-mailman (input) for mailman id 278404;
 Thu, 24 Feb 2022 15:23:23 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nNFxj-0001Sm-3a
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 15:23:23 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nNFxi-0008OS-M2; Thu, 24 Feb 2022 15:23:22 +0000
Received: from 54-240-197-226.amazon.com ([54.240.197.226] helo=[10.7.236.14])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nNFxi-00027K-GD; Thu, 24 Feb 2022 15:23:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=9jzA2z5Ie9oHaG65OsiHnsV+whzyVQIl4hjomkN7oUQ=; b=cmhqsRBkfDSA/AZvLOmsaeKQd4
	eOkKUewbn0lXqCrXvho4tDF3gQDkrY+sHnFUK2oxET/f8g656a7r0uwIWLFuAkaFw9GHrKdVlWBlz
	5Ssokr/K79BqPxbW2yFszW1MLUdlr1wElwXYlNwxSLEqaCE5r2suRChkndYuKzF92K3M=;
Message-ID: <0f8a2619-0d0c-989d-fd2c-8e45d33c2172@xen.org>
Date: Thu, 24 Feb 2022 15:23:20 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.1
Subject: Re: [PATCH v2 0/2] Rename psr_mode_is_{32bit/user} to
 regs_mode_is_{32bit/user}
To: Michal Orzel <michal.orzel@arm.com>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20220222105613.20668-1-michal.orzel@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220222105613.20668-1-michal.orzel@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Michal,

On 22/02/2022 10:56, Michal Orzel wrote:
> The request to rename psr_mode_is_32bit to regs_mode_is_32bit was make during
> a discussion [1]. Because psr_mode_is_user shares the same prototype, we should
> rename it as well to keep the naming consistent.
> 
> [1] https://marc.info/?l=xen-devel&m=156457538423787&w=2
> 
> Michal Orzel (2):
>    xen/arm: Rename psr_mode_is_32bit to regs_mode_is_32bit
>    xen/arm: Rename psr_mode_is_user to regs_mode_is_user

I have committed the two patches.

Thanks for the contribution!

Cheers,

> 
>   xen/arch/arm/arm64/vsysreg.c    |  4 ++--
>   xen/arch/arm/include/asm/regs.h |  6 ++---
>   xen/arch/arm/traps.c            | 42 ++++++++++++++++-----------------
>   xen/arch/arm/vcpreg.c           |  4 ++--
>   xen/arch/arm/vtimer.c           |  2 +-
>   5 files changed, 29 insertions(+), 29 deletions(-)
> 

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Feb 24 15:24:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 15:24:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278411.475642 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNFyc-00022N-Ey; Thu, 24 Feb 2022 15:24:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278411.475642; Thu, 24 Feb 2022 15:24:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNFyc-00022G-C4; Thu, 24 Feb 2022 15:24:18 +0000
Received: by outflank-mailman (input) for mailman id 278411;
 Thu, 24 Feb 2022 15:24:17 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=l9RI=TH=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nNFyb-0001zs-Gk
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 15:24:17 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d41fd7f9-9585-11ec-8539-5f4723681683;
 Thu, 24 Feb 2022 16:24:16 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 3CE5021634;
 Thu, 24 Feb 2022 15:24:16 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 016E613AFF;
 Thu, 24 Feb 2022 15:24:15 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id j9QPOh+jF2LzXAAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 24 Feb 2022 15:24:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d41fd7f9-9585-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1645716256; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=CMUX6zu06GtcQAZGr8gKrme0g9ECkJiXojjlwJeMzfg=;
	b=uy+k4qRi50QdZ5Z+iHf8EnFwcBfaF1+pZebYjYK8D3ChuTiWmxmw9+LAbtl+AXQe0YYv4u
	S4ZP0CG/9eZJW6T8dwffnDjKDkFc1B90UQDAelRyMVv31DqcNaZDUmJTDifokRpI7yhIAP
	915Ko18NwsfHUcC1+2uIz5FCKEvzXio=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>
Subject: [PATCH v3] xen/public: add comment to struct xen_mem_acquire_resource
Date: Thu, 24 Feb 2022 16:24:14 +0100
Message-Id: <20220224152414.27948-1-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Commit 7c7f7e8fba01 changed xen/include/public/memory.h in an incompatible
way. Unfortunately the changed parts were already in use in the Linux
kernel, so an update of the header in the kernel would result in a build
breakage.

As the change of above commit was in a section originally meant to be not
stable, it was the usage in the kernel which was wrong.

Add a comment to the modified struct for not reusing the now removed bit,
in order to avoid kernels using it stumbling over a possible new meaning
of the bit.

In case the kernel is updating to a new version of the header, the wrong
use case must be removed first.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
V2:
- only add comment instead of reverting commit 7c7f7e8fba01 (Jan Beulich)
V3:
- make pad field comment more specific
---
 xen/include/public/memory.h | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/xen/include/public/memory.h b/xen/include/public/memory.h
index 383a9468c3..2d0817eab1 100644
--- a/xen/include/public/memory.h
+++ b/xen/include/public/memory.h
@@ -662,6 +662,13 @@ struct xen_mem_acquire_resource {
      * two calls.
      */
     uint32_t nr_frames;
+    /*
+     * Padding field, must be zero on input.
+     * In a previous version this was an output field with the lowest
+     * bit named XENMEM_rsrc_acq_caller_owned. Future versions of this
+     * interface will not reuse this bit with the field being zero on
+     * input.
+     */
     uint32_t pad;
     /*
      * IN - the index of the initial frame to be mapped. This parameter
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Thu Feb 24 15:33:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 15:33:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278421.475662 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNG7K-0003bx-E0; Thu, 24 Feb 2022 15:33:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278421.475662; Thu, 24 Feb 2022 15:33:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNG7K-0003bq-Ax; Thu, 24 Feb 2022 15:33:18 +0000
Received: by outflank-mailman (input) for mailman id 278421;
 Thu, 24 Feb 2022 15:33:17 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=VLhp=TH=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nNG7J-0003bT-3q
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 15:33:17 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 15835989-9587-11ec-8539-5f4723681683;
 Thu, 24 Feb 2022 16:33:15 +0100 (CET)
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2056.outbound.protection.outlook.com [104.47.2.56]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-34-4xyFhZQBP5GrZvC_bxdEHw-1; Thu, 24 Feb 2022 16:33:14 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM8PR04MB7251.eurprd04.prod.outlook.com (2603:10a6:20b:1d2::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.24; Thu, 24 Feb
 2022 15:33:12 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.024; Thu, 24 Feb 2022
 15:33:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 15835989-9587-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645716795;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=5R+2VHDgppM3rqEJHDSmmHWwmW926pYrHshAXwJO0TI=;
	b=VCskZ45bnCI31dJgICOZGgHaaIOEGNs6n9O+B98LRQBqrzOYLfs3wSjVIw7kt59In6Em4u
	V3U7l4pscawH/54D3933Af9HSIT5rAmoFnZOI+lh/4K9HucRE/MLU3cdy4otAtFYwKRleF
	0Kld9DmRDnLd4bdNCUd00nrw9Wd5vHo=
X-MC-Unique: 4xyFhZQBP5GrZvC_bxdEHw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Zdhe+Bx3volnoZRlaLnkCg56S6VMwEi0rUC7K3si7+icakx6X28fpdZcAcDbNSEflbZU9FXuT0QBONn/Nuk2Hijrl/4kMvSpXG/VWs99mqAzEonpp5GuS6wktmfRiLWwi8zV6Fj8bHOS0zgOm2fSYACjO2VQ0ZSO0ptuMOfNWpceM7bzwrmmg5Rz62RijcuapbD1GPVuREiZOCtzozc9Y4clAC6F1m3ieAwF9/pKe0B6Pf55xVqtCZS13aRmaraiEAOkBeCx7aVtOprCn02qZyOMZ0tkpH2vaVwGvmezDFSz8ouoClHWPAI9FJbOaN4YPPWr4PLALuMK6ZlnH7Etaw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=5ZrrsloNWEExtgxPvaYwMkJWXAdO/XFAyldvEfQrlso=;
 b=HyHtJxbo2AZhZshKs+xsmgokCf/AHwfGtR/hTKN8TZJ+44Zwxjcpq5AXIYPoiCyTMEvnyZQmxYH2VJVQIL9vrjXjjLelA5Ebg31kytrxZkfDrm1zikWnIrJWxd7VlpupvU0K2M/j5TpTZPUbeqXcJXMVRNgJb0g0uH17+Ux0orVZh6Oelpnb3C+sf1eJa2D/vIJIaCJdfGiXw+vNqFaNvHCCdgWURdqB3dTwB/TN/NJpd6mxQMe1o2Io3j7orCeuq/3P9ljPE7xrT4mvjJW3eMTscgI0WJr3Mz+Q2EA1mPHmExxd2KpdyjCvpKebFJA2Mx1ASbWzffnYvQa2NaLWMQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <81d22e3f-6309-1141-0af5-00a8231a7b56@suse.com>
Date: Thu, 24 Feb 2022 16:33:10 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH RFC] pci/ats: do not allow broken devices to be assigned
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Paul Durrant <paul@xen.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Kevin Tian <kevin.tian@intel.com>,
 Oleksandr Andrushchenko <andr2000@gmail.com>, xen-devel@lists.xenproject.org
References: <20220224124344.86192-1-roger.pau@citrix.com>
 <3eb5e059-b37c-27c9-5c1b-0ed92b9edfd0@suse.com>
 <Yheb8Z2oNwypwHFd@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Yheb8Z2oNwypwHFd@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6PR08CA0045.eurprd08.prod.outlook.com
 (2603:10a6:20b:c0::33) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 6a3c79f5-5d3e-437c-6c47-08d9f7aaf7ec
X-MS-TrafficTypeDiagnostic: AM8PR04MB7251:EE_
X-Microsoft-Antispam-PRVS:
	<AM8PR04MB725147A550CAF6DF6541C54CB33D9@AM8PR04MB7251.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ErFPgJHKQpl+yXCn556PBpDohjNNZmhUmL9kEr/iCtq01m5E/8HFB4s9Mbv18M7q5DpiVpGKLyQKr8kFWvL7nyt/GzA68JWNNe6l8Zl+F/mQ/ptsdIx9VkRQgl62L9mKlOeR8ATS9/kAmYVv1ZX8Pramp0WFasJWer5aZG4bNeBv2CSQj0RAOzt5vNz7zB5OLrUBWS8hNhFwu1yFWT2Vtx4Yp8DorCrg2EcSqAoITFylKIhZqbxM/FtkKkSUXkwZ6sImki1vOle6+yQ1T8pAowZH3rSac72RvMNtq84y71/FdfPocA/aiD+1pLIE0gfUI/ydAK925CQ0dPocHDZCWSTkHitZcckTI06W0PvC5ql5F16mG+5RL7oFnqJpq6oHwz1V+m4rvaPF1vzUr/eC6yveJThxqcdXnCU0jk7FEEY+bW69dG1RpXUeU37wVFaGxNLPSBodaqH2UwHW+eL7wGVSMYB+c97cXkCYWhOXeAOJZEYmDCj1QEEp3rx7MTmlLK/zcs/snLiNNNbM23ouySvsMGNuE04P7iLMirMNIaSj05seVP/j451sBkCDXWcH7omOp81Y56eiWjAT/G6jv3uLTAQLxCeqnWUijblhBaElGPJnhpt8sn6vhdGJ36AeANvdJJoerFl3kIipkUkrJegl7DkWfdVxZ4nWQDw89incMvwkS5ojl6LYC+LaZV3mbKH18h1P1+qheX3BxyT1G5SzOrcmrX4Wo4fvberrTt8NzRT7nrma1yl1veFwZ5BQ
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8936002)(6486002)(66556008)(66476007)(4326008)(53546011)(8676002)(31696002)(38100700002)(6506007)(2616005)(508600001)(2906002)(110136005)(6512007)(54906003)(186003)(26005)(316002)(31686004)(36756003)(7416002)(83380400001)(66946007)(86362001)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?Rs7K2R61kzTJgfiv7ssttN6zx4qsjjWO7GyWDUiBDIaz/tt9VWyDYRPs/7T0?=
 =?us-ascii?Q?d3fQQsFwVUrHJXgpnP8YR1mXt0YdMSybmSwWBLqZWvP3kCWmiiZdFFSYZnqz?=
 =?us-ascii?Q?DqYkS8Y54yCA9QjGTLqz1vKsmGH/buuuMQj5PjUsGEeE9nTLPmeozHV7z4lc?=
 =?us-ascii?Q?n9ffjTyKp2ZdJYEfTVnE9og9WW4ZPAnyZeWHQDbelwH3AbcLyZLL71FcNabi?=
 =?us-ascii?Q?JiRB3bsNv4bRI2snzDm+r70sweHJk0h8SVKScBWNxY6VE4jhore0ez+XkIz1?=
 =?us-ascii?Q?KHlRNkQZiUsPAyxPApO21WRudyPEyJ/xm6pQ/8PmIzm4Tsx7SL8uKbqAXQ/Z?=
 =?us-ascii?Q?HELmk7hhZNksb9uFYj1OarqpFnRhu34+/QOA9jrMOykKOIPG0UejLOLd4jPq?=
 =?us-ascii?Q?5fsrVxUOn6nIe2BeGDYsOfTjlFPMvM6Acv/Kpa3YriIG6Kp4IJ0hmAhSfrDD?=
 =?us-ascii?Q?2TXFsHqR2WVwLiKrLa0IYw4Vo2HxPoj8ZBhiuSLmjvx2XCjjUeEl4i2AlyJ2?=
 =?us-ascii?Q?onobCNMcehMp3XHrDdJXZZSxNX8VVMvH0h+KcZr8JtFZJcXdqxZcCA8CIJyY?=
 =?us-ascii?Q?6NtzKBRfycGicaJjxeDoIBuhlCujR8tAshtRgKsgTbvtGfVrqCB+l5qJ9xhE?=
 =?us-ascii?Q?KSNWBQEYwt4/BDEhUaHHIiz+5y2is9Id4lX+HUb++2qIqLoJQ0sRk1wSNFSI?=
 =?us-ascii?Q?9lQ2z9AItAxX6mKLA1Efp31qEk99kbx+ny1N04gz9lPwRrVNRcHS7L/jfauR?=
 =?us-ascii?Q?ixT2gKhmph6yicSWMDtNkkrVd9F+KfRlqm+natnP/Kg9jKZ7eWzIHIAcz7wl?=
 =?us-ascii?Q?EMIbAgaRn+rarVMD5R+u8f+NOSvm2TWEaraMroxyTnwFLy6E9BsG1e97whSs?=
 =?us-ascii?Q?s8bGQaa0Z8P6mZIspsj9K1+kKCOgy1H7WpIhg3oLK2nwh4aC3mi0EgaHGAOP?=
 =?us-ascii?Q?I83diex2hZjgK31el0cRGah9F43F6h4sHiwUYCImdMcWEH5iDMiBpvhM35un?=
 =?us-ascii?Q?8VmL8qszFxVT1tUwibsfweFWMIpOblEw17ktHJ539XofPEBzm2k/0prr3C8M?=
 =?us-ascii?Q?Vm6ErNZGjiy4RwU64LgSipUa8zYCG2Sc+/oSEKVg9axx5L9I4b9zGqNBPsjC?=
 =?us-ascii?Q?77W0irToS4NVaFx9+gQEhGlKS9iDMCwbsBv9aTV6RmGt4QwYgTmbP37whORt?=
 =?us-ascii?Q?MSR/Cd5XjpxT4yM+WCnm8u+1H8JkVhmaYbFLh5+HL7xsdYCaEOu3kuO7CX82?=
 =?us-ascii?Q?Fsg2hwPwgclpYF4aSl5MLgzEYpUYWbabpmor119cvURvV4mphADqp8lvRGxt?=
 =?us-ascii?Q?7/khlzuZ2+s6sIgnZh2jEO/h+IkbQSlpbazI1zt5qGApwMNiTqP2hjgV++ym?=
 =?us-ascii?Q?rW8GlMrAzEG3fWpRAss4PrkbCpr+sXP5+705KfgcnA45njsFT76a5GNZFwLi?=
 =?us-ascii?Q?xr7faAc+w0jXp/gc3IwjJqCld8jvAVL8M49+3z78NKMvDoASUYaYpv6xsr6A?=
 =?us-ascii?Q?77P5Lotnhv50buwUrmhs0nHBN1TrZvaZNipqhh0MWyz4zy0Eg9HnJ06ifd05?=
 =?us-ascii?Q?vEtdcPeAw2BJhu6XARsaGrN/2oQWnzMhJTsHhy6P7aQGWq/R4tFWqaIiwZOo?=
 =?us-ascii?Q?K8VyIo/1IFsIHcuv4bII4nw=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6a3c79f5-5d3e-437c-6c47-08d9f7aaf7ec
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2022 15:33:12.7634
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0jRovZZWxxabCebGLzcZb8dffiGfn3xzz16zzI6spUvtTkiKMzOjXKAdGaqsMfj/GXPWExl9KhdxfaqRU1rROA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7251

On 24.02.2022 15:53, Roger Pau Monn=C3=A9 wrote:
> On Thu, Feb 24, 2022 at 01:58:31PM +0100, Jan Beulich wrote:
>> On 24.02.2022 13:43, Roger Pau Monne wrote:
>>> TBD: it's unclear whether we still need the pcidevs_lock in
>>> iommu_dev_iotlb_flush_timeout. The caller of
>>> iommu_dev_iotlb_flush_timeout is already bogus as it iterates over a
>>> list of pdevs without holding the pcidevs_lock.
>>
>> Analysis of whether / where recursive uses are needed should imo
>> include cases where the lock ought to be held, but currently isn't
>> (like apparently this case).
>=20
> Well, I'm not opposed to that. I think just aiming to get the current
> usages analyzed will already be hard.

While I fully agree, the decision to drop recursive locking would better
not put roadblocks in the way of adding locking where it is currently
missing.

>>> @@ -1487,6 +1487,11 @@ static int assign_device(struct domain *d, u16 s=
eg, u8 bus, u8 devfn, u32 flag)
>>>      ASSERT(pdev && (pdev->domain =3D=3D hardware_domain ||
>>>                      pdev->domain =3D=3D dom_io));
>>> =20
>>> +    /* Do not allow broken devices to be assigned. */
>>> +    rc =3D -EBADF;
>>> +    if ( pdev->broken )
>>> +        goto done;
>>
>> I think this wants exceptions for Dom0 and DomIO. An admin may be
>> able to fix things in Dom0, e.g. by updating device firmware.
>=20
> Doesn't a device get assigned to DomIO (or Dom0 if not using quarantine
> mode), and then when deassigned from DomIO gets assigned to Dom0?
>=20
> So there's no usage of assign_device in the path that (re)assigns a
> device used by a guest into Dom0?

Well, this assumes all tool stacks behave like the xl one presently
does. Which I think is the wrong way round: Making a device assignable
should be "deassign from Dom0" (implicitly making it land in DomIO),
while removing a device from the set of assignable ones should be
"assign to Dom0" (implicitly deassigning from DomIO). That way (I
think I said so elsewhere earlier on) libxl would also avoid the need
to actually use DOMID_IO explicitly. It using DOMID_SELF like done in
various other places would seem more clen to me.

Paul - I think it was you who decided to make it work the way it
currently does. Do you have any insights into your thought process
back then which you could share?

> Or would you rather imply that pdev->broken should get cleared at some
> point (ie: when the device is assigned back to Dom0)?

I did ponder this for a while when writing the earlier reply. But I
decided against, for it being a functional change: _pci_hide_device()
currently is also sticky. But yes, in principle if a misbehaving
device _can_ be fixed (e.g. by updating its firmware), then I think
there needs to be a way to clear the "broken" flag.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Feb 24 15:37:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 15:37:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278428.475673 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNGBq-0004HU-23; Thu, 24 Feb 2022 15:37:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278428.475673; Thu, 24 Feb 2022 15:37:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNGBp-0004HN-Uc; Thu, 24 Feb 2022 15:37:57 +0000
Received: by outflank-mailman (input) for mailman id 278428;
 Thu, 24 Feb 2022 15:37:56 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=VLhp=TH=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nNGBo-0004HH-Jg
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 15:37:56 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id bc402522-9587-11ec-8539-5f4723681683;
 Thu, 24 Feb 2022 16:37:55 +0100 (CET)
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2058.outbound.protection.outlook.com [104.47.1.58]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-36-WCrEa5sPOWq_q6mNZtihVQ-1; Thu, 24 Feb 2022 16:37:53 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM0PR04MB4212.eurprd04.prod.outlook.com (2603:10a6:208:61::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.24; Thu, 24 Feb
 2022 15:37:52 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.024; Thu, 24 Feb 2022
 15:37:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bc402522-9587-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645717075;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=BteCfqwDRFkREaQhnGaLNsECpBk6t15po9zqcuEo+Cw=;
	b=RBE6cpg1I68ewKLo9AZF/P1cmlPfGUHznisDSQdmyQAQRyLuCuFq85CIASHn2sMm2hSI+F
	mKtCannFjKOjJrml9reV2+qhzWKSiPXD+rrgNMQ+iVUgXA7jeGsN308gGtd5tW7Ge8WXIP
	oiTuslsdmnsH+tfaAxx2qfxc2SJqhl8=
X-MC-Unique: WCrEa5sPOWq_q6mNZtihVQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=eBhcCQCbTQiLUucLfOaxzAApI9CTLkRBIDlka8r0yl+0kkQYkjrf8AV81qP70HLUgdsI5ycATnIryahSE6H08Y7at4DASwKF6Po3mT0+ZMq5UXQYTgkKiJaTO0oKmVFORhT/injo2+gEgUt/w/WXUYzrts5Wr7ntowhxv8ut8vtpqkGuLpfeSYj+CAe+iOPlzzIZU8b5+B61HAWK16Kcwkh1ParmgVkuUY9OzGXRxubLqv/vbMzUlkOR4WM5Br6pAo58Gn3nPyJ3oeS6z2KwwXqtGxJuHONK2ZhIRPsP3C8zolO6fWbcU7KsP3+pCpRTgVAHZ9ZJDaBw6P1lYd5Qsg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=BteCfqwDRFkREaQhnGaLNsECpBk6t15po9zqcuEo+Cw=;
 b=hWg1tySqrpj4s4iljgYd66dTok2hKFsYNp/vUehdlGVaAADvcfc4/K87oblhQ7YwAotxeexq59SywwCL4l9Bm8RlLcId3ZdAytxMP6zia0NNt2fhATn2RI/3y2x5wgl11JRPTKgq/XCuLGxFKhkLobOBMAVTFYL6nRiC7M5zZGFQhovtaZK43g+Mmi04OhL0+N45SMGFRAvXtHWP9xP+MNlqqOAMjbjePRWMOtUrR/9k3RUtmGCqdlD99Q15D3XIkErm4amTC+47WRSDgNrY/CDVlfdRn57iOe1kYCGZSJa+utjgnegX1M/Lf4TG8J5Op5pcYjrDSi8gvmTwmN6KOQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <9972f96c-d0cc-d9a8-3566-74dbaf7e9e33@suse.com>
Date: Thu, 24 Feb 2022 16:37:50 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v3] xen/public: add comment to struct
 xen_mem_acquire_resource
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220224152414.27948-1-jgross@suse.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220224152414.27948-1-jgross@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR3P281CA0052.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:4a::23) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: aa968758-4f7d-44d9-c80b-08d9f7ab9e54
X-MS-TrafficTypeDiagnostic: AM0PR04MB4212:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB42122F73138A997FB5AE5784B33D9@AM0PR04MB4212.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	PRfSfB1ITTI4x1cDDhiK7zajd+qlZLe6djQ81+Sb03Ux3P8byRBy2Mr0z8Tfoi1hUD1gBN75QxCqkzgzm53sAUfAjOU5Wnk/UfGe7aF5xheTXJFbRMKlAFmcCYujo7wsStBJ3AKR34MLQZ+R6HuAcCJbBBZ48F0jFm+A+PK1fz2fGGnmIyJUFtCtDXQxfjBLmSNnrLG708oiajLfERZQL4s3Y5m8e77oR6MvjVFFvXGbn7Be99CmUESJdE8/hYiZ4eDBfkb+kxns7LjYLhSehSUMMMpsnFrxsCbFvpOd4c7SkOmCIQH3Z1AY1eXZiUZXGvIAaznez68SB03ZGCY8uCeS2uvDX2WB9BxtpwKiQG3i4vzhNsG941q487PJx5C73/cvamq0gpatO9GuZSJzdapAFYqLSY5NW4aukJriTt1s488M597KZawdALRyYvLqhof7JIBXT5JwiqMiq8EA0mAODCM7hZJtLeBGyvhKd2brTRoMEzvGB6a9JPtRqyX7MYJcyT1vybPh7RGfKW7wkQWs+h0R/XmswCUFrLHSaNQB0IJCALVxVltEPWpcxA6kaqpslEPC88SQffLwaNm5y1uQAm0sHfOdGMoc8czN+zYnASS7kf0ea9urKhx94uZ9HT+5NxY6b9axAf2hQCbeapEo6lBTNrZ5+gLpH5yAZoWXk3FcEwdDI1jb2o49qhfAnHGc5c1tMTwPxvCTNaYqpdoG8w0rHj0kBPnO0jpb+4I1Bip9mtCl+/aOEgrnxq58
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6512007)(8676002)(2616005)(66556008)(36756003)(5660300002)(316002)(6862004)(8936002)(66476007)(66946007)(26005)(38100700002)(6636002)(186003)(31686004)(2906002)(6486002)(53546011)(31696002)(6506007)(4744005)(37006003)(54906003)(508600001)(86362001)(4326008)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Q1o1UDFoWndoVm9JSEFhTTVJQ1ZWTFIxZndwdG1EbEVDRkhRN2tpeHBLMHo5?=
 =?utf-8?B?S0VJMmF0YzZlRkpnNTJmeWlCNGJPeWw1anp6cGJEU3BzTjhOaVVzM3NaRFRi?=
 =?utf-8?B?YnZWdWQxT3hzMTgrbWFHci9ldW5ua2RjTlZUVFYraXFlZm4zY2RiOGR5ck1x?=
 =?utf-8?B?RzVyNUNUSlp5Unc1Q05yQzhVZ05VV0hlWlBRMWZjOVhmTGdwKzdvUCt6VHNI?=
 =?utf-8?B?TzRmVGFkazZWU0dFaWtxb0hMUlQva1RFZy9PMkRPblI2NmpMbmxGN0JDTGw4?=
 =?utf-8?B?dFFhRmsxVVhLMkYyV1pQOXVMTDIwS0ltZERNVEVHaXIrZVpJMWRoYzZPODJN?=
 =?utf-8?B?L3NYVEU5SUV6WlFJWG9IWVZhMm9oRWZDY2t4TE1wVlR6TWhhazBzdG94L0Vz?=
 =?utf-8?B?TzNkZ0ZLajh1YnRQNjlYdE43Kzk5aGpLa0hObWhObGRsOWNaWlM1dGVpTTdt?=
 =?utf-8?B?cUhpY1ZwRlc3QTFoWnp3Q2U3L0RwTVNGbFF1NytLUExLbnVoMFE4cG5iOTg4?=
 =?utf-8?B?VWJnQjh5cjBqekExWm1jTUJNTk9LcWU0QmVyRnpLOEtZcENjVkhsamdVQWhT?=
 =?utf-8?B?RkFFOU1NZ3FnRzk4VS9XR3BIbWgzRXpUUXIrbGxvSkF6U20zSGJxZXp5SzI3?=
 =?utf-8?B?T3dySDNtVXRLNm8vclc2OVZnYjR2RHhKUS9EdGhrQVBqSnNEMkNyOUgyaklD?=
 =?utf-8?B?Zko1S0JYajkxeXZMT3JMNVNSdUlWYkwyRnRzRU5wZVphZ1l4M0VRODF1QUVv?=
 =?utf-8?B?Ny84M2l4SzE3SmhFZmI4MnBwTmlRVUh6b3FnUTYzNkxDU0l0K0Yyelg0TzRz?=
 =?utf-8?B?dDZkRUcxN2hTcHV1Rjg0RzI1dFdCL0dMQkw4dEdWeTNxNVBCSWRoUXJSYm9H?=
 =?utf-8?B?YlJKYnN2c1lEZitYclVPSWR0bi9SYmxSd1J2K2VkRHhyM1pWQnF6UnZqejVw?=
 =?utf-8?B?cnc4VGtVR0w2VXBDSzFJOVg1RERuV0dxVXA0bFdPV0JBZldJaFJVTjRIeWV6?=
 =?utf-8?B?VStwR3ZXVU81OTlCTGxnak00aUdQWWE1bGhtYjkwZG1yVHhZa2JzcGFPQ0lK?=
 =?utf-8?B?QzVFN2JjTitpWXI2bk9mbUxEaFhkQnRlMWI1UUNMU3BHVmQvZ2xhNEVVbEY3?=
 =?utf-8?B?bU42WFM4T0NGbjBDU3BmbXdwc3ZyUE1oMmJzWDJCZlFtVXk5dXZjNk1NeGZF?=
 =?utf-8?B?NmZ6VmQ2eGJjSkI3SlZoRU1QRnc3SER6VG5Va0NLODhwelk4Y1lNK3pHWGNK?=
 =?utf-8?B?QlArZVlzamdObkkvbDZrR3dhbnZMYk5XMTFLR3RzZ283aHVmSTg1VDlFZmtZ?=
 =?utf-8?B?SFE5blpSdHQ0dEFXMHV3SzF6MUpEWDBISnVacmRncS80K3VsZXFxQ0dBTEcx?=
 =?utf-8?B?KytyVHI0Z0dQdndNVVNKUW5vck9jY0pFR1luaEhiT21WQjhmKytEZ3Bldm5y?=
 =?utf-8?B?ZTg4bFdieTdIZlQ2OURqeU5JemttU3N6VnFOZWRQZUN0YmoxZHRCVnQ0Sm9D?=
 =?utf-8?B?a0hQS1ZNTUxoRTBzei9Ra3lvdUtnWnRXQjhSbjVXZDVHaS9hTGFlVnFSY1dx?=
 =?utf-8?B?YW10YVhRMDBjdCtqUHdYQmViM2J5YmpFd1c5ZG5hak1UUmxCcDdnOXNML0VJ?=
 =?utf-8?B?dWpVT0t1ZFlGYXJYd0t6NUpmeEkzNTVjTkhuQkVXRHRkamFzWm5oOTl6TXVL?=
 =?utf-8?B?bytRRkJCU0FZVHZraVQraDFqNFhmcStvUGxnenQxekozTFJ5R0sxa040TEFi?=
 =?utf-8?B?VXhTUlJQRnpLM1pQbHVNZnN5V2wvVFEyTHB6MCtidlZtdUdmRVQ5MStSdjFN?=
 =?utf-8?B?bkZZelQ0NEhPUk4weHlhK3ZWR2NnTnByeEh4ekZIRU12emE0WlpGcmVic0pJ?=
 =?utf-8?B?ajJhaFI2K0dMVFQ1UFlzTzdFQ3ZIRVk4dzk3eCttTGVjdGxqNVNRSGlPTlRW?=
 =?utf-8?B?RDRUb2MxRVYvQ25GVEhvZU8vaFdUTDM5dExEdGlpWUoyUmprNUtUOWx3Y3dO?=
 =?utf-8?B?N0V6bDVnVDZ1OVMrNTBhUEJzTUNSL0FHZXkrZEQ4b2xpYmo2V1dLK0I0SC9i?=
 =?utf-8?B?MjJOYXhDdFJrRUVTVTg1djRKbzZleE9KVTkzWG5WSW94b09YYStCZHNZQTR4?=
 =?utf-8?B?aVgzN1cyYy9aZUVZK1l0Q1N6VFJqN0J3T3hUdjFpWWo3WGpNby9oWlY2amFw?=
 =?utf-8?Q?TzCiQYCgCCv3xPlSsbOQluY=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: aa968758-4f7d-44d9-c80b-08d9f7ab9e54
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2022 15:37:51.8710
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qMP8jAAw+IMWbOP0ohhAFx1BOMplHYPvq83HL5v9SCwfMzyI+0j+2VGBf4bL5uvbtZ7usAaX1zLEuftgcw6U2w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4212

On 24.02.2022 16:24, Juergen Gross wrote:
> --- a/xen/include/public/memory.h
> +++ b/xen/include/public/memory.h
> @@ -662,6 +662,13 @@ struct xen_mem_acquire_resource {
>       * two calls.
>       */
>      uint32_t nr_frames;
> +    /*
> +     * Padding field, must be zero on input.
> +     * In a previous version this was an output field with the lowest
> +     * bit named XENMEM_rsrc_acq_caller_owned. Future versions of this
> +     * interface will not reuse this bit with the field being zero on
> +     * input.
> +     */
>      uint32_t pad;

Did you mean "... being non-zero ..." and "bit" and "field" changing
positions?

Jan



From xen-devel-bounces@lists.xenproject.org Thu Feb 24 15:41:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 15:41:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278437.475684 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNGEt-0005iY-Jo; Thu, 24 Feb 2022 15:41:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278437.475684; Thu, 24 Feb 2022 15:41:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNGEt-0005iR-GN; Thu, 24 Feb 2022 15:41:07 +0000
Received: by outflank-mailman (input) for mailman id 278437;
 Thu, 24 Feb 2022 15:41:05 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=l9RI=TH=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nNGEr-0005iL-Cp
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 15:41:05 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2c964266-9588-11ec-8539-5f4723681683;
 Thu, 24 Feb 2022 16:41:04 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 8A8D31F37C;
 Thu, 24 Feb 2022 15:41:03 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5035213AFF;
 Thu, 24 Feb 2022 15:41:03 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id b+//EQ+nF2IHZQAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 24 Feb 2022 15:41:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2c964266-9588-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1645717263; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=SNDlErUUGn7Wki06GJZwW8Uu96EoZJWASJg9lACDEaY=;
	b=bzi1NAoRCOd1MMXMOHkZOTko86j+HQ54IN5LMOtpHrVq7H+/eFQ7eLpA/uC7ul8HG+Njzh
	tlx50Ds6Y1JwpUvfpxdKoP9tQP6bL19RC+iy5ErZsIDYwkkkrdl8XN9vKWKBQOOOR8Fnz1
	lbV97aDPlqcL+v88lkevgNgHDbbcLW4=
Message-ID: <93d49d5f-29d5-72d1-c00c-ad14fb08b9c4@suse.com>
Date: Thu, 24 Feb 2022 16:41:02 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v3] xen/public: add comment to struct
 xen_mem_acquire_resource
Content-Language: en-US
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220224152414.27948-1-jgross@suse.com>
 <9972f96c-d0cc-d9a8-3566-74dbaf7e9e33@suse.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <9972f96c-d0cc-d9a8-3566-74dbaf7e9e33@suse.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------rSEb6uvca7yT7sZZZMsniJOQ"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------rSEb6uvca7yT7sZZZMsniJOQ
Content-Type: multipart/mixed; boundary="------------XKqg7b7NN0drSqOeXfvI0SsG";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
Message-ID: <93d49d5f-29d5-72d1-c00c-ad14fb08b9c4@suse.com>
Subject: Re: [PATCH v3] xen/public: add comment to struct
 xen_mem_acquire_resource
References: <20220224152414.27948-1-jgross@suse.com>
 <9972f96c-d0cc-d9a8-3566-74dbaf7e9e33@suse.com>
In-Reply-To: <9972f96c-d0cc-d9a8-3566-74dbaf7e9e33@suse.com>

--------------XKqg7b7NN0drSqOeXfvI0SsG
Content-Type: multipart/mixed; boundary="------------2EEnrZ1bPYvQxxnxK580JW9c"

--------------2EEnrZ1bPYvQxxnxK580JW9c
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMjQuMDIuMjIgMTY6MzcsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAyNC4wMi4yMDIy
IDE2OjI0LCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gLS0tIGEveGVuL2luY2x1ZGUvcHVi
bGljL21lbW9yeS5oDQo+PiArKysgYi94ZW4vaW5jbHVkZS9wdWJsaWMvbWVtb3J5LmgNCj4+
IEBAIC02NjIsNiArNjYyLDEzIEBAIHN0cnVjdCB4ZW5fbWVtX2FjcXVpcmVfcmVzb3VyY2Ug
ew0KPj4gICAgICAgICogdHdvIGNhbGxzLg0KPj4gICAgICAgICovDQo+PiAgICAgICB1aW50
MzJfdCBucl9mcmFtZXM7DQo+PiArICAgIC8qDQo+PiArICAgICAqIFBhZGRpbmcgZmllbGQs
IG11c3QgYmUgemVybyBvbiBpbnB1dC4NCj4+ICsgICAgICogSW4gYSBwcmV2aW91cyB2ZXJz
aW9uIHRoaXMgd2FzIGFuIG91dHB1dCBmaWVsZCB3aXRoIHRoZSBsb3dlc3QNCj4+ICsgICAg
ICogYml0IG5hbWVkIFhFTk1FTV9yc3JjX2FjcV9jYWxsZXJfb3duZWQuIEZ1dHVyZSB2ZXJz
aW9ucyBvZiB0aGlzDQo+PiArICAgICAqIGludGVyZmFjZSB3aWxsIG5vdCByZXVzZSB0aGlz
IGJpdCB3aXRoIHRoZSBmaWVsZCBiZWluZyB6ZXJvIG9uDQo+PiArICAgICAqIGlucHV0Lg0K
Pj4gKyAgICAgKi8NCj4+ICAgICAgIHVpbnQzMl90IHBhZDsNCj4gDQo+IERpZCB5b3UgbWVh
biAiLi4uIGJlaW5nIG5vbi16ZXJvIC4uLiIgYW5kICJiaXQiIGFuZCAiZmllbGQiIGNoYW5n
aW5nDQo+IHBvc2l0aW9ucz8NCg0KTm8sIHdoeT8gVGhlIGN1cnJlbnQgTGludXgga2VybmVs
IHdpbGwgc2V0IHBhZCAodGhlICJmaWVsZCIpIHRvIHplcm8NCndoZW4gZG9pbmcgdGhlIGh5
cGVyY2FsbCwgYW5kIGl0IGV4cGVjdHMgdGhlIGJpdCB0byBiZSBzZXQgb3Igbm90IG9uDQpy
ZXR1cm4uIFRoaXMgbWVhbnMgdGhhdCB0aGUgYml0IGlzIHJlc2VydmVkIGZvciB0aGUgY2Fz
ZSB0aGF0IHBhZA0Kd2FzIHplcm8gb24gaW5wdXQuDQoNCg0KSnVlcmdlbg0KDQo=
--------------2EEnrZ1bPYvQxxnxK580JW9c
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------2EEnrZ1bPYvQxxnxK580JW9c--

--------------XKqg7b7NN0drSqOeXfvI0SsG--

--------------rSEb6uvca7yT7sZZZMsniJOQ
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmIXpw4FAwAAAAAACgkQsN6d1ii/Ey+j
5wgAlSgxXguNNU04gqqv7MWuqLWz5R6EcgLtfjQxrGgfpwLT73QLA1UNXZzd0leDqMr3YeM0fCpk
jMElFvg7nAd/VAQHkFPycV6KNGc76P6J0Xj6mzuKQsXg1XzFMvDMe7s4+cmK1nHZQQC/86fQNtes
MT3OPg/UE2/Aqlb5q29pNqioA0LO3lqkQRkKTcFrRDyYqPtzE2bsgPLMUOtcEZIlGElcfUfHn1FI
a8P0MDUtvwoOOzk0yfzQEE2VHznQwLojGAY+03G3DIrssq/WlD1uf8kpFkaTQV19lPk+Bs7XW1z4
Qcy/VXfTDbEVSQ8kGuU73UjeJ71HYNYHAca3zGpBoA==
=cSpV
-----END PGP SIGNATURE-----

--------------rSEb6uvca7yT7sZZZMsniJOQ--


From xen-devel-bounces@lists.xenproject.org Thu Feb 24 15:59:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 15:59:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278444.475694 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNGWC-0007MA-3U; Thu, 24 Feb 2022 15:59:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278444.475694; Thu, 24 Feb 2022 15:59:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNGWC-0007M3-0T; Thu, 24 Feb 2022 15:59:00 +0000
Received: by outflank-mailman (input) for mailman id 278444;
 Thu, 24 Feb 2022 15:58:59 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=uiXl=TH=lst.de=hch@srs-se1.protection.inumbo.net>)
 id 1nNGWB-0007Lx-Cf
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 15:58:59 +0000
Received: from verein.lst.de (verein.lst.de [213.95.11.211])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id acb0c244-958a-11ec-8eb8-a37418f5ba1a;
 Thu, 24 Feb 2022 16:58:58 +0100 (CET)
Received: by verein.lst.de (Postfix, from userid 2407)
 id 88B5268AFE; Thu, 24 Feb 2022 16:58:54 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: acb0c244-958a-11ec-8eb8-a37418f5ba1a
Date: Thu, 24 Feb 2022 16:58:54 +0100
From: Christoph Hellwig <hch@lst.de>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>, iommu@lists.linux-foundation.org,
	x86@kernel.org, Stefano Stabellini <sstabellini@kernel.org>,
	Juergen Gross <jgross@suse.com>, Joerg Roedel <joro@8bytes.org>,
	David Woodhouse <dwmw2@infradead.org>,
	Lu Baolu <baolu.lu@linux.intel.com>,
	Robin Murphy <robin.murphy@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	xen-devel@lists.xenproject.org, linux-ia64@vger.kernel.org,
	linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org,
	linux-hyperv@vger.kernel.org, tboot-devel@lists.sourceforge.net,
	linux-pci@vger.kernel.org
Subject: Re: cleanup swiotlb initialization
Message-ID: <20220224155854.GA30938@lst.de>
References: <20220222153514.593231-1-hch@lst.de> <09cb4ad3-88e7-3744-b4b8-a6d745ecea9e@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <09cb4ad3-88e7-3744-b4b8-a6d745ecea9e@oracle.com>
User-Agent: Mutt/1.5.17 (2007-11-01)

Thanks.

This looks really strange as early_amd_iommu_init should not interact much
with the changes.  I'll see if I can find a AMD system to test on.

On Wed, Feb 23, 2022 at 07:57:49PM -0500, Boris Ostrovsky wrote:
> [�� 37.377313] BUG: unable to handle page fault for address: ffffc90042880018
> [�� 37.378219] #PF: supervisor read access in kernel mode
> [�� 37.378219] #PF: error_code(0x0000) - not-present page
> [�� 37.378219] PGD 7c2f2ee067 P4D 7c2f2ee067 PUD 7bf019b067 PMD 105a30067 PTE 0
> [�� 37.378219] Oops: 0000 [#1] PREEMPT SMP NOPTI
> [�� 37.378219] CPU: 14 PID: 1 Comm: swapper/0 Not tainted 5.17.0-rc5swiotlb #9
> [�� 37.378219] Hardware name: Oracle Corporation ORACLE SERVER E1-2c/ASY,Generic,SM,E1-2c, BIOS 49004900 12/23/2020
> [�� 37.378219] RIP: e030:init_iommu_one+0x248/0x2f0
> [�� 37.378219] Code: 48 89 43 68 48 85 c0 74 c4 be 00 20 00 00 48 89 df e8 ea ee ff ff 48 89 43 78 48 85 c0 74 ae c6 83 98 00 00 00 00 48 8b 43 38 <48> 8b 40 18 a8 01 74 07 83 8b a8 04 00 00 01 f6 83 a8 04 00 00 01
> [�� 37.378219] RSP: e02b:ffffc9004044bd18 EFLAGS: 00010286
> [�� 37.378219] RAX: ffffc90042880000 RBX: ffff888107260800 RCX: 0000000000000000
> [�� 37.378219] RDX: 0000000080000000 RSI: ffffea00041cab80 RDI: 00000000ffffffff
> [�� 37.378219] RBP: ffffc9004044bd38 R08: 0000000000000901 R09: ffffea00041cab00
> [�� 37.378219] R10: 0000000000000002 R11: 0000000000000000 R12: ffffc90040435008
> [�� 37.378219] R13: 0000000000080000 R14: 00000000efa00000 R15: 0000000000000000
> [�� 37.378219] FS:� 0000000000000000(0000) GS:ffff88fef4180000(0000) knlGS:0000000000000000
> [�� 37.378219] CS:� e030 DS: 0000 ES: 0000 CR0: 0000000080050033
> [�� 37.378219] CR2: ffffc90042880018 CR3: 000000000260a000 CR4: 0000000000050660
> [�� 37.378219] Call Trace:
> [�� 37.378219]� <TASK>
> [�� 37.378219]� early_amd_iommu_init+0x3c5/0x72d
> [�� 37.378219]� ? iommu_setup+0x284/0x284
> [�� 37.378219]� state_next+0x158/0x68f
> [�� 37.378219]� ? iommu_setup+0x284/0x284
> [�� 37.378219]� iommu_go_to_state+0x28/0x2d
> [�� 37.378219]� amd_iommu_init+0x15/0x4b
> [�� 37.378219]� ? iommu_setup+0x284/0x284
> [�� 37.378219]� pci_iommu_init+0x12/0x37
> [�� 37.378219]� do_one_initcall+0x48/0x210
> [�� 37.378219]� kernel_init_freeable+0x229/0x28c
> [�� 37.378219]� ? rest_init+0xe0/0xe0
> [�� 37.963966]� kernel_init+0x1a/0x130
> [�� 37.979415]� ret_from_fork+0x22/0x30
> [�� 37.991436]� </TASK>
> [�� 37.999465] Modules linked in:
> [�� 38.007413] CR2: ffffc90042880018
> [�� 38.019416] ---[ end trace 0000000000000000 ]---
> [�� 38.023418] RIP: e030:init_iommu_one+0x248/0x2f0
> [�� 38.023418] Code: 48 89 43 68 48 85 c0 74 c4 be 00 20 00 00 48 89 df e8 ea ee ff ff 48 89 43 78 48 85 c0 74 ae c6 83 98 00 00 00 00 48 8b 43 38 <48> 8b 40 18 a8 01 74 07 83 8b a8 04 00 00 01 f6 83 a8 04 00 00 01
> [�� 38.023418] RSP: e02b:ffffc9004044bd18 EFLAGS: 00010286
> [�� 38.023418] RAX: ffffc90042880000 RBX: ffff888107260800 RCX: 0000000000000000
> [�� 38.155413] RDX: 0000000080000000 RSI: ffffea00041cab80 RDI: 00000000ffffffff
> [�� 38.175965] Freeing initrd memory: 62640K
> [�� 38.155413] RBP: ffffc9004044bd38 R08: 0000000000000901 R09: ffffea00041cab00
> [�� 38.155413] R10: 0000000000000002 R11: 0000000000000000 R12: ffffc90040435008
> [�� 38.155413] R13: 0000000000080000 R14: 00000000efa00000 R15: 0000000000000000
> [�� 38.155413] FS:� 0000000000000000(0000) GS:ffff88fef4180000(0000) knlGS:0000000000000000
> [�� 38.287414] CS:� e030 DS: 0000 ES: 0000 CR0: 0000000080050033
> [�� 38.309557] CR2: ffffc90042880018 CR3: 000000000260a000 CR4: 0000000000050660
> [�� 38.332403] Kernel panic - not syncing: Fatal exception
> [�� 38.351414] Rebooting in 20 seconds..
>
>
>
> -boris
---end quoted text---


From xen-devel-bounces@lists.xenproject.org Thu Feb 24 16:11:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 16:11:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278451.475705 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNGi4-0001kL-7L; Thu, 24 Feb 2022 16:11:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278451.475705; Thu, 24 Feb 2022 16:11:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNGi4-0001kE-49; Thu, 24 Feb 2022 16:11:16 +0000
Received: by outflank-mailman (input) for mailman id 278451;
 Thu, 24 Feb 2022 16:11:15 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=VLhp=TH=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nNGi3-0001k8-Hc
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 16:11:15 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 63971f72-958c-11ec-8eb8-a37418f5ba1a;
 Thu, 24 Feb 2022 17:11:14 +0100 (CET)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2113.outbound.protection.outlook.com [104.47.17.113]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-19-VZb2S2PqOaWZHsZMRFk3xA-1; Thu, 24 Feb 2022 17:11:12 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM0PR04MB7009.eurprd04.prod.outlook.com (2603:10a6:208:19b::24)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Thu, 24 Feb
 2022 16:11:08 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.024; Thu, 24 Feb 2022
 16:11:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 63971f72-958c-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645719074;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=DbGOzmSn+1hs/xlf3H8j1wvPbL6MWHAaVHEbBRxUdn0=;
	b=ZeGU5JuN5N0t+WSBAbVTkPBO4APCS19mokrawOnM87/RRn0rU/YJ8t9A4f33uofV9/bxMp
	zLgPnaLmFF/1uVSaCrza+u1K8G5s7D9oX1jMe6jDRCbpW5w8nwsOLp3L0AuuYk/38nR7kz
	6c/ApYh3HVVp7n3Ik8PeJFD+6YxuQ+s=
X-MC-Unique: VZb2S2PqOaWZHsZMRFk3xA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gklaYfKXougR3U17BnOJl5tQo04d8wp1n1W0UD8OxYUlI5KF1hUKgtxY/RI6jxmBvT/JvWlJ+jpjiA5LtYG264541Pz8aUVEcVI2GrOUG0msUAvt7bh+YOaGdnt7hu0yIILU7IIKsh7ZioBR7+pl3uN/lVoPgym9FDmJTuOUxHHsnqYrdVLAqJmDuAyHNaT3dSGkJfRY33V2TAYfWDlkYYkOnbkkrhVRHoiXVVZY54E5mns+HvoLOOL0zrfg6zTrfkUgLQRj/8WH0fwb1rim25HWj+R+6kYWIkHqJBkCAS03YpO0jLWlExRhvYlZ2388S73k9UkrXHHNKVppSyaBaQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=DbGOzmSn+1hs/xlf3H8j1wvPbL6MWHAaVHEbBRxUdn0=;
 b=R2Q325Ii6lpCXnGWZITP1NPgpoY9TdSV7KPA5Zi1qPkNx7lb4AjmjdMSGrUlGoVcENVVjx/J5U5vTx5kjng2Yiap9ek/DkelvpP2UF9CtRqGckUztGOxB9csbdhTeHAgVTgrfw6g2OMs3ERdwRdyIBn3dHyPh7skthRJpnaH5ZwuDC/3zrGH5JK5/z8jnTx2NfZxU44kXCFjrI3a2FZAQSjILXT3e7jOGfx502n+dlHki2oPw5hA/PCMWw23SynJlDdz4q2XV9+P2Zlhtgf47VARu2Mqe/StoBbnjqFCWgwilE1mIwHAlUh9U0XM3BRZycpATc3D7erHzDx5KrwnUg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <15e71984-37db-c6c2-5feb-05c8f1ad85f7@suse.com>
Date: Thu, 24 Feb 2022 17:11:05 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH 2/2] xen/spinlock: merge recurse_cpu and debug.cpu fields
 in struct spinlock
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, xen-devel@lists.xenproject.org
References: <20220224105436.1480-1-jgross@suse.com>
 <20220224105436.1480-3-jgross@suse.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220224105436.1480-3-jgross@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR05CA0024.eurprd05.prod.outlook.com
 (2603:10a6:20b:2e::37) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: cefad1f4-8362-4320-b51f-08d9f7b04390
X-MS-TrafficTypeDiagnostic: AM0PR04MB7009:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB70098185D83BC8A68666783FB33D9@AM0PR04MB7009.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	nlG6zNZe/AGAidw//G9XBSBoCLxA2SVEeywMjWFGcnqVNJxcOK2QQ7O/gwAzZnuklpAXby1m0Ffiw0AyXpT0HoRn40nce8lqANdoUXFTtaFYfpknw0Fqs6xjzdYnQvxs+UPx6krtT6o7iTThlh4KjnScaeGIwqS7FwnT09dwrkuX8tCvBy2Mhv0MS3n+9R9ZVOrEO+fs/+nU2yEC1n3/5o6fX78ABNm0Z+woiOayWXOIi3KW4ZO5WVFyUqxbXFdCIda3nxQx90+7JjDwHBvb5lCqpke+2N9ff1p5NmogU834tEE2i9fnnz21EHhO5K/16E8bHram9mUawtijlii3TBjhLay+oYjptobA5paqY/qrVKsJgrQ5RHXpRn8OhlRlZa6LOBcpmDH2osJ1zTOKmypIvATyYu6TSUmaGovR/mcq87liEiBHhzdp8XzdIuToY1P+d9eqDcBIgRU7URMJuzlT/ueSaro5vl5ZxVTBp5TkCss7LfmAZjBZuFhTDTzKkYP03QufkjaP8HQ/mwJLxFHktKITS3LQbXlXCse8Gt9kRbX9Zc3lGCf62Ud2w10q8Q5V50p+m5fR5++7mh9Yu7GY/nTnPnNvpGNzODsVjmDfVNLlN9qA4Ig5l+7ZLZV7wi+afyDDsClHJDK+3uTa6xl+VXWSrxB2czFKRg0Lfuayw8LXwPpZy1kOgOpV1KOQN4L5cztAfW0KYWSJS8+JQObyoQ+pS1PH3aEmK3/ssSA=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(83380400001)(26005)(2616005)(53546011)(186003)(6506007)(6512007)(36756003)(5660300002)(54906003)(316002)(31696002)(6636002)(37006003)(86362001)(66476007)(66946007)(4326008)(508600001)(6862004)(2906002)(38100700002)(31686004)(8936002)(66556008)(8676002)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Zks4azQ0N1czZGlqdXN3bDQ4Vjc3eWJIRkx2TFNKOU9Gd1FtN2FiZVU5aFhF?=
 =?utf-8?B?WkFyanBPRXRVd3hjbkpaaVpvQnBkc0V1UUk2ZS94UElyQSt3aFMzbzdadlFt?=
 =?utf-8?B?Umd0c2ZTem1EYWVSdVluYzgyL09wYW1aNnZha21iaDRNZURnbzVxcmhUL2g2?=
 =?utf-8?B?bGRZdS83aGVNY1JQTWFKNkQwSno4TkgvaHJkaEJqUmluT3p4ZTNuM21EaTVG?=
 =?utf-8?B?VlZsZWd3aVV2QW4zSmw2dldwVkRFZXp2b0dMcFJibTROUkNhWjlIZEdVUWFM?=
 =?utf-8?B?TFF0TEQraUF1QVpKOHVFRk5qVHhrMHZrY0xNQ2pKNTRrQitzTTA5dXAwMWhW?=
 =?utf-8?B?OFpSV0w2UTlIbjBrVnhUTFVlRVRzTC9zZmdMcERGM3lSR29GOE1qeDI0Mmxw?=
 =?utf-8?B?c29uUnVVV1VrSGMvSzZhdFBaSWptYmp3Z0JRMTNIZzEvb2lpNXFrTnZsUTY2?=
 =?utf-8?B?L2tJZnBreDU2Q2wvTnFQaFNKK3FvUGxzdTc0dC93ajIydUx2anV4RXJ4Q3Vn?=
 =?utf-8?B?NW8vREVQRzNmSGIzMHdmRE5KSUkyRTJJTDFnNFRwY0M0aXdONXB0aWJjTi8r?=
 =?utf-8?B?dVNZayt2TTNyY01TQUJRbFFyTGViTWZzbjczUVNaNUNYV2NHNmhFZlpyNEQy?=
 =?utf-8?B?V043dUJ1aU52NmJ0dUF2V2N3QWVyakVlclNpZXI2M3p0bitoNUlja0JMVFNM?=
 =?utf-8?B?OUZEWWpJQW81N1pONVNxK2EvM0xjTmQyVDdUYWhSWldWL1czUForZVpLNXYw?=
 =?utf-8?B?SjRSWkpjcm02cEdYQWNOMEFPUFZWOHVtKzFHSGM4UGlhdVNwTGxYMVl4SmZX?=
 =?utf-8?B?THJPYlo0L2tMaDExR1g0MFpQbHU3WGVONVlNYWZDSllIbGp1NGFzWFRRemR3?=
 =?utf-8?B?ZWtWTkZlVGd2N1gwbUV6U0p6dm5ESnJtdCtZV0lBWStBeEVpb2J3WXVvVXh1?=
 =?utf-8?B?bERzVGpxUFgwSWZFbTNJb3N1M1ZyVXhzQkN0OERNcDcveEpRbFhyQktFd0tn?=
 =?utf-8?B?T1dvYmduK1JIUTlTUHJEcWdSS21YZzk0VUluRm5RQzI4SHVMYytra1lQQWtu?=
 =?utf-8?B?WjQwNGdyWVBwOWluZnI5SzAyQ1U1SWtYRzg0QmxvUHQxOFFWRE56REloME9V?=
 =?utf-8?B?L1FvUjh2YjJGOGY3ZTFKYkVoZ1NYbkJVV09xMmxvZFpRSS96cEdUVHBJQlFn?=
 =?utf-8?B?VXZ6dm14dXZTQ2FoaGs4VWFyMldFbUZ2SVFwdWlKR3N3WTJSUThVZ2hyNHpK?=
 =?utf-8?B?cE5Jd29kTFZOc1FIbHRHd3ZZZ054OWsxMVJJd3ltL2VXYnBJRHVIZUxtS3Bz?=
 =?utf-8?B?Q1ZLRy9tOHNZblFaTHl6U2RNS3VIK09Sa0ExZEsxdngxc1d6dHpXR1pRRnNG?=
 =?utf-8?B?MWdNWWVLcXdTa0tabnM0a0RCTUYxTkl0K2xkV09Kb1JLYi9wcHFnN1g2dVdN?=
 =?utf-8?B?V0NhaVBwdldaVHc2bXExUUhTN1NQMk4zTXBiNURaZXlNdS9tR01GMEczM2ov?=
 =?utf-8?B?NFZHVDRWZUtOdjJMNUh2djRwVTJmOEFFUy9TTkViR2VwdE10WElvZG40Sml1?=
 =?utf-8?B?bDR2dU1YeGFqbHVLczdVUXN2MlBlZm5Hc2xCVjZUaDN0VUlQbk5LOU1jeTFI?=
 =?utf-8?B?TUdxTVQyekFqcHdXZmdNZHluOThDYzYzdTZOcDV3ZEdEYjI1bS9KenhBdEFG?=
 =?utf-8?B?bWlMb0JUUTZPMDFMUk5ROTNpWmk5Sy82c1JGTUVqTDZ2MkIyRll1VEJkRXZX?=
 =?utf-8?B?Mklkc2pIZ3c0UDgxMnVqWmh1UmZ3ck1vTTFvek1GR2J6RDcxZTBCa004am4y?=
 =?utf-8?B?RnlVQVY2djdwMVVockhHMmJVMDJxNTkrV0pqMmNGdnUrS2ZoWlc1djVXdVky?=
 =?utf-8?B?ckk1Vmhjd3NwSVVBcWk4SUdZc0FvMkE2YStLRS9RRmNIL3pyd1lGOGNIR3Rv?=
 =?utf-8?B?eWJGMVkwSFgwVjRaWkE2OHN0N0NsTGNPejFHSTVxNVB0Rmt1eU84YkVhaUlY?=
 =?utf-8?B?TUJYVkNKNlA3TzFHUDkwT3YzWStLSDBwblFPTjF4Z2g3dkRzUlBWWGViLzJY?=
 =?utf-8?B?cnZjV3NEUnRpb053akQzQkFOOHpWVnJBTG15N3FSdlVMaGxyNFRTNkVPeTFk?=
 =?utf-8?B?QTV2cVRYV1NjU3NBaU90S3hGbG5WUWhRL2s5LzhrcmJZRXMyQkMvUlZuRUdn?=
 =?utf-8?Q?ejnUQY1DULk4XWsc91/QU3M=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cefad1f4-8362-4320-b51f-08d9f7b04390
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2022 16:11:07.6215
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: K0zrQX0BnjQNBULQDVXii8W5DgpbRklKzz1BzlT5o2vXifOdIgWMQAkqaT6856vCd5PHXqihSV8k3f7XRWU3PA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB7009

On 24.02.2022 11:54, Juergen Gross wrote:
> --- a/xen/arch/x86/mm/mm-locks.h
> +++ b/xen/arch/x86/mm/mm-locks.h
> @@ -42,7 +42,7 @@ static inline void mm_lock_init(mm_lock_t *l)
>  
>  static inline bool mm_locked_by_me(const mm_lock_t *l)
>  {
> -    return (l->lock.recurse_cpu == current->processor);
> +    return (l->lock.data.cpu == current->processor);
>  }

I see a fair risk with this: Behavior will now differ between debug and
non-debug builds. E.g. a livelock because of trying to acquire the same
lock again would not be noticed in a debug build if the acquire is
conditional upon this function's return value. I think this is the main
reason behind having two separate field, despite the apparent redundancy.

Nevertheless a few more comments in case I'm missing something.

> @@ -81,19 +79,19 @@ static void check_barrier(spinlock_t *lock)
>       * However, if we spin on an IRQ-unsafe lock with IRQs disabled then that
>       * is clearly wrong, for the same reason outlined in check_lock() above.
>       */
> -    BUG_ON(!local_irq_is_enabled() && !lock->debug.irq_safe);
> +    BUG_ON(!local_irq_is_enabled() && !lock->data.irq_safe);
>  }
>  
>  static void got_lock(spinlock_t *lock)
>  {
> -    lock->debug.cpu = smp_processor_id();
> +    lock->data.cpu = smp_processor_id();

This assignment breaks ...

> @@ -230,9 +228,9 @@ int _spin_is_locked(spinlock_t *lock)
>       * "false" here, making this function suitable only for use in
>       * ASSERT()s and alike.
>       */
> -    return lock->recurse_cpu == SPINLOCK_NO_CPU
> +    return lock->data.cpu == SPINLOCK_NO_CPU

... the use of this field to distinguish recursively locked locks
from "simple" ones. At the very least the comment needs updating,
but ...

>             ? lock->tickets.head != lock->tickets.tail

... in how far this is still a sensible check in debug builds is
also questionable. The effect here certainly also deserves pointing
out in the description.

> -           : lock->recurse_cpu == smp_processor_id();
> +           : lock->data.cpu == smp_processor_id();
>  }
>  
>  int _spin_trylock(spinlock_t *lock)
> @@ -296,22 +294,24 @@ int _spin_trylock_recursive(spinlock_t *lock)
>  {
>      unsigned int cpu = smp_processor_id();
>  
> -    /* Don't allow overflow of recurse_cpu field. */
> +    /* Don't allow overflow of cpu field. */
>      BUILD_BUG_ON(NR_CPUS > SPINLOCK_NO_CPU);
>      BUILD_BUG_ON(SPINLOCK_RECURSE_BITS < 3);
>  
>      check_lock(lock, true);
>  
> -    if ( likely(lock->recurse_cpu != cpu) )
> +    if ( likely(lock->data.cpu != cpu) )
>      {
>          if ( !spin_trylock(lock) )
>              return 0;
> -        lock->recurse_cpu = cpu;
> +#ifndef CONFIG_DEBUG_LOCKS
> +        lock->data.cpu = cpu;
> +#endif

Maybe worth an ASSERT() in the #else case (and elsewhere as applicable)?

> --- a/xen/include/xen/spinlock.h
> +++ b/xen/include/xen/spinlock.h
> @@ -6,26 +6,34 @@
>  #include <asm/spinlock.h>
>  #include <asm/types.h>
>  
> -#define SPINLOCK_CPU_BITS  12
> +#define SPINLOCK_CPU_BITS      12
> +#define SPINLOCK_NO_CPU        ((1u << SPINLOCK_CPU_BITS) - 1)
> +#define SPINLOCK_RECURSE_BITS  (16 - SPINLOCK_CPU_BITS)
> +#define SPINLOCK_MAX_RECURSE   ((1u << SPINLOCK_RECURSE_BITS) - 1)
> +#define SPINLOCK_PAD_BITS      (30 - SPINLOCK_CPU_BITS - SPINLOCK_RECURSE_BITS)
>  
> -#ifdef CONFIG_DEBUG_LOCKS
> -union lock_debug {
> -    uint16_t val;
> -#define LOCK_DEBUG_INITVAL 0xffff
> +typedef union {
> +    u32 val;
>      struct {
> -        uint16_t cpu:SPINLOCK_CPU_BITS;
> -#define LOCK_DEBUG_PAD_BITS (14 - SPINLOCK_CPU_BITS)
> -        uint16_t :LOCK_DEBUG_PAD_BITS;
> +        u32 cpu:SPINLOCK_CPU_BITS;
> +        u32 recurse_cnt:SPINLOCK_RECURSE_BITS;
> +        u32 pad:SPINLOCK_PAD_BITS;
> +#ifdef CONFIG_DEBUG_LOCKS
>          bool irq_safe:1;
>          bool unseen:1;
> +#define SPINLOCK_DEBUG_INITVAL 0xc0000000
> +#else
> +        u32 debug_pad:2;

Prior to your change we had two well-formed uint16_t. You replace them by
five new instances of the being-phased-out u32?

Also - do the two padding fields really need names?

Jan



From xen-devel-bounces@lists.xenproject.org Thu Feb 24 16:12:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 16:12:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278458.475717 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNGjQ-0002NM-N6; Thu, 24 Feb 2022 16:12:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278458.475717; Thu, 24 Feb 2022 16:12:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNGjQ-0002NF-Ju; Thu, 24 Feb 2022 16:12:40 +0000
Received: by outflank-mailman (input) for mailman id 278458;
 Thu, 24 Feb 2022 16:12:39 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=VLhp=TH=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nNGjP-0002N9-5s
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 16:12:39 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 959b46c0-958c-11ec-8539-5f4723681683;
 Thu, 24 Feb 2022 17:12:38 +0100 (CET)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2106.outbound.protection.outlook.com [104.47.18.106]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-3-QXE8fecLOuebZUWcgNbJeQ-1; Thu, 24 Feb 2022 17:12:36 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM0PR04MB7009.eurprd04.prod.outlook.com (2603:10a6:208:19b::24)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Thu, 24 Feb
 2022 16:12:34 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.024; Thu, 24 Feb 2022
 16:12:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 959b46c0-958c-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645719157;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=fes2X8LHR3MmHa1Ck0Ecg5/fD1KI8vhvIkifjMXos50=;
	b=b/PAzeJGzH75exYi/GIBLSfHsgY14AmCs/z4ODVHvix4WuoocfYOjF1dEF5xi+LZukjGb2
	fl5jpskDDoJPdsmVPd+0d9bEraRHJnALpxyxj5bdI5u3SMtOUi7oO6otCVy1MqWdNWpQKF
	FIi6a1ZDWT4WKRV5SDOMtYp+ImqDO3k=
X-MC-Unique: QXE8fecLOuebZUWcgNbJeQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=n1AsVCk6Px3c2/+YbNqJC29nsRKKNDHPplikvJ3VPMMSkpOr4pC7T9Apeq7GB8Qa4Yd/DaSqRgjI4LWH8ANsPJ99jtQ3O/Tx7f2ov3ya1qR1zc6XZ7irbhH2roBq3cs9ue0Y7+NCZYAb4DMr36T0uuFaTho/AsjGyOVmJEmFsHWWCgqnxtgjmwvcuQdFuamWrhHRnoAjHvj6bqCsSllD2PNgGtN36VZDtXKu8k4KAnxUvUgz0zxsb0dA3ndj0otp6C9OiDZKXiuiFerHhqzZIBtviNe+NEbdsSNx5cjoTP/RaRfDsj8hkjb7BahTCU5yy2CoADkmAZQiL0HrDKkLiw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=fes2X8LHR3MmHa1Ck0Ecg5/fD1KI8vhvIkifjMXos50=;
 b=H92E9n1bEdFo2IwoUmjzHzKwjdlMxvyO21bmozor8UHgX4v8V2eEy7D5E3DDHsVsX6TVBjWRCkJQZSXCfKRyxpW1g7S1JN02GIj2O2UwupIuJ0JFVM3FSWvN9AvxBhk9i4awz8yA0RcGMx4vtufDx8m/nxLe57+4Rk3PLmFtntv9iOUOutfckYduZjUt1XnLse4GIPdj0hBxr4H7amtB2Lx507Y2IEL1s013HwyxHpEHujfXf+xNB16MNGLgXUsjRJJfBx2tmengmgQQsJbuUl7esg35I5mIJ3tE9BE1+IWBVAw3uZ/1IC/b2R4FKft8EpJ0ps7COmMLICxzMwXJdA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <7009dbf4-d814-6181-7315-a4fce21ee338@suse.com>
Date: Thu, 24 Feb 2022 17:12:33 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH 1/2] xen/spinlock: use lock address for lock debug
 functions
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220224105436.1480-1-jgross@suse.com>
 <20220224105436.1480-2-jgross@suse.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220224105436.1480-2-jgross@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0157.eurprd06.prod.outlook.com
 (2603:10a6:20b:45c::32) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f8547a57-f89b-4b29-ebef-08d9f7b077d3
X-MS-TrafficTypeDiagnostic: AM0PR04MB7009:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB7009C263F6D124979FA91411B33D9@AM0PR04MB7009.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	RKzXo4Yf9UbLlQnEH4DBNOVa1comUaP7TK7RUHC+qhK06oFp97f3nouA+OD+XN9F65LL2Ils28usZpRc2MAHRYJl4S0hWajMhqtTpvETP96wAPzdaKmp1/OjaXZNjd8JamBcUf8tHzbQfh+6KYqRi3+PVZSStlByXDHak4C6zEXemx4WdmY8BTObrx67aMlhbYuaQWmCpZCZiNTZyVyyKkKmxpYJSGPUDhEqnmRIEA/5d/+rKK0conYZGyWQtbD6zoMWfffnJBK51kMUxvPlQLWoDni/ok7pQXecdbO7UdyUsZegA/xeKwEOgSXYj3esTgPPvey2Wq8Vhtz/9tc5GjZnBal5VsgPbvBvlg2YJH/ibrsyZhQ8iAQCkR/KlxlrpsbcOW5DWg5GX3mRjAzO2GFVLZQ8Um/v2y7cSdXrM76LF0cvEiP5pgq4TlhyPBmvsu5qq/wMFBkgcAEZrMUTmjuTtllw3phOTHcRm5qilYYGKEGV7wR0HiTEJUFmtW0ZYVwC9zJYvEGOXiVwswHYUpHEWYHD3Vil3zib2xXtBFrtznPk9AZnSwPV21xwc+ueiyzsj7viReoezj3GAd5d1qKOKUwxeXi37kgBSjsDYCXvF9kASm+XQAy0wcJOrYBD2j77ZhOs+7UBEwBvtizeUj+p+e0E/qcq49NcOmVCwi1F2Ts/K9fo2P6uLHkPGnoE9F+Leiy0a6Y/r44HpNI14fxosNGTqEvLXGjpqCu10cE=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(83380400001)(26005)(2616005)(53546011)(186003)(6506007)(6512007)(36756003)(5660300002)(54906003)(316002)(31696002)(6636002)(37006003)(86362001)(66476007)(66946007)(4326008)(558084003)(508600001)(6862004)(2906002)(38100700002)(31686004)(8936002)(66556008)(8676002)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?c0N5YWVITDI2djN4VWgvTHg5UVNCUE1mdUFDZEUxakY2ZHV3S3doTlNUNGY3?=
 =?utf-8?B?ek1HUU1GU1c3ZU8vUnFpTldlYmRDRGZ0QW4xT2dRVzhtN3hTK2lHdzhmRUVh?=
 =?utf-8?B?VXhiZDUzRnh1L3l3blhKMC9qUzR6OXFVQ2QxL1NXRzdjdkV0K050cDlFelV3?=
 =?utf-8?B?NEhiaWEvQlR5UHVHZmZ3L2hVTXFBUjV4T05uYkxPY1ZvV2xqZHJlbjZlRVRt?=
 =?utf-8?B?Q1dGWmpiRTZCeEhOMUltanZrdlI1SHd3d3luakFCQkNrU0dNQ0F2N0k1N3J0?=
 =?utf-8?B?eWVBUnd6Yk82S05JdXdqRndkQjdpUitpTytwYkRWVkRYMXV0Kys0Sndna3Qy?=
 =?utf-8?B?b0lJQlJOR25HVjBRam00Vzd2aWdYV2ZIMWYrT2pBUDVrOGRBb2xUNXE2ZVht?=
 =?utf-8?B?ZW82VnliM29yZ1FFMnRrTFdpSEJjRFBqR0lxTytnUmZtSzR3Q3VtYjNOVHhW?=
 =?utf-8?B?R0tqcmJGNngyb2RnVlV3ckRXRHBnRFA4M1BYZU93cXZxRnQ2Tlk1U3BjRzlP?=
 =?utf-8?B?NTRDN1ZrdW9JMnZxTjR1WWx3bW9xVi9uZlJPYzkzVW1BYmJ4VTM4OEdrSk4r?=
 =?utf-8?B?dDFOakIrVGVSaGwweCtiYktiRkx5WWJFNDk1UTk1L0lObkVORTVXZDJ5T3Qw?=
 =?utf-8?B?czd0enI1VFBMZVFnK29hVy9icHViTHF4ejBsNW5DcEZQeXVjbVlPdXRldDNq?=
 =?utf-8?B?czFHcGRZc1JhYVorY2JnaUlmck1WK2ZlSUx4b0IyYzVGQWorYlBGSXJTUE5D?=
 =?utf-8?B?VjZUN1hDV0h2MHhybXhnT2tOWXFmMEszVXR4ZFZQemNNcnNCMGd3ZUcrQ0Jp?=
 =?utf-8?B?bHlraHdBdWxRc0FJdk5NTWZMd0tBYmFCbDUxaS8rRXFQVlcybFJQVE1YNnd6?=
 =?utf-8?B?V1pVbklCd0JFVmVCemxOSERmcy9YSnhIQW81bjduS0Z6cDlaUHFCZW1aUUdv?=
 =?utf-8?B?WVhJdzIxZzVvTXExZmJIQUtnZ3dhY1BuTVhCY3JhMGEwcnU2SkpqZ0ZubHFO?=
 =?utf-8?B?aExnZDF2dWRYSWxKckhsTHA1NGxLczd4UHVvckxRbWhJNHZnWGJ6Y3JzNDFn?=
 =?utf-8?B?M1ZYeXJqbmR1TDFOU0NDZGprUURydDhsU2d6b0tTN2VSZnNveldvRm5XeFpw?=
 =?utf-8?B?bjNHSzhTTVdRbmdtQ2owNDBlYjJ4YWNTZWs1UmpKN2dtcHdaQ2w2SkhIMGJW?=
 =?utf-8?B?Y3JxSVZ4aFNGYXpxSEhqTnpNdk1XV3lNZEpjcHdmbHd2RFNpWjNaYVhtNHow?=
 =?utf-8?B?OXl4elQyUjZnRlEyZFozMFovZ09xMFBiTG9vTjZiMzQ2aXVIYjRObm0vZzN4?=
 =?utf-8?B?RGtLS0drdFFyZVp4dVZQTWJnMU5PMjloa0plOFlaOXd4M1JiZGM1eWpYZ0NT?=
 =?utf-8?B?ZnlaWmViMHJDZTg2TGVIcjBBUzdlSmkwdEdzTnJJem5OZ2dwVkk2d1ZodW9Q?=
 =?utf-8?B?M2ZzWlA5QlQvYlhEcDk3QWY5azJrNTloU1c2TVpTK3c5U0JwcWVjU0l2cjd3?=
 =?utf-8?B?Vm84NDdrSDlkcTd1alcwNW5pOUFyQ3Y3STNJSm5iNERiK0ExR2QxZm8zM0Uv?=
 =?utf-8?B?SFhLM3RHcTFUcmpsQXVBbStNaXJXY0ovcmQwSlZaNWVJbDNlays4L3VoTURh?=
 =?utf-8?B?aDZtSjRBRjU0cUR0b1p6MVQvZ3dpcVlXclZvS2ErWnR1b3VoNUpQcFNzdTNK?=
 =?utf-8?B?NGh3N0JLZGxuejloNmdoUnp3WDc1NGVNSVkwanNJSzR3TlAxaXdMblVuV1lp?=
 =?utf-8?B?ZWZZUlNHZmxmMHgzbnNGOHAyQ0MxajNYc3dRMDRRb0dwa2gvVXRNNXBVazVU?=
 =?utf-8?B?MWpaRzJWY0x2Vi9xWDg4YzB2SHVMb1crMDlFZEN1WU1GZS9lVGRxc2lOajhw?=
 =?utf-8?B?dGNFbHkrbWpCeUs1U29Hc3ZUTmFNSHZOb28yR3hvL3NhaW9EWUdRSHpkOC9k?=
 =?utf-8?B?UVFuKy9tNHYyL1BjOG1YTEFUbWVKaVJKSWRwczFEMXBGY0RhT0k0VFRwbC9U?=
 =?utf-8?B?dUFGa3BtOVhQQUdLV2h5QUVvWVVneW1vMnFPY3I1MU5LYlI5b3RXRDVlUkVG?=
 =?utf-8?B?TmJnbHhPOUoraUc3MVdzZXljR1BaWFhpcFlHdmRibk16L3dBemxsZUliV3pF?=
 =?utf-8?B?NjZvL1dGNFlFZHNGaVdvMTkvY1JEQWdNd3N5RXhsNHVpVktWR215SW5rd3Fk?=
 =?utf-8?Q?Jba6qUq+U6dZp7BZbSN7PR4=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f8547a57-f89b-4b29-ebef-08d9f7b077d3
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2022 16:12:34.8036
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1iFnLf6ucBKEKDoXjc+6HYyAUJlPiI5R7t7Ad2Rg934zwnwKLFAzOEVF82ddgV0ZDWzxk9JpWUSh6KR0QS2tEQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB7009

On 24.02.2022 11:54, Juergen Gross wrote:
> Instead of only passing the lock_debug address to check_lock() et al
> use the address of the spinlock.

I'm uncertain about this full exposure. The next patch looks to again
only use the new "data" subfield in these debugging helpers.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Feb 24 16:19:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 16:19:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278467.475727 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNGqF-00035J-EI; Thu, 24 Feb 2022 16:19:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278467.475727; Thu, 24 Feb 2022 16:19:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNGqF-00035C-BL; Thu, 24 Feb 2022 16:19:43 +0000
Received: by outflank-mailman (input) for mailman id 278467;
 Thu, 24 Feb 2022 16:19:41 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=FHEV=TH=oracle.com=boris.ostrovsky@srs-se1.protection.inumbo.net>)
 id 1nNGqD-000356-6m
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 16:19:41 +0000
Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com
 [205.220.177.32]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8ef3573c-958d-11ec-8539-5f4723681683;
 Thu, 24 Feb 2022 17:19:37 +0100 (CET)
Received: from pps.filterd (m0246630.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 21OFdutD027379; 
 Thu, 24 Feb 2022 16:18:52 GMT
Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79])
 by mx0b-00069f02.pphosted.com with ESMTP id 3ecvar7f1r-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 24 Feb 2022 16:18:52 +0000
Received: from pps.filterd (userp3020.oracle.com [127.0.0.1])
 by userp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 21OG6urJ153066;
 Thu, 24 Feb 2022 16:18:51 GMT
Received: from nam11-co1-obe.outbound.protection.outlook.com
 (mail-co1nam11lp2176.outbound.protection.outlook.com [104.47.56.176])
 by userp3020.oracle.com with ESMTP id 3eat0r08r2-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 24 Feb 2022 16:18:50 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10)
 by SJ0PR10MB5785.namprd10.prod.outlook.com (2603:10b6:a03:3d1::7)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.26; Thu, 24 Feb
 2022 16:18:47 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::6d20:6694:a16:56f7]) by BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::6d20:6694:a16:56f7%3]) with mapi id 15.20.5017.024; Thu, 24 Feb 2022
 16:18:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8ef3573c-958d-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date :
 subject : to : cc : references : from : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2021-07-09;
 bh=zr0WlNi9qNdnOP6Z90PTZonM8PHLStvdmbigYILztrg=;
 b=IiOtL9tL7pCuq0X97tZ4D8UCwwHM2gNeS4Q/70hudceMNrtcMQMsf9gTYgGs4M6P1JEM
 mitycnGr4w2I47jgEn8+mDw/nPJo+B8VuLRiiWRArY9PDVWJnSV8JOtDXtqe6P2aoHk7
 3bFlMPg/bcpp3dp3Y+i06jAnUm2d4jiwSBK7oO+BxWz6kVRAmTHYr5Hw+fJBxeLOG9NT
 fPB4fKauzpfQuFzVtGxw5gnPbMyCROx04578/aUbG3pC/3wbx1d7jPC2ig8+gpKo6Q3L
 sk/7RjeyisRjrVQ+wMunvlYHk9N1nWiqdhcWuxcSvDchncemdUHZ+i6l0a4HPTunekti iA== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=VXt4gPUkTZgD/tX8jtbO2kGJpp4QN/h6qFwQUt7y2BXVo2F4mCRpoq9QZ7wtidXUkzDizqdioM/DDC3Oa0OOJmP53fGT505WotQ7pnYVUmrSCsGt36qdrs7ttqcvEGkXD+yGS/sRB82ClYFJBDlcoOVch6Xztgn8etYRzsZqpu9mnDDrGI4SIh3J2GNiisuflyZ9iaTTvwqqmttzEgp2ctHQOX4XghaS+j/gmr2ZQtdYe7Rkr1mqHKJgStKVXVV8z69zKazCx2KPk/iRy3V5ukvb8g8pHUYqiimSE3KcabOmi9AX9I/dCs3hUcld6ShFrGAgj0jgobnMpwxYiPgXGA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=zr0WlNi9qNdnOP6Z90PTZonM8PHLStvdmbigYILztrg=;
 b=OevHCxib6wNeE6phQUVkD4tBf0gSBmIhuKJUEtzPETJTTcMBv/jQMj4A8BFDxaEfX+TDicI7/W/3l0caZhdq/4gCIGYO7lTZMoFLcBZVymuJs7z66SGuPpEvNhH0KP03lfcMlmzFiohrV8su+81SmC42v83Q+YFMFtAdnnPyUiWudvA1FcXTRjBwO2DqnpV57133SvfhPkGza0Bw5fhrLtx6M+X84elLHY8yMvYftW6NG9udHSGVyDCEknMsgQKNVto5QK4pVWa/ZiGj2bi0TsaDD9hmi+/AnwasYCwCc4209ZCHyMgvqqijiVKb+kAI4YX9Txhge/+MNdut8ya3IQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=zr0WlNi9qNdnOP6Z90PTZonM8PHLStvdmbigYILztrg=;
 b=xkEXlWnGxdIs+nlKnCcdgN4ik1Cfr38HYXvxd8j/zcobYGUywqNr1j5wEPbPj7y5FT2j3cqBPos7WYsxbJrEAdcvVSG4pfASTN3EMMrvyhALOAwu3Fzvk8mh5CfQOHYjqGCIT4odpMsGzbHC/7MRbqEFjlJrkpt6DCBrSQWWHUg=
Message-ID: <206ba6a3-770a-70ad-96bc-76c6380da988@oracle.com>
Date: Thu, 24 Feb 2022 11:18:33 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.1
Subject: Re: cleanup swiotlb initialization
Content-Language: en-US
To: Christoph Hellwig <hch@lst.de>
Cc: iommu@lists.linux-foundation.org, x86@kernel.org,
        Stefano Stabellini <sstabellini@kernel.org>,
        Juergen Gross
 <jgross@suse.com>, Joerg Roedel <joro@8bytes.org>,
        David Woodhouse <dwmw2@infradead.org>,
        Lu Baolu <baolu.lu@linux.intel.com>,
        Robin Murphy <robin.murphy@arm.com>,
        linux-arm-kernel@lists.infradead.org, xen-devel@lists.xenproject.org,
        linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org,
        linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org,
        linux-s390@vger.kernel.org, linux-hyperv@vger.kernel.org,
        tboot-devel@lists.sourceforge.net, linux-pci@vger.kernel.org
References: <20220222153514.593231-1-hch@lst.de>
 <09cb4ad3-88e7-3744-b4b8-a6d745ecea9e@oracle.com>
 <20220224155854.GA30938@lst.de>
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <20220224155854.GA30938@lst.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: SA9PR11CA0007.namprd11.prod.outlook.com
 (2603:10b6:806:6e::12) To BLAPR10MB5009.namprd10.prod.outlook.com
 (2603:10b6:208:321::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 6f7a2783-6c19-4d37-42f9-08d9f7b155ec
X-MS-TrafficTypeDiagnostic: SJ0PR10MB5785:EE_
X-Microsoft-Antispam-PRVS: 
	<SJ0PR10MB5785404B16848580DDF957218A3D9@SJ0PR10MB5785.namprd10.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	W/bEZu52wrvxS8Lc3qiHX/+2sgU55XexBsAFECyP9Cg332+w3K3WXm2xsdldFQKqqp/uv990BEgH49NNi1lGpBbWefva8/4yyx3Dwev0M9VNpOdy+drY3k6XR8wZohWcmepxH8bOimgp6cBv4wZtdFQIYydEJJZiqY9ZDqxd4LADpeEQMrXo7UpIjLT89R7HBOfmL8cH51Ftr9/ab3cIJGgxVLqb5WF1Uf95h2O3Hgx/p2+bEQLCugr6xtNGRbMHTgZlxGq0Mf6PLL4nibLBd2tYHz5tVppimWqVwBJyS6AKvktUYMMEDKodynyD4V7/DKs+fJcqkthiwRMs+ImCs8fDvn+NWTmoxmh38SKYRz8BhvWqGtHqoEobz4whThR0n8n0LUusBTaAqPsGwr747I2+we04//PhtmSNwhCC5JTmR607Ix7llgD8BBfILKyv07wmXV4+OdizOjryWZbae+lqG8mGpJ+PcheKMTAeHHYWgyjC1ufIK8gcRQJ1+9/xfH5YankCZBu/KaLab3Rri0wd/4AHwLqBFkdmsCoixOzZzwyxZM6qsQjeNWNnMzhINwiVFAIRbJb6z7DZ0sJDuBF3B/mUwceOJ1//uTv4203n0WtaQQKeU0wVggPufpvMCOfT7ys5GldA0LjhtBkbgzaS5NvmS5sg0A5vpHtXTz7lvVR2P54GWrEh4AWlIBMlDFkkF/cgn2TNLPj4eMqWckRMiS6rbrhp3wNZoDqtAfs=
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(508600001)(8676002)(66556008)(2616005)(83380400001)(4326008)(44832011)(7416002)(8936002)(5660300002)(54906003)(66476007)(7116003)(186003)(66946007)(26005)(36756003)(6916009)(316002)(6486002)(45080400002)(31686004)(31696002)(53546011)(86362001)(6666004)(38100700002)(2906002)(6512007)(6506007)(3480700007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?VktGSWRrUVJEc0NuUHhIOWtMMGlMeXNjL2VZaHJ4K3pFUC9GSzFsM1ZWRHhv?=
 =?utf-8?B?L0h6YzBvZFQ3OWVkNmFTYlFWQzNZVDRPNlJKUjJ4anBLWDBJSVJDTVEwaHpO?=
 =?utf-8?B?cUtWZjBGOVdrN21rSjFTbHBqU2ZsQ2dOOGVEdHkreGtuZitvTUJOdisrN3ZR?=
 =?utf-8?B?Q3lsMlBScXJIN1ZoREgxQWt2VXYzMlNCM3JIMUZQcGprdmtuWERwdFl6T1Nn?=
 =?utf-8?B?VGI4cVE4S294Yk50MDhwL1c1NERERnpVYWN2ci9vbGNDL0tiN1RRUFN2MTFQ?=
 =?utf-8?B?eWozWGNjU2tyaCsvajdONGRHbEdlaUl3ZjRRNXBPYXpiZWYxTkIyYlV3eWkr?=
 =?utf-8?B?U0xnT3FqQW1iejZmUzdXOEo2RlMvNmltU2tVbmlxblZ6RDZ0aDl1NUozVUp2?=
 =?utf-8?B?UzF6eDR2MCtXMDJjbElRTGlZQk54dEVEd21nR2dXZTJZVlMxek5FeWhGbFpn?=
 =?utf-8?B?L3U4OWJaVVNjRnhOOXhKR2hMb2VNdSs1dUpqaDRRNUlFT2xnT0JkRjZockVV?=
 =?utf-8?B?TElLZjdxcVBReUVEcVM2KzFEUGcxbmtrcU1HZzdWaHhqVWFsU3VDUUxIbFBR?=
 =?utf-8?B?WHp2UGJPR0JDV3VwN1JtNlNJSFl0MS81OFQ4N0VjR243c2RxTndOWmhYZWFq?=
 =?utf-8?B?cXpuZmszbkVlWHVVaU5ybG04VTZzNUpNWEdqYi90RE94UlBNait5M09XR3hT?=
 =?utf-8?B?SEV6UXRGZ2E5VTVLd1JMRWs4VDFTc2Z0bDRHQkxMTm8rL0xmYXdPTkRMclJK?=
 =?utf-8?B?NUJRS05EUVJDbFJON1Z5eDRKQTBWajFoRGU1VGlEaENMMU14YlgwZUFYZFRT?=
 =?utf-8?B?ZjJVc1JFL0h1M2Q4SEhKem5iVHg0ZklQYlg0UVBtdEd6dGxZWERCaG8raEYz?=
 =?utf-8?B?MEViaE54eWMzZlpoeW1DeVBiMTkwNmU5RVZxWGl1K252SDdqUHI3eG1MSHE1?=
 =?utf-8?B?bHBCbFg5RU9DTTVPcitXRzNEamErZ0ZsL1JERjNNbFRZdHI1S1FmN0dMdmRV?=
 =?utf-8?B?bisxc3ROWlhsSDE5UnFYLzBJNnpJbmx3am9Tc29FMThsWEpMWGtSeWpDb2FP?=
 =?utf-8?B?VzQwS0ZQajV4eVpBV1BhMEFlaWg3aDRBN2RKOHRZbzJUeWszcSs5WmIxUzM0?=
 =?utf-8?B?eTh2bHBaenNFaVlrME9iaVBpb000UzBmcW1JTzREMGZXYzc2MXNTdDFLUk9O?=
 =?utf-8?B?TnRHaFRkSjBURy9WaThYTHdHWUxVSHREd3ZsMjNadDFaQTRySjFFTWNyaHY2?=
 =?utf-8?B?aFYzZm1MaUZYQTNQNG5ocXU3NDN3S3J4V2hVK0toSDB3bThRYnJzbUNFWWRa?=
 =?utf-8?B?cTVBN255eS9QZ0VDMk1ORFFEQ3JqOWFkT29SMmdFUEFINWxXZmFGYVl0QjFy?=
 =?utf-8?B?RnlLWHN1aUMyZ1QzL1RQZFBaSUd0TzJaVlNkcGlyN2tZU1Z1Rk03R1JPZVR3?=
 =?utf-8?B?V2tSeFFWdXVhcW4yeEtoWnV3M1R4VnBsTm83bW1LOENERER6Z3QwVENEZ0xy?=
 =?utf-8?B?ZE5Sc3JReURNak5kTXFWTmRrM3J1YS9rYU9oajNPUGVteFZiWkNlek1VY0dJ?=
 =?utf-8?B?TUVRa1EvVDAySzlRNHI5Ync5TU8yeG5TWUVZdnZtYTh6UG1MeEgzZDlzRzVq?=
 =?utf-8?B?RVc0NFhhQUpkVkhYWEQ3akhLSE9TVkNnb3BzR0ZzTmtXVzdjU2xGZmdxOTRo?=
 =?utf-8?B?SFFsaURvaG8rOVV3UjZ1RjJxcVdOZU9Uc1A0dWR6b2VIOHduYXdkWGcwQ3c1?=
 =?utf-8?B?Tjk0dUxLS0Vtc2RhY25BVkE4SlNuN250Z0twVEdzTWtEOVl4YklZNEtqSXhH?=
 =?utf-8?B?Tnd0UHEzWU04VlBodC9weDB5RVFBKzF1RXVVaVkyS0V4QzVlaXoyaWs3cEQr?=
 =?utf-8?B?S0dzc3ZOVU9wNkw3ZnIzZFhJeWRhTjR5empPODVVQUhyVVUyUmF3L3Y3amNL?=
 =?utf-8?B?MEFqYzVLMkNIWFBNUFhvc2hWaUNtbSsvSFhNNGtRanUvRDJTeVRMUUlvQkwv?=
 =?utf-8?B?eGRwWHRoMW0yV2F5MDJSbmVGZ3BxWTQ2ZWU5ekZCajhJSWdCamRpanRGTDZ3?=
 =?utf-8?B?aWpjOGJZaWQzMnpjby9VMHd1S0xCSXFYaTlDYThPN1BlSXNiTVJFT2xuYzhR?=
 =?utf-8?B?MGt5ZUdnVjdLekF5bElwUEFWQ3dUb2p1V09YMUlpOXFCc05pM08zbENkME9S?=
 =?utf-8?B?dEd4MGwxRk13b21sZkNqeFhWcFB2aWxHTW1NWlQ2N0RISHZsRlAxaDRtOVd6?=
 =?utf-8?B?ZzArOVZ3RWNZUTA1NU9xK25Kc0RnPT0=?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6f7a2783-6c19-4d37-42f9-08d9f7b155ec
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2022 16:18:47.4329
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: h4wj66LLjTVIqRHUirgnySr+Yi5eVX6oo0+CbRSUavJYoZmsYLDf8zCt1AztG5nOfnW6NRwIfQRkai7q3LFjKdTcCrunBZ/fCaOe7H8QpM4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB5785
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10268 signatures=684655
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 spamscore=0
 mlxscore=0 adultscore=0 mlxlogscore=846 suspectscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2202240095
X-Proofpoint-GUID: 49gfwTdtFA3i5qMnUOXWR97xCIOKkMf0
X-Proofpoint-ORIG-GUID: 49gfwTdtFA3i5qMnUOXWR97xCIOKkMf0


On 2/24/22 10:58 AM, Christoph Hellwig wrote:
> Thanks.
>
> This looks really strange as early_amd_iommu_init should not interact much
> with the changes.  I'll see if I can find a AMD system to test on.


Just to be clear: this crashes only as dom0. Boots fine as baremetal.


-boris


>
> On Wed, Feb 23, 2022 at 07:57:49PM -0500, Boris Ostrovsky wrote:
>> [   37.377313] BUG: unable to handle page fault for address: ffffc90042880018
>> [   37.378219] #PF: supervisor read access in kernel mode
>> [   37.378219] #PF: error_code(0x0000) - not-present page
>> [   37.378219] PGD 7c2f2ee067 P4D 7c2f2ee067 PUD 7bf019b067 PMD 105a30067 PTE 0
>> [   37.378219] Oops: 0000 [#1] PREEMPT SMP NOPTI
>> [   37.378219] CPU: 14 PID: 1 Comm: swapper/0 Not tainted 5.17.0-rc5swiotlb #9
>> [   37.378219] Hardware name: Oracle Corporation ORACLE SERVER E1-2c/ASY,Generic,SM,E1-2c, BIOS 49004900 12/23/2020
>> [   37.378219] RIP: e030:init_iommu_one+0x248/0x2f0
>> [   37.378219] Code: 48 89 43 68 48 85 c0 74 c4 be 00 20 00 00 48 89 df e8 ea ee ff ff 48 89 43 78 48 85 c0 74 ae c6 83 98 00 00 00 00 48 8b 43 38 <48> 8b 40 18 a8 01 74 07 83 8b a8 04 00 00 01 f6 83 a8 04 00 00 01
>> [   37.378219] RSP: e02b:ffffc9004044bd18 EFLAGS: 00010286
>> [   37.378219] RAX: ffffc90042880000 RBX: ffff888107260800 RCX: 0000000000000000
>> [   37.378219] RDX: 0000000080000000 RSI: ffffea00041cab80 RDI: 00000000ffffffff
>> [   37.378219] RBP: ffffc9004044bd38 R08: 0000000000000901 R09: ffffea00041cab00
>> [   37.378219] R10: 0000000000000002 R11: 0000000000000000 R12: ffffc90040435008
>> [   37.378219] R13: 0000000000080000 R14: 00000000efa00000 R15: 0000000000000000
>> [   37.378219] FS:  0000000000000000(0000) GS:ffff88fef4180000(0000) knlGS:0000000000000000
>> [   37.378219] CS:  e030 DS: 0000 ES: 0000 CR0: 0000000080050033
>> [   37.378219] CR2: ffffc90042880018 CR3: 000000000260a000 CR4: 0000000000050660
>> [   37.378219] Call Trace:
>> [   37.378219]  <TASK>
>> [   37.378219]  early_amd_iommu_init+0x3c5/0x72d
>> [   37.378219]  ? iommu_setup+0x284/0x284
>> [   37.378219]  state_next+0x158/0x68f
>> [   37.378219]  ? iommu_setup+0x284/0x284
>> [   37.378219]  iommu_go_to_state+0x28/0x2d
>> [   37.378219]  amd_iommu_init+0x15/0x4b
>> [   37.378219]  ? iommu_setup+0x284/0x284
>> [   37.378219]  pci_iommu_init+0x12/0x37
>> [   37.378219]  do_one_initcall+0x48/0x210
>> [   37.378219]  kernel_init_freeable+0x229/0x28c
>> [   37.378219]  ? rest_init+0xe0/0xe0
>> [   37.963966]  kernel_init+0x1a/0x130
>> [   37.979415]  ret_from_fork+0x22/0x30
>> [   37.991436]  </TASK>
>> [   37.999465] Modules linked in:
>> [   38.007413] CR2: ffffc90042880018
>> [   38.019416] ---[ end trace 0000000000000000 ]---
>> [   38.023418] RIP: e030:init_iommu_one+0x248/0x2f0
>> [   38.023418] Code: 48 89 43 68 48 85 c0 74 c4 be 00 20 00 00 48 89 df e8 ea ee ff ff 48 89 43 78 48 85 c0 74 ae c6 83 98 00 00 00 00 48 8b 43 38 <48> 8b 40 18 a8 01 74 07 83 8b a8 04 00 00 01 f6 83 a8 04 00 00 01
>> [   38.023418] RSP: e02b:ffffc9004044bd18 EFLAGS: 00010286
>> [   38.023418] RAX: ffffc90042880000 RBX: ffff888107260800 RCX: 0000000000000000
>> [   38.155413] RDX: 0000000080000000 RSI: ffffea00041cab80 RDI: 00000000ffffffff
>> [   38.175965] Freeing initrd memory: 62640K
>> [   38.155413] RBP: ffffc9004044bd38 R08: 0000000000000901 R09: ffffea00041cab00
>> [   38.155413] R10: 0000000000000002 R11: 0000000000000000 R12: ffffc90040435008
>> [   38.155413] R13: 0000000000080000 R14: 00000000efa00000 R15: 0000000000000000
>> [   38.155413] FS:  0000000000000000(0000) GS:ffff88fef4180000(0000) knlGS:0000000000000000
>> [   38.287414] CS:  e030 DS: 0000 ES: 0000 CR0: 0000000080050033
>> [   38.309557] CR2: ffffc90042880018 CR3: 000000000260a000 CR4: 0000000000050660
>> [   38.332403] Kernel panic - not syncing: Fatal exception
>> [   38.351414] Rebooting in 20 seconds..
>>
>>
>>
>> -boris
> ---end quoted text---
>


From xen-devel-bounces@lists.xenproject.org Thu Feb 24 16:23:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 16:23:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278474.475739 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNGtg-0004SO-Tq; Thu, 24 Feb 2022 16:23:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278474.475739; Thu, 24 Feb 2022 16:23:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNGtg-0004SH-Qo; Thu, 24 Feb 2022 16:23:16 +0000
Received: by outflank-mailman (input) for mailman id 278474;
 Thu, 24 Feb 2022 16:23:16 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=VLhp=TH=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nNGtg-0004SB-7Q
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 16:23:16 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 10e5a219-958e-11ec-8eb8-a37418f5ba1a;
 Thu, 24 Feb 2022 17:23:14 +0100 (CET)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2105.outbound.protection.outlook.com [104.47.18.105]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-17-GmTHLCgrO2GXkkB4hDyIfw-1; Thu, 24 Feb 2022 17:23:13 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DBBPR04MB8058.eurprd04.prod.outlook.com (2603:10a6:10:1e7::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.24; Thu, 24 Feb
 2022 16:23:11 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.024; Thu, 24 Feb 2022
 16:23:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 10e5a219-958e-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645719794;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=UeRz2cvuqd2++ZLhwlWnNIrggwqyR2u29a5qNOTVmSE=;
	b=bQaCwDvoM1qQaSLdhyN9TciEveOr9Z3KLgS2SA7dGSS2cMsYATVZn1wShMkap+TqhGrDds
	d1SPACvbz1fo8JTrNKkNlyTzb4yQfO5ubYVgFMXQyI7TlrrtAb2dwL2mIZtrmgi6aUyaQA
	mTe37/QCGFbpzVHAITMlxgNvSWJNWmk=
X-MC-Unique: GmTHLCgrO2GXkkB4hDyIfw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Ajsgex7F9uLbUSLe1uONHuR2fLymo4LFc4IF9pH8VgGp99PN6VYuNq+yF07CGhv0BKZD91TClhguNdayY/dvMh1wdOChtwUSjcjBGtfQTL5+QAquutlt/Z+MfaevIkABO1FMsS6Vy8bekLnIOcKd4bg0mVnTuoGHsKKQ5lGxLUKH0dGV5fm8ock8e0wMOoLah+F//vvcUbh9433df7PL5w+gso5UMPY7wSZxLGfnmQuFxjJgJUJH1SQSw2WM/ysVZ9uyNKNqloV4VxEO/zL8K9v8WCWqpmx4HuMlFAEaXp3XyN+yd7hOsO0sFXnp3c2WQZx0P9YUw9FooTUqNaaaHQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=UeRz2cvuqd2++ZLhwlWnNIrggwqyR2u29a5qNOTVmSE=;
 b=JmbRp8kHNfSWSU0WEG+FI3R5yQBnhf6X6PZVeN+5zdHi7aclh52zyrTVn10PS6INFd2pCKxAP5wz3gDpioXSnESTfnKeUOpLFaxxN+6qF6jiL+EqJyx+R2p2UqdnEvU3QUvocEF1Huf4VZDT2OWzaBtEmoR/XrJSKNnmqPLbGedTIoylKl2KvLrN5jFBumpG9ao6AcOfCLpuA8AqcElLfaqFbuC+lc1YMt56b4zW8V+NA7jgdELn0X3hlrz7gC+KUy0Aj/p0aPqqbn/jEryXU/QAjWhrrMNSk5lb4Qw5ox35WeLLLRq/EzG/8vMl3FGW4nuw+pofmC/vIEd4NVBgcw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <1b90636c-2890-2ed5-1315-51f80b2d2d78@suse.com>
Date: Thu, 24 Feb 2022 17:23:09 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v3] xen/public: add comment to struct
 xen_mem_acquire_resource
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220224152414.27948-1-jgross@suse.com>
 <9972f96c-d0cc-d9a8-3566-74dbaf7e9e33@suse.com>
 <93d49d5f-29d5-72d1-c00c-ad14fb08b9c4@suse.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <93d49d5f-29d5-72d1-c00c-ad14fb08b9c4@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0402CA0013.eurprd04.prod.outlook.com
 (2603:10a6:203:90::23) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 914df0a5-26e1-46c3-067a-08d9f7b1f36e
X-MS-TrafficTypeDiagnostic: DBBPR04MB8058:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<DBBPR04MB8058EFD0192B6741A1F1AD03B33D9@DBBPR04MB8058.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	qdX1BUa3Iy4zgzzwMaDlrhGJqkUyRsR6uAF60M0bLAwcI7SrFi3/8slgLr9TEMNrgTGM8X26sm+CyPWz5tVmCuUU4c/kcTszPkM4KnXMR5NO7rGIAM963FsfSH54JWtYgaOwQXK88LxVhwblbexPADuF6DcFJVerYoSQG9BGG1OYNIOqsvUWrW/NS4au8EtPd3gYsviL5hrJ1S831h9aQGkmc4W+MeqknAFFMxzslbI6HNdcy0FiAPOtzhj6F14IDcdkmGCEmaau9GJrK2qSk3cp9EGcQkOX50ivAyRJohZCQlElOM6kLy/NCtBg7W1SPYEpW4GH9Xy8fIUrssZkyqipNxuVfbporgJYc8HFGu6DbHeppp3c5FiuKyHkFkmenk/s9yotaX36rc5gEbJNu1OyMYzqhbcMDFRlYQRv2adHZLe1upUiQoPt3jKDTc2iAI9Pg+QWzx5aFjh2UToMXKv68//rcZklCNYDh9TnerNHQv8HDmWlcepwwSxD3L9icqaxyud5I9sJ7vUk7BwQM12rLraWVd4lIFrJ7JB0df87vkOXcvT373Oa2JtiIKDIMlMevcS9Npm7mw9FCoDQrkrBLNEvYmZ5aOnidvmz1j+IKgj7jWBnvViby7FCMmZEz4/BaGupNX+WS5LaVXyHd8esLZvUOy2iB2TIbnjr7UOVV66FoUab5BMXMLY2whpYBqhkCIwdzYbq9BAucH3iM3vvdSGJjGGENPaHhZzbx6zq0QAybG8igskTxRg5k7qP
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2906002)(6512007)(6636002)(54906003)(53546011)(508600001)(6506007)(66476007)(66556008)(37006003)(316002)(8936002)(5660300002)(31686004)(6486002)(36756003)(66946007)(4326008)(6862004)(186003)(26005)(8676002)(2616005)(86362001)(31696002)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?OGh2THljSDNVK0ovblo2cnZYMmxEbythS1JnODltUzE5ZUNjanI2bFMrWlNX?=
 =?utf-8?B?MTlhMVVybGRvZTBXUlV1YlA1MFpLTFN4elJyZVZYVFRYQzRIa3dSRS9OaWxV?=
 =?utf-8?B?RllFQnpXMkJvMkk1NUVZOUdSL3UyV3NDK2Y4TXFpSzJab3ZUVElVdCtYbVhX?=
 =?utf-8?B?cm8vVytPaFZESHBuWm5hbHpOZVl2d0pMSmtubUowTXZZYmx2R01rUEFuMXo0?=
 =?utf-8?B?MW5uYWtaZDZUcGFIcFpXMk1pUHZZTzZLL0ZXM09KR2QzQUVQWERHa29rL05N?=
 =?utf-8?B?Zm9SZGRaUXNlanpVdGN1NE81Uk9xaWlFWFNUdmhRWUZPbTF0cTNrQ2dIM3BO?=
 =?utf-8?B?MVYrWHVPQjV0RnhhUGpsU2pyTzhoNStONDZIZ0gzTjF6eEx2TDIwRUVPLzZ5?=
 =?utf-8?B?aUNNV0ExMytNa2txZXBhMklxNjFGeUhoWXA0RmJ2TGZQdm5PSm4zTHB3MUZK?=
 =?utf-8?B?V0lyYkFyUHl5SFY4YkFjVm8zVDl4cXFTSjdXRHFteXlrWDVpeEc2KytWWVc4?=
 =?utf-8?B?OStrYmg2cWFLV0ZNTHlHVHNneTVSZ1Vvc3N1YkZPMXNZcU1jQm9sY3RhL1Zp?=
 =?utf-8?B?NW4rVTdWQTBxdUY1bGFkQ2RMZHVCSHZOVVVLb0ZGR2k5djVQajVSeWlldzl0?=
 =?utf-8?B?ZVkzc2UvUk9kanFXSWhMZUNHM2htemx0YUVFeVJNUWltbXZRTzI1MzBFWUd6?=
 =?utf-8?B?VjdxenN2ZnowaUE2dFRsSDFFN0xtSzZ2V0FYbmZ6aHBtdWpKR3FhdU9USmNz?=
 =?utf-8?B?cG4zcFNQbjdDWVVPY2Rvd0YxYmNzQThFUjhRNVhzNlAyYVljaVREVU5FZDd1?=
 =?utf-8?B?eXROa0VQMGxCTGJ0eDhTdGlEMDNDaGJ2U2NRVXBJN1gvWUVOTE9USmhoTWxz?=
 =?utf-8?B?SnlwZUdNSXZFaDV3T1Z5TCtqSmR2ODh1L09QbEMrOXZLSGZ0NkVsRHpYTHRB?=
 =?utf-8?B?alIwQjhPa29mZ1g2akJpNHFuRUVCZ28rcTRPTHNFY0NxYXhCU3Z2UnFRbnN6?=
 =?utf-8?B?WGdSZlNuOGhLY3I2TTdUUWVHSUUwaHl0TWZuZGN4VVZobEtjUVpBakxhTlRk?=
 =?utf-8?B?bnpGZTloQ2pDSzEwRFhhbFgvMnFWU3Qzb3NCWlBDY3dYb0xESzFNaHNCU1lt?=
 =?utf-8?B?bTN0dVFTWnR0eWZhd0RFSmtYTXcrZzFxWkZIVldDblZPaGY1WjVmS2wyQlVs?=
 =?utf-8?B?a0V0TGRqVGJCMzNBZi8rS1A5OXlqUXhDaVdhTG9ieFNSRlRkajAvWlIzWWt0?=
 =?utf-8?B?a0g1Z0tIdlc4MnBJQ2Y0RGpnaVNNZE56R1BsdWE1ZFh6THBaSGg3STR1VXlU?=
 =?utf-8?B?VmNocGFUbnhNb0tNVExhOUlNS0V2czIyMWY0djI3ZUZQNUhJajYxMnBhclBX?=
 =?utf-8?B?WDY5bHZ3empBRjR2QmdCMW8zaFRScHZMbldYbG9oOERiVll0ODhnM0RZZWxG?=
 =?utf-8?B?Y3NTb1VvS21DWmxjT2ZyL3FuVlhNb2tjdlFoZS9OTVMvanlUY1gzZWdrcm5D?=
 =?utf-8?B?aWpMY1ZuWVFXZ052VXZmS1BOMG0xZVpvOGxZU0lCWmk3dHBzR2k0TTFRYVBY?=
 =?utf-8?B?YkJBYlZ0WDdzSEg3dlNOVWRaV2NLNVJ3RGNqTEw5ODhaeXUvSnA4QkptalRz?=
 =?utf-8?B?VVFLVzkzbTVhaDBOYmZzMWVGSjdrWWR2YmZNUVlHMFlqakNJSjU1ZGUzU2pt?=
 =?utf-8?B?NE9Ua1V3OXUwUnh6VlNEL2cyMlJ0MWFUUFhZNThFTzRMQnlJMmc2NGV0Wjdz?=
 =?utf-8?B?RnRvcTByZDBHWFlnRHFNOTk2Zmgzd2RaVzExemdrcHBIZjdxT2d4N0VHKy9n?=
 =?utf-8?B?RnZ0VTVEeE1vamdVSGtyVldBdHRUc2tzNmNyQ2hkMURrSXczaWtJNnNCbVBi?=
 =?utf-8?B?ajNIbTlHWDBPS2tuU1FFVXZXQmkwY3JDUURFV1JaaVpBRVE5ODMvU0VINHlI?=
 =?utf-8?B?NmZGZ09QbTVBYUJmVWk4M3ZCcEFIN1gzdG5KV09XSlJUK0w2RlNWZ01iZHkx?=
 =?utf-8?B?WDRsc3lnQ2JjUDNDbGgzSHh5QlFXNXdSZG1aYk9PcVJiNWZDZmFuL0lLblhq?=
 =?utf-8?B?eTRmSWxFR2w3bFY0ZmpzdUxySTY0aDF3MU0xdjZlbkpBNmRYa2FsMUJkd1lD?=
 =?utf-8?B?Nm9FRlJ2RDhMclV6M1B4dWNLSXQwZDY3bkJkSDdvMFhjdmNWRUpuQXEzcE9r?=
 =?utf-8?Q?w8ZJavYU2UE4YbRZ5sJqI6k=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 914df0a5-26e1-46c3-067a-08d9f7b1f36e
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2022 16:23:11.7950
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6t2V8mLfuI9O1ErtZ3AsPqjtyoQt+aYkWgmsMRAI8WfnbU3+qw2waatO/qbyEPCu1Nra/geuW3vqdu5LCoipcQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB8058

On 24.02.2022 16:41, Juergen Gross wrote:
> On 24.02.22 16:37, Jan Beulich wrote:
>> On 24.02.2022 16:24, Juergen Gross wrote:
>>> --- a/xen/include/public/memory.h
>>> +++ b/xen/include/public/memory.h
>>> @@ -662,6 +662,13 @@ struct xen_mem_acquire_resource {
>>>        * two calls.
>>>        */
>>>       uint32_t nr_frames;
>>> +    /*
>>> +     * Padding field, must be zero on input.
>>> +     * In a previous version this was an output field with the lowest
>>> +     * bit named XENMEM_rsrc_acq_caller_owned. Future versions of this
>>> +     * interface will not reuse this bit with the field being zero on
>>> +     * input.
>>> +     */
>>>       uint32_t pad;
>>
>> Did you mean "... being non-zero ..." and "bit" and "field" changing
>> positions?
> 
> No, why? The current Linux kernel will set pad (the "field") to zero
> when doing the hypercall, and it expects the bit to be set or not on
> return. This means that the bit is reserved for the case that pad
> was zero on input.

Hmm, maybe I got confused (but only in part by the wording). The bit is
fine to use as input. This will mean the field is not zero on input, but
the way this is worded is somewhat confusing. How about making things
explicit: "... will not reuse this bit as an output with the field being
zero on input"? Then
Acked-by: Jan Beulich <jbeulich@suse.com>
and I'd be fine making the adjustment while committing.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Feb 24 16:28:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 16:28:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278483.475750 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNGyA-0005Ae-Kj; Thu, 24 Feb 2022 16:27:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278483.475750; Thu, 24 Feb 2022 16:27:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNGyA-0005AX-H4; Thu, 24 Feb 2022 16:27:54 +0000
Received: by outflank-mailman (input) for mailman id 278483;
 Thu, 24 Feb 2022 16:27:53 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=l9RI=TH=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nNGy9-0005AR-IH
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 16:27:53 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b6888a0c-958e-11ec-8539-5f4723681683;
 Thu, 24 Feb 2022 17:27:52 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id EAA38212C1;
 Thu, 24 Feb 2022 16:27:51 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A9A5B13B0C;
 Thu, 24 Feb 2022 16:27:51 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id xhUvKAeyF2LVeQAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 24 Feb 2022 16:27:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b6888a0c-958e-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1645720071; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=6cE4ifsoKgIRNuxJUiecSGLGD8B+jSy58OyjpSfgDLw=;
	b=vNWl7Zv3vy3KpIr/V2LYF7P7JJj7exjyC2MZwMlSGaWyYHxbbM0HTJKBMJKHZbswWgQdjq
	6eZ86gzLiSnfdTR5/3mXvKD2W3llphSX0jtZywp6bjzYzM7Ja72/YkJetGrPjXCMTlYTOw
	BjYnr36mcwiwA2r7wfxyLayuggPVrJE=
Message-ID: <c19031f5-c97a-1809-2633-ad546ea819dd@suse.com>
Date: Thu, 24 Feb 2022 17:27:51 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v3] xen/public: add comment to struct
 xen_mem_acquire_resource
Content-Language: en-US
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220224152414.27948-1-jgross@suse.com>
 <9972f96c-d0cc-d9a8-3566-74dbaf7e9e33@suse.com>
 <93d49d5f-29d5-72d1-c00c-ad14fb08b9c4@suse.com>
 <1b90636c-2890-2ed5-1315-51f80b2d2d78@suse.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <1b90636c-2890-2ed5-1315-51f80b2d2d78@suse.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------jAJMYC144YgwarDCeIpBlwg7"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------jAJMYC144YgwarDCeIpBlwg7
Content-Type: multipart/mixed; boundary="------------b0F9acf6m0vRVHQPcKKGh4Ti";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
Message-ID: <c19031f5-c97a-1809-2633-ad546ea819dd@suse.com>
Subject: Re: [PATCH v3] xen/public: add comment to struct
 xen_mem_acquire_resource
References: <20220224152414.27948-1-jgross@suse.com>
 <9972f96c-d0cc-d9a8-3566-74dbaf7e9e33@suse.com>
 <93d49d5f-29d5-72d1-c00c-ad14fb08b9c4@suse.com>
 <1b90636c-2890-2ed5-1315-51f80b2d2d78@suse.com>
In-Reply-To: <1b90636c-2890-2ed5-1315-51f80b2d2d78@suse.com>

--------------b0F9acf6m0vRVHQPcKKGh4Ti
Content-Type: multipart/mixed; boundary="------------G30oNsuh44MThYrNQ0iypBcy"

--------------G30oNsuh44MThYrNQ0iypBcy
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMjQuMDIuMjIgMTc6MjMsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAyNC4wMi4yMDIy
IDE2OjQxLCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gT24gMjQuMDIuMjIgMTY6MzcsIEph
biBCZXVsaWNoIHdyb3RlOg0KPj4+IE9uIDI0LjAyLjIwMjIgMTY6MjQsIEp1ZXJnZW4gR3Jv
c3Mgd3JvdGU6DQo+Pj4+IC0tLSBhL3hlbi9pbmNsdWRlL3B1YmxpYy9tZW1vcnkuaA0KPj4+
PiArKysgYi94ZW4vaW5jbHVkZS9wdWJsaWMvbWVtb3J5LmgNCj4+Pj4gQEAgLTY2Miw2ICs2
NjIsMTMgQEAgc3RydWN0IHhlbl9tZW1fYWNxdWlyZV9yZXNvdXJjZSB7DQo+Pj4+ICAgICAg
ICAgKiB0d28gY2FsbHMuDQo+Pj4+ICAgICAgICAgKi8NCj4+Pj4gICAgICAgIHVpbnQzMl90
IG5yX2ZyYW1lczsNCj4+Pj4gKyAgICAvKg0KPj4+PiArICAgICAqIFBhZGRpbmcgZmllbGQs
IG11c3QgYmUgemVybyBvbiBpbnB1dC4NCj4+Pj4gKyAgICAgKiBJbiBhIHByZXZpb3VzIHZl
cnNpb24gdGhpcyB3YXMgYW4gb3V0cHV0IGZpZWxkIHdpdGggdGhlIGxvd2VzdA0KPj4+PiAr
ICAgICAqIGJpdCBuYW1lZCBYRU5NRU1fcnNyY19hY3FfY2FsbGVyX293bmVkLiBGdXR1cmUg
dmVyc2lvbnMgb2YgdGhpcw0KPj4+PiArICAgICAqIGludGVyZmFjZSB3aWxsIG5vdCByZXVz
ZSB0aGlzIGJpdCB3aXRoIHRoZSBmaWVsZCBiZWluZyB6ZXJvIG9uDQo+Pj4+ICsgICAgICog
aW5wdXQuDQo+Pj4+ICsgICAgICovDQo+Pj4+ICAgICAgICB1aW50MzJfdCBwYWQ7DQo+Pj4N
Cj4+PiBEaWQgeW91IG1lYW4gIi4uLiBiZWluZyBub24temVybyAuLi4iIGFuZCAiYml0IiBh
bmQgImZpZWxkIiBjaGFuZ2luZw0KPj4+IHBvc2l0aW9ucz8NCj4+DQo+PiBObywgd2h5PyBU
aGUgY3VycmVudCBMaW51eCBrZXJuZWwgd2lsbCBzZXQgcGFkICh0aGUgImZpZWxkIikgdG8g
emVybw0KPj4gd2hlbiBkb2luZyB0aGUgaHlwZXJjYWxsLCBhbmQgaXQgZXhwZWN0cyB0aGUg
Yml0IHRvIGJlIHNldCBvciBub3Qgb24NCj4+IHJldHVybi4gVGhpcyBtZWFucyB0aGF0IHRo
ZSBiaXQgaXMgcmVzZXJ2ZWQgZm9yIHRoZSBjYXNlIHRoYXQgcGFkDQo+PiB3YXMgemVybyBv
biBpbnB1dC4NCj4gDQo+IEhtbSwgbWF5YmUgSSBnb3QgY29uZnVzZWQgKGJ1dCBvbmx5IGlu
IHBhcnQgYnkgdGhlIHdvcmRpbmcpLiBUaGUgYml0IGlzDQo+IGZpbmUgdG8gdXNlIGFzIGlu
cHV0LiBUaGlzIHdpbGwgbWVhbiB0aGUgZmllbGQgaXMgbm90IHplcm8gb24gaW5wdXQsIGJ1
dA0KPiB0aGUgd2F5IHRoaXMgaXMgd29yZGVkIGlzIHNvbWV3aGF0IGNvbmZ1c2luZy4gSG93
IGFib3V0IG1ha2luZyB0aGluZ3MNCj4gZXhwbGljaXQ6ICIuLi4gd2lsbCBub3QgcmV1c2Ug
dGhpcyBiaXQgYXMgYW4gb3V0cHV0IHdpdGggdGhlIGZpZWxkIGJlaW5nDQo+IHplcm8gb24g
aW5wdXQiPyBUaGVuDQoNCkZpbmUgd2l0aCBtZS4NCg0KPiBBY2tlZC1ieTogSmFuIEJldWxp
Y2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KPiBhbmQgSSdkIGJlIGZpbmUgbWFraW5nIHRoZSBh
ZGp1c3RtZW50IHdoaWxlIGNvbW1pdHRpbmcuDQoNClRoYW5rcywNCg0KDQpKdWVyZ2VuDQo=

--------------G30oNsuh44MThYrNQ0iypBcy
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------G30oNsuh44MThYrNQ0iypBcy--

--------------b0F9acf6m0vRVHQPcKKGh4Ti--

--------------jAJMYC144YgwarDCeIpBlwg7
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmIXsgcFAwAAAAAACgkQsN6d1ii/Ey/P
6Af+LOQXB0kKlNx1Mnv+i4Ovr2KEkGeq1cpyUK70geh9aJuxr/NCke/QGcP/14JMbE4Es2jCM5ZH
K7ZrhvSauLHaEVSO22CrodmekBBr5yOD5LSsh/nIGxiRhkddBxY0XlpiPCqk07NT4IFHGynfmovp
HYFSgtWTKxkLzFrhlQXMQ2ZueaO0E/TaH8GRwPTxPpnz0gY3oO2hzoUhkUO9pMugF/2j2isRODAo
qI9tlYaJF/QwIajEvRmNBbt16iKIoMe/ClJKE5YwzC+KLXDcJKCCmaCEqYIixp9a2iUZDIkGTifq
rUoSAJy8xXHI3gXTCvbzj88Ti/GCurYGFrJfZq0joQ==
=CAGe
-----END PGP SIGNATURE-----

--------------jAJMYC144YgwarDCeIpBlwg7--


From xen-devel-bounces@lists.xenproject.org Thu Feb 24 16:37:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 16:37:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278490.475761 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNH7M-0006hA-IL; Thu, 24 Feb 2022 16:37:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278490.475761; Thu, 24 Feb 2022 16:37:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNH7M-0006h3-ED; Thu, 24 Feb 2022 16:37:24 +0000
Received: by outflank-mailman (input) for mailman id 278490;
 Thu, 24 Feb 2022 16:37:22 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=gX/V=TH=citrix.com=prvs=047ddeb39=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nNH7K-0006gx-MJ
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 16:37:22 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 08315fc4-9590-11ec-8eb8-a37418f5ba1a;
 Thu, 24 Feb 2022 17:37:20 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 08315fc4-9590-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645720640;
  h=from:to:cc:subject:date:message-id:
   content-transfer-encoding:mime-version;
  bh=t+8rG6Fm+mpvRCzCQQn9JDgF4eVQf/agejDrWs9oP8Y=;
  b=AqKoe3QxBV3xsVbNaTxwCa8Pto3FWR3TzxB17CO5zLHxvH8FvgZDe1yk
   +3zIjYXTQOecSwSbtCR7Vbi15ydjCRis5U07eK/du1KZEAs5hjjMXtptY
   HOUeTr8ZbgJRHxSTnlZuQ35nZZAWIwfrNjb8s24704JSAgGHFF8frAvG7
   0=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 67183607
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:jdxGlqKOs49YKtNoFE+RJpUlxSXFcZb7ZxGr2PjKsXjdYENSgjdWy
 2IdWjvTbq7cM2OkL49yPovjpB9SvMfcxoUwGlBlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA148IMsdoUg7wbRh2NQ02YPR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 NQRvMCXZgMLApePt+oYehB7MA1kJLITrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBNPsM44F/Glp0BnSDOo8QICFSKLPjTNd9Glv35AVQ66BD
 yYfQWVvTB+eQAdDBk4GKJIGkuyFr3fEdCIN/Tp5ooJoujOOnWSdyoPFL979atGMA8JPkS6wv
 Xna9m70BhUbMt23yjef9H+owOjVkkvTUYQeDufgrqZCj1iax2hVAxoTPXO4rOe4jAiiWttZA
 00S5icq66M18SSDTNPwQhm5q36spQMHVpxbFOhSwBGAzO/Y7hiUAkAATyVdc5o2uckuXzso2
 1SV2dTzClRHsqCRSH+b3qeZq3W1Iyd9BXcLeCssXQYDpd75r+kOYgnnF4g5VvTv15usRG+2k
 2viQDUCa6s7jJICi4KU+XL7uXGDqJ3gRy0Wyh/OQTfwhu9mX7KNa4ut4FndyP9PKoeFU1WM1
 EQ5d9iiAPMmVs/UynHUKAkZNPTwvqvebmWA6bJ6N8R5r1yQF2ifkZe8Cd2UDGNgKY46dDDge
 yc/UisBtcYIbBNGgUKaCr9d6vjGL4C9TbwJtdiON7Kih6SdkifdokmCgmbKggjQfLAEy/1XB
 HtiWZ/E4YwmIapm1iGqYOwWzKUmwCszrUuKG8ymkUj9jeDFOybOIVvgDLdoRrpnhE9jiF+Im
 +uzyuPQk0kPOAEASnO/HXEvwaAiciFgWMGeRz1/fe+fOAt2cFzN+NeKqY7Nj7dNxvwP/s+Rp
 ynVchYBlDLX2C2WQS3XOysLQO6+Av5CQYcTYHVE0aCAgCN4P+5CLc43KvMKQFXQ3LY9laUtF
 6FdIa1twJ1nE1z6xtjUVrGkxKRKfxW3nwOeeS2jZTk0ZZl7QALVvNTje2PSGOMmV0JbaeNWT
 2Wc6z7m
IronPort-HdrOrdr: A9a23:g9xeUaov9XioBRaDGViMpT4aV5oveYIsimQD101hICG9Ffbo8P
 xG/c5rsSMc7Qx7ZJhOo7y90cW7Lk80lqQU3WByB9mftWDd0QPDQb2KhrGC/xTQXwH46+5Bxe
 NBXsFFebjN5IFB/KXHCd+DYrQd/OU=
X-IronPort-AV: E=Sophos;i="5.90,134,1643691600"; 
   d="scan'208";a="67183607"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=KXkrGviOt2pG4WfAHMClrh6Ik3H0DNSnOn99ENfvzmZ5F8vCJLW5AcdE9DcyyqqfHUlTAYQr7JXp7HEpldBW12AoNtS9VMDZhG0wofnBaeIw59lW9AqlyX+wGlOKHxQwFZoMXxrtpplarrRoptm9x0FMVR8VQ/PzE/Zguu9gDiGjqfGOORkjnUjfq3fBBk0/cEZD5MvCFQ5oZq0iuishErfGFa3u6ZD7boP4PRaq6y9ReUOq7GbWhkLsN3ZVe5sNVRAnISAo3QTYAKY05Ib2uXwK0M/ftUNXb15PgreyzYOgYL4D5O2lFCtjRtPHggS61WHz2DLzXJWq+L74Xh7N7A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Yeyjqo6BAR6+mndrcxmXz+lkFiDgi+mh4YsAir/cbrI=;
 b=AzV9FTrRBv2o4E0UwqOI0GJVSqUH39Y3I5N9G/dVWjS+Vsjoe0zQL9aIefwf9JB/Ie23ijs5Z57Ts+A/5VbNMnVg6tuZXMXRK1kaJBPchQbBnWO3WtauiaIgatoxyvGz80cL6JATvKAlzQY++dDTw1Lvxjd5H8FEFg6Bbwosthf7BlhlgXw7yTYuxAh/GJaxJF/5YFUdKCnWJL4UEyCQWBUuamCh4OMimsHlRFX3wxHKSbWpiBxiPrmnF9n2VsuiQjVYCCME+4QIDCT9p3tRvwq0dGSEIw4jr5Mf01knYEBccPvOtym5WS0R3fizRKcO1TD7DEECsuNzddvnDfelGw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Yeyjqo6BAR6+mndrcxmXz+lkFiDgi+mh4YsAir/cbrI=;
 b=nQ0amT+JAV3uUBprJ/qt5ewDva9xJ2mpqZpgZKJH84j/ZmV3EnBHHlyXlt5wxxmm7dUaAi8q5w04NiYzo1vaig4nkw9Sa38H5JtHDtdzOqJdU9zIP9gzbCO8m5NAHvTGswTYdz5RAeenTbCp8H6ouq1Q3PjarhLtp/WrIZovr4Y=
From: Roger Pau Monne <roger.pau@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Roger Pau Monne <roger.pau@citrix.com>, Jan Beulich <jbeulich@suse.com>,
	Paul Durrant <paul@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>, Kevin Tian
	<kevin.tian@intel.com>, Oleksandr Andrushchenko <andr2000@gmail.com>
Subject: [PATCH v2] pci/ats: do not allow broken devices to be assigned to guests
Date: Thu, 24 Feb 2022 17:37:01 +0100
Message-ID: <20220224163701.89404-1-roger.pau@citrix.com>
X-Mailer: git-send-email 2.34.1
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO2P265CA0087.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:8::27) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 8f69a873-98b6-486a-01ab-08d9f7b3e9ec
X-MS-TrafficTypeDiagnostic: CH2PR03MB5350:EE_
X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
X-Microsoft-Antispam-PRVS: <CH2PR03MB535066A581017B65F2EAF4D58F3D9@CH2PR03MB5350.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: kLDltzc0XdWzDjWuE7gbGIdWTWOWeK15NCtLPiLMQbHbSHv/2vw8QL1O0Mk1BRgDb59UHCgQpbJcLPWJp4s9PmQB6p+N96Si7+gWwfmrSckmpWU7zIoy+Yzs+gpBdEYhjCrURkgGmNW0LWaPIYAoTTrpWRaicIk5Pgxtf2RsQxjh7UK+1y5zmldfCMx18+9kLwVk7iurArTOaXTa/583xVGAjU9rbL7jK3YD9yrUyebTyEcv8idIuE1fNE9rerVRehLz7bJy1c8CsVceMD7wpQk6ievZkPekl0W2GpA3VpT8rqyCQASfSyuWHVXRDkDqgChp60IxCMyzYxSuP7LmZNM1eqA12CIQ1vAoxF28mJM/EW4POIh5uLO2Yh+nzeUiMWcBIpgPGozHQV4BSUuPLYX+6q9039mnKxlDaYr0wRoOVLNiBFICZi27JmK+y1Ma9d8Ol4EssMfLiUry33QCBoKQg0mW5ThMSEGJcPGeGk6qPKFuGn0quT6Rhp4Cq/3N4OdgZ32Z/JoSt/uT/dAgApqaLb78a8akX7ok2gOnb4R2x81sienH9FdgeQOn4DBak3kQk9c2ICoJ+UWNKTMXEykA0pMm8wXQ7DTj6Uewgz76ETZgMUphOrm1AkLaqErpQQHneGMytVUXjckjuOwbjA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(2616005)(54906003)(66476007)(1076003)(316002)(4326008)(8936002)(2906002)(6916009)(66556008)(66946007)(186003)(26005)(86362001)(6486002)(8676002)(5660300002)(82960400001)(83380400001)(6666004)(6512007)(508600001)(36756003)(38100700002)(6506007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZWZkM3NsaWlPMjhzTmY5SXg3Nnl4d1E0YTJLanJEZEdKTU94cHIxQmxUU2tD?=
 =?utf-8?B?Wko0UmcveUtLTmIyYWxoUFVoZmxFYWlWRDA4REM3VDdURkxOOUZEdXF1T1ly?=
 =?utf-8?B?Yi9KRjB1Q3FoZi9oby9aNGNqTkRUbWMrTmNaUHpHNDFHbWxrUXVBL2ZwYXVl?=
 =?utf-8?B?VGh0TEl2Z3R3ZUZ1bE1rRzMxeTBERi9ocWJyMkE3eFdQL244VkxoK2krY256?=
 =?utf-8?B?QUJhSmx3MVdYKzdoSzU5aUY3TGprK0VwZTJMUTRPR0o0d052Z2ttVk5HcTJE?=
 =?utf-8?B?YTdGMjNFcFM2Q2pDUEF5N1N1SHExd2VzQUdUQVJnVmNkWGtlY01iRFI5VWR3?=
 =?utf-8?B?UW9XeGQ3RlI5L1ZENHZ4RjRvM1I1RmZhUDRhV0FDWVZvWG1sckoyb0pkNWVy?=
 =?utf-8?B?MHJuTnBEMHoxZGswYVNMU21pT29BczJFSnhoMG1OT1N0UU8vdXp5NUdEM3Zs?=
 =?utf-8?B?TFR6QWRVQnNVOTJwdW5OcFpqR2pvcGtPa2E2cHNsRE5GUFdzemd3RjlmMXVk?=
 =?utf-8?B?WmljMUVHc1ZyL2hqaXBWNE9zZlh2d211dWRQaFZUOU9Ubk5FQ2tjQzRTQm9r?=
 =?utf-8?B?V2piQ0kvdFNNYlRpV3pEZmExT0dSV2hza2VxWnFyeGRpRVA4bUlCVG9NYnQ5?=
 =?utf-8?B?UC9IamNjRUZONUFGbEVxOUpubjZkOUdCTWZ5T0RHYXlpS1hGK3lIdDhOUXVQ?=
 =?utf-8?B?MXNzQk1GQkw3YVpES2ZjYlRlYXNhMC82RHJEU01Zd1ZVeWZBSjJUQm10R08r?=
 =?utf-8?B?Rm85SGloOGt3RG8xdDY5eE5OMlE2bGVBeCs3YlhTWHVRRWp0RkFCeG94UlRG?=
 =?utf-8?B?ME9ubkx0c0hCSDIzVjVreEdnOWtVQkNXQlExRkUrMEd3cVlkaW9GSjlpNEVK?=
 =?utf-8?B?YTRnd0xsU21jaGdwWDdCWWNFQm1sRTdRM2ZILzQxMGlVaHh4VzNhazFpejEv?=
 =?utf-8?B?Vm5LYVl6dktQTmRwMEcvMUI0cDlBTVBKQUM0c041SGV4d2VGMFI1MlluOEhr?=
 =?utf-8?B?ZHBTZHhGekhuanJNSHBJeE5KWVNaTW02TDJGYkVxRXg3VGJaRlc2K3pDWlly?=
 =?utf-8?B?djFPWGUvOG5tR29xMk53TUNHYlR1RGR1NnljcjVWeTdmazhrU1F1Uk9wZDVk?=
 =?utf-8?B?SlA0a1BNQUdVM3Z1SklRcjBVN0Z1VWYxck9NUE93MFVQSUNLMDJxdUR5K2dI?=
 =?utf-8?B?V0pCQXhGWXFBZjcxckRqcUlpeStsMEwzQUh4c2wya3NVdWs1OVlmZ0RDejAz?=
 =?utf-8?B?bkJLYkhQZ0hQTll2N0Q0WG1BM1JicUM0eEthLyttRWxHNmRxVzJhWGlKOEd2?=
 =?utf-8?B?REhIZFZobHF2NklkRzVvU1RvdU5YQ1NOcmdaV0poaCtEMVVOUzhyMW5aa1ZG?=
 =?utf-8?B?Y1lRRTloM2E2K3JXTjhrVHdnVWhHU0ovNnR0bUFKZi8rWlAwYUtWcnZ4MG4r?=
 =?utf-8?B?Mmc3d1ZyL0lUUVdkQ3FiRDM0Y2xjTmxNdVZhN3ZOaTJlT0o0MkdZWjVPZ0hx?=
 =?utf-8?B?djZOM0lpVU5UMHFNdVdNWit2Qmc3Z1kzVU1IRCtEZFhLam5zc3k5WWk0V1lP?=
 =?utf-8?B?a2pjaUtWQi9UdXNId2Zkd2thV0NMS2o1TERYUVE5bElOcUhJY1dmNWg0cmF5?=
 =?utf-8?B?OXFTaCtMeVlmLzIwV2Jaazc3UWZUMkJ4LzRBUkJkZmVyVnR3OER4ZDVaWXAw?=
 =?utf-8?B?b2NXQURSSnhUS1pvZm5kSFV1Q3JRVm0yRXB6aGtzYndGQVFIWG5PSVNTZDcy?=
 =?utf-8?B?TVBqWVNhNkliRmEvNDhmZng2RENML0QxeVFLMFhrSXlVSnprUWZjZFNKZXp4?=
 =?utf-8?B?R3YxSURselBNQVNINHJOZnZyRzJsbHhRYlhDNHJaTnU0VWFqTzJVZFRzYlhJ?=
 =?utf-8?B?dlZUTkdITno1WWZmS0VRdW1WeE1EVHROeGhFOXVSSDVkMFZvdjVKb2c2N2NJ?=
 =?utf-8?B?YTBCNTh4KzBKbEtmNFFVM3NFQWUzaG1jTWNhdmxGeFZiQUZDUkNXUXhMcWE2?=
 =?utf-8?B?ZHRpVnRsTWhYSmV5azVCS0VzaU5HL1JTYVVBYzJkdTJCZ0pxbzJ3Y3JkUzIx?=
 =?utf-8?B?SnhvRCtPWDVsWkV2UzZqNzZnOU05T2ZtK01VbTdmNjlEZU4veEJXMHlxRUk1?=
 =?utf-8?B?WnlrdDRlWVlZU1JPRUt5ZU44cVJPUHlyQUNsZk5RbjJ6Uit3UFY3MVJRRWxH?=
 =?utf-8?Q?DcdKTNx2lCUVWvlHz+c4TCs=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8f69a873-98b6-486a-01ab-08d9f7b3e9ec
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2022 16:37:14.7587
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wrBEr1TFGMw0+A26x7+EiQr/hlFi+SPcxByCEgnwO+DrAwfqsyFqX3eoEmZC5t+1LWDlnwpjvbq25Byk80+6NQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR03MB5350
X-OriginatorOrg: citrix.com

Introduce a new field to mark devices as broken: having it set
prevents the device from being assigned to guests. Use the field in
order to mark ATS devices that have failed a flush as broken, thus
preventing them to be assigned to any guest.

This allows the device IOMMU context entry to be cleaned up properly,
as calling _pci_hide_device will just change the ownership of the
device, but the IOMMU context entry of the device would be left as-is.
It would also leak a Domain ID, as removing the device from it's
previous owner will allow releasing the DID used by the device without
having cleaned up the context entry.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Cc: Oleksandr Andrushchenko <andr2000@gmail.com>
---
Changes since v1:
 - Allow assigning broken devices to dom_io or the hardware domain.
---
 xen/drivers/passthrough/pci.c        | 11 +++++++----
 xen/drivers/passthrough/vtd/qinval.c |  8 +++++++-
 xen/include/xen/pci.h                |  3 +++
 3 files changed, 17 insertions(+), 5 deletions(-)

diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
index 70b6684981..91b43a3f04 100644
--- a/xen/drivers/passthrough/pci.c
+++ b/xen/drivers/passthrough/pci.c
@@ -501,7 +501,7 @@ static void free_pdev(struct pci_seg *pseg, struct pci_dev *pdev)
     xfree(pdev);
 }
 
-static void _pci_hide_device(struct pci_dev *pdev)
+static void __init _pci_hide_device(struct pci_dev *pdev)
 {
     if ( pdev->domain )
         return;
@@ -1487,6 +1487,11 @@ static int assign_device(struct domain *d, u16 seg, u8 bus, u8 devfn, u32 flag)
     ASSERT(pdev && (pdev->domain == hardware_domain ||
                     pdev->domain == dom_io));
 
+    /* Do not allow broken devices to be assigned to guests. */
+    rc = -EBADF;
+    if ( pdev->broken && d != hardware_domain && d != dom_io )
+        goto done;
+
     rc = pdev_msix_assign(d, pdev);
     if ( rc )
         goto done;
@@ -1585,9 +1590,7 @@ void iommu_dev_iotlb_flush_timeout(struct domain *d, struct pci_dev *pdev)
         return;
     }
 
-    list_del(&pdev->domain_list);
-    pdev->domain = NULL;
-    _pci_hide_device(pdev);
+    pdev->broken = true;
 
     if ( !d->is_shutting_down && printk_ratelimit() )
         printk(XENLOG_ERR "dom%d: ATS device %pp flush failed\n",
diff --git a/xen/drivers/passthrough/vtd/qinval.c b/xen/drivers/passthrough/vtd/qinval.c
index 9f291f47e5..510961a203 100644
--- a/xen/drivers/passthrough/vtd/qinval.c
+++ b/xen/drivers/passthrough/vtd/qinval.c
@@ -227,7 +227,7 @@ static int __must_check dev_invalidate_sync(struct vtd_iommu *iommu,
 
     ASSERT(iommu->qinval_maddr);
     rc = queue_invalidate_wait(iommu, 0, 1, 1, 1);
-    if ( rc == -ETIMEDOUT )
+    if ( rc == -ETIMEDOUT && !pdev->broken )
     {
         struct domain *d = rcu_lock_domain_by_id(did_to_domain_id(iommu, did));
 
@@ -241,6 +241,12 @@ static int __must_check dev_invalidate_sync(struct vtd_iommu *iommu,
         iommu_dev_iotlb_flush_timeout(d, pdev);
         rcu_unlock_domain(d);
     }
+    else if ( rc == -ETIMEDOUT )
+        /*
+         * The device is already marked as broken, ignore the error in order to
+         * allow {de,}assign to succeed.
+         */
+        rc = 0;
 
     return rc;
 }
diff --git a/xen/include/xen/pci.h b/xen/include/xen/pci.h
index b6d7e454f8..02b31f7259 100644
--- a/xen/include/xen/pci.h
+++ b/xen/include/xen/pci.h
@@ -108,6 +108,9 @@ struct pci_dev {
     /* Device with errata, ignore the BARs. */
     bool ignore_bars;
 
+    /* Device misbehaving, prevent assigning it to guests. */
+    bool broken;
+
     enum pdev_type {
         DEV_TYPE_PCI_UNKNOWN,
         DEV_TYPE_PCIe_ENDPOINT,
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Thu Feb 24 16:40:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 16:40:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278497.475772 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNH9h-0007Hc-VF; Thu, 24 Feb 2022 16:39:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278497.475772; Thu, 24 Feb 2022 16:39:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNH9h-0007HV-Rv; Thu, 24 Feb 2022 16:39:49 +0000
Received: by outflank-mailman (input) for mailman id 278497;
 Thu, 24 Feb 2022 16:39:48 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=uiXl=TH=lst.de=hch@srs-se1.protection.inumbo.net>)
 id 1nNH9g-0007H6-64
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 16:39:48 +0000
Received: from verein.lst.de (verein.lst.de [213.95.11.211])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 605fefbb-9590-11ec-8eb8-a37418f5ba1a;
 Thu, 24 Feb 2022 17:39:46 +0100 (CET)
Received: by verein.lst.de (Postfix, from userid 2407)
 id 8DAAC68AFE; Thu, 24 Feb 2022 17:39:43 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 605fefbb-9590-11ec-8eb8-a37418f5ba1a
Date: Thu, 24 Feb 2022 17:39:43 +0100
From: Christoph Hellwig <hch@lst.de>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>, iommu@lists.linux-foundation.org,
	x86@kernel.org, Stefano Stabellini <sstabellini@kernel.org>,
	Juergen Gross <jgross@suse.com>, Joerg Roedel <joro@8bytes.org>,
	David Woodhouse <dwmw2@infradead.org>,
	Lu Baolu <baolu.lu@linux.intel.com>,
	Robin Murphy <robin.murphy@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	xen-devel@lists.xenproject.org, linux-ia64@vger.kernel.org,
	linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org,
	linux-hyperv@vger.kernel.org, tboot-devel@lists.sourceforge.net,
	linux-pci@vger.kernel.org
Subject: Re: cleanup swiotlb initialization
Message-ID: <20220224163943.GA32088@lst.de>
References: <20220222153514.593231-1-hch@lst.de> <09cb4ad3-88e7-3744-b4b8-a6d745ecea9e@oracle.com> <20220224155854.GA30938@lst.de> <206ba6a3-770a-70ad-96bc-76c6380da988@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <206ba6a3-770a-70ad-96bc-76c6380da988@oracle.com>
User-Agent: Mutt/1.5.17 (2007-11-01)

On Thu, Feb 24, 2022 at 11:18:33AM -0500, Boris Ostrovsky wrote:
>
> On 2/24/22 10:58 AM, Christoph Hellwig wrote:
>> Thanks.
>>
>> This looks really strange as early_amd_iommu_init should not interact much
>> with the changes.  I'll see if I can find a AMD system to test on.
>
>
> Just to be clear: this crashes only as dom0. Boots fine as baremetal.

Ah.  I can gues what this might be.  On Xen the hypervisor controls the
IOMMU and we should never end up initializing it in Linux, right?


From xen-devel-bounces@lists.xenproject.org Thu Feb 24 16:43:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 16:43:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278504.475782 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNHD8-0000E9-EH; Thu, 24 Feb 2022 16:43:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278504.475782; Thu, 24 Feb 2022 16:43:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNHD8-0000E2-B8; Thu, 24 Feb 2022 16:43:22 +0000
Received: by outflank-mailman (input) for mailman id 278504;
 Thu, 24 Feb 2022 16:43:20 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=VLhp=TH=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nNHD6-0000Dw-Hb
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 16:43:20 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id deeb0633-9590-11ec-8539-5f4723681683;
 Thu, 24 Feb 2022 17:43:19 +0100 (CET)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2054.outbound.protection.outlook.com [104.47.6.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-33-uY8oQFtHO1WaARFOUQ3kiQ-1; Thu, 24 Feb 2022 17:43:17 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM6PR04MB4424.eurprd04.prod.outlook.com (2603:10a6:20b:1e::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.27; Thu, 24 Feb
 2022 16:43:16 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.024; Thu, 24 Feb 2022
 16:43:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: deeb0633-9590-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645720998;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=W6Ps70Sf/Udog8fbpdUoBek2hV338nFs/0uA0xlJ0ng=;
	b=G1vcsDxvgjXbOqJ8Y9PzSUKZqGdFg29/T5C6jpJS3LCKX8FVFrhQMEi/j2DWc/8hZCiT53
	+NIa+bNyIie5XcJv+SUzEDXs5mEMjw3tmrouX1r8AdKMRZiQ0+bdWMk6hYnlcuFf7w+hcF
	9MzHTw94107uYqhn1SU/4PAVYaTIqlI=
X-MC-Unique: uY8oQFtHO1WaARFOUQ3kiQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ltEoL19yuMwQskrskQXDgnZQUP/Hqg4d5PsbLnbchJnqY8Yku5WUqVHHuiMI1RCeTdGEaumVyvgE3MProUHgMJkhJl2dDVYEinZmJxzaBffglceQnMtdnp2PgubROvUoxMnhHWuPgPLM/u2JUxKM969keSG9S4JA2w3Lrv0Fk+q1W5hm3hqmFIWg7LeVRVQYejfNuNB8oQIGsQDaSGB+ljdnZrKBGhI9ozteJVFCXaCfWyb6fjQRcJ3Qpf/b1bO+gN6BN4XSTFawdl542dBBWemBojVajklsdWK2D67OsUQX4RREK9quD44MJ2vlbySU1FxrHNrkrQ4lgJ86bH6KyA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Lctuyp3sqxjRhuRF/ZUXDYC9j5FpRHWS77F2/NW8LoA=;
 b=mZwjjh/b4wtRUatJFbGBkgyW3lcDqh5J7rEQts1mMECzToAyeJF5L+M8P1rWq8eRJule0wkgD1cCFd0Biu4PvjoRytRcYNlYzLmF+cLiaGUOSSPN5We5w47ueXI1yV597bHcXSAXAmbYtRd1710yWcP0+KJuhiOG4YOj3mYC1Z0A1Ia1v+8gVVc5t8lnl9dw7s7S1oxB4mHaDbt3ENzJEj/xBrUaeNCH3crM7X/FZHMTYRbFHKyEigYGv4G0f/huex/UAGdCya/igk/451Zjex1jBhfCq2fGl87aKZRbQ/BKEPQ3IblO94tlQDQBRI3E/DZfSS+TsBjDZ+amOVmV9Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <87b47562-7689-de37-f2ee-df05ef01c923@suse.com>
Date: Thu, 24 Feb 2022 17:43:13 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v2] pci/ats: do not allow broken devices to be assigned to
 guests
Content-Language: en-US
To: Roger Pau Monne <roger.pau@citrix.com>
CC: Paul Durrant <paul@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Kevin Tian <kevin.tian@intel.com>,
 Oleksandr Andrushchenko <andr2000@gmail.com>, xen-devel@lists.xenproject.org
References: <20220224163701.89404-1-roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220224163701.89404-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM5PR0201CA0017.eurprd02.prod.outlook.com
 (2603:10a6:203:3d::27) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 88a738cb-5f6a-4ca4-2f0a-08d9f7b4c13d
X-MS-TrafficTypeDiagnostic: AM6PR04MB4424:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB4424A363FD620843BE123B4CB33D9@AM6PR04MB4424.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	THjcmSAkt5yiglymTRVN8w/0lSgRPyXdUO9EQvFRls/Uh7QGQrp3QOBjQAXYiTrCXzidiMBx8oOU/CarZImV/5ymUDQD3kLXbNyBkNMSoPX4gTDnWG/SXg0YhGVYbPauVMKqZZWC/zbku/kOVR7hvLja2pjy6c4UnKA3bmH7fBHMsXi8QCcIJpu0YfwUsOM6zy4Relqh3H+oeZ/YsK47mFM58osgWE68umfRt6Vp5jANFLODfYsakLpZ909frfJm/mzNqP4MPNVRH/SX/m3flWu2F8U2eN+l8cZDXIfKUYll43/QEDVxg7yP9GYg4mj+9UYrawygxkVkJmwVo1uw+0r5/Hf2PP80vEEI1MUXLqhe4EaqcGXGYDw83Ve8aO1Ir75vLK8GWP5b6W2WOQ+2zott1cURr3Pj1cdOmwOUIk16DrIad/EIp91vfUC/hjLvpNxisN064D1OUcAwBjj8CiRt0h8TwV0sW0s0nluwfKDvxGe623wyxbPdfFo9u57km3F7ZGky2hSw2toJyxSz9zJw/k7CoLEEJ9aIV9S7mUYQCbV/KTUWIDk/lKHnuMss/OOMqwDCqOKASgsaWok1kVBGjQvGCfmJmm9nRZy4fdYPiEZH0dfNP4sZ8H4YmsjFAaAigAGAqDMTq3AkvjPaYjs/0bdjLN7tQ2ow88ircOJR3SBSqda9m9q8P/qbb5S0D1HOh4szzSZaC1nRxDxc9p3FPep7nSZhwyomKzNFTQg=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(508600001)(316002)(5660300002)(83380400001)(31686004)(26005)(2616005)(66946007)(4326008)(186003)(66556008)(66476007)(8676002)(8936002)(4744005)(54906003)(7416002)(6486002)(6916009)(31696002)(2906002)(36756003)(6506007)(6512007)(38100700002)(86362001)(6666004)(53546011)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?TBgHDVhPqgiY1PvruB76kc/vL/ooLWdsEvL9JfcPCqeIKEVHOQKGrXNgTPdV?=
 =?us-ascii?Q?rLMRmjh0kMWasNeTXyPElejIq7CYTbCpSMGZuT61N7Ym9ceVm6rteF2uqWRJ?=
 =?us-ascii?Q?CTj3d0NhJ9pSCWaneIe517+Q8TFxmB0OIowOe9LffZVCOj0ycm8V9uhgk280?=
 =?us-ascii?Q?uPNgl1ndlLUzbJGJmL3tXHne+xcn1c7lb0dCChODq2U3rUzM0zYKwqqKHhb2?=
 =?us-ascii?Q?C1siU9zJD+uGlSYpT1RFHM3RzY5b3CcxN8XN6bdhtzm1A7HDgPoOoXqCOZGE?=
 =?us-ascii?Q?mteTMLIDYvKUDM8X7raDnszWHuiDK5WDIptnjDKxqRobnN991+G0dQM3M2Dj?=
 =?us-ascii?Q?26ju9Cm6g4hE4UWPQ3v5FP5h1dY9Xex8z81Nv+Y+5hdQQKSq7hEoTwebJ/fY?=
 =?us-ascii?Q?vIh6QS7TOzSGF+m8erNhlbkFGHUQXSkyX2D5P5VR0/EoemSXxtU6vsPrtr05?=
 =?us-ascii?Q?PZbKpQC7M1OJjkm/7A5wqaVKz41cstNU3UAzStvyE2EMpSIl14uT+tHyQZRo?=
 =?us-ascii?Q?zcSrH3TgJxcM1UUH2TI5+5Ghrn3+dkwyWJzRLcbQnA7rC1nmaMGKYnMaoqWv?=
 =?us-ascii?Q?M7DH1PnHZKPgzfHeoKvdTuDodp5DU25ltIsP8wFU95fhAR1i7KE0JYM44nJ1?=
 =?us-ascii?Q?HWYugCDDWou/63EqyomjSJ/6F/O9JU48P+kU1C5vYzkG+SdNBnSCIVjXP2Pb?=
 =?us-ascii?Q?WvMd7YXbevGOf352qX3O1VOYybb5huvcEjjIw6MSd6VxPDUdYkyjLcurI7Vi?=
 =?us-ascii?Q?MwWIQQu4w9AY+OF+LfTHPfqn7tVymV7pB8O7acMT9MgdbVRI/AFX/SJF1pZg?=
 =?us-ascii?Q?0hIwlsn9nvOuYqf/p+XNM30JJTZDNAoADS3bnKWt6YVPrXgaOM6LEQek/s6I?=
 =?us-ascii?Q?djVBNd39ki6x23u9kqLWnkwKAN0RJwYOBgk33BOp1+R4LAx43nRMs+JX8NHs?=
 =?us-ascii?Q?MfE7b55yfHc9Xp2vFTpM67nK5oYa/L+sZzQuk0kP7XGH4RNvTC+xem0FZnEw?=
 =?us-ascii?Q?N0pD/8azvnstKktljx6DGru9WrDXOxH3RFjSEuMxoJbOpO2lh0iqa+x7UXAu?=
 =?us-ascii?Q?/TUUp3XRmkwbiyTqFs0n36BnzMuT3d1yhuhY4Nemz70JXjcNWJVGXDBgAg9t?=
 =?us-ascii?Q?sMimFNz4d+LBSs4vULism2FMvgqkhT1JIjXZ572gmyEteycRSf4vOhg+cfcL?=
 =?us-ascii?Q?7Ev5ZuHdRH1TGfY5APl/sK+5s1AviC643+PHqjF56DMeIR/FPOZXYUAGZmLm?=
 =?us-ascii?Q?Zf6Fu3FLRv4M3qUkGT4hTKhSrbAIVqShKZjJxKTSiAo1wKGp7pA3KdQqNNbe?=
 =?us-ascii?Q?cbzXlp9uDDiXZrEab/USQ8vVc5k30UdeJcpupgukiZON1EfNG5JfegZcANY3?=
 =?us-ascii?Q?qclmUrRmspft/7UVZqsa7P6B4TmAdflW/v2zHq3ZYn0raeG4Sv/KX4/YVbA1?=
 =?us-ascii?Q?uhF/OWAaxESyQkd+BH+Dm6PlaViz7BfLOg27qJp8Bt6am244r7q6PvYQvb1L?=
 =?us-ascii?Q?vFFsc6DYmlhNBkvIaa4ZfzFmU++VdjTcQTDNpoVREnNETsE45VWzYfMmSJnL?=
 =?us-ascii?Q?SgdqjUKEGFBDdhpmIx8aZmU8JlYUDiQj7fyjy+xL9M0KsfLTeIIuwgiwb8A8?=
 =?us-ascii?Q?1vKz+2pJbha4+0VYodXEUL4=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 88a738cb-5f6a-4ca4-2f0a-08d9f7b4c13d
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2022 16:43:15.9384
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /5GGkw4v8RaS3mt2yEBlKe5v4AcXbSWigtqX7jkbEN3sHATBI5MZktEeMxViW3dgrGDhGriuXeKZxIth1SqonQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4424

On 24.02.2022 17:37, Roger Pau Monne wrote:
> Introduce a new field to mark devices as broken: having it set
> prevents the device from being assigned to guests. Use the field in
> order to mark ATS devices that have failed a flush as broken, thus
> preventing them to be assigned to any guest.
>=20
> This allows the device IOMMU context entry to be cleaned up properly,
> as calling _pci_hide_device will just change the ownership of the
> device, but the IOMMU context entry of the device would be left as-is.
> It would also leak a Domain ID, as removing the device from it's
> previous owner will allow releasing the DID used by the device without
> having cleaned up the context entry.

This DID aspect is VT-d specific, isn't it? I'd be inclined to ask to
make this explicit (which could be done while committing if no other
need for a v3 arises).

> Signed-off-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>

Jan



From xen-devel-bounces@lists.xenproject.org Thu Feb 24 16:50:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 16:50:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278513.475793 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNHJR-0000zq-6k; Thu, 24 Feb 2022 16:49:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278513.475793; Thu, 24 Feb 2022 16:49:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNHJR-0000zj-3g; Thu, 24 Feb 2022 16:49:53 +0000
Received: by outflank-mailman (input) for mailman id 278513;
 Thu, 24 Feb 2022 16:49:52 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=u+U/=TH=citrix.com=prvs=04734daf1=George.Dunlap@srs-se1.protection.inumbo.net>)
 id 1nNHJQ-0000zd-D6
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 16:49:52 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c7a09e30-9591-11ec-8539-5f4723681683;
 Thu, 24 Feb 2022 17:49:51 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c7a09e30-9591-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645721391;
  h=from:to:subject:date:message-id:mime-version;
  bh=xdaqC3vPdlD5GBEH73xjVhaAghG0idjd8TE8lvf+1hc=;
  b=UQIESotPbnjQUaRPjjMu83Ao2DIBv6zVxapvWt0zpKEBGSapkIRfsmYe
   Hx4t/3/uNzC2+9L+8f58UPC0XVGauflAVnyKYkY1VywbHZJE/6tvcvPdO
   OyLwJrXZ6KV3EVO1XFguQx1n2T1IW0IV2qROYuwruQnWCloIBRYKQm4hh
   g=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=hardfail (body hash did not verify [final]) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 64358261
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:VoC28K9j3fgKlJ3SqzscDrUDp3qTJUtcMsCJ2f8bNWPdYAuX7wSz/
 BJcAD7Ya7vPIDfrKpolWDmFhU8B6JPSx9ViGlBor3pkQylH9JudD9iTIEr8ZnPIc8eYHUs5t
 Z9GMNPKJZ1oQiOCqEegaOfs/ScjjfuCHuWlWLes1kydPeNBYH5JZUVLx75p6mIRveWEPu+th
 T/Ti5CAZlT6hjN9amtMtfKO+EJjsK+v5G5FtVZgOawbsQWOxiUZVJ4RG/q8fiDyKmV28k9WZ
 AphIJWRpD6xE8IFU4v9+lrDWhRWBOaUZ2Bis1IOM0SYqkEqShcaj+BqbJLwVW8N02/Tx4orl
 I0W3XCNYVxB0pPkybx1vyZwS0mSDYUekFMQCSHi2SA75xSun0rEm52CPmlvVWEr0r8f7VV13
 e4ZMFgwgiWr3Ipa9l4Zpt5E3azPJOGzVG8WV+oJITvxVZ7KSribK0nGCEMxMJ7dSamiEN6HD
 /f1ZwaDYzyfThsfCAg5JascjcC0u0Tac3pq+VWa8P9fD2j7lGSd0ZDoOdvRPNeLWd9UjgCTo
 WeuE2bRW09AcobFkHzcryzq1rSncSDTAer+EJWX+/lwj1DV6nEVDBQOfVC6veO4mgi1XNc3x
 0k8pHZ18PhoqhXDot/VDkeUp0e0my4mBtdfHek1sh6kwYru2lPMboQDZmEYM4F33CMsfhQp2
 0GImZXxCDV1q7qTYXWH6rKdqzi1PzMIKXMDYyBCRgwAi/H7rZsohw/VZtlmGa+xyNbyHFnYw
 T+QqzMlr64OlsNN3KK+lXjFhDKq4JrIZg8z+gjTGGmi62tRfIK4fZah70Tz5PNJPoGfCFKGu
 RAsh8Gb5ftIDteJmSqCUegJNL6s7veBdjbbhDZHHYQl9jmr026ue8ZX+j4WDEZvLssAPC/kZ
 mfSvx9c4NlYO37CRaR3eYOqF8MyzaX6U8ujXfTddNlmbZ14dQvB9yZrDWac1mbsnUxqkqAnN
 I2zdtylBnIXT69gyVKeZeoT3/kI2yo33mjSRrj3yA6h3KCBY2SWUvEON17mRv4+6KSIsQDE6
 eFVPsGBywhceODmayyR+okWRXgRNmQyD53yr81Rd8aALxBgFWVnDOXeqZskeodllqATkf3a8
 3WVU1VdjlH4gBXvMwSDbGl+abXpdZl6pHM/eycrOD6AwX8pYIDp9q4Ze5s+YrAP/fZmi/VzS
 pEtdsmPC+4JSzvD9i8cZILVvI1mdRK7wwmJOkKNSSIjcptXYh3G897pYCPi7CALSCGwsKMWm
 KGtyQrBXdwjRgBuAczMYfSj51+2p34Qgv11RUjTZNJUfS3E1YF2N2rKlvIxKMwWARzZw32R0
 AP+KRsAvuzMv48d+cHEn7yZtJyuF/ZiH01cBC/Q6rPeHSPd9GCyh4JbUOKFeDnbfGzx8aSmI
 +5SypnUKvoN2kpNrIx4HqdDwqc35t+prLhfpixvGXTNfl2xBptlPHidwcAJvapIrpdQogvwW
 ASQ+91WOLOGEMzgGV8VYgEia4yr0vUVhDjf97IxKUDw6TVr1KSOTUhJeReW4ARRM75qGIogy
 PUmvogd7EqiiXICItuAyyxZ6WmIBngBSLk88IEXBpfxjQgmwU0EZobTYgf/5ZCTQ9RKPFMjL
 jKdiOzFnbs07kDYcnM1U2fK2uZGrYQPvBFM3BkJIFHhssTMnPY70xRM7T0yZgtQxxRDlel0P
 wBDO0B4PbmO/nFtrMxfQ3vqEAZEbDWe/kHy0FIPmHfuU1izVmfNIWs+Ps6A5EkctWlbe1Bz5
 7qf1Hr6XR7lecjw2m05XksNg/buS/R85grekcamAsHDHp5SSTHsmKOpaEIDogHrBs53j0rCz
 cFy/eFsc+v4LykUi/Y+B4SQk78XTXisHmVCXPUnx6IPEmH0cSu3nzOJLiiZcNlAIfDD90zjU
 pRGKcdGVhD43yGLxhgcAaMPOLZykOQe7dwOYK7wJWUGvr2cqRJkqJvVsCP5gQcDQtN1jNwyL
 avLdimPD3TWg3ZI81Iht+EdZDD+O4NdIlShgqblq43lCq7vrskzXEdi4OSakky3ISx7wi+xv
 ETxNqjZmrkKJZtXo6PgFaBKBgORINz1VfiV/A3bj+mife8jIu+V6VpL9wCP0xB+eOJIBo8pz
 ejlXMvfgRud1IvaRVw1jHVo+0NhwcypFNRaPcvsRJWxtXvTAZS8i/fvFo3RFHCorD+/zpT/L
 +dbQJHpHTLwZzu77CcLA8S5O0xAY5kblo+6+UuAQw2kU3DxKzDvItK97mPOZmpGbCIOMJCWI
 laq56vwuooE9t8TXERs6xRa73lQegGLtUwOLYCZiNVlJjPw3gPqVkXKz3LMFg0n+lHbSZ2ns
 PoptzD1dQioubGg8T2qm9cag/HjN14k2bNYVhtEo7Ze0mnmZEZbfbV1GchXUfl8z32tvKwUk
 RmQNQPO/w2mBm8aGfg9ify+Njqi6hsmYImhfWVxpxvOA8p0bavZaIZcGu5byyoeUhPozf29K
 MFY/Xv1PxOrxYpuS/pV7fu+6dqLDNuArp7U0SgRS/DPPis=
IronPort-HdrOrdr: A9a23:4g0Dl6q8RuStZOfbcvoDn7kaV5urL9V00zEX/kB9WHVpm5Oj+f
 xGzc516farslossSkb6Ku90dq7MAnhHP9OkMMs1NKZPTUO11HYVb2KgbGSoQEIeBeOu9K1t5
 0QC5SWYeeYZTMR4KaKgzVQe+xQh+Vvm5rY4ds2uk0dKz2CHJsQiDuRZDzrd3FedU1jP94UBZ
 Cc7s1Iq36LYnIMdPm2AXEDQqzqu8DLvIiOW29LOzcXrC21yR+44r/zFBaVmj0EVSlU/Lsk+W
 /Z1yTk+6SYte2hwBO07R6d030Woqqu9jJwPr3NtiEnEESutu9uXvUiZ1S2hkF1nAho0idurD
 CDmWZlAy050QKtQoj8m2qQ5+Cn6kdp15aq8y7nvVLz5cP+Xz40EMxHmMZQdQbY8VMpuJVm3L
 tMxH/xjesfMftR9B6NmOQgeisa4XZcm0BS59L7TkYvI7c2eftUt8gS7UlVGJAPEGbz750mCv
 BnCIXZ6OxNeV2XYnjFti03qebcFUgbD1ODWAwPq8aV2z9ZkDRwyFYZ3tUWmjMF+IgmQ5dJ6u
 zYOuBjla1ITMURcaVhbd1xCfefGyjIW1bBIWiSKVPoGOUOPG/MsYf+5PEv6OSjaPUzve8PcV
 T6ISZlXEIJCjLT4Je1rex2Gzj2MRaAYQg=
X-IronPort-AV: E=Sophos;i="5.90,134,1643691600"; 
   d="asc'?scan'208";a="64358261"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=IG3h2jR7BLovHHujFtcF6yJ7/W9l6JOE1kBOLB1HEy3o9zPcDhlVdHFNiWXpl6uWoQHzpH+QORtkruH2usVMIiU6RXKuoum2/WzQ9QuttHlF6u2HGvNLLKXnKgiTZMWH/mTOIbzrAZUEzT+DmijoWqAeXvTGMR77UUctCm9ImafpKfKp+Oe81f82g8HSg7ICLanuh2lrULc0ExNxQzqtyHRoO/S4PpchDZKfMAORYBKLC/49dn/ezNFysglq6wAE+h+y0S+d43j8A8ybX7gwrznohUl1GRjDQCrQlDAOj7MTZY53FOvQvXpvClqCz4VTnA9ElG7jTejZo4Ls3/Ve5w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=dMVteJp43pHO3mYJNgHdT7wIa4xwlw5yM8lUuP2j/s0=;
 b=b+hwS0R0oAQ4z7p8v4uxPrsESxQBvFnqlNZbwEDsCC0BKLpiD9ZOf3n5SAIoKsvwTE0DOqxE/A7R4tMUHbaA17hzJljBfY56Mfsu+sIjl4IMke0MbcSllZFJ5yaW6g5sDJwf84oyhVZ+lTbyVXvAK6AJKvp//r32HL/TBuheMxcnVAUpl+g5lB3C7fcQ23QX+pJEM+XnCtUymgzrQHX+sTlNKdX0oC5B9UwMdeTLCKOAKqm8yGxI6lILniNb5KAmT1Dt1hi18J4Xy5Zzl2uVXx2OrPkYd25tUvpxwFWXdSOPbT0TRVwQLA63jO6h9XNzZpZ+w+8rQlI8cbjcAt0c5g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=dMVteJp43pHO3mYJNgHdT7wIa4xwlw5yM8lUuP2j/s0=;
 b=V9+wlg9nJj8RgMzFPNsJoPwrE9xOyQkQc0S+nA+IjdLRo1CAq1C3iue0A+ca9DJjeQ12lFjeizozKu3zKY+wJyxwKWlIVeWDdrUSfBRGtlnCEaq91u1ftn/sAhsBIfu3dxfnvT50kUpSOHOOcjMOw9pmkXABS3XUm7rncbk4b5g=
From: George Dunlap <George.Dunlap@citrix.com>
To: xen-devel <xen-devel@lists.xenproject.org>, Tamas K Lengyel
	<tamas.k.lengyel@gmail.com>, "intel-xen@intel.com" <intel-xen@intel.com>,
	"daniel.kiper@oracle.com" <daniel.kiper@oracle.com>, Roger Pau Monne
	<roger.pau@citrix.com>, Sergey Dyasli <sergey.dyasli@citrix.com>, Christopher
 Clark <christopher.w.clark@gmail.com>, Rich Persaud <persaur@gmail.com>,
	Kevin Pearson <kevin.pearson@ortmanconsulting.com>, Juergen Gross
	<jgross@suse.com>, =?utf-8?B?UGF1bCBEdXJyYW50wqA=?= <pdurrant@amazon.com>,
	"Ji, John" <john.ji@intel.com>, "edgar.iglesias@xilinx.com"
	<edgar.iglesias@xilinx.com>, "robin.randhawa@arm.com"
	<robin.randhawa@arm.com>, Artem Mygaiev <Artem_Mygaiev@epam.com>, Matt
 Spencer <Matt.Spencer@arm.com>, "Stewart Hildebrand"
	<Stewart.Hildebrand@dornerworks.com>, Volodymyr Babchuk
	<volodymyr_babchuk@epam.com>, Jeff Kubascik <Jeff.Kubascik@dornerworks.com>,
	Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
	Ian Jackson <Ian.Jackson@citrix.com>, Rian Quinn <rianquinn@gmail.com>,
	"Daniel P. Smith" <dpsmith@apertussolutions.com>,
	=?utf-8?B?4oCL4oCL4oCL4oCL4oCL4oCL4oCLRG91ZyBHb2xkc3RlaW4=?=
	<cardoe@cardoe.com>, George Dunlap <George.Dunlap@citrix.com>, "David
 Woodhouse" <dwmw@amazon.co.uk>,
	=?utf-8?B?4oCL4oCL4oCL4oCL4oCL4oCL4oCLQW1pdCBTaGFo?= <amit@infradead.org>,
	=?utf-8?B?4oCL4oCL4oCL4oCL4oCL4oCL4oCLVmFyYWQgR2F1dGFt?=
	<varadgautam@gmail.com>, Brian Woods <brian.woods@xilinx.com>, Robert Townley
	<rob.townley@gmail.com>, Bobby Eshleman <bobby.eshleman@gmail.com>,
	=?utf-8?B?4oCL4oCL4oCL4oCL4oCL4oCL4oCLQ29yZXkgTWlueWFyZA==?=
	<cminyard@mvista.com>, Olivier Lambert <olivier.lambert@vates.fr>, "Andrew
 Cooper" <Andrew.Cooper3@citrix.com>, Ash Wilding <ash.j.wilding@gmail.com>,
	Rahul Singh <Rahul.Singh@arm.com>, =?utf-8?B?UGlvdHIgS3LDs2w=?=
	<piotr.krol@3mdeb.com>, Brendan Kerrigan <brendank310@gmail.com>, "Thierry
 Laurion (Insurgo)" <insurgo@riseup.net>, Oleksandr Andrushchenko
	<oleksandr_andrushchenko@epam.com>, Oleksandr Tyshchenko
	<oleksandr_tyshchenko@epam.com>, Deepthi <deepthi.m@ltts.com>, Scott Davis
	<scottwd@gmail.com>, Ben Boyd <ben@exotanium.io>, Anthony Perard
	<anthony.perard@citrix.com>, Michal Orzel <michal.orzel@arm.com>
Subject: [ANNOUNCE] Call for agenda items for March 2022 Community Call @ 1600
 UTC
Thread-Topic: [ANNOUNCE] Call for agenda items for March 2022 Community Call @
 1600 UTC
Thread-Index: AQHYKZ6GWVOKVKgeEke5Ycz2R+cy2g==
Date: Thu, 24 Feb 2022 16:49:44 +0000
Message-ID: <7914A3A3-9907-425D-A455-C30A105187C5@citrix.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3693.60.0.1.1)
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 3c793595-ca36-4818-880a-08d9f7b5a8f0
x-ms-traffictypediagnostic: BYAPR03MB4119:EE_
x-microsoft-antispam-prvs: <BYAPR03MB4119B4576A21986ACE2EE997993D9@BYAPR03MB4119.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: fmKRhp/56r/mybdfPuQl0Jc1cX0422fwidjxeI3bnexwgXcP86QGqTR1NzhR/p4T0CltDqecir76blB2jwCFnx+NPf+6gL8vohPKOTp1tvidV9oB/PoMutNR7WUbf+3J6TsrDox5d3XGqhQoc8QqXl0RNGzpGmRmE2D4kjrA2w651aoc6N2pyhFwJcyFfVR/JZmiuFvh4pHNSj0IbBZA427EWPqvXPPqvF30h+7RpW1oS9yeINBCdqEPF43KI+4GcAhJa6fWBi8HZz/v4KJ3IzHa5JVLjfChtId6Koadlrp4wzCECU+IWmDPaBh8QfnEW0FqLXR9L0xFMNuVfNvYLdPI7WluQoEhpM6tOCUhL8FNz4CD/JPUjNGQ65CMSL6xqS2k+WMEYxsPS1ChFvWy1XMeiJTqzar6swP3SIpFinHRgGi2n0gkxbxNywbLJLo7FXTDcNAOvMAQHJBTvIPM1EJC3HZPkqV4ucny0VBQ+/FSTRUrUQ9iOpLLvPhHyP6bH1P9GEAT5B4S2O1ZFpd5sqY7TxadLTrLdhg97Vl75zQY4Mq12ysR4fEIZTkOnuXRbwpWEv4Orygk2IItC6PF+CEr70f2NSycbbh8RI4CaYOpWY/tYZiCM5MKJV5QKkQsVI3wsKBX0wleGXHkMiSi5fs9nd0wY3X1fTLACj5ht2QURFq0Fk+SUkc/AGN0Z59HHEKERE4r41T/hQU2PNOzoUqOvge1K6kdfqJUC/7bwbisXAUj7HY/KnlyoOy2oFpxbjlNDQXpaXXq98bnxVSEEWvK9hErzRWvuHLZmDJifBDaYCN2OQjYYgJBPABLsrcwr8DBjG7nhXoiEe/Ym7+e3oircvQROqM00t2QC1L15sAw+BOl8we0p1X6d8l4ijcU
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(8676002)(6486002)(66476007)(110136005)(66556008)(966005)(508600001)(64756008)(33656002)(91956017)(66946007)(76116006)(7406005)(316002)(86362001)(7416002)(5660300002)(66446008)(2906002)(6512007)(38070700005)(82960400001)(71200400001)(921005)(26005)(186003)(99936003)(6506007)(122000001)(8936002)(38100700002)(83380400001)(2616005)(36756003)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?RlpRQ2JveWdxMW1IN1V2TFVuUGdEYVdXcW4yTlViNkJ2U3FBaXkzSDRVRGZQ?=
 =?utf-8?B?bnE0b1pQU0xoTFF4U0dsRlJycElnRXpFVlhWMC9FTDhMZEVzTlF2V2Q3ZUpq?=
 =?utf-8?B?RzZYNlhueEw0UElZQnRuWDZXUFgvY3JSWHpRYnhRYXBvclVRQk9DenJoQ0lF?=
 =?utf-8?B?UzRTOFIrRUcydkxZaFJwc0V5QjMxWGI1TVdlRWpkLzFQei9NOE9uV0hmWjhW?=
 =?utf-8?B?TlhhNzI3YzhST0gwZ2t3V2RBSjEvR3FMV2lFakRvdVpVNHZrRmdMSkpkSGZu?=
 =?utf-8?B?SUJWM0gzWEtrK1RnTmVxYlFzRUVxNEp6ZlpZRFlDNjdJNEdabkF0NXh5OEtT?=
 =?utf-8?B?ZFoyTC83UGpNamxnd2lYSHVSMFVDa29EeVNnVlZ1bE5jTCtjQndKTW55OWpR?=
 =?utf-8?B?QVBXeklRRWNyeER6cTJKOEtnLzRBV2hWZ1NwZGNZM0I5T0RzRW5MS1RTQk5a?=
 =?utf-8?B?cWk1OTlNT0Z4NStiQ1R4Q3duQmQ2NlloVkpIbDlneDFJSDNiRGtPTFhwcGdP?=
 =?utf-8?B?V2doVFNYT1dLZWpuZnVvV2tnQnBpWHNjci9BbnpjSkFtOFJFVmdRUFVwVUdi?=
 =?utf-8?B?R096bHRIQ0luVXYxVFVEVjJhaTFNd1dOLzhCL3pNUGtyelFGcENvRllUVkRn?=
 =?utf-8?B?Tm45YlArdi9uTUs5SktzenlnVlVIc09aUWJodC82L3E1cTF6blpyVnl2LzY2?=
 =?utf-8?B?cnVXSXB1NzI3MTJNZStUVnhrRWdOa0RQTktKcXdsV2lQeThjZ0x0RVJRZW5O?=
 =?utf-8?B?QzJQNG9SMVBLYnpvK0ZEd29SSEZsYXlQbnBQa0VrVE9UNWlCV3ArUm1CcVFt?=
 =?utf-8?B?dTJXOHRGMm83SmNoK2JuNEF3TXYvRmRPaGE1ZzlpanNZVnlUNzNsWnA2b0cw?=
 =?utf-8?B?akNCelhGRDk4NDM5MXBkN3FROWdsYjYyRjZvRUZ0Z2lJc3NNZ0tMUU9HRmF5?=
 =?utf-8?B?Tlo3RzJWQ0FnOUVLVVlRazdXQ2dnTFcydWszb1RVdkVhWTZsbHVpVkFaanIw?=
 =?utf-8?B?NE8xTmtYQVZKVFc2dnExd1BHMjhQK0hRQkdwdXdyK3RTaWpDQ0oxY2RSWnlu?=
 =?utf-8?B?Z29nN2JIZ0FSTnZsVHE1TkxQNDNHdjVIcHdMVk5pRjVCL2ZTckNoTVlCWFJw?=
 =?utf-8?B?N0NLMzNqa09NS0s3dW5iNmFVL2JjZnZhQVUzM0NTa0FPWU9wcStsZ3JEb09v?=
 =?utf-8?B?SElVMTdnTDM1SzVmVjZKK2JoenhRQUV4OG1wRXJ1aFpHK1VWaWJ2Y2FtZTd6?=
 =?utf-8?B?Y3N0ZDAvNENnbkpiVndBdFZ2K1ZjcENvMzUwVTRJQ0NlbEJvT2ZwNkVlem1a?=
 =?utf-8?B?V2R2SDhaNFJlOVZWUmZ4d2J4TUtqWFBzSk5tWS9kaDJnWDlXakk5bFlPeGJo?=
 =?utf-8?B?M2lPekR6Mm54NjdRa2lIWTNHUkRxM2k2cjM0QXRGTWtZamdaeklJUmxDVk1p?=
 =?utf-8?B?dFNYYzF3dlltWExUU0VKT3k5Vi9iditlQUN2VE5pRHJFK1lmWFJmRkZyTTgr?=
 =?utf-8?B?d29mVlpGRWhaQ1NSUTNkVzZRSHJHMkFsUGtSc2tCMmZFOTNZYi9Mc2JOZG1G?=
 =?utf-8?B?QXQwVTFuNnl0K3VDbm5LVGE4TE1lRXVlcFFYeGRSTEpkeVlrNENuN29aakRa?=
 =?utf-8?B?ZndtNHpOeG9PYWptOGVJL3FWbXRtQ3Z1TTQwTTEyVTNyN0hHeE96NzhFdjJG?=
 =?utf-8?B?MTdBMElzSjJXaU9qT0orQklDSll1QWMzME8wZnlPdWRzWGVGUFZxeHAySG41?=
 =?utf-8?B?Y3RvQkFOakZHZVdPSFVtbUpZK1JGZFJBaGE0QmZwZW5tNXJ0RWhvbVhlN3RU?=
 =?utf-8?B?MFpNQkRhaVA2cXpQWFdOTDhEK2lMaWdBdDFTQWdWVTBSckVZU0xES3JyOUtF?=
 =?utf-8?B?Vi9rWnU1dEJFeEF1UlFjTWVDWWhScndSV0kraGUrTXVhWERtRmhkd0xjWFJ6?=
 =?utf-8?B?VE9EcC81WHIyc2h6eFFuamVLU3ZmNmI0YjhIYzROaU93QkVHOGZVRWNwNWtK?=
 =?utf-8?B?QWR2ekpKUEhqSkpvSE9JcWdaQkRNUkVBQVlkSnV4WXhaSFpvK0FuYUZkbCtH?=
 =?utf-8?B?SXl6c0dOYUpreWJ3ODJ6cGFaaXp6QUl1WlgxamxMOThLMEdzSGR3N2FwYld4?=
 =?utf-8?B?VGFPYUFuZ1o2RFlqVEVFd0pzcHBNK3NmWTdqekpZUithQVBrY1NnQ0hvZS80?=
 =?utf-8?B?ZUJ1elVGczNKUWdjdFdIK296SlRYVVZEZVkvQzF5S2oyZkI4K0hDV3h0clAv?=
 =?utf-8?Q?qjbaP+sqLUZdZnAig/XvSiaEivn+IDiSV8L1Kyy5WQ=3D?=
Content-Type: multipart/signed;
	boundary="Apple-Mail=_6C137B20-D43B-4D0E-BA19-3F791BD06FC0";
	protocol="application/pgp-signature";
	micalg=pgp-sha512
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3c793595-ca36-4818-880a-08d9f7b5a8f0
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Feb 2022 16:49:44.2457
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: AVSiyETcUhPVEK6rDN/AHhi6cI3MwcPvw8a/e5UAjjOS/cYwMsIJlrPP9Kf4/RLHafJRFAuaSBH2wGRq+NfJDT20ip7bcKLJMc81NYo3w80=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4119
X-OriginatorOrg: citrix.com

--Apple-Mail=_6C137B20-D43B-4D0E-BA19-3F791BD06FC0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii

Hi all,

The proposed agenda is in =
https://cryptpad.fr/pad/#/2/pad/edit/UQhtWwPPUUD6p2gWGXEPrIc1/ and you =
can edit to add items.  Alternatively, you can reply to this mail =
directly.

Agenda items appreciated a few days before the call: please put your =
name besides items if you edit the document.

Note the following administrative conventions for the call:
* Unless, agreed in the pervious meeting otherwise, the call is on the =
1st Tuesday of each month at 1600 British Time (either GMT or BST)
* I usually send out a meeting reminder a few days before with a =
provisional agenda

* To allow time to switch between meetings, we'll plan on starting the =
agenda at 16:05 sharp.  Aim to join by 16:03 if possible to allocate =
time to sort out technical difficulties &c

* If you want to be CC'ed please add or remove yourself from the =
sign-up-sheet at =
https://cryptpad.fr/pad/#/2/pad/edit/D9vGzihPxxAOe6RFPz0sRCf+/

Best Regards
George



=3D=3D Dial-in Information =3D=3D
## Meeting time
16:00 - 17:00 UTC
Further International meeting times: =
https://www.timeanddate.com/worldclock/meetingdetails.html?year=3D2022&mon=
th=3D03&day=3D1&hour=3D16&min=3D0&sec=3D0&p1=3D1234&p2=3D37&p3=3D224&p4=3D=
179


## Dial in details
Web: https://meet.jit.si/XenProjectCommunityCall

Dial-in info and pin can be found here:

https://meet.jit.si/static/dialInInfo.html?room=3DXenProjectCommunityCall

--Apple-Mail=_6C137B20-D43B-4D0E-BA19-3F791BD06FC0
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="signature.asc"
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEj3+7SZ4EDefWZFyCshXHp8eEG+0FAmIXtycACgkQshXHp8eE
G+1HCAf/YsOvf4gH/4S4ZF0PazsLhbQxTZCvqGKvny4sAZg9AQZXrPKzbsXgrlHv
JHyF8yYkGsBohXP5V7Z1H4IcwtwEa+ayDiGHRzrPewrASA8PMcRCG3wQkzEEu1a8
FjT8W7XGDwXnDFc1Q3CA6yzzq7MvZJaA9yrzPMop3yBNszj4xzl6dn1K1JWrK+0B
Kn2XGALE2ByAiznVBMICfwKXmkhEz+KVKlwGspr+mL4RPoTWX1fZhp42GBjDjttv
LXVatHtUCwfhOKHpv9Dik/anAqqhHWnRLRzNBbziY87Rnn5f3ap77cH7WvvxuBIL
X7+KXezWQ/M9NsEU4t2MPrnsCF+UPA==
=+Ufr
-----END PGP SIGNATURE-----

--Apple-Mail=_6C137B20-D43B-4D0E-BA19-3F791BD06FC0--


From xen-devel-bounces@lists.xenproject.org Thu Feb 24 17:00:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 17:00:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278520.475804 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNHT4-0002Se-4V; Thu, 24 Feb 2022 16:59:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278520.475804; Thu, 24 Feb 2022 16:59:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNHT4-0002SX-1B; Thu, 24 Feb 2022 16:59:50 +0000
Received: by outflank-mailman (input) for mailman id 278520;
 Thu, 24 Feb 2022 16:59:49 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=6js4=TH=citrix.com=prvs=047c6e0b2=Jane.Malalane@srs-se1.protection.inumbo.net>)
 id 1nNHT3-0002RJ-0x
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 16:59:49 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2b2cc548-9593-11ec-8eb8-a37418f5ba1a;
 Thu, 24 Feb 2022 17:59:47 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2b2cc548-9593-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645721987;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=2+SnpnIe2UeRFXwEc2cG5/BwM17UTPrMDST4j5wAOqc=;
  b=VClIACsG5hdJ05i2jtYUPBFguJMkXCxmGnFC0O8dqB9B/CNHMM2jc8Tu
   HlMeeTHD1FO0TrFasbr6Eb1VJfMrKXlAy9kcFMpcfjpecxtuy8qvNW/3Z
   cN7ElFdCRNRo2oCSd58xo1jQhl6qi/m6R5tYP21KXS733TEpccSAlHFsx
   8=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 64924405
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:9JbZO6Ci7e6WURVW/9Djw5YqxClBgxIJ4kV8jS/XYbTApDJ302FSx
 jYXUD+PP/rZY2X8Lo0naYy29BwEvsKAzt5qQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHWeIdA970Ug5w7Rj3tYz6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhs7
 s506J2RGD10ZO7mtfoDTAgFTgdxaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguwBJc/meqYWvnhkxDfUJf0nXYrCU+PB4towMDIY2JwfR6qCP
 5dxhTxHUU7PODhFHFUtT58snua6hiTHVGQGgQfAzUYwyzeKl1EguFT3C/LZc8KHbd9YlUGZo
 iTB5WuRKgoBKNWVxD6B83StruzChyX2XMQVDrLQ3u5nhhify3IeDDUSVECnur+ph0imQdVdJ
 kcIvC00osAaykuvSdXsWgyil1SNtBUcRtl4HvUz7UeGza+8yxmdLngJSHhGctNOnM08SCEu1
 1SJt8j0HjEpu7qQIVqf67OVoDWaKSUTa2gYakcsTwQf5ML4iJoulR+JRdFmeJNZlfWsR2u2m
 WrT6nFj2fND1qbnyplX43japSmV+5noHzRovEb9c3y78RIkOaiqMtnABUfg0d5MK4OQT1+kt
 XcCmtSD4O1mMaxhhBBhU81WQuj3uq/t3Cn0xAc2QsJ/r2jFF2uLINgIiAySMnuFJSrtldXBR
 EbI8T1c65ZIVJdBRf8mOtnhYyjGIEWJKDgEahw2RocWCnSSXFXelM2LWaJ29zqz+KTLuftiU
 ap3ie72UR4n5V1PlVJavds1374x3TwZzmjOX539xBnP+ePAOCPLFe1ZagDRNrtRAEa4TOP9q
 Yg32yyikUg3bQEDSnOPrd57wa4idxDX+qwaW+QIL7Xec2KK6UkqCuPLwKNJRmCWt/89qws8x
 VnkAhUw4AOm3RXvcFzWAlg+OOKHdcsu9hoTYH1zVWtELlB+OO5DGo9ELMBpFVTmncQ+pcNJo
 w4tIZvYWa0XEmydk9nfBLGkxLFfmN2QrVvmFwKuYSQlfo4mQArM+9T+eRDo+jVIBS2y3fbSa
 ZX5vu8HafLvnzhfMfs=
IronPort-HdrOrdr: A9a23:BkwD0Kk0LuwaW5ATnPpTmzubMYXpDfObimdD5ihNYBxZY6Wkfp
 +V88jzhCWZtN9OYhwdcIi7SdS9qXO1z+8R3WGIVY3SEDUOy1HYUL2KirGSjAEIeheOu9K1sJ
 0PT0EQMqyIMbEXt7eY3OD8Kadb/DDlytHnuQ699QYUcegCUcgJhG0ZajpzUHcGPzWubaBJTK
 Z0jfA3wwZIDE5nCPhTcUN1ONQryee79q7OUFojPVoK+QOOhTSn5PrRCB6DxCoTVDtJ3PML7X
 XFuxaR3NTjj9iLjjvnk0PD5ZVfn9XsjvFZAtaXt8QTIjLwzi61eYVaXaGYtjxdmpDu1L9qqq
 iOn/4TBbU315rjRBDwnfIr4Xim7N8a0Q6h9bZfuwqknSW2fkNiNyMLv/MnTvKQ0TtfgDg76t
 MR44vRjesnMTrQ2Cv6/NTGTBdsiw69pmcji/caizhFXZIZc6I5l/1WwKp5KuZ3IMvB0vFvLA
 CuNrCo2N9GNVeBK3zJtGhmx9KhGnw1AxedW0AH/siYySJfknx1x1YRgJV3pAZLyLstD51fo+
 jUOKVhk79DCscQcKJmHe8EBc+6EHbETx7AOH+bZV7nCKYEMXTQrIOf2sR/2Mi6PJgTiJcikp
 XIV11V8WY0ZkL1EMWLmIZG9xjcKV/NKggFCvsuk6SRloeMN4YDaxfzOGzGu/HQ0ckiPg==
X-IronPort-AV: E=Sophos;i="5.90,134,1643691600"; 
   d="scan'208";a="64924405"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=bK14UY5E/M4p1kKx53/y0sycu+9ryUt3sB81I7A1q5mCCtR7Avev4BlnV8y6kOWp/0zq3xxOMeBbZIWZV1oTa5ctDq7D8qqWzLJtdOtP8IXzpMUhQkXkbrkmJfVRMcDGjZOx6zd1WChOQ+AqbjwM1d0F6+Of3KerrA1fME9wIIBykuJoCkq5nOcA0GD6pJ1TrA6xWyH3M2pxnNfVeiPpTi3VW8qDL2Zto9Nimo/vurB9V/whAGmyMwKb6Q77RHVYPFaUgp6ICYXu2gIm61FEjAHaNV5rMmhwfzKOAExbPfwTf94ISuDtzD90tb5HkcIohukvMy/93k/qVUe0jjn8SA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=2+SnpnIe2UeRFXwEc2cG5/BwM17UTPrMDST4j5wAOqc=;
 b=C/bDa+EGdEng1hFzrWc7xT1+EMpjj3SuYB7HYYKwSrjmcp8BUIjr6b/cvjnjG9aBT/Zh3aBdh1XCUT/kRF1cN+FbZP8vGqxGvqdVrlJpNVjlMq4PEdvtrIxrGlA1Tx8md5+ITJkKRMe1JoN+ZFmUeadPmeMd2Cn/jsAkOY0Vfns6EFMV0+vtIyNXrJsGt/A97GsFhOV8k6Mru1rHox2/o1pdK2XXaGLM4j2FiTewQoa5Sbdz7mRFXJs3+udKd8mhKdKTFgt7V0fijcngrxI/k7kNZk6FeHDj45dfo79QupBcmuG1m+WwMQfwpxFrnbfF7SntBfjHm6evfHsHBOr3OQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=2+SnpnIe2UeRFXwEc2cG5/BwM17UTPrMDST4j5wAOqc=;
 b=gB15Qh1r2bK5M+8gZAKExJZasWlEsmjvbuWbLwWJhTAueZbDITzmrIGr9ILmgmDZTOKSG843MA07IcQDbRCVCsgn3loZF4MvCiV39veqfCFNeDRNLaHHrhKZ67hWGIcw2KDnkMfh7dmdT1EbHK0JILNN/6HXGFHUEUWla28lfr0=
From: Jane Malalane <Jane.Malalane@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Wei Liu <wl@xen.org>, Anthony Perard <anthony.perard@citrix.com>, "Juergen
 Gross" <jgross@suse.com>, Andrew Cooper <Andrew.Cooper3@citrix.com>, "George
 Dunlap" <George.Dunlap@citrix.com>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Christian Lindig
	<christian.lindig@citrix.com>, David Scott <dave@recoil.org>, "Volodymyr
 Babchuk" <Volodymyr_Babchuk@epam.com>, Roger Pau Monne
	<roger.pau@citrix.com>, Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v3 2/2] x86/xen: Allow per-domain usage of hardware
 virtualized APIC
Thread-Topic: [PATCH v3 2/2] x86/xen: Allow per-domain usage of hardware
 virtualized APIC
Thread-Index: AQHYJO0/E2Q9kBLnmUergICAnT03vayiyEcAgAAtrYA=
Date: Thu, 24 Feb 2022 16:59:41 +0000
Message-ID: <50854702-490a-521f-c4af-1de57d4abf4b@citrix.com>
References: <20220218172943.12182-1-jane.malalane@citrix.com>
 <20220218172943.12182-3-jane.malalane@citrix.com>
 <b83773ec-c97a-7aea-e61a-c2e34b270816@suse.com>
In-Reply-To: <b83773ec-c97a-7aea-e61a-c2e34b270816@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 35e5def6-8afd-41e7-3943-08d9f7b70cfd
x-ms-traffictypediagnostic: BYAPR03MB4648:EE_
x-microsoft-antispam-prvs: <BYAPR03MB46480B4080F78480C08BB01A813D9@BYAPR03MB4648.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: M61fCpFKmNCYs9BwR9XGm/4iTkFu8vBwiRcKzqF2mORRGVaJrEbqxYFr8OrqyB4OvnJUYURCuWFqq4Gs//BIZ0KiQjdnijC8HQx1S05aZz9lqvd1paf8rF5elQkERFMpLSKlIPuf28tsQL1owgopAoDZgxjB34D6nw0axjeUKuSbR9eNysaoaURXmiquKtYi+Vx6vgDYcVuOAKnltetmqN1YIVgcd3QH4qEZr7zlBuNy4QKMZBbsxG+OMfESzwlMf1zrcbNY2sLZTjRFc7rfQBGwTcgpmkKLAq0I8+RBncyMCqfvJFPzgA6sPRWYiIK+vC2aNKVD6wmR/FUQ1GArkkMb5qx3fvpzGul+QOvEwIg245XcdSRJunmXTeikTsaTZ4XUI92/CQx+UtsaSYJi7XWDpOyqtIuf5oY7VpcDnI42PWqyFhve4xXduOdoX8cbPwSHURpt1+ne1YbgUOqo1djrZqRQqv7pm1LheKzCsezTPkQaz++gNp5QLBtf7ylkZu16dA9BTvPnhKA0JqiOHL3EiP2cKBa9wLRDIYlIoW9bmrI7zBQk4Ey9DWq5zfwszMraVcrxHVttn5BNBjf5oKJ6uBeyw0VuIHMbpw1U5tttO0KLtf+4TV7C9qZ7PTbEiPVZLLhHqHYQv2V1nYmtsX1/j6wxKZ5NSQIAedga0Lflf8UY2n1FzpIe5NKpMzmIGHNBdvBOuqqhQ3KbpDhQNKu1LvT8iXimOQ5CSgJOpZAuOLwh55VeNmKY0vrE8aMt
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR03MB3386.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(86362001)(91956017)(6486002)(2906002)(186003)(66946007)(26005)(53546011)(66556008)(8676002)(4326008)(66476007)(66446008)(64756008)(508600001)(36756003)(31686004)(316002)(6512007)(6916009)(54906003)(76116006)(6506007)(8936002)(82960400001)(38100700002)(5660300002)(2616005)(71200400001)(31696002)(83380400001)(122000001)(38070700005)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?K1NENHM5dGxGUEhJZ0Y1eTlkUnRhejJDM0FSU2FCajhoK08rcndLeUVkRzBW?=
 =?utf-8?B?WEVhV1NRZkp6bDdURHRaWHU0MlNQeCtoa3IyWWVrejVrZ2Frdk9pbUdqUmtI?=
 =?utf-8?B?cXAzbWRJS2lhUEMyeFJEbTFIZFZUc1doek1LYmJXWTkwL09XbzhZT0N5SVRL?=
 =?utf-8?B?K240cTloem1ac0UraXdRWjJhd0xxMjVQakJIbnpOYnJNeW1FTGJhNVkySzRB?=
 =?utf-8?B?Qzhrc1RybmFDeERCVytDZVVjQ1FMYnRybm40UUFxczlDYTdISHhTSVJEN09L?=
 =?utf-8?B?TFJqS1lLVXZwT01lL1Fkam9vRzFYN0ZEckEzcm5RYUtWUXIwZUVjTDc4VHpL?=
 =?utf-8?B?WEtRRzJxZzVaSkpoNFpwdUFYTTR3MXhzZlgzVWl4TjVMTCtPaWdWN3Z2ZjUy?=
 =?utf-8?B?S3pJOXVQTCt3RGYwdE81eW9rTFlOTkpGaEF1YndBTUpqKzgrUmwxcjYxcXlU?=
 =?utf-8?B?NGVrT1FNRCtzN3QwVnpLdjVLZStKdmd1RHFrOGRJNXFBeXR6UTdCWCtJdlNz?=
 =?utf-8?B?NS85cGxXOUtxVjh6ZWRkUjBGSFZNdS9sN0NDbVJXcmJQRWNwV0U0c3Y4SzVH?=
 =?utf-8?B?WjlLbGszMGtNbkFJa25DTTdxekFqZFRIdkVveWxVd3BYc3A1c2prK3VoTlhO?=
 =?utf-8?B?STRyZ2tRbGxuRzE3UEFaUkYxY21jR1U4RWtzV3U0OWplUFRLZlJrMWVZb0wv?=
 =?utf-8?B?TUM0MW8yZ1ZCYUVzMkRRNFNENThOVkQyRVFORE5KUFJvTzBUWkVYSVBGM3B6?=
 =?utf-8?B?QnRWYjEvWHpiZi9MellpT3cvcjlZeEFBUVRTOE9SVEFlOFF4ZThmcm84THpQ?=
 =?utf-8?B?Rk9rSFdHd0NCeGppbUNhKzdsTkVUV3hoc2oyU3FaeE1LYmpUdFAvVC8rYkNs?=
 =?utf-8?B?SW9xWXZBM05EUGMrR3F3S0cydlNvdnpWZlVLeW9KSWR6Y1RBd1F2cEdNQi9E?=
 =?utf-8?B?Z3VHY0VkS2Z1K3pyUTBaMldHMnFQNm0yQTJXMmZGcjEzd2FaR0FNZDlyczcx?=
 =?utf-8?B?aFQwd3U2S2FyTFp5cU9nRFdPQVFtUkQ1RmJyNm92SFZ6Tk9VbDkrbEg2TGxz?=
 =?utf-8?B?MFlyN0dwNEx0N0VudXlxbS9FZThDMEl0cGtqTVFVdWpJdi92NWV0eHNWVmpZ?=
 =?utf-8?B?YmduVUFBMUkwb0FTaGJYRVR0RlgzVDg1WlFUbmtad1FLNnpZMmhsSmhYeExC?=
 =?utf-8?B?Mm9xU0hFUVE4TTY4L2E2YVV3ZHFLRHNuMHJoTHRJdWF3S1dqSkh2cTdQN3NW?=
 =?utf-8?B?Z09Jakkrd1pzR2dxejRsUnJuL1JiVWt1djBYT2pPR3Y2UE9ScEZ5TUlpRkoy?=
 =?utf-8?B?eXB0cnRyOGFyUlpwVGliM2hhNU9XVXNaZ0xPSFNBSC9zeXovQ0pkYlQ1eUla?=
 =?utf-8?B?RStneWRvcU43L21uWUJibG5TNGdoVTlUSXZrZjBrM3ZoVWlqa0FMYitSWW9S?=
 =?utf-8?B?VFN0T0tsalM4ZDdWK05OYVd0aDdYa2JHVEgvcGxwbEJIaU1qSU1pZXd5dyt0?=
 =?utf-8?B?cC9Sa3M2L2tVUHpzcjRGQVF5VnRXYi9oN0RzeWMvL0ZIZ3VJekRKamRwcFNo?=
 =?utf-8?B?aEhkVEpNOUNPakJsU1NhU1JkTkM3UUFmeGNidUM2ZGhBbnR0NGxIOE8ycVU0?=
 =?utf-8?B?Kzl0Z25TQWFmam9FQWd1TVBDMUhBT1N1SEhYMkdBNTFVMTErekplSU9zQ3lO?=
 =?utf-8?B?SjhaTTF5ck9WeGlnOUV5bStkWldGdnZUVFhQRnE0N2lsOXV1cWhJellUYWNV?=
 =?utf-8?B?TEFVQWViZVpqOFVCeHN1eGx4WGRXS2NjUjliUTR0UGwzWEgzZ3VGRlRrSzNn?=
 =?utf-8?B?OGtReGNLbHowMEZQQlRiaHNQckIvV3ZOaThGS2NuS212L0cwNlFUSEt4dXJy?=
 =?utf-8?B?bDBENnFHK2JGL0w4STdzVjZCTndlcXlTbFozVmExU2hFR2Rabm9LeEhGWDJW?=
 =?utf-8?B?ZnZEaVM0dkpKTDhlZVlkVG1DREdFeWpEOGFiNWpWNWVDU3pLMk5Mb0pqSm5o?=
 =?utf-8?B?RmR2ZEVObjFaU3U1aTY2cExWSXIzVlRSLzRaSHNSMEIwc2RKcjY4RUJwUCtK?=
 =?utf-8?B?Ukd4QmtOZ0VXdng3elVFQ0ZBRzFzNWRHNTJjNzlwRkk4NkVQR1VhQkdMem4z?=
 =?utf-8?B?ajE3SGVSckl4WTBrTXMxM3FyK0dHMXZ0RXBMaGRYSUdVTVhZVUtjSWFOY1pD?=
 =?utf-8?B?aVJ4bWJjL3lWUEdQR2NZN1lHY3h4R3hiVHdnMUpsUXZLd2tTOVJ1czdIRldq?=
 =?utf-8?Q?ExXYJWvMYWAvKL7Si9kjH3+CV0gOFJnNqbnKsvKDnE=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <44F3199BB171444AB7F1D163082F7B58@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM5PR03MB3386.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 35e5def6-8afd-41e7-3943-08d9f7b70cfd
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Feb 2022 16:59:41.7539
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 6QMPhzxIlND2L8G+dSRZAeqYE+Yt7JFC1RwOc9U8cD73EbN7xfqJ6AcdepgAKLimutdbqGhjHFi/FSdKDpNxzT2sn8z6Swoird0B/UEiv/E=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4648
X-OriginatorOrg: citrix.com

T24gMjQvMDIvMjAyMiAxNDoxNiwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IFtDQVVUSU9OIC0gRVhU
RVJOQUwgRU1BSUxdIERPIE5PVCByZXBseSwgY2xpY2sgbGlua3MsIG9yIG9wZW4gYXR0YWNobWVu
dHMgdW5sZXNzIHlvdSBoYXZlIHZlcmlmaWVkIHRoZSBzZW5kZXIgYW5kIGtub3cgdGhlIGNvbnRl
bnQgaXMgc2FmZS4NCj4gDQo+IE9uIDE4LjAyLjIwMjIgMTg6MjksIEphbmUgTWFsYWxhbmUgd3Jv
dGU6DQo+PiAtLS0gYS94ZW4vYXJjaC94ODYvaHZtL3ZteC92bXguYw0KPj4gKysrIGIveGVuL2Fy
Y2gveDg2L2h2bS92bXgvdm14LmMNCj4+IEBAIC0zMzMzLDE1ICszMzMzLDE1IEBAIHN0YXRpYyB2
b2lkIHZteF9pbnN0YWxsX3ZsYXBpY19tYXBwaW5nKHN0cnVjdCB2Y3B1ICp2KQ0KPj4gICANCj4+
ICAgdm9pZCB2bXhfdmxhcGljX21zcl9jaGFuZ2VkKHN0cnVjdCB2Y3B1ICp2KQ0KPj4gICB7DQo+
PiAtICAgIGludCB2aXJ0dWFsaXplX3gyYXBpY19tb2RlOw0KPj4gKyAgICBib29sIHZpcnR1YWxp
emVfeDJhcGljX21vZGU7DQo+PiAgICAgICBzdHJ1Y3QgdmxhcGljICp2bGFwaWMgPSB2Y3B1X3Zs
YXBpYyh2KTsNCj4+ICAgICAgIHVuc2lnbmVkIGludCBtc3I7DQo+PiAgIA0KPj4gICAgICAgdmly
dHVhbGl6ZV94MmFwaWNfbW9kZSA9ICggKGNwdV9oYXNfdm14X2FwaWNfcmVnX3ZpcnQgfHwNCj4+
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjcHVfaGFzX3ZteF92aXJ0dWFsX2lu
dHJfZGVsaXZlcnkpICYmDQo+PiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNwdV9o
YXNfdm14X3ZpcnR1YWxpemVfeDJhcGljX21vZGUgKTsNCj4+ICsgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgdi0+ZG9tYWluLT5hcmNoLmh2bS5hc3Npc3RlZF94MmFwaWMgKTsNCj4gDQo+
IEZvbGxvd2luZyBmcm9tIG15IGNvbW1lbnQgb24gcGF0Y2ggMSwgSSdkIGV4cGVjdCB0aGlzIHRv
IGJlY29tZSBhIHNpbXBsZQ0KPiBhc3NpZ25tZW50IG9mIHYtPmRvbWFpbi0+YXJjaC5odm0uYXNz
aXN0ZWRfeDJhcGljIChhdCB3aGljaCBwb2ludCB0aGUNCj4gbG9jYWwgdmFyaWFibGUgY291bGQg
Z28gYXdheSksIGp1c3QgbGlrZSAuLi4NCj4gDQo+PiAtICAgIGlmICggIWNwdV9oYXNfdm14X3Zp
cnR1YWxpemVfYXBpY19hY2Nlc3NlcyAmJg0KPj4gKyAgICBpZiAoICF2LT5kb21haW4tPmFyY2gu
aHZtLmFzc2lzdGVkX3hhcGljICYmDQo+PiAgICAgICAgICAgICF2aXJ0dWFsaXplX3gyYXBpY19t
b2RlICkNCj4+ICAgICAgICAgICByZXR1cm47DQo+IA0KPiAuLi4gaGVyZS4NClByZXZpb3N1bHkg
d2UgZGlzY3Vzc2VkIHNldHRpbmcgdi0+ZG9tYWluLT5hcmNoLmh2bS5hc3Npc3RlZF94YXBpYyBl
cXVhbCANCnRvIG9ubHkgY3B1X2hhc192bXhfdmlydHVhbGl6ZV94MmFwaWNfbW9kZSwgdGhhdCdz
IHdoeSBJIGhhdmUgdGhvc2UgDQphZGRpdGlvbmFsIGNoZWNrcyBhcyBhdCBsZWFzdCBhcGljX3Jl
Z192aXJ0IG9yIHZpcnR1YWxfaW50cl9kZWxpdmVyeSBhcmUgDQpuZWVkZWQgZm9yIHRoZSBzdWJz
ZXF1ZW50IHBhcnRzIG9mIHRoaXMgZnVuY3Rpb24uIEkgbWlnaHQgYmUgDQptaXN1bmRlcnN0YW5k
aW5nIHlvdXIgcXVlc3Rpb24uDQoNClVubGVzcyB5b3UgbWVhbiB0aGF0IHdlIHNob3VsZCBmYWxs
YmFjayB0byBoYXZpbmcgDQp2LT5kb21haW4tPmFyY2guaHZtLmFzc2lzdGVkX3hhcGljIGRlcGVu
ZCBvbiB0aG9zZSBvdGhlciBmZWF0dXJlcy4uLj8NCj4gDQo+PiBAQCAtMTEyNCw5ICsxMTI1LDgg
QEAgdm9pZCBjcHVpZF9oeXBlcnZpc29yX2xlYXZlcyhjb25zdCBzdHJ1Y3QgdmNwdSAqdiwgdWlu
dDMyX3QgbGVhZiwNCj4+ICAgICAgICAgICAgKiBhbmQgd3Jtc3IgaW4gdGhlIGd1ZXN0IHdpbGwg
cnVuIHdpdGhvdXQgVk1FWElUcyAoc2VlDQo+PiAgICAgICAgICAgICogdm14X3ZsYXBpY19tc3Jf
Y2hhbmdlZCgpKS4NCj4+ICAgICAgICAgICAgKi8NCj4+IC0gICAgICAgIGlmICggY3B1X2hhc192
bXhfdmlydHVhbGl6ZV94MmFwaWNfbW9kZSAmJg0KPj4gLSAgICAgICAgICAgICBjcHVfaGFzX3Zt
eF9hcGljX3JlZ192aXJ0ICYmDQo+PiAtICAgICAgICAgICAgIGNwdV9oYXNfdm14X3ZpcnR1YWxf
aW50cl9kZWxpdmVyeSApDQo+PiArICAgICAgICBpZiAoIGNwdV9oYXNfdm14X2FwaWNfcmVnX3Zp
cnQgJiYgY3B1X2hhc192bXhfdmlydHVhbF9pbnRyX2RlbGl2ZXJ5ICYmDQo+PiArICAgICAgICAg
ICAgIHYtPmRvbWFpbi0+YXJjaC5odm0uYXNzaXN0ZWRfeDJhcGljICkNCj4+ICAgICAgICAgICAg
ICAgcmVzLT5hIHw9IFhFTl9IVk1fQ1BVSURfWDJBUElDX1ZJUlQ7DQo+IA0KPiBXaGlsZSB3aXRo
aW4gdGhlIDgwIGNvbHMgbGltaXQsIEkgdGhpbmsgaXQgd291bGQgaGVscCByZWFkYWJpbGl0eSBp
ZiB5b3UNCj4ga2VwdCBpdCBhdCBvbmUgc3ViLWNvbmRpdGlvbiBwZXIgbGluZS4NClN1cmUuDQoN
ClRoYW5rIHlvdSwNCg0KSmFuZS4=


From xen-devel-bounces@lists.xenproject.org Thu Feb 24 17:05:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 17:05:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278529.475816 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNHY1-0003wR-Sh; Thu, 24 Feb 2022 17:04:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278529.475816; Thu, 24 Feb 2022 17:04:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNHY1-0003wK-Pe; Thu, 24 Feb 2022 17:04:57 +0000
Received: by outflank-mailman (input) for mailman id 278529;
 Thu, 24 Feb 2022 17:04:56 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=VLhp=TH=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nNHXz-0003wC-UP
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 17:04:55 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e31d2ac3-9593-11ec-8eb8-a37418f5ba1a;
 Thu, 24 Feb 2022 18:04:54 +0100 (CET)
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2051.outbound.protection.outlook.com [104.47.2.51]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-20-fbm9m3G5M32sL8OnM3eo8w-1; Thu, 24 Feb 2022 18:04:52 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DB8PR04MB6905.eurprd04.prod.outlook.com (2603:10a6:10:113::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.24; Thu, 24 Feb
 2022 17:04:47 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.024; Thu, 24 Feb 2022
 17:04:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e31d2ac3-9593-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645722294;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=scsAPxl3AoD+EZsEa2mAz7jdIUYdI2bYxnO99MqC5GI=;
	b=amsaA9vK9qVK8UYXHLvQoXzScGq/mK4TbLNeSDjXf5io4T4mKeQ8SBkbGFkBM5OSBSC4/f
	70k1SkIiAf37zHxzE+suVgn6Tmwg9D+xRKcxmL7+XggalwR96Va+LFg3b44Vl+JAMZP72U
	7oGut6H/E6i0DHr/apo8kF80F0Bv/Ds=
X-MC-Unique: fbm9m3G5M32sL8OnM3eo8w-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=NxAdLhRuj0O5lzbDnINvzvMvcFCnP+NlyaDwBCeat6R9wAorkHldvIztjy3knSEjnZw/534Hok3DKu9FILiHiaMskO8lAl9HQtmmDQReKq0yT4rS+aJd67SBoysJVbJaMxhQRjH1Yg/CNy5ik8RH75imrBPRzJH0uDmHUknhdK8jFC0/9zCgrOffjm7PJx4MU/LhVCnt3pdPhZv2f/jAZixR1aelqcteKVYBHBg3cKDALK8mD1Cy2LhoMHyhG+JhlBfrldtnLxyVO4uF8eJMqWzEH/QfuKjZEjnOpxKMwr4Z5VTteffnxrN8SSE4Yf0RXLjHDNNiV85LZYqVdselSg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=scsAPxl3AoD+EZsEa2mAz7jdIUYdI2bYxnO99MqC5GI=;
 b=nA0eLBvP2M6GtW38eH5Kz6o8icuiHtUwN7izWbDEXusP/w861O1eqVgAMN0gzUZ4JBAWaINseAxKJHf1e+4aknzT1FKYY1HTtwaQQrR575DBq8cpQXPnsksBLg9o/6TbugtUNFX+wuSGllpsP+z+s5xhjsaPEYoHkZPcFvkmkmUpsxZ9laVs2ZRBdZwQPllYmh+YcJmghugtEyBwMs2kLzQ0QczDFn1zQtfV9Uw5ao13V2EH/5WLdCiLXGrn7gOcoiFXlw/tNGfcfsbl1o41R00zSrogUIU222L0u6dYphkALLGtgRq8NWlLuSzpnGcjRaQYemuMuOo3H4jQURpMgw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <e7c952bf-ac8a-156f-6015-738ff5eaa138@suse.com>
Date: Thu, 24 Feb 2022 18:04:45 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v3 2/2] x86/xen: Allow per-domain usage of hardware
 virtualized APIC
Content-Language: en-US
To: Jane Malalane <Jane.Malalane@citrix.com>
Cc: Wei Liu <wl@xen.org>, Anthony Perard <anthony.perard@citrix.com>,
 Juergen Gross <jgross@suse.com>, Andrew Cooper <Andrew.Cooper3@citrix.com>,
 George Dunlap <George.Dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Christian Lindig <christian.lindig@citrix.com>, David Scott
 <dave@recoil.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Roger Pau Monne <roger.pau@citrix.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20220218172943.12182-1-jane.malalane@citrix.com>
 <20220218172943.12182-3-jane.malalane@citrix.com>
 <b83773ec-c97a-7aea-e61a-c2e34b270816@suse.com>
 <50854702-490a-521f-c4af-1de57d4abf4b@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <50854702-490a-521f-c4af-1de57d4abf4b@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P194CA0087.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:209:8f::28) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5e56c004-ab83-4c20-53c7-08d9f7b7c335
X-MS-TrafficTypeDiagnostic: DB8PR04MB6905:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<DB8PR04MB6905660458439CA307A68756B33D9@DB8PR04MB6905.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	aFzHMCPdnsiFgjhW4UZCfFvqCGNC44j9M9b47VWIg4X0OscCRzYkAongRRm0eobL/FIJqg9XBW5Gjpe5P7Rym3KFCxBNBZoA1BgTUF4X7ANSocCZLLhLQ0B2RjwM/Zu/zx5Qmp9QV5mgkOXOb402OBtTvrdLnFBzEOf1fKTSgyGF0eREtMsA5Z40glG5FV3u3LadOWIEaMAS3aq9wmXoPOlk3qiob4awXXmLPvYetCVQqhJjaH4lAoagEPWNiHXVDlS+nBpZ658/xrr2m314Ccx0jJ7B8uVGWLQcMt0MKP0muBEVhWZIKXNfvHnK6dNBWEOIcCLyOX5cqxKT338XTX/Uyc7IVrKQb3EYl+ALfdxYjuCsNOo9R3ye+a5EJ++j0kTiXILjYVXV3KqauJdSJa+e018X/ZSN1XXN3ZSmXQ2ZGinoDM0ga8xTZNyOZvV1VCb5JdPVOEQ9K/o1kT2q7FrFCMhjW0LQCtxhul1nU9vIuzy77FQjeuVOlQe0wleWY/hTL93L3fUu/7GFSvLn/XKg3/lpAD4V3wxHeFojXILMygGPLKIqdNXs1ybejEBYxg51S96nP7oQOZoInsGU5KdI31+W/ygcIQHYlgwZeIVOKylFHUN9ReHCO4BnrYivIfrgXRikkKNaZ1GJDHt3XbmtlI0hq4/EYT5mH7XLf5Df91GohXfJwwNABxA2t3VCNrMtz0wlPlFUv3J/YQXMAZaDe2YE6ygqK9+pDR0nNFw9opssENJI4Wyum8ghlSJa
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66946007)(31686004)(83380400001)(36756003)(2906002)(6506007)(8676002)(4326008)(66476007)(66556008)(5660300002)(508600001)(6916009)(38100700002)(54906003)(7416002)(8936002)(2616005)(186003)(26005)(316002)(53546011)(6486002)(86362001)(31696002)(6512007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?SXdJaHpMSjFZa2xBMDFmM2Q1N0dRZldFTHcwZ3BqMXpySXBJam95cllvNDg1?=
 =?utf-8?B?b0RZeHFHOVFXb21kMy80d1Y0d0tjdW0vaytiMTc0aFF2OENZNmhtblpKL0E2?=
 =?utf-8?B?UjBGeWlwM3g3Wnc5ZWZsbkl4WnZ1SklQa1M5bEx3cS81Q1hSK0RSQ1EwSWVh?=
 =?utf-8?B?SUNNMXRTRjM5MUZPdFFpNjZhSGdjcHUvbU9VbHVHc2FBYWdIOHZPT3ZSZTdo?=
 =?utf-8?B?Qm9VUCt4M0FVS0N0b0tQZGh1enRZWXhDWDJDaG5YRFVlbzVGNE1qcDhKYXYr?=
 =?utf-8?B?SmI5ckFGU1pXSjJZZVAxdCtSZ2lvcXdtMGJHMEg2Y3BLTXhyY3ZpaVlxYW1M?=
 =?utf-8?B?YldKbUhXOVR6bm9JWWdNdWo4ZUFkZlZocWc1cGY4WlRUaW1lay9yMW5DOVgw?=
 =?utf-8?B?cmJzUlczSXdhUi9kVUNOd0pmU3dBcEc0VXhob2RsOFFJRkV0cWRvRFM3WTFz?=
 =?utf-8?B?OHEvK1RrakxSVVR1RFRtRW5wcDlYNE9sRnpTYW5oMmxZVlpLbnZ3TVQyZ050?=
 =?utf-8?B?WEUzQkhGYkNXK1EvaUY0bXdYd29VcytINWNOcEJWUmo2dGxjazlmUCtTUmVY?=
 =?utf-8?B?TzlWaGs3VlUzcGdVL0RtOTRpSVJzVFIrREEwSTNPUkFtd1ZHeXdyemw3NTU5?=
 =?utf-8?B?c2RuOTR6WEcwRmhQVkQxaWVoMDY2Rmp2TE5KL0lRTDJmcXhUUGxkSWRsVFpa?=
 =?utf-8?B?bHcySTU0MHVIWU1wdlI0WFhHRlBhdGVva1JzRUNOT1YvcENEdEEwVlNiLzBR?=
 =?utf-8?B?VHh1Yld4NXhyRnhHUkxIOXhJK2xhOExoWU13U1dkVEhYTlhiaGZKaE54Mncr?=
 =?utf-8?B?QmFCa1hTemQySVNlR3lsL0hERHRVWVhwUXhsbUZyVjVMTnFCUTNtSVQ1UHNo?=
 =?utf-8?B?NWtNOTF5ZmFaU3J1UVV1MVJaU3F6VkUvcXlCMXp5NTNoUllCZTlIcGtsRVBC?=
 =?utf-8?B?VnQ4L0xxRll5bVd4U3REZU9kdEttNDhMNmpidXlWcVhuWk1pdE1sbjNueXUx?=
 =?utf-8?B?eEZWUm1yRjBFM09MN0RCU2lQL2x6TStQTzd2MXV3NXBEYTQvQVU0cTQ4R0Ew?=
 =?utf-8?B?ZTl0Y2h1VWQzNEt6c2RKWEZ2LzIvb1lQZHpFN0owcm0zOEc0dDJ5MytxRWpW?=
 =?utf-8?B?bFM0eXEva1BzakVpN01QVExVT2FFdUwybUZXN0NqZ2JiWWtsWTVuRVBHMTBG?=
 =?utf-8?B?N1BhbzNRTFYxQmZjalJma21PQS9RaVZvYnIwK0ZFVmhCVm5wWmt5Z0E1TXN0?=
 =?utf-8?B?Um4ycmxFd3NPQ3NOWXVrdjZ6MkhDbFN0OC9iMTJRZVEvZEtYdlc2NFpPZDA0?=
 =?utf-8?B?TVlEL3VCTjc5TTFlUFBQTmVDakNtbjMwNDNDbkJhWEx2YWQvSVJ4RGhIZmlC?=
 =?utf-8?B?RXA0c1RyTFFzNjFzWnVrZytVT01DZ0lhQUpxWTkybzVPcWtGZ2NYM2F1WVhK?=
 =?utf-8?B?QjVSTDFuVU43djltTFVCaXE1eUNNTms5OEp4Q2dBNzJxYWFIZjdqNk5GdXU5?=
 =?utf-8?B?Y3JiVzFTU0FWakFnZ1FIWkRuRnJUK1NaK2FISlJQRnJYUk93SU4xbkZXRjM0?=
 =?utf-8?B?T1RwYytISmVWbWV6b0NCRGFSRnNFRWlTRE16Y3d1ZUpjQktmQ2R4TFhXV0hj?=
 =?utf-8?B?MmwxZTRveHBrTnQ1Z2lZZTNVQU9rV0NtMkJYb3RYaGhQMkxaOTJUMEpwdHdC?=
 =?utf-8?B?MXNrNXQ4Q2xEeFJaYmdkaisyeXNkbEhKR3RJOUJER1RpSHM0TnVacGFRRG9W?=
 =?utf-8?B?NXE0aExHeDdoclBDR0w5MU5uN0lReDF1NHJheko3UHdPd1JnbVd5cTdqRWxl?=
 =?utf-8?B?YXp2aGtZVC9vUzZKL3EwQWpIOG1HTmJRejJCTHBmSlZzMlNqS2ljYUdTZFky?=
 =?utf-8?B?WEcrSTBEaENSQlY4TWJnaGxOVVAxczNkblU4bEM0Y0xTY1VlWUxHb1VWYXho?=
 =?utf-8?B?SEQ1WlNqT1VJb05QTGE1YTZDN0NyajRzRFd0Zlg0MFdmUWNQaWc2VXAzV08z?=
 =?utf-8?B?YkVIeW03M3NqMjkyTW1QWENmVWY3UDBEOHgxWTEwaDlrM1FZaGNCa09tRkJu?=
 =?utf-8?B?RVlQcFZiZDdzbElJTmNGeUR1c0cxUkJpVW5sT3BqMmp6UXBmZUkyald2VUFi?=
 =?utf-8?B?THlUdnpVamlkNkN0a3R1a2JZOFhaOGQ4aWJ0NTdNemlWdXByaFNQamtKVzZs?=
 =?utf-8?Q?Mbatm+HYM8O6FlcQWge7THE=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5e56c004-ab83-4c20-53c7-08d9f7b7c335
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2022 17:04:47.7326
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XRLnExaqfHw8lp7qPvvcrhj43+XsSS4Xs6o70RF8sk/iDfvd0y3CVuIXXzs/9+kOgPDQhzkg7q8Y8cmLb0tnlQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6905

On 24.02.2022 17:59, Jane Malalane wrote:
> On 24/02/2022 14:16, Jan Beulich wrote:
>> [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments unless you have verified the sender and know the content is safe.
>>
>> On 18.02.2022 18:29, Jane Malalane wrote:
>>> --- a/xen/arch/x86/hvm/vmx/vmx.c
>>> +++ b/xen/arch/x86/hvm/vmx/vmx.c
>>> @@ -3333,15 +3333,15 @@ static void vmx_install_vlapic_mapping(struct vcpu *v)
>>>   
>>>   void vmx_vlapic_msr_changed(struct vcpu *v)
>>>   {
>>> -    int virtualize_x2apic_mode;
>>> +    bool virtualize_x2apic_mode;
>>>       struct vlapic *vlapic = vcpu_vlapic(v);
>>>       unsigned int msr;
>>>   
>>>       virtualize_x2apic_mode = ( (cpu_has_vmx_apic_reg_virt ||
>>>                                   cpu_has_vmx_virtual_intr_delivery) &&
>>> -                               cpu_has_vmx_virtualize_x2apic_mode );
>>> +                               v->domain->arch.hvm.assisted_x2apic );
>>
>> Following from my comment on patch 1, I'd expect this to become a simple
>> assignment of v->domain->arch.hvm.assisted_x2apic (at which point the
>> local variable could go away), just like ...
>>
>>> -    if ( !cpu_has_vmx_virtualize_apic_accesses &&
>>> +    if ( !v->domain->arch.hvm.assisted_xapic &&
>>>            !virtualize_x2apic_mode )
>>>           return;
>>
>> ... here.
> Previosuly we discussed setting v->domain->arch.hvm.assisted_xapic equal 
> to only cpu_has_vmx_virtualize_x2apic_mode, that's why I have those 
> additional checks as at least apic_reg_virt or virtual_intr_delivery are 
> needed for the subsequent parts of this function. I might be 
> misunderstanding your question.

My expectation would have been that assisted_x2apic_available is assigned
what is (in context above) assigned to virtualize_x2apic_mode (in patch 1).
Anything deviating from this needs, I think, explaining there.

> Unless you mean that we should fallback to having 
> v->domain->arch.hvm.assisted_xapic depend on those other features...?

No, xapic is fine afaic.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Feb 24 17:08:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 17:08:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278536.475827 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNHbK-0004Zo-Bk; Thu, 24 Feb 2022 17:08:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278536.475827; Thu, 24 Feb 2022 17:08:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNHbK-0004Zh-8N; Thu, 24 Feb 2022 17:08:22 +0000
Received: by outflank-mailman (input) for mailman id 278536;
 Thu, 24 Feb 2022 17:08:20 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=FHEV=TH=oracle.com=boris.ostrovsky@srs-se1.protection.inumbo.net>)
 id 1nNHbI-0004Zb-9C
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 17:08:20 +0000
Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com
 [205.220.177.32]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5c6d7a94-9594-11ec-8539-5f4723681683;
 Thu, 24 Feb 2022 18:08:18 +0100 (CET)
Received: from pps.filterd (m0246632.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 21OFWY9S007293; 
 Thu, 24 Feb 2022 17:07:42 GMT
Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79])
 by mx0b-00069f02.pphosted.com with ESMTP id 3ectsx81m3-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 24 Feb 2022 17:07:41 +0000
Received: from pps.filterd (userp3020.oracle.com [127.0.0.1])
 by userp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 21OGuuWh068779;
 Thu, 24 Feb 2022 17:07:40 GMT
Received: from nam11-dm6-obe.outbound.protection.outlook.com
 (mail-dm6nam11lp2168.outbound.protection.outlook.com [104.47.57.168])
 by userp3020.oracle.com with ESMTP id 3eat0r21w2-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 24 Feb 2022 17:07:40 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10)
 by BYAPR10MB2933.namprd10.prod.outlook.com (2603:10b6:a03:88::29)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.24; Thu, 24 Feb
 2022 17:07:38 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::6d20:6694:a16:56f7]) by BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::6d20:6694:a16:56f7%3]) with mapi id 15.20.5017.024; Thu, 24 Feb 2022
 17:07:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5c6d7a94-9594-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date :
 subject : to : cc : references : from : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2021-07-09;
 bh=+nO2rVtfBk9wR3DMR04tVAteK2MA3ZuQ7oyViyDcIDI=;
 b=BSO7Y07jUq+hOiswwyQjaNk0Rf4Qem25r1XSYc06GKiF7kkMoALbP4o+BzutS40I69Fd
 8ihLbse+7W6v+nkMuxEk5EqVL/Pno1ymI6GT5qmk5Ob9vZgkC9AKwRgMHRXHVoMtFmHK
 ihA/qxSIp0rlilQBALJ7QMP5bZdRZL7qx9jl/pOEx1Z5kLC2CPnT67dZ8ZhRqY8fcUDT
 bjKoQMfUIGO/eTaQCX86n2pdK4QvHcc5rTi5WWAMH7oZ3UqGJrWG2LJQAijkDfkA9BKI
 pYO+eQkmihWGBUpc0fFzcEas/9JcL2MR4udgrkD3tS+Dva2Jlrz+dMOHgnJVVJ9495GO xQ== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=T7HTRI2p8jGmYKYKwfRH3F6dgPGyUlDb3C3/CIX5pPDnFgjAis12c4DbJkwVeWYeR5R/WsHrDeCjU63WVOFatjlWeRVrb5dg992LmyR+SEZcH/fAtDXLxnbwX0C8LhyJjJmywT9479U6gP/TMucv+U8HwPAmSP/JMPY6ir+Hzo8eHLDwXOZOLsriKR9yEppz2W13dIAY+vUPZ/OvHXNjLrsZySst/DBWyCVgV1wk393K7+BmP1gTcooDbJPJJvwV+RNRWAea+a1wlOeuoGxYVabU7vj88rnwpIE07e/n6uEMBRtsAkETHgnJ/xqajCv5dlaGaRdhYiSy0pCm2ompBQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=+nO2rVtfBk9wR3DMR04tVAteK2MA3ZuQ7oyViyDcIDI=;
 b=eJ7UjF9fYf6MYMcev9J0D1H2opwgPKQpkRqYjZYovyj0aqwDVNL2CLBn+WqkHA6/solgKLQrxZ9fqZ8WAsqEdgCux9FgVNF4Wsqb93eWI73B1L8rjvNKxpVxUIjJqAFatLNtal64BYDRNOW4Jv4E0sOGnahS6NKDAYlcDBTnaU2oqdwRmDxY5rFe7HvRaGGRioxeHR946y9Phmwcd7UufMbX25j2eKYTfYCXfxcbC0KFjqCxSqmGvSHDAIu3tt+/ZV1tPro8vzJ95X4G2YLFJUxm67sh8CUL0kqkdbkODM7gRw1E34z3se3s+wGz+NIsBxjfQRau6+d62OWE6OXd8A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=+nO2rVtfBk9wR3DMR04tVAteK2MA3ZuQ7oyViyDcIDI=;
 b=WIDO5I5Oi1Atd6Raf3i6egZhe1p19jRmqLMdnPz5HcDZum3+eXSmPCsKvQZ/S5fNgdDgotue79Q9tBCsB0dD6aDeUp053r1fh6Zijm7kiFydEG06zCveIGtO4kQDUL5Hx3BMC8XH84cuiSndsLW48qtLTj0slqmZTt8NDqnHxFk=
Message-ID: <8ffd8587-7eb3-d5b6-eab0-b86df5c0ebbd@oracle.com>
Date: Thu, 24 Feb 2022 12:07:26 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.1
Subject: Re: cleanup swiotlb initialization
Content-Language: en-US
To: Christoph Hellwig <hch@lst.de>
Cc: iommu@lists.linux-foundation.org, x86@kernel.org,
        Stefano Stabellini <sstabellini@kernel.org>,
        Juergen Gross
 <jgross@suse.com>, Joerg Roedel <joro@8bytes.org>,
        David Woodhouse <dwmw2@infradead.org>,
        Lu Baolu <baolu.lu@linux.intel.com>,
        Robin Murphy <robin.murphy@arm.com>,
        linux-arm-kernel@lists.infradead.org, xen-devel@lists.xenproject.org,
        linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org,
        linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org,
        linux-s390@vger.kernel.org, linux-hyperv@vger.kernel.org,
        tboot-devel@lists.sourceforge.net, linux-pci@vger.kernel.org
References: <20220222153514.593231-1-hch@lst.de>
 <09cb4ad3-88e7-3744-b4b8-a6d745ecea9e@oracle.com>
 <20220224155854.GA30938@lst.de>
 <206ba6a3-770a-70ad-96bc-76c6380da988@oracle.com>
 <20220224163943.GA32088@lst.de>
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <20220224163943.GA32088@lst.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: BYAPR08CA0046.namprd08.prod.outlook.com
 (2603:10b6:a03:117::23) To BLAPR10MB5009.namprd10.prod.outlook.com
 (2603:10b6:208:321::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2c344323-bd09-4fec-46b3-08d9f7b828c9
X-MS-TrafficTypeDiagnostic: BYAPR10MB2933:EE_
X-Microsoft-Antispam-PRVS: 
	<BYAPR10MB293364751D244699B3F963878A3D9@BYAPR10MB2933.namprd10.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	kmiNM9QWpQj3JRvlplQEXw9n/9qemJPRczQ5h4XI1X8TxQHyezzBVC9rnADCp2fQAXXDnirGZjBwrzUFahXAvyn+ZrgRnnGA8JSlOTFJL/H8zlqul10fbhpvtAJcmkA8sb5IHqltBJzSdfZEbXEZXrcgsALNz6uL0wz/mTfoAWVTwijIR9d6xyTcHGIaPo7A2fpM4N/uGqydbJ8HWbbeAST5OfyagYqb/itokkBoo74tZG2399h1ml2KwkL2jL8yF2eO64sFOFvISf57tcEBGfQj2EC75U0TKbmZhXvGRi9SNPlM8/lDy0ZSejtGKPCm3lh+K+QbTXBaRgQGYHDn/giW54+4W1OJidcWHRiI1+JrxJHX+osAJyFn+xh/Z7zC6Z2Vm0AYphpP0hB+I4PZ/1eMmIe2ausp9TT+kFZVBoDsYs/nlZgsWqOPDu4SCwf3dl6125h/KADx/uWixUHPw0xZf1JgAPc+Va69FcDxHKc4fyLWF7zP9F+e2mGzcm55TvPiF40j5X6qOJ/j//AMkdfBWLHaOLu7sFN/FNn4KjtxUMHFuSlH+lqKWTIz27mM2YPDYrRuJoJo8b7CWj+OHWPEeFHlkZWQFGZ4+91MpaEBE1VDauQZuYBLtz5+YsKAgJD4mu4zvFw5NYHUAuBPBLcrw12d9ut06+uF1DCCLxcMDXkl1sR6gZ2iQOpzndC8n1ioPsYMOYeeeVRIY05b6QatGIfcU441X05vSGYbbtU=
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(26005)(508600001)(38100700002)(186003)(2906002)(2616005)(316002)(6486002)(31686004)(86362001)(36756003)(6666004)(53546011)(8936002)(31696002)(5660300002)(6512007)(66556008)(66476007)(8676002)(4326008)(3480700007)(66946007)(6506007)(54906003)(6916009)(7116003)(44832011)(4744005)(7416002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?SXQ2a3h3YzlVY3psR24zdC9QcUZ6TTFiRE9UUDhmRXczMEEyaG81YkY0em1H?=
 =?utf-8?B?Z2pjY05OVFJVRkluTFJ6S3hhM0ZlYVd6bXlYMlVtRCtpOUtZa243QWZIOW45?=
 =?utf-8?B?cytsS3I5UmR6VWliQ2lnWUtxZzlJZkFjbTkxMUtzcGlTc0p5Q0dYVUE4aU52?=
 =?utf-8?B?WE51WEV3Zkl0UGpObFU4MGR1MjAyR1hrMVJIeExudXRtbTRLcWZ6cXdTWjBj?=
 =?utf-8?B?RTF3OXhkcjlieklUcEZqSDRZeS9JbitvWTR3d0tOOGpjcEtVcVNXaE9NUnZs?=
 =?utf-8?B?cVBRdDNXblJJZ2tmZTRUU2NUbUh5ZWg2K1RKK0ZCWGtYa2hRSDVORStiNzds?=
 =?utf-8?B?Zll0cmdDQzlsT1VnOVNPSmQxQVJUeWpPZ0czamNqRURWOTRxTGNMRjk0SndO?=
 =?utf-8?B?Z1RRbjZFbCtSQ1kvSFh5QmNVNzNNWE9UUmF3TmxjblA4Tml1TjZVSlVteFVD?=
 =?utf-8?B?UmtJdGFkSlpUQ1ZlMW1OSkZlcXJWcTNXTkpFcXRoNDdIWTRoSkdhY0hJeEs0?=
 =?utf-8?B?Uk1Gc3B3RzhHelRWMDlBbkZDcVdkWFB6TzB1Y3RqbUVpZExEWUM1M3N3OGJl?=
 =?utf-8?B?S1BQc0Z4VlhQeHZudjdMOGxpc0RpN3dOM1RaUXg0SHFUYWFJTElyNmgyRlRD?=
 =?utf-8?B?SS9XZWxxYjY4R0lQWGhXeU5scXhGRTJWYXVNdFZsWEl1TG9BaFdjVEQzT1JU?=
 =?utf-8?B?bm1oOHQyVGlqVExLMjAxNjlTRSsvYkFwZjZhZGUrTDNCTkFlanoyUHVSb05v?=
 =?utf-8?B?NFU1bHp6dDB1ak1wL1N5bWhlWkdqc3h0Q0Z5dm9naW4rMXFEa1VXNVdnS01s?=
 =?utf-8?B?aHU4N3lsNkVBSlNrNnhtMnhJd3pwRElmVmk3bFZpbis2dU4rSENVSVBrLzFB?=
 =?utf-8?B?YzVlMXdMSVY4dS8ycjlHam5hRkh2ZFFwSEFnNTdIZGRwT1hMcGNIbkRPbFNs?=
 =?utf-8?B?SWoxbTZDelRrbWU1QlhOODRJeHJZc0hIWnJhVmhtVnhxNGxhRVMxcGc1SHJr?=
 =?utf-8?B?WEx2bEZCMlN6bStlUTBiS2tISUl4cmFYbE54SzRSWjFwVGN2czVlaisrN1lP?=
 =?utf-8?B?enB5UUgzL3NpcEE1TWRFT0dnRE5NS01OVkwxTHdFQ1Jzb3QvRUdNVUVYNGZQ?=
 =?utf-8?B?KzdaKzJ5SmlnN1dqa1h6L1ZmK0FYUUxaeU5IR0xRS1dCVktrQnB4TDdxR3dM?=
 =?utf-8?B?eFczVlRRSWZIWG5ubzNkc2VwS0xSc29oanJWVjhrN2dyNVc2a0tCbXROdlZJ?=
 =?utf-8?B?U0pCQUp0VktzNHoxTG9ubDdBRnRPWTNYb1R5dWUzOVh6TTJJUGp4UUtHbWdJ?=
 =?utf-8?B?aWVCMW9YTDFmV0F0WnM3UVVwVVRHSnBaUGx4ZFUrTXpFR1ZkRkZ6S01Fa0dD?=
 =?utf-8?B?NVBjM3h3alBHU3ViRkRSTWpubUZSODVTaWxwQmZzai9OOTFPMFJXQk01Yk14?=
 =?utf-8?B?dFJVbVowK1c5cTlQZ0cyWjNRRUQ2S3ZNZEJWQVFETGZPM1hlckROd3JpUjk4?=
 =?utf-8?B?d0JKWFUwYW1XQ1l6OEd4MVVhQWY1VVZPZi96cTVkaDlkdVYvSlRyRm1SVThN?=
 =?utf-8?B?UVBmTGE0bFZwVVA0bXc5cnJzZzZoSVRwRWY2UmluWGc4NHYyNnRuMXJwRWNO?=
 =?utf-8?B?ZlVkT1lMYm9GYzlYemdVZWF3TUFCc044OEtVQmVvYWM4Wk5FUStEV0VZUEVU?=
 =?utf-8?B?R1ZqZ1VUc0VCTHdhOURsWXVFZERiTmIxdEVnVnpOdVlJeWJFMjdUUkRqZGZr?=
 =?utf-8?B?ZjdJYUt5WEV5aGk0aHA3S3drN2FlZ0xmRzcrR0hieHJSdEd1ek0zdDhqUjgx?=
 =?utf-8?B?ai81TzFIMjlmSWJRRFFJRXdEZlQ1MDBqS2J6ZTh0c3Z1SnFiaC9yTjhha0Jq?=
 =?utf-8?B?UzFFQiszbC9mOTladHdUN0xVa09qbm9DUVRuV2RqTTFTSWNTVmQ1eDI0Y2Jr?=
 =?utf-8?B?SWk1dUN1bmY2bG5OZlJaWVE4b0puc1BMMmxYdUVKRW9qRlE1bVZkdXREYW9N?=
 =?utf-8?B?QlJxK0ltVEtuTzdTclAyVkc0UWczU2tOTHZIdHNTTytLcWF4REhOa2lXOGFE?=
 =?utf-8?B?bEZSV2p2VkhkbExtUnAwUkRiNTVqTjNya0NZRzZ5RW5HWWFrZmRLY3dxbERW?=
 =?utf-8?B?ZFhVN1dUOGVzWUFka1c3dERxUmI2MGJjYTdSaHBpbm5zVlFsQlV2TXdnejJj?=
 =?utf-8?B?bXRuaFBhZXhaVzM2czAwNS9RMmYxbjhCWEgwWDFtNEZmZDVwQmVXd0VxOWJE?=
 =?utf-8?Q?BkoLh6ytPfb1Mq2SNHtZK1OlFSwXllg8oIkRQkvJBo=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2c344323-bd09-4fec-46b3-08d9f7b828c9
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2022 17:07:38.1520
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OQhDrtunFcKjN1DE8Dow4ZY7CuAmUiIhNF7BLK4sLDan25KyIQMoygGuCDWSe0UW3is5lw+Dsq8etoGwToveJaplWJMRTMAkmSb9T/DDWXw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB2933
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10268 signatures=684655
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 spamscore=0
 mlxscore=0 adultscore=0 mlxlogscore=999 suspectscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2202240097
X-Proofpoint-ORIG-GUID: dRhxuVACkwLDmdqzFGNh1tB3chsQYZpc
X-Proofpoint-GUID: dRhxuVACkwLDmdqzFGNh1tB3chsQYZpc


On 2/24/22 11:39 AM, Christoph Hellwig wrote:
> On Thu, Feb 24, 2022 at 11:18:33AM -0500, Boris Ostrovsky wrote:
>> On 2/24/22 10:58 AM, Christoph Hellwig wrote:
>>> Thanks.
>>>
>>> This looks really strange as early_amd_iommu_init should not interact much
>>> with the changes.  I'll see if I can find a AMD system to test on.
>>
>> Just to be clear: this crashes only as dom0. Boots fine as baremetal.
> Ah.  I can gues what this might be.  On Xen the hypervisor controls the
> IOMMU and we should never end up initializing it in Linux, right?


Right, we shouldn't be in that code path.


-boris



From xen-devel-bounces@lists.xenproject.org Thu Feb 24 17:10:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 17:10:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278543.475837 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNHd8-0005w1-O2; Thu, 24 Feb 2022 17:10:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278543.475837; Thu, 24 Feb 2022 17:10:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNHd8-0005vu-KO; Thu, 24 Feb 2022 17:10:14 +0000
Received: by outflank-mailman (input) for mailman id 278543;
 Thu, 24 Feb 2022 17:10:13 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=sGkr=TH=kernel.org=patchwork-bot+netdevbpf@srs-se1.protection.inumbo.net>)
 id 1nNHd7-0005vm-Ec
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 17:10:13 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org
 [2604:1380:4641:c500::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9fec0376-9594-11ec-8eb8-a37418f5ba1a;
 Thu, 24 Feb 2022 18:10:12 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id C9E0861B7C;
 Thu, 24 Feb 2022 17:10:10 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPS id 2ACD8C340F0;
 Thu, 24 Feb 2022 17:10:10 +0000 (UTC)
Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org
 (localhost.localdomain [127.0.0.1])
 by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id
 0F611EAC09B; Thu, 24 Feb 2022 17:10:10 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9fec0376-9594-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1645722610;
	bh=rGTcIsyPfUg5jarnpPAC5c1oD8wbki17rcNUhK+rn+A=;
	h=Subject:From:Date:References:In-Reply-To:To:Cc:From;
	b=q/k7zPwArBHqe8/t+oyHeDXRSwRligPTjz43URI2HteAX66Lhn8sn2Yflw7v+9GIw
	 rd/KJNZWLi0Zwo9dH5sMGGo9QzxwssloFXHU7zL+lmW7ftHNEftNVIW2Ap1/xfcIq4
	 Z4Mw8XH7VNSoCUDI43BrvCrFSLAu5U7F+VHs2GKBOK8+V8T2/VntTwrP8PBJffKP0M
	 kF+Nj4f1quM4mfg9ewfVR1uVotEiX0R60OhpCmlCYoDskzM6CmfoAsobRutHr2Ol45
	 6lDEHtu6dWkxhDemDOZVn9SPzYAGaeCJOPmqfI3i3erpXATf/u7cGY9gDWfIAaRMBg
	 5eOoPUNZaMbqw==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: Re: [PATCH v2 1/2] Revert "xen-netback: remove 'hotplug-status' once it
 has served its purpose"
From: patchwork-bot+netdevbpf@kernel.org
Message-Id: 
 <164572261005.890.15777493366001996059.git-patchwork-notify@kernel.org>
Date: Thu, 24 Feb 2022 17:10:10 +0000
References: <20220222001817.2264967-1-marmarek@invisiblethingslab.com>
In-Reply-To: <20220222001817.2264967-1-marmarek@invisiblethingslab.com>
To: =?utf-8?q?Marek_Marczykowski-G=C3=B3recki_=3Cmarmarek=40invisiblethingslab?=@ci.codeaurora.org,
	=?utf-8?q?=2Ecom=3E?=@ci.codeaurora.org
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, mcb30@ipxe.org,
 wei.liu@kernel.org, paul@xen.org, davem@davemloft.net, kuba@kernel.org,
 xen-devel@lists.xenproject.org, netdev@vger.kernel.org

Hello:

This series was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Tue, 22 Feb 2022 01:18:16 +0100 you wrote:
> This reverts commit 1f2565780e9b7218cf92c7630130e82dcc0fe9c2.
> 
> The 'hotplug-status' node should not be removed as long as the vif
> device remains configured. Otherwise the xen-netback would wait for
> re-running the network script even if it was already called (in case of
> the frontent re-connecting). But also, it _should_ be removed when the
> vif device is destroyed (for example when unbinding the driver) -
> otherwise hotplug script would not configure the device whenever it
> re-appear.
> 
> [...]

Here is the summary with links:
  - [v2,1/2] Revert "xen-netback: remove 'hotplug-status' once it has served its purpose"
    https://git.kernel.org/netdev/net/c/0f4558ae9187
  - [v2,2/2] Revert "xen-netback: Check for hotplug-status existence before watching"
    https://git.kernel.org/netdev/net/c/e8240addd0a3

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html




From xen-devel-bounces@lists.xenproject.org Thu Feb 24 17:31:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 17:31:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278550.475848 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNHxa-0008PV-Gi; Thu, 24 Feb 2022 17:31:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278550.475848; Thu, 24 Feb 2022 17:31:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNHxa-0008PO-Di; Thu, 24 Feb 2022 17:31:22 +0000
Received: by outflank-mailman (input) for mailman id 278550;
 Thu, 24 Feb 2022 17:31:21 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nNHxZ-0008PI-Kv
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 17:31:21 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nNHxZ-0002tn-1v; Thu, 24 Feb 2022 17:31:21 +0000
Received: from 54-240-197-225.amazon.com ([54.240.197.225] helo=[10.7.239.15])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nNHxY-0008Ky-Sa; Thu, 24 Feb 2022 17:31:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=ojvJAQ1tcL/hurWNURfex0LQ6xzJ51lAC+TUn+DhejM=; b=c0v+qPBRBr0lf/5/tzJ+wSrqvZ
	y/L4CbzB8Ghuya2d5SHQqai14DR3rGrjj6logUEGHW3w0ZSytJJYeIlc0WlQK+8tMGJ790XoUev3n
	lTkz5mo8x/gGVqq5hPZ/PCEUgNerUuv+wpDOqQkhbEPKsK2ozjFOcWXAVFpApSNG/q1c=;
Message-ID: <9bc0efe0-cf2c-1146-854f-300578412ff7@xen.org>
Date: Thu, 24 Feb 2022 17:31:19 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.1
Subject: Re: [PATCH v2] xen/mm: pg_offlined can be defined as bool in
 free_heap_pages()
To: Andrew Cooper <Andrew.Cooper3@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Julien Grall <jgrall@amazon.com>
References: <20220223190833.24710-1-julien@xen.org>
 <27fd5c5f-591c-42c4-abed-95a9e5829d56@citrix.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <27fd5c5f-591c-42c4-abed-95a9e5829d56@citrix.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Andrew,

On 23/02/2022 19:38, Andrew Cooper wrote:
> On 23/02/2022 19:08, Julien Grall wrote:
>> From: Julien Grall <jgrall@amazon.com>
>>
>> The local variable pg_offlined in free_heap_pages() can only take two
>> values. So switch it to a bool.
>>
>> Signed-off-by: Julien Grall <jgrall@amazon.com>
> 
> I'd argue this might want to go as far as declaring Fixes: 289610483fc43
> which really did introduce one bool pg_offlined and one unsigned int
> pg_offlined which were the same thing.

I am OK with that. I will add it while committing the patch.

> 
> Either way, Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>

Thanks!

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Feb 24 17:40:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 17:40:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278559.475860 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNI60-0001Aq-H2; Thu, 24 Feb 2022 17:40:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278559.475860; Thu, 24 Feb 2022 17:40:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNI60-0001Aj-Ct; Thu, 24 Feb 2022 17:40:04 +0000
Received: by outflank-mailman (input) for mailman id 278559;
 Thu, 24 Feb 2022 17:40:02 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=oTFz=TH=citrix.com=prvs=047b345d9=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nNI5y-0000o8-JF
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 17:40:02 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c935afb9-9598-11ec-8eb8-a37418f5ba1a;
 Thu, 24 Feb 2022 18:40:00 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c935afb9-9598-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645724400;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=ho9uvsjSBrvHeOUTDVh9znup132sGvMrXoNo/3/hFJw=;
  b=YhJ3wg/1j3+h88fuHOkUcHt/E1PVCokQeJIGq2RbX1K0zlZNsYBfenby
   sz5enUpeTXZbk5KDjHGM4IbHcvxtMYfAasrXaLo+DqTZ8yOXn53daG3oP
   8niS1nEtxN79NbL7ogzBl/RVRaaxqNL8STcNB9gEMBmZ90o54eCc3wzYW
   s=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 64363116
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:38e7/a4P/89H1e4X1pU99AxRtCrHchMFZxGqfqrLsTDasY5as4F+v
 mIYUGqDb/mKMTTxKo9yPNmy/R5VsJLSzoM1SFZprHhnHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0XqPp8Zj2tQy2YLjX1vW0
 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X
 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx
 umhurSXEgIQPJHyp9hHShdIQyU9L/Zt3LvYdC3XXcy7lyUqclPpyvRqSko3IZcZ6qB8BmQmG
 f4wcW5XKErZ3qTvnez9GrIEascLdaEHOKs2vH16wC6fJvEhWZ3ZGI3B5MNC3Sd2jcdLdRrbT
 5RFMmQ0NU2eC/FJEmwzAaM7ocuCvVnyLCRRt0PSvqcuwmeGmWSd15CyaYGIK7RmX/59gUKwt
 m/AuWPjDXkyJNGZjDaI7H+oruvOhj/gHpIfEqWi8fxni0HVwXYcYDUUX1ampfiyimalRslSb
 UcT/0ITQbMarRLxCIOnBlvh/SDC7kV0t8ds//MSz1qI86jo3TmlXHEKXm5FK859n+syWml/v
 rOWpO/BCTtqubyTbHuS8LaIsD+/URQowX8+iTwsFlVcvYS6yG0npleWF4s4Tvbp5jHgMWyom
 1i3QD4Ca6L/ZCLh/4Gy5hj5jj2lvfAlpSZlt1yMDgpJAu6UDbNJhrBEC3CGtZ6sz67DFzFtW
 UTofeDEsoji6rnXyUSwrB0lRu3B2hp8GGS0baRTN5cg7S+x3HWoYJpd5jpzTG8wbJpZJ2OzP
 BWI5lsKjHO2AJdMRfUpC25WI553pZUM6Py/DqyEBjawSsIZmPC7ENFGOhfLgjGFfLkEmqAjI
 5aLGftA/l5BYZmLOAGeHr9HuZdyn3hW7TqKGfjTkkT2uZLDNSX9YepUbzOzghURsfrsTPP9q
 I0EaaNnCnx3DYXDX8Ug2dRNdQtTdSBjX/gbaaV/L4a+H+avI0l4Y9f5yrI9YY112aNTk+bD5
 HamXUFEjlH4gBX6xc+iMxiPtJuHsU5DkE8G
IronPort-HdrOrdr: A9a23:mjlBBK/XYxG9HENtLktuk+F2db1zdoMgy1knxilNoENuHfBwxv
 rDoB1E73LJYW4qKQwdcdDpAtjkfZtFnaQFrrX5To3SIDUO31HYYr2KjLGSjwEIfheRygcz79
 YYT0ETMqySMbE+t7eB3ODaKadg/DDkytHRuQ629R4EJmsKC52IrT0JcTpzencGHzWubqBJcK
 Z0k/A3wQZIDk5nCfhTaEN1PdTrlpnurtbLcBQGDxko5E2lljWz8oP3FBCew1M3Ty5P6a1Kyx
 mEryXJooGY992rwB7V0GHeq75MnsH699dFDMuQzuAINzTXjBqybogJYczAgNl1mpDs1L8Zqq
 iJn/4SBbU115oXRBDynfLZ4Xik7N/p0Q669bbXuwq6nSWzfkNENyMIv/MmTvKe0Tt7gDg06t
 M644rS3aAnfC/ojWDz4cPFWAptkVfxqX0+kfQLh3gaSocGbqRNxLZvt3+9Pa1wVR4S0rpXWN
 WGzfuskMp+YBefdTTUr2NvyNujUjA6GQqHWFELvoiQ3yJNlH50wkMEzIhH901wua4VWt1B/a
 DJI65onLZBQosfar98Hv4IRY+yBnbWSRzBPWqOKRDsFb0BOXjKt5nriY9Frt2CadgN1t8/iZ
 7BWFRXuSo7fF/vE9SH2NlR/hXEUAyGLELQIwFllu9EU5HHNcjW2He4OSMTeuOb0oAiPvE=
X-IronPort-AV: E=Sophos;i="5.90,134,1643691600"; 
   d="scan'208";a="64363116"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=mP+58IS9lKmMoz1Zq3I4JLjIdKgWZ6E81j8iW5nhWK8PgEe3gZ2GJHDPFMXKeJZ8R1CLD0WHW7THvsM5bu5iuLye26rcZe7S+Gq28ALj667MpZwmgzO7vu+cjLFejJsnPqTyU7fa6IlFKd6VvSTmTuxRMTNoAewxFsHTWhK5oU3pxlfmIg+Z6VyO94ZQgOGY9XwVc8OjJpi+wqRt5E/+fXVPMxnpDCp9Y7pXBYdb/7I1dXgigA+jf/Y1ZUs0Jp5oIPE0IM+tEC5YFPx5qjJMoG24sZ8+rqKCMp4HqWQxpmNIkt8YbIaIFd9YvUZlaMSXa8KHS78oC1/zPyCkp3I6eg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ho9uvsjSBrvHeOUTDVh9znup132sGvMrXoNo/3/hFJw=;
 b=TzbFthydbEX5QvzkPDrIAiUNKke42bT38nAgv4bbiwBbm/E6k4HTmF3rkmOvy+y9TloZN/hV1LRftFkoR0Rdm7nXyTKDbz0rpa7ec29W3rYlY/6wlr0sEHEv82Pp0lWqzVinxGxHHtvsCMS+CY1CUqHuy3ZrSFfF+uE1UIxLX+TExjSMYmK7py21Xo5MAIsIYGuyeLg1rtbEtHYw5WN+5H91vcrcev2AA8prQpQ+B4IyXPjHMc74E4OCbGjH1nCu3DxzQTnq9GXKoYKtIXC46n3EJw/LUNVsp1GRhkcD8esa4gafmsBfW2PbTST9S5iwdOi4TZiKJltRt95NbAA7Fg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ho9uvsjSBrvHeOUTDVh9znup132sGvMrXoNo/3/hFJw=;
 b=vhIQ7VPEW+GntZssDeDdIomcJd7L60IQ1s9JKrWCFAzMHUgq9VLl4GYsV2pmfH8PP/8PH7y2gZR93xOFSST3kj4tXGFlRJpSgSQ38WpRkgzNvovBKRgwKEwZvQOVUbnLHm8l2yq54QigGTpgCSICo5O1cus8Ct824KMVOhncTqU=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Wei Liu <wl@xen.org>, Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: Ping: [PATCH v2] x86/time: switch platform timer hooks to altcall
Thread-Topic: Ping: [PATCH v2] x86/time: switch platform timer hooks to
 altcall
Thread-Index: AQHYCH/zSGV6zWhCDUW+2oPSoHYB06yi0XUAgABomoA=
Date: Thu, 24 Feb 2022 17:39:54 +0000
Message-ID: <822a757b-a9a3-e677-4cc4-3879125f9f24@citrix.com>
References: <5f1f49e6-1380-73bf-d68f-6eb9dd05cad6@suse.com>
 <68d40be4-9ced-01bf-8bc3-585f11827504@suse.com>
In-Reply-To: <68d40be4-9ced-01bf-8bc3-585f11827504@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: a637f285-0574-4776-10aa-08d9f7bcaaf0
x-ms-traffictypediagnostic: CY4PR03MB3333:EE_
x-microsoft-antispam-prvs: <CY4PR03MB3333CC298E9659423F2B55D5BA3D9@CY4PR03MB3333.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: Jdsp4dC67PiLIDYn/ggH223uXqeTlYc7XJAd0L64zlcTuUhmasaJ5fJnDjb2Wxk+pyFpMd7BBZj8+QbqCxueThG/JQFuBTsbKuLL3mFLr24GL6bccL35X6j8lUwk2/kT29ghqUnoCqTczxAj11PgwPbe9jWst0yVCc+clR2zd3iAEzmmnfx6LcXsyKHeJSLgA3yxeCbMv+BZmlFXdecjra8Dv4UJCtKlb6Ule5JWJ0JOwsy+T40yQJm4UUNYuNd4T2wAAcH9FURli+lebHw9kk6ptxOi5BeiLVNIKv0A0Q9d43y3q21KaX95iNDrmvtLqIW3Xip27MQs/jJScg+X2V89dAIkJr4hCD2scJVnJS40xSzLre6t77vipLaaHKqazkmmdPphoTVlqqgodZxLY3Os/Utark4JFxHDPshs40XO82MxtoiChB46z16rgRNd7yJuCBb5zGTXLT2VL7c1XqDBgx12lDc+RK6Z1F0vua+lDz1eqS09AY22P+sf9bSnQDDOZ1zLuGjhOWDSwjnPNLyob5nO5NJUx2sSh7WNThGgGdJUkPP25EQe+mTIJZggBPUsE5kyAp9vX0/7giJAOjg8eW+yiAKyTl/w7ljU1prFJt6b6uDgx7+OXggWe1ODPRZc1gTL0eDfeKrPumftBCuEASvoovcvQUidiCuQWarH+ObeVWsaaC9O8ZO6E56LOk+xGKydzPT2zqlXvamCQe6A/rOOQzQO5ooM7n4CWBfY6yU5PG11J/90Dv2tnGiuTdOq/C9DNp9xE5tzWJ9s4g==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66476007)(91956017)(8936002)(4326008)(8676002)(66446008)(64756008)(76116006)(66946007)(107886003)(31696002)(66556008)(38100700002)(122000001)(5660300002)(26005)(2906002)(82960400001)(31686004)(36756003)(2616005)(316002)(71200400001)(6512007)(83380400001)(186003)(38070700005)(6506007)(54906003)(6486002)(508600001)(86362001)(53546011)(110136005)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?eUNOV3EvOGVJVWtTUVhhK3F6YnBTeXVEbEdxUDFvTlcva2ZsRSt5eW9ibisr?=
 =?utf-8?B?eE1hSEhud2dwRWNxY210aXlxSlBoWUlTRlBpWmJVR3VrNUU2d2dyaDF4WWFo?=
 =?utf-8?B?dStwaUI0L09qcEcrWDE3aWZFTFVGSHo2ZmQwME9DUlZ6dHdMNHVtWDY2dktP?=
 =?utf-8?B?K0VzdUc1dXJ2MlgyeCtNNjRGQnBBckphSDhxVU1tWEhLQTdUdnpQbE9ZRUNK?=
 =?utf-8?B?dTh6bCtSVGJDN3JmYTQzUTB6NUlaaU8zelB6OE83R0ZXTlR2Q3diQnZtQjlO?=
 =?utf-8?B?aXlKQWVVdGtJZTA1Qkl1Qkt6c01GdXlZWnVMRWZOU0tYUGFONzhkbWtCT21Z?=
 =?utf-8?B?NXlJanlaTHgwMVorYjFhaUVxbDk2aDlFcjR4TjJrS01CaVcxenRUYkxhRUNs?=
 =?utf-8?B?cVVXWllOTG1GQnowZkw2RXVWTnJNKzY1ZnNVYWhtTUUxNlNadWZxUTNpcStM?=
 =?utf-8?B?WHJxTUNTTjdrSHRuMjlubW5mR0VmVjNzK1ZWVVZ4YkZIUm1QdDNEalVjN2Zq?=
 =?utf-8?B?U0NTQjRKSWRqRmJGSkJHdXplQi9LMVJlSWtCb2tFSjJ1ZmIzOC9ycDR2L1gv?=
 =?utf-8?B?SDhCN3Q4WmZndkFNeUUwSHpGOFZldmtoSlU4OGVqVmFWMW04NHU1NVdlY3lO?=
 =?utf-8?B?VDVjWU1wUVBESW9EaDFMVzNSN0szaVUvWjA4TFI3SmZQNVVSTGYzdHZsMnNZ?=
 =?utf-8?B?K1p4a29MZjdZLzhCSEl5TElUWVBSNFIrL1dDZ0d2TUVnNklZRXlmbHFyQ1lS?=
 =?utf-8?B?UmVMTmVZbTNqTjdQeDIzVW93Y1VSbUxhY2VDbzd0eHdha0h3enhOV1hzR0JD?=
 =?utf-8?B?aCtYNHhBRXlncGtVUHdBR3BnNGpySzRhQmZYYXBQNitkVnpzSmZ2UlNwSWpF?=
 =?utf-8?B?L2kyS2pYOFgzWnNkS2FpUkIzTVRTWTErYzZBTTZZeU5sL0JGSVNpWUsvemlD?=
 =?utf-8?B?K2NvbHRqRmk1MmltcWduL0xFYnpRTU92VmV5ektNRzkwckR6LzZsNnNlWWZQ?=
 =?utf-8?B?ckRhM1RxQkgyWFhMU0o0QzNXblZEaDQ4YlFqRkdxRE1odkdWakttTjFoVkdU?=
 =?utf-8?B?K1pDT3AvZUlkc2hhZUd5YjFrYzdtMTFUV2c1S0VEcVhZNEgrTEZ2VDBQaEJJ?=
 =?utf-8?B?cTBLWGQxV1QxQ3lBRUlBckJBUlFOQ0V5OUxzS3dkR2hjanZIRysrOFBNNGJs?=
 =?utf-8?B?RkZ5aGlIbWJkM1dxZFZWb3NkQXMzZU1QdjdmQzlXMi8wU3ZiNnM0Y1RkQ000?=
 =?utf-8?B?eVRuOE5KVE92QXZTNzVtUmNJQVVEek5FSmt5bzFTMDFtTWRIVGd2cmtHdlQw?=
 =?utf-8?B?Q1NLSkhMUTkxMEVvM2R4YXRyd1RyaEtwZ3BWRTZoaEJRbVFjOTlxd3d4U09r?=
 =?utf-8?B?QVNrcEtQZTVIMDJTRG83QThka2tYNEl2U2NDR2dqQTNYdnFNdHRZREhOV3hO?=
 =?utf-8?B?VFYwMFk0aXQ3by9xeHFKcWMzTWVueUNTakliRWNoMjAySnlXcmVvYmQ5UGxW?=
 =?utf-8?B?Kyt5aXdaUGo4VnhXZ3FwOVVGUkdsSHJOcG5XaHNDb1krc21paU5Ra1VESTBT?=
 =?utf-8?B?ODFFaTFDS3d0U1o5RkNtVjFmODVmbkFuakhFcDVSSVhkNFJhVjRJaHdobnlU?=
 =?utf-8?B?ZEFMak5tTHVPdTNodEpUK0tVUkRQd1o4NUJGZHhydWx2YXMwKy9lVlZtNUpt?=
 =?utf-8?B?eFBMSjZRai9mOXVQT3NYNUZqR1Y0WjJaZ05KaS9ESTIrNmhaTDJSK0FOWDE5?=
 =?utf-8?B?YXVaNWs1d280WFZxT0swd0ppYmN5Q0tYUmZpdUpXcjBrU1RzTW1EMlN1dkxj?=
 =?utf-8?B?US9Oc2N4RUg3d1BUcTR0ZlVBMEdHaFVJRVFNY2l0Q3dxTTczYjFTSkFpSlhm?=
 =?utf-8?B?V2MyWm5ZRmJjOEdiL3VSK1E1K1ZOeW5ZVE1IVHcvaXIwUDJjN3ZSdjJKRzBV?=
 =?utf-8?B?YncxelprendUc2k2SFdnY0JPcHgrS0ZJUldXRkNRbUxtclE5OW4rUFo3Ym14?=
 =?utf-8?B?NjREdmw1ZzRVRFhUQlRyU2hiNmNUZUxyQVo1Z1RzZE5OakJJUGVHMS9IRDlG?=
 =?utf-8?B?aC9XRnNJTW1zam4wMnVUdDNSaXFMWHFZNEhDWWJEb1Fnc0JMbDQ1eUFacVE2?=
 =?utf-8?B?V1YrcjVMVENLdlZTUEVaWnpEeGRnTUFLdmMyaGpISDBUSWFzZU1hcTM1ZmdC?=
 =?utf-8?B?eFkzaTVFV3RvMlIrZjVCVmlNVDRpKzBlMkxONlZqTGhPZHIvUG5nSXdMN0NY?=
 =?utf-8?B?eGhocmFQMTNONHhDbzIrL01LbmJRPT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <1EAE667346C5164CAA81E8EBAC2B3AA1@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a637f285-0574-4776-10aa-08d9f7bcaaf0
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Feb 2022 17:39:54.2314
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: MwdWDWEr1TS8ykP4EWTNmuZNYv9xszSlLcwMEBZi9OBLTbqdycjyLCG3gpvV7lbaAfHolAHx1apKyl7IHtTmbJvs7/7R3doD3B3iP/H4xlU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR03MB3333
X-OriginatorOrg: citrix.com

T24gMjQvMDIvMjAyMiAxMToyNSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDEzLjAxLjIwMjIg
MTQ6MTcsIEphbiBCZXVsaWNoIHdyb3RlOg0KPj4gRXhjZXB0IGluIHRoZSAiY2xvY2tzb3VyY2U9
dHNjIiBjYXNlIHdlIGNhbiByZXBsYWNlIHRoZSBpbmRpcmVjdCBjYWxscw0KPj4gaW52b2x2ZWQg
aW4gYWNjZXNzaW5nIHRoZSBwbGF0Zm9ybSB0aW1lcnMgYnkgZGlyZWN0IG9uZXMsIGFzIHRoZXkg
Z2V0DQo+PiBlc3RhYmxpc2hlZCBvbmNlIGFuZCBuZXZlciBjaGFuZ2VkLiBUbyBhbHNvIGNvdmVy
IHRoZSAidHNjIiBjYXNlLCBpbnZva2UNCj4+IHdoYXQgcmVhZF90c2MoKSByZXNvbHZlcyB0byBk
aXJlY3RseS4gSW4gdHVybiByZWFkX3RzYygpIHRoZW4gYmVjb21lcw0KPj4gdW5yZWFjaGFibGUg
YW5kIGhlbmNlIGNhbiBtb3ZlIHRvIC5pbml0LiouDQo+Pg0KPj4gU2lnbmVkLW9mZi1ieTogSmFu
IEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KPiBBcyB0aGlzIGFjdHVhbGx5IGFtZW5kcyB0
aGUgSUJUIHdvcmssIEkgd291bGQgaGF2ZSBob3BlZCBmb3IgaXQgdG8gYmUNCj4gdmlld2VkIGFz
IHVzZWZ1bC4NCg0KU29ycnkgLSBpdCBmZWxsIHRocm91Z2ggdGhlIGNyYWNrcy7CoCBEZWZpbml0
ZWx5IHVzZWZ1bC4NCg0KPiAgT2YgY291cnNlIGlmIGFjY2VwdGVkIGluIGdlbmVyYWwsIGl0IHdv
dWxkIG5vdyB3YW50DQo+IHRvIGhhdmUgX19pbml0Y29uc3RfY2ZfY2xvYmJlciBhbm5vdGF0aW9u
IGFkZGl0aW9uIGluY2x1ZGVkLiBBbGJlaXQNCj4gdGhlcmUncyBhIHNsaWdodCBjb21wbGljYXRp
b246IFNvbWUgb2YgdGhlIHN0cnVjdHVyZXMgYXJlIHdyaXR0ZW4gdG8sDQo+IHNvIHRob3NlIGNv
dWxkbid0IHJlYWxseSBiZSAiY29uc3QiLg0KDQpUaGUgLmluaXQuY2ZfY2xvYmJlciBzZWN0aW9u
IG5lZWRzIHRvIGNvbnRhaW5lciBhIHBvaW50ZXIgdG8gZXZlcnkNCnRhcmdldCBmdW5jdGlvbi7C
oCBGb3IgdGhlIGN1cnJlbnQgb3BzIHN0cnVjdHVyZXMsIHdlIGp1c3QgcHV0IHRoZSB3aG9sZQ0K
b3BzIHN0cnVjdHVyZSBpbi4NCg0KRm9yIGluZGl2aWR1YWwgZnVuY3Rpb25zLCB0aGUgYmVzdCBw
bGFuIEkgY291bGQgY29tZSB1cCB3aXRoIHdhcyBhIG1hY3JvDQp3aGljaCBlbWl0czoNCg0KLnB1
c2hzZWN0aW9uIC5pbml0LmNmX2Nsb2JiZXIsIGEsIEBwcm9nYml0cw0KLnF1YWQgZm4NCi5wb3Bz
ZWN0aW9uDQoNCndyYXBwZWQgdXAgaW4gI2RlZmluZSBjZl9jbG9iYmVyKGZuKSwgc28gdGhlIGVu
ZCBjb2RlIHJlc3VsdCBvdWdodCB0bw0KbG9vayBsaWtlOg0KDQpzdGF0aWMgdm9pZCBmb28ocGFy
YW0gKmJhcikNCnsNCsKgwqDCoCAuLi4NCn0NCmNmX2Nsb2JiZXIoZm9vKTsNCg0Kc2ltaWxhciB0
byBjb21tYW5kIGxpbmUgcGFyYW1ldGVycy4NCg0KDQpUaGF0IHNhaWQsIGluIHRoaXMgY2FzZSwg
Y2FuJ3Qgd2UgY2ZfY2xvYmJlciBlYWNoIHBsYXRmb3JtX3RpbWVzb3VyY2UgP8KgDQpJdCB3b3Vs
ZCByZXF1aXJlIGFsdGNhbGwoKWluZyB0aGUgcmVzdW1lIGhvb2sgdG9vLsKgICh0aGUgaW5pdCBo
b29rIHdvbid0DQptYXR0ZXIgZWl0aGVyIHdheS4pDQoNCn5BbmRyZXcNCg==


From xen-devel-bounces@lists.xenproject.org Thu Feb 24 17:50:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 17:50:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278567.475874 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNIFu-000314-FL; Thu, 24 Feb 2022 17:50:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278567.475874; Thu, 24 Feb 2022 17:50:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNIFu-00030x-CR; Thu, 24 Feb 2022 17:50:18 +0000
Received: by outflank-mailman (input) for mailman id 278567;
 Thu, 24 Feb 2022 17:50:17 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3iZV=TH=tklengyel.com=tamas@srs-se1.protection.inumbo.net>)
 id 1nNIFs-00030r-Ug
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 17:50:17 +0000
Received: from MTA-15-3.privateemail.com (mta-15-3.privateemail.com
 [198.54.122.111]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 380e5372-959a-11ec-8539-5f4723681683;
 Thu, 24 Feb 2022 18:50:15 +0100 (CET)
Received: from mta-15.privateemail.com (localhost [127.0.0.1])
 by mta-15.privateemail.com (Postfix) with ESMTP id B6C0F18000A9
 for <xen-devel@lists.xenproject.org>; Thu, 24 Feb 2022 12:50:12 -0500 (EST)
Received: from mail-yw1-f174.google.com (unknown [10.20.151.146])
 by mta-15.privateemail.com (Postfix) with ESMTPA id 9C59F18000A0
 for <xen-devel@lists.xenproject.org>; Thu, 24 Feb 2022 12:50:12 -0500 (EST)
Received: by mail-yw1-f174.google.com with SMTP id
 00721157ae682-2d68d519a33so6300707b3.7
 for <xen-devel@lists.xenproject.org>; Thu, 24 Feb 2022 09:50:12 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 380e5372-959a-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=tklengyel.com;
	s=default; t=1645725012;
	bh=RXVQdrq2wUyMpcgS/RMTl3KIG9GiTKXPRfJu6KrbQaU=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=Mltc914Mt+i+Wb/H7eQQxGeB8qerwogCD/jtCgLd7yp/+SXxuKWZ6zQ3O1PROWoRg
	 lLwzHgJefdhk+iukpDCMrqYs45IuU7tDrzAmEcC3YI1brFdgxY2cOaH0ixyIdPNm6s
	 BtFWAC2q9DUTSbs0G+oBkenP6INobGMAF9leW0N/+o5zjmjjRUlynEXg0TIY6MdknC
	 R6p80RA8vR3ioUVjE41C7MYpiSABfd9gQwpciIHz3hAb4buXGV2hri2Ews++7eHIS1
	 glXapr/f193GpbCRbARnpai9Iy7g+esY5YJ2HmRrkiiL0oICWo964UHuGb2u8vlruN
	 eWPAkpQOnkuLw==
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=tklengyel.com;
	s=default; t=1645725012;
	bh=RXVQdrq2wUyMpcgS/RMTl3KIG9GiTKXPRfJu6KrbQaU=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=Mltc914Mt+i+Wb/H7eQQxGeB8qerwogCD/jtCgLd7yp/+SXxuKWZ6zQ3O1PROWoRg
	 lLwzHgJefdhk+iukpDCMrqYs45IuU7tDrzAmEcC3YI1brFdgxY2cOaH0ixyIdPNm6s
	 BtFWAC2q9DUTSbs0G+oBkenP6INobGMAF9leW0N/+o5zjmjjRUlynEXg0TIY6MdknC
	 R6p80RA8vR3ioUVjE41C7MYpiSABfd9gQwpciIHz3hAb4buXGV2hri2Ews++7eHIS1
	 glXapr/f193GpbCRbARnpai9Iy7g+esY5YJ2HmRrkiiL0oICWo964UHuGb2u8vlruN
	 eWPAkpQOnkuLw==
X-Gm-Message-State: AOAM532OB973dTUYeUE4Cj2ItmBBKAV6rDvxDUkzDQ90SWL5SNY/2woo
	KcDnaSWopNZ4BemzoLRlbFe3z5DhyvJYdDj0BsU=
X-Google-Smtp-Source: ABdhPJycN7lO/x0oZeO235pGTY2qapXOC8hzfekxT/sFCyUfa9HJvC+fDgA+Ejqk3ZMc+8lsXzke3Cmd9iEfJ/hwnLo=
X-Received: by 2002:a81:9858:0:b0:2d6:ecb0:71b7 with SMTP id
 p85-20020a819858000000b002d6ecb071b7mr3599506ywg.507.1645725011811; Thu, 24
 Feb 2022 09:50:11 -0800 (PST)
MIME-Version: 1.0
References: <b3564fe0-e375-b386-df0d-a5c2b54d1299@suse.com> <30592690-ee08-1886-b6ba-b3309659d29c@suse.com>
In-Reply-To: <30592690-ee08-1886-b6ba-b3309659d29c@suse.com>
From: Tamas K Lengyel <tamas@tklengyel.com>
Date: Thu, 24 Feb 2022 12:49:36 -0500
X-Gmail-Original-Message-ID: <CABfawhnSpBK+uSSvqa4QODx5CNjC3Z8_Y+Skie0Bv9_B9jz1qw@mail.gmail.com>
Message-ID: <CABfawhnSpBK+uSSvqa4QODx5CNjC3Z8_Y+Skie0Bv9_B9jz1qw@mail.gmail.com>
Subject: Re: Ping: [PATCH v4] x86/altp2m: p2m_altp2m_propagate_change() should
 honor present page order
To: Jan Beulich <JBeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Petre Pircalabu <ppircalabu@bitdefender.com>, 
	Alexandru Isaila <aisaila@bitdefender.com>, George Dunlap <george.dunlap@citrix.com>, 
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Content-Type: text/plain; charset="UTF-8"
X-Virus-Scanned: ClamAV using ClamSMTP

On Thu, Feb 24, 2022 at 8:10 AM Jan Beulich <jbeulich@suse.com> wrote:
>
> On 03.02.2022 14:57, Jan Beulich wrote:
> > For higher order mappings the comparison against p2m->min_remapped_gfn
> > needs to take the upper bound of the covered GFN range into account, not
> > just the base GFN. Otherwise, i.e. when dropping a mapping overlapping
> > the remapped range but the base GFN outside of that range, an altp2m may
> > wrongly not get reset.
> >
> > Note that there's no need to call get_gfn_type_access() ahead of the
> > check against the remapped range boundaries: None of its outputs are
> > needed earlier, and p2m_reset_altp2m() doesn't require the lock to be
> > held. In fact this avoids a latent lock order violation: With per-GFN
> > locking p2m_reset_altp2m() not only doesn't require the GFN lock to be
> > held, but holding such a lock would actually not be allowed, as the
> > function acquires a P2M lock.
> >
> > Local variables are moved into the more narrow scope (one is deleted
> > altogether) to help see their actual life ranges.
> >
> > Signed-off-by: Jan Beulich <jbeulich@suse.com>
> > ---
> > Note that this addresses only half of the problem: get_gfn_type_access()
> > would also need invoking for all of the involved GFNs, not just the 1st
> > one.
> > ---
> > v4: Restore mistakenly dropped mfn_eq(mfn, INVALID_MFN).
>
> I think this was the only open item I needed to deal with. Any chance
> I could get an ack or R-b here, please?
>
> Thanks, Jan

Reviewed-by: Tamas K Lengyel <tamas@tklengyel.com>


From xen-devel-bounces@lists.xenproject.org Thu Feb 24 18:54:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 18:54:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278575.475886 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNJFQ-0000mF-1L; Thu, 24 Feb 2022 18:53:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278575.475886; Thu, 24 Feb 2022 18:53:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNJFP-0000m8-U8; Thu, 24 Feb 2022 18:53:51 +0000
Received: by outflank-mailman (input) for mailman id 278575;
 Thu, 24 Feb 2022 18:53:50 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nNJFO-0000ls-9F; Thu, 24 Feb 2022 18:53:50 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nNJFO-0004Kt-67; Thu, 24 Feb 2022 18:53:50 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nNJFN-0003MQ-OQ; Thu, 24 Feb 2022 18:53:49 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nNJFN-0000sO-O0; Thu, 24 Feb 2022 18:53:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=q/TR3AX68X39ZyFERWncpiWYy/rFjAZuxv55H0OlzZo=; b=slURYhQ7tLoXHkCVeXMB97Nsl7
	t2ZLBv3x/87AyeRX+2KmoACcbAr3X+VQxx9ez5xw/AWEcBUyUErRfItjUIf6c8YsS3txBYfe580bO
	eB3ixFHoCwuptYMzfFUlK/jpsX5RR2QW6+5pIrArIDnwT0Ovpa0OcvolWPaq0R/Zv3BI=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168214-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 168214: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-dom0pvh-xl-intel:guest-localmigrate/x10:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=fe60fab0424b93c6688d285bd7995226a96937d4
X-Osstest-Versions-That:
    xen=f04231775c179b3424fca45d64f29e226a41a610
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 24 Feb 2022 18:53:49 +0000

flight 168214 xen-unstable real [real]
flight 168219 xen-unstable real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/168214/
http://logs.test-lab.xenproject.org/osstest/logs/168219/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-dom0pvh-xl-intel 20 guest-localmigrate/x10 fail pass in 168219-retest
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 168219-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10       fail  like 168211
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168211
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168211
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168211
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168211
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168211
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168211
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168211
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168211
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168211
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168211
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168211
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168211
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  fe60fab0424b93c6688d285bd7995226a96937d4
baseline version:
 xen                  f04231775c179b3424fca45d64f29e226a41a610

Last test of basis   168211  2022-02-23 21:07:13 Z    0 days
Testing same since   168214  2022-02-24 08:49:26 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            fail    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   f04231775c..fe60fab042  fe60fab0424b93c6688d285bd7995226a96937d4 -> master


From xen-devel-bounces@lists.xenproject.org Thu Feb 24 19:49:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 19:49:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278590.475901 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNK6v-00068r-H6; Thu, 24 Feb 2022 19:49:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278590.475901; Thu, 24 Feb 2022 19:49:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNK6v-00068k-DJ; Thu, 24 Feb 2022 19:49:09 +0000
Received: by outflank-mailman (input) for mailman id 278590;
 Thu, 24 Feb 2022 19:49:08 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=oTFz=TH=citrix.com=prvs=047b345d9=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nNK6u-00068W-JH
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 19:49:08 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d2a6a649-95aa-11ec-8eb8-a37418f5ba1a;
 Thu, 24 Feb 2022 20:49:06 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d2a6a649-95aa-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645732146;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=Bg09nIB9t3NNShfGM6r18m+esMd6e6YTAaEyvnpHPUU=;
  b=eNCBYk9mY+IHLtpKp5nKUMvHZVVgfmNQTLt5LgiIGGybciCmMvPa3Zsd
   HC0oGHk1HnO75ADUo6N9lY4qXWUVdunDKGpYeZ39TlP8eDQyrxfeidQCc
   O9QZoe1otm46PorekbekWoIjrxAGJcWe731MvBgTNUOscg90DASWw4Cqj
   o=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 64830769
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:DtmAGKPuofaQxOvvrR2Zl8FynXyQoLVcMsEvi/4bfWQNrUoj0zRWz
 jccD2uHOa2CMDTwfowgYI3n/EJXu5SDytcyTQto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFcMpBsJ00o5wbZj2NIw2rBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zl
 fNclbrrRSQTAvPPnN03a0Z4AgRSIvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALBc/nJo4A/FpnyinUF60OSpHfWaTao9Rf2V/cg+gQQaaFP
 5VHOFKDajzvXSFXfWdOWasct/eShj7iQ21Uo0qK8P9fD2/7k1UqjemF3MDuUtiNSsJYhFqYp
 2TL5T3RW09BcteYzFKt93u2g+bVkCDTWYQMFaa5/PpnnF2SwGMIDBQcE1C8pJGRlUqWS99Zb
 UsO9UIGvaU0sUCmUNT5dxm5u2Kf+A4RXcJKFO834x3LzbDbiy67LGUZSj9KaPQ9qdQ7Azct0
 ze0c8jBXGI19ufPEDTEq+nS/Wja1TUpwXEqOAkVbS1e7/rZnN8wiivldolDAYuZkYigcd3v+
 AyioC87jrQVqMcE0aSn4FzK6w6RSoj1oh0dvVuOAD/8hu9tTMv8PtHztwCHhRpVBNvBFjG8U
 G44d99yBQzkJbWEj2SzTeoEB9lFDN7VYWSH0TaD83TMnglBGkJPn6gNuFmSx28za67onAMFh
 meJ52u9A7cJYROXgVdfOd7ZNijT5fGI+S7Zfv7VdMFSRZN6aRWK+ipjDWbJgTywzhR2zftkZ
 s/AGSpJMZr8If45pNZRb71AuYLHOwhknT+DLXwF507PPUWiiI69Fu5ebQrmghER56KYugTFm
 +uzxOPRoyizpNbWO3GNmaZKdAhiBSFiWfje9pwGHsbec1EOMDxwVJfsLUYJJtUNc1J9zbyTo
 BlQmyZwlTLCuJEwAV7SOyA7Nei2Bs4XQLBSFXVEAGtEEkMLOe6HhJrzvbNuFVX73ISPFcJJc
 sQ=
IronPort-HdrOrdr: A9a23:1okAAaj13JVPolTDs2anlpUv33BQXuIji2hC6mlwRA09TySZ//
 rBoB19726MtN9xYgBHpTnuAsm9qB/nmaKdpLNhWItKPzOW31dATrsSjrcKqgeIc0aVm9K1l5
 0QF5SWYOeAdWSS5vya3ODXKbkdKaG8gcKVuds=
X-IronPort-AV: E=Sophos;i="5.90,134,1643691600"; 
   d="scan'208";a="64830769"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>, Thiner Logoer
	<logoerthiner1@163.com>, =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?=
	<marmarek@invisiblethingslab.com>
Subject: x86/CET: Fix S3 resume with shadow stacks active
Date: Thu, 24 Feb 2022 19:48:52 +0000
Message-ID: <20220224194853.17774-2-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220224194853.17774-1-andrew.cooper3@citrix.com>
References: <20220224194853.17774-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

The original shadow stack support has an error on S3 resume with very bizzare
fallout.  The BSP comes back up, but APs fail with:

  (XEN) Enabling non-boot CPUs ...
  (XEN) Stuck ??
  (XEN) Error bringing CPU1 up: -5

and then later (on at least two Intel TigerLake platforms), the next HVM vCPU
to be scheduled on the BSP dies with:

  (XEN) d1v0 Unexpected vmexit: reason 3
  (XEN) domain_crash called from vmx.c:4304
  (XEN) Domain 1 (vcpu#0) crashed on cpu#0:

The VMExit reason is EXIT_REASON_INIT, which has nothing to do with the
scheduled vCPU, and will be addressed in a subsequent patch.  It is a
consequence of the APs triple faulting.

The reason the APs triple fault is because we don't tear down the stacks on
suspend.  The idle/play_dead loop is killed in the middle of running, meaning
that the supervisor token is left busy.

On resume, SETSSBSY finds the token already busy, suffers #CP and triple
faults because the IDT isn't configured this early.

Rework the AP bringup path to (re)create the supervisor token.  This ensures
the primary stack is non-busy before use.

Fixes: b60ab42db2f0 ("x86/shstk: Activate Supervisor Shadow Stacks")
Link: https://github.com/QubesOS/qubes-issues/issues/7283
Reported-by: Thiner Logoer <logoerthiner1@163.com>
Reported-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Tested-by: Thiner Logoer <logoerthiner1@163.com>
Tested-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>
CC: Thiner Logoer <logoerthiner1@163.com>
CC: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>

Slightly RFC.  This does fix the crash encountered, but it occurs to me that
there's a race condition when S3 platform powerdown is incident with an
NMI/#MC, where more than just the primary shadow stack can end up busy on
resume.

A larger fix would be to change how we allocate tokens, and always have each
CPU set up its own tokens.  I didn't do this originally in the hopes of having
WRSSQ generally disabled, but that plan failed when encountering reality...

diff --git a/xen/arch/x86/boot/x86_64.S b/xen/arch/x86/boot/x86_64.S
index fa41990dde0f..5d12937a0e40 100644
--- a/xen/arch/x86/boot/x86_64.S
+++ b/xen/arch/x86/boot/x86_64.S
@@ -51,13 +51,21 @@ ENTRY(__high_start)
         test    $CET_SHSTK_EN, %al
         jz      .L_ap_cet_done
 
-        /* Derive MSR_PL0_SSP from %rsp (token written when stack is allocated). */
-        mov     $MSR_PL0_SSP, %ecx
+        /* Derive the supervisor token address from %rsp. */
         mov     %rsp, %rdx
+        and     $~(STACK_SIZE - 1), %rdx
+        or      $(PRIMARY_SHSTK_SLOT + 1) * PAGE_SIZE - 8, %rdx
+
+        /*
+         * Write a new supervisor token.  Doesn't matter on boot, but for S3
+         * resume this clears the busy bit.
+         */
+        wrssq   %rdx, (%rdx)
+
+        /* Point MSR_PL0_SSP at the token. */
+        mov     $MSR_PL0_SSP, %ecx
+        mov     %edx, %eax
         shr     $32, %rdx
-        mov     %esp, %eax
-        and     $~(STACK_SIZE - 1), %eax
-        or      $(PRIMARY_SHSTK_SLOT + 1) * PAGE_SIZE - 8, %eax
         wrmsr
 
         setssbsy


From xen-devel-bounces@lists.xenproject.org Thu Feb 24 19:49:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 19:49:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278591.475908 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNK6v-0006CK-Ru; Thu, 24 Feb 2022 19:49:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278591.475908; Thu, 24 Feb 2022 19:49:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNK6v-0006B0-Kt; Thu, 24 Feb 2022 19:49:09 +0000
Received: by outflank-mailman (input) for mailman id 278591;
 Thu, 24 Feb 2022 19:49:08 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=oTFz=TH=citrix.com=prvs=047b345d9=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nNK6u-00068X-Ts
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 19:49:08 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d2c10a42-95aa-11ec-8539-5f4723681683;
 Thu, 24 Feb 2022 20:49:07 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d2c10a42-95aa-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645732147;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=FrcIuQFMoLhLEcVl+cvl5AZm1H6qvYM6PJlmDQshz58=;
  b=Lq4D+U2zSZOjj2ZoIRWF3VCb9D8Y6sJMPR7ts0fl0RVpwqsMMZjc+O+c
   gYnRq2gRJF6LbeHht6v2EjXoEiootGZml/r8SqooXFHAH0edlSiotuVLK
   JI2FswwR1/0KiRWY3ag8m7AH0pq9J6YvJaPSjfBNLwR9MlQY2nRsTG7++
   4=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 67202356
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:PSOo+KlP0R0BvMewPZaBDebo5gxjJkRdPkR7XQ2eYbSJt1+Wr1Gzt
 xIZDWjTPPnYYmqhfNAkO9ji9RwHuZ6And8wTwZsritnEiMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EoLd9IR2NYy24DjWV/V4
 rsenuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR
 v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ
 NtxWZOYQiAbYo6LmKcnVBBICX9EFpZt3ICWCC3q2SCT5xWun3rExvxvCAc9PJEC+/YxCmZLn
 RAaAGlTNFbZ3bvwme/lDLk37iggBJCD0Ic3k3ds1zzGS90hRojOWf7i7t5ExjYgwMtJGJ4yY
 uJHNmA3Nk+dPXWjPH9LCagxnuPx3UKhdjR8pgq5qo0mxi/6mVkZPL/Fb4OOJ43iqd9utkWVu
 GPAuXj4CxcyNdqDxD7D+XWp7sfLmiz8VZgOFLy+++QzqATNnSoYDxh+fV6yu/ywkEO9c9NZN
 U0P+yAqoLQy9UqkVd30VVuzp3vslhwBXZxWGu4z6gCIw4LV5RqUAi4PSTspQMwrsoo6SCIn0
 neNnsj1Hnp/vbuNU3Wf+7yI6zSoNkA9D0UPeCsFRgst+MT4rcc4iRenZslnOL64iJvyAz6Y/
 tyRhHFg3fNJ15dNjvjluwCc696xmnTXZgUS1Fn0GWLm1ARwdJT7XaeTwnzkvN8Vee51UWK9l
 HQDnsGf6sUHApeMiDGBTY0xIV252xqWGGaC2AAyRvHN4xzooif+Jt4IvFmSMW80ap5sRNP/X
 KPEVeq9Drd3NWDiU6J4apnZ5y8Cnfm5ToSNuhw5g7NzjnlNmO2voXkGia24hTmFfK0QfUcXY
 8nznSGEVytyNEif5GDqL9rxKJdyrszE+UvdRIrg0zOs2qeEaXieRN8taQXSM75ltv/e+1qNq
 L6z0vdmLT0FDoUShQGNrOYuwa0idyBnVfgaVeQNHgJ8HuaWMD54UKKAqV/QU4dkg75Uho/1E
 oKVASdlJK7ErSSfc22iMyk7AJu2BMoXhS9rbEQEYAfzs1B+MNnH0UvqX8ZuFVXR3Lc4lqAco
 jhsU5joP8mjvRyco2VNNcSm9dc6HPlp7CrXVxeYjPEEV8YIb2T0FhXMJ2MDKAFm4vKLiPYD
IronPort-HdrOrdr: A9a23:iPOTlKOmfKPLi8BcTv+jsMiBIKoaSvp037BN7TESdfU1SL36qy
 nKpp8mPHDP6Qr5NEtOpTniAsW9qBHnmKKdiLN5VYtKNDOW3VdAR7sD0WKN+VPd84uVzJ846Y
 5QN4xFTP3qDUI/qcrm6CSxDt5I+rO6zJw=
X-IronPort-AV: E=Sophos;i="5.90,134,1643691600"; 
   d="scan'208";a="67202356"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>, Jun Nakajima
	<jun.nakajima@intel.com>, Kevin Tian <kevin.tian@intel.com>, Thiner Logoer
	<logoerthiner1@163.com>, =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?=
	<marmarek@invisiblethingslab.com>
Subject: x86/vmx: Don't spuriously crash the domain when INIT is received
Date: Thu, 24 Feb 2022 19:48:53 +0000
Message-ID: <20220224194853.17774-3-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20220224194853.17774-1-andrew.cooper3@citrix.com>
References: <20220224194853.17774-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

In VMX operation, the handling of INIT IPIs is changed.  EXIT_REASON_INIT has
nothing to do with the guest in question, simply signals that an INIT was
received.

Ignoring the INIT is probably the wrong thing to do, but is helpful for
debugging.  Crashing the domain which happens to be in context is definitely
wrong.  Print an error message and continue.

Discovered as collateral damage from when an AP triple faults on S3 resume on
Intel TigerLake platforms.

Link: https://github.com/QubesOS/qubes-issues/issues/7283
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>
CC: Jun Nakajima <jun.nakajima@intel.com>
CC: Kevin Tian <kevin.tian@intel.com>
CC: Thiner Logoer <logoerthiner1@163.com>
CC: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>

diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c
index c075370f642a..883213ce8f6a 100644
--- a/xen/arch/x86/hvm/vmx/vmx.c
+++ b/xen/arch/x86/hvm/vmx/vmx.c
@@ -3965,6 +3965,10 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs)
     case EXIT_REASON_MCE_DURING_VMENTRY:
         do_machine_check(regs);
         break;
+
+    case EXIT_REASON_INIT:
+        printk(XENLOG_ERR "Error: INIT received - ignoring\n");
+        return; /* Renter the guest without further processing */
     }
 
     /* Now enable interrupts so it's safe to take locks. */


From xen-devel-bounces@lists.xenproject.org Thu Feb 24 19:49:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 19:49:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278592.475922 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNK77-0006kq-1o; Thu, 24 Feb 2022 19:49:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278592.475922; Thu, 24 Feb 2022 19:49:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNK76-0006kj-UK; Thu, 24 Feb 2022 19:49:20 +0000
Received: by outflank-mailman (input) for mailman id 278592;
 Thu, 24 Feb 2022 19:49:20 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=oTFz=TH=citrix.com=prvs=047b345d9=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nNK76-00068X-1Z
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 19:49:20 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d9a48a77-95aa-11ec-8539-5f4723681683;
 Thu, 24 Feb 2022 20:49:18 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d9a48a77-95aa-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645732158;
  h=from:to:cc:subject:date:message-id:mime-version:
   content-transfer-encoding;
  bh=dBGtOVnJAGzlMckx93dr04watYwOZpHH/UAI9UgAPoc=;
  b=brv0b/pMW4l32nGs9qQA/teD0kmxdmyomCdvGk7MrzQ/QEsLd9Vln3ty
   n1ZyU5smwpinNJm/Pl++hbeeSm8Se65M4MtthTGfUqvUqJkaTqzRLqzld
   +rHN7aOb2HlSUxpQWyD+bcgnV9czN+u0l4g40UzR61u5BLtWdFnYoknwe
   4=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 64939144
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:tyj4iKgLhCacCTUgg98zhfUoX161qhAKZh0ujC45NGQN5FlHY01je
 htvUWrTPKrbZDD3ft92a4Wx8hsBuJXRy9IyHQFr/CFgECgb9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M78wIFqtQw24LhWVnR4
 YiaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV
 efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9
 TlDiXC/YQsDAKvziM4dbxl7LQJ5L7Ie4OL2AUHq5KR/z2WeG5ft6/BnDUVwNowE4OdnR2pJ8
 JT0KhhUMErF3bjvhuvmFK883azPL+GyVG8bklhmwSvUErANRpfbTr+RzdRZwC0xloZFGvO2i
 88xN2Y+N0WZP0En1lE/NIMlt/qPlFjENBpphWCwvoko3FLd5VkkuFTqGIWMIYHbLSlPpW6co
 W3B8n7lAhAcOcbG4WPbqTSngeqntSbyQocbDrC73v9snlyIx2YXBQEWVF20uv2wgAi1XNc3A
 08Z5Cso67Qz/UqDT9/hUhn+q3mB1jYMVtwVH+Ak5QWlzqvP/x3fFmUCViRGatEtqIkxXzNC/
 n2jks7tBDdvmKaIUn/b/bCRxRutPQAFIGlEYjULJTbp+PG6/tt11EiWCI8+Tujl1bUZBA0c3
 RiGhhY4uKU5jfIL9JuY+kLY2yrxl7jwG1tdChrsYkqp6QZwZYiAboOu6ETG4fsoELt1XmVtr
 1BfxZHAsblm4YWl0XXUHb5TRO3BC+OtbWWE6WODCaXN4NhEF5SLWYlLqA9zK05yWirvUW+4O
 RSD0e+9CXI6AZdLUUOVS9/pYyjJ5fK5fTgAahwyRoAQCnSWXFXalByCnWbKgwjQfLEEyMnTw
 6uzf8e2Fmo9Aq961jewTOp1+eZ1mn1gmTmPH8ukl0/PPV+iiJi9E+lt3LymNL1R0U95iF+Nr
 4Y32zWikX2zr9ESkgGIqNVOfDjm3FAwBIzsqtw/SwJwClEOJY3VMNeImelJU9U8x8x9z76Ul
 lngCh4w4Aeu3hXvdFTVAk2PnZuyBP6TW1pgZndyVbtpslB+CbuSAFA3LMNmLeF6r7U4lZaZj
 ZAtIq29PxiGcRyfkxx1UHU3hNwKmMiD7e5WAxeYXQ==
IronPort-HdrOrdr: A9a23:sk/1OaDq1rctRbHlHemg55DYdb4zR+YMi2TC1yhKJyC9Ffbo8P
 xG/c5rsSMc5wxwZJhNo7y90cq7MBbhHPxOkOos1N6ZNWGM0gaVxelZnO3fKlbbehEWmNQz6U
 4ZSdkdNOHN
X-IronPort-AV: E=Sophos;i="5.90,134,1643691600"; 
   d="scan'208";a="64939144"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>, Thiner Logoer
	<logoerthiner1@163.com>, =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?=
	<marmarek@invisiblethingslab.com>, Kevin Tian <kevin.tian@intel.com>
Subject: x86: Fix crash on S3 resume
Date: Thu, 24 Feb 2022 19:48:51 +0000
Message-ID: <20220224194853.17774-1-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

Two fixes from investing a QubesOS bug report.

Andrew Cooper (2):
  x86/CET: Fix S3 resume with shadow stacks active
  x86/vmx: Don't spuriously crash the domain when INIT is received

 xen/arch/x86/boot/x86_64.S | 18 +++++++++++++-----
 xen/arch/x86/hvm/vmx/vmx.c |  4 ++++
 2 files changed, 17 insertions(+), 5 deletions(-)



From xen-devel-bounces@lists.xenproject.org Thu Feb 24 20:13:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 20:13:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278612.475936 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNKUZ-000285-2N; Thu, 24 Feb 2022 20:13:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278612.475936; Thu, 24 Feb 2022 20:13:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNKUY-00027y-Vj; Thu, 24 Feb 2022 20:13:34 +0000
Received: by outflank-mailman (input) for mailman id 278612;
 Thu, 24 Feb 2022 20:13:33 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nNKUX-00027o-IU; Thu, 24 Feb 2022 20:13:33 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nNKUX-0005mv-DJ; Thu, 24 Feb 2022 20:13:33 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nNKUW-0007ht-Bb; Thu, 24 Feb 2022 20:13:32 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nNKUW-0005ea-BB; Thu, 24 Feb 2022 20:13:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=lgH3OLsbhS5b8ayynqAakDWuXc7qgYM+4rW0oPckXPU=; b=4DOmPzaBBdd4ea4PKSS6StbFPg
	5xqRDbixhjD6XZXxVC+3SRkKrFK/KHgyvbV6VVTyz6rl60mCN/tLGHiTPw7zLy3rX7nX4qrTk6Ihj
	dauj2S4M00eEfc8izAU6kU7f/Rx2ZXGGlmVzFz7beC8xJJdTOHBi+kppLDurPpeCIodw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168218-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 168218: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=66b467a0e86daff8caa2b571871b1cb96633df45
X-Osstest-Versions-That:
    xen=93189e8c8b93e2c4658156e785a9b78b61e71a64
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 24 Feb 2022 20:13:32 +0000

flight 168218 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168218/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  66b467a0e86daff8caa2b571871b1cb96633df45
baseline version:
 xen                  93189e8c8b93e2c4658156e785a9b78b61e71a64

Last test of basis   168216  2022-02-24 11:01:39 Z    0 days
Testing same since   168218  2022-02-24 16:01:44 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com><mailto:andrew.cooper3@citrix.com>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Julien Grall <jgrall@amazon.com>
  Michal Orzel <michal.orzel@arm.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   93189e8c8b..66b467a0e8  66b467a0e86daff8caa2b571871b1cb96633df45 -> smoke


From xen-devel-bounces@lists.xenproject.org Thu Feb 24 21:51:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 21:51:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278627.475948 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNM1X-0003IZ-Jv; Thu, 24 Feb 2022 21:51:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278627.475948; Thu, 24 Feb 2022 21:51:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNM1X-0003IS-GU; Thu, 24 Feb 2022 21:51:43 +0000
Received: by outflank-mailman (input) for mailman id 278627;
 Thu, 24 Feb 2022 21:51:41 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Z+bi=TH=oracle.com=dongli.zhang@srs-se1.protection.inumbo.net>)
 id 1nNM1V-0003IH-2C
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 21:51:41 +0000
Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com
 [205.220.177.32]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f031e36c-95bb-11ec-8539-5f4723681683;
 Thu, 24 Feb 2022 22:51:37 +0100 (CET)
Received: from pps.filterd (m0246630.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 21OKTCAA026078; 
 Thu, 24 Feb 2022 21:51:09 GMT
Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71])
 by mx0b-00069f02.pphosted.com with ESMTP id 3ecvar891r-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 24 Feb 2022 21:51:09 +0000
Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1])
 by aserp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 21OLexQe004512;
 Thu, 24 Feb 2022 21:51:08 GMT
Received: from nam11-co1-obe.outbound.protection.outlook.com
 (mail-co1nam11lp2172.outbound.protection.outlook.com [104.47.56.172])
 by aserp3030.oracle.com with ESMTP id 3eapkkvqpr-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 24 Feb 2022 21:51:08 +0000
Received: from BYAPR10MB2663.namprd10.prod.outlook.com (2603:10b6:a02:a9::20)
 by BN6PR10MB2020.namprd10.prod.outlook.com (2603:10b6:404:100::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Thu, 24 Feb
 2022 21:51:05 +0000
Received: from BYAPR10MB2663.namprd10.prod.outlook.com
 ([fe80::a0d5:610d:bcf:9b47]) by BYAPR10MB2663.namprd10.prod.outlook.com
 ([fe80::a0d5:610d:bcf:9b47%4]) with mapi id 15.20.4995.027; Thu, 24 Feb 2022
 21:51:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f031e36c-95bb-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc :
 subject : date : message-id : content-type : mime-version;
 s=corp-2021-07-09; bh=O1gSDQTacDSNjxNoGSWyOCwpiMkubGpkduZAn3weBqk=;
 b=Q7/vh+pJbokaU3xuCplT/nOU46Z3Wt4zt0ks64Blv4DUiZ8m+KhYNCEo5PZjxJNAAb08
 RFwdZf1iN5oWMjb3YU3gTjXstcIeyg68NQL6YM5tsqj8vadfaJsviYS4T069QXRcSSvD
 Jf5wF1EFyGRAgjIejgESU+u/K1EF7qdfyCW8UyGxeFaDoeEwnIHZW+qk2EL0JaU6zOyD
 8xxF30qSfEvvrno8LP926TjA7t9IAvWy3C2nqmrUJxJ8wcGj6f7rftc+Cx20uErFLFYI
 iLMsgzq2epEjrYmaZWZGIyHw0bzebJrcE1wN+AWjojQKaV6ngs0q/e9EvOiqE+G0u7Ei Dw== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=i8RWz7bXhU6isQ3gtUM/ihv3VbOdEBmlZf1cSyIisEUT795936930GG3U3KxbfiQsUjWKtqf7O4VWJfj/LYNKweJIPCxuwdDT/W7uP7k+hpfClSQ8YGrEa05tx/w0MFgRjH7sAfxtEfY32Ehv4HsoavdZ7WuNF7R7Rv5lqhFs69HcLTFXtmw2U3tzJhlFpxSPV0xmoLiN9LjXhrJUfuWBgriRg8hwkQBjoxkib7/zoM2zHxBdsNzsVC0Te50PBfD84gj+vuCX83wd0TEd2HiZFgCoBLtLjxPiRmb80rY8R/p1FSBIK7+7O38Ws4a8ds99gQBR7yYsCz0pcC8owAx6Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=O1gSDQTacDSNjxNoGSWyOCwpiMkubGpkduZAn3weBqk=;
 b=Po+aq0eh9mQS/DTuKKuOZN7jEtL32XYB02Wx/KdudK99HrgrT7HMltdPonV18jC27qa/30YgtE7TFG00+tuA/SA6yYVRK4t7y85DXxb+WllmWI2QhqwqFOXzcsAuHJTQtVIaYCNWXrzUPtj8W/aS0PlG5DujqsgaRMsBWmYtKsuhSgWBJqrEwADagEqwE6i9+PGrWCncayumbCZAMTz8gPq6c3UvxiwHozFUY6Nt6zgBt3ZvkxcXi3tYRYXYSV8XjqmkNZuyd3A2wx6nbSN98EKFiu39NZH0gchfOHS6dU4FgL8VH2gXh9a2+755aD80rTVGz2pohNuTRfeGceRtog==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=O1gSDQTacDSNjxNoGSWyOCwpiMkubGpkduZAn3weBqk=;
 b=Ich7CIfLQjA2kP1/VMbdiP9Hsf0EatO38/NrH28nLhf0chXI5jF8G5O8HThXmdovgRXItw//Ytt/5bPkTZb9jls30mGM5GmXtFptNXmKJCiFwBhZwUhUOBhSO0ZZjlIesfblnlgt20Jy9zCdBwGLk9DDB0mW9p3i389o88StrwA=
From: Dongli Zhang <dongli.zhang@oracle.com>
To: xen-devel@lists.xenproject.org, x86@kernel.org
Cc: linux-kernel@vger.kernel.org, boris.ostrovsky@oracle.com, jgross@suse.com,
        sstabellini@kernel.org, tglx@linutronix.de, mingo@redhat.com,
        bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com,
        joe.jin@oracle.com
Subject: [PATCH v3 0/1] xen: fix HVM kexec kernel panic
Date: Thu, 24 Feb 2022 13:50:48 -0800
Message-Id: <20220224215049.2845-1-dongli.zhang@oracle.com>
X-Mailer: git-send-email 2.17.1
Content-Type: text/plain
X-ClientProxiedBy: SA9PR13CA0099.namprd13.prod.outlook.com
 (2603:10b6:806:24::14) To BYAPR10MB2663.namprd10.prod.outlook.com
 (2603:10b6:a02:a9::20)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c8c5c01d-1f74-4a3b-76a5-08d9f7dfc1d2
X-MS-TrafficTypeDiagnostic: BN6PR10MB2020:EE_
X-Microsoft-Antispam-PRVS: 
	<BN6PR10MB2020D15FCE8FCDDFA9266E25F03D9@BN6PR10MB2020.namprd10.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	kenOy3uzedM5w3yIYgEDKiimU1aXoNIgTUQYhRYEuc1BxzNYA92dmEUzZhuBQxNRlVZku25W1PMselnACQfrddnvyxF4A3hCNMzMZ9ybLCGXYIOCgfqzqJbvKwwNwadiJfznmlxp4E3kqMmCBtoH4Xh5pVB7lKd/5qOxhpB+VCVWrKHL1mTGI+pwz9tW4tUrqeWkmdAWE0xitSyaSaLkNDZ2jZOH1s/v804TPvRuLoJqDltQdyuYycZX9ebU4he9Zyb+NtMsI4ed+9AX8xpDR7SG93RFqz4HuyMsZl98zXNW/cfXtoLPa6DQphW4zlbiTOJOSCzE8K9CZS47ZcYmC2lMK6Zr/KBVpVDzDKv0q1t8bVqpx/iB+5xeK6pzbpQWSTLdgwfxEVXcsikMxoqXsKxv/f+DNGrMbIoSxf0ZZN4s59PDJDTD9xL/Xl5nIQPy37EGr7ubWFkMzKfwRquysTzGRogR1ni030NExDdUKh9fGeYlsxJ726KXmXOoKmNvp2iL6SyofT4YzFyc0rgdkjbngRhoChzN3zVPf/8uQEYS7vR9+cdLvaGBrfR90qBCuXnlB8nHItOIosvZ2/wwkj5Kem8WODoK8C13I+OWv2N4MYLrIod/WAi5xFXjPcU3QqDWQqspLS1fbqd7faljLy2ZILQTFm6NKYgIUPykZW132JzsUx/2iocHj0FmyI+pz21fq1Npy7o4Pdzww/tmxMnOp7WixsL37h8JTR06P21e7ZUQqA4eyk/sl1iLlBcwPyheWGdTPlfLP60xgzvDpCv6Z5q3REHlvI6SO+AA46o=
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB2663.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(1076003)(44832011)(36756003)(86362001)(2906002)(6512007)(107886003)(186003)(8936002)(2616005)(6506007)(26005)(7416002)(966005)(6486002)(5660300002)(8676002)(66556008)(508600001)(52116002)(83380400001)(66946007)(4326008)(66476007)(6666004)(38100700002)(38350700002)(316002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?gCu7JsHtajKygwliAUDMhkV9vO9s7g4qfMJ/MbXl1DuIdvPYpw90w4+MO0JZ?=
 =?us-ascii?Q?PzaYgT+C99Q9KsqcZMvhZiqeK442yv3I+ZkO3n7G4EDHE4ACLyu/VwzO5uBd?=
 =?us-ascii?Q?h501jKcLsPiEbcUzkUEwMAzv47to0bvnHtD7Gd2tSaE/8ItD92CGwISS7wol?=
 =?us-ascii?Q?qBBmqF0HalOpmQzVzoTEzAMd5N+kMqgWU/Y4hapBaag4ILwM3xH03KVyEgVT?=
 =?us-ascii?Q?cWcQDTq6eSgu/ywM8koaHTOzY7weGnJOFjtaKdatFjuhziHlhiE94h1JIc6f?=
 =?us-ascii?Q?E64PCfPMUKuzDJsnJM12h52x3fN8CJ3zGX4mTGWRvW3CsdyfG5QMtQFgGkDV?=
 =?us-ascii?Q?Qz+k5G/dVn69pOSNyZZrjuyIskkfsMn1r0OGF6cSiqFsboe5Wbp65JCYXO2W?=
 =?us-ascii?Q?vrVDtiqn4ez8KydJiepulwhwC+n3RyXLFIe4RyjgzZAWTerflmXimPwos06L?=
 =?us-ascii?Q?OsPvhw1T/XxjCn06PI7QQ107eArYU2koZlvAhg4xMYv2HAJL8ppO9Uz57seQ?=
 =?us-ascii?Q?ARZc6wrUpggv7q6vcNVLEvSUXqm+viQXHgpI1reMN8QjfDSmVIw0SoQ0/EGW?=
 =?us-ascii?Q?kB+L+E1gyzHXboYzWoXS/rpdeup7PONyWQKoXtMTXmBmoMDPhxhSprB26ht4?=
 =?us-ascii?Q?Abl80EJUjqekYM8x0TMAGYKVXbWJLLy9hvvwAxiG4kqZPPSULe2QKow+hAdK?=
 =?us-ascii?Q?9Du5iCHP0lIg2YNAnLCwHpa805LzhXMtVtebGtUNz1aS1lGGok9HfRRXk7ax?=
 =?us-ascii?Q?xUoOhw31TnxrnZ/ziMpMgen0Xr0rp2y938VnoKzk//YhYmJaEg6bzHxNFFnu?=
 =?us-ascii?Q?xkvr4R08n01FyncN/bJNihFPaq5aISjEA3Sf/aqFYUNeb9ecBf2EC5HeIKd4?=
 =?us-ascii?Q?rYPsDpJ6ejv31N+MrSxmdPzbMwKb1X5c7vQ514+6SnAHq890AakeoWTmL4bk?=
 =?us-ascii?Q?Y2VExAabp3xUjmaJlxjt7SUSy+U3aj4np6RQpKLqUVjlSJyTo0CWp71Leh4R?=
 =?us-ascii?Q?rTrtjbdRXCNIk9Wwhkr+WJwWA0wsF8dteiLkwywahpOb8K7UhbPzRW+vFahO?=
 =?us-ascii?Q?wrc9FRHkaH5sbTItkC97p07geW7zlvVg2m+heatqOGhWAcfFriYp8ycAbfi3?=
 =?us-ascii?Q?jZcGep0/U6WTcdJu4Ktlmmwg9HZGujfgm7d5PpXsmbHEWW0VSNHof7C+KqUs?=
 =?us-ascii?Q?UGztWWoDT8geHDSk+h4rY0Hh4tpGdi3FtBAhAvIOppmLQDikIdr9UBHSKcAn?=
 =?us-ascii?Q?IX+N01y40lyGur2fizt2FVMzDLGZXKlkkmZ0YjNS3HG6DtJ5F/sdZYzpsCWj?=
 =?us-ascii?Q?eiJTkdXRyMM89UfmfulwSs0X/CdEhHpNj6skptuDXzN4OlGhxar1RPTz/hU3?=
 =?us-ascii?Q?DmwnuWT1N1eVOexmCbkiG09NYPU7gGCDdZUkMRGoI6DFdnZeWVx+mTcEzTsQ?=
 =?us-ascii?Q?Rt5w5gxu+crA7asxdXtkaToI+fFBGkJHZuLTPOXU2n3oG5DYIy14FeWgqx9m?=
 =?us-ascii?Q?AZ/lY2Oa56NFQCIFnOme55VdKgoCIdmy5tmJT8aHEDWzyE3eGGLAcKDMgjco?=
 =?us-ascii?Q?okz/3LVgr3HC20UFR1YssulN+4z+ifjc5RFL3wI+0MAIWrKvqvYOtdEra2Jo?=
 =?us-ascii?Q?4CL6tXgBp0DYhJ0qPTx0uHs=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c8c5c01d-1f74-4a3b-76a5-08d9f7dfc1d2
X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2663.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2022 21:51:05.4480
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1pBgUsMJH7+/NB+S7e8c2PEDVh0zBJtDphjdsuccv38DmeMVT+NgX7/rE1wq/SVuulvv7bOVwDmNnXgGggq2og==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR10MB2020
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10268 signatures=684655
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0 mlxscore=0
 spamscore=0 mlxlogscore=999 adultscore=0 phishscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2202240120
X-Proofpoint-GUID: C95S2tNrFwvPWTj3CCXfrYKw8unkJkMx
X-Proofpoint-ORIG-GUID: C95S2tNrFwvPWTj3CCXfrYKw8unkJkMx

This is the v3 of the patch to fix xen kexec kernel panic issue when the
kexec is triggered on VCPU >= 32.

PANIC: early exception 0x0e IP 10:ffffffffa96679b6 error 0 cr2 0x20
[    0.000000] CPU: 0 PID: 0 Comm: swapper Not tainted 5.17.0-rc4xen-00054-gf71077a4d84b-dirty #1
[    0.000000] Hardware name: Xen HVM domU, BIOS 4.4.4OVM 12/15/2020
[    0.000000] RIP: 0010:pvclock_clocksource_read+0x6/0xb0
... ...
[    0.000000] RSP: 0000:ffffffffaae03e10 EFLAGS: 00010082 ORIG_RAX: 0000000000000000
[    0.000000] RAX: 0000000000000000 RBX: 0000000000010000 RCX: 0000000000000002
[    0.000000] RDX: 0000000000000003 RSI: ffffffffaac37515 RDI: 0000000000000020
[    0.000000] RBP: 0000000000011000 R08: 0000000000000000 R09: 0000000000000001
[    0.000000] R10: ffffffffaae03df8 R11: ffffffffaae03c68 R12: 0000000040000004
[    0.000000] R13: ffffffffaae03e50 R14: 0000000000000000 R15: 0000000000000000
[    0.000000] FS:  0000000000000000(0000) GS:ffffffffab588000(0000) knlGS:0000000000000000
[    0.000000] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[    0.000000] CR2: 0000000000000020 CR3: 00000000ea410000 CR4: 00000000000406a0
[    0.000000] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[    0.000000] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
[    0.000000] Call Trace:
[    0.000000]  <TASK>
[    0.000000]  ? xen_clocksource_read+0x24/0x40
[    0.000000]  ? xen_init_time_common+0x5/0x49
[    0.000000]  ? xen_hvm_init_time_ops+0x23/0x45
[    0.000000]  ? xen_hvm_guest_init+0x221/0x25c
[    0.000000]  ? 0xffffffffa9600000
[    0.000000]  ? setup_arch+0x440/0xbd6
[    0.000000]  ? start_kernel+0x6c/0x695
[    0.000000]  ? secondary_startup_64_no_verify+0xd5/0xdb
[    0.000000]  </TASK>


Changed since v1:
  - Add commit message to explain why xen_hvm_init_time_ops() is delayed
    for any vcpus. (Suggested by Boris Ostrovsky)
  - Add a comment in xen_hvm_smp_prepare_boot_cpu() referencing the related
    code in xen_hvm_guest_init(). (suggested by Juergen Gross)
Changed since v2:
  - Delay for all VCPUs. (Suggested by Boris Ostrovsky)
  - Add commit message that why PVM is not supported by this patch
  - Test if kexec/kdump works with mainline xen (HVM and PVM)


I have delayed the xen_hvm_init_time_ops() for all VCPUs. Unfortunately,
now I am able to reproduce the clock backward as shown below on some old
versions of xen. I am not able to reproduce on most recent mainline xen.

[    0.359687] pcpu-alloc: [0] 16 17 18 19 20 21 22 23 [0] 24 25 26 27 28 29 30 31
[    0.359694] pcpu-alloc: [0] 32 33 34 35 36 37 38 39 [0] 40 41 42 43 44 45 46 47
[    0.359701] pcpu-alloc: [0] 48 49 50 51 52 53 54 55 [0] 56 57 58 59 60 61 62 63

... clock backward after the clocksource is switched from native to xen...

[    0.000004] Fallback order for Node 0: 0
[    0.002967] Built 1 zonelists, mobility grouping on.  Total pages: 3527744
[    0.007129] Policy zone: Normal
[    0.008937] Kernel command line: BOOT_IMAGE=/boot/vmlinuz-5.17.0-rc4xen-00054-gf71077a4d84b-dirty root=UUID=2a5975ab-a059-4697-9aee-7a53ddfeea21 ro text console=ttyS0,115200n8 console=tty1 earlyprintk=tty    S0,115200n8 loglevel=7 no_timer_check reboot=s32 splash crashkernel=512M-:192M vt.handoff=1
[    0.023880] Unknown kernel command line parameters "text splash BOOT_IMAGE=/boot/vmlinuz-5.17.0-rc4xen-00054-gf71077a4d84b-dirty", will be passed to user space.
[    0.032647] printk: log_buf_len individual max cpu contribution: 4096 bytes
[    0.036828] printk: log_buf_len total cpu_extra contributions: 258048 bytes
[    0.041049] printk: log_buf_len min size: 262144 bytes
[    0.044481] printk: log_buf_len: 524288 bytes


Since now I am able to reproduce the clock backward on old xen version,
please let me know if I should re-use the v2 of this patch, as it has been
running well in our env well for very long time.

https://lore.kernel.org/all/20211028012543.8776-1-dongli.zhang@oracle.com/


BTW, I have tested that 'soft_reset' does not work with mainline xen, even
when I directly trigger kexec with below commands.

# kexec -l /boot/vmlinuz-5.17.0-rc4xen-00054-gf71077a4d84b-dirty \
        --initrd=/boot/initrd.img-5.17.0-rc4xen-00054-gf71077a4d84b-dirty \
        --reuse-cmdline
# kexec -e


Thank you very much!

Dongli Zhang




From xen-devel-bounces@lists.xenproject.org Thu Feb 24 21:51:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 21:51:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278628.475952 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNM1X-0003L0-Tz; Thu, 24 Feb 2022 21:51:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278628.475952; Thu, 24 Feb 2022 21:51:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNM1X-0003KL-OW; Thu, 24 Feb 2022 21:51:43 +0000
Received: by outflank-mailman (input) for mailman id 278628;
 Thu, 24 Feb 2022 21:51:42 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Z+bi=TH=oracle.com=dongli.zhang@srs-se1.protection.inumbo.net>)
 id 1nNM1W-0003IH-7Z
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 21:51:42 +0000
Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com
 [205.220.177.32]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f0658db5-95bb-11ec-8539-5f4723681683;
 Thu, 24 Feb 2022 22:51:37 +0100 (CET)
Received: from pps.filterd (m0246631.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 21OKTJw1007900; 
 Thu, 24 Feb 2022 21:51:11 GMT
Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71])
 by mx0b-00069f02.pphosted.com with ESMTP id 3ecv6f0jka-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 24 Feb 2022 21:51:10 +0000
Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1])
 by aserp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 21OLexQh004512;
 Thu, 24 Feb 2022 21:51:09 GMT
Received: from nam11-co1-obe.outbound.protection.outlook.com
 (mail-co1nam11lp2172.outbound.protection.outlook.com [104.47.56.172])
 by aserp3030.oracle.com with ESMTP id 3eapkkvqpr-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 24 Feb 2022 21:51:09 +0000
Received: from BYAPR10MB2663.namprd10.prod.outlook.com (2603:10b6:a02:a9::20)
 by BN6PR10MB2020.namprd10.prod.outlook.com (2603:10b6:404:100::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Thu, 24 Feb
 2022 21:51:07 +0000
Received: from BYAPR10MB2663.namprd10.prod.outlook.com
 ([fe80::a0d5:610d:bcf:9b47]) by BYAPR10MB2663.namprd10.prod.outlook.com
 ([fe80::a0d5:610d:bcf:9b47%4]) with mapi id 15.20.4995.027; Thu, 24 Feb 2022
 21:51:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f0658db5-95bb-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc :
 subject : date : message-id : in-reply-to : references : content-type :
 mime-version; s=corp-2021-07-09;
 bh=gZipOVj0ANJPBHydjW1hu0Ub3HQQYNC8CTUA2epZ4yg=;
 b=LKsFrBywcYkIupuzDdezEZEYmJxF89dxe03CiVpuTvSA2XSYqRuugG8+g6Q523wVN6oD
 dFBIXKwmpvFIcZ4B29ysQBy1UTxRlqM3lyT5RFK8sTmcnQMXFBr7pRz7r5cQCG1dxgk+
 n8f1/3tk2JhZd+NUdIP73+8jbE9lWKXVLd/KJ6u3RilTRC7Rf1cGR/NmzcpvqRyQZQ9N
 eospycghK4Frs7FdVvhnQF7AFYo4hpLoTLHLVu14yl0TeoAUhV3dMVhKghu1X1VDgtNI
 CSCbyMCBOmBIiwsiKm/pPHGh4EW69pDhjBuQwsqGJPh3t4gaSY5r+7u6gAHWb3d1jCgJ kA== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=nkgE1SjfwRbvJL3MQxLCHAqcCRB4o78p8vJ6s4+/HkU6u7/1bJYF8yFFtjYLkPjtJpTP120sCp81UzRfdX507m4PEODNl/0hZaOj7yGO+9mkbiK2Bbt4AmPQ30WIIdlkum9pNIOwoa6+eYZxdmCUvPswSrtWtsrdMwiBLembYZdlmerc8ivt4xGulMwW3FAH1v+duEM0qipYSMsoGw7RArcdEmuw/Xxbkv9CjHcUeXGrdQyTR68A8SjdKSdotMsp9akNkvAhB558xeLcxz3eGfErcUpDJoWKgQCOiT5f2/loaHbxr19xZSOdPSp/FVPJfwnce7IuNFozuNOGqQ0Jng==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=gZipOVj0ANJPBHydjW1hu0Ub3HQQYNC8CTUA2epZ4yg=;
 b=I66/Lw5Npf4r55R4d/s+m0V+iX/0MNLsioOrKDSwzzg51r+sO8ijhX5YK2DpIM6qm3geUq5i/eAXyROKRElhglA7ROamebZO1LkpLl4uQrim5v68ajD5pT3rrM31rGrt5QvyBnrTuHjr7b/n9RR5qlLjBvMm2hzNl+GFqfHRuVBEX1yEi5gm1HkqoV+hZNLFXxWCP6C7FzBABclZfYyG0NIMUa9HAz+Sxm123eFTv4X2DdNWewb4job+SbPF6uW2tbLOxdChlHX+v6Ll+2n9mZtEt4WuuEr3N/gDDde+b7bXRSQOiarnQPD94kUH4Usz2CJZiRoGAtTRLvkIy+cnNw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=gZipOVj0ANJPBHydjW1hu0Ub3HQQYNC8CTUA2epZ4yg=;
 b=rq/waDtXqD83I1LO13s/dAe4rfd2+WEYrqAIA+MfrfPXjYA0GVcXf9tmalQjqZtT8FZ9hNqyMAZ7qEXUNE2pPDs37wD22SyTeyAA9DgvUZSI4C4kckszH6AkXEKKNYIjGaO1Z1oWQLKso0s2hsW91CpHENHa9r04OEhq1UR5XRM=
From: Dongli Zhang <dongli.zhang@oracle.com>
To: xen-devel@lists.xenproject.org, x86@kernel.org
Cc: linux-kernel@vger.kernel.org, boris.ostrovsky@oracle.com, jgross@suse.com,
        sstabellini@kernel.org, tglx@linutronix.de, mingo@redhat.com,
        bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com,
        joe.jin@oracle.com
Subject: [PATCH v3 1/1] xen: delay xen_hvm_init_time_ops() to xen_hvm_smp_prepare_boot_cpu()
Date: Thu, 24 Feb 2022 13:50:49 -0800
Message-Id: <20220224215049.2845-2-dongli.zhang@oracle.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20220224215049.2845-1-dongli.zhang@oracle.com>
References: <20220224215049.2845-1-dongli.zhang@oracle.com>
Content-Type: text/plain
X-ClientProxiedBy: SA9PR13CA0099.namprd13.prod.outlook.com
 (2603:10b6:806:24::14) To BYAPR10MB2663.namprd10.prod.outlook.com
 (2603:10b6:a02:a9::20)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e8445e2c-1374-4bf2-db86-08d9f7dfc2df
X-MS-TrafficTypeDiagnostic: BN6PR10MB2020:EE_
X-Microsoft-Antispam-PRVS: 
	<BN6PR10MB20206C612A8AB50F350C1864F03D9@BN6PR10MB2020.namprd10.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	RRXsgfu+6kOdFwQr4GnMkUFNLEfkfLkpwTDvc15SHB/c1DwRU5yxgQBtyjOnk06BiADoJwHQGqzDDPPk+wOAn4w9oRQTR2nDY5Zi7BSjlEYkOORUi1GEx6UkuIQ6RMmB21TduZwqFqsO2ulORB99Bu7AmhjvwJYieU9HQzwsX2GU8VUlNy7XanXPwuevvtocgZgMM5jcoX6IaceTWj5TFAbMv+OCNUQZU2JtsQE1cN7A2whUGqw8QFWmilfdDm5yU0KOg7CzaFdDoVgEyjyIjHvujqhuj3eDLqT/ffce1gEQ34ygEDM58kIPBpBj57ikdkqwVB/pJrAumu6IsPbY19hRkJViJV0BprwVJUaogaYSjkY8E04APQ+jNbMHAuDOGQNB+ntK5mEAgTPj2a83PsIFzloI8sFvtFWz3DeYPB0urr4/H1CizMgpCJX4z1RTj9G0zHiXIVuPGgXlR06wLEh8e1xoQWhQMjX4RosswJJrFPZ2u2/vRBcUOLYTEalxX+af4pRzyPya2KBxxpnsDxwBFGcxBrg2n7J0XR6kpOorNFoCLTTDP4BpNE9rSmiIB3tFL9XTWXGrH1O4pRzaBNZWg4MKMl64B851hKJ9bj4NWw3dviSJ0xghR53ddJlVq/6HKqD6JwHVBjE9FftwsOe4eJQ9Gd5BHN6cbzEw9XZtxrRcMDXZP9AgLnO4Fn9jMQYXVMDHn28STeX90YD9Hw==
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB2663.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(1076003)(44832011)(36756003)(86362001)(2906002)(6512007)(107886003)(186003)(8936002)(2616005)(6506007)(26005)(7416002)(6486002)(5660300002)(8676002)(66556008)(508600001)(52116002)(83380400001)(66946007)(4326008)(66476007)(6666004)(38100700002)(38350700002)(316002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?fmhClmG7FvRl2yXHDfiCpmHBSHxiELkPoJe9eVuk2XeOHyf/13rtSzuLVy9+?=
 =?us-ascii?Q?K7Sxc2i16zN6bCOwHXdzhCUcTrnMdnRp+sH4XnIfR0XzKfVRpzhpx+S/MY3K?=
 =?us-ascii?Q?20ALkBD/F7jjGLmI6E+kC7z/FTECleJYcFgm6KEfM4skk7jOuH4uqEzxeY81?=
 =?us-ascii?Q?7A9y43ViR0RSfq7q7KBZ8paEnYzciBL0Q+RUH5GWggUulOjEilFN7iWSpqu9?=
 =?us-ascii?Q?cNHYD/S7MNYwYrLRWxg5AzN473EsVgKyAPCc2lfHdmSdEawKDtIXXEH3SW6+?=
 =?us-ascii?Q?9cLKIvHfQw/1LmWnb1kTbrLYkaqn2KAlIK+vLV4fv+RaCC1zg1Pn3Pd+droW?=
 =?us-ascii?Q?uOrGv8Wt6GRDhy4v2HiprQultXWovpwLKnozCvQ/Zr0E19l5O70XhuRR27MD?=
 =?us-ascii?Q?lVsALbquPgcLnfc60CnCDU3MLXi7k05r63mnBUL+RiAC8T3pcGFxoNiHO0CK?=
 =?us-ascii?Q?RTtfAqdLfc3M6qgzif3OfAR20a0JK4rgU3Dk80bZOxUNoXO+c8h4cYJpkgqy?=
 =?us-ascii?Q?Bt/C8jL483cRnwIJsUlb8jzFoxIieWXTrBqKsZ1nAtSYfG+Z5NDj0P0IFJUq?=
 =?us-ascii?Q?IyanYqWGw9Lk3+XIV3+I0K+DY69RUH8Vf5C9koX5gJq1oQCMfMLKQ5YPFvbU?=
 =?us-ascii?Q?0TlByS5mL8VY4FILhpcc5YSEOlGKyJSv7BNpXIabZOKxoQ9+NZYJeOcUKwR9?=
 =?us-ascii?Q?iDJjrcMT5jGdF9kTWfgvIk6wMpqyKdFlfP3s3bwB8WCzhRZdPCz+cbPA7BFb?=
 =?us-ascii?Q?t2PbaJqjWD/U2DiMB4wfNxf24jOa2CiUH18F2sUp4oWolE8zRdqdmpibtcMA?=
 =?us-ascii?Q?qfamQeGnLLs6MIr9aZejjDlwnyu0qZS4L4JvICscWkwEmc+CZEKpC9/kCbQm?=
 =?us-ascii?Q?5C/2N8EEfyjaTHfWudN2jxTA/4GVi8xrFHq+9hfKX7fog62MbnF4Gga99jnc?=
 =?us-ascii?Q?oaqokLjBkDBsUsIHbDiIFUU6JzjCuSkZqHl+dZ62FAhJc60VLl9Ul5SvzmXV?=
 =?us-ascii?Q?RotEg3shfvun1G3M2nPbkT3H5nOEvMGeB0R98jhTAqCIEdnvt33GYGwMaKsU?=
 =?us-ascii?Q?J1lTtlcGpuGigWelNI7KioOn0A0o7Ap1IwCRxB0wa1QeGu0f1UG42L4i1+zV?=
 =?us-ascii?Q?U4YTLFAtUrBIMOQANblWCfcICwgWN8dzfB+2bjmuEij06DVECsLV/E0zwIv3?=
 =?us-ascii?Q?pHWVQc7W1FbMBuGMF1veFv48CH1DKCSREKfySeh9uSjtc91zoVgk2yUJ4zzb?=
 =?us-ascii?Q?FMlWI7aafMB5+nDOX+sH0bHXLuvNJUC19lkTW6jlb4f8/uYxFw8WDf8REGnz?=
 =?us-ascii?Q?ib9ulbFQq48ViLAcY55cZ7P926SZDWn8sCVXBCx5K5LiIHwptiMEpDm8ZfdM?=
 =?us-ascii?Q?aECSXyeRbsfiZe5MXeMmao2LAufPr6AlDm4tNzlYrEVetTWEggWL7l/gpuCD?=
 =?us-ascii?Q?Z6wHKgvnzY1BzhJoKEHzmmcbyEV3y+UQgYtUiyUK0n2FTwTmslc14mMjSd6Z?=
 =?us-ascii?Q?17gtUdBkSCZbzfMuFi5AUGuodpwnKSqObGoFT7hyuiN35q0CAOlFiFlbsX72?=
 =?us-ascii?Q?5f5gbtVF/ggm12kj1tMYR14XyyGntSaYYiBIpFQPuy8pqhYZ49Ohq98AM5+j?=
 =?us-ascii?Q?L/uUyEoPzAdn/7CmHotxUpA=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e8445e2c-1374-4bf2-db86-08d9f7dfc2df
X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2663.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2022 21:51:07.0885
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TCNov6F9Ke5ya3RnB+oXMMm2Vqc2KZpsstQ7/hTcKQE7sMVs/u6tV4zyaUVNcHPSKZq7LGYV4EgZg59AzGqjxg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR10MB2020
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10268 signatures=684655
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0 mlxscore=0
 spamscore=0 mlxlogscore=999 adultscore=0 phishscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2202240120
X-Proofpoint-GUID: 4eWe7zao_OZm0IANtyUSQ9-DZBBJPrEh
X-Proofpoint-ORIG-GUID: 4eWe7zao_OZm0IANtyUSQ9-DZBBJPrEh

The sched_clock() can be used very early since commit 857baa87b642
("sched/clock: Enable sched clock early"). In addition, with commit
38669ba205d1 ("x86/xen/time: Output xen sched_clock time from 0"), kdump
kernel in Xen HVM guest may panic at very early stage when accessing
&__this_cpu_read(xen_vcpu)->time as in below:

setup_arch()
 -> init_hypervisor_platform()
     -> x86_init.hyper.init_platform = xen_hvm_guest_init()
         -> xen_hvm_init_time_ops()
             -> xen_clocksource_read()
                 -> src = &__this_cpu_read(xen_vcpu)->time;

This is because Xen HVM supports at most MAX_VIRT_CPUS=32 'vcpu_info'
embedded inside 'shared_info' during early stage until xen_vcpu_setup() is
used to allocate/relocate 'vcpu_info' for boot cpu at arbitrary address.

However, when Xen HVM guest panic on vcpu >= 32, since
xen_vcpu_info_reset(0) would set per_cpu(xen_vcpu, cpu) = NULL when
vcpu >= 32, xen_clocksource_read() on vcpu >= 32 would panic.

This patch always delays xen_hvm_init_time_ops() to later in
xen_hvm_smp_prepare_boot_cpu() after the 'vcpu_info' for boot vcpu is
registered.

This issue can be reproduced on purpose via below command at the guest
side when kdump/kexec is enabled:

"taskset -c 33 echo c > /proc/sysrq-trigger"

Unfortunately, the 'soft_reset' (kexec) does not work with mainline xen
version so that I can test this patch only with HVM guest on old xen
hypervisor where 'soft_reset' is working. The bugfix for PVM is not
implemented due to the lack of testing environment.

Cc: Joe Jin <joe.jin@oracle.com>
Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com>
---
Changed since v1:
  - Add commit message to explain why xen_hvm_init_time_ops() is delayed
    for any vcpus. (Suggested by Boris Ostrovsky)
  - Add a comment in xen_hvm_smp_prepare_boot_cpu() referencing the related
    code in xen_hvm_guest_init(). (suggested by Juergen Gross)
Changed since v2:
  - Delay for all VCPUs. (Suggested by Boris Ostrovsky)
  - Add commit message that why PVM is not supported by this patch
  - Test if kexec/kdump works with mainline xen (HVM and PVM)

 arch/x86/xen/enlighten_hvm.c |  1 -
 arch/x86/xen/smp_hvm.c       | 17 +++++++++++++++++
 2 files changed, 17 insertions(+), 1 deletion(-)

diff --git a/arch/x86/xen/enlighten_hvm.c b/arch/x86/xen/enlighten_hvm.c
index 517a9d8d8f94..53f306ec1d3b 100644
--- a/arch/x86/xen/enlighten_hvm.c
+++ b/arch/x86/xen/enlighten_hvm.c
@@ -216,7 +216,6 @@ static void __init xen_hvm_guest_init(void)
 	WARN_ON(xen_cpuhp_setup(xen_cpu_up_prepare_hvm, xen_cpu_dead_hvm));
 	xen_unplug_emulated_devices();
 	x86_init.irqs.intr_init = xen_init_IRQ;
-	xen_hvm_init_time_ops();
 	xen_hvm_init_mmu_ops();
 
 #ifdef CONFIG_KEXEC_CORE
diff --git a/arch/x86/xen/smp_hvm.c b/arch/x86/xen/smp_hvm.c
index 6ff3c887e0b9..9a5efc1a1633 100644
--- a/arch/x86/xen/smp_hvm.c
+++ b/arch/x86/xen/smp_hvm.c
@@ -19,6 +19,23 @@ static void __init xen_hvm_smp_prepare_boot_cpu(void)
 	 */
 	xen_vcpu_setup(0);
 
+	/*
+	 * xen_hvm_init_time_ops() used to be called at very early stage
+	 * by xen_hvm_guest_init(). While only MAX_VIRT_CPUS 'vcpu_info'
+	 * are embedded inside 'shared_info', the VM would use them until
+	 * xen_vcpu_setup() is used to allocate/relocate them at arbitrary
+	 * address.
+	 *
+	 * However, when Xen HVM guest boots on vcpu >= MAX_VIRT_CPUS
+	 * (e.g., kexec kernel), per_cpu(xen_vcpu, cpu) is NULL at early
+	 * stage. To access per_cpu(xen_vcpu, cpu) via
+	 * xen_clocksource_read() would panic the kernel.
+	 *
+	 * Therefore we always delay xen_hvm_init_time_ops() to
+	 * xen_hvm_smp_prepare_boot_cpu() to avoid the panic.
+	 */
+	xen_hvm_init_time_ops();
+
 	/*
 	 * The alternative logic (which patches the unlock/lock) runs before
 	 * the smp bootup up code is activated. Hence we need to set this up
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Thu Feb 24 22:19:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 22:19:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278643.475970 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNMSa-0006aQ-Az; Thu, 24 Feb 2022 22:19:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278643.475970; Thu, 24 Feb 2022 22:19:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNMSa-0006aJ-7Q; Thu, 24 Feb 2022 22:19:40 +0000
Received: by outflank-mailman (input) for mailman id 278643;
 Thu, 24 Feb 2022 22:19:39 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nNMSZ-0006aD-0C
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 22:19:39 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nNMSY-0007xM-IC; Thu, 24 Feb 2022 22:19:38 +0000
Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nNMSY-0003Qt-CZ; Thu, 24 Feb 2022 22:19:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=oVgAEReLhxpkkDqDeb1VQ3F8qmoOSpR99aNRGsZBfis=; b=Q5Oo6Jb1OzNEQz2hF9v41k1rAe
	vKG8b7oTPyYAdL5o6n0ApaBAVWnXeHBHFW+CwXTrWxqfm6RMeMKWm38bdTv1cygFwmIaPtSkGWaOm
	JjbC2OQaR9zxxLbkmoWgu56V+P+nz14PLvlEUhQ+Jz0Uu61i2d2ZRdDFpjVM4oPC20xo=;
Message-ID: <2d7c7a16-f46f-7de1-0b9e-c5ec46bf54a7@xen.org>
Date: Thu, 24 Feb 2022 22:19:36 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.1
Subject: Re: [PATCH v3 01/19] xen/arm: lpae: Rename LPAE_ENTRIES_MASK_GS to
 LPAE_ENTRY_MASK_GS
To: Michal Orzel <michal.orzel@arm.com>, xen-devel@lists.xenproject.org
Cc: Julien Grall <jgrall@amazon.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20220221102218.33785-1-julien@xen.org>
 <20220221102218.33785-2-julien@xen.org>
 <c87e41d4-be73-665c-aa40-22798e254012@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <c87e41d4-be73-665c-aa40-22798e254012@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit



On 22/02/2022 13:30, Michal Orzel wrote:
> Hi Julien,

Hi Michal,

> On 21.02.2022 11:22, Julien Grall wrote:
>> From: Julien Grall <jgrall@amazon.com>
>>
>> Commit 05031fa87357 "xen/arm: guest_walk: Only generate necessary
>> offsets/masks" introduced LPAE_ENTRIES_MASK_GS. In a follow-up patch,
>> we will use it for to define LPAE_ENTRY_MASK.
>>
> for is unneddded. Should be "we will use it to define..."

I fixed this one and ...

> 
>> This will lead to inconsistent naming. As LPAE_ENTRY_MASK is used in
>> many places, it is better to rename LPAE_ENTRIES_MASK_GS and avoid
>> some churn.
>>
>> So rename LPAE_ENTRIES_MASK_GS to LPAE_ENTRY_MASK_GS.
>>
>> Signed-off-by: Julien Grall <jgrall@amazon.com>
>>
>> ---
>>      Changes in v2:
>>          - New patch
>> ---
>>   xen/arch/arm/include/asm/lpae.h | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/xen/arch/arm/include/asm/lpae.h b/xen/arch/arm/include/asm/lpae.h
>> index e94de2e7d8e8..4fb9a40a4ca9 100644
>> --- a/xen/arch/arm/include/asm/lpae.h
>> +++ b/xen/arch/arm/include/asm/lpae.h
>> @@ -180,7 +180,7 @@ static inline bool lpae_is_superpage(lpae_t pte, unsigned int level)
>>    */
>>   #define LPAE_SHIFT_GS(gs)         ((gs) - 3)
>>   #define LPAE_ENTRIES_GS(gs)       (_AC(1, U) << LPAE_SHIFT_GS(gs))
>> -#define LPAE_ENTRIES_MASK_GS(gs)  (LPAE_ENTRIES_GS(gs) - 1)
>> +#define LPAE_ENTRY_MASK_GS(gs)  (LPAE_ENTRIES_GS(gs) - 1)
> 
> Incorrect indentation of (LPAE_ENTRIES_GS(gs) - 1)

... this one in my tree. I will commit it with Bertrand's reviewed-by.

Thank you for the review!

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Feb 24 22:24:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 22:24:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278650.475981 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNMXG-0007xz-TX; Thu, 24 Feb 2022 22:24:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278650.475981; Thu, 24 Feb 2022 22:24:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNMXG-0007xs-Pf; Thu, 24 Feb 2022 22:24:30 +0000
Received: by outflank-mailman (input) for mailman id 278650;
 Thu, 24 Feb 2022 22:24:30 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nNMXG-0007xm-10
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 22:24:30 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nNMXF-00082d-OX; Thu, 24 Feb 2022 22:24:29 +0000
Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nNMXF-0003mu-JC; Thu, 24 Feb 2022 22:24:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=qTJugUZnT4nVv2+/PF1cBL0sMF506Nh/3pH55iDwan4=; b=CAKGcIWCSVi1C25jhy5JiY4Duy
	7aXbgpdJqftw/rRPp2IX6Scx4l1xzD+V8tkcBbDE81GMG3tKkp5sSEg4WbWfEUH7EQoi4hS7tsnT2
	5H7Y+KnB38kApqP9+ytVO0PYFpQZ+vkraF/V1Lfpk3XETD9QUKgL2kdDaQ4/liunc44c=;
Message-ID: <5dfae695-a59c-6f03-49ee-1903f7d55296@xen.org>
Date: Thu, 24 Feb 2022 22:24:27 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.1
Subject: Re: [PATCH v3 02/19] xen/arm: lpae: Use the generic helpers to
 defined the Xen PT helpers
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Julien Grall <jgrall@amazon.com>, Stefano Stabellini
 <sstabellini@kernel.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20220221102218.33785-1-julien@xen.org>
 <20220221102218.33785-3-julien@xen.org>
 <2DB6D0E3-E220-47C1-BB01-E4679AFA34EC@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <2DB6D0E3-E220-47C1-BB01-E4679AFA34EC@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit



On 22/02/2022 15:38, Bertrand Marquis wrote:
> Hi Julien,

Hi Bertrand,

>> On 21 Feb 2022, at 10:22, Julien Grall <julien@xen.org> wrote:
>>
>> From: Julien Grall <jgrall@amazon.com>
>>
>> Currently, Xen PT helpers are only working with 4KB page granularity
>> and open-code the generic helpers. To allow more flexibility, we can
>> re-use the generic helpers and pass Xen's page granularity
>> (PAGE_SHIFT).
>>
>> As Xen PT helpers are used in both C and assembly, we need to move
>> the generic helpers definition outside of the !__ASSEMBLY__ section.
>>
>> Take the opportunity to prefix LPAE_ENTRIES, LPAE_ENTRIES and
>> LPAE_ENTRIES_MASK with XEN_PT_.
> 
> The list needs to be fixed to be SHIFT, ENTRIES and ENTRY_MASK.

I have fixed it in my tree and will commit it with...

>>
>> Note the aliases for each level are still kept for the time being so we
>> can avoid a massive patch to change all the callers.
>>
>> Signed-off-by: Julien Grall <jgrall@amazon.com>
> 
> With this fixed:
> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>

Michal's and your's reviewed-by.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Feb 24 22:27:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 22:27:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278657.475992 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNMaW-0000C8-Az; Thu, 24 Feb 2022 22:27:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278657.475992; Thu, 24 Feb 2022 22:27:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNMaW-0000C1-74; Thu, 24 Feb 2022 22:27:52 +0000
Received: by outflank-mailman (input) for mailman id 278657;
 Thu, 24 Feb 2022 22:27:51 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Z+bi=TH=oracle.com=dongli.zhang@srs-se1.protection.inumbo.net>)
 id 1nNMaV-0000Bt-04
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 22:27:51 +0000
Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com
 [205.220.165.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id fead36fe-95c0-11ec-8eb8-a37418f5ba1a;
 Thu, 24 Feb 2022 23:27:49 +0100 (CET)
Received: from pps.filterd (m0246617.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 21OM8g2O017851; 
 Thu, 24 Feb 2022 22:27:44 GMT
Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70])
 by mx0b-00069f02.pphosted.com with ESMTP id 3ecxfb03x1-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 24 Feb 2022 22:27:44 +0000
Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1])
 by aserp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 21OMKYIb094036;
 Thu, 24 Feb 2022 22:27:43 GMT
Received: from nam10-mw2-obe.outbound.protection.outlook.com
 (mail-mw2nam10lp2104.outbound.protection.outlook.com [104.47.55.104])
 by aserp3020.oracle.com with ESMTP id 3eb48473mf-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 24 Feb 2022 22:27:43 +0000
Received: from BYAPR10MB2663.namprd10.prod.outlook.com (2603:10b6:a02:a9::20)
 by CY4PR10MB1639.namprd10.prod.outlook.com (2603:10b6:910:b::21) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.17; Thu, 24 Feb
 2022 22:27:40 +0000
Received: from BYAPR10MB2663.namprd10.prod.outlook.com
 ([fe80::a0d5:610d:bcf:9b47]) by BYAPR10MB2663.namprd10.prod.outlook.com
 ([fe80::a0d5:610d:bcf:9b47%4]) with mapi id 15.20.4995.027; Thu, 24 Feb 2022
 22:27:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fead36fe-95c0-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc :
 subject : date : message-id : content-type : content-transfer-encoding :
 mime-version; s=corp-2021-07-09;
 bh=S2pQkbyG0tdJ+ARls95XNZJNZL1V2A/Z3kyE48Us1EU=;
 b=R/jWBARp6NqPCSzXs84hJtiW5Pa89FXY6dDkviorXw70uCatoUrqSRy+A36scKX0OtmM
 FsEWWFnpJvZlszlzdmatJ99+OVZ6voIA4+2jfWUqsZ6V3ZWSjhh6RBzBxl9trBhLEhVI
 1m9nXCYtbK7yp5nSPOybT9pBqGNzCw3RManHzQDkTJt2GPy3FT4B0pWcqF5q+nOy6iKa
 623Qx9Jr8XPq+rAVzOaXr57sFzZjmwh/WpBsPCFGIaomKQI06yVnM0jOh5p4PbXk59z3
 suAUXOuxEjSa09jWxkEDsHy9yI2hB9RmQ0fS+b/b/QO1rtaJlApgEUndYKC4RzyF6aod UA== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=iBKeBfkTQxWMyp4h8DT4sxMdfIZsOH1GogJNzsEcW9CocwGtILT3r5Wa9a5REBftYcnIQXNbZPFME8iYge5MOiUZcrsCpb69P7ZMe75KT4h+J31iW0SaSALCEFi0Ry8bhtaM30TKYwHxZs7GxZdNJla8WHkyv36A9OGZaWElyHUBR0HungdKoJSa3B4sALQ3H+mX3Ol3T0eAZgbFZ55o9+Zd1/r3Pk12bafRRPUV8TG+968my2+z5RUTzC8g0EbOJh/DV68rDp/OprDBjRT8RaKwWhtv188PjpYqY901D9y1M4Zex11ViF1bcly8sA86AEIkwxLwXbjNgaxKROuOlA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=S2pQkbyG0tdJ+ARls95XNZJNZL1V2A/Z3kyE48Us1EU=;
 b=HsCAfAeIPB0DfOROlR6adP03hNQSvLKYX3j5VGF8QCeKhe1t54LhFV1q9BcMdjRheIRf2uCXwU5Z7sWUzF9BrJv/h7Sb0vnLc7zkcTuyf7xKEp32eM8VQ8OpWZZcvv9wR6Mq52zxHpTWFS3qKadjygH9B7LuLa3jSYJJvYWvYpl4lylw/8Iv3eOAMFvRJJW8nmLKX5LgIxENzh/yAlPkrqd1eYWLLK80DtJN1KQfcsujUYSfPjy8LQe7vHt0bPwD+AITUSTtfYWBGTy+Vllyy1nUFoUOpv10K0f+yJUPO6wTNnYeJPxD6JLhPpWVww6Q7Iz7vCCE+JAWHadHEBPeIA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=S2pQkbyG0tdJ+ARls95XNZJNZL1V2A/Z3kyE48Us1EU=;
 b=KUcbGhfp5xpymAEIutuNLkDG9vadfvyiSm2LtLtWCXO2y8TDJeVNiXbces/S0ukFaVNO5119eMSXqJiDMxJJSr/sX50ugCS3QpWt+r9AwBg5Ipi2kX6ezSJ/P3uaDxdCisvbuNV7L3HZ42t29w/tm1rr/cHwHn7zugQjx09diXc=
From: Dongli Zhang <dongli.zhang@oracle.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: lkml <linux-kernel@vger.kernel.org>
Subject: [BUG REPORT] soft_reset (kexec/kdump) does not work with mainline xen
Thread-Topic: [BUG REPORT] soft_reset (kexec/kdump) does not work with
 mainline xen
Thread-Index: AQHYKc2TmfaW7HQJX0Cd51obFMzfDg==
Date: Thu, 24 Feb 2022 22:27:40 +0000
Message-ID: 
 <BYAPR10MB2663BBE2CEECCC4C6504B190F03D9@BYAPR10MB2663.namprd10.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
suggested_attachment_session_id: e4ef5105-6856-7ae0-2fc5-8e279b317d5e
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 76de6c41-7f92-42bf-7019-08d9f7e4de86
x-ms-traffictypediagnostic: CY4PR10MB1639:EE_
x-microsoft-antispam-prvs: 
 <CY4PR10MB16391FDBDB9BBDC0A9DB2C9FF03D9@CY4PR10MB1639.namprd10.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 MO1kBy1uCGGbDXyVTjiqJ7QLUcVr4sCIgimzSv6LfYR/r3af51/XFVmNG7zbKkw2i+BBjuajq6oYBSVHYR56Ccg14w5zpJryosV3c/Ax62SWzPzrnvLZEBilG09MKRZhBw4V8q8lvscjZh9Ydx8Qma69KSsPp3siLzUoKrQW99nRnfXIwwOrmjX5IMPEFm/0m8Gs3SAInipl5BDF7Pk176njxifHz8TcNKaUN/zXXH2qYjfFwtIZ6mNQmJja86G7LlwwvQjExXNXmYYQ3f2goGJP+Ma34cegP+Xngp8iMAD8PLBa2GLmJbCdyuCygbgrzxryjY1Z/WlmfMkYtI3a9mOZM8aoKtIWiqctAPkZmt3HskUrtK4m4LDEXEQ6kZZXyO9/XCjjhGG9JXuexcw64cwZ9vqqTgPq8bqV906vNLhP1b0XSDrlncJO5DM79JkBB+9JMcA69pW0M3xW0R3bANwnxwD0gZhws1ouh68ssOg26M4dMC+XyS8pCpPhi/jaXBAsLuVE/ETjCINFjmwQfAaoGfjeuxH4GKmVtO1zgW68HT5Hm5hEjUuN/jc7z0t9SB5RwBc2YFPK0/6qACuHSOO9bIuRrgUDdbVbzZC5gu8jsBazklc/uHldr1WdaNI7fZe2iec8gnuCfR7EApXZULpPIZmvVT+sGzTR6DeZVoWgSmUPfwywBNK99ZwRalDHws0wFmyQZZNIeJ/LFRbwJA==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB2663.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66446008)(64756008)(76116006)(66946007)(8676002)(66556008)(66476007)(2906002)(4326008)(9686003)(508600001)(8936002)(38070700005)(91956017)(86362001)(52536014)(186003)(38100700002)(83380400001)(316002)(6506007)(55016003)(33656002)(6916009)(5660300002)(7696005)(71200400001)(122000001)(44832011);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?iso-8859-1?Q?LtNTIvRHQ2UIz35RHgn1JlQ+hS4GV2k2aiiL44FpFzC1Ru5veN9/WDUu9x?=
 =?iso-8859-1?Q?bXSAZGFnKso4TRtYINMzeq9j/U87ZEpXj9GJSxIZK/GF9WQGGGKqJ+wkfP?=
 =?iso-8859-1?Q?MGlHtVAyRUL2vutvXONFWtHXm4pWwReMKQSCRHnFIkxgqP8y9Ot1H36q3b?=
 =?iso-8859-1?Q?gStJH0sIUw9TzLVDsDPKgQke4TPnfB4YOhOzSglCacI0G6UvRFt20QoIZr?=
 =?iso-8859-1?Q?Dzk20nzHTx3hRC/KGqNfx0GW3CQl4zST4VlsO/73Y494Dgt9cWAIWTWUoX?=
 =?iso-8859-1?Q?eHZ58Cxita1S6QToro6ulEmM5uV75JnC/Na6zhj67NfVq3cob/Z4pG/HhK?=
 =?iso-8859-1?Q?bDEEUTtDM6xJGVuMrEY3b2Fsd1EgLFfeOpYuWDP3jmf0apIppuTs2bqcus?=
 =?iso-8859-1?Q?KT+onPM4dGuQosr9gRBC36BAK/eNVaj+pwu2pT1PBWFG0evyaTuAerJHYf?=
 =?iso-8859-1?Q?F7jN9qxQ8PT/ja3TINGW5wpPERGzw9O7BwPxFlDvub/1BojKCRaTGQEvHZ?=
 =?iso-8859-1?Q?RYCG+0JsBzWX47IlFV6Hj2ON+h8whJ+rynGXwIY2AH2NAKZrKBlbCNN1rw?=
 =?iso-8859-1?Q?aCKVYbV01rwd7dFEwXFKkXmXaIEWyxQPFT0aN9vsm9wD7xdw292oQsFmM6?=
 =?iso-8859-1?Q?l/9AHQi3BbjW5J/fCjNF/ghjWTRzbPmksl1ZH+9NjcUrucUFsXjc3hULcv?=
 =?iso-8859-1?Q?CyIQuAEv5ZP63y9TgPkN1nq5fh2xGtQa5pKeI6lyCvMTO0LZpA2l9xEoxT?=
 =?iso-8859-1?Q?I4SmNHKZm5fUxSOnprtdBOrlBB6CFCgVapX3ZL/CFrt/7EGBFsOlppx7+F?=
 =?iso-8859-1?Q?/QyhbREhExnUWzeqwfPlM1Aw0Lb9Nkk6oxzEXdpuyJ/7f6ZNdaOOdSqGfM?=
 =?iso-8859-1?Q?2q+tmuyVwyiX0O5vH+s7JK3fKE2+IYXE+TKXeAuAabgTaFrBS4JIhjo9mJ?=
 =?iso-8859-1?Q?s71F5h4LAsjA1oBL0sIOl5NiXtkMLdFs3AILGlRO+8ABI89qTZgzePRW1E?=
 =?iso-8859-1?Q?2HWZxOTfIWMTXrIhOcB3KCtUeb+2Mr613px264FqKFhnosdCJH4nTwl1CX?=
 =?iso-8859-1?Q?4SoEVRs/uTfGZdn0CjCD4pn71ZQFQt5hDLIEsmSUgz4y3CkqNifm04ZXul?=
 =?iso-8859-1?Q?tWiiNA04DqU3HAIv+yB7c4npGD5lFR6dNdNZHOmFbY/kGI/Ugma4u5TlOo?=
 =?iso-8859-1?Q?U7O2ex4Ip+09h88JrtuM/OF1fOknSfwLOwlGiGKCkAw+uKjqLW2ixDJs12?=
 =?iso-8859-1?Q?dWNj7DPh29LNTvQUp5VS1/wu+YkNfQixThNUZSfHN/AmakqsTmxzEJGVRh?=
 =?iso-8859-1?Q?R40akrLKyb95XVe41e+EiM/axqonOcRypMlpdZctK5FzrCMcF/NjU/DBRz?=
 =?iso-8859-1?Q?00T1ZVpejwmM4pgl+Y7GrJGJe+fMGv+gr51RRSR3AHAdoe9W1M1HN1iCmI?=
 =?iso-8859-1?Q?HLI66OdRY6sjlSii7qdum8AYjCZymyUR1rUIy+7P6f3KFm8+5eZUJBiePF?=
 =?iso-8859-1?Q?+4t+FgZAqujGbil/d3BeK51vrltHh5s2gYGWm/X1JBV6xbymsmvThiSNCz?=
 =?iso-8859-1?Q?tRfNtYpEqwj5CaaBpx2veoC7hCCvQvNjhiA2I0sofzSOduIyYz62Jew2tq?=
 =?iso-8859-1?Q?CAY1sDwxDfjT5emo2AUqa5JF2FOH01IjEGET5LfU5yEDyyCPJzq0kTeelp?=
 =?iso-8859-1?Q?UYGfaXXAuMjiJIJXTEdvLHOyBRYKDPKEu1dgTMlh?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2663.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 76de6c41-7f92-42bf-7019-08d9f7e4de86
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Feb 2022 22:27:40.6342
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: FpydhbBq1ZQHoB7kiB/KAZ4dYzrlm8QMGpF/KZY7v/gT6kb5/lUZKmJLnve+iuu7CCpzkp84Ks6Cle8u2w9Jzg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR10MB1639
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10268 signatures=684655
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0
 mlxlogscore=999 adultscore=0 bulkscore=0 phishscore=0 suspectscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202240123
X-Proofpoint-GUID: ZEZV24tn7qXHqPIpLjn91YPzlsg2U9rc
X-Proofpoint-ORIG-GUID: ZEZV24tn7qXHqPIpLjn91YPzlsg2U9rc

Hello,=0A=
=0A=
This is to report that the soft_reset (kexec/kdump) has not been working fo=
r me=0A=
since long time ago.=0A=
=0A=
I have tested again with the most recent mainline xen and the most recent=
=0A=
mainline kernel.=0A=
=0A=
While it works with my old xen version, it does not work with mainline xen.=
=0A=
=0A=
=0A=
This is the log of my HVM guest.=0A=
=0A=
Waiting for domain test-vm (domid 1) to die [pid 1265]=0A=
Domain 1 has shut down, reason code 5 0x5=0A=
Action for shutdown reason code 5 is soft-reset=0A=
Done. Rebooting now=0A=
xc: error: Failed to set d1's policy (err leaf 0xffffffff, subleaf 0xffffff=
ff, msr 0xffffffff) (17 =3D File exists): Internal error=0A=
libxl: error: libxl_cpuid.c:490:libxl__cpuid_legacy: Domain 1:Failed to app=
ly CPUID policy: File exists=0A=
libxl: error: libxl_create.c:1613:domcreate_rebuild_done: Domain 1:cannot (=
re-)build domain: -3=0A=
libxl: error: libxl_xshelp.c:201:libxl__xs_read_mandatory: xenstore read fa=
iled: `/libxl/1/type': No such file or directory=0A=
libxl: warning: libxl_dom.c:51:libxl__domain_type: unable to get domain typ=
e for domid=3D1, assuming HVM=0A=
=0A=
=0A=
Neither of below works.=0A=
=0A=
# kexec -l /boot/vmlinuz-5.17.0-rc4xen-00054-gf71077a4d84b-dirty --initrd=
=3D/boot/initrd.img-5.17.0-rc4xen-00054-gf71077a4d84b-dirty --reuse-cmdline=
=0A=
# kexec -e=0A=
=0A=
or=0A=
=0A=
# taskset -c 0 echo c > /proc/sysrq-trigger=0A=
=0A=
=0A=
Thank you very much!=0A=
=0A=
Dongli Zhang=


From xen-devel-bounces@lists.xenproject.org Thu Feb 24 22:41:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 22:41:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278666.476003 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNMnh-0002YF-JY; Thu, 24 Feb 2022 22:41:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278666.476003; Thu, 24 Feb 2022 22:41:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNMnh-0002Y8-Er; Thu, 24 Feb 2022 22:41:29 +0000
Received: by outflank-mailman (input) for mailman id 278666;
 Thu, 24 Feb 2022 22:41:27 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nNMnf-0002Y2-R9
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 22:41:27 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nNMnf-0008L2-Bh; Thu, 24 Feb 2022 22:41:27 +0000
Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nNMnf-0004qb-5x; Thu, 24 Feb 2022 22:41:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject:
	From:References:Cc:To:MIME-Version:Date:Message-ID;
	bh=xmXGpcqyX+h7bR2xSKnSZVOKSdzZSh3HbFSxhKW7aBk=; b=2hp2M0N/1lXlk8awxZSeoiNyEN
	pFHkEAiPra8gRnVZg5buHJO47oxz9uOSQlYrh54gDCV5HrFHpDOiXyLoA0ZytKEolP4WC2Mxn/kt4
	fh23CetXhh81UcRCJbxofb1rOVDbI5cxmBakBPBcYBDt0yVOea+XiVDTaBPgEj/Y/c48=;
Message-ID: <7a92b31a-ff09-3263-c25f-aba420adcce3@xen.org>
Date: Thu, 24 Feb 2022 22:41:25 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.1
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Julien Grall <jgrall@amazon.com>, Stefano Stabellini
 <sstabellini@kernel.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20220221102218.33785-1-julien@xen.org>
 <20220221102218.33785-4-julien@xen.org>
 <66B2C3AB-A61C-4CC7-8249-AA925B2774FD@arm.com>
From: Julien Grall <julien@xen.org>
Subject: Re: [PATCH v3 03/19] xen/arm: p2m: Replace level_{orders, masks}
 arrays with XEN_PT_LEVEL_{ORDER, MASK}
In-Reply-To: <66B2C3AB-A61C-4CC7-8249-AA925B2774FD@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit



On 22/02/2022 15:55, Bertrand Marquis wrote:
> Hi Julien,

Hi Bertrand,

>> On 21 Feb 2022, at 10:22, Julien Grall <julien@xen.org> wrote:
>>
>> From: Julien Grall <jgrall@amazon.com>
>>
>> The array level_orders and level_masks can be replaced with the
>> recently introduced macros LEVEL_ORDER and LEVEL_MASK.
>>
>> Signed-off-by: Julien Grall <jgrall@amazon.com>
> 
> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
> 
> One open question: At this stage the convenience aliases that you
> kept in include/asm/lpae.h are used in a very limited number of places.

I am not sure I would call it very limited:

42sh> ack "(FIRST|SECOND|THIRD)_(ORDER|SHIFT|MASK)" | wc -l
65

That's including the 9 definitions.

> Could we remove those and use only XEN_PT_LEVEL_* to make the
> code a bit more coherent.

I made an attempt in the past and it resulted to longer line in 
assembly. So I am on the fence to whether the aliases should be 
completely removed.

At the same time, XEN_PT_LEVEL(...) is handy for places where we don't 
know at compile time the level.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Feb 24 22:56:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 22:56:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278673.476014 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNN1Z-00045C-Rd; Thu, 24 Feb 2022 22:55:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278673.476014; Thu, 24 Feb 2022 22:55:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNN1Z-000455-O3; Thu, 24 Feb 2022 22:55:49 +0000
Received: by outflank-mailman (input) for mailman id 278673;
 Thu, 24 Feb 2022 22:55:49 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nNN1Z-00044z-5l
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 22:55:49 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nNN1V-00009F-5O; Thu, 24 Feb 2022 22:55:45 +0000
Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nNN1U-0005ww-Vo; Thu, 24 Feb 2022 22:55:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject:
	From:References:Cc:To:MIME-Version:Date:Message-ID;
	bh=kiGNoNOATm3G6K6BFFu/M9wqslarFhAG0JWMOeHad5A=; b=oqVUY0vukjnHaoEUa+trZAcMQW
	LQmmVNNrD+TVZ0tOdo0fAp73ZcmY1GQNbKOpFri2+Hkdd+OS3d+PIxcmH+LGqR9Xx85oLKl4NbDtR
	LgAFlMx/TB1iAiH10UU13LNqbPWCWivOx7Dr5r9pgP5xlCY62N1NH1nayRS+ICYGIjes=;
Message-ID: <78543fe5-1dde-41b8-e28d-de2cf22fc87f@xen.org>
Date: Thu, 24 Feb 2022 22:55:42 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.1
To: Jan Beulich <jbeulich@suse.com>, Juergen Gross <jgross@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220203131418.1319-1-jgross@suse.com>
 <20220203131418.1319-2-jgross@suse.com>
 <a35bb9ba-e2be-f73e-9272-906bc09d9b6e@xen.org>
 <93e50bc4-6e53-b753-c520-7d1d0a5a5f5a@suse.com>
 <7ca05a74-6b65-f9cb-f524-28d700a7d0e4@suse.com>
From: Julien Grall <julien@xen.org>
Subject: Re: [PATCH v2 2/2] xen/include/public: deprecate GNTTABOP_transfer
In-Reply-To: <7ca05a74-6b65-f9cb-f524-28d700a7d0e4@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Jan,

On 16/02/2022 09:29, Jan Beulich wrote:
> On 16.02.2022 08:20, Juergen Gross wrote:
>> On 15.02.22 22:13, Julien Grall wrote:
>>> As a side note, should we also update SUPPORT.md?
>>
>> Good question.
> 
> I'm not sure here either - talking about individual hypercall sub-ops
> seems overly small granularity to me for this kind of doc. Plus I
> don't view deprecation and de-supporting as the same thing. The latter
> would mean to render unsupported any old XenoLinux which may still be
> in use, all of the sudden.

I understand this would result to unsupport some old OSes (not clear how 
old). However, from what Juergen said this feature is untested.

To me it sound like we are not confident that we could security support 
this feature.

So I am not sure to understand why we only want to deprecate it.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Feb 24 23:48:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 24 Feb 2022 23:48:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278680.476024 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNNqn-0000nz-Pb; Thu, 24 Feb 2022 23:48:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278680.476024; Thu, 24 Feb 2022 23:48:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNNqn-0000ns-Mf; Thu, 24 Feb 2022 23:48:45 +0000
Received: by outflank-mailman (input) for mailman id 278680;
 Thu, 24 Feb 2022 23:48:44 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=oTFz=TH=citrix.com=prvs=047b345d9=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nNNql-0000nm-W9
 for xen-devel@lists.xenproject.org; Thu, 24 Feb 2022 23:48:44 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4a76fd1e-95cc-11ec-8539-5f4723681683;
 Fri, 25 Feb 2022 00:48:41 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4a76fd1e-95cc-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645746521;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=X+XSqHV7lU0CNkmac3rR6tHMGH3mlOEN46r4Dp2ok3M=;
  b=bjDxiy7sOwPun70BszSeE1gVKMKoizyL/izOFEeeZtcB1vnojO61Bprw
   8IcPjnF25G6a8S8kPlmMA15gqTEYj0VB79QsEG3oS0w8adMTq/cZwHxeI
   0L7zL9g9QGtLn2AHLPVSxMSQ2J9xppviXvAO6uE0VDHTd+N2Jt4ApXYMv
   A=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 65362840
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:fIeCEqhBuCZ7LaLARo6fdrGkX161fRAKZh0ujC45NGQN5FlHY01je
 htvXGiCbKmOYjanc493YYXkpBxTup+Ez9FmSgJk+SFhFX4b9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M78wIFqtQw24LhWVnR4
 YiaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV
 efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9
 TlDiXC/YQAwEqPLp/0laQQGOQ4iDOpJwJTqB1Hq5KR/z2WeG5ft6/BnDUVwNowE4OdnR2pJ8
 JT0KhhUMErF3bjvhuvmFK883azPL+GyVG8bklhmwSvUErANRpfbTr+RzdRZwC0xloZFGvO2i
 88xN2c0Mk6QP0Un1lE/Jbwludq1iX/FTjRBsGieq/cR7VaDw1kkuFTqGIWMIYHbLSlPpW6Ho
 krW8mK/BQsVXPSPxDzA/n+yi+vnmSLgRJlUBLC+7uRtglCY2ioUEhJ+fVmxrOS9i0W+c8lCM
 EFS8S0rxZXe72TyEIO7BUfh5ifZ4FhMALK8DtHW9imK04ba5DmAPlIZEBRuNO1hu/cdaBoDg
 wrhc8zSORRjt7icSHS4/7iSrC+vNSV9EVLudRPoXiNevYC9/dhbYgbnC486TfXr1oGd9STYn
 mjSxBXSkYn/miLiO0+T2VncywyhqZHSJuLezlWGBzn1hu+ViWPMWmBJ1bQ5xasYRGp6ZgPY1
 JThpyR4xLpQZX1qvHbQKNjh5Jnzu5643MT02DaD5aUJ+TW34GKEdotN+jx4L0oBGp9aJWK3P
 BWP41gOvMQ70J6WgUlfOdzZ5yMCl/WIKDgYfqqMMoomjmZZLmdrAx2ClWbPhjuwwSDAYIk0O
 IuBcNbEMJrpIf8P8dZCfM9EieVD7nlnnQv7HMmnpzz6gev2TCPEEt8tbQrRBt3VGYvZ+W05B
 f4EbJDUo/ieOcWjChTqHXk7dghbfSBmXsmt86S6tIere2JbJY3oMNeIqZsJcI15haVF0ODO+
 3C2QEhDz1Tjw3bALG23hrpLMdsDgb4XQaoHABER
IronPort-HdrOrdr: A9a23:GWfQ7aM5XB/YJMBcT2H155DYdb4zR+YMi2TDiHoedfUFSKOlfp
 6V8MjzjSWE9Ar4WBkb6LS90DHpewKTyXcH2/hvAV7EZnimhILIFvAs0WKG+Vzd8kLFh5ZgPM
 tbAspD4ZjLfCVHZKXBkUmF+rQbsaK6GcmT7I+0pRoMPGJXguNbnn1E426gYxdLrWJ9dP0E/e
 +nl7N6Tk2bCBIqh6qAdxw4dtmGg+eOuIPtYBYACRJiwhKJlymU5LnzFAXd9gsCUhtUqI1Ssl
 Ttokjc3OGOovu7whjT2yv49JJNgubszdNFGYilltUVEDPxkQylDb4RGYFq/QpF5d1H2mxa1+
 UkkC1QefibLEmhJ11dlCGdnzUIFgxes0MKh2Xo2kcL6vaJOg7SQ/Ax9L6xNCGptnbI9esMo5
 6ilQiixupqJAKFkyLn69fSURZ20kKyvHo5iOYWy2dSSI0EddZq3MYiFW5uYd899RjBmcsa+S
 hVfbbhzecTdUnfY2HSv2FpztDpVnMvHg2eSkxHvsCOyTBZkH1w0kNdnaUk7zs93YN4T4MB6/
 XPM6xumr0LRsgKbbhlDONERcesEGTCTR/FLWrXK1X6E6MMPW7LtvfMkfgIzfDvfIZNwIo5mZ
 zHXl8dvWkue1j2AcnLx5FP+gClehT1Yd0s8LAp23FUgMyIeFOwC1zwdLkHqbrVn8ki
X-IronPort-AV: E=Sophos;i="5.90,134,1643691600"; 
   d="scan'208";a="65362840"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=lAmivvg0V4n2AwPU9ATZ4vYVXeFp74HCRmTPyRiXyVrbqRTnXRO+/1DVjBSAyQoQNydhhuFet5Ka2PK0RPQffgQZn0pWPQ1+Sx07Zk55P8sl/SyqbAHNgETr0yOv0PrdzGyjJbjfrD+D4K8vRVWBIkgjbjUFPXRe+x3ikM9h9KfsVFkY36xnhsXagIAsmHb7w3+KHct1t3kKcgi17M78i/UD1u5rDrG/kiHUcag+nel+HgoHs7i3qsgoQCEdKFveRtUhtIrR99ZkCn6qGqvoy16XVkeacQ2KCMj4ilqv8Vs4/IjfzX7iJtSnFhJaDsa0ZEqh+rna0nP4CuwHv8if7w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=X+XSqHV7lU0CNkmac3rR6tHMGH3mlOEN46r4Dp2ok3M=;
 b=Z8KyVfB05fT9qHP77x3ijUxHHVXG/qbLn+k29r6NAQpHnywVLEV/Q2wL2bZfFbllh7Gcbs0vFl59lBo78bsQCtCMPkWdEbCXl6CZqxB7zF1biTkwJ7dMJy/ncsmHfYWwQY/UeeaRR4BUAzqtgEshINLcn5p7ekwlKY9OAKA7mOVM+ZvwWa8htMPDwv/onV60qF322RMDnDQTDbkMM5jeSEoAf0cXpFZJTW8CXdcT2+j9Atdw9iyqDkSul6G8ViewjO9W2A87Yl0SJGCtzxj74CYuj8Ench0VVdFMn9zQLA5a8e7T12QiWtDr0HzuN4BEGafE+Z0YLNPano7jd8OJfA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=X+XSqHV7lU0CNkmac3rR6tHMGH3mlOEN46r4Dp2ok3M=;
 b=GM+4TeVMGzH81+d7wsM9btJ0wT4e1QqdXGeMCEz1uiKoXP5X7UZzRUCbesUw579jf3OLoP7p+1WqQyGehc+dxvC53wte36d9P5938tFd3lBdk8EJsWR/nn3mNl8tVGJlfKjnSL2OaOc1efX3a6E/zXb9dAHPJFWTfHnrYIojDYE=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Wei Liu <wl@xen.org>, Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH] x86: make embedded endbr64 check compatible with older
 GNU grep
Thread-Topic: [PATCH] x86: make embedded endbr64 check compatible with older
 GNU grep
Thread-Index: AQHYKWdr96DvHtmiCE6n5nuoqf1KFayifeMAgAAQ3YCAANCCAA==
Date: Thu, 24 Feb 2022 23:48:34 +0000
Message-ID: <609a06a9-20ab-4315-0ffa-0b0e76d28c8e@citrix.com>
References: <ceaae3c8-0c35-efc1-c7bc-f44364ce29e4@suse.com>
 <cced4ec0-f522-9273-b10c-0e652bcc5aa3@citrix.com>
 <d6392c5c-b70d-6efd-f49e-567e703d64a3@citrix.com>
In-Reply-To: <d6392c5c-b70d-6efd-f49e-567e703d64a3@citrix.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 89c808d3-bce1-40f5-07fb-08d9f7f02bb0
x-ms-traffictypediagnostic: BN7PR03MB4340:EE_
x-microsoft-antispam-prvs: <BN7PR03MB4340F208DFF0E47DF5122725BA3D9@BN7PR03MB4340.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: QYb6AKOTAdvTsLX1Muzmq5G4azGoeGnekjQeYn0s6LMjpGZxYWWXV/Al/F00VPhzEupFsrcNtuHQ8gmWhx3V0y2HAxRZOu3lFK96wR/f0+Id5tTm1yfSnXyPm8HDwuEnYVDz86RwA7pxdFSk08JmcaNQrH06Tnvkt+w2+gySHVeE0S/GHHJJFCrSqCe8Ok6gdwyzlzHc+ZVd5THliNl59nc/Eo2TvaNzXZFPk4zErhA4qcO/eKDFG2yCUEUf3+csHpUU+3Y04DJqde9HnEG/joS6k5VFvWsw8n5kfkzsQdBZKypQlV/tcbfuZNWGdpBAoX0fx3+XTqNra1D2cz04w8L6djPHoqMKHaCF4e1KO5AX021MRBFECIkqUMRQy7qgg66f5fGfO4ukjfB7qdrpB/u4BFCDTrtcfx95DjQgsB8PvH3URmq0PxZK9PVDjcXFWrWi+AL+ID5534TI4xt5z1Vbc3BBq3pXJ4TAQHk7nBbh+Bx1bRMSzK//V8al943CY0NPohVIzA7/e9pPu8Bl3yDWdIa45f6t3fDTvUu1Ma5teDrXnj0rlFsYnQdxT0c7w74120YPiovqcOokEAJHjHO2okLQVwG5ApVfNX3fKtpB4pQZmXoQ+KH9kXRQSIipaeWn1ZAUSYl2GchU6qVfCzDKgkVeEpAlRdR6+7gJr6GnXleQAvKxmW67I0xYihRwid2UeOH6JsTLdOwcFumpiiPcOwDZj1HlbNrBKjhIBVsmwrZiaZInPBo4HnC7oqDzDiBR9KYIrpxDhL2UFu+E21JuVL+q1OyzFxIe+WvPC7pypl+I/PGoA1GFWZm6QfrEKBDGkhQPLh7Tg+etE0XI8UFC0fInse0bwhzgwbXxbjK3da/spSMLuD8TKzYTg/UBAFFCKzbGNmXdnTAG1abZUg==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66946007)(36756003)(38100700002)(2616005)(6512007)(186003)(31686004)(76116006)(91956017)(82960400001)(122000001)(26005)(107886003)(66446008)(64756008)(66476007)(4326008)(8676002)(66556008)(2906002)(316002)(54906003)(110136005)(4744005)(31696002)(8936002)(53546011)(6506007)(86362001)(38070700005)(966005)(508600001)(5660300002)(6486002)(71200400001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?RVJHKy93THJsYWJqSlJvSXh2cEtQa1pVMXlaMmtvVlF2RVZUVTd3WjhxWHpU?=
 =?utf-8?B?ZXEvMG1PUThZS2pLL1pVZ2hyR0ZjRVZpRnhhUzQwQmRVaDBML1o2dDVFRWpa?=
 =?utf-8?B?ZUhRSkd2WlloMEtkcmIzU3pQV3pseEVuSVMzWXJBWTk3blNEenBjQ3ZZT3pO?=
 =?utf-8?B?dHUyVkxUUTNTZkl5RmFqVi82RTNIenRleU05RURJTHhaQVZTOUdRaWZZSHM1?=
 =?utf-8?B?S1IvU0RuVm1vdmd1YWhoT0pYb2psRlJsbzBMRkZpNDRWaUFxOUtTWGZWM0M5?=
 =?utf-8?B?bWZBRnF5Q2NoOU05V0Q0dW11QURwU3g4MWtzMzdqN2p6ZmVqL2xTYkVTOE1X?=
 =?utf-8?B?YllGbTkrMXk3R2ZRREpVYm14QWdHcXBpUldpaEgybTZBRW5TczlHMHcxbzRV?=
 =?utf-8?B?SWNRUW9BdDRGTHUvY0lEM2VtZGtnbStSZzdXVDJSM1c0c1d5WFJEaTJCK2Rw?=
 =?utf-8?B?dXFRSmFYUnlwYnBrdXZTUXJEc2lPYjMxb0xvdmlkVUk0TDRwZWJZWXU2dm9a?=
 =?utf-8?B?Z3Z2QmRnUFhUUnZQaGROeWt6bGNkQUNNMk02R3pUMjlMVHVhZnczejhrY2Nz?=
 =?utf-8?B?V2RMRVNkN0tMZUNnSWhZN1NCeS9ITVN4WXYxZXFFL0JFcHg3bW5IeTNmN2Vh?=
 =?utf-8?B?OEJMU0tqbmI4ZFFLQ01CYlRHTFhvZUpqbFIrR3lycENub1FmV0t5aDdsdHhE?=
 =?utf-8?B?Z2RielZCZUNYSTJiUmZpVXhuRm40c2xnamdhUnBJVE5WYXBhWFNVMlZ2Sm1t?=
 =?utf-8?B?ZUNGKzFpZjBuanhkWWFXWWVWUXhjVk9mQ1dYbjRTTzNXb1E5NFBWMEtKYkVm?=
 =?utf-8?B?MUlWS0wvaGRIL0xtVVI1TDEyRU9jQWk3RHM0RlBMYmFkV2hrdEhXMkdtejdW?=
 =?utf-8?B?azRJSTZBNkNFSk1XYWVQM0xFQTBLZDV3bUczaXlJYnNyL2NhT2l4NEV0RytM?=
 =?utf-8?B?azExT1lJS0p0WnJrZ3lKTjhEZG1Ec2RBcE9HcVVGWk50d0pWdjdieC9ncWxs?=
 =?utf-8?B?RjQ5dUVjYW80L3JYRld1aVFVRUZEVFIxU3Vibm9rU05VUkVPNDZkUTkrQUt4?=
 =?utf-8?B?RkZOcFJETGI3WHpCdG5XQ1JCa0VNS2RKTisvTitqYldSS21vNEcwOFVKN2lq?=
 =?utf-8?B?M2lVZ0NqOWs4bjZacGpmdVNKdk85ZndzY1RJWEpqZHV5RWJkQ212ZXZ5OFVk?=
 =?utf-8?B?dFRvUSt4eTFIVUFHL1pqMnFKOWJDVnBrdTVwdVBpeUp1UHlkeHZYRGQ4VThG?=
 =?utf-8?B?UjJyR21JOTNZS3dxQStqLytvQ0xQNGlsemNWMGh4cWlZS082Y0F6eGpTb2xj?=
 =?utf-8?B?cnZ1MGlJMlRqdExsNUd6VndIdDc5K25pL1lWRFhnMkRZRE0veWp4TlNBNktY?=
 =?utf-8?B?V2R1ejBFcm5CNDJ0T0xjbWdsME1MTnl4TjJCUXl0T3pHQmNYWEV6NVl3M3kr?=
 =?utf-8?B?SzVvekdKWjV3S2IyZk9mMHhkTDI2WlorV0ZEM2phemZFZE1rWkovc3p1WWEx?=
 =?utf-8?B?VUtrWGN0WFZDdlUveXFSZkJ5YmYzeVJlWVBQOVJDNmlacTBaOTd6Nmg0VWY1?=
 =?utf-8?B?ci9oMkcxTzZPaDQyT2s0RG40c3NzL1laNUhoNDd3NzhiRzBudjhUZFgwa2Zl?=
 =?utf-8?B?T3FLa2szRVlqaHlaTHY1L1hHVkcyMjYrbTFrZFBJeC9USTB3RGpCdlZTNlR4?=
 =?utf-8?B?US96SXRRRG9aT3IwT1Z3VEpIenJxcDBaMnRTN05ZOEVRY0E3RUhEUUFueVBt?=
 =?utf-8?B?SlhlbmJtTSs3amdjUm9EMDZqQjNJYzU3MDY5Y25WaXppcGxoUzVIUUNtdEZw?=
 =?utf-8?B?L0gwUHRrWVJQQnlRSGh2cVZPcm5DQWE1T2djMGNSTm5xR2pleUd6RXl2Rkhy?=
 =?utf-8?B?WWpSWndCS3hVN2kzY2xaeGsyTXArbVJVMkFSNjlMZVVwNzBhYUdiM0l3eDlL?=
 =?utf-8?B?VlBUOUsyb1NtWTd4clhCVVZWRlQ4cVl6c2EwQ1o4L1FoWDUxVjdidnA3b0ls?=
 =?utf-8?B?V21VaU4xdWxpSzZqSWtCdFlJOVRWVWpOenhiRHB3OUlzblM2N0tkTkFQd3g1?=
 =?utf-8?B?YmZ3WDBsbXY3ZE4rZU5iMUZ5WG9mcVNVelRJSUJkR0xqT1diRGxUZGZSenF2?=
 =?utf-8?B?bk93dzZmNmhhOElEOS9pWUhxYlYydmt5Z3pqSGdwVVZPdWlzL0F0L2QvU1Uz?=
 =?utf-8?B?TU1qMEFhRGdTVnFWS0hGMnpCeUpRWFRvNmdEUEVpZnRBK1dUZEVBbys4bDAw?=
 =?utf-8?B?eE1HeXJHYVpyRHZuODJybDVnTHhBPT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <64154F183EDC2040AB1BD66FA1354DE2@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 89c808d3-bce1-40f5-07fb-08d9f7f02bb0
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Feb 2022 23:48:34.5398
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: cRyrgV9f9ldi9HkORczU2qiFr+EjJvDokTAdw18fpBh0wCO98WM3H9D+5mu8ZrTSDVjQxsnMd9GNVQP4+1nWXOlpOb/Q+39yN7Xs/ifCrIQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB4340
X-OriginatorOrg: citrix.com

T24gMjQvMDIvMjAyMiAxMToyMiwgQW5kcmV3IENvb3BlciB3cm90ZToNCj4gT24gMjQvMDIvMjAy
MiAxMDoyMSwgQW5kcmV3IENvb3BlciB3cm90ZToNCj4+IE9uIDI0LzAyLzIwMjIgMTA6MTQsIEph
biBCZXVsaWNoIHdyb3RlOg0KPj4+IFdpdGggdmVyc2lvbiAyLjcgSSdtIG9ic2VydmluZyBzdXBw
b3J0IGZvciBiaW5hcnkgc2VhcmNoZXMsIGJ1dA0KPj4+IHVucmVsaWFibGUgcmVzdWx0czogT25s
eSBhIHN1YnNldCBvZiB0aGUgc3VwcG9zZWQgbWF0Y2hlcyBpcyBhY3R1YWxseQ0KPj4+IHJlcG9y
dGVkOyBmb3Igb3VyIHBhdHRlcm4gSSd2ZSBuZXZlciBvYnNlcnZlZCBhbnkgbWF0Y2guIFRoaXMg
c2FtZQ0KPj4+IHZlcnNpb24gd29ya3MgZmluZSB3aGVuIGhhbmRpbmcgaXQgYSBQZXJsIHJlZ2V4
cCB1c2luZyBoZXggb3Igb2N0YWwNCj4+PiBlc2NhcGVzLiBQcm9iZSBmb3Igc3VwcG9ydCBvZiAt
UCBhbmQgcHJlZmVyIHRoYXQgb3ZlciB0aGUgb3JpZ2luYWwNCj4+PiBhcHByb2FjaC4NCj4+Pg0K
Pj4+IEZpeGVzOiA0ZDAzNzQyNWRjY2YgKCJ4ODY6IEJ1aWxkIGNoZWNrIGZvciBlbWJlZGRlZCBl
bmRicjY0IGluc3RydWN0aW9ucyIpDQo+Pj4gU2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpi
ZXVsaWNoQHN1c2UuY29tPg0KPj4gTG9va3MgcGxhdXNpYmxlLsKgIFRlbnRhdGl2ZSBhY2ssIGJ1
dCB0aGlzIGRlZmluaXRlbHkgbmVlZHMgYSBmdWxsIHJ1bg0KPj4gdGhyb3VnaCBDSSBiZWZvcmUg
Y29tbWl0dGluZy7CoCBMZXQgbWUga2ljayBzb21ldGhpbmcgb2ZmLg0KPiBTdGFydGVkIG5vdzoN
Cj4NCj4gaHR0cHM6Ly9naXRsYWIuY29tL3hlbi1wcm9qZWN0L3Blb3BsZS9hbmR5aGhwL3hlbi8t
L3BpcGVsaW5lcy80Nzg1MDg0NTkNCj4gaHR0cHM6Ly9jaXJydXMtY2kuY29tL2J1aWxkLzYyNTUx
OTYwMTg4MzU0NTYNCg0KRXZlcnl0aGluZyBpcyBncmVlbi7CoCBHb29kIHRvIGNvbW1pdC4NCg0K
QWNrZWQtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+DQoNCn5B
bmRyZXcNCg==


From xen-devel-bounces@lists.xenproject.org Fri Feb 25 00:16:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 00:16:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278687.476036 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNOHN-0004gW-Je; Fri, 25 Feb 2022 00:16:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278687.476036; Fri, 25 Feb 2022 00:16:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNOHN-0004gP-F3; Fri, 25 Feb 2022 00:16:13 +0000
Received: by outflank-mailman (input) for mailman id 278687;
 Fri, 25 Feb 2022 00:16:11 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Z5Py=TI=wind.enjellic.com=greg@srs-se1.protection.inumbo.net>)
 id 1nNOHL-0004gJ-OO
 for xen-devel@lists.xen.org; Fri, 25 Feb 2022 00:16:11 +0000
Received: from wind.enjellic.com (wind.enjellic.com [76.10.64.91])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id 1ec6ffc0-95d0-11ec-8eb8-a37418f5ba1a;
 Fri, 25 Feb 2022 01:16:05 +0100 (CET)
Received: from wind.enjellic.com (localhost [127.0.0.1])
 by wind.enjellic.com (8.15.2/8.15.2) with ESMTP id 21P0G3Lt005995;
 Thu, 24 Feb 2022 18:16:03 -0600
Received: (from greg@localhost)
 by wind.enjellic.com (8.15.2/8.15.2/Submit) id 21P0G2Hk005994;
 Thu, 24 Feb 2022 18:16:02 -0600
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1ec6ffc0-95d0-11ec-8eb8-a37418f5ba1a
Date: Thu, 24 Feb 2022 18:16:02 -0600
From: "Dr. Greg" <greg@enjellic.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: xen-devel@lists.xen.org
Subject: Re: IGD pass-through failures since 4.10.
Message-ID: <20220225001602.GB5755@wind.enjellic.com>
Reply-To: "Dr. Greg" <greg@enjellic.com>
References: <20220214060011.GA24404@wind.enjellic.com> <198ef291-4dee-ddac-aef6-8451bc1e880c@suse.com> <20220217201534.GA29303@wind.enjellic.com> <dc1a4483-7dca-aa72-6b86-4217e6840efb@suse.com> <20220222185230.GA15532@wind.enjellic.com> <b9a77707-5d93-050a-f9ee-da284dbd0eac@suse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <b9a77707-5d93-050a-f9ee-da284dbd0eac@suse.com>
User-Agent: Mutt/1.4i
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.2.3 (wind.enjellic.com [127.0.0.1]); Thu, 24 Feb 2022 18:16:03 -0600 (CST)

On Wed, Feb 23, 2022 at 09:59:48AM +0100, Jan Beulich wrote:

Hi, I hope the end of the week is going well for everyone.

> On 22.02.2022 19:52, Dr. Greg wrote:
> > On Fri, Feb 18, 2022 at 08:04:14AM +0100, Jan Beulich wrote:
> >> On 17.02.2022 21:15, Dr. Greg wrote:
> >>> On Mon, Feb 14, 2022 at 09:56:34AM +0100, Jan Beulich wrote:
> >>> In the case of the logs above, the following command sequence is being
> >>> executed upon termination of the domain:
> >>>
> >>> # Unbind devices.
> >>> echo 0000:00:14.0 >| /sys/bus/pci/drivers/pciback/unbind
> >>> echo 0000:00:02.0 >| /sys/bus/pci/drivers/pciback/unbind
> >>>
> >>> # Rebind devices.
> >>> echo 0000:00:14.0 >| /sys/bus/pci/drivers/xhci_hcd/bind
> >>> echo 0000:00:02.0 >| /sys/bus/pci/drivers/i915/bind
> > 
> >> ... you may still want to try replacing these with
> >> "xl pci-assignable-add ..." / "xl pci-assignable-remove ...".
> > 
> > We tested using the 'xl pci-assignable-add/remove' sequences and we
> > believe this may have resulted in the proper return of the devices to
> > dom0 but haven't been able to verify that since the Windows VM is now
> > throwing the VIDEO_TDR error.
> > 
> > Unless we are misunderstanding something the 'xl
> > pci-assignable-remove' sequence requires the manual re-binding of the
> > devices to their dom0 drivers.

> Hmm, I thought drivers would be rebound, but I'm not a tool stack
> person.  Looking at libxl__device_pci_assignable_remove() at least
> support this assumption of mine. You did use the command's -r
> option, didn't you?

No we weren't and I now see the -r option.

We have already re-worked our setup scripts to use pci-assignable-add
and will verify the -r option works as advertised, thanks for the tip.

We had our lab machine broken for a couple of days where it wouldn't
start an IGD pass-through session in any way shape or form.  We got
that sorted out and will now go back to 4.15.2 and verify what works
and doesn't work and report back.

> Jan

Have a good weekend.

As always,
Dr. G.W. Wettstein, Ph.D.   Enjellic Systems Development, LLC.
4206 N. 19th Ave.           Specializing in information infra-structure
Fargo, ND  58102            development.
PH: 701-281-1686            EMAIL: greg@enjellic.com
------------------------------------------------------------------------------
"On the other hand, the Linux philosophy is 'laugh in the face of
 danger'.  Oops.  Wrong one.  'Do it yourself'.  Thats it."
                                -- Linus Torvalds


From xen-devel-bounces@lists.xenproject.org Fri Feb 25 00:55:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 00:55:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278694.476047 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNOta-0000Nn-M7; Fri, 25 Feb 2022 00:55:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278694.476047; Fri, 25 Feb 2022 00:55:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNOta-0000Ng-Ir; Fri, 25 Feb 2022 00:55:42 +0000
Received: by outflank-mailman (input) for mailman id 278694;
 Fri, 25 Feb 2022 00:55:41 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=FJge=TI=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nNOtZ-0000Na-Fa
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 00:55:41 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a50ca268-95d5-11ec-8539-5f4723681683;
 Fri, 25 Feb 2022 01:55:38 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 9045061D11;
 Fri, 25 Feb 2022 00:55:36 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8BAD3C340E9;
 Fri, 25 Feb 2022 00:55:35 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a50ca268-95d5-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1645750536;
	bh=DbFOq4HunJam2EEaJwAa5d2U+Om0/qSLfgcaPUNfH8I=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=jdbajwZVNkZAsPBCEuDiS5Z0vhRVdt77QOTN5SeyiLv52Y7vuS7F2g5aF7sTXNToq
	 /q+mh62ycF20QfY89PZNcCbKNvuazx5Y9CGQavL83NQC/i4pPiCOG+3zk36uhRa/9c
	 RYiDQX7WwkDGNtw1KPEGPXUcnwI9KoDr6xcLC8J1p85ETVZ7oDemdtzxdPH1DbfaX8
	 uEO+UCx4foNIyY0OLe3IS06L+SIsdaRupEoslfD1p6BBY3f2KPuoXvnhmmSf7mz7lp
	 fK7VSQtHW72WV4xIO6zPBRRe+kgba3dFeZTaJghn8HMb4l5aLZJzuFv+6dryl1ZkwN
	 aBYewnD2jWtBg==
Date: Thu, 24 Feb 2022 16:55:34 -0800 (PST)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Wei Chen <Wei.Chen@arm.com>
cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
    "julien@xen.org" <julien@xen.org>, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    Bertrand Marquis <Bertrand.Marquis@arm.com>, 
    Penny Zheng <Penny.Zheng@arm.com>, Henry Wang <Henry.Wang@arm.com>, 
    nd <nd@arm.com>
Subject: Re: Proposal for Porting Xen to Armv8-R64 - DraftA
In-Reply-To: <PAXPR08MB7420A01809B84E04E196793F9E3D9@PAXPR08MB7420.eurprd08.prod.outlook.com>
Message-ID: <alpine.DEB.2.22.394.2202241606450.239973@ubuntu-linux-20-04-desktop>
References: <PAXPR08MB7420A01809B84E04E196793F9E3D9@PAXPR08MB7420.eurprd08.prod.outlook.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

Hi Wei,

This is extremely exciting, thanks for the very nice summary!


On Thu, 24 Feb 2022, Wei Chen wrote:
> # Proposal for Porting Xen to Armv8-R64
> 
> This proposal will introduce the PoC work of porting Xen to Armv8-R64,
> which includes:
> - The changes of current Xen capability, like Xen build system, memory
>   management, domain management, vCPU context switch.
> - The expanded Xen capability, like static-allocation and direct-map.
> 
> ***Notes:***
> 1. ***This proposal only covers the work of porting Xen to Armv8-R64***
>    ***single CPU. Xen SMP support on Armv8-R64 relates to Armv8-R***
>    ***Trusted-Frimware (TF-R). This is an external dependency,***
>    ***so we think the discussion of Xen SMP support on Armv8-R64***
>    ***should be started when single-CPU support is complete.***
> 2. ***This proposal will not touch xen-tools. In current stage,***
>    ***Xen on Armv8-R64 only support dom0less, all guests should***
>    ***be booted from device tree.***
> 
> ## 1. Essential Background
> 
> ### 1.1. Armv8-R64 Profile
> The Armv-R architecture profile was designed to support use cases that
> have a high sensitivity to deterministic execution. (e.g. Fuel Injection,
> Brake control, Drive trains, Motor control etc)
> 
> Arm announced Armv8-R in 2013, it is the latest generation Arm architecture
> targeted at the Real-time profile. It introduces virtualization at the highest
> security level while retaining the Protected Memory System Architecture (PMSA)
> based on a Memory Protection Unit (MPU). In 2020, Arm announced Cortex-R82,
> which is the first Arm 64-bit Cortex-R processor based on Armv8-R64.
> 
> - The latest Armv8-R64 document can be found here:
>   [Arm Architecture Reference Manual Supplement - Armv8, for Armv8-R AArch64 architecture profile](https://developer.arm.com/documentation/ddi0600/latest/).
> 
> - Armv-R Architecture progression:
>   Armv7-R -> Armv8-R AArch32 -> Armv8 AArch64
>   The following figure is a simple comparison of "R" processors based on
>   different Armv-R Architectures.
>   ![image](https://drive.google.com/uc?export=view&id=1nE5RAXaX8zY2KPZ8imBpbvIr2eqBguEB)
> 
> - The Armv8-R architecture evolved additional features on top of Armv7-R:
>     - An exception model that is compatible with the Armv8-A model
>     - Virtualization with support for guest operating systems
>         - PMSA virtualization using MPUs In EL2.
> - The new features of Armv8-R64 architecture
>     - Adds support for the 64-bit A64 instruction set, previously Armv8-R
>       only supported A32.
>     - Supports up to 48-bit physical addressing, previously up to 32-bit
>       addressing was supported.
>     - Optional Arm Neon technology and Advanced SIMD
>     - Supports three Exception Levels (ELs)
>         - Secure EL2 - The Highest Privilege, MPU only, for firmware, hypervisor
>         - Secure EL1 - RichOS (MMU) or RTOS (MPU)
>         - Secure EL0 - Application Workloads
>     - Optionally supports Virtual Memory System Architecture at S-EL1/S-EL0.
>       This means it's possible to run rich OS kernels - like Linux - either
>       bare-metal or as a guest.
> - Differences with the Armv8-A AArch64 architecture
>     - Supports only a single Security state - Secure. There is not Non-Secure
>       execution state supported.
>     - EL3 is not supported, EL2 is mandatory. This means secure EL2 is the
>       highest EL.
>     - Supports the A64 ISA instruction
>         - With a small set of well-defined differences
>     - Provides a PMSA (Protected Memory System Architecture) based
>       virtualization model.
>         - As opposed to Armv8-A AArch64's VMSA based Virtualization
>         - Can support address bits up to 52 if FEAT_LPA is enabled,
>           otherwise 48 bits.
>         - Determines the access permissions and memory attributes of
>           the target PA.
>         - Can implement PMSAv8-64 at EL1 and EL2
>             - Address translation flat-maps the VA to the PA for EL2 Stage 1.
>             - Address translation flat-maps the VA to the PA for EL1 Stage 1.
>             - Address translation flat-maps the IPA to the PA for EL1 Stage 2.
>     - PMSA in EL1 & EL2 is configurable, VMSA in EL1 is configurable.
> 
> ### 1.2. Xen Challenges with PMSA Virtualization
> Xen is PMSA unaware Type-1 Hypervisor, it will need modifications to run
> with an MPU and host multiple guest OSes.
> 
> - No MMU at EL2:
>     - No EL2 Stage 1 address translation
>         - Xen provides fixed ARM64 virtual memory layout as basis of EL2
>           stage 1 address translation, which is not applicable on MPU system,
>           where there is no virtual addressing. As a result, any operation
>           involving transition from PA to VA, like ioremap, needs modification
>           on MPU system.
>     - Xen's run-time addresses are the same as the link time addresses.
>         - Enable PIC (position-independent code) on a real-time target
>           processor probably very rare.
>     - Xen will need to use the EL2 MPU memory region descriptors to manage
>       access permissions and attributes for accesses made by VMs at EL1/0.
>         - Xen currently relies on MMU EL1 stage 2 table to manage these
>           accesses.
> - No MMU Stage 2 translation at EL1:
>     - A guest doesn't have an independent guest physical address space
>     - A guest can not reuse the current Intermediate Physical Address
>       memory layout
>     - A guest uses physical addresses to access memory and devices
>     - The MPU at EL2 manages EL1 stage 2 access permissions and attributes
> - There are a limited number of MPU protection regions at both EL2 and EL1:
>     - Architecturally, the maximum number of protection regions is 256,
>       typical implementations have 32.
>     - By contrast, Xen does not need to consider the number of page table
>       entries in theory when using MMU.
> - The MPU protection regions at EL2 need to be shared between the hypervisor
>   and the guest stage 2.
>     - Requires careful consideration - may impact feature 'fullness' of both
>       the hypervisor and the guest
>     - By contrast, when using MMU, Xen has standalone P2M table for guest
>       stage 2 accesses.
> 
> ## 2. Proposed changes of Xen
> ### **2.1. Changes of build system:**
> 
> - ***Introduce new Kconfig options for Armv8-R64***:
>   Unlike Armv8-A, because lack of MMU support on Armv8-R64, we may not
>   expect one Xen binary to run on all machines. Xen images are not common
>   across Armv8-R64 platforms. Xen must be re-built for different Armv8-R64
>   platforms. Because these platforms may have different memory layout and
>   link address.
>     - `ARM64_V8R`:
>       This option enables Armv8-R profile for Arm64. Enabling this option
>       results in selecting MPU. This Kconfig option is used to gate some
>       Armv8-R64 specific code except MPU code, like some code for Armv8-R64
>       only system ID registers access.
> 
>     - `ARM_MPU`
>       This option enables MPU on ARMv8-R architecture. Enabling this option
>       results in disabling MMU. This Kconfig option is used to gate some
>       ARM_MPU specific code. Once when this Kconfig option has been enabled,
>       the MMU relate code will not be built for Armv8-R64. The reason why
>       not depends on runtime detection to select MMU or MPU is that, we don't
>       think we can use one image for both Armv8-R64 and Armv8-A64. Another
>       reason that we separate MPU and V8R in provision to allow to support MPU
>       on 32bit Arm one day.
> 
>     - `XEN_START_ADDRESS`
>       This option allows to set the custom address at which Xen will be
>       linked. This address must be aligned to a page size. Xen's run-time
>       addresses are the same as the link time addresses. Different platforms
>       may have differnt memory layout. This Kconfig option provides users
>       the ability to select proper link addresses for their boards.
>       ***Notes: Fixed link address means the Xen binary could not be***
>       ***relocated by EFI loader. So in current stage, Xen could not***
>       ***be launched as an EFI application on Armv8-R64.***
> 
>     - `ARM_MPU_NORMAL_MEMORY_START` and `ARM_MPU_NORMAL_MEMORY_END`
>       `ARM_MPU_DEVICE_MEMORY_START` and `ARM_MPU_DEVICE_MEMORY_END`
>       These Kconfig options allow to set memory regions for Xen code, data
>       and device memory. Before parsing memory information from device tree,
>       Xen will use the values that stored in these options to setup boot-time
>       MPU configuration. Why we need a boot-time MPU configuration?
>       1. More deterministic: Arm MPU supports background regions,
>          if we don't configure the MPU regions and don't enable MPU.
>          We can enable MPU background regions. But that means all RAM
>          is RWX. Random values in RAM or maliciously embedded data can
>          be exploited. Using these Kconfig options allow users to have
>          a deterministic RAM area to execute code.
>       2. More compatible: On some Armv8-R64 platforms, if the MPU is
>          disabled, the `dc zva` instruction will make the system halt.
>          And this instruction will be embedded in some built-in functions,
>          like `memory set`. If we use `-ddont_use_dc` to rebuild GCC,
>          the built-in functions will not contain `dc zva`. However, it is
>          obviously unlikely that we will be able to recompile all GCC
>          for ARMv8-R64.
>       3. One optional idea:
>           We can map `XEN_START_ADDRESS` to `XEN_START_ADDRESS + 2MB` or
>           `XEN_START_ADDRESS` to `XEN_START_ADDRESS + image_end` for
>           MPU normal memory. It's enough to support Xen run in boot time.

I can imagine that we need to have a different Xen build for each
ARMv8-R platform. Do you envision that XEN_START_ADDRESS and
ARM_MPU_*_MEMORY_START/END are preconfigured based on the platform
choice at build time? I don't think we want a user to provide all of
those addresses by hand, right?

The next question is whether we could automatically generate
XEN_START_ADDRESS and ARM_MPU_*_MEMORY_START/END based on the platform
device tree at build time (at build time, not runtime). That would
make things a lot easier and it is also aligned with the way Zephyr and
other RTOSes and baremetal apps work.

The device tree can be given as input to the build system, and the
Makefiles would take care of generating XEN_START_ADDRESS and
ARM_MPU_*_MEMORY_START/END based on /memory and other interesting nodes.


> - ***Define new system registers for compilers***:
>   Armv8-R64 is based on Armv8.4. That means we will use some Armv8.4
>   specific system registers. As Armv8-R64 only have secure state, so
>   at least, `VSTCR_EL2` and `VSCTLR_EL2` will be used for Xen. And the
>   first GCC version that supports Armv8.4 is GCC 8.1. In addition to
>   these, PMSA of Armv8-R64 introduced lots of MPU related system registers:
>   `PRBAR_ELx`, `PRBARx_ELx`, `PRLAR_ELx`, `PRLARx_ELx`, `PRENR_ELx` and
>   `MPUIR_ELx`. But the first GCC version to support these system registers
>   is GCC 11. So we have two ways to make compilers to work properly with
>   these system registers.
>   1. Bump GCC version to GCC 11.
>      The pros of this method is that, we don't need to encode these
>      system registers in macros by ourselves. But the cons are that,
>      we have to update Makefiles to support GCC 11 for Armv8-R64.
>      1.1. Check the GCC version 11 for Armv8-R64.
>      1.2. Add march=armv8r to CFLAGS for Armv8-R64.
>      1.3. Solve the confliction of march=armv8r and mcpu=generic
>     These changes will affect common Makefiles, not only Arm Makefiles.
>     And GCC 11 is new, lots of toolchains and Distro haven't supported it.
> 
>   2. Encode new system registers in macros ***(preferred)***
>         ```
>         /* Virtualization Secure Translation Control Register */
>         #define VSTCR_EL2  S3_4_C2_C6_2
>         /* Virtualization System Control Register */
>         #define VSCTLR_EL2 S3_4_C2_C0_0
>         /* EL1 MPU Protection Region Base Address Register encode */
>         #define PRBAR_EL1  S3_0_C6_C8_0
>         ...
>         /* EL2 MPU Protection Region Base Address Register encode */
>         #define PRBAR_EL2  S3_4_C6_C8_0
>         ...
>         ```
>      If we encode all above system registers, we don't need to bump GCC
>      version. And the common CFLAGS Xen is using still can be applied to
>      Armv8-R64. We don't need to modify Makefiles to add specific CFLAGS.

I think that's fine and we did something similar with the original ARMv7-A
port if I remember correctly.


> ### **2.2. Changes of the initialization process**
> In general, we still expect Armv8-R64 and Armv8-A64 to have a consistent
> initialization process. In addition to some architecture differences, there
> is no more than reusable code that we will distinguish through CONFIG_ARM_MPU
> or CONFIG_ARM64_V8R. We want most of the initialization code to be reusable
> between Armv8-R64 and Armv8-A64.

+1


> - We will reuse the original head.s and setup.c of Arm. But replace the
>   MMU and page table operations in these files with configuration operations
>   for MPU and MPU regions.
> 
> - We provide a boot-time MPU configuration. This MPU configuration will
>   support Xen to finish its initialization. And this boot-time MPU
>   configuration will record the memory regions that will be parsed from
>   device tree.
> 
>   In the end of Xen initialization, we will use a runtime MPU configuration
>   to replace boot-time MPU configuration. The runtime MPU configuration will
>   merge and reorder memory regions to save more MPU regions for guests.
>   ![img](https://drive.google.com/uc?export=view&id=1wTFyK2XfU3lTlH1PqRDoacQVTwUtWIGU)
> 
> - Defer system unpausing domain.
>   When Xen initialization is about to end, Xen unpause guests created
>   during initialization. But this will cause some issues. The unpause
>   action occurs before free_init_memory, however the runtime MPU configuration
>   is built after free_init_memory.
> 
>   So if the unpaused guests start executing the context switch at this
>   point, then its MPU context will base on the boot-time MPU configuration.
>   Probably it will be inconsistent with runtime MPU configuration, this
>   will cause unexpected problems (This may not happen in a single core
>   system, but on SMP systems, this problem is foreseeable, so we hope to
>   solve it at the beginning).
> 
> ### **2.3. Changes to reduce memory fragmentation**
> 
> In general, memory in Xen system can be classified to 4 classes:
> `image sections`, `heap sections`, `guest RAM`, `boot modules (guest Kernel,
> initrd and dtb)`
> 
> Currently, Xen doesn't have any restriction for users how to allocate
> memory for different classes. That means users can place boot modules
> anywhere, can reserve Xen heap memory anywhere and can allocate guest
> memory anywhere.
> 
> In a VMSA system, this would not be too much of a problem, since the
> MMU can manage memory at a granularity of 4KB after all. But in a
> PMSA system, this will be a big problem. On Armv8-R64, the max MPU
> protection regions number has been limited to 256. But in typical
> processor implementations, few processors will design more than 32
> MPU protection regions. Add in the fact that Xen shares MPU protection
> regions with guest's EL1 Stage 2. It becomes even more important
> to properly plan the use of MPU protection regions.
> 
> - An ideal of memory usage layout restriction:
> ![img](https://drive.google.com/uc?export=view&id=1kirOL0Tx2aAypTtd3kXAtd75XtrngcnW)
> 1. Reserve proper MPU regions for Xen image (code, rodata and data + bss).
> 2. Reserve one MPU region for boot modules.
>    That means the placement of all boot modules, include guest kernel,
>    initrd and dtb, will be limited to this MPU region protected area.
> 3. Reserve one or more MPU regions for Xen heap.
>    On Armv8-R64, the guest memory is predefined in device tree, it will
>    not be allocated from heap. Unlike Armv8-A64, we will not move all
>    free memory to heap. We want Xen heap is dertermistic too, so Xen on
>    Armv8-R64 also rely on Xen static heap feature. The memory for Xen
>    heap will be defined in tree too. Considering that physical memory
>    can also be discontinuous, one or more MPU protection regions needs
>    to be reserved for Xen HEAP.
> 4. If we name above used MPU protection regions PART_A, and name left
>    MPU protection regions PART_B:
>    4.1. In hypervisor context, Xen will map left RAM and devices to PART_B.
>         This will give Xen the ability to access whole memory.
>    4.2. In guest context, Xen will create EL1 stage 2 mapping in PART_B.
>         In this case, Xen just need to update PART_B in context switch,
>         but keep PART_A as fixed.

I think that the memory layout and restrictions that you wrote above
make sense. I have some comments on the way they are represented in
device tree, but that's different.


> ***Notes: Static allocation will be mandatory on MPU based systems***
> 
> **A sample device tree of memory layout restriction**:
> ```
> chosen {
>     ...
>     /*
>      * Define a section to place boot modules,
>      * all boot modules must be placed in this section.
>      */
>     mpu,boot-module-section = <0x10000000 0x10000000>;
>     /*
>      * Define a section to cover all guest RAM. All guest RAM must be located
>      * within this section. The pros is that, in best case, we can only have
>      * one MPU protection region to map all guest RAM for Xen.
>      */
>     mpu,guest-memory-section = <0x20000000 0x30000000>;
>     /*
>      * Define a memory section that can cover all device memory that
>      * will be used in Xen.
>      */
>     mpu,device-memory-section = <0x80000000 0x7ffff000>;
>     /* Define a section for Xen heap */
>     xen,static-mem = <0x50000000 0x20000000>;

As mentioned above, I understand the need for these sections, but why do
we need to describe them in device tree at all? Could Xen select them by
itself during boot?

If not, and considering that we have to generate
ARM_MPU_*_MEMORY_START/END anyway at build time, would it make sense to
also generate mpu,guest-memory-section, xen,static-mem, etc. at build
time rather than passing it via device tree to Xen at runtime?

What's the value of doing ARM_MPU_*_MEMORY_START/END at build time and
everything else at runtime?

It looks like we are forced to have the sections definitions at build
time because we need them before we can parse device tree. In that case,
we might as well define all the sections at build time.

But I think it would be even better if Xen could automatically choose
xen,static-mem, mpu,guest-memory-section, etc. on its own based on the
regular device tree information (/memory, /amba, etc.), without any need
for explicitly describing each range with these new properties.

 
>     domU1 {
>         ...
>         #xen,static-mem-address-cells = <0x01>;
>         #xen,static-mem-size-cells = <0x01>;
>         /* Statically allocated guest memory, within mpu,guest-memory-section */
>         xen,static-mem = <0x30000000 0x1f000000>;
> 
>         module@11000000 {
>             compatible = "multiboot,kernel\0multiboot,module";
>             /* Boot module address, within mpu,boot-module-section */
>             reg = <0x11000000 0x3000000>;
>             ...
>         };
> 
>         module@10FF0000 {
>                 compatible = "multiboot,device-tree\0multiboot,module";
>                 /* Boot module address, within mpu,boot-module-section */
>                 reg = <0x10ff0000 0x10000>;
>                 ...
>         };
>     };
> };
> ```
> 
> ### **2.4. Changes of memory management**
> Xen is coupled with VMSA, in order to port Xen to Armv8-R64, we have to
> decouple Xen from VMSA. And give Xen the ability to manage memory in PMSA.
> 
> 1. ***Use buddy allocator to manage physical pages for PMSA***
>    From the view of physical page, PMSA and VMSA don't have any difference.
>    So we can reuse buddy allocator on Armv8-R64 to manage physical pages.
>    The difference is that, in VMSA, Xen will map allocated pages to virtual
>    addresses. But in PMSA, Xen just convert the pages to physical address.
> 
> 2. ***Can not use virtual address for memory management***
>    As Armv8-R64 only has PMSA in EL2, Xen loses the ability of using virtual
>    address to manage memory. This brings some problems, some virtual address
>    based features could not work well on Armv8-R64, like `FIXMAP`, `vmap/vumap`,
>    `ioremap` and `alternative`.
> 
>    But the functions or macros of these features are used in lots of common
>    code. So it's not good to use `#ifdef CONFIG_ARM_MPU` to gate relate code
>    everywhere. In this case, we propose to use stub helpers to make the changes
>    transparently to common code.
>    1. For `FIXMAP`, we will use `0` in `FIXMAP_ADDR` for all fixmap operations.
>       This will return physical address directly of fixmapped item.
>    2. For `vmap/vumap`, we will use some empty inline stub helpers:
>         ```
>         static inline void vm_init_type(...) {}
>         static inline void *__vmap(...)
>         {
>             return NULL;
>         }
>         static inline void vunmap(const void *va) {}
>         static inline void *vmalloc(size_t size)
>         {
>             return NULL;
>         }
>         static inline void *vmalloc_xen(size_t size)
>         {
>             return NULL;
>         }
>         static inline void vfree(void *va) {}
>         ```
> 
>    3. For `ioremap`, it depends on `vmap`. As we have make `vmap` to always
>       return `NULL`, they could not work well on Armv8-R64 without changes.
>       `ioremap` will return input address directly.
>         ```
>         static inline void *ioremap_attr(...)
>         {
>             /* We don't have the ability to change input PA cache attributes */
>             if ( CACHE_ATTR_need_change )
>                 return NULL;
>             return (void *)pa;
>         }
>         static inline void __iomem *ioremap_nocache(...)
>         {
>             return ioremap_attr(start, len, PAGE_HYPERVISOR_NOCACHE);
>         }
>         static inline void __iomem *ioremap_cache(...)
>         {
>             return ioremap_attr(start, len, PAGE_HYPERVISOR);
>         }
>         static inline void __iomem *ioremap_wc(...)
>         {
>             return ioremap_attr(start, len, PAGE_HYPERVISOR_WC);
>         }
>         void *ioremap(...)
>         {
>             return ioremap_attr(pa, len, PAGE_HYPERVISOR_NOCACHE);
>         }
> 
>         ```
>     4. For `alternative`, it depends on `vmap` too. We will simply disable
>        it on Armv8-R64 in current stage. How to implement `alternative`
>        on Armv8-R64 is better to be discussed after basic functions of Xen
>        on Armv8-R64 work well.
>        But simply disable `alternative` will make `cpus_have_const_cap` always
>        return false.
>         ```
>         * System capability check for constant cap */
>         #define cpus_have_const_cap(num) ({                \
>                register_t __ret;                           \
>                                                            \
>                asm volatile (ALTERNATIVE("mov %0, #0",     \
>                                          "mov %0, #1",     \
>                                          num)              \
>                              : "=r" (__ret));              \
>                                                            \
>                 unlikely(__ret);                           \
>                 })
>         ```
>         So, before we have an PMSA `alternative` implementation, we have to
>         implement a separate `cpus_have_const_cap` for Armv8-R64:
>         ```
>         #define cpus_have_const_cap(num) cpus_have_cap(num)
>         ```

I think it is OK to disable alternative


> ### **2.5. Changes of guest management**
> Armv8-R64 only supports PMSA in EL2, but it supports configurable
> VMSA or PMSA in EL1. This means Xen will have a new type guest on
> Armv8-R64 - MPU based guest.
> 
> 1. **Add a new domain type - MPU_DOMAIN**
>    When user want to create a guest that will be using MPU in EL1, user
>    should add a `mpu` property in device tree `domU` node, like following
>    example:
>     ```
>     domU2 {
>         compatible = "xen,domain";
>         direct-map;
>         mpu; --> Indicates this domain will use PMSA in EL1.
>         ...
>     };
>     ```
>     Corresponding to `mpu` property in device tree, we also need to introduce
>     a new flag `XEN_DOMCTL_CDF_INTERNAL_mpu` for domain to mark itself as an
>     MPU domain. This flag will be used in domain creation and domain doing
>     vCPU context switch.
>     1. Domain creation need this flag to decide enable PMSA or VMSA in EL1.
>     2. vCPU context switch need this flag to decide save/restore MMU or MPU
>        related registers.
> 
> 2. **Add MPU registers to vCPU save EL1 MPU context**
>    Current Xen only support MMU based guest, so it hasn't considered to
>    save/restore MPU context. In this case, we need to add MPU registers
>    to `arch_vcpu`:
>     ```
>     struct arch_vcpu
>     {
>     #ifdef CONFIG_ARM_MPU
>         /* Virtualization Translation Control Register */
>         register_t vtcr_el2;
> 
>         /* EL1 MPU regions' registers */
>         pr_t mpu_regions[CONFIG_ARM_MPU_EL1_PROTECTION_REGIONS];
>     #endif
>     }
>     ```
>     Armv8-R64 can support max to 256 MPU regions. But that's just theoretical.
>     So we don't want to define `pr_t mpu_regions[256]`, this is a memory waste
>     in most of time. So we decided to let the user specify through a Kconfig
>     option. `CONFIG_ARM_MPU_EL1_PROTECTION_REGIONS` default value can be `32`,
>     it's a typical implementation on Armv8-R64. Users will recompile Xen when
>     their platform changes. So when the MPU changes, respecifying the MPU
>     protection regions number will not cause additional problems.

I wonder if we could probe the number of MPU regions at runtime and
dynamically allocate the memory needed to store them in arch_vcpu.


>
> 3. **MPU based P2M table management**
>    Armv8-R64 EL2 doesn't have EL1 stage 2 address translation. But through
>    PMSA, it still has the ability to control the permissions and attributes
>    of EL1 stage 2. In this case, we still hope to keep the interface
>    consistent with MMU based P2M as far as possible.
> 
>    p2m->root will point to an allocated memory. In Armv8-A64, this memory
>    is used to save the EL1 stage 2 translation table. But in Armv8-R64,
>    this memory will be used to store EL2 MPU protection regions that are
>    used by guest. During domain creation, Xen will prepare the data in
>    this memory to make guest can access proper RAM and devices. When the
>    guest's vCPU will be scheduled in, this data will be written to MPU
>    protection region registers.
> 
> ### **2.6. Changes of exception trap**
> As Armv8-R64 has compatible exception mode with Armv8-A64, so we can reuse most
> of Armv8-A64's exception trap & handler code. But except the trap based on EL1
> stage 2 translation abort.
> 
> In Armv8-A64, we use `FSC_FLT_TRANS`
> ```
>     case FSC_FLT_TRANS:
>         ...
>         if ( is_data )
>         {
>             enum io_state state = try_handle_mmio(regs, hsr, gpa);
>             ...
>         }
> ```
> But for Armv8-R64, we have to use `FSC_FLT_PERM`
> ```
>     case FSC_FLT_PERM:
>         ...
>         if ( is_data )
>         {
>             enum io_state state = try_handle_mmio(regs, hsr, gpa);
>             ...
>         }
> ```
> 
> ### **2.5. Changes of device driver**
> 1. Because Armv8-R64 only has single secure state, this will affect some
> devices that have two secure state, like GIC. But fortunately, most
> vendors will not link a two secure state GIC to Armv8-R64 processors.
> Current GIC driver can work well with single secure state GIC for Armv8-R64.
> 2. Xen should use secure hypervisor timer in Secure EL2. We will introduce
> a CONFIG_ARM_SECURE_STATE to make Xen to use secure registers for timer. 
> 
> ### **2.7. Changes of virtual device**
> Currently, we only support pass-through devices in guest. Because event
> channel, xen-bus, xen-storage and other advanced Xen features haven't been
> enabled in Armv8-R64.

That's fine -- it is a great start! Looking forward to it!


From xen-devel-bounces@lists.xenproject.org Fri Feb 25 01:13:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 01:13:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278703.476058 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNPAy-0004rH-BK; Fri, 25 Feb 2022 01:13:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278703.476058; Fri, 25 Feb 2022 01:13:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNPAy-0004rA-6d; Fri, 25 Feb 2022 01:13:40 +0000
Received: by outflank-mailman (input) for mailman id 278703;
 Fri, 25 Feb 2022 01:13:39 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nNPAx-0004r0-4F; Fri, 25 Feb 2022 01:13:39 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nNPAw-0004ha-To; Fri, 25 Feb 2022 01:13:38 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nNPAw-0005N6-Ec; Fri, 25 Feb 2022 01:13:38 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nNPAw-0007uR-EA; Fri, 25 Feb 2022 01:13:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=FAqmUb7ZympTrw1G0AW89Mz68EnnZ/T1IHlfYsYj+JU=; b=xd2jJ4MtgwP6Vflbc/H3lIsN+M
	lkKpeb0Wg0lnXbwLy0vkinbL8i4KyxAAM/1Xswe1m59Ll4Wz1KG4JRTw4V4dBe447uJzoTgb3NKc/
	6BgVAv9knp2GG4MHONGWY8Dy6j6NZ1HKO9DWfp8X9T4LZNycDeC+h6EDqbs+Wmn1Duxs=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168222-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 168222: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=9ba4c529985a1773852069889a5b53f2ed26c408
X-Osstest-Versions-That:
    xen=66b467a0e86daff8caa2b571871b1cb96633df45
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 25 Feb 2022 01:13:38 +0000

flight 168222 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168222/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  9ba4c529985a1773852069889a5b53f2ed26c408
baseline version:
 xen                  66b467a0e86daff8caa2b571871b1cb96633df45

Last test of basis   168218  2022-02-24 16:01:44 Z    0 days
Testing same since   168222  2022-02-24 21:02:59 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Julien Grall <jgrall@amazon.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   66b467a0e8..9ba4c52998  9ba4c529985a1773852069889a5b53f2ed26c408 -> smoke


From xen-devel-bounces@lists.xenproject.org Fri Feb 25 02:29:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 02:29:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278714.476069 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNQLi-0003wz-NK; Fri, 25 Feb 2022 02:28:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278714.476069; Fri, 25 Feb 2022 02:28:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNQLi-0003wr-IS; Fri, 25 Feb 2022 02:28:50 +0000
Received: by outflank-mailman (input) for mailman id 278714;
 Fri, 25 Feb 2022 02:28:49 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nNQLh-0003wc-C2; Fri, 25 Feb 2022 02:28:49 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nNQLh-0006N4-9G; Fri, 25 Feb 2022 02:28:49 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nNQLg-0002VQ-PQ; Fri, 25 Feb 2022 02:28:48 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nNQLg-0000LS-Or; Fri, 25 Feb 2022 02:28:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=4LqNVelm1JqB49GK/WSlpBpyPgknvJY9EER8zxjiMZs=; b=5xIvsMiGVcKuanO5LXuOpKq3Wp
	YfjpNU4cEnRyP+/XMV15FBpty/bUYQgam/P5GkPi+b42ZCAfQ9z2NDX6vHzdcv2DqLas65me7SFUt
	IqW/SsuAdHhukR6WUfPdsHm4+n08VEby1v7v3ZJBosAJkbL8gLcG9bG1JucmLG6LrAJ4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168217-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 168217: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-amd64-coresched-amd64-xl:guest-localmigrate/x10:fail:heisenbug
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=4aa2e497a98bafe962e72997f67a369e4b52d9c1
X-Osstest-Versions-That:
    qemuu=31e3caf21b6cdf54d11f3744b8b341f07a30b5d7
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 25 Feb 2022 02:28:48 +0000

flight 168217 qemu-mainline real [real]
flight 168223 qemu-mainline real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/168217/
http://logs.test-lab.xenproject.org/osstest/logs/168223/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-coresched-amd64-xl 20 guest-localmigrate/x10 fail pass in 168223-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168205
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168205
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168205
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168205
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168205
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168205
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168205
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168205
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                4aa2e497a98bafe962e72997f67a369e4b52d9c1
baseline version:
 qemuu                31e3caf21b6cdf54d11f3744b8b341f07a30b5d7

Last test of basis   168205  2022-02-23 09:37:25 Z    1 days
Testing same since   168217  2022-02-24 13:08:23 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Daniel P. Berrangé <berrange@redhat.com>
  Eduardo Otubo <otubo@redhat.com>
  Peter Maydell <peter.maydell@linaro.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                fail    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   31e3caf21b..4aa2e497a9  4aa2e497a98bafe962e72997f67a369e4b52d9c1 -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Fri Feb 25 04:04:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 04:04:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278732.476103 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNRpi-0005R0-Nx; Fri, 25 Feb 2022 04:03:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278732.476103; Fri, 25 Feb 2022 04:03:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNRpi-0005Qt-Kh; Fri, 25 Feb 2022 04:03:54 +0000
Received: by outflank-mailman (input) for mailman id 278732;
 Fri, 25 Feb 2022 04:03:53 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nNRph-0005Qj-Nj; Fri, 25 Feb 2022 04:03:53 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nNRph-00086E-LO; Fri, 25 Feb 2022 04:03:53 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nNRph-0006Hj-8q; Fri, 25 Feb 2022 04:03:53 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nNRph-0005Qo-8O; Fri, 25 Feb 2022 04:03:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=u1ZgscZvZ0yAYG5jx+oyDprEJcU49BNp5Zr38m8gLqE=; b=ZHSRBq2jyAYFHulncBZt9MF6+D
	fZnowI/wnpIxVp1WabjtjixxdbKSLubRIqATBk833fPMlqWmQtsB8UpO7SyZj11uBXrGwigslVoOP
	zyoIKKUz/lh3ocAC2wj9J2tIQ0qAXzb+pA5R1yZAdlLUoQkebbZp0LhuFBcAzP6MMCDk=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168220-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 168220: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=93189e8c8b93e2c4658156e785a9b78b61e71a64
X-Osstest-Versions-That:
    xen=fe60fab0424b93c6688d285bd7995226a96937d4
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 25 Feb 2022 04:03:53 +0000

flight 168220 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168220/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10       fail  like 168214
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168214
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168214
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168214
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168214
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168214
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168214
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168214
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168214
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168214
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168214
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168214
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168214
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  93189e8c8b93e2c4658156e785a9b78b61e71a64
baseline version:
 xen                  fe60fab0424b93c6688d285bd7995226a96937d4

Last test of basis   168214  2022-02-24 08:49:26 Z    0 days
Testing same since   168220  2022-02-24 19:08:16 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Jan Beulich <jbeulich@suse.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   fe60fab042..93189e8c8b  93189e8c8b93e2c4658156e785a9b78b61e71a64 -> master


From xen-devel-bounces@lists.xenproject.org Fri Feb 25 06:34:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 06:34:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278746.476115 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNUB8-0003Xh-RV; Fri, 25 Feb 2022 06:34:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278746.476115; Fri, 25 Feb 2022 06:34:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNUB8-0003Xa-O5; Fri, 25 Feb 2022 06:34:10 +0000
Received: by outflank-mailman (input) for mailman id 278746;
 Fri, 25 Feb 2022 06:34:09 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=i2jl=TI=arm.com=Wei.Chen@srs-se1.protection.inumbo.net>)
 id 1nNUB6-0003XR-KX
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 06:34:09 +0000
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur01on060d.outbound.protection.outlook.com
 [2a01:111:f400:fe1e::60d])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ed58707b-9604-11ec-8539-5f4723681683;
 Fri, 25 Feb 2022 07:34:04 +0100 (CET)
Received: from AS9PR06CA0321.eurprd06.prod.outlook.com (2603:10a6:20b:45b::23)
 by AM6PR08MB3592.eurprd08.prod.outlook.com (2603:10a6:20b:4b::33)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Fri, 25 Feb
 2022 06:34:01 +0000
Received: from AM5EUR03FT059.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:45b:cafe::e0) by AS9PR06CA0321.outlook.office365.com
 (2603:10a6:20b:45b::23) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.23 via Frontend
 Transport; Fri, 25 Feb 2022 06:34:01 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT059.mail.protection.outlook.com (10.152.17.193) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5017.24 via Frontend Transport; Fri, 25 Feb 2022 06:34:01 +0000
Received: ("Tessian outbound 741ca6c82739:v113");
 Fri, 25 Feb 2022 06:34:01 +0000
Received: from 8a0f1fb064f6.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 F27B883A-689C-48C7-8020-A59389F59A3F.1; 
 Fri, 25 Feb 2022 06:33:50 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8a0f1fb064f6.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 25 Feb 2022 06:33:50 +0000
Received: from AS1PR08MB7426.eurprd08.prod.outlook.com (2603:10a6:20b:4c5::16)
 by AM5PR0802MB2417.eurprd08.prod.outlook.com (2603:10a6:203:9c::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.25; Fri, 25 Feb
 2022 06:33:46 +0000
Received: from AS1PR08MB7426.eurprd08.prod.outlook.com
 ([fe80::58e6:449c:825c:a0c2]) by AS1PR08MB7426.eurprd08.prod.outlook.com
 ([fe80::58e6:449c:825c:a0c2%4]) with mapi id 15.20.5017.024; Fri, 25 Feb 2022
 06:33:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ed58707b-9604-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=IxeCYMPjbIvUwloUfteQTu6Y/qfE3SubC522rmSz+Vo=;
 b=R8kYm+8qyRQ7GYTmjTGqU8rKTEETEo0Ir+QE5h1enQNNUlOMUGs4ZFPsIr49uEZ0cVRRKqgKAAI4MytuuMoC3E6fycIcCJbUuuhSgarpN9zsPWjQ48n+RxArknoRdns/jV+VaFnNONLAiG4KgWNCazqRrN41dHbr5rQhSj5o1Mg=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=lDXtiZqhJN9EGzBdnxVvnww7Ifxvghf03DJpyBR6QJKyRi9pikcuzJrBi7wtoGXXadKT2LtFWbiOQyX0oy0yNF/ivult4srj0gw0YdUElAK8y5uuzWuYK4egbF3y3QB0gzJ4ojDvZsNzDDPmuhpZoQ910hyunvf4rWzlrFzcdDdyfeGkRcojwNJH+O7S59KrNI+OCWxtGT9eyjsENUwoonijZGRdVbDxegRZCfCo3IS0Of2S6DJA1d1ruJC8LVLoTF1naN4KTe2yC71Ectu28MN0vzQLhFUMUz713K7cJVsSDf2Eic/d+uSyx+UQ7aVtUcjtROGcwQVTAumWndsxeQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=IxeCYMPjbIvUwloUfteQTu6Y/qfE3SubC522rmSz+Vo=;
 b=QxErcZUTfrrKUU7z8Bram03uXbwHFPYu1xcTtCX6ldkBcxcEgcm9oQ+tMbyFcfAXyftehoPjNoKiXzkNEp4Wol5G9drqQGHTuj/WvofJtBPc+5khIY2fvk5Zx4Gz1LkzTgpGDQzkTwHuNrcTTuG37JJtT2ZFcy0FtZiHPPKcaVEE6N/n6FoxHPA80pIfQB8e39WyKioQ4R4G4XySiPvJ33N9dvOZ8ViVVH5Q44oOAvQhdbrJws/Pp4RvzlP+WX9VohoAlTY7dnvQbuATrjiaZW2nBc85iP0/yvEbU6fz+qtxD49iflW9zBwfCjJeC7Vz3MreygMhpt2Jo8tNZ3NGgw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=IxeCYMPjbIvUwloUfteQTu6Y/qfE3SubC522rmSz+Vo=;
 b=R8kYm+8qyRQ7GYTmjTGqU8rKTEETEo0Ir+QE5h1enQNNUlOMUGs4ZFPsIr49uEZ0cVRRKqgKAAI4MytuuMoC3E6fycIcCJbUuuhSgarpN9zsPWjQ48n+RxArknoRdns/jV+VaFnNONLAiG4KgWNCazqRrN41dHbr5rQhSj5o1Mg=
From: Wei Chen <Wei.Chen@arm.com>
To: Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"julien@xen.org" <julien@xen.org>, Stefano Stabellini
	<sstabellini@kernel.org>
CC: Bertrand Marquis <Bertrand.Marquis@arm.com>, Penny Zheng
	<Penny.Zheng@arm.com>, Henry Wang <Henry.Wang@arm.com>, nd <nd@arm.com>
Subject: RE: Proposal for Porting Xen to Armv8-R64 - DraftA
Thread-Topic: Proposal for Porting Xen to Armv8-R64 - DraftA
Thread-Index: AdgpQxtXwh7LkfydTgiYk9bhMgU+ogAMdc6AACCpIxA=
Date: Fri, 25 Feb 2022 06:33:46 +0000
Message-ID:
 <AS1PR08MB7426FB2B4706EAFD26C1E7779E3E9@AS1PR08MB7426.eurprd08.prod.outlook.com>
References:
 <PAXPR08MB7420A01809B84E04E196793F9E3D9@PAXPR08MB7420.eurprd08.prod.outlook.com>
 <a0c4c458-152e-750b-9e26-63a6d544e836@xilinx.com>
In-Reply-To: <a0c4c458-152e-750b-9e26-63a6d544e836@xilinx.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: AF8C881ACE731B4F80FB59EB7C854CE2.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: d98b6d46-8756-44c4-a3a2-08d9f828cf7b
x-ms-traffictypediagnostic:
	AM5PR0802MB2417:EE_|AM5EUR03FT059:EE_|AM6PR08MB3592:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR08MB3592DB186FEF517BB4058E6A9E3E9@AM6PR08MB3592.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 VjhmcrboZGAFYqSavgLp56Xq+XoaXz4mce4FGQHdV183yMs1pE9nYjtwr5BFtbo9TeidrTk5sQ0KpzvEDhBv++Ifkg5lQYv7QvFEwwpoROXUSyeT0ug7zTMkvhZxK2P2VzV+WzfIG0rhV47o29s30y2AOHFU/0Zxc7Fodpc5QiH14vVyaUgMbAj5VVL739uBAzg8t5j0YiIZZnCBRWEFrgKlHUgAb8Kh6rKvJ4EEfOh9IJYCjiWjDzIilOaOOP0IANsJApXdkhHythA9KPL93QpZDgnx1G7lLI6zpPUZ4Jx7YINLuc3RnmphIkL2ho1nfkwBuw8CtjC22qZbixFR0ix+1hW4Q1O6U7PX5PSfwEodVT8GP+RKbbo+BA4HD9RjFzGXjrKxRIFQJRWmApiH3SBeoz4wttnQFCDbtVacxY8UAjX6KX46NKsnv1Dk7YG0jEjfruSDjy/mAm+XyVNJ9P65xUEWzxEPCnL5SSLP5CPIJFDkwenbAs8k8SCOmFEevBU0PMqf0xcggz3OL/dyuVnjI2JlTDM6/oJakvuxJczp0VftJLbgYfbFo8GJy66ml/TnlHYJqDFMSv4Ay0HbK2SMI5VzfW8A7G84EGCHelTLTbRHI0PEvoIe1bjHU0d926zCPZPYXChJ633yR9MXNDLVMXO65sxytpb3MOuc4sBX5cXp2c3Yeb4Vg7xeDYADBMpSGsN6NUN0j8G+YCZtaUSYfxBHYP2VzYOE3c9274/JLnp3INaklNgIi7awLdVH7J5UjM+o2z1nmps3BSzB48IxD1boXr4YMD0StGfn3OPvF2cc+KXArMo5cCUOtRtGC7EYtHFtKNbC787yXWv2NQ==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS1PR08MB7426.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(4326008)(8676002)(66556008)(66476007)(66446008)(64756008)(66946007)(76116006)(52536014)(5660300002)(30864003)(8936002)(38070700005)(966005)(316002)(54906003)(110136005)(122000001)(38100700002)(2906002)(508600001)(9686003)(71200400001)(53546011)(55016003)(6506007)(7696005)(33656002)(186003)(26005)(86362001)(83380400001)(559001)(579004);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0802MB2417
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT059.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	fe2c5596-6d7f-44e4-8904-08d9f828c6da
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	TTyo24dBMX2RlsiBuzuFW5cIsf73LW3iTSpBkDqcDnBXT7SL932cKB846O06TagBEXqyDwZhDHo0pucGh0eU6liLxdfZcjG93mnebZHb/yEOJKt306izWQBqTrEuUoPJzIo1ZmyWJtZd0Pa/b+fKxx3Ej2e4FhAKJVMjqkzjJpFa4WRy/l56d8jfZwn/PbMZ7jjFiLkMZ3Oq828LvRrioq/uiNoHFUHyHYb5Oji3uXROWjrtExnxByaL5zNEknEie6euntkW9PbjsYGU2AxDKJmVZTB86sjlOxJ94/OYXIi45ygxDaSowkYhTK8q6KZ3ZSVZiIkoSZV+6anrzkKJCs/UkOqT3iG7RXj80l5z6TUihndCO8QYlul0j4TJyZqk+BIDrBr8L9PeOhrt0ZwMaUu+AG9oTwcRJ67TwiPTuvIPIAyT/2cdAcNSZB4uPC1TCRFc2XDWIK26cndqj04+5PntWTZw0Ybdzv0Xaua+Bt3H0UknoMSizivih1e3WcSyswOCdtkNUWYH4sw+i+71dVBdzoQWd+/kD9cW9IwmC+CGpf/IvivAWfYQn5U0+kWadbXGuY8dK/Q36jLsSTRyrLnk5yUMbASz7B2a3Qe8PzHZ70Anp9+qZKZ54JORaCKSsGEK4k7P2gPVzckkLcmzIcx3HXOYfm2CaiFnhSbbsZsnSISzCY1ho202uylLfyHxf7bx7yNLXzXQDsBK7XHLb4D7ViAVKvfp9cDtcubwkQmZym15ryG2LTmRNHQs002mEgeznIT/b1f79Y2Hu0GVpZAhtgPyOn/q6yQ2atf/WiA=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(4326008)(70586007)(81166007)(26005)(9686003)(186003)(82310400004)(8676002)(70206006)(53546011)(966005)(33656002)(356005)(508600001)(7696005)(2906002)(6506007)(52536014)(47076005)(110136005)(336012)(86362001)(5660300002)(83380400001)(40460700003)(8936002)(54906003)(36860700001)(30864003)(55016003)(316002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2022 06:34:01.2065
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: d98b6d46-8756-44c4-a3a2-08d9f828cf7b
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT059.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3592

SEkgQXlhbiwNCg0KPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBBeWFuIEt1
bWFyIEhhbGRlciA8YXlhbi5rdW1hci5oYWxkZXJAeGlsaW54LmNvbT4NCj4gU2VudDogMjAyMuW5
tDLmnIgyNOaXpSAxOTo1Mg0KPiBUbzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+OyB4ZW4t
ZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmc7DQo+IGp1bGllbkB4ZW4ub3JnOyBTdGVmYW5vIFN0
YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+DQo+IENjOiBCZXJ0cmFuZCBNYXJxdWlz
IDxCZXJ0cmFuZC5NYXJxdWlzQGFybS5jb20+OyBQZW5ueSBaaGVuZw0KPiA8UGVubnkuWmhlbmdA
YXJtLmNvbT47IEhlbnJ5IFdhbmcgPEhlbnJ5LldhbmdAYXJtLmNvbT47IG5kIDxuZEBhcm0uY29t
Pg0KPiBTdWJqZWN0OiBSZTogUHJvcG9zYWwgZm9yIFBvcnRpbmcgWGVuIHRvIEFybXY4LVI2NCAt
IERyYWZ0QQ0KPiANCj4gSGkgV2VpLA0KPiANCj4gVGhpcyBpcyBhIG5pY2Ugd3JpdGV1cC4gSSBo
YXZlIGEgZmV3IGluaXRpYWwgcXVlcmllcy4NCj4gDQo+IE9uIDI0LzAyLzIwMjIgMDY6MDEsIFdl
aSBDaGVuIHdyb3RlOg0KPiA+ICMgUHJvcG9zYWwgZm9yIFBvcnRpbmcgWGVuIHRvIEFybXY4LVI2
NA0KPiA+DQo+ID4gVGhpcyBwcm9wb3NhbCB3aWxsIGludHJvZHVjZSB0aGUgUG9DIHdvcmsgb2Yg
cG9ydGluZyBYZW4gdG8gQXJtdjgtUjY0LA0KPiA+IHdoaWNoIGluY2x1ZGVzOg0KPiA+IC0gVGhl
IGNoYW5nZXMgb2YgY3VycmVudCBYZW4gY2FwYWJpbGl0eSwgbGlrZSBYZW4gYnVpbGQgc3lzdGVt
LCBtZW1vcnkNCj4gPiAgICBtYW5hZ2VtZW50LCBkb21haW4gbWFuYWdlbWVudCwgdkNQVSBjb250
ZXh0IHN3aXRjaC4NCj4gPiAtIFRoZSBleHBhbmRlZCBYZW4gY2FwYWJpbGl0eSwgbGlrZSBzdGF0
aWMtYWxsb2NhdGlvbiBhbmQgZGlyZWN0LW1hcC4NCj4gPg0KPiA+ICoqKk5vdGVzOioqKg0KPiA+
IDEuICoqKlRoaXMgcHJvcG9zYWwgb25seSBjb3ZlcnMgdGhlIHdvcmsgb2YgcG9ydGluZyBYZW4g
dG8gQXJtdjgtUjY0KioqDQo+ID4gICAgICoqKnNpbmdsZSBDUFUuIFhlbiBTTVAgc3VwcG9ydCBv
biBBcm12OC1SNjQgcmVsYXRlcyB0byBBcm12OC1SKioqDQo+ID4gICAgICoqKlRydXN0ZWQtRnJp
bXdhcmUgKFRGLVIpLiBUaGlzIGlzIGFuIGV4dGVybmFsIGRlcGVuZGVuY3ksKioqDQo+ID4gICAg
ICoqKnNvIHdlIHRoaW5rIHRoZSBkaXNjdXNzaW9uIG9mIFhlbiBTTVAgc3VwcG9ydCBvbiBBcm12
OC1SNjQqKioNCj4gPiAgICAgKioqc2hvdWxkIGJlIHN0YXJ0ZWQgd2hlbiBzaW5nbGUtQ1BVIHN1
cHBvcnQgaXMgY29tcGxldGUuKioqDQo+ID4gMi4gKioqVGhpcyBwcm9wb3NhbCB3aWxsIG5vdCB0
b3VjaCB4ZW4tdG9vbHMuIEluIGN1cnJlbnQgc3RhZ2UsKioqDQo+ID4gICAgICoqKlhlbiBvbiBB
cm12OC1SNjQgb25seSBzdXBwb3J0IGRvbTBsZXNzLCBhbGwgZ3Vlc3RzIHNob3VsZCoqKg0KPiA+
ICAgICAqKipiZSBib290ZWQgZnJvbSBkZXZpY2UgdHJlZS4qKioNCj4gPg0KPiA+ICMjIDEuIEVz
c2VudGlhbCBCYWNrZ3JvdW5kDQo+ID4NCj4gPiAjIyMgMS4xLiBBcm12OC1SNjQgUHJvZmlsZQ0K
PiA+IFRoZSBBcm12LVIgYXJjaGl0ZWN0dXJlIHByb2ZpbGUgd2FzIGRlc2lnbmVkIHRvIHN1cHBv
cnQgdXNlIGNhc2VzIHRoYXQNCj4gPiBoYXZlIGEgaGlnaCBzZW5zaXRpdml0eSB0byBkZXRlcm1p
bmlzdGljIGV4ZWN1dGlvbi4gKGUuZy4gRnVlbCBJbmplY3Rpb24sDQo+ID4gQnJha2UgY29udHJv
bCwgRHJpdmUgdHJhaW5zLCBNb3RvciBjb250cm9sIGV0YykNCj4gPg0KPiA+IEFybSBhbm5vdW5j
ZWQgQXJtdjgtUiBpbiAyMDEzLCBpdCBpcyB0aGUgbGF0ZXN0IGdlbmVyYXRpb24gQXJtDQo+IGFy
Y2hpdGVjdHVyZQ0KPiA+IHRhcmdldGVkIGF0IHRoZSBSZWFsLXRpbWUgcHJvZmlsZS4gSXQgaW50
cm9kdWNlcyB2aXJ0dWFsaXphdGlvbiBhdCB0aGUNCj4gaGlnaGVzdA0KPiA+IHNlY3VyaXR5IGxl
dmVsIHdoaWxlIHJldGFpbmluZyB0aGUgUHJvdGVjdGVkIE1lbW9yeSBTeXN0ZW0gQXJjaGl0ZWN0
dXJlDQo+IChQTVNBKQ0KPiA+IGJhc2VkIG9uIGEgTWVtb3J5IFByb3RlY3Rpb24gVW5pdCAoTVBV
KS4gSW4gMjAyMCwgQXJtIGFubm91bmNlZCBDb3J0ZXgtDQo+IFI4MiwNCj4gPiB3aGljaCBpcyB0
aGUgZmlyc3QgQXJtIDY0LWJpdCBDb3J0ZXgtUiBwcm9jZXNzb3IgYmFzZWQgb24gQXJtdjgtUjY0
Lg0KPiANCj4gSXMgdGhlcmUgc29tZSBnb29kIGRvY3VtZW50IGV4cGxhaW5pbmcgdGhlIGRpZmZl
cmVuY2UgYmV0d2VlbiBNUFUgYW5kDQo+IE1NVSA/IEFuZCB3aGVuIGRvIHdlIG5lZWQgb25lIHZz
IG90aGVyLg0KPiANCg0KVGhlIEFybSBBcmNoaXRlY3R1cmUgUmVmZXJlbmNlIE1hbnVhbCBTdXBw
bGVtZW50IGRvY3VtZW50Og0KaHR0cHM6Ly9kZXZlbG9wZXIuYXJtLmNvbS9kb2N1bWVudGF0aW9u
L2RkaTA2MDAvbGF0ZXN0Lw0KV2lsbCBpbnRyb2R1Y2UgdGhlIFBNU0EgYW5kIFZNU0EgZm9yIEFy
bXY4LVIuDQoNCj4gPg0KPiA+IC0gVGhlIGxhdGVzdCBBcm12OC1SNjQgZG9jdW1lbnQgY2FuIGJl
IGZvdW5kIGhlcmU6DQo+ID4gICAgW0FybSBBcmNoaXRlY3R1cmUgUmVmZXJlbmNlIE1hbnVhbCBT
dXBwbGVtZW50IC0gQXJtdjgsIGZvciBBcm12OC1SDQo+IEFBcmNoNjQgYXJjaGl0ZWN0dXJlDQo+
IHByb2ZpbGVdKGh0dHBzOi8vZGV2ZWxvcGVyLmFybS5jb20vZG9jdW1lbnRhdGlvbi9kZGkwNjAw
L2xhdGVzdC8pLg0KPiA+DQo+ID4gLSBBcm12LVIgQXJjaGl0ZWN0dXJlIHByb2dyZXNzaW9uOg0K
PiA+ICAgIEFybXY3LVIgLT4gQXJtdjgtUiBBQXJjaDMyIC0+IEFybXY4IEFBcmNoNjQNCj4gPiAg
ICBUaGUgZm9sbG93aW5nIGZpZ3VyZSBpcyBhIHNpbXBsZSBjb21wYXJpc29uIG9mICJSIiBwcm9j
ZXNzb3JzIGJhc2VkDQo+IG9uDQo+ID4gICAgZGlmZmVyZW50IEFybXYtUiBBcmNoaXRlY3R1cmVz
Lg0KPiA+ICAgICFbaW1hZ2VdKGh0dHBzOi8vZHJpdmUuZ29vZ2xlLmNvbS91Yz9leHBvcnQ9dmll
dyZpZD0xbkU1UkFYYVg4elkyS1BaOA0KPiBpbUJwYnZJcjJlcUJndUVCKQ0KPiA+DQo+ID4gLSBU
aGUgQXJtdjgtUiBhcmNoaXRlY3R1cmUgZXZvbHZlZCBhZGRpdGlvbmFsIGZlYXR1cmVzIG9uIHRv
cCBvZiBBcm12Ny1SOg0KPiA+ICAgICAgLSBBbiBleGNlcHRpb24gbW9kZWwgdGhhdCBpcyBjb21w
YXRpYmxlIHdpdGggdGhlIEFybXY4LUEgbW9kZWwNCj4gPiAgICAgIC0gVmlydHVhbGl6YXRpb24g
d2l0aCBzdXBwb3J0IGZvciBndWVzdCBvcGVyYXRpbmcgc3lzdGVtcw0KPiA+ICAgICAgICAgIC0g
UE1TQSB2aXJ0dWFsaXphdGlvbiB1c2luZyBNUFVzIEluIEVMMi4NCj4gPiAtIFRoZSBuZXcgZmVh
dHVyZXMgb2YgQXJtdjgtUjY0IGFyY2hpdGVjdHVyZQ0KPiA+ICAgICAgLSBBZGRzIHN1cHBvcnQg
Zm9yIHRoZSA2NC1iaXQgQTY0IGluc3RydWN0aW9uIHNldCwgcHJldmlvdXNseQ0KPiBBcm12OC1S
DQo+ID4gICAgICAgIG9ubHkgc3VwcG9ydGVkIEEzMi4NCj4gPiAgICAgIC0gU3VwcG9ydHMgdXAg
dG8gNDgtYml0IHBoeXNpY2FsIGFkZHJlc3NpbmcsIHByZXZpb3VzbHkgdXAgdG8gMzItDQo+IGJp
dA0KPiA+ICAgICAgICBhZGRyZXNzaW5nIHdhcyBzdXBwb3J0ZWQuDQo+ID4gICAgICAtIE9wdGlv
bmFsIEFybSBOZW9uIHRlY2hub2xvZ3kgYW5kIEFkdmFuY2VkIFNJTUQNCj4gPiAgICAgIC0gU3Vw
cG9ydHMgdGhyZWUgRXhjZXB0aW9uIExldmVscyAoRUxzKQ0KPiA+ICAgICAgICAgIC0gU2VjdXJl
IEVMMiAtIFRoZSBIaWdoZXN0IFByaXZpbGVnZSwgTVBVIG9ubHksIGZvciBmaXJtd2FyZSwNCj4g
aHlwZXJ2aXNvcg0KPiA+ICAgICAgICAgIC0gU2VjdXJlIEVMMSAtIFJpY2hPUyAoTU1VKSBvciBS
VE9TIChNUFUpDQo+ID4gICAgICAgICAgLSBTZWN1cmUgRUwwIC0gQXBwbGljYXRpb24gV29ya2xv
YWRzDQo+ID4gICAgICAtIE9wdGlvbmFsbHkgc3VwcG9ydHMgVmlydHVhbCBNZW1vcnkgU3lzdGVt
IEFyY2hpdGVjdHVyZSBhdCBTLQ0KPiBFTDEvUy1FTDAuDQo+ID4gICAgICAgIFRoaXMgbWVhbnMg
aXQncyBwb3NzaWJsZSB0byBydW4gcmljaCBPUyBrZXJuZWxzIC0gbGlrZSBMaW51eCAtDQo+IGVp
dGhlcg0KPiA+ICAgICAgICBiYXJlLW1ldGFsIG9yIGFzIGEgZ3Vlc3QuDQo+ID4gLSBEaWZmZXJl
bmNlcyB3aXRoIHRoZSBBcm12OC1BIEFBcmNoNjQgYXJjaGl0ZWN0dXJlDQo+ID4gICAgICAtIFN1
cHBvcnRzIG9ubHkgYSBzaW5nbGUgU2VjdXJpdHkgc3RhdGUgLSBTZWN1cmUuIFRoZXJlIGlzIG5v
dCBOb24tDQo+IFNlY3VyZQ0KPiA+ICAgICAgICBleGVjdXRpb24gc3RhdGUgc3VwcG9ydGVkLg0K
PiANCj4gSWYgc28sIHRoZW4gSSBndWVzcyB0aGVyZSBpcyBubyBUcnVzdHpvbmUga2luZCBvZiBw
cm90ZWN0aW9uIGF2YWlsYWJsZS4NCj4gSSBtZWFuIHdoZXJlIGFwcGxpY2F0aW9uIGlzIG5vcm1h
bCB3b3JsZCBjYW4gcmVxdWVzdCBmb3IgZGF0YSB0byBiZQ0KPiBwcm9jZXNzZWQgaW4gc2VjdXJl
IHdvcmxkIChieSBzd2l0Y2hpbmcgdGhlIE5TIGJpdCBvbiBBWEkpLg0KPiANCg0KT24gQXJtdjgt
UiwgdGhlcmUgaXMgbm90IGFueSBub24tc2VjdXJlIGFwcGxpY2F0aW9uLiBBbGwgd29ya2xvYWRz
IG9uIEFybXY4LVINCmFyZSBzZWN1cmUuIEJ1dCBpbiBhIGhldGVyb2dlbmVvdXMgc3lzdGVtIChl
LmcuIGNvcnRleC1hICsgY29ydGV4LXIpLCB3ZSBjYW4NCnRyZWF0IHRoZSBlbnRpcmUgQXJtdjgt
UiBhcyBhIFRydXN0Wm9uZS4gVGhlIHRyYWRpdGlvbmFsIHNlY3VyZSBhcHBsaWNhdGlvbnMNCm9u
IENvcnRleC1BIFRydXN0Wm9uZSBjYW4gYmUgZGVwbG95ZWQgdG8gQXJtdjgtUiwgdGhlIE5TLWFw
cGxpY2F0aW9ucyBvbg0KQ29ydGV4LUEgY2FuIHVzZSBJUEMgdG8gc2VuZCByZXF1ZXN0IHRvIEFy
bXY4LVIgIlRydXN0Wm9uZSIuDQoNCj4gQWxzbywgZG9lcyBBcm12OC1SIHN1cHBvcnQgVHJ1c3R6
b25lIGNvbnRyb2xsZXIgNDAwIHdoaWNoIGhlbHBzIHRvDQo+IHBhcnRpdGlvbiBtZW1vcnkgaW50
byBkaWZmZXJlbnQgcHJvdGVjdGVkIGVuY2xhdmVzIGJhc2VkIG9uIE5TQUlEID8NCj4gDQo+IChB
cG9sb2dpZXMgaWYgbXkgcXVlcmllcyBhcmUgaXJyZWxldmFudCwgSSBhbSBhc2tpbmcgdGhpcyBw
dXJlbHkgb3V0IG9mDQo+IG15IG93biBpbnRlcmVzdCA6KSApDQoNClllcywgaWYgeW91IGhhdmUg
ZG93bmxvYWRlZCB0aGUgRlZQX0Jhc2VSX0FFTXY4UiwgeW91IGNhbiBmaW5kIGl0IGhhcw0KaW50
ZWdyYXRlZCB0aGlzIElQIGluIG1vZGVsLiBUaG91Z2gsIEkgZG9uJ3Qga25vdyB3aGF0IGlzIHRo
ZSB1c2UtY2FzZQ0Kb2YgaXQgb24gdGhlIFY4Ui4gQnV0IGZyb20gYXJjaGl0ZWN0dXJlJ3Mgdmll
dyB5b3UgY2FuIHVzZSBUWkMtNDAwIGZvcg0KQXJtdjgtUi4NCg0KPiANCj4gPiAgICAgIC0gRUwz
IGlzIG5vdCBzdXBwb3J0ZWQsIEVMMiBpcyBtYW5kYXRvcnkuIFRoaXMgbWVhbnMgc2VjdXJlIEVM
MiBpcw0KPiB0aGUNCj4gPiAgICAgICAgaGlnaGVzdCBFTC4NCj4gPiAgICAgIC0gU3VwcG9ydHMg
dGhlIEE2NCBJU0EgaW5zdHJ1Y3Rpb24NCj4gPiAgICAgICAgICAtIFdpdGggYSBzbWFsbCBzZXQg
b2Ygd2VsbC1kZWZpbmVkIGRpZmZlcmVuY2VzDQo+ID4gICAgICAtIFByb3ZpZGVzIGEgUE1TQSAo
UHJvdGVjdGVkIE1lbW9yeSBTeXN0ZW0gQXJjaGl0ZWN0dXJlKSBiYXNlZA0KPiA+ICAgICAgICB2
aXJ0dWFsaXphdGlvbiBtb2RlbC4NCj4gPiAgICAgICAgICAtIEFzIG9wcG9zZWQgdG8gQXJtdjgt
QSBBQXJjaDY0J3MgVk1TQSBiYXNlZCBWaXJ0dWFsaXphdGlvbg0KPiA+ICAgICAgICAgIC0gQ2Fu
IHN1cHBvcnQgYWRkcmVzcyBiaXRzIHVwIHRvIDUyIGlmIEZFQVRfTFBBIGlzIGVuYWJsZWQsDQo+
ID4gICAgICAgICAgICBvdGhlcndpc2UgNDggYml0cy4NCj4gPiAgICAgICAgICAtIERldGVybWlu
ZXMgdGhlIGFjY2VzcyBwZXJtaXNzaW9ucyBhbmQgbWVtb3J5IGF0dHJpYnV0ZXMgb2YNCj4gPiAg
ICAgICAgICAgIHRoZSB0YXJnZXQgUEEuDQo+ID4gICAgICAgICAgLSBDYW4gaW1wbGVtZW50IFBN
U0F2OC02NCBhdCBFTDEgYW5kIEVMMg0KPiA+ICAgICAgICAgICAgICAtIEFkZHJlc3MgdHJhbnNs
YXRpb24gZmxhdC1tYXBzIHRoZSBWQSB0byB0aGUgUEEgZm9yIEVMMg0KPiBTdGFnZSAxLg0KPiA+
ICAgICAgICAgICAgICAtIEFkZHJlc3MgdHJhbnNsYXRpb24gZmxhdC1tYXBzIHRoZSBWQSB0byB0
aGUgUEEgZm9yIEVMMQ0KPiBTdGFnZSAxLg0KPiA+ICAgICAgICAgICAgICAtIEFkZHJlc3MgdHJh
bnNsYXRpb24gZmxhdC1tYXBzIHRoZSBJUEEgdG8gdGhlIFBBIGZvciBFTDENCj4gU3RhZ2UgMi4N
Cj4gPiAgICAgIC0gUE1TQSBpbiBFTDEgJiBFTDIgaXMgY29uZmlndXJhYmxlLCBWTVNBIGluIEVM
MSBpcyBjb25maWd1cmFibGUuDQo+ID4NCj4gPiAjIyMgMS4yLiBYZW4gQ2hhbGxlbmdlcyB3aXRo
IFBNU0EgVmlydHVhbGl6YXRpb24NCj4gPiBYZW4gaXMgUE1TQSB1bmF3YXJlIFR5cGUtMSBIeXBl
cnZpc29yLCBpdCB3aWxsIG5lZWQgbW9kaWZpY2F0aW9ucyB0byBydW4NCj4gPiB3aXRoIGFuIE1Q
VSBhbmQgaG9zdCBtdWx0aXBsZSBndWVzdCBPU2VzLg0KPiA+DQo+ID4gLSBObyBNTVUgYXQgRUwy
Og0KPiA+ICAgICAgLSBObyBFTDIgU3RhZ2UgMSBhZGRyZXNzIHRyYW5zbGF0aW9uDQo+ID4gICAg
ICAgICAgLSBYZW4gcHJvdmlkZXMgZml4ZWQgQVJNNjQgdmlydHVhbCBtZW1vcnkgbGF5b3V0IGFz
IGJhc2lzIG9mDQo+IEVMMg0KPiA+ICAgICAgICAgICAgc3RhZ2UgMSBhZGRyZXNzIHRyYW5zbGF0
aW9uLCB3aGljaCBpcyBub3QgYXBwbGljYWJsZSBvbiBNUFUNCj4gc3lzdGVtLA0KPiA+ICAgICAg
ICAgICAgd2hlcmUgdGhlcmUgaXMgbm8gdmlydHVhbCBhZGRyZXNzaW5nLiBBcyBhIHJlc3VsdCwg
YW55DQo+IG9wZXJhdGlvbg0KPiA+ICAgICAgICAgICAgaW52b2x2aW5nIHRyYW5zaXRpb24gZnJv
bSBQQSB0byBWQSwgbGlrZSBpb3JlbWFwLCBuZWVkcw0KPiBtb2RpZmljYXRpb24NCj4gPiAgICAg
ICAgICAgIG9uIE1QVSBzeXN0ZW0uDQo+ID4gICAgICAtIFhlbidzIHJ1bi10aW1lIGFkZHJlc3Nl
cyBhcmUgdGhlIHNhbWUgYXMgdGhlIGxpbmsgdGltZSBhZGRyZXNzZXMuDQo+ID4gICAgICAgICAg
LSBFbmFibGUgUElDIChwb3NpdGlvbi1pbmRlcGVuZGVudCBjb2RlKSBvbiBhIHJlYWwtdGltZSB0
YXJnZXQNCj4gPiAgICAgICAgICAgIHByb2Nlc3NvciBwcm9iYWJseSB2ZXJ5IHJhcmUuDQo+ID4g
ICAgICAtIFhlbiB3aWxsIG5lZWQgdG8gdXNlIHRoZSBFTDIgTVBVIG1lbW9yeSByZWdpb24gZGVz
Y3JpcHRvcnMgdG8NCj4gbWFuYWdlDQo+ID4gICAgICAgIGFjY2VzcyBwZXJtaXNzaW9ucyBhbmQg
YXR0cmlidXRlcyBmb3IgYWNjZXNzZXMgbWFkZSBieSBWTXMgYXQNCj4gRUwxLzAuDQo+ID4gICAg
ICAgICAgLSBYZW4gY3VycmVudGx5IHJlbGllcyBvbiBNTVUgRUwxIHN0YWdlIDIgdGFibGUgdG8g
bWFuYWdlIHRoZXNlDQo+ID4gICAgICAgICAgICBhY2Nlc3Nlcy4NCj4gPiAtIE5vIE1NVSBTdGFn
ZSAyIHRyYW5zbGF0aW9uIGF0IEVMMToNCj4gPiAgICAgIC0gQSBndWVzdCBkb2Vzbid0IGhhdmUg
YW4gaW5kZXBlbmRlbnQgZ3Vlc3QgcGh5c2ljYWwgYWRkcmVzcyBzcGFjZQ0KPiA+ICAgICAgLSBB
IGd1ZXN0IGNhbiBub3QgcmV1c2UgdGhlIGN1cnJlbnQgSW50ZXJtZWRpYXRlIFBoeXNpY2FsIEFk
ZHJlc3MNCj4gPiAgICAgICAgbWVtb3J5IGxheW91dA0KPiA+ICAgICAgLSBBIGd1ZXN0IHVzZXMg
cGh5c2ljYWwgYWRkcmVzc2VzIHRvIGFjY2VzcyBtZW1vcnkgYW5kIGRldmljZXMNCj4gPiAgICAg
IC0gVGhlIE1QVSBhdCBFTDIgbWFuYWdlcyBFTDEgc3RhZ2UgMiBhY2Nlc3MgcGVybWlzc2lvbnMg
YW5kDQo+IGF0dHJpYnV0ZXMNCj4gPiAtIFRoZXJlIGFyZSBhIGxpbWl0ZWQgbnVtYmVyIG9mIE1Q
VSBwcm90ZWN0aW9uIHJlZ2lvbnMgYXQgYm90aCBFTDIgYW5kDQo+IEVMMToNCj4gPiAgICAgIC0g
QXJjaGl0ZWN0dXJhbGx5LCB0aGUgbWF4aW11bSBudW1iZXIgb2YgcHJvdGVjdGlvbiByZWdpb25z
IGlzIDI1NiwNCj4gPiAgICAgICAgdHlwaWNhbCBpbXBsZW1lbnRhdGlvbnMgaGF2ZSAzMi4NCj4g
PiAgICAgIC0gQnkgY29udHJhc3QsIFhlbiBkb2VzIG5vdCBuZWVkIHRvIGNvbnNpZGVyIHRoZSBu
dW1iZXIgb2YgcGFnZQ0KPiB0YWJsZQ0KPiA+ICAgICAgICBlbnRyaWVzIGluIHRoZW9yeSB3aGVu
IHVzaW5nIE1NVS4NCj4gPiAtIFRoZSBNUFUgcHJvdGVjdGlvbiByZWdpb25zIGF0IEVMMiBuZWVk
IHRvIGJlIHNoYXJlZCBiZXR3ZWVuIHRoZQ0KPiBoeXBlcnZpc29yDQo+ID4gICAgYW5kIHRoZSBn
dWVzdCBzdGFnZSAyLg0KPiA+ICAgICAgLSBSZXF1aXJlcyBjYXJlZnVsIGNvbnNpZGVyYXRpb24g
LSBtYXkgaW1wYWN0IGZlYXR1cmUgJ2Z1bGxuZXNzJyBvZg0KPiBib3RoDQo+ID4gICAgICAgIHRo
ZSBoeXBlcnZpc29yIGFuZCB0aGUgZ3Vlc3QNCj4gPiAgICAgIC0gQnkgY29udHJhc3QsIHdoZW4g
dXNpbmcgTU1VLCBYZW4gaGFzIHN0YW5kYWxvbmUgUDJNIHRhYmxlIGZvcg0KPiBndWVzdA0KPiA+
ICAgICAgICBzdGFnZSAyIGFjY2Vzc2VzLg0KPiBTbywgY2FuIGl0IHN1cHBvcnQgcnVubmluZyBi
b3RoIFJUT1MgYW5kIExpbnV4IGFzIGd1ZXN0cyA/IE15DQo+IHVuZGVyc3RhbmRpbmcgaXMgbm8g
YXMgd2UgY2FuJ3QgZW5hYmxlIE1QVSAoZm9yIFJUT1MpIGFuZCBNTVUgKGZvcg0KPiBMaW51eCkg
YXQgdGhlIHNhbWUgdGltZS4gVGhlcmUgbmVlZHMgdG8gYmUgdHdvIHNlcGFyYXRlIGltYWdlcyBv
ZiBYZW4uDQo+IFBsZWFzZSBjb25maXJtLg0KPiA+DQo+ID4gIyMgMi4gUHJvcG9zZWQgY2hhbmdl
cyBvZiBYZW4NCj4gPiAjIyMgKioyLjEuIENoYW5nZXMgb2YgYnVpbGQgc3lzdGVtOioqDQo+ID4N
Cj4gPiAtICoqKkludHJvZHVjZSBuZXcgS2NvbmZpZyBvcHRpb25zIGZvciBBcm12OC1SNjQqKio6
DQo+ID4gICAgVW5saWtlIEFybXY4LUEsIGJlY2F1c2UgbGFjayBvZiBNTVUgc3VwcG9ydCBvbiBB
cm12OC1SNjQsDQo+IEJ1dCBBcm12OC1SNjQgc3VwcG9ydHMgVk1TQSAoUmVmZXINCj4gQVJNIERE
SSAwNjAwQS5kIElEMTIwODIxLCBCMS4yLjIsDQo+IFZpcnR1YWwgTWVtb3J5IFN5c3RlbSBBcmNo
aXRlY3R1cmUsIFZNU0F2OC02NCkuIFNvIGl0IHNob3VsZCBzdXBwb3J0DQo+IE1NVSwgaXNuJ3Qg
aXQgPw0KPiANCg0KU29ycnksIG15IGRlc2NyaXB0aW9uIG9mIHRoaXMgc2VudGVuY2UgaXMgbm90
IGFjY3VyYXRlIGVub3VnaC4gSXQgc2hvdWxkIGJlDQoibGFjayBvZiBNTVUgc3VwcG9ydCBvbiBB
cm12OC1SNjQgRUwyIi4gT25seSBFTDEgY2FuIGJlIGNvbmZpZ3VyZWQgdG8gVk1TQS4NCkV2ZW4g
c28sIHRoZSBWTVNBIGluIEVMMSBzdXBwb3J0IGlzIG5vdCBtYW5kYXRvcnkuIElmIHlvdSB3YW50
IHRvIGVuYWJsZQ0KVk1TQSBpbiBFTDEgZm9yIGd1ZXN0LCB5b3UgaGF2ZSB0byBjaGVjayB0aGUg
SUQgcmVnaXN0ZXIgdG8gY29uZmlybSB5b3VyDQpwbGF0Zm9ybSBzdXBwb3J0IFZNU0EgaW4gRUwx
LiANCg0KPiAtIEF5YW4NCj4gPiB3ZSBtYXkgbm90DQo+ID4gICAgZXhwZWN0IG9uZSBYZW4gYmlu
YXJ5IHRvIHJ1biBvbiBhbGwgbWFjaGluZXMuIFhlbiBpbWFnZXMgYXJlIG5vdA0KPiBjb21tb24N
Cj4gPiAgICBhY3Jvc3MgQXJtdjgtUjY0IHBsYXRmb3Jtcy4gWGVuIG11c3QgYmUgcmUtYnVpbHQg
Zm9yIGRpZmZlcmVudCBBcm12OC0NCj4gUjY0DQo+ID4gICAgcGxhdGZvcm1zLiBCZWNhdXNlIHRo
ZXNlIHBsYXRmb3JtcyBtYXkgaGF2ZSBkaWZmZXJlbnQgbWVtb3J5IGxheW91dA0KPiBhbmQNCj4g
PiAgICBsaW5rIGFkZHJlc3MuDQo+ID4gICAgICAtIGBBUk02NF9WOFJgOg0KPiA+ICAgICAgICBU
aGlzIG9wdGlvbiBlbmFibGVzIEFybXY4LVIgcHJvZmlsZSBmb3IgQXJtNjQuIEVuYWJsaW5nIHRo
aXMNCj4gb3B0aW9uDQo+ID4gICAgICAgIHJlc3VsdHMgaW4gc2VsZWN0aW5nIE1QVS4gVGhpcyBL
Y29uZmlnIG9wdGlvbiBpcyB1c2VkIHRvIGdhdGUNCj4gc29tZQ0KPiA+ICAgICAgICBBcm12OC1S
NjQgc3BlY2lmaWMgY29kZSBleGNlcHQgTVBVIGNvZGUsIGxpa2Ugc29tZSBjb2RlIGZvcg0KPiBB
cm12OC1SNjQNCj4gPiAgICAgICAgb25seSBzeXN0ZW0gSUQgcmVnaXN0ZXJzIGFjY2Vzcy4NCj4g
Pg0KPiA+ICAgICAgLSBgQVJNX01QVWANCj4gPiAgICAgICAgVGhpcyBvcHRpb24gZW5hYmxlcyBN
UFUgb24gQVJNdjgtUiBhcmNoaXRlY3R1cmUuIEVuYWJsaW5nIHRoaXMNCj4gb3B0aW9uDQo+ID4g
ICAgICAgIHJlc3VsdHMgaW4gZGlzYWJsaW5nIE1NVS4gVGhpcyBLY29uZmlnIG9wdGlvbiBpcyB1
c2VkIHRvIGdhdGUNCj4gc29tZQ0KPiA+ICAgICAgICBBUk1fTVBVIHNwZWNpZmljIGNvZGUuIE9u
Y2Ugd2hlbiB0aGlzIEtjb25maWcgb3B0aW9uIGhhcyBiZWVuDQo+IGVuYWJsZWQsDQo+ID4gICAg
ICAgIHRoZSBNTVUgcmVsYXRlIGNvZGUgd2lsbCBub3QgYmUgYnVpbHQgZm9yIEFybXY4LVI2NC4g
VGhlIHJlYXNvbg0KPiB3aHkNCj4gPiAgICAgICAgbm90IGRlcGVuZHMgb24gcnVudGltZSBkZXRl
Y3Rpb24gdG8gc2VsZWN0IE1NVSBvciBNUFUgaXMgdGhhdCwgd2UNCj4gZG9uJ3QNCj4gPiAgICAg
ICAgdGhpbmsgd2UgY2FuIHVzZSBvbmUgaW1hZ2UgZm9yIGJvdGggQXJtdjgtUjY0IGFuZCBBcm12
OC1BNjQuDQo+IEFub3RoZXINCj4gPiAgICAgICAgcmVhc29uIHRoYXQgd2Ugc2VwYXJhdGUgTVBV
IGFuZCBWOFIgaW4gcHJvdmlzaW9uIHRvIGFsbG93IHRvDQo+IHN1cHBvcnQgTVBVDQo+ID4gICAg
ICAgIG9uIDMyYml0IEFybSBvbmUgZGF5Lg0KPiA+DQo+ID4gICAgICAtIGBYRU5fU1RBUlRfQURE
UkVTU2ANCj4gPiAgICAgICAgVGhpcyBvcHRpb24gYWxsb3dzIHRvIHNldCB0aGUgY3VzdG9tIGFk
ZHJlc3MgYXQgd2hpY2ggWGVuIHdpbGwgYmUNCj4gPiAgICAgICAgbGlua2VkLiBUaGlzIGFkZHJl
c3MgbXVzdCBiZSBhbGlnbmVkIHRvIGEgcGFnZSBzaXplLiBYZW4ncyBydW4tDQo+IHRpbWUNCj4g
PiAgICAgICAgYWRkcmVzc2VzIGFyZSB0aGUgc2FtZSBhcyB0aGUgbGluayB0aW1lIGFkZHJlc3Nl
cy4gRGlmZmVyZW50DQo+IHBsYXRmb3Jtcw0KPiA+ICAgICAgICBtYXkgaGF2ZSBkaWZmZXJudCBt
ZW1vcnkgbGF5b3V0LiBUaGlzIEtjb25maWcgb3B0aW9uIHByb3ZpZGVzDQo+IHVzZXJzDQo+ID4g
ICAgICAgIHRoZSBhYmlsaXR5IHRvIHNlbGVjdCBwcm9wZXIgbGluayBhZGRyZXNzZXMgZm9yIHRo
ZWlyIGJvYXJkcy4NCj4gPiAgICAgICAgKioqTm90ZXM6IEZpeGVkIGxpbmsgYWRkcmVzcyBtZWFu
cyB0aGUgWGVuIGJpbmFyeSBjb3VsZCBub3QgYmUqKioNCj4gPiAgICAgICAgKioqcmVsb2NhdGVk
IGJ5IEVGSSBsb2FkZXIuIFNvIGluIGN1cnJlbnQgc3RhZ2UsIFhlbiBjb3VsZCBub3QqKioNCj4g
PiAgICAgICAgKioqYmUgbGF1bmNoZWQgYXMgYW4gRUZJIGFwcGxpY2F0aW9uIG9uIEFybXY4LVI2
NC4qKioNCj4gPg0KPiA+ICAgICAgLSBgQVJNX01QVV9OT1JNQUxfTUVNT1JZX1NUQVJUYCBhbmQg
YEFSTV9NUFVfTk9STUFMX01FTU9SWV9FTkRgDQo+ID4gICAgICAgIGBBUk1fTVBVX0RFVklDRV9N
RU1PUllfU1RBUlRgIGFuZCBgQVJNX01QVV9ERVZJQ0VfTUVNT1JZX0VORGANCj4gPiAgICAgICAg
VGhlc2UgS2NvbmZpZyBvcHRpb25zIGFsbG93IHRvIHNldCBtZW1vcnkgcmVnaW9ucyBmb3IgWGVu
IGNvZGUsDQo+IGRhdGENCj4gPiAgICAgICAgYW5kIGRldmljZSBtZW1vcnkuIEJlZm9yZSBwYXJz
aW5nIG1lbW9yeSBpbmZvcm1hdGlvbiBmcm9tIGRldmljZQ0KPiB0cmVlLA0KPiA+ICAgICAgICBY
ZW4gd2lsbCB1c2UgdGhlIHZhbHVlcyB0aGF0IHN0b3JlZCBpbiB0aGVzZSBvcHRpb25zIHRvIHNl
dHVwDQo+IGJvb3QtdGltZQ0KPiA+ICAgICAgICBNUFUgY29uZmlndXJhdGlvbi4gV2h5IHdlIG5l
ZWQgYSBib290LXRpbWUgTVBVIGNvbmZpZ3VyYXRpb24/DQo+ID4gICAgICAgIDEuIE1vcmUgZGV0
ZXJtaW5pc3RpYzogQXJtIE1QVSBzdXBwb3J0cyBiYWNrZ3JvdW5kIHJlZ2lvbnMsDQo+ID4gICAg
ICAgICAgIGlmIHdlIGRvbid0IGNvbmZpZ3VyZSB0aGUgTVBVIHJlZ2lvbnMgYW5kIGRvbid0IGVu
YWJsZSBNUFUuDQo+ID4gICAgICAgICAgIFdlIGNhbiBlbmFibGUgTVBVIGJhY2tncm91bmQgcmVn
aW9ucy4gQnV0IHRoYXQgbWVhbnMgYWxsIFJBTQ0KPiA+ICAgICAgICAgICBpcyBSV1guIFJhbmRv
bSB2YWx1ZXMgaW4gUkFNIG9yIG1hbGljaW91c2x5IGVtYmVkZGVkIGRhdGEgY2FuDQo+ID4gICAg
ICAgICAgIGJlIGV4cGxvaXRlZC4gVXNpbmcgdGhlc2UgS2NvbmZpZyBvcHRpb25zIGFsbG93IHVz
ZXJzIHRvIGhhdmUNCj4gPiAgICAgICAgICAgYSBkZXRlcm1pbmlzdGljIFJBTSBhcmVhIHRvIGV4
ZWN1dGUgY29kZS4NCj4gPiAgICAgICAgMi4gTW9yZSBjb21wYXRpYmxlOiBPbiBzb21lIEFybXY4
LVI2NCBwbGF0Zm9ybXMsIGlmIHRoZSBNUFUgaXMNCj4gPiAgICAgICAgICAgZGlzYWJsZWQsIHRo
ZSBgZGMgenZhYCBpbnN0cnVjdGlvbiB3aWxsIG1ha2UgdGhlIHN5c3RlbSBoYWx0Lg0KPiA+ICAg
ICAgICAgICBBbmQgdGhpcyBpbnN0cnVjdGlvbiB3aWxsIGJlIGVtYmVkZGVkIGluIHNvbWUgYnVp
bHQtaW4NCj4gZnVuY3Rpb25zLA0KPiA+ICAgICAgICAgICBsaWtlIGBtZW1vcnkgc2V0YC4gSWYg
d2UgdXNlIGAtZGRvbnRfdXNlX2RjYCB0byByZWJ1aWxkIEdDQywNCj4gPiAgICAgICAgICAgdGhl
IGJ1aWx0LWluIGZ1bmN0aW9ucyB3aWxsIG5vdCBjb250YWluIGBkYyB6dmFgLiBIb3dldmVyLCBp
dA0KPiBpcw0KPiA+ICAgICAgICAgICBvYnZpb3VzbHkgdW5saWtlbHkgdGhhdCB3ZSB3aWxsIGJl
IGFibGUgdG8gcmVjb21waWxlIGFsbCBHQ0MNCj4gPiAgICAgICAgICAgZm9yIEFSTXY4LVI2NC4N
Cj4gPiAgICAgICAgMy4gT25lIG9wdGlvbmFsIGlkZWE6DQo+ID4gICAgICAgICAgICBXZSBjYW4g
bWFwIGBYRU5fU1RBUlRfQUREUkVTU2AgdG8gYFhFTl9TVEFSVF9BRERSRVNTICsgMk1CYA0KPiBv
cg0KPiA+ICAgICAgICAgICAgYFhFTl9TVEFSVF9BRERSRVNTYCB0byBgWEVOX1NUQVJUX0FERFJF
U1MgKyBpbWFnZV9lbmRgIGZvcg0KPiA+ICAgICAgICAgICAgTVBVIG5vcm1hbCBtZW1vcnkuIEl0
J3MgZW5vdWdoIHRvIHN1cHBvcnQgWGVuIHJ1biBpbiBib290DQo+IHRpbWUuDQo+ID4NCj4gPiAt
ICoqKkRlZmluZSBuZXcgc3lzdGVtIHJlZ2lzdGVycyBmb3IgY29tcGlsZXJzKioqOg0KPiA+ICAg
IEFybXY4LVI2NCBpcyBiYXNlZCBvbiBBcm12OC40LiBUaGF0IG1lYW5zIHdlIHdpbGwgdXNlIHNv
bWUgQXJtdjguNA0KPiA+ICAgIHNwZWNpZmljIHN5c3RlbSByZWdpc3RlcnMuIEFzIEFybXY4LVI2
NCBvbmx5IGhhdmUgc2VjdXJlIHN0YXRlLCBzbw0KPiA+ICAgIGF0IGxlYXN0LCBgVlNUQ1JfRUwy
YCBhbmQgYFZTQ1RMUl9FTDJgIHdpbGwgYmUgdXNlZCBmb3IgWGVuLiBBbmQgdGhlDQo+ID4gICAg
Zmlyc3QgR0NDIHZlcnNpb24gdGhhdCBzdXBwb3J0cyBBcm12OC40IGlzIEdDQyA4LjEuIEluIGFk
ZGl0aW9uIHRvDQo+ID4gICAgdGhlc2UsIFBNU0Egb2YgQXJtdjgtUjY0IGludHJvZHVjZWQgbG90
cyBvZiBNUFUgcmVsYXRlZCBzeXN0ZW0NCj4gcmVnaXN0ZXJzOg0KPiA+ICAgIGBQUkJBUl9FTHhg
LCBgUFJCQVJ4X0VMeGAsIGBQUkxBUl9FTHhgLCBgUFJMQVJ4X0VMeGAsIGBQUkVOUl9FTHhgIGFu
ZA0KPiA+ICAgIGBNUFVJUl9FTHhgLiBCdXQgdGhlIGZpcnN0IEdDQyB2ZXJzaW9uIHRvIHN1cHBv
cnQgdGhlc2Ugc3lzdGVtDQo+IHJlZ2lzdGVycw0KPiA+ICAgIGlzIEdDQyAxMS4gU28gd2UgaGF2
ZSB0d28gd2F5cyB0byBtYWtlIGNvbXBpbGVycyB0byB3b3JrIHByb3Blcmx5DQo+IHdpdGgNCj4g
PiAgICB0aGVzZSBzeXN0ZW0gcmVnaXN0ZXJzLg0KPiA+ICAgIDEuIEJ1bXAgR0NDIHZlcnNpb24g
dG8gR0NDIDExLg0KPiA+ICAgICAgIFRoZSBwcm9zIG9mIHRoaXMgbWV0aG9kIGlzIHRoYXQsIHdl
IGRvbid0IG5lZWQgdG8gZW5jb2RlIHRoZXNlDQo+ID4gICAgICAgc3lzdGVtIHJlZ2lzdGVycyBp
biBtYWNyb3MgYnkgb3Vyc2VsdmVzLiBCdXQgdGhlIGNvbnMgYXJlIHRoYXQsDQo+ID4gICAgICAg
d2UgaGF2ZSB0byB1cGRhdGUgTWFrZWZpbGVzIHRvIHN1cHBvcnQgR0NDIDExIGZvciBBcm12OC1S
NjQuDQo+ID4gICAgICAgMS4xLiBDaGVjayB0aGUgR0NDIHZlcnNpb24gMTEgZm9yIEFybXY4LVI2
NC4NCj4gPiAgICAgICAxLjIuIEFkZCBtYXJjaD1hcm12OHIgdG8gQ0ZMQUdTIGZvciBBcm12OC1S
NjQuDQo+ID4gICAgICAgMS4zLiBTb2x2ZSB0aGUgY29uZmxpY3Rpb24gb2YgbWFyY2g9YXJtdjhy
IGFuZCBtY3B1PWdlbmVyaWMNCj4gPiAgICAgIFRoZXNlIGNoYW5nZXMgd2lsbCBhZmZlY3QgY29t
bW9uIE1ha2VmaWxlcywgbm90IG9ubHkgQXJtIE1ha2VmaWxlcy4NCj4gPiAgICAgIEFuZCBHQ0Mg
MTEgaXMgbmV3LCBsb3RzIG9mIHRvb2xjaGFpbnMgYW5kIERpc3RybyBoYXZlbid0IHN1cHBvcnRl
ZA0KPiBpdC4NCj4gPg0KPiA+ICAgIDIuIEVuY29kZSBuZXcgc3lzdGVtIHJlZ2lzdGVycyBpbiBt
YWNyb3MgKioqKHByZWZlcnJlZCkqKioNCj4gPiAgICAgICAgICBgYGANCj4gPiAgICAgICAgICAv
KiBWaXJ0dWFsaXphdGlvbiBTZWN1cmUgVHJhbnNsYXRpb24gQ29udHJvbCBSZWdpc3RlciAqLw0K
PiA+ICAgICAgICAgICNkZWZpbmUgVlNUQ1JfRUwyICBTM180X0MyX0M2XzINCj4gPiAgICAgICAg
ICAvKiBWaXJ0dWFsaXphdGlvbiBTeXN0ZW0gQ29udHJvbCBSZWdpc3RlciAqLw0KPiA+ICAgICAg
ICAgICNkZWZpbmUgVlNDVExSX0VMMiBTM180X0MyX0MwXzANCj4gPiAgICAgICAgICAvKiBFTDEg
TVBVIFByb3RlY3Rpb24gUmVnaW9uIEJhc2UgQWRkcmVzcyBSZWdpc3RlciBlbmNvZGUgKi8NCj4g
PiAgICAgICAgICAjZGVmaW5lIFBSQkFSX0VMMSAgUzNfMF9DNl9DOF8wDQo+ID4gICAgICAgICAg
Li4uDQo+ID4gICAgICAgICAgLyogRUwyIE1QVSBQcm90ZWN0aW9uIFJlZ2lvbiBCYXNlIEFkZHJl
c3MgUmVnaXN0ZXIgZW5jb2RlICovDQo+ID4gICAgICAgICAgI2RlZmluZSBQUkJBUl9FTDIgIFMz
XzRfQzZfQzhfMA0KPiA+ICAgICAgICAgIC4uLg0KPiA+ICAgICAgICAgIGBgYA0KPiA+ICAgICAg
IElmIHdlIGVuY29kZSBhbGwgYWJvdmUgc3lzdGVtIHJlZ2lzdGVycywgd2UgZG9uJ3QgbmVlZCB0
byBidW1wIEdDQw0KPiA+ICAgICAgIHZlcnNpb24uIEFuZCB0aGUgY29tbW9uIENGTEFHUyBYZW4g
aXMgdXNpbmcgc3RpbGwgY2FuIGJlIGFwcGxpZWQNCj4gdG8NCj4gPiAgICAgICBBcm12OC1SNjQu
IFdlIGRvbid0IG5lZWQgdG8gbW9kaWZ5IE1ha2VmaWxlcyB0byBhZGQgc3BlY2lmaWMNCj4gQ0ZM
QUdTLg0KPiA+DQo+ID4gIyMjICoqMi4yLiBDaGFuZ2VzIG9mIHRoZSBpbml0aWFsaXphdGlvbiBw
cm9jZXNzKioNCj4gPiBJbiBnZW5lcmFsLCB3ZSBzdGlsbCBleHBlY3QgQXJtdjgtUjY0IGFuZCBB
cm12OC1BNjQgdG8gaGF2ZSBhIGNvbnNpc3RlbnQNCj4gPiBpbml0aWFsaXphdGlvbiBwcm9jZXNz
LiBJbiBhZGRpdGlvbiB0byBzb21lIGFyY2hpdGVjdHVyZSBkaWZmZXJlbmNlcywNCj4gdGhlcmUN
Cj4gPiBpcyBubyBtb3JlIHRoYW4gcmV1c2FibGUgY29kZSB0aGF0IHdlIHdpbGwgZGlzdGluZ3Vp
c2ggdGhyb3VnaA0KPiBDT05GSUdfQVJNX01QVQ0KPiA+IG9yIENPTkZJR19BUk02NF9WOFIuIFdl
IHdhbnQgbW9zdCBvZiB0aGUgaW5pdGlhbGl6YXRpb24gY29kZSB0byBiZQ0KPiByZXVzYWJsZQ0K
PiA+IGJldHdlZW4gQXJtdjgtUjY0IGFuZCBBcm12OC1BNjQuDQo+ID4NCj4gPiAtIFdlIHdpbGwg
cmV1c2UgdGhlIG9yaWdpbmFsIGhlYWQucyBhbmQgc2V0dXAuYyBvZiBBcm0uIEJ1dCByZXBsYWNl
IHRoZQ0KPiA+ICAgIE1NVSBhbmQgcGFnZSB0YWJsZSBvcGVyYXRpb25zIGluIHRoZXNlIGZpbGVz
IHdpdGggY29uZmlndXJhdGlvbg0KPiBvcGVyYXRpb25zDQo+ID4gICAgZm9yIE1QVSBhbmQgTVBV
IHJlZ2lvbnMuDQo+ID4NCj4gPiAtIFdlIHByb3ZpZGUgYSBib290LXRpbWUgTVBVIGNvbmZpZ3Vy
YXRpb24uIFRoaXMgTVBVIGNvbmZpZ3VyYXRpb24gd2lsbA0KPiA+ICAgIHN1cHBvcnQgWGVuIHRv
IGZpbmlzaCBpdHMgaW5pdGlhbGl6YXRpb24uIEFuZCB0aGlzIGJvb3QtdGltZSBNUFUNCj4gPiAg
ICBjb25maWd1cmF0aW9uIHdpbGwgcmVjb3JkIHRoZSBtZW1vcnkgcmVnaW9ucyB0aGF0IHdpbGwg
YmUgcGFyc2VkIGZyb20NCj4gPiAgICBkZXZpY2UgdHJlZS4NCj4gPg0KPiA+ICAgIEluIHRoZSBl
bmQgb2YgWGVuIGluaXRpYWxpemF0aW9uLCB3ZSB3aWxsIHVzZSBhIHJ1bnRpbWUgTVBVDQo+IGNv
bmZpZ3VyYXRpb24NCj4gPiAgICB0byByZXBsYWNlIGJvb3QtdGltZSBNUFUgY29uZmlndXJhdGlv
bi4gVGhlIHJ1bnRpbWUgTVBVIGNvbmZpZ3VyYXRpb24NCj4gd2lsbA0KPiA+ICAgIG1lcmdlIGFu
ZCByZW9yZGVyIG1lbW9yeSByZWdpb25zIHRvIHNhdmUgbW9yZSBNUFUgcmVnaW9ucyBmb3IgZ3Vl
c3RzLg0KPiA+ICAgICFbaW1nXShodHRwczovL2RyaXZlLmdvb2dsZS5jb20vdWM/ZXhwb3J0PXZp
ZXcmaWQ9MXdURnlLMlhmVTNsVGxIMVBxUg0KPiBEb2FjUVZUd1V0V0lHVSkNCj4gPg0KPiA+IC0g
RGVmZXIgc3lzdGVtIHVucGF1c2luZyBkb21haW4uDQo+ID4gICAgV2hlbiBYZW4gaW5pdGlhbGl6
YXRpb24gaXMgYWJvdXQgdG8gZW5kLCBYZW4gdW5wYXVzZSBndWVzdHMgY3JlYXRlZA0KPiA+ICAg
IGR1cmluZyBpbml0aWFsaXphdGlvbi4gQnV0IHRoaXMgd2lsbCBjYXVzZSBzb21lIGlzc3Vlcy4g
VGhlIHVucGF1c2UNCj4gPiAgICBhY3Rpb24gb2NjdXJzIGJlZm9yZSBmcmVlX2luaXRfbWVtb3J5
LCBob3dldmVyIHRoZSBydW50aW1lIE1QVQ0KPiBjb25maWd1cmF0aW9uDQo+ID4gICAgaXMgYnVp
bHQgYWZ0ZXIgZnJlZV9pbml0X21lbW9yeS4NCj4gPg0KPiA+ICAgIFNvIGlmIHRoZSB1bnBhdXNl
ZCBndWVzdHMgc3RhcnQgZXhlY3V0aW5nIHRoZSBjb250ZXh0IHN3aXRjaCBhdCB0aGlzDQo+ID4g
ICAgcG9pbnQsIHRoZW4gaXRzIE1QVSBjb250ZXh0IHdpbGwgYmFzZSBvbiB0aGUgYm9vdC10aW1l
IE1QVQ0KPiBjb25maWd1cmF0aW9uLg0KPiA+ICAgIFByb2JhYmx5IGl0IHdpbGwgYmUgaW5jb25z
aXN0ZW50IHdpdGggcnVudGltZSBNUFUgY29uZmlndXJhdGlvbiwgdGhpcw0KPiA+ICAgIHdpbGwg
Y2F1c2UgdW5leHBlY3RlZCBwcm9ibGVtcyAoVGhpcyBtYXkgbm90IGhhcHBlbiBpbiBhIHNpbmds
ZSBjb3JlDQo+ID4gICAgc3lzdGVtLCBidXQgb24gU01QIHN5c3RlbXMsIHRoaXMgcHJvYmxlbSBp
cyBmb3Jlc2VlYWJsZSwgc28gd2UgaG9wZQ0KPiB0bw0KPiA+ICAgIHNvbHZlIGl0IGF0IHRoZSBi
ZWdpbm5pbmcpLg0KPiA+DQo+ID4gIyMjICoqMi4zLiBDaGFuZ2VzIHRvIHJlZHVjZSBtZW1vcnkg
ZnJhZ21lbnRhdGlvbioqDQo+ID4NCj4gPiBJbiBnZW5lcmFsLCBtZW1vcnkgaW4gWGVuIHN5c3Rl
bSBjYW4gYmUgY2xhc3NpZmllZCB0byA0IGNsYXNzZXM6DQo+ID4gYGltYWdlIHNlY3Rpb25zYCwg
YGhlYXAgc2VjdGlvbnNgLCBgZ3Vlc3QgUkFNYCwgYGJvb3QgbW9kdWxlcyAoZ3Vlc3QNCj4gS2Vy
bmVsLA0KPiA+IGluaXRyZCBhbmQgZHRiKWANCj4gPg0KPiA+IEN1cnJlbnRseSwgWGVuIGRvZXNu
J3QgaGF2ZSBhbnkgcmVzdHJpY3Rpb24gZm9yIHVzZXJzIGhvdyB0byBhbGxvY2F0ZQ0KPiA+IG1l
bW9yeSBmb3IgZGlmZmVyZW50IGNsYXNzZXMuIFRoYXQgbWVhbnMgdXNlcnMgY2FuIHBsYWNlIGJv
b3QgbW9kdWxlcw0KPiA+IGFueXdoZXJlLCBjYW4gcmVzZXJ2ZSBYZW4gaGVhcCBtZW1vcnkgYW55
d2hlcmUgYW5kIGNhbiBhbGxvY2F0ZSBndWVzdA0KPiA+IG1lbW9yeSBhbnl3aGVyZS4NCj4gPg0K
PiA+IEluIGEgVk1TQSBzeXN0ZW0sIHRoaXMgd291bGQgbm90IGJlIHRvbyBtdWNoIG9mIGEgcHJv
YmxlbSwgc2luY2UgdGhlDQo+ID4gTU1VIGNhbiBtYW5hZ2UgbWVtb3J5IGF0IGEgZ3JhbnVsYXJp
dHkgb2YgNEtCIGFmdGVyIGFsbC4gQnV0IGluIGENCj4gPiBQTVNBIHN5c3RlbSwgdGhpcyB3aWxs
IGJlIGEgYmlnIHByb2JsZW0uIE9uIEFybXY4LVI2NCwgdGhlIG1heCBNUFUNCj4gPiBwcm90ZWN0
aW9uIHJlZ2lvbnMgbnVtYmVyIGhhcyBiZWVuIGxpbWl0ZWQgdG8gMjU2LiBCdXQgaW4gdHlwaWNh
bA0KPiA+IHByb2Nlc3NvciBpbXBsZW1lbnRhdGlvbnMsIGZldyBwcm9jZXNzb3JzIHdpbGwgZGVz
aWduIG1vcmUgdGhhbiAzMg0KPiA+IE1QVSBwcm90ZWN0aW9uIHJlZ2lvbnMuIEFkZCBpbiB0aGUg
ZmFjdCB0aGF0IFhlbiBzaGFyZXMgTVBVIHByb3RlY3Rpb24NCj4gPiByZWdpb25zIHdpdGggZ3Vl
c3QncyBFTDEgU3RhZ2UgMi4gSXQgYmVjb21lcyBldmVuIG1vcmUgaW1wb3J0YW50DQo+ID4gdG8g
cHJvcGVybHkgcGxhbiB0aGUgdXNlIG9mIE1QVSBwcm90ZWN0aW9uIHJlZ2lvbnMuDQo+ID4NCj4g
PiAtIEFuIGlkZWFsIG9mIG1lbW9yeSB1c2FnZSBsYXlvdXQgcmVzdHJpY3Rpb246DQo+ID4gIVtp
bWddKGh0dHBzOi8vZHJpdmUuZ29vZ2xlLmNvbS91Yz9leHBvcnQ9dmlldyZpZD0xa2lyT0wwVHgy
YUF5cFR0ZDNrWEF0DQo+IGQ3NVh0cm5nY25XKQ0KPiA+IDEuIFJlc2VydmUgcHJvcGVyIE1QVSBy
ZWdpb25zIGZvciBYZW4gaW1hZ2UgKGNvZGUsIHJvZGF0YSBhbmQgZGF0YSArDQo+IGJzcykuDQo+
ID4gMi4gUmVzZXJ2ZSBvbmUgTVBVIHJlZ2lvbiBmb3IgYm9vdCBtb2R1bGVzLg0KPiA+ICAgICBU
aGF0IG1lYW5zIHRoZSBwbGFjZW1lbnQgb2YgYWxsIGJvb3QgbW9kdWxlcywgaW5jbHVkZSBndWVz
dCBrZXJuZWwsDQo+ID4gICAgIGluaXRyZCBhbmQgZHRiLCB3aWxsIGJlIGxpbWl0ZWQgdG8gdGhp
cyBNUFUgcmVnaW9uIHByb3RlY3RlZCBhcmVhLg0KPiA+IDMuIFJlc2VydmUgb25lIG9yIG1vcmUg
TVBVIHJlZ2lvbnMgZm9yIFhlbiBoZWFwLg0KPiA+ICAgICBPbiBBcm12OC1SNjQsIHRoZSBndWVz
dCBtZW1vcnkgaXMgcHJlZGVmaW5lZCBpbiBkZXZpY2UgdHJlZSwgaXQgd2lsbA0KPiA+ICAgICBu
b3QgYmUgYWxsb2NhdGVkIGZyb20gaGVhcC4gVW5saWtlIEFybXY4LUE2NCwgd2Ugd2lsbCBub3Qg
bW92ZSBhbGwNCj4gPiAgICAgZnJlZSBtZW1vcnkgdG8gaGVhcC4gV2Ugd2FudCBYZW4gaGVhcCBp
cyBkZXJ0ZXJtaXN0aWMgdG9vLCBzbyBYZW4gb24NCj4gPiAgICAgQXJtdjgtUjY0IGFsc28gcmVs
eSBvbiBYZW4gc3RhdGljIGhlYXAgZmVhdHVyZS4gVGhlIG1lbW9yeSBmb3IgWGVuDQo+ID4gICAg
IGhlYXAgd2lsbCBiZSBkZWZpbmVkIGluIHRyZWUgdG9vLiBDb25zaWRlcmluZyB0aGF0IHBoeXNp
Y2FsIG1lbW9yeQ0KPiA+ICAgICBjYW4gYWxzbyBiZSBkaXNjb250aW51b3VzLCBvbmUgb3IgbW9y
ZSBNUFUgcHJvdGVjdGlvbiByZWdpb25zIG5lZWRzDQo+ID4gICAgIHRvIGJlIHJlc2VydmVkIGZv
ciBYZW4gSEVBUC4NCj4gPiA0LiBJZiB3ZSBuYW1lIGFib3ZlIHVzZWQgTVBVIHByb3RlY3Rpb24g
cmVnaW9ucyBQQVJUX0EsIGFuZCBuYW1lIGxlZnQNCj4gPiAgICAgTVBVIHByb3RlY3Rpb24gcmVn
aW9ucyBQQVJUX0I6DQo+ID4gICAgIDQuMS4gSW4gaHlwZXJ2aXNvciBjb250ZXh0LCBYZW4gd2ls
bCBtYXAgbGVmdCBSQU0gYW5kIGRldmljZXMgdG8NCj4gUEFSVF9CLg0KPiA+ICAgICAgICAgIFRo
aXMgd2lsbCBnaXZlIFhlbiB0aGUgYWJpbGl0eSB0byBhY2Nlc3Mgd2hvbGUgbWVtb3J5Lg0KPiA+
ICAgICA0LjIuIEluIGd1ZXN0IGNvbnRleHQsIFhlbiB3aWxsIGNyZWF0ZSBFTDEgc3RhZ2UgMiBt
YXBwaW5nIGluIFBBUlRfQi4NCj4gPiAgICAgICAgICBJbiB0aGlzIGNhc2UsIFhlbiBqdXN0IG5l
ZWQgdG8gdXBkYXRlIFBBUlRfQiBpbiBjb250ZXh0IHN3aXRjaCwNCj4gPiAgICAgICAgICBidXQg
a2VlcCBQQVJUX0EgYXMgZml4ZWQuDQo+ID4NCj4gPiAqKipOb3RlczogU3RhdGljIGFsbG9jYXRp
b24gd2lsbCBiZSBtYW5kYXRvcnkgb24gTVBVIGJhc2VkIHN5c3RlbXMqKioNCj4gPg0KPiA+ICoq
QSBzYW1wbGUgZGV2aWNlIHRyZWUgb2YgbWVtb3J5IGxheW91dCByZXN0cmljdGlvbioqOg0KPiA+
IGBgYA0KPiA+IGNob3NlbiB7DQo+ID4gICAgICAuLi4NCj4gPiAgICAgIC8qDQo+ID4gICAgICAg
KiBEZWZpbmUgYSBzZWN0aW9uIHRvIHBsYWNlIGJvb3QgbW9kdWxlcywNCj4gPiAgICAgICAqIGFs
bCBib290IG1vZHVsZXMgbXVzdCBiZSBwbGFjZWQgaW4gdGhpcyBzZWN0aW9uLg0KPiA+ICAgICAg
ICovDQo+ID4gICAgICBtcHUsYm9vdC1tb2R1bGUtc2VjdGlvbiA9IDwweDEwMDAwMDAwIDB4MTAw
MDAwMDA+Ow0KPiA+ICAgICAgLyoNCj4gPiAgICAgICAqIERlZmluZSBhIHNlY3Rpb24gdG8gY292
ZXIgYWxsIGd1ZXN0IFJBTS4gQWxsIGd1ZXN0IFJBTSBtdXN0IGJlDQo+IGxvY2F0ZWQNCj4gPiAg
ICAgICAqIHdpdGhpbiB0aGlzIHNlY3Rpb24uIFRoZSBwcm9zIGlzIHRoYXQsIGluIGJlc3QgY2Fz
ZSwgd2UgY2FuIG9ubHkNCj4gaGF2ZQ0KPiA+ICAgICAgICogb25lIE1QVSBwcm90ZWN0aW9uIHJl
Z2lvbiB0byBtYXAgYWxsIGd1ZXN0IFJBTSBmb3IgWGVuLg0KPiA+ICAgICAgICovDQo+ID4gICAg
ICBtcHUsZ3Vlc3QtbWVtb3J5LXNlY3Rpb24gPSA8MHgyMDAwMDAwMCAweDMwMDAwMDAwPjsNCj4g
PiAgICAgIC8qDQo+ID4gICAgICAgKiBEZWZpbmUgYSBtZW1vcnkgc2VjdGlvbiB0aGF0IGNhbiBj
b3ZlciBhbGwgZGV2aWNlIG1lbW9yeSB0aGF0DQo+ID4gICAgICAgKiB3aWxsIGJlIHVzZWQgaW4g
WGVuLg0KPiA+ICAgICAgICovDQo+ID4gICAgICBtcHUsZGV2aWNlLW1lbW9yeS1zZWN0aW9uID0g
PDB4ODAwMDAwMDAgMHg3ZmZmZjAwMD47DQo+ID4gICAgICAvKiBEZWZpbmUgYSBzZWN0aW9uIGZv
ciBYZW4gaGVhcCAqLw0KPiA+ICAgICAgeGVuLHN0YXRpYy1tZW0gPSA8MHg1MDAwMDAwMCAweDIw
MDAwMDAwPjsNCj4gPg0KPiA+ICAgICAgZG9tVTEgew0KPiA+ICAgICAgICAgIC4uLg0KPiA+ICAg
ICAgICAgICN4ZW4sc3RhdGljLW1lbS1hZGRyZXNzLWNlbGxzID0gPDB4MDE+Ow0KPiA+ICAgICAg
ICAgICN4ZW4sc3RhdGljLW1lbS1zaXplLWNlbGxzID0gPDB4MDE+Ow0KPiA+ICAgICAgICAgIC8q
IFN0YXRpY2FsbHkgYWxsb2NhdGVkIGd1ZXN0IG1lbW9yeSwgd2l0aGluIG1wdSxndWVzdC1tZW1v
cnktDQo+IHNlY3Rpb24gKi8NCj4gPiAgICAgICAgICB4ZW4sc3RhdGljLW1lbSA9IDwweDMwMDAw
MDAwIDB4MWYwMDAwMDA+Ow0KPiA+DQo+ID4gICAgICAgICAgbW9kdWxlQDExMDAwMDAwIHsNCj4g
PiAgICAgICAgICAgICAgY29tcGF0aWJsZSA9ICJtdWx0aWJvb3Qsa2VybmVsXDBtdWx0aWJvb3Qs
bW9kdWxlIjsNCj4gPiAgICAgICAgICAgICAgLyogQm9vdCBtb2R1bGUgYWRkcmVzcywgd2l0aGlu
IG1wdSxib290LW1vZHVsZS1zZWN0aW9uICovDQo+ID4gICAgICAgICAgICAgIHJlZyA9IDwweDEx
MDAwMDAwIDB4MzAwMDAwMD47DQo+ID4gICAgICAgICAgICAgIC4uLg0KPiA+ICAgICAgICAgIH07
DQo+ID4NCj4gPiAgICAgICAgICBtb2R1bGVAMTBGRjAwMDAgew0KPiA+ICAgICAgICAgICAgICAg
ICAgY29tcGF0aWJsZSA9ICJtdWx0aWJvb3QsZGV2aWNlLXRyZWVcMG11bHRpYm9vdCxtb2R1bGUi
Ow0KPiA+ICAgICAgICAgICAgICAgICAgLyogQm9vdCBtb2R1bGUgYWRkcmVzcywgd2l0aGluIG1w
dSxib290LW1vZHVsZS1zZWN0aW9uDQo+ICovDQo+ID4gICAgICAgICAgICAgICAgICByZWcgPSA8
MHgxMGZmMDAwMCAweDEwMDAwPjsNCj4gPiAgICAgICAgICAgICAgICAgIC4uLg0KPiA+ICAgICAg
ICAgIH07DQo+ID4gICAgICB9Ow0KPiA+IH07DQo+ID4gYGBgDQo+ID4NCj4gPiAjIyMgKioyLjQu
IENoYW5nZXMgb2YgbWVtb3J5IG1hbmFnZW1lbnQqKg0KPiA+IFhlbiBpcyBjb3VwbGVkIHdpdGgg
Vk1TQSwgaW4gb3JkZXIgdG8gcG9ydCBYZW4gdG8gQXJtdjgtUjY0LCB3ZSBoYXZlIHRvDQo+ID4g
ZGVjb3VwbGUgWGVuIGZyb20gVk1TQS4gQW5kIGdpdmUgWGVuIHRoZSBhYmlsaXR5IHRvIG1hbmFn
ZSBtZW1vcnkgaW4NCj4gUE1TQS4NCj4gPg0KPiA+IDEuICoqKlVzZSBidWRkeSBhbGxvY2F0b3Ig
dG8gbWFuYWdlIHBoeXNpY2FsIHBhZ2VzIGZvciBQTVNBKioqDQo+ID4gICAgIEZyb20gdGhlIHZp
ZXcgb2YgcGh5c2ljYWwgcGFnZSwgUE1TQSBhbmQgVk1TQSBkb24ndCBoYXZlIGFueQ0KPiBkaWZm
ZXJlbmNlLg0KPiA+ICAgICBTbyB3ZSBjYW4gcmV1c2UgYnVkZHkgYWxsb2NhdG9yIG9uIEFybXY4
LVI2NCB0byBtYW5hZ2UgcGh5c2ljYWwNCj4gcGFnZXMuDQo+ID4gICAgIFRoZSBkaWZmZXJlbmNl
IGlzIHRoYXQsIGluIFZNU0EsIFhlbiB3aWxsIG1hcCBhbGxvY2F0ZWQgcGFnZXMgdG8NCj4gdmly
dHVhbA0KPiA+ICAgICBhZGRyZXNzZXMuIEJ1dCBpbiBQTVNBLCBYZW4ganVzdCBjb252ZXJ0IHRo
ZSBwYWdlcyB0byBwaHlzaWNhbA0KPiBhZGRyZXNzLg0KPiA+DQo+ID4gMi4gKioqQ2FuIG5vdCB1
c2UgdmlydHVhbCBhZGRyZXNzIGZvciBtZW1vcnkgbWFuYWdlbWVudCoqKg0KPiA+ICAgICBBcyBB
cm12OC1SNjQgb25seSBoYXMgUE1TQSBpbiBFTDIsIFhlbiBsb3NlcyB0aGUgYWJpbGl0eSBvZiB1
c2luZw0KPiB2aXJ0dWFsDQo+ID4gICAgIGFkZHJlc3MgdG8gbWFuYWdlIG1lbW9yeS4gVGhpcyBi
cmluZ3Mgc29tZSBwcm9ibGVtcywgc29tZSB2aXJ0dWFsDQo+IGFkZHJlc3MNCj4gPiAgICAgYmFz
ZWQgZmVhdHVyZXMgY291bGQgbm90IHdvcmsgd2VsbCBvbiBBcm12OC1SNjQsIGxpa2UgYEZJWE1B
UGAsDQo+IGB2bWFwL3Z1bWFwYCwNCj4gPiAgICAgYGlvcmVtYXBgIGFuZCBgYWx0ZXJuYXRpdmVg
Lg0KPiA+DQo+ID4gICAgIEJ1dCB0aGUgZnVuY3Rpb25zIG9yIG1hY3JvcyBvZiB0aGVzZSBmZWF0
dXJlcyBhcmUgdXNlZCBpbiBsb3RzIG9mDQo+IGNvbW1vbg0KPiA+ICAgICBjb2RlLiBTbyBpdCdz
IG5vdCBnb29kIHRvIHVzZSBgI2lmZGVmIENPTkZJR19BUk1fTVBVYCB0byBnYXRlIHJlbGF0ZQ0K
PiBjb2RlDQo+ID4gICAgIGV2ZXJ5d2hlcmUuIEluIHRoaXMgY2FzZSwgd2UgcHJvcG9zZSB0byB1
c2Ugc3R1YiBoZWxwZXJzIHRvIG1ha2UgdGhlDQo+IGNoYW5nZXMNCj4gPiAgICAgdHJhbnNwYXJl
bnRseSB0byBjb21tb24gY29kZS4NCj4gPiAgICAgMS4gRm9yIGBGSVhNQVBgLCB3ZSB3aWxsIHVz
ZSBgMGAgaW4gYEZJWE1BUF9BRERSYCBmb3IgYWxsIGZpeG1hcA0KPiBvcGVyYXRpb25zLg0KPiA+
ICAgICAgICBUaGlzIHdpbGwgcmV0dXJuIHBoeXNpY2FsIGFkZHJlc3MgZGlyZWN0bHkgb2YgZml4
bWFwcGVkIGl0ZW0uDQo+ID4gICAgIDIuIEZvciBgdm1hcC92dW1hcGAsIHdlIHdpbGwgdXNlIHNv
bWUgZW1wdHkgaW5saW5lIHN0dWIgaGVscGVyczoNCj4gPiAgICAgICAgICBgYGANCj4gPiAgICAg
ICAgICBzdGF0aWMgaW5saW5lIHZvaWQgdm1faW5pdF90eXBlKC4uLikge30NCj4gPiAgICAgICAg
ICBzdGF0aWMgaW5saW5lIHZvaWQgKl9fdm1hcCguLi4pDQo+ID4gICAgICAgICAgew0KPiA+ICAg
ICAgICAgICAgICByZXR1cm4gTlVMTDsNCj4gPiAgICAgICAgICB9DQo+ID4gICAgICAgICAgc3Rh
dGljIGlubGluZSB2b2lkIHZ1bm1hcChjb25zdCB2b2lkICp2YSkge30NCj4gPiAgICAgICAgICBz
dGF0aWMgaW5saW5lIHZvaWQgKnZtYWxsb2Moc2l6ZV90IHNpemUpDQo+ID4gICAgICAgICAgew0K
PiA+ICAgICAgICAgICAgICByZXR1cm4gTlVMTDsNCj4gPiAgICAgICAgICB9DQo+ID4gICAgICAg
ICAgc3RhdGljIGlubGluZSB2b2lkICp2bWFsbG9jX3hlbihzaXplX3Qgc2l6ZSkNCj4gPiAgICAg
ICAgICB7DQo+ID4gICAgICAgICAgICAgIHJldHVybiBOVUxMOw0KPiA+ICAgICAgICAgIH0NCj4g
PiAgICAgICAgICBzdGF0aWMgaW5saW5lIHZvaWQgdmZyZWUodm9pZCAqdmEpIHt9DQo+ID4gICAg
ICAgICAgYGBgDQo+ID4NCj4gPiAgICAgMy4gRm9yIGBpb3JlbWFwYCwgaXQgZGVwZW5kcyBvbiBg
dm1hcGAuIEFzIHdlIGhhdmUgbWFrZSBgdm1hcGAgdG8NCj4gYWx3YXlzDQo+ID4gICAgICAgIHJl
dHVybiBgTlVMTGAsIHRoZXkgY291bGQgbm90IHdvcmsgd2VsbCBvbiBBcm12OC1SNjQgd2l0aG91
dA0KPiBjaGFuZ2VzLg0KPiA+ICAgICAgICBgaW9yZW1hcGAgd2lsbCByZXR1cm4gaW5wdXQgYWRk
cmVzcyBkaXJlY3RseS4NCj4gPiAgICAgICAgICBgYGANCj4gPiAgICAgICAgICBzdGF0aWMgaW5s
aW5lIHZvaWQgKmlvcmVtYXBfYXR0ciguLi4pDQo+ID4gICAgICAgICAgew0KPiA+ICAgICAgICAg
ICAgICAvKiBXZSBkb24ndCBoYXZlIHRoZSBhYmlsaXR5IHRvIGNoYW5nZSBpbnB1dCBQQSBjYWNo
ZQ0KPiBhdHRyaWJ1dGVzICovDQo+ID4gICAgICAgICAgICAgIGlmICggQ0FDSEVfQVRUUl9uZWVk
X2NoYW5nZSApDQo+ID4gICAgICAgICAgICAgICAgICByZXR1cm4gTlVMTDsNCj4gPiAgICAgICAg
ICAgICAgcmV0dXJuICh2b2lkICopcGE7DQo+ID4gICAgICAgICAgfQ0KPiA+ICAgICAgICAgIHN0
YXRpYyBpbmxpbmUgdm9pZCBfX2lvbWVtICppb3JlbWFwX25vY2FjaGUoLi4uKQ0KPiA+ICAgICAg
ICAgIHsNCj4gPiAgICAgICAgICAgICAgcmV0dXJuIGlvcmVtYXBfYXR0cihzdGFydCwgbGVuLCBQ
QUdFX0hZUEVSVklTT1JfTk9DQUNIRSk7DQo+ID4gICAgICAgICAgfQ0KPiA+ICAgICAgICAgIHN0
YXRpYyBpbmxpbmUgdm9pZCBfX2lvbWVtICppb3JlbWFwX2NhY2hlKC4uLikNCj4gPiAgICAgICAg
ICB7DQo+ID4gICAgICAgICAgICAgIHJldHVybiBpb3JlbWFwX2F0dHIoc3RhcnQsIGxlbiwgUEFH
RV9IWVBFUlZJU09SKTsNCj4gPiAgICAgICAgICB9DQo+ID4gICAgICAgICAgc3RhdGljIGlubGlu
ZSB2b2lkIF9faW9tZW0gKmlvcmVtYXBfd2MoLi4uKQ0KPiA+ICAgICAgICAgIHsNCj4gPiAgICAg
ICAgICAgICAgcmV0dXJuIGlvcmVtYXBfYXR0cihzdGFydCwgbGVuLCBQQUdFX0hZUEVSVklTT1Jf
V0MpOw0KPiA+ICAgICAgICAgIH0NCj4gPiAgICAgICAgICB2b2lkICppb3JlbWFwKC4uLikNCj4g
PiAgICAgICAgICB7DQo+ID4gICAgICAgICAgICAgIHJldHVybiBpb3JlbWFwX2F0dHIocGEsIGxl
biwgUEFHRV9IWVBFUlZJU09SX05PQ0FDSEUpOw0KPiA+ICAgICAgICAgIH0NCj4gPg0KPiA+ICAg
ICAgICAgIGBgYA0KPiA+ICAgICAgNC4gRm9yIGBhbHRlcm5hdGl2ZWAsIGl0IGRlcGVuZHMgb24g
YHZtYXBgIHRvby4gV2Ugd2lsbCBzaW1wbHkNCj4gZGlzYWJsZQ0KPiA+ICAgICAgICAgaXQgb24g
QXJtdjgtUjY0IGluIGN1cnJlbnQgc3RhZ2UuIEhvdyB0byBpbXBsZW1lbnQgYGFsdGVybmF0aXZl
YA0KPiA+ICAgICAgICAgb24gQXJtdjgtUjY0IGlzIGJldHRlciB0byBiZSBkaXNjdXNzZWQgYWZ0
ZXIgYmFzaWMgZnVuY3Rpb25zIG9mDQo+IFhlbg0KPiA+ICAgICAgICAgb24gQXJtdjgtUjY0IHdv
cmsgd2VsbC4NCj4gPiAgICAgICAgIEJ1dCBzaW1wbHkgZGlzYWJsZSBgYWx0ZXJuYXRpdmVgIHdp
bGwgbWFrZSBgY3B1c19oYXZlX2NvbnN0X2NhcGANCj4gYWx3YXlzDQo+ID4gICAgICAgICByZXR1
cm4gZmFsc2UuDQo+ID4gICAgICAgICAgYGBgDQo+ID4gICAgICAgICAgKiBTeXN0ZW0gY2FwYWJp
bGl0eSBjaGVjayBmb3IgY29uc3RhbnQgY2FwICovDQo+ID4gICAgICAgICAgI2RlZmluZSBjcHVz
X2hhdmVfY29uc3RfY2FwKG51bSkgKHsgICAgICAgICAgICAgICAgXA0KPiA+ICAgICAgICAgICAg
ICAgICByZWdpc3Rlcl90IF9fcmV0OyAgICAgICAgICAgICAgICAgICAgICAgICAgIFwNCj4gPiAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICBcDQo+ID4gICAgICAgICAgICAgICAgIGFzbSB2b2xhdGlsZSAoQUxURVJOQVRJVkUoIm1vdiAl
MCwgIzAiLCAgICAgXA0KPiA+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICJtb3YgJTAsICMxIiwgICAgIFwNCj4gPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICBudW0pICAgICAgICAgICAgICBcDQo+ID4gICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgOiAiPXIiIChfX3JldCkpOyAgICAgICAgICAgICAgXA0KPiA+ICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFwNCj4g
PiAgICAgICAgICAgICAgICAgIHVubGlrZWx5KF9fcmV0KTsgICAgICAgICAgICAgICAgICAgICAg
ICAgICBcDQo+ID4gICAgICAgICAgICAgICAgICB9KQ0KPiA+ICAgICAgICAgIGBgYA0KPiA+ICAg
ICAgICAgIFNvLCBiZWZvcmUgd2UgaGF2ZSBhbiBQTVNBIGBhbHRlcm5hdGl2ZWAgaW1wbGVtZW50
YXRpb24sIHdlDQo+IGhhdmUgdG8NCj4gPiAgICAgICAgICBpbXBsZW1lbnQgYSBzZXBhcmF0ZSBg
Y3B1c19oYXZlX2NvbnN0X2NhcGAgZm9yIEFybXY4LVI2NDoNCj4gPiAgICAgICAgICBgYGANCj4g
PiAgICAgICAgICAjZGVmaW5lIGNwdXNfaGF2ZV9jb25zdF9jYXAobnVtKSBjcHVzX2hhdmVfY2Fw
KG51bSkNCj4gPiAgICAgICAgICBgYGANCj4gPg0KPiA+ICMjIyAqKjIuNS4gQ2hhbmdlcyBvZiBn
dWVzdCBtYW5hZ2VtZW50KioNCj4gPiBBcm12OC1SNjQgb25seSBzdXBwb3J0cyBQTVNBIGluIEVM
MiwgYnV0IGl0IHN1cHBvcnRzIGNvbmZpZ3VyYWJsZQ0KPiA+IFZNU0Egb3IgUE1TQSBpbiBFTDEu
IFRoaXMgbWVhbnMgWGVuIHdpbGwgaGF2ZSBhIG5ldyB0eXBlIGd1ZXN0IG9uDQo+ID4gQXJtdjgt
UjY0IC0gTVBVIGJhc2VkIGd1ZXN0Lg0KPiA+DQo+ID4gMS4gKipBZGQgYSBuZXcgZG9tYWluIHR5
cGUgLSBNUFVfRE9NQUlOKioNCj4gPiAgICAgV2hlbiB1c2VyIHdhbnQgdG8gY3JlYXRlIGEgZ3Vl
c3QgdGhhdCB3aWxsIGJlIHVzaW5nIE1QVSBpbiBFTDEsIHVzZXINCj4gPiAgICAgc2hvdWxkIGFk
ZCBhIGBtcHVgIHByb3BlcnR5IGluIGRldmljZSB0cmVlIGBkb21VYCBub2RlLCBsaWtlDQo+IGZv
bGxvd2luZw0KPiA+ICAgICBleGFtcGxlOg0KPiA+ICAgICAgYGBgDQo+ID4gICAgICBkb21VMiB7
DQo+ID4gICAgICAgICAgY29tcGF0aWJsZSA9ICJ4ZW4sZG9tYWluIjsNCj4gPiAgICAgICAgICBk
aXJlY3QtbWFwOw0KPiA+ICAgICAgICAgIG1wdTsgLS0+IEluZGljYXRlcyB0aGlzIGRvbWFpbiB3
aWxsIHVzZSBQTVNBIGluIEVMMS4NCj4gPiAgICAgICAgICAuLi4NCj4gPiAgICAgIH07DQo+ID4g
ICAgICBgYGANCj4gPiAgICAgIENvcnJlc3BvbmRpbmcgdG8gYG1wdWAgcHJvcGVydHkgaW4gZGV2
aWNlIHRyZWUsIHdlIGFsc28gbmVlZCB0bw0KPiBpbnRyb2R1Y2UNCj4gPiAgICAgIGEgbmV3IGZs
YWcgYFhFTl9ET01DVExfQ0RGX0lOVEVSTkFMX21wdWAgZm9yIGRvbWFpbiB0byBtYXJrIGl0c2Vs
Zg0KPiBhcyBhbg0KPiA+ICAgICAgTVBVIGRvbWFpbi4gVGhpcyBmbGFnIHdpbGwgYmUgdXNlZCBp
biBkb21haW4gY3JlYXRpb24gYW5kIGRvbWFpbg0KPiBkb2luZw0KPiA+ICAgICAgdkNQVSBjb250
ZXh0IHN3aXRjaC4NCj4gPiAgICAgIDEuIERvbWFpbiBjcmVhdGlvbiBuZWVkIHRoaXMgZmxhZyB0
byBkZWNpZGUgZW5hYmxlIFBNU0Egb3IgVk1TQSBpbg0KPiBFTDEuDQo+ID4gICAgICAyLiB2Q1BV
IGNvbnRleHQgc3dpdGNoIG5lZWQgdGhpcyBmbGFnIHRvIGRlY2lkZSBzYXZlL3Jlc3RvcmUgTU1V
IG9yDQo+IE1QVQ0KPiA+ICAgICAgICAgcmVsYXRlZCByZWdpc3RlcnMuDQo+ID4NCj4gPiAyLiAq
KkFkZCBNUFUgcmVnaXN0ZXJzIHRvIHZDUFUgc2F2ZSBFTDEgTVBVIGNvbnRleHQqKg0KPiA+ICAg
ICBDdXJyZW50IFhlbiBvbmx5IHN1cHBvcnQgTU1VIGJhc2VkIGd1ZXN0LCBzbyBpdCBoYXNuJ3Qg
Y29uc2lkZXJlZCB0bw0KPiA+ICAgICBzYXZlL3Jlc3RvcmUgTVBVIGNvbnRleHQuIEluIHRoaXMg
Y2FzZSwgd2UgbmVlZCB0byBhZGQgTVBVIHJlZ2lzdGVycw0KPiA+ICAgICB0byBgYXJjaF92Y3B1
YDoNCj4gPiAgICAgIGBgYA0KPiA+ICAgICAgc3RydWN0IGFyY2hfdmNwdQ0KPiA+ICAgICAgew0K
PiA+ICAgICAgI2lmZGVmIENPTkZJR19BUk1fTVBVDQo+ID4gICAgICAgICAgLyogVmlydHVhbGl6
YXRpb24gVHJhbnNsYXRpb24gQ29udHJvbCBSZWdpc3RlciAqLw0KPiA+ICAgICAgICAgIHJlZ2lz
dGVyX3QgdnRjcl9lbDI7DQo+ID4NCj4gPiAgICAgICAgICAvKiBFTDEgTVBVIHJlZ2lvbnMnIHJl
Z2lzdGVycyAqLw0KPiA+ICAgICAgICAgIHByX3QgbXB1X3JlZ2lvbnNbQ09ORklHX0FSTV9NUFVf
RUwxX1BST1RFQ1RJT05fUkVHSU9OU107DQo+ID4gICAgICAjZW5kaWYNCj4gPiAgICAgIH0NCj4g
PiAgICAgIGBgYA0KPiA+ICAgICAgQXJtdjgtUjY0IGNhbiBzdXBwb3J0IG1heCB0byAyNTYgTVBV
IHJlZ2lvbnMuIEJ1dCB0aGF0J3MganVzdA0KPiB0aGVvcmV0aWNhbC4NCj4gPiAgICAgIFNvIHdl
IGRvbid0IHdhbnQgdG8gZGVmaW5lIGBwcl90IG1wdV9yZWdpb25zWzI1Nl1gLCB0aGlzIGlzIGEN
Cj4gbWVtb3J5IHdhc3RlDQo+ID4gICAgICBpbiBtb3N0IG9mIHRpbWUuIFNvIHdlIGRlY2lkZWQg
dG8gbGV0IHRoZSB1c2VyIHNwZWNpZnkgdGhyb3VnaCBhDQo+IEtjb25maWcNCj4gPiAgICAgIG9w
dGlvbi4gYENPTkZJR19BUk1fTVBVX0VMMV9QUk9URUNUSU9OX1JFR0lPTlNgIGRlZmF1bHQgdmFs
dWUgY2FuDQo+IGJlIGAzMmAsDQo+ID4gICAgICBpdCdzIGEgdHlwaWNhbCBpbXBsZW1lbnRhdGlv
biBvbiBBcm12OC1SNjQuIFVzZXJzIHdpbGwgcmVjb21waWxlDQo+IFhlbiB3aGVuDQo+ID4gICAg
ICB0aGVpciBwbGF0Zm9ybSBjaGFuZ2VzLiBTbyB3aGVuIHRoZSBNUFUgY2hhbmdlcywgcmVzcGVj
aWZ5aW5nIHRoZQ0KPiBNUFUNCj4gPiAgICAgIHByb3RlY3Rpb24gcmVnaW9ucyBudW1iZXIgd2ls
bCBub3QgY2F1c2UgYWRkaXRpb25hbCBwcm9ibGVtcy4NCj4gPg0KPiA+IDMuICoqTVBVIGJhc2Vk
IFAyTSB0YWJsZSBtYW5hZ2VtZW50KioNCj4gPiAgICAgQXJtdjgtUjY0IEVMMiBkb2Vzbid0IGhh
dmUgRUwxIHN0YWdlIDIgYWRkcmVzcyB0cmFuc2xhdGlvbi4gQnV0DQo+IHRocm91Z2gNCj4gPiAg
ICAgUE1TQSwgaXQgc3RpbGwgaGFzIHRoZSBhYmlsaXR5IHRvIGNvbnRyb2wgdGhlIHBlcm1pc3Np
b25zIGFuZA0KPiBhdHRyaWJ1dGVzDQo+ID4gICAgIG9mIEVMMSBzdGFnZSAyLiBJbiB0aGlzIGNh
c2UsIHdlIHN0aWxsIGhvcGUgdG8ga2VlcCB0aGUgaW50ZXJmYWNlDQo+ID4gICAgIGNvbnNpc3Rl
bnQgd2l0aCBNTVUgYmFzZWQgUDJNIGFzIGZhciBhcyBwb3NzaWJsZS4NCj4gPg0KPiA+ICAgICBw
Mm0tPnJvb3Qgd2lsbCBwb2ludCB0byBhbiBhbGxvY2F0ZWQgbWVtb3J5LiBJbiBBcm12OC1BNjQs
IHRoaXMNCj4gbWVtb3J5DQo+ID4gICAgIGlzIHVzZWQgdG8gc2F2ZSB0aGUgRUwxIHN0YWdlIDIg
dHJhbnNsYXRpb24gdGFibGUuIEJ1dCBpbiBBcm12OC1SNjQsDQo+ID4gICAgIHRoaXMgbWVtb3J5
IHdpbGwgYmUgdXNlZCB0byBzdG9yZSBFTDIgTVBVIHByb3RlY3Rpb24gcmVnaW9ucyB0aGF0DQo+
IGFyZQ0KPiA+ICAgICB1c2VkIGJ5IGd1ZXN0LiBEdXJpbmcgZG9tYWluIGNyZWF0aW9uLCBYZW4g
d2lsbCBwcmVwYXJlIHRoZSBkYXRhIGluDQo+ID4gICAgIHRoaXMgbWVtb3J5IHRvIG1ha2UgZ3Vl
c3QgY2FuIGFjY2VzcyBwcm9wZXIgUkFNIGFuZCBkZXZpY2VzLiBXaGVuDQo+IHRoZQ0KPiA+ICAg
ICBndWVzdCdzIHZDUFUgd2lsbCBiZSBzY2hlZHVsZWQgaW4sIHRoaXMgZGF0YSB3aWxsIGJlIHdy
aXR0ZW4gdG8gTVBVDQo+ID4gICAgIHByb3RlY3Rpb24gcmVnaW9uIHJlZ2lzdGVycy4NCj4gPg0K
PiA+ICMjIyAqKjIuNi4gQ2hhbmdlcyBvZiBleGNlcHRpb24gdHJhcCoqDQo+ID4gQXMgQXJtdjgt
UjY0IGhhcyBjb21wYXRpYmxlIGV4Y2VwdGlvbiBtb2RlIHdpdGggQXJtdjgtQTY0LCBzbyB3ZSBj
YW4NCj4gcmV1c2UgbW9zdA0KPiA+IG9mIEFybXY4LUE2NCdzIGV4Y2VwdGlvbiB0cmFwICYgaGFu
ZGxlciBjb2RlLiBCdXQgZXhjZXB0IHRoZSB0cmFwIGJhc2VkDQo+IG9uIEVMMQ0KPiA+IHN0YWdl
IDIgdHJhbnNsYXRpb24gYWJvcnQuDQo+ID4NCj4gPiBJbiBBcm12OC1BNjQsIHdlIHVzZSBgRlND
X0ZMVF9UUkFOU2ANCj4gPiBgYGANCj4gPiAgICAgIGNhc2UgRlNDX0ZMVF9UUkFOUzoNCj4gPiAg
ICAgICAgICAuLi4NCj4gPiAgICAgICAgICBpZiAoIGlzX2RhdGEgKQ0KPiA+ICAgICAgICAgIHsN
Cj4gPiAgICAgICAgICAgICAgZW51bSBpb19zdGF0ZSBzdGF0ZSA9IHRyeV9oYW5kbGVfbW1pbyhy
ZWdzLCBoc3IsIGdwYSk7DQo+ID4gICAgICAgICAgICAgIC4uLg0KPiA+ICAgICAgICAgIH0NCj4g
PiBgYGANCj4gPiBCdXQgZm9yIEFybXY4LVI2NCwgd2UgaGF2ZSB0byB1c2UgYEZTQ19GTFRfUEVS
TWANCj4gPiBgYGANCj4gPiAgICAgIGNhc2UgRlNDX0ZMVF9QRVJNOg0KPiA+ICAgICAgICAgIC4u
Lg0KPiA+ICAgICAgICAgIGlmICggaXNfZGF0YSApDQo+ID4gICAgICAgICAgew0KPiA+ICAgICAg
ICAgICAgICBlbnVtIGlvX3N0YXRlIHN0YXRlID0gdHJ5X2hhbmRsZV9tbWlvKHJlZ3MsIGhzciwg
Z3BhKTsNCj4gPiAgICAgICAgICAgICAgLi4uDQo+ID4gICAgICAgICAgfQ0KPiA+IGBgYA0KPiA+
DQo+ID4gIyMjICoqMi41LiBDaGFuZ2VzIG9mIGRldmljZSBkcml2ZXIqKg0KPiA+IDEuIEJlY2F1
c2UgQXJtdjgtUjY0IG9ubHkgaGFzIHNpbmdsZSBzZWN1cmUgc3RhdGUsIHRoaXMgd2lsbCBhZmZl
Y3Qgc29tZQ0KPiA+IGRldmljZXMgdGhhdCBoYXZlIHR3byBzZWN1cmUgc3RhdGUsIGxpa2UgR0lD
LiBCdXQgZm9ydHVuYXRlbHksIG1vc3QNCj4gPiB2ZW5kb3JzIHdpbGwgbm90IGxpbmsgYSB0d28g
c2VjdXJlIHN0YXRlIEdJQyB0byBBcm12OC1SNjQgcHJvY2Vzc29ycy4NCj4gPiBDdXJyZW50IEdJ
QyBkcml2ZXIgY2FuIHdvcmsgd2VsbCB3aXRoIHNpbmdsZSBzZWN1cmUgc3RhdGUgR0lDIGZvciBB
cm12OC0NCj4gUjY0Lg0KPiA+IDIuIFhlbiBzaG91bGQgdXNlIHNlY3VyZSBoeXBlcnZpc29yIHRp
bWVyIGluIFNlY3VyZSBFTDIuIFdlIHdpbGwNCj4gaW50cm9kdWNlDQo+ID4gYSBDT05GSUdfQVJN
X1NFQ1VSRV9TVEFURSB0byBtYWtlIFhlbiB0byB1c2Ugc2VjdXJlIHJlZ2lzdGVycyBmb3IgdGlt
ZXIuDQo+ID4NCj4gPiAjIyMgKioyLjcuIENoYW5nZXMgb2YgdmlydHVhbCBkZXZpY2UqKg0KPiA+
IEN1cnJlbnRseSwgd2Ugb25seSBzdXBwb3J0IHBhc3MtdGhyb3VnaCBkZXZpY2VzIGluIGd1ZXN0
LiBCZWNhdXNlIGV2ZW50DQo+ID4gY2hhbm5lbCwgeGVuLWJ1cywgeGVuLXN0b3JhZ2UgYW5kIG90
aGVyIGFkdmFuY2VkIFhlbiBmZWF0dXJlcyBoYXZlbid0DQo+IGJlZW4NCj4gPiBlbmFibGVkIGlu
IEFybXY4LVI2NC4NCj4gPg0KPiA+IC0tDQo+ID4gQ2hlZXJzLA0KPiA+IFdlaSBDaGVuDQo+ID4N
Cj4gPg0K


From xen-devel-bounces@lists.xenproject.org Fri Feb 25 07:16:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 07:16:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278755.476126 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNUpo-0007yD-9N; Fri, 25 Feb 2022 07:16:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278755.476126; Fri, 25 Feb 2022 07:16:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNUpo-0007y6-66; Fri, 25 Feb 2022 07:16:12 +0000
Received: by outflank-mailman (input) for mailman id 278755;
 Fri, 25 Feb 2022 07:16:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=RDkG=TI=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nNUpm-0007xz-HC
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 07:16:10 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c982be19-960a-11ec-8539-5f4723681683;
 Fri, 25 Feb 2022 08:16:02 +0100 (CET)
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2057.outbound.protection.outlook.com [104.47.2.57]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-34-UGmoo5HzPbizNbkA-Hhh3A-1; Fri, 25 Feb 2022 08:16:00 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DU2PR04MB8646.eurprd04.prod.outlook.com (2603:10a6:10:2dd::6) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.25; Fri, 25 Feb
 2022 07:15:57 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.025; Fri, 25 Feb 2022
 07:15:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c982be19-960a-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645773361;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=6psnJpzd9Jc7hs0y3CIABWWV9FExx0g5VblraM77pcE=;
	b=AHCVGh88XpfLZCKO7wJrCMeKx7IlSSKZDuGh8LxsNnS+4iLtRbN7s2Cl820vYPrRFuZfNl
	qtwhqlS7B26t2z5clP4p5C5ab4Wk/AIx+9x0VNWEOa97oJHNpJ5dtbjWds1cja3o+qSvHl
	r2N7DcEcHlfxKivEGsrqNA0Hnmgtcs0=
X-MC-Unique: UGmoo5HzPbizNbkA-Hhh3A-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=AyOa4jennSvY6JH7GL9DMFYCMUPYylXOAHiXQPxK+EdzFTdQNjKmPkYduGr3+JC9l82lxu2T/vExBeZnVndoPcd5xCIZfJNBPaZWOyk5jN8QAakgBCrE3kQ2K1uJn1N0nUcScS/dPvqk5zYV10mXMm3PcEO3//rWKVBTMbcD6McHPfVzlyUp0caXDVLuP2omre97v88LoMLdF26my5PY3G4pNkHdjg4o+72XHl4/rB/DxlcvoNIPn8NVabevVGn45MS+nGF7GNeZLsbeCsAZsrs84LYXVTVhD0Zvn392uhsP9SkVKoDj6sKM4uQTHy/nKAR/9RSpTJF34vj/l4Ujzg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=6psnJpzd9Jc7hs0y3CIABWWV9FExx0g5VblraM77pcE=;
 b=h3xdHdx7L0uc5Vn7SAWrGBafPIW7DAQuVY6isFzPzGLc4koh1ITbcOcCgx12c/RKG3l97ezWJQF1S9JeZejd03wpa7diAKD3ScptdbmL9Qwz8jj9+Js0OLjdvJha14OOsmkEvevI7LnkTf51J1Tv7u2t4QbRVK1pnzJhWkiNYfbSb1gyjvh8DKXQfp/fGdsYIdemLIJrSyny1S/c289rOu8XsTP3VuQKt3FYdtZqa6EwBRwrJdZyIWy7FcEzgy15gylT8lQ+2DnnMkVMDA6lxXGHuMhi36Zg267+8joxPuz94xhUK+44d0L0rj73gWwdXypM3WZYfi7HoSToM7S1Nw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <d3814109-f4ba-9edb-1575-ab94faaeba08@suse.com>
Date: Fri, 25 Feb 2022 08:15:55 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [BUG REPORT] soft_reset (kexec/kdump) does not work with mainline
 xen
Content-Language: en-US
To: Dongli Zhang <dongli.zhang@oracle.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Anthony Perard <anthony.perard@citrix.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>
References: <BYAPR10MB2663BBE2CEECCC4C6504B190F03D9@BYAPR10MB2663.namprd10.prod.outlook.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <BYAPR10MB2663BBE2CEECCC4C6504B190F03D9@BYAPR10MB2663.namprd10.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0415.eurprd06.prod.outlook.com
 (2603:10a6:20b:461::19) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ca35854e-4d2f-41e4-79bf-08d9f82eab41
X-MS-TrafficTypeDiagnostic: DU2PR04MB8646:EE_
X-Microsoft-Antispam-PRVS:
	<DU2PR04MB8646D77D332203B482C73CC2B33E9@DU2PR04MB8646.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	IEsDlJ+YIvAxlEnEPhrWQQ0iM1rxVCVB3CnDyHfRDcfuwvQoETzeB0LOsyqXTK+Io8c4LANl3QPe+ecqW73hFvqc8KSUUUkhm3YXTV/J+AfbC9yTQqXfW9RZPjahKzAv7mL9aj1RUBDCsFh7PbLF4YxOE6v+8eNvGsivF6Z9DHox40Prcq0a9BzYVHaUYBAc9lH8ZY9mOl958uORAPbOcr/41NrIXOTrolYsteagmMs2pmTGjtUZm2aZaKRbKaFjl5ebBgCsY765p/0Lxedv54MjNOYSVmr9ENxsgVKgzrQuP8KXd+VjXkcY/LPC7/2g84TE4ldQpuHe/d2MrYmCNmsXP/WyG/+v3hoQm9jqnV/2vjYtlk1xin1yt9jETddF2FctrDvPAJxsH0JmB6h1GkoWF9NFQH7DWv5hltrwPU8o/DdPIAeM0I/rdB80KIvN/p+D+DnwfpnMu1mtJOXidKfhmc25c07v6tXeAM9TdcotFUk+bZRqc8qFjiniIjYP69xP9isieA5EYdYOyfMjxP2JQ3slU9zdgo8TQojIHlPS7tEo1Tdyb5WH0tpK5joBHreUS5YhbVjNulfiL4zSJkdAlxS/RJhpP+/eXTVaMpGbTNU0Z9ImZaKuO6r2fyoXUYKC9Cb+ykEzwNpiEofCZXvv5BFwi4K9o9kLz9NZpHzC+PpAzEvf+XoPrFtA9SOFYyTM8mhQ3c6bpliHe2jGUs8O0RlENpZ9/4SAnO01Mo8=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(31696002)(38100700002)(31686004)(66476007)(66946007)(86362001)(508600001)(54906003)(186003)(26005)(36756003)(53546011)(66556008)(8936002)(6916009)(5660300002)(8676002)(6506007)(6512007)(2906002)(6486002)(4326008)(316002)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?eEtQVXBBUzZLT3RFM3VpYnR3MGhsTVBZR1hLeWtIZHcvQklYeFF6U2VEcWdh?=
 =?utf-8?B?MGRBTFdra3hGM2FpM3BQeVpzOTdDUE4rU1NrWUlMT0UvKzBJUjU0NFZtZDdy?=
 =?utf-8?B?Ly92S1lHdERrNzRDdWJXUjhsMkl1MHd3c0NKMkVlOEVoM1hVR1MvM2I0WlBj?=
 =?utf-8?B?cytSaXJQN3NLZTBPZjVhZ0l5ZDZZSUFrR1NSaUtDaGVzL2FPRXVhU09CSVFE?=
 =?utf-8?B?bEcrWDE0ZEkxaXE4dHdoeE9PVUQ3K3NVckRNSDV2Sm5wQ2IrbjRobU9CMnN4?=
 =?utf-8?B?TmZpMTNKemVvU0IrVVM0WExlVSt3LzRxYXU4UFU2RFdzNncxakUrRXlaTVEz?=
 =?utf-8?B?Sms4YytWMjg1eVdzK1B3d3ZjZDhzT05TSm1zZlFLTHFPU2ZGRnFQTjJZT0dm?=
 =?utf-8?B?RlloaU9tcit3TlNYT2JmVURRWnRudXF6NVFmNzhYb0Q2cHpSRmFXOW5BVTlB?=
 =?utf-8?B?VzVHRmFUMGlqbEhQbHluOGRjU09KSXV0ZjRuaEtkZ0JsWDBSSlRGQzdaeWNt?=
 =?utf-8?B?NjBUeWZYOTlaOHIyODhXUHJSRzF5bkF6NE9TbmhnMGxrYzFyUUdTSjNlTDJE?=
 =?utf-8?B?dExUY25RVXROU2FqTEVNdThhSTJIZW05SWtEdW9NSFFXSGd3SzZGVHFtQUdu?=
 =?utf-8?B?STBVa21JUXlxUUtxRTNBbWZKSzFiV0hDaDFtMHFjTHVaMWd3V1ZQSGp5K29t?=
 =?utf-8?B?WDdyQ2RGb3kvVWRIbk5aV3AyTUNhQjlUL2FmcEhFUFRiT2hQNXFrcUwrMkxR?=
 =?utf-8?B?UGJTYnNEQ3BHeEZQazRIWStVWXNFZHlnZHBOYktGNlhHVU82VWVUYTI3ZytD?=
 =?utf-8?B?RGhEb0htUHBUZ3QrQ3V1QThBOWxDdkdsZUZkK2RMeG9NMGZnMVFpUlY3Y3ph?=
 =?utf-8?B?Q1djaWQ5UzRxTWp6d1k4OGdzZUpCc0VFRDk5b3FYR2VVM3lPMmpPRkVRZ1lz?=
 =?utf-8?B?KzNzenRudkFKQVRRVTBncmt4RXl3cEt5RTJLUFJNaU0wN2ZLUDBYNFBKRmpZ?=
 =?utf-8?B?Qlg3aVZzTzlJV1JoYkRqSWdhdHprQXVidEcwckpXQzFNdXhNd3dtdE5YaEdH?=
 =?utf-8?B?QVh5eCs2cXA1QjZIQVhyTC8yVDNGMG0ycFFJaXl5cWsxNUNSK0grNWY5dmdo?=
 =?utf-8?B?MFAzNnVTYmtVdk90bWdKU0ppRVRTTkxhZFRDREJKM0tRRTBldkZoMUtZbStK?=
 =?utf-8?B?NmxRalVsVDJUM0FDMVluRzNCM2lhZUlyVHlvRE5ENjdWK1B0Q0QxaGl5dHpm?=
 =?utf-8?B?alFQT3pvdi9QdjFobmxBNzB6di9DTHJaSGJpNlpVTVNKWFY2MDlYajNxeXhv?=
 =?utf-8?B?Z3cvQmpoM2ZrTVdOSTEyWTBuY1dBclJHaHVRTlFvUUNwVW5ZaEpKRno2amlq?=
 =?utf-8?B?ZzNoZDZObVo0Z2pNUGhmM0ZYNnVxWEhVS1B2ZmJ2R1Y4STZxK0ZNZG5GUi9I?=
 =?utf-8?B?TWhJL3N5dDEwVDUySENjT011Mnp3RnJrL2xiUVR0TzYwRVJ0eW85K3h5STJs?=
 =?utf-8?B?YU5YbllUWC9WS01PQTgrQ2l0Y2FOb05mbHh2YlJISEVmaXZEdWdOUnpLR3JI?=
 =?utf-8?B?R3ZsNEZhMDkzNjc3cmMwOC9SZm03dmJDbU5jUDkvVXRoWlZtNkhFUGptano5?=
 =?utf-8?B?MHUxZVNEa0I5N2QyM2p2N3lzMlBlb3pHNVNXZG8xTFVQa3pNbE45RGdMZzhh?=
 =?utf-8?B?bW9GVUZGc0JpUTN4ZlBBVUJJajZZUmxhdnFsQlBkTEFqWU9kT0NaL2NJdndC?=
 =?utf-8?B?T1J1QWs1d1JtNEltclRZUWFoL1pvNnh2aDA3US8wdkVZY2FvODNZdllmVW1n?=
 =?utf-8?B?L2RpemorbVRCRGRubTlMVlBWQlB2Q00xOWE5Y09tWElNOWNVVXkwUkowSHNG?=
 =?utf-8?B?MCtndys2REFSYS9vUEF6dksrNXVEVjJhRXJaS09GYkh6UjN5VmRKbGdjWGZk?=
 =?utf-8?B?dnUycEI4MW55cU5aNVdBREVTazI1SCtTL3Vsekh5bTJpUzdaME5NNnIvbkds?=
 =?utf-8?B?c1RYRzlOdVNwQ25icEpINWRZY0pQQ0xPQStTZGM0ZFV5VUc1dHhQQTFJekdD?=
 =?utf-8?B?Zy9DTEsrVyttWnYzazM3QWRtUjhsOEwxQjFORFY5aDhPeC9ZbWRJU3JxK0xN?=
 =?utf-8?B?ZW8vZVlmRkdEMkYyUVBhVW95OEFjVUxDZDNKT3pRek1jd2xzVkRlUXlIVGhD?=
 =?utf-8?Q?zrFINNflLaxmziyjDfL8yxc=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ca35854e-4d2f-41e4-79bf-08d9f82eab41
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2022 07:15:57.8139
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rrsuk+B8EKLmuA1MYRHo7yBq0EthvC538dgv7IWVWHtdvC+nNAYFc3GFWHoem8LbPFx2/SeXjcPPDiwyngisqA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8646

On 24.02.2022 23:27, Dongli Zhang wrote:
> Hello,
> 
> This is to report that the soft_reset (kexec/kdump) has not been working for me
> since long time ago.
> 
> I have tested again with the most recent mainline xen and the most recent
> mainline kernel.
> 
> While it works with my old xen version, it does not work with mainline xen.
> 
> 
> This is the log of my HVM guest.
> 
> Waiting for domain test-vm (domid 1) to die [pid 1265]
> Domain 1 has shut down, reason code 5 0x5
> Action for shutdown reason code 5 is soft-reset
> Done. Rebooting now
> xc: error: Failed to set d1's policy (err leaf 0xffffffff, subleaf 0xffffffff, msr 0xffffffff) (17 = File exists): Internal error

I don't suppose you tried you track down the origin of this EEXIST? I think
it's pretty obvious, as in the handling of XEN_DOMCTL_set_cpu_policy we have

        if ( d->creation_finished )
            ret = -EEXIST; /* No changing once the domain is running. */

Question is how to address it: One approach could be to clear
d->creation_finished in domain_soft_reset(). But I think it would be more
clean if the tool stack avoided trying to set the CPUID policy (again) on
the guest when it soft-resets, as it's still the same guest after all.
Cc-ing Andrew and Anthony for possible thoughts.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Feb 25 08:08:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 08:08:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278771.476136 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNVeA-0005Jb-Ac; Fri, 25 Feb 2022 08:08:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278771.476136; Fri, 25 Feb 2022 08:08:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNVeA-0005JU-7e; Fri, 25 Feb 2022 08:08:14 +0000
Received: by outflank-mailman (input) for mailman id 278771;
 Fri, 25 Feb 2022 08:08:13 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=RDkG=TI=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nNVe8-0005JO-Us
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 08:08:13 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 128d5a32-9612-11ec-8eb8-a37418f5ba1a;
 Fri, 25 Feb 2022 09:08:11 +0100 (CET)
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2054.outbound.protection.outlook.com [104.47.1.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-10-BxiCtfTXOlupAQFzqxlAtQ-1; Fri, 25 Feb 2022 09:08:09 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM0PR04MB4769.eurprd04.prod.outlook.com (2603:10a6:208:ce::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.25; Fri, 25 Feb
 2022 08:08:08 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.025; Fri, 25 Feb 2022
 08:08:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 128d5a32-9612-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645776490;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=RiAbcjw3IJnH6SQpm1Ncps3d2ZlSMnMmS/DnNHXZ46A=;
	b=VyG1pIiX1Lk7HTdoY+9Ur/6+6Qwqnjp6Behagdql1r5AHUrqHxonir0ToqIwVBiVt/pCS2
	Cq2KIXJT0XgVyVrAImgnXOgZyD5G8zZqknxYpSWv/XQhgbLwDYnQC1NF5BphjWm9v6zims
	rnEl1J9AXrJbAWGXWf2xrwd0OTAnlLg=
X-MC-Unique: BxiCtfTXOlupAQFzqxlAtQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=mUV3dZsLouEl2eQk3d+7FEtWkf7IR/psdyXS5TMPDIFOjRulMoLjvKyHWQG0Gj5rr1m08aeHATDAXASVzqOAA2oxCNpCA7JYfYQtSLm8Hw4mpELIbzD0gNOUVEYemHHYyNk2ROXd5cfhvndGtob6rNWx7mlakibWnroT2VIJLHmERnIJ5Qe/wVgPFax/eEudTssyeH3d/WwRcPTkHBhZ8uZlpgKyw7kJ5AYI5QxWWgJc2PTZJ0Gk+k11WflkPgDu7RwhtOYx/t4UkYqqMbRpBijHFF9ycnbFu4tt1Ys4A6RO02lE5LeLlaJVeb2DloDQrK8i1mSduTravY8RdOgoWA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=s8j6NO4oah08wH/fsHgkYTWGSVNd52XmtLPxm300hho=;
 b=APnOu7MtsQ+ySyGWKObSx3nx8x+XLaHXawXvv8Y+suqDvKFPrvH0gVaes8duuYGQS/hgNkTQuqb8aKCMSaPD5z1995RPfljMUIFNelAI156QSDjfEUBGcec23ctSxK2MWy0d4uh0GodKgGtHuBHgjNiAdi21T6hEFNtqvzipEiEMYdTV+BVl4biRD3MSEpJ5jMqA4Uw3DEseXtHJFCkZhonZJeBE+dUQ3sRrJZ5gTsWrX9r1QjecW8nY0PnITlRBKpWCn2FSGSNLT895EDZqhbZUZMTBOlZ4JBzAbXv8Cqp0u2PKdw2g/qIEeeRSk5/JXdTQQxsFk6IWCnRacJqvPg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <da4f6447-03ce-2c31-3243-909d879745c9@suse.com>
Date: Fri, 25 Feb 2022 09:08:05 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: Ping: [PATCH v2] x86/time: switch platform timer hooks to altcall
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
CC: Wei Liu <wl@xen.org>, Roger Pau Monne <roger.pau@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <5f1f49e6-1380-73bf-d68f-6eb9dd05cad6@suse.com>
 <68d40be4-9ced-01bf-8bc3-585f11827504@suse.com>
 <822a757b-a9a3-e677-4cc4-3879125f9f24@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <822a757b-a9a3-e677-4cc4-3879125f9f24@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6P194CA0086.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:209:8f::27) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 0b5fad0a-d567-4cb9-403f-08d9f835f542
X-MS-TrafficTypeDiagnostic: AM0PR04MB4769:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB4769430B4A7E4318E264B401B33E9@AM0PR04MB4769.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	cAf1uobqDu+vQEpr5Y9BJZI4I3vUuX05cCgcwA0TvpaNf4GVYBpnquShRWpW1IfPMT7r1vfeBSZcPZae+TICK7ntmhRurx7RhC+s950ll6Kg+p2xMRrfbxrDvERn1/pBagNz/G43S6Nzfq0S6+NkMi1XkkpV8YfxStVfe51tzQ8N42QzgOo+Zz3jjuLja1Gzgo0lgp3k+3weboxkRW6rRwBTtWv3t9j0wbXarB/kLA92Qya3jLWgpxuU+PU2z/GawIs2+tVvxC1Hat+jLgCU0PhZL2UAotlw2/AreKbRC1tnUDmHsY3IRiWuARc4nU2YLsozcdy1kfCuTdI/LlyTGGvG/XXUUrFtMOKSpnN+0nq+I+fvQUvjf8O3ZG0fUpJ/wbEd/MsULdZw9613TkpY7PbIMQ4kKSZjWwTWZltHqg9Bmvg4nxpPNhiA1a+pOD6iHqvFDJIyykaX9GUN+xQM0oIN2uconBkEPVE3tNWIs0GX9pBMb+vT1wGP/aZUkPLih0RzeP1rCXBRYufg5mjUk5wnLM9xSxhFNTwUBZtvs1wL5iXqPgFJ5aSfF347Bggw3hM+gJhTJVnKSt8moSDRmJNMU6V4okg5k2miPsV36Y/JnXT+18FgtNUyBFCY3inMPZf7xooJ6Pbl0ZsXg05xbWNJFxBKLQ08QLfLAFHr5w13IzNDq1OxYodlnR+545odv54CCJQGvCOREFf/fZsGAuwGsuQp/nqCFfnyQA2dpEU=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(31686004)(8936002)(38100700002)(508600001)(83380400001)(54906003)(6486002)(316002)(6916009)(36756003)(4326008)(66946007)(6506007)(6512007)(6666004)(31696002)(86362001)(8676002)(66556008)(66476007)(53546011)(5660300002)(2616005)(2906002)(186003)(26005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?Vv1FQHTizhfosY++lS5ZiSVjIXgLt54cSIyJVqa7ANVBlm3vO+sdaxq7Pikp?=
 =?us-ascii?Q?GBLnWB9f0jbWq27C5m/v9nuGVP+t4yfCYnMF8TgrjumZyzfh8loPRG8Gxu4L?=
 =?us-ascii?Q?6d1g3cXrr939WqKH5031o4MXKsA5qTfTjJ91wts9SXsUqRy+yZeyr0omlHnh?=
 =?us-ascii?Q?EXiLwDLrmQn09CsaeqLTUaufKRxO2HmIJaphYkt5F9pcaOMz4QGVetFYR+MS?=
 =?us-ascii?Q?8dzs5z3IbN5oeXIAJ/Z5SWJlP3AyQzxzgwRNCvA2Ya03wqC0AAA8qvW6YRZQ?=
 =?us-ascii?Q?YMvSL1PzXGdZUM9LPexlO6jB1WOa0I6ji6pQYcBKm3alY21I1IIUWtVu9C+B?=
 =?us-ascii?Q?yrpeq+MMOPdU1ZBhlLQtXgFYIRzi8BVqgQEh7OycAEH71sUG0a//h1E+UyDH?=
 =?us-ascii?Q?dwA0GG16k9EpF2t+mF2wmmW2QRgArttV+0nbh9a1d+MQs/wpp7c+24ItaFnF?=
 =?us-ascii?Q?MWO0VwqX5Nex6iZK5BOneX2Po4R9gyk4rgpUWEQFkhviI88wddt6Ivg05oY9?=
 =?us-ascii?Q?UwVb+CTjMCXK3KNCCHyGiOxHKYtGHmLLOhAW11BC2KoU8HiBfs9wRYv4g/DT?=
 =?us-ascii?Q?gqTtoVIINz9e0X0exeuu7LCL/33z/K7np2IDyNRKoPsq2gGbsWsNDbHz0lB/?=
 =?us-ascii?Q?9S+l6ERoLfreEabKk78zCCDck41wUZuiReM1DiDOCN2FbIWD4joFgW9VSDhT?=
 =?us-ascii?Q?W1BkhHE83nM8jUlY1/XgY4ODo+0a1auTC51ENHmMgb8vW5g26iQ8cJvf+/qh?=
 =?us-ascii?Q?xjCDNX75ejiwb8NxxPk4jxHAslw97cq2XEKei1AdyXTzIIG/eHQWztGACYW2?=
 =?us-ascii?Q?D/vRL7recsapHuHSyYYfCABbMiQlzYJmWRo9P8DVhBVMPWlAIMn8UKcM0Tgb?=
 =?us-ascii?Q?4B0Nx3WXWiRTMoP0cijFRuYGXDqx5quQpOk+Gjlmv6wDMwzyMA/7dBjxNjXb?=
 =?us-ascii?Q?6u/GTw0dFQRYPyaQqSjhIGGH5JZ/O5cdb/qo3MyygruPdieIYUwebARGTMCS?=
 =?us-ascii?Q?DV4Ko6+xHRKNFU+vdllxZfLyVvZIhOdh4JBFJZ+nku3OtlE+y2vlH3F4+LF+?=
 =?us-ascii?Q?Y2HrqK617LMAczvimsCIVSnG/hXSOdZeF7W9abOVGN70BpvByJ+FIaNqiZTs?=
 =?us-ascii?Q?UCJ06laaf5S2/gsBroUJonJKFvCbRUtysfv7D9FNB3Gha/2OyirN8yRXPI6B?=
 =?us-ascii?Q?hAEY0bwyx/YJuqsb9MmW9qMwPl7VqHckrEFpcHfetTUK2F3JjvwmljYyq4sM?=
 =?us-ascii?Q?jbc8DbEuOtX2CU58qP9OssZGr72POjY1OEgl1p7skna3l/9x75AOFKqBHqxh?=
 =?us-ascii?Q?SqW/PI4XTXqcqOUMNopd7OPHi2SyELpZFRergz/kWR+4Uz1TW4u+1241/jYj?=
 =?us-ascii?Q?XRqTZdwurL+Rh7KppRRURmYw/xvB8YXtdvXdWpL6t/88NngqsXgIFp9tEByW?=
 =?us-ascii?Q?gkNV4NhNFNk9ukp0rSvXclw7j7n0Y1kfMcaH8o5e61h4hZJQv3lkddk3KjPs?=
 =?us-ascii?Q?9qrRE0Zr530ZUknkNs9MY1XZqkGYJStGaYRut84C2xysBhPTQxOhmWs1/UDq?=
 =?us-ascii?Q?2cRT02V8C1gHodoTqevf2g6WgxurafBeAVjSj9407OtEKq4d0zrflla5uE3t?=
 =?us-ascii?Q?2EW9Bs0i5YmTw9F8idq0qEQ=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0b5fad0a-d567-4cb9-403f-08d9f835f542
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2022 08:08:08.3225
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JSSRg8R14cpHcZuYaQZq/OztY/6L2MWT74+9xYDuy8duLaKWAFf2KRr22d35eB1/5XysrhBK6SWwu6YBqt60Eg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4769

On 24.02.2022 18:39, Andrew Cooper wrote:
> On 24/02/2022 11:25, Jan Beulich wrote:
>> On 13.01.2022 14:17, Jan Beulich wrote:
>>> Except in the "clocksource=3Dtsc" case we can replace the indirect call=
s
>>> involved in accessing the platform timers by direct ones, as they get
>>> established once and never changed. To also cover the "tsc" case, invok=
e
>>> what read_tsc() resolves to directly. In turn read_tsc() then becomes
>>> unreachable and hence can move to .init.*.
>>>
>>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> As this actually amends the IBT work, I would have hoped for it to be
>> viewed as useful.
>=20
> Sorry - it fell through the cracks.=C2=A0 Definitely useful.
>=20
>>  Of course if accepted in general, it would now want
>> to have __initconst_cf_clobber annotation addition included. Albeit
>> there's a slight complication: Some of the structures are written to,
>> so those couldn't really be "const".
>=20
> The .init.cf_clobber section needs to container a pointer to every
> target function.=C2=A0 For the current ops structures, we just put the wh=
ole
> ops structure in.
>=20
> For individual functions, the best plan I could come up with was a macro
> which emits:
>=20
> .pushsection .init.cf_clobber, a, @progbits
> .quad fn
> .popsection
>=20
> wrapped up in #define cf_clobber(fn), so the end code result ought to
> look like:
>=20
> static void foo(param *bar)
> {
> =C2=A0=C2=A0=C2=A0 ...
> }
> cf_clobber(foo);
>=20
> similar to command line parameters.
>=20
>=20
> That said, in this case, can't we cf_clobber each platform_timesource ?=
=C2=A0
> It would require altcall()ing the resume hook too.=C2=A0 (the init hook w=
on't
> matter either way.)

The resume hook is altcall()ed by the patch already. The problem isn't
that the annotation would be wrong when placed on all ops structs, but
that a mix of const and non-const isn't okay. Some of the structs can
be made const (plt_pit, plt_xen_timer, and plt_hyperv_timer),
but others cannot be (plt_hpet, plt_pmtimer, and plt_tsc). (There's
also going to be fallout from making some const, as then the .init
hook needs to change so its parameter is pointer to const, which in
turn requires updates to plt_hpet and plt_pmtimer to be no longer be
made through the function's parameter, but that's merely a cosmetic
and patch size aspect.)

As said in reply to Roger, I think I'd prefer to do this 2nd
transformation in a separate patch anyway, putting in the one here as
is (merely mechanically rebased over the cf_check additions). The two
steps are technically separable, and with the other adjustments needed
it seems better to keep them separate. (And really I'm about to put in
the patch here.)

As to the init hook not mattering: verify_tsc_reliability() is an
initcall, which happens after AP bringup and hence after the 2nd
alternatives patching pass. Therefore plt_tsc cannot be annotated. But
that's fine: It has no resume hook and the plan is to do away with
read_tsc() as a real function.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Feb 25 08:11:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 08:11:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278778.476148 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNVhT-0006gU-Q9; Fri, 25 Feb 2022 08:11:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278778.476148; Fri, 25 Feb 2022 08:11:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNVhT-0006gN-Mz; Fri, 25 Feb 2022 08:11:39 +0000
Received: by outflank-mailman (input) for mailman id 278778;
 Fri, 25 Feb 2022 08:11:38 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JTA2=TI=gmail.com=baijiaju1990@srs-se1.protection.inumbo.net>)
 id 1nNVhS-0006gH-5J
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 08:11:38 +0000
Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com
 [2a00:1450:4864:20::42b])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8d40efaf-9612-11ec-8eb8-a37418f5ba1a;
 Fri, 25 Feb 2022 09:11:36 +0100 (CET)
Received: by mail-wr1-x42b.google.com with SMTP id d28so3227302wra.4
 for <xen-devel@lists.xenproject.org>; Fri, 25 Feb 2022 00:11:37 -0800 (PST)
Received: from localhost.localdomain ([64.64.123.58])
 by smtp.gmail.com with ESMTPSA id
 m13-20020a05600c3b0d00b0037c00e01771sm5215190wms.34.2022.02.25.00.11.29
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 25 Feb 2022 00:11:35 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8d40efaf-9612-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id;
        bh=UBLS7I7dklf7q80OfnsV44HmdpezS2KIc4AWPPfOP04=;
        b=VmMDQhXZmW4KDOJcfBmlCBg33brjp9/FsvEsQq7AffkbjS1GeappduvSErrFoHJCPH
         4xVqaTIfaNjdXXrn4CqxUSvsL006OkvNj7yqrfLpVd0Z52/JQ9gUjeWYtz6Yc68FhtKG
         jU3N4MsHypNSnstReXP0RnnZO9RTAkFEYromKyn1uYaGYpphZXkwPGdSSNFabKe6EIt8
         HWw6x1CDGsRjItQCpqpsawyGOJTtoQXC/t9q7nIvSAyArxgpm+fJA5mQDoCdHb6QKqG8
         0M5wBFSvZP1A6mkfw5cvFRmDYS2qleDoxRbH7NoIo7DqZs2OKcFLHEKhujpMyzKbT9OI
         zsEg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id;
        bh=UBLS7I7dklf7q80OfnsV44HmdpezS2KIc4AWPPfOP04=;
        b=R8/Z2xc76hAcftCMRU7m1YSvDyPAgEn1uk0d8GB31md2Ks/HM6KGD3RotdBYUtaAa3
         CLDq/kDYRR0ooJzw59CcZmF5YVPxsdRTMqH4Z4TgE+DPw9YknQcIsu0r/7G77uSxfai5
         K9FfhawoHJXXvbsPb1GkZHfxN92/iT9Yluo2wtnjTGtMWqpgwTwASyt37OaoKkj4e8lq
         7TX1Hcgw3t+l2G6LzrvTmAXZGu4SA9dRkr9GcWZK4Zx7v1ObuQd5qiFZiHHTskye81ik
         u2CDiH8k1869e2MY81AsMw1n5aty7WPGKKPZoZzlNosgde6Z6GGZGk5KhiKKzqmV/LqA
         mtFA==
X-Gm-Message-State: AOAM532nT3nmCG5pfiu11Y/D1PwCR3VWLVuB0RZfsMJLfLUpsWXIM/I0
	APq+q8XBmtrGGMtLiY5looc=
X-Google-Smtp-Source: ABdhPJyCDoikK7f54V0mXZagQeuhGKw7xJp/PtqFade8F1gSuFIJPWK8WRRBh+uUcFbVeU632u363Q==
X-Received: by 2002:a5d:6389:0:b0:1ed:bc35:cda4 with SMTP id p9-20020a5d6389000000b001edbc35cda4mr5307355wru.350.1645776696385;
        Fri, 25 Feb 2022 00:11:36 -0800 (PST)
From: Jia-Ju Bai <baijiaju1990@gmail.com>
To: boris.ostrovsky@oracle.com,
	jgross@suse.com,
	sstabellini@kernel.org,
	tglx@linutronix.de,
	mingo@redhat.com,
	bp@alien8.de,
	dave.hansen@linux.intel.com,
	hpa@zytor.com
Cc: x86@kernel.org,
	xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org,
	Jia-Ju Bai <baijiaju1990@gmail.com>
Subject: [PATCH] arch: x86: xen: check the return value of kasprintf()
Date: Fri, 25 Feb 2022 00:11:21 -0800
Message-Id: <20220225081121.18803-1-baijiaju1990@gmail.com>
X-Mailer: git-send-email 2.17.1

The function kasprintf() can fail, but there is no check of its return
value. To fix this bug, its return value should be checked with new
error handling code.

Fixes: f87e4cac4f4e ("xen: SMP guest support")
Fixes: 83b96794e0ea ("x86/xen: split off smp_pv.c")
Fixes: d5de8841355a ("x86: split spinlock implementations out into their own files")
Reported-by: TOTE Robot <oslab@tsinghua.edu.cn>
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
---
 arch/x86/xen/smp.c      | 2 ++
 arch/x86/xen/smp_pv.c   | 2 ++
 arch/x86/xen/spinlock.c | 2 ++
 3 files changed, 6 insertions(+)

diff --git a/arch/x86/xen/smp.c b/arch/x86/xen/smp.c
index c3e1f9a7d43a..91261390f8c0 100644
--- a/arch/x86/xen/smp.c
+++ b/arch/x86/xen/smp.c
@@ -65,6 +65,8 @@ int xen_smp_intr_init(unsigned int cpu)
 	char *resched_name, *callfunc_name, *debug_name;
 
 	resched_name = kasprintf(GFP_KERNEL, "resched%d", cpu);
+	if (!resched_name)
+		return -ENOMEM;
 	rc = bind_ipi_to_irqhandler(XEN_RESCHEDULE_VECTOR,
 				    cpu,
 				    xen_reschedule_interrupt,
diff --git a/arch/x86/xen/smp_pv.c b/arch/x86/xen/smp_pv.c
index 4a6019238ee7..7d1471fd1267 100644
--- a/arch/x86/xen/smp_pv.c
+++ b/arch/x86/xen/smp_pv.c
@@ -118,6 +118,8 @@ int xen_smp_intr_init_pv(unsigned int cpu)
 	char *callfunc_name, *pmu_name;
 
 	callfunc_name = kasprintf(GFP_KERNEL, "irqwork%d", cpu);
+	if (!callfunc_name)
+		return -ENOMEM;
 	rc = bind_ipi_to_irqhandler(XEN_IRQ_WORK_VECTOR,
 				    cpu,
 				    xen_irq_work_interrupt,
diff --git a/arch/x86/xen/spinlock.c b/arch/x86/xen/spinlock.c
index 043c73dfd2c9..ccdb9eddd93b 100644
--- a/arch/x86/xen/spinlock.c
+++ b/arch/x86/xen/spinlock.c
@@ -75,6 +75,8 @@ void xen_init_lock_cpu(int cpu)
 	     cpu, per_cpu(lock_kicker_irq, cpu));
 
 	name = kasprintf(GFP_KERNEL, "spinlock%d", cpu);
+	if (!name)
+		return;
 	irq = bind_ipi_to_irqhandler(XEN_SPIN_UNLOCK_VECTOR,
 				     cpu,
 				     dummy_handler,
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Fri Feb 25 08:12:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 08:12:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278783.476159 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNViW-0007EA-3e; Fri, 25 Feb 2022 08:12:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278783.476159; Fri, 25 Feb 2022 08:12:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNViW-0007E3-0V; Fri, 25 Feb 2022 08:12:44 +0000
Received: by outflank-mailman (input) for mailman id 278783;
 Fri, 25 Feb 2022 08:12:42 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=RDkG=TI=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nNViU-0007Dq-4i
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 08:12:42 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b378e84d-9612-11ec-8eb8-a37418f5ba1a;
 Fri, 25 Feb 2022 09:12:40 +0100 (CET)
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur02lp2055.outbound.protection.outlook.com [104.47.4.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-7-D9MGV2fxMH2jSVdXog5zOg-1; Fri, 25 Feb 2022 09:12:39 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VE1PR04MB6542.eurprd04.prod.outlook.com (2603:10a6:803:123::32)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.25; Fri, 25 Feb
 2022 08:12:36 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.025; Fri, 25 Feb 2022
 08:12:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b378e84d-9612-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645776760;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=ZtSJfUDPTaZX3Ro+9HI1MQjzcDYms16CEya/kgr+EiU=;
	b=TZZruFp/SGqEXHhLI34UayZD9TITb1+0rHyxiZuNjt4+30g2Av0Ffuha1wHKx6sVTbzRsx
	4M70GmvBZhCgKyxnv3X2soFDUp/1YXrtw9aB/Cl4nMWFu5Vd5zm4BJmLbguLNlNdaIAsQL
	ZEBxcLRvpwhW3/3rJwXfC0GxXVJIvXs=
X-MC-Unique: D9MGV2fxMH2jSVdXog5zOg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=KJyPUqFTsiq1KQJKlM/tIVjPscdsOA8hAAYX8cVwJ1nWvD9e4jRfCuzulxa7+nS5MrshbgetpJL1FBNxmP3phlNrzUo6DNZvMiWVjdWMU7ZdcKWhNtruy1/Lwn80H2DA2YfLofGgsrVAbbjkQ0nniI3qn872MZhVxAam5VabnxOyyO+OdblueqdzrRlpeoo9/OHpoj+0dORSDWkX2AaI5puWsqMh2nh74CUP/3acL9Ep4Zpt1tAb8nChdOc5AwtLtR+PT11lH+TzUEtObZcX3SxUMCmy+l2/rJnTf+6K++fevvkgU9HqD0W6vnRSMcvg8n+Fo50jcC4PCTVOAsfEqw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ZtSJfUDPTaZX3Ro+9HI1MQjzcDYms16CEya/kgr+EiU=;
 b=dk5anf7rqdYt/9LwW6bqsCxJ6Yln5AFv+7p2xbUDZ74jP2CwThfVw99+W/PxNeiwsx0AupWEec+57nN0W4Mpe8MW0EpXfPSQmWG8g2x7u2WShwem0XJyoSKCE+kzYlN4WkW30JRtLyilCIeNaUhhv/tGQ8V55o/1Jex1s3t4YaPEPkx282fQb5U6z13ZuBNw8c+ARA5r17k+XgICH0MUg2UaYdAQCyacjdlt4KEUl5P+b5A9lUHs6QhHtzRu+8K3t8yVyOAtb9YWG7VBGHqtv7g+WyOmTF+ayRmW8WBgae8Uvdfbig18Yf8pZ7V09A4bFjnS5Oi6bvoPF256uyuKIg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <cade3f06-4f25-07d6-3090-08a6487ba298@suse.com>
Date: Fri, 25 Feb 2022 09:12:32 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v2 2/2] xen/include/public: deprecate GNTTABOP_transfer
Content-Language: en-US
To: Julien Grall <julien@xen.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org, Juergen Gross <jgross@suse.com>
References: <20220203131418.1319-1-jgross@suse.com>
 <20220203131418.1319-2-jgross@suse.com>
 <a35bb9ba-e2be-f73e-9272-906bc09d9b6e@xen.org>
 <93e50bc4-6e53-b753-c520-7d1d0a5a5f5a@suse.com>
 <7ca05a74-6b65-f9cb-f524-28d700a7d0e4@suse.com>
 <78543fe5-1dde-41b8-e28d-de2cf22fc87f@xen.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <78543fe5-1dde-41b8-e28d-de2cf22fc87f@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR04CA0008.eurprd04.prod.outlook.com
 (2603:10a6:206:1::21) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: da837d05-2dae-417c-00ef-08d9f8369435
X-MS-TrafficTypeDiagnostic: VE1PR04MB6542:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<VE1PR04MB6542F749C73B1B9B5C47BD4FB33E9@VE1PR04MB6542.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	JCnkbxDSzs0aiAl/yNxOk410q1xOc74hvHN5eK3eHHu82VCDNSsH6oAc6WX+TfnLae8pfTVwcpEyJHfDrsHFOj1c6Oew1o4M/Qlq/2T6Dl8awoVavA25zrbxm18fTX1NNcq0kPiGk3QFN19/+DhYy62zZFxriBKWPvdUwDi9cCd7CbDtW4ONww7L21XcOGKFLBR/5ZQs1sRcnh7s/MriF9BnyHzT48RcGA6ufTxZo7ipwrVqLo4v1fQmKpmnrM0GdSzgfcow8PoCFrrUXbQ/m2juFxNtfVJC1ncl4QaggPoDlabrRDlulK/y2+uNv4v02E2EyUE8sCriW0RdlJP2Cj6/9kPkmPBFnPTqJbpXbQvF31eSvHe7pn3jYlYVdXsvrk4SIWpLqmAo2Tgzlnlu3PYqofDdeqlQZVpw2Rq+nydbci/BAnAUH6bFNtwihWzrAz+7ZDLVArg5Su1bXbKrAIAxkKfNhD+c3OYGM8WiA/WzTdq9GefW6V3yvrFfrkOc4+nDmkKeWI67RLGnKzIeCFwD3jbbgN1i+bckdOywsfzVywx1CSPm5bpWlcJtIwk0Mk3VnKeSEn9lmvlJ1aOmf/++mYz5NKm6gF/37mnBc8GmdiCiQucFecnHFbwKldfHTdfrWCoQUsCnuI26vp15Jgii8NhreSVNR/kU8wAboEcvv6c4FKH4xMnPdQz77r5Elb/vYaMU+40Wi8xWWCJCvGMUCHC8vEV6udQz9bq1Cw9qMXgXKzLaVW4tDaSuE/te
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2616005)(36756003)(86362001)(8936002)(6486002)(5660300002)(83380400001)(6666004)(31686004)(31696002)(54906003)(6916009)(186003)(26005)(6512007)(316002)(38100700002)(53546011)(107886003)(6506007)(2906002)(66946007)(4326008)(66556008)(66476007)(508600001)(8676002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Mko2T0pIcXhmc20xSVU2MWkwMFJ2N1o2eWFVdlFTYWxUMXVCQnIrOCtQMS9h?=
 =?utf-8?B?RHozWjZQUm9JaUtkQWFYWWd6STRXSnVXdllJempDYVRuMEROS2pZZktYenk1?=
 =?utf-8?B?dmhTd0ltaUU2c0FjOXRWTnpOM0tNV2pteTdqY2hydUFzUERLTXdSZ0ZIRDVO?=
 =?utf-8?B?MnIyMUNmMzF4QVJsMmtoWUhhb1FrYnFGYkJVOFRmTWxzRXNnaUN3azFqMmpR?=
 =?utf-8?B?Vi9KN0FWRXNLbC9sbDdhbUxFUmp3L3BpWlNDSEd4amFvZWxaSFovMU9HamVD?=
 =?utf-8?B?emx2MTZGZFVpQ1BqKzRkaDVkVEtCeUprbzBjUFpPUGpOVGw5K1ZYRzUzaDhk?=
 =?utf-8?B?VmRvU1VKcjB5WDJFdWQyc2h5WWdOMUJGYjNUTEo4VGdOZUlvNXl2ZlFYcExW?=
 =?utf-8?B?aDV6UTJQdmZZUy9rdWxiSXVxbXZOU0FkTEpoWTlrbHh0SUY2amk0Wml0MkxS?=
 =?utf-8?B?YmNndVd3NnBFajF0L2RIdFpFOEcvcVVtNEpod0xPbGI2dHRWb2tWam9SVUR3?=
 =?utf-8?B?NVVjdFl4bEZhdGt3RzlGcGZEOW04TFgxdzlFNHZFV0gxcnJpYXMralB0WlZK?=
 =?utf-8?B?TDVnWmZDWHFBcFRHdTY3KzN4Zkg5Z250cU9FMnZkbHVrSTg2RnpKTi9vZmpo?=
 =?utf-8?B?Q0p4dHN6bjFNN2dyV2VkencybDEyWWRyOG5peDNEeXR4ODNMcWN3TlVKQUE5?=
 =?utf-8?B?blV2OEUzbEYwUTIrWDUweS93Witsb2c4d2tNVW4wYWJQZ1BnT2NNUWkxYkdy?=
 =?utf-8?B?Qm1kSkRNeTJ4YVBHOUFlSk94Tys3anUyS2JTcXV0ZVVsVmE3ZWlOUWdoL0Rm?=
 =?utf-8?B?dzBDd2RsZGdsSkdHZ3RuNStsUmpBNXA0TXBPbWJ0d3FnQTgwclJRMzdLM1dq?=
 =?utf-8?B?U1QrazFDLzN4WE50cThLbUVpNStUREFCQzhMK29ySUZTd05pSHR2S0VEUVVU?=
 =?utf-8?B?TkUzU0d6eGN5UnBta0JqUVlkdDFQcWdlVkNLNkdQTjdZL1BYcmt4dXhkMER1?=
 =?utf-8?B?RmxRWU5zOWhheFY4S1c1WDc2SFJLRzJoL2VHVkUrTGxVMEJNSVk1SnhVTlNs?=
 =?utf-8?B?U3pua1pxOXRCbHZKUXBoQmFCYjZKeC9LQkk2aFI1Zkh4b250QzhrbzYrakpZ?=
 =?utf-8?B?TEl2MmZ2VVJtUGJnS3dPcHorTGtGdkVoU1MxRHhUOE92aW5VSXRwaDA2TVBD?=
 =?utf-8?B?MWZ1U0NIbTNNWmN5VzNCeDdtSzBFWWJGamhEQmM5QjFHUzdJNW1IK094R1g0?=
 =?utf-8?B?UDAzNFhFSkVIQ1lwQmQ1RHEybnppL2RFWjliUHdnU25PcnZCa3F6VThkODI0?=
 =?utf-8?B?Q0loL2k2YTV2UEdTUVhZUVo1MmlJZ1R1VEgzbzBhVEJya2tGUUVhekttMFZq?=
 =?utf-8?B?NENLM3gvckcvUWU1QmY1dERZcHQxS2pEVnI0MXdWVWpuSlUxcnZZMWtYeHZG?=
 =?utf-8?B?YjJPRGFDNnhDaHd1d0tBaWJ2d0dlQW01R1pTaENaaVhTK09lcnFNdi9QRGti?=
 =?utf-8?B?SGc2Rk9iOUVIV0ZZVUtaczB2Ymdhd09SUkVac2JMTFRtS0c4VEozNGl6Z0RS?=
 =?utf-8?B?VDVSdEtpM2MyaDRFK090bnRtbE5nV0EyaFpiZzFMSU1yYmgvS2JpRVgzWGVS?=
 =?utf-8?B?aDM3L0g0UTNpV1pTdEJkRG5VSDBhQUVza3VuakFoSW1LQVBoYlQ2L0V0dHM0?=
 =?utf-8?B?dzREdHNLcHp5RmZVdjNuM0liWVJaMnBHYVM0Q1BGQTUzRGFhVHhucFFjWUNq?=
 =?utf-8?B?cFlBVGxVdHEwNjA4R1phc0pwNXUrZExaOUphSHNUS2djQ1pQNzUwL1U1SXZO?=
 =?utf-8?B?c1BReVUxN3ZSVS9mRTNIQXFVSEpyMnVucnNvNzZJck56YmY1MEZ2dXA4Znh6?=
 =?utf-8?B?SWo2RlI2WXNFeEhLQ0lwSlh1eGs5RDJSWnZvSjRFeUllUGdMRTFIeHBRa3Jq?=
 =?utf-8?B?MnhPQlBuNVdTZGw5Y1pudXR6UVpJWE5FYyt6aGY1bVNxZlVGOXNzeUM0cW04?=
 =?utf-8?B?R2RpN29ac1MyME9qVWN4anp2RU51Umh5NXlicHZpMkUvay8yNHJSYjA5OE9Q?=
 =?utf-8?B?eXkvSW95YjYvcVJwUHp2a0d1TWhWaXR5elJpQ1lqTEdYRE9JN0I1ZllCQjZI?=
 =?utf-8?B?VkZhYmNFWlcyN0RUOU5kMXl3cHNlVW8ySVAvSjMyK2c4cmNwUFF6WnNUc3l5?=
 =?utf-8?Q?UPKiOM/aqzSTQVwR67aHASI=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: da837d05-2dae-417c-00ef-08d9f8369435
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2022 08:12:35.7746
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /t9M56upUyZ5UdH3+1fI0OA/IV8EZRyFer7ZkDqW5wFIZYK4zHYZGSn8EeBwOInmH4v/d2zdE6KpSKUf8z5hRg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6542

On 24.02.2022 23:55, Julien Grall wrote:
> On 16/02/2022 09:29, Jan Beulich wrote:
>> On 16.02.2022 08:20, Juergen Gross wrote:
>>> On 15.02.22 22:13, Julien Grall wrote:
>>>> As a side note, should we also update SUPPORT.md?
>>>
>>> Good question.
>>
>> I'm not sure here either - talking about individual hypercall sub-ops
>> seems overly small granularity to me for this kind of doc. Plus I
>> don't view deprecation and de-supporting as the same thing. The latter
>> would mean to render unsupported any old XenoLinux which may still be
>> in use, all of the sudden.
> 
> I understand this would result to unsupport some old OSes (not clear how 
> old). However, from what Juergen said this feature is untested.
> 
> To me it sound like we are not confident that we could security support 
> this feature.
> 
> So I am not sure to understand why we only want to deprecate it.

Not sure what to say: Rendering unsupported however old guests is not
a nice step. Hence my concern (which isn't an outright objection).

Jan



From xen-devel-bounces@lists.xenproject.org Fri Feb 25 08:20:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 08:20:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278794.476170 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNVqH-0000Ne-33; Fri, 25 Feb 2022 08:20:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278794.476170; Fri, 25 Feb 2022 08:20:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNVqG-0000NX-VM; Fri, 25 Feb 2022 08:20:44 +0000
Received: by outflank-mailman (input) for mailman id 278794;
 Fri, 25 Feb 2022 08:20:43 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Zfiy=TI=citrix.com=prvs=0484f4aa7=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nNVqF-0000NR-J0
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 08:20:43 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d0e759d2-9613-11ec-8539-5f4723681683;
 Fri, 25 Feb 2022 09:20:41 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d0e759d2-9613-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645777241;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=n9QJyCVLG8Ho/ORYM9gRdxWQ7f3hr1iV625024GGrjA=;
  b=cToaSeA7UH3MXzUYegPgDKs+lqcrT9aAMXZVH8IX2O4vyhUOrhz0gm2G
   aBLu5APd6RQ972y+djb7YEtrk5Bx9+h8BPOsNcMqqT0woTZSwvhT2NDPu
   P4TdhGEsJEbmfR1z9TOT0cwfHCWTLio43yHb2IQP6KsioIHCRAX6Fkd26
   w=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 64975463
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Q3N5mqvwZjDFdxdQXHaJGT+8refnVJFeMUV32f8akzHdYApBsoF/q
 tZmKWrXa/aPYDb2eoxyPI22/B8OscSEyNVmSlNkrn8xEihE+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQyw4bVvqYy2YLjW1nX5
 IuoyyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb
 /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo
 Oihu6BcRi80DqKPodsPTyJ6UABFB/Ya26DeCHGW5Jn7I03uKxMAwt1rBUAye4YZ5vx2ESdF8
 vlwxDIlN07ZwbjsmfTiF7cq1p9LwMrDZevzvll6yj7UF7A+SI3rSKTW/95Imjw3g6iiGN6AO
 5tGNGYxN3wsZTVFK2UUOs46ptyv2D7vaDt2pnDIuIEOtj27IAtZj+G2bYu9lsaxbcdfk1ucp
 2nG13/kGRxcP9uaoRKa9lq8i+mJmjn0MKoYGaek7PdsjBuWz3YKFRwNfVKhpL+yjUvWc8hWK
 1EQvDEvq6cy3EWxS5/2WBjQiG6JuFsQVsRdF8U+6RqR0ezE7gCBHG8GQzVdLts8u6cLqScCj
 wHT2YmzXHo27ePTGSn1GqqoQS2aJBgablY9dzM/b0gk2OO4/KIslzvGZ4M2eEKqteHdFTb1y
 jGMiSExgbQPkMIGv5mGEUD7byGE/caQEFNsjunDdif8t14iOtb5D2C9wQWDtZ59wJClok5tV
 ZTus+yX96gwAJ6Ej0Rhq81dTejyt55p3NAx6GOD/qXNFRzxqhZPnqgKuVmSwXuF1O5eKFcFh
 2eJ5GtsCGd7ZifCUEOOS9vZ5z4W5abhD8/5cfvfc8BDZJN8HCfeon0zOhLJgz21yBB0+U3aB
 Xt9WZz9ZZr9If46pAdaus9HieN7rszA7Tm7qW/HI+SPjuPFOS/9pUYtO1qSdOEphJ5oUy2Om
 +uzw/Cikk0FOMWnO3G/2ddKcTgicChqbbir+pc/XrPSfWJb9JQJVqa5LUUJINc+wcy4V47go
 xmAZ6Ov4AGn1C2fdF7TMSgLhXGGdc8XkE/X9BcEZD6A83MifZyu/OEYcZ42dqMg7+tt0bh/S
 PxtRilKKq4npujvk9jFUaTAkQ==
IronPort-HdrOrdr: A9a23:qY3l5qkJgDKlF/FEttAgBRvdcFHpDfPCimdD5ihNYBxZY6Wkfp
 +V8sjzhCWatN9OYh0dcLC7WJVpQRvnhPhICK0qTMqftWjdyRGVxeRZjLcKrAeQfhEWmtQtsZ
 uINpIOdOEYbmIK/PoSgjPIa+rIqePvmMvD6Ja8vhVQpENRGtpdBm9Ce3im+yZNNXB77PQCZf
 2hDp0tnUveRZ1bVLXyOlA1G8z44/HbnpPvZhALQzYh9Qm1lDutrJr3CQKR0BsyWy5Ghe5Kyx
 mOryXJooGY992rwB7V0GHeq7xQhdva09NGQOiBkNIcJDnAghuhIK5hR7qBljYop/zH0idgrP
 D85zMbe+hj4XLYeW+45TPrxgnbyT4rr0TvzFeJ6EGT1vDRdXYfMY5slIhZehzW5w4Lp9dnyp
 9G2Gqfqt5+EQ7AtD6V3amGazha0m6P5VYym+8aiHJSFaEEbqVKkIAZ9ERJVL8dASPB7pw9Gu
 UGNrCR2B9vSyLaU5nlhBgu/DT1NU5DXStuA3Jy9/B96gIm0kyQlCAjtY4idnRpzuNId3AL3Z
 WADk1SrsA8ciYnV9MMOA4/e7rENoXse2O7DIvAGyWvKEk4U0i93qIfpo9FoN2XRA==
X-IronPort-AV: E=Sophos;i="5.90,136,1643691600"; 
   d="scan'208";a="64975463"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=KlHJm6PrQmzOzLS2lcJIzT8FCA42BZ1e20hF30AkwqOLPkTXoLnY/m0XKLx7HnEGWAfF5cX3nHj7RKzJrrhHNQ22tLBmF1QPE+hxTrfLJfSk2rDOlG2N3bF27vlYuSRF9wh0DRUs9GoxOXSxmksGSFT/LZLd82K+bWlInm3TSC736UWSP8cLpOBmycTZnXMu9M2KdOiC5hmoDxn4COhKJgd/0W4bFHQvriKM5ku6tG6HzGVEjzFs0c+7q9L1KQpGzs448ZO/UTot1rnrvB51lg/OWsxEz1Y9OdjaMXEIX4Sck+WB61gfAL6R908vkgkMj/ltnPH5NpXUd61Lb4aNlw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=PUtxugdevG2Vz087BTXIdqD2zU1rmzcIyP5uJoil3Lc=;
 b=JCCPnr9wgP8eOmZE5NFLU1+IW3mjTmT7bUoU1Fg6BqunH+XS2/k9fJb0j/SxOOMW7xrVvGgg+udOPFmMLCbEndVH0aDE47y5UkKkWC/W0L6BFFQMaEo7GlcXYaoA/gDydsQZ0akPLDojutX6OMpuFUSvuOC3w/AnQ6VY+eEFbmpD0C/YlK7cAYDK5uqzIJYaxZK3vyAJdhJnKxGDCbTMh6g3ldeZtvnl5iTKVY8GMNeVZkTSSoR4BG9YRbWVd5n+jNIbDJEy21cHn/xE6cHlT6k8DSb/RmOiKmh+6TAFKNuKneF0ysJVhmZ8pCAQtrNUoJmqNEj7sljOF9QAxbNA+Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=PUtxugdevG2Vz087BTXIdqD2zU1rmzcIyP5uJoil3Lc=;
 b=VBJeMU0HeITW6IpBqp4duZ0MeWfk+kaQPIWwvJWKfxgzoo0XfIKKfqt5DpBp8aZ17b5zRoAYaWNSviGmYEmf87UJovU89q14QjwUm+vwk2MAGDfl9WdACnHZd7uLxdvrt5DBxr5MD5l/eBy5ktqNYdSurG1sBIULZAiOURvbvmY=
Date: Fri, 25 Feb 2022 09:20:27 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Rahul Singh <rahul.singh@arm.com>
CC: <xen-devel@lists.xenproject.org>, <bertrand.marquis@arm.com>, Jan Beulich
	<jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu
	<wl@xen.org>
Subject: Re: [PATCH v2 3/3] xen/vpci: msix: move read/write call to MSI-X PBA
 entry to arch file
Message-ID: <YhiRS11TlQjuefHR@Air-de-Roger>
References: <cover.1644937405.git.rahul.singh@arm.com>
 <3e47316052dce3c85bde04ab6b72ba4f48fa0bb8.1644937405.git.rahul.singh@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <3e47316052dce3c85bde04ab6b72ba4f48fa0bb8.1644937405.git.rahul.singh@arm.com>
X-ClientProxiedBy: MRXP264CA0045.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:500:14::33) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: be0909cb-8eac-4c6e-9df6-08d9f837b16e
X-MS-TrafficTypeDiagnostic: MN2PR03MB5264:EE_
X-Microsoft-Antispam-PRVS: <MN2PR03MB5264D4BEF943AFF071B94C568F3E9@MN2PR03MB5264.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: SHMtiebEHs/lF7Xfn0ZDfImfvOnyFbgZ9Xm3FmRCG0E/lAAnJT+Ik8F4XMyzpOXJnM4vvSKhU8lJoiRliHMozfKiwmV1z3x66BrUU3MKUkZmblDM7Mydcpf6cV6mabqQp5iStmcjP4F0bMU2JbNkxNg6R13l8xu+7DZvbOTTCDK75gKidRiPFZW0GHioBNO6pkpc0uU0mILhMNlhugT4LGQpTutWfBs6pUpGQ604C/Ig96ba1DFZygZi6qEdlJ7Ql59uOy9Qaq1jS5mXyJ0v4ybAoaLkymmkSly8GFKUYXddgL1xi5gL6ZbPZHNiZ/pZP6Ta+sxgX6TxeqfwNn+IZnbEeD+tub0GhjlmhldKLEgXcVjswZ0D89DPedful+Cp2ukz76mWS8iF24L925oFKiDDaAhZgXfVniM8GPdNYJwGlARObIY6JgeAxJbemXSer5fZTBmVHe8RREhVgUy8R4yyJz0D2RGlSGg6nC0wghYKCxjq00BrHcDqYzSOzX4JH9bda480TebJq/vJu/vyDy9iZi1wL7uQQwgpyM/plY8btHiphqnA5c3xmkg9vsXpycqKhSvyK/2vh11kARaBETP5kh6oGZF1YsJbjfHGTsonNsplgCYo/LZDG0z8jMGP+WhWeEt0yfg8oWchjLsIIg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(86362001)(2906002)(8676002)(4326008)(66476007)(66556008)(66946007)(508600001)(6486002)(316002)(54906003)(6916009)(82960400001)(38100700002)(9686003)(6666004)(6512007)(6506007)(83380400001)(8936002)(4744005)(5660300002)(33716001)(26005)(186003)(85182001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cDVGTjhLZEtFenF2R3EzbEk1UUlmLzNIazFTNVREMDF2bFlXUDVzSWNRRjJG?=
 =?utf-8?B?WDhsbHFPSGpLZFkyY1A5TWhEUGJ4TVd1V2pKSEFxaERqSWZzWGZiZkVLTHRx?=
 =?utf-8?B?bnJaNTlzSFBqVi9CemsrV0RES0E0MTFrc3R6SWFQTldPQk1XUFJralc4WXNW?=
 =?utf-8?B?ZTcyMndPL3VWRklRTkJvbTRyNkpUYUowNU9ObmhwZXBGWE1UY2QxbHlUZ2xC?=
 =?utf-8?B?MFVPTnZHYnlzamc2MmY1TVpzbU9FcDJFa2hQMThPRW5SUnN4NXpJeTY4Z2RZ?=
 =?utf-8?B?dHBabjhENGc4M0REdm5CYUJBeWh0OXJGaU1oU0lLd1NMUkJQcXFnTTFwRnJM?=
 =?utf-8?B?ZHAwaVRmVGxLSkhCTzdrMjNPdE9XM05kdzEwbUJsUjdEOW4xbytVaFdtMHNZ?=
 =?utf-8?B?ajdwV2VDWHpEaEVRcGFqYzdYdDYzdUVkWlB4ZzRtc1lyb0d4KyszYTB0Vnd3?=
 =?utf-8?B?SWthazd4bmZGN0tMcDJZenlmZTZrdkZob1llTitUMm9ueWlvZHp4cmpINkhE?=
 =?utf-8?B?Y3piL3RZTkI4aGdlL0hSQk9wQldvc0xMWGU4LzhpeEg1NDZzYW5IQmxCdSt5?=
 =?utf-8?B?STlWOFd5TDJlS0ZhNkRGMWxmZk5WMWJpNUZrQ0RVSERYa3EyTlBEajlMWktU?=
 =?utf-8?B?Y1llQ1kxVk5qMG1nVTRZb1RNbHlzdVQyNy9XajllRkVXaGJDckdXKzQ2Mld6?=
 =?utf-8?B?R2wrWEhLKzdSaG9mV0c4YXJFTjZGcDYxQUdMV0NrOStPMytIYnJQbWF4SGpN?=
 =?utf-8?B?RnArNEZpWHk4ZHE0L2VleXMyamJCZnh6VGY4ZmFiWjdiL1FibGZyKzlDNDNM?=
 =?utf-8?B?cG9RSDE2NzlhMHhyYnRBN1N4R0lJYWtqT3E3Rlc5UU40Q2M0ODlMYzJMMVpJ?=
 =?utf-8?B?THpEczk4WnFkdFZtdkhqSjcyRjF0NnJNWms4bjlLZ09Qc2tHYVU1Y1JabTJp?=
 =?utf-8?B?eTNHemtjdURCUmZWMDV5eWVuWmt6U3pnSXFTTXVreXlPMU5NVlhZUUg2U1E1?=
 =?utf-8?B?STVwVVlLWGJtWVEwb1BvMmF3NVRBZkl6ZWdxSjFTWnMrL2ZUTDNzUU9yeDJN?=
 =?utf-8?B?eTNOSm9iS3k1eEVPaHZYajFKUk9IZStIcEtIMThvM0lSMXRCdDdUVUFMNHNl?=
 =?utf-8?B?cjhIMmZuY2VKY2dqVklJWVZpbzYrTFhYU1d2MEFxUzFCSU9LNnlMRmVZallU?=
 =?utf-8?B?VWs5TysrRjNJR1NmZ0FXenVpNmZMYmdBL2lxQ1VGc0VXQlV4MmRQcG9TN1Yz?=
 =?utf-8?B?cnBTL1RMaWRQaUpnV0JoWndJaDVUN3pLNEI0eWI1S3hkWWpIS1dMa0xHMnRw?=
 =?utf-8?B?R3k2SjhHTkhsMmdURW5HUWNGYXBabEdaeERIU0NkdGpmL1g2OGlCdFl4YTJ2?=
 =?utf-8?B?TnA3UVVoMnJNQ3AvR0lkK2s5d2xYVUFHUXgydXdWOHZmcFEyNnpzL2JXRlJz?=
 =?utf-8?B?L3ltRWdWSVVIbkhiczJYRUh1SmtCcmt4Tjg4N08xNDFxOEZ3eEY3YVRqTC9a?=
 =?utf-8?B?Zzh0WUppZDk1VE5GS2RZQVZpVm1kRXZxQ0tTV3JwVy9USCtCbGlZU2RnTmRu?=
 =?utf-8?B?Ly90NFNUK0IyV2pVSkYvTUVVUnBsT3FyUEtJOUhEdGp4SEhZWm4vaXFtRlhG?=
 =?utf-8?B?ZmJqRDJkZ0FhS3N6ZWNpckU2ZC9UNGt0RVV3S2NYYVM3bEtGdFhEMmh3eC9x?=
 =?utf-8?B?ZDRsZ0VBOFE0UTVKNEpibXBNbzNoWU1KMFpHTVZBOEFOaFlkNHovSXpsKzBV?=
 =?utf-8?B?NlNpYlZ5QVZzMjFVaWxCeTBFUngxQWRlNGZhVnZ6VGxwakxTMnRiK2FRL2lH?=
 =?utf-8?B?bkxFdlBXZlNUWjE5dkE4UkdQL21BK3NtMXEzK2h2TElITUJMSlgzS1Bxd3lX?=
 =?utf-8?B?NGlaaktCYXlMdWQ4WkRSbSt5V0xaMmwwcmdXRVdzU29QWlFlanljZHpUQmEv?=
 =?utf-8?B?NTN1YXdHNS9QWGJ3UTZnZWVDNC9mMlR6VVM4ZDFnQXpNaExGNXdqK1lGR0lJ?=
 =?utf-8?B?cVJ2RXBMN2RmWldIYVNrbU1tbUVPbVhHMlBWNDlZQlhTS0I3eXlGMDJtQTR2?=
 =?utf-8?B?YVY2aVJ4MzRWMkNnay82RnlKUXNtZm5DcWYwQXFKSHBKUXFsM1NwYUFhKy9r?=
 =?utf-8?B?VnBnemVJQmdITmVUNDUwYitQemp6WHBMOXVTRFhKdG5CRUFJdlVRVDRJbTFa?=
 =?utf-8?Q?NaPeM3NKzq70Y7imXRxWP3k=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: be0909cb-8eac-4c6e-9df6-08d9f837b16e
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2022 08:20:33.7247
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: X47VHzDRXMtvygpGnRoNGiwYacDpmJXnv2IQjjQ67uDtF0ek7gCI2Q9yUVThODXlFc1niSso2Angks2SA5pquA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB5264
X-OriginatorOrg: citrix.com

On Tue, Feb 15, 2022 at 03:25:18PM +0000, Rahul Singh wrote:
> {read,write}{l,q} function argument is different for ARM and x86.
> ARM {read,wrie}(l,q} function argument is pointer whereas X86
> {read,wrie}(l,q} function argument is address itself.
> 
> {read,write}{l,q} is only used in common file to access the MSI-X PBA
> structure. To avoid impacting other x86 code and to make the code common
> move the read/write call to MSI-X PBA to arch specific file.

I think we agreed where going to unify {read,write}{l,q} so they could
be used in arch-agnostic code?

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Feb 25 08:22:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 08:22:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278800.476180 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNVrX-0000ws-Ct; Fri, 25 Feb 2022 08:22:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278800.476180; Fri, 25 Feb 2022 08:22:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNVrX-0000wl-9n; Fri, 25 Feb 2022 08:22:03 +0000
Received: by outflank-mailman (input) for mailman id 278800;
 Fri, 25 Feb 2022 08:22:02 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Zfiy=TI=citrix.com=prvs=0484f4aa7=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nNVrW-0000wd-9i
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 08:22:02 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 00087e18-9614-11ec-8539-5f4723681683;
 Fri, 25 Feb 2022 09:22:00 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 00087e18-9614-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645777320;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=SU2yN9Q1lEKlxdyV4yT10+E7f1BL0BrER8rYX+/tAnE=;
  b=XyGKixw4QNDfABKvZbdeo81gKqvJVHfrk9yBRh8trwdOuCJmkLhEHOPe
   zf4Qi5dr4cGWbBPJ2U94XQ+CEZ0ds41lH5yC8B2/DYvgFFVl/qnU6NZZ7
   8fDA4v2qQ/4a/XD0KwrfjmsfoSFg/7iqL47J7u3AKuWP2V56yvKJuz92k
   A=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 67238741
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:hnJyXaBKHpkrgxVW/+7jw5YqxClBgxIJ4kV8jS/XYbTApDkm0mADz
 DEYXGyGPvnZazPzftt0PITnpB5Q6p7Qy9ViQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHWeIdA970Ug5w7Rj39Yy6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhWy
 Ol8jZK2Tz0DO7fxmcEzYjx/IythaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguw5K8bmJsUHs2xIxjDFF/c2B5vERs0m4PcGg21r1p8SRJ4yY
 eI6UhpBV0nkPydkJ0gsA7Mcpbr5xWbGJmgwRFW9+vNsvjm7IBZK+KfpGMrYfJqNX8o9tlaVo
 CfK8nr0BjkeNceD0nyV/3S0nOjNkCjnHoUIG9WQ/PNwnEeawGBVDRQMTEa6utGwkEv4UNVaQ
 2QW8Cczqak59GSwU8LwGRa/pRaspBccRt4WCOw85wGlw7DRpQ2eAwA5oiVpMYJ88pVsHHpzi
 wHPz4iB6SFTXKO9bnKhx4+aqzWIEy0PEG4nSx4hajsP/Iy2yG0stS7nQtFmGa+zq9T6HzDs3
 jyHxBQDa6UvYd0jjPviow2e6964jt2QF1NuuF2LNo6wxl4hPOaYi5qUBU83BBqqBKKQVRG/s
 XcNgKByB8heXMjWxERhrAjgdYxFBspp0hWA0DaD/LF7rlxBHkJPm6gKsVmSw28zb645lcfBO
 hO7hO+ozMY70IGWRaF2eZmtLM8h0LLtE9/oPtiNMIYTPcQoKFLfpHk2DaJ144wLuBJ9+U3YE
 c3GGftA8F5AUfg3pNZIb711PUAXKtAWmjqIGMGTI+WP2ruCfn+FIYrpw3PVBt3VGJis+V2Pm
 /4GbpPi40wGDIXWP3mGmaZOfAtiBSVqWvjLRzl/K7frzvxOQzp6VZc8ANoJJuRYokiivryQr
 yHlBxQBkwKXaL+uAVziV02PoYjHBP5XhXk6ITYtLRCv3X0iapyo96ARa908erxPyQCp5acco
 yUtEylYPslydw==
IronPort-HdrOrdr: A9a23:bfXFlKuZLPblowWK25s7nYbE7skCmoMji2hC6mlwRA09TyXGra
 +TdaUguSMc1gx9ZJhBo7G90KnpewK6yXdQ2/hqAV7CZnichILMFu9fBOTZsl/d8kHFh4tgPO
 JbAtVD4b7LfCZHZKTBkXCF+r8bqbHtmsDY5ts2jU0dNT2CA5sQkDuRYTzrdHGeKjM2YabQQ/
 Gnl7Z6TnebCD0qR/X+IkNAc/nIptXNmp6jSRkaByQ/4A3LqT+z8rb1HzWRwx9bClp0sPwf2F
 mAtza8yrSosvm9xBOZ/2jP765OkN+k7tdYHsSDhuUcNz2poAe1Y4ZKXaGEoVkO0amSwWdvtO
 OJjwYrPsx15X+UVmapoSH10w2l6zoq42+K8y7tvVLT5ejCAB4qActIgoxUNjHD7VA7gd162K
 VXm0qEqpt+F3r77WjAzumNcysvulu/oHIkn+JWpWdYS5EiZLhYqpFa1F9JEa0HADnx5OkcYa
 RT5fnnlbhrmG6hHjHkVjEF+q3tYp1zJGbNfqE6gL3b79AM90oJjHfxx6Qk7wI9HdwGOtt5Dt
 //Q9RVfYF1P74rhJ1GdZQ8qOuMexvwqEH3QRSvyWqOLtB0B5uKke+z3IkI
X-IronPort-AV: E=Sophos;i="5.90,136,1643691600"; 
   d="scan'208";a="67238741"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=OIsdafmqmtayZ48S6seSN0jsxXT18jYKmZjZk5AYON/W8ici1nIPqcLck0JcH3olzYGiIE0beOJkL0xTEkWJxCPMZWX1R8nbReNSzBGTODfGH4WRR4e95Pyft5iLqdzi8wfXWWtwoQ8mjfi+Pf6KqEGQwsILvGmWShOQleUC5lKUp7BQf5pU55M1l5JHWL47A8MEYtdifzx3hbuu45nOy8ERhJfsOFmCmzAm4aScK6WmGb4wTou61b+eWHRIbr/N2SiCfrdW/lk5Yrc+mQTsSRg4i5u5xFuOos9ewj+rWhcIecDh0UWsFfmgHgSLMcs606lm8x2OweHVatmnZryfug==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=oP54Ot7PWMoy2ZY2U1Ti9Nruaac6CbGjFHOhndATzFY=;
 b=BoNbPT8X+a0AorE/Eu/hNL2Ad5fk72upHRKvZXhdvqrrz5y5DKwYn9cWSRpntRBWqt9DbuJ0YSj4SgO6x+Qz2IvIvS4hD6EEBIrnXQra19boZbJOcQjyRjj8CJ5qO84h2betmU8Zt8L+OrnvqCmMZW+k81rCfVWmJdP+SELZEBs6ke+3ajOdZXM0nBq+HLw5JxOhVTn/nry7/jmznT7ltwalmttp4kuld2Cqx9uGbC1qL+fHZBcmuyt6ZFo1z6RuBdF31M/UclnK+uSdcHxWbzsEu/vNfRcIQAQ2gufddrbR4HpPBKKkHUvw1JrpKUh3XYLNhpwdxOP8lKNq2c2mzw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=oP54Ot7PWMoy2ZY2U1Ti9Nruaac6CbGjFHOhndATzFY=;
 b=cNkbKXvI/bSNm7xcQJLJvCZauxjQ80H0P8WYiQg4L2EFRVSG1p6gR6UbBbSGhZU65ILZQDO1lIC2CZ89v4ZOwtJ2P7pzgd0MWADlGFofRiUW4B4gBL5v/bxPHBL/O7B/WeW+FIGV+L3JmJslLCwrwJobt7fsxvyeG1/UscDWDa8=
Date: Fri, 25 Feb 2022 09:21:50 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Rahul Singh <rahul.singh@arm.com>, <bertrand.marquis@arm.com>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2 3/3] xen/vpci: msix: move read/write call to MSI-X PBA
 entry to arch file
Message-ID: <YhiRnmgajgeat/fP@Air-de-Roger>
References: <cover.1644937405.git.rahul.singh@arm.com>
 <3e47316052dce3c85bde04ab6b72ba4f48fa0bb8.1644937405.git.rahul.singh@arm.com>
 <c8f54e83-95c9-04aa-d788-da755e284c42@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <c8f54e83-95c9-04aa-d788-da755e284c42@suse.com>
X-ClientProxiedBy: PR3P189CA0071.EURP189.PROD.OUTLOOK.COM
 (2603:10a6:102:b4::16) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b4aa4472-69b8-469a-c221-08d9f837e215
X-MS-TrafficTypeDiagnostic: MN2PR03MB5264:EE_
X-Microsoft-Antispam-PRVS: <MN2PR03MB5264616AFE044B137053568D8F3E9@MN2PR03MB5264.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: FF/zYNVWqDpM9cj5d2j+gIKWKdZMQvmy34yiUFfX8uE5BzTYnO3fiNAYXCIVO5tdi+SbSj4B0gd4zVSp6vfch0zKvndiaSna0MCcuzoxUp6n/88GrvkHYKi4WZ1KNoL03VwStVjM/FUZTrOdu5iPmk3D9oy+1DbH6E4e599SRtzuUUAqfOIButHRFfBmCRtOL+KwbA40MfA/Qp3W4WUhVHragc/cZnk8R+KXoq4Vjyq7IERcf+58+CFawqFg3To19kJTU0iYfIASsxwN3MIsa1aNu22iJBOZuUqwjw3EODq2C0AE30z39xc8xOWso3FDj3pknYJCQ9fycLA0bwqx49gzeIkyUo5rWVGgFmW+twv41bJIq2PY/XEckAEbpCDiZTWvUSp4j7FhIChSOUc8PRYM3/TnKq9xFkj+m2on44CoLQuaMQuyvtu9+R4E9rW92HAH2ddd47Y55zB2P7bZeoozNLCzQXZfvnHolhUpD9Eg8eWw29plRctYke1P08gPWB6xJMgDcFF8SMjI1vXSxyoQk9OVufFkhjKE9S15dYYGBtJN1+WZQ6PcLZGc3LdFZGNcK75eOXY/cSPpJt2XoPLlPl9jxeSB849YnAUuqPZn+waQcjL2aP4zbQxMYm6jrAwCyMR/qg+Q4esvNIowAA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(86362001)(2906002)(8676002)(4326008)(66476007)(66556008)(66946007)(508600001)(6486002)(316002)(53546011)(54906003)(6916009)(82960400001)(38100700002)(9686003)(6666004)(6512007)(6506007)(83380400001)(8936002)(5660300002)(33716001)(26005)(186003)(85182001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eG41Yk1UNGNOMTl2YmtFTGx2bzR5WktWRjE5RzBlSE8rNk1hdGc2d3VUckQz?=
 =?utf-8?B?TVh3K1BHaDB1U1IxTXVPSTMydkpJdmJkZktIdmZFTXByR1p4amZCVGdsK0Iy?=
 =?utf-8?B?dU5uRnF1NVJSbWIxc2VWMUQvNnlmcTA4a3pLQmhvc3VPaGYrVXZqWTVaWTl1?=
 =?utf-8?B?WmpoRWY2WTlkS1FON3BsTlFkd3lZUjZuV0RwMWRqZkszWUNPWStoMDNVYm9j?=
 =?utf-8?B?K01ya2pNMndEbEdKSkQvQzRCYndkSXdDZGxsckFrUVhUaHBnTldCWDAvWFlZ?=
 =?utf-8?B?VUpxZnU4TDdGTjJIRWxxK0QrczV0eEpmdVBOZDBxSEEycXczSjMzc1FUY3p4?=
 =?utf-8?B?dHdsdWZ4SGltNzYzR08vaFpvUERJSmdKaWh3UlR5bEp5VXpvdDhKU2FhV0RI?=
 =?utf-8?B?TDFxRlpvNVVWdmJDUDZQUWF5c09od2pVdGFsaDFoMTRxL0ZwdzNSZXpHZE1m?=
 =?utf-8?B?RVJ2UmlGaXAvdTE1NSs3SWNNTk1hMjNFSmxNVDdKVExUN00vY0ROVHVoR3Js?=
 =?utf-8?B?OERxL1FHN2VwUlJoSFF1V09zenNhMnpINFZ2WnRjR2RiOGhIQktYZ3lPQkVJ?=
 =?utf-8?B?MnNNdWRKcGJkN3B0aXdYYmZOUVlIZjJ0OGUwM0QrZmxJS2xZaTFIazYrcnJ5?=
 =?utf-8?B?RWtoaFVxVnJieTdHS1JXYmJzNVE5R1E5VXdWTG1xNVhZZFFFNHBiRExSWWRI?=
 =?utf-8?B?TjFIdE8xV0U0TWt1Vnp0ZlhMRlp0WGRQTHI5bDVTV00wcTd2MkZaRzhhZmhi?=
 =?utf-8?B?THZuWFZLOFgyaTA0cjluak1YUVg5NW1jaGhwYXUzK1VMSmw1TTBPUjNoRCt4?=
 =?utf-8?B?OHdOKzhGMU14cG8xaXdZTGxkak5aaUxnWlozZG5VWG8zd1hFclhXbTY0eDlT?=
 =?utf-8?B?UzRRUDdhQTZIZDlXd0ZlMXFobHo3QVEyWjZJajBPclJvenlteWlJd213MEhV?=
 =?utf-8?B?WEhOWmkvT1orWTNtTjQrc0FxbjlEdmIyaHZlbnV4YXFGd1NQaGZ2UlpLN0g3?=
 =?utf-8?B?Q1h1MFMrZ2RYdUYzT1Ezc3RGbkpFMk5NVUVtZDFNb01LUUJuSXpzMDc4SGN3?=
 =?utf-8?B?RkZkejNhY0lNTjloTWxNRnhvTlRQbThoczVQUEl0TmY4djl3b0gzaUMyb3Y1?=
 =?utf-8?B?cldjVVFSYzYxRFFoemFZcUtHdnZLd0JNVUY3d3BmOEUyWVpOR2lGd2owQnJ5?=
 =?utf-8?B?d3F3dG9QVFhaYU03bEtQREVESkcwdEtqYnFjOS9JOVp4SG1abUprdHAxQkhu?=
 =?utf-8?B?V1dNTHV0YkxQQVIxZHFocnNFY0J1cU5FS2kyZVlEdEFBQlFIZG5UcllyWGZx?=
 =?utf-8?B?d25rWnpQaE5CeE95VTU2Y081NzFEaXNmVmpNWjdaUm4xZGFTcXgrZFMycmw0?=
 =?utf-8?B?T253c3pQZlhzd2ZvV0lxT0xtWEp5Y1ZpTElLRUxicVFkSWozc1VPR01MSmRW?=
 =?utf-8?B?WnJMYmd4b2tvRTkwU2s2UXhrZHVqYjhEQXhLQmhKU3VoSXFzQXArbks0a0xx?=
 =?utf-8?B?L0tMZm1PamFMU015UFBFcFBtQ0dPZHdHcmtDOVRXSHArMkN0Ujl6V0drZWxm?=
 =?utf-8?B?MHYxZFVyd2FZMEh2MDE0Y0lVTnpQWDBzcVBNWlFDYVhDdVpnVko3aTZhR2pB?=
 =?utf-8?B?V0tlOXgxQzI3OVdFZHI4RE41YXIzRlU1R2diN2kvKzZwZk5aZVd6WlJKOHVz?=
 =?utf-8?B?VUZjMlJsVVlqdkE2cWNFdjYydktXUWhrSDViYlJ5ejF2TTVpa3NuaU1URlF4?=
 =?utf-8?B?QUpab1BJYnUrSE96U3pIREpETmdqVG5ON0habWE3UnBaNk5BdjV2TjFCaFBZ?=
 =?utf-8?B?KytSUHRweWNVYkNJRE1LajZjSjZwR0puN1VaWVNneW9jWkhCNSt0d3lZT3BB?=
 =?utf-8?B?bjNILzJYWWF0ejNaZ2k5K05vSWl4SEZVTktSbHFoTkdreVo5cnN1dngyMHI4?=
 =?utf-8?B?RlBmUWV2ZUJZY3BWWjF5NEEzK2NuWXR1cVRrL3dORFRWVTM0YzFza3VDWHVI?=
 =?utf-8?B?ZnFwU1gwcjBqOFloOVE5Y0srZU1zUmlPeDhlakdaWkszaHZwcWZDWVF3YS9H?=
 =?utf-8?B?TkhrUmZ5SGMwMDVhV2dxR1d2bGpwVG4waXdjTFFsU0s1VFlQMTlzTTE1RFJY?=
 =?utf-8?B?SlV5MlFCaTRyeDJxQnU2SDJEbHkvWkt1U0tJTUpTTUN6WVF3aE9qdngrekxr?=
 =?utf-8?Q?cvK1UTO+Am14+NFPh+MF0CI=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b4aa4472-69b8-469a-c221-08d9f837e215
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2022 08:21:55.2414
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hDrSKP7+rvEhQ+pINw63pL3tn1PDuIL3rpN5zB9O5oJjL/GndKNQIGJ7FGraSZY8S10aLQXe/edz0kuI24EAyg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB5264
X-OriginatorOrg: citrix.com

On Thu, Feb 24, 2022 at 04:18:31PM +0100, Jan Beulich wrote:
> On 15.02.2022 16:25, Rahul Singh wrote:
> > @@ -170,31 +170,7 @@ bool vpci_msix_read(struct vpci_msix *msix, unsigned long addr,
> >          return true;
> >  
> >      if ( VMSIX_ADDR_IN_RANGE(addr, msix->pdev->vpci, VPCI_MSIX_PBA) )
> > -    {
> > -        /*
> > -         * Access to PBA.
> > -         *
> > -         * TODO: note that this relies on having the PBA identity mapped to the
> > -         * guest address space. If this changes the address will need to be
> > -         * translated.
> > -         */
> > -        switch ( len )
> > -        {
> > -        case 4:
> > -            *data = readl(addr);
> > -            break;
> > -
> > -        case 8:
> > -            *data = readq(addr);
> > -            break;
> > -
> > -        default:
> > -            ASSERT_UNREACHABLE();
> > -            break;
> > -        }
> 
> ... in the comment ahead of this switch() (and the assumption is likely
> wrong for DomU).
> 
> But then, Roger: What "identity mapped" is meant here? Surely not GVA ->
> GPA, but rather GPA -> HPA? The address here is a guest physical one,
> but read{l,q}() act on (host) virtual addresses. This would have been
> easier to notice as wrong if read{l,q}() weren't allowing unsigned long
> arguments to be passed to them.

Urg, indeed, thanks for noticing. I will send a patch to fix this
right now.

Roger.


From xen-devel-bounces@lists.xenproject.org Fri Feb 25 08:24:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 08:24:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278808.476192 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNVuA-0001aR-RE; Fri, 25 Feb 2022 08:24:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278808.476192; Fri, 25 Feb 2022 08:24:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNVuA-0001aJ-Ny; Fri, 25 Feb 2022 08:24:46 +0000
Received: by outflank-mailman (input) for mailman id 278808;
 Fri, 25 Feb 2022 08:24:45 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=RDkG=TI=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nNVu9-0001aD-6Y
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 08:24:45 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 624d6b87-9614-11ec-8539-5f4723681683;
 Fri, 25 Feb 2022 09:24:43 +0100 (CET)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2108.outbound.protection.outlook.com [104.47.18.108]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-41-bO_Xvlv8OFCwXQt4o19khQ-1; Fri, 25 Feb 2022 09:24:42 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by HE1PR0401MB2313.eurprd04.prod.outlook.com (2603:10a6:3:22::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.14; Fri, 25 Feb
 2022 08:24:40 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.025; Fri, 25 Feb 2022
 08:24:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 624d6b87-9614-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645777483;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=SYGTJnML6h9d+Pm5Co7dP/w8whbD+gt2kiCOAepd1NU=;
	b=A+L+nLcvJgE+PHXWGBuKIfRshtGIlkyGBatbeUzWt1lcfWw3UYnGXxt0LFgbadU6J9/KTa
	I1Riu7LIty1L18hK+Ba5YPwMZsnoi2EzoWH6RsxQFppuls5BozwdZ1ZZUL92URWcXFxgVh
	NXtspPDbmzZmw+tqAMawCXhKNbb2gE0=
X-MC-Unique: bO_Xvlv8OFCwXQt4o19khQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jXjzgozWzh+RG7m6N+rLxvmkUasypGGTLXeaOFwy4yCZo0VmM70JiC2GgTJRJb5OVMzLCTq8/2buqleJBw5XXXbwAlGTirlGQQZ57X2tMDlCQfuIw/ZoygTn/VLNolYKWce1oP9mryD4JEKP7nU7S9zncPifZOLFDVqOb+XG5BViptc/ic/zb47HKRby3lBs4UTi6sdhY8l5Wr9tzlDpRVVBrk8Dq/6Q8S6aj+w6vln0FZcovGrDxLZKPZtZMFtBp6E0dj/151y2d46+1GxC5J8TNRF9TqlBh6geDzuA01YpFpYST7Dq9JGoo+2lmU+JrI/VRyu8/SJhIlmqNgSLgQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=SYGTJnML6h9d+Pm5Co7dP/w8whbD+gt2kiCOAepd1NU=;
 b=TkI3owUYThu61jDfolHL2yXYdKBcS59rrHS3Hc90LhUn+mUVNTGVfgfKcTQUVj5yMblag2JTtqsuQD5KlXr1EzRhetw2IUxBArHN+oixwvY0fhRLU9iHdMetz6xD6lMaTnzSizAhfq7yCfebym9jdrcTvN5bCyp8cLIlLZHTEKU6bc5pyFdxVOsQG5Uxoopx9YufAee/Py05U4AskA+PTEu/1LUwIHpb0Rm8fuPcFDYp9Aj9QZ+h4wFWyoGHel5yU3paCgZZIzLb1FindrolKtuOjjCkPtBjULE5WWWj9pCkEODlWdZzG4xAl4mc3+5IlqMKRUEqyKySPMm7K26hhw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <e8b71b3a-55a0-31a2-b2ab-3b2470680709@suse.com>
Date: Fri, 25 Feb 2022 09:24:38 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v2.2 8/7] x86/IOMMU: Use altcall, and
 __initconst_cf_clobber
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20220214125632.24563-1-andrew.cooper3@citrix.com>
 <20220222114711.19209-1-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220222114711.19209-1-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0197.eurprd06.prod.outlook.com
 (2603:10a6:20b:45d::13) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 1f017d4a-fc9f-40af-02f8-08d9f83844be
X-MS-TrafficTypeDiagnostic: HE1PR0401MB2313:EE_
X-Microsoft-Antispam-PRVS:
	<HE1PR0401MB2313E9F8476518319AA288F3B33E9@HE1PR0401MB2313.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	xFRjUd/TTLOjNy/JkNQbS3AigAfU/TjijTOzyrNNsEQxlZIeA0h8qsowelR6rl2QgT5ckigPuyzb7vIHJ1SUYiEQUPw8ickbnXYIV4SX+pMOldBtEG9UkGSPMXZRloRgnuqqjs6zV0xIRKfLprg3OfvDT7iII9kWHCuqZ05GYfQuVXzKGQxQD/imkVseGQ3nNTsh8hrAkf0Pu/k2mnZw/VC0fR6SbFrgOVLoSlAVsemBThSf3PDqqLxOu/qZaJSNKYvjsjcsgvGorbv8X286c6L0edG37WHYEfN/6vy5SfoT+CH6grXhei6epIeWXhHPDT7KqI+zPQTbdNUb0mfPF7jnShCEiskIt5akHKfD3R+WmtgfBw7ymL72NglHAbSBoYl2jpjnL4QJioJ3kJq7wDM06BXvduFaKIheVEc3aLk0w9ZXyubOhZJez7LXAsNeJ3YsUo8t6K73uS+Mqa3l4EFAIOce26lk02JD24wnNkIYIjvpJ/ZCY4QUfgrE2SwNq82PCIa9I6Z7Tx6RFVL/wUQwziZrrYPaKRjTkjhxU+6VDjG7FGedb4lfLH23gP+vboEYh70MAnr/9W/VaY30adXNC/Pmil3lHigirQESZuZQmw1MhaF6rnLXHpa4mV23Z8Do/hWHQDMA7fTw1ClfMP1Mai2dvK7aGOwGBeo5rKA+FYHZT/6Jo6PbTC2jJ+9CqzrOjV5Nvh2elpcrjoWUvPJKIf57C4uYufElufrYqJrJbvT2pimZl2hlK0GhuN0L
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(316002)(508600001)(6916009)(36756003)(5660300002)(6486002)(86362001)(31686004)(8936002)(54906003)(31696002)(8676002)(2906002)(26005)(2616005)(38100700002)(53546011)(66946007)(66476007)(4326008)(6512007)(66556008)(186003)(6506007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Q09zcm9Qc2JyWmxUeUM3L2V6eGZjcjJOaTM4aEdYMnRXWHdyaUZxUHJqZzdG?=
 =?utf-8?B?R0NpSFRGY0o0bzVJWXAyU0JlL2hHaUJHOFJrdys2WjM0L1pabFFaR2JvbjIw?=
 =?utf-8?B?ZWtCWVZPMVZoZGdOMUI1OWVuVGthcmVxTmY2bjdNMGlUZ3hyR3J4KzVKc0ln?=
 =?utf-8?B?bGVUYkNoZjNGOWtaSkZUenI5bHFNWjRKMk8zTC9CdmpGd0dxZHd5Rmo4cVU4?=
 =?utf-8?B?bEZqNTlsUEdiRHVUakZCNUt3Nzd0L0o4ZEZCT1g2ejZHMTVLWnZGWXZQNENX?=
 =?utf-8?B?M2dOcnRCSmNvQW55Wi81VHlhVFhBam82dTUzaWhQZkRpREdBUUtnRTF4STNO?=
 =?utf-8?B?YlBrZ3FjV3c2dWliZWdIMW85VVV6NUJTTlVqMGUyakVya0RremRZL1hMbVFE?=
 =?utf-8?B?VDdUWXFhL3ZyMzFPZ0Jxa3EzcjNnVjI0OXZjQzQvcEdVeW9BallMZXkrNitO?=
 =?utf-8?B?azRUdUVOR3JQTE50TDdrc0ZPaFVYQjQvS1o4NzM1Y1RXdXBjbmNQQTZNQUVV?=
 =?utf-8?B?emErRmtOVVlyYnQ4SzJQOE5EamdNMEh6MWk3Mnc3RFk1S0QxMWdxdXBKbTYv?=
 =?utf-8?B?QXFJbTVHQ0hiN0NEUWwvbVpnVURJWm4xVDZ1TE5uTUdjdHRmdVY4SFFoR0xr?=
 =?utf-8?B?cUNMeGZLWGNoZmRyampWZ1Mzd0ZPZkw2OGZBNFdobEhuK3JScTIwREd6NHBE?=
 =?utf-8?B?UThpU0NsMnJicHFCb0JselRpc2Rra2dEMG9HV0ZnL3BFQzFVSFdGOFRxS1Nj?=
 =?utf-8?B?YVVqQU9zaCt0RE1NRnlnL1MzeVBLMFNMbWZsb01Hd1lLcXBhTnBOSk96OEdF?=
 =?utf-8?B?S0ZGYUhwQjE4ekJWU21QdWtqL1preEdqQ0R0Y1JCN0I0eGxISTRTL1NLVHln?=
 =?utf-8?B?blhwTmFlTm1FeFRwNUdKaVFVNWlxUDNvdTcxZDlhc0ZFNHVsVTVEbE5wWWI5?=
 =?utf-8?B?eW5jb0ZvQVl0TzJZN2xTNU00QVJCQUdDbVQrMWc0WFRqRnpIT2Y5SjVEcWFU?=
 =?utf-8?B?eFl0VGt2QWh0MTlhYXNZakRoLzNPTFM5VHlBOFBKTGwrYitZQ2g4OXVjYmZM?=
 =?utf-8?B?amRCaWRWdlJEWDVHb0piQ3h4emxjL2x1c3NSd1p6Z0xFZUJlSFBlRy9PMFJG?=
 =?utf-8?B?bVZjRnJGKzdtWmQwWEJzYnZEclVRSXlsYTNEVnZhOGo5TUlJVFMxNkNYMzVi?=
 =?utf-8?B?S29nRkN2ZTdJWG9PVVByYlBaZ2c3MzNqSTVyWVk1ZmlFNEE4a3pLOGJiZkRL?=
 =?utf-8?B?U2t3ci9rSDM5UlJUeHp0blB2ejl5bHJCYUgycEtQUGRuUGFTdWYwQXRUcEMz?=
 =?utf-8?B?REJ5aDE1c2NaVTl2KzZvYVhQdjBpbGRuMnR0SkhmRmdXcWFtRVcxckx5VFo1?=
 =?utf-8?B?YlBuN2V4YVdUbnNoZ0hwbmo0MGlKWnlnL2EyZ0tjZ0VweGJ6TVdVcWZ3Ymha?=
 =?utf-8?B?Y1gvODV3SGtLeUJNKy8vb2RGVkJ2RExKbzJudDF0NFZhV0FuK201bnJxd1c3?=
 =?utf-8?B?YnZKMVRCbGM4WVpXNnpJVGJVTEcrc0E2SVgzeStLYlJ5OW1kSERHSWVyREFk?=
 =?utf-8?B?UG9vT20yTk9obmd5aXVDdWJwSHRQNlRrL2MwandQMGc4UEJNQUpxNG5JMk5I?=
 =?utf-8?B?dDNaQm51TVNkbzhFbWwzV1VHbldzVVh0SGx4ZlpSTTlIRDNPcFdMSjJna0U5?=
 =?utf-8?B?MEo5cTBoNzFYT09SL3dRaW1xWlhXS0VCLzZRc29XM3Z2UGR1RjFwbktKbllC?=
 =?utf-8?B?Y0F3L2pEY2hjdU1rQjZSZ1JZeURGbTFqdzZrZkliUkcxN1JVaGI5cDVOeW15?=
 =?utf-8?B?UXpFZzlEdlJub2FNcjI5S3ZlYURTOHYrZHZ3d1FNdWduczFMWlg5TmtHZjFQ?=
 =?utf-8?B?UW5GcUpKbWZpOHQyQU1CK3VIUmx0cTl4VGdCMVN2YnRPYldGQXBQYUVCcjg5?=
 =?utf-8?B?dm5SN0RLekM4RVpNRlJYWVc0YjFwSFR2bWFvWVp1SHJwTkNNNUVPTk8rcmxs?=
 =?utf-8?B?eFlVSVNmc3J5YzdjRDFBVzgrbjdEZmhMb3FSa2NhOEZJOFpTc1J6cXlBQVM5?=
 =?utf-8?B?dDU4WWZzWmV0a0JzT2VSSVdiTDZjUHZWa0JLQ2FFeVhBV3FhNmI3bFlZc1BV?=
 =?utf-8?B?Q2JRQm16cFFTajJJTzhza01tRlBqdzZnRmwrYVM3YUxyQmd0UXU4eXpGelRJ?=
 =?utf-8?Q?IuD/bhlfUS54IwonEOwpwu8=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1f017d4a-fc9f-40af-02f8-08d9f83844be
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2022 08:24:40.6358
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CujFPPwuU2rU9+i3nULRy50uy9mMXHsXS7O3Ee+KT0RguP9fMLbPl2MDTGyinV6MStzLxS6LRDbuzSlvopubTg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0401MB2313

On 22.02.2022 12:47, Andrew Cooper wrote:
> --- a/xen/drivers/passthrough/amd/pci_amd_iommu.c
> +++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c
> @@ -628,7 +628,7 @@ static void cf_check amd_dump_page_tables(struct domain *d)
>                                hd->arch.amd.paging_mode, 0, 0);
>  }
>  
> -static const struct iommu_ops __initconstrel _iommu_ops = {
> +static const struct iommu_ops __initconst_cf_clobber _iommu_ops = {

Following my initcall related remark on x86'es time.c I'm afraid I don't
see how this and ...

> @@ -2794,7 +2793,7 @@ static int __init cf_check intel_iommu_quarantine_init(struct domain *d)
>      return rc;
>  }
>  
> -static struct iommu_ops __initdata vtd_ops = {
> +static const struct iommu_ops __initconst_cf_clobber vtd_ops = {

... this actually works. But I guess I must be overlooking something, as
I'm sure that you did test the change.

Both ops structures reference a function, through .adjust_irq_affinities,
which isn't __init but which is used (besides here) for an initcall. With
the ENDBR removed by the time initcalls are run, these should cause #CP.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Feb 25 08:27:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 08:27:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278817.476203 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNVx0-0002Jn-Cb; Fri, 25 Feb 2022 08:27:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278817.476203; Fri, 25 Feb 2022 08:27:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNVx0-0002Jg-9Y; Fri, 25 Feb 2022 08:27:42 +0000
Received: by outflank-mailman (input) for mailman id 278817;
 Fri, 25 Feb 2022 08:27:40 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mSMM=TI=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1nNVwy-0002Ja-Fy
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 08:27:40 +0000
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur02on060e.outbound.protection.outlook.com
 [2a01:111:f400:fe07::60e])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id cae60e8c-9614-11ec-8539-5f4723681683;
 Fri, 25 Feb 2022 09:27:39 +0100 (CET)
Received: from AS9PR0301CA0002.eurprd03.prod.outlook.com
 (2603:10a6:20b:468::15) by DB9PR08MB6412.eurprd08.prod.outlook.com
 (2603:10a6:10:23d::17) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Fri, 25 Feb
 2022 08:27:23 +0000
Received: from AM5EUR03FT038.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:468:cafe::d8) by AS9PR0301CA0002.outlook.office365.com
 (2603:10a6:20b:468::15) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.25 via Frontend
 Transport; Fri, 25 Feb 2022 08:27:23 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT038.mail.protection.outlook.com (10.152.17.118) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5017.22 via Frontend Transport; Fri, 25 Feb 2022 08:27:22 +0000
Received: ("Tessian outbound 1f399c739551:v113");
 Fri, 25 Feb 2022 08:27:22 +0000
Received: from 09506247d506.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 37553FBC-CA8C-4460-A22F-264E714FA6DC.1; 
 Fri, 25 Feb 2022 08:27:16 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 09506247d506.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 25 Feb 2022 08:27:16 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by HE1PR08MB2873.eurprd08.prod.outlook.com (2603:10a6:7:30::10) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Fri, 25 Feb
 2022 08:27:14 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::aca7:79c4:fa65:dac6]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::aca7:79c4:fa65:dac6%5]) with mapi id 15.20.5017.022; Fri, 25 Feb 2022
 08:27:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cae60e8c-9614-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=gkd/1LMAIeDmVlc4RspthIUiwxY6FbLzuBtfbkw98OA=;
 b=HqA5H5WZHfyhR/aCr4R9l6Kvg+5/U77ythwHSeubE1v8QTczUUGaA/YwAY8R9SAT8t6NYA+LF/N7VJCHrD2sofQs07LKTs1HG+oor7CnkMg22cYuiNvvq/pmfUPXvR4WDECHXtiPHL4lKW7kk5xiUBX5MDSxYidV3UHwCERihxQ=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 9ca0ec0f4f462e3a
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=IxIf4QKx0le80i26AsB+XGIi5U3Tj7be3LfHBMMu4N2FwuVrNBzzoglnfMrJYA5NQFXVa2weA/8n0Bij5d2ojh9mwgqg4Lw/VLteShCA2/T3xgDhYe2XJXmxZuxc0VsmmtL8p3FOvoWqW9xD4CBlhO4RcuKyevkDWC3M8qNTrff0ygVgZK3+gzY2DbH7DNWTg1FEKhe9aZg7K8KV4ka5R/sRH4C0jDttHdXKZKmKCJMhzAxo5mJRzSicmN/S4w420Xsu7/7GqkeEcQazfXNcrTHhW9VvaXoKlhDNEiSZcC473SrvoVNxNKQiUrM89krMnRc6RddrmE6LWqGFHq/K+A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=gkd/1LMAIeDmVlc4RspthIUiwxY6FbLzuBtfbkw98OA=;
 b=Llna29zj+CiIIgANgRmzfuOJe2v1yCHBjrgEkVK0jHruN/CNfZsnO9hB0UhllzUM1w71/ha6YsemTNe+1HfJjcjjLxhYn4elZpcte+baEEfKB+5bfPpKYbzHYHTmkgdxK1kRxPNkbhEa3aHTt0tBPPhBRScFUrl8mAb6+l+y0zQrPU5JWAFHWGnaUrITmoAYlEXqy3KrQFqE+3WyFHXbSpc39LL6qMIM043OnhNBshLNUoHIh1FbogErlolha9ndEI6QrmGLOaFEmeQ3XiazSppdjlXGM+HFnOMUA79E+xZYMag8FXYb1yuSkjiJ2InBuTo34Q/aevuql1pKjlKMng==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=gkd/1LMAIeDmVlc4RspthIUiwxY6FbLzuBtfbkw98OA=;
 b=HqA5H5WZHfyhR/aCr4R9l6Kvg+5/U77ythwHSeubE1v8QTczUUGaA/YwAY8R9SAT8t6NYA+LF/N7VJCHrD2sofQs07LKTs1HG+oor7CnkMg22cYuiNvvq/pmfUPXvR4WDECHXtiPHL4lKW7kk5xiUBX5MDSxYidV3UHwCERihxQ=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Julien Grall <julien@xen.org>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Julien
 Grall <jgrall@amazon.com>, Stefano Stabellini <sstabellini@kernel.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v3 03/19] xen/arm: p2m: Replace level_{orders, masks}
 arrays with XEN_PT_LEVEL_{ORDER, MASK}
Thread-Topic: [PATCH v3 03/19] xen/arm: p2m: Replace level_{orders, masks}
 arrays with XEN_PT_LEVEL_{ORDER, MASK}
Thread-Index: AQHYJwz3/5rVW4vmxU2XDig/F0ROyKyfuzqAgAOV+oCAAKOsgA==
Date: Fri, 25 Feb 2022 08:27:14 +0000
Message-ID: <17D9F4AB-0FB1-4827-A564-4EBBDECF977A@arm.com>
References: <20220221102218.33785-1-julien@xen.org>
 <20220221102218.33785-4-julien@xen.org>
 <66B2C3AB-A61C-4CC7-8249-AA925B2774FD@arm.com>
 <7a92b31a-ff09-3263-c25f-aba420adcce3@xen.org>
In-Reply-To: <7a92b31a-ff09-3263-c25f-aba420adcce3@xen.org>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3693.60.0.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: eafc2b5b-f631-4db8-fb86-08d9f838a59d
x-ms-traffictypediagnostic:
	HE1PR08MB2873:EE_|AM5EUR03FT038:EE_|DB9PR08MB6412:EE_
X-Microsoft-Antispam-PRVS:
	<DB9PR08MB6412D747DFA8954550D52F549D3E9@DB9PR08MB6412.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 4270IHDxsOitbZLwpQtRuvok8jmoYo9y9Dv865FZqLClfO0N5jz/5EDyOjNiP/P+AO93Kl5+HOh9vaM/O+HSylK/u9YAypA2Xf7+qO4zkjDa/eHzd1Zkb+xIsKrYXcAps5+2hULXwgT00w7pmIo0+fCUda6j+zM5987Epo9ed/f+z4L7A1w6oWjfxtnqhCLrrZSQ8DokQ0irRJVfji3m0nbypzScNhdQghxqPU5EHdIVnEBWQkaAe3IjDF27CbTwRq77WrvISioIrH54MCZVJIhGbcQgfj4k1W4JKlx3c0NA2vnIs4YsVt+zpv5WobhEZPVSITiFqjwAGDC2hoF6lSCCM+/ZgE7oZnBEHPiHJgrRmzu4pd6KDtW+4m2ME0qxNgPZJqhsZVS4l8NAxGh0wvNtbRcQxbZ2kNKmc468u5IuP+nLJcZDGJVNmokrAoB6U+KOtMP8X/b3TPvo/N6yrcIXFfSQaXjeYMv2YLntsIJ9YUGfUo+cnbTPH108z00wH0vDTu6CeIptjNLEUEiXa0tbQ1QQGJerlwYoFE4ElQp1boYssHiFoCbTSU1hf6bpVQ0yLx7WF9RPL80eDuu2dYbWovWnVqtNCieiPgfU5x0ZswN3/jIXyMLJCQbi7P9ouJZhRX0//7PMf/DGjsg/GVYN11wK1YwpV2CXlMK/e3rnkwui/y76yYe+A/RlaUSYLJPWyGr/1+qgJjIs7n4oJ/Cpma/DdmBamXxzZVGDJiJghDeWN752RxQ2G5+z10k2
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(2616005)(6506007)(122000001)(53546011)(86362001)(6512007)(186003)(26005)(38100700002)(71200400001)(83380400001)(66446008)(6486002)(36756003)(8936002)(5660300002)(76116006)(316002)(33656002)(38070700005)(91956017)(2906002)(54906003)(66476007)(66946007)(8676002)(64756008)(508600001)(4326008)(6916009)(66556008)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <B8E4D97F09018E4B822501F5EF725362@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR08MB2873
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT038.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	83ee994d-a96d-4d9a-e848-08d9f838a08a
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	2YDC/LnFLSmTP49PtvYIAhU532YhoFgXQ4957wND/5GaOfW8AX5IiG1RH/AxA7cfCsxEOlFdMwL52KIp3kpqLUnSWLpRtrPeibxfC3dY+XENbaGH542qNN6tdTbXyOKku6ZJtzTqCSMlVl6Nim45Lo7sFixFHcjSCtduAcFuBANk9QJ2m96dN9owe01ACAaE+1nhknz12UY18DzU3Hi4DE6cJG7eCmhr4tMJAifHu3HhbmHlrTSoIal48xoVtdyHwTzDQyvedbCX2JtqAQwqKJAz3cqOeL3xV4PVnRSoXfq6kRV24D4Vf+BLDXcpsbyj18yWmyPN6n0xI0lqOCsn5De3M6+JU4/0mLOUiS6JrpJ1i0FI9B9eKvZtVFyRO5NfPgiUOmrkwVDmFsM9LXCDs5jUfQWsJbm+tS5VnFiwZR8G8H2u4uG5Uo+hk+pFIZGap+iDhTaSKknQntrTgpRYTC6+zjiSfogZt0pH0WwN17idaR3dGPElEImyXO1MOfGEepjxyRFlqVge+w+52MSKn9Kce04jizAlAVpVLGxBdCAziuRHE1/HDk3SWqee2M8B/pkIGEWQ6OXe2zpK0lGGDOJ3Ut7YYfkv47k868TIVKgeaG2wClY9jxeAaXJRLj+WouNAmkFj/UW88HvAujygVZiLQZ0gGb83WD4V9uLuucMeOuHsoWyu79W+CBiJRevt
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(53546011)(508600001)(6506007)(336012)(54906003)(8936002)(33656002)(86362001)(2906002)(6512007)(70586007)(8676002)(70206006)(316002)(4326008)(6862004)(5660300002)(6486002)(82310400004)(47076005)(83380400001)(26005)(186003)(107886003)(36860700001)(36756003)(356005)(81166007)(40460700003)(2616005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2022 08:27:22.9462
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: eafc2b5b-f631-4db8-fb86-08d9f838a59d
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT038.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6412

Hi Julien,

> On 24 Feb 2022, at 22:41, Julien Grall <julien@xen.org> wrote:
>=20
>=20
>=20
> On 22/02/2022 15:55, Bertrand Marquis wrote:
>> Hi Julien,
>=20
> Hi Bertrand,
>=20
>>> On 21 Feb 2022, at 10:22, Julien Grall <julien@xen.org> wrote:
>>>=20
>>> From: Julien Grall <jgrall@amazon.com>
>>>=20
>>> The array level_orders and level_masks can be replaced with the
>>> recently introduced macros LEVEL_ORDER and LEVEL_MASK.
>>>=20
>>> Signed-off-by: Julien Grall <jgrall@amazon.com>
>> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
>> One open question: At this stage the convenience aliases that you
>> kept in include/asm/lpae.h are used in a very limited number of places.
>=20
> I am not sure I would call it very limited:
>=20
> 42sh> ack "(FIRST|SECOND|THIRD)_(ORDER|SHIFT|MASK)" | wc -l
> 65
>=20
> That's including the 9 definitions.

My bad I looked with your full serie in my tree.

>=20
>> Could we remove those and use only XEN_PT_LEVEL_* to make the
>> code a bit more coherent.
>=20
> I made an attempt in the past and it resulted to longer line in assembly.=
 So I am on the fence to whether the aliases should be completely removed.
>=20
> At the same time, XEN_PT_LEVEL(...) is handy for places where we don't kn=
ow at compile time the level.

One other big argument for making the switch is that XEN_PT_LEVEL is far mo=
re specific then FIRST_ORDER and others which are very unspecific names.

Anyway definitely something that we could do after your serie.

Cheers
Bertrand

>=20
> Cheers,
>=20
> --=20
> Julien Grall



From xen-devel-bounces@lists.xenproject.org Fri Feb 25 08:36:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 08:36:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278824.476214 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNW5v-0003nr-AF; Fri, 25 Feb 2022 08:36:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278824.476214; Fri, 25 Feb 2022 08:36:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNW5v-0003nk-6r; Fri, 25 Feb 2022 08:36:55 +0000
Received: by outflank-mailman (input) for mailman id 278824;
 Fri, 25 Feb 2022 08:36:54 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=d3I2=TI=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nNW5t-0003ne-T7
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 08:36:53 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 148bcace-9616-11ec-8eb8-a37418f5ba1a;
 Fri, 25 Feb 2022 09:36:52 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 4B1EC212BF;
 Fri, 25 Feb 2022 08:36:52 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0B0CB13B65;
 Fri, 25 Feb 2022 08:36:52 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id N1FSASSVGGKoPgAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 25 Feb 2022 08:36:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 148bcace-9616-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1645778212; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=kbee77WNyNUjc5zQbhgYW4K+2VGvOEyP/lNyCctJvZ8=;
	b=t+wfr+SjreykOXdOhZ/8yIpwiZGnMyJ/Ao7WZu5rYvEMyybCp11tAx+gFh6igdNReRzZGr
	JXJ0ZZQ8ztqsSRonbPZq8U4CSZ79npZahqynhZwJzdB5m+Kkg8VrRA0uNbz3kxvEW+B69S
	pBW8l4cQQ6/HdGMm5T4UYV5krxnqwDw=
Message-ID: <05a26a5d-8597-84c6-171c-2751987b7836@suse.com>
Date: Fri, 25 Feb 2022 09:36:51 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH 2/2] xen/spinlock: merge recurse_cpu and debug.cpu fields
 in struct spinlock
Content-Language: en-US
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, xen-devel@lists.xenproject.org
References: <20220224105436.1480-1-jgross@suse.com>
 <20220224105436.1480-3-jgross@suse.com>
 <15e71984-37db-c6c2-5feb-05c8f1ad85f7@suse.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <15e71984-37db-c6c2-5feb-05c8f1ad85f7@suse.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------cOSq3T0ls92hfBkNd1U9gNz0"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------cOSq3T0ls92hfBkNd1U9gNz0
Content-Type: multipart/mixed; boundary="------------CPqfh8fPfecjEIYNluIGKQUw";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, xen-devel@lists.xenproject.org
Message-ID: <05a26a5d-8597-84c6-171c-2751987b7836@suse.com>
Subject: Re: [PATCH 2/2] xen/spinlock: merge recurse_cpu and debug.cpu fields
 in struct spinlock
References: <20220224105436.1480-1-jgross@suse.com>
 <20220224105436.1480-3-jgross@suse.com>
 <15e71984-37db-c6c2-5feb-05c8f1ad85f7@suse.com>
In-Reply-To: <15e71984-37db-c6c2-5feb-05c8f1ad85f7@suse.com>

--------------CPqfh8fPfecjEIYNluIGKQUw
Content-Type: multipart/mixed; boundary="------------4IqAYmWzR6QhgnrSvdMat2C6"

--------------4IqAYmWzR6QhgnrSvdMat2C6
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMjQuMDIuMjIgMTc6MTEsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAyNC4wMi4yMDIy
IDExOjU0LCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gLS0tIGEveGVuL2FyY2gveDg2L21t
L21tLWxvY2tzLmgNCj4+ICsrKyBiL3hlbi9hcmNoL3g4Ni9tbS9tbS1sb2Nrcy5oDQo+PiBA
QCAtNDIsNyArNDIsNyBAQCBzdGF0aWMgaW5saW5lIHZvaWQgbW1fbG9ja19pbml0KG1tX2xv
Y2tfdCAqbCkNCj4+ICAgDQo+PiAgIHN0YXRpYyBpbmxpbmUgYm9vbCBtbV9sb2NrZWRfYnlf
bWUoY29uc3QgbW1fbG9ja190ICpsKQ0KPj4gICB7DQo+PiAtICAgIHJldHVybiAobC0+bG9j
ay5yZWN1cnNlX2NwdSA9PSBjdXJyZW50LT5wcm9jZXNzb3IpOw0KPj4gKyAgICByZXR1cm4g
KGwtPmxvY2suZGF0YS5jcHUgPT0gY3VycmVudC0+cHJvY2Vzc29yKTsNCj4+ICAgfQ0KPiAN
Cj4gSSBzZWUgYSBmYWlyIHJpc2sgd2l0aCB0aGlzOiBCZWhhdmlvciB3aWxsIG5vdyBkaWZm
ZXIgYmV0d2VlbiBkZWJ1ZyBhbmQNCj4gbm9uLWRlYnVnIGJ1aWxkcy4gRS5nLiBhIGxpdmVs
b2NrIGJlY2F1c2Ugb2YgdHJ5aW5nIHRvIGFjcXVpcmUgdGhlIHNhbWUNCj4gbG9jayBhZ2Fp
biB3b3VsZCBub3QgYmUgbm90aWNlZCBpbiBhIGRlYnVnIGJ1aWxkIGlmIHRoZSBhY3F1aXJl
IGlzDQo+IGNvbmRpdGlvbmFsIHVwb24gdGhpcyBmdW5jdGlvbidzIHJldHVybiB2YWx1ZS4g
SSB0aGluayB0aGlzIGlzIHRoZSBtYWluDQo+IHJlYXNvbiBiZWhpbmQgaGF2aW5nIHR3byBz
ZXBhcmF0ZSBmaWVsZCwgZGVzcGl0ZSB0aGUgYXBwYXJlbnQgcmVkdW5kYW5jeS4NCg0KWW91
IGFyZSBhd2FyZSB0aGF0IG1tX2xvY2tlZF9ieV9tZSgpIGlzIHVzZWQgZm9yIHJlY3Vyc2l2
ZSBzcGlubG9ja3MNCm9ubHk/DQoNCj4gDQo+IE5ldmVydGhlbGVzcyBhIGZldyBtb3JlIGNv
bW1lbnRzIGluIGNhc2UgSSdtIG1pc3Npbmcgc29tZXRoaW5nLg0KPiANCj4+IEBAIC04MSwx
OSArNzksMTkgQEAgc3RhdGljIHZvaWQgY2hlY2tfYmFycmllcihzcGlubG9ja190ICpsb2Nr
KQ0KPj4gICAgICAgICogSG93ZXZlciwgaWYgd2Ugc3BpbiBvbiBhbiBJUlEtdW5zYWZlIGxv
Y2sgd2l0aCBJUlFzIGRpc2FibGVkIHRoZW4gdGhhdA0KPj4gICAgICAgICogaXMgY2xlYXJs
eSB3cm9uZywgZm9yIHRoZSBzYW1lIHJlYXNvbiBvdXRsaW5lZCBpbiBjaGVja19sb2NrKCkg
YWJvdmUuDQo+PiAgICAgICAgKi8NCj4+IC0gICAgQlVHX09OKCFsb2NhbF9pcnFfaXNfZW5h
YmxlZCgpICYmICFsb2NrLT5kZWJ1Zy5pcnFfc2FmZSk7DQo+PiArICAgIEJVR19PTighbG9j
YWxfaXJxX2lzX2VuYWJsZWQoKSAmJiAhbG9jay0+ZGF0YS5pcnFfc2FmZSk7DQo+PiAgIH0N
Cj4+ICAgDQo+PiAgIHN0YXRpYyB2b2lkIGdvdF9sb2NrKHNwaW5sb2NrX3QgKmxvY2spDQo+
PiAgIHsNCj4+IC0gICAgbG9jay0+ZGVidWcuY3B1ID0gc21wX3Byb2Nlc3Nvcl9pZCgpOw0K
Pj4gKyAgICBsb2NrLT5kYXRhLmNwdSA9IHNtcF9wcm9jZXNzb3JfaWQoKTsNCj4gDQo+IFRo
aXMgYXNzaWdubWVudCBicmVha3MgLi4uDQo+IA0KPj4gQEAgLTIzMCw5ICsyMjgsOSBAQCBp
bnQgX3NwaW5faXNfbG9ja2VkKHNwaW5sb2NrX3QgKmxvY2spDQo+PiAgICAgICAgKiAiZmFs
c2UiIGhlcmUsIG1ha2luZyB0aGlzIGZ1bmN0aW9uIHN1aXRhYmxlIG9ubHkgZm9yIHVzZSBp
bg0KPj4gICAgICAgICogQVNTRVJUKClzIGFuZCBhbGlrZS4NCj4+ICAgICAgICAqLw0KPj4g
LSAgICByZXR1cm4gbG9jay0+cmVjdXJzZV9jcHUgPT0gU1BJTkxPQ0tfTk9fQ1BVDQo+PiAr
ICAgIHJldHVybiBsb2NrLT5kYXRhLmNwdSA9PSBTUElOTE9DS19OT19DUFUNCj4gDQo+IC4u
LiB0aGUgdXNlIG9mIHRoaXMgZmllbGQgdG8gZGlzdGluZ3Vpc2ggcmVjdXJzaXZlbHkgbG9j
a2VkIGxvY2tzDQo+IGZyb20gInNpbXBsZSIgb25lcy4gQXQgdGhlIHZlcnkgbGVhc3QgdGhl
IGNvbW1lbnQgbmVlZHMgdXBkYXRpbmcsDQo+IGJ1dCAuLi4NCj4gDQo+PiAgICAgICAgICAg
ICAgPyBsb2NrLT50aWNrZXRzLmhlYWQgIT0gbG9jay0+dGlja2V0cy50YWlsDQo+IA0KPiAu
Li4gaW4gaG93IGZhciB0aGlzIGlzIHN0aWxsIGEgc2Vuc2libGUgY2hlY2sgaW4gZGVidWcg
YnVpbGRzIGlzDQo+IGFsc28gcXVlc3Rpb25hYmxlLiBUaGUgZWZmZWN0IGhlcmUgY2VydGFp
bmx5IGFsc28gZGVzZXJ2ZXMgcG9pbnRpbmcNCj4gb3V0IGluIHRoZSBkZXNjcmlwdGlvbi4N
Cg0KT2theSwgd2lsbCBhZGQgc29tZXRoaW5nLg0KDQo+IA0KPj4gLSAgICAgICAgICAgOiBs
b2NrLT5yZWN1cnNlX2NwdSA9PSBzbXBfcHJvY2Vzc29yX2lkKCk7DQo+PiArICAgICAgICAg
ICA6IGxvY2stPmRhdGEuY3B1ID09IHNtcF9wcm9jZXNzb3JfaWQoKTsNCj4+ICAgfQ0KPj4g
ICANCj4+ICAgaW50IF9zcGluX3RyeWxvY2soc3BpbmxvY2tfdCAqbG9jaykNCj4+IEBAIC0y
OTYsMjIgKzI5NCwyNCBAQCBpbnQgX3NwaW5fdHJ5bG9ja19yZWN1cnNpdmUoc3BpbmxvY2tf
dCAqbG9jaykNCj4+ICAgew0KPj4gICAgICAgdW5zaWduZWQgaW50IGNwdSA9IHNtcF9wcm9j
ZXNzb3JfaWQoKTsNCj4+ICAgDQo+PiAtICAgIC8qIERvbid0IGFsbG93IG92ZXJmbG93IG9m
IHJlY3Vyc2VfY3B1IGZpZWxkLiAqLw0KPj4gKyAgICAvKiBEb24ndCBhbGxvdyBvdmVyZmxv
dyBvZiBjcHUgZmllbGQuICovDQo+PiAgICAgICBCVUlMRF9CVUdfT04oTlJfQ1BVUyA+IFNQ
SU5MT0NLX05PX0NQVSk7DQo+PiAgICAgICBCVUlMRF9CVUdfT04oU1BJTkxPQ0tfUkVDVVJT
RV9CSVRTIDwgMyk7DQo+PiAgIA0KPj4gICAgICAgY2hlY2tfbG9jayhsb2NrLCB0cnVlKTsN
Cj4+ICAgDQo+PiAtICAgIGlmICggbGlrZWx5KGxvY2stPnJlY3Vyc2VfY3B1ICE9IGNwdSkg
KQ0KPj4gKyAgICBpZiAoIGxpa2VseShsb2NrLT5kYXRhLmNwdSAhPSBjcHUpICkNCj4+ICAg
ICAgIHsNCj4+ICAgICAgICAgICBpZiAoICFzcGluX3RyeWxvY2sobG9jaykgKQ0KPj4gICAg
ICAgICAgICAgICByZXR1cm4gMDsNCj4+IC0gICAgICAgIGxvY2stPnJlY3Vyc2VfY3B1ID0g
Y3B1Ow0KPj4gKyNpZm5kZWYgQ09ORklHX0RFQlVHX0xPQ0tTDQo+PiArICAgICAgICBsb2Nr
LT5kYXRhLmNwdSA9IGNwdTsNCj4+ICsjZW5kaWYNCj4gDQo+IE1heWJlIHdvcnRoIGFuIEFT
U0VSVCgpIGluIHRoZSAjZWxzZSBjYXNlIChhbmQgZWxzZXdoZXJlIGFzIGFwcGxpY2FibGUp
Pw0KDQpPa2F5Lg0KDQo+IA0KPj4gLS0tIGEveGVuL2luY2x1ZGUveGVuL3NwaW5sb2NrLmgN
Cj4+ICsrKyBiL3hlbi9pbmNsdWRlL3hlbi9zcGlubG9jay5oDQo+PiBAQCAtNiwyNiArNiwz
NCBAQA0KPj4gICAjaW5jbHVkZSA8YXNtL3NwaW5sb2NrLmg+DQo+PiAgICNpbmNsdWRlIDxh
c20vdHlwZXMuaD4NCj4+ICAgDQo+PiAtI2RlZmluZSBTUElOTE9DS19DUFVfQklUUyAgMTIN
Cj4+ICsjZGVmaW5lIFNQSU5MT0NLX0NQVV9CSVRTICAgICAgMTINCj4+ICsjZGVmaW5lIFNQ
SU5MT0NLX05PX0NQVSAgICAgICAgKCgxdSA8PCBTUElOTE9DS19DUFVfQklUUykgLSAxKQ0K
Pj4gKyNkZWZpbmUgU1BJTkxPQ0tfUkVDVVJTRV9CSVRTICAoMTYgLSBTUElOTE9DS19DUFVf
QklUUykNCj4+ICsjZGVmaW5lIFNQSU5MT0NLX01BWF9SRUNVUlNFICAgKCgxdSA8PCBTUElO
TE9DS19SRUNVUlNFX0JJVFMpIC0gMSkNCj4+ICsjZGVmaW5lIFNQSU5MT0NLX1BBRF9CSVRT
ICAgICAgKDMwIC0gU1BJTkxPQ0tfQ1BVX0JJVFMgLSBTUElOTE9DS19SRUNVUlNFX0JJVFMp
DQo+PiAgIA0KPj4gLSNpZmRlZiBDT05GSUdfREVCVUdfTE9DS1MNCj4+IC11bmlvbiBsb2Nr
X2RlYnVnIHsNCj4+IC0gICAgdWludDE2X3QgdmFsOw0KPj4gLSNkZWZpbmUgTE9DS19ERUJV
R19JTklUVkFMIDB4ZmZmZg0KPj4gK3R5cGVkZWYgdW5pb24gew0KPj4gKyAgICB1MzIgdmFs
Ow0KPj4gICAgICAgc3RydWN0IHsNCj4+IC0gICAgICAgIHVpbnQxNl90IGNwdTpTUElOTE9D
S19DUFVfQklUUzsNCj4+IC0jZGVmaW5lIExPQ0tfREVCVUdfUEFEX0JJVFMgKDE0IC0gU1BJ
TkxPQ0tfQ1BVX0JJVFMpDQo+PiAtICAgICAgICB1aW50MTZfdCA6TE9DS19ERUJVR19QQURf
QklUUzsNCj4+ICsgICAgICAgIHUzMiBjcHU6U1BJTkxPQ0tfQ1BVX0JJVFM7DQo+PiArICAg
ICAgICB1MzIgcmVjdXJzZV9jbnQ6U1BJTkxPQ0tfUkVDVVJTRV9CSVRTOw0KPj4gKyAgICAg
ICAgdTMyIHBhZDpTUElOTE9DS19QQURfQklUUzsNCj4+ICsjaWZkZWYgQ09ORklHX0RFQlVH
X0xPQ0tTDQo+PiAgICAgICAgICAgYm9vbCBpcnFfc2FmZToxOw0KPj4gICAgICAgICAgIGJv
b2wgdW5zZWVuOjE7DQo+PiArI2RlZmluZSBTUElOTE9DS19ERUJVR19JTklUVkFMIDB4YzAw
MDAwMDANCj4+ICsjZWxzZQ0KPj4gKyAgICAgICAgdTMyIGRlYnVnX3BhZDoyOw0KPiANCj4g
UHJpb3IgdG8geW91ciBjaGFuZ2Ugd2UgaGFkIHR3byB3ZWxsLWZvcm1lZCB1aW50MTZfdC4g
WW91IHJlcGxhY2UgdGhlbSBieQ0KPiBmaXZlIG5ldyBpbnN0YW5jZXMgb2YgdGhlIGJlaW5n
LXBoYXNlZC1vdXQgdTMyPw0KDQpPaCwgc29ycnkuIFdpbGwgY2hhbmdlIHRvIHVpbnQzMl90
Lg0KDQo+IEFsc28gLSBkbyB0aGUgdHdvIHBhZGRpbmcgZmllbGRzIHJlYWxseSBuZWVkIG5h
bWVzPw0KDQpJJ20gZmluZSB0byBkcm9wIHRoZW0uDQoNCg0KSnVlcmdlbg0KDQo=
--------------4IqAYmWzR6QhgnrSvdMat2C6
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------4IqAYmWzR6QhgnrSvdMat2C6--

--------------CPqfh8fPfecjEIYNluIGKQUw--

--------------cOSq3T0ls92hfBkNd1U9gNz0
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmIYlSMFAwAAAAAACgkQsN6d1ii/Ey8D
8Af7BlkJY/YSRhA/rtn1HNE1/pzdQopBKl4cBwBHICOQ7TuPQox+ulLSPALr16ZprispmzVTmbHz
iIQwIH3mrYxzyqTCKhlzkhrYKP0EtjfOahufDqJhq0Lvc9OlrSy1hN0bIFJ0pP5F5nXDzWgTRx/7
82DsZ4JPGk7OaNyLW+h/LbT2hzTydAjV491qeGaPNtrfc2BLQV/kPDpYnSjiDpvU9SfvT1MLQs1l
J58fk2y80XEkdAkyTPoNhTbd0Inhp2csMnjti9kNLypwewVEju/1tEEbOpt9yZ9mzmmVp8pJMFBl
RtjUOM7fXVd9Cz+ZstWOo0kIzWCe+2QESnG0weRMgA==
=jeh1
-----END PGP SIGNATURE-----

--------------cOSq3T0ls92hfBkNd1U9gNz0--


From xen-devel-bounces@lists.xenproject.org Fri Feb 25 08:38:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 08:38:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278830.476224 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNW7A-0004N7-K0; Fri, 25 Feb 2022 08:38:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278830.476224; Fri, 25 Feb 2022 08:38:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNW7A-0004N0-H9; Fri, 25 Feb 2022 08:38:12 +0000
Received: by outflank-mailman (input) for mailman id 278830;
 Fri, 25 Feb 2022 08:38:11 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=RDkG=TI=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nNW79-0004Mq-7E
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 08:38:11 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 42b5cba7-9616-11ec-8eb8-a37418f5ba1a;
 Fri, 25 Feb 2022 09:38:09 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2177.outbound.protection.outlook.com [104.47.17.177]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-12-BZlVEax-MNK9UtqbI8IkKw-1; Fri, 25 Feb 2022 09:38:08 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DB7PR04MB4202.eurprd04.prod.outlook.com (2603:10a6:5:25::33) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.25; Fri, 25 Feb
 2022 08:38:06 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.025; Fri, 25 Feb 2022
 08:38:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 42b5cba7-9616-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645778289;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=rKVDFPLFqEZvyu4womEk2iWR1POD6f2mdPiDd8hAyk8=;
	b=G7kIGxNzn16EeM1SixsfQXdy3R9fLAx+weoE6kheW+AWNsTZ+FW9liVmHVdVVW3gCN9r/W
	AP14Zi9vAw5XsmeJtPDxiXTK1bP5U34ESTKN3MWFrE9sYagEyf8vdFqk4BwIO+mxnDpnYb
	h9ttINPFDhiAx21sD8WxlpPjnCsFhGA=
X-MC-Unique: BZlVEax-MNK9UtqbI8IkKw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=IDbI2rTXuwk+/k2kMnqek0+rF3HBz7z+W+V8C++sZlUasoyR6FadAnRBZScC78pj5mPwTzgqYukeLldkLZtHh49t7uupFCnQM+pMVFSuBhe1s6bKsvfHLPa5yDMqSv/Z5xv6++18vRB1JOP+sORwpn3sNbYpDpV+R3n8CuRz15DgJPqvUwU9w9QVJb0hcES0HpIIEA+AF0dXcBsISrw1hbvoyi7+8cv9lYyEr2XVCbWiTyi5Icj96IQtJvmOpaTX3yXWRf0S5G2gDCQQS8mvcz2hit2haDFX6B9xvQmOSHu3kERYGnShj6qb25k+msHY5fmCRiyxsJ2RPZ6r3R8DvA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=pdk83KMn+1VFA3mDD5VKw0kBIVuWYUxHw0+Umf7uJoE=;
 b=cUhiKb3SmlXqeFggxUmzjkZQHAb8g6eMC8wbWH6gOziZUlOevccrCnfySAmIbM0WzuX9+N/ow2Iu/8cBEbAx8MGDl/ukzvCkFWy1aL9UT6VCnYHushEx+AjottebOmoKM3jRPc/aY1er1ytTfgWjhpsKnNK6Y85HM7zePN+Sz4gvqQNNYp5m3mLxvRYo1BDwspCimMQhX9LSgB13EAIrlFHoUfT/vvvI1MSO+tRgcOQ8G2o1AX8uKaYdFxNfhPful2AtbJjwrBE0siuFV0scd0DDoZKNVDrhD5jtGIEPNYmwx2LvccZunMrIDUfQvkhaVHbjfVCBMEk+8z+gLFBbEA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <9b1f517f-eb4d-ddc7-b957-4f0354ee2b9d@suse.com>
Date: Fri, 25 Feb 2022 09:38:04 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: x86/CET: Fix S3 resume with shadow stacks active
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
CC: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Thiner Logoer <logoerthiner1@163.com>,
 =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20220224194853.17774-1-andrew.cooper3@citrix.com>
 <20220224194853.17774-2-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220224194853.17774-2-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6P193CA0047.EURP193.PROD.OUTLOOK.COM
 (2603:10a6:209:8e::24) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 203f972e-d323-4e2f-5073-08d9f83a24b7
X-MS-TrafficTypeDiagnostic: DB7PR04MB4202:EE_
X-Microsoft-Antispam-PRVS:
	<DB7PR04MB42028F0ED046670300D5FF8AB33E9@DB7PR04MB4202.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	24TPUQftipONlSGkM5/QOKAcf8bBCu6ItLjMQpHOuIMi6DjvllYRZbONEfHZy2ZvaajRjNNDkrmqUNkr7qcdEvYvPp1vP016tmaQbLCE6UOXg8T9DhZhua+/raxZD55AdL9qc0OEezyVEeht+c/cTc7UCwE4BP2SJjII9zprk3Fmoj8kdaqJkWJJScyFgA6Pcxd4Xw9mNNDyTM3eS4rZ1Zmom2CrUjqjDshHpZkj/iOEkeM5yYnsmG2oK48H5lQZM38iz3yb2YALSyZQc0fU/gJFwbQQtewpNeNP/1qsulqhoLRKhznmNkZMtkNiqCzRVDWZ4PtdAS7KqNu2yHV0vV3ukZ/5nYX5VaMw423rv7ovm/HPYu1hxV8D/zBHfcCIYrVJUGfH7TZzQzaO6UP6+WoD7KVON3E04/6cMRAiNkKJEFFpIUBXld/xWFzjA14Zd2/nIhwMeS/Vwu19mWkEjFerrYP99LrTiSDhMzJvRvFIENw1lGOyxGLwByiZ4dhdZi2mxNjd8hELXUKf5qwm1ARpTYOi2ktDHDqEv7O+eVds8FfSQsh1aVcVzlKAJNzzYlc1bCWHlEtaF6YqVtDfXORqenQunglZCIlqAlrktHnOFwgNkH7UwJm0HBs7Nq4euLnu+buxXWJdo3K/n8JHCxev5eJ19xA/06BApeKzYUbUivg9HMT736ZyObbOoknjLya1TNSzM4hwQxnEpelb69rQqjCTuRfsEuhoaiUAJlLjeeeciCQam9SLb/BM2qHj/O25UAXkyrA/Cl6CdhYPwXATFqpm8yDGf+VsZ7ylAcE6FJxqjt3RYK6zyTlDcr3Ci1m6cb5jv+uYPMn7mJYOEg==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6512007)(6506007)(53546011)(66574015)(31696002)(2616005)(86362001)(186003)(26005)(83380400001)(38100700002)(8936002)(5660300002)(4326008)(8676002)(66946007)(31686004)(66476007)(66556008)(2906002)(36756003)(6916009)(508600001)(54906003)(6486002)(966005)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?cszg9U1CDAenV7BMsrK0qxHneLnjRq/WktfZ3ppvjdaQHarFVtYmZ7UcjWjG?=
 =?us-ascii?Q?yDOoo41kz7cql/6Oy232Lo0UM68yDGiM2dRio/GvFUfl43oG04iWXtqdnQPp?=
 =?us-ascii?Q?Jca5gSD1SIy4kusqJ3hGg+YeMasGAlP727z1/iZ621tnot5HOuG6RFFLDabp?=
 =?us-ascii?Q?UrPXGP30iZFwfgSrv9Jy/Y7/45VqbSRerURjtLyyz7yA9QZzO0fBru2yN73o?=
 =?us-ascii?Q?rpAHdzXunygpKvr9UxCQLvwb23S0b4Yg1QNpJy/VZFzhjXx7UKW/HGGfJpDW?=
 =?us-ascii?Q?HP42Th/lih2Kfj0aMT4FRsIQeyyVX4dQgEYnjibYb+L8y/2Di+dJoXr2Y01b?=
 =?us-ascii?Q?mCmdb6jFyKhmTYCYg4bdK/yXHpMokQ8qhKWtM/0/Vxu76TyiFhVnP1lkWgGf?=
 =?us-ascii?Q?1L0EKot/pQ0115rT8VPpCZDoYvm3hNQmSMwa7tTsAkYwHNVpl6HiLRpbcW9s?=
 =?us-ascii?Q?v6wXuszKqbiqu82wPe59BZQtFNrcqJWymu3TddTyXjS9OzwY4+9x68T58bEP?=
 =?us-ascii?Q?TQAg7e/qBK5UiFJ+B9OOVDOV4rlJoghSFSmxPX+WuhTz00n7fVeACFQq+Yr6?=
 =?us-ascii?Q?qG1Crj3IbPKxi/UL+D/DRgGIRGveIKRwO/Gs0e6L7NwpFIjhsfaCcB95inkS?=
 =?us-ascii?Q?+Xl8H3MK/7fU4ytAXPlkXlN7pr3WVF4YEvFEbGs4Bd4UedwAemqJwi7uj0Ir?=
 =?us-ascii?Q?Xn9DLEyHkZ/xKl2yGUV04iS8zAps7aWCH1pmX43/jxJFrjS41LwycfqHYg4l?=
 =?us-ascii?Q?51B74QO6cKLIjLfE4k94MauFbqSyPeDjNCOga2PYssRY8VAniqMZ4D/vDk+Z?=
 =?us-ascii?Q?qOpV0z5/3Nm7fRtuXw1M/wSqrghLgF7Z9RNA+AJPbRrC+SqwCKySh9jVdhHw?=
 =?us-ascii?Q?Fk5YIwKSs9MAYaR9s1r8Y43OpXOog/JG388FTclvMqMrk5stALjXBUpXODs4?=
 =?us-ascii?Q?hxLJRm4uKilTK9zBrMjPlW10a3Kbrj4NBckfOcuGTkFX9qsP8UdrZFSEdast?=
 =?us-ascii?Q?CGxJeFj7hBQyEPlB2jj3c56KJJHuo9y60e6xDIzdEQ/ARi5ixtL+RIT4tmC9?=
 =?us-ascii?Q?vBrPQTYQ/fYYYr/X+sdDxNsWrQwLMqfrk9iXh7SiNC/YHgiyIO1vOtzu9HX/?=
 =?us-ascii?Q?Pn5VZe1i0+DsmPHXkx9q2NkvegDvJf26Bse91el8hzjliQqgkLM83Vr3wSSy?=
 =?us-ascii?Q?U20/N3G+IVH6qRBVumgFPEA+06ZwaV+Uqk7WfsPqQbHZ4gR8FAD+pNK+Ifn+?=
 =?us-ascii?Q?tYoGxgh5eCyXkVnqOEuIxrfO3Q1iyCue+eehnk+rTUqdkjE2O6ObZ6aBGQYA?=
 =?us-ascii?Q?/jWauvqAuSp6Gc9NAZTB7N7JLy6fysv+Rjw+8/nZQc2amkWBt3uS9vetBTBT?=
 =?us-ascii?Q?kayhgncSfJ0DSyv8ZPbjdklaF7cG0aD1U+CTxt2Hu8BzB17sxeX2st3/dvw4?=
 =?us-ascii?Q?vxfvZt/T7WBb7uGQ7qsDDHLi743tk0bNLEnf4zRDoYxZo9iYVv6UB8XzSDRl?=
 =?us-ascii?Q?EarVGR07Q1Zo9sSb20/b+zrrPQzHAVymLdHBKHPAU0EV+0Ack4TsedssiMYX?=
 =?us-ascii?Q?x0c6EfDp9gbG4+4/iRLtUUXU/L1CT6B//+j/lA3KZ2q/BkxADIASpm3/FzBZ?=
 =?us-ascii?Q?EAoH75qoSjv1Z58Zyk3sF5g=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 203f972e-d323-4e2f-5073-08d9f83a24b7
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2022 08:38:05.9452
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2vHSH3v7GwrOoeqW5Q8Zg4vytG4VATbrzFMpywpGBWzWbHBepSQWaj43EDE763HJ7luU866FzdmWGBEy3itJMQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4202

On 24.02.2022 20:48, Andrew Cooper wrote:
> The original shadow stack support has an error on S3 resume with very biz=
zare
> fallout.  The BSP comes back up, but APs fail with:
>=20
>   (XEN) Enabling non-boot CPUs ...
>   (XEN) Stuck ??
>   (XEN) Error bringing CPU1 up: -5
>=20
> and then later (on at least two Intel TigerLake platforms), the next HVM =
vCPU
> to be scheduled on the BSP dies with:
>=20
>   (XEN) d1v0 Unexpected vmexit: reason 3
>   (XEN) domain_crash called from vmx.c:4304
>   (XEN) Domain 1 (vcpu#0) crashed on cpu#0:
>=20
> The VMExit reason is EXIT_REASON_INIT, which has nothing to do with the
> scheduled vCPU, and will be addressed in a subsequent patch.  It is a
> consequence of the APs triple faulting.
>=20
> The reason the APs triple fault is because we don't tear down the stacks =
on
> suspend.  The idle/play_dead loop is killed in the middle of running, mea=
ning
> that the supervisor token is left busy.
>=20
> On resume, SETSSBSY finds the token already busy, suffers #CP and triple
> faults because the IDT isn't configured this early.
>=20
> Rework the AP bringup path to (re)create the supervisor token.  This ensu=
res
> the primary stack is non-busy before use.
>=20
> Fixes: b60ab42db2f0 ("x86/shstk: Activate Supervisor Shadow Stacks")
> Link: https://github.com/QubesOS/qubes-issues/issues/7283
> Reported-by: Thiner Logoer <logoerthiner1@163.com>
> Reported-by: Marek Marczykowski-G=C3=B3recki <marmarek@invisiblethingslab=
.com>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Tested-by: Thiner Logoer <logoerthiner1@163.com>
> Tested-by: Marek Marczykowski-G=C3=B3recki <marmarek@invisiblethingslab.c=
om>

Reviewed-by: Jan Beulich <jbeulich@suse.com>

> Slightly RFC.  This does fix the crash encountered, but it occurs to me t=
hat
> there's a race condition when S3 platform powerdown is incident with an
> NMI/#MC, where more than just the primary shadow stack can end up busy on
> resume.
>=20
> A larger fix would be to change how we allocate tokens, and always have e=
ach
> CPU set up its own tokens.  I didn't do this originally in the hopes of h=
aving
> WRSSQ generally disabled, but that plan failed when encountering reality.=
..

While I think this wants fixing one way or another, I also think this
shouldn't block the immediate fix here (which addresses an unconditional
crash rather than a pretty unlikely one).

Jan



From xen-devel-bounces@lists.xenproject.org Fri Feb 25 08:39:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 08:39:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278839.476235 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNW89-00051F-1B; Fri, 25 Feb 2022 08:39:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278839.476235; Fri, 25 Feb 2022 08:39:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNW88-000518-UV; Fri, 25 Feb 2022 08:39:12 +0000
Received: by outflank-mailman (input) for mailman id 278839;
 Fri, 25 Feb 2022 08:39:11 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=QTOj=TI=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1nNW87-0004qP-AY
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 08:39:11 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 6687ecf5-9616-11ec-8539-5f4723681683;
 Fri, 25 Feb 2022 09:39:10 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7EF33106F;
 Fri, 25 Feb 2022 00:39:09 -0800 (PST)
Received: from e123311-lin.arm.com (unknown [10.57.19.177])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1042A3F70D;
 Fri, 25 Feb 2022 00:39:07 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6687ecf5-9616-11ec-8539-5f4723681683
From: Michal Orzel <michal.orzel@arm.com>
To: xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH] xen/arm: Avoid integer overflow using MIDR_IMPLEMENTOR_MASK
Date: Fri, 25 Feb 2022 09:38:54 +0100
Message-Id: <20220225083854.6371-1-michal.orzel@arm.com>
X-Mailer: git-send-email 2.29.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Value of macro MIDR_IMPLEMENTOR_MASK exceeds the range of integer
and can lead to overflow. Currently there is no issue as it is used
in an expression implicitly casted to u32 in MIDR_IS_CPU_MODEL_RANGE.
To avoid possible problems, fix the macro.

Signed-off-by: Michal Orzel <michal.orzel@arm.com>
---
 xen/arch/arm/include/asm/processor.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/arch/arm/include/asm/processor.h b/xen/arch/arm/include/asm/processor.h
index 8ab2940f68..149fae0d27 100644
--- a/xen/arch/arm/include/asm/processor.h
+++ b/xen/arch/arm/include/asm/processor.h
@@ -39,7 +39,7 @@
 #define MIDR_VARIANT(midr) \
     (((midr) & MIDR_VARIANT_MASK) >> MIDR_VARIANT_SHIFT)
 #define MIDR_IMPLEMENTOR_SHIFT  24
-#define MIDR_IMPLEMENTOR_MASK   (0xff << MIDR_IMPLEMENTOR_SHIFT)
+#define MIDR_IMPLEMENTOR_MASK   (0xffu << MIDR_IMPLEMENTOR_SHIFT)
 #define MIDR_IMPLEMENTOR(midr) \
     (((midr) & MIDR_IMPLEMENTOR_MASK) >> MIDR_IMPLEMENTOR_SHIFT)
 
-- 
2.29.0



From xen-devel-bounces@lists.xenproject.org Fri Feb 25 08:42:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 08:42:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278847.476247 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNWB1-0006QD-GE; Fri, 25 Feb 2022 08:42:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278847.476247; Fri, 25 Feb 2022 08:42:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNWB1-0006Q6-C2; Fri, 25 Feb 2022 08:42:11 +0000
Received: by outflank-mailman (input) for mailman id 278847;
 Fri, 25 Feb 2022 08:42:09 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Zfiy=TI=citrix.com=prvs=0484f4aa7=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nNWAz-0006Q0-CM
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 08:42:09 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id cf5120b3-9616-11ec-8eb8-a37418f5ba1a;
 Fri, 25 Feb 2022 09:42:07 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cf5120b3-9616-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645778526;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=BZMuj71EISq22FzGn64YJv3TZOVthmanBRcprhqTZOI=;
  b=MrEUfsnloQGzU+dC4muC02U3sdHVv5r/yr/4JpZqNmgUeF1gyM6X2rPT
   zC6JGDWDjNtfufVmkS56iSKNrkiPD3tAmDecm0qCyaGHDYD2i+l0krtEu
   qN19O9k5ZvHh4Za/whiKkNku7t1t0NBooOdHl4ER6t1TUeUmejRQCak6D
   w=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 65384799
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:lcpLb6KGKL3EBj4iFE+RJ5UlxSXFcZb7ZxGr2PjKsXjdYENShmdTz
 mIWXGuGaauOYGegLo92PIW/oxkBsZTUzNZkSQRlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA148IMsdoUg7wbRh2NQ12YLR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 Ixi74OBUToAAq2WgL0WeRsFECRfZpQTrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBNPsM44F/Glp0BnSDOo8QICFSKLPjTNd9Glt3ZASQqePD
 yYfQWA2dQ3gXhNPAV0OUMwZl9qqumfgTgQN/Tp5ooJoujOOnWSdyoPFM9fLe9rMWcRcmG6Zo
 H7L+yLyBRRyHMOb4SqI9DSrnOCntTP2XsceGaO18tZugUaP3SoDBRsOT1y5rPKlzEmkVLp3I
 koY4HB29fAa+0miT927VBq9yFactwMYc8pdFas98g7l4qje7hudB2MEZiVcc9Fgv8gzLRQxz
 UOAld7tAT1psZWWRGib+7PSqim9UQAXMGsDaCksXQYDpd75r+kOYgnnF4g5VvTv15usRG+2k
 2viQDUCa6s71OFRyJSjwHn7g2i0/5PjTFM24ySMZzfwhu9mX7KNa4ut4FndyP9PKoeFU1WM1
 EQ5d9iiAPMmVs/UynHUKAkZNPTwvqvebmWA6bJ6N8R5r1yQF2ifkZe8Cd2UDGNgKY46dDDge
 yc/UisBtcYIbBNGgUKaCr9d6vjGL4C8RLwJtdiON7Kih6SdkifdrUmCgmbKggjQfLAEy/1XB
 HtiWZ/E4YwmIapm1iGqYOwWzKUmwCszrUuKG8ymkEj+jefGPCbNIVvgDLdoRrpohE9jiF+Im
 +uzyuPQk0kPOAEASnO/HXEvwaAiciFgWMGeRz1/fe+fOAt2cFzN+NeKqY7Nj7dNxvwP/s+Rp
 ynVchYBlDLX2C2WQS3XOysLQO6+Av5CQYcTYHVE0aCAgCN4P+5CLc43KvMKQFXQ3Lc7nK4sE
 qJcIJ3o7zYmYm2vxgnxpKLV9eRKXB+qmRiPL2yiZj0+dIRnXAvH5pnveQ6HycXEJnPfWRcWy
 1F46j7mfA==
IronPort-HdrOrdr: A9a23:peeN9KnCOCjKctnlRFAGuxlSBzrpDfIo3DAbv31ZSRFFG/Fw8P
 re+8jztCWE7Ar5PUtKpTnuAsW9qB/nmqKdgrNwAV7BZmfbUQKTRekJgLcKqAeAJwTOssJbyK
 d8Y+xfJbTLfD1HZB/BkWqF+gAbsbu6zJw=
X-IronPort-AV: E=Sophos;i="5.90,136,1643691600"; 
   d="scan'208";a="65384799"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=nn8hGov3hzz1RsT4spuSrBPLKdToDraEUP5ytk4Db22XdNd93l+AoQ+OPpIksNXwHqHLRKPwNdQK1k/BVb/rBN1J76VZx+kJRVEVgechZsiKQmlqqirJaDR+9SsU0QKuYHDIlkvT3rlYy5ZXcPr99Yywv4F1CujpM78oCH/5OUymiiagr8sDxSGVAZqRx3y2RC+EfMkR+noaKqlBxBRm1EAiNOsPrMbsqbtVbqBu2JFh9Pn51mf3Jz7X5yeuk7LezLu9a79s4Bqix1twfT3Qsob7uR4bhjqKaZg7KBXZHeKMeUMIgVn1fSI5zIPDVagYbV36vH+Cf8wIAhxRP53QUw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=362OdD7Yjtrz9CvyKnpo87g0J1BeJXvv+MalHiJzF4E=;
 b=LCAeYKFyGJPJGAPOmTINwCWMDKf9T6VoXO5aM08IDq351HR29/Y7sXa7KeYciYdxjCe8jfiMCrnvW2Iq0M/ovU+v2bIBOrvjHZ2Ocx80ENWXm94P3Tba7DEhU8U4Zmq+Pilql8jhDM/4Yx1+6Yby9NK3zBZ7lOX31Hx29gmLFrJjhbj4+YBx3pq0/kYFJ8XLHty/IFnFbcqH/ZZKxwl84JjZmCNZvlzuWS8yM/iKcO2vlV3t4P7otUM1nkPE1D77qQzw1NP5cKimHi0aIdaox02qAY8Yy+6N/ABcZLOFVpU+k4vVIwK+TivGjlmLiIjaRUgyO8KMWD7ULOuz/trSBQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=362OdD7Yjtrz9CvyKnpo87g0J1BeJXvv+MalHiJzF4E=;
 b=WAiiQnH6XVipc4wR67FaZXLvVFynJkOZq+Ev4HX0tVH8/dy3PDSCmS2hxYd6oP61j7sO1cghiMNPOEs3lxra0MLrjMa9GH8EPpCYtbWhQn1QaA8xJ1och549ffn/9UscbB6JMaS0C53GnRljxqI0DYhK0IZ6UsJYK8nonjZJ9fI=
Date: Fri, 25 Feb 2022 09:41:55 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Paul Durrant <paul@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>, Kevin Tian
	<kevin.tian@intel.com>, Oleksandr Andrushchenko <andr2000@gmail.com>,
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2] pci/ats: do not allow broken devices to be assigned
 to guests
Message-ID: <YhiWU+7Q9/Fbsig+@Air-de-Roger>
References: <20220224163701.89404-1-roger.pau@citrix.com>
 <87b47562-7689-de37-f2ee-df05ef01c923@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <87b47562-7689-de37-f2ee-df05ef01c923@suse.com>
X-ClientProxiedBy: MR1P264CA0120.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:501:50::12) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ebb513b9-be01-490a-763f-08d9f83ab0c3
X-MS-TrafficTypeDiagnostic: MWHPR03MB2943:EE_
X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
X-Microsoft-Antispam-PRVS: <MWHPR03MB2943C52AE15A8B97489234078F3E9@MWHPR03MB2943.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: t8HbE3i0L4bKfxSwvRnnxjtuM+FV8UcqzFFS46kcthmZAN21IVVho26RKqmdsj2GCFCTGO2REkA7QOwgiqFoA9ZMZ/aO1QvtKOGwTSfAY1a0IdofjGlghJgkYYA1qy8fvoLpoe2zE9jSHEpJcB52+XLHVTaQz8Y3yY1KAI+iYCc2Ligv7Hq0Gv3pAaNHY5zfQVzitoivXpvscyFtfmlHTxaR0pS1J+S6KQLLrDEDBEhuJzL0wKj7v+pcgdPV6tbbgGbDOd5M/rX0YyKUzeNinYA/2ilHTZTE/XsaGyQXVab0/jMcArqUFylLHWZ6kAy9/s0qmkZ9mlbXIOWfs94im9PnkFDTaRQKyePc60jbt6gL7dW04U0ghuZssHVAwujSYROMRa+3VHN6B7bcO3gml5vJ4MGPHOwMd86XEpFubYNSDd0VK7Dod9JmkRji5Xdulr2EpxPbfE+/TYIpquizTMUn+NeO5OdUQsR2Mz2ddAdFboLx+EZAoCRiwrdLDDwGfFVcMea9Di0wlcGFTBsSfxc1Q1Te7eWJKGIuCYiHsm46MdplPiW3GnzZyS1B8M9lMwhtcXY+74huQzphPFVIxCC8ce9rijHsWAqgNdGgSwc0OqWqY+S9yZrrsuJ4VzuJxzxO3UHSfqD3EygQS9NVPg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(6486002)(83380400001)(66946007)(66476007)(66556008)(316002)(85182001)(54906003)(86362001)(2906002)(6916009)(4326008)(8676002)(8936002)(5660300002)(82960400001)(26005)(186003)(6506007)(6512007)(6666004)(9686003)(38100700002)(53546011)(33716001)(508600001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OVhlRXl3ck4xbkVuQlNSL1VER2hMZkdzT3ptVms2ZTAxdnBaWExGZ3VpcWdB?=
 =?utf-8?B?N3dFRTNWalNUZjRsTFBGa2dsYVQ3cVV5b09sQjVUeVVvcDNPR2hhMC8xRWN3?=
 =?utf-8?B?OHNOYVRDUU1TRnBFV2J3cjZIUk54bjl2RU1xZHNtZ1MzRThpN2R0amZBMW1W?=
 =?utf-8?B?WGlFcitUTUdENjRub3pBbldQMEEzS1NGTXVtQTJPU0c5V2x0Y3k4dS8yK2kr?=
 =?utf-8?B?K0V4UFVQenNvcGNadXNjam5EbXMremphelBBTjBFR1FuVld3czZUNmtXOStU?=
 =?utf-8?B?UGZvYlpjMkxhSkQxb3VXMlRrMjBHMVVhejZ3RlpxM1VDb2kvSEhjSEpWaG5Z?=
 =?utf-8?B?YlczeExseTNHN05XTDhEd2ZyRHdDZk9Zb0wzTnBRNW0xSE4vZ3RyUlRpdVIx?=
 =?utf-8?B?NWo1Mm1PSC95blRLWm5WNU4wcGQ5WlZPNlNuSjAvaHdjNDNNQ2wrWXFIZlVS?=
 =?utf-8?B?MEh5cVErTDViQkQvM3BvS2pZaGd0LzB3SEN5SG5qL3FCVXNzdk9Yc3FqVE9j?=
 =?utf-8?B?Wm43ckp1OHBxMExUempWdndFYlJLczVzWlI3eVoxOE9OZ0pYSGtVWld3dW9K?=
 =?utf-8?B?ZEk1UXhzQUdxUEVEMlpsRGQyVE5hYTQrTERaOU0wcWxZY1UyRXA0V1Y0dWd5?=
 =?utf-8?B?Qk9TU2hLS3pxb0tHSm0rb2ZSc1lpWHRMRTd6SEJJdWxLcTFMVDkzb1dacU0r?=
 =?utf-8?B?VDI5ZzJtMUErTWJhL3VJYzVEd0ZNdUJkbGpHVnEyUEQzUEd1MVNZaXNaTE1O?=
 =?utf-8?B?L0pYVllRRnVUT2hEZkJVUnZYaTVxa2F0NXRRZk13eVV2YUE5YjZUMkY0V0JD?=
 =?utf-8?B?QVBrNDNkSnVjTVRoK3lPTVJoMitNcCtYU3FEU1BEOTd6WFZKQnpFSUtoUk85?=
 =?utf-8?B?TFd5QWtYYTdVTFVJVzhLTDV3dGNxR3dRZmM1b3p0NGxJeEtMeFhpN0g1dmVU?=
 =?utf-8?B?RW5uaUhWKzJzZHpxN1FwOFhtYnBrL2hnNDdMWWpERHlZdk5uR3c5SkZrVG5S?=
 =?utf-8?B?bEtsNEF0b1UyWkVkcUEwejlWNlhqTFB0MS9RL1FxTDlvdVNrODFyNWRvRUZP?=
 =?utf-8?B?VkdGekVhTkljNjQ2TG9LMDVMWmZ0Z3Zaa2pxU2laNDZTTW9KR0xPVXFtWkx2?=
 =?utf-8?B?NXNEUkxkYlVmaXBFU3JPQ2R3Q0pWY2grQTJ2N2grZElrWTRPblFQclR5emJB?=
 =?utf-8?B?c3dvWURJWkNkeHF1dWQ4Uks0WlJqS29Id2hzMkROL1c3Y0VUcEpPcmljVS9h?=
 =?utf-8?B?dG5wQWJ2SkhiNTFiZy8xdWlVUStFVjE0b244UWVOQ2RTalR2Y09SWjhYenJk?=
 =?utf-8?B?cU1YbFZKMDRKaXhxZTNYdDNjM3FzZlIrc1lIVFl4RTdJM0poMkY0ZGlLQkJl?=
 =?utf-8?B?S1V1cDlUM0sxQ0dvVE9taThwNk5NbXBxZlZ6VVRLSHlMRjhSdGFrcURBVEN1?=
 =?utf-8?B?NmFqM1hGeDNSTVZhMm1BT0Q2emYvQzJYd2ZIRHYxSkd3NHd4aXIxNHh1L3o1?=
 =?utf-8?B?MlVZTDRqNnNsc0tzSFp0UEorSHErVVBQM1B0YitudWhBNjZVNm5zWVE2N1dl?=
 =?utf-8?B?eUloQVJhK1F3UXZuMU9DQkNZZUNPWlNQNFpBYnBJM0YyR3RYQ2RwYy9lTXJm?=
 =?utf-8?B?TmVHdmw2bk1URnZEWTFaOWlNeTJERTRBS1pWOXl0YXFsRzdRaUNTVWRGdVpa?=
 =?utf-8?B?VzBSclBPVkUwa21sNmlTS1ZxWG9QZXhQd0pyZFhoWlZEeW0zUmdWTjN4Kzl2?=
 =?utf-8?B?Zkp3ZVlFOENXOXRlYytXWHVybms2N1FKaHliWUtRVUdCd2lZV28zaGh0aWN5?=
 =?utf-8?B?Nnp5ejZIWk54RFJNellJODlDWm9wUTNkS3ZBOXhFcElNSUQ4WjdNdFZvUlA2?=
 =?utf-8?B?OWJOZDl2S0NXS01HZGptOE8rVXg2NmFEOWNnSlNHT0t2bnNjWFZkYXExSXVa?=
 =?utf-8?B?MEVWU0QrNXpadGVtNXoydGh3SksxUjBTWDlaZHF5UGQrRHYwaEw3M0dyLzNN?=
 =?utf-8?B?TjNVbXViQngzK0JocldYZVhXcHNkZXFQTHlLMVUzSlo1QmFVaWNuZ3NjbHI3?=
 =?utf-8?B?UGY2Yy9EMVdOVnkyQVVBWEJ3QnBMSUN1MHJGd1NKNDZHajEydDQ1U0c0QW9H?=
 =?utf-8?B?KzQ4dHJ5T1gyQkd3Vnh5TnRFWjZCWTRxdmt0dmlHeVlzZ2xsMVRwQWtiOE1H?=
 =?utf-8?Q?OnEllEoUfXSEzZ5kOwt4mfs=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ebb513b9-be01-490a-763f-08d9f83ab0c3
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2022 08:42:00.9851
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HMkGNmxhiCcQp47wsJGcYqPGhCZ62c8zsF+EsQFzOEbl6Ye+E91ImqZmNhOcgIHHe/3rKh7pb5XY8ZGR7YwThg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2943
X-OriginatorOrg: citrix.com

On Thu, Feb 24, 2022 at 05:43:13PM +0100, Jan Beulich wrote:
> On 24.02.2022 17:37, Roger Pau Monne wrote:
> > Introduce a new field to mark devices as broken: having it set
> > prevents the device from being assigned to guests. Use the field in
> > order to mark ATS devices that have failed a flush as broken, thus
> > preventing them to be assigned to any guest.
> > 
> > This allows the device IOMMU context entry to be cleaned up properly,
> > as calling _pci_hide_device will just change the ownership of the
> > device, but the IOMMU context entry of the device would be left as-is.
> > It would also leak a Domain ID, as removing the device from it's
> > previous owner will allow releasing the DID used by the device without
> > having cleaned up the context entry.
> 
> This DID aspect is VT-d specific, isn't it? I'd be inclined to ask to
> make this explicit (which could be done while committing if no other
> need for a v3 arises).

Indeed. AMD doesn't use iommu_dev_iotlb_flush_timeout so the function
is VT-d specific. What about using:

"Introduce a new field to mark devices as broken: having it set
prevents the device from being assigned to guests. Use the field in
order to mark ATS devices that have failed a flush when using VT-d as
broken, thus preventing them to be assigned to any guest.

This allows the device IOMMU context entry to be cleaned up properly,
as calling _pci_hide_device will just change the ownership of the
device, but the IOMMU context entry of the device would be left as-is.
It would also leak a VT-d Domain ID if using one, as removing the
device from it's previous owner will allow releasing the IOMMU DID
used by the device without having cleaned up the context entry."

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Feb 25 08:44:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 08:44:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278853.476258 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNWDH-0006zi-Tu; Fri, 25 Feb 2022 08:44:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278853.476258; Fri, 25 Feb 2022 08:44:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNWDH-0006zb-QO; Fri, 25 Feb 2022 08:44:31 +0000
Received: by outflank-mailman (input) for mailman id 278853;
 Fri, 25 Feb 2022 08:44:30 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=RDkG=TI=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nNWDG-0006zS-HV
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 08:44:30 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 24ca2863-9617-11ec-8eb8-a37418f5ba1a;
 Fri, 25 Feb 2022 09:44:28 +0100 (CET)
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur03lp2056.outbound.protection.outlook.com [104.47.9.56]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-37-PVe12tJIOZqNzLfZl-yF_Q-1; Fri, 25 Feb 2022 09:44:27 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM9PR04MB7620.eurprd04.prod.outlook.com (2603:10a6:20b:2d9::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.25; Fri, 25 Feb
 2022 08:44:26 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.025; Fri, 25 Feb 2022
 08:44:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 24ca2863-9617-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645778669;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=/iyaoknACxl0d6KOSX3tULqJRL9tvjvk7Oa3iw/mrck=;
	b=fuTZmmpw5dWCU4rWAWli2MMWL1xNDb/OjNDADocpEO/2TLL5iX/7Ff1pqxzKkqL88qDOH5
	yP1RIhAiOEN4TAiviF/4G+jAQh5mqV7T0ZSZJC9YMAxQpq8axB3IvvvtQ8k3sY9D0wzqTC
	Wa3b+3WJ+MY9Y/B1NEihFzmhsBiRgs0=
X-MC-Unique: PVe12tJIOZqNzLfZl-yF_Q-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=HtNHkJBnL7SioBm2g3W553qw92Ev6FvMNM0xHsgUYJez5pkXh8415UhvIGMkoKjyxok/Jq4z3BfPtzVNKZnDPzLVVdHaCItzbv2HNVGk3shbIPU/tc/mZym0kwdk9IRYzz1allbXwSvYRELGO2VKU+UeZsxMeAabGI0bqaKbfaWAdWNIhJ/JereDeuxG8wW19xdoBFXd3JEz1zZoZEWNNXlKM9ydDyR70IwdV+e+QLFuOU+uLhXx0SzT47bNFMtgOFZcPYglPfFZxChDCSG7VDu2MLFp3+qYFaJ61aEOB0euesI/jrQv+L0yg94TZZgZZCMnNmWYxEPOBUvRgU99qQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=/iyaoknACxl0d6KOSX3tULqJRL9tvjvk7Oa3iw/mrck=;
 b=amuI7sERtQ3q0DGSnF5qvTQvsuAVdKXLHB8m1nY7/ZAB5694cQxysevxk+QVDrQMDspMxu1VEAlyNKGKFXlDYz/BNSga7TroVquXWV09hyDpBWzo4zu1W44mHku7CdkHUVw/apmX1gH6W+x/nBXKUHzC08AcJ0i5CYJaavsaKLPhYNlVqKBwxVavyokNaJu3txs7VLl76jG7RKaByUrZNmla0RsfhfWqBfEzFd0lFIjR02/WDUyqdFuZnmdN9943xw6iqpH2xeQjWsf1C46+bUvIMVMVHJIHttyOz/SC9Nim11b9gttp4mBURWhqe5P3+r9tvAJ//V5/XCA1/bmy7A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <12d8b90b-15b0-c094-71e5-35cfdbfe72b4@suse.com>
Date: Fri, 25 Feb 2022 09:44:24 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: x86/vmx: Don't spuriously crash the domain when INIT is received
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Jun Nakajima <jun.nakajima@intel.com>,
 Kevin Tian <kevin.tian@intel.com>, Thiner Logoer <logoerthiner1@163.com>,
 =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20220224194853.17774-1-andrew.cooper3@citrix.com>
 <20220224194853.17774-3-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220224194853.17774-3-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR3P281CA0074.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:1f::12) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d90724e1-f7e4-4d85-e397-08d9f83b0775
X-MS-TrafficTypeDiagnostic: AM9PR04MB7620:EE_
X-Microsoft-Antispam-PRVS:
	<AM9PR04MB7620067158568F0B7A9BF611B33E9@AM9PR04MB7620.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	S6Ud89IYfh1YyLHZc1NLvRWYL7oWATS18LKVemzqPTnxlN1OSFZAKc+g5GLwY5Rs1enzYKN2ZalfHbIIxXfDEsGpMX+7ob7wO868P2rIGPvCZDNA6CueRUPQb5qzO/3Y87J4LZy1qCfwPLmoOfmZnpQO3bAN9GrIMy5n1OjYvGREP8zwvIkGGWTUCP3uLndrCPuCaYvQXT3tJSaH3gStJHmay7VOeLQyZqB0K9OzKq0gZ6wOUZo1O3zzod+4LI+9YPXDcUGrBs3vNXuFKVvCxHug/71NnSToyF8unQhf2wMKe3VgcNfjl58D2o5q3A/dppVgdfgWh9udTCtKGYUr4xEwW6cNsHadnR7an1Ki3IiNL+qdB7b5P1RlkF/AgSNjCvVPJ5BU6+RvyNeDIYZMSr6d00EPenGhMhx6Hyi8nFXRO3WWPguVz6re74pE9KVr+fU5A+7WkLMDn9ne4TL7UtnW7e3m1smpoZZ95KLkHBk7hEHNhvt6G0Lzgfl057kHmtMtjp/Xr0fGS1rF+FAzm52AfnTMHuu/Ij2ggJfEK+uLvApR23Fcurdrngouks8oqPW+DRmQ/QjF52zsShzoOZZUUYrRvOLLddOJrGHuC0vDnfl8G4v8Syuv2kSchhiD5Orb1/WW1gRpyEo7QtXq9HljheqA0uPgtNi6d8VlLnOK8f6T9l3PJ2r4/DVoXXZctI0lSwaqx5vTwzLKIR+uG4bNRrCWi21zGmlGGciSkm6rLuVjr4gsa33zOq9mDdsO
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(31686004)(8936002)(38100700002)(508600001)(83380400001)(54906003)(6486002)(316002)(6916009)(36756003)(4326008)(66946007)(6506007)(6512007)(31696002)(86362001)(8676002)(66556008)(66476007)(53546011)(5660300002)(2616005)(2906002)(186003)(4744005)(26005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?cWtkeUE3UlFDTFZLd0JvSUtaN0lLNStXVDMvdkFwaWlUVTk5S1p3ek1ndmFL?=
 =?utf-8?B?NFBHdlhOY1J5NXluUGRYMm9TSUpWeUxpR0c4aGpNMXhodVNMVnpwdDZBcVNh?=
 =?utf-8?B?eEtWazl1Yk1tRjQyUjcvQ3VkR3Nnby81enBGMUF5WTh3YzRaU0N3YXhpTmND?=
 =?utf-8?B?UUZZck5XbVQydFlPeTY5N0ppR3ROampkUXN5RHkyYml6TWd2OEdTU1dNTXR1?=
 =?utf-8?B?QjlFQU5hM2VXL0Y1azg2K25UOUV3K1JLcGNnNG5VRmkrWFVZbkN6T2JiQXdk?=
 =?utf-8?B?aGN0RzMvbkNvTnZucVp1bGR3K016TUNyUnJ2aU96d2l4SGxKUHMxa0U5aWhn?=
 =?utf-8?B?Zi9NektnNlB5cTExb3NFeUd2WWtmdlhCSHNoQjFZRDZrVFFHenRaQnFnSS9B?=
 =?utf-8?B?Q2NHTzRnUjNkSld4QWJBTXpXWHpZUG9weXBQLzRhaFlibTBVM2FPN20wb3ZY?=
 =?utf-8?B?dnVOa1ZmQXRyeW11WHJRZ3IzS2tiKzRkT1FELzRpUUlYS1BtaXllZEQzSVBE?=
 =?utf-8?B?UjJRVVh3Q25yYlhYWmdPL1BlMG5CWlJFbnM1ZC9TYkt1blVqUnRkVEZiQm5L?=
 =?utf-8?B?NVFMM3ljY3doNFhFZzVwWlcrUGpNaWpySnp1ZThQL0VKRDFWY3Nyb1R0bjZC?=
 =?utf-8?B?SkdsaFZaaFdXelRkMC82K3RBc3JHTit2M0hDY3lIRFc3YmV0RStyQUFYWDc2?=
 =?utf-8?B?SEdFTkhralRtcTkzRmFiSy9QVGxDNFlMY3E0T0VLUTBwTDYrak90dURTS2tj?=
 =?utf-8?B?YjBWY1VxZjFsZjg5UUtxWDQxT09ncElLUzJNdGFwZkFOUWV1MVFzTThPTThT?=
 =?utf-8?B?SlJVVEhuNXlRNEF3cjdENTdFdXBpL29Rbnh4Y2pEYTAxbXU0YUd1UkgzdXNY?=
 =?utf-8?B?VjZKdTV3WlNKd0pSSDRNTnA5NkZrK05XbUpIaUZDdkxrYmRmRjlnd29rMVk4?=
 =?utf-8?B?b0dXV3ZZNzBmUGNPMTNmR1dGb0Y2Tzk2a2JUVEUvVGg3TEQ0bWR0QUI4SlNJ?=
 =?utf-8?B?L1preDZQQ0RUb0tMOWZGT0lVQ0JQczFkbHJWMmNJOG00TWdYbk8vQlJuaVky?=
 =?utf-8?B?eWhhMUhBTmZqNnEydnJTTGJYK1JIVnhjdVIxYnFrN2JVQ1NvcFBVcklvc08z?=
 =?utf-8?B?UWk0YXA0Y2h4bDJ1ZFIyNGFvUmd6Qko3K3hOaEZnOFZWc2E0UndZd2o5UHBo?=
 =?utf-8?B?cVg1M0pJWXgxRkl3OVNkZlN4KzJTeEhOVTdQUDI1L3F5WFNHZ0UwNGxzN0dQ?=
 =?utf-8?B?RXJ5enBSa3dXbmtzeUs4Q0NidXhSSXZCczF6bGIvMW84SGxWTjRDY0l3Z2Zv?=
 =?utf-8?B?aUFHZG5rc0ZRbGtWTlZ4aHNxOG1wN1hzdVppa0FLK1pDN2IrVHVhSGRwK0Jo?=
 =?utf-8?B?ZEt0eG9KT1BJd0dITUlqaGowbWZ5RVVIMS94SW13TjlSOUZLVkg2L0IyYWRn?=
 =?utf-8?B?NURCTVJ1VVpBd2lmbVpNR1d6eHVwVXV3Si9DUmk1dXVUS1plUzA3YTF3OGxD?=
 =?utf-8?B?dFBVcldCZHVoQWVlcEVQb05kSDN3dzVUb2ZTYkhKdCtZWFJvcW0vNTh2bUVv?=
 =?utf-8?B?MjkzejI3SFNrR2NVaUxKdlM4b0RVMjRJK0xiekpjekJSZ3J3OTRQR1N6cjBa?=
 =?utf-8?B?UWRQTlgvbEpudFA0VEJSTUZSSUFWR281cktPZGVadGNrTSs4UHpzZENYYjFM?=
 =?utf-8?B?ODdiMWF0OFFtWXpJQ0hCL1NrTm1iZWNlQUdXbnArSkJoQ0tsMWlud3RzVzU3?=
 =?utf-8?B?SjdxL3BJYlcxZ1pPNGFHaGg1NC9aRG9lUUUzRmtjaGZRVy9QQ2YzVmVDNk02?=
 =?utf-8?B?Z2V0aCt0U2tUbVdUMUVYVC91SmJQdHc5Ny9SQUhRQlB6NnJnYjkwL2ZmdjM4?=
 =?utf-8?B?M0w5RlFTbDBIbGFFVC9MMG1FcTJrYUhLRTZ1YWtZQ1Bhbi9ua05BaXd5WVlI?=
 =?utf-8?B?UmdXS0R4ZmNzU3ltQzcvR0N0eXpmZGlOOFZERmpEUXFrZnA5MkNEL0JtNm5N?=
 =?utf-8?B?QnR1eFRodkhFckl4MWZFM0pvN0R0T0VIK1I4WmdnRC9obDYzTEE2WWNkeUVi?=
 =?utf-8?B?VTFPajhHeXZMODg2MnFkUUNUWk83bjVuUHJTUERHZUI0N21jbGd4QmlScnJj?=
 =?utf-8?B?emFXYktkN0Vwd2VVL0NzQlpHN1c2Z1pKSG1PUzF1VHlnc2dKK3hFckNUS2hT?=
 =?utf-8?Q?Eu39DsCcB32G9a/xTeZMrWQ=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d90724e1-f7e4-4d85-e397-08d9f83b0775
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2022 08:44:26.3123
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: euq9uq2QXR0Z8y77p7gtUG4ieQ6uncd47S6XDOgQacUXGCIsUV6MqbhYbnu6CMjiLM6RR2H1+hilF2xb0XwZsg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB7620

On 24.02.2022 20:48, Andrew Cooper wrote:
> In VMX operation, the handling of INIT IPIs is changed.  EXIT_REASON_INIT has
> nothing to do with the guest in question, simply signals that an INIT was
> received.
> 
> Ignoring the INIT is probably the wrong thing to do, but is helpful for
> debugging.  Crashing the domain which happens to be in context is definitely
> wrong.  Print an error message and continue.
> 
> Discovered as collateral damage from when an AP triple faults on S3 resume on
> Intel TigerLake platforms.

I'm afraid I don't follow the scenario, which was (only) outlined in
patch 1: Why would the BSP receive INIT in this case? And it also
cannot be that the INIT was received by the vCPU while running on
another CPU: With APs not coming back up, it cannot have been
scheduled to run there. And it would have been de-scheduled before
suspending (i.e. before any INITs are sent).

Jan



From xen-devel-bounces@lists.xenproject.org Fri Feb 25 08:47:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 08:47:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278861.476268 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNWGN-0007hC-Bn; Fri, 25 Feb 2022 08:47:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278861.476268; Fri, 25 Feb 2022 08:47:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNWGN-0007h5-8q; Fri, 25 Feb 2022 08:47:43 +0000
Received: by outflank-mailman (input) for mailman id 278861;
 Fri, 25 Feb 2022 08:47:42 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=d3I2=TI=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nNWGM-0007gx-67
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 08:47:42 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9760cf61-9617-11ec-8eb8-a37418f5ba1a;
 Fri, 25 Feb 2022 09:47:41 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id C5953212BF;
 Fri, 25 Feb 2022 08:47:40 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8DE3713B65;
 Fri, 25 Feb 2022 08:47:40 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id f4f+IKyXGGKbRAAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 25 Feb 2022 08:47:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9760cf61-9617-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1645778860; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=BlaTZRJRXNesrFzBAHf17w8XerLFn10CsrD8MIBovvg=;
	b=BlE+SxpjCPyRI+90lzFdbqk7eoDxDQ76uEg2z3Ca4uQ74RTtYISFhdkXMHFZsxgClS9XgP
	BN+SwF50DjKwjX3US6d2k9B+pzOn1sI7E/0Ay/yqJDOmB4a4eGVlADvxcmNIj8HB+mPlc5
	VTgPav5v/ct2cje1bZ2GXt/V2LgViv0=
Message-ID: <fec22cee-d8f4-676c-7ec4-7f65f93af061@suse.com>
Date: Fri, 25 Feb 2022 09:47:39 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH 1/2] xen/spinlock: use lock address for lock debug
 functions
Content-Language: en-US
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220224105436.1480-1-jgross@suse.com>
 <20220224105436.1480-2-jgross@suse.com>
 <7009dbf4-d814-6181-7315-a4fce21ee338@suse.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <7009dbf4-d814-6181-7315-a4fce21ee338@suse.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------0F61St06QKinIR7enVadyATd"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------0F61St06QKinIR7enVadyATd
Content-Type: multipart/mixed; boundary="------------Ar7FXG7mzEMPPo36IiJ1T0TU";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
Message-ID: <fec22cee-d8f4-676c-7ec4-7f65f93af061@suse.com>
Subject: Re: [PATCH 1/2] xen/spinlock: use lock address for lock debug
 functions
References: <20220224105436.1480-1-jgross@suse.com>
 <20220224105436.1480-2-jgross@suse.com>
 <7009dbf4-d814-6181-7315-a4fce21ee338@suse.com>
In-Reply-To: <7009dbf4-d814-6181-7315-a4fce21ee338@suse.com>

--------------Ar7FXG7mzEMPPo36IiJ1T0TU
Content-Type: multipart/mixed; boundary="------------WAQT3iSH1H7Sffeokqf5Bt6g"

--------------WAQT3iSH1H7Sffeokqf5Bt6g
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMjQuMDIuMjIgMTc6MTIsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAyNC4wMi4yMDIy
IDExOjU0LCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gSW5zdGVhZCBvZiBvbmx5IHBhc3Np
bmcgdGhlIGxvY2tfZGVidWcgYWRkcmVzcyB0byBjaGVja19sb2NrKCkgZXQgYWwNCj4+IHVz
ZSB0aGUgYWRkcmVzcyBvZiB0aGUgc3BpbmxvY2suDQo+IA0KPiBJJ20gdW5jZXJ0YWluIGFi
b3V0IHRoaXMgZnVsbCBleHBvc3VyZS4gVGhlIG5leHQgcGF0Y2ggbG9va3MgdG8gYWdhaW4N
Cj4gb25seSB1c2UgdGhlIG5ldyAiZGF0YSIgc3ViZmllbGQgaW4gdGhlc2UgZGVidWdnaW5n
IGhlbHBlcnMuDQoNCk5ldmVydGhlbGVzcyBJIGRvbid0IHRoaW5rIHRoYXQgdGhpcyBkZXRh
aWwgc2hvdWxkIGJlIGV4cG9ydGVkLA0KZXNwZWNpYWxseSBhcyBjaGVja19sb2NrKCkgaXMg
YmVpbmcgdXNlZCBmb3Igcndsb2NrcywgdG9vLg0KDQoNCkp1ZXJnZW4NCg==
--------------WAQT3iSH1H7Sffeokqf5Bt6g
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------WAQT3iSH1H7Sffeokqf5Bt6g--

--------------Ar7FXG7mzEMPPo36IiJ1T0TU--

--------------0F61St06QKinIR7enVadyATd
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmIYl6wFAwAAAAAACgkQsN6d1ii/Ey8G
aAf/Up0PyJq156Zlxg2QQfJq+x8RgJ2el2gFpsYjZ0eP6O/MV+eWOdVdqreRX1dayKcEr9xpxc2a
NAxFx+LI3JlXjAHqg5zLCDLgJfeOOXGZOamlaaORXciSvpk0Imjo69s8ZCu17mC+FN2MVSu4iwgn
EC8aE03o1laOrA/gPhMSgL66IJ976GIlgSS43XEPvkAL+hLA9U/BlmUyfnZp+OEWvkfgrwCiXY/Q
jSmGH7MdCM1KyNgU9KGBajXLd6aoVagI6auy1ILfP9xhuBYf5bKQqFtKXF0hFWduGIWCuwiVVg/4
9oXE5TMawDTy+RY8lf6htfWTPSojh+I0fZVG0I0IbQ==
=USBx
-----END PGP SIGNATURE-----

--------------0F61St06QKinIR7enVadyATd--


From xen-devel-bounces@lists.xenproject.org Fri Feb 25 08:48:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 08:48:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278864.476280 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNWGg-0008Cn-Nm; Fri, 25 Feb 2022 08:48:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278864.476280; Fri, 25 Feb 2022 08:48:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNWGg-0008Ce-KM; Fri, 25 Feb 2022 08:48:02 +0000
Received: by outflank-mailman (input) for mailman id 278864;
 Fri, 25 Feb 2022 08:48:00 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=YZHd=TI=lst.de=hch@srs-se1.protection.inumbo.net>)
 id 1nNWGe-0007gx-SC
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 08:48:00 +0000
Received: from verein.lst.de (verein.lst.de [213.95.11.211])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a28ac697-9617-11ec-8eb8-a37418f5ba1a;
 Fri, 25 Feb 2022 09:48:00 +0100 (CET)
Received: by verein.lst.de (Postfix, from userid 2407)
 id 364BF68AA6; Fri, 25 Feb 2022 09:47:56 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a28ac697-9617-11ec-8eb8-a37418f5ba1a
Date: Fri, 25 Feb 2022 09:47:55 +0100
From: Christoph Hellwig <hch@lst.de>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>, iommu@lists.linux-foundation.org,
	x86@kernel.org, Stefano Stabellini <sstabellini@kernel.org>,
	Juergen Gross <jgross@suse.com>, Joerg Roedel <joro@8bytes.org>,
	David Woodhouse <dwmw2@infradead.org>,
	Lu Baolu <baolu.lu@linux.intel.com>,
	Robin Murphy <robin.murphy@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	xen-devel@lists.xenproject.org, linux-ia64@vger.kernel.org,
	linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org,
	linux-hyperv@vger.kernel.org, tboot-devel@lists.sourceforge.net,
	linux-pci@vger.kernel.org
Subject: Re: cleanup swiotlb initialization
Message-ID: <20220225084755.GA29630@lst.de>
References: <20220222153514.593231-1-hch@lst.de> <09cb4ad3-88e7-3744-b4b8-a6d745ecea9e@oracle.com> <20220224155854.GA30938@lst.de> <206ba6a3-770a-70ad-96bc-76c6380da988@oracle.com> <20220224163943.GA32088@lst.de> <8ffd8587-7eb3-d5b6-eab0-b86df5c0ebbd@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <8ffd8587-7eb3-d5b6-eab0-b86df5c0ebbd@oracle.com>
User-Agent: Mutt/1.5.17 (2007-11-01)

On Thu, Feb 24, 2022 at 12:07:26PM -0500, Boris Ostrovsky wrote:
>>> Just to be clear: this crashes only as dom0. Boots fine as baremetal.
>> Ah.  I can gues what this might be.  On Xen the hypervisor controls the
>> IOMMU and we should never end up initializing it in Linux, right?
>
>
> Right, we shouldn't be in that code path.

Can you try the patch below on top of the series?


diff --git a/arch/x86/kernel/pci-dma.c b/arch/x86/kernel/pci-dma.c
index b849f11a756d0..f88c9a4a5ed12 100644
--- a/arch/x86/kernel/pci-dma.c
+++ b/arch/x86/kernel/pci-dma.c
@@ -47,22 +47,6 @@ static unsigned int x86_swiotlb_flags;
  */
 static void __init pci_swiotlb_detect_4gb(void)
 {
-#ifdef CONFIG_SWIOTLB_XEN
-	if (xen_pv_domain()) {
-		if (xen_initial_domain())
-			x86_swiotlb_enable = true;
-
-		if (x86_swiotlb_enable) {
-			dma_ops = &xen_swiotlb_dma_ops;
-#ifdef CONFIG_PCI
-			/* Make sure ACS will be enabled */
-			pci_request_acs();
-#endif
-		}
-		return;
-	}
-#endif /* CONFIG_SWIOTLB_XEN */
-
 	/* don't initialize swiotlb if iommu=off (no_iommu=1) */
 	if (!no_iommu && max_possible_pfn > MAX_DMA32_PFN)
 		x86_swiotlb_enable = true;
@@ -82,16 +66,36 @@ static inline void __init pci_swiotlb_detect_4gb(void)
 }
 #endif /* CONFIG_SWIOTLB */
 
+#ifdef CONFIG_SWIOTLB_XEN
+static void __init xen_swiotlb_init(void)
+{
+	if (!xen_initial_domain() && !x86_swiotlb_enable)
+		return;
+	x86_swiotlb_enable = true;
+	dma_ops = &xen_swiotlb_dma_ops;
+#ifdef CONFIG_PCI
+	/* Make sure ACS will be enabled */
+	pci_request_acs();
+#endif
+	swiotlb_init_remap(true, x86_swiotlb_flags, xen_swiotlb_fixup);
+}
+#else
+static inline void __init xen_swiotlb_init(void)
+{
+}
+#endif /* CONFIG_SWIOTLB_XEN */
+
 void __init pci_iommu_alloc(void)
 {
+	if (xen_pv_domain()) {
+		xen_swiotlb_init();
+		return;
+	}
 	pci_swiotlb_detect_4gb();
 	gart_iommu_hole_init();
 	amd_iommu_detect();
 	detect_intel_iommu();
-#ifdef CONFIG_SWIOTLB
-	swiotlb_init_remap(x86_swiotlb_enable, x86_swiotlb_flags,
-			   xen_pv_domain() ? xen_swiotlb_fixup : NULL);
-#endif
+	swiotlb_init(x86_swiotlb_enable, x86_swiotlb_flags);
 }
 
 /*


From xen-devel-bounces@lists.xenproject.org Fri Feb 25 08:48:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 08:48:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278873.476291 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNWHA-0000NM-WD; Fri, 25 Feb 2022 08:48:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278873.476291; Fri, 25 Feb 2022 08:48:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNWHA-0000ND-Su; Fri, 25 Feb 2022 08:48:32 +0000
Received: by outflank-mailman (input) for mailman id 278873;
 Fri, 25 Feb 2022 08:48:31 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nNWH9-0000Mp-9F; Fri, 25 Feb 2022 08:48:31 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nNWH9-0005XF-5x; Fri, 25 Feb 2022 08:48:31 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nNWH8-0002A5-MM; Fri, 25 Feb 2022 08:48:30 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nNWH8-00037e-Lr; Fri, 25 Feb 2022 08:48:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=t+ahcvrdf9F+u1q7DPgFZHwLgKu9wuZJ93Cv9kA8LaA=; b=blwPSYn6ng9BiTmclHgtSI9CSN
	jpwidGuxEWSD4NheheaKAOrKb3mpF/ALDSGMCFpmmPD9HbZqqP0UTEcqHZaCD90Pm53F/Eo3X+n4J
	PowRo3E2HetW9zrEE78Y8kNnXjtQrm+ZQz9OSJb4HF/Agob0Znx6jVQy3w0MJ2ACV0KM=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168221-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 168221: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-freebsd12-amd64:guest-start/freebsd.repeat:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:allowable
    linux-linus:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=73878e5eb1bd3c9656685ca60bc3a49d17311e0c
X-Osstest-Versions-That:
    linux=23d04328444a8fa0ca060c5e532220dac8e8bc26
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 25 Feb 2022 08:48:30 +0000

flight 168221 linux-linus real [real]
flight 168226 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/168221/
http://logs.test-lab.xenproject.org/osstest/logs/168226/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-freebsd12-amd64 21 guest-start/freebsd.repeat fail pass in 168226-retest

Regressions which are regarded as allowable (not blocking):
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10   fail REGR. vs. 168209
 test-armhf-armhf-xl-rtds    18 guest-start/debian.repeat fail REGR. vs. 168209

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168209
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168209
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168209
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168209
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168209
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168209
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168209
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168209
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                73878e5eb1bd3c9656685ca60bc3a49d17311e0c
baseline version:
 linux                23d04328444a8fa0ca060c5e532220dac8e8bc26

Last test of basis   168209  2022-02-23 20:12:18 Z    1 days
Testing same since   168221  2022-02-24 19:41:23 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Christoph Hellwig <hch@lst.de>
  Dylan Yudaken <dylany@fb.com>
  Eric Dumazet <edumazet@google.com>
  Frank Rowand <frank.rowand@sony.com>
  Hans de Goede <hdegoede@redhat.com>
  Jens Axboe <axboe@kernel.dk>
  Kanchan Joshi <joshi.k@samsung.com>
  Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
  Lee Jones <lee.jones@linaro.org>
  Linus Torvalds <torvalds@linux-foundation.org>
  Mario Limonciello <mario.limonciello@amd.com>
  Nikhil Gupta <nikhil.gupta@nxp.com>
  Ondrej Mosnacek <omosnace@redhat.com>
  Paul Moore <paul@paul-moore.com>
  Rob Herring <robh@kernel.org>
  Roger Quadros <rogerq@kernel.org>
  Stefano Garzarella <sgarzare@redhat.com>
  Varun Prakash <varun@chelsio.com>
  Vinod Koul <vkoul@kernel.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             fail    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   23d04328444a..73878e5eb1bd  73878e5eb1bd3c9656685ca60bc3a49d17311e0c -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Fri Feb 25 08:50:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 08:50:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278884.476302 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNWIl-0001tP-Cy; Fri, 25 Feb 2022 08:50:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278884.476302; Fri, 25 Feb 2022 08:50:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNWIl-0001tI-9v; Fri, 25 Feb 2022 08:50:11 +0000
Received: by outflank-mailman (input) for mailman id 278884;
 Fri, 25 Feb 2022 08:50:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=RDkG=TI=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nNWIj-0001t3-VR
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 08:50:09 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ee6f4987-9617-11ec-8539-5f4723681683;
 Fri, 25 Feb 2022 09:50:07 +0100 (CET)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2056.outbound.protection.outlook.com [104.47.6.56]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-35-lrbjZ2vsPMmROilO78iEQw-1; Fri, 25 Feb 2022 09:50:07 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM0PR04MB5970.eurprd04.prod.outlook.com (2603:10a6:208:11e::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.25; Fri, 25 Feb
 2022 08:50:05 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.025; Fri, 25 Feb 2022
 08:50:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ee6f4987-9617-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645779008;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=87vJMMFCo73OKXazDCc7e0KRnRbAiz+e8E9jO/WlJxM=;
	b=ce97KJEf0Y8F22lMZ7g3YhEyWPfq9LOmYSNjTeflcGWb0VB0X75wDsWeJ08Ar3CWdUUu5n
	/oVE6rQc+mTaz4t5Aaio+pFICgG+TdePXcoyZ3VMsZbUcXgbBIom9mcwyFn6uhQd4AsO7P
	KvetsCQesasK3e/H3Iay74h+z5nQ7oE=
X-MC-Unique: lrbjZ2vsPMmROilO78iEQw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=WE+LCd3+9P+eWXKoMKBSglQblRap+3I4Lme/BLI6OvtBqOLoBxCGXmPP1a9TSA+ycRbwqyT7Yo0qBLhTJE2gHNcRbvFR5OpTQtjT8YlMEw5DQNUnz+SRnxb3AmhvVEe8FhbSv+B264ZHowQIqqa7mr+Tpb7zC7Dzia2fnZGuZp9e/KohzVhWG70AGrg8rUUNtpOHG+pUWKT13ChfZiHRHBYEwLjZKYMHpRHnGMk8rk+Cay+CRUVgChDRGXJkmXTlGlwycMYsC7btHfszILtlFL0HTGkju+W9hFUa3HjmK6gerLpE8fiSV/YrPrzQ7FXzHY4VDLF1SIUp3fJUrcr3ig==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=364jzE8FU/zdW/4zgsvrrBay0I6lxHePDd7eK5ROF9g=;
 b=ZrVWzNbWO5feOK65K6r7JoABBmJAAXV5tEouIO2ITJdsAE/4W35QMzCdE/iRmdTY2C2Wl4xvtSddbcoB5kVjvVwlo3ui62/DTCdYA15rdjuLvVm5hij7pnHduzqfLzigVVayrjZ74UYGRGdIbt0dFxO6c6o62Fyr2jOwN5Z/tbRhzmSaIJ+d0ZsBGdr2ou5bYVbwbCdOKE390MngosQ1ZqQONQUN7EFc6SG47b72C6KGNFFlatVabVJtGHZRPjuWj80S0sdRZMoDzb3QPkZbsV127cKEHs5RT5sEVnyCrCYtsWOr5q0qLmAB3O71bP7LtUQD7C4YzNFCjyX7ildwMQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <37c1934c-1d73-a9cd-64ba-8e004e4ca916@suse.com>
Date: Fri, 25 Feb 2022 09:50:03 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v2] pci/ats: do not allow broken devices to be assigned to
 guests
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: Paul Durrant <paul@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Kevin Tian <kevin.tian@intel.com>,
 Oleksandr Andrushchenko <andr2000@gmail.com>, xen-devel@lists.xenproject.org
References: <20220224163701.89404-1-roger.pau@citrix.com>
 <87b47562-7689-de37-f2ee-df05ef01c923@suse.com>
 <YhiWU+7Q9/Fbsig+@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YhiWU+7Q9/Fbsig+@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS8P189CA0003.EURP189.PROD.OUTLOOK.COM
 (2603:10a6:20b:31f::17) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2f739941-c08c-48a4-211c-08d9f83bd1a8
X-MS-TrafficTypeDiagnostic: AM0PR04MB5970:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB59706FB01879BB87F728809AB33E9@AM0PR04MB5970.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	0jzaolrWWi9ayROrEGCwB8rMf0tZri0Gpem6ZeMsx+bfFoyL3Yn0dcPXxK7XDlPg1wD4IWDk7RxiP5xMR3zJ4iqDI3434vo0i+yu3mVoINy43j9sQQelxDO6csFy2XBAVtUK3N/3XKsLVT2ZUtjz8XKka8+8DdAxGm7vhqCq2exuNmI5hmJGw8ehnNMe4itmZlEgdytcLI8tHgrjHp9bspx6w2hA1tUvpUmfg203Zfem0FAac1l7MgOmnRjjGuxhuWX4R9gf8NoecRJ21HLQZnIF2jMg6GOPLqLr+kvqQot4vvyH+MEHOHb6EN6ye4Xv77/5SEOG9lkoY0XpiGKUZszGXvClhgiwowY68S3ykcS/TDqTnAD5R0yVjwryXE1FLbEidE7K+AgfxpkibjaX7zOX8NL21+61zOO/Yyb3DLR/cjVbjS4LHx0CgVD3TL2BpP5vIxPDKz9yCxx9NpLmN+kl2Pd/ba9k5y7g7TBcD8D/d5k6SEncetqYtg5BWd6bEQnObbyB5oZzGxrlNl4MHXVxX/oKRHKGykgr4i3cA6xbw8YAXvlOD/XP4vBGNBJ2Gtc/i4IBOiaGD/Vw+/zgcesC3xOll71KTFENRZizj5v8SfL55Z8Bkgonp/70Isag2XzJOrb2O50szhoRTu3QLBdVDeLrZxWyRMxfH88N3PM+Pgwj6tiw+gVsccQ1iRIDDibfXkRHPDltaw6f0sAhUVUWxJ+cxMNSVoeGELzKKeg=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(5660300002)(36756003)(6486002)(2616005)(83380400001)(53546011)(38100700002)(186003)(8936002)(7416002)(31686004)(508600001)(26005)(2906002)(31696002)(86362001)(8676002)(4326008)(66556008)(66476007)(6506007)(66946007)(316002)(54906003)(6512007)(6916009)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?f0g4P2t/KBoMmDDITpFizVxCdoxoOugbpQCpgBC0YPg4ZKJqAijUEmu9Lgfw?=
 =?us-ascii?Q?YOf8B5VUmnLhaclKXxeMSnEV3qrLYtmjlrwEOOjeTB1Zyu/cbxRtK7WaPaF8?=
 =?us-ascii?Q?jylymezrIhgVm00Az6Ccl02yJdnsQ5D2FshR5ZdYkejxCxq+RjHkTqXlgVL0?=
 =?us-ascii?Q?Ot5BVf/nEBvAuulEuNyCTqAxQum3ujLNSyrwS4vV/4dxp0kMBL8Skb+Uf1QG?=
 =?us-ascii?Q?CGSPGJ9RQUHbvCQz82mNtVogdSVo5lj7tlIMbVXXKCqUaDV6VE25mXYUhdjm?=
 =?us-ascii?Q?cuRG0g/KzI4z7NdjT20q3vL7VBa9FEq5QfMITyG4dBWhpMhgCODKwzHq6Z78?=
 =?us-ascii?Q?vnPVX8Z8uUF9Uy/dXNgHyduQJOX2JD7tQmnZUjRB4YReNTF6R7vaKWxwT3bg?=
 =?us-ascii?Q?a34rBGmFqu9oF8y/ueKgMTizidV4e0CIakjJxkj25S8PujH+gFfJz9p3fzce?=
 =?us-ascii?Q?fzyfqFm8igyiRZ7zFiTEvfjbz2rpMUUwqe8r0JJyTwWelQLtohhyIpXNan3A?=
 =?us-ascii?Q?lLTv79IMUk547SkTSe92IJh/gQZ6xIs+XVX7YfIVpJGWYLSkfZqMeepOhAg7?=
 =?us-ascii?Q?WfVW9VT0lPdEP10aVCPPkns9UlipWdkJsMpI2L/X4kvjuGSEbA/vRlwuPGiQ?=
 =?us-ascii?Q?MM0jhUMTFSxh+9ABGfPoYIiC8YtcF7v0kaYQEJtxe4hkeABfG6WSKKP8Uwbt?=
 =?us-ascii?Q?JI4XyOz36e0cnPnqQl4GyBvv6ku41TbhlhEgi7qjU3xRcfvMjuxeKActGREN?=
 =?us-ascii?Q?w7Nc50T6n8P/H9+uNjLDrSjpBQYfXw4L14uzExs7KRQPbnOmwkfXgeGb0c86?=
 =?us-ascii?Q?vAsOZPSVrHimlReepAyGHM70uSvUFjy4d4N+xADMetiDgQfmxJKJ3duVty/k?=
 =?us-ascii?Q?ZM5ZxEwCbP4xhl3FDY+zSaz0Bc36k90brmUuG/FIfE8cMhrAfUfgq85IrOQ9?=
 =?us-ascii?Q?e18Z+Va4CbXDql7ZNPxAJuaWFuUCyoKpMOZxCCnrtn/7GYte30OCQ0DhkMek?=
 =?us-ascii?Q?VzSEcOqK+BPGbdLo/9JF870yZ8q4ZXnQFgKM8i4u/mEZX+K/XVRIsEwipUkr?=
 =?us-ascii?Q?rpGS/Smrx8fIPiNIPzx3HAfQ+rG/Zpu2ACgEXBN2gmHRm37XJ6bD2AdmedWn?=
 =?us-ascii?Q?gV4px+f0l384ziZDcfQunCJVGa88VlsNy9l6F1nFDs/3FjYfYf66wPqkuW37?=
 =?us-ascii?Q?wQ4AVTwQW+Kq+F5q+mZ0hlf3OGFoZl7VjH7x8mrv77ggYcfRG+7nUr2f9hWX?=
 =?us-ascii?Q?h+uLnTkKYMdN2iMQJtXPAAYz1beIOtQlFK40jhW0bvYx6QDLUTnJcSKC1EM3?=
 =?us-ascii?Q?h80ZonBTG/Hr5ebN/e12acUi4tK30332Cx7tSXvytptkVVPJBBDjCLq/SF02?=
 =?us-ascii?Q?uFo2EML676Uk02siAilkkQF/VXbxK/w4fxKG+tCjtjur7yQZ0zrcTo6A3NRE?=
 =?us-ascii?Q?1QEMxK6gBSlnJIcSn1oFotkKU1lOj3otJXR8u+sD5yzcuu9zFZuuIkVaxYtl?=
 =?us-ascii?Q?ij+lYO9X7v39sQnjBO3ofKYMMa+/am6sV3CclwbHwDUFS5Km2hklKHjOgP+8?=
 =?us-ascii?Q?QXx5nQ2QmtVVphkNtDAlEaXnpl5dn5Oh6S944jBqTCAG9pearopnIE6lmkCu?=
 =?us-ascii?Q?uEi2L+tkjaL64ZFVguv9L8c=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2f739941-c08c-48a4-211c-08d9f83bd1a8
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2022 08:50:05.5570
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: v+93EAO+fMnzHnIfs8pviD1KsYeYQB9czOrOUPGA2JxRmCngiXS4auL0xDCCYsq3jAPDOUceXti/HO/inUrniw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5970

On 25.02.2022 09:41, Roger Pau Monn=C3=A9 wrote:
> On Thu, Feb 24, 2022 at 05:43:13PM +0100, Jan Beulich wrote:
>> On 24.02.2022 17:37, Roger Pau Monne wrote:
>>> Introduce a new field to mark devices as broken: having it set
>>> prevents the device from being assigned to guests. Use the field in
>>> order to mark ATS devices that have failed a flush as broken, thus
>>> preventing them to be assigned to any guest.
>>>
>>> This allows the device IOMMU context entry to be cleaned up properly,
>>> as calling _pci_hide_device will just change the ownership of the
>>> device, but the IOMMU context entry of the device would be left as-is.
>>> It would also leak a Domain ID, as removing the device from it's
>>> previous owner will allow releasing the DID used by the device without
>>> having cleaned up the context entry.
>>
>> This DID aspect is VT-d specific, isn't it? I'd be inclined to ask to
>> make this explicit (which could be done while committing if no other
>> need for a v3 arises).
>=20
> Indeed. AMD doesn't use iommu_dev_iotlb_flush_timeout so the function
> is VT-d specific.

But perhaps wrongly so. Which is why I'd prefer to ...

> What about using:
>=20
> "Introduce a new field to mark devices as broken: having it set
> prevents the device from being assigned to guests. Use the field in
> order to mark ATS devices that have failed a flush when using VT-d as
> broken, thus preventing them to be assigned to any guest.

... omit VT-d here (i.e. leave this paragraph as you had it before),
but ...

> This allows the device IOMMU context entry to be cleaned up properly,
> as calling _pci_hide_device will just change the ownership of the
> device, but the IOMMU context entry of the device would be left as-is.
> It would also leak a VT-d Domain ID if using one, as removing the
> device from it's previous owner will allow releasing the IOMMU DID
> used by the device without having cleaned up the context entry."

... use this as replacement.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Feb 25 08:55:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 08:55:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278896.476313 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNWNv-0002cK-54; Fri, 25 Feb 2022 08:55:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278896.476313; Fri, 25 Feb 2022 08:55:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNWNv-0002cD-1R; Fri, 25 Feb 2022 08:55:31 +0000
Received: by outflank-mailman (input) for mailman id 278896;
 Fri, 25 Feb 2022 08:55:29 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=d3I2=TI=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nNWNt-0002c5-TH
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 08:55:29 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ae40d307-9618-11ec-8eb8-a37418f5ba1a;
 Fri, 25 Feb 2022 09:55:29 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 984271F380;
 Fri, 25 Feb 2022 08:55:28 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 51E0513B65;
 Fri, 25 Feb 2022 08:55:28 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id bGQNEoCZGGKKSAAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 25 Feb 2022 08:55:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ae40d307-9618-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1645779328; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Pyth/fAzjgx6z8/eOEJWgQls/CMVJkmukQkaSOGGi3s=;
	b=Ygu6aVVD1EK7Emvssq3ZYnY1lnFzRUarWcaMIg+RoZODEjb+lukIQpUlaDdEYv7vo1QaTe
	V3Ko3M7/oiyC9ZohMED8qAmEUobTjw1gUvVM2jWIwH2aIrO2+nXjSSpfuknNsokv434FNM
	MgH8HUZUVSZhaG7kL6fA2BZeXJW2lio=
Message-ID: <bb003355-1a2c-8145-e227-3799f782a099@suse.com>
Date: Fri, 25 Feb 2022 09:55:27 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH 2/2] xen/spinlock: merge recurse_cpu and debug.cpu fields
 in struct spinlock
Content-Language: en-US
From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, xen-devel@lists.xenproject.org
References: <20220224105436.1480-1-jgross@suse.com>
 <20220224105436.1480-3-jgross@suse.com>
 <15e71984-37db-c6c2-5feb-05c8f1ad85f7@suse.com>
 <05a26a5d-8597-84c6-171c-2751987b7836@suse.com>
In-Reply-To: <05a26a5d-8597-84c6-171c-2751987b7836@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 25.02.22 09:36, Juergen Gross wrote:
> On 24.02.22 17:11, Jan Beulich wrote:
>> On 24.02.2022 11:54, Juergen Gross wrote:
>>> --- a/xen/arch/x86/mm/mm-locks.h
>>> +++ b/xen/arch/x86/mm/mm-locks.h
>>> @@ -42,7 +42,7 @@ static inline void mm_lock_init(mm_lock_t *l)
>>>   static inline bool mm_locked_by_me(const mm_lock_t *l)
>>>   {
>>> -    return (l->lock.recurse_cpu == current->processor);
>>> +    return (l->lock.data.cpu == current->processor);
>>>   }
>>
>> I see a fair risk with this: Behavior will now differ between debug and
>> non-debug builds. E.g. a livelock because of trying to acquire the same
>> lock again would not be noticed in a debug build if the acquire is
>> conditional upon this function's return value. I think this is the main
>> reason behind having two separate field, despite the apparent redundancy.
> 
> You are aware that mm_locked_by_me() is used for recursive spinlocks
> only?

BTW, it might make sense to add another bool for the debug case to mark
recursive lock usage. I don't think anything good can come from using a
lock in both modes (recursive and non-recursive).


Juergen


From xen-devel-bounces@lists.xenproject.org Fri Feb 25 09:00:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 09:00:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278904.476324 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNWT2-00049R-PF; Fri, 25 Feb 2022 09:00:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278904.476324; Fri, 25 Feb 2022 09:00:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNWT2-00049K-LR; Fri, 25 Feb 2022 09:00:48 +0000
Received: by outflank-mailman (input) for mailman id 278904;
 Fri, 25 Feb 2022 09:00:47 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Zfiy=TI=citrix.com=prvs=0484f4aa7=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nNWT1-00049E-Jl
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 09:00:47 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 696d2c52-9619-11ec-8eb8-a37418f5ba1a;
 Fri, 25 Feb 2022 10:00:45 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 696d2c52-9619-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645779646;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=FbsQLOGvzoXDYqbL3/2y7ff0ve1G6Yj8lSyEZyC5L7Q=;
  b=f2gvh0lkDXqFtGDUJo1fQrTrqqeYqBM62ffhKQqh+qpDfBVu9x86Na1c
   IGmQd5TQGqhNT5nMpk6CFirL/I2BH062pN8LX2nFRqAfVDecM14959gbu
   Pu5m/++HOLGTYNQtZUPETb31ceWNI6qU5ziDYkd/EcAu6sU9N4B3F1cUX
   8=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 64867165
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Wt8WUqJv4n3NzAT3FE+RJ5UlxSXFcZb7ZxGr2PjKsXjdYENShTMGn
 WNOX2qOPvaJNGajeNAiOd7n8UkCucCHytVhQQNlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA148IMsdoUg7wbRh2NQ12YLR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 OQdp5aKEF54B/HVkvYPbSYCKmJiMrITrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBNPsM44F/Glp0BnSDOo8QICFSKLPjTNd9Gls1p4RRKiDD
 yYfQThUazvFQjluBnkeDrkUjcOlj3XfYSIN/Tp5ooJoujOOnWSdyoPFM9fLe9rMWcRcmG6Zo
 H7L+yLyBRRyHMOb4SqI9DSrnOCntTP2XsceGaO18tZugUaP3SoDBRsOT1y5rPKlzEmkVLp3I
 koY4HB29fAa+0miT927VBq9yFactwMYc8pdFas98g7l4qje7hudB2MEZiVcc9Fgv8gzLRQxz
 UOAld7tAT1psZWWRGib+7PSqim9UQAXMGsDaCksXQYDpd75r+kOYgnnF4g5VvTv15usRG+2k
 2viQDUCa6s7vJ4Z3Z/ipAH+3yumtIr3cVQMpRnYQTfwhu9mX7KNa4ut4FndyP9PKoeFU1WM1
 EQ5d9iiAPMmVs/UynHUKAkZNPTwvqvebmWA6bJ6N8R5r1yQF2ifkZe8Cd2UDGNgKY46dDDge
 yc/UisBtcYIbBNGgUKaCr9d6vjGL4C8RLwJtdiON7Kih6SdkifdrUmCgmbKggjQfLAEy/1XB
 HtiWZ/E4YwmIapm1iGqYOwWzKUmwCszrUuKG8ymkEj+jefGPCbNIVvgDLdoRrpohE9jiF+Im
 +uzyuPQk0kPOAEASnO/HXEvwaAiciFgWMGeRz1/fe+fOAt2cFzN+NeKqY7Nj7dNxvwP/s+Rp
 ynVchYBlDLX2C2WQS3XOysLQO6+Av5CQYcTYHVE0aCAgCN4P+5CLc43KvMKQFXQ3Lc7nK4sE
 qJcIJ3o7zYmYm2vxgnxpKLV9eRKXB+qmRiPL2yiZj0+dIRnXAvH5pnveQ6HycXEJnDfWRcWy
 1F46j7mfA==
IronPort-HdrOrdr: A9a23:04sO+q7R8nmTUDdkqwPXwVGBI+orL9Y04lQ7vn2ZFiY7TiXIra
 yTdaoguCMc6AxxZJkh8erwX5VoZUmsj6KdhrNhQItKPTOWw1dASbsN0WKM+UyDJ8STzJ856U
 4kSdkDNDSSNykKsS+Z2njALz9I+rDum8rJ9ITjJjVWPHlXgslbnnlE422gYytLrWd9dP4E/M
 323Ls5m9PsQwVdUiz9bUN1KtTrlpnurtbLcBQGDxko5E2nii6p0qfzF1y90g0FWz1C7L8++S
 yd+jaJq5mLgrWe8FvxxmXT55NZlJ/IzcZCPtWFjowwJi/3ggilSYx9U/mpvSwzosuo9FE2+e
 O86SsIDoBW0Tf8b2u1qRzi103J1ysv0WbrzRuijX7qsaXCNUQHIvsEobgcXgrS6kImst05+r
 lMxXilu51eCg6FtDjh5vDTPisa2HackD4Hq6o+nnZfWYwRZPt6tooE5n5YF58GAWbT9J0nKu
 9zF8vRjcwmPm9yV0qp/lWH/ebcHUjaRny9Mwo/U42uonRrdUlCvgolLJd1pAZEyHo/I6M0kN
 gsfJ4Y0I2mdfVmHp6VNN1xMfdfNVa9My4kEFjiaGgPR5t3c04klfbMkcEIDaeRCds18Kc=
X-IronPort-AV: E=Sophos;i="5.90,136,1643691600"; 
   d="scan'208";a="64867165"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=I1lRB/KIZbjjc8AhITbiQQzFHxvlrbNL76iphoNbFHbrxCOQXHuus2jdTr9Dc6ms2eZzC+xmlgcDiP2bVkiJdweC3CYsI7/shoan2QyHcqJjpuwrt0ifRKoYBXVslrcn3NIvip57uvmShopu4e9vWkBMkBhXP0nOIZ9LU+SD3F4BWBaC1UPsOit4ZBeQVKCsAVSAqPVppnoD64o0LPHv4N5DM9UQ5mpQ4Fh86t3Sv5mq9NIObx6ihpX7kM7z46gkktUwjLCc1P2dZR8x8kTxKQSf3mI0yH6XXobyz8zXTbAy/oiqc4FRReD/4NSAN7rsOIqwKk8gbV85/w9ulBnanw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=jEbboJgImCIzDFMuUIWNM1MW/+/0gagx6MuzxgoWux0=;
 b=WK5XrTxOxS3tmJ2JZmcv/uiPnQN3Q1nNeSqPNt8ASB9jS6WLvEzp5fml46AK9oJuLOuBPrFmMex3FSm33uyX3RTq+mnSvObjbKRrLX9LdfYUgXt5ocpZTrivInJS/Qn8mSrTfsCYASU28t/YM8sNzs9wtBO4orMdasnTtu+9+kVHX4LXgm9IBd+jtl9+aKv9wCrcPoQBcxEpnsbtnfnOxVG6zbFOOPtFBYODvavqFyfHXL2SvH3vVhwk5P25LrW8ECFTbYswmgn0V4IP5y2Ji8wIkc3krUlX/d6Crqu7ng3h8mmeoZeKdKXH2zrRAoQXCzPUQGpa+JrWM6+TVA33NQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=jEbboJgImCIzDFMuUIWNM1MW/+/0gagx6MuzxgoWux0=;
 b=gxyOsjVWqU4eyOfSVg1JugcvTvN0WT3OboVptKkYF2P/taRtJS9vYh1tXzjD1dGUf0VYE90Qa45/GpqzC8H0VnWGmSXR11NxnsZuJsv2JWqkLIaOhk/4isHv6T7H5rrEz75/8+ci5/o4Wx9WIUUb3ioIz1nZIBSfXwMj2Dai7J0=
Date: Fri, 25 Feb 2022 10:00:35 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Paul Durrant <paul@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>, Kevin Tian
	<kevin.tian@intel.com>, Oleksandr Andrushchenko <andr2000@gmail.com>,
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2] pci/ats: do not allow broken devices to be assigned
 to guests
Message-ID: <Yhias2g1moF/9gzC@Air-de-Roger>
References: <20220224163701.89404-1-roger.pau@citrix.com>
 <87b47562-7689-de37-f2ee-df05ef01c923@suse.com>
 <YhiWU+7Q9/Fbsig+@Air-de-Roger>
 <37c1934c-1d73-a9cd-64ba-8e004e4ca916@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <37c1934c-1d73-a9cd-64ba-8e004e4ca916@suse.com>
X-ClientProxiedBy: MR1P264CA0039.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:501:3e::31) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f254a7bc-6291-4118-8771-08d9f83d4bee
X-MS-TrafficTypeDiagnostic: MW4PR03MB6967:EE_
X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
X-Microsoft-Antispam-PRVS: <MW4PR03MB6967BE3EAF88EC05911E2F968F3E9@MW4PR03MB6967.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: Fh7n2cd7kc+aS+HSMH69hPM7+q+dK/HBjCUzstYMWlCk9VbHjSahYYQWawLKFxwVxNUK4Gb7/Voan1KwwDk4WFzD5DYuFAAcZQ1DP0hmTD1pBw+UOuK34k6KMg0p7WJJPD0i7rFMkvCp6q6QzjqsiorhT1z4x6XUTDOzVxSQyQk1qSMw+V4ZCO8Na2/6+mBtQodHR9EOuEe2QIMhRqMvF7nMi4au1q5bE95E0fDXxFJimfoNHiQdmXVSytdek994kBKPIUhS8O9C/f5Q/agBLL4BJW3k7SDvcTELD8e3yPiHzpdbQp1+PqF14TR44mMzNPmMJjYERD+GPsmRx5DGJ06BbJ5ZHzjFOT+UBJjh/hxxJRmpvDk59cUxWG00BE6+/QEGyIgtAD3bYmGtgG2u1jQncOL0gnmJZ23kVOaVob+UGLUku4cDG95ZzzkqjWmpcIAz82SEQYHBNjKIHGgre3H2XORgYU8HFRQuKQ59o6b+pBTJdDQOVA6WaEQK1OHBx9z1OIKic55FI89q0mFpxRVEEVNb/8fA0PJD38V4nCxDLUd8sOTFX5/fzK/UUGtRsnYAbgfjlYywsa45m4SUrgF1ynuuJBp2DWdKcq+8xm1FXRdXOcXZV/ybZrbwK39OPhF7lEwU7usSGJK4BJP2lQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(186003)(26005)(38100700002)(2906002)(6916009)(316002)(54906003)(6486002)(8936002)(85182001)(82960400001)(508600001)(9686003)(6512007)(6666004)(83380400001)(66556008)(53546011)(5660300002)(66476007)(6506007)(66946007)(33716001)(8676002)(4326008)(86362001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NnlmN2ZCTlFUQWVMU2ExckhsMStFcEsvbEdCekRpRG9mYXNCNTJvK1czQnFP?=
 =?utf-8?B?ODcwODFKKzFqUUxWR2kvcDh3T0ZpWE1nWnJ2K3R4WDJQZ3NoOXJYZ05YTUJj?=
 =?utf-8?B?emx4Yno2c2NmM3N6NCtCUVA1ejRhbm15QlFqcTNpdFE3K3lBSnV5TU94WU1L?=
 =?utf-8?B?dWhzOFQ3cWRKdmpzSm8vUndOT2s1R3ZtY1BoR1NDUW1qV09BUjVPVlNmNjFS?=
 =?utf-8?B?WElSVVNFQzByeFBmV0VPd0hTZ0RJTEJ5eGFLUXU1M25kT01yVkR5VGNxbldr?=
 =?utf-8?B?VFBQSWhydlRaY2xwdmZ4N1hReFdpU0hmWFgrMVo2NEp5T0FSTnZjaGp5Rk50?=
 =?utf-8?B?YmxjcEdoVG9YZ2YwVkw5WUs0dXVkbzFCZCt0dkFCdGs0cVVPdU5vSk9mMHRD?=
 =?utf-8?B?TFFNcGQvVXdlVnZUak9raWZNWVV2R3kxcnFwendzeDEyakhLZ0FsQ01HUWFk?=
 =?utf-8?B?dUNHZDBrVjZwWm1peHhjbjRYWVNFUEZtcHp2a3FjTC83NUs2cURuZ0s0Rll5?=
 =?utf-8?B?V1grNXh0clA4cERCTlRYZ3g1ZHdlNjc5aittSHo0bC83ZnpzbWdnNU5pRzl6?=
 =?utf-8?B?QzJ5c0c5cTJtOE5nM2lCSXBtNUxMNE1PK2wwOW9HK1NYdXhCVXF5Z0FOUm5Z?=
 =?utf-8?B?d2FWU09maWkycXQ5Z2d0eUJsd3pwdVhWRG5zMzI0RG1mMGpESUVaOGswZ1Zq?=
 =?utf-8?B?RXN2NkRtTlM5aHVzaVF6MDBDVS9Ra3lVRm5hYkd5L0h3Y3V2VzUwZE9jN2xX?=
 =?utf-8?B?aGVuVCthck5HRzdEUllKUWE1dFZRV09xRFBJcTQzTldiVE9wekxlRkNQY081?=
 =?utf-8?B?RkdqUEdGcTZJeENKY3ovWUZ5cjhwMXA4eE5iYW0wZjcwc2Q5bGh5SDdCYmh2?=
 =?utf-8?B?MlR0a1FIekk3V3NRV2NsZTlxZ0FJalVmRGJwelFiWFg4SEFRb2NZOEhvNXhO?=
 =?utf-8?B?VEJTa0tTMlRMckdBV3ByNXBia0NDckhoSDdKMndWR2JFQk1JRnArZHlXRDYz?=
 =?utf-8?B?LzFlZW9Td1NTMmpUZWlqc3JtUFUwMzF2WTk4Y3RlZzhrOVVOcC93WWh5Tmcy?=
 =?utf-8?B?WDJha3VlNjQvRURaVHluME0rUFhBMWlkVmlxdnBoZW16dStScXVXcDk2S3Vp?=
 =?utf-8?B?cmlaZFhvQmZ3MXk5b0pPaUhXR0RTTStWaEtrbEEzSWw5QXRwZDlwYUIzcDJD?=
 =?utf-8?B?b1hXNDlHY2hBY01rMDArSkxlZm5UeVgwSWZnN3RFSHF1M1ErZExuKys4SStV?=
 =?utf-8?B?bDJOM1RQaVFuS0tRWmFCQjl4eHBUNW1YdS9qMWUxRGNkYzJaR1E1dTJLSWlM?=
 =?utf-8?B?TVR5aWZjOE4xd3Z4SnJpQTdoMTFLcS9PSDA1UFZxeDdXQkhUWkIyc0wyTFdh?=
 =?utf-8?B?QlJBR3gwS3NobVpDcVJrbFgyMlFaSjljSDluOG15NEtCVzlkaTUvVUFROHFL?=
 =?utf-8?B?amlQVGFFVi9jVXpJeUFzL3lhNFQzb3dMMFFmTWdZcnpZRmNtRU9SNGdvU0pH?=
 =?utf-8?B?U0VGeURDM0U4aTJVMjFZVElwU0MwZElTZDc0M1cyUVplWlJ1c3loZk52RXBZ?=
 =?utf-8?B?T0pXY2QyVk1UbWR3R1ordXJCTTB2QngrVGdhNlFyczZhR0NHZE9SL0taVlBK?=
 =?utf-8?B?TGpnZm1pOTliWU0vRjFrSWpBMWRGWnN0WjhCT0xReVNhUHBQaTNoRnJCakFt?=
 =?utf-8?B?QWp5WHlOV3BuN3Z5eFQ3N29zSkhqL0lZVUJQSmcydnZJL1RUcXFJdk5SdkJv?=
 =?utf-8?B?bjFVMjhwenhQVGZyaFo1NVVrcHJDUkwwaEFQVURoWHZpK3BSVDlLZGxaOW1h?=
 =?utf-8?B?M29wd2c4OXFaNWMrZ2dsRlF1eldsMDBnM0MwVTZhQ0lrSTErbVAwNXlLeTJ0?=
 =?utf-8?B?Rm1hWlRxSkZ0VlA5ZUhhajJPQnNzR0thZDZrWXVwS3ROTUpSMi91YnBtQk9L?=
 =?utf-8?B?MThYVVBscmxaUURjZExSdjI5MmdxM0gzNkRDdVlZd1dXUzF6SzJXOWFvcmJN?=
 =?utf-8?B?OUI5YmZHcExhT3dZdENFeHltanlqazkvWWRmNCtVczBsTzBoU3NTeGtlV2RE?=
 =?utf-8?B?WUF2bll6bFhXbGQwdWtya2tEN3hCR0QrL1FvcDdCM1ovT2tsNnpHamZDNkxK?=
 =?utf-8?B?SUVYNSswT1h1aHBJT2xqWTg0YmZaUVNDOVVsbG5YdlhnbUlrV2ZvcmcvaEJE?=
 =?utf-8?Q?9OjbCptRTYKDxNlRvZ9Vpco=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f254a7bc-6291-4118-8771-08d9f83d4bee
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2022 09:00:40.1190
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3FQVQHm6bHLmFotQ5j7MQqelzy5F8Aplw6CMIXKLGBWvXryS3dHADq+QUMucgHdMWB/ZAkQgavNaS26eTdOQ9A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR03MB6967
X-OriginatorOrg: citrix.com

On Fri, Feb 25, 2022 at 09:50:03AM +0100, Jan Beulich wrote:
> On 25.02.2022 09:41, Roger Pau Monné wrote:
> > On Thu, Feb 24, 2022 at 05:43:13PM +0100, Jan Beulich wrote:
> >> On 24.02.2022 17:37, Roger Pau Monne wrote:
> >>> Introduce a new field to mark devices as broken: having it set
> >>> prevents the device from being assigned to guests. Use the field in
> >>> order to mark ATS devices that have failed a flush as broken, thus
> >>> preventing them to be assigned to any guest.
> >>>
> >>> This allows the device IOMMU context entry to be cleaned up properly,
> >>> as calling _pci_hide_device will just change the ownership of the
> >>> device, but the IOMMU context entry of the device would be left as-is.
> >>> It would also leak a Domain ID, as removing the device from it's
> >>> previous owner will allow releasing the DID used by the device without
> >>> having cleaned up the context entry.
> >>
> >> This DID aspect is VT-d specific, isn't it? I'd be inclined to ask to
> >> make this explicit (which could be done while committing if no other
> >> need for a v3 arises).
> > 
> > Indeed. AMD doesn't use iommu_dev_iotlb_flush_timeout so the function
> > is VT-d specific.
> 
> But perhaps wrongly so. Which is why I'd prefer to ...

I thought the same, but didn't care enough to try to fix the AMD side.

> > What about using:
> > 
> > "Introduce a new field to mark devices as broken: having it set
> > prevents the device from being assigned to guests. Use the field in
> > order to mark ATS devices that have failed a flush when using VT-d as
> > broken, thus preventing them to be assigned to any guest.
> 
> ... omit VT-d here (i.e. leave this paragraph as you had it before),
> but ...

OK, it wasn't my intention to make it sound like this is not required
for AMD, just not used ATM. Was merely trying to reflect the current
logic in the text.

> > This allows the device IOMMU context entry to be cleaned up properly,
> > as calling _pci_hide_device will just change the ownership of the
> > device, but the IOMMU context entry of the device would be left as-is.
> > It would also leak a VT-d Domain ID if using one, as removing the
> > device from it's previous owner will allow releasing the IOMMU DID
> > used by the device without having cleaned up the context entry."
> 
> ... use this as replacement.

Fine.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Feb 25 09:14:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 09:14:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278911.476335 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNWfp-0005fB-V1; Fri, 25 Feb 2022 09:14:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278911.476335; Fri, 25 Feb 2022 09:14:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNWfp-0005f4-Qs; Fri, 25 Feb 2022 09:14:01 +0000
Received: by outflank-mailman (input) for mailman id 278911;
 Fri, 25 Feb 2022 09:14:00 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=RDkG=TI=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nNWfo-0005eh-0P
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 09:14:00 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 436d0a82-961b-11ec-8539-5f4723681683;
 Fri, 25 Feb 2022 10:13:58 +0100 (CET)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2056.outbound.protection.outlook.com [104.47.6.56]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-29-9ki6KQL-OpeMvh6mcDAr3w-1; Fri, 25 Feb 2022 10:13:56 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by HE1PR0402MB3449.eurprd04.prod.outlook.com (2603:10a6:7:8a::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.25; Fri, 25 Feb
 2022 09:13:54 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.025; Fri, 25 Feb 2022
 09:13:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 436d0a82-961b-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645780438;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=TrTFREjytDbzqeDL8ZkSTClwJ54uo6X9ShAXL2biEHg=;
	b=UM2KkVzro5c3iDk3NRPJEVIG1yLb5Hr7z7fseNgu15C1R849YhYWAPY4KXPtNdsfstcBCG
	ziLVS3Ktnp/POYfMu16z7ALDFeCoMRP0MQl/JoXzlmrrs1G7Er/TYbAlPUOA7YMsoQ1KPJ
	IS2dlWzeXdsLyBbzB49HgAqG4ZJd3rs=
X-MC-Unique: 9ki6KQL-OpeMvh6mcDAr3w-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=R6NNch5Is1TkuOLcMWFvC166AZcQ1AX6BPbgKYHMNRq5VHUGxxXx31rGdPpUv3qnMV51qd1Zxk3JQTqioL8kOTD0Nj/jRkct54QubbKJT3jlqWWnSTRjravfzrdtz06wD2O4nI0R29AP5erJStpMAAl2JwM+ACoVCeC35ksyTXC2cTvAeFdGg43GfIU4tJ736Vfh4O/T65REnCwY7Qs7TQiZQmNMPn+ebmw9p9vQkg7+DQn9GAI6y6ee2nqYEpeYx028jTjjDE+so2TE5YfLtMoCzWyfApGCdB4gLAGpV6Xm46TqM9UkjVX81z7yMvYAWHkeiJdPzQwJ4RFKkFG1rg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=TrTFREjytDbzqeDL8ZkSTClwJ54uo6X9ShAXL2biEHg=;
 b=EukByAmETfc/cFH2lXFS4fc/yxdVYzpRuZCMTvnG4zRIyDY6xoJpUNfpAS68ouPAsrBZsjTfrPSc45lFe6ZVScD5MibuPdViqDycYzJUlzNurgDeW/joa2OePeyY3NXNd/YZegOMzVXKF22MuKCO3aR8XJGY2CQTrkjpmm8n6dmEzMvuq6hy1FTsQ/TBlA0yFZ80FvIPLXhBs+TgQA8PkobG3qZTUZmaL5fKBxJEIQwyPbRvM4UFfjAkpkGuadjRVabjL7YmhQP6OgYJGQd+3MUZvFMbj6+wi5ocVphcEOH4KiWDW56lrEANPSnSdHB7biCCUfjzIh8qPfnBWDYGlw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <9761efc1-15c9-0d5d-95c3-217bb5054853@suse.com>
Date: Fri, 25 Feb 2022 10:13:51 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH 2/2] xen/spinlock: merge recurse_cpu and debug.cpu fields
 in struct spinlock
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, xen-devel@lists.xenproject.org
References: <20220224105436.1480-1-jgross@suse.com>
 <20220224105436.1480-3-jgross@suse.com>
 <15e71984-37db-c6c2-5feb-05c8f1ad85f7@suse.com>
 <05a26a5d-8597-84c6-171c-2751987b7836@suse.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <05a26a5d-8597-84c6-171c-2751987b7836@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0402CA0003.eurprd04.prod.outlook.com
 (2603:10a6:203:90::13) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ede18e35-fc9f-470a-d68d-08d9f83f2542
X-MS-TrafficTypeDiagnostic: HE1PR0402MB3449:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<HE1PR0402MB3449AD13635A8131C5342358B33E9@HE1PR0402MB3449.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Tg9aiWzoBkb/zN9z4bGIvjCPO7eDPzz/0CWBoYsfDJeHIs00/z8Y/qMsa1drlNGx6idObPiFPbWjXK3rNfCYPUO2DnEqtHLMaTihaKB90viQ3u2r5ng6u9zknDg68yH/XORLf6L1MGHB0uc5OHDyrM8z7AHQEGdOuKJLIW2nxL6ReDk5yGXsbbyRLcI/EljXSDDgnbp01S7wmDhHL1NF3J6UKTWCBDcAGVV1EeX1A6aeE79UEQMCWqxcAVjtWS3TxoDK5cR6z6Tqs4yNSDCJtJHhG5UwcQ8WBF+5q++gTU06MvL5QlRwzrVT4aEj2jpL+HHepKLiHuZnKSApvx7Jm1rSXTO/arJptZozHK3L1dzK4spqJyGXfP+fKUD80IafAcZY59b9wICDmzOBAdDJzIM1tscsZuvHRf4759cnJ2PF77Jk4RAqQ4cZK7a1WQ91Ze4Haj7nMieXyVV03JH6hsDtsCEVPtbWJhAxjWffWnquif083pmAUfsKcS9DxKZKLNJMmQNu/MGKUt2EOZKtdWwToOc8uD+L4Qhkwk6ZrK4i9W7foDgUG51UVQlHs9kMX3vJaP9uF+qoQQp4TLSgqx8W3o0Qyr/utcmApmVMRJPe+gv1W9iVBSExQpDDcen2xhInm+qOOinPktKYCyLlFqZ6jALPSojxkCSjimWg922zONOUlEmHAJSEJ1Tq6hAxEJpUWZ+G60zicrAvVPdHIKvq+QX+V9AH6KUIjT+XamU=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(86362001)(8936002)(31696002)(316002)(38100700002)(66556008)(508600001)(83380400001)(186003)(6636002)(26005)(37006003)(54906003)(2906002)(66946007)(4326008)(6862004)(8676002)(6666004)(66476007)(2616005)(53546011)(6506007)(6486002)(5660300002)(36756003)(31686004)(6512007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?MHVEcHNWZzJ6Wkp1SXRkWGJMYk43dm5iR3N3NGplTWdST09oVkdhSzhBeWdP?=
 =?utf-8?B?UWZ6bjRVVlFzMnhnWnllaVBPdXdyeXNvb3hVQkFGb0I4WXU5M1cxQnVJcEg4?=
 =?utf-8?B?U1BZUURWYmczUGc2aXVNZzNWOHFCazhtUmlMZ01HeGl3bVh5a2E4SUFGa3Fm?=
 =?utf-8?B?VFh5VlVQbE1mZVJwamFhMDBDbzZFckpJckhxeDFNeWtONXVuclMyUWxUZ1Vy?=
 =?utf-8?B?UDR4YmY0cXllQTlnSFk3NkQram9QeXJlTXB2ZlJ4K0NSMkd3bVNab0N4QmhY?=
 =?utf-8?B?ZXFOUi9BRWNLLzVlL1FwZk9iTk5oVnVPd2dEYmQwTUFMYTJRaUt2QmlXN1Y2?=
 =?utf-8?B?ZWg5U3lyYkQ1MXlHdFYyaTR2RFFZenAxc1h4NytuS1ZybHIxMjNTYkhNMGI5?=
 =?utf-8?B?c1pWc0x0cHRCMmZOMktPazZ0ZHU4Y3kvSGkyQXJ1bGVxSkZmY0RqZy9WQkhZ?=
 =?utf-8?B?UUFJNXZjOEU1NVN4YWppZ1JqTWhsVGJ6VWFkbnBKZU1OempGQVhtM1htTUhT?=
 =?utf-8?B?cUhqdXcwUDRKSkxlWXBmL2ZWcktGUlMyc3hVd3ovWWFuM1FLM1B4bXdTd2ht?=
 =?utf-8?B?dVpaOXJLdE5lazJ3aUwxVURoeHVuejRHejJoa2ZLRFEyclJTeXh0a3hsUHZN?=
 =?utf-8?B?d2J5LzdsbCszRGE1ZGthdU9oR3BtalpLbHlYQks5YnhZdFN6S1NUVDIrWkI0?=
 =?utf-8?B?eFQwT21LbVZBZ2dtTmQwMmhxbjhiZ3htNUNROHhxK0hIZUM1UUJQa3hkK0gz?=
 =?utf-8?B?bm5sQkVCWEswNHkxaEFXMEltRngzVFFkcktmcm9icW1SVyt5Rk8xSGUrbjhO?=
 =?utf-8?B?Z00wZVlLekx1TEt2a0Q4RzRrN0FFOStTSWNPdEtmeEE1WDk3UlV0QmpTMVZC?=
 =?utf-8?B?aElVNHU1OWxnb3pDd2hNa0FFR0FtSFFrdm81Y1k0Y1RMSkI2cXNGeS9oNVBu?=
 =?utf-8?B?eDRGZWg2aThWMlduMlpGK2NvcGw4SzBTZ2Zzd1pkOGxRUlhaUzB5MFRIMHVI?=
 =?utf-8?B?cFdvb212blBqNnNSUzRvRlZodEZtZ1dGUDJ6bzR3R0F5cnBQVTM2a1UxYmho?=
 =?utf-8?B?b21pVWk3b292TEYxTWc3VDZGMUJKeWRYZ0I5TkMrZzQ1N09PNDdjMnlSUEhN?=
 =?utf-8?B?VjJ2d1Jhdk5ZaFIwRDhOOGk0N2tXRGd6V0FhV1d4MzJESlhJM3daQlhEREd3?=
 =?utf-8?B?Nkt4RC9Tc09EbERoUWtsQkYvTklzV3BSOVFoQTZWOGhrUEd2Uk9CNmVXM0ZX?=
 =?utf-8?B?TGJwbndPenBjcUJzQmxuMWpOOW9uRkw2c3NHVVlvY0o0WUdQTi9tY2ZwNm9Q?=
 =?utf-8?B?OVZFS2ZodTNWbnlVVjlqZU9jTGNZR2tqU2VMM3VEVGRpWHk0YmxFUWpNVllw?=
 =?utf-8?B?aUR4YWF0MXdxZlBZOGV1QmpBSWhUR2VvMUV4ME5meHZDang0UDVpa0JRVHdD?=
 =?utf-8?B?K0RsVFlGTDB5Wjhja2E1RVFlYWtNSXdNOUIxOXhSd3JnQTJuaTZmTk9GQlFi?=
 =?utf-8?B?emtvZHE1VStWSFJYWmR4cVg2N3J1QnY3VmZlR2lNVFRNMW1wRDdnZ24vTW5k?=
 =?utf-8?B?dUd2OFU2a0VsUGdvakdHSUdzenNncUFqWE9TZkNWenJlRTRJeG44OWtBUk54?=
 =?utf-8?B?dS8vVGdTWUw3VUh3cEVRaTVpd0R5dFBnWm1ZZi83S1FkLytjQW4ySEFjNUtH?=
 =?utf-8?B?bFoyek4yaVVhQy9wRzV0b3kxblJoeUdoMzVhOFk4ZGplWDFFaFUrOGdGTGhi?=
 =?utf-8?B?UHd6b0dTVytNNFNBN0ZZMFBBNnlWQTViYjBkM3hoK2EwY0lJM3ZNRWVZMlU4?=
 =?utf-8?B?dndWMlhjcU1iQmF1Y2xKZ0kvSkdXLzl2UlVpVzY4eUpWYjN6UzNNOVhBMENt?=
 =?utf-8?B?djF1UUU1UVhOVjZ6aWRFUFBqbDhJc0tuMWwzbnduanMzSHN4NU5NRlNoNHUx?=
 =?utf-8?B?Y2xnNmZ3QTdhN2FLYndCZlRCNm5JUExTSSt3OTJJSlAwNitoOUFCRWRlY3Fx?=
 =?utf-8?B?azdBL0lrcXIxWnZxZzQwaUN2WmJKOENBVGEzTXA4Ymt5QlF3UU5XUjgrOWVv?=
 =?utf-8?B?NzRNVE96VXFiMndKYXBGYmlBSzJmckNjcnhkc1gyM24zMzRCNk1HbzYyeFJy?=
 =?utf-8?B?VStiQ3I3Yy9iSlk5VG9NMGpsaDdLRnRtVkZ1czhJYjA3Q3dSanFKNHBaajkz?=
 =?utf-8?Q?Eypw/OKlYZRjrLR4he+KLOU=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ede18e35-fc9f-470a-d68d-08d9f83f2542
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2022 09:13:54.2807
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OcLNLwoJP27c4kRC+BSSJQMhSSjPOqAXcP5uQfovvgppmBpipuoKg3ZbgSA7naeEoprSNRn5UGp9QmUHabAoAA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0402MB3449

On 25.02.2022 09:36, Juergen Gross wrote:
> On 24.02.22 17:11, Jan Beulich wrote:
>> On 24.02.2022 11:54, Juergen Gross wrote:
>>> --- a/xen/arch/x86/mm/mm-locks.h
>>> +++ b/xen/arch/x86/mm/mm-locks.h
>>> @@ -42,7 +42,7 @@ static inline void mm_lock_init(mm_lock_t *l)
>>>   
>>>   static inline bool mm_locked_by_me(const mm_lock_t *l)
>>>   {
>>> -    return (l->lock.recurse_cpu == current->processor);
>>> +    return (l->lock.data.cpu == current->processor);
>>>   }
>>
>> I see a fair risk with this: Behavior will now differ between debug and
>> non-debug builds. E.g. a livelock because of trying to acquire the same
>> lock again would not be noticed in a debug build if the acquire is
>> conditional upon this function's return value. I think this is the main
>> reason behind having two separate field, despite the apparent redundancy.
> 
> You are aware that mm_locked_by_me() is used for recursive spinlocks
> only?

I will admit that it occurred to me only a while after writing the earlier
reply that it's used only with recursive locking, due to _mm_lock() indeed
using spin_lock_recursive() unconditionally (i.e. independent of its "rec"
parameter). Nevertheless I continue to have the vague recollection that
the duplication of the two fields was intentional and deemed necessary.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Feb 25 09:24:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 09:24:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278928.476349 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNWpk-0007KS-2K; Fri, 25 Feb 2022 09:24:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278928.476349; Fri, 25 Feb 2022 09:24:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNWpj-0007KL-Va; Fri, 25 Feb 2022 09:24:15 +0000
Received: by outflank-mailman (input) for mailman id 278928;
 Fri, 25 Feb 2022 09:24:14 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=RDkG=TI=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nNWpi-0007KF-KB
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 09:24:14 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b190b7e8-961c-11ec-8eb8-a37418f5ba1a;
 Fri, 25 Feb 2022 10:24:12 +0100 (CET)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2110.outbound.protection.outlook.com [104.47.18.110]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-22-_OZx9afaNg2i1ziCCeO9pw-1; Fri, 25 Feb 2022 10:24:11 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM0PR04MB5778.eurprd04.prod.outlook.com (2603:10a6:208:133::25)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.25; Fri, 25 Feb
 2022 09:24:10 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.025; Fri, 25 Feb 2022
 09:24:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b190b7e8-961c-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645781052;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=8y74vp+z9psfLiuDEpwZUnEeuw8kGNyBqdnHkkA7Pxg=;
	b=Sog18XyVdFM1fVYlwj8qDF6aOirrX6MAc1N96R/I5pPT/FRSyHof9VByMBXrkWFmkmDBg8
	daAc13aeyrZlSU9goDBZNH52Sz9COc4/tOupxghzv1KbvigdHV2xpVwo/dtXqSwLQIj1q5
	goewieLcvOri07+BKI37lur6+DERO10=
X-MC-Unique: _OZx9afaNg2i1ziCCeO9pw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=GT7+TzpRkI48eP1VQ8fC2Ih8YTcAVhJzj3hGk3h5VporWEzE8oVpIW8i6VYlEIsozFDs7oHs0LyAwQwLqYZTVC0Q0F5PyeE1bN/RnNu2c7Lrl7UMocmqnTyg9WBlundGJ+m6N+RDYrSZ7bOSU4KcDhe/id4wtiguPcOfO+b4KG3nzBAgJjhTgomsGds+DITQxZ9W3g0gTi91M8wwtLVgPgt/zL27/nWiF65g7OitF/h8MI2DZACvp0DdQqTmt0bRaNcPbR28NFAw4HC091araoC60+rcNVQGirA/Y7fTf2now+Nt9O9UUH7Yx1dkPP18S3UksNZDEiIN199IjYN1Mw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=wHWYKZ9o0K97kUOYCXLO7HOm1sIUmATcrVHMotVnOP4=;
 b=N/2rkqEhuXFp8Nrn+i+XFcudZSbSEvnOiXHXLAJOD4D9SYe144F3Rqn81Wz8bfxz+MhDHkkbWd01ZLmAnxMBKEnoI8TQ8CX5Inixunl009aOzG8tliiwp6/xCiO78q+xozUNEUCWi9xRZ5niRhDn3YpCdOi8TgI2Nl8xXXdVfgzDGB3vW+H9tkg4HP5F7QrzyjbGx75AG1vjKTJSuzighUUXPxTtERx1uqyrtmU8o0ePf6hVXiislvOuSxaHPJlDZnuvDsoOxdyJMndk35evTXFQcs58/UfNVkdRTqMqwRB8W63HrPGSriDl6Poxld1cFadaw+rtTUuIepxBvjYN9A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <1f848da5-7f02-e380-a616-bff785520a90@suse.com>
Date: Fri, 25 Feb 2022 10:24:08 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH 2/2] xen/spinlock: merge recurse_cpu and debug.cpu fields
 in struct spinlock
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, xen-devel@lists.xenproject.org
References: <20220224105436.1480-1-jgross@suse.com>
 <20220224105436.1480-3-jgross@suse.com>
 <15e71984-37db-c6c2-5feb-05c8f1ad85f7@suse.com>
 <05a26a5d-8597-84c6-171c-2751987b7836@suse.com>
 <bb003355-1a2c-8145-e227-3799f782a099@suse.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <bb003355-1a2c-8145-e227-3799f782a099@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS8PR07CA0045.eurprd07.prod.outlook.com
 (2603:10a6:20b:459::16) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 3598acff-eff3-41bf-ed7e-08d9f840944c
X-MS-TrafficTypeDiagnostic: AM0PR04MB5778:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB57781A0585EFDBF63E52D067B33E9@AM0PR04MB5778.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	TjkvKhqZ2SdTzvo4ki2dZmlDx9J50+8TikT4o+JmyVF/gFGTrsYOiDcEWV2mOIVyTf0nwZLB+MNoMHNn6m12NuPw8j2PS9/9Z8LK4HqdrsVxy+Hysa8cwW4ciQv0JVv8D/oc16SKsX1OWqSLybdGgRwZTL+y+bJHMZ/WLj478AFc3IC5KRu5zQ67HREr4enkxnZqf8QG4TSgS0NOS62Wordy5u/dSNTmdJto+zDYU7DB77Z/YxlFkNa5tyS7Bc5em7ZKOKBP5YkmuYD12a6/UZPVFTYtewcnIX473guA5nY/BoexId1Idw3vMvBLpQPOTskeScjh3bBP7rwqdu5K1RdYiZBz3dNLVo1IhcJUX8irE/3f9S2kj6/yVM1Gdwj5D94Yn4Vw5l2O4s58mI0DEMNvLj/EaRBAdgKx/TODjgm/bD4l5pSGE/EbFv8t+THICmO/heY0nRDj+MVP5hSU2HI/xagxBGpXIKQHwF2IVFRWBr0odbEjwp4qLzTo1m24vfA+l7vJO+Uvg66YIP/4QoxJqJvnx+1LgakCz/5AIyGIz7bikA0ItXgqyuobD/dOCzTSySKNST1KPbWv9hGc0vRHsDBE3BDM7W1ktlOhz8/yzW0Q6Din99nf5UkJ8ICRPTvcRaKQckSXczRB50AD9+v+gSIDf/qK5fVq+mUbB63+bh5IQ2GuNOFeYxiKyjvtbUfxFNWmEYyFWViFaLnHJJtDS7ZEFP11Yz6di1nCHrG4WiDA++sZpNcjJ06UsB7+
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66946007)(66476007)(8936002)(5660300002)(31686004)(6862004)(53546011)(316002)(37006003)(8676002)(4326008)(66556008)(54906003)(2906002)(6636002)(6486002)(508600001)(36756003)(6506007)(6512007)(83380400001)(31696002)(38100700002)(2616005)(26005)(86362001)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?4af5jNj/mOPQd5htNCxQnrwaDYz0Kw49AKDk/f3g9EUC+ahCAJq45rni3TF6?=
 =?us-ascii?Q?o9sLuuzZ/bRCN2b4ZZgmDbiP6p84P6MoB1J26v0tEmkP6CDi39box2Dd3sVF?=
 =?us-ascii?Q?oaFFWmR1Kf1Eg2DhvUuvKflBism6oljFCL3OTK7VjFTPC8VNB8GFY7nNsKwy?=
 =?us-ascii?Q?pUg8XYNcdrl2S1ezVp239y5FGvj4LwmK8NHiTnrCs0awLHmFLY8x6m6QHZni?=
 =?us-ascii?Q?QqcKiSDo34ivcsaKvpQzD1w+3cP9EH94gKuMbYw+3eR6hXvT90Hz6E19NwzG?=
 =?us-ascii?Q?U1e8hU4JiVYzMV0YjXHhMbB0J1BCxZ5LsWpv/lJPRcI579BoBI5szRK9wbkt?=
 =?us-ascii?Q?ZthUN8r2IAoK9zUpE+0hZ4wCTqNS2Nr42buXvIv4cAq7616ElKcUgMnQAqh4?=
 =?us-ascii?Q?1QBs0JEUI28eo/joDZ5zT/cnIO/iLpv84NkZDLnWcVJ2ewZU1FBm6DJLd3zW?=
 =?us-ascii?Q?fw0xd0UMwbdSPfUu3Ms/XckmeCqosXj5KQkkG2TseIv568WUE+sGiPz7Ssyd?=
 =?us-ascii?Q?U5PZ1hNI8M+jlvUuQ5rXJxnBizZKOh1rLpGBEEcd0T8BlP7l2FlAigZGLXiQ?=
 =?us-ascii?Q?CInLmYhR7dAUVuxGl9pqz9ohs2wVqkt4EJDuQnhTjOXZ95uut7tYloot/Rf5?=
 =?us-ascii?Q?kio18UO7pR0dpIpacYE7A+/nPMrk8i8460MM6M0XGRh/mFJiRUEchXVGrz72?=
 =?us-ascii?Q?D3jAHyUt1Q8BVDe1GVrnviHsfUmmkagCUca/PNFgO/lf4G0qhqZKn/2Wphv3?=
 =?us-ascii?Q?FIFzv6XnguTRtXlR3to81sSsItJvZnKHrpcqq6ErH7el/eHOQqRBTs3TH1MM?=
 =?us-ascii?Q?eM8UG3Lf/tTWHggiy3TkIX7xByk5RpMr++oHw2Gvhvoo7b8Bl7RUDgyerSXE?=
 =?us-ascii?Q?FYnlmxGYhI0r1y8RhvtH9Q6Gjt+HyrvG3NFfKQDk1dKZ4tKpN4QleIsx7D+U?=
 =?us-ascii?Q?IFQs7UXsl4vAo84mIjMKO0KZfvitbRQpEDPGCCsl0i+QEGrv0fQNwqzLLsNs?=
 =?us-ascii?Q?hzSY1MJiwZ4zGqUmtugUcwaipHhvGOQmYEy6jRb1CicKK8eRzgk4xkqjSLGu?=
 =?us-ascii?Q?yEwILLdgOZAdo86wSGE3wN/mHaVnJvl4jg6gGT1HSyfhawTDx0f5+akkFJxW?=
 =?us-ascii?Q?Mjj/2dcS1eQ+G8rHqn8Z+uiDLLCb3wutgO8DweoUVPw5BQYGjWQtY5qd2Kae?=
 =?us-ascii?Q?B/CWBgHvNxXfPlbRb5rwgAbPOota5z9O76xY9yyrTaEv4a88tKLSK2IUY/gB?=
 =?us-ascii?Q?rNg+JYVjWbuHMnAWiW7Fqm1elq5cTd/lW5QkcELaQMZOf4WHAKM8isJKjNSv?=
 =?us-ascii?Q?tobLineHOxSrHC4v3co/xsOSCuUKAQLL3l/Ycs3ZvZlAbpGqHziqMrdOIzRz?=
 =?us-ascii?Q?MC3OUcMTbLtFPXlU40yXi9TiprwlejY1I5zy6hGctteCnje3zmsLZnNr8TWw?=
 =?us-ascii?Q?hTzwaySfo1zAGKXDWUUbq+J4iZLL1QrEm71NgHkRPOzDP0IwrfbhaqOlG01n?=
 =?us-ascii?Q?rQhnCF9ZfHvykAb57SzVvgxy6aj3bsVep4Ft73u1wpiCrE5SebTnjetUOhWJ?=
 =?us-ascii?Q?4WTM9jx9uG0sjxDwxeVXhfeHnHoMDSUWotPm5Nz6PiMc8ASUSYdZZNlUytAS?=
 =?us-ascii?Q?8DVCXT8AemkK1nE3kUnrVJU=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3598acff-eff3-41bf-ed7e-08d9f840944c
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2022 09:24:10.1019
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zWgMJFYbX6xbCGA2F+InvUR4IDabXmij8XEW2sO3dRobsd/nyRmL/Hx/FScaW3Hi07hxQtpei1vrQk5l++dCiQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5778

On 25.02.2022 09:55, Juergen Gross wrote:
> On 25.02.22 09:36, Juergen Gross wrote:
>> On 24.02.22 17:11, Jan Beulich wrote:
>>> On 24.02.2022 11:54, Juergen Gross wrote:
>>>> --- a/xen/arch/x86/mm/mm-locks.h
>>>> +++ b/xen/arch/x86/mm/mm-locks.h
>>>> @@ -42,7 +42,7 @@ static inline void mm_lock_init(mm_lock_t *l)
>>>> =C2=A0 static inline bool mm_locked_by_me(const mm_lock_t *l)
>>>> =C2=A0 {
>>>> -=C2=A0=C2=A0=C2=A0 return (l->lock.recurse_cpu =3D=3D current->proces=
sor);
>>>> +=C2=A0=C2=A0=C2=A0 return (l->lock.data.cpu =3D=3D current->processor=
);
>>>> =C2=A0 }
>>>
>>> I see a fair risk with this: Behavior will now differ between debug and
>>> non-debug builds. E.g. a livelock because of trying to acquire the same
>>> lock again would not be noticed in a debug build if the acquire is
>>> conditional upon this function's return value. I think this is the main
>>> reason behind having two separate field, despite the apparent redundanc=
y.
>>
>> You are aware that mm_locked_by_me() is used for recursive spinlocks
>> only?
>=20
> BTW, it might make sense to add another bool for the debug case to mark
> recursive lock usage. I don't think anything good can come from using a
> lock in both modes (recursive and non-recursive).

But beware of the coexisting paging_lock() and paging_lock_recursive().
Albeit I guess your comment was for spinlocks in general, not the
mm-lock machinery. Yet mentioning this reminds me of the page alloc
lock, which different paths acquire in different ways. So the bit
couldn't be a sticky one.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Feb 25 09:38:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 09:38:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278935.476360 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNX3C-0000V2-9l; Fri, 25 Feb 2022 09:38:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278935.476360; Fri, 25 Feb 2022 09:38:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNX3C-0000Uv-6K; Fri, 25 Feb 2022 09:38:10 +0000
Received: by outflank-mailman (input) for mailman id 278935;
 Fri, 25 Feb 2022 09:38:08 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=d3I2=TI=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nNX3A-0000Up-TM
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 09:38:08 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a348eeac-961e-11ec-8eb8-a37418f5ba1a;
 Fri, 25 Feb 2022 10:38:07 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 5B7431F383;
 Fri, 25 Feb 2022 09:38:07 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1C76613B8E;
 Fri, 25 Feb 2022 09:38:07 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id U4KZBX+jGGKMXAAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 25 Feb 2022 09:38:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a348eeac-961e-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1645781887; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=iNLXfuS1ukocf3UH1KS7ZzMQvS+SNsfrjBM5tEj5qRA=;
	b=o5biQv3HxM9thzO9cACj+Iuh8Xauas5K7daH4kcO0sYYa3z6tuKffzCUJDDosnLwC2Y9JN
	SDMjhedtqSGV2edEYkFrRJZNTB7iNAVmImpbQRvH+bvZc4F3wLgw4QPuVgGuymti0kkjK9
	L+fj+Ez2si7JUTUqE/9F75SMhex79cM=
Message-ID: <f10818fc-1059-692f-caf3-5fbc1e304855@suse.com>
Date: Fri, 25 Feb 2022 10:38:06 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Content-Language: en-US
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, xen-devel@lists.xenproject.org
References: <20220224105436.1480-1-jgross@suse.com>
 <20220224105436.1480-3-jgross@suse.com>
 <15e71984-37db-c6c2-5feb-05c8f1ad85f7@suse.com>
 <05a26a5d-8597-84c6-171c-2751987b7836@suse.com>
 <bb003355-1a2c-8145-e227-3799f782a099@suse.com>
 <1f848da5-7f02-e380-a616-bff785520a90@suse.com>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH 2/2] xen/spinlock: merge recurse_cpu and debug.cpu fields
 in struct spinlock
In-Reply-To: <1f848da5-7f02-e380-a616-bff785520a90@suse.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------QpKzCzDVOqB0OkwmxxL2v0bN"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------QpKzCzDVOqB0OkwmxxL2v0bN
Content-Type: multipart/mixed; boundary="------------ZRkGchB2SOBf7AeKXTDrteLE";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, xen-devel@lists.xenproject.org
Message-ID: <f10818fc-1059-692f-caf3-5fbc1e304855@suse.com>
Subject: Re: [PATCH 2/2] xen/spinlock: merge recurse_cpu and debug.cpu fields
 in struct spinlock
References: <20220224105436.1480-1-jgross@suse.com>
 <20220224105436.1480-3-jgross@suse.com>
 <15e71984-37db-c6c2-5feb-05c8f1ad85f7@suse.com>
 <05a26a5d-8597-84c6-171c-2751987b7836@suse.com>
 <bb003355-1a2c-8145-e227-3799f782a099@suse.com>
 <1f848da5-7f02-e380-a616-bff785520a90@suse.com>
In-Reply-To: <1f848da5-7f02-e380-a616-bff785520a90@suse.com>

--------------ZRkGchB2SOBf7AeKXTDrteLE
Content-Type: multipart/mixed; boundary="------------WzF0esdaANed5qvi8jCcW0N0"

--------------WzF0esdaANed5qvi8jCcW0N0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMjUuMDIuMjIgMTA6MjQsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAyNS4wMi4yMDIy
IDA5OjU1LCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gT24gMjUuMDIuMjIgMDk6MzYsIEp1
ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+Pj4gT24gMjQuMDIuMjIgMTc6MTEsIEphbiBCZXVsaWNo
IHdyb3RlOg0KPj4+PiBPbiAyNC4wMi4yMDIyIDExOjU0LCBKdWVyZ2VuIEdyb3NzIHdyb3Rl
Og0KPj4+Pj4gLS0tIGEveGVuL2FyY2gveDg2L21tL21tLWxvY2tzLmgNCj4+Pj4+ICsrKyBi
L3hlbi9hcmNoL3g4Ni9tbS9tbS1sb2Nrcy5oDQo+Pj4+PiBAQCAtNDIsNyArNDIsNyBAQCBz
dGF0aWMgaW5saW5lIHZvaWQgbW1fbG9ja19pbml0KG1tX2xvY2tfdCAqbCkNCj4+Pj4+ICDC
oCBzdGF0aWMgaW5saW5lIGJvb2wgbW1fbG9ja2VkX2J5X21lKGNvbnN0IG1tX2xvY2tfdCAq
bCkNCj4+Pj4+ICDCoCB7DQo+Pj4+PiAtwqDCoMKgIHJldHVybiAobC0+bG9jay5yZWN1cnNl
X2NwdSA9PSBjdXJyZW50LT5wcm9jZXNzb3IpOw0KPj4+Pj4gK8KgwqDCoCByZXR1cm4gKGwt
PmxvY2suZGF0YS5jcHUgPT0gY3VycmVudC0+cHJvY2Vzc29yKTsNCj4+Pj4+ICDCoCB9DQo+
Pj4+DQo+Pj4+IEkgc2VlIGEgZmFpciByaXNrIHdpdGggdGhpczogQmVoYXZpb3Igd2lsbCBu
b3cgZGlmZmVyIGJldHdlZW4gZGVidWcgYW5kDQo+Pj4+IG5vbi1kZWJ1ZyBidWlsZHMuIEUu
Zy4gYSBsaXZlbG9jayBiZWNhdXNlIG9mIHRyeWluZyB0byBhY3F1aXJlIHRoZSBzYW1lDQo+
Pj4+IGxvY2sgYWdhaW4gd291bGQgbm90IGJlIG5vdGljZWQgaW4gYSBkZWJ1ZyBidWlsZCBp
ZiB0aGUgYWNxdWlyZSBpcw0KPj4+PiBjb25kaXRpb25hbCB1cG9uIHRoaXMgZnVuY3Rpb24n
cyByZXR1cm4gdmFsdWUuIEkgdGhpbmsgdGhpcyBpcyB0aGUgbWFpbg0KPj4+PiByZWFzb24g
YmVoaW5kIGhhdmluZyB0d28gc2VwYXJhdGUgZmllbGQsIGRlc3BpdGUgdGhlIGFwcGFyZW50
IHJlZHVuZGFuY3kuDQo+Pj4NCj4+PiBZb3UgYXJlIGF3YXJlIHRoYXQgbW1fbG9ja2VkX2J5
X21lKCkgaXMgdXNlZCBmb3IgcmVjdXJzaXZlIHNwaW5sb2Nrcw0KPj4+IG9ubHk/DQo+Pg0K
Pj4gQlRXLCBpdCBtaWdodCBtYWtlIHNlbnNlIHRvIGFkZCBhbm90aGVyIGJvb2wgZm9yIHRo
ZSBkZWJ1ZyBjYXNlIHRvIG1hcmsNCj4+IHJlY3Vyc2l2ZSBsb2NrIHVzYWdlLiBJIGRvbid0
IHRoaW5rIGFueXRoaW5nIGdvb2QgY2FuIGNvbWUgZnJvbSB1c2luZyBhDQo+PiBsb2NrIGlu
IGJvdGggbW9kZXMgKHJlY3Vyc2l2ZSBhbmQgbm9uLXJlY3Vyc2l2ZSkuDQo+IA0KPiBCdXQg
YmV3YXJlIG9mIHRoZSBjb2V4aXN0aW5nIHBhZ2luZ19sb2NrKCkgYW5kIHBhZ2luZ19sb2Nr
X3JlY3Vyc2l2ZSgpLg0KPiBBbGJlaXQgSSBndWVzcyB5b3VyIGNvbW1lbnQgd2FzIGZvciBz
cGlubG9ja3MgaW4gZ2VuZXJhbCwgbm90IHRoZQ0KPiBtbS1sb2NrIG1hY2hpbmVyeS4gWWV0
IG1lbnRpb25pbmcgdGhpcyByZW1pbmRzIG1lIG9mIHRoZSBwYWdlIGFsbG9jDQo+IGxvY2ss
IHdoaWNoIGRpZmZlcmVudCBwYXRocyBhY3F1aXJlIGluIGRpZmZlcmVudCB3YXlzLiBTbyB0
aGUgYml0DQo+IGNvdWxkbid0IGJlIGEgc3RpY2t5IG9uZS4NCg0KSW50ZXJlc3RpbmcuDQoN
ClNlZW1zIGFzIGlmIGUuZy4gY29uc29sZV9sb2NrIGlzIHVzZWQgaW4gYm90aCB3YXlzLCB0
b28uDQoNCk1pZ2h0IGJlIGEgZ29vZCBpZGVhIHRvIGF0IGxlYXN0IGFkZCBzb21lIHNlbGYt
ZGVhZGxvY2sgZGV0ZWN0aW9uDQpzdXBwb3J0IHRvIGRlYnVnIGJ1aWxkcy4NCg0KDQpKdWVy
Z2VuDQo=
--------------WzF0esdaANed5qvi8jCcW0N0
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------WzF0esdaANed5qvi8jCcW0N0--

--------------ZRkGchB2SOBf7AeKXTDrteLE--

--------------QpKzCzDVOqB0OkwmxxL2v0bN
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmIYo34FAwAAAAAACgkQsN6d1ii/Ey8z
WQf+LeqnIijjdVqRqRYQqlb8H451PgFApo5FNHKqyorQqwckomKVtP/HJi+dSKRz0/yW7qz76Xi2
aZ9yx9KPghc4HaktgT4jLPynrmqNl95Na1wvmmbg7MduJu2L/nUvUK3OXO3SQJcZsWaEm6c3E0Lw
hU6S7ZnZysgLXvGoA24NcE/8uKkFirPTPC+Yw9oYlOKVhbnlRlUax8KZsrBx+fzFjigkQ+0lzy3P
mrQSNGdabx6Om3uP93Jo/PUzHnTPt4K7xYqn59M5qbw+Noz0Eqw85nvFNmzFzaijwTnGKGiCIQi0
60xNnqrV2MLmiim6lZPs+/gQJNWfu+QSMrDY83EYeQ==
=fD1y
-----END PGP SIGNATURE-----

--------------QpKzCzDVOqB0OkwmxxL2v0bN--


From xen-devel-bounces@lists.xenproject.org Fri Feb 25 10:25:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 10:25:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278965.476455 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNXmS-0006hd-VV; Fri, 25 Feb 2022 10:24:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278965.476455; Fri, 25 Feb 2022 10:24:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNXmS-0006hW-SJ; Fri, 25 Feb 2022 10:24:56 +0000
Received: by outflank-mailman (input) for mailman id 278965;
 Fri, 25 Feb 2022 10:24:55 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nNXmR-0006hQ-DH
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 10:24:55 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nNXmP-0007Kd-V0; Fri, 25 Feb 2022 10:24:53 +0000
Received: from 54-240-197-234.amazon.com ([54.240.197.234]
 helo=[192.168.31.13]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nNXmP-0002GR-P2; Fri, 25 Feb 2022 10:24:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=N1UUDo7gtYWrVku021KqM8cTfVxWRdNiS3Bd0+hOgho=; b=aisKRc4lbR3WJIJKem/9EjoxIk
	TOkAsK3Gxbj9yi1YqjVQvxMml0c3L0tdZQfoesKqZnFUM8l1yu0ToSvss/ZkK3mkoepspyk9V5eXz
	HGgkgISpSJqSLIzUaqpi+AYIp9VQ8WQv2Xam7xvW2wNpHNqoAJBHHKwrJZaG9QJ4yiDE=;
Message-ID: <2295bb1c-6298-75b2-5f51-80bf114e365f@xen.org>
Date: Fri, 25 Feb 2022 10:24:51 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.1
Subject: Re: [PATCH v2 2/2] xen/include/public: deprecate GNTTABOP_transfer
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org, Juergen Gross <jgross@suse.com>
References: <20220203131418.1319-1-jgross@suse.com>
 <20220203131418.1319-2-jgross@suse.com>
 <a35bb9ba-e2be-f73e-9272-906bc09d9b6e@xen.org>
 <93e50bc4-6e53-b753-c520-7d1d0a5a5f5a@suse.com>
 <7ca05a74-6b65-f9cb-f524-28d700a7d0e4@suse.com>
 <78543fe5-1dde-41b8-e28d-de2cf22fc87f@xen.org>
 <cade3f06-4f25-07d6-3090-08a6487ba298@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <cade3f06-4f25-07d6-3090-08a6487ba298@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 25/02/2022 08:12, Jan Beulich wrote:
> On 24.02.2022 23:55, Julien Grall wrote:
>> On 16/02/2022 09:29, Jan Beulich wrote:
>>> On 16.02.2022 08:20, Juergen Gross wrote:
>>>> On 15.02.22 22:13, Julien Grall wrote:
>>>>> As a side note, should we also update SUPPORT.md?
>>>>
>>>> Good question.
>>>
>>> I'm not sure here either - talking about individual hypercall sub-ops
>>> seems overly small granularity to me for this kind of doc. Plus I
>>> don't view deprecation and de-supporting as the same thing. The latter
>>> would mean to render unsupported any old XenoLinux which may still be
>>> in use, all of the sudden.
>>
>> I understand this would result to unsupport some old OSes (not clear how
>> old). However, from what Juergen said this feature is untested.
>>
>> To me it sound like we are not confident that we could security support
>> this feature.
>>
>> So I am not sure to understand why we only want to deprecate it.
> 
> Not sure what to say: Rendering unsupported however old guests is not
> a nice step. Hence my concern (which isn't an outright objection).

In the past we have removed support for feature we deemed unsafe to use 
and it would require effort to secure it. This is despite the fact that 
it may be used in production (e.g. PV devices, qemu trad...).

So I think the question here is really, do you think we can sensibly 
security support GNTTABOP_transfer?

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Feb 25 10:31:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 10:31:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278972.476466 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNXsQ-0008AG-KD; Fri, 25 Feb 2022 10:31:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278972.476466; Fri, 25 Feb 2022 10:31:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNXsQ-0008A9-H0; Fri, 25 Feb 2022 10:31:06 +0000
Received: by outflank-mailman (input) for mailman id 278972;
 Fri, 25 Feb 2022 10:31:05 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=RDkG=TI=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nNXsO-0008A3-Us
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 10:31:05 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 07f2cf17-9626-11ec-8eb8-a37418f5ba1a;
 Fri, 25 Feb 2022 11:31:03 +0100 (CET)
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur03lp2053.outbound.protection.outlook.com [104.47.10.53]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-3-DvPCMrKANoCMnmgTjAYG2Q-1; Fri, 25 Feb 2022 11:31:01 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM0PR04MB5266.eurprd04.prod.outlook.com (2603:10a6:208:c3::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Fri, 25 Feb
 2022 10:31:00 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.025; Fri, 25 Feb 2022
 10:31:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 07f2cf17-9626-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645785062;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=POXQsCTEhKU9rL1NFnJ4gkLf2nr1Wkc69qpMY9fYofg=;
	b=O7UHfGKGNAgQya5AbLuo975cgwUFGL4mHHXJrdsuQMi72aoIvypFJQr6N1s5nB1xXFWgiy
	RlBG44ekCQGbMcNoi/1hno7hQXrMlyNjEvikYberXVjjhaQUk4ePqT6LbpvMNW4c7pA+ud
	xI77Xc1TH2qcSm8p0uH2rh/ifJpYHD8=
X-MC-Unique: DvPCMrKANoCMnmgTjAYG2Q-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=WlFtQYSrfYWaaBJpWIpLujZblclFGt0I/VPtLoF/JZ9bpEgxZEmXaBIM+uQgmMIThypZ9i/krpVDhjIW+UtA5RhjtgEg46oige28Ji9Dz1A7wtW7YxyrL+vdZ2L2jT7dg+eVMw7VDb9qUnY6lDBRzl4RuZMns1YB+bO64GXj65ca6YwPJyF0ZtoL/rnrioVaUTXKS3fSyY/DmEj2aq93U/sl3yV8DvchNSJ2mpAfDQlPaeSD6H0a07IC82sAhWyjQXo+1JBCK5kzbU2dOlhxUvZuwt7W6ZV/KKEpP3ajdkUlZyUkOYG2vp3tvloHhnPzXiPeIWWz/1C9jVLEPrh1Tg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=POXQsCTEhKU9rL1NFnJ4gkLf2nr1Wkc69qpMY9fYofg=;
 b=S0WKZMol6F4xlhM7fTzSa6WhxbO76o2yuCcDjtu6ZqjHPCKw78BptexMx8V3015zzR/MsygjUDcBpBXBZpCAKFmYcQIFotgVLY6pltyOijdGByXXfReuYwdtunKLHXCaf2ynX2qqdElMoJTatInUsBTNUVw7+tgTIdPvBc893j7oAZMZnUUd6+Srzh1U/hSwV7m7XvZ8pVl+NftEzoQdvjLyO5hBlB5AF4TEDhcLbqDJWIDT0w8mLG3Ji0rpbKzkxhVCE03aW21O4hViz4wtQd6Vkc8uFAjQeZ/uT3qgA+vedxDsZOgjTzKHK0fI74XVv2OkBGqfjBAHaia/nUPCnQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <a27ff4b4-37ea-7bbc-eb43-6c4e6eb9277b@suse.com>
Date: Fri, 25 Feb 2022 11:30:58 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v2 2/2] xen/include/public: deprecate GNTTABOP_transfer
Content-Language: en-US
To: Julien Grall <julien@xen.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org, Juergen Gross <jgross@suse.com>
References: <20220203131418.1319-1-jgross@suse.com>
 <20220203131418.1319-2-jgross@suse.com>
 <a35bb9ba-e2be-f73e-9272-906bc09d9b6e@xen.org>
 <93e50bc4-6e53-b753-c520-7d1d0a5a5f5a@suse.com>
 <7ca05a74-6b65-f9cb-f524-28d700a7d0e4@suse.com>
 <78543fe5-1dde-41b8-e28d-de2cf22fc87f@xen.org>
 <cade3f06-4f25-07d6-3090-08a6487ba298@suse.com>
 <2295bb1c-6298-75b2-5f51-80bf114e365f@xen.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <2295bb1c-6298-75b2-5f51-80bf114e365f@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM7PR04CA0017.eurprd04.prod.outlook.com
 (2603:10a6:20b:110::27) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a3fa4f27-70bb-430c-593d-08d9f849ea6b
X-MS-TrafficTypeDiagnostic: AM0PR04MB5266:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB5266C2921BB73A8593FD4CB4B33E9@AM0PR04MB5266.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	pQp7nxUkTRpea91TTGPvKWQBRUid8TMqKqSTpheoemGXC9CKwC6dxU7jtyePwDeqxg+3Wt09aWUfK/MJC9uUeeU6mKAiUcbFdaJIGVuK1zpOGzP6mfID0ZiaGSAY8GcshaWLXZiDX/wPMxBRPnw0x2Nr/4fWKpNZfc6dgy31k3SQLQW5pzG/HwHdzqBXYjL5M4zR0WnARQA368M2F9eupQNEAc5nahFLlQITJLmL3ZBprPewizKbX2AXvZLwW629QAN9iF+tBVPeUs4Jl9cbcSsJxxx7a3WGUvQTXUY6pa/2OJEnvpjtkft4BYyRR4eBalqT4kKrPprh9EO2a5kSdo3loKRlaE0kLC1HfBEGcA/FqwRmro9hBPpTkpsvK3OqOTm5OeeZwsgFYT5bBVeMx4NZyZsSNTBHVJjrUcndL56wKH7q89bOsfai5YjHJwZxVbi+5EYluLm3X8LQLEqYfQNzqlSxLKq2bYyvbsKWal989z9UMXlNSgvw/vV3/JDVg1ho3u8IgDT9bh7Z52Xp8v+aDh/PpNO8uJZX9RZ9zw4eo2gald1kCCSW7UCIQALlXVETjdY0VlE/IzcGjI0R9G9CCrQZ5r+i19Snk5s4jJRh+bUMjEmcEw9zfHRppRBb+GGPbGo5hHZ1Ew4fK9Sucv8bhyVjU1hEENDYO0btrVp8M/yeB1CPNKdVcNBF/Q7AZRie41qcHJOQk57DOCoyF1OENfLA9BXDc1Y5pE8idmKq/tOwFJ+KLRGYffF9MkZj
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6486002)(8676002)(86362001)(26005)(8936002)(54906003)(2616005)(186003)(508600001)(4326008)(5660300002)(31696002)(66556008)(66476007)(6506007)(53546011)(83380400001)(6916009)(66946007)(38100700002)(31686004)(36756003)(107886003)(2906002)(6512007)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aHpBd292VjBDaE9VM21vZGh1U01QVnJ3dzFMa3BDNCttdVNOeVVxMHNnZnI5?=
 =?utf-8?B?a0VhQTRxMU81Z2lSaEdwaGN3WnYvTE5JZ3dtbU9rWDdSR0x2S1BUT3llb0t0?=
 =?utf-8?B?TWV5SlJIZWdBaGlNNkplSkJIcHdDcUdRTy9pNDJtWEQyc3NFejZnRUN6YjAv?=
 =?utf-8?B?ZjA3ekNNVVRJOWlSck9DVzVJTk8ySTZTVzg4VE1uOHp4a2ZwNElmUFNDcmJ2?=
 =?utf-8?B?VXlUWVdyLy95cTh5UGh1YzZxZzZ2dUc1VjZFUVEreHpZaXlaK1ZGelJmd3RE?=
 =?utf-8?B?TUdYWVFVTHhCK3pmdmVsek9wQVVmZFVKMDRsNENYeW9ONGpEUHJxYVdpbkdX?=
 =?utf-8?B?bm1rZFIySDVLZ0cyK3hxdit1c1MzckkrdWZtRkRIcDhQbGQ0cmQxWE9WSWhM?=
 =?utf-8?B?VGxJcUFOR2tCUzJOU09lT1dWZk0wL2k2MUc5UmRMRUJxa0VBbEk1Ky9uRmJu?=
 =?utf-8?B?WHZwcUxIR1lSMmNMeDY3aHNvdEpKTWtFRGVLR0RCTmwyQmk1d0dzOVp2VHZp?=
 =?utf-8?B?TG9KZDhNZnlHS0ZFUWswRmsxQW9kelJiY2xLa3dOTFhqNzFoa013THFpVWsx?=
 =?utf-8?B?OWN2SjRzZlhKYXYrKzRJOUZWVnBjTlpDa3VZd3RSWkx4OHVud3psV1UycVpV?=
 =?utf-8?B?amZDaUxPb0Z6VUhkLzFrQXVPbnlETkxHSWNFaHE0dW04c2VUNmdRaDAxSUFw?=
 =?utf-8?B?M1ltSGRjZ084R25ZMDUwbWFudmk3RnF3SzJ1c0dkUXVLdUhsZEhTbnlHdzc3?=
 =?utf-8?B?VlAxVTVxb3Q5REl3MWJCRGtXUGdNU2szeitSd2RsOHBPRE8yN2NueHVlQllQ?=
 =?utf-8?B?MEhNN2Z0eEpxc3pMK3Mzb3NiZmFTNGtXQ1o4SldmWjF6SElhaVY5WTkrOGk0?=
 =?utf-8?B?VFM2YytaRHZVQmFqbzl1dk1zTm9KaDhIRWhPVFVTb3FoOE03R1ZzVnJxWThq?=
 =?utf-8?B?MWJITFRuUk51TVA0WTFTcFo4cklxbGZYNVorM2prU1hObXB5Mm5mcmpMcUNP?=
 =?utf-8?B?c3ZYTkowMlcvMTVIRVg2aGczekNiK05JM0w0L3c1MWt1NkVrWGNYdm52TUhU?=
 =?utf-8?B?SUdGRFRyVUM0a0RZd0UyaXFUYnM0aVBqMHE0cGdrM2FPVHA3NHU5V2F6d3dv?=
 =?utf-8?B?WVVzWVpKSUd5ZEIxa0lneUtFdkdZVW5OQjlkT2xKcSt1cExFMmMwb1BIU3F6?=
 =?utf-8?B?cmZwbUxyVWhIWkRMOWdCSHppVkRtQzY0WHIxcTM0RVFkMG85cXBHVUJUS08r?=
 =?utf-8?B?bnJrME05eWpkU0phN3dadDIvR2FyVnU0b3ZrbjFSc3pLS05xQU9YNDRLVzZI?=
 =?utf-8?B?L3hWSnBnRjZUVSt5b1hHSUpaVk5IZXRReEpKN2ZubndpYmtiaTV0ejFCcklz?=
 =?utf-8?B?YVdpOGd2MGZkQ1BBTjlWUU9EejBlQkFVM0ZJTW5OZzloeGRROFkwNkpvUXFv?=
 =?utf-8?B?RmFDc2J3YmY1Ky9ZMklGR3JuYU9LUmJRWHhibDFuV3BJWmw3Mlc5UWhVWDB2?=
 =?utf-8?B?dXg2dUc2cmVWcFFoa2d1dVE2b3phTFRsREtnVEJaVG84dGtyQWl1NEp0ZkM2?=
 =?utf-8?B?elZNSGtla2U2Z3FBS1BlUkRLSTZsZUlOeGw0TXRGdElpYkN4L3kwNEE5Ulpy?=
 =?utf-8?B?QnJLU1NkL0NwVVBzZTVxOUJnTXZmOXB5ODV3OW52Sll3bkJlMERCNTdEOHBu?=
 =?utf-8?B?MnBURFVVSnJQUnJyQTJtRWVKSVpjS0VTQXZIWFhLV25LNCthS2hDenlKSGxZ?=
 =?utf-8?B?WlFLalZFQzhMTGhWZHJENkpmbzdzaEVEUEtNZml1a04ySmVvRE1Nblh5UWhj?=
 =?utf-8?B?bFM5Qk9OVWRHVHdlVXk5bGwvNTh6ekVNQkhuYVhwbmpsTk4wRnd4SmtsUzJU?=
 =?utf-8?B?a1VMK3JJL0licXcwZUFqVUdHNFhYNzMxMGE4RGpudDJIbzhSSmIwYkJMRHRK?=
 =?utf-8?B?bTR1ZTRxYUlCaEo3SWgzK1FoYXpRVkdvN2ZrbWJDb2ZSejczNmV3cHRmeXVB?=
 =?utf-8?B?a0lweGF5cm4zWDRnYVFGV29KS2NjQzdHNmJJTU9RM1N1OHh0WXo2OW1SZGFs?=
 =?utf-8?B?MXZsZTM4ZEI1czBtSFprWWZHMXhBYjJDS3B6aFVPWUJRbUZpVnRic0tJNnRH?=
 =?utf-8?B?NWF0bnFnZC91dHpMeWxWR3Y5cmhVWDc5N0tjeFNyTnc0anJkMkNoQ2puR2Vz?=
 =?utf-8?Q?EFG2OJo5IZBx+Crnm0cK+tk=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a3fa4f27-70bb-430c-593d-08d9f849ea6b
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2022 10:31:00.0559
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Wn83+OthBFPaCtvIai62T3BeGkLJITUh91J0ESmPKLWBFmvpQO636prAkcsCOnU8cO/jRUt7Vziz2NcGhXf0NQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5266

On 25.02.2022 11:24, Julien Grall wrote:
> On 25/02/2022 08:12, Jan Beulich wrote:
>> On 24.02.2022 23:55, Julien Grall wrote:
>>> On 16/02/2022 09:29, Jan Beulich wrote:
>>>> On 16.02.2022 08:20, Juergen Gross wrote:
>>>>> On 15.02.22 22:13, Julien Grall wrote:
>>>>>> As a side note, should we also update SUPPORT.md?
>>>>>
>>>>> Good question.
>>>>
>>>> I'm not sure here either - talking about individual hypercall sub-ops
>>>> seems overly small granularity to me for this kind of doc. Plus I
>>>> don't view deprecation and de-supporting as the same thing. The latter
>>>> would mean to render unsupported any old XenoLinux which may still be
>>>> in use, all of the sudden.
>>>
>>> I understand this would result to unsupport some old OSes (not clear how
>>> old). However, from what Juergen said this feature is untested.
>>>
>>> To me it sound like we are not confident that we could security support
>>> this feature.
>>>
>>> So I am not sure to understand why we only want to deprecate it.
>>
>> Not sure what to say: Rendering unsupported however old guests is not
>> a nice step. Hence my concern (which isn't an outright objection).
> 
> In the past we have removed support for feature we deemed unsafe to use 
> and it would require effort to secure it. This is despite the fact that 
> it may be used in production (e.g. PV devices, qemu trad...).
> 
> So I think the question here is really, do you think we can sensibly 
> security support GNTTABOP_transfer?

I don't think it's a question of "can", but of "are we willing to". It
would be "can" only if we learned of some seemingly very hard to solve
issue. From a workload perspective it would certainly be nice if we
didn't have to think about this anymore. Yet like in certain other
cases, besides the particular item here I'm also worried of setting
a precedent which may then be used to argue for the removal of support
for other operations, just to make our lives easier.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Feb 25 10:40:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 10:40:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278981.476477 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNY1H-0001I5-MC; Fri, 25 Feb 2022 10:40:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278981.476477; Fri, 25 Feb 2022 10:40:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNY1H-0001Hy-I6; Fri, 25 Feb 2022 10:40:15 +0000
Received: by outflank-mailman (input) for mailman id 278981;
 Fri, 25 Feb 2022 10:40:13 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=XIt/=TI=kernel.org=patchwork-bot+netdevbpf@srs-se1.protection.inumbo.net>)
 id 1nNY1F-0001Hs-LV
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 10:40:13 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4edf84dd-9627-11ec-8eb8-a37418f5ba1a;
 Fri, 25 Feb 2022 11:40:12 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id EA43B61676;
 Fri, 25 Feb 2022 10:40:10 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPS id AEFA2C340F2;
 Fri, 25 Feb 2022 10:40:10 +0000 (UTC)
Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org
 (localhost.localdomain [127.0.0.1])
 by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id
 8E526EAC09B; Fri, 25 Feb 2022 10:40:10 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4edf84dd-9627-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1645785610;
	bh=1Bj4E8jna9gv+7NmgSy2dvDNmaH/RWmUnYnExJ1EXXU=;
	h=Subject:From:Date:References:In-Reply-To:To:Cc:From;
	b=naGEzD/RpkgtsDTe3JbpvxClxahzdvbXym5agxbwVk/p1LYOffGh3xFaC33lapix+
	 oUNVFd5208INQsRMIzfwZmVb3gw7bbFvQqQzeWTKQsvSkrXuNmNlYe7TWushWj5fPx
	 Afg6Iv4HP44YZcoF6kC5Je/Ulflv37WObaf7eDeB/l8LXdD8JJ4FjTCEj8Dwq9lJx8
	 APRLCfXLb76SCcK4WDQnRnxgnjd6aIgn+BhaxqAZaB5NkK8QO7nzfsblMaRYPVD+H6
	 ZWOkUzcizcAW2nYprgaEAc0qz/R+IWzSSHef4XdTTzAjF24WPbTxDC9bTSh+J8DpQn
	 7/tIvebdXOV+w==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: Re: [PATCH v2] xen/netfront: destroy queues before real_num_tx_queues is
 zeroed
From: patchwork-bot+netdevbpf@kernel.org
Message-Id: 
 <164578561057.13834.5994173770160348500.git-patchwork-notify@kernel.org>
Date: Fri, 25 Feb 2022 10:40:10 +0000
References: <20220223211954.2506824-1-marmarek@invisiblethingslab.com>
In-Reply-To: <20220223211954.2506824-1-marmarek@invisiblethingslab.com>
To: =?utf-8?q?Marek_Marczykowski-G=C3=B3recki_=3Cmarmarek=40invisiblethingslab?=@ci.codeaurora.org,
	=?utf-8?q?=2Ecom=3E?=@ci.codeaurora.org
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
 boris.ostrovsky@oracle.com, jgross@suse.com, sstabellini@kernel.org,
 davem@davemloft.net, kuba@kernel.org, atenart@kernel.org,
 xen-devel@lists.xenproject.org, netdev@vger.kernel.org

Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:

On Wed, 23 Feb 2022 22:19:54 +0100 you wrote:
> xennet_destroy_queues() relies on info->netdev->real_num_tx_queues to
> delete queues. Since d7dac083414eb5bb99a6d2ed53dc2c1b405224e5
> ("net-sysfs: update the queue counts in the unregistration path"),
> unregister_netdev() indirectly sets real_num_tx_queues to 0. Those two
> facts together means, that xennet_destroy_queues() called from
> xennet_remove() cannot do its job, because it's called after
> unregister_netdev(). This results in kfree-ing queues that are still
> linked in napi, which ultimately crashes:
> 
> [...]

Here is the summary with links:
  - [v2] xen/netfront: destroy queues before real_num_tx_queues is zeroed
    https://git.kernel.org/netdev/net/c/dcf4ff7a48e7

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html




From xen-devel-bounces@lists.xenproject.org Fri Feb 25 10:49:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 10:49:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278989.476488 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNY9l-000202-ES; Fri, 25 Feb 2022 10:49:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278989.476488; Fri, 25 Feb 2022 10:49:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNY9l-0001zv-B0; Fri, 25 Feb 2022 10:49:01 +0000
Received: by outflank-mailman (input) for mailman id 278989;
 Fri, 25 Feb 2022 10:49:00 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=i2jl=TI=arm.com=Wei.Chen@srs-se1.protection.inumbo.net>)
 id 1nNY9j-0001zW-IN
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 10:49:00 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05on20621.outbound.protection.outlook.com
 [2a01:111:f400:7e1b::621])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 86aab264-9628-11ec-8539-5f4723681683;
 Fri, 25 Feb 2022 11:48:54 +0100 (CET)
Received: from AM6P194CA0081.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:8f::22)
 by AM0PR08MB2962.eurprd08.prod.outlook.com (2603:10a6:208:5b::19) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.16; Fri, 25 Feb
 2022 10:48:50 +0000
Received: from AM5EUR03FT037.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:8f:cafe::a) by AM6P194CA0081.outlook.office365.com
 (2603:10a6:209:8f::22) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.23 via Frontend
 Transport; Fri, 25 Feb 2022 10:48:50 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT037.mail.protection.outlook.com (10.152.17.241) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5017.22 via Frontend Transport; Fri, 25 Feb 2022 10:48:49 +0000
Received: ("Tessian outbound 18e50a6f0513:v113");
 Fri, 25 Feb 2022 10:48:44 +0000
Received: from b8990489366e.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 369B4312-6644-4205-8442-74CC613892E0.1; 
 Fri, 25 Feb 2022 10:48:34 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b8990489366e.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 25 Feb 2022 10:48:34 +0000
Received: from AS1PR08MB7426.eurprd08.prod.outlook.com (2603:10a6:20b:4c5::16)
 by AM5PR0802MB2531.eurprd08.prod.outlook.com (2603:10a6:203:a0::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.21; Fri, 25 Feb
 2022 10:48:32 +0000
Received: from AS1PR08MB7426.eurprd08.prod.outlook.com
 ([fe80::58e6:449c:825c:a0c2]) by AS1PR08MB7426.eurprd08.prod.outlook.com
 ([fe80::58e6:449c:825c:a0c2%4]) with mapi id 15.20.5017.024; Fri, 25 Feb 2022
 10:48:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 86aab264-9628-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=2nh6JR06Bqda3CnKAnNz0ViVr5NJPj3yCERFwbw1ukE=;
 b=5Z3anoGz963umb0svcdnL2liJEBoajUmKXz1FtPQLIwcThFkLoQLm8Ukm8eTa1bm66iXwvkKy3aWR8281rqg5Bnz3ZjfX70itnniCiSzWpEHQOxMXjKHU4WvoqRKx9QVMTM95jX+PImnlv6Gl/Hrd9cGj2CnTJ9UWdIUpc8pOOk=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: ded7751f44731ea6
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=DMteEZl0qJcvXnu7yktKMOvnU9ut4FCZgryFTbB6OG82xXonjNsGkJxlHb65JS//wJe4sGh9Hitj8guZ/c82ODeVOv8eDrnaDp0AkfkIONqBsHFSwFQ4b87n4K3gkyrr2vDA2hmJ+LXWNsoVXvCJ+rZW9UVhAyZs2AKdZC3IkYhr7cvx+8U8iaOMbsOqVIs0Va8ayLc9k7vT27L3Hra3pA4OdJrwWEc+/1NoPOo8uPPTC/1pDKDWyqNAxzN1iREHWMrQg7DLPHa3R6ixuMRWabpztWMSyXa/EpqMR25hJRGquhfE/8HLmFG2xGvEap2HrrCbQWoovjUMUqimaWeKjw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=2nh6JR06Bqda3CnKAnNz0ViVr5NJPj3yCERFwbw1ukE=;
 b=JmthvdErcoGvEuvRNrA0DSwe81FcJoluMZHS7aLqNYtE7Dzg9Er4/zGNske2y66v5I0LBpHgkZcikANdTVD5OIJ+4kIU4ABGwFpxXe/oS4Y6mU1wSmM2ZtYrGKvlKwHgIzRT2qn5c6itUjsbHjLV6PRRFU4hlEa7IeyA9I8pmz9csimxtQlF2CSSOShsMDihOyKWzIT554MUpXR2EjyaTDcba9ENKSkznMdP54fdp/xOkKAjAwnOu9Wt1+pTVTUv74d8lw+/TM03OzfKs5bfPF0cHZRPUq2tWN0yXFC8VDBd69stOa61wipKDcLOJSUOd9TsjsavJh+E9xAT+dItFg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=2nh6JR06Bqda3CnKAnNz0ViVr5NJPj3yCERFwbw1ukE=;
 b=5Z3anoGz963umb0svcdnL2liJEBoajUmKXz1FtPQLIwcThFkLoQLm8Ukm8eTa1bm66iXwvkKy3aWR8281rqg5Bnz3ZjfX70itnniCiSzWpEHQOxMXjKHU4WvoqRKx9QVMTM95jX+PImnlv6Gl/Hrd9cGj2CnTJ9UWdIUpc8pOOk=
From: Wei Chen <Wei.Chen@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"julien@xen.org" <julien@xen.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Penny Zheng <Penny.Zheng@arm.com>, Henry Wang
	<Henry.Wang@arm.com>, nd <nd@arm.com>
Subject: RE: Proposal for Porting Xen to Armv8-R64 - DraftA
Thread-Topic: Proposal for Porting Xen to Armv8-R64 - DraftA
Thread-Index: AdgpQxtXwh7LkfydTgiYk9bhMgU+ogAn0mUAABEK2UA=
Date: Fri, 25 Feb 2022 10:48:30 +0000
Message-ID:
 <AS1PR08MB74269923288B75097392BDD99E3E9@AS1PR08MB7426.eurprd08.prod.outlook.com>
References:
 <PAXPR08MB7420A01809B84E04E196793F9E3D9@PAXPR08MB7420.eurprd08.prod.outlook.com>
 <alpine.DEB.2.22.394.2202241606450.239973@ubuntu-linux-20-04-desktop>
In-Reply-To:
 <alpine.DEB.2.22.394.2202241606450.239973@ubuntu-linux-20-04-desktop>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 82679e38-e893-4318-190a-08d9f84c682f
x-ms-traffictypediagnostic:
	AM5PR0802MB2531:EE_|AM5EUR03FT037:EE_|AM0PR08MB2962:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR08MB2962E73C7F303FDB641E136E9E3E9@AM0PR08MB2962.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 9RmRITmpjdXV8SLVqmxZ2pKFAhh1tS/WgAvPlMmvYDHO9EiZCjhxs5iaxTj1yqepPxeSD2iR3BQtFGNUPU4XHa60z4a5qKRb1HNWmPkUlxYsMRTlTVx7gheaxSj2GE+mdcs8XQrXqyfi24k9ELRxevR2qsXMEJNqW57xbMibJuunktDmmrPyj3/6Z851KllYP0f+vvlM7x7GnrTEw4x4vYvP05fLTzXYDxBAdsYv3wVRbO45jfzfV7izcZyNPuNY3iy77toeR4ZLCrJHqzAeXM1ZLDy3W6Ra3IIWYPYaxHcqpEmawOF9wY2v7e4HHCvEMKiq44O7zRm9t0s7rE2uQgcafgBAh3cEfCUrZVS7ssQBOkZngosmA2s5eckuRTBQ/DlBdl49lp2KF87UzoCt60ULmfxtRvlsWX2eFhsY2GTbNS5V/tk2A7q9udxu7kW3PAZdayL95UA/d9/Jiyb6uesJQcUmQEVosadD9M72jwWVqpDKkZZmkIQ8n7QnvRzjwzjZ+05Tkiu0/bxwXFdfM5SSl6dxJOE+vS5L49cYcb3nGeiF8BhG8J1ddnrvsvNcSx7p4+hnVOzORP0pbXyhh/kIuJ3uyFBhZaWIkR6NR2gENS+W5hU+xjb2UnEeCVHnpuKD+XlTLC9wu7uxw7yywlbRc+Jsev28noaQgljNs8UAgCrPdC4N82wfcd1V51oCPnxTCGOg9Whom9p/sCn1ppz0Hflm7ByRiKO6IOiwhdjUbLufWMFFiu+XVNykD7tF6GP0BGSb8oD1XmDk2q0xgLqo8b5r+g9yFGwEj1+uOrIufLItWTcEgzIizHagV6O1p6Bp9vnyvqWCv7GCA/PNPg==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS1PR08MB7426.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66946007)(8676002)(66476007)(38100700002)(66556008)(66446008)(4326008)(38070700005)(33656002)(2906002)(71200400001)(6916009)(91956017)(122000001)(76116006)(64756008)(53546011)(166002)(7696005)(6506007)(508600001)(316002)(9686003)(186003)(30864003)(5660300002)(55016003)(83380400001)(8936002)(52536014)(54906003)(86362001)(559001)(579004);DIR:OUT;SFP:1101;
Content-Type: multipart/alternative;
	boundary="_000_AS1PR08MB74269923288B75097392BDD99E3E9AS1PR08MB7426eurp_"
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0802MB2531
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT037.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	cc2a3e16-95d3-46b7-bd4c-08d9f84c5d2f
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	t4ZtLXqiwztVjCiUJ5bJT2ZiGO+msbKK/3AM3APpdPPBSVCE087z7hmDoOKlDeK4QPb+sF8uijvdzgygJCudSnFJ7aJ4/J4H33ocrbI3KsWKfD5KDfJjCPKGaDIbm26YMFJOp1JG8nazuckW1nRzfojvAIrC2K13XpWOyDLsx4ctH+e64HV4MAftHA3REHXzY3F9Q8kPOUbq36vPlF2URRtXCn/9188v/GW6ZsMzjrq/I7jwdizzNqb4K7u3P339q/b5XZ021xUVQ3lLCJ9/vTmmJsB7WwKC5BEWOycaYYY/aWTQ6errRATCetWdBQYZlQnJ4Y7GbaJVDbEC1hgug8Qi6vH045BcxRT0owYdU9cwwHunDw9TrSOd2Aa/x1TgbnV8z2nwTFx7UPBOHuQKuOjnxU0Gaq/ovV/DmY1i7+a03s9aTuRWI+CiRU+duJNji0Ce/EoNNh2nQK/U0suARwfICo/XIbKGrl2u0u/+5p0aytqcliWouFI/bMzQqVLQ1nYVeluXyEDbz2BdoIvEP4I3NUvX4t87oZwAMw5dlV28UskBmg+Xs9wKWOW6ssWwNRvelqIVzPyLvWlwYZOT3nfhdVjygzWOfj6jxoYX9Inht+ChmLPJ15Ae6m2yL5GcAwHDtGBSvyJ6kQ7V+HngbJ2MS/DtRTuVcviPCfjMXojBEfr3v9KcV8yEAmISwPv4dKctoUuZuMEMQ5A62jMNK6A83pljZ5PgXXY0Vyli8OGFwiMcXuVQ7JzDWQafOWscpj2DtaY5h65ZItQ0+7c7ELaSuvzj17vHSq6XazcPN7g=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(7696005)(47076005)(40460700003)(53546011)(33656002)(6506007)(55016003)(508600001)(36860700001)(2906002)(9686003)(70586007)(5660300002)(70206006)(8936002)(54906003)(86362001)(8676002)(82310400004)(336012)(356005)(30864003)(166002)(81166007)(52536014)(316002)(4326008)(6862004)(26005)(186003)(83380400001)(559001)(579004);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2022 10:48:49.0631
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 82679e38-e893-4318-190a-08d9f84c682f
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT037.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB2962

--_000_AS1PR08MB74269923288B75097392BDD99E3E9AS1PR08MB7426eurp_
Content-Type: text/plain; charset="iso-2022-jp"
Content-Transfer-Encoding: quoted-printable

Hi Stefano,

> -----Original Message-----
> From: Stefano Stabellini <sstabellini@kernel.org>
> Sent: 2022=1B$BG/=1B(B2=1B$B7n=1B(B25=1B$BF|=1B(B 8:56
> To: Wei Chen <Wei.Chen@arm.com>
> Cc: xen-devel@lists.xenproject.org; julien@xen.org; Stefano Stabellini
> <sstabellini@kernel.org>; Bertrand Marquis <Bertrand.Marquis@arm.com>;
> Penny Zheng <Penny.Zheng@arm.com>; Henry Wang <Henry.Wang@arm.com>; nd
> <nd@arm.com>
> Subject: Re: Proposal for Porting Xen to Armv8-R64 - DraftA
>
> Hi Wei,
>
> This is extremely exciting, thanks for the very nice summary!
>
>
> On Thu, 24 Feb 2022, Wei Chen wrote:
> > # Proposal for Porting Xen to Armv8-R64
> >
> > This proposal will introduce the PoC work of porting Xen to Armv8-R64,
> > which includes:
> > - The changes of current Xen capability, like Xen build system, memory
> >   management, domain management, vCPU context switch.
> > - The expanded Xen capability, like static-allocation and direct-map.
> >
> > ***Notes:***
> > 1. ***This proposal only covers the work of porting Xen to Armv8-R64***
> >    ***single CPU. Xen SMP support on Armv8-R64 relates to Armv8-R***
> >    ***Trusted-Frimware (TF-R). This is an external dependency,***
> >    ***so we think the discussion of Xen SMP support on Armv8-R64***
> >    ***should be started when single-CPU support is complete.***
> > 2. ***This proposal will not touch xen-tools. In current stage,***
> >    ***Xen on Armv8-R64 only support dom0less, all guests should***
> >    ***be booted from device tree.***
> >
> > ## 1. Essential Background
> >
> > ### 1.1. Armv8-R64 Profile
> > The Armv-R architecture profile was designed to support use cases that
> > have a high sensitivity to deterministic execution. (e.g. Fuel Injectio=
n,
> > Brake control, Drive trains, Motor control etc)
> >
> > Arm announced Armv8-R in 2013, it is the latest generation Arm
> architecture
> > targeted at the Real-time profile. It introduces virtualization at the
> highest
> > security level while retaining the Protected Memory System Architecture
> (PMSA)
> > based on a Memory Protection Unit (MPU). In 2020, Arm announced Cortex-
> R82,
> > which is the first Arm 64-bit Cortex-R processor based on Armv8-R64.
> >
> > - The latest Armv8-R64 document can be found here:
> >   [Arm Architecture Reference Manual Supplement - Armv8, for Armv8-R
> AArch64 architecture
> profile](https://developer.arm.com/documentation/ddi0600/latest/).
> >
> > - Armv-R Architecture progression:
> >   Armv7-R -> Armv8-R AArch32 -> Armv8 AArch64
> >   The following figure is a simple comparison of "R" processors based o=
n
> >   different Armv-R Architectures.
> >   ![image](https://drive.google.com/uc?export=3Dview&id=3D1nE5RAXaX8zY2=
KPZ8i
> mBpbvIr2eqBguEB)
> >
> > - The Armv8-R architecture evolved additional features on top of Armv7-=
R:
> >     - An exception model that is compatible with the Armv8-A model
> >     - Virtualization with support for guest operating systems
> >         - PMSA virtualization using MPUs In EL2.
> > - The new features of Armv8-R64 architecture
> >     - Adds support for the 64-bit A64 instruction set, previously Armv8=
-
> R
> >       only supported A32.
> >     - Supports up to 48-bit physical addressing, previously up to 32-bi=
t
> >       addressing was supported.
> >     - Optional Arm Neon technology and Advanced SIMD
> >     - Supports three Exception Levels (ELs)
> >         - Secure EL2 - The Highest Privilege, MPU only, for firmware,
> hypervisor
> >         - Secure EL1 - RichOS (MMU) or RTOS (MPU)
> >         - Secure EL0 - Application Workloads
> >     - Optionally supports Virtual Memory System Architecture at S-EL1/S=
-
> EL0.
> >       This means it's possible to run rich OS kernels - like Linux -
> either
> >       bare-metal or as a guest.
> > - Differences with the Armv8-A AArch64 architecture
> >     - Supports only a single Security state - Secure. There is not Non-
> Secure
> >       execution state supported.
> >     - EL3 is not supported, EL2 is mandatory. This means secure EL2 is
> the
> >       highest EL.
> >     - Supports the A64 ISA instruction
> >         - With a small set of well-defined differences
> >     - Provides a PMSA (Protected Memory System Architecture) based
> >       virtualization model.
> >         - As opposed to Armv8-A AArch64's VMSA based Virtualization
> >         - Can support address bits up to 52 if FEAT_LPA is enabled,
> >           otherwise 48 bits.
> >         - Determines the access permissions and memory attributes of
> >           the target PA.
> >         - Can implement PMSAv8-64 at EL1 and EL2
> >             - Address translation flat-maps the VA to the PA for EL2
> Stage 1.
> >             - Address translation flat-maps the VA to the PA for EL1
> Stage 1.
> >             - Address translation flat-maps the IPA to the PA for EL1
> Stage 2.
> >     - PMSA in EL1 & EL2 is configurable, VMSA in EL1 is configurable.
> >
> > ### 1.2. Xen Challenges with PMSA Virtualization
> > Xen is PMSA unaware Type-1 Hypervisor, it will need modifications to ru=
n
> > with an MPU and host multiple guest OSes.
> >
> > - No MMU at EL2:
> >     - No EL2 Stage 1 address translation
> >         - Xen provides fixed ARM64 virtual memory layout as basis of EL=
2
> >           stage 1 address translation, which is not applicable on MPU
> system,
> >           where there is no virtual addressing. As a result, any
> operation
> >           involving transition from PA to VA, like ioremap, needs
> modification
> >           on MPU system.
> >     - Xen's run-time addresses are the same as the link time addresses.
> >         - Enable PIC (position-independent code) on a real-time target
> >           processor probably very rare.
> >     - Xen will need to use the EL2 MPU memory region descriptors to
> manage
> >       access permissions and attributes for accesses made by VMs at
> EL1/0.
> >         - Xen currently relies on MMU EL1 stage 2 table to manage these
> >           accesses.
> > - No MMU Stage 2 translation at EL1:
> >     - A guest doesn't have an independent guest physical address space
> >     - A guest can not reuse the current Intermediate Physical Address
> >       memory layout
> >     - A guest uses physical addresses to access memory and devices
> >     - The MPU at EL2 manages EL1 stage 2 access permissions and
> attributes
> > - There are a limited number of MPU protection regions at both EL2 and
> EL1:
> >     - Architecturally, the maximum number of protection regions is 256,
> >       typical implementations have 32.
> >     - By contrast, Xen does not need to consider the number of page
> table
> >       entries in theory when using MMU.
> > - The MPU protection regions at EL2 need to be shared between the
> hypervisor
> >   and the guest stage 2.
> >     - Requires careful consideration - may impact feature 'fullness' of
> both
> >       the hypervisor and the guest
> >     - By contrast, when using MMU, Xen has standalone P2M table for
> guest
> >       stage 2 accesses.
> >
> > ## 2. Proposed changes of Xen
> > ### **2.1. Changes of build system:**
> >
> > - ***Introduce new Kconfig options for Armv8-R64***:
> >   Unlike Armv8-A, because lack of MMU support on Armv8-R64, we may not
> >   expect one Xen binary to run on all machines. Xen images are not
> common
> >   across Armv8-R64 platforms. Xen must be re-built for different Armv8-
> R64
> >   platforms. Because these platforms may have different memory layout
> and
> >   link address.
> >     - `ARM64_V8R`:
> >       This option enables Armv8-R profile for Arm64. Enabling this
> option
> >       results in selecting MPU. This Kconfig option is used to gate som=
e
> >       Armv8-R64 specific code except MPU code, like some code for Armv8=
-
> R64
> >       only system ID registers access.
> >
> >     - `ARM_MPU`
> >       This option enables MPU on ARMv8-R architecture. Enabling this
> option
> >       results in disabling MMU. This Kconfig option is used to gate som=
e
> >       ARM_MPU specific code. Once when this Kconfig option has been
> enabled,
> >       the MMU relate code will not be built for Armv8-R64. The reason
> why
> >       not depends on runtime detection to select MMU or MPU is that, we
> don't
> >       think we can use one image for both Armv8-R64 and Armv8-A64.
> Another
> >       reason that we separate MPU and V8R in provision to allow to
> support MPU
> >       on 32bit Arm one day.
> >
> >     - `XEN_START_ADDRESS`
> >       This option allows to set the custom address at which Xen will be
> >       linked. This address must be aligned to a page size. Xen's run-
> time
> >       addresses are the same as the link time addresses. Different
> platforms
> >       may have differnt memory layout. This Kconfig option provides
> users
> >       the ability to select proper link addresses for their boards.
> >       ***Notes: Fixed link address means the Xen binary could not be***
> >       ***relocated by EFI loader. So in current stage, Xen could not***
> >       ***be launched as an EFI application on Armv8-R64.***
> >
> >     - `ARM_MPU_NORMAL_MEMORY_START` and `ARM_MPU_NORMAL_MEMORY_END`
> >       `ARM_MPU_DEVICE_MEMORY_START` and `ARM_MPU_DEVICE_MEMORY_END`
> >       These Kconfig options allow to set memory regions for Xen code,
> data
> >       and device memory. Before parsing memory information from device
> tree,
> >       Xen will use the values that stored in these options to setup
> boot-time
> >       MPU configuration. Why we need a boot-time MPU configuration?
> >       1. More deterministic: Arm MPU supports background regions,
> >          if we don't configure the MPU regions and don't enable MPU.
> >          We can enable MPU background regions. But that means all RAM
> >          is RWX. Random values in RAM or maliciously embedded data can
> >          be exploited. Using these Kconfig options allow users to have
> >          a deterministic RAM area to execute code.
> >       2. More compatible: On some Armv8-R64 platforms, if the MPU is
> >          disabled, the `dc zva` instruction will make the system halt.
> >          And this instruction will be embedded in some built-in
> functions,
> >          like `memory set`. If we use `-ddont_use_dc` to rebuild GCC,
> >          the built-in functions will not contain `dc zva`. However, it
> is
> >          obviously unlikely that we will be able to recompile all GCC
> >          for ARMv8-R64.
> >       3. One optional idea:
> >           We can map `XEN_START_ADDRESS` to `XEN_START_ADDRESS + 2MB` o=
r
> >           `XEN_START_ADDRESS` to `XEN_START_ADDRESS + image_end` for
> >           MPU normal memory. It's enough to support Xen run in boot tim=
e.
>
> I can imagine that we need to have a different Xen build for each
> ARMv8-R platform. Do you envision that XEN_START_ADDRESS and
> ARM_MPU_*_MEMORY_START/END are preconfigured based on the platform
> choice at build time? I don't think we want a user to provide all of
> those addresses by hand, right?

Yes, this is in our TODO list. We want to reuse current arm/platforms and
Kconfig menu for Armv8-R.

>
> The next question is whether we could automatically generate
> XEN_START_ADDRESS and ARM_MPU_*_MEMORY_START/END based on the platform
> device tree at build time (at build time, not runtime). That would
> make things a lot easier and it is also aligned with the way Zephyr and
> other RTOSes and baremetal apps work.

It's a considerable option. But here we may encounter some problems need
to be solved first:
1. Does CONFIG_DTB must be selected by default on Armv8-R? Without firmware
   or bootloader (like u-boot), we have to build DTB into Xen binary. This
   can guarantee build-time DTB is the same as runtime DTB. But eventually,
   we will have firmware and bootloader before Xen launch (as Arm EBBR's
   requirement). In this case, we may not build DTB into Xen image. And
   we can't guarantee build-time DTB is the same as runtime DTB.
2. If build-time DTB is the same as runtime DTB, how can we determine
   the XEN_START_ADDRESS in DTB describe memory range? Should we always
   limit Xen to boot from lowest address? Or will we introduce some new
   DT property to specify the Xen start address? I think this DT property
   also can solve above question#1.

>
> The device tree can be given as input to the build system, and the
> Makefiles would take care of generating XEN_START_ADDRESS and
> ARM_MPU_*_MEMORY_START/END based on /memory and other interesting nodes.
>

If we can solve above questions, yes, device tree is a good idea for
XEN_START_ADDRESS. For ARM_MPU_NORMAL_MEMORY_*, we can get them from
memory nodes, but for ARM_MPU_DEVICE_MEMORY_*, they are not easy for
us to scan all devices' nodes. And it's very tricky, if the memory
regions are interleaved. So in our current RFC code, we select to use
the optional idea:
We map `XEN_START_ADDRESS` to `XEN_START_ADDRESS + 2MB` for MPU normal memo=
ry.
But we use mpu,device-memory-section in DT for MPU device memory.

>
> > - ***Define new system registers for compilers***:
> >   Armv8-R64 is based on Armv8.4. That means we will use some Armv8.4
> >   specific system registers. As Armv8-R64 only have secure state, so
> >   at least, `VSTCR_EL2` and `VSCTLR_EL2` will be used for Xen. And the
> >   first GCC version that supports Armv8.4 is GCC 8.1. In addition to
> >   these, PMSA of Armv8-R64 introduced lots of MPU related system
> registers:
> >   `PRBAR_ELx`, `PRBARx_ELx`, `PRLAR_ELx`, `PRLARx_ELx`, `PRENR_ELx` and
> >   `MPUIR_ELx`. But the first GCC version to support these system
> registers
> >   is GCC 11. So we have two ways to make compilers to work properly wit=
h
> >   these system registers.
> >   1. Bump GCC version to GCC 11.
> >      The pros of this method is that, we don't need to encode these
> >      system registers in macros by ourselves. But the cons are that,
> >      we have to update Makefiles to support GCC 11 for Armv8-R64.
> >      1.1. Check the GCC version 11 for Armv8-R64.
> >      1.2. Add march=3Darmv8r to CFLAGS for Armv8-R64.
> >      1.3. Solve the confliction of march=3Darmv8r and mcpu=3Dgeneric
> >     These changes will affect common Makefiles, not only Arm Makefiles.
> >     And GCC 11 is new, lots of toolchains and Distro haven't supported
> it.
> >
> >   2. Encode new system registers in macros ***(preferred)***
> >         ```
> >         /* Virtualization Secure Translation Control Register */
> >         #define VSTCR_EL2  S3_4_C2_C6_2
> >         /* Virtualization System Control Register */
> >         #define VSCTLR_EL2 S3_4_C2_C0_0
> >         /* EL1 MPU Protection Region Base Address Register encode */
> >         #define PRBAR_EL1  S3_0_C6_C8_0
> >         ...
> >         /* EL2 MPU Protection Region Base Address Register encode */
> >         #define PRBAR_EL2  S3_4_C6_C8_0
> >         ...
> >         ```
> >      If we encode all above system registers, we don't need to bump GCC
> >      version. And the common CFLAGS Xen is using still can be applied t=
o
> >      Armv8-R64. We don't need to modify Makefiles to add specific CFLAG=
S.
>
> I think that's fine and we did something similar with the original ARMv7-=
A
> port if I remember correctly.
>
>
> > ### **2.2. Changes of the initialization process**
> > In general, we still expect Armv8-R64 and Armv8-A64 to have a consisten=
t
> > initialization process. In addition to some architecture differences,
> there
> > is no more than reusable code that we will distinguish through
> CONFIG_ARM_MPU
> > or CONFIG_ARM64_V8R. We want most of the initialization code to be
> reusable
> > between Armv8-R64 and Armv8-A64.
>
> +1
>
>
> > - We will reuse the original head.s and setup.c of Arm. But replace the
> >   MMU and page table operations in these files with configuration
> operations
> >   for MPU and MPU regions.
> >
> > - We provide a boot-time MPU configuration. This MPU configuration will
> >   support Xen to finish its initialization. And this boot-time MPU
> >   configuration will record the memory regions that will be parsed from
> >   device tree.
> >
> >   In the end of Xen initialization, we will use a runtime MPU
> configuration
> >   to replace boot-time MPU configuration. The runtime MPU configuration
> will
> >   merge and reorder memory regions to save more MPU regions for guests.
> >   ![img](https://drive.google.com/uc?export=3Dview&id=3D1wTFyK2XfU3lTlH=
1PqRD
> oacQVTwUtWIGU)
> >
> > - Defer system unpausing domain.
> >   When Xen initialization is about to end, Xen unpause guests created
> >   during initialization. But this will cause some issues. The unpause
> >   action occurs before free_init_memory, however the runtime MPU
> configuration
> >   is built after free_init_memory.
> >
> >   So if the unpaused guests start executing the context switch at this
> >   point, then its MPU context will base on the boot-time MPU
> configuration.
> >   Probably it will be inconsistent with runtime MPU configuration, this
> >   will cause unexpected problems (This may not happen in a single core
> >   system, but on SMP systems, this problem is foreseeable, so we hope t=
o
> >   solve it at the beginning).
> >
> > ### **2.3. Changes to reduce memory fragmentation**
> >
> > In general, memory in Xen system can be classified to 4 classes:
> > `image sections`, `heap sections`, `guest RAM`, `boot modules (guest
> Kernel,
> > initrd and dtb)`
> >
> > Currently, Xen doesn't have any restriction for users how to allocate
> > memory for different classes. That means users can place boot modules
> > anywhere, can reserve Xen heap memory anywhere and can allocate guest
> > memory anywhere.
> >
> > In a VMSA system, this would not be too much of a problem, since the
> > MMU can manage memory at a granularity of 4KB after all. But in a
> > PMSA system, this will be a big problem. On Armv8-R64, the max MPU
> > protection regions number has been limited to 256. But in typical
> > processor implementations, few processors will design more than 32
> > MPU protection regions. Add in the fact that Xen shares MPU protection
> > regions with guest's EL1 Stage 2. It becomes even more important
> > to properly plan the use of MPU protection regions.
> >
> > - An ideal of memory usage layout restriction:
> > ![img](https://drive.google.com/uc?export=3Dview&id=3D1kirOL0Tx2aAypTtd=
3kXAt
> d75XtrngcnW)
> > 1. Reserve proper MPU regions for Xen image (code, rodata and data +
> bss).
> > 2. Reserve one MPU region for boot modules.
> >    That means the placement of all boot modules, include guest kernel,
> >    initrd and dtb, will be limited to this MPU region protected area.
> > 3. Reserve one or more MPU regions for Xen heap.
> >    On Armv8-R64, the guest memory is predefined in device tree, it will
> >    not be allocated from heap. Unlike Armv8-A64, we will not move all
> >    free memory to heap. We want Xen heap is dertermistic too, so Xen on
> >    Armv8-R64 also rely on Xen static heap feature. The memory for Xen
> >    heap will be defined in tree too. Considering that physical memory
> >    can also be discontinuous, one or more MPU protection regions needs
> >    to be reserved for Xen HEAP.
> > 4. If we name above used MPU protection regions PART_A, and name left
> >    MPU protection regions PART_B:
> >    4.1. In hypervisor context, Xen will map left RAM and devices to
> PART_B.
> >         This will give Xen the ability to access whole memory.
> >    4.2. In guest context, Xen will create EL1 stage 2 mapping in PART_B=
.
> >         In this case, Xen just need to update PART_B in context switch,
> >         but keep PART_A as fixed.
>
> I think that the memory layout and restrictions that you wrote above
> make sense. I have some comments on the way they are represented in
> device tree, but that's different.
>
>
> > ***Notes: Static allocation will be mandatory on MPU based systems***
> >
> > **A sample device tree of memory layout restriction**:
> > ```
> > chosen {
> >     ...
> >     /*
> >      * Define a section to place boot modules,
> >      * all boot modules must be placed in this section.
> >      */
> >     mpu,boot-module-section =3D <0x10000000 0x10000000>;
> >     /*
> >      * Define a section to cover all guest RAM. All guest RAM must be
> located
> >      * within this section. The pros is that, in best case, we can only
> have
> >      * one MPU protection region to map all guest RAM for Xen.
> >      */
> >     mpu,guest-memory-section =3D <0x20000000 0x30000000>;
> >     /*
> >      * Define a memory section that can cover all device memory that
> >      * will be used in Xen.
> >      */
> >     mpu,device-memory-section =3D <0x80000000 0x7ffff000>;
> >     /* Define a section for Xen heap */
> >     xen,static-mem =3D <0x50000000 0x20000000>;
>
> As mentioned above, I understand the need for these sections, but why do
> we need to describe them in device tree at all? Could Xen select them by
> itself during boot?

I think without some inputs, Xen could not do this or will do it in some
assumption. For example, assume the first the boot-module-section determine=
d
by lowest address and highest address of all modules. And the same for
guest-memory-section, calculated from all guest allocated memory regions.


>
> If not, and considering that we have to generate
> ARM_MPU_*_MEMORY_START/END anyway at build time, would it make sense to
> also generate mpu,guest-memory-section, xen,static-mem, etc. at build
> time rather than passing it via device tree to Xen at runtime?
>

Did you mean we still add these information in device tree, but for build
time only. In runtime we don't parse them?

> What's the value of doing ARM_MPU_*_MEMORY_START/END at build time and
> everything else at runtime?

ARM_MPU_*_MEMORY_START/END is defined by platform. But other things are
users customized. They can change their usage without rebuild the image.

>
> It looks like we are forced to have the sections definitions at build
> time because we need them before we can parse device tree. In that case,
> we might as well define all the sections at build time.
>
> But I think it would be even better if Xen could automatically choose
> xen,static-mem, mpu,guest-memory-section, etc. on its own based on the
> regular device tree information (/memory, /amba, etc.), without any need
> for explicitly describing each range with these new properties.
>

for mpu,guest-memory-section, with the limitations: no other usage between
different guest' memory nodes, this is OK. But for xen,static-mem (heap),
we just want everything on a MPU system is dertermistic. But, of course Xen
can select left memory for heap without static-mem.

>
> >     domU1 {
> >         ...
> >         #xen,static-mem-address-cells =3D <0x01>;
> >         #xen,static-mem-size-cells =3D <0x01>;
> >         /* Statically allocated guest memory, within mpu,guest-memory-
> section */
> >         xen,static-mem =3D <0x30000000 0x1f000000>;
> >
> >         module@11000000 {
> >             compatible =3D "multiboot,kernel\0multiboot,module";
> >             /* Boot module address, within mpu,boot-module-section */
> >             reg =3D <0x11000000 0x3000000>;
> >             ...
> >         };
> >
> >         module@10FF0000 {
> >                 compatible =3D "multiboot,device-tree\0multiboot,module=
";
> >                 /* Boot module address, within mpu,boot-module-section
> */
> >                 reg =3D <0x10ff0000 0x10000>;
> >                 ...
> >         };
> >     };
> > };
> > ```
> >
> > ### **2.4. Changes of memory management**
> > Xen is coupled with VMSA, in order to port Xen to Armv8-R64, we have to
> > decouple Xen from VMSA. And give Xen the ability to manage memory in
> PMSA.
> >
> > 1. ***Use buddy allocator to manage physical pages for PMSA***
> >    From the view of physical page, PMSA and VMSA don't have any
> difference.
> >    So we can reuse buddy allocator on Armv8-R64 to manage physical page=
s.
> >    The difference is that, in VMSA, Xen will map allocated pages to
> virtual
> >    addresses. But in PMSA, Xen just convert the pages to physical
> address.
> >
> > 2. ***Can not use virtual address for memory management***
> >    As Armv8-R64 only has PMSA in EL2, Xen loses the ability of using
> virtual
> >    address to manage memory. This brings some problems, some virtual
> address
> >    based features could not work well on Armv8-R64, like `FIXMAP`,
> `vmap/vumap`,
> >    `ioremap` and `alternative`.
> >
> >    But the functions or macros of these features are used in lots of
> common
> >    code. So it's not good to use `#ifdef CONFIG_ARM_MPU` to gate relate
> code
> >    everywhere. In this case, we propose to use stub helpers to make the
> changes
> >    transparently to common code.
> >    1. For `FIXMAP`, we will use `0` in `FIXMAP_ADDR` for all fixmap
> operations.
> >       This will return physical address directly of fixmapped item.
> >    2. For `vmap/vumap`, we will use some empty inline stub helpers:
> >         ```
> >         static inline void vm_init_type(...) {}
> >         static inline void *__vmap(...)
> >         {
> >             return NULL;
> >         }
> >         static inline void vunmap(const void *va) {}
> >         static inline void *vmalloc(size_t size)
> >         {
> >             return NULL;
> >         }
> >         static inline void *vmalloc_xen(size_t size)
> >         {
> >             return NULL;
> >         }
> >         static inline void vfree(void *va) {}
> >         ```
> >
> >    3. For `ioremap`, it depends on `vmap`. As we have make `vmap` to
> always
> >       return `NULL`, they could not work well on Armv8-R64 without
> changes.
> >       `ioremap` will return input address directly.
> >         ```
> >         static inline void *ioremap_attr(...)
> >         {
> >             /* We don't have the ability to change input PA cache
> attributes */
> >             if ( CACHE_ATTR_need_change )
> >                 return NULL;
> >             return (void *)pa;
> >         }
> >         static inline void __iomem *ioremap_nocache(...)
> >         {
> >             return ioremap_attr(start, len, PAGE_HYPERVISOR_NOCACHE);
> >         }
> >         static inline void __iomem *ioremap_cache(...)
> >         {
> >             return ioremap_attr(start, len, PAGE_HYPERVISOR);
> >         }
> >         static inline void __iomem *ioremap_wc(...)
> >         {
> >             return ioremap_attr(start, len, PAGE_HYPERVISOR_WC);
> >         }
> >         void *ioremap(...)
> >         {
> >             return ioremap_attr(pa, len, PAGE_HYPERVISOR_NOCACHE);
> >         }
> >
> >         ```
> >     4. For `alternative`, it depends on `vmap` too. We will simply
> disable
> >        it on Armv8-R64 in current stage. How to implement `alternative`
> >        on Armv8-R64 is better to be discussed after basic functions of
> Xen
> >        on Armv8-R64 work well.
> >        But simply disable `alternative` will make `cpus_have_const_cap`
> always
> >        return false.
> >         ```
> >         * System capability check for constant cap */
> >         #define cpus_have_const_cap(num) ({                \
> >                register_t __ret;                           \
> >                                                            \
> >                asm volatile (ALTERNATIVE("mov %0, #0",     \
> >                                          "mov %0, #1",     \
> >                                          num)              \
> >                              : "=3Dr" (__ret));              \
> >                                                            \
> >                 unlikely(__ret);                           \
> >                 })
> >         ```
> >         So, before we have an PMSA `alternative` implementation, we hav=
e
> to
> >         implement a separate `cpus_have_const_cap` for Armv8-R64:
> >         ```
> >         #define cpus_have_const_cap(num) cpus_have_cap(num)
> >         ```
>
> I think it is OK to disable alternative
>
>
> > ### **2.5. Changes of guest management**
> > Armv8-R64 only supports PMSA in EL2, but it supports configurable
> > VMSA or PMSA in EL1. This means Xen will have a new type guest on
> > Armv8-R64 - MPU based guest.
> >
> > 1. **Add a new domain type - MPU_DOMAIN**
> >    When user want to create a guest that will be using MPU in EL1, user
> >    should add a `mpu` property in device tree `domU` node, like
> following
> >    example:
> >     ```
> >     domU2 {
> >         compatible =3D "xen,domain";
> >         direct-map;
> >         mpu; --> Indicates this domain will use PMSA in EL1.
> >         ...
> >     };
> >     ```
> >     Corresponding to `mpu` property in device tree, we also need to
> introduce
> >     a new flag `XEN_DOMCTL_CDF_INTERNAL_mpu` for domain to mark itself
> as an
> >     MPU domain. This flag will be used in domain creation and domain
> doing
> >     vCPU context switch.
> >     1. Domain creation need this flag to decide enable PMSA or VMSA in
> EL1.
> >     2. vCPU context switch need this flag to decide save/restore MMU or
> MPU
> >        related registers.
> >
> > 2. **Add MPU registers to vCPU save EL1 MPU context**
> >    Current Xen only support MMU based guest, so it hasn't considered to
> >    save/restore MPU context. In this case, we need to add MPU registers
> >    to `arch_vcpu`:
> >     ```
> >     struct arch_vcpu
> >     {
> >     #ifdef CONFIG_ARM_MPU
> >         /* Virtualization Translation Control Register */
> >         register_t vtcr_el2;
> >
> >         /* EL1 MPU regions' registers */
> >         pr_t mpu_regions[CONFIG_ARM_MPU_EL1_PROTECTION_REGIONS];
> >     #endif
> >     }
> >     ```
> >     Armv8-R64 can support max to 256 MPU regions. But that's just
> theoretical.
> >     So we don't want to define `pr_t mpu_regions[256]`, this is a memor=
y
> waste
> >     in most of time. So we decided to let the user specify through a
> Kconfig
> >     option. `CONFIG_ARM_MPU_EL1_PROTECTION_REGIONS` default value can b=
e
> `32`,
> >     it's a typical implementation on Armv8-R64. Users will recompile Xe=
n
> when
> >     their platform changes. So when the MPU changes, respecifying the
> MPU
> >     protection regions number will not cause additional problems.
>
> I wonder if we could probe the number of MPU regions at runtime and
> dynamically allocate the memory needed to store them in arch_vcpu.
>

We have considered to used a pr_t mpu_regions[0] in arch_vcpu. But it seems
we will encounter some static allocated arch_vcpu problems and sizeof issue=
.

>
> >
> > 3. **MPU based P2M table management**
> >    Armv8-R64 EL2 doesn't have EL1 stage 2 address translation. But
> through
> >    PMSA, it still has the ability to control the permissions and
> attributes
> >    of EL1 stage 2. In this case, we still hope to keep the interface
> >    consistent with MMU based P2M as far as possible.
> >
> >    p2m->root will point to an allocated memory. In Armv8-A64, this
> memory
> >    is used to save the EL1 stage 2 translation table. But in Armv8-R64,
> >    this memory will be used to store EL2 MPU protection regions that ar=
e
> >    used by guest. During domain creation, Xen will prepare the data in
> >    this memory to make guest can access proper RAM and devices. When th=
e
> >    guest's vCPU will be scheduled in, this data will be written to MPU
> >    protection region registers.
> >
> > ### **2.6. Changes of exception trap**
> > As Armv8-R64 has compatible exception mode with Armv8-A64, so we can
> reuse most
> > of Armv8-A64's exception trap & handler code. But except the trap based
> on EL1
> > stage 2 translation abort.
> >
> > In Armv8-A64, we use `FSC_FLT_TRANS`
> > ```
> >     case FSC_FLT_TRANS:
> >         ...
> >         if ( is_data )
> >         {
> >             enum io_state state =3D try_handle_mmio(regs, hsr, gpa);
> >             ...
> >         }
> > ```
> > But for Armv8-R64, we have to use `FSC_FLT_PERM`
> > ```
> >     case FSC_FLT_PERM:
> >         ...
> >         if ( is_data )
> >         {
> >             enum io_state state =3D try_handle_mmio(regs, hsr, gpa);
> >             ...
> >         }
> > ```
> >
> > ### **2.5. Changes of device driver**
> > 1. Because Armv8-R64 only has single secure state, this will affect som=
e
> > devices that have two secure state, like GIC. But fortunately, most
> > vendors will not link a two secure state GIC to Armv8-R64 processors.
> > Current GIC driver can work well with single secure state GIC for Armv8=
-
> R64.
> > 2. Xen should use secure hypervisor timer in Secure EL2. We will
> introduce
> > a CONFIG_ARM_SECURE_STATE to make Xen to use secure registers for timer=
.
> >
> > ### **2.7. Changes of virtual device**
> > Currently, we only support pass-through devices in guest. Because event
> > channel, xen-bus, xen-storage and other advanced Xen features haven't
> been
> > enabled in Armv8-R64.
>
> That's fine -- it is a great start! Looking forward to it!

--_000_AS1PR08MB74269923288B75097392BDD99E3E9AS1PR08MB7426eurp_
Content-Type: text/html; charset="iso-2022-jp"
Content-Transfer-Encoding: quoted-printable

<html>
<head>
<meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3Diso-2022-=
jp">
</head>
<body>
<div></div>
<font size=3D"2"><span style=3D"font-size:11pt;">
<div class=3D"PlainText">Hi Stefano,<br>
<br>
&gt; -----Original Message-----<br>
&gt; From: Stefano Stabellini &lt;sstabellini@kernel.org&gt;<br>
&gt; Sent: 2022=1B$BG/=1B(B2=1B$B7n=1B(B25=1B$BF|=1B(B 8:56<br>
&gt; To: Wei Chen &lt;Wei.Chen@arm.com&gt;<br>
&gt; Cc: xen-devel@lists.xenproject.org; julien@xen.org; Stefano Stabellini=
<br>
&gt; &lt;sstabellini@kernel.org&gt;; Bertrand Marquis &lt;Bertrand.Marquis@=
arm.com&gt;;<br>
&gt; Penny Zheng &lt;Penny.Zheng@arm.com&gt;; Henry Wang &lt;Henry.Wang@arm=
.com&gt;; nd<br>
&gt; &lt;nd@arm.com&gt;<br>
&gt; Subject: Re: Proposal for Porting Xen to Armv8-R64 - DraftA<br>
&gt; <br>
&gt; Hi Wei,<br>
&gt; <br>
&gt; This is extremely exciting, thanks for the very nice summary!<br>
&gt; <br>
&gt; <br>
&gt; On Thu, 24 Feb 2022, Wei Chen wrote:<br>
&gt; &gt; # Proposal for Porting Xen to Armv8-R64<br>
&gt; &gt;<br>
&gt; &gt; This proposal will introduce the PoC work of porting Xen to Armv8=
-R64,<br>
&gt; &gt; which includes:<br>
&gt; &gt; - The changes of current Xen capability, like Xen build system, m=
emory<br>
&gt; &gt;&nbsp;&nbsp; management, domain management, vCPU context switch.<b=
r>
&gt; &gt; - The expanded Xen capability, like static-allocation and direct-=
map.<br>
&gt; &gt;<br>
&gt; &gt; ***Notes:***<br>
&gt; &gt; 1. ***This proposal only covers the work of porting Xen to Armv8-=
R64***<br>
&gt; &gt;&nbsp;&nbsp;&nbsp; ***single CPU. Xen SMP support on Armv8-R64 rel=
ates to Armv8-R***<br>
&gt; &gt;&nbsp;&nbsp;&nbsp; ***Trusted-Frimware (TF-R). This is an external=
 dependency,***<br>
&gt; &gt;&nbsp;&nbsp;&nbsp; ***so we think the discussion of Xen SMP suppor=
t on Armv8-R64***<br>
&gt; &gt;&nbsp;&nbsp;&nbsp; ***should be started when single-CPU support is=
 complete.***<br>
&gt; &gt; 2. ***This proposal will not touch xen-tools. In current stage,**=
*<br>
&gt; &gt;&nbsp;&nbsp;&nbsp; ***Xen on Armv8-R64 only support dom0less, all =
guests should***<br>
&gt; &gt;&nbsp;&nbsp;&nbsp; ***be booted from device tree.***<br>
&gt; &gt;<br>
&gt; &gt; ## 1. Essential Background<br>
&gt; &gt;<br>
&gt; &gt; ### 1.1. Armv8-R64 Profile<br>
&gt; &gt; The Armv-R architecture profile was designed to support use cases=
 that<br>
&gt; &gt; have a high sensitivity to deterministic execution. (e.g. Fuel In=
jection,<br>
&gt; &gt; Brake control, Drive trains, Motor control etc)<br>
&gt; &gt;<br>
&gt; &gt; Arm announced Armv8-R in 2013, it is the latest generation Arm<br=
>
&gt; architecture<br>
&gt; &gt; targeted at the Real-time profile. It introduces virtualization a=
t the<br>
&gt; highest<br>
&gt; &gt; security level while retaining the Protected Memory System Archit=
ecture<br>
&gt; (PMSA)<br>
&gt; &gt; based on a Memory Protection Unit (MPU). In 2020, Arm announced C=
ortex-<br>
&gt; R82,<br>
&gt; &gt; which is the first Arm 64-bit Cortex-R processor based on Armv8-R=
64.<br>
&gt; &gt;<br>
&gt; &gt; - The latest Armv8-R64 document can be found here:<br>
&gt; &gt;&nbsp;&nbsp; [Arm Architecture Reference Manual Supplement - Armv8=
, for Armv8-R<br>
&gt; AArch64 architecture<br>
&gt; profile](<a href=3D"https://developer.arm.com/documentation/ddi0600/la=
test/">https://developer.arm.com/documentation/ddi0600/latest/</a>).<br>
&gt; &gt;<br>
&gt; &gt; - Armv-R Architecture progression:<br>
&gt; &gt;&nbsp;&nbsp; Armv7-R -&gt; Armv8-R AArch32 -&gt; Armv8 AArch64<br>
&gt; &gt;&nbsp;&nbsp; The following figure is a simple comparison of &quot;=
R&quot; processors based on<br>
&gt; &gt;&nbsp;&nbsp; different Armv-R Architectures.<br>
&gt; &gt;&nbsp;&nbsp; ![image](https://drive.google.com/uc?export=3Dview&am=
p;id=3D1nE5RAXaX8zY2KPZ8i<br>
&gt; mBpbvIr2eqBguEB)<br>
&gt; &gt;<br>
&gt; &gt; - The Armv8-R architecture evolved additional features on top of =
Armv7-R:<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; - An exception model that is compatible w=
ith the Armv8-A model<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; - Virtualization with support for guest o=
perating systems<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; - PMSA virtualiza=
tion using MPUs In EL2.<br>
&gt; &gt; - The new features of Armv8-R64 architecture<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; - Adds support for the 64-bit A64 instruc=
tion set, previously Armv8-<br>
&gt; R<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; only supported A32.<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; - Supports up to 48-bit physical addressi=
ng, previously up to 32-bit<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; addressing was supported.<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; - Optional Arm Neon technology and Advanc=
ed SIMD<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; - Supports three Exception Levels (ELs)<b=
r>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; - Secure EL2 - Th=
e Highest Privilege, MPU only, for firmware,<br>
&gt; hypervisor<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; - Secure EL1 - Ri=
chOS (MMU) or RTOS (MPU)<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; - Secure EL0 - Ap=
plication Workloads<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; - Optionally supports Virtual Memory Syst=
em Architecture at S-EL1/S-<br>
&gt; EL0.<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; This means it's possible to r=
un rich OS kernels - like Linux -<br>
&gt; either<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; bare-metal or as a guest.<br>
&gt; &gt; - Differences with the Armv8-A AArch64 architecture<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; - Supports only a single Security state -=
 Secure. There is not Non-<br>
&gt; Secure<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; execution state supported.<br=
>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; - EL3 is not supported, EL2 is mandatory.=
 This means secure EL2 is<br>
&gt; the<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; highest EL.<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; - Supports the A64 ISA instruction<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; - With a small se=
t of well-defined differences<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; - Provides a PMSA (Protected Memory Syste=
m Architecture) based<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; virtualization model.<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; - As opposed to A=
rmv8-A AArch64's VMSA based Virtualization<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; - Can support add=
ress bits up to 52 if FEAT_LPA is enabled,<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; other=
wise 48 bits.<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; - Determines the =
access permissions and memory attributes of<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; the t=
arget PA.<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; - Can implement P=
MSAv8-64 at EL1 and EL2<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;=
&nbsp; - Address translation flat-maps the VA to the PA for EL2<br>
&gt; Stage 1.<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;=
&nbsp; - Address translation flat-maps the VA to the PA for EL1<br>
&gt; Stage 1.<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;=
&nbsp; - Address translation flat-maps the IPA to the PA for EL1<br>
&gt; Stage 2.<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; - PMSA in EL1 &amp; EL2 is configurable, =
VMSA in EL1 is configurable.<br>
&gt; &gt;<br>
&gt; &gt; ### 1.2. Xen Challenges with PMSA Virtualization<br>
&gt; &gt; Xen is PMSA unaware Type-1 Hypervisor, it will need modifications=
 to run<br>
&gt; &gt; with an MPU and host multiple guest OSes.<br>
&gt; &gt;<br>
&gt; &gt; - No MMU at EL2:<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; - No EL2 Stage 1 address translation<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; - Xen provides fi=
xed ARM64 virtual memory layout as basis of EL2<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; stage=
 1 address translation, which is not applicable on MPU<br>
&gt; system,<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; where=
 there is no virtual addressing. As a result, any<br>
&gt; operation<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; invol=
ving transition from PA to VA, like ioremap, needs<br>
&gt; modification<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; on MP=
U system.<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; - Xen's run-time addresses are the same a=
s the link time addresses.<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; - Enable PIC (pos=
ition-independent code) on a real-time target<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; proce=
ssor probably very rare.<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; - Xen will need to use the EL2 MPU memory=
 region descriptors to<br>
&gt; manage<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; access permissions and attrib=
utes for accesses made by VMs at<br>
&gt; EL1/0.<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; - Xen currently r=
elies on MMU EL1 stage 2 table to manage these<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; acces=
ses.<br>
&gt; &gt; - No MMU Stage 2 translation at EL1:<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; - A guest doesn't have an independent gue=
st physical address space<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; - A guest can not reuse the current Inter=
mediate Physical Address<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; memory layout<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; - A guest uses physical addresses to acce=
ss memory and devices<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; - The MPU at EL2 manages EL1 stage 2 acce=
ss permissions and<br>
&gt; attributes<br>
&gt; &gt; - There are a limited number of MPU protection regions at both EL=
2 and<br>
&gt; EL1:<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; - Architecturally, the maximum number of =
protection regions is 256,<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; typical implementations have =
32.<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; - By contrast, Xen does not need to consi=
der the number of page<br>
&gt; table<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; entries in theory when using =
MMU.<br>
&gt; &gt; - The MPU protection regions at EL2 need to be shared between the=
<br>
&gt; hypervisor<br>
&gt; &gt;&nbsp;&nbsp; and the guest stage 2.<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; - Requires careful consideration - may im=
pact feature 'fullness' of<br>
&gt; both<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; the hypervisor and the guest<=
br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; - By contrast, when using MMU, Xen has st=
andalone P2M table for<br>
&gt; guest<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; stage 2 accesses.<br>
&gt; &gt;<br>
&gt; &gt; ## 2. Proposed changes of Xen<br>
&gt; &gt; ### **2.1. Changes of build system:**<br>
&gt; &gt;<br>
&gt; &gt; - ***Introduce new Kconfig options for Armv8-R64***:<br>
&gt; &gt;&nbsp;&nbsp; Unlike Armv8-A, because lack of MMU support on Armv8-=
R64, we may not<br>
&gt; &gt;&nbsp;&nbsp; expect one Xen binary to run on all machines. Xen ima=
ges are not<br>
&gt; common<br>
&gt; &gt;&nbsp;&nbsp; across Armv8-R64 platforms. Xen must be re-built for =
different Armv8-<br>
&gt; R64<br>
&gt; &gt;&nbsp;&nbsp; platforms. Because these platforms may have different=
 memory layout<br>
&gt; and<br>
&gt; &gt;&nbsp;&nbsp; link address.<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; - `ARM64_V8R`:<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; This option enables Armv8-R p=
rofile for Arm64. Enabling this<br>
&gt; option<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; results in selecting MPU. Thi=
s Kconfig option is used to gate some<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; Armv8-R64 specific code excep=
t MPU code, like some code for Armv8-<br>
&gt; R64<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; only system ID registers acce=
ss.<br>
&gt; &gt;<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; - `ARM_MPU`<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; This option enables MPU on AR=
Mv8-R architecture. Enabling this<br>
&gt; option<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; results in disabling MMU. Thi=
s Kconfig option is used to gate some<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; ARM_MPU specific code. Once w=
hen this Kconfig option has been<br>
&gt; enabled,<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; the MMU relate code will not =
be built for Armv8-R64. The reason<br>
&gt; why<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; not depends on runtime detect=
ion to select MMU or MPU is that, we<br>
&gt; don't<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; think we can use one image fo=
r both Armv8-R64 and Armv8-A64.<br>
&gt; Another<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; reason that we separate MPU a=
nd V8R in provision to allow to<br>
&gt; support MPU<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; on 32bit Arm one day.<br>
&gt; &gt;<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; - `XEN_START_ADDRESS`<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; This option allows to set the=
 custom address at which Xen will be<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; linked. This address must be =
aligned to a page size. Xen's run-<br>
&gt; time<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; addresses are the same as the=
 link time addresses. Different<br>
&gt; platforms<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; may have differnt memory layo=
ut. This Kconfig option provides<br>
&gt; users<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; the ability to select proper =
link addresses for their boards.<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; ***Notes: Fixed link address =
means the Xen binary could not be***<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; ***relocated by EFI loader. S=
o in current stage, Xen could not***<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; ***be launched as an EFI appl=
ication on Armv8-R64.***<br>
&gt; &gt;<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; - `ARM_MPU_NORMAL_MEMORY_START` and `ARM_=
MPU_NORMAL_MEMORY_END`<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; `ARM_MPU_DEVICE_MEMORY_START`=
 and `ARM_MPU_DEVICE_MEMORY_END`<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; These Kconfig options allow t=
o set memory regions for Xen code,<br>
&gt; data<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; and device memory. Before par=
sing memory information from device<br>
&gt; tree,<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; Xen will use the values that =
stored in these options to setup<br>
&gt; boot-time<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; MPU configuration. Why we nee=
d a boot-time MPU configuration?<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; 1. More deterministic: Arm MP=
U supports background regions,<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; if we don't=
 configure the MPU regions and don't enable MPU.<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; We can enab=
le MPU background regions. But that means all RAM<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; is RWX. Ran=
dom values in RAM or maliciously embedded data can<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; be exploite=
d. Using these Kconfig options allow users to have<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; a determini=
stic RAM area to execute code.<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; 2. More compatible: On some A=
rmv8-R64 platforms, if the MPU is<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; disabled, t=
he `dc zva` instruction will make the system halt.<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; And this in=
struction will be embedded in some built-in<br>
&gt; functions,<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; like `memor=
y set`. If we use `-ddont_use_dc` to rebuild GCC,<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; the built-i=
n functions will not contain `dc zva`. However, it<br>
&gt; is<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; obviously u=
nlikely that we will be able to recompile all GCC<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; for ARMv8-R=
64.<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; 3. One optional idea:<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; We ca=
n map `XEN_START_ADDRESS` to `XEN_START_ADDRESS + 2MB` or<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; `XEN_=
START_ADDRESS` to `XEN_START_ADDRESS + image_end` for<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; MPU n=
ormal memory. It's enough to support Xen run in boot time.<br>
&gt; <br>
&gt; I can imagine that we need to have a different Xen build for each<br>
&gt; ARMv8-R platform. Do you envision that XEN_START_ADDRESS and<br>
&gt; ARM_MPU_*_MEMORY_START/END are preconfigured based on the platform<br>
&gt; choice at build time? I don't think we want a user to provide all of<b=
r>
&gt; those addresses by hand, right?<br>
<br>
Yes, this is in our TODO list. We want to reuse current arm/platforms and<b=
r>
Kconfig menu for Armv8-R.<br>
<br>
&gt; <br>
&gt; The next question is whether we could automatically generate<br>
&gt; XEN_START_ADDRESS and ARM_MPU_*_MEMORY_START/END based on the platform=
<br>
&gt; device tree at build time (at build time, not runtime). That would<br>
&gt; make things a lot easier and it is also aligned with the way Zephyr an=
d<br>
&gt; other RTOSes and baremetal apps work.<br>
<br>
It's a considerable option. But here we may encounter some problems need<br=
>
to be solved first:<br>
1. Does CONFIG_DTB must be selected by default on Armv8-R? Without firmware=
<br>
&nbsp;&nbsp; or bootloader (like u-boot), we have to build DTB into Xen bin=
ary. This<br>
&nbsp;&nbsp; can guarantee build-time DTB is the same as runtime DTB. But e=
ventually,<br>
&nbsp;&nbsp; we will have firmware and bootloader before Xen launch (as Arm=
 EBBR's<br>
&nbsp;&nbsp; requirement). In this case, we may not build DTB into Xen imag=
e. And<br>
&nbsp;&nbsp; we can't guarantee build-time DTB is the same as runtime DTB.<=
br>
2. If build-time DTB is the same as runtime DTB, how can we determine<br>
&nbsp;&nbsp; the XEN_START_ADDRESS in DTB describe memory range? Should we =
always<br>
&nbsp;&nbsp; limit Xen to boot from lowest address? Or will we introduce so=
me new<br>
&nbsp;&nbsp; DT property to specify the Xen start address? I think this DT =
property<br>
&nbsp;&nbsp; also can solve above question#1.<br>
<br>
&gt; <br>
&gt; The device tree can be given as input to the build system, and the<br>
&gt; Makefiles would take care of generating XEN_START_ADDRESS and<br>
&gt; ARM_MPU_*_MEMORY_START/END based on /memory and other interesting node=
s.<br>
&gt; <br>
<br>
If we can solve above questions, yes, device tree is a good idea for<br>
XEN_START_ADDRESS. For ARM_MPU_NORMAL_MEMORY_*, we can get them from<br>
memory nodes, but for ARM_MPU_DEVICE_MEMORY_*, they are not easy for<br>
us to scan all devices' nodes. And it's very tricky, if the memory<br>
regions are interleaved. So in our current RFC code, we select to use<br>
the optional idea:<br>
We map `XEN_START_ADDRESS` to `XEN_START_ADDRESS + 2MB` for MPU normal memo=
ry.<br>
But we use mpu,device-memory-section in DT for MPU device memory.<br>
<br>
&gt; <br>
&gt; &gt; - ***Define new system registers for compilers***:<br>
&gt; &gt;&nbsp;&nbsp; Armv8-R64 is based on Armv8.4. That means we will use=
 some Armv8.4<br>
&gt; &gt;&nbsp;&nbsp; specific system registers. As Armv8-R64 only have sec=
ure state, so<br>
&gt; &gt;&nbsp;&nbsp; at least, `VSTCR_EL2` and `VSCTLR_EL2` will be used f=
or Xen. And the<br>
&gt; &gt;&nbsp;&nbsp; first GCC version that supports Armv8.4 is GCC 8.1. I=
n addition to<br>
&gt; &gt;&nbsp;&nbsp; these, PMSA of Armv8-R64 introduced lots of MPU relat=
ed system<br>
&gt; registers:<br>
&gt; &gt;&nbsp;&nbsp; `PRBAR_ELx`, `PRBARx_ELx`, `PRLAR_ELx`, `PRLARx_ELx`,=
 `PRENR_ELx` and<br>
&gt; &gt;&nbsp;&nbsp; `MPUIR_ELx`. But the first GCC version to support the=
se system<br>
&gt; registers<br>
&gt; &gt;&nbsp;&nbsp; is GCC 11. So we have two ways to make compilers to w=
ork properly with<br>
&gt; &gt;&nbsp;&nbsp; these system registers.<br>
&gt; &gt;&nbsp;&nbsp; 1. Bump GCC version to GCC 11.<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; The pros of this method is that, we=
 don't need to encode these<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; system registers in macros by ourse=
lves. But the cons are that,<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; we have to update Makefiles to supp=
ort GCC 11 for Armv8-R64.<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; 1.1. Check the GCC version 11 for A=
rmv8-R64.<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; 1.2. Add march=3Darmv8r to CFLAGS f=
or Armv8-R64.<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; 1.3. Solve the confliction of march=
=3Darmv8r and mcpu=3Dgeneric<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; These changes will affect common Makefile=
s, not only Arm Makefiles.<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; And GCC 11 is new, lots of toolchains and=
 Distro haven't supported<br>
&gt; it.<br>
&gt; &gt;<br>
&gt; &gt;&nbsp;&nbsp; 2. Encode new system registers in macros ***(preferre=
d)***<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; ```<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; /* Virtualization=
 Secure Translation Control Register */<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; #define VSTCR_EL2=
&nbsp; S3_4_C2_C6_2<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; /* Virtualization=
 System Control Register */<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; #define VSCTLR_EL=
2 S3_4_C2_C0_0<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; /* EL1 MPU Protec=
tion Region Base Address Register encode */<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; #define PRBAR_EL1=
&nbsp; S3_0_C6_C8_0<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; ...<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; /* EL2 MPU Protec=
tion Region Base Address Register encode */<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; #define PRBAR_EL2=
&nbsp; S3_4_C6_C8_0<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; ...<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; ```<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; If we encode all above system regis=
ters, we don't need to bump GCC<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; version. And the common CFLAGS Xen =
is using still can be applied to<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; Armv8-R64. We don't need to modify =
Makefiles to add specific CFLAGS.<br>
&gt; <br>
&gt; I think that's fine and we did something similar with the original ARM=
v7-A<br>
&gt; port if I remember correctly.<br>
&gt; <br>
&gt; <br>
&gt; &gt; ### **2.2. Changes of the initialization process**<br>
&gt; &gt; In general, we still expect Armv8-R64 and Armv8-A64 to have a con=
sistent<br>
&gt; &gt; initialization process. In addition to some architecture differen=
ces,<br>
&gt; there<br>
&gt; &gt; is no more than reusable code that we will distinguish through<br=
>
&gt; CONFIG_ARM_MPU<br>
&gt; &gt; or CONFIG_ARM64_V8R. We want most of the initialization code to b=
e<br>
&gt; reusable<br>
&gt; &gt; between Armv8-R64 and Armv8-A64.<br>
&gt; <br>
&gt; +1<br>
&gt; <br>
&gt; <br>
&gt; &gt; - We will reuse the original head.s and setup.c of Arm. But repla=
ce the<br>
&gt; &gt;&nbsp;&nbsp; MMU and page table operations in these files with con=
figuration<br>
&gt; operations<br>
&gt; &gt;&nbsp;&nbsp; for MPU and MPU regions.<br>
&gt; &gt;<br>
&gt; &gt; - We provide a boot-time MPU configuration. This MPU configuratio=
n will<br>
&gt; &gt;&nbsp;&nbsp; support Xen to finish its initialization. And this bo=
ot-time MPU<br>
&gt; &gt;&nbsp;&nbsp; configuration will record the memory regions that wil=
l be parsed from<br>
&gt; &gt;&nbsp;&nbsp; device tree.<br>
&gt; &gt;<br>
&gt; &gt;&nbsp;&nbsp; In the end of Xen initialization, we will use a runti=
me MPU<br>
&gt; configuration<br>
&gt; &gt;&nbsp;&nbsp; to replace boot-time MPU configuration. The runtime M=
PU configuration<br>
&gt; will<br>
&gt; &gt;&nbsp;&nbsp; merge and reorder memory regions to save more MPU reg=
ions for guests.<br>
&gt; &gt;&nbsp;&nbsp; ![img](https://drive.google.com/uc?export=3Dview&amp;=
id=3D1wTFyK2XfU3lTlH1PqRD<br>
&gt; oacQVTwUtWIGU)<br>
&gt; &gt;<br>
&gt; &gt; - Defer system unpausing domain.<br>
&gt; &gt;&nbsp;&nbsp; When Xen initialization is about to end, Xen unpause =
guests created<br>
&gt; &gt;&nbsp;&nbsp; during initialization. But this will cause some issue=
s. The unpause<br>
&gt; &gt;&nbsp;&nbsp; action occurs before free_init_memory, however the ru=
ntime MPU<br>
&gt; configuration<br>
&gt; &gt;&nbsp;&nbsp; is built after free_init_memory.<br>
&gt; &gt;<br>
&gt; &gt;&nbsp;&nbsp; So if the unpaused guests start executing the context=
 switch at this<br>
&gt; &gt;&nbsp;&nbsp; point, then its MPU context will base on the boot-tim=
e MPU<br>
&gt; configuration.<br>
&gt; &gt;&nbsp;&nbsp; Probably it will be inconsistent with runtime MPU con=
figuration, this<br>
&gt; &gt;&nbsp;&nbsp; will cause unexpected problems (This may not happen i=
n a single core<br>
&gt; &gt;&nbsp;&nbsp; system, but on SMP systems, this problem is foreseeab=
le, so we hope to<br>
&gt; &gt;&nbsp;&nbsp; solve it at the beginning).<br>
&gt; &gt;<br>
&gt; &gt; ### **2.3. Changes to reduce memory fragmentation**<br>
&gt; &gt;<br>
&gt; &gt; In general, memory in Xen system can be classified to 4 classes:<=
br>
&gt; &gt; `image sections`, `heap sections`, `guest RAM`, `boot modules (gu=
est<br>
&gt; Kernel,<br>
&gt; &gt; initrd and dtb)`<br>
&gt; &gt;<br>
&gt; &gt; Currently, Xen doesn't have any restriction for users how to allo=
cate<br>
&gt; &gt; memory for different classes. That means users can place boot mod=
ules<br>
&gt; &gt; anywhere, can reserve Xen heap memory anywhere and can allocate g=
uest<br>
&gt; &gt; memory anywhere.<br>
&gt; &gt;<br>
&gt; &gt; In a VMSA system, this would not be too much of a problem, since =
the<br>
&gt; &gt; MMU can manage memory at a granularity of 4KB after all. But in a=
<br>
&gt; &gt; PMSA system, this will be a big problem. On Armv8-R64, the max MP=
U<br>
&gt; &gt; protection regions number has been limited to 256. But in typical=
<br>
&gt; &gt; processor implementations, few processors will design more than 3=
2<br>
&gt; &gt; MPU protection regions. Add in the fact that Xen shares MPU prote=
ction<br>
&gt; &gt; regions with guest's EL1 Stage 2. It becomes even more important<=
br>
&gt; &gt; to properly plan the use of MPU protection regions.<br>
&gt; &gt;<br>
&gt; &gt; - An ideal of memory usage layout restriction:<br>
&gt; &gt; ![img](https://drive.google.com/uc?export=3Dview&amp;id=3D1kirOL0=
Tx2aAypTtd3kXAt<br>
&gt; d75XtrngcnW)<br>
&gt; &gt; 1. Reserve proper MPU regions for Xen image (code, rodata and dat=
a +<br>
&gt; bss).<br>
&gt; &gt; 2. Reserve one MPU region for boot modules.<br>
&gt; &gt;&nbsp;&nbsp;&nbsp; That means the placement of all boot modules, i=
nclude guest kernel,<br>
&gt; &gt;&nbsp;&nbsp;&nbsp; initrd and dtb, will be limited to this MPU reg=
ion protected area.<br>
&gt; &gt; 3. Reserve one or more MPU regions for Xen heap.<br>
&gt; &gt;&nbsp;&nbsp;&nbsp; On Armv8-R64, the guest memory is predefined in=
 device tree, it will<br>
&gt; &gt;&nbsp;&nbsp;&nbsp; not be allocated from heap. Unlike Armv8-A64, w=
e will not move all<br>
&gt; &gt;&nbsp;&nbsp;&nbsp; free memory to heap. We want Xen heap is derter=
mistic too, so Xen on<br>
&gt; &gt;&nbsp;&nbsp;&nbsp; Armv8-R64 also rely on Xen static heap feature.=
 The memory for Xen<br>
&gt; &gt;&nbsp;&nbsp;&nbsp; heap will be defined in tree too. Considering t=
hat physical memory<br>
&gt; &gt;&nbsp;&nbsp;&nbsp; can also be discontinuous, one or more MPU prot=
ection regions needs<br>
&gt; &gt;&nbsp;&nbsp;&nbsp; to be reserved for Xen HEAP.<br>
&gt; &gt; 4. If we name above used MPU protection regions PART_A, and name =
left<br>
&gt; &gt;&nbsp;&nbsp;&nbsp; MPU protection regions PART_B:<br>
&gt; &gt;&nbsp;&nbsp;&nbsp; 4.1. In hypervisor context, Xen will map left R=
AM and devices to<br>
&gt; PART_B.<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; This will give Xe=
n the ability to access whole memory.<br>
&gt; &gt;&nbsp;&nbsp;&nbsp; 4.2. In guest context, Xen will create EL1 stag=
e 2 mapping in PART_B.<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; In this case, Xen=
 just need to update PART_B in context switch,<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; but keep PART_A a=
s fixed.<br>
&gt; <br>
&gt; I think that the memory layout and restrictions that you wrote above<b=
r>
&gt; make sense. I have some comments on the way they are represented in<br=
>
&gt; device tree, but that's different.<br>
&gt; <br>
&gt; <br>
&gt; &gt; ***Notes: Static allocation will be mandatory on MPU based system=
s***<br>
&gt; &gt;<br>
&gt; &gt; **A sample device tree of memory layout restriction**:<br>
&gt; &gt; ```<br>
&gt; &gt; chosen {<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; ...<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; /*<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; * Define a section to place boot mo=
dules,<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; * all boot modules must be placed i=
n this section.<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; */<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; mpu,boot-module-section =3D &lt;0x1000000=
0 0x10000000&gt;;<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; /*<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; * Define a section to cover all gue=
st RAM. All guest RAM must be<br>
&gt; located<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; * within this section. The pros is =
that, in best case, we can only<br>
&gt; have<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; * one MPU protection region to map =
all guest RAM for Xen.<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; */<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; mpu,guest-memory-section =3D &lt;0x200000=
00 0x30000000&gt;;<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; /*<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; * Define a memory section that can =
cover all device memory that<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; * will be used in Xen.<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; */<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; mpu,device-memory-section =3D &lt;0x80000=
000 0x7ffff000&gt;;<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; /* Define a section for Xen heap */<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; xen,static-mem =3D &lt;0x50000000 0x20000=
000&gt;;<br>
&gt; <br>
&gt; As mentioned above, I understand the need for these sections, but why =
do<br>
&gt; we need to describe them in device tree at all? Could Xen select them =
by<br>
&gt; itself during boot?<br>
<br>
I think without some inputs, Xen could not do this or will do it in some<br=
>
assumption. For example, assume the first the boot-module-section determine=
d<br>
by lowest address and highest address of all modules. And the same for<br>
guest-memory-section, calculated from all guest allocated memory regions.<b=
r>
&nbsp;<br>
<br>
&gt; <br>
&gt; If not, and considering that we have to generate<br>
&gt; ARM_MPU_*_MEMORY_START/END anyway at build time, would it make sense t=
o<br>
&gt; also generate mpu,guest-memory-section, xen,static-mem, etc. at build<=
br>
&gt; time rather than passing it via device tree to Xen at runtime?<br>
&gt; <br>
<br>
Did you mean we still add these information in device tree, but for build<b=
r>
time only. In runtime we don't parse them?<br>
<br>
&gt; What's the value of doing ARM_MPU_*_MEMORY_START/END at build time and=
<br>
&gt; everything else at runtime?<br>
<br>
ARM_MPU_*_MEMORY_START/END is defined by platform. But other things are<br>
users customized. They can change their usage without rebuild the image.<br=
>
<br>
&gt; <br>
&gt; It looks like we are forced to have the sections definitions at build<=
br>
&gt; time because we need them before we can parse device tree. In that cas=
e,<br>
&gt; we might as well define all the sections at build time.<br>
&gt; <br>
&gt; But I think it would be even better if Xen could automatically choose<=
br>
&gt; xen,static-mem, mpu,guest-memory-section, etc. on its own based on the=
<br>
&gt; regular device tree information (/memory, /amba, etc.), without any ne=
ed<br>
&gt; for explicitly describing each range with these new properties.<br>
&gt; <br>
<br>
for mpu,guest-memory-section, with the limitations: no other usage between<=
br>
different guest' memory nodes, this is OK. But for xen,static-mem (heap),<b=
r>
we just want everything on a MPU system is dertermistic. But, of course Xen=
<br>
can select left memory for heap without static-mem.<br>
<br>
&gt; <br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; domU1 {<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; ...<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; #xen,static-mem-a=
ddress-cells =3D &lt;0x01&gt;;<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; #xen,static-mem-s=
ize-cells =3D &lt;0x01&gt;;<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; /* Statically all=
ocated guest memory, within mpu,guest-memory-<br>
&gt; section */<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; xen,static-mem =
=3D &lt;0x30000000 0x1f000000&gt;;<br>
&gt; &gt;<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; module@11000000 {=
<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;=
&nbsp; compatible =3D &quot;multiboot,kernel\0multiboot,module&quot;;<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;=
&nbsp; /* Boot module address, within mpu,boot-module-section */<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;=
&nbsp; reg =3D &lt;0x11000000 0x3000000&gt;;<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;=
&nbsp; ...<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; };<br>
&gt; &gt;<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; module@10FF0000 {=
<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;=
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; compatible =3D &quot;multiboot,device-tree\0=
multiboot,module&quot;;<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;=
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; /* Boot module address, within mpu,boot-modu=
le-section<br>
&gt; */<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;=
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; reg =3D &lt;0x10ff0000 0x10000&gt;;<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;=
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; ...<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; };<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; };<br>
&gt; &gt; };<br>
&gt; &gt; ```<br>
&gt; &gt;<br>
&gt; &gt; ### **2.4. Changes of memory management**<br>
&gt; &gt; Xen is coupled with VMSA, in order to port Xen to Armv8-R64, we h=
ave to<br>
&gt; &gt; decouple Xen from VMSA. And give Xen the ability to manage memory=
 in<br>
&gt; PMSA.<br>
&gt; &gt;<br>
&gt; &gt; 1. ***Use buddy allocator to manage physical pages for PMSA***<br=
>
&gt; &gt;&nbsp;&nbsp;&nbsp; From the view of physical page, PMSA and VMSA d=
on't have any<br>
&gt; difference.<br>
&gt; &gt;&nbsp;&nbsp;&nbsp; So we can reuse buddy allocator on Armv8-R64 to=
 manage physical pages.<br>
&gt; &gt;&nbsp;&nbsp;&nbsp; The difference is that, in VMSA, Xen will map a=
llocated pages to<br>
&gt; virtual<br>
&gt; &gt;&nbsp;&nbsp;&nbsp; addresses. But in PMSA, Xen just convert the pa=
ges to physical<br>
&gt; address.<br>
&gt; &gt;<br>
&gt; &gt; 2. ***Can not use virtual address for memory management***<br>
&gt; &gt;&nbsp;&nbsp;&nbsp; As Armv8-R64 only has PMSA in EL2, Xen loses th=
e ability of using<br>
&gt; virtual<br>
&gt; &gt;&nbsp;&nbsp;&nbsp; address to manage memory. This brings some prob=
lems, some virtual<br>
&gt; address<br>
&gt; &gt;&nbsp;&nbsp;&nbsp; based features could not work well on Armv8-R64=
, like `FIXMAP`,<br>
&gt; `vmap/vumap`,<br>
&gt; &gt;&nbsp;&nbsp;&nbsp; `ioremap` and `alternative`.<br>
&gt; &gt;<br>
&gt; &gt;&nbsp;&nbsp;&nbsp; But the functions or macros of these features a=
re used in lots of<br>
&gt; common<br>
&gt; &gt;&nbsp;&nbsp;&nbsp; code. So it's not good to use `#ifdef CONFIG_AR=
M_MPU` to gate relate<br>
&gt; code<br>
&gt; &gt;&nbsp;&nbsp;&nbsp; everywhere. In this case, we propose to use stu=
b helpers to make the<br>
&gt; changes<br>
&gt; &gt;&nbsp;&nbsp;&nbsp; transparently to common code.<br>
&gt; &gt;&nbsp;&nbsp;&nbsp; 1. For `FIXMAP`, we will use `0` in `FIXMAP_ADD=
R` for all fixmap<br>
&gt; operations.<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; This will return physical add=
ress directly of fixmapped item.<br>
&gt; &gt;&nbsp;&nbsp;&nbsp; 2. For `vmap/vumap`, we will use some empty inl=
ine stub helpers:<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; ```<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; static inline voi=
d vm_init_type(...) {}<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; static inline voi=
d *__vmap(...)<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; {<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;=
&nbsp; return NULL;<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; }<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; static inline voi=
d vunmap(const void *va) {}<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; static inline voi=
d *vmalloc(size_t size)<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; {<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;=
&nbsp; return NULL;<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; }<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; static inline voi=
d *vmalloc_xen(size_t size)<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; {<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;=
&nbsp; return NULL;<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; }<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; static inline voi=
d vfree(void *va) {}<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; ```<br>
&gt; &gt;<br>
&gt; &gt;&nbsp;&nbsp;&nbsp; 3. For `ioremap`, it depends on `vmap`. As we h=
ave make `vmap` to<br>
&gt; always<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; return `NULL`, they could not=
 work well on Armv8-R64 without<br>
&gt; changes.<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; `ioremap` will return input a=
ddress directly.<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; ```<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; static inline voi=
d *ioremap_attr(...)<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; {<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;=
&nbsp; /* We don't have the ability to change input PA cache<br>
&gt; attributes */<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;=
&nbsp; if ( CACHE_ATTR_need_change )<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;=
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; return NULL;<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;=
&nbsp; return (void *)pa;<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; }<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; static inline voi=
d __iomem *ioremap_nocache(...)<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; {<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;=
&nbsp; return ioremap_attr(start, len, PAGE_HYPERVISOR_NOCACHE);<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; }<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; static inline voi=
d __iomem *ioremap_cache(...)<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; {<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;=
&nbsp; return ioremap_attr(start, len, PAGE_HYPERVISOR);<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; }<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; static inline voi=
d __iomem *ioremap_wc(...)<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; {<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;=
&nbsp; return ioremap_attr(start, len, PAGE_HYPERVISOR_WC);<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; }<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; void *ioremap(...=
)<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; {<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;=
&nbsp; return ioremap_attr(pa, len, PAGE_HYPERVISOR_NOCACHE);<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; }<br>
&gt; &gt;<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; ```<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; 4. For `alternative`, it depends on `vmap=
` too. We will simply<br>
&gt; disable<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; it on Armv8-R64 in curr=
ent stage. How to implement `alternative`<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; on Armv8-R64 is better =
to be discussed after basic functions of<br>
&gt; Xen<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; on Armv8-R64 work well.=
<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; But simply disable `alt=
ernative` will make `cpus_have_const_cap`<br>
&gt; always<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; return false.<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; ```<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; * System capabili=
ty check for constant cap */<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; #define cpus_have=
_const_cap(num) ({&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nb=
sp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; \<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;=
&nbsp;&nbsp;&nbsp;&nbsp; register_t __ret;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nb=
sp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;=
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; \<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;=
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nb=
sp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;=
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nb=
sp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; \<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;=
&nbsp;&nbsp;&nbsp;&nbsp; asm volatile (ALTERNATIVE(&quot;mov %0, #0&quot;,&=
nbsp;&nbsp;&nbsp;&nbsp; \<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;=
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nb=
sp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;=
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; &quot;mov %0, #1&quot;,&nbsp;&nbsp;&nbsp;&nb=
sp; \<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;=
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nb=
sp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;=
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; num)&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbs=
p;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; \<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;=
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nb=
sp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; : &quot;=3Dr&quot; (__ret));&nbsp;&nbsp;&=
nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; \<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;=
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nb=
sp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;=
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nb=
sp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; \<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;=
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; unlikely(__ret);&nbsp;&nbsp;&nbsp;&nbsp;&nbs=
p;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&=
nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; \<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;=
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; })<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; ```<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; So, before we hav=
e an PMSA `alternative` implementation, we have<br>
&gt; to<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; implement a separ=
ate `cpus_have_const_cap` for Armv8-R64:<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; ```<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; #define cpus_have=
_const_cap(num) cpus_have_cap(num)<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; ```<br>
&gt; <br>
&gt; I think it is OK to disable alternative<br>
&gt; <br>
&gt; <br>
&gt; &gt; ### **2.5. Changes of guest management**<br>
&gt; &gt; Armv8-R64 only supports PMSA in EL2, but it supports configurable=
<br>
&gt; &gt; VMSA or PMSA in EL1. This means Xen will have a new type guest on=
<br>
&gt; &gt; Armv8-R64 - MPU based guest.<br>
&gt; &gt;<br>
&gt; &gt; 1. **Add a new domain type - MPU_DOMAIN**<br>
&gt; &gt;&nbsp;&nbsp;&nbsp; When user want to create a guest that will be u=
sing MPU in EL1, user<br>
&gt; &gt;&nbsp;&nbsp;&nbsp; should add a `mpu` property in device tree `dom=
U` node, like<br>
&gt; following<br>
&gt; &gt;&nbsp;&nbsp;&nbsp; example:<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; ```<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; domU2 {<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; compatible =3D &q=
uot;xen,domain&quot;;<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; direct-map;<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; mpu; --&gt; Indic=
ates this domain will use PMSA in EL1.<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; ...<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; };<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; ```<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; Corresponding to `mpu` property in device=
 tree, we also need to<br>
&gt; introduce<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; a new flag `XEN_DOMCTL_CDF_INTERNAL_mpu` =
for domain to mark itself<br>
&gt; as an<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; MPU domain. This flag will be used in dom=
ain creation and domain<br>
&gt; doing<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; vCPU context switch.<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; 1. Domain creation need this flag to deci=
de enable PMSA or VMSA in<br>
&gt; EL1.<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; 2. vCPU context switch need this flag to =
decide save/restore MMU or<br>
&gt; MPU<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; related registers.<br>
&gt; &gt;<br>
&gt; &gt; 2. **Add MPU registers to vCPU save EL1 MPU context**<br>
&gt; &gt;&nbsp;&nbsp;&nbsp; Current Xen only support MMU based guest, so it=
 hasn't considered to<br>
&gt; &gt;&nbsp;&nbsp;&nbsp; save/restore MPU context. In this case, we need=
 to add MPU registers<br>
&gt; &gt;&nbsp;&nbsp;&nbsp; to `arch_vcpu`:<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; ```<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; struct arch_vcpu<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; {<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; #ifdef CONFIG_ARM_MPU<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; /* Virtualization=
 Translation Control Register */<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; register_t vtcr_e=
l2;<br>
&gt; &gt;<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; /* EL1 MPU region=
s' registers */<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; pr_t mpu_regions[=
CONFIG_ARM_MPU_EL1_PROTECTION_REGIONS];<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; #endif<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; }<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; ```<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; Armv8-R64 can support max to 256 MPU regi=
ons. But that's just<br>
&gt; theoretical.<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; So we don't want to define `pr_t mpu_regi=
ons[256]`, this is a memory<br>
&gt; waste<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; in most of time. So we decided to let the=
 user specify through a<br>
&gt; Kconfig<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; option. `CONFIG_ARM_MPU_EL1_PROTECTION_RE=
GIONS` default value can be<br>
&gt; `32`,<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; it's a typical implementation on Armv8-R6=
4. Users will recompile Xen<br>
&gt; when<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; their platform changes. So when the MPU c=
hanges, respecifying the<br>
&gt; MPU<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; protection regions number will not cause =
additional problems.<br>
&gt; <br>
&gt; I wonder if we could probe the number of MPU regions at runtime and<br=
>
&gt; dynamically allocate the memory needed to store them in arch_vcpu.<br>
&gt; <br>
<br>
We have considered to used a pr_t mpu_regions[0] in arch_vcpu. But it seems=
<br>
we will encounter some static allocated arch_vcpu problems and sizeof issue=
.<br>
<br>
&gt; <br>
&gt; &gt;<br>
&gt; &gt; 3. **MPU based P2M table management**<br>
&gt; &gt;&nbsp;&nbsp;&nbsp; Armv8-R64 EL2 doesn't have EL1 stage 2 address =
translation. But<br>
&gt; through<br>
&gt; &gt;&nbsp;&nbsp;&nbsp; PMSA, it still has the ability to control the p=
ermissions and<br>
&gt; attributes<br>
&gt; &gt;&nbsp;&nbsp;&nbsp; of EL1 stage 2. In this case, we still hope to =
keep the interface<br>
&gt; &gt;&nbsp;&nbsp;&nbsp; consistent with MMU based P2M as far as possibl=
e.<br>
&gt; &gt;<br>
&gt; &gt;&nbsp;&nbsp;&nbsp; p2m-&gt;root will point to an allocated memory.=
 In Armv8-A64, this<br>
&gt; memory<br>
&gt; &gt;&nbsp;&nbsp;&nbsp; is used to save the EL1 stage 2 translation tab=
le. But in Armv8-R64,<br>
&gt; &gt;&nbsp;&nbsp;&nbsp; this memory will be used to store EL2 MPU prote=
ction regions that are<br>
&gt; &gt;&nbsp;&nbsp;&nbsp; used by guest. During domain creation, Xen will=
 prepare the data in<br>
&gt; &gt;&nbsp;&nbsp;&nbsp; this memory to make guest can access proper RAM=
 and devices. When the<br>
&gt; &gt;&nbsp;&nbsp;&nbsp; guest's vCPU will be scheduled in, this data wi=
ll be written to MPU<br>
&gt; &gt;&nbsp;&nbsp;&nbsp; protection region registers.<br>
&gt; &gt;<br>
&gt; &gt; ### **2.6. Changes of exception trap**<br>
&gt; &gt; As Armv8-R64 has compatible exception mode with Armv8-A64, so we =
can<br>
&gt; reuse most<br>
&gt; &gt; of Armv8-A64's exception trap &amp; handler code. But except the =
trap based<br>
&gt; on EL1<br>
&gt; &gt; stage 2 translation abort.<br>
&gt; &gt;<br>
&gt; &gt; In Armv8-A64, we use `FSC_FLT_TRANS`<br>
&gt; &gt; ```<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; case FSC_FLT_TRANS:<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; ...<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; if ( is_data )<br=
>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; {<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;=
&nbsp; enum io_state state =3D try_handle_mmio(regs, hsr, gpa);<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;=
&nbsp; ...<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; }<br>
&gt; &gt; ```<br>
&gt; &gt; But for Armv8-R64, we have to use `FSC_FLT_PERM`<br>
&gt; &gt; ```<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; case FSC_FLT_PERM:<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; ...<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; if ( is_data )<br=
>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; {<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;=
&nbsp; enum io_state state =3D try_handle_mmio(regs, hsr, gpa);<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;=
&nbsp; ...<br>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; }<br>
&gt; &gt; ```<br>
&gt; &gt;<br>
&gt; &gt; ### **2.5. Changes of device driver**<br>
&gt; &gt; 1. Because Armv8-R64 only has single secure state, this will affe=
ct some<br>
&gt; &gt; devices that have two secure state, like GIC. But fortunately, mo=
st<br>
&gt; &gt; vendors will not link a two secure state GIC to Armv8-R64 process=
ors.<br>
&gt; &gt; Current GIC driver can work well with single secure state GIC for=
 Armv8-<br>
&gt; R64.<br>
&gt; &gt; 2. Xen should use secure hypervisor timer in Secure EL2. We will<=
br>
&gt; introduce<br>
&gt; &gt; a CONFIG_ARM_SECURE_STATE to make Xen to use secure registers for=
 timer.<br>
&gt; &gt;<br>
&gt; &gt; ### **2.7. Changes of virtual device**<br>
&gt; &gt; Currently, we only support pass-through devices in guest. Because=
 event<br>
&gt; &gt; channel, xen-bus, xen-storage and other advanced Xen features hav=
en't<br>
&gt; been<br>
&gt; &gt; enabled in Armv8-R64.<br>
&gt; <br>
&gt; That's fine -- it is a great start! Looking forward to it!<br>
</div>
</span></font>
</body>
</html>

--_000_AS1PR08MB74269923288B75097392BDD99E3E9AS1PR08MB7426eurp_--


From xen-devel-bounces@lists.xenproject.org Fri Feb 25 10:49:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 10:49:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.278990.476499 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNYA2-0002Lo-RT; Fri, 25 Feb 2022 10:49:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 278990.476499; Fri, 25 Feb 2022 10:49:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNYA2-0002Lh-O9; Fri, 25 Feb 2022 10:49:18 +0000
Received: by outflank-mailman (input) for mailman id 278990;
 Fri, 25 Feb 2022 10:49:17 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nNYA1-0002L9-Ec; Fri, 25 Feb 2022 10:49:17 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nNYA1-0007mK-BM; Fri, 25 Feb 2022 10:49:17 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nNYA0-0000fp-Qn; Fri, 25 Feb 2022 10:49:16 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nNYA0-0006uO-QN; Fri, 25 Feb 2022 10:49:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=TOFAlThw0GzE3owd8zbY1Sp+HHNhtGRy3/4hNCmMH74=; b=5nEsvcuriRazeZ191kvLuM7pxb
	BqTE+DNNs1JRog/1dZ96zqlG2GVEUrIrlspCzWdTVMshv0mea8cxune/XQLtubI8RgHonqu5gkPqj
	yVoupY4/aI1fT34UQCceTszMhzQubkleneIQOB4TYI4Hnq1l5jVBjYEGBJ+PHW51yrTU=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168225-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 168225: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=32b9d8b0ae00669555f01f91ee11612a636c4b69
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 25 Feb 2022 10:49:16 +0000

flight 168225 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168225/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              32b9d8b0ae00669555f01f91ee11612a636c4b69
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  595 days
Failing since        151818  2020-07-11 04:18:52 Z  594 days  576 attempts
Testing same since   168212  2022-02-24 04:21:36 Z    1 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brad Laue <brad@brad-x.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Christophe Fergeau <cfergeau@redhat.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Divya Garg <divya.garg@nutanix.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Emilio Herrera <ehespinosa57@gmail.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Ivan Teterevkov <ivan.teterevkov@nutanix.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jing Qi <jinqi@redhat.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Lubomir Rintel <lkundrak@v3.sk>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nicolas Lécureuil <neoclust@mageia.org>
  Nicolas Lécureuil <nicolas.lecureuil@siveo.net>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Rohit Kumar <rohit.kumar3@nutanix.com>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  shenjiatong <yshxxsjt715@gmail.com>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tu Qiang <tu.qiang35@zte.com.cn>
  Tuguoyi <tu.guoyi@h3c.com>
  tuqiang <tu.qiang35@zte.com.cn>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Vineeth Pillai <viremana@linux.microsoft.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yasuhiko Kamata <belphegor@belbel.or.jp>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 98975 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Feb 25 10:54:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 10:54:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279009.476509 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNYFS-00042n-GV; Fri, 25 Feb 2022 10:54:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279009.476509; Fri, 25 Feb 2022 10:54:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNYFS-00042g-DG; Fri, 25 Feb 2022 10:54:54 +0000
Received: by outflank-mailman (input) for mailman id 279009;
 Fri, 25 Feb 2022 10:54:53 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nNYFQ-00042a-Ua
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 10:54:52 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nNYFQ-0007rf-Jr; Fri, 25 Feb 2022 10:54:52 +0000
Received: from 54-240-197-234.amazon.com ([54.240.197.234]
 helo=[192.168.31.13]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nNYFQ-0003oL-DO; Fri, 25 Feb 2022 10:54:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=hN/OdZMlyIiYeYqt31xWK6K82FZHnUbh9gI5ig+z7bg=; b=FDqO2JVbMw9DL1DGTV9SQ9p5BV
	ZHlbAwC5c3GHadTTpMOPLqKdrcd/y1cU3vFO2MKUSmk0QMbuINHMVRZdqD1NpN0YyLp09/u/CWLhZ
	bti6CjqBbNznLkn3MupI1N5vBFzkp+OQ2TCF4/E2sN3zBtvhYbka5Z//Oizi5dYgMxWQ=;
Message-ID: <dc161f7e-63c8-0e14-0c1f-51b1318aab2a@xen.org>
Date: Fri, 25 Feb 2022 10:54:50 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.1
Subject: Re: [PATCH] xen/arm: Avoid integer overflow using
 MIDR_IMPLEMENTOR_MASK
To: Michal Orzel <michal.orzel@arm.com>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20220225083854.6371-1-michal.orzel@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220225083854.6371-1-michal.orzel@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Michal,

On 25/02/2022 08:38, Michal Orzel wrote:
> Value of macro MIDR_IMPLEMENTOR_MASK exceeds the range of integer
> and can lead to overflow. Currently there is no issue as it is used
> in an expression implicitly casted to u32 in MIDR_IS_CPU_MODEL_RANGE.
> To avoid possible problems, fix the macro.

Correct me if I am wrong, it sounds like this is only for hardening 
purpose at the moment.

As this code is coming from Linux, I would prefer if we first upstream 
to Linux and then port to Xen once merged.

> 
> Signed-off-by: Michal Orzel <michal.orzel@arm.com>
> ---
>   xen/arch/arm/include/asm/processor.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/xen/arch/arm/include/asm/processor.h b/xen/arch/arm/include/asm/processor.h
> index 8ab2940f68..149fae0d27 100644
> --- a/xen/arch/arm/include/asm/processor.h
> +++ b/xen/arch/arm/include/asm/processor.h
> @@ -39,7 +39,7 @@
>   #define MIDR_VARIANT(midr) \
>       (((midr) & MIDR_VARIANT_MASK) >> MIDR_VARIANT_SHIFT)
>   #define MIDR_IMPLEMENTOR_SHIFT  24
> -#define MIDR_IMPLEMENTOR_MASK   (0xff << MIDR_IMPLEMENTOR_SHIFT)
> +#define MIDR_IMPLEMENTOR_MASK   (0xffu << MIDR_IMPLEMENTOR_SHIFT)

NIT: We tend to use 0xffU.

>   #define MIDR_IMPLEMENTOR(midr) \
>       (((midr) & MIDR_IMPLEMENTOR_MASK) >> MIDR_IMPLEMENTOR_SHIFT)
>   

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Feb 25 10:59:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 10:59:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279016.476521 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNYKA-0004jN-3v; Fri, 25 Feb 2022 10:59:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279016.476521; Fri, 25 Feb 2022 10:59:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNYKA-0004jG-00; Fri, 25 Feb 2022 10:59:46 +0000
Received: by outflank-mailman (input) for mailman id 279016;
 Fri, 25 Feb 2022 10:59:44 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ZUh1=TI=citrix.com=prvs=04827bf5e=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nNYK8-0004j8-7i
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 10:59:44 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 07c99f80-962a-11ec-8539-5f4723681683;
 Fri, 25 Feb 2022 11:59:42 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 07c99f80-962a-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645786781;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=giFSduqJwy6ndyW6qpqhP1uaYgu3qzCTMZTFL2CquC0=;
  b=NVuplAJlm8Nn57OhfP0CiA5kIJBvkvwKSLOZ98SCzVj0caRbhzLGVBeM
   0HMWU/CKvoQhcO5YqThBdz76LY267DbE1CNNccH+PQFBkKl3C0dqod0te
   j6PnhI0qyUM4bNzJS9fJYlM21wZwQCoJdA6AfiRwFLzLSFSTNFVTWAHx1
   E=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 67246922
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:a9SNCq+X+IrpkVwbtCOMDrUDaH6TJUtcMsCJ2f8bNWPcYEJGY0x3n
 2AcC2uHOv3eamPzKtlyatvl/UhX7MTVydZnHAM5qC88E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si+Fa+Sn9T8mvU2xbuKU5NTsY0idfic5DnZ54f5fs7Rh2NQw24LkW1nlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCnazgFwckYo7pouZHa0FZLRxMEvdov7CSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFKoZtmtt0nfyCvE+TIqYa67L+cVZzHE7gcUm8fP2O
 ZVDNWQ+Nk6ojxtnBWw2E6IDmvyT22DmNBJVqUPLhq0X/D2GpOB2+Oe0a4eEEjCQfu1OhVqRr
 G/C+2X/AzkZOcaZxD7D9Wij7sfFkDnnQosUGPu9/+RznVyI7mUJDVsdUl7Tice+jkmyStdOM
 Xs+8yAlrbUx3EGzR9y7VBq9yFaGoxodVtx4A+A8rgaXxcL85geSBmEACDlbetEinMYsQHoh0
 Vrht8PkA3ljvaOYTVqZ96yItnWiNC4NN2gAaCQYCwwf7LHeTJob10yVCIw5Sejs04OzSWqYL
 y22QDYWt+VNjcNX9ICB/wr/2zOSm6rmFCBy6VCCNo661T9RaImgbo2uzFHU6/dcMYqUJmW8U
 Gg4d9u2t75XU8zU/MCZaKBURezyua7ZWNHJqQM3R/EcGyKRF2lPlGy6yBV3Pw9XP8kNYlcFi
 2eD6FoKtPe/0JZHBJKbgr5d6ex2nMAM9vy/D5g4i+aihLArJWdrGwk0OCatM5jFyhRErE3GE
 c7znTyQJXgbE7976zG9Wv0Q17Qmrghnmz+OGsyik0n/ieLGDJJwdVvjGAHfBgzexPnZyDg5D
 v4Fb5fao/mheLeWjtbrHX47cglRcClT6WHeoM1LbO+TSjeK60l6Y8I9NYgJItQ/94wMz7+g1
 ijkBidwlQqu7VWaeF7iQi0yN9vSsWNX8CtT0doEZg3zhRDOoO+Hsc8iSnfAVeJ/pbw7kKUtF
 KFtlgfpKq0ndwkrMg81NPHVhIdjaA6qlUSJOS+kayI4ZJluW0rC/dqMQ+cl3HNm4vaf3Sfmn
 4Cd6w==
IronPort-HdrOrdr: A9a23:EgWR1K1zkjSqm+2r1AbfkAqjBRxyeYIsimQD101hICG9Lfb2qy
 n+ppgmPEHP5Qr5AEtQ5OxpOMG7MBbhHQYc2/hfAV7QZnibhILOFvAt0WKC+UytJ8SazIBgPM
 hbAtFD4bHLfDtHZIPBkXOF+rUbsZi6GcKT9J/jJh5WJGkAAcAB0+46MHfhLqQffngcOXNTLu
 v52iMznUvHRZ1hVLXdOpBqZZmgm/T70LbdJTIWDR8u7weDyRmy7qThLhSe1hACFxtS3LYL6w
 H+4kzEz5Tml8v+5g7X1mfV4ZgTssDm0MF/CMuFjdVQAinwizyveJ9qV9S5zXMISaCUmRQXee
 v30lMd1vdImjTsl6aO0F3QMjzboXMTArnZuAalaDXY0JTErXkBerV8bMpiA2XkAgwbzYtBOe
 twrhKkX9A8N2KwoA3to9fPTB1kjUyyvD4rlvMSlWVWVc8EZKZWtpF3xjIfLH4sJlOy1GkcKp
 gnMCgc3ocjTXqKK3TC+mV/yt2lWXo+Wh+AX0gZo8SQlzxbhmpwwUcUzNEW2i5ozuNxd7BUo+
 Dfdqh4nrBHScEbKap7GecaWMOyTmjAWwjFPm6eKUnuUKsHJ3XOoZjq56hd3pDhRLUYiJ8p3J
 jRWlJRsmA/P0roFM2VxZVOtgvARW2sNA6dvP22J6IJzYEUaICbQxFrEmpe4PdIi89vd/HmZw
 ==
X-IronPort-AV: E=Sophos;i="5.90,136,1643691600"; 
   d="scan'208";a="67246922"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=iyYWVygn9zrEnnHj670I+xMM078Mce7gbZaH/MN3GTppMKmBIKZBQi/S+KOOU5jycwAsEMSWgSDNQMwYEj8eIzWS4Qhj+l8AjFbt5ZFGjz8AfkVcAY/lCJfCZkTyF3IiA46jVBLwLBZr8pVZOJIMMf5v/Q5CoW/7YwbB+YoHR2iyVdQ+T6ejViKau7y3LJyJHWtrU2l56HVHnH5CQ0dBoqzb1V2Dj/pxqM7sh+Ama1gMLTd+Rc8UkNy07r+z1CBMuFwKqr+yc1Zt44gz9PV3kf35WZCkrP8jIF1osuqcmlaQ72zWBn0Bil66zh736inCml5+8c6ZWGFtlDREB3yFyA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=giFSduqJwy6ndyW6qpqhP1uaYgu3qzCTMZTFL2CquC0=;
 b=aLGCoyIcaS9BB2qehNxr5z4pA8qM+8lTc/pz6z8VJ9KP12WU77x3VDqww5dkLeJ/OxHRshJgL8R73QdmkxRAW47oOIUL6R3a3474SjkbuidCZIs9EdahYGmuC6BmoyRMvgIAr/SODPYAdsy/FxJCbpePwLSO03tm5SmKCs61EbTvlJGjIT6I1YLEQ0VQZrGfMBK22psxbXltzVGYxMqbTYEgaZi74oR0vDIukqX73sJZLxclDo0HLOOikwWlw+0FR6mSRG9gVZlu+hIjK/waAlLGNnAPVCc5rOsHWxU5nr0lJFpildxpM1JRwMk6mjXDOM82t8QRWGCY8j7TY4ymEg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=giFSduqJwy6ndyW6qpqhP1uaYgu3qzCTMZTFL2CquC0=;
 b=vXyY8uvaLKJRBWQJJ0N+ZRzS9RMiWK5x0eKAJgZkuY+CDNOQ1VepB7VbF2mKaCdvH6IF7zeYc5TGF+JqyigwAyOIbiod+WOVNByiWcFzyX/TiPiCeaIFBGSuGozN47rsLvEYjI1IxFplmapU0akjR7zL25qN9hl3tcFy9oUca/E=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Julien Grall <julien@xen.org>, Michal Orzel <michal.orzel@arm.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Stefano Stabellini <sstabellini@kernel.org>, Bertrand Marquis
	<bertrand.marquis@arm.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH] xen/arm: Avoid integer overflow using
 MIDR_IMPLEMENTOR_MASK
Thread-Topic: [PATCH] xen/arm: Avoid integer overflow using
 MIDR_IMPLEMENTOR_MASK
Thread-Index: AQHYKiNA8xx4cBmUbUiQd1elipGwDaykF/IAgAABUgA=
Date: Fri, 25 Feb 2022 10:59:35 +0000
Message-ID: <42974ed3-9075-a679-188e-1771f5e604b3@citrix.com>
References: <20220225083854.6371-1-michal.orzel@arm.com>
 <dc161f7e-63c8-0e14-0c1f-51b1318aab2a@xen.org>
In-Reply-To: <dc161f7e-63c8-0e14-0c1f-51b1318aab2a@xen.org>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: ce9b622c-8e64-4c4c-4f97-08d9f84de8eb
x-ms-traffictypediagnostic: BN6PR03MB2481:EE_
x-microsoft-antispam-prvs: <BN6PR03MB24819F7A7FE591AEDDA32FBFBA3E9@BN6PR03MB2481.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: c/QiUSaRYKwArRggnyLPsDZWvqtbeAhV4CB/dY1mNOivwNcXslMouPVaF85SNgk9hyyAFeDDwbrmgfApMUhBob7W4hj8sMPSunuH7IcTmb7UM68HnjFxgcviAmAfew/YkN/dV3JbRCYgtPH39Gz5Qc/4vtkO4jTIhXq6J7hPN71ZCWo9XJzOUL751z8F+jcDdNhita07VqTnc2WYBPzr63jjd8MbFuCNq4uPueiTaWTuxh9yliYLxCmKczCZmZ6xlGApej9iMmk66CjIoHcWAlKTFFdPFH5RBoI0JftdVm7Q62MthMIpQL3atrzKpzyEwSBArHdEZdNT4zhbMmPiK870I8VlpbPnwkYUinApIvxekWTuH+eKfFO/vbTR+oL2jOLq/Oo4EnkINXySWb3w+9w8elLQTG01ZnTkLhmQ8bgsXufAgF8zu+O6Ks5EbzGIHsElIEN3DcbY6ho2hLCbJjTTXuM74mf76lWURmdKAujaFu9lDA50KvvKEH+VUAvu+ZfgSFBHOf1crFVuCO/1cDX/XsQB2bkd27pGBykTroPD4k1kCP5yTkTvrt8OLPMLoa0+07qiqMxzMgg9oSi5xRs2twPSJEW5KG+5DlwsuXs2l8npgnUzYmLpptF2JatI0nh/nKVjMOxyySA/OMZIkqg/3k49+G0sFGPy4fNs2SdQfdLaYicBeDSaBnW5NV/mkx3VpT3iyJOmNeJe2REph8Cedtvx2iZovT3m2N4k7uJSJb9THTIuBFzYZ6ICHOqc2kX4ONPjACYtqXcsLTPsrA==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6486002)(508600001)(36756003)(5660300002)(82960400001)(122000001)(38100700002)(86362001)(316002)(8936002)(4744005)(2616005)(64756008)(66556008)(66476007)(66946007)(8676002)(4326008)(66446008)(83380400001)(6512007)(6506007)(2906002)(186003)(53546011)(31696002)(110136005)(26005)(38070700005)(91956017)(71200400001)(54906003)(76116006)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?ekljU3QxTmhsQWZTYkk3MHdxY25qQWoyOGlzeHc3ZW5rSjVndktrajBEcHpN?=
 =?utf-8?B?dTVUSHVYYUFMeVMwb1hhM3FpdThNYmpoKzhvNkp4Q3Q5T1k4M3V3QkNLUUE3?=
 =?utf-8?B?MEdaSEhkMWw2NFk4a2VaOUxTV3RhNXFjcmVhSHdQZXg0VnFUcjNweU5MRlZy?=
 =?utf-8?B?Z3VKZmhqd2ppaG9GWVozQXZ1elhsT1BENzJQYVJtYXpZQTRwR3JvT3lRQ1Ey?=
 =?utf-8?B?SmZGRkQvbmYyZkVVRWtadnFzazFwTlNSb3U1S0c4cCtuM3FkUXZvcU1MLzR1?=
 =?utf-8?B?QWJNZ3kwazZuWnZ5TU8ybmN0WWtod0llb01SaENZU3pRUjFsdXdwSTFCUk4r?=
 =?utf-8?B?Y2ExMjY1L2syOVZhb2gxZ2pKOUkrWVdveHY5MnJsaHZCY2QvZDgrdFVhQ2ti?=
 =?utf-8?B?YmtvZUlwSGdIWE9QSnlhRFJYL3JvV0pnVWd1dTc0Y080WTVZZk5uRFpMN0Ny?=
 =?utf-8?B?NkZsUE1HY0pJeTFuTnJtZUlHMi85eXRZcEY1dXQvZHgxSEdpTVRTc3VvUVlT?=
 =?utf-8?B?Sjd4OEVOdmFkWENTUEVwMVZxb3JrTUxnSWlkZVRNem9ZZmFOMi83OHRTbFVy?=
 =?utf-8?B?NVJpUjJVNE5EVEZRbmczeFQ5R2hoYzRMY2FsWFhoclErakhoczRXYWtPYngz?=
 =?utf-8?B?OWJUaFNicUxuVmRhSmVtdjRsQkpOMkk5YzVCMHpia1dMQVoybEtRSzNIL29N?=
 =?utf-8?B?K1RzeENKYkJzOTVuVGRVdXhsSnpQcDhlYnhRNFdlN2FiTWVYdDRLS29lamV2?=
 =?utf-8?B?djBJV01BZWFoalorSlFGd29naDVWZVFKWE0ycWVZYjZzN3UzS0hHc1ZacG0r?=
 =?utf-8?B?dG1WYVQveW15RGNNc0JoUnQ1OUJqNlBydjUxQ25EbFBqOFlvZ1FtK2g5bysv?=
 =?utf-8?B?QXYrN1VpUDAxZzgwKzUyK3ZLU3poVVVLTngvQXNpTzhZbDNtZkN4R3g4dnFS?=
 =?utf-8?B?bVZmUmFPeHVOZ3ZqT2R5Tm5EbUYwRjFvejNmUm8zYldnNEVRd1dQUmRGZkFY?=
 =?utf-8?B?R0I3cDRiODladG43Qi9WSGxJdTI2ODFHL0IwQ1AxbU1TcktyT1dCdThHb1Jv?=
 =?utf-8?B?d3FKL1ZXSkljOC9Hd2lkd3ZkK2k4TTNmeTkzbEd2VnFMcnBKMHNGamFiQmNo?=
 =?utf-8?B?UDBqMFUrd0crY1Uva0swWXl0SDRpUzQ4SzcrcFR0SlA3cXdzZjhJS0tmSDZx?=
 =?utf-8?B?d2srYWpwUUV1SFhuMkR5c0hHQnJyQWtreTN5MWRMRHpUN3Q3eGU2OHFyditt?=
 =?utf-8?B?OEFkOExBdEgwQVZXak9ORUh0NmVXVUdMTkpnbHQyN2tRR3YrYnZrTUxSV2NS?=
 =?utf-8?B?Rk1ONVNtRGhxUURVZEtqaUZvNU1lVjBsS0RTcU94VzZPYXVIWXc0Qzg5ZVlO?=
 =?utf-8?B?aFZSVGZQcFdneGVsTU5mcmFIY2RIeW5SakJSbGdCRXg5UElzQ0E2a1FSLzJ2?=
 =?utf-8?B?Tzl1U25SZTVtNCtsaUFyMXpLa2cySnVsSFV4UlNnanZTOHVWNTZOMDhVRjQy?=
 =?utf-8?B?SkdyMXNWZEw2RjZ3emtNb3R1R25UektsZ0dyUmFmWUdwTW0wTG54T3ZRVENH?=
 =?utf-8?B?S1hsb3VaM1VLY1hiaTErUW1zZUlkL0V5d1hhbTVDVlJ2RWtUMGFOL3RPaTkw?=
 =?utf-8?B?c3lJQWJIOHc3NXhCRkZQbkN5NTQrK00reS9NaldZYUR1OTNRakVtRmYxVFh1?=
 =?utf-8?B?aWs1UFJLcnp6bUFkaU9Kd3huVDhyVjkrbXdXbklmS0tCZ3I3RjlTOFZDTUVK?=
 =?utf-8?B?S3o3VXhqbzdOVm9BNzdpWUczaU14M2Z3bngvNmJ2eDM3ZzNLWG00VWZORG1t?=
 =?utf-8?B?K01ROE9oVkNLbEpraGhYMS84YkpxeVBRRlNjZFVSaEloUTB1MnJXUVRESUVa?=
 =?utf-8?B?TmYxV2FsYjltTTBmbWswZllEdFYwQXhCLzlVeWZ4Q3ZSZVBCMVMwUi9acVY1?=
 =?utf-8?B?TXNVSG5MQ0JFYlczdWUwN0o2Rm9PVXIydDVVbm51VnJQR1VZYjU3Wlg2Kzk3?=
 =?utf-8?B?c2hGVEFHbVNuZS9sWHNFREFLSWlSRzFKWXFUNHJhTEpxeVZwY2NiTVovU3pn?=
 =?utf-8?B?REp6RFl5R2ZGMzJxcXd2dFRQN244a2M3MzRrcW9yS3R5UzlVRC9WU2ZGenZn?=
 =?utf-8?B?VUt1R2lldm5JOURwTWNuQmVjSFFaYlY1YTJJZlZCUDQ3ejJYTWE0cEZLcXY4?=
 =?utf-8?B?TkRTbGFJOTFaSkFXZTkzWGY2R0QxTjcwNDJQSDZKY0R5K2NEaHNwNHVBdVBx?=
 =?utf-8?B?NmFzb05na0gyTUNYSitXZXg3dWVRPT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <0BA0FE94D7D1B645A967C8EAADE82670@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ce9b622c-8e64-4c4c-4f97-08d9f84de8eb
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Feb 2022 10:59:35.2604
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: d0MOYihKhnAbZQXhNIATQwVygA/T++KEk8wbW3BHJFjwgOmOdUvamSIkzVlFbVZaW6nJyjCDyD+Ve3mpqVRe1l+wbDHODUlhKmkfg6klu7c=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2481
X-OriginatorOrg: citrix.com

T24gMjUvMDIvMjAyMiAxMDo1NCwgSnVsaWVuIEdyYWxsIHdyb3RlOg0KPiBIaSBNaWNoYWwsDQo+
DQo+IE9uIDI1LzAyLzIwMjIgMDg6MzgsIE1pY2hhbCBPcnplbCB3cm90ZToNCj4+IFZhbHVlIG9m
IG1hY3JvIE1JRFJfSU1QTEVNRU5UT1JfTUFTSyBleGNlZWRzIHRoZSByYW5nZSBvZiBpbnRlZ2Vy
DQo+PiBhbmQgY2FuIGxlYWQgdG8gb3ZlcmZsb3cuIEN1cnJlbnRseSB0aGVyZSBpcyBubyBpc3N1
ZSBhcyBpdCBpcyB1c2VkDQo+PiBpbiBhbiBleHByZXNzaW9uIGltcGxpY2l0bHkgY2FzdGVkIHRv
IHUzMiBpbiBNSURSX0lTX0NQVV9NT0RFTF9SQU5HRS4NCj4+IFRvIGF2b2lkIHBvc3NpYmxlIHBy
b2JsZW1zLCBmaXggdGhlIG1hY3JvLg0KPg0KPiBDb3JyZWN0IG1lIGlmIEkgYW0gd3JvbmcsIGl0
IHNvdW5kcyBsaWtlIHRoaXMgaXMgb25seSBmb3IgaGFyZGVuaW5nDQo+IHB1cnBvc2UgYXQgdGhl
IG1vbWVudC4NCj4NCj4gQXMgdGhpcyBjb2RlIGlzIGNvbWluZyBmcm9tIExpbnV4LCBJIHdvdWxk
IHByZWZlciBpZiB3ZSBmaXJzdCB1cHN0cmVhbQ0KPiB0byBMaW51eCBhbmQgdGhlbiBwb3J0IHRv
IFhlbiBvbmNlIG1lcmdlZC4NCg0KV2VsbC7CoCBUaGUgZXhwcmVzc2lvbiBpcyB1bmRlZmluZWQg
YmVoYXZpb3VyIGluIEMsIGJlY2F1c2Ugb2Ygc2hpZnRpbmcNCmludG8gdGhlIHNpZ24gYml0Lg0K
DQpJbiBwcmluY2lwbGUsIHRoZSBjb21waWxlciBpcyBmcmVlIHRvIG9wdGltaXNlIGlzX2FmZmVj
dGVkX21pZHJfcmFuZ2UoKQ0KdG8gInJldHVybiB0cnVlIiBhcyBhIGNvbnNlcXVlbmNlLCBldmVu
IGlmIGNvbXBpbGVycyB0ZW5kIG5vdCB0byBiZSB0aGF0DQptYWxpY2lvdXMuDQoNCn5BbmRyZXcN
Cg==


From xen-devel-bounces@lists.xenproject.org Fri Feb 25 11:03:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 11:03:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279025.476532 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNYO7-0006Cl-Rj; Fri, 25 Feb 2022 11:03:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279025.476532; Fri, 25 Feb 2022 11:03:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNYO7-0006Ce-Nl; Fri, 25 Feb 2022 11:03:51 +0000
Received: by outflank-mailman (input) for mailman id 279025;
 Fri, 25 Feb 2022 11:03:50 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nNYO6-0006CY-HC
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 11:03:50 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nNYO6-000837-2F; Fri, 25 Feb 2022 11:03:50 +0000
Received: from 54-240-197-226.amazon.com ([54.240.197.226]
 helo=[192.168.31.13]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nNYO5-0004Rf-SC; Fri, 25 Feb 2022 11:03:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=ktE0Dj4oZ1ofEtmAcjdTr2AUC6s3WDLEPv9T0wQd7tw=; b=VSm0qse2wCDHe9ASlQUeL6arQ6
	rcYPLbprTfBUVBT8To9n1ky/J2TMBal4PjJacco8JIGalKRzMFp2mvTuGZG7RaT330IgXSNPrL7n2
	bl2zoGIxh0MRPwvBferfOhgJeMPF9HBF5azfWK4z2QQeHux45F0K8vM66hbrHcULE+0M=;
Message-ID: <9afd3969-cd64-4729-b94a-e4400f2c1087@xen.org>
Date: Fri, 25 Feb 2022 11:03:47 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.1
Subject: Re: [PATCH] xen/arm: Avoid integer overflow using
 MIDR_IMPLEMENTOR_MASK
To: Andrew Cooper <Andrew.Cooper3@citrix.com>,
 Michal Orzel <michal.orzel@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20220225083854.6371-1-michal.orzel@arm.com>
 <dc161f7e-63c8-0e14-0c1f-51b1318aab2a@xen.org>
 <42974ed3-9075-a679-188e-1771f5e604b3@citrix.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <42974ed3-9075-a679-188e-1771f5e604b3@citrix.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi,

On 25/02/2022 10:59, Andrew Cooper wrote:
> On 25/02/2022 10:54, Julien Grall wrote:
>> Hi Michal,
>>
>> On 25/02/2022 08:38, Michal Orzel wrote:
>>> Value of macro MIDR_IMPLEMENTOR_MASK exceeds the range of integer
>>> and can lead to overflow. Currently there is no issue as it is used
>>> in an expression implicitly casted to u32 in MIDR_IS_CPU_MODEL_RANGE.
>>> To avoid possible problems, fix the macro.
>>
>> Correct me if I am wrong, it sounds like this is only for hardening
>> purpose at the moment.
>>
>> As this code is coming from Linux, I would prefer if we first upstream
>> to Linux and then port to Xen once merged.
> 
> Well.  The expression is undefined behaviour in C, because of shifting
> into the sign bit.
> 
> In principle, the compiler is free to optimise is_affected_midr_range()
> to "return true" as a consequence, even if compilers tend not to be that
> malicious.

Are you arguing against fixing Linux first and the backport it to Xen?

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Feb 25 11:47:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 11:47:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279033.476542 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNZ46-0002AH-6n; Fri, 25 Feb 2022 11:47:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279033.476542; Fri, 25 Feb 2022 11:47:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNZ46-0002AA-3Q; Fri, 25 Feb 2022 11:47:14 +0000
Received: by outflank-mailman (input) for mailman id 279033;
 Fri, 25 Feb 2022 11:47:13 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Zfiy=TI=citrix.com=prvs=0484f4aa7=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nNZ45-0002A4-1Y
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 11:47:13 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a9cc1772-9630-11ec-8eb8-a37418f5ba1a;
 Fri, 25 Feb 2022 12:47:11 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a9cc1772-9630-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645789631;
  h=from:to:cc:subject:date:message-id:
   content-transfer-encoding:mime-version;
  bh=0Ktb92adsVkmWTCw5E6AmJZ00+bq5/0UXmMSrAVMpSU=;
  b=iAkN2Rb8CbX6QWRUHgYhm+QedTpwhgWLorpRlvdLATG8udSYLqFXnwPu
   4PyIHwWlIZJQicdi9DabFbLIvcxQEkPOQgvkvzUAopXsV2ySoSj+oeKFE
   6V//NAlckxggAVmBxaoTG5KPQEzra7O923wJdwyZZ5WQjBzlkq4j0T7DJ
   s=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 64985351
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:O3EBhKKs4Al757lWFE+R05UlxSXFcZb7ZxGr2PjKsXjdYENShGdTn
 DFKDG7QbKveamX0c90jYdzk808GvcXQm4VkHFFlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA148IMsdoUg7wbRh2NQ12YLR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 OpLm6ybYwgzBOrRhO03fB1BIyZzAZQTrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBNPsM44F/Glp0BnSDOo8QICFSKLPjTNd9Gls15ATRquHD
 yYfQSg0agnpbiQeBnEGUo4TvP+4vXfUVgQN/Tp5ooJoujOOnWSdyoPFMtDYZ9iLTsV9hVuDq
 yTN+GGRKgEXMpmTxCSI9lqoh/TThmXrVYQKDrq6+/V2xlqJyQQu5AY+DAXh56Pj0wjnBowZe
 xd8FjcSQbYay0qFfvLXUAeC52OYtzQzX8NgFOAG0VTYokbL2DqxCm8BRz9HTdUpss4qWDAnv
 mO0c8PV6S9H6+PMFy/EnluAhXbrYHVOczdeDcMRZVZdu7HeTJcPYgUjpzqJOIq8lZXLFD752
 FhmRwBu1uxI3abnO0hWlG0rYg5ARLCVH2bZBS2NBwpJCz+Vgqb/NuREDnCBsJ59wH6xFAXpg
 ZT9s5H2ABoyJZ+MjjeRZ+4GAauk4f2IWBWF3wIyQMV4q2n1oyb7FWy13N2YDB04WirjUWW0C
 HI/RCsLvMMDVJdURfUfj32N5zQCkvG7SIWNugH8ZdtSeJlhHDJrDwk1DXN8K1vFyRB2+YlmY
 M/zWZ/1UR4yVPQ2pBLrFrx1+eJ6mUgDKZb7GMmTI+KPiuHFOhZ4iN4tbTOzUwzOxPjc8VWNr
 o0GbJPiJtc2eLSWXxQ7OLU7dDgiBXM6GYr3u4pQcOuCKRBhA2YvF7naxrZJRmCvt/09ejvgl
 p1lZnJl9Q==
IronPort-HdrOrdr: A9a23:HNVGa60VKQdNEG4iYLxt8AqjBLYkLtp133Aq2lEZdPUzSL3+qy
 nOpoV+6faQsl0ssR4b9exoVJPufZq+z/5ICOsqU4tKNTOO0AHEEGgI1+rf6gylNyri9vNMkY
 dMGpIObeEY1GIK7voSNjPIceod/A==
X-IronPort-AV: E=Sophos;i="5.90,136,1643691600"; 
   d="scan'208";a="64985351"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=RQ7B3ukD7yRi8vctcmCEY/+ppIS1yXl5Ew9TypzlYcorf73Zft2gzwEGAr2TNj1XOVBprx+fw+rmMA6wUpSAeMkzwwLcFi88/Ri3NRkfS5Ikz6rWaoPHx6Oykaq3CGHkVGgCgzXgTmD1WGABxbC73pNd9QAD+APcHp5H8ERclYZNJxJrgX7t2Zg8JwmccefXii5ceA1ps0IA3MOcWPvR4n+dKI6E0y6ppbAn0R+pubTJSeFdePQx01X2Jo70qhhY90Y0hH0oBhPHIXitd/YcBYJ6zZdCScH3Nfqnw/eucQdbObB5zgQ3dvPwTrrdMwlOs8C0cP7L9vg3BF0QV5zQRg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=yx4r1lSZIl1pe2SrW52IVtMxwtt6xWeMduyLUDwhOFc=;
 b=ZycM94aGaz/GDb7qsf3y60aUp6NrJPKDTjYQbG4o3sneLguMlLzr7GxSxz7P99s+NietpOAnEAkPcFpTqzptNRdazSihZsjWjIsoptK5vA9RrDkJrEhQ8n4aWALKQw2XjNpbxk/dz+m6X7nWog9WALzY/kEanTY1wg6aHn+N7t6llwcrx1LyyTjg2h2aTXNy0u8kpOb0QGAZcPA9DqL5S2WduD68BAmiMp4CiNuD+qK415CdMpAlAQ98hyhDduUHzuqYYZBh4QB4YI1PHFPZn6kHBRQ3skKdEAhwFKi31FTxm+Y6uqOns4U2xCTZqnM42AG9Tj/tbiB72JxilPk33g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=yx4r1lSZIl1pe2SrW52IVtMxwtt6xWeMduyLUDwhOFc=;
 b=oTfOuiyKztwsUZFy0DaBMeZ7RUO21MgPKaSdTSOPR5O5dUGJqK+WkTnKpGQdfVzHE+BzlGhnQbWwlbTeExqTfpqxiAUogLqY36LO852rcTP3H/wE0qhkNBNPu4EtGJ0BpNFLsSOJ4jkRMFXBr12RtxypZ2TtlK1boofqPxlxd5Y=
From: Roger Pau Monne <roger.pau@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Roger Pau Monne <roger.pau@citrix.com>, Jan Beulich <jbeulich@suse.com>
Subject: [PATCH] vpci/msix: fix PBA accesses
Date: Fri, 25 Feb 2022 12:46:47 +0100
Message-ID: <20220225114647.93879-1-roger.pau@citrix.com>
X-Mailer: git-send-email 2.34.1
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO4P265CA0009.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:2ad::12) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2c966e0b-d76e-4596-8c9f-08d9f854887f
X-MS-TrafficTypeDiagnostic: MWHPR03MB2896:EE_
X-Microsoft-Antispam-PRVS: <MWHPR03MB28965D4D2C6366F1692826768F3E9@MWHPR03MB2896.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: q2A8oXFuEFOHiK8sk47CNAPGjjONGP9c6cj26B4XwTADZPV1WKJejTizWTOjsn7uTwr0aPg/0SWKVEirOuN/iEyAVa4PPCNL917T/2iWXJy2l7YgRH1Qr1752ZGb7YokwK6TBQ7yvJ6h+YLAFeua8ELkrMbZykx9MU0S4jSfcBsR/7p/HoavihIOFfCkpq6QnYJ/H5MCr76kVI4Dx/sB1vvU8JpeeTbtm0w5Eo/VSoBPtO4LLNjAEBuN9LK/+K4hy6Z9bIMB+tVt5y6iePlSsca19YE89/p/6nughkckqFtddQ6PZy+2QKh21ldld8ccw+osAMOpIgB2fsEc/o9hlgC7dVAzRdl3fx7yU/E1Q1+xnJ4YzFl7bEtxS/Xzk2vkJvx3Y9mPyjuBV8lYHo9rvhQvnMp2deM2H18LcIaucqn40XbleXRRiHfRIbZ9Z1UjY1+MWjUmYJyx195Su3einjrECkemSyhVG4sTwHiqDDyswfL1Jr52/elSpM9ycs4jH1Erxx2ywxCL/K2DzEgShcC+KeAsc5UCoWqiHwVNS2uDI7ve7Wv8ISvvJVuRxBfIyfomKVHbSqqzRSeOUOj4NlV0TFyPMa2+wKN1w+QYdYe7GuQFu3ssT4wWvEjIjmo8b53JThA7FmcPf6VG6VSEQg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(83380400001)(8936002)(6916009)(508600001)(6486002)(54906003)(38100700002)(316002)(82960400001)(1076003)(2616005)(4326008)(2906002)(8676002)(6666004)(26005)(6512007)(6506007)(86362001)(5660300002)(66476007)(66556008)(186003)(66946007)(36756003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YnovNTBWUTg4MHdZclUrMVdxVDZGTUVvK2RDNW5yM0VoUmZHcUwxcVdQR0dJ?=
 =?utf-8?B?WjBQMlNUZHVBbzlnWjk2R2hwcUNJNC85RE1yMTJDMFBUclZFTUZSMlladTJQ?=
 =?utf-8?B?L1c4WVE5ZUkzVFVJc0F2M3liKzNTRDRBNWpqTkhaNENzZnZrMHI0MlB1UnNN?=
 =?utf-8?B?eXRtYnZJVkVqQndyVE1RVFMvZEh6YmxuSXJTMWFhYjJWOEFnYzZyZUdXMWNr?=
 =?utf-8?B?eUtyb2o1bVdUUHhMZmx3QVQrT2c1WlB4UTdDNWNieVFIVkMzVXBiSzhJczBI?=
 =?utf-8?B?SEpBNTZmVTV6REw0VkM4bFdiQzZyS2IvR0dUcW5xL3VrS0JHUlhtNWEvQ0Zx?=
 =?utf-8?B?d3JOTzFNQTlNR2ptRThYSUx3MUZOWEg3QmRwTjFxcEFOVTE2WVhpbnV4V0R3?=
 =?utf-8?B?UjY3ai8vK3ZGNE5GQklCRElSMlVyZXdKWHd5aWhZZStZNzdMUDRQbk1pYlNn?=
 =?utf-8?B?M0RKN3J4aHJZQXVDY0ZDb3d3dS9JN0tYenhDdldKK0RTenk0dVJoalpESm1X?=
 =?utf-8?B?ajlMc3ZBV1VocXFRWGd1Umg1TEtzNDRzcW5CcGF1K2x1bjduZ3NJa25kMnp6?=
 =?utf-8?B?Ym9GZmF3NEVwZW1ROXVOM0o0ZE9rWmdGYXdGOSt6dS9aYlEzbk5qQ3VJQjh2?=
 =?utf-8?B?Zzl1Q25TdEZ1S2pnVGZId0tLY1VYM2I4clVBUTFYcHVqdjBwNXEvbGYyeGNt?=
 =?utf-8?B?Sit1Q2cyNnhhdFpVN1g1Y0VlUWlCK1RYcUl2RnNtdzVxU0c0MlFBNWpudzVY?=
 =?utf-8?B?T3pPbWVYVDhTaUJsMmdkeTFzNHg4aWlwc2Vad1pSYnBoZ2VNMnEzTUMyVzRH?=
 =?utf-8?B?NU9NL1NzQ0VPbUhaNEtiYXhRT1BkcHovRjZXbjY2Z29CT2VObXdyY3p0MlY4?=
 =?utf-8?B?Z1plenBETzVxMTkyOWU1WkJSYUNoODZyUSs3aXpWRlJSNlFkeGFHRmFXa1lh?=
 =?utf-8?B?ejA0Y3JHNUJBVXZzQkc1ZnhBUkNRYTd0b3ZrbFJ5VnRTYzlQZG01QStoSUtx?=
 =?utf-8?B?UHpxNHFKOTlSSmRUVVR3YkthRVZydWgxQWlNQSt5bUJWajB4bzJjdExGSWx5?=
 =?utf-8?B?S2JzMUtkZUtJNjJ6WmFPMlpxSzRqeVlSOXdYME1NNlRPV3JRUGtGNHNxSXc1?=
 =?utf-8?B?ejllRG5IRUduTFdGQWJRQ2VkbjcxaUNwTlhIK2dxN0daNSt4UkdKZFdMWmw3?=
 =?utf-8?B?Q0Rvb2c0SGNZYzJHOHBLV0kxNW5ZV29qWlBuZWRuajBicS9KdDJkOUUwcE9G?=
 =?utf-8?B?VWdZdzRPZ09QTXBaUm51UnZYRW9ONE1LU2x4WGZWYzl5b0FPRTBtUFJ2RVAz?=
 =?utf-8?B?UnV1eGNWUEZiVVZxYkEvUXFFYnorUm4rb1pnQVBYQU40T2N5ZVBrTEFBaWlP?=
 =?utf-8?B?QmdFNHMzWXBDaEZRN1o3TW1KVG1RYTBxZjMrcFZCRi84ckZ2ZzZSaStiZjhT?=
 =?utf-8?B?czlKNmF5Nm1YT2tkT3pEN1JOWWE3Y20zbTRpT1Q0RUViTy9xd2FjRDErSTc0?=
 =?utf-8?B?RHNMNXBmekxISXVtdTl5dTFrMTNESjBMWE0yWllkSGppbWFYeUpYdkZQVXpI?=
 =?utf-8?B?U3pxd000dmJoZkxNTkxhRnppU0d2bjgxL2JPellqeFhHMmgxUFk4STU5RzZD?=
 =?utf-8?B?YzNITWIzMVdJZ2V3VHdBYm9xR0w0WTJibGlCRW15VHFOeGZzYlpDUU1CTEVZ?=
 =?utf-8?B?dTE2T2I3OWZnTlR5cVJCMndaazRlSkNrQ2hDVnR4Q1lzcklaQ1FHTHU4bU5y?=
 =?utf-8?B?c280NFRVaVJHVE5GVnErSnB4Q0Fsc2RJd3JTYlRrN0Z0Z29SZmtQY2FMLzJp?=
 =?utf-8?B?b3JrTUVYZEVUOWxaUlhuTEkrSmg5TkpqVXdxY1BML0RMSC8zWnRCb29mWVRF?=
 =?utf-8?B?cTFXR0diUnltZEtyb1V1dDE0bE05K0Y3akNNQUhTeVg1UUNZREtRV0dLUnZz?=
 =?utf-8?B?dkpDbStIRTRPckRoQUJjZ3pyWHFRYXNPa1huQmZIbCthL1ppNHZBL3M2djRv?=
 =?utf-8?B?NWs4RGoxbTdOOGFsU1NqY2xwSHJWcFI1Qm5WVDZVaHJGTlNTVnhPQ3JQTi8v?=
 =?utf-8?B?clVrWk1aS2YwODRZbGdFdENjU01oZFVsKzRnVXhzM1Jsd25xdWttTWd0OXRJ?=
 =?utf-8?B?SmIydGhZbFU0c2NGZERCRVFZa0hNMDZUZkY3RkJuYUVSeHh0MHIwNWVlbldV?=
 =?utf-8?Q?ZbL74SHs9vD2L3blOg+y+K0=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 2c966e0b-d76e-4596-8c9f-08d9f854887f
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2022 11:47:00.2043
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vIYiGkilxNq9B27A8fPHOtBuXCOLKga7NYxACYg5cz/1d/viMssS3mgSxjmu0AO59UetFIzuMqIU2eNdUMq1xA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2896
X-OriginatorOrg: citrix.com

Map the PBA in order to access it from the MSI-X read handler. Note
that previously the handler will pass the physical host address into
the read{l,q} handlers, which is wrong as those expect a linear
address.

Map the PBA using ioremap when the first access is performed. Note
that 32bit arches might want to abstract the call to ioremap into a
vPCI arch handler, so they can use a fixmap range to map the PBA.

Reported-by: Jan Beulich <jbeulich@suse.com>
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
I don't seem to have a box with a driver that will try to access the
PBA, so I would consider this specific code path only build tested. At
least it doesn't seem to regress the current state of vPCI.
---
 xen/drivers/vpci/msix.c | 28 +++++++++++++++++++++++++---
 xen/drivers/vpci/vpci.c |  2 ++
 xen/include/xen/vpci.h  |  2 ++
 3 files changed, 29 insertions(+), 3 deletions(-)

diff --git a/xen/drivers/vpci/msix.c b/xen/drivers/vpci/msix.c
index 846f1b8d70..70085e98b9 100644
--- a/xen/drivers/vpci/msix.c
+++ b/xen/drivers/vpci/msix.c
@@ -198,8 +198,13 @@ static int msix_read(struct vcpu *v, unsigned long addr, unsigned int len,
     if ( !access_allowed(msix->pdev, addr, len) )
         return X86EMUL_OKAY;
 
+    spin_lock(&msix->pdev->vpci->lock);
     if ( VMSIX_ADDR_IN_RANGE(addr, msix->pdev->vpci, VPCI_MSIX_PBA) )
     {
+        struct vpci *vpci = msix->pdev->vpci;
+        paddr_t base = vmsix_table_addr(vpci, VPCI_MSIX_PBA);
+        unsigned int idx = addr - base;
+
         /*
          * Access to PBA.
          *
@@ -207,25 +212,42 @@ static int msix_read(struct vcpu *v, unsigned long addr, unsigned int len,
          * guest address space. If this changes the address will need to be
          * translated.
          */
+
+        if ( !msix->pba )
+        {
+            msix->pba = ioremap(base, vmsix_table_size(vpci, VPCI_MSIX_PBA));
+            if ( !msix->pba )
+            {
+                /*
+                 * If unable to map the PBA return all 1s (all pending): it's
+                 * likely better to trigger spurious events than drop them.
+                 */
+                spin_unlock(&vpci->lock);
+                gprintk(XENLOG_WARNING, "%pp: unable to map MSI-X PBA\n",
+                        msix->pdev);
+                return X86EMUL_OKAY;
+           }
+        }
+
         switch ( len )
         {
         case 4:
-            *data = readl(addr);
+            *data = readl(msix->pba + idx);
             break;
 
         case 8:
-            *data = readq(addr);
+            *data = readq(msix->pba + idx);
             break;
 
         default:
             ASSERT_UNREACHABLE();
             break;
         }
+        spin_unlock(&vpci->lock);
 
         return X86EMUL_OKAY;
     }
 
-    spin_lock(&msix->pdev->vpci->lock);
     entry = get_entry(msix, addr);
     offset = addr & (PCI_MSIX_ENTRY_SIZE - 1);
 
diff --git a/xen/drivers/vpci/vpci.c b/xen/drivers/vpci/vpci.c
index fb0947179b..f8674f3ea8 100644
--- a/xen/drivers/vpci/vpci.c
+++ b/xen/drivers/vpci/vpci.c
@@ -51,6 +51,8 @@ void vpci_remove_device(struct pci_dev *pdev)
         xfree(r);
     }
     spin_unlock(&pdev->vpci->lock);
+    if ( pdev->vpci->msix && pdev->vpci->msix->pba )
+        iounmap(pdev->vpci->msix->pba);
     xfree(pdev->vpci->msix);
     xfree(pdev->vpci->msi);
     xfree(pdev->vpci);
diff --git a/xen/include/xen/vpci.h b/xen/include/xen/vpci.h
index e8ac1eb395..bf93fc8d22 100644
--- a/xen/include/xen/vpci.h
+++ b/xen/include/xen/vpci.h
@@ -127,6 +127,8 @@ struct vpci {
         bool enabled         : 1;
         /* Masked? */
         bool masked          : 1;
+        /* PBA map */
+        void *pba;
         /* Entries. */
         struct vpci_msix_entry {
             uint64_t addr;
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Fri Feb 25 12:17:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 12:17:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279045.476556 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNZWs-0005di-MD; Fri, 25 Feb 2022 12:16:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279045.476556; Fri, 25 Feb 2022 12:16:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNZWs-0005db-Iv; Fri, 25 Feb 2022 12:16:58 +0000
Received: by outflank-mailman (input) for mailman id 279045;
 Fri, 25 Feb 2022 12:16:57 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nNZWr-0005dR-BY; Fri, 25 Feb 2022 12:16:57 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nNZWr-0000qW-7U; Fri, 25 Feb 2022 12:16:57 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nNZWq-0003oK-Oe; Fri, 25 Feb 2022 12:16:56 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nNZWq-0003FV-OA; Fri, 25 Feb 2022 12:16:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=j2c76C30/dVOtbnsij01iUaGZ2+G2etnoSlC/eU07eo=; b=v65BVaF4JTUb6pt8q2hvEyChlo
	8/JcpwXskeEdonE1/6pxW7szqe4TXyIoJAZhCqc8YlRr9mwNVqVTIcCDC5OWCT+sYfjlpbA6SoCVW
	gIfuCmo8p4GMIHdJdc7kFHM7XW0dBB/yOiRw2Oh2Jtx0aVWKuyXIGhsSMBdH5HQqA7RE=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168224-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 168224: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=9ba4c529985a1773852069889a5b53f2ed26c408
X-Osstest-Versions-That:
    xen=93189e8c8b93e2c4658156e785a9b78b61e71a64
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 25 Feb 2022 12:16:56 +0000

flight 168224 xen-unstable real [real]
flight 168228 xen-unstable real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/168224/
http://logs.test-lab.xenproject.org/osstest/logs/168228/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 168228-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168220
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168220
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168220
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168220
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168220
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168220
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168220
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168220
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168220
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168220
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168220
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168220
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  9ba4c529985a1773852069889a5b53f2ed26c408
baseline version:
 xen                  93189e8c8b93e2c4658156e785a9b78b61e71a64

Last test of basis   168220  2022-02-24 19:08:16 Z    0 days
Testing same since   168224  2022-02-25 04:07:22 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Andrew Cooper <andrew.cooper3@citrix.com><mailto:andrew.cooper3@citrix.com>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Julien Grall <jgrall@amazon.com>
  Michal Orzel <michal.orzel@arm.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   93189e8c8b..9ba4c52998  9ba4c529985a1773852069889a5b53f2ed26c408 -> master


From xen-devel-bounces@lists.xenproject.org Fri Feb 25 12:28:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 12:28:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279061.476587 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNZiJ-0007Mj-0k; Fri, 25 Feb 2022 12:28:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279061.476587; Fri, 25 Feb 2022 12:28:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNZiI-0007Mc-Ti; Fri, 25 Feb 2022 12:28:46 +0000
Received: by outflank-mailman (input) for mailman id 279061;
 Fri, 25 Feb 2022 12:28:44 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ZUh1=TI=citrix.com=prvs=04827bf5e=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nNZiG-0007MV-KZ
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 12:28:44 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7588896d-9636-11ec-8539-5f4723681683;
 Fri, 25 Feb 2022 13:28:40 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7588896d-9636-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645792123;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=oKtYSX1KmB/UzKlONbxyD0KC73ISEOnvwAvXlAp3hHo=;
  b=L0Mi8AdMo95LRzv6z73CiOZAIQENXbGZlto4r7Ap3LeV92pNZP5ACrQ/
   vXhusYSw6Tu0z+T3ELkYFmOzoHzO+1ZbBP9lV09nICahFSlfxZ7VFB1HM
   UTgBO8ZzejVXgL3XAoUhhHxif1STJqFyM7839+2pPCRE2Bkoqo/0ta+nN
   8=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 64987199
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:yhgSFawzNV0N6l4qyWV6t+fMxirEfRIJ4+MujC+fZmUNrF6WrkUFm
 2dJWTiAM/reNjPwf9x/YY2y9B4Hv8XUzdUyTVdlqyAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGX9JZS5LwbZj2NYy24XhWWthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 NplnI6MUz8mLLz1mf1GWElUOAh3ba8dweqSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DFYUToHx/ixreCu4rW8vrSKTW/95Imjw3g6iiGN6AO
 5tJNmM+PXwsZTVUJwsQLLFmx921h2SuYxF8sU2XtKc4tj27IAtZj+G2bYu9lsaxbcFSkUGVv
 H7G/mL0GEgybYLEjzGC9xqEg+bVmCrhVYE6Fbum9+Vrilme2mwSDhINUVKx5/K+jyaWS99Zb
 kAZ5Ccqhawz71CwCMnwWQWip3yJtQJaXMBfe8U55R+MzOzI4g+fLmkCUjNFLtchsaceRzYny
 1uIlNPBHiF0vfueTnf13qiQhSO/P24SN2BqTS0ZS00D6trqooA2hzrOSMpuFOi+ididJN3r6
 2nU9m5k3exV1JNVkfXglbzav96yjrHbchQN6RfGZ2O8tQgpaKWMbtyqsmGOuJ6sM72lZlWGu
 XEFne2X4+YPEYyBmUSxfQkdIF26z63baWOB2DaDC7Fkrm3woCD7Iei89RkjfB8BDyoSRdP+j
 KY/Uyt17YQbAnalZLQfj2mZW5VzlviI+TgIu5npgjtyjnpZKF7vEMJGPxf4M4XRfK4Ey/BX1
 XCzK5vEMJriIf47pAdavs9EuVPR+ggwxHnIWbfwxAm93LyVaRa9EOlZbQTSN7xktPvc+G05F
 uqz0ePQmn2zt8WkP0HqHXM7dwhWfRDX+7iswyCoSgJzClU/QzxwYxMg6bggZ5Zkj8xoehTgp
 RmAtrtj4AOn3xXvcFzSAlg6Me+Hdcsv/BoTYH13VX71iidLXGpaxPpGH3fBVeJ8r7ILID8dZ
 6RtRvhs9dwUEmWXo2lGNMKlxGGgHTzy7T+z0+OeSGFXV7ZrRhDT+8+ieQ3q9SIUCTGwu9d4q
 Lqlvj43i7JaL+i+JK46sM6S8m4=
IronPort-HdrOrdr: A9a23:wk1CIKOAb7mvhcBcTjujsMiBIKoaSvp037BK7S1MoNJuEvBw9v
 re+MjzsCWftN9/Yh4dcLy7VpVoIkmskKKdg7NhXotKNTOO0AeVxelZhrcKqAeQeREWmNQ96U
 9hGZIOdeEZDzJB/LrHCN/TKade/DGFmprY+9s31x1WPGZXgzkL1XYDNu6ceHcGIjVuNN4CO7
 e3wNFInDakcWR/VLXAOpFUN9Kz3uEijfjdEGY7OyI=
X-IronPort-AV: E=Sophos;i="5.90,136,1643691600"; 
   d="scan'208";a="64987199"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Pw1thLJX6rMgArkaRY15fMasmAsHXIKqrMUhYJcWdmvCk9EaCjuhzUMwDhb2INdxd7mZ9LuqhQXcRN4mrSUX9H3U9M+cm01eAvh+Rwyox1S3r9HtP2km0wdJciZawKXz+HOei/AYz6ctF/a+xX2KSOZcakTgh/0ZJbxpb7SW8G8B8AUmxes2I/5JRfUDjEF3uhLGOQdu8IGc0Pam4PPaQ2cKH++EpW0Zp1frm61E6H/d+vYsYKou/41i0cDRq5OPuwTS2DzjpC2Rk9f6E6C8/lz/9ACk99nir6HCxeD0QtLesKf/7S8R0fwbBDdSFAq3TvPKEYGYhYY8eaWwhTZD4A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=oKtYSX1KmB/UzKlONbxyD0KC73ISEOnvwAvXlAp3hHo=;
 b=NZGPo5rs/pNHepTP3XRxXiVC5jCOG9k+gP13XloT7vd00IrxNXUe1+0GNB4ZD4eJE6NOuIs9PqscI9H0HUVmWnWlAhBB3VMzTIy1wD8hJDcEWDfzVseWcAUP500RWikNh5Iq7g2DeOZ0tQNFh8QgQpcjpLPdy3Y0jqrWcsEPkcVdAVZob0ut1B5YBSLQW28eNZO/mmV11fbMZ92lPsY6MN7fzuFNPXvgvUzzSWwx/QL8sjINS8O/aDhlsVpWHvaIrc1rTzVY2HpXg7AsHngy2ZMnNnyzSN0aFupVgdoA/vmoHI5/QLZziukCGvRBQJaiKXG0m/f5vQ84zXTMIoUY3w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=oKtYSX1KmB/UzKlONbxyD0KC73ISEOnvwAvXlAp3hHo=;
 b=LRdGqismkFQeykYZhXfoNgVK/E8rjKQO9YAJmUjoO72NeUmOsoIInzgOJ8L532jKDAl3xhXrs3RxtFcEx6JDH52t7rPI7xwOAcK1BdcERG2uBAWuOR1/jeAOAPf5FgT1D55EoyBzMIW+w42oqEeovyA93Y3XrEYD19ZuX27NwBQ=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>, Jun Nakajima
	<jun.nakajima@intel.com>, Kevin Tian <kevin.tian@intel.com>, Thiner Logoer
	<logoerthiner1@163.com>, =?utf-8?B?TWFyZWsgTWFyY3p5a293c2tpLUfDs3JlY2tp?=
	<marmarek@invisiblethingslab.com>, Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: x86/vmx: Don't spuriously crash the domain when INIT is received
Thread-Topic: x86/vmx: Don't spuriously crash the domain when INIT is received
Thread-Index: AQHYKben+W9NHlmgjUe5tEPatIDj2Kyj9FgAgAA+noA=
Date: Fri, 25 Feb 2022 12:28:32 +0000
Message-ID: <51ef6bd1-bcd9-9a3a-e902-887d42d7dd7e@citrix.com>
References: <20220224194853.17774-1-andrew.cooper3@citrix.com>
 <20220224194853.17774-3-andrew.cooper3@citrix.com>
 <12d8b90b-15b0-c094-71e5-35cfdbfe72b4@suse.com>
In-Reply-To: <12d8b90b-15b0-c094-71e5-35cfdbfe72b4@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 60d09915-8bac-4483-7c5f-08d9f85a5620
x-ms-traffictypediagnostic: BYAPR03MB4296:EE_
x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
x-microsoft-antispam-prvs: <BYAPR03MB42968E7E11373434E090C882BA3E9@BYAPR03MB4296.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: yXnCVCe80IAP7iVeNMrPKr12Rbo6g8H9jTmiv4N7B0WvP70g71Zd41yGcJHn3E8huarWqy1rOyDkUkDupGBBw7SO0i2sexy1GLrbKtCBtRmsiG41fm9K8LDNtf24GOYFSrYeOx8wgv0vnhMHEs9/DGpnpT5iLCuHLLL2b7jgezXpxJVELSctZftEyPnOPKgy/IT2DDGRn7WfvHQmBK9AlnRcqAfnQoqV/+u7LOh6Ar1wKZjFHBRGbavG4TzCthln93PQK28utpQ0AnLusjB7aX8RbP8blgpoICZwgnPx+FEiXwTIQlly0/Pxqm/K1yjjaAycuybMh6n16htDMBEo6Lxm+MDV7859vj7c+c5Sp3IVKggLSeYqEBJTQmy/Px/eHCvHJIaW7QhfzmUBvWeZLcQFoKaymK+1jlNbq+tlDIS4fGg1aGBHYGPq3ryHS9BY8YX4WQBY/3u2ii8MdLdPsRXJK4CJliJuZga8bOFdCuUvGKdiF5XqkBqZ1NbUv9d+Av38p2Ld1eHJ9KkYnYHHdM5ydo3S83BwoowsIDRjPgyPY+X6V+UMm9Mo6lOim75tDEdn6x84F/dNaig/+c51MuBmKBDsd3uMLwn+pItr7xxHakIraOX2RoXa83+kuxOg+FTQa5l1d2gq7JHNVUYlPHBkzsqy8Rijr0JSclmc2IaDa6Sn55M6ZgptT4Nx4mM4SJD5F/vI+NAdZU/2d5doCk+2VZ8ncyyiQnlsqtEUNqrod37LQiQH22Fr7u5T/n316hcAi8roKFcsa3wtqGvF9Q==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(2616005)(5660300002)(38100700002)(82960400001)(8936002)(83380400001)(38070700005)(122000001)(71200400001)(31696002)(316002)(508600001)(66556008)(53546011)(26005)(66946007)(36756003)(64756008)(8676002)(4326008)(66446008)(66476007)(86362001)(91956017)(6486002)(76116006)(6916009)(54906003)(6506007)(2906002)(31686004)(6512007)(186003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?UGI1T2ZlK2lTaUw3MEtFeFRLZUlyLzVTcEY3V1BOVGJGTnR1OGJxWGp1ckph?=
 =?utf-8?B?UUJxa2p1WTNUMUMyZ3ZydnNJMTFnWkJUc0VZNFBkUnd5akljSmpMM3dJN1Mw?=
 =?utf-8?B?TUR6V2tFNndVSExCZDk4OUl1Zmk4S2xMS0dNM2doTGlKTi9lWjh5eDFPSmY3?=
 =?utf-8?B?WndmdEVRM2RyRndmNTNBSjFJb2lpWFRkcmppY0ppcEtXbk53RkhrdnJ2K3Z5?=
 =?utf-8?B?dnk5N0FCYmJTQ1k3dWxxdmxKWjg5cWk2WWNIc1M1WDZMUFpYRE1mbFE1QkJx?=
 =?utf-8?B?YjVETGRLMmpLWERHMW81RjJvc0RZcXJ6Q09XTUlpWXM1bERLQXNFREtVZzdk?=
 =?utf-8?B?ZHZtRFAwcTMzaGVaT1Z0WnRWUXo4YU5ET2VmZnNGb0hIVVdvei9CRmlXUDA4?=
 =?utf-8?B?Ykpqby9wU0w4UStTK29QWVpVNnR1WlJyZHAyTi9yYUxsTUFKNTNoTjlWRjJu?=
 =?utf-8?B?VlJDY3ZzN2h2eDFsMnpLL2NZbldGdG8zOUJmTThzaUZRWERGeldxZ0djbmFZ?=
 =?utf-8?B?UHMzZUE0djk1WlBxejQrZ0UyZWVnOEoxL1ZlNW9kWVRPdWtQN3RwWVd1SmRP?=
 =?utf-8?B?YnN0OWF3d3lrOTVwMFRTS3ByVVVNMDdlR0hoOGpURDl0N1ZJYTJyc2lpSktC?=
 =?utf-8?B?OXJEL3I3Rit6TnFmN0VKak9RV3hDU1lMSDFsbG1pWlVkQU12dEV4WUF2amR2?=
 =?utf-8?B?djRtd3M1di9NTlVVMVdSV1k0R2FuSkw1YmttSDlWYUZkV24ydlQyaXFTaXZt?=
 =?utf-8?B?VDlKZW9jbElUQ21BczNMUlY4NU8xTUhSVkZnV0hTYllrdDRvYlNBQnVhNkw2?=
 =?utf-8?B?V3hOcTJIRTdiZld2ZlVPYVpKQ3hScC9UNzNmWGsvYXNNMHZYR3d2Ylh1eHRi?=
 =?utf-8?B?U3RzZlBidnc4YkhkYzdaL2sxTDNpYWVkVWU2dlUyc0pUdlhka043UTZjVmtm?=
 =?utf-8?B?NmZsK3pwVTFhZDZyaS9kRGh1SlR1UElpaWEvdmcvL3VDWWNFRjlYamljenln?=
 =?utf-8?B?eXVhVC9sR1VZU2dMazk1bEpCN1lDSnRpMGhLSldwMGxXNFZ3S3ZZMEdiSTNC?=
 =?utf-8?B?emU0WWVzYjY4elQzYStmcmVSeFNVZjVSMlllQmJIaWgxVityZzJFSHZUYk12?=
 =?utf-8?B?ci82dWZMQTlMSFJoZS83UXlUTStqRWtxandnOHdIUkd1NWNlM0tyZVBOQitQ?=
 =?utf-8?B?ZEFTekRKWDN3cHdaMWdzSUFOelI2RWU4NWc3bCtKUjk1QlNlUktBbVdGcVRj?=
 =?utf-8?B?R3VVTWlLL2ttUHlKeWVqSXdHS2xWODZmNU14MmpHcTJMR1NpL1pwYmcvYUkv?=
 =?utf-8?B?eXNxaHE1cDFwMmM2ZVZ6U2hBYUc1OTlCcVQrelhjWnJZTko4SEJSOEg5S3Mv?=
 =?utf-8?B?b0liMytwOVVZVnA1cDNRT2ZCcEd1OVVkcnI1SnB4dk9RemFTdkxHRElWVGVH?=
 =?utf-8?B?QWFrRk5oREhUczlvN0I2aU1vSjluTEpNTDdNYzQ2d093UkpVOGZicVdaV09n?=
 =?utf-8?B?TVdwQ3pYOTNVaWs5eW5HRXNqNnVveXVSUVlHcTlqQmd5L205NU5zL25UbU1u?=
 =?utf-8?B?bXdEbThkY1FKOWtaV2hBZ2ozTVNHbmw3NmVHWFM5Y1BkR3p1SjUxZU80UGY0?=
 =?utf-8?B?WmVDRVgwcW0rQmJMaTUrcm1wNFp3RXc1cEVraE1kZmZaY0RkMlVGb2lIZEoy?=
 =?utf-8?B?aU81aGswMFNsZUNsNmRUS2lhYnF2NEdIRWNwK2JXSFRYak1FMEh0UHVuTWtu?=
 =?utf-8?B?VTV5MmQ5MEVNNkY0T3lDMTlQalVvV3JNcHpuOHc1V0tLcVc2Wi8ydmx3OHFH?=
 =?utf-8?B?MjZOQmt3R3p0NmhhdUNoVmc4YzhoajVLQnNlWVNCZGNLVCs2aldsVzUwNlI3?=
 =?utf-8?B?M3lvNjMvRFN0VGx5QmFZT2lIYzF0VGtjdE5welg0bkdBb2txVzBjMEtKSWx0?=
 =?utf-8?B?dnA3d3JsMFUwZEtTL3VVczVDbmlRaHpVUkxNS3k4aFk4YkNnd1JlRmZqalN4?=
 =?utf-8?B?bkdrVWV5cjdVVkx6S0ZlZmEzdmlXS1haRkxSUTJXM0J6NVdwTWpZVVlUL1J0?=
 =?utf-8?B?R3VOU0F2NlBqVlVIQWpmQjcxdXVhN0N0MFgycldMZ0pvWUN4V2dCcjBEWXY0?=
 =?utf-8?B?ZTRXbDJVQVhweExUWnV1NFBLbmlCYW5WNlZYeWdQN0JwUDVTVnJsU3hQRXps?=
 =?utf-8?B?cEErSnc1MzhZbHZLUEJrSXVTQXVUUXlyQm1ZK25JNEFidEhMTkJ6MlRWVjVj?=
 =?utf-8?B?bEJjZWVMOHU4WWpNbUZYdHFoam1BPT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <A088CE51542225429BC0A33B8EFB798E@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 60d09915-8bac-4483-7c5f-08d9f85a5620
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Feb 2022 12:28:32.4881
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: wiPrTS1xVI51PBqP66ILtiFHSMldiJV5THUetD7RkaezTNqWLyw1du5aUqb3+O7D+JYSIPRHCb9OumPNe5S1jfIPscNJMomwAjLAgE/j1oY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4296
X-OriginatorOrg: citrix.com

T24gMjUvMDIvMjAyMiAwODo0NCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDI0LjAyLjIwMjIg
MjA6NDgsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBJbiBWTVggb3BlcmF0aW9uLCB0aGUgaGFu
ZGxpbmcgb2YgSU5JVCBJUElzIGlzIGNoYW5nZWQuICBFWElUX1JFQVNPTl9JTklUIGhhcw0KPj4g
bm90aGluZyB0byBkbyB3aXRoIHRoZSBndWVzdCBpbiBxdWVzdGlvbiwgc2ltcGx5IHNpZ25hbHMg
dGhhdCBhbiBJTklUIHdhcw0KPj4gcmVjZWl2ZWQuDQo+Pg0KPj4gSWdub3JpbmcgdGhlIElOSVQg
aXMgcHJvYmFibHkgdGhlIHdyb25nIHRoaW5nIHRvIGRvLCBidXQgaXMgaGVscGZ1bCBmb3INCj4+
IGRlYnVnZ2luZy4gIENyYXNoaW5nIHRoZSBkb21haW4gd2hpY2ggaGFwcGVucyB0byBiZSBpbiBj
b250ZXh0IGlzIGRlZmluaXRlbHkNCj4+IHdyb25nLiAgUHJpbnQgYW4gZXJyb3IgbWVzc2FnZSBh
bmQgY29udGludWUuDQo+Pg0KPj4gRGlzY292ZXJlZCBhcyBjb2xsYXRlcmFsIGRhbWFnZSBmcm9t
IHdoZW4gYW4gQVAgdHJpcGxlIGZhdWx0cyBvbiBTMyByZXN1bWUgb24NCj4+IEludGVsIFRpZ2Vy
TGFrZSBwbGF0Zm9ybXMuDQo+IEknbSBhZnJhaWQgSSBkb24ndCBmb2xsb3cgdGhlIHNjZW5hcmlv
LCB3aGljaCB3YXMgKG9ubHkpIG91dGxpbmVkIGluDQo+IHBhdGNoIDE6IFdoeSB3b3VsZCB0aGUg
QlNQIHJlY2VpdmUgSU5JVCBpbiB0aGlzIGNhc2U/DQoNClNIVVRET1dOIGlzIGEgc2lnbmFsIGVt
aXR0ZWQgYnkgYSBjb3JlIHdoZW4gaXQgY2FuJ3QgY29udGludWUuwqAgVHJpcGxlDQpmYXVsdCBp
cyBvbmUgY2F1c2UsIGJ1dCBvdGhlciBzb3VyY2VzIGluY2x1ZGUgYSBkb3VibGUgI01DLCBldGMu
DQoNClNvbWUgZXh0ZXJuYWwgY29tcG9uZW50LCBpbiB0aGUgUENIIEkgZXhwZWN0LCBuZWVkcyB0
byB0dXJuIHRoaXMgaW50byBhDQpwbGF0Zm9ybSByZXNldCwgYmVjYXVzZSBvbmUgbWFsZnVuY3Rp
b25pbmcgY29yZSBjYW4ndC7CoCBJdCBpcyB3aHkgYQ0KdHJpcGxlIGZhdWx0IG9uIGFueSBsb2dp
Y2FsIHByb2Nlc3NvciBicmluZ3MgdGhlIHdob2xlIHN5c3RlbSBkb3duLg0KDQo+IEFuZCBpdCBh
bHNvIGNhbm5vdCBiZSB0aGF0IHRoZSBJTklUIHdhcyByZWNlaXZlZCBieSB0aGUgdkNQVSB3aGls
ZSBydW5uaW5nIG9uDQo+IGFub3RoZXIgQ1BVOg0KDQpJdCdzIG5vdGhpbmcgKHJlYWxseSkgdG8g
ZG8gd2l0aCB0aGUgdkNQVS7CoCBJTklUIGlzIGEgZXh0ZXJuYWwgc2lnbmFsIHRvDQp0aGUgKHJl
YWwpIEFQSUMsIGp1c3QgbGlrZSBOTUkvZXRjLg0KDQpJdCBpcyB0aGUgbmV4dCBWTUVudHJ5IG9u
IGEgQ1BVIHdoaWNoIHJlY2VpdmVkIElOSVQgdGhhdCBzdWZmZXJzIGENClZNRW50cnkgZmFpbHVy
ZSwgYW5kIHRoZSBWTUVudHJ5IGZhaWx1cmUgaGFzIG5vdGhpbmcgdG8gZG8gd2l0aCB0aGUNCmNv
bnRlbnRzIG9mIHRoZSBWTUNTLg0KDQpJbXBvcnRhbnRseSBmb3IgWGVuIGhvd2V2ZXIsIHRoaXMg
aXNuJ3QgYXBwbGljYWJsZSBmb3Igc2NoZWR1bGluZyBQVg0KdkNQVXMsIHdoaWNoIGlzIHdoeSBk
b20wIHdhc24ndCB0aGUgb25lIHRoYXQgY3Jhc2hlZC7CoCBUaGlzIGFjdHVhbGx5DQptZWFudCB0
aGF0IGRvbTAgd2FzIGFsaXZlIGFuIHVzYWJsZSwgYWxiZWl0IGl0IHNoYXJpbmcgYWxsIHZDUFVz
IG9uIGENCnNpbmdsZSBDUFUuDQoNCg0KVGhlIGNoYW5nZSBpbiBJTklUIGJlaGF2aW91ciBleGlz
dHMgZm9yIFRYVCwgd2hlcmUgaXMgaXQgY3JpdGljYWwgdGhhdA0Kc29mdHdhcmUgY2FuIGNsZWFy
IHNlY3JldHMgZnJvbSBSQU0gYmVmb3JlIHJlc2V0dGluZy7CoCBJJ20gbm90IHdhbnRpbmcNCnRv
IGdldCBpbnRvIGFueSBvZiB0aGF0IGJlY2F1c2UgaXQncyBmYXIgbW9yZSBjb21wbGljYXRlZCB0
aGFuIEkgaGF2ZQ0KdGltZSB0byBmaXguDQoNClhlbiBzdGlsbCBpZ25vcmVzIHRoZSBJTklULCBi
dXQgbm93IGRvZXNuJ3QgY3Jhc2ggYW4gZW50aXJlbHkgaW5ub2NlbnQNCmRvbWFpbiBhcyBhIHNp
ZGUgZWZmZWN0IG9mIHRoZSBwbGF0Zm9ybSBzZW5kaW5nIGFuIElOSVQgSVBJLg0KDQp+QW5kcmV3
DQoNClAuUy4gVGhpcyBpcyBhbHNvIGZ1biB3aXRob3V0IGludGVycnVwdCByZW1hcHBpbmcuwqAg
WFNBLTMgZGlkbid0IGltYWdpbmUNCnRoZSBmdWxsIHNjb3BlIG9mIHByb2JsZW1zIHdoaWNoIGNv
dWxkIG9jY3VyLg0K


From xen-devel-bounces@lists.xenproject.org Fri Feb 25 12:41:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 12:41:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279070.476599 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNZuM-0001Hh-7j; Fri, 25 Feb 2022 12:41:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279070.476599; Fri, 25 Feb 2022 12:41:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNZuM-0001Ha-4X; Fri, 25 Feb 2022 12:41:14 +0000
Received: by outflank-mailman (input) for mailman id 279070;
 Fri, 25 Feb 2022 12:41:12 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ZUh1=TI=citrix.com=prvs=04827bf5e=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nNZuK-0001HU-P8
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 12:41:12 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 323a3b82-9638-11ec-8eb8-a37418f5ba1a;
 Fri, 25 Feb 2022 13:41:06 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 323a3b82-9638-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645792865;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=la1fAJ8UP1zhnZR7eEXYw9LSuWccAxsyPyp/KC8csKE=;
  b=ZVZnJP493oyAfhAidZgIH8Q/92KS6ee/bKvJmekKKmy9/807BmjqCbt/
   EZXi6sDLUvKtiwdvQHSiA/b/mD+n41girpPwztAMys590KjYqzOE2nGB6
   IWRPpbEFjAFBaGhG0LR1P5g1BPgF3s+ntHzk2Wv5x3Y/HM07Wh22sDGlq
   c=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 67251824
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:6FUhLKBC6P+NfRVW//zjw5YqxClBgxIJ4kV8jS/XYbTApD5x0TcBy
 mVJX2DVb/+JZTGjf9sib4619ksB7MKBztYyQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHWeIdA970Ug5w7Rj39Yy6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhr9
 +dwkZKKezsJHZPrqv8cThcbKiVXaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguwKKsXxMZxZkXZn1TzDVt4tQIzZQrWM7thdtNs1rp4RR6uHN
 5BFAdZpRAjLewVBYQ0oM4kBk+P22mCvWTJ/k03A8MLb5ECMlVcsgdABKuH9f9WQQMxPk0Wwp
 2TY/n/4CBUXKNyezzWe9numwOTImEvTSI8UUbG16PNuqFmS3XAITg0bU0Ohpvu0gVL4XMhQQ
 2QQ/SUpoLIu9E2tQ8Okd0Tm+ziPuRt0c9haHvA+6QqN4rHJ+AvfDW8BJhZebPQ2uclwQiYlv
 mJlhPuwW2Yp6ufMDyvAqPHE9lteJBT5M0cYWh05aQU/0eXDg78UvAnOU9ggKaqc24id9S7L/
 xiGqy03hrM2hMEN1rmm8V2vvw9AtqQlXSZuuFyJAzvNAhdRIdf8Otf2sQSzAeNocd7BJmRtq
 kTojCR3AAomKZiW3BKAT+wWdF1Cz6bUaWaM6bKD8nRIythMx5JBVdwBiN2dDB0wWirhRdMPS
 BWC0e+2zMUOVEZGlYctP+qM5z0ClMAM7+jNWPHOdcZpaZNsbgKB9ywGTRfOgz2yzBFwzPlnY
 c/znSOQ4ZAyU/UPIN2eHbp17FPW7npmmTO7qW7TlXxLLoZylFbKEOxYYTNin8gy7b+eoRW9z
 jqsH5Di9vmra8WnOnO/2ddKdTgidCFnbbir+50/XrPSeWJORTB+Y8I9NJt8IuSJaYwOzbyWl
 px8M2cFoGfCaYrvcl3bOig+M+q0Bf6SbxsTZEQRALph4FB6Ca6H56YDbZonO74h8e1o1/lvS
 PcZPc6HB5xypv7volzxsbGVQFReSSmW
IronPort-HdrOrdr: A9a23:qAHFsayqGs1GEhtc0xpYKrPxguskLtp133Aq2lEZdPULSKOlfp
 GV8MjziyWYtN9IYgBcpTiBUJPwJE81bfZOkMYs1MSZLXXbUQyTXc9fBOrZsnHd8kjFmNK1up
 0QCpSWZOeAbmSSyPyKmjVQcOxQgeVvkprY/ds2pk0FJWoBCsFdBkVCe32m+yVNNVJ77PECZf
 6hD7981lydkAMsH6OG7xc+Lor+juyOsKijTQ8NBhYh5gXLpyiv8qTGHx+R2Qpbey9TwJ85mF
 K10zDR1+GGibWW2xXc32jc49B9g9360OZOA8SKl4w8NijssAC1f45sMofy/wzd4dvfqmrCou
 O85yvIDP4DrE85uVvF5ycF7jOQlQrGLUWSkGNwz0GT+fARDwhKdPapzbgpDCcxrXBQ5u2UmZ
 g7r15w/fBsfGL9tTW46N7SWx5wkE2o5XIkjO4IlnRaFZATcblLsOUkjQho+bo7bWvHAbocYa
 FT5QDnlYJrWELfa2qcsnhkwdSqUHh2FhCaQlIassjQ1zRNhnh2w0YR2cRaxx47hd8AYogB4/
 6BPrVjlblIQMNTZaVhBP0ZSc/yDmDWWxrDPG+bPFyiHqAaPHDGrYLx/dwOlauXUY1NyIF3lI
 XKUVteu2J3c0XyCdeW1JkO6RzJSHXVZ0Wa9iif3ekPhlTRfsuYDcTYciFcryKJmYRrPvHm
X-IronPort-AV: E=Sophos;i="5.90,136,1643691600"; 
   d="scan'208";a="67251824"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=nCtXdOKsKA3/gMsw6cuT3O1kjzkxRMieGojDJi8LYiDj3VNCCXrGYNb5BNcNVbnCUO7UYgX3COT0HVoe/k/rtR6W7PdVk3qCQ8MzhmDO/LmQHXP6eAPHC6j9x9wdcZI93oORTD7yoaX4YabR07xDtZ9koT1xkl5hm1mSuiNkxvCzlEywP/Sfj0rp05jtLg9qZdZiVa0D/pH5CCabfNmLILu/coR/lYUKHAvdbOVwmkOFW6ZzTuNevsC9fOTWYZILzsjU7cP0lEco8mtL/cmd2BKF5krVnzYaG8Rx8loMSFlQThPPs16QXQen7jMncMDX54BOVVOSRFfYhSHUN74egQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=la1fAJ8UP1zhnZR7eEXYw9LSuWccAxsyPyp/KC8csKE=;
 b=a0V8G2cEhzmP4ejU/Vwu8gGKjyiYPDGOAljMgnttsSmi4hMoVMKP1kOKoHYERrt9dPgsyKupOHXcKAYLcr75xXeR9eM8P5KDZPGmFIbwg4R21OQn7RSctg5qM1TIzDRlpJnaY88aQYW0F2IVpBDiYyKsNWA2bfr5pi3gdWNRsulNCFFrrgBD1xZKKcVTib5X3Uh28skVA3nBAGWe265b9AJtGJGoT41p1BhdtQHrNXsCb47rLpyZyQE/GLzF1Awix/D2sYSJRJsloTcJoiqgMwb+H5iFoIIJzS77uov16WsEbvrK+It9yI07WNQiX6c73M60yFpVO/2i8/TqzOiq4A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=la1fAJ8UP1zhnZR7eEXYw9LSuWccAxsyPyp/KC8csKE=;
 b=jIzK+NfME5yPw2ThgQOY7Ql+lgUHFSfpq+lcdIVpxuUuPPk8rhBQ92+dKgi13+kIMZh225fE068PnCHPvHVEpKDIb5OR9sYU/esG6cH3BF6+3ocgaS+MtwXJxJrKg7vguP0pohTBbqqylhwYvjJ8ICchEv5h6ZruMWBN3awlisg=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>, "Thiner
 Logoer" <logoerthiner1@163.com>,
	=?utf-8?B?TWFyZWsgTWFyY3p5a293c2tpLUfDs3JlY2tp?=
	<marmarek@invisiblethingslab.com>, Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: x86/CET: Fix S3 resume with shadow stacks active
Thread-Topic: x86/CET: Fix S3 resume with shadow stacks active
Thread-Index: AQHYKbemeqHKT0/FpkqigAUimYUei6yj8pMAgABD3oA=
Date: Fri, 25 Feb 2022 12:41:00 +0000
Message-ID: <ec8e8166-aad6-54b9-a58d-2681e690ce55@citrix.com>
References: <20220224194853.17774-1-andrew.cooper3@citrix.com>
 <20220224194853.17774-2-andrew.cooper3@citrix.com>
 <9b1f517f-eb4d-ddc7-b957-4f0354ee2b9d@suse.com>
In-Reply-To: <9b1f517f-eb4d-ddc7-b957-4f0354ee2b9d@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: b5e7450b-e3c2-451a-26a9-08d9f85c13d8
x-ms-traffictypediagnostic: SN6PR03MB3600:EE_
x-microsoft-antispam-prvs: <SN6PR03MB360060B17249EDE04A127BD6BA3E9@SN6PR03MB3600.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: GCht6HCQzAw++C0yYU3z1w08gflU6cN1DB+3vtbD+D3Twjk+J35DYu5tzXNFcZdiYq2Vp/uO3BseeBq2ABjGDZUyDhBKaumfdn9pM3QjZW4Z8xxbf43hNxRWSWYPs1vdgRa/DV0VbXfTwbV+NG18v34UeFQNY5/M8lfZTKaqmzLWap8MKm7h0hftDWDnpBwxMp3gihDbVnNUBziIWS6NqH6p2IV6ZMMbRPRFCuG0J2ypXW5Z5+AXdckBraT76p3/T0a5P2aCqDyVqAtW0EO6kvEoLjIuw1l4qiBc4TrdmsFBVXaC9uyZb9KMX8b/eYJP7DdVSn2oMB8IF2+7L/W45nLnS6i3HCTvRaleAJoqgHW1RRRXzkWyu1MEFsHkUs0Q2yZzpt9nXa5ZPy0tdW3uEkiD3jY1whs29XyNIdUU3esAKxeuDfnpAWyv2Jc42iyMTvBW5nNDbUnRVR+qurlkFJmQ/JqIrDwYCSci0ZAA/G41G4l4Y1vuV7MpnYjrWGWSog5VNtp6AaWh11j/Sxetjl0J2wrvcc2yW2S5yEggbwEBLHRJ8wrxS2/t9DN/9Q0N7BDVElTJ5C6UBQL++GuzROR1XOrmvETgYy+JQDGYcFybPzjetOEwmVqvJvHGS4D7KAPL8T03UFq/2bAjGU7En9RRP+MZbMwJZK1bGrvMkeTnxOFNDM/SdNftTHs2s0kNIk4cnpbZhFxC/cLV496pZRDFGkdugqMBgCNhHSBXiYeqgE3sjShYj7epEe6wmpXcg3pkG7OG7dg9AyArpNmGHn6RKR+ObD18E0Lhezt267MUUfwmEw7xq1SXLvBi8cpqzT/UlorjDK7yEVamHAmO6s9GtIi+RgS2SvVmPZvT0BU=
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(82960400001)(8936002)(86362001)(5660300002)(66446008)(64756008)(66946007)(66556008)(6512007)(122000001)(6506007)(91956017)(31696002)(53546011)(4326008)(38100700002)(8676002)(66476007)(54906003)(76116006)(26005)(36756003)(83380400001)(186003)(38070700005)(2906002)(2616005)(508600001)(66574015)(6486002)(6916009)(966005)(71200400001)(31686004)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?ZFdDNC9zUXJROHZtSWlEL2J5MWxSbTNLamNzSWFsNzlYMkduNU5DclJKS3I0?=
 =?utf-8?B?aWl1NE85VDk2dWs1anhqY00yNDIyRStBdnVqSGNPVnErZDVlTUo2T0E1dkhi?=
 =?utf-8?B?TmVNdXpJUEpENEwyRWVUT2QwN3VLYktGRnZNVmVITEdmVG5ja2ZHcjY1cDNL?=
 =?utf-8?B?ZHozNGtTWkJuZ3lRcHdvUTE2YWdBbGJSSEFnWE5sMlM3bzFmbCtFUFZ2ZGcw?=
 =?utf-8?B?MmVaOEprNUJnUzNtUy9VRy9EVVpMazZTekx0bWxWR1UrdEJFb2VSYUZLaU1R?=
 =?utf-8?B?dWpvK0VJb09zaG9sZnNzVWdKUXJRQzlnMjExb21iMWV3S1hXODkvVmd5RUpq?=
 =?utf-8?B?eVl2UkVrNFBPUzJSQXUzRk5IRmxkY1BncjRsTThyOGF5Q1ZnMlVlblZ5elI5?=
 =?utf-8?B?ZEZGUklxVnJSeXRNMXFabnZ6dnR0OGN4VXVnNjNpQ2ZUZ0VjYlJWeTVFUXJ3?=
 =?utf-8?B?a1dkZWl2WXdKL2RzakxrVTRBdldIK05sTXZpM2oxaDdObXZycnU4Rk9jV2ll?=
 =?utf-8?B?NHM4RFF1VGVDY3Y3b2JCYnFoZmdiMUdkankra1AxdTNtam85WlRlWnVtQkJ3?=
 =?utf-8?B?bXRDS2hNa05iRGZTZWcvdjY3aGo4a1MxVXlxdmU3R0Z2dXFSNVdiWFFpV0pM?=
 =?utf-8?B?VFYwVUZZalNHa3VQNm1BSm9oNVdPeExhK2RZcDFwUUpGWjllSHdTUCs1M0tw?=
 =?utf-8?B?OUdsVDRHd29kMnRKenBwdjZEakpVTHhFakxvaG1ySDJLTGlta2g2RFQzQmNG?=
 =?utf-8?B?NGhVaTFib1pJbE12S01GVE0xQ3hDUHZvRVJrdjVnK2sxb2V3bWRoQ3lPbHBB?=
 =?utf-8?B?SG0xZ09LenQvaHh0dU01WkZaNEFpbWg3Unh1QVRjaVByU0crRHhRVFg3UVJR?=
 =?utf-8?B?N0p6ZnYwYWpuSkRzc3dsTXFwWjI5bkhUNHRrM005TklTUEFkQXU0NG15b1U5?=
 =?utf-8?B?dDJqak9WcG5hOTltbDF0d2E2YmR4cXpOMDB1WTg1NEZhYUp1TkQyMy9Ockk2?=
 =?utf-8?B?dlRHek0rVzFKckJidUhMNkxXa3ZocDV3N2Iya29VeVdrZGhMaDNUTXpPNldY?=
 =?utf-8?B?elZFbk5MMGQ5NlNZZFFHa2cvZng0ZmJ3eFR1bnJhV040aDlJcWMzWk9kb1RL?=
 =?utf-8?B?N2huSnA3K3JPMTlqVEVKc3JCR3dtY2pXbFFDK0c1RTU3RzhZK1BKRFB0RkRC?=
 =?utf-8?B?Sm9DclJ4bWNoZXZiVys2Mis0aUVUeUtMSW1qYllDaWxsUXZ6WkNpVmxrQjFl?=
 =?utf-8?B?U1NSaGlPaFBOaGIyVmtKa2NqWEluVmVlckNjeUhJWkJzSzJvM042bkl6ZzZE?=
 =?utf-8?B?Y1BtVkxmdjBGZkYyOGxyZjZDLzAvZEpTSUw3NlNqeGh1TzJLSTR0RmppNW5I?=
 =?utf-8?B?OENkOUgraW5hOUc2U1FkSXBEMHlTT2ZKRVQvQ3VOMDAwaWlmNVpMa1BjMTE2?=
 =?utf-8?B?TUEvem56aWFVRW1TNGJiYkVtdUI5NFNpcGZNbmdGRWRZNTBhOFFlRGQ1SThJ?=
 =?utf-8?B?dWpBT0xyQ2ppUlVQSlJEU1lkUXAvT2tvTFVFV2ZWL0IzTXUvczdRd3VFbTc2?=
 =?utf-8?B?NnFaUkdGK2VTTTZMUllaZjlGMWFGWk0xTERKdFN1UXU2SFJ0bGhNTEQ0WkdW?=
 =?utf-8?B?WTZFMElWeW9LZkxFS1d1UFBpb3JvNThuWnNqUTdYY3NuV0NpZVh2bjdlL1By?=
 =?utf-8?B?MjFyMHNYdDE4NUY1c1lRa2FMYWcwVFJKZDI0VmVMV1NFeUpZNm1CM241bU05?=
 =?utf-8?B?eVE0bXpUNVc3VE8vVC9PWUF3ZTNJRE5HdlJHcnlsZXAzSCtHMXRvczZpaTRs?=
 =?utf-8?B?ZHpNRWZ0bWp3QnR5NzdqaS9uVGpveFFwVzBrOUh0M2lXZ2pncFlTMmVRMGpB?=
 =?utf-8?B?bGpaOUtSQVNLNlA0cGZMRXRnZWlZNjQwamtsMjNzeUJmRjRuVmFBaHVEOWdk?=
 =?utf-8?B?bVZmZ0NHWXBnU3RjSzhLV3Z5MU1OSkhoOFB0NVJ1eTF2T25PaU1waFNvcWpS?=
 =?utf-8?B?eEhXeXNxN2hvQm8wZXNkUXZtemNEbDJUMW5pMTdpNlBXOVFQaE9US1dUZnVi?=
 =?utf-8?B?UUFja1diQWdRSjdwTFRtS3oxS0lPN3FNcnlGYWkrUTEvSkVTY3R4bTAvOFI1?=
 =?utf-8?B?dkc1WjZHdndvemlTN2xjUEpVakFqRWJhZU1SQlIxNHcxdk0vQTdLMlgvaEZD?=
 =?utf-8?B?dm1SYzRRYVlMa1FqUFV6bmhrNFFHVEcwUjdOQnNvRXZiMkltTmJlOFlLcjR4?=
 =?utf-8?B?TnVoQnp3aEVGRFlSeVJnMGRxYTN3PT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <07567A3C09D6E240A54F0375AF1D77A4@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b5e7450b-e3c2-451a-26a9-08d9f85c13d8
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Feb 2022 12:41:00.0904
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: KHfPjTCNqx6NrP81vX1TXbuCXeU2sfMCLNHf3w+J1A3np7vzPozTliyXz9NtNYXzxmYPg1vuc4RF+YG+C7pk0g6TA9brWYet2WMDbvSI3Bk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR03MB3600
X-OriginatorOrg: citrix.com

T24gMjUvMDIvMjAyMiAwODozOCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDI0LjAyLjIwMjIg
MjA6NDgsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBUaGUgb3JpZ2luYWwgc2hhZG93IHN0YWNr
IHN1cHBvcnQgaGFzIGFuIGVycm9yIG9uIFMzIHJlc3VtZSB3aXRoIHZlcnkgYml6emFyZQ0KPj4g
ZmFsbG91dC4gIFRoZSBCU1AgY29tZXMgYmFjayB1cCwgYnV0IEFQcyBmYWlsIHdpdGg6DQo+Pg0K
Pj4gICAoWEVOKSBFbmFibGluZyBub24tYm9vdCBDUFVzIC4uLg0KPj4gICAoWEVOKSBTdHVjayA/
Pw0KPj4gICAoWEVOKSBFcnJvciBicmluZ2luZyBDUFUxIHVwOiAtNQ0KPj4NCj4+IGFuZCB0aGVu
IGxhdGVyIChvbiBhdCBsZWFzdCB0d28gSW50ZWwgVGlnZXJMYWtlIHBsYXRmb3JtcyksIHRoZSBu
ZXh0IEhWTSB2Q1BVDQo+PiB0byBiZSBzY2hlZHVsZWQgb24gdGhlIEJTUCBkaWVzIHdpdGg6DQo+
Pg0KPj4gICAoWEVOKSBkMXYwIFVuZXhwZWN0ZWQgdm1leGl0OiByZWFzb24gMw0KPj4gICAoWEVO
KSBkb21haW5fY3Jhc2ggY2FsbGVkIGZyb20gdm14LmM6NDMwNA0KPj4gICAoWEVOKSBEb21haW4g
MSAodmNwdSMwKSBjcmFzaGVkIG9uIGNwdSMwOg0KPj4NCj4+IFRoZSBWTUV4aXQgcmVhc29uIGlz
IEVYSVRfUkVBU09OX0lOSVQsIHdoaWNoIGhhcyBub3RoaW5nIHRvIGRvIHdpdGggdGhlDQo+PiBz
Y2hlZHVsZWQgdkNQVSwgYW5kIHdpbGwgYmUgYWRkcmVzc2VkIGluIGEgc3Vic2VxdWVudCBwYXRj
aC4gIEl0IGlzIGENCj4+IGNvbnNlcXVlbmNlIG9mIHRoZSBBUHMgdHJpcGxlIGZhdWx0aW5nLg0K
Pj4NCj4+IFRoZSByZWFzb24gdGhlIEFQcyB0cmlwbGUgZmF1bHQgaXMgYmVjYXVzZSB3ZSBkb24n
dCB0ZWFyIGRvd24gdGhlIHN0YWNrcyBvbg0KPj4gc3VzcGVuZC4gIFRoZSBpZGxlL3BsYXlfZGVh
ZCBsb29wIGlzIGtpbGxlZCBpbiB0aGUgbWlkZGxlIG9mIHJ1bm5pbmcsIG1lYW5pbmcNCj4+IHRo
YXQgdGhlIHN1cGVydmlzb3IgdG9rZW4gaXMgbGVmdCBidXN5Lg0KPj4NCj4+IE9uIHJlc3VtZSwg
U0VUU1NCU1kgZmluZHMgdGhlIHRva2VuIGFscmVhZHkgYnVzeSwgc3VmZmVycyAjQ1AgYW5kIHRy
aXBsZQ0KPj4gZmF1bHRzIGJlY2F1c2UgdGhlIElEVCBpc24ndCBjb25maWd1cmVkIHRoaXMgZWFy
bHkuDQo+Pg0KPj4gUmV3b3JrIHRoZSBBUCBicmluZ3VwIHBhdGggdG8gKHJlKWNyZWF0ZSB0aGUg
c3VwZXJ2aXNvciB0b2tlbi4gIFRoaXMgZW5zdXJlcw0KPj4gdGhlIHByaW1hcnkgc3RhY2sgaXMg
bm9uLWJ1c3kgYmVmb3JlIHVzZS4NCj4+DQo+PiBGaXhlczogYjYwYWI0MmRiMmYwICgieDg2L3No
c3RrOiBBY3RpdmF0ZSBTdXBlcnZpc29yIFNoYWRvdyBTdGFja3MiKQ0KPj4gTGluazogaHR0cHM6
Ly9naXRodWIuY29tL1F1YmVzT1MvcXViZXMtaXNzdWVzL2lzc3Vlcy83MjgzDQo+PiBSZXBvcnRl
ZC1ieTogVGhpbmVyIExvZ29lciA8bG9nb2VydGhpbmVyMUAxNjMuY29tPg0KPj4gUmVwb3J0ZWQt
Ynk6IE1hcmVrIE1hcmN6eWtvd3NraS1Hw7NyZWNraSA8bWFybWFyZWtAaW52aXNpYmxldGhpbmdz
bGFiLmNvbT4NCj4+IFNpZ25lZC1vZmYtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIz
QGNpdHJpeC5jb20+DQo+PiBUZXN0ZWQtYnk6IFRoaW5lciBMb2dvZXIgPGxvZ29lcnRoaW5lcjFA
MTYzLmNvbT4NCj4+IFRlc3RlZC1ieTogTWFyZWsgTWFyY3p5a293c2tpLUfDs3JlY2tpIDxtYXJt
YXJla0BpbnZpc2libGV0aGluZ3NsYWIuY29tPg0KPiBSZXZpZXdlZC1ieTogSmFuIEJldWxpY2gg
PGpiZXVsaWNoQHN1c2UuY29tPg0KDQpUaGFua3MuDQoNCj4+IFNsaWdodGx5IFJGQy4gIFRoaXMg
ZG9lcyBmaXggdGhlIGNyYXNoIGVuY291bnRlcmVkLCBidXQgaXQgb2NjdXJzIHRvIG1lIHRoYXQN
Cj4+IHRoZXJlJ3MgYSByYWNlIGNvbmRpdGlvbiB3aGVuIFMzIHBsYXRmb3JtIHBvd2VyZG93biBp
cyBpbmNpZGVudCB3aXRoIGFuDQo+PiBOTUkvI01DLCB3aGVyZSBtb3JlIHRoYW4ganVzdCB0aGUg
cHJpbWFyeSBzaGFkb3cgc3RhY2sgY2FuIGVuZCB1cCBidXN5IG9uDQo+PiByZXN1bWUuDQo+Pg0K
Pj4gQSBsYXJnZXIgZml4IHdvdWxkIGJlIHRvIGNoYW5nZSBob3cgd2UgYWxsb2NhdGUgdG9rZW5z
LCBhbmQgYWx3YXlzIGhhdmUgZWFjaA0KPj4gQ1BVIHNldCB1cCBpdHMgb3duIHRva2Vucy4gIEkg
ZGlkbid0IGRvIHRoaXMgb3JpZ2luYWxseSBpbiB0aGUgaG9wZXMgb2YgaGF2aW5nDQo+PiBXUlNT
USBnZW5lcmFsbHkgZGlzYWJsZWQsIGJ1dCB0aGF0IHBsYW4gZmFpbGVkIHdoZW4gZW5jb3VudGVy
aW5nIHJlYWxpdHkuLi4NCj4gV2hpbGUgSSB0aGluayB0aGlzIHdhbnRzIGZpeGluZyBvbmUgd2F5
IG9yIGFub3RoZXIsIEkgYWxzbyB0aGluayB0aGlzDQo+IHNob3VsZG4ndCBibG9jayB0aGUgaW1t
ZWRpYXRlIGZpeCBoZXJlICh3aGljaCBhZGRyZXNzZXMgYW4gdW5jb25kaXRpb25hbA0KPiBjcmFz
aCByYXRoZXIgdGhhbiBhIHByZXR0eSB1bmxpa2VseSBvbmUpLg0KDQpGYWlyIHBvaW50LsKgIEkn
bGwgZ2V0IHRoaXMgY29tbWl0dGVkIG5vdywgYW5kIHdvcmsgb24gdGhlIElTVCBzaHN0a3MgbGF0
ZXIuDQoNCkFzIGEgbm90ZSBmb3IgYmFja3BvcnRpbmcsIHRoaXMgZGVwZW5kcyBvbiB0aGUgYWRq
dXN0bWVudHMgbWFkZSBpbiBjL3MNCjMxMTQzNGJmYzlkMSBzbyBpc24ndCBzYWZlIHRvIGJhY2tw
b3J0IGluIGV4YWN0bHkgdGhpcyBmb3JtLsKgIEknbGwgc29ydA0Kc29tZXRoaW5nIG91dCBpbiBk
dWUgY291cnNlLg0KDQp+QW5kcmV3DQo=


From xen-devel-bounces@lists.xenproject.org Fri Feb 25 13:08:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 13:08:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279077.476609 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNaKZ-0003ok-E3; Fri, 25 Feb 2022 13:08:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279077.476609; Fri, 25 Feb 2022 13:08:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNaKZ-0003od-B4; Fri, 25 Feb 2022 13:08:19 +0000
Received: by outflank-mailman (input) for mailman id 279077;
 Fri, 25 Feb 2022 13:08:18 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=E0Ll=TI=citrix.com=prvs=04808661d=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nNaKY-0003oX-1t
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 13:08:18 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id fbdd7409-963b-11ec-8539-5f4723681683;
 Fri, 25 Feb 2022 14:08:13 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fbdd7409-963b-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645794496;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=/dLasjR4QNQQl1HUPUWbJ6+yTkW58wF5ll0k2xMBRrg=;
  b=f+3NdM3PrvP6KwHhEPQ6Ywuf2/ux46THUPjT1OkNRZAxMiIkeqi/fFoJ
   8RQ5Mc9ZC9H45kA4L+u/6mbHJYfqxu+aScqVTnl8S848bvNxP8cWH9eOW
   nxUlW3e4XIYgHpLnrBH4GkNuHwuMJ7IHyYYjNqoRL+KOOPvpI23cCdAs+
   k=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 64988098
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:a4Y5t6+02LZDjsfVNbrKDrUDG36TJUtcMsCJ2f8bNWPcYEJGY0x3m
 mVMXziAO/vbZ2byc9EnPI6+9BkC78ODzINjSQc6qyk8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si+Fa+Sn9T8mvU2xbuKU5NTsY0idfic5DnZ54f5fs7Rh2NQw24LkW1nlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCna6iQiNxZaHXpP1DDQNIFy5nNLRv0rCSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFIoZpnFnyyCfFfs8SIrPa67L+cVZzHE7gcUm8fP2O
 ZZIOWo3PUSojxtnJ3FQE54/s8GTv3DbQQ9ElXOMmfRv7D2GpOB2+Oe0a4eEEjCQfu1rmUKfq
 nPD7n7OKBgQP9yCyhKI6nupwOTImEvTQ5kOHbe18vprhly7xWEJDhASE1yhrpGRgEOkR8hWL
 UBS/yM0tLUz72SiVNy7VBq9yFaHswAdXZxMEuQ8wACL1qfQpQ2eAwAsTCNHLtovt8Y0RDkj/
 l6Pg97tQzdotdW9Vna15rqS6zSoNkA9PWIEICMJUwYBy93iu50oyALCSM55F6y4hcGzHiv/q
 xiIozI5nK47ltMQ2uOw+lWvqzCxopnESCYl6wORWXiqhit7boO4Y42j6XDA8O1Nao2eSzG8U
 GMswpbEqrpUVNfUyXLLEL5l8KyVC+itAi/XpQY0E4Id7mrz4W6ncplZ+RhUKxI8WiobQgPBb
 EjWsAJXwZZcOnq2cKN6C76M59QWIbvIToq8CK2NBjZaSt0oLVLconkyDaKF9z21yCARfbcD1
 YB3mCpGJVITEuxZwTW/XI/xOpd7l3lllQs/qX0WpilLMIZyhlbJGN/p03PUN4jVCZ9oRi2Po
 r6z0OPQln1ivBXWOHW/zGLqBQliwYIHLZ73sddLUeWIPxBrHmosY9eIn+98JNA8w/kNzr+Ql
 p1YZqO+4ACu7ZEgAV/XAk2PlZu1BcovxZ7FFXZE0amUN4gLPt/0sfZ3m2ofdrg77u1zpcOYv
 NFeE/hs9s9nE2ydkxxENMGVhNU7KHyD2FLfVwL4MWNXV8MxGGT0FirMI1KHGN8mVXHs66PTY
 tSIi2vmfHb0b186XZaONan2lAvZULp0sLsaYnYk6+J7IC3EmLWG4QSr5hPrC6ng8Sn++wY=
IronPort-HdrOrdr: A9a23:FkSpfqODmAjYmcBcTsGjsMiBIKoaSvp037Eqv3oedfVwSL39qy
 nOpoV/6faaslsssR0b9exofZPwJk80lqQFg7X5X43DYOCOggLBR+tfBMnZsl7d8kXFh4hgPM
 xbEpSWZueeMWRH
X-IronPort-AV: E=Sophos;i="5.90,136,1643691600"; 
   d="scan'208";a="64988098"
Date: Fri, 25 Feb 2022 13:08:08 +0000
From: Anthony PERARD <anthony.perard@citrix.com>
To: Jane Malalane <jane.malalane@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>, "Juergen
 Gross" <jgross@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>, "George
 Dunlap" <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, "Julien
 Grall" <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Bertrand Marquis
	<bertrand.marquis@arm.com>, Jun Nakajima <jun.nakajima@intel.com>, Kevin Tian
	<kevin.tian@intel.com>, Roger Pau =?iso-8859-1?Q?Monn=E9?=
	<roger.pau@citrix.com>
Subject: Re: [PATCH v3 1/2] xen+tools: Report Interrupt Controller
 Virtualization capabilities on x86
Message-ID: <YhjUuEIKs016T4yx@perard.uk.xensource.com>
References: <20220218172943.12182-1-jane.malalane@citrix.com>
 <20220218172943.12182-2-jane.malalane@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220218172943.12182-2-jane.malalane@citrix.com>

On Fri, Feb 18, 2022 at 05:29:42PM +0000, Jane Malalane wrote:
> Add XEN_SYSCTL_PHYSCAP_ARCH_ASSISTED_xapic and
> XEN_SYSCTL_PHYSCAP_ARCH_ASSISTED_x2apic to report accelerated xapic
> and x2apic, on x86 hardware.
> No such features are currently implemented on AMD hardware.
> 
> For that purpose, also add an arch-specific "capabilities" parameter
> to struct xen_sysctl_physinfo.
> 
> Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Signed-off-by: Jane Malalane <jane.malalane@citrix.com>
> ---
> diff --git a/tools/include/libxl.h b/tools/include/libxl.h
> index 51a9b6cfac..333ffad38d 100644
> --- a/tools/include/libxl.h
> +++ b/tools/include/libxl.h
> @@ -528,6 +528,13 @@
>  #define LIBXL_HAVE_MAX_GRANT_VERSION 1
>  
>  /*
> + * LIBXL_HAVE_PHYSINFO_ASSISTED_APIC indicates that libxl_physinfo has
> + * cap_assisted_x{2}apic fields, which indicates the availability of x{2}APIC

I think I'd rather have both cap_assisted_xapic and cap_assisted_x2apic
spelled out in the comment as that would allow to grep for both string.

> + * hardware assisted virtualization.
> + */
> +#define LIBXL_HAVE_PHYSINFO_ASSISTED_APIC 1


Otherwise, tools/ side looks good.

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Fri Feb 25 13:14:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 13:14:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279085.476624 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNaQ3-0005DZ-4g; Fri, 25 Feb 2022 13:13:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279085.476624; Fri, 25 Feb 2022 13:13:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNaQ2-0005DS-W0; Fri, 25 Feb 2022 13:13:58 +0000
Received: by outflank-mailman (input) for mailman id 279085;
 Fri, 25 Feb 2022 13:13:57 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=E0Ll=TI=citrix.com=prvs=04808661d=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nNaQ1-0005DJ-SF
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 13:13:57 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c828cb23-963c-11ec-8eb8-a37418f5ba1a;
 Fri, 25 Feb 2022 14:13:55 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c828cb23-963c-11ec-8eb8-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645794835;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=v2qxe5P4S0hcUcJFEXE67qh405OTQnralKQirE0QE3I=;
  b=PGv+Tetzo+dwR7v77MnvdEzQ/06Zcy2g36SM3W959feJ/4mbwVgupQNU
   VXzsRFT+a7iO4LjTu8wueKSpx23Pnkl93YfRdfSZWMWBc4zdbNemfULXy
   8bJsbJIQ0g/9Q1TdvmlhB3Z4lCDYNNMk6nz3bvhE+jhi7f/FsnqzEffR8
   A=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 64880166
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:nkt3Qazwm19eGK5jniN6t+fVxirEfRIJ4+MujC+fZmUNrF6WrkUDx
 2QeWT2PPK7cYmfzc413bt+ypkgHu57dyoA1QAZuqyAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGX9JZS5LwbZj2NYy24XhWWthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 Nplh6KcbQZxH6D1hMsYbBd5D35sP6N70eqSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DNYUDunZm3HfBAOwvW5zrSKTW/95Imjw3g6iiGN6AO
 5pJMWMxMnwsZTVMI3kzNbwEw96Oj3/YcGd5lQLO/qoetj27IAtZj+G2bYu9lsaxbd5Ogk+Sq
 2bC/mL4KhIXLtqSzXyC6H3Eru3SmSL2XqoCGbv+8eRl6HWtwWgUBAwTREGMi/CzgU6jWPpSM
 0URvCEpqMAa+EW1Q/HnUha/oXrCuQQTM/JPF8Uq5QfLzbDbiy6JC25BQjNfZdgOsM4tWSdsx
 lKPh8nuBzFkrPuSU3313rWeoC62OCMVBXQffiJCRgwAi/Hhr5s0lQnnVct4Hei+ididJN3r6
 2nU9m5k3exV1JNVkfXglbzav96yjqr3Yio0viTaZ36K6zx3RZL6dY6m1HGOuJ6sM72lZlWGu
 XEFne2X4+YPEYyBmUSxfQkdIF26z63baWOB2DaDC7Fkrm3woCD7Iei89RkjfB8BDyoSRdP+j
 KY/Uyt17YQbAnalZLQfj2mZW5VzlviI+TgIu5npgjtyjnpZKF7vEMJGPxf4M4XRfK4Ey/BX1
 XCzK5vEMJriIf47pAdavs9EuVPR+ggwxHnIWbfwxAm93LyVaRa9EOlZbQTSN7xktPvc+G05F
 uqz0ePQmn2zt8WkP0HqHXM7dwhWfRDX+7iswyCoSgJzClU/QzxwYxMg6bggZ5Zkj8xoehTgp
 RmAtrtj4AOn3xXvcFzSAlg6Me+Hdcsv/BoTYH13VX71iidLXGpaxPpGH3fBVeJ8r7ILID8dZ
 6RtRvhs9dwUEmWXo2lGNMKlxGGgHTzy7T+z0+OeSGBXV/Zdq8bho7cIoiOHGPEyMxeK
IronPort-HdrOrdr: A9a23:rKYDnKkvM1UiWmRIRSXRFwLR4jLpDfLW3DAbv31ZSRFFG/Fw9/
 rCoB3U73/JYVcqKRUdcLW7UpVoLkmyyXcY2+cs1NSZLWzbUQmTXeJfBOLZqlWNJ8SXzIVgPM
 xbAspD4bPLbGSTjazBkXSF+9RL+qj6zEh/792usEuETmtRGt9dBx8SMHf9LqXvLjM2fqbQEv
 Cnl6x6jgvlQ1s7ROKhCEIIWuDSzue77q4PMXY9dmcaABDlt0LR1ILH
X-IronPort-AV: E=Sophos;i="5.90,136,1643691600"; 
   d="scan'208";a="64880166"
Date: Fri, 25 Feb 2022 13:13:49 +0000
From: Anthony PERARD <anthony.perard@citrix.com>
To: Jane Malalane <jane.malalane@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>, "Juergen
 Gross" <jgross@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>, "George
 Dunlap" <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, "Julien
 Grall" <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
	Christian Lindig <christian.lindig@citrix.com>, David Scott
	<dave@recoil.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Roger Pau
 =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>
Subject: Re: [PATCH v3 2/2] x86/xen: Allow per-domain usage of hardware
 virtualized APIC
Message-ID: <YhjWDZh3kUq1WSHd@perard.uk.xensource.com>
References: <20220218172943.12182-1-jane.malalane@citrix.com>
 <20220218172943.12182-3-jane.malalane@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220218172943.12182-3-jane.malalane@citrix.com>

On Fri, Feb 18, 2022 at 05:29:43PM +0000, Jane Malalane wrote:
> diff --git a/tools/include/libxl.h b/tools/include/libxl.h
> index 333ffad38d..1c83cae711 100644
> --- a/tools/include/libxl.h
> +++ b/tools/include/libxl.h
> @@ -535,6 +535,13 @@
>  #define LIBXL_HAVE_PHYSINFO_ASSISTED_APIC 1
>  
>  /*
> + * LIBXL_HAVE_ASSISTED_APIC indicates that libxl_domain_build_info has
> + * assisted_x{2}apic fields, for enabling hardware assisted virtualization for

Could you spell out both "assisted_xapic and assisted_x2apic" as that
would allow for grep to find both string.

> + * x{2}apic per domain.
> + */
> +#define LIBXL_HAVE_ASSISTED_APIC 1
> +
> +/*
> diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c
> index 39fdca1b49..ba5b8f433f 100644
> --- a/tools/libs/light/libxl_arm.c
> +++ b/tools/libs/light/libxl_arm.c
> @@ -1384,8 +1384,9 @@ void libxl__arch_domain_create_info_setdefault(libxl__gc *gc,
>      }
>  }
>  
> -void libxl__arch_domain_build_info_setdefault(libxl__gc *gc,
> -                                              libxl_domain_build_info *b_info)
> +int libxl__arch_domain_build_info_setdefault(libxl__gc *gc,
> +                                             libxl_domain_build_info *b_info,
> +                                             const libxl_physinfo *physinfo)
>  {
>      /* ACPI is disabled by default */
>      libxl_defbool_setdefault(&b_info->acpi, false);
> @@ -1399,6 +1400,8 @@ void libxl__arch_domain_build_info_setdefault(libxl__gc *gc,

There is another return in this function, which want to return 0 rather
than void.

>      memset(&b_info->u, '\0', sizeof(b_info->u));
>      b_info->type = LIBXL_DOMAIN_TYPE_INVALID;
>      libxl_domain_build_info_init_type(b_info, LIBXL_DOMAIN_TYPE_PVH);
> +
> +    return 0;
>  }
>  
>  int libxl__arch_passthrough_mode_setdefault(libxl__gc *gc,
> diff --git a/tools/libs/light/libxl_x86.c b/tools/libs/light/libxl_x86.c
> index e0a06ecfe3..c377d13b19 100644
> --- a/tools/libs/light/libxl_x86.c
> +++ b/tools/libs/light/libxl_x86.c
> @@ -819,11 +827,27 @@ void libxl__arch_domain_create_info_setdefault(libxl__gc *gc,
>  {
>  }
>  
> -void libxl__arch_domain_build_info_setdefault(libxl__gc *gc,
> -                                              libxl_domain_build_info *b_info)
> +int libxl__arch_domain_build_info_setdefault(libxl__gc *gc,
> +                                             libxl_domain_build_info *b_info,
> +                                             const libxl_physinfo *physinfo)
>  {
>      libxl_defbool_setdefault(&b_info->acpi, true);
>      libxl_defbool_setdefault(&b_info->arch_x86.msr_relaxed, false);
> +
> +    if (b_info->type != LIBXL_DOMAIN_TYPE_PV) {
> +        libxl_defbool_setdefault(&b_info->arch_x86.assisted_xapic,
> +                             physinfo->cap_assisted_xapic);
> +        libxl_defbool_setdefault(&b_info->arch_x86.assisted_x2apic,
> +                             physinfo->cap_assisted_x2apic);
> +    }
> +
> +    else if (!libxl_defbool_is_default(b_info->arch_x86.assisted_xapic) ||

This "else" needs to be on the same line as the "}" 2 lines above.

> +             !libxl_defbool_is_default(b_info->arch_x86.assisted_x2apic)) {
> +        LOG(ERROR, "Interrupt Controller Virtualization not supported for PV");
> +        return ERROR_INVAL;
> +    }
> +
> +    return 0;

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Fri Feb 25 13:19:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 13:19:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279092.476634 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNaVg-0005uJ-NU; Fri, 25 Feb 2022 13:19:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279092.476634; Fri, 25 Feb 2022 13:19:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNaVg-0005uC-KY; Fri, 25 Feb 2022 13:19:48 +0000
Received: by outflank-mailman (input) for mailman id 279092;
 Fri, 25 Feb 2022 13:19:46 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=RDkG=TI=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nNaVe-0005u6-RG
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 13:19:46 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 97e4ac27-963d-11ec-8539-5f4723681683;
 Fri, 25 Feb 2022 14:19:42 +0100 (CET)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2059.outbound.protection.outlook.com [104.47.13.59]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-9-jx9S3igMPpS0NoM3RsG62g-1; Fri, 25 Feb 2022 14:19:43 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB6830.eurprd04.prod.outlook.com (2603:10a6:803:132::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.25; Fri, 25 Feb
 2022 13:19:41 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.025; Fri, 25 Feb 2022
 13:19:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 97e4ac27-963d-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645795185;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=aN++Ou5EpSV4a6TfcLsWZ6X9vUPYMD3uTVmOZ5boP6U=;
	b=B5LxMU+UO23pWBeHhr+T/IY/xQOlZr00giJU4yuaoOuh2WA6U7zsHS3eLV2/yOkx/r1wrU
	ChcQ7HmkMnHPwqvHXSs3InIi5HNjMMjLN/zzYI34+iGP3GAr+ddCMkaqVfCH4esYwzPB6C
	k5XrXujChD0Z7H0CL5DpDGypxLHtA8M=
X-MC-Unique: jx9S3igMPpS0NoM3RsG62g-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=FBRahlXlXTNKe/wnYXzHSXfPiL4MT4SDa6Exoqw4DfjP9lG9ibxhAmeJDjRrR8Q8mAwirgzpkVkI9rGA+dYXjLAh+pSO+pjNJ1R3VW/vQFDHxh0vI9WtZJHmkhGTYVXC4+hrUW58szlFglWuOu2Bt5oiGu2MRQYJCAaF8dPn7pW/sFqAm1SHKIdKSEZP9itcqaTcqrDnUcJVYsDAbJXGFBkfr1C7hkazwFeepPRwuy4XVrZVNHYQyNsIHZdhbr3keN2ZByy9vsNy5V491paWvZ9tqR63z0z9hITnJBlFO2YMyeeMyFGwjEaDoT3oGQazjbpSFTFOu2BdQ+7KpL/s1Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=4pKluLIw0bhgHTRI9o+lm9WG2x0lqHbv0wNACbT5vRA=;
 b=jawnUa7jQQ4FQIjLayEEnrAbDIwZaAq49guMlkuu1O+9kJo6u5we2cv0kzlnRXzFcKWcQg9SdM3m4IahAvEQr0sMWKvG1Lirnqm2U+NqKQzNOT+7eU95iCI6DFfel2a6tYW2Dk7ar/wSR6aHQKjX3yzK28eGcHAq7YSwRelhKkaN64CX5BDomWlfm4U3muDzrGQTTGx0n2m8ECEe/zFwPL+rs9C9CUfQM4wqLb4nxeOYua8hP6wg0uLKjq5wfmZCpGbW/wtvddsOWXTu6+/dcizFhBEPbjq/ymVeR9s46dsaHbui7aIEDnSmOG/vibgRad5gh2An1yQGlXOnr2mtTA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <bb4b4106-f49d-2b50-1eb9-eb450f6b24fa@suse.com>
Date: Fri, 25 Feb 2022 14:19:39 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: x86/vmx: Don't spuriously crash the domain when INIT is received
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
CC: Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>,
 Jun Nakajima <jun.nakajima@intel.com>, Kevin Tian <kevin.tian@intel.com>,
 Thiner Logoer <logoerthiner1@163.com>,
 =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20220224194853.17774-1-andrew.cooper3@citrix.com>
 <20220224194853.17774-3-andrew.cooper3@citrix.com>
 <12d8b90b-15b0-c094-71e5-35cfdbfe72b4@suse.com>
 <51ef6bd1-bcd9-9a3a-e902-887d42d7dd7e@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <51ef6bd1-bcd9-9a3a-e902-887d42d7dd7e@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: FR3P281CA0072.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:4b::23) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 8e6d96cc-ea01-4188-e608-08d9f8617b64
X-MS-TrafficTypeDiagnostic: VI1PR04MB6830:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB68308AAF3308D795D5588729B33E9@VI1PR04MB6830.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Sj0wUJ15RtcCRUu8RvVLUY3vQo38TOjQcjP6Tt3V9QHpacQeyRvJhpARxokHglx1x1XmpXlOqqKFvJkyCDTZWYA+l3Eyo3f19i6QJdG+qUh5YAMXLrVOq9BfHN2ToKos8ljhAPeSTf8vlU1i6do2c1z5M90bkDrofZhFvwGNe3RdtnsL1XUpYBx1fLUMQlfpV8sDs2/gYcwzelJ7i9QI1hm5DQkghKYwCFVeHG8Kfb65OpC75kMgIs7BrmLKBbn1oYlanraO4Oe28Z4aF8scWFxPclvIXbt2aMD/73f/VOjgAaSwDfPWRLO5InlWM99bo3+UtCpsXa5kC7vtRZKrIY+ky5uSLZxrpHeJoTxHfKC3hh6dPriJLOEw27eaAtngK6HdHxVrPrxG80BrTEg1LlYYn9ayIktdr5944Mp8hpOjTnfNjWh81VSv+XKLyysRqdUDglS19jyLZIbdMkWLV3JMTpe5qqQml65ViCp2siDu//JLykU6Jwqp98om+vRPWsyr+2JWwv0mfQ7+pNlA1uxMZh+J73ps9JurmU4DiDjH0vhNaZbYE1RbXkCKCG/vxm8vxGyjqKnuExwHRHDQ0QgCT9Dq4p/To9qP5kEOX2IBVqnVv/H0JWsmPrRs92GD4iwPfLHuID1xt6wPyzNhya4xsUuYL1OxtIGFDHpASwkwh3W92ES02eKcI1hB1y5me5T/dZ7eVwzDgJK237hrXPHoUfO/ktua2Vrbu6wUNbG1uMSLsoYLRaahKDJ7fBVh
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(38100700002)(83380400001)(86362001)(31696002)(508600001)(31686004)(6486002)(54906003)(6916009)(316002)(66476007)(5660300002)(36756003)(66946007)(66556008)(2616005)(26005)(186003)(4326008)(2906002)(8676002)(6512007)(53546011)(8936002)(6506007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?p4liVpBNUVo+AH5yhzGEOpYAkyXWMPSYYSvSo1AImteyC+KOuAYAcamlqEDc?=
 =?us-ascii?Q?VfIHCqwyZ/G7v3VO19GKfPOAj1vrs71wmIv2XjYPPHtmEQEPhieRPJHkzuTx?=
 =?us-ascii?Q?fpeVaCZ4/fkcjqvh7b/3OVTHZBUlDRsayjMQNt65xxXGH3HrZk1vVB/DgmqU?=
 =?us-ascii?Q?T1ITwbFFX2YcCzWsloUpWnf2bWIjA6SddtS7wjzl5BCkMjm2/22O0+Uw5IJw?=
 =?us-ascii?Q?bPeyGdpZISEhwReueGIuazMjhEtPXoryGqQh/zPusjPSeaj8YQiKEw1bR1hL?=
 =?us-ascii?Q?jpjo0jgqswqWaknIq56wQv5UveOdp4icak9dY8q8QSHhRSqD1ZF4xhzC3aq5?=
 =?us-ascii?Q?xM/NgDAvAKr1YcyrYIiUZqOu4ySi8iIoVrd6u5Ug/ZSHaGMdLm8yJYpI58z8?=
 =?us-ascii?Q?ZfZstsGJFb48f9/jOx8tWF0noCze6H88B98qaxuQ//Iu8XB0ToV09TKj0iRd?=
 =?us-ascii?Q?Ma/JfYPgQ5cga1LEktBZ8Hm++klA/AS915Zc0MG8iZQGfBIVN3Vb/foBIZl+?=
 =?us-ascii?Q?TSsuFTHXJ9mrsMjBiZ5zEKjGcycF4SbiuNBeB9L3JHrK8QGz7k+hPC6eUE9C?=
 =?us-ascii?Q?eksIybOKDuC2ukri7z+FBNT1QFsfBm3t12i7HgMGh+eiNVP0vTlagSUZtzzK?=
 =?us-ascii?Q?w7Mw48aZqcQC3QXauDl0LvNvKBrC7YIp0rxWRfIy0JASWM7Zy0/2D5VoWW12?=
 =?us-ascii?Q?0u4MW9p9npQ6+zNoXGSJRI+ysVklEZIcYO5dgHTxQ7jsXJDLNgMgCKI3P6xp?=
 =?us-ascii?Q?LkSp2FhDjzPR8pK18p8AJ2LzrvCkwgapLrYnKjSQRiFex2iqrKrvwvPpovyG?=
 =?us-ascii?Q?8jiyZs1T+XWuFVWZCpuQtgv8f+JjmJYo8LggcX0ckBGRzuh/vY/k5Yh3n8/I?=
 =?us-ascii?Q?wUWAWKXB6r7SObaAwjuln+J3MS9/WWqur4GfZkLirflhDOPicfoJLyr2svL1?=
 =?us-ascii?Q?jD04cRRtPIY2Z6UBvyFXvzweVToKVbBb0Icd370KcBJ6KdexHcL4lrlvem9Q?=
 =?us-ascii?Q?x2xf4s+w4yiZZVmb2KCVgDEZL5zN2XbfEfg5mTkk3DPWECBWKc/89P1PKroy?=
 =?us-ascii?Q?DygJYTBqvIBcCncJqeT7waMh3GRcc9Ew7mhh2kq5MOogEWtcTybx1YPIqeA1?=
 =?us-ascii?Q?1xrChju4jJYPwl2AmjXKMqSxq2pII2Z3kBLHH/LFkcenxxeL+HilGy2g1yrp?=
 =?us-ascii?Q?FWaTcOCJjTdrmhMSsZunx6+OH+Dhl6m8v32V1EiQWqIgy+uKzaDz9U2QeCfa?=
 =?us-ascii?Q?P0c4OoTN4ZuLX5wwXy7D8Tl/BnIt1LLtsX9vbgrPUR3YvBmh2ui6RVhu03nk?=
 =?us-ascii?Q?C/7GAQ4rajIJkg0B+j3QVFz052APse7s9KZnSDUKiT39C5+yAIg/eB9IHn6o?=
 =?us-ascii?Q?IMNsT2eVhmjtkjbAAdLh1mw6kLFgikAfHU9AlX+4IjkPrz5tHZOlsAnuE5FA?=
 =?us-ascii?Q?BgyUvpJz+H99belryVpOA+qcL23OlZcq4577aq+xstpWYBiXXan3nFDvuW0+?=
 =?us-ascii?Q?DOQhkdamZrjXHxIlfxKtFm7/+pmnhIud8ney2Y+haG6DxXuZYwcqPXnfpmB4?=
 =?us-ascii?Q?CEzOIIIwfvWh+IQweK/RQm1dFyDVou3EU89RHoOFL01ZhE/vJgeI9nV9UvZp?=
 =?us-ascii?Q?X9IY+ByxqaRQdYyM2vwlJfg=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8e6d96cc-ea01-4188-e608-08d9f8617b64
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2022 13:19:41.6768
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pSuww95W//Pl0qVlcwV6AMC1WQUfa+PsdvGJ9ZvLB5voTCufNYXraqfjfuPgejK1d385WLOKvXuOqc121bWB9A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6830

On 25.02.2022 13:28, Andrew Cooper wrote:
> On 25/02/2022 08:44, Jan Beulich wrote:
>> On 24.02.2022 20:48, Andrew Cooper wrote:
>>> In VMX operation, the handling of INIT IPIs is changed.  EXIT_REASON_IN=
IT has
>>> nothing to do with the guest in question, simply signals that an INIT w=
as
>>> received.
>>>
>>> Ignoring the INIT is probably the wrong thing to do, but is helpful for
>>> debugging.  Crashing the domain which happens to be in context is defin=
itely
>>> wrong.  Print an error message and continue.
>>>
>>> Discovered as collateral damage from when an AP triple faults on S3 res=
ume on
>>> Intel TigerLake platforms.
>> I'm afraid I don't follow the scenario, which was (only) outlined in
>> patch 1: Why would the BSP receive INIT in this case?
>=20
> SHUTDOWN is a signal emitted by a core when it can't continue.=C2=A0 Trip=
le
> fault is one cause, but other sources include a double #MC, etc.
>=20
> Some external component, in the PCH I expect, needs to turn this into a
> platform reset, because one malfunctioning core can't.=C2=A0 It is why a
> triple fault on any logical processor brings the whole system down.

I'm afraid this doesn't answer my question. Clearly the system didn't
shut down. Hence I still don't see why the BSP would see INIT in the
first place.

>> And it also cannot be that the INIT was received by the vCPU while runni=
ng on
>> another CPU:
>=20
> It's nothing (really) to do with the vCPU.=C2=A0 INIT is a external signa=
l to
> the (real) APIC, just like NMI/etc.
>=20
> It is the next VMEntry on a CPU which received INIT that suffers a
> VMEntry failure, and the VMEntry failure has nothing to do with the
> contents of the VMCS.
>=20
> Importantly for Xen however, this isn't applicable for scheduling PV
> vCPUs, which is why dom0 wasn't the one that crashed.=C2=A0 This actually
> meant that dom0 was alive an usable, albeit it sharing all vCPUs on a
> single CPU.
>=20
>=20
> The change in INIT behaviour exists for TXT, where is it critical that
> software can clear secrets from RAM before resetting.=C2=A0 I'm not wanti=
ng
> to get into any of that because it's far more complicated than I have
> time to fix.

I guess there's something hidden behind what you say here, like INIT
only being latched, but this latched state then causing the VM entry
failure. Which would mean that really the INIT was a signal for the
system to shut down / shutting down. In which case arranging to
continue by ignoring the event in VMX looks wrong. Simply crashing
the guest would then be wrong as well, of course. We should shut
down instead.

But I don't think I see the full picture here yet, unless your
mentioning of TXT was actually implying that TXT was active at the
point of the crash (which I don't think was said anywhere).

Jan



From xen-devel-bounces@lists.xenproject.org Fri Feb 25 13:27:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 13:27:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279101.476646 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNadP-0007RO-Nb; Fri, 25 Feb 2022 13:27:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279101.476646; Fri, 25 Feb 2022 13:27:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNadP-0007RH-KX; Fri, 25 Feb 2022 13:27:47 +0000
Received: by outflank-mailman (input) for mailman id 279101;
 Fri, 25 Feb 2022 13:27:46 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=d3I2=TI=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nNadO-0007RB-Km
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 13:27:46 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b600a203-963e-11ec-8539-5f4723681683;
 Fri, 25 Feb 2022 14:27:43 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 002D91F380;
 Fri, 25 Feb 2022 13:27:44 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A5A1813BD1;
 Fri, 25 Feb 2022 13:27:44 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 1b4QJ1DZGGJpSgAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 25 Feb 2022 13:27:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b600a203-963e-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1645795665; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=L7Lchxug1wh4lmXVF3m87PVXxFgIAJYCSrECSMUN5os=;
	b=UUUKpeHWOabAXEjbzHQMbygmNE24m0KGF/ddc6HvfQ0vbyK1SdAI0STwOZ2UZzB85gGqdU
	zwQvoGd7ElPo8pFsLuo5+xcF+vcqXtCitFtesLG8OCKjaJZNsfwNFX3Jdrk6fGBZ+vrmBV
	uft8Jx7rmUSKfYf3zY+ygvcwelHbox8=
Message-ID: <919a30bd-be6c-f773-5b90-700966099d19@suse.com>
Date: Fri, 25 Feb 2022 14:27:44 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Content-Language: en-US
To: Jia-Ju Bai <baijiaju1990@gmail.com>, boris.ostrovsky@oracle.com,
 sstabellini@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
 dave.hansen@linux.intel.com, hpa@zytor.com
Cc: x86@kernel.org, xen-devel@lists.xenproject.org,
 linux-kernel@vger.kernel.org
References: <20220225081121.18803-1-baijiaju1990@gmail.com>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH] arch: x86: xen: check the return value of kasprintf()
In-Reply-To: <20220225081121.18803-1-baijiaju1990@gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------oMzV5If1mgGqJO1WZ6RTVtpg"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------oMzV5If1mgGqJO1WZ6RTVtpg
Content-Type: multipart/mixed; boundary="------------DoFSGUDUMXcD7gEdWjdcecyu";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Jia-Ju Bai <baijiaju1990@gmail.com>, boris.ostrovsky@oracle.com,
 sstabellini@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
 dave.hansen@linux.intel.com, hpa@zytor.com
Cc: x86@kernel.org, xen-devel@lists.xenproject.org,
 linux-kernel@vger.kernel.org
Message-ID: <919a30bd-be6c-f773-5b90-700966099d19@suse.com>
Subject: Re: [PATCH] arch: x86: xen: check the return value of kasprintf()
References: <20220225081121.18803-1-baijiaju1990@gmail.com>
In-Reply-To: <20220225081121.18803-1-baijiaju1990@gmail.com>

--------------DoFSGUDUMXcD7gEdWjdcecyu
Content-Type: multipart/mixed; boundary="------------IncJ9dP6aG1DUn6PWvIIt03m"

--------------IncJ9dP6aG1DUn6PWvIIt03m
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMjUuMDIuMjIgMDk6MTEsIEppYS1KdSBCYWkgd3JvdGU6DQo+IFRoZSBmdW5jdGlvbiBr
YXNwcmludGYoKSBjYW4gZmFpbCwgYnV0IHRoZXJlIGlzIG5vIGNoZWNrIG9mIGl0cyByZXR1
cm4NCj4gdmFsdWUuIFRvIGZpeCB0aGlzIGJ1ZywgaXRzIHJldHVybiB2YWx1ZSBzaG91bGQg
YmUgY2hlY2tlZCB3aXRoIG5ldw0KPiBlcnJvciBoYW5kbGluZyBjb2RlLg0KPiANCj4gRml4
ZXM6IGY4N2U0Y2FjNGY0ZSAoInhlbjogU01QIGd1ZXN0IHN1cHBvcnQiKQ0KPiBGaXhlczog
ODNiOTY3OTRlMGVhICgieDg2L3hlbjogc3BsaXQgb2ZmIHNtcF9wdi5jIikNCj4gRml4ZXM6
IGQ1ZGU4ODQxMzU1YSAoIng4Njogc3BsaXQgc3BpbmxvY2sgaW1wbGVtZW50YXRpb25zIG91
dCBpbnRvIHRoZWlyIG93biBmaWxlcyIpDQo+IFJlcG9ydGVkLWJ5OiBUT1RFIFJvYm90IDxv
c2xhYkB0c2luZ2h1YS5lZHUuY24+DQo+IFNpZ25lZC1vZmYtYnk6IEppYS1KdSBCYWkgPGJh
aWppYWp1MTk5MEBnbWFpbC5jb20+DQo+IC0tLQ0KPiAgIGFyY2gveDg2L3hlbi9zbXAuYyAg
ICAgIHwgMiArKw0KPiAgIGFyY2gveDg2L3hlbi9zbXBfcHYuYyAgIHwgMiArKw0KPiAgIGFy
Y2gveDg2L3hlbi9zcGlubG9jay5jIHwgMiArKw0KPiAgIDMgZmlsZXMgY2hhbmdlZCwgNiBp
bnNlcnRpb25zKCspDQo+IA0KPiBkaWZmIC0tZ2l0IGEvYXJjaC94ODYveGVuL3NtcC5jIGIv
YXJjaC94ODYveGVuL3NtcC5jDQo+IGluZGV4IGMzZTFmOWE3ZDQzYS4uOTEyNjEzOTBmOGMw
IDEwMDY0NA0KPiAtLS0gYS9hcmNoL3g4Ni94ZW4vc21wLmMNCj4gKysrIGIvYXJjaC94ODYv
eGVuL3NtcC5jDQo+IEBAIC02NSw2ICs2NSw4IEBAIGludCB4ZW5fc21wX2ludHJfaW5pdCh1
bnNpZ25lZCBpbnQgY3B1KQ0KPiAgIAljaGFyICpyZXNjaGVkX25hbWUsICpjYWxsZnVuY19u
YW1lLCAqZGVidWdfbmFtZTsNCj4gICANCj4gICAJcmVzY2hlZF9uYW1lID0ga2FzcHJpbnRm
KEdGUF9LRVJORUwsICJyZXNjaGVkJWQiLCBjcHUpOw0KPiArCWlmICghcmVzY2hlZF9uYW1l
KQ0KPiArCQlyZXR1cm4gLUVOT01FTTsNCg0KVGhlcmUgYXJlIDMgbW9yZSBpbnN0YW5jZXMg
b2Yga2FzcHJpbnRmKCkgaW4gdGhpcyBmdW5jdGlvbi4NCg0KPiAgIAlyYyA9IGJpbmRfaXBp
X3RvX2lycWhhbmRsZXIoWEVOX1JFU0NIRURVTEVfVkVDVE9SLA0KPiAgIAkJCQkgICAgY3B1
LA0KPiAgIAkJCQkgICAgeGVuX3Jlc2NoZWR1bGVfaW50ZXJydXB0LA0KPiBkaWZmIC0tZ2l0
IGEvYXJjaC94ODYveGVuL3NtcF9wdi5jIGIvYXJjaC94ODYveGVuL3NtcF9wdi5jDQo+IGlu
ZGV4IDRhNjAxOTIzOGVlNy4uN2QxNDcxZmQxMjY3IDEwMDY0NA0KPiAtLS0gYS9hcmNoL3g4
Ni94ZW4vc21wX3B2LmMNCj4gKysrIGIvYXJjaC94ODYveGVuL3NtcF9wdi5jDQo+IEBAIC0x
MTgsNiArMTE4LDggQEAgaW50IHhlbl9zbXBfaW50cl9pbml0X3B2KHVuc2lnbmVkIGludCBj
cHUpDQo+ICAgCWNoYXIgKmNhbGxmdW5jX25hbWUsICpwbXVfbmFtZTsNCj4gICANCj4gICAJ
Y2FsbGZ1bmNfbmFtZSA9IGthc3ByaW50ZihHRlBfS0VSTkVMLCAiaXJxd29yayVkIiwgY3B1
KTsNCj4gKwlpZiAoIWNhbGxmdW5jX25hbWUpDQo+ICsJCXJldHVybiAtRU5PTUVNOw0KDQpB
bmQgaW4gaGVyZSBpcyBhbm90aGVyIG9uZSwgdG9vLg0KDQo+ICAgCXJjID0gYmluZF9pcGlf
dG9faXJxaGFuZGxlcihYRU5fSVJRX1dPUktfVkVDVE9SLA0KPiAgIAkJCQkgICAgY3B1LA0K
PiAgIAkJCQkgICAgeGVuX2lycV93b3JrX2ludGVycnVwdCwNCj4gZGlmZiAtLWdpdCBhL2Fy
Y2gveDg2L3hlbi9zcGlubG9jay5jIGIvYXJjaC94ODYveGVuL3NwaW5sb2NrLmMNCj4gaW5k
ZXggMDQzYzczZGZkMmM5Li5jY2RiOWVkZGQ5M2IgMTAwNjQ0DQo+IC0tLSBhL2FyY2gveDg2
L3hlbi9zcGlubG9jay5jDQo+ICsrKyBiL2FyY2gveDg2L3hlbi9zcGlubG9jay5jDQo+IEBA
IC03NSw2ICs3NSw4IEBAIHZvaWQgeGVuX2luaXRfbG9ja19jcHUoaW50IGNwdSkNCj4gICAJ
ICAgICBjcHUsIHBlcl9jcHUobG9ja19raWNrZXJfaXJxLCBjcHUpKTsNCj4gICANCj4gICAJ
bmFtZSA9IGthc3ByaW50ZihHRlBfS0VSTkVMLCAic3BpbmxvY2slZCIsIGNwdSk7DQo+ICsJ
aWYgKCFuYW1lKQ0KPiArCQlyZXR1cm47DQoNCkp1c3QgZmFpbGluZyBzaWxlbnRseSBpcyBu
b3QgbmljZS4NCg0KPiAgIAlpcnEgPSBiaW5kX2lwaV90b19pcnFoYW5kbGVyKFhFTl9TUElO
X1VOTE9DS19WRUNUT1IsDQo+ICAgCQkJCSAgICAgY3B1LA0KPiAgIAkJCQkgICAgIGR1bW15
X2hhbmRsZXIsDQoNCg0KSnVlcmdlbg0K
--------------IncJ9dP6aG1DUn6PWvIIt03m
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------IncJ9dP6aG1DUn6PWvIIt03m--

--------------DoFSGUDUMXcD7gEdWjdcecyu--

--------------oMzV5If1mgGqJO1WZ6RTVtpg
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmIY2VAFAwAAAAAACgkQsN6d1ii/Ey+L
tQgAiS8darJWTHfNev/ftsWvgYnsIh6/d3XQKL12qjTv3w7t/SDgCn7dUVehgkjnkaX+fF4JPL8t
oX+sA2PbWaVbJ824FUynH8gUA103TCoWIn/YYxyxhXy60FDdO66Dc0TtY7iNVEoqP1Ob9jiM8AmW
J7FYQiv5QUKhXnRhq4NzEgKrueeawiUqz/wIyuZNSPBcWC5meXNfA1GML0SQOHscaCLXjdqKoBWX
rqpXayiTL2ZJiay/vxdRny1gXtYzFgp1OEENeozGfGQJHFWsT4hDjfYWiMnM9TTmHtdDVr08hna3
P6Ygcdg4aawTZafc4VxW0/6JiPEGjI6BXnAirtj3bw==
=w7n2
-----END PGP SIGNATURE-----

--------------oMzV5If1mgGqJO1WZ6RTVtpg--


From xen-devel-bounces@lists.xenproject.org Fri Feb 25 13:50:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 13:50:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279108.476656 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNaz6-0002CV-HV; Fri, 25 Feb 2022 13:50:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279108.476656; Fri, 25 Feb 2022 13:50:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNaz6-0002CO-ES; Fri, 25 Feb 2022 13:50:12 +0000
Received: by outflank-mailman (input) for mailman id 279108;
 Fri, 25 Feb 2022 13:50:11 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HXke=TI=gmail.com=this.is.a0lson@srs-se1.protection.inumbo.net>)
 id 1nNaz5-0002CI-Cc
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 13:50:11 +0000
Received: from mail-ot1-x32b.google.com (mail-ot1-x32b.google.com
 [2607:f8b0:4864:20::32b])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d8dd2a43-9641-11ec-8eb9-a37418f5ba1a;
 Fri, 25 Feb 2022 14:50:10 +0100 (CET)
Received: by mail-ot1-x32b.google.com with SMTP id
 l21-20020a056830239500b005afd2a7eaa2so796785ots.9
 for <xen-devel@lists.xenproject.org>; Fri, 25 Feb 2022 05:50:10 -0800 (PST)
Received: from development (c-73-166-253-254.hsd1.tx.comcast.net.
 [73.166.253.254]) by smtp.gmail.com with ESMTPSA id
 g35-20020a9d2da6000000b005af5fb99326sm1103832otb.63.2022.02.25.05.50.07
 for <xen-devel@lists.xenproject.org>
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 25 Feb 2022 05:50:08 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d8dd2a43-9641-11ec-8eb9-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=message-id:subject:from:to:date:user-agent:mime-version
         :content-transfer-encoding;
        bh=q/Ah4dHPOKbUhA6A/cbpacuPbQDLPxgHP9W7TYvNxO4=;
        b=I+YwrSCUubK6TwfuqKTMOyXzna72jSIMa5qCeF23OM1AWO8Jqo2nEFI0pDc5WPmQVQ
         /WpQ04q5YHZ9lkaDgEkhvmqqYtZT1zcD45DUvkR/vduI7jp0CvG6wnIQhyNoyoT0Kxk/
         piu0Rzl+ejAbByDeIAH4yhvqHosuI/xIG7ZW6HynUU63+TTNoVA3fYhmYudrW9vUUlkz
         LfgKCqFRzeA30z2H0P7Pj1RlawozhTW2lOj9oHPwNNKXJUIwFN+MaSZmN1wvXqIzbpep
         rQAzTG96WwsjnJBDoeAOvuJeJwShxmvopJj3cYZZzVy1UvSkE64ga+4lktpZ2GDfwzOq
         gysg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:message-id:subject:from:to:date:user-agent
         :mime-version:content-transfer-encoding;
        bh=q/Ah4dHPOKbUhA6A/cbpacuPbQDLPxgHP9W7TYvNxO4=;
        b=MVSn8EB0tdRWfhvKAYoywdVY27Jg3zlXN5Y0PpqdPpDZPzTMZmL5ZMpgsWzRDB+D3h
         ONQNyGWRtm53uezvpUhxCobD4DNL8HNHqgV4F33njlHr3351COOPB/0kEc5WjvUTYU/q
         DoAoVsOLXI47wmWoz40kwIvy6Y3XOOW94sdJ1CTZV0IIgIsas9/F/eGIX9jmW8H+q7mD
         5g8mzqqiObBqVa9ZxAfiINcd53MT00Neor9/h6TcJhGFJuS5zg33kwPeLGOtwYzCqJrZ
         rM9gRyH7Bd2q0b3AUwybSCU3X66aF1H7PlAx17GEQTx5teM8jxvZ+xjOxm2eLwHj6NcO
         Df7Q==
X-Gm-Message-State: AOAM5324TpSw39Oav6nqxZX+kxe2wPs7ai2c62BxiPJ/zTHFTRbK74y6
	BVMSgs+P+xRkjkoRwyWe9SS7CBktZX/DAg==
X-Google-Smtp-Source: ABdhPJxwvx5YPsbGzRHZeNUtMai/YHLGSHM9VRr6/EhRvbQEU/VgAYGNsR/IUOO0o7Gpxx7FAAr3Tw==
X-Received: by 2002:a05:6830:b92:b0:5af:44c9:f115 with SMTP id a18-20020a0568300b9200b005af44c9f115mr2792357otv.24.1645797008966;
        Fri, 25 Feb 2022 05:50:08 -0800 (PST)
Message-ID: <c33d1731b054a488974f96b8171b7b1b5aa61b4a.camel@gmail.com>
Subject: PVH dom0 and MSIX memory mapping issue
From: Alex Olson <this.is.a0lson@gmail.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Date: Fri, 25 Feb 2022 07:50:06 -0600
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.36.5-0ubuntu1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit

I realize PVH for dom0 is still experimental, but was trying to see how well it
works in the state of "master".

I found one issue with MSI-X interrupts in dom0 -- a fatal page fault occurs
when the MSI-X PBA is accessed from dom0.  It looks like dom0 doesn't have an
identity mapping for the PBA of a PCI device --  intentionally caused by
vpci_make_msix_hole() ?   

I was also wondering, what is the impact of "existing mapping (...) at 0
clobbers MSIX MMIO area".

Is the purpose of vpci_make_msix_hole() to make MSIX table/PBA accesses trap to
the hypervisor?  Seems like the page-based granularity is too coarse since the
PBA can be much smaller than a page as well as not aligned... 

I was able to get something potentially usable by adding a "ioremap" call in
 msix_read() and msix_write to deal with the access of the PBA.  Wasn't sure if
this was a proper way of handling things...  Was also wondering if it would make
sense to do the same for the "clobbers MSIX MMIO area" cases too.

Thanks

-Alex





From xen-devel-bounces@lists.xenproject.org Fri Feb 25 13:51:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 13:51:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279114.476668 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNb0W-0002lb-Tc; Fri, 25 Feb 2022 13:51:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279114.476668; Fri, 25 Feb 2022 13:51:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNb0W-0002lU-Pb; Fri, 25 Feb 2022 13:51:40 +0000
Received: by outflank-mailman (input) for mailman id 279114;
 Fri, 25 Feb 2022 13:51:39 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=DRUi=TI=invisiblethingslab.com=marmarek@srs-se1.protection.inumbo.net>)
 id 1nNb0V-0002lF-KN
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 13:51:39 +0000
Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com
 [64.147.123.25]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0b2a4834-9642-11ec-8eb9-a37418f5ba1a;
 Fri, 25 Feb 2022 14:51:37 +0100 (CET)
Received: from compute5.internal (compute5.nyi.internal [10.202.2.45])
 by mailout.west.internal (Postfix) with ESMTP id 713613202057;
 Fri, 25 Feb 2022 08:51:32 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163])
 by compute5.internal (MEProxy); Fri, 25 Feb 2022 08:51:33 -0500
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri,
 25 Feb 2022 08:51:30 -0500 (EST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0b2a4834-9642-11ec-8eb9-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-type:date:date:from:from
	:in-reply-to:in-reply-to:message-id:mime-version:references
	:reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy
	:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=RNgi6dy3JhQ0xZoCo
	wrrqyZIHuYhjGwar6kGMWcvlnQ=; b=DEeAjnbvs/QOeMWuGemMvCxRmXfbbR5ED
	ul0pYSUWM44ht/XfUn0x0fsyDyxx7JxKqOh65dZIB6rwjPwM2U5RwPt+yaO4Q5Nr
	Zu0TVkWCUownsZSPhM5UL6QZDQQzhvfj9XIaOWI2D1qNuZAtAfNLBs/4uNfUw10X
	2k8Il3qkd3RUW6cnQgIyCbuyq+GI1c7X+j8ZqUQDaL3IPGOwGgAr7TNuB/WvQjBX
	vnTNvVOIGcUfJRxar6XEW7lFHYCb9xsX4h1at4DX2XzcDl92SWyc6jD8SVSoWFQe
	JowD29AVKqJ2IHPB1W+L7KBHTVg+t397+5Uw2b2jMNSgSP99cz7DQ==
X-ME-Sender: <xms:494YYv_isixrR4lYA9ELKsHiTUIX-QieTu-85t1ueC3RbioGBmN4vQ>
    <xme:494YYrvcJW3DssEvVVcPNKUtFEH1k1eXV_7fFdckCk4MnIWSKuqFMgq6sf0LSXORc
    MXePUZtULQ40A>
X-ME-Received: <xmr:494YYtBVMxtuB9ZsxfdDLdlxcEGK2lrNFQYFkRQRKyXVfSRBnkJJBVAsFoR4FytGsgVnJtmbHH8i5lN7zJfbKLxnnrFh5x0KBA>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrleeggdehjecutefuodetggdotefrodftvf
    curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
    uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
    fjughrpeffhffvuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrrhgvkhcu
    ofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinhhvih
    hsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepteevffei
    gffhkefhgfegfeffhfegveeikeettdfhheevieehieeitddugeefteffnecuvehluhhsth
    gvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghrvghksehi
    nhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh
X-ME-Proxy: <xmx:494YYrfVl3Tzmx9wJq4jrkS3JKfehVBGc5SxJc0lNA0WRcEvFcIYyw>
    <xmx:494YYkMtoAHvcpLaxk1X9-HVSlBL-7pzQ5fnn0-q-SOe4-MFyh-_Bw>
    <xmx:494YYtkTiO7uiL8A8MnWHziUhJGJGOQVWQKA5SFQOwUND-_2ncX5hA>
    <xmx:5N4YYj0JVHDEPp5z3LlSt14BxP6CcpvOCpi-3n8V9DLK3B3v0No2lw>
Date: Fri, 25 Feb 2022 14:51:28 +0100
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <Andrew.Cooper3@citrix.com>,
	Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>,
	Jun Nakajima <jun.nakajima@intel.com>,
	Kevin Tian <kevin.tian@intel.com>,
	Thiner Logoer <logoerthiner1@163.com>,
	Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: x86/vmx: Don't spuriously crash the domain when INIT is received
Message-ID: <Yhje4LFNt+RQJ5E0@mail-itl>
References: <20220224194853.17774-1-andrew.cooper3@citrix.com>
 <20220224194853.17774-3-andrew.cooper3@citrix.com>
 <12d8b90b-15b0-c094-71e5-35cfdbfe72b4@suse.com>
 <51ef6bd1-bcd9-9a3a-e902-887d42d7dd7e@citrix.com>
 <bb4b4106-f49d-2b50-1eb9-eb450f6b24fa@suse.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="LvOjtPaHYJSux8fC"
Content-Disposition: inline
In-Reply-To: <bb4b4106-f49d-2b50-1eb9-eb450f6b24fa@suse.com>


--LvOjtPaHYJSux8fC
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Fri, 25 Feb 2022 14:51:28 +0100
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <Andrew.Cooper3@citrix.com>,
	Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>,
	Jun Nakajima <jun.nakajima@intel.com>,
	Kevin Tian <kevin.tian@intel.com>,
	Thiner Logoer <logoerthiner1@163.com>,
	Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: x86/vmx: Don't spuriously crash the domain when INIT is received

On Fri, Feb 25, 2022 at 02:19:39PM +0100, Jan Beulich wrote:
> On 25.02.2022 13:28, Andrew Cooper wrote:
> > On 25/02/2022 08:44, Jan Beulich wrote:
> >> On 24.02.2022 20:48, Andrew Cooper wrote:
> >>> In VMX operation, the handling of INIT IPIs is changed.  EXIT_REASON_=
INIT has
> >>> nothing to do with the guest in question, simply signals that an INIT=
 was
> >>> received.
> >>>
> >>> Ignoring the INIT is probably the wrong thing to do, but is helpful f=
or
> >>> debugging.  Crashing the domain which happens to be in context is def=
initely
> >>> wrong.  Print an error message and continue.
> >>>
> >>> Discovered as collateral damage from when an AP triple faults on S3 r=
esume on
> >>> Intel TigerLake platforms.
> >> I'm afraid I don't follow the scenario, which was (only) outlined in
> >> patch 1: Why would the BSP receive INIT in this case?
> >=20
> > SHUTDOWN is a signal emitted by a core when it can't continue.=C2=A0 Tr=
iple
> > fault is one cause, but other sources include a double #MC, etc.
> >=20
> > Some external component, in the PCH I expect, needs to turn this into a
> > platform reset, because one malfunctioning core can't.=C2=A0 It is why a
> > triple fault on any logical processor brings the whole system down.
>=20
> I'm afraid this doesn't answer my question. Clearly the system didn't
> shut down. Hence I still don't see why the BSP would see INIT in the
> first place.
>=20
> >> And it also cannot be that the INIT was received by the vCPU while run=
ning on
> >> another CPU:
> >=20
> > It's nothing (really) to do with the vCPU.=C2=A0 INIT is a external sig=
nal to
> > the (real) APIC, just like NMI/etc.
> >=20
> > It is the next VMEntry on a CPU which received INIT that suffers a
> > VMEntry failure, and the VMEntry failure has nothing to do with the
> > contents of the VMCS.
> >=20
> > Importantly for Xen however, this isn't applicable for scheduling PV
> > vCPUs, which is why dom0 wasn't the one that crashed.=C2=A0 This actual=
ly
> > meant that dom0 was alive an usable, albeit it sharing all vCPUs on a
> > single CPU.
> >=20
> >=20
> > The change in INIT behaviour exists for TXT, where is it critical that
> > software can clear secrets from RAM before resetting.=C2=A0 I'm not wan=
ting
> > to get into any of that because it's far more complicated than I have
> > time to fix.
>=20
> I guess there's something hidden behind what you say here, like INIT
> only being latched, but this latched state then causing the VM entry
> failure. Which would mean that really the INIT was a signal for the
> system to shut down / shutting down. In which case arranging to
> continue by ignoring the event in VMX looks wrong. Simply crashing
> the guest would then be wrong as well, of course. We should shut
> down instead.

A shutdown could be an alternative here, with remark that it would make
debugging such issues significantly harder. Note the INIT is delivered
to BSP, but the actual reason (in this case) is on some AP. Shutdown
(crash) in this case would prevent (still functioning) BSP to show you
the message (unless you have serial console, which is rather rare in
laptops - which are significant target for Qubes OS).

> But I don't think I see the full picture here yet, unless your
> mentioning of TXT was actually implying that TXT was active at the
> point of the crash (which I don't think was said anywhere).

No, TXT wasn't (intentionally) active. I think Andrew mentioned it as
explanation why VMX behaves this way: to let the OS do something _if_ TXT
is active (the check for TXT is the OS responsibility here). But that's
my guess only...

--=20
Best Regards,
Marek Marczykowski-G=C3=B3recki
Invisible Things Lab

--LvOjtPaHYJSux8fC
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmIY3uAACgkQ24/THMrX
1yzoxwf/VV/bSEByAwaA8ZfFTzSwEnX0ecC28fSsVvqK0yZZjs8iFOBRAkmZiRFx
1h4a1SEvc6KuaHx8UCgItD0t20ylVwjDy7NE1jKEVdDDed+QREZetnkLDzicYct4
XdTgIN70+G+n6Rs9rLNwTgwX4EVskjAjiW74iTSgh2Wo1+dd4Ow7zE41+HCJccgy
DSmuONtou4Kzm2pd0bSAyyeVdsau1lDWnYKyqfcXE67f1SINYwwORMaQo2xSx+m4
x4zSo2T2bvStHL0Mq5DJPyieQgKmm7p+UHXpn4ZEYacRRt0XaXc+z7MulifSYClb
yfADBRV7YMTuLi8DKj2RjYU++YDkug==
=l1l9
-----END PGP SIGNATURE-----

--LvOjtPaHYJSux8fC--


From xen-devel-bounces@lists.xenproject.org Fri Feb 25 14:09:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 14:09:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279122.476679 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNbHS-0004Tt-DK; Fri, 25 Feb 2022 14:09:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279122.476679; Fri, 25 Feb 2022 14:09:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNbHS-0004Tm-9H; Fri, 25 Feb 2022 14:09:10 +0000
Received: by outflank-mailman (input) for mailman id 279122;
 Fri, 25 Feb 2022 14:09:08 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=d3I2=TI=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nNbHQ-0004Te-9C
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 14:09:08 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7e5d2d71-9644-11ec-8eb9-a37418f5ba1a;
 Fri, 25 Feb 2022 15:09:06 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 0304E1F38B;
 Fri, 25 Feb 2022 14:09:06 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id DBDB013BE6;
 Fri, 25 Feb 2022 14:09:05 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id KzRcNAHjGGLIXgAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 25 Feb 2022 14:09:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7e5d2d71-9644-11ec-8eb9-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1645798146; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=E6JzscrfvjSDBwdZnpXujsEETbxz2T4zIpCYvRb6+qo=;
	b=Rfv+9BG7yUEzVrXTny0g3wY3EuxK0In5UVXt9UT1nuaBFQZ1XMHvuqVUk+ltaS/5m7p5Rs
	ayEf+L+xPu4WIPzhOGSUjLaOTlfogmW6P6WA3403ZGX/6pnwqKCLWW2VsM19kjS5ymog1j
	o+hXbDpBmXzlJ4cQEwiLcvcARfcpk9E=
Message-ID: <d89c0991-b437-31c3-8432-281c3fa24c41@suse.com>
Date: Fri, 25 Feb 2022 15:09:05 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Content-Language: en-US
To: James Dingwall <james-xen@dingwall.me.uk>, xen-devel@lists.xenproject.org
References: <20220223180859.GA1412216@dingwall.me.uk>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [RFC] kernel: xenfs parameter to hide deprecated files
In-Reply-To: <20220223180859.GA1412216@dingwall.me.uk>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------1oylJZz3Ri82TsAanZ0cP0jd"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------1oylJZz3Ri82TsAanZ0cP0jd
Content-Type: multipart/mixed; boundary="------------Taz6Er9V87gXq4GGMVSXjlwF";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: James Dingwall <james-xen@dingwall.me.uk>, xen-devel@lists.xenproject.org
Message-ID: <d89c0991-b437-31c3-8432-281c3fa24c41@suse.com>
Subject: Re: [RFC] kernel: xenfs parameter to hide deprecated files
References: <20220223180859.GA1412216@dingwall.me.uk>
In-Reply-To: <20220223180859.GA1412216@dingwall.me.uk>

--------------Taz6Er9V87gXq4GGMVSXjlwF
Content-Type: multipart/mixed; boundary="------------bMs6IAiJ0qHlQ232Gl000Eri"

--------------bMs6IAiJ0qHlQ232Gl000Eri
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMjMuMDIuMjIgMTk6MDgsIEphbWVzIERpbmd3YWxsIHdyb3RlOg0KPiBIaSwNCj4gDQo+
IEkgaGF2ZSBiZWVuIGludmVzdGlnYXRpbmcgYSB2ZXJ5IGludGVybWl0dGVudCBpc3N1ZSB3
ZSBoYXZlIHdpdGggeGVuc3RvcmUNCj4gYWNjZXNzIGhhbmdpbmcuICBUeXBpY2FsbHkgaXQg
c2VlbXMgdG8gaGFwcGVuIHdoZW4gYWxsIGRvbWFpbnMgYXJlIHN0b3BwZWQNCj4gcHJpb3Ig
dG8gYSBzeXN0ZW0gcmVib290LiAgeGVuc3RvcmUgaXMgcnVubmluZyBpbiBhIHN0dWJkb20g
YW5kIHVzaW5nIHRoZQ0KPiBoeXBlcnZpc29yIGRlYnVnIGtleXMgaW5kaWNhdGVzIHRoZSBk
b21haW4gaXMgc3RpbGwgdGhlcmUuDQoNCkNvdWxkIGl0IGJlIGRvbTAgc2h1dGRvd24gaGFu
ZGxpbmcgaXMgdW5sb2FkaW5nIHNvbWUgbW9kdWxlcyB3aGljaCBhcmUNCm5lZWRlZCBmb3Ig
WGVuc3RvcmUgY29tbXVuaWNhdGlvbj8gRS5nLiB4ZW4tZXZ0Y2huPw0KDQo+IA0KPiBJIGhh
dmUgY29tZSBhY3Jvc3Mgc29tZSBvbGQgbGlzdCB0aHJlYWRzIHdoaWNoIHN1Z2dlc3RlZCBh
Y2Nlc3MgdmlhDQo+IC9wcm9jL3hlbi94ZW5idXMgY291bGQgY2F1c2UgcHJvYmxlbXMgYnV0
IGl0IHNlZW1zIHBhdGNoZXMgd2VudCBpbiB0byB0aGUNCj4ga2VybmVsIGZvciA0LjEwLiAg
SG93ZXZlciB0byBlbGltaW5hdGUgdGhpcyBlbnRpcmVseSBhcyBhIHBvc3NpYmlsaXR5DQo+
IEkgY2FtZSB1cCB3aXRoIHRoaXMga2VybmVsIHBhdGNoIHRvIGhpZGUgZGVwcmVjYXRlZCBl
bnRyaWVzIGluIHhlbmZzLg0KDQpJIGRvbid0IHNlZSBob3cgdGhpcyBwYXRjaCBjb3VsZCBo
ZWxwLg0KDQpsaWJ4ZW5zdG9yZSBpcyB1c2luZyAvZGV2L3hlbi94ZW5idXMgaWYgaXQgaXMg
YXZhaWxhYmxlLiBTbyB0aGUgb25seQ0KY2FzZSB3aGVyZSB5b3VyIHBhdGNoIHdvdWxkIGF2
b2lkIGFjY2Vzc2luZyAvcHJvYy94ZW4veGVuYnVzIHdvdWxkIGJlDQppZiAvZGV2L3hlbi94
ZW5idXMgaXNuJ3QgdGhlcmUuIEJ1dCB0aGlzIHdvdWxkbid0IG1ha2UgWGVuc3RvcmUgbW9y
ZQ0KcmVhY3RpdmUsIEkgZ3Vlc3MuIDstKQ0KDQo+IEkgZm91bmQgdGhpcyBvbGQgdGhyZWFk
IGZvciBhIHNpbWlsYXIgY2hhbmdlIHdoZXJlIHRoZSBlbnRyaWVzIHdlcmUgbWFkZQ0KPiBj
b25kaXRpb25hbCBvbiBrZXJuZWwgY29uZmlnIG9wdGlvbnMgaW5zdGVhZCBvZiBhIG1vZHVs
ZSBwYXJhbWV0ZXIgYnV0DQo+IHRoaXMgd2FzIG5ldmVyIG1lcmdlZC4NCj4gDQo+IGh0dHBz
Oi8vbGttbC5vcmcvbGttbC8yMDE1LzExLzMwLzc2MQ0KPiANCj4gSWYgdGhpcyB3b3VsZCBi
ZSBhIHVzZWZ1bCBmZWF0dXJlIEkgd291bGQgd2VsY29tZSBmZWVkYmFjay4NCg0KSSdtIG5v
dCBzdXJlIGhvdyBoZWxwZnVsIGl0IGlzIHRvIGxldCB0aGUgdXNlciBzcGVjaWZ5IGEgYm9v
dCBwYXJhbWV0ZXINCmZvciBoaWRpbmcgdGhlIGZpbGVzLiBJdCB3aWxsIHByb2JhYmx5IG5v
dCBnZXQgdXNlZCBhIGxvdC4NCg0KDQpKdWVyZ2VuDQo=
--------------bMs6IAiJ0qHlQ232Gl000Eri
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------bMs6IAiJ0qHlQ232Gl000Eri--

--------------Taz6Er9V87gXq4GGMVSXjlwF--

--------------1oylJZz3Ri82TsAanZ0cP0jd
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmIY4wEFAwAAAAAACgkQsN6d1ii/Ey8O
Bgf9Fvi+qOUQAqs2IAJ1qcBFy6fiqwrI8TQOA8BSZFBYjIKtWwe2kUF1SNTlHM0erSDVgyb5ra36
k0AZ0yt9B75iHh7WwFK+MaLGmfNLSOF4z2+hNdEHODswyFh6+Q6V9E47xR+dswKe2axl8FYEzxTj
QAOxe/v5AK8NiYBCKktqi+qyVHJY7DC8fe7U18+cssmIhOhUmh5TAz95hIpGqZA5qynJrGwBktB8
DjqWElQTrMxrkkElJi4cUji9jItZI7aDqy3ykrtFUnC6w+YN+77UmOY42VkPuBWqAOAiU0fyWQU+
/ShwLwnJSpJw29AGHhL+1wbkfRPZn9v+eHQOQzKjVA==
=eXaV
-----END PGP SIGNATURE-----

--------------1oylJZz3Ri82TsAanZ0cP0jd--


From xen-devel-bounces@lists.xenproject.org Fri Feb 25 14:18:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 14:18:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279131.476690 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNbQU-000619-Cq; Fri, 25 Feb 2022 14:18:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279131.476690; Fri, 25 Feb 2022 14:18:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNbQU-000612-9O; Fri, 25 Feb 2022 14:18:30 +0000
Received: by outflank-mailman (input) for mailman id 279131;
 Fri, 25 Feb 2022 14:18:29 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=RDkG=TI=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nNbQT-00060w-7F
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 14:18:29 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id cc962dd3-9645-11ec-8539-5f4723681683;
 Fri, 25 Feb 2022 15:18:27 +0100 (CET)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2111.outbound.protection.outlook.com [104.47.18.111]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-8-kaqRjf8aN_m5-Q99pTwMZg-1; Fri, 25 Feb 2022 15:18:26 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM5PR04MB3106.eurprd04.prod.outlook.com (2603:10a6:206:7::17) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.25; Fri, 25 Feb
 2022 14:18:25 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.025; Fri, 25 Feb 2022
 14:18:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cc962dd3-9645-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645798707;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=VBtE1pAC4/ZFQqbHod0OFuE8vkASdxzck1Sh6w8nfMk=;
	b=jSqB6kQMW81ejLmNL16OQXpU9G61gw837EjFNcwfgorBN+4V+wdzkNz3EjCJ8iWjdTkpjg
	17kezjneRLxJ+iHtPm56uKoamu+tIKMWd2uRUk74f/Wiv4Y55alJJsL0rmxsi5C+q+/FmW
	Wk15d+uk5pnHevKq2DqXKfdNYjYm1cQ=
X-MC-Unique: kaqRjf8aN_m5-Q99pTwMZg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=PniVy1w4kuMyncQc1qBl4RS58v3tWrpZ6BfxnLQRWciVGy9ENmb9TigdSjRjAKJZH1YTmlXkj3A8gG/FxkxnyhaUfa98s26xeBh1+sxefTuMS2ySpUQSTpXQkxaLBkYAbPME8USAW9MLeUT3nntzbVFfWGnvo90PUn3nDyTEt9nkUwWhjvEbcX3x0KYLSXt1qgThMkLDGkrESagIeHDbtVwK3K42dI8c+5TQl/V4wUWOr2E4YdGJv5SAEbk4EpZqvB882zKkevnxUXFJi2WNPSg9m64/ap9CLfs6eb1NQAwQLufXjhTkgNkX+xvHKO+MrpIfmmh9c4BackdvSbZ1pA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=cfJFsvFnIwGC4dJEX2zbYAMwN2OPOR+mLARDA0M3EKQ=;
 b=fk+SOuNax25D7QBZIbAy9FhnW63RwNlQSRBNwi/T2skyxulGUzdrVh6H8gQBpktv20iYtLHz4G7ugY0pxxwYWb8PZn+OiQu8tmAlEXzUrPr7BvPOGlpV3mb1X6rSVHy2xb8aWawgVo5ViZsQro04b1UeiVBrVjcJB71ejsw7yEMeiKWDj3WECsXxnWltxMrFh6s5I2BlQt6SEeR25QTSD8zory+CgV/spbIcL8F+Qnm7yxHfUA2O90Ca/oI+FJJAgh1KhfA9pgtpmu+/1sazMt+q+4fyr1Cdh+EPvGfqxWXn7u/yPIB1m+ABttIACxehTgukD3556iKZ9McEPRwMaw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <0b8ce52a-559f-dabc-717d-98b8acf5afc3@suse.com>
Date: Fri, 25 Feb 2022 15:18:23 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: x86/vmx: Don't spuriously crash the domain when INIT is received
Content-Language: en-US
To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>
CC: Andrew Cooper <Andrew.Cooper3@citrix.com>,
 Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>,
 Jun Nakajima <jun.nakajima@intel.com>, Kevin Tian <kevin.tian@intel.com>,
 Thiner Logoer <logoerthiner1@163.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20220224194853.17774-1-andrew.cooper3@citrix.com>
 <20220224194853.17774-3-andrew.cooper3@citrix.com>
 <12d8b90b-15b0-c094-71e5-35cfdbfe72b4@suse.com>
 <51ef6bd1-bcd9-9a3a-e902-887d42d7dd7e@citrix.com>
 <bb4b4106-f49d-2b50-1eb9-eb450f6b24fa@suse.com> <Yhje4LFNt+RQJ5E0@mail-itl>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Yhje4LFNt+RQJ5E0@mail-itl>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR04CA0034.eurprd04.prod.outlook.com
 (2603:10a6:20b:46a::16) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 6c115ab7-08c9-4108-a579-08d9f869af9e
X-MS-TrafficTypeDiagnostic: AM5PR04MB3106:EE_
X-Microsoft-Antispam-PRVS:
	<AM5PR04MB310679EB36F7D5D647FE7606B33E9@AM5PR04MB3106.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	IRI9+nmILhFgJj/HYA2dDbl8q/M2/1xd7PyItK95nADYLmT1KVMSGZ0kakOG928zxZM30OjjdfGE/ToMT6pX2P2SwAnMTITfxMlO/tHUj339fetfNaRfjrPvrw6OtAAkyyBNRpouC83Z57kY3r/r83q/Tiy+92OWth1lUV41jseRZ7n7d9KPOvK6bWBTe/BlLFjzcVprIW/UWYJP4CVP+Mbd6nMi11OfHs7Dcjps429EWQWROwDz4pVXIYgu/K2GT3q3rqwG4TjXdffzZplfWJFoXc8VeFvIUKC/jK8Grnfhs37mAm8NhfZ57KtoT2tvOJwJr6b8WZgCOulc92QX+J1549bQDgJFHioomwSc4o/nVpPKjZwp2hvffTLBji6gt6UjwTYww+D3GdmvSi4/2zfsJBKSNSEX/Pg7rh3tjleQqACDxiPcmBxO3NwBY8C+Z3g05Y+hQqi7JIciQlYGu18LDthV3a8xe8OAQxm4UCe/43AmKYCXPKi+1ZOhP+xdxglsR8F4CA+oAIV96SQkNGqkXfLp9AzKQEo7DCQoI3eYU6arFM+MjIKCSjDKDXzObM8+RjQNbWWJuME2j1E/My43oQ3KEoGqzYZcif8sllm8Cq3Ky34jNg4n6urJ8jGyOuNGubMy9EVLzYPb/6/PWh3efamF/KqnAZgdsZd3+sPxJ8DFPVpPmemSXyLcGMaB0Aq/uq4SnfzSGWMGmbNxXc6O9j1D5vDuChHbJx8ZCTtVzHXIopbIpsnEL5W5oluy
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(38100700002)(508600001)(36756003)(53546011)(6512007)(6506007)(316002)(31696002)(6916009)(6486002)(54906003)(66574015)(8676002)(66946007)(83380400001)(4326008)(66476007)(66556008)(5660300002)(8936002)(86362001)(31686004)(186003)(2616005)(26005)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?Jpq+0EIWQq8yDiPmEVqWZn8KhrVgWvCgSePqar7IittQe/mgTJ0jkIv4B3bX?=
 =?us-ascii?Q?qmkfljy0O9tRlqQ4v3qjsoEtm6t/sNng89SzTAnu1Yo8r51fzYYwHa7A6qhM?=
 =?us-ascii?Q?2BgwLdgBqTXxjAPFKNjq3eYFjEfo1RHUIL2IgnfGb0RLDn0AXwq54ceqicVb?=
 =?us-ascii?Q?ipayenPrZreccXzLjFKVGnrFnr+U0D8Jh+xLZ7y2KmRGZw0gyXEFb6oDVd3f?=
 =?us-ascii?Q?TSpDaMEhwFCN3GEs5bvl49t6ZJYtv8htRjKxP5B6/CLC3m/sVrcpKEPTb8zB?=
 =?us-ascii?Q?tzwEpTtkStUfA2285cd3HtZYDPbThWhq2dOFxljXz+MkU/UPfXesuZS/NRDj?=
 =?us-ascii?Q?6a/bjKRYiTxU8yu6v8Euvp2Qokm1karOheMQsvBwPqjuWknOG+VEtdJkfF+P?=
 =?us-ascii?Q?kgyt0Ud/2bgEgRj5TsLECi/UjoUYpIx08uqtQi4zIw5QGJulRYziQfFG9hBx?=
 =?us-ascii?Q?bNSHv2JeKpJ51RjgKaNz4eURZumU0al/PzLRChXbGnX/GZRETkv9tV4ZNO1I?=
 =?us-ascii?Q?uGHR/OmApuKGik9YjPkUjbJK9r+pctRJOtAGb0cuN3hcEuHHu/P8oLeY7a2/?=
 =?us-ascii?Q?RbrZI4Wv7vXGi4C4rRHXGIuwhwYMnqJXhAQCQOl7trntl8l8kg1fLFF44+RB?=
 =?us-ascii?Q?v4XdxogP0OO6n0uEe9XenO1Jd0QSnZSio+Dg8/DCc8mx9tgnaLUNn7zj/f5x?=
 =?us-ascii?Q?kN7tYDlpste/g/KNrZF5onu2bNymWAM5ZdaMfpehUQ8YVYUa8ZuWE3pi3/9i?=
 =?us-ascii?Q?KWnVrqt1aAu3bmIP7uz8Nsf7veGyn7CEhYatfl4sRh1L/EEMhuo/t2GgG8xD?=
 =?us-ascii?Q?SQXJH0vhmLaMMD9cStKCTtnFV43AuPKL+GGYODG3h+h3rg12z5Ow5qs0SmlD?=
 =?us-ascii?Q?znIVeRjkAufhHnrKwRXZLgIb+eYw114QuZs9BKrAlxzro0dEcwQdFBVOsXIJ?=
 =?us-ascii?Q?MBEbj2Fa/79M5BHs2JNQ0q/RSWlemqrgcDkyhhXVCmL5f3OJfhQIc21Pgh+H?=
 =?us-ascii?Q?cqcXodXK5LJ1EP4oASyCmR0XE6kiOdvtFLxZrBzl/1JwCigK3f+DFUyHF+IV?=
 =?us-ascii?Q?awOLyRqzTy0V0qgLO0012XYyXHRSOP4mO5O0FI0EJ0Y2ftghS4+Zwr/iA/8Y?=
 =?us-ascii?Q?CIxSDblE84L7r5LilHl7r91/gYx6WCOy3kmNcvNOZNcSqXjkSrp+EnlQlkN7?=
 =?us-ascii?Q?W8VC/nAT1Z4zpjrBWkPb1mpHoyI0FbXcql3PpYNBzOWpO+4i628KNfO0G+28?=
 =?us-ascii?Q?g6o5f5Vl6eZrJ9QQhxAzBYww6bVDMlJ3K8zYKigX3KqxKP9KOy0V3xNu07no?=
 =?us-ascii?Q?tLX0pYXwxS41hVqmKFWQqMUXqKwzseB1wxUbgAzC5YOBVVFQOqpdbj+TC36R?=
 =?us-ascii?Q?tOrRAJ7aY4GAntsm0FtTsWUOF5NjdiNd/ulVBpi/CyoBhnt4M/DoV6jNNABQ?=
 =?us-ascii?Q?rlySnZ3LKkFaqsHP+7lgmGnj/kCmGdf2kWMJrTlQ4IcxLjra7f/ZtnL+zLZw?=
 =?us-ascii?Q?qsXVu2wcqnb55noEVgDYhl7MnQcvbAVGt8rJa6tif5BjqajuhGP7haGz/W8+?=
 =?us-ascii?Q?wrYKoixK6RvyJBhBZzbQ2fBF5HnQPXIon/4TIL8gjZXd7qEGh/YfEQr3H1jJ?=
 =?us-ascii?Q?lvPHv2ohOk+mH0ctkQol1j4=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6c115ab7-08c9-4108-a579-08d9f869af9e
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2022 14:18:25.2550
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GFq9y+NqsObErUEXAi7nPr3wwFxx2L+3UGtYK6iEopg6tPH2aH0JCP5X20kSvJS45rNckpIjQpJ/SeJ1IHN32A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR04MB3106

On 25.02.2022 14:51, Marek Marczykowski-G=C3=B3recki wrote:
> On Fri, Feb 25, 2022 at 02:19:39PM +0100, Jan Beulich wrote:
>> On 25.02.2022 13:28, Andrew Cooper wrote:
>>> On 25/02/2022 08:44, Jan Beulich wrote:
>>>> On 24.02.2022 20:48, Andrew Cooper wrote:
>>>>> In VMX operation, the handling of INIT IPIs is changed.  EXIT_REASON_=
INIT has
>>>>> nothing to do with the guest in question, simply signals that an INIT=
 was
>>>>> received.
>>>>>
>>>>> Ignoring the INIT is probably the wrong thing to do, but is helpful f=
or
>>>>> debugging.  Crashing the domain which happens to be in context is def=
initely
>>>>> wrong.  Print an error message and continue.
>>>>>
>>>>> Discovered as collateral damage from when an AP triple faults on S3 r=
esume on
>>>>> Intel TigerLake platforms.
>>>> I'm afraid I don't follow the scenario, which was (only) outlined in
>>>> patch 1: Why would the BSP receive INIT in this case?
>>>
>>> SHUTDOWN is a signal emitted by a core when it can't continue.=C2=A0 Tr=
iple
>>> fault is one cause, but other sources include a double #MC, etc.
>>>
>>> Some external component, in the PCH I expect, needs to turn this into a
>>> platform reset, because one malfunctioning core can't.=C2=A0 It is why =
a
>>> triple fault on any logical processor brings the whole system down.
>>
>> I'm afraid this doesn't answer my question. Clearly the system didn't
>> shut down. Hence I still don't see why the BSP would see INIT in the
>> first place.
>>
>>>> And it also cannot be that the INIT was received by the vCPU while run=
ning on
>>>> another CPU:
>>>
>>> It's nothing (really) to do with the vCPU.=C2=A0 INIT is a external sig=
nal to
>>> the (real) APIC, just like NMI/etc.
>>>
>>> It is the next VMEntry on a CPU which received INIT that suffers a
>>> VMEntry failure, and the VMEntry failure has nothing to do with the
>>> contents of the VMCS.
>>>
>>> Importantly for Xen however, this isn't applicable for scheduling PV
>>> vCPUs, which is why dom0 wasn't the one that crashed.=C2=A0 This actual=
ly
>>> meant that dom0 was alive an usable, albeit it sharing all vCPUs on a
>>> single CPU.
>>>
>>>
>>> The change in INIT behaviour exists for TXT, where is it critical that
>>> software can clear secrets from RAM before resetting.=C2=A0 I'm not wan=
ting
>>> to get into any of that because it's far more complicated than I have
>>> time to fix.
>>
>> I guess there's something hidden behind what you say here, like INIT
>> only being latched, but this latched state then causing the VM entry
>> failure. Which would mean that really the INIT was a signal for the
>> system to shut down / shutting down. In which case arranging to
>> continue by ignoring the event in VMX looks wrong. Simply crashing
>> the guest would then be wrong as well, of course. We should shut
>> down instead.
>=20
> A shutdown could be an alternative here, with remark that it would make
> debugging such issues significantly harder. Note the INIT is delivered
> to BSP, but the actual reason (in this case) is on some AP. Shutdown
> (crash) in this case would prevent (still functioning) BSP to show you
> the message (unless you have serial console, which is rather rare in
> laptops - which are significant target for Qubes OS).

Well, I didn't necessarily mean shutting down silently. I fully
appreciate the usefulness of getting state dumped out for debugging
of an issue.

>> But I don't think I see the full picture here yet, unless your
>> mentioning of TXT was actually implying that TXT was active at the
>> point of the crash (which I don't think was said anywhere).
>=20
> No, TXT wasn't (intentionally) active. I think Andrew mentioned it as
> explanation why VMX behaves this way: to let the OS do something _if_ TXT
> is active (the check for TXT is the OS responsibility here). But that's
> my guess only...

One part here that I don't understand: How would the OS become
aware of the INIT if it didn't try to enter a VMX guest (i.e. non-
root mode)?

Jan



From xen-devel-bounces@lists.xenproject.org Fri Feb 25 14:21:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 14:21:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279138.476700 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNbSx-0007O6-PR; Fri, 25 Feb 2022 14:21:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279138.476700; Fri, 25 Feb 2022 14:21:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNbSx-0007Nz-MM; Fri, 25 Feb 2022 14:21:03 +0000
Received: by outflank-mailman (input) for mailman id 279138;
 Fri, 25 Feb 2022 14:21:02 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=d3I2=TI=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nNbSw-0007Na-Cm
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 14:21:02 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 27fe86dd-9646-11ec-8539-5f4723681683;
 Fri, 25 Feb 2022 15:21:00 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id C10A51F38B;
 Fri, 25 Feb 2022 14:21:00 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8945913BEA;
 Fri, 25 Feb 2022 14:21:00 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id /K0WIMzlGGLJZAAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 25 Feb 2022 14:21:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 27fe86dd-9646-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1645798860; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=UAV7wLYRHNjzDGv5jhiBwVgAofY76KduxbiwjOfQgn8=;
	b=Va5LMDDh7OTQ83gzegMLp+aTgRVRXIt60b5eQ4bANVjssqDj8gtLE/kSNwP+gOkisqKfHV
	FfSc623Rodpjjs0Pd1O5ojd34wqiOECwxQUI/5F+zUe/XCz80QXSTRzonYtBesB0fupLS0
	BFsU2GBdDdMTY5JAaEiJSlpyQPfCnx0=
Message-ID: <36a36a8f-0b93-9393-f446-6c85b9118532@suse.com>
Date: Fri, 25 Feb 2022 15:21:00 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v2 2/2] xen/include/public: deprecate GNTTABOP_transfer
Content-Language: en-US
To: Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220203131418.1319-1-jgross@suse.com>
 <20220203131418.1319-2-jgross@suse.com>
 <a35bb9ba-e2be-f73e-9272-906bc09d9b6e@xen.org>
 <93e50bc4-6e53-b753-c520-7d1d0a5a5f5a@suse.com>
 <7ca05a74-6b65-f9cb-f524-28d700a7d0e4@suse.com>
 <78543fe5-1dde-41b8-e28d-de2cf22fc87f@xen.org>
 <cade3f06-4f25-07d6-3090-08a6487ba298@suse.com>
 <2295bb1c-6298-75b2-5f51-80bf114e365f@xen.org>
 <a27ff4b4-37ea-7bbc-eb43-6c4e6eb9277b@suse.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <a27ff4b4-37ea-7bbc-eb43-6c4e6eb9277b@suse.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------4Vu0sP6PNebs7qSkur4hAP3X"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------4Vu0sP6PNebs7qSkur4hAP3X
Content-Type: multipart/mixed; boundary="------------09EOFPML600r03fpLPlH2GSp";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
Message-ID: <36a36a8f-0b93-9393-f446-6c85b9118532@suse.com>
Subject: Re: [PATCH v2 2/2] xen/include/public: deprecate GNTTABOP_transfer
References: <20220203131418.1319-1-jgross@suse.com>
 <20220203131418.1319-2-jgross@suse.com>
 <a35bb9ba-e2be-f73e-9272-906bc09d9b6e@xen.org>
 <93e50bc4-6e53-b753-c520-7d1d0a5a5f5a@suse.com>
 <7ca05a74-6b65-f9cb-f524-28d700a7d0e4@suse.com>
 <78543fe5-1dde-41b8-e28d-de2cf22fc87f@xen.org>
 <cade3f06-4f25-07d6-3090-08a6487ba298@suse.com>
 <2295bb1c-6298-75b2-5f51-80bf114e365f@xen.org>
 <a27ff4b4-37ea-7bbc-eb43-6c4e6eb9277b@suse.com>
In-Reply-To: <a27ff4b4-37ea-7bbc-eb43-6c4e6eb9277b@suse.com>

--------------09EOFPML600r03fpLPlH2GSp
Content-Type: multipart/mixed; boundary="------------FGS0c7d4WFH3HQk4l7A9qOK0"

--------------FGS0c7d4WFH3HQk4l7A9qOK0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMjUuMDIuMjIgMTE6MzAsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAyNS4wMi4yMDIy
IDExOjI0LCBKdWxpZW4gR3JhbGwgd3JvdGU6DQo+PiBPbiAyNS8wMi8yMDIyIDA4OjEyLCBK
YW4gQmV1bGljaCB3cm90ZToNCj4+PiBPbiAyNC4wMi4yMDIyIDIzOjU1LCBKdWxpZW4gR3Jh
bGwgd3JvdGU6DQo+Pj4+IE9uIDE2LzAyLzIwMjIgMDk6MjksIEphbiBCZXVsaWNoIHdyb3Rl
Og0KPj4+Pj4gT24gMTYuMDIuMjAyMiAwODoyMCwgSnVlcmdlbiBHcm9zcyB3cm90ZToNCj4+
Pj4+PiBPbiAxNS4wMi4yMiAyMjoxMywgSnVsaWVuIEdyYWxsIHdyb3RlOg0KPj4+Pj4+PiBB
cyBhIHNpZGUgbm90ZSwgc2hvdWxkIHdlIGFsc28gdXBkYXRlIFNVUFBPUlQubWQ/DQo+Pj4+
Pj4NCj4+Pj4+PiBHb29kIHF1ZXN0aW9uLg0KPj4+Pj4NCj4+Pj4+IEknbSBub3Qgc3VyZSBo
ZXJlIGVpdGhlciAtIHRhbGtpbmcgYWJvdXQgaW5kaXZpZHVhbCBoeXBlcmNhbGwgc3ViLW9w
cw0KPj4+Pj4gc2VlbXMgb3Zlcmx5IHNtYWxsIGdyYW51bGFyaXR5IHRvIG1lIGZvciB0aGlz
IGtpbmQgb2YgZG9jLiBQbHVzIEkNCj4+Pj4+IGRvbid0IHZpZXcgZGVwcmVjYXRpb24gYW5k
IGRlLXN1cHBvcnRpbmcgYXMgdGhlIHNhbWUgdGhpbmcuIFRoZSBsYXR0ZXINCj4+Pj4+IHdv
dWxkIG1lYW4gdG8gcmVuZGVyIHVuc3VwcG9ydGVkIGFueSBvbGQgWGVub0xpbnV4IHdoaWNo
IG1heSBzdGlsbCBiZQ0KPj4+Pj4gaW4gdXNlLCBhbGwgb2YgdGhlIHN1ZGRlbi4NCj4+Pj4N
Cj4+Pj4gSSB1bmRlcnN0YW5kIHRoaXMgd291bGQgcmVzdWx0IHRvIHVuc3VwcG9ydCBzb21l
IG9sZCBPU2VzIChub3QgY2xlYXIgaG93DQo+Pj4+IG9sZCkuIEhvd2V2ZXIsIGZyb20gd2hh
dCBKdWVyZ2VuIHNhaWQgdGhpcyBmZWF0dXJlIGlzIHVudGVzdGVkLg0KPj4+Pg0KPj4+PiBU
byBtZSBpdCBzb3VuZCBsaWtlIHdlIGFyZSBub3QgY29uZmlkZW50IHRoYXQgd2UgY291bGQg
c2VjdXJpdHkgc3VwcG9ydA0KPj4+PiB0aGlzIGZlYXR1cmUuDQo+Pj4+DQo+Pj4+IFNvIEkg
YW0gbm90IHN1cmUgdG8gdW5kZXJzdGFuZCB3aHkgd2Ugb25seSB3YW50IHRvIGRlcHJlY2F0
ZSBpdC4NCj4+Pg0KPj4+IE5vdCBzdXJlIHdoYXQgdG8gc2F5OiBSZW5kZXJpbmcgdW5zdXBw
b3J0ZWQgaG93ZXZlciBvbGQgZ3Vlc3RzIGlzIG5vdA0KPj4+IGEgbmljZSBzdGVwLiBIZW5j
ZSBteSBjb25jZXJuICh3aGljaCBpc24ndCBhbiBvdXRyaWdodCBvYmplY3Rpb24pLg0KPj4N
Cj4+IEluIHRoZSBwYXN0IHdlIGhhdmUgcmVtb3ZlZCBzdXBwb3J0IGZvciBmZWF0dXJlIHdl
IGRlZW1lZCB1bnNhZmUgdG8gdXNlDQo+PiBhbmQgaXQgd291bGQgcmVxdWlyZSBlZmZvcnQg
dG8gc2VjdXJlIGl0LiBUaGlzIGlzIGRlc3BpdGUgdGhlIGZhY3QgdGhhdA0KPj4gaXQgbWF5
IGJlIHVzZWQgaW4gcHJvZHVjdGlvbiAoZS5nLiBQViBkZXZpY2VzLCBxZW11IHRyYWQuLi4p
Lg0KPj4NCj4+IFNvIEkgdGhpbmsgdGhlIHF1ZXN0aW9uIGhlcmUgaXMgcmVhbGx5LCBkbyB5
b3UgdGhpbmsgd2UgY2FuIHNlbnNpYmx5DQo+PiBzZWN1cml0eSBzdXBwb3J0IEdOVFRBQk9Q
X3RyYW5zZmVyPw0KPiANCj4gSSBkb24ndCB0aGluayBpdCdzIGEgcXVlc3Rpb24gb2YgImNh
biIsIGJ1dCBvZiAiYXJlIHdlIHdpbGxpbmcgdG8iLiBJdA0KPiB3b3VsZCBiZSAiY2FuIiBv
bmx5IGlmIHdlIGxlYXJuZWQgb2Ygc29tZSBzZWVtaW5nbHkgdmVyeSBoYXJkIHRvIHNvbHZl
DQo+IGlzc3VlLiBGcm9tIGEgd29ya2xvYWQgcGVyc3BlY3RpdmUgaXQgd291bGQgY2VydGFp
bmx5IGJlIG5pY2UgaWYgd2UNCj4gZGlkbid0IGhhdmUgdG8gdGhpbmsgYWJvdXQgdGhpcyBh
bnltb3JlLiBZZXQgbGlrZSBpbiBjZXJ0YWluIG90aGVyDQo+IGNhc2VzLCBiZXNpZGVzIHRo
ZSBwYXJ0aWN1bGFyIGl0ZW0gaGVyZSBJJ20gYWxzbyB3b3JyaWVkIG9mIHNldHRpbmcNCj4g
YSBwcmVjZWRlbnQgd2hpY2ggbWF5IHRoZW4gYmUgdXNlZCB0byBhcmd1ZSBmb3IgdGhlIHJl
bW92YWwgb2Ygc3VwcG9ydA0KPiBmb3Igb3RoZXIgb3BlcmF0aW9ucywganVzdCB0byBtYWtl
IG91ciBsaXZlcyBlYXNpZXIuDQoNCkp1c3Qgb25lIGNvbW1lbnQ6IGRlc3VwcG9ydGluZyBH
TlRUQUJPUF90cmFuc2ZlciB3b3VsZCBoaXQgb25seSBzeXN0ZW1zDQp3aXRoIGEgWGVub0xp
bnV4IGRvbTAuIEkgdGhpbmsgdGhvc2UgcnVubmluZyBvbiBhIHN0aWxsIHN1cHBvcnRlZCBY
ZW4NCnZlcnNpb24gYXJlIHJlYWxseSByYXJlIHRoZXNlIGRheXMuDQoNCg0KSnVlcmdlbg0K

--------------FGS0c7d4WFH3HQk4l7A9qOK0
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------FGS0c7d4WFH3HQk4l7A9qOK0--

--------------09EOFPML600r03fpLPlH2GSp--

--------------4Vu0sP6PNebs7qSkur4hAP3X
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmIY5cwFAwAAAAAACgkQsN6d1ii/Ey8+
JwgAjXqAdOTRAP1BNGPLP2DKLc7h7dO3HxGZVWjEv6Lyk/duf/iunCanKYbXOFiXzROsWjm/8yMd
fxgxDA+uBOXTMgjdjDoJcgw+8kEgZ5xXpIEVNw5tM/M3ud3Y3/SJwcA1jzjjDk1OWqhNyL1twY19
LOSh1EoWmo9DHsVksJZ+It26/3w8aqnyyIfnDzErHgqxy73Ga5VLJzfTDd+b9S2KdT2JivFP5wGl
jilY3f51HWmATGq5srJ7Q1JgVm7dJoN/diDji5cKI7DFPW8HlskymCSQ2Q396jPudzsW1yZd3zXv
1HpYeoVEr6tTGk1lso09Xf6aNhyrlVxtE0Iv5pwB2A==
=KyBk
-----END PGP SIGNATURE-----

--------------4Vu0sP6PNebs7qSkur4hAP3X--


From xen-devel-bounces@lists.xenproject.org Fri Feb 25 14:23:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 14:23:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279145.476712 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNbUw-0007yn-5D; Fri, 25 Feb 2022 14:23:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279145.476712; Fri, 25 Feb 2022 14:23:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNbUw-0007yg-1z; Fri, 25 Feb 2022 14:23:06 +0000
Received: by outflank-mailman (input) for mailman id 279145;
 Fri, 25 Feb 2022 14:23:04 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=RDkG=TI=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nNbUu-0007yX-Rj
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 14:23:04 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 71273dac-9646-11ec-8539-5f4723681683;
 Fri, 25 Feb 2022 15:23:03 +0100 (CET)
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2055.outbound.protection.outlook.com [104.47.8.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-33-URA9ahGKNwOykTVWSHp7vA-2; Fri, 25 Feb 2022 15:23:02 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM0PR04MB6033.eurprd04.prod.outlook.com (2603:10a6:208:13b::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.25; Fri, 25 Feb
 2022 14:23:00 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.025; Fri, 25 Feb 2022
 14:23:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 71273dac-9646-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1645798983;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=fdHSh8pofKzrcB9b/7qOSRhrz2eHlDdGdXyDUN+sHZU=;
	b=d14T889vJXfQQVbxrFiKlY+L1RS2DTifDVGGU2x7hd1GWZDGHUJTOpuMNiVHDL8ogeZq3o
	h8l2gCZSN8MqTGblVCZtMJqfADBP+dEh7H00ZV+nubh6e071HIHcWQEC9XS/ajJG1neZmE
	jmhsSgCN4gpjC7O+iXGKRNzRfDvG6u0=
X-MC-Unique: URA9ahGKNwOykTVWSHp7vA-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Tdp2o+XUw/eO/q+H9g2qRu1w6xlSFcGy9foACSuzmHc76gVcszDyDm1vuCMsup5rbxr3jCw1O0RkHaPZSNjHNdidGZesoKEQugQFnzliwXQ0e84MRgRt3dHNw8muAIZaC+i5NAlXb9obNU6kfMTBjHJtkfHIfNcY1HaCsrooWmgbN5CkvypnKvyCVdsJ47SmLn9WbNmUTbRIvXR04PGkQ+WctU3GD4MTxG3hVi2bf98l5mgVkl1ze6KCez7Nyk3nmq38s0ZkYggf5nB4mH8joqmdVeA5RHjFHD/lOgNicw1tsq8nDyEbJk1AaJGkcEvd4U2xvT7WVMZgZoNGYExpmQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=fdHSh8pofKzrcB9b/7qOSRhrz2eHlDdGdXyDUN+sHZU=;
 b=h1FJilQr0uuB05eG63vtbVKZZEArz9y8rntZ+g+BNczHiTTVvymo90+N9WkqJ91z0goKLJLAi1ZwlaH4WmTh4OSJVMppoTvvlW4WqAtaFP4lVoOaldSkpEt9RuydKJoz5tshCW5a3K8MefguoMeV53yXGIOStFamIftdmTECslKlPlSZsR3aJn91Y58jUaYUS1XNfHEdnQQ8L8k6nW0c3uPcUejQL75js0zcvCjm9CQPI//wT0G8cLJ3D6PNGfLiOJMhxskGH7VEg/boiK9PFOuriiT7X4c6OmaDeZIKpEbmWflsl2sAhKcyqqgCL60StltrZrjuZY8GSmg2NXtC3Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <a96d555c-8540-1f83-f110-a47904e74b55@suse.com>
Date: Fri, 25 Feb 2022 15:22:59 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: PVH dom0 and MSIX memory mapping issue
Content-Language: en-US
To: Alex Olson <this.is.a0lson@gmail.com>
References: <c33d1731b054a488974f96b8171b7b1b5aa61b4a.camel@gmail.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <c33d1731b054a488974f96b8171b7b1b5aa61b4a.camel@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR1001CA0069.EURPRD10.PROD.OUTLOOK.COM
 (2603:10a6:206:15::46) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 06811325-8588-47b8-eb35-08d9f86a53dd
X-MS-TrafficTypeDiagnostic: AM0PR04MB6033:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB6033D96519E58C2704D29F0BB33E9@AM0PR04MB6033.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	7wooipM5XBda1aBByzhKqclkO3x1YH0gbqdbGUqQhSwh2Rmvrdly3CvdFkIgbQqzglGquN2QA7pyngwFf0NCcqShTLRAiQY/kynXBwtcPfw8GQ8us41rCkT9cA+NNxruXmAJCUZWYZfSM0a0/t4uqZTjvI63laUMLXNYjKLDU68QuevNDzzTyiSzw6irBZXD3YRW2JGrPsc8SHoBmNn7ebvtvymjjSFEu/lgCz2triCL5KeHx0hdm7xd6JoZByi+f+FKEL85iC6ekxFlXMTbisfrowvP2YrIR2UMpPf6g6EfyzaRzkZwk+eZn2Hw+u6nHbjzlMUUxPnHiXBI2Gthiri3GMrinZ69TXX4OuVV9wmn6qhinIFHwZ2pPbqfdyng6+3k1Eq7JFDeiR+3vZY7e2zCeanfFRehZm2z2AkXUao/OqtxUi6az8QfTNLAyILNqp8TNnCSev3Bk+YQWnJIMuGaXJHzga/CYqavBI3DMwOWU/1pJSV9ltr0fp/xcxmyoSNVWomxPDwwuNthZ1GlMqUwFO90RyzyTOyAcOqJnpfvdqdXDMn/gfLzqlJoBGopGCM4pSmoH2sHmtok1M5+3dyGRJc2lGoFxVU016KbyFniO97JicSpVIQr98E0JI7lz1331KLwXiCeSQecx4t8QLC0z9nedXI2JyKJa+mkSRa7DT3+vmFlwel0AxNIWZXpHfMMPmhyLOg3GNF3Qo6njQR8n79IXvye64O9Z6QQJy51MG23KOU21iwMxbizmXodmBwqntI0sIDX/5aAwUEFpewiHvALyLLDWGRVegWUepCCX+T2fwFRmZhg/cqwCJZg
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2616005)(38100700002)(83380400001)(31696002)(186003)(86362001)(26005)(53546011)(316002)(6916009)(36756003)(2906002)(66946007)(66476007)(4326008)(31686004)(5660300002)(8936002)(8676002)(6506007)(6512007)(508600001)(6486002)(966005)(66556008)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aWtqTktGNGhZK091ZUt2MFB5TUNGUzBTektBM3d3dzRrS2VjL1NDeUZTNFlF?=
 =?utf-8?B?eFNXUFd2dnpoeW9XU2lqVVNuMEhXYmhHaFh2cWxIZjBkaGNFbjgvaElhRnRx?=
 =?utf-8?B?QnhaNkE1S1d2UkpSVm4vVFVwdzZiT0dvdUwrajBYZnpJWnFhT2pZcyt2dFRJ?=
 =?utf-8?B?cDdzOVBETGVkM0E3czhtdGh6cVdHR0phdzJBQ0NMZGEvSFlDRmtkeDlSL2ky?=
 =?utf-8?B?YVNrYzlaWmx4OWpDQ2ZsaUhCMGtPQ08vNWVlR1FidkZaVjl6TlFxWG9PZmZL?=
 =?utf-8?B?TGhXREc3Q3YwSkxZOXRHelprM2dKTGNWdGZvNVliZjdSRy9tbG9tTUxMcnV0?=
 =?utf-8?B?b1dldW1rUzFMaXB6d0VkQWZiSC8vTGNpSk9lL244ZzAxcTNyaUx3TDRYaDZn?=
 =?utf-8?B?RVpWL0VxYWRmd0ExWVZnZTNubmtNYk1sbUoxRks5MUJDNkNraDZBSFU3cmM3?=
 =?utf-8?B?dFVNUlBNVmRsZks3bStQTmVSNTVDOUx6bVpzVlpVSmc0cDcwWTVFdG9sVFp4?=
 =?utf-8?B?czYzZXNBcXRkYWVlWFFHbWVBbDNzUEFaVG1pTEhoYkRURThoUDh0SW9ZaXRP?=
 =?utf-8?B?K1ZtNmFuQ2tZYUZOTFVMZld6aXk1OS9sTjVlRDV0NkViV3RidDJIWW14eW5n?=
 =?utf-8?B?OUxJRkJLTVMzQjgwWmJYaWtWRjZSa0V1RmJVZGtmQmNPUGIxSnNHOHZka2Ry?=
 =?utf-8?B?NjlzMWcveGhKTmdVQjUvZ0tWN2FWVlc0Rm1DZVd4VnRXTm1Bb0VORy95TGlY?=
 =?utf-8?B?S012QUE3aFVHc0s1aVk5b0pmU204SVhXank1bG9rSW14R1Nzbk9lbFJjc1d6?=
 =?utf-8?B?RU0xdHF0bjcxaWdYZUZNWVdCNHNFKzJ5a2dLQzUvdTNUVGFjei95NVNFUEJ5?=
 =?utf-8?B?YllEUzdOQWtZQlBmempIWmxzOWRXaG1ka2dpd1diR1huMGdkOEJqOXc4d3NH?=
 =?utf-8?B?T1dJcUduenBxTkZsWEwvQjQ5SlVsK3lDZlh2QXM2d2FBK0p4TzZzbTNFSUwy?=
 =?utf-8?B?c2x0S1lJVU5vblZnS3p1Q2MyRFp3dWhrN3JyakU5Z1JUUmZCMmFocmYrY1JU?=
 =?utf-8?B?YzlMakxCWEdZMEd5UnRwMkFPTXhRZTc2bXVSYTg2TldVVzlPODdWZVJFU1ZO?=
 =?utf-8?B?VjhxeWd2c3cvS3E0MG9CU0pKMmVoRUdza1dhKy9xZHdCV3dwZ2pWam5vaDJT?=
 =?utf-8?B?YktUMlBXMDkwenczRGFhbFN5eXd4RU9LUi8xTXBGTFdHTlpVa09WOFd6UEVx?=
 =?utf-8?B?RnVGWTlob1kydmxTbm9KTWlhZGtQVjkxbGZXYXhmWExDeGp4RFBDZWhHWis5?=
 =?utf-8?B?NFlPZDViZDMyOTZFTWxlWm1Vd2V2LzJtM3dPanB1bmlyRU56UTF6V28yb0Fh?=
 =?utf-8?B?TUhBQUR4RG9NeCtDVmNKdHo1c1ZiMTJHS1E0LytheVpLb3E1cEhLWkF4MFlK?=
 =?utf-8?B?WVFPM3dsMHhVUGlKc2NFYzRuTXk0V1MxaTEvMDRiTzM4d3VZODFLNWRPU0ZF?=
 =?utf-8?B?MWN2ZTYxZnVYQ3VrSGtJem5iQW9xbTkrUFV0MDJ2RGd3Z3JzaldNbGxvaVln?=
 =?utf-8?B?VlhWUXhqcVU1ZEJLWDN3R0JNMElnVWVGWGZtMnk1NGwwZkcvbDY2akhyMkRR?=
 =?utf-8?B?Y2dYdWptMys2MmFrUHQrOGU5RzZpRGZXdVlDbVFod1QrRUlJRjFLcXZ0R3Zy?=
 =?utf-8?B?dUkzQmU0UElXNmxuZ3VUdThORDdaNXhQUTF0Q0I5SzdJdnRTNUMwWklFZ3ND?=
 =?utf-8?B?T05iczQzWklWMUVtbFR5VWM3WUY3RG54Z2pMUWFpRzdJa2h1aHlNcko5U3FB?=
 =?utf-8?B?Q3JwZ0JiNG9KdTlyUlo5T3pGQlhwZ1h2a1J3ZWczcDd1ZCtRUDJUdmNZVFdj?=
 =?utf-8?B?eENEMEpnODhZRnpOckRyU1AwcnEwV2xSWXBwWGcvc3hEUnEzTkdDaHR5djZv?=
 =?utf-8?B?aWRNWExqVVRJT0Q4U0xhWTB3cnlDZldSRUlhdDZ0dVIxOWw4V0lLd0d5SlFK?=
 =?utf-8?B?ZHAzejhoVVZ4ZjU4ZzA3bk9mNTUwRVl3azd2ZTVsQnZCL2dPdEdGUkxPZ1dB?=
 =?utf-8?B?Wk1UMnZKditjd3M2ZUloeHppK0VRWUoxam9xVUtrNDhjeUh0T1Q3WXpLNG1Z?=
 =?utf-8?B?M2ZHVExJTTZmU2VkZVNDTmEwbG4xYlN0cm5hcVROZldkSUJlWjNGWEhPcEJE?=
 =?utf-8?Q?UZQDG8u5mH92nmptWq8TfoA=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 06811325-8588-47b8-eb35-08d9f86a53dd
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2022 14:23:00.8160
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vukCBxkAwjPqLNDX9G9jtc/hzXiAy0/ele/1mhoYM9UjpwbxV03rh6f+Atswt4aRdxFR125qOjCsk50/u3W6DQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6033

On 25.02.2022 14:50, Alex Olson wrote:
> I realize PVH for dom0 is still experimental, but was trying to see how well it
> works in the state of "master".
> 
> I found one issue with MSI-X interrupts in dom0 -- a fatal page fault occurs
> when the MSI-X PBA is accessed from dom0.  It looks like dom0 doesn't have an
> identity mapping for the PBA of a PCI device --  intentionally caused by
> vpci_make_msix_hole() ?   
> 
> I was also wondering, what is the impact of "existing mapping (...) at 0
> clobbers MSIX MMIO area".
> 
> Is the purpose of vpci_make_msix_hole() to make MSIX table/PBA accesses trap to
> the hypervisor?  Seems like the page-based granularity is too coarse since the
> PBA can be much smaller than a page as well as not aligned... 
> 
> I was able to get something potentially usable by adding a "ioremap" call in
>  msix_read() and msix_write to deal with the access of the PBA.  Wasn't sure if
> this was a proper way of handling things...  Was also wondering if it would make
> sense to do the same for the "clobbers MSIX MMIO area" cases too.

You happen to ask just over two hours after a patch was posted:
https://lists.xen.org/archives/html/xen-devel/2022-02/msg01657.html
Since Roger didn't have an environment to test his change, maybe you
could do so, offering a Tested-by if successful?

Jan



From xen-devel-bounces@lists.xenproject.org Fri Feb 25 14:27:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 14:27:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279154.476722 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNbZ3-0000IH-Pp; Fri, 25 Feb 2022 14:27:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279154.476722; Fri, 25 Feb 2022 14:27:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNbZ3-0000IA-Mc; Fri, 25 Feb 2022 14:27:21 +0000
Received: by outflank-mailman (input) for mailman id 279154;
 Fri, 25 Feb 2022 14:27:20 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=halk=TI=citrix.com=prvs=048fa7b34=Jane.Malalane@srs-se1.protection.inumbo.net>)
 id 1nNbZ1-0000I2-TD
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 14:27:20 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 08450661-9647-11ec-8eb9-a37418f5ba1a;
 Fri, 25 Feb 2022 15:27:18 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 08450661-9647-11ec-8eb9-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645799238;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=02JAWAv02yBJddYouoIiPUrSkCTCLharLLXH/U//9Ys=;
  b=Z0+5wquxP+i+ONYsBuYT0qXgUbwtXxcaltWTML8gPoCHoKY3SCps4usp
   PaoZ7LQARB0eFsHCwGqK3jTpwAdTrYFxpoRypwggBAveMkLMNa1NZ44P+
   78pvEEFlAizWLmD18W23g6Cw0wfaxs18MesJnbO3FwZZVLIE9VVKF/Byp
   8=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 64994181
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Lf4lBaC4GEIV9xVW/9Hjw5YqxClBgxIJ4kV8jS/XYbTApDInhTAEn
 DAaUW3XPPvcMzDwf9txPdi0ox5U6p7cm4MwQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHWeIdA970Ug5w7Rj39Yy6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhW7
 e12qJGfSzsIO4yUmb0PaEdbH3lHaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguwBJc/meqYWvnhkxDfUJf0nXYrCU+PB4towMDIY2JwfTKqHN
 5NxhTxHUzP7ajAeCk4rKMgfzMGluCjAVW1UtwfAzUYwyzeKl1EguFT3C/LZc8KHbd9YlUGZo
 iTB5WuRKgoBKNWVxD6B83StruzChyX2XMQVDrLQ3u5nhhify3IeDDUSVECnur+ph0imQdVdJ
 kcIvC00osAaykuvSdXsWgyil1SNtBUcRtl4HvUz7UeGza+8yxmdLngJSHhGctNOnM08SCEu1
 1SJt8j0HjEpu7qQIVqf67OVoDWaKSUTa2gYakcsTwQf5ML4iJoulR+JRdFmeJNZlfWsR2u2m
 WrT6nFj2fND1qbnyplX43jgpgqXu5XmTDIU4ySPXzu31V16aNacMtnABUfg0d5MK4OQT1+kt
 XcCmtSD4O1mMaxhhBBhU81WQuj3uq/t3Cn0xAc2QsJ/r2jFF2uLINgIiAySMnuFJSrtldXBR
 EbI8T1c65ZIVJdBRf8mOtnhYyjGIEWJKDgEahw2RoYfCnSSXFXelM2LWaJ29zq8+KTLuftiU
 ap3ie72UR4n5V1PlVJavds1374x3TwZzmjOX539xBnP+ePAOCPKFe5ZbQPWNrhRAEa4TOP9q
 Yc32yyikUg3bQEDSnOPrd57wa4idxDX+qwaW+QIL7Xec2KK6UkqCuPLwKNJRmCWt/89qws8x
 VnkAhUw4AOm3RXvcFzWAlg+OOKHdcsu9hoTYH1zVWtELlB+OO5DGo9ELMBpFVTmncQ+pcNJo
 w4tIJ3RUqwSEW2co1zwr/DV9eRfSfhivirXVwKNazkjZZ9wAQvP/97vZAz08ycSSCGwsKMDT
 3eIjGs3nbJrq9xeMfvr
IronPort-HdrOrdr: A9a23:LXTLLaDrbPykj53lHegbsceALOsnbusQ8zAXPh9KJiC9I/b1qy
 nxppkmPEfP+UsssHFJo6HkBEEZKUmsuaKdkrNhQYtKOzOW91dATbsSoLcKpgePJ8SQzJ8l6U
 4NSdkcNDS0NykBsS+Y2nj3Lz9D+qj+zEnAv463pB0NLT2CKZsQlDuRYjzrSnGeLzM2YabRYa
 DsgPav0ADQHkj/AP7LZEUtbqzmnZnmhZjmaRkJC1oM8w+Vlw6l77b8Dlyxwgoeeykn+8ZizU
 H11yjCoomzufCyzRHRk0XJ6Y5NpdfnwtxfQOSRl8kuLCn2gArAXvUgZ1TChkF3nAic0idurD
 D+mWZlAy210QKXQoiBm2qu5+An6kdp15at8y7AvZKpm72HeNtzMbs+uWseSGqD16NohqAM7I
 tbm22erJZZFhXGgWD04MXJTQhjkg6urWMlivN7tQ0WbWIyUs4mkWUkxjIdLH7AJlOO1Kk3VO
 11SM3M7vdfdl2XK3jfo2l02dSpGnA+BA2PTEQOstGcl2E+pgEy82IIgMgE2nsQ/pM0TJdJo+
 zCL6RzjblLCssbd7h0CusNSda+TmbNXRXPOmSPJkmPLtBNB1vd75rspLkl7uCjf5IFiJM0hZ
 TaSVtd8XU/fkr/YPf+q6GjMiq9NFlVcQ6duf22vaIJyoEUbICbQxG+dA==
X-IronPort-AV: E=Sophos;i="5.90,136,1643691600"; 
   d="scan'208";a="64994181"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Cy4nsMTgmJA2CS3cNXnEX4NhjPl8Fz8MMIfaMLQpLUpWjzUuuT+2ssPOwJd7QUtalM/qFob+0I78StvcM6gq0/ZgU1jI/7ZvjdjitlVqB6J4CV3Ndh2e7aZkbj4IIE/vy08vPo31QIfNsAB4cBczpNwsJMVLYg2MxSPGu0yhkToyTwPty1aSx3Wv57VzP8spysm9xFsPW9nla7+f/symgTprIFL8fbrmKRR0ilmNGHm3Rb/YrQ0z+ucxmI5YZbmT9m+GuQG6qIx3B7sa2NZ7pWw2/vAMcFqMCneMPJVfRgv5IFEdDjrIueuw671O3ed/0tcHNStECufgyAVfyavyww==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=02JAWAv02yBJddYouoIiPUrSkCTCLharLLXH/U//9Ys=;
 b=KJGRUMX3SjMEA5RYgSuXBPzJPiQlK8zkBPlj1G8ciqPrUZhtvX89ch8npLP8LrMSEqXo3hDRtrvGsq9c2KDyKxY2Z5j9uQ3prgVMp4AALk8fSZIlPDtXJ9IN2bx2aYd7tfn4HpZAJ072AeK0FMfsPN/Kmb2MILnc6CV1mDvWlovxLWniEsLKcIrJTCw203qjGDddw3JsgNneDm8EQ/itsHXZXeE4m35NcQg80e1lvAodgbjFieZCaoPswQoQEpjH6ffT2OKh06/BhfvOZAX6ugQzBI3jtxiW0asvrJKPlmgWCzQKakihvfulc0STGPJEsthar8KIik+MbRf9o6+LAA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=02JAWAv02yBJddYouoIiPUrSkCTCLharLLXH/U//9Ys=;
 b=uBACfVh87DxrQGRFFqZuF71qgbjalL3w1QRrfqWm6ZMkEWQrTl6dNmALOxREgqM9lRf1YKgm+Ykjc/7JaGT2o9W0nnv8YTbgTQJwI/WOP205SleVdN8AKUVBvXQtfKygKhE+QkHaTcw80NmFtPvgfhXZn9AaUR/OxTXGACOmsmA=
From: Jane Malalane <Jane.Malalane@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Wei Liu <wl@xen.org>, Anthony Perard <anthony.perard@citrix.com>, "Juergen
 Gross" <jgross@suse.com>, Andrew Cooper <Andrew.Cooper3@citrix.com>, "George
 Dunlap" <George.Dunlap@citrix.com>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Christian Lindig
	<christian.lindig@citrix.com>, David Scott <dave@recoil.org>, "Volodymyr
 Babchuk" <Volodymyr_Babchuk@epam.com>, Roger Pau Monne
	<roger.pau@citrix.com>, Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v3 2/2] x86/xen: Allow per-domain usage of hardware
 virtualized APIC
Thread-Topic: [PATCH v3 2/2] x86/xen: Allow per-domain usage of hardware
 virtualized APIC
Thread-Index: AQHYJO0/E2Q9kBLnmUergICAnT03vayiyEcAgAAtrYCAAAFvgIABZk2A
Date: Fri, 25 Feb 2022 14:27:11 +0000
Message-ID: <62fa98a0-09a9-0af4-f289-d89cfcf8e046@citrix.com>
References: <20220218172943.12182-1-jane.malalane@citrix.com>
 <20220218172943.12182-3-jane.malalane@citrix.com>
 <b83773ec-c97a-7aea-e61a-c2e34b270816@suse.com>
 <50854702-490a-521f-c4af-1de57d4abf4b@citrix.com>
 <e7c952bf-ac8a-156f-6015-738ff5eaa138@suse.com>
In-Reply-To: <e7c952bf-ac8a-156f-6015-738ff5eaa138@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 6b8fd214-27b1-4da8-5377-08d9f86ae97a
x-ms-traffictypediagnostic: SA0PR03MB5466:EE_
x-microsoft-antispam-prvs: <SA0PR03MB5466F5EBC0A5E34F127E220F813E9@SA0PR03MB5466.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: ETTn9W9k+gLffzFw4hefcyb9ndXkvUddOaRROCAt2+rJ2paYAHtdC716FC4/d2gwNwYgk9y6SWzO8HuJMbh5C0gi1p6802dr9NMmT0uXQ9+4evG7GZDjFrmryysR9/J8IRiu8wcID4cm0j2FYVyv/V/XFTSS0xfOG0tgXt3oaJdFiFy7ZuZzkg5pJb5CuDPHQFMs5YJaIrRsNKHVnV0RyrBMbzkt2ZCeWLHrFk21G0xXQuVlpUMD8Bi4gn0cRJbEMtKk4/miGC7M0rTZDtWz62A2PvheMQvxetis/kPJIf/ul/+rcSDQ8JpsyOJQ60B1Bx5pz1ne1O23acVJKIcR6L7/Mk79/fjac9nVVpJYY+zHQWQxU1i8aeZif9H76W6PG8zfjDepsvNvlta2Y+3qEbawDdheyRwcpW9oWfjTqjtd5AHtx/owQsr5TZu3l4lenQuVXus/iZcw2bzcqGh217CFDeKW0lKk4satN3ex/Z8yFYvxPARshqzTbcT/CUG02B9mN2W3NQo8JiwX81tZQxQjYFdj70yMLelljMRfLuoi9Uz/xNtqL7ulRuoPx54ozX1sishodic0neK4RIP9so8TLrqNbXh4EsVAUgo7LsydQICXcNLevQ14+34joHE2Wz6GzvF1Bxf/v1U8Zg3ol7FjrhV2Z+zoq4u4LGRPBV1aq3lOq9X5bBMz8L5EfKjYUnPyionv3lHxqGUOGWRmm06JRZWrG/iK084Z/e0cq0ZtP2r2NC0JyeI540vjdBj8
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR03MB3386.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6512007)(6486002)(122000001)(5660300002)(31696002)(82960400001)(38100700002)(316002)(36756003)(83380400001)(54906003)(6916009)(186003)(26005)(31686004)(2616005)(4326008)(8676002)(53546011)(86362001)(38070700005)(508600001)(71200400001)(8936002)(66446008)(66476007)(66556008)(66946007)(91956017)(76116006)(64756008)(2906002)(6506007)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?amU5MkdyYTFwVU55QWpsL1pya2tMb0RBcmlYdks4NXh0YVlZTndVNnMzb0Q3?=
 =?utf-8?B?SklXdGRTSHJNRFNqNUV5S0tmYStnYVJ1NEZmek5FS3RRRXlBTXowb0lRc2ZH?=
 =?utf-8?B?dlRmZlpZbEVFdFRGcUZiWUNWc2szZ1BWeTRqRG9Rdllpam5rOG94bUU4TDUx?=
 =?utf-8?B?NlZXaVRGejJLdU0wMVZlUWNmRi93YzdIZ3p0NTJ3T0JVcWRZeUpXclpINHJL?=
 =?utf-8?B?M0hjWU9hbVpwbDJZL2Z2UXduZ3ZBOG5VNEhMOHZHWUMyVWcxZk1oUGtnSVZY?=
 =?utf-8?B?d1RCTktlMXlzMVNhRFBjQit3OUJYZGg4dnk1czB1ZVI0eDk3WlhjRXpvalJm?=
 =?utf-8?B?US9ERytHWnM5WG9IZk1rZUt2V2dlU3lqT1RZRkhlQk1tUThxTVk5ZC8rcE4r?=
 =?utf-8?B?aXFSRzJzMXBUdjllWVdWMnBaSUFKWjB3RkF3MW1PN2xSMDcyT0tuWHZ3dHMw?=
 =?utf-8?B?OWF0RWtHOFhZQVdsWnp5ZE5PUlRHdDc3MDY3ckNRM1NWU0s0Y2o5ZVZjK2hn?=
 =?utf-8?B?dVdGaEV0dE9ua2tMcnQvMDBSNk5SNVNxUGlIa09kWHVZZldGcTdXdGM1Lzdj?=
 =?utf-8?B?MkJ6Z1llRm93UVJvczdHWVJtdEswNDVlRjRhak5XLy85N3BZNXRpdG9YdExE?=
 =?utf-8?B?VXBWcHcyZ3hpVExRSElMZGlNR25aNXhDbHJLeE05bGF2RERLNHZQTEU2RnRZ?=
 =?utf-8?B?OXJuY3NTSloxMFFBYjNCaXpkbm1qVXlOTnFQb3BKbWF0VVNoeHZJK1JNN2JK?=
 =?utf-8?B?RGtHZFZzcmwwSHVMN01XL0t6aDREZjBMeEp5WlE0a3FNUEdCczc0cC9GOE1x?=
 =?utf-8?B?WnMxVUJld0hjVDJXNURvaThrNHBrTGQ1WEZHMFU4NTZDMXpFcGJTYmc1TFVK?=
 =?utf-8?B?cFVKRGpLRFpKYzd1b0hmUUJhc094bG83UnZWck9qUmdFc3o2Y2FuQ2o3Z25E?=
 =?utf-8?B?NnMwZFJKSzlqZGZWV1BuUi9hN3pXRXQwOWw3cW5STkVtUk52K3A4WmlDcTh5?=
 =?utf-8?B?Y3dqWFlSc0FVUjBKc1l3NDRWcUdrazVpbVVTU0FoZlhBdFNzbExDMDcvdXll?=
 =?utf-8?B?VU5LdFlCaTVnVHEyUEE3Unk0c09teWV6QXRMTERXc3V5UkhIT2lwMjBFalZ0?=
 =?utf-8?B?dDhOb3BtMmpBNmdEVlRVVUZjaHdxd2xYWDVmc3BSRlRZRlVEWUJpczcwVW00?=
 =?utf-8?B?UjBJSHVqeldodGV4a2VOck92Ulh6K3BaVTRzKzF5ZFRGUFBTa1dpYktuSlNH?=
 =?utf-8?B?VGhXcU1WcU9FWFVoREZkcTQreEl6VUwwdEJYLzhpRzVqa0pzckY3cERqYXIr?=
 =?utf-8?B?dDYxWjBkcmJXS2hLcUdMUTh1MnhqMFN2dVdBUHZtYkJ1M2hoNXFZL0RsOFh5?=
 =?utf-8?B?QXhFTTZ0VGd0MmN5MCsvc2hFTUR6blloUVpDNkVrMVJaQUxjdzlpb0xZZm1E?=
 =?utf-8?B?S0YveFVkTmJiMEQwU05ic3BxV3NxWXdiSHcvd1pjcDl2V1pWWlc5REhRVXZy?=
 =?utf-8?B?VHdnOG82dzFCVUpoY2dmdmRDN0hocnFyYUxxek14NkZyUUJRZ2hDeGgrRUJD?=
 =?utf-8?B?SVpIaGhkay9HOXdBajhpOXh5OFQrUzRPZTlnSHRkSXllTkZOZXR1MnpjUzNr?=
 =?utf-8?B?dkNQMTI0Ym5laGlmL2Yra3Izd0ZON3dXU1VDRnV5TlNXQk43MGxBbXRKY1Qv?=
 =?utf-8?B?aS9NQmgzV3pGY0F3Rnk2K282TVNjMXg3Q2d2SklJZEJNbjB1amd1dzhyQUFh?=
 =?utf-8?B?Z1JTcCtkWUtjUDdTQ1VubjYzVDdyOWVEbnp1T2pORWk5b2p1aHg0K1ZIdVI1?=
 =?utf-8?B?bjBoOTI2V0trc2FEQVl0NzUvRWZ1WHNML21oMUpTZ0d0UUtuNXB3MWN5Znlo?=
 =?utf-8?B?OVcvdXRBK25iVllYeUFvcC85L3N2ckFhdGcwblJ1bDdKZkZFMkV4cGJKNmd5?=
 =?utf-8?B?L3Z2N2RvbTdKeHNaN2FNU0tOalNnZldGSm5jZ3lWVGluYmpKTlZRT04zTVZa?=
 =?utf-8?B?d0M4ZnZ5MHBURy9FYnlsVGl6cllLNnFPampMeUNDZEMveStsdkE2TkcrdUJK?=
 =?utf-8?B?UGZxeTJuNUg3WURzNWZja3FHc3QwaGh3dWRWQml6VFgwQ09vRmFySlNTZVk4?=
 =?utf-8?B?SEh0NXpvSERIRjJYTFZLSHVqM3lMTXMyekNXSDdiWGxHbzVqRll1UHRIbTRl?=
 =?utf-8?B?ZU1aK2txRktDQVBDMERQbHFML2JDSWZLUnRMa0dPNUc4bnJtN1ZTVUdWYjBa?=
 =?utf-8?Q?tghuDA1T1TbhaeXBNwlkEUC8i/CTJsblTJ9C/jONmo=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <D4AAA76416F20B4CA11B19664C1E0FAC@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM5PR03MB3386.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6b8fd214-27b1-4da8-5377-08d9f86ae97a
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Feb 2022 14:27:11.6497
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: orXDXlVOpIZV5hbeY2dbiI2gofroFGCBcPsd+KL6mX3VxNxsmtjwI6lgPz0V6m2PQN5VWpG04DCwuq+BFq81j6OLf2T2X0XBlpq/ziVZHUw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR03MB5466
X-OriginatorOrg: citrix.com

T24gMjQvMDIvMjAyMiAxNzowNCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDI0LjAyLjIwMjIg
MTc6NTksIEphbmUgTWFsYWxhbmUgd3JvdGU6DQo+PiBPbiAyNC8wMi8yMDIyIDE0OjE2LCBKYW4g
QmV1bGljaCB3cm90ZToNCj4+PiBbQ0FVVElPTiAtIEVYVEVSTkFMIEVNQUlMXSBETyBOT1QgcmVw
bHksIGNsaWNrIGxpbmtzLCBvciBvcGVuIGF0dGFjaG1lbnRzIHVubGVzcyB5b3UgaGF2ZSB2ZXJp
ZmllZCB0aGUgc2VuZGVyIGFuZCBrbm93IHRoZSBjb250ZW50IGlzIHNhZmUuDQo+Pj4NCj4+PiBP
biAxOC4wMi4yMDIyIDE4OjI5LCBKYW5lIE1hbGFsYW5lIHdyb3RlOg0KPj4+PiAtLS0gYS94ZW4v
YXJjaC94ODYvaHZtL3ZteC92bXguYw0KPj4+PiArKysgYi94ZW4vYXJjaC94ODYvaHZtL3ZteC92
bXguYw0KPj4+PiBAQCAtMzMzMywxNSArMzMzMywxNSBAQCBzdGF0aWMgdm9pZCB2bXhfaW5zdGFs
bF92bGFwaWNfbWFwcGluZyhzdHJ1Y3QgdmNwdSAqdikNCj4+Pj4gICAgDQo+Pj4+ICAgIHZvaWQg
dm14X3ZsYXBpY19tc3JfY2hhbmdlZChzdHJ1Y3QgdmNwdSAqdikNCj4+Pj4gICAgew0KPj4+PiAt
ICAgIGludCB2aXJ0dWFsaXplX3gyYXBpY19tb2RlOw0KPj4+PiArICAgIGJvb2wgdmlydHVhbGl6
ZV94MmFwaWNfbW9kZTsNCj4+Pj4gICAgICAgIHN0cnVjdCB2bGFwaWMgKnZsYXBpYyA9IHZjcHVf
dmxhcGljKHYpOw0KPj4+PiAgICAgICAgdW5zaWduZWQgaW50IG1zcjsNCj4+Pj4gICAgDQo+Pj4+
ICAgICAgICB2aXJ0dWFsaXplX3gyYXBpY19tb2RlID0gKCAoY3B1X2hhc192bXhfYXBpY19yZWdf
dmlydCB8fA0KPj4+PiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNwdV9oYXNf
dm14X3ZpcnR1YWxfaW50cl9kZWxpdmVyeSkgJiYNCj4+Pj4gLSAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICBjcHVfaGFzX3ZteF92aXJ0dWFsaXplX3gyYXBpY19tb2RlICk7DQo+Pj4+ICsg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdi0+ZG9tYWluLT5hcmNoLmh2bS5hc3Npc3Rl
ZF94MmFwaWMgKTsNCj4+Pg0KPj4+IEZvbGxvd2luZyBmcm9tIG15IGNvbW1lbnQgb24gcGF0Y2gg
MSwgSSdkIGV4cGVjdCB0aGlzIHRvIGJlY29tZSBhIHNpbXBsZQ0KPj4+IGFzc2lnbm1lbnQgb2Yg
di0+ZG9tYWluLT5hcmNoLmh2bS5hc3Npc3RlZF94MmFwaWMgKGF0IHdoaWNoIHBvaW50IHRoZQ0K
Pj4+IGxvY2FsIHZhcmlhYmxlIGNvdWxkIGdvIGF3YXkpLCBqdXN0IGxpa2UgLi4uDQo+Pj4NCj4+
Pj4gLSAgICBpZiAoICFjcHVfaGFzX3ZteF92aXJ0dWFsaXplX2FwaWNfYWNjZXNzZXMgJiYNCj4+
Pj4gKyAgICBpZiAoICF2LT5kb21haW4tPmFyY2guaHZtLmFzc2lzdGVkX3hhcGljICYmDQo+Pj4+
ICAgICAgICAgICAgICF2aXJ0dWFsaXplX3gyYXBpY19tb2RlICkNCj4+Pj4gICAgICAgICAgICBy
ZXR1cm47DQo+Pj4NCj4+PiAuLi4gaGVyZS4NCj4+IFByZXZpb3N1bHkgd2UgZGlzY3Vzc2VkIHNl
dHRpbmcgdi0+ZG9tYWluLT5hcmNoLmh2bS5hc3Npc3RlZF94YXBpYyBlcXVhbA0KPj4gdG8gb25s
eSBjcHVfaGFzX3ZteF92aXJ0dWFsaXplX3gyYXBpY19tb2RlLCB0aGF0J3Mgd2h5IEkgaGF2ZSB0
aG9zZQ0KPj4gYWRkaXRpb25hbCBjaGVja3MgYXMgYXQgbGVhc3QgYXBpY19yZWdfdmlydCBvciB2
aXJ0dWFsX2ludHJfZGVsaXZlcnkgYXJlDQo+PiBuZWVkZWQgZm9yIHRoZSBzdWJzZXF1ZW50IHBh
cnRzIG9mIHRoaXMgZnVuY3Rpb24uIEkgbWlnaHQgYmUNCj4+IG1pc3VuZGVyc3RhbmRpbmcgeW91
ciBxdWVzdGlvbi4NCj4gDQo+IE15IGV4cGVjdGF0aW9uIHdvdWxkIGhhdmUgYmVlbiB0aGF0IGFz
c2lzdGVkX3gyYXBpY19hdmFpbGFibGUgaXMgYXNzaWduZWQNCj4gd2hhdCBpcyAoaW4gY29udGV4
dCBhYm92ZSkgYXNzaWduZWQgdG8gdmlydHVhbGl6ZV94MmFwaWNfbW9kZSAoaW4gcGF0Y2ggMSku
DQo+IEFueXRoaW5nIGRldmlhdGluZyBmcm9tIHRoaXMgbmVlZHMsIEkgdGhpbmssIGV4cGxhaW5p
bmcgdGhlcmUuDQoNCk9oLCBzb3JyeSwgSSBrZXB0IHRoaW5raW5nIHlvdSBtZWFudCBjcHVfaGFz
Xy4uLiBpbnN0ZWFkIG9mIHRoZSBsb2NhbCANCnZhcmlhYmxlIGFuZCBpdCB3YXMganVzdCBhbGwg
Y29uZnVzaW5nIG1lLiBXb3VsZCBpdCBoZWxwIGlmIEkgZGlkbid0IHVzZSANCmEgbG9jYWwgdmFy
aWFibGUgYXQgYWxsLCBvciBjaGFuZ2VkIHRoZSBuYW1lIHRoZW4uIFRoaXMgaXMgcmVhbGx5IGp1
c3QgYSANCmNoZWNrIHRoYXQgaXMgZG9uZSBiZWZvcmUgZXhlY3V0aW5nIHRoZSBjb2RlIGJlbG93
IGluIHRoZSBmdW5jdGlvbi4NCg0KVGhhbmtzLA0KDQpKYW5lLg==


From xen-devel-bounces@lists.xenproject.org Fri Feb 25 14:32:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 14:32:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279161.476734 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNbdX-0001j1-CR; Fri, 25 Feb 2022 14:31:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279161.476734; Fri, 25 Feb 2022 14:31:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNbdX-0001iu-8U; Fri, 25 Feb 2022 14:31:59 +0000
Received: by outflank-mailman (input) for mailman id 279161;
 Fri, 25 Feb 2022 14:31:58 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=halk=TI=citrix.com=prvs=048fa7b34=Jane.Malalane@srs-se1.protection.inumbo.net>)
 id 1nNbdW-0001io-HR
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 14:31:58 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ae2fa30d-9647-11ec-8539-5f4723681683;
 Fri, 25 Feb 2022 15:31:56 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ae2fa30d-9647-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645799517;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=UhfEm22/Cv36tYP4Emir/j2Tu0W4Ek1hZclOq0pCCJU=;
  b=Tj2QiIcQ1xRJ/ibjFTZ9oCvt17auWCyILrwyJQY6HhEIF3uwiJOsiyQZ
   VCFq2/muDIVYNI1YZYmWslMVEDMZdktG9o6VaiFuEgvDrecPoObdhYUIT
   bYLXEm7mjuHnN5NR+063CUsbW1CoVCDV7YBbmUmAm9eUXKpA5YAD/A4Xx
   k=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 64994573
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:kjYqEaNabRvb+QrvrR1el8FynXyQoLVcMsEvi/4bfWQNrUoq0DwCz
 DMdXziBa66LZmbyL4wkbN/j/B4CucLTn4NjQAto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFcMpBsJ00o5wbZj2NMw27BVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z0
 vZNnJeMSF4TGYLmlNkWeAR2Lx1aBPgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALDsDtMcU6s3VpyTjfAN4tQIzZQrWM7thdtNs1rp4STKeCO
 pVCAdZpRBWbWTBBAHRNNJAzk9ajnGCjWgxShHvA8MLb5ECMlVcsgdABKuH9YceWTM9YmkKZo
 GPu/GnjBBwectuFxlKt8G+oh+LJtTP2XsQVDrLQ3sBthFqf12kCEio8XFGwoeS6okOmUtcZI
 EsRkgIipLY/3FamRd78W1u/unHslgEYc8pdFas98g7l4rrZ5UOVC3YJShZFacc6r4kmSDoyz
 FiLktj1Qzt1v9W9S3iQ67OVpjOaIjUOICkJYipsZQkK+d74u6kokwnCCN1kFcaIYsbdQG+qh
 WrQ9W5n2utV3ZVjO7iHEU7vmRGsj5P1T1cPwSr9Ul+uxR5XWLKBXtn9gbTE1spoIIGcR1iHm
 XELncmC8ewDZa2weDyxrPYlR+/wuavcWNHIqRs2RsR6qWzxk5K2Vd0IuFlDyFFV3tHokNMDS
 Gvaoktv6ZBaJxNGhocnMtvqW6zGIUUNfOkJt8w4jPISM/CdlyfdpUmCgHJ8OUi3wSDAdollZ
 P+mnT6EVypyNEie5GPeqx0h+bEq3Dsi4mjYWIr2yR+quZLHOiLIFutcbAbWNrhhhE9hnOkz2
 4wOXydt408CONASnwGNqdJDRbz0BSJT6W/KRzx/KbfYf1sO9JAJAP7N27IxE7GJbIwO/tokC
 kqVAxcCoHKm3CWvAVzTNhhLNeO+Nb4i/ClTFXF9Yj6VN40LPN/HAFE3LMBsI9HKNYVLkJZJc
 hXyU57YU6QXF2+eoGx1gFuUhNUKSSlHTDmmZkKNSDM+Y4RhV0rO/NrldRHo7y4AEmy8ss5Wn
 lFq/lqCKXbfb2yO1PrrVc8=
IronPort-HdrOrdr: A9a23:EpQ+N6zp6PwwoR+eoT60KrPxheskLtp133Aq2lEZdPULSKKlfp
 GV88jziyWZtN9IYgBdpTiBUJPwJU81bfZOkMYs1MSZLXbbUQyTXc9fBOrZsnHd8kjFl9K1up
 0QC5SWZOeAb2SSyPyKnTVQcOxQgeVvkprY/ts2pk0FJWoBBsEQjDuRSDzraHGeLDM2XqbRf6
 Dsgfav0gDQAEj/Gf7LYEXtMdKzwuHjpdbDW1orFhQn4A6BgXeD87jhCSWV2R8YTndm3aoi2X
 KtqX242oyT99WAjjPM3W7a6Jpb3PH7zMFYOcCKgs8Jbh3xlweTYph7UbHqhkF3nAjv0idprD
 D/mWZlAy1B0QKXQohzm2qq5+DU6kdq15Yl8y7AvZKsm72geNtwMbs+uWsQSGqp16NnhqAn7E
 sD5RPoi7NHSRzHhyjz/N7OSlVjkVe1u2MrlaoJg2VYSpZ2Us4bkWUzxjIdLH47JlOz1GnnKp
 gbMOjMoPJNNV+KZXHQuWdihNSqQ3QoBx+DBkwPoNac3TRalG1wixJw/r1Tol4QsJYmD5VU7e
 XNNapl0LlIU88NdKp4QOMMW9G+BGDBSQ/FdGiSPVPkHqcaPG+lke+83JwloOWxPJAYxpo7n5
 rMFFteqG4pYkrrTdaD2ZVamyq9NllVnQ6dvf22y6IJyIEUHoCbQhFrYGpe5vednw==
X-IronPort-AV: E=Sophos;i="5.90,136,1643691600"; 
   d="scan'208";a="64994573"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Ule0926Yh3PFsaCKjS2nIs1f2VMUNJheUTyIlP90Af/4I6flRoGbBI4On+bOh4HR97zMlkMqI7CuUwMRWNG4017iikccxbRL3uzi3PsrcEfdzgpnvnEZV+zRxDRg0/1R6Z1xqK93q5hfBrXeDCrcX3S+apG3YTtvgMDo2QiXZkoxE4Fo1cQmU+u6TkhHbrGdyoHqdfjoaB9sb0892K0T0LZp5jDmdVeYi94r2Fi1SiwH4RRY5dGXcKqF8syKv3iIQAnh2vFL/rWCYMYSrDGO7XBvS1bYEDJPcwwnaLqBGfUMABR9rcuaorbOp+AUN2Zb6HnrPbL4IUN4soWgQfwXCA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=UhfEm22/Cv36tYP4Emir/j2Tu0W4Ek1hZclOq0pCCJU=;
 b=RbZN0ewzzRhE6HDtfaFCm3+pw25EJX+xlJJXLLQgJ+LVDiVLD5yLhHz1TiCcKyJAvE1Ny3SOc01iADVKbgeBsFXfN0pqeJnaRlLBdoI3m2BQniX8HieCpErfI+9okf9eiXiYsqfXq15VN/ikCz7uGrJMCShZXqAsDhhBJyyn4SAtvDndCbW6herv2bddWjHewfDLmL9Q3VyDw/5WeZ7H0Ozqhk9xbGTpkDBV+eWbEF0le7MPlWmxLcsCaMAE7x+A0IVlgmgYHgSGl2eybJvfBD9xwvd+XwwCiO8+KvlFk7zlgDIjQLHWWlxNkLUgJ9aerfSJyWhDH5Cw4QWuxwB2yg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=UhfEm22/Cv36tYP4Emir/j2Tu0W4Ek1hZclOq0pCCJU=;
 b=S+DDJNn6O3zCwSInT2pMef9Vfg4v167fmk69DkQZic7ziU19tzrrI6hSr3VtG6Tkh5zUkgpGSczX3fPMmb0Up6ih7N48xPNDlFGgzZjFMJVNE/HnKCdhprW5O8pq9yUojb+iom/wNBDKgIbe+4uOdJOG7dXPB1cVtZay0kmYlP4=
From: Jane Malalane <Jane.Malalane@citrix.com>
To: Anthony Perard <anthony.perard@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>, "Juergen
 Gross" <jgross@suse.com>, Andrew Cooper <Andrew.Cooper3@citrix.com>, "George
 Dunlap" <George.Dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, "Julien
 Grall" <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
	Christian Lindig <christian.lindig@citrix.com>, David Scott
	<dave@recoil.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, "Roger Pau
 Monne" <roger.pau@citrix.com>
Subject: Re: [PATCH v3 2/2] x86/xen: Allow per-domain usage of hardware
 virtualized APIC
Thread-Topic: [PATCH v3 2/2] x86/xen: Allow per-domain usage of hardware
 virtualized APIC
Thread-Index: AQHYJO0/E2Q9kBLnmUergICAnT03vaykSTOAgAAVuwA=
Date: Fri, 25 Feb 2022 14:31:39 +0000
Message-ID: <2badbdb6-838c-495f-4969-351ee7e73ef2@citrix.com>
References: <20220218172943.12182-1-jane.malalane@citrix.com>
 <20220218172943.12182-3-jane.malalane@citrix.com>
 <YhjWDZh3kUq1WSHd@perard.uk.xensource.com>
In-Reply-To: <YhjWDZh3kUq1WSHd@perard.uk.xensource.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: c1a01e46-f9a5-4697-bb22-08d9f86b8904
x-ms-traffictypediagnostic: CH2PR03MB5207:EE_
x-microsoft-antispam-prvs: <CH2PR03MB5207110D96BF3B83F15FF432813E9@CH2PR03MB5207.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: PJ+7NQ6D+6MYhOI1f6nk5WNQQAHlbiOhMgvGVVdXPDzeR0bpFjAKnjm+Rx30NjuRgLtW1/88Rc5b6XHFN1Vntp1A+/aaHry4knRkDmo1pKqAazPf+46og2Fxyk3TLjP1dzQ+8VVu47+VlG+cFzvoSV+HlnLIDTEJJ6zKclDnxXMnB31QUSp2rvGog9eUguBdE+ETzQrM523oGzvlJvsH7SssaShFoTOZGf7+VnGmPIOBCNGZU5H1uWY9eIPbd1mus/tNjLCpVLArGDx26b5CG8vdnQvMDikF6mS6gI2FKnALzd9BmWyY2Udsp1DosAgqklyQ6I0Uq/V+Gv26Nv0xY2gvoSIw0pe8mSG4mCZb+hbJK9EKyZ+Ybl6t3iBiu/MJxnrJY0rdJhnQRnOFOIOsvCq6CVIeH9WTPjQmfEhQGS/JCTN1khYmgRiLOypo/MJA8xctucIoowXkTid9akF0P7jkbijiax1krSXQ9AC05CwJSnu4CaoTqGoaxXeMmx320PWOQ5XQlIzEvF9cog2+Wgb4vEgggBAi1ER0rZO7hXUhXpLAMq4b7zv2l1Dw2dRCZynfPrm/UBeHV2Gq63bgMTJcHPGGPg8wb/KHTY82g83oYt3oXsZ7gTo7AKiTYhWWXJdnXZVQx8lkbMS+NkCBkqwTWQpwMFMGzy6TjwqiYEBGfhoPUB606t9XnHaz0GvYdQ5C9gf6HQAWL3EW6dljmLV9/ok302vDWpeHXlWxM5VvD+xMi/vx6XzD5UyrNl3d
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR03MB3386.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(36756003)(6636002)(38070700005)(316002)(6486002)(83380400001)(5660300002)(2906002)(31686004)(8936002)(6862004)(122000001)(107886003)(4326008)(8676002)(2616005)(66476007)(26005)(64756008)(71200400001)(186003)(54906003)(86362001)(53546011)(37006003)(508600001)(38100700002)(6512007)(6506007)(66946007)(76116006)(66556008)(91956017)(31696002)(82960400001)(66446008)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?b25JdDZzcXlCeXFtenRzSUVoc3N5cTNjNGI4N0RsNzViZlJ0dzZ3SUpmRkl0?=
 =?utf-8?B?aVBPV05aLzFmV284c2I1LytQL1p5RUc2NGs0cVN0TXp3ak1uNWhVTVM4cGQ3?=
 =?utf-8?B?VW51ZTl2UGc3TnlGVDVJSjlhN0N1Q3Y5TjArelpDM3cyazEvYXUvVXY2R0VK?=
 =?utf-8?B?emJEdjd4OG5TaGtIU0pocm5zTnYzWXIwVElDeUFxQmt6a1crSHFoR210aU1a?=
 =?utf-8?B?K1JHQ2xVRHNDM1NsSWxsWGU0NS9KMysycG5sTWZwQlo5UHQ3WU1tNGtVOUpu?=
 =?utf-8?B?Q1hQTE1lMk5SUDk3Vm9FdkMxbW9keTd6dVlid1JEMC8waldlNndIZlZOVGZP?=
 =?utf-8?B?TjJQdWZzVzhjdS85SVNLRnJRcytFeWJPQ1JPSE1qTXFPaGgwZFJIQm5wMVBl?=
 =?utf-8?B?ZzQ0VEljR0JOeklSSXZTang1NGV2OXhLQjdGNWNtZ0o4ZTJQODN1Z0FqeDRs?=
 =?utf-8?B?b3ovOFZxUkNPRm9lbVJaeWVtZ0M3dGFORi9tcnFLdGplQkkwQkYrSlFCTWtu?=
 =?utf-8?B?cDEyaktwY3RUakswT3l1cG1KSVBTQU9yU3BkdnJscXdoNjhpZGV5bVZuUFE3?=
 =?utf-8?B?U3BhUWx1b0RlVUx1THZnK1dkQjRra0lNOWo5QXltTTFWcW00SGkzcVE1Qklh?=
 =?utf-8?B?Qjd5VWtJQlBuamoxMUZ3Y09Oc0V0azZRSnV1VnRaYW04dWxpSnQ5aWd4R1F2?=
 =?utf-8?B?UkNjb3IveDB6c1pnb296cktOVUVPVitSVnVxOGhnVUNqSzZvR0JFcmRoUFBs?=
 =?utf-8?B?Mm1KUVVNbnZnZWl2Sytsc2NEa0s2ZnZ5YitaZGNpOHpFOTNha2sza0ZINjdG?=
 =?utf-8?B?SjhzNXJ6ZVNyWjhySkpramtGSHZRbXVldVVqYnJkVWVmTlpiMUtKenJZSU1N?=
 =?utf-8?B?eWxjMGducFBHZjl0NklLcWIxL0IrV205cTRCeDFOenFTUjVGVjN2SnJaRlIw?=
 =?utf-8?B?WWt3ZFZsQnpneUVuSUdIbEZ6dlByaFVWSWl1UEl0RWxncnVpTkJ1WVlhbmow?=
 =?utf-8?B?elFSTEJDc0RBeXNrL0NRdUIxemU0UkwzaDVITTlUSzVBaVppM2FoZERYd3Bm?=
 =?utf-8?B?ajlnZHl5OGZOdTBHOFA4YUhjWjF2blNqMVNxSVRaeHd2TUtzcUdHbWM2UXdq?=
 =?utf-8?B?R0JVb3JlV2E5aHRiSkY4NkMyQXF1VzgwL0hmZTBuS2xOSEJQQUdaM3dMMVJq?=
 =?utf-8?B?MDVIOTk1N3VFMEI1YUlld0VtSHJrMVRCdzd6bXo3ZDdVbVZWRysxZ0Z0YU01?=
 =?utf-8?B?eVVJUXNBMVVvK1lHdjBPVjdrMnZNL3BiWDBuTCsvd2hLMStUdGVXS1pkV1pk?=
 =?utf-8?B?YzZ1R3dlV1pvcFhiV0liZE51WXdNK2EyVURlQVFpekUyOEZndTVKclIrVUVX?=
 =?utf-8?B?bjRtaHV3TzUybzNMdit2MHQwTmRHSDRXYitxYzhMZEdBR0k5d3BDUnRUWHBN?=
 =?utf-8?B?Sy9Va1RKMUZUM2hHT0lGdEFLYnJudy9FZVZhYSt3bmtIeG1KMkxaV3VkL3cy?=
 =?utf-8?B?NWhmM1hrWWdOVjdrL1krY0ZONHdjMDBVaUsrRDRLR2x0N1FFSHdVcU5JWmRC?=
 =?utf-8?B?N0o4bkRMOGNxT2wvZmhpREtuQUtuK1lESUwxaFErOXNGYzUzTzVscWxrOWNz?=
 =?utf-8?B?T0R1NElsdFZXc2dReGVETjdMeFdHY0hUL1B2cWFvSzNyd09BVmt1U0ZHcUJ4?=
 =?utf-8?B?RUlkbWVzcDJjbDFSU0RqOTFnOXR5RU84VHpPcjg4dUdkNFg4d2pLYzRWczEv?=
 =?utf-8?B?Q0VyeWMzZTJCWitrdmdmRWRVVVdwM2g2dHFWb0E3KzhOcjZqdHQxWHA4amZI?=
 =?utf-8?B?MTZXNElWU2QyZm1JWnVhbGNiSlFkd25tN0tDcFBUQ1dwUzBlZ1lkUmlUUTFH?=
 =?utf-8?B?bkpYVXB6UkJGbjk5cHcwaFlWUWhFUzUyUFB1OVVXb01IREptamRBalF1T0pj?=
 =?utf-8?B?MjczV3ViWmpXMHF0NUtBOW5xdEdKVUR3bFIyZHdqUmJYWVlzcU1jYkR0Njg5?=
 =?utf-8?B?bm1MdkkvYWJGZTNKY2FPYklBRkNRWVFGa3ZUYjkvSXFMMkx0bFFzMEpYYklo?=
 =?utf-8?B?VnhsWXhNVElQYk8xa0s2cWk1dVorUjVLSy9wL2NqTDlQY1d3R3FlM3lEVW9K?=
 =?utf-8?B?aTFnQlQrS0pmUy9uMmxqamxxVVkveThkM1ZraThQYjRpRlQ1eUJxaGNnRU1x?=
 =?utf-8?B?ZnNhV2taaU02Q2M1SGJKVGowaWdYMlFNLytQYmFCWHJnWTNmd3I5YTc2aURX?=
 =?utf-8?Q?LYzWMLLQS6dmN0TUUIihEtkz6YQl1c1fQp7dWNUNGI=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <F6277DCEFC48774D9E04BEEDB9C55917@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM5PR03MB3386.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c1a01e46-f9a5-4697-bb22-08d9f86b8904
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Feb 2022 14:31:39.2832
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 6k9Skq4TcbY3A2mNKWHcOkhuuxZowQCOLLaYM8lf50BKWq8NyFnyDTs6YG0ohfqCYOdDpzV4CsxDuJBZlJjJ13dJ2OF5wb91Z+ETJaZlKpM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR03MB5207
X-OriginatorOrg: citrix.com

T24gMjUvMDIvMjAyMiAxMzoxMywgQW50aG9ueSBQRVJBUkQgd3JvdGU6DQo+IE9uIEZyaSwgRmVi
IDE4LCAyMDIyIGF0IDA1OjI5OjQzUE0gKzAwMDAsIEphbmUgTWFsYWxhbmUgd3JvdGU6DQo+PiBk
aWZmIC0tZ2l0IGEvdG9vbHMvaW5jbHVkZS9saWJ4bC5oIGIvdG9vbHMvaW5jbHVkZS9saWJ4bC5o
DQo+PiBpbmRleCAzMzNmZmFkMzhkLi4xYzgzY2FlNzExIDEwMDY0NA0KPj4gLS0tIGEvdG9vbHMv
aW5jbHVkZS9saWJ4bC5oDQo+PiArKysgYi90b29scy9pbmNsdWRlL2xpYnhsLmgNCj4+IEBAIC01
MzUsNiArNTM1LDEzIEBADQo+PiAgICNkZWZpbmUgTElCWExfSEFWRV9QSFlTSU5GT19BU1NJU1RF
RF9BUElDIDENCj4+ICAgDQo+PiAgIC8qDQo+PiArICogTElCWExfSEFWRV9BU1NJU1RFRF9BUElD
IGluZGljYXRlcyB0aGF0IGxpYnhsX2RvbWFpbl9idWlsZF9pbmZvIGhhcw0KPj4gKyAqIGFzc2lz
dGVkX3h7Mn1hcGljIGZpZWxkcywgZm9yIGVuYWJsaW5nIGhhcmR3YXJlIGFzc2lzdGVkIHZpcnR1
YWxpemF0aW9uIGZvcg0KPiANCj4gQ291bGQgeW91IHNwZWxsIG91dCBib3RoICJhc3Npc3RlZF94
YXBpYyBhbmQgYXNzaXN0ZWRfeDJhcGljIiBhcyB0aGF0DQo+IHdvdWxkIGFsbG93IGZvciBncmVw
IHRvIGZpbmQgYm90aCBzdHJpbmcuDQpXaWxsIGRvIChmb3IgYm90aCBjYXNlcykuDQo+IA0KPj4g
KyAqIHh7Mn1hcGljIHBlciBkb21haW4uDQo+PiArICovDQo+PiArI2RlZmluZSBMSUJYTF9IQVZF
X0FTU0lTVEVEX0FQSUMgMQ0KPj4gKw0KPj4gKy8qDQo+PiBkaWZmIC0tZ2l0IGEvdG9vbHMvbGli
cy9saWdodC9saWJ4bF9hcm0uYyBiL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfYXJtLmMNCj4+IGlu
ZGV4IDM5ZmRjYTFiNDkuLmJhNWI4ZjQzM2YgMTAwNjQ0DQo+PiAtLS0gYS90b29scy9saWJzL2xp
Z2h0L2xpYnhsX2FybS5jDQo+PiArKysgYi90b29scy9saWJzL2xpZ2h0L2xpYnhsX2FybS5jDQo+
PiBAQCAtMTM4NCw4ICsxMzg0LDkgQEAgdm9pZCBsaWJ4bF9fYXJjaF9kb21haW5fY3JlYXRlX2lu
Zm9fc2V0ZGVmYXVsdChsaWJ4bF9fZ2MgKmdjLA0KPj4gICAgICAgfQ0KPj4gICB9DQo+PiAgIA0K
Pj4gLXZvaWQgbGlieGxfX2FyY2hfZG9tYWluX2J1aWxkX2luZm9fc2V0ZGVmYXVsdChsaWJ4bF9f
Z2MgKmdjLA0KPj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICBsaWJ4bF9kb21haW5fYnVpbGRfaW5mbyAqYl9pbmZvKQ0KPj4gK2ludCBsaWJ4bF9fYXJjaF9k
b21haW5fYnVpbGRfaW5mb19zZXRkZWZhdWx0KGxpYnhsX19nYyAqZ2MsDQo+PiArICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbGlieGxfZG9tYWluX2J1aWxkX2lu
Zm8gKmJfaW5mbywNCj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICBjb25zdCBsaWJ4bF9waHlzaW5mbyAqcGh5c2luZm8pDQo+PiAgIHsNCj4+ICAgICAgIC8q
IEFDUEkgaXMgZGlzYWJsZWQgYnkgZGVmYXVsdCAqLw0KPj4gICAgICAgbGlieGxfZGVmYm9vbF9z
ZXRkZWZhdWx0KCZiX2luZm8tPmFjcGksIGZhbHNlKTsNCj4+IEBAIC0xMzk5LDYgKzE0MDAsOCBA
QCB2b2lkIGxpYnhsX19hcmNoX2RvbWFpbl9idWlsZF9pbmZvX3NldGRlZmF1bHQobGlieGxfX2dj
ICpnYywNCj4gDQo+IFRoZXJlIGlzIGFub3RoZXIgcmV0dXJuIGluIHRoaXMgZnVuY3Rpb24sIHdo
aWNoIHdhbnQgdG8gcmV0dXJuIDAgcmF0aGVyDQo+IHRoYW4gdm9pZC4NCj4gDQo+PiAgICAgICBt
ZW1zZXQoJmJfaW5mby0+dSwgJ1wwJywgc2l6ZW9mKGJfaW5mby0+dSkpOw0KPj4gICAgICAgYl9p
bmZvLT50eXBlID0gTElCWExfRE9NQUlOX1RZUEVfSU5WQUxJRDsNCj4+ICAgICAgIGxpYnhsX2Rv
bWFpbl9idWlsZF9pbmZvX2luaXRfdHlwZShiX2luZm8sIExJQlhMX0RPTUFJTl9UWVBFX1BWSCk7
DQo+PiArDQo+PiArICAgIHJldHVybiAwOw0KPj4gICB9DQo+PiAgIA0KPj4gICBpbnQgbGlieGxf
X2FyY2hfcGFzc3Rocm91Z2hfbW9kZV9zZXRkZWZhdWx0KGxpYnhsX19nYyAqZ2MsDQo+PiBkaWZm
IC0tZ2l0IGEvdG9vbHMvbGlicy9saWdodC9saWJ4bF94ODYuYyBiL3Rvb2xzL2xpYnMvbGlnaHQv
bGlieGxfeDg2LmMNCj4+IGluZGV4IGUwYTA2ZWNmZTMuLmMzNzdkMTNiMTkgMTAwNjQ0DQo+PiAt
LS0gYS90b29scy9saWJzL2xpZ2h0L2xpYnhsX3g4Ni5jDQo+PiArKysgYi90b29scy9saWJzL2xp
Z2h0L2xpYnhsX3g4Ni5jDQo+PiBAQCAtODE5LDExICs4MjcsMjcgQEAgdm9pZCBsaWJ4bF9fYXJj
aF9kb21haW5fY3JlYXRlX2luZm9fc2V0ZGVmYXVsdChsaWJ4bF9fZ2MgKmdjLA0KPj4gICB7DQo+
PiAgIH0NCj4+ICAgDQo+PiAtdm9pZCBsaWJ4bF9fYXJjaF9kb21haW5fYnVpbGRfaW5mb19zZXRk
ZWZhdWx0KGxpYnhsX19nYyAqZ2MsDQo+PiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgIGxpYnhsX2RvbWFpbl9idWlsZF9pbmZvICpiX2luZm8pDQo+PiAraW50
IGxpYnhsX19hcmNoX2RvbWFpbl9idWlsZF9pbmZvX3NldGRlZmF1bHQobGlieGxfX2djICpnYywN
Cj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBsaWJ4bF9k
b21haW5fYnVpbGRfaW5mbyAqYl9pbmZvLA0KPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgIGNvbnN0IGxpYnhsX3BoeXNpbmZvICpwaHlzaW5mbykNCj4+ICAg
ew0KPj4gICAgICAgbGlieGxfZGVmYm9vbF9zZXRkZWZhdWx0KCZiX2luZm8tPmFjcGksIHRydWUp
Ow0KPj4gICAgICAgbGlieGxfZGVmYm9vbF9zZXRkZWZhdWx0KCZiX2luZm8tPmFyY2hfeDg2Lm1z
cl9yZWxheGVkLCBmYWxzZSk7DQo+PiArDQo+PiArICAgIGlmIChiX2luZm8tPnR5cGUgIT0gTElC
WExfRE9NQUlOX1RZUEVfUFYpIHsNCj4+ICsgICAgICAgIGxpYnhsX2RlZmJvb2xfc2V0ZGVmYXVs
dCgmYl9pbmZvLT5hcmNoX3g4Ni5hc3Npc3RlZF94YXBpYywNCj4+ICsgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgIHBoeXNpbmZvLT5jYXBfYXNzaXN0ZWRfeGFwaWMpOw0KPj4gKyAgICAgICAg
bGlieGxfZGVmYm9vbF9zZXRkZWZhdWx0KCZiX2luZm8tPmFyY2hfeDg2LmFzc2lzdGVkX3gyYXBp
YywNCj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHBoeXNpbmZvLT5jYXBfYXNzaXN0
ZWRfeDJhcGljKTsNCj4+ICsgICAgfQ0KPj4gKw0KPj4gKyAgICBlbHNlIGlmICghbGlieGxfZGVm
Ym9vbF9pc19kZWZhdWx0KGJfaW5mby0+YXJjaF94ODYuYXNzaXN0ZWRfeGFwaWMpIHx8DQo+IA0K
PiBUaGlzICJlbHNlIiBuZWVkcyB0byBiZSBvbiB0aGUgc2FtZSBsaW5lIGFzIHRoZSAifSIgMiBs
aW5lcyBhYm92ZS4NCk9rYXkuDQoNClRoYW5rIHlvdSwNCg0KSmFuZS4=


From xen-devel-bounces@lists.xenproject.org Fri Feb 25 14:54:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 14:54:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279170.476745 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNbzV-0004Fq-9J; Fri, 25 Feb 2022 14:54:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279170.476745; Fri, 25 Feb 2022 14:54:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNbzV-0004Fj-6E; Fri, 25 Feb 2022 14:54:41 +0000
Received: by outflank-mailman (input) for mailman id 279170;
 Fri, 25 Feb 2022 14:54:39 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=E0Ll=TI=citrix.com=prvs=04808661d=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nNbzT-0004Fd-OZ
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 14:54:39 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d9ae8d33-964a-11ec-8539-5f4723681683;
 Fri, 25 Feb 2022 15:54:38 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d9ae8d33-964a-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645800878;
  h=from:to:cc:subject:date:message-id:mime-version:
   content-transfer-encoding;
  bh=IaJt2L4vKz2TOg5dOyMZ7VgsPRoU2r5KtiivYrAd/QY=;
  b=OHd5L1wlC8QXB6wHy5hXJj3/l0sZEquEWuMvdO6BtOo0+je6nisWL5XM
   DYNA72pKX0R9wrEbfGOmqmbif0fP39nT+KLD0jvV4jfMkthkNGMUwnHsP
   vTdz8RUIBHS7yycYgs91McNMIisc6MS//5hirT8mZI/UTjC53crdgMIfV
   A=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 64888347
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:wpOJKqy3ZWvQLAgsSCp6t+cbxirEfRIJ4+MujC+fZmUNrF6WrkUAz
 DAXDWmBafeLZjDzetpwOtnj/UwE6JHXx4AyGwNrqSAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGX9JZS5LwbZj2NYy24XhWWthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 NpliIOfaAADOb31nacSXkQBPghVepFG9+qSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DNYUDunZm3HfBAOwvW5zrSKTW/95Imjw3g6iiGN6AO
 5pJOWEzM3wsZTUfFEVQDZckv9vyi1TlVgVqsX6zgK4otj27IAtZj+G2bYu9lsaxbd5Ogk+Sq
 2bC/mL4KhIXLtqSzXyC6H3ErvDLtTP2XsQVDrLQ3vx3hFyewEQDBRtQUkG0ydGph0j7V99BJ
 kg8/is1sbN05EGtVsP6XRCzvDiDpBF0c9haHvA+6QqN4rHJ+AvfDW8BJgOtc/R/6pVwH2Zzk
 AbUwZW5XlSDrYF5V1qg6Zi1qhm1KREQbmAPOHYpZCBC39ns9dRbYg30cv5vF6u8j9vQED72w
 iyXoCVWu4j/nfLnxI3gowmZ3mvESozhC1dsu16JBj7NAhZROdb9D7FE/2Q3+hqpwGyxalCa9
 EYJlMGFhAzlJcHczXfdKAnh8VzA2hpkDNE+qQI+d3XC3270k5JGQWy2yGsvTKuOGpxZEQIFm
 GeJ5WtsCGZ7ZRNGl5NfbYOrENgNxqP9D9njXf28RoMQPsUuKFbboXk2PRb4M4XRfK4Ey/BX1
 XCzK5vEMJrnIf4/kGreqxk1i9fHORzSNUuMHMumnnxLIJKVZWKPSKdtDbd9RrtR0U9wmy2Mq
 4w3H5LTk313CbSiCgGKod97BQ1bdhATWMGpw/G7g8bee2KK7kl6UKSPqV7gEqQ495loehDgp
 SnsChcFkwOk3RUq62yiMxheVV8mZr4nxVpTAMDmFQ/AN6QLCWp30JoiSg==
IronPort-HdrOrdr: A9a23:Y7l/S6/BNp3+5YPZcABuk+DUI+orL9Y04lQ7vn2YSXRuHPBw8P
 re+MjztCWE7gr5N0tBpTntAsW9qBDnhPtICOsqTNSftWDd0QPCRuxfBOPZslrd8kbFl9K1u5
 0OT0EHMqyTMWRH
X-IronPort-AV: E=Sophos;i="5.90,136,1643691600"; 
   d="scan'208";a="64888347"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@citrix.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, "Jan
 Beulich" <jbeulich@suse.com>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Subject: [XEN PATCH] build: fix auto defconfig rule
Date: Fri, 25 Feb 2022 14:54:08 +0000
Message-ID: <20220225145409.41323-1-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

We should only run "defconfig" if ".config" is missing. Commit
317c98cb91 have added a dependency on "tools/fixdep", so make would
start runnning "defconfig" also when "tools/fixdep" is newer than
".config" and thus overwrite any changes made by a developer.
Reintroduce intended behavior of the rule to only generate a default
Kconfig when ".config" is missing.

Fixes: 317c98cb91 ("build: hook kconfig into xen build system")
Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 xen/Makefile | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/xen/Makefile b/xen/Makefile
index 133b382f86..ed4891daf1 100644
--- a/xen/Makefile
+++ b/xen/Makefile
@@ -243,15 +243,10 @@ ifeq ($(need-config),y)
 # changes are detected.
 -include include/config/auto.conf.cmd
 
-# This allows make to build fixdep before invoking defconfig. We can't use
-# "tools_fixdep" which is a .PHONY target and would force make to call
-# "defconfig" again to update $(KCONFIG_CONFIG).
-tools/fixdep:
-	$(Q)$(MAKE) $(build)=tools tools/fixdep
-
 # Allow people to just run `make` as before and not force them to configure
-$(KCONFIG_CONFIG): tools/fixdep
-	$(Q)$(MAKE) $(build)=tools/kconfig defconfig
+# Only run defconfig if $(KCONFIG_CONFIG) is missing
+$(KCONFIG_CONFIG): tools_fixdep
+	$(if $(wildcard $@), , $(Q)$(MAKE) $(build)=tools/kconfig defconfig)
 
 # The actual configuration files used during the build are stored in
 # include/generated/ and include/config/. Update them if .config is newer than
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Fri Feb 25 15:13:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 15:13:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279179.476778 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcHw-0007Cm-Ch; Fri, 25 Feb 2022 15:13:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279179.476778; Fri, 25 Feb 2022 15:13:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcHw-0007Cb-8u; Fri, 25 Feb 2022 15:13:44 +0000
Received: by outflank-mailman (input) for mailman id 279179;
 Fri, 25 Feb 2022 15:13:43 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=E0Ll=TI=citrix.com=prvs=04808661d=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nNcHv-0007Bf-Af
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 15:13:43 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 834855a0-964d-11ec-8eb9-a37418f5ba1a;
 Fri, 25 Feb 2022 16:13:41 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 834855a0-964d-11ec-8eb9-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645802021;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=SYJTJIKxHEFQcMKNpvz4kHz4LT/E8ZyffBaU/35UM+o=;
  b=fxVxyUnGDPXgWIBjQSHfUYV+H9HbwWLe/COFKCKBGoNFTdQFF861SSoB
   uVSG2fC4vZ+W2PEimi/1BLDXLvbG24gIqrCsGksohAJ5/QbPgGHrxoqx0
   mxH/8egw8AImXfPI8DErHqVw7O4FXx4xhBz8kzxlpF2gPM7nPinbDQFWD
   o=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 64998366
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:OJpQDqqeqBn9aMkcTQo0yxXXTz5eBmIcZRIvgKrLsJaIsI4StFCzt
 garIBmFb/uDMGKjfN8lPdixpk4F6sTcy9FmSFFt+CsxEH5B8ZuZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlVEliefQAOCU5NfsYkidfyc9IMsaoU8lyrZRbrJA24DjWVvX4
 46q+aUzBXf+s9JKGjNMg068gEsHUMTa4Fv0aXRnOJinFHeH/5UkJMp3yZOZdhMUcaENdgKOf
 M7RzanRw4/s10xF5uVJMFrMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKv+Zvrgc91Zk
 b1wWZKMpQgBGqPou8pFFCRjCiBcD6ZZor7uBFWyvpnGp6HGWyOEL/RGCUg3OcsT+/ptAHEI/
 vsdQNwPRknd3aTsmuv9E7QywJR4RCXoFNp3VnVIxDfFDfEgUNbbTr/D/9Nw1zYsnMFeW/3ZY
 qL1bBIxMEWRM0YRZD/7DrogkteLhUHQLQdd8niz+LA35Gbz8hFIhe2F3N39JYXRGJQ9clyjj
 n3C13T0BFcdLtP34TiP/2+oh+TPtTjmQ49UH7q9ntZ6jVvWymENBRk+UVqgveL/mkO4Q8hYK
 UEf5mwpt6dayaCwZoCjBVvi+ifC50NCHYoLewEn1O2T4o7axyW3Xi85dSdASu4tq5U3bBkH2
 1DcyrsFGgdTmLGSTHuc8JKdojWzJTUZIAc+WMMUcecWy4K9+d9u13ojWv4mSffo1YOtRVkc1
 hjX9HBWulkFsSIcO0xXF3jjiinkmJXGRxVdCu7/DjP8tVMRiGJIiuWVBbnnARRocNfxorqp5
 iFsdy2iAAYmV8DleMulGrhlIV1Rz6zZWAAweHY2d3Xbyxyj+mS4Yadb6yxkKUFiP64sIGG1P
 RCP4F8MvMcLZBNGiJObharrWqzGKoC6SLzYug38NIISMvCdiifdlM2RWaJg9z+0yxV9+U3OE
 ZyabdytHR4n5VdPl1KLqxMm+eZznEgWnDqLLbiilkjP+efONRa9FOZeWHPTP79R0U9xiFiMm
 zqpH5DRkEs3vSyXSnS/zLP/2nhRdSlrXc2t8pcPHgNBSyI/cFwc5zbq6etJU+RYc259z48kI
 lnVtpdk9WfC
IronPort-HdrOrdr: A9a23:1LyF2K5qTKylOhj0YgPXwPDXdLJyesId70hD6qhwISY6TiX+rb
 HJoB17726NtN9/YhEdcLy7VJVoBEmskKKdgrNhWotKPjOW21dARbsKheCJrgEIWReOktK1vZ
 0QCpSWY+eQMbEVt6nHCXGDYrQd/OU=
X-IronPort-AV: E=Sophos;i="5.90,136,1643691600"; 
   d="scan'208";a="64998366"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@citrix.com>, Jan Beulich
	<jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>, Wei Liu
	<wl@xen.org>
Subject: [XEN PATCH v2 04/29] tools/firmware/hvmloader: rework Makefile
Date: Fri, 25 Feb 2022 15:12:56 +0000
Message-ID: <20220225151321.44126-5-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220225151321.44126-1-anthony.perard@citrix.com>
References: <20220225151321.44126-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

Setup proper dependencies with libacpi so we don't need to run "make
hvmloader" in the "all" target. ("build.o" new prerequisite isn't
exactly proper but a side effect of building the $(DSDT_FILES) is to
generate the "ssdt_*.h" needed by "build.o".)

Make use if "-iquote" instead of a plain "-I".

For "roms.inc" target, use "$(SHELL)" instead of plain "sh". And use
full path to "mkhex" instead of a relative one. Lastly, add "-f" flag
to "mv", in case the target already exist.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 tools/firmware/hvmloader/Makefile | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/tools/firmware/hvmloader/Makefile b/tools/firmware/hvmloader/Makefile
index b754220839..fc20932110 100644
--- a/tools/firmware/hvmloader/Makefile
+++ b/tools/firmware/hvmloader/Makefile
@@ -60,8 +60,7 @@ ROMS += $(ROMBIOS_ROM) $(STDVGA_ROM) $(CIRRUSVGA_ROM)
 endif
 
 .PHONY: all
-all: acpi
-	$(MAKE) hvmloader
+all: hvmloader
 
 .PHONY: acpi
 acpi:
@@ -73,12 +72,15 @@ smbios.o: CFLAGS += -D__SMBIOS_DATE__="\"$(SMBIOS_REL_DATE)\""
 ACPI_PATH = ../../libacpi
 DSDT_FILES = dsdt_anycpu.c dsdt_15cpu.c dsdt_anycpu_qemu_xen.c
 ACPI_OBJS = $(patsubst %.c,%.o,$(DSDT_FILES)) build.o static_tables.o
-$(ACPI_OBJS): CFLAGS += -I. -DLIBACPI_STDUTILS=\"$(CURDIR)/util.h\"
+$(ACPI_OBJS): CFLAGS += -iquote . -DLIBACPI_STDUTILS=\"$(CURDIR)/util.h\"
 CFLAGS += -I$(ACPI_PATH)
 vpath build.c $(ACPI_PATH)
 vpath static_tables.c $(ACPI_PATH)
 OBJS += $(ACPI_OBJS)
 
+$(DSDT_FILES): acpi
+build.o: $(DSDT_FILES)
+
 hvmloader: $(OBJS) hvmloader.lds
 	$(LD) $(LDFLAGS_DIRECT) -N -T hvmloader.lds -o $@ $(OBJS)
 
@@ -87,21 +89,21 @@ roms.inc: $(ROMS)
 
 ifneq ($(ROMBIOS_ROM),)
 	echo "#ifdef ROM_INCLUDE_ROMBIOS" >> $@.new
-	sh ../../misc/mkhex rombios $(ROMBIOS_ROM) >> $@.new
+	$(SHELL) $(XEN_ROOT)/tools/misc/mkhex rombios $(ROMBIOS_ROM) >> $@.new
 	echo "#endif" >> $@.new
 endif
 
 ifneq ($(STDVGA_ROM),)
 	echo "#ifdef ROM_INCLUDE_VGABIOS" >> $@.new
-	sh ../../misc/mkhex vgabios_stdvga $(STDVGA_ROM) >> $@.new
+	$(SHELL) $(XEN_ROOT)/tools/misc/mkhex vgabios_stdvga $(STDVGA_ROM) >> $@.new
 	echo "#endif" >> $@.new
 endif
 ifneq ($(CIRRUSVGA_ROM),)
 	echo "#ifdef ROM_INCLUDE_VGABIOS" >> $@.new
-	sh ../../misc/mkhex vgabios_cirrusvga $(CIRRUSVGA_ROM) >> $@.new
+	$(SHELL) $(XEN_ROOT)/tools/misc/mkhex vgabios_cirrusvga $(CIRRUSVGA_ROM) >> $@.new
 	echo "#endif" >> $@.new
 endif
-	mv $@.new $@
+	mv -f $@.new $@
 
 .PHONY: clean
 clean:
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Fri Feb 25 15:13:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 15:13:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279181.476800 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcI1-0007od-6r; Fri, 25 Feb 2022 15:13:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279181.476800; Fri, 25 Feb 2022 15:13:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcI1-0007oF-24; Fri, 25 Feb 2022 15:13:49 +0000
Received: by outflank-mailman (input) for mailman id 279181;
 Fri, 25 Feb 2022 15:13:47 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=E0Ll=TI=citrix.com=prvs=04808661d=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nNcHz-0007Bf-CN
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 15:13:47 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 86cdaa5e-964d-11ec-8eb9-a37418f5ba1a;
 Fri, 25 Feb 2022 16:13:46 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 86cdaa5e-964d-11ec-8eb9-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645802026;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=g6V0HqnXbYzHAD7EivABin1e8USUEILeVoIQJoAVubg=;
  b=LUl/asu+6prFABHSOjfKWNgbVczUtxNV+ru3MR5lhiXdlowdiD03zc9o
   iBdP1xCDhavmCJ83oYo64bDb2+A8R4txVQ7wwsFz/d0jAA9sA/gjMlbST
   dmaJDtfCZkeNgJS4qlx0B9nRvW3AY9YQgf1UcenIH7bDWWOL0QEuT8pbf
   Q=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 64998371
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:kE1Yyqyps4r+weUlnRl6t+dcxirEfRIJ4+MujC+fZmUNrF6WrkUHn
 TYdWmjVPq7YMzHxf4h/a9vj/EhSvcKEzN9qTQE4qCAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGX9JZS5LwbZj2NYy24XhWWthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 Nplr4Xudz9qB6r2gb4EUkNDLQEnD4tH5+qSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DNYUDunZm3HfBAOwvW5zrSKTW/95Imjw3g6iiGN6AO
 5tIOWEwNXwsZTVsGGsTBZEYvdyUg2jlUhlAlRGfnKs4tj27IAtZj+G2bYu9lsaxbdpRtlaVo
 CTB5WuRKgEXMpmTxCSI9lqoh/TThmXrVYQKDrq6+/V2xlqJyQQu5AY+DAXh56Pj0wjnBowZe
 xd8FjcSQbYa7lX1cOG+ZhqCuSSdv0QHZfoJIcs791TYokbL2DqxCm8BRz9HTdUpss4qWDAnv
 mO0c8PV6S9H6+PMFy/EnluAhXbrYHVOczdeDcMRZVZdu7HeTJcPYgUjpzqJOIq8lZXLFD752
 FhmRwBu1uxI3abnO0hWlG0rYg5ARLCVH2bZBS2NBwpJCz+Vgqb/NuREDnCBsJ59wH6xFAXpg
 ZT9s5H2ABoyJZ+MjjeRZ+4GAauk4f2IWBWF3wIyQMV4q2n1oyb7FWy13N2YDB04WirjUWW0C
 HI/RCsLvMMDVJdURfUfj32N5zQCkvG7SIWNugH8ZdtSeJlhHDJrDwk1DXN8K1vFyRB2+YlmY
 M/zWZ/1UR4yVPQ2pBLrFrx1+eJ6mUgDKZb7GMmTI+KPiuHFOhZ4iN4tbTOzUwzOxPjc8VWNr
 o0GbJPiJtc2eLSWXxQ7OLU7dTgiRUXXz7ivwyCLXoZv+jZbJVw=
IronPort-HdrOrdr: A9a23:azSQoKAQDg4IrJPlHemm55DYdb4zR+YMi2TC1yhKJiC9Ffbo8v
 xG/c5rsiMc5wxxZJhNo7290cq7MBHhHPxOgbX5VI3KNGKNhILBFvAH0WKI+VPd8kPFmtK1rZ
 0QEJRDNA==
X-IronPort-AV: E=Sophos;i="5.90,136,1643691600"; 
   d="scan'208";a="64998371"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@citrix.com>, Wei Liu <wl@xen.org>
Subject: [XEN PATCH v2 07/29] tools/helper: Cleanup Makefile
Date: Fri, 25 Feb 2022 15:12:59 +0000
Message-ID: <20220225151321.44126-8-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220225151321.44126-1-anthony.perard@citrix.com>
References: <20220225151321.44126-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

Use $(TARGETS) to collect targets.
Collect library to link against in $(LDLIBS).
Remove extra "-f" flags that is already part of $(RM).

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 tools/helpers/Makefile | 25 +++++++++++++++++--------
 1 file changed, 17 insertions(+), 8 deletions(-)

diff --git a/tools/helpers/Makefile b/tools/helpers/Makefile
index 7f6c422440..2fe3be2f89 100644
--- a/tools/helpers/Makefile
+++ b/tools/helpers/Makefile
@@ -5,10 +5,10 @@
 XEN_ROOT = $(CURDIR)/../..
 include $(XEN_ROOT)/tools/Rules.mk
 
-PROGS += xen-init-dom0
+TARGETS += xen-init-dom0
 ifeq ($(CONFIG_Linux),y)
 ifeq ($(CONFIG_X86),y)
-PROGS += init-xenstore-domain
+TARGETS += init-xenstore-domain
 endif
 endif
 
@@ -17,6 +17,10 @@ $(XEN_INIT_DOM0_OBJS): CFLAGS += $(CFLAGS_libxentoollog)
 $(XEN_INIT_DOM0_OBJS): CFLAGS += $(CFLAGS_libxenstore)
 $(XEN_INIT_DOM0_OBJS): CFLAGS += $(CFLAGS_libxenlight)
 $(XEN_INIT_DOM0_OBJS): CFLAGS += $(CFLAGS_libxenctrl)
+xen-init-dom0: LDLIBS += $(LDLIBS_libxenctrl)
+xen-init-dom0: LDLIBS += $(LDLIBS_libxentoollog)
+xen-init-dom0: LDLIBS += $(LDLIBS_libxenstore)
+xen-init-dom0: LDLIBS += $(LDLIBS_libxenlight)
 
 INIT_XENSTORE_DOMAIN_OBJS = init-xenstore-domain.o init-dom-json.o
 $(INIT_XENSTORE_DOMAIN_OBJS): CFLAGS += $(CFLAGS_libxentoollog)
@@ -25,27 +29,32 @@ $(INIT_XENSTORE_DOMAIN_OBJS): CFLAGS += $(CFLAGS_libxenctrl)
 $(INIT_XENSTORE_DOMAIN_OBJS): CFLAGS += $(CFLAGS_libxenstore)
 $(INIT_XENSTORE_DOMAIN_OBJS): CFLAGS += $(CFLAGS_libxenlight)
 $(INIT_XENSTORE_DOMAIN_OBJS): CFLAGS += -include $(XEN_ROOT)/tools/config.h
+init-xenstore-domain: LDLIBS += $(LDLIBS_libxentoollog)
+init-xenstore-domain: LDLIBS += $(LDLIBS_libxenstore)
+init-xenstore-domain: LDLIBS += $(LDLIBS_libxenctrl)
+init-xenstore-domain: LDLIBS += $(LDLIBS_libxenguest)
+init-xenstore-domain: LDLIBS += $(LDLIBS_libxenlight)
 
 .PHONY: all
-all: $(PROGS)
+all: $(TARGETS)
 
 xen-init-dom0: $(XEN_INIT_DOM0_OBJS)
-	$(CC) $(LDFLAGS) -o $@ $(XEN_INIT_DOM0_OBJS) $(LDLIBS_libxenctrl) $(LDLIBS_libxentoollog) $(LDLIBS_libxenstore) $(LDLIBS_libxenlight) $(APPEND_LDFLAGS)
+	$(CC) $(LDFLAGS) -o $@ $(XEN_INIT_DOM0_OBJS) $(LDLIBS) $(APPEND_LDFLAGS)
 
 init-xenstore-domain: $(INIT_XENSTORE_DOMAIN_OBJS)
-	$(CC) $(LDFLAGS) -o $@ $(INIT_XENSTORE_DOMAIN_OBJS) $(LDLIBS_libxentoollog) $(LDLIBS_libxenstore) $(LDLIBS_libxenctrl) $(LDLIBS_libxenguest) $(LDLIBS_libxenlight) $(APPEND_LDFLAGS)
+	$(CC) $(LDFLAGS) -o $@ $(INIT_XENSTORE_DOMAIN_OBJS) $(LDLIBS) $(APPEND_LDFLAGS)
 
 .PHONY: install
 install: all
 	$(INSTALL_DIR) $(DESTDIR)$(LIBEXEC_BIN)
-	for i in $(PROGS); do $(INSTALL_PROG) $$i $(DESTDIR)$(LIBEXEC_BIN); done
+	for i in $(TARGETS); do $(INSTALL_PROG) $$i $(DESTDIR)$(LIBEXEC_BIN); done
 
 .PHONY: uninstall
 uninstall:
-	for i in $(PROGS); do rm -f $(DESTDIR)$(LIBEXEC_BIN)/$$i; done
+	for i in $(TARGETS); do rm -f $(DESTDIR)$(LIBEXEC_BIN)/$$i; done
 
 .PHONY: clean
 clean:
-	$(RM) -f *.o $(PROGS) $(DEPS_RM)
+	$(RM) *.o $(TARGETS) $(DEPS_RM)
 
 distclean: clean
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Fri Feb 25 15:13:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 15:13:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279178.476767 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcHt-0006vk-4O; Fri, 25 Feb 2022 15:13:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279178.476767; Fri, 25 Feb 2022 15:13:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcHt-0006vd-07; Fri, 25 Feb 2022 15:13:41 +0000
Received: by outflank-mailman (input) for mailman id 279178;
 Fri, 25 Feb 2022 15:13:39 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=E0Ll=TI=citrix.com=prvs=04808661d=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nNcHr-0006fy-1B
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 15:13:39 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 81401bbd-964d-11ec-8539-5f4723681683;
 Fri, 25 Feb 2022 16:13:38 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 81401bbd-964d-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645802017;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=e4dSMew7ThkfUT4VBhxHq8D2hkxwuVvIslum+Yj9ZTA=;
  b=ZFdXX2wSzk61xpbrtkxhazU3pLODbgJyrkpmt0aORNUirUMtjbJ93W0X
   RAJDtAF1W7n3UMETtbCwA6eGSGZH5sb6vjisIQgL++kYSO0zvmN4f1JAW
   /SFfrqjxfX4/96Os9zGKRTweuWSwmQhhdPORnvTGWym7fEZ00dgMJsM8B
   o=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 64890228
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:+mI2eKNid+sPdhzvrR3Ol8FynXyQoLVcMsEvi/4bfWQNrUoi0TEPz
 jZKWjjUOPmCY2HyLo11aI7k9EkFvZ/XydUwTQto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFcMpBsJ00o5wbZj2NMw27BVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z5
 8lIiZi8WBcQYY7hmcEQAl5JFjtvBPgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALJc/3PIQZqzd4wCvQF/oOSpHfWaTao9Rf2V/cg+gQQaaPP
 5BDOVKDajz+Yz9pKE8mVal9t/mNuUfSIhBRgnG88P9fD2/7k1UqjemF3MDuUsOObdVYmACfv
 G2u13T0BFQWOcKSzRKB82mwnanfkCXjQoUQGbaksPlwjzWuKnc7UUNMEwHh+L/g1xD4C4k3x
 1EoFjQGgrQ3yEinX8nEAD6VoVuJ71kNXsBBKrhvgO2S8Zb87wGcD2kCazdObt06qcM7LQAXO
 k+1c8DBXmI27uDMIZ6J3vLN9G7pZ3BJRYMXTXJcFWM4D8/fTJbfZ/4lZvJqC+aLg9L8AlkcK
 Bja/XFl193/YSPmvphXHGwrYRrw9/AlrSZvv207u15JCCsjNeZJgKTytDDmAQ5odtrxc7V4l
 CFsdzKixO4PF4qRsyeGXf8AGrqkj97cbmGB3gI2Q8R5r2z1k5JGQWy2yGsvTKuOGpxZEQIFn
 WeJ4V8BjHOtFCHCgVBLj3KZVJ1xkPmI+SXNXfHIdNteCqWdhyfclByCkXW4hji3+GB1yPlXE
 c7CLa6EUCZLYYw6nWHeb7pMjtcWKtUWmDq7qWbTlE/8j9JzpRe9FN84Dbd5RrthvfPc/V6Mq
 I432gnj40w3bdASqxL/qeY7RW3m51BgbXwqg6S7rtK+Hzc=
IronPort-HdrOrdr: A9a23:otMmpqBLcDW9H/DlHemq55DYdb4zR+YMi2TC1yhKJiC9Ffbo8P
 xG/c5rrCMc5wxxZJhNo7290ey7MBHhHP1OkO0s1NWZPDUO0VHAROoJ0WKh+UyEJ8SXzJ866U
 4KScZD4bPLYWSS9fyKgzWFLw==
X-IronPort-AV: E=Sophos;i="5.90,136,1643691600"; 
   d="scan'208";a="64890228"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@citrix.com>, Wei Liu <wl@xen.org>
Subject: [XEN PATCH v2 03/29] tools/examples: cleanup Makefile
Date: Fri, 25 Feb 2022 15:12:55 +0000
Message-ID: <20220225151321.44126-4-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220225151321.44126-1-anthony.perard@citrix.com>
References: <20220225151321.44126-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

Don't check if a target exist before installing it. For directory,
install doesn't complain, and for file it would prevent from updating
them. Also remove the existing loop and instead install all files with
a single call to $(INSTALL_DATA).

Remove XEN_CONFIGS-y which isn't used.

Remove "build" target.

Add an empty line after the first comment. The comment isn't about
$(XEN_READMES), it is about the makefile as a whole.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---

Notes:
    v2:
    - remove existing loops in install targets and use a single call to
      $(INSTALL_DATA) to install multiple files.

 tools/examples/Makefile | 25 ++++++-------------------
 1 file changed, 6 insertions(+), 19 deletions(-)

diff --git a/tools/examples/Makefile b/tools/examples/Makefile
index 14e24f4cb3..c839bf5603 100644
--- a/tools/examples/Makefile
+++ b/tools/examples/Makefile
@@ -2,6 +2,7 @@ XEN_ROOT = $(CURDIR)/../..
 include $(XEN_ROOT)/tools/Rules.mk
 
 # Xen configuration dir and configs to go there.
+
 XEN_READMES = README
 
 XEN_CONFIGS += xlexample.hvm
@@ -10,14 +11,9 @@ XEN_CONFIGS += xlexample.pvhlinux
 XEN_CONFIGS += xl.conf
 XEN_CONFIGS += cpupool
 
-XEN_CONFIGS += $(XEN_CONFIGS-y)
-
 .PHONY: all
 all:
 
-.PHONY: build
-build:
-
 .PHONY: install
 install: all install-readmes install-configs
 
@@ -26,12 +22,8 @@ uninstall: uninstall-readmes uninstall-configs
 
 .PHONY: install-readmes
 install-readmes:
-	[ -d $(DESTDIR)$(XEN_CONFIG_DIR) ] || \
-		$(INSTALL_DIR) $(DESTDIR)$(XEN_CONFIG_DIR)
-	set -e; for i in $(XEN_READMES); \
-	    do [ -e $(DESTDIR)$(XEN_CONFIG_DIR)/$$i ] || \
-	    $(INSTALL_DATA) $$i $(DESTDIR)$(XEN_CONFIG_DIR); \
-	done
+	$(INSTALL_DIR) $(DESTDIR)$(XEN_CONFIG_DIR)
+	$(INSTALL_DATA) $(XEN_READMES) $(DESTDIR)$(XEN_CONFIG_DIR)
 
 .PHONY: uninstall-readmes
 uninstall-readmes:
@@ -39,14 +31,9 @@ uninstall-readmes:
 
 .PHONY: install-configs
 install-configs: $(XEN_CONFIGS)
-	[ -d $(DESTDIR)$(XEN_CONFIG_DIR) ] || \
-		$(INSTALL_DIR) $(DESTDIR)$(XEN_CONFIG_DIR)
-	[ -d $(DESTDIR)$(XEN_CONFIG_DIR)/auto ] || \
-		$(INSTALL_DIR) $(DESTDIR)$(XEN_CONFIG_DIR)/auto
-	set -e; for i in $(XEN_CONFIGS); \
-	    do [ -e $(DESTDIR)$(XEN_CONFIG_DIR)/$$i ] || \
-	    $(INSTALL_DATA) $$i $(DESTDIR)$(XEN_CONFIG_DIR); \
-	done
+	$(INSTALL_DIR) $(DESTDIR)$(XEN_CONFIG_DIR)
+	$(INSTALL_DIR) $(DESTDIR)$(XEN_CONFIG_DIR)/auto
+	$(INSTALL_DATA) $(XEN_CONFIGS) $(DESTDIR)$(XEN_CONFIG_DIR)
 
 .PHONY: uninstall-configs
 uninstall-configs:
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Fri Feb 25 15:13:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 15:13:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279177.476756 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcHq-0006gB-SC; Fri, 25 Feb 2022 15:13:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279177.476756; Fri, 25 Feb 2022 15:13:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcHq-0006g4-P9; Fri, 25 Feb 2022 15:13:38 +0000
Received: by outflank-mailman (input) for mailman id 279177;
 Fri, 25 Feb 2022 15:13:37 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=E0Ll=TI=citrix.com=prvs=04808661d=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nNcHp-0006fy-F9
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 15:13:37 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7e28d66b-964d-11ec-8539-5f4723681683;
 Fri, 25 Feb 2022 16:13:33 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7e28d66b-964d-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645802013;
  h=from:to:cc:subject:date:message-id:mime-version:
   content-transfer-encoding;
  bh=KIhYkS7Gu6rrziwgHwY7wsgo17mkuu1fvf9ZT/ahnY8=;
  b=id1eF/w6/iDKAOd1Gj1ujsNOQ3u9wkSonJN7+ntMGIwFv0xyR2xzlGgQ
   mz5rxu0oZxbgN0fIqytfp1lC/n3PTs4cmGXcG8bDHmb6XGHUoRnxPpEXz
   kjI3teUn36pxueBdqfDV58LO9n/DRVZHRyrJAQyH3IfS9WQMFOM9/XFvD
   U=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 67264703
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:XamYGqkmIzcizGZxAOAC2bfo5gwBJkRdPkR7XQ2eYbSJt1+Wr1Gzt
 xIcCmzXOvfcZmCmf91xOdjg8xsCvpXcnN82GVE/q3wzHyMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EoLd9IR2NYy24DjWV7V4
 7senuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR
 v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ
 NtxWZOYQD53OpTok/ghUxBiKQNsHJdv17nKGC3q2SCT5xWun3rExvxvCAc9PJEC+/YxCmZLn
 RAaAGlTNFbZ3bvwme/lDLk37iggBJCD0Ic3s3d8zTbfHLA+TIrKWani7t5ExjYgwMtJGJ4yY
 uJHNmAxMEuYOHWjPH9OU7UBhrn5nED0SC10unG8p5Am43fcmVkZPL/Fb4OOJ43iqd9utkqRu
 G/u5WnyBRAectuFxlKt8Hihm+vOliPTQ58JGfuz8fsCqF+Owm0eDjUGWF39puO24mazX99ZI
 goJ9CsrsbM/6kWDScP0VBm15nWDu3Y0QMFMGuc37AWMzKv84AuDAGUACDlbZ7QOq8seVTEsk
 FiTkLvBFTFp9bGYV3+Z3rOVti+pfzgYK3cYYi0JRhdD5MPsyKkxgQjIVc1LC7Oug5v+HjSY6
 yuDqTUzg/MPjc8B3ri/4XjKhSnpoonOSEgy/Aq/Y46+xlonPsj/PdXusAWFq6YbRGqEcrWfl
 HE9xcynyOsSMZGErhavUsQ3NZ6v6s/QZVUwnmVTN5Um8j2s/VuqcoZR/CxyKS9VDyoURdP6S
 BSN4F0Mvfe/KFPvNPYqONzpV6zG2IC9TYyNaxzCUjZZjnGdniej9TomW0Of1nuFfKMEwfBmY
 sfznSpB4B8n5UVbINieG7Z1PVwDnHlWKYbvqXbTlUXPPV22PiP9dFv9GAHSBt3VFYvdyOkvz
 /5RNtGR1zJUW/Dkby/c/OY7dA5WcCdnXMyr85QPLoZvxzaK/kl7Wpc9Jpt7JuRYc1l9zL+Ur
 hlRpGcCoLYAuZE3AVrTMS0yAF8edZ1+sWg6LUQR0aWAgBAejXKUxP5HLfMfJOB/nMQ6lKIcZ
 6RVKq2oX6UUIhyaqmt1UHUIhNE7HPhdrVnVZHTNjflWV8MIejElDfe/Jlq/rHRVV3Hv3Sb8y
 pX5vj7mrVM4b1wKJK7rhDiHkztdYVB1dDpOYnb1
IronPort-HdrOrdr: A9a23:opY5oKo7qkcARqRw88p/1ZwaV5oheYIsimQD101hICG8cqSj+P
 xG+85rsCMc6QxhP03I9urgBEDtex7hHP1OkOss1NWZPDUO0VHAROoJ0WKL+UyFJ8SUzIBgPM
 lbH5SWcOeAbmRHsQ==
X-IronPort-AV: E=Sophos;i="5.90,136,1643691600"; 
   d="scan'208";a="67264703"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@citrix.com>, Wei Liu <wl@xen.org>, "George
 Dunlap" <george.dunlap@citrix.com>, Christian Lindig
	<christian.lindig@citrix.com>, Samuel Thibault
	<samuel.thibault@ens-lyon.org>, Juergen Gross <jgross@suse.com>, "Andrew
 Cooper" <andrew.cooper3@citrix.com>, Stefano Stabellini
	<sstabellini@kernel.org>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Jan Beulich <jbeulich@suse.com>, David Scott
	<dave@recoil.org>, Elena Ufimtseva <elena.ufimtseva@oracle.com>, Julien Grall
	<julien@xen.org>
Subject: [XEN PATCH v2 00/29] Toolstack build system improvement, toward non-recursive makefiles
Date: Fri, 25 Feb 2022 15:12:52 +0000
Message-ID: <20220225151321.44126-1-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

Patch series available in this git branch:
https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git br.toolstack-build-system-v2

Changes in v2:
- one new patch
- other changes described in patch notes

Hi everyone,

I've been looking at reworking the build system we have for the "tools/", and
transforming it to something that suit it better. There are a lot of
dependencies between different sub-directories so it would be nice if GNU make
could actually handle them. This is possible with "non-recursive makefiles".

With non-recursive makefiles, make will have to load/include all the makefiles
and thus will have complete overview of all the dependencies. This will allow
make to build the necessary targets in other directory, and we won't need to
build sub-directories one by one.

To help with this transformation, I've chosen to go with a recent project
called "subdirmk". It help to deal with the fact that all makefiles will share
the same namespace, it is hooked into autoconf, we can easily run `make` from
any subdirectory. Together "autoconf" and "subdirmk" will also help to get
closer to be able to do out-of-tree build of the tools, but I'm mainly looking
to have non-recursive makefile.

Link to the project:
    https://www.chiark.greenend.org.uk/ucgi/~ian/git/subdirmk.git/

But before getting to the main course, I've got quite a few cleanup and some
changes to the makefiles. I start the patch series with patches that remove old
left over stuff, then start reworking makefiles. They are some common changes like
removing the "build" targets in many places as "all" would be the more common
way to spell it and "all" is the default target anyway. They are other changes
related to the conversion to "subdirmk", I start to use the variable $(TARGETS)
in several makefiles, this variable will have a special meaning in subdirmk
which will build those target by default.

stubdom has some changes also as it won't be able to use tools/ Makefiles
as-is anymore.

As for the conversion to non-recursive makefile, with subdirmk, I have this WIP
branch, it contains some changes that I'm trying out, some notes, and the
conversion, one Makefile per commit. Cleanup are still needed, some makefile
not converted yet, but it's otherwise mostly done.

    https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git br.toolstack-build-system-v1-wip-extra

With that branch, you could tried something like:
    ./configure; cd tools/xl; make
and `xl` should be built as well as all the xen library needed.
Also, things like `make clean` or rebuild should be faster in the all tools/
directory.

Cheers,

Anthony PERARD (29):
  tools/console: have one Makefile per program/directory
  tools/debugger/gdbsx: Fix and cleanup makefiles
  tools/examples: cleanup Makefile
  tools/firmware/hvmloader: rework Makefile
  tools/fuzz/libelf: rework makefile
  tools/fuzz/x86_instruction_emulator: rework makefile
  tools/helper: Cleanup Makefile
  tools/hotplug: cleanup Makefiles
  tools/libfsimage: Cleanup makefiles
  tools/xenpaging: Rework makefile
  tools/xenstore: Cleanup makefile
  tools/xentop: rework makefile
  tools/xentrace: rework Makefile
  libs: rename LDUSELIBS to LDLIBS and use it instead of APPEND_LDFLAGS
  libs: Remove need for *installlocal targets
  libs,tools/include: Clean "clean" targets
  libs: Rename $(SRCS-y) to $(OBJS-y)
  libs/guest: rename ELF_OBJS to LIBELF_OBJS
  libs/guest: rework CFLAGS
  libs/store: use of -iquote instead of -I
  libs/stat: Fix and rework python-bindings build
  libs/stat: Fix and rework perl-binding build
  .gitignore: Cleanup ignores of tools/libs/*/{headers.chk,*.pc}
  stubdom: introduce xenlibs.mk
  tools/libs: create Makefile.common to be used by stubdom build system
  tools/xenstore: introduce Makefile.common to be used by stubdom
  stubdom: build xenstore*-stubdom using new Makefile.common
  stubdom: xenlibs linkfarm, ignore non-regular files
  tools/ocaml: fix build dependency target

 stubdom/Makefile                              |  24 +-
 tools/Makefile                                |   2 +-
 tools/console/Makefile                        |  49 +---
 tools/console/client/Makefile                 |  39 ++++
 tools/console/daemon/Makefile                 |  50 +++++
 tools/debugger/gdbsx/Makefile                 |  20 +-
 tools/debugger/gdbsx/gx/Makefile              |  15 +-
 tools/debugger/gdbsx/xg/Makefile              |  25 +--
 tools/examples/Makefile                       |  25 +--
 tools/firmware/hvmloader/Makefile             |  16 +-
 tools/fuzz/libelf/Makefile                    |  21 +-
 tools/fuzz/x86_instruction_emulator/Makefile  |  32 ++-
 tools/helpers/Makefile                        |  25 ++-
 tools/hotplug/FreeBSD/Makefile                |  11 +-
 tools/hotplug/Linux/Makefile                  |  16 +-
 tools/hotplug/Linux/systemd/Makefile          |  16 +-
 tools/hotplug/NetBSD/Makefile                 |   9 +-
 tools/hotplug/common/Makefile                 |  16 +-
 tools/include/Makefile                        |   1 +
 tools/include/xen-foreign/Makefile            |   1 +
 tools/libfsimage/common/Makefile              |  11 +-
 tools/libfsimage/ext2fs-lib/Makefile          |   9 -
 tools/libfsimage/ext2fs/Makefile              |   9 -
 tools/libfsimage/fat/Makefile                 |   9 -
 tools/libfsimage/iso9660/Makefile             |  11 -
 tools/libfsimage/reiserfs/Makefile            |   9 -
 tools/libfsimage/ufs/Makefile                 |   9 -
 tools/libfsimage/xfs/Makefile                 |   9 -
 tools/libfsimage/zfs/Makefile                 |   9 -
 tools/libs/call/Makefile                      |   7 +-
 tools/libs/ctrl/Makefile                      |  50 +----
 tools/libs/devicemodel/Makefile               |   7 +-
 tools/libs/evtchn/Makefile                    |   7 +-
 tools/libs/foreignmemory/Makefile             |   7 +-
 tools/libs/gnttab/Makefile                    |   9 +-
 tools/libs/guest/Makefile                     | 100 +--------
 tools/libs/hypfs/Makefile                     |   4 +-
 tools/libs/light/Makefile                     | 209 +++++++++---------
 tools/libs/stat/Makefile                      |  72 +++---
 tools/libs/store/Makefile                     |  18 +-
 tools/libs/toolcore/Makefile                  |   2 +-
 tools/libs/toollog/Makefile                   |   3 +-
 tools/libs/util/Makefile                      |  23 +-
 tools/libs/vchan/Makefile                     |   9 +-
 tools/ocaml/libs/eventchn/Makefile            |   8 +-
 tools/ocaml/libs/mmap/Makefile                |   8 +-
 tools/ocaml/libs/xb/Makefile                  |   8 +-
 tools/ocaml/libs/xc/Makefile                  |   8 +-
 tools/ocaml/libs/xentoollog/Makefile          |   8 +-
 tools/ocaml/libs/xl/Makefile                  |   8 +-
 tools/ocaml/libs/xs/Makefile                  |   8 +-
 tools/xenpaging/Makefile                      |  24 +-
 tools/xenstore/Makefile                       |  94 +++-----
 tools/xentop/Makefile                         |  21 +-
 tools/xentrace/Makefile                       |  19 +-
 stubdom/xenlibs.mk                            |  13 ++
 tools/libfsimage/Rules.mk                     |  26 +--
 tools/libfsimage/common.mk                    |  11 +
 tools/libs/libs.mk                            |  17 +-
 tools/libs/guest/xg_offline_page.c            |   2 +-
 tools/ocaml/Makefile.rules                    |   2 +-
 .gitignore                                    |  35 ---
 tools/console/client/.gitignore               |   1 +
 tools/console/daemon/.gitignore               |   1 +
 tools/fuzz/libelf/.gitignore                  |   2 +
 .../fuzz/x86_instruction_emulator/.gitignore  |   7 +
 tools/libs/.gitignore                         |   2 +
 tools/libs/call/Makefile.common               |   6 +
 tools/libs/ctrl/Makefile.common               |  44 ++++
 tools/libs/devicemodel/Makefile.common        |   6 +
 tools/libs/evtchn/Makefile.common             |   6 +
 tools/libs/foreignmemory/Makefile.common      |   6 +
 tools/libs/gnttab/Makefile.common             |   8 +
 tools/libs/guest/Makefile.common              |  84 +++++++
 tools/libs/stat/bindings/swig/perl/.empty     |   1 -
 tools/libs/stat/bindings/swig/python/.empty   |   1 -
 tools/libs/toolcore/Makefile.common           |   1 +
 tools/libs/toollog/Makefile.common            |   2 +
 tools/xenstore/Makefile.common                |  33 +++
 79 files changed, 732 insertions(+), 824 deletions(-)
 create mode 100644 tools/console/client/Makefile
 create mode 100644 tools/console/daemon/Makefile
 create mode 100644 stubdom/xenlibs.mk
 create mode 100644 tools/libfsimage/common.mk
 create mode 100644 tools/console/client/.gitignore
 create mode 100644 tools/console/daemon/.gitignore
 create mode 100644 tools/fuzz/libelf/.gitignore
 create mode 100644 tools/fuzz/x86_instruction_emulator/.gitignore
 create mode 100644 tools/libs/call/Makefile.common
 create mode 100644 tools/libs/ctrl/Makefile.common
 create mode 100644 tools/libs/devicemodel/Makefile.common
 create mode 100644 tools/libs/evtchn/Makefile.common
 create mode 100644 tools/libs/foreignmemory/Makefile.common
 create mode 100644 tools/libs/gnttab/Makefile.common
 create mode 100644 tools/libs/guest/Makefile.common
 delete mode 100644 tools/libs/stat/bindings/swig/perl/.empty
 delete mode 100644 tools/libs/stat/bindings/swig/python/.empty
 create mode 100644 tools/libs/toolcore/Makefile.common
 create mode 100644 tools/libs/toollog/Makefile.common
 create mode 100644 tools/xenstore/Makefile.common

-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Fri Feb 25 15:13:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 15:13:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279180.476788 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcHz-0007Wi-Sd; Fri, 25 Feb 2022 15:13:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279180.476788; Fri, 25 Feb 2022 15:13:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcHz-0007Wb-Oc; Fri, 25 Feb 2022 15:13:47 +0000
Received: by outflank-mailman (input) for mailman id 279180;
 Fri, 25 Feb 2022 15:13:46 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=E0Ll=TI=citrix.com=prvs=04808661d=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nNcHy-0007Bf-43
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 15:13:46 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 84f32f10-964d-11ec-8eb9-a37418f5ba1a;
 Fri, 25 Feb 2022 16:13:44 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 84f32f10-964d-11ec-8eb9-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645802024;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=5eg0u8Tr2A+J7E6dTFFsvBCkPDf1mtYo9cEvKklzXuc=;
  b=BkNN56BgxF87OvJE7Ndl5wNCbNfvTvUh0yRktHS3w7elYZc5uuEjsQqb
   n1WVQoENhFWshThtjewpnU22YPE87OV/LknyhaWI/3Bf7KXx5JgaadqdI
   XI9DEnzMJtY+VOOnSeys6NW9V9k3wXPbW6d18xtnk/9vutunT9sG7FYD2
   s=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 65000277
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:nYATfKPWRRNaTgDvrR2Jl8FynXyQoLVcMsEvi/4bfWQNrUog02dSz
 GRLX22EOfaKYGegKN9wPI7g9UJXsJHcyoRjGQto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFcMpBsJ00o5wbZj2NMw27BVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zy
 4p2sp+sZAETNYrVw89CThAHTAcuIvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALJc/3PIQZqzd4wCvQF/oOSpHfWaTao9Rf2V/cg+gQQK6GP
 5BGNlKDajztTTxENkgsEa4kkcGBolnkcSxcjWK88P9fD2/7k1UqjemF3MDuUseRWcxfk0Kcp
 2TH12f0GBcXMJqY0zXt2m2orv/Cm2X8Qo16PL+l8v9nhnWDy2pVDwcZPXOrrP/8hkOgVtZ3L
 00P5jFovaU07FasTNT2Q1u/unHslhwWVsdUEuY6wBqQ0aeS6AGcblXoVRYYNoZg7pVvA2V3i
 BnZxLsFGACDrpWWFkma9au5qwm5HjFOBjAfbHBba1satoyLTJ4IsjrDSdNqEaiQh9LzGC3tz
 z3ikBXSl4n/nuZQifzloAmvbyaE48GQE1Vrvlm/sneNs1shDLNJcbBE/rQyARxoCI+CBmeMs
 3Ef8yR1xLBfVMrd/MBhrQhkIV1I2xpnGGGN6bKMN8N4n9hIx5JFVdoBiN2ZDB00WvvogRezP
 CfuVfp5vfe/xkeCY65teJ6WAM8316XmHtmNfqmKMocRPsEtKVffpHkGiausM4bFyhlEfUYXY
 8rzTCpRJSxCVfQPIMSeHY/xLoPHNghhnDiOFPgXPjys0KaEZW79dFv2GADmUwzN14vd+F+92
 48Gb6OikkwDOMWjMni/2dNCdjgicClkba0aXuQKL4Zv1CI9Qzp/YxIQqJt8E7FYc1N9zb+Zr
 ingARYDkDISRxTvcG23V5yqU5u3Nb4XkJ7xFXVE0YqAs5T7XbuS0Q==
IronPort-HdrOrdr: A9a23:kUcsQ6s9ODr1zToVJZPIQ0Ow7skDTtV00zEX/kB9WHVpmszxra
 6TdZMgpHnJYVcqKQkdcL+7WJVoLUmxyXcx2/h1AV7AZniAhILLFvAA0WKK+VSJcEeSygce79
 YFT0EXMqyIMbEQt6fHCWeDfOrIuOP3kpyVuQ==
X-IronPort-AV: E=Sophos;i="5.90,136,1643691600"; 
   d="scan'208";a="65000277"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@citrix.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, "Jan
 Beulich" <jbeulich@suse.com>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Subject: [XEN PATCH v2 05/29] tools/fuzz/libelf: rework makefile
Date: Fri, 25 Feb 2022 15:12:57 +0000
Message-ID: <20220225151321.44126-6-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220225151321.44126-1-anthony.perard@citrix.com>
References: <20220225151321.44126-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

Rename ELF_LIB_OBJS to LIBELF_OBJS as to have the same name as in
libs/guest/.

Replace "-I" by "-iquote".

Remove the use of "vpath". It will not works when we will convert this
makefile to subdirmk. Instead, we create symlinks to the source files.

Since we are creating a new .gitignore for the links, also move the
existing entry to it.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---

Notes:
    v2:
    - create a per-directory .gitignore to add new entry and existing one

 tools/fuzz/libelf/Makefile   | 21 ++++++++++-----------
 .gitignore                   |  1 -
 tools/fuzz/libelf/.gitignore |  2 ++
 3 files changed, 12 insertions(+), 12 deletions(-)
 create mode 100644 tools/fuzz/libelf/.gitignore

diff --git a/tools/fuzz/libelf/Makefile b/tools/fuzz/libelf/Makefile
index 9eb30ee40c..9211f75951 100644
--- a/tools/fuzz/libelf/Makefile
+++ b/tools/fuzz/libelf/Makefile
@@ -1,25 +1,24 @@
 XEN_ROOT = $(CURDIR)/../../..
 include $(XEN_ROOT)/tools/Rules.mk
 
-# libelf fuzz target
-vpath %.c ../../../xen/common/libelf
-CFLAGS += -I../../../xen/common/libelf
-ELF_SRCS-y += libelf-tools.c libelf-loader.c libelf-dominfo.c
-ELF_LIB_OBJS := $(patsubst %.c,%.o,$(ELF_SRCS-y))
+LIBELF_OBJS := libelf-tools.o libelf-loader.o libelf-dominfo.o
 
-$(patsubst %.c,%.o,$(ELF_SRCS-y)): CFLAGS += -Wno-pointer-sign
-
-$(ELF_LIB_OBJS): CFLAGS += -DFUZZ_NO_LIBXC $(CFLAGS_xeninclude)
+CFLAGS += -iquote ../../../xen/common/libelf
+$(LIBELF_OBJS): CFLAGS += -Wno-pointer-sign
+$(LIBELF_OBJS): CFLAGS += -DFUZZ_NO_LIBXC $(CFLAGS_xeninclude)
 
 libelf-fuzzer.o: CFLAGS += $(CFLAGS_xeninclude)
 
-libelf.a: libelf-fuzzer.o $(ELF_LIB_OBJS)
+$(LIBELF_OBJS:.o=.c): libelf-%.c: ../../../xen/common/libelf/libelf-%.c FORCE
+	ln -nsf $< $@
+
+libelf.a: libelf-fuzzer.o $(LIBELF_OBJS)
 	$(AR) rc $@ $^
 
 .PHONY: libelf-fuzzer-all
 libelf-fuzzer-all: libelf.a libelf-fuzzer.o
 
-afl-libelf-fuzzer: afl-libelf-fuzzer.o libelf-fuzzer.o $(ELF_LIB_OBJS)
+afl-libelf-fuzzer: afl-libelf-fuzzer.o libelf-fuzzer.o $(LIBELF_OBJS)
 	$(CC) $(CFLAGS) $^ -o $@
 
 # Common targets
@@ -31,7 +30,7 @@ distclean: clean
 
 .PHONY: clean
 clean:
-	rm -f *.o .*.d *.a *-libelf-fuzzer
+	rm -f *.o .*.d *.a *-libelf-fuzzer $(LIBELF_OBJS:.o=.c)
 
 .PHONY: install
 install: all
diff --git a/.gitignore b/.gitignore
index 4e2a850f94..fb29d42342 100644
--- a/.gitignore
+++ b/.gitignore
@@ -194,7 +194,6 @@ tools/flask/utils/flask-loadpolicy
 tools/flask/utils/flask-setenforce
 tools/flask/utils/flask-set-bool
 tools/flask/utils/flask-label-pci
-tools/fuzz/libelf/afl-libelf-fuzzer
 tools/fuzz/x86_instruction_emulator/asm
 tools/fuzz/x86_instruction_emulator/afl-harness
 tools/fuzz/x86_instruction_emulator/afl-harness-cov
diff --git a/tools/fuzz/libelf/.gitignore b/tools/fuzz/libelf/.gitignore
new file mode 100644
index 0000000000..ed634214c9
--- /dev/null
+++ b/tools/fuzz/libelf/.gitignore
@@ -0,0 +1,2 @@
+/afl-libelf-fuzzer
+/libelf-*.c
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Fri Feb 25 15:13:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 15:13:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279182.476810 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcI2-00085s-FR; Fri, 25 Feb 2022 15:13:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279182.476810; Fri, 25 Feb 2022 15:13:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcI2-00085R-Aj; Fri, 25 Feb 2022 15:13:50 +0000
Received: by outflank-mailman (input) for mailman id 279182;
 Fri, 25 Feb 2022 15:13:49 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=E0Ll=TI=citrix.com=prvs=04808661d=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nNcI0-0007Bf-Pg
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 15:13:49 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 879ce21b-964d-11ec-8eb9-a37418f5ba1a;
 Fri, 25 Feb 2022 16:13:47 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 879ce21b-964d-11ec-8eb9-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645802027;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=+tvgdAnTgDFIQbMFRm+czYIkxCdj45NAL3MUbvPerCo=;
  b=SG+Fv1Hf0KSYHJUJwpZ+Zkd/ZHARVzwHnHWe/Sa9/zvN7HRsDp0hMNJX
   830HmV9VagoWU/6OvzwzIWKrTrDRdhoh07AR0nGckKuPSqLDttt7v1jTp
   OSsn8N7lQ1buFMN5Yx7wUj5FiKQJimsLDzPKURy3ZKyITYcDXJzOyp6M1
   c=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 64998373
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:TEaeMKhcHvuX9+aHKGjzAh4OX161CxAKZh0ujC45NGQN5FlHY01je
 htvXmiEaPnYMDPxedhyboi3pBtTscTVztZgTVdsri81H34b9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M78wIFqtQw24LhWVnQ4
 YmaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV
 efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9
 TlDiXC/YVcoOIndms9NaAlFHS17N7VfoeDBGEHq5KR/z2WeG5ft6/BnDUVwNowE4OdnR2pJ8
 JT0KhhUMErF3bjvhuvmFK883azPL+GyVG8bknhm0THeC+dgWZ3ZSr/GzdRZwC0xloZFGvO2i
 88xN2Y+PUSbPEYn1lE/MLEjp+KGhCjDSCRXmXi3oboL5FTuw1kkuFTqGIWMIYHbLSlPpW6Ho
 krW8mK/BQsVXPSPxDzA/n+yi+vnmSLgRJlUBLC+7uRtglCY2ioUEhJ+aLegiaDn0AjkAYsZc
 hFKvHp1xUQvyKC1Zon8WTmpolXUhQ4BVdZVGfUjsV6L85OBtm51GVM4ZjJGbdUnsuo/Sjory
 kKFkrvVONB/jFGGYSnDr+nJ9FteLQBQdDZfPnFcEWPp9vG++Nlbs/7Zcjp0/EdZZPXRECq4/
 T2FpTNWa1473Z9SjPXTEbwqbluRSnn1ouwdulS/soGNtFoRiGuZi2qAswmzARFodtvxc7V5l
 CJY8/VyFchXZX13qASDQf8WAJai7OufPTvXjDZHRsd9qmvxoiL+JdgIuFmSwXuF1O5eKFcFh
 2eJ5GtsCGJ7ZiP2PcebnarrYyjV8UQQPYu8Da2FBja/SpNwaBWG7ElTib24hAjQfLwXufhnY
 /+zKJ/0ZV5DUPgP5GfmFo81jO5wrghjlDy7eHwO50n+uVZoTCXOEult3ZrnRr1R0Z5oVy2Oq
 4cPb5bRkk4HOAA8CwGOmbMuwZkxBSBTLfjLRwZ/L4Zv/iIO9LkdNsLs
IronPort-HdrOrdr: A9a23:pZEU/aHSMBtPf1+SpLqE4seALOsnbusQ8zAXP0AYc3Nom6uj5q
 WTdZUgpHjJYVkqOU3I9ersBEDiewK/yXcW2+ks1N6ZNWGM0ldARLsSibcKqAePJ8SRzIJgPN
 9bAstDNOE=
X-IronPort-AV: E=Sophos;i="5.90,136,1643691600"; 
   d="scan'208";a="64998373"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@citrix.com>, Wei Liu <wl@xen.org>
Subject: [XEN PATCH v2 08/29] tools/hotplug: cleanup Makefiles
Date: Fri, 25 Feb 2022 15:13:00 +0000
Message-ID: <20220225151321.44126-9-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220225151321.44126-1-anthony.perard@citrix.com>
References: <20220225151321.44126-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

Remove "build" targets.

Use simply expanded variables when recursively expanded variable
aren't needed. (Use ":=" instead of "=".)

Don't check if a directory already exist when installing, just create
it.

Fix $(HOTPLUGPATH), it shouldn't have any double-quote.

Some reindentation.

FreeBSD, "hotplugpath.sh" is already installed by common/.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 tools/hotplug/FreeBSD/Makefile       | 11 +++--------
 tools/hotplug/Linux/Makefile         | 16 ++++++----------
 tools/hotplug/Linux/systemd/Makefile | 16 +++++++---------
 tools/hotplug/NetBSD/Makefile        |  9 +++------
 tools/hotplug/common/Makefile        | 16 ++++++----------
 5 files changed, 25 insertions(+), 43 deletions(-)

diff --git a/tools/hotplug/FreeBSD/Makefile b/tools/hotplug/FreeBSD/Makefile
index de9928cd86..a6552c9884 100644
--- a/tools/hotplug/FreeBSD/Makefile
+++ b/tools/hotplug/FreeBSD/Makefile
@@ -2,18 +2,15 @@ XEN_ROOT = $(CURDIR)/../../..
 include $(XEN_ROOT)/tools/Rules.mk
 
 # Xen script dir and scripts to go there.
-XEN_SCRIPTS = vif-bridge block
+XEN_SCRIPTS := vif-bridge block
 
-XEN_SCRIPT_DATA =
+XEN_SCRIPT_DATA :=
 
-XEN_RCD_PROG = rc.d/xencommons rc.d/xendriverdomain
+XEN_RCD_PROG := rc.d/xencommons rc.d/xendriverdomain
 
 .PHONY: all
 all:
 
-.PHONY: build
-build:
-
 .PHONY: install
 install: install-scripts install-rcd
 
@@ -44,12 +41,10 @@ install-rcd:
 	   do \
 	   $(INSTALL_PROG) $$i $(DESTDIR)$(INITD_DIR); \
 	done
-	$(INSTALL_DATA) ../common/hotplugpath.sh $(DESTDIR)$(XEN_SCRIPT_DIR)
 
 .PHONY: uninstall-rcd
 uninstall-rcd:
 	rm -f $(addprefix $(DESTDIR)$(INITD_DIR)/, $(XEN_RCD_PROG))
-	rm -f $(DESTDIR)$(XEN_SCRIPT_DIR)/hotplugpath.sh
 
 .PHONY: clean
 clean:
diff --git a/tools/hotplug/Linux/Makefile b/tools/hotplug/Linux/Makefile
index 0b1d111d7e..9a7b3a3515 100644
--- a/tools/hotplug/Linux/Makefile
+++ b/tools/hotplug/Linux/Makefile
@@ -2,7 +2,7 @@ XEN_ROOT = $(CURDIR)/../../..
 include $(XEN_ROOT)/tools/Rules.mk
 
 # Xen script dir and scripts to go there.
-XEN_SCRIPTS = vif-bridge
+XEN_SCRIPTS := vif-bridge
 XEN_SCRIPTS += vif-route
 XEN_SCRIPTS += vif-nat
 XEN_SCRIPTS += vif-openvswitch
@@ -22,16 +22,13 @@ XEN_SCRIPTS += launch-xenstore
 
 SUBDIRS-$(CONFIG_SYSTEMD) += systemd
 
-XEN_SCRIPT_DATA = xen-script-common.sh locking.sh logging.sh
+XEN_SCRIPT_DATA := xen-script-common.sh locking.sh logging.sh
 XEN_SCRIPT_DATA += xen-hotplug-common.sh xen-network-common.sh vif-common.sh
 XEN_SCRIPT_DATA += block-common.sh
 
 .PHONY: all
 all: subdirs-all
 
-.PHONY: build
-build:
-
 .PHONY: install
 install: install-initd install-scripts subdirs-install
 
@@ -41,9 +38,9 @@ uninstall: uninstall-initd uninstall-scripts subdirs-uninstall
 # See docs/misc/distro_mapping.txt for INITD_DIR location
 .PHONY: install-initd
 install-initd:
-	[ -d $(DESTDIR)$(INITD_DIR) ] || $(INSTALL_DIR) $(DESTDIR)$(INITD_DIR)
-	[ -d $(DESTDIR)$(SYSCONFIG_DIR) ] || $(INSTALL_DIR) $(DESTDIR)$(SYSCONFIG_DIR)
-	[ -d $(DESTDIR)$(LIBEXEC_BIN) ] || $(INSTALL_DIR) $(DESTDIR)$(LIBEXEC_BIN)
+	$(INSTALL_DIR) $(DESTDIR)$(INITD_DIR)
+	$(INSTALL_DIR) $(DESTDIR)$(SYSCONFIG_DIR)
+	$(INSTALL_DIR) $(DESTDIR)$(LIBEXEC_BIN)
 	$(INSTALL_DATA) init.d/sysconfig.xendomains $(DESTDIR)$(SYSCONFIG_DIR)/xendomains
 	$(INSTALL_DATA) init.d/sysconfig.xencommons $(DESTDIR)$(SYSCONFIG_DIR)/xencommons
 	$(INSTALL_PROG) xendomains $(DESTDIR)$(LIBEXEC_BIN)
@@ -64,8 +61,7 @@ uninstall-initd:
 
 .PHONY: install-scripts
 install-scripts:
-	[ -d $(DESTDIR)$(XEN_SCRIPT_DIR) ] || \
-		$(INSTALL_DIR) $(DESTDIR)$(XEN_SCRIPT_DIR)
+	$(INSTALL_DIR) $(DESTDIR)$(XEN_SCRIPT_DIR)
 	set -e; for i in $(XEN_SCRIPTS); \
 	    do \
 	    $(INSTALL_PROG) $$i $(DESTDIR)$(XEN_SCRIPT_DIR); \
diff --git a/tools/hotplug/Linux/systemd/Makefile b/tools/hotplug/Linux/systemd/Makefile
index a5d41d86ef..26df2a43b1 100644
--- a/tools/hotplug/Linux/systemd/Makefile
+++ b/tools/hotplug/Linux/systemd/Makefile
@@ -1,12 +1,12 @@
 XEN_ROOT = $(CURDIR)/../../../..
 include $(XEN_ROOT)/tools/Rules.mk
 
-XEN_SYSTEMD_MODULES = xen.conf
+XEN_SYSTEMD_MODULES := xen.conf
 
-XEN_SYSTEMD_MOUNT =  proc-xen.mount
+XEN_SYSTEMD_MOUNT := proc-xen.mount
 XEN_SYSTEMD_MOUNT += var-lib-xenstored.mount
 
-XEN_SYSTEMD_SERVICE  = xenstored.service
+XEN_SYSTEMD_SERVICE := xenstored.service
 XEN_SYSTEMD_SERVICE += xenconsoled.service
 XEN_SYSTEMD_SERVICE += xen-qemu-dom0-disk-backend.service
 XEN_SYSTEMD_SERVICE += xendomains.service
@@ -14,7 +14,7 @@ XEN_SYSTEMD_SERVICE += xen-watchdog.service
 XEN_SYSTEMD_SERVICE += xen-init-dom0.service
 XEN_SYSTEMD_SERVICE += xendriverdomain.service
 
-ALL_XEN_SYSTEMD =	$(XEN_SYSTEMD_MODULES)  \
+ALL_XEN_SYSTEMD :=	$(XEN_SYSTEMD_MODULES)  \
 			$(XEN_SYSTEMD_MOUNT)	\
 			$(XEN_SYSTEMD_SERVICE)
 
@@ -30,10 +30,8 @@ distclean: clean
 
 .PHONY: install
 install: $(ALL_XEN_SYSTEMD)
-	[ -d $(DESTDIR)$(XEN_SYSTEMD_DIR) ] || \
-		$(INSTALL_DIR) $(DESTDIR)$(XEN_SYSTEMD_DIR)
-	[ -d $(DESTDIR)$(XEN_SYSTEMD_MODULES_LOAD) ] || \
-		$(INSTALL_DIR) $(DESTDIR)$(XEN_SYSTEMD_MODULES_LOAD)
+	$(INSTALL_DIR) $(DESTDIR)$(XEN_SYSTEMD_DIR)
+	$(INSTALL_DIR) $(DESTDIR)$(XEN_SYSTEMD_MODULES_LOAD)
 	$(INSTALL_DATA) *.service $(DESTDIR)$(XEN_SYSTEMD_DIR)
 	$(INSTALL_DATA) *.mount $(DESTDIR)$(XEN_SYSTEMD_DIR)
 	$(INSTALL_DATA) *.conf $(DESTDIR)$(XEN_SYSTEMD_MODULES_LOAD)
@@ -48,5 +46,5 @@ $(XEN_SYSTEMD_MODULES):
 	rm -f $@.tmp
 	for mod in $(LINUX_BACKEND_MODULES) ; do \
 		echo $$mod ; \
-		done > $@.tmp
+	done > $@.tmp
 	$(call move-if-changed,$@.tmp,$@)
diff --git a/tools/hotplug/NetBSD/Makefile b/tools/hotplug/NetBSD/Makefile
index f909ffa367..1cd3db2ccb 100644
--- a/tools/hotplug/NetBSD/Makefile
+++ b/tools/hotplug/NetBSD/Makefile
@@ -2,22 +2,19 @@ XEN_ROOT = $(CURDIR)/../../..
 include $(XEN_ROOT)/tools/Rules.mk
 
 # Xen script dir and scripts to go there.
-XEN_SCRIPTS =
+XEN_SCRIPTS :=
 XEN_SCRIPTS += locking.sh
 XEN_SCRIPTS += block
 XEN_SCRIPTS += vif-bridge
 XEN_SCRIPTS += vif-ip
 XEN_SCRIPTS += qemu-ifup
 
-XEN_SCRIPT_DATA =
-XEN_RCD_PROG = rc.d/xencommons rc.d/xendomains rc.d/xen-watchdog rc.d/xendriverdomain
+XEN_SCRIPT_DATA :=
+XEN_RCD_PROG := rc.d/xencommons rc.d/xendomains rc.d/xen-watchdog rc.d/xendriverdomain
 
 .PHONY: all
 all:
 
-.PHONY: build
-build:
-
 .PHONY: install
 install: install-scripts install-rcd
 
diff --git a/tools/hotplug/common/Makefile b/tools/hotplug/common/Makefile
index ef48bfacc9..e8a8dbea6c 100644
--- a/tools/hotplug/common/Makefile
+++ b/tools/hotplug/common/Makefile
@@ -1,22 +1,19 @@
 XEN_ROOT = $(CURDIR)/../../..
 include $(XEN_ROOT)/tools/Rules.mk
 
-HOTPLUGPATH="hotplugpath.sh"
+HOTPLUGPATH := hotplugpath.sh
 
 # OS-independent hotplug scripts go in this directory
 
 # Xen scripts to go there.
-XEN_SCRIPTS =
-XEN_SCRIPT_DATA = $(HOTPLUGPATH)
+XEN_SCRIPTS :=
+XEN_SCRIPT_DATA := $(HOTPLUGPATH)
 
 genpath-target = $(call buildmakevars2file,$(HOTPLUGPATH))
 $(eval $(genpath-target))
 
 .PHONY: all
-all: build
-
-.PHONY: build
-build: $(HOTPLUGPATH)
+all: $(HOTPLUGPATH)
 
 .PHONY: install
 install: install-scripts
@@ -25,9 +22,8 @@ install: install-scripts
 uninstall: uninstall-scripts
 
 .PHONY: install-scripts
-install-scripts: build
-	[ -d $(DESTDIR)$(XEN_SCRIPT_DIR) ] || \
-		$(INSTALL_DIR) $(DESTDIR)$(XEN_SCRIPT_DIR)
+install-scripts: all
+	$(INSTALL_DIR) $(DESTDIR)$(XEN_SCRIPT_DIR)
 	set -e; for i in $(XEN_SCRIPTS); \
 	   do \
 	   $(INSTALL_PROG) $$i $(DESTDIR)$(XEN_SCRIPT_DIR); \
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Fri Feb 25 15:13:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 15:13:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279183.476822 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcI3-0008PQ-W0; Fri, 25 Feb 2022 15:13:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279183.476822; Fri, 25 Feb 2022 15:13:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcI3-0008NN-Ku; Fri, 25 Feb 2022 15:13:51 +0000
Received: by outflank-mailman (input) for mailman id 279183;
 Fri, 25 Feb 2022 15:13:50 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=E0Ll=TI=citrix.com=prvs=04808661d=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nNcI2-0007Bf-FK
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 15:13:50 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 87999e26-964d-11ec-8eb9-a37418f5ba1a;
 Fri, 25 Feb 2022 16:13:49 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 87999e26-964d-11ec-8eb9-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645802028;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=Itv0TYjJaWvZTLhYwIDcVR+kB+4hcfXSmAszpJaqRIw=;
  b=E0BA9QO3L+to8fOVx0uIWCjXSqGyG0PnVEPKKd5kxjkvzElXPpjyHuCp
   MbxHEbK5zzFQLHz6Jg87jPE7poALanePy/90sBL+gSYxY20xqQayggyjo
   y5/ybP9oAqcV3NzcBY2xT1WrwGbdJNc8nIDoyElRMdzNoj7uEW5g56Z0v
   Y=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 65407512
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:33+IyK61u+7MofRIySmgkwxRtDbHchMFZxGqfqrLsTDasY5as4F+v
 mYYUWGHOP+IYGbyctl0Pdm09UtU65PWyNZjSVNo/Co8Hi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0XqPp8Zj2tQy2YLjXlvX0
 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X
 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx
 umhurTuRUQ0F/f1mt4XTiN0Ixxcfv1Bu+TIdC3XXcy7lyUqclPpyvRqSko3IZcZ6qB8BmQmG
 f4wcW5XKErZ3qTvnez9GrIEascLdaEHOKsWvG1gyjfIS+4rW5nZT43B5MNC3Sd2jcdLdRrbT
 5RENWIwMU2aC/FJEnlJT7xhp8Kuv2fESz5alV6siqxmvkGGmWSd15CyaYGIK7RmX/59gUKwt
 m/AuWPjDXkyOdiSzzPD73ytg/PUkD3ycIUIHba8+7hhh1j77nweDlgaWEW2pdG9i1WiQJRPJ
 koM4C0soKMuskuxQbHAswaQ+SDe+ERGApwJTrN8uFrlJrfoDxixWGRHUxcbUd4cvtIMaQwX9
 BzZmJCyCmk62FGKck61+rCRpDK0HCEaK24eeCMJJTc4D8nfTJIb1UyWEIs6eEKhppisQGyrn
 WjWxMQrr+hL1aY2O7OHEUcrat5GjrzAVUYL6wreRQpJBSspNdf+N+REBbU2hMuszbp1rHHd7
 RDoeODEtYji6K1hcgTXEY3h+5nzup643MX02wIHInXY323FF4SfVY5R+ipiA0xiL9wJfzTkC
 GeK518Mu8MKYCbyNfcvC25UNyjM5fKxfTgCfqqJBuein7ArLFPXlM2QTRT4M5/RfLgEzvhkZ
 MbznTeEBncGE6V3pAdatM9GuYLHMhsWnDuJLbiilkzP+ePHOBa9FOdUWHPTP7tRxP7V/23oH
 yN3apLiJ+N3C7alPEE6MOc7cDg3EJTMLcuu+pwPK7XaeVIO9aNII6a5/I7NsrdNx8x9/tokN
 FnnBye0FHKXaaX7FDi3
IronPort-HdrOrdr: A9a23:eIo/va5jHKV2WBVJ4QPXwPDXdLJyesId70hD6qhwISY6TiX+rb
 HJoB17726NtN9/YhEdcLy7VJVoBEmskKKdgrNhWotKPjOW21dARbsKheCJrgEIWReOktK1vZ
 0QCpSWY+eQMbEVt6nHCXGDYrQd/OU=
X-IronPort-AV: E=Sophos;i="5.90,136,1643691600"; 
   d="scan'208";a="65407512"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@citrix.com>, Elena Ufimtseva
	<elena.ufimtseva@oracle.com>, Wei Liu <wl@xen.org>
Subject: [XEN PATCH v2 02/29] tools/debugger/gdbsx: Fix and cleanup makefiles
Date: Fri, 25 Feb 2022 15:12:54 +0000
Message-ID: <20220225151321.44126-3-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220225151321.44126-1-anthony.perard@citrix.com>
References: <20220225151321.44126-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

gdbsx/:
  - Make use of subdir facility for the "clean" target.
  - No need to remove the *.a, they aren't in this dir.
  - Avoid calling "distclean" in subdirs as "distclean" targets do only
    call "clean", and the "clean" also runs "clean" in subdirs.
  - Avoid the need to make "gx_all.a" and "xg_all.a" in the "all"
    recipe by forcing make to check for update of "xg/xg_all.a" and
    "gx/gx_all.a" by having "FORCE" as prerequisite. Now, when making
    "gdbsx", make will recurse even when both *.a already exist.
  - List target in $(TARGETS).

gdbsx/*/:
  - Fix dependency on *.h.
  - Remove some dead code.
  - List targets in $(TARGETS).
  - Remove "build" target.
  - Cleanup "clean" targets.
  - remove comments about the choice of "ar" instead of "ld"
  - Use "$(AR)" instead of plain "ar".

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---

Notes:
    v2:
    - also replace plain "ar" by "$(AR)"

 tools/debugger/gdbsx/Makefile    | 20 ++++++++++----------
 tools/debugger/gdbsx/gx/Makefile | 15 +++++++--------
 tools/debugger/gdbsx/xg/Makefile | 25 +++++++------------------
 3 files changed, 24 insertions(+), 36 deletions(-)

diff --git a/tools/debugger/gdbsx/Makefile b/tools/debugger/gdbsx/Makefile
index 5571450a89..4aaf427c45 100644
--- a/tools/debugger/gdbsx/Makefile
+++ b/tools/debugger/gdbsx/Makefile
@@ -1,20 +1,20 @@
 XEN_ROOT = $(CURDIR)/../../..
 include ./Rules.mk
 
+SUBDIRS-y += gx
+SUBDIRS-y += xg
+
+TARGETS := gdbsx
+
 .PHONY: all
-all:
-	$(MAKE) -C gx
-	$(MAKE) -C xg
-	$(MAKE) gdbsx
+all: $(TARGETS)
 
 .PHONY: clean
-clean:
-	rm -f xg_all.a gx_all.a gdbsx
-	set -e; for d in xg gx; do $(MAKE) -C $$d clean; done
+clean: subdirs-clean
+	rm -f $(TARGETS)
 
 .PHONY: distclean
 distclean: clean
-	set -e; for d in xg gx; do $(MAKE) -C $$d distclean; done
 
 .PHONY: install
 install: all
@@ -28,7 +28,7 @@ uninstall:
 gdbsx: gx/gx_all.a xg/xg_all.a 
 	$(CC) $(LDFLAGS) -o $@ $^
 
-xg/xg_all.a:
+xg/xg_all.a: FORCE
 	$(MAKE) -C xg
-gx/gx_all.a:
+gx/gx_all.a: FORCE
 	$(MAKE) -C gx
diff --git a/tools/debugger/gdbsx/gx/Makefile b/tools/debugger/gdbsx/gx/Makefile
index 3b8467f799..e9859aea9c 100644
--- a/tools/debugger/gdbsx/gx/Makefile
+++ b/tools/debugger/gdbsx/gx/Makefile
@@ -2,21 +2,20 @@ XEN_ROOT = $(CURDIR)/../../../..
 include ../Rules.mk
 
 GX_OBJS := gx_comm.o gx_main.o gx_utils.o gx_local.o
-GX_HDRS := $(wildcard *.h)
+
+TARGETS := gx_all.a
 
 .PHONY: all
-all: gx_all.a
+all: $(TARGETS)
 
 .PHONY: clean
 clean:
-	rm -rf gx_all.a *.o .*.d
+	rm -f *.o $(TARGETS) $(DEPS_RM)
 
 .PHONY: distclean
 distclean: clean
 
-#%.o: %.c $(GX_HDRS) Makefile
-#	$(CC) -c $(CFLAGS) -o $@ $<
-
-gx_all.a: $(GX_OBJS) Makefile $(GX_HDRS)
-	ar cr $@ $(GX_OBJS)        # problem with ld using -m32 
+gx_all.a: $(GX_OBJS) Makefile
+	$(AR) cr $@ $(GX_OBJS)
 
+-include $(DEPS_INCLUDE)
diff --git a/tools/debugger/gdbsx/xg/Makefile b/tools/debugger/gdbsx/xg/Makefile
index acdcddf0d5..05325d6d81 100644
--- a/tools/debugger/gdbsx/xg/Makefile
+++ b/tools/debugger/gdbsx/xg/Makefile
@@ -1,35 +1,24 @@
 XEN_ROOT = $(CURDIR)/../../../..
 include ../Rules.mk
 
-XG_HDRS := xg_public.h 
 XG_OBJS := xg_main.o 
 
 CFLAGS += -D__XEN_TOOLS__
 CFLAGS += $(CFLAGS_xeninclude)
 
+TARGETS := xg_all.a
 
 .PHONY: all
-all: build
+all: $(TARGETS)
 
-.PHONY: build
-build: xg_all.a $(XG_HDRS) $(XG_OBJS) Makefile
-# build: mk-symlinks xg_all.a $(XG_HDRS) $(XG_OBJS) Makefile
-# build: mk-symlinks xg_all.a
-
-xg_all.a: $(XG_OBJS) Makefile $(XG_HDRS)
-	ar cr $@ $(XG_OBJS)    # problems using -m32 in ld 
-#	$(LD) -b elf32-i386 $(LDFLAGS) -r -o $@ $^
-#	$(CC) -m32 -c -o $@ $^
-
-# xg_main.o: xg_main.c Makefile $(XG_HDRS)
-#$(CC) -c $(CFLAGS) -o $@ $<
-
-# %.o: %.c $(XG_HDRS) Makefile  -- doesn't work as it won't overwrite Rules.mk
-#%.o: %.c       -- doesn't recompile when .c changed
+xg_all.a: $(XG_OBJS) Makefile
+	$(AR) cr $@ $(XG_OBJS)
 
 .PHONY: clean
 clean:
-	rm -rf xen xg_all.a $(XG_OBJS)  .*.d
+	rm -f $(TARGETS) $(XG_OBJS) $(DEPS_RM)
 
 .PHONY: distclean
 distclean: clean
+
+-include $(DEPS_INCLUDE)
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Fri Feb 25 15:13:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 15:13:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279184.476833 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcI5-0000Jn-JE; Fri, 25 Feb 2022 15:13:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279184.476833; Fri, 25 Feb 2022 15:13:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcI5-0000JJ-Cd; Fri, 25 Feb 2022 15:13:53 +0000
Received: by outflank-mailman (input) for mailman id 279184;
 Fri, 25 Feb 2022 15:13:51 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=E0Ll=TI=citrix.com=prvs=04808661d=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nNcI3-0007Bf-D6
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 15:13:51 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 89003833-964d-11ec-8eb9-a37418f5ba1a;
 Fri, 25 Feb 2022 16:13:50 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 89003833-964d-11ec-8eb9-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645802029;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=vEj0fZWMl+R77ejhJIT+1IS4qvoqXeRC/IzY/VGgI/8=;
  b=PubzSiPEqzLM6y2qEjQkXxtemIuVSB681AKSO6dAEOVu9+vmhT53gpnv
   Owb4pm55w4vR0Wre/3k1WeNUByUzSnNosCRCGV3uYNJAssi6DH4smSOAz
   vtKLD7oZBDR9yCCPQBHDbUXbL6AfUGgx4izGFA3sm15oTKmf/b7sl10il
   c=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 65000282
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:SOsCnq2e5JUL5bNoy/bD5bhxkn2cJEfYwER7XKvMYLTBsI5bpzNTn
 DQfUDzTaPmCamanfdtzYY/l80pUucfcn4U1SFdkpC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EE/NtTo5w7Rj2tQy3IDja++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /1jiZO0RgxwY5fFv9o+CDBkORNbA+pvreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHiOp8fvXdxiynUF/88TbjIQrnQ5M8e1zA17ixLNaiDP
 5JBM2o1BPjGSyxVYgYoFs8mp+mTp2bHcQxil2y4mZNitgA/yyQuieOwYbI5YOeiWsF9jkue4
 GXc8AzREhwccdCS1zeB2natnfPU2zP2XpoIE7+1/eIsh0ecrlH/EzVPCwH9+6PgzBfjBZQPc
 CT45xbCs4AcyEOvQdKkAiexh0Cn5Tcgceh1LaoTvVTlJrXv3y6VAW0NTzhkYdMgtdMrSTFC6
 mJlj+8FFhQ07uTLFCv1GqO86GrrZHNLdTNqiTosEFNdi+QPtr3fmf4mojxLNKeuxuP4Fjjrq
 9xhhHhv3u5D5SLnOkjSwLwmv95OjsSYJuLWzl+ONo5A0u+fTNT0D2BPwQKGhcus1K7DEjG8U
 IEswqByFtwmA5CXjzCqS+4QBryv7PvtGGSC3QMwQ8B9qmz1oybLkWVsDNdWfhYB3iEsI2KBX
 aMukVkJuM870IWCN8ebnL5d++x1lPO9RLwJp9jfb8ZUY4gZSeN01HoGWKJk5Ei0yBJEufhmY
 f+zKJ/wZV5HWfUP5GfnHI81jO50rh3SMEuOHPgXOTz8iuHADJNUIJ9YWGazghcRt/vV8F2Iq
 I8Eb6NnCXx3CYXDX8UeyqZLRXhiEJTxLcqeRxB/HgJbHjdbJQ==
IronPort-HdrOrdr: A9a23:/P8FrKqY77uZ9uNAHEuoI3oaV5oTeYIsimQD101hICG8cqSj+f
 xG+85rsyMc6QxhIE3I9urhBEDtex/hHNtOkOws1NSZLW7bUQmTXeJfBOLZqlWKcUDDH6xmpM
 NdmsBFeaTN5DNB7PoSjjPWLz9Z+qjkzJyV
X-IronPort-AV: E=Sophos;i="5.90,136,1643691600"; 
   d="scan'208";a="65000282"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@citrix.com>, Wei Liu <wl@xen.org>
Subject: [XEN PATCH v2 09/29] tools/libfsimage: Cleanup makefiles
Date: Fri, 25 Feb 2022 15:13:01 +0000
Message-ID: <20220225151321.44126-10-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220225151321.44126-1-anthony.perard@citrix.com>
References: <20220225151321.44126-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

Remove the need for "fs-*" targets by creating a "common.mk" which
have flags that are common to libfsimage/common/ and the other
libfsimages/*/ directories.

In common.mk, make $(PIC_OBJS) a recursively expanded variable so it
doesn't matter where $(LIB_SRCS-y) is defined, and remove the extra
$(PIC_OBJS) from libfsimage/common/Makefile.

Use a $(TARGETS) variable to list things to be built. And $(TARGETS)
can be use in the clean target in common.mk.

iso9660/:
    Remove the explicit dependency between fsys_iso9660.c and
    iso9660.h, this is handled automaticaly by the .*.d dependency files,
    and iso9660.h already exist.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 tools/libfsimage/common/Makefile     | 11 +++--------
 tools/libfsimage/ext2fs-lib/Makefile |  9 ---------
 tools/libfsimage/ext2fs/Makefile     |  9 ---------
 tools/libfsimage/fat/Makefile        |  9 ---------
 tools/libfsimage/iso9660/Makefile    | 11 -----------
 tools/libfsimage/reiserfs/Makefile   |  9 ---------
 tools/libfsimage/ufs/Makefile        |  9 ---------
 tools/libfsimage/xfs/Makefile        |  9 ---------
 tools/libfsimage/zfs/Makefile        |  9 ---------
 tools/libfsimage/Rules.mk            | 26 ++++++++------------------
 tools/libfsimage/common.mk           | 11 +++++++++++
 11 files changed, 22 insertions(+), 100 deletions(-)
 create mode 100644 tools/libfsimage/common.mk

diff --git a/tools/libfsimage/common/Makefile b/tools/libfsimage/common/Makefile
index 0c5a34baea..79f8cfd28e 100644
--- a/tools/libfsimage/common/Makefile
+++ b/tools/libfsimage/common/Makefile
@@ -1,5 +1,5 @@
 XEN_ROOT = $(CURDIR)/../../..
-include $(XEN_ROOT)/tools/libfsimage/Rules.mk
+include $(XEN_ROOT)/tools/libfsimage/common.mk
 
 MAJOR := $(shell $(XEN_ROOT)/version.sh $(XEN_ROOT)/xen/Makefile)
 MINOR = 0
@@ -13,12 +13,10 @@ LDFLAGS += $(PTHREAD_LDFLAGS)
 
 LIB_SRCS-y = fsimage.c fsimage_plugin.c fsimage_grub.c
 
-PIC_OBJS := $(patsubst %.c,%.opic,$(LIB_SRCS-y))
-
-LIB = libxenfsimage.so libxenfsimage.so.$(MAJOR) libxenfsimage.so.$(MAJOR).$(MINOR)
+TARGETS = libxenfsimage.so libxenfsimage.so.$(MAJOR) libxenfsimage.so.$(MAJOR).$(MINOR)
 
 .PHONY: all
-all: $(LIB)
+all: $(TARGETS)
 
 .PHONY: install
 install: all
@@ -40,9 +38,6 @@ uninstall:
 	rm -f $(DESTDIR)$(libdir)/libxenfsimage.so.$(MAJOR)
 	rm -f $(DESTDIR)$(libdir)/libxenfsimage.so.$(MAJOR).$(MINOR)
 
-clean distclean::
-	rm -f $(LIB)
-
 libxenfsimage.so: libxenfsimage.so.$(MAJOR)
 	ln -sf $< $@
 libxenfsimage.so.$(MAJOR): libxenfsimage.so.$(MAJOR).$(MINOR)
diff --git a/tools/libfsimage/ext2fs-lib/Makefile b/tools/libfsimage/ext2fs-lib/Makefile
index 431a79068e..b9b560df75 100644
--- a/tools/libfsimage/ext2fs-lib/Makefile
+++ b/tools/libfsimage/ext2fs-lib/Makefile
@@ -9,13 +9,4 @@ FS_LIBDEPS = $(EXTFS_LIBS)
 # Include configure output (config.h)
 CFLAGS += -include $(XEN_ROOT)/tools/config.h
 
-.PHONY: all
-all: fs-all
-
-.PHONY: install
-install: fs-install
-
-.PHONY: uninstall
-uninstall: fs-uninstall
-
 include $(XEN_ROOT)/tools/libfsimage/Rules.mk
diff --git a/tools/libfsimage/ext2fs/Makefile b/tools/libfsimage/ext2fs/Makefile
index c62ae359ac..fe01f98148 100644
--- a/tools/libfsimage/ext2fs/Makefile
+++ b/tools/libfsimage/ext2fs/Makefile
@@ -4,13 +4,4 @@ LIB_SRCS-y = fsys_ext2fs.c
 
 FS = ext2fs
 
-.PHONY: all
-all: fs-all
-
-.PHONY: install
-install: fs-install
-
-.PHONY: uninstall
-uninstall: fs-uninstall
-
 include $(XEN_ROOT)/tools/libfsimage/Rules.mk
diff --git a/tools/libfsimage/fat/Makefile b/tools/libfsimage/fat/Makefile
index 7ee5e7588d..58bcc0751d 100644
--- a/tools/libfsimage/fat/Makefile
+++ b/tools/libfsimage/fat/Makefile
@@ -4,13 +4,4 @@ LIB_SRCS-y = fsys_fat.c
 
 FS = fat
 
-.PHONY: all
-all: fs-all
-
-.PHONY: install
-install: fs-install
-
-.PHONY: uninstall
-uninstall: fs-uninstall
-
 include $(XEN_ROOT)/tools/libfsimage/Rules.mk
diff --git a/tools/libfsimage/iso9660/Makefile b/tools/libfsimage/iso9660/Makefile
index bc86baf2c0..acf3164046 100644
--- a/tools/libfsimage/iso9660/Makefile
+++ b/tools/libfsimage/iso9660/Makefile
@@ -4,15 +4,4 @@ LIB_SRCS-y = fsys_iso9660.c
 
 FS = iso9660
 
-.PHONY: all
-all: fs-all
-
-.PHONY: install
-install: fs-install
-
-.PHONY: uninstall
-uninstall: fs-uninstall
-
-fsys_iso9660.c: iso9660.h
-
 include $(XEN_ROOT)/tools/libfsimage/Rules.mk
diff --git a/tools/libfsimage/reiserfs/Makefile b/tools/libfsimage/reiserfs/Makefile
index 5acfedf25e..42b751e007 100644
--- a/tools/libfsimage/reiserfs/Makefile
+++ b/tools/libfsimage/reiserfs/Makefile
@@ -4,13 +4,4 @@ LIB_SRCS-y = fsys_reiserfs.c
 
 FS = reiserfs
 
-.PHONY: all
-all: fs-all
-
-.PHONY: install
-install: fs-install
-
-.PHONY: uninstall
-uninstall: fs-uninstall
-
 include $(XEN_ROOT)/tools/libfsimage/Rules.mk
diff --git a/tools/libfsimage/ufs/Makefile b/tools/libfsimage/ufs/Makefile
index f32b9178bd..cca4f0a588 100644
--- a/tools/libfsimage/ufs/Makefile
+++ b/tools/libfsimage/ufs/Makefile
@@ -4,13 +4,4 @@ LIB_SRCS-y = fsys_ufs.c
 
 FS = ufs
 
-.PHONY: all
-all: fs-all
-
-.PHONY: install
-install: fs-install
-
-.PHONY: uninstall
-uninstall: fs-uninstall
-
 include $(XEN_ROOT)/tools/libfsimage/Rules.mk
diff --git a/tools/libfsimage/xfs/Makefile b/tools/libfsimage/xfs/Makefile
index 54eeb6e35e..ebac7baf14 100644
--- a/tools/libfsimage/xfs/Makefile
+++ b/tools/libfsimage/xfs/Makefile
@@ -4,13 +4,4 @@ LIB_SRCS-y = fsys_xfs.c
 
 FS = xfs
 
-.PHONY: all
-all: fs-all
-
-.PHONY: install
-install: fs-install
-
-.PHONY: uninstall
-uninstall: fs-uninstall
-
 include $(XEN_ROOT)/tools/libfsimage/Rules.mk
diff --git a/tools/libfsimage/zfs/Makefile b/tools/libfsimage/zfs/Makefile
index 084e5ec08d..434a9c3580 100644
--- a/tools/libfsimage/zfs/Makefile
+++ b/tools/libfsimage/zfs/Makefile
@@ -28,13 +28,4 @@ LIB_SRCS-y = zfs_lzjb.c zfs_sha256.c zfs_fletcher.c fsi_zfs.c fsys_zfs.c
 
 FS = zfs
 
-.PHONY: all
-all: fs-all
-
-.PHONY: install
-install: fs-install
-
-.PHONY: uninstall
-uninstall: fs-uninstall
-
 include $(XEN_ROOT)/tools/libfsimage/Rules.mk
diff --git a/tools/libfsimage/Rules.mk b/tools/libfsimage/Rules.mk
index bb6d42abb4..cf37d6cb0d 100644
--- a/tools/libfsimage/Rules.mk
+++ b/tools/libfsimage/Rules.mk
@@ -1,25 +1,18 @@
-include $(XEN_ROOT)/tools/Rules.mk
-
-CFLAGS += -Wno-unknown-pragmas -I$(XEN_ROOT)/tools/libfsimage/common/ -DFSIMAGE_FSDIR=\"$(FSDIR)\"
-CFLAGS += -Werror -D_GNU_SOURCE
-LDFLAGS += -L../common/
-
-PIC_OBJS := $(patsubst %.c,%.opic,$(LIB_SRCS-y))
-
-FSDIR = $(libdir)/xenfsimage
+include $(XEN_ROOT)/tools/libfsimage/common.mk
 
 FSLIB = fsimage.so
+TARGETS += $(FSLIB)
 
-.PHONY: fs-all
-fs-all: $(FSLIB)
+.PHONY: all
+all: $(TARGETS)
 
-.PHONY: fs-install
-fs-install: fs-all
+.PHONY: install
+install: all
 	$(INSTALL_DIR) $(DESTDIR)$(FSDIR)/$(FS)
 	$(INSTALL_PROG) $(FSLIB) $(DESTDIR)$(FSDIR)/$(FS)
 
-.PHONY: fs-uninstall
-fs-uninstall:
+.PHONY: uninstall
+uninstall:
 	rm -f $(addprefix $(DESTDIR)$(FSDIR)/$(FS)/, $(FSLIB))
 	if [ -d $(DESTDIR)$(FSDIR)/$(FS) ]; then \
 		rmdir $(DESTDIR)$(FSDIR)/$(FS); \
@@ -28,7 +21,4 @@ fs-uninstall:
 $(FSLIB): $(PIC_OBJS)
 	$(CC) $(LDFLAGS) $(SHLIB_LDFLAGS) -o $@ $^ -lxenfsimage $(FS_LIBDEPS) $(APPEND_LDFLAGS)
 
-clean distclean::
-	rm -f $(PIC_OBJS) $(FSLIB) $(DEPS_RM)
-
 -include $(DEPS_INCLUDE)
diff --git a/tools/libfsimage/common.mk b/tools/libfsimage/common.mk
new file mode 100644
index 0000000000..77bc957f27
--- /dev/null
+++ b/tools/libfsimage/common.mk
@@ -0,0 +1,11 @@
+include $(XEN_ROOT)/tools/Rules.mk
+
+FSDIR := $(libdir)/xenfsimage
+CFLAGS += -Wno-unknown-pragmas -I$(XEN_ROOT)/tools/libfsimage/common/ -DFSIMAGE_FSDIR=\"$(FSDIR)\"
+CFLAGS += -Werror -D_GNU_SOURCE
+LDFLAGS += -L../common/
+
+PIC_OBJS = $(patsubst %.c,%.opic,$(LIB_SRCS-y))
+
+clean distclean::
+	rm -f $(PIC_OBJS) $(TARGETS) $(DEPS_RM)
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Fri Feb 25 15:13:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 15:13:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279185.476836 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcI6-0000Qu-5d; Fri, 25 Feb 2022 15:13:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279185.476836; Fri, 25 Feb 2022 15:13:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcI5-0000PF-Vk; Fri, 25 Feb 2022 15:13:53 +0000
Received: by outflank-mailman (input) for mailman id 279185;
 Fri, 25 Feb 2022 15:13:52 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=E0Ll=TI=citrix.com=prvs=04808661d=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nNcI4-0007Bf-2j
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 15:13:52 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8968535d-964d-11ec-8eb9-a37418f5ba1a;
 Fri, 25 Feb 2022 16:13:50 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8968535d-964d-11ec-8eb9-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645802030;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=zZhTh/NI1Yuo6FeFerl0nTlpsDly6vffYs1vsJ0qtn8=;
  b=aNwn2hPOOo8rCn+DADJTplPCfoLaC2fVIxWXI8Oz+F4HfWcNSXaY/3mJ
   B9aPzqou5Qserh+H7d+g5xfm9ed7IZZ0VUa2Dm9DYUgb6QNyPofBn6vfo
   bzn9pVT8pzLVQb5MriMB8/njmQKh+di5wpvri8sE6fkysNoka2puEmI/K
   E=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 65407506
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:tVQdDamiqXC3S5Q7x/B7+vDo5gyuJkRdPkR7XQ2eYbSJt1+Wr1Gzt
 xJOUGvXM/qLZDGnft8ga43n9k8Bu8XXyd5hTQs4rCw8QyMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EoLd9IR2NYy24DjWV7V4
 7senuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR
 v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ
 NtxWZOYVQhwLIPmo9skFABcDHtXOrFF17bgGC3q2SCT5xWun3rExvxvCAc9PJEC+/YxCmZLn
 RAaAGlTNFbZ3bvwme/lDLk37iggBJCD0Ic3s3d8zTbfHLA+TIrKWani7t5ExjYgwMtJGJ4yY
 uJHNGY3M0mYPXWjPH80J6w3n/6on0DeYmECkn+2ubEe/WfcmVkZPL/Fb4OOJ43iqd9utl2Du
 mvM8mD9AxcbHN+S0zyI9jSrnOCntTz/cJIfEvu/7PECqF+Owm0eDjUGWF39puO24mauVtQaJ
 0EK9y4Gqakp6FftXtT7Rwe/onOPolgbQdU4O+8w5RyJy6HUyx2EHWVCRTlEAOHKr+dvG2Zsj
 AXQ2Yq0W3o/69V5VE5x6J+IomqgFwIuElZFfCsbFyIC/9rMqaYK20enoslYLIa5idj8GDfVy
 j+MrTQji7h7sfPnx5lX7nic3Wvy+8Ghohodo1yOAzn7tl8RiJuNOtTwgWU3+8qsO2pworOpm
 HEf0/aT4+kVZX1mvHzcGb5ddF1FChvsDdE9vbKNN8Vwn9hO0yT6FWy13N2YDB04WirjUWW0C
 HI/QSsLuPdu0IKCNMebmb6ZBcUw1rTHHt/4TP3SZdcmSsEvKFLYoHgyOBbIhziFfK0QfUcXY
 8bznSGEVytyNEia5GDuG7d1PUEDnEjSOl8/tbiklk/6gNJylVaeSKsfMUvmUwzKxPjsnekhy
 P4Gb5Hi40wGCIXWO3CLmaZOfQFiBSVqXvje9p0IHtNv1yI7QQnN/deKmuh/E2Gk9owI/tr1E
 oaVARcJmAKi3iSccW1nqBlLMdvSYHq2llpjVQREALpi8yN7CWpzxM/zr6cKQIQ=
IronPort-HdrOrdr: A9a23:DyULwKsQkEoUWCayie0TaNFu7skDcNV00zEX/kB9WHVpmszxra
 +TdZMgpHjJYVcqKQgdcL+7WZVoLUmwyXcx2/hyAV7AZniDhILLFuFfBOLZqlWKcREWtNQtsJ
 uIG5IObuEYZmIVsS+V2mWF+q4bsbq6zJw=
X-IronPort-AV: E=Sophos;i="5.90,136,1643691600"; 
   d="scan'208";a="65407506"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@citrix.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, "Jan
 Beulich" <jbeulich@suse.com>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Subject: [XEN PATCH v2 01/29] tools/console: have one Makefile per program/directory
Date: Fri, 25 Feb 2022 15:12:53 +0000
Message-ID: <20220225151321.44126-2-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220225151321.44126-1-anthony.perard@citrix.com>
References: <20220225151321.44126-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

Sources of both xenconsoled and xenconsole are already separated into
different directory and don't share anything in common. Having two
different Makefile means it's easier to deal with *FLAGS.

Some common changes:
Rename $(BIN) to $(TARGETS), this will be useful later.
Stop removing *.so *.rpm *.a as they aren't created here.
Use $(OBJS-y) to list objects.
Update $(CFLAGS) for the directory rather than a single object.

daemon:
    Remove the need for $(LDLIBS_xenconsoled), use $(LDLIBS) instead.
    Remove the need for $(CONSOLE_CFLAGS-y) and use $(CFLAGS-y)
	instead.

client:
    Remove the unused $(LDLIBS_xenconsole)

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---

Notes:
    v2:
    - create per-directory .gitignore

 tools/console/Makefile          | 49 ++------------------------------
 tools/console/client/Makefile   | 39 +++++++++++++++++++++++++
 tools/console/daemon/Makefile   | 50 +++++++++++++++++++++++++++++++++
 .gitignore                      |  2 --
 tools/console/client/.gitignore |  1 +
 tools/console/daemon/.gitignore |  1 +
 6 files changed, 94 insertions(+), 48 deletions(-)
 create mode 100644 tools/console/client/Makefile
 create mode 100644 tools/console/daemon/Makefile
 create mode 100644 tools/console/client/.gitignore
 create mode 100644 tools/console/daemon/.gitignore

diff --git a/tools/console/Makefile b/tools/console/Makefile
index 207c04c9cd..63bd2ac302 100644
--- a/tools/console/Makefile
+++ b/tools/console/Makefile
@@ -1,50 +1,7 @@
 XEN_ROOT=$(CURDIR)/../..
 include $(XEN_ROOT)/tools/Rules.mk
 
-CFLAGS  += -Werror
+SUBDIRS-y := daemon client
 
-CFLAGS  += $(CFLAGS_libxenctrl)
-CFLAGS  += $(CFLAGS_libxenstore)
-LDLIBS += $(LDLIBS_libxenctrl)
-LDLIBS += $(LDLIBS_libxenstore)
-LDLIBS += $(SOCKET_LIBS)
-
-LDLIBS_xenconsoled += $(UTIL_LIBS)
-LDLIBS_xenconsoled += -lrt
-CONSOLE_CFLAGS-$(CONFIG_ARM) = -DCONFIG_ARM
-
-BIN      = xenconsoled xenconsole
-
-.PHONY: all
-all: $(BIN)
-
-.PHONY: clean
-clean:
-	$(RM) *.a *.so *.o *.rpm $(BIN) $(DEPS_RM)
-	$(RM) client/*.o daemon/*.o
-
-.PHONY: distclean
-distclean: clean
-
-daemon/main.o: CFLAGS += -include $(XEN_ROOT)/tools/config.h
-daemon/io.o: CFLAGS += $(CFLAGS_libxenevtchn) $(CFLAGS_libxengnttab) $(CFLAGS_libxenforeignmemory) $(CONSOLE_CFLAGS-y)
-xenconsoled: $(patsubst %.c,%.o,$(wildcard daemon/*.c))
-	$(CC) $(LDFLAGS) $^ -o $@ $(LDLIBS) $(LDLIBS_libxenevtchn) $(LDLIBS_libxengnttab) $(LDLIBS_libxenforeignmemory) $(LDLIBS_xenconsoled) $(APPEND_LDFLAGS)
-
-client/main.o: CFLAGS += -include $(XEN_ROOT)/tools/config.h
-xenconsole: $(patsubst %.c,%.o,$(wildcard client/*.c))
-	$(CC) $(LDFLAGS) $^ -o $@ $(LDLIBS) $(LDLIBS_xenconsole) $(APPEND_LDFLAGS)
-
-.PHONY: install
-install: $(BIN)
-	$(INSTALL_DIR) $(DESTDIR)/$(sbindir)
-	$(INSTALL_PROG) xenconsoled $(DESTDIR)/$(sbindir)
-	$(INSTALL_DIR) $(DESTDIR)$(LIBEXEC_BIN)
-	$(INSTALL_PROG) xenconsole $(DESTDIR)$(LIBEXEC_BIN)
-
-.PHONY: uninstall
-uninstall:
-	rm -f $(DESTDIR)$(LIBEXEC_BIN)/xenconsole
-	rm -f $(DESTDIR)$(sbindir)/xenconsoled
-
--include $(DEPS_INCLUDE)
+.PHONY: all clean install distclean uninstall
+all clean install distclean uninstall: %: subdirs-%
diff --git a/tools/console/client/Makefile b/tools/console/client/Makefile
new file mode 100644
index 0000000000..44176c6d93
--- /dev/null
+++ b/tools/console/client/Makefile
@@ -0,0 +1,39 @@
+XEN_ROOT=$(CURDIR)/../../..
+include $(XEN_ROOT)/tools/Rules.mk
+
+CFLAGS += -Werror
+CFLAGS += $(CFLAGS_libxenctrl)
+CFLAGS += $(CFLAGS_libxenstore)
+CFLAGS += -include $(XEN_ROOT)/tools/config.h
+
+LDLIBS += $(LDLIBS_libxenctrl)
+LDLIBS += $(LDLIBS_libxenstore)
+LDLIBS += $(SOCKET_LIBS)
+
+OBJS-y := main.o
+
+TARGETS := xenconsole
+
+.PHONY: all
+all: $(TARGETS)
+
+xenconsole: $(OBJS-y)
+	$(CC) $(LDFLAGS) $^ -o $@ $(LDLIBS) $(APPEND_LDFLAGS)
+
+.PHONY: install
+install: all
+	$(INSTALL_DIR) $(DESTDIR)$(LIBEXEC_BIN)
+	$(INSTALL_PROG) xenconsole $(DESTDIR)$(LIBEXEC_BIN)
+
+.PHONY: uninstall
+uninstall:
+	rm -f $(DESTDIR)$(LIBEXEC_BIN)/xenconsole
+
+.PHONY: clean
+clean:
+	$(RM) *.o $(TARGETS) $(DEPS_RM)
+
+.PHONY: distclean
+distclean: clean
+
+-include $(DEPS_INCLUDE)
diff --git a/tools/console/daemon/Makefile b/tools/console/daemon/Makefile
new file mode 100644
index 0000000000..0f004f0b14
--- /dev/null
+++ b/tools/console/daemon/Makefile
@@ -0,0 +1,50 @@
+XEN_ROOT=$(CURDIR)/../../..
+include $(XEN_ROOT)/tools/Rules.mk
+
+CFLAGS += -Werror
+CFLAGS += $(CFLAGS_libxenctrl)
+CFLAGS += $(CFLAGS_libxenstore)
+CFLAGS += $(CFLAGS_libxenevtchn)
+CFLAGS += $(CFLAGS_libxengnttab)
+CFLAGS += $(CFLAGS_libxenforeignmemory)
+CFLAGS-$(CONFIG_ARM) += -DCONFIG_ARM
+CFLAGS += -include $(XEN_ROOT)/tools/config.h
+
+LDLIBS += $(LDLIBS_libxenctrl)
+LDLIBS += $(LDLIBS_libxenstore)
+LDLIBS += $(LDLIBS_libxenevtchn)
+LDLIBS += $(LDLIBS_libxengnttab)
+LDLIBS += $(LDLIBS_libxenforeignmemory)
+LDLIBS += $(SOCKET_LIBS)
+LDLIBS += $(UTIL_LIBS)
+LDLIBS += -lrt
+
+OBJS-y := main.o
+OBJS-y += io.o
+OBJS-y += utils.o
+
+TARGETS := xenconsoled
+
+.PHONY: all
+all: $(TARGETS)
+
+xenconsoled: $(OBJS-y)
+	$(CC) $(LDFLAGS) $^ -o $@ $(LDLIBS) $(APPEND_LDFLAGS)
+
+.PHONY: install
+install: all
+	$(INSTALL_DIR) $(DESTDIR)/$(sbindir)
+	$(INSTALL_PROG) xenconsoled $(DESTDIR)/$(sbindir)
+
+.PHONY: uninstall
+uninstall:
+	rm -f $(DESTDIR)$(sbindir)/xenconsoled
+
+.PHONY: clean
+clean:
+	$(RM) *.o $(TARGETS) $(DEPS_RM)
+
+.PHONY: distclean
+distclean: clean
+
+-include $(DEPS_INCLUDE)
diff --git a/.gitignore b/.gitignore
index d425be4bd9..4e2a850f94 100644
--- a/.gitignore
+++ b/.gitignore
@@ -159,8 +159,6 @@ tools/libs/util/libxenutil.map
 tools/libs/vchan/headers.chk
 tools/libs/vchan/libxenvchan.map
 tools/libs/vchan/xenvchan.pc
-tools/console/xenconsole
-tools/console/xenconsoled
 tools/debugger/gdb/gdb-6.2.1-linux-i386-xen/*
 tools/debugger/gdb/gdb-6.2.1/*
 tools/debugger/gdb/gdb-6.2.1.tar.bz2
diff --git a/tools/console/client/.gitignore b/tools/console/client/.gitignore
new file mode 100644
index 0000000000..b096a1d841
--- /dev/null
+++ b/tools/console/client/.gitignore
@@ -0,0 +1 @@
+/xenconsole
diff --git a/tools/console/daemon/.gitignore b/tools/console/daemon/.gitignore
new file mode 100644
index 0000000000..55c8f84664
--- /dev/null
+++ b/tools/console/daemon/.gitignore
@@ -0,0 +1 @@
+/xenconsoled
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Fri Feb 25 15:13:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 15:13:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279186.476844 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcI7-0000au-0b; Fri, 25 Feb 2022 15:13:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279186.476844; Fri, 25 Feb 2022 15:13:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcI6-0000XO-Nf; Fri, 25 Feb 2022 15:13:54 +0000
Received: by outflank-mailman (input) for mailman id 279186;
 Fri, 25 Feb 2022 15:13:53 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=E0Ll=TI=citrix.com=prvs=04808661d=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nNcI4-0007Bf-VI
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 15:13:53 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8a2e6326-964d-11ec-8eb9-a37418f5ba1a;
 Fri, 25 Feb 2022 16:13:51 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8a2e6326-964d-11ec-8eb9-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645802031;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=UAbT4K/ao9ETM/4n/1jW37qwLD7c5IdIpzy2VsdfrxM=;
  b=a7iYnPM95J/FN6D9guuAKj5vCfZ1/0jMIgHLD2rv2aMHzPcLnCfffMWb
   CC2Jv+ALOY5ivLPB6XGsopJTLWuZB3g2/3WKlsiuBtwYTRY1mkXy2Yj7C
   SgJ8SjDUnQoOlX8oTrnP+5y3sP94vOqKMfT9IRCJ93BOgRaMEAiDIhLDV
   0=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 65407531
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:yuB00KnLwLkyxNy7HZLyCc3o5gyuJkRdPkR7XQ2eYbSJt1+Wr1Gzt
 xJLWT2APfyDYmb0LtBzYdjg9kxUvZbQm4VjT1Bt+Hg1RiMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EoLd9IR2NYy24DjWV7V4
 7senuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR
 v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ
 NtxWZOYdR0kB7zJkt4hfhh6TSVBNoFf+pvfLi3q2SCT5xWun3rExvxvCAc9PJEC+/YxCmZLn
 RAaAGlTNFbZ3bvwme/lDLk37iggBJCD0Ic3s3d8zTbfHLA+TIrKWani7t5ExjYgwMtJGJ4yY
 uJHNGY3M0mbOnWjPH9KKJ8umruWjEL9dnoBtGKrn5Zow0jMmVkZPL/Fb4OOJ43iqd9utl2Du
 mvM8mD9AxcbHN+S0zyI9jSrnOCntTz/cJIfEvu/7PECqF+Owm0eDjUGWF39puO24mauVtQaJ
 0EK9y4Gqakp6FftXtT7Rwe/onOPolgbQdU4O+8w5RyJy6HUyx2EHWVCRTlEAOHKr+dvG2Zsj
 AXQ2Yq0W3o/69V5VE5x6J+otz6LKC0fF1MvZA1aSTQOz8DhhJk820enoslYLIa5idj8GDfVy
 j+MrTQji7h7sfPnx5lX7nic3Wvy+8Ghohodo1yOAzn7tl8RiJuNOtTwgWU3+8qsO2pworOpm
 HEf0/aT4+kVZX1mvHzcGb5ddF1FChvsDdE9vbKNN8Vwn9hO0yT6FWy13N2YDB04WirjUWW0C
 HI/QSsLuPdu0IKCNMebmb6ZBcUw1rTHHt/4TP3SZdcmSsEvKFLYoHgyOBbIhziFfK0QfUcXY
 8bznSGEVytyNEia5GDuG7d1PUEDnEjSOl8/tbiklk/6gNJylVaeSKsfMUvmUwzKxPjsnekhy
 P4Gb5Hi40wGCIXWO3CLmaZOfQFiBSVqXvje9p0IHtNv1yI7QQnN/deKmuh/E2Gk9owI/tr1E
 oaVARcJmAKi3iSccW1nqBlLMdvSYHq2llpjVQREALpi8yJ6CWpzxM/zr6cKQIQ=
IronPort-HdrOrdr: A9a23:v9zODa1cg82wlKRb0ZmrLgqjBLQkLtp133Aq2lEZdPRUGvb2qy
 nIpoV96faUskdpZJhOo7G90cW7LE80sKQFg7X5Xo3SODUO2lHJEGgK1+KLqFfd8m/Fh4tgPM
 9bAs5D4bbLY2SS4/yX3ODBKadC/OW6
X-IronPort-AV: E=Sophos;i="5.90,136,1643691600"; 
   d="scan'208";a="65407531"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@citrix.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, "Jan
 Beulich" <jbeulich@suse.com>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>
Subject: [XEN PATCH v2 06/29] tools/fuzz/x86_instruction_emulator: rework makefile
Date: Fri, 25 Feb 2022 15:12:58 +0000
Message-ID: <20220225151321.44126-7-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220225151321.44126-1-anthony.perard@citrix.com>
References: <20220225151321.44126-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

Rework dependencies of all objects. We don't need to add dependencies
for headers that $(CC) is capable of generating, we only need to
include $(DEPS_INCLUDE). Some dependencies are still needed so make
knows to generate symlinks for them.

We remove the use of "vpath" for cpuid.c. While it works fine for now,
when we will convert this makefile to subdirmk, vpath will not be
usable. Also, "-iquote" is now needed to build "cpuid.o".

Replace "-I." by "-iquote .", so it applies to double-quote includes
only.

Rather than checking if a symlink exist, always regenerate the
symlink. So if the source tree changed location, the symlink is
updated.

Since we are creating a new .gitignore for the symlink, also move the
entry to it.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---

Notes:
    v2:
    - create a new per-directory .gitignore to add the new entry and existing ones

 tools/fuzz/x86_instruction_emulator/Makefile  | 32 ++++++++-----------
 .gitignore                                    |  6 ----
 .../fuzz/x86_instruction_emulator/.gitignore  |  7 ++++
 3 files changed, 21 insertions(+), 24 deletions(-)
 create mode 100644 tools/fuzz/x86_instruction_emulator/.gitignore

diff --git a/tools/fuzz/x86_instruction_emulator/Makefile b/tools/fuzz/x86_instruction_emulator/Makefile
index 1a6dbf94e1..f11437e6a2 100644
--- a/tools/fuzz/x86_instruction_emulator/Makefile
+++ b/tools/fuzz/x86_instruction_emulator/Makefile
@@ -8,33 +8,27 @@ else
 x86-insn-fuzz-all:
 endif
 
-# Add libx86 to the build
-vpath %.c $(XEN_ROOT)/xen/lib/x86
+cpuid.c: %: $(XEN_ROOT)/xen/lib/x86/% FORCE
+	ln -nsf $< $@
 
-x86_emulate:
-	[ -L $@ ] || ln -sf $(XEN_ROOT)/xen/arch/x86/$@
+x86_emulate: FORCE
+	ln -nsf $(XEN_ROOT)/xen/arch/x86/$@
 
 x86_emulate/%: x86_emulate ;
 
-x86-emulate.c x86-emulate.h wrappers.c: %:
-	[ -L $* ] || ln -sf $(XEN_ROOT)/tools/tests/x86_emulator/$*
+x86-emulate.c x86-emulate.h wrappers.c: %: $(XEN_ROOT)/tools/tests/x86_emulator/% FORCE
+	ln -nsf $< $@
 
-CFLAGS += $(CFLAGS_xeninclude) -D__XEN_TOOLS__ -I.
+CFLAGS += $(CFLAGS_xeninclude) -D__XEN_TOOLS__ -iquote .
+cpuid.o: CFLAGS += -iquote $(XEN_ROOT)/xen/lib/x86
 
 GCOV_FLAGS := --coverage
 %-cov.o: %.c
 	$(CC) -c $(CFLAGS) $(GCOV_FLAGS) $< -o $@
 
-x86.h := $(addprefix $(XEN_ROOT)/tools/include/xen/asm/,\
-                     x86-vendors.h x86-defns.h msr-index.h) \
-         $(addprefix $(XEN_ROOT)/tools/include/xen/lib/x86/, \
-                     cpuid.h cpuid-autogen.h)
-x86_emulate.h := x86-emulate.h x86_emulate/x86_emulate.h $(x86.h)
-
-# x86-emulate.c will be implicit for both
-x86-emulate.o x86-emulate-cov.o: x86_emulate/x86_emulate.c $(x86_emulate.h)
-
-fuzz-emul.o fuzz-emulate-cov.o cpuid.o wrappers.o: $(x86_emulate.h)
+x86-emulate.h: x86_emulate/x86_emulate.h
+x86-emulate.o x86-emulate-cov.o: x86-emulate.h x86_emulate/x86_emulate.c
+fuzz-emul.o fuzz-emul-cov.o wrappers.o: x86-emulate.h
 
 x86-insn-fuzzer.a: fuzz-emul.o x86-emulate.o cpuid.o
 	$(AR) rc $@ $^
@@ -51,7 +45,7 @@ all: x86-insn-fuzz-all
 
 .PHONY: distclean
 distclean: clean
-	rm -f x86_emulate x86-emulate.c x86-emulate.h
+	rm -f x86_emulate x86-emulate.c x86-emulate.h wrappers.c cpuid.c
 
 .PHONY: clean
 clean:
@@ -67,3 +61,5 @@ afl: afl-harness
 
 .PHONY: afl-cov
 afl-cov: afl-harness-cov
+
+-include $(DEPS_INCLUDE)
diff --git a/.gitignore b/.gitignore
index fb29d42342..3da56594c5 100644
--- a/.gitignore
+++ b/.gitignore
@@ -194,12 +194,6 @@ tools/flask/utils/flask-loadpolicy
 tools/flask/utils/flask-setenforce
 tools/flask/utils/flask-set-bool
 tools/flask/utils/flask-label-pci
-tools/fuzz/x86_instruction_emulator/asm
-tools/fuzz/x86_instruction_emulator/afl-harness
-tools/fuzz/x86_instruction_emulator/afl-harness-cov
-tools/fuzz/x86_instruction_emulator/wrappers.c
-tools/fuzz/x86_instruction_emulator/x86_emulate
-tools/fuzz/x86_instruction_emulator/x86-emulate.[ch]
 tools/helpers/init-xenstore-domain
 tools/helpers/xen-init-dom0
 tools/hotplug/common/hotplugpath.sh
diff --git a/tools/fuzz/x86_instruction_emulator/.gitignore b/tools/fuzz/x86_instruction_emulator/.gitignore
new file mode 100644
index 0000000000..65c3cf9702
--- /dev/null
+++ b/tools/fuzz/x86_instruction_emulator/.gitignore
@@ -0,0 +1,7 @@
+/asm
+/afl-harness
+/afl-harness-cov
+/cpuid.c
+/wrappers.c
+/x86_emulate
+/x86-emulate.[ch]
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Fri Feb 25 15:13:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 15:13:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279188.476866 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcIA-0001YA-Rz; Fri, 25 Feb 2022 15:13:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279188.476866; Fri, 25 Feb 2022 15:13:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcIA-0001Xa-Ll; Fri, 25 Feb 2022 15:13:58 +0000
Received: by outflank-mailman (input) for mailman id 279188;
 Fri, 25 Feb 2022 15:13:56 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=E0Ll=TI=citrix.com=prvs=04808661d=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nNcI8-0006fy-FH
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 15:13:56 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8af36756-964d-11ec-8539-5f4723681683;
 Fri, 25 Feb 2022 16:13:54 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8af36756-964d-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645802034;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=PsH7X2yVeRIwZGaTHcN3WknuPqURtR6v199OPOJQpsM=;
  b=eAU7I2/TBmrBo7+9gVKkVDUdQUjMBvi+VAfFXr9b2rL86r6sLqrC56kh
   KnfCDi9HVBhVX8v+U5sJ0030DqN9SO1yaV4naZiKlACsfMYjao7mcO0bs
   scDsZnFSY0eULUv4d/1Vvukv50YTpZt0cZ6IHj7X+3l6fXfANtWD1zcF+
   A=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 67264742
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:a1ypo6ll8X08Ba4+jWCeC1Po5gyLJkRdPkR7XQ2eYbSJt1+Wr1Gzt
 xIcDGDVPPaNYzHwf91ya4jg8EkO6p+AzdQyTAFp+ytnRSMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EoLd9IR2NYy24DjWV7V4
 7senuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR
 v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ
 NtxWZOYSwhwPfHWs78mVSIINw0gZYpp1Jn5CC3q2SCT5xWun3rExvxvCAc9PJEC+/YxCmZLn
 RAaAGlTNFbZ3bvwme/lDLk37iggBJCD0Ic3s3d8zTbfHLA+TIrKWani7t5ExjYgwMtJGJ4yY
 uJHNmAxMEucOXWjPH82KcwMtaShwUDgTANSkUy3m6At73bcmVkZPL/Fb4OOJ43iqd9utkSXv
 GXd5EziHwoXcteYzFKt8G+oh+LJtTP2XsQVDrLQ3u5nhhify3IeDDUSVECnur+ph0imQdVdJ
 kcIvC00osAa60iDXtT7GRqirxa5UgU0AoQKVbdgsUfUl/SSs13x6nU4oiBpatN/t5MsbmcR0
 GTZu/+3XRtAnJurYCfInluLlg+aNS8QJG4EQCYLSwoZ/tXuyL0OYgLzosVLS/Ds0ICscd3k6
 3XT9XVl2e1P5SIe//jjpTj6bySQSo8lp+LfziHeRSqb4wxwf+ZJjKT4uAGAvZ6swGt0J2RtX
 UToeeDCvYji7rnXzURhpdnh+pnztp5p1xWG3DZS82EJrWjFxpJaVdk4DMtCDEloKN0YXjTif
 VXevwhcjLcKYif3MvMuP9/pU5xypUQFKTgDfqqFBjapSsIsHDJrAQk0PRLAt4wTuBJEfV4D1
 WezLp/3UCdy5VVPxzuqXeYNuYLHNQhlrV4/savTlkz9uZLHPSb9Ye5cbDOmM7BohIvZ8V692
 4sOaKO3J+B3DbSWjt//qtVIczjn7BETWPjLliCgXrXbc1o+RTp4UKe5LHFIU9UNopm5X9zgp
 hmVMnK0AnKm7ZEbAW1mskxeVY4=
IronPort-HdrOrdr: A9a23:IzpogKgnKbNH4PsvRxw1oQxXm3BQXuIji2hC6mlwRA09TySZ//
 rBoB19726TtN9xYgBZpTnuAsm9qB/nmaKdpLNhWItKPzOW31dATrsSjrcKqgeIc0aVm9K1l5
 0QF5SWYOeAdGSS5vya3ODXKbkdKaG8gcKVuds=
X-IronPort-AV: E=Sophos;i="5.90,136,1643691600"; 
   d="scan'208";a="67264742"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@citrix.com>, Wei Liu <wl@xen.org>, "Juergen
 Gross" <jgross@suse.com>, Julien Grall <julien@xen.org>
Subject: [XEN PATCH v2 11/29] tools/xenstore: Cleanup makefile
Date: Fri, 25 Feb 2022 15:13:03 +0000
Message-ID: <20220225151321.44126-12-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220225151321.44126-1-anthony.perard@citrix.com>
References: <20220225151321.44126-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

Regroup *FLAGS together, use $(LDLIBS).

Remove $(LDLIBS_xenstored) which was the wrong name name as it doesn't
decribe how to link to a potential libxenstored.so, instead add the
value to $(LDLIBS) of xenstored.

Add SYSTEMD_LIBS into $(LDLIBS) instead of $(LDFLAGS).

Remove the "-I." from $(CFLAGS), it shouldn't be needed.

Removed $(CFLAGS-y) and $(LDFLAGS-y). $(CFLAGS-y) is already included
in $(CFLAGS) and both aren't used anyway.

Rename ALL_TARGETS to TARGETS.
Only add programmes we want to build in $(TARGETS), not phony-targets
(replace "clients").

Store all `xenstored` objs into $(XENSTORED_OBJS-y).

Replace one $< by $^ even if there's only one dependency,
(xenstore-control).

clean: "init-xenstore-domain" isn't built here any more, so stop
trying to remove it, remove $(TARGETS). Also regroup all files to be
removed in one command, using $(RM).

Drop $(MAJOR) and $(MINOR), they aren't used anymore.

Drop ".SECONDARY:", it doesn't appear there's intermediate files that
would be deleted anymore.

Drop "tarball:" target.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---

Notes:
    v2:
    - drop MAJOR and MINOR variables
    - drop tarball rule
    - drop ".SECONDARY:"
    - rework "clean:" to have one command

 tools/xenstore/Makefile | 91 +++++++++++++++++++----------------------
 1 file changed, 43 insertions(+), 48 deletions(-)

diff --git a/tools/xenstore/Makefile b/tools/xenstore/Makefile
index c86278fdb1..830052c65f 100644
--- a/tools/xenstore/Makefile
+++ b/tools/xenstore/Makefile
@@ -1,11 +1,7 @@
 XEN_ROOT=$(CURDIR)/../..
 include $(XEN_ROOT)/tools/Rules.mk
 
-MAJOR = 3.0
-MINOR = 3
-
 CFLAGS += -Werror
-CFLAGS += -I.
 # Include configure output (config.h)
 CFLAGS += -include $(XEN_ROOT)/tools/config.h
 CFLAGS += -I./include
@@ -16,71 +12,77 @@ CFLAGS += $(CFLAGS_libxentoolcore)
 CFLAGS += -DXEN_LIB_STORED="\"$(XEN_LIB_STORED)\""
 CFLAGS += -DXEN_RUN_STORED="\"$(XEN_RUN_STORED)\""
 
-CFLAGS  += $(CFLAGS-y)
-LDFLAGS += $(LDFLAGS-y)
+ifdef CONFIG_STUBDOM
+CFLAGS += -DNO_SOCKETS=1
+endif
 
-CLIENTS := xenstore-exists xenstore-list xenstore-read xenstore-rm xenstore-chmod
-CLIENTS += xenstore-write xenstore-ls xenstore-watch
+XENSTORED_OBJS-y := xenstored_core.o xenstored_watch.o xenstored_domain.o
+XENSTORED_OBJS-y += xenstored_transaction.o xenstored_control.o
+XENSTORED_OBJS-y += xs_lib.o talloc.o utils.o tdb.o hashtable.o
 
-XENSTORED_OBJS = xenstored_core.o xenstored_watch.o xenstored_domain.o
-XENSTORED_OBJS += xenstored_transaction.o xenstored_control.o
-XENSTORED_OBJS += xs_lib.o talloc.o utils.o tdb.o hashtable.o
+XENSTORED_OBJS-$(CONFIG_Linux) += xenstored_posix.o
+XENSTORED_OBJS-$(CONFIG_NetBSD) += xenstored_posix.o
+XENSTORED_OBJS-$(CONFIG_FreeBSD) += xenstored_posix.o
+XENSTORED_OBJS-$(CONFIG_MiniOS) += xenstored_minios.o
 
-XENSTORED_OBJS_$(CONFIG_Linux) = xenstored_posix.o
-XENSTORED_OBJS_$(CONFIG_NetBSD) = xenstored_posix.o
-XENSTORED_OBJS_$(CONFIG_FreeBSD) = xenstored_posix.o
-XENSTORED_OBJS_$(CONFIG_MiniOS) = xenstored_minios.o
+$(XENSTORED_OBJS-y): CFLAGS += $(CFLAGS_libxengnttab)
 
-XENSTORED_OBJS += $(XENSTORED_OBJS_y)
-LDLIBS_xenstored += -lrt
+xenstored: LDLIBS += $(LDLIBS_libxenevtchn)
+xenstored: LDLIBS += $(LDLIBS_libxengnttab)
+xenstored: LDLIBS += $(LDLIBS_libxenctrl)
+xenstored: LDLIBS += -lrt
+xenstored: LDLIBS += $(SOCKET_LIBS)
 
-ALL_TARGETS = clients
-ifeq ($(XENSTORE_XENSTORED),y)
-ALL_TARGETS += xs_tdb_dump xenstored
+ifeq ($(CONFIG_SYSTEMD),y)
+$(XENSTORED_OBJS-y): CFLAGS += $(SYSTEMD_CFLAGS)
+xenstored: LDLIBS += $(SYSTEMD_LIBS)
 endif
 
-ifdef CONFIG_STUBDOM
-CFLAGS += -DNO_SOCKETS=1
+xenstore: LDLIBS += $(LDLIBS_libxenstore)
+xenstore: LDLIBS += $(LDLIBS_libxentoolcore)
+xenstore: LDLIBS += $(SOCKET_LIBS)
+
+xenstore-control: LDLIBS += $(LDLIBS_libxenstore)
+xenstore-control: LDLIBS += $(LDLIBS_libxenctrl)
+xenstore-control: LDLIBS += $(LDLIBS_libxenguest)
+xenstore-control: LDLIBS += $(LDLIBS_libxentoolcore)
+xenstore-control: LDLIBS += $(SOCKET_LIBS)
+
+CLIENTS := xenstore-exists xenstore-list xenstore-read xenstore-rm xenstore-chmod
+CLIENTS += xenstore-write xenstore-ls xenstore-watch
+
+TARGETS := xenstore $(CLIENTS) xenstore-control
+ifeq ($(XENSTORE_XENSTORED),y)
+TARGETS += xs_tdb_dump xenstored
 endif
 
 .PHONY: all
-all: $(ALL_TARGETS)
+all: $(TARGETS)
 
 .PHONY: clients
 clients: xenstore $(CLIENTS) xenstore-control
 
-ifeq ($(CONFIG_SYSTEMD),y)
-$(XENSTORED_OBJS): CFLAGS += $(SYSTEMD_CFLAGS)
-xenstored: LDFLAGS += $(SYSTEMD_LIBS)
-endif
-
-$(XENSTORED_OBJS): CFLAGS += $(CFLAGS_libxengnttab)
-
-xenstored: $(XENSTORED_OBJS)
-	$(CC) $^ $(LDFLAGS) $(LDLIBS_libxenevtchn) $(LDLIBS_libxengnttab) $(LDLIBS_libxenctrl) $(LDLIBS_xenstored) $(SOCKET_LIBS) -o $@ $(APPEND_LDFLAGS)
+xenstored: $(XENSTORED_OBJS-y)
+	$(CC) $(LDFLAGS) $^ $(LDLIBS) -o $@ $(APPEND_LDFLAGS)
 
-xenstored.a: $(XENSTORED_OBJS)
+xenstored.a: $(XENSTORED_OBJS-y)
 	$(AR) cr $@ $^
 
 $(CLIENTS): xenstore
 	ln -f xenstore $@
 
 xenstore: xenstore_client.o xs_lib.o
-	$(CC) $^ $(LDFLAGS) $(LDLIBS_libxenstore) $(LDLIBS_libxentoolcore) $(SOCKET_LIBS) -o $@ $(APPEND_LDFLAGS)
+	$(CC) $(LDFLAGS) $^ $(LDLIBS) -o $@ $(APPEND_LDFLAGS)
 
 xenstore-control: xenstore_control.o
-	$(CC) $< $(LDFLAGS) $(LDLIBS_libxenstore) $(LDLIBS_libxenctrl) $(LDLIBS_libxenguest) $(LDLIBS_libxentoolcore) $(SOCKET_LIBS) -o $@ $(APPEND_LDFLAGS)
+	$(CC) $(LDFLAGS) $^ $(LDLIBS) -o $@ $(APPEND_LDFLAGS)
 
 xs_tdb_dump: xs_tdb_dump.o utils.o tdb.o talloc.o
-	$(CC) $^ $(LDFLAGS) -o $@ $(APPEND_LDFLAGS)
+	$(CC) $(LDFLAGS) $^ -o $@ $(APPEND_LDFLAGS)
 
 .PHONY: clean
 clean:
-	rm -f *.a *.o
-	rm -f xenstored
-	rm -f xs_tdb_dump xenstore-control init-xenstore-domain
-	rm -f xenstore $(CLIENTS)
-	$(RM) $(DEPS_RM)
+	$(RM) *.a *.o $(TARGETS) $(DEPS_RM)
 
 .PHONY: distclean
 distclean: clean
@@ -89,10 +91,6 @@ distclean: clean
 TAGS:
 	etags `find . -name '*.[ch]'`
 
-.PHONY: tarball
-tarball: clean
-	cd .. && tar -c -j -v -h -f xenstore.tar.bz2 xenstore/
-
 .PHONY: install
 install: all
 	$(INSTALL_DIR) $(DESTDIR)$(bindir)
@@ -135,6 +133,3 @@ clients-install: clients
 	done
 
 -include $(DEPS_INCLUDE)
-
-# never delete any intermediate files.
-.SECONDARY:
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Fri Feb 25 15:13:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 15:13:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279190.476871 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcIB-0001dV-HV; Fri, 25 Feb 2022 15:13:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279190.476871; Fri, 25 Feb 2022 15:13:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcIB-0001bi-4Y; Fri, 25 Feb 2022 15:13:59 +0000
Received: by outflank-mailman (input) for mailman id 279190;
 Fri, 25 Feb 2022 15:13:57 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=E0Ll=TI=citrix.com=prvs=04808661d=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nNcI8-0007Bf-Si
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 15:13:56 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8b94b611-964d-11ec-8eb9-a37418f5ba1a;
 Fri, 25 Feb 2022 16:13:55 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8b94b611-964d-11ec-8eb9-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645802035;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=06doEHilS6AKmsVA0dHPUnjlMaGNmuuqrJF1JZCOe3k=;
  b=Ssfq5I8RyMaki5CLdenUAzYmHgnkW5QMIuMss+cZexCDkhLM9oaw4rRE
   U4Xf9m7231yK2CTlZd7X3Wbz+dR89K4HaIqDz+h/0IuIix02vEEuvLPOX
   nHYtnlEwRmWPZTMeRtd6TUz21HxifgFCX96hA/an9pf0z7um9KDNF9Iop
   Y=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 64890254
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:EPQnR6gvCnA1+n0BGDUxZttuX161CxAKZh0ujC45NGQN5FlHY01je
 htvCD/TM67ZZDH2f9tzat/g80sA6pSEmIAwSgFrqSAyQiIb9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M78wIFqtQw24LhWVnQ4
 YmaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV
 efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9
 TlDiXC/YVd3MpXTivssahJRHAI9Aal58uf9LVHq5KR/z2WeG5ft6/BnDUVwNowE4OdnR2pJ8
 JT0KhhUMErF3bjvhuvmFK883azPL+GyVG8bknhm0THeC+dgWZ3ZSr/GzdRZwC0xloZFGvO2i
 88xN2Y/PUyaPkEn1lE/MtEBmLqWgUvFWgJogxGeg4ce/mH65VkkuFTqGIWMIYHbLSlPpW6Ho
 krW8mK/BQsVXPSPxDzA/n+yi+vnmSLgRJlUBLC+7uRtglCY2ioUEhJ+aLegiaDn0AjkAYsZc
 hFKvHp1xUQvyKC1ZomjUyWnsmG1hxUVVPkTL+kF4lm3xoOBtm51GVM4ZjJGbdUnsuo/Sjory
 kKFkrvVONB/jFGGYSnDr+nJ9FteLQBQdDZfPnFcEWPp9vG++Nlbs/7Zcjp0/EdZZPXRECq4/
 T2FpTNWa1473Z9SjPXTEbwqbluRSnn1ouwdulS/soGNtFoRiGuZi2qAswmzARFodtvxc7V5l
 CJY8/VyFchXZX13qASDQf8WAJai7OufPTvXjDZHRsd9qmvxoiL+JdgIuFmSwXuF1O5eKFcFh
 2eJ5GtsCGJ7ZiP2PcebnarrYyjV8UQQPYu8Da2FBja/SpNwaBWG7ElTib24hAjQfLwXufhnY
 /+zKJ/0ZV5DUPgP5GfmFo81jO5wrghjlDy7eHwO50n+uVZoTCXOEult3ZrnRr1R0Z5oVy2Oq
 4cPb5bRkk4HOAA8CwGOmbMuwZkxBSBTLfjLRwZ/LIZv/iIO9LkdNsLs
IronPort-HdrOrdr: A9a23:M4+jDK1C+nj0VAtkpVbo/QqjBIokLtp133Aq2lEZdPRUGvb3qy
 nIpoV86faUskdoZJhOo7C90cW7LU80sKQFhLX5Xo3SOzUO2lHYT72KhLGKq1aLdhEWtNQtsZ
 uIG5IOceEYZmIasS+V2maF+q4bsbu6zJw=
X-IronPort-AV: E=Sophos;i="5.90,136,1643691600"; 
   d="scan'208";a="64890254"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@citrix.com>, Wei Liu <wl@xen.org>
Subject: [XEN PATCH v2 12/29] tools/xentop: rework makefile
Date: Fri, 25 Feb 2022 15:13:04 +0000
Message-ID: <20220225151321.44126-13-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220225151321.44126-1-anthony.perard@citrix.com>
References: <20220225151321.44126-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

Add "xentop" to "TARGETS" because this variable will be useful later.

Always define all the targets, even when configured with
--disable-monitor, instead don't visit the subdirectory.
This mean xentop/ isn't visited anymore during "make clean" that's how
most other subdirs in the tools/ works.

Also add missing "xentop" rules. It only works without it because we
still have make's built-ins rules and variables, but fix this to not
have to rely on them.

Use $(TARGETS) with $(INSTALL_PROG), and thus install into the
directory rather than spelling the program name.

In the "clean" rule, use $(RM) and remove all "*.o" instead of just
one object.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---

Notes:
    v2:
    - use $(RM) in clean.
    - remove all *.o instead of just one object in "clean" rule.
    - in "install" rule, make use of $(TARGETS). install into a dir rather
      than to a specific path, in case there's more targets.

 tools/Makefile        |  2 +-
 tools/xentop/Makefile | 21 +++++++++------------
 2 files changed, 10 insertions(+), 13 deletions(-)

diff --git a/tools/Makefile b/tools/Makefile
index 79b4c7e3de..0c1d8b64a4 100644
--- a/tools/Makefile
+++ b/tools/Makefile
@@ -17,7 +17,7 @@ SUBDIRS-$(CONFIG_XCUTILS) += xcutils
 SUBDIRS-$(CONFIG_X86) += firmware
 SUBDIRS-y += console
 SUBDIRS-y += xenmon
-SUBDIRS-y += xentop
+SUBDIRS-$(XENSTAT_XENTOP) += xentop
 SUBDIRS-y += libfsimage
 SUBDIRS-$(CONFIG_Linux) += vchan
 
diff --git a/tools/xentop/Makefile b/tools/xentop/Makefile
index 0034114684..7bd96f34d5 100644
--- a/tools/xentop/Makefile
+++ b/tools/xentop/Makefile
@@ -13,36 +13,33 @@
 XEN_ROOT=$(CURDIR)/../..
 include $(XEN_ROOT)/tools/Rules.mk
 
-ifneq ($(XENSTAT_XENTOP),y)
-.PHONY: all install xentop uninstall
-all install xentop uninstall:
-else
-
 CFLAGS += -DGCC_PRINTF -Werror $(CFLAGS_libxenstat)
 LDLIBS += $(LDLIBS_libxenstat) $(CURSES_LIBS) $(TINFO_LIBS) $(SOCKET_LIBS) -lm
 CFLAGS += -DHOST_$(XEN_OS)
 
 # Include configure output (config.h)
 CFLAGS += -include $(XEN_ROOT)/tools/config.h
-LDFLAGS += $(APPEND_LDFLAGS)
+
+TARGETS := xentop
 
 .PHONY: all
-all: xentop
+all: $(TARGETS)
+
+xentop: xentop.o
+	$(CC) $(LDFLAGS) -o $@ $< $(LDLIBS) $(APPEND_LDFLAGS)
 
 .PHONY: install
-install: xentop
+install: all
 	$(INSTALL_DIR) $(DESTDIR)$(sbindir)
-	$(INSTALL_PROG) xentop $(DESTDIR)$(sbindir)/xentop
+	$(INSTALL_PROG) $(TARGETS) $(DESTDIR)$(sbindir)
 
 .PHONY: uninstall
 uninstall:
 	rm -f $(DESTDIR)$(sbindir)/xentop
 
-endif
-
 .PHONY: clean
 clean:
-	rm -f xentop xentop.o $(DEPS_RM)
+	$(RM) *.o $(TARGETS) $(DEPS_RM)
 
 .PHONY: distclean
 distclean: clean
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Fri Feb 25 15:14:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 15:14:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279192.476888 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcIG-0002VC-4m; Fri, 25 Feb 2022 15:14:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279192.476888; Fri, 25 Feb 2022 15:14:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcIF-0002Uw-UM; Fri, 25 Feb 2022 15:14:03 +0000
Received: by outflank-mailman (input) for mailman id 279192;
 Fri, 25 Feb 2022 15:14:01 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=E0Ll=TI=citrix.com=prvs=04808661d=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nNcID-0006fy-KF
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 15:14:01 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8ea134df-964d-11ec-8539-5f4723681683;
 Fri, 25 Feb 2022 16:14:00 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8ea134df-964d-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645802040;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=vttR2ey9IAO0GfyGTtbLDlIQNMB1Ci4jM1PA3CUcb8k=;
  b=KB/LrD5ag1nUBMErNqY/ChMDFWQ/L4vdX+ZeIxXusFwnzpbGIg2j4nux
   /z7s0Aye08Uk0Sz9lCjJZyu//lXdoGIKw2fx8ZZBctivT0dstXfJ46llD
   Xq6Vy/JVNiT7PlBKvws8xv+sXYJ3KKFf6q7ZHM8LeIbygqJCs6dvFo+rf
   0=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 65000303
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:D2Lds6sCbDgK7S4cYOrOCa6QDOfnVCxeMUV32f8akzHdYApBsoF/q
 tZmKWyEaf+MNmbxc4sgao23/UsC75+Gy941Gwptri5kEy5G+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQyw4bVvqYy2YLjW1nX5
 IuoyyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb
 /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo
 Oihu6BcRi9uY4bl3/oMCyVBHmZsJvBC+uPcBCKg5Jn7I03uKxMAwt1rBUAye4YZ5vx2ESdF8
 vlwxDIlN07ZwbjsmfTiF7cq1p9LwMrDZevzvllpyy3ZCvA3B4jOWazQ6fdT3Ssqh9AIFvHbD
 yYcQWQyNEyYOEUUUrsRII4dssv5nynAShtnjW6Xi/co6nTLzSUkhdABN/KKI4fXFK25hH2wp
 G3c+H/iKgoHL9HZwj2AmlqzgsffkCW9X5gdfJWo+/gvjFCNy2g7DBwNSUD9sfS/klS5Wd9UN
 woT4CVGkEQp3BX1FJ+nBUT++SPa+E5HMzZNLwEkwEbQ4YOT/RfBOnEJCSxaNdgk6NQTHyN/g
 zdlgOjVLTBotbSUT1eU+bGVsS6+NEApEIMSWcMXZVBbuoe++enfmjqKF48+S/Dt0rUZDBmtm
 2jikcQou1kEYSfnPY2f9EuPvT+jr4OhouUdtlSOBTLNAu+UieeYi22UBbrzsacowGWxFADpU
 J04dy62trFm4XalznHlfQn1NOv1j8tpyRWF6bKVI7Ev9i6251modp1K7Td1KS9Ba5hYJGC1O
 ROO4VsJvPe/2UdGi4ctMupd7OxwkMDd+SnNDKiIPrKinLArHON4wM2eTRHJhD28+KTduao+J
 Y2aYa6R4YUyUsxaIM6Nb75Fi9cDn3lmrUuKHMyT50n3gNK2OS/OIZ9YYQTmUwzMxP7dyOkj2
 40EbJXiJtQ2eLCWXxQ7BqZIdQFadSVgXMuuwyGVH8baSjdb9KgaI6e56dscl0ZNxMy5Ss+gE
 qmBZ3Jl
IronPort-HdrOrdr: A9a23:oa4zPK2qm5e5XYUDTcpd6AqjBLgkLtp133Aq2lEZdPRUGvb2qy
 nIpoV/6faUskd3ZJhOo7G90cW7LE80lqQFg7X5X43DYOCOggLBR+tfBOPZslnd8kbFmNK1u5
 0NT0EHMqySMWRH
X-IronPort-AV: E=Sophos;i="5.90,136,1643691600"; 
   d="scan'208";a="65000303"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@citrix.com>, Wei Liu <wl@xen.org>, "Juergen
 Gross" <jgross@suse.com>
Subject: [XEN PATCH v2 15/29] libs: Remove need for *installlocal targets
Date: Fri, 25 Feb 2022 15:13:07 +0000
Message-ID: <20220225151321.44126-16-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220225151321.44126-1-anthony.perard@citrix.com>
References: <20220225151321.44126-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

There is no need for an extra "installlocal" target, we can use
double-colon rules instead.

"install-headers" in "libs/store" was introduced for the same reason
that "installlocal" exist, so it is replaced as well.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---

Notes:
    v2:
    - fix libs/stat/Makefile, make *install targets of the binding also
      double-column.

 tools/libs/light/Makefile | 10 ++--------
 tools/libs/stat/Makefile  |  8 ++++----
 tools/libs/store/Makefile | 10 ++--------
 tools/libs/libs.mk        |  4 ++--
 4 files changed, 10 insertions(+), 22 deletions(-)

diff --git a/tools/libs/light/Makefile b/tools/libs/light/Makefile
index 7c0a5dca85..769e2a83e2 100644
--- a/tools/libs/light/Makefile
+++ b/tools/libs/light/Makefile
@@ -239,17 +239,11 @@ libxl-save-helper: $(SAVE_HELPER_OBJS) libxenlight.so
 testidl: testidl.o libxenlight.so
 	$(CC) $(LDFLAGS) -o $@ testidl.o $(LDLIBS_libxenlight) $(LDLIBS_libxentoollog) $(LDLIBS_libxentoolcore) $(APPEND_LDFLAGS)
 
-install: installlocal $(LIBHEADERS)
-
-.PHONY: installlocal
-installlocal: libxl-save-helper
+install:: $(LIBHEADERS) libxl-save-helper
 	$(INSTALL_DIR) $(DESTDIR)$(LIBEXEC_BIN)
 	$(INSTALL_PROG) libxl-save-helper $(DESTDIR)$(LIBEXEC_BIN)
 
-uninstall: uninstalllocal
-
-.PHONY: uninstalllocal
-uninstalllocal:
+uninstall::
 	rm -f $(DESTDIR)$(LIBEXEC_BIN)/libxl-save-helper
 
 clean: cleanlocal
diff --git a/tools/libs/stat/Makefile b/tools/libs/stat/Makefile
index 6cd0af5239..1aef25a9bb 100644
--- a/tools/libs/stat/Makefile
+++ b/tools/libs/stat/Makefile
@@ -78,8 +78,8 @@ uninstall-python-bindings:
 ifeq ($(XENSTAT_PYTHON_BINDINGS),y)
 .PHONY: all
 all: python-bindings
-install: install-python-bindings
-uninstall: uninstall-python-bindings
+install:: install-python-bindings
+uninstall:: uninstall-python-bindings
 endif
 
 # Perl bindings
@@ -111,8 +111,8 @@ ifeq ($(XENSTAT_PERL_BINDINGS),y)
 all: perl-bindings
 
 .PHONY: install
-install: install-perl-bindings
-uninstall: uninstall-perl-bindings
+install:: install-perl-bindings
+uninstall:: uninstall-perl-bindings
 endif
 
 clean: cleanlocal
diff --git a/tools/libs/store/Makefile b/tools/libs/store/Makefile
index 18ae1fe94d..b94060be8d 100644
--- a/tools/libs/store/Makefile
+++ b/tools/libs/store/Makefile
@@ -30,10 +30,7 @@ xs.opic: CFLAGS += -DUSE_DLSYM
 endif
 
 .PHONY: install
-install: install-headers
-
-.PHONY: install-headers
-install-headers:
+install::
 	$(INSTALL_DIR) $(DESTDIR)$(includedir)
 	$(INSTALL_DIR) $(DESTDIR)$(includedir)/xenstore-compat
 	$(INSTALL_DATA) $(XEN_INCLUDE)/xenstore-compat/xs.h $(DESTDIR)$(includedir)/xenstore-compat/xs.h
@@ -42,10 +39,7 @@ install-headers:
 	ln -sf xenstore-compat/xs_lib.h $(DESTDIR)$(includedir)/xs_lib.h
 
 .PHONY: uninstall
-uninstall: uninstall-headers
-
-.PHONY: uninstall-headers
-uninstall-headers:
+uninstall::
 	rm -f $(DESTDIR)$(includedir)/xs_lib.h
 	rm -f $(DESTDIR)$(includedir)/xs.h
 	rm -f $(DESTDIR)$(includedir)/xenstore-compat/xs_lib.h
diff --git a/tools/libs/libs.mk b/tools/libs/libs.mk
index 3118cb4194..a173f59a8b 100644
--- a/tools/libs/libs.mk
+++ b/tools/libs/libs.mk
@@ -100,7 +100,7 @@ endif
 endif
 
 .PHONY: install
-install: all
+install:: all
 	$(INSTALL_DIR) $(DESTDIR)$(libdir)
 	$(INSTALL_DIR) $(DESTDIR)$(includedir)
 	$(INSTALL_SHLIB) lib$(LIB_FILE_NAME).so.$(MAJOR).$(MINOR) $(DESTDIR)$(libdir)
@@ -111,7 +111,7 @@ install: all
 	$(INSTALL_DATA) $(PKG_CONFIG) $(DESTDIR)$(PKG_INSTALLDIR)
 
 .PHONY: uninstall
-uninstall:
+uninstall::
 	rm -f $(DESTDIR)$(PKG_INSTALLDIR)/$(LIB_FILE_NAME).pc
 	for i in $(LIBHEADER); do rm -f $(DESTDIR)$(includedir)/$$i; done
 	rm -f $(DESTDIR)$(libdir)/lib$(LIB_FILE_NAME).so
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Fri Feb 25 15:14:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 15:14:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279194.476899 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcII-000365-Rx; Fri, 25 Feb 2022 15:14:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279194.476899; Fri, 25 Feb 2022 15:14:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcII-00035Y-FQ; Fri, 25 Feb 2022 15:14:06 +0000
Received: by outflank-mailman (input) for mailman id 279194;
 Fri, 25 Feb 2022 15:14:05 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=E0Ll=TI=citrix.com=prvs=04808661d=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nNcIH-0006fy-Ap
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 15:14:05 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 90b877c9-964d-11ec-8539-5f4723681683;
 Fri, 25 Feb 2022 16:14:04 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 90b877c9-964d-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645802044;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=ECjrP9xItuWCPbZk1vIvsP9mwRYqVRzBpP4c/9vcJbk=;
  b=AtUAtz/gP8g1le1Y+n21yZF/MJ5bWkIbGsA2cgJ3nsByF9RLqWB+xMIO
   A0UYQjqKaKWKuHVbvQ8oskmAdLZ0EwBLLLqBRugs6TEKXMS7uTf/7qQ0s
   XwQK/g4xB6sv9RGtV9EGi5M8p/ADZHwA5zuP/+QM2+wQ04/5XIOIbJVvm
   0=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 64433043
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:BEphi65W27NUIGGmTy09ZQxRtD3HchMFZxGqfqrLsTDasY5as4F+v
 jFLX2qGP6rcN2GjeNojaY7koBwFv8XQy9FhGlRpqHg9Hi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0XqPp8Zj2tQy2YLjXlvX0
 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X
 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx
 umhurToSj8wF4vPuNgceEhhTihHYIFX2ZPIdC3XXcy7lyUqclPpyvRqSko3IZcZ6qB8BmQmG
 f4wcW5XKErZ3qTvnez9GrIEascLdaEHOKsWvG1gyjfIS+4rW5nZT43B5MNC3Sd2jcdLdRrbT
 5RFNWE0NEibC/FJEm1PDcMGo+7yvSbcdSVolEnEq4kw8lGGmWSd15CyaYGIK7RmX/59gUKwt
 m/AuWPjDXkyNtOFziGe2mmxneKJliT+MKoCGbv9+vN0jVm7wm0IFAZQRVa9ueO+iEO1R5RYM
 UN8x8Y1hfFsrgrxFIC7BkDm5i7f1vIBZzZOO7U50Bik7Kn03weyV1FZRwccRM0HmMBjEFTGy
 WS1t9/uADVutpicRnSc6qqYoFuOBMQFEYMRTXRaFFVYurEPtKl210uSFYg7TMZZm/WoQWmY/
 tyckMQpa1z/Z+Yv3r7zw13IiinESnPhHl9svVW/so5IA2pEiG+Zi26AtQmzARVodt/xory9U
 J4swZn2AAcmV8zlqcB1aL9RdIxFHt7cWNEmvXZhHoM66xOm8GO5cIZb7VlWfRk1b5lYIGO0O
 BeL4Wu9AaO/2lPwPMebhKrrVqwXIVXIT4y5Bpg4kPIUCnSOSON31H43PhPBt4wcuEMtjbs+K
 f+mnTWEVh4n5VBc5GPuHY81iOZzrghnnD+7bc2rnnyPjOvFDFbIGOhtDbd7Rr1ghE9yiF6Oq
 Ig32grj40g3bdASlQGMqd9DdQ1RdCNjbX00wuQOHtO+zsNdMDlJI5fsLXkJIdcNc3h9/gsQw
 kyAZw==
IronPort-HdrOrdr: A9a23:73PudKs1DQmwVPdIvLu9yGJ/7skDcNV00zEX/kB9WHVpmszxra
 +TdZMgpHjJYVcqKQgdcL+7WZVoLUmwyXcx2/hyAV7AZniDhILLFuFfBOLZqlWKcREWtNQtsJ
 uIG5IObuEYZmIVsS+V2mWF+q4bsbq6zJw=
X-IronPort-AV: E=Sophos;i="5.90,136,1643691600"; 
   d="scan'208";a="64433043"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross
	<jgross@suse.com>, Wei Liu <wl@xen.org>
Subject: [XEN PATCH v2 14/29] libs: rename LDUSELIBS to LDLIBS and use it instead of APPEND_LDFLAGS
Date: Fri, 25 Feb 2022 15:13:06 +0000
Message-ID: <20220225151321.44126-15-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220225151321.44126-1-anthony.perard@citrix.com>
References: <20220225151321.44126-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

LDLIBS is more appropriate and intended to be used to add library
dependencies. APPEND_LDFLAGS wasn't intended to be changed by the
build system.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
---

Notes:
    v2:
    - reviewed

 tools/libs/guest/Makefile |  2 +-
 tools/libs/hypfs/Makefile |  2 +-
 tools/libs/light/Makefile | 18 +++++++++---------
 tools/libs/stat/Makefile  |  2 +-
 tools/libs/store/Makefile |  2 +-
 tools/libs/libs.mk        |  4 ++--
 6 files changed, 15 insertions(+), 15 deletions(-)

diff --git a/tools/libs/guest/Makefile b/tools/libs/guest/Makefile
index ab580e1b64..2005d8a67d 100644
--- a/tools/libs/guest/Makefile
+++ b/tools/libs/guest/Makefile
@@ -102,7 +102,7 @@ NO_HEADERS_CHK := y
 
 include $(XEN_ROOT)/tools/libs/libs.mk
 
-libxenguest.so.$(MAJOR).$(MINOR): APPEND_LDFLAGS += $(ZLIB_LIBS) -lz
+libxenguest.so.$(MAJOR).$(MINOR): LDLIBS += $(ZLIB_LIBS) -lz
 
 .PHONY: cleanlocal
 cleanlocal:
diff --git a/tools/libs/hypfs/Makefile b/tools/libs/hypfs/Makefile
index 39feca87e8..efa955bd50 100644
--- a/tools/libs/hypfs/Makefile
+++ b/tools/libs/hypfs/Makefile
@@ -4,7 +4,7 @@ include $(XEN_ROOT)/tools/Rules.mk
 MAJOR    = 1
 MINOR    = 0
 
-APPEND_LDFLAGS += -lz
+LDLIBS += -lz
 
 SRCS-y                 += core.c
 
diff --git a/tools/libs/light/Makefile b/tools/libs/light/Makefile
index 453bea0067..7c0a5dca85 100644
--- a/tools/libs/light/Makefile
+++ b/tools/libs/light/Makefile
@@ -166,14 +166,14 @@ NO_HEADERS_CHK := y
 
 include $(XEN_ROOT)/tools/libs/libs.mk
 
-LDUSELIBS-y += $(PTYFUNCS_LIBS)
-LDUSELIBS-$(CONFIG_LIBNL) += $(LIBNL3_LIBS)
-LDUSELIBS-$(CONFIG_Linux) += -luuid
-LDUSELIBS-$(CONFIG_Linux) += -lrt
-LDUSELIBS-$(CONFIG_ARM) += -lfdt
-LDUSELIBS-y += $(PTHREAD_LIBS)
-LDUSELIBS-y += -lyajl
-LDUSELIBS += $(LDUSELIBS-y)
+LDLIBS-y += $(PTYFUNCS_LIBS)
+LDLIBS-$(CONFIG_LIBNL) += $(LIBNL3_LIBS)
+LDLIBS-$(CONFIG_Linux) += -luuid
+LDLIBS-$(CONFIG_Linux) += -lrt
+LDLIBS-$(CONFIG_ARM) += -lfdt
+LDLIBS-y += $(PTHREAD_LIBS)
+LDLIBS-y += -lyajl
+LDLIBS += $(LDLIBS-y)
 
 $(LIB_OBJS) $(PIC_OBJS) $(LIBXL_TEST_OBJS): CFLAGS += $(CFLAGS_LIBXL) -include $(XEN_ROOT)/tools/config.h
 $(ACPI_OBJS) $(ACPI_PIC_OBJS): CFLAGS += -I. -DLIBACPI_STDUTILS=\"$(CURDIR)/libxl_x86_acpi.h\"
@@ -228,7 +228,7 @@ $(XEN_INCLUDE)/_%.h: _%.h
 	$(call move-if-changed,_$*.h,$(XEN_INCLUDE)/_$*.h)
 
 libxenlight_test.so: $(PIC_OBJS) $(LIBXL_TEST_OBJS)
-	$(CC) $(LDFLAGS) -Wl,$(SONAME_LDFLAG) -Wl,libxenlight.so.$(MAJOR) $(SHLIB_LDFLAGS) -o $@ $^ $(LDUSELIBS) $(APPEND_LDFLAGS)
+	$(CC) $(LDFLAGS) -Wl,$(SONAME_LDFLAG) -Wl,libxenlight.so.$(MAJOR) $(SHLIB_LDFLAGS) -o $@ $^ $(LDLIBS) $(APPEND_LDFLAGS)
 
 test_%: test_%.o test_common.o libxenlight_test.so
 	$(CC) $(LDFLAGS) -o $@ $^ $(filter-out %libxenlight.so, $(LDLIBS_libxenlight)) $(LDLIBS_libxentoollog) $(LDLIBS_libxentoolcore) -lyajl $(APPEND_LDFLAGS)
diff --git a/tools/libs/stat/Makefile b/tools/libs/stat/Makefile
index 5840213376..6cd0af5239 100644
--- a/tools/libs/stat/Makefile
+++ b/tools/libs/stat/Makefile
@@ -26,7 +26,7 @@ SRCS-$(CONFIG_FreeBSD) += xenstat_freebsd.c
 
 LDLIBS-y += -lyajl
 LDLIBS-$(CONFIG_SunOS) += -lkstat
-APPEND_LDFLAGS += $(LDLIBS-y)
+LDLIBS += $(LDLIBS-y)
 
 include $(XEN_ROOT)/tools/libs/libs.mk
 
diff --git a/tools/libs/store/Makefile b/tools/libs/store/Makefile
index 8e33db6a66..18ae1fe94d 100644
--- a/tools/libs/store/Makefile
+++ b/tools/libs/store/Makefile
@@ -5,7 +5,7 @@ MAJOR = 4
 MINOR = 0
 
 ifeq ($(CONFIG_Linux),y)
-APPEND_LDFLAGS += -ldl
+LDLIBS += -ldl
 endif
 
 SRCS-y   += xs_lib.c
diff --git a/tools/libs/libs.mk b/tools/libs/libs.mk
index b3d784c57f..3118cb4194 100644
--- a/tools/libs/libs.mk
+++ b/tools/libs/libs.mk
@@ -18,7 +18,7 @@ CFLAGS   += -Werror -Wmissing-prototypes
 CFLAGS   += $(CFLAGS_xeninclude)
 CFLAGS   += $(foreach lib, $(USELIBS_$(LIBNAME)), $(CFLAGS_libxen$(lib)))
 
-LDUSELIBS = $(foreach lib, $(USELIBS_$(LIBNAME)), $(LDLIBS_libxen$(lib)))
+LDLIBS += $(foreach lib, $(USELIBS_$(LIBNAME)), $(LDLIBS_libxen$(lib)))
 
 LIB_OBJS := $(SRCS-y:.c=.o)
 PIC_OBJS := $(SRCS-y:.c=.opic)
@@ -88,7 +88,7 @@ lib$(LIB_FILE_NAME).so.$(MAJOR): lib$(LIB_FILE_NAME).so.$(MAJOR).$(MINOR)
 	$(SYMLINK_SHLIB) $< $@
 
 lib$(LIB_FILE_NAME).so.$(MAJOR).$(MINOR): $(PIC_OBJS) libxen$(LIBNAME).map
-	$(CC) $(LDFLAGS) $(PTHREAD_LDFLAGS) -Wl,$(SONAME_LDFLAG) -Wl,lib$(LIB_FILE_NAME).so.$(MAJOR) $(SHLIB_LDFLAGS) -o $@ $(PIC_OBJS) $(LDUSELIBS) $(APPEND_LDFLAGS)
+	$(CC) $(LDFLAGS) $(PTHREAD_LDFLAGS) -Wl,$(SONAME_LDFLAG) -Wl,lib$(LIB_FILE_NAME).so.$(MAJOR) $(SHLIB_LDFLAGS) -o $@ $(PIC_OBJS) $(LDLIBS) $(APPEND_LDFLAGS)
 
 # If abi-dumper is available, write out the ABI analysis
 ifneq ($(ABI_DUMPER),)
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Fri Feb 25 15:16:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 15:16:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279237.476910 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcKH-0006dp-FN; Fri, 25 Feb 2022 15:16:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279237.476910; Fri, 25 Feb 2022 15:16:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcKH-0006dg-AZ; Fri, 25 Feb 2022 15:16:09 +0000
Received: by outflank-mailman (input) for mailman id 279237;
 Fri, 25 Feb 2022 15:16:08 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=E0Ll=TI=citrix.com=prvs=04808661d=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nNcIN-0006fy-Re
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 15:14:11 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 94bd007a-964d-11ec-8539-5f4723681683;
 Fri, 25 Feb 2022 16:14:10 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 94bd007a-964d-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645802050;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=W0bxiqkDioEV6QfS2tr8a6KFXyY+fCoCDm7KXgI9vhg=;
  b=O0uXr1DJ1UpyOgGqzR5nsHWdanyij+3B/gEI+FjbrMCr76S3J3XTueDe
   ACqFFHJ+RyQzcA8knjxB70YqF6Zz0dXIeZ7YFMRlHPsyTCeYhGLwcC/c/
   UPrmFicAhVk+aX/MYb2S600OgHrEJFHSB1jtG+GLiOSGE8rsGHlPo/u8Y
   A=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 64998418
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:oYeLqqiMLvOXISJm/8lR0+BBX161GhAKZh0ujC45NGQN5FlHY01je
 htvXT2DaKmNM2HzKIt+aYjkpE4A68LSydMwTwVqr3w0FS0b9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M78wIFqtQw24LhWVnQ4
 YmaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV
 efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9
 TlDiXC/YQQ0A/3ywOYPbzdzAjshG69q1fzjP1Hq5KR/z2WeG5ft6/BnDUVwNowE4OdnR2pJ8
 JT0KhhUMErF3bjvhuvmFK883azPL+GyVG8bknhm0THeC+dgWZ3ZSr/GzdRZwC0xloZFGvO2i
 88xN2Y+PUScOk0n1lE/VtE/hbiLolbFUDxSmUKYgod0unSO9VkkuFTqGIWMIYHbLSlPpW6Ho
 krW8mK/BQsVXPSdxiCC6WmEnfLUkGXwX4d6PK218LtmjUOewkQXCQYKTh2rrP+hkEm8VtlDb
 UsO9UITQbMarRLxCIOnBlvh/SDC7kV0t8ds//MS6xywmpSM4RSlKEMVVGFnavAL9+sobGl/v
 rOWpO/BCTtqubyTbHuS8LaIsD+/URQowX8+iTwsFlVcvYS6yG0npleWF4s4Tvbp5jHgMWyom
 1i3QD4Ca6L/ZCLh/4Gy5hj5jj2lvfAlpSZlt1yMDgpJAu6UDbNJhrBEC3CHvJ6sz67DFzFtW
 UTofeDEvYji6rnXyUSwrB0lRu3B2hp8GGS0baRTN5cg7S+x3HWoYJpd5jpzTG8wbJpZJmOwP
 BKL4VsJjHO2AJdMRfUmC25WI553pZUM6Py/DqyEBjawSsIZmPC7ENFGOhfLgjGFfLkEmqAjI
 5aLGftA/l5BYZmLOAGeHr9HuZdyn3hW7TqKGfjTkkT2uZLDNSX9YepUbzOzghURsfrsTPP9q
 I0EaaNnCnx3DYXDX8Ug2dVLfABScCNiXsieRg4+XrfrHzeK0VoJU5f5qY7NsaQ/90iJvo8kJ
 k2AZ3I=
IronPort-HdrOrdr: A9a23:2gbzpK3SaC2cCZBmduItOwqjBIokLtp133Aq2lEZdPRUGvb3qy
 nIpoV86faUskdoZJhOo7C90cW7LU80sKQFhLX5Xo3SOzUO2lHYT72KhLGKq1aLdhEWtNQtsZ
 uIG5IOceEYZmIasS+V2maF+q4bsbu6zJw=
X-IronPort-AV: E=Sophos;i="5.90,136,1643691600"; 
   d="scan'208";a="64998418"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross
	<jgross@suse.com>, Wei Liu <wl@xen.org>
Subject: [XEN PATCH v2 20/29] libs/store: use of -iquote instead of -I
Date: Fri, 25 Feb 2022 15:13:12 +0000
Message-ID: <20220225151321.44126-21-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220225151321.44126-1-anthony.perard@citrix.com>
References: <20220225151321.44126-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
---

Notes:
    v2:
    - reviewed

 tools/libs/store/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/libs/store/Makefile b/tools/libs/store/Makefile
index 778da51f95..2334c953bb 100644
--- a/tools/libs/store/Makefile
+++ b/tools/libs/store/Makefile
@@ -22,7 +22,7 @@ CFLAGS += -DXEN_LIB_STORED="\"$(XEN_LIB_STORED)\""
 CFLAGS += -DXEN_RUN_STORED="\"$(XEN_RUN_STORED)\""
 
 vpath xs_lib.c $(XEN_ROOT)/tools/xenstore
-CFLAGS += -I $(XEN_ROOT)/tools/xenstore
+CFLAGS += -iquote $(XEN_ROOT)/tools/xenstore
 
 xs.opic: CFLAGS += -DUSE_PTHREAD
 ifeq ($(CONFIG_Linux),y)
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Fri Feb 25 15:16:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 15:16:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279248.476920 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcKT-00074y-NQ; Fri, 25 Feb 2022 15:16:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279248.476920; Fri, 25 Feb 2022 15:16:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcKT-00074r-Jz; Fri, 25 Feb 2022 15:16:21 +0000
Received: by outflank-mailman (input) for mailman id 279248;
 Fri, 25 Feb 2022 15:16:20 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=E0Ll=TI=citrix.com=prvs=04808661d=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nNcII-0007Bf-QD
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 15:14:06 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9233d2c5-964d-11ec-8eb9-a37418f5ba1a;
 Fri, 25 Feb 2022 16:14:05 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9233d2c5-964d-11ec-8eb9-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645802045;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=ucmQHqhfA/0/4TjBEifr4fx+A1LGfu70XMt0V9W8px4=;
  b=XjNQ8kTxd1DYdklKUzRPdh0s4EdJDjQ75IjyFTmG00shNupOPGmg3q1H
   Wx4e62okaiccej9Ico6hky1VNSJAWtBKSzJbVPkuFvHWql7uPd/NmBsfj
   PDUEZQAGeb6dKvOvOtLmgSGaQPNmdZRFfzk6dfsOnH6EZRokC51sa21UD
   4=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 64433048
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:chIKra+G99YQrBgf6eO+DrUDhX6TJUtcMsCJ2f8bNWPcYEJGY0x3z
 WMWCDjXPKqMajb0c49+aI7i8xhVuMDRzNFiG1Y5qyw8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si+Fa+Sn9T8mvU2xbuKU5NTsY0idfic5DnZ54f5fs7Rh2NQw24LkW1nlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCnaWOaA0zP6jRpPRDCgZ9Mzs9H61Nx7CSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFIoZpnFnyyCfFfs8SIrPa67L+cVZzHE7gcUm8fP2O
 ZZFMmE3MESojxtnEHk3MaIjk+mUnmT7Ug9c9BWclYs6yj2GpOB2+Oe0a4eEEjCQfu1XkVyfv
 Xnu5HniD1cRM9n34SWB2mKhgKnIhyyTcJIfEvi0++BnhHWXx3cPE1sGWF2ju/67h0WiHdVFJ
 CQpFjEG9PZoshbxF5+kAkP+8CXsUgMgt8R4KtMb4huMz7fo81jAGU0kVH1jaNcZu5pjLdA17
 WOhk9TsDD1plbSaT3OB67uZxQ+P1TgpwXwqPnFdE1ZcizX3iMRq10+UEI4/eEKgpoCtQVnNL
 ya2QD/Sbln5peoCzO2F8F/OmFpATbCZH1dutm07so9Ihz6VhbJJhaT0uDA3Dt4ade51q2VtW
 lBeyqByC8hUUPmweNSlGrllIV1Qz6/t3MfgqVBuBYI90D+m5mSue4tdiBknehs0bZpdJWKxO
 BeL0e+02HO1FCH7BUOQS9jsY/nGMIC6TYi1PhwqRoAmjmdNmP+vo3g1OB/4M5HFm0kwi6AvU
 ap3gu73ZUv2/Z9PlWLsL89EiOdD7nlnmQv7GMCqpzz6gOH2TCPEFt843K6mM7lRAFWs+16Or
 b6y9qKiln1ibQEJSnKPoN5LcAtTdiBT6FKfg5U/S9Nv6zFOQAkJY8I9C5t7I+SJQ4w9ej/0w
 0yA
IronPort-HdrOrdr: A9a23:1SBHSKyZzm3UNs6jJ+gNKrPwJr1zdoMgy1knxilNoRw8SKOlfq
 eV7ZEmPH7P+VEssR4b+OxoVJPsfZq+z+8W3WByB9eftWDd0QPCRr2KhbGSpwEIcBeRygcy78
 tdmtBFeb7NMWQ=
X-IronPort-AV: E=Sophos;i="5.90,136,1643691600"; 
   d="scan'208";a="64433048"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@citrix.com>, Wei Liu <wl@xen.org>, "Juergen
 Gross" <jgross@suse.com>
Subject: [XEN PATCH v2 16/29] libs,tools/include: Clean "clean" targets
Date: Fri, 25 Feb 2022 15:13:08 +0000
Message-ID: <20220225151321.44126-17-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220225151321.44126-1-anthony.perard@citrix.com>
References: <20220225151321.44126-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

There is no need for an extra "cleanlocal" target, we can use
double-colon rules instead.

Generated headers are now in tools/include/, so remove those file
there.

Remove -f flag as it's already in $(RM).

libs.mk:
  - don't try to remove "*.rpm" anymore.

libs/light:
  - "_paths.*.tmp" isn't created anymore.
  - clean "libxenlight_test.so" and "libxl_test_*.opic".

libs/stat:
  - don't remove $(DEPS_RM) from here as it is already done in
    "libs.mk".

libs/util:
  - fix clean of version-script file.

include/xen-foreign:
  - remove __pycache__

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---

Notes:
    v2:
    - stop removing $(DEPS_RM) from libs/stat/Makefile.

 tools/include/Makefile             |  1 +
 tools/include/xen-foreign/Makefile |  1 +
 tools/libs/ctrl/Makefile           |  5 +----
 tools/libs/guest/Makefile          |  3 +--
 tools/libs/light/Makefile          | 19 ++++++++-----------
 tools/libs/stat/Makefile           |  8 ++------
 tools/libs/util/Makefile           |  7 ++-----
 tools/libs/vchan/Makefile          |  5 +----
 tools/libs/libs.mk                 |  4 ++--
 9 files changed, 19 insertions(+), 34 deletions(-)

diff --git a/tools/include/Makefile b/tools/include/Makefile
index d965987f55..3a03a0b0fa 100644
--- a/tools/include/Makefile
+++ b/tools/include/Makefile
@@ -82,6 +82,7 @@ uninstall:
 clean:
 	rm -rf xen xen-xsm acpi
 	$(MAKE) -C xen-foreign clean
+	rm -f _*.h
 
 .PHONY: dist
 dist: install
diff --git a/tools/include/xen-foreign/Makefile b/tools/include/xen-foreign/Makefile
index 6ce51daf5e..b538d0ea94 100644
--- a/tools/include/xen-foreign/Makefile
+++ b/tools/include/xen-foreign/Makefile
@@ -13,6 +13,7 @@ clean:
 	rm -f $(headers)
 	rm -f checker checker.c
 	rm -f *.pyc *.o *~
+	rm -rf __pycache__
 
 distclean: clean
 
diff --git a/tools/libs/ctrl/Makefile b/tools/libs/ctrl/Makefile
index ef7362327f..f58c4ef1aa 100644
--- a/tools/libs/ctrl/Makefile
+++ b/tools/libs/ctrl/Makefile
@@ -54,8 +54,5 @@ NO_HEADERS_CHK := y
 
 include $(XEN_ROOT)/tools/libs/libs.mk
 
-clean: cleanlocal
-
-.PHONY: cleanlocal
-cleanlocal:
+clean::
 	rm -f libxenctrl.map
diff --git a/tools/libs/guest/Makefile b/tools/libs/guest/Makefile
index 2005d8a67d..56483c545f 100644
--- a/tools/libs/guest/Makefile
+++ b/tools/libs/guest/Makefile
@@ -104,6 +104,5 @@ include $(XEN_ROOT)/tools/libs/libs.mk
 
 libxenguest.so.$(MAJOR).$(MINOR): LDLIBS += $(ZLIB_LIBS) -lz
 
-.PHONY: cleanlocal
-cleanlocal:
+clean::
 	rm -f libxenguest.map
diff --git a/tools/libs/light/Makefile b/tools/libs/light/Makefile
index 769e2a83e2..0c04a5b5cb 100644
--- a/tools/libs/light/Makefile
+++ b/tools/libs/light/Makefile
@@ -246,15 +246,12 @@ install:: $(LIBHEADERS) libxl-save-helper
 uninstall::
 	rm -f $(DESTDIR)$(LIBEXEC_BIN)/libxl-save-helper
 
-clean: cleanlocal
-
-.PHONY: cleanlocal
-cleanlocal:
-	$(RM) -f _*.h *.o $(CLIENTS)
-	$(RM) -f _*.c *.pyc _paths.*.tmp _*.api-for-check
-	$(RM) -f testidl.c.new testidl.c *.api-ok
-	$(RM) -f $(TEST_PROGS)
-	$(RM) -rf __pycache__
-	$(RM) -f libxenlight.map
-	$(RM) -f $(AUTOSRCS) $(AUTOINCS)
+clean::
+	$(RM) _*.h *.o $(CLIENTS)
+	$(RM) _*.c *.pyc _*.api-for-check
+	$(RM) testidl.c.new testidl.c *.api-ok
+	$(RM) $(TEST_PROGS) libxenlight_test.so libxl_test_*.opic
+	$(RM) -r __pycache__
+	$(RM) libxenlight.map
+	$(RM) $(AUTOSRCS) $(AUTOINCS)
 	$(MAKE) -C $(ACPI_PATH) ACPI_BUILD_DIR=$(CURDIR) clean
diff --git a/tools/libs/stat/Makefile b/tools/libs/stat/Makefile
index 1aef25a9bb..39a671d7ed 100644
--- a/tools/libs/stat/Makefile
+++ b/tools/libs/stat/Makefile
@@ -115,9 +115,5 @@ install:: install-perl-bindings
 uninstall:: uninstall-perl-bindings
 endif
 
-clean: cleanlocal
-
-.PHONY: cleanlocal
-cleanlocal:
-	rm -f $(BINDINGS) $(BINDINGSRC) $(DEPS_RM)
-	rm -f libxenstat.map
+clean::
+	$(RM) libxenstat.map $(BINDINGS) $(BINDINGSRC)
diff --git a/tools/libs/util/Makefile b/tools/libs/util/Makefile
index 72fecb4c49..7a658e9446 100644
--- a/tools/libs/util/Makefile
+++ b/tools/libs/util/Makefile
@@ -49,8 +49,5 @@ $(LIB_OBJS) $(PIC_OBJS): $(AUTOINCS)
 	@rm -f $*.[ch]
 	$(FLEX) --header-file=$*.h --outfile=$*.c $<
 
-clean: cleanlocal
-
-.PHONY: cleanlocal
-cleanlocal:
-	$(RM) -f libxlutil.map
+clean::
+	$(RM) libxenutil.map
diff --git a/tools/libs/vchan/Makefile b/tools/libs/vchan/Makefile
index 83a45d2817..4ccb4dd1f6 100644
--- a/tools/libs/vchan/Makefile
+++ b/tools/libs/vchan/Makefile
@@ -12,8 +12,5 @@ NO_HEADERS_CHK := y
 
 include $(XEN_ROOT)/tools/libs/libs.mk
 
-clean: cleanlocal
-
-.PHONY: cleanlocal
-cleanlocal:
+clean::
 	rm -f libxenvchan.map
diff --git a/tools/libs/libs.mk b/tools/libs/libs.mk
index a173f59a8b..c2eaefc928 100644
--- a/tools/libs/libs.mk
+++ b/tools/libs/libs.mk
@@ -124,8 +124,8 @@ TAGS:
 	etags -t *.c *.h
 
 .PHONY: clean
-clean:
-	rm -rf *.rpm $(LIB) *~ $(DEPS_RM) $(LIB_OBJS) $(PIC_OBJS)
+clean::
+	rm -rf $(LIB) *~ $(DEPS_RM) $(LIB_OBJS) $(PIC_OBJS)
 	rm -f lib$(LIB_FILE_NAME).so.$(MAJOR).$(MINOR) lib$(LIB_FILE_NAME).so.$(MAJOR)
 	rm -f headers.chk headers.lst
 	rm -f $(PKG_CONFIG)
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Fri Feb 25 15:16:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 15:16:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279250.476926 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcKU-00077a-0w; Fri, 25 Feb 2022 15:16:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279250.476926; Fri, 25 Feb 2022 15:16:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcKT-000773-Rt; Fri, 25 Feb 2022 15:16:21 +0000
Received: by outflank-mailman (input) for mailman id 279250;
 Fri, 25 Feb 2022 15:16:20 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=E0Ll=TI=citrix.com=prvs=04808661d=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nNcIa-0007Bf-6O
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 15:14:24 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9c196b56-964d-11ec-8eb9-a37418f5ba1a;
 Fri, 25 Feb 2022 16:14:23 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9c196b56-964d-11ec-8eb9-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645802062;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=PjwCsNWxlB3gIKV9SoGAb5GW19kuozp+yzWw4gCwjzk=;
  b=iFrMEcm3XYP/19IRvxvJ/Vfi2cJ7RdYppZAQusk3SggO4hgP8Fhcwxm5
   dg5+32DICiQU0WgVS14dDfgU2O1f33gFQtgCa2WOxTgM2CwOXUls4IEj0
   X8cqC6y8mwbe0U8tQBwP/JqoFljdFmReJjuTrBVLRT8FWTiSDyHqEVCyl
   o=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 65407611
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:no3q46wld09LXDghvzh6t+c+xirEfRIJ4+MujC+fZmUNrF6WrkUEm
 DFLUGyHOP6KMTb9Kd9+OYi3908HvZ+Ex4JjSFNprSAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGX9JZS5LwbZj2NYy24XhWWthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 NpljsKdEiQUHKn2mekhXhBUSSRTZ7McweqSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DNYUDunZm3HfBAOwvW5zrSKTW/95Imjw3g6iiGN6AO
 pZBNmQ2NXwsZTUXC2Y3S41npt6Lizr/XmBF8lO0ipIOtj27IAtZj+G2bYu9lsaxbdpRtlaVo
 CTB5WuRKgoTMcGSzXyZ8nOmj/LLgQv2XplXEKy/8LhtmlL77nweDlgaWEW2pdG9i1WiQJRPJ
 koM4C0soKMuskuxQbHAswaQ+SDe+ERGApwJTrN8uFrlJrfoDxixPTYpFR18StgctcIKSDUmj
 Fqkxc2zPGk62FGKck61+rCRpDK0HCEaK24eeCMJJTc4D8nfTJIb1UyWEIs6eEKhppisQGyrn
 WjWxMQrr+hL1aY2O7OHEUcrat5GjrzAVUYL6wreRQpJBSspNdf+N+REBbU2hMuszbp1rHHd7
 RDoeODEtYji6K1hcgTXEY3h+5nzup643MX02wIHInXY323FF4SfVY5R+ipiA0xiL9wJfzTkC
 GeK518Mu8MKYCbyNfcvC25UNyjM5fKxfTgCfqqJBuein7ArLFPXlM2QTRT4M5/RfLgEzvhkZ
 MbznTeEBncGE6V3pAdatM9GuYLHMhsWnDuJLbiilkzP+ePHOBa9FOdUWHPTP7tRxP7V/23oH
 yN3apLiJ+N3C7alPEE6MOc7cDg3EJTMLcuu+pwPK7XaeVIO9aNII6a5/I7NsrdNx8x9/tokN
 FnkMqOE4DITXUH6FDg=
IronPort-HdrOrdr: A9a23:hKt77qjydAUsfVa8aUocqJQDB3BQXtwji2hC6mlwRA09TySZ//
 rAoB19726StN9xYgBYpTnuAsi9qB/nmKKdpLNhX4tKPzOW3FdATrsD0WKK+VSJcEfDH6xmpM
 JdmsBFebvN5DNB4/oSjjPVLz9Z+qjlzJyV
X-IronPort-AV: E=Sophos;i="5.90,136,1643691600"; 
   d="scan'208";a="65407611"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@citrix.com>, Samuel Thibault
	<samuel.thibault@ens-lyon.org>, Wei Liu <wl@xen.org>
Subject: [XEN PATCH v2 27/29] stubdom: build xenstore*-stubdom using new Makefile.common
Date: Fri, 25 Feb 2022 15:13:19 +0000
Message-ID: <20220225151321.44126-28-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220225151321.44126-1-anthony.perard@citrix.com>
References: <20220225151321.44126-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

Makefile.common have everything needed by stubdom, when used with
xenlibs.mk, so we don't need "Makefile" anymore.

Also, remove DESTDIR for "xenstore" related targets, "xenlibs.mk"
doesn't use DESTDIR so its value doesn't matter.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
---

Notes:
    v2:
    - reviewed

 stubdom/Makefile | 15 ++++++---------
 1 file changed, 6 insertions(+), 9 deletions(-)

diff --git a/stubdom/Makefile b/stubdom/Makefile
index 6b804824ba..1fa075b9ad 100644
--- a/stubdom/Makefile
+++ b/stubdom/Makefile
@@ -346,8 +346,7 @@ define do_links
   cd $(dir $@); \
   ln -sf $(dir $<)include/*.h include/; \
   ln -sf $(dir $<)*.[ch] .; \
-  [ -e $(dir $<)Makefile.common ] && ln -sf $(dir $<)Makefile.common . ||:; \
-  ln -sf $(dir $<)Makefile .
+  ln -sf $(dir $<)Makefile.common .
   touch $@
 endef
 
@@ -356,13 +355,11 @@ define BUILD_lib
  libxen$(1): libs-$$(XEN_TARGET_ARCH)/$(1)/libxen$(1).a
  libs-$$(XEN_TARGET_ARCH)/$(1)/libxen$(1).a: $$(LIBDEPS_$(1)) $$(LIBDEP_$(1))
  libs-$$(XEN_TARGET_ARCH)/$(1)/libxen$(1).a: mk-headers-$$(XEN_TARGET_ARCH) $$(NEWLIB_STAMPFILE) .phony
-	CPPFLAGS="$$(TARGET_CPPFLAGS)" CFLAGS="$$(TARGET_CFLAGS)" $$(MAKE) CONFIG_LIBXC_MINIOS=y $$(if $$(wildcard $$(@D)/Makefile.common),-f $(CURDIR)/xenlibs.mk) -C $$(@D) $$(@F)
+	CPPFLAGS="$$(TARGET_CPPFLAGS)" CFLAGS="$$(TARGET_CFLAGS)" $$(MAKE) CONFIG_LIBXC_MINIOS=y -f $(CURDIR)/xenlibs.mk -C $$(@D) $$(@F)
 
  clean-libxen$(1):
 	if [ -e libs-$$(XEN_TARGET_ARCH)/$(1)/Makefile.common ]; then \
 	    $$(MAKE) -f $(CURDIR)/xenlibs.mk -C libs-$$(XEN_TARGET_ARCH)/$(1) clean; \
-	elif [ -e libs-$$(XEN_TARGET_ARCH)/$(1)/Makefile ]; then \
-	    $$(MAKE) -C libs-$$(XEN_TARGET_ARCH)/$(1) clean; \
 	fi
 
  libs-$$(XEN_TARGET_ARCH)/$(1)/stamp: $$(XEN_ROOT)/tools/libs/$(1)/Makefile.common
@@ -494,7 +491,7 @@ xenstore-minios-config.mk: $(CURDIR)/xenstore-minios.cfg
 
 .PHONY: xenstore
 xenstore: $(CROSS_ROOT) xenstore-minios-config.mk
-	CPPFLAGS="$(TARGET_CPPFLAGS) $(shell cat xenstore-minios-config.mk)" CFLAGS="$(TARGET_CFLAGS)" $(MAKE) DESTDIR= -C $@ xenstored.a CONFIG_STUBDOM=y
+	CPPFLAGS="$(TARGET_CPPFLAGS) $(shell cat xenstore-minios-config.mk)" CFLAGS="$(TARGET_CFLAGS)" $(MAKE) -f $(CURDIR)/xenlibs.mk -C $@ xenstored.a CONFIG_STUBDOM=y
 
 #############
 # xenstorepvh
@@ -505,7 +502,7 @@ xenstorepvh-minios-config.mk: $(CURDIR)/xenstorepvh-minios.cfg
 
 .PHONY: xenstorepvh
 xenstorepvh: $(CROSS_ROOT) xenstorepvh-minios-config.mk
-	CPPFLAGS="$(TARGET_CPPFLAGS) $(shell cat xenstorepvh-minios-config.mk)" CFLAGS="$(TARGET_CFLAGS)" $(MAKE) DESTDIR= -C $@ xenstored.a CONFIG_STUBDOM=y
+	CPPFLAGS="$(TARGET_CPPFLAGS) $(shell cat xenstorepvh-minios-config.mk)" CFLAGS="$(TARGET_CFLAGS)" $(MAKE) -f $(CURDIR)/xenlibs.mk -C $@ xenstored.a CONFIG_STUBDOM=y
 
 ########
 # minios
@@ -657,8 +654,8 @@ clean:
 	rm -f *-minios-config.mk
 	rm -fr pkg-config
 	-[ ! -d ioemu ] || $(MAKE) DESTDIR= -C ioemu clean
-	-[ ! -d xenstore ] || $(MAKE) DESTDIR= -C xenstore clean
-	-[ ! -d xenstorepvh ] || $(MAKE) DESTDIR= -C xenstorepvh clean
+	-[ ! -d xenstore ] || $(MAKE) -f $(CURDIR)/xenlibs.mk -C xenstore clean
+	-[ ! -d xenstorepvh ] || $(MAKE) -f $(CURDIR)/xenlibs.mk -C xenstorepvh clean
 
 # clean the cross-compilation result
 .PHONY: crossclean
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Fri Feb 25 15:16:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 15:16:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279253.476943 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcKV-0007Z7-Bf; Fri, 25 Feb 2022 15:16:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279253.476943; Fri, 25 Feb 2022 15:16:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcKV-0007YM-3h; Fri, 25 Feb 2022 15:16:23 +0000
Received: by outflank-mailman (input) for mailman id 279253;
 Fri, 25 Feb 2022 15:16:21 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=E0Ll=TI=citrix.com=prvs=04808661d=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nNcIJ-0007Bf-Uj
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 15:14:08 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 91582a91-964d-11ec-8eb9-a37418f5ba1a;
 Fri, 25 Feb 2022 16:14:05 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 91582a91-964d-11ec-8eb9-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645802044;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=ADC2Vsrbqitg8mHjAC2JFay6LpiS741rs0NhF3hf1d8=;
  b=WG+exY38dYAFDxNd8b4Ae3sKHjWtilQCpiCYkbcHHcBom7GJL5Ei211x
   fLcn63/imCNHUZ3p36csZRggP8lB14Xw5y+pxL29A3SY+29xtOfRdP1ed
   jyuVjlq+J8ypRr9LvX6iwr1fSJA1R1V+BMYpmuQiYlitVuvgI46L4WBQi
   E=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 65407577
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:/KTYKKDrqHYTFxVW/1Pjw5YqxClBgxIJ4kV8jS/XYbTApDlz1mAAm
 2MYW2DQP/uIazT3L48kbYSxo0pSvJDXx4dgQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHWeIdA970Ug5w7Rj39Yy6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhWl
 NlHtaHoFjsIAabdhs4+aCJ/Oh1HaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguwqKtXrO4UO/Glt1zjDAd4tQIzZQrWM7thdtNs1rp4TQa6BO
 pVGAdZpRC+DUxtOA3MRMpwZzP+C3UDwMDtDoV3A8MLb5ECMlVcsgdABKuH9ZdiiVchT2EGCq
 Qru/WvjBQoBHMeC0jfD+XWp7sffkCW+VI8MGbmQ8v9xnEbV1mEVEAcRV1awvb++kEHWZj5EA
 xVKoGx09/F0rRH1CImmN/GlnJKaljlAV9BQLrVl1CCywbvKySWiPU8tcgcUPbTKq/QKbTAt0
 1aImfbgCjpurKCZRBqhy1uEkd+hEXNLdDFfPEfoWSNAuoC++99r0nojW/4+SPbdszHjJd3nL
 9lmRgAajq5bs8ME3r7TEbvv02P1/cihouLYC2zqsoOZAuFRON/Ni2+AswGzARN8wGCxFAjpU
 J8swZX20Qz2JcvR/BFhuc1UdF1T296LMSfHnXlkFIQ7+jKm9haLJN4MvW4ifRs0ap5cIVcFh
 XM/XysLtfe/21PwMMdKj3+ZUZx2ncAM6/y/PhwrUja+SscoL1LWlM2fTUWRw3rsgCARfVIXY
 v+mnTKXJS9CU8xPlWPuL89EiOND7n1ulAv7GMGgpzz6gOX2WZJgYepcWLd4Rrtit/3sTcS82
 4s3CvZmPD0ECLyuOnSMqNVLRb3IRFBiba3LRwVsXrbrCmJb9KsJUpc9HZtJl1RZoplo
IronPort-HdrOrdr: A9a23:HPOWV6y9TrUYmc/ULQneKrPwFL1zdoMgy1knxilNoRw8SKKlfq
 eV7ZImPH7P+U4ssR4b+exoVJPtfZqYz+8R3WBzB8bEYOCFghrKEGgK1+KLqFeMJ8S9zJ846U
 4JSdkGNDSaNzlHZKjBjzVQa+xQouW6zA==
X-IronPort-AV: E=Sophos;i="5.90,136,1643691600"; 
   d="scan'208";a="65407577"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross
	<jgross@suse.com>, Wei Liu <wl@xen.org>
Subject: [XEN PATCH v2 17/29] libs: Rename $(SRCS-y) to $(OBJS-y)
Date: Fri, 25 Feb 2022 15:13:09 +0000
Message-ID: <20220225151321.44126-18-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220225151321.44126-1-anthony.perard@citrix.com>
References: <20220225151321.44126-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

The only thing done thing done with $(SRCS-y) is to replace ".c" by
".o". It is more useful to collect which object we want to build as
make will figure out how to build it and from which source file.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
---

Notes:
    v2:
    - reviewed

 tools/libs/call/Makefile          |  12 +--
 tools/libs/ctrl/Makefile          |  74 +++++++-------
 tools/libs/devicemodel/Makefile   |  12 +--
 tools/libs/evtchn/Makefile        |  12 +--
 tools/libs/foreignmemory/Makefile |  12 +--
 tools/libs/gnttab/Makefile        |  14 +--
 tools/libs/guest/Makefile         |  86 ++++++++--------
 tools/libs/hypfs/Makefile         |   2 +-
 tools/libs/light/Makefile         | 162 +++++++++++++++---------------
 tools/libs/stat/Makefile          |  12 +--
 tools/libs/store/Makefile         |   4 +-
 tools/libs/toolcore/Makefile      |   2 +-
 tools/libs/toollog/Makefile       |   4 +-
 tools/libs/util/Makefile          |  16 +--
 tools/libs/vchan/Makefile         |   4 +-
 tools/libs/libs.mk                |   7 +-
 16 files changed, 217 insertions(+), 218 deletions(-)

diff --git a/tools/libs/call/Makefile b/tools/libs/call/Makefile
index 93d404b79e..e5cb7c937c 100644
--- a/tools/libs/call/Makefile
+++ b/tools/libs/call/Makefile
@@ -4,11 +4,11 @@ include $(XEN_ROOT)/tools/Rules.mk
 MAJOR    = 1
 MINOR    = 3
 
-SRCS-y                 += core.c buffer.c
-SRCS-$(CONFIG_Linux)   += linux.c
-SRCS-$(CONFIG_FreeBSD) += freebsd.c
-SRCS-$(CONFIG_SunOS)   += solaris.c
-SRCS-$(CONFIG_NetBSD)  += netbsd.c
-SRCS-$(CONFIG_MiniOS)  += minios.c
+OBJS-y                 += core.o buffer.o
+OBJS-$(CONFIG_Linux)   += linux.o
+OBJS-$(CONFIG_FreeBSD) += freebsd.o
+OBJS-$(CONFIG_SunOS)   += solaris.o
+OBJS-$(CONFIG_NetBSD)  += netbsd.o
+OBJS-$(CONFIG_MiniOS)  += minios.o
 
 include $(XEN_ROOT)/tools/libs/libs.mk
diff --git a/tools/libs/ctrl/Makefile b/tools/libs/ctrl/Makefile
index f58c4ef1aa..5fd06949f1 100644
--- a/tools/libs/ctrl/Makefile
+++ b/tools/libs/ctrl/Makefile
@@ -1,43 +1,43 @@
 XEN_ROOT = $(CURDIR)/../../..
 include $(XEN_ROOT)/tools/Rules.mk
 
-SRCS-y       += xc_altp2m.c
-SRCS-y       += xc_cpupool.c
-SRCS-y       += xc_domain.c
-SRCS-y       += xc_evtchn.c
-SRCS-y       += xc_gnttab.c
-SRCS-y       += xc_misc.c
-SRCS-y       += xc_flask.c
-SRCS-y       += xc_physdev.c
-SRCS-y       += xc_private.c
-SRCS-y       += xc_csched.c
-SRCS-y       += xc_csched2.c
-SRCS-y       += xc_arinc653.c
-SRCS-y       += xc_rt.c
-SRCS-y       += xc_tbuf.c
-SRCS-y       += xc_pm.c
-SRCS-y       += xc_cpu_hotplug.c
-SRCS-y       += xc_vm_event.c
-SRCS-y       += xc_vmtrace.c
-SRCS-y       += xc_monitor.c
-SRCS-y       += xc_mem_paging.c
-SRCS-y       += xc_mem_access.c
-SRCS-y       += xc_memshr.c
-SRCS-y       += xc_hcall_buf.c
-SRCS-y       += xc_foreign_memory.c
-SRCS-y       += xc_kexec.c
-SRCS-y       += xc_resource.c
-SRCS-$(CONFIG_X86) += xc_psr.c
-SRCS-$(CONFIG_X86) += xc_pagetab.c
-SRCS-$(CONFIG_Linux) += xc_linux.c
-SRCS-$(CONFIG_FreeBSD) += xc_freebsd.c
-SRCS-$(CONFIG_SunOS) += xc_solaris.c
-SRCS-$(CONFIG_NetBSD) += xc_netbsd.c
-SRCS-$(CONFIG_NetBSDRump) += xc_netbsd.c
-SRCS-$(CONFIG_MiniOS) += xc_minios.c
-SRCS-y       += xc_evtchn_compat.c
-SRCS-y       += xc_gnttab_compat.c
-SRCS-y       += xc_devicemodel_compat.c
+OBJS-y       += xc_altp2m.o
+OBJS-y       += xc_cpupool.o
+OBJS-y       += xc_domain.o
+OBJS-y       += xc_evtchn.o
+OBJS-y       += xc_gnttab.o
+OBJS-y       += xc_misc.o
+OBJS-y       += xc_flask.o
+OBJS-y       += xc_physdev.o
+OBJS-y       += xc_private.o
+OBJS-y       += xc_csched.o
+OBJS-y       += xc_csched2.o
+OBJS-y       += xc_arinc653.o
+OBJS-y       += xc_rt.o
+OBJS-y       += xc_tbuf.o
+OBJS-y       += xc_pm.o
+OBJS-y       += xc_cpu_hotplug.o
+OBJS-y       += xc_vm_event.o
+OBJS-y       += xc_vmtrace.o
+OBJS-y       += xc_monitor.o
+OBJS-y       += xc_mem_paging.o
+OBJS-y       += xc_mem_access.o
+OBJS-y       += xc_memshr.o
+OBJS-y       += xc_hcall_buf.o
+OBJS-y       += xc_foreign_memory.o
+OBJS-y       += xc_kexec.o
+OBJS-y       += xc_resource.o
+OBJS-$(CONFIG_X86) += xc_psr.o
+OBJS-$(CONFIG_X86) += xc_pagetab.o
+OBJS-$(CONFIG_Linux) += xc_linux.o
+OBJS-$(CONFIG_FreeBSD) += xc_freebsd.o
+OBJS-$(CONFIG_SunOS) += xc_solaris.o
+OBJS-$(CONFIG_NetBSD) += xc_netbsd.o
+OBJS-$(CONFIG_NetBSDRump) += xc_netbsd.o
+OBJS-$(CONFIG_MiniOS) += xc_minios.o
+OBJS-y       += xc_evtchn_compat.o
+OBJS-y       += xc_gnttab_compat.o
+OBJS-y       += xc_devicemodel_compat.o
 
 CFLAGS   += -D__XEN_TOOLS__
 CFLAGS	+= $(PTHREAD_CFLAGS)
diff --git a/tools/libs/devicemodel/Makefile b/tools/libs/devicemodel/Makefile
index 3e50ff6d90..a0a2d24f99 100644
--- a/tools/libs/devicemodel/Makefile
+++ b/tools/libs/devicemodel/Makefile
@@ -4,11 +4,11 @@ include $(XEN_ROOT)/tools/Rules.mk
 MAJOR    = 1
 MINOR    = 4
 
-SRCS-y                 += core.c
-SRCS-$(CONFIG_Linux)   += common.c
-SRCS-$(CONFIG_FreeBSD) += common.c
-SRCS-$(CONFIG_SunOS)   += compat.c
-SRCS-$(CONFIG_NetBSD)  += compat.c
-SRCS-$(CONFIG_MiniOS)  += compat.c
+OBJS-y                 += core.o
+OBJS-$(CONFIG_Linux)   += common.o
+OBJS-$(CONFIG_FreeBSD) += common.o
+OBJS-$(CONFIG_SunOS)   += compat.o
+OBJS-$(CONFIG_NetBSD)  += compat.o
+OBJS-$(CONFIG_MiniOS)  += compat.o
 
 include $(XEN_ROOT)/tools/libs/libs.mk
diff --git a/tools/libs/evtchn/Makefile b/tools/libs/evtchn/Makefile
index b8c37b5b97..8208ecf650 100644
--- a/tools/libs/evtchn/Makefile
+++ b/tools/libs/evtchn/Makefile
@@ -4,11 +4,11 @@ include $(XEN_ROOT)/tools/Rules.mk
 MAJOR    = 1
 MINOR    = 2
 
-SRCS-y                 += core.c
-SRCS-$(CONFIG_Linux)   += linux.c
-SRCS-$(CONFIG_FreeBSD) += freebsd.c
-SRCS-$(CONFIG_SunOS)   += solaris.c
-SRCS-$(CONFIG_NetBSD)  += netbsd.c
-SRCS-$(CONFIG_MiniOS)  += minios.c
+OBJS-y                 += core.o
+OBJS-$(CONFIG_Linux)   += linux.o
+OBJS-$(CONFIG_FreeBSD) += freebsd.o
+OBJS-$(CONFIG_SunOS)   += solaris.o
+OBJS-$(CONFIG_NetBSD)  += netbsd.o
+OBJS-$(CONFIG_MiniOS)  += minios.o
 
 include $(XEN_ROOT)/tools/libs/libs.mk
diff --git a/tools/libs/foreignmemory/Makefile b/tools/libs/foreignmemory/Makefile
index 0eb9a3a712..4427435932 100644
--- a/tools/libs/foreignmemory/Makefile
+++ b/tools/libs/foreignmemory/Makefile
@@ -4,11 +4,11 @@ include $(XEN_ROOT)/tools/Rules.mk
 MAJOR    = 1
 MINOR    = 4
 
-SRCS-y                 += core.c
-SRCS-$(CONFIG_Linux)   += linux.c
-SRCS-$(CONFIG_FreeBSD) += freebsd.c
-SRCS-$(CONFIG_SunOS)   += compat.c solaris.c
-SRCS-$(CONFIG_NetBSD)  += netbsd.c
-SRCS-$(CONFIG_MiniOS)  += minios.c
+OBJS-y                 += core.o
+OBJS-$(CONFIG_Linux)   += linux.o
+OBJS-$(CONFIG_FreeBSD) += freebsd.o
+OBJS-$(CONFIG_SunOS)   += compat.o solaris.o
+OBJS-$(CONFIG_NetBSD)  += netbsd.o
+OBJS-$(CONFIG_MiniOS)  += minios.o
 
 include $(XEN_ROOT)/tools/libs/libs.mk
diff --git a/tools/libs/gnttab/Makefile b/tools/libs/gnttab/Makefile
index ae390ce60f..7d7aeeadff 100644
--- a/tools/libs/gnttab/Makefile
+++ b/tools/libs/gnttab/Makefile
@@ -4,13 +4,13 @@ include $(XEN_ROOT)/tools/Rules.mk
 MAJOR    = 1
 MINOR    = 2
 
-SRCS-GNTTAB            += gnttab_core.c
-SRCS-GNTSHR            += gntshr_core.c
+OBJS-GNTTAB            += gnttab_core.o
+OBJS-GNTSHR            += gntshr_core.o
 
-SRCS-$(CONFIG_Linux)   += $(SRCS-GNTTAB) $(SRCS-GNTSHR) linux.c
-SRCS-$(CONFIG_MiniOS)  += $(SRCS-GNTTAB) gntshr_unimp.c minios.c
-SRCS-$(CONFIG_FreeBSD) += $(SRCS-GNTTAB) $(SRCS-GNTSHR) freebsd.c
-SRCS-$(CONFIG_NetBSD)  += $(SRCS-GNTTAB) $(SRCS-GNTSHR) netbsd.c
-SRCS-$(CONFIG_SunOS)   += gnttab_unimp.c gntshr_unimp.c
+OBJS-$(CONFIG_Linux)   += $(OBJS-GNTTAB) $(OBJS-GNTSHR) linux.o
+OBJS-$(CONFIG_MiniOS)  += $(OBJS-GNTTAB) gntshr_unimp.o minios.o
+OBJS-$(CONFIG_FreeBSD) += $(OBJS-GNTTAB) $(OBJS-GNTSHR) freebsd.o
+OBJS-$(CONFIG_NetBSD)  += $(OBJS-GNTTAB) $(OBJS-GNTSHR) netbsd.o
+OBJS-$(CONFIG_SunOS)   += gnttab_unimp.o gntshr_unimp.o
 
 include $(XEN_ROOT)/tools/libs/libs.mk
diff --git a/tools/libs/guest/Makefile b/tools/libs/guest/Makefile
index 56483c545f..17eb0ebf4b 100644
--- a/tools/libs/guest/Makefile
+++ b/tools/libs/guest/Makefile
@@ -6,69 +6,69 @@ ifeq ($(CONFIG_LIBXC_MINIOS),y)
 override CONFIG_MIGRATE := n
 endif
 
-SRCS-y += xg_private.c
-SRCS-y += xg_domain.c
-SRCS-y += xg_suspend.c
-SRCS-y += xg_resume.c
+OBJS-y += xg_private.o
+OBJS-y += xg_domain.o
+OBJS-y += xg_suspend.o
+OBJS-y += xg_resume.o
 ifeq ($(CONFIG_MIGRATE),y)
-SRCS-y += xg_sr_common.c
-SRCS-$(CONFIG_X86) += xg_sr_common_x86.c
-SRCS-$(CONFIG_X86) += xg_sr_common_x86_pv.c
-SRCS-$(CONFIG_X86) += xg_sr_restore_x86_pv.c
-SRCS-$(CONFIG_X86) += xg_sr_restore_x86_hvm.c
-SRCS-$(CONFIG_X86) += xg_sr_save_x86_pv.c
-SRCS-$(CONFIG_X86) += xg_sr_save_x86_hvm.c
-SRCS-y += xg_sr_restore.c
-SRCS-y += xg_sr_save.c
-SRCS-y += xg_offline_page.c
+OBJS-y += xg_sr_common.o
+OBJS-$(CONFIG_X86) += xg_sr_common_x86.o
+OBJS-$(CONFIG_X86) += xg_sr_common_x86_pv.o
+OBJS-$(CONFIG_X86) += xg_sr_restore_x86_pv.o
+OBJS-$(CONFIG_X86) += xg_sr_restore_x86_hvm.o
+OBJS-$(CONFIG_X86) += xg_sr_save_x86_pv.o
+OBJS-$(CONFIG_X86) += xg_sr_save_x86_hvm.o
+OBJS-y += xg_sr_restore.o
+OBJS-y += xg_sr_save.o
+OBJS-y += xg_offline_page.o
 else
-SRCS-y += xg_nomigrate.c
+OBJS-y += xg_nomigrate.o
 endif
-SRCS-y       += xg_core.c
-SRCS-$(CONFIG_X86) += xg_core_x86.c
-SRCS-$(CONFIG_ARM) += xg_core_arm.c
+OBJS-y       += xg_core.o
+OBJS-$(CONFIG_X86) += xg_core_x86.o
+OBJS-$(CONFIG_ARM) += xg_core_arm.o
 
 CFLAGS += -I$(XEN_libxenctrl)
 
 vpath %.c ../../../xen/common/libelf
 CFLAGS += -I../../../xen/common/libelf
 
-ELF_SRCS-y += libelf-tools.c libelf-loader.c
-ELF_SRCS-y += libelf-dominfo.c
+ELF_OBJS-y += libelf-tools.o libelf-loader.o
+ELF_OBJS-y += libelf-dominfo.o
 
-SRCS-y += $(ELF_SRCS-y)
+OBJS-y += $(ELF_OBJS-y)
 
-$(patsubst %.c,%.o,$(ELF_SRCS-y)): CFLAGS += -Wno-pointer-sign
-$(patsubst %.c,%.opic,$(ELF_SRCS-y)): CFLAGS += -Wno-pointer-sign
+$(ELF_OBJS-y): CFLAGS += -Wno-pointer-sign
+$(ELF_OBJS-y:.o=.opic): CFLAGS += -Wno-pointer-sign
 
 ifeq ($(CONFIG_X86),y) # Add libx86 to the build
 vpath %.c ../../../xen/lib/x86
 
-SRCS-y                 += cpuid.c msr.c policy.c
+OBJS-y                 += cpuid.o msr.o policy.o
 endif
 
 # new domain builder
-SRCS-y                 += xg_dom_core.c
-SRCS-y                 += xg_dom_boot.c
-SRCS-y                 += xg_dom_elfloader.c
-SRCS-$(CONFIG_X86)     += xg_dom_bzimageloader.c
-SRCS-$(CONFIG_X86)     += xg_dom_decompress_lz4.c
-SRCS-$(CONFIG_X86)     += xg_dom_hvmloader.c
-SRCS-$(CONFIG_ARM)     += xg_dom_armzimageloader.c
-SRCS-y                 += xg_dom_binloader.c
-SRCS-y                 += xg_dom_compat_linux.c
-
-SRCS-$(CONFIG_X86)     += xg_dom_x86.c
-SRCS-$(CONFIG_X86)     += xg_cpuid_x86.c
-SRCS-$(CONFIG_ARM)     += xg_dom_arm.c
+OBJS-y                 += xg_dom_core.o
+OBJS-y                 += xg_dom_boot.o
+OBJS-y                 += xg_dom_elfloader.o
+OBJS-$(CONFIG_X86)     += xg_dom_bzimageloader.o
+OBJS-$(CONFIG_X86)     += xg_dom_decompress_lz4.o
+OBJS-$(CONFIG_X86)     += xg_dom_hvmloader.o
+OBJS-$(CONFIG_ARM)     += xg_dom_armzimageloader.o
+OBJS-y                 += xg_dom_binloader.o
+OBJS-y                 += xg_dom_compat_linux.o
+
+OBJS-$(CONFIG_X86)     += xg_dom_x86.o
+OBJS-$(CONFIG_X86)     += xg_cpuid_x86.o
+OBJS-$(CONFIG_ARM)     += xg_dom_arm.o
 
 ifeq ($(CONFIG_LIBXC_MINIOS),y)
-SRCS-y                 += xg_dom_decompress_unsafe.c
-SRCS-y                 += xg_dom_decompress_unsafe_bzip2.c
-SRCS-y                 += xg_dom_decompress_unsafe_lzma.c
-SRCS-y                 += xg_dom_decompress_unsafe_lzo1x.c
-SRCS-y                 += xg_dom_decompress_unsafe_xz.c
-SRCS-y                 += xg_dom_decompress_unsafe_zstd.c
+OBJS-y                 += xg_dom_decompress_unsafe.o
+OBJS-y                 += xg_dom_decompress_unsafe_bzip2.o
+OBJS-y                 += xg_dom_decompress_unsafe_lzma.o
+OBJS-y                 += xg_dom_decompress_unsafe_lzo1x.o
+OBJS-y                 += xg_dom_decompress_unsafe_xz.o
+OBJS-y                 += xg_dom_decompress_unsafe_zstd.o
 endif
 
 CFLAGS   += -Werror -Wmissing-prototypes
diff --git a/tools/libs/hypfs/Makefile b/tools/libs/hypfs/Makefile
index efa955bd50..630e1e6f3e 100644
--- a/tools/libs/hypfs/Makefile
+++ b/tools/libs/hypfs/Makefile
@@ -6,6 +6,6 @@ MINOR    = 0
 
 LDLIBS += -lz
 
-SRCS-y                 += core.c
+OBJS-y += core.o
 
 include ../libs.mk
diff --git a/tools/libs/light/Makefile b/tools/libs/light/Makefile
index 0c04a5b5cb..13545654c2 100644
--- a/tools/libs/light/Makefile
+++ b/tools/libs/light/Makefile
@@ -1,31 +1,31 @@
 XEN_ROOT = $(CURDIR)/../../..
 include $(XEN_ROOT)/tools/Rules.mk
 
-SRCS-y += osdeps.c
-SRCS-y += libxl_paths.c
-SRCS-y += libxl_bootloader.c
-SRCS-y += flexarray.c
+OBJS-y += osdeps.o
+OBJS-y += libxl_paths.o
+OBJS-y += libxl_bootloader.o
+OBJS-y += flexarray.o
 ifeq ($(CONFIG_LIBNL),y)
-SRCS-y += libxl_netbuffer.c
+OBJS-y += libxl_netbuffer.o
 else
-SRCS-y += libxl_nonetbuffer.c
+OBJS-y += libxl_nonetbuffer.o
 endif
 ifeq ($(CONFIG_X86),y)
-SRCS-y += libxl_convert_callout.c
+OBJS-y += libxl_convert_callout.o
 else
-SRCS-y += libxl_no_convert_callout.c
+OBJS-y += libxl_no_convert_callout.o
 endif
-SRCS-y += libxl_remus.c
-SRCS-y += libxl_checkpoint_device.c
-SRCS-y += libxl_remus_disk_drbd.c
+OBJS-y += libxl_remus.o
+OBJS-y += libxl_checkpoint_device.o
+OBJS-y += libxl_remus_disk_drbd.o
 ifeq ($(CONFIG_LIBNL),y)
-SRCS-y += libxl_colo_restore.c
-SRCS-y += libxl_colo_save.c
-SRCS-y += libxl_colo_qdisk.c
-SRCS-y += libxl_colo_proxy.c
-SRCS-y += libxl_colo_nic.c
+OBJS-y += libxl_colo_restore.o
+OBJS-y += libxl_colo_save.o
+OBJS-y += libxl_colo_qdisk.o
+OBJS-y += libxl_colo_proxy.o
+OBJS-y += libxl_colo_nic.o
 else
-SRCS-y += libxl_no_colo.c
+OBJS-y += libxl_no_colo.o
 endif
 
 ACPI_PATH  = $(XEN_ROOT)/tools/libacpi
@@ -40,82 +40,82 @@ vpath static_tables.c $(ACPI_PATH)/
 acpi:
 	$(MAKE) -C $(ACPI_PATH) ACPI_BUILD_DIR=$(CURDIR) DSDT_FILES="$(DSDT_FILES-y)"
 
-SRCS-$(CONFIG_X86) += $(ACPI_OBJS:.o=.c)
+OBJS-$(CONFIG_X86) += $(ACPI_OBJS)
 
 CFLAGS += -Wno-format-zero-length -Wmissing-declarations \
 	-Wno-declaration-after-statement -Wformat-nonliteral
 
 CFLAGS-$(CONFIG_X86) += -DCONFIG_PCI_SUPP_LEGACY_IRQ
 
-SRCS-$(CONFIG_X86) += libxl_cpuid.c
-SRCS-$(CONFIG_X86) += libxl_x86.c
-SRCS-$(CONFIG_X86) += libxl_psr.c
-SRCS-$(CONFIG_X86) += libxl_x86_acpi.c
-SRCS-$(CONFIG_ARM) += libxl_nocpuid.c
-SRCS-$(CONFIG_ARM) += libxl_arm.c
-SRCS-$(CONFIG_ARM) += libxl_libfdt_compat.c
+OBJS-$(CONFIG_X86) += libxl_cpuid.o
+OBJS-$(CONFIG_X86) += libxl_x86.o
+OBJS-$(CONFIG_X86) += libxl_psr.o
+OBJS-$(CONFIG_X86) += libxl_x86_acpi.o
+OBJS-$(CONFIG_ARM) += libxl_nocpuid.o
+OBJS-$(CONFIG_ARM) += libxl_arm.o
+OBJS-$(CONFIG_ARM) += libxl_libfdt_compat.o
 ifeq ($(CONFIG_ARM_64),y)
 DSDT_FILES-y = dsdt_anycpu_arm.c
-SRCS-y += libxl_arm_acpi.c
-SRCS-y += $(DSDT_FILES-y)
+OBJS-y += libxl_arm_acpi.o
+OBJS-y += $(DSDT_FILES-y:.c=.o)
 dsdt_anycpu_arm.c:
 	$(MAKE) -C $(ACPI_PATH) ACPI_BUILD_DIR=$(CURDIR) DSDT_FILES="$(DSDT_FILES-y)"
 else
-SRCS-$(CONFIG_ARM) += libxl_arm_no_acpi.c
+OBJS-$(CONFIG_ARM) += libxl_arm_no_acpi.o
 endif
 
-SRCS-OS-$(CONFIG_NetBSD) = libxl_netbsd.c
-SRCS-OS-$(CONFIG_Linux) = libxl_linux.c libxl_setresuid.c
-SRCS-OS-$(CONFIG_FreeBSD) = libxl_freebsd.c libxl_setresuid.c
-ifeq ($(SRCS-OS-y),)
+OBJS-OS-$(CONFIG_NetBSD) = libxl_netbsd.o
+OBJS-OS-$(CONFIG_Linux) = libxl_linux.o libxl_setresuid.o
+OBJS-OS-$(CONFIG_FreeBSD) = libxl_freebsd.o libxl_setresuid.o
+ifeq ($(OBJS-OS-y),)
 $(error Your Operating System is not supported by libxenlight, \
 please check libxl_linux.c and libxl_netbsd.c to see how to get it ported)
 endif
-SRCS-y += $(SRCS-OS-y)
-
-SRCS-y += libxl.c
-SRCS-y += libxl_create.c
-SRCS-y += libxl_dm.c
-SRCS-y += libxl_pci.c
-SRCS-y += libxl_dom.c
-SRCS-y += libxl_exec.c
-SRCS-y += libxl_xshelp.c
-SRCS-y += libxl_device.c
-SRCS-y += libxl_internal.c
-SRCS-y += libxl_utils.c
-SRCS-y += libxl_uuid.c
-SRCS-y += libxl_json.c
-SRCS-y += libxl_aoutils.c
-SRCS-y += libxl_numa.c
-SRCS-y += libxl_vnuma.c
-SRCS-y += libxl_stream_read.c
-SRCS-y += libxl_stream_write.c
-SRCS-y += libxl_save_callout.c
-SRCS-y += _libxl_save_msgs_callout.c
-SRCS-y += libxl_qmp.c
-SRCS-y += libxl_event.c
-SRCS-y += libxl_fork.c
-SRCS-y += libxl_dom_suspend.c
-SRCS-y += libxl_dom_save.c
-SRCS-y += libxl_usb.c
-SRCS-y += libxl_vtpm.c
-SRCS-y += libxl_nic.c
-SRCS-y += libxl_disk.c
-SRCS-y += libxl_console.c
-SRCS-y += libxl_cpupool.c
-SRCS-y += libxl_mem.c
-SRCS-y += libxl_sched.c
-SRCS-y += libxl_tmem.c
-SRCS-y += libxl_9pfs.c
-SRCS-y += libxl_domain.c
-SRCS-y += libxl_vdispl.c
-SRCS-y += libxl_pvcalls.c
-SRCS-y += libxl_vsnd.c
-SRCS-y += libxl_vkb.c
-SRCS-y += libxl_genid.c
-SRCS-y += _libxl_types.c
-SRCS-y += libxl_flask.c
-SRCS-y += _libxl_types_internal.c
+OBJS-y += $(OBJS-OS-y)
+
+OBJS-y += libxl.o
+OBJS-y += libxl_create.o
+OBJS-y += libxl_dm.o
+OBJS-y += libxl_pci.o
+OBJS-y += libxl_dom.o
+OBJS-y += libxl_exec.o
+OBJS-y += libxl_xshelp.o
+OBJS-y += libxl_device.o
+OBJS-y += libxl_internal.o
+OBJS-y += libxl_utils.o
+OBJS-y += libxl_uuid.o
+OBJS-y += libxl_json.o
+OBJS-y += libxl_aoutils.o
+OBJS-y += libxl_numa.o
+OBJS-y += libxl_vnuma.o
+OBJS-y += libxl_stream_read.o
+OBJS-y += libxl_stream_write.o
+OBJS-y += libxl_save_callout.o
+OBJS-y += _libxl_save_msgs_callout.o
+OBJS-y += libxl_qmp.o
+OBJS-y += libxl_event.o
+OBJS-y += libxl_fork.o
+OBJS-y += libxl_dom_suspend.o
+OBJS-y += libxl_dom_save.o
+OBJS-y += libxl_usb.o
+OBJS-y += libxl_vtpm.o
+OBJS-y += libxl_nic.o
+OBJS-y += libxl_disk.o
+OBJS-y += libxl_console.o
+OBJS-y += libxl_cpupool.o
+OBJS-y += libxl_mem.o
+OBJS-y += libxl_sched.o
+OBJS-y += libxl_tmem.o
+OBJS-y += libxl_9pfs.o
+OBJS-y += libxl_domain.o
+OBJS-y += libxl_vdispl.o
+OBJS-y += libxl_pvcalls.o
+OBJS-y += libxl_vsnd.o
+OBJS-y += libxl_vkb.o
+OBJS-y += libxl_genid.o
+OBJS-y += _libxl_types.o
+OBJS-y += libxl_flask.o
+OBJS-y += _libxl_types_internal.o
 
 ifeq ($(CONFIG_LIBNL),y)
 CFLAGS_LIBXL += $(LIBNL3_CFLAGS)
@@ -175,7 +175,7 @@ LDLIBS-y += $(PTHREAD_LIBS)
 LDLIBS-y += -lyajl
 LDLIBS += $(LDLIBS-y)
 
-$(LIB_OBJS) $(PIC_OBJS) $(LIBXL_TEST_OBJS): CFLAGS += $(CFLAGS_LIBXL) -include $(XEN_ROOT)/tools/config.h
+$(OBJS-y) $(PIC_OBJS) $(LIBXL_TEST_OBJS): CFLAGS += $(CFLAGS_LIBXL) -include $(XEN_ROOT)/tools/config.h
 $(ACPI_OBJS) $(ACPI_PIC_OBJS): CFLAGS += -I. -DLIBACPI_STDUTILS=\"$(CURDIR)/libxl_x86_acpi.h\"
 $(TEST_PROG_OBJS) _libxl.api-for-check: CFLAGS += $(CFLAGS_libxentoollog) $(CFLAGS_libxentoolcore)
 libxl_dom.o libxl_dom.opic: CFLAGS += -I$(XEN_ROOT)/tools  # include libacpi/x86.h
@@ -189,7 +189,7 @@ testidl.c: libxl_types.idl gentest.py $(XEN_INCLUDE)/libxl.h $(AUTOINCS)
 
 all: $(CLIENTS) $(TEST_PROGS) $(AUTOSRCS) $(AUTOINCS)
 
-$(LIB_OBJS) $(PIC_OBJS) $(SAVE_HELPER_OBJS) $(LIBXL_TEST_OBJS) $(TEST_PROG_OBJS): $(AUTOINCS) libxl.api-ok
+$(OBJS-y) $(PIC_OBJS) $(SAVE_HELPER_OBJS) $(LIBXL_TEST_OBJS) $(TEST_PROG_OBJS): $(AUTOINCS) libxl.api-ok
 
 libxl.api-ok: check-libxl-api-rules _libxl.api-for-check
 	$(PERL) $^
@@ -212,8 +212,8 @@ $(XEN_INCLUDE)/libxl_json.h: $(XEN_INCLUDE)/_libxl_types_json.h
 libxl_internal.h: _libxl_types_internal.h _libxl_types_private.h _libxl_types_internal_private.h
 libxl_internal_json.h: _libxl_types_internal_json.h
 
-$(LIB_OBJS) $(PIC_OBJS) $(LIBXL_TEST_OBJS) $(TEST_PROG_OBJS) $(SAVE_HELPER_OBJS): $(XEN_INCLUDE)/libxl.h
-$(LIB_OBJS) $(PIC_OBJS) $(LIBXL_TEST_OBJS): libxl_internal.h
+$(OBJS-y) $(PIC_OBJS) $(LIBXL_TEST_OBJS) $(TEST_PROG_OBJS) $(SAVE_HELPER_OBJS): $(XEN_INCLUDE)/libxl.h
+$(OBJS-y) $(PIC_OBJS) $(LIBXL_TEST_OBJS): libxl_internal.h
 
 _libxl_type%.h _libxl_type%_json.h _libxl_type%_private.h _libxl_type%.c: libxl_type%.idl gentypes.py idl.py
 	$(eval stem = $(notdir $*))
diff --git a/tools/libs/stat/Makefile b/tools/libs/stat/Makefile
index 39a671d7ed..998435d494 100644
--- a/tools/libs/stat/Makefile
+++ b/tools/libs/stat/Makefile
@@ -17,12 +17,12 @@ include $(XEN_ROOT)/tools/Rules.mk
 
 CFLAGS += -include $(XEN_ROOT)/tools/config.h
 
-SRCS-y += xenstat.c
-SRCS-y += xenstat_qmp.c
-SRCS-$(CONFIG_Linux) += xenstat_linux.c
-SRCS-$(CONFIG_SunOS) += xenstat_solaris.c
-SRCS-$(CONFIG_NetBSD) += xenstat_netbsd.c
-SRCS-$(CONFIG_FreeBSD) += xenstat_freebsd.c
+OBJS-y += xenstat.o
+OBJS-y += xenstat_qmp.o
+OBJS-$(CONFIG_Linux) += xenstat_linux.o
+OBJS-$(CONFIG_SunOS) += xenstat_solaris.o
+OBJS-$(CONFIG_NetBSD) += xenstat_netbsd.o
+OBJS-$(CONFIG_FreeBSD) += xenstat_freebsd.o
 
 LDLIBS-y += -lyajl
 LDLIBS-$(CONFIG_SunOS) += -lkstat
diff --git a/tools/libs/store/Makefile b/tools/libs/store/Makefile
index b94060be8d..778da51f95 100644
--- a/tools/libs/store/Makefile
+++ b/tools/libs/store/Makefile
@@ -8,8 +8,8 @@ ifeq ($(CONFIG_Linux),y)
 LDLIBS += -ldl
 endif
 
-SRCS-y   += xs_lib.c
-SRCS-y   += xs.c
+OBJS-y   += xs_lib.o
+OBJS-y   += xs.o
 
 LIBHEADER = xenstore.h xenstore_lib.h
 
diff --git a/tools/libs/toolcore/Makefile b/tools/libs/toolcore/Makefile
index 9c013b2879..ce417ea648 100644
--- a/tools/libs/toolcore/Makefile
+++ b/tools/libs/toolcore/Makefile
@@ -6,7 +6,7 @@ MINOR	= 0
 
 LIBHEADER := xentoolcore.h
 
-SRCS-y	+= handlereg.c
+OBJS-y	+= handlereg.o
 
 include $(XEN_ROOT)/tools/libs/libs.mk
 
diff --git a/tools/libs/toollog/Makefile b/tools/libs/toollog/Makefile
index dce1b2de85..c09aa02ba5 100644
--- a/tools/libs/toollog/Makefile
+++ b/tools/libs/toollog/Makefile
@@ -4,7 +4,7 @@ include $(XEN_ROOT)/tools/Rules.mk
 MAJOR	= 1
 MINOR	= 0
 
-SRCS-y	+= xtl_core.c
-SRCS-y	+= xtl_logger_stdio.c
+OBJS-y	+= xtl_core.o
+OBJS-y	+= xtl_logger_stdio.o
 
 include $(XEN_ROOT)/tools/libs/libs.mk
diff --git a/tools/libs/util/Makefile b/tools/libs/util/Makefile
index 7a658e9446..ffe507b379 100644
--- a/tools/libs/util/Makefile
+++ b/tools/libs/util/Makefile
@@ -1,13 +1,13 @@
 XEN_ROOT = $(CURDIR)/../../..
 include $(XEN_ROOT)/tools/Rules.mk
 
-SRCS-y += libxlu_cfg_y.c
-SRCS-y += libxlu_cfg_l.c
-SRCS-y += libxlu_cfg.c
-SRCS-y += libxlu_disk_l.c
-SRCS-y += libxlu_disk.c
-SRCS-y += libxlu_vif.c
-SRCS-y += libxlu_pci.c
+OBJS-y += libxlu_cfg_y.o
+OBJS-y += libxlu_cfg_l.o
+OBJS-y += libxlu_cfg.o
+OBJS-y += libxlu_disk_l.o
+OBJS-y += libxlu_disk.o
+OBJS-y += libxlu_vif.o
+OBJS-y += libxlu_pci.o
 
 CFLAGS += -Wno-format-zero-length -Wmissing-declarations \
 	-Wno-declaration-after-statement -Wformat-nonliteral
@@ -39,7 +39,7 @@ NO_HEADERS_CHK := y
 
 include $(XEN_ROOT)/tools/libs/libs.mk
 
-$(LIB_OBJS) $(PIC_OBJS): $(AUTOINCS)
+$(OBJS-y) $(PIC_OBJS): $(AUTOINCS)
 
 %.c %.h:: %.y
 	@rm -f $*.[ch]
diff --git a/tools/libs/vchan/Makefile b/tools/libs/vchan/Makefile
index 4ccb4dd1f6..ac2bff66f5 100644
--- a/tools/libs/vchan/Makefile
+++ b/tools/libs/vchan/Makefile
@@ -5,8 +5,8 @@ CFLAGS += $(CFLAGS_libxenctrl)
 
 LIBHEADER := libxenvchan.h
 
-SRCS-y += init.c
-SRCS-y += io.c
+OBJS-y += init.o
+OBJS-y += io.o
 
 NO_HEADERS_CHK := y
 
diff --git a/tools/libs/libs.mk b/tools/libs/libs.mk
index c2eaefc928..58d8166b09 100644
--- a/tools/libs/libs.mk
+++ b/tools/libs/libs.mk
@@ -20,8 +20,7 @@ CFLAGS   += $(foreach lib, $(USELIBS_$(LIBNAME)), $(CFLAGS_libxen$(lib)))
 
 LDLIBS += $(foreach lib, $(USELIBS_$(LIBNAME)), $(LDLIBS_libxen$(lib)))
 
-LIB_OBJS := $(SRCS-y:.c=.o)
-PIC_OBJS := $(SRCS-y:.c=.opic)
+PIC_OBJS := $(OBJS-y:.o=.opic)
 
 LIB_FILE_NAME = $(FILENAME_$(LIBNAME))
 LIB := lib$(LIB_FILE_NAME).a
@@ -79,7 +78,7 @@ headers.lst: FORCE
 libxen$(LIBNAME).map:
 	echo 'VERS_$(MAJOR).$(MINOR) { global: *; };' >$@
 
-lib$(LIB_FILE_NAME).a: $(LIB_OBJS)
+lib$(LIB_FILE_NAME).a: $(OBJS-y)
 	$(AR) rc $@ $^
 
 lib$(LIB_FILE_NAME).so: lib$(LIB_FILE_NAME).so.$(MAJOR)
@@ -125,7 +124,7 @@ TAGS:
 
 .PHONY: clean
 clean::
-	rm -rf $(LIB) *~ $(DEPS_RM) $(LIB_OBJS) $(PIC_OBJS)
+	rm -rf $(LIB) *~ $(DEPS_RM) $(OBJS-y) $(PIC_OBJS)
 	rm -f lib$(LIB_FILE_NAME).so.$(MAJOR).$(MINOR) lib$(LIB_FILE_NAME).so.$(MAJOR)
 	rm -f headers.chk headers.lst
 	rm -f $(PKG_CONFIG)
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Fri Feb 25 15:16:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 15:16:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279254.476955 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcKW-0007uQ-SV; Fri, 25 Feb 2022 15:16:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279254.476955; Fri, 25 Feb 2022 15:16:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcKW-0007u8-K5; Fri, 25 Feb 2022 15:16:24 +0000
Received: by outflank-mailman (input) for mailman id 279254;
 Fri, 25 Feb 2022 15:16:24 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=E0Ll=TI=citrix.com=prvs=04808661d=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nNcIW-0006fy-S9
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 15:14:20 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 98e5e580-964d-11ec-8539-5f4723681683;
 Fri, 25 Feb 2022 16:14:17 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 98e5e580-964d-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645802057;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=d3piZxqZuNJB/VZp7MMLQLrSEQWkmz/CgMBBNprZ0OE=;
  b=Cy0HYOMWQDvMGGVrqAMhikKvWzPoj9PcC1XZuF4iZUpw5uMzHhBkQz+E
   c11FArnhk54Mgx6ZDCnnBGwZsweSdgyPRi8SNC+K4nv9xs5+zkzzS5oxS
   h5b+tc1OeEQ4QJiTBjNjAABhP5J+gkkK1F5+zi40+EKGTlc72neMEs3FL
   g=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 64433086
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:ugzeC6BqjmufXRVW/yDjw5YqxClBgxIJ4kV8jS/XYbTApD4r0TYPy
 jAaCG/TPPeDMWajLtt+a4S/9UlVscXXn4I1QQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHWeIdA970Ug5w7Rj39Yy6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhAl
 IpBuJaiaz50N7XgtMIxECJoAyVhaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguwqKtXrO4UO/Glt1zjDAd4tQIzZQrWM7thdtNs1rp4SQa2FP
 5pHAdZpRDP4RBFSGGwzNI4nzbmagF/ELTNA9GvA8MLb5ECMlVcsgdABKuH9ZdiiVchT2EGCq
 Qru5G38HxwecsCfyDCM73awruLJhmb/SYUUUrqi+ZZCkFCVg2AeFhASfV+6uuWizF6zXcpFL
 E4Z8TZoqrI9nHFHVfGkAUf++iTd+EdBBZwASIXW9T1h1ILlv1mVC2IWbAccYcQKmOkaBgcax
 luWyoaB6SNUjJWZTneU97GxpDy0ODQIIWJqWRLoXTfp8PG4/tht00unosJLVffs04arQW2YL
 yWi8XBm74j/m/LnwElSEbrvpzu37qbEQQcujuk8djL0t1gpDGJJimHB1LQ60RqiBNrIJrVil
 CJd8yR70AzoJcvc/MBqaL9QdIxFH97fbFXhbadHRvHNDQiF9X+5Zpx36zpjPkpvOctsUWa3P
 BKM5VoNuccLZCPCgUpLj2SZUZVCIU/IT4mNaxwpRoAWPsgZmPGvpkmCmnJ8L0iyyRNxwMnTy
 L+QcNq2DGZyNEiU5GHeegvp6pdynnpW7TqKHfjTlk37uZLDNC/9YepUazOmM7FmhJ5oVS2Iq
 r6zwePRkE4BOAA/CwGKmbMuwacidiBqVcir8JUMLoZu4GNOQQkcNhMY+pt5E6QNokifvrygE
 q2VMqOA9GfCuA==
IronPort-HdrOrdr: A9a23:cZOTB6rBSZWrKJwZSx7rYJYaV5oteYIsimQD101hICG8cqSj+P
 xG+85rsiMc6QxhIU3I9urgBEDtex7hHNtOkOss1NSZLW3bUQmTTL2KhLGKq1aLJ8S9zJ856U
 4JSdkZNDSaNzZHZKjBjDVQa+xQo+W6zA==
X-IronPort-AV: E=Sophos;i="5.90,136,1643691600"; 
   d="scan'208";a="64433086"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@citrix.com>, Samuel Thibault
	<samuel.thibault@ens-lyon.org>, Wei Liu <wl@xen.org>
Subject: [XEN PATCH v2 24/29] stubdom: introduce xenlibs.mk
Date: Fri, 25 Feb 2022 15:13:16 +0000
Message-ID: <20220225151321.44126-25-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220225151321.44126-1-anthony.perard@citrix.com>
References: <20220225151321.44126-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

This new makefile will be used to build libraries that provides
"Makefile.common".

At some point, we will be converting Makefile in tools/ to "subdirmk"
and stubdom build will not be able to use those new makefiles, so we
will put the necessary information for stubdom to build the xen
libraries into a new Makefile.common and xenlibs.mk will use it.
We only need to build static libraries and don't need anything else.

The check for the presence of "Makefile.common" will go aways once
there is one for all libraries used by stubdom build.

Also remove DESTDIR= from "clean" targets, we don't do installation in
this recipe so the value of DESTDIR doesn't matter.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
---

Notes:
    v2:
    - reviewed

 stubdom/Makefile   |  9 +++++++--
 stubdom/xenlibs.mk | 13 +++++++++++++
 2 files changed, 20 insertions(+), 2 deletions(-)
 create mode 100644 stubdom/xenlibs.mk

diff --git a/stubdom/Makefile b/stubdom/Makefile
index 5fb5dbc341..fba4c977ef 100644
--- a/stubdom/Makefile
+++ b/stubdom/Makefile
@@ -346,6 +346,7 @@ define do_links
   cd $(dir $@); \
   ln -sf $(dir $<)include/*.h include/; \
   ln -sf $(dir $<)*.[ch] .; \
+  [ -e $(dir $<)Makefile.common ] && ln -sf $(dir $<)Makefile.common . ||:; \
   ln -sf $(dir $<)Makefile .
   touch $@
 endef
@@ -355,10 +356,14 @@ define BUILD_lib
  libxen$(1): libs-$$(XEN_TARGET_ARCH)/$(1)/libxen$(1).a
  libs-$$(XEN_TARGET_ARCH)/$(1)/libxen$(1).a: $$(LIBDEPS_$(1)) $$(LIBDEP_$(1))
  libs-$$(XEN_TARGET_ARCH)/$(1)/libxen$(1).a: mk-headers-$$(XEN_TARGET_ARCH) $$(NEWLIB_STAMPFILE) .phony
-	CPPFLAGS="$$(TARGET_CPPFLAGS)" CFLAGS="$$(TARGET_CFLAGS)" $$(MAKE) CONFIG_LIBXC_MINIOS=y -C $$(@D) $$(@F)
+	CPPFLAGS="$$(TARGET_CPPFLAGS)" CFLAGS="$$(TARGET_CFLAGS)" $$(MAKE) CONFIG_LIBXC_MINIOS=y $$(if $$(wildcard $$(@D)/Makefile.common),-f $(CURDIR)/xenlibs.mk) -C $$(@D) $$(@F)
 
  clean-libxen$(1):
-	[ ! -e libs-$$(XEN_TARGET_ARCH)/$(1)/Makefile ] || $$(MAKE) DESTDIR= -C libs-$$(XEN_TARGET_ARCH)/$(1) clean
+	if [ -e libs-$$(XEN_TARGET_ARCH)/$(1)/Makefile.common ]; then \
+	    $$(MAKE) -f $(CURDIR)/xenlibs.mk -C libs-$$(XEN_TARGET_ARCH)/$(1) clean; \
+	elif [ -e libs-$$(XEN_TARGET_ARCH)/$(1)/Makefile ]; then \
+	    $$(MAKE) -C libs-$$(XEN_TARGET_ARCH)/$(1) clean; \
+	fi
 
  libs-$$(XEN_TARGET_ARCH)/$(1)/stamp: $$(XEN_ROOT)/tools/libs/$(1)/Makefile
 	$$(do_links)
diff --git a/stubdom/xenlibs.mk b/stubdom/xenlibs.mk
new file mode 100644
index 0000000000..5c8742ccf9
--- /dev/null
+++ b/stubdom/xenlibs.mk
@@ -0,0 +1,13 @@
+include $(XEN_ROOT)/tools/Rules.mk
+
+include Makefile.common
+
+LIBNAME := $(notdir $(CURDIR))
+FILENAME_$(LIBNAME) ?= xen$(LIBNAME)
+LIB_FILE_NAME = $(FILENAME_$(LIBNAME))
+
+lib$(LIB_FILE_NAME).a: $(OBJS-y)
+	$(AR) rc $@ $^
+
+clean::
+	rm -f $(OBJS-y) lib$(LIB_FILE_NAME).a
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Fri Feb 25 15:16:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 15:16:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279256.476964 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcKY-0008Cm-39; Fri, 25 Feb 2022 15:16:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279256.476964; Fri, 25 Feb 2022 15:16:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcKX-0008CS-VP; Fri, 25 Feb 2022 15:16:25 +0000
Received: by outflank-mailman (input) for mailman id 279256;
 Fri, 25 Feb 2022 15:16:24 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=E0Ll=TI=citrix.com=prvs=04808661d=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nNcIR-0006fy-Rh
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 15:14:15 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 96495a21-964d-11ec-8539-5f4723681683;
 Fri, 25 Feb 2022 16:14:13 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 96495a21-964d-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645802053;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=iBXan52Uptq1lv5gul5Hkg1gH0pXMqxs3qqmW+W01jw=;
  b=MjzXe7hcOsy22c/tbQJt8Su0MlspPKBSRMoDwBUNGfMUJKeTCt4+q+ts
   A1w+VEyV1bMS1ygcoO4SmKH0duOqHElUqPQZMhfXz2jDVD8g4asBP1z0h
   aVeyMWDBgiJ10fgwpXeMQPdK8RMF8SVHMyyt+xnDcPHYdQVzfFF6FoAdS
   E=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 65000328
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:2sa8AqDh4G2S8xVW/1Pjw5YqxClBgxIJ4kV8jS/XYbTApDNzhmQPy
 GsfDDyDbv+JMWr1eI1/PoTj8R8DsJbQzodhQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHWeIdA970Ug5w7Rj39Yy6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhj6
 /tKh4e9czwMI4SStLkkWThTHBphaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguwqKtXrO4UO/Glt1zjDAd4tQIzZQrWM7thdtNs1rp4TRa6GP
 JBJAdZpRErtTwVPOWxKMb4vofv2uCKmQywbp2vA8MLb5ECMlVcsgdABKuH9ZdiiVchT2EGCq
 Qru/WvjBQoBHMeC0jfD+XWp7sffkCW+VI8MGbmQ8v9xnEbV1mEVEAcRV1awvb++kEHWZj5EA
 xVKoGx09/F0rRH1CImmN/GlnJKalgw/dd1iCOAA0ySQ4/T4vj+TJ2MLdSEUPbTKq/QKbTAt0
 1aImfbgCjpurKCZRBqhy1uEkd+hEXNLdDFfPEfoWSNAuoC++99r0nojW/4+SPbdszHjJd3nL
 9lmRgAajq5bs8ME3r7TEbvv02P1/cihouLYC2zqsoOZAuFRON/Ni2+AswGzARN8wGCxFAjpU
 J8swZX20Qz2JcvR/BFhuc1UdF1T296LMSfHnXlkFIQ7+jKm9haLJN4MvW4ifRs0ap5cIVcFh
 XM/XysLtfe/21PwMMdKj3+ZUZx2ncAM6/y/PhwrUja+SscoL1LWlM2fTUWRw3rsgCARfVIXY
 v+mnTKXJS9CU8xPlWPuL89EiOND7n1ulAv7GMGgpzz6gOX2WZJgYepcWLd4Rrtit/3sTcS82
 4s3CvZmPD0ECLyuOnSMqNVLRb3IRFBiba3LRwVsXrbrCmJb9KsJUZc9HZtJl1RZoplo
IronPort-HdrOrdr: A9a23:mzn/raivuTaJtnmKfbjVxuAX0HBQXtwji2hC6mlwRA09TySZ//
 rAoB19726StN9xYgBYpTnuAsi9qB/nmKKdpLNhX4tKPzOW3FdATrsD0WKK+VSJcEfDH6xmpM
 JdmsBFebvN5DNB4/oSjjPVLz9Z+qjlzJyV
X-IronPort-AV: E=Sophos;i="5.90,136,1643691600"; 
   d="scan'208";a="65000328"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross
	<jgross@suse.com>, Wei Liu <wl@xen.org>
Subject: [XEN PATCH v2 22/29] libs/stat: Fix and rework perl-binding build
Date: Fri, 25 Feb 2022 15:13:14 +0000
Message-ID: <20220225151321.44126-23-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220225151321.44126-1-anthony.perard@citrix.com>
References: <20220225151321.44126-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

For PERL_FLAGS, use make's shell rather than a backquote.

Rather than relying on the VCS to create an empty directory for us,
we can create one before generating the *.c file for the bindings.

Make use of generic variable names to build a shared library from a
source file: CFLAGS, LDFLAGS, and LDLIBS.

To build a shared library, we need to build the source file with
"-fPIC", which was drop by 6d0ec05390 (tools: split libxenstat into
new tools/libs/stat directory).

The source file generated by swig seems to be missing many prototype for
many functions, so we need "-Wno-missing-prototypes" in order to
build it. Also, one of the prototype is deemed malformed, so we also
need "-Wno-strict-prototypes".

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
---

Notes:
    v2:
    - reviewed

 tools/libs/stat/Makefile                  | 15 +++++++++++----
 tools/libs/stat/bindings/swig/perl/.empty |  1 -
 2 files changed, 11 insertions(+), 5 deletions(-)
 delete mode 100644 tools/libs/stat/bindings/swig/perl/.empty

diff --git a/tools/libs/stat/Makefile b/tools/libs/stat/Makefile
index b8d75810fc..7eaf50e91e 100644
--- a/tools/libs/stat/Makefile
+++ b/tools/libs/stat/Makefile
@@ -94,13 +94,20 @@ uninstall:: uninstall-python-bindings
 endif
 
 # Perl bindings
-PERL_FLAGS=`perl -MConfig -e 'print "$$Config{ccflags} -I$$Config{archlib}/CORE";'`
+PERL_FLAGS = $(shell $(PERL) -MConfig -e 'print "$$Config{ccflags} -I$$Config{archlib}/CORE";')
 $(PERLMOD): $(PERLSRC)
 $(PERLSRC): bindings/swig/xenstat.i
-	swig -perl $(SWIG_FLAGS) -outdir $(@D) -o $(PERLSRC) $<
-
+	mkdir -p $(@D)
+	swig -perl $(SWIG_FLAGS) -outdir $(@D) -o $@ $<
+
+$(PERLLIB): CFLAGS += -fPIC
+$(PERLLIB): CFLAGS += -Wno-strict-prototypes
+$(PERLLIB): CFLAGS += -Wno-missing-prototypes
+$(PERLLIB): LDFLAGS += $(PERL_FLAGS)
+$(PERLLIB): LDFLAGS += $(SHLIB_LDFLAGS)
+$(PERLLIB): LDLIBS := $(LDLIBS_libxenstat)
 $(PERLLIB): $(PERLSRC)
-	$(CC) $(CFLAGS) $(LDFLAGS) $(PERL_FLAGS) $(SHLIB_LDFLAGS) -lxenstat -o $@ $< $(APPEND_LDFLAGS)
+	$(CC) $(CFLAGS) $(LDFLAGS) -o $@ $< $(LDLIBS) $(APPEND_LDFLAGS)
 
 .PHONY: perl-bindings
 perl-bindings: $(PERLLIB) $(PERLMOD)
diff --git a/tools/libs/stat/bindings/swig/perl/.empty b/tools/libs/stat/bindings/swig/perl/.empty
deleted file mode 100644
index 2a8dd4274d..0000000000
--- a/tools/libs/stat/bindings/swig/perl/.empty
+++ /dev/null
@@ -1 +0,0 @@
-This directory is empty; this file is included to prevent version control systems from removing the directory.
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Fri Feb 25 15:16:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 15:16:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279280.476975 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcKp-0001H0-Fo; Fri, 25 Feb 2022 15:16:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279280.476975; Fri, 25 Feb 2022 15:16:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcKp-0001Gu-BF; Fri, 25 Feb 2022 15:16:43 +0000
Received: by outflank-mailman (input) for mailman id 279280;
 Fri, 25 Feb 2022 15:16:42 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=E0Ll=TI=citrix.com=prvs=04808661d=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nNcIY-0007Bf-Da
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 15:14:22 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9a7d7af3-964d-11ec-8eb9-a37418f5ba1a;
 Fri, 25 Feb 2022 16:14:20 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9a7d7af3-964d-11ec-8eb9-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645802060;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=ae6Vs1nYUDXcC+AeNHwQbE6sOaNWGywbrl+G+3LlLsM=;
  b=Bz4Kn8I01W6nIeSsoYj7gcqadaW4K6E6KjOiPPv69JMZ8YC93t+DFr8n
   Qz36MN5flOZELNEVbgiH3PskO91IEgw+ZsaXRCA5jEYa36QBuovYVFp//
   DO0tLAF5Eh7YQ8c8tbnvpGUmuDxCa4qP+SENdoSoukjw2/fqGEozQT8Hu
   c=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 65000340
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:iYn56ahvJU19gsPbU+X4iVjRX161eBAKZh0ujC45NGQN5FlHY01je
 htvCGjUP6nYYGH3fdAiPNy28UwB7ZTXmNZiSwI6/CFgF3wb9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M78wIFqtQw24LhWVnQ4
 YmaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV
 efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9
 TlDiXC/YSgFH7bAivo6aj9nL3h4PaBH/5aaJnfq5KR/z2WeG5ft6/BnDUVwNowE4OdnR2pJ8
 JT0KhhUMErF3bjvhuvmFK883azPL+GyVG8bknhm0THeC+dgWZ3ZSr/GzdRZwC0xloZFGvO2i
 88xN2c3NEybP0Un1lE/DM5nsLaLhFfDTxpIsmq5vIgJoGTo9VkkuFTqGIWMIYHbLSlPpW6Ho
 krW8mK/BQsVXPSEwD+Y/3bqmu/OlyrmXJ46Gbujs/p7h1vVwXYcYDUGWF3+rfSnh0qWX9NEN
 1dS6icotbI19kGgUp/6RRLQiHyLpBkHQPJLDvY3rgqKz8LpDx2xXzZeCGQbMZp/6ZFwFWdCO
 kK1c83BKhBOq7GHV1Wk0Iio9DWyNCkSBDIFanpRJeca2OXLrIY2hxPJa99sFq+pk9H4cQ3NL
 yC2QDsW3OtK05NSv0mv1RWe2m/3+MCVJuIgzliPBgqYAhVFiJlJjmBCwXzS9r5+IYmQVTFtV
 1BUypHFvIji4Xxg/RFhodnh/pn1tp5p0xWG2DaD+qXNERz3qhZPmqgKvVlDyL9BaJpsRNMQS
 Ba7VfltzJFSJmC2SqR8fpi8Dc8npYC5S4i4CayNMocWOsApHONiwM2ITRTBt4wKuBJx+ZzTx
 L/BKZr8ZZrkIf4PIMWKqxc1juZwm3FWKZL7TpHn1RW3uYdyl1bOIYrpxGCmN7hjhIvd+V292
 48Ga6OilkUOOMWjM3K/2dNCcjg3wY0TWMmeRzp/LbXYfGKL2QgJVpfs/F/WU9c9zvQNy7yRp
 SnVt40x4AOXuEAr4D6iMhhLAI4Dl74lxZ7nFUTA5WqV5kU=
IronPort-HdrOrdr: A9a23:W+MrOqDZ/CU3RrvlHemU55DYdb4zR+YMi2TC1yhKJyC9Ffbo8f
 xG/c5rrSMc5wxwZJhNo7y90ey7MBbhHP1OkO4s1NWZLWrbUQKTRekIh+bfKn/baknDH4ZmpN
 5dmsNFaeEYY2IUsS+D2njbL+od
X-IronPort-AV: E=Sophos;i="5.90,136,1643691600"; 
   d="scan'208";a="65000340"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross
	<jgross@suse.com>, Wei Liu <wl@xen.org>, Samuel Thibault
	<samuel.thibault@ens-lyon.org>
Subject: [XEN PATCH v2 25/29] tools/libs: create Makefile.common to be used by stubdom build system
Date: Fri, 25 Feb 2022 15:13:17 +0000
Message-ID: <20220225151321.44126-26-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220225151321.44126-1-anthony.perard@citrix.com>
References: <20220225151321.44126-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

This new "Makefile.common" is intended to be used by both tools/ and
stubdom/ build system without stubdom needed to use tools/ build
system.

It should contain the necessary list of objects and CFLAGS needed to
build a static library.

Change stubdom/ to check Makefile.common, for the linkfarm.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
---

Notes:
    v2:
    - reviewed

 stubdom/Makefile                         |  2 +-
 tools/libs/call/Makefile                 |  7 +-
 tools/libs/ctrl/Makefile                 | 45 +-----------
 tools/libs/devicemodel/Makefile          |  7 +-
 tools/libs/evtchn/Makefile               |  7 +-
 tools/libs/foreignmemory/Makefile        |  7 +-
 tools/libs/gnttab/Makefile               |  9 +--
 tools/libs/guest/Makefile                | 90 +-----------------------
 tools/libs/toolcore/Makefile             |  2 +-
 tools/libs/toollog/Makefile              |  3 +-
 tools/libs/call/Makefile.common          |  6 ++
 tools/libs/ctrl/Makefile.common          | 44 ++++++++++++
 tools/libs/devicemodel/Makefile.common   |  6 ++
 tools/libs/evtchn/Makefile.common        |  6 ++
 tools/libs/foreignmemory/Makefile.common |  6 ++
 tools/libs/gnttab/Makefile.common        |  8 +++
 tools/libs/guest/Makefile.common         | 84 ++++++++++++++++++++++
 tools/libs/toolcore/Makefile.common      |  1 +
 tools/libs/toollog/Makefile.common       |  2 +
 19 files changed, 174 insertions(+), 168 deletions(-)
 create mode 100644 tools/libs/call/Makefile.common
 create mode 100644 tools/libs/ctrl/Makefile.common
 create mode 100644 tools/libs/devicemodel/Makefile.common
 create mode 100644 tools/libs/evtchn/Makefile.common
 create mode 100644 tools/libs/foreignmemory/Makefile.common
 create mode 100644 tools/libs/gnttab/Makefile.common
 create mode 100644 tools/libs/guest/Makefile.common
 create mode 100644 tools/libs/toolcore/Makefile.common
 create mode 100644 tools/libs/toollog/Makefile.common

diff --git a/stubdom/Makefile b/stubdom/Makefile
index fba4c977ef..fbc63a5063 100644
--- a/stubdom/Makefile
+++ b/stubdom/Makefile
@@ -365,7 +365,7 @@ define BUILD_lib
 	    $$(MAKE) -C libs-$$(XEN_TARGET_ARCH)/$(1) clean; \
 	fi
 
- libs-$$(XEN_TARGET_ARCH)/$(1)/stamp: $$(XEN_ROOT)/tools/libs/$(1)/Makefile
+ libs-$$(XEN_TARGET_ARCH)/$(1)/stamp: $$(XEN_ROOT)/tools/libs/$(1)/Makefile.common
 	$$(do_links)
 endef
 
diff --git a/tools/libs/call/Makefile b/tools/libs/call/Makefile
index e5cb7c937c..103f5ad360 100644
--- a/tools/libs/call/Makefile
+++ b/tools/libs/call/Makefile
@@ -4,11 +4,6 @@ include $(XEN_ROOT)/tools/Rules.mk
 MAJOR    = 1
 MINOR    = 3
 
-OBJS-y                 += core.o buffer.o
-OBJS-$(CONFIG_Linux)   += linux.o
-OBJS-$(CONFIG_FreeBSD) += freebsd.o
-OBJS-$(CONFIG_SunOS)   += solaris.o
-OBJS-$(CONFIG_NetBSD)  += netbsd.o
-OBJS-$(CONFIG_MiniOS)  += minios.o
+include Makefile.common
 
 include $(XEN_ROOT)/tools/libs/libs.mk
diff --git a/tools/libs/ctrl/Makefile b/tools/libs/ctrl/Makefile
index 5fd06949f1..93442ab389 100644
--- a/tools/libs/ctrl/Makefile
+++ b/tools/libs/ctrl/Makefile
@@ -1,50 +1,7 @@
 XEN_ROOT = $(CURDIR)/../../..
 include $(XEN_ROOT)/tools/Rules.mk
 
-OBJS-y       += xc_altp2m.o
-OBJS-y       += xc_cpupool.o
-OBJS-y       += xc_domain.o
-OBJS-y       += xc_evtchn.o
-OBJS-y       += xc_gnttab.o
-OBJS-y       += xc_misc.o
-OBJS-y       += xc_flask.o
-OBJS-y       += xc_physdev.o
-OBJS-y       += xc_private.o
-OBJS-y       += xc_csched.o
-OBJS-y       += xc_csched2.o
-OBJS-y       += xc_arinc653.o
-OBJS-y       += xc_rt.o
-OBJS-y       += xc_tbuf.o
-OBJS-y       += xc_pm.o
-OBJS-y       += xc_cpu_hotplug.o
-OBJS-y       += xc_vm_event.o
-OBJS-y       += xc_vmtrace.o
-OBJS-y       += xc_monitor.o
-OBJS-y       += xc_mem_paging.o
-OBJS-y       += xc_mem_access.o
-OBJS-y       += xc_memshr.o
-OBJS-y       += xc_hcall_buf.o
-OBJS-y       += xc_foreign_memory.o
-OBJS-y       += xc_kexec.o
-OBJS-y       += xc_resource.o
-OBJS-$(CONFIG_X86) += xc_psr.o
-OBJS-$(CONFIG_X86) += xc_pagetab.o
-OBJS-$(CONFIG_Linux) += xc_linux.o
-OBJS-$(CONFIG_FreeBSD) += xc_freebsd.o
-OBJS-$(CONFIG_SunOS) += xc_solaris.o
-OBJS-$(CONFIG_NetBSD) += xc_netbsd.o
-OBJS-$(CONFIG_NetBSDRump) += xc_netbsd.o
-OBJS-$(CONFIG_MiniOS) += xc_minios.o
-OBJS-y       += xc_evtchn_compat.o
-OBJS-y       += xc_gnttab_compat.o
-OBJS-y       += xc_devicemodel_compat.o
-
-CFLAGS   += -D__XEN_TOOLS__
-CFLAGS	+= $(PTHREAD_CFLAGS)
-CFLAGS += -include $(XEN_ROOT)/tools/config.h
-
-# Needed for posix_fadvise64() in xc_linux.c
-CFLAGS-$(CONFIG_Linux) += -D_GNU_SOURCE
+include Makefile.common
 
 LIBHEADER := xenctrl.h xenctrl_compat.h
 PKG_CONFIG := xencontrol.pc
diff --git a/tools/libs/devicemodel/Makefile b/tools/libs/devicemodel/Makefile
index a0a2d24f99..b70dd774e4 100644
--- a/tools/libs/devicemodel/Makefile
+++ b/tools/libs/devicemodel/Makefile
@@ -4,11 +4,6 @@ include $(XEN_ROOT)/tools/Rules.mk
 MAJOR    = 1
 MINOR    = 4
 
-OBJS-y                 += core.o
-OBJS-$(CONFIG_Linux)   += common.o
-OBJS-$(CONFIG_FreeBSD) += common.o
-OBJS-$(CONFIG_SunOS)   += compat.o
-OBJS-$(CONFIG_NetBSD)  += compat.o
-OBJS-$(CONFIG_MiniOS)  += compat.o
+include Makefile.common
 
 include $(XEN_ROOT)/tools/libs/libs.mk
diff --git a/tools/libs/evtchn/Makefile b/tools/libs/evtchn/Makefile
index 8208ecf650..3dad3840c6 100644
--- a/tools/libs/evtchn/Makefile
+++ b/tools/libs/evtchn/Makefile
@@ -4,11 +4,6 @@ include $(XEN_ROOT)/tools/Rules.mk
 MAJOR    = 1
 MINOR    = 2
 
-OBJS-y                 += core.o
-OBJS-$(CONFIG_Linux)   += linux.o
-OBJS-$(CONFIG_FreeBSD) += freebsd.o
-OBJS-$(CONFIG_SunOS)   += solaris.o
-OBJS-$(CONFIG_NetBSD)  += netbsd.o
-OBJS-$(CONFIG_MiniOS)  += minios.o
+include Makefile.common
 
 include $(XEN_ROOT)/tools/libs/libs.mk
diff --git a/tools/libs/foreignmemory/Makefile b/tools/libs/foreignmemory/Makefile
index 4427435932..b70dd774e4 100644
--- a/tools/libs/foreignmemory/Makefile
+++ b/tools/libs/foreignmemory/Makefile
@@ -4,11 +4,6 @@ include $(XEN_ROOT)/tools/Rules.mk
 MAJOR    = 1
 MINOR    = 4
 
-OBJS-y                 += core.o
-OBJS-$(CONFIG_Linux)   += linux.o
-OBJS-$(CONFIG_FreeBSD) += freebsd.o
-OBJS-$(CONFIG_SunOS)   += compat.o solaris.o
-OBJS-$(CONFIG_NetBSD)  += netbsd.o
-OBJS-$(CONFIG_MiniOS)  += minios.o
+include Makefile.common
 
 include $(XEN_ROOT)/tools/libs/libs.mk
diff --git a/tools/libs/gnttab/Makefile b/tools/libs/gnttab/Makefile
index 7d7aeeadff..3dad3840c6 100644
--- a/tools/libs/gnttab/Makefile
+++ b/tools/libs/gnttab/Makefile
@@ -4,13 +4,6 @@ include $(XEN_ROOT)/tools/Rules.mk
 MAJOR    = 1
 MINOR    = 2
 
-OBJS-GNTTAB            += gnttab_core.o
-OBJS-GNTSHR            += gntshr_core.o
-
-OBJS-$(CONFIG_Linux)   += $(OBJS-GNTTAB) $(OBJS-GNTSHR) linux.o
-OBJS-$(CONFIG_MiniOS)  += $(OBJS-GNTTAB) gntshr_unimp.o minios.o
-OBJS-$(CONFIG_FreeBSD) += $(OBJS-GNTTAB) $(OBJS-GNTSHR) freebsd.o
-OBJS-$(CONFIG_NetBSD)  += $(OBJS-GNTTAB) $(OBJS-GNTSHR) netbsd.o
-OBJS-$(CONFIG_SunOS)   += gnttab_unimp.o gntshr_unimp.o
+include Makefile.common
 
 include $(XEN_ROOT)/tools/libs/libs.mk
diff --git a/tools/libs/guest/Makefile b/tools/libs/guest/Makefile
index 4f2373101f..19d3ff2fdb 100644
--- a/tools/libs/guest/Makefile
+++ b/tools/libs/guest/Makefile
@@ -1,97 +1,11 @@
 XEN_ROOT = $(CURDIR)/../../..
 include $(XEN_ROOT)/tools/Rules.mk
 
-ifeq ($(CONFIG_LIBXC_MINIOS),y)
-# Save/restore of a domain is currently incompatible with a stubdom environment
-override CONFIG_MIGRATE := n
-endif
-
-OBJS-y += xg_private.o
-OBJS-y += xg_domain.o
-OBJS-y += xg_suspend.o
-OBJS-y += xg_resume.o
-ifeq ($(CONFIG_MIGRATE),y)
-OBJS-y += xg_sr_common.o
-OBJS-$(CONFIG_X86) += xg_sr_common_x86.o
-OBJS-$(CONFIG_X86) += xg_sr_common_x86_pv.o
-OBJS-$(CONFIG_X86) += xg_sr_restore_x86_pv.o
-OBJS-$(CONFIG_X86) += xg_sr_restore_x86_hvm.o
-OBJS-$(CONFIG_X86) += xg_sr_save_x86_pv.o
-OBJS-$(CONFIG_X86) += xg_sr_save_x86_hvm.o
-OBJS-y += xg_sr_restore.o
-OBJS-y += xg_sr_save.o
-OBJS-y += xg_offline_page.o
-else
-OBJS-y += xg_nomigrate.o
-endif
-OBJS-y       += xg_core.o
-OBJS-$(CONFIG_X86) += xg_core_x86.o
-OBJS-$(CONFIG_ARM) += xg_core_arm.o
-
-vpath %.c ../../../xen/common/libelf
-
-LIBELF_OBJS += libelf-tools.o libelf-loader.o
-LIBELF_OBJS += libelf-dominfo.o
-
-OBJS-y += $(LIBELF_OBJS)
-
-ifeq ($(CONFIG_X86),y) # Add libx86 to the build
-vpath %.c ../../../xen/lib/x86
-
-OBJS-y                 += cpuid.o msr.o policy.o
-endif
-
-# new domain builder
-OBJS-y                 += xg_dom_core.o
-OBJS-y                 += xg_dom_boot.o
-OBJS-y                 += xg_dom_elfloader.o
-OBJS-$(CONFIG_X86)     += xg_dom_bzimageloader.o
-OBJS-$(CONFIG_X86)     += xg_dom_decompress_lz4.o
-OBJS-$(CONFIG_X86)     += xg_dom_hvmloader.o
-OBJS-$(CONFIG_ARM)     += xg_dom_armzimageloader.o
-OBJS-y                 += xg_dom_binloader.o
-OBJS-y                 += xg_dom_compat_linux.o
-
-OBJS-$(CONFIG_X86)     += xg_dom_x86.o
-OBJS-$(CONFIG_X86)     += xg_cpuid_x86.o
-OBJS-$(CONFIG_ARM)     += xg_dom_arm.o
-
-ifeq ($(CONFIG_LIBXC_MINIOS),y)
-OBJS-y                 += xg_dom_decompress_unsafe.o
-OBJS-y                 += xg_dom_decompress_unsafe_bzip2.o
-OBJS-y                 += xg_dom_decompress_unsafe_lzma.o
-OBJS-y                 += xg_dom_decompress_unsafe_lzo1x.o
-OBJS-y                 += xg_dom_decompress_unsafe_xz.o
-OBJS-y                 += xg_dom_decompress_unsafe_zstd.o
-endif
-
-CFLAGS += -D__XEN_TOOLS__
-CFLAGS += -include $(XEN_ROOT)/tools/config.h
-CFLAGS += -iquote ../../../xen/common/libelf
-
-# To be able to include xc_private.h
-CFLAGS += -iquote $(XEN_libxenctrl)
-
-# Needed for posix_fadvise64() in xc_linux.c
-CFLAGS-$(CONFIG_Linux) += -D_GNU_SOURCE
-
-CFLAGS	+= $(PTHREAD_CFLAGS)
-CFLAGS	+= $(CFLAGS_libxentoollog)
-CFLAGS	+= $(CFLAGS_libxenevtchn)
-CFLAGS	+= $(CFLAGS_libxendevicemodel)
-
-# libxenguest includes xc_private.h, so needs this despite not using
-# this functionality directly.
-CFLAGS += $(CFLAGS_libxencall) $(CFLAGS_libxenforeignmemory)
-
-ifeq ($(CONFIG_MiniOS),y)
-ZLIB_CFLAGS :=
-ZLIB_LIBS :=
-endif
+include Makefile.common
 
 xg_dom_bzimageloader.o xg_dom_bzimageloader.opic: CFLAGS += $(ZLIB_CFLAGS)
 
-$(LIBELF_OBJS) $(LIBELF_OBJS:.o=.opic): CFLAGS += -Wno-pointer-sign
+$(LIBELF_OBJS:.o=.opic): CFLAGS += -Wno-pointer-sign
 
 LIBHEADER := xenguest.h
 
diff --git a/tools/libs/toolcore/Makefile b/tools/libs/toolcore/Makefile
index ce417ea648..0d92b68b3b 100644
--- a/tools/libs/toolcore/Makefile
+++ b/tools/libs/toolcore/Makefile
@@ -6,7 +6,7 @@ MINOR	= 0
 
 LIBHEADER := xentoolcore.h
 
-OBJS-y	+= handlereg.o
+include Makefile.common
 
 include $(XEN_ROOT)/tools/libs/libs.mk
 
diff --git a/tools/libs/toollog/Makefile b/tools/libs/toollog/Makefile
index c09aa02ba5..2361b8cbf1 100644
--- a/tools/libs/toollog/Makefile
+++ b/tools/libs/toollog/Makefile
@@ -4,7 +4,6 @@ include $(XEN_ROOT)/tools/Rules.mk
 MAJOR	= 1
 MINOR	= 0
 
-OBJS-y	+= xtl_core.o
-OBJS-y	+= xtl_logger_stdio.o
+include Makefile.common
 
 include $(XEN_ROOT)/tools/libs/libs.mk
diff --git a/tools/libs/call/Makefile.common b/tools/libs/call/Makefile.common
new file mode 100644
index 0000000000..85e608f8ad
--- /dev/null
+++ b/tools/libs/call/Makefile.common
@@ -0,0 +1,6 @@
+OBJS-y                 += core.o buffer.o
+OBJS-$(CONFIG_Linux)   += linux.o
+OBJS-$(CONFIG_FreeBSD) += freebsd.o
+OBJS-$(CONFIG_SunOS)   += solaris.o
+OBJS-$(CONFIG_NetBSD)  += netbsd.o
+OBJS-$(CONFIG_MiniOS)  += minios.o
diff --git a/tools/libs/ctrl/Makefile.common b/tools/libs/ctrl/Makefile.common
new file mode 100644
index 0000000000..0a09c28fd3
--- /dev/null
+++ b/tools/libs/ctrl/Makefile.common
@@ -0,0 +1,44 @@
+OBJS-y       += xc_altp2m.o
+OBJS-y       += xc_cpupool.o
+OBJS-y       += xc_domain.o
+OBJS-y       += xc_evtchn.o
+OBJS-y       += xc_gnttab.o
+OBJS-y       += xc_misc.o
+OBJS-y       += xc_flask.o
+OBJS-y       += xc_physdev.o
+OBJS-y       += xc_private.o
+OBJS-y       += xc_csched.o
+OBJS-y       += xc_csched2.o
+OBJS-y       += xc_arinc653.o
+OBJS-y       += xc_rt.o
+OBJS-y       += xc_tbuf.o
+OBJS-y       += xc_pm.o
+OBJS-y       += xc_cpu_hotplug.o
+OBJS-y       += xc_vm_event.o
+OBJS-y       += xc_vmtrace.o
+OBJS-y       += xc_monitor.o
+OBJS-y       += xc_mem_paging.o
+OBJS-y       += xc_mem_access.o
+OBJS-y       += xc_memshr.o
+OBJS-y       += xc_hcall_buf.o
+OBJS-y       += xc_foreign_memory.o
+OBJS-y       += xc_kexec.o
+OBJS-y       += xc_resource.o
+OBJS-$(CONFIG_X86) += xc_psr.o
+OBJS-$(CONFIG_X86) += xc_pagetab.o
+OBJS-$(CONFIG_Linux) += xc_linux.o
+OBJS-$(CONFIG_FreeBSD) += xc_freebsd.o
+OBJS-$(CONFIG_SunOS) += xc_solaris.o
+OBJS-$(CONFIG_NetBSD) += xc_netbsd.o
+OBJS-$(CONFIG_NetBSDRump) += xc_netbsd.o
+OBJS-$(CONFIG_MiniOS) += xc_minios.o
+OBJS-y       += xc_evtchn_compat.o
+OBJS-y       += xc_gnttab_compat.o
+OBJS-y       += xc_devicemodel_compat.o
+
+CFLAGS   += -D__XEN_TOOLS__
+CFLAGS	+= $(PTHREAD_CFLAGS)
+CFLAGS += -include $(XEN_ROOT)/tools/config.h
+
+# Needed for posix_fadvise64() in xc_linux.c
+CFLAGS-$(CONFIG_Linux) += -D_GNU_SOURCE
diff --git a/tools/libs/devicemodel/Makefile.common b/tools/libs/devicemodel/Makefile.common
new file mode 100644
index 0000000000..a7bf7c35bb
--- /dev/null
+++ b/tools/libs/devicemodel/Makefile.common
@@ -0,0 +1,6 @@
+OBJS-y                 += core.o
+OBJS-$(CONFIG_Linux)   += common.o
+OBJS-$(CONFIG_FreeBSD) += common.o
+OBJS-$(CONFIG_SunOS)   += compat.o
+OBJS-$(CONFIG_NetBSD)  += compat.o
+OBJS-$(CONFIG_MiniOS)  += compat.o
diff --git a/tools/libs/evtchn/Makefile.common b/tools/libs/evtchn/Makefile.common
new file mode 100644
index 0000000000..20629f521a
--- /dev/null
+++ b/tools/libs/evtchn/Makefile.common
@@ -0,0 +1,6 @@
+OBJS-y                 += core.o
+OBJS-$(CONFIG_Linux)   += linux.o
+OBJS-$(CONFIG_FreeBSD) += freebsd.o
+OBJS-$(CONFIG_SunOS)   += solaris.o
+OBJS-$(CONFIG_NetBSD)  += netbsd.o
+OBJS-$(CONFIG_MiniOS)  += minios.o
diff --git a/tools/libs/foreignmemory/Makefile.common b/tools/libs/foreignmemory/Makefile.common
new file mode 100644
index 0000000000..ff3b1d4f3e
--- /dev/null
+++ b/tools/libs/foreignmemory/Makefile.common
@@ -0,0 +1,6 @@
+OBJS-y                 += core.o
+OBJS-$(CONFIG_Linux)   += linux.o
+OBJS-$(CONFIG_FreeBSD) += freebsd.o
+OBJS-$(CONFIG_SunOS)   += compat.o solaris.o
+OBJS-$(CONFIG_NetBSD)  += netbsd.o
+OBJS-$(CONFIG_MiniOS)  += minios.o
diff --git a/tools/libs/gnttab/Makefile.common b/tools/libs/gnttab/Makefile.common
new file mode 100644
index 0000000000..759e36e1cb
--- /dev/null
+++ b/tools/libs/gnttab/Makefile.common
@@ -0,0 +1,8 @@
+OBJS-GNTTAB            += gnttab_core.o
+OBJS-GNTSHR            += gntshr_core.o
+
+OBJS-$(CONFIG_Linux)   += $(OBJS-GNTTAB) $(OBJS-GNTSHR) linux.o
+OBJS-$(CONFIG_MiniOS)  += $(OBJS-GNTTAB) gntshr_unimp.o minios.o
+OBJS-$(CONFIG_FreeBSD) += $(OBJS-GNTTAB) $(OBJS-GNTSHR) freebsd.o
+OBJS-$(CONFIG_NetBSD)  += $(OBJS-GNTTAB) $(OBJS-GNTSHR) netbsd.o
+OBJS-$(CONFIG_SunOS)   += gnttab_unimp.o gntshr_unimp.o
diff --git a/tools/libs/guest/Makefile.common b/tools/libs/guest/Makefile.common
new file mode 100644
index 0000000000..a026a2f662
--- /dev/null
+++ b/tools/libs/guest/Makefile.common
@@ -0,0 +1,84 @@
+ifeq ($(CONFIG_LIBXC_MINIOS),y)
+# Save/restore of a domain is currently incompatible with a stubdom environment
+override CONFIG_MIGRATE := n
+endif
+
+OBJS-y += xg_private.o
+OBJS-y += xg_domain.o
+OBJS-y += xg_suspend.o
+OBJS-y += xg_resume.o
+ifeq ($(CONFIG_MIGRATE),y)
+OBJS-y += xg_sr_common.o
+OBJS-$(CONFIG_X86) += xg_sr_common_x86.o
+OBJS-$(CONFIG_X86) += xg_sr_common_x86_pv.o
+OBJS-$(CONFIG_X86) += xg_sr_restore_x86_pv.o
+OBJS-$(CONFIG_X86) += xg_sr_restore_x86_hvm.o
+OBJS-$(CONFIG_X86) += xg_sr_save_x86_pv.o
+OBJS-$(CONFIG_X86) += xg_sr_save_x86_hvm.o
+OBJS-y += xg_sr_restore.o
+OBJS-y += xg_sr_save.o
+OBJS-y += xg_offline_page.o
+else
+OBJS-y += xg_nomigrate.o
+endif
+OBJS-y       += xg_core.o
+OBJS-$(CONFIG_X86) += xg_core_x86.o
+OBJS-$(CONFIG_ARM) += xg_core_arm.o
+
+vpath %.c ../../../xen/common/libelf
+
+LIBELF_OBJS += libelf-tools.o libelf-loader.o
+LIBELF_OBJS += libelf-dominfo.o
+
+OBJS-y += $(LIBELF_OBJS)
+
+ifeq ($(CONFIG_X86),y) # Add libx86 to the build
+vpath %.c ../../../xen/lib/x86
+
+OBJS-y                 += cpuid.o msr.o policy.o
+endif
+
+# new domain builder
+OBJS-y                 += xg_dom_core.o
+OBJS-y                 += xg_dom_boot.o
+OBJS-y                 += xg_dom_elfloader.o
+OBJS-$(CONFIG_X86)     += xg_dom_bzimageloader.o
+OBJS-$(CONFIG_X86)     += xg_dom_decompress_lz4.o
+OBJS-$(CONFIG_X86)     += xg_dom_hvmloader.o
+OBJS-$(CONFIG_ARM)     += xg_dom_armzimageloader.o
+OBJS-y                 += xg_dom_binloader.o
+OBJS-y                 += xg_dom_compat_linux.o
+
+OBJS-$(CONFIG_X86)     += xg_dom_x86.o
+OBJS-$(CONFIG_X86)     += xg_cpuid_x86.o
+OBJS-$(CONFIG_ARM)     += xg_dom_arm.o
+
+ifeq ($(CONFIG_LIBXC_MINIOS),y)
+OBJS-y                 += xg_dom_decompress_unsafe.o
+OBJS-y                 += xg_dom_decompress_unsafe_bzip2.o
+OBJS-y                 += xg_dom_decompress_unsafe_lzma.o
+OBJS-y                 += xg_dom_decompress_unsafe_lzo1x.o
+OBJS-y                 += xg_dom_decompress_unsafe_xz.o
+OBJS-y                 += xg_dom_decompress_unsafe_zstd.o
+endif
+
+CFLAGS += -D__XEN_TOOLS__
+CFLAGS += -include $(XEN_ROOT)/tools/config.h
+CFLAGS += -iquote ../../../xen/common/libelf
+
+# To be able to include xc_private.h
+CFLAGS += -iquote $(XEN_libxenctrl)
+
+# Needed for posix_fadvise64() in xc_linux.c
+CFLAGS-$(CONFIG_Linux) += -D_GNU_SOURCE
+
+CFLAGS	+= $(PTHREAD_CFLAGS)
+CFLAGS	+= $(CFLAGS_libxentoollog)
+CFLAGS	+= $(CFLAGS_libxenevtchn)
+CFLAGS	+= $(CFLAGS_libxendevicemodel)
+
+# libxenguest includes xc_private.h, so needs this despite not using
+# this functionality directly.
+CFLAGS += $(CFLAGS_libxencall) $(CFLAGS_libxenforeignmemory)
+
+$(LIBELF_OBJS): CFLAGS += -Wno-pointer-sign
diff --git a/tools/libs/toolcore/Makefile.common b/tools/libs/toolcore/Makefile.common
new file mode 100644
index 0000000000..9ade6c12bf
--- /dev/null
+++ b/tools/libs/toolcore/Makefile.common
@@ -0,0 +1 @@
+OBJS-y	+= handlereg.o
diff --git a/tools/libs/toollog/Makefile.common b/tools/libs/toollog/Makefile.common
new file mode 100644
index 0000000000..c053ac6a73
--- /dev/null
+++ b/tools/libs/toollog/Makefile.common
@@ -0,0 +1,2 @@
+OBJS-y	+= xtl_core.o
+OBJS-y	+= xtl_logger_stdio.o
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Fri Feb 25 15:16:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 15:16:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279282.476988 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcKr-0001cg-6B; Fri, 25 Feb 2022 15:16:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279282.476988; Fri, 25 Feb 2022 15:16:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcKq-0001cA-Rm; Fri, 25 Feb 2022 15:16:44 +0000
Received: by outflank-mailman (input) for mailman id 279282;
 Fri, 25 Feb 2022 15:16:42 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=E0Ll=TI=citrix.com=prvs=04808661d=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nNcIP-0006fy-R5
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 15:14:13 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 95676d2b-964d-11ec-8539-5f4723681683;
 Fri, 25 Feb 2022 16:14:11 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 95676d2b-964d-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645802051;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=lstnw/Cy7kkWvWE8Q3+svCB9Cq3t+tCtdqmShje5Wb4=;
  b=iCo1ZrnSy60EYtvdgjJU+nbJliVULEDnAgYxBv1dyaWTbEWtGMvTDrgY
   +VO52MMv5C5bnCm12+9EH9HspnMIan27OtMi/ZQp/1M37G5/6sUFr3/Ra
   HoVjFvGXocHKxhJHKMXCcgAcu2FTKVb8CZyv9HukXnF+msuxAqGaX0BhJ
   I=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 67264776
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:CLdS6ameic96krdP7A9bnRfo5gz7JkRdPkR7XQ2eYbSJt1+Wr1Gzt
 xIfXWGDMqneN2WgL4wiYImx9RhTu8DXnINmSFdq/nw9ECMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EoLd9IR2NYy24DjWV7V4
 7senuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR
 v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ
 NtxWZOYTgEOI47epskmUD5gMnFTOoFE4aPACC3q2SCT5xWun3rExvxvCAc9PJEC+/YxCmZLn
 RAaAGlTNFbZ3bvwme/lDLk37iggBJCD0Ic3s3d8zTbfHLA+TIrKWani7t5ExjYgwMtJGJ4yY
 uJHNmAxMEufPXWjPH8lWIB5hcOWmULEfj5mr3+7te0d+ELMmVkZPL/Fb4OOJ43iqd9utlmcj
 nLL+SL+GB5yHN6Q0z2e6Vq3m/TC2yj8Xeo6BLC+s/JnnlCX7mgSEwENE0u2p+GjjUyzUM4ZL
 FYbkhfCtoBrqhbtFIOkGUTl/jjU5XbwRua8DcU97iaQ6bjqzj2aIVAlHhNGRN4/qMgfEGlCO
 kCyo/vlAjlmsbuwQH2b96uJoT7aBRX5PVPudgdfE1JbvoCLTJUby0uWE409SPLdYsjdRGmoq
 w1muhTSkFn6YSQj86ygtW7KjDu3znQiZl5kv16HNo5JA+4QWWJEW2BKwQSKhRqjBNzAJrVkg
 JTis5LPhAzpJcvQ/BFhuM1XQNmUCw+taVUwe2JHEZg77CiK8HW+Z41W6zwWDB43bptbJWa1P
 ReL4Vs5CHpv0J2CN/4fj2WZUZlC8EQdPY69CqC8giRmOPCdizNrDAkxPBXNjggBYWAnkL0lO
 IfzTCpfJS1yNEiT9xLvH711+eZynkgWnDqPLbimn0XP+efPPxa9FOZaWGZim8hktctoVi2Oq
 I0BXyZLoj0CONDDjt7/qtZCfQhXdiFgXfgbaaV/L4a+H+avI0l5Y9e5/F/rU9UNc3h9/gsQw
 kyAZw==
IronPort-HdrOrdr: A9a23:2FKlp6qBOvzFfhuOvMkasUcaV5oteYIsimQD101hICG8cqSj+P
 xG+85rsiMc6QxhIU3I9urgBEDtex7hHNtOkOss1NSZLW3bUQmTTL2KhLGKq1aLJ8S9zJ856U
 4JSdkZNDSaNzZHZKjBjDVQa+xQo+W6zA==
X-IronPort-AV: E=Sophos;i="5.90,136,1643691600"; 
   d="scan'208";a="67264776"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross
	<jgross@suse.com>, Wei Liu <wl@xen.org>
Subject: [XEN PATCH v2 21/29] libs/stat: Fix and rework python-bindings build
Date: Fri, 25 Feb 2022 15:13:13 +0000
Message-ID: <20220225151321.44126-22-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220225151321.44126-1-anthony.perard@citrix.com>
References: <20220225151321.44126-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

Fix the dependency on the library, $(SHLIB) variable doesn't exist
anymore.

Rework dependency on the include file, we can let `swig` generate the
dependency for us with the use of "-M*" flags.

The xenstat.h file has moved so we need to fix the include location.

Rather than relaying on the VCS to create an empty directory for us,
we can create one before generating the *.c file for the bindings.

Make use of generic variable names to build a shared library from a
source file: CFLAGS, LDFLAGS, and LDLIBS.

Fix python's specific *flags by using python-config, and add them to
generic flags variables: CFLAGS, LDLIBS.

To build a shared library, we need to build the source file with
"-fPIC", which was drop by 6d0ec05390 (tools: split libxenstat into
new tools/libs/stat directory).

The source file generated by swig seems to be missing a prototype for
the "init" function, so we need "-Wno-missing-prototypes" in order to
build it.

Add some targets to .PHONY.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
---

Notes:
    v2:
    - reviewed

 tools/libs/stat/Makefile                    | 27 +++++++++++++++------
 tools/libs/stat/bindings/swig/python/.empty |  1 -
 2 files changed, 19 insertions(+), 9 deletions(-)
 delete mode 100644 tools/libs/stat/bindings/swig/python/.empty

diff --git a/tools/libs/stat/Makefile b/tools/libs/stat/Makefile
index 998435d494..b8d75810fc 100644
--- a/tools/libs/stat/Makefile
+++ b/tools/libs/stat/Makefile
@@ -49,23 +49,34 @@ install-bindings: install-perl-bindings install-python-bindings
 .PHONY: uninstall-bindings
 uninstall-bindings: uninstall-perl-bindings uninstall-python-bindings
 
-$(BINDINGS): $(SHLIB) $(SHLIB_LINKS) include/xenstat.h
+$(BINDINGS): libxenstat.so
 
-SWIG_FLAGS=-module xenstat -Iinclude -I.
+SWIG_FLAGS = -module xenstat -I$(XEN_INCLUDE)
+SWIG_FLAGS += -MMD -MP -MF .$(if $(filter-out .,$(@D)),$(subst /,@,$(@D))@)$(@F).d
 
 # Python bindings
-PYTHON_VERSION=$(PYTHON:python%=%)
-PYTHON_FLAGS=-I/usr/include/python$(PYTHON_VERSION) -lpython$(PYTHON_VERSION)
 $(PYMOD): $(PYSRC)
 $(PYSRC): bindings/swig/xenstat.i
-	swig -python $(SWIG_FLAGS) -outdir $(@D) -o $(PYSRC) $<
-
+	mkdir -p $(@D)
+	swig -python $(SWIG_FLAGS) -outdir $(@D) -o $@ $<
+
+$(PYLIB): CFLAGS += $(shell $(PYTHON)-config --includes)
+$(PYLIB): CFLAGS += -fPIC
+$(PYLIB): CFLAGS += -Wno-missing-prototypes
+$(PYLIB): LDFLAGS += $(SHLIB_LDFLAGS)
+$(PYLIB): LDLIBS := $(shell $(PYTHON)-config --libs)
+$(PYLIB): LDLIBS += $(LDLIBS_libxenstat)
 $(PYLIB): $(PYSRC)
-	$(CC) $(CFLAGS) $(LDFLAGS) $(PYTHON_FLAGS) $(SHLIB_LDFLAGS) -lxenstat -o $@ $< $(APPEND_LDFLAGS)
+	$(CC) $(CFLAGS) $(LDFLAGS) -o $@ $< $(LDLIBS) $(APPEND_LDFLAGS)
 
+.PHONY: python-bindings
 python-bindings: $(PYLIB) $(PYMOD)
 
-pythonlibdir=$(prefix)/lib/python$(PYTHON_VERSION)/site-packages
+pythonlibdir = $(shell $(PYTHON) -c \
+	       'import distutils.sysconfig as cfg; \
+	        print(cfg.get_python_lib(False, False, prefix="$(prefix)"))')
+
+.PHONY: install-python-bindings
 install-python-bindings: $(PYLIB) $(PYMOD)
 	$(INSTALL_PROG) $(PYLIB) $(DESTDIR)$(pythonlibdir)/_xenstat.so
 	$(INSTALL_PROG) $(PYMOD) $(DESTDIR)$(pythonlibdir)/xenstat.py
diff --git a/tools/libs/stat/bindings/swig/python/.empty b/tools/libs/stat/bindings/swig/python/.empty
deleted file mode 100644
index 2a8dd4274d..0000000000
--- a/tools/libs/stat/bindings/swig/python/.empty
+++ /dev/null
@@ -1 +0,0 @@
-This directory is empty; this file is included to prevent version control systems from removing the directory.
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Fri Feb 25 15:16:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 15:16:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279285.476990 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcKr-0001hh-K7; Fri, 25 Feb 2022 15:16:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279285.476990; Fri, 25 Feb 2022 15:16:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcKr-0001f1-9r; Fri, 25 Feb 2022 15:16:45 +0000
Received: by outflank-mailman (input) for mailman id 279285;
 Fri, 25 Feb 2022 15:16:42 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=E0Ll=TI=citrix.com=prvs=04808661d=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nNcIH-0007Bf-8N
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 15:14:05 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 90344314-964d-11ec-8eb9-a37418f5ba1a;
 Fri, 25 Feb 2022 16:14:03 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 90344314-964d-11ec-8eb9-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645802043;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=Qi8ktRfGxKz6TVNBfNc+szyw4+rNfchyhf2q4Nw7GMs=;
  b=F4n+rKBh+eAVFe6BXWJtVlf0DVGDoWrWGGqNwnlV3Rm9cLmP4WslD5L9
   yVj9EjemY8P9TnhQdRq6ZwENXP7InJO+JHWYzIxQNdX4k3IVoRFkKdSJl
   kr8In1+nV5y6G4QdUQqM2KOlp5VbO8xM3JwxpuM043JWQ4cFV7DmglupJ
   0=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 64433034
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:4qtPwK3DISLmD7J/6fbD5blxkn2cJEfYwER7XKvMYLTBsI5bp2YCz
 TZNDzjSOfneMWT3Kt1zPN+0pEpUvsDTzd9gHldqpC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EE/NtTo5w7Rj2tQy3IDja++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /1xj467FiUxN5beicMsUiVqTSxbYYJ/reqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHiOp8fvXdxiynUF/88TbjIQrnQ5M8e1zA17ixLNaiCO
 5FCMWEzBPjGSwRKGg8PI5UaoMipqGLAagZjik+vo6VitgA/yyQuieOwYbI5YOeiWsF9jkue4
 GXc8AzREhwccdCS1zeB2natnfPU2zP2XpoIE7+1/eIsh0ecrlH/EzVPCwH9+6PgzBfjBZQPc
 CT45xbCs4AOzl6gEfvlViaqsVm1vyIuBdd1T8IDvVTlJrXv3y6VAW0NTzhkYdMgtdMrSTFC6
 mJlj+8FFhQ07uTLFCv1GqO86GrrZHNLdTNqiTosEFNdi+QPtr3fmf4mojxLNKeuxuP4Fjjrq
 9xhhHhv3u5D5SLnOkjSwLwmv95OjsSYJuLWzl+ONo5A0u+fTNT0D2BPwQKGhcus1K7DEjG8U
 IEswqByFtwmA5CXjzCqS+4QBryv7PvtGGSC3QMwQ8B9qmz1oybLkWVsDNdWfhYB3iEsI2KBX
 aMukVkJuM870IWCN8ebnL5d++x1lPO9RLwJp9jfb8ZUY4gZSeN01HoGWKJk5Ei0yBJEufhmY
 f+zKJ/wZV5HWfUP5GfnHI81jO50rh3SMEuOHPgXOTz8iuHADJNUIJ9YWGazghcRt/vV8F2Iq
 I8Eb6NnCXx3CYXDX8UeyqZLRXhiEJTxLcmowyCLXoZv+jZbJVw=
IronPort-HdrOrdr: A9a23:ghfykK9AO/Fxt7JMo09uk+DgI+orL9Y04lQ7vn2YSXRuHPBw8P
 re+sjztCWE8Ar5N0tBpTntAsW9qDbnhPtICOoqTNCftWvdyQiVxehZhOOIqVDd8m/Fh4pgPM
 9bAtFD4bbLbGSS4/yU3ODBKadD/OW6
X-IronPort-AV: E=Sophos;i="5.90,136,1643691600"; 
   d="scan'208";a="64433034"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@citrix.com>, Wei Liu <wl@xen.org>
Subject: [XEN PATCH v2 10/29] tools/xenpaging: Rework makefile
Date: Fri, 25 Feb 2022 15:13:02 +0000
Message-ID: <20220225151321.44126-11-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220225151321.44126-1-anthony.perard@citrix.com>
References: <20220225151321.44126-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

- Rename $(SRCS) to $(OBJS-y), we don't need to collect sources.
- Rename $(IBINS) to $(TARGETS)
- Stop cleaning "xen" and non-set variable $(LIB).

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 tools/xenpaging/Makefile | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/tools/xenpaging/Makefile b/tools/xenpaging/Makefile
index 04743b335c..e2ed9eaa3f 100644
--- a/tools/xenpaging/Makefile
+++ b/tools/xenpaging/Makefile
@@ -5,33 +5,33 @@ CFLAGS += $(CFLAGS_libxentoollog) $(CFLAGS_libxenevtchn) $(CFLAGS_libxenctrl) $(
 LDLIBS += $(LDLIBS_libxentoollog) $(LDLIBS_libxenevtchn) $(LDLIBS_libxenctrl) $(LDLIBS_libxenstore) $(PTHREAD_LIBS)
 LDFLAGS += $(PTHREAD_LDFLAGS)
 
-POLICY    = default
+POLICY   := default
 
-SRC      :=
-SRCS     += file_ops.c xenpaging.c policy_$(POLICY).c
-SRCS     += pagein.c
+OBJS-y   := file_ops.o
+OBJS-y   += xenpaging.o
+OBJS-y   += policy_$(POLICY).o
+OBJS-y   += pagein.o
 
 CFLAGS   += -Werror
 CFLAGS   += -Wno-unused
 
-OBJS     = $(SRCS:.c=.o)
-IBINS    = xenpaging
+TARGETS := xenpaging
 
-all: $(IBINS)
+all: $(TARGETS)
 
-xenpaging: $(OBJS)
+xenpaging: $(OBJS-y)
 	$(CC) $(LDFLAGS) -o $@ $^ $(LDLIBS) $(APPEND_LDFLAGS)
 
 install: all
 	$(INSTALL_DIR) -m 0700 $(DESTDIR)$(XEN_PAGING_DIR)
 	$(INSTALL_DIR) $(DESTDIR)$(LIBEXEC_BIN)
-	$(INSTALL_PROG) $(IBINS) $(DESTDIR)$(LIBEXEC_BIN)
+	$(INSTALL_PROG) $(TARGETS) $(DESTDIR)$(LIBEXEC_BIN)
 
 uninstall:
-	rm -f $(addprefix $(DESTDIR)$(LIBEXEC_BIN)/, $(IBINS))
+	rm -f $(addprefix $(DESTDIR)$(LIBEXEC_BIN)/, $(TARGETS))
 
 clean:
-	rm -f *.o *~ $(DEPS_RM) xen TAGS $(IBINS) $(LIB)
+	rm -f *.o *~ $(DEPS_RM) TAGS $(TARGETS)
 
 distclean: clean
 
@@ -39,6 +39,6 @@ distclean: clean
 
 .PHONY: TAGS
 TAGS:
-	etags -t $(SRCS) *.h
+	etags -t *.c *.h
 
 -include $(DEPS_INCLUDE)
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Fri Feb 25 15:16:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 15:16:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279286.476997 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcKs-0001oB-1M; Fri, 25 Feb 2022 15:16:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279286.476997; Fri, 25 Feb 2022 15:16:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcKr-0001l2-O7; Fri, 25 Feb 2022 15:16:45 +0000
Received: by outflank-mailman (input) for mailman id 279286;
 Fri, 25 Feb 2022 15:16:43 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=E0Ll=TI=citrix.com=prvs=04808661d=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nNcIX-0006fy-SP
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 15:14:21 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9af70695-964d-11ec-8539-5f4723681683;
 Fri, 25 Feb 2022 16:14:20 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9af70695-964d-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645802060;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=zUPvHCMrHWztCdZF7XbOEKTRFq0ToqxKkhG98hXZpoI=;
  b=YrlaRQD5Aa33JuOGuqUBaqA1iN5OncTLT6WFT7Qy+8Jhm/zVADYaiUkv
   K/WIJpXKea3sZKGFD+c3EwABmxaEeZd3t9Z77FTWaCnN2kvQwgtg9ZpNL
   8475PuhrOUiWgzGJt7elX/Ukau4IN7RtOOiaDSx9cvVGWCuAkzWgL7dvq
   4=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 64433090
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:OzsjYq5KZJr+Pz+KkCm9EgxRtCDHchMFZxGqfqrLsTDasY5as4F+v
 mJNCzrVb67YNDPwLd53O4q18ElTu57RyNNlHQtrqihgHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0XqPp8Zj2tQy2YLjXlvX0
 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X
 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx
 umhurSdSRYXI/HNnt4PCRp0HiRMEJBnwePIdC3XXcy7lyUqclPpyvRqSko3IZcZ6qB8BmQmG
 f4wcW5XKErZ3qTvnez9GrIEascLdaEHOKsWvG1gyjfIS+4rW5nZT43B5MNC3Sd2jcdLdRrbT
 5RFNWE0NEWYC/FJEkoaJokFsceQvHfiXhJTpVPOo5omuFGGmWSd15CyaYGIK7RmX/59gUKwt
 m/AuWPjDXkyL9Wa1DeBtG6sh+XGgCfncI8UD/i85/lsxlqJyQQ7GBAQEFe2v/S9okq/QM5Eb
 VwZ/DI0qqo//1DtScPyNzW6r2SDpQU0QMdLHqsx7wTl90bPy1/HXC5eFGcHMYF48p9tLdA36
 rOXt/7pFAJy7LyTc2DH9ZuZqAGfBAkscWBXMEfoUjA5y9XkpYgyiDfGQdBiDLO5g7XJJN3g/
 9yZhHNg3utO1Kbnw43+pAma2Gz0+vAlWyZovl2/Y46z0u9uiGdJjaSM4EOT0/tPJZ3xorKp7
 CldwJj2AAzj4PiweM2xrAclQODBCxWtamS0bbtT838JrWXFF5mLJ9043d2GDB01WvvogBewC
 KMphStf5YVIIFyhZrJtboS6BqwClPa8SIu5D6yJNoIWOvCdkTNrGgk0NCZ8OEi3zSARfVwXY
 8/HIa5A815AYUiY8NZGb7hEiuJ6rszP7WjSWYr633yaPUm2PxaopUM+GALWNIgRtfrcyC2Mq
 oo3H5bamn13DbylCgGKoNF7ELz/BSVibXwAg5cMLbDrz8sPMDxJNsI9Npt6I901x/kOz7yQl
 px/M2cBoGfCabT8AV3iQhhehHnHB/6TcVpT0fQQAGuV
IronPort-HdrOrdr: A9a23:86t1jq2sqHlSKlmk7QFdrgqjBLQkLtp133Aq2lEZdPRUGvb2qy
 nIpoV96faUskdpZJhOo7G90cW7LE80sKQFg7X5Xo3SODUO2lHJEGgK1+KLqFfd8m/Fh4tgPM
 9bAs5D4bbLY2SS4/yX3ODBKadC/OW6
X-IronPort-AV: E=Sophos;i="5.90,136,1643691600"; 
   d="scan'208";a="64433090"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross
	<jgross@suse.com>, Wei Liu <wl@xen.org>, Samuel Thibault
	<samuel.thibault@ens-lyon.org>
Subject: [XEN PATCH v2 26/29] tools/xenstore: introduce Makefile.common to be used by stubdom
Date: Fri, 25 Feb 2022 15:13:18 +0000
Message-ID: <20220225151321.44126-27-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220225151321.44126-1-anthony.perard@citrix.com>
References: <20220225151321.44126-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

Also change stubdom to depends on Makefile.common.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
---

Notes:
    v2:
    - reviewed

 stubdom/Makefile               |  4 ++--
 tools/xenstore/Makefile        | 33 +++------------------------------
 tools/xenstore/Makefile.common | 33 +++++++++++++++++++++++++++++++++
 3 files changed, 38 insertions(+), 32 deletions(-)
 create mode 100644 tools/xenstore/Makefile.common

diff --git a/stubdom/Makefile b/stubdom/Makefile
index fbc63a5063..6b804824ba 100644
--- a/stubdom/Makefile
+++ b/stubdom/Makefile
@@ -371,10 +371,10 @@ endef
 
 $(foreach lib,$(STUB_LIBS),$(eval $(call BUILD_lib,$(lib))))
 
-xenstore/stamp: $(XEN_ROOT)/tools/xenstore/Makefile
+xenstore/stamp: $(XEN_ROOT)/tools/xenstore/Makefile.common
 	$(do_links)
 
-xenstorepvh/stamp: $(XEN_ROOT)/tools/xenstore/Makefile
+xenstorepvh/stamp: $(XEN_ROOT)/tools/xenstore/Makefile.common
 	$(do_links)
 
 LINK_DIRS := xenstore xenstorepvh $(foreach dir,$(STUB_LIBS),libs-$(XEN_TARGET_ARCH)/$(dir))
diff --git a/tools/xenstore/Makefile b/tools/xenstore/Makefile
index 830052c65f..1b66190cc5 100644
--- a/tools/xenstore/Makefile
+++ b/tools/xenstore/Makefile
@@ -1,31 +1,7 @@
 XEN_ROOT=$(CURDIR)/../..
 include $(XEN_ROOT)/tools/Rules.mk
 
-CFLAGS += -Werror
-# Include configure output (config.h)
-CFLAGS += -include $(XEN_ROOT)/tools/config.h
-CFLAGS += -I./include
-CFLAGS += $(CFLAGS_libxenevtchn)
-CFLAGS += $(CFLAGS_libxenctrl)
-CFLAGS += $(CFLAGS_libxenguest)
-CFLAGS += $(CFLAGS_libxentoolcore)
-CFLAGS += -DXEN_LIB_STORED="\"$(XEN_LIB_STORED)\""
-CFLAGS += -DXEN_RUN_STORED="\"$(XEN_RUN_STORED)\""
-
-ifdef CONFIG_STUBDOM
-CFLAGS += -DNO_SOCKETS=1
-endif
-
-XENSTORED_OBJS-y := xenstored_core.o xenstored_watch.o xenstored_domain.o
-XENSTORED_OBJS-y += xenstored_transaction.o xenstored_control.o
-XENSTORED_OBJS-y += xs_lib.o talloc.o utils.o tdb.o hashtable.o
-
-XENSTORED_OBJS-$(CONFIG_Linux) += xenstored_posix.o
-XENSTORED_OBJS-$(CONFIG_NetBSD) += xenstored_posix.o
-XENSTORED_OBJS-$(CONFIG_FreeBSD) += xenstored_posix.o
-XENSTORED_OBJS-$(CONFIG_MiniOS) += xenstored_minios.o
-
-$(XENSTORED_OBJS-y): CFLAGS += $(CFLAGS_libxengnttab)
+include Makefile.common
 
 xenstored: LDLIBS += $(LDLIBS_libxenevtchn)
 xenstored: LDLIBS += $(LDLIBS_libxengnttab)
@@ -65,9 +41,6 @@ clients: xenstore $(CLIENTS) xenstore-control
 xenstored: $(XENSTORED_OBJS-y)
 	$(CC) $(LDFLAGS) $^ $(LDLIBS) -o $@ $(APPEND_LDFLAGS)
 
-xenstored.a: $(XENSTORED_OBJS-y)
-	$(AR) cr $@ $^
-
 $(CLIENTS): xenstore
 	ln -f xenstore $@
 
@@ -81,8 +54,8 @@ xs_tdb_dump: xs_tdb_dump.o utils.o tdb.o talloc.o
 	$(CC) $(LDFLAGS) $^ -o $@ $(APPEND_LDFLAGS)
 
 .PHONY: clean
-clean:
-	$(RM) *.a *.o $(TARGETS) $(DEPS_RM)
+clean::
+	$(RM) $(TARGETS) $(DEPS_RM)
 
 .PHONY: distclean
 distclean: clean
diff --git a/tools/xenstore/Makefile.common b/tools/xenstore/Makefile.common
new file mode 100644
index 0000000000..21b78b0538
--- /dev/null
+++ b/tools/xenstore/Makefile.common
@@ -0,0 +1,33 @@
+# Makefile shared with stubdom
+
+XENSTORED_OBJS-y := xenstored_core.o xenstored_watch.o xenstored_domain.o
+XENSTORED_OBJS-y += xenstored_transaction.o xenstored_control.o
+XENSTORED_OBJS-y += xs_lib.o talloc.o utils.o tdb.o hashtable.o
+
+XENSTORED_OBJS-$(CONFIG_Linux) += xenstored_posix.o
+XENSTORED_OBJS-$(CONFIG_NetBSD) += xenstored_posix.o
+XENSTORED_OBJS-$(CONFIG_FreeBSD) += xenstored_posix.o
+XENSTORED_OBJS-$(CONFIG_MiniOS) += xenstored_minios.o
+
+CFLAGS += -Werror
+# Include configure output (config.h)
+CFLAGS += -include $(XEN_ROOT)/tools/config.h
+CFLAGS += -I./include
+CFLAGS += $(CFLAGS_libxenevtchn)
+CFLAGS += $(CFLAGS_libxenctrl)
+CFLAGS += $(CFLAGS_libxenguest)
+CFLAGS += $(CFLAGS_libxentoolcore)
+CFLAGS += -DXEN_LIB_STORED="\"$(XEN_LIB_STORED)\""
+CFLAGS += -DXEN_RUN_STORED="\"$(XEN_RUN_STORED)\""
+
+ifdef CONFIG_STUBDOM
+CFLAGS += -DNO_SOCKETS=1
+endif
+
+$(XENSTORED_OBJS-y): CFLAGS += $(CFLAGS_libxengnttab)
+
+xenstored.a: $(XENSTORED_OBJS-y)
+	$(AR) cr $@ $^
+
+clean::
+	$(RM) *.a *.o
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Fri Feb 25 15:16:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 15:16:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279288.477003 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcKs-0001xz-PE; Fri, 25 Feb 2022 15:16:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279288.477003; Fri, 25 Feb 2022 15:16:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcKs-0001u7-B5; Fri, 25 Feb 2022 15:16:46 +0000
Received: by outflank-mailman (input) for mailman id 279288;
 Fri, 25 Feb 2022 15:16:43 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=E0Ll=TI=citrix.com=prvs=04808661d=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nNcIK-0006fy-6j
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 15:14:08 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 93144fa5-964d-11ec-8539-5f4723681683;
 Fri, 25 Feb 2022 16:14:06 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 93144fa5-964d-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645802046;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=qfHKg9nbI8bb67OsGXzXE6dg5Icrubx3wFHR9cPr4Ug=;
  b=JOM1eAyBzQhkTQTHJ7qH5GJYVBuC0ggkJcoMoFIxp5gD0bpbmUF26rcb
   NspPOkmjG/b5LY459efDRhRnW9/ev6Q4ssBIYAbhOiZfOoqI0Gksi2WW7
   nCT6NWZe0CqKm4js2BuUDx0fITkMRC/vWdi8MRI8eN+eLqglxiuBecUKq
   c=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 64433057
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:RvLwoKth63cf0m/xIS7FaE0WEufnVCxeMUV32f8akzHdYApBsoF/q
 tZmKWuAbvuKNjCgeYwnaYqyoB9TvpDWz4ViGwtspH00RXtE+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQyw4bVvqYy2YLjW1nX5
 IuoyyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb
 /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo
 Oihu6BcRi81D4HepvYdcCVXLCRnHJ8BoZ39LnWg5Jn7I03uKxMAwt1rBUAye4YZ5vx2ESdF8
 vlwxDIlN07ZwbjsmfTiF7cq1p9LwMrDZevzvllpyy3ZCvA3B4jOWazQ6fdT3Ssqh9AIFvHbD
 yYcQWQzME+bO0AQUrsRIJxks8ikqWPbTwR370CVp4E9/HHP4iUkhdABN/KKI4fXFK25hH2wu
 Wbu72n/RBYAO7S3yzWf9Wm3rvTShi69U4UXfJWo+/gvjFCNy2g7DBwNSUD9sfS/klS5Wd9UN
 woT4CVGkEQp3BX1FJ+nBUT++SPa+E5HMzZNLwEkwB285rjq8Qa6Omc7SydgWpt/lvU5SCN/g
 zdlgOjVLTBotbSUT1eU+bGVsS6+NEApEIMSWcMXZVBbuoe++enfmjqKF48+S/Dt0rUZDBmtm
 2jikcQou1kEYSfnPY2f9EuPvT+jr4OhouUdtlSOBTLNAu+UieeYi22UBbrzsacowGWxFADpU
 J04dy62trFm4XalznHlfQn1NOv1j8tpyRWF6bKVI7Ev9i6251modp1K7Td1KS9Ba5hYJGC1O
 ROO4VsJvPe/2UdGi4ctMupd7OxwkMDd+SnNDKiIPrKinLArHON4wM2eTRHJhD28+KTduao+J
 Y2aYa6R4YUyUsxaIM6Nb75Fi9cDn3lmrUuKHMyT50n3gNK2OS/OIZ9YYQTmUwzMxP7dyOkj2
 40EbJXiJtQ2eLCWXxQ7BqZIdQFadSVgXMuuwyGVH8baSjdb9KgaI6e56dscl0ZNxcy5Ss+gE
 qmBZ3Jl
IronPort-HdrOrdr: A9a23:/ZdQs6juOLFlGwpM6jE7g79l13BQXtwji2hC6mlwRA09TySZ//
 rAoB19726StN9xYgBYpTnuAsi9qB/nmKKdpLNhX4tKPzOW3FdATrsD0WKK+VSJcEfDH6xmpM
 JdmsBFebvN5DNB4/oSjjPVLz9Z+qjlzJyV
X-IronPort-AV: E=Sophos;i="5.90,136,1643691600"; 
   d="scan'208";a="64433057"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross
	<jgross@suse.com>, Wei Liu <wl@xen.org>
Subject: [XEN PATCH v2 19/29] libs/guest: rework CFLAGS
Date: Fri, 25 Feb 2022 15:13:11 +0000
Message-ID: <20220225151321.44126-20-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220225151321.44126-1-anthony.perard@citrix.com>
References: <20220225151321.44126-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

Remove '-Werror -Wmissing-progress -I./include $(CFLAGS_xeninclude)',
those flags are already added via "libs.mk".

Flag "-I." isn't needed, we just need to fix the #include of
"xg_core.h" as this header isn't expected to be installed.

Make use of "-iquote" instead of '-I' for double-quote included
headers.

Also, regroup the CFLAGS into the same place in the makefile.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
---

Notes:
    v2:
    - reviewed

 tools/libs/guest/Makefile          | 20 +++++++++-----------
 tools/libs/guest/xg_offline_page.c |  2 +-
 2 files changed, 10 insertions(+), 12 deletions(-)

diff --git a/tools/libs/guest/Makefile b/tools/libs/guest/Makefile
index 7707d4300f..4f2373101f 100644
--- a/tools/libs/guest/Makefile
+++ b/tools/libs/guest/Makefile
@@ -28,18 +28,13 @@ OBJS-y       += xg_core.o
 OBJS-$(CONFIG_X86) += xg_core_x86.o
 OBJS-$(CONFIG_ARM) += xg_core_arm.o
 
-CFLAGS += -I$(XEN_libxenctrl)
-
 vpath %.c ../../../xen/common/libelf
-CFLAGS += -I../../../xen/common/libelf
 
 LIBELF_OBJS += libelf-tools.o libelf-loader.o
 LIBELF_OBJS += libelf-dominfo.o
 
 OBJS-y += $(LIBELF_OBJS)
 
-$(LIBELF_OBJS) $(LIBELF_OBJS:.o=.opic): CFLAGS += -Wno-pointer-sign
-
 ifeq ($(CONFIG_X86),y) # Add libx86 to the build
 vpath %.c ../../../xen/lib/x86
 
@@ -70,10 +65,12 @@ OBJS-y                 += xg_dom_decompress_unsafe_xz.o
 OBJS-y                 += xg_dom_decompress_unsafe_zstd.o
 endif
 
-CFLAGS   += -Werror -Wmissing-prototypes
-CFLAGS   += -I. -I./include $(CFLAGS_xeninclude)
-CFLAGS   += -D__XEN_TOOLS__
-CFLAGS   += -include $(XEN_ROOT)/tools/config.h
+CFLAGS += -D__XEN_TOOLS__
+CFLAGS += -include $(XEN_ROOT)/tools/config.h
+CFLAGS += -iquote ../../../xen/common/libelf
+
+# To be able to include xc_private.h
+CFLAGS += -iquote $(XEN_libxenctrl)
 
 # Needed for posix_fadvise64() in xc_linux.c
 CFLAGS-$(CONFIG_Linux) += -D_GNU_SOURCE
@@ -92,8 +89,9 @@ ZLIB_CFLAGS :=
 ZLIB_LIBS :=
 endif
 
-xg_dom_bzimageloader.o: CFLAGS += $(ZLIB_CFLAGS)
-xg_dom_bzimageloader.opic: CFLAGS += $(ZLIB_CFLAGS)
+xg_dom_bzimageloader.o xg_dom_bzimageloader.opic: CFLAGS += $(ZLIB_CFLAGS)
+
+$(LIBELF_OBJS) $(LIBELF_OBJS:.o=.opic): CFLAGS += -Wno-pointer-sign
 
 LIBHEADER := xenguest.h
 
diff --git a/tools/libs/guest/xg_offline_page.c b/tools/libs/guest/xg_offline_page.c
index cfe0e2d537..c594fdba41 100644
--- a/tools/libs/guest/xg_offline_page.c
+++ b/tools/libs/guest/xg_offline_page.c
@@ -25,7 +25,7 @@
 #include <stdlib.h>
 #include <unistd.h>
 #include <sys/time.h>
-#include <xg_core.h>
+#include "xg_core.h"
 
 #include "xc_private.h"
 #include "xg_private.h"
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Fri Feb 25 15:16:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 15:16:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279290.477012 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcKt-0002B6-N9; Fri, 25 Feb 2022 15:16:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279290.477012; Fri, 25 Feb 2022 15:16:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcKt-00028j-4i; Fri, 25 Feb 2022 15:16:47 +0000
Received: by outflank-mailman (input) for mailman id 279290;
 Fri, 25 Feb 2022 15:16:43 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=E0Ll=TI=citrix.com=prvs=04808661d=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nNcIV-0006fy-S4
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 15:14:19 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 98a8c4b6-964d-11ec-8539-5f4723681683;
 Fri, 25 Feb 2022 16:14:16 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 98a8c4b6-964d-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645802056;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=3vyVdZEIG+4X/H2vZhQNrYK/eTmrh5e09O/takxxz8Q=;
  b=DJphRGFJ4yDCMBd+gcJQLTpHLXrTJaTLHWPKpv+yPEwPMxiVYmiLrKhT
   YQVIeY8QMZ2luy/87Bly72XIaqSXqxpt7BN6CIeHEHnq1qUNKnJHjpNQt
   KUSvs4IX8r2hRfWAY/UVzG4I82oxmRM6Aepj6qditrl0XM7Gvv2Xgyv10
   0=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 64998429
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:R+nmIqAPGP9/ehVW/xbjw5YqxClBgxIJ4kV8jS/XYbTApDInhTUCy
 TEYXjyCP/iIN2TyeNB/boW38UNV68fWm9NjQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHWeIdA970Ug5w7Rj39Yy6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhK1
 dxysYyLQzs7EfThp7QmFDBeAXFXaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguwqKtXrO4UO/Glt1zjDAd4tQIzZQrWM7thdtNs1rp4STKeOO
 5BIAdZpRCrgZz5TH3MvM6MRzNfx1yDVWTx4pWvA8MLb5ECMlVcsgdABKuH9YceWTM9YmkKZo
 GPu/GnjBBwectuFxlKt7XaEluLJ2yThV+o6FrKi8eVxqEaO3WFVAxoTPXOrrP/8hkOgVtZ3L
 00P5jFovaU07FasTNT2Q1u/unHslhwWVsdUEuY6wBqQ0aeS6AGcbkAGUzpAZdoOpMIwAzsw2
 Te0c8jBXGI19ufPEDTEq+nS/Wja1TUpwXEqXjINcg8V2NPfsq5qoy2fdZFKFrzlp4igcd3v+
 AyioC87jrQVqMcE0aSn4FzK6w6RSoj1oh0dvVuOAD/8hu9tTMv8PtHztwCHhRpVBNvBFjG8U
 G44d99yBQzkJbWEj2SzTeoEB9lFDN7VYWSH0TaD83TMnglBGkJPn6gMsVmSx28za67onAMFh
 meJ6Gu9A7cJYROXgVdfOd7ZNijT5fGI+S7Zfv7VdMFSRZN6aRWK+ipjDWbJgTywzxR1zfxnY
 c/DGSpJMZr8If42pNZRb71AuYLHOwhknT+DLXwF507PPUWiiI69Fu5ebQrmghER56KYugTFm
 +uzxOPRoyizpNbWO3GNmaZKdAhiBSFiWfje9pwGHsbec1EOMDxwVJfsLUYJJtUNc1J9zbyTo
 BlQmyZwlTLCuJEwAV7SOyA7Nei2Bs4XQLBSFXVEAGtEEkMLOe6HhJrzvbNtFVX73ISPFcJJc
 sQ=
IronPort-HdrOrdr: A9a23:TrvJb6mEGxZLBNc4akvo38aCA0LpDfIq3DAbv31ZSRFFG/Fxl6
 iV88jzsiWE7wr5OUtQ4OxoV5PgfZqxz/NICMwqTNWftWrdyQ+VxeNZjbcKqgeIc0aVygce79
 YET0EXMqyXMbEQt6jHCWeDf+rIuOP3k5yVuQ==
X-IronPort-AV: E=Sophos;i="5.90,136,1643691600"; 
   d="scan'208";a="64998429"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@citrix.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, "Jan
 Beulich" <jbeulich@suse.com>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Wei Liu <wl@xen.org>, Juergen Gross
	<jgross@suse.com>
Subject: [XEN PATCH v2 23/29] .gitignore: Cleanup ignores of tools/libs/*/{headers.chk,*.pc}
Date: Fri, 25 Feb 2022 15:13:15 +0000
Message-ID: <20220225151321.44126-24-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220225151321.44126-1-anthony.perard@citrix.com>
References: <20220225151321.44126-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---

Notes:
    v2:
    - move new .gitignore entries to the one in tools/libs/

 .gitignore            | 26 --------------------------
 tools/libs/.gitignore |  2 ++
 2 files changed, 2 insertions(+), 26 deletions(-)

diff --git a/.gitignore b/.gitignore
index 3da56594c5..7a04dc3a89 100644
--- a/.gitignore
+++ b/.gitignore
@@ -105,26 +105,8 @@ tools/config.cache
 config/Tools.mk
 config/Stubdom.mk
 config/Docs.mk
-tools/libs/toolcore/headers.chk
-tools/libs/toolcore/xentoolcore.pc
-tools/libs/toollog/headers.chk
-tools/libs/toollog/xentoollog.pc
-tools/libs/evtchn/headers.chk
-tools/libs/evtchn/xenevtchn.pc
-tools/libs/gnttab/headers.chk
-tools/libs/gnttab/xengnttab.pc
-tools/libs/hypfs/headers.chk
-tools/libs/hypfs/xenhypfs.pc
-tools/libs/call/headers.chk
-tools/libs/call/xencall.pc
 tools/libs/ctrl/libxenctrl.map
-tools/libs/ctrl/xencontrol.pc
-tools/libs/foreignmemory/headers.chk
-tools/libs/foreignmemory/xenforeignmemory.pc
-tools/libs/devicemodel/headers.chk
-tools/libs/devicemodel/xendevicemodel.pc
 tools/libs/guest/libxenguest.map
-tools/libs/guest/xenguest.pc
 tools/libs/guest/xc_bitops.h
 tools/libs/guest/xc_core.h
 tools/libs/guest/xc_core_arm.h
@@ -144,21 +126,13 @@ tools/libs/light/testidl.c
 tools/libs/light/test_timedereg
 tools/libs/light/test_fdderegrace
 tools/libs/light/tmp.*
-tools/libs/light/xenlight.pc
-tools/libs/stat/headers.chk
 tools/libs/stat/libxenstat.map
-tools/libs/stat/xenstat.pc
-tools/libs/store/headers.chk
 tools/libs/store/list.h
 tools/libs/store/utils.h
-tools/libs/store/xenstore.pc
 tools/libs/store/xs_lib.c
-tools/libs/util/*.pc
 tools/libs/util/libxlu_cfg_y.output
 tools/libs/util/libxenutil.map
-tools/libs/vchan/headers.chk
 tools/libs/vchan/libxenvchan.map
-tools/libs/vchan/xenvchan.pc
 tools/debugger/gdb/gdb-6.2.1-linux-i386-xen/*
 tools/debugger/gdb/gdb-6.2.1/*
 tools/debugger/gdb/gdb-6.2.1.tar.bz2
diff --git a/tools/libs/.gitignore b/tools/libs/.gitignore
index 4a13126144..1ad7c7f0cb 100644
--- a/tools/libs/.gitignore
+++ b/tools/libs/.gitignore
@@ -1 +1,3 @@
+*/*.pc
+*/headers.chk
 */headers.lst
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Fri Feb 25 15:16:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 15:16:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279292.477022 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcKu-0002MN-K8; Fri, 25 Feb 2022 15:16:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279292.477022; Fri, 25 Feb 2022 15:16:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcKt-0002GR-MQ; Fri, 25 Feb 2022 15:16:47 +0000
Received: by outflank-mailman (input) for mailman id 279292;
 Fri, 25 Feb 2022 15:16:44 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=E0Ll=TI=citrix.com=prvs=04808661d=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nNcIa-0007Bf-OF
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 15:14:24 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9cda7daa-964d-11ec-8eb9-a37418f5ba1a;
 Fri, 25 Feb 2022 16:14:23 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9cda7daa-964d-11ec-8eb9-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645802063;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=kixkpefhBRjANCwQ7euq99oUP/7Tc6+q09WVcxZqwx4=;
  b=R1tdvDVn14vuC39rem7NsgwufwPpQyQkPWoLASSZ9/1rUzjnEDjSG0dx
   7yqF4yhlirsoOcTM/fAmzdArvwY0/KuSQtzp0GKv6ZLVkPOXr0ZGoNtkj
   f0g5pUqGQaIqWc6+YUEX3bfuAunR3LMD7oIAYW9Zed+5sy6QkQOV0fUcq
   M=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 65000348
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:3iVG06DMRirSzhVW/yDjw5YqxClBgxIJ4kV8jS/XYbTApDMqg2AAn
 zMaC22EPv+CN2T3Lt9wa4q39hkAsJ+Hz99nQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHWeIdA970Ug5w7Rj39Yy6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhoj
 /5TmL3uFjwgZIncl+UkXwAFPgdHaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguwqKtXrO4UO/Glt1zjDAd4tQIzZQrWM7thdtNs1rp4TRa6GP
 JZJAdZpRBnhSEFDCg1INMsnubu3tF2iWjcfpU3A8MLb5ECMlVcsgdABKuH9ZdiiVchT2EGCq
 Qru5G38HxwecsCfyDCM73awruLJhmb/SYUUUrqi+ZZCkFCVg2AeFhASfV+6uuWizF6zXcpFL
 E4Z8TZoqrI9nHFHVfGkAUf++iTd+EdBBZwASIXW9T1h1ILNpC2HK0laEQVIMvg2u84PSSV3+
 3mwyoaB6SNUjJWZTneU97GxpDy0ODQIIWJqWRLoXTfp8PG4/tht00unosJLVffs04arQW2YL
 yWi8XBm74j/m/LnwElSEbrvpzu37qbEQQcujuk8djL0t1gpDGJJimHB1LQ60RqiBNrIJrVil
 CJd8yR70AzoJcvc/MBqaL9QdIxFH97fbFXhbadHRvHNDQiF9X+5Zpx36zpjPkpvOctsUWa3P
 BKM5VoNuccLZCPCgUpLj2SZUZVCIU/IT4mNaxwpRoAWPsgZmPGvpkmCmnJ8L0iyyRNxwMnTy
 L+QcNq2DGZyNEiU5GHeegvp6pdynnpW7TqKHfjTlk37uZLDNC/9YepUazOmM7FmhJ5oVS2Iq
 r6zwePRkE4BOAA/CwGKmbMuwacidiBqVcir8JUMLoZu4GNOQQkcNhMY+pt5E6QNokifvrygE
 q2VMqOA9GfCuA==
IronPort-HdrOrdr: A9a23:+l1Y0apOvw0CxQuxZb+GZqgaV5oTeYIsimQD101hICG8cqSj+f
 xG+85rsyMc6QxhIE3I9urhBEDtex/hHNtOkOws1NSZLW7bUQmTXeJfBOLZqlWKcUDDH6xmpM
 NdmsBFeaTN5DNB7PoSjjPWLz9Z+qjkzJyV
X-IronPort-AV: E=Sophos;i="5.90,136,1643691600"; 
   d="scan'208";a="65000348"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@citrix.com>, Samuel Thibault
	<samuel.thibault@ens-lyon.org>, Wei Liu <wl@xen.org>
Subject: [XEN PATCH v2 28/29] stubdom: xenlibs linkfarm, ignore non-regular files
Date: Fri, 25 Feb 2022 15:13:20 +0000
Message-ID: <20220225151321.44126-29-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220225151321.44126-1-anthony.perard@citrix.com>
References: <20220225151321.44126-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

When we will convert tools/ build system, their will be a need to
replace some use of "vpath". This will done making symbolic links.
Those symlinks are not wanted by stubdom build system when making a
linkfarm for the Xen libraries. To avoid them, we will use `find`
instead of plain shell globbing.

For example, there will be a link to "xen/lib/x86/cpuid.o" in
"tools/libs/guest/".

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
---

Notes:
    v2:
    - reviewed

 stubdom/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/stubdom/Makefile b/stubdom/Makefile
index 1fa075b9ad..b312f710cd 100644
--- a/stubdom/Makefile
+++ b/stubdom/Makefile
@@ -345,7 +345,7 @@ define do_links
   mkdir -p $(dir $@)include
   cd $(dir $@); \
   ln -sf $(dir $<)include/*.h include/; \
-  ln -sf $(dir $<)*.[ch] .; \
+  find $(dir $<) -maxdepth 1 -type f -name '*.[ch]' -exec ln -sf {} . \; ; \
   ln -sf $(dir $<)Makefile.common .
   touch $@
 endef
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Fri Feb 25 15:16:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 15:16:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279299.477028 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcKv-0002dE-E4; Fri, 25 Feb 2022 15:16:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279299.477028; Fri, 25 Feb 2022 15:16:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcKu-0002XG-RI; Fri, 25 Feb 2022 15:16:48 +0000
Received: by outflank-mailman (input) for mailman id 279299;
 Fri, 25 Feb 2022 15:16:46 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=E0Ll=TI=citrix.com=prvs=04808661d=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nNcIf-0007Bf-NL
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 15:14:29 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9e8be35f-964d-11ec-8eb9-a37418f5ba1a;
 Fri, 25 Feb 2022 16:14:27 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9e8be35f-964d-11ec-8eb9-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645802067;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=kVfi8O5fUs5vOwYORwAwSsIcv2wq/KeyJm02u0brLh8=;
  b=B13VtlZNDjEy4Lrb9Kncz0B4+D3s/zKtSIl04Sx2+vyytNnTwG81aSR3
   i+MH9Y8Tk3/7SUmkAfZpCoh3u32CBzDijK0NzepCPpKw2lqR7Dbqo50q5
   5cm0JDqcfdzS1mlTbY4LQpp4vcOcLAIYRoQjhlgLT2+YRktpLvx83auid
   k=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 64998443
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:42XmkqOCEpmHjzzvrR3fl8FynXyQoLVcMsEvi/4bfWQNrUor3zEHx
 mcbDD2CPv/eYGX2ed0naIm0oBlVsZfVmNZlSgto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFcMpBsJ00o5wbZj2NMw27BVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z0
 /t3t7GoaAkSIrzhnt8+fitID2ZYMvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALJc/3PIQZqzd4wCvQF/oOSpHfWaTao9Rf2V/cg+gQQaePN
 5ZFMlKDajzcURNWZQhQNa4sxvXvo0vwVAVJ72ua8P9fD2/7k1UqjemF3MDuUsOObdVYmACfv
 G2u12jwHBwyLtGUzjuBtHW2iYfnjS79HY4fCrC83vprm0GIgHweDgUMUlm2quX/jVSxM++zM
 GRNpHBo9/JrshX2EJ+tBHVUvUJooDYHdeBSPvUb5jqR24fS2CW0NHgYCRhOPYlOWNANeRQm0
 VqAntXMDDNpsaGIRX/1yop4vQ9eKgBOczZcOHZsoR8tpoC6/dpt1k6nosNLTfbt5uAZDw0c1
 NxjQMIWo7wIxfAG2Kyglbwsq2L9/8OZJuLZC+i+Y45E0u+bTNL0D2BLwQKChRqlEGp/ZgPQ1
 JTjs5LDhN3i9bnXyESwrBwlRdlFHcqtPjzGmkJIFJI87Tmr8HPLVdkOvGwheB41b55cIWeBj
 KrvVeV5vs470JyCN/IfXm5MI55ykfiI+SrNDJg4keaikrAuLVTarUmClGab3nz3kVhErE3ME
 czzTCpYNl5DUf4P5GPvH481iOZ3rghjlTK7bc2qlHyPjOvBDEN5vJ9YaTNimMhit/jayOgUm
 v4CX/a3J+J3C7WvMnGKqtdIdTjn7xETXPjLliCeTcbbSiIOJY3rI6K5LW8JE2C9o5loqw==
IronPort-HdrOrdr: A9a23:0gL9g6jOi35dwX2lbuVCiV4eEHBQXuIji2hC6mlwRA09TySZ//
 rBoB19726TtN9xYgBZpTnuAsm9qB/nmaKdpLNhWItKPzOW31dATrsSjrcKqgeIc0aVm9K1l5
 0QF5SWYOeAdGSS5vya3ODXKbkdKaG8gcKVuds=
X-IronPort-AV: E=Sophos;i="5.90,136,1643691600"; 
   d="scan'208";a="64998443"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@citrix.com>, Christian Lindig
	<christian.lindig@citrix.com>, David Scott <dave@recoil.org>, Wei Liu
	<wl@xen.org>
Subject: [XEN PATCH v2 29/29] tools/ocaml: fix build dependency target
Date: Fri, 25 Feb 2022 15:13:21 +0000
Message-ID: <20220225151321.44126-30-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220225151321.44126-1-anthony.perard@citrix.com>
References: <20220225151321.44126-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

They are two competiting spelling for the variable holding the path to
"tools/ocaml", $(TOPLEVEL) and $(OCAML_TOPLEVEL). The "Makefile.rules"
which is included in all ocaml Makefiles have one rule which make use
of that variable which is then sometime unset. When building
"ocaml/xenstored", make isn't capable of generating ".ocamldep.make"
because $(TOPLEVEL) isn't defined in this case.

This can fail with an error like this when paths.ml have been
regenerated:
    Error: Files define.cmx and paths.cmx
       make inconsistent assumptions over interface Paths

This patch fix ".ocamldep.make" rule by always spelling the variable
$(OCAML_TOPLEVEL).

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---

Notes:
    v2:
    - new patch

 tools/ocaml/libs/eventchn/Makefile   | 8 ++++----
 tools/ocaml/libs/mmap/Makefile       | 8 ++++----
 tools/ocaml/libs/xb/Makefile         | 8 ++++----
 tools/ocaml/libs/xc/Makefile         | 8 ++++----
 tools/ocaml/libs/xentoollog/Makefile | 8 ++++----
 tools/ocaml/libs/xl/Makefile         | 8 ++++----
 tools/ocaml/libs/xs/Makefile         | 8 ++++----
 tools/ocaml/Makefile.rules           | 2 +-
 8 files changed, 29 insertions(+), 29 deletions(-)

diff --git a/tools/ocaml/libs/eventchn/Makefile b/tools/ocaml/libs/eventchn/Makefile
index 154efd4a8e..7362a28d9e 100644
--- a/tools/ocaml/libs/eventchn/Makefile
+++ b/tools/ocaml/libs/eventchn/Makefile
@@ -1,6 +1,6 @@
-TOPLEVEL=$(CURDIR)/../..
-XEN_ROOT=$(TOPLEVEL)/../..
-include $(TOPLEVEL)/common.make
+OCAML_TOPLEVEL=$(CURDIR)/../..
+XEN_ROOT=$(OCAML_TOPLEVEL)/../..
+include $(OCAML_TOPLEVEL)/common.make
 
 CFLAGS += $(CFLAGS_libxenevtchn) $(CFLAGS_xeninclude)
 
@@ -31,5 +31,5 @@ install: $(LIBS) META
 uninstall:
 	$(OCAMLFIND) remove -destdir $(OCAMLDESTDIR) xeneventchn
 
-include $(TOPLEVEL)/Makefile.rules
+include $(OCAML_TOPLEVEL)/Makefile.rules
 
diff --git a/tools/ocaml/libs/mmap/Makefile b/tools/ocaml/libs/mmap/Makefile
index df45819df5..a621537135 100644
--- a/tools/ocaml/libs/mmap/Makefile
+++ b/tools/ocaml/libs/mmap/Makefile
@@ -1,6 +1,6 @@
-TOPLEVEL=$(CURDIR)/../..
-XEN_ROOT=$(TOPLEVEL)/../..
-include $(TOPLEVEL)/common.make
+OCAML_TOPLEVEL=$(CURDIR)/../..
+XEN_ROOT=$(OCAML_TOPLEVEL)/../..
+include $(OCAML_TOPLEVEL)/common.make
 
 OBJS = xenmmap
 INTF = $(foreach obj, $(OBJS),$(obj).cmi)
@@ -26,5 +26,5 @@ install: $(LIBS) META
 uninstall:
 	$(OCAMLFIND) remove -destdir $(OCAMLDESTDIR) xenmmap
 
-include $(TOPLEVEL)/Makefile.rules
+include $(OCAML_TOPLEVEL)/Makefile.rules
 
diff --git a/tools/ocaml/libs/xb/Makefile b/tools/ocaml/libs/xb/Makefile
index be4499147e..ff4428af6d 100644
--- a/tools/ocaml/libs/xb/Makefile
+++ b/tools/ocaml/libs/xb/Makefile
@@ -1,6 +1,6 @@
-TOPLEVEL=$(CURDIR)/../..
-XEN_ROOT=$(TOPLEVEL)/../..
-include $(TOPLEVEL)/common.make
+OCAML_TOPLEVEL=$(CURDIR)/../..
+XEN_ROOT=$(OCAML_TOPLEVEL)/../..
+include $(OCAML_TOPLEVEL)/common.make
 
 CFLAGS += -I../mmap
 CFLAGS += $(CFLAGS_libxenctrl) # For xen_mb()
@@ -49,4 +49,4 @@ install: $(LIBS) META
 uninstall:
 	$(OCAMLFIND) remove -destdir $(OCAMLDESTDIR) xenbus
 
-include $(TOPLEVEL)/Makefile.rules
+include $(OCAML_TOPLEVEL)/Makefile.rules
diff --git a/tools/ocaml/libs/xc/Makefile b/tools/ocaml/libs/xc/Makefile
index b6da4fdbaf..67acc46bee 100644
--- a/tools/ocaml/libs/xc/Makefile
+++ b/tools/ocaml/libs/xc/Makefile
@@ -1,6 +1,6 @@
-TOPLEVEL=$(CURDIR)/../..
-XEN_ROOT=$(TOPLEVEL)/../..
-include $(TOPLEVEL)/common.make
+OCAML_TOPLEVEL=$(CURDIR)/../..
+XEN_ROOT=$(OCAML_TOPLEVEL)/../..
+include $(OCAML_TOPLEVEL)/common.make
 
 CFLAGS += -I../mmap $(CFLAGS_libxenctrl) $(CFLAGS_libxenguest)
 CFLAGS += $(APPEND_CFLAGS)
@@ -38,4 +38,4 @@ xenctrl_abi_check.h: abi-check xenctrl_stubs.c xenctrl.ml
 
 GENERATED_FILES += xenctrl_abi_check.h
 
-include $(TOPLEVEL)/Makefile.rules
+include $(OCAML_TOPLEVEL)/Makefile.rules
diff --git a/tools/ocaml/libs/xentoollog/Makefile b/tools/ocaml/libs/xentoollog/Makefile
index 593f9e9e9d..9ede2fd124 100644
--- a/tools/ocaml/libs/xentoollog/Makefile
+++ b/tools/ocaml/libs/xentoollog/Makefile
@@ -1,6 +1,6 @@
-TOPLEVEL=$(CURDIR)/../..
-XEN_ROOT=$(TOPLEVEL)/../..
-include $(TOPLEVEL)/common.make
+OCAML_TOPLEVEL=$(CURDIR)/../..
+XEN_ROOT=$(OCAML_TOPLEVEL)/../..
+include $(OCAML_TOPLEVEL)/common.make
 
 # allow mixed declarations and code
 CFLAGS += -Wno-declaration-after-statement
@@ -62,4 +62,4 @@ install: $(LIBS) META
 uninstall:
 	ocamlfind remove -destdir $(OCAMLDESTDIR) xentoollog
 
-include $(TOPLEVEL)/Makefile.rules
+include $(OCAML_TOPLEVEL)/Makefile.rules
diff --git a/tools/ocaml/libs/xl/Makefile b/tools/ocaml/libs/xl/Makefile
index cbe1569cc5..7c1c4edced 100644
--- a/tools/ocaml/libs/xl/Makefile
+++ b/tools/ocaml/libs/xl/Makefile
@@ -1,6 +1,6 @@
-TOPLEVEL=$(CURDIR)/../..
-XEN_ROOT=$(TOPLEVEL)/../..
-include $(TOPLEVEL)/common.make
+OCAML_TOPLEVEL=$(CURDIR)/../..
+XEN_ROOT=$(OCAML_TOPLEVEL)/../..
+include $(OCAML_TOPLEVEL)/common.make
 
 # ignore unused generated functions and allow mixed declarations and code
 CFLAGS += -Wno-unused -Wno-declaration-after-statement
@@ -68,4 +68,4 @@ install: $(LIBS) META
 uninstall:
 	$(OCAMLFIND) remove -destdir $(OCAMLDESTDIR) xenlight
 
-include $(TOPLEVEL)/Makefile.rules
+include $(OCAML_TOPLEVEL)/Makefile.rules
diff --git a/tools/ocaml/libs/xs/Makefile b/tools/ocaml/libs/xs/Makefile
index 572efb76c4..e934bbb550 100644
--- a/tools/ocaml/libs/xs/Makefile
+++ b/tools/ocaml/libs/xs/Makefile
@@ -1,6 +1,6 @@
-TOPLEVEL=$(CURDIR)/../..
-XEN_ROOT=$(TOPLEVEL)/../..
-include $(TOPLEVEL)/common.make
+OCAML_TOPLEVEL=$(CURDIR)/../..
+XEN_ROOT=$(OCAML_TOPLEVEL)/../..
+include $(OCAML_TOPLEVEL)/common.make
 
 OCAMLINCLUDE += -I ../xb/
 OCAMLOPTFLAGS += -for-pack Xenstore
@@ -43,7 +43,7 @@ install: $(LIBS) META
 uninstall:
 	$(OCAMLFIND) remove -destdir $(OCAMLDESTDIR) xenstore
 
-include $(TOPLEVEL)/Makefile.rules
+include $(OCAML_TOPLEVEL)/Makefile.rules
 
 genpath-target = $(call buildmakevars2module,paths.ml)
 $(eval $(genpath-target))
diff --git a/tools/ocaml/Makefile.rules b/tools/ocaml/Makefile.rules
index abfbc64ce0..7e4db457a1 100644
--- a/tools/ocaml/Makefile.rules
+++ b/tools/ocaml/Makefile.rules
@@ -44,7 +44,7 @@ META: META.in
 
 ALL_OCAML_OBJ_SOURCES=$(addsuffix .ml, $(ALL_OCAML_OBJS))
 
-.ocamldep.make: $(ALL_OCAML_OBJ_SOURCES) Makefile $(TOPLEVEL)/Makefile.rules
+.ocamldep.make: $(ALL_OCAML_OBJ_SOURCES) Makefile $(OCAML_TOPLEVEL)/Makefile.rules
 	$(call quiet-command, $(OCAMLDEP) $(ALL_OCAML_OBJ_SOURCES) *.mli $o,MLDEP,)
 
 clean: $(CLEAN_HOOKS)
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Fri Feb 25 15:16:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 15:16:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279304.477058 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcKz-0003hz-8f; Fri, 25 Feb 2022 15:16:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279304.477058; Fri, 25 Feb 2022 15:16:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcKy-0003er-PS; Fri, 25 Feb 2022 15:16:52 +0000
Received: by outflank-mailman (input) for mailman id 279304;
 Fri, 25 Feb 2022 15:16:50 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=E0Ll=TI=citrix.com=prvs=04808661d=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nNcI9-0007Bf-TA
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 15:13:58 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8cf1125a-964d-11ec-8eb9-a37418f5ba1a;
 Fri, 25 Feb 2022 16:13:56 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8cf1125a-964d-11ec-8eb9-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645802036;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=DRUZBzwipLHVi3LrT/VXUcevANDycChtXk37Vv5NYiY=;
  b=N1/SCWTsIS83qYO6zuT4boiHmdXlCLJ4oqRlBFDVj8gCQqHqNf3OHkss
   6F6f//40Xiwsqek4hQC1plEPJ4/h7KCPxHOuq+hEJN/qI8lcyHckQTS2Q
   hfqS9i5x2pPswd9mxspzmRcaolCiwt5T4XjU8tiPND4ENfOkgsZhKlRRp
   8=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 64890255
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:gHA4S6NzNahL3zPvrR3Ol8FynXyQoLVcMsEvi/4bfWQNrUp20jJSn
 WsbUTiGO6mIMGP3KttzPY609kIEvJPUm4UxGQto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFcMpBsJ00o5wbZj2NMw27BVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zw
 fZNnIC3WVYSF4r8setMbBZkTS9RMvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALJc/3PIQZqzd4wCvQF/oOSpHfWaTao9Rf2V/cg+gQQaaPP
 5BENFKDajz9PSNkeWUbKa4Fu7+qqCTWKWMFpV6a8P9fD2/7k1UqjemF3MDuUsOObdVYmACfv
 G2u13T0BFQWOcKSzRKB82mwnanfkCXjQoUQGbaksPlwjzWuKnc7UUNMEwHh+L/g1xD4C4k3x
 1EoFjQGpIsy3VCsXojGdjqIiXHVgREgBdR/HLhvgO2S8Zb87wGcD2kCazdObt06qcM7LQAXO
 k+1c8DBXmI27uDMIZ6J3vLN9G7pZ3BJRYMXTXJcFWM4D8/fTJbfZ/4lZvJqC+aLg9L8AlkcK
 Bja/XFl193/YSPmvphXHGwrYRrw9/AlrSZvv207u15JCCsjNeZJgKTytDDmAQ5odtrxc7V4l
 CFsdzKixO4PF4qRsyeGXf8AGrqkj97cbmGB3gI2Q8R5r2z1k5JGQWy2yGsvTKuOGpxZEQIFn
 WeJ4V8BjHOtFCHCgVBLj3KZVJ1xkPmI+SXNXfHIdNteCqWdhyfclByCkXW4hji3+GB1yPlXE
 c7CLa6EUCZLYYw6nWHeb7pMjtcWKtUWmDq7qWbTlE/8j9JzpRe9FN84Dbd5RrthvfPc/V6Mq
 I432gnj40w3bdASqxL/qeY7RW3m51BibXwqg6S7rtK+Hzc=
IronPort-HdrOrdr: A9a23:+qM2u6BQamjKN2TlHemU55DYdb4zR+YMi2TC1yhKJyC9Ffbo8f
 xG/c5rrSMc5wxwZJhNo7y90ey7MBbhHP1OkO4s1NWZLWrbUQKTRekIh+bfKn/baknDH4ZmpN
 5dmsNFaeEYY2IUsS+D2njbL+od
X-IronPort-AV: E=Sophos;i="5.90,136,1643691600"; 
   d="scan'208";a="64890255"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Wei Liu <wl@xen.org>
Subject: [XEN PATCH v2 13/29] tools/xentrace: rework Makefile
Date: Fri, 25 Feb 2022 15:13:05 +0000
Message-ID: <20220225151321.44126-14-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220225151321.44126-1-anthony.perard@citrix.com>
References: <20220225151321.44126-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

Remove "build" targets.

Use "$(TARGETS)" to list binary to be built.

Cleanup "clean" rule.

Also drop conditional install of $(BIN) and $(LIBBIN) as those two
variables are now always populated.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---

Notes:
    v2:
    - fix typo in title
    - drop conditional install of $(BIN) and $(LIBBIN)

 tools/xentrace/Makefile | 19 +++++++------------
 1 file changed, 7 insertions(+), 12 deletions(-)

diff --git a/tools/xentrace/Makefile b/tools/xentrace/Makefile
index 9fb7fc96e7..0995fa9203 100644
--- a/tools/xentrace/Makefile
+++ b/tools/xentrace/Makefile
@@ -14,36 +14,31 @@ SBIN     = xentrace xentrace_setsize
 LIBBIN   = xenctx
 SCRIPTS  = xentrace_format
 
-.PHONY: all
-all: build
+TARGETS := $(BIN) $(SBIN) $(LIBBIN)
 
-.PHONY: build
-build: $(BIN) $(SBIN) $(LIBBIN)
+.PHONY: all
+all: $(TARGETS)
 
 .PHONY: install
-install: build
+install: all
 	$(INSTALL_DIR) $(DESTDIR)$(bindir)
 	$(INSTALL_DIR) $(DESTDIR)$(sbindir)
-	[ -z "$(LIBBIN)" ] || $(INSTALL_DIR) $(DESTDIR)$(LIBEXEC_BIN)
-ifneq ($(BIN),)
+	$(INSTALL_DIR) $(DESTDIR)$(LIBEXEC_BIN)
 	$(INSTALL_PROG) $(BIN) $(DESTDIR)$(bindir)
-endif
 	$(INSTALL_PROG) $(SBIN) $(DESTDIR)$(sbindir)
 	$(INSTALL_PYTHON_PROG) $(SCRIPTS) $(DESTDIR)$(bindir)
-	[ -z "$(LIBBIN)" ] || $(INSTALL_PROG) $(LIBBIN) $(DESTDIR)$(LIBEXEC_BIN)
+	$(INSTALL_PROG) $(LIBBIN) $(DESTDIR)$(LIBEXEC_BIN)
 
 .PHONY: uninstall
 uninstall:
 	rm -f $(addprefix $(DESTDIR)$(LIBEXEC_BIN)/, $(LIBBIN))
 	rm -f $(addprefix $(DESTDIR)$(bindir)/, $(SCRIPTS))
 	rm -f $(addprefix $(DESTDIR)$(sbindir)/, $(SBIN))
-ifneq ($(BIN),)
 	rm -f $(addprefix $(DESTDIR)$(bindir)/, $(BIN))
-endif
 
 .PHONY: clean
 clean:
-	$(RM) *.a *.so *.o *.rpm $(BIN) $(SBIN) $(LIBBIN) $(DEPS_RM)
+	$(RM) *.o $(TARGETS) $(DEPS_RM)
 
 .PHONY: distclean
 distclean: clean
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Fri Feb 25 15:16:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 15:16:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279305.477066 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcL0-0003tv-Kh; Fri, 25 Feb 2022 15:16:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279305.477066; Fri, 25 Feb 2022 15:16:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcKz-0003q4-QY; Fri, 25 Feb 2022 15:16:53 +0000
Received: by outflank-mailman (input) for mailman id 279305;
 Fri, 25 Feb 2022 15:16:51 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=E0Ll=TI=citrix.com=prvs=04808661d=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nNcIM-0007Bf-Qc
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 15:14:10 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 935c9a50-964d-11ec-8eb9-a37418f5ba1a;
 Fri, 25 Feb 2022 16:14:07 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 935c9a50-964d-11ec-8eb9-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645802047;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=+VKqQ9Ban5DJzksG49npHQWFkvG/L4HTbI6R5Xjk91w=;
  b=iPDDwPFn3wbQgYeYWuWznLlzn0mwqcxXKNpXICeCeTcZbik1UUduZ6hQ
   WMmmsJLhNUe7mmW0HwNfX2B3pYlnLA8DpYvzPgJ3R6POxsnCTu4lb07Q1
   RQr102rGZeZTA+GzznVbIbCmCXMKHhC+enQrW9WRiVhhMXK7uRCt7wWGd
   A=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 65407580
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:LM/w6qOgkd8+srrvrR3fl8FynXyQoLVcMsEvi/4bfWQNrUpw0GMAz
 DFKWGGFO/qJN2T9ctEiO4rjpEgP7Z/dn9VmHAto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFcMpBsJ00o5wbZj2NMw27BVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z5
 vpRip+0ZBoVMfPGt+QhWQdYT38uFPgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALJc/3PIQZqzd4wCvQF/oOSpHfWaTao9Rf2V/cg+gQQKqGO
 JdJMVKDajyaaCRUFUwKFqgBjdeSilnUTgdBi1ia8P9fD2/7k1UqjemF3MDuUsOObdVYmACfv
 G2u12b2GBYBL/SE1CGItHmrg4fnjS79HY4fCrC83vprm0GIgHweDgUMUlm2quX/jVSxM++zM
 GRNpHBo9/JrshX2EJ+tBHVUvUJooDYydMZvEOkX9T2ClKD74zqTGGhYEG5oPYlOWNANeRQm0
 VqAntXMDDNpsaGIRX/1yop4vQ9eKgBOczZcOHZsoR8tpoC6/dpt1k6nosNLTfbt5uAZDw0c1
 NxjQMIWo7wIxfAG2Kyglbwsq2L9/8OZJuLZC+i+Y45E0u+bTNL0D2BLwQKChRqlEGp/ZgPQ1
 JTjs5LDhN3i9bnXyESwrBwlRdlFHcqtPjzGmkJIFJI87Tmr8HPLVdkOvGwheB41b55cIWeBj
 KrvVeV5vs470JyCN/IfXm5MI55ykfiI+SrNDJg4keaikrAuLVTarUmClGab3nz3kVhErE3ME
 czzTCpYNl5DUf4P5GPvH481iOZ3rghjlTK7bc2qlHyPjOvBDEN5vJ9YaTNimMhit/jayOgUm
 v4CX/a3J+J3C7WvMnGKqtdIdTjn7xETXPjLliCeTcbbSiIOJY3rI6W5LW8JE2C9o5loqw==
IronPort-HdrOrdr: A9a23:x3xGZayhnHQSaCmhimyDKrPwFL1zdoMgy1knxilNoRw8SKKlfq
 eV7ZImPH7P+U4ssR4b+exoVJPtfZqYz+8R3WBzB8bEYOCFghrKEGgK1+KLqFeMJ8S9zJ846U
 4JSdkGNDSaNzlHZKjBjzVQa+xQouW6zA==
X-IronPort-AV: E=Sophos;i="5.90,136,1643691600"; 
   d="scan'208";a="65407580"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross
	<jgross@suse.com>, Wei Liu <wl@xen.org>
Subject: [XEN PATCH v2 18/29] libs/guest: rename ELF_OBJS to LIBELF_OBJS
Date: Fri, 25 Feb 2022 15:13:10 +0000
Message-ID: <20220225151321.44126-19-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220225151321.44126-1-anthony.perard@citrix.com>
References: <20220225151321.44126-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

It seems a better name. Later, we will introduce LIBX86_OBJS to
collect lib/x86/* objects.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
---

Notes:
    v2:
    - fix typo in patch description
    - reviewed

 tools/libs/guest/Makefile | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/tools/libs/guest/Makefile b/tools/libs/guest/Makefile
index 17eb0ebf4b..7707d4300f 100644
--- a/tools/libs/guest/Makefile
+++ b/tools/libs/guest/Makefile
@@ -33,13 +33,12 @@ CFLAGS += -I$(XEN_libxenctrl)
 vpath %.c ../../../xen/common/libelf
 CFLAGS += -I../../../xen/common/libelf
 
-ELF_OBJS-y += libelf-tools.o libelf-loader.o
-ELF_OBJS-y += libelf-dominfo.o
+LIBELF_OBJS += libelf-tools.o libelf-loader.o
+LIBELF_OBJS += libelf-dominfo.o
 
-OBJS-y += $(ELF_OBJS-y)
+OBJS-y += $(LIBELF_OBJS)
 
-$(ELF_OBJS-y): CFLAGS += -Wno-pointer-sign
-$(ELF_OBJS-y:.o=.opic): CFLAGS += -Wno-pointer-sign
+$(LIBELF_OBJS) $(LIBELF_OBJS:.o=.opic): CFLAGS += -Wno-pointer-sign
 
 ifeq ($(CONFIG_X86),y) # Add libx86 to the build
 vpath %.c ../../../xen/lib/x86
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Fri Feb 25 15:19:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 15:19:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279378.477086 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcNu-0007uI-23; Fri, 25 Feb 2022 15:19:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279378.477086; Fri, 25 Feb 2022 15:19:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcNt-0007uB-Uy; Fri, 25 Feb 2022 15:19:53 +0000
Received: by outflank-mailman (input) for mailman id 279378;
 Fri, 25 Feb 2022 15:19:52 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Zfiy=TI=citrix.com=prvs=0484f4aa7=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nNcNs-0007u5-AJ
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 15:19:52 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5f1f5a33-964e-11ec-8eb9-a37418f5ba1a;
 Fri, 25 Feb 2022 16:19:50 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5f1f5a33-964e-11ec-8eb9-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645802390;
  h=from:to:cc:subject:date:message-id:
   content-transfer-encoding:mime-version;
  bh=ZHAFFtgdwJyMnejfvYqugN7Durmt4Go3z7wTrKNqX80=;
  b=AVc6g0BVZaMXFdgFJVudDDS642LqtYWAGX838i/QFeD79rtFscTUPFt2
   EAXi6+3k3UmsOMe1tFUydItsE906ponjDkn9R6Q6STywzitscPJWzSmAI
   OHi56RNPQ5gt+YvQFTBfhy4ACQF/QYHMIjTy85lEC0QIzcE4npaR1GXbl
   M=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 67265528
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:E2USHavaYo9YgLzQNCeDMwN1MufnVGheMUV32f8akzHdYApBsoF/q
 tZmKWqBbPeDN2Kmcoh+OYizoRkO75Tdn9IyGlRlriA8Ri4V+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQyw4bVvqYy2YLjW1nX5
 IuoyyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb
 /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo
 Oihu6BcRi8OeZzekqcfVyNdHn05MYNPpZHnLmOw5Jn7I03uKxMAwt1rBUAye4YZ5vx2ESdF8
 vlwxDIlN07ZwbjsmfTiF7cq1p9LwMrDZevzvll6yj7UF7A+SI3rSKTW/95Imjw3g6iiGN6AO
 JBHNGc1PHwsZTViCnUrC5Nlld2qlyfdaWBpkWqSv7M4tj27IAtZj+G2bYu9lsaxbd5Ogk+Sq
 2bC/mL4KhIXLtqSzXyC6H3ErvDLtTP2XsQVDrLQ3vx3hFyewEQDBRtQUkG0ydGph0j7V99BJ
 kg8/is1sbN05EGtVsP6XRCzvDiDpBF0c9haHvA+6QqN4rHJ+AvfDW8BJgOtc/R/6pVwH2Zzk
 AbUwZW5XlSDrYF5V1q6sYaGp3CwPRIQIDNFaQENECUl7MLs9dRbYg30cv5vF6u8j9vQED72w
 iyXoCVWu4j/nfLnxI3gowmZ3mvESozhC1dsu16JBj7NAhZROdb9D7FE/2Q3+hqpwGyxalCa9
 EYJlMGFhAzlJcHczXfdKAnh8VzA2hpkDNE+qQI+d3XC3270k5JGQWy2yGsvTKuOGpxZEQIFm
 GeJ5WtsCGZ7ZRNGl5NfbYOrENgNxqP9D9njXf28RoMQPsUuKFbboXk2PRb4M4XRfK4Ey/BX1
 XCzK5vEMJrnIf4/kGreqxk1i9fHORzSNUuMHMumnnxLIJKVZWKPSKdtDbd9RrtR0U9wmy2Mq
 4w3H5LTk313CbSiCgGKod97BQ1bdhATWMGpw/G7g8bee2KK7kl6UKSPqV7gEqQ495loehDgp
 SnsChcFkwOk3RUq62yiMxheVV8mZr4mxVoTNi0wJ1e4nX8lZIek9qAEcJUrO7Ig8YReITRcF
 ZHpp+3o7ixzdwn6
IronPort-HdrOrdr: A9a23:lgXHiqn6GXfwQaKFd1odFZaTE4jpDfIq3DAbv31ZSRFFG/Fxl6
 iV88jzsiWE7wr5OUtQ4OxoV5PgfZqxz/NICMwqTNWftWrdyQ+VxeNZjbcKqgeIc0aVygce79
 YET0EXMqyXMbEQt6jHCWeDf+rIuOP3k5yVuQ==
X-IronPort-AV: E=Sophos;i="5.90,136,1643691600"; 
   d="scan'208";a="67265528"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=N0r9J01DOLhTju/fn3od5+/pAjveP86w2ABeJ3iecqIGlD86WPDO5itYOg5J/duw+u7+AnbVzpRPASjEwRaPbfJc+catsikbVhCd2+NlbOJPg2yCVg1iTTruge3xfXAUy2tKhljOVDj/TFmRyiDlnD1pectD7eOp8tmmrsVRCzxjN6vxf4F8GcJ6oclsFg1x5iD2SUITpozdMGNDg+rSqn+qx7M+LCmAN3gMid9yE8OOhfd4ijeQ2jj31vakBGi/FW74kqFET2vr/9a6PGucRuRjGyMuXfoxbnaVOgKC3oQ1ygEu2blaW70vMFcHukvlZQ0uFyu8ONSDUpuZjXtAwA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=KL1Y0yuM0Lq869715xLMo+zCsvaKf811cVwl6HDo0Vs=;
 b=PA8Idk5+l+4beQerYdpdpW48NcNcfCvmLpBfkquUUx6cCzxQ1fjqgaZ7xe4le5zGbt7nzPj0ScZ4Oz713QqWsGibz6Ja+7WX80gPbB1cYj6BKCqoHVBT/sZV7zqRolpMRl6z28nu3uUifTXfnxKz4Q4QrTMSNy/glLa3DDxOp+U4pjY+PK+21dMhb/+CXVkQXkm2tHPnMXHMkgIwdxFWaYZUeY55GBGdHrql4nH6H93qUBX6oYs9gXodF+1pxhot96KOECstts4HduQF2HK3v+Cgl6rF7S2TySzQZbg8TSLzzUeYHAbzaUBaTLIOztoP3SIGREs/dj5d+RDE84HCog==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=KL1Y0yuM0Lq869715xLMo+zCsvaKf811cVwl6HDo0Vs=;
 b=BmMLzKX0vYy6J+gZxC8tY6y3/1SrTXrUGfn1Hf7H4fWuywd2Szk+elV8F1dnVdSQvfn6Xdyk0SHIA0xcB8emDxVPh23T8oKJOzyxeMdXdMJOZ56tdMcJEFuuV8KTwzBfKzU6K+Qsn1Z2vKehmpZg9hxLuJpFTJ9Ir3W6BkmMrCQ=
From: Roger Pau Monne <roger.pau@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Roger Pau Monne <roger.pau@citrix.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, Jan
 Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>, Stefano
 Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Subject: [PATCH 0/2] codeql: add support for Xen and tools
Date: Fri, 25 Feb 2022 16:19:29 +0100
Message-ID: <20220225151931.99848-1-roger.pau@citrix.com>
X-Mailer: git-send-email 2.34.1
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO2P265CA0071.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:60::35) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ca53773a-41ce-470f-2a0c-08d9f87241b7
X-MS-TrafficTypeDiagnostic: CY4PR03MB3063:EE_
X-Microsoft-Antispam-PRVS: <CY4PR03MB30637615CCA2E989C94083588F3E9@CY4PR03MB3063.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: NJqQ5ziI/gS5aTQYMo5B8SBmcLaMh5WDDfFQ55QN4y027uuFvN2prmLUhO/vleMgk76zbN2c9k76Gd3bMzMbsbq/vTGj0wn0Be1adjCi4GhjYPjpdhvInI74xaEwDoJx0ha5r6TRqcG6mz/0xhqRpEUXoiJCzzz3QTh1rE+AVKxdF1kIcmGbWT/Dr1reqXkfJ5styV3+y9+myhXnhW8O6QLHxDSDQoylyLMLX2KaznZ20xuqVW5ggel76C+9VKgxGFHZb20CX8AlprDIL52E0YsP85gUdJW8lfFvWS0G7GNAES0M6DFhSVq6kcKhpMwPxFGiZLC0HcXm9JetjpWtzPaFWnrgl5MCcvAIfFcxz6fDPlVS8nCEbw1gB69CQHLnCnQWuAt/VuhRVb8a6FQiZkKANuzui+pA5Q2VP9SWNhNvESrxbNxodyYIyxZuXGjWLm6OCBH7YBvtmpXIvJqGZSKoQb8euvbx0sTEzB9x5CZ5ckzf7MLfxnhkrpD9G5uK+jE54W5bzvhC4s0NNpgJ6Ul1EP3yAr16w7yO7VYakPUkwaDSzcWlV8s4kQfTqXjx8hnwspsFLi3UqvZZdMhJ1/7+9yCdKEJ9Jj+NdHJ3LeLDJXuAiFMioPJ011bGcJYBKeW6TAgCXlAytbjsxGEjWQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66556008)(6512007)(6486002)(26005)(8676002)(66476007)(5660300002)(6666004)(4326008)(6506007)(6916009)(316002)(66946007)(86362001)(54906003)(83380400001)(186003)(1076003)(2616005)(82960400001)(4744005)(36756003)(38100700002)(2906002)(508600001)(8936002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ajhvYyt3MHFkV09HVCtnZW9wYXV6UFhJOFZWUm5JbEZ0TlFGZmlqaFc4WUxZ?=
 =?utf-8?B?L2dRWWpoT1hOOUtSNitYcU9pd0Z2ZXhjaGZkKzcrMHJOVWExZFQzUmh1d1V3?=
 =?utf-8?B?ZWlQdU1rSEN5VnowQWM2RFdHQ1ZuS3NCV0t5RythTTl1THBicWM1eHUwZ0xZ?=
 =?utf-8?B?MzJ2RkJtcGV6eDJIOFE4YzVHOWF4Z3VlUVI4aHBlUzd2azV6N2E0QUJnd0hJ?=
 =?utf-8?B?SFZ1K2dBR2dNYkFoMTBMaDFWMnpkTEFpaHlwUmVXdXNWL2diaUJ1WlplZGU2?=
 =?utf-8?B?aW94eDBCelpGL0VtMGpBVGUyUFhrdi9HdTJMZlhwZTlpVzcrWHVGSDZaZ2dm?=
 =?utf-8?B?ZU0veTZrUVJIVmNkUCtzR0UxRmptZmcvbnFlSXpja3U0N1NGbTdkdDg1NXVl?=
 =?utf-8?B?RXViY1UxRjJ1S1VsazJSRmo3ZFNIUnpIQzVqYXQvRjV2Skt2T1QvVk10Ujcz?=
 =?utf-8?B?cGxCOGdIdDBHN0IzSEQ4MFVycmxIdThDRGlLQW03b0JjeWRCUmROV3hIQ01Q?=
 =?utf-8?B?LzVjOWpISG1EQng4WUNsR1JHOVlLaHVjOFJOM0laVE1UUWk4UE12TEtNOHJ0?=
 =?utf-8?B?d1ZMTEdQVitDMXJvbGdzK09DcHlvUVB3QmsvUlYya3NnRXpJVW4xQmcyYXdD?=
 =?utf-8?B?WWpnK1VkblFXNkZEZkMxaWo5WW44THJmYnhlcGcrMTlaZlBtMDRkSlFNTkZo?=
 =?utf-8?B?KzlPOENFQ0lRVldmcmVpRzRpbUNKUEZxRlVyYVFYaWFneVRwY2V0TUdCWGRU?=
 =?utf-8?B?YXNRSTI2WkFXUHBqaDJNSnI5YjhTcFBXTkJxM3BaS0Vva0VISFAwM1o5YzEy?=
 =?utf-8?B?OHhMMnFVb25QZjllMWlTdXE2dWJUZkJiMmdmSGRqUDdPZVEyQ3h6VVVzdG1s?=
 =?utf-8?B?LzBjeUJ1WEJWaTdlLzZXNXJwbGxnMzNFT0txTGdVdmZWZWRGNEo1eUxhcGdl?=
 =?utf-8?B?K0pnWFlHN2ZGZkhCNkFadlZIeWxqZDkvcklCajl6MC9vc0V3djk5d1VCcEhY?=
 =?utf-8?B?OWxiRDVoVS90UW9qeW1vOFVBWkgvNUJsSU0xWGs0M2M5dm13UW1nRlQrUVFB?=
 =?utf-8?B?WElLTUlJTU9xWHFaREF3ZHo4dVdlLytHV2ZZL05udHAxNVNMUEtUamdnRDZW?=
 =?utf-8?B?bW0zYktSbFhBRDAxY1N3dWRSMXBiL094U2RuZEl4UVdWRDdLVGxHWVZCaGlu?=
 =?utf-8?B?N1lVdTZGK0NHMWZUNmdaWm4zWUpLZkt0SUJXUXdic00wVTJ2c0hRekgvdFNy?=
 =?utf-8?B?aWtMbjNVRU5ESzdLNk14SU1JbUhGSkRNallDcDlFZnI2L21VR09MT1JHdmto?=
 =?utf-8?B?TGJ3LzlHeHFMMEdUaUliQWd0TVlFWU11NUM0SVJmQktEMlcrbjArQTc1d3Zq?=
 =?utf-8?B?ai9sZE9BZ1dMY0NlUk5udG9OeEl0MlBGc3dRbUNzN2llZFdRaEw2VUZmT3o5?=
 =?utf-8?B?cGJ2SXo5SDU5Q2huYmFhVnZVeEk5eHNsWXpVWmZVditUZGFJOEt0Ni9ZeHhk?=
 =?utf-8?B?SVk5OWhPN0pRa1BkTUNTRExUL2ptSXdmUUpGL2tHdkhhZ29qUTFlNWkzZWk0?=
 =?utf-8?B?THZML3pOQlhNRldIait0YmpCN1krN2FSS3NoSDdqSW5aYXJkU1dUbzZNMGJ1?=
 =?utf-8?B?K2M1cmFMbi9VRGR6Mm03blFKM2wyTVBTY2pLUUI0YzVQVWtldXVGNTZrM0Rh?=
 =?utf-8?B?YjRFTjMrMWZ4Q3dFY0lXNFZpanVqUWIwbmZUMTRRcFI2UnMxYnZWYW9INmJP?=
 =?utf-8?B?MGhXWW0wSEcvS1JEZXVwQTlZSlF4N3hXUUlhZlBQOUNzN0wvRUJEQlh2N1VL?=
 =?utf-8?B?Qzd4Y2JpQmhEMDNVeUU0LzJvUlcxY1VBMEhXb2NiL1hiUUlVdGdXVUJ6UFRN?=
 =?utf-8?B?bmtndWxNcEhaQ0lld01RcmpNcUhFOXEzM21iWGoxOUx0V0JPdDFhQkNqQkkz?=
 =?utf-8?B?SkZSd0hOU25WcXFFYjhnckZTT2xjbVF6am1xT2FEMU1rTmI3M2RIMUFTWEpY?=
 =?utf-8?B?OVlQSkswOGs2MnhHRmtoZEhNM0p0NHVPM2ZHb1JZL1o5WjhWSUJPRzE4K05p?=
 =?utf-8?B?VDYvaHd1R29lcEFVRVlvUW5teTMxc1NSRWRXN01NMEdMV1RoMTNyUEw1TDFW?=
 =?utf-8?B?SGpzYk5Mc0h1R0Z1UXRvNGdWdS8rYnE3L0Y1bWtlMW9kOGx5bW9DSGU0NGpP?=
 =?utf-8?Q?e/8AHA0Noac6Qx+3UWdB3SY=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ca53773a-41ce-470f-2a0c-08d9f87241b7
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2022 15:19:46.3368
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 76mIqVAuHa1snaIeN3Rm0TDfYEYoEULfk1+aH6vtadlHuQj+CIwpNBWoZhmhlY0h8rWDO0iVzGXZxyCtnCsaZg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR03MB3063
X-OriginatorOrg: citrix.com

Hello,

The following series add support for Xen and tools to be analyzed with
CodeQL using a github workflow. The result of such analysis ends up in
the "Security" github tab.

Currently we perform 3 different analyses for C, Python and Go code.

Roger Pau Monne (2):
  codeql: add support for analyzing C, Python and Go
  codeql: ignore Kconfig

 .github/codeql/codeql-config.yml |  2 ++
 .github/workflows/codeql.yml     | 60 ++++++++++++++++++++++++++++++++
 2 files changed, 62 insertions(+)
 create mode 100644 .github/codeql/codeql-config.yml
 create mode 100644 .github/workflows/codeql.yml

-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Fri Feb 25 15:20:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 15:20:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279379.477097 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcO3-0008TY-EA; Fri, 25 Feb 2022 15:20:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279379.477097; Fri, 25 Feb 2022 15:20:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcO3-0008Sw-A2; Fri, 25 Feb 2022 15:20:03 +0000
Received: by outflank-mailman (input) for mailman id 279379;
 Fri, 25 Feb 2022 15:20:01 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Zfiy=TI=citrix.com=prvs=0484f4aa7=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nNcO1-0007u5-8P
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 15:20:01 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 64f864d4-964e-11ec-8eb9-a37418f5ba1a;
 Fri, 25 Feb 2022 16:20:00 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 64f864d4-964e-11ec-8eb9-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645802400;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:content-transfer-encoding:mime-version;
  bh=7JLwmDLnPplfo5EXV+kV2lfB8peL6ufTDYH7Y6eoats=;
  b=KmIIQzLpR3+p89Fyw7ip7iixKuycs1fpiiwdhwOa06L4IbgFiTKbBirX
   C7GVm9sFtnjdIs5ZEMBs3koyiQ0Pf5ZZz1X6jvxclsKlBIBBIKFebVNF3
   XcMXExrGR6uW6JWmGD8pEfInEqFWlIuN5fjlxOsymcB5+aWFmLUmzHLPA
   M=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 64998962
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:qYkdqqKvAQIQa2h7FE+R75UlxSXFcZb7ZxGr2PjKsXjdYENS0GNRm
 GsbCjqFa6qPZmX1eYh1bISy/EoOv8fTz4RiGwRlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA148IMsdoUg7wbRh2NQ12YLR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 JJwuMGpcgVxBfznle0ACUV/CGY9JIQTrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBNPsM44F/Glp0BnSDOo8QICFSKLPjTNd9Gls15EeTKiED
 yYfQWRQQT7sMx5ABhQOEbIAmuLriFzAXQQN/Tp5ooJoujOOnWSdyoPFK8HJc9aHQcFUmEewp
 W/c+Wn9RBYAO7S31j6t4n+qwOjVkkvTWp8WFbC+3u5nhhuU3GN7IA0bUx63rOe0jma6WslDM
 AoE9yw2t68w+Ue3CN7nUHWQonSJoxodUNp4CPAh5UeGza+83uqCLjFaFHgbMoVg7ZJoA2xxv
 rOUoz/3LXtSveCMcnDFzea/oDqvY3QyNihBfAZRGGPp/OLfiI00ixvOSPNqH6i0ksD5FFnM/
 tyakMQtr+5N1JBWjs1X6XiC2mvx/caREmbZ8y2KBjrN0+9vWGKyi2VEA3D/5O0IEouWR0LpU
 JMsy5nHt7Bm4X1geUWwrAQx8FOBu6ft3N702wcH83wdG9KFoS/LkWd4umwWGauRGpxYEQIFm
 WeK0e+r2LddPWGxcYh8aJ+rBsIhwMDITIq5C6+IN4YTOsApLGdrGR2Cg2bKjggBd2B2zMkC1
 WqzK57wXR7294w9pNZJewvt+eBynX1vrY8ibZv60w6mwdKjiI29Et843K+1Rrlhtsus+VyNm
 /4Gbpfi40gPAYXWP3iMmaZOfA9iEJTOLc2vwyChXrXYeVQO9aBII6K5/I7NjKQ+x/UFzrqTp
 yrlMqKaoXKm7UD6xcyxQikLQJvkXIplrGJ9OiopPF2y3GMkb5rp56AaH6bbt5F+nAC/5ZaYl
 8U4Rvg=
IronPort-HdrOrdr: A9a23:O0hgnqoYywXifAftIrZS13UaV5oveYIsimQD101hICG9Ffbo8P
 xG/c5rsSMc7Qx7ZJhOo7y90cW7Lk80lqQU3WByB9mftWDd0QPDQb2KhrGC/xTQXwH46+5Bxe
 NBXsFFebjN5IFB/KXHCd+DYrQd/OU=
X-IronPort-AV: E=Sophos;i="5.90,136,1643691600"; 
   d="scan'208";a="64998962"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=M4p00J74PvYcXoqXJrFE1wlWVQb5r+BcXoG+V58L6yWxCodQgCHcRcJP6V0Je/mTVFz0HsPPZHb3QqxL/3dAmjSq5WxG3jY7rf1W11jBJXbywH598JpmHN7WSf1Ma4MYUvlTiCRaD6URnkHPrEmkwye6Ux8NHbiIaXrNp5XpqM0pUT9QUO7LuDZfm1FyC59L2uby5Iy0sf0ILfemlN3kDIEQeIbwC7K0VvRfoVjI74PYudxsNVgKotr64Q9hpMYpdcA7xG6eSNmg1eI3LvpOg0nnojbr56hbJsz8TueRykyidTEUOSXtE1dKARkfqRdu35PDEHFGTyjwM3oERkrYww==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Lewhc8J3qtovseDH6VSo3lWF3jCtfrt5D8YHKkcpQFU=;
 b=aZetWlHAY6f98Rodk8tfeSjp8QM59B1n3O2jcyKaj3pIJY2n1VxujCBIPJMMwWrnuvm8zS4OnC3GOkA/utCwtRde/RzGIDgpz5JyjgHmGkiRyIuSbIgtovB0vSXah+E7v1bZoolYzrfE/c/ZKI0B/g9B4Z5sNGwI3F2/UN1rZN7OptKTSEDQ6tvjvf+MzqBzW31ou7toTo8fVfDVfiTV9nVCCDimrmAC4E8FGmrYcEsovG7Xy0UmEvJY7ScIaDJESHw1jWyxFuW43sYtShb35S+zAxgL+rn1GdoYlu2UA/QL7n7gD93ksabUBri5DHQfjyHnC+nd+tyvoh6XG2++Vw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Lewhc8J3qtovseDH6VSo3lWF3jCtfrt5D8YHKkcpQFU=;
 b=intvuDKGAXota+nJWPVRtB/fjjI0QrbjIOKWihWvtpSDzZtHTeUko+me7JIC/5VJ1deyTLoc30SXvGiqTM7CnneaK2OFAv01NotbpzM+tnkFz7uvdHI3NnqDKrRGmAA5dmJQAgvRdGl+dUugn9yqCXdpy//3ccCd6ZDXlbXkmL0=
From: Roger Pau Monne <roger.pau@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Roger Pau Monne <roger.pau@citrix.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, Jan
 Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>, Stefano
 Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Subject: [PATCH 1/2] codeql: add support for analyzing C, Python and Go
Date: Fri, 25 Feb 2022 16:19:30 +0100
Message-ID: <20220225151931.99848-2-roger.pau@citrix.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220225151931.99848-1-roger.pau@citrix.com>
References: <20220225151931.99848-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LNXP265CA0085.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:76::25) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a901d43a-3096-43eb-0ce7-08d9f8724681
X-MS-TrafficTypeDiagnostic: CY4PR03MB3063:EE_
X-Microsoft-Antispam-PRVS: <CY4PR03MB3063C00D5A6E035FADA2B38E8F3E9@CY4PR03MB3063.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: +SjXeFW3PKWGD5U8MYgaXvLJn0vxAbSyDTR/ysMEG7xoIG/Scm5pMwpdKSvCC4UUrF4RyzTukCWFLizv15EKfvIedxs8WQOBs8MO1gnq2JG8LKjKIMTrQ2gsu3FkDN4d9jHkyh0FuvN1X2aycwL+hCuLaulv4oIxkycEXfBooPgmZhmKToIamWo4KtsinMT9qRrcS7a+9ljLbJ+uie1TfQRdv1S958G8+hPAntr2Q6YnQNkZMS1sXTkXiC4Y1cgqfWsxx89+C3Os123foum8WmqplvJK2R+aRKn/t7KuBPJAyr8wvMyQ08sLM0DmuQ3c9ewAA24m9HO1UiNjdTn2HGJ+gbFp+eWu/42GZZrzpYcniPB9CoFI4hbrrrPKDO7ECDYMrT2ARCG+e2pzkTzsUzH6IUX6JuXva4rSG+1tKgZ7m7XvGjEVOD33aiI/MublMw6AyS1/xdz/ffVw128S5b4YkUqm8jfErzmrAqyKhIR8s+oBnP122BgucXTcL6RKrwM9xqxxkdvz88ukn3vy9RiHKCUaqHzipaBblFBBs2uCnMup0KRiOToqXXtZkDdRRgHX8GrtPRm5dFdcKF8HqFDm+5KBdUdrG+ezZ1WFk/2JgGCZGgmRPoJ6fc7PdK+lnkUdhysHRerFhTQtPbz/7w==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66556008)(6512007)(6486002)(26005)(8676002)(66476007)(5660300002)(6666004)(4326008)(6506007)(6916009)(316002)(66946007)(86362001)(54906003)(83380400001)(186003)(1076003)(2616005)(82960400001)(36756003)(38100700002)(2906002)(508600001)(8936002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NVNTSnVTVE52WEttUkM1QlRER21kd2c2UFlXNlBPQ2psZUJPQlpPcy9iRC9W?=
 =?utf-8?B?aWxXSEd1UzZYN3RONkQ0WmtZMGtXL3FLQVdyK0U1eGNzUXcwUStwN0QzTHI3?=
 =?utf-8?B?VCtGakRzMHVidjV5UWwvaGU4QU90QUxmNGw0ZGlwZW9aVnd2aS9ObUJWK000?=
 =?utf-8?B?dVZHNFNDcWFpV3h2YmxIS0kvZUpGWC9LZDBCS3VBbGt6dGdtVzI3cnJOUlBR?=
 =?utf-8?B?ZzJ0SmpSSzR1VEViZnBwOVpsRFpjRGVXZnZrbFdhbHlROVZhWUtONjhDTWtT?=
 =?utf-8?B?TzZ6c3BPejFJR1B3Z3IrZDFmbFRTblNqaDk3TFVtSVBQbWczUitBUVhDRE52?=
 =?utf-8?B?VFVoTTVBdnoxd0trZ1pMa29pTUZJUk9hbnZ0QVBRczJJZmg1SEFrS0J2UXA4?=
 =?utf-8?B?WjFzaXhYNHp4cDFWcGltbHVuME5sUkhvaU8xcENUSEhLREpzd0xBOWdqZVdP?=
 =?utf-8?B?bzZUWTVsZkhLK2R6N3J1eUNxREtCWWRCTSszUloreFFOUmZUeUpTUmkrdTIw?=
 =?utf-8?B?cFQ4NFZseGluVjRRbVY2NXNrbXlJd2ttZEJJZlBkelB4K0RxUmVadFRqeUNn?=
 =?utf-8?B?ekZiMFl4QXB2ekdlM2xwWllSQVhZNWR5U25lR2VscGwrbFZoWU9INGR2eVJF?=
 =?utf-8?B?d3Q5WERGUHlDeXQxZWFTb0g5Y0JNVy9iRUFoalBISlJicFNMSVhjb1BYWDBL?=
 =?utf-8?B?WkRIU0lWSVBqaUpiYm5wL3FtSTdlUGxuRGRpUTFFRFFIcjdDanI4aWloQ2Ft?=
 =?utf-8?B?SzN2M09yaUthdWlPc29pbHhrcW5HS0lkbUFlZDdqK1p1c2tJY1VKQkhUZUt0?=
 =?utf-8?B?a2RZK2h2Zzhoa3BVLzRJZ3c5M3hKdjdWb2NzdnJKZll6bzJNMHlkRGdYMFZK?=
 =?utf-8?B?aE1EK2pvOHV6dHZTTm8rVTNWczIyOTZoTkkxYzAwRWp0U2g4ck5oTWQrQUN2?=
 =?utf-8?B?aThqclBvK0dXclM2dVp1a3o1NXNGcWFpN2pkRUpGQ2thdXdxOU8wWDR3V0Vu?=
 =?utf-8?B?SHR4aUo2UW05Z29ZUUx6TkErUG8wMmZOdTkxZW5DNlllSmx0VGtsdDVWekFF?=
 =?utf-8?B?QlJGRVlkdHNkYjhuRVpncm5FL3pWcG5lVDRaUE5ab05nZTY1QWR6Q3ZyQzd4?=
 =?utf-8?B?Mk9nWUduRTJmZ1RiSmh3ZnlQMjREaGJyNk93OHJaTVlJQmRXWGRPN3YycWU4?=
 =?utf-8?B?VlJ5WTVrQmc0THIzczEzbU5LR1lXbTBpWlRoWVNyVXY5a3hxYllNSTFjWmRX?=
 =?utf-8?B?QXlQM293WTdiYkpPVWIwL3Q1QnBJVDZDZFZ5eWFydy9kOW9EMDJmV1hjY0hH?=
 =?utf-8?B?YjlXdE1NcEVJRUR5eG9nVGhWd3ltWFVWLzEwTEZTbkx1VHk4ZStlcldsQnhp?=
 =?utf-8?B?bWxmR216cm1PWnpXREJYVCtWK2lBRzV6dWpSZDY2Q25JNUUvaHhtM0Yrc1BK?=
 =?utf-8?B?c0FhTkxFVUlmMXMwL0VsTGZOM0RiZWRXSzRmYWg3L0Z6TEZheWh2cTBNbmhV?=
 =?utf-8?B?MjlGMG1DYWd3ODZ1MXBVc0hWaHp4WkIzdEZSVkVnQm9WMzE1OXhhU29jUlcr?=
 =?utf-8?B?MExUV0xwSi80aEhPVitYSDd0N2dYalZCT0FrYmtiUnU4OXk0azNrcGM2b3Iz?=
 =?utf-8?B?a2pjb0VDNFhmYWF0alBkL3ZTWVRaWDhMa0JiYVdaL0hXV3UyVVRNSys2WWNC?=
 =?utf-8?B?cjRleXdWK25zd2w0TEQ2V3FZRHNTOXNEdzl5VUNwUXduRGtsMHhlSXJSZmI0?=
 =?utf-8?B?TjlRc1dQei81SkRLN1NqRHZJSU40RTNaQ1JvNzNGZ0hnTmNyQ3hrRmF3UFNz?=
 =?utf-8?B?Y2c3YTREdDA4a2lVbXJSaDBJeTNGWHZuZHhHZVRuQkhyTi85ZU5uT0ZOQzRS?=
 =?utf-8?B?bzlEN0xpT2taL0h3SGtVRnFaQWd6SjBGZDduczhES1VNa2l0dngyQkRrQVhN?=
 =?utf-8?B?TFF5L2o5MjNBTktWSFNGaUlFNCtrRjlaYzZWRU03a000aVNmeXJ4UDVNSEho?=
 =?utf-8?B?bTJjYUJRZmkxcjQwWUZ4WDJjSEtIRm1OQTRZWFcyQit3RlZTQksrdVo0ZHlL?=
 =?utf-8?B?WkZqVnBKRXRmY3I0cWhZaWpCaHBRK0lwQzBIaHJMSThoblliclRBdjNVMm0v?=
 =?utf-8?B?K05qMzZaU3FweUp3YVZBcDZ5QVpDeDJqK2kvRUZtQllyQm4wNk42a0REOUw3?=
 =?utf-8?Q?s4wBOUdrk8hkqz2Rmr7CGwo=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a901d43a-3096-43eb-0ce7-08d9f8724681
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2022 15:19:54.3708
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5eAF5d+XKTKpG3dINyfc7kOC9IfjpqR9uIvFwGjx6vOHGiPu77lkArEKFZ8hN8QwFY1E2f2ikJaKWIS09MBnvw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR03MB3063
X-OriginatorOrg: citrix.com

Introduce CodeQL support for Xen and analyze the C, Python and Go
files.

Note than when analyzing Python or Go we avoid building the hypervisor
and only build the tools.

Requested-by: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
TBD: there's no limit in the number of scans here unlike Coverity, but
each takes github minutes and we are limited to 2000 per month IIRC.
We might want to not perform a scan for each push.

TBD: should we also disable the shim build? I'm not sure there's much
value in analyzing it.
---
 .github/workflows/codeql.yml | 59 ++++++++++++++++++++++++++++++++++++
 1 file changed, 59 insertions(+)
 create mode 100644 .github/workflows/codeql.yml

diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml
new file mode 100644
index 0000000000..5bfe478983
--- /dev/null
+++ b/.github/workflows/codeql.yml
@@ -0,0 +1,59 @@
+name: CodeQL
+
+on:
+  workflow_dispatch:
+  push:
+    branches: [staging]
+  schedule:
+    - cron: '18 10 * * WED,SUN' # Bi-weekly at 10:18 UTC
+
+jobs:
+  analyse:
+
+    strategy:
+      matrix:
+        language: [ 'cpp', 'python', 'go' ]
+
+    runs-on: ubuntu-latest
+
+    steps:
+    - name: Install build dependencies
+      run: |
+        sudo apt-get install -y wget git \
+          libbz2-dev build-essential \
+          zlib1g-dev libncurses5-dev iasl \
+          libbz2-dev e2fslibs-dev uuid-dev libyajl-dev \
+          autoconf libtool liblzma-dev \
+          python3-dev golang python-dev libsystemd-dev
+
+    - uses: actions/checkout@v2
+      with:
+        ref: staging
+
+    - name: Configure Xen
+      run: |
+        ./configure --with-system-qemu=/bin/true \
+                    --with-system-seabios=/bin/true \
+                    --with-system-ovmf=/bin/true
+
+    - name: Pre build stuff
+      run: |
+        make -j`nproc` mini-os-dir
+
+    - uses: github/codeql-action/init@v1
+      with:
+        languages: ${{matrix.language}}
+        queries: security-and-quality
+
+    - if: matrix.language == 'cpp'
+      name: Full Build
+      run: |
+        make -j`nproc` build-xen build-tools
+        make -j`nproc` -C extras/mini-os/
+
+    - if: matrix.language == 'python' || matrix.language == 'go'
+      name: Tools Build
+      run: |
+        make -j`nproc` build-tools
+
+    - uses: github/codeql-action/analyze@v1
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Fri Feb 25 15:20:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 15:20:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279380.477108 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcO7-0000os-MR; Fri, 25 Feb 2022 15:20:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279380.477108; Fri, 25 Feb 2022 15:20:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcO7-0000oh-IN; Fri, 25 Feb 2022 15:20:07 +0000
Received: by outflank-mailman (input) for mailman id 279380;
 Fri, 25 Feb 2022 15:20:06 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Zfiy=TI=citrix.com=prvs=0484f4aa7=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nNcO6-0007u5-AK
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 15:20:06 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 67f3cc4d-964e-11ec-8eb9-a37418f5ba1a;
 Fri, 25 Feb 2022 16:20:05 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 67f3cc4d-964e-11ec-8eb9-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645802405;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:content-transfer-encoding:mime-version;
  bh=/zbAF9xhZs7zkz99bXimn00C1AzPUbFM+7FY5qL3xcY=;
  b=WGrON8o++jv9HwVTgqOAK7zQ5uLMZj3A29Dmwnq10s5amLbOGaAjZ/qL
   Z7Dwy7c5RxposEwAMDrVK5EpCiCQEiNTyP5npqS7BBUyANNIXhxP4hEKf
   hStQ0PYvB1uq/TFK+y7Tmz33KekP1WKPsO54EBtZKu9uUcA51NiThpi2G
   I=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 64433622
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:M4LO4K9lG7p5PuqgeB45DrUDvn6TJUtcMsCJ2f8bNWPcYEJGY0x3y
 WYXXWiFOPaDNzajeIwka43j9RtV78CGnN9gHQdopX08E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si+Fa+Sn9T8mvU2xbuKU5NTsY0idfic5DnZ54f5fs7Rh2NQw24LkW1nlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCnYyIWywjI6flpPg6ShIEHwJyJ6lk1qCSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFJkYtXx6iynQEN4tQIzZQrWM7thdtNs1rp4SQa2FO
 ZBDAdZpRFf5MwZIPEc2NKoZm8S4rUnafSFThmvA8MLb5ECMlVcsgdABKuH9YceWTM9YmkKZo
 GPu/GnjBBwectuFxlKt7XaEluLJ2yThV+o6FqC89/NsqE2ewCoUEhJ+fUu2p7y1h1CzX/pbK
 lcI4Ww+oK4q7kupQ9LhGRqirxasvBQRRt5RGO0S8xyWx+zf5APxO4QfZmcfMpp87pZwHGF0k
 A/S9z/0OdBxmK2tW1mX6729kS+VICNJIUwOfysmYxRQtrEPv7oPph7IS99iFou8gdv0BSz8z
 li2kcQuu1kApZVVjvvmpDgrlxrp/8GUFVBtum07S0r4tlsRWWKzW2C/BbE3B95kJZ3RcFSOt
 WNsdyO2vLFXVsHleMBgrYww8FCVCxStbGy0bb1HRcBJG9GRF5iLJ9E4DNZWfhoBDyr8UWW1C
 HI/QCsIjHOpAFOkbLVsf6W6ANkwwK7rGLzND66IM4USO8QsLFffpEmCgHJ8OUi3wSDAdollZ
 P+mnTuEVy5GWcyLMhLsLwvi7VPb7n9nnj6CLXwK5x+mzaCfdBaopUQtazOzghQCxPrc+m39q
 o8HX+PTkkk3eLCuM0H/rN9IRXhXfCdTOHwDg5EOHgJ1ClE9Qz9J5j646e5JRrGJaIwOzraYp
 izmAxQAoLc97FWeQTi3hrlYQOqHdb50rG4hPDxqOlCt2nM5Zp2o4rtZfJwyFYTLPsQ6pRKoZ
 5Hpo/m9P8k=
IronPort-HdrOrdr: A9a23:Bkjsuqt41w0oO1eMHN8LAOPN7skCkoMji2hC6mlwRA09TyXGra
 6TdaUguiMc1gx8ZJhBo7C90KnpewK6yXcT2/hvAV7CZnibhILMFuBfBOTZskTd8kHFh4tgPO
 JbAtJD4b7LfChHZKTBkXGF+r8bqbHtms3Y5pa9854ud3AWV0gJ1XYJNu/xKDwReOApP+tcKH
 LKjfA32QZINE5nJfiTNz0gZazuttfLnJXpbVovAAMm0hCHiXeN5KThGxaV8x8CW3cXqI1SvF
 Ttokjc3OGOovu7whjT2yv66IlXosLozp9mCNaXgsYYBz3wgkKDZZhnWZeFoDcpydvfomoCoZ
 3pmVMNLs5z43TeciWcpgbs4RDp1HIU53rr2Taj8A3eiP28YAh/J9tKhIpffBecwVEnpstA3K
 VC2H/cn4ZLDDvb9R6NqeTgZlVPrA6ZsHAimekcgzh0So0FcoJcqoQZ4Qd8DIoAJiTn84oqed
 MeQ/003MwmMW9yUkqp/VWGmLeXLzYO91a9MwQ/U/WuonlrdCsT9Tpc+CQd9k1wg67VBaM0o9
 gsCZ4Y5o2mfvVmHp6VO91xNPdfcla9Oi4kEFjiaGgPR5t3c04klfbMkcEIDaeRCds18Kc=
X-IronPort-AV: E=Sophos;i="5.90,136,1643691600"; 
   d="scan'208";a="64433622"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=LI+JfwG6kG1cM0I8V9nSUbmNI8+3EKaURU9uLP8NXWyN1nDJKiSfl4+adluL8+TSiUFK+YSFupcJmrbKCeJeDvrayLVHLDLLFpNBrDtZlycsBVH0pPI29XJKN7NC434/qyDGhJtposeB3UibCKfadOH5FULpaLrMb8COBWjd5XRGh4WuzVfu8sScqyBv49vnr9en0b9+p5pgJosz5WWA1FVrPrp7aE0bYwI2r3vTsk1HyvJnOJ5nEfzxXn1NBzTt57m2hkSZni4Ym2cLOMpETgDqcoYW5iePyvYgG7Lpo6l4RSVfhpjBCTm7F4XfYUFxBEqAFw0kWNZiTeQS5plAtA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=bN0IVcvEv4wCzAJopPvVAHw1GJdIujQtv3tKwci1P7U=;
 b=OGAmlQ64PCMPhpJlw0aNAQ+nv4Mk8E/yZigVi439qLqfcsREr2JwD9cD2CcqxWbEyys9M978VI3xuNvjBbNTcAMxsX6zHmGLBtiyR14XaBqQQ8Yur4VIOFSmOqtBsiXdMHoJX4gsM3Z0dH6otY2sCYioIEKn3MGi3xZMls5HbeHVt6cK4MGvaiv54XbF5FvlwDfTcaqrsRIkvHETUBGXQ/RQDt7h0JHGdDYakT5h5xnz91Zfl2W2dsOUPHQL+pitdZT/yXrIphFW5PnCojYDqsjUYhTknPnfnA91jwVb15xJqlGl2z82xRRxJqqpLFTrr8tFBFQLO2uk2M69/1wYMA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=bN0IVcvEv4wCzAJopPvVAHw1GJdIujQtv3tKwci1P7U=;
 b=MaeN+ykj5g+q1sr+aMzbuygV2hcZQjhSErcxyuf8/8ZnWsi2bC3EHjtgBWnHrI0zfRx9bH1UaEmixuLDmpdxfMhKKaAWUcNvasc4Jav56g5phBYZMftvF/xZkycSuPkvPUpl7KLA2Sy0irgXLyKSrZuGysnU4qjjDaHe2m0N7sU=
From: Roger Pau Monne <roger.pau@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Roger Pau Monne <roger.pau@citrix.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, "Jan
 Beulich" <jbeulich@suse.com>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Subject: [PATCH 2/2] codeql: ignore Kconfig
Date: Fri, 25 Feb 2022 16:19:31 +0100
Message-ID: <20220225151931.99848-3-roger.pau@citrix.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220225151931.99848-1-roger.pau@citrix.com>
References: <20220225151931.99848-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO4P265CA0090.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:2bc::11) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 6200ad6c-eb3c-4459-0e4b-08d9f8724999
X-MS-TrafficTypeDiagnostic: CY4PR03MB3063:EE_
X-Microsoft-Antispam-PRVS: <CY4PR03MB3063790E66D1AD77ECCE2E358F3E9@CY4PR03MB3063.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: hV/ZRsRRt9AlIXU/qvBQV8RRRRTX5sY696JiDyng/ohz214F1lulV3xbMj59MfAiDV+XeFYs1PSiYOtHTpfaNamIm1yd155l2TD9tLCNcF4XSFAlpQCatMzgqQ4ixCEb1tOHZqylB9gkfojrYXH7HLgJ3YkoWiiEmis4jk52AfqEU+sKVR8oZEhb9R24kC1XRNhoHgVpHOLxmV4MaITWpefboxyjcLljacydvB6g7+dOIvBdPpIHhCgqd06be2nw9pVuagJxLmkbwwVNHiGl2uJaBGDXB05Ldl8jKjSWiyWQMMOUOc4Nh7VsMEUpOlFjgBH2Vg2aSmW1jgf/6glROngfWSc2Sz8BwwfrkhKFf0H+uNEO/K8b7Cfyw8HLfSPOXgKtXu/JfkyQoFOON7NxYVDNe3wNBJBkIBjpVJAHLUO4T8DbIiRfub+/V2//X+dsqQrgRIFjoGZ57cjLBzKEKgfPGrvQj1UwRxBk3koxRuqcnz/5pORFcJ+zYnAKMfZ0fOZor4/aTXNE+SWjD+IXPOzl9aeFYjTfJjvj9qf3i8LL+efS/MWXYjWu7NV7OYxj/Q49Ifijm2+dLuf+B7xE+D6fUAUotffMupQNd3nBHqa5aviXRUKsCHWJ3OqpuDGP26C5a3WHZSAskLG1wCTfXQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66556008)(6512007)(6486002)(26005)(8676002)(66476007)(5660300002)(6666004)(4326008)(6506007)(6916009)(316002)(66946007)(86362001)(54906003)(83380400001)(186003)(1076003)(2616005)(82960400001)(4744005)(36756003)(38100700002)(2906002)(508600001)(8936002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RXZ3RHI3cEtTbHFocnBxcnpTZ0RZR1kvSzRRK3Fkd0ptdjlwVGlDR3Z1R0hB?=
 =?utf-8?B?YTZwODllTXRYZjQxeWJXNVRuaG51aCtVNHRuMTNESnd2OUJlYzRzSXJtYVJQ?=
 =?utf-8?B?L0trS3hiaTMyU3BVVTRtVWxWaG9GbUdtRXFzZnAxc1JvbjVIZ1pIcisrektX?=
 =?utf-8?B?eUNNNnl5eld6Vjgzb3FQSm9TZExaSDNJTjFNWGxOMVNHODNWY0VIM3huZXdo?=
 =?utf-8?B?YXBGRXpyWFE5TmthMzhXY1ZyQ2d2OU9FTnBxMk1qc0pmUWtWdWhram5YL3Ry?=
 =?utf-8?B?T0ViVmdvY09hUWRNVUd1WmIvUU9sczBrb1BkOTVNdytTa083RkV0VUdmekJY?=
 =?utf-8?B?NktyeS92blJCTURNT1N5Qk9pVEh1aktydG01MXhVNjN1ZkJVSDVscHYyaUZ6?=
 =?utf-8?B?ZHBkT1Y3ZnlSQmFzQ3V2UThlTG84RzliTHBkRTVNcUNwUTZrMWtHYkNYNi9J?=
 =?utf-8?B?S0ZJUVNxN3d3NkZVczY1WTFMVzZ4aGZtTXg3QUtmSkVZbWhtUVNvQTd1S3VK?=
 =?utf-8?B?VjJ6WUo5TldwSEo1cFJ3ZzhLc283b1hrSFhlenBxTWg1bk10L3liQ2daQ210?=
 =?utf-8?B?TWlNRGtsQ2FtMGh6MVRqS1pRVGxSVERUcWFWelpyU2RXY3phcWpOeTUwOHlq?=
 =?utf-8?B?b2Rrb0lxNFNDczVBbk9KcFlEZWNlMGhldFQ1aHdMR1dhMjdDdVpQM2ZKVjdI?=
 =?utf-8?B?WGtHQlBPNzhDaFdFWmF5ZXRRbHg3alpCaEVJQTJrcldWNkYrbW1nZVQxbEJi?=
 =?utf-8?B?c2x4OEhUUXNYa0hjeDE2NEJReEMyNFdiVFdNU3dQZk9zdVZPSzBLZVZaelpV?=
 =?utf-8?B?WVpxaFBNSTh3TE9xWUJUNkIwVUltdm5EWEQrbk0wNEMzdFo2YjQwVUsreFpR?=
 =?utf-8?B?bmJ1S3MrbE5Balo0clREUFUrMWZRcmczWGpibWxYQi81UnVVL1RPSERIdk9L?=
 =?utf-8?B?aGRkZ3hOckxHM0pSek9iWXFxYjFJQ1ZQWDhsTjJjTVhNNkpEY0tFUWJLNXMv?=
 =?utf-8?B?NHcybkdIREZ0TUxjRE8rMG8va21hcjRyRDZzVXUzNnlmeVRBUkU5Vm1jSm55?=
 =?utf-8?B?UUVBT3VKY0Z0MW0rY04yMFE2dzJFVUhtWDhHVVR1VUFxUW9BelM5NkREZUo3?=
 =?utf-8?B?MTBwVFZNMVVjbWk3MHluVnlaS2lQZmI1Vk5HMzFnOTJkZ204VExLNmtqemN0?=
 =?utf-8?B?RGJrNytaZEFySllURUJ2dUVxNjUzV2tGZGQvNkI1bXJSMmpZaUdVbXdpNGVz?=
 =?utf-8?B?Sy9xM2FzMzlpZHR0WnlISFpHVzdiZ2JjcVU2YzlXcjF5QUl0WDRhNVo3clU0?=
 =?utf-8?B?WEQ3YVJDeG5KeGVnRm0rR2F4K2tlWHp5TVV6Q21SbDFkbzhqZ0lCdGpRUUxU?=
 =?utf-8?B?bE1McDlmNVg4d3EyWDhDb2U5dk9aaHhsVHJRaTZsUUZMQjI4bG5mVHMyZUh0?=
 =?utf-8?B?SGJING1lanlwRjFuYzBqZWVvWm54d2VWVTI4cURrekZXSEZxa0NIeW4xNlh5?=
 =?utf-8?B?V3UvV3pINWF4eGVoZlVjV3NQSDRoa1dOdHU2QWV4bm1USTVjZHBiQ3B4THVE?=
 =?utf-8?B?L081dzBSaFBtM1lWQlNqd25mQnR0REhEZWFseVdITjN5anhhS3pBU3R2NEVm?=
 =?utf-8?B?SUkxdlJ1TE5QandzZkNuY0xIOENBNEpFYjdmd3VXRGljS28zQURySUlPVmtG?=
 =?utf-8?B?QUlzRkJVUnByWDBZajZ6UjQ3bDliVStyb2FZODBlZFdmSTBMV0d1dm5MbDdw?=
 =?utf-8?B?NFFST1RlaXZFT2gwdTJBOFhaOHlUNkhZY1dnVVA1bzVJcmtvUkYrUHMweisx?=
 =?utf-8?B?ZVJleDhTYnBZeXJ3Um1yQTJPWko4ZnNvdkEzeDlmWDhaSW1qdUI2alV2S3Yr?=
 =?utf-8?B?RjFFUytra0RrMzhBM1MxRDBXOW1qSzhjaEZ6YW82YmoycEVaUWxKSWNoTFls?=
 =?utf-8?B?djRkSEJYL3dIWElIVVhKaXB6VTJTTm51VUZsRWQ0a2U4YzMrckQzcVBtblI4?=
 =?utf-8?B?ajlyaFpKZVdvdnNEZlA4bDVNSXVIckhxM25xUUVDbXp3Vy9nK2IxSGx0NnU5?=
 =?utf-8?B?SzNKYnJRV2dQYThYVXVlSlJiQys5M0VXai9aMWpDZnphN081ZFZTUHkvbGhJ?=
 =?utf-8?B?UE50OXJPR0tQNENPMEplc21odnRIT3pNbzMzaVdZVlZOd0tKdFplWklMTFpX?=
 =?utf-8?Q?dkQCYazby7NgUxSP+TGmbDc=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6200ad6c-eb3c-4459-0e4b-08d9f8724999
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2022 15:19:59.6081
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kdBCA8tZWVeFkTEQac7cHRqkDy9gOsAp63EGHxbjjKsxwe0zDprXrjeXfiZK6nZcehpyg8t3sMI3IxUen8NcuA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR03MB3063
X-OriginatorOrg: citrix.com

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
 .github/codeql/codeql-config.yml | 2 ++
 .github/workflows/codeql.yml     | 1 +
 2 files changed, 3 insertions(+)
 create mode 100644 .github/codeql/codeql-config.yml

diff --git a/.github/codeql/codeql-config.yml b/.github/codeql/codeql-config.yml
new file mode 100644
index 0000000000..3648e8e39b
--- /dev/null
+++ b/.github/codeql/codeql-config.yml
@@ -0,0 +1,2 @@
+paths-ignore:
+  - xen/tools/kconfig
diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml
index 5bfe478983..2e2dfeaee1 100644
--- a/.github/workflows/codeql.yml
+++ b/.github/workflows/codeql.yml
@@ -42,6 +42,7 @@ jobs:
 
     - uses: github/codeql-action/init@v1
       with:
+        config-file: ./.github/codeql/codeql-config.yml
         languages: ${{matrix.language}}
         queries: security-and-quality
 
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Fri Feb 25 15:26:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 15:26:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279407.477119 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcU4-0002As-Dj; Fri, 25 Feb 2022 15:26:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279407.477119; Fri, 25 Feb 2022 15:26:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcU4-0002Al-9e; Fri, 25 Feb 2022 15:26:16 +0000
Received: by outflank-mailman (input) for mailman id 279407;
 Fri, 25 Feb 2022 15:26:14 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=COT/=TI=oracle.com=boris.ostrovsky@srs-se1.protection.inumbo.net>)
 id 1nNcU2-0002AW-9n
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 15:26:14 +0000
Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com
 [205.220.177.32]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4244215e-964f-11ec-8539-5f4723681683;
 Fri, 25 Feb 2022 16:26:11 +0100 (CET)
Received: from pps.filterd (m0246632.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 21PEkTaB013166; 
 Fri, 25 Feb 2022 15:24:16 GMT
Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71])
 by mx0b-00069f02.pphosted.com with ESMTP id 3eexj89840-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Fri, 25 Feb 2022 15:24:15 +0000
Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1])
 by aserp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 21PFH13U069533;
 Fri, 25 Feb 2022 15:24:15 GMT
Received: from nam10-dm6-obe.outbound.protection.outlook.com
 (mail-dm6nam10lp2104.outbound.protection.outlook.com [104.47.58.104])
 by aserp3030.oracle.com with ESMTP id 3eapkmxvhr-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Fri, 25 Feb 2022 15:24:15 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10)
 by MWHPR10MB1726.namprd10.prod.outlook.com (2603:10b6:301:a::17) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.24; Fri, 25 Feb
 2022 15:24:12 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::6d20:6694:a16:56f7]) by BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::6d20:6694:a16:56f7%3]) with mapi id 15.20.5017.026; Fri, 25 Feb 2022
 15:24:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4244215e-964f-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date :
 subject : to : cc : references : from : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2021-07-09;
 bh=xq1KFz/d2s6ddJNFYr6ecFFBNr4eI3OIg1/Km9fVKq0=;
 b=tDVpMsqE2yC3sJv2iRK5aD4VmfqGhiJEzXA/0Re0bMR3k+S8WEkj59tjGUQGeEu3FRGd
 iI+48uMQXCsA7qk4fKtrSbUCCN5qrRSw3anOsyHvYJTMKKfG1rfmnPY+LiZX9Eg2hpdz
 4XAZhK+w3fKx9sNLj40JKoexwATKJHO+/zxHtKm5uRvrCYQyIGW8k2x0kDJKHHgrht4z
 Qq4PxfASYkb9WThfxhNF9ln7Z/H8Rj6/5hJMo7fXi5ZVr1WNS3ZlW42xVMuOjSjRQZRH
 +JDOnxTaXu96iwSdXtGWWNH8qSJKSE5kMPJYxrEUKzh3ZDngt+I3ac73B0h+qP3rnRVl oQ== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Cl7NZFMgIcVtetzJPTHeMjtr62l/EaRS7SnWymDf2+tL/PaZDeL3xbbhpRooaegafIvTzJjXQuvINbCSCqx8uwfMSdG/hwacKkbHUpJ3TLsOw5wUtgnYRL4Nq1EMGDr+gBdfA0LwhiDLYIoncXwypAsLKElFgiC9CLm8B1Lcrfoafs5Z5LOS2G8WgjmtN3+btPmNC0hxgVo+++NHeFAVpOO84uRTVinXLFLPMRraiTI6fQ5fjpbJp/NotapffvB8QMJTjIRKmFfAv58wgumo+jueqR71hVZRb+eXJsFG/bllreIKEv9Gi923OCq8K2bS79Pumu5dmeCa9QLzkAUw/Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=xq1KFz/d2s6ddJNFYr6ecFFBNr4eI3OIg1/Km9fVKq0=;
 b=WKTsJvlRt40sKSnZNA0aDyd3I4JOx8LeBvxKIjuHSGhBKO0EXLHE3u/Fb7kfSO5819APhzImSfcZHRBNuuBuSauCAvFRnl0SzTmVWDLz3PUpZjxLrGxV6mxc3Z5HuBs+706PG3OsMpCMUbTTe0BAoXDFIvjXlv20zej6OBO8Z9sPaw/vi83afkqCXKVXFK29qMOWzMKoxjh6vPVF9rkQAmcsXxVbu0QIs8/7NdhiZiV1LcA7anYiLDbyIAy5jtOdlCqpojaUh+8OaCeW3Gf8L5wF3LXdDmEPlp+N+aLvmJ97rVLJ9L/BrUChuyV7QdUJGLYUz2GNNwYZY4BQOgjxAQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=xq1KFz/d2s6ddJNFYr6ecFFBNr4eI3OIg1/Km9fVKq0=;
 b=oNZQ33HyaQLoiri5jTRDmHa4v3wsZ7V8T1tznmJtW3yoCK1H6Ug7mQcqKd79oK3974VG1umZ3misheKhw7qJqfmsOY8/y4hLpt7JJG0szficpJRmcjIb5OVeKJedI0cwjo71UqNNhXwuXWdXzVjlwQSZar6aNbUpzjj4P8WhkDQ=
Message-ID: <49710cd4-17af-7cc6-5f31-1f36afddb51c@oracle.com>
Date: Fri, 25 Feb 2022 10:24:06 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.1
Subject: Re: cleanup swiotlb initialization
Content-Language: en-US
To: Christoph Hellwig <hch@lst.de>
Cc: iommu@lists.linux-foundation.org, x86@kernel.org,
        Stefano Stabellini <sstabellini@kernel.org>,
        Juergen Gross
 <jgross@suse.com>, Joerg Roedel <joro@8bytes.org>,
        David Woodhouse <dwmw2@infradead.org>,
        Lu Baolu <baolu.lu@linux.intel.com>,
        Robin Murphy <robin.murphy@arm.com>,
        linux-arm-kernel@lists.infradead.org, xen-devel@lists.xenproject.org,
        linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org,
        linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org,
        linux-s390@vger.kernel.org, linux-hyperv@vger.kernel.org,
        tboot-devel@lists.sourceforge.net, linux-pci@vger.kernel.org
References: <20220222153514.593231-1-hch@lst.de>
 <09cb4ad3-88e7-3744-b4b8-a6d745ecea9e@oracle.com>
 <20220224155854.GA30938@lst.de>
 <206ba6a3-770a-70ad-96bc-76c6380da988@oracle.com>
 <20220224163943.GA32088@lst.de>
 <8ffd8587-7eb3-d5b6-eab0-b86df5c0ebbd@oracle.com>
 <20220225084755.GA29630@lst.de>
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <20220225084755.GA29630@lst.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: SA9P223CA0020.NAMP223.PROD.OUTLOOK.COM
 (2603:10b6:806:26::25) To BLAPR10MB5009.namprd10.prod.outlook.com
 (2603:10b6:208:321::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: edb153b5-ba21-419a-e138-08d9f872e066
X-MS-TrafficTypeDiagnostic: MWHPR10MB1726:EE_
X-Microsoft-Antispam-PRVS: 
	<MWHPR10MB172605C5A2B316A6E04A37988A3E9@MWHPR10MB1726.namprd10.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	zRPGz6rTvBJo2Op6AviLkezM3YP/b4Wi73ZHHcYYwArqvRTtApuGAT59Pm3dpk4LBe9jN31J+T5/0j0KJKHUM9jLeU8QCzkU3ve2GQWsaHenQ7aIQNuj67guo5EL+ZKfi38mkQ2co2fQtlhXTCv2QpFfaI5XmSRK7Io09Q6i86f/tPLb65D7l58hWRxrCMPmmpqwuXVoNP+ISGQzJ7rF1a8qGb1uYi6m5O844b1XR8Hkg6RzErsi5N0jPNeZ59RL49J3Vh0kfchqH32VukKMXLXE0wtLo2zc8MYRXD5FoDT4xdmhYe6NGNWe5Ecs+0KS6CcPLBXHBHwv8dP7squ0RLNGsZlgXCfZBuHN00UUhvaasDfJY+BHPVZB5+VMDifpm4Yx2EfN/CdiuJYnZ56/OJrNrFKYJkyzHg0EQJwGOOS4oWgdM95HUpSkHBC/1OE0EQ+CicFXpkUDKXyWH127RZ8lMxg+83yBoFLgYc2rUGhb6kKBgL/nzbmRQCL+U3GMGWI8eR7jy8zAS8TFoiJAvAgQX1xUiP19Xd5+fR8sKAgVuo28VjDxqdUBR4QWt7S3UoauvAypYJnrpagbJb7QWQ51FpdfW2QdB97DqdK08YcGF3dBRPsoSwRRSEC68tXcDMlsay2OY3iMqItcPtM+6zhYpvhqZYYYpTr3f3ns2908zmmGbhOW72ZolCt/lDm7cgSEMqO4U0dFzvYQBdiyU+/WIzjhghcoESkX7XzCnQmjRTprMLNcLQQHIT/ucImS
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2906002)(4326008)(8676002)(31696002)(8936002)(66476007)(6916009)(66556008)(66946007)(54906003)(6486002)(4744005)(5660300002)(86362001)(6666004)(186003)(38100700002)(53546011)(3480700007)(316002)(83380400001)(6512007)(36756003)(6506007)(44832011)(7116003)(508600001)(31686004)(2616005)(7416002)(26005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?M0dra25xSE9xU3hhNFMrclhPeEVlWTNTNkphY3JRSVpCYzZCTjAxUFRwQllO?=
 =?utf-8?B?SkFnTFBFWkpHYTd4VldHTVBvT2J1S3YraUpqaVIzWkdkMFB4bUF2WW9OMVpD?=
 =?utf-8?B?QWVHQzdkMTFQNkRuYXR5eVZUdmI4ZmtxdjZIajJpQVkvQ2hZN3VLaldsUytm?=
 =?utf-8?B?MXN3YW8zbkZiMDlPa0FXQnlEOHJsaFE2R3FZejlNVnhFK212Q3U3ZCtCTkNZ?=
 =?utf-8?B?RXFUbkZyQ0pTK1JwNXFyVkJGSmNyc1g0TWpsSGxXOXAvZU1HUHpXcjRENEFZ?=
 =?utf-8?B?bGg4YTJ6V2RuZldZQkcza2dYcDNSUG1QaTQ0bXlKTFpHQkVSUmxsUDRZaE1R?=
 =?utf-8?B?Q05TWkUzUTI0aWwxTTdaNnZTQWV2aVRjbGQwclhYSHFKeTVaVC8xbGFkei9L?=
 =?utf-8?B?UUNMam1PVVBnRmpoTGI4eVhzTnc2ZnRPWE5RZWwvdHM1K2pTVkEwWVA0TUs0?=
 =?utf-8?B?ZWpnb2QzMzJhSEpUbzRVOEtlSWt4SDB0a3ZHVDk3MnVvVVBkd2V3K2hINjRq?=
 =?utf-8?B?N0Q2THZOeUxlcVhLK3pwNTJXb21vTXNWcWRXUDN5K0JCZ0dFazJmYUVxUVd4?=
 =?utf-8?B?UXVFWnU5WFlmRzFSUE90cDliVzhXKzB1bWUrV3RHb2wwYnRDaDBCV0RoM3V2?=
 =?utf-8?B?WjF2cWhHSUhwTDkzeVJleGUyVmJRUmptL1hKU0p1TzRrRm52RTZMdEVhbkpj?=
 =?utf-8?B?dGdZaVFkaW5wcjUwUHpCM1JMQnRBTzJnU29HdmJROTRuQ0Vla203UmJlbWZy?=
 =?utf-8?B?QmNOZ1BYMTVscld3a1VmREdocnkyNmFrU2IrNjRCRFQ3NkhmRnhkRTk0MWRY?=
 =?utf-8?B?OXU3Z1dDZWVHYmd5WU9McXFsUDlXbHlZS3pBcGRDQVQxb05CMlBYblFnQjVw?=
 =?utf-8?B?eHY3TFl4a0Y0RlhGQWp0dGg2cGlKTXZEeEp3bUtYYXRwckN1U2lrd3E3d3NT?=
 =?utf-8?B?TFVZSlY2ODZrY09xc1BBUjVmWGtsV3ZaWjVWRnp5MWoza0JiWmxPUXEzaFZZ?=
 =?utf-8?B?Q1d0UGoxSFFvT1ZGQXB5QXRFSnRMNDBnYnllcDV1T3dwRjlDckRWMVc5bE9r?=
 =?utf-8?B?Q0ttTkFJSlJnUVRoZ3hQQXB0TnRIdWdzaThIdEFYVmdRRUYvZFc5MnVHU0RJ?=
 =?utf-8?B?Z0x2WGoydmw3dlgzVWt2anlrWVN5V3l6dEkvU0d2VmJITTdxMktROTFDWlhT?=
 =?utf-8?B?UU92bXdxKzVvWktGdUtDc1prdUxuVlVYTE0xa2MyU2p0NHlOVXdvV0hqVHBC?=
 =?utf-8?B?S0ZiQndHQ1QxN1FoQWg0Z1VQSFpBN0pqUTNZcGo4YStLRlpQVkJJTzI1THBt?=
 =?utf-8?B?TFlIZ0xEbjhMZG00Vi8rVmhQbXJKZVlyQzNoU3AxYWtGeGNQUzBLeEJ3S2xQ?=
 =?utf-8?B?ZjlidmJJKzRhOGFFNCs0UmdyNmdRKzhuMmFtV2VpL2wzdWN6U2QxUkhPZk8w?=
 =?utf-8?B?ZnZzKzV3L2VDNXRKeWpHZzgwc0dEdFpPekI1Vlp6SmNMWS8rZzBPS25ZYnF4?=
 =?utf-8?B?Y0RwN0o5bkkwWFNDMVQvN0s1dUNyZ3BBOHFaMW9sQTdzNHF2aWQ3KzVaMGZi?=
 =?utf-8?B?T3NUNkxRQ2pvTmZYWHlHSk9mc2V1aHNFVy9TSVAySGNrRXltQ0ZmY2h5Qzg4?=
 =?utf-8?B?MWh1VXYrUloyc3B0dVlYNXBrdDRtcE9EUHlMREp2TnpNMG13OGNEVVNaQWFV?=
 =?utf-8?B?VDVBTWlXVEJyY2VGYmM1TkprSTZnZytyVC9wYUNpWUdpd3dxcjlodGFuYkc1?=
 =?utf-8?B?dkRRRUZUVHJ5Rloyckd4b2NsY0tYWmdnM1NwWi9aS0Vyd0l0SXl5Z1pOQkNu?=
 =?utf-8?B?TDgxTmU4N3phMU12djRHN1NPa1lOR3V6NVFXZlVWdm5EaGpLSEhVMlI1NXpF?=
 =?utf-8?B?WFA4WHBVbTY2OXZzckw3VWxzTStxblJTTjczVmJycGVZV0U0VnhUZEQwWkJl?=
 =?utf-8?B?blBQcXFadE9hVDYxSm03YVJTQjFyem1ITXY0NEsweHVpUnIxR2NoVEE5cWV2?=
 =?utf-8?B?eTV1bE51T056NktwUEh6L3g3VEZZMnN1NVI0cG1uZC9haEozTitQbEV1ODhx?=
 =?utf-8?B?M2Npa3pHVVBIWlNuY1ZTbHhxeGFwSmxYeE0yUXF2cXZMN3YwbWllV3BHWWVh?=
 =?utf-8?B?YXFzQzF1cmwwUE5uYlhqd29MZStLUEozSktXa3hjT2dlVXFFL3FnMmsySFVo?=
 =?utf-8?B?djA4cGdSVWVDQUlWd2YwTXZINnN6UkZzazVGMWVxaHdlVFZyWEpSYmVadGpo?=
 =?utf-8?Q?JWDfW9GfCB9eD12jfk6yd0KOyBRrBMhIMEezy++zL8=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: edb153b5-ba21-419a-e138-08d9f872e066
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2022 15:24:12.6934
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: u8nwtBbhXOmqpOQiJRyAPDa9MWM8HYrPvOB5Db34UpZrEvC1bGaWNKQ6c8kJVfnmrNC8ubes8rm0q/Zkd7zRmtp1ifMsxdEnb90uc96u+/Y=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1726
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10268 signatures=684655
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0 mlxscore=0
 spamscore=0 mlxlogscore=904 adultscore=0 phishscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2202250090
X-Proofpoint-GUID: EHKvuJik5zh0LZJL-dHJLMhDOWs_znGx
X-Proofpoint-ORIG-GUID: EHKvuJik5zh0LZJL-dHJLMhDOWs_znGx


On 2/25/22 3:47 AM, Christoph Hellwig wrote:
> On Thu, Feb 24, 2022 at 12:07:26PM -0500, Boris Ostrovsky wrote:
>>>> Just to be clear: this crashes only as dom0. Boots fine as baremetal.
>>> Ah.  I can gues what this might be.  On Xen the hypervisor controls the
>>> IOMMU and we should never end up initializing it in Linux, right?
>>
>> Right, we shouldn't be in that code path.
> Can you try the patch below on top of the series?
>

Yes, this makes dom0 boot fine.


(It also addresses something I wanted to mention while looking at the patches, which was to remove Xen initialization code from pci_swiotlb_detect_4gb() since it had noting to do with what the routine's name implies.)


-boris



From xen-devel-bounces@lists.xenproject.org Fri Feb 25 15:31:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 15:31:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279424.477130 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcYn-0003qK-6g; Fri, 25 Feb 2022 15:31:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279424.477130; Fri, 25 Feb 2022 15:31:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcYn-0003qD-34; Fri, 25 Feb 2022 15:31:09 +0000
Received: by outflank-mailman (input) for mailman id 279424;
 Fri, 25 Feb 2022 15:31:08 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=OfPD=TI=citrix.com=prvs=04800b3b0=christian.lindig@srs-se1.protection.inumbo.net>)
 id 1nNcYm-0003q2-1P
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 15:31:08 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f22a5ecd-964f-11ec-8eb9-a37418f5ba1a;
 Fri, 25 Feb 2022 16:31:06 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f22a5ecd-964f-11ec-8eb9-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645803066;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=A28qk6yx7g9PJoD5im5B7qv5gS2TCCS/6xCmjta4UuU=;
  b=Z/yp7MopQalSKL+uHZy4LWJfd5pzcdQiA5pfZMRJzpNvTFtOgujdmRbo
   8qqZDSKgO8a5i+XmLl/ZZU8ySXjFxuRJa3RIY85nl/msgS9hoKhhC7hcK
   pu7mXfSz8iLZybNBFgX0gbraIxzRPgQSg5WX30TmnliHaUS5RVbraV/nQ
   w=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 64434659
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:yUmiO6PbBAbZaYPvrR24l8FynXyQoLVcMsEvi/4bfWQNrUp00mQGn
 2tJC2nSOKvcM2L9Kdh2bovl9E5TusDVzIQ2Ggto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFcMpBsJ00o5wbZj2NMw27BVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z9
 Ipzhbu0TiMTYPPWlfwGUwZRMX0uIvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALJ8nxPZgDu3hmizXYC/onTrjIQrnQ5M8e1zA17ixLNaiCO
 5FFN2c+BPjGSwBtZmw8IrIjoPyXgCWjXBRdgnCSv7VitgA/yyQuieOwYbI5YOeiWsF9jkue4
 GXc8AzRDhgEOfSFxDGC83bqgfXA9QvrVYRXGLCm+/pChFyI2ndVGBAQTUG8o/Sylgi5Qd03F
 qAP0nNw9+5orhXtF4SjGU3jyJKZgvICc+YPLd0d7Aap8PSK+QuBHWgbRxwdOMNz4afaWgcW/
 lOOmtroAxlmv7uUVW+R+9+okN+iBcQGBTRcPHFZFGPp9/Gm+dhu1UyXEr6PBYbo1oWdJN3m/
 9ydQMHSbZ03hNVD6ai09Euvb9mE9smQFV5dCuk6swuYAuJFiGyNO93ABbvzt68owGOlor+p5
 ilsdy+2tr1mMH11vHbRKNjh5Znwjxp/DBXSgER0A74q/Cm39niocOh4uW8ieRg1a5pZIWexO
 Cc/XD+9ArcJbRNGioctPuqM5zkCl/C8RbwJqNiOBjaxXnSBXFDep3w/DaJh92vsjFItgckC1
 WSzKq6R4YIhIf0/llKeHr5FuZdyn3xW7T6DFPjTkkX8uZLDNSH9dFvwGAbXBgzPxPjf+1u9H
 hc2H5bi9iizp8WlOniHqdNIdAtSRZX5bLivw/Fqmie4ClMOMEkqCuPLwKNnfIpgnq9PkfzP8
 G37UUhdoGcTT1WYQelWQhiPsI/SYKs=
IronPort-HdrOrdr: A9a23:qaPEtqCbFY5b1ojlHegMsceALOsnbusQ8zAXPh9KJyC9I/b2qy
 nxppgmPEfP+UossHFJo6HlBEEZKUmsu6KdkrNhQotKOzOW+VdATbsSorcKpgeAJ8SQzJ8k6U
 4NSdkdNDS0NykGsS+Y2nj5Lz9D+qj9zEnAv463pB0BLXAIV0gj1XYCNu/yKDwteOAsP+tfKH
 Po3Ls/m9PWQwVwUi3UPAhhY8Hz4/nw0L72ax8PABAqrCOUiymz1bL8Gx+Emj8DTjJm294ZgC
 v4uj28wp/mn+Cwyxfa2WOWxY9RgsHdxtxKA9HJotQJKw/rlh2jaO1aKv+/VXEO0aSSAWQR4Z
 7xSiQbToJOArTqDziISC7Wqk3dOfAVmiffIBGj8CDeSIfCNUwH4oJ69PNkm13imhcdVZhHod
 F29nPcuJxNARzamiPho9DOShFxj0Kx5WEviOgJkhVkIMEjgC84l/1uwKp5KuZJIMvB0vFtLA
 CuNrCq2N9GNVeBK3zJtGhmx9KhGnw1AxedW0AH/siYySJfknx1x1YRgJV3pAZNyLstD51fo+
 jUOKVhk79DCscQcKJmHe8EBc+6EHbETx7AOH+bZV7nCKYEMXTQrIOf2sR52Mi6PJgTiJcikp
 XIV11V8WY0ZkL1EMWLmIZG9xjcKV/NFAgFCvsukaSRloeMMYYDaxfzOmzGu/HQ18kiPg==
X-IronPort-AV: E=Sophos;i="5.90,136,1643691600"; 
   d="scan'208";a="64434659"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=aXJ7jbS1eRkaluv0Jf3Irt5o30sQCVAxNP0ecymjj3DRLogBvkYk3j9eu97OTaZYz7RhNn1eJFZiAge9ThSTuTofrf8blOU5zYb3agsh9C4YUHRMWoKpYUY6enNjk6rT3eIsHVbS/MDlxFdQwYMG0hoTBr142Mtfvs9+F5CCgjGpl4VsXcWFQHZZCfEJx9qTfNMFslf4Ll3QtNDc/e3iPWIJAeH+NOre23NVTlB3b5TWRyTUTVYeNHb2AujNyueGQcf0ZA+vHVg5lnZz0Kpe8E73Rnt9a6Tz6vNZnFkcmPMweN6I+BLmR9PapgySPZJ+TGBT/v3FzbSmzoS7RJHF7Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=A28qk6yx7g9PJoD5im5B7qv5gS2TCCS/6xCmjta4UuU=;
 b=neO1mTSapynfhEDyeCQyyYoq6CSy4BTz6y0bP+dGCLQp6Io9if76LnX361qGF3GedEVu3m82CIXTeA0S86MHW662Hjs3GMRiklvELZXxBDuulKi+U8CCsQ3+IrTih/MDOuoatZt+y2gLuDZoHSQnfYbNwi2MrPJyyAj5qE7iaheHog3P67+YR9grXX3MyZhcwPf9K/x6HdAApUflXhiJyiaDtC8x35bYpCp/W20Kic/T+ruzEbFDiFx44kJPNArZNgBI/xWdNYZnh6e9FTJsV8etIjsEY3etBoRL24S+c7MsFJnCiQG1YdBqtDWVBlK4j6i40RmbW0eeh24eD1RbKw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=A28qk6yx7g9PJoD5im5B7qv5gS2TCCS/6xCmjta4UuU=;
 b=eg4zw6GgXu+Jc6WqdIpY/exqpeh7jMqSoHm7gYazct8rdaTJtcvQ095lAVMmu7lQxUMbtsNvGojTK/iuGcR6ig+DqY84EKoMRvyBdFSn5/TvFfB19MlIRIdsskxVigo3EPViWAFat/iMKqFq3205BmViuT0aZkrIIgwQeynuIvU=
From: Christian Lindig <christian.lindig@citrix.com>
To: Anthony Perard <anthony.perard@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, David Scott <dave@recoil.org>,
	Wei Liu <wl@xen.org>, Edwin Torok <edvin.torok@citrix.com>
Subject: Re: [XEN PATCH v2 29/29] tools/ocaml: fix build dependency target
Thread-Topic: [XEN PATCH v2 29/29] tools/ocaml: fix build dependency target
Thread-Index: AQHYKlrZb2DloYmiEUGGLqB4eANGnaykZKqA
Date: Fri, 25 Feb 2022 15:30:59 +0000
Message-ID: <C31BFB15-F511-452B-A249-1D6FDAC5F626@citrix.com>
References: <20220225151321.44126-1-anthony.perard@citrix.com>
 <20220225151321.44126-30-anthony.perard@citrix.com>
In-Reply-To: <20220225151321.44126-30-anthony.perard@citrix.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3608.120.23.2.4)
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: b48568d7-7985-45a5-315a-08d9f873d314
x-ms-traffictypediagnostic: DM6PR03MB4843:EE_
x-microsoft-antispam-prvs: <DM6PR03MB48437D4F3C57608AB52F35D4F63E9@DM6PR03MB4843.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: BLN69EyGw1vxF0yDamA6iOG/nNz81CUnQfdaLb5LJCn4lQTFMXuIEfCJSWoIwsQZqYTkmvoWshgR+/uwJFyDVCIrFSFSue8LQgN17IH57HgP5+7fvuJfUBHkO25+KaLKBom9lEwhIGWbNkJ0nvF7p4HtUSWxuC1AJjPR1edV2XznnS03ZhpHwdn47S75rMmOwRiFnAB3Ljz3i3No9ZUQUcBKzKX2+0inVdSKgSzAeetQGtBjT1kHqklZ3orPNedwknsOUsEPkByb6fZP/42KvZiXxEbXgcgTsXn5Fn7mHLs2sTTWxZKFfwXRHCxPWWsIkINZjKM7QshVu2++CX8Iys4UyTmCv682fodaAtHaRtS9nkSd1hRSbgeZogIMQd0pArpwRovD5kLqIvx6wjaXoOrBvfYd0BB00h9g2qOqJXulQp2Sn8Bd37QmyGMZiufMaFPydzHOb6u9gtEAG4wfHJV1LrIkKmrsNHupPSeEcUW974EDDdx1p1HeAI2VK9i/w16xnWuJqBhDrOhzC7sZDOBGgz1Fl0OdMIan5HMcO7qGb23rTCn8fiYyAM/Gis783KWn/OHiYz5HL+GrhbNevgNSuBYmM655fUMMPonLy416umwKKvezVWq0bBA9Pv/qjs9GEesGdBcxpiW4TRKfqYXOMkTFeUnPdefTe2xIezKCfCWZI3drHjTvmj0ZOFSJJbfsPW/VYZaAMKT8h0uadKpOKO+n2UBh1347pPDi7dQ=
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR03MB6539.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(33656002)(53546011)(6512007)(6486002)(8936002)(4744005)(5660300002)(6506007)(86362001)(508600001)(44832011)(122000001)(26005)(316002)(2906002)(71200400001)(82960400001)(38070700005)(186003)(76116006)(4326008)(66946007)(107886003)(38100700002)(66446008)(6862004)(66556008)(64756008)(36756003)(2616005)(66476007)(8676002)(91956017)(37006003)(54906003)(6636002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?WFo5ZjRFWUFqSUs3eUs5aHdpT0xFbUZ5R3dOVmlOWHFobWVDZlJobGo3NFBl?=
 =?utf-8?B?WlBGM2tXanNWTE5JWmViVlM5b2g4SnZUUmtRZnBEOWk1d0llTEZDN005aHFG?=
 =?utf-8?B?THBFeFZxYmdCNVkvbVZ2NUZlL1NaUnlGdkdkQ1ozNFBod2RJYjBnOTRQeFNP?=
 =?utf-8?B?KzBHbGplV25KeEpYY3UxSlJjcUk1ck5QclNWbDlBcTkrTys2YTJUem5UNUNS?=
 =?utf-8?B?RGNoSjJmTWg5Y0xpc09lajRhOUhBOTlpMXRHaUpXWldqZ0l4d1R4Mjc5Qk1v?=
 =?utf-8?B?Y3g1UlFHVm5XZkFBekRPOG5tbWdvQWdRSlhTbzkySlZiZUJqTE5zZGwxS1Yw?=
 =?utf-8?B?a3Bqb0pPdjU5MU1TdG4yQ3ZBNThKcys3TE1IRlRFMDl0ODVXUUZ1TDFIT3pD?=
 =?utf-8?B?amo0cU51Tkt1Q2tUc3VCc2FMSUFielVnbjBXY2ZIRUVZODZXeVZRWmJaVEtM?=
 =?utf-8?B?bERhYzZRRjVWRTYzT3IzWU5pSk5Yd1R2S2xKMFhUMXJoVFdIYUhJbW94NWNp?=
 =?utf-8?B?YS9pOWxHSjA1VzI4RVZ1ZUg4WkFsVWVkKzlOeTBkcmZyZ2VoUnNSZW1POWd5?=
 =?utf-8?B?cHowRXZXY3RCbmNkZHM5enRLQmZDYjN0UWNJNm4wU2ZFRXlFOFFrTmx0RjV4?=
 =?utf-8?B?OEh1c2s4bEVuLzdhdm9ReTM1dmgrcWhWYXRlOWhtZmZMRlRnSEJ0Qlk4eENj?=
 =?utf-8?B?eU5LbTMzU2VCZXBSWmNzdmgrSkhQZlJ3MVJMcW9RekMvVnFmUHVSYkMvNFpa?=
 =?utf-8?B?ajhYSEpzM3VudWp1UG9ZYjVxdlJ0MytWaEFudXE4cXRXbHZ2RVI5UFlGQVln?=
 =?utf-8?B?eDE0OFMyWEhGS0tYN2VxSVhyZ3lac2dQazMweVRHYWVORzlqR2lEOVc5b0o0?=
 =?utf-8?B?Z21RSDhGRHRGaHBtc1FocGVjZEtienV2eXNTZFFJQktpcFlIRzJNNWdWN1VH?=
 =?utf-8?B?YUF6VURVWkc1YXVGOElTSGdhUk5hTW9BcVF6Mzh0ZUJrOUU2cDVkZEN3WStX?=
 =?utf-8?B?NnBRN3pyZzNIVnN5N2g3OWhaanhITE0wUFl1ZmNrci9kemN1WG5MMnU0UWFr?=
 =?utf-8?B?QzhyMVcwT2s4ZE9MUGVIMVFrK1dzOEc3QkZJUHY2Q0JMUjdNaG5qRmNPdlNy?=
 =?utf-8?B?MDJaNExwa0JFYWREVTBjdzhxT3kvV0Vxc3VBK21jZG50OElBYkI2aWFoNVhK?=
 =?utf-8?B?QVZTYTZTei83amYzeUlrV1N1MnlUOXhjYVhPa0lpbEd4c2o1bnFBZ2ZXcmRq?=
 =?utf-8?B?T0hRTVhheGxvTzBXQjQxNVZLYXFBamU2NGh6VlZ4VHN5TjJNZHB0OFBzdGsz?=
 =?utf-8?B?YWJzUnpHRmhoOFd5UGFLb1NUdUZUQm9BNVBuUEVpaDZ3T1gxZCttbVR6UWI2?=
 =?utf-8?B?ZlhuQlBOVzUrQUNnL2ZtRDZXTlBwM3JPMmJvN1hheHhRVkZObVNxd0lrbHMv?=
 =?utf-8?B?VFRKaHhidmJjSDB6QlY0MmdhUHFUZUt5TStjcjNTRUJjZmNRcXgwTGVpeGxJ?=
 =?utf-8?B?WWExd01nWG55RDdoTFZ1ODM3bnd1aUNnTzd0Y1JKWmFLTGZNc0tBK3V4b3Qv?=
 =?utf-8?B?R0Z1b2p3UWUybFN0N1cwM2FVUFJGWGx4eHhEM3k3MzRaZExGTkVPeW01WXZ1?=
 =?utf-8?B?Y2h4cXlXb3d4K0FqNjJYR3UvRUJGaktoaVZjOTI5ckZOanM2NUl1ZTV4d1hN?=
 =?utf-8?B?eDZmbndjdEp2ZXBUbHRaOXFWdjg1QUw3YU5DMVBnc0lzbkNpTVVUTHNxK2lp?=
 =?utf-8?B?UFpGRldudC9LZzFKS2NSNGZOMThUYkc3ZzhySzlicWh1emRrY0dKaG9Sa29z?=
 =?utf-8?B?bytNbTFNM1FpUk5VVG92SDA4bTE5MmdNRXZtNTJldkVNc0ZwZEF2WGgzSGhI?=
 =?utf-8?B?UEpmUE5BMzk2dXByZitZVHFldlZnaTZyT0NEMWt1Ylg0dzl1WDZCUmFNM1g5?=
 =?utf-8?B?WDB3SVBhd0djeGZ2dDFrQmpNRFVuWTJUZ0tIaGRoSHI5L2hrRXFvSzFqU25R?=
 =?utf-8?B?eHNTbndaRDhFQ3o0UmpzSW5GNUkzNlRFQlBCcVJnR0ZkQ0JlV0FRd2kzM1k2?=
 =?utf-8?B?TkhOZDFKZi83NThMNmtaSVNUZkFlYUlMMHY3bHZ5RVFLYWd2dittMS9VRkpw?=
 =?utf-8?B?K0VIaUsxcGw3ZXdEUjlCZUV1ZkV2bkJEQWdyLzZDemJEbUhEZHFRMU5KNlJB?=
 =?utf-8?B?VXRwWmpncXVyZHlHNkVkNW1QSjJuOFB3ZGRUVlJaZ29mT1lYL3UyR0lReDNq?=
 =?utf-8?Q?NImtvLzW3EZ8qNcbNUwT7AvexLC9zBB5RblHm3yIro=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <F039D4064B0EC84DB1E953D995E3FDF2@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW4PR03MB6539.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b48568d7-7985-45a5-315a-08d9f873d314
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Feb 2022 15:30:59.5566
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: E7d02ZHAC/gNUYEt2Uvstz7KMucQQK8fYsYmEMM2vnmkR2cwZPafUqY1Sd0kZTjR8+iQ0M/u4/FM08OPelrOSiOt01pS0vU5dOnvKTraHYQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4843
X-OriginatorOrg: citrix.com

DQoNCj4gT24gMjUgRmViIDIwMjIsIGF0IDE1OjEzLCBBbnRob255IFBFUkFSRCA8YW50aG9ueS5w
ZXJhcmRAY2l0cml4LmNvbT4gd3JvdGU6DQo+IA0KPiBUaGlzIHBhdGNoIGZpeCAiLm9jYW1sZGVw
Lm1ha2UiIHJ1bGUgYnkgYWx3YXlzIHNwZWxsaW5nIHRoZSB2YXJpYWJsZQ0KPiAkKE9DQU1MX1RP
UExFVkVMKS4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IEFudGhvbnkgUEVSQVJEIDxhbnRob255LnBl
cmFyZEBjaXRyaXguY29tPg0KPiAtLS0NCj4gDQo+IE5vdGVzOg0KPiAgICB2MjoNCj4gICAgLSBu
ZXcgcGF0Y2gNCj4gDQo+IHRvb2xzL29jYW1sL2xpYnMvZXZlbnRjaG4vTWFrZWZpbGUgICB8IDgg
KysrKy0tLS0NCj4gdG9vbHMvb2NhbWwvbGlicy9tbWFwL01ha2VmaWxlICAgICAgIHwgOCArKysr
LS0tLQ0KPiB0b29scy9vY2FtbC9saWJzL3hiL01ha2VmaWxlICAgICAgICAgfCA4ICsrKystLS0t
DQo+IHRvb2xzL29jYW1sL2xpYnMveGMvTWFrZWZpbGUgICAgICAgICB8IDggKysrKy0tLS0NCj4g
dG9vbHMvb2NhbWwvbGlicy94ZW50b29sbG9nL01ha2VmaWxlIHwgOCArKysrLS0tLQ0KPiB0b29s
cy9vY2FtbC9saWJzL3hsL01ha2VmaWxlICAgICAgICAgfCA4ICsrKystLS0tDQo+IHRvb2xzL29j
YW1sL2xpYnMveHMvTWFrZWZpbGUgICAgICAgICB8IDggKysrKy0tLS0NCj4gdG9vbHMvb2NhbWwv
TWFrZWZpbGUucnVsZXMgICAgICAgICAgIHwgMiArLQ0KDQpBY2tlZC1ieTogQ2hyaXN0aWFuIExp
bmRpZyA8Y2hyaXN0aWFuLmxpbmRpZ0BjaXRyaXguY29tPg0KDQpJIGFtIGZpbmUgd2l0aCB0aGlz
IGJ1dCBpbiBnZW5lcmFsIHRoaW5rIHRoYXQgdGhlIE9DYW1sIHBhcnQgc2hvdWxkIGJlIGJ1aWx0
IHVzaW5nIER1bmUgKGJ1dCBpbnZva2VkIGZyb20gTWFrZSksIHdoaWNoIGlzIG5vdyB0aGUgc3Rh
bmRhcmQgdG9vbCB0byBidWlsZCBPQ2FtbCBwcm9qZWN0cyBhbmQgaXMgc2ltcGxlLCBmYXN0LCBh
bmQgYWNjdXJhdGUuIEVkd2luIG1haW50YWlucyBzdWNoIGEgYnVpbGQgZm9yIGFsbCBkZXZlbG9w
bWVudCB3b3JrIG9uIHRoZSBPQ2FtbCBzaWRlIGJ1dCBpdCBpcyBub3QgdXBzdHJlYW1lZC4NCg0K
4oCUIEMNCg0KIA==


From xen-devel-bounces@lists.xenproject.org Fri Feb 25 15:36:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 15:36:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279442.477141 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNce0-0004aG-QR; Fri, 25 Feb 2022 15:36:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279442.477141; Fri, 25 Feb 2022 15:36:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNce0-0004a9-Mf; Fri, 25 Feb 2022 15:36:32 +0000
Received: by outflank-mailman (input) for mailman id 279442;
 Fri, 25 Feb 2022 15:36:31 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nNcdz-0004Zz-DJ; Fri, 25 Feb 2022 15:36:31 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nNcdz-0004XR-As; Fri, 25 Feb 2022 15:36:31 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nNcdy-0004au-Pf; Fri, 25 Feb 2022 15:36:30 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nNcdy-0004ep-PE; Fri, 25 Feb 2022 15:36:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=WCfTWU3tRq3f1cKI+qTy0jqEA3UNDBVTnmPWMtvnOG0=; b=ixT8nPOGTsjJEbtPzFFZs+YvJ5
	HHzmoZs8QSi+/q8neOlVaUp6bqEIaAVW8dd8q8MZG4NyqH9Z4jOIh1UV4CdB+7688QI1UA7r1V+wb
	C3O10ef6d+6TXc/rgqb52HIqTRLKN1VGHnG+FhH5P8Eg0XYAMc27uF3h6JqO3sSMe4kc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168229-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 168229: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=f0f2f42c21de82ff65672e8ecfadcfddc63f2186
X-Osstest-Versions-That:
    xen=9ba4c529985a1773852069889a5b53f2ed26c408
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 25 Feb 2022 15:36:30 +0000

flight 168229 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168229/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  f0f2f42c21de82ff65672e8ecfadcfddc63f2186
baseline version:
 xen                  9ba4c529985a1773852069889a5b53f2ed26c408

Last test of basis   168222  2022-02-24 21:02:59 Z    0 days
Testing same since   168229  2022-02-25 11:00:28 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Bob Eshleman <bobbyeshleman@gmail.com>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Julien Grall <jgrall@amazon.com>
  Mateusz Mówka <mateusz.mowka@intel.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   9ba4c52998..f0f2f42c21  f0f2f42c21de82ff65672e8ecfadcfddc63f2186 -> smoke


From xen-devel-bounces@lists.xenproject.org Fri Feb 25 15:38:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 15:38:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279453.477152 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcgG-0005IV-8L; Fri, 25 Feb 2022 15:38:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279453.477152; Fri, 25 Feb 2022 15:38:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcgG-0005IO-49; Fri, 25 Feb 2022 15:38:52 +0000
Received: by outflank-mailman (input) for mailman id 279453;
 Fri, 25 Feb 2022 15:38:51 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=caTZ=TI=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1nNcgF-0005ID-DT
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 15:38:51 +0000
Received: from ppsw-40.csi.cam.ac.uk (ppsw-40.csi.cam.ac.uk [131.111.8.140])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 06dd7e2d-9651-11ec-8539-5f4723681683;
 Fri, 25 Feb 2022 16:38:50 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:58224)
 by ppsw-40.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.138]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1nNcg7-0010vb-kl (Exim 4.95) (return-path <amc96@srcf.net>);
 Fri, 25 Feb 2022 15:38:43 +0000
Received: from [192.168.1.10] (host-92-12-45-187.as13285.net [92.12.45.187])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 3161E1FB3A;
 Fri, 25 Feb 2022 15:38:43 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 06dd7e2d-9651-11ec-8539-5f4723681683
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <fdab0a3d-42b7-635e-2253-3b1ea8b5900f@srcf.net>
Date: Fri, 25 Feb 2022 15:38:42 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Content-Language: en-GB
To: Roger Pau Monne <roger.pau@citrix.com>, xen-devel@lists.xenproject.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>
References: <20220225151931.99848-1-roger.pau@citrix.com>
 <20220225151931.99848-2-roger.pau@citrix.com>
From: Andrew Cooper <amc96@srcf.net>
Subject: Re: [PATCH 1/2] codeql: add support for analyzing C, Python and Go
In-Reply-To: <20220225151931.99848-2-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 25/02/2022 15:19, Roger Pau Monne wrote:
> Introduce CodeQL support for Xen and analyze the C, Python and Go
> files.
>
> Note than when analyzing Python or Go we avoid building the hypervisor
> and only build the tools.
>
> Requested-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> ---
> TBD: there's no limit in the number of scans here unlike Coverity, but
> each takes github minutes and we are limited to 2000 per month IIRC.
> We might want to not perform a scan for each push.

We don't push very often, and github is slower at noticing anyway, so I
think we ought to be fine.

We can always revisit the decision if we do end up hitting limits.

> TBD: should we also disable the shim build? I'm not sure there's much
> value in analyzing it.

Shim's logic is quite different in areas.  I'd say it's worth keeping.

> ---
>  .github/workflows/codeql.yml | 59 ++++++++++++++++++++++++++++++++++++
>  1 file changed, 59 insertions(+)
>  create mode 100644 .github/workflows/codeql.yml
>
> diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml
> new file mode 100644
> index 0000000000..5bfe478983
> --- /dev/null
> +++ b/.github/workflows/codeql.yml
> @@ -0,0 +1,59 @@
> +name: CodeQL

As a thought... As we're considering doing cross-arm checks, should we
use an x86 suffix here ?

> +
> +on:
> +  workflow_dispatch:
> +  push:
> +    branches: [staging]
> +  schedule:
> +    - cron: '18 10 * * WED,SUN' # Bi-weekly at 10:18 UTC
> +
> +jobs:
> +  analyse:
> +
> +    strategy:
> +      matrix:
> +        language: [ 'cpp', 'python', 'go' ]
> +
> +    runs-on: ubuntu-latest
> +
> +    steps:
> +    - name: Install build dependencies
> +      run: |
> +        sudo apt-get install -y wget git \
> +          libbz2-dev build-essential \
> +          zlib1g-dev libncurses5-dev iasl \
> +          libbz2-dev e2fslibs-dev uuid-dev libyajl-dev \
> +          autoconf libtool liblzma-dev \
> +          python3-dev golang python-dev libsystemd-dev
> +
> +    - uses: actions/checkout@v2
> +      with:
> +        ref: staging

This one doesn't want to be forced to staging.  The github integration
does work properly with different branches.

Importantly, it will allow anyone with a fork of Xen to use the
workflow_dispatch UI to do a one-off run on any branch.

~Andrew


From xen-devel-bounces@lists.xenproject.org Fri Feb 25 15:39:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 15:39:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279459.477163 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcgt-0005pb-GK; Fri, 25 Feb 2022 15:39:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279459.477163; Fri, 25 Feb 2022 15:39:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcgt-0005pU-DI; Fri, 25 Feb 2022 15:39:31 +0000
Received: by outflank-mailman (input) for mailman id 279459;
 Fri, 25 Feb 2022 15:39:30 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ZUh1=TI=citrix.com=prvs=04827bf5e=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nNcgs-0005ID-Bj
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 15:39:30 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1decc05d-9651-11ec-8539-5f4723681683;
 Fri, 25 Feb 2022 16:39:29 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1decc05d-9651-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645803569;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=+K4eMOavg/iyeV+961Gq0YuaDaJFFHfGgzTkbVQTzGk=;
  b=WZDrR3Ne5KcKDNp1A3IC7GNwl+S2IghOlq6mAhUF+1jnHo43ZLKRbqU5
   WHvcdjoMlryADfZ20Uvx1Wua+TFlAYPIZKL/tyA7THioBZm7ePQ4A0x9j
   /oY/YwS38R6RZbFCyO+tnGRVvrx/GYBM/hHppIxvxIkfh5WctNGdmRIxT
   U=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 64892651
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:jUbIxa1gnyGazXCLWvbD5RZxkn2cJEfYwER7XKvMYLTBsI5bpzBRm
 zFMCGqHb/uPYDP8KNglO47n9xsPu5/RzNFkS1NqpC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EE/NtTo5w7Rj2tQy3IDja++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /19h4e9dj0rLJHCt6cWQxRbFCpyMLFJreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHCOo8Ft24m5jbeFfs8GrjIQrnQ5M8e1zA17ixLNaiCN
 5tDN2c2BPjGSy8XB3IbC5QApc6tg3j1ai9Vq3zNtINitgA/yyQuieOwYbI5YOeiXt5Jl0yVo
 mbH+WXRARwAMtGbjz2f/RqEmevnjS79HoUIG9WQ9ONugVCV7nweDlsRT1TTiem0jAuyVsxSL
 2QQ+zEytu4i+UqzVN7/Uhak5nmesXY0WdBdDuk74wGl0bfP7kCSAW1sc9JaQIV47olsH2Vsj
 wLX2YOybdByjFGLYUKv7bqrlzGgBSY6bmQSaCwDRgcI/9a29enfkSnzZtpkFae0iPj8Fjfx3
 y2GoUACulkDsSIY//7lpA6a2lpAsrCMF1dovVuPAgpJ+yskPNbNWmC+1bTMAR+sxq69R0LJg
 nULktP2AAsmXcDUz3zlrAng8diUCxe53N/03Q8H83oJrW3FF5ufkWZ4umAWyKBBaJtsRNMRS
 BWP0T69HbcKVJdQUYd5YpiqF+MhxrX6GNLuW5j8N4QSP8ctLVPapHk2PSZ8OlwBdmB2wMnT3
 r/BLK6R4YsyU/w7nFJauc9HuVPU+szO7TyKHs2qp/hW+bGfeGSUWd843KimNYgEAFe/iFyNq
 b53bpLSoz0GCbGWSnSHoOY7cAFRRVBmVM+eliCiXrPaSuaQMDp6UKG5LHJIU9ENopm5Yc+Tp
 iDtAhIDkQGn7ZAFQC3TAk1ehHrUdc8XhVowPDA2PEbu3H4mYI2167wYeYdxdr4inNGPB9YuJ
 xXZU61s2shydwk=
IronPort-HdrOrdr: A9a23:BQNG4avR7mxxmH2I9b6kNZIS7skC1oMji2hC6mlwRA09TyXGra
 6TdaUguiMc1gx8ZJh5o6H9BEGBKUmskaKceeEqTPmftXrdyRSVxeZZnMrfKlzbamLDH4tmtJ
 uIHJIOcOEYYWIK7/oSpTPIburIo+P3sJxA592utEuFJDsCA8oLgmcJaTpzUHcGPjWubaBJTq
 Z0jfA3wAZIDE5nF/hTcUN1OdQryee78a7OUFojPVoK+QOOhTSn5PrRCB6DxCoTVDtJ3PML7X
 XFuxaR3NThj9iLjjvnk0PD5ZVfn9XsjvFZAtaXt8QTIjLwzi61eYVaXaGYtjxdmpDs1L9qqq
 iIn/4TBbU115rjRBDynfIr4Xi47N8a0Q6n9bZfuwq6nSW2fkNgNyMLv/MmTvKQ0TtQgDg76t
 MX44vRjeslMfuL9h6Nl+TgRlVkkFG5rmEllvNWh3tDUZEGYLsUtoAH+lhJea1wVh4SxbpXWN
 WGNvusr8q+sGnqGEzxry1q2pihT34zFhCJTgwLvdGUySFfmDR8w1EDzMISk38c/NZlIqM0q9
 jsI+BtjvVDX8UWZaVyCKMIRta2EHXERVbJPHiJKVrqGakbMzbGqoLx4r8y+Oa2EaZ4gacaid
 DEShdVpGQyc0XhBYmH24BK6AnERCGnUTHk2qhlltFEU33HNczW2AG4OSUTepGb0oci6+XgKo
 KOBK4=
X-IronPort-AV: E=Sophos;i="5.90,136,1643691600"; 
   d="scan'208";a="64892651"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=eQH6n8Wo3qwydw9x6Kv1ggX0a0qTG9t1S53AKCe5f7+6tltYNxRDi7UkDHRu5wFayQyLn9hJU0VGVkrmTInlmS8gzms1TfzWCdsLikxhhpaHzcBO8pj595Q8DXNmC7KZG+Hqc1EbKoY7NkVV/6Yr4Ax4b+iM9Oj4iUEDL4kw5u1koFjTJ/EhQ56fxIXP/EYtobfbz+zG5PLL0NmVo7RVboSQ/Dv0U37ijrshz1cYHb36UiBHKJfCgBO3fIdvLT3v+vFy6jti6bRrIsFoKvLbhnJV/4ZW/PYZJN4IlVBqWVQ1mYLg5b+adzhlYaOg2Jk54FvTRYTBKbOGoJtKcQmndg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=+K4eMOavg/iyeV+961Gq0YuaDaJFFHfGgzTkbVQTzGk=;
 b=S8TPi9OZyT9q3Wxx2t6Vdonv692MWQMejazOuECPAxeuaeTC3goVeC9uNSkPWl5mIEs3icf7RpS1hLG3j/9hvFCqGg17xv3ff/faslPbWiSuPNm5Y2UhhRkXD0mtTj2GeSfL2YCRcjD6QFa4GnZqCyHRUNm/N2W282A8wdP3FXwdGGip2SuhBBzNVKoI6yxNDAB/bjE8OU5Gws3Jc4TOv7RWYK2cFtsne0Bhf1Q9ZSPSTkeCZFSRPqgkk9c5BUbJS9eN2ocelqXL7T0bzumatyMiW3F0kj8Yb1TYKC2oEN7linYpkteRA1oT0Prn8ff0A0NkQq5ZrO6dDn2PA4AaAg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=+K4eMOavg/iyeV+961Gq0YuaDaJFFHfGgzTkbVQTzGk=;
 b=m2ooqjSBCEPdQG+ljvoLqIvjaALDo7egZlp7HJ5vg1yYhZDEazn+otXUGvpGQ18jUt7C62hlLE26dWsQ9hdWe4P1qybAgv8PQ2ZYM+skvTT7w0ftai2tHqASMDTVRqNMHtnmT/C6klQ16B0AWmtSpGBx9OsmP2M49foquxCBkMs=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: George Dunlap <George.Dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>
Subject: Re: [PATCH 2/2] codeql: ignore Kconfig
Thread-Topic: [PATCH 2/2] codeql: ignore Kconfig
Thread-Index: AQHYKlsow44ghqoZz0KWb0Ee5pJ23aykZwCA
Date: Fri, 25 Feb 2022 15:39:22 +0000
Message-ID: <8b7dc698-3fb2-3ab4-0998-ecfd35935183@citrix.com>
References: <20220225151931.99848-1-roger.pau@citrix.com>
 <20220225151931.99848-3-roger.pau@citrix.com>
In-Reply-To: <20220225151931.99848-3-roger.pau@citrix.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: af4219a8-97cb-4b94-07c6-08d9f874fea9
x-ms-traffictypediagnostic: DM6PR03MB3626:EE_
x-microsoft-antispam-prvs: <DM6PR03MB36263803E28096D93D6EEE31BA3E9@DM6PR03MB3626.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: i4lTVueOJRgxqVQihemcCkr32idIhqlXlvSC/RNUFcXTTbvlSVhtszXkAiY8L56thLhJuNHDJ//JPv8QsAgUFD1STtE07dbM3Z9FxM1Fbvbz0QrMkPx1tAl3WtKPlPiW4BZBD4p5gpn1ebbJHBAQxg+HiYhbf6YzTYnx/uqKAkhBkXBBK7H5DFepYeOIPYyqcGV5wmxejrVcAyUMGV9TZ99qcAAoiweZVfTc/eE093N5wlfS3civRzVap49FJcC8B1Q+kW7kQ73nGdibPfl3YK/k/aoP1pQcaYDCYoPPR4L5Aked/HBkUBxa1u95guouzUSUyQec3o43lM9aKOdi4nH241UYIbouCT0B/9wyB/6iwwFFsjbC7voOQGUqjcVyrAOy9xfIbC1wViDt4bN6bhLf1TNa22Ps06GKuPyMSpC227DGtmaIHkVowfuPjHQhqR57KANsQvyI0ZTKVSULyjUkttdSzeeON30qdd2/KUbayTDM8OPkh7+KxaBSWGeLkjyd/iIVOdwNdOoBV88VeJJpkOPcjuVAjHfUIZM06nA02GitGGevzJS0PJK+w/QkgYh6OkURPvoo7Pn5KNXDFMCDGHaZL1+fOdbnjGmUPtbRjkd+oUzgI35YgZjNsUGXn6/pmhFdlnMlyHaTSQDCosLhLSAOHaB8C4vMSsovzaXCKbzxchFE/K96I8jgdhj+xdxbf7izRKHBvM+OgTS4WyLl+UC09n7UxYkGvIDdrgcdem4uVDy8Q8oHjGielv+TUhW+WO+IbP9y9degjz1tJA==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(316002)(6506007)(2906002)(54906003)(110136005)(6486002)(508600001)(8676002)(8936002)(53546011)(6512007)(66556008)(66946007)(76116006)(66476007)(66446008)(64756008)(91956017)(5660300002)(4326008)(38070700005)(558084003)(31686004)(31696002)(2616005)(82960400001)(38100700002)(36756003)(186003)(26005)(71200400001)(122000001)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?NlhkMUFoRWhGSXpsaE41dFMrdlp4THVCWTNxcnRvRTZ2VC8xTDNpcm5zVlFK?=
 =?utf-8?B?WkdjN2lRU2xDNnJxYlJqL1cyQzVKZEpvTmRDRDAxODhZVFpLMmEycFM2Vlcv?=
 =?utf-8?B?Q0t4UHp3a3ZJai95YjR5S3hGWXZ0QktiODhpWkhXekcvWm14ZGJpditLM3Jx?=
 =?utf-8?B?STJRMHNQTFIzZ0Y4THMvRTZjZExXOEg5d2FQdnkvY2hIcEJ4VStGUWovN3hW?=
 =?utf-8?B?aW82Mm16bDJvRllOZnNxbU1GVkJKVnVtQVdMNUpPYm9oazNJeG14QnNSUUJx?=
 =?utf-8?B?ai9QeFUwWTJpQlVEWFl4UFlDSklsQkpTM2RubElqZ3hjNzJNUWQ2WWlMZ2xK?=
 =?utf-8?B?dG1qYlNjRUs3eFArSGtLZ3E2cmpBTEFhODBYWFdDRDNkaXl2NkxhTVhLUDVH?=
 =?utf-8?B?Mklldmx5aUc0dktrMjdqTG95UGgyeVY2L09hY3Y5czYzdlY3ZFZmL0g1b3pm?=
 =?utf-8?B?WWVtZU1DeVVCRkZXMEp2OUI4emRnOHVxK0JxdU41TFc3czNabkV6ZHV1cUpt?=
 =?utf-8?B?ZjJjVmx0MkhrL3kySmpKTEYxcHdtOXZMRkZiMXZqeENBejRPTHo3WUZKaHFv?=
 =?utf-8?B?NjNRaGtSOG1PMzd0MSt5QXdOZkR3YUV0YTNkajliSWtpMVphZHF2eUtkc3d1?=
 =?utf-8?B?OVRxSkI3YkFZNWRWdG9wSU82Y0tZd0dIYlJjTzdqbTRmSm0yLzB6WExhYzNu?=
 =?utf-8?B?TjYvSUU4aGc3SlN4TWhqSlpzN0trTlFTVzhORzk0L0ZYMmt2Mkx6Nm8waGM3?=
 =?utf-8?B?NWVmSkJ3OE1wUmxiZWk1OG53MmlzSFl3WnhPRENuMGY0akFQekloVitoWFVG?=
 =?utf-8?B?QnkvZ2MzZG9FZ256b2k3cks3MGxNd2RMS0h3YytHQXhLcU5xcHI2Mkdjc2lK?=
 =?utf-8?B?VDVwSHhad1RkWVUzeGxWdFh3YzhtSUtORWZGQm1KNXAzM0xkNlBpbzIzeGRQ?=
 =?utf-8?B?M0g3cW9XUlhRWE91K2UrN2pmTExhNW1WTVFKWGE1WGpEbGk4NTRJTEJzRVNU?=
 =?utf-8?B?V0ZKMUNkK0hjekM5dktQWUpxS3lGWDU3REgwTXpxVjc5TFk4VU1vZ3AwaEVG?=
 =?utf-8?B?ZVZlUjZYTUk5Z08rMm0rSCtSWFFuQzRNQzZxZCs1enNQL1RtM251U2dOTEFU?=
 =?utf-8?B?NmxhaFk2SGM4cU4yTm81b3lmWFE0amM3SzFKRFF3SVVJcVFTeDY5clRSMWta?=
 =?utf-8?B?MVlGUVc5RXN3bGllTVU3ZzJ5RnAzcEVIL2dVR0Z6M2JPRlNjTjM3WCtNOUtJ?=
 =?utf-8?B?b2xaYjlWSms2dEg2T0c1RkZrWkM3UUdkRzhwSEgxZDBRL0h3eDREZjcwWFBB?=
 =?utf-8?B?WitkU1pCdkxsbFZSc1VTMTNLeFNKR1dnM1R4SVlkbUlXTGt1NGxNTGxkS1lw?=
 =?utf-8?B?VEF2bFZmdEhQaEQ5Mm12MVNVS0E3bWpWOTd3Mnp5VkJDQnhGK0phaUQrR1Vu?=
 =?utf-8?B?RXp1cGJvc2NRV080YjVtVCtFMGtYTWVOc05pSUpqOStOdVRDdngyTjhLWElz?=
 =?utf-8?B?MElwZDhZMkdYZ1E0aUxnNjNBelJtRUZUUnQwcGNxOHQ2eWVCUndCdnNkYlZD?=
 =?utf-8?B?c2tLTlYxVFIzK1dmeERxSk15VFVUc1VSdXJoNVJBT2ljcmVQRjZneldCcHFS?=
 =?utf-8?B?ZmlBUGlFZ25aeU1oenNtWXQyVTBoRXVhVCttM1R0eGtRSTQ4OURVMUVKVEVF?=
 =?utf-8?B?RHZSMGd1Y29XWE9zYWllMVFIb2NST2hTZW1XdlN6QjArajlJVS9PSEJIWVlI?=
 =?utf-8?B?SWNVRW5QaWp6S1lCZ2NUTnlOOFYxZzVUQVB0WUdzcEIvMXg2UGlJSW5NeUxH?=
 =?utf-8?B?eSt0aFYxOXdodklqL3N2bE1iUE1EcTRsWC9acTNlRU5adllGSyswbEtvUmtF?=
 =?utf-8?B?UTc2ZEZpUGgvT2JqMlljcEZoRkxCL3k2ODdPcmpReWVFSVYzYmM4ZXAySW1Y?=
 =?utf-8?B?WkhxbDE2aFIwcFM4ZzhMcjRMYlMvOGwyb0ozWEI5KzlzcTdmVGU1cktZNXBB?=
 =?utf-8?B?aVR0cU13OFl4SEsyOExmOWgzN2Vib2s3WmpxRUdGOUVMVHVoZnJNSy9kbFVT?=
 =?utf-8?B?WUxiNmhyVVBTRnRLSnJaTTQzSUgweUY4Z0N1OWJOMUpoQlZyNStlL3JHSVI2?=
 =?utf-8?B?SWplNm9TV1VRcGk0T2w2RFFIMzVhWWRQNGFpam5hN1R4UW8xK0tnUVMrQVJU?=
 =?utf-8?B?bUc4Y3ZpRWJCK0FhRnEyM1IxcE5nUWY5MHFOZmRQci81ZFFPdy82WXNubkg1?=
 =?utf-8?B?U08veW9mSXNhQnY4UTd2dGZRZzF3PT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <22364183D04CA747B69EBB5B9420294D@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: af4219a8-97cb-4b94-07c6-08d9f874fea9
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Feb 2022 15:39:22.0927
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: hdYdXouZXUPhLhCtMq9nWuikt0yI7FbgPyALf/sNy935A4AiU96B7urRIxexH9Ov4U/7qTTehWKlH9qDgUuDM0fOvIRxKydi6dz56lby6HY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3626
X-OriginatorOrg: citrix.com

T24gMjUvMDIvMjAyMiAxNToxOSwgUm9nZXIgUGF1IE1vbm5lIHdyb3RlOg0KPiBTaWduZWQtb2Zm
LWJ5OiBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT4NCg0KSSBhZ3JlZSB3
aXRoIHRoaXMsIGJ1dCBpdCBsb29rcyBsaWtlIGl0IHdhbnRzIHRvIGJlIGZvbGRlZCBpbnRvIHRo
ZQ0KcHJldmlvdXMgcGF0Y2guDQoNCn5BbmRyZXcNCg==


From xen-devel-bounces@lists.xenproject.org Fri Feb 25 15:40:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 15:40:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279467.477173 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNchX-0007Fs-Sw; Fri, 25 Feb 2022 15:40:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279467.477173; Fri, 25 Feb 2022 15:40:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNchX-0007Fl-Pf; Fri, 25 Feb 2022 15:40:11 +0000
Received: by outflank-mailman (input) for mailman id 279467;
 Fri, 25 Feb 2022 15:40:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Zfiy=TI=citrix.com=prvs=0484f4aa7=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nNchW-0005ID-Pj
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 15:40:10 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 35f42b01-9651-11ec-8539-5f4723681683;
 Fri, 25 Feb 2022 16:40:09 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 35f42b01-9651-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645803609;
  h=from:to:cc:subject:date:message-id:
   content-transfer-encoding:mime-version;
  bh=g1MzI94IsfiVMIInuKuZHybLDc3Vy+sXaMWZ+g/T0Uc=;
  b=QDeMbZOrNSJT2WVmJxu50FU+e/cfVm1SJJ9TLACcrEwt8YprAACb9RqH
   ZlVbE6Qc8aB6gChy2MDUz0iDuF1DXdJme1quJTjIkFRtopKjT+NTqcqTy
   iW1bGQZMU12LkFEQZiV6lYQxovv4vwYjW5ZUl8GP3VtHjkuwzwlrQA9d2
   U=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 65409743
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:CmJS9aKFpS1efbFVFE+R2pUlxSXFcZb7ZxGr2PjKsXjdYENS3mNWy
 zYeCD2PPfbZYWf9f913aYzioUMB6p6EzIMxSVdlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA148IMsdoUg7wbRh2NQ12YLR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 NodrLzgZyMWB4DFpsgUUAkINgh4YIQTrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBNPsM44F/Glp0BnSDOo8QICFSKLPjTNd9Glt2pgfQqqFD
 yYfQWJqVRLLfBFhBlAKCbsck+Clr0jBNCIN/Tp5ooJoujOOnWSdyoPFLNrUYZqLXoNcxkKDo
 WTu8GHwAxVcP9uaoRKV/3TpiuLRkCfTXIMJCKb+5vNsmEeUxGEYFFsRT1TTnBWiohfgAZQFc
 RVSo3dw6/hpnKC2cjXjdxLouV7UkDojYvdZLcEz6xHd74PSvi/MUwDoUQV9QNAhscY3Qxkj2
 VmIg87lCFRTjVGFdZ6O3uzK9G3vYED5OUdHPHZZFlVdv7EPtalu1kqnczp1LEKiYjQZ8xnUy
 ivCkiUxjq57YSUjh/TipgCvb95BS/H0ou8JCuf/AjPNAuBRPtfNi2mUBb7zt6cowGGxFATpg
 ZT8s5LChN3i9LnU/MB3fM0DHauy+9GOOyDGjFhkEvEJrmrxpiH/JNwNuGkmfC+F1/ronxezM
 Sc/XisLufdu0IaCN/crM+pd9exwpUQfKTgVfq+NNYcfCnSAXASG4DtvdSatM5PFyyARfVUEE
 c7DK66EVC9CYYw+lWbeb7pNgNcDm3FlrUuOFM+T8vhS+efHDJJjYexeawXmgyFQxP7snTg5B
 P4Eb5rak0gECbamCsQVmKZKRW03wbEALcmeg+Rcd/KZIxogH2ckCvTLxqgmdZAjlKNQ/tokN
 FnmMqOE4DITXUH6FDg=
IronPort-HdrOrdr: A9a23:XPmJA6BB+GlJ/TPlHehEsceALOsnbusQ8zAXPh9KJyC9I/b2qy
 nxppgmPH/P6Ar4WBkb6Le90c67MA7hHP9OkPMs1NKZPTUO11HYVb2KgbGSpgEIeBeOiNK1t5
 0QC5SWYeeYZTMR4LeYkWuF+r4bsaa6GcuT9IHjJhlWPGVXg/YK1XYENu/XKDw+eCB2Qb4CUL
 aM7MtOoDStPVwRc8SAH3EAG8zOvcfCmp7KaQMPQ0dP0njEsRqYrJrBVzSI1BYXVD1ChZ8k7G
 j+igT8ooGuqeuyxBPw33Laq75WhNzi4N1eA9HksLlcFhzcziKTIKhxUbyLuz445Mmp9VYRid
 HJ5ywtOsxigkmhCl2dkF/I4U3NwTwu43jtxRuzmn34u/H0Qzo8Fo5omZ9ZWgGx0TttgPhMlI
 Zwm06JvZteCh3N2A7n4cLTah1snk2o5VI/jO8oiWBFW4d2Us4dkWUmxjIaLH48JlO61Gh+e9
 MeTP00pcwmO29yVkqp8VWGm7eXLzcO9hTveDl2hiXa6UkVoJlD9Tpp+CUupAZwyHsDceg22w
 29CNUSqFhvdL5gUUsvPpZ2fSOIYla9My4kdljiZGjaKA==
X-IronPort-AV: E=Sophos;i="5.90,136,1643691600"; 
   d="scan'208";a="65409743"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=dofb7jKf81jrfgbMa36Q0dYCqn27hZjf5dzHQyY08ITMuvwn4lzu03jzWDo67A6bN2TDSFslFH9bbiejrgV7fW40ljMJ4a0//Ey01twg5xs1jS8Vd7PXXHCbHJc9Lisx8vw/u1cKK2EkTMlQkiwN4Agwb5sfhfUW2cL9YDtFyQrjbcslWVq6QPQhiDLoJ4Ia7zvnQM6/NzRAJ+JJOSXx+XxYctD6SiFvrRA1m/k1O2otnkvvNP0rWYhftnbdLBDLNbnPefvH6yItWiNU5gkK7eh2sLm5fzJPxKQXbTzF/v40gRYaydpxgJ//grrhza0uFMEl4OeIybob7mYTFs6Tgw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=2UvduzblfSFq8jsCANaC3GfwcTReX1ZLErddJKkA9AQ=;
 b=AWA5VHNPT9giPJvW0CsYL5av8ZURrHZ8fTKgnriehS4oAPzLfzq4VBGDXyGMU4cnrWd4daWuk8X7KVlM3h/VWWUiscPb9N7pZpCcsv7leAk3QqbqhK29uH6YnzDabO/g8/+vZrn2ek7VwdnRuqkzFJENQ9o0mopyXR/y48cDF2OJK1uM+/NGfVlazj/mcnxaQBEmQEC4kKmgrg1Z0lGANg4/vMahR5nvcTQxff7sggtKleIk88xLVjfjFX0EsbuLeOtKORudmHYlD/t5yRH3kphQQwzlGV8RHDEDodPMAlesHy9fgA253X7uEp9aIMwDh/mQmtasJc17phyy/Z4X4w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=2UvduzblfSFq8jsCANaC3GfwcTReX1ZLErddJKkA9AQ=;
 b=hg55IgwCaZCEZPN6tm57OOU2MN8cPUn0uh+NU79u8e8kNVrT/sBBsJIk8KzZ1D/tfYdMQwOcw1kWAO8rHWU3JyvZnRD66J7Kc3xFIf2GUMrysmzDQrT9v4oolR5v0p5rAlqIONjTyZ2StCHlz5nH6717CFm9SVa7CbNNeztPbd8=
From: Roger Pau Monne <roger.pau@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Alex Olson <this.is.a0lson@gmail.com>, Roger Pau Monne
	<roger.pau@citrix.com>
Subject: [PATCH v2 0/2] vpci/msix: fix PBA acceses
Date: Fri, 25 Feb 2022 16:39:54 +0100
Message-ID: <20220225153956.1078-1-roger.pau@citrix.com>
X-Mailer: git-send-email 2.34.1
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO4P123CA0174.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:18a::17) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: df0125cc-c681-4391-bc0b-08d9f87517c6
X-MS-TrafficTypeDiagnostic: SN6PR03MB3982:EE_
X-Microsoft-Antispam-PRVS: <SN6PR03MB3982E518B0773EA91DB982A88F3E9@SN6PR03MB3982.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: +vnxgOFocCTc0CGB98KejT5bkqwxZVi26rgOp83rO+eIkTz5PTE7TabnQYrTDcjrS9ZnrjmbFsl5oQ5ARcCx2bzvebgKcTcmNg7gkxNisglTvxdn16Pz/R+y6//Ez2PcJbaqbaSDCLNeQ4uvCBfIU7OlToNhC62KOEGIStCl65VleBLx8Z+WnniLbMcWDNsdYt17o5D0xGil7cd2zMtJUDB26yVc59AlwW7UwI7GC2GwIlQ0v6Hcre+z1SZpqpRvIDdTlWRXy1cVe1HTvJjhMj15d2A6yNPUWwpMljvCdE3E2cNUJLCCOShTM9G3/SQPPBpwJ9ycL5U4Kd1TsSX09cvoIhX9xLqiq/u99LByStMfUpaEGmCWh8jPAyxXuGMtGVJrBw2KOEU989jnp8Kd334nKcFKnhkxw/m4IU4NKKKj1oXlVZGKjPXL2+PwRN7/eXgs3e7nGILAFKb8+BUgdbhtR7uSnYgtrgH1TH9Lgr/xtPaWxYgRpBDyxhYWzbvnnIvrfha70IJnAGSAt3eYTNnbMQ/yiHxnMdRODOKLADnpz/bBfeoxYTBDj/XweyqfsDuYJMKiYkVzyiqNfFpGXxDipsBU6nxW6TRsGEPMcbV+0WYTUJc6AQgzxShsH+X6+lmGXb/besVLoS4yIBYx5Q==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38100700002)(1076003)(82960400001)(6916009)(83380400001)(6666004)(54906003)(86362001)(2906002)(26005)(8936002)(107886003)(186003)(36756003)(316002)(6486002)(66476007)(66556008)(4744005)(5660300002)(508600001)(2616005)(8676002)(6506007)(66946007)(4326008)(6512007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a015eXNSTEFYejRYTXFvaTdVQ0pwTitOTDZkYk42dzVNeEUzMGxiSTN3ZXpw?=
 =?utf-8?B?MFpBOHIvK3dwcWtwZEZJbDZjbFNaRDFWSHVzaEFyMHg0cUxGd3FkVjhDZXhX?=
 =?utf-8?B?cUMybGhLOW1CQ01KMnpJMC93YWIrdG1HTms5VUlWc2hrREsvL1pKM1FEWGl4?=
 =?utf-8?B?dnluRjZhdk1ObmdxWFYrczQyVkpxeHdDeXdaM3BjMVBhMm5ISkhyVTFmbFRR?=
 =?utf-8?B?Q0pMdGM0NGZwaG9haTQyNzlpeE9XWDhpYURBWlRIR0FyNkdxVVNZTDI0dEVs?=
 =?utf-8?B?b1JMbDdyTTQxSDhGUERsT01nZVJBNTkzL0wvZFR5UVB2dkhITnhoSk9Qemtm?=
 =?utf-8?B?c3hhRVZOek4wZ2NNeldtWVA3ZmxWaUVob0NHUXpPRWd2akwybnl3UWtwOFlh?=
 =?utf-8?B?SXE1elI3L1BXU2h0eDNaRStWKzF5MEkvOUNhbUlmZnNlUEhyZVJ2QnAvVU93?=
 =?utf-8?B?ZG5UVzd6L2tlQ01xVE1NK1hKQVlpTXY0RU96KzVQWkFHVCtNbVFDTTZzUEgr?=
 =?utf-8?B?Mk9vdEdXeCt6elF5ZEg2cURKVWdYM0V3NTE4MnVSbUdYMzlPcWp2UUM3QUFR?=
 =?utf-8?B?amtGSlNoM2lUTnFUa2tQRjZuM1htZSs5SVFXcktmMmg5akVKSi90dXpCVXdV?=
 =?utf-8?B?N1llcEVpQ052VUp2RXNKc3BVUmRxL2lFeHVJQ1pCME95a1I5WWt0SzB6ZlR0?=
 =?utf-8?B?di9qU0JQdjdzR2VOWUtJMkVDUFdCK0xFb2lTejhhODdGYjhmOVNHWHAvVzBl?=
 =?utf-8?B?dmZDU2F1VlZDNDl3THlVWlk0V0hOdWhweUJzT1dYOVY0S0hYajBRbjR4Q2xY?=
 =?utf-8?B?KzdUZVJmWUdqK0NDbm9hWE5LcEJqTjczRHZsb3QyQVNJMzZJbFlpMDhlV0p0?=
 =?utf-8?B?WThyZWx2bHZIeXRqbFBQQ1pKc083NllMRlhDaEdJRTR0MnJJYWpzSTV6WDBv?=
 =?utf-8?B?Q2pJekNGT3BEYUlHeEhNM1VVUVkyOWVpRUxQMk5XRG1YTmJGaFBqVXNMZjE5?=
 =?utf-8?B?bnhES1dNMzZvRVVqWWNjc0RSNGVISVIvNnlFRDhQWW50NFRFRTI1OXBTNkxz?=
 =?utf-8?B?b20xeG91eWRNVjlyaklFKzg5NzM2aEpxVENCV3hJNGhyMDRETTZLeU45MjdO?=
 =?utf-8?B?QmJtQ2tVeFVTRFA0enI5Rms4empSQW5mUXBwRDJ0ZXBkV2NYTU9oWjkvcUtp?=
 =?utf-8?B?dXhQUC9RTGFmN2F3UzNBNHRqelR3TWRsU2U3SUQwZTBnM0VUQkRQL0dQcGZl?=
 =?utf-8?B?c2x3R1NNSDRCMVdDYUFTUmxNZXRGYWQxc2FSSXdhQjd5M2FYdHowOGNFUHV5?=
 =?utf-8?B?VWUwVHNVRkJvcEtyUWRKY2k4TG5iaWR0SmRVaDNrRGNFamszOVY1RG5DMU5T?=
 =?utf-8?B?SG1xamQzN2ZMdFJYZWZ6Zjc5WUxoZHp2UlVTTnhzU20wT2pZN25BOWl2ajVi?=
 =?utf-8?B?WTNZdFkwL3l6aTk1RmR1TXFQWnhUamY0NEN4ZHpWWDdxQll6aXpWVFRoOWVw?=
 =?utf-8?B?bmhUeWlpL200N0xxaUlpcEcxZTVwNDRRR05PQ1I0RWlOYWd5MmNZb3pYZzhG?=
 =?utf-8?B?RS9MZ0dFdjJhVmIrVXhkMlR4NU5BdHRZTHZJY3VNUUVuNkl6WktHOTI5QW84?=
 =?utf-8?B?dTFnQnhHZUNZeUh0bENieVpUOXJDSzFLdU9uWHBFenR4UHZ5K2NoWWxwM3Nz?=
 =?utf-8?B?QmxsWHVsa3V2bmIzZUFScWNWR1dKeXdtaEwrNnhuVDRETGRsdUViWEhPWnha?=
 =?utf-8?B?S2tUa2c4RTVWNEp5dm1NN1NnNlNkSlovWk0vWTZ4Z1VMcm1IVTJoYXN5T2pJ?=
 =?utf-8?B?VUNJNURzaTVVaEltamlEWDJTeVN0ZUdMYlRVWVVmRkJWTUU2eXZLT2UyZkNE?=
 =?utf-8?B?YjRxSm5DMXg2NTlFdDExZ1BjWUlIeWxnSlk5T3dTMDI3SEk3MnlIaVpCY01C?=
 =?utf-8?B?ZHN6SmlrMDMxZW1ha3JBS0VOdDJ6UnE4R0VWZjc1M2xXMmJsOWZkS2FYQ3R6?=
 =?utf-8?B?N3gxZkVMdThaVW44V1l2RnZleVJxRGMrY3k4VEl1TVJUYSs2eFZQb2tLc0NT?=
 =?utf-8?B?bHdLckY0R1k2TlBZZU1sTlZEWkdHOEhwdVdBaG1DcW9ITWxmYmpkbzNBS1ZL?=
 =?utf-8?B?N2hiMnNJWUdPWDk4SE9iaHBiTHdrWXlrdFV2ejVsMTZpcGExYVpFSW0rNE0y?=
 =?utf-8?Q?STIUVkqLuuCSIlMeUmZi8Eo=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: df0125cc-c681-4391-bc0b-08d9f87517c6
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2022 15:40:04.4178
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ndCD/PS+nMGm3Q7WQwC7OLg7l0m/XkDvz11GsG0MIr9D/WRvhisGdpV5IJrRtLKcLYMuuyyE7s1PqyquN8YilA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR03MB3982
X-OriginatorOrg: citrix.com

Hello,

First patch is just a preparatory non-functional change to reduce
indentation. Second patch is the one that actually fixes access to the
PBA.

Thanks, Roger.

Roger Pau Monne (2):
  vpci/msix: reduce indentation in msix_write PBA handling
  vpci/msix: fix PBA accesses

 xen/drivers/vpci/msix.c | 78 ++++++++++++++++++++++++++++++++---------
 xen/drivers/vpci/vpci.c |  2 ++
 xen/include/xen/vpci.h  |  2 ++
 3 files changed, 66 insertions(+), 16 deletions(-)

-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Fri Feb 25 15:40:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 15:40:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279468.477185 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNche-0007Yu-5R; Fri, 25 Feb 2022 15:40:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279468.477185; Fri, 25 Feb 2022 15:40:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNche-0007Yn-1l; Fri, 25 Feb 2022 15:40:18 +0000
Received: by outflank-mailman (input) for mailman id 279468;
 Fri, 25 Feb 2022 15:40:16 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Zfiy=TI=citrix.com=prvs=0484f4aa7=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nNchc-0005ID-JM
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 15:40:16 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 391bd44e-9651-11ec-8539-5f4723681683;
 Fri, 25 Feb 2022 16:40:15 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 391bd44e-9651-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645803615;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:content-transfer-encoding:mime-version;
  bh=8CnV1YFo7Tb5Y161XjRmYx5MERlsmjdyjjYLhh+ReR8=;
  b=W2gANz99Pq1EQMyZHvwrg+fqJZx4GoEDkLrcQ7g2ycW3xStfSbfFol2H
   46usqkvRJu659J5tjs843Nb8JS5EvL8TOKXBGQYZ7cgTYxsL0KxJUsSg7
   Wzx1eVVEJx3o8Y6WZ3vTxD0UuDd/CNSPANpnju8oQNhbA7o0EQZwgqf9x
   s=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 65000615
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Olo6a6Igte+8JZNxFE+R2pUlxSXFcZb7ZxGr2PjKsXjdYENShDFTz
 WFKWGrVMveOYGSme9t2aNu2/BgHsMTXxtJjQQJlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA148IMsdoUg7wbRh2NQ12YLR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 MxQiI2ibS0xApDngu4geUd9OSZeB5QTrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBNPsM44F/Glp0BnSDOo8QICFSKLPjTNd9Glt3pgWQ6+DD
 yYfQSdKVQzCQxFxBmgOS5w6vsiF3liuKAQN/Tp5ooJoujOOnWSdyoPFLNrUYZqLXoNcxkKDo
 WTu8GHwAxVcP9uaoRKV/3TpiuLRkCfTXIMJCKb+5vNsmEeUxGEYFFsRT1TTnBWiohfgAZQFc
 RVSo3dw6/hpnKC2cjXjdwSlnW+WmjQEZ+d7CecHwl+o4K302T/MUwDoUQV9QNAhscY3Qxkj2
 VmIg87lCFRTjVGFdZ6O3uzK9G3vYED5OUdHPHZZFlVdv7EPtalu1kqnczp1LEKiYjQZ8xnUy
 ivCkiUxjq57YSUjh/TipgCvb95BS/H0ou8JCuf/AjPNAuBRPtfNi2mUBb7zt6cowGGxFATpg
 ZT8s5LChN3i9LnU/MB3fM0DHauy+9GOOyDGjFhkEvEJrmrxpiH/JNwNuGkmfC+F1/ronxezM
 Sc/XisLufdu0IaCN/crM+pd9exwpUQfKTgVfq+NNYcfCnSAXASG4DtvdSatM5PFyyARfVUEE
 c7DK66EVC9CYYw+lWbeb7pNgNcDm3FlrUuOFM+T8vhS+efHDJJjYexeawXmgyFQxP7snTg5B
 P4Eb5rak0gECbamCsQVmKZKRW03wbEALcmeg+Rcd/KZIxogH2ckCvTLxqgmdZAjlKNQ/tokN
 FnnMqOE4DITXUH6FDg=
IronPort-HdrOrdr: A9a23:+2hXFam4qlAkMUL0DNIQD7OknZnpDfPIimdD5ihNYBxZY6Wkfp
 +V8sjzhCWatN9OYh0dcLC7WJVpQRvnhPlICO4qTMiftWjdyReVxeRZjLcKrAeQYhEWmtQtsJ
 uINpIOcuEYbmIK/foSgjPIa+rIqePvmMvD6Ja8vhVQpENRGtxdBm9Ce3em+yZNNW977PQCZf
 6hDp0tnUvfRZ1bVLXxOlA1G8z44/HbnpPvZhALQzYh9Qm1lDutrJr3CQKR0BsyWy5Ghe5Kyx
 mJryXJooGY992rwB7V0GHeq7xQhdva09NGQOiBkNIcJDnAghuhIK5hR7qBljYop/zH0idhrP
 D85zMbe+hj4XLYeW+45TPrxgnbyT4rr0TvzFeJ6EGT1/DRdXYfMY5slIhZehzW5w4Lp9dnyp
 9G2Gqfqt5+EQ7AtD6V3amHazha0m6P5VYym+8aiHJSFaEEbqVKkIAZ9ERJVL8dASPB7pw9Gu
 UGNrCS2B9vSyLbU5nlhBgt/DT1NU5DXCtuA3Jy9vB96gIm3UyQlCAjtYkidnRpzuNLd3AL3Z
 WBDk1SrsA9ciYnV9MPOA4/e7rDNoW0e2O2DIuzGyWvKEhVAQOEl3bIiI9FkN1CPqZ4i6cPpA
 ==
X-IronPort-AV: E=Sophos;i="5.90,136,1643691600"; 
   d="scan'208";a="65000615"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jeReTPUdOael0apFxFejlRkY4U3ONSJp1KAgTpV3S1LL4deGgIzdNzPM4cjM3j1X+xSsYCklBCwudF8vUVeW1KfCff8UcneTnCt9l8kdHSf/qMHRxFDASw/knFpxYc9e+zkysmzBwYLxFtRvNQSoR3C1CDohPJY2f0rgveKokS9yWYJ8d8FXKGLK9OzXXp7AvRfNntDk+QtzrErUuRtVjeSDXy23ON5tAORPc5/HLmqtL3fFf59XwDPFBLITY1Xv/razPSg8a14AcbGUqZxU8D4ZIUHp1xqwU9GIE3FBEcozaIArVIEvul6xspmdJLLWyZlFtgAgIhpJaGI5wJKHbg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=6xQx3p2gIUoOaj3d39MS75urWwINz7VNe9IUM3IGjb4=;
 b=GfnsmJ7mXOiBfypO4BPJ/ujEsTqW2eefbBeM3we05cJRFcsqzKAIgDB3b4cb9I/a7JlEtPyyUM5BPextIeEbzXq+o56eFYsgJHcrdzamXVmu6nzZArpZbc6yRPNe/J0HWKWaS3AEcxUuVyGwzTc8cO0VuRgDFGCV3ojJKeER7VoOgiz6Zya8uR3gqMf3LRA7wDpkiipKexgonb+AQKgxmy/a/ayipUGURki0kuw8o42s4eQkYy3dNhJZcD1cpYEzDwRuHONc7U0bYLaMxfuvrNj9rIKacVMs71UKmgeDMA0f4HW+F142GfG3g5nbq1tUikoT6RuhWFruCbzDHndKNw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=6xQx3p2gIUoOaj3d39MS75urWwINz7VNe9IUM3IGjb4=;
 b=GidsEg8DFSXjBL1Tol9f9BWi1b8hc5h8ZT8exLV7/5Cf+etkDxAlgOL4yCehOrox0sLjhSfRNJFmbQZfsdfD+KQbBdYVeVTlVAWzFERrc/gF9ZyX96VR5xEhrokdLERiRXxvur+p4xa+fW/Icw/TxPl66y7r0tRmbnx5e5HwhpA=
From: Roger Pau Monne <roger.pau@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Alex Olson <this.is.a0lson@gmail.com>, Roger Pau Monne
	<roger.pau@citrix.com>
Subject: [PATCH v2 1/2] vpci/msix: reduce indentation in msix_write PBA handling
Date: Fri, 25 Feb 2022 16:39:55 +0100
Message-ID: <20220225153956.1078-2-roger.pau@citrix.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220225153956.1078-1-roger.pau@citrix.com>
References: <20220225153956.1078-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO4P123CA0324.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:197::23) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 019e133d-9591-4d66-7409-08d9f8751a94
X-MS-TrafficTypeDiagnostic: SN6PR03MB3982:EE_
X-Microsoft-Antispam-PRVS: <SN6PR03MB39825A984702F7AD78C802D28F3E9@SN6PR03MB3982.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: S47bMAshBVi46FtOzdks/NOl01WwW67ADrmZD5p7cKYx2HDGU1nfSc/5EhC1+NA+Ak36baT7sGKyeFySNLUCurOk0iTgj68+zgaUYRvxWhjK5urDkjQhk236kr8m3tre8fsJ/sg+/lIGPR4ULC7/7u014f35g6RYpE1Eu7kqWYyw40SExhCbFKIi+aYHDUVZ7gjiHhCHFFwWZjs8SuQ9xRclJAMz9N2Hpn4De+puIf0yM75l476QeUKX0a3/Bo6NOzVqV0l27E/0ycQAuqfO24kffl86BJoLhJDMf1epcTRf5mZ4oDVZuZqSpi9F3yTEvAH5I8gVnkP71n2up2UXK1YDs2qH7cfUzG/R/4poBEBUDcHr0yHQUz2L9HY1nsTktJ/qa8WEaHCD120emdDnLVDaIkHdbZqa6QGasNmUWN+hh2Qy4RK/mP24NZaZOpA03el+I3nFEN53ANXG8+wLNU29GiaBNz0St3cbuP4w4JqPXpslvkP5uvPPil5FHqKJpJCRLQkwhl8bI0imUnsiGeuLDw7HtYDtgIq8SUQ0liLptdWwr2i0kZ5VmxhCnAUTmBZkFC0edZanrL4/fV1YSeY1e/Hm7Yw963xkPGqKb/IreQfdY3MFKShHEA19q6wXCqf/szbfVKqNAa6eTB/ZGg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38100700002)(1076003)(82960400001)(6916009)(83380400001)(6666004)(54906003)(86362001)(2906002)(26005)(8936002)(107886003)(186003)(36756003)(316002)(6486002)(66476007)(66556008)(5660300002)(508600001)(2616005)(8676002)(6506007)(66946007)(4326008)(6512007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ckFwSUlKMUhNdDJhZ2N5aHJFNy8xejQvNEtIa29CNEpsOU9Sa2lJd0RyWlA3?=
 =?utf-8?B?d2RZcFc2OWwrQmRHVFFBbEdZZUZJWS9Pc1BvWkErK3p3VDNvMjZubzZpVHhQ?=
 =?utf-8?B?TXBIM29zeDNqMW82RDFONUgwc2dwT2U2TjN0K2xGZWF3dllyM2h5VWp3Ty9n?=
 =?utf-8?B?d1hVcnc3bDZ4OGlUb1BiUm5Id0VCZ1ZZZHVqUUJDblRzd3Y4QW9BU0VzNzF0?=
 =?utf-8?B?Yzd5WWVENDA1TWNMWGFWaFczWkVBaGtXVnB4Y0htNVJFK2ZNeGhuRURIMjdX?=
 =?utf-8?B?NWVIT2pwRG4yRHQwUmRZZ0hrbThaK2RsaWdXbDZaUllodk84M2hpVUFCUG5w?=
 =?utf-8?B?NlZEUHFFZmw4aDRZdnZVZFladDVIOSt2Q2ovRkJralVaM053aHBKZnFSd20y?=
 =?utf-8?B?cmtsT0FydklVazdwdHdLU1BiV1ZPamdKalJUWUpyRk4zTlJ2dTlRWjdpa2xK?=
 =?utf-8?B?TkVBZlYvSmVIUldSemw1eWF4aCtleVhKdnZaakpLUDZVam5QU3liVzdZbjVj?=
 =?utf-8?B?UXNmQkxEMjVieFFhNFpvemRzSWdGcWdWQmU4QVI2TlZPTHI1S1U2bHNLQUVi?=
 =?utf-8?B?YnhVcW54QUg5dVkwZGpSTzZuU0ZxQjRHZkhKaDZSaTlRa05KcVV3d08zM3Iv?=
 =?utf-8?B?emtWRkJheGZ5ZVAzaWlUS0J2UjJ1VXF0STJGMWxiWXRkRk9oVHJib082aDBW?=
 =?utf-8?B?dXRSMnE4Qi9MenlqckJzclZQbGhGcjBlTnhwRENpQTNKWFRBSjFyK1JBb3kw?=
 =?utf-8?B?NmZ6SXlMdnM4MjM3ZlBZSlI2eEJSOGFhaHRQMlYzOUdCL3ZzUkYwOVgxaVBF?=
 =?utf-8?B?U3laQkNIdmNZeXJYR0lZSm5wMEpackdSdDNaQTR4aTVwbFAyY1dHME4zQmJl?=
 =?utf-8?B?QU8yVkEzZzE3K20wMmxPaUFHZmRiYUt5R25DZDBxSjI1NFdDeXhtNHgvZGdP?=
 =?utf-8?B?ak9lOG1Ba1hhYUpRdENhUUVHRkhUWnZjZ1J2aXROTFM2OVVmQlp0ZmtwNENP?=
 =?utf-8?B?cU9ydVh4aG9yS2V6R2t0blF6TVg5UVFBMVppdEhvQVNTbk1zeS9qSTE3SjZC?=
 =?utf-8?B?c2U3b01HTlVOeUR3OFQ5bkF1RmkwK2FQY0txZzdVZ2NoNG9BZDdwZ0VFWmt0?=
 =?utf-8?B?bDh0NWJxZ0M3c1JUKzF1TjRtZ0VWWUNSbmZyMDBBRFc5dGNhc3UyMkt3RGJ3?=
 =?utf-8?B?MHY0RngvUWM3VllRLzVOSENuZDF1cHFxdEV0NTdZRWlabGUwaWV2dWtKSFVC?=
 =?utf-8?B?S2hSQTFnejRsTnNhelprK3lSZzdiS3ljVGZ0SFpqK2RWQUwra09WbjgrR1ZT?=
 =?utf-8?B?czBwU1lhR2d0SEhkcmRzYjFwV3FsS3k0cXFMV3JSVkNnSWx6c01nbkhtQVZ5?=
 =?utf-8?B?YVFaU0t6RGo4M0dSTkVaV0xjR1ZhckRyUzRjeFZGU2ZQNTdaMlB1UXZxQU94?=
 =?utf-8?B?SWp1eXFYREVqMDJsaEl1L1hOWUFhQXozbFRta3VXQ1JlOWJEK1JJVUxOaThs?=
 =?utf-8?B?NmVqRlBJamIyeVlueFJhemdleUlxRTVyQnVhS0xsTWIyU29IVi84cFVoNTF2?=
 =?utf-8?B?Tmo5U1BsQUdBYld5UWEycjkvNzIvTzU2dTJhM0MwajJDaGFHN3FrVWVteFV1?=
 =?utf-8?B?VklGelpvRDZqQnRiOHk4QWZYUW9wRFM1aUZldFRSczNhRGZWdmg1MmttZGdK?=
 =?utf-8?B?QXZ3aDY5VDBSWTgvSVVRdVpISUF1MkRIQjJVUkRDWWlZZVpPWGF0NUVBSFVH?=
 =?utf-8?B?R3FCT3ZWSHhGMjZFZUpmSCtiTzUxQS9YSW5TMkc1RjAwYitva3QvcDFiWkRE?=
 =?utf-8?B?RklqMzl3MHJ0N2N2QzdRRGhJUlU5UjNsWVlYRVMwdFJZdDl0ZHRLa3VnZWJ1?=
 =?utf-8?B?aHdlQ0ZJdWZ2YWg3R3pyaHM1amthU3hubTBpbFF4Snl5bkgrdXZlcGFzS09U?=
 =?utf-8?B?eDkzUTlWUzUzSFVZNVpObW9zSnpycGREbUdNQjBZQmJxUE9BQTlNRjU4WVEy?=
 =?utf-8?B?bUdoMDd4dnNydkR3TStUc2s3MEI5SkplV09xL1RvU2VGcVhhMXdqOUw5RTEy?=
 =?utf-8?B?RFVYdEZ5eWpsSDRmQjQwUDBHOGlTV0dYaGVpMms0TjdGeTJneFkwMHRWY2Rz?=
 =?utf-8?B?VnN0VkVDTmhhMDVaUlp4RDZWLzNielFqWThnRHNOY0V1Y05QMUtGTkQrOEM2?=
 =?utf-8?Q?9RQqnJbfl3VnyCS3zyGSFzk=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 019e133d-9591-4d66-7409-08d9f8751a94
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2022 15:40:09.2009
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: h3/FX7Q4cgDwcv4otIBIBF6NVElerJVn7GaIDjzqhYSEAZmlo+dY9SR6DPpHH9GJjj/HgLKLGlH0w25Uaz7Cjg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR03MB3982
X-OriginatorOrg: citrix.com

No functional change.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
 xen/drivers/vpci/msix.c | 29 +++++++++++++++--------------
 1 file changed, 15 insertions(+), 14 deletions(-)

diff --git a/xen/drivers/vpci/msix.c b/xen/drivers/vpci/msix.c
index 2ab4079412..a1fa7a5f13 100644
--- a/xen/drivers/vpci/msix.c
+++ b/xen/drivers/vpci/msix.c
@@ -275,23 +275,24 @@ static int cf_check msix_write(
 
     if ( VMSIX_ADDR_IN_RANGE(addr, msix->pdev->vpci, VPCI_MSIX_PBA) )
     {
-        /* Ignore writes to PBA for DomUs, it's behavior is undefined. */
-        if ( is_hardware_domain(d) )
+
+        if ( !is_hardware_domain(d) )
+            /* Ignore writes to PBA for DomUs, it's behavior is undefined. */
+            return X86EMUL_OKAY;
+
+        switch ( len )
         {
-            switch ( len )
-            {
-            case 4:
-                writel(data, addr);
-                break;
+        case 4:
+            writel(data, addr);
+            break;
 
-            case 8:
-                writeq(data, addr);
-                break;
+        case 8:
+            writeq(data, addr);
+            break;
 
-            default:
-                ASSERT_UNREACHABLE();
-                break;
-            }
+        default:
+            ASSERT_UNREACHABLE();
+            break;
         }
 
         return X86EMUL_OKAY;
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Fri Feb 25 15:40:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 15:40:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279469.477197 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNchi-0007sq-Hc; Fri, 25 Feb 2022 15:40:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279469.477197; Fri, 25 Feb 2022 15:40:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNchi-0007sR-AT; Fri, 25 Feb 2022 15:40:22 +0000
Received: by outflank-mailman (input) for mailman id 279469;
 Fri, 25 Feb 2022 15:40:20 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Zfiy=TI=citrix.com=prvs=0484f4aa7=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nNchg-0005ID-5Q
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 15:40:20 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3b7dea83-9651-11ec-8539-5f4723681683;
 Fri, 25 Feb 2022 16:40:19 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3b7dea83-9651-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645803618;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:content-transfer-encoding:mime-version;
  bh=PKNPsUAVRvnP0bndWK3m9763yhv4YFhHq5tw/1e77Uw=;
  b=LE0klMiuiM0cxmffbjhfr0/IKogmaichF5Bhd97yEDDKNFWxMkjQxTeA
   yJNtqqM1zENPiXOEwUwB9CnBxgRT3jBp+5YuAW7WdG3wiZOOTdHel/L8F
   33H1dwW25plkOcTHJgYxiZFgspybm5R35209K9iK+B68VfPW0NeVLUAdz
   o=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 65002456
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:iLo4PqPVS7KXPh/vrR2Bl8FynXyQoLVcMsEvi/4bfWQNrUp00GRWy
 GFKXGGCaaqLMWv2e9x1bo3i8ksFu5WHy9BjSAto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFcMpBsJ00o5wbZj2NMw27BVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z1
 fBziaCrciUTfaTNls44VglWGgcvBPgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALNs7kMZlZonh95TrYEewnUdbIRKCiCdpwgmpo3poSQKi2i
 8wxcBVpXgz6O15zHko7V54ujdeH3UChbGgNwL6SjfVuuDWCpOBr65DvOtfIft2BRe1Og12V4
 GnB+gzRHhEbL5qe0nyMqna3gennkibyWYZUH7q9ntZ6jVvWymENBRk+UVqgveL/mkO4Q8hYK
 UEf5mwpt6dayaCwZoCjBVvi+ifC50NCHYoLewEn1O2T4rfx3TqlHVMmdH1IadIMkcomSzUMh
 2bcyrsFGgdTmLGSTHuc8JKdojWzJTUZIAc+WMMUcecWy4K9+d9u13ojWv4mSffo1YOtRVkc1
 hjX9HBWulkFsSIcO0xXF3jjiinkmJXGRxVdCu7/DjP8tVMRiGJIiuWVBbnnARRocNfxorqp5
 iFsdy2iAAYmV8DleMulGrhlIV1Rz6zZWAAweHY2d3Xbyxyj+mS4Yadb6yxkKUFiP64sIGG1P
 RCP4F8MvMcLZBNGiJObharrWqzGKoC6SLzYug38NIISMvCdiifdlM2RWaJg9z+0yxV9+U3OE
 ZyabdytHR4n5VdPl1KLqxMm+eZznEgWnDqLLbiilkjP+efONRa9FOZeWHPTP79R0U9xiFiMm
 zqpH5DRkEs3vSyXSnS/zLP/2nhRdSlrXc2t8pcPHgNBSyI/cFwc5zbq6epJU6RunrhPl/eO+
 Xe4W0RCz0H4i2GBIgKPAk2Popu1NXqjhRrX5RARAGs=
IronPort-HdrOrdr: A9a23:pjBg+a8doP2Nw4QSlyluk+E6db1zdoMgy1knxilNoENuHfBwxv
 rDoB1E73LJYVYqOU3Jmbi7Sc29qBTnhOJICOgqTMqftWzd1ldAQ7sSi7cKrweQeREWs9Qtrp
 uIEJIOeeEYb2IK9PoSiTPQe71LoKjlzEnrv5al854Ed3AVV0gK1XYfNu/0KDwSeOEQbqBJa6
 Z0q/A37waISDAyVICWF3MFV+/Mq5nik4/nWwcPA1oC5BOVhT2lxbbmG1zAty1uGQ9n8PMHyy
 zoggb57qKsv7WSzQLd7Xba69BzlMH6wtVOKcSQgow+KynqiCyveIN9Mofy9wwdkaWK0hIHgd
 PMqxAvM4Ba7G7QRHi8pV/X1wzpwF8Vmgjf4G7dpUGmjd3yRTo8BcYEr5leaAHl500pu8w5+L
 5X3kqC3qAnQi/orWDY3ZzlRhtqnk27rT4JiugIlUFSVoMYdft4sZEfxkVIC50NdRiKpLzPKN
 MeTf002cwmMW9zNxvizypSKZ2XLzkO9y69MwY/Upf/6UkVoJh7p3FosPD30E1wsa7VcKM0lN
 gsAp4Y5I2mcfVmH56VfN1xOfdfKla9Ny4kY1jiaGgOKsk8SgfwQtjMkfEI2N0=
X-IronPort-AV: E=Sophos;i="5.90,136,1643691600"; 
   d="scan'208";a="65002456"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=lwcSFqdMIJhPibQL3kKzcBIiWcSyFaZbsukoEYGlWaUp9c0+k5xE34SvUJwqshuqgb8o5CppxWbKBCZfxmc3QxaEYFqSLflGFWCbT+G+DaLE0rYCdLOpXXFcFVjwqYqL/2pCxeuXPFHvkWv+2gd/jFzXLQVYjRiYbE9Miz+pd2PQ3dQJ6UfSpYHXTX0L8cOk+08JXKdbQ+Zc6BSyqntH7bK/boCqpIACoxPf/gKH3B5jv8FXFITEgLs5JWkXqj796ZT/Zdg35BEL2nJLViCD6Lw8nOBkyLrCRwhpPaWd+OtdnTqOB1uN01/BfLUXYurNdUDifiK0iBuK3wqQ2uJlLA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=NQfSCOTOAbixao4uPBP8gOpZAnH8IT6a2fwSzdK0eqA=;
 b=itGqQrbV0vRP+wppWeoQ4NH2DrfYbptbjFdF4XF4lYSBm00O9FyhZdNqjOFrfT8aTovP1A1AsLkKFcxwyGPu1tD8TMmVbXPGHss4bS1714pzhaSMa5HYQiihnJqEsoRFhy1ZwR62xqyGrDcqLl7TT4nUY8BtKnHiiMjAPx8issFXcUr2RUtT9pzO324EMJEFTSwCN1XInRNV59NL51WZRtMqy7hNNZ6vsHF2UmnrHPIh8h2QFFPvqH1sQz0hmN31q85dIYixWMqqgJS8zxhel/AEtLuwoaKnclE2w0NpfQMliIH4+wOUeVX01OEHZq8Tk2SAFGt92HkDLhezVz4O6A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=NQfSCOTOAbixao4uPBP8gOpZAnH8IT6a2fwSzdK0eqA=;
 b=S6DqQWhnAmORM976B9ASfaW+nMf7T2ewscm+xpRHmukanZz/4rXAe6yemSfmxeYCCvLOQpce98UsrYrkxD4aH8gaPRPHABvmr6v0yBAGm5z8O207rZ/F4mpD0wlD7/MsAIMGzM2eo5ufNdE22I7SFFw/ryfGs2nyrst1lBe6RzA=
From: Roger Pau Monne <roger.pau@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Alex Olson <this.is.a0lson@gmail.com>, Roger Pau Monne
	<roger.pau@citrix.com>, Jan Beulich <jbeulich@suse.com>
Subject: [PATCH v2 2/2] vpci/msix: fix PBA accesses
Date: Fri, 25 Feb 2022 16:39:56 +0100
Message-ID: <20220225153956.1078-3-roger.pau@citrix.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220225153956.1078-1-roger.pau@citrix.com>
References: <20220225153956.1078-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO4P123CA0131.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:193::10) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 8f0a5903-821e-46e2-66ee-08d9f8751dc4
X-MS-TrafficTypeDiagnostic: SN6PR03MB3982:EE_
X-Microsoft-Antispam-PRVS: <SN6PR03MB398206BA5E36077BCF3B71468F3E9@SN6PR03MB3982.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: Wbt13kLn8Fwcd0NK4EL8ek8xPH0MHAhU04pR0ay1DStH9FyNX1A2fGCCnT/YwWylAF8h1Ka/WsJKfbqsud9WHLWQmmpQyZkflCBLY67iKTRIykvB50CUjrNIyxO5FV4qcsbON60DPAlg54+gNOG0DYF3rX25Hwh9/wGAhbqKC+rVCSj+6SUJkXz9KlSlJ3kHFDst+yOK/ZaNPNw3oEfypM8e8iz97EKlSJ0wkg36iSbTMxvxuKSniYKAt0ITxxK82PsRubG5/g15BbGBxd85AU97xnI8GA8zYzI96zZMGF+SsgYVidNhJtY4Qy1TYyHzIwsivNgjzAfeD1IsFMv0MYKgTRU1Cx/D98veHLwwBAHbmsa8ASgOzzM5GUWXZUV5IVsZE27Qf/pDH9NLN/MEAgPRHJeloR/JZ4iiW8fIRq3D7TpNk07LTIsoMvQNzc6m9Vqwg4iQFcRMFbzU3DR9t75G27fA8SxLKTEj5J8bT1ZBjeYQrxBXt4YhGg5oWmHYzNq0gP56/SPzvDexZpHzVvdJ+wXdT6eukNX2+4+SLaX/ZZRHF406F+p62/c/+wJRsQuOYhGQffDsCKtqpWebi0L3Tk+n3aCxdcUIDaA6AyN4otgL9yIuAHhC1Le5lo+HIcAjZQtLHtDaaa/EbV59PA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38100700002)(1076003)(82960400001)(6916009)(83380400001)(6666004)(54906003)(86362001)(2906002)(26005)(8936002)(186003)(36756003)(316002)(6486002)(66476007)(66556008)(5660300002)(508600001)(2616005)(8676002)(6506007)(66946007)(4326008)(6512007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S2JRcWJYNHFKK1B6M2JHbUZWeTBLbkZXcGhTdkROYytDZWp5RTU2OFlVQzhR?=
 =?utf-8?B?aVVQZ2VsWFJhRFRvNEp4UDcxcU1JZ0wvQlBVbHZ6WnhXZVdmbURVbXBXaXVv?=
 =?utf-8?B?azJqSzNtUDlrc08wVW0vSEhXRlZVRW5DMVhXSkFXUTdsUWJsSDR2MGEzM0Vs?=
 =?utf-8?B?TDd2cUpMeEVSd1ppeGJWY0xnNS83aThON2NPQ2tlWjMrZ1dHMHgrTCs2bFBP?=
 =?utf-8?B?dFRpd2dETWJ6RzN6MGh6YTRFdnFuRXc3T2lZMkNEOG8vekQ3N0JaSEZLRUx6?=
 =?utf-8?B?UlJNdUZEOWJuR2VFUmJ3bG1QeTBQZGUzNVR6L1BvWHprT2xuSUxYV0NZMFB6?=
 =?utf-8?B?Nkl4S09VUVBXaE1oTk04L2hRMkZnSFEvOVhBenFqTE1BRnpLT1VvV09DNTRo?=
 =?utf-8?B?b29lblM3M0ZoY25OM2pmRUxYaVpYU0ZjRFMzdWdtQ2RBcXp2YWUrOEV4Nmgz?=
 =?utf-8?B?ZXpqbkVmM3FqNDl3RWdSbTkyaERPeCtxNnI1VDVPcjFmSXpYUnZ5K2FqL0hq?=
 =?utf-8?B?SjZ5KzlTVU9pV3ZxYWxSd0xjYWJlL2luTFYybzk5d0F6c3hRb1JVMldSMDJm?=
 =?utf-8?B?VHB4bjNFdWZydU55TXJuYXdMV1FZcHBhSWIxTUtieHRGZEJQdXRmeCtVa084?=
 =?utf-8?B?NVlWM05URUd6TVJaUXczL2RPSHpQcWhZdnJDTjQxMjRtTGhGNTIvQ2tzRjha?=
 =?utf-8?B?UUlpcUQyZHMzcnlYckhYZi9ocmxjRXZ3VTF6UVJNeDZta2VSVjVtVFdNL0o1?=
 =?utf-8?B?enkrV3FsaXg0MDhBNzI2Ny9IUXUyQURUVG16MHdhTzlMaUJpWnJPS1pPbE80?=
 =?utf-8?B?bTllQmNyZXBhblBpb1plRlNzbkN4aWJpU0ZnZGErd0d1Q3NCaXFxbFRJTUpa?=
 =?utf-8?B?NWtpcVkzbkZ1Y09Cd2VYbnZUalk4OXl6MHc4UUk1MXJ0YlgvT2w4S2NPMVg2?=
 =?utf-8?B?VERlMWNEd2xEWWhBUVlXN1hrdG8zSVBjVTFPZnZrMHFvOWJmRHdUV092RW9M?=
 =?utf-8?B?Zi9hNWNzWnA0V0dURUtGUEg2U1BvTm8zcDFjRWNPeHN1MmxmZ21PS1BlQWZM?=
 =?utf-8?B?REZFR3VPTFl3TUVXQmpaZ1BmcTBsV0pmWWdaUEx6Zjk3WHg1ZFFsMW9KZmFH?=
 =?utf-8?B?bExoUzFFbnczRjdLNlEwSFQ2cG9HVktqZUJ0Q3pLNGdDcWljT1BVc3FsVHpy?=
 =?utf-8?B?cGt0Y05DL2lrTHN0VEpFWVF1Y2t4V1FJNWxLSFBPVTJ5R2JDbGxSOHlnalMw?=
 =?utf-8?B?WlkzS2g1ZDFwdUdnR3NRem1oNXo1dXMyZXVjRUFYQ1Z6NUl6L2NGTGtCdGNB?=
 =?utf-8?B?RkpvNUhLZUxWeWhIdmtQNTJ6T2gzQUp3bk5YbmJMVCtNN0JVdGZUNzRPQVJt?=
 =?utf-8?B?SHU0SUpSWkQrYy9yNkFlUWxQUWNPc3JkcE5QbXpDZ1pYekFBUVVJdkErVlNI?=
 =?utf-8?B?QWxCazVWbmRYb0thTGFCTFN0ZjdrNVNGaHpybmFQUGNpT0t5Y1llUmVIdStl?=
 =?utf-8?B?d1U0a0ZEY2NyTE1Qd2lhakV2bHVGcTZzUmh1c1hTN3hvSjJoa1ZnS29LT1h5?=
 =?utf-8?B?OGo1RDlaZlc0YklKMk51QjJSRUxjYW00NXQ0WUhUY3MxQ1V6TGJOcTZhcHU3?=
 =?utf-8?B?eVNuYTBYZEZtM2Y2SWU0VHNIZm15NENaR3dWSzVyRzFXQjhkbGE3QnlvNEVL?=
 =?utf-8?B?Y3MwV2wweTgzaUtSbGROZHYvM1YxU0N4SmFFR0l2bEJsQWVzR3NISlZpY2ho?=
 =?utf-8?B?RE84M2VlRElyd3MvQytvRHFFb3FGb280VGVxaVI3ODdWYUN5ZjdRbEhXSk1u?=
 =?utf-8?B?cXVJOVk4ejBrOVEwRTJKNHY3N3kwaGNmWVVyMGx0RHVtSTVoOUlaYVpvMFF2?=
 =?utf-8?B?N0xueGtNV0lpWnZrL1VwMFU0blZGU2ttSGM3bnVKMEZLRjAzOFIzMzVKSnFV?=
 =?utf-8?B?UUlzSWtNWU43UlhjNzdWQXZvSzR2T0QrSDJubU5DTHhVVkRZcytZeVVQVDd6?=
 =?utf-8?B?VnhFTjZxV2xQVHFoU1YvVmx1WThqbmd3K2FjbFltR1ZzSnRPYmEwRkpjeUV1?=
 =?utf-8?B?TFZZa1V3dG1PeS9PSS9QcDRwUTNuMEtHanV3QVBzcm52QkkzM0RqT2craXJl?=
 =?utf-8?B?ajA1cjJUbklYVjNLQlRPdUFRZys0V25SbFlzeDh5YVdEWi9UaWMrUjlBeVZj?=
 =?utf-8?Q?hI2pmLaJN4Gjy8G4njuKai4=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8f0a5903-821e-46e2-66ee-08d9f8751dc4
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2022 15:40:14.5002
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hFxBudelBJC3FU9hBW/E82GLXa5kjgP2QlxAIoja7rDGvZADcHof/qVQK9bASV7vN+DmmYGU70HmahFdAVJYhQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR03MB3982
X-OriginatorOrg: citrix.com

Map the PBA in order to access it from the MSI-X read and write
handlers. Note that previously the handlers would pass the physical
host address into the {read,write}{l,q} handlers, which is wrong as
those expect a linear address.

Map the PBA using ioremap when the first access is performed. Note
that 32bit arches might want to abstract the call to ioremap into a
vPCI arch handler, so they can use a fixmap range to map the PBA.

Reported-by: Jan Beulich <jbeulich@suse.com>
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Cc: Alex Olson <this.is.a0lson@gmail.com>
---
Changes since v1:
 - Also handle writes.

I don't seem to have a box with a driver that will try to access the
PBA, so I would consider this specific code path only build tested. At
least it doesn't seem to regress the current state of vPCI.
---
 xen/drivers/vpci/msix.c | 55 +++++++++++++++++++++++++++++++++++++----
 xen/drivers/vpci/vpci.c |  2 ++
 xen/include/xen/vpci.h  |  2 ++
 3 files changed, 54 insertions(+), 5 deletions(-)

diff --git a/xen/drivers/vpci/msix.c b/xen/drivers/vpci/msix.c
index a1fa7a5f13..9fbc111ecc 100644
--- a/xen/drivers/vpci/msix.c
+++ b/xen/drivers/vpci/msix.c
@@ -198,8 +198,13 @@ static int cf_check msix_read(
     if ( !access_allowed(msix->pdev, addr, len) )
         return X86EMUL_OKAY;
 
+    spin_lock(&msix->pdev->vpci->lock);
     if ( VMSIX_ADDR_IN_RANGE(addr, msix->pdev->vpci, VPCI_MSIX_PBA) )
     {
+        struct vpci *vpci = msix->pdev->vpci;
+        paddr_t base = vmsix_table_addr(vpci, VPCI_MSIX_PBA);
+        unsigned int idx = addr - base;
+
         /*
          * Access to PBA.
          *
@@ -207,25 +212,43 @@ static int cf_check msix_read(
          * guest address space. If this changes the address will need to be
          * translated.
          */
+
+        if ( !msix->pba )
+        {
+            msix->pba = ioremap(base, vmsix_table_size(vpci, VPCI_MSIX_PBA));
+            if ( !msix->pba )
+            {
+                /*
+                 * If unable to map the PBA return all 1s (all pending): it's
+                 * likely better to trigger spurious events than drop them.
+                 */
+                spin_unlock(&vpci->lock);
+                gprintk(XENLOG_WARNING,
+                        "%pp: unable to map MSI-X PBA, report all pending\n",
+                        msix->pdev);
+                return X86EMUL_OKAY;
+           }
+        }
+
         switch ( len )
         {
         case 4:
-            *data = readl(addr);
+            *data = readl(msix->pba + idx);
             break;
 
         case 8:
-            *data = readq(addr);
+            *data = readq(msix->pba + idx);
             break;
 
         default:
             ASSERT_UNREACHABLE();
             break;
         }
+        spin_unlock(&vpci->lock);
 
         return X86EMUL_OKAY;
     }
 
-    spin_lock(&msix->pdev->vpci->lock);
     entry = get_entry(msix, addr);
     offset = addr & (PCI_MSIX_ENTRY_SIZE - 1);
 
@@ -273,27 +296,49 @@ static int cf_check msix_write(
     if ( !access_allowed(msix->pdev, addr, len) )
         return X86EMUL_OKAY;
 
+    spin_lock(&msix->pdev->vpci->lock);
     if ( VMSIX_ADDR_IN_RANGE(addr, msix->pdev->vpci, VPCI_MSIX_PBA) )
     {
+        struct vpci *vpci = msix->pdev->vpci;
+        paddr_t base = vmsix_table_addr(vpci, VPCI_MSIX_PBA);
+        unsigned int idx = addr - base;
 
         if ( !is_hardware_domain(d) )
+        {
             /* Ignore writes to PBA for DomUs, it's behavior is undefined. */
+            spin_unlock(&vpci->lock);
             return X86EMUL_OKAY;
+        }
+
+        if ( !msix->pba )
+        {
+            msix->pba = ioremap(base, vmsix_table_size(vpci, VPCI_MSIX_PBA));
+            if ( !msix->pba )
+            {
+                /* Unable to map the PBA, ignore write. */
+                spin_unlock(&vpci->lock);
+                gprintk(XENLOG_WARNING,
+                        "%pp: unable to map MSI-X PBA, write ignored\n",
+                        msix->pdev);
+                return X86EMUL_OKAY;
+           }
+        }
 
         switch ( len )
         {
         case 4:
-            writel(data, addr);
+            writel(data, msix->pba + idx);
             break;
 
         case 8:
-            writeq(data, addr);
+            writeq(data, msix->pba + idx);
             break;
 
         default:
             ASSERT_UNREACHABLE();
             break;
         }
+        spin_unlock(&vpci->lock);
 
         return X86EMUL_OKAY;
     }
diff --git a/xen/drivers/vpci/vpci.c b/xen/drivers/vpci/vpci.c
index f3b32d66cb..9fb3c05b2b 100644
--- a/xen/drivers/vpci/vpci.c
+++ b/xen/drivers/vpci/vpci.c
@@ -51,6 +51,8 @@ void vpci_remove_device(struct pci_dev *pdev)
         xfree(r);
     }
     spin_unlock(&pdev->vpci->lock);
+    if ( pdev->vpci->msix && pdev->vpci->msix->pba )
+        iounmap(pdev->vpci->msix->pba);
     xfree(pdev->vpci->msix);
     xfree(pdev->vpci->msi);
     xfree(pdev->vpci);
diff --git a/xen/include/xen/vpci.h b/xen/include/xen/vpci.h
index bcad1516ae..c399b101ee 100644
--- a/xen/include/xen/vpci.h
+++ b/xen/include/xen/vpci.h
@@ -127,6 +127,8 @@ struct vpci {
         bool enabled         : 1;
         /* Masked? */
         bool masked          : 1;
+        /* PBA map */
+        void *pba;
         /* Entries. */
         struct vpci_msix_entry {
             uint64_t addr;
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Fri Feb 25 15:47:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 15:47:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279496.477207 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcoN-0000py-Ff; Fri, 25 Feb 2022 15:47:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279496.477207; Fri, 25 Feb 2022 15:47:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNcoN-0000pr-Be; Fri, 25 Feb 2022 15:47:15 +0000
Received: by outflank-mailman (input) for mailman id 279496;
 Fri, 25 Feb 2022 15:47:14 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Zfiy=TI=citrix.com=prvs=0484f4aa7=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nNcoL-0000pl-Uv
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 15:47:13 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 31d9db39-9652-11ec-8539-5f4723681683;
 Fri, 25 Feb 2022 16:47:12 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 31d9db39-9652-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645804032;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=loGFyJwM+XwR3P9i5ZVFpp7f5j+1dFNkkb9zZFsjBzw=;
  b=TR8+MSTBiVBKZKf8GvvgjigI0URJEJ9BwFYHMQK+d5hPSJNWcdOWFdM0
   lSZ3PW6hzK4rMptAYb4QDFKrf6txChyhpm8Y91kceoB3A/RyP4dC3jXRk
   eb81o6QV6noq50CsYX27WQLJae16qYPhiryXBVXsHL5AXiCYtDgTeNZjq
   I=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 67269168
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:poInTaKefz5aWqFUFE+R9ZUlxSXFcZb7ZxGr2PjKsXjdYENSgzcCz
 GMeCmCCOPeMY2X3L95yYd7g9EsHv5bRnN5mHgRlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA148IMsdoUg7wbRh2NQ12YLR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 M1hm8KIWyASB6P3orpDejhdGWJOILITrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBNPsM44F/Glp0BnSDOo8QICFSKLPjTNd9Glv3J4fRKiOD
 yYfQRl3XU7POQ1MAUlNCIBjlcPwtEfPcCIN/Tp5ooJoujOOnWSdyoPFINfTP9CHW8hRtkKZv
 X7duXT0BAkAM96SwibD9Wij7sfTnSLgHoMJUrTg8uVthnWcw2USDFsdUl7Tifuzh1O6WtlfA
 1cJ4Sdopq83nHFHVfGkAUf++iTd+EdBBZwASIXW9T1h1ILMzyjHPnojdQdPU+Z46uYXQDZp5
 kKWyoaB6SNUjJWZTneU97GxpDy0ODQIIWJqWRLoXTfp8PG4/tht00unosJLVffs04arQW2YL
 yWi8XBm74j/m/LnwElSEbrvpzu37qbEQQcujuk8djL0t1gpDGJJimHB1LQ60RqiBNrIJrVil
 CJd8yR70AzoJcvc/MBqaL9QdIxFH97fbFXhbadHRvHNDQiF9X+5Zpx36zpjPkpvOctsUWa3P
 BKM5VoNuccLZCPCgUpLj2SZUZVCIU/IT4mNaxwpRoAWPsgZmPGvpkmCmnJ8L0iyyRNxwMnTy
 L+QcNq2DGZyNEiU5GHeegvp6pdynnpW7TqKHfjTlk37uZLDNC/9YepUazOmM7FmhJ5oVS2Iq
 r6zwePRkE4BOAA/CwGKmbMuwacidiBqVcir8JUMLoZu4GNOQQkcNhMY+pt4E6RNlKVJjObYu
 Ha7X05T0l3kgnPbbw6NbxhehHnHB/6TcVpT0fQQAGuV
IronPort-HdrOrdr: A9a23:vMWk46oppDH6tC2+WJMByccaV5vHL9V00zEX/kB9WHVpm5Oj+P
 xGzc526farslsssREb+OxpOMG7MBThHLpOkPMs1NaZLXLbUQ6TQr2KgrGSoQEIdxeOk9K1kJ
 0QDpSWa+eAc2SS7/yKmTVQeuxIqLLskNHKuQ6d9QYUcegDUdAe0+4TMHf8LqQZfngjOXJvf6
 Dsmvav6gDQMEg/X4CePD0oTuLDr9rEmNbPZgMHPQcu7E2rgSmz4LD3PhCE1lNGOgk/iosKwC
 zgqUjU96+ju/a0xlv10HLS1Y1fnJ/ExsFYDMKBp8AJInHHixquZq5mR7qe1QpF6N2H2RIPqp
 3hsh0gN8N85zf4eXy0mwLk303a3DMn+xbZuCulqEqmhfa8aCMxCsJHi44cWADe8VAcsNZ117
 8O936FtrJMZCmw0BjV1pztbVVHh0C0qX0tnao4lHpES7YTb7dXsMg24F5VKpEdByj3gbpXXd
 WGNPusqsq+TGnqLkww5gJUsZyRtzUIb127q3E5y4OoO2M8pgE786MarPZv60vouqhNCaWs3N
 60QpiApIs+P/P+UpgNd9vpYfHHfVAlEii8Rl57HzzcZdM60jT22tvK3Ik=
X-IronPort-AV: E=Sophos;i="5.90,136,1643691600"; 
   d="scan'208";a="67269168"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Yqxjpxw8kDzv3/Gv2fNX9ZAU3ZigskmPF11lxlXE0nE4VlHpdvsl+v5uPLRnpi0mycaChifYO3RZKg4IBRmfIN82GHg6HXWQolCFDGlomp9hSWHHRs4KH+GcETMUfxFWHd93RBTsWOYZAMwE8xiu7FSdwFyegz4BVwgsCW4PpCBeiVgw61XXx56OhwMqDfWgzm0Q31otmHeqKXpWAY9zf7DxvwwgKgW8l8mElG7vYl0xQ4vphafXwYtWPRjdPXktkHwEnX+r+osEeJJNBX7s0nV8bTBeBhX2NMoG9BpnvtKSQf62gunV4H4w+V4vkYIREA6lOZx9O2n8kkDbqY4oGQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=JMwwkm+CmVlz7ID6wMu0ZzsE4q/CT+KGXGDH/hWKlwk=;
 b=NUXZIFz+r9HlmJZAHNaSXfBiFFdaLNu2Ncu9mWXnqnMCNkK6rzWgnCpqo9W7oV3lKtAHiIgQEEU9+dUHwH6NWRranTwPse0/HchvIhIZLkEyQIbgoQv33OxBsdQYVlJRJrZWp8ObANeSvG4K/SvL+uD4Hob7/HyJYpCThXJXHz3vRTCt/ZEg/GjXtMvkKRDbIv5TUd0bep8HxpalJLd0vtIt1r8daHGGkd0P3e0gcjDsYhZwF9GMVUywNIiDBlDcc2HkXIEav/4fKC0T3/UD9WkpPXj8MZT/Tht3o4Y7Wh9qtZXCPzEbgHu/0l0JFwpvZ+fdYXVxA5B35pQHJ0iYkw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=JMwwkm+CmVlz7ID6wMu0ZzsE4q/CT+KGXGDH/hWKlwk=;
 b=ZR+38If7Ekb63IM4wml9nzFt+3Zf3QQzyt5Uo1Dw7rEQAK3Ll4sSsgPMDTwaLWZ8SHcQkICapvoHrWIr/7Ccd3g9MrH0/9teUYEL/F8FiTwylNJZbCCRhEJ1b1Tnmb2/ikO5UMeBUCiePC3IH0HpNKAmP4VoVBT0WhLjYyi9FYk=
Date: Fri, 25 Feb 2022 16:46:56 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Alex Olson <this.is.a0lson@gmail.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: Re: PVH dom0 and MSIX memory mapping issue
Message-ID: <Yhj58BIIN2p4bYJ8@Air-de-Roger>
References: <c33d1731b054a488974f96b8171b7b1b5aa61b4a.camel@gmail.com>
 <a96d555c-8540-1f83-f110-a47904e74b55@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <a96d555c-8540-1f83-f110-a47904e74b55@suse.com>
X-ClientProxiedBy: LO4P265CA0084.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:2bd::17) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 081e39d2-e16a-4f91-51e7-08d9f8761083
X-MS-TrafficTypeDiagnostic: SN4PR03MB6718:EE_
X-Microsoft-Antispam-PRVS: <SN4PR03MB6718660E3CE40ED71C6F7ACD8F3E9@SN4PR03MB6718.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: +Ccnedb7w4sUUYg3dj217B+yLzlGCGUc3Hrxvilpd3Lz180iQbyDXbLh6wOnBMpJX8N93McwCebcsDQYT616L/NgYN5C4x0EkOMkGs19oDRDpeDbrjwDuBUwd1CJrSDD7XE47LYDBHM7zyqEy7vVtsOBeq3thNOyZA7h0iTTcQpinGYgaYgNcakyzuN8vjrL/qr5FUz9L2uarrGxCijtbPYI7HES++zXxecjvZB2VtCNOMqadOczDtMcRKIcIrH+RV1UqrJbTyK3IvtPSxL9csXygjKBIJHFpDY4OV0KLgEPOtDsKuxhEVI9ebBxXlHk2R5Lyj5IbrhOWGcWEwzJ/aMQfGGPDKEVecpuVUUNT47fcRGrL1plYADerPpAofMFCdzLLgueyR9kZMCUvldMQ45xuvy1cLnBltrv7mi2yAQ1DNCzFB5WAQSNN6TZ+O880DGOIfdmL8yW6UzAZvkcmdAwYdJyNF6VJjWUqCGOg0CXPC5ju38URtMEw3iKDesk4LBObxfG80IQL+QXxOhZU4JrRk+O/FK6wXWG1NP0jraEABbSDV/6a2gcBuHs/fsAIoy3nvY7xVuJ10DU+ysDxSPDMafAKGyTiStCeRxBL/aVyBoNnlok7lzkstbUYkiKW7TOnLFIEg1Firhd+9+tmbkCo/3GPgOdh7H+XX2hGVXggLDpoUGy4yUitLJ/cdNUInWNzDyJzz2iufOTSzs8p4vONDS/VhwZXxcInFpdeio=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(6666004)(66946007)(8676002)(2906002)(9686003)(4326008)(66476007)(66556008)(6512007)(508600001)(8936002)(6486002)(966005)(86362001)(26005)(54906003)(85182001)(83380400001)(53546011)(82960400001)(316002)(6506007)(5660300002)(38100700002)(186003)(6916009)(33716001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VE45N0lCZ09KM3FpTXYwa0NoQ1g2aXVOb21Fa2p3R04yMG41KzdvdmdIRFkr?=
 =?utf-8?B?U2cvaFpGQW1VVlhLb0lycmYyb0RGNHJTQnQyT2hySUduelJHenNCcGdZNW1t?=
 =?utf-8?B?aXFwOHY0QU5zWjJYR0gvcHJkSGJBTmdicktHaGNyYWpWNFZVTEdEVU1vZHhE?=
 =?utf-8?B?SjVFK3hhNEJsN3JqdGlLUDZOUTl5QXpDWlVlMm5CK2hFVjllN2k3OUJtVjdu?=
 =?utf-8?B?ZG1qZG1sU0t1YkozUElnWk5DT0Zrdml1dFd1K0ZEeExMYklUQzNMQXNVdmpL?=
 =?utf-8?B?QlNtUWw1K3JRZ3FtZWNzTWNUMXlEWnZGSm9aWlBNd0xzT3BMbGFIL3F6clZY?=
 =?utf-8?B?WmdUcjZDNFEzaUxuSDE1MU83Rm5jZStyVm5xa1BwanEzcU1jYnlzMVNPUk13?=
 =?utf-8?B?cFcxc0dObEk5d3JUWDFuVnJxajExbUFqd0p3V3Fpb1E2bnY5dmtzMzk1dFdy?=
 =?utf-8?B?U2dLWndqaGRaV2Q1akJWWjlUSUVWcFJ0TWhGMjNESDUwcTFxNjJockpEU3ZS?=
 =?utf-8?B?M2FDYURjZFRQdWs5TmxrbnlWRVRoTWFsUE5MeWtpYWZvZEVReVRlRGdTVU5J?=
 =?utf-8?B?SHh4NzhSSkNNbktaalVUMzdyLzlrTU9wVkE0UEI1MENpQ0g4MEcwR3lydENS?=
 =?utf-8?B?S1h0OEZLU3Q4MENlbHZPNjVBTXB2Y044bkxNOEZSNjBNTXc1a29BSjdJNjJU?=
 =?utf-8?B?c0xNWjVuRTVFWlVtNDUzVi93N1FVOXArU0kxV2QwWGZ4OHdVL1VJek0zSzJH?=
 =?utf-8?B?cFRMMzk2Q0lrdmF1czN0Y29rNktEdVliYzd4NTYzNlUzcnBKVkNDYWJVZVFI?=
 =?utf-8?B?eTMwaW96UEcwTkpUMEhONjdyaDFGVXFrUnlYa3RIZVpEeUI1dTJid2VwZU5u?=
 =?utf-8?B?U081SFJ6UHZqT0FxcS9rTjJoUStQR05ZZjFaY25kUWpMVXlHamdjY1Nsc0xC?=
 =?utf-8?B?amJqVEpjL01OMVRDODdUbGhzM1VrajhMSUl2T21jNWJENWJhMGxJbTFCbW91?=
 =?utf-8?B?NmgxSkErMW1tMnJWZW5sY2VYUGM5YVM1QkpZQ29vaWx1S2dQdVhtVUlzdUxN?=
 =?utf-8?B?ZG9RSmhzeVlyQmZ2d0FPaWIxVlpMcWlYMXRaWTBxaEFZcGhVVEJUMTdzVEdr?=
 =?utf-8?B?Y1pPNXZUUWF6NUhuVThHYUpWQ3dxSkdGczFnRWFmNTBTTUtMdVhjQi9Qb01x?=
 =?utf-8?B?YkpPZnl1YUZySVViV1FjbGdtU3RnZmNNQWMvSzREdjgvOTh6WG8wcExZZkVw?=
 =?utf-8?B?MEtFb2UrMWRiUUk3YVo1Ti8waHNSTTZMUHM1MWpWRUpLSDRqdlpNOEQ4RGkx?=
 =?utf-8?B?WEtLZGREbSs1MXQ2aGpaNU5mUUZRb2h1UVZCN3R3bEZ0TVhFTzBHN3JheHVp?=
 =?utf-8?B?aHJmYjBVOE9TaWRjZ2tvdWx1NVZLRWRYZDFBK1BEOXcxMStZWHBvT3Q5MmNi?=
 =?utf-8?B?ZzJCT3hiTHErWlkzZk9Rd041Yi9GbHN0VmFTT1E5Uys3WTVHeUx5b1RiUWdI?=
 =?utf-8?B?VEdyT2wrUFV3M0cxVCs2dHIzWTR1Y1cvd29ZRFR3ZERtRjJXTkE0eWFHc0Yv?=
 =?utf-8?B?Qi9yMVpTaHhTUkJ1ZzIxU3daWG1jTGV2S3ZZZGM5UHcyc3dobDF1RzEreTg3?=
 =?utf-8?B?ZFpSWWFIRSs3SWFsS1JiKzlVWFVjSmpVZHhvcU9EaU9VKzdLZmRkWlVJWmdv?=
 =?utf-8?B?UU9YVkxVL3h0ZVJ0YnJkeTVtUG15OSs4NWNodHdQbTltNjI5VnBXb0VxYSt6?=
 =?utf-8?B?ZS9iZWtueFpvNEhFMUR3TnJIMzdUbksyVmRyblFYeWpYR21LK056OGZHTk14?=
 =?utf-8?B?OTh1RHNjUHdvbnhIK1dhVnJqSTBQVWZCcnRNUjZMbWpEa052dzJUZmR1NmtQ?=
 =?utf-8?B?T2VYR0ZGWXBlNXl5YVFadGtiRy9CNzl0dFB5Lyt0ZjExM3FVMzFHQmQwR3lW?=
 =?utf-8?B?Zjdpd1RMZzA1NEtOSHhpK3hWSUJBVkhONWMwWWZ4TG54Qmg3bUpkUk1aeG42?=
 =?utf-8?B?Vlp2eFhPNFlFM01IeEQ4ODdsNFUvVzhFWi9xUDZncUhaT0ZzOGpzM1Nkbzlw?=
 =?utf-8?B?TzhzZEw3dC9ybkVBQ2hMYkd0d250ZzhRWHBKL2NkYkJHcEpEdDlKa09zRW9S?=
 =?utf-8?B?WGl3elFseXJTOU40bUsyTTk3YXlFaUVjaDRqZlprT3BiRVBBWGVNd2Nua2Q3?=
 =?utf-8?Q?dPM5grK2tjWefEAMHkX3r6w=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 081e39d2-e16a-4f91-51e7-08d9f8761083
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2022 15:47:01.8537
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: roBUUEvuWXg4PGqGvreU/PTz77oUB3LQ5RJZHeVQLGY2Gg/fKRKL88nz9jzYvte2Hb7eel0ZOJI5n05AvAnYxg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR03MB6718
X-OriginatorOrg: citrix.com

On Fri, Feb 25, 2022 at 03:22:59PM +0100, Jan Beulich wrote:
> On 25.02.2022 14:50, Alex Olson wrote:
> > I realize PVH for dom0 is still experimental, but was trying to see how well it
> > works in the state of "master".
> > 
> > I found one issue with MSI-X interrupts in dom0 -- a fatal page fault occurs
> > when the MSI-X PBA is accessed from dom0.  It looks like dom0 doesn't have an
> > identity mapping for the PBA of a PCI device --  intentionally caused by
> > vpci_make_msix_hole() ?   
> > 
> > I was also wondering, what is the impact of "existing mapping (...) at 0
> > clobbers MSIX MMIO area".
> > 
> > Is the purpose of vpci_make_msix_hole() to make MSIX table/PBA accesses trap to
> > the hypervisor?  Seems like the page-based granularity is too coarse since the
> > PBA can be much smaller than a page as well as not aligned... 

Page-size granularity is the minimum that we can do in the second
stage page tables.

I guess we could do with some logic to forward accesses outside of the
MSI-X table and PBA that falls into a valid BAR region that shared the
4K page.

> > I was able to get something potentially usable by adding a "ioremap" call in
> >  msix_read() and msix_write to deal with the access of the PBA.  Wasn't sure if
> > this was a proper way of handling things...  Was also wondering if it would make
> > sense to do the same for the "clobbers MSIX MMIO area" cases too.
> 
> You happen to ask just over two hours after a patch was posted:
> https://lists.xen.org/archives/html/xen-devel/2022-02/msg01657.html
> Since Roger didn't have an environment to test his change, maybe you
> could do so, offering a Tested-by if successful?

I had to post a new verison because I idnd't recall that for dom0 we
also allow writes to the PBA, it's here:

https://lore.kernel.org/xen-devel/20220225153956.1078-1-roger.pau@citrix.com/

Roger.


From xen-devel-bounces@lists.xenproject.org Fri Feb 25 16:03:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 16:03:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279504.477218 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNd3j-0003ig-Vt; Fri, 25 Feb 2022 16:03:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279504.477218; Fri, 25 Feb 2022 16:03:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNd3j-0003iZ-SH; Fri, 25 Feb 2022 16:03:07 +0000
Received: by outflank-mailman (input) for mailman id 279504;
 Fri, 25 Feb 2022 16:03:06 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=halk=TI=citrix.com=prvs=048fa7b34=Jane.Malalane@srs-se1.protection.inumbo.net>)
 id 1nNd3h-0003iT-Uo
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 16:03:06 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 68f8ed5d-9654-11ec-8eb9-a37418f5ba1a;
 Fri, 25 Feb 2022 17:03:04 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 68f8ed5d-9654-11ec-8eb9-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645804983;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=wwq1DPbX6k4Jw2hx0Y9dUMaZk7uzSF4+0j0i9Lh17Dw=;
  b=bWtoqme33eJG3TMd96GGQaVcwSZyb178+p3rmT2n8pPv/lU5Pdo+tiAw
   qVqg8QXDCCDnQzKcrhJ5YSbcTrbUtDXNYXx+AkvCUHHkciGaeG6KAHT8n
   bjSLJffeQBp9Y6PhdIpi9ScHxHQoFnShNZZ9pqKUHvT728jEL3aJfUnah
   U=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 67270571
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:/qJeTKNRwonJbQPvrR0Ul8FynXyQoLVcMsEvi/4bfWQNrUolgmYAy
 GEfCzyOM/zYZDb0ft0gaYTi9k9TuJDTztNrTQto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFcMpBsJ00o5wbZj2NMw27BVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z+
 cxyjoSybA4QF/PNquUzQR93Pyh8IvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALDsDtMcU6s3VpyTjfAN4tQIzZQrWM7thdtNs1rp4RR6mGO
 pVAAdZpRCzGUxx+B0cFM50jhOHvi0v8YgVo903A8MLb5ECMlVcsgdABKuH9cNGQWd9cmEreo
 2vc5nn4GTkTLtnZwj2AmlqSgevIkTL+SZglPrSy/f53g3We3mUWThYRUDOTo+S/zEi3WNtdK
 kkd0isosaU2skesS7HVTxC+5XKJoBMYc95RCPEhrhGAzLLO5ASUDXRCSSROAPQludE3Q3o21
 1aPt9LvGTFr9raSTBq16bO8vT60fy8PIgcqZyUJUA8E6NnLu5wog1TESdMLOKy6lNruAhnr3
 iuH6iM5gt07ltUX3q+2+VTGhTOEpZXTSAMxoALNUQqN7B59ZYOjT5yl7x7c9/koEWqCZgDf5
 j5ewZHYtb1QS8HW/MCQfAkTNICw2M2dMhjVuHcxHqsg2Sar1FKqf58FtVmSO3xVGsoDfDboZ
 mratgVQ+IJfMROWUENnX26iI590lPa9TLwJQtiRN4MTOcYpKGdr6QkzPRb44oz7rKQ7fUjT0
 7+/eN3kM3sVAL8PINGeF7ZEiu9DKszTKAruqXHHI/aPjev2iJ29E+5t3L6yggYRtvLsTOL9q
 Ys3Cidy408DONASmwGOmWLpEXgELGIgGbf9oNFNe+iIL2JOQT99VqCNmO98I9Q9x8y5c9skG
 FnnCye0L3Kl2BX6xfiiMCg/ONsDo74lxZ7EAcDcFQnxgCVyCWpexKwea4E2bdEaGB9LlpZJo
 w0+U5zYWJxnE22fkxxENMWVhNEyJXyD2FPVVwL4MWdXQnKVb1GQkjMSVlC0r3dm4+venZZWn
 oBMISuAGctTH1k5VZ2OAB9tpnvo1UUgdCtJdxKgCvFYeVn28ZgsLCr0j/QtJNoLJwmFzTyfv
 zt6yz9EzQURi+fZKOX0uJ0=
IronPort-HdrOrdr: A9a23:6mGX2qsI0e0aQvBMWwMn0qww7skC2YMji2hC6mlwRA09TyXGra
 6TdaUguiMc1gx8ZJh5o6H9BEGBKUmskaKceeEqTPmftXrdyRSVxeZZnMrfKlzbamLDH4tmtJ
 uIHJIOcOEYYWIK7/oSpTPIburIo+P3sJxA592utEuFJDsCA8oLgmcJaTpzUHcGPjWubaBJTq
 Z0jfA3wAZIDE5nF/hTcUN1OdQryee78a7OUFojPVoK+QOOhTSn5PrRCB6DxCoTVDtJ3PML7X
 XFuxaR3NThj9iLjjvnk0PD5ZVfn9XsjvFZAtaXt8QTIjLwzi61eYVaXaGYtjxdmpDs1L9qqq
 iIn/4TBbU115rjRBDynfIr4Xi47N8a0Q6n9bZfuwq6nSW2fkNgNyMLv/MmTvKQ0TtQgDg76t
 MX44vRjesmMTrQ2Cv6/NTGTBdsiw69pmcji/caizhFXZIZc6I5l/1UwKr7KuZ1IMvW0vFuLA
 BVNrCW2B+WSyLsU1nJ+m10hNC8VHU6GRmLBkAEp8yOyjBT2HR01VERysATlmoJsMtVcegJ28
 3UdqBz0L1eRM4faqxwQO8HXMusE2TIBRbBKnibL1jrHLwOf3jNt5n06rMo4/zCQu1E8LIi3J
 DaFF9Iv287fEzjTcWIwZ1Q6xjIBH6wWDz8o/surqSReoeMMoYDHRfzOmzGyfHQ0Mn3KverLs
 qOBA==
X-IronPort-AV: E=Sophos;i="5.90,136,1643691600"; 
   d="scan'208";a="67270571"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=TFNDQDJLzg4RY/QFHX3uhjtkMxI8n4ck8UR2xi0F4Ke1f6lYSg4ub+Y16z4nj48NVxiCudZCgaTeMBfQ0Z1ZOM2TFlgQ8p13rm0Mhap0CCo0BYzUReJRn/wgOPRR2p3OZZRkpjHG/02JVgPB7dDDSscgnV6axW9v/pl6M7e5KGVSqFW5w4DQQ4pgSCMdAVxzkC2MCFz6P8MyVPNOGwlhEePLRqgO/1ajgD30lOeHuHtBeFRZjKjJza/8eHhAeJgjxNniT2MoxPn7GCPzjGJ89gklhLJM5HmXcj2W+7svGAAoWuHUGGWUl4iDw4U5OaDFTjTkW+6bHtFE0QA9zWYxZw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=wwq1DPbX6k4Jw2hx0Y9dUMaZk7uzSF4+0j0i9Lh17Dw=;
 b=CJnvWwq1FCo5uLCVsx4oMvcr0zCZ5gBbJ8MsLWkbz8679Z/bBzNINNrjbNiaZP2qCF0gKaIam2+OqRQR++eaIj2LKZWH+YlRQjqv7QuhTDiYoxjhPEc+3aVTm18DahR5KaxjgrVZOqmXuGQwymr2j8IB5/kIMi9+ihzklg9urDe5D9zUTRo5mTY3VvTWLuX74U6x/pbnv2UDOHk+5LANCPaQlOsKbiCDwmfOgt71BF1W2r+d80hIGVxu3zqERAQkR3N7KLon+CCU2B9pZ2cD7lvsm3CSn1CCpvSjHlwOh7b72XSLUpw+1Np+toGzwPs3z2Iqc8yMrW9DqMbDL7TZKg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=wwq1DPbX6k4Jw2hx0Y9dUMaZk7uzSF4+0j0i9Lh17Dw=;
 b=b0n2b92ObbCeROhiK05sOm/06QHRkn0B/C5qxb5asfhJMDqJmFyb+eJ6vVotSZ7SUSRt/BcOfI8+AMM5BHelnn/vprZb/yuWJHQkWE7djPnfc0dQCK6Uj2KBWYfHetpAaBupDWSDyibQ0dvzMFqVaHDNa+u1jLoUz+7LTnx5alA=
From: Jane Malalane <Jane.Malalane@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Wei Liu <wl@xen.org>, Anthony Perard <anthony.perard@citrix.com>, "Juergen
 Gross" <jgross@suse.com>, Andrew Cooper <Andrew.Cooper3@citrix.com>, "George
 Dunlap" <George.Dunlap@citrix.com>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>,
	Jun Nakajima <jun.nakajima@intel.com>, Kevin Tian <kevin.tian@intel.com>,
	Roger Pau Monne <roger.pau@citrix.com>, Xen-devel
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v3 1/2] xen+tools: Report Interrupt Controller
 Virtualization capabilities on x86
Thread-Topic: [PATCH v3 1/2] xen+tools: Report Interrupt Controller
 Virtualization capabilities on x86
Thread-Index: AQHYJO06JWynylsFtkyl8WR8WaDosKyixjKAgAGyPAA=
Date: Fri, 25 Feb 2022 16:02:54 +0000
Message-ID: <22ae35a0-9df8-9357-4b44-2f00586144fc@citrix.com>
References: <20220218172943.12182-1-jane.malalane@citrix.com>
 <20220218172943.12182-2-jane.malalane@citrix.com>
 <0a31970c-c0f8-c995-ce04-67523a4a830a@suse.com>
In-Reply-To: <0a31970c-c0f8-c995-ce04-67523a4a830a@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: bb2a06e6-cc01-4fa7-3290-08d9f8784878
x-ms-traffictypediagnostic: BY5PR03MB5299:EE_
x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
x-microsoft-antispam-prvs: <BY5PR03MB529940A5C3AE7274C124C174813E9@BY5PR03MB5299.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: P/nuz6OoVWZq9SiVl3TgErqM+E7gGIlUbIETI5vJ4044ZSUo0JOXrYGNeslOLej0Tl+4UEwY7PRu694ASuu3yfAzpuCYAD/7saTMqA3z5x0YEete11+6eeZwwITihXK2m0BF7ngqIoT3fFsdbaWilXeeFuUhx0o95wx20seGygZcjfLWG1uGjxpDGgFCraipi3MyAMaWkbN8LegUPkcl/FHZH9C6uWdugq88ibc+vqRoTEsg8myOt1ytsHt2BGxdF2v/pFIIlSxm2Wifi4cFq2y978C2nQt3cyrMSJFgH8O+rns9am0lmGDZDKXDIT/PaXp9Q5R+Q3rtkJfn1yB4B7zEB1GeV61D/MgJmH66Ay51sZHFA2Z9pmjPyiJNak7PyTPQsoCMWs+wht5diiEWv4DoPcqudRNwSAbtX9Jd8Jz8aW+Zi+mUSEXSkrQsVDErb3qIQz+3CeQtrjS4xAZxCFFgI3+5TKlzibYA6Ms1TGCk9X1zGL5rXXCJeRE+KxFm8Fismj3xRFPUeu74IwxBJjOfsZ/4y4LIwkQToVynokUyEcjKIazD9FjZWxN96tRaZ4Kv2O5vHwaGztyICrzAaNlF9DEnc0hXHvOPENhP2PwiCw2qPa8YZFcc9zaSdmbfoWgc9dQsZ8nGxUTDRoOZUpOuBdds/uMlUSQCY03/4MnPAO+0tj9lRa16R5aPedIa3nZnGWHU44+P2LqaKRkcE9dI6H8m504+rZs9LCdZJBJHRIlEpI2R180EGPRmMAbP
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR03MB3386.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(2906002)(31686004)(6512007)(6506007)(66476007)(316002)(36756003)(122000001)(31696002)(508600001)(53546011)(6486002)(71200400001)(83380400001)(186003)(2616005)(26005)(8936002)(7416002)(54906003)(6916009)(5660300002)(66446008)(82960400001)(86362001)(8676002)(38100700002)(4326008)(64756008)(91956017)(76116006)(66946007)(38070700005)(66556008)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?SVNldFNueDM1VUpXTTRhNVQwenEwb1dNOWM5Z1FtM0xDSmJnWlRJWlFEeTNo?=
 =?utf-8?B?WlAzQ1ltTklBM25hcU9JdlgvU0s3ekxWZU1kdG82b0pER2dUa2JhaURGQ2lM?=
 =?utf-8?B?T2ZKWjZZOXFsQ3dFZXppWE5ibjc4S1Mrc0tiOExhYUxOZXpzdEFXZ0JBa2Ry?=
 =?utf-8?B?bUZrQnltd01CSUkrSEUrVitRUDI2eEx2VVN6NmlVSTE2cFNrNkZ1SGgzbmVp?=
 =?utf-8?B?aFduYWVORk5iYm9kdlVBNytiOHhqWHJRVnlOOVkza05KYjkxNlNiVndhcENy?=
 =?utf-8?B?Ynk1d2NtYXYzM0J1WWl0eFNsYjAvZExFUDEzd2ZIRWxTZElKZ1g0VEN5UWo5?=
 =?utf-8?B?cEJJTnVjV1k4QXhqWVJLQ0w2SXFTb3JjWUdPRmJiZzJDRXRROXVVQVQrT1RZ?=
 =?utf-8?B?M3VwejRIa2NDMTZoMU9lZmR2U0E2NG80eXhBY2tSOXZPYXhlY25EbnZPNjFk?=
 =?utf-8?B?Vm9aei93OW1nQTl1SGs2VDd2RXNDVEZ6NGZvTWV4ZTd4WUZQNDR0L3B5aVk0?=
 =?utf-8?B?MElYUjljZUcyMkJKcTRqQmwrb1RCNzZDaTA5cklIMDlIdUcrTVp3c3RPYSsx?=
 =?utf-8?B?aFhJa3pVNy82UHdPYVNMNmYwMHdrdDIxTEpIV1RnWU15NFVSdWIrMVc4Unh4?=
 =?utf-8?B?c240akUzZ3pGdXBlWjE0ZFdKT29HbmFLOFFxRVFuQk9BV2ZoN0VQQSt1Z1Vm?=
 =?utf-8?B?TVc5aThXS1NrbVp2UWNSTjZ0OGVReEZkbDE0UXVYdzB1dzdiRXpSV0ZWNUZE?=
 =?utf-8?B?V0dxYmxvN0lORHpUMmo3UnlPTndQMDJ2dDVxaTBRNk1IMjM2ZmhNYm1QN0pD?=
 =?utf-8?B?K3RZSGhnQWRuZUdjYkpqUGhyUG9GejR2QTlaUGJtWFZGaVRsbmk1QzhWaVp0?=
 =?utf-8?B?WEwvL0piWC8zWE5RZVc3cVRDaHBveFY4dWJ6cFB6ZFY1QkFzNHJveGNuUEJW?=
 =?utf-8?B?M1g5YTVYWFNUY2pNNFVOZ1JwaVB5aWQ3RGZSSFJ0SWN3aVJDUmgxRjAwcTNz?=
 =?utf-8?B?SitaNmEvOU1tdWJnTnRmOGFCTEJvM2hIRnlGM0tBQXB5eTJWalJCQ0s2bk04?=
 =?utf-8?B?clMrMGp5cE5RNmtMdHhhRytwN3JtUnhOTVlLb0FXdENQSG5icm5JOWV3VHJ6?=
 =?utf-8?B?TFg3MncvWlZsT0luMVkzNGpJamJxdDVaQ0RwVW5EbHk4L2JkbVRQN3RCU2Jr?=
 =?utf-8?B?OFlzZ1RJY1FKNFRPOHFBSHFRalZXcU9jWERuRmVwWWFkSENmeFI2MXRrSTgx?=
 =?utf-8?B?d2JZNmFGSFFBL285UFN5cDJ0MDJaRFhVeHhwWUszWUxIR21KZU4vcDQwSS81?=
 =?utf-8?B?OTYwa1kwT3hoMWR5alpKOVN6WVVXdDlsVnVzU0hRN3pHTjlyOTBJZm1ZbGRJ?=
 =?utf-8?B?NEVQRTkvUDJGL3ZRQXlWNkpaUmg3by9uSzJ1b2Y0L3lqeDRtbDlnRStaZy8z?=
 =?utf-8?B?WFJLd1ZZa1l1elFpeUJUTU5ibGRvSjVmcExaTjltSGFIN2YvREsvd2NROWti?=
 =?utf-8?B?WStvOUhiSmZtSGFaUGdlZDVmZk1JY29LN2lHaE94czUxcEFUUFozeTlVV1ZH?=
 =?utf-8?B?ckJBZUNiZ3hDK0lkNTlSY0VMempKUHFmOWZkUlN5NUdhc29pRE4wV2tOL1Jl?=
 =?utf-8?B?QlJMa1JEYWJoN3gwNzE4UmhtMGZJNXN4ZXR3WEZUYUVJbHZVZ202YzRPTy9X?=
 =?utf-8?B?akd2M3cycGNZTXc3YnlISW9XeDZmRXBoL1A1eVNtQWxQa29QeXY1Skt2SmxH?=
 =?utf-8?B?S2xXZFNpZlB6TkthUkZ5SExOZXY1ZXhTN1cydExzc2NFTEl1VU05di9EYjNV?=
 =?utf-8?B?OUg5QXY0Umh6WjF1UkFSemh0dktlbFdXTmRPUG9zOVJXaDVXTFZVMkEwdVRF?=
 =?utf-8?B?NkxoWUc5K2Z5bCtuNHAwMWhDMDNVQVRHWThEd3lNQm8rVG52dlN3Sjg1UXdz?=
 =?utf-8?B?eVFLU2Z5VndmaklNV2dZMTJmcG1NdlMzNDJPelRxL1NkUG5zdUg3ZXhuWGFI?=
 =?utf-8?B?ZVh4aEErTWJ6K0FqcmJZaGtNeGxhcU1UZ2hla2N5RUlyaU45bllMQ0hpTFJP?=
 =?utf-8?B?THRzeGp2RDhCRzhmaEpsd0pMaWR0SXVlemJZd3dEUmlzRFg5aWc5UHhBYUFx?=
 =?utf-8?B?SzVqd3dYenlPRFdxZHBlSTlqS0FyV2RJZ2hJd2k3V3hzdlloZXpLUVFxR0Vh?=
 =?utf-8?B?cG0vRTJBLy84dEkvLyt6UXN4QnlJMFZNV0VxQzk4Wm9WZjZYZDJXSHVJKy8y?=
 =?utf-8?Q?UU1F86TpgJoO+pe3yG5xWKiOQ3KdFdIfr2p9oIs9u4=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <05531D31B4132148BED2A7855A73FC2D@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM5PR03MB3386.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bb2a06e6-cc01-4fa7-3290-08d9f8784878
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Feb 2022 16:02:54.4611
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 9wv+HRBp9Pis3GdWY/VGe4G0Dsq+TBwxiIdKwunh9T1A9ARuya2SvrmImhgz5SSJfMcJhFN+bZMEIhLtPBFwhIKWCLvquaVwSmkBn/REiSE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB5299
X-OriginatorOrg: citrix.com

T24gMjQvMDIvMjAyMiAxNDowOCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IFtDQVVUSU9OIC0gRVhU
RVJOQUwgRU1BSUxdIERPIE5PVCByZXBseSwgY2xpY2sgbGlua3MsIG9yIG9wZW4gYXR0YWNobWVu
dHMgdW5sZXNzIHlvdSBoYXZlIHZlcmlmaWVkIHRoZSBzZW5kZXIgYW5kIGtub3cgdGhlIGNvbnRl
bnQgaXMgc2FmZS4NCj4gDQo+IE9uIDE4LjAyLjIwMjIgMTg6MjksIEphbmUgTWFsYWxhbmUgd3Jv
dGU6DQo+PiBBZGQgWEVOX1NZU0NUTF9QSFlTQ0FQX0FSQ0hfQVNTSVNURURfeGFwaWMgYW5kDQo+
PiBYRU5fU1lTQ1RMX1BIWVNDQVBfQVJDSF9BU1NJU1RFRF94MmFwaWMgdG8gcmVwb3J0IGFjY2Vs
ZXJhdGVkIHhhcGljDQo+PiBhbmQgeDJhcGljLCBvbiB4ODYgaGFyZHdhcmUuDQo+PiBObyBzdWNo
IGZlYXR1cmVzIGFyZSBjdXJyZW50bHkgaW1wbGVtZW50ZWQgb24gQU1EIGhhcmR3YXJlLg0KPj4N
Cj4+IEZvciB0aGF0IHB1cnBvc2UsIGFsc28gYWRkIGFuIGFyY2gtc3BlY2lmaWMgImNhcGFiaWxp
dGllcyIgcGFyYW1ldGVyDQo+PiB0byBzdHJ1Y3QgeGVuX3N5c2N0bF9waHlzaW5mby4NCj4+DQo+
PiBTdWdnZXN0ZWQtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+
DQo+PiBTaWduZWQtb2ZmLWJ5OiBKYW5lIE1hbGFsYW5lIDxqYW5lLm1hbGFsYW5lQGNpdHJpeC5j
b20+DQo+PiAtLS0NCj4+IHYzOg0KPj4gICAqIERlZmluZSBYRU5fU1lTQ1RMX1BIWVNDQVBfQVJD
SF9NQVggZm9yIEFCSSBjaGVja2luZyBhbmQgYWN0dWFsbHkNCj4+ICAgICBzZXQgYXJjaF9jYXBi
aWxpdGllcywgdmlhIGEgY2FsbCB0byBjX2JpdG1hcF90b19vY2FtbF9saXN0KCkNCj4+ICAgKiBI
YXZlIGFzc2lzdGVkX3gyYXBpY19hdmFpbGFibGUgb25seSBkZXBlbmQgb24NCj4+ICAgICBjcHVf
aGFzX3ZteF92aXJ0dWFsaXplX3gyYXBpY19tb2RlDQo+IA0KPiBJIHVuZGVyc3RhbmQgdGhpcyB3
YXMgdGhlIHJlc3VsdCBmcm9tIHByZXZpb3VzIGRpc2N1c3Npb24sIGJ1dCB0aGlzDQo+IG5lZWRz
IGp1c3RpZnlpbmcgaW4gdGhlIGRlc2NyaXB0aW9uLiBOb3QgdGhlIGxlYXN0IGJlY2F1c2UgaXQg
ZGlmZmVycw0KPiBmcm9tIHdoZW4gWEVOX0hWTV9DUFVJRF9YMkFQSUNfVklSVCB3b3VsZCBiZSBz
ZXQgYXMgd2VsbCBhcyBmcm9tIHdoYXQNCj4gdm14X3ZsYXBpY19tc3JfY2hhbmdlZCgpIGRvZXMu
IFRoZSBkaWZmZXJlbmNlIGJldHdlZW4gdGhvc2UgdHdvIGlzDQo+IHByb2JhYmx5IGludGVuZGVk
IChqdWRnaW5nIGZyb20gYSBjb21tZW50IHRoZXJlKSwgYnV0IHRoZSBmdXJ0aGVyDQo+IGRpZmZl
cmVuY2UgdG8gd2hhdCB5b3UgYWRkIGlzbid0IG9idmlvdXMuDQoNCk9rYXksIEkgd2lsbCBtYWtl
IHRoYXQgZXhwbGljaXQuDQoNCj4gV2hpY2ggcmFpc2VzIGFub3RoZXIgdGhvdWdodDogSWYgdGhh
dCBoeXBlcnZpc29yIGxlYWYgd2FzIHBhcnQgb2YgdGhlDQo+IEhWTSBmZWF0dXJlIHNldCwgdGhl
IHRvb2wgc3RhY2sgY291bGQgYmUgYWJsZSB0byBvYnRhaW4gdGhlIHdhbnRlZA0KPiBpbmZvcm1h
dGlvbiB3aXRob3V0IGFsdGVyaW5nIHN5c2N0bCAoYXNzdW1pbmcgdGhlIGNvbmRpdGlvbnMgdG8g
c2V0DQo+IHRoZSByZXNwZWN0aXZlIGJpdHMgd2VyZSB0aGUgc2FtZSkuIEFuZCBJIHdvdWxkIHZp
ZXcgaXQgYXMgZ2VuZXJhbGx5DQo+IHJlYXNvbmFibGUgZm9yIHRoZXJlIHRvIGJlIGEgd2F5IGZv
ciB0b29sIHN0YWNrcyB0byBrbm93IHdoYXQNCj4gaHlwZXJ2aXNvciBsZWF2ZXMgZ3Vlc3RzIGFy
ZSBnb2luZyB0byBnZXQgdG8gc2VlIChhdCB0aGUgbWF4aW11bSBhbmQNCj4gYnkgZGVmYXVsdCku
DQoNCkxpa2UgdGhlICJjcHVpZCIgeHRmIHRlc3QgYWxsb3dzIHVzIHRvPw0KTWFrZXMgc2Vuc2Ug
dG8gbWUuIEknbSBoYXBweSB0byB0YWtlIHRoYXQgdXAgYWZ0ZXIuDQoNCj4gDQo+PiAtLS0gYS94
ZW4vaW5jbHVkZS9wdWJsaWMvc3lzY3RsLmgNCj4+ICsrKyBiL3hlbi9pbmNsdWRlL3B1YmxpYy9z
eXNjdGwuaA0KPj4gQEAgLTM1LDcgKzM1LDcgQEANCj4+ICAgI2luY2x1ZGUgImRvbWN0bC5oIg0K
Pj4gICAjaW5jbHVkZSAicGh5c2Rldi5oIg0KPj4gICANCj4+IC0jZGVmaW5lIFhFTl9TWVNDVExf
SU5URVJGQUNFX1ZFUlNJT04gMHgwMDAwMDAxNA0KPj4gKyNkZWZpbmUgWEVOX1NZU0NUTF9JTlRF
UkZBQ0VfVkVSU0lPTiAweDAwMDAwMDE1DQo+PiAgIA0KPj4gICAvKg0KPj4gICAgKiBSZWFkIGNv
bnNvbGUgY29udGVudCBmcm9tIFhlbiBidWZmZXIgcmluZy4NCj4+IEBAIC0xMTEsNiArMTExLDEz
IEBAIHN0cnVjdCB4ZW5fc3lzY3RsX3RidWZfb3Agew0KPj4gICAvKiBNYXggWEVOX1NZU0NUTF9Q
SFlTQ0FQXyogY29uc3RhbnQuICBVc2VkIGZvciBBQkkgY2hlY2tpbmcuICovDQo+PiAgICNkZWZp
bmUgWEVOX1NZU0NUTF9QSFlTQ0FQX01BWCBYRU5fU1lTQ1RMX1BIWVNDQVBfZ250dGFiX3YyDQo+
PiAgIA0KPj4gKy8qIFRoZSBwbGF0Zm9ybSBzdXBwb3J0cyB4ezJ9YXBpYyBoYXJkd2FyZSBhc3Np
c3RlZCBlbXVsYXRpb24uICovDQo+PiArI2RlZmluZSBYRU5fU1lTQ1RMX1BIWVNDQVBfWDg2X0FT
U0lTVEVEX1hBUElDICAoMXUgPDwgMCkNCj4+ICsjZGVmaW5lIFhFTl9TWVNDVExfUEhZU0NBUF9Y
ODZfQVNTSVNURURfWDJBUElDICgxdSA8PCAxKQ0KPj4gKw0KPj4gKy8qIE1heCBYRU5fU1lTQ1RM
X1BIWVNDQVBfWDg2e0FSTX1fXyogY29uc3RhbnQuIFVzZWQgZm9yIEFCSSBjaGVja2luZy4gKi8N
Cj4+ICsjZGVmaW5lIFhFTl9TWVNDVExfUEhZU0NBUF9BUkNIX01BWCBYRU5fU1lTQ1RMX1BIWVND
QVBfWDg2X0FTU0lTVEVEX1gyQVBJQw0KPiANCj4gRG9lc24ndCB0aGlzIHRoZW4gbmVlZCB0byBi
ZSBhIHBlci1hcmNoIGNvbnN0YW50PyBUaGUgQUJJcyB3b3VsZCBkaWZmZXINCj4gdW5sZXNzIHdl
IHJlcXVpcmVkIHRoYXQgZXZlcnkgYml0IG1heSBvbmx5IGJlIHVzZWQgZm9yIGEgc2luZ2xlIHB1
cnBvc2UuDQo+IElPVyBpdCB3b3VsZCB3YW50IHRvIGJlIG5hbWVkIFhFTl9TWVNDVExfUEhZU0NB
UF9YODZfTUFYLg0KDQpPa2F5Lg0KDQo+IA0KPj4gQEAgLTEyMCw2ICsxMjcsOCBAQCBzdHJ1Y3Qg
eGVuX3N5c2N0bF9waHlzaW5mbyB7DQo+PiAgICAgICB1aW50MzJfdCBtYXhfbm9kZV9pZDsgLyog
TGFyZ2VzdCBwb3NzaWJsZSBub2RlIElEIG9uIHRoaXMgaG9zdCAqLw0KPj4gICAgICAgdWludDMy
X3QgY3B1X2toejsNCj4+ICAgICAgIHVpbnQzMl90IGNhcGFiaWxpdGllczsvKiBYRU5fU1lTQ1RM
X1BIWVNDQVBfPz8/ICovDQo+PiArICAgIHVpbnQzMl90IGFyY2hfY2FwYWJpbGl0aWVzOy8qIFhF
Tl9TWVNDVExfUEhZU0NBUF9YODZ7QVJNfV8/Pz8gKi8NCj4+ICsgICAgdWludDMyX3QgcGFkOyAv
KiBNdXN0IGJlIHplcm8uICovDQo+IA0KPiBJZiB0aGlzIHdhcyBhbiBpbnB1dCBmaWVsZCAob3Ig
Y291bGQgcG90ZW50aWFsbHkgYmVjb21lIG9uZSksIHRoZQ0KPiBjb21tZW50IHdvdWxkIGJlIGFw
cGxpY2FibGUuIEJ1dCB0aGUgd2hvbGUgc3RydWN0IGlzIE9VVC1vbmx5LCBzbw0KPiBlaXRoZXIg
b21pdCB0aGUgY29tbWVudCBvciB1c2UgZS5nLiAid2lsbCIgb3IgYmV0dGVyICJyZXNlcnZlZCIg
KGFzDQo+IHBlb3BsZSBzaG91bGRuJ3QgbWFrZSB0aGVtc2VsdmVzIGRlcGVuZGVudCBvbiB0aGUg
ZmllbGQgYmVpbmcgemVybykuDQoNCldpbGwgb21taXQuDQoNClRoYW5rIHlvdSwNCg0KSmFuZS4=


From xen-devel-bounces@lists.xenproject.org Fri Feb 25 16:29:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 16:29:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279513.477229 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNdT2-0006K5-7U; Fri, 25 Feb 2022 16:29:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279513.477229; Fri, 25 Feb 2022 16:29:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNdT2-0006Jy-4X; Fri, 25 Feb 2022 16:29:16 +0000
Received: by outflank-mailman (input) for mailman id 279513;
 Fri, 25 Feb 2022 16:29:14 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=E0Ll=TI=citrix.com=prvs=04808661d=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nNdT0-0006Js-Mb
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 16:29:14 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0f1038ff-9658-11ec-8539-5f4723681683;
 Fri, 25 Feb 2022 17:29:11 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0f1038ff-9658-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645806551;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=dIdvA6jL2zvyGQkfeJRdJ548QoN/HZZe+YR1VWTGvzM=;
  b=PcHW9nFuJK95kXToXDb/Y8fWYoK+49w0FGeJsYne5ixsPJT4US2IQhoW
   FWMYjlUidxEQiW+ddYRmz3JlqVIH1jGLkuWFPVdvBgWxvI0GY1veN2MbP
   4ZFRXgl+YARfvITtoJ1NkzXYiiUqdk2+qJM7if1xopkMg/rsqR28Y+vWI
   0=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 64440688
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:NeSUDatUmu431461TjMrfJkWvefnVFNeMUV32f8akzHdYApBsoF/q
 tZmKTqBbqveZWD0L4olbIy0/BgAvceDzIVgGQJoqSlnRCpB+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQyw4bVvqYy2YLjW1nX5
 IuoyyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb
 /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo
 Oihu6BcRi8gB67lkdoRdSIAGjskNq9JoZbGfEWg5Jn7I03uKxMAwt1rBUAye4YZ5vx2ESdF8
 vlwxDIlN07ZwbjsmfTiF7cq1p9LwMrDZevzvllpyy3ZCvA3B4jOWazQ6fdT3Ssqh9AIFvHbD
 yYcQWQzMEiYPU0fUrsRIIMXjtikmkOkTzMGuGzIuZBo6HnLyRMkhdABN/KKI4fXFK25hH2wu
 Wbu72n/RBYAO7S3xTOb/1q2i+TInCe9X5gdfJWo+/gvjFCNy2g7DBwNSUD9sfS/klS5Wd9UN
 woT4CVGkEQp3BX1FJ+nBUT++SPa+E5HMzZNLwEkwAi0yYPd3Qq/PTANVGRKatN/nc5reCN/g
 zdlgOjVLTBotbSUT1eU+bGVsS6+NEApEIMSWcMXZVBbuoe++enfmjqKF48+S/Dt0rUZDBmtm
 2jikcQou1kEYSfnPY2f9EuPvT+jr4OhouUdtlSOBTLNAu+UieeYi22UBbrzsacowGWxFADpU
 J04dy62trFm4XalznHlfQn1NOv1j8tpyRWF6bKVI7Ev9i6251modp1K7Td1KS9Ba5hYJGC1O
 ROO4VsJvPe/2UdGi4ctMupd7OxwkMDd+SnNDKiIPrKinLArHON4wM2eTRHJhD28+KTduao+J
 Y2aYa6R4YUyUsxaIM6Nb75Fi9cDn3lmrUuKHMyT50n3gNK2OS/OIZ9YYQTmUwzMxP7dyOkj2
 40EbJXiJtQ2eLCWXxQ7BqZIdQFadSVgXMuuwyGVH8baSjdb9KgaI6e56dscl0ZNxvk9ejvgl
 p1lZnJl9Q==
IronPort-HdrOrdr: A9a23:5Xf+E62EAV186fiuMg/9zwqjBLIkLtp133Aq2lEZdPRUGvb3qy
 mLpoV+6faUskd1ZJhOo7290cW7LU80sKQFhrX5Xo3SPjUO2lHJEGgK1+KLqFfd8m/Fh41gPM
 9bAs5D4bbLbGSS4/yU3DWF
X-IronPort-AV: E=Sophos;i="5.90,136,1643691600"; 
   d="scan'208";a="64440688"
Date: Fri, 25 Feb 2022 16:28:43 +0000
From: Anthony PERARD <anthony.perard@citrix.com>
To: Christian Lindig <christian.lindig@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, David Scott <dave@recoil.org>,
	Wei Liu <wl@xen.org>, Edwin Torok <edvin.torok@citrix.com>
Subject: Re: [XEN PATCH v2 29/29] tools/ocaml: fix build dependency target
Message-ID: <YhkDu+oikp0Yd3sN@perard.uk.xensource.com>
References: <20220225151321.44126-1-anthony.perard@citrix.com>
 <20220225151321.44126-30-anthony.perard@citrix.com>
 <C31BFB15-F511-452B-A249-1D6FDAC5F626@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <C31BFB15-F511-452B-A249-1D6FDAC5F626@citrix.com>

On Fri, Feb 25, 2022 at 03:30:59PM +0000, Christian Lindig wrote:
> 
> 
> > On 25 Feb 2022, at 15:13, Anthony PERARD <anthony.perard@citrix.com> wrote:
> > 
> > This patch fix ".ocamldep.make" rule by always spelling the variable
> > $(OCAML_TOPLEVEL).
> > 
> > Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> > ---
> > 
> > Notes:
> >    v2:
> >    - new patch
> > 
> > tools/ocaml/libs/eventchn/Makefile   | 8 ++++----
> > tools/ocaml/libs/mmap/Makefile       | 8 ++++----
> > tools/ocaml/libs/xb/Makefile         | 8 ++++----
> > tools/ocaml/libs/xc/Makefile         | 8 ++++----
> > tools/ocaml/libs/xentoollog/Makefile | 8 ++++----
> > tools/ocaml/libs/xl/Makefile         | 8 ++++----
> > tools/ocaml/libs/xs/Makefile         | 8 ++++----
> > tools/ocaml/Makefile.rules           | 2 +-
> 
> Acked-by: Christian Lindig <christian.lindig@citrix.com>
> 
> I am fine with this but in general think that the OCaml part should be built using Dune (but invoked from Make), which is now the standard tool to build OCaml projects and is simple, fast, and accurate. Edwin maintains such a build for all development work on the OCaml side but it is not upstreamed.

ocaml-dune doesn't seems to be available on debian oldstable. So I don't
think we can use it for now.

But thanks for pointing that out.

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Fri Feb 25 16:34:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 16:34:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279520.477240 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNdYM-0007hf-SW; Fri, 25 Feb 2022 16:34:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279520.477240; Fri, 25 Feb 2022 16:34:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNdYM-0007hY-OM; Fri, 25 Feb 2022 16:34:46 +0000
Received: by outflank-mailman (input) for mailman id 279520;
 Fri, 25 Feb 2022 16:34:45 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=H5pI=TI=citrix.com=prvs=04867385f=edvin.torok@srs-se1.protection.inumbo.net>)
 id 1nNdYL-0007hS-7j
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 16:34:45 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d48ddc9e-9658-11ec-8eb9-a37418f5ba1a;
 Fri, 25 Feb 2022 17:34:43 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d48ddc9e-9658-11ec-8eb9-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645806883;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=GjXkIADl9uM4Dlv0sXQ4R+U/++MHKrpWDEYeyP1k9ww=;
  b=FV4Ia93Htl8BJNOHkR/E1Y/9FbnsU6VF9n9urC0IIEoh+6jwZ9pTr8QP
   DDIEobN3dMrlb0dlt1K6zmn3H9l1z/FZA15RO2/DRoAA3EslbQdWHMAIF
   EBAK1RQ2rYuGeQtBI9TqMGADwafwHeKU8qFicbYYwmHUc8OZjTC38m8cd
   c=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 67275415
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:6xn8kq5eQNGhloN/x5QzRQxRtC7HchMFZxGqfqrLsTDasY5as4F+v
 mMcCmCDPaqOZGahedxwad+3900O75HUzIJnTlNory5jHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0XqPp8Zj2tQy2YLjXlvX0
 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X
 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx
 umhurS5cigTb4bjl90naEIFLSIjDZ1ewuDYdC3XXcy7lyUqclPpyvRqSko3IZcZ6qB8BmQmG
 f4wcW5XKErZ3qTvnez9GrIEascLdaEHOKsStm9hy3fFCuwhQrjIQrnQ5M8e1zA17ixLNaiBP
 ZVENWMyBPjGSwcUZ3cxBJVnp6DrmH/kWQMfq3Owi6VitgA/yyQuieOwYbI5YOeiWsF9jkue4
 GXc8AzRDhgEOfSFxDGC83bqgfXA9QvrVYRXGLCm+/pChFyI2ndVGBAQTUG8o/Sylgi5Qd03F
 qAP0nNw9+5orhXtF4SjGU3jyJKZgvICc9NrPNdrwy6C85DvuFunBTU0fiZ7N8Nz4afaWgcW/
 lOOmtroAxlmv7uUVW+R+9+okN+iBcQGBTRcPHFZFGPp9/Gm+dhu1UyXEr6PBYbo1oWdJN3m/
 9ydQMHSbZ03hNVD6ai09Euvb9mE9smQFV5dCuk6swuYAuJFiGyNO93ABbvzt68owGOlor+p5
 ilsdy+2tr1mMH11vHbRKNjh5Znwjxp/DBXSgER0A74q/Cm39niocOh4uW8ieRg1a5pZIWexO
 Cc/XD+9ArcJbRNGioctPuqM5zkCl/C8RbwJqNiOBjaxXnSBXFDep3w/DaJh92vsjFItgckC1
 WSzKq6R4YIhIf0/llKeHr5FuZdyn3xW7T6DFPjTkkX8uZLDNSH9dFvwGAbXBgzPxPjf+1u9H
 hc2H5bi9iizp8WlOniHqdNIdAtSRZX5bLivw/Fqmie4ClMOMEkqCuPLwKNnfIpgnq9PkfzP8
 G37UUhdoGcTT1WbQelWQhiPsI/SYKs=
IronPort-HdrOrdr: A9a23:mHcFG6tHCX3fkh+WO89gp2IH7skC2IMji2hC6mlwRA09TyXGra
 +TdaUguSMc1gx9ZJh5o6H8BEGBKUmskKKceeEqTPiftXrdyReVxeZZnMXfKlzbamHDH4tmu5
 uIHJIOceEYYWIK7voSpTPIaerIo+P3sZxA592ut0uFJDsCA8oLjmdE40SgYzZLrWF9dMEE/f
 Gnl656Tk+bCBIqh7OAdx44tob41r/2vaOjRSRDKw8s6QGIgz/twqX9CQKk0hAXVC4K6as+8E
 De+jaJppmLgrWe8FvxxmXT55NZlJ/K0d1YHvGBjcATN3HFlhuoXoJ8QLeP1QpF491HqWxa0u
 UkkS1Qe/ib2EmhOV1dZiGdnTUI5QxerkMKD2Xo2EcL7/aJHA7SQPAx+r6xOiGplXbI+usMip
 6jlljpx6Z/HFfOmj/w6MPPUAwvnk2ooWA6mepWlHBHV5ACAYUh5rD2bCtuYeY99Q/Bmcka+d
 NVfYnhDTdtACenRmGcunMqzM2nX3w1EBvDSk8eutaN2zwTmHxi1UMXyMEWg39FrfsGOtR5zv
 WBNr4tmKBFT8cQY644DOAdQdGvAmiIRR7XKmqdLVnuCalCMXPQrJz85qkz+YiRCdY15Yp3nI
 6EXEJTtGY0dU6rAcqS3IdT+hSIW2m5VSSF8LAp23G4gMyKeFPGC1zwdLl1qbrSnxw2OLyvZ8
 qO
X-IronPort-AV: E=Sophos;i="5.90,136,1643691600"; 
   d="scan'208";a="67275415"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Bo6zoQ+3srPQIW/kgi3m+qsxAIkFo8BYoRQIhvizGqPE7K7479kTqWh65cUEJBh4c+fc32HB1/Fqriur1HYi2rteIJo0otdQR+VFTRb0TNhEPDt2Fv4c5l7lNy/4uDtz7fFiWZefNwgAitOguUnC9mKXwywEI49fClUmf2ObHYv8qmAppUOTpF+LScHpTJnI5OxJ1eWE3mc79JLrqQbVKHnRMxZZv/Qlm+Z0rLjvMm7pZBGoPgSxSK4azv8khp58zK8gHF6LcW1TBKTPHtKZdQGevkam3NSYdAVPr0T0X4E7ZEE0WFq4DuBwfIxeM6N7lggrJCK1/ObJ4Ns+qc/XxQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=txgGUiJ+6nBlTCNx2uw2Lxue+ffy4vVAQ9yyLvyT3Yc=;
 b=ZVs6Y+GCKAX5FbheY9NngBVwiodEWn2SfnXhYT333TCVY6+zYug08RCWmbhzQpw4j0KvG0vD8rUtliGTEtRk31U/y9/xWN6enzNTzhPfQuw4vVi2aREtirRuVkEzq8h5d4H98PUIIoqa1K5W5Gl6dn6gvghWGULMgdSwJg2USye/RNksk/BxfXpM2BcrdCafOLHjJcZoiDFJm00394TAQgXCs1J/xnicHbM2QlNouisf/ltCZfu7rA7EtwRTmnRaiJkOx2zrq4xyZA6a1iOj4sN36paHRis1VLrGHVqT6eZMT7pS8OKEMvQ51tDnsrwIaTznRAxh0HvIYsG1jPmlHA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=txgGUiJ+6nBlTCNx2uw2Lxue+ffy4vVAQ9yyLvyT3Yc=;
 b=KjEHBc/5exs9KLM3OS+iMPQGWU5WQTsjgQvXUs0LpN2H7pkMBF1mVwSs7XWAHpOXhU4ycn1FcNEPAy/iplXykRCqDcU5IhG4AvK2SxZjvwH1tk2NNwy43UT1FUiCBHM36LpT0Qb6LtOasqT3z7GsD9c7/3WseSgMeSqUBlsfWl0=
From: Edwin Torok <edvin.torok@citrix.com>
To: Anthony Perard <anthony.perard@citrix.com>
CC: Christian Lindig <christian.lindig@citrix.com>, Xen-devel
	<xen-devel@lists.xenproject.org>, David Scott <dave@recoil.org>, Wei Liu
	<wl@xen.org>
Subject: Re: [XEN PATCH v2 29/29] tools/ocaml: fix build dependency target
Thread-Topic: [XEN PATCH v2 29/29] tools/ocaml: fix build dependency target
Thread-Index: AQHYKlrZb2DloYmiEUGGLqB4eANGnaykZKqAgAAQIoCAAAGTgA==
Date: Fri, 25 Feb 2022 16:34:23 +0000
Message-ID: <F69E17D1-C936-4648-A8BB-C9FB64ABD769@citrix.com>
References: <20220225151321.44126-1-anthony.perard@citrix.com>
 <20220225151321.44126-30-anthony.perard@citrix.com>
 <C31BFB15-F511-452B-A249-1D6FDAC5F626@citrix.com>
 <YhkDu+oikp0Yd3sN@perard.uk.xensource.com>
In-Reply-To: <YhkDu+oikp0Yd3sN@perard.uk.xensource.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3693.40.0.1.81)
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 56d1882d-9d11-4d1e-aaa4-08d9f87cae26
x-ms-traffictypediagnostic: CY4PR03MB3269:EE_
x-microsoft-antispam-prvs: <CY4PR03MB326912372E490C2EF8BF47459B3E9@CY4PR03MB3269.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: DYjapxbFnuHE1zo5RnroD1CyqfIVe28wNS2iDZePmFLvI7VbQfXCnhICXrBtieskH4OLJLPiFqtqMlvD9ifu/UaNIZJSLTVq81236Ql91lbVjXuB164yQmNeB9rzozvknFAjK82Y/VqDpf5vlLLj51rAaGM4dc6AL6eDn936W+++s9NfhmGjUH/6KlWuMmEKCOfK809I3k9GMIvRwVPW59N7o8PvvYqN+t3/ViMkJqTShEhYA9qlqnPXS0eMnjBRrmMxIsZS2ZDC5DuNpUIQ1KL4KqD9unEA4DBGr8x1eBTffGe9ZwdkAfYzTjsISA70bBxPBHFu+4VoogSfznOVyrC1ajs4qGDVj43w5Wo0bzZv9Kq8ReRmu43+waVqU471MWY71Eyv2W4TY5KaNF2mTOGboWOIvS+VG9kA92BQ/dgdAs5jot8wpu/XfP0qg+5beOuexsUe3bZTtEydLB4avkeh02yJxJADXhv6KWKBFxAyFcn2r4zj3znAU5xFDa6OrPeLmg0SyJLcs5t6NS0PpSHRwKy/9NdLKVV2DBDiUbnF1cc9mnP5hQK58YZ8Rm1SNnKDsFtsXUq3mPWKPeFn2X/6FyHoQMw6ulapnATMxlsDVpthL1dwVpkKvnpNHuVxEtlJAnkMFj6Aa6KT6l7vXcrhY9T1xrpY5GHV8+EftPAcQBYUBxN113KNh9gZsVBHfKiQoSd/OkP0GmCugSTtAurDdd0GYAiAwCLj9zjy7zme21rHJ/HKR7NOSmGpddUV
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB5888.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(508600001)(186003)(2616005)(86362001)(33656002)(6506007)(6512007)(38070700005)(2906002)(6486002)(26005)(316002)(76116006)(5660300002)(66556008)(82960400001)(64756008)(66946007)(8676002)(91956017)(71200400001)(36756003)(6862004)(8936002)(54906003)(37006003)(122000001)(6636002)(38100700002)(4326008)(53546011)(66476007)(66446008)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?W419s8RDwdbwF2PLex6JnAS0CFOG3VJQjxtviyG04pAH6t8YLYV1mLV+exRe?=
 =?us-ascii?Q?pADDYi/pR83bhBVyG8+/tnLdV+jHo0kKTL3Lo9In73HgNnyem4KvHvbgJLGo?=
 =?us-ascii?Q?uAi5yiMgwkJ6BBPkTPiONY8w/GEWfXGV6ZC6mZ9y8rVmlfr9bhiv+wJWIk7u?=
 =?us-ascii?Q?+X7xIv46hYn3MUkFVMPdQBHqhSQH2TEarUhYPhmvNxqdxPJK1hObRPT3OQ0Q?=
 =?us-ascii?Q?tDh62EZiQH+kItmuFiBsI08sOljX+ysIUsxg8wjOUfQ5HxjmaZwgsZXYpUJ8?=
 =?us-ascii?Q?kUVP8DnYYsvkrEx6zYifIfv+NZ1K0WxBVWf7s6+UlYNVSdKVs/1AnBvYvqg4?=
 =?us-ascii?Q?FEO/RlARDL1WMstGNv3UC4S+I+tZvIlHZd1Jdn3j48IGr8LKkfiA6pKzBC/Y?=
 =?us-ascii?Q?/GimBH94f85PzEBvbicq2Jizfs5+osl6y5q5ZTuzIIRvPzdSNAmIrBTKBCXJ?=
 =?us-ascii?Q?Ynuq6zP2cS4jIawOSSMdRkyJUMBbHyaluM+KLdp9xgjkRhQiCiVJnB9SwOxI?=
 =?us-ascii?Q?ZjQk7Fv6LYxI0+Wayq/h2qOHk6196qFKb72jcnGRh0EEvMcCVsbl3HbWHY8t?=
 =?us-ascii?Q?e63npxiKaWcEgf8k5W5PTwjPY/S/IcZD1OvtXHULtKrT631ZabU4y6iPjT66?=
 =?us-ascii?Q?UiMXPxucaDFVVWqmD8/HIQjoGM7Pg2YZAHtbii9m80LjfhkEgvvE6Ly8XTZS?=
 =?us-ascii?Q?9HCwBqr1GxN2c83yrlKXyVwMaccSfvh27zgygh1UdAnbuNJzszWzqcW5gNyk?=
 =?us-ascii?Q?dNVGO+w5UPzeuZcElxQnlspPjpiQ6Nk10Cvm5Jrlbbu84gSc8l7W5XaRXf+a?=
 =?us-ascii?Q?2JYYxAnKicnyfh0UBVlaCVK5svtEqBO3XObaDpnYBWHBPuDuvcteoKRNwJkJ?=
 =?us-ascii?Q?mTvfd2vJmR2l3A0rJsbzcF2+dtYIN1Q13jr64xL1T6MjINrOkL/ejTKqHAqM?=
 =?us-ascii?Q?jDfHMEckuc7hn6B56kShfa/j/zKGnR7Yt56YFJpZf490p51L4pO3Xiye7Nvv?=
 =?us-ascii?Q?FqCz15UOBLUJoYdy+TlvprFWAB0bXgUnGKEhxAoe7Q7WxH1yiD77RSFGJuxA?=
 =?us-ascii?Q?8d86nqCBsvC/wTC6j0n3YeuAjAQFwyTy6H9UC+IOsb5VNeIpoE04h1E/OaDe?=
 =?us-ascii?Q?kAfXhVRM6wHmkAQyO2ZeD1C5pMu52eSmsm8vAgA5PsFHHloT4OCP4F3uCo4q?=
 =?us-ascii?Q?zoit8cwq7cz8ebuWOTYGxd83FG4PtXgUp4HpJYfA4Lx4wbyB1mM2ZCYVj1Ti?=
 =?us-ascii?Q?f2Y9Pzai557jmh7KRVfpaTOwDYaAjKSMu+ZXgnimfXr8F7JJQsxNqte1IlOt?=
 =?us-ascii?Q?bKu0TRy4R/i/zsw49Epf2pXWXQU1sL1crNAQmyU8L9XPtAM+mdIocLfuOnSZ?=
 =?us-ascii?Q?DCRthjo1chhGZEOMN1Iyg3+pK0zyTJqLt/RDKpmD7k4C2k+GmlMDBEJ5Hqlt?=
 =?us-ascii?Q?b0kI9UXfliU0nxOhiaLfP73fXxAzZTIT0pbDgdMx4aRvATBSI5u+vjCRqCCD?=
 =?us-ascii?Q?rl3fBRK4oNeM8CxJU/nwysoNCyybl0DZDHxLxTJkO9G1EzlPD88VFsILEaZ/?=
 =?us-ascii?Q?Y5sdq2n/4C6edxG2vOli0CvhEQwg361ibpqyNT89unmz60kI90pN08E6Zcfu?=
 =?us-ascii?Q?j+5Gg77v7yYa0t3I8zAKYzo=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <B75A6B12C7CBD3468F39564B9E4401C7@namprd03.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB5888.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 56d1882d-9d11-4d1e-aaa4-08d9f87cae26
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Feb 2022 16:34:23.0257
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: jYJSeB4eooa/PThKjNUs8Vr6g2GAG5FRWS2AVaeQuwYpy0cVGEadkITL7qElhBvvufEi1/LlP8IuLOhuWsxh8g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR03MB3269
X-OriginatorOrg: citrix.com



> On 25 Feb 2022, at 16:28, Anthony PERARD <anthony.perard@citrix.com> wrot=
e:
>=20
> On Fri, Feb 25, 2022 at 03:30:59PM +0000, Christian Lindig wrote:
>>=20
>>=20
>>> On 25 Feb 2022, at 15:13, Anthony PERARD <anthony.perard@citrix.com> wr=
ote:
>>>=20
>>> This patch fix ".ocamldep.make" rule by always spelling the variable
>>> $(OCAML_TOPLEVEL).
>>>=20
>>> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
>>> ---
>>>=20
>>> Notes:
>>>   v2:
>>>   - new patch
>>>=20
>>> tools/ocaml/libs/eventchn/Makefile   | 8 ++++----
>>> tools/ocaml/libs/mmap/Makefile       | 8 ++++----
>>> tools/ocaml/libs/xb/Makefile         | 8 ++++----
>>> tools/ocaml/libs/xc/Makefile         | 8 ++++----
>>> tools/ocaml/libs/xentoollog/Makefile | 8 ++++----
>>> tools/ocaml/libs/xl/Makefile         | 8 ++++----
>>> tools/ocaml/libs/xs/Makefile         | 8 ++++----
>>> tools/ocaml/Makefile.rules           | 2 +-
>>=20
>> Acked-by: Christian Lindig <christian.lindig@citrix.com>
>>=20
>> I am fine with this but in general think that the OCaml part should be b=
uilt using Dune (but invoked from Make), which is now the standard tool to =
build OCaml projects and is simple, fast, and accurate. Edwin maintains suc=
h a build for all development work on the OCaml side but it is not upstream=
ed.
>=20
> ocaml-dune doesn't seems to be available on debian oldstable. So I don't
> think we can use it for now.
>=20
> But thanks for pointing that out.
>=20


I think we should try to add it as an optional build-system: when available=
 use it, and at some point in the future remove the old one.
It is pretty much impossible to do development on the codebase without it, =
any developer who wants to make the changes to the OCaml code will likely w=
ant it.
(Of course those who only want to build and install oxenstored may not requ=
ire dune, and may be fine with the Makefiles as they wouldn't require incre=
mental builds or editor support).

Best regards,
--Edwin

> --=20
> Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Fri Feb 25 16:41:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 16:41:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279527.477251 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNdf1-0000kW-Ia; Fri, 25 Feb 2022 16:41:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279527.477251; Fri, 25 Feb 2022 16:41:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNdf1-0000kP-FP; Fri, 25 Feb 2022 16:41:39 +0000
Received: by outflank-mailman (input) for mailman id 279527;
 Fri, 25 Feb 2022 16:41:37 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nNdez-0000kJ-Lb
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 16:41:37 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nNdez-0006Fy-27; Fri, 25 Feb 2022 16:41:37 +0000
Received: from 54-240-197-226.amazon.com ([54.240.197.226]
 helo=[192.168.31.13]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nNdey-0003Rr-SF; Fri, 25 Feb 2022 16:41:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=j+s4BpypqEYU8nIQ67lJ3CtDHpzFI93+yBN3Gy8tHhM=; b=u1LzNFod7GHpxZuWJvtDRYPJM0
	n5LubCJDdUrL0/GaRgKA5Bj7hw8OZTiBgXII/882FtfpUJYALCCSyiY6QyV0cwgGl4BaAk3XQGmJ9
	OrglOEH+6XzmUiSLyoXPEPBtXG4aM9SlxQr0MHAO3yy6TaKtuWouEyl6vofvhD18HuWI=;
Message-ID: <9c6bbed2-14a1-87e9-cce0-dbc8e4488324@xen.org>
Date: Fri, 25 Feb 2022 16:41:34 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.1
Subject: Re: [PATCH v3 03/19] xen/arm: p2m: Replace level_{orders, masks}
 arrays with XEN_PT_LEVEL_{ORDER, MASK}
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Julien Grall <jgrall@amazon.com>, Stefano Stabellini
 <sstabellini@kernel.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20220221102218.33785-1-julien@xen.org>
 <20220221102218.33785-4-julien@xen.org>
 <66B2C3AB-A61C-4CC7-8249-AA925B2774FD@arm.com>
 <7a92b31a-ff09-3263-c25f-aba420adcce3@xen.org>
 <17D9F4AB-0FB1-4827-A564-4EBBDECF977A@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <17D9F4AB-0FB1-4827-A564-4EBBDECF977A@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit



On 25/02/2022 08:27, Bertrand Marquis wrote:
> Hi Julien,

Hi Bertrand,

> 
>> On 24 Feb 2022, at 22:41, Julien Grall <julien@xen.org> wrote:
>>
>>
>>
>> On 22/02/2022 15:55, Bertrand Marquis wrote:
>>> Hi Julien,
>>
>> Hi Bertrand,
>>
>>>> On 21 Feb 2022, at 10:22, Julien Grall <julien@xen.org> wrote:
>>>>
>>>> From: Julien Grall <jgrall@amazon.com>
>>>>
>>>> The array level_orders and level_masks can be replaced with the
>>>> recently introduced macros LEVEL_ORDER and LEVEL_MASK.
>>>>
>>>> Signed-off-by: Julien Grall <jgrall@amazon.com>
>>> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
>>> One open question: At this stage the convenience aliases that you
>>> kept in include/asm/lpae.h are used in a very limited number of places.
>>
>> I am not sure I would call it very limited:
>>
>> 42sh> ack "(FIRST|SECOND|THIRD)_(ORDER|SHIFT|MASK)" | wc -l
>> 65
>>
>> That's including the 9 definitions.
> 
> My bad I looked with your full serie in my tree.
> 
>>
>>> Could we remove those and use only XEN_PT_LEVEL_* to make the
>>> code a bit more coherent.
>>
>> I made an attempt in the past and it resulted to longer line in assembly. So I am on the fence to whether the aliases should be completely removed.
>>
>> At the same time, XEN_PT_LEVEL(...) is handy for places where we don't know at compile time the level.
> 
> One other big argument for making the switch is that XEN_PT_LEVEL is far more specific then FIRST_ORDER and others which are very unspecific names.

How about renaming them to XEN_PT_L0_ORDER? Or maybe XPT_L0_ORDER?

This would allows us to keep the assembly line relatively short.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Feb 25 16:43:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 16:43:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279533.477262 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNdgW-0001LA-U4; Fri, 25 Feb 2022 16:43:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279533.477262; Fri, 25 Feb 2022 16:43:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNdgW-0001L3-Qq; Fri, 25 Feb 2022 16:43:12 +0000
Received: by outflank-mailman (input) for mailman id 279533;
 Fri, 25 Feb 2022 16:43:11 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nNdgV-0001Kr-JR; Fri, 25 Feb 2022 16:43:11 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nNdgV-0006HI-H6; Fri, 25 Feb 2022 16:43:11 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nNdgV-00077X-2p; Fri, 25 Feb 2022 16:43:11 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nNdgV-000214-2J; Fri, 25 Feb 2022 16:43:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=BJwjExSqRxKP22m6Yc2K8X9zPbqv3XmkMl+3aWbcjFU=; b=3Ocs+Wlyagrq47syUhjk7DZk5n
	XtcEE0LdFcmhO32KGH8ARKUM+DM9HcSTCwqa2U/QIg2ywyfvaNEeLyalW4lChTbszgw7Ie2LPxHQm
	8fyCWoNys1NnMJT4L1PkVQxKNA0AALZnzrrMBduVE6yE5Eo7Ivg/kA9cKgk6O8VxrFEs=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168227-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 168227: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=53ab78cd6d5aba25575a7cfb95729336ba9497d8
X-Osstest-Versions-That:
    linux=73878e5eb1bd3c9656685ca60bc3a49d17311e0c
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 25 Feb 2022 16:43:11 +0000

flight 168227 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168227/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168221
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168221
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168221
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168221
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168221
 test-armhf-armhf-xl-rtds     18 guest-start/debian.repeat    fail  like 168221
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168221
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168221
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168221
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                53ab78cd6d5aba25575a7cfb95729336ba9497d8
baseline version:
 linux                73878e5eb1bd3c9656685ca60bc3a49d17311e0c

Last test of basis   168221  2022-02-24 19:41:23 Z    0 days
Testing same since   168227  2022-02-25 08:51:05 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Aaron Lewis <aaronlewis@google.com>
  Alex Deucher <alexander.deucher@amd.com>
  Alex Vesker <valex@nvidia.com>
  Alexei Starovoitov <ast@kernel.org>
  Alexey Bayduraev <alexey.v.bayduraev@linux.intel.com>
  Alok Prasad <palok@marvell.com>
  Alvin Šipraga <alsi@bang-olufsen.dk>
  Anton Romanov <romanton@google.com>
  Ariel Elior <aelior@marvell.com>
  Ariel Levkovich <lariel@nvidia.com>
  Arnaldo Carvalho de Melo <acme@redhat.com>
  Baruch Siach <baruch.siach@siklu.com>
  Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
  Bjorn Helgaas <bhelgaas@google.com>
  Brian Vazquez <brianvv@google.com>
  Chen Gong <curry.gong@amd.com>
  Chris Mi <cmi@nvidia.com>
  Christian König <christian.koenig@amd.com>
  Christophe JAILLET <christophe.jaillet@wanadoo.fr>
  Christophe Leroy <christophe.leroy@csgroup.eu>
  Dan Carpenter <dan.carpenter@oracle.com>
  Daniel Borkmann <daniel@iogearbox.net>
  Daniel Wheeler <daniel.wheeler@amd.com>
  Dany Madden <drt@linux.ibm.com>
  Dave Airlie <airlied@redhat.com>
  David S. Miller <davem@davemloft.net>
  Dmitry Osipenko <digetx@gmail.com>
  Duoming Zhou <duoming@zju.edu.cn>
  Eric Dumazet <edumazet@google.com>
  Evan Quan <evan.quan@amd.com>
  Fabio M. De Francesco <fmdefrancesco@gmail.com>
  Felix Maurer <fmaurer@redhat.com>
  Florian Westphal <fw@strlen.de>
  Gal Pressman <gal@nvidia.com>
  German Gomez <german.gomez@arm.com>
  Guchun Chen <guchun.chen@amd.com>
  Gurucharan G <gurucharanx.g@intel.com> (A Contingent worker at Intel)
  Heyi Guo <guoheyi@linux.alibaba.com>
  Imre Deak <imre.deak@intel.com>
  Jacob Keller <jacob.e.keller@intel.com>
  Jakub Kicinski <kuba@kernel.org>
  Jasdeep Dhillon <jdhillon@amd.com>
  Jason Wang <jasowang@redhat.com>
  Jeremy Linton <jeremy.linton@arm.com>
  Jiri Olsa <jolsa@kernel.org>
  John Fastabend <john.fastabend@gmail.com>
  John Garry <john.garry@huawei.com>
  Jon Hunter <jonathanh@nvidia.com>
  Jon Hunter <jonathanh@nvidia.com> # T186
  Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
  Karsten Graul <kgraul@linux.ibm.com>
  koba.ko@canonical.com
  Konrad Dybcio <konrad.dybcio@somainline.org>
  Konrad Jankowski <konrad0.jankowski@intel.com>
  Kumar Kartikeya Dwivedi <memxor@gmail.com>
  Lama Kayal <lkayal@nvidia.com>
  Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>
  Leo Yan <leo.yan@linaro.org>
  Leonardo Bras <leobras@redhat.com>
  Leslie Shi <Yuliang.Shi@amd.com>
  Liang Zhang <zhangliang5@huawei.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Maher Sanalla <msanalla@nvidia.com>
  Manish Chopra <manishc@marvell.com>
  Maor Dickman <maord@nvidia.com>
  Maor Gottlieb <maorg@nvidia.com>
  Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
  Marco Elver <elver@google.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Mario Limonciello <mario.limonciello@amd.com>
  Mat Martineau <mathew.j.martineau@linux.intel.com>
  Mateusz Palczewski <mateusz.palczewski@intel.com>
  Matt Roper <matthew.d.roper@intel.com>
  Mauri Sandberg <maukka@ext.kapsi.fi>
  Maxim Levitsky <mlevitsk@redhat.com>
  Maxime Ripard <maxime@cerno.tech>
  Meir Lichtinger <meirl@nvidia.com>
  Michael Chan <michael.chan@broadcom.com>
  Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
  Michel Dänzer <mdaenzer@redhat.com>
  Mikko Perttunen <mperttunen@nvidia.com>
  Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
  Nicholas Piggin <npiggin@gmail.com>
  Niels Dossche <dossche.niels@gmail.com>
  Niels Dossche <niels.dossche@ugent.be>
  Oleksij Rempel <o.rempel@pengutronix.de>
  Oliver Neukum <oneukum@suse.com>
  Pablo Neira Ayuso <pablo@netfilter.org>
  Pali Rohár <pali@kernel.org>
  Paolo Abeni <pabeni@redhat.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Paul Blakey <paulb@nvidia.com>
  Paul Menzel <pmenzel@molgen.mpg.de>
  Pavan Chebbi <pavan.chebbi@broadcom.com>
  Qiang Yu <qiang.yu@amd.com>
  Roi Dayan <roid@nvidia.com>
  Rudi Heitbaum <rudi@heitbaum.com>
  Saeed Mahameed <saeedm@nvidia.com>
  Sandeep Penigalapati <sandeep.penigalapati@intel.com>
  Sean Tranchetti <quic_stranche@quicinc.com>
  Siarhei Volkau <lis8215@gmail.com>
  Simon Horman <simon.horman@corigine.com>
  Somnath Kotur <somnath.kotur@broadcom.com>
  Stefano Garzarella <sgarzare@redhat.com>
  Stephen Boyd <sboyd@kernel.org>
  Subash Abhinov Kasiviswanathan <quic_subashab@quicinc.com>
  Sukadev Bhattiprolu <sukadev@linux.ibm.com>
  suresh kumar <suresh2514@gmail.com>
  Svenning Sørensen <sss@secomea.com>
  Tao Liu <thomas.liu@ucloud.cn>
  Tariq Toukan <tariqt@nvidia.com>
  Thierry Reding <thierry.reding@gmail.com>
  Thierry Reding <treding@nvidia.com>
  Thomas Zimmermann <tzimmermann@suse.de>
  Tom Rix <trix@redhat.com>
  Tony Nguyen <anthony.l.nguyen@intel.com>
  Tvrtko Ursulin <tvrtko.ursulin@intel.com>
  Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
  Ville Syrjälä <ville.syrjala@linux.intel.com>
  Vladimir Oltean <vladimir.oltean@nxp.com>
  Wan Jiabing <wanjiabing@vivo.com>
  Wanpeng Li <wanpengli@tencent.com>
  Wojciech Drewek <wojciech.drewek@intel.com>
  Xiaoke Wang <xkernel.wang@foxmail.com>
  Xin Long <lucien.xin@gmail.com>
  Yevgeny Kliteynik <kliteyn@nvidia.com>
  Yonghong Song <yhs@fb.com>
  Zhengjun Xing <zhengjun.xing@linux.intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   73878e5eb1bd..53ab78cd6d5a  53ab78cd6d5aba25575a7cfb95729336ba9497d8 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Fri Feb 25 17:12:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 17:12:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279549.477281 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNe8j-0004tV-IE; Fri, 25 Feb 2022 17:12:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279549.477281; Fri, 25 Feb 2022 17:12:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNe8j-0004tO-DI; Fri, 25 Feb 2022 17:12:21 +0000
Received: by outflank-mailman (input) for mailman id 279549;
 Fri, 25 Feb 2022 17:12:20 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ZUh1=TI=citrix.com=prvs=04827bf5e=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nNe8i-0004tF-CV
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 17:12:20 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 154aa887-965e-11ec-8eb9-a37418f5ba1a;
 Fri, 25 Feb 2022 18:12:18 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 154aa887-965e-11ec-8eb9-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645809138;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=x/GdCrGTBYXVKADzhTOUA4HbsusNoi9AZZ+DqQY6uWA=;
  b=XZgDvsFIh/6PLvEWwtN8X8ECBkqNEyvvwaCe/ZMloAfaYtTmXKUBm8Oz
   sOa6CXAWiGHEvKI2VJbn1YxK6yqMkx02ihES2Rq+Ueluj1MwL0geXBaOi
   scstJ2PawgBeWec5G5WqvgPLEnCnsTFRGkGUFxCcNNRg1zQPUcsOvJCAv
   o=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 65009921
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:mthBEKmratUbZwjVRMRYaqro5gx6JkRdPkR7XQ2eYbSJt1+Wr1Gzt
 xJLWm+EPP3eZmSjeNF+ao/g/BwBuMPQy9dhHQtu/ns0FSMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EoLd9IR2NYy24DjWV7V4
 7senuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR
 v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ
 NtxWZOYbQZqbvzBxvshCRgFGCtifpVG/bXtLi3q2SCT5xWun3rExvxvCAc9PJEC+/YxCmZLn
 RAaAGlTNFbZ3bvwme/lDLk37iggBJCD0Ic3k3ds1zzGS90hRojOWf7i7t5ExjYgwMtJGJ4yY
 uJHNGI3PUWaOnWjPH9MKbwCzfXwuEPzcgVUuFWNlIsT3UfqmVkZPL/Fb4OOJ43iqd9utkKfq
 WXL5Xj5AxcXLoW3kGTetHmrg4fnmCrhXYsIGb6Q9/h0gUaSzGgeFB0XU1SgpfCzzEW5Xrp3O
 0ESvyYjs6U23EiqVcXmGQ21pmaeuRwRUMYWFPc1gCmOx7TV5UCFB2ECZj9HdNEi8sQxQFQC1
 FWEgtfoDjxHq6CORDSW8bL8hSy2ETgYKykFfyBsZQkY5Z/lqYI6jBPKR/5iFrK4ipv+HjSY/
 tyRhHFg3fNJ15dNjvjluwCc696xmnTXZio0pVWGUzy60ll4OYWve8+Q6V3Rx/kVee51UWK9l
 HQDnsGf6sUHApeMiDGBTY0xIV252xqWGGaC2AAyRvHN4xzooif+Jt4IvFmSMW80ap5sRNP/X
 KPEVeq9Drd3NWDiU6J4apnZ5y8Cnfm5ToSNuhw5g7NzjnlNmO2voHAGia24hTmFfK0QfUcXY
 8bznSGEVytyNEif5GDqL9rxKJdyrszE+UvdRIrg0zOs2qeEaXieRN8taQXSM79ltf/Z+F2Nq
 76z0vdmLT0FAYUShQGNrOYuwa0idyBnVfgaVeQNHgJ8HuaWMD54UKKAqV/QU4dkg75Uho/1E
 oKVASdlJK7ErSSfc22iMyk7AJu2BMoXhS9rbEQEYAfzs1B+MNnH0UvqX8ZuFVXR3Lc4lqAco
 jhsU5joP8mjvRyco2VNNcSm9dc6HPlp7CrXVxeYjPEEV8cIbyTC+8P+fxup8y8LDyGtstA5r
 aHm3QTeKafvjSw+ZCoKQJpDF2+MgEU=
IronPort-HdrOrdr: A9a23:YDY6Aa9h5CUlksDAS9puk+F+db1zdoMgy1knxilNoENuHPBwxv
 rAoB1E73PJYW4qKQ0dcdDpAtjlfZtFnaQFoLX5To3SIzUO31HYbL2KjLGSjQEIfheeygcz79
 YZT0ETMqyTMbE+t7eG3ODaKadi/DDkytHSuQ629R4EJmsGC9AC0+46MHfgLqQffngaOXNTLu
 v62iMznUvYRZ1hVLXcOpBqZZmnm/T70LbdJTIWDR8u7weDyRmy7qThLhSe1hACFxtS3LYL6w
 H+4k7Ez5Tml8v+5g7X1mfV4ZgTssDm0MF/CMuFjdVQAinwizyveJ9qV9S5zXUISaCUmRIXee
 v30lEd1vdImirsl6aO0EPQMjzboXETArnZuASlaDXY0JbErXkBerR8bMpiA2rkAgwbzY1BOe
 twrhGkX9A8N2KxoA3to9fPTB1kjUyyvD4rlvMSlWVWVc8EZKZWtpF3xjIZLH6uJlOM1GkLKp
 gkMCjn3ocdTbpaVQGugkB/hNi3GngjFBaPRUYP/sSTzjhNhXh8i08V3tYWkHsM/I80D8As3Z
 WKDo140LVVCsMGZ6N0A+kMBcOxF2zWWBrJdGafO07uGq0LM2/E75T3/LI27ue3f4Fg9up/pL
 3RFFdD8WIicUPnDsODmJVN7xDWWW24GS/gz8lPjqIJ8oEUhICbeBFrZGpe5vdI+c9vcPEzc8
 zDTK5rPw==
X-IronPort-AV: E=Sophos;i="5.90,136,1643691600"; 
   d="scan'208";a="65009921"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=JICo6OVbANMR5UI3P+8PzWsYOB22Z9Gf0n6Ybd4b2d5CfxWkB+aKXUULayxIs8mWL1s67xvza9mgGUsvphZmaddp2xuZmMj0ynbQPJRWuQtIAdLIWSbOeZUOOjLWDWHgSzjcSIDpAtv+lLoXdG2o2OCxrCNMGNyWnjh2pdyRmBVjcNaVHcom/qnQp/qQ5/UcoQIXhX29ZtAgkJuzBuyWXGT7L9m935ZOCwP6wTJDXP0kkOEq6sKBq9Rgft05EfGANaLPjmvcO73AzUWZ4qbLeOLpwtYihDzNn5n1fvg8DybGy0xfHtWq6Stae/xNVCpsPFzK0lYy7D/0EJ8empBw5g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=x/GdCrGTBYXVKADzhTOUA4HbsusNoi9AZZ+DqQY6uWA=;
 b=Sbd7DpMurB1VezpfyFsJhDFnTiSSKlYB2qcmFywWBA+S1FUPHtB0Fi6jsHEyzpHVOYBK7ZO9/zUbPU9DrRWZbTboR1bzvgASZhc/BURHZNA/5bNg12TawwTsEGUm0lnIfeMODgrNnYc8D7CDrcT5+xyGvB8bhzQilW1vxj1nZfG5OduftX/uC7AhfrD+8j6lZn8/92viWO6HXtgnhMAThcQ6yD+VF5IqLCnhwC/aHpKXM8v0aejY8ax5IwjLY45weMBinwl9b750ELgY4CY6cxXB7CNcqqS/4laOb/QilzI7rU3Dn9C1sREEoRxoY6tcrhHUrquHIYaK54YwkquZ4Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=x/GdCrGTBYXVKADzhTOUA4HbsusNoi9AZZ+DqQY6uWA=;
 b=ZGqrWrUvyGCBtXK1rep8LxkR01ThD+nyZLiJvHGQI171LUCMhMPJkeH8UiQI4TlAN/bZplrGcyFJpfDifsnTOIWiMopXWMLZ44PNjPN4/OBGqAE9pHmeOP9jMzWxn4Qsi1gZgt8FJaTHrslP7+MRVQkL4SQNEu39318M9L0MbPs=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>, Jun Nakajima
	<jun.nakajima@intel.com>, Kevin Tian <kevin.tian@intel.com>, Thiner Logoer
	<logoerthiner1@163.com>, =?utf-8?B?TWFyZWsgTWFyY3p5a293c2tpLUfDs3JlY2tp?=
	<marmarek@invisiblethingslab.com>, Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: x86/vmx: Don't spuriously crash the domain when INIT is received
Thread-Topic: x86/vmx: Don't spuriously crash the domain when INIT is received
Thread-Index: AQHYKben+W9NHlmgjUe5tEPatIDj2Kyj9FgAgAA+noCAAA5JgIAAQNgA
Date: Fri, 25 Feb 2022 17:11:45 +0000
Message-ID: <965e91fa-1f1e-7c57-5a71-a09b170a7d9f@citrix.com>
References: <20220224194853.17774-1-andrew.cooper3@citrix.com>
 <20220224194853.17774-3-andrew.cooper3@citrix.com>
 <12d8b90b-15b0-c094-71e5-35cfdbfe72b4@suse.com>
 <51ef6bd1-bcd9-9a3a-e902-887d42d7dd7e@citrix.com>
 <bb4b4106-f49d-2b50-1eb9-eb450f6b24fa@suse.com>
In-Reply-To: <bb4b4106-f49d-2b50-1eb9-eb450f6b24fa@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 0b60f35d-bb87-4f2c-df01-08d9f881e6d2
x-ms-traffictypediagnostic: BYAPR03MB3688:EE_
x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
x-microsoft-antispam-prvs: <BYAPR03MB36881637D80AF0CAF27D63C0BA3E9@BYAPR03MB3688.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 8SLncy9PrrUKmi64TFLZuPJK0Mt5MLmuDrV+IRa79c2EYUNBW0hG/kpdf6WvRgOVgtGtyofVfWN74Gc5orij1Dnm6VGjh6YfCSfofQMkCcK93qTB+VUVkUQIpvc18kdvYnX3Qu2wodjlS6M2fSXKYbVoxlFGAj2I7Fe7lLApghNc40F/UGozD8k74BapuyYBAnsXp+1YzM0uXNPzFfNaq/YI0/RU3YS9smrP+l9pFf81SyRprJq192fFDb5wohzgUD8ifyyivIQIt8MCXVDk9pZtS9xysQOEN3k/XK/c7G0zJ3LkL2qeU/QXu5DiXKYm6ELL2W4lsllprNE7DdkYeQ3OWOaGUI6AqTl4GE/YelvhXGcCBpekVH+jCavAJGUK1rtzw+PIm2WLY987Tq/CjZhISCtijrPYDkoD0mZvCooGtsVCt83WJp8qcR6e87jg8bNBCdmpCnrlu0AuJACD567lAA/hLonnE0zWp3CNGdXvj3RKZPqNUvZgA/skLwg8/22UJRjp+6AFpVA8ZzybCcy59Vpl1oP9GQVPMU6aQMdhn3sWHek8MbgxxZyxYxBkjeOEnVXaRMX2ctRQaoNeGzdJTeryoX5Yprs3Bgy0m41A8WtYZJbCtsBj49a8bRQiHd6Xae655dZeYwJNo0RKTrPHAccOUPdHqexGrrqvLcO4RWQ5mIoDwF+a/otWJW8fBb7weYkoLcI/FZ+SG+Wi23g1HvjZ2mNP/UvY4SwCu3Hn7mzmcIWpKhkMcVTAdv2selhfXNS/D9rsCkRYbABQjA==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(31696002)(5660300002)(86362001)(26005)(186003)(83380400001)(6916009)(54906003)(36756003)(31686004)(91956017)(53546011)(66476007)(122000001)(316002)(66946007)(6506007)(6512007)(76116006)(508600001)(6486002)(82960400001)(4326008)(71200400001)(8936002)(2616005)(66446008)(64756008)(2906002)(8676002)(66556008)(38100700002)(38070700005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?NWQ4R1l3L1IzeW0rTDA1WC9VMFNsajR1NkE0MS9JTFIyZElzS2YwRGd4VWta?=
 =?utf-8?B?WEw0ZmsxZEV6WEpsZEFHWXVwSjU1ZHNrclNUODlrRG5EQngvSTNtbENpRXZK?=
 =?utf-8?B?bU1nZnp2dGlhY2hKU21HVHpWL1M4T010cVRQYllyR1VXL2tmdm82b0ZyQWhl?=
 =?utf-8?B?YkV6K2VNWXUxMHR2NEc1Rm8wTmZUa1pEZ3VzR05qR3R4NGdQSnNERFdSNVQz?=
 =?utf-8?B?Zkk2eXBTOWZNUkxsMzV0UG1hT0h6WURQSkVBK0taendGS0hveUxZNTBMclhC?=
 =?utf-8?B?ZzFTTDNqL0U3bG9IODIyZjdnb3VZQXJhWFV2V3ZlaUxHaHEvdGxGakNTakFo?=
 =?utf-8?B?dWtxQWdtQi9EV05tcVk2MDl5SCtLQkhtNm5kaFlmcGw4K08xLzFVWDJaOTJF?=
 =?utf-8?B?eHpwWkx0ckFncnZCT3ozejNLTUh0bmtIemRDM3U4aUp5T0dpSmxYYklhZkUx?=
 =?utf-8?B?MXc5elpMaGFiUWMvbzNHTExURlNjVWNiUTgzRlcwYjc3bERTakt3eWVidW5R?=
 =?utf-8?B?cTNrSFI5WFBHTVdCbVFlUVA0WTJodlJvRlJwdU81MWFvTFhBazE5STV3MzFH?=
 =?utf-8?B?NG5QQldJM205aEgzNDFGZm80Mk51Tzd3UU1ueW55OFNaYzdnbXRjVEJmU2ww?=
 =?utf-8?B?S091TmtEWlM2dVRCM21xU0oveXkvTkl4eW1xdkFGdUVLSWVIY04zeGlCMmQ1?=
 =?utf-8?B?M09QVUU0a2J3d0JwYzJwOWZwd2NtZDVvNU9xRUs5Uzh2YzRCcGVSVzhRTll1?=
 =?utf-8?B?WEY1Q3RsUEpRczN0eFFFQTZnUjhMWWRuQ0NNQnZ4YXBwZWlQY05oYW1QSHVr?=
 =?utf-8?B?SldUY2tiYVc4cTNSUktCdldXQUE0ZVhJZVJqWjZsdlp0QmNmaWk3b3ZFQ3JW?=
 =?utf-8?B?K2pPZ3dIN1ZlbmVOcWhJMC9DdGhMaUU5UzlzQXB3M29zcnpLTmxnbWZQZlBj?=
 =?utf-8?B?cjYrZXhFUjFnaWRqM084THB5VEV0aVJBZEVkMU1iL2hCY3p2bmEyeXBqUFBi?=
 =?utf-8?B?dXJjNXY3UkZxaHY1ZmpISkROZVNvSzVqMVphd2VySm5tbHIxM1k1QmtldlFr?=
 =?utf-8?B?QU5sNzNYcTVSM1JiK3lLdGNqYW5pYWxwTEtIdHZjOFlCTnoyVDVBdTBLOXc0?=
 =?utf-8?B?bDdFeUxZVWtBSjU5RGszeS9MZTVjZ1NKL29iQldYWkxYaWNRMjEyUXRkU0x5?=
 =?utf-8?B?REN6eWFrYUtlNTNmSzJMNzY3RStqcHhVRUsxa20xejczd0ZCUC95SlJyOFBj?=
 =?utf-8?B?dnBsNEFuNS9xN0R5ejBBWFZrYStNazBXRi9YRXlwb3YrWHIwSmZQc3M2dkZJ?=
 =?utf-8?B?UVFGTkFUZ1N5L1NwRGVqOUlDKy9iZEhBTUNiUjAxcjJBQWhTV2ZON0xXL3ds?=
 =?utf-8?B?cUZJVVR5cmZMVnJFRnBTZE4yZEtQcW5UMTM3ZFdqWmtjYlVpRzdVMUtVRTNq?=
 =?utf-8?B?OURwdlFLeTl5ODZoZTcxcFM3N0VSRG1USEZmQXhJN0ZjdmVZUnJ2a012TXRD?=
 =?utf-8?B?d1FsZktjOUJBWHRFeDNQQ0NYY2lDVXAwQ01XQjFENjFHZTVJazFKbzlWbnpI?=
 =?utf-8?B?MEsyVVYxemhUQ0psYjROUzB0WngvZWRmWEJRL3VuTktQRVBZdkVqMjZZUGo1?=
 =?utf-8?B?NXUrU1VTQjJnNXpUOEtEQnlvUkVHNHRTN0hZL1lhSW1YZ0sxWC9naWpuVzc0?=
 =?utf-8?B?MVVENHdvRjhUTzROT09OVUI2Q3g0RGQ4cmplNC95VjhRRHpkaXBxYnBhN28r?=
 =?utf-8?B?N3FpS21aN1hKRkoyRHp1dEZSdzVZYnlNeklFczR4aTR0V2grZWZKSGhuQURs?=
 =?utf-8?B?YzVxQi9WR1ZCMU11WXp3U05icDJKR1pCampKUWF4TDl4Ykg5bXp2ZkhMK0Qv?=
 =?utf-8?B?eDc4ODJOTnRNcTVSSUdxdjhIODdVa2J2TzZhYk80Q3BaTk1jWldhZGtkQzd3?=
 =?utf-8?B?ZmtGNEVydTdEMnBGbTVuYnFxNGpBd29VYTF3T203aGRhYXdQeElwakcycStL?=
 =?utf-8?B?UGJCMVNOcTlpWDFqZEU4YU9Ta2lwZWszZkFLcjJoTTR1NGREUXR6aHljS1Zn?=
 =?utf-8?B?VEVTRzl2K0lPcjUvbXRzTTBEQ1U2YTQ5VE9wU0t3d1RuMlBUSEt2U2p1TEZ1?=
 =?utf-8?B?TWk1Y0tXMTBFeUpCOHB3S1NHc1AwVjFVV09wMmRjaFVCV1FhTkdoU1FVNXNi?=
 =?utf-8?B?NTdleUhvNGtrZTR6U29NOTliZERnMk5BaUFpMnF1blJQMDNicVhFSXNGOVVa?=
 =?utf-8?B?cjlTREk5NDE5Zi9KdERJRTFqUW13PT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <40ED024FD7376C42BEAC46AA39763A4E@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0b60f35d-bb87-4f2c-df01-08d9f881e6d2
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Feb 2022 17:11:45.5747
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: j0ClOWScRMxu4Yqb2lzP+A8MN9TgYwLuY2ltBpthdWxQBM29Qf0kqW3dsiavZZ6DCso0rGbQYdTNyCh4nj99raGG+reVuw1ceCYET4aJYN4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB3688
X-OriginatorOrg: citrix.com

T24gMjUvMDIvMjAyMiAxMzoxOSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDI1LjAyLjIwMjIg
MTM6MjgsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBPbiAyNS8wMi8yMDIyIDA4OjQ0LCBKYW4g
QmV1bGljaCB3cm90ZToNCj4+PiBPbiAyNC4wMi4yMDIyIDIwOjQ4LCBBbmRyZXcgQ29vcGVyIHdy
b3RlOg0KPj4+PiBJbiBWTVggb3BlcmF0aW9uLCB0aGUgaGFuZGxpbmcgb2YgSU5JVCBJUElzIGlz
IGNoYW5nZWQuICBFWElUX1JFQVNPTl9JTklUIGhhcw0KPj4+PiBub3RoaW5nIHRvIGRvIHdpdGgg
dGhlIGd1ZXN0IGluIHF1ZXN0aW9uLCBzaW1wbHkgc2lnbmFscyB0aGF0IGFuIElOSVQgd2FzDQo+
Pj4+IHJlY2VpdmVkLg0KPj4+Pg0KPj4+PiBJZ25vcmluZyB0aGUgSU5JVCBpcyBwcm9iYWJseSB0
aGUgd3JvbmcgdGhpbmcgdG8gZG8sIGJ1dCBpcyBoZWxwZnVsIGZvcg0KPj4+PiBkZWJ1Z2dpbmcu
ICBDcmFzaGluZyB0aGUgZG9tYWluIHdoaWNoIGhhcHBlbnMgdG8gYmUgaW4gY29udGV4dCBpcyBk
ZWZpbml0ZWx5DQo+Pj4+IHdyb25nLiAgUHJpbnQgYW4gZXJyb3IgbWVzc2FnZSBhbmQgY29udGlu
dWUuDQo+Pj4+DQo+Pj4+IERpc2NvdmVyZWQgYXMgY29sbGF0ZXJhbCBkYW1hZ2UgZnJvbSB3aGVu
IGFuIEFQIHRyaXBsZSBmYXVsdHMgb24gUzMgcmVzdW1lIG9uDQo+Pj4+IEludGVsIFRpZ2VyTGFr
ZSBwbGF0Zm9ybXMuDQo+Pj4gSSdtIGFmcmFpZCBJIGRvbid0IGZvbGxvdyB0aGUgc2NlbmFyaW8s
IHdoaWNoIHdhcyAob25seSkgb3V0bGluZWQgaW4NCj4+PiBwYXRjaCAxOiBXaHkgd291bGQgdGhl
IEJTUCByZWNlaXZlIElOSVQgaW4gdGhpcyBjYXNlPw0KPj4gU0hVVERPV04gaXMgYSBzaWduYWwg
ZW1pdHRlZCBieSBhIGNvcmUgd2hlbiBpdCBjYW4ndCBjb250aW51ZS7CoCBUcmlwbGUNCj4+IGZh
dWx0IGlzIG9uZSBjYXVzZSwgYnV0IG90aGVyIHNvdXJjZXMgaW5jbHVkZSBhIGRvdWJsZSAjTUMs
IGV0Yy4NCj4+DQo+PiBTb21lIGV4dGVybmFsIGNvbXBvbmVudCwgaW4gdGhlIFBDSCBJIGV4cGVj
dCwgbmVlZHMgdG8gdHVybiB0aGlzIGludG8gYQ0KPj4gcGxhdGZvcm0gcmVzZXQsIGJlY2F1c2Ug
b25lIG1hbGZ1bmN0aW9uaW5nIGNvcmUgY2FuJ3QuwqAgSXQgaXMgd2h5IGENCj4+IHRyaXBsZSBm
YXVsdCBvbiBhbnkgbG9naWNhbCBwcm9jZXNzb3IgYnJpbmdzIHRoZSB3aG9sZSBzeXN0ZW0gZG93
bi4NCj4gSSdtIGFmcmFpZCB0aGlzIGRvZXNuJ3QgYW5zd2VyIG15IHF1ZXN0aW9uLiBDbGVhcmx5
IHRoZSBzeXN0ZW0gZGlkbid0DQo+IHNodXQgZG93bi4NCg0KSW5kZWVkLCAqYmVjYXVzZSogWGVu
IGNhdWdodCBhbmQgaWdub3JlZCB0aGUgSU5JVCB3aGljaCB3YXMgb3RoZXJ3aXNlDQpzdXBwb3Nl
ZCB0byBkbyBpdC4NCg0KPiAgSGVuY2UgSSBzdGlsbCBkb24ndCBzZWUgd2h5IHRoZSBCU1Agd291
bGQgc2VlIElOSVQgaW4gdGhlDQo+IGZpcnN0IHBsYWNlLg0KPg0KPj4+IEFuZCBpdCBhbHNvIGNh
bm5vdCBiZSB0aGF0IHRoZSBJTklUIHdhcyByZWNlaXZlZCBieSB0aGUgdkNQVSB3aGlsZSBydW5u
aW5nIG9uDQo+Pj4gYW5vdGhlciBDUFU6DQo+PiBJdCdzIG5vdGhpbmcgKHJlYWxseSkgdG8gZG8g
d2l0aCB0aGUgdkNQVS7CoCBJTklUIGlzIGEgZXh0ZXJuYWwgc2lnbmFsIHRvDQo+PiB0aGUgKHJl
YWwpIEFQSUMsIGp1c3QgbGlrZSBOTUkvZXRjLg0KPj4NCj4+IEl0IGlzIHRoZSBuZXh0IFZNRW50
cnkgb24gYSBDUFUgd2hpY2ggcmVjZWl2ZWQgSU5JVCB0aGF0IHN1ZmZlcnMgYQ0KPj4gVk1FbnRy
eSBmYWlsdXJlLCBhbmQgdGhlIFZNRW50cnkgZmFpbHVyZSBoYXMgbm90aGluZyB0byBkbyB3aXRo
IHRoZQ0KPj4gY29udGVudHMgb2YgdGhlIFZNQ1MuDQo+Pg0KPj4gSW1wb3J0YW50bHkgZm9yIFhl
biBob3dldmVyLCB0aGlzIGlzbid0IGFwcGxpY2FibGUgZm9yIHNjaGVkdWxpbmcgUFYNCj4+IHZD
UFVzLCB3aGljaCBpcyB3aHkgZG9tMCB3YXNuJ3QgdGhlIG9uZSB0aGF0IGNyYXNoZWQuwqAgVGhp
cyBhY3R1YWxseQ0KPj4gbWVhbnQgdGhhdCBkb20wIHdhcyBhbGl2ZSBhbiB1c2FibGUsIGFsYmVp
dCBpdCBzaGFyaW5nIGFsbCB2Q1BVcyBvbiBhDQo+PiBzaW5nbGUgQ1BVLg0KPj4NCj4+DQo+PiBU
aGUgY2hhbmdlIGluIElOSVQgYmVoYXZpb3VyIGV4aXN0cyBmb3IgVFhULCB3aGVyZSBpcyBpdCBj
cml0aWNhbCB0aGF0DQo+PiBzb2Z0d2FyZSBjYW4gY2xlYXIgc2VjcmV0cyBmcm9tIFJBTSBiZWZv
cmUgcmVzZXR0aW5nLsKgIEknbSBub3Qgd2FudGluZw0KPj4gdG8gZ2V0IGludG8gYW55IG9mIHRo
YXQgYmVjYXVzZSBpdCdzIGZhciBtb3JlIGNvbXBsaWNhdGVkIHRoYW4gSSBoYXZlDQo+PiB0aW1l
IHRvIGZpeC4NCj4gSSBndWVzcyB0aGVyZSdzIHNvbWV0aGluZyBoaWRkZW4gYmVoaW5kIHdoYXQg
eW91IHNheSBoZXJlLCBsaWtlIElOSVQNCj4gb25seSBiZWluZyBsYXRjaGVkLCBidXQgdGhpcyBs
YXRjaGVkIHN0YXRlIHRoZW4gY2F1c2luZyB0aGUgVk0gZW50cnkNCj4gZmFpbHVyZS4gV2hpY2gg
d291bGQgbWVhbiB0aGF0IHJlYWxseSB0aGUgSU5JVCB3YXMgYSBzaWduYWwgZm9yIHRoZQ0KPiBz
eXN0ZW0gdG8gc2h1dCBkb3duIC8gc2h1dHRpbmcgZG93bi4NCg0KWWVzLg0KDQo+IEluIHdoaWNo
IGNhc2UgYXJyYW5naW5nIHRvDQo+IGNvbnRpbnVlIGJ5IGlnbm9yaW5nIHRoZSBldmVudCBpbiBW
TVggbG9va3Mgd3JvbmcuIFNpbXBseSBjcmFzaGluZw0KPiB0aGUgZ3Vlc3Qgd291bGQgdGhlbiBi
ZSB3cm9uZyBhcyB3ZWxsLCBvZiBjb3Vyc2UuIFdlIHNob3VsZCBzaHV0DQo+IGRvd24gaW5zdGVh
ZC4NCg0KSXQgaXMgc29mdHdhcmUncyBkaXNjcmV0aW9uIHdoYXQgdG8gZG8gd2hlbiBhbiBJTklU
IGlzIGNhdWdodCwgZXZlbiBpZg0KdGhlIGV4cGVjdGF0aW9uIGlzIHRvIGhvbm91ciBpdCBmYWly
bHkgcHJvbXB0bHkuDQoNCj4gQnV0IEkgZG9uJ3QgdGhpbmsgSSBzZWUgdGhlIGZ1bGwgcGljdHVy
ZSBoZXJlIHlldCwgdW5sZXNzIHlvdXINCj4gbWVudGlvbmluZyBvZiBUWFQgd2FzIGFjdHVhbGx5
IGltcGx5aW5nIHRoYXQgVFhUIHdhcyBhY3RpdmUgYXQgdGhlDQo+IHBvaW50IG9mIHRoZSBjcmFz
aCAod2hpY2ggSSBkb24ndCB0aGluayB3YXMgc2FpZCBhbnl3aGVyZSkuDQoNClRoaXMgZGlkIGNh
dXNlIGNvbmZ1c2lvbiBkdXJpbmcgZGVidWdnaW5nLsKgIEFzIGZhciBhcyB3ZSBjYW4gdGVsbCwg
VFhUDQppcyBub3QgYWN0aXZlLCBidXQgdGhlIG9ic2VydmVkIGJlaGF2aW91ciBjZXJ0YWlubHkg
bG9va3MgbGlrZSBUWFQgaXMNCmFjdGl2ZS4NCg0KVGhlbiBhZ2FpbiwgcmVzZXQgaXMgYSBwbGF0
Zm9ybSBiZWhhdmlvdXIsIG5vdCBhcmNoaXRlY3R1cmFsLsKgIEFsc28sDQppdCdzIG15IHVuZGVy
c3RhbmRpbmcgdGhhdCBJbnRlbCBkb2VzIG5vdCBzdXBwb3J0IFMzIG9uIFRpZ2VyTGFrZQ0KKG9w
dGluZyB0byBvbmx5IHN1cHBvcnQgUzBpeCBpbnN0ZWFkKSwgc28gSSdtIGd1ZXNzaW5nIHRoYXQg
IkxpbnV4IFMzIg0KYXMgaXQncyBjYWxsZWQgaW4gdGhlIG1lbnUgaXMgc29tZXRoaW5nIHJldHJv
Zml0dGVkIGJ5IHRoZSBPRU0uDQoNCkJ1dCBvdmVyYWxsLCB0aGUgcG9pbnQgaXNuJ3QgcmVhbGx5
IGFib3V0IHdoYXQgdHJpZ2dlcmVkIHRoZSBJTklULsKgIFdlDQphbHNvIHNob3VsZG4ndCBudWtl
IGFuIGlubm9jZW50IFZNIGlmIGFuIElOSVQgSVBJIHNsaXBzIHRocm91Z2gNCmludGVycnVwdCBy
ZW1hcHBpbmcuDQoNCn5BbmRyZXcNCg==


From xen-devel-bounces@lists.xenproject.org Fri Feb 25 17:57:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 17:57:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279556.477292 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNeq8-0000q5-Sp; Fri, 25 Feb 2022 17:57:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279556.477292; Fri, 25 Feb 2022 17:57:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNeq8-0000py-PY; Fri, 25 Feb 2022 17:57:12 +0000
Received: by outflank-mailman (input) for mailman id 279556;
 Fri, 25 Feb 2022 17:57:11 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HXke=TI=gmail.com=this.is.a0lson@srs-se1.protection.inumbo.net>)
 id 1nNeq6-0000ps-LH
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 17:57:11 +0000
Received: from mail-qt1-x82c.google.com (mail-qt1-x82c.google.com
 [2607:f8b0:4864:20::82c])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 595b51d5-9664-11ec-8eb9-a37418f5ba1a;
 Fri, 25 Feb 2022 18:57:08 +0100 (CET)
Received: by mail-qt1-x82c.google.com with SMTP id e2so3140832qte.12
 for <xen-devel@lists.xenproject.org>; Fri, 25 Feb 2022 09:57:08 -0800 (PST)
Received: from development (c-73-166-253-254.hsd1.tx.comcast.net.
 [73.166.253.254]) by smtp.gmail.com with ESMTPSA id
 s18-20020a05622a179200b002de9529450csm1864947qtk.85.2022.02.25.09.57.06
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 25 Feb 2022 09:57:07 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 595b51d5-9664-11ec-8eb9-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=message-id:subject:from:to:cc:date:in-reply-to:references
         :user-agent:mime-version:content-transfer-encoding;
        bh=aye+ci87ryBSKRStBASOk0eHohf3P3XgeSTb7JDgzyo=;
        b=bdSH/6ThxZbAO/X+OeR0LhEqy8vdmkCDpUPnjo4syIqL05UZBBG8ygUXIWAIwwo57U
         ReFMbH/Eb2AyNBzofml8Mj2vt7owXZywFBSdLr+jpwk4swajpzWeOyHSJIArwYly1eEZ
         2wyF8ZSFiH2kpcsk2eHaC3e/pyOirtNas+G4bACRrzlkcuAkKXRuIuPANlfXhclSZUH8
         +qc9x5MTXrGIWCtlzvMfD1c9p75bnSJzNverdrxomS8sv9zJjlvPXeSWSoxzVn/xkCsx
         r0Eo3uZ4ZNor9LzqNtLaaQqbZY7AndqJTzoWnSw6vzTl9odER9cThSx8HQL6bpfl+iGN
         FyQA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to
         :references:user-agent:mime-version:content-transfer-encoding;
        bh=aye+ci87ryBSKRStBASOk0eHohf3P3XgeSTb7JDgzyo=;
        b=HT98R34jCBmMNAoVCSGlhnsiRw4HbHTU0ef2q5FRiS06WJnw0irNecUFgjt1RMkvQt
         TP3xG9cKIGM3yt7WmfOaY1Nxn/ioUDJHZvMY84K70mltka7s40336SmwJJrX6iAcoZRt
         +LuETm1NAb+yDLxt8Oy29LvxKC/S3OTxbvgqxxtaA5oX+1ETnuzfdLb6SenKeTgopLpK
         VlUfi5loJ57qUf8+l5+12ndV+7ZyvI6eWJGaIFhPT+HvTaHYzoVltB2RnlKtYpgGRRlc
         XocBM9wAsbnvA+9+o07LHjInNda4iCMwqgFIeoWzz/B+WclY5H5dQqLPVkWVkIdYud6P
         m15Q==
X-Gm-Message-State: AOAM532RiUcYLxQmSXldg0KULgPns3t36+UhDFK0Ed2v3mjan4Nz/nSR
	HOmEk91xVACm4LdcUVWyJSpUpt1iBlbgow==
X-Google-Smtp-Source: ABdhPJzKxuBSHfok7FLyjGUo2vbV5ivLu+N/HZsWCH6HdlP8u1fIKkHcNdrO6xLtHV4YsIYkF7JNkQ==
X-Received: by 2002:a05:622a:90:b0:2de:57e3:c77a with SMTP id o16-20020a05622a009000b002de57e3c77amr7961741qtw.488.1645811827689;
        Fri, 25 Feb 2022 09:57:07 -0800 (PST)
Message-ID: <d8da3251985684ab9099ce95a8329a7e35535a7b.camel@gmail.com>
Subject: Re: [PATCH v2 2/2] vpci/msix: fix PBA accesses
From: Alex Olson <this.is.a0lson@gmail.com>
To: Roger Pau Monne <roger.pau@citrix.com>, xen-devel@lists.xenproject.org
Cc: Jan Beulich <jbeulich@suse.com>
Date: Fri, 25 Feb 2022 11:57:05 -0600
In-Reply-To: <20220225153956.1078-3-roger.pau@citrix.com>
References: <20220225153956.1078-1-roger.pau@citrix.com>
	 <20220225153956.1078-3-roger.pau@citrix.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.36.5-0ubuntu1 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

I think there is an issue in the spin_lock handling of patch 2 for the
"msix_write" function as it results in the lock being taken a second time while
held (hangs). 

The lock taken before checking "VMSIX_ADDR_IN_RANGE" isn't unlocked for the non-
PBA case and a second lock is attempted just before the call to get_entry()
later in the same function.  It looks like either the added lock should either
be moved inside the PBA case or the lock before get_entry() should be removed.


On my server, upon loading the ioatdma driver, it now successfully attempts an
PBA write (which now doesn't crash the system), but I'm not sure I have a way to
fully exercise it...

I also see a different (related) issue in which modify_bars is called on a
virtual function seemingly before the BAR addresses are initialized/known and
will start a different thread for that topic.

Regards,

-Alex


On Fri, 2022-02-25 at 16:39 +0100, Roger Pau Monne wrote:
> Map the PBA in order to access it from the MSI-X read and write
> handlers. Note that previously the handlers would pass the physical
> host address into the {read,write}{l,q} handlers, which is wrong as
> those expect a linear address.
> 
> Map the PBA using ioremap when the first access is performed. Note
> that 32bit arches might want to abstract the call to ioremap into a
> vPCI arch handler, so they can use a fixmap range to map the PBA.
> 
> Reported-by: Jan Beulich <jbeulich@suse.com>
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> ---
> Cc: Alex Olson <this.is.a0lson@gmail.com>
> ---
> Changes since v1:
>  - Also handle writes.
> 
> I don't seem to have a box with a driver that will try to access the
> PBA, so I would consider this specific code path only build tested. At
> least it doesn't seem to regress the current state of vPCI.
> ---
>  xen/drivers/vpci/msix.c | 55 +++++++++++++++++++++++++++++++++++++----
>  xen/drivers/vpci/vpci.c |  2 ++
>  xen/include/xen/vpci.h  |  2 ++
>  3 files changed, 54 insertions(+), 5 deletions(-)
> 
> diff --git a/xen/drivers/vpci/msix.c b/xen/drivers/vpci/msix.c
> index a1fa7a5f13..9fbc111ecc 100644
> --- a/xen/drivers/vpci/msix.c
> +++ b/xen/drivers/vpci/msix.c
> @@ -198,8 +198,13 @@ static int cf_check msix_read(
>      if ( !access_allowed(msix->pdev, addr, len) )
>          return X86EMUL_OKAY;
>  
> +    spin_lock(&msix->pdev->vpci->lock);
>      if ( VMSIX_ADDR_IN_RANGE(addr, msix->pdev->vpci, VPCI_MSIX_PBA) )
>      {
> +        struct vpci *vpci = msix->pdev->vpci;
> +        paddr_t base = vmsix_table_addr(vpci, VPCI_MSIX_PBA);
> +        unsigned int idx = addr - base;
> +
>          /*
>           * Access to PBA.
>           *
> @@ -207,25 +212,43 @@ static int cf_check msix_read(
>           * guest address space. If this changes the address will need to be
>           * translated.
>           */
> +
> +        if ( !msix->pba )
> +        {
> +            msix->pba = ioremap(base, vmsix_table_size(vpci, VPCI_MSIX_PBA));
> +            if ( !msix->pba )
> +            {
> +                /*
> +                 * If unable to map the PBA return all 1s (all pending): it's
> +                 * likely better to trigger spurious events than drop them.
> +                 */
> +                spin_unlock(&vpci->lock);
> +                gprintk(XENLOG_WARNING,
> +                        "%pp: unable to map MSI-X PBA, report all pending\n",
> +                        msix->pdev);
> +                return X86EMUL_OKAY;
> +           }
> +        }
> +
>          switch ( len )
>          {
>          case 4:
> -            *data = readl(addr);
> +            *data = readl(msix->pba + idx);
>              break;
>  
>          case 8:
> -            *data = readq(addr);
> +            *data = readq(msix->pba + idx);
>              break;
>  
>          default:
>              ASSERT_UNREACHABLE();
>              break;
>          }
> +        spin_unlock(&vpci->lock);
>  
>          return X86EMUL_OKAY;
>      }
>  
> -    spin_lock(&msix->pdev->vpci->lock);
>      entry = get_entry(msix, addr);
>      offset = addr & (PCI_MSIX_ENTRY_SIZE - 1);
>  
> @@ -273,27 +296,49 @@ static int cf_check msix_write(
>      if ( !access_allowed(msix->pdev, addr, len) )
>          return X86EMUL_OKAY;
>  
> +    spin_lock(&msix->pdev->vpci->lock);
>      if ( VMSIX_ADDR_IN_RANGE(addr, msix->pdev->vpci, VPCI_MSIX_PBA) )
>      {
> +        struct vpci *vpci = msix->pdev->vpci;
> +        paddr_t base = vmsix_table_addr(vpci, VPCI_MSIX_PBA);
> +        unsigned int idx = addr - base;
>  
>          if ( !is_hardware_domain(d) )
> +        {
>              /* Ignore writes to PBA for DomUs, it's behavior is undefined. */
> +            spin_unlock(&vpci->lock);
>              return X86EMUL_OKAY;
> +        }
> +
> +        if ( !msix->pba )
> +        {
> +            msix->pba = ioremap(base, vmsix_table_size(vpci, VPCI_MSIX_PBA));
> +            if ( !msix->pba )
> +            {
> +                /* Unable to map the PBA, ignore write. */
> +                spin_unlock(&vpci->lock);
> +                gprintk(XENLOG_WARNING,
> +                        "%pp: unable to map MSI-X PBA, write ignored\n",
> +                        msix->pdev);
> +                return X86EMUL_OKAY;
> +           }
> +        }
>  
>          switch ( len )
>          {
>          case 4:
> -            writel(data, addr);
> +            writel(data, msix->pba + idx);
>              break;
>  
>          case 8:
> -            writeq(data, addr);
> +            writeq(data, msix->pba + idx);
>              break;
>  
>          default:
>              ASSERT_UNREACHABLE();
>              break;
>          }
> +        spin_unlock(&vpci->lock);
>  
>          return X86EMUL_OKAY;
>      }
> diff --git a/xen/drivers/vpci/vpci.c b/xen/drivers/vpci/vpci.c
> index f3b32d66cb..9fb3c05b2b 100644
> --- a/xen/drivers/vpci/vpci.c
> +++ b/xen/drivers/vpci/vpci.c
> @@ -51,6 +51,8 @@ void vpci_remove_device(struct pci_dev *pdev)
>          xfree(r);
>      }
>      spin_unlock(&pdev->vpci->lock);
> +    if ( pdev->vpci->msix && pdev->vpci->msix->pba )
> +        iounmap(pdev->vpci->msix->pba);
>      xfree(pdev->vpci->msix);
>      xfree(pdev->vpci->msi);
>      xfree(pdev->vpci);
> diff --git a/xen/include/xen/vpci.h b/xen/include/xen/vpci.h
> index bcad1516ae..c399b101ee 100644
> --- a/xen/include/xen/vpci.h
> +++ b/xen/include/xen/vpci.h
> @@ -127,6 +127,8 @@ struct vpci {
>          bool enabled         : 1;
>          /* Masked? */
>          bool masked          : 1;
> +        /* PBA map */
> +        void *pba;
>          /* Entries. */
>          struct vpci_msix_entry {
>              uint64_t addr;



From xen-devel-bounces@lists.xenproject.org Fri Feb 25 18:46:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 18:46:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279564.477303 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNfbb-00069W-KY; Fri, 25 Feb 2022 18:46:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279564.477303; Fri, 25 Feb 2022 18:46:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNfbb-00069P-HK; Fri, 25 Feb 2022 18:46:15 +0000
Received: by outflank-mailman (input) for mailman id 279564;
 Fri, 25 Feb 2022 18:46:13 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=nFiF=TI=oracle.com=dongli.zhang@srs-se1.protection.inumbo.net>)
 id 1nNfbZ-00069J-5u
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 18:46:13 +0000
Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com
 [205.220.177.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 30eceaf4-966b-11ec-8eb9-a37418f5ba1a;
 Fri, 25 Feb 2022 19:46:08 +0100 (CET)
Received: from pps.filterd (m0246632.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 21PIihhK027454; 
 Fri, 25 Feb 2022 18:46:03 GMT
Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80])
 by mx0b-00069f02.pphosted.com with ESMTP id 3eexj89tky-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Fri, 25 Feb 2022 18:46:02 +0000
Received: from pps.filterd (userp3030.oracle.com [127.0.0.1])
 by userp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 21PIjx2X096196;
 Fri, 25 Feb 2022 18:46:01 GMT
Received: from nam12-bn8-obe.outbound.protection.outlook.com
 (mail-bn8nam12lp2173.outbound.protection.outlook.com [104.47.55.173])
 by userp3030.oracle.com with ESMTP id 3eanp0jud2-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Fri, 25 Feb 2022 18:46:01 +0000
Received: from BYAPR10MB2663.namprd10.prod.outlook.com (2603:10b6:a02:a9::20)
 by MN2PR10MB3408.namprd10.prod.outlook.com (2603:10b6:208:127::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Fri, 25 Feb
 2022 18:45:52 +0000
Received: from BYAPR10MB2663.namprd10.prod.outlook.com
 ([fe80::a0d5:610d:bcf:9b47]) by BYAPR10MB2663.namprd10.prod.outlook.com
 ([fe80::a0d5:610d:bcf:9b47%4]) with mapi id 15.20.5017.025; Fri, 25 Feb 2022
 18:45:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 30eceaf4-966b-11ec-8eb9-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc :
 references : from : message-id : date : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2021-07-09;
 bh=8BYp7TpMiW9tihYA5bt5W0jmwZZ4fgvseB/F7Eosde4=;
 b=cuKu8XT6hoS0eZbVteECJm0ViF4DrpCnHpkyGa/UVF4AtTA4DLw96LoT0rlQDmQOFnFs
 MMFKjfToFsXpRSYJxwaET1i2q1r7EOJS3gOcOzmGAX6H1b1Wn9OK8wyqNRh+fY0tdhNq
 iwYjY0HbezZEz3hx7EDTq8R/DfWhw1ifujEkeFs0KedK3s64pQTfQn/fCz+5QGcU0Nfk
 9rB5q8SG/l99vKDK5uNhxs24HTcYfi8W2DDZcnQc5zUoztwt5Td08kJ+c7OmK7DvtcHe
 LPWdXUchiT/9Vy3gA6SS6uKDS0fzEsYMIqmq3nW1sWTR0NoMBur2AZOrgwLlD1nyZU8m fQ== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=CNdG51b2tVLtNJiE1RXPJEc0lsXhJ5SausI9ttisMPoWN7hVQXTzSL4Keq3Q78lCheESaFs+6fioWll9Eewct2EhZw5JgX68IxGjIpM1k/+qXSjs7hn2l7K/5fZJCd+lncy1K4IrarAHHEesA1cv7cbQo4Z2nlAel+i8dp4u1/s9NDB4EYLH4UofmlaHpWDsixywuuBHiOVasXxzKXQI2RnZ6eGlt4baSXbBTonXWVNSMtPme4UqbenH32bgV1i5tazcxaah9C7JT48MLkbtQzLHiJDdV6rMn3PRGzX+9cIlYcgGYIuo0UGG04nDvh/IRExgO5jJU8Bd3MWFWkpAOQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=8BYp7TpMiW9tihYA5bt5W0jmwZZ4fgvseB/F7Eosde4=;
 b=VwW6NxUtkSw82vtn5qFkNc1WwT4Kqh1O7ih+jSHBYP9Lq9GbsrGMl55E3m5b7NBzWmRj0sAZv5CkKYG7Pkk1nUkA3wLX87LVCN4+7DvIMOGx7SkoDIfJyLNI/bVMotUFROKp11ar2kqP3NShM85xCBX6jA+yqZ05P0q62MqERGSKPj/pZVaMsfkPhbFYQeMQZ6wXjIuu/Cb3C594TuXe07LRqd4PT2fKtMV/YSw0A3Rk2aSUAumn42EFXd26+X19zcNI5JnwdDAE8JH3VK7KFqoB6NVcwp0wvK6Y2mYypEqINdZ4vXpMM+Ddg9o0jKV9POxSyPzWKeBpPt3dP3shvg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=8BYp7TpMiW9tihYA5bt5W0jmwZZ4fgvseB/F7Eosde4=;
 b=tzWxefiCN0qChMcoFuhzqETjP/jGYlRqzpbi9Vpas0DfMMw2Y8ZaYr8TK7thH/FO7otAcCzEQnnuzmh5RiPiYhcOpoQG5V3bGIxEhxWoe93hF4Yvd6jukPfWYvlTMuNq8xgHKFE6P9i1vmUxC5fYcl8uroO8RNpFWBlCS6NDTns=
Subject: Re: [BUG REPORT] soft_reset (kexec/kdump) does not work with mainline
 xen
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        Anthony Perard <anthony.perard@citrix.com>,
        Andrew Cooper <andrew.cooper3@citrix.com>
References: <BYAPR10MB2663BBE2CEECCC4C6504B190F03D9@BYAPR10MB2663.namprd10.prod.outlook.com>
 <d3814109-f4ba-9edb-1575-ab94faaeba08@suse.com>
From: Dongli Zhang <dongli.zhang@oracle.com>
Message-ID: <7ccbf308-2a30-e6ca-ea7f-4c2ad2c85c8d@oracle.com>
Date: Fri, 25 Feb 2022 10:45:50 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.1
In-Reply-To: <d3814109-f4ba-9edb-1575-ab94faaeba08@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: SA0PR11CA0181.namprd11.prod.outlook.com
 (2603:10b6:806:1bc::6) To BYAPR10MB2663.namprd10.prod.outlook.com
 (2603:10b6:a02:a9::20)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: febaa07f-2ca0-4ea0-e3ae-08d9f88f0c3a
X-MS-TrafficTypeDiagnostic: MN2PR10MB3408:EE_
X-Microsoft-Antispam-PRVS: 
	<MN2PR10MB34087DD27DD13269414AB02FF03E9@MN2PR10MB3408.namprd10.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	JWyRYHb3+P2BJIhJSm31npPH4yY0jOpHv7I1MEDg+bxw4fe7BjXULrvYi8/jUiqvZSofzE01Sw5lT3Z34hjmcxXgRuPQy28vS8L4jY2+zCb18To2oId+bfhd7uaOyaj5G0FcoL9FWr1/pAUaqTf4q43R7Ua7je9Djbg8kxIMK/6mQn3L+98P7+Ij0Du0md5jpOe2PJvN5iWGun7k8jhB7zzMwXrQArHPcl+5XKRXQb6KHrgNkDvS73Ydso5GgHS1T/0ETqRzCXpggYOtfIJ5tVptkBv94qh/umWMRj/qO0BMkwbhYkEszLhgTkiyrE/FKJEAKGGNpBOEEC9nYzWqSm27obwArGLpPIksXWQEH21vBxzOviLSYG5s00kqM/XF27uJaysFEVcn7Ps+RDPYjd5rCy26a7iedQ5jvD3Fxdh1eDyJIMxmi4t/CE9jCgEQP4Ei3TSDf0FafxjxkafUu8GSHquYKRvrowsZlbZVB0BWoEERPDLnxfUy7/D0xVISMu24Os+rvNpvg8xxJ+Y1V9qlVeZjnCAnWLiMExd/XQhegAM7TCMTIqSSfMDaOBsUommjdYP2o/O39B6PAggdCCZOFPhMqVXcqqftVXBiSMKMkXgpkqYuZ+v17XVfEuTX85Za6Y7osZJDgsv6mLw1OVD5O/Q7Dy0Mpzu6w3qn9cLSEt3QyEAP2zirzSEN6uGgip7w5+Wjalr7d1yDy8RLvxAQGHQO8Tv65+FMYGUEapc=
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB2663.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(54906003)(8936002)(44832011)(86362001)(38100700002)(31696002)(6486002)(83380400001)(66556008)(66476007)(6916009)(2906002)(316002)(4326008)(66946007)(8676002)(186003)(36756003)(53546011)(2616005)(6512007)(5660300002)(31686004)(508600001)(6506007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?VWxqSnl2NG5lNVpoUUtGckg4bDlrNWJCenAwS1V6Vy9aQ2JyZzdiS1Jxd3Jl?=
 =?utf-8?B?NjY1OWN6M25MUEhEQmxBdVhYZWZDbFFrbTl6UmowZm1sUmRGZFF0ZUhIdEU5?=
 =?utf-8?B?OGNaOW5FYnlBbGJSank0OWJtUnZXTElvd2hYbFJ4bHBxWWd3NHhza1BPWEth?=
 =?utf-8?B?Z01hazFQUm9SVTZRRVdtUlNTQWI5ZGtSNEdoa3lYNjBBaWNrWk1iY0pDUnJt?=
 =?utf-8?B?TnJicThjazlEMmlaVFZ5Y0JNTmRDOVcrSFdGZnREcVRxUW9idFlyYjBVd2Fk?=
 =?utf-8?B?UzQ0WmlHMUVzMjdPb0xpWm1mZFRqVkpCejBIS0tWSEh2VjVLL0puZlZVcEJx?=
 =?utf-8?B?OGp6dmxGYjlDaXdBbWc4S3FnTjFjK1NaejBmcDIvQW9hbTBnTlUxSnBUSGF3?=
 =?utf-8?B?eDd5YUZxMTNqY3NtNEp3RTExZ1lhSzV3ekIwbDV6OWVzVUdxWjNYQ2UxY1NV?=
 =?utf-8?B?RW1YQWdNb3o5Zi9kU2JoRFI3aXRDUTRad3RRVVJVOTUrajFBR0drSXdwcE5O?=
 =?utf-8?B?THVVTERCSzVwU2ViNnZIbFJnemhIWWJqYXpKQ3hHbHNoNkdMWHN6Ni9peWlr?=
 =?utf-8?B?ZDRHUTQ3UE16cFVwMzVQUzlTMEFpU3J2MGJaUWd1aURFTGV4L0NhQnkzNlBH?=
 =?utf-8?B?N1YwODVoaVQ0eUQrUjljYng5L2pJTVlCbnRJYTA3dEtrWllwUFVWV2xPY2hE?=
 =?utf-8?B?VmcrU3lmdkh5S2FkeHFQRTdPd3NQcVRzaUNzY2d6Y1lIQVNGV0ZQVnRqR0FM?=
 =?utf-8?B?Nm9pTWRJZHRjV2tZNFdua2JNUmtEbmpBKzl4RG95cFc0d0loOTE5VFVxSFpu?=
 =?utf-8?B?THYzTnNKV0dJeGtBck9RV0QySTNGcEdSZUx0SkNzeW45TmUyYXR3WTRYc003?=
 =?utf-8?B?V21mcnZvNW03K3lLWVpSaVc0TDd0b2RudTZkcnJBWmE4VHBqUUNCR2ZnbmRG?=
 =?utf-8?B?S2gyb25pMzkzMjRlc3I2ODVzYWpxME1YQlhtU01YejVuK2J1RHpTWFBLTE50?=
 =?utf-8?B?SlJyZFdYVzZsaUdsWmEwSXFSY3p4by91N0hHRDNUZ3l1ellVYkMvZnhxSUM2?=
 =?utf-8?B?ZVZBNUVkYmY2bkg5SUNIN0o0T3cvaXRSbEhxNWlwb044a3I2SUh1a1VTN3lW?=
 =?utf-8?B?QlVqK0VrR1pIaGY0SWhVT2hETkNCNGhJaFRKQXZPN3Ezdk11K0VINjhNMUcz?=
 =?utf-8?B?RndTbmMvNGJYdnBkajlsQysvbld6WUZqaTExVkJsd3F1cWNnZ0JCZUpUd3Yw?=
 =?utf-8?B?dFdMZkZ6QjRiUWlDYmo5L21LQnE4dHkrVUFZMVdEMW9jSFZaYVNtM0N1ODhS?=
 =?utf-8?B?eW9TYVhhRWw0NlAza29QU2x4L2JqZ0Jha0FnRnJ5Q2ZzSU1MNEJ0T2ZBNVB4?=
 =?utf-8?B?ZE9tV0poQVdWZDQ5TWJ2WXNZWDlCa2tUWFVrL3J0SkRQYXRWNXVYUkpTYlZH?=
 =?utf-8?B?SjhKY011QXpybnFRMkRVMlZFRmVmV0QxY2IzTGRQaE1kQ04ydmJoUWkvenlM?=
 =?utf-8?B?TjdQMFNpbFBFNnkzOWIrakJtbmNMU0dSTmNoZHBtWVNTQ0QrWHUrMW8wdWRo?=
 =?utf-8?B?anBycjUwV3hLTkZYM0hVMlNpbTk1Z1VmRWo3U051RHplY2pVcjJEUVRSTXU0?=
 =?utf-8?B?R29VS0lPN2RTZ3o5K3hpa0dBVXVuQS9wMWxqMW5NeFMzbnJiR0plMFUxWWJk?=
 =?utf-8?B?TG1WR1BzZmFHdFZYZ2dTS21idzByYU5ZY2F1cTJLckRDd1VvclExZUJwbklm?=
 =?utf-8?B?ZnRhYTZPZlJyUWFMOURVdDM2dWxkOGErNnZKMWFnajl0WG01dkdQNWQ1YWpj?=
 =?utf-8?B?NS9KTXpuZHBlU0twditubDJQOVlDM3o5QnhlV0p3L0w1aHVYRUtUeGdlZi94?=
 =?utf-8?B?MHFNVXdoMlJzVkFySnRGV1hUSUxIeSs4M0VSK1p1clJ1NGFrNmg3dEdnUWFS?=
 =?utf-8?B?S2dURFJ6OGlsell0d3kycklabEZtTXVjaFRGZ3dDWXlyTURzaTNnaXhaajRH?=
 =?utf-8?B?a3NpQkZmdHFRUjBaOFMrM042eUVwbXVuMytodzkzbTU5YkVOalV5VUduRGJk?=
 =?utf-8?B?VXc4WU5uU0RDSzdnbXZQK3lnNXZGaDRrRVkrL2tzNnNENlFlREExWjdEVkty?=
 =?utf-8?B?VkppUktKL2lTNUI4UTFSUVFYdzk5L2F0OVlwc1ZOR1pJaUNNandBeFowY1FT?=
 =?utf-8?Q?RqxBc/gmf3QHNOreXu8KY+w6K/T9MTPSNV+JXRj+OVh5?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: febaa07f-2ca0-4ea0-e3ae-08d9f88f0c3a
X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2663.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2022 18:45:52.1489
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GvevdDBvckd2wCPDaNHX+7XjA7VtFT7Ml9qrUZqSOuBokvBa5w913oiAkCpedkq70vlszXCiFylhmj+EjlBVzw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB3408
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10268 signatures=684655
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 adultscore=0
 malwarescore=0 phishscore=0 mlxlogscore=999 mlxscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2202250106
X-Proofpoint-GUID: AE2VKIPTP_2Z4er74D-sCD2Oq7BGhSl6
X-Proofpoint-ORIG-GUID: AE2VKIPTP_2Z4er74D-sCD2Oq7BGhSl6

Hi Jan,

On 2/24/22 11:15 PM, Jan Beulich wrote:
> On 24.02.2022 23:27, Dongli Zhang wrote:
>> Hello,
>>
>> This is to report that the soft_reset (kexec/kdump) has not been working for me
>> since long time ago.
>>
>> I have tested again with the most recent mainline xen and the most recent
>> mainline kernel.
>>
>> While it works with my old xen version, it does not work with mainline xen.
>>
>>
>> This is the log of my HVM guest.
>>
>> Waiting for domain test-vm (domid 1) to die [pid 1265]
>> Domain 1 has shut down, reason code 5 0x5
>> Action for shutdown reason code 5 is soft-reset
>> Done. Rebooting now
>> xc: error: Failed to set d1's policy (err leaf 0xffffffff, subleaf 0xffffffff, msr 0xffffffff) (17 = File exists): Internal error
> 
> I don't suppose you tried you track down the origin of this EEXIST? I think
> it's pretty obvious, as in the handling of XEN_DOMCTL_set_cpu_policy we have
> 
>         if ( d->creation_finished )
>             ret = -EEXIST; /* No changing once the domain is running. */
> 
> Question is how to address it: One approach could be to clear
> d->creation_finished in domain_soft_reset(). But I think it would be more
> clean if the tool stack avoided trying to set the CPUID policy (again) on
> the guest when it soft-resets, as it's still the same guest after all.
> Cc-ing Andrew and Anthony for possible thoughts.
> 

The soft_reset on HVM is successful after I reset d->creation_finished at the
beginning of domain_soft_reset(). So far I am able to use this as workaround to
test kexec/kdump.

However, while my image's console works well on old xen versions, the console on
mainline xen version does not work well.

I connect to the console with "xl console <domid>" immediately after the domU is
panic (and kdump is triggered). I am not able to have the syslogs of kdump
kernel on mainline xen. The same image works on old xen version.

Thank you very much!

Dongli Zhang


From xen-devel-bounces@lists.xenproject.org Fri Feb 25 19:46:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 19:46:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279573.477314 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNgXY-0003qz-3h; Fri, 25 Feb 2022 19:46:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279573.477314; Fri, 25 Feb 2022 19:46:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNgXX-0003qs-VS; Fri, 25 Feb 2022 19:46:07 +0000
Received: by outflank-mailman (input) for mailman id 279573;
 Fri, 25 Feb 2022 19:46:06 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nNgXW-0003qm-Nb
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 19:46:06 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nNgXW-0000yZ-DD; Fri, 25 Feb 2022 19:46:06 +0000
Received: from 54-240-197-226.amazon.com ([54.240.197.226]
 helo=[192.168.31.13]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nNgXW-0005BY-71; Fri, 25 Feb 2022 19:46:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=0rbHA/d4QWgKXz6b7JpM1lpw/W7gSC4xYbg31Hk0nSY=; b=zIVjR8tA6OA6SGm3MzNgqLpCJ0
	6JK0V48siXgTMNLAORr8kh17mzpZQ7okl8iLhVt8xglt0KPkQQfWfbambczbw5Dfj0nQXmOjs9yxM
	2HOb9yDnddTo+tz8bLfFOQuP+bAFe4ucDQ+Or0aSUZ1fUpzdyiSVG0ShDEDczzI5o5o4=;
Message-ID: <dbe2395b-c533-c7f1-bec1-70f4399b430a@xen.org>
Date: Fri, 25 Feb 2022 19:46:04 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.1
Subject: Re: [PATCH v2] xen/arm: vpci: remove PCI I/O ranges property value
To: Rahul Singh <rahul.singh@arm.com>, xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com, Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <8ea25f00c8641bfd95a4d8444b82ca2ac3ee5ce0.1644939115.git.rahul.singh@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <8ea25f00c8641bfd95a4d8444b82ca2ac3ee5ce0.1644939115.git.rahul.singh@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Rahul,

On 15/02/2022 15:36, Rahul Singh wrote:
> PCI I/O space are not mapped to dom0 when PCI passthrough is enabled,
> also there is no vpci trap handler register for IO bar.
> 
> Remove PCI I/O ranges property value from dom0 device tree node so that
> dom0 linux will not allocate I/O space for PCI devices if
> pci-passthrough is enabled.
> 
> Signed-off-by: Rahul Singh <rahul.singh@arm.com>
> ---
>   xen/arch/arm/domain_build.c   | 29 +++++++++++++++
>   xen/common/device_tree.c      | 69 +++++++++++++++++++++++++++++++++++
>   xen/include/xen/device_tree.h | 10 +++++
>   3 files changed, 108 insertions(+)

For future version, please add a changelog. This helps to figure out 
what changed more easily.

> 
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index 6931c022a2..7cfe64fe97 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -648,6 +648,31 @@ static void __init allocate_static_memory(struct domain *d,
>   }
>   #endif
>   
> +/*
> + * PCI IO bar are not mapped to dom0 when PCI passthrough is enabled, also
> + * there is no trap handler registered for IO bar, therefore remove the IO
> + * range property from the device tree node for dom0.
> + */
> +static int handle_linux_pci_io_ranges(struct kernel_info *kinfo,
> +                                      const struct dt_device_node *node)
> +{
> +    if ( !is_pci_passthrough_enabled() )
> +        return 0;
> +
> +    if ( !dt_device_type_is_equal(node, "pci") )
> +        return 0;
> +
> +    /*
> +     * The current heuristic assumes that a device is a host bridge
> +     * if the type is "pci" and then parent type is not "pci".
> +     */
> +    if ( node->parent && dt_device_type_is_equal(node->parent, "pci") )
> +        return 0;


The logic above is exactly the same as in handle_linux_pci_domain(). Can 
we create an helper that could be used by both functions? This would 
help to keep the logic synchronized.

> +
> +    return dt_pci_remove_io_ranges(kinfo->fdt, node);
> +}
> +
> +
>   /*
>    * When PCI passthrough is available we want to keep the
>    * "linux,pci-domain" in sync for every host bridge.
> @@ -723,6 +748,10 @@ static int __init write_properties(struct domain *d, struct kernel_info *kinfo,
>       if ( iommu_node && device_get_class(iommu_node) != DEVICE_IOMMU )
>           iommu_node = NULL;
>   
> +    res = handle_linux_pci_io_ranges(kinfo, node);
> +    if ( res )
> +        return res;
> +
>       dt_for_each_property_node (node, prop)
>       {
>           const void *prop_data = prop->value;
> diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c
> index 4aae281e89..55a883e0f6 100644
> --- a/xen/common/device_tree.c
> +++ b/xen/common/device_tree.c

If I am not mistaken, the file common/device_tree.c is so far only 
containing code to parse the host device-tree. But now...

> @@ -2195,6 +2195,75 @@ int dt_get_pci_domain_nr(struct dt_device_node *node)
>       return (u16)domain;
>   }
>   
> +int dt_pci_remove_io_ranges(void *fdt, const struct dt_device_node *dev)

you are introducing code to write the domain device-tree. I understand 
this is because dt_match_bus() is internal. However, I would rather 
prefer if we export dt_match_bus() & co and move this code to under 
arch/arm/pci/. Maybe we should introduce a file domain_build.c.

Furthermore, the name of the function doesn't really match what the 
function does. It will generate "ranges" for the hostbridge and remove 
the I/O. We may want to perform other modifications on the range. So I 
would name the function something like:

domain_build_generate_hostbridge_range()

> +    const struct dt_device_node *parent = NULL;
> +    const struct dt_bus *bus, *pbus;
> +    unsigned int rlen;
> +    int na, ns, pna, pns, rone;
> +    const __be32 *ranges;
> +    __be32 regs[((GUEST_ROOT_ADDRESS_CELLS * 2) + GUEST_ROOT_SIZE_CELLS + 1)

GUEST_ROOT_*_CELLS are only valid for domU. In theory, there are no 
guarantee this will be bigger that what the host device-tree supports.

So you want to use DT_MAX_ADDR_CELLS here.

> +               * 2];
Looking at the code below. I couldn't find any check guaranteing the 
static array will be big enough to store the ranges provided by the host DT.

> +    __be32 *addr = &regs[0];
> +
> +    bus = dt_match_bus(dev);
> +    if ( !bus )
> +        return 0; /* device is not a bus */
> +
> +    parent = dt_get_parent(dev);
> +    if ( !parent )
> +        return -EINVAL;
> +
> +    ranges = dt_get_property(dev, "ranges", &rlen);
> +    if ( !ranges )
> +    {
> +        printk(XENLOG_ERR "DT: no ranges; cannot enumerate %s\n",
> +               dev->full_name);
> +        return -EINVAL;
> +    }
> +    if ( !rlen ) /* Nothing to do */
> +        return 0;
> +
> +    bus->count_cells(dev, &na, &ns);
> +    if ( !DT_CHECK_COUNTS(na, ns) )
> +    {
> +        printk(XENLOG_ERR "dt_parse: Bad cell count for device %s\n",
> +               dev->full_name);
> +        return -EINVAL;
> +    }
> +
> +    pbus = dt_match_bus(parent);
> +    if ( !pbus )
> +    {
> +        printk(XENLOG_ERR "DT: %s is not a valid bus\n", parent->full_name);
> +        return -EINVAL;
> +    }
> +
> +    pbus->count_cells(dev, &pna, &pns);
> +    if ( !DT_CHECK_COUNTS(pna, pns) )
> +    {
> +        printk(XENLOG_ERR "dt_parse: Bad cell count for parent %s\n",
> +               dev->full_name);
> +        return -EINVAL;
> +    }
> +
> +    /* Now walk through the ranges */
> +    rlen /= 4;
> +    rone = na + pna + ns;
> +    for ( ; rlen >= rone; rlen -= rone, ranges += rone )
> +    {

Most of the code in this function is the same as dt_for_each_range(). 
Can we refactor it to avoid code duplication?

> +        unsigned int flags = bus->get_flags(ranges);
> +        if ( flags & IORESOURCE_IO )
> +            continue;
> +
> +        memcpy(addr, ranges, 4 * rone);
> +
> +        addr += rone;
> +    }
> +
> +    return fdt_property(fdt, "ranges", regs, sizeof(regs));
> +}
> +
>   /*
>    * Local variables:
>    * mode: C
> diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h
> index fd6cd00b43..580231f872 100644
> --- a/xen/include/xen/device_tree.h
> +++ b/xen/include/xen/device_tree.h
> @@ -849,6 +849,16 @@ int dt_count_phandle_with_args(const struct dt_device_node *np,
>    */
>   int dt_get_pci_domain_nr(struct dt_device_node *node);
>   
> +/**
> + * dt_pci_remove_io_range - Remove the PCI I/O range property value.
> + * @fdt: Pointer to the file descriptor tree.
> + * @node: Device tree node.
> + *
> + * This function will remove the PCI IO range property from the PCI device tree
> + * node.
> + */
> +int dt_pci_remove_io_ranges(void *fdt, const struct dt_device_node *node);
> +
>   struct dt_device_node *dt_find_node_by_phandle(dt_phandle handle);
>   
>   #ifdef CONFIG_DEVICE_TREE_DEBUG

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Feb 25 20:08:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 20:08:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279580.477324 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNgtW-0006QE-V9; Fri, 25 Feb 2022 20:08:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279580.477324; Fri, 25 Feb 2022 20:08:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNgtW-0006Q7-SJ; Fri, 25 Feb 2022 20:08:50 +0000
Received: by outflank-mailman (input) for mailman id 279580;
 Fri, 25 Feb 2022 20:08:49 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nNgtV-0006Px-Kk
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 20:08:49 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nNgtV-0001Qx-DN; Fri, 25 Feb 2022 20:08:49 +0000
Received: from 54-240-197-226.amazon.com ([54.240.197.226]
 helo=[192.168.31.13]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nNgtV-0006sr-7X; Fri, 25 Feb 2022 20:08:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=E3sViSrhk7xmMdXNxQZ441RrrS2eQIzqyhxaILutyPA=; b=7NbXEdKVoeIA15oZznCQio9rOt
	V7uRLwSvL49PqbUJCO8NppjCq4e9A9YYVPqPwZp6zPdlmN9qRLOlV4qUtWtrkmJ7+PylIVDjw2qtr
	/MAxLDWUO/2P2xaQicqVObXRwimv/hp1to+Kg4j74AIErmosv6puuqmOLbVSad4ejTD4=;
Message-ID: <6269ec3d-039e-d68f-771d-c5e088631410@xen.org>
Date: Fri, 25 Feb 2022 20:08:47 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.1
Subject: Re: [RFC PATCH 0/2] Introduce reserved Xenheap
To: Henry Wang <Henry.Wang@arm.com>, xen-devel@lists.xenproject.org,
 sstabellini@kernel.org
Cc: Bertrand.Marquis@arm.com, wei.chen@arm.com, penny.zheng@arm.com
References: <20220224013023.50920-1-Henry.Wang@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220224013023.50920-1-Henry.Wang@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Henry,

On 24/02/2022 01:30, Henry Wang wrote:
> The reserved Xenheap, or statically configured Xenheap, refers to parts
> of RAM reserved in the beginning for Xenheap. Like the static memory
> allocation, such reserved Xenheap regions are reserved by configuration
> in the device tree using physical address ranges.

In Xen, we have the concept of domheap and xenheap. For Arm64 and x86 
they would be the same. But for Arm32, they would be different: xenheap 
is always mapped whereas domheap is separate.

Skimming through the series, I think you want to use the region for both 
domheap and xenheap. Is that correct?

Furthemore, now that we are introducing more static region, it will get 
easier to overlap the regions by mistakes. I think we want to have some 
logic in Xen (or outside) to ensure that none of them overlaps. Do you 
have any plan for that?

> 
> This feature is useful to run Xen on Arm MPU systems, where only a
> finite number of memory protection regions are available. The limited
> number of protection regions places requirement on planning the use of
> MPU protection regions and one or more MPU protection regions needs to
> be reserved only for Xenheap.
> 
> Therefore, this patch series is sent as RFC for comments from the
> community. The first patch introduces the reserved Xenheap and the
> device tree processing code. The second patch adds the implementation of
> the reserved Xenheap pages handling in boot and heap allocator on Arm64.
> 
> Henry Wang (2):
>    docs, xen/arm: Introduce reserved Xenheap memory
>    xen/arm: Handle reserved Xenheap pages in boot/heap allocator
> 
>   docs/misc/arm/device-tree/booting.txt | 43 ++++++++++++++++++++++
>   xen/arch/arm/bootfdt.c                | 52 +++++++++++++++++++++------
>   xen/arch/arm/include/asm/setup.h      |  3 ++
>   xen/arch/arm/setup.c                  | 52 +++++++++++++++++++--------
>   4 files changed, 125 insertions(+), 25 deletions(-)
> 

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Feb 25 20:12:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 20:12:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279587.477335 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNgx6-0007nZ-EQ; Fri, 25 Feb 2022 20:12:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279587.477335; Fri, 25 Feb 2022 20:12:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNgx6-0007nS-Bc; Fri, 25 Feb 2022 20:12:32 +0000
Received: by outflank-mailman (input) for mailman id 279587;
 Fri, 25 Feb 2022 20:12:31 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nNgx5-0007nM-1H
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 20:12:31 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nNgx4-0001X0-Ts; Fri, 25 Feb 2022 20:12:30 +0000
Received: from 54-240-197-226.amazon.com ([54.240.197.226]
 helo=[192.168.31.13]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nNgx4-0007F0-OI; Fri, 25 Feb 2022 20:12:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=Auvgj0/rbJfyJ5LgCODNKZpgZL4w/Q0O9qQG2SfrTQs=; b=FriGTSWkjjaMTD2iIfiddiNIFW
	gjT1DhKmKoPLpNXOO5qWqnN1L/Hshzq4kMIlOGOAVoeBriZQ2EKqR8Bu+uWCnoi5hFKrqS67rhZpK
	oEU0HtaAz7ZkZeTKvWPYG0GiKVisM5iW9Pbgo6+bRBsmDzFhNXfsdvQfsA9GdgNVl850=;
Message-ID: <4c558f8f-56d4-0445-32d4-169bc5d0a3bc@xen.org>
Date: Fri, 25 Feb 2022 20:12:28 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.1
Subject: Re: Proposal for Porting Xen to Armv8-R64 - DraftA
To: Wei Chen <Wei.Chen@arm.com>, Stefano Stabellini <sstabellini@kernel.org>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>,
 Penny Zheng <Penny.Zheng@arm.com>, Henry Wang <Henry.Wang@arm.com>,
 nd <nd@arm.com>
References: <PAXPR08MB7420A01809B84E04E196793F9E3D9@PAXPR08MB7420.eurprd08.prod.outlook.com>
 <alpine.DEB.2.22.394.2202241606450.239973@ubuntu-linux-20-04-desktop>
 <AS1PR08MB74269923288B75097392BDD99E3E9@AS1PR08MB7426.eurprd08.prod.outlook.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <AS1PR08MB74269923288B75097392BDD99E3E9@AS1PR08MB7426.eurprd08.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Wei,

On 25/02/2022 10:48, Wei Chen wrote:
>> >     Armv8-R64 can support max to 256 MPU regions. But that's just
>> theoretical.
>> >     So we don't want to define `pr_t mpu_regions[256]`, this is a memory
>> waste
>> >     in most of time. So we decided to let the user specify through a
>> Kconfig
>> >     option. `CONFIG_ARM_MPU_EL1_PROTECTION_REGIONS` default value can be
>> `32`,
>> >     it's a typical implementation on Armv8-R64. Users will recompile Xen
>> when
>> >     their platform changes. So when the MPU changes, respecifying the
>> MPU
>> >     protection regions number will not cause additional problems.
>> 
>> I wonder if we could probe the number of MPU regions at runtime and
>> dynamically allocate the memory needed to store them in arch_vcpu.
>> 
> 
> We have considered to used a pr_t mpu_regions[0] in arch_vcpu. But it seems
> we will encounter some static allocated arch_vcpu problems and sizeof issue.

Does it need to be embedded in arch_vcpu? If not, then we could allocate 
memory outside and add a pointer in arch_vcpu.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Feb 25 20:41:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 20:41:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279594.477346 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNhPE-0002m6-Nl; Fri, 25 Feb 2022 20:41:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279594.477346; Fri, 25 Feb 2022 20:41:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNhPE-0002lz-Kp; Fri, 25 Feb 2022 20:41:36 +0000
Received: by outflank-mailman (input) for mailman id 279594;
 Fri, 25 Feb 2022 20:41:35 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nNhPD-0002lp-6V; Fri, 25 Feb 2022 20:41:35 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nNhPD-00022I-4X; Fri, 25 Feb 2022 20:41:35 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nNhPC-0001E5-M3; Fri, 25 Feb 2022 20:41:34 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nNhPC-0006aK-Ld; Fri, 25 Feb 2022 20:41:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=GpW5mJCNNbsnxZCoUNucgcY1MVxiBbiu/zssEkHyfgM=; b=vI8jH5WGfj6mJQXV4THlyZyMQM
	aROhYRbLvzMssO3efIWUrHR0mq0D5PQofEvsmvQzTtdUMs2OjrTxTobFkGSSb20h0TWMe9MVXErO1
	TbY1ffnDISzG9g69ljgsHQNR1nRzcVvij5phxZr0H9QogDfKvDjbUQVI+0UlpR5TzDXA=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168232-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 168232: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=54cddc3ad4b3a317985ce5f491f9b1f31ab10dd8
X-Osstest-Versions-That:
    ovmf=b24306f15daa2ff8510b06702114724b33895d3c
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 25 Feb 2022 20:41:34 +0000

flight 168232 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168232/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 54cddc3ad4b3a317985ce5f491f9b1f31ab10dd8
baseline version:
 ovmf                 b24306f15daa2ff8510b06702114724b33895d3c

Last test of basis   168185  2022-02-21 15:43:05 Z    4 days
Testing same since   168232  2022-02-25 16:10:29 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Ard Biesheuvel <ardb@kernel.org>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   b24306f15d..54cddc3ad4  54cddc3ad4b3a317985ce5f491f9b1f31ab10dd8 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Fri Feb 25 20:55:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 20:55:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279606.477358 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNhcN-0004Ld-W0; Fri, 25 Feb 2022 20:55:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279606.477358; Fri, 25 Feb 2022 20:55:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNhcN-0004LW-St; Fri, 25 Feb 2022 20:55:11 +0000
Received: by outflank-mailman (input) for mailman id 279606;
 Fri, 25 Feb 2022 20:55:11 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nNhcM-0004LQ-VO
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 20:55:10 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nNhcM-0002Gc-MX; Fri, 25 Feb 2022 20:55:10 +0000
Received: from 54-240-197-234.amazon.com ([54.240.197.234]
 helo=[192.168.31.13]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nNhcM-00023h-GO; Fri, 25 Feb 2022 20:55:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=LPyNC422MbgOl7mcGhV5zK1/711pAOhIpnk66/nGPxg=; b=i7qT6d3tAss2tOLu+owyuaJFNm
	tu6j+ugUBfJRAW9iamQ6Eic9se0nIRTK/ulTnc7ZSVBrudYU7aub+TtYgVH2TAcpbsCqbf/+mb9A7
	UGyKi5AFv0SpMdkFb0h2nwGcr8B9mqEly1Glsd+gTzE64fza7kVt5ZE71lvWFGuG29aI=;
Message-ID: <04db7e8b-2f04-41d7-1deb-d8bda3625c04@xen.org>
Date: Fri, 25 Feb 2022 20:55:08 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.1
Subject: Re: Proposal for Porting Xen to Armv8-R64 - DraftA
To: Wei Chen <Wei.Chen@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Stefano Stabellini <sstabellini@kernel.org>
Cc: Bertrand Marquis <Bertrand.Marquis@arm.com>,
 Penny Zheng <Penny.Zheng@arm.com>, Henry Wang <Henry.Wang@arm.com>,
 nd <nd@arm.com>
References: <PAXPR08MB7420A01809B84E04E196793F9E3D9@PAXPR08MB7420.eurprd08.prod.outlook.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <PAXPR08MB7420A01809B84E04E196793F9E3D9@PAXPR08MB7420.eurprd08.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Wei,

Thank you for sending the proposal. Please find some comments below.

On 24/02/2022 06:01, Wei Chen wrote:
> # Proposal for Porting Xen to Armv8-R64
> 
> This proposal will introduce the PoC work of porting Xen to Armv8-R64,
> which includes:
> - The changes of current Xen capability, like Xen build system, memory
>    management, domain management, vCPU context switch.
> - The expanded Xen capability, like static-allocation and direct-map.
> 
> ***Notes:***
> 1. ***This proposal only covers the work of porting Xen to Armv8-R64***
>     ***single CPU. Xen SMP support on Armv8-R64 relates to Armv8-R***
>     ***Trusted-Frimware (TF-R). This is an external dependency,***
>     ***so we think the discussion of Xen SMP support on Armv8-R64***
>     ***should be started when single-CPU support is complete.***

I agree that we should first focus on single-CPU support.

> 2. ***This proposal will not touch xen-tools. In current stage,***
>     ***Xen on Armv8-R64 only support dom0less, all guests should***
>     ***be booted from device tree.***

Make sense. I actually expect some issues in the way xen-tools would 
need to access memory of the domain that is been created.

[...]

> ### 1.2. Xen Challenges with PMSA Virtualization
> Xen is PMSA unaware Type-1 Hypervisor, it will need modifications to run
> with an MPU and host multiple guest OSes.
> 
> - No MMU at EL2:
>      - No EL2 Stage 1 address translation
>          - Xen provides fixed ARM64 virtual memory layout as basis of EL2
>            stage 1 address translation, which is not applicable on MPU system,
>            where there is no virtual addressing. As a result, any operation
>            involving transition from PA to VA, like ioremap, needs modification
>            on MPU system.
>      - Xen's run-time addresses are the same as the link time addresses.
>          - Enable PIC (position-independent code) on a real-time target
>            processor probably very rare.

Aside the assembly boot code and UEFI stub, Xen already runs at the same 
address as it was linked.

>      - Xen will need to use the EL2 MPU memory region descriptors to manage
>        access permissions and attributes for accesses made by VMs at EL1/0.
>          - Xen currently relies on MMU EL1 stage 2 table to manage these
>            accesses.
> - No MMU Stage 2 translation at EL1:
>      - A guest doesn't have an independent guest physical address space
>      - A guest can not reuse the current Intermediate Physical Address
>        memory layout
>      - A guest uses physical addresses to access memory and devices
>      - The MPU at EL2 manages EL1 stage 2 access permissions and attributes
> - There are a limited number of MPU protection regions at both EL2 and EL1:
>      - Architecturally, the maximum number of protection regions is 256,
>        typical implementations have 32.
>      - By contrast, Xen does not need to consider the number of page table
>        entries in theory when using MMU.
> - The MPU protection regions at EL2 need to be shared between the hypervisor
>    and the guest stage 2.
>      - Requires careful consideration - may impact feature 'fullness' of both
>        the hypervisor and the guest
>      - By contrast, when using MMU, Xen has standalone P2M table for guest
>        stage 2 accesses.

[...]

> - ***Define new system registers for compilers***:
>    Armv8-R64 is based on Armv8.4. That means we will use some Armv8.4
>    specific system registers. As Armv8-R64 only have secure state, so
>    at least, `VSTCR_EL2` and `VSCTLR_EL2` will be used for Xen. And the
>    first GCC version that supports Armv8.4 is GCC 8.1. In addition to
>    these, PMSA of Armv8-R64 introduced lots of MPU related system registers:
>    `PRBAR_ELx`, `PRBARx_ELx`, `PRLAR_ELx`, `PRLARx_ELx`, `PRENR_ELx` and
>    `MPUIR_ELx`. But the first GCC version to support these system registers
>    is GCC 11. So we have two ways to make compilers to work properly with
>    these system registers.
>    1. Bump GCC version to GCC 11.
>       The pros of this method is that, we don't need to encode these
>       system registers in macros by ourselves. But the cons are that,
>       we have to update Makefiles to support GCC 11 for Armv8-R64.
>       1.1. Check the GCC version 11 for Armv8-R64.
>       1.2. Add march=armv8r to CFLAGS for Armv8-R64.
>       1.3. Solve the confliction of march=armv8r and mcpu=generic
>      These changes will affect common Makefiles, not only Arm Makefiles.
>      And GCC 11 is new, lots of toolchains and Distro haven't supported it.

I agree that forcing to use GCC11 is not a good idea. But I am not sure 
to understand the problem with the -march=.... Ultimately, shouldn't we 
aim to build Xen ARMv8-R with -march=armv8r?

[...]

> ### **2.2. Changes of the initialization process**
> In general, we still expect Armv8-R64 and Armv8-A64 to have a consistent
> initialization process. In addition to some architecture differences, there
> is no more than reusable code that we will distinguish through CONFIG_ARM_MPU
> or CONFIG_ARM64_V8R. We want most of the initialization code to be reusable
> between Armv8-R64 and Armv8-A64.
> 
> - We will reuse the original head.s and setup.c of Arm. But replace the
>    MMU and page table operations in these files with configuration operations
>    for MPU and MPU regions.
> 
> - We provide a boot-time MPU configuration. This MPU configuration will
>    support Xen to finish its initialization. And this boot-time MPU
>    configuration will record the memory regions that will be parsed from
>    device tree.
> 
>    In the end of Xen initialization, we will use a runtime MPU configuration
>    to replace boot-time MPU configuration. The runtime MPU configuration will
>    merge and reorder memory regions to save more MPU regions for guests.
>    ![img](https://drive.google.com/uc?export=view&id=1wTFyK2XfU3lTlH1PqRDoacQVTwUtWIGU)
> 
> - Defer system unpausing domain.
>    When Xen initialization is about to end, Xen unpause guests created
>    during initialization. But this will cause some issues. The unpause
>    action occurs before free_init_memory, however the runtime MPU configuration
>    is built after free_init_memory.

I was half expecting that free_init_memory() would not be called for Xen 
Armv8R.

> 
>    So if the unpaused guests start executing the context switch at this
>    point, then its MPU context will base on the boot-time MPU configuration.

Can you explain why you want to switch the MPU configuration that late?

>    Probably it will be inconsistent with runtime MPU configuration, this
>    will cause unexpected problems (This may not happen in a single core
>    system, but on SMP systems, this problem is foreseeable, so we hope to
>    solve it at the beginning).

[...]

> ### **2.4. Changes of memory management**
> Xen is coupled with VMSA, in order to port Xen to Armv8-R64, we have to
> decouple Xen from VMSA. And give Xen the ability to manage memory in PMSA.
> 
> 1. ***Use buddy allocator to manage physical pages for PMSA***
>     From the view of physical page, PMSA and VMSA don't have any difference.
>     So we can reuse buddy allocator on Armv8-R64 to manage physical pages.
>     The difference is that, in VMSA, Xen will map allocated pages to virtual
>     addresses. But in PMSA, Xen just convert the pages to physical address.
> 
> 2. ***Can not use virtual address for memory management***
>     As Armv8-R64 only has PMSA in EL2, Xen loses the ability of using virtual
>     address to manage memory. This brings some problems, some virtual address
>     based features could not work well on Armv8-R64, like `FIXMAP`, `vmap/vumap`,
>     `ioremap` and `alternative`.
> 
>     But the functions or macros of these features are used in lots of common
>     code. So it's not good to use `#ifdef CONFIG_ARM_MPU` to gate relate code
>     everywhere. In this case, we propose to use stub helpers to make the changes
>     transparently to common code.
>     1. For `FIXMAP`, we will use `0` in `FIXMAP_ADDR` for all fixmap operations.
>        This will return physical address directly of fixmapped item.
>     2. For `vmap/vumap`, we will use some empty inline stub helpers:
>          ```
>          static inline void vm_init_type(...) {}
>          static inline void *__vmap(...)
>          {
>              return NULL;
>          }
>          static inline void vunmap(const void *va) {}
>          static inline void *vmalloc(size_t size)
>          {
>              return NULL;
>          }
>          static inline void *vmalloc_xen(size_t size)
>          {
>              return NULL;
>          }
>          static inline void vfree(void *va) {}
>          ```
> 
>     3. For `ioremap`, it depends on `vmap`. As we have make `vmap` to always
>        return `NULL`, they could not work well on Armv8-R64 without changes.
>        `ioremap` will return input address directly.
>          ```
>          static inline void *ioremap_attr(...)
>          {
>              /* We don't have the ability to change input PA cache attributes */
OOI, who will set them?

>              if ( CACHE_ATTR_need_change )
>                  return NULL;
>              return (void *)pa;
>          }
>          static inline void __iomem *ioremap_nocache(...)
>          {
>              return ioremap_attr(start, len, PAGE_HYPERVISOR_NOCACHE);
>          }
>          static inline void __iomem *ioremap_cache(...)
>          {
>              return ioremap_attr(start, len, PAGE_HYPERVISOR);
>          }
>          static inline void __iomem *ioremap_wc(...)
>          {
>              return ioremap_attr(start, len, PAGE_HYPERVISOR_WC);
>          }
>          void *ioremap(...)
>          {
>              return ioremap_attr(pa, len, PAGE_HYPERVISOR_NOCACHE);
>          }
> 
>          ```
>      4. For `alternative`, it depends on `vmap` too.

The only reason we depend on vmap() is because the map the sections 
*text read-only and we enforce WnX. For VMSA, it would be possible to 
avoid vmap() with some rework. I don't know for PMSA.

> We will simply disable
>         it on Armv8-R64 in current stage. How to implement `alternative`
>         on Armv8-R64 is better to be discussed after basic functions of Xen
>         on Armv8-R64 work well.
alternative are mostly helpful to handle errata or enable features that 
are not present on all CPUs. I wouldn't expect this to be necessary at 
the beginning. In fact, on Arm, it was introduced > 4 years after the 
initial port :).

[...]

> ### **2.5. Changes of device driver**
> 1. Because Armv8-R64 only has single secure state, this will affect some
> devices that have two secure state, like GIC. But fortunately, most
> vendors will not link a two secure state GIC to Armv8-R64 processors.
> Current GIC driver can work well with single secure state GIC for Armv8-R64.
> 2. Xen should use secure hypervisor timer in Secure EL2. We will introduce
> a CONFIG_ARM_SECURE_STATE to make Xen to use secure registers for timer.
> 
> ### **2.7. Changes of virtual device**
> Currently, we only support pass-through devices in guest. Because event
> channel, xen-bus, xen-storage and other advanced Xen features haven't been
> enabled in Armv8-R64.

That's fine. I expect to require quite a bit of work to move from Xen 
sharing the pages (e.g. like for grant-tables) to the guest sharing pages.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Feb 25 21:29:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 21:29:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279615.477369 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNi9M-0007sv-Ss; Fri, 25 Feb 2022 21:29:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279615.477369; Fri, 25 Feb 2022 21:29:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNi9M-0007so-OX; Fri, 25 Feb 2022 21:29:16 +0000
Received: by outflank-mailman (input) for mailman id 279615;
 Fri, 25 Feb 2022 21:29:15 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nNi9L-0007se-Bx; Fri, 25 Feb 2022 21:29:15 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nNi9L-0002pR-9H; Fri, 25 Feb 2022 21:29:15 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nNi9K-0003Ae-Sp; Fri, 25 Feb 2022 21:29:14 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nNi9K-0006iR-Ry; Fri, 25 Feb 2022 21:29:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=lWTwCFBg2iHSPpqdK+910CMXaNZOR7UwDoNWKsM0iWM=; b=21lg+ixcMOnmf/mkMFzle+ARg6
	Za4azEJZ+Yo2cq2MUr3Yfm15PDl6zmDccE5UZdA3+A72++mZM42EalGeXFtKSqQthWGfWeOgrr7LD
	jBdSNmScHWr+wscKM33jVGpUJ8QW6DDDGkyjFAWJTFdjWAurFEKhWWmZs9rmo98GF5oQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168230-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 168230: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-amd64-i386-libvirt-pair:guest-migrate/dst_host/src_host/debian.repeat:fail:heisenbug
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=fa435db8ce1dff3b15e3f59a12f55f7b3a347b08
X-Osstest-Versions-That:
    qemuu=4aa2e497a98bafe962e72997f67a369e4b52d9c1
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 25 Feb 2022 21:29:14 +0000

flight 168230 qemu-mainline real [real]
flight 168234 qemu-mainline real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/168230/
http://logs.test-lab.xenproject.org/osstest/logs/168234/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-i386-libvirt-pair 28 guest-migrate/dst_host/src_host/debian.repeat fail pass in 168234-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168217
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168217
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168217
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168217
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168217
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168217
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168217
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168217
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 qemuu                fa435db8ce1dff3b15e3f59a12f55f7b3a347b08
baseline version:
 qemuu                4aa2e497a98bafe962e72997f67a369e4b52d9c1

Last test of basis   168217  2022-02-24 13:08:23 Z    1 days
Testing same since   168230  2022-02-25 11:36:57 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Daniel P. Berrangé <berrange@redhat.com>
  Eduardo Habkost <eduardo@habkost.net>
  John Snow <jsnow@redhat.com>
  Peter Maydell <peter.maydell@linaro.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 fail    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   4aa2e497a9..fa435db8ce  fa435db8ce1dff3b15e3f59a12f55f7b3a347b08 -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Fri Feb 25 22:40:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 22:40:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279628.477391 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNjFv-0007Z7-DF; Fri, 25 Feb 2022 22:40:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279628.477391; Fri, 25 Feb 2022 22:40:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNjFv-0007Z0-7w; Fri, 25 Feb 2022 22:40:07 +0000
Received: by outflank-mailman (input) for mailman id 279628;
 Fri, 25 Feb 2022 22:40:05 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nNjFt-0007Ox-GO; Fri, 25 Feb 2022 22:40:05 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nNjFt-0003z6-Ei; Fri, 25 Feb 2022 22:40:05 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nNjFt-0006rj-5g; Fri, 25 Feb 2022 22:40:05 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nNjFt-0007Ld-5F; Fri, 25 Feb 2022 22:40:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=6KxlHcOKTUKE9mn5kJmqkRL5ElKdmlgPF0srJOOhcBM=; b=ggARX/U31IHJwJDNhoEH0o9W6O
	pz5KA7dPqSEqlF4MogHI3HB0nIJDX4I77UA+iUGJBPmF/MJKMoszImjnSqT8FFG19rhWGHphscfGG
	0mxib7f1AlipB9AltHFah14CVKest1reRrIe4AhKNxO7i9hWJPMv+Uf01Oge4gHuHzsk=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168233-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 168233: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=10f1f7b010a22d6d4ee67b018412d5f7ea386fc6
X-Osstest-Versions-That:
    xen=f0f2f42c21de82ff65672e8ecfadcfddc63f2186
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 25 Feb 2022 22:40:05 +0000

flight 168233 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168233/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  10f1f7b010a22d6d4ee67b018412d5f7ea386fc6
baseline version:
 xen                  f0f2f42c21de82ff65672e8ecfadcfddc63f2186

Last test of basis   168229  2022-02-25 11:00:28 Z    0 days
Testing same since   168233  2022-02-25 18:01:50 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Thiner Logoer <logoerthiner1@163.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   f0f2f42c21..10f1f7b010  10f1f7b010a22d6d4ee67b018412d5f7ea386fc6 -> smoke


From xen-devel-bounces@lists.xenproject.org Fri Feb 25 22:40:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 22:40:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279627.477380 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNjFl-0006Zv-Ue; Fri, 25 Feb 2022 22:39:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279627.477380; Fri, 25 Feb 2022 22:39:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNjFl-0006Zo-RV; Fri, 25 Feb 2022 22:39:57 +0000
Received: by outflank-mailman (input) for mailman id 279627;
 Fri, 25 Feb 2022 22:39:56 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=COT/=TI=oracle.com=boris.ostrovsky@srs-se1.protection.inumbo.net>)
 id 1nNjFj-0006Zg-As
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 22:39:56 +0000
Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com
 [205.220.177.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d818f517-968b-11ec-8eb9-a37418f5ba1a;
 Fri, 25 Feb 2022 23:39:52 +0100 (CET)
Received: from pps.filterd (m0246632.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 21PMbGJs027396; 
 Fri, 25 Feb 2022 22:39:22 GMT
Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70])
 by mx0b-00069f02.pphosted.com with ESMTP id 3eexj8a9cr-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Fri, 25 Feb 2022 22:39:22 +0000
Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1])
 by aserp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 21PMacOm185227;
 Fri, 25 Feb 2022 22:39:21 GMT
Received: from nam12-dm6-obe.outbound.protection.outlook.com
 (mail-dm6nam12lp2172.outbound.protection.outlook.com [104.47.59.172])
 by aserp3020.oracle.com with ESMTP id 3eb4858t69-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Fri, 25 Feb 2022 22:39:21 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10)
 by BYAPR10MB2759.namprd10.prod.outlook.com (2603:10b6:a02:b5::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Fri, 25 Feb
 2022 22:39:19 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::6d20:6694:a16:56f7]) by BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::6d20:6694:a16:56f7%3]) with mapi id 15.20.5017.026; Fri, 25 Feb 2022
 22:39:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d818f517-968b-11ec-8eb9-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date :
 subject : to : cc : references : from : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2021-07-09;
 bh=1O3xyKUv4FtQGNH4I0wtWPNQhC27Zof8tVcpw0UEso0=;
 b=c3HJbgfYAsx9m6LBldw3AtCO6AosCbMqrydUsVbOjl+OpJHAya3bAdtaGnG6TYutdmJk
 rzSBVr49TVuuGN/BRr9T8+VncaPayczfVlyLX9VvB/CX09xdeSBoJcgFOAbaQV6G539M
 bg6+MZOUrAd3VXZ6l7zCcwpxkqyzmwwG4DBfc9Pd44siLCFi5RKxJ0ce4ODxS5xrkqxX
 5u9FDvLIF2uRHkKqUvoLcqlFpoe4B0hFRq2sHZS9kLByT6Cs8aIqx0DU8zszajuM88FG
 C4KOPnC0UROZBcLexnC60kog5LzaMhbemGg9gX4KAmmWNHQug4F4I3ZNlVHbMsHE5NU1 Nw== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=GNUmQcfu4YvgHUqXpDNenyI2KJh+wxogbf1sCbUtgh2yj1/5Z3ioEt9MbRRuJKlG0m1d4P1PHw93qHWHW4tBLi53nOB/09e8YZ3k0C1I0WF1qQx0lzGooSYckhX7gg2ev+yU59UvnzveCbV96R+Ja03qrSa2d18Rp5Nz5b+DSEfmSELxwG7QUQrEizspvE3IFK54czI1Nv5ywdNvUq4dyqWlb+UAz5wEtsxMzrmMPJHBKVEEtuCUaKIgI7ztoRPnYhxu0GwkM/j5GDr4hNWVpjweu5TndcGvMTmgMu3DqMCbmlnNsvmgcMIawu8BKwUyjfXXoSVv3rTzBRr8TbgcvQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=1O3xyKUv4FtQGNH4I0wtWPNQhC27Zof8tVcpw0UEso0=;
 b=X1qZyywrE9zcekRPSPOsHnas0ob6hiPP1scFuuIeUty3eWyQn/HINukLbbQZgM9pTtTefgPMeMsKmreOxktyeS8U6cLqUGuRq8VIriso+P52Joj/Ewzzu9+hdagu4GQ3gwtxTeH3Ybpkz1zf8I2WewcVaMo1767G0Z33w2+z5rwIfN0kmVtfjxaSPaAKN82RynZ/AsHzFgG5tdVKmEBDlXl41PL3o3409V9EVqv5w2GRAVvl3QY9BdHQiViSO+7F3A36hzAi3sjq/EWUWQJ4iIAkIBdwIKvi3K0OQUmdsGJQKkeKZTq5fVNW+ZPlKElCsCEk7rXcecjnACroGbuOgw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=1O3xyKUv4FtQGNH4I0wtWPNQhC27Zof8tVcpw0UEso0=;
 b=NrK/Hc897E+Npd608xwvDRhVj7KTYvNePEnHmo/fIFnk1vH0/6QcVovoguX8gkr+EA+ZF7CQNkeQo5L577sumFTg2gqRLEO031gStH//KQZWnYbFtOETFMXhM2fcvO3PKblkYZhZs8IUphoM0bNmDNNpxCZL5s0uoqg77gX0C5U=
Message-ID: <9de1059b-6b48-e2c8-60bc-f29b42b217f7@oracle.com>
Date: Fri, 25 Feb 2022 17:39:15 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.1
Subject: Re: [PATCH v3 0/1] xen: fix HVM kexec kernel panic
Content-Language: en-US
To: Dongli Zhang <dongli.zhang@oracle.com>, xen-devel@lists.xenproject.org,
        x86@kernel.org
Cc: linux-kernel@vger.kernel.org, jgross@suse.com, sstabellini@kernel.org,
        tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
        dave.hansen@linux.intel.com, hpa@zytor.com, joe.jin@oracle.com
References: <20220224215049.2845-1-dongli.zhang@oracle.com>
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <20220224215049.2845-1-dongli.zhang@oracle.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: SN7PR04CA0077.namprd04.prod.outlook.com
 (2603:10b6:806:121::22) To BLAPR10MB5009.namprd10.prod.outlook.com
 (2603:10b6:208:321::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4f5c8bec-62cc-4055-fd3d-08d9f8afa946
X-MS-TrafficTypeDiagnostic: BYAPR10MB2759:EE_
X-Microsoft-Antispam-PRVS: 
	<BYAPR10MB2759130AA49812FB8AD8C7158A3E9@BYAPR10MB2759.namprd10.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	kf0vNL5JTc403HkjW7G8eaghvFZD0LbemcC2AGfNWzvREmRjtxM6/MZ79ZwpwFaG22JVc4W59qD5Glu+NUwx8THrhpkF61XMQqIHIMwqkEZBCj3j2a6m5yjfgalGWIMKDiZmkmwogBoLuw38uA8Y3VHsEr232/VznBIEBX7hEPXYuBUdivpKqamCc3Qoihcexu7C5DGG11n0oJh8J5Hrkg+1zo+NQVdeMebDT9iombq1OWY6hDXwywLJLdGg3KF+cplaHbK9H/ZtYAnaYT4OUw4ZhShQ58l9W+9lhOHhxtgpWjyYXWJWi/vVhC+6rZ9KCMuMq9zG6mqhwdDyBl8RVzUAcQN2tWlI3S95Sj4dVBVrAzxTzvXUbBU7EALh770Nir9xOfTuilEv57r6uLlBVUsW93mvHxZQUYOVHFbl7U/CFks9nQrMcPA3lBBX4cXT6PXL1Z4L64XefFst6UgxAqqhgqHJ6RhA7BnnSutGQXy2DAo8e7mZ72QXc3i+CYcmvUYZYnEt4Wo3SM1THiJO/9QwOaW1KSdwGkr4wSibviSlKZI+BmF7QOCrUfv5myrhvD4LX9uSUPEDS5YN3qsv4kbVrUagRsihgVMQChydhJCfRlC//4S5HGjCVwizVEczq7y6HzOKzeiA15J8Pj+aD4T90wp8eMwg8rDd0Nz4P4r+zkTKldm8nAFuoTxM/1vQODjTmF5xxt7sJSuHQOIqc/LT4TcB2gX41zRtWfoC+oe8vMD2Y+E67GUURi+8C95iS6Oj7oJFnPoYsPlsGt42XP9yLA0spoaQ51vuyhxbjH1fvrFmnRbA9T2Y9MkfOdwPfXFbVI/uwYM2E8qk6Maz3Q==
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8676002)(5660300002)(44832011)(66476007)(66946007)(36756003)(316002)(8936002)(4326008)(66556008)(966005)(7416002)(38100700002)(2906002)(6506007)(6666004)(508600001)(6512007)(31686004)(107886003)(83380400001)(31696002)(26005)(186003)(6486002)(86362001)(2616005)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?Rml1ajBzTlNMUElVYlVYTzcwNUZET0thN2VXcGxPbk56TEl0WFBHUUN3VWpy?=
 =?utf-8?B?RmxIYVhMd2dqYVRFWkN2M3gvTEgxeDdsRnpOb1RzRkFEZlFkV1liTUxUeTVJ?=
 =?utf-8?B?NkdBM0NtM3pDVE1rSUVBRFZBZndLa2p5WHdSV0REYTBHM3ltVkZDSW14Z1hu?=
 =?utf-8?B?Nk55NXg4Y05XMld1dWNMbmswUmJUTC90TElHNW1rR1Z4dmdHQUR0a1FCVmlL?=
 =?utf-8?B?ekJjVURobUh5TTFSSlExNWo2TXhSWFN6SGNmZFI5YlZHeFpnQkp5c3M1RlYr?=
 =?utf-8?B?MjJxekZpVnhxOG9MZWI0SXFOQ010cXNYeVNGV3BQbkcxbTdWRU03dlRHM0Nk?=
 =?utf-8?B?dElRVzFLV24yQzllM2IxTjJsWWpWWE54eFFGN3d0WFVHZXlSU01SbjNFZDVi?=
 =?utf-8?B?MGNWeUZvRzlUSlNScUNJSlV0NkpNVEVNVlBmNzJ5VkpIaXI4Y0h4VDI3NVph?=
 =?utf-8?B?MFM3UkZjajBpN2tyM3ZXb25zZVZ2bWhjQktZUjdkRkp4ZDBOTDNmY25iSUJE?=
 =?utf-8?B?WWcxdGtRRGNvRENKODUzeUdRS2RKdHBwOW1GcU9raWk3MkpGUkhlbEtWenVi?=
 =?utf-8?B?Y01kL3JXRm8rYk4vc2ZSSi9kbW1tb2Y4cnYzZW50OFFyTGUrbnA3akhoK3ZZ?=
 =?utf-8?B?K2pMeDRQSnErODBMbmpsNitNdE02ZXE2NU5TS1pVK3g1dUkxVnlqb2dOd3o5?=
 =?utf-8?B?K0h3bWdyUGRlaHhTM2xBR3FOZlRqSVF3S3o5WFVnQ2JQanhWTlNYN1JmWkVt?=
 =?utf-8?B?OFROY1JGWi9ySlJTTzZZR0JZU2JyNGtlRDZYMlp5ck52c1BRNmdoT3ZlM3pr?=
 =?utf-8?B?N2htY2hURVhhenVIQW1uSW5PbU9jSGZxei9TUVhXdWxXdUlPZENqcGw4UXo2?=
 =?utf-8?B?ejR1aFkyMHVCRHJxOVpUdXZ0L0xnYnlwK1BJUlBkcFUvSjlqdVJZLzJheGVl?=
 =?utf-8?B?THpyODRTSnp2RHE2ZnM2L1lRMzhWYjZsQ1NuWjlML1dnb3RrZUhsc292UjNN?=
 =?utf-8?B?NWNEdWJpWWIvdUlNcWlUNGVUZEFGdkU1Vk01c0RXT3RJOGNlNVRMVm5iMVlm?=
 =?utf-8?B?L01Hay9yWklEcHQrd1ZtWTFMbjcyOFFHV3NVUTBhbTRBeWlTZEw3V1FQN0VE?=
 =?utf-8?B?VUhpUEVBOHJqd29rdWpWMkNHdWRxd01wOWszMCtOTTRHeHFYQ0I4RnJQcVZK?=
 =?utf-8?B?RGd4dElwV05ONTk4cllJOEJMZjUyKzJYbzJteWZtb0VJaEFmWUttUUJub01K?=
 =?utf-8?B?bVdkWXJhWG5ZeVZoWGt4KzVVTXNzVkMrL3FrZ2ZUdjg2UFErTjRqV1NsQS83?=
 =?utf-8?B?OGZ0alBGbHVzSGZuckVYazhJZTBpUThkYjJMbE5CSldDM1JzWXhOYzV1dHds?=
 =?utf-8?B?c0RXWjV3Yk9raXBwRU1oTldJUkFCVWtyVGtYU1VBS1luTTNBbzYrMWRXdldY?=
 =?utf-8?B?eWluSldwS1pMaWFucm9VdmxTcGZnYkRHdDZVWjlXa1JhN1pxZkFSS0NHdHdX?=
 =?utf-8?B?MmJpMlpoQjM0T0s4emFhV080cVczRTN3TWh4dDlwU3QzemFSU2NQc282aWJn?=
 =?utf-8?B?dG1tQ0xPVW1McEFmRExHVTNqSk15TFl3cnpXamRvMm4zd0tpdHppMFFNbGNT?=
 =?utf-8?B?V3ZzeDBxU2tlMzlsdm44d1lWSFd4S1BtZSsrc2hwZXVBRTFFMEZpK2ZKU01r?=
 =?utf-8?B?NE41M3FNb3RMd2tLbXIrdlVCZVBMd1lpdVNvWThKUFFCU2xjVzRBTlFmOE5q?=
 =?utf-8?B?RmNiNG9hcFhRc01xY1RFYXNySXZnZGlsYmh3aStTbzNEeXRYb1J0WkVaQkdU?=
 =?utf-8?B?VFlldHY1TTdpRmg1RWZMTk5ES3RZeEZkVEF4NEVudHhqb2lVdmlLS2xnaUFq?=
 =?utf-8?B?Z0VLRjFjb2FxZGE1RlpTWWVHbzR6dzYwSG1DQUVOS3dNWi9ONmgzU08rbzhm?=
 =?utf-8?B?M25kcWxpc2Jpbzd6WTRDVk9pZDBodHZiZkdvN1phSXlTVHdtM2ZEc245Z3J3?=
 =?utf-8?B?MUd3bGh3dXdCZFZORFNZZzBHUlEwdTB5TzNGbkh6ckJ2dmZiYTRtMGkrSmVF?=
 =?utf-8?B?VW1wTysxaDJZSFZTbFh4SGExSW5Jcm9EbHh5MjNEc1NJVkRVcGFZK0NOYTJp?=
 =?utf-8?B?WXFISlJ6MW9WM1JCQVQvdFpYZ0o4aFhnb3R3U0YyYWQ0U1lleUhKRU5uVEZh?=
 =?utf-8?B?VEgxRnVjWDdKYldRMjVvNjBDK2lFMGpKc3BmY090UFhhMWJwNlZEdmIvYk5H?=
 =?utf-8?Q?yao9D02ss+P6h0sIyaSlKiACQcV8QVgpwiIgCOwBSA=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4f5c8bec-62cc-4055-fd3d-08d9f8afa946
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2022 22:39:19.4633
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: N4ExZ3wh3B7s3R7Z5gnQo/1rj7nF+/eWHVhO/y2i7RxeNJmm7fkiSwJzqUTmCb5FX50jscRHGPoJ8O2wwXybhKpEr74aLFAQr3P5KHE0kEQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB2759
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10269 signatures=684655
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0
 mlxlogscore=999 adultscore=0 bulkscore=0 phishscore=0 suspectscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202250123
X-Proofpoint-GUID: x0hkbZMcXLs-sFfnRrCEiRnDvFHgkKZ3
X-Proofpoint-ORIG-GUID: x0hkbZMcXLs-sFfnRrCEiRnDvFHgkKZ3


On 2/24/22 4:50 PM, Dongli Zhang wrote:
> This is the v3 of the patch to fix xen kexec kernel panic issue when the
> kexec is triggered on VCPU >= 32.
>
> PANIC: early exception 0x0e IP 10:ffffffffa96679b6 error 0 cr2 0x20
> [    0.000000] CPU: 0 PID: 0 Comm: swapper Not tainted 5.17.0-rc4xen-00054-gf71077a4d84b-dirty #1
> [    0.000000] Hardware name: Xen HVM domU, BIOS 4.4.4OVM 12/15/2020
> [    0.000000] RIP: 0010:pvclock_clocksource_read+0x6/0xb0
> ... ...
> [    0.000000] RSP: 0000:ffffffffaae03e10 EFLAGS: 00010082 ORIG_RAX: 0000000000000000
> [    0.000000] RAX: 0000000000000000 RBX: 0000000000010000 RCX: 0000000000000002
> [    0.000000] RDX: 0000000000000003 RSI: ffffffffaac37515 RDI: 0000000000000020
> [    0.000000] RBP: 0000000000011000 R08: 0000000000000000 R09: 0000000000000001
> [    0.000000] R10: ffffffffaae03df8 R11: ffffffffaae03c68 R12: 0000000040000004
> [    0.000000] R13: ffffffffaae03e50 R14: 0000000000000000 R15: 0000000000000000
> [    0.000000] FS:  0000000000000000(0000) GS:ffffffffab588000(0000) knlGS:0000000000000000
> [    0.000000] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> [    0.000000] CR2: 0000000000000020 CR3: 00000000ea410000 CR4: 00000000000406a0
> [    0.000000] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
> [    0.000000] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
> [    0.000000] Call Trace:
> [    0.000000]  <TASK>
> [    0.000000]  ? xen_clocksource_read+0x24/0x40


This is done to set xen_sched_clock_offset which I think will not be used for a while, until sched_clock is called (and the other two uses are for suspend/resume)


Can we simply defer 'xen_sched_clock_offset = xen_clocksource_read();' until after all vcpu areas are properly set? Or are there other uses of xen_clocksource_read() before ?


-boris


> [    0.000000]  ? xen_init_time_common+0x5/0x49
> [    0.000000]  ? xen_hvm_init_time_ops+0x23/0x45
> [    0.000000]  ? xen_hvm_guest_init+0x221/0x25c
> [    0.000000]  ? 0xffffffffa9600000
> [    0.000000]  ? setup_arch+0x440/0xbd6
> [    0.000000]  ? start_kernel+0x6c/0x695
> [    0.000000]  ? secondary_startup_64_no_verify+0xd5/0xdb
> [    0.000000]  </TASK>
>
>
> Changed since v1:
>    - Add commit message to explain why xen_hvm_init_time_ops() is delayed
>      for any vcpus. (Suggested by Boris Ostrovsky)
>    - Add a comment in xen_hvm_smp_prepare_boot_cpu() referencing the related
>      code in xen_hvm_guest_init(). (suggested by Juergen Gross)
> Changed since v2:
>    - Delay for all VCPUs. (Suggested by Boris Ostrovsky)
>    - Add commit message that why PVM is not supported by this patch
>    - Test if kexec/kdump works with mainline xen (HVM and PVM)
>
>
> I have delayed the xen_hvm_init_time_ops() for all VCPUs. Unfortunately,
> now I am able to reproduce the clock backward as shown below on some old
> versions of xen. I am not able to reproduce on most recent mainline xen.
>
> [    0.359687] pcpu-alloc: [0] 16 17 18 19 20 21 22 23 [0] 24 25 26 27 28 29 30 31
> [    0.359694] pcpu-alloc: [0] 32 33 34 35 36 37 38 39 [0] 40 41 42 43 44 45 46 47
> [    0.359701] pcpu-alloc: [0] 48 49 50 51 52 53 54 55 [0] 56 57 58 59 60 61 62 63
>
> ... clock backward after the clocksource is switched from native to xen...
>
> [    0.000004] Fallback order for Node 0: 0
> [    0.002967] Built 1 zonelists, mobility grouping on.  Total pages: 3527744
> [    0.007129] Policy zone: Normal
> [    0.008937] Kernel command line: BOOT_IMAGE=/boot/vmlinuz-5.17.0-rc4xen-00054-gf71077a4d84b-dirty root=UUID=2a5975ab-a059-4697-9aee-7a53ddfeea21 ro text console=ttyS0,115200n8 console=tty1 earlyprintk=tty    S0,115200n8 loglevel=7 no_timer_check reboot=s32 splash crashkernel=512M-:192M vt.handoff=1
> [    0.023880] Unknown kernel command line parameters "text splash BOOT_IMAGE=/boot/vmlinuz-5.17.0-rc4xen-00054-gf71077a4d84b-dirty", will be passed to user space.
> [    0.032647] printk: log_buf_len individual max cpu contribution: 4096 bytes
> [    0.036828] printk: log_buf_len total cpu_extra contributions: 258048 bytes
> [    0.041049] printk: log_buf_len min size: 262144 bytes
> [    0.044481] printk: log_buf_len: 524288 bytes
>
>
> Since now I am able to reproduce the clock backward on old xen version,
> please let me know if I should re-use the v2 of this patch, as it has been
> running well in our env well for very long time.
>
> https://lore.kernel.org/all/20211028012543.8776-1-dongli.zhang@oracle.com/
>
>
> BTW, I have tested that 'soft_reset' does not work with mainline xen, even
> when I directly trigger kexec with below commands.
>
> # kexec -l /boot/vmlinuz-5.17.0-rc4xen-00054-gf71077a4d84b-dirty \
>          --initrd=/boot/initrd.img-5.17.0-rc4xen-00054-gf71077a4d84b-dirty \
>          --reuse-cmdline
> # kexec -e
>
>
> Thank you very much!
>
> Dongli Zhang
>
>


From xen-devel-bounces@lists.xenproject.org Fri Feb 25 23:54:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 25 Feb 2022 23:54:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279647.477402 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNkPf-00072y-Px; Fri, 25 Feb 2022 23:54:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279647.477402; Fri, 25 Feb 2022 23:54:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNkPf-00072r-Ms; Fri, 25 Feb 2022 23:54:15 +0000
Received: by outflank-mailman (input) for mailman id 279647;
 Fri, 25 Feb 2022 23:54:14 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=FJge=TI=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1nNkPd-00072l-HR
 for xen-devel@lists.xenproject.org; Fri, 25 Feb 2022 23:54:14 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3969241e-9696-11ec-8539-5f4723681683;
 Sat, 26 Feb 2022 00:54:09 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id A5F88B82AB7;
 Fri, 25 Feb 2022 23:54:08 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id D1AC6C340E7;
 Fri, 25 Feb 2022 23:54:06 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3969241e-9696-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1645833247;
	bh=LsdljDN0ezEK9TN/mX8+BsCSFSOqkZ2noWMaMeOvTls=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=Yn6pC3XoUahEfUyu5Q42ovPdv18o3HlvuNbMAX3bIKLXlaquwpWT8jbgdnWallMfF
	 9KHGfSJKUDyix+X30DJFZd1sCXHGfQ+8tLBQJ9HFtnlJaqRDV7pBCFcO+wYcjwoPvz
	 d1+MMzigP2/I6AbNNZkpgM/syzvhTlTKbHOLZvv1h0kPkhr06HxfR/RGNbNQjQmoeZ
	 vJ0Ra0ZHC1YPbLHlktC9lTt2VxjFZezCDbLs75Sl4CcDY0cLGdJ3ztl6JkTZohD7Sb
	 LqsDWrxQnNFdCze8cpnjwYZZE7DpvjEzSnv4Q6u4uE0vqG4TJl4yV4272k3Okb1YL9
	 h1MPVIkzrpT6g==
Date: Fri, 25 Feb 2022 15:54:06 -0800 (PST)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Wei Chen <Wei.Chen@arm.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
    "julien@xen.org" <julien@xen.org>, 
    Bertrand Marquis <Bertrand.Marquis@arm.com>, 
    Penny Zheng <Penny.Zheng@arm.com>, Henry Wang <Henry.Wang@arm.com>, 
    nd <nd@arm.com>
Subject: RE: Proposal for Porting Xen to Armv8-R64 - DraftA
In-Reply-To: <AS1PR08MB74269923288B75097392BDD99E3E9@AS1PR08MB7426.eurprd08.prod.outlook.com>
Message-ID: <alpine.DEB.2.22.394.2202251214210.239973@ubuntu-linux-20-04-desktop>
References: <PAXPR08MB7420A01809B84E04E196793F9E3D9@PAXPR08MB7420.eurprd08.prod.outlook.com> <alpine.DEB.2.22.394.2202241606450.239973@ubuntu-linux-20-04-desktop> <AS1PR08MB74269923288B75097392BDD99E3E9@AS1PR08MB7426.eurprd08.prod.outlook.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-778875687-1645820194=:239973"
Content-ID: <alpine.DEB.2.22.394.2202251217240.239973@ubuntu-linux-20-04-desktop>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-778875687-1645820194=:239973
Content-Type: text/plain; CHARSET=UTF-8
Content-Transfer-Encoding: 8BIT
Content-ID: <alpine.DEB.2.22.394.2202251217241.239973@ubuntu-linux-20-04-desktop>

On Fri, 25 Feb 2022, Wei Chen wrote:
> > Hi Wei,
> >
> > This is extremely exciting, thanks for the very nice summary!
> >
> >
> > On Thu, 24 Feb 2022, Wei Chen wrote:
> > > # Proposal for Porting Xen to Armv8-R64
> > >
> > > This proposal will introduce the PoC work of porting Xen to Armv8-R64,
> > > which includes:
> > > - The changes of current Xen capability, like Xen build system, memory
> > >   management, domain management, vCPU context switch.
> > > - The expanded Xen capability, like static-allocation and direct-map.
> > >
> > > ***Notes:***
> > > 1. ***This proposal only covers the work of porting Xen to Armv8-R64***
> > >    ***single CPU. Xen SMP support on Armv8-R64 relates to Armv8-R***
> > >    ***Trusted-Frimware (TF-R). This is an external dependency,***
> > >    ***so we think the discussion of Xen SMP support on Armv8-R64***
> > >    ***should be started when single-CPU support is complete.***
> > > 2. ***This proposal will not touch xen-tools. In current stage,***
> > >    ***Xen on Armv8-R64 only support dom0less, all guests should***
> > >    ***be booted from device tree.***
> > >
> > > ## 1. Essential Background
> > >
> > > ### 1.1. Armv8-R64 Profile
> > > The Armv-R architecture profile was designed to support use cases that
> > > have a high sensitivity to deterministic execution. (e.g. Fuel Injection,
> > > Brake control, Drive trains, Motor control etc)
> > >
> > > Arm announced Armv8-R in 2013, it is the latest generation Arm
> > architecture
> > > targeted at the Real-time profile. It introduces virtualization at the
> > highest
> > > security level while retaining the Protected Memory System Architecture
> > (PMSA)
> > > based on a Memory Protection Unit (MPU). In 2020, Arm announced Cortex-
> > R82,
> > > which is the first Arm 64-bit Cortex-R processor based on Armv8-R64.
> > >
> > > - The latest Armv8-R64 document can be found here:
> > >   [Arm Architecture Reference Manual Supplement - Armv8, for Armv8-R
> > AArch64 architecture
> > profile](https://developer.arm.com/documentation/ddi0600/latest/).
> > >
> > > - Armv-R Architecture progression:
> > >   Armv7-R -> Armv8-R AArch32 -> Armv8 AArch64
> > >   The following figure is a simple comparison of "R" processors based on
> > >   different Armv-R Architectures.
> > >   ![image](https://drive.google.com/uc?export=view&id=1nE5RAXaX8zY2KPZ8i
> > mBpbvIr2eqBguEB)
> > >
> > > - The Armv8-R architecture evolved additional features on top of Armv7-R:
> > >     - An exception model that is compatible with the Armv8-A model
> > >     - Virtualization with support for guest operating systems
> > >         - PMSA virtualization using MPUs In EL2.
> > > - The new features of Armv8-R64 architecture
> > >     - Adds support for the 64-bit A64 instruction set, previously Armv8-
> > R
> > >       only supported A32.
> > >     - Supports up to 48-bit physical addressing, previously up to 32-bit
> > >       addressing was supported.
> > >     - Optional Arm Neon technology and Advanced SIMD
> > >     - Supports three Exception Levels (ELs)
> > >         - Secure EL2 - The Highest Privilege, MPU only, for firmware,
> > hypervisor
> > >         - Secure EL1 - RichOS (MMU) or RTOS (MPU)
> > >         - Secure EL0 - Application Workloads
> > >     - Optionally supports Virtual Memory System Architecture at S-EL1/S-
> > EL0.
> > >       This means it's possible to run rich OS kernels - like Linux -
> > either
> > >       bare-metal or as a guest.
> > > - Differences with the Armv8-A AArch64 architecture
> > >     - Supports only a single Security state - Secure. There is not Non-
> > Secure
> > >       execution state supported.
> > >     - EL3 is not supported, EL2 is mandatory. This means secure EL2 is
> > the
> > >       highest EL.
> > >     - Supports the A64 ISA instruction
> > >         - With a small set of well-defined differences
> > >     - Provides a PMSA (Protected Memory System Architecture) based
> > >       virtualization model.
> > >         - As opposed to Armv8-A AArch64's VMSA based Virtualization
> > >         - Can support address bits up to 52 if FEAT_LPA is enabled,
> > >           otherwise 48 bits.
> > >         - Determines the access permissions and memory attributes of
> > >           the target PA.
> > >         - Can implement PMSAv8-64 at EL1 and EL2
> > >             - Address translation flat-maps the VA to the PA for EL2
> > Stage 1.
> > >             - Address translation flat-maps the VA to the PA for EL1
> > Stage 1.
> > >             - Address translation flat-maps the IPA to the PA for EL1
> > Stage 2.
> > >     - PMSA in EL1 & EL2 is configurable, VMSA in EL1 is configurable.
> > >
> > > ### 1.2. Xen Challenges with PMSA Virtualization
> > > Xen is PMSA unaware Type-1 Hypervisor, it will need modifications to run
> > > with an MPU and host multiple guest OSes.
> > >
> > > - No MMU at EL2:
> > >     - No EL2 Stage 1 address translation
> > >         - Xen provides fixed ARM64 virtual memory layout as basis of EL2
> > >           stage 1 address translation, which is not applicable on MPU
> > system,
> > >           where there is no virtual addressing. As a result, any
> > operation
> > >           involving transition from PA to VA, like ioremap, needs
> > modification
> > >           on MPU system.
> > >     - Xen's run-time addresses are the same as the link time addresses.
> > >         - Enable PIC (position-independent code) on a real-time target
> > >           processor probably very rare.
> > >     - Xen will need to use the EL2 MPU memory region descriptors to
> > manage
> > >       access permissions and attributes for accesses made by VMs at
> > EL1/0.
> > >         - Xen currently relies on MMU EL1 stage 2 table to manage these
> > >           accesses.
> > > - No MMU Stage 2 translation at EL1:
> > >     - A guest doesn't have an independent guest physical address space
> > >     - A guest can not reuse the current Intermediate Physical Address
> > >       memory layout
> > >     - A guest uses physical addresses to access memory and devices
> > >     - The MPU at EL2 manages EL1 stage 2 access permissions and
> > attributes
> > > - There are a limited number of MPU protection regions at both EL2 and
> > EL1:
> > >     - Architecturally, the maximum number of protection regions is 256,
> > >       typical implementations have 32.
> > >     - By contrast, Xen does not need to consider the number of page
> > table
> > >       entries in theory when using MMU.
> > > - The MPU protection regions at EL2 need to be shared between the
> > hypervisor
> > >   and the guest stage 2.
> > >     - Requires careful consideration - may impact feature 'fullness' of
> > both
> > >       the hypervisor and the guest
> > >     - By contrast, when using MMU, Xen has standalone P2M table for
> > guest
> > >       stage 2 accesses.
> > >
> > > ## 2. Proposed changes of Xen
> > > ### **2.1. Changes of build system:**
> > >
> > > - ***Introduce new Kconfig options for Armv8-R64***:
> > >   Unlike Armv8-A, because lack of MMU support on Armv8-R64, we may not
> > >   expect one Xen binary to run on all machines. Xen images are not
> > common
> > >   across Armv8-R64 platforms. Xen must be re-built for different Armv8-
> > R64
> > >   platforms. Because these platforms may have different memory layout
> > and
> > >   link address.
> > >     - `ARM64_V8R`:
> > >       This option enables Armv8-R profile for Arm64. Enabling this
> > option
> > >       results in selecting MPU. This Kconfig option is used to gate some
> > >       Armv8-R64 specific code except MPU code, like some code for Armv8-
> > R64
> > >       only system ID registers access.
> > >
> > >     - `ARM_MPU`
> > >       This option enables MPU on ARMv8-R architecture. Enabling this
> > option
> > >       results in disabling MMU. This Kconfig option is used to gate some
> > >       ARM_MPU specific code. Once when this Kconfig option has been
> > enabled,
> > >       the MMU relate code will not be built for Armv8-R64. The reason
> > why
> > >       not depends on runtime detection to select MMU or MPU is that, we
> > don't
> > >       think we can use one image for both Armv8-R64 and Armv8-A64.
> > Another
> > >       reason that we separate MPU and V8R in provision to allow to
> > support MPU
> > >       on 32bit Arm one day.
> > >
> > >     - `XEN_START_ADDRESS`
> > >       This option allows to set the custom address at which Xen will be
> > >       linked. This address must be aligned to a page size. Xen's run-
> > time
> > >       addresses are the same as the link time addresses. Different
> > platforms
> > >       may have differnt memory layout. This Kconfig option provides
> > users
> > >       the ability to select proper link addresses for their boards.
> > >       ***Notes: Fixed link address means the Xen binary could not be***
> > >       ***relocated by EFI loader. So in current stage, Xen could not***
> > >       ***be launched as an EFI application on Armv8-R64.***
> > >
> > >     - `ARM_MPU_NORMAL_MEMORY_START` and `ARM_MPU_NORMAL_MEMORY_END`
> > >       `ARM_MPU_DEVICE_MEMORY_START` and `ARM_MPU_DEVICE_MEMORY_END`
> > >       These Kconfig options allow to set memory regions for Xen code,
> > data
> > >       and device memory. Before parsing memory information from device
> > tree,
> > >       Xen will use the values that stored in these options to setup
> > boot-time
> > >       MPU configuration. Why we need a boot-time MPU configuration?
> > >       1. More deterministic: Arm MPU supports background regions,
> > >          if we don't configure the MPU regions and don't enable MPU.
> > >          We can enable MPU background regions. But that means all RAM
> > >          is RWX. Random values in RAM or maliciously embedded data can
> > >          be exploited. Using these Kconfig options allow users to have
> > >          a deterministic RAM area to execute code.
> > >       2. More compatible: On some Armv8-R64 platforms, if the MPU is
> > >          disabled, the `dc zva` instruction will make the system halt.
> > >          And this instruction will be embedded in some built-in
> > functions,
> > >          like `memory set`. If we use `-ddont_use_dc` to rebuild GCC,
> > >          the built-in functions will not contain `dc zva`. However, it
> > is
> > >          obviously unlikely that we will be able to recompile all GCC
> > >          for ARMv8-R64.
> > >       3. One optional idea:
> > >           We can map `XEN_START_ADDRESS` to `XEN_START_ADDRESS + 2MB` or
> > >           `XEN_START_ADDRESS` to `XEN_START_ADDRESS + image_end` for
> > >           MPU normal memory. It's enough to support Xen run in boot time.
> >
> > I can imagine that we need to have a different Xen build for each
> > ARMv8-R platform. Do you envision that XEN_START_ADDRESS and
> > ARM_MPU_*_MEMORY_START/END are preconfigured based on the platform
> > choice at build time? I don't think we want a user to provide all of
> > those addresses by hand, right?
> 
> Yes, this is in our TODO list. We want to reuse current arm/platforms and
> Kconfig menu for Armv8-R.
 
OK, good


> > The next question is whether we could automatically generate
> > XEN_START_ADDRESS and ARM_MPU_*_MEMORY_START/END based on the platform
> > device tree at build time (at build time, not runtime). That would
> > make things a lot easier and it is also aligned with the way Zephyr and
> > other RTOSes and baremetal apps work.
> 
> It's a considerable option. But here we may encounter some problems need
> to be solved first:
> 1. Does CONFIG_DTB must be selected by default on Armv8-R? Without firmware
>    or bootloader (like u-boot), we have to build DTB into Xen binary.

CONFIG_DTB should trigger runtime support for device tree, while here we
are talking about build time support for device tree. It is very
different.

Just to make an example, the whole build-time device tree could be
scanned by Makefiles and other scripts, leading to C header files
generations, but no code in Xen to parse device tree at all.

DTB ---> Makefiles/scripts ---> .h files ---> Makefiles/scripts ---> xen


I am not saying this is the best way to do it, I am only pointing out
that build-time device tree does not imply run-time device tree. Also,
it doesn't imply a DTB built-in the Xen binary (although that is also an
option).

The way many baremetal OSes and RTOSes work is that they take a DTB as
input to the build *only*. From the DTB, the build-time make system
generates #defines and header files that are imported in C.

The resulting RTOS binary doesn't need support for DTB, because all the
right addresses have already been provided as #define by the Make
system.

I don't think we need to go to the extreme of removing DTB support from
Xen on ARMv8-R. I am only saying that if we add build-time device tree
support it would make it easier to support multiple boards without
having to have platform files in Xen for each of them, and we can do
that without any impact on runtime device tree parsing.


>    This
>    can guarantee build-time DTB is the same as runtime DTB. But eventually,
>    we will have firmware and bootloader before Xen launch (as Arm EBBR's
>    requirement). In this case, we may not build DTB into Xen image. And
>    we can't guarantee build-time DTB is the same as runtime DTB.

As mentioned, if we have a build-time DTB we might not need a run-time
DTB. Secondly, I think it is entirely reasonable to expect that the
build-time DTB and the run-time DTB are the same.

It is the same problem with platform files: we have to assume that the
information in the platform files matches the runtime DTB.


> 2. If build-time DTB is the same as runtime DTB, how can we determine
>    the XEN_START_ADDRESS in DTB describe memory range? Should we always
>    limit Xen to boot from lowest address? Or will we introduce some new
>    DT property to specify the Xen start address? I think this DT property
>    also can solve above question#1.
 
The loading address should be automatically chosen by the build scripts.
We can do that now with ImageBuilder [1]: it selects a 2MB-aligned
address for each binary to load, one by one starting from a 2MB offset
from start of memory.

[1] https://gitlab.com/ViryaOS/imagebuilder/-/blob/master/scripts/uboot-script-gen#L390

So the build scripts can select XEN_START_ADDRESS based on the
memory node information on the build-time device tree. And there should
be no need to add XEN_START_ADDRESS to the runtime device tree.


> > The device tree can be given as input to the build system, and the
> > Makefiles would take care of generating XEN_START_ADDRESS and
> > ARM_MPU_*_MEMORY_START/END based on /memory and other interesting nodes.
> >
> 
> If we can solve above questions, yes, device tree is a good idea for
> XEN_START_ADDRESS. For ARM_MPU_NORMAL_MEMORY_*, we can get them from
> memory nodes, but for ARM_MPU_DEVICE_MEMORY_*, they are not easy for
> us to scan all devices' nodes. And it's very tricky, if the memory
> regions are interleaved. So in our current RFC code, we select to use
> the optional idea:
> We map `XEN_START_ADDRESS` to `XEN_START_ADDRESS + 2MB` for MPU normal memory.
> But we use mpu,device-memory-section in DT for MPU device memory.

Keep in mind that we are talking about build-time scripts: it doesn't
matter if they are slow. We can scan the build-time dtb as many time as
needed and generate ARM_MPU_DEVICE_MEMORY_* as appropriate. It might
make "make xen" slower but runtime will be unaffected.

So, I don't think this is a problem.


> > > - ***Define new system registers for compilers***:
> > >   Armv8-R64 is based on Armv8.4. That means we will use some Armv8.4
> > >   specific system registers. As Armv8-R64 only have secure state, so
> > >   at least, `VSTCR_EL2` and `VSCTLR_EL2` will be used for Xen. And the
> > >   first GCC version that supports Armv8.4 is GCC 8.1. In addition to
> > >   these, PMSA of Armv8-R64 introduced lots of MPU related system
> > registers:
> > >   `PRBAR_ELx`, `PRBARx_ELx`, `PRLAR_ELx`, `PRLARx_ELx`, `PRENR_ELx` and
> > >   `MPUIR_ELx`. But the first GCC version to support these system
> > registers
> > >   is GCC 11. So we have two ways to make compilers to work properly with
> > >   these system registers.
> > >   1. Bump GCC version to GCC 11.
> > >      The pros of this method is that, we don't need to encode these
> > >      system registers in macros by ourselves. But the cons are that,
> > >      we have to update Makefiles to support GCC 11 for Armv8-R64.
> > >      1.1. Check the GCC version 11 for Armv8-R64.
> > >      1.2. Add march=armv8r to CFLAGS for Armv8-R64.
> > >      1.3. Solve the confliction of march=armv8r and mcpu=generic
> > >     These changes will affect common Makefiles, not only Arm Makefiles.
> > >     And GCC 11 is new, lots of toolchains and Distro haven't supported
> > it.
> > >
> > >   2. Encode new system registers in macros ***(preferred)***
> > >         ```
> > >         /* Virtualization Secure Translation Control Register */
> > >         #define VSTCR_EL2  S3_4_C2_C6_2
> > >         /* Virtualization System Control Register */
> > >         #define VSCTLR_EL2 S3_4_C2_C0_0
> > >         /* EL1 MPU Protection Region Base Address Register encode */
> > >         #define PRBAR_EL1  S3_0_C6_C8_0
> > >         ...
> > >         /* EL2 MPU Protection Region Base Address Register encode */
> > >         #define PRBAR_EL2  S3_4_C6_C8_0
> > >         ...
> > >         ```
> > >      If we encode all above system registers, we don't need to bump GCC
> > >      version. And the common CFLAGS Xen is using still can be applied to
> > >      Armv8-R64. We don't need to modify Makefiles to add specific CFLAGS.
> >
> > I think that's fine and we did something similar with the original ARMv7-A
> > port if I remember correctly.
> >
> >
> > > ### **2.2. Changes of the initialization process**
> > > In general, we still expect Armv8-R64 and Armv8-A64 to have a consistent
> > > initialization process. In addition to some architecture differences,
> > there
> > > is no more than reusable code that we will distinguish through
> > CONFIG_ARM_MPU
> > > or CONFIG_ARM64_V8R. We want most of the initialization code to be
> > reusable
> > > between Armv8-R64 and Armv8-A64.
> >
> > +1
> >
> >
> > > - We will reuse the original head.s and setup.c of Arm. But replace the
> > >   MMU and page table operations in these files with configuration
> > operations
> > >   for MPU and MPU regions.
> > >
> > > - We provide a boot-time MPU configuration. This MPU configuration will
> > >   support Xen to finish its initialization. And this boot-time MPU
> > >   configuration will record the memory regions that will be parsed from
> > >   device tree.
> > >
> > >   In the end of Xen initialization, we will use a runtime MPU
> > configuration
> > >   to replace boot-time MPU configuration. The runtime MPU configuration
> > will
> > >   merge and reorder memory regions to save more MPU regions for guests.
> > >   ![img](https://drive.google.com/uc?export=view&id=1wTFyK2XfU3lTlH1PqRD
> > oacQVTwUtWIGU)
> > >
> > > - Defer system unpausing domain.
> > >   When Xen initialization is about to end, Xen unpause guests created
> > >   during initialization. But this will cause some issues. The unpause
> > >   action occurs before free_init_memory, however the runtime MPU
> > configuration
> > >   is built after free_init_memory.
> > >
> > >   So if the unpaused guests start executing the context switch at this
> > >   point, then its MPU context will base on the boot-time MPU
> > configuration.
> > >   Probably it will be inconsistent with runtime MPU configuration, this
> > >   will cause unexpected problems (This may not happen in a single core
> > >   system, but on SMP systems, this problem is foreseeable, so we hope to
> > >   solve it at the beginning).
> > >
> > > ### **2.3. Changes to reduce memory fragmentation**
> > >
> > > In general, memory in Xen system can be classified to 4 classes:
> > > `image sections`, `heap sections`, `guest RAM`, `boot modules (guest
> > Kernel,
> > > initrd and dtb)`
> > >
> > > Currently, Xen doesn't have any restriction for users how to allocate
> > > memory for different classes. That means users can place boot modules
> > > anywhere, can reserve Xen heap memory anywhere and can allocate guest
> > > memory anywhere.
> > >
> > > In a VMSA system, this would not be too much of a problem, since the
> > > MMU can manage memory at a granularity of 4KB after all. But in a
> > > PMSA system, this will be a big problem. On Armv8-R64, the max MPU
> > > protection regions number has been limited to 256. But in typical
> > > processor implementations, few processors will design more than 32
> > > MPU protection regions. Add in the fact that Xen shares MPU protection
> > > regions with guest's EL1 Stage 2. It becomes even more important
> > > to properly plan the use of MPU protection regions.
> > >
> > > - An ideal of memory usage layout restriction:
> > > ![img](https://drive.google.com/uc?export=view&id=1kirOL0Tx2aAypTtd3kXAt
> > d75XtrngcnW)
> > > 1. Reserve proper MPU regions for Xen image (code, rodata and data +
> > bss).
> > > 2. Reserve one MPU region for boot modules.
> > >    That means the placement of all boot modules, include guest kernel,
> > >    initrd and dtb, will be limited to this MPU region protected area.
> > > 3. Reserve one or more MPU regions for Xen heap.
> > >    On Armv8-R64, the guest memory is predefined in device tree, it will
> > >    not be allocated from heap. Unlike Armv8-A64, we will not move all
> > >    free memory to heap. We want Xen heap is dertermistic too, so Xen on
> > >    Armv8-R64 also rely on Xen static heap feature. The memory for Xen
> > >    heap will be defined in tree too. Considering that physical memory
> > >    can also be discontinuous, one or more MPU protection regions needs
> > >    to be reserved for Xen HEAP.
> > > 4. If we name above used MPU protection regions PART_A, and name left
> > >    MPU protection regions PART_B:
> > >    4.1. In hypervisor context, Xen will map left RAM and devices to
> > PART_B.
> > >         This will give Xen the ability to access whole memory.
> > >    4.2. In guest context, Xen will create EL1 stage 2 mapping in PART_B.
> > >         In this case, Xen just need to update PART_B in context switch,
> > >         but keep PART_A as fixed.
> >
> > I think that the memory layout and restrictions that you wrote above
> > make sense. I have some comments on the way they are represented in
> > device tree, but that's different.
> >
> >
> > > ***Notes: Static allocation will be mandatory on MPU based systems***
> > >
> > > **A sample device tree of memory layout restriction**:
> > > ```
> > > chosen {
> > >     ...
> > >     /*
> > >      * Define a section to place boot modules,
> > >      * all boot modules must be placed in this section.
> > >      */
> > >     mpu,boot-module-section = <0x10000000 0x10000000>;
> > >     /*
> > >      * Define a section to cover all guest RAM. All guest RAM must be
> > located
> > >      * within this section. The pros is that, in best case, we can only
> > have
> > >      * one MPU protection region to map all guest RAM for Xen.
> > >      */
> > >     mpu,guest-memory-section = <0x20000000 0x30000000>;
> > >     /*
> > >      * Define a memory section that can cover all device memory that
> > >      * will be used in Xen.
> > >      */
> > >     mpu,device-memory-section = <0x80000000 0x7ffff000>;
> > >     /* Define a section for Xen heap */
> > >     xen,static-mem = <0x50000000 0x20000000>;
> >
> > As mentioned above, I understand the need for these sections, but why do
> > we need to describe them in device tree at all? Could Xen select them by
> > itself during boot?
> 
> I think without some inputs, Xen could not do this or will do it in some
> assumption. For example, assume the first the boot-module-section determined
> by lowest address and highest address of all modules. And the same for
> guest-memory-section, calculated from all guest allocated memory regions.

Right, I think that the mpu,boot-module-section should be generated by a
set of scripts like ImageBuilder. Something with a list of all the
binaries that need to be loaded and also the DTB at build-time.
Something like ImageBuilder would have the ability to add
"mpu,boot-module-section" to device tree automatically and automatically
choose a good address for it.
 
As an example, today ImageBuilder takes as input a config file like the
following:

---
MEMORY_START="0x0"
MEMORY_END="0x80000000"

DEVICE_TREE="4.16-2022.1/mpsoc.dtb"
XEN="4.16-2022.1/xen"
DOM0_KERNEL="4.16-2022.1/Image-dom0-5.16"
DOM0_RAMDISK="4.16-2022.1/xen-rootfs.cpio.gz"

NUM_DOMUS=1
DOMU_KERNEL[0]="4.16-2022.1/Image-domU"
DOMU_RAMDISK[0]="4.16-2022.1/initrd.cpio"
DOMU_PASSTHROUGH_DTB[0]="4.16-2022.1/passthrough-example-sram.dtb"
---

And generates a U-Boot boot.scr script with:
- load addresses for each binary
- commands to edit the DTB to add those addresses to device tree (e.g.
  dom0less kernels addresses)

ImageBuilder can also modify the DTB at build time instead (instead of
doing it from boot.scr.) See FDTEDIT.

I am not saying we should use ImageBuilder, but it sounds like we need
something similar.


> > If not, and considering that we have to generate
> > ARM_MPU_*_MEMORY_START/END anyway at build time, would it make sense to
> > also generate mpu,guest-memory-section, xen,static-mem, etc. at build
> > time rather than passing it via device tree to Xen at runtime?
> >
> 
> Did you mean we still add these information in device tree, but for build
> time only. In runtime we don't parse them?

Yes, something like that, but see below.


> > What's the value of doing ARM_MPU_*_MEMORY_START/END at build time and
> > everything else at runtime?
> 
> ARM_MPU_*_MEMORY_START/END is defined by platform. But other things are
> users customized. They can change their usage without rebuild the image.
 
Good point.

We don't want to have to rebuild Xen if the user updated a guest kernel,
resulting in a larger boot-module-section.

So I think it makes sense that "mpu,boot-module-section" is generated by
the scripts (e.g. ImageBuilder) at build time, and Xen reads the
property at boot from the runtime device tree.

I think we need to divide the information into two groups:


# Group1: board info

This information is platform specific and it is not meant to change
depending on the VM configuration. Ideally, we build Xen for a platform
once, then we can use the same Xen binary together with any combination
of dom0/domU kernels and ramdisks.

This kind of information doesn't need to be exposed to the runtime
device tree. But we can still use a build-time device tree to generate
the addresses if it is convenient.

XEN_START_ADDRESS, ARM_MPU_DEVICE_MEMORY_*, and ARM_MPU_NORMAL_MEMORY_*
seem to be part of this group.


# Group2: boot configuration

This information is about the specific set of binaries and VMs that we
need to boot. It is conceptually similar to the dom0less device tree
nodes that we already have. If we change one of the VM binaries, we
likely have to refresh the information here.

"mpu,boot-module-section" probably belongs to this group (unless we find
a way to define "mpu,boot-module-section" generically so that we don't
need to change it any time the set of boot modules change.)


> > It looks like we are forced to have the sections definitions at build
> > time because we need them before we can parse device tree. In that case,
> > we might as well define all the sections at build time.
> >
> > But I think it would be even better if Xen could automatically choose
> > xen,static-mem, mpu,guest-memory-section, etc. on its own based on the
> > regular device tree information (/memory, /amba, etc.), without any need
> > for explicitly describing each range with these new properties.
> >
> 
> for mpu,guest-memory-section, with the limitations: no other usage between
> different guest' memory nodes, this is OK. But for xen,static-mem (heap),
> we just want everything on a MPU system is dertermistic. But, of course Xen
> can select left memory for heap without static-mem.

It is good that you think they can be chosen by Xen.

Differently from "boot-module-section", which has to do with the boot
modules selected by the user for a specific execution,
guest-memory-section and static-mem are Xen specific memory
policies/allocations.

A user wouldn't know how to fill them in. And I worry that even a script
like ImageBuilder wouldn't be the best place to pick these values --
they seem too "important" to leave to a script.

But it seems possible to choose the values in Xen:
- Xen knows ARM_MPU_NORMAL_MEMORY_* because it was defined at build time
- Xen reads boot-module-section from device tree

It should be possible at this point for Xen to pick the best values for
guest-memory-section and static-mem based on the memory available.


> > >     domU1 {
> > >         ...
> > >         #xen,static-mem-address-cells = <0x01>;
> > >         #xen,static-mem-size-cells = <0x01>;
> > >         /* Statically allocated guest memory, within mpu,guest-memory-
> > section */
> > >         xen,static-mem = <0x30000000 0x1f000000>;
> > >
> > >         module@11000000 {
> > >             compatible = "multiboot,kernel\0multiboot,module";
> > >             /* Boot module address, within mpu,boot-module-section */
> > >             reg = <0x11000000 0x3000000>;
> > >             ...
> > >         };
> > >
> > >         module@10FF0000 {
> > >                 compatible = "multiboot,device-tree\0multiboot,module";
> > >                 /* Boot module address, within mpu,boot-module-section
> > */
> > >                 reg = <0x10ff0000 0x10000>;
> > >                 ...
> > >         };
> > >     };
> > > };
> > > ```
--8323329-778875687-1645820194=:239973--


From xen-devel-bounces@lists.xenproject.org Sat Feb 26 01:18:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 26 Feb 2022 01:18:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279660.477413 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNliw-00018i-RS; Sat, 26 Feb 2022 01:18:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279660.477413; Sat, 26 Feb 2022 01:18:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNliw-00018b-NN; Sat, 26 Feb 2022 01:18:14 +0000
Received: by outflank-mailman (input) for mailman id 279660;
 Sat, 26 Feb 2022 01:18:13 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Gd1R=TJ=oracle.com=dongli.zhang@srs-se1.protection.inumbo.net>)
 id 1nNliu-00018V-Uc
 for xen-devel@lists.xenproject.org; Sat, 26 Feb 2022 01:18:13 +0000
Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com
 [205.220.165.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f5105c85-96a1-11ec-8eb9-a37418f5ba1a;
 Sat, 26 Feb 2022 02:18:10 +0100 (CET)
Received: from pps.filterd (m0246629.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 21PMoCJA017475; 
 Sat, 26 Feb 2022 01:17:45 GMT
Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71])
 by mx0b-00069f02.pphosted.com with ESMTP id 3eexa8td7e-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Sat, 26 Feb 2022 01:17:44 +0000
Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1])
 by aserp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 21Q1H3Ei059710;
 Sat, 26 Feb 2022 01:17:44 GMT
Received: from nam04-bn8-obe.outbound.protection.outlook.com
 (mail-bn8nam08lp2043.outbound.protection.outlook.com [104.47.74.43])
 by aserp3030.oracle.com with ESMTP id 3efa8a8dra-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Sat, 26 Feb 2022 01:17:43 +0000
Received: from BYAPR10MB2663.namprd10.prod.outlook.com (2603:10b6:a02:a9::20)
 by BLAPR10MB4994.namprd10.prod.outlook.com (2603:10b6:208:30d::7)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Sat, 26 Feb
 2022 01:17:41 +0000
Received: from BYAPR10MB2663.namprd10.prod.outlook.com
 ([fe80::a0d5:610d:bcf:9b47]) by BYAPR10MB2663.namprd10.prod.outlook.com
 ([fe80::a0d5:610d:bcf:9b47%4]) with mapi id 15.20.5017.025; Sat, 26 Feb 2022
 01:17:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f5105c85-96a1-11ec-8eb9-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc :
 references : from : message-id : date : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2021-07-09;
 bh=RhEiP+/Ax28z9eZZ/auAHLTVRUyLy3kmKT/2fDdzMDQ=;
 b=CXN2CIFls9Mn65PXGueGTjBoC9sRmuOEDKIv8ds4HQdqWTEoZvoU/X3oRfGTcD4Q/ky5
 CVQyk1/G0zfZCE23YHLlac2z2Iv81yxx806fzaQn700+XBsQlZnxECQj9sYva5EbGR04
 l5/pS5hzwUrOwPHp/L+4XNxukUyrAx2T2Upr8fULaySNtpG/bs7Zx9citeqdWDOihFO6
 ecKQ4qJSasxGKNghVIyASWUUK4ylYVPdJR+AGsXu36pzj5NACYYFGyjat05G+6KKQNFg
 WfYUnBY23GZxTaq4L54/BMNrll1qzyAOHo1iNVIiNBqHwklk6OHAMOBJw6mf5ScdaEmp AQ== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=dcfZGPma64bbSGUfeJDod6NxIvFWiCQufrLc78Dq4u6+p0A2g+Dwr1iDPpKlXGgRdzmlc6RYaTBGXpT3nZGKsrWKnNa1/eZGlMPrlvMP2o42XK9vCThielhAPILi5x1Zvvx4KGndH9tZxB/VTLZhzVdWaCKSUPOiVZZl+L236+7bidQV4nLDSg0HvDuCSsdTiFyUMnp4FI5OeFuXn+kh+emutJ/4djEmUCUru/WsJSVZx9Skl1d0fd5FZYqEH9TfebBdSRGHMI9Nw+d5K6cOEEDfy1NkZbDdGFkxhxOQ+MrH132CMuoG+4OQF9kLPCjonN/q+RfSgsKmtJ6koETLeQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=RhEiP+/Ax28z9eZZ/auAHLTVRUyLy3kmKT/2fDdzMDQ=;
 b=an2sERoeq5TUkECbBmT97dLW3DHobz3Qx/q8uRQR05UaNiIwgZaZM2EXpJiPRRBIxOWZ2GLrujkwwmYm+hXPDvGfGKw7RHB8WQCY4c+GX/0dtsC0wBDisMCfr9n/xSxpPy7db5Lg5bvXMJmD9/ttK9M7ov/bfdZKa891pQx3P4qG1g5G30+oTlkTybhps1IJyLwByzogz3gU6DjgvSdzwX6BeyMQNVsPIuNJ0ul9h2PnqXAvqi9rx+VsKHKF/YBvyXjhzJheZv4cqORaxah7rTBXJvsuE+cOtBGKs0hy12aYdVmAsCRDH4X4DIw5aAYOWteeFfUou444y/9a9AvMMQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=RhEiP+/Ax28z9eZZ/auAHLTVRUyLy3kmKT/2fDdzMDQ=;
 b=nwjes+WOpWZGLimQvaAbgM5zgYcZKyzZX+Gr7DpY1dsIO8OweXzknoJjfvzYrvErGj5Y7V3NBOkjX2Zmjxxii2QXLblXJ3IYV+QdLLyORjlu53enzsI31Kle9lK6Z6UCf8H3dG6SEibHDiL7UKgXJu6dCfCpRwnvfVpdQS4kb6E=
Subject: Re: [PATCH v3 0/1] xen: fix HVM kexec kernel panic
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        xen-devel@lists.xenproject.org, x86@kernel.org
Cc: linux-kernel@vger.kernel.org, jgross@suse.com, sstabellini@kernel.org,
        tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
        dave.hansen@linux.intel.com, hpa@zytor.com, joe.jin@oracle.com
References: <20220224215049.2845-1-dongli.zhang@oracle.com>
 <9de1059b-6b48-e2c8-60bc-f29b42b217f7@oracle.com>
From: Dongli Zhang <dongli.zhang@oracle.com>
Message-ID: <36014dbd-e63c-cf49-dafd-2d7a8b84db5d@oracle.com>
Date: Fri, 25 Feb 2022 17:17:41 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.1
In-Reply-To: <9de1059b-6b48-e2c8-60bc-f29b42b217f7@oracle.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: SN4PR0201CA0002.namprd02.prod.outlook.com
 (2603:10b6:803:2b::12) To BYAPR10MB2663.namprd10.prod.outlook.com
 (2603:10b6:a02:a9::20)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 6472d60f-0872-40bf-9cf4-08d9f8c5c8c3
X-MS-TrafficTypeDiagnostic: BLAPR10MB4994:EE_
X-Microsoft-Antispam-PRVS: 
	<BLAPR10MB49942B359DE5F6F7439EFED9F03F9@BLAPR10MB4994.namprd10.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	HV4UygS7YV1SYqxLCXefJw27fmQoA9ajV7vSkTj74nK7J+87cwaek6R2bg1G9n9hy1HhiBcRwppCBmBGrYYkOqkdv4/Sw7IHaq/eNHD0705dKVC9hk2FxAJfawrepdYhn4MYNO4PkOoFqGy4LssLlFsnukGAn30VqAkepievhr2x4Bcy6nSoSWQsA9yslmEjn6lBPyqeaVVyRFwB+qDp7/ZkwbDkwTcd2w4/IFIdOL5cadmdF528Ceh2m69tD3wa2QAtNfSiP9lEwLVBp13Evc60fmK/ChNNmobQ7WOTFzCSOaT4frVP9A/+t5jMyE77nQ1SeLlZXBerCoi9z3qVKqwhr9G0AvIEdYBYodmfFAESkFoPh0eN4ABwq0K6Kg0jOCgJMnSK4dbFcfca33eLVTL6nLD0W+wbncUFQ56iB8+SC+ALqOYE48oESpJ5+BufbUqayOsAoqDbWz4FN8vrFR4Eh4/tVr8RmLYvbtmuJh5hqBcAKFV3ztECGC11ymK3+P0Aj263flvBs6NJ7qr/Yv/NHQn/Gpdsa6qI+ZUO3PBSnjrTsN2vugUC6fzh1QVoA7tfcab6rgJJu8Yg72y7D5sZ/j1thPvY23sClRKwxyzZujV9QIcbWgSv1gOZKgCZIkdtNNPxupBeqqSV2lbzlcI7m2lsSPC39kPjWbtEcl3BLPT3AosWkYhPSyIjJDKi8P2j+LDGnNDAHZUhJsd4fAaFcavNWcNiHtDECSeDHxg=
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB2663.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(53546011)(36756003)(2616005)(107886003)(6506007)(6512007)(186003)(8676002)(4326008)(38100700002)(5660300002)(44832011)(7416002)(8936002)(2906002)(6486002)(31696002)(86362001)(508600001)(66476007)(66556008)(66946007)(316002)(83380400001)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?MERKSGJJVy9VdFVpaERtM3ZOOHJWNjNHR0hJRnR2aUN6dDgwaEVtcGdRZnZM?=
 =?utf-8?B?V2hZNUMyYVRjeW1Vb002ZTljSWEwZjAzR25SNWdUS3o0cjgzck1EZWJFOGYy?=
 =?utf-8?B?UjNxWWlVTjFhNE9kSjJzeWgzYnlSMUgrQ0pFMkpBU1p6RHFPVTFaTUpTUzN1?=
 =?utf-8?B?aEVMTDMvVURHWmtJbC8ralE1VkF2ajZrcUh4d0dES21oNzJyZ0RIS1duTGFs?=
 =?utf-8?B?VmNBVnFvK0gwTENhVUxjUTZ6WVFqdGdXQlF1VjM2QVF1eTVTMmpaczRmeHVi?=
 =?utf-8?B?VEpoYVVQSFhyR0ZGZ0xKSzgyUDRQSkx6bm8xMzhOR016NEkyMFJJalM1bmVm?=
 =?utf-8?B?S0sxa3VMa2dCU2Q3YWkvalc3SU5hQnVlMk5QRDRhVGVMQ0ZJQS9odjB6TEhr?=
 =?utf-8?B?bTNURzFwWGc5N0Era1p5eW9obFlTRHlZSERUWHdxWlpCUDdxb3RUME45UEI1?=
 =?utf-8?B?dFZDWXcrclVLTUl1NU5oN0MwVXhMZjR6TklVTGR4RG9Ta1E4Ykx6RGN4ZGNa?=
 =?utf-8?B?ek55Q29TZ3QvRXJ2RE5VV3kxazc4YmcxR3NEMVlFWTY5Q1d3eGtoQnFTbUJ2?=
 =?utf-8?B?RjJSbU50Y0QzeFdwN2J0OE5ta3FEa2Z2a2QrWWI2R0hwQml4VW1OVGE3aUpN?=
 =?utf-8?B?cC9xTjg3K2FPVC9UdDgxa0NHRFZSTDRxT0xLbE0rb0F1cjJab1Y5R2EzUits?=
 =?utf-8?B?ZXdiNWxWN3V1bWN0NUxmTDdTUE9QdldKQ2MzRDlLaXNzMWl3eGdVTXE4WGpU?=
 =?utf-8?B?bWFFeHpEdjQyZnVidHhZeDZpa0RNV3k1SXZMd3pZOC9IcEtyRGw3ZU1tUGNG?=
 =?utf-8?B?c09BMktPVXpyaC9tWlJxRzI2di9TUGlFazRnVUhERExDN0l5QmlXTVJHSUh3?=
 =?utf-8?B?U1R1OUdiWjd0T1FWMmdObWZ5bnp2L2pmcVRzMVpRWTE4WXZoWnU1U3lkNVcz?=
 =?utf-8?B?NWlBOEtjbHdVYVpmN09VQTJGdnl3QUx4YTNvYzBNMUx6NG1IdHZ4NUtJTlpl?=
 =?utf-8?B?c09NcWJFbXVGaXlpK3I2QlZ2bi9vQlZ5eDlVUUVhV3Z5ZnVMTS9jYnpMY0dt?=
 =?utf-8?B?ajBjWlUvNGQ5L2RSWE1McG5RczdDbG1xWmhiRjRSS3BEdHpoK1MyVTQ4bmJM?=
 =?utf-8?B?L3dMK21sQjgxOTdlNEJma28yWE5qSFlieEZNdWF4eHQ5QU1QN1dWcUhBWjYv?=
 =?utf-8?B?UDR1Mk84VFhKWlp2eUZITnQycGFpY2xnRlRqb2QyUDZaUDFibjhXR2dUbmhP?=
 =?utf-8?B?R0lkT0cwRXBiYlN2VGxzWmIzdFQyK2JUNjJWQ1NSYkZEdEI3bGRMTFlHbTNI?=
 =?utf-8?B?c240ZmhiMmhCSkhFUVFFRkhMQ25QRm5QbGMwTU9FN0NFTlNiNnNCNkpZY3Bm?=
 =?utf-8?B?NVZPOWErN2tDMGFsWVNzNkkzN1BmWFVydENkQ2F4UzFOcmNpaWhHbHVnbDNw?=
 =?utf-8?B?amNtb2I1UzRxcTdLZW95dGxVWFBzTG1mVWFxV0MxOStCL3IxWnRxb1dKWXhN?=
 =?utf-8?B?c0wvbHJNaXkxTEpXWU4vcDR1MGxRazBTeUZsQ09hN0Zwak5tK3NTTDgzNHlT?=
 =?utf-8?B?RFRkSm9MVXBFWHdhUm1tZGl6Wlc5VG1MM0JoenpwNXBCZkgvbGFtZWJUYkRV?=
 =?utf-8?B?aGQzaHJxN09uWC9YckxlTjhWSmg2UmdvWmdtdHV6b0h4bUlFNG9kRDVpcVEv?=
 =?utf-8?B?QXFmVTMxRnV3Yk54amlBRmp1NXM4TWFLb21YR1pkMVp2OGFQUUNIWHRWUTZl?=
 =?utf-8?B?WXJ1cFlQNXBXS1Y5eXM0MVp5T3pUSGtOMm8zd1M3ZDFGYVZNajVPUi9VMkkv?=
 =?utf-8?B?RFFrOXduVUhNTGRwVjE3UC9CdVFmdkhHSTJ4Rk9Ub0xVSHcrbU1zeDJjQkp2?=
 =?utf-8?B?MFRsa0prdXl0eitnb2ZHMmliclJQL24wUkg0UVA3bzY2KzZjMmFOaHhaNjJ4?=
 =?utf-8?B?dis4K2x4emd0dGhoZDREeTQxei9PbGlaUlpyaFdTYkV0UlhoSGRuSkxrNjE0?=
 =?utf-8?B?TWJDV0RHNENGc0RIZnl3bTRtT24wTSt2Y25meVVwTzZERnZLRlVFaVVHRU9F?=
 =?utf-8?B?c3RVWU9HQmY2TFRGZ3VXcHlnTTdTZVBBM2ZEKzJHYkgvSlhGY3hvQWpXK0Jz?=
 =?utf-8?B?MG5Wd3hhaU1YV0ZxWEhHdmlLZ2ZlVmt2dDNMZG1YY0RYYkFTOVNCbmU5YVpG?=
 =?utf-8?Q?pEG6V9U1hNzauE4d6qviYC4CROS4siRtnLJT2h7hcgIA?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6472d60f-0872-40bf-9cf4-08d9f8c5c8c3
X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2663.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2022 01:17:41.5769
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qsjV00Ru4beszjnmAgas+Oi6RmDnDuIMVkoP7z3SHMiLcwRlBkQ/t3j6GTu/No6yJeoh05Mb4JZ4Ybye/ppNXQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB4994
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10269 signatures=684655
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 bulkscore=0 phishscore=0
 malwarescore=0 mlxscore=0 suspectscore=0 spamscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2202260008
X-Proofpoint-GUID: jQBbHsh6YXPabCjHkWNcA1QZQrgYC3m4
X-Proofpoint-ORIG-GUID: jQBbHsh6YXPabCjHkWNcA1QZQrgYC3m4

Hi Boris,

On 2/25/22 2:39 PM, Boris Ostrovsky wrote:
> 
> On 2/24/22 4:50 PM, Dongli Zhang wrote:
>> This is the v3 of the patch to fix xen kexec kernel panic issue when the
>> kexec is triggered on VCPU >= 32.
>>
>> PANIC: early exception 0x0e IP 10:ffffffffa96679b6 error 0 cr2 0x20
>> [    0.000000] CPU: 0 PID: 0 Comm: swapper Not tainted
>> 5.17.0-rc4xen-00054-gf71077a4d84b-dirty #1
>> [    0.000000] Hardware name: Xen HVM domU, BIOS 4.4.4OVM 12/15/2020
>> [    0.000000] RIP: 0010:pvclock_clocksource_read+0x6/0xb0
>> ... ...
>> [    0.000000] RSP: 0000:ffffffffaae03e10 EFLAGS: 00010082 ORIG_RAX:
>> 0000000000000000
>> [    0.000000] RAX: 0000000000000000 RBX: 0000000000010000 RCX: 0000000000000002
>> [    0.000000] RDX: 0000000000000003 RSI: ffffffffaac37515 RDI: 0000000000000020
>> [    0.000000] RBP: 0000000000011000 R08: 0000000000000000 R09: 0000000000000001
>> [    0.000000] R10: ffffffffaae03df8 R11: ffffffffaae03c68 R12: 0000000040000004
>> [    0.000000] R13: ffffffffaae03e50 R14: 0000000000000000 R15: 0000000000000000
>> [    0.000000] FS:  0000000000000000(0000) GS:ffffffffab588000(0000)
>> knlGS:0000000000000000
>> [    0.000000] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
>> [    0.000000] CR2: 0000000000000020 CR3: 00000000ea410000 CR4: 00000000000406a0
>> [    0.000000] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
>> [    0.000000] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
>> [    0.000000] Call Trace:
>> [    0.000000]  <TASK>
>> [    0.000000]  ? xen_clocksource_read+0x24/0x40
> 
> 
> This is done to set xen_sched_clock_offset which I think will not be used for a
> while, until sched_clock is called (and the other two uses are for suspend/resume)
> 
> 
> Can we simply defer 'xen_sched_clock_offset = xen_clocksource_read();' until
> after all vcpu areas are properly set? Or are there other uses of
> xen_clocksource_read() before ?
> 

I have tested that below patch will panic kdump kernel.

diff --git a/arch/x86/xen/smp_hvm.c b/arch/x86/xen/smp_hvm.c
index 6ff3c887e0b9..6a0c99941ae1 100644
--- a/arch/x86/xen/smp_hvm.c
+++ b/arch/x86/xen/smp_hvm.c
@@ -19,6 +19,8 @@ static void __init xen_hvm_smp_prepare_boot_cpu(void)
         */
        xen_vcpu_setup(0);

+       xen_init_sched_clock_offset();
+
        /*
         * The alternative logic (which patches the unlock/lock) runs before
         * the smp bootup up code is activated. Hence we need to set this up
diff --git a/arch/x86/xen/time.c b/arch/x86/xen/time.c
index d9c945ee1100..8a2eafa0c215 100644
--- a/arch/x86/xen/time.c
+++ b/arch/x86/xen/time.c
@@ -520,9 +520,14 @@ static void __init xen_time_init(void)
                pvclock_gtod_register_notifier(&xen_pvclock_gtod_notifier);
 }

-static void __init xen_init_time_common(void)
+void xen_init_sched_clock_offset(void)
 {
        xen_sched_clock_offset = xen_clocksource_read();
+}
+
+static void __init xen_init_time_common(void)
+{
+       xen_sched_clock_offset = 0;
        static_call_update(pv_steal_clock, xen_steal_clock);
        paravirt_set_sched_clock(xen_sched_clock);

diff --git a/arch/x86/xen/xen-ops.h b/arch/x86/xen/xen-ops.h
index fd0fec6e92f4..9f7656214dfb 100644
--- a/arch/x86/xen/xen-ops.h
+++ b/arch/x86/xen/xen-ops.h
@@ -69,6 +69,7 @@ void xen_teardown_timer(int cpu);
 void xen_setup_cpu_clockevents(void);
 void xen_save_time_memory_area(void);
 void xen_restore_time_memory_area(void);
+void xen_init_sched_clock_offset(void);
 void xen_init_time_ops(void);
 void xen_hvm_init_time_ops(void);



Unfortunately, I am not able to obtain the panic callstack from kdump time this
time. I have only below.

PANIC: early exception 0x0e IP 10:ffffffffa6c679b6 error 0 cr2 0x20
PANIC: early exception 0x0e IP 10:ffffffffa6c679b6 error 0 cr2 0x20



The sched_clock() can be used very early since commit 857baa87b642
("sched/clock: Enable sched clock early"). Any printk should use sched_clock()
to obtain the timestamp.

vprintk_store()
-> local_clock()
   -> sched_clock()
      -> paravirt_sched_clock()
         -> xen_sched_clock()
            -> xen_clocksource_read()


AFAIR, we started to encounter the issue since commit 857baa87b642
("sched/clock: Enable sched clock early"). kdump used to work well before that
commit.

Thank you very much!

Dongli Zhang


From xen-devel-bounces@lists.xenproject.org Sat Feb 26 03:18:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 26 Feb 2022 03:18:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279670.477424 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNnbT-0004z7-HU; Sat, 26 Feb 2022 03:18:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279670.477424; Sat, 26 Feb 2022 03:18:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNnbT-0004yz-Cc; Sat, 26 Feb 2022 03:18:39 +0000
Received: by outflank-mailman (input) for mailman id 279670;
 Sat, 26 Feb 2022 03:18:38 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nNnbS-0004yp-FC; Sat, 26 Feb 2022 03:18:38 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nNnbS-0002oS-AO; Sat, 26 Feb 2022 03:18:38 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nNnbR-0008Ia-Oh; Sat, 26 Feb 2022 03:18:37 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nNnbR-0002nh-OE; Sat, 26 Feb 2022 03:18:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=jgrqaUmnFMvpVwqq1LHrqv6Kk0CtlaqxOgNwsdVVLYM=; b=LCJE50Xiv3fF4m26EqsmN7lpHk
	ShkcyEFAdEtRiroxbgJiqhRpF8U9futT1mLUhuUqF/AuzqKlNI3TIqSEWEuinFusjLQZWL3H8R3ev
	bs1SNdRCFuwDtLix6Zl9J4AvxYxk7s3flFP76Lu/aXCptkqT98Vf4Uqy135p465AHPMU=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168231-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 168231: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=f0f2f42c21de82ff65672e8ecfadcfddc63f2186
X-Osstest-Versions-That:
    xen=9ba4c529985a1773852069889a5b53f2ed26c408
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 26 Feb 2022 03:18:37 +0000

flight 168231 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168231/

Failures :-/ but no regressions.

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds    18 guest-start/debian.repeat fail REGR. vs. 168224

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168224
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168224
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168224
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168224
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168224
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168224
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168224
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168224
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168224
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168224
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168224
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168224
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  f0f2f42c21de82ff65672e8ecfadcfddc63f2186
baseline version:
 xen                  9ba4c529985a1773852069889a5b53f2ed26c408

Last test of basis   168224  2022-02-25 04:07:22 Z    0 days
Testing same since   168231  2022-02-25 15:39:35 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Bob Eshleman <bobbyeshleman@gmail.com>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Julien Grall <jgrall@amazon.com>
  Mateusz Mówka <mateusz.mowka@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   9ba4c52998..f0f2f42c21  f0f2f42c21de82ff65672e8ecfadcfddc63f2186 -> master


From xen-devel-bounces@lists.xenproject.org Sat Feb 26 06:55:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 26 Feb 2022 06:55:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279703.477514 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNqzE-0002qZ-4V; Sat, 26 Feb 2022 06:55:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279703.477514; Sat, 26 Feb 2022 06:55:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNqzE-0002qS-1H; Sat, 26 Feb 2022 06:55:24 +0000
Received: by outflank-mailman (input) for mailman id 279703;
 Sat, 26 Feb 2022 06:55:22 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nNqzC-0002qI-Mh; Sat, 26 Feb 2022 06:55:22 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nNqzC-00078H-IZ; Sat, 26 Feb 2022 06:55:22 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nNqzC-0000Nx-1k; Sat, 26 Feb 2022 06:55:22 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nNqzC-0005Ub-1H; Sat, 26 Feb 2022 06:55:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ddyfmHaK2jb9rJKzkpTy7p50N3I4BIa1yAhglJT3NU0=; b=x2vOA5jKgjRUlJcClvsLTwRut+
	b2kHLgpFomCger5AYSe2lEIx3zFjmPpC21mAiHw2wAwhuuyfJ3IZZqr1Z53PgJwjQ+reQ1cDQ5bZW
	9e4sPeBhDeGjWUwTnAOCz3gVz0vdatzFSr2GFd6iWSRHUmypEZSLc355LCqezOlA741o=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168235-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 168235: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=c47658311d60be064b839f329c0e4d34f5f0735b
X-Osstest-Versions-That:
    linux=53ab78cd6d5aba25575a7cfb95729336ba9497d8
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 26 Feb 2022 06:55:22 +0000

flight 168235 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168235/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168227
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168227
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168227
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168227
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168227
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168227
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168227
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168227
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                c47658311d60be064b839f329c0e4d34f5f0735b
baseline version:
 linux                53ab78cd6d5aba25575a7cfb95729336ba9497d8

Last test of basis   168227  2022-02-25 08:51:05 Z    0 days
Testing same since   168235  2022-02-25 20:39:57 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Christophe JAILLET <christophe.jaillet@wanadoo.fr>
  Christophe Kerello <christophe.kerello@foss.st.com>
  Cosmin Tanislav <cosmin.tanislav@analog.com>
  Cosmin Tanislav <demonsingur@gmail.com>
  Daehwan Jung <dh10.jung@samsung.com>
  Damien Le Moal <damien.lemoal@opensource.wdc.com>
  Daniel Starke <daniel.starke@siemens.com>
  daniel.starke@siemens.com <daniel.starke@siemens.com>
  Daniele Palmas <dnlplm@gmail.com>
  Dmytro Bagrii <dimich.dmb@gmail.com>
  Fabrice Gasnier <fabrice.gasnier@foss.st.com>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Hans de Goede <hdegoede@redhat.com>
  Heikki Krogerus <heikki.krogerus@linux.intel.com>
  Hongyu Xie <xiehongyu1@kylinos.cn>
  Jens Axboe <axboe@kernel.dk>
  Johan Hovold <johan@kernel.org>
  Jonathan Cameron <Jonathan.Cameron@huawei.com>
  Julia Pineda <julia.pineda@analog.com>
  Kees Cook <keescook@chromium.org>
  Linus Torvalds <torvalds@linux-foundation.org>
  Lorenzo Bianconi <lorenzo@kernel.org>
  Marek Szyprowski <m.szyprowski@samsung.com>
  Mario Tesi <mario.tesi@st.com>
  Mathias Nyman <mathias.nyman@linux.intel.com>
  Miaoqian Lin <linmq006@gmail.com>
  Miquel Raynal <miquel.raynal@bootlin.com>
  Muhammad Usama Anjum <usama.anjum@collabora.com>
  Mårten Lindahl <marten.lindahl@axis.com>
  Nuno Sá <nuno.sa@analog.com>
  Oleksij Rempel <o.rempel@pengutronix.de>
  Oliver Graute <oliver.graute@kococonnector.com>
  Phil Elwell <phil@raspberrypi.com>
  Puma Hsu <pumahsu@google.com>
  Sean Nyekjaer <sean@geanix.com>
  Sebastian Andrzej Siewior <bigeasy@linutronix.de>
  Sergey Shtylyov <s.shtylyov@omp.ru>
  Slark Xiao <slark_xiao@163.com>
  Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
  Szymon Heidrich <szymon.heidrich@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   53ab78cd6d5a..c47658311d60  c47658311d60be064b839f329c0e4d34f5f0735b -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Sat Feb 26 10:06:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 26 Feb 2022 10:06:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279726.477526 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNtyN-00048L-IJ; Sat, 26 Feb 2022 10:06:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279726.477526; Sat, 26 Feb 2022 10:06:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNtyN-00048E-FA; Sat, 26 Feb 2022 10:06:43 +0000
Received: by outflank-mailman (input) for mailman id 279726;
 Sat, 26 Feb 2022 10:06:41 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Y5OK=TJ=citrix.com=prvs=049eb39b2=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nNtyL-000488-AD
 for xen-devel@lists.xenproject.org; Sat, 26 Feb 2022 10:06:41 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c73de111-96eb-11ec-8eb9-a37418f5ba1a;
 Sat, 26 Feb 2022 11:06:38 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c73de111-96eb-11ec-8eb9-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645869997;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:content-transfer-encoding:mime-version;
  bh=zsEPMi+b0GEc3CfqJk274DNdvD+Emc0oA23mYPTyylQ=;
  b=NvF42VPzC46UeJUWOddqicNgos2rwCSPhQqjyFGRTOzLnG9ybxEzVfI5
   Zn7e7se6VMhUL8lEQOwhTdv8t+j/qVR8GT2k1ZTuOJgA5pkSOVD+q4MYp
   81L2aP42K1GWJScQdbICSIzgFRFLD37nvtVTAo4amsrr42Jq8C3xdWgdR
   I=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 65047790
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:ff8/Yq1AxVRR2fqZefbD5fdxkn2cJEfYwER7XKvMYLTBsI5bpzYFz
 GcYWWzQbvrbZ2Hzc9wlOoq+o0wB6pHUyYU2SwU5pC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EE/NtTo5w7Rj2tQy34Dga++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /1J5ZngYBgFA5fonfQsCStBEBllOPNJreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHxO4wSoDd4xCzxBvc6W5HTBa7N4Le02R9u25gSQqmPP
 6L1bxJDRi7tfkZOA244M5wzo7fvvXjbfzxH/Qf9Sa0fvDGIkV0ZPKLWGNjfd8GORM5Vtl2Fv
 W+A9GP8ajkGNN2EjzuetHv0gvTImwv0XYsTEPuz8fsCqE2ewCkfBQMbUXO/oOKlkQiuVtRHM
 UsW9yEy668o+ySWosLVBkPi5iTe51hFBoQWQ7ZSBByxJrT851acVkEbYgN7TNk2hZUEXD8Sz
 VrXkIa8bdBwi4G9RXWY/7aSiDq9PykJMGMPDRM5oRs5D8rL+99q0E+WJjp3OOvs14CuR2msq
 9yfhHVm390uYdg3O7JXFLwtqxalvdD3QwE8/W07tUr1v1oiNOZJi2FFgGU3DMqszq7FHzFtX
 1BewqByCdzi67nXxURhp81XQdmUCw6tamG0vLKWN8BJG86R03CiZ5tMxzp1OV1kNM0JERewP
 hOO5l8IuMILZCPyBUOSX25XI557pUQHPY64Ps04k/IUOsQhHON51HsGibGsM5DFzxF3zPBX1
 WazesewF3cKYZmLPxLtL9rxJYQDn3hkrUuKHMiT503+jdK2OS7EIZ9YYQDmRr1os8u5TPD9r
 o832z2ikE4EDoUTo0D/rOYuELz9BSNjVMCu9pcOLbbrz8gPMDhJNsI9CIgJIuRNt69Uiv3J7
 je6XEpZw0D4nnrJNUOBbXULVV8ldc8XQa4TVcD0AWuV5g==
IronPort-HdrOrdr: A9a23:ViKQxKwd/8suJBgr1MdbKrPxzuskLtp133Aq2lEZdPULSKOlfp
 GV8MjziyWYtN9wYhAdcdDpAtjlfZq6z+8I3WBxB8beYOCCggWVxe5ZnO3fKlHbak/DH6tmpN
 xdmstFeazN5DpB/L/HCWCDer5Kqrn3k5xAx92utUuFJTsaFZ2IhD0JbTpzfHcGITWvUvECZe
 WhD4d81nKdUEVSSv7+KmgOXuDFqdGOvJX6YSQeDxpizAWVlzun5JPzDhDdh34lInly6IZn1V
 KAvx3y562lvf3+4hjA11XL55ATvNf60NNMCOGFl8BQADTxjQSDYphnRtS5zXsIidDqzGxvvM
 jHoh8mMcg2w3TNflutqR+o4AXk2CZG0Q6U9XaoxV/Y5eDpTjMzDMRMwahDdAHC1kYmtNZglI
 pWwmOwrfNsfFz9tRW4w+KNewBhl0Kyr3Znu/UUlWZjXYwXb6IUhZAD/XlSDIwLEEvBmcwa+d
 FVfYDhDcttABOnhyizhBgt/DXsZAV/Iv6+eDlNhiTPuAIm3kyQzCMjtbgidzk7hdcAoqJ/lp
 f525RT5cFzp/AtHNBA7Z86MLOK40z2MGTx2TGpUB3a/J9uAQO5l3ew2sRw2N2X
X-IronPort-AV: E=Sophos;i="5.90,139,1643691600"; 
   d="scan'208";a="65047790"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Lq5OjQ8Tsy0ncR4/Oa/qKKNFSYWWL7SG7bua4RNfyCvr3t8xOCKv74uTPcR6S6ELS+gndF5xnTEzh1mhzaSPNdXaLk0HUgGIaLAYbvBZYbN+AUnA9lX9LdmDTM86EchWNSQvL7fK2sVIa0PI2GMxPinNEOA5j2oOIGg2XpbdydyboWzZLSWswqD26tHYJ3UR00IiyGWB3pXuJIE1KuXrq2O+fQ6GdFMfLucrR+KBdpxOPDoqSEiQ71qw6EltGBjEAE7p4A192RSfZ2/QN6sqU1nRdfb39KVjMZIJ2nQTOyNDupThc4UsU8QcDhZkMCj8OCzfRruifFi5MZGEdYrJ2g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=+0xCVDIM20YR3TZi0k5lqQzK2c1CZyooLEaYcIANKSQ=;
 b=DmZGpmqoUe04ACS040lPXX2hYY911HyJ2xXPgZlUk0ERJD39CBAX0qxo/ma+aoH6jzYLn3vRBh/H+GsHfrA67iUyaq2mr+oMx3RkMukiQyufqLjCbDvqEqlex71KXEvUDI0wSdUpo/2qIRRTezZjwWuzbbI8t8vwXQdRpzfW0h/gRlIbsx8wrxVQ4Wv/gDfcOuEz4z6iwiJJqFDjbul0mkvZlooANWdi7ftjxxDk/Rn1FBsSF53Neu9YemG1Vf4+bc7OT/G9E/QOsBEb9Y6x802o8Kn9uL7b00E2U30K2Dw1bJwpGWQWEjV19VP8o08bw7f+o0vPxRi1LuDWPMA9fg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=+0xCVDIM20YR3TZi0k5lqQzK2c1CZyooLEaYcIANKSQ=;
 b=Te3uoDmep63HMZCsGoD9mTLDNpcmDgw5X5SccSU6dtSEFUiLYC6wDJ94TSc0PYOuNZrdanlAN4RIR9IM1OBrJ6sSUN3HPlvfqeb7X2jCZjpzUUDGV+1HLRptPPaoTJKh39Q3i3WypIz+2owY7N9HxZtY1bqo36l8i0TX4sRIOwA=
From: Roger Pau Monne <roger.pau@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Alex Olson <this.is.a0lson@gmail.com>, Roger Pau Monne
	<roger.pau@citrix.com>, Jan Beulich <jbeulich@suse.com>
Subject: [PATCH v2.1 2/2] vpci/msix: fix PBA accesses
Date: Sat, 26 Feb 2022 11:05:54 +0100
Message-ID: <20220226100554.2664-1-roger.pau@citrix.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <d8da3251985684ab9099ce95a8329a7e35535a7b.camel@gmail.com>
References: <d8da3251985684ab9099ce95a8329a7e35535a7b.camel@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LNXP123CA0020.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:d2::32) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a167a006-47bb-4ff5-26f5-08d9f90fa8e6
X-MS-TrafficTypeDiagnostic: MWHPR03MB2925:EE_
X-Microsoft-Antispam-PRVS: <MWHPR03MB2925F86F8A6D80D2B757F85D8F3F9@MWHPR03MB2925.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: t70UQQeOmmoP+2N0tHh7emT0Dv1I7/sa7Lo7oMNqjVCfPlBAUPkGIRm6YA29uIowZKBFblWCyK9HjAcoJCcIJ0P77QSzmIzhjna3RDC6voezZk7dT9/dOBQivJ80d+MH0ZRFl4cMf9fOqebUrPlybY0JORsqrUerZxq1lyryxUXae9cNKznoX/NNSM/zHF99nem6AwF8yU9NYvxH308pSJeBUwVrrWDhIXWIRqL0GQIeUiU47aUignEjjrexcxndrcFYDixa/ZvyEFQWgp4ThDKiuBh8HJUSeK5y/ybwhLga+RraatcSIMeSVWPHrmRYwBbLPlXY3U0t5YsVZIZ4OuCtaMwi/7D4NMvyTS6wBRY1fhmHGynf21ybu4jkIHrzgmKmOVN6her9q6IirQ0HEHGBpdITnexAvzHrkhysVBIVl0RoFIvkz1B2Ymz5ClOa5xmbWsZHLIhTOxPGUrM3CiqzxWyVQI1SYYeN9E1n3W3aC8c11jbf3SYNNGVUB3gnnjoiudGhKeUyfehw2XqoZlldDplRuWtStKm13XIMDawb3z0Zbs7hiQ9AB1UYDubTSHXsmyyEEjmCqPjxnarjo4KW+0iX2Ud8gB4QLBQoiMKcLS/7w5Ql5oML09z9IatOEK0IJtuMcvp3GqlIe+dNPg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6486002)(66946007)(66556008)(66476007)(5660300002)(316002)(8676002)(508600001)(1076003)(2616005)(82960400001)(6916009)(54906003)(186003)(6512007)(38100700002)(26005)(2906002)(83380400001)(4326008)(6506007)(86362001)(6666004)(8936002)(36756003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WEFIVHl4dllwMjJmZnM3RmYvTzQrNVVKM0JxNk1mdEY3UDBpVFJKMUVTNy9s?=
 =?utf-8?B?OHRLTThnRENZby80bGJBYk0xMi9RRHRhR1BYRlRyam0wbWtKL203aVZ6K3Uw?=
 =?utf-8?B?SkU1QVlRdVcycDlzTmVmTFlTcjZDVnAzMUd4dW5tSkVDaFZUejZIT0xjcy9P?=
 =?utf-8?B?bTZtN0tWLytVajNCd2ZFdmVJOXMzTTJwYXJRdlZBa0ppK1NGeWNIRGtnMml1?=
 =?utf-8?B?RkZjVm04b1l2cmt0Wkw0NkZoVmhjL21ZYjdjaDJZNE9ieUo2NmhTWE1zWFE3?=
 =?utf-8?B?Wjg4SitGNVA4YmtkSlZSZkdzNnJHeXdGSmJCMlo2UHR1UGVWL29xanYyUFRP?=
 =?utf-8?B?aEpHOW50UnV2b3lxQzAxZTRBR3BPTjBaeWx2V0hYS1BiU3R5VmxsRC80UFZE?=
 =?utf-8?B?eGRPM0J3VlBwSnNQNHQ5eXFyVTZyYVIzS01ZQ0JwU09Sa0pLWkRjWHFabkcy?=
 =?utf-8?B?L2grNWF4THlWYjVpWDB1NkxscHVaRVNSQmJhUGpKZmJmS1lGNWplSm54Mzho?=
 =?utf-8?B?emlvUkJnVTVveThvSU9pWVIrMVZtSWdVbHFlcCtNd1hOcGpsRFJDWjVVYnVX?=
 =?utf-8?B?U0plMU1xZEdRNFNNb0xLckxZYUFCbXpIaVJhSnF3VE16RHI2OWg0WnNaTkFw?=
 =?utf-8?B?V2M2Qm9tNHVBcmprajhablYwaG1iSjF0UncyRTBMTW1aaW9UdUZ2V2dsZXNi?=
 =?utf-8?B?Y2pqZ0loRjk2TE0wRXluak9hVkF5aFlTZlVWVFFHMnN3UnZHam5HWmNaSVU2?=
 =?utf-8?B?SGlHQ0xtRVQ2YkZ5TjVERTZuMjhieE9pV0N6QXc4Z3F6U2xpemZEQVNwMzlz?=
 =?utf-8?B?Q0NoeXFmenhua0pSYkNOOWZubWRYeEI2YmRMMm9KR0dBRU9OY3p0L2VETkxZ?=
 =?utf-8?B?UnZROHpqRVFEVHNQSEVzSmxCanlTdnBpeDRzMGg5NFY4L3RsQkN5TStkNno0?=
 =?utf-8?B?KytGdlloeDM5dUZHUE5tWGprRVplQ240ZkZqWFNhTzdVUGkydnVMSm5qU1oz?=
 =?utf-8?B?amRIblF3cTVuSXQ2M3ZHL3dRTE1YRk91WXFIb2dFZmZWNUtnWGZmbmJKNUow?=
 =?utf-8?B?MTVnUVErOGVodnlRbjZMNHV3UC9PejJlNTc4MCthLzlRMnRXNkxnVjZ6TXoz?=
 =?utf-8?B?VWdLQzh3K0pFeDh6bCsxMjNpVG1tTG5acHNoSGVlNGpHMHg4OTZRT0VTbkhw?=
 =?utf-8?B?cU1SS0hrUGZxRCtiR09ibmIwZ0dPbm14Q3hOSXhHWExXSE1CVmhlbUY2VTRV?=
 =?utf-8?B?bFM2dG5NR0ZGWHRuQTgvV1g4NDl0bXF3WG5MR1hQMVUzUE16eWVQRy9pNlJl?=
 =?utf-8?B?a2RrWlAxN2RvLy9zU0ZmZXN5T3d0ZUlpclBTS1hxZDRvc3ozQmdwb21lOXA0?=
 =?utf-8?B?QmR1VitkOGI5MUpHMzdNVUZsTlZJOHRabVhOUWUrTkpEaFNVWUNFNC9BKzNP?=
 =?utf-8?B?VmVmNUJwNjVoMTVGOG1wZlNScGpKV0Fyd1V0ZHI2OGJ0cWVWUUprdjBzMU15?=
 =?utf-8?B?UmdQN1dLejJFeGJoc1RudWJZMU9nZ1ZyVXREb0VlVkZMTTBUOE1kMk0rWE1O?=
 =?utf-8?B?YmM4UHdxWDlpaUM1K2lCR0cxaTVTSkZvekFCeUFhMVh0MEk4dGdoSUZIU0NS?=
 =?utf-8?B?clJHMDhrSjRyTGsramhXa3BUUmJIalpwNnQrTjVQZHdnY2lHc2NWWHVUa09u?=
 =?utf-8?B?TkJIdHh3UnRYcldIL2VvSDVzbkI0Lzd4V1JFMkdaRkx1bCtKaTREYUo1djQ0?=
 =?utf-8?B?c2R3YW5xS2liV0puM3dEem5ySTM4SmIxMjdJeW1sQURWd3EvZUFpMVRNMytm?=
 =?utf-8?B?ZEhRZVc3WjROQWFZL3ZUNzhqakw5cTNQQWRrMHltTFQzMmRBSXRCeUl0ZGJr?=
 =?utf-8?B?N0tkV2kyZCt0RG5sWFFpVGRyY2J6Skh4NEhvVWQvZFNJSiswRnJuRk56a1RI?=
 =?utf-8?B?SXZjY0cvbFNuREd0cXhOekgvZmtjNzlXTUQ3dFBVakVkSU9IaGJZSVM5aVZX?=
 =?utf-8?B?SkZzcTR1MWFVY3R0V2dvZ05WZCs4dCtXdjluRFhLNUpMTWUzb1ZLcDc3eGVz?=
 =?utf-8?B?eDErdGVqN1V4QUNzdzRnS0E2aDJxQWdzL242RXdESy9BdzR1d05RV1FKRmk4?=
 =?utf-8?B?WXh6akR4WDE1aXhnSFlpclBxZytDYjV0WnFzUlF6ZnhxQm1zTlBZekNDT0Jl?=
 =?utf-8?Q?ESuFWn90kmuP+vmD/UXX7os=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a167a006-47bb-4ff5-26f5-08d9f90fa8e6
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2022 10:06:30.5147
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ggDswAyaNnzuaHIULKKHDwSZD94NG9zhSJ0a4KOClpJbeIDpIAYLC8jH+Is5tLZHE7euO9VR+7zqbcOqV8NNFw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2925
X-OriginatorOrg: citrix.com

Map the PBA in order to access it from the MSI-X read and write
handlers. Note that previously the handlers would pass the physical
host address into the {read,write}{l,q} handlers, which is wrong as
those expect a linear address.

Map the PBA using ioremap when the first access is performed. Note
that 32bit arches might want to abstract the call to ioremap into a
vPCI arch handler, so they can use a fixmap range to map the PBA.

Reported-by: Jan Beulich <jbeulich@suse.com>
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Cc: Alex Olson <this.is.a0lson@gmail.com>
---
Changes since v1:
 - Also handle writes.

I don't seem to have a box with a driver that will try to access the
PBA, so I would consider this specific code path only build tested. At
least it doesn't seem to regress the current state of vPCI.
---
 xen/drivers/vpci/msix.c | 56 ++++++++++++++++++++++++++++++++++++-----
 xen/drivers/vpci/vpci.c |  2 ++
 xen/include/xen/vpci.h  |  2 ++
 3 files changed, 54 insertions(+), 6 deletions(-)

diff --git a/xen/drivers/vpci/msix.c b/xen/drivers/vpci/msix.c
index a1fa7a5f13..4775f88e1f 100644
--- a/xen/drivers/vpci/msix.c
+++ b/xen/drivers/vpci/msix.c
@@ -198,8 +198,13 @@ static int cf_check msix_read(
     if ( !access_allowed(msix->pdev, addr, len) )
         return X86EMUL_OKAY;
 
+    spin_lock(&msix->pdev->vpci->lock);
     if ( VMSIX_ADDR_IN_RANGE(addr, msix->pdev->vpci, VPCI_MSIX_PBA) )
     {
+        struct vpci *vpci = msix->pdev->vpci;
+        paddr_t base = vmsix_table_addr(vpci, VPCI_MSIX_PBA);
+        unsigned int idx = addr - base;
+
         /*
          * Access to PBA.
          *
@@ -207,25 +212,43 @@ static int cf_check msix_read(
          * guest address space. If this changes the address will need to be
          * translated.
          */
+
+        if ( !msix->pba )
+        {
+            msix->pba = ioremap(base, vmsix_table_size(vpci, VPCI_MSIX_PBA));
+            if ( !msix->pba )
+            {
+                /*
+                 * If unable to map the PBA return all 1s (all pending): it's
+                 * likely better to trigger spurious events than drop them.
+                 */
+                spin_unlock(&vpci->lock);
+                gprintk(XENLOG_WARNING,
+                        "%pp: unable to map MSI-X PBA, report all pending\n",
+                        msix->pdev);
+                return X86EMUL_OKAY;
+           }
+        }
+
         switch ( len )
         {
         case 4:
-            *data = readl(addr);
+            *data = readl(msix->pba + idx);
             break;
 
         case 8:
-            *data = readq(addr);
+            *data = readq(msix->pba + idx);
             break;
 
         default:
             ASSERT_UNREACHABLE();
             break;
         }
+        spin_unlock(&vpci->lock);
 
         return X86EMUL_OKAY;
     }
 
-    spin_lock(&msix->pdev->vpci->lock);
     entry = get_entry(msix, addr);
     offset = addr & (PCI_MSIX_ENTRY_SIZE - 1);
 
@@ -273,32 +296,53 @@ static int cf_check msix_write(
     if ( !access_allowed(msix->pdev, addr, len) )
         return X86EMUL_OKAY;
 
+    spin_lock(&msix->pdev->vpci->lock);
     if ( VMSIX_ADDR_IN_RANGE(addr, msix->pdev->vpci, VPCI_MSIX_PBA) )
     {
+        struct vpci *vpci = msix->pdev->vpci;
+        paddr_t base = vmsix_table_addr(vpci, VPCI_MSIX_PBA);
+        unsigned int idx = addr - base;
 
         if ( !is_hardware_domain(d) )
+        {
             /* Ignore writes to PBA for DomUs, it's behavior is undefined. */
+            spin_unlock(&vpci->lock);
             return X86EMUL_OKAY;
+        }
+
+        if ( !msix->pba )
+        {
+            msix->pba = ioremap(base, vmsix_table_size(vpci, VPCI_MSIX_PBA));
+            if ( !msix->pba )
+            {
+                /* Unable to map the PBA, ignore write. */
+                spin_unlock(&vpci->lock);
+                gprintk(XENLOG_WARNING,
+                        "%pp: unable to map MSI-X PBA, write ignored\n",
+                        msix->pdev);
+                return X86EMUL_OKAY;
+           }
+        }
 
         switch ( len )
         {
         case 4:
-            writel(data, addr);
+            writel(data, msix->pba + idx);
             break;
 
         case 8:
-            writeq(data, addr);
+            writeq(data, msix->pba + idx);
             break;
 
         default:
             ASSERT_UNREACHABLE();
             break;
         }
+        spin_unlock(&vpci->lock);
 
         return X86EMUL_OKAY;
     }
 
-    spin_lock(&msix->pdev->vpci->lock);
     entry = get_entry(msix, addr);
     offset = addr & (PCI_MSIX_ENTRY_SIZE - 1);
 
diff --git a/xen/drivers/vpci/vpci.c b/xen/drivers/vpci/vpci.c
index f3b32d66cb..9fb3c05b2b 100644
--- a/xen/drivers/vpci/vpci.c
+++ b/xen/drivers/vpci/vpci.c
@@ -51,6 +51,8 @@ void vpci_remove_device(struct pci_dev *pdev)
         xfree(r);
     }
     spin_unlock(&pdev->vpci->lock);
+    if ( pdev->vpci->msix && pdev->vpci->msix->pba )
+        iounmap(pdev->vpci->msix->pba);
     xfree(pdev->vpci->msix);
     xfree(pdev->vpci->msi);
     xfree(pdev->vpci);
diff --git a/xen/include/xen/vpci.h b/xen/include/xen/vpci.h
index bcad1516ae..c399b101ee 100644
--- a/xen/include/xen/vpci.h
+++ b/xen/include/xen/vpci.h
@@ -127,6 +127,8 @@ struct vpci {
         bool enabled         : 1;
         /* Masked? */
         bool masked          : 1;
+        /* PBA map */
+        void *pba;
         /* Entries. */
         struct vpci_msix_entry {
             uint64_t addr;
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Sat Feb 26 10:11:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 26 Feb 2022 10:11:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279735.477537 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNu2e-0005Zi-8O; Sat, 26 Feb 2022 10:11:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279735.477537; Sat, 26 Feb 2022 10:11:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNu2e-0005Zb-58; Sat, 26 Feb 2022 10:11:08 +0000
Received: by outflank-mailman (input) for mailman id 279735;
 Sat, 26 Feb 2022 10:11:06 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Y5OK=TJ=citrix.com=prvs=049eb39b2=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nNu2c-0005ZU-Rj
 for xen-devel@lists.xenproject.org; Sat, 26 Feb 2022 10:11:06 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 677716ef-96ec-11ec-8eb9-a37418f5ba1a;
 Sat, 26 Feb 2022 11:11:05 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 677716ef-96ec-11ec-8eb9-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1645870265;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=4g/a6ZyggbsjwJL1akrPwZf2umvPUlvePw6p8Yh0cHM=;
  b=YdapEDaYrrIWLitD4N0HcgIhnqwUJACGHvGOKp3kGOcu33+bN/C5O1CT
   mYCy0gXB2wS1Cohvjub5Egm0LmuNzXJ2EFnW+Je/y/Zb/9oqQFyxhsDWm
   P9NlzwVNDT4jfxGfyQdNaCCiDdtBDNGPhxD7KU4pgpdgaKLT2REaUm9Jf
   I=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 65044976
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:p/uT+awpKIAmRAIOk416t+cTxirEfRIJ4+MujC+fZmUNrF6WrkUPx
 zQfXWzXMvuJYWumeI8jPITl801T7ZGAm9FlTwA4/CAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGX9JZS5LwbZj2NYy24bhWmthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 Npln66qRkApZ7L1nMsPYSdCTQIiFu520eqSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DJoQQt2sm1TjEJf0nXYrCU+PB4towMDIY2J0WQaqPO
 JRxhTxHMxrKbSN+MwcuLJM33/2wq2PBXiZ+twfAzUYwyzeKl1EguFT3C/LXcNGXQcRenm6Du
 3nLuW/+B3kyJNGZjDaI7H+oruvOhj/gHpIfEqWi8fxni0HVwXYcYDUKVVqg5/iizEfmX8lYL
 WQb/yMvqe4580nDczXmd0Tm+jje5EdaAocOVb1hgO2Q9kbKyyyrHGdDTmdeUdgJpv0IX2IJi
 nTKr/q8UFSDr4apYX6a876Vqxa7Ni4UMXIOaEc4cOcV3zXwiNpt10ySF76PBIbw14SoQm+on
 1hmuQBj3+17sCId60msEbkraRqIr4OBcAM67x6/somNvlIgP97Ni2BFBDHmARd8wGSxEgjpU
 JsswZH2AAUy4Xelzn3lrAIlRuzB2hp9GGeA6WOD5rF4n9hXx1atfJpL/BZ1L1pzP8APdFfBO
 RGP5FwNvcMOZCPyNcebhr5d7exwnMAM8vy/C5jpgidmOMAtJGdrAgk0DaJv44wduBd1yvxuU
 XtqWc2tEWwbGcxaIMmeHI8gPUsQ7nlmnwv7HMmjpzz+iOb2TCPFGN8tbQrVBshkvfzsnekg2
 4sGXyd8404EC7OWj+i+2dN7EG3m2lBgXcGm85EML7XbSuekcUl4Y8LsLXoaU9UNt4xel/vS/
 2H7XUldyVHlgmbAJxnMYXdmAI4Dl74lxZ7nFUTA5WqV5kU=
IronPort-HdrOrdr: A9a23:7584tKAxL983dlflHehAsceALOsnbusQ8zAXPh9KJiC9I/b1qy
 nxppkmPH/P6Qr4WBkb6Le90Y27MAnhHP9OkPIs1NKZMjUO11HYTr2KgbGSpgEIXheOi9K1tp
 0QDZSWaueAdGSS5PySiGLTc6dC/DDEytHRuQ639QYTcegAUdAH0+4WMHf+LqUgLzM2eabRWa
 Dsr/Zvln6FQzA6f867Dn4KU6zqoMDKrovvZVojCwQ84AeDoDu04PqieiLolSs2Yndq+/MP4G
 LFmwv26uGKtOy68AbV0yv2445NkNXs59NfDIini9QTKB/rlgG0Db4RE4GqjXQQmqWC+VwqmN
 7Dr1MJONly0WrYeiWPrR7ky2DboUITwk6n7WXdrWrooMT/Sj5/IdFGn5hlfhzQ7FdllM1g0Y
 pQtljp+6Z/PFflpmDQ9tLIXxZlmg6funw5i9MeiHRZTM83dKJRl4oC50lYea1wUR4S0LpXXt
 WGMfuspcq/KTihHjDkVyhUsZaRt00Ib1i7qhNogL3X79BU9EoJunfwivZv3Evoz6hNO6Ws19
 60Q5iAq4s+PfP+TZgNc9vpEvHHfFAkf3r3QRCvyBLcZeQ6B04=
X-IronPort-AV: E=Sophos;i="5.90,139,1643691600"; 
   d="scan'208";a="65044976"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=bt1DMACTBmW2ynu/LbTzWh6HZf+QxPKEqkm50ukBMw4HtLooA1owFczweJWxSlh36fwycIc4aNdttJ3XsDyfbo41IJzpel6Zk9djPjzvzZ1wKsx13sJVJdwqc0e8DeIvaMHB51+rnGIrEbD1Waot1aOZvOoQnTasa90DXzrTd8l3T0q/VwS3p/CNJjL6Dk2wuf6fjbhY8VVsNxvnTyo8xfaZdaz6tFlGaaio4dPiE0S1dOxQh0A03Z9peCV+do2OwkHz0f45OTr+Z3SD6b8+PPOI1YF9wE8UAW/7Puq9VpEGXoKJipCGSVpYD75hIqmVMkrr9v0fNjUmZlhN3qWkeA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=7sfGT9aN9+pb2i5D8lPbDuH8UbgfNsQRBEc0pbhJY8c=;
 b=b+BdRelRZ7/3ZzW6vgq+ms2oZ7/4g2NRonXOzpsctnqworgH+J5h30lKoJM1EDNWm+gF+bz/p+Ki52dcitoL4FqBACS5+ZJwzVT5X3v9DeRxFIY9QVs867SMTlK69TqFx2vy7v+yKRa128Ax5VaBKtVnzLZWp1mA4z3C38SKu2Nf+Ardv757y2Upc6NqMw8vlZMaXtA39CLml+qcNXXRwu/dWNS6ID5BKESoxRijfeajWKm/jfvjpcnom2XzWSN3n/cuVLcs8drdIO5JyAcnK532giZ0mTIBKtkkMgOjMnBTHmrZW7kFJli7rusA4QfX0wIJpLweSi2TBSrzizUMRQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=7sfGT9aN9+pb2i5D8lPbDuH8UbgfNsQRBEc0pbhJY8c=;
 b=pa3XxBuB+6UKuUEx1Psj3ibDK7XbVPeYCHgOJm/Y1FGvcZ7jj9TdoyNqjtiTotQuwMtMaD7SqD1Qcg2b6/01MtPN9DfcduqGGSqdqvQg0bUmOpZHI22lqOE0lewvnT+5whRS0IZMif1F7BehlJwzySyO6k/cBV3BMHs2dLPIx00=
Date: Sat, 26 Feb 2022 11:10:55 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Alex Olson <this.is.a0lson@gmail.com>
CC: <xen-devel@lists.xenproject.org>, Jan Beulich <jbeulich@suse.com>
Subject: Re: [PATCH v2 2/2] vpci/msix: fix PBA accesses
Message-ID: <Yhn8rzRIC/TNiPv2@Air-de-Roger>
References: <20220225153956.1078-1-roger.pau@citrix.com>
 <20220225153956.1078-3-roger.pau@citrix.com>
 <d8da3251985684ab9099ce95a8329a7e35535a7b.camel@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <d8da3251985684ab9099ce95a8329a7e35535a7b.camel@gmail.com>
X-ClientProxiedBy: LO4P265CA0066.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:2af::9) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b49d248b-70ce-41c0-9152-08d9f910497b
X-MS-TrafficTypeDiagnostic: MWHPR03MB2925:EE_
X-Microsoft-Antispam-PRVS: <MWHPR03MB2925B01BD50D288236AD37868F3F9@MWHPR03MB2925.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: VoTzfeUlQbzRTha4iTMGo15XcSR/pMKg0L17mPkGfptrzWZOlXYZeTMaDylt7tj0vR+40chd6PWtAry5TTdYNX6IgmM5w/Y8jRmao5BnyQBcJZKFyv+NPGOnLCnE7IEbovhhuWDXtybCXALhNlFAonY5peI5VNoH7RajJbrDiLi7z0P3s+alR4gC/te2lplNRowPiSb+mDWGcISNyUOer9DHu8qFvJwusRJ8F617coOIMKluGYvvcAATXeoSRm4m1DPsBPVvI0dOWybIQy9ss4lG0JVC32NhLbSFP8dkmPtpviJ+lndTUf/DJ2umpAYf+A1nLHp1ik+qBLicZIyrStUX8Up8jEz8kDg1JtUFXKDnZncCDJfXFmNFFoUGYbmA7fqqpGnip5f9RXroMZM+oUaLvZGNsP4pm+G8p7dosUd2BxQ7XAJzYjhkVVPCuAVzoC+Y6+zYg2VpKaKuqXJI7xvAYeowIJT6ZG7HerGJP8a+BEEu9WHlhZjhrwxQ93Eqm98vKnXbakY5uMGCuExtJyRAPoQ/W6MyZcfQzh7T7QJ0XbUxKTQNK92UrkNc537462fC553MV8j5z2MOyreORrOZ8H/bz2EBok1yRj4ZVewp7lvDYnT9W25jyL/6JAMByuwGQOMiGatuoxjT34EBUf5pKWmWh3+6cJiZ5ktFsJRPLYxlC/zbEDBFdhDQXJvRYNM21muq9Infi5mro6UuvyRyxyFpgcBBXekzR6dnFzk=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(6666004)(86362001)(83380400001)(4326008)(6506007)(85182001)(8936002)(33716001)(5660300002)(316002)(66556008)(66476007)(508600001)(8676002)(6486002)(66946007)(966005)(186003)(6512007)(9686003)(2906002)(26005)(38100700002)(6916009)(82960400001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MVhGZm4rYnk3MTlCeEFINi9melh2QTR1VXlKbWtxaGtFTCsxdmRQWXdrR0tE?=
 =?utf-8?B?TWdvbGl1V3plZVdOWkV2ZngrZXlXK3BEOXdCYXRiZWZueTIxM1dhNDQ4WVhq?=
 =?utf-8?B?TDZ0d3d4MjRVbEVXaXVhMzh5N1oxNEZjR0NpNnFKQ1RKaFYyRDdwRTluSXNt?=
 =?utf-8?B?S01qM1BTaWFqZ2JmS3JZMHY0cXQxSFZiS0hLekJCMkJ6dHpJcDlCaEpXUXlQ?=
 =?utf-8?B?T0sxZzNvV3ZveTlsYmxqWFFSTDlLQkdsWWF5Ti9NUTBoNk1hWEhaV1hadVox?=
 =?utf-8?B?MWx5b1lLTUZZOGZTV1V3SUdQSG1UaWw3Sm80V3Z6dDFTQWVIRnZMTkNhTkhy?=
 =?utf-8?B?VTQ2NW1POUYxUk9MTStiQm4rRFlQWFVoNXA3WVd3SFQ0a2RjSEphU0t5M1lZ?=
 =?utf-8?B?RklSM0N3WXV4NFlpN0lsNi9CYjFFK0tQbDRScnJlNFhzcjhKY050YUh5M3da?=
 =?utf-8?B?QUM0aDVkWVhGUm9BdXdUaXMvak5iYTAwQjVFNWFabUJNVDVxZmNNSS9OQXBQ?=
 =?utf-8?B?QzVYL2NOZW5oRWE4OElncFY4bTNyYy9FRjdra3liTXpHMzFwS290VGVQam5m?=
 =?utf-8?B?TlNDbmpIMGU3K1hsMGdGSWM0NXUveklMWkpsVWU5WDJ2ZWV0b1pVbHZqT3Jy?=
 =?utf-8?B?SVl2eVF2U0YyVHNoNDBmWUxkZ2FNbk5wWWNDNjV3VCtqMlhwU0M3c05WaHFt?=
 =?utf-8?B?RnZNaFgrU2FyNHpTQ3dENllqR3BHTktnSjhQWlN1ejRxM2E2UXVYMjFNZ1pQ?=
 =?utf-8?B?V2ZDaHhyWUZjQmh4MUh1RUlPTlFQOWNkMDFEUjhnZnVWWk9lK2pBYUV6dERV?=
 =?utf-8?B?Ky9hb1RpS0puTVF0aWtZaE8vMWZlWllBWGV0RUsrQTg5QVJSR0xIVTJmbERW?=
 =?utf-8?B?blFLbW56YXNGcGlyRnVkTnBmRkIvMGJFaEJic05HM0pERVJCOGdLVWIrMEYw?=
 =?utf-8?B?WDkrMDVBM2krNHo2N2dNWENYS1dBTGdscEVFQllyOHZHQ0pQbk50QnhMbVFI?=
 =?utf-8?B?SGpyU0FuY1lYMnQ3UzVMNm5iSCtvL09LZnZvMWpoK2JmeXk3SlEzZGsvQi9w?=
 =?utf-8?B?NkxKMWJZVUtWREJoVHcycFA1eGtBTzQ1VHdXWFRmZFNMdlhCM1pBS0svYkda?=
 =?utf-8?B?TFhUSTJsNUVPRnBXSU5FbnpaVVlEb0tUekJ2S1dHeWlUNWZTTjdCRUZUN1J6?=
 =?utf-8?B?dzRZTXVRTk4zVmM2MmNyUnNBTU1zaVJRTGUrWTBmbnh3MXZBOU1TNDRzTnlT?=
 =?utf-8?B?aXVPRGFGZWNFY0w1bkliMFEyYlNZOEZRWHJwSUJaMW02S1IrM001OFpQOTlk?=
 =?utf-8?B?WWRCbk9yb05uYlpZcVMxUXQrUFhlb3RJNUErbjl2ejAzbThmenJoMCtGZjlC?=
 =?utf-8?B?Mmh2MmZIZmFxa29MV3dNdU40TGN3OStUdTZhd2JVRkpHZW0wanhFUEpzOGV2?=
 =?utf-8?B?dUVpZExLSzhCMkcrOGN5NDA0Ri95V21xeXpEYVppMjNiRG5hVkcvSlVWNDNx?=
 =?utf-8?B?ZG0yRWE0UjIzekE0MCtCVThKNGNnVkxVZmFJTExaVGEvKzVabTl4NGJWWDF3?=
 =?utf-8?B?WDdYOTZjK1BnbzdSU1ltVUN1VWhjaXZPaEdxZ0NnRk9ZdVVIblFnZ2RQZ3Bn?=
 =?utf-8?B?Szh6MEhJeHprbVdGYnZLY0RNVklDR2JMb3hZRm9Wb1pXUGFRbWJ2MFYxeFY5?=
 =?utf-8?B?VEpDdThFVlhQWDRhOGU4cG51eXVZVzdIeFJOa0dNbEEyeTFtNm5HWVI0S2JK?=
 =?utf-8?B?U1N0TzU1MUxwRlc1RHNsdklSTE1MZnRoMHlhWVhuMUtMRTlXTnBRelFCbDlD?=
 =?utf-8?B?UXJVdmhjWVBFSHhEZ2tpc1NkM2w4WjVxUkJHR0VLMHdVMHRuaFplUlBQb0s4?=
 =?utf-8?B?N3I5emdNREFmSnhJUUZkUHRqT2lXa0QyckM0aWlSTzlBdmZZbklsM05ua0ds?=
 =?utf-8?B?Q05XUjFYOFJ4YVcrYWxHZ2ZaTk5yQ1JCalExUktvY3JSWnExQUpLNUxhNmF1?=
 =?utf-8?B?RXZtWDBqNGsvOFJ5YmR5RnpXS1BaQXRUcDhQZzZvQ2srTDVpWXZlRWZaYzVC?=
 =?utf-8?B?QVhtUzlKZzZ3M0ZRVXo4RDFYRHl6WTZFaUppamhiRDNVVndDYW4wOUN2cmdC?=
 =?utf-8?B?TXdYbGJMalg5bllFYmtOcUdRQ084V25TRXFhOEE2cjNHb3pJZFVtNzBOcVVn?=
 =?utf-8?Q?qbDJ1CqQW2WTKCRsJ28D7Zc=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b49d248b-70ce-41c0-9152-08d9f910497b
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2022 10:10:59.9606
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eeqWj18R2Phb5qdT+KpEvoRian8y/tuSJU0PLg56sIYhJTc9NHzzukYSxY1y3eHjg1XECkgqUY5rAwq9iiQVlQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2925
X-OriginatorOrg: citrix.com

On Fri, Feb 25, 2022 at 11:57:05AM -0600, Alex Olson wrote:
> I think there is an issue in the spin_lock handling of patch 2 for the
> "msix_write" function as it results in the lock being taken a second time while
> held (hangs). 
> 
> The lock taken before checking "VMSIX_ADDR_IN_RANGE" isn't unlocked for the non-
> PBA case and a second lock is attempted just before the call to get_entry()
> later in the same function.  It looks like either the added lock should either
> be moved inside the PBA case or the lock before get_entry() should be removed.

Sorry, was in a rush to send this before leaving yesterday and didn't
refresh the commit before generating the patch, v2.1 should be fixed.

Could you provide a 'Tested-by' if it work for you?

> 
> On my server, upon loading the ioatdma driver, it now successfully attempts an
> PBA write (which now doesn't crash the system), but I'm not sure I have a way to
> fully exercise it...

Urg, that's weird, PBA should be read-only only according to the spec.
Writes to PBA have undefined behavior.

> 
> I also see a different (related) issue in which modify_bars is called on a
> virtual function seemingly before the BAR addresses are initialized/known and
> will start a different thread for that topic.

SR-IOV is not supported on PVH dom0 yet, so that's not going to work.
I've posted a series in 2018 to enable it, but sadly had no time to
work on it anymore:

https://lore.kernel.org/xen-devel/20180717094830.54806-1-roger.pau@citrix.com/

It's likely not going to apply cleanly, and there's a lot of comments
to be fixed up there.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Sat Feb 26 10:50:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 26 Feb 2022 10:50:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279743.477548 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNuei-0001F5-7W; Sat, 26 Feb 2022 10:50:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279743.477548; Sat, 26 Feb 2022 10:50:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNuei-0001Ey-4K; Sat, 26 Feb 2022 10:50:28 +0000
Received: by outflank-mailman (input) for mailman id 279743;
 Sat, 26 Feb 2022 10:50:26 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nNueg-0001Eo-Rz; Sat, 26 Feb 2022 10:50:26 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nNueg-00038p-Oa; Sat, 26 Feb 2022 10:50:26 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nNueg-0004Y6-EW; Sat, 26 Feb 2022 10:50:26 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nNueg-0003rT-E7; Sat, 26 Feb 2022 10:50:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=femKxftB3y75Qhppu5lQf9jzZ/eHs0WePxYePWpixb4=; b=hSi5qDLP0nTEn/WjxRsbEbJ83E
	Sppv7gB9ukVL8PaZSAMIoZr3rrTEmAn92VpvuNY7MzxuGSKy8gGGEaBoGSDJu8bVd/xwUPdAg0RWC
	BGjrk7vtaamgWjNC2Xqof5o64sBsbrTT2Y3AmTGKbpj7x/wqR/x0I/PBnMob7WVCv6ec=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168237-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 168237: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=854ea58e4ee9dd5521bfb85df97f75381f617cb3
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 26 Feb 2022 10:50:26 +0000

flight 168237 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168237/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              854ea58e4ee9dd5521bfb85df97f75381f617cb3
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  596 days
Failing since        151818  2020-07-11 04:18:52 Z  595 days  577 attempts
Testing same since   168237  2022-02-26 04:19:42 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brad Laue <brad@brad-x.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Christophe Fergeau <cfergeau@redhat.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Divya Garg <divya.garg@nutanix.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Emilio Herrera <ehespinosa57@gmail.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Ivan Teterevkov <ivan.teterevkov@nutanix.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jing Qi <jinqi@redhat.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Kim InSoo <simmon@nplob.com>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Lubomir Rintel <lkundrak@v3.sk>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nicolas Lécureuil <neoclust@mageia.org>
  Nicolas Lécureuil <nicolas.lecureuil@siveo.net>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Rohit Kumar <rohit.kumar3@nutanix.com>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  shenjiatong <yshxxsjt715@gmail.com>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tu Qiang <tu.qiang35@zte.com.cn>
  Tuguoyi <tu.guoyi@h3c.com>
  tuqiang <tu.qiang35@zte.com.cn>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Vineeth Pillai <viremana@linux.microsoft.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yasuhiko Kamata <belphegor@belbel.or.jp>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 99017 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Feb 26 11:55:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 26 Feb 2022 11:55:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279754.477559 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNvf2-0007Bu-Bs; Sat, 26 Feb 2022 11:54:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279754.477559; Sat, 26 Feb 2022 11:54:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNvf2-0007Bn-6h; Sat, 26 Feb 2022 11:54:52 +0000
Received: by outflank-mailman (input) for mailman id 279754;
 Sat, 26 Feb 2022 11:54:50 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nNvf0-0007Bd-Ge; Sat, 26 Feb 2022 11:54:50 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nNvf0-0004AR-D2; Sat, 26 Feb 2022 11:54:50 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nNvez-0006Er-W6; Sat, 26 Feb 2022 11:54:50 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nNvez-0005es-Vd; Sat, 26 Feb 2022 11:54:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=iZkDBj5PF/gFIUqcYu8B/AboeJ3R1rV2Q8IlZl5ImNQ=; b=IiVohFIk1XRw0bWCxn3hQjLFY6
	Runsm6h69oEWeIZaaYY6ZwAg1dY7js+tFIKrEFaQ2mQtkpNtrcInOLdhX0IWEsQkxJUSf+wkk5oqA
	+8n9Gg3tT8sAiGJXAl8kBR2Ez0EEH6a1C0xsrAS0taairU8GOpbBiLTRfeLOgyr1wD2U=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168236-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 168236: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=10f1f7b010a22d6d4ee67b018412d5f7ea386fc6
X-Osstest-Versions-That:
    xen=f0f2f42c21de82ff65672e8ecfadcfddc63f2186
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 26 Feb 2022 11:54:49 +0000

flight 168236 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168236/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168231
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168231
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168231
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168231
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168231
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168231
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168231
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168231
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168231
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168231
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168231
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168231
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  10f1f7b010a22d6d4ee67b018412d5f7ea386fc6
baseline version:
 xen                  f0f2f42c21de82ff65672e8ecfadcfddc63f2186

Last test of basis   168231  2022-02-25 15:39:35 Z    0 days
Testing same since   168236  2022-02-26 03:21:52 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Thiner Logoer <logoerthiner1@163.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   f0f2f42c21..10f1f7b010  10f1f7b010a22d6d4ee67b018412d5f7ea386fc6 -> master


From xen-devel-bounces@lists.xenproject.org Sat Feb 26 11:55:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 26 Feb 2022 11:55:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279764.477577 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNvfm-0007rO-SY; Sat, 26 Feb 2022 11:55:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279764.477577; Sat, 26 Feb 2022 11:55:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNvfm-0007rH-PR; Sat, 26 Feb 2022 11:55:38 +0000
Received: by outflank-mailman (input) for mailman id 279764;
 Sat, 26 Feb 2022 11:55:37 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=r031=TJ=gmail.com=akihiko.odaki@srs-se1.protection.inumbo.net>)
 id 1nNvfl-0007fi-CX
 for xen-devel@lists.xenproject.org; Sat, 26 Feb 2022 11:55:37 +0000
Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com
 [2607:f8b0:4864:20::636])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 01f1a04c-96fb-11ec-8eb9-a37418f5ba1a;
 Sat, 26 Feb 2022 12:55:36 +0100 (CET)
Received: by mail-pl1-x636.google.com with SMTP id bd1so6888621plb.13
 for <xen-devel@lists.xenproject.org>; Sat, 26 Feb 2022 03:55:36 -0800 (PST)
Received: from localhost.localdomain
 ([2400:4050:c360:8200:4c8a:825a:fb9a:12f3])
 by smtp.gmail.com with ESMTPSA id
 pi16-20020a17090b1e5000b001bd1ffaf2basm1323761pjb.0.2022.02.26.03.55.32
 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);
 Sat, 26 Feb 2022 03:55:34 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 01f1a04c-96fb-11ec-8eb9-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=OE8zP91owAdAv34uCdWfWeqWZ/xtaym8fiSm/ATXeO4=;
        b=AOn7rkPqO+IspT+ZlGbo+gCLcxuWJFl6lJHIw+WO6MFQfNH9SB+yrUYxFz8evfSX21
         PzBBZ/VyyVGgxwCvNAXt4VgBs72WZf8l4HUCM+yRnjjpomTB5U82AxsFXppli+63IbL3
         X2PGJyXQv/d9Lra5aj3+duZy/KYLbIBjoh6lYaUFFwayyWI97uHHGq/Y3qekq2HqRTYi
         nXHwCs/Sr3HiZCFiDqSxeZzk8Q4vRfH8ef+X09HyfWtcGWY7F05Er9xk8T36XlnX0RL5
         ot+nva2I4HBY2sfgGvX+X6ZOL9hRiZQidEw7rLIY06CDYpbqYHpjVXNa4Pbmh5lv4wiN
         TG5g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=OE8zP91owAdAv34uCdWfWeqWZ/xtaym8fiSm/ATXeO4=;
        b=urtA61MJmLI+PzrC21RrXFRHDVSUWQ5hxjMk5beHgwFkh+H1nVABQdAt+alWYAImUi
         eSSpao5brLxWgFr6np3LJ4x90II+54Q32CyUMXgPml/z6/NLf7Evn7DOxnEsrZR28wV4
         AQTKjxczaNzv3QAirIJUXtvzph9C1fzSVYOSXa9rb0BY761+0w6rjckdyfmF8MMHTHUv
         QgD2GFEdXTbANWLpgOSflVaA6FIKBihrwnOvyC2BqXG2mNbArU3u2SWnpF3A6b0U3CLO
         InKHDdn8m74kZo/RkcmoV1/hBmYiQm3sIMoiR6ZhWO61P4hfZ75w3R2jOnLy/vc4p35i
         vblw==
X-Gm-Message-State: AOAM531PyE0EU6y8ch+nizwZoVy+rjfRmCR8HGFjKqiPEMErnVlFiaBC
	VmHQl48hZHjekMHpZbApYy0=
X-Google-Smtp-Source: ABdhPJxzxcwqMQgVSDEOScYTCQv+dVNrIoXxffPaEgtRBh3LH6zFDiaNBTknjegkmpJqtJsydO/sFA==
X-Received: by 2002:a17:902:d2c6:b0:150:128:b276 with SMTP id n6-20020a170902d2c600b001500128b276mr12050398plc.5.1645876535179;
        Sat, 26 Feb 2022 03:55:35 -0800 (PST)
From: Akihiko Odaki <akihiko.odaki@gmail.com>
To: 
Cc: qemu Developers <qemu-devel@nongnu.org>,
	xen-devel@lists.xenproject.org,
	Gerd Hoffmann <kraxel@redhat.com>,
	"Michael S . Tsirkin" <mst@redhat.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Anthony Perard <anthony.perard@citrix.com>,
	Paul Durrant <paul@xen.org>,
	Akihiko Odaki <akihiko.odaki@gmail.com>
Subject: [PATCH v3 0/3] virtio-gpu: Respect UI refresh rate for EDID
Date: Sat, 26 Feb 2022 20:55:13 +0900
Message-Id: <20220226115516.59830-1-akihiko.odaki@gmail.com>
X-Mailer: git-send-email 2.32.0 (Apple Git-132)
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Let virtio-gpu be aware of the refresh rate. The EDID change is delivered with
display hotplugging, which should not happen too frequently. Because of that,
this moves the refresh rate to QemuUIInfo, whose change delivery is throttled.

The delivery throttling also affects xenfb and this change does not maintain
a seperate code path to avoid the throttling because the difference is little
if it xists. Usually the refresh rate of display does not change frequently and
most guests are not prepared for that anyway.

v3: Rebased to the latest QEMU.

Akihiko Odaki (3):
  ui/console: Do not return a value with ui_info
  ui: Deliver refresh rate via QemuUIInfo
  virtio-gpu: Respect UI refresh rate for EDID

 hw/display/virtio-gpu-base.c   |  7 +++---
 hw/display/virtio-gpu.c        |  1 +
 hw/display/virtio-vga.c        |  5 ++--
 hw/display/xenfb.c             | 14 ++++++++---
 hw/vfio/display.c              |  8 +++---
 include/hw/virtio/virtio-gpu.h |  1 +
 include/ui/console.h           |  4 +--
 include/ui/gtk.h               |  2 +-
 ui/console.c                   |  6 -----
 ui/gtk-egl.c                   |  4 +--
 ui/gtk-gl-area.c               |  3 +--
 ui/gtk.c                       | 45 ++++++++++++++++++++--------------
 12 files changed, 54 insertions(+), 46 deletions(-)

-- 
2.32.0 (Apple Git-132)



From xen-devel-bounces@lists.xenproject.org Sat Feb 26 11:55:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 26 Feb 2022 11:55:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279765.477589 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNvfp-00088C-3K; Sat, 26 Feb 2022 11:55:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279765.477589; Sat, 26 Feb 2022 11:55:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNvfp-000883-0M; Sat, 26 Feb 2022 11:55:41 +0000
Received: by outflank-mailman (input) for mailman id 279765;
 Sat, 26 Feb 2022 11:55:40 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=r031=TJ=gmail.com=akihiko.odaki@srs-se1.protection.inumbo.net>)
 id 1nNvfo-0007Uo-7o
 for xen-devel@lists.xenproject.org; Sat, 26 Feb 2022 11:55:40 +0000
Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com
 [2607:f8b0:4864:20::1029])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 03bfce9f-96fb-11ec-8539-5f4723681683;
 Sat, 26 Feb 2022 12:55:39 +0100 (CET)
Received: by mail-pj1-x1029.google.com with SMTP id
 h17-20020a17090acf1100b001bc68ecce4aso10685190pju.4
 for <xen-devel@lists.xenproject.org>; Sat, 26 Feb 2022 03:55:39 -0800 (PST)
Received: from localhost.localdomain
 ([2400:4050:c360:8200:4c8a:825a:fb9a:12f3])
 by smtp.gmail.com with ESMTPSA id
 pi16-20020a17090b1e5000b001bd1ffaf2basm1323761pjb.0.2022.02.26.03.55.35
 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);
 Sat, 26 Feb 2022 03:55:37 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 03bfce9f-96fb-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=1vVq5QSmFweuWNBdaYFtPRKPL3G9SHsp3hf2KVemRVo=;
        b=Y2+1zlnn4e2aOoUS/40z8+sK0+GHbu2IDCJKBrw6ym7cvsqogLskQzaDpI+4NzPStq
         fCbnbPNjpS36ByBqAxPA3Gf8FAnZmhZ2W0GtHN1NTpBTd7WVcEuZaenGC0xNiRH4IFJv
         0BRaqXxTI1LUCWMjoDXvUKnRRWslB1bWM2VTUWrUhKoHbU6y3XaXjZ4dsKOVWE8cMm/p
         5/GLFLpLWK4kefelCJte5v93tlm9W76ZeWNXM7jrEjfpcteMxKi9CugiZKrMycPZKTIh
         FHMnpOSu2GQtwB9yhO2uIrLa+UpcqUTPBKJ52O8Twk/GCCeAzB1u+OyouiJWxDXvQ521
         sXbA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=1vVq5QSmFweuWNBdaYFtPRKPL3G9SHsp3hf2KVemRVo=;
        b=J30iP38p/W8p4f2YVvlTCG6OA4KyrPNQWlzDVqAzdzTv0lL9HKhUfyuFqrZDGKghN6
         gECmC25cHTBVOpiQBT+8mWAzrdA9DUpegrx3NU62TDqJXm5Vo/D0E3YWo0vUUOrjM2tC
         ZmLUb87AdUhGrRPvx5/JCgP2mWrwAV3wiEiOn3pU3HGwh0CfMOP6o8ejNivoMYHw/0hD
         BL31HGrxjWZjE0sgWc5LltWqEhOp3rVPPhsS1jBpVBogd9iZ+EKzAP08GvTEl1oLVkMc
         dMnUAOiqzY6tqzH3fvFzihZbdas+z4ZmPoIxBgcnSHEe07l0LKmw9McLvFQ4b2Uo4keg
         Vm4w==
X-Gm-Message-State: AOAM531KvGxlljJf00TZsTifB8lEvXJByEfF/dyLUo+Zc8+jwkBeQd5E
	fGy5/uMrHl2uyizXx69kqyM=
X-Google-Smtp-Source: ABdhPJzv9vpq6EwhjOpHjxz1l51nFl8tdgYInJJ4xyQ8eyJ/15tOXY5qM2/17GCtdoEvEc2qD2VD8g==
X-Received: by 2002:a17:902:9045:b0:14f:14e7:f3aa with SMTP id w5-20020a170902904500b0014f14e7f3aamr11257393plz.69.1645876538010;
        Sat, 26 Feb 2022 03:55:38 -0800 (PST)
From: Akihiko Odaki <akihiko.odaki@gmail.com>
To: 
Cc: qemu Developers <qemu-devel@nongnu.org>,
	xen-devel@lists.xenproject.org,
	Gerd Hoffmann <kraxel@redhat.com>,
	"Michael S . Tsirkin" <mst@redhat.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Anthony Perard <anthony.perard@citrix.com>,
	Paul Durrant <paul@xen.org>,
	Akihiko Odaki <akihiko.odaki@gmail.com>
Subject: [PATCH v3 1/3] ui/console: Do not return a value with ui_info
Date: Sat, 26 Feb 2022 20:55:14 +0900
Message-Id: <20220226115516.59830-2-akihiko.odaki@gmail.com>
X-Mailer: git-send-email 2.32.0 (Apple Git-132)
In-Reply-To: <20220226115516.59830-1-akihiko.odaki@gmail.com>
References: <20220226115516.59830-1-akihiko.odaki@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

The returned value is not used and misleading.

Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>
---
 hw/display/virtio-gpu-base.c | 6 +++---
 hw/display/virtio-vga.c      | 5 ++---
 hw/vfio/display.c            | 8 +++-----
 include/ui/console.h         | 2 +-
 4 files changed, 9 insertions(+), 12 deletions(-)

diff --git a/hw/display/virtio-gpu-base.c b/hw/display/virtio-gpu-base.c
index fff0fb4a828..c73b3aa06b8 100644
--- a/hw/display/virtio-gpu-base.c
+++ b/hw/display/virtio-gpu-base.c
@@ -69,12 +69,12 @@ static void virtio_gpu_notify_event(VirtIOGPUBase *g, uint32_t event_type)
     virtio_notify_config(&g->parent_obj);
 }
 
-static int virtio_gpu_ui_info(void *opaque, uint32_t idx, QemuUIInfo *info)
+static void virtio_gpu_ui_info(void *opaque, uint32_t idx, QemuUIInfo *info)
 {
     VirtIOGPUBase *g = opaque;
 
     if (idx >= g->conf.max_outputs) {
-        return -1;
+        return;
     }
 
     g->req_state[idx].x = info->xoff;
@@ -92,7 +92,7 @@ static int virtio_gpu_ui_info(void *opaque, uint32_t idx, QemuUIInfo *info)
 
     /* send event to guest */
     virtio_gpu_notify_event(g, VIRTIO_GPU_EVENT_DISPLAY);
-    return 0;
+    return;
 }
 
 static void
diff --git a/hw/display/virtio-vga.c b/hw/display/virtio-vga.c
index 5a2f7a45408..84433d3557e 100644
--- a/hw/display/virtio-vga.c
+++ b/hw/display/virtio-vga.c
@@ -47,15 +47,14 @@ static void virtio_vga_base_text_update(void *opaque, console_ch_t *chardata)
     }
 }
 
-static int virtio_vga_base_ui_info(void *opaque, uint32_t idx, QemuUIInfo *info)
+static void virtio_vga_base_ui_info(void *opaque, uint32_t idx, QemuUIInfo *info)
 {
     VirtIOVGABase *vvga = opaque;
     VirtIOGPUBase *g = vvga->vgpu;
 
     if (g->hw_ops->ui_info) {
-        return g->hw_ops->ui_info(g, idx, info);
+        g->hw_ops->ui_info(g, idx, info);
     }
-    return -1;
 }
 
 static void virtio_vga_base_gl_block(void *opaque, bool block)
diff --git a/hw/vfio/display.c b/hw/vfio/display.c
index 89bc90508fb..78f4d82c1c3 100644
--- a/hw/vfio/display.c
+++ b/hw/vfio/display.c
@@ -106,14 +106,14 @@ err:
     return;
 }
 
-static int vfio_display_edid_ui_info(void *opaque, uint32_t idx,
-                                     QemuUIInfo *info)
+static void vfio_display_edid_ui_info(void *opaque, uint32_t idx,
+                                      QemuUIInfo *info)
 {
     VFIOPCIDevice *vdev = opaque;
     VFIODisplay *dpy = vdev->dpy;
 
     if (!dpy->edid_regs) {
-        return 0;
+        return;
     }
 
     if (info->width && info->height) {
@@ -121,8 +121,6 @@ static int vfio_display_edid_ui_info(void *opaque, uint32_t idx,
     } else {
         vfio_display_edid_update(vdev, false, 0, 0);
     }
-
-    return 0;
 }
 
 static void vfio_display_edid_init(VFIOPCIDevice *vdev)
diff --git a/include/ui/console.h b/include/ui/console.h
index f590819880b..7f5374380f0 100644
--- a/include/ui/console.h
+++ b/include/ui/console.h
@@ -427,7 +427,7 @@ typedef struct GraphicHwOps {
     bool gfx_update_async; /* if true, calls graphic_hw_update_done() */
     void (*text_update)(void *opaque, console_ch_t *text);
     void (*update_interval)(void *opaque, uint64_t interval);
-    int (*ui_info)(void *opaque, uint32_t head, QemuUIInfo *info);
+    void (*ui_info)(void *opaque, uint32_t head, QemuUIInfo *info);
     void (*gl_block)(void *opaque, bool block);
 } GraphicHwOps;
 
-- 
2.32.0 (Apple Git-132)



From xen-devel-bounces@lists.xenproject.org Sat Feb 26 11:55:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 26 Feb 2022 11:55:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279767.477600 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNvfs-0008TE-DA; Sat, 26 Feb 2022 11:55:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279767.477600; Sat, 26 Feb 2022 11:55:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNvfs-0008T7-8w; Sat, 26 Feb 2022 11:55:44 +0000
Received: by outflank-mailman (input) for mailman id 279767;
 Sat, 26 Feb 2022 11:55:43 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=r031=TJ=gmail.com=akihiko.odaki@srs-se1.protection.inumbo.net>)
 id 1nNvfq-0007fi-UG
 for xen-devel@lists.xenproject.org; Sat, 26 Feb 2022 11:55:43 +0000
Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com
 [2607:f8b0:4864:20::1034])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0514cd72-96fb-11ec-8eb9-a37418f5ba1a;
 Sat, 26 Feb 2022 12:55:41 +0100 (CET)
Received: by mail-pj1-x1034.google.com with SMTP id
 ge19-20020a17090b0e1300b001bcca16e2e7so6273477pjb.3
 for <xen-devel@lists.xenproject.org>; Sat, 26 Feb 2022 03:55:41 -0800 (PST)
Received: from localhost.localdomain
 ([2400:4050:c360:8200:4c8a:825a:fb9a:12f3])
 by smtp.gmail.com with ESMTPSA id
 pi16-20020a17090b1e5000b001bd1ffaf2basm1323761pjb.0.2022.02.26.03.55.38
 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);
 Sat, 26 Feb 2022 03:55:40 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0514cd72-96fb-11ec-8eb9-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=ZiMwz4CLUHVQwB/T9EDfn/YLCqMyd2Smwt78yZWRpeo=;
        b=AQpKxolY+jmvrIAcwuW4Q5j87it2u7GvZ51eYOQWO5OZ0CAwny+tQHokxK/bwHV0qF
         gghMz3iM0K7MGDoy29eFn1Ji/t1qYxsz3HZvZ3ksCSM724gIAyLEz1MFcr1G1RQr9TLl
         V016pJBUCr2G3uh0wmWttf5Rtn1WLdAiNjVYpfeheiWs6M1AZO//qzyg3Fq9zJsi60Z6
         LTfKUtoqt4dV7Xxm3QciSv0uhF/cc3RsyouZZ3holFsa1xliqU5wQ8lufWa5nXRXt4YV
         fVZ/Bko53qzyLLxBoZ5cEceawnBQWXRkT2wVNXx22Sfet+hB2sLu1/GC1ANTZaJGzn25
         nkDA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=ZiMwz4CLUHVQwB/T9EDfn/YLCqMyd2Smwt78yZWRpeo=;
        b=0v0XkOmSTnDteAEUmwIuHE2/N55mG1BcREYu76zPGFBUR5+vqNjS4KXAHD0jmVQu3T
         aB6Q6HoXs6rz3E9rRfbrKy1eWFyX4p4vo9+TOf6YRHDjMV92g3zjN8mz/7kOTihzfh+o
         bqKWpNxFLISJ9FcAOBPQPCaeWD0hm36sBMASFOcHNyuSptXHAAHsS/xzA0dpRqrEo7U8
         h3a8wyQEd4PFbEBwmEjcvxiE1oO6NTFmSehIg6pPaDGO5IBnHtIB9uyBKEgq3pZwdY7l
         GgGNotzERWKPf5c/yUcSVlQPMMOvNb1JjkPv0BXYubbgNLxAbTskyZH/KD4LgJfm29nd
         xWxA==
X-Gm-Message-State: AOAM53310Cyr8Y3RFRcLARGkTTkPYglNGGReWCBhP9dqewp+nNUzo0GP
	v6Db2Mo/aIaFFnS572oKdyo=
X-Google-Smtp-Source: ABdhPJz/YbHQ3xbVnebcpB1Qyc25RMYaC59gB9DTVe0ZA/Fb3d5S0sNzZFhaZSt7b+KC/nesUruCaA==
X-Received: by 2002:a17:902:7e4b:b0:151:57d6:670f with SMTP id a11-20020a1709027e4b00b0015157d6670fmr129391pln.144.1645876540447;
        Sat, 26 Feb 2022 03:55:40 -0800 (PST)
From: Akihiko Odaki <akihiko.odaki@gmail.com>
To: 
Cc: qemu Developers <qemu-devel@nongnu.org>,
	xen-devel@lists.xenproject.org,
	Gerd Hoffmann <kraxel@redhat.com>,
	"Michael S . Tsirkin" <mst@redhat.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Anthony Perard <anthony.perard@citrix.com>,
	Paul Durrant <paul@xen.org>,
	Akihiko Odaki <akihiko.odaki@gmail.com>
Subject: [PATCH v3 2/3] ui: Deliver refresh rate via QemuUIInfo
Date: Sat, 26 Feb 2022 20:55:15 +0900
Message-Id: <20220226115516.59830-3-akihiko.odaki@gmail.com>
X-Mailer: git-send-email 2.32.0 (Apple Git-132)
In-Reply-To: <20220226115516.59830-1-akihiko.odaki@gmail.com>
References: <20220226115516.59830-1-akihiko.odaki@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

This change adds a new member, refresh_rate to QemuUIInfo in
include/ui/console.h. It represents the refresh rate of the
physical display backend, and it is more appropriate than
GUI update interval as the refresh rate which the emulated device
reports:
- sdl may set GUI update interval shorter than the refresh rate
  of the physical display to respond to user-generated events.
- sdl and vnc aggressively changes GUI update interval, but
  a guests is typically not designed to respond to frequent
  refresh rate changes, or frequent "display mode" changes in
  general. The frequency of refresh rate changes of the physical
  display backend matches better to the guest's expectation.

QemuUIInfo also has other members representing "display mode",
which makes it suitable for refresh rate representation. It has
a throttling of update notifications, and prevents frequent changes
of the display mode.

Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>
---
 hw/display/xenfb.c   | 14 +++++++++++---
 include/ui/console.h |  2 +-
 include/ui/gtk.h     |  2 +-
 ui/console.c         |  6 ------
 ui/gtk-egl.c         |  4 ++--
 ui/gtk-gl-area.c     |  3 +--
 ui/gtk.c             | 45 +++++++++++++++++++++++++-------------------
 7 files changed, 42 insertions(+), 34 deletions(-)

diff --git a/hw/display/xenfb.c b/hw/display/xenfb.c
index 838260b6ad1..a53341ef673 100644
--- a/hw/display/xenfb.c
+++ b/hw/display/xenfb.c
@@ -777,16 +777,24 @@ static void xenfb_update(void *opaque)
     xenfb->up_fullscreen = 0;
 }
 
-static void xenfb_update_interval(void *opaque, uint64_t interval)
+static void xenfb_ui_info(void *opaque, uint32_t idx, QemuUIInfo *info)
 {
     struct XenFB *xenfb = opaque;
+    uint32_t refresh_rate;
 
     if (xenfb->feature_update) {
 #ifdef XENFB_TYPE_REFRESH_PERIOD
         if (xenfb_queue_full(xenfb)) {
             return;
         }
-        xenfb_send_refresh_period(xenfb, interval);
+
+        refresh_rate = info->refresh_rate;
+        if (!refresh_rate) {
+            refresh_rate = 75;
+        }
+
+        /* T = 1 / f = 1 [s*Hz] / f = 1000*1000 [ms*mHz] / f */
+        xenfb_send_refresh_period(xenfb, 1000 * 1000 / refresh_rate);
 #endif
     }
 }
@@ -983,5 +991,5 @@ struct XenDevOps xen_framebuffer_ops = {
 static const GraphicHwOps xenfb_ops = {
     .invalidate  = xenfb_invalidate,
     .gfx_update  = xenfb_update,
-    .update_interval = xenfb_update_interval,
+    .ui_info     = xenfb_ui_info,
 };
diff --git a/include/ui/console.h b/include/ui/console.h
index 7f5374380f0..24f1dbec038 100644
--- a/include/ui/console.h
+++ b/include/ui/console.h
@@ -139,6 +139,7 @@ typedef struct QemuUIInfo {
     int       yoff;
     uint32_t  width;
     uint32_t  height;
+    uint32_t  refresh_rate;
 } QemuUIInfo;
 
 /* cursor data format is 32bit RGBA */
@@ -426,7 +427,6 @@ typedef struct GraphicHwOps {
     void (*gfx_update)(void *opaque);
     bool gfx_update_async; /* if true, calls graphic_hw_update_done() */
     void (*text_update)(void *opaque, console_ch_t *text);
-    void (*update_interval)(void *opaque, uint64_t interval);
     void (*ui_info)(void *opaque, uint32_t head, QemuUIInfo *info);
     void (*gl_block)(void *opaque, bool block);
 } GraphicHwOps;
diff --git a/include/ui/gtk.h b/include/ui/gtk.h
index 101b147d1b9..ae0f53740d1 100644
--- a/include/ui/gtk.h
+++ b/include/ui/gtk.h
@@ -155,7 +155,7 @@ extern bool gtk_use_gl_area;
 
 /* ui/gtk.c */
 void gd_update_windowsize(VirtualConsole *vc);
-int gd_monitor_update_interval(GtkWidget *widget);
+void gd_update_monitor_refresh_rate(VirtualConsole *vc, GtkWidget *widget);
 void gd_hw_gl_flushed(void *vc);
 
 /* ui/gtk-egl.c */
diff --git a/ui/console.c b/ui/console.c
index 40eebb6d2cc..63c5c207f0c 100644
--- a/ui/console.c
+++ b/ui/console.c
@@ -155,7 +155,6 @@ static void gui_update(void *opaque)
     uint64_t dcl_interval;
     DisplayState *ds = opaque;
     DisplayChangeListener *dcl;
-    QemuConsole *con;
 
     ds->refreshing = true;
     dpy_refresh(ds);
@@ -170,11 +169,6 @@ static void gui_update(void *opaque)
     }
     if (ds->update_interval != interval) {
         ds->update_interval = interval;
-        QTAILQ_FOREACH(con, &consoles, next) {
-            if (con->hw_ops->update_interval) {
-                con->hw_ops->update_interval(con->hw, interval);
-            }
-        }
         trace_console_refresh(interval);
     }
     ds->last_update = qemu_clock_get_ms(QEMU_CLOCK_REALTIME);
diff --git a/ui/gtk-egl.c b/ui/gtk-egl.c
index e3bd4bc2743..b5bffbab252 100644
--- a/ui/gtk-egl.c
+++ b/ui/gtk-egl.c
@@ -140,8 +140,8 @@ void gd_egl_refresh(DisplayChangeListener *dcl)
 {
     VirtualConsole *vc = container_of(dcl, VirtualConsole, gfx.dcl);
 
-    vc->gfx.dcl.update_interval = gd_monitor_update_interval(
-            vc->window ? vc->window : vc->gfx.drawing_area);
+    gd_update_monitor_refresh_rate(
+            vc, vc->window ? vc->window : vc->gfx.drawing_area);
 
     if (!vc->gfx.esurface) {
         gd_egl_init(vc);
diff --git a/ui/gtk-gl-area.c b/ui/gtk-gl-area.c
index fc5a082eb84..0113474ef5f 100644
--- a/ui/gtk-gl-area.c
+++ b/ui/gtk-gl-area.c
@@ -121,8 +121,7 @@ void gd_gl_area_refresh(DisplayChangeListener *dcl)
 {
     VirtualConsole *vc = container_of(dcl, VirtualConsole, gfx.dcl);
 
-    vc->gfx.dcl.update_interval = gd_monitor_update_interval(
-            vc->window ? vc->window : vc->gfx.drawing_area);
+    gd_update_monitor_refresh_rate(vc, vc->window ? vc->window : vc->gfx.drawing_area);
 
     if (!vc->gfx.gls) {
         if (!gtk_widget_get_realized(vc->gfx.drawing_area)) {
diff --git a/ui/gtk.c b/ui/gtk.c
index a8567b9ddc8..7d904141af0 100644
--- a/ui/gtk.c
+++ b/ui/gtk.c
@@ -696,11 +696,20 @@ static gboolean gd_window_close(GtkWidget *widget, GdkEvent *event,
     return TRUE;
 }
 
-static void gd_set_ui_info(VirtualConsole *vc, gint width, gint height)
+static void gd_set_ui_refresh_rate(VirtualConsole *vc, int refresh_rate)
 {
     QemuUIInfo info;
 
-    memset(&info, 0, sizeof(info));
+    info = *dpy_get_ui_info(vc->gfx.dcl.con);
+    info.refresh_rate = refresh_rate;
+    dpy_set_ui_info(vc->gfx.dcl.con, &info, true);
+}
+
+static void gd_set_ui_size(VirtualConsole *vc, gint width, gint height)
+{
+    QemuUIInfo info;
+
+    info = *dpy_get_ui_info(vc->gfx.dcl.con);
     info.width = width;
     info.height = height;
     dpy_set_ui_info(vc->gfx.dcl.con, &info, true);
@@ -724,33 +733,32 @@ static void gd_resize_event(GtkGLArea *area,
 {
     VirtualConsole *vc = (void *)opaque;
 
-    gd_set_ui_info(vc, width, height);
+    gd_set_ui_size(vc, width, height);
 }
 
 #endif
 
-/*
- * If available, return the update interval of the monitor in ms,
- * else return 0 (the default update interval).
- */
-int gd_monitor_update_interval(GtkWidget *widget)
+void gd_update_monitor_refresh_rate(VirtualConsole *vc, GtkWidget *widget)
 {
 #ifdef GDK_VERSION_3_22
     GdkWindow *win = gtk_widget_get_window(widget);
+    int refresh_rate;
 
     if (win) {
         GdkDisplay *dpy = gtk_widget_get_display(widget);
         GdkMonitor *monitor = gdk_display_get_monitor_at_window(dpy, win);
-        int refresh_rate = gdk_monitor_get_refresh_rate(monitor); /* [mHz] */
-
-        if (refresh_rate) {
-            /* T = 1 / f = 1 [s*Hz] / f = 1000*1000 [ms*mHz] / f */
-            return MIN(1000 * 1000 / refresh_rate,
-                       GUI_REFRESH_INTERVAL_DEFAULT);
-        }
+        refresh_rate = gdk_monitor_get_refresh_rate(monitor); /* [mHz] */
+    } else {
+        refresh_rate = 0;
     }
+
+    gd_set_ui_refresh_rate(vc, refresh_rate);
+
+    /* T = 1 / f = 1 [s*Hz] / f = 1000*1000 [ms*mHz] / f */
+    vc->gfx.dcl.update_interval = refresh_rate ?
+        MIN(1000 * 1000 / refresh_rate, GUI_REFRESH_INTERVAL_DEFAULT) :
+        GUI_REFRESH_INTERVAL_DEFAULT;
 #endif
-    return 0;
 }
 
 static gboolean gd_draw_event(GtkWidget *widget, cairo_t *cr, void *opaque)
@@ -787,8 +795,7 @@ static gboolean gd_draw_event(GtkWidget *widget, cairo_t *cr, void *opaque)
         return FALSE;
     }
 
-    vc->gfx.dcl.update_interval =
-        gd_monitor_update_interval(vc->window ? vc->window : s->window);
+    gd_update_monitor_refresh_rate(vc, vc->window ? vc->window : s->window);
 
     fbw = surface_width(vc->gfx.ds);
     fbh = surface_height(vc->gfx.ds);
@@ -1673,7 +1680,7 @@ static gboolean gd_configure(GtkWidget *widget,
 {
     VirtualConsole *vc = opaque;
 
-    gd_set_ui_info(vc, cfg->width, cfg->height);
+    gd_set_ui_size(vc, cfg->width, cfg->height);
     return FALSE;
 }
 
-- 
2.32.0 (Apple Git-132)



From xen-devel-bounces@lists.xenproject.org Sat Feb 26 11:55:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 26 Feb 2022 11:55:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279768.477611 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNvfu-0000Mc-LQ; Sat, 26 Feb 2022 11:55:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279768.477611; Sat, 26 Feb 2022 11:55:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nNvfu-0000MT-H7; Sat, 26 Feb 2022 11:55:46 +0000
Received: by outflank-mailman (input) for mailman id 279768;
 Sat, 26 Feb 2022 11:55:45 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=r031=TJ=gmail.com=akihiko.odaki@srs-se1.protection.inumbo.net>)
 id 1nNvft-0007Uo-0n
 for xen-devel@lists.xenproject.org; Sat, 26 Feb 2022 11:55:45 +0000
Received: from mail-pg1-x52e.google.com (mail-pg1-x52e.google.com
 [2607:f8b0:4864:20::52e])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 069f38a2-96fb-11ec-8539-5f4723681683;
 Sat, 26 Feb 2022 12:55:44 +0100 (CET)
Received: by mail-pg1-x52e.google.com with SMTP id z4so7097706pgh.12
 for <xen-devel@lists.xenproject.org>; Sat, 26 Feb 2022 03:55:44 -0800 (PST)
Received: from localhost.localdomain
 ([2400:4050:c360:8200:4c8a:825a:fb9a:12f3])
 by smtp.gmail.com with ESMTPSA id
 pi16-20020a17090b1e5000b001bd1ffaf2basm1323761pjb.0.2022.02.26.03.55.40
 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);
 Sat, 26 Feb 2022 03:55:42 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 069f38a2-96fb-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=PA+WCteHQO0lrRBLqQfQaqZn8q0hOOjrSckhEBEspgs=;
        b=a1g9gVxd2qro29ukrrigoEDwnnpi9zUsQ6NGUQw0EWmx88h1QRpnLxAQq8v9q+5LyL
         nrasmCejv4KpqaD93Mn2pF9UQuOIakgjqtPS3bjQzBwcSiV7GcEcl2FU1UTI25HtBdh3
         ceReknBXMSr3qWzYK4yqmC9jtJT9oaEigIojPRzsQYFIQ4pMhq5b2cGJAc4WUKZlPYnB
         h+6Da2fxzrk6+ssM3tQR+EW74qlJE7nwq+GykYolK3YiAH1/HIq95LjdoHI5zGlRTXdJ
         EDyDfFvKGToc8C7aeT8I9+1AUS9Lw3F3glHr5Ac701NZamZ34L72GpnW7VI/3b6WU+NN
         SOiQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=PA+WCteHQO0lrRBLqQfQaqZn8q0hOOjrSckhEBEspgs=;
        b=VSlz1CJ2sPsk1aL4A8Sm4xl2De9JC//XJIln31DmMqVHAl5oBtMpE1O74vMX5ZTXTr
         qb3q2/8+GK5fcUP7b0BHieVhHmHEbNFW2Vetk3gHS6cguogb6DXcUBN+cYRj4+iMS+p9
         FUMCsHLEkSr6uURStySzrDWc3Yysau/IuQETZ6ffI5j8DIRfD6J2ZhiOTkDreLGDX0/P
         PpIClPHNwiH0XzSXxlV3e5xejY6HfD01tzjtEBQxVoQT7kln999m2HSt0tvCy3RTXzmG
         Dd1jNB4oIN6eY2qCDB1S92wWr3vFnP9jHSuzAfUvxmPYg6H9kvJ6l7sWL/YsY4TnOXbZ
         7ahQ==
X-Gm-Message-State: AOAM530txvxrpXsIoWNxpIT1pSG7CKQShqK4aNY30THJCvnMtSDNDCxL
	FQiPU26rU6MPUGa0S+BLvCM=
X-Google-Smtp-Source: ABdhPJyhtEwvZRT3/rGv5Q5kdFQg3/iO52gQvR2WGuc3llR8Ktgjshhnz8w9A2PJPg5VEwIxDnpkhw==
X-Received: by 2002:a05:6a00:1a56:b0:4c6:fe0c:2e27 with SMTP id h22-20020a056a001a5600b004c6fe0c2e27mr12200504pfv.65.1645876542871;
        Sat, 26 Feb 2022 03:55:42 -0800 (PST)
From: Akihiko Odaki <akihiko.odaki@gmail.com>
To: 
Cc: qemu Developers <qemu-devel@nongnu.org>,
	xen-devel@lists.xenproject.org,
	Gerd Hoffmann <kraxel@redhat.com>,
	"Michael S . Tsirkin" <mst@redhat.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Anthony Perard <anthony.perard@citrix.com>,
	Paul Durrant <paul@xen.org>,
	Akihiko Odaki <akihiko.odaki@gmail.com>
Subject: [PATCH v3 3/3] virtio-gpu: Respect UI refresh rate for EDID
Date: Sat, 26 Feb 2022 20:55:16 +0900
Message-Id: <20220226115516.59830-4-akihiko.odaki@gmail.com>
X-Mailer: git-send-email 2.32.0 (Apple Git-132)
In-Reply-To: <20220226115516.59830-1-akihiko.odaki@gmail.com>
References: <20220226115516.59830-1-akihiko.odaki@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>
---
 hw/display/virtio-gpu-base.c   | 1 +
 hw/display/virtio-gpu.c        | 1 +
 include/hw/virtio/virtio-gpu.h | 1 +
 3 files changed, 3 insertions(+)

diff --git a/hw/display/virtio-gpu-base.c b/hw/display/virtio-gpu-base.c
index c73b3aa06b8..ee2587a8c36 100644
--- a/hw/display/virtio-gpu-base.c
+++ b/hw/display/virtio-gpu-base.c
@@ -79,6 +79,7 @@ static void virtio_gpu_ui_info(void *opaque, uint32_t idx, QemuUIInfo *info)
 
     g->req_state[idx].x = info->xoff;
     g->req_state[idx].y = info->yoff;
+    g->req_state[idx].refresh_rate = info->refresh_rate;
     g->req_state[idx].width = info->width;
     g->req_state[idx].height = info->height;
     g->req_state[idx].width_mm = info->width_mm;
diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c
index c6dc818988c..04fbbd1f8f3 100644
--- a/hw/display/virtio-gpu.c
+++ b/hw/display/virtio-gpu.c
@@ -217,6 +217,7 @@ virtio_gpu_generate_edid(VirtIOGPU *g, int scanout,
         .height_mm = b->req_state[scanout].height_mm,
         .prefx = b->req_state[scanout].width,
         .prefy = b->req_state[scanout].height,
+        .refresh_rate = b->req_state[scanout].refresh_rate,
     };
 
     edid->size = cpu_to_le32(sizeof(edid->edid));
diff --git a/include/hw/virtio/virtio-gpu.h b/include/hw/virtio/virtio-gpu.h
index 2179b757037..09a317e1a7a 100644
--- a/include/hw/virtio/virtio-gpu.h
+++ b/include/hw/virtio/virtio-gpu.h
@@ -81,6 +81,7 @@ struct virtio_gpu_scanout {
 struct virtio_gpu_requested_state {
     uint16_t width_mm, height_mm;
     uint32_t width, height;
+    uint32_t refresh_rate;
     int x, y;
 };
 
-- 
2.32.0 (Apple Git-132)



From xen-devel-bounces@lists.xenproject.org Sat Feb 26 17:07:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 26 Feb 2022 17:07:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279832.477640 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nO0XB-0005eN-1c; Sat, 26 Feb 2022 17:07:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279832.477640; Sat, 26 Feb 2022 17:07:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nO0XA-0005eG-UI; Sat, 26 Feb 2022 17:07:04 +0000
Received: by outflank-mailman (input) for mailman id 279832;
 Sat, 26 Feb 2022 17:07:03 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nO0X9-0005e6-Qv; Sat, 26 Feb 2022 17:07:03 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nO0X9-0001WO-NP; Sat, 26 Feb 2022 17:07:03 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nO0X9-0005CM-4F; Sat, 26 Feb 2022 17:07:03 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nO0X9-0006nK-3k; Sat, 26 Feb 2022 17:07:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=yCkyJuCQbeA+ZJzPsdkRtV+L863JqpcNFxmuEIp4Juk=; b=FF3DUKyHzrraW0nfGoP0lPZT7B
	GBb0S60gWHOWMeWezPtkB8MFY5gQBsZR3zqv2SK+DMNbsAlm36mGnVV4zmk166xEcTYUKeG71z/rf
	dLPa1MFiMFDlU3G4YKBq15q5JSZe3pcYbZ/1FUYR4YJtr6oM9+zP8NKvFTR+UI13YXEQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168238-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 168238: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=9137eda53752ef73148e42b0d7640a00f1bc96b1
X-Osstest-Versions-That:
    linux=c47658311d60be064b839f329c0e4d34f5f0735b
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 26 Feb 2022 17:07:03 +0000

flight 168238 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168238/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168235
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168235
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168235
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168235
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168235
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168235
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168235
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168235
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                9137eda53752ef73148e42b0d7640a00f1bc96b1
baseline version:
 linux                c47658311d60be064b839f329c0e4d34f5f0735b

Last test of basis   168235  2022-02-25 20:39:57 Z    0 days
Testing same since   168238  2022-02-26 06:58:02 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Adam Ward <Adam.Ward.opensource@diasemi.com>
  Bart Van Assche <bvanassche@acm.org>
  Bartosz Golaszewski <brgl@bgdev.pl>
  Bjorn Andersson <bjorn.andersson@linaro.org>
  ChenXiaoSong <chenxiaosong2@huawei.com>
  Christoph Hellwig <hch@lst.de>
  Chuansheng Liu <chuansheng.liu@intel.com>
  David Sterba <dsterba@suse.com>
  Dāvis Mosāns <davispuh@gmail.com>
  Guillaume Savaton <guillaume@baierouge.fr>
  Jason Gunthorpe <jgg@nvidia.com>
  Jon Lin <jon.lin@rock-chips.com>
  Laibin Qiu <qiulaibin@huawei.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Marek Szyprowski <m.szyprowski@samsung.com>
  Mark Brown <broonie@kernel.org>
  Md Haris Iqbal <haris.iqbal@ionos.com>
  Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>
  Prasad Kumpatla <quic_pkumpatl@quicinc.com>
  Qu Wenruo <wqu@suse.com>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Samuel Holland <samuel@sholland.org>
  Shreeya Patel <shreeya.patel@collabora.com>
  Viresh Kumar <viresh.kumar@linaro.org>
  Zhou Qingyang <zhou1615@umn.edu>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   c47658311d60..9137eda53752  9137eda53752ef73148e42b0d7640a00f1bc96b1 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Sat Feb 26 19:30:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 26 Feb 2022 19:30:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279853.477655 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nO2lt-0002iv-0m; Sat, 26 Feb 2022 19:30:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279853.477655; Sat, 26 Feb 2022 19:30:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nO2ls-0002io-SS; Sat, 26 Feb 2022 19:30:24 +0000
Received: by outflank-mailman (input) for mailman id 279853;
 Sat, 26 Feb 2022 19:30:23 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nO2lr-0002ii-Mp
 for xen-devel@lists.xenproject.org; Sat, 26 Feb 2022 19:30:23 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nO2lr-0003ze-AR; Sat, 26 Feb 2022 19:30:23 +0000
Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nO2lr-0007Zh-4l; Sat, 26 Feb 2022 19:30:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=vy0KKzNV1cTLvO2UQfRSEyvB/FsMPs4v5L5ywHF+59w=; b=3a5jzQjQC6+wibDQg3P+J9WUZ+
	anHmwb5XCfAJNPlcGLbGL0g8YDaLNivAYVMnd+uISuGn8cGPfa1iO6R4aqOLxw4UCECmAewCfzKfh
	YK/34iwo/OK/SVYK0M0bje3qW8ukzDj4ACSao3lL+7dw+3ZeMU9FIV47F2DuBnRyBVNI=;
Message-ID: <e8382df1-eb0c-9571-873f-848e2d6cf8fa@xen.org>
Date: Sat, 26 Feb 2022 19:30:21 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.1
Subject: Re: [PATCH v3 05/19] xen/arm: mm: Add support for the contiguous bit
To: xen-devel@lists.xenproject.org
Cc: Julien Grall <jgrall@amazon.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20220221102218.33785-1-julien@xen.org>
 <20220221102218.33785-6-julien@xen.org>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220221102218.33785-6-julien@xen.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 21/02/2022 10:22, Julien Grall wrote:
> @@ -1333,21 +1386,34 @@ static int xen_pt_update(unsigned long virt,
>       while ( left )
>       {
>           unsigned int order, level;
> +        unsigned int nr_contig;
> +        unsigned int new_flags;
>   
>           level = xen_pt_mapping_level(vfn, mfn, left, flags);
>           order = XEN_PT_LEVEL_ORDER(level);
>   
>           ASSERT(left >= BIT(order, UL));
>   
> -        rc = xen_pt_update_entry(root, pfn_to_paddr(vfn), mfn, level, flags);
> -        if ( rc )
> -            break;
> +        /*
> +         * Check if we can set the contiguous mapping and update the
> +         * flags accordingly.
> +         */
> +        nr_contig = xen_pt_check_contig(vfn, mfn, level, left, flags);
> +        new_flags = flags | ((nr_contig > 1) ? _PAGE_CONTIG : 0);
>   
> -        vfn += 1U << order;
> -        if ( !mfn_eq(mfn, INVALID_MFN) )
> -            mfn = mfn_add(mfn, 1U << order);
> +        for ( ; nr_contig > 0; nr_contig-- )
> +        {
> +            rc = xen_pt_update_entry(root, pfn_to_paddr(vfn), mfn, level,
> +                                     new_flags);
> +            if ( rc )
> +                break;
>   
> -        left -= (1U << order);
> +            vfn += 1U << order;
> +            if ( !mfn_eq(mfn, INVALID_MFN) )
> +                mfn = mfn_add(mfn, 1U << order);
> +
> +            left -= (1U << order);
> +        }

I forgot to add:

if ( rc )
   break;

Without it, the outer loop will never exit in case of an error.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Sat Feb 26 22:56:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 26 Feb 2022 22:56:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279861.477666 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nO5yn-0004D8-8h; Sat, 26 Feb 2022 22:55:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279861.477666; Sat, 26 Feb 2022 22:55:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nO5yn-0004D1-5j; Sat, 26 Feb 2022 22:55:57 +0000
Received: by outflank-mailman (input) for mailman id 279861;
 Sat, 26 Feb 2022 22:55:56 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=cBSf=TJ=gmail.com=jandryuk@srs-se1.protection.inumbo.net>)
 id 1nO5ym-0004Cv-3C
 for xen-devel@lists.xenproject.org; Sat, 26 Feb 2022 22:55:56 +0000
Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com
 [2a00:1450:4864:20::12c])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 406563cf-9757-11ec-8539-5f4723681683;
 Sat, 26 Feb 2022 23:55:54 +0100 (CET)
Received: by mail-lf1-x12c.google.com with SMTP id f37so15302955lfv.8
 for <xen-devel@lists.xenproject.org>; Sat, 26 Feb 2022 14:55:54 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 406563cf-9757-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc:content-transfer-encoding;
        bh=HKCcLUZhsUknh9j6JCzm6hJju6qrKH1+yPCUjtvcLaA=;
        b=StQAlHn89LtG+TKp4A7bKTtfqr5poZL4wMDblkY00A8CEkITtu4pQYirczcRi7BWvZ
         dl4QKe4bWXX3tOHJE0uAMRXOzgz5LCBVWxkTZfgx6cP62gH7lNoRnhIc/f7/EdgE/4lE
         WmrDxOg0ko9kGi1ybHIGF/YTgi64ugEyq/2Sy1I5OJuL/N20vHKCK+nnEOxUo28mQYRv
         1seI/1rHwoyCEjp2jOW9GRK8DYsPr1yn96xV3eOgIveB9m4LcXow9eKq70xC8JcR/ddg
         g1i5g6dPs8UHaq8HoXDf2mynbAGKUOgrLXhQLe6R6V7RwE2qA1/IOi83zmUiwz4ibebi
         PONw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc:content-transfer-encoding;
        bh=HKCcLUZhsUknh9j6JCzm6hJju6qrKH1+yPCUjtvcLaA=;
        b=KKpOfGO0VzHfjkJKEhc4PNcmKGIBaCFcCbdkluApeYXqkkveNLz4P+Jy7kNn9KN7I1
         gee2Gdf0py65L5t4brpR/a8KgOQg3Sqjxl0a1Brh0rndpYPz53Kpps7On5JT4JVFabWi
         1Ic8SFfpb27Yf41XQqrXBOOSi1RVCsNDnD3O4Wmj/HtpXe2vsE8J3JND5Ps9L8rHvLup
         xZ4pFQBr7uC7GNs0RRJrsohmhTfaDUn17cW9Utk4lUDPSPBSc1rhrfWKI0A/qaUY2AT5
         lGOlio82DsymY5u0NMoA5H0uGitsQ/ZZ4P4e1q/BAsnUZjbVoCl3BvM/Bd4BOMeSJCNt
         Ogng==
X-Gm-Message-State: AOAM53284mp8WmXQ2CFKtSFWyZKiHCWvNhQHogRPcfydKBLqoJObjSif
	fyhRhNOLH3kw9kZFfeyrQbMI1j6I0Hd39Fd0dxs=
X-Google-Smtp-Source: ABdhPJx7R3+65fgH5TPurDLicr5SRdQufFa4peGfsYLcOdx0mlAdmjqL7jjYezy5QkfOuq1DQfxn/PUEe4rhCDfSYgs=
X-Received: by 2002:a19:7503:0:b0:443:3d52:fde6 with SMTP id
 y3-20020a197503000000b004433d52fde6mr8716395lfe.250.1645916153567; Sat, 26
 Feb 2022 14:55:53 -0800 (PST)
MIME-Version: 1.0
References: <20220224194853.17774-1-andrew.cooper3@citrix.com>
 <20220224194853.17774-3-andrew.cooper3@citrix.com> <12d8b90b-15b0-c094-71e5-35cfdbfe72b4@suse.com>
 <51ef6bd1-bcd9-9a3a-e902-887d42d7dd7e@citrix.com> <bb4b4106-f49d-2b50-1eb9-eb450f6b24fa@suse.com>
 <965e91fa-1f1e-7c57-5a71-a09b170a7d9f@citrix.com>
In-Reply-To: <965e91fa-1f1e-7c57-5a71-a09b170a7d9f@citrix.com>
From: Jason Andryuk <jandryuk@gmail.com>
Date: Sat, 26 Feb 2022 17:55:40 -0500
Message-ID: <CAKf6xpsz8zLEkCFpqXrgUOEkwHxTHM41vijGoZTWdhhRSA2OrQ@mail.gmail.com>
Subject: Re: x86/vmx: Don't spuriously crash the domain when INIT is received
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
Cc: Jan Beulich <jbeulich@suse.com>, Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>, 
	Jun Nakajima <jun.nakajima@intel.com>, Kevin Tian <kevin.tian@intel.com>, 
	Thiner Logoer <logoerthiner1@163.com>, 
	=?UTF-8?Q?Marek_Marczykowski=2DG=C3=B3recki?= <marmarek@invisiblethingslab.com>, 
	Xen-devel <xen-devel@lists.xenproject.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Feb 25, 2022 at 12:12 PM Andrew Cooper
<Andrew.Cooper3@citrix.com> wrote:
>
> On 25/02/2022 13:19, Jan Beulich wrote:
> > But I don't think I see the full picture here yet, unless your
> > mentioning of TXT was actually implying that TXT was active at the
> > point of the crash (which I don't think was said anywhere).
>
> This did cause confusion during debugging.  As far as we can tell, TXT
> is not active, but the observed behaviour certainly looks like TXT is
> active.

It's curious since the CPU, i5-1135G7, is listed as *not* supporting
TXT.  However, it does support Boot Guard, and both Boot Guard and TXT
use Authenticated Code Modules (ACMs) to implement their
functionality.  There is the below quote from the Measured Launched
Environment Developer=E2=80=99s Guide:
http://kib.kiev.ua/x86docs/Intel/TXT/315168-014.pdf

"Both Server TXT and Boot Guard (BtG) technologies require Startup ACM to b=
e
executed at platform reset. Intel =C2=AE CPUs can support only single such =
ACM and
therefore combining of BtG ACM with a Startup ACM is inevitable for platfor=
ms
supporting both technologies. This combining requirement triggered the
whole set of
upgrades targeted to better alignment of both technologies, and their
mutual benefits."

So I'm just speculating, but it seems there is TXT-ish stuff going on
when it resumes.

Regards,
Jason


From xen-devel-bounces@lists.xenproject.org Sun Feb 27 01:04:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 27 Feb 2022 01:04:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279868.477677 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nO7yy-0001wh-33; Sun, 27 Feb 2022 01:04:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279868.477677; Sun, 27 Feb 2022 01:04:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nO7yx-0001wa-W5; Sun, 27 Feb 2022 01:04:15 +0000
Received: by outflank-mailman (input) for mailman id 279868;
 Sun, 27 Feb 2022 01:04:14 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nO7yw-0001wQ-MX; Sun, 27 Feb 2022 01:04:14 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nO7yw-0003LW-Ip; Sun, 27 Feb 2022 01:04:14 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nO7yw-0002fE-0f; Sun, 27 Feb 2022 01:04:14 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nO7yw-0001Vs-0D; Sun, 27 Feb 2022 01:04:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=BexiBk50pOUT3+a4G4T+LTywORWDfbgpSytXlNUNJBk=; b=amg1MpFPgrh+He8bPYIiMB2jbj
	h06eCH6AMPTbkLCHWxQjA47pP0vsNYYBT/vgJz4ydtiPdhuH7uOCt2D/6TH6YWfq/WGvu0tHt+uT6
	qZoyt6AZsZnD8wimLCegbnKK1/h/izDfKW3NFpHnTUoMQDBRTjtoXlCGswmaDN7/N9nw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168239-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 168239: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=2c8c230edab57eae6d2e8df7239ef121a45a1443
X-Osstest-Versions-That:
    linux=9137eda53752ef73148e42b0d7640a00f1bc96b1
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 27 Feb 2022 01:04:14 +0000

flight 168239 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168239/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168238
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168238
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168238
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168238
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168238
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168238
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168238
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168238
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                2c8c230edab57eae6d2e8df7239ef121a45a1443
baseline version:
 linux                9137eda53752ef73148e42b0d7640a00f1bc96b1

Last test of basis   168238  2022-02-26 06:58:02 Z    0 days
Testing same since   168239  2022-02-26 19:12:01 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Changbin Du <changbin.du@gmail.com>
  Damien Le Moal <damien.lemoal@opensource.wdc.com>
  Darrick J. Wong <djwong@kernel.org>
  Linus Torvalds <torvalds@linux-foundation.org>
  Palmer Dabbelt <palmer@rivosinc.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   9137eda53752..2c8c230edab5  2c8c230edab57eae6d2e8df7239ef121a45a1443 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Sun Feb 27 08:13:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 27 Feb 2022 08:13:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279892.477688 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOEgM-0008Jn-Rh; Sun, 27 Feb 2022 08:13:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279892.477688; Sun, 27 Feb 2022 08:13:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOEgM-0008Jg-Nv; Sun, 27 Feb 2022 08:13:30 +0000
Received: by outflank-mailman (input) for mailman id 279892;
 Sun, 27 Feb 2022 08:13:29 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nOEgL-0008JW-HH; Sun, 27 Feb 2022 08:13:29 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nOEgL-0003f2-Dh; Sun, 27 Feb 2022 08:13:29 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nOEgK-0006hp-2z; Sun, 27 Feb 2022 08:13:28 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nOEgK-000591-2Y; Sun, 27 Feb 2022 08:13:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=MY7qYzKjhtohs5KD/Z9dEWyr+kjoigxIgfOemnlAv3Q=; b=k3XD/4uSWxE7tZecD44/A45Sge
	5wPbHkyFVLChUFDyVD6kFBpGMjAv/7HuKcHOmw7jo/EmyT5kYXfVsVGsiKLIsT+miWVkftowMV+/Y
	8HXBf4KTmwHXTHamKfab7kISGKBd6JaYlq85ZvY7vswpQ1uNBXKkGTDiM0Ot3tk99Grg=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168240-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 168240: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=2293be58d6a18cab800e25e42081bacb75c05752
X-Osstest-Versions-That:
    linux=2c8c230edab57eae6d2e8df7239ef121a45a1443
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 27 Feb 2022 08:13:28 +0000

flight 168240 linux-linus real [real]
flight 168243 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/168240/
http://logs.test-lab.xenproject.org/osstest/logs/168243/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 168243-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168239
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168239
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168239
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168239
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168239
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168239
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168239
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168239
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                2293be58d6a18cab800e25e42081bacb75c05752
baseline version:
 linux                2c8c230edab57eae6d2e8df7239ef121a45a1443

Last test of basis   168239  2022-02-26 19:12:01 Z    0 days
Testing same since   168240  2022-02-27 01:11:48 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Al Viro <viro@zeniv.linux.org.uk>
  Andrew Morton <akpm@linux-foundation.org>
  Andrey Konovalov <andreyknvl@google.com>
  Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
  Arnaldo Carvalho de Melo <acme@kernel.org>
  Arnaldo Carvalho de Melo <acme@redhat.com>
  Christophe Leroy <christophe.leroy@csgroup.eu>
  Daniel Bristot de Oliveira <bristot@kernel.org>
  David Rientjes <rientjes@google.com>
  Johannes Weiner <hannes@cmpxchg.org>
  Linus Torvalds <torvalds@linux-foundation.org>
  Liu Yuntao <liuyuntao10@huawei.com>
  Luis Chamberlain <mcgrof@kernel.org>
  Masami Hiramatsu <mhiramat@kernel.org>
  Miaohe Lin <linmiaohe@huawei.com>
  Michal Hocko <mhocko@suse.com>
  Mike Kravetz <mike.kravetz@oracle.com>
  Mike Rapoport <rppt@linux.ibm.com>
  Nathan Chancellor <nathan@kernel.org>
  Roman Gushchin <roman.gushchin@linux.dev>
  Shakeel Butt <shakeelb@google.com>
  Steven Rostedt (Google) <rostedt@goodmis.org>
  Suren Baghdasaryan <surenb@google.com>
  Sven Schnelle <svens@linux.ibm.com>
  Tom Zanussi <zanussi@kernel.org>
  Vladimir Davydov <vdavydov.dev@gmail.com>
  Vlastimil Babka <vbabka@suse.cz>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 fail    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   2c8c230edab5..2293be58d6a1  2293be58d6a18cab800e25e42081bacb75c05752 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Sun Feb 27 08:51:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 27 Feb 2022 08:51:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279903.477699 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOFHE-00041f-Ry; Sun, 27 Feb 2022 08:51:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279903.477699; Sun, 27 Feb 2022 08:51:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOFHE-00041Y-Ow; Sun, 27 Feb 2022 08:51:36 +0000
Received: by outflank-mailman (input) for mailman id 279903;
 Sun, 27 Feb 2022 08:51:36 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nOFHD-00041O-Ug; Sun, 27 Feb 2022 08:51:35 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nOFHD-0004Hy-So; Sun, 27 Feb 2022 08:51:35 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nOFHD-0007mK-Fv; Sun, 27 Feb 2022 08:51:35 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nOFHD-0007vT-FS; Sun, 27 Feb 2022 08:51:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=c+V9y4XmYasqaUxaIxvAoVdeMx6ym2mGGymIoWqBbBo=; b=TpY2ekAou9yuJuaufc6QCBginc
	MudRh2Gq4eGaIf+vOLDRz1GCH/ujIixQ8Bh+l9BRGOWM7g+jjQ+PTxQULbMcQCyGEVA5PJFIDbux8
	FJQa/xryJ1BAfsNjurEVDLutM5wiuyigP/8191Ol0NR4VSUn4nCv5ZRoP0rZLrA+Km6M=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168242-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 168242: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=854ea58e4ee9dd5521bfb85df97f75381f617cb3
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 27 Feb 2022 08:51:35 +0000

flight 168242 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168242/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              854ea58e4ee9dd5521bfb85df97f75381f617cb3
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  597 days
Failing since        151818  2020-07-11 04:18:52 Z  596 days  578 attempts
Testing same since   168237  2022-02-26 04:19:42 Z    1 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brad Laue <brad@brad-x.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Christophe Fergeau <cfergeau@redhat.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Divya Garg <divya.garg@nutanix.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Emilio Herrera <ehespinosa57@gmail.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Ivan Teterevkov <ivan.teterevkov@nutanix.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jing Qi <jinqi@redhat.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Kim InSoo <simmon@nplob.com>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Lubomir Rintel <lkundrak@v3.sk>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nicolas Lécureuil <neoclust@mageia.org>
  Nicolas Lécureuil <nicolas.lecureuil@siveo.net>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Rohit Kumar <rohit.kumar3@nutanix.com>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  shenjiatong <yshxxsjt715@gmail.com>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tu Qiang <tu.qiang35@zte.com.cn>
  Tuguoyi <tu.guoyi@h3c.com>
  tuqiang <tu.qiang35@zte.com.cn>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Vineeth Pillai <viremana@linux.microsoft.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yasuhiko Kamata <belphegor@belbel.or.jp>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 99017 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Feb 27 10:05:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 27 Feb 2022 10:05:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279917.477710 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOGQK-0002g3-HJ; Sun, 27 Feb 2022 10:05:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279917.477710; Sun, 27 Feb 2022 10:05:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOGQK-0002fw-ED; Sun, 27 Feb 2022 10:05:04 +0000
Received: by outflank-mailman (input) for mailman id 279917;
 Sun, 27 Feb 2022 10:05:03 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nOGQJ-0002fm-K4; Sun, 27 Feb 2022 10:05:03 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nOGQJ-0005Yx-Gj; Sun, 27 Feb 2022 10:05:03 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nOGQI-0001Gf-S6; Sun, 27 Feb 2022 10:05:02 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nOGQI-0005aB-Rc; Sun, 27 Feb 2022 10:05:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=zV74cKDbVC1atdkXmFXA3mtPhsRIl36uZeRZPqKW5d8=; b=Q5i4ofGtv6id10dYqx+hf0A4sQ
	yyBdaQVyjrwK1520AM7i5XwD+y+V3aGOFZ/0aiIg1eiIR+5sQMGWyW4OXAojuhaUFcrMlTyxAjw6W
	eNvVJ0xNewnzV0JL0lkeLu3aLztw1qG/5kzVUc3mZ9PhGw/xTj+hC/hwf3qPKUuk+u8w=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168241-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 168241: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=10f1f7b010a22d6d4ee67b018412d5f7ea386fc6
X-Osstest-Versions-That:
    xen=10f1f7b010a22d6d4ee67b018412d5f7ea386fc6
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 27 Feb 2022 10:05:02 +0000

flight 168241 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168241/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168236
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168236
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168236
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168236
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168236
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168236
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168236
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168236
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168236
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168236
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168236
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168236
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  10f1f7b010a22d6d4ee67b018412d5f7ea386fc6
baseline version:
 xen                  10f1f7b010a22d6d4ee67b018412d5f7ea386fc6

Last test of basis   168241  2022-02-27 01:52:14 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Sun Feb 27 10:56:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 27 Feb 2022 10:56:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279928.477721 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOHED-0007g1-Dt; Sun, 27 Feb 2022 10:56:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279928.477721; Sun, 27 Feb 2022 10:56:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOHED-0007fu-As; Sun, 27 Feb 2022 10:56:37 +0000
Received: by outflank-mailman (input) for mailman id 279928;
 Sun, 27 Feb 2022 10:56:36 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nOHEC-0007fk-Nl; Sun, 27 Feb 2022 10:56:36 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nOHEC-0006Pc-M2; Sun, 27 Feb 2022 10:56:36 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nOHEC-0002N3-5Z; Sun, 27 Feb 2022 10:56:36 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nOHEC-00089N-59; Sun, 27 Feb 2022 10:56:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=wIr7cZO4D6g6KQuWGZYtvu21VMmFZOsQpH0+YQdrULY=; b=phhBwYVXZT9CzZwP/3LTAPUsmO
	OFInY8fcpU55INFuQnCUVZVVLzjRs5FmcEXNPAvo3xsq2gU9PgdpAZDQds20oxGbgIWDOEMAEGhAX
	dwaiUxUOopDwKFe8+wAzys+4Id4TVrQi9GS4sY792N5/Ev9Sguvl8sp+4IcK1PBcSElw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168244-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-coverity test] 168244: tolerable ALL FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable-coverity:coverity-amd64:coverity-upload:fail:heisenbug
X-Osstest-Versions-This:
    xen=10f1f7b010a22d6d4ee67b018412d5f7ea386fc6
X-Osstest-Versions-That:
    xen=210f27e55abd2a57c01105992bc10bc4d7b8132d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 27 Feb 2022 10:56:36 +0000

flight 168244 xen-unstable-coverity real [real]
flight 168245 xen-unstable-coverity real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/168244/
http://logs.test-lab.xenproject.org/osstest/logs/168245/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 coverity-amd64                7 coverity-upload     fail pass in 168245-retest

version targeted for testing:
 xen                  10f1f7b010a22d6d4ee67b018412d5f7ea386fc6
baseline version:
 xen                  210f27e55abd2a57c01105992bc10bc4d7b8132d

Last test of basis   168204  2022-02-23 09:20:59 Z    4 days
Testing same since   168244  2022-02-27 09:20:56 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Andrew Cooper <andrew.cooper3@citrix.com><mailto:andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Bob Eshleman <bobbyeshleman@gmail.com>
  Dario Faggioli <dfaggioli@suse.com>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Julien Grall <jgrall@amazon.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Mateusz Mówka <mateusz.mowka@intel.com>
  Michal Orzel <michal.orzel@arm.com>
  Thiner Logoer <logoerthiner1@163.com>

jobs:
 coverity-amd64                                               fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   210f27e55a..10f1f7b010  10f1f7b010a22d6d4ee67b018412d5f7ea386fc6 -> coverity-tested/smoke


From xen-devel-bounces@lists.xenproject.org Sun Feb 27 14:31:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 27 Feb 2022 14:31:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279954.477765 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOKa7-0003V9-MM; Sun, 27 Feb 2022 14:31:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279954.477765; Sun, 27 Feb 2022 14:31:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOKa7-0003Uw-Hc; Sun, 27 Feb 2022 14:31:27 +0000
Received: by outflank-mailman (input) for mailman id 279954;
 Sun, 27 Feb 2022 14:31:26 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=jKox=TK=bombadil.srs.infradead.org=BATV+9eb748f383daf30c13ac+6762+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nOKa5-0002ik-U7
 for xen-devel@lists.xenproject.org; Sun, 27 Feb 2022 14:31:26 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f0928821-97d9-11ec-8eba-a37418f5ba1a;
 Sun, 27 Feb 2022 15:31:25 +0100 (CET)
Received: from [213.208.157.39] (helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nOKZu-009Nwk-Uw; Sun, 27 Feb 2022 14:31:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f0928821-97d9-11ec-8eba-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=gVSpX+7KV6wn42digZLX3vAuIC0pBbxisjv1zSfXCt8=; b=xS25Gh/L8q4nvftBwke0WoEuqB
	WZCQlc4/eO5m3CIrFujWVHy7c1ntMcLiIZovb5nZz1QbJ55VmGrJczPFQsviDKqOjrr8CaJV5tk3t
	Xot0RwKQgQN3vFaawuH7zO02hfp/gC13NXkUr0HbpiONgwU1icVk750lH1Zezl7LJZ4supXTzjGYV
	TMOHmImTl28NSLzRp31rAG4SS3rsHr9ROgPrN9gEFW7EiWrxIEL0YuEyz95TNysrz7npSj2Vs9L1+
	rdZF/5LTPPxZSaq/F/NzTfl4m72hXRFfX1gMSaS9dUN0bCXPJmQyuYcTjJHPklOQ8b6/9HfoxeIwe
	teC9G4FQ==;
From: Christoph Hellwig <hch@lst.de>
To: iommu@lists.linux-foundation.org
Cc: x86@kernel.org,
	Anshuman Khandual <anshuman.khandual@arm.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Joerg Roedel <joro@8bytes.org>,
	David Woodhouse <dwmw2@infradead.org>,
	Lu Baolu <baolu.lu@linux.intel.com>,
	Robin Murphy <robin.murphy@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	xen-devel@lists.xenproject.org,
	linux-ia64@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	tboot-devel@lists.sourceforge.net,
	linux-pci@vger.kernel.org
Subject: [PATCH 04/11] swiotlb: rename swiotlb_late_init_with_default_size
Date: Sun, 27 Feb 2022 15:30:48 +0100
Message-Id: <20220227143055.335596-5-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220227143055.335596-1-hch@lst.de>
References: <20220227143055.335596-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

swiotlb_late_init_with_default_size is an overly verbose name that
doesn't even catch what the function is doing, given that the size is
not just a default but the actual requested size.

Rename it to swiotlb_init_late.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>
---
 arch/x86/pci/sta2x11-fixup.c | 2 +-
 include/linux/swiotlb.h      | 2 +-
 kernel/dma/swiotlb.c         | 6 ++----
 3 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/arch/x86/pci/sta2x11-fixup.c b/arch/x86/pci/sta2x11-fixup.c
index 101081ad64b6d..e0c039a75b2db 100644
--- a/arch/x86/pci/sta2x11-fixup.c
+++ b/arch/x86/pci/sta2x11-fixup.c
@@ -57,7 +57,7 @@ static void sta2x11_new_instance(struct pci_dev *pdev)
 		int size = STA2X11_SWIOTLB_SIZE;
 		/* First instance: register your own swiotlb area */
 		dev_info(&pdev->dev, "Using SWIOTLB (size %i)\n", size);
-		if (swiotlb_late_init_with_default_size(size))
+		if (swiotlb_init_late(size))
 			dev_emerg(&pdev->dev, "init swiotlb failed\n");
 	}
 	list_add(&instance->list, &sta2x11_instance_list);
diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h
index 9fb3a568f0c51..b48b26bfa0edb 100644
--- a/include/linux/swiotlb.h
+++ b/include/linux/swiotlb.h
@@ -40,7 +40,7 @@ extern void swiotlb_init(int verbose);
 int swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, int verbose);
 unsigned long swiotlb_size_or_default(void);
 extern int swiotlb_late_init_with_tbl(char *tlb, unsigned long nslabs);
-extern int swiotlb_late_init_with_default_size(size_t default_size);
+int swiotlb_init_late(size_t size);
 extern void __init swiotlb_update_mem_attributes(void);
 
 phys_addr_t swiotlb_tbl_map_single(struct device *hwdev, phys_addr_t phys,
diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c
index 519e363097190..5f64b02fbb732 100644
--- a/kernel/dma/swiotlb.c
+++ b/kernel/dma/swiotlb.c
@@ -290,11 +290,9 @@ swiotlb_init(int verbose)
  * initialize the swiotlb later using the slab allocator if needed.
  * This should be just like above, but with some error catching.
  */
-int
-swiotlb_late_init_with_default_size(size_t default_size)
+int swiotlb_init_late(size_t size)
 {
-	unsigned long nslabs =
-		ALIGN(default_size >> IO_TLB_SHIFT, IO_TLB_SEGSIZE);
+	unsigned long nslabs = ALIGN(size >> IO_TLB_SHIFT, IO_TLB_SEGSIZE);
 	unsigned long bytes;
 	unsigned char *vstart = NULL;
 	unsigned int order;
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Sun Feb 27 14:31:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 27 Feb 2022 14:31:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279951.477732 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOKa2-0002j2-Rn; Sun, 27 Feb 2022 14:31:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279951.477732; Sun, 27 Feb 2022 14:31:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOKa2-0002iu-Oh; Sun, 27 Feb 2022 14:31:22 +0000
Received: by outflank-mailman (input) for mailman id 279951;
 Sun, 27 Feb 2022 14:31:21 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=jKox=TK=bombadil.srs.infradead.org=BATV+9eb748f383daf30c13ac+6762+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nOKZz-0002ie-VM
 for xen-devel@lists.xenproject.org; Sun, 27 Feb 2022 14:31:20 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id eb0b1ff1-97d9-11ec-8539-5f4723681683;
 Sun, 27 Feb 2022 15:31:16 +0100 (CET)
Received: from [213.208.157.39] (helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nOKZe-009NtN-G3; Sun, 27 Feb 2022 14:30:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: eb0b1ff1-97d9-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:
	Content-ID:Content-Description:In-Reply-To:References;
	bh=A05LVfYU2PEONzsS8Gc05/y0YX3f/s4+nAdtFiYFaPA=; b=MYjz99MEZpXYXZ+u/hPXwH/5VL
	VfsjwWWbuKCw7zshSoI+auf/yLifEcY/XE1DJRFtz3VxuS31UllEfuuBvuYyI0R62c4l0m9SjGj0a
	WGByXvlVvb4GlpMZgQZ/bHMpyjRMYTs0vyxZOS1rHRz9lghF2LWQbtukyT+tPh4vCHeGeC/AcmY98
	WuPu16zN8JjBDp4ZENXRc9jSpBUvW+n6Sq1vNfMv9rubVC7W2JwfnAylwXOQV0dZC32gjZLT10dhi
	Ws7JHUh8ywEv+8gXM1ulZ+IZIGPfH8AiNbDzJ4upQZLKpO5YOSuave3h2BfqRd4XiSg8EOVVaK+3v
	hog6QeMw==;
From: Christoph Hellwig <hch@lst.de>
To: iommu@lists.linux-foundation.org
Cc: x86@kernel.org,
	Anshuman Khandual <anshuman.khandual@arm.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Joerg Roedel <joro@8bytes.org>,
	David Woodhouse <dwmw2@infradead.org>,
	Lu Baolu <baolu.lu@linux.intel.com>,
	Robin Murphy <robin.murphy@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	xen-devel@lists.xenproject.org,
	linux-ia64@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	tboot-devel@lists.sourceforge.net,
	linux-pci@vger.kernel.org
Subject: cleanup swiotlb initialization v2
Date: Sun, 27 Feb 2022 15:30:44 +0100
Message-Id: <20220227143055.335596-1-hch@lst.de>
X-Mailer: git-send-email 2.30.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Hi all,

this series tries to clean up the swiotlb initialization, including
that of swiotlb-xen.  To get there is also removes the x86 iommu table
infrastructure that massively obsfucates the initialization path.

Git tree:

    git://git.infradead.org/users/hch/misc.git swiotlb-init-cleanup

Gitweb:

    http://git.infradead.org/users/hch/misc.git/shortlog/refs/heads/swiotlb-init-cleanup

Changes since v1:
 - skip IOMMU initialization on Xen PV kernels
 - various small whitespace / typo fixes

Diffstat:
 arch/ia64/include/asm/iommu_table.h      |    7 -
 arch/x86/include/asm/iommu_table.h       |  102 -------------------
 arch/x86/include/asm/swiotlb.h           |   30 -----
 arch/x86/kernel/pci-iommu_table.c        |   77 --------------
 arch/x86/kernel/pci-swiotlb.c            |   77 --------------
 arch/x86/xen/pci-swiotlb-xen.c           |   96 ------------------
 b/arch/arm/mm/init.c                     |    6 -
 b/arch/arm/xen/mm.c                      |   23 ++--
 b/arch/arm64/mm/init.c                   |    6 -
 b/arch/ia64/mm/init.c                    |    4 
 b/arch/mips/cavium-octeon/dma-octeon.c   |   15 --
 b/arch/mips/loongson64/dma.c             |    2 
 b/arch/mips/pci/pci-octeon.c             |    2 
 b/arch/mips/sibyte/common/dma.c          |    2 
 b/arch/powerpc/include/asm/svm.h         |    4 
 b/arch/powerpc/include/asm/swiotlb.h     |    1 
 b/arch/powerpc/mm/mem.c                  |    6 -
 b/arch/powerpc/platforms/pseries/setup.c |    3 
 b/arch/powerpc/platforms/pseries/svm.c   |   26 ----
 b/arch/riscv/mm/init.c                   |    8 -
 b/arch/s390/mm/init.c                    |    3 
 b/arch/x86/include/asm/dma-mapping.h     |   12 --
 b/arch/x86/include/asm/gart.h            |    5 
 b/arch/x86/include/asm/iommu.h           |    8 +
 b/arch/x86/include/asm/xen/page.h        |    5 
 b/arch/x86/include/asm/xen/swiotlb-xen.h |    2 
 b/arch/x86/kernel/Makefile               |    2 
 b/arch/x86/kernel/amd_gart_64.c          |    5 
 b/arch/x86/kernel/aperture_64.c          |   14 --
 b/arch/x86/kernel/cpu/mshyperv.c         |    8 -
 b/arch/x86/kernel/pci-dma.c              |  109 ++++++++++++++++----
 b/arch/x86/kernel/tboot.c                |    1 
 b/arch/x86/kernel/vmlinux.lds.S          |   12 --
 b/arch/x86/mm/mem_encrypt_amd.c          |    3 
 b/arch/x86/pci/sta2x11-fixup.c           |    2 
 b/arch/x86/xen/Makefile                  |    2 
 b/drivers/iommu/amd/init.c               |    6 -
 b/drivers/iommu/amd/iommu.c              |    5 
 b/drivers/iommu/intel/dmar.c             |    6 -
 b/drivers/xen/swiotlb-xen.c              |  132 -------------------------
 b/include/linux/dmar.h                   |    6 -
 b/include/linux/swiotlb.h                |   22 ++--
 b/include/trace/events/swiotlb.h         |   29 +----
 b/include/xen/arm/page.h                 |    1 
 b/include/xen/swiotlb-xen.h              |    8 +
 b/kernel/dma/direct.h                    |    2 
 b/kernel/dma/swiotlb.c                   |  163 +++++++++++++++----------------
 47 files changed, 253 insertions(+), 817 deletions(-)


From xen-devel-bounces@lists.xenproject.org Sun Feb 27 14:31:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 27 Feb 2022 14:31:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279953.477747 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOKa4-00031R-Bt; Sun, 27 Feb 2022 14:31:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279953.477747; Sun, 27 Feb 2022 14:31:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOKa4-00030I-7z; Sun, 27 Feb 2022 14:31:24 +0000
Received: by outflank-mailman (input) for mailman id 279953;
 Sun, 27 Feb 2022 14:31:22 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=jKox=TK=bombadil.srs.infradead.org=BATV+9eb748f383daf30c13ac+6762+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nOKa2-0002ik-JY
 for xen-devel@lists.xenproject.org; Sun, 27 Feb 2022 14:31:22 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ebc18f39-97d9-11ec-8eba-a37418f5ba1a;
 Sun, 27 Feb 2022 15:31:19 +0100 (CET)
Received: from [213.208.157.39] (helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nOKZk-009NuE-Cz; Sun, 27 Feb 2022 14:31:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ebc18f39-97d9-11ec-8eba-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=+WiBOXA0MRDZn1kqTV3ww0Ba1VAfcBaU/VHzqZHaxWQ=; b=UcMvfw8PmtRTqsFC3KR7eGE16Z
	ScdqwnvCgitmv45Q5ry3OAtO9pAZicvl9XYX8rtjmHIqsoPld+fqpCFXgiJWUTVNQXrtRr5+gJ7G9
	zNDGvmhjJvotR5KJmi+LerfiLBEJ8+g/DV8hmCvfEcASMbpdUSh3+Ys0hMCj0wzEo22LHDc5AFJm3
	460k5swhB+imd2zecCUtx/NDpMxrE8s8/T/tQZp56g/hNMchq2zBI1AwK8BJ9KguClDyChdet3gjn
	MlZpKgk5YExrCKU0+vtPE1aDMIW2Hw5Nk4N8c/3a/rZIJTo3dD7J9ofdhbwHjFQZ6o6APbGFVdnMk
	lx+LUO+Q==;
From: Christoph Hellwig <hch@lst.de>
To: iommu@lists.linux-foundation.org
Cc: x86@kernel.org,
	Anshuman Khandual <anshuman.khandual@arm.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Joerg Roedel <joro@8bytes.org>,
	David Woodhouse <dwmw2@infradead.org>,
	Lu Baolu <baolu.lu@linux.intel.com>,
	Robin Murphy <robin.murphy@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	xen-devel@lists.xenproject.org,
	linux-ia64@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	tboot-devel@lists.sourceforge.net,
	linux-pci@vger.kernel.org
Subject: [PATCH 02/11] swiotlb: make swiotlb_exit a no-op if SWIOTLB_FORCE is set
Date: Sun, 27 Feb 2022 15:30:46 +0100
Message-Id: <20220227143055.335596-3-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220227143055.335596-1-hch@lst.de>
References: <20220227143055.335596-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

If force bouncing is enabled we can't release the buffers.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>
---
 kernel/dma/swiotlb.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c
index f1e7ea160b433..36fbf1181d285 100644
--- a/kernel/dma/swiotlb.c
+++ b/kernel/dma/swiotlb.c
@@ -378,6 +378,9 @@ void __init swiotlb_exit(void)
 	unsigned long tbl_vaddr;
 	size_t tbl_size, slots_size;
 
+	if (swiotlb_force == SWIOTLB_FORCE)
+		return;
+
 	if (!mem->nslabs)
 		return;
 
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Sun Feb 27 14:31:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 27 Feb 2022 14:31:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279955.477776 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOKaC-0003tA-W5; Sun, 27 Feb 2022 14:31:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279955.477776; Sun, 27 Feb 2022 14:31:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOKaC-0003t1-Rx; Sun, 27 Feb 2022 14:31:32 +0000
Received: by outflank-mailman (input) for mailman id 279955;
 Sun, 27 Feb 2022 14:31:31 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=jKox=TK=bombadil.srs.infradead.org=BATV+9eb748f383daf30c13ac+6762+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nOKaB-0002ie-M1
 for xen-devel@lists.xenproject.org; Sun, 27 Feb 2022 14:31:31 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f4156650-97d9-11ec-8539-5f4723681683;
 Sun, 27 Feb 2022 15:31:31 +0100 (CET)
Received: from [213.208.157.39] (helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nOKZy-009Nyh-As; Sun, 27 Feb 2022 14:31:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f4156650-97d9-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=EOKl3QOewLIjf0ZNmcnzTQ4FZFAHUeZ7HEyWrW0JICI=; b=VUPEtA7V1kUXdEQLXDATMWGPWl
	B8DR/5fTzGbOotY2kYTIvMBdMiEigGK5KA/dEOClSNYxjT355jLQFUFXUab6e/Pbv6scABIiEjBKu
	eRCXfdOZejOc9Q1Caj3SkYhqZSP0u48gwi72tuNMLXnVoFf3AuDrW/me+5SXfOwfFnJy2icKFabfD
	KgRqf9ucOjLQxS0fC0FogpnUSM7GvHoBCfhlifa1X+9qAdn91vh4MqyNcheVpWp4rnvs8nlwT2nem
	psc3GVSj5A/xheKnzeUaF+be0MRC5VAU7YZBD0dJ80cj7PRNsT7rvL3v9Fvy0Cp42uHab+x47KiA3
	GgNBOBUA==;
From: Christoph Hellwig <hch@lst.de>
To: iommu@lists.linux-foundation.org
Cc: x86@kernel.org,
	Anshuman Khandual <anshuman.khandual@arm.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Joerg Roedel <joro@8bytes.org>,
	David Woodhouse <dwmw2@infradead.org>,
	Lu Baolu <baolu.lu@linux.intel.com>,
	Robin Murphy <robin.murphy@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	xen-devel@lists.xenproject.org,
	linux-ia64@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	tboot-devel@lists.sourceforge.net,
	linux-pci@vger.kernel.org
Subject: [PATCH 05/11] swiotlb: pass a gfp_mask argument to swiotlb_init_late
Date: Sun, 27 Feb 2022 15:30:49 +0100
Message-Id: <20220227143055.335596-6-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220227143055.335596-1-hch@lst.de>
References: <20220227143055.335596-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Let the caller chose a zone to allocate from.  This will be used
later on by the xen-swiotlb initialization on arm.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>
---
 arch/x86/pci/sta2x11-fixup.c | 2 +-
 include/linux/swiotlb.h      | 2 +-
 kernel/dma/swiotlb.c         | 4 ++--
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/x86/pci/sta2x11-fixup.c b/arch/x86/pci/sta2x11-fixup.c
index e0c039a75b2db..c7e6faf59a861 100644
--- a/arch/x86/pci/sta2x11-fixup.c
+++ b/arch/x86/pci/sta2x11-fixup.c
@@ -57,7 +57,7 @@ static void sta2x11_new_instance(struct pci_dev *pdev)
 		int size = STA2X11_SWIOTLB_SIZE;
 		/* First instance: register your own swiotlb area */
 		dev_info(&pdev->dev, "Using SWIOTLB (size %i)\n", size);
-		if (swiotlb_init_late(size))
+		if (swiotlb_init_late(size, GFP_DMA))
 			dev_emerg(&pdev->dev, "init swiotlb failed\n");
 	}
 	list_add(&instance->list, &sta2x11_instance_list);
diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h
index b48b26bfa0edb..1befd6b2ccf5e 100644
--- a/include/linux/swiotlb.h
+++ b/include/linux/swiotlb.h
@@ -40,7 +40,7 @@ extern void swiotlb_init(int verbose);
 int swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, int verbose);
 unsigned long swiotlb_size_or_default(void);
 extern int swiotlb_late_init_with_tbl(char *tlb, unsigned long nslabs);
-int swiotlb_init_late(size_t size);
+int swiotlb_init_late(size_t size, gfp_t gfp_mask);
 extern void __init swiotlb_update_mem_attributes(void);
 
 phys_addr_t swiotlb_tbl_map_single(struct device *hwdev, phys_addr_t phys,
diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c
index 5f64b02fbb732..a653fcf1fe6c2 100644
--- a/kernel/dma/swiotlb.c
+++ b/kernel/dma/swiotlb.c
@@ -290,7 +290,7 @@ swiotlb_init(int verbose)
  * initialize the swiotlb later using the slab allocator if needed.
  * This should be just like above, but with some error catching.
  */
-int swiotlb_init_late(size_t size)
+int swiotlb_init_late(size_t size, gfp_t gfp_mask)
 {
 	unsigned long nslabs = ALIGN(size >> IO_TLB_SHIFT, IO_TLB_SEGSIZE);
 	unsigned long bytes;
@@ -309,7 +309,7 @@ int swiotlb_init_late(size_t size)
 	bytes = nslabs << IO_TLB_SHIFT;
 
 	while ((SLABS_PER_PAGE << order) > IO_TLB_MIN_SLABS) {
-		vstart = (void *)__get_free_pages(GFP_DMA | __GFP_NOWARN,
+		vstart = (void *)__get_free_pages(gfp_mask | __GFP_NOWARN,
 						  order);
 		if (vstart)
 			break;
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Sun Feb 27 14:31:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 27 Feb 2022 14:31:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279952.477742 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOKa4-0002yV-2z; Sun, 27 Feb 2022 14:31:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279952.477742; Sun, 27 Feb 2022 14:31:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOKa3-0002yO-W6; Sun, 27 Feb 2022 14:31:23 +0000
Received: by outflank-mailman (input) for mailman id 279952;
 Sun, 27 Feb 2022 14:31:22 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=jKox=TK=bombadil.srs.infradead.org=BATV+9eb748f383daf30c13ac+6762+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nOKa2-0002ie-9f
 for xen-devel@lists.xenproject.org; Sun, 27 Feb 2022 14:31:22 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ee77a0b8-97d9-11ec-8539-5f4723681683;
 Sun, 27 Feb 2022 15:31:21 +0100 (CET)
Received: from [213.208.157.39] (helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nOKZq-009Nur-9E; Sun, 27 Feb 2022 14:31:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ee77a0b8-97d9-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=S8rL5r6CVieQSVcTz72mVZA1dTrwukBQ7UxroweHdXM=; b=TmJNvjFSewtYWBr07EHo8a1WwA
	8e4I78/K50tproBTCfhYD6iRK1G6UAv1A6Rup/LoZsEsEUQE9OdlHXx4jz7jhRyNzXaQtiVFKlupt
	a2hGvZ4aqXvIr1yj57HcCRUt65RO1+Y5wozGU5i4Z+jrTVcR/2s9BDbFJzUITh9decsl8OkwX+TI4
	xyhztZrj+xPANoAVZ61PdUT+mxMalQcYiDsCn0GIahnvB1rVuihkl2a5cyicVFHeMavSBVSpLMnz6
	VHxJC+B1OeUcyn68Iz+B0pyY23J2t7U4tBFoigOIWko50r9hiWnG0mBx9qZO6X4rJTVWF8zxJf5B5
	y/jM9GUQ==;
From: Christoph Hellwig <hch@lst.de>
To: iommu@lists.linux-foundation.org
Cc: x86@kernel.org,
	Anshuman Khandual <anshuman.khandual@arm.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Joerg Roedel <joro@8bytes.org>,
	David Woodhouse <dwmw2@infradead.org>,
	Lu Baolu <baolu.lu@linux.intel.com>,
	Robin Murphy <robin.murphy@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	xen-devel@lists.xenproject.org,
	linux-ia64@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	tboot-devel@lists.sourceforge.net,
	linux-pci@vger.kernel.org
Subject: [PATCH 03/11] swiotlb: simplify swiotlb_max_segment
Date: Sun, 27 Feb 2022 15:30:47 +0100
Message-Id: <20220227143055.335596-4-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220227143055.335596-1-hch@lst.de>
References: <20220227143055.335596-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Remove the bogus Xen override that was usually larger than the actual
size and just calculate the value on demand.  Note that
swiotlb_max_segment still doesn't make sense as an interface and should
eventually be removed.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>
---
 drivers/xen/swiotlb-xen.c |  2 --
 include/linux/swiotlb.h   |  1 -
 kernel/dma/swiotlb.c      | 20 +++-----------------
 3 files changed, 3 insertions(+), 20 deletions(-)

diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c
index 47aebd98f52f5..485cd06ed39e7 100644
--- a/drivers/xen/swiotlb-xen.c
+++ b/drivers/xen/swiotlb-xen.c
@@ -202,7 +202,6 @@ int xen_swiotlb_init(void)
 	rc = swiotlb_late_init_with_tbl(start, nslabs);
 	if (rc)
 		return rc;
-	swiotlb_set_max_segment(PAGE_SIZE);
 	return 0;
 error:
 	if (nslabs > 1024 && repeat--) {
@@ -254,7 +253,6 @@ void __init xen_swiotlb_init_early(void)
 
 	if (swiotlb_init_with_tbl(start, nslabs, true))
 		panic("Cannot allocate SWIOTLB buffer");
-	swiotlb_set_max_segment(PAGE_SIZE);
 }
 #endif /* CONFIG_X86 */
 
diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h
index f6c3638255d54..9fb3a568f0c51 100644
--- a/include/linux/swiotlb.h
+++ b/include/linux/swiotlb.h
@@ -164,7 +164,6 @@ static inline void swiotlb_adjust_size(unsigned long size)
 #endif /* CONFIG_SWIOTLB */
 
 extern void swiotlb_print_info(void);
-extern void swiotlb_set_max_segment(unsigned int);
 
 #ifdef CONFIG_DMA_RESTRICTED_POOL
 struct page *swiotlb_alloc(struct device *dev, size_t size);
diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c
index 36fbf1181d285..519e363097190 100644
--- a/kernel/dma/swiotlb.c
+++ b/kernel/dma/swiotlb.c
@@ -75,12 +75,6 @@ struct io_tlb_mem io_tlb_default_mem;
 
 phys_addr_t swiotlb_unencrypted_base;
 
-/*
- * Max segment that we can provide which (if pages are contingous) will
- * not be bounced (unless SWIOTLB_FORCE is set).
- */
-static unsigned int max_segment;
-
 static unsigned long default_nslabs = IO_TLB_DEFAULT_SIZE >> IO_TLB_SHIFT;
 
 static int __init
@@ -104,18 +98,12 @@ early_param("swiotlb", setup_io_tlb_npages);
 
 unsigned int swiotlb_max_segment(void)
 {
-	return io_tlb_default_mem.nslabs ? max_segment : 0;
+	if (!io_tlb_default_mem.nslabs)
+		return 0;
+	return rounddown(io_tlb_default_mem.nslabs << IO_TLB_SHIFT, PAGE_SIZE);
 }
 EXPORT_SYMBOL_GPL(swiotlb_max_segment);
 
-void swiotlb_set_max_segment(unsigned int val)
-{
-	if (swiotlb_force == SWIOTLB_FORCE)
-		max_segment = 1;
-	else
-		max_segment = rounddown(val, PAGE_SIZE);
-}
-
 unsigned long swiotlb_size_or_default(void)
 {
 	return default_nslabs << IO_TLB_SHIFT;
@@ -267,7 +255,6 @@ int __init swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, int verbose)
 
 	if (verbose)
 		swiotlb_print_info();
-	swiotlb_set_max_segment(mem->nslabs << IO_TLB_SHIFT);
 	return 0;
 }
 
@@ -368,7 +355,6 @@ swiotlb_late_init_with_tbl(char *tlb, unsigned long nslabs)
 	swiotlb_init_io_tlb_mem(mem, virt_to_phys(tlb), nslabs, true);
 
 	swiotlb_print_info();
-	swiotlb_set_max_segment(mem->nslabs << IO_TLB_SHIFT);
 	return 0;
 }
 
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Sun Feb 27 14:31:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 27 Feb 2022 14:31:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279956.477787 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOKaG-0004Ep-77; Sun, 27 Feb 2022 14:31:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279956.477787; Sun, 27 Feb 2022 14:31:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOKaG-0004Ef-3U; Sun, 27 Feb 2022 14:31:36 +0000
Received: by outflank-mailman (input) for mailman id 279956;
 Sun, 27 Feb 2022 14:31:34 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=jKox=TK=bombadil.srs.infradead.org=BATV+9eb748f383daf30c13ac+6762+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nOKaE-0002ie-PT
 for xen-devel@lists.xenproject.org; Sun, 27 Feb 2022 14:31:34 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f5ea2ddb-97d9-11ec-8539-5f4723681683;
 Sun, 27 Feb 2022 15:31:34 +0100 (CET)
Received: from [213.208.157.39] (helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nOKa2-009O0e-Fb; Sun, 27 Feb 2022 14:31:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f5ea2ddb-97d9-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=2LuLtS1efSBZ06JRKs3rwu/XDIHFFEkeBlwKrISdqYE=; b=B0tNho3So6ibMdJaKnw+MR/zzf
	auJa86nzZ0hX+C2umlQDX3eiwUc6f5zR1U7xbRSvDrAEntVHQEtfSYtlEIV8BnSDd7gEz2TpAInM6
	4Ul3cG03Nzvg0ZxHhOFfhNoYZUXMH3JTVN4rUAvOggj2OvD3jthqE7T37aNi+t3rDN9Gk7mw+TSwe
	DmGa/1VUOy5wE+TwfKa2AvrZ9i3DAKf2GZWvEcD9hWgqdV9keOr/5OWzYo7H2JYw+m/kK1l47rk1Y
	7XEF46Dp/b24BRonRQEurSPJujQsm1ayykJNknGOKP2ZJui2HzgS1uVDWSyxTVi3iYcGAoh1LnpKT
	AKxlXENw==;
From: Christoph Hellwig <hch@lst.de>
To: iommu@lists.linux-foundation.org
Cc: x86@kernel.org,
	Anshuman Khandual <anshuman.khandual@arm.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Joerg Roedel <joro@8bytes.org>,
	David Woodhouse <dwmw2@infradead.org>,
	Lu Baolu <baolu.lu@linux.intel.com>,
	Robin Murphy <robin.murphy@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	xen-devel@lists.xenproject.org,
	linux-ia64@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	tboot-devel@lists.sourceforge.net,
	linux-pci@vger.kernel.org
Subject: [PATCH 06/11] MIPS/octeon: use swiotlb_init instead of open coding it
Date: Sun, 27 Feb 2022 15:30:50 +0100
Message-Id: <20220227143055.335596-7-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220227143055.335596-1-hch@lst.de>
References: <20220227143055.335596-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Use the generic swiotlb initialization helper instead of open coding it.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 arch/mips/cavium-octeon/dma-octeon.c | 15 ++-------------
 arch/mips/pci/pci-octeon.c           |  2 +-
 2 files changed, 3 insertions(+), 14 deletions(-)

diff --git a/arch/mips/cavium-octeon/dma-octeon.c b/arch/mips/cavium-octeon/dma-octeon.c
index df70308db0e69..fb7547e217263 100644
--- a/arch/mips/cavium-octeon/dma-octeon.c
+++ b/arch/mips/cavium-octeon/dma-octeon.c
@@ -186,15 +186,12 @@ phys_addr_t dma_to_phys(struct device *dev, dma_addr_t daddr)
 	return daddr;
 }
 
-char *octeon_swiotlb;
-
 void __init plat_swiotlb_setup(void)
 {
 	phys_addr_t start, end;
 	phys_addr_t max_addr;
 	phys_addr_t addr_size;
 	size_t swiotlbsize;
-	unsigned long swiotlb_nslabs;
 	u64 i;
 
 	max_addr = 0;
@@ -236,15 +233,7 @@ void __init plat_swiotlb_setup(void)
 	if (OCTEON_IS_OCTEON2() && max_addr >= 0x100000000ul)
 		swiotlbsize = 64 * (1<<20);
 #endif
-	swiotlb_nslabs = swiotlbsize >> IO_TLB_SHIFT;
-	swiotlb_nslabs = ALIGN(swiotlb_nslabs, IO_TLB_SEGSIZE);
-	swiotlbsize = swiotlb_nslabs << IO_TLB_SHIFT;
-
-	octeon_swiotlb = memblock_alloc_low(swiotlbsize, PAGE_SIZE);
-	if (!octeon_swiotlb)
-		panic("%s: Failed to allocate %zu bytes align=%lx\n",
-		      __func__, swiotlbsize, PAGE_SIZE);
 
-	if (swiotlb_init_with_tbl(octeon_swiotlb, swiotlb_nslabs, 1) == -ENOMEM)
-		panic("Cannot allocate SWIOTLB buffer");
+	swiotlb_adjust_size(swiotlbsize);
+	swiotlb_init(1);
 }
diff --git a/arch/mips/pci/pci-octeon.c b/arch/mips/pci/pci-octeon.c
index fc29b85cfa926..e457a18cbdc59 100644
--- a/arch/mips/pci/pci-octeon.c
+++ b/arch/mips/pci/pci-octeon.c
@@ -664,7 +664,7 @@ static int __init octeon_pci_setup(void)
 
 		/* BAR1 movable regions contiguous to cover the swiotlb */
 		octeon_bar1_pci_phys =
-			virt_to_phys(octeon_swiotlb) & ~((1ull << 22) - 1);
+			io_tlb_default_mem.start & ~((1ull << 22) - 1);
 
 		for (index = 0; index < 32; index++) {
 			union cvmx_pci_bar1_indexx bar1_index;
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Sun Feb 27 14:31:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 27 Feb 2022 14:31:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279957.477798 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOKaR-000532-Lx; Sun, 27 Feb 2022 14:31:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279957.477798; Sun, 27 Feb 2022 14:31:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOKaR-00052o-IJ; Sun, 27 Feb 2022 14:31:47 +0000
Received: by outflank-mailman (input) for mailman id 279957;
 Sun, 27 Feb 2022 14:31:46 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=jKox=TK=bombadil.srs.infradead.org=BATV+9eb748f383daf30c13ac+6762+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nOKaQ-0002ik-61
 for xen-devel@lists.xenproject.org; Sun, 27 Feb 2022 14:31:46 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id fbd37e24-97d9-11ec-8eba-a37418f5ba1a;
 Sun, 27 Feb 2022 15:31:44 +0100 (CET)
Received: from [213.208.157.39] (helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nOKa8-009O3e-Qj; Sun, 27 Feb 2022 14:31:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fbd37e24-97d9-11ec-8eba-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=b75km5KmX6ouQa9QUEF1IuyVI05MMXFb1fyxs1aBLOE=; b=ZTE52Q5CLZI0adoycwdy+zvmHh
	hxwX23wsRvw+s0e0tLhk9WTRLxF03ZtWOAMOqJiC1aHQE/Efrkp3vOgyhbfTWktByxWbT767Ea+nf
	QhHMLYzWHEqX6vQlX1y1Yko1Wqv0PG5foZjnimY5IkkPNfDB4QOg0LrtiNUvkCSwAFPpqhmTV7AJ6
	ouKVtx1nku/BKsMgIg3CIyzsHRz3lHWIuurmS1YYsIXOLH0XlvV3I/6qS3iPHxnF1fmMBkyk4ACMD
	/L4s3R9XgFAiNOr7ZOMhjubjCbO0rKgc0uF8C/3JljpmEvT4Yw1nLE9bQKgTYSiXkZn0G9eUv3Ot3
	MNZSrOIQ==;
From: Christoph Hellwig <hch@lst.de>
To: iommu@lists.linux-foundation.org
Cc: x86@kernel.org,
	Anshuman Khandual <anshuman.khandual@arm.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Joerg Roedel <joro@8bytes.org>,
	David Woodhouse <dwmw2@infradead.org>,
	Lu Baolu <baolu.lu@linux.intel.com>,
	Robin Murphy <robin.murphy@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	xen-devel@lists.xenproject.org,
	linux-ia64@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	tboot-devel@lists.sourceforge.net,
	linux-pci@vger.kernel.org
Subject: [PATCH 07/11] x86: remove the IOMMU table infrastructure
Date: Sun, 27 Feb 2022 15:30:51 +0100
Message-Id: <20220227143055.335596-8-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220227143055.335596-1-hch@lst.de>
References: <20220227143055.335596-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

The IOMMU table tries to separate the different IOMMUs into different
backends, but actually requires various cross calls.

Rewrite the code to do the generic swiotlb/swiotlb-xen setup directly
in pci-dma.c and then just call into the IOMMU drivers.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 arch/ia64/include/asm/iommu_table.h    |   7 --
 arch/x86/include/asm/dma-mapping.h     |   1 -
 arch/x86/include/asm/gart.h            |   5 +-
 arch/x86/include/asm/iommu.h           |   6 ++
 arch/x86/include/asm/iommu_table.h     | 102 -----------------------
 arch/x86/include/asm/swiotlb.h         |  30 -------
 arch/x86/include/asm/xen/swiotlb-xen.h |   2 -
 arch/x86/kernel/Makefile               |   2 -
 arch/x86/kernel/amd_gart_64.c          |   5 +-
 arch/x86/kernel/aperture_64.c          |  14 ++--
 arch/x86/kernel/pci-dma.c              | 111 ++++++++++++++++++++-----
 arch/x86/kernel/pci-iommu_table.c      |  77 -----------------
 arch/x86/kernel/pci-swiotlb.c          |  77 -----------------
 arch/x86/kernel/tboot.c                |   1 -
 arch/x86/kernel/vmlinux.lds.S          |  12 ---
 arch/x86/xen/Makefile                  |   2 -
 arch/x86/xen/pci-swiotlb-xen.c         |  96 ---------------------
 drivers/iommu/amd/init.c               |   6 --
 drivers/iommu/amd/iommu.c              |   5 +-
 drivers/iommu/intel/dmar.c             |   6 +-
 include/linux/dmar.h                   |   6 +-
 21 files changed, 114 insertions(+), 459 deletions(-)
 delete mode 100644 arch/ia64/include/asm/iommu_table.h
 delete mode 100644 arch/x86/include/asm/iommu_table.h
 delete mode 100644 arch/x86/include/asm/swiotlb.h
 delete mode 100644 arch/x86/kernel/pci-iommu_table.c
 delete mode 100644 arch/x86/kernel/pci-swiotlb.c
 delete mode 100644 arch/x86/xen/pci-swiotlb-xen.c

diff --git a/arch/ia64/include/asm/iommu_table.h b/arch/ia64/include/asm/iommu_table.h
deleted file mode 100644
index cc96116ac276a..0000000000000
--- a/arch/ia64/include/asm/iommu_table.h
+++ /dev/null
@@ -1,7 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0 */
-#ifndef _ASM_IA64_IOMMU_TABLE_H
-#define _ASM_IA64_IOMMU_TABLE_H
-
-#define IOMMU_INIT_POST(_detect)
-
-#endif /* _ASM_IA64_IOMMU_TABLE_H */
diff --git a/arch/x86/include/asm/dma-mapping.h b/arch/x86/include/asm/dma-mapping.h
index bb1654fe0ce74..256fd8115223d 100644
--- a/arch/x86/include/asm/dma-mapping.h
+++ b/arch/x86/include/asm/dma-mapping.h
@@ -9,7 +9,6 @@
 
 #include <linux/scatterlist.h>
 #include <asm/io.h>
-#include <asm/swiotlb.h>
 
 extern int iommu_merge;
 extern int panic_on_overflow;
diff --git a/arch/x86/include/asm/gart.h b/arch/x86/include/asm/gart.h
index 3185565743459..5af8088a10df6 100644
--- a/arch/x86/include/asm/gart.h
+++ b/arch/x86/include/asm/gart.h
@@ -38,7 +38,7 @@ extern int gart_iommu_aperture_disabled;
 extern void early_gart_iommu_check(void);
 extern int gart_iommu_init(void);
 extern void __init gart_parse_options(char *);
-extern int gart_iommu_hole_init(void);
+void gart_iommu_hole_init(void);
 
 #else
 #define gart_iommu_aperture            0
@@ -51,9 +51,8 @@ static inline void early_gart_iommu_check(void)
 static inline void gart_parse_options(char *options)
 {
 }
-static inline int gart_iommu_hole_init(void)
+static inline void gart_iommu_hole_init(void)
 {
-	return -ENODEV;
 }
 #endif
 
diff --git a/arch/x86/include/asm/iommu.h b/arch/x86/include/asm/iommu.h
index bf1ed2ddc74bd..dba89ed40d38d 100644
--- a/arch/x86/include/asm/iommu.h
+++ b/arch/x86/include/asm/iommu.h
@@ -9,6 +9,12 @@
 extern int force_iommu, no_iommu;
 extern int iommu_detected;
 
+#ifdef CONFIG_SWIOTLB
+extern bool x86_swiotlb_enable;
+#else
+#define x86_swiotlb_enable false
+#endif
+
 /* 10 seconds */
 #define DMAR_OPERATION_TIMEOUT ((cycles_t) tsc_khz*10*1000)
 
diff --git a/arch/x86/include/asm/iommu_table.h b/arch/x86/include/asm/iommu_table.h
deleted file mode 100644
index 1fb3fd1a83c25..0000000000000
--- a/arch/x86/include/asm/iommu_table.h
+++ /dev/null
@@ -1,102 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0 */
-#ifndef _ASM_X86_IOMMU_TABLE_H
-#define _ASM_X86_IOMMU_TABLE_H
-
-#include <asm/swiotlb.h>
-
-/*
- * History lesson:
- * The execution chain of IOMMUs in 2.6.36 looks as so:
- *
- *            [xen-swiotlb]
- *                 |
- *         +----[swiotlb *]--+
- *        /         |         \
- *       /          |          \
- *    [GART]     [Calgary]  [Intel VT-d]
- *     /
- *    /
- * [AMD-Vi]
- *
- * *: if SWIOTLB detected 'iommu=soft'/'swiotlb=force' it would skip
- * over the rest of IOMMUs and unconditionally initialize the SWIOTLB.
- * Also it would surreptitiously initialize set the swiotlb=1 if there were
- * more than 4GB and if the user did not pass in 'iommu=off'. The swiotlb
- * flag would be turned off by all IOMMUs except the Calgary one.
- *
- * The IOMMU_INIT* macros allow a similar tree (or more complex if desired)
- * to be built by defining who we depend on.
- *
- * And all that needs to be done is to use one of the macros in the IOMMU
- * and the pci-dma.c will take care of the rest.
- */
-
-struct iommu_table_entry {
-	initcall_t	detect;
-	initcall_t	depend;
-	void		(*early_init)(void); /* No memory allocate available. */
-	void		(*late_init)(void); /* Yes, can allocate memory. */
-#define IOMMU_FINISH_IF_DETECTED (1<<0)
-#define IOMMU_DETECTED		 (1<<1)
-	int		flags;
-};
-/*
- * Macro fills out an entry in the .iommu_table that is equivalent
- * to the fields that 'struct iommu_table_entry' has. The entries
- * that are put in the .iommu_table section are not put in any order
- * hence during boot-time we will have to resort them based on
- * dependency. */
-
-
-#define __IOMMU_INIT(_detect, _depend, _early_init, _late_init, _finish)\
-	static const struct iommu_table_entry				\
-		__iommu_entry_##_detect __used				\
-	__attribute__ ((unused, __section__(".iommu_table"),		\
-			aligned((sizeof(void *)))))	\
-	= {_detect, _depend, _early_init, _late_init,			\
-	   _finish ? IOMMU_FINISH_IF_DETECTED : 0}
-/*
- * The simplest IOMMU definition. Provide the detection routine
- * and it will be run after the SWIOTLB and the other IOMMUs
- * that utilize this macro. If the IOMMU is detected (ie, the
- * detect routine returns a positive value), the other IOMMUs
- * are also checked. You can use IOMMU_INIT_POST_FINISH if you prefer
- * to stop detecting the other IOMMUs after yours has been detected.
- */
-#define IOMMU_INIT_POST(_detect)					\
-	__IOMMU_INIT(_detect, pci_swiotlb_detect_4gb,  NULL, NULL, 0)
-
-#define IOMMU_INIT_POST_FINISH(detect)					\
-	__IOMMU_INIT(_detect, pci_swiotlb_detect_4gb,  NULL, NULL, 1)
-
-/*
- * A more sophisticated version of IOMMU_INIT. This variant requires:
- *  a). A detection routine function.
- *  b). The name of the detection routine we depend on to get called
- *      before us.
- *  c). The init routine which gets called if the detection routine
- *      returns a positive value from the pci_iommu_alloc. This means
- *      no presence of a memory allocator.
- *  d). Similar to the 'init', except that this gets called from pci_iommu_init
- *      where we do have a memory allocator.
- *
- * The standard IOMMU_INIT differs from the IOMMU_INIT_FINISH variant
- * in that the former will continue detecting other IOMMUs in the call
- * list after the detection routine returns a positive number, while the
- * latter will stop the execution chain upon first successful detection.
- * Both variants will still call the 'init' and 'late_init' functions if
- * they are set.
- */
-#define IOMMU_INIT_FINISH(_detect, _depend, _init, _late_init)		\
-	__IOMMU_INIT(_detect, _depend, _init, _late_init, 1)
-
-#define IOMMU_INIT(_detect, _depend, _init, _late_init)			\
-	__IOMMU_INIT(_detect, _depend, _init, _late_init, 0)
-
-void sort_iommu_table(struct iommu_table_entry *start,
-		      struct iommu_table_entry *finish);
-
-void check_iommu_entries(struct iommu_table_entry *start,
-			 struct iommu_table_entry *finish);
-
-#endif /* _ASM_X86_IOMMU_TABLE_H */
diff --git a/arch/x86/include/asm/swiotlb.h b/arch/x86/include/asm/swiotlb.h
deleted file mode 100644
index ff6c92eff035a..0000000000000
--- a/arch/x86/include/asm/swiotlb.h
+++ /dev/null
@@ -1,30 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0 */
-#ifndef _ASM_X86_SWIOTLB_H
-#define _ASM_X86_SWIOTLB_H
-
-#include <linux/swiotlb.h>
-
-#ifdef CONFIG_SWIOTLB
-extern int swiotlb;
-extern int __init pci_swiotlb_detect_override(void);
-extern int __init pci_swiotlb_detect_4gb(void);
-extern void __init pci_swiotlb_init(void);
-extern void __init pci_swiotlb_late_init(void);
-#else
-#define swiotlb 0
-static inline int pci_swiotlb_detect_override(void)
-{
-	return 0;
-}
-static inline int pci_swiotlb_detect_4gb(void)
-{
-	return 0;
-}
-static inline void pci_swiotlb_init(void)
-{
-}
-static inline void pci_swiotlb_late_init(void)
-{
-}
-#endif
-#endif /* _ASM_X86_SWIOTLB_H */
diff --git a/arch/x86/include/asm/xen/swiotlb-xen.h b/arch/x86/include/asm/xen/swiotlb-xen.h
index 66b4ddde77430..e5a90b42e4dde 100644
--- a/arch/x86/include/asm/xen/swiotlb-xen.h
+++ b/arch/x86/include/asm/xen/swiotlb-xen.h
@@ -3,10 +3,8 @@
 #define _ASM_X86_SWIOTLB_XEN_H
 
 #ifdef CONFIG_SWIOTLB_XEN
-extern int __init pci_xen_swiotlb_detect(void);
 extern int pci_xen_swiotlb_init_late(void);
 #else
-#define pci_xen_swiotlb_detect NULL
 static inline int pci_xen_swiotlb_init_late(void) { return -ENXIO; }
 #endif
 
diff --git a/arch/x86/kernel/Makefile b/arch/x86/kernel/Makefile
index 6aef9ee28a394..2851d4f0aa0d2 100644
--- a/arch/x86/kernel/Makefile
+++ b/arch/x86/kernel/Makefile
@@ -71,7 +71,6 @@ obj-y			+= bootflag.o e820.o
 obj-y			+= pci-dma.o quirks.o topology.o kdebugfs.o
 obj-y			+= alternative.o i8253.o hw_breakpoint.o
 obj-y			+= tsc.o tsc_msr.o io_delay.o rtc.o
-obj-y			+= pci-iommu_table.o
 obj-y			+= resource.o
 obj-y			+= irqflags.o
 obj-y			+= static_call.o
@@ -136,7 +135,6 @@ obj-$(CONFIG_PCSPKR_PLATFORM)	+= pcspeaker.o
 
 obj-$(CONFIG_X86_CHECK_BIOS_CORRUPTION) += check.o
 
-obj-$(CONFIG_SWIOTLB)			+= pci-swiotlb.o
 obj-$(CONFIG_OF)			+= devicetree.o
 obj-$(CONFIG_UPROBES)			+= uprobes.o
 
diff --git a/arch/x86/kernel/amd_gart_64.c b/arch/x86/kernel/amd_gart_64.c
index ed837383de5c8..194d54eed5376 100644
--- a/arch/x86/kernel/amd_gart_64.c
+++ b/arch/x86/kernel/amd_gart_64.c
@@ -38,11 +38,9 @@
 #include <asm/iommu.h>
 #include <asm/gart.h>
 #include <asm/set_memory.h>
-#include <asm/swiotlb.h>
 #include <asm/dma.h>
 #include <asm/amd_nb.h>
 #include <asm/x86_init.h>
-#include <asm/iommu_table.h>
 
 static unsigned long iommu_bus_base;	/* GART remapping area (physical) */
 static unsigned long iommu_size;	/* size of remapping area bytes */
@@ -808,7 +806,7 @@ int __init gart_iommu_init(void)
 	flush_gart();
 	dma_ops = &gart_dma_ops;
 	x86_platform.iommu_shutdown = gart_iommu_shutdown;
-	swiotlb = 0;
+	x86_swiotlb_enable = false;
 
 	return 0;
 }
@@ -842,4 +840,3 @@ void __init gart_parse_options(char *p)
 		}
 	}
 }
-IOMMU_INIT_POST(gart_iommu_hole_init);
diff --git a/arch/x86/kernel/aperture_64.c b/arch/x86/kernel/aperture_64.c
index af3ba08b684b5..7a5630d904b23 100644
--- a/arch/x86/kernel/aperture_64.c
+++ b/arch/x86/kernel/aperture_64.c
@@ -392,7 +392,7 @@ void __init early_gart_iommu_check(void)
 
 static int __initdata printed_gart_size_msg;
 
-int __init gart_iommu_hole_init(void)
+void __init gart_iommu_hole_init(void)
 {
 	u32 agp_aper_base = 0, agp_aper_order = 0;
 	u32 aper_size, aper_alloc = 0, aper_order = 0, last_aper_order = 0;
@@ -401,11 +401,11 @@ int __init gart_iommu_hole_init(void)
 	int i, node;
 
 	if (!amd_gart_present())
-		return -ENODEV;
+		return;
 
 	if (gart_iommu_aperture_disabled || !fix_aperture ||
 	    !early_pci_allowed())
-		return -ENODEV;
+		return;
 
 	pr_info("Checking aperture...\n");
 
@@ -491,10 +491,8 @@ int __init gart_iommu_hole_init(void)
 			 * and fixed up the northbridge
 			 */
 			exclude_from_core(last_aper_base, last_aper_order);
-
-			return 1;
 		}
-		return 0;
+		return;
 	}
 
 	if (!fallback_aper_force) {
@@ -527,7 +525,7 @@ int __init gart_iommu_hole_init(void)
 			panic("Not enough memory for aperture");
 		}
 	} else {
-		return 0;
+		return;
 	}
 
 	/*
@@ -561,6 +559,4 @@ int __init gart_iommu_hole_init(void)
 	}
 
 	set_up_gart_resume(aper_order, aper_alloc);
-
-	return 1;
 }
diff --git a/arch/x86/kernel/pci-dma.c b/arch/x86/kernel/pci-dma.c
index de234e7a8962e..17bcac942ac49 100644
--- a/arch/x86/kernel/pci-dma.c
+++ b/arch/x86/kernel/pci-dma.c
@@ -7,13 +7,16 @@
 #include <linux/memblock.h>
 #include <linux/gfp.h>
 #include <linux/pci.h>
+#include <linux/amd-iommu.h>
 
 #include <asm/proto.h>
 #include <asm/dma.h>
 #include <asm/iommu.h>
 #include <asm/gart.h>
 #include <asm/x86_init.h>
-#include <asm/iommu_table.h>
+
+#include <xen/xen.h>
+#include <xen/swiotlb-xen.h>
 
 static bool disable_dac_quirk __read_mostly;
 
@@ -34,24 +37,87 @@ int no_iommu __read_mostly;
 /* Set this to 1 if there is a HW IOMMU in the system */
 int iommu_detected __read_mostly = 0;
 
-extern struct iommu_table_entry __iommu_table[], __iommu_table_end[];
+#ifdef CONFIG_SWIOTLB
+bool x86_swiotlb_enable;
+
+/*
+ * If 4GB or more detected (and iommu=off not set) or if SME is active
+ * then set swiotlb to 1 and return 1.
+ */
+static void __init pci_swiotlb_detect_4gb(void)
+{
+	/* don't initialize swiotlb if iommu=off (no_iommu=1) */
+	if (!no_iommu && max_possible_pfn > MAX_DMA32_PFN)
+		x86_swiotlb_enable = true;
+
+	/*
+	 * Set swiotlb to 1 so that bounce buffers are allocated and used for
+	 * devices that can't support DMA to encrypted memory.
+	 */
+	if (cc_platform_has(CC_ATTR_HOST_MEM_ENCRYPT))
+		x86_swiotlb_enable = true;
+
+	if (swiotlb_force == SWIOTLB_FORCE)
+		x86_swiotlb_enable = true;
+}
+#else
+static inline void __init pci_swiotlb_detect_4gb(void)
+{
+}
+#endif /* CONFIG_SWIOTLB */
+
+#ifdef CONFIG_SWIOTLB_XEN
+static bool xen_swiotlb;
+
+static void __init pci_xen_swiotlb_init(void)
+{
+	if (!xen_initial_domain() && !x86_swiotlb_enable &&
+	    swiotlb_force != SWIOTLB_FORCE)
+		return;
+	x86_swiotlb_enable = false;
+	xen_swiotlb = true;
+	xen_swiotlb_init_early();
+	dma_ops = &xen_swiotlb_dma_ops;
+	if (IS_ENABLED(CONFIG_PCI))
+		pci_request_acs();
+}
+
+int pci_xen_swiotlb_init_late(void)
+{
+	int rc;
+
+	if (xen_swiotlb)
+		return 0;
+
+	rc = xen_swiotlb_init();
+	if (rc)
+		return rc;
+
+	/* XXX: this switches the dma ops under live devices! */
+	dma_ops = &xen_swiotlb_dma_ops;
+	if (IS_ENABLED(CONFIG_PCI))
+		pci_request_acs();
+	return 0;
+}
+EXPORT_SYMBOL_GPL(pci_xen_swiotlb_init_late);
+#else
+static inline void __init pci_xen_swiotlb_init(void)
+{
+}
+#endif /* CONFIG_SWIOTLB_XEN */
 
 void __init pci_iommu_alloc(void)
 {
-	struct iommu_table_entry *p;
-
-	sort_iommu_table(__iommu_table, __iommu_table_end);
-	check_iommu_entries(__iommu_table, __iommu_table_end);
-
-	for (p = __iommu_table; p < __iommu_table_end; p++) {
-		if (p && p->detect && p->detect() > 0) {
-			p->flags |= IOMMU_DETECTED;
-			if (p->early_init)
-				p->early_init();
-			if (p->flags & IOMMU_FINISH_IF_DETECTED)
-				break;
-		}
+	if (xen_pv_domain()) {
+		pci_xen_swiotlb_init();
+		return;
 	}
+	pci_swiotlb_detect_4gb();
+	gart_iommu_hole_init();
+	amd_iommu_detect();
+	detect_intel_iommu();
+	if (x86_swiotlb_enable)
+		swiotlb_init(0);
 }
 
 /*
@@ -102,7 +168,7 @@ static __init int iommu_setup(char *p)
 		}
 #ifdef CONFIG_SWIOTLB
 		if (!strncmp(p, "soft", 4))
-			swiotlb = 1;
+			x86_swiotlb_enable = 1;
 #endif
 		if (!strncmp(p, "pt", 2))
 			iommu_set_default_passthrough(true);
@@ -121,14 +187,17 @@ early_param("iommu", iommu_setup);
 
 static int __init pci_iommu_init(void)
 {
-	struct iommu_table_entry *p;
-
 	x86_init.iommu.iommu_init();
 
-	for (p = __iommu_table; p < __iommu_table_end; p++) {
-		if (p && (p->flags & IOMMU_DETECTED) && p->late_init)
-			p->late_init();
+#ifdef CONFIG_SWIOTLB
+	/* An IOMMU turned us off. */
+	if (x86_swiotlb_enable) {
+		pr_info("PCI-DMA: Using software bounce buffering for IO (SWIOTLB)\n");
+		swiotlb_print_info();
+	} else {
+		swiotlb_exit();
 	}
+#endif
 
 	return 0;
 }
diff --git a/arch/x86/kernel/pci-iommu_table.c b/arch/x86/kernel/pci-iommu_table.c
deleted file mode 100644
index 42e92ec62973b..0000000000000
--- a/arch/x86/kernel/pci-iommu_table.c
+++ /dev/null
@@ -1,77 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0
-#include <linux/dma-mapping.h>
-#include <asm/iommu_table.h>
-#include <linux/string.h>
-#include <linux/kallsyms.h>
-
-static struct iommu_table_entry * __init
-find_dependents_of(struct iommu_table_entry *start,
-		   struct iommu_table_entry *finish,
-		   struct iommu_table_entry *q)
-{
-	struct iommu_table_entry *p;
-
-	if (!q)
-		return NULL;
-
-	for (p = start; p < finish; p++)
-		if (p->detect == q->depend)
-			return p;
-
-	return NULL;
-}
-
-
-void __init sort_iommu_table(struct iommu_table_entry *start,
-			     struct iommu_table_entry *finish) {
-
-	struct iommu_table_entry *p, *q, tmp;
-
-	for (p = start; p < finish; p++) {
-again:
-		q = find_dependents_of(start, finish, p);
-		/* We are bit sneaky here. We use the memory address to figure
-		 * out if the node we depend on is past our point, if so, swap.
-		 */
-		if (q > p) {
-			tmp = *p;
-			memmove(p, q, sizeof(*p));
-			*q = tmp;
-			goto again;
-		}
-	}
-
-}
-
-#ifdef DEBUG
-void __init check_iommu_entries(struct iommu_table_entry *start,
-				struct iommu_table_entry *finish)
-{
-	struct iommu_table_entry *p, *q, *x;
-
-	/* Simple cyclic dependency checker. */
-	for (p = start; p < finish; p++) {
-		q = find_dependents_of(start, finish, p);
-		x = find_dependents_of(start, finish, q);
-		if (p == x) {
-			printk(KERN_ERR "CYCLIC DEPENDENCY FOUND! %pS depends on %pS and vice-versa. BREAKING IT.\n",
-			       p->detect, q->detect);
-			/* Heavy handed way..*/
-			x->depend = NULL;
-		}
-	}
-
-	for (p = start; p < finish; p++) {
-		q = find_dependents_of(p, finish, p);
-		if (q && q > p) {
-			printk(KERN_ERR "EXECUTION ORDER INVALID! %pS should be called before %pS!\n",
-			       p->detect, q->detect);
-		}
-	}
-}
-#else
-void __init check_iommu_entries(struct iommu_table_entry *start,
-				       struct iommu_table_entry *finish)
-{
-}
-#endif
diff --git a/arch/x86/kernel/pci-swiotlb.c b/arch/x86/kernel/pci-swiotlb.c
deleted file mode 100644
index 814ab46a0dada..0000000000000
--- a/arch/x86/kernel/pci-swiotlb.c
+++ /dev/null
@@ -1,77 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0
-
-#include <linux/pci.h>
-#include <linux/cache.h>
-#include <linux/init.h>
-#include <linux/swiotlb.h>
-#include <linux/memblock.h>
-#include <linux/dma-direct.h>
-#include <linux/cc_platform.h>
-
-#include <asm/iommu.h>
-#include <asm/swiotlb.h>
-#include <asm/dma.h>
-#include <asm/xen/swiotlb-xen.h>
-#include <asm/iommu_table.h>
-
-int swiotlb __read_mostly;
-
-/*
- * pci_swiotlb_detect_override - set swiotlb to 1 if necessary
- *
- * This returns non-zero if we are forced to use swiotlb (by the boot
- * option).
- */
-int __init pci_swiotlb_detect_override(void)
-{
-	if (swiotlb_force == SWIOTLB_FORCE)
-		swiotlb = 1;
-
-	return swiotlb;
-}
-IOMMU_INIT_FINISH(pci_swiotlb_detect_override,
-		  pci_xen_swiotlb_detect,
-		  pci_swiotlb_init,
-		  pci_swiotlb_late_init);
-
-/*
- * If 4GB or more detected (and iommu=off not set) or if SME is active
- * then set swiotlb to 1 and return 1.
- */
-int __init pci_swiotlb_detect_4gb(void)
-{
-	/* don't initialize swiotlb if iommu=off (no_iommu=1) */
-	if (!no_iommu && max_possible_pfn > MAX_DMA32_PFN)
-		swiotlb = 1;
-
-	/*
-	 * Set swiotlb to 1 so that bounce buffers are allocated and used for
-	 * devices that can't support DMA to encrypted memory.
-	 */
-	if (cc_platform_has(CC_ATTR_HOST_MEM_ENCRYPT))
-		swiotlb = 1;
-
-	return swiotlb;
-}
-IOMMU_INIT(pci_swiotlb_detect_4gb,
-	   pci_swiotlb_detect_override,
-	   pci_swiotlb_init,
-	   pci_swiotlb_late_init);
-
-void __init pci_swiotlb_init(void)
-{
-	if (swiotlb)
-		swiotlb_init(0);
-}
-
-void __init pci_swiotlb_late_init(void)
-{
-	/* An IOMMU turned us off. */
-	if (!swiotlb)
-		swiotlb_exit();
-	else {
-		printk(KERN_INFO "PCI-DMA: "
-		       "Using software bounce buffering for IO (SWIOTLB)\n");
-		swiotlb_print_info();
-	}
-}
diff --git a/arch/x86/kernel/tboot.c b/arch/x86/kernel/tboot.c
index f9af561c3cd4f..0c1154a1c4032 100644
--- a/arch/x86/kernel/tboot.c
+++ b/arch/x86/kernel/tboot.c
@@ -24,7 +24,6 @@
 #include <asm/processor.h>
 #include <asm/bootparam.h>
 #include <asm/pgalloc.h>
-#include <asm/swiotlb.h>
 #include <asm/fixmap.h>
 #include <asm/proto.h>
 #include <asm/setup.h>
diff --git a/arch/x86/kernel/vmlinux.lds.S b/arch/x86/kernel/vmlinux.lds.S
index 27f830345b6f0..bbe910c15b293 100644
--- a/arch/x86/kernel/vmlinux.lds.S
+++ b/arch/x86/kernel/vmlinux.lds.S
@@ -306,18 +306,6 @@ SECTIONS
 		*(.altinstr_replacement)
 	}
 
-	/*
-	 * struct iommu_table_entry entries are injected in this section.
-	 * It is an array of IOMMUs which during run time gets sorted depending
-	 * on its dependency order. After rootfs_initcall is complete
-	 * this section can be safely removed.
-	 */
-	.iommu_table : AT(ADDR(.iommu_table) - LOAD_OFFSET) {
-		__iommu_table = .;
-		*(.iommu_table)
-		__iommu_table_end = .;
-	}
-
 	. = ALIGN(8);
 	.apicdrivers : AT(ADDR(.apicdrivers) - LOAD_OFFSET) {
 		__apicdrivers = .;
diff --git a/arch/x86/xen/Makefile b/arch/x86/xen/Makefile
index 4953260e281c3..3c5b52fbe4a7f 100644
--- a/arch/x86/xen/Makefile
+++ b/arch/x86/xen/Makefile
@@ -47,6 +47,4 @@ obj-$(CONFIG_XEN_DEBUG_FS)	+= debugfs.o
 
 obj-$(CONFIG_XEN_PV_DOM0)	+= vga.o
 
-obj-$(CONFIG_SWIOTLB_XEN)	+= pci-swiotlb-xen.o
-
 obj-$(CONFIG_XEN_EFI)		+= efi.o
diff --git a/arch/x86/xen/pci-swiotlb-xen.c b/arch/x86/xen/pci-swiotlb-xen.c
deleted file mode 100644
index 46df59aeaa06a..0000000000000
--- a/arch/x86/xen/pci-swiotlb-xen.c
+++ /dev/null
@@ -1,96 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0
-
-/* Glue code to lib/swiotlb-xen.c */
-
-#include <linux/dma-map-ops.h>
-#include <linux/pci.h>
-#include <xen/swiotlb-xen.h>
-
-#include <asm/xen/hypervisor.h>
-#include <xen/xen.h>
-#include <asm/iommu_table.h>
-
-
-#include <asm/xen/swiotlb-xen.h>
-#ifdef CONFIG_X86_64
-#include <asm/iommu.h>
-#include <asm/dma.h>
-#endif
-#include <linux/export.h>
-
-static int xen_swiotlb __read_mostly;
-
-/*
- * pci_xen_swiotlb_detect - set xen_swiotlb to 1 if necessary
- *
- * This returns non-zero if we are forced to use xen_swiotlb (by the boot
- * option).
- */
-int __init pci_xen_swiotlb_detect(void)
-{
-
-	if (!xen_pv_domain())
-		return 0;
-
-	/* If running as PV guest, either iommu=soft, or swiotlb=force will
-	 * activate this IOMMU. If running as PV privileged, activate it
-	 * irregardless.
-	 */
-	if (xen_initial_domain() || swiotlb || swiotlb_force == SWIOTLB_FORCE)
-		xen_swiotlb = 1;
-
-	/* If we are running under Xen, we MUST disable the native SWIOTLB.
-	 * Don't worry about swiotlb_force flag activating the native, as
-	 * the 'swiotlb' flag is the only one turning it on. */
-	swiotlb = 0;
-
-#ifdef CONFIG_X86_64
-	/* pci_swiotlb_detect_4gb turns on native SWIOTLB if no_iommu == 0
-	 * (so no iommu=X command line over-writes).
-	 * Considering that PV guests do not want the *native SWIOTLB* but
-	 * only Xen SWIOTLB it is not useful to us so set no_iommu=1 here.
-	 */
-	if (max_pfn > MAX_DMA32_PFN)
-		no_iommu = 1;
-#endif
-	return xen_swiotlb;
-}
-
-static void __init pci_xen_swiotlb_init(void)
-{
-	if (xen_swiotlb) {
-		xen_swiotlb_init_early();
-		dma_ops = &xen_swiotlb_dma_ops;
-
-#ifdef CONFIG_PCI
-		/* Make sure ACS will be enabled */
-		pci_request_acs();
-#endif
-	}
-}
-
-int pci_xen_swiotlb_init_late(void)
-{
-	int rc;
-
-	if (xen_swiotlb)
-		return 0;
-
-	rc = xen_swiotlb_init();
-	if (rc)
-		return rc;
-
-	dma_ops = &xen_swiotlb_dma_ops;
-#ifdef CONFIG_PCI
-	/* Make sure ACS will be enabled */
-	pci_request_acs();
-#endif
-
-	return 0;
-}
-EXPORT_SYMBOL_GPL(pci_xen_swiotlb_init_late);
-
-IOMMU_INIT_FINISH(pci_xen_swiotlb_detect,
-		  NULL,
-		  pci_xen_swiotlb_init,
-		  NULL);
diff --git a/drivers/iommu/amd/init.c b/drivers/iommu/amd/init.c
index b10fb52ea4428..721300cf90207 100644
--- a/drivers/iommu/amd/init.c
+++ b/drivers/iommu/amd/init.c
@@ -27,7 +27,6 @@
 #include <asm/apic.h>
 #include <asm/gart.h>
 #include <asm/x86_init.h>
-#include <asm/iommu_table.h>
 #include <asm/io_apic.h>
 #include <asm/irq_remapping.h>
 #include <asm/set_memory.h>
@@ -3237,11 +3236,6 @@ __setup("ivrs_ioapic",		parse_ivrs_ioapic);
 __setup("ivrs_hpet",		parse_ivrs_hpet);
 __setup("ivrs_acpihid",		parse_ivrs_acpihid);
 
-IOMMU_INIT_FINISH(amd_iommu_detect,
-		  gart_iommu_hole_init,
-		  NULL,
-		  NULL);
-
 bool amd_iommu_v2_supported(void)
 {
 	return amd_iommu_v2_present;
diff --git a/drivers/iommu/amd/iommu.c b/drivers/iommu/amd/iommu.c
index 461f1844ed1fb..541a7b8315a12 100644
--- a/drivers/iommu/amd/iommu.c
+++ b/drivers/iommu/amd/iommu.c
@@ -1834,7 +1834,10 @@ void amd_iommu_domain_update(struct protection_domain *domain)
 
 static void __init amd_iommu_init_dma_ops(void)
 {
-	swiotlb = (iommu_default_passthrough() || sme_me_mask) ? 1 : 0;
+	if (iommu_default_passthrough() || sme_me_mask)
+		x86_swiotlb_enable = true;
+	else
+		x86_swiotlb_enable = false;
 }
 
 int __init amd_iommu_init_api(void)
diff --git a/drivers/iommu/intel/dmar.c b/drivers/iommu/intel/dmar.c
index 915bff76fe965..29bee4b210c5b 100644
--- a/drivers/iommu/intel/dmar.c
+++ b/drivers/iommu/intel/dmar.c
@@ -30,7 +30,6 @@
 #include <linux/numa.h>
 #include <linux/limits.h>
 #include <asm/irq_remapping.h>
-#include <asm/iommu_table.h>
 #include <trace/events/intel_iommu.h>
 
 #include "../irq_remapping.h"
@@ -913,7 +912,7 @@ dmar_validate_one_drhd(struct acpi_dmar_header *entry, void *arg)
 	return 0;
 }
 
-int __init detect_intel_iommu(void)
+void __init detect_intel_iommu(void)
 {
 	int ret;
 	struct dmar_res_callback validate_drhd_cb = {
@@ -946,8 +945,6 @@ int __init detect_intel_iommu(void)
 		dmar_tbl = NULL;
 	}
 	up_write(&dmar_global_lock);
-
-	return ret ? ret : 1;
 }
 
 static void unmap_iommu(struct intel_iommu *iommu)
@@ -2165,7 +2162,6 @@ static int __init dmar_free_unused_resources(void)
 }
 
 late_initcall(dmar_free_unused_resources);
-IOMMU_INIT_POST(detect_intel_iommu);
 
 /*
  * DMAR Hotplug Support
diff --git a/include/linux/dmar.h b/include/linux/dmar.h
index 45e903d847335..cbd714a198a0a 100644
--- a/include/linux/dmar.h
+++ b/include/linux/dmar.h
@@ -121,7 +121,7 @@ extern int dmar_remove_dev_scope(struct dmar_pci_notify_info *info,
 				 u16 segment, struct dmar_dev_scope *devices,
 				 int count);
 /* Intel IOMMU detection */
-extern int detect_intel_iommu(void);
+void detect_intel_iommu(void);
 extern int enable_drhd_fault_handling(void);
 extern int dmar_device_add(acpi_handle handle);
 extern int dmar_device_remove(acpi_handle handle);
@@ -197,6 +197,10 @@ static inline bool dmar_platform_optin(void)
 	return false;
 }
 
+static inline void detect_intel_iommu(void)
+{
+}
+
 #endif /* CONFIG_DMAR_TABLE */
 
 struct irte {
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Sun Feb 27 14:31:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 27 Feb 2022 14:31:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279967.477808 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOKaY-0005mC-Un; Sun, 27 Feb 2022 14:31:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279967.477808; Sun, 27 Feb 2022 14:31:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOKaY-0005m5-Rj; Sun, 27 Feb 2022 14:31:54 +0000
Received: by outflank-mailman (input) for mailman id 279967;
 Sun, 27 Feb 2022 14:31:54 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=jKox=TK=bombadil.srs.infradead.org=BATV+9eb748f383daf30c13ac+6762+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nOKaX-0002ik-V3
 for xen-devel@lists.xenproject.org; Sun, 27 Feb 2022 14:31:54 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 00bc9342-97da-11ec-8eba-a37418f5ba1a;
 Sun, 27 Feb 2022 15:31:52 +0100 (CET)
Received: from [213.208.157.39] (helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nOKaG-009OB7-B1; Sun, 27 Feb 2022 14:31:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 00bc9342-97da-11ec-8eba-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=JdxyTNAGqW27S4S6ZEFBFR/VybAHE6V5ih7t10OnNJI=; b=lI0hsR5ACeRAz7HzfuPC5f2lK6
	11HvIC9O4NjYRnETgO9aDFMfEu5IaSjQwavBrNtyeFaUnK1VKICC+EvoD/m4sVpcqPUCKIf7J8TIO
	kBH+bzO6Kb5/mhklOnVKyuSntEpcsKDaYbRMapKodjSLhHKUpNx/k352HQGSVdNU9J1FvY+TSUUUV
	iNxs46XhMSKFLl1tgVpvsAJehYzarwaM9seGJNuRg9Febx9zQzuxdr2AQBudJBC6nuIOBLlVa2I0+
	ys2VvDpaGvg+GlP1TI1q7FYVi01tT3qt8S/wKpq6zDzhhLTY1jsSwEb82vJFtzzMCsPrO/QdY/8Jf
	H4OKTSCQ==;
From: Christoph Hellwig <hch@lst.de>
To: iommu@lists.linux-foundation.org
Cc: x86@kernel.org,
	Anshuman Khandual <anshuman.khandual@arm.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Joerg Roedel <joro@8bytes.org>,
	David Woodhouse <dwmw2@infradead.org>,
	Lu Baolu <baolu.lu@linux.intel.com>,
	Robin Murphy <robin.murphy@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	xen-devel@lists.xenproject.org,
	linux-ia64@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	tboot-devel@lists.sourceforge.net,
	linux-pci@vger.kernel.org
Subject: [PATCH 08/11] swiotlb: make the swiotlb_init interface more useful
Date: Sun, 27 Feb 2022 15:30:52 +0100
Message-Id: <20220227143055.335596-9-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220227143055.335596-1-hch@lst.de>
References: <20220227143055.335596-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Pass a bool to pass if swiotlb needs to be enabled based on the
addressing needs and replace the verbose argument with a set of
flags, including one to force enable bounce buffering.

Note that this patch removes the possibility to force xen-swiotlb
use using swiotlb=force on the command line on x86 (arm and arm64
never supported that), but this interface will be restored shortly.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 arch/arm/mm/init.c                     |  6 +----
 arch/arm64/mm/init.c                   |  6 +----
 arch/ia64/mm/init.c                    |  4 +--
 arch/mips/cavium-octeon/dma-octeon.c   |  2 +-
 arch/mips/loongson64/dma.c             |  2 +-
 arch/mips/sibyte/common/dma.c          |  2 +-
 arch/powerpc/include/asm/swiotlb.h     |  1 +
 arch/powerpc/mm/mem.c                  |  3 ++-
 arch/powerpc/platforms/pseries/setup.c |  3 ---
 arch/riscv/mm/init.c                   |  8 +-----
 arch/s390/mm/init.c                    |  3 +--
 arch/x86/kernel/cpu/mshyperv.c         |  8 ------
 arch/x86/kernel/pci-dma.c              | 15 ++++++-----
 arch/x86/mm/mem_encrypt_amd.c          |  3 ---
 drivers/xen/swiotlb-xen.c              |  4 +--
 include/linux/swiotlb.h                | 15 ++++++-----
 include/trace/events/swiotlb.h         | 29 ++++++++-------------
 kernel/dma/swiotlb.c                   | 35 ++++++++++++++------------
 18 files changed, 56 insertions(+), 93 deletions(-)

diff --git a/arch/arm/mm/init.c b/arch/arm/mm/init.c
index 6d0cb0f7bc54b..73f30d278b565 100644
--- a/arch/arm/mm/init.c
+++ b/arch/arm/mm/init.c
@@ -312,11 +312,7 @@ static void __init free_highpages(void)
 void __init mem_init(void)
 {
 #ifdef CONFIG_ARM_LPAE
-	if (swiotlb_force == SWIOTLB_FORCE ||
-	    max_pfn > arm_dma_pfn_limit)
-		swiotlb_init(1);
-	else
-		swiotlb_force = SWIOTLB_NO_FORCE;
+	swiotlb_init(max_pfn > arm_dma_pfn_limit, SWIOTLB_VERBOSE);
 #endif
 
 	set_max_mapnr(pfn_to_page(max_pfn) - mem_map);
diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c
index db63cc885771a..52102adda3d28 100644
--- a/arch/arm64/mm/init.c
+++ b/arch/arm64/mm/init.c
@@ -373,11 +373,7 @@ void __init bootmem_init(void)
  */
 void __init mem_init(void)
 {
-	if (swiotlb_force == SWIOTLB_FORCE ||
-	    max_pfn > PFN_DOWN(arm64_dma_phys_limit))
-		swiotlb_init(1);
-	else if (!xen_swiotlb_detect())
-		swiotlb_force = SWIOTLB_NO_FORCE;
+	swiotlb_init(max_pfn > PFN_DOWN(arm64_dma_phys_limit), SWIOTLB_VERBOSE);
 
 	/* this will put all unused low memory onto the freelists */
 	memblock_free_all();
diff --git a/arch/ia64/mm/init.c b/arch/ia64/mm/init.c
index 5d165607bf354..3c3e15b22608f 100644
--- a/arch/ia64/mm/init.c
+++ b/arch/ia64/mm/init.c
@@ -437,9 +437,7 @@ mem_init (void)
 		if (iommu_detected)
 			break;
 #endif
-#ifdef CONFIG_SWIOTLB
-		swiotlb_init(1);
-#endif
+		swiotlb_init(true, SWIOTLB_VERBOSE);
 	} while (0);
 
 #ifdef CONFIG_FLATMEM
diff --git a/arch/mips/cavium-octeon/dma-octeon.c b/arch/mips/cavium-octeon/dma-octeon.c
index fb7547e217263..9fbba6a8fa4c5 100644
--- a/arch/mips/cavium-octeon/dma-octeon.c
+++ b/arch/mips/cavium-octeon/dma-octeon.c
@@ -235,5 +235,5 @@ void __init plat_swiotlb_setup(void)
 #endif
 
 	swiotlb_adjust_size(swiotlbsize);
-	swiotlb_init(1);
+	swiotlb_init(true, SWIOTLB_VERBOSE);
 }
diff --git a/arch/mips/loongson64/dma.c b/arch/mips/loongson64/dma.c
index 364f2f27c8723..8220a1bc0db64 100644
--- a/arch/mips/loongson64/dma.c
+++ b/arch/mips/loongson64/dma.c
@@ -24,5 +24,5 @@ phys_addr_t dma_to_phys(struct device *dev, dma_addr_t daddr)
 
 void __init plat_swiotlb_setup(void)
 {
-	swiotlb_init(1);
+	swiotlb_init(true, SWIOTLB_VERBOSE);
 }
diff --git a/arch/mips/sibyte/common/dma.c b/arch/mips/sibyte/common/dma.c
index eb47a94f3583e..c5c2c782aff68 100644
--- a/arch/mips/sibyte/common/dma.c
+++ b/arch/mips/sibyte/common/dma.c
@@ -10,5 +10,5 @@
 
 void __init plat_swiotlb_setup(void)
 {
-	swiotlb_init(1);
+	swiotlb_init(true, SWIOTLB_VERBOSE);
 }
diff --git a/arch/powerpc/include/asm/swiotlb.h b/arch/powerpc/include/asm/swiotlb.h
index 3c1a1cd161286..4203b5e0a88ed 100644
--- a/arch/powerpc/include/asm/swiotlb.h
+++ b/arch/powerpc/include/asm/swiotlb.h
@@ -9,6 +9,7 @@
 #include <linux/swiotlb.h>
 
 extern unsigned int ppc_swiotlb_enable;
+extern unsigned int ppc_swiotlb_flags;
 
 #ifdef CONFIG_SWIOTLB
 void swiotlb_detect_4g(void);
diff --git a/arch/powerpc/mm/mem.c b/arch/powerpc/mm/mem.c
index 8e301cd8925b2..d99b8b5b40ca6 100644
--- a/arch/powerpc/mm/mem.c
+++ b/arch/powerpc/mm/mem.c
@@ -17,6 +17,7 @@
 #include <linux/suspend.h>
 #include <linux/dma-direct.h>
 
+#include <asm/swiotlb.h>
 #include <asm/machdep.h>
 #include <asm/rtas.h>
 #include <asm/kasan.h>
@@ -251,7 +252,7 @@ void __init mem_init(void)
 	if (is_secure_guest())
 		svm_swiotlb_init();
 	else
-		swiotlb_init(0);
+		swiotlb_init(ppc_swiotlb_enable, ppc_swiotlb_flags);
 #endif
 
 	high_memory = (void *) __va(max_low_pfn * PAGE_SIZE);
diff --git a/arch/powerpc/platforms/pseries/setup.c b/arch/powerpc/platforms/pseries/setup.c
index 83a04d967a59f..45d637ab58261 100644
--- a/arch/powerpc/platforms/pseries/setup.c
+++ b/arch/powerpc/platforms/pseries/setup.c
@@ -838,9 +838,6 @@ static void __init pSeries_setup_arch(void)
 	}
 
 	ppc_md.pcibios_root_bridge_prepare = pseries_root_bridge_prepare;
-
-	if (swiotlb_force == SWIOTLB_FORCE)
-		ppc_swiotlb_enable = 1;
 }
 
 static void pseries_panic(char *str)
diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c
index c27294128e182..6cdbb62672fe5 100644
--- a/arch/riscv/mm/init.c
+++ b/arch/riscv/mm/init.c
@@ -118,13 +118,7 @@ void __init mem_init(void)
 	BUG_ON(!mem_map);
 #endif /* CONFIG_FLATMEM */
 
-#ifdef CONFIG_SWIOTLB
-	if (swiotlb_force == SWIOTLB_FORCE ||
-	    max_pfn > PFN_DOWN(dma32_phys_limit))
-		swiotlb_init(1);
-	else
-		swiotlb_force = SWIOTLB_NO_FORCE;
-#endif
+	swiotlb_init(max_pfn > PFN_DOWN(dma32_phys_limit), SWIOTLB_VERBOSE);
 	high_memory = (void *)(__va(PFN_PHYS(max_low_pfn)));
 	memblock_free_all();
 
diff --git a/arch/s390/mm/init.c b/arch/s390/mm/init.c
index 86ffd0d51fd59..6fb6bf64326f9 100644
--- a/arch/s390/mm/init.c
+++ b/arch/s390/mm/init.c
@@ -185,8 +185,7 @@ static void pv_init(void)
 		return;
 
 	/* make sure bounce buffers are shared */
-	swiotlb_force = SWIOTLB_FORCE;
-	swiotlb_init(1);
+	swiotlb_init(true, SWIOTLB_FORCE | SWIOTLB_VERBOSE);
 	swiotlb_update_mem_attributes();
 }
 
diff --git a/arch/x86/kernel/cpu/mshyperv.c b/arch/x86/kernel/cpu/mshyperv.c
index 5a99f993e6392..568274917f1cd 100644
--- a/arch/x86/kernel/cpu/mshyperv.c
+++ b/arch/x86/kernel/cpu/mshyperv.c
@@ -336,14 +336,6 @@ static void __init ms_hyperv_init_platform(void)
 			swiotlb_unencrypted_base = ms_hyperv.shared_gpa_boundary;
 #endif
 		}
-
-#ifdef CONFIG_SWIOTLB
-		/*
-		 * Enable swiotlb force mode in Isolation VM to
-		 * use swiotlb bounce buffer for dma transaction.
-		 */
-		swiotlb_force = SWIOTLB_FORCE;
-#endif
 	}
 
 	if (hv_max_functions_eax >= HYPERV_CPUID_NESTED_FEATURES) {
diff --git a/arch/x86/kernel/pci-dma.c b/arch/x86/kernel/pci-dma.c
index 17bcac942ac49..bb08184a50e3a 100644
--- a/arch/x86/kernel/pci-dma.c
+++ b/arch/x86/kernel/pci-dma.c
@@ -39,6 +39,7 @@ int iommu_detected __read_mostly = 0;
 
 #ifdef CONFIG_SWIOTLB
 bool x86_swiotlb_enable;
+static unsigned int x86_swiotlb_flags;
 
 /*
  * If 4GB or more detected (and iommu=off not set) or if SME is active
@@ -54,16 +55,16 @@ static void __init pci_swiotlb_detect_4gb(void)
 	 * Set swiotlb to 1 so that bounce buffers are allocated and used for
 	 * devices that can't support DMA to encrypted memory.
 	 */
-	if (cc_platform_has(CC_ATTR_HOST_MEM_ENCRYPT))
-		x86_swiotlb_enable = true;
-
-	if (swiotlb_force == SWIOTLB_FORCE)
+	if (cc_platform_has(CC_ATTR_HOST_MEM_ENCRYPT)) {
 		x86_swiotlb_enable = true;
+		x86_swiotlb_flags |= SWIOTLB_FORCE;
+	}
 }
 #else
 static inline void __init pci_swiotlb_detect_4gb(void)
 {
 }
+#define x86_swiotlb_flags 0
 #endif /* CONFIG_SWIOTLB */
 
 #ifdef CONFIG_SWIOTLB_XEN
@@ -71,8 +72,7 @@ static bool xen_swiotlb;
 
 static void __init pci_xen_swiotlb_init(void)
 {
-	if (!xen_initial_domain() && !x86_swiotlb_enable &&
-	    swiotlb_force != SWIOTLB_FORCE)
+	if (!xen_initial_domain() && !x86_swiotlb_enable)
 		return;
 	x86_swiotlb_enable = false;
 	xen_swiotlb = true;
@@ -116,8 +116,7 @@ void __init pci_iommu_alloc(void)
 	gart_iommu_hole_init();
 	amd_iommu_detect();
 	detect_intel_iommu();
-	if (x86_swiotlb_enable)
-		swiotlb_init(0);
+	swiotlb_init(x86_swiotlb_enable, x86_swiotlb_flags);
 }
 
 /*
diff --git a/arch/x86/mm/mem_encrypt_amd.c b/arch/x86/mm/mem_encrypt_amd.c
index 2b2d018ea3450..a72942d569cf9 100644
--- a/arch/x86/mm/mem_encrypt_amd.c
+++ b/arch/x86/mm/mem_encrypt_amd.c
@@ -191,9 +191,6 @@ void __init sme_early_init(void)
 	/* Update the protection map with memory encryption mask */
 	for (i = 0; i < ARRAY_SIZE(protection_map); i++)
 		protection_map[i] = pgprot_encrypted(protection_map[i]);
-
-	if (cc_platform_has(CC_ATTR_GUEST_MEM_ENCRYPT))
-		swiotlb_force = SWIOTLB_FORCE;
 }
 
 void __init sev_setup_arch(void)
diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c
index 485cd06ed39e7..c2da3eb4826e8 100644
--- a/drivers/xen/swiotlb-xen.c
+++ b/drivers/xen/swiotlb-xen.c
@@ -251,7 +251,7 @@ void __init xen_swiotlb_init_early(void)
 		panic("%s (rc:%d)", xen_swiotlb_error(XEN_SWIOTLB_EFIXUP), rc);
 	}
 
-	if (swiotlb_init_with_tbl(start, nslabs, true))
+	if (swiotlb_init_with_tbl(start, nslabs, SWIOTLB_VERBOSE))
 		panic("Cannot allocate SWIOTLB buffer");
 }
 #endif /* CONFIG_X86 */
@@ -376,7 +376,7 @@ static dma_addr_t xen_swiotlb_map_page(struct device *dev, struct page *page,
 	/*
 	 * Oh well, have to allocate and map a bounce buffer.
 	 */
-	trace_swiotlb_bounced(dev, dev_addr, size, swiotlb_force);
+	trace_swiotlb_bounced(dev, dev_addr, size);
 
 	map = swiotlb_tbl_map_single(dev, phys, size, size, 0, dir, attrs);
 	if (map == (phys_addr_t)DMA_MAPPING_ERROR)
diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h
index 1befd6b2ccf5e..dcecf953f7997 100644
--- a/include/linux/swiotlb.h
+++ b/include/linux/swiotlb.h
@@ -13,11 +13,8 @@ struct device;
 struct page;
 struct scatterlist;
 
-enum swiotlb_force {
-	SWIOTLB_NORMAL,		/* Default - depending on HW DMA mask etc. */
-	SWIOTLB_FORCE,		/* swiotlb=force */
-	SWIOTLB_NO_FORCE,	/* swiotlb=noforce */
-};
+#define SWIOTLB_VERBOSE	(1 << 0) /* verbose initialization */
+#define SWIOTLB_FORCE	(1 << 1) /* force bounce buffering */
 
 /*
  * Maximum allowable number of contiguous slabs to map,
@@ -36,8 +33,7 @@ enum swiotlb_force {
 /* default to 64MB */
 #define IO_TLB_DEFAULT_SIZE (64UL<<20)
 
-extern void swiotlb_init(int verbose);
-int swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, int verbose);
+int swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, unsigned int flags);
 unsigned long swiotlb_size_or_default(void);
 extern int swiotlb_late_init_with_tbl(char *tlb, unsigned long nslabs);
 int swiotlb_init_late(size_t size, gfp_t gfp_mask);
@@ -126,13 +122,16 @@ static inline bool is_swiotlb_force_bounce(struct device *dev)
 	return mem && mem->force_bounce;
 }
 
+void swiotlb_init(bool addressing_limited, unsigned int flags);
 void __init swiotlb_exit(void);
 unsigned int swiotlb_max_segment(void);
 size_t swiotlb_max_mapping_size(struct device *dev);
 bool is_swiotlb_active(struct device *dev);
 void __init swiotlb_adjust_size(unsigned long size);
 #else
-#define swiotlb_force SWIOTLB_NO_FORCE
+static inline void swiotlb_init(bool addressing_limited, unsigned int flags)
+{
+}
 static inline bool is_swiotlb_buffer(struct device *dev, phys_addr_t paddr)
 {
 	return false;
diff --git a/include/trace/events/swiotlb.h b/include/trace/events/swiotlb.h
index 705be43b71ab0..da05c9ebd224a 100644
--- a/include/trace/events/swiotlb.h
+++ b/include/trace/events/swiotlb.h
@@ -8,20 +8,15 @@
 #include <linux/tracepoint.h>
 
 TRACE_EVENT(swiotlb_bounced,
-
-	TP_PROTO(struct device *dev,
-		 dma_addr_t dev_addr,
-		 size_t size,
-		 enum swiotlb_force swiotlb_force),
-
-	TP_ARGS(dev, dev_addr, size, swiotlb_force),
+	TP_PROTO(struct device *dev, dma_addr_t dev_addr, size_t size),
+	TP_ARGS(dev, dev_addr, size),
 
 	TP_STRUCT__entry(
-		__string(	dev_name,	dev_name(dev)		)
-		__field(	u64,	dma_mask			)
-		__field(	dma_addr_t,	dev_addr		)
-		__field(	size_t,	size				)
-		__field(	enum swiotlb_force,	swiotlb_force	)
+		__string(dev_name, dev_name(dev))
+		__field(u64, dma_mask)
+		__field(dma_addr_t, dev_addr)
+		__field(size_t, size)
+		__field(bool, force)
 	),
 
 	TP_fast_assign(
@@ -29,19 +24,15 @@ TRACE_EVENT(swiotlb_bounced,
 		__entry->dma_mask = (dev->dma_mask ? *dev->dma_mask : 0);
 		__entry->dev_addr = dev_addr;
 		__entry->size = size;
-		__entry->swiotlb_force = swiotlb_force;
+		__entry->force = is_swiotlb_force_bounce(dev);
 	),
 
-	TP_printk("dev_name: %s dma_mask=%llx dev_addr=%llx "
-		"size=%zu %s",
+	TP_printk("dev_name: %s dma_mask=%llx dev_addr=%llx size=%zu %s",
 		__get_str(dev_name),
 		__entry->dma_mask,
 		(unsigned long long)__entry->dev_addr,
 		__entry->size,
-		__print_symbolic(__entry->swiotlb_force,
-			{ SWIOTLB_NORMAL,	"NORMAL" },
-			{ SWIOTLB_FORCE,	"FORCE" },
-			{ SWIOTLB_NO_FORCE,	"NO_FORCE" }))
+		__entry->force ? "FORCE" : "NORMAL")
 );
 
 #endif /*  _TRACE_SWIOTLB_H */
diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c
index a653fcf1fe6c2..ad604e5a0983d 100644
--- a/kernel/dma/swiotlb.c
+++ b/kernel/dma/swiotlb.c
@@ -69,7 +69,8 @@
 
 #define INVALID_PHYS_ADDR (~(phys_addr_t)0)
 
-enum swiotlb_force swiotlb_force;
+static bool swiotlb_force_bounce;
+static bool swiotlb_force_disable;
 
 struct io_tlb_mem io_tlb_default_mem;
 
@@ -88,9 +89,9 @@ setup_io_tlb_npages(char *str)
 	if (*str == ',')
 		++str;
 	if (!strcmp(str, "force"))
-		swiotlb_force = SWIOTLB_FORCE;
+		swiotlb_force_bounce = true;
 	else if (!strcmp(str, "noforce"))
-		swiotlb_force = SWIOTLB_NO_FORCE;
+		swiotlb_force_disable = true;
 
 	return 0;
 }
@@ -211,7 +212,7 @@ static void swiotlb_init_io_tlb_mem(struct io_tlb_mem *mem, phys_addr_t start,
 	mem->index = 0;
 	mem->late_alloc = late_alloc;
 
-	if (swiotlb_force == SWIOTLB_FORCE)
+	if (swiotlb_force_bounce)
 		mem->force_bounce = true;
 
 	spin_lock_init(&mem->lock);
@@ -233,12 +234,13 @@ static void swiotlb_init_io_tlb_mem(struct io_tlb_mem *mem, phys_addr_t start,
 	return;
 }
 
-int __init swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, int verbose)
+int __init swiotlb_init_with_tbl(char *tlb, unsigned long nslabs,
+		unsigned int flags)
 {
 	struct io_tlb_mem *mem = &io_tlb_default_mem;
 	size_t alloc_size;
 
-	if (swiotlb_force == SWIOTLB_NO_FORCE)
+	if (swiotlb_force_disable)
 		return 0;
 
 	/* protect against double initialization */
@@ -252,8 +254,9 @@ int __init swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, int verbose)
 		      __func__, alloc_size, PAGE_SIZE);
 
 	swiotlb_init_io_tlb_mem(mem, __pa(tlb), nslabs, false);
+	mem->force_bounce = flags & SWIOTLB_FORCE;
 
-	if (verbose)
+	if (flags & SWIOTLB_VERBOSE)
 		swiotlb_print_info();
 	return 0;
 }
@@ -262,20 +265,21 @@ int __init swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, int verbose)
  * Statically reserve bounce buffer space and initialize bounce buffer data
  * structures for the software IO TLB used to implement the DMA API.
  */
-void  __init
-swiotlb_init(int verbose)
+void __init swiotlb_init(bool addressing_limit, unsigned int flags)
 {
 	size_t bytes = PAGE_ALIGN(default_nslabs << IO_TLB_SHIFT);
 	void *tlb;
 
-	if (swiotlb_force == SWIOTLB_NO_FORCE)
+	if (!addressing_limit && !swiotlb_force_bounce)
+		return;
+	if (swiotlb_force_disable)
 		return;
 
 	/* Get IO TLB memory from the low pages */
 	tlb = memblock_alloc_low(bytes, PAGE_SIZE);
 	if (!tlb)
 		goto fail;
-	if (swiotlb_init_with_tbl(tlb, default_nslabs, verbose))
+	if (swiotlb_init_with_tbl(tlb, default_nslabs, flags))
 		goto fail_free_mem;
 	return;
 
@@ -298,7 +302,7 @@ int swiotlb_init_late(size_t size, gfp_t gfp_mask)
 	unsigned int order;
 	int rc = 0;
 
-	if (swiotlb_force == SWIOTLB_NO_FORCE)
+	if (swiotlb_force_disable)
 		return 0;
 
 	/*
@@ -337,7 +341,7 @@ swiotlb_late_init_with_tbl(char *tlb, unsigned long nslabs)
 	struct io_tlb_mem *mem = &io_tlb_default_mem;
 	unsigned long bytes = nslabs << IO_TLB_SHIFT;
 
-	if (swiotlb_force == SWIOTLB_NO_FORCE)
+	if (swiotlb_force_disable)
 		return 0;
 
 	/* protect against double initialization */
@@ -362,7 +366,7 @@ void __init swiotlb_exit(void)
 	unsigned long tbl_vaddr;
 	size_t tbl_size, slots_size;
 
-	if (swiotlb_force == SWIOTLB_FORCE)
+	if (swiotlb_force_bounce)
 		return;
 
 	if (!mem->nslabs)
@@ -708,8 +712,7 @@ dma_addr_t swiotlb_map(struct device *dev, phys_addr_t paddr, size_t size,
 	phys_addr_t swiotlb_addr;
 	dma_addr_t dma_addr;
 
-	trace_swiotlb_bounced(dev, phys_to_dma(dev, paddr), size,
-			      swiotlb_force);
+	trace_swiotlb_bounced(dev, phys_to_dma(dev, paddr), size);
 
 	swiotlb_addr = swiotlb_tbl_map_single(dev, paddr, size, size, 0, dir,
 			attrs);
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Sun Feb 27 14:31:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 27 Feb 2022 14:31:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279969.477820 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOKab-00067M-E9; Sun, 27 Feb 2022 14:31:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279969.477820; Sun, 27 Feb 2022 14:31:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOKab-00067B-9u; Sun, 27 Feb 2022 14:31:57 +0000
Received: by outflank-mailman (input) for mailman id 279969;
 Sun, 27 Feb 2022 14:31:55 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=jKox=TK=bombadil.srs.infradead.org=BATV+9eb748f383daf30c13ac+6762+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nOKaZ-0002ik-AI
 for xen-devel@lists.xenproject.org; Sun, 27 Feb 2022 14:31:55 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0218b33c-97da-11ec-8eba-a37418f5ba1a;
 Sun, 27 Feb 2022 15:31:54 +0100 (CET)
Received: from [213.208.157.39] (helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nOKaJ-009ODX-I5; Sun, 27 Feb 2022 14:31:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0218b33c-97da-11ec-8eba-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=e5WrycmUWO29UJfUDorb7NMshMB8lzYVa/Mc+LVTrQY=; b=M6zu15mMoPH+9m8brqTPBHG/MC
	A1xLxoqDKLMvUNkNY0qpBK3uCp9lzGbLcGsqRUtjocz8fFQc+1Futvsr0HDC5pQub0V5q/IW3X5DM
	XxT5xEwpQjzqXMlvqCLscqKv2vSze/CFvVJlqhNLpKFBHw+q/Ttav1/C/auhHll/1QYCggzmQ6G3g
	T8DM1uznPKhTcSGXsvggUq1ncptnYaXLXKrgoWT4BKmLcAnZxTCKsRFwCtON9/siNdio+Iut29G9K
	TuuFBRx65ncACOSJM/GWPdJq+7cv8bsg3M9Q6EqQhIa2RVRROr1HXP+p2mSW9tbbJ0hY2MOkl60xF
	OWiusQpw==;
From: Christoph Hellwig <hch@lst.de>
To: iommu@lists.linux-foundation.org
Cc: x86@kernel.org,
	Anshuman Khandual <anshuman.khandual@arm.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Joerg Roedel <joro@8bytes.org>,
	David Woodhouse <dwmw2@infradead.org>,
	Lu Baolu <baolu.lu@linux.intel.com>,
	Robin Murphy <robin.murphy@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	xen-devel@lists.xenproject.org,
	linux-ia64@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	tboot-devel@lists.sourceforge.net,
	linux-pci@vger.kernel.org
Subject: [PATCH 09/11] swiotlb: add a SWIOTLB_ANY flag to lift the low memory restriction
Date: Sun, 27 Feb 2022 15:30:53 +0100
Message-Id: <20220227143055.335596-10-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220227143055.335596-1-hch@lst.de>
References: <20220227143055.335596-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Power SVM wants to allocate a swiotlb buffer that is not restricted to
low memory for the trusted hypervisor scheme.  Consolidate the support
for this into the swiotlb_init interface by adding a new flag.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 arch/powerpc/include/asm/svm.h       |  4 ----
 arch/powerpc/mm/mem.c                |  5 +----
 arch/powerpc/platforms/pseries/svm.c | 26 +-------------------------
 include/linux/swiotlb.h              |  1 +
 kernel/dma/swiotlb.c                 |  9 +++++++--
 5 files changed, 10 insertions(+), 35 deletions(-)

diff --git a/arch/powerpc/include/asm/svm.h b/arch/powerpc/include/asm/svm.h
index 7546402d796af..85580b30aba48 100644
--- a/arch/powerpc/include/asm/svm.h
+++ b/arch/powerpc/include/asm/svm.h
@@ -15,8 +15,6 @@ static inline bool is_secure_guest(void)
 	return mfmsr() & MSR_S;
 }
 
-void __init svm_swiotlb_init(void);
-
 void dtl_cache_ctor(void *addr);
 #define get_dtl_cache_ctor()	(is_secure_guest() ? dtl_cache_ctor : NULL)
 
@@ -27,8 +25,6 @@ static inline bool is_secure_guest(void)
 	return false;
 }
 
-static inline void svm_swiotlb_init(void) {}
-
 #define get_dtl_cache_ctor() NULL
 
 #endif /* CONFIG_PPC_SVM */
diff --git a/arch/powerpc/mm/mem.c b/arch/powerpc/mm/mem.c
index d99b8b5b40ca6..a4d65418c30a9 100644
--- a/arch/powerpc/mm/mem.c
+++ b/arch/powerpc/mm/mem.c
@@ -249,10 +249,7 @@ void __init mem_init(void)
 	 * back to to-down.
 	 */
 	memblock_set_bottom_up(true);
-	if (is_secure_guest())
-		svm_swiotlb_init();
-	else
-		swiotlb_init(ppc_swiotlb_enable, ppc_swiotlb_flags);
+	swiotlb_init(ppc_swiotlb_enable, ppc_swiotlb_flags);
 #endif
 
 	high_memory = (void *) __va(max_low_pfn * PAGE_SIZE);
diff --git a/arch/powerpc/platforms/pseries/svm.c b/arch/powerpc/platforms/pseries/svm.c
index c5228f4969eb2..3b4045d508ec8 100644
--- a/arch/powerpc/platforms/pseries/svm.c
+++ b/arch/powerpc/platforms/pseries/svm.c
@@ -28,7 +28,7 @@ static int __init init_svm(void)
 	 * need to use the SWIOTLB buffer for DMA even if dma_capable() says
 	 * otherwise.
 	 */
-	swiotlb_force = SWIOTLB_FORCE;
+	ppc_swiotlb_flags |= SWIOTLB_ANY | SWIOTLB_FORCE;
 
 	/* Share the SWIOTLB buffer with the host. */
 	swiotlb_update_mem_attributes();
@@ -37,30 +37,6 @@ static int __init init_svm(void)
 }
 machine_early_initcall(pseries, init_svm);
 
-/*
- * Initialize SWIOTLB. Essentially the same as swiotlb_init(), except that it
- * can allocate the buffer anywhere in memory. Since the hypervisor doesn't have
- * any addressing limitation, we don't need to allocate it in low addresses.
- */
-void __init svm_swiotlb_init(void)
-{
-	unsigned char *vstart;
-	unsigned long bytes, io_tlb_nslabs;
-
-	io_tlb_nslabs = (swiotlb_size_or_default() >> IO_TLB_SHIFT);
-	io_tlb_nslabs = ALIGN(io_tlb_nslabs, IO_TLB_SEGSIZE);
-
-	bytes = io_tlb_nslabs << IO_TLB_SHIFT;
-
-	vstart = memblock_alloc(PAGE_ALIGN(bytes), PAGE_SIZE);
-	if (vstart && !swiotlb_init_with_tbl(vstart, io_tlb_nslabs, false))
-		return;
-
-
-	memblock_free(vstart, PAGE_ALIGN(io_tlb_nslabs << IO_TLB_SHIFT));
-	panic("SVM: Cannot allocate SWIOTLB buffer");
-}
-
 int set_memory_encrypted(unsigned long addr, int numpages)
 {
 	if (!cc_platform_has(CC_ATTR_MEM_ENCRYPT))
diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h
index dcecf953f7997..ee655f2e4d28b 100644
--- a/include/linux/swiotlb.h
+++ b/include/linux/swiotlb.h
@@ -15,6 +15,7 @@ struct scatterlist;
 
 #define SWIOTLB_VERBOSE	(1 << 0) /* verbose initialization */
 #define SWIOTLB_FORCE	(1 << 1) /* force bounce buffering */
+#define SWIOTLB_ANY	(1 << 2) /* allow any memory for the buffer */
 
 /*
  * Maximum allowable number of contiguous slabs to map,
diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c
index ad604e5a0983d..ec200e40fc397 100644
--- a/kernel/dma/swiotlb.c
+++ b/kernel/dma/swiotlb.c
@@ -275,8 +275,13 @@ void __init swiotlb_init(bool addressing_limit, unsigned int flags)
 	if (swiotlb_force_disable)
 		return;
 
-	/* Get IO TLB memory from the low pages */
-	tlb = memblock_alloc_low(bytes, PAGE_SIZE);
+	/*
+	 * By default allocate the bonuce buffer memory from low memory.
+	 */
+	if (flags & SWIOTLB_ANY)
+		tlb = memblock_alloc(bytes, PAGE_SIZE);
+	else
+		tlb = memblock_alloc_low(bytes, PAGE_SIZE);
 	if (!tlb)
 		goto fail;
 	if (swiotlb_init_with_tbl(tlb, default_nslabs, flags))
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Sun Feb 27 14:32:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 27 Feb 2022 14:32:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.279975.477831 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOKaf-0006Zk-Qx; Sun, 27 Feb 2022 14:32:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 279975.477831; Sun, 27 Feb 2022 14:32:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOKaf-0006ZZ-MT; Sun, 27 Feb 2022 14:32:01 +0000
Received: by outflank-mailman (input) for mailman id 279975;
 Sun, 27 Feb 2022 14:32:00 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=jKox=TK=bombadil.srs.infradead.org=BATV+9eb748f383daf30c13ac+6762+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nOKae-0002ik-E3
 for xen-devel@lists.xenproject.org; Sun, 27 Feb 2022 14:32:00 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 042def4d-97da-11ec-8eba-a37418f5ba1a;
 Sun, 27 Feb 2022 15:31:58 +0100 (CET)
Received: from [213.208.157.39] (helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nOKaO-009OG2-1J; Sun, 27 Feb 2022 14:31:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 042def4d-97da-11ec-8eba-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=Cyjl4t+7FTO1M8Vjk3i/x3mfCdgghJXKTni0GBp1uHk=; b=RmcR/O+cWWHohA8RJ6wYRJB+Oz
	TsZCLGz1mqafzyebn0zhnF/l/RKex1Qp2uRmrN6AsvDu5oeztMeKyZHKKAOi66xNl/fPAhiwNJWTn
	N0v1S2SBo3EadFErMb5ltLYZt4yfXuYpYZRUMgmFsFyQPH07Tt7k7M4U6QPbcUEKJKK1Ifcll6BTu
	1ZmILgS76sJlNhXYrheTQJixlxFTKlrqSmC8eQV2YSNjHX4XkK6oMfUSW4hNQgkMw6w54JzMrT2A2
	IdUQgMQW4HGyBhd0buRL2as1EgB+GgfQrUaFmYbNm9yZNkqNqIXaETdJJ/crul0aXUDLZkcEOnN/N
	uXlJhIZA==;
From: Christoph Hellwig <hch@lst.de>
To: iommu@lists.linux-foundation.org
Cc: x86@kernel.org,
	Anshuman Khandual <anshuman.khandual@arm.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Joerg Roedel <joro@8bytes.org>,
	David Woodhouse <dwmw2@infradead.org>,
	Lu Baolu <baolu.lu@linux.intel.com>,
	Robin Murphy <robin.murphy@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	xen-devel@lists.xenproject.org,
	linux-ia64@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	tboot-devel@lists.sourceforge.net,
	linux-pci@vger.kernel.org
Subject: [PATCH 10/11] swiotlb: merge swiotlb-xen initialization into swiotlb
Date: Sun, 27 Feb 2022 15:30:54 +0100
Message-Id: <20220227143055.335596-11-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220227143055.335596-1-hch@lst.de>
References: <20220227143055.335596-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Allow to pass a remap argument to the swiotlb initialization functions
to handle the Xen/x86 remap case.  ARM/ARM64 never did any remapping
from xen_swiotlb_fixup, so we don't even need that quirk.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 arch/arm/xen/mm.c               |  23 +++---
 arch/x86/include/asm/xen/page.h |   5 --
 arch/x86/kernel/pci-dma.c       |  19 +++--
 arch/x86/pci/sta2x11-fixup.c    |   2 +-
 drivers/xen/swiotlb-xen.c       | 128 +-------------------------------
 include/linux/swiotlb.h         |   7 +-
 include/xen/arm/page.h          |   1 -
 include/xen/swiotlb-xen.h       |   8 +-
 kernel/dma/swiotlb.c            | 120 +++++++++++++++---------------
 9 files changed, 96 insertions(+), 217 deletions(-)

diff --git a/arch/arm/xen/mm.c b/arch/arm/xen/mm.c
index a7e54a087b802..58b40f87617d3 100644
--- a/arch/arm/xen/mm.c
+++ b/arch/arm/xen/mm.c
@@ -23,22 +23,20 @@
 #include <asm/xen/hypercall.h>
 #include <asm/xen/interface.h>
 
-unsigned long xen_get_swiotlb_free_pages(unsigned int order)
+static gfp_t xen_swiotlb_gfp(void)
 {
 	phys_addr_t base;
-	gfp_t flags = __GFP_NOWARN|__GFP_KSWAPD_RECLAIM;
 	u64 i;
 
 	for_each_mem_range(i, &base, NULL) {
 		if (base < (phys_addr_t)0xffffffff) {
 			if (IS_ENABLED(CONFIG_ZONE_DMA32))
-				flags |= __GFP_DMA32;
-			else
-				flags |= __GFP_DMA;
-			break;
+				return __GFP_DMA32;
+			return __GFP_DMA;
 		}
 	}
-	return __get_free_pages(flags, order);
+
+	return GFP_KERNEL;
 }
 
 static bool hypercall_cflush = false;
@@ -143,10 +141,15 @@ static int __init xen_mm_init(void)
 	if (!xen_swiotlb_detect())
 		return 0;
 
-	rc = xen_swiotlb_init();
 	/* we can work with the default swiotlb */
-	if (rc < 0 && rc != -EEXIST)
-		return rc;
+	if (!io_tlb_default_mem.nslabs) {
+		if (!xen_initial_domain())
+			return -EINVAL;
+		rc = swiotlb_init_late(swiotlb_size_or_default(),
+				       xen_swiotlb_gfp(), NULL);
+		if (rc < 0)
+			return rc;
+	}
 
 	cflush.op = 0;
 	cflush.a.dev_bus_addr = 0;
diff --git a/arch/x86/include/asm/xen/page.h b/arch/x86/include/asm/xen/page.h
index e989bc2269f54..1fc67df500145 100644
--- a/arch/x86/include/asm/xen/page.h
+++ b/arch/x86/include/asm/xen/page.h
@@ -357,9 +357,4 @@ static inline bool xen_arch_need_swiotlb(struct device *dev,
 	return false;
 }
 
-static inline unsigned long xen_get_swiotlb_free_pages(unsigned int order)
-{
-	return __get_free_pages(__GFP_NOWARN, order);
-}
-
 #endif /* _ASM_X86_XEN_PAGE_H */
diff --git a/arch/x86/kernel/pci-dma.c b/arch/x86/kernel/pci-dma.c
index bb08184a50e3a..b0901f027cdcd 100644
--- a/arch/x86/kernel/pci-dma.c
+++ b/arch/x86/kernel/pci-dma.c
@@ -68,15 +68,12 @@ static inline void __init pci_swiotlb_detect_4gb(void)
 #endif /* CONFIG_SWIOTLB */
 
 #ifdef CONFIG_SWIOTLB_XEN
-static bool xen_swiotlb;
-
 static void __init pci_xen_swiotlb_init(void)
 {
 	if (!xen_initial_domain() && !x86_swiotlb_enable)
 		return;
 	x86_swiotlb_enable = false;
-	xen_swiotlb = true;
-	xen_swiotlb_init_early();
+	swiotlb_init_remap(true, x86_swiotlb_flags, xen_swiotlb_fixup);
 	dma_ops = &xen_swiotlb_dma_ops;
 	if (IS_ENABLED(CONFIG_PCI))
 		pci_request_acs();
@@ -84,14 +81,16 @@ static void __init pci_xen_swiotlb_init(void)
 
 int pci_xen_swiotlb_init_late(void)
 {
-	int rc;
-
-	if (xen_swiotlb)
+	if (dma_ops == &xen_swiotlb_dma_ops)
 		return 0;
 
-	rc = xen_swiotlb_init();
-	if (rc)
-		return rc;
+	/* we can work with the default swiotlb */
+	if (!io_tlb_default_mem.nslabs) {
+		int rc = swiotlb_init_late(swiotlb_size_or_default(),
+					   GFP_KERNEL, xen_swiotlb_fixup);
+		if (rc < 0)
+			return rc;
+	}
 
 	/* XXX: this switches the dma ops under live devices! */
 	dma_ops = &xen_swiotlb_dma_ops;
diff --git a/arch/x86/pci/sta2x11-fixup.c b/arch/x86/pci/sta2x11-fixup.c
index c7e6faf59a861..7368afc039987 100644
--- a/arch/x86/pci/sta2x11-fixup.c
+++ b/arch/x86/pci/sta2x11-fixup.c
@@ -57,7 +57,7 @@ static void sta2x11_new_instance(struct pci_dev *pdev)
 		int size = STA2X11_SWIOTLB_SIZE;
 		/* First instance: register your own swiotlb area */
 		dev_info(&pdev->dev, "Using SWIOTLB (size %i)\n", size);
-		if (swiotlb_init_late(size, GFP_DMA))
+		if (swiotlb_init_late(size, GFP_DMA, NULL))
 			dev_emerg(&pdev->dev, "init swiotlb failed\n");
 	}
 	list_add(&instance->list, &sta2x11_instance_list);
diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c
index c2da3eb4826e8..df8085b50df10 100644
--- a/drivers/xen/swiotlb-xen.c
+++ b/drivers/xen/swiotlb-xen.c
@@ -104,7 +104,7 @@ static int is_xen_swiotlb_buffer(struct device *dev, dma_addr_t dma_addr)
 	return 0;
 }
 
-static int xen_swiotlb_fixup(void *buf, unsigned long nslabs)
+int xen_swiotlb_fixup(void *buf, unsigned long nslabs)
 {
 	int rc;
 	unsigned int order = get_order(IO_TLB_SEGSIZE << IO_TLB_SHIFT);
@@ -130,132 +130,6 @@ static int xen_swiotlb_fixup(void *buf, unsigned long nslabs)
 	return 0;
 }
 
-enum xen_swiotlb_err {
-	XEN_SWIOTLB_UNKNOWN = 0,
-	XEN_SWIOTLB_ENOMEM,
-	XEN_SWIOTLB_EFIXUP
-};
-
-static const char *xen_swiotlb_error(enum xen_swiotlb_err err)
-{
-	switch (err) {
-	case XEN_SWIOTLB_ENOMEM:
-		return "Cannot allocate Xen-SWIOTLB buffer\n";
-	case XEN_SWIOTLB_EFIXUP:
-		return "Failed to get contiguous memory for DMA from Xen!\n"\
-		    "You either: don't have the permissions, do not have"\
-		    " enough free memory under 4GB, or the hypervisor memory"\
-		    " is too fragmented!";
-	default:
-		break;
-	}
-	return "";
-}
-
-int xen_swiotlb_init(void)
-{
-	enum xen_swiotlb_err m_ret = XEN_SWIOTLB_UNKNOWN;
-	unsigned long bytes = swiotlb_size_or_default();
-	unsigned long nslabs = bytes >> IO_TLB_SHIFT;
-	unsigned int order, repeat = 3;
-	int rc = -ENOMEM;
-	char *start;
-
-	if (io_tlb_default_mem.nslabs) {
-		pr_warn("swiotlb buffer already initialized\n");
-		return -EEXIST;
-	}
-
-retry:
-	m_ret = XEN_SWIOTLB_ENOMEM;
-	order = get_order(bytes);
-
-	/*
-	 * Get IO TLB memory from any location.
-	 */
-#define SLABS_PER_PAGE (1 << (PAGE_SHIFT - IO_TLB_SHIFT))
-#define IO_TLB_MIN_SLABS ((1<<20) >> IO_TLB_SHIFT)
-	while ((SLABS_PER_PAGE << order) > IO_TLB_MIN_SLABS) {
-		start = (void *)xen_get_swiotlb_free_pages(order);
-		if (start)
-			break;
-		order--;
-	}
-	if (!start)
-		goto exit;
-	if (order != get_order(bytes)) {
-		pr_warn("Warning: only able to allocate %ld MB for software IO TLB\n",
-			(PAGE_SIZE << order) >> 20);
-		nslabs = SLABS_PER_PAGE << order;
-		bytes = nslabs << IO_TLB_SHIFT;
-	}
-
-	/*
-	 * And replace that memory with pages under 4GB.
-	 */
-	rc = xen_swiotlb_fixup(start, nslabs);
-	if (rc) {
-		free_pages((unsigned long)start, order);
-		m_ret = XEN_SWIOTLB_EFIXUP;
-		goto error;
-	}
-	rc = swiotlb_late_init_with_tbl(start, nslabs);
-	if (rc)
-		return rc;
-	return 0;
-error:
-	if (nslabs > 1024 && repeat--) {
-		/* Min is 2MB */
-		nslabs = max(1024UL, ALIGN(nslabs >> 1, IO_TLB_SEGSIZE));
-		bytes = nslabs << IO_TLB_SHIFT;
-		pr_info("Lowering to %luMB\n", bytes >> 20);
-		goto retry;
-	}
-exit:
-	pr_err("%s (rc:%d)\n", xen_swiotlb_error(m_ret), rc);
-	return rc;
-}
-
-#ifdef CONFIG_X86
-void __init xen_swiotlb_init_early(void)
-{
-	unsigned long bytes = swiotlb_size_or_default();
-	unsigned long nslabs = bytes >> IO_TLB_SHIFT;
-	unsigned int repeat = 3;
-	char *start;
-	int rc;
-
-retry:
-	/*
-	 * Get IO TLB memory from any location.
-	 */
-	start = memblock_alloc(PAGE_ALIGN(bytes),
-			       IO_TLB_SEGSIZE << IO_TLB_SHIFT);
-	if (!start)
-		panic("%s: Failed to allocate %lu bytes\n",
-		      __func__, PAGE_ALIGN(bytes));
-
-	/*
-	 * And replace that memory with pages under 4GB.
-	 */
-	rc = xen_swiotlb_fixup(start, nslabs);
-	if (rc) {
-		memblock_free(start, PAGE_ALIGN(bytes));
-		if (nslabs > 1024 && repeat--) {
-			/* Min is 2MB */
-			nslabs = max(1024UL, ALIGN(nslabs >> 1, IO_TLB_SEGSIZE));
-			bytes = nslabs << IO_TLB_SHIFT;
-			pr_info("Lowering to %luMB\n", bytes >> 20);
-			goto retry;
-		}
-		panic("%s (rc:%d)", xen_swiotlb_error(XEN_SWIOTLB_EFIXUP), rc);
-	}
-
-	if (swiotlb_init_with_tbl(start, nslabs, SWIOTLB_VERBOSE))
-		panic("Cannot allocate SWIOTLB buffer");
-}
-#endif /* CONFIG_X86 */
-
 static void *
 xen_swiotlb_alloc_coherent(struct device *hwdev, size_t size,
 			   dma_addr_t *dma_handle, gfp_t flags,
diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h
index ee655f2e4d28b..919cf82ed978e 100644
--- a/include/linux/swiotlb.h
+++ b/include/linux/swiotlb.h
@@ -34,10 +34,11 @@ struct scatterlist;
 /* default to 64MB */
 #define IO_TLB_DEFAULT_SIZE (64UL<<20)
 
-int swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, unsigned int flags);
 unsigned long swiotlb_size_or_default(void);
-extern int swiotlb_late_init_with_tbl(char *tlb, unsigned long nslabs);
-int swiotlb_init_late(size_t size, gfp_t gfp_mask);
+int swiotlb_init_late(size_t size, gfp_t gfp_mask,
+		int (*remap)(void *tlb, unsigned long nslabs));
+void __init swiotlb_init_remap(bool addressing_limit, unsigned int flags,
+		int (*remap)(void *tlb, unsigned long nslabs));
 extern void __init swiotlb_update_mem_attributes(void);
 
 phys_addr_t swiotlb_tbl_map_single(struct device *hwdev, phys_addr_t phys,
diff --git a/include/xen/arm/page.h b/include/xen/arm/page.h
index ac1b654705631..7e199c6656b90 100644
--- a/include/xen/arm/page.h
+++ b/include/xen/arm/page.h
@@ -115,6 +115,5 @@ static inline bool set_phys_to_machine(unsigned long pfn, unsigned long mfn)
 bool xen_arch_need_swiotlb(struct device *dev,
 			   phys_addr_t phys,
 			   dma_addr_t dev_addr);
-unsigned long xen_get_swiotlb_free_pages(unsigned int order);
 
 #endif /* _ASM_ARM_XEN_PAGE_H */
diff --git a/include/xen/swiotlb-xen.h b/include/xen/swiotlb-xen.h
index b3e647f86e3e2..590ceb923f0c8 100644
--- a/include/xen/swiotlb-xen.h
+++ b/include/xen/swiotlb-xen.h
@@ -10,8 +10,12 @@ void xen_dma_sync_for_cpu(struct device *dev, dma_addr_t handle,
 void xen_dma_sync_for_device(struct device *dev, dma_addr_t handle,
 			     size_t size, enum dma_data_direction dir);
 
-int xen_swiotlb_init(void);
-void __init xen_swiotlb_init_early(void);
+#ifdef CONFIG_SWIOTLB_XEN
+int xen_swiotlb_fixup(void *buf, unsigned long nslabs);
+#else
+#define xen_swiotlb_fixup NULL
+#endif
+
 extern const struct dma_map_ops xen_swiotlb_dma_ops;
 
 #endif /* __LINUX_SWIOTLB_XEN_H */
diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c
index ec200e40fc397..35ee2318ea563 100644
--- a/kernel/dma/swiotlb.c
+++ b/kernel/dma/swiotlb.c
@@ -234,40 +234,17 @@ static void swiotlb_init_io_tlb_mem(struct io_tlb_mem *mem, phys_addr_t start,
 	return;
 }
 
-int __init swiotlb_init_with_tbl(char *tlb, unsigned long nslabs,
-		unsigned int flags)
-{
-	struct io_tlb_mem *mem = &io_tlb_default_mem;
-	size_t alloc_size;
-
-	if (swiotlb_force_disable)
-		return 0;
-
-	/* protect against double initialization */
-	if (WARN_ON_ONCE(mem->nslabs))
-		return -ENOMEM;
-
-	alloc_size = PAGE_ALIGN(array_size(sizeof(*mem->slots), nslabs));
-	mem->slots = memblock_alloc(alloc_size, PAGE_SIZE);
-	if (!mem->slots)
-		panic("%s: Failed to allocate %zu bytes align=0x%lx\n",
-		      __func__, alloc_size, PAGE_SIZE);
-
-	swiotlb_init_io_tlb_mem(mem, __pa(tlb), nslabs, false);
-	mem->force_bounce = flags & SWIOTLB_FORCE;
-
-	if (flags & SWIOTLB_VERBOSE)
-		swiotlb_print_info();
-	return 0;
-}
-
 /*
  * Statically reserve bounce buffer space and initialize bounce buffer data
  * structures for the software IO TLB used to implement the DMA API.
  */
-void __init swiotlb_init(bool addressing_limit, unsigned int flags)
+void __init swiotlb_init_remap(bool addressing_limit, unsigned int flags,
+		int (*remap)(void *tlb, unsigned long nslabs))
 {
-	size_t bytes = PAGE_ALIGN(default_nslabs << IO_TLB_SHIFT);
+	struct io_tlb_mem *mem = &io_tlb_default_mem;
+	unsigned long nslabs = default_nslabs;
+	size_t alloc_size = PAGE_ALIGN(array_size(sizeof(*mem->slots), nslabs));
+	size_t bytes;
 	void *tlb;
 
 	if (!addressing_limit && !swiotlb_force_bounce)
@@ -275,23 +252,48 @@ void __init swiotlb_init(bool addressing_limit, unsigned int flags)
 	if (swiotlb_force_disable)
 		return;
 
+	/* protect against double initialization */
+	if (WARN_ON_ONCE(mem->nslabs))
+		return;
+
 	/*
 	 * By default allocate the bonuce buffer memory from low memory.
 	 */
+retry:
+	bytes = PAGE_ALIGN(default_nslabs << IO_TLB_SHIFT);
 	if (flags & SWIOTLB_ANY)
 		tlb = memblock_alloc(bytes, PAGE_SIZE);
 	else
 		tlb = memblock_alloc_low(bytes, PAGE_SIZE);
 	if (!tlb)
-		goto fail;
-	if (swiotlb_init_with_tbl(tlb, default_nslabs, flags))
-		goto fail_free_mem;
-	return;
+		panic("%s: failed to allocate tlb structure\n", __func__);
+
+	if (remap && remap(tlb, nslabs) < 0) {
+		memblock_free(tlb, PAGE_ALIGN(bytes));
+
+		/* Min is 2MB */
+		if (nslabs <= 1024)
+			panic("%s: Failed to remap %zu bytes\n",
+			      __func__, bytes);
+		nslabs = max(1024UL, ALIGN(nslabs >> 1, IO_TLB_SEGSIZE));
+		goto retry;
+	}
+
+	mem->slots = memblock_alloc(alloc_size, PAGE_SIZE);
+	if (!mem->slots)
+		panic("%s: Failed to allocate %zu bytes align=0x%lx\n",
+		      __func__, alloc_size, PAGE_SIZE);
 
-fail_free_mem:
-	memblock_free(tlb, bytes);
-fail:
-	pr_warn("Cannot allocate buffer");
+	swiotlb_init_io_tlb_mem(mem, __pa(tlb), default_nslabs, false);
+	mem->force_bounce = flags & SWIOTLB_FORCE;
+
+	if (flags & SWIOTLB_VERBOSE)
+		swiotlb_print_info();
+}
+
+void __init swiotlb_init(bool addressing_limit, unsigned int flags)
+{
+	return swiotlb_init_remap(addressing_limit, flags, NULL);
 }
 
 /*
@@ -299,8 +301,10 @@ void __init swiotlb_init(bool addressing_limit, unsigned int flags)
  * initialize the swiotlb later using the slab allocator if needed.
  * This should be just like above, but with some error catching.
  */
-int swiotlb_init_late(size_t size, gfp_t gfp_mask)
+int swiotlb_init_late(size_t size, gfp_t gfp_mask,
+		int (*remap)(void *tlb, unsigned long nslabs))
 {
+	struct io_tlb_mem *mem = &io_tlb_default_mem;
 	unsigned long nslabs = ALIGN(size >> IO_TLB_SHIFT, IO_TLB_SEGSIZE);
 	unsigned long bytes;
 	unsigned char *vstart = NULL;
@@ -310,9 +314,14 @@ int swiotlb_init_late(size_t size, gfp_t gfp_mask)
 	if (swiotlb_force_disable)
 		return 0;
 
+	/* protect against double initialization */
+	if (WARN_ON_ONCE(mem->nslabs))
+		return -ENOMEM;
+
 	/*
 	 * Get IO TLB memory from the low pages
 	 */
+retry:
 	order = get_order(nslabs << IO_TLB_SHIFT);
 	nslabs = SLABS_PER_PAGE << order;
 	bytes = nslabs << IO_TLB_SHIFT;
@@ -333,33 +342,28 @@ int swiotlb_init_late(size_t size, gfp_t gfp_mask)
 			(PAGE_SIZE << order) >> 20);
 		nslabs = SLABS_PER_PAGE << order;
 	}
-	rc = swiotlb_late_init_with_tbl(vstart, nslabs);
-	if (rc)
-		free_pages((unsigned long)vstart, order);
-
-	return rc;
-}
-
-int
-swiotlb_late_init_with_tbl(char *tlb, unsigned long nslabs)
-{
-	struct io_tlb_mem *mem = &io_tlb_default_mem;
-	unsigned long bytes = nslabs << IO_TLB_SHIFT;
 
-	if (swiotlb_force_disable)
-		return 0;
+	if (remap)
+		rc = remap(vstart, nslabs);
+	if (rc) {
+		free_pages((unsigned long)vstart, order);
 
-	/* protect against double initialization */
-	if (WARN_ON_ONCE(mem->nslabs))
-		return -ENOMEM;
+		/* Min is 2MB */
+		if (nslabs <= 1024)
+			return rc;
+		nslabs = max(1024UL, ALIGN(nslabs >> 1, IO_TLB_SEGSIZE));
+		goto retry;
+	}
 
 	mem->slots = (void *)__get_free_pages(GFP_KERNEL | __GFP_ZERO,
 		get_order(array_size(sizeof(*mem->slots), nslabs)));
-	if (!mem->slots)
+	if (!mem->slots) {
+		free_pages((unsigned long)vstart, order);
 		return -ENOMEM;
+	}
 
-	set_memory_decrypted((unsigned long)tlb, bytes >> PAGE_SHIFT);
-	swiotlb_init_io_tlb_mem(mem, virt_to_phys(tlb), nslabs, true);
+	set_memory_decrypted((unsigned long)vstart, bytes >> PAGE_SHIFT);
+	swiotlb_init_io_tlb_mem(mem, virt_to_phys(vstart), nslabs, true);
 
 	swiotlb_print_info();
 	return 0;
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Sun Feb 27 14:33:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 27 Feb 2022 14:33:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280011.477842 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOKc8-0008W9-80; Sun, 27 Feb 2022 14:33:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280011.477842; Sun, 27 Feb 2022 14:33:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOKc8-0008W2-56; Sun, 27 Feb 2022 14:33:32 +0000
Received: by outflank-mailman (input) for mailman id 280011;
 Sun, 27 Feb 2022 14:33:30 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=jKox=TK=bombadil.srs.infradead.org=BATV+9eb748f383daf30c13ac+6762+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nOKc6-0008Vb-MQ
 for xen-devel@lists.xenproject.org; Sun, 27 Feb 2022 14:33:30 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3ae89d69-97da-11ec-8539-5f4723681683;
 Sun, 27 Feb 2022 15:33:29 +0100 (CET)
Received: from [213.208.157.39] (helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nOKZh-009Ntc-P9; Sun, 27 Feb 2022 14:31:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3ae89d69-97da-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=fpYq2gch6ejmPkcFKPjSyDr7OAs4OQSLe0uyAoUEPa0=; b=ihBj93GbCChJ0QpAjRhTh6iHDw
	0V6UJQeF355QVgLts1D1r2YGkHDA1vgqG1MCi6sSzX0aU/yqPgXefij6ux0UlqgXGjeB9/GRGKdYg
	oF8ivuYiEMCHvU+2SNZqnmJUHhwIQgxe00hyKYiad9mwYNBa3BW9GbsM5y7rI1HRXPxZCBGvuqRDR
	fiF4970M/qxQiqg+AXq0JYfsIzNIGaD3UqdTAtUgcyN1xzoE26/iw1TRFGJjIQxipIz85o+MC6Sul
	S52cjGS7vKJDa8qibbtunWtwfjPsgkLYNferGeEOzuQq41QVFs7XXLlP3G3aebutpxz/kUKPAwbwv
	5CtFglVw==;
From: Christoph Hellwig <hch@lst.de>
To: iommu@lists.linux-foundation.org
Cc: x86@kernel.org,
	Anshuman Khandual <anshuman.khandual@arm.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Joerg Roedel <joro@8bytes.org>,
	David Woodhouse <dwmw2@infradead.org>,
	Lu Baolu <baolu.lu@linux.intel.com>,
	Robin Murphy <robin.murphy@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	xen-devel@lists.xenproject.org,
	linux-ia64@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	tboot-devel@lists.sourceforge.net,
	linux-pci@vger.kernel.org
Subject: [PATCH 01/11] dma-direct: use is_swiotlb_active in dma_direct_map_page
Date: Sun, 27 Feb 2022 15:30:45 +0100
Message-Id: <20220227143055.335596-2-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220227143055.335596-1-hch@lst.de>
References: <20220227143055.335596-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

Use the more specific is_swiotlb_active check instead of checking the
global swiotlb_force variable.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>
---
 kernel/dma/direct.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/dma/direct.h b/kernel/dma/direct.h
index 4632b0f4f72eb..4dc16e08c7e1a 100644
--- a/kernel/dma/direct.h
+++ b/kernel/dma/direct.h
@@ -91,7 +91,7 @@ static inline dma_addr_t dma_direct_map_page(struct device *dev,
 		return swiotlb_map(dev, phys, size, dir, attrs);
 
 	if (unlikely(!dma_capable(dev, dma_addr, size, true))) {
-		if (swiotlb_force != SWIOTLB_NO_FORCE)
+		if (is_swiotlb_active(dev))
 			return swiotlb_map(dev, phys, size, dir, attrs);
 
 		dev_WARN_ONCE(dev, 1,
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Sun Feb 27 14:37:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 27 Feb 2022 14:37:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280031.477853 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOKfd-0000zz-ST; Sun, 27 Feb 2022 14:37:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280031.477853; Sun, 27 Feb 2022 14:37:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOKfd-0000zs-PC; Sun, 27 Feb 2022 14:37:09 +0000
Received: by outflank-mailman (input) for mailman id 280031;
 Sun, 27 Feb 2022 14:37:08 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=jKox=TK=bombadil.srs.infradead.org=BATV+9eb748f383daf30c13ac+6762+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1nOKak-0002ie-6T
 for xen-devel@lists.xenproject.org; Sun, 27 Feb 2022 14:32:06 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:e::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 076dba9c-97da-11ec-8539-5f4723681683;
 Sun, 27 Feb 2022 15:32:03 +0100 (CET)
Received: from [213.208.157.39] (helo=localhost)
 by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nOKaS-009OIV-2W; Sun, 27 Feb 2022 14:31:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 076dba9c-97da-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
	:Reply-To:Content-Type:Content-ID:Content-Description;
	bh=zCMW1Q+QCPXYuvBuEGOZUQKFwE9OwdLFtYhltvQ29K4=; b=gdyCXq66VbjetEyefeZjfrjLn/
	KFQQrvNuyQDreVuu13IHX3wfCfPHEtIxvJ6JqsMNDkY0USHKy7oCaTu4H7iFuqb2PQMxvCNBFLcYY
	KZ3LS1ks43RUB2OYoxYpQZJEd07kMZ/3qKopL/s5iB/o2XydyagggAPb3Te4EjfCBCXFCTg/Y8p9z
	2kSmzGmaN82rRP7wXwyQ+GOo4Uamo5zAprzgs98k8sgxtB+ZSJ4CjgiBANK9/V6D2jidQhWgoX7p0
	NcVk0BzE781U1ijtQTkpZZ2WxTbe57/8gozWq3sdLV4dZH4vLtkrv61f0R5MpjUuztFqcz/di9cxw
	Kqf5U4OQ==;
From: Christoph Hellwig <hch@lst.de>
To: iommu@lists.linux-foundation.org
Cc: x86@kernel.org,
	Anshuman Khandual <anshuman.khandual@arm.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Joerg Roedel <joro@8bytes.org>,
	David Woodhouse <dwmw2@infradead.org>,
	Lu Baolu <baolu.lu@linux.intel.com>,
	Robin Murphy <robin.murphy@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	xen-devel@lists.xenproject.org,
	linux-ia64@vger.kernel.org,
	linux-mips@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-s390@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	tboot-devel@lists.sourceforge.net,
	linux-pci@vger.kernel.org
Subject: [PATCH 11/11] x86: remove cruft from <asm/dma-mapping.h>
Date: Sun, 27 Feb 2022 15:30:55 +0100
Message-Id: <20220227143055.335596-12-hch@lst.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220227143055.335596-1-hch@lst.de>
References: <20220227143055.335596-1-hch@lst.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

<asm/dma-mapping.h> gets pulled in by all drivers using the DMA API.
Remove x86 internal variables and unnecessary includes from it.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 arch/x86/include/asm/dma-mapping.h | 11 -----------
 arch/x86/include/asm/iommu.h       |  2 ++
 2 files changed, 2 insertions(+), 11 deletions(-)

diff --git a/arch/x86/include/asm/dma-mapping.h b/arch/x86/include/asm/dma-mapping.h
index 256fd8115223d..1c66708e30623 100644
--- a/arch/x86/include/asm/dma-mapping.h
+++ b/arch/x86/include/asm/dma-mapping.h
@@ -2,17 +2,6 @@
 #ifndef _ASM_X86_DMA_MAPPING_H
 #define _ASM_X86_DMA_MAPPING_H
 
-/*
- * IOMMU interface. See Documentation/core-api/dma-api-howto.rst and
- * Documentation/core-api/dma-api.rst for documentation.
- */
-
-#include <linux/scatterlist.h>
-#include <asm/io.h>
-
-extern int iommu_merge;
-extern int panic_on_overflow;
-
 extern const struct dma_map_ops *dma_ops;
 
 static inline const struct dma_map_ops *get_arch_dma_ops(struct bus_type *bus)
diff --git a/arch/x86/include/asm/iommu.h b/arch/x86/include/asm/iommu.h
index dba89ed40d38d..0bef44d30a278 100644
--- a/arch/x86/include/asm/iommu.h
+++ b/arch/x86/include/asm/iommu.h
@@ -8,6 +8,8 @@
 
 extern int force_iommu, no_iommu;
 extern int iommu_detected;
+extern int iommu_merge;
+extern int panic_on_overflow;
 
 #ifdef CONFIG_SWIOTLB
 extern bool x86_swiotlb_enable;
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Sun Feb 27 18:15:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 27 Feb 2022 18:15:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280052.477869 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOO4u-0005Bs-FZ; Sun, 27 Feb 2022 18:15:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280052.477869; Sun, 27 Feb 2022 18:15:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOO4u-0005Bl-Bx; Sun, 27 Feb 2022 18:15:28 +0000
Received: by outflank-mailman (input) for mailman id 280052;
 Sun, 27 Feb 2022 18:15:27 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=kuAl=TK=csgroup.eu=christophe.leroy@srs-se1.protection.inumbo.net>)
 id 1nOO4t-0005Bf-97
 for xen-devel@lists.xenproject.org; Sun, 27 Feb 2022 18:15:27 +0000
Received: from FRA01-MR2-obe.outbound.protection.outlook.com
 (mail-mr2fra01on0625.outbound.protection.outlook.com
 [2a01:111:f400:7e19::625])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 3bfa8c69-97f9-11ec-8eba-a37418f5ba1a;
 Sun, 27 Feb 2022 19:15:25 +0100 (CET)
Received: from MRZP264MB2988.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:31::15)
 by MR1P264MB2739.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:38::10) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.21; Sun, 27 Feb
 2022 18:15:23 +0000
Received: from MRZP264MB2988.FRAP264.PROD.OUTLOOK.COM
 ([fe80::8142:2e6f:219b:646d]) by MRZP264MB2988.FRAP264.PROD.OUTLOOK.COM
 ([fe80::8142:2e6f:219b:646d%5]) with mapi id 15.20.5017.026; Sun, 27 Feb 2022
 18:15:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3bfa8c69-97f9-11ec-8eba-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=FqadLqcfGYl+WrjDxSTsDZ1Soph6sd5RiRO2Z6bfCcXgBtp/iLFx43WGLTFm+vqvKXbXlf0WHRmlPnaE5g0LnA6tu4taDnfdTpcgHpike1I4oOZjVT2ZkOgcCqK6goFQ8iNX7SreP/7giqb/kEP/wPWTT/dRhUA2O19CobuQu3C9FhulUqpZsmOgWpHc2Ic0SGFI+SVkBswga+RAQFAVbn3cWpR/lb+kDY4Zi76moC0D4N4J3/9iqlFtag2LA/QLf5PvfU/QxExMsuL1h072WAhbQ5I+CrOKVz5lsbynhwEnQZPCZqzD0s3e7NEK3XymaP6RSnVNQI/+O0OIvRPkKg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ZYeagP1ThBsatQ9DwHFI+wzQF/so3h8AME1EtCEpcHE=;
 b=A6ITEBqxj9nVZEfiySjQ2+I83Xc5drYGmwh5ryhGE/UH7hksKu28oMFTaAJzT/J7ukmqbSvzhR09TDN2j6zQdPbfT9d+tVmZXzPef/Shohr3iiPox62tWdBaPhWrXj2OJdAS0f5cXE8QPqz45eoAME2pIbvn9ADy8ibbEwTK7ugv+V/Knl0TXauLeMvzACr7UnghXrLiD+tvrlCHas9nMDDiJue7Ns8u4QBSy0cnQ+1STnvmYce26raTf28k/d7rgZnR0zO8oQexsWux3njqbpoOj+plNlOM1g6A77C/ixqT8r3VqREKzarSzico4dBscUr/zurrK1rDlx3eXNPNwA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=csgroup.eu; dmarc=pass action=none header.from=csgroup.eu;
 dkim=pass header.d=csgroup.eu; arc=none
From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Christoph Hellwig <hch@lst.de>, "iommu@lists.linux-foundation.org"
	<iommu@lists.linux-foundation.org>
CC: Juergen Gross <jgross@suse.com>, "linux-s390@vger.kernel.org"
	<linux-s390@vger.kernel.org>, "linux-hyperv@vger.kernel.org"
	<linux-hyperv@vger.kernel.org>, Stefano Stabellini <sstabellini@kernel.org>,
	"linux-ia64@vger.kernel.org" <linux-ia64@vger.kernel.org>, Anshuman Khandual
	<anshuman.khandual@arm.com>, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Robin Murphy <robin.murphy@arm.com>, Joerg Roedel <joro@8bytes.org>,
	"x86@kernel.org" <x86@kernel.org>, "linux-mips@vger.kernel.org"
	<linux-mips@vger.kernel.org>, "linuxppc-dev@lists.ozlabs.org"
	<linuxppc-dev@lists.ozlabs.org>, "tboot-devel@lists.sourceforge.net"
	<tboot-devel@lists.sourceforge.net>, "linux-pci@vger.kernel.org"
	<linux-pci@vger.kernel.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, Boris Ostrovsky
	<boris.ostrovsky@oracle.com>, David Woodhouse <dwmw2@infradead.org>,
	"linux-riscv@lists.infradead.org" <linux-riscv@lists.infradead.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, Lu Baolu <baolu.lu@linux.intel.com>
Subject: Re: [PATCH 08/11] swiotlb: make the swiotlb_init interface more
 useful
Thread-Topic: [PATCH 08/11] swiotlb: make the swiotlb_init interface more
 useful
Thread-Index: AQHYK+d7zyfGvpMeO0af+hVExH8R66yntCgA
Date: Sun, 27 Feb 2022 18:15:23 +0000
Message-ID: <3f5c827f-8e91-baef-7114-784a0c65e298@csgroup.eu>
References: <20220227143055.335596-1-hch@lst.de>
 <20220227143055.335596-9-hch@lst.de>
In-Reply-To: <20220227143055.335596-9-hch@lst.de>
Accept-Language: fr-FR, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=csgroup.eu;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 56a95360-498d-45de-c58d-08d9fa1d1f28
x-ms-traffictypediagnostic: MR1P264MB2739:EE_
x-microsoft-antispam-prvs:
 <MR1P264MB2739A46884510C4D4AB0BAA4ED009@MR1P264MB2739.FRAP264.PROD.OUTLOOK.COM>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 xxmOPUwaQx8LLpBnpnXVxQ9nSW575FipLBUYRNnsiQM/7xvGoPuo4q7W3FT50TX0JPsKpHrnWXqHFeCaA6hSNNvj4nRtRuIZ5kcQYzQ4CUFz16NbFveoqMnNUI7lCgTr3uKb8V+bUfFfu+YEBgCy5rV2RuF6udcUlEcq2ZTuj1UgVP3/0SRMahQCgn56flbgarqLLWKolrTi5ruvcjVj3tmTQw3DH1NBnDLqO1hkwwhBg7PqL0E3KeWz6yk/U+JGI7uqq1/jMI0vDkWSZa+HO9SPVhZq4E/UWy7qFjQehTtZ+ebOjUjvSBFE6KX34i6VBw+/c8RATZLaBVl0ZXkPATsa3v+4dtDzdysjgaOINCkaShgq3bansnOmYhaFZWKU6PFiayG6nXqNemEZPxM8BHnFhFYDCv+9XA/Y7E3a90ReiynkBLKsMSpYMtXmiS16xhAOc0Wkl2YuyITl5QqVmwOcPcuP6/EGvm5IaZWZz6HVOSelU9oYnjswWFUsu5nOfa2F8/5DS63ZYDvY+FRReTNxyyhUgzyahTgQBM+Y8i6NsGPkMA3zE8IVMCWyF2TA9XDyyn8+vH5OeqTRVBOHH/q7S1dqJ+x+eVUcn7h0C+Yqygg9IZWLJZNum3eqfsEpwUEznjxqEvroiCHDHCFAsxQBdTyGFArgm0S/5VRtlyZsG1TRMVdaJWTfGxrKX5urU1wH/oOL4V0642sOrqAAo6Xh4fvHd+Tl7Lp7skr7xgNkVPjCTAjPDmkAC5bBevPbqLz7zSQwWqfZldSy/WqhKw==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MRZP264MB2988.FRAP264.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(122000001)(26005)(8676002)(186003)(2616005)(110136005)(54906003)(508600001)(83380400001)(2906002)(6486002)(316002)(38070700005)(6512007)(5660300002)(4326008)(7416002)(8936002)(38100700002)(71200400001)(86362001)(6506007)(36756003)(31696002)(44832011)(31686004)(76116006)(64756008)(66946007)(91956017)(66476007)(66446008)(66556008)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?WENxQkFFMWlOQmxRWlFVY1FPWm4rT2VyOWJ6bUVJNW50QWcwZkVmWHZ6NjRT?=
 =?utf-8?B?S1QxWGIveEZJeG9oY1R3WnVacm5PYWVoZ1JRTTlwcG9tZTZBZldEQ0NNbElk?=
 =?utf-8?B?aEtMOStQam5LZC9aaXBSUXpCNmh1MmhMRW1lWmsybW8ybnBFQkNFSWZMb2hi?=
 =?utf-8?B?M0hJUFIrWmpEcjRSZ1g1dFhyYUwwWnkyK2lWb3U5L21GNHBKcThneE1VQStM?=
 =?utf-8?B?d3AwblVJS1EwTWl2eDRkVU1IcVlvSDVEQnF5bU5hOElpd29rTXJHMTVPVHB4?=
 =?utf-8?B?bE56SVJuZkJtRDI2b214NUZIOHJFanQ3NGFpZzc3M3h2cEJ5M29XZTlZN3Jz?=
 =?utf-8?B?SzFCYTR2a0lzdVRUL2VUZlpHTWlVTnVqOHJXcCtDWVFGUi80TGc0NEVhYTN4?=
 =?utf-8?B?RXU5L0lUb3JXWEIwTzhFRW53R3Q3Y2hiNUlwOUhCczZFeW5pbmF1azFMU2h5?=
 =?utf-8?B?azMxc1k2Y05KK1Nuc1FiVjdvc0tqOVRJam5xSmlPQjhvN05ZTjFmMGhaVkto?=
 =?utf-8?B?cThZYlp1Q3JkYmdLZXpWdUdmb1pQYVI1eHRLTHQyd25KQ1BIOXVpLzdZUlVx?=
 =?utf-8?B?TytNTTZYNXNzNTQ3RVdvOFVUeVJGVm9qMEg0QWFPVThmV3pvOXZraW9jbEl2?=
 =?utf-8?B?MDVKMHhSMjBrOEt4d1c3bTcyUzBaeWZobEVlVmlYaC9WZnA2Y01PVkg2c2ts?=
 =?utf-8?B?bWpodjFHbHVXNmkyOGFETmtJK29OYkxXMUtnM0ZQUHpDckU0S0RlcnkybUdy?=
 =?utf-8?B?MEtsRTNQeTgwc09uNGk4ZHpLNnNxS3czQzhsNU9pOFp5aG1NbzQ5TjJwbTZB?=
 =?utf-8?B?dlVhREI3Q2ozUXJsSlJESWRPU051TTFjR1VjMk0vbXNZRDJRV3d0aFdyOThR?=
 =?utf-8?B?YzlOZjhxaWVnK0ZGRE12YmJnc1VzQ0s0RStaYWFQa3d2aytnS3JreG1jViti?=
 =?utf-8?B?TTFoTkdSMGhrSWhTdTRCbnpjQWM5a2ViUGZzUVpZVnVUVWhPSFZTdktxVllZ?=
 =?utf-8?B?NEREaE9NNjh3RHdDWGprTkFKbHRuUGFnYUxVcVdvNUJoaWVKSkVmMDBPZlV4?=
 =?utf-8?B?QndkcUFHT09BV2lFdnU0ZWh4OEZGdm5ORVBQMGQ1MExyR2dSdUh4bUFiWHZj?=
 =?utf-8?B?dWlJVDcveGdmeDBqMHdQUTBNTW9JOUppbUtNTjVEblVhZk5FQVZibVJvQUlI?=
 =?utf-8?B?cndYY1ZCOHhIMW9aR1FwK3IzUVU1bXNMY214cEV1OVlLS0JwK3ZQU05uTFQ2?=
 =?utf-8?B?dUUxWmM3bjNoUy9uTFNYYnpBeERwWlllK1lGNzhFcEZWWm1xby90TU5WUTFi?=
 =?utf-8?B?bC8zRVFBZmdqbnd6ZnhqUldqTDJUVWljczRNRWw0dWlHSTRHWm1GT0dnQStM?=
 =?utf-8?B?UzZod0FWOFExWEdjMFgxQ3N4Zml4TkJkclVKK2Z0MkRFZUEyNEltQVVXSmZD?=
 =?utf-8?B?bXA3bktYYmMvNHQrQ1cyZ1ViMlhOV0o2eE9WUTVqZFRkaHZYc3ozRmQ5Vzg0?=
 =?utf-8?B?TjN4c0huYkJVUGhRRUxZakdjTFFHdDFDbVJSWEZIeTZxM3FhV0JPUW9RZjRV?=
 =?utf-8?B?T2ZmSjBxNmtENS9obTVuQ2Z0YkRGeDQzb0dRcWhwWm8xc0NvNmlpcEVXZ3N0?=
 =?utf-8?B?SUFSd0pPOXBJK2paTW9GaXlkS3BaSmVCMGd2QVdkejR6VkZ4L3F1TEN1MUxj?=
 =?utf-8?B?V0syYjVMc2lWNDRxRHgvYkp6Vmx1RS96OFJZeWlTa09ZR1lHd3ZuTXJUaUR5?=
 =?utf-8?B?WjlWNU9aQVQ4Z1J4Qm03TTJYcmc1aHd3K2kyRjkzcFhNZGdaR3pBWTBITk91?=
 =?utf-8?B?UmdNaTBOcURvbVZzT25LMHhtbnc4ZXgwSzY5c3lwWFI3c09FUk10eWcvUXI0?=
 =?utf-8?B?YW5lWUIwTHBqbUUvNjdkWW1QSExDdkFLbFQzVWVENlFBWW9rd2RZamNFRGt4?=
 =?utf-8?B?a3docll3N092cDluQU5yWUYzUkh3NWxTSjhiaFk2K3IrTVRpeFVoSEorbk1G?=
 =?utf-8?B?UklFTHFiNzZ2MnVQWVZQVTV0aHBHQjJtUUU4T1puTEdIRDRpMklwZ1IwS0h5?=
 =?utf-8?B?NjhRTGt3UFNMUTE1Qk1TUW1aZ3VtL0pGQ2hwamNKQjdlVGtVbGI5RStpcXM3?=
 =?utf-8?B?VnYrMGcxczRPUzNmd3ZIRnpVcVZDcDFvYzExdkNxQTQ3ZjNwYWs5UTRiMm92?=
 =?utf-8?B?SHVaemhaKzdIRkQzK3ZDNWJHSEtFRXlPWktreHFEMWYrd1dGMjBaM1lLTmhx?=
 =?utf-8?Q?Wl7cviTeVgjdbmGsZgp40TpeVnDMNNBet62fL335QU=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <9FE742FE772C63498FDD057F606855F7@FRAP264.PROD.OUTLOOK.COM>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: csgroup.eu
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MRZP264MB2988.FRAP264.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-Network-Message-Id: 56a95360-498d-45de-c58d-08d9fa1d1f28
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Feb 2022 18:15:23.2616
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 9914def7-b676-4fda-8815-5d49fb3b45c8
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: gXSMr13XVpww7GYaD/Ph/PhwcuDEoaMtD772s/Tdn5coknXaY0HeExMHE1599gZWn024x+s6+jPocxEPjmsR8BeloLsRDosVcorIF1UtvP0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MR1P264MB2739

DQoNCkxlIDI3LzAyLzIwMjIgw6AgMTU6MzAsIENocmlzdG9waCBIZWxsd2lnIGEgw6ljcml0wqA6
DQo+IFBhc3MgYSBib29sIHRvIHBhc3MgaWYgc3dpb3RsYiBuZWVkcyB0byBiZSBlbmFibGVkIGJh
c2VkIG9uIHRoZQ0KPiBhZGRyZXNzaW5nIG5lZWRzIGFuZCByZXBsYWNlIHRoZSB2ZXJib3NlIGFy
Z3VtZW50IHdpdGggYSBzZXQgb2YNCj4gZmxhZ3MsIGluY2x1ZGluZyBvbmUgdG8gZm9yY2UgZW5h
YmxlIGJvdW5jZSBidWZmZXJpbmcuDQo+IA0KPiBOb3RlIHRoYXQgdGhpcyBwYXRjaCByZW1vdmVz
IHRoZSBwb3NzaWJpbGl0eSB0byBmb3JjZSB4ZW4tc3dpb3RsYg0KPiB1c2UgdXNpbmcgc3dpb3Rs
Yj1mb3JjZSBvbiB0aGUgY29tbWFuZCBsaW5lIG9uIHg4NiAoYXJtIGFuZCBhcm02NA0KPiBuZXZl
ciBzdXBwb3J0ZWQgdGhhdCksIGJ1dCB0aGlzIGludGVyZmFjZSB3aWxsIGJlIHJlc3RvcmVkIHNo
b3J0bHkuDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBDaHJpc3RvcGggSGVsbHdpZyA8aGNoQGxzdC5k
ZT4NCj4gLS0tDQo+ICAgYXJjaC9hcm0vbW0vaW5pdC5jICAgICAgICAgICAgICAgICAgICAgfCAg
NiArLS0tLQ0KPiAgIGFyY2gvYXJtNjQvbW0vaW5pdC5jICAgICAgICAgICAgICAgICAgIHwgIDYg
Ky0tLS0NCj4gICBhcmNoL2lhNjQvbW0vaW5pdC5jICAgICAgICAgICAgICAgICAgICB8ICA0ICst
LQ0KPiAgIGFyY2gvbWlwcy9jYXZpdW0tb2N0ZW9uL2RtYS1vY3Rlb24uYyAgIHwgIDIgKy0NCj4g
ICBhcmNoL21pcHMvbG9vbmdzb242NC9kbWEuYyAgICAgICAgICAgICB8ICAyICstDQo+ICAgYXJj
aC9taXBzL3NpYnl0ZS9jb21tb24vZG1hLmMgICAgICAgICAgfCAgMiArLQ0KPiAgIGFyY2gvcG93
ZXJwYy9pbmNsdWRlL2FzbS9zd2lvdGxiLmggICAgIHwgIDEgKw0KPiAgIGFyY2gvcG93ZXJwYy9t
bS9tZW0uYyAgICAgICAgICAgICAgICAgIHwgIDMgKystDQoNCmFyY2gvcG93ZXJwYy9tbS9tZW0u
bzooLnRvYysweDApOiB1bmRlZmluZWQgcmVmZXJlbmNlIHRvIGBwcGNfc3dpb3RsYl9mbGFncycN
Cm1ha2VbMV06ICoqKiBbdm1saW51eF0gRXJyb3IgMQ0KL2xpbnV4L01ha2VmaWxlOjExNTU6IHJl
Y2lwZSBmb3IgdGFyZ2V0ICd2bWxpbnV4JyBmYWlsZWQNCg0KDQo+ICAgYXJjaC9wb3dlcnBjL3Bs
YXRmb3Jtcy9wc2VyaWVzL3NldHVwLmMgfCAgMyAtLS0NCj4gICBhcmNoL3Jpc2N2L21tL2luaXQu
YyAgICAgICAgICAgICAgICAgICB8ICA4ICstLS0tLQ0KPiAgIGFyY2gvczM5MC9tbS9pbml0LmMg
ICAgICAgICAgICAgICAgICAgIHwgIDMgKy0tDQo+ICAgYXJjaC94ODYva2VybmVsL2NwdS9tc2h5
cGVydi5jICAgICAgICAgfCAgOCAtLS0tLS0NCj4gICBhcmNoL3g4Ni9rZXJuZWwvcGNpLWRtYS5j
ICAgICAgICAgICAgICB8IDE1ICsrKysrKy0tLS0tDQo+ICAgYXJjaC94ODYvbW0vbWVtX2VuY3J5
cHRfYW1kLmMgICAgICAgICAgfCAgMyAtLS0NCj4gICBkcml2ZXJzL3hlbi9zd2lvdGxiLXhlbi5j
ICAgICAgICAgICAgICB8ICA0ICstLQ0KPiAgIGluY2x1ZGUvbGludXgvc3dpb3RsYi5oICAgICAg
ICAgICAgICAgIHwgMTUgKysrKysrLS0tLS0NCj4gICBpbmNsdWRlL3RyYWNlL2V2ZW50cy9zd2lv
dGxiLmggICAgICAgICB8IDI5ICsrKysrKysrLS0tLS0tLS0tLS0tLQ0KPiAgIGtlcm5lbC9kbWEv
c3dpb3RsYi5jICAgICAgICAgICAgICAgICAgIHwgMzUgKysrKysrKysrKysrKystLS0tLS0tLS0t
LS0NCj4gICAxOCBmaWxlcyBjaGFuZ2VkLCA1NiBpbnNlcnRpb25zKCspLCA5MyBkZWxldGlvbnMo
LSkNCj4g


From xen-devel-bounces@lists.xenproject.org Sun Feb 27 19:26:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 27 Feb 2022 19:26:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280059.477880 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOPB3-0003dD-LI; Sun, 27 Feb 2022 19:25:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280059.477880; Sun, 27 Feb 2022 19:25:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOPB3-0003d6-Fz; Sun, 27 Feb 2022 19:25:53 +0000
Received: by outflank-mailman (input) for mailman id 280059;
 Sun, 27 Feb 2022 19:25:51 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nOPB1-0003d0-OO
 for xen-devel@lists.xenproject.org; Sun, 27 Feb 2022 19:25:51 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nOPB0-0008Qi-PF; Sun, 27 Feb 2022 19:25:50 +0000
Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nOPB0-0008Ce-J9; Sun, 27 Feb 2022 19:25:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=AEFCaeESzi1bLlReDDCWKKVEJvgcbOfE8sMNWaqZy50=; b=qnToenPE/Hke4O/oMnEfJZGL9d
	2DtM1qjQ8b2nbPaR8doGH970tFf3s62SwMH+q//s8Bw48v17dd1h4uo4O4f5+B3v/yMt/7oZybq2u
	fK7w3tZGC+El6F30YtTd1J2eVWFBk29bkj/pvCwcqfDJwaNFDTnVmI9TSha6mGkbBf3U=;
Message-ID: <c591a430-1cf8-bb27-a151-ba4125c4cec9@xen.org>
Date: Sun, 27 Feb 2022 19:25:47 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.1
Subject: Re: [PATCH v3 00/19] xen/arm: mm: Remove open-coding mappings
To: xen-devel@lists.xenproject.org
Cc: Julien Grall <jgrall@amazon.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <20220221102218.33785-1-julien@xen.org>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220221102218.33785-1-julien@xen.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 21/02/2022 10:21, Julien Grall wrote:
> From: Julien Grall <jgrall@amazon.com>
> 
> Hi all,
> 
> This series was originally sent as "xen/arm: mm: Add limited support
> for superpages" [1] and finally has grown enough to remove most of
> the open-coding mappings in the boot code.
> 
> This will help to:
>      1) Get better compliance with the Arm memory model
>      2) Pave the way to support other page size (64KB, 16KB)
> 
> The previous version was spent a few months ago. So I have decided
> to remove all the acked-by/reviewed-by tags.
> 
> Cheers,
> 
> [1] <20201119190751.22345-1-julien@xen.org>
> [2] <PA4PR08MB6253F49C13ED56811BA5B64E92479@PA4PR08MB6253.eurprd08.prod.outlook.com>
> 
> Julien Grall (18):
>    xen/arm: lpae: Rename LPAE_ENTRIES_MASK_GS to LPAE_ENTRY_MASK_GS
>    xen/arm: lpae: Use the generic helpers to defined the Xen PT helpers
>    xen/arm: p2m: Replace level_{orders, masks} arrays with
>      XEN_PT_LEVEL_{ORDER, MASK}

The first 3 patches are fully reviewed. So I have committed them. The 
rest of the patches need review.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Sun Feb 27 23:02:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 27 Feb 2022 23:02:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280072.477902 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOSYO-0007RI-NI; Sun, 27 Feb 2022 23:02:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280072.477902; Sun, 27 Feb 2022 23:02:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOSYO-0007RB-KN; Sun, 27 Feb 2022 23:02:12 +0000
Received: by outflank-mailman (input) for mailman id 280072;
 Sun, 27 Feb 2022 23:02:11 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nOSYN-0007R1-9A; Sun, 27 Feb 2022 23:02:11 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nOSYN-0003g2-89; Sun, 27 Feb 2022 23:02:11 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nOSYM-0001mk-PM; Sun, 27 Feb 2022 23:02:10 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nOSYM-0001Tg-Ow; Sun, 27 Feb 2022 23:02:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=eisiMXfrFzpeKj7OIu4SSbXuRMWOh7tB0ijc/lz5JGQ=; b=qk6u7IM/ZKyuevFOZ0MT9Vs/QI
	lD6uHaZ78hM76l4qcUn9NL3GcE9T+7MvYeipJfPBsvIngWRXccbl1mjrrL/eEHdPeMZO/l5jJt8lB
	cU86SsMU4Db+fK3+gmQq1tqOQY3qXZdC0+J8QOvAsKu2R+JjCkAUhwn0SGELjXvdc7p8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168246-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 168246: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=4388144c44c4dd9e9b7df97938ef08ffa85eec07
X-Osstest-Versions-That:
    xen=10f1f7b010a22d6d4ee67b018412d5f7ea386fc6
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 27 Feb 2022 23:02:10 +0000

flight 168246 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168246/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  4388144c44c4dd9e9b7df97938ef08ffa85eec07
baseline version:
 xen                  10f1f7b010a22d6d4ee67b018412d5f7ea386fc6

Last test of basis   168233  2022-02-25 18:01:50 Z    2 days
Testing same since   168246  2022-02-27 20:00:25 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Julien Grall <jgrall@amazon.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   10f1f7b010..4388144c44  4388144c44c4dd9e9b7df97938ef08ffa85eec07 -> smoke


From xen-devel-bounces@lists.xenproject.org Mon Feb 28 02:54:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 02:54:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280092.477914 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOWAV-0006OJ-Np; Mon, 28 Feb 2022 02:53:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280092.477914; Mon, 28 Feb 2022 02:53:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOWAV-0006OB-IS; Mon, 28 Feb 2022 02:53:47 +0000
Received: by outflank-mailman (input) for mailman id 280092;
 Mon, 28 Feb 2022 02:53:46 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=l6xm=TL=microsoft.com=mikelley@srs-se1.protection.inumbo.net>)
 id 1nOWAU-0006O4-9c
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 02:53:46 +0000
Received: from NAM04-DM6-obe.outbound.protection.outlook.com
 (mail-dm6nam08on20728.outbound.protection.outlook.com
 [2a01:111:f400:7e8b::728])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a35f2f3f-9841-11ec-8539-5f4723681683;
 Mon, 28 Feb 2022 03:53:43 +0100 (CET)
Received: from MN0PR21MB3098.namprd21.prod.outlook.com (2603:10b6:208:376::14)
 by CY4PR21MB0135.namprd21.prod.outlook.com (2603:10b6:903:b2::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5061.1; Mon, 28 Feb
 2022 02:53:39 +0000
Received: from MN0PR21MB3098.namprd21.prod.outlook.com
 ([fe80::69f8:51be:b573:e70c]) by MN0PR21MB3098.namprd21.prod.outlook.com
 ([fe80::69f8:51be:b573:e70c%5]) with mapi id 15.20.5038.006; Mon, 28 Feb 2022
 02:53:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a35f2f3f-9841-11ec-8539-5f4723681683
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Uxr/H+0VHYjtixcCNiJhNVsAkUTVHABVRiEjtjIlwufEjFxZ8Eh0ltsXlBE8Oqw2JxNZUNmgPXtOdjO502CC4IgYnJ6SLY0VEtialT9getwLzbPg7hcoWvgrwJhUaWT773wjlSGb+QSfqweOI31hR8H6HEtWz0lGqpetZF5GBQM4BF4mHGLHS7GuL9tSm7sFgNC76chJcMQHb3wPonQQw8lQ5ArllHB3jOY6CvmQl+Rj2QDQV3RS4xSarhc5s5BxT83HiHD+sFG6cnxcvfjfDzJEoZqUB5u8XKXfxs1zbDa9pe1ElQSZzHySpGgyZyZrLSNNBlNkpY0Ih7Q+hRb5ww==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=cUQzgDhFXj39UwjsoncgNcIWa1l4ZcVYsMn1FkSIhVs=;
 b=KuABfYBu8dRbhpq/Ms8IkUlKlVTgZlgCCxlFYN0GSr+Cuo8MOH0L/PqrVUXDP07RxO1lgq9DbGDcho3sjJs5/1vu2/nfoU5fxB3j3WuePzpwfjtSJ4R2TYxoJ+GJvoVd6Qn3ognoByz/TtOoAsDllrz3LL1E/mhXUu11kUMghzkIxCmHhkFMGhr+fkqlS7nSKawXUhTTzulsdZIvshYviBGj72mhvdldLlbVkITesqF+zDsA17Tk/GLl48cx/pUrwzyiidxv9XKlJGmpTjphHdSPPR+r4c7VPEjdXw+gtIgZC3drdIIGE3WfMFTQhvvONb+YpgxyYXiFNiXsHqc40w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=microsoft.com; dmarc=pass action=none
 header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=cUQzgDhFXj39UwjsoncgNcIWa1l4ZcVYsMn1FkSIhVs=;
 b=WH4Au/u10QL2YXuccVwaVhYaL5TtX3pVeqdOhHKxnSrj11hBx5hD5Z+hK2LCyxc94YTU8yKBlXeH87ObgvZbNzbv9bQ2oUBpO6aHaOYHTrjtnORXb5vGmcWzyQNSVOVz6cd7enMYQQ9UnoE0TL8Z0MzrfUUXR5jdMltX4O+2eIs=
From: "Michael Kelley (LINUX)" <mikelley@microsoft.com>
To: Christoph Hellwig <hch@lst.de>, "iommu@lists.linux-foundation.org"
	<iommu@lists.linux-foundation.org>
CC: "x86@kernel.org" <x86@kernel.org>, Anshuman Khandual
	<anshuman.khandual@arm.com>, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>, Boris Ostrovsky
	<boris.ostrovsky@oracle.com>, Juergen Gross <jgross@suse.com>, Joerg Roedel
	<joro@8bytes.org>, David Woodhouse <dwmw2@infradead.org>, Lu Baolu
	<baolu.lu@linux.intel.com>, Robin Murphy <robin.murphy@arm.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "linux-ia64@vger.kernel.org"
	<linux-ia64@vger.kernel.org>, "linux-mips@vger.kernel.org"
	<linux-mips@vger.kernel.org>, "linuxppc-dev@lists.ozlabs.org"
	<linuxppc-dev@lists.ozlabs.org>, "linux-riscv@lists.infradead.org"
	<linux-riscv@lists.infradead.org>, "linux-s390@vger.kernel.org"
	<linux-s390@vger.kernel.org>, "linux-hyperv@vger.kernel.org"
	<linux-hyperv@vger.kernel.org>, "tboot-devel@lists.sourceforge.net"
	<tboot-devel@lists.sourceforge.net>, "linux-pci@vger.kernel.org"
	<linux-pci@vger.kernel.org>
Subject: RE: [PATCH 08/11] swiotlb: make the swiotlb_init interface more
 useful
Thread-Topic: [PATCH 08/11] swiotlb: make the swiotlb_init interface more
 useful
Thread-Index: AQHYK+bNn5GdGBwbMEGdpROKeAVKTayoQv4A
Date: Mon, 28 Feb 2022 02:53:39 +0000
Message-ID:
 <MN0PR21MB309816A344171B46735CA29CD7019@MN0PR21MB3098.namprd21.prod.outlook.com>
References: <20220227143055.335596-1-hch@lst.de>
 <20220227143055.335596-9-hch@lst.de>
In-Reply-To: <20220227143055.335596-9-hch@lst.de>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
msip_labels:
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=54503504-d8f3-4c3e-a3cf-4bee18dc2a5e;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2022-02-28T02:46:33Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=microsoft.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: ad617b86-9c9b-4e42-4228-08d9fa658626
x-ms-traffictypediagnostic: CY4PR21MB0135:EE_
x-ms-exchange-atpmessageproperties: SA|SL
x-microsoft-antispam-prvs:
 <CY4PR21MB013561022727D491FE6CAF60D7019@CY4PR21MB0135.namprd21.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 jgY3to4oAxE+ZbyD313tm4v2LKB9wgdM/t4YKDWaNfCvbK0n+Fd3cojE1ClcO7QxvKMwF/uoufBShgtPGVTookIDiit+Fcjs/CtlqwsgEvEo4fQFnoFV3/1YS4VjkI5iooYW8QfBgPveg5sC6UkAgzma431tSutH7J7B68uasxC8IpKZDwgpaQX5tVtWURwLUEPdekPQr2Fy66CSy9uEX9PAbtyjH6gGRva4egr9bx+NLYcWuCOCML22RZDZxzp9K9zQ5/UkDPoltk/0sCiffwK8ZP6OlEXCZMpQfV4gN3xyZdTYp7QVBAi5MInJQJJ4sWsbbFwN2AE37HW3rspqojnINkB+YueoibYA3ftD2U53G3Slgid5Vp1pvUVdMjw8k5X2l0o4c8rvodEaqvG+1++Y6uMeDz80bhyq7YCQo60CGpic2JFXgSbbbfF1wat5FEGC65HXY9jGw4LDInsbJrVRIeKr9xXzDKrRCSMIf47Edu2KZWsiA0fbm11PsYTnx/zD1/aAF+151CIdXz5fN1MPp/jSDB5Id1ZPTFBmPhW1M1Yxo0hdW+9XTVVdv4QpjhCvSoQPUM9tSqm7o2EGSH6n5v4etwyhoHDEKV/qQb8EGMxnEi9CbZN05fN6wbR+A/LZSc0yJyquLD6rRcF4HI0XSOhLpot/uQWELl5MN11aEYRY3dUJA0iy/vi/JUuxc/UqJHsHKADReFFdoo+Pd0kYiIVT/vPx7ozfSALqTv4Y2v7AzQ3PVH0naZ4RIbMH
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN0PR21MB3098.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(55016003)(316002)(7416002)(83380400001)(8936002)(76116006)(86362001)(122000001)(52536014)(4326008)(8676002)(38100700002)(33656002)(110136005)(66946007)(66476007)(66556008)(66446008)(64756008)(26005)(82960400001)(82950400001)(5660300002)(54906003)(186003)(8990500004)(6506007)(38070700005)(71200400001)(2906002)(9686003)(10290500003)(7696005)(508600001);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?bI3bCFBx6zsQOCHdRhVezvuntStzw2ubtckeFpHc6FRUctIevqiE7viqUUMk?=
 =?us-ascii?Q?XLAwGeVVeDMurGjR/Q+JYa67qMrcn7lnZVlho37bdx+OfmZoH6P4QRY3Uv6N?=
 =?us-ascii?Q?oC39s+hMI1aLvlgJRY5ac9p/kuzRmv5pARGW9VNE//6XeIuxjvpn0E1/GYlB?=
 =?us-ascii?Q?5baH/JwBHhbePMb5NrWTEp7Chv8J923oKbwVB5OPEAgm6Y26DilPQgidrXpS?=
 =?us-ascii?Q?Tp1WKWF0V3ZU/nwKfDl1TxK2wPxpBQ4TPs1M7VR+Mluv5E9p47N3LpCchXBQ?=
 =?us-ascii?Q?/kzdxwpGnjv21Wkdu8UBqkpH9QCEpokR3gEdzxYz4Lne//7IAZmHJNKBc0Wx?=
 =?us-ascii?Q?DrLES/rDF9pEuCqBAqvthSOhAYo8TmhIlmn4LzsEpAn2ooLfby2eN1AKFOji?=
 =?us-ascii?Q?4K9g0Jj7cghNPgPaSTXRo0i/hONGui2O8/w4Eoka0wSFuHuPoTRdh1hUOWoG?=
 =?us-ascii?Q?qc/rixUlG+ImhiFuwkAu8dtndrkox1HzC0uCB6MzwH9W4Lurb4C+WccM76Ea?=
 =?us-ascii?Q?MxBacIus5w6Zm3F0D9ThiZ936iL+6L5L0hcuIwL8MdcYvQgY+JLVcXjH8Gv2?=
 =?us-ascii?Q?Fme1GRcqgEyucZyj3wA9MDEpPMJUnXRoWC7lt+20EP6B6phcSHGEPcE0mLZV?=
 =?us-ascii?Q?if/QiOUNvHsh8vSRixEZUrVYl49ilI2c25b38VhZm+YNLfWhhwQncZDqhK9y?=
 =?us-ascii?Q?JrDj3APCrAMpwESWdu42hnAxYw/X94rtNXCR8pokyc0Ds/KmDb0wSnS7hP0Z?=
 =?us-ascii?Q?h8vspIlXxjMwVlWXJd9hHLjYFw5MFLuE/JFVqV/6AnSzLU87pFaeKvoIWu+P?=
 =?us-ascii?Q?On6/qewv3P5ZehLY1lb+GuW8IU9MeLjAO+m5JSDvi+rIoOCL/wJMG6vT0K2+?=
 =?us-ascii?Q?U4iLRx0tEgym7IdSDKMj6vZajYd5aYBrF99ikT5pC0aOIyTMIkf/CN2MJP98?=
 =?us-ascii?Q?PCE3vEkdsi+HN1akosWx6vQEDbzWW6gN4DBu0MZsmpymyQrz8CImXdIJ5lwC?=
 =?us-ascii?Q?JR0xBIXPGb1/IqsYZVVr0fQgCcrwlYqMMuf0wr8hJ0eHjwot++uNuCnZrYV/?=
 =?us-ascii?Q?TMREqnmp436YIFK/j3m4WsI3PmwtIYYkQGgsJ+QKjSgGVyy9+YXcaStaOLAs?=
 =?us-ascii?Q?7/S+J4H5UK3YDA+qm+DQUBZU/aYzGc+xKm/k0NP8Uc8OS7fYw7+EzvxHoXsQ?=
 =?us-ascii?Q?2CGWTIy7L19LFU01lANImKIxPVvgkd2ydXpJGU0AAVFSTA2KiyrVvuJogK9s?=
 =?us-ascii?Q?4px/EQJ+fTByINM4KtL7WrD27DdUfxzh4YWpkn5tQEVtBIZ6nISzva4fL1Za?=
 =?us-ascii?Q?WSF5t2PChgd8tFGSv3ov5hr971K7PMrLu5SL2LCrE2U5e/lpBM7TCzkVtrfT?=
 =?us-ascii?Q?YkPp7KphcWAzEL7INpnql/Awh4O1m92TDMNyXIuE02TDoObTdIXvVgkXITno?=
 =?us-ascii?Q?65STsxtjRIAoPjVKKuyymTczT0L5OWO2F/X3HMuBMIwD2Fuv8S8qnw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: microsoft.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MN0PR21MB3098.namprd21.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ad617b86-9c9b-4e42-4228-08d9fa658626
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Feb 2022 02:53:39.7488
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: q9m4+4xhejZm5i6EYSB7ZZnkSKhosXtmzoGei3eyArUh57G0m5VTfc7xylx9wwvd4b9gPdNNpH4yjn7LuEGVnmYpGWDjM4GJQEejazXlEMc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR21MB0135

From: Christoph Hellwig <hch@lst.de> Sent: Sunday, February 27, 2022 6:31 A=
M
>=20
> Pass a bool to pass if swiotlb needs to be enabled based on the
> addressing needs and replace the verbose argument with a set of
> flags, including one to force enable bounce buffering.
>=20
> Note that this patch removes the possibility to force xen-swiotlb
> use using swiotlb=3Dforce on the command line on x86 (arm and arm64
> never supported that), but this interface will be restored shortly.
>=20
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  arch/arm/mm/init.c                     |  6 +----
>  arch/arm64/mm/init.c                   |  6 +----
>  arch/ia64/mm/init.c                    |  4 +--
>  arch/mips/cavium-octeon/dma-octeon.c   |  2 +-
>  arch/mips/loongson64/dma.c             |  2 +-
>  arch/mips/sibyte/common/dma.c          |  2 +-
>  arch/powerpc/include/asm/swiotlb.h     |  1 +
>  arch/powerpc/mm/mem.c                  |  3 ++-
>  arch/powerpc/platforms/pseries/setup.c |  3 ---
>  arch/riscv/mm/init.c                   |  8 +-----
>  arch/s390/mm/init.c                    |  3 +--
>  arch/x86/kernel/cpu/mshyperv.c         |  8 ------
>  arch/x86/kernel/pci-dma.c              | 15 ++++++-----
>  arch/x86/mm/mem_encrypt_amd.c          |  3 ---
>  drivers/xen/swiotlb-xen.c              |  4 +--
>  include/linux/swiotlb.h                | 15 ++++++-----
>  include/trace/events/swiotlb.h         | 29 ++++++++-------------
>  kernel/dma/swiotlb.c                   | 35 ++++++++++++++------------
>  18 files changed, 56 insertions(+), 93 deletions(-)

[snip]

>=20
> diff --git a/arch/x86/kernel/cpu/mshyperv.c b/arch/x86/kernel/cpu/mshyper=
v.c
> index 5a99f993e6392..568274917f1cd 100644
> --- a/arch/x86/kernel/cpu/mshyperv.c
> +++ b/arch/x86/kernel/cpu/mshyperv.c
> @@ -336,14 +336,6 @@ static void __init ms_hyperv_init_platform(void)
>  			swiotlb_unencrypted_base =3D ms_hyperv.shared_gpa_boundary;
>  #endif
>  		}
> -
> -#ifdef CONFIG_SWIOTLB
> -		/*
> -		 * Enable swiotlb force mode in Isolation VM to
> -		 * use swiotlb bounce buffer for dma transaction.
> -		 */
> -		swiotlb_force =3D SWIOTLB_FORCE;
> -#endif

With this code removed, it's not clear to me what forces the use of the
swiotlb in a Hyper-V isolated VM.  The code in pci_swiotlb_detect_4g() does=
n't
catch this case because cc_platform_has(CC_ATTR_HOST_MEM_ENCRYPT)
returns "false" in a Hyper-V guest.  In the Hyper-V guest, it's only
cc_platform_has(CC_ATTR_GUEST_MEM_ENCRYPT) that returns "true".  I'm
looking more closely at the meaning of the CC_ATTR_* values, and it may
be that Hyper-V should also return "true" for CC_ATTR_MEM_ENCRYPT,
but I don't think CC_ATTR_HOST_MEM_ENCRYPT should return "true".

Michael





From xen-devel-bounces@lists.xenproject.org Mon Feb 28 03:15:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 03:15:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280101.477924 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOWVO-0000uZ-Jl; Mon, 28 Feb 2022 03:15:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280101.477924; Mon, 28 Feb 2022 03:15:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOWVO-0000uS-GN; Mon, 28 Feb 2022 03:15:22 +0000
Received: by outflank-mailman (input) for mailman id 280101;
 Mon, 28 Feb 2022 03:15:20 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=0PrO=TL=vivo.com=wangqing@srs-se1.protection.inumbo.net>)
 id 1nOWVM-0000uM-OI
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 03:15:20 +0000
Received: from APC01-HK2-obe.outbound.protection.outlook.com
 (mail-hk2apc01on0706.outbound.protection.outlook.com
 [2a01:111:f400:febc::706])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a64ff3ac-9844-11ec-8eba-a37418f5ba1a;
 Mon, 28 Feb 2022 04:15:17 +0100 (CET)
Received: from SL2PR06MB3082.apcprd06.prod.outlook.com (2603:1096:100:37::17)
 by PS2PR06MB2454.apcprd06.prod.outlook.com (2603:1096:300:45::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.23; Mon, 28 Feb
 2022 03:15:13 +0000
Received: from SL2PR06MB3082.apcprd06.prod.outlook.com
 ([fe80::49ef:baa:8c3b:cb3d]) by SL2PR06MB3082.apcprd06.prod.outlook.com
 ([fe80::49ef:baa:8c3b:cb3d%5]) with mapi id 15.20.5017.026; Mon, 28 Feb 2022
 03:15:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a64ff3ac-9844-11ec-8eba-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=n1fEWfHCHkAUJpDNFUgKGKSfUYPuyoiT3QrP6ueVail+mA/KRZ/XunmYzqsvAIT+Dph4Bg3gMteyIOXc6tNCnQJCqnjByWvZx237XKYxYmPvvXMNaon4nx25k5zZvpNWPJA6nlILXvnZssSjVbiImVY67a3HHRYVLMZPmrdbDjoYBR0JVFag9jXjJPf1jjvib2T+/osRn1I5W04skS2HXf7jrFCnJHkW7Olksrnoc1iEUIyZjpVySFKi2CWKj0aB4uGlTk6IGI0tFS/Qg9Uy81lap62nUqKErWSpS0l5+BSDmWez45Pd1zvtuogW8KdgXxQ5UDOiYwLlvyeCNAXyQQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=v8krF1cSsCFYuWdZnXErYBDMuwe0kPjprcu+E4vYgxk=;
 b=T8swgeEfOCQlPLxu+xYDfSqF0DkXbdkyCk8jKWsNT8aJi7kB08PAnULHxO0nkL74SZ+WhVQ4s6YNa6ll3ogfZSmVZtyUd97HYgiR6TnpupirkYrjAWykas0LXaY+Dr4+F1V2i2dDWNiwvlt5iDayPpEOaUf366TmmFLp+af1/L48JypErtl2Uov/6Qdq/cXyI+vATU/COav7CHY7TpJAOsQuNp7LLgyVr0SWhwxiT7KAB9ZGaFeae4ebVcufje0kRh+ygPSIcWvr83OYJIOBogY8ReJXBa/NXhUxE94Uuko5XFfVyeWilW9K5KMi9/67uDDp4+5mYQIVCTrgvI8i2A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com;
 dkim=pass header.d=vivo.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo0.onmicrosoft.com;
 s=selector2-vivo0-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=v8krF1cSsCFYuWdZnXErYBDMuwe0kPjprcu+E4vYgxk=;
 b=V1Zs5e1pwDes0wr0ttkRBMU8aXsPE/RunOP6TY13hzdlOWKJ/qDbDfxKTP1kQzA4oxTzM2dc1zhC1Vku6AWeHaR8sgaWT/KsbvluB5gJ8JfOtNFGKX2tZy7dE4SXb3AZinIvsvmDraI2FkNbu+bpizYNHpkU4tAlHHUVxYIwT7A=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=vivo.com;
From: Qing Wang <wangqing@vivo.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org
Cc: Wang Qing <wangqing@vivo.com>
Subject: [PATCH] xen: use time_is_before_eq_jiffies() instead of open coding it
Date: Sun, 27 Feb 2022 19:15:03 -0800
Message-Id: <1646018104-61415-1-git-send-email-wangqing@vivo.com>
X-Mailer: git-send-email 2.7.4
Content-Type: text/plain
X-ClientProxiedBy: HK2PR03CA0055.apcprd03.prod.outlook.com
 (2603:1096:202:17::25) To SL2PR06MB3082.apcprd06.prod.outlook.com
 (2603:1096:100:37::17)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: fd0805ba-2ddb-41bd-1bae-08d9fa688916
X-MS-TrafficTypeDiagnostic: PS2PR06MB2454:EE_
X-Microsoft-Antispam-PRVS:
	<PS2PR06MB24548CFAAAD967E65022F11BBD019@PS2PR06MB2454.apcprd06.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	GRGi/Xd/OUNXhHrQXT/dGia6UKXpRsPlLnTi51rXEqsjh/Yssv0QAJX7N/JmANQuOxMq0lFNA2b0+Nk0GPTrXIuJDNSkF43Gl2I9LasKSGkj7ajt0Vq07Spjw5hqZ4B8Wko/f7b/ovvMQvxOSoEP0ivBHmdr+4G2TBGY0sHiJC2OSL6QRG681SeQqnmu1XMKWPxKj40jOGkzWez0oMZ4VP2x2YDT4B74VduIZO8ugjTpJrykF5qBikyBcvzKwhmUBLH/Xb0HjrMdI1c+H/t74UjC50FUNBnFclmj1di8HabPtFalpjjvjIXMwGFVjxFN2BqfhZeTKP7YqRfGbjuCoe7XaEYGl9rJjtkM2QydBXdiyJU5SNHDNJ5Zx5uBBqWJ2q5laT0Z756EExfO4NkU+GUBcIpMnpV4zUdfzWVN++BxnklHrtjwi926VbgA4q97qX/0b+ZGoOKpubdbZxCj+glmSV9AewNW72e/MOn8uKU21v34LNj0vcq8igK1O/dSIK83v2MAlUDURuITW7YVReNOMCNWbZrRZzpW0tOORpy7DLV2fLi+jvMLIV3wjuSUBNOt41COaHWzDM1m5AJ/Qa953bW8IvDef58Nm1o5t0N5YcyWOiyYDPlQ1xolT/v0h0Q/XRzNecRaLGfZXwmxhVq8akySRv6nldaVNaC4y9gApVq0b8E155ysqWQrIz1FxvmbkHl1ZWs2kaGZ5s8saw==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SL2PR06MB3082.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(5660300002)(66556008)(66476007)(66946007)(316002)(4744005)(4326008)(2906002)(86362001)(38100700002)(38350700002)(8936002)(52116002)(6506007)(6512007)(8676002)(186003)(26005)(107886003)(2616005)(83380400001)(6666004)(110136005)(6486002)(508600001)(36756003);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?gtZr1btOGnkEeac1kPh1nFGZkRZXhA8zlCuSivctJ5oMEJPzCRy+ZQLi+Al5?=
 =?us-ascii?Q?+eahW1+aUv+ok6JyoGHfQOJqsHtYAlJGHrGMePe1cY380lUjAMe0ps7kZV0T?=
 =?us-ascii?Q?u5j4Xf27jhh6jP1096dGd8Xa3PSgd0wKC+ilnqLU9eRwHVNEqZB8W+brrfPk?=
 =?us-ascii?Q?69ECmiEaw7wJp4pEegcabj+AHTQ+SDaZLE6vhOLUX2S8BqqNbVgmwx5ThS63?=
 =?us-ascii?Q?tmGNwbRza26U/Iisg+FwZl96OfjqnqXkdErkBGIU7nlHogP41sVrNAoJAU/g?=
 =?us-ascii?Q?6spy5Jawh3MQrrU4gN3hdcIR7AsqAKMpKVovbFaWdISQ8Aj/zeVOw8zF/zQR?=
 =?us-ascii?Q?wtdC+86j+j6rm86XNcwt3/+giEZLE/iTqNwDRE81I3+wjmmDPvpTNrDb4Upm?=
 =?us-ascii?Q?u4UgFqx2uWtXKlfDGRfRJFgxUGdziGH2YwH/UtqaH12q5ZPogNWu42oi2uom?=
 =?us-ascii?Q?2/4sF1hOQDozoa6z2vHG6Toviznw7Ek/tKW2k76P9EYoEYJ28j17oIgtnwIY?=
 =?us-ascii?Q?FRCW6F1GmRj7WlYTqt4ADP2xyk4liTRCpBTRG2g8b5bo9BoZ8kQ1Y+QooYcy?=
 =?us-ascii?Q?DvpMRhfFMN/633JPNxN9BXHbrYYsT3SzbAY57JLFmZwcv/ua2uWVhidtnqkW?=
 =?us-ascii?Q?7lWqcq61H0JiI2Kg+5OjCstcM+e/+HkTzJ/lnIL5CCfBGWvTtw/XcfWuICmq?=
 =?us-ascii?Q?7fp7RKOC1nk2MzTGQ6v/CpxvYTtxe8aOYCFL8iMP6IiGqnwfeJZt9E401MBn?=
 =?us-ascii?Q?q97Ey8GmmVmChRDjZvoX0W5Ft3UGzOZ7IatPpkNZKFVDEyniBZTOiDxlXwiU?=
 =?us-ascii?Q?Je1rZ9WlOAm3CFu+lJD+D3m51yE1vjx0YBlc7uMdhXRxOs50nhh9sjWUx+Gi?=
 =?us-ascii?Q?X8pPj+byuvJhc70SAYbaFd8F5dL06t90qfRf4kfCB5F5Y12LSvLylLGB3n5f?=
 =?us-ascii?Q?sJsTkj42au+IEbZ45C6nRJDCaedsH+IqZvEuHp3NSw1tLp592FT+UFDD7UNM?=
 =?us-ascii?Q?aRLjuKj+/W3Jb/OCWeaeRbTsq/s5gSbfht5AtMbDWb+tuQAmBVKx+Uj4hHsl?=
 =?us-ascii?Q?9m3uZPpQ9GyQH+7cWI+1+Ry+GIYU5yzwTwnYwvIpSHK+XMBb7LYnpGJhewAV?=
 =?us-ascii?Q?Q7AS7JBxJjP7QdFXiPrYeads0ulam8WEsLnv1djWX4s+LPISYCES3mcoHJ68?=
 =?us-ascii?Q?obSjOd/uhOk1GdzbWPxm7bwmNnVk4V9lSYCYNfeEfypQk/y6iYO0oLqpkEvi?=
 =?us-ascii?Q?3Ng4a+Z9/x6aiK5u9xL7GJq1OF+nBDYNcH+jmtItQwPDl0xYLB+a/wYEQwMK?=
 =?us-ascii?Q?KpmuDsktSZNsljR22J0kO62kkB0+hVCJNzX5uK3eLg9H4783sqQYUG5n4TRU?=
 =?us-ascii?Q?MvZpWU4j0pYF73tZZIoRi5nwOf5Tfxmouq7DpCO7mM1HnZRzCcFagugXi1Xi?=
 =?us-ascii?Q?86el0bYO1vlO1SBx/IiSGouk0hwk1sTZlnXPbfXKw64+LxKJ3zoWcX721YnT?=
 =?us-ascii?Q?RggeI4rFvitwUzzFNZJWShO1lnFH9SWlZdbI4lHXSxZs+jeagK554Wp8D8lL?=
 =?us-ascii?Q?X+qZnfXJJMNMpmav4MqyZ7U2KoCU25+fm+Q6kzfZjJMNZ9lHK2R2EHWu0Joj?=
 =?us-ascii?Q?H5vWHnpX11Tfp6+WkiKjJ1I=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fd0805ba-2ddb-41bd-1bae-08d9fa688916
X-MS-Exchange-CrossTenant-AuthSource: SL2PR06MB3082.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2022 03:15:13.6074
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5Yi5/LVrwiDNSXXtQ6WY2QQ3DEiVs6VNs5x16XAbWDkO1ty4kRNz0+koxg9llp7BTdfjWfHXfT9YvG8BrMZKhA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PS2PR06MB2454

From: Wang Qing <wangqing@vivo.com>

Use the helper function time_is_{before,after}_jiffies() to improve
code readability.

Signed-off-by: Wang Qing <wangqing@vivo.com>
---
 drivers/xen/balloon.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/xen/balloon.c b/drivers/xen/balloon.c
index a2c4fc49..dfe26fa
--- a/drivers/xen/balloon.c
+++ b/drivers/xen/balloon.c
@@ -59,6 +59,7 @@
 #include <linux/slab.h>
 #include <linux/sysctl.h>
 #include <linux/moduleparam.h>
+#include <linux/jiffies.h>
 
 #include <asm/page.h>
 #include <asm/tlb.h>
@@ -794,7 +795,7 @@ static int __init balloon_wait_finish(void)
 		if (balloon_state == BP_ECANCELED) {
 			pr_warn_once("Initial ballooning failed, %ld pages need to be freed.\n",
 				     -credit);
-			if (jiffies - last_changed >= HZ * balloon_boot_timeout)
+			if (time_is_before_eq_jiffies(last_changed + HZ * balloon_boot_timeout))
 				panic("Initial ballooning failed!\n");
 		}
 
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Mon Feb 28 03:43:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 03:43:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280109.477936 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOWwH-00047Z-S5; Mon, 28 Feb 2022 03:43:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280109.477936; Mon, 28 Feb 2022 03:43:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOWwH-00047S-P4; Mon, 28 Feb 2022 03:43:09 +0000
Received: by outflank-mailman (input) for mailman id 280109;
 Mon, 28 Feb 2022 03:43:08 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nOWwG-00047I-8l; Mon, 28 Feb 2022 03:43:08 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nOWwG-000319-5g; Mon, 28 Feb 2022 03:43:08 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nOWwF-00074Q-OX; Mon, 28 Feb 2022 03:43:07 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nOWwF-00051Q-Kq; Mon, 28 Feb 2022 03:43:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=HSyIsk7w/qNZG5VbaOFCRbOP7pzUIhTiMApXL5xci4Q=; b=Y3DsxW0KeFWXsDCriexbG2SXW6
	1xoCYyFiddrBlDnG880+ElfWQLhyS/Jzf9vvO//nsC3wIigDTGoM+OK7ISn4fxU9xMRCQIblN+nsl
	vcdIqvmlTaQQ7giQ9G9AzxiR6ohb75P1HIeDpdsWEJurpla7JakknsCYoYGGlMHLfPIU=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168247-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 168247: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=52a02554673122486ecb36c36387d91cf9544986
X-Osstest-Versions-That:
    linux=2293be58d6a18cab800e25e42081bacb75c05752
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 28 Feb 2022 03:43:07 +0000

flight 168247 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168247/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168240
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168240
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168240
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168240
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168240
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168240
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168240
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168240
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                52a02554673122486ecb36c36387d91cf9544986
baseline version:
 linux                2293be58d6a18cab800e25e42081bacb75c05752

Last test of basis   168240  2022-02-27 01:11:48 Z    1 days
Testing same since   168247  2022-02-27 21:39:42 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  "Surendrakumar Upadhyay, TejaskumarX" <tejaskumarx.surendrakumar.upadhyay@intel.com>
  Andy Shevchenko <andriy.shevchenko@linux.intel.com>
  Christoph Hellwig <hch@lst.de>
  Dan Carpenter <dan.carpenter@oracle.com>
  Halil Pasic <pasic@linux.ibm.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Linus Walleij <linus.walleij@linaro.org>
  Marc Zyngier <maz@kernel.org>
  Sean Anderson <seanga2@gmail.com>
  Thomas Gleixner <tglx@linutronix.de>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   2293be58d6a1..52a025546731  52a02554673122486ecb36c36387d91cf9544986 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Mon Feb 28 05:12:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 05:12:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280084.477946 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOYKc-0004uP-C7; Mon, 28 Feb 2022 05:12:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280084.477946; Mon, 28 Feb 2022 05:12:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOYKc-0004uI-98; Mon, 28 Feb 2022 05:12:22 +0000
Received: by outflank-mailman (input) for mailman id 280084;
 Mon, 28 Feb 2022 00:27:18 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=tLaL=TL=oss.nxp.com=peng.fan@srs-se1.protection.inumbo.net>)
 id 1nOTsk-0007Sm-A7
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 00:27:18 +0000
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01on0603.outbound.protection.outlook.com
 [2a01:111:f400:fe02::603])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2dd3808d-982d-11ec-8eba-a37418f5ba1a;
 Mon, 28 Feb 2022 01:27:15 +0100 (CET)
Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11)
 by DB8PR04MB6460.eurprd04.prod.outlook.com (2603:10a6:10:10f::27)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.25; Mon, 28 Feb
 2022 00:27:13 +0000
Received: from DU0PR04MB9417.eurprd04.prod.outlook.com
 ([fe80::552c:ed46:26dc:77cc]) by DU0PR04MB9417.eurprd04.prod.outlook.com
 ([fe80::552c:ed46:26dc:77cc%4]) with mapi id 15.20.4995.018; Mon, 28 Feb 2022
 00:27:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2dd3808d-982d-11ec-8eba-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Rz/UXzUP9JI27VcULwbSjESjLDJvZTQczKIpoSCRlHnxnCranwPPl+oJZHEoPkxdHj99ML0tMYianySIIGKIedp/zpAgrhdFTMsFJh8CygNuUAZG03GOTsUvD/ctOWuwnNvsbRGtYeXNdWKXETnLxjbmVJEw7yHFMr7mFlmmfoYWcxZMKuG7MTqBTSK+d2LV7KAa9tMhWt10hqz5Iz2dAbtkHIGfAo/csxANhKEeKBdu3+h8WhcN+hjUXmseZolt/fTl1sH8sHWfmgR7pghr0YLpWz240B+oYWgCN+yZzUYrZkF7km+lmu2geSMp2yV7VMON/LJaepqQKOypyY16mA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=GMGefyqmp9TvgUgnXkoWxjjwX+pIBdIaAGpojmKBTAg=;
 b=RE5tMuozE8Gs3UVgQsr8kLWSkwaG5quWjmUTiqeikKFgxrRv79JbqdYaTKmHyHL3T8R/vXzozdGN4l0gkfdRXRkFLvoXNkywGUh7zA9YO5SIagEFBo01oqHzP9PUHFQ9qbCxHF1f5QekNqHceUG9Gr5ccw6SlFACvsP1JlQJgYd1SqjMrbjk1Tc1kIF7fslZB7oWtiu8TvWkGwRb9kKAyJBLgcdjrX7J9VPbEJ7dJaV6pfAMmTrJmYGzAHjrvW6Zg0XdxvyR0Sp827NSGWfEu6XzCvH9rYMtqQ+cU/NNgh6uOKR/7SVMG51aLMnQIaa6ytQAUVI++dtyaV0op5HH1A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com;
 dkim=pass header.d=oss.nxp.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com;
 s=selector2-NXP1-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=GMGefyqmp9TvgUgnXkoWxjjwX+pIBdIaAGpojmKBTAg=;
 b=BBoPabCOzAgIG3YWEmaY4jB5DZJ1G2nldK7GNVulZwgJtp5FiN2hTyoGAbqcx9OVU3LoCr4cMJs483utsLdLEjX6kuprd6iROOvNboEvuLiA6lIHrR7N4yjgzA7LSZnZkBHY4WG8vEVG3b72AlNjWG9XU8/tWmpAkwI4myBqVBY=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=oss.nxp.com;
From: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
To: sstabellini@kernel.org,
	julien@xen.org,
	Volodymyr_Babchuk@epam.com,
	bertrand.marquis@arm.com
Cc: andrew.cooper3@citrix.com,
	george.dunlap@citrix.com,
	jbeulich@suse.com,
	wl@xen.org,
	xen-devel@lists.xenproject.org,
	van.freenix@gmail.com,
	Peng Fan <peng.fan@nxp.com>
Subject: [PATCH 0/3] xen/arm: add i.MX lpuart and i.MX8QM initial support
Date: Mon, 28 Feb 2022 09:07:08 +0800
Message-Id: <20220228010711.11566-1-peng.fan@oss.nxp.com>
X-Mailer: git-send-email 2.30.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-ClientProxiedBy: SI2PR02CA0001.apcprd02.prod.outlook.com
 (2603:1096:4:194::10) To DU0PR04MB9417.eurprd04.prod.outlook.com
 (2603:10a6:10:358::11)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9aedd7f3-f36e-464a-f0da-08d9fa511092
X-MS-TrafficTypeDiagnostic: DB8PR04MB6460:EE_
X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True
X-Microsoft-Antispam-PRVS:
	<DB8PR04MB6460F54B578D074735187AA7C9019@DB8PR04MB6460.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	nr3FxVPNnCmeSsM6+18wjDBRrRN80HZczd8BgN9LhkMvHzRcbU9qmFYz6tXYCTIM+94/t9TPHJZfc0rHH0UvpB/ZxOpstjpPMTpldZAqlTThd7rMZffUanpNGvWWIG2RHL61kZIh8xbUmxmmQiNpt79acoG2eW9bjAVXlQATB2q/Nd4QoLrOTd+xnKGP8WKEHsokP1R6x5H1o2dUlJvrbmK1NnkCLBuudxy0ffLtPg/54d01r7XuCVjvdB15NqwQeomBWJwWtBr+h84u1eS4uIHYu0z8k7Y13IJLHameR3By0fkaFQzWFv69BZhdcUsmWZiDzZ0isieXY/QHQ51PwhSgysmDFpqDEIzUsOAr5vKfScXPksW66fZ6IQjeOZFGisZqQgDgvcI8AwsPY7bnt0plzSLsOsF6vrqNk8821MEdkfwDAxRrvuSyykVYZi4AQ60gIQrCrvmoEI5s660LIe/KT0LMG7aUoi3NNbI0oHgJS4Jg9ODeX58NVG7/sky0ZFZKPfkVj2Fyie8Pg4lxPjJ0egTSVyPkoY/Xsds8VLABYI/7c0ul6idHw5rt0j8mY4b2jkOdR9JD8ymF68vDKxJq+mHQsfBIe0ej6/KKv7n1b63Kna9wr/VdX8U0BZ1UiQw4M62khqGtXi8FQf53y8yxYOjcBw0glBIoDWSfLOCTmoQ2B4mhOFNAICEJxR9oYK2efGk93DxsHRU9vc9EGQ==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66946007)(66556008)(66476007)(6512007)(6506007)(6666004)(316002)(4326008)(8676002)(52116002)(2906002)(2616005)(1076003)(86362001)(26005)(186003)(5660300002)(6486002)(38350700002)(38100700002)(8936002)(7416002)(4744005)(508600001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?p3m/kOx/z3Mp95wxTXq8DGphXecYQwlcOjQHnouZc/5W8pKAN5ZWNUCrEraB?=
 =?us-ascii?Q?0+wj4DWrlXJ41MuSnapZUkna8b1Yz2dYPcZTRkT1HZ5fO3G3QjpOGn2tt4xR?=
 =?us-ascii?Q?28js4jy4pZBBJjUJwzatpuO4spZ/pxPFq/Kpjsi3Sxn4o8LLUaM1zFAVGe4/?=
 =?us-ascii?Q?S/PPUPTvL2JuNNkP9KdcNYUo7KJUqsgeUiPIxUMzYupMHtNO2mNhU+vDiYIf?=
 =?us-ascii?Q?0C5LgdCJ6CgpOCcyVybW3f7bT1ObWsjNeeMOHV4/Id46d2JwUbvsv6SJCLYb?=
 =?us-ascii?Q?Xw9h9ozjENBf73JM39t9qnh+IFH4q8mmHNRnoR1jlX9WUlXiCgzQT8VuV/Gz?=
 =?us-ascii?Q?J7SJveo5tNBsUDvUnPZiHDYBH8mL4zVx/EFLUsoEi/H4gtZAFwUlBxRBI7oo?=
 =?us-ascii?Q?PTFmzrIltuOgSzO7DXXhg5gT54zBoyb50AKij8bYfVNaZP85o0K41ugVtYVg?=
 =?us-ascii?Q?J8sGWyjkLOQo8qo5m/XB9f40JGTaJaKwUQU2ANcN9FJcx6sYfLl82MIFrLkt?=
 =?us-ascii?Q?5/1VyLFdZrMLAc9pkYxZfchSBWqanJgku+d56oA7KMkNNUPYe1wrO5mIKWtf?=
 =?us-ascii?Q?KUwaukJqumUg5GiNL4qELuJVVQjBgrRo6dX0QHveq20I6uwINOO8Vh8D1qzC?=
 =?us-ascii?Q?p6jJY766dvfGkCKMTBr4UTV/mGMk9q6vSHvNrudSUARdRH/9OS+iC8rfJMt8?=
 =?us-ascii?Q?GiNBt3TG5nI2GerCneQfvqn+1q8P6B0ZFKsBK/F+5ymc0rOkCJYSPDXJgInB?=
 =?us-ascii?Q?d5NVV9nVKwjWslvKN43r+xFnxLJ0lmyeeF/CIGTppWJXUFXtsFXABZNUGbUl?=
 =?us-ascii?Q?rwxjmABdD4mDmYgBme/ostY6c5Gul8TUkslEGOZYkXpwlIY9fADXKSHXX76Z?=
 =?us-ascii?Q?ISmr/26ZId9m7EUzE26ahtjMBFoGvrpo0nIY/VpBoZhh9TVQ66IE1LVN4RiD?=
 =?us-ascii?Q?JC+l7kGPvVO9Z+1HA9hZuqMd1HGAEWXHIgUtdRLMqkQRZRM+ijdpYpwtvSn5?=
 =?us-ascii?Q?IQcNcDprYFzO/plGIjeBvvpJbidZ7Bk+njJuPYSZZxYGvT27/ZQ/c9W8NkJI?=
 =?us-ascii?Q?BJTzYxpzpZ7UC31HO+Mp6Emwt3D6uu1ag8ZdVzrkyMFqgobRkbLr5H1A83WU?=
 =?us-ascii?Q?rLVXvC4Z7zRS1Sz/wg6QfDBul3Jp10NokJGL1yaNihDsApP0fCIUJ8/gE2+P?=
 =?us-ascii?Q?Krb4ONR9Xb1QTe0qH/uEFAm2U5L8CdUZZfGGN2tX2uCOw2Ii/AvtOVrGwXUW?=
 =?us-ascii?Q?L1hrUp2x3pz6z5wkH+Ni4A/VMW5FkRHfO+xGk2X0iQ9KPO8RfJYRq69u9vWc?=
 =?us-ascii?Q?C2UykKvWlZjGUbn0mhn+Zlgkzm9W9MaH74wswsBbeJEOePi7339X2CX/cEiB?=
 =?us-ascii?Q?dPRzp7BuvDF6u02xIojaN8+gpmq1nwEttr6yELGNCA2CRbwB8DgRxPv6pT+F?=
 =?us-ascii?Q?tt2Y7ekEK7NWVPVkNJdU5tSyKLqOjMmCt6eQoXDq/IrMf+Qe/vgi49o6d+tk?=
 =?us-ascii?Q?F+vFb1rMqhWp6Ks2YSOSu4xnDjlVfHNmJpwwexD09NucQLyfysYId4CHJOK7?=
 =?us-ascii?Q?8uqTYifYqUYyvyX78/t8t2dU5zDJ4aELcT6ZgkQVq2e0hI/R7tBv/VPpUaOW?=
 =?us-ascii?Q?fefOh+AyDZCYscL4ZGGb9AA=3D?=
X-OriginatorOrg: oss.nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9aedd7f3-f36e-464a-f0da-08d9fa511092
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2022 00:27:13.1057
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: T47ZXH2S6aaHsPdJih+6i4xSiohRjFUwkV7zlfqEFNMmjxW/B5sZH4j3XSlg4HrjuUB5G/IwadVDa6v19BREjQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6460

From: Peng Fan <peng.fan@nxp.com>

Add i.MX lpuart driver and i.MX8QM platform support.
 - lpuart is the uart IP used in i.MX8QM/QXP/93.
 - Very basic i.MX8QM platform support.

Peng Fan (3):
  xen/arm: Add i.MX lpuart driver
  xen/arm: Add i.MX lpuart early printk support
  xen/arm: Add i.MX8QM platform support

 xen/arch/arm/Kconfig.debug              |  21 ++
 xen/arch/arm/arm64/debug-imx-lpuart.inc |  48 ++++
 xen/arch/arm/platforms/Makefile         |   1 +
 xen/arch/arm/platforms/imx8qm.c         |  44 ++++
 xen/drivers/char/Kconfig                |   8 +
 xen/drivers/char/Makefile               |   1 +
 xen/drivers/char/imx-lpuart.c           | 303 ++++++++++++++++++++++++
 xen/include/xen/imx-lpuart.h            |  64 +++++
 8 files changed, 490 insertions(+)
 create mode 100644 xen/arch/arm/arm64/debug-imx-lpuart.inc
 create mode 100644 xen/arch/arm/platforms/imx8qm.c
 create mode 100644 xen/drivers/char/imx-lpuart.c
 create mode 100644 xen/include/xen/imx-lpuart.h

-- 
2.30.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 28 05:12:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 05:12:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280087.477960 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOYKd-00056X-26; Mon, 28 Feb 2022 05:12:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280087.477960; Mon, 28 Feb 2022 05:12:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOYKc-00055l-SI; Mon, 28 Feb 2022 05:12:22 +0000
Received: by outflank-mailman (input) for mailman id 280087;
 Mon, 28 Feb 2022 00:27:25 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=tLaL=TL=oss.nxp.com=peng.fan@srs-se1.protection.inumbo.net>)
 id 1nOTsq-0007Sm-O5
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 00:27:24 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04on062e.outbound.protection.outlook.com
 [2a01:111:f400:fe0c::62e])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 329673d4-982d-11ec-8eba-a37418f5ba1a;
 Mon, 28 Feb 2022 01:27:23 +0100 (CET)
Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11)
 by DB8PR04MB6460.eurprd04.prod.outlook.com (2603:10a6:10:10f::27)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.25; Mon, 28 Feb
 2022 00:27:21 +0000
Received: from DU0PR04MB9417.eurprd04.prod.outlook.com
 ([fe80::552c:ed46:26dc:77cc]) by DU0PR04MB9417.eurprd04.prod.outlook.com
 ([fe80::552c:ed46:26dc:77cc%4]) with mapi id 15.20.4995.018; Mon, 28 Feb 2022
 00:27:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 329673d4-982d-11ec-8eba-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=hSfyKXEm88+iJ7OIfLAfKPjFKy6RT5jXGQrj3rrU4e1e6zsWPs+qo/1lWctfGLczFqStJdiZVAGZmRNYR4SSm1s8XbuGCo8UzfDFL0C+jP9AHRH8UVS9acrR8Pm52Y+Xtpn9+rBWcdP0vJG3Pkgd7EQHZUuWIAe2Ufp0sPRAKh2vcCdCBp5BDolmNVVfluL6uKk/tKleQJTdZyoL6PuB1xwZPzVsHtQztlYplQccPYwBde8E7E41mD/S6JbE3cvKxsQcuD67s1JygD5XqSKI4PWg8NouI1ujmPa5MCbPQ+5JcU/Yq3rwTzPH+MOYDf/+juL5WHabtlj8hw3C1+OJLQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=HQTF4tiGiA6bqr8wGDrApHkfcsxMIqMshDIrr4CmuTU=;
 b=Ok9F2B6SgOKau2+gFivh8Nj97bBBDFK1K+TzC/pedVZbh+YfjAoplkZYXQkg09I+X3bgr9eyWCHQFYNZezPHFt1keART70YDQWjDud3ypu8XaA5H5xxLuG5qJU3R8OixD5V47Q8Ua+1zqn7ZcdLevjQrkqSiQb4Oms2Cy6jw47cl7bXFoTnrhZyiJigLYpVgls83dWT5I4o7Q5H+GPFhnFJ17EFoA7gj9wmAVRnfDW9VzlRX9qVtc/3cE6/AXvUAPbilL9uV+7kgaoifHOBeBMbavp5eHs/O8i9RrSvRD7hXV1ltKJaOhlhMaM8fn4O9yH/wzpXlAjPtQtkA7gHB/g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com;
 dkim=pass header.d=oss.nxp.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com;
 s=selector2-NXP1-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=HQTF4tiGiA6bqr8wGDrApHkfcsxMIqMshDIrr4CmuTU=;
 b=mPFwL/knohds/yZ6cjH9EZfWgPMgztle4PWcW/4akid82CmmafCb66jBQUZTAlwikDYvJdBw3xZO3qHNzXEYqI36Fl5KUlC4Vbxt+23YuA1C+JbnBB4r+MmTkJIK4kksKS5js+lKlQBsNVrLr79D4CDy0td336lw/djVXew881o=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=oss.nxp.com;
From: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
To: sstabellini@kernel.org,
	julien@xen.org,
	Volodymyr_Babchuk@epam.com,
	bertrand.marquis@arm.com
Cc: andrew.cooper3@citrix.com,
	george.dunlap@citrix.com,
	jbeulich@suse.com,
	wl@xen.org,
	xen-devel@lists.xenproject.org,
	van.freenix@gmail.com,
	Peng Fan <peng.fan@nxp.com>
Subject: [PATCH 2/3] xen/arm: Add i.MX lpuart early printk support
Date: Mon, 28 Feb 2022 09:07:10 +0800
Message-Id: <20220228010711.11566-3-peng.fan@oss.nxp.com>
X-Mailer: git-send-email 2.30.0
In-Reply-To: <20220228010711.11566-1-peng.fan@oss.nxp.com>
References: <20220228010711.11566-1-peng.fan@oss.nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-ClientProxiedBy: SI2PR02CA0001.apcprd02.prod.outlook.com
 (2603:1096:4:194::10) To DU0PR04MB9417.eurprd04.prod.outlook.com
 (2603:10a6:10:358::11)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5c43f520-0d5a-4339-c7f7-08d9fa5115cc
X-MS-TrafficTypeDiagnostic: DB8PR04MB6460:EE_
X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True
X-Microsoft-Antispam-PRVS:
	<DB8PR04MB6460E824D623CF2499BDE905C9019@DB8PR04MB6460.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	VJ6oA1A33nHN2+3zo9pJwh5y2Y+PfNAZxMIAlUhF6wmiHrXftDIFkofJprp1nVz+WNAPQ9DlnEM09NuOKnJpFbZ//Pk12lh/LycCskzwTQ94skEcmdYQx9GV80qP25I6YzxSD1x3FlL7A70auw95a+qUH3LJ+58Uim4FHBW4Fk9hyeIKRD16tCCWlpFxF0ubfo+X5qyvBO4vm6clGJkkkJzzsg5ZSzYUb5LkhvgTPOVX8HgRNVG8la/hWeO7bS9TURevvIAKqS5dH3bLxKYcosOHKAm9A8NPcL3UpSblFISwKsQl+cAmI/SsJ0yQGhHxD5A7Q3Xw+6szWi0PQ8u9q8xqz7mVuNXY4GARx49C9nH/K5VOx82vc5o7XJXmdOOwC5oXdb5BwPpGJX07nVPBgRHI/VA3rNu4jahEhyQAUjP/RH0hD9LFSjgykKm5VhhQdHV/8HX2pZ0cYhUE02sR4C0JZYxl8jfFh+hjx8fdcM1ori/SEIfBalfIVkU01jYg53hC9Y/SGUKntN/9h0EGQPWPi1iPhbBRJS17b3cp+t2JRckqShWXiQ1WHZCmtiYFaxPFf5hf383QjS52MSfnzSav/GsO7rNMWUmc6oBX3eLMcR5Y1xIsWUa8HtiOjAFUmnL+gXzZw0T7bM/aKAT6M80/wABaEGHRQ/dcGWyrYqBEOkWYWQZyI0ol/41rQDLUbmogTgkSlyudnXEvUHvBd6yr93pHOotuqK4aMlPmYIY=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66946007)(66556008)(66476007)(6512007)(6506007)(6666004)(316002)(4326008)(8676002)(52116002)(2906002)(2616005)(1076003)(86362001)(26005)(186003)(5660300002)(6486002)(38350700002)(38100700002)(8936002)(7416002)(508600001)(2004002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?Ox3s7WlQfZ+VfDVreq/oshTEe6eoZyEWMJ/7hudbrfqrZ1RhIf03X1uOkNhL?=
 =?us-ascii?Q?r3jU2UTYSQMIGmA/vN6RyEjf92I9Xv6LADRUlIQfNILnOzCf9dDEpiKI2+Gz?=
 =?us-ascii?Q?0HAWfZe89GkPE67OaeJQhr1PAFsquIRx99FWp+7wm4TL9d03UE+ubR9/ZY1M?=
 =?us-ascii?Q?D34M+SU1+NtYxGt/ZQMiT7hpM2jDeN1QVczwGd63ApGvDJraxk4dJu8YQ6z3?=
 =?us-ascii?Q?v1xKoAahTwz/BLqmhEk4OSnsXLoGSe9fFByDMGKWaAR7k5fD60zDc7PBi1f3?=
 =?us-ascii?Q?LmdrD8oSqRUeBr/KMQ1lhg1wfIqo2oa7mbA293/MTp+jyiYZXbHj1hmlLMw0?=
 =?us-ascii?Q?tVVVuj9MWunDXFQ/Fubzh85EB8R9pmT+fd6EXYoGlXBUi1JkQFmX7fxL6AB/?=
 =?us-ascii?Q?Bsm0LYfLVCesTCcxTNJMeW6+GdQ9ZcWvTehunVAlnz9AOe8KCexiBbK8w+hU?=
 =?us-ascii?Q?DckZBrPUPqS//hTh+5KOBKV9rk16B9i4SM/UE9Bs8TIu36JsDEFIj1ykCkU+?=
 =?us-ascii?Q?zVuCJenXUbMLS5uFnfJUZtGJZwRr1UaCBnyR7nB+lTn0HTu3Gqk058qnK4Bd?=
 =?us-ascii?Q?RB9BSsI9CF+HuXuumzft8hY6PTQm9r4lMQC7sONn+tMs1eMHfhbPm2EdustL?=
 =?us-ascii?Q?U1eZDQdWl3arb39q4PqO9tCGiteuR8evkT0L8pfmO0gxLi6GJB4pBuqugzes?=
 =?us-ascii?Q?xLZQMjwYgF6IhNe1Vxeby2Uz89UXu2DIdNXCyNQcCPVMYzOarGpwVrlKxZVd?=
 =?us-ascii?Q?hIhEH9h/ufZdZvblvUriDOhEvgRTqbiVGzaPkPPz8cRNhRjuXKMwbIDIh8Li?=
 =?us-ascii?Q?lXW1FaQg9oM7jeJFDF4A1fz+T1XFb1XtG6zNNDeLXF1vhBlFzgNIHaHgTsej?=
 =?us-ascii?Q?0nHmHqmfV2BgRTePlqRcd1wuLarA4T1YtbyHVwFq29mPmfswfAykh70lUvQl?=
 =?us-ascii?Q?pta5k1HjNAcZFEtju7Ov/9GQr8ASWmgI7V8ulXu4lzTFx9bpFhnDY/7hRV+L?=
 =?us-ascii?Q?+9PEn+faV0fR3kBjwFoz2IdVECHxi9kLG6yKy9A8C+1oHco76G79g1Ic6M2B?=
 =?us-ascii?Q?xBHGqgepqTa2gfNf9EKTQTTmu0J6Wb8QLgt4nqGpc+IA6/wr2f378FGPeREy?=
 =?us-ascii?Q?j/8hVxUcXSByCroi/Vbc8/LXnv2diz2/sUEHjxnNTGk8zO2BWmgfE3JEqsTj?=
 =?us-ascii?Q?U3ih+ba6u/GTlS8VhFz7T9N0276v9Uc0FUqm6SXbH5W0OOt5/Y58U0A4mz0V?=
 =?us-ascii?Q?j2FYUN4EJmdgquCgtFDIcLWUxhsIrSyCK4IlGC0EZvzhQ6lJsDQmzBhITFFS?=
 =?us-ascii?Q?718Q2404oyNz6wKubXKrGrhSgNtRWeRc97IIbDETCm6DIapcAnnb5kTZKLJk?=
 =?us-ascii?Q?uADE45L2pYEkvEn4f4lJdK3Aju8m2nnzPCr6RniEJ42zAYsqX1NJOZyeABxA?=
 =?us-ascii?Q?FzARX5ksPipfLPQYfcXKvYHBhu6sO7hkwQgTtSMvzPA+QR/WtFV5wCEgmM3A?=
 =?us-ascii?Q?Oy2Z2VwlY9XQhR+fy+VV9ScxRlFX6+pXoX7HqxmCr4ustgB9ekxc3Zp3pKAM?=
 =?us-ascii?Q?JdiliP0aUMuPfY9rc4IVg1s7cZI7ab+m2JuRgRztsSrMzxyAr/pPOtrbRnTE?=
 =?us-ascii?Q?FEpZfntLRfRObnEbhbHXu6I=3D?=
X-OriginatorOrg: oss.nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5c43f520-0d5a-4339-c7f7-08d9fa5115cc
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2022 00:27:21.6403
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nQDVnKWb2+ruoBIbLr+n6Kvrranrf1p0OwVzodIRM8BZZe/BTHabB8by4SBJ/8kLJ2rrR6OE+ikFJRRuq0+D5A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6460

From: Peng Fan <peng.fan@nxp.com>

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 xen/arch/arm/Kconfig.debug              | 18 ++++++++++
 xen/arch/arm/arm64/debug-imx-lpuart.inc | 48 +++++++++++++++++++++++++
 2 files changed, 66 insertions(+)
 create mode 100644 xen/arch/arm/arm64/debug-imx-lpuart.inc

diff --git a/xen/arch/arm/Kconfig.debug b/xen/arch/arm/Kconfig.debug
index 35ccd13273..9ecb446b3a 100644
--- a/xen/arch/arm/Kconfig.debug
+++ b/xen/arch/arm/Kconfig.debug
@@ -55,6 +55,20 @@ choice
 			selecting one of the platform specific options below if
 			you know the parameters for the port.
 
+			This option is preferred over the platform specific
+			options; the platform specific options are deprecated
+			and will soon be removed.
+	config EARLY_UART_CHOICE_IMX_LPUART
+		select EARLY_UART_IMX_LPUART
+		depends on ARM_64
+		bool "Early printk via i.MX LPUART"
+		help
+			Say Y here if you wish the early printk to direct their
+			output to a i.MX LPUART. You can use this option to
+			provide the parameters for the i.MX LPUART rather than
+			selecting one of the platform specific options below if
+			you know the parameters for the port.
+
 			This option is preferred over the platform specific
 			options; the platform specific options are deprecated
 			and will soon be removed.
@@ -186,6 +200,9 @@ config EARLY_UART_CADENCE
 config EARLY_UART_EXYNOS4210
 	select EARLY_PRINTK
 	bool
+config EARLY_UART_IMX_LPUART
+	select EARLY_PRINTK
+	bool
 config EARLY_UART_MESON
 	select EARLY_PRINTK
 	bool
@@ -283,6 +300,7 @@ config EARLY_PRINTK_INC
 	default "debug-8250.inc" if EARLY_UART_8250
 	default "debug-cadence.inc" if EARLY_UART_CADENCE
 	default "debug-exynos4210.inc" if EARLY_UART_EXYNOS4210
+	default "debug-imx-lpuart.inc" if EARLY_UART_IMX_LPUART
 	default "debug-meson.inc" if EARLY_UART_MESON
 	default "debug-mvebu.inc" if EARLY_UART_MVEBU
 	default "debug-pl011.inc" if EARLY_UART_PL011
diff --git a/xen/arch/arm/arm64/debug-imx-lpuart.inc b/xen/arch/arm/arm64/debug-imx-lpuart.inc
new file mode 100644
index 0000000000..7510210d46
--- /dev/null
+++ b/xen/arch/arm/arm64/debug-imx-lpuart.inc
@@ -0,0 +1,48 @@
+/*
+ * xen/arch/arm/arm64/debug-imx8qm.inc
+ *
+ * i.MX8QM specific debug code
+ *
+ * Peng Fan <peng.fan@nxp.com>
+ * Copyright (C) 2016 Freescale Inc.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#include <xen/imx-lpuart.h>
+
+.macro early_uart_init wb wc wd
+/* Already initialized in bootloader */
+.endm
+/* i.MX8QM wait LPUART to be ready to transmit
+ * rb: register which contains the UART base address
+ * rc: scratch register
+ */
+.macro early_uart_ready xb, c
+1:
+        ldr   w\c, [\xb, #UARTSTAT]   /* <- Flag register */
+        tst   w\c, #UARTSTAT_TDRE     /* Check FIFO EMPTY bit */
+        beq   1b                      /* Wait for the UART to be ready */
+.endm
+
+/* i.MX8QM LPUART transmit character
+ * rb: register which contains the UART base address
+ * rt: register which contains the character to transmit */
+.macro early_uart_transmit xb, wt
+        str   \wt, [\xb, #UARTDATA]  /* -> Data Register */
+.endm
+
+/*
+ * Local variables:
+ * mode: ASM
+ * indent-tabs-mode: nil
+ * End:
+ */
-- 
2.30.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 28 05:12:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 05:12:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280090.477966 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOYKd-0005C0-D3; Mon, 28 Feb 2022 05:12:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280090.477966; Mon, 28 Feb 2022 05:12:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOYKd-0005AI-4v; Mon, 28 Feb 2022 05:12:23 +0000
Received: by outflank-mailman (input) for mailman id 280090;
 Mon, 28 Feb 2022 00:27:28 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=tLaL=TL=oss.nxp.com=peng.fan@srs-se1.protection.inumbo.net>)
 id 1nOTsu-0007Sm-8e
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 00:27:28 +0000
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01on0615.outbound.protection.outlook.com
 [2a01:111:f400:fe02::615])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 34ac9e04-982d-11ec-8eba-a37418f5ba1a;
 Mon, 28 Feb 2022 01:27:27 +0100 (CET)
Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11)
 by DB8PR04MB6460.eurprd04.prod.outlook.com (2603:10a6:10:10f::27)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.25; Mon, 28 Feb
 2022 00:27:25 +0000
Received: from DU0PR04MB9417.eurprd04.prod.outlook.com
 ([fe80::552c:ed46:26dc:77cc]) by DU0PR04MB9417.eurprd04.prod.outlook.com
 ([fe80::552c:ed46:26dc:77cc%4]) with mapi id 15.20.4995.018; Mon, 28 Feb 2022
 00:27:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 34ac9e04-982d-11ec-8eba-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=kCH+/SIbWCm2C9FOwOeomig7vCKzcsAQ6VIhYK2b9zhhrFO3/Bb1PICUl0arGYD/TeLUcW++7gGcVwBiA3Jy/aNnAiCGXHkmhM7qaSY60G6ZwYXTCLaeT3WFGCbJGusBbXm2Wvr8ar6n0ALDWEDatuOnFC6d9qxL+5lVuIk7dZ0xAkliarjaf1RTV5Qi7p+hAJpFa+uhVL433ugjGBYeaMETnWxrKH5RDB/ds9Fh8rf3cVPg0SU0Xjrb8uNRDEnmFhfQBRJEDG6kAE8Jo52aJKSLraQixJALC8KOfuftazcBudH+oQuRzGOZAwimYuP+cQhbt6Mk4OPAZ9Jy+YyPYg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=FsCR7rC+1KKOTplUp+q9rcVTXAyb/TEnoFHsWncVriA=;
 b=BgNBqjQlhlmHN9e1DrRznU27RVV0fCMo501/Ww+YjhsahoPpHDTSS/vMpXJk4szKQM0ovjZKBMq2PhBo3gSLwKkswJ8996QhIgX8I17vFD8S3ZlWtytvAz/6HS/4GhcZ7wGKjEZGmHMVtCbY+N8YG0FtSuOLxG3KJBjA/7wVPgH9zb0V+getUq2k90ZrQ/tLOJKNUWcQkrTCXv2/RYpsxEFeF5i2kXSjcZdx1FrUc4cgFYAYDl3CdjdBrPsgBw0Om3/WjFB0BOiBZjGqAedVXx7bLDvEx+70nEeGgMrd5j1jRnhtIQeQb0T3y5T/wXv98n7ALd6BV5Z1uqbg7KFMlQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com;
 dkim=pass header.d=oss.nxp.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com;
 s=selector2-NXP1-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=FsCR7rC+1KKOTplUp+q9rcVTXAyb/TEnoFHsWncVriA=;
 b=d0ENjTqy7lns4aX44kXF+NkZN4Y/zJAiPzv8VGvm7ifS5c5si2zm51gjZpq1nyCgqL/OPt2G7BAxcKvZa3z6m2UeQ579OsGsB+lJJ/YkNNC/mTtXpqWCNwRUd4Hd5nyJRCd+Pu6mhbXqNFRZPmX/zLPWJGH2Aq9hkF4YTSWbsu8=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=oss.nxp.com;
From: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
To: sstabellini@kernel.org,
	julien@xen.org,
	Volodymyr_Babchuk@epam.com,
	bertrand.marquis@arm.com
Cc: andrew.cooper3@citrix.com,
	george.dunlap@citrix.com,
	jbeulich@suse.com,
	wl@xen.org,
	xen-devel@lists.xenproject.org,
	van.freenix@gmail.com,
	Peng Fan <peng.fan@nxp.com>
Subject: [PATCH 3/3] xen/arm: Add i.MX8QM platform support
Date: Mon, 28 Feb 2022 09:07:11 +0800
Message-Id: <20220228010711.11566-4-peng.fan@oss.nxp.com>
X-Mailer: git-send-email 2.30.0
In-Reply-To: <20220228010711.11566-1-peng.fan@oss.nxp.com>
References: <20220228010711.11566-1-peng.fan@oss.nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-ClientProxiedBy: SI2PR02CA0001.apcprd02.prod.outlook.com
 (2603:1096:4:194::10) To DU0PR04MB9417.eurprd04.prod.outlook.com
 (2603:10a6:10:358::11)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e9757529-61b1-49b3-2fae-08d9fa5117f6
X-MS-TrafficTypeDiagnostic: DB8PR04MB6460:EE_
X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True
X-Microsoft-Antispam-PRVS:
	<DB8PR04MB6460A7AA1938DBCB3C38FEB3C9019@DB8PR04MB6460.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	1BJfX+UagmLtDP/RCLcKh+2jO8OfGZU1VG709rjFFd/LEvyG3t5bq6GA3cRRTu+Xv2H3BOdNzBtNN3A/f9LO/Bbkqkfr9aWb+PbC5Itbl9L8hUJDwK5iwp9leHwC5bndsJd3/HYJTHgFl6lGyb0A2HgDujl48AjtZuywbD/V5KWdrzx/D5x1fp9IFJdxAV6sIoMa1zIJeQB3aeQiyy2GU89SFV3ju263ag7TW88nJUuLhLZ5vPwFgUJspe7b8aqChgdSGR7vCK0hXSPZuDLkJyKNMw5n7B4eMZ6GeRDkL1L+lRoK50mdsOyczPqm5arByWpyOqRfe+7T0kk6m6D0rL7UH0aAvGQvBfCYczpCn7veGb1VArZ3UoyOc4BsGC6+k6m0JpbuW/Qyo0uctmU9E2oS/gXUYlesgaq3J8gtKq5FoEeYYsiNw4CC7Qi2boCUE68yuHn8MjBBcXEIxMcSZKOQJEcgMjFBBHgpiNvnP1S1XxmwLWHvNPNuj0l8QaHbVvOgnQ3KENzxLauMz0DMAiWvhzc5YUPN4wFGXAwQwiaJSX5ddxB+qPZBAWrpI3mKqb724l8yzU6IT0B3+67uDZa/kl6H3hJvtVuy5ry85Nhbix9g4kVkTHqUOUyH2OtWJSBZonQx4iLvSkR2aFNPGxbLphHMuX1j5mEk2bju0MrcQYeOnOK1kNQoy4/FSjQZFGzmsVHrf5mcYXpi7uJ0YVjaQMws4zGSeyfw6ujv2sU=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66946007)(66556008)(66476007)(6512007)(6506007)(6666004)(316002)(4326008)(8676002)(52116002)(2906002)(2616005)(1076003)(86362001)(26005)(186003)(5660300002)(6486002)(38350700002)(38100700002)(8936002)(7416002)(508600001)(2004002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?F6pBc2KQYLUxP4OI/Flimarlv14niNUbJG2LAdw+BszRLawgaigdHmcFWADK?=
 =?us-ascii?Q?G+UmCGI3pMH4hfI53lsN15jKvVGf9HeEJLF0jBklGnlMLr8juyESjeOvC1rY?=
 =?us-ascii?Q?I57mEBS8OVuHeBw6etVlz9ivXPOZfkzKKPuOBiIRNWGAruzSl0NbdBBmTgwK?=
 =?us-ascii?Q?x5hoOR7Y+ExHuMWWL3Ws70hGWozsINjWzxs9Vghc1qqVGqTyv0Lv4YdfsrzT?=
 =?us-ascii?Q?rrofu0Tu1YZSgVgKG+CiZCb8z+/zLPRHwQi0NSHQGJw3squfxaBIJWdQPxSA?=
 =?us-ascii?Q?r8aHietJHmqbxdBfNNcZjQ5cvOF7/J6XCjNrINTvtHwH1kAxpzJeNAYm2J1q?=
 =?us-ascii?Q?N78/z/vcxH7gGJvXz2FJy3liODTDLoml21+Z/l6RcGAb/YRb3Np8e287EMxu?=
 =?us-ascii?Q?Iqdh3xsEteDf4IREFMkSW+63ZTH4Ue4k1hQiGEjwyKcRnVO8r/0ywTyyEmLt?=
 =?us-ascii?Q?Iw4lz+geuqHfD4Vz209T7K0gNeybMKkhVALlCx7J24t4CPYpJGln8Y8fmY0b?=
 =?us-ascii?Q?Yj8N8+9RVf4F5WZ4yUjQp5NPDnNonqGy+cDZPdGXsRXD6Pw32wGB23NKnCbw?=
 =?us-ascii?Q?nYM/ND/MoYBuNfIZHOHg0shOdHlYSQcBtb3/p1es4xletNiXburmt2seS9G9?=
 =?us-ascii?Q?Wd/1uuk+4lqZLoJJH+mpnzgt/Otutyi+rwOC0uEXF3lAUgxHjXk/lQ0eqsTo?=
 =?us-ascii?Q?Fz+6CDKJrXfhxWdtafk+2vC6J5Bek7Vg8lo/hdatpKdosloh2DrcvMmvUx7u?=
 =?us-ascii?Q?INt0rdbPtucyGXoQe3iHBFIxftx0Im10qlaSlgGnx5dgt64rZZmJULNDCVz5?=
 =?us-ascii?Q?7evrbn3IWhGyEirxPAF83uiW6dtbDJ7/qiTl7ozL2amcOUVBUaFaDCkGPCcs?=
 =?us-ascii?Q?BUwtrLyGOcLy+zIJFD+Chss+SnZfObr3wiXUtViM36f7Z5pEtFi/aegXP1om?=
 =?us-ascii?Q?R+WHHFYgBQ7qVufUgn0pGaADfdZfumvL2QnQ1DFmywIgEo+sPmHHqnjOwudR?=
 =?us-ascii?Q?kA7JaFvVKyHH4a5m6BaQyO8Knv9NeXAb/qWf5x76uqQbhC2GBPVXytZaBfw3?=
 =?us-ascii?Q?3ZZS7Ibj7DqAR/cLWLY0X0vKx2Ae0iuzKuZkzPYTq1zyDkJQBENLq5D+sQNq?=
 =?us-ascii?Q?8/NUDD6wzZh/KTuvon9Tp/l32OInONqD6BR8qhHrPOqnUSv88y1rKKSEIs7i?=
 =?us-ascii?Q?tW3lJeqOKzwAoRJMgMBBAdDraHozggiAHbpYFSxClkepyZ3ZEvaFT3kGQnWJ?=
 =?us-ascii?Q?3+nWJ3KQ4f+cDCMe5vZ9dqKh3rz4XJSOGX9VrFZg1DgUqn1kPvtAnC3CWwtm?=
 =?us-ascii?Q?V2gMjcT2lppNpAjZggnfa5iD8fEKLMnROyRQJzvt0R55obIGgB+ULHR7stY/?=
 =?us-ascii?Q?8Qm6a7Q54oh3ku/cqAmDGDpZtmKiKVaEd9NjUiC/RPvxqgn7vr3gbRGv36zE?=
 =?us-ascii?Q?Cv0/OUvxONXzb5C7FJw/W/G62utHQrDgYlq/h7Ee7zposKXci7ceR69RNz9G?=
 =?us-ascii?Q?8ug+ei9M+xOsuqJW4fg227ImYPOU2+fSzMVHuAepbq7lRSYViqTsuKb3CBbx?=
 =?us-ascii?Q?28yYG3YmLEyMhV0f/GZBPPqVsI3xn1Wuq0kyanf9io6vkGSCF03W/YwuFlQW?=
 =?us-ascii?Q?VSIW4KduX+/ytcZDGP1JRB8=3D?=
X-OriginatorOrg: oss.nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e9757529-61b1-49b3-2fae-08d9fa5117f6
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2022 00:27:25.4065
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zk/OkScjFGK3h+yhfESsntwx6yW3qKpMRqT54zyJt38rF6Lk4vHSQnYD7U43n3qj3R081hZhC5kxHD4KuPLhIQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6460

From: Peng Fan <peng.fan@nxp.com>

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 xen/arch/arm/Kconfig.debug      |  3 +++
 xen/arch/arm/platforms/Makefile |  1 +
 xen/arch/arm/platforms/imx8qm.c | 44 +++++++++++++++++++++++++++++++++
 3 files changed, 48 insertions(+)
 create mode 100644 xen/arch/arm/platforms/imx8qm.c

diff --git a/xen/arch/arm/Kconfig.debug b/xen/arch/arm/Kconfig.debug
index 9ecb446b3a..43ccd8fe62 100644
--- a/xen/arch/arm/Kconfig.debug
+++ b/xen/arch/arm/Kconfig.debug
@@ -143,6 +143,9 @@ choice
 	config EARLY_PRINTK_HIKEY960
 		bool "Early printk with pl011 with Hikey 960"
 		select EARLY_UART_PL011
+	config EARLY_PRINTK_IMX8QM
+		bool "Early printk with i.MX LPUART with i.MX8QM"
+		select EARLY_UART_IMX_LPUART
 	config EARLY_PRINTK_JUNO
 		bool "Early printk with pl011 on Juno platform"
 		select EARLY_UART_PL011
diff --git a/xen/arch/arm/platforms/Makefile b/xen/arch/arm/platforms/Makefile
index 8632f4115f..bec6e55d1f 100644
--- a/xen/arch/arm/platforms/Makefile
+++ b/xen/arch/arm/platforms/Makefile
@@ -9,5 +9,6 @@ obj-$(CONFIG_ALL_PLAT)   += sunxi.o
 obj-$(CONFIG_ALL64_PLAT) += thunderx.o
 obj-$(CONFIG_ALL64_PLAT) += xgene-storm.o
 obj-$(CONFIG_ALL64_PLAT) += brcm-raspberry-pi.o
+obj-$(CONFIG_ALL64_PLAT) += imx8qm.o
 obj-$(CONFIG_MPSOC_PLATFORM)  += xilinx-zynqmp.o
 obj-$(CONFIG_MPSOC_PLATFORM)  += xilinx-zynqmp-eemi.o
diff --git a/xen/arch/arm/platforms/imx8qm.c b/xen/arch/arm/platforms/imx8qm.c
new file mode 100644
index 0000000000..289c18e5f9
--- /dev/null
+++ b/xen/arch/arm/platforms/imx8qm.c
@@ -0,0 +1,44 @@
+/*
+ * xen/arch/arm/platforms/imx8qm.c
+ *
+ * i.MX 8QM setup
+ *
+ * Copyright 2022 NXP
+ *
+ * Peng Fan <peng.fan@nxp.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#include <xen/delay.h>
+#include <xen/mm.h>
+#include <xen/vmap.h>
+#include <asm/io.h>
+#include <asm/platform.h>
+
+static const char * const imx8qm_dt_compat[] __initconst =
+{
+    "fsl,imx8qm",
+    NULL
+};
+
+PLATFORM_START(imx8qm, "i.MX 8")
+    .compatible = imx8qm_dt_compat,
+PLATFORM_END
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
-- 
2.30.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 28 05:12:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 05:12:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280086.477951 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOYKc-0004yq-MW; Mon, 28 Feb 2022 05:12:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280086.477951; Mon, 28 Feb 2022 05:12:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOYKc-0004y9-Ha; Mon, 28 Feb 2022 05:12:22 +0000
Received: by outflank-mailman (input) for mailman id 280086;
 Mon, 28 Feb 2022 00:27:22 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=tLaL=TL=oss.nxp.com=peng.fan@srs-se1.protection.inumbo.net>)
 id 1nOTso-0007Sm-HQ
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 00:27:22 +0000
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01on0618.outbound.protection.outlook.com
 [2a01:111:f400:fe02::618])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 30b02d9f-982d-11ec-8eba-a37418f5ba1a;
 Mon, 28 Feb 2022 01:27:21 +0100 (CET)
Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11)
 by DB8PR04MB6460.eurprd04.prod.outlook.com (2603:10a6:10:10f::27)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.25; Mon, 28 Feb
 2022 00:27:18 +0000
Received: from DU0PR04MB9417.eurprd04.prod.outlook.com
 ([fe80::552c:ed46:26dc:77cc]) by DU0PR04MB9417.eurprd04.prod.outlook.com
 ([fe80::552c:ed46:26dc:77cc%4]) with mapi id 15.20.4995.018; Mon, 28 Feb 2022
 00:27:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 30b02d9f-982d-11ec-8eba-a37418f5ba1a
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=BjhichTcyAAIgI9ku7T2z284g06GO1wQHMR1atsu2pLjb+pDsaiU+pDnVFpBzOBmelMr1Np476YrFqcoFJ2wZOiWPpyNXXzQ9U1hHT9ee9iaDwa0BMRnrsbIp70M5oZKai3eJbfxSexByydtR1J23kfR9yYWv4ESUDYxptESrrJmvJNK6hb+ldXnIkV4yqivbPUjZj8xZNYN0GzOKhmcpnOpLey0aQtd09SludG0lLVmkeVCPJeSDPzBrzYrtLy7ox6bCUsolMMJY2KwJVap8jdlTaRYXWrh5ryBvn7H6WHXbGhftmFfHwmZf5PktPBsTN4U51UHWGFLy8dQswdkrw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=+wXOdp/qRyy28MQahFckXGWnjzLCGIX/DgJitz/KjhM=;
 b=Mny9SoOjoLQyHueLvltwCcOQapOrHDjvMGJMNP2KYt3Oep3jSpoqiw9VDbKYzGj1zXHa2wo+TTsAjHwm93rdwRg4F37RqBdIlGuWbN6W22MU3ih3UAyE6yz9zp6FaRfx/HNem9XH18JrOCcV2f1qnKDx6+xNKYUTkr/lj2baCAfPk4SwGEKxGbQl1KrNaoRMbG5Gc+B74RepTluNDwQ2sjOZglPbUmc2uefWyZLYhdiIDNqaqC94MRMPeOJ+TtXjM52KD8NTZMRsykdlMYD6j8pCNhSIObpcotCkJdoua9AwsuesNeAwx2aUh/zFT+RGbEwg5yCRbiKIBoJdN+bgtQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com;
 dkim=pass header.d=oss.nxp.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com;
 s=selector2-NXP1-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=+wXOdp/qRyy28MQahFckXGWnjzLCGIX/DgJitz/KjhM=;
 b=Kdzt/NhcxG6s67r19Frai88pZThyA/FKeyyEnxzI/nhGlG7pDCUDea5egIYbUjomloOvH5oZzxEmKh5OlXhPHwMXHRXQSnITM1/2lWQ5eRcdcd96IIobBViwctefItanMNcu1NLOmRgomKmvdhDjLpo3ihkMv8P0pqPHSgilAxY=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=oss.nxp.com;
From: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
To: sstabellini@kernel.org,
	julien@xen.org,
	Volodymyr_Babchuk@epam.com,
	bertrand.marquis@arm.com
Cc: andrew.cooper3@citrix.com,
	george.dunlap@citrix.com,
	jbeulich@suse.com,
	wl@xen.org,
	xen-devel@lists.xenproject.org,
	van.freenix@gmail.com,
	Peng Fan <peng.fan@nxp.com>
Subject: [PATCH 1/3] xen/arm: Add i.MX lpuart driver
Date: Mon, 28 Feb 2022 09:07:09 +0800
Message-Id: <20220228010711.11566-2-peng.fan@oss.nxp.com>
X-Mailer: git-send-email 2.30.0
In-Reply-To: <20220228010711.11566-1-peng.fan@oss.nxp.com>
References: <20220228010711.11566-1-peng.fan@oss.nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-ClientProxiedBy: SI2PR02CA0001.apcprd02.prod.outlook.com
 (2603:1096:4:194::10) To DU0PR04MB9417.eurprd04.prod.outlook.com
 (2603:10a6:10:358::11)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9b1b741b-5009-4730-1971-08d9fa511357
X-MS-TrafficTypeDiagnostic: DB8PR04MB6460:EE_
X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True
X-Microsoft-Antispam-PRVS:
	<DB8PR04MB646033EFC17BC649EE7F4D92C9019@DB8PR04MB6460.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	wgCsUBnEjJNfumzMcRGt4qg0+OZHROm9nnA2of5KB9Omjdx7keMJ2i4xo85TOVYhvOuq3/Tw3u69A/cbujCGpfjDH4g3TM/NjJuw3n4RKhY9ycCf/Bla04u97SjrzDbn17G4ZFLfG/ADylzIjaFokJfXuZzHQTRK6tAokVdrpadv4tG8xeEinAZlv+JJLKcYco81OcnGti20y+kKxF62IM569OgwoMzrhrp0YdQEaBMq0phLP7hzy8Pkh6QKTRU3PXyAlm2hzHxN6OQEJ9d/9J+fTIi36KdKfoELuk9m+jr5V3rUKKnmdEdSq8aIGSljYOsZrxNiBDYUXOzphvlq9/ti/XtyRXaR4XxUfwBXTo86PkzNaVXeEKiJw4dDETWrQ8gp5VXoIAiNx7vh8D11dLc8UJJDjhaKYuiyanAD6nHiWAEwlJ43AXei/OzQYrNY/9/l1jAEsLigFfDRM2jBl/Xmku+B5jjM8pgA/gEZljb9qTKs6Jbj7qVMAXie/nUZylKmBHV9KsH4A46hPuErcqTnmJvcey3vOZtF9J4MNojcVNv7Kln8hm1S5/Q3/jlB1QYuyY33rNzIKz9cq9lAbtplX3Enm1FfvU95e6+m3XdivhzxyQWlVZbBIEhiuIJIkEeHWxmvNQrEwFogbikHm73vcniVUkBwgZvLpOqRsfdFIIxYFlwvZcLONzzkIyUBpfRmGCyKob7nYBU6sk05DQZyrUw0Ko3vWVD2fSuXdUU=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66946007)(66556008)(66476007)(6512007)(6506007)(6666004)(316002)(4326008)(8676002)(52116002)(2906002)(2616005)(1076003)(86362001)(26005)(186003)(5660300002)(6486002)(38350700002)(38100700002)(30864003)(8936002)(7416002)(508600001)(83380400001)(2004002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?pTgVCFJ2DKBJDpJW+PMHoAvV3YXiGVvsqmyrrEg2UtPWmo5DVZ7sZnEBbSWE?=
 =?us-ascii?Q?ch2qQkYPlCTtLHeFBUNWtnzTib09YgtPtnRuemW1JWPLCicwCtiTa3y4EcOr?=
 =?us-ascii?Q?ISn8LbBuznD//bKdokXXWCZ+UYSUkiFzXZP5tlgmPvTH5/brnBWTzFrToiwf?=
 =?us-ascii?Q?8hZapammfFJPTWgXFSggF0vP/oL+fp+70SRrQ5Qb3OgsG1GrAQj1wyMhZw9B?=
 =?us-ascii?Q?ZjkSpO67uD93hj9i3V0iJW775AVDt0rlehzrK+LAPTGEILYrNTFUEq1WlQ7m?=
 =?us-ascii?Q?ngXboadw0qE3gHNG09fPwnG34TXO4P5WLpiAuqvJ4OlF024rBWbG6c47rtZe?=
 =?us-ascii?Q?HRO7czrWlLzgheP/EA+wOQCwB7QQAjI/ADjjO5rf2+Ayp+UMsClh9SiZSTvR?=
 =?us-ascii?Q?1R5PJ86m7kJSb51yW4gIQxePMKncv2X4HQUR+PE+fuNcM4wRTxVwXgcC4bYc?=
 =?us-ascii?Q?Z3pOiz/ehnguQRmVP15GPPjKm6LMhy4qVvOCNPt/fljxyqHo12UATdle7EVj?=
 =?us-ascii?Q?4H2sGFU8C/t+sZaXsdbk289EEekllJcKN5N/pMpUw9GK9xypqYGdHXSZKKyN?=
 =?us-ascii?Q?bRGcMyNw4CH4GMB5t20e9C+bi23isko+zmf5yKMPO24IC997G1XA5+VgQZYC?=
 =?us-ascii?Q?wX1VZBxcEPr8u4MF4x8hukcQQFfMYAfnlk4IYhs0GC9FIm0pVPzvW8o78lBs?=
 =?us-ascii?Q?JWGB5JW0ujfU5Hi51YnUGq+mIJgsStoC7+9ICQ/QU+1yN+EmD7YZpCllt7cH?=
 =?us-ascii?Q?h+X7oYEzluZOwtvWn8lR7TL09b23aMw4ELJC+kxspfEkXXWR3Hj4GcZX444C?=
 =?us-ascii?Q?Ns5cF7cnMZlMIpMOjIoNeQGTbyVEfiHh+ZbyNUCXbfmKbtREmGx+uO2NYDLA?=
 =?us-ascii?Q?bSjRdG78mFc7gk6jPy5RgM1oOyebbndzWcQD4c7bkemMWaGqQXN229yebPbW?=
 =?us-ascii?Q?5/So0EOG/DmWF6jpta6f2debVrtYpusrtvRw6zAbnu0ZrYcGbimoVnOUQz+4?=
 =?us-ascii?Q?6XI0pK46leSleW1SumjddJIYFaLFPwe80Q0lkdMWJSIqxoWr3PRU14GnJhM2?=
 =?us-ascii?Q?s4NpDksow0EdIQNBXxaS6o8a8VdLxsIifLAgbcFStZUCjl9+1lX2BHwQLZXD?=
 =?us-ascii?Q?mCOb6AkmgKNrMwZAY0QV/GNqKLvdBvO72GrbaRpYzvthuWqBNgKd6yZh9nRi?=
 =?us-ascii?Q?nxQ5EDGLzja2jd7Qj9/3KfwylmSWdi7cW0ZsOPQ2U4b234GmRlG3Ny3YA6A7?=
 =?us-ascii?Q?jbDRPCrzUZCUudhTOq0HO4iILVcXS+GuljbybTgPNRPUOIUDIelXk6z6Dzyl?=
 =?us-ascii?Q?6kreToiBvPVt/RyYWk60PRm6NLXBIH03ykk41QHNlzdnK9vw1WHAIxR+yNA+?=
 =?us-ascii?Q?duqCtdJlRs/WGbRbq3+z3W2R150dDJNglSzZBFNpqhCRkmKgWkg0kqlnfQB3?=
 =?us-ascii?Q?NB0P2wehmglVyFZjV2ZFl+58U0HeJvCoBnfPCA4FitnpBqx2e7h2XMb7RO4a?=
 =?us-ascii?Q?p8+zEpVIlOzdbHDbpgSs7/zuqxH7uANJVYzGJHN6icKbbBvtN0g7BN3/NGSw?=
 =?us-ascii?Q?TdNkCcD6qMXSnxQNskJzZn45CUILc493VjtuwOwP9I9+42XAehagVOHFbcLY?=
 =?us-ascii?Q?U1tX7xhP8zYOb//Wk/pT06E=3D?=
X-OriginatorOrg: oss.nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9b1b741b-5009-4730-1971-08d9fa511357
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2022 00:27:17.9342
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0ApXLbcKGoXA+hr2XrwmFaMUF9R07QQ2O/Rg644RIiJx8YnaPEHF+bBKY7zNgCsrlaOu4pa3IuOQLrp/3K4vQA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6460

From: Peng Fan <peng.fan@nxp.com>

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 xen/drivers/char/Kconfig      |   8 +
 xen/drivers/char/Makefile     |   1 +
 xen/drivers/char/imx-lpuart.c | 303 ++++++++++++++++++++++++++++++++++
 xen/include/xen/imx-lpuart.h  |  64 +++++++
 4 files changed, 376 insertions(+)
 create mode 100644 xen/drivers/char/imx-lpuart.c
 create mode 100644 xen/include/xen/imx-lpuart.h

diff --git a/xen/drivers/char/Kconfig b/xen/drivers/char/Kconfig
index 2ff5b288e2..0efdb2128f 100644
--- a/xen/drivers/char/Kconfig
+++ b/xen/drivers/char/Kconfig
@@ -13,6 +13,14 @@ config HAS_CADENCE_UART
 	  This selects the Xilinx Zynq Cadence UART. If you have a Xilinx Zynq
 	  based board, say Y.
 
+config HAS_IMX_LPUART
+	bool "i.MX LPUART driver"
+	default y
+	depends on ARM_64
+	help
+	  This selects the i.MX LPUART. If you have a i.MX8QM based board,
+	  say Y.
+
 config HAS_MVEBU
 	bool "Marvell MVEBU UART driver"
 	default y
diff --git a/xen/drivers/char/Makefile b/xen/drivers/char/Makefile
index 7c646d771c..14e67cf072 100644
--- a/xen/drivers/char/Makefile
+++ b/xen/drivers/char/Makefile
@@ -8,6 +8,7 @@ obj-$(CONFIG_HAS_MVEBU) += mvebu-uart.o
 obj-$(CONFIG_HAS_OMAP) += omap-uart.o
 obj-$(CONFIG_HAS_SCIF) += scif-uart.o
 obj-$(CONFIG_HAS_EHCI) += ehci-dbgp.o
+obj-$(CONFIG_HAS_IMX_LPUART) += imx-lpuart.o
 obj-$(CONFIG_ARM) += arm-uart.o
 obj-y += serial.o
 obj-$(CONFIG_XEN_GUEST) += xen_pv_console.o
diff --git a/xen/drivers/char/imx-lpuart.c b/xen/drivers/char/imx-lpuart.c
new file mode 100644
index 0000000000..2a30e3f21a
--- /dev/null
+++ b/xen/drivers/char/imx-lpuart.c
@@ -0,0 +1,303 @@
+/*
+ * xen/drivers/char/imx-lpuart.c
+ *
+ * Driver for i.MX LPUART.
+ *
+ * Peng Fan <peng.fan@nxp.com>
+ * Copyright 2022 NXP
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#include <xen/console.h>
+#include <xen/serial.h>
+#include <xen/imx-lpuart.h>
+#include <xen/init.h>
+#include <xen/irq.h>
+#include <xen/errno.h>
+#include <xen/mm.h>
+#include <asm/device.h>
+#include <asm/io.h>
+
+#define imx_lpuart_read(uart, off)       readl((uart)->regs + off)
+#define imx_lpuart_write(uart, off, val) writel((val), (uart)->regs + off)
+
+static struct imx_lpuart {
+    unsigned int baud, clock_hz, data_bits, parity, stop_bits, fifo_size;
+    unsigned int irq;
+    char __iomem *regs;
+    struct irqaction irqaction;
+    struct vuart_info vuart;
+} imx8_com = {0};
+
+static void imx_lpuart_interrupt(int irq, void *data,
+                                  struct cpu_user_regs *regs)
+{
+    struct serial_port *port = data;
+    struct imx_lpuart *uart = port->uart;
+    unsigned int sts, rxcnt;
+
+    sts = imx_lpuart_read(uart, UARTSTAT);
+    rxcnt = imx_lpuart_read(uart, UARTWATER) >> UARTWATER_RXCNT_OFF;
+
+    if ((sts & UARTSTAT_RDRF) || (rxcnt > 0)) {
+	    serial_rx_interrupt(port, regs);
+    }
+
+    if ((sts & UARTSTAT_TDRE) &&
+        !(imx_lpuart_read(uart, UARTBAUD) & UARTBAUD_TDMAE))
+	    serial_tx_interrupt(port, regs);
+
+    imx_lpuart_write(uart, UARTSTAT, sts);
+}
+
+static void __init imx_lpuart_init_preirq(struct serial_port *port)
+{
+    struct imx_lpuart *uart = port->uart;
+    u32 sbr, osr;
+    u32 ctrl, old_ctrl, bd;
+    u32 baud;
+
+    ctrl = old_ctrl = imx_lpuart_read(uart, UARTCTRL);
+    ctrl = (old_ctrl & ~UARTCTRL_M) | UARTCTRL_TE | UARTCTRL_RE;
+    bd = imx_lpuart_read(uart, UARTBAUD);
+    baud = uart->baud;
+
+    while ( !(imx_lpuart_read(uart, UARTSTAT) & UARTSTAT_TC))
+	    barrier();
+
+    /* Disable trasmit and receive */
+    imx_lpuart_write(uart, UARTCTRL, old_ctrl & ~(UARTCTRL_TE | UARTCTRL_RE));
+
+    osr = (bd >> UARTBAUD_OSR_SHIFT) & UARTBAUD_OSR_MASK;
+    sbr = uart->clock_hz / (baud * (osr + 1));
+
+    bd &= ~ UARTBAUD_SBR_MASK;
+    bd |= sbr & UARTBAUD_SBR_MASK;
+    bd |= UARTBAUD_BOTHEDGE;
+    bd &= ~(UARTBAUD_TDMAE | UARTBAUD_RDMAE);
+
+    imx_lpuart_write(uart, UARTMODIR, 0);
+    imx_lpuart_write(uart, UARTBAUD, bd);
+    imx_lpuart_write(uart, UARTCTRL, ctrl);
+}
+
+static void __init imx_lpuart_init_postirq(struct serial_port *port)
+{
+    struct imx_lpuart *uart = port->uart;
+    unsigned int temp;
+
+    uart->irqaction.handler = imx_lpuart_interrupt;
+    uart->irqaction.name = "imx_lpuart";
+    uart->irqaction.dev_id = port;
+
+    if ( setup_irq(uart->irq, 0, &uart->irqaction) != 0 )
+    {
+        dprintk(XENLOG_ERR, "Failed to allocate imx_lpuart IRQ %d\n",
+                uart->irq);
+        return;
+    }
+
+    /* Enable interrupte */
+    temp = imx_lpuart_read(uart, UARTCTRL);
+    temp |= (UARTCTRL_RIE | UARTCTRL_TIE);
+    temp |= UARTCTRL_ILIE;
+    imx_lpuart_write(uart, UARTCTRL, temp);
+}
+
+static void imx_lpuart_suspend(struct serial_port *port)
+{
+    BUG();
+}
+
+static void imx_lpuart_resume(struct serial_port *port)
+{
+    BUG();
+}
+
+static int imx_lpuart_tx_ready(struct serial_port *port)
+{
+    struct imx_lpuart *uart = port->uart;
+
+    return (imx_lpuart_read(uart, UARTSTAT) & UARTSTAT_TC) ? 1 : 0;
+}
+
+static void imx_lpuart_putc(struct serial_port *port, char c)
+{
+    struct imx_lpuart *uart = port->uart;
+
+    while ( !(imx_lpuart_read(uart, UARTSTAT) & UARTSTAT_TDRE))
+        barrier();
+
+    imx_lpuart_write(uart, UARTDATA, c);
+}
+
+static int imx_lpuart_getc(struct serial_port *port, char *pc)
+{
+    struct imx_lpuart *uart = port->uart;
+    int ch;
+
+    while ( !(imx_lpuart_read(uart, UARTSTAT) & UARTSTAT_RDRF))
+        barrier();
+
+    ch = imx_lpuart_read(uart, UARTDATA);
+    *pc = ch & 0xff;
+
+    if (imx_lpuart_read(uart, UARTSTAT) &  UARTSTAT_OR)
+        imx_lpuart_write(uart, UARTSTAT, UARTSTAT_OR);
+
+    return 1;
+}
+
+static int __init imx_lpuart_irq(struct serial_port *port)
+{
+    struct imx_lpuart *uart = port->uart;
+
+    return ((uart->irq >0) ? uart->irq : -1);
+}
+
+static const struct vuart_info *imx_lpuart_vuart_info(struct serial_port *port)
+{
+    struct imx_lpuart *uart = port->uart;
+
+    return &uart->vuart;
+}
+
+static void imx_lpuart_start_tx(struct serial_port *port)
+{
+    struct imx_lpuart *uart = port->uart;
+    unsigned int temp;
+
+    temp = imx_lpuart_read(uart, UARTSTAT);
+    /* Wait until empty */
+    while (!(temp & UARTSTAT_TDRE))
+	    barrier();
+
+    temp = imx_lpuart_read(uart, UARTCTRL);
+    imx_lpuart_write(uart, UARTCTRL, (temp | UARTCTRL_TIE));
+
+    return;
+}
+
+static void imx_lpuart_stop_tx(struct serial_port *port)
+{
+    struct imx_lpuart *uart = port->uart;
+    unsigned int temp;
+
+    temp = imx_lpuart_read(uart, UARTCTRL);
+    temp &= ~(UARTCTRL_TIE | UARTCTRL_TCIE);
+    imx_lpuart_write(uart, UARTCTRL, temp);
+
+    return;
+}
+
+static struct uart_driver __read_mostly imx_lpuart_driver = {
+    .init_preirq = imx_lpuart_init_preirq,
+    .init_postirq = imx_lpuart_init_postirq,
+    .endboot = NULL,
+    .suspend = imx_lpuart_suspend,
+    .resume = imx_lpuart_resume,
+    .tx_ready = imx_lpuart_tx_ready,
+    .putc = imx_lpuart_putc,
+    .getc = imx_lpuart_getc,
+    .irq = imx_lpuart_irq,
+    .start_tx = imx_lpuart_start_tx,
+    .stop_tx = imx_lpuart_stop_tx,
+    .vuart_info = imx_lpuart_vuart_info,
+};
+
+static int __init imx_lpuart_init(struct dt_device_node *dev,
+                                     const void *data)
+{
+    const char *config = data;
+    struct imx_lpuart *uart;
+    u32 clkspec;
+    int res;
+    u64 addr, size;
+
+    if ( strcmp(config, "") )
+        printk("WARNING: UART configuration is not supported\n");
+
+    uart = &imx8_com;
+
+    res = dt_property_read_u32(dev, "clock-frequency", &clkspec);
+    if ( !res )
+    {
+	res = dt_property_read_u32(dev, "assigned-clock-rates", &clkspec);
+	if ( !res )
+	{
+		printk("imx-uart: Unable to retrieve the clock frequency\n");
+		return -EINVAL;
+	}
+    }
+
+    uart->clock_hz = clkspec;
+    uart->baud = 115200;
+    uart->data_bits = 8;
+    uart->parity = 0;
+    uart->stop_bits = 1;
+
+    res = dt_device_get_address(dev, 0, &addr, &size);
+    if ( res )
+    {
+        printk("imx8-lpuart: Unable to retrieve the base"
+               " address of the UART\n");
+        return res;
+    }
+
+    res = platform_get_irq(dev, 0);
+    if ( res < 0 )
+    {
+        printk("imx8-lpuart: Unable to retrieve the IRQ\n");
+        return -EINVAL;
+    }
+    uart->irq = res;
+
+    uart->regs = ioremap_nocache(addr, size);
+    if ( !uart->regs )
+    {
+        printk("imx8-lpuart: Unable to map the UART memory\n");
+        return -ENOMEM;
+    }
+
+    uart->vuart.base_addr = addr;
+    uart->vuart.size = size;
+    uart->vuart.data_off = UARTDATA;
+    /* tmp from uboot */
+    uart->vuart.status_off = UARTSTAT;
+    uart->vuart.status = UARTSTAT_TDRE;
+
+    /* Register with generic serial driver */
+    serial_register_uart(SERHND_DTUART, &imx_lpuart_driver, uart);
+
+    dt_device_set_used_by(dev, DOMID_XEN);
+
+    return 0;
+}
+
+static const struct dt_device_match imx_lpuart_dt_compat[] __initconst =
+{
+    DT_MATCH_COMPATIBLE("fsl,imx8qm-lpuart"),
+    {},
+};
+
+DT_DEVICE_START(imx_lpuart, "i.MX LPUART", DEVICE_SERIAL)
+    .dt_match = imx_lpuart_dt_compat,
+    .init = imx_lpuart_init,
+DT_DEVICE_END
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
diff --git a/xen/include/xen/imx-lpuart.h b/xen/include/xen/imx-lpuart.h
new file mode 100644
index 0000000000..945ab1c4fa
--- /dev/null
+++ b/xen/include/xen/imx-lpuart.h
@@ -0,0 +1,64 @@
+/*
+ * xen/include/asm-arm/imx-lpuart.h
+ *
+ * Common constant definition between early printk and the LPUART driver
+ *
+ * Peng Fan <peng.fan@nxp.com>
+ * Copyright 2022 NXP
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#ifndef __ASM_ARM_IMX_LPUART_H
+#define __ASM_ARM_IMX_LPUART_H
+
+/* 32-bit register definition */
+#define UARTBAUD          (0x10)
+#define UARTSTAT          (0x14)
+#define UARTCTRL          (0x18)
+#define UARTDATA          (0x1C)
+#define UARTMATCH         (0x20)
+#define UARTMODIR         (0x24)
+#define UARTFIFO          (0x28)
+#define UARTWATER         (0x2c)
+
+#define UARTSTAT_TDRE     (1 << 23)
+#define UARTSTAT_TC       (1 << 22)
+#define UARTSTAT_RDRF     (1 << 21)
+#define UARTSTAT_OR       (1 << 19)
+
+#define UARTBAUD_OSR_SHIFT (24)
+#define UARTBAUD_OSR_MASK (0x1f)
+#define UARTBAUD_SBR_MASK (0x1fff)
+#define UARTBAUD_BOTHEDGE (0x00020000)
+#define UARTBAUD_TDMAE    (0x00800000)
+#define UARTBAUD_RDMAE    (0x00200000)
+
+#define UARTCTRL_TIE      (1 << 23)
+#define UARTCTRL_TCIE     (1 << 22)
+#define UARTCTRL_RIE      (1 << 21)
+#define UARTCTRL_ILIE     (1 << 20)
+#define UARTCTRL_TE       (1 << 19)
+#define UARTCTRL_RE       (1 << 18)
+#define UARTCTRL_M        (1 << 4)
+
+#define UARTWATER_RXCNT_OFF     24
+
+#endif /* __ASM_ARM_IMX_LPUART_H */
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
-- 
2.30.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 28 06:06:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 06:06:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280150.477991 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOZAk-0003dk-SK; Mon, 28 Feb 2022 06:06:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280150.477991; Mon, 28 Feb 2022 06:06:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOZAk-0003dd-PJ; Mon, 28 Feb 2022 06:06:14 +0000
Received: by outflank-mailman (input) for mailman id 280150;
 Mon, 28 Feb 2022 06:06:13 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nOZAj-0003dT-66; Mon, 28 Feb 2022 06:06:13 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nOZAj-00060T-4s; Mon, 28 Feb 2022 06:06:13 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nOZAi-0006db-NV; Mon, 28 Feb 2022 06:06:12 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nOZAi-0003vC-Km; Mon, 28 Feb 2022 06:06:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=SSq0lZdLUeh807I+40dEr675QVc4OJrt4OzPSQDTeLQ=; b=XGmbmk15gixpVWA0eljlJw4XG8
	nUto6l7Ldtn3KOoYAf4uOey9/vxDna+E25BtS81e/YGSPqX1lI5tTMPioU+AA43BZA5GduxJjxHng
	TGBwTTHCNNM0/5Kbm9XZnP2gi3xMfGMEj1XvFz3aircIAd3jOv0Q4M1FmWMnLhnWReLs=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168249-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 168249: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=f1d1c337e7c0575da7fd248b2dd9cffc755940df
X-Osstest-Versions-That:
    ovmf=54cddc3ad4b3a317985ce5f491f9b1f31ab10dd8
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 28 Feb 2022 06:06:12 +0000

flight 168249 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168249/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 f1d1c337e7c0575da7fd248b2dd9cffc755940df
baseline version:
 ovmf                 54cddc3ad4b3a317985ce5f491f9b1f31ab10dd8

Last test of basis   168232  2022-02-25 16:10:29 Z    2 days
Testing same since   168249  2022-02-28 03:11:49 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Brijesh Singh <brijesh.singh@amd.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Jiewen Yao <jiewen.yao@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   54cddc3ad4..f1d1c337e7  f1d1c337e7c0575da7fd248b2dd9cffc755940df -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Mon Feb 28 07:13:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 07:13:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280164.478001 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOaDa-00025m-0p; Mon, 28 Feb 2022 07:13:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280164.478001; Mon, 28 Feb 2022 07:13:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOaDZ-00025f-Tr; Mon, 28 Feb 2022 07:13:13 +0000
Received: by outflank-mailman (input) for mailman id 280164;
 Mon, 28 Feb 2022 07:13:12 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2oYG=TL=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1nOaDY-00025Z-Ey
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 07:13:12 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05on20609.outbound.protection.outlook.com
 [2a01:111:f400:7e1a::609])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e247b53b-9865-11ec-8539-5f4723681683;
 Mon, 28 Feb 2022 08:13:10 +0100 (CET)
Received: from AS9PR05CA0024.eurprd05.prod.outlook.com (2603:10a6:20b:488::23)
 by DB8PR08MB5340.eurprd08.prod.outlook.com (2603:10a6:10:11c::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.25; Mon, 28 Feb
 2022 07:13:07 +0000
Received: from AM5EUR03FT019.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:488:cafe::2c) by AS9PR05CA0024.outlook.office365.com
 (2603:10a6:20b:488::23) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.26 via Frontend
 Transport; Mon, 28 Feb 2022 07:13:07 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT019.mail.protection.outlook.com (10.152.16.104) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5017.22 via Frontend Transport; Mon, 28 Feb 2022 07:13:07 +0000
Received: ("Tessian outbound 1f399c739551:v113");
 Mon, 28 Feb 2022 07:13:06 +0000
Received: from 91e919b4c17e.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 FB2FDD8D-721B-4D4E-9BAD-C138DB22849F.1; 
 Mon, 28 Feb 2022 07:12:56 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 91e919b4c17e.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 28 Feb 2022 07:12:56 +0000
Received: from PA4PR08MB6253.eurprd08.prod.outlook.com (2603:10a6:102:e4::8)
 by PR2PR08MB4889.eurprd08.prod.outlook.com (2603:10a6:101:1d::23) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.25; Mon, 28 Feb
 2022 07:12:53 +0000
Received: from PA4PR08MB6253.eurprd08.prod.outlook.com
 ([fe80::41e8:ebec:d794:38aa]) by PA4PR08MB6253.eurprd08.prod.outlook.com
 ([fe80::41e8:ebec:d794:38aa%3]) with mapi id 15.20.5017.026; Mon, 28 Feb 2022
 07:12:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e247b53b-9865-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=pp02zjIYeZalTW9b7HYAe4jh3R6FUNgkXVamR1r7uNU=;
 b=HloPZQ+Lq09a9uhZ2fKsCPipivSDmhpLU94NljlrmZ8eLcKzjBBf3qvaLTVmEvmG1A3ieFJ79zivahjnFv07yYKn+/zNTmX+ZNmSlzuEy86F5OxhNRjoazC2BS3es5/AY2t0LJr9MnZynAkXKNbqQfSpz4gsnohPt2/TqM2Cuvw=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cZ/n/xZhpBHrgQQEhHMt406gpgfun/frvPDZcvN1TFEX1kkLYQkrIP1uDhl+dw/GdEQjPBTu7Y/IUDoB9Rxa9S3VcfvkUWh67XNAEjJD4sdVf8Ye43qonuyPv+UuP6hbnbpT4fSwP/lYmyElES2chBHpNTyNBlGbIBBOMT+ITdEdiY1+O76QEC8KHImGLra1ZamG3Xk08fyF9yQkgAm4/tYN6RtmRPrxSxxQ0XcbqywyQ+Ywa8ip0TPpwEPFJbuWinHUE7NNl7AwqqEnZbnVC+lOXAos3O8fwxQMAgg73hgGo1Dh/Iqr/7hHP2IMxrii3+Me85eWieZpsdnKTbpaow==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=pp02zjIYeZalTW9b7HYAe4jh3R6FUNgkXVamR1r7uNU=;
 b=Ep3PTx6/gTBJLyqRD/UFupW9jLzufB04lx+RqA2q1IfUbzpdCovAWflSk+NLd2AJXzRwcCMwXb5a+7kjn/9EPR+n4+l3jI1+Lvtj7IyWXFvmANO3UYrRMocg4+FTGyhqYxh6rgzINTFhX15p2ZWFWVqcK1ena/P0fvo+1g5D955IKG2vg5jj22eilQBf4x51+Cvawbpgk5nH9jAUFiDJnquFuzQ/OzqYRsx0odcWbDrVATEOygGunyigUAHeCImfnSjwvF5B75lQVVKy7kSDELKeLu2G7ZSkm0AlMukKDgVNEf8R2w2bvDpdQEANiBRxOWo2lJ8XjOi/PF3yAtAbxg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=pp02zjIYeZalTW9b7HYAe4jh3R6FUNgkXVamR1r7uNU=;
 b=HloPZQ+Lq09a9uhZ2fKsCPipivSDmhpLU94NljlrmZ8eLcKzjBBf3qvaLTVmEvmG1A3ieFJ79zivahjnFv07yYKn+/zNTmX+ZNmSlzuEy86F5OxhNRjoazC2BS3es5/AY2t0LJr9MnZynAkXKNbqQfSpz4gsnohPt2/TqM2Cuvw=
From: Henry Wang <Henry.Wang@arm.com>
To: Julien Grall <julien@xen.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "sstabellini@kernel.org"
	<sstabellini@kernel.org>
CC: Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>,
	Penny Zheng <Penny.Zheng@arm.com>
Subject: RE: [RFC PATCH 0/2] Introduce reserved Xenheap
Thread-Topic: [RFC PATCH 0/2] Introduce reserved Xenheap
Thread-Index: AQHYKR4hoR5C+vQhgEqBFutamuKD06yktMKAgAPYnoA=
Date: Mon, 28 Feb 2022 07:12:52 +0000
Message-ID:
 <PA4PR08MB625324910ED4D40383191F9D92019@PA4PR08MB6253.eurprd08.prod.outlook.com>
References: <20220224013023.50920-1-Henry.Wang@arm.com>
 <6269ec3d-039e-d68f-771d-c5e088631410@xen.org>
In-Reply-To: <6269ec3d-039e-d68f-771d-c5e088631410@xen.org>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 7B9FFCA5BD783A42897B93CD3A401033.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: db73d7bc-cc3b-4f61-8ff7-08d9fa89c4ec
x-ms-traffictypediagnostic:
	PR2PR08MB4889:EE_|AM5EUR03FT019:EE_|DB8PR08MB5340:EE_
X-Microsoft-Antispam-PRVS:
	<DB8PR08MB5340715878810DB0821D408092019@DB8PR08MB5340.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 nYE7MMucERryofHgdYl29j5L93PU8f4xyv1icNRbYDVcuFhrSqqsLs8/kYYCMLA8Exm48Kfl+RomcEDFeYcJLaRr46QO5G9WR5BhcEWehsB8ZoGv9hM4z0ErpbcQfLJiFp6PAVVTgCBHwVRqFRjCR7VS4Tj7JdphTw1znZwJ0BcsFazSjMebLA5UHcKO0aLd/K+rxjzs0TJHmWffcX3C3wKCjGsEZ+xwrl04K51KKMkTJH+n6w+o4hPk+k9SbuNvP6y+RR7wpFqUARiSxEaSwrlJd0Vil1XEnXWi016P6bRzWN2TIKCZ7jzzXnXy9eDUcvBp6Owbjvu5e1q9RsUVwctPYkO7urs6OMOcTZRkwGO0Km9j4YxI1A3gmW0+Q2G4qTZBGyhDjIjPunDxJhFKXLuyZGeZkzDfJRNsOzzH9uSh/UGaCnqpungYjs/lDx3M/YQDL6VtuQ8Np8DWZ/RUw9oHpyvwkGx949OfRfh5hjotckKdhCpxR5fBjGmpGKiDCvYkbmA87xpz+WnIA8ExgjFUdcQ5kFFZRCcKe22s1nO2BYV4kpDtIa0ISCdrrL/cpZJFfIh6V+Fqnpx3A4UPvJaS523OlrKAVwBfvJ2HMCaP1BNHkQOulDo6vA7H7cWJHTomhUz1fIfm752aC1I7b4aG286vHpuhS8w/1wUcieUWdYc6JfIXG+7CmCNHPUu3EZDJWz6W9DnA3xPNCJiMbQ==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR08MB6253.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(76116006)(66556008)(55016003)(8936002)(52536014)(5660300002)(33656002)(66476007)(8676002)(66946007)(64756008)(66446008)(4326008)(316002)(2906002)(110136005)(54906003)(508600001)(7696005)(186003)(26005)(53546011)(6506007)(83380400001)(9686003)(86362001)(38100700002)(38070700005)(122000001)(71200400001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR2PR08MB4889
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT019.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	180ab702-52f6-43cf-770a-08d9fa89bc85
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	gM5d//7sKcJ+0RJWivEFMR4eJFEgxYJgMmHxkS9EuBsgq58yZQjr2NJ8TixunutWHYoegabRbo7DHrsAqAN6GTowcfC1lhVuSvIghIXjy0cb8yTEQ0jvQAYPRxqFSFISdfkMh0+gau8Kc9l2PjImivza4cjze4/AWCBXhpUut/24fF4nxxWWZlw/ZEhnSsCV8b1UEk8XgJu81zEJrra5ZNczxhU04krF9t3hrVWCeNHzAby1HBS9DiQyV7mLHNnq69C3kZzVt+nm5qoyNFlEq0YUV9lSsfSQf4Kmho8095r0Sl/g5GT9y48E8HLGB5W6xaKdyET7X/l0AzG4jYb5hhXqETziISRf6UV+g5tXyhGc6Fac5nHRtszi+6SWo1ng5DVTcwp3QDhwOXPi/Qfgvk6f/Zr6mVCCn/M8OyFrLF+dPBa4XK+s5bVwAJ3UnEEisKbC95qWUUZEQb+eDXKt7+/l/v4E5eZoqeXEGsQlEhuHBEDY+rHvXNzUrMb8FRKFlGySj0hbdUALDHGZaavchnp3EQlIxU36LKuYdHqeTPP9mw5tcISYrn9R0T0v7JngDhLBaRMC/AIlgbCi1yAUit+dCZc1xzMwYc3OXZcPMLYgmXzBE7+85vopgG2xf86eM84X2G/Yrrzyx7roJsfRxVhWU+XIS5mIdR6AkZwffqmLEn6LmhfllPAVJDtTpUkM
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(40460700003)(83380400001)(54906003)(53546011)(81166007)(36860700001)(508600001)(52536014)(316002)(8936002)(356005)(86362001)(70206006)(26005)(186003)(4326008)(70586007)(2906002)(9686003)(47076005)(6506007)(110136005)(336012)(5660300002)(33656002)(82310400004)(55016003)(8676002)(7696005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2022 07:13:07.0468
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: db73d7bc-cc3b-4f61-8ff7-08d9fa89c4ec
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT019.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5340

SGkgSnVsaWVuLA0KDQpUaGFua3MgdmVyeSBtdWNoIGZvciB5b3VyIHRpbWUgcmVhZGluZyB0aGUg
c2VyaWVzIGFuZCB5b3VyIGZlZWRiYWNrLiBQbGVhc2UNCmZpbmQgdGhlIGlubGluZSByZXBseSBi
ZWxvdy4NCg0KPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBKdWxpZW4gR3Jh
bGwgPGp1bGllbkB4ZW4ub3JnPg0KPiBTZW50OiBTYXR1cmRheSwgRmVicnVhcnkgMjYsIDIwMjIg
NDowOSBBTQ0KPiBUbzogSGVucnkgV2FuZyA8SGVucnkuV2FuZ0Bhcm0uY29tPjsgeGVuLWRldmVs
QGxpc3RzLnhlbnByb2plY3Qub3JnOw0KPiBzc3RhYmVsbGluaUBrZXJuZWwub3JnDQo+IENjOiBC
ZXJ0cmFuZCBNYXJxdWlzIDxCZXJ0cmFuZC5NYXJxdWlzQGFybS5jb20+OyBXZWkgQ2hlbg0KPiA8
V2VpLkNoZW5AYXJtLmNvbT47IFBlbm55IFpoZW5nIDxQZW5ueS5aaGVuZ0Bhcm0uY29tPg0KPiBT
dWJqZWN0OiBSZTogW1JGQyBQQVRDSCAwLzJdIEludHJvZHVjZSByZXNlcnZlZCBYZW5oZWFwDQo+
IA0KPiBIaSBIZW5yeSwNCj4gDQo+IE9uIDI0LzAyLzIwMjIgMDE6MzAsIEhlbnJ5IFdhbmcgd3Jv
dGU6DQo+ID4gVGhlIHJlc2VydmVkIFhlbmhlYXAsIG9yIHN0YXRpY2FsbHkgY29uZmlndXJlZCBY
ZW5oZWFwLCByZWZlcnMgdG8gcGFydHMNCj4gPiBvZiBSQU0gcmVzZXJ2ZWQgaW4gdGhlIGJlZ2lu
bmluZyBmb3IgWGVuaGVhcC4gTGlrZSB0aGUgc3RhdGljIG1lbW9yeQ0KPiA+IGFsbG9jYXRpb24s
IHN1Y2ggcmVzZXJ2ZWQgWGVuaGVhcCByZWdpb25zIGFyZSByZXNlcnZlZCBieSBjb25maWd1cmF0
aW9uDQo+ID4gaW4gdGhlIGRldmljZSB0cmVlIHVzaW5nIHBoeXNpY2FsIGFkZHJlc3MgcmFuZ2Vz
Lg0KPiANCj4gSW4gWGVuLCB3ZSBoYXZlIHRoZSBjb25jZXB0IG9mIGRvbWhlYXAgYW5kIHhlbmhl
YXAuIEZvciBBcm02NCBhbmQgeDg2DQo+IHRoZXkgd291bGQgYmUgdGhlIHNhbWUuIEJ1dCBmb3Ig
QXJtMzIsIHRoZXkgd291bGQgYmUgZGlmZmVyZW50OiB4ZW5oZWFwDQo+IGlzIGFsd2F5cyBtYXBw
ZWQgd2hlcmVhcyBkb21oZWFwIGlzIHNlcGFyYXRlLg0KPiANCj4gU2tpbW1pbmcgdGhyb3VnaCB0
aGUgc2VyaWVzLCBJIHRoaW5rIHlvdSB3YW50IHRvIHVzZSB0aGUgcmVnaW9uIGZvciBib3RoDQo+
IGRvbWhlYXAgYW5kIHhlbmhlYXAuIElzIHRoYXQgY29ycmVjdD8NCg0KWWVzIEkgdGhpbmsgdGhh
dCB3b3VsZCBiZSBjb3JyZWN0LCBmb3IgQXJtMzIsIGluc3RlYWQgb2YgdXNpbmcgdGhlIGZ1bGwN
CmByYW1fcGFnZXNgIGFzIHRoZSBpbml0aWFsIHZhbHVlIG9mIGBoZWFwX3BhZ2VzYCwgd2Ugd2Fu
dCB0byB1c2UgdGhlDQpyZWdpb24gc3BlY2lmaWVkIGluIHRoZSBkZXZpY2UgdHJlZS4gQnV0IHdl
IGFyZSBjb25mdXNlZCBpZiB0aGlzIGlzIHRoZQ0KY29ycmVjdCAob3IgcHJlZmVycmVkKSB3YXkg
Zm9yIEFybTMyLCBzbyBpbiB0aGlzIHNlcmllcyB3ZSBvbmx5DQppbXBsZW1lbnRlZCB0aGUgcmVz
ZXJ2ZWQgaGVhcCBmb3IgQXJtNjQuDQoNCkNvdWxkIHlvdSBwbGVhc2Ugc2hhcmUgeW91ciBvcGlu
aW9uIG9uIHRoaXM/IFRoYW5rcyENCg0KPiANCj4gRnVydGhlbW9yZSwgbm93IHRoYXQgd2UgYXJl
IGludHJvZHVjaW5nIG1vcmUgc3RhdGljIHJlZ2lvbiwgaXQgd2lsbCBnZXQNCj4gZWFzaWVyIHRv
IG92ZXJsYXAgdGhlIHJlZ2lvbnMgYnkgbWlzdGFrZXMuIEkgdGhpbmsgd2Ugd2FudCB0byBoYXZl
IHNvbWUNCj4gbG9naWMgaW4gWGVuIChvciBvdXRzaWRlKSB0byBlbnN1cmUgdGhhdCBub25lIG9m
IHRoZW0gb3ZlcmxhcHMuIERvIHlvdQ0KPiBoYXZlIGFueSBwbGFuIGZvciB0aGF0Pw0KDQpUb3Rh
bGx5IGFncmVlIHdpdGggdGhpcyBpZGVhLCBidXQgYmVmb3JlIHdlIGFjdHVhbGx5IGltcGxlbWVu
dCB0aGUgY29kZSwNCndlIHdvdWxkIGxpa2UgdG8gZmlyc3RseSBzaGFyZSBvdXIgdGhvdWdodHMg
b24gdGhpczogT25lIG9wdGlvbiBjb3VsZCBiZSB0bw0KYWRkIGRhdGEgc3RydWN0dXJlcyB0byBu
b3RlcyBkb3duIHRoZXNlIHN0YXRpYyBtZW1vcnkgcmVnaW9ucyB3aGVuIHRoZQ0KZGV2aWNlIHRy
ZWUgaXMgcGFyc2VkLCBhbmQgdGhlbiB3ZSBjYW4gY2hlY2sgaWYgdGhleSBhcmUgb3ZlcmxhcHBl
ZC4gT3Zlcg0KdGhlIGxvbmcgdGVybSAoYW5kIHRoaXMgbG9uZyB0ZXJtIG9wdGlvbiBpcyBjdXJy
ZW50bHkgbm90IGluIG91ciBwbGFuKSwNCm1heWJlIHdlIGNhbiBhZGQgc29tZXRoaW5nIGluIHRo
ZSBYZW4gdG9vbHN0YWNrIGZvciB0aGlzIHVzYWdlPw0KDQpBbHNvLCBJIGFtIHdvbmRlcmluZyBp
ZiB0aGUgb3ZlcmxhcHBpbmcgY2hlY2sgbG9naWMgc2hvdWxkIGJlIGludHJvZHVjZWQNCmluIHRo
aXMgc2VyaWVzLiBXRFlUPw0KDQo+IA0KPiA+DQo+ID4gVGhpcyBmZWF0dXJlIGlzIHVzZWZ1bCB0
byBydW4gWGVuIG9uIEFybSBNUFUgc3lzdGVtcywgd2hlcmUgb25seSBhDQo+ID4gZmluaXRlIG51
bWJlciBvZiBtZW1vcnkgcHJvdGVjdGlvbiByZWdpb25zIGFyZSBhdmFpbGFibGUuIFRoZSBsaW1p
dGVkDQo+ID4gbnVtYmVyIG9mIHByb3RlY3Rpb24gcmVnaW9ucyBwbGFjZXMgcmVxdWlyZW1lbnQg
b24gcGxhbm5pbmcgdGhlIHVzZSBvZg0KPiA+IE1QVSBwcm90ZWN0aW9uIHJlZ2lvbnMgYW5kIG9u
ZSBvciBtb3JlIE1QVSBwcm90ZWN0aW9uIHJlZ2lvbnMgbmVlZHMgdG8NCj4gPiBiZSByZXNlcnZl
ZCBvbmx5IGZvciBYZW5oZWFwLg0KPiA+DQo+ID4gVGhlcmVmb3JlLCB0aGlzIHBhdGNoIHNlcmll
cyBpcyBzZW50IGFzIFJGQyBmb3IgY29tbWVudHMgZnJvbSB0aGUNCj4gPiBjb21tdW5pdHkuIFRo
ZSBmaXJzdCBwYXRjaCBpbnRyb2R1Y2VzIHRoZSByZXNlcnZlZCBYZW5oZWFwIGFuZCB0aGUNCj4g
PiBkZXZpY2UgdHJlZSBwcm9jZXNzaW5nIGNvZGUuIFRoZSBzZWNvbmQgcGF0Y2ggYWRkcyB0aGUg
aW1wbGVtZW50YXRpb24gb2YNCj4gPiB0aGUgcmVzZXJ2ZWQgWGVuaGVhcCBwYWdlcyBoYW5kbGlu
ZyBpbiBib290IGFuZCBoZWFwIGFsbG9jYXRvciBvbiBBcm02NC4NCj4gPg0KPiA+IEhlbnJ5IFdh
bmcgKDIpOg0KPiA+ICAgIGRvY3MsIHhlbi9hcm06IEludHJvZHVjZSByZXNlcnZlZCBYZW5oZWFw
IG1lbW9yeQ0KPiA+ICAgIHhlbi9hcm06IEhhbmRsZSByZXNlcnZlZCBYZW5oZWFwIHBhZ2VzIGlu
IGJvb3QvaGVhcCBhbGxvY2F0b3INCj4gPg0KPiA+ICAgZG9jcy9taXNjL2FybS9kZXZpY2UtdHJl
ZS9ib290aW5nLnR4dCB8IDQzICsrKysrKysrKysrKysrKysrKysrKysNCj4gPiAgIHhlbi9hcmNo
L2FybS9ib290ZmR0LmMgICAgICAgICAgICAgICAgfCA1MiArKysrKysrKysrKysrKysrKysrKyst
LS0tLS0NCj4gPiAgIHhlbi9hcmNoL2FybS9pbmNsdWRlL2FzbS9zZXR1cC5oICAgICAgfCAgMyAr
Kw0KPiA+ICAgeGVuL2FyY2gvYXJtL3NldHVwLmMgICAgICAgICAgICAgICAgICB8IDUyICsrKysr
KysrKysrKysrKysrKystLS0tLS0tLQ0KPiA+ICAgNCBmaWxlcyBjaGFuZ2VkLCAxMjUgaW5zZXJ0
aW9ucygrKSwgMjUgZGVsZXRpb25zKC0pDQo+ID4NCj4gDQo+IC0tDQo+IEp1bGllbiBHcmFsbA0K
DQpLaW5kIHJlZ2FyZHMsDQoNCkhlbnJ5DQo=


From xen-devel-bounces@lists.xenproject.org Mon Feb 28 07:32:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 07:32:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280173.478013 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOaWF-0004Wz-NB; Mon, 28 Feb 2022 07:32:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280173.478013; Mon, 28 Feb 2022 07:32:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOaWF-0004Ws-K3; Mon, 28 Feb 2022 07:32:31 +0000
Received: by outflank-mailman (input) for mailman id 280173;
 Mon, 28 Feb 2022 07:32:30 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=A4HT=TL=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nOaWE-0004Wm-6a
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 07:32:30 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 94b69ebb-9868-11ec-8eba-a37418f5ba1a;
 Mon, 28 Feb 2022 08:32:28 +0100 (CET)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2057.outbound.protection.outlook.com [104.47.6.57]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-5-3QOJmHaINY2B7vuDJZEA-A-1; Mon, 28 Feb 2022 08:32:26 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AS8PR04MB8897.eurprd04.prod.outlook.com (2603:10a6:20b:42c::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.25; Mon, 28 Feb
 2022 07:32:24 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.026; Mon, 28 Feb 2022
 07:32:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 94b69ebb-9868-11ec-8eba-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1646033548;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=qIEe3hY3fV9EBs6DUgYbFBLUC7pe1lAdEmYvL22XwHc=;
	b=BkpkeavWgjxtH/Ow/XuPunPdr/VF5CqkVotS8CZmbvhHCagvidozOl7jbJAVv2AtOungwf
	07aDrr4eMb3aB4rOICnu79HXFszzs1xZ3t3YP6DY3e45lkkjBJCfv74LwKhFMlJkYOneCg
	IScjuTd38BpvDo47vqpbeS/bMt16EJk=
X-MC-Unique: 3QOJmHaINY2B7vuDJZEA-A-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Dtb8vd83m0CsJ9NguGaxRxZ0HPVozU2n7Qi/EYXNRwDq42WEGzjvhsZsj9gPWTkDJlSkhugiDdEFDssEWeGjkHj45CqdSG5JmQmmHq+FqqV/oNtBKCb8baLkM+BJ9UoFDb9FnaZMkFKHfcJRuZFtWhZjt+xGPndhr2j1siyQ8hR1Yqw6hxzdHJHppUnviw3cdZ38q5iFfVjyZCYRbBzqGEmaAcDtLtkMdb3R+1fvrAPEXoykVqn6OR79pBbUFkMUPwa1eBXf76/Tpo/B1kPOzdBsTIURGeZ2aCLMQTqkAk1CaaJuBviJbYPQJilikk0u5hQWAwQbwbNQq+/pUmhaCw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=qIEe3hY3fV9EBs6DUgYbFBLUC7pe1lAdEmYvL22XwHc=;
 b=Mz25tU4SR7d9rGQHagWY/kpn1ekz+ZvIycqXfzs1Vbe0yfas/01yeX/WWlX1z4ITUu6bhc/ww1RHpTZyxL4RZk+2ev76MqkFIHdlSkZQgEaQ1YgBp6nhgW5RiOVcxd6b+jALzXyURdLMnxoKXUEPc1IoBIEBYt7JiFBUbVQ/UbzmkYQhquIOQDyrjlhVpDR8u+XTqk6LoM+/+uH99b4iMe7PhM2M8qmAas3doEivj4tyCZP5NpfPSyKvz22RB0Ioq2npWXf/Mx9cZXbRiOD44O1lBo/3DB39Nfc8hHJeOZ+jG7fzrRwKYZbxYr0GneeBdd03EnkC1cuylCV1dQBWSQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <de431523-ad71-1cb6-a28d-07418886ee23@suse.com>
Date: Mon, 28 Feb 2022 08:32:26 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v3 1/2] xen+tools: Report Interrupt Controller
 Virtualization capabilities on x86
Content-Language: en-US
To: Jane Malalane <Jane.Malalane@citrix.com>
Cc: Wei Liu <wl@xen.org>, Anthony Perard <anthony.perard@citrix.com>,
 Juergen Gross <jgross@suse.com>, Andrew Cooper <Andrew.Cooper3@citrix.com>,
 George Dunlap <George.Dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Jun Nakajima <jun.nakajima@intel.com>, Kevin Tian <kevin.tian@intel.com>,
 Roger Pau Monne <roger.pau@citrix.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20220218172943.12182-1-jane.malalane@citrix.com>
 <20220218172943.12182-2-jane.malalane@citrix.com>
 <0a31970c-c0f8-c995-ce04-67523a4a830a@suse.com>
 <22ae35a0-9df8-9357-4b44-2f00586144fc@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <22ae35a0-9df8-9357-4b44-2f00586144fc@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR3P281CA0070.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:4b::22) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9accf07e-ec40-42cc-67dd-08d9fa8c7690
X-MS-TrafficTypeDiagnostic: AS8PR04MB8897:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<AS8PR04MB88977AA5E84AD1EF5D853490B3019@AS8PR04MB8897.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	aDKcpVdl5CL6aqrooO+1CuDYztbVvM/8b1LJYFW5dJKdtLG3SFJ+07C2bMbBShM5qblCLvX5IR88Q2Q58YIGc0fiFUYkMTy8dp4fMj36A/P9LYVh9uV/s6eaEBusmJY7gHNR3KtfIMUoilASqTk5ylea3HegliGUgXF8W7i7ITW0Bce2pDjLMMEa2solecSBrvfCWpFVjLBJIBxMztkA5NRIP4fcH6FNMgza4fWln+3xWrddFMdvzCnZC8FecYJw8/dERzNWhSuhGJ6rLHsZIAFrzlfX4zQB07Pc6PliB+0NaipbiOHsHN/itDBrZEsF2CZaH+dtttcH5ja/1Z/D099E6JW808ZQOmhd7tNyBtHAiXbHbXGCWrIty6qFuX72AO5HzZDLJuFGKWpegEtKOU/1BN7O02VqftKKnAzkME6nd18+XWzxS18mbgnXwHQx66xx7F4+5wLQ4lUro0CEqWUqZxkj5k/ecfUaBTCeUyPtESmLwQiD2yCM2tmwqHPRHRzUIObSijcMwHT7lA0KU++/Pm4GoQTtKumgq88hUIeu7EMMtUHN4aXjHunoSxSxy17mXjr+TThL9HnCHXLG7tcT0nQtS9KMbLAdlQDb8J+b13n4HzoeZkyT+xaUshHxPUUt0ZOdwaN2ifgarQfrbqB73ek3xd3xjQTzoF5rTkvVrOVUqIv49PzyZsYQQ7ZcsWC95N9gSkQK8E/EiN7svUzS9VjcuABBbU5Jb7Utufr7d4vmgoYhIepIwfYRt77u
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(26005)(186003)(38100700002)(31696002)(66556008)(86362001)(8676002)(66476007)(508600001)(31686004)(2906002)(66946007)(36756003)(6486002)(316002)(6916009)(54906003)(4326008)(6512007)(7416002)(5660300002)(2616005)(8936002)(53546011)(6506007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UGtUd3hQNEVGSE9OTVFKS1BiaERHbzhXUE1XSEgvaDdtM3F5Y0ZISkZnUVJh?=
 =?utf-8?B?SEtNblJqREVjQXM2M2ZpUFZDMGNVV1hzbVlCd2xDSnhVTGxYVzFZZ3hUSjRZ?=
 =?utf-8?B?dUZzdy9QNi9peDd6KzA1aCtuSXJkVjhyZ1FxY3p2dUdnWnRhM3ZuZ25URVRF?=
 =?utf-8?B?RXoxNHAydldqMEtjY0ZoS2NnRytuU3EweVE2OUx1cUZjMXlhODdQT2piRG4x?=
 =?utf-8?B?OC9aV251ZHkxdDdUV0VyUDh2M1VmOStGMVV4V1RxbEZQclBCcVpnTUtiNEpQ?=
 =?utf-8?B?RVcxYVB6YktmV3U1Si9rbXkxRlRJS0JVZmhUWVpaRFpPNEJ1ZTM4NEtiRjNF?=
 =?utf-8?B?WU1tdU1PYm02WXJxL1NsalVibjRZMHlTY04xaUM0OUdFRVY3UDg0Z0ZiS3hS?=
 =?utf-8?B?R0FPQUdkOTdUVlg1cVZKQ3NjNkJRZ2pTQUY4K01kcW54Q2x0UUltczhWSU5B?=
 =?utf-8?B?YWQ2S3o5Y1pKdGQyNjhjdUpnd2txUzRhaExsZ2tEbUd5emlkejhrVUtCM20x?=
 =?utf-8?B?aHBJeHVsbWpSR0x2UVBMZTRZRDZ4ZGZQUmxxaDkydFdHUzlKOG9MalNjNVdG?=
 =?utf-8?B?Vkt1VHJpZVFldVZJOG9zNUNLbWw0bGRQYm9ONTJXWks5YUp5T0FqaW9sY2t3?=
 =?utf-8?B?UTlGTFc4SUJXQktxTDMxQ09yRzRlcEUwQ1d3TnRUeHFrQVFTc1NNaUdhdkRP?=
 =?utf-8?B?aklBU0FHb3YvZnZCWkRscEViK1NCWmNhaTZEM1NuN1UwbDZDaHFUS012R2hY?=
 =?utf-8?B?blBLYzdBT2ltZzJ4bVJ2Z0tRYWkycVhEaXJOZ3lXam1xRmRweGFFanJqTjdp?=
 =?utf-8?B?QVJyVkg2M0tLZWtMeVhHN1BWdFMrVFluVFgwbGdwcVNEQnBqRmV1R2dXYngr?=
 =?utf-8?B?VkxReEFTVzdyc2UzcXladjF5UXJmSVFjeG9mSy8vYXJQYXNYM2dTY3VsNzBk?=
 =?utf-8?B?eElUMXA3Z0tjUVBCV3RvdEFWMkI1bWIrRHVub0ZPSlNpN3FXTVgxbGpRMTNE?=
 =?utf-8?B?dXpnZnFDT2FJRFBqbjRLbFlaTUMvclNkYzJnbWcvaUNySFpKR0IvQk5nRVJH?=
 =?utf-8?B?dGpOZ21pVk9zTXM0dG9iTnIxNGVWY1dqODNLekx2cFBOcERISE5JTERZaFNu?=
 =?utf-8?B?QnJDdXdVNWwxQ3dpZnoxbjg1ZHdSV0xxYm1RUFE4V2UvMlA4VUkzVHZPeWJQ?=
 =?utf-8?B?U2creVZucmEyYjJ6aDFldTNrOENwS0p4NXZKaTdIaGEvWGVwWGZQM3BqLzVS?=
 =?utf-8?B?QUZZSXR1Z3lNZHM5bHdoQjBLbVBBc3cycVRETFdib3JJTC9EQXhWT1BJdVps?=
 =?utf-8?B?cnlsVE1ZbStZZkZqdnE3bnZOd04zV2poeXdFb0FaU2Z6M3J1aU9kUU1rNHJH?=
 =?utf-8?B?dWcyUEZ5WHFmbFEyekJjd2prdDczbUY5UXFqN2x5SnBxVVU2dzF6ZkRzUXpD?=
 =?utf-8?B?b2xlcDZpWDlQd2htWHNsa01EdHNWYWZ4SFM2RGp6MDhlQTRuQVhZRm9JMzVM?=
 =?utf-8?B?RjU1Sll3OHhGWE5lM1hyYUlLY2o5Q0QxZ2Y3dzg1YjFISkM0MEkrN2lCclhF?=
 =?utf-8?B?QUVzTU53YmNmY3dkek03SzlLTDZDOS9WQXJrTkF2b3YydThwbFd1anZMb3h6?=
 =?utf-8?B?OWZFYnhsNDEweENOWFVocFc4Tjc4WmovYUczbGxaVktTTVYrVkRraUNENDVE?=
 =?utf-8?B?UFJzbFpDamNyNjYzK2RKc2xzN0dIMkJqRUphMmdDUktBS3JoMjhrcS92UHJO?=
 =?utf-8?B?T1N6Q2F0SzVKRThKZEM1MUpMTGx5KzVYaVVoNDVabU8vdDcyVzlZaS84NDZh?=
 =?utf-8?B?T0N4RFdYWnk5Q2hxNGRyK2NOcEZ3VFRNWXdOSlFHQk0vUkUxK05EdEViSVRF?=
 =?utf-8?B?akQ1UGx6aHZjbUVkVjVZS05RZXNCSDUxbzZkMTJPekxjNitMeExKVUlXSzNB?=
 =?utf-8?B?V25nMmsvTWJJWnY4NlUvbUhOOXlCZ2JtUEgxWUFzTzRCUzBUSkN3OFEwblUv?=
 =?utf-8?B?T0xUc3ZkcXYvcU83YlhndDlpUTExb1g3YVgybzhlQ2E5MTk0OGdDeXdDc2JC?=
 =?utf-8?B?Vm0wTXAxaTkydjNmbGpGOVdPdXNEVXBWYnFEWVhSdWFhWFg4TnY1dE1XOHdG?=
 =?utf-8?B?MkhjZ1I3NDlRVVlwcmU1M2VwaDVJWW0xMzRoaVlMb3dKOXFRaGRaMEkvUDlI?=
 =?utf-8?Q?e7iJVJfmdMJsafRFejUkdq4=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9accf07e-ec40-42cc-67dd-08d9fa8c7690
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2022 07:32:24.2895
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lGrc5UWcmB0lzcls+Ey1dnmPI5PH4htMUE+aNkTM9fonj5N+E+JTCk876/HukS2TRu/JZBruvwxGd71WEmZYKg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8897

On 25.02.2022 17:02, Jane Malalane wrote:
> On 24/02/2022 14:08, Jan Beulich wrote:
>> On 18.02.2022 18:29, Jane Malalane wrote:
>>> Add XEN_SYSCTL_PHYSCAP_ARCH_ASSISTED_xapic and
>>> XEN_SYSCTL_PHYSCAP_ARCH_ASSISTED_x2apic to report accelerated xapic
>>> and x2apic, on x86 hardware.
>>> No such features are currently implemented on AMD hardware.
>>>
>>> For that purpose, also add an arch-specific "capabilities" parameter
>>> to struct xen_sysctl_physinfo.
>>>
>>> Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
>>> Signed-off-by: Jane Malalane <jane.malalane@citrix.com>
>>> ---
>>> v3:
>>>   * Define XEN_SYSCTL_PHYSCAP_ARCH_MAX for ABI checking and actually
>>>     set arch_capbilities, via a call to c_bitmap_to_ocaml_list()
>>>   * Have assisted_x2apic_available only depend on
>>>     cpu_has_vmx_virtualize_x2apic_mode
>>
>> I understand this was the result from previous discussion, but this
>> needs justifying in the description. Not the least because it differs
>> from when XEN_HVM_CPUID_X2APIC_VIRT would be set as well as from what
>> vmx_vlapic_msr_changed() does. The difference between those two is
>> probably intended (judging from a comment there), but the further
>> difference to what you add isn't obvious.
> 
> Okay, I will make that explicit.
> 
>> Which raises another thought: If that hypervisor leaf was part of the
>> HVM feature set, the tool stack could be able to obtain the wanted
>> information without altering sysctl (assuming the conditions to set
>> the respective bits were the same). And I would view it as generally
>> reasonable for there to be a way for tool stacks to know what
>> hypervisor leaves guests are going to get to see (at the maximum and
>> by default).
> 
> Like the "cpuid" xtf test allows us to?

I don't think I understand the question. That xtf test is concerned
about checking the CPUID output it gets to see itself. It doesn't care
about what other guests might get to see, nor the maximum and default.

> Makes sense to me. I'm happy to take that up after.

"After" what?

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 28 07:36:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 07:36:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280180.478024 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOaZj-0005B7-7d; Mon, 28 Feb 2022 07:36:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280180.478024; Mon, 28 Feb 2022 07:36:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOaZj-0005B0-41; Mon, 28 Feb 2022 07:36:07 +0000
Received: by outflank-mailman (input) for mailman id 280180;
 Mon, 28 Feb 2022 07:36:06 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=A4HT=TL=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nOaZi-0005Au-36
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 07:36:06 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 14a9ac3c-9869-11ec-8eba-a37418f5ba1a;
 Mon, 28 Feb 2022 08:36:03 +0100 (CET)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2057.outbound.protection.outlook.com [104.47.6.57]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-10-27u34WfMPP-nNFKI0Jy9sw-1; Mon, 28 Feb 2022 08:36:01 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by HE1PR0402MB3500.eurprd04.prod.outlook.com (2603:10a6:7:87::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.25; Mon, 28 Feb
 2022 07:35:58 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.026; Mon, 28 Feb 2022
 07:35:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 14a9ac3c-9869-11ec-8eba-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1646033763;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=7L+4fGJdLSsPnTKFR1c8paHCpzUNNRpMEQoSnfZBlUQ=;
	b=P25d5xb93z3OQP4n/Q1hUTHHvWrvmonNFKqu42kEioq8mc1B0tItAOgyHvlAVLSAJdlUGP
	u2RiMHdcIpeeq4WNI8zSDfVnWLWdNYMgmV3fbJ14Bvc+ljI9c9m2JmjbgiBklJLw9D8zAM
	5S0CSz9d+7vqmB8m2AwxVsKrmV/iFkI=
X-MC-Unique: 27u34WfMPP-nNFKI0Jy9sw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=MErZwVDWS/FsMxcpc1QOfGKEZrErCBexjSOVbW1iPvOiqFoEkYXMoMx7bKN1y7iqR0qbJDH625s1EZOYNo9nrNLwdGKXZX28o8VpORPQUN8RNvY2RyFKlCERuQSwRZ3wUel9EbPqcEcJDh4XOUkPTwrVWNyc1XSplnfmyaxPiRtXkZoH0ss+hnq6dtDUgF0TNWEcFUinZ6izurJA8ZTdU9gpHazKMVQRmQuyB7v0aVAwUHV3iksSlvKRrkwwNlJeecXIjuPMOL6Q45UlqNu8IGgJBOTNbfkalhpjGil3AcszCDmrNYmK/SpjYpsURyg5s+6SX8sp92edG6Gyle8Zlg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=IQl0y/cY6I+hCBgQO+PVjS03gmBWQks8OM1Zvf8d32Y=;
 b=oUECcyXi2XhguxQh4uhDef/xhaamB4rLa5w6Y7inZ25WyofwlPpiCiNlH6swQH26DhPfSrxZkXUo06LZwDws3kIb6m2KVQEGX64r2kahk96vFwPWfp7pB65QdS8zG1BxwuNRam/bSBCRgnJpBBmBIGtM5IhTJ5Ia6KiyOxjRwttgAukeg5PHkoqAtUOCsPDAorljvfCYFoPy8IsbC0q2gUha8aeJPDVccYwHgaOOka5maLs36WLBlcwq2rVxCXBk+FokoTJP1SS/fupTTt1+qg3YdO3J+ITTDz745gncvFlZuPfqvWk+k8QNKdW7bCfU5ocjIsnINMRJbkF9PnQyOg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <2e1dcfb8-20ae-26b2-427d-9c19bd8c8add@suse.com>
Date: Mon, 28 Feb 2022 08:36:00 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: x86/vmx: Don't spuriously crash the domain when INIT is received
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
CC: Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>,
 Jun Nakajima <jun.nakajima@intel.com>, Kevin Tian <kevin.tian@intel.com>,
 Thiner Logoer <logoerthiner1@163.com>,
 =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20220224194853.17774-1-andrew.cooper3@citrix.com>
 <20220224194853.17774-3-andrew.cooper3@citrix.com>
 <12d8b90b-15b0-c094-71e5-35cfdbfe72b4@suse.com>
 <51ef6bd1-bcd9-9a3a-e902-887d42d7dd7e@citrix.com>
 <bb4b4106-f49d-2b50-1eb9-eb450f6b24fa@suse.com>
 <965e91fa-1f1e-7c57-5a71-a09b170a7d9f@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <965e91fa-1f1e-7c57-5a71-a09b170a7d9f@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM5PR1001CA0022.EURPRD10.PROD.OUTLOOK.COM
 (2603:10a6:206:2::35) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5901a70f-330d-499e-e8e0-08d9fa8cf65e
X-MS-TrafficTypeDiagnostic: HE1PR0402MB3500:EE_
X-Microsoft-Antispam-PRVS:
	<HE1PR0402MB3500DB324AB1CA13B01043D1B3019@HE1PR0402MB3500.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	qzZY95p2gNgUrwVd3eWhx7ianOo5PvRuS4E/xFsV/GQEDTodiRxLxO4i0FE5qk1HQBLhMYQQV5BqB1X1QPTXS34m4TvAwsxF1c0B1qQDFTvoSnxkIjMnwA9nh/vwjHMrO89yuOilCZ7r5dpcSBzBhd5GS4qrh2TaAxXhLhj/g8nEbAugS2Fr6oxvEJXF+s/gxmJatGF2AilXG+SFtbTg3HC3tqh/t4pSMY0yfk1QyGRYmlzT3os4UTFWhpdaiihGh/e2h+gBGRFylnFWkQUJ4dnP7EJyjGPo2gnTBd087Hoy+WSb1c3h7jbEc7+7RuQ/8aH9q+QdRonDmBJ3O8iEMbPGaxrzDmp23LYCS3ReIUuMRxguyhfXtNa208pL/3OKQjKHTiR+yi92deFWYCD7QgBaeCkJSUrzx86KqjpHAV75pyLNjWtwj2biRMa1FqiHk0ojGhi5RzkDzQDRl0YxS1+GHuFneBgrwiCUiB38FMTImW3s/d4lW7AcNzgB7SBaPRU94bE2GQ8R5HWcmy0gzh9/kkpCe9+mM1fPEKUkJEoxqMUmumRLozmVQCl7OtEPsi5ORk+whnYdFnRYh1lq9j95XcUHEfr+WMyN5jdTKXQtQxblvFKyVgSm2sZCp0JmtBL9cvujju4X9v0yP83SEHbLyQ4VenFeeCrT4d1Hcm4ic16MzR9yn0+AJC5Y3EjF2vBGKNPZZWoNfINVPHqGuBF33hMb11f4LFx6Ecssfyk=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(38100700002)(8676002)(66476007)(316002)(6512007)(66556008)(8936002)(66946007)(4326008)(26005)(186003)(6666004)(6506007)(54906003)(6916009)(2616005)(53546011)(36756003)(508600001)(31686004)(83380400001)(2906002)(31696002)(5660300002)(86362001)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?tMAQwxx9VA5TVAcs0xLBRKby8PgCXal9o+uyfxROQtRpyXHiMGgqZIb0/XKS?=
 =?us-ascii?Q?7BGLdOyP8Q/VZt3bJFTLfAIPhNm/BkgzYwLCI7/CHdj0RFLtpDF/j+PdZnRm?=
 =?us-ascii?Q?JT2NfjHxxUme0L8AnZreOzl9LHjmUZ8bhZB7/QhakvOK4UZP9WWm8vHAZ9tc?=
 =?us-ascii?Q?QgN6HT3vLflbx1YL2h4aOsBRH7Ul85v+fMS8CrSRzLw3D3dpmtK6chgFQAdU?=
 =?us-ascii?Q?4FpiYPbeigKaHqhvDZv2Ii6URpdJJhnMpasFldv6PJYGIr8C4VVS97kX3Vgo?=
 =?us-ascii?Q?rI8r1S1maYKrjp6T3HplCX1Od4BLWfPwCacveKQgCjQBtv5ctQ0lq8Srf3dh?=
 =?us-ascii?Q?H6ahVVGR/97UsvljSxHQlEGegB0Sjy/ufw2JIwNmksXKa5fzEy4ycq9PoDbW?=
 =?us-ascii?Q?e91BBNFLxp02UyIJeD2N852mEThxcpvPFcElDyCHxTgT5lvL9XsN/d1fwR/n?=
 =?us-ascii?Q?xa2mwWrBBvtoKwe3T3bO+UfCY4/Mpcefr0mc5DU/fcFtzT4puSpoMKRM8yPO?=
 =?us-ascii?Q?NIzISSdJEC9MdoRUejUawUkPkSN3C+wMuVX1J3MbdQiAC/lbUCVEuNlH3zlq?=
 =?us-ascii?Q?C0NpzyLQa1WMq6Ma3CSNgPu1GIXrKPUz0eZxS5TZjk6GJ3fPvQ0ASK/FtB53?=
 =?us-ascii?Q?SvbtxSyXosot+egCN2X8TZ7u+4e1A+DvICsWTd1A5QJ6YpclQAMuHnUNib39?=
 =?us-ascii?Q?mk28qf4p/brbst7TAZWGCzcCjwxvp/twi0ewEwuatBX+eLkvfquQIjEp8NYw?=
 =?us-ascii?Q?A7UCvdyVgUBReHRT12w6eNQ3qyRFyzCTX6lE/fyObzJlotyk4vorrB2Bzx8e?=
 =?us-ascii?Q?d2hMiYmxoI8GmALuBsilU/FyMs7uQwxpmqgrLZEv6HER969pNMDLramWdmxf?=
 =?us-ascii?Q?D4d5TdGUd1Uxwqe53PUn7Hrp7P7KOJKjglQp6VKw57rPRMzNgKZqbYyvk4zS?=
 =?us-ascii?Q?s3ZDD5fPlx0J29XfHSdh75EWtODaUXC6Mr8eWtpGpWM8AnU3KoIDWcjHxj3w?=
 =?us-ascii?Q?RF8EFHM5/Bd3W0q2UU+5DQcKeSjJ9Kw6I2m9t9/W4PmudOxK21MLWF3uOt58?=
 =?us-ascii?Q?7HYKkQ1/WWq7myX6EroT1m0YIHjbawcNmBz0wo81BR9Nm1ARXNxgft+SeCeH?=
 =?us-ascii?Q?jWN9DRYRiGx6Nrj4fRB/2+KDhRz6jHaqrHYv6wTj80okEPhIdx1chpPQeCUk?=
 =?us-ascii?Q?NxmvuepxymBskSXjG0tM5Qr5cHgS3LGfgDPfCudkziQjgqA3kjkMbIXPGw+O?=
 =?us-ascii?Q?73eMp+nvWSi5NpH3OhDEPM8hoLv/6yIfD6azValvNnJDX97FufWGK7ydhtco?=
 =?us-ascii?Q?pKuVyNK09lOPsGSRdnSh1Q/nfZVhq41SLeVlqT/9IgKzkinN04aiTLJFj/zd?=
 =?us-ascii?Q?ifDKzVx+nScjYKBFArKIMDSi7Kost8t00vn4CUiKs92cnw5mi4FgACtW6T8e?=
 =?us-ascii?Q?i5pbXbH0NoCrAsOBDPku/mxZ10HLn+rl+1IXIVEk9DEm/TiG2xXzFxh72o4e?=
 =?us-ascii?Q?IgItoRViGfKx53dwCO7/ZRitV8w6hGqLYiZNx3HalmGDAaCh4ePJelD20XKL?=
 =?us-ascii?Q?896FeaOoT0YhEZMywcKHliRRQbhsb3dUujBQJjFxvQDeDfcMkLyOWBrntWHN?=
 =?us-ascii?Q?+1ALL0IWIHNXLLCMbYQfhrM=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5901a70f-330d-499e-e8e0-08d9fa8cf65e
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2022 07:35:58.7135
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: U/kVp8HKn1UUY9geRrF9f8yRFgctMqJhE6mV/n6HnwceKClVbAjBScX2qVwxghzIHE+d+pJ80/6hSYg0bKGnqg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0402MB3500

On 25.02.2022 18:11, Andrew Cooper wrote:
> On 25/02/2022 13:19, Jan Beulich wrote:
>> On 25.02.2022 13:28, Andrew Cooper wrote:
>>> On 25/02/2022 08:44, Jan Beulich wrote:
>>>> On 24.02.2022 20:48, Andrew Cooper wrote:
>>>>> In VMX operation, the handling of INIT IPIs is changed.  EXIT_REASON_=
INIT has
>>>>> nothing to do with the guest in question, simply signals that an INIT=
 was
>>>>> received.
>>>>>
>>>>> Ignoring the INIT is probably the wrong thing to do, but is helpful f=
or
>>>>> debugging.  Crashing the domain which happens to be in context is def=
initely
>>>>> wrong.  Print an error message and continue.
>>>>>
>>>>> Discovered as collateral damage from when an AP triple faults on S3 r=
esume on
>>>>> Intel TigerLake platforms.
>>>> I'm afraid I don't follow the scenario, which was (only) outlined in
>>>> patch 1: Why would the BSP receive INIT in this case?
>>> SHUTDOWN is a signal emitted by a core when it can't continue.=C2=A0 Tr=
iple
>>> fault is one cause, but other sources include a double #MC, etc.
>>>
>>> Some external component, in the PCH I expect, needs to turn this into a
>>> platform reset, because one malfunctioning core can't.=C2=A0 It is why =
a
>>> triple fault on any logical processor brings the whole system down.
>> I'm afraid this doesn't answer my question. Clearly the system didn't
>> shut down.
>=20
> Indeed, *because* Xen caught and ignored the INIT which was otherwise
> supposed to do it.
>=20
>>  Hence I still don't see why the BSP would see INIT in the
>> first place.
>>
>>>> And it also cannot be that the INIT was received by the vCPU while run=
ning on
>>>> another CPU:
>>> It's nothing (really) to do with the vCPU.=C2=A0 INIT is a external sig=
nal to
>>> the (real) APIC, just like NMI/etc.
>>>
>>> It is the next VMEntry on a CPU which received INIT that suffers a
>>> VMEntry failure, and the VMEntry failure has nothing to do with the
>>> contents of the VMCS.
>>>
>>> Importantly for Xen however, this isn't applicable for scheduling PV
>>> vCPUs, which is why dom0 wasn't the one that crashed.=C2=A0 This actual=
ly
>>> meant that dom0 was alive an usable, albeit it sharing all vCPUs on a
>>> single CPU.
>>>
>>>
>>> The change in INIT behaviour exists for TXT, where is it critical that
>>> software can clear secrets from RAM before resetting.=C2=A0 I'm not wan=
ting
>>> to get into any of that because it's far more complicated than I have
>>> time to fix.
>> I guess there's something hidden behind what you say here, like INIT
>> only being latched, but this latched state then causing the VM entry
>> failure. Which would mean that really the INIT was a signal for the
>> system to shut down / shutting down.
>=20
> Yes.
>=20
>> In which case arranging to
>> continue by ignoring the event in VMX looks wrong. Simply crashing
>> the guest would then be wrong as well, of course. We should shut
>> down instead.
>=20
> It is software's discretion what to do when an INIT is caught, even if
> the expectation is to honour it fairly promptly.
>=20
>> But I don't think I see the full picture here yet, unless your
>> mentioning of TXT was actually implying that TXT was active at the
>> point of the crash (which I don't think was said anywhere).
>=20
> This did cause confusion during debugging.=C2=A0 As far as we can tell, T=
XT
> is not active, but the observed behaviour certainly looks like TXT is
> active.
>=20
> Then again, reset is a platform behaviour, not architectural.=C2=A0 Also,
> it's my understanding that Intel does not support S3 on TigerLake
> (opting to only support S0ix instead), so I'm guessing that "Linux S3"
> as it's called in the menu is something retrofitted by the OEM.
>=20
> But overall, the point isn't really about what triggered the INIT.=C2=A0 =
We
> also shouldn't nuke an innocent VM if an INIT IPI slips through
> interrupt remapping.

But we also shouldn't continue in such a case as if nothing had happened
at all, should we?

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 28 07:45:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 07:45:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280190.478046 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOaiY-0006ne-8q; Mon, 28 Feb 2022 07:45:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280190.478046; Mon, 28 Feb 2022 07:45:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOaiY-0006nX-5O; Mon, 28 Feb 2022 07:45:14 +0000
Received: by outflank-mailman (input) for mailman id 280190;
 Mon, 28 Feb 2022 07:45:12 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nOaiW-0006nI-Mi; Mon, 28 Feb 2022 07:45:12 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nOaiW-0007hB-KQ; Mon, 28 Feb 2022 07:45:12 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nOaiW-00030p-6X; Mon, 28 Feb 2022 07:45:12 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nOaiW-0006W2-66; Mon, 28 Feb 2022 07:45:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=qoWEJwRgGizpWS4wd2m9Y5agT+4K1piMKks6Q4xnc2s=; b=yw8XmPLVozvw2YzZp3mi2mJfzD
	zgz0okUCBvmSgT+kgr0a56uMd999M9RsclaCjNCXe3zcBooUPtxq4WUg8hqtrAuHxReWc08IZkugz
	SzfdIXazB0sC0lDz2V5YHvfIyhwTVQFvANAeevipfC76wIzaiUsnzOoCEkTV544v6jjc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168248-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 168248: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=4388144c44c4dd9e9b7df97938ef08ffa85eec07
X-Osstest-Versions-That:
    xen=10f1f7b010a22d6d4ee67b018412d5f7ea386fc6
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 28 Feb 2022 07:45:12 +0000

flight 168248 xen-unstable real [real]
flight 168252 xen-unstable real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/168248/
http://logs.test-lab.xenproject.org/osstest/logs/168252/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 168252-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168241
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168241
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168241
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168241
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168241
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168241
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168241
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168241
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168241
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168241
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168241
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168241
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  4388144c44c4dd9e9b7df97938ef08ffa85eec07
baseline version:
 xen                  10f1f7b010a22d6d4ee67b018412d5f7ea386fc6

Last test of basis   168241  2022-02-27 01:52:14 Z    1 days
Testing same since   168248  2022-02-27 23:06:56 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Julien Grall <jgrall@amazon.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   10f1f7b010..4388144c44  4388144c44c4dd9e9b7df97938ef08ffa85eec07 -> master


From xen-devel-bounces@lists.xenproject.org Mon Feb 28 08:01:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 08:01:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280210.478057 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOayf-0001Lw-49; Mon, 28 Feb 2022 08:01:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280210.478057; Mon, 28 Feb 2022 08:01:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOayf-0001Lp-1D; Mon, 28 Feb 2022 08:01:53 +0000
Received: by outflank-mailman (input) for mailman id 280210;
 Mon, 28 Feb 2022 08:01:51 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=A4HT=TL=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nOayd-0001Lj-S2
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 08:01:51 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id af492509-986c-11ec-8539-5f4723681683;
 Mon, 28 Feb 2022 09:01:50 +0100 (CET)
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur03lp2053.outbound.protection.outlook.com [104.47.10.53]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-41-bcYMwRR5NumY8ps3DmZtOA-1; Mon, 28 Feb 2022 09:01:49 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by PAXPR04MB8846.eurprd04.prod.outlook.com (2603:10a6:102:20d::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.25; Mon, 28 Feb
 2022 08:01:47 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.026; Mon, 28 Feb 2022
 08:01:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: af492509-986c-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1646035310;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=/aHw6eS3HhLdhmS4JyEajEPzY6f6I/mNQ5p2ENR9IAg=;
	b=bynWTn2HcAd0uB8RunTlwImLs2VIt1UucYgPWgdOcQtBKHDEn0C8AXBMnoyPolX5AkztG2
	2dAoS/FY6OrFQ6uOGRfQPrr+NchXM8KK5Qssc7fQsiBlTm4ozbE2NoOCevwCG3FEfNqjSm
	beIPs6c8COFWj0KZFCeZcQg1UKoQmwU=
X-MC-Unique: bcYMwRR5NumY8ps3DmZtOA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=HxbTY0jqvOhuEIWHupiQbiAIEbrUVW19fjgLKpQYH4g90LGaCfrek8JPXL3exoB3GGYV3fit4Qk0VaKYdpSk7MRl8AsYI8i+Qa0bcektXgdXIbmTrRsqiCJLWxe/ZtAbABGymBNGlzs7EO0cT0fN/ld02kchHkXGp+DAmW1q/rFZmCHU0sLs3EW8FNypiLcUTwuKS0UwHfVhiAavf181CXdVARbWi/XUxVVae2FZaGLxS8hDez8jON7I7t4vE+9Je0f76nO8poDeKQ04XqKcqThCubEedjfE1rtRBmxnJF9OzWbdNxpBnAcfIKmb/QxHRbq/Ufz7AYY4gHJSZOJWVA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=cOqyZQ+bY3Yh8mG1PmvxpxUYf9LoPAAtucE3Xf3e57c=;
 b=ctoxHho2wayVhV72aP0uqZm3tjxbFIqnCM875MSzs7ZHyf+fhNpCi+lL7GDDYJQWlb7sDwv8yDgz3tzuOPhJsX2g8Bmq755u7y/SBHkov2dud/SsBfHzre9UaOOa2YFyGr5oqM30KjQYeItTwA0jed+0cs+BGHICXdamGSlDrJ8LUBzdePeSSLjFI20Ie2V/Y14ZTgt5YDhRQOX8o8RtcKvFLolk21Rw2ayE8dh42RScBpvmg4jeQtd0RF9AmBaiwQY+6Gl+5sxv1uAhy95b9Uc4BLCfS2aHDP+/i49BslP561ZSTUtLWScnFPNRMZMCPmI4uP1myYBv0wDgmDwnUQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <02055c67-89a3-b60d-5f8d-cca5d38ea227@suse.com>
Date: Mon, 28 Feb 2022 09:01:49 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v2 1/2] vpci/msix: reduce indentation in msix_write PBA
 handling
Content-Language: en-US
To: Roger Pau Monne <roger.pau@citrix.com>
CC: Alex Olson <this.is.a0lson@gmail.com>, xen-devel@lists.xenproject.org
References: <20220225153956.1078-1-roger.pau@citrix.com>
 <20220225153956.1078-2-roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220225153956.1078-2-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0416.eurprd06.prod.outlook.com
 (2603:10a6:20b:461::10) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 8a4573d7-4b74-4618-5c13-08d9fa90918d
X-MS-TrafficTypeDiagnostic: PAXPR04MB8846:EE_
X-Microsoft-Antispam-PRVS:
	<PAXPR04MB88463D734B3EAEE36271A984B3019@PAXPR04MB8846.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	92bjdUXpiC6TryRJ5x3Ie415ZGsGTECxKUA60kZa4vefm6q+pJ7d0UsbdLq01JVSCz2eaO55V5itvxdQ/b+RsPa0oFPAcWDoj8nL5PWm6y8JEXNW+R5k4uAf8KtgtCfQoNZYstxZYGV6nX26X2sUiuqTLh+c2+drA+qpJWt/K61aAnMWxujG5deeVIY/NeK0ncHHJs62RVtjXwsjBrtDQUt3YsaqDI/xb7XqMONt8QEfYMcAonC6hL7QFkTGX8r+wL0P5PSFHlZGarU9w4SB5R1/mEuZxsNTY4PPm/CQEzvZooBdhamPKfPe524G685Cd/WXz65aBwEN8ydm3n02JquE3bAAo5iPRNDW2rD15pW4MslgmddW1FUASsSF/2hLBPkq7/Lackp5ZNS5TIwdaRKH2ROL5VdHFsP0cFRrHq73c+Db7biJ5DlWEKx9au2vtqXHKQIqiB//0rf3fPcbceDh6drwTnKHrkBqNRnij4QfxLjH/3Cx6ukSGDhbdAIbp0nD04a7uWRrfJfD91mCqURVFLjprBUu5c5MHw2Ip0/Z4BfcoVMLWFdE7T8pGjE4jxEDkt9TkQJem20IjE62cQHNqc3o6OjdhKvIYsHlxc4PPTR3YsjEn1tB8KcJmglsDxNTgGe1tZXKr2XQvSQjIjQGihDUUPSTzQF6HG0RI46fm4KwdQnL/AjthM9Aof3fgwe71I50Zpda9oBDQtAGIKkMnTYZd2ZtVRuYLoBlv/M=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66476007)(66556008)(31696002)(5660300002)(2906002)(53546011)(8676002)(36756003)(66946007)(8936002)(4326008)(31686004)(6512007)(26005)(558084003)(2616005)(6486002)(186003)(86362001)(316002)(6506007)(38100700002)(6916009)(508600001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?KOwiEV1jXDdNcqT3IJdlrY66g4BlerO0t0RlQf0AKbylHbiCtV4lgtqZ1oXi?=
 =?us-ascii?Q?uxR5fGvI1wdvfzUBLRm2wXuNIvr05AYFY5TujS51ea+sUMDtMLYzi6nn52tH?=
 =?us-ascii?Q?N6a60/uAktlSxE7f3NauHwvkjkwCnTYtdR780o6j7vuAo5PGnBKhi+nJk+nr?=
 =?us-ascii?Q?YRBW/YzSfmQ6tsVvOvt2ev4W4yZJv/TL67LoEOKJHOHw/Mb7BdcSjmRyZmz1?=
 =?us-ascii?Q?5aN2UakbGUAlt9lcjODq8ZmekD8Pij6dg8B2MKAtPoCdcl0tX0/hFV+zgx9w?=
 =?us-ascii?Q?8jCwD1YzSbSRaSVnYDPzwoUfJ0OKdGFE81QeMk03F19njub8LjZluvwHETos?=
 =?us-ascii?Q?EXuabgr4KM6KgyzYcLAzOSQOxFlKr2kxDG3eMK5q+55+vNsR285PJUbDtpy8?=
 =?us-ascii?Q?sPeISFo0yF+dU24pJzCmLUByOmhgjy0il6tORVOZ31HldpKHZzEo/ZAmKazo?=
 =?us-ascii?Q?IC2YPySkEPmZ3y0+f3ldceJ3Fr+Wd80tVNvzwYjO5lwkFu/+XpDOUxDVwTFx?=
 =?us-ascii?Q?0iGsGmgRioSaeQKsDS2HSHaQtigcXD1zXw1rG6Pxd5Sw49VyOoRbnR10mtFx?=
 =?us-ascii?Q?E3Y5OQDAqe1Ou6fYHqfRtg8aZnek7v3oAA4+8YcWb6DlDkpxkC1SIoUCyLJN?=
 =?us-ascii?Q?TUghiZiYHvuHuiqubReFU2CSaP8TY0Gbi4+1y88sRNx6lfrT4oLVtyXjh7TA?=
 =?us-ascii?Q?90em4Xy8+ksXNkRQGtEnSmNKGBuNq0KidT4OsJLVH95gdPknO1TLz2bM/0TI?=
 =?us-ascii?Q?6r/TjLM+FnHQAR0LpTJb+Jk3Uys5YuBex2XSfixMWRq3zLoVkjpScmkTQfN3?=
 =?us-ascii?Q?V/PPx+17NVH3tqU4tGZFnRR/YmQAtrtmSYnk/nAqcvHpChodMCkiitdXYp06?=
 =?us-ascii?Q?y+utbowNv2Vi/rgVYt1Ap7vPNSTwiqx/LAfo7J1jeheAJAeef8eeG5rzqq1/?=
 =?us-ascii?Q?J8J5R67fnUgMJ/CpILf08qa0ZY1wJf9XGn5gc3jqX2oTGrjoOlJMCGPuXClG?=
 =?us-ascii?Q?CB6b48tc+/jx8odgc6AdWaRMOt9O4sCSDAkCB8LaigWqtC4XjpekKPqRoYl6?=
 =?us-ascii?Q?74OldEFWYqwfWFSye/TQUH3MQXjMiAqmKgxmjSiiC9CYBRO7k71WLJfGaqom?=
 =?us-ascii?Q?TjDT6cqAtgX8F6mF+ndXvyNBNP4aaD8PHTkPHXBWpIpg1w/LkHfSHbPa12b6?=
 =?us-ascii?Q?ti8JvmesyRtiT7xCThxbBO8cdXw3XG3A+/EW44ZpWkzGvFzjO0gXC6tL599B?=
 =?us-ascii?Q?4ZeNjwS+eFRWeSK0AwaZ0O2eXMB+apJfgfMFEBTNCvAhXteOH8wIOtJra3Nl?=
 =?us-ascii?Q?UhuQRe6TVMzSOsjScJv9mYk5MAcLtlIvkXvBnl4aYyG2vVDLU8X1WdMiB+kq?=
 =?us-ascii?Q?T3oe2FOCqg9FwgpOhF4NT5RbcSEvKn1K12uGuolMzWiVNILzIZfFEOWGeKiN?=
 =?us-ascii?Q?XyN9r3TogcglFrMK4JyLg9HOOAdhIjlg5TNSQoSKqo05gD4dC1mqGHuLW1NS?=
 =?us-ascii?Q?8fdUdeHeFduaUFIyAmUGtKIdovsI0ntj3BlJTD4wHkHCLJ+wYIqzedPDSJio?=
 =?us-ascii?Q?MwAAPXcGK26iPCFbXARIRjru3hAx9V/BtFhT1yz1nA8CnKuiGkc05RVtxUwC?=
 =?us-ascii?Q?3lZmUXi+xRIHbeM1DoaoLsg=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8a4573d7-4b74-4618-5c13-08d9fa90918d
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2022 08:01:47.6643
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kiOuw0IAGKcTFokML+5PoQbBaA9xg5aKhW3bpa5ppQHJt1Rf8kPZDm68wUW0JOqSH4WTjP2sQgctVzO8KkgAqw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8846

On 25.02.2022 16:39, Roger Pau Monne wrote:
> No functional change.
>=20
> Signed-off-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>

Acked-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Mon Feb 28 08:06:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 08:06:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280217.478069 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOb2s-000200-OM; Mon, 28 Feb 2022 08:06:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280217.478069; Mon, 28 Feb 2022 08:06:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOb2s-0001zt-JU; Mon, 28 Feb 2022 08:06:14 +0000
Received: by outflank-mailman (input) for mailman id 280217;
 Mon, 28 Feb 2022 08:06:13 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=A4HT=TL=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nOb2r-0001zn-5e
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 08:06:13 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 49dffbd0-986d-11ec-8eba-a37418f5ba1a;
 Mon, 28 Feb 2022 09:06:10 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2173.outbound.protection.outlook.com [104.47.17.173]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-13-R0ME7ReRMbCld5zOWB79Ww-1; Mon, 28 Feb 2022 09:06:08 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DB6PR0401MB2583.eurprd04.prod.outlook.com (2603:10a6:4:37::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.26; Mon, 28 Feb
 2022 08:06:06 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.026; Mon, 28 Feb 2022
 08:06:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 49dffbd0-986d-11ec-8eba-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1646035569;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=1MVKJsZZ4FZphk4iI3F/skfgZAbFHqBSWA96qazOT2E=;
	b=P5K4O5nTjXyuH5oX9bOBD8rKnIhWgO7zAW2FBI/QCd6NIcJV8Wqk2FgDQ+fSogIj0PgvL9
	9CIr4lmyV2Wi5bwLfbh1B4xMvply52P/7VJXozoA4h23fSaJ/fhCgu5V4FuL2Fmk4bLHUx
	Al3xGXYWKmRGeo/2jx5FTguFYh8u7FI=
X-MC-Unique: R0ME7ReRMbCld5zOWB79Ww-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Ju29got0lGSbwq5gyTfeSCoN7MgDiqAzxFh84IW7LtXna9+w0fMIVuUMy8UFwQ467Xsr6D3A55lbzBLNhL1nuUOt4w2r9vR8Z/JOu/on3ObKv2G37Tkio6zuWqSxAT7+O5VPst74vkM5+MOiPC8ZWGvHa2LL5I2MTMQN8cRTbi6cQ2PB1TNZ44TfUps5/t1OLy9s8OdyIQhcoV4Cr23D6iCvL0kFc6ySvti9GtP3F2xiz78IgtHeCU3huUDXvYmTLXN9oXWyrXAvvSVMgqEQUyY+lbI0njq4RlKDXPKpQeBeViKOO1YKJCH2ghlKWZEOvgEYiWSGU+7TTSfOwbKB8w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=1MVKJsZZ4FZphk4iI3F/skfgZAbFHqBSWA96qazOT2E=;
 b=mr8gbTgXkpzcvy42GewkQR14rt7ECxf+fphM0hgU4Inu1VvEuga7LISUfYzkUCQRp7QXupVO0Qod1fVPU8qqkFVQKZnmQTMTW3fKRpopZNeCfp7WT1qozBUGEeAcZ1cRqVG+Xtv9iIBMwZWtvK+5SQswLG4jOPx2iRp1T56OfzxIm9jYDaSj9hJsyCDneQMNom2TBSl9i4rafPmFaH9szmY9eGtHblCRQzl5JsDVXiYj9q40wKfXC1aqVd2yMjfrWZOTjEPGIBsWaIKCxNGC1PRHwsnKxJpylA+J67M5rvAPO1DK/J2B8gMRvkfFMEn6n1EROH66apW9hn6862ADNg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <8938002d-6ed7-bb52-43b5-f9788da3a4d1@suse.com>
Date: Mon, 28 Feb 2022 09:06:08 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH 0/3] xen/arm: add i.MX lpuart and i.MX8QM initial support
Content-Language: en-US
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Cc: andrew.cooper3@citrix.com, george.dunlap@citrix.com, wl@xen.org,
 xen-devel@lists.xenproject.org, van.freenix@gmail.com,
 Peng Fan <peng.fan@nxp.com>, sstabellini@kernel.org, julien@xen.org,
 Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com
References: <20220228010711.11566-1-peng.fan@oss.nxp.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220228010711.11566-1-peng.fan@oss.nxp.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR3P281CA0004.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:1d::23) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 8660e871-773c-4260-6ea1-08d9fa912bda
X-MS-TrafficTypeDiagnostic: DB6PR0401MB2583:EE_
X-Microsoft-Antispam-PRVS:
	<DB6PR0401MB25834163D2E62C23DF0B923EB3019@DB6PR0401MB2583.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ug3UsEkPdXsC8qd0i8npT6kc6vynsX57wcR81xzttEmzvt/FQMwYt9cj/7Ibrd6answ84uxHBnBjXK/FwWcw1PjXuHF/g+hwUNmmLthf04jZx/MHcSWzc95fuAAJLvjApgj3tHqYnJTBVIqHFAaZnYQwnL/VSNtiPL1uuMXCF1ixVh3uVusB5rs0lBtoGc9fA9LPCIx8PSJvcsG3n+XPkRIClFonljw8YYgdORi1Ad1mrk81EaGabugYCpRiLwtWsGSkXON7LEeSwHCaKv8Rsf+gTjhxgB2iZLbmXYcTfhzmErcZXCNgYpysjw0+3r+yz3KwcV1hhLtto9KkGa+rtd0xQJsHSR4YgaK/COakS6lDLaJlnuW7SWQGBljRW7k0NKXhp084PWYVdLrdk+JcERVYSB8O5l+PrPYSQjJy/rUbn4BxTuJigvPKTboJWWO3s3+6S+mnzjFr7NlKi4ef8ZjADZkIuo+wrtVQhSjyQmEtiMUpnvceJj50iVDUTB5kQY5lzSUa77s1kfox75x+crOZ0X4PTcAArIgR30L4locfURRB5cGMsaawDGstF57b8Zx4wsb40gWFpHje8OILiw59e332lmDM87Roq+xt6qAOFTFfChnuvvvNbmbhr/to6yihv6FnfeL9YXEMSf6fVpqnO/jXIySM8M3jBxiNJv1vqLLtyaWFh0t/0iiY8sr+gRxuhUj2fCmHjN7Hq1jGuAflFGJrA2rYW7nJEqzT23k=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8676002)(6916009)(4326008)(66476007)(66556008)(66946007)(316002)(508600001)(6486002)(86362001)(36756003)(31686004)(31696002)(38100700002)(53546011)(6506007)(6512007)(2616005)(26005)(186003)(5660300002)(8936002)(2906002)(7416002)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?MGtFREZydHVXSkU3bmU5cTRpYTJWMHdWS2J5TkxlTmZDWmZsWmgyaVN2Z3JN?=
 =?utf-8?B?UDArNmwzOVRDRENJYWgvTG9GbmkvaHNTSTVJR0kwZ0FBYVJKVDJKSXBnZ0Q0?=
 =?utf-8?B?d3NVRzlGRk9JVkJ2RVIyZ2hGZkpFVkxvRXJMYWlrOXpFbUQ5OWQwUUNURjBi?=
 =?utf-8?B?NU9hUThnY1VVWkV4bkJ0Yk9wZml1V0phNk43cmJFUXFSS1Q0LzBCd0lDb2pv?=
 =?utf-8?B?SmNRR1BHVHVFTnBnUUVaYWxGaUxsSHF4Qm9ETWJqSnQ3WHhGdGY4MnZDZEhE?=
 =?utf-8?B?S3RsWUdpK0lJSERpWnFNdWtsSXllTUxkdVBLeGE4OExHeEs1WU1YTnE3KzVH?=
 =?utf-8?B?WTJocTZGRFIrQkFLZ09MSk5INkFVczhTSXBUUzE0dHI4ZTk0M2pJb3h5d2dJ?=
 =?utf-8?B?TjEyNkoyQ3Z3WXJPS3NZNWxQMXgrejlXMXgydDdXUXFPZTdtbTJyVGpCUkFr?=
 =?utf-8?B?N3JPeUpDaHpSSHlSSFF6b3BXNjNmbmRSODVHUDlNNkMvSGt1UjRrbDVnNGhp?=
 =?utf-8?B?V0txU1BKeGhuRjZwOWFQSG1ycjdrcy9GL2ZYVldWVk11QkUvb1EzTEZwbTE0?=
 =?utf-8?B?VnhKN2VCRnpmSDJKMlh4KzRZdzhoZ21xVEh0Y3NVVHJUV3JXc2hyejAvRUR3?=
 =?utf-8?B?MnQzUXRSbHUrdVozSkdwWXl1QUE0VVAyR1hnS0Y4WU9GenB0b0l0MmdoWWEz?=
 =?utf-8?B?NklDUVBRYy9TQTNiN3VselJiRXpZeEI2SFdjK1R0eWNOV2Y4a1o3OWUxNHdV?=
 =?utf-8?B?bEpNOHJqWFdIRHlzeEVpVFVvQlVjRVByRlQwMEFCa3ZYM0k2Z210cTRJMUVG?=
 =?utf-8?B?S1RkQnc1VUg0bXBwdHR2TklHSCtidXJqQTlRRUZSdm5wWGlYdVZBc3BYTUk1?=
 =?utf-8?B?K3hlalEvMzVTMTZtR1RqRWVZUlExWnFwMS90aWxqamtXTUdMYkZsTTNPclBW?=
 =?utf-8?B?Q3pBYmdlWEU1UTh2cEZDNUt1ckJzYStJdmR2SzkwZEZEczFZOWZnUWF3Yjc3?=
 =?utf-8?B?cGtlRUFlS29OOUs3WEtRMTBuVlEvMlBvdko4cnY5d2o3Vm45Q3lkRTd6N0da?=
 =?utf-8?B?b2c2MVovb2FFRWtoUlV6MnlQeVRNeko3NFVuY1Z3Z0xpOThWWS9SeXRaOU9D?=
 =?utf-8?B?R1ljRzVWb1lVb3E5ZDV4VGxsV09WQ1VqSXlQVllpdjh1OFJKQ0lOb3h5NVBO?=
 =?utf-8?B?VCsrTTZQU0JZcDlCZENSM09TK3FVN25IQzNrN1dJUFUwYjZzQkNVeVNzZ1l3?=
 =?utf-8?B?NDdxTDhhNDZkUjRJZDdINXMvUi9WMEdIOTlKZmF6bHFibXNqbXplMWZQYzlo?=
 =?utf-8?B?S21Jdm14VXdEUHhFOFBGNDJyWDd4MERnNk1WSHhyVTJaSjAwbVRaUGM4ckZZ?=
 =?utf-8?B?Y2tid0NySUhxYXhuOWdJUjRObFl0T0FIVERjRjFnUnh4VnhSR0QrUFJLVWNp?=
 =?utf-8?B?T25nWGVPMmFsYjg3ZkRjR1ZKNTVBL0xNSkJuY2p3ZTJrNXA1UC9DWlJGOGM4?=
 =?utf-8?B?NGVhampRM3N5MVl2ZEt0Zk40SjRLTThJOGJtM21PWERJTjdsTko3QkdzcGZW?=
 =?utf-8?B?dGhNVUxkUG9COXRhR29BVE5idGl4UURZaHhvSVFsanFWYjRSUWVwamo4Y005?=
 =?utf-8?B?aWtCcHMxNjVONUlMMStkdWxTUjZ0M3hHQkY0SFVyaGgrLzNGU2JmenFHRk9i?=
 =?utf-8?B?OXdDZGF0Q0ZUb1poOExHcW5pUkE5RjhseUozUmVrVG9tMzhTY3I0WnJLazBy?=
 =?utf-8?B?eHUrWFZGcFE1SjRWd1E0emJsN053eHVHZnF2N0pGZlI0aXlwKzh2TDJDK3dF?=
 =?utf-8?B?VFNqYi9QaVF6d2Q1QkpWaG1UMlJyYU1QdGY2bzZhN0ZpQWpreEU2emNqdTJq?=
 =?utf-8?B?YkQvaU1JWlBmR280WHJtY2R3YS9VKy9nVE9BVi9KdVBva0tvb1dlblZWbFp4?=
 =?utf-8?B?Y2ZWK0JoZDZVVEpaNHRvRllNYjVYZFZmak9hdTVOeVc0VEIybVZ0RnpBaG9Q?=
 =?utf-8?B?OUF0bzZDTUhYRlZDbHMwcTZkZUNjVHVOUjNWOXZKNkMwV01pTWpkKzFsTkUx?=
 =?utf-8?B?NytVQjlWbGEwai8zZkFhWEFqd3JCNmdRcEw3aXpTSjdYdXo3YTRYaVNaTGN6?=
 =?utf-8?B?ZitabnkyL00rZEpOOGxHNXNzaHlmditXUUh5d0tuWVU4ZWYzNzNuZ05pb041?=
 =?utf-8?Q?Vw2VItpKQg4VDL/zxABBDrU=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8660e871-773c-4260-6ea1-08d9fa912bda
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2022 08:06:06.4291
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +2lT/psiO0NlSXbczeQ15I7qsVv3ICpUm9sfPc+/aFGAoOIdrjuyuxdouhWdjbOf8vxxZ4KkMTje/X25FoFgBw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0401MB2583

On 28.02.2022 02:07, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> Add i.MX lpuart driver and i.MX8QM platform support.
>  - lpuart is the uart IP used in i.MX8QM/QXP/93.
>  - Very basic i.MX8QM platform support.
> 
> Peng Fan (3):
>   xen/arm: Add i.MX lpuart driver
>   xen/arm: Add i.MX lpuart early printk support
>   xen/arm: Add i.MX8QM platform support
> 
>  xen/arch/arm/Kconfig.debug              |  21 ++
>  xen/arch/arm/arm64/debug-imx-lpuart.inc |  48 ++++
>  xen/arch/arm/platforms/Makefile         |   1 +
>  xen/arch/arm/platforms/imx8qm.c         |  44 ++++
>  xen/drivers/char/Kconfig                |   8 +
>  xen/drivers/char/Makefile               |   1 +
>  xen/drivers/char/imx-lpuart.c           | 303 ++++++++++++++++++++++++
>  xen/include/xen/imx-lpuart.h            |  64 +++++
>  8 files changed, 490 insertions(+)
>  create mode 100644 xen/arch/arm/arm64/debug-imx-lpuart.inc
>  create mode 100644 xen/arch/arm/platforms/imx8qm.c
>  create mode 100644 xen/drivers/char/imx-lpuart.c
>  create mode 100644 xen/include/xen/imx-lpuart.h

I guess the latter two additions want to be accompanied by an update to
./MAINTAINERS' ARM section.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 28 08:12:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 08:12:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280225.478080 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOb96-0003Qe-De; Mon, 28 Feb 2022 08:12:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280225.478080; Mon, 28 Feb 2022 08:12:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOb96-0003QX-A5; Mon, 28 Feb 2022 08:12:40 +0000
Received: by outflank-mailman (input) for mailman id 280225;
 Mon, 28 Feb 2022 08:12:38 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=oRDO=TL=nxp.com=peng.fan@srs-se1.protection.inumbo.net>)
 id 1nOb94-0003QR-MT
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 08:12:38 +0000
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01on060e.outbound.protection.outlook.com
 [2a01:111:f400:fe1f::60e])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 300f9c96-986e-11ec-8539-5f4723681683;
 Mon, 28 Feb 2022 09:12:36 +0100 (CET)
Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11)
 by AS8PR04MB8434.eurprd04.prod.outlook.com (2603:10a6:20b:345::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.25; Mon, 28 Feb
 2022 08:12:35 +0000
Received: from DU0PR04MB9417.eurprd04.prod.outlook.com
 ([fe80::552c:ed46:26dc:77cc]) by DU0PR04MB9417.eurprd04.prod.outlook.com
 ([fe80::552c:ed46:26dc:77cc%4]) with mapi id 15.20.4995.018; Mon, 28 Feb 2022
 08:12:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 300f9c96-986e-11ec-8539-5f4723681683
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=CEeWg750YBFAul3OOPRSIyVm/hDT90NNXncy+5jfRZBek8DJTI2XI+GASZnUIcP3vP4WEfRzWbW8Rf47fQ7UT6N1BFSye/yVzjENPH3326P+Fmr3+/DOGwww38/G5WBFGY7whuhnocxBv/9lYF03vl6DcQwaiNdzur8Yy8njiNowOCAenr0w4zG8YZjC/Cx1VIIONSBW9Q0LHZeAz1pBKS/l1hE6rmyPJndXoZsADajlcBdnNhcAsEmDGA6lFQgA+M09MFihHddNO8BGLX5m/dnBUgF10S7WlmTl6pRpJ8t7HwtHcd5jEjBz2QdSSXlkpS/uMJQd9aXmHMYkyp6VYw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Kn/Jwj7vhQrZqtsBVGzXc1XGDB76vUmMIy+0q687RVs=;
 b=RlLzQD/nyCQ2Obo9Wsiem3pT4yCGTAFH05/PvS3ux9iNnZIeuMXPlo1kpZDKoJlG7Fq/XknB5hEmqezTO9/YuRQajmzL89gRboCgCdNE/oqLNf3xXAN0TIn05khT/vBSElG4KNe2fEcVFgQdPb7MLPY9EKX/KyeSzYThUtIkYsTcpPTo+PQXKYeOFNtqqbTlV5TuWmnnY7FvwjTicUmFLAY5p/pgMCpIH7KzYVvZnfR98RwlMohU/UfdZtX+SbvzubtfLEgzY29hjU1UCDC1tJxPxidsFOCmq3lgxkUKgrb94w7gapt2JhY+gqxtm7+Cfx7k0AXs4aIRJTwfFVoMtg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass
 header.d=nxp.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Kn/Jwj7vhQrZqtsBVGzXc1XGDB76vUmMIy+0q687RVs=;
 b=NnISi3EyV0OMgbrZ3gu+9vRyGKt8MfyK1aHRc6UY3dUXobUrgjuayF9byaXQQqQkQmwB6oH32Amr1RC5KjdPUbJSTtvMjTODKqwgWDy3AvKnnZnJ+BsdNIz1PMiTXhAjTig9IQux+CNuAT9d83utQfZA4S7nUL4Dr4o6xVZepEQ=
From: Peng Fan <peng.fan@nxp.com>
To: Jan Beulich <jbeulich@suse.com>, "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
CC: "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
	"george.dunlap@citrix.com" <george.dunlap@citrix.com>, "wl@xen.org"
	<wl@xen.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "van.freenix@gmail.com"
	<van.freenix@gmail.com>, "sstabellini@kernel.org" <sstabellini@kernel.org>,
	"julien@xen.org" <julien@xen.org>, "Volodymyr_Babchuk@epam.com"
	<Volodymyr_Babchuk@epam.com>, "bertrand.marquis@arm.com"
	<bertrand.marquis@arm.com>
Subject: RE: [PATCH 0/3] xen/arm: add i.MX lpuart and i.MX8QM initial support
Thread-Topic: [PATCH 0/3] xen/arm: add i.MX lpuart and i.MX8QM initial support
Thread-Index: AQHYLDnuLa4kODQy+UeFBibwbeVee6yom6AAgAABZNA=
Date: Mon, 28 Feb 2022 08:12:35 +0000
Message-ID:
 <DU0PR04MB94177C2DAC3018BCF1DF963588019@DU0PR04MB9417.eurprd04.prod.outlook.com>
References: <20220228010711.11566-1-peng.fan@oss.nxp.com>
 <8938002d-6ed7-bb52-43b5-f9788da3a4d1@suse.com>
In-Reply-To: <8938002d-6ed7-bb52-43b5-f9788da3a4d1@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=nxp.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: dece7b72-c268-4623-9a3b-08d9fa9213be
x-ms-traffictypediagnostic: AS8PR04MB8434:EE_
x-microsoft-antispam-prvs:
 <AS8PR04MB843413D6688A62710A3DEA8D88019@AS8PR04MB8434.eurprd04.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 5b2+gqL6CC6betoPrN/OAecoWtyJh38ESHuYkSnbqgTT+28vRnKXk2cHtiFGBccl8TE2PDm2bMfnhB0jiRqX2P0yzsiT0dOgJ6lFiyWIhmWCvdCcqluuGxEAr/ELOH4CY77BRpv/GWs6CXQB8ZQ8wjuZ3g2cBDsiND1AZbyeYQ6/QctRnbB4t4ehPOojIwmCODJZept5qn1nssO2QvfRBaw3vfzJizAykNLNee8S/t19n/7FLBOj1a7jBarlgwu9N9V9rNfFzYoBmSQTFXMkF1fwSIWj8dRdfyzZFz2IwU9B8Z6USZl7imFt7BMZvYLb4IoxuCCYGWFIb37T0+YdRET3CrDE0wZX6yUVPM274kc61nzzLACVhZuszTa3CYlsWBsXgCMEB4Q53Y8gqDDt/kmPTsDKpP/klKko0mR9RuFZctjT2/zVls2zSu1ipzVd4vzI4iT6hnFVM+VF2xCXkAD+3nd7JhAwH46KodRsHip1CrygqAQnelt3MsfSLR2/pu+fxM/WCHK5ruXBkZIhI0lLDLINy+E+Dp7OWrLoGBBGSCx4k/+H5DD9tsSjrmOIU2Ih1+g2vitBJlNJUKX4IQyHF6I7KzHbKPExk1jGMh9Xsn8CyS9CBTanXBzIY3/4V8Q49E2kaZx1cJXvr2kAfZc2HqZfdeti9uypsDRrCHT/JnI0M5K7zhng4YjYr+1IaUv2i88Jg0+cZSg9baESzQ==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(54906003)(86362001)(26005)(7416002)(71200400001)(316002)(9686003)(186003)(38070700005)(508600001)(55016003)(44832011)(66946007)(4326008)(66446008)(83380400001)(52536014)(110136005)(66476007)(66556008)(8936002)(122000001)(33656002)(38100700002)(64756008)(5660300002)(8676002)(53546011)(6506007)(7696005)(2906002)(76116006);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?OU1lKzhQZGp4VGRmYU5hRnMwN0RBQ0MxYkZsZFluNktZamc1M3RDRTBjMjln?=
 =?utf-8?B?a1dNTXdXK2hTakpGUFBEZzVtTHBsL3gxWkhIeE0vaDlBck1zeFdQblk0L3or?=
 =?utf-8?B?bnlzOXpRZEhKL3hGUTN6eEhGRkNQN3Byd3VUa25Ia2NBT3Zlck01TXl0UGRD?=
 =?utf-8?B?VVdJOWs0SVJCNDNJeDlJc25Hd0UrQjV4aHlDYkl3eDFwaHBlWGM2aUhWcWly?=
 =?utf-8?B?SmtSYmsrbDNQby9zbVpicjQxanh5MmlDckd6NEFrZGcrNVdWbHlybU42eWg4?=
 =?utf-8?B?V2xNcGFXeXg4VEFnT3JWcCtYV0lDY29ta000VklrK0Fsa0lydVo5NXZOem56?=
 =?utf-8?B?MjJrZmZvRjNobzI4K0wvSUdadmVldDgzdmdFOEtyUWxycUFWMHZJdGVaUytU?=
 =?utf-8?B?S3pmdnppdUJUYmJ4MXJreG1FOEZwWkNTd3ZZZE5mZDJOQkd2ZDBMMGt0d2to?=
 =?utf-8?B?TFArdEF6d2c2VzdRRlpjUVU1eWEyNTVObGtsZnlsT3BYd0tQbjEvQTRKeER4?=
 =?utf-8?B?RmljMVhiN0ZzemlOVndVRjJrSkJiSms1UlZDTG9aMDlBaE82OHBJd3kzbTBu?=
 =?utf-8?B?SVJGWUlQK1R1SXNod3c5Q1ROSTVOaEJXMWlUUDVpUGdPNi9Sb2l0clJoK0pI?=
 =?utf-8?B?cjhJeEFpWkl5bEdqcnB4czNlY0thbksveDd5Vm5EM25YY0c5MFVwSGhGcEEw?=
 =?utf-8?B?OHF3NHp2d2tEa3dSUlh1akMwVU5OeUI3S0p4WmdIaE5ZREIvRmdmaVpWckVu?=
 =?utf-8?B?dlZ1REVld2FXREVxbHFRaDFZRXhhTHlWWlNyODdvSHZhSzVrTjRPS1hGNE9u?=
 =?utf-8?B?QitGb0NLbVA2V3BkWHM0TkovYlBqTzMrOTkvRnZUanpYVUU1b0c5SEI0eDht?=
 =?utf-8?B?L1V5NmRCM2V1a1VxMkVva3JCWFFJek1DNG81RFcxSGNSa0lpWXhYS0VPSGli?=
 =?utf-8?B?WVBIU1ZxSjk5UmFLNUt6ZGpxWGlWUGgvbmllczAyN3JGZHFqdkM3aFpja20r?=
 =?utf-8?B?YUMxUEdrV0pkWTlBSHF3NkpSdU8vd05jZG45TUliNGdxQ3VhMnA4Mk5tQko5?=
 =?utf-8?B?d2dpVGpuWEdBVlFFaE0wZThyTUE4Y28wQXplSzIzcEwwRmFaNjRPQVRDb0Zh?=
 =?utf-8?B?Q2REWmI1Y3BWNjdWam02YURFNHVUQ3NIeDFSb2RmbGtzSWk4R3hvazNnZ2JF?=
 =?utf-8?B?OTIyM0J4akcwN0ZvZlBqLzNqcDBvbnp0d1N6MWo1dU9LbjN1aTl6ZEdZZE5l?=
 =?utf-8?B?VnBERjNBN01zbFBxY3QvN05RLzByYzMxdzZvNmpPWHRFbUVndjEyNG9oYkJo?=
 =?utf-8?B?b2RFV2psVE9hcHc5ZlZ2eGhVb3BBaXdLOUR1S3dmUHpaOGVmZ1dGd0hIMm0w?=
 =?utf-8?B?NTRndGtWZmYwaGFZUnMrN0FlTHgweG5Kbjd0SEE1emtnd2JGVlVBV2kyQ1J4?=
 =?utf-8?B?bHJwWjlmTGNEY3l5QUV5NlE5SEsxYnpXMzhkbzJ4YkN1MXNsbzMrU3pVbVJa?=
 =?utf-8?B?bnJtNTg3ekM4MnlKeFIvU2xGVHZCVUE3RnZ2N0JKZ0FHZW5Yd0hBWHFqK3R0?=
 =?utf-8?B?VFpUcVIySW5zcWsvY1R1Y3hOQWd4eVd2WXl6TVYvNGxMRG9KNkoxSGlXUW0y?=
 =?utf-8?B?UzZlZGl1UE03a2tacitzY0ZWdzhJRHpkUmc5V05uQy9mOFUxZU50Sk5NZnJj?=
 =?utf-8?B?R1NyN1htQkpnOFpOcStHNk9CV1ExWTgycElPemMxU0k2MHJBTmRSZGl0UmRZ?=
 =?utf-8?B?Tll1cmZEU1RVRVVCV2pPcXR3VDBvdWpsblR0cm03VHBQYkxrY0t5Y0pYckFG?=
 =?utf-8?B?d0hRNUNpQ0kyNGJRTHBYeXZJVkhKNjZOTUI3UmdFU1FVVWVGTXN1QUpQaXhr?=
 =?utf-8?B?TElQRzFTNjhidVNmK2Yzb0QvU1RFRE9LOHNEZDBiL1VRdW1aZGQ0UHNvcXZw?=
 =?utf-8?B?YUhwSmFRMFd2UWh5dVh1Wng2VCszeTlCSEV3UUNLWGFxa1ZHWFlNOW1BOXJM?=
 =?utf-8?B?eTUwMnVhWldQZEpXaU44eFFvUnRPTzN0bi85TFV0c3MzVjg2Z2NlZHpEK1l4?=
 =?utf-8?B?cmtuUHNFblRJVENoa2RFWXM4dGpxQ0hodnJQdFdUN1BMRHhrajY2L29LYm0y?=
 =?utf-8?B?ZjExQmk0Zk55dDFiYmhUNlZxK3VlVVhiZHBaZDRrakdBLzFONWxwbUE5SHRT?=
 =?utf-8?Q?1Xsno8F+Ec7TDTjv2bOzmlI=3D?=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dece7b72-c268-4623-9a3b-08d9fa9213be
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Feb 2022 08:12:35.1969
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: TDKyWmRjxxqC6VF9KX0AEZePSQ10pWDTE02glQGQAqFnhaZq+HlAU3y/qv+Kw1oCJeEQm0/goREuOKLfYtWvpQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8434

PiBTdWJqZWN0OiBSZTogW1BBVENIIDAvM10geGVuL2FybTogYWRkIGkuTVggbHB1YXJ0IGFuZCBp
Lk1YOFFNIGluaXRpYWwNCj4gc3VwcG9ydA0KPiANCj4gT24gMjguMDIuMjAyMiAwMjowNywgUGVu
ZyBGYW4gKE9TUykgd3JvdGU6DQo+ID4gRnJvbTogUGVuZyBGYW4gPHBlbmcuZmFuQG54cC5jb20+
DQo+ID4NCj4gPiBBZGQgaS5NWCBscHVhcnQgZHJpdmVyIGFuZCBpLk1YOFFNIHBsYXRmb3JtIHN1
cHBvcnQuDQo+ID4gIC0gbHB1YXJ0IGlzIHRoZSB1YXJ0IElQIHVzZWQgaW4gaS5NWDhRTS9RWFAv
OTMuDQo+ID4gIC0gVmVyeSBiYXNpYyBpLk1YOFFNIHBsYXRmb3JtIHN1cHBvcnQuDQo+ID4NCj4g
PiBQZW5nIEZhbiAoMyk6DQo+ID4gICB4ZW4vYXJtOiBBZGQgaS5NWCBscHVhcnQgZHJpdmVyDQo+
ID4gICB4ZW4vYXJtOiBBZGQgaS5NWCBscHVhcnQgZWFybHkgcHJpbnRrIHN1cHBvcnQNCj4gPiAg
IHhlbi9hcm06IEFkZCBpLk1YOFFNIHBsYXRmb3JtIHN1cHBvcnQNCj4gPg0KPiA+ICB4ZW4vYXJj
aC9hcm0vS2NvbmZpZy5kZWJ1ZyAgICAgICAgICAgICAgfCAgMjEgKysNCj4gPiAgeGVuL2FyY2gv
YXJtL2FybTY0L2RlYnVnLWlteC1scHVhcnQuaW5jIHwgIDQ4ICsrKysNCj4gPiAgeGVuL2FyY2gv
YXJtL3BsYXRmb3Jtcy9NYWtlZmlsZSAgICAgICAgIHwgICAxICsNCj4gPiAgeGVuL2FyY2gvYXJt
L3BsYXRmb3Jtcy9pbXg4cW0uYyAgICAgICAgIHwgIDQ0ICsrKysNCj4gPiAgeGVuL2RyaXZlcnMv
Y2hhci9LY29uZmlnICAgICAgICAgICAgICAgIHwgICA4ICsNCj4gPiAgeGVuL2RyaXZlcnMvY2hh
ci9NYWtlZmlsZSAgICAgICAgICAgICAgIHwgICAxICsNCj4gPiAgeGVuL2RyaXZlcnMvY2hhci9p
bXgtbHB1YXJ0LmMgICAgICAgICAgIHwgMzAzDQo+ICsrKysrKysrKysrKysrKysrKysrKysrKw0K
PiA+ICB4ZW4vaW5jbHVkZS94ZW4vaW14LWxwdWFydC5oICAgICAgICAgICAgfCAgNjQgKysrKysN
Cj4gPiAgOCBmaWxlcyBjaGFuZ2VkLCA0OTAgaW5zZXJ0aW9ucygrKQ0KPiA+ICBjcmVhdGUgbW9k
ZSAxMDA2NDQgeGVuL2FyY2gvYXJtL2FybTY0L2RlYnVnLWlteC1scHVhcnQuaW5jDQo+ID4gIGNy
ZWF0ZSBtb2RlIDEwMDY0NCB4ZW4vYXJjaC9hcm0vcGxhdGZvcm1zL2lteDhxbS5jICBjcmVhdGUg
bW9kZQ0KPiA+IDEwMDY0NCB4ZW4vZHJpdmVycy9jaGFyL2lteC1scHVhcnQuYyAgY3JlYXRlIG1v
ZGUgMTAwNjQ0DQo+ID4geGVuL2luY2x1ZGUveGVuL2lteC1scHVhcnQuaA0KPiANCj4gSSBndWVz
cyB0aGUgbGF0dGVyIHR3byBhZGRpdGlvbnMgd2FudCB0byBiZSBhY2NvbXBhbmllZCBieSBhbiB1
cGRhdGUNCj4gdG8gLi9NQUlOVEFJTkVSUycgQVJNIHNlY3Rpb24uDQoNCkknbGwgYWRkcmVzcyB0
aGlzIGluIHYyLiBMZXQgbWUgd2FpdCBtb3JlIGNvbW1lbnRzIGFuZCBhZGRyZXNzIHRvZ2V0aGVy
Lg0KDQpUaGFua3MsDQpQZW5nLg0KDQo+IA0KPiBKYW4NCg0K


From xen-devel-bounces@lists.xenproject.org Mon Feb 28 09:03:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 09:03:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280234.478090 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nObwL-0000E8-8t; Mon, 28 Feb 2022 09:03:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280234.478090; Mon, 28 Feb 2022 09:03:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nObwL-0000E1-5M; Mon, 28 Feb 2022 09:03:33 +0000
Received: by outflank-mailman (input) for mailman id 280234;
 Mon, 28 Feb 2022 09:03:31 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=o1tx=TL=citrix.com=prvs=051234957=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nObwJ-0000Dv-0r
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 09:03:31 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4a0bb162-9875-11ec-8eba-a37418f5ba1a;
 Mon, 28 Feb 2022 10:03:28 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4a0bb162-9875-11ec-8eba-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1646039008;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=FJj3r47xArD1XAmvMNa0En/0jxTJ4E5PWTFfRSXmNZo=;
  b=C68Um+TQh59HRx413FwjvFkCgvlTkc7qu+lOS4GOdNcYTNmif6hEI/2+
   xjIPVTM+Qg7JwO6CFcG4uoKjOY0fdQpyliVJciO5YUL192H1Y6q1T0WpF
   oXtpfG0jy9jder/07VeDooss8vY1K4pcH/2+BAvV0rPLY74m+MTZtBkmP
   Q=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 65114389
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Xztei6jnnAdOwvU0ghVePxmiX161rhAKZh0ujC45NGQN5FlHY01je
 htvCGrUafncZGb2etByYd+0/BwHvpGEndVnSQs5pXwwFCMb9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M78wIFqtQw24LhWVnS4
 YmaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV
 efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9
 TlDiXC/YR0KJPDjmM4yaQdnTi9MGu5t3ZDWKlHq5KR/z2WeG5ft6/BnDUVwNowE4OdnR2pJ8
 JT0KhhUMErF3bjvhuvmFK883azPL+GyVG8bkmtnwjzDS+4vXLjIQrnQ5M8e1zA17ixLNaiDP
 pNFMmo+BPjGSyEeNlRUVJhmp92Hn1j7fRNBrXbO9ZNitgA/yyQuieOwYbI5YOeiR9hRn0uej
 nLL+SL+GB5yHMeE1TOP/3aoh+nOtSD2QoQfEPu/7PECqEKX7nweDlsRT1TTifC8gR/gc8lFI
 EJS/CcyxYAi+UruQtTjUhmQpH+fogVaS9dWC/c96gyG1uzT+QnxLmoOQyNFadcmnNQrXjFs3
 ViM9+4FHhQ27ufTEyjEsO7J83XiYkD5MFPuewcebhFYzNnJj7stsU/BfPEgO4uan9bcTGSYL
 y+xkAAygLAajMgu3qq9/Ezajz/EmqUlXjLZ9S2MADv7s1oRiJqNItXxtAOFtaoowJOxEwHZ1
 EXojfRy+wzn4XulsCWWCNsAE7iyjxpuGG2N2AU/d3XNGtnExpJCQWyyyGwkTKuKGpxdEdMMX
 KM1kVkMjHO0FCH3BZKbm6rrV6wXIVHITLwJrMz8YNtUeYRWfwSa5ixobkP49zmzzBV9wf5mY
 MvFKZbE4ZMm5UJPlmfeqwA1i+JD+8zD7TmLGcCTI+qPi9Jym0J5uZ9aaQDTP4jVHYuPoRnP8
 sY3Cid54043bQEKWQGOqdR7BQlTdRATXMmqw+QKJr/rClc3QwkJVq6OqY7NjqQ4xsy5YM+Tp
 SrjMqKZoXKi7UD6xfKiMSgyOOuyBs8k9RrW/0UEZD6V5pTqWq72hI83fJorZ7g3sutlyP9/V
 f4efMucRP9IT1z6F/41NPERcKQKmMyXuD+z
IronPort-HdrOrdr: A9a23:AYvbd6jFfjwKg+NbA6m8t9bna3BQXtUji2hC6mlwRA09TyX+rb
 HIoB17726RtN91YhodcL+7VpVoLUm8yXcW2/hzAV7SZniChILAFugLgbcK7AeOJ8SUzJ8+6U
 4PSchD4JWZNzJHZYyT2mSFL+o=
X-IronPort-AV: E=Sophos;i="5.90,142,1643691600"; 
   d="scan'208";a="65114389"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ly4IGcUEoOlXuUEOwcEIAVfeQjD0KiaEva0JNr/6IKuCJVNRfKeLJY9IrBH3/xjs4dOTo+C3ENjgAnIvJPcg2NYfVRh6ZE0vDdi5eX0HtMuJQqjMM8mMYvbaDQwaCxysNvb7pWtmic/tFwAqfJo3ZNc2ppW6LVw2D2ARZm54c3Hzy5vnHkStEs8FnrJygCao11JXkCecn2MEVhjzNOwQvXTL1pFj/qD4fHtOpnPhH3gpTd0eYYzy7WkO5PsBZ+rhIvWiV4pFycQNXW4Kw08l08pxMM8K4hXAuaJADn0F67m/rdnqNEY4bWIZGISHqP3RyqCR52onZrM04u3cMPuAAA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=koSxmFAygem3Us67bDFcZ9/VKysWrbqwLtRmZ/bbOOY=;
 b=G2DEjAWZMYAWOYVdATut2nLwKUafh1pfoF0veAGTAvUTfi2ksOlKu4AzOz33obDoMmqi+tRBwF0CzgZoZ+zDnf2Dm1DJPSgUTdGXoGLpEJMDyds8HFIQxKOQK+VaDmCmnGo3cuePnO+2eBkgj03tvHQGrFQsr32BtBSIeCo/UCiAqSAJcgMJjMVui2nn+aiK5su9JIytnqcZzvCJOvnwt1BE0q3wLrlz9IAVq5q4svN7GCEc1JG1fU9jjXfzMKpzzHahQ8/Ol6GWXsfGrvnmzUxJh6BI30gjQR7h+Y/WomlrDqStFxQqFPIpeqJEqwaO7vmmil8a43BXXNNwy/lCxw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=koSxmFAygem3Us67bDFcZ9/VKysWrbqwLtRmZ/bbOOY=;
 b=XrcQckX90NblnvjUGurTQ2YUJXxD+4GbsFPFuxb4kMcqutSg9NwtdkktzV56my2d7cNHXCWVZ7syRmTB4QGkKd8sTI7iXsae7kmgjLx5X/hk9hMxtKbvPPuxZWeF1JDTNp5B2P1+yMdLc2JymGH831N9xp1qrd5Mr9dA1KSW3G4=
Date: Mon, 28 Feb 2022 10:03:15 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Andrew Cooper <amc96@srcf.net>
CC: <xen-devel@lists.xenproject.org>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, "Jan
 Beulich" <jbeulich@suse.com>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH 1/2] codeql: add support for analyzing C, Python and Go
Message-ID: <YhyP08GNVJxWLivN@Air-de-Roger>
References: <20220225151931.99848-1-roger.pau@citrix.com>
 <20220225151931.99848-2-roger.pau@citrix.com>
 <fdab0a3d-42b7-635e-2253-3b1ea8b5900f@srcf.net>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <fdab0a3d-42b7-635e-2253-3b1ea8b5900f@srcf.net>
X-ClientProxiedBy: FR3P281CA0019.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:1c::6) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 1a9a90b7-0b15-46a7-d82a-08d9fa992aa1
X-MS-TrafficTypeDiagnostic: SN6PR03MB3760:EE_
X-Microsoft-Antispam-PRVS: <SN6PR03MB376066E2AAA25C92CFF340398F019@SN6PR03MB3760.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: o8h98I3WcguhKzNrTzahO6qH2eyJp2ubgnuU0Qh4N1QBbzS24wZ4d1Y08XmV/3un9xTmzymGKJ0Y+IiSUTEbKzXl0ZSKJzJpxOCp5snCvRAqXcDLGlvfoM5o89G5xOIttedrctHtv0/8V8meYq/iWvmtb8szlEtv60+mAQNjN1g9S7M9lFpBlcvTn6l1v6GcJNtbXBdYViBbnRN5SwJQSlv3QARF5VoKWhHyF6bWSoxvbIUgZqIIDAa+dF4t4Dbeh1Y2itU4AXlC9okjaEQDRaI+w+rbP8dg3UP8/jT9l/C+Wh9kdUFH+51cjix9HCdKCi3jyFAePLTfgziL/X+gfKLtT4axfSKURxz1+Y3bhln7OewfxlK+A5iODVR/5CiSWJ0DJVeb05RIcHEe9Lm/QB1xXSUh3p7x+fx/fYrrytvwBEJlc9HKtJXmlJ8p2u/+H4F+ghNxERESdIECOY0BhCpyxum+g3IxCEGoKuZRfO+hZ+K2mm0oXgfA29dZzhr4ELvEvMmM9sOBbwuj48/c/sgzA8kBRJVcp6PyfeINObb0NNlkL6kzDodTwM36byV4ADLuDKXsjypkCm8VVZwaaNJrFb7I+KwIpV5fVy1tcuVZ6dcyDbZgj7t0Zm9N4nkP29OQBQqpVWnSGmJGq69pKA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(186003)(83380400001)(38100700002)(86362001)(82960400001)(26005)(508600001)(2906002)(85182001)(6486002)(66946007)(66556008)(66476007)(4326008)(8676002)(54906003)(316002)(6916009)(53546011)(33716001)(9686003)(6506007)(6512007)(5660300002)(8936002)(6666004);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cmtUbG5nRThpeUVMOHlCN1VlOGRDMldXWGxlTUZCMEZ2ZWpLY0NHTVZtT3p5?=
 =?utf-8?B?SllXT01lUWNzN1NYTHB0Tk84ZEZWWXRQM1pkSlBIcjBGcUR1ci9TVzVLSlo4?=
 =?utf-8?B?cDBxb0pjUXNscnlEdDBiWm5jaWdGd1o1UjhkOWs2SEczWDg0ZE9pRXAyZEdD?=
 =?utf-8?B?Mi9CamFsRGRtanhlUitTa2xiUWdCaWJqbmdOclFXK0VuRHB6QWRJTUlVbGhx?=
 =?utf-8?B?d21vZGJPKzZRbXhETVdiYSt2SmZJNWJrUmFRaU1qMHpsS2hqQmdidi9pUlRQ?=
 =?utf-8?B?WmgwcU9Tb05BdWNlR2JUSUFyalJHNXZsQ3lFcGdJQmNiRmxvMDE1blZ6c28w?=
 =?utf-8?B?K2FVWXZERWtpVy9NZDZkcWlvZzI0ZzVEWi8wZ2JveUdWM2NkYnJpMGR5a2px?=
 =?utf-8?B?OTNLK1llaDVXR3pUem9MOWZvZDFVSEl5cEV2RjZZbjgzWi9tUCtzdFdId2dx?=
 =?utf-8?B?b3pEeTM2QVBSNFdWclo0WnJTSlNYd0IrRStjVDdXM0h3UTBkU3ZRc1RFYlpk?=
 =?utf-8?B?UzJDeDZPL1B4YVNPck80YlZpcDU3UExPcm9LSW55TXdTL1NaZzRDYzZZaWhj?=
 =?utf-8?B?TVdCSXhYc3NVd2hQODZNbWt4dnJFWFl4dTN5QWtBbkNNbXB5ZC85RU9Tckts?=
 =?utf-8?B?aHdaSTRPS3FEUzZ4bi8wNDExNW1LQi8zSk9VM3d4QmxkbkkxVUc1K20yZ2lY?=
 =?utf-8?B?N3VIZUh5Ry9Hb0Vwd083VXlGZ3hQYW04cWxLbjFHRjk4a2o1c3pYaGxFdkx0?=
 =?utf-8?B?TmQ3UWVaRVlsWHFkTHFhdVlWK0w1QmJheXYzV0dqREwwbUQwZWxVTHpsa3JG?=
 =?utf-8?B?cTBhZjc0SnJNL01zQWJzSVZQczRLSWJ4TTM3cTg5VGk3dUN1TUEzYkJ5Tk1K?=
 =?utf-8?B?MkVEQ0tzdjBTdjFKUVZqZ0twU0EzbDB1ZVN4QnZNcGt2cjRTOGxtNTVnWk1p?=
 =?utf-8?B?WjZZNlhFUHp1aHhzYXo1Z1VLd09vVytSeU96RkMzZjFGSmhMOFcrQUhDTmRL?=
 =?utf-8?B?S1cwSFo2V2ExZU05NlRvbkVJY1FnaStRdk0vSU1rZFJ0SWZDNytnSlFQSHFm?=
 =?utf-8?B?bHpsMnh1bmgydFQ0QXRoM2srY09HQkhpSTc1TURTQXFQanhOUlpFRTI0cnV4?=
 =?utf-8?B?K204NTVDdERBRHJQUTNIc3BZQTFuVHZqQUNCU2x1ZFRiMmk0WTRYcEk1bWVI?=
 =?utf-8?B?aVhheW1SVFJaNU43RG05VldFRVprSXY5LzliWDU1anREZkhOdjZ2Nm5oWDBB?=
 =?utf-8?B?Ky9NbmkrajJqdDF5YW9CZlBEZlZVV3QzWkZrc1E5Q0I3byswaVdsK21vYXpr?=
 =?utf-8?B?dElIbHp4bnVLOHBBWlJZSlQ4SGU3STQ3V01kOFRSY2F5MmZqeTNhVVk4OVhR?=
 =?utf-8?B?NU9VYTNIMUpWK3JZY2ljaEJXWXJIcXhVZjB3VUg5czQ0V0dmQVhSQ1paeCtt?=
 =?utf-8?B?N2xZenloMCtrV2o2U1VjREJIdlJ2YkZvWGRWVGlqaDluQmNVZm53dXVLSXoy?=
 =?utf-8?B?cWE1TndVMDJ1T0loUDVJVHlQZWIwYVN0ZXRVNmQ1SEYyQnZlSUJVb0V5dWFK?=
 =?utf-8?B?aHczUWZ2UGZlT21DMjFSN1hOR3IzZmdaUFBXMEU1eVNLNE9MN1FiMlRyS0V5?=
 =?utf-8?B?NVhoNnhMRG1oQzNzNzAvbnRCbkd5ZnF5NzI5UjQ5b3BPNkNWVW9wQWtQRndU?=
 =?utf-8?B?dlA3bDJWWFVTdnFaZy9mWHltdmZ4a09qOTE0RHdnZ3NORmEwTWswZ2tNa09q?=
 =?utf-8?B?eVVSdUNKM0pNdmgwaVA1Vy9lcVhWalJjcGFYNEhDcGFhOTZ4QUNCVjJBWmQ0?=
 =?utf-8?B?TWZlUjlPT0tuMStOaGRYaDQyUUhDbUJwdDUrdWVSb1YwWUhCak96WC9CbzF4?=
 =?utf-8?B?czFBN2d0N2FDb0Ryc0g3eFA2N2N0T2E3Y1RjMWVLSWh2czZsQ3o4Uk1jQ1Nu?=
 =?utf-8?B?TzdGcXZiMHNtN1ZMTDFUTnE3dlN4cVNPbkZSNmpGcVFSbGRjUXBUSlFLQ2or?=
 =?utf-8?B?NSttMHpIRDZTcy9HR3hBS1BwQWNBSVNqOGN5K1loYWNrK3pKWHFMSHhrUmNn?=
 =?utf-8?B?dUpWZ3I3bEU4RU1aQUFDMzd2Z2VRU3ZLUFBaVi9iWnF2VEQ1R1pKRlZuVEYw?=
 =?utf-8?B?TnpBTmpWSHR0QTFIQkJQSXlhaHp3MWNONnJFWkRGSGlrYXRpd2xCL1JnWUNi?=
 =?utf-8?Q?iOk/HNcQzL/f3PPvghpZ4kY=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 1a9a90b7-0b15-46a7-d82a-08d9fa992aa1
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2022 09:03:20.4637
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DZma78ovYZis6fVlcBeFCRwZ5HMTzV5W7jpLDDdbyx5LsfQYOh6LkhBwTnZIYlX0DRttoP8ZADTAzWRLHeqq1w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR03MB3760
X-OriginatorOrg: citrix.com

On Fri, Feb 25, 2022 at 03:38:42PM +0000, Andrew Cooper wrote:
> On 25/02/2022 15:19, Roger Pau Monne wrote:
> > Introduce CodeQL support for Xen and analyze the C, Python and Go
> > files.
> >
> > Note than when analyzing Python or Go we avoid building the hypervisor
> > and only build the tools.
> >
> > Requested-by: Andrew Cooper <andrew.cooper3@citrix.com>
> > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> > ---
> > TBD: there's no limit in the number of scans here unlike Coverity, but
> > each takes github minutes and we are limited to 2000 per month IIRC.
> > We might want to not perform a scan for each push.
> 
> We don't push very often, and github is slower at noticing anyway, so I
> think we ought to be fine.
> 
> We can always revisit the decision if we do end up hitting limits.
> 
> > TBD: should we also disable the shim build? I'm not sure there's much
> > value in analyzing it.
> 
> Shim's logic is quite different in areas.  I'd say it's worth keeping.

Ack to both.

> > ---
> >  .github/workflows/codeql.yml | 59 ++++++++++++++++++++++++++++++++++++
> >  1 file changed, 59 insertions(+)
> >  create mode 100644 .github/workflows/codeql.yml
> >
> > diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml
> > new file mode 100644
> > index 0000000000..5bfe478983
> > --- /dev/null
> > +++ b/.github/workflows/codeql.yml
> > @@ -0,0 +1,59 @@
> > +name: CodeQL
> 
> As a thought... As we're considering doing cross-arm checks, should we
> use an x86 suffix here ?

It would be nice to handle all arches in the same file, but the
divergences could be bigger than the shared parts, since setting up
all the Arm cross-build env is likely not trivial.

I also wonder how to tag x86 vs Arm databases, but I guess we will
find a way. Maybe using the 'category' field for the analyze action?

> > +
> > +on:
> > +  workflow_dispatch:
> > +  push:
> > +    branches: [staging]
> > +  schedule:
> > +    - cron: '18 10 * * WED,SUN' # Bi-weekly at 10:18 UTC
> > +
> > +jobs:
> > +  analyse:
> > +
> > +    strategy:
> > +      matrix:
> > +        language: [ 'cpp', 'python', 'go' ]
> > +
> > +    runs-on: ubuntu-latest
> > +
> > +    steps:
> > +    - name: Install build dependencies
> > +      run: |
> > +        sudo apt-get install -y wget git \
> > +          libbz2-dev build-essential \
> > +          zlib1g-dev libncurses5-dev iasl \
> > +          libbz2-dev e2fslibs-dev uuid-dev libyajl-dev \
> > +          autoconf libtool liblzma-dev \
> > +          python3-dev golang python-dev libsystemd-dev
> > +
> > +    - uses: actions/checkout@v2
> > +      with:
> > +        ref: staging
> 
> This one doesn't want to be forced to staging.  The github integration
> does work properly with different branches.

Don't we need this so the `schedule` triggered run picks the staging
branch instead of master?

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Feb 28 09:05:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 09:05:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280241.478102 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nObyZ-0000qP-Mr; Mon, 28 Feb 2022 09:05:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280241.478102; Mon, 28 Feb 2022 09:05:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nObyZ-0000qI-JW; Mon, 28 Feb 2022 09:05:51 +0000
Received: by outflank-mailman (input) for mailman id 280241;
 Mon, 28 Feb 2022 09:05:50 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=o1tx=TL=citrix.com=prvs=051234957=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nObyY-0000qC-Kj
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 09:05:50 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9cef33c0-9875-11ec-8539-5f4723681683;
 Mon, 28 Feb 2022 10:05:47 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9cef33c0-9875-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1646039147;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=hXUX3ogSgr+uWXDjRyYtFEqLy0Ijii3Rs+mT7X/SVpE=;
  b=Yyt/iY1WIjSKjM1T0PuwdDYer0iKfUYzr/GMiOnLjxJ2qnDv19FNSQjc
   rusxne+RHjabAxavXSgE3dBZpT+f8FIXbCVwe2IesfbhVs7Awylh8Eal8
   WLc6jzBmtvZ64AfLbo7I5x6Fw/bucxvFIMFqUppsOyf8u16aB0wkQIY3v
   U=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 65110200
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:K510lKLaGGtQQ2fCFE+R6JUlxSXFcZb7ZxGr2PjKsXjdYENS0TACz
 2pOUG3Va/mKNGajf94jOt+1pEgEscOBzNQ3S1BlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA148IMsdoUg7wbRh2NQ32YLR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 O9qlaaNQBcCArLJlbQ9FBpGDQd9IbITrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBNPsM44F/Glp0BnSDOo8QICFSKLPjTNd9Glt35kWR66GD
 yYfQStVLxGQcQBiAxAOBr84oMOqnGfPTxQN/Tp5ooJoujOOnWSdyoPFK8HJc9aHQcFUmEewp
 W/c+Wn9RBYAO7S31j6t4n+qwOjVkkvTWp8WFbC+3u5nhhuU3GN7IA0bUx63rOe0jma6WslDM
 AoE9yw2t68w+Ue3CN7nUHWQonSJoxodUNp4CPAh5UeGza+83uqCLjFaFHgbMoVg7ZJoA2xxv
 rOUoz/3LQZIkIeoQGK2yqiRoGOSfisLM0kBeTBRGGPp/OLfiI00ixvOSPNqH6i0ksD5FFnM/
 tyakMQtr+5N1JBWjs1X6XiC2mvx/caREmbZ8y2KBjrN0+9vWGKyi2VEA3D/5O0IEouWR0LpU
 JMsy5nHt7Bm4X1geUWwrAQx8FOBuqzt3N702wcH83wdG9KFoSPLkWd4umwWGauRGpxYEQIFm
 WeK0e+r2LddPWGxcYh8aJ+rBsIhwMDITIq5C6GEMYMXPsYpJGdrGR2Cg2bKgggBd2B2zMkC1
 WqzK57wXR7294w9pNZJewvt+eBynX1vrY8ibZv60w6mwdKjiI29Et843K+1Rrlhtsus+VyNm
 /4Gbpfi40gPAYXWP3iMmaZOfA9iEJTOLc2vwyChXrXYeVQO9aBII6K5/I7NjKQ+x/UFzrqTp
 yrlMqKaoXKm7UD6xcyxQikLQJvkXIplrGJ9OiopPF2y3GMkb5rp56AaH6bbt5F+rYSPEdYco
 yE5Rvi9
IronPort-HdrOrdr: A9a23:suvc4KnlmPiQHSpqPPPySoRHH8rpDfPOimdD5ihNYBxZY6Wkfp
 +V88jzhCWZtN9OYhwdcLC7WZVpQRvnhPlICK0qTM2ftW7dyRaVxeBZnPDfKljbdREWmdQtt5
 uIH5IObeEYSGIK8foSgzPIYurIouP3iZxA7N22pxwGLXAIV0gj1XYANu/yKDwJeOAsP+teKH
 Pz3Lsim9L2Ek5nEfhTS0N1F9TrlpnurtbLcBQGDxko5E2nii6p0qfzF1y90g0FWz1C7L8++S
 yd+jaJrJmLgrWe8FvxxmXT55NZlJ/IzcZCPtWFjowwJi/3ggilSYx9U/mpvSwzosuo9FE2+e
 O86CsIDoBW0Tf8b2u1qRzi103J1ysv0WbrzRuijX7qsaXCNUUHIvsEobgcXgrS6kImst05+r
 lMxXilu51eCg6FtDjh5vDTPisa2XackD4Hq6o+nnZfWYwRZPt6tooE5n5YF58GAWbT9J0nKu
 9zF8vRjcwmPW9yV0qp/1WH/ebcHkjaRny9Mws/U42uonVrdUlCvgUlLJd1pAZDyHo/I6M0k9
 gsfJ4Y0Y2mdfVmHp6VNN1xMfdfNVa9My4kEFjiV2gPR5t3ck4klfbMkcAIDaeRCdg18Kc=
X-IronPort-AV: E=Sophos;i="5.90,142,1643691600"; 
   d="scan'208";a="65110200"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=GLGm5RMT/g/6bT/8OFzTaUbQd/NnR8jXrdoqEizTJShe+Clg74+qdaNcBl+uDXu6tKk8vBREW0h5ZOwtgT7iywvgkj7pYq+nUsRTc5TkYlFVEveUD3PFXOKQ4c9h+uzF/hJHYpEAzom7bYOX6n03BpBxvzN+y67bObnOVfJQMP9YiqMB62x4zpAyFKvVjQtlXSaQ7FVVhwwWRqviznF5Q/Rgh1VzA7B3ZB73NY4y+sPuGotBMooFGCFhtYuXLqWv+l1aphTmipcVrclN7hotjtuvda0rnhK8jxwts0Y0E+Lpf9f2DLRI6uuco52+fC1DwyXVlj+Pe/HB2B30TzewMQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=hc512v+N1e9+TYq6gaRrUt/eJWWCxP41BROPs5SHyhA=;
 b=UgaMHLpBix+kBNkyDppjNEMkwErrBFdcceO39z76IP0R/8pH9Oup9cJMkO+W7JfN7Awh+zDvEv3oild4s/S7H9X8E12lAtwtKHHyYFh4M1wHXZ3a7fJWXAWBL8WBkt4e6ubfc5vMGjMAAeso39mcTRPgtTdOxyu2bEf45SR4p7Pi8GTOQv6xl4BATHahLJDIx0yDtJYc7Dij9obULdc8F/wEO0rKSnUBUlZr8J9tM4eaXa4o+6akA8NWd8u9gqaxgDkcJoxrAbyMPU8VwLOuqemelELEXIYqqfBpqrhlfB9K1i5b/6IWxqmulQ/PYPzFbJDBgLrCFZSjL0TByafKBQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=hc512v+N1e9+TYq6gaRrUt/eJWWCxP41BROPs5SHyhA=;
 b=JFz/XuxesowsWQZVgVjWuEgBjF6j1QIPCB1Ad1BqfGBf3ahPXk6g5b3duvN4GRO6iPBrgZIrEL2UbchM8ieyGfBBDJMeadCgTtM1egLxYNrEI/ED2RVyI/A8spSz+40C9Q3/ntdgkPdgmRa9r7zNt6WRLBgU/R3haZcUGt7lYnU=
Date: Mon, 28 Feb 2022 10:05:26 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, George
 Dunlap <George.Dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, Julien
 Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Wei Liu
	<wl@xen.org>
Subject: Re: [PATCH 2/2] codeql: ignore Kconfig
Message-ID: <YhyQVqTOCErd7j8+@Air-de-Roger>
References: <20220225151931.99848-1-roger.pau@citrix.com>
 <20220225151931.99848-3-roger.pau@citrix.com>
 <8b7dc698-3fb2-3ab4-0998-ecfd35935183@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <8b7dc698-3fb2-3ab4-0998-ecfd35935183@citrix.com>
X-ClientProxiedBy: MR1P264CA0092.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:501:3f::11) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 746a4404-ed38-408d-1718-08d9fa99789d
X-MS-TrafficTypeDiagnostic: DM6PR03MB3963:EE_
X-Microsoft-Antispam-PRVS: <DM6PR03MB396307FB71A8FE7C1B869B0A8F019@DM6PR03MB3963.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: CKMEdMY2JNC4XFjanSSg0V5sQXsgq+tz4fxA4DSfwrH453iaS+rjxPGCU6+TT07zaXbG+0cWSLRVjdtukIyPQ1pe097Su2C52yknmjh8Qgn4X7zvEbIkcVzN1kvRas0yNurEdgROIiwW6iWR+05xnSPeGRtlovWuWFP8hwXlv9tpfBL+Y2Xt793MV8/fymlLWqhqr4P+EZAGp1QXjEN9yWhvUqFhWuE22if1xO8EEOJ2RfGQrdsY/jVwfpTzLa2q1UiQY1oZJo0cCFgRl6mhi0fuWWe8s4hHqzQjQYL9OprRafduiuZIasEhPO+tI8zFfTlxKo6WOlzZuoMmOvmXsjR2ZhnQqO8NLpMklM8y56XUsHIzVKQkb51lGrtha76vL5AwYwOrnQ+e+LjJSxPfaVxv/8sNJsHS3doh8O4Oe1apUnwXkuy2b4rn6Ws71jEMuKMkN3LvXhz5egOi46ayQhBfq9ubVQhQ04JmkXao6Pc/5TWDS2oNDrJaWhghZE61AOC+6m5NwhK9JAwJBj0Nom+HL5ac5rli3VLgilSZgpMLM9T2uIZqHnIBNJuV5VDHCNUYz6tVGeAedirm/k7pRD4RwB/emr04c8WU3J2pXsIxIXQPNPLXm+oGdRWnVm/K9noLJHqXVfO1W9lunC1bYw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(4744005)(26005)(54906003)(6636002)(83380400001)(186003)(38100700002)(6862004)(86362001)(66476007)(66556008)(8676002)(2906002)(66946007)(4326008)(9686003)(316002)(82960400001)(508600001)(6506007)(33716001)(5660300002)(6666004)(6486002)(8936002)(53546011)(85182001)(6512007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S3JmYTc1c1p2aHBlYy9TN0J1K0swRjc1dDZXcDhGRFFCWjIxZEx5YTdwZ2xB?=
 =?utf-8?B?OWdYQ09hbTlqeEIyNXNzT254cjE0MmlPRmVyalQwd25FTG1PWlZ6N1JTOEdQ?=
 =?utf-8?B?YnlKYWdZZTdQR3UyRWNmRm0yRThjeUNLa0ZVdWc4QjhQNFJaVzFJZWJzMjB1?=
 =?utf-8?B?WGtibkozMEZmMTVpUG92bUNtRzRnL29ob2JDZ1o0RzNCOVlVT1hIMmt3SHJ4?=
 =?utf-8?B?NnRadWZQSUJ6bUhoK1FaOWlIZ3dqTEREVWJZS3p5dGtxQ2lrUDJmT09kUm9k?=
 =?utf-8?B?WmFmUmpFMDFVb1V0bVBtMlVGKy9CVC9zNkkvQXJCTG5FSVRuR0NXTXk2dDRv?=
 =?utf-8?B?cmtPYjNDKzN5dStreHh3Ry9xYTZGTmwweTRUQUtSZ0NZa3ZIUEpOaHJLWlRr?=
 =?utf-8?B?UFZBRzI2NmJycERPWEsxOUxjU2xQcWVGd3Z1NUVUaGRUK2N2OUZ4VSsrSldl?=
 =?utf-8?B?eGdNeEZBZHpFNUNaTlFpMmJpOGp3Uk5PeHZ0Z1hGdGlWWG1JWkFiaGpONjR6?=
 =?utf-8?B?TjNXSkc1TllXbVlwMGQ4cGZDcUFIZ0pHT3hLMm5mSXR0dkQwT1NsU3JzWHVs?=
 =?utf-8?B?VVZUanZiSGRtMTZwVUlDMmJsK3NuazRkQnZWSzNyWEJJRDlDVXltam9kTEVJ?=
 =?utf-8?B?WTc2VnUzSmpXQlNSaVEydXpCcEdKUTFySXE3SWlDQkVVUkFSOFNuOExleDlH?=
 =?utf-8?B?d2djbVBpeFg1bDNoQzVId0tlZElQQ3pQRnl4ZmIwdUM1OWZYQVZreHVRTHNE?=
 =?utf-8?B?a0ZaVldjNllRUjhyRDJaQmVjemgvMDVrdU9pZVJEY3AzK0hSaDQ1cGZ1T2Nj?=
 =?utf-8?B?N0k2UDBjbFBmVDI4YWFRODlaODRZM2Jic3NQOGlDMWc2MW9INTFSOE1xanph?=
 =?utf-8?B?OGRlbjdhRmVnZEpGdE92TUVsdWxteFZzZHZ2emFTUmtPMFAvWllKWGVBYmdT?=
 =?utf-8?B?TFdkcHZRS2ZUbDRmUFFGMlFsTkgwdVlvdEhiSk8wUm12VEFiOWVBZDM3Wits?=
 =?utf-8?B?YmJSOWRiYkVFMlY5ZmFpbnY5V25yaUJ2dGx3MFhPTDhUSkNpd08yWGc2b2Js?=
 =?utf-8?B?YXB6WFpXT2wwZ0hIUDEvZkpleTdPZlAyYmJ3OHlFdlU5NWlSM2phWjR0M1Nj?=
 =?utf-8?B?NWdCTWZVRU9HYTFUT0pweVVpNkdVbWRrYmY0ZmxwdXFlaVBuZHNhR2R3anE0?=
 =?utf-8?B?K3kveC8vaDU3Zk0zOU9JcklTbFFsV1lIL3Z0MUZRTER4WW95R2pCSkdZOFEy?=
 =?utf-8?B?NFJsck9LbVBOa2JmcWNtL2c1cS82ZHU5aTBPWmc1Ri9zODBoQzVOaFprdWZ4?=
 =?utf-8?B?VTVLckdXQ0puNWhrckVScFZzVS9VaFB3T0VHb3hBeUVUOUJxN0lJajBscDZu?=
 =?utf-8?B?ajVEV0ZWWW5LcFN1dEhPaHdTQVMyUmxFN2IvNXZKV0xCcExBd0VyN0tPTk1E?=
 =?utf-8?B?NmZxRXhQVytNNUxCZ3JlQno5MS9BZ0c0MmJ6dDZIUTFRNUx3SnF4M1d5eWZJ?=
 =?utf-8?B?Yk1GYkJYbzYyVklEZlFiWjV1b2UvN3JSL3hFL29VMFRmWDhneEQrSnJVWmQy?=
 =?utf-8?B?REl0c1dISnBHUzdlanA2NGZmZ3JlZEx5WTJWVUNFU0FvYnhMR3A5dUVrZ0l1?=
 =?utf-8?B?NzJ4RENRWGxtaFpEZ05HbldzY3Z5d1lia1ZEUnZ4ckQyaVVJQkNWbk1lL3pT?=
 =?utf-8?B?ZWk1M2wxVnJIUXM2OWtmSk5yTGEzcDdIcG9VVFdoZUdid2VoY3gycEtLa2hk?=
 =?utf-8?B?SWIwZTAzZmNsaUF1ODNQS1VSOVZsYlViYlZQczZQNzQxLzQremhweGRDZlNs?=
 =?utf-8?B?NkJ0M0psWmRxbE40VmVCQlBwUVFkUzBlRnZveVhHblBXeGlmTUFYZ2VMdGRl?=
 =?utf-8?B?Y3VQb2VJOEpwMHRVdlFoTW5zS2QxS1dGYzJBTUFGdEU2WFIyRUZ6blByK2NT?=
 =?utf-8?B?VnhsNHFYY2FFY0hmWWMxcCtGNmJrelM0M0lNY3lrNWNjb3N0Y2Y1eXlWSFda?=
 =?utf-8?B?Rk45Vi9TWGtaTGIwTzRET3RxdE1NTmpvOXdJWDFaQldwQjhnM1lLVC9oaDFy?=
 =?utf-8?B?OThzT1FyaU5JUTVKOUdCVDhnV1FQNEhhaDh2NThCLzV6KzZlOVNhUHJOdXc0?=
 =?utf-8?B?ajlWb0FWZ0pxY0xYc3VDNncxSGUwZ2dnR0d4bjM1UkxYemo3dVRNRnBVKy9B?=
 =?utf-8?Q?1iIsnisVhLftMxLPWvQ8Eag=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 746a4404-ed38-408d-1718-08d9fa99789d
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2022 09:05:31.1230
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QGq3H6arJ4LH3G7vGH2umn6sUe34qVKxfWn4gAbwLWQZfoKUr143qOpDvnS6XgUIMBH6qyaweYpOsxp5kkjJag==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3963
X-OriginatorOrg: citrix.com

On Fri, Feb 25, 2022 at 03:39:22PM +0000, Andrew Cooper wrote:
> On 25/02/2022 15:19, Roger Pau Monne wrote:
> > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> 
> I agree with this, but it looks like it wants to be folded into the
> previous patch.

Can do. We also need to add
tools/firmware/xen-dir/xen-root/xen/tools/kconfig/ in order to prevent
Kconfig from the shim also showing up.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Feb 28 09:19:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 09:19:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280248.478112 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOcC8-0002Qi-QI; Mon, 28 Feb 2022 09:19:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280248.478112; Mon, 28 Feb 2022 09:19:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOcC8-0002Qb-NV; Mon, 28 Feb 2022 09:19:52 +0000
Received: by outflank-mailman (input) for mailman id 280248;
 Mon, 28 Feb 2022 09:19:51 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nOcC7-0002QV-Px
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 09:19:51 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nOcC2-0001R0-Jv; Mon, 28 Feb 2022 09:19:46 +0000
Received: from 54-240-197-230.amazon.com ([54.240.197.230]
 helo=[192.168.13.237]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nOcC2-0000JB-Cw; Mon, 28 Feb 2022 09:19:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=voGZEd5Eve9O3Bg1Sl0I79UAX6SsPDaF/oSzL2dpFQk=; b=T/O1XNumGBPHw/dKcdYQw1fTvx
	TA1IDlQuG6oODT8znCN34jW1oj1sm7Tks62vIIXToVkciZFci8IR69IFd8b80apIBtvojC4MNYGkD
	v6mMTShiOdxt2TWr/4sOGxHHgfcaVPKStFtAXMi0LxrYdVcW/4G7aNFRC2iKxE+h9AsU=;
Message-ID: <16bef21e-42b3-c271-81ab-1d87453a0fdb@xen.org>
Date: Mon, 28 Feb 2022 09:19:43 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.1
Subject: Re: [PATCH 1/3] xen/arm: Add i.MX lpuart driver
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>, sstabellini@kernel.org,
 Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com
Cc: andrew.cooper3@citrix.com, george.dunlap@citrix.com, jbeulich@suse.com,
 wl@xen.org, xen-devel@lists.xenproject.org, van.freenix@gmail.com,
 Peng Fan <peng.fan@nxp.com>
References: <20220228010711.11566-1-peng.fan@oss.nxp.com>
 <20220228010711.11566-2-peng.fan@oss.nxp.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220228010711.11566-2-peng.fan@oss.nxp.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Peng,

On 28/02/2022 01:07, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>

Can you give me a link to the specification and/or a similar driver in 
Linux?

This would help to review this patch.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Feb 28 09:24:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 09:24:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280255.478124 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOcGz-0003oE-Eq; Mon, 28 Feb 2022 09:24:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280255.478124; Mon, 28 Feb 2022 09:24:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOcGz-0003o7-Bu; Mon, 28 Feb 2022 09:24:53 +0000
Received: by outflank-mailman (input) for mailman id 280255;
 Mon, 28 Feb 2022 09:24:52 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nOcGy-0003o1-OY
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 09:24:52 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nOcGt-0001WT-Uc; Mon, 28 Feb 2022 09:24:47 +0000
Received: from 54-240-197-230.amazon.com ([54.240.197.230]
 helo=[192.168.13.237]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nOcGt-0000ow-NY; Mon, 28 Feb 2022 09:24:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=J9TazujMzOd3uEITzkilChYyt8P6hhqqD1QqS3i3a2M=; b=vtrINLSuUEd2RARdFBGPLYSB55
	Ba/i7CfTx+lh8yYS6dQFHiyKcjIXoOSxzSVapWyQZlsf7s/elkIJvB+fuZ1YHK32WgYnGckfrJCpL
	nfIwrH9HTP+PhYevIuXuRWvtovNRBlaXeafPTflBd1H5jCX2YL2od8TzXQUf6FUu0tqQ=;
Message-ID: <ba77dc96-d421-b775-d5fd-99dc3ea2dfad@xen.org>
Date: Mon, 28 Feb 2022 09:24:45 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.1
Subject: Re: [PATCH 2/3] xen/arm: Add i.MX lpuart early printk support
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>, sstabellini@kernel.org,
 Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com
Cc: andrew.cooper3@citrix.com, george.dunlap@citrix.com, jbeulich@suse.com,
 wl@xen.org, xen-devel@lists.xenproject.org, van.freenix@gmail.com,
 Peng Fan <peng.fan@nxp.com>
References: <20220228010711.11566-1-peng.fan@oss.nxp.com>
 <20220228010711.11566-3-peng.fan@oss.nxp.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220228010711.11566-3-peng.fan@oss.nxp.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Peng,

On 28/02/2022 01:07, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>   xen/arch/arm/Kconfig.debug              | 18 ++++++++++
>   xen/arch/arm/arm64/debug-imx-lpuart.inc | 48 +++++++++++++++++++++++++
>   2 files changed, 66 insertions(+)
>   create mode 100644 xen/arch/arm/arm64/debug-imx-lpuart.inc
> 
> diff --git a/xen/arch/arm/Kconfig.debug b/xen/arch/arm/Kconfig.debug
> index 35ccd13273..9ecb446b3a 100644
> --- a/xen/arch/arm/Kconfig.debug
> +++ b/xen/arch/arm/Kconfig.debug
> @@ -55,6 +55,20 @@ choice
>   			selecting one of the platform specific options below if
>   			you know the parameters for the port.
>   
> +			This option is preferred over the platform specific
> +			options; the platform specific options are deprecated
> +			and will soon be removed.
> +	config EARLY_UART_CHOICE_IMX_LPUART
> +		select EARLY_UART_IMX_LPUART
> +		depends on ARM_64
> +		bool "Early printk via i.MX LPUART"
> +		help
> +			Say Y here if you wish the early printk to direct their
> +			output to a i.MX LPUART. You can use this option to
> +			provide the parameters for the i.MX LPUART rather than
> +			selecting one of the platform specific options below if
> +			you know the parameters for the port.

Plaform specific early printk are deprecated. So I would rather prefer 
we are not introducing new one. Can you adjust the description to remove 
any mention of platform specific options?

> +
>   			This option is preferred over the platform specific
>   			options; the platform specific options are deprecated
>   			and will soon be removed.
> @@ -186,6 +200,9 @@ config EARLY_UART_CADENCE
>   config EARLY_UART_EXYNOS4210
>   	select EARLY_PRINTK
>   	bool
> +config EARLY_UART_IMX_LPUART
> +	select EARLY_PRINTK
> +	bool
>   config EARLY_UART_MESON
>   	select EARLY_PRINTK
>   	bool
> @@ -283,6 +300,7 @@ config EARLY_PRINTK_INC
>   	default "debug-8250.inc" if EARLY_UART_8250
>   	default "debug-cadence.inc" if EARLY_UART_CADENCE
>   	default "debug-exynos4210.inc" if EARLY_UART_EXYNOS4210
> +	default "debug-imx-lpuart.inc" if EARLY_UART_IMX_LPUART
>   	default "debug-meson.inc" if EARLY_UART_MESON
>   	default "debug-mvebu.inc" if EARLY_UART_MVEBU
>   	default "debug-pl011.inc" if EARLY_UART_PL011
> diff --git a/xen/arch/arm/arm64/debug-imx-lpuart.inc b/xen/arch/arm/arm64/debug-imx-lpuart.inc
> new file mode 100644
> index 0000000000..7510210d46
> --- /dev/null
> +++ b/xen/arch/arm/arm64/debug-imx-lpuart.inc
> @@ -0,0 +1,48 @@
> +/*
> + * xen/arch/arm/arm64/debug-imx8qm.inc
> + *
> + * i.MX8QM specific debug code
> + *
> + * Peng Fan <peng.fan@nxp.com>
> + * Copyright (C) 2016 Freescale Inc.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */
> +
> +#include <xen/imx-lpuart.h>
> +
> +.macro early_uart_init wb wc wd
> +/* Already initialized in bootloader */
> +.endm

NIT: I would add a newline to separate with this macro from next one.

> +/* i.MX8QM wait LPUART to be ready to transmit
> + * rb: register which contains the UART base address
> + * rc: scratch register
> + */

The coding style for multi-lines comment is:

/*
  * Foo
  * Bar
  */

> +.macro early_uart_ready xb, c
> +1:
> +        ldr   w\c, [\xb, #UARTSTAT]   /* <- Flag register */
> +        tst   w\c, #UARTSTAT_TDRE     /* Check FIFO EMPTY bit */
> +        beq   1b                      /* Wait for the UART to be ready */
> +.endm
> +
> +/* i.MX8QM LPUART transmit character
> + * rb: register which contains the UART base address
> + * rt: register which contains the character to transmit */

Coding style:

/*
  * Foo
  * Bar
  */

> +.macro early_uart_transmit xb, wt
> +        str   \wt, [\xb, #UARTDATA]  /* -> Data Register */
> +.endm
> +
> +/*
> + * Local variables:
> + * mode: ASM
> + * indent-tabs-mode: nil
> + * End:
> + */

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Feb 28 09:27:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 09:27:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280264.478135 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOcJR-0004Xn-W2; Mon, 28 Feb 2022 09:27:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280264.478135; Mon, 28 Feb 2022 09:27:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOcJR-0004Xg-Sn; Mon, 28 Feb 2022 09:27:25 +0000
Received: by outflank-mailman (input) for mailman id 280264;
 Mon, 28 Feb 2022 09:27:24 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=oRDO=TL=nxp.com=peng.fan@srs-se1.protection.inumbo.net>)
 id 1nOcJQ-0004Xa-KO
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 09:27:24 +0000
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02on0611.outbound.protection.outlook.com
 [2a01:111:f400:fe06::611])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a23f3363-9878-11ec-8539-5f4723681683;
 Mon, 28 Feb 2022 10:27:23 +0100 (CET)
Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11)
 by PAXPR04MB8878.eurprd04.prod.outlook.com (2603:10a6:102:20d::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.25; Mon, 28 Feb
 2022 09:27:21 +0000
Received: from DU0PR04MB9417.eurprd04.prod.outlook.com
 ([fe80::552c:ed46:26dc:77cc]) by DU0PR04MB9417.eurprd04.prod.outlook.com
 ([fe80::552c:ed46:26dc:77cc%4]) with mapi id 15.20.4995.018; Mon, 28 Feb 2022
 09:27:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a23f3363-9878-11ec-8539-5f4723681683
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=VKaB+L5xGNTzw+2XatZXHvvX42bz9+W49jqRjurSuhAzJlW7kv46njEYU41sxKtp1Tt5XLYa65LGFtWb9eZ3xspUZdJRnhCPQDXsscWNYg0v2KC2/YY1j0kF7y6LXbFX9hWwdvAlmSC/+BLcmGGcjR55Jl/mRhufh5Ye4StKB5I21U35Zz044GMBKGZByuKZHzF11clj+frULgTgqdshAoKA2sgjw0vOdFs+XJ5CwnZkcgJ37qSQYEXuRbsuIMGvgqlJ9R5fJK0RQNw1PdJEBBH0NfWdOv4zyZ9cZwXDpJeBo2Y1+q88/VinqrJm90HQX2oF2KYlW+UUMExxmxCWGg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=kkAF/lKm2202ZxLaHYCWL2EGRF1rrx+Yawu3jgIjuw8=;
 b=L6iAUOI3dyBJGd8uNQpCUUWI7G5KPFwGlrEobKzOdCQu7FSt0u3jtmHJKSyOaCO4y1rVYpzU005JJpdO8otag4wBkkg5Z3UHG0SshSBuMhfcY9jVVGtUSGRK883hUw67T9RyZYHweOEc9vRY+/J43x8ziUStfmqjhzELWoS1+a4gJu1knvVQUnUX0WED0ChUZYHfaX4ZMmtYjLXkMBAW9Ccb2EwCscNt1ntNOoO+jGTDFMqeODKeG8f5wFrSVfmZLtqQjBGR7VYJr+ZsV5MG6RXIZZmw2faWu0Czec3SLyojh0pwRzv618wuaKUg3SR6Iu0JuFNsgGKU2Qsy/vIvcQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass
 header.d=nxp.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=kkAF/lKm2202ZxLaHYCWL2EGRF1rrx+Yawu3jgIjuw8=;
 b=KEkrNHKm2egh9q0taquRrfjLLHGyjLA8yeFqb+M4hA7YdILeIg5/2Jsj3OjoTLBRqJ8fWXn6ebHIiW4MSt9IS18htTD51ERlEaxp8VUa5hkycNz2qvF+REkzT+cmfXacfF6no0rkdJsn0Smw3DqgiuOjp+lukJqvngNBJfBQq1Q=
From: Peng Fan <peng.fan@nxp.com>
To: Julien Grall <julien@xen.org>, "Peng Fan (OSS)" <peng.fan@oss.nxp.com>,
	"sstabellini@kernel.org" <sstabellini@kernel.org>,
	"Volodymyr_Babchuk@epam.com" <Volodymyr_Babchuk@epam.com>,
	"bertrand.marquis@arm.com" <bertrand.marquis@arm.com>
CC: "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
	"george.dunlap@citrix.com" <george.dunlap@citrix.com>, "jbeulich@suse.com"
	<jbeulich@suse.com>, "wl@xen.org" <wl@xen.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"van.freenix@gmail.com" <van.freenix@gmail.com>
Subject: RE: [PATCH 1/3] xen/arm: Add i.MX lpuart driver
Thread-Topic: [PATCH 1/3] xen/arm: Add i.MX lpuart driver
Thread-Index: AQHYLDnx328AZbWyq02DiYDlO7tvpKyosDCAgAAA+dA=
Date: Mon, 28 Feb 2022 09:27:21 +0000
Message-ID:
 <DU0PR04MB94177B6A7BC34EA6590FF37B88019@DU0PR04MB9417.eurprd04.prod.outlook.com>
References: <20220228010711.11566-1-peng.fan@oss.nxp.com>
 <20220228010711.11566-2-peng.fan@oss.nxp.com>
 <16bef21e-42b3-c271-81ab-1d87453a0fdb@xen.org>
In-Reply-To: <16bef21e-42b3-c271-81ab-1d87453a0fdb@xen.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=nxp.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 20c05cca-ee7d-48b4-3614-08d9fa9c85bd
x-ms-traffictypediagnostic: PAXPR04MB8878:EE_
x-microsoft-antispam-prvs:
 <PAXPR04MB8878F1DBA6656C92BC04E0C088019@PAXPR04MB8878.eurprd04.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 agCmE55MEYyk/+yYgR2QxgJ3BT59pNOhZGqEGreU6sve1hBXS7t2opLDjVfj+EtkrvRVrG/QclcnAz5cfq1x+ahyIv/Z4oTAbGytEDvEsVNGUIuZkLcf6Ab3RxcWlHKSZ/r002oQL7I37k/LQPTWugZsyw1jA1KtJVFOAxxnfnAkPbeEHrP/IdYrbLHHfFsXIaj5JHY5IXhCc546MYPp46saL3nuyVbhUeUy5AT5RDVmzDs4U457SA/PaW5SrjyDIBSltT7ISxmCzHsNxqKC7ZQIE1ojsMOvoWI5gjp1lJphgc3hqhx5tcnynApbL0dAtc/h/JYN4rcJgr9zAAbBHrtUlXGZ7jbVdyaY+cFXMnSNyqQYOnaSc4okR2uSPG1QWcRQh0uksEZWvi6Vfx6MW3DaATRFO7naLVc+FcGPQwuxbrmPGIbjx/kwsvZZJCIZRGgjGfgfvRHgEXokMI0CBfv/Lw4vOcDKiEV1vmiXUieLER+d5b9an8xBqVnFYOsPk/ZphIV7pAHw1iOgCPUznsYpGBaxVUs2YUTPzpxte7o2YPGeM48i69ovpqFUuC1FDgZ01dF9eL5R0vWvqyGnXHXfkj58iEGy8oEuJTGw8P2k/SLiGxg3pFANqgPo0shhHdKyMq/5KFk0xlphwIXeZSfaKKdhrvVMUdjYuDI5eAg9Xc4chuehQhe7HegfUBtS4breJQjZm909/BoHV6QEuwXVae6FhOxcJJTLzxsoQPNdn7dnFp71anqk52DxbzGpCzUBSpFean7tnmeZi/tn3nWI2K3zB1920NpDKZZw0Csv6mVc6IN13FMGtUc5KE99LLIz0US6akU8rXnud4wNPg==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66556008)(66946007)(64756008)(966005)(508600001)(71200400001)(55016003)(122000001)(8676002)(4326008)(38070700005)(76116006)(66476007)(54906003)(110136005)(53546011)(6506007)(26005)(2906002)(9686003)(7696005)(186003)(7416002)(86362001)(5660300002)(316002)(66446008)(38100700002)(8936002)(33656002)(44832011)(4744005)(83380400001)(52536014);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?YVdmT1JYM1BZckJBQnBQdHlFZm56NC9qckd2dnV5NFVyWW80MGZZZGZGelE2?=
 =?utf-8?B?MU9VYlRkRGNmeGN2MStFMUt0VXJSZ2EwR3VZTEpwNUpqSXBKMVhRcWR6Y2FZ?=
 =?utf-8?B?RnlRWlA3QWtnd0dkV3lsUEhDaW9RQU5OY3ZCU1g4WHFJeVcwZGRhQ0FpRWF2?=
 =?utf-8?B?ZWE4NmU1RDY3QlNYbnI3SEdOOExOSzdZUWJ2MEpKZFBvRHNzcWxSN3I5aHNG?=
 =?utf-8?B?MCtEYndJeDZaMHREbVRXalp1Tk9wVzYwUUIwOVhEa1Zib2NCV1h5S0pzck9O?=
 =?utf-8?B?THY0YThYRGJFWlRwTHY5THBTRDVMTFB0VjNEVmVCZWlFeVkwTUpPZFAyb1Fz?=
 =?utf-8?B?Wnl0RmFmaGQ3UEFucHB3OXN4b0xEWXc1Ylp4bXR0Ykd0SFp0SHFoWjZDcHhk?=
 =?utf-8?B?NVZrU2lXblRoU1A4OUJMWko3a0pQcnEvUW5yRjh4SlRxNS96RHlWR0haeXRw?=
 =?utf-8?B?VThCdks4SnlZaVBwUHVmcW94bjJQaW9jamVxNnBZeDByUVFjd1poeFhDcmxo?=
 =?utf-8?B?c3A3dzM3Zkt3cEdHV3dZVlcwdkpkY2tMTzhnY0p2c2dzYjNGSFNMWHk1RWpW?=
 =?utf-8?B?cHRtL0Nndm9QQ0NwTHpzNnR0MWRBbXhkNGhKbHRVN0NtZmpWNk5GNWQ2VU5n?=
 =?utf-8?B?emY3dCtYN1JlRzMwMzB5YVdoTDJodENoOFlVNXRXeUZVZW5RZzhpdENQR2dh?=
 =?utf-8?B?T1lUSmpzc285SmU0RUxNd1FTVVJtV0orTzROUi9vVWQ3MVBWRUtUVzB1THVM?=
 =?utf-8?B?TVl4dmphVXY1ejBEcWhEY1FvUGt2dDNOaFhLVkN3TVJWdmJ1MzVDNzUyb3Y4?=
 =?utf-8?B?cTludUx5RSttclNGdmo4bmRsZlZLMEtRc0JHZHZoVHBGYmVhQUo1ck94Si9D?=
 =?utf-8?B?RWIvUU44Ymxua0R5UGF5R0RhL05XdTQySldpSWtraFdHMTBjN3JVUVoybGta?=
 =?utf-8?B?Z0dUOUNSQVkzVzRPWWNmK0hjczdmNUEvOHROeGh5alJuSHk4cWRKK09Rajda?=
 =?utf-8?B?S3VzYnh6cWREM0FIdDhIZU5SbUVOYUFSWlpLUkU1YXdsMUgvZGgrL1ZFY1cy?=
 =?utf-8?B?Zm02NkxIdXh0Y2EvRDhFcWducTRlWktQb3BVOUhlaHZBQStHZ1ZvVHNabnRW?=
 =?utf-8?B?WEo2T1pISFAwZzNWQmw4STN3UE50QlBVUk94UEdSUWZ3TlRweDdGT2VwM3cr?=
 =?utf-8?B?M29iLzVxS1Era0JoT2lnaEtWVGpKQ2xYREZ0VFNlYXdDK3UxMmplTDVNT1ZC?=
 =?utf-8?B?RzBNc1J1Z0Q5dmY0a21Sbi9RSHI2bEcwcER6OWYxc2lnTEM1Z29PWkQ2SDZ1?=
 =?utf-8?B?NFd5eDRiM0FmQy9PWjlrdktTd0dXNzlQK3NrY0VidVk1eFpoL3drbHhYZGxY?=
 =?utf-8?B?RE9rMXBzblM5VDlBMUd4SldVclN4SHhEcmpndWhHRnI3MlpWZjJkM21pSURT?=
 =?utf-8?B?ZXhhUWJSQXEvOURGeDBIL2QwUWEzM3Jma2o3Z3ViYTFhV09tSGJQOC9VWk9W?=
 =?utf-8?B?d2JjMGI4V2lXdSsxN3hFaCtPOUNnZ3IvbXlmVStIVUZtbVk3MzQ4b3pDZW03?=
 =?utf-8?B?Qi85YzV4SzBCUnB2T3ViT3BmZWd2VDRRK3FVQ2RRZ1hrVTlIdDBVeXJISks3?=
 =?utf-8?B?VVg3NjI5L1lGUjZSYldzYXhVTzBBc3luMm1US1ZSUko1enA1MlppUm1NeGFM?=
 =?utf-8?B?MjVIRndjZHM4NDNnNTJmSmxnNmJrOTRCVWFjVGVyUklVcjV4NWhuaVRmYkRk?=
 =?utf-8?B?QUhSSDVwTDFyYUlDcG90UlhHT1U5OFZ2VmJkRjBIcnJmemE4bERqd0g5eTBW?=
 =?utf-8?B?RVRIa2FJc0J3S2hXM01RK25MWng5NURubGJMQVZoL3pYKzNFWUVGQTc5ZjBO?=
 =?utf-8?B?VHRHcEl1elNSUnd2WjhncFU4S1lJV3BtUFcrVlhZbWJyTS9QcFU3eVpVT0lM?=
 =?utf-8?B?bTJ5Uk44ZzdTNUxNUklSVEJTUzNDN2NqVWpPSVFSdzZiNTJkQUkzUlNUb1NL?=
 =?utf-8?B?UXdtR1J6MmpkNDFwQjAxdEo4c3krVUNMK3JOVXdrUThaVEszeTkzeTNJWGpW?=
 =?utf-8?B?Y2RES1BqUkVSTXJ1Q0VDWnFkV3pVL2hVVmFublIrNEZSODBYVU9XRll1bkc0?=
 =?utf-8?B?UTJvMy9XNUdaL0Q0ZjBMQjYzVEhWY1BIQnNJVE1XdWs4UzhTbnlDUXh3WVJv?=
 =?utf-8?Q?fjsnxQi4hlTD1AP29UamG4c=3D?=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 20c05cca-ee7d-48b4-3614-08d9fa9c85bd
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Feb 2022 09:27:21.4310
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: +HuHj2x3kHTZrx6BVOg0C65TTdUL7DO+w9FSQfUmEP15sSP+QljIk9MThX3n+HOggBeaCMTQbgssEZxGlPadKg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8878

SGkgSnVsaWVuLA0KDQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggMS8zXSB4ZW4vYXJtOiBBZGQgaS5N
WCBscHVhcnQgZHJpdmVyDQo+IA0KPiBIaSBQZW5nLA0KPiANCj4gT24gMjgvMDIvMjAyMiAwMTow
NywgUGVuZyBGYW4gKE9TUykgd3JvdGU6DQo+ID4gRnJvbTogUGVuZyBGYW4gPHBlbmcuZmFuQG54
cC5jb20+DQo+IA0KPiBDYW4geW91IGdpdmUgbWUgYSBsaW5rIHRvIHRoZSBzcGVjaWZpY2F0aW9u
IGFuZC9vciBhIHNpbWlsYXIgZHJpdmVyIGluIExpbnV4Pw0KDQpodHRwczovL3d3dy5ueHAuY29t
L3dlYmFwcC9Eb3dubG9hZD9jb2xDb2RlPUlNWDhRTUlFQyANCkNoYXRwZXIgMTMuNiBMb3cgUG93
ZXIgVW5pdmVyc2FsIEFzeW5jaHJvbm91cyBSZWNlaXZlci8NClRyYW5zbWl0dGVyIChMUFVBUlQp
DQpCdXQgdGhpcyByZXF1aXJlcyByZWdpc3RyYXRpb24gdG8gYWNjZXNzLg0KDQpMaW51eCBkcml2
ZXI6DQpodHRwczovL2dpdC5rZXJuZWwub3JnL3B1Yi9zY20vbGludXgva2VybmVsL2dpdC90b3J2
YWxkcy9saW51eC5naXQvdHJlZS9kcml2ZXJzL3R0eS9zZXJpYWwvZnNsX2xwdWFydC5jDQoNCg0K
VGhhbmtzLA0KUGVuZy4NCg0KPiANCj4gVGhpcyB3b3VsZCBoZWxwIHRvIHJldmlldyB0aGlzIHBh
dGNoLg0KPiANCj4gQ2hlZXJzLA0KPiANCj4gLS0NCj4gSnVsaWVuIEdyYWxsDQo=


From xen-devel-bounces@lists.xenproject.org Mon Feb 28 09:31:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 09:31:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280271.478146 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOcNE-0005wI-Fk; Mon, 28 Feb 2022 09:31:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280271.478146; Mon, 28 Feb 2022 09:31:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOcNE-0005wB-Cj; Mon, 28 Feb 2022 09:31:20 +0000
Received: by outflank-mailman (input) for mailman id 280271;
 Mon, 28 Feb 2022 09:31:18 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nOcNC-0005w5-Cf
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 09:31:18 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nOcN7-0001fm-1J; Mon, 28 Feb 2022 09:31:13 +0000
Received: from 54-240-197-230.amazon.com ([54.240.197.230]
 helo=[192.168.13.237]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nOcN6-0001FR-Qd; Mon, 28 Feb 2022 09:31:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=GJxpW+wfT2tUsI60DYqhNvRAnqEPYv+Af2H65Lz/+CQ=; b=qwe83a5g+Uc7VPY8jN+5WoUn6Z
	l+hRfsWPmemGC1nX7Dq0m6h6hMbnLu0HIS3SENl9eGSTAknJY0nm+HYjuH5l8m93MKrsYRd+ZO1iy
	UOKmtAK/MKy//Xnf7xjjHqSsn6Ya7vWcZIE/csZ8s4DzbO815vm8pOv0OH0O97TwMKTA=;
Message-ID: <e55f32f9-4d24-77a9-026b-201536c73708@xen.org>
Date: Mon, 28 Feb 2022 09:31:09 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.1
Subject: Re: [PATCH 3/3] xen/arm: Add i.MX8QM platform support
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>, sstabellini@kernel.org,
 Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com
Cc: andrew.cooper3@citrix.com, george.dunlap@citrix.com, jbeulich@suse.com,
 wl@xen.org, xen-devel@lists.xenproject.org, van.freenix@gmail.com,
 Peng Fan <peng.fan@nxp.com>
References: <20220228010711.11566-1-peng.fan@oss.nxp.com>
 <20220228010711.11566-4-peng.fan@oss.nxp.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220228010711.11566-4-peng.fan@oss.nxp.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Peng,

On 28/02/2022 01:07, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>   xen/arch/arm/Kconfig.debug      |  3 +++
>   xen/arch/arm/platforms/Makefile |  1 +
>   xen/arch/arm/platforms/imx8qm.c | 44 +++++++++++++++++++++++++++++++++
>   3 files changed, 48 insertions(+)
>   create mode 100644 xen/arch/arm/platforms/imx8qm.c
> 
> diff --git a/xen/arch/arm/Kconfig.debug b/xen/arch/arm/Kconfig.debug
> index 9ecb446b3a..43ccd8fe62 100644
> --- a/xen/arch/arm/Kconfig.debug
> +++ b/xen/arch/arm/Kconfig.debug
> @@ -143,6 +143,9 @@ choice
>   	config EARLY_PRINTK_HIKEY960
>   		bool "Early printk with pl011 with Hikey 960"
>   		select EARLY_UART_PL011
> +	config EARLY_PRINTK_IMX8QM
> +		bool "Early printk with i.MX LPUART with i.MX8QM"
> +		select EARLY_UART_IMX_LPUART

The goal of platform specific early printk is to select to UART address 
(see EARLY_UART_BASE_ADDRESS).

However, we have deprecated them. So we should avoid adding new ones.

>   	config EARLY_PRINTK_JUNO
>   		bool "Early printk with pl011 on Juno platform"
>   		select EARLY_UART_PL011
> diff --git a/xen/arch/arm/platforms/Makefile b/xen/arch/arm/platforms/Makefile
> index 8632f4115f..bec6e55d1f 100644
> --- a/xen/arch/arm/platforms/Makefile
> +++ b/xen/arch/arm/platforms/Makefile
> @@ -9,5 +9,6 @@ obj-$(CONFIG_ALL_PLAT)   += sunxi.o
>   obj-$(CONFIG_ALL64_PLAT) += thunderx.o
>   obj-$(CONFIG_ALL64_PLAT) += xgene-storm.o
>   obj-$(CONFIG_ALL64_PLAT) += brcm-raspberry-pi.o
> +obj-$(CONFIG_ALL64_PLAT) += imx8qm.o
>   obj-$(CONFIG_MPSOC_PLATFORM)  += xilinx-zynqmp.o
>   obj-$(CONFIG_MPSOC_PLATFORM)  += xilinx-zynqmp-eemi.o
> diff --git a/xen/arch/arm/platforms/imx8qm.c b/xen/arch/arm/platforms/imx8qm.c
> new file mode 100644
> index 0000000000..289c18e5f9
> --- /dev/null
> +++ b/xen/arch/arm/platforms/imx8qm.c
> @@ -0,0 +1,44 @@
> +/*
> + * xen/arch/arm/platforms/imx8qm.c
> + *
> + * i.MX 8QM setup
> + *
> + * Copyright 2022 NXP
> + *
> + * Peng Fan <peng.fan@nxp.com>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */
> +
> +#include <xen/delay.h>
> +#include <xen/mm.h>
> +#include <xen/vmap.h>
> +#include <asm/io.h>
> +#include <asm/platform.h>
> +
> +static const char * const imx8qm_dt_compat[] __initconst =
> +{
> +    "fsl,imx8qm",
> +    NULL
> +};
> +
> +PLATFORM_START(imx8qm, "i.MX 8")
> +    .compatible = imx8qm_dt_compat,
> +PLATFORM_END

We are only adding new platform definition when quirks are necessary. Do 
you need specific quirks for the i.MX8QM?

A somewhat related question, is this series enough to boot Xen upstream 
on the board?

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Feb 28 09:55:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 09:55:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280278.478157 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOckJ-0008PM-Fc; Mon, 28 Feb 2022 09:55:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280278.478157; Mon, 28 Feb 2022 09:55:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOckJ-0008PF-AZ; Mon, 28 Feb 2022 09:55:11 +0000
Received: by outflank-mailman (input) for mailman id 280278;
 Mon, 28 Feb 2022 09:55:09 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nOckH-0008P9-Tl
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 09:55:09 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nOckC-00022b-8N; Mon, 28 Feb 2022 09:55:04 +0000
Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nOckC-0003Bs-0G; Mon, 28 Feb 2022 09:55:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject:
	From:References:Cc:To:MIME-Version:Date:Message-ID;
	bh=pvokMa2ciW4n5JHoqWln4eK7lybZsRW703YLyb2rvDE=; b=LfqXqUGOmq9mSjed6ZDKohQThW
	NDcxrPvpdWKXpRzwPsQAcHjDKgHr+fsp3C8+9bVvAkzzMpp+LXRRJ0Tg7MdRv7VodolIxyZ8rIul/
	eHfTgTW5yOsEZdjdbYI1V8ISQ1qdGEU5U65nAB5CAFzTf62QPJ3xjiGSmS+QvFsOoJDQ=;
Message-ID: <ecb68523-1881-214a-b1e4-b239fed6ddce@xen.org>
Date: Mon, 28 Feb 2022 09:55:01 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.1
To: Jan Beulich <jbeulich@suse.com>
Cc: Wei Liu <wei.liu2@citrix.com>, Stefano Stabellini
 <sstabellini@kernel.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 George Dunlap <george.dunlap@citrix.com>, Hongyan Xia <hongyxia@amazon.com>,
 Julien Grall <jgrall@amazon.com>, Wei Liu <wl@xen.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 xen-devel@lists.xenproject.org
References: <20220221102218.33785-1-julien@xen.org>
 <20220221102218.33785-15-julien@xen.org>
 <fea3b34c-d605-be27-f75e-722b39cc48e3@suse.com>
From: Julien Grall <julien@xen.org>
Subject: Re: [PATCH v3 14/19] xen/arm: add Persistent Map (PMAP)
 infrastructure
In-Reply-To: <fea3b34c-d605-be27-f75e-722b39cc48e3@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Jan,

On 22/02/2022 15:22, Jan Beulich wrote:
> On 21.02.2022 11:22, Julien Grall wrote:
>> --- a/xen/common/Makefile
>> +++ b/xen/common/Makefile
>> @@ -28,6 +28,7 @@ obj-y += multicall.o
>>   obj-y += notifier.o
>>   obj-y += page_alloc.o
>>   obj-$(CONFIG_HAS_PDX) += pdx.o
>> +obj-bin-$(CONFIG_HAS_PMAP) += pmap.init.o
>>   obj-$(CONFIG_PERF_COUNTERS) += perfc.o
>>   obj-y += preempt.o
>>   obj-y += random.o
> 
> Nit: Please move the insertion one line further down.

Doh. I have moved the insertion.

> 
>> --- /dev/null
>> +++ b/xen/common/pmap.c
>> @@ -0,0 +1,79 @@
>> +#include <xen/bitops.h>
>> +#include <xen/init.h>
>> +#include <xen/pmap.h>
>> +
>> +#include <asm/pmap.h>
>> +#include <asm/fixmap.h>
>> +
>> +/*
>> + * Simple mapping infrastructure to map / unmap pages in fixed map.
>> + * This is used to set up the page table for mapcache, which is used
>> + * by map domain page infrastructure.
> 
> Is this comment stale from its original x86 purpose?
Yes. I should reword to:

"This is used to set the page table before the map domain page 
infrastructure is initialized".

> 
>> + * This structure is not protected by any locks, so it must not be used after
>> + * smp bring-up.
>> + */
>> +
>> +/* Bitmap to track which slot is used */
>> +static unsigned long __initdata inuse;
> 
> I guess this wants to use DECLARE_BITMAP(), for ...
> 
>> +void *__init pmap_map(mfn_t mfn)
>> +{
>> +    unsigned long flags;
>> +    unsigned int idx;
>> +    unsigned int slot;
>> +
>> +    BUILD_BUG_ON(sizeof(inuse) * BITS_PER_BYTE < NUM_FIX_PMAP);
>> +
>> +    ASSERT(system_state < SYS_STATE_smp_boot);
>> +
>> +    local_irq_save(flags);
>> +
>> +    idx = find_first_zero_bit(&inuse, NUM_FIX_PMAP);
> 
> ... this to be correct irrespective of how large NUM_FIX_PMAP is?
> I think that's preferable over the BUILD_BUG_ON().

I agree. I will have a look to use DECLARE_BITMAP().

> 
>> +    if ( idx == NUM_FIX_PMAP )
>> +        panic("Out of PMAP slots\n");
>> +
>> +    __set_bit(idx, &inuse);
>> +
>> +    slot = idx + FIXMAP_PMAP_BEGIN;
>> +    ASSERT(slot >= FIXMAP_PMAP_BEGIN && slot <= FIXMAP_PMAP_END);
>> +
>> +    /*
>> +     * We cannot use set_fixmap() here. We use PMAP when there is no direct map,
>> +     * so map_pages_to_xen() called by set_fixmap() needs to map pages on
>> +     * demand, which then calls pmap() again, resulting in a loop. Modify the
>> +     * PTEs directly instead. The same is true for pmap_unmap().
>> +     */
>> +    arch_pmap_map(slot, mfn);
> 
> I'm less certain here, but like above I'm under the impression
> that this comment may no longer be accurate.

This comment is still accurate for Arm. I also expect it to be accurate 
for all architectures because set_fixmap() is likely going to be 
implemented with generic PT helpers.

So I think it makes sense to keep it in common code. This explains why 
we are calling arch_pmap_map() rather than set_fixmap() directly.

> 
>> +    local_irq_restore(flags);
> 
> What is this IRQ save/restore intended to protect against, when
> use of this function is limited to pre-SMP boot anyway?

Hmmm... This patch has been through various revision before me. I went 
through the archives and couldn't tell why local_irq_restore() was added.

Looking at the code, none of the Xen page-table helpers expect to be 
called from interrupt context. So I am thinking to replace with an 
ASSERT/BUG_ON !in_irq().

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Feb 28 10:06:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 10:06:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280285.478169 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOcvT-0001ZE-JM; Mon, 28 Feb 2022 10:06:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280285.478169; Mon, 28 Feb 2022 10:06:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOcvT-0001Z7-Dw; Mon, 28 Feb 2022 10:06:43 +0000
Received: by outflank-mailman (input) for mailman id 280285;
 Mon, 28 Feb 2022 10:06:42 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nOcvS-0001Z1-Q9
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 10:06:42 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nOcvS-0002LP-Dg; Mon, 28 Feb 2022 10:06:42 +0000
Received: from 54-240-197-224.amazon.com ([54.240.197.224]
 helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com)
 by xenbits.xenproject.org with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nOcvS-0004TQ-5G; Mon, 28 Feb 2022 10:06:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:
	Subject:Cc:To:From; bh=ExgHnlTeJ0I/J1Q7pQ+FQvgN5arq/5SIe441Bm1jT0E=; b=C/dGZp
	IlC30IWEKTp00K7OI3y+Oy2uSQcmhvMHfZicrIBwhzGEIcs2ZkHmGpuSTZWZ8lrBJg8/BDpVHva2h
	paM9lNTH5IPMCbo/bmuFrbBXxJYyiUxCOTn9gRh6MtTPyx9GZlWS01FtYGx2JoWc7/cUpn76jTrxa
	kTA7L3u3mSI=;
From: Julien Grall <julien@xen.org>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	Julien Grall <julien.grall@arm.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Julien Grall <jgrall@amazon.com>
Subject: [PATCH] xen/arm: Remove unused BOOT_RELOC_VIRT_START
Date: Mon, 28 Feb 2022 10:06:33 +0000
Message-Id: <20220228100633.57593-1-julien@xen.org>
X-Mailer: git-send-email 2.32.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Julien Grall <julien.grall@arm.com>

We stopped relocating Xen since commit f60658c6ae "xen/arm: Stop
relocating Xen".

At the same time, update the memory layout description.

Signed-off-by: Julien Grall <julien.grall@arm.com>
Signed-off-by: Julien Grall <jgrall@amazon.com>
---
 xen/arch/arm/include/asm/config.h | 4 +---
 xen/arch/arm/mm.c                 | 1 -
 2 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/xen/arch/arm/include/asm/config.h b/xen/arch/arm/include/asm/config.h
index 2aced0bc3b8b..b25c9d39bb32 100644
--- a/xen/arch/arm/include/asm/config.h
+++ b/xen/arch/arm/include/asm/config.h
@@ -77,8 +77,7 @@
  *   2M -   4M   Xen text, data, bss
  *   4M -   6M   Fixmap: special-purpose 4K mapping slots
  *   6M -  10M   Early boot mapping of FDT
- *   10M - 12M   Early relocation address (used when relocating Xen)
- *               and later for livepatch vmap (if compiled in)
+ *   10M - 12M   Livepatch vmap (if compiled in)
  *
  * ARM32 layout:
  *   0  -  12M   <COMMON>
@@ -115,7 +114,6 @@
 #define BOOT_FDT_SLOT_SIZE     MB(4)
 #define BOOT_FDT_VIRT_END      (BOOT_FDT_VIRT_START + BOOT_FDT_SLOT_SIZE)
 
-#define BOOT_RELOC_VIRT_START  _AT(vaddr_t,0x00a00000)
 #ifdef CONFIG_LIVEPATCH
 #define LIVEPATCH_VMAP_START   _AT(vaddr_t,0x00a00000)
 #define LIVEPATCH_VMAP_END     (LIVEPATCH_VMAP_START + MB(2))
diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
index 515d0906f85b..8a17222109c6 100644
--- a/xen/arch/arm/mm.c
+++ b/xen/arch/arm/mm.c
@@ -196,7 +196,6 @@ static void __init __maybe_unused build_assertions(void)
     /* 2MB aligned regions */
     BUILD_BUG_ON(XEN_VIRT_START & ~SECOND_MASK);
     BUILD_BUG_ON(FIXMAP_ADDR(0) & ~SECOND_MASK);
-    BUILD_BUG_ON(BOOT_RELOC_VIRT_START & ~SECOND_MASK);
     /* 1GB aligned regions */
 #ifdef CONFIG_ARM_32
     BUILD_BUG_ON(XENHEAP_VIRT_START & ~FIRST_MASK);
-- 
2.32.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 28 10:07:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 10:07:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280288.478179 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOcvn-00021y-Pz; Mon, 28 Feb 2022 10:07:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280288.478179; Mon, 28 Feb 2022 10:07:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOcvn-00021r-Me; Mon, 28 Feb 2022 10:07:03 +0000
Received: by outflank-mailman (input) for mailman id 280288;
 Mon, 28 Feb 2022 10:07:02 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nOcvm-00020A-D3
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 10:07:02 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nOcvm-0002MD-3z; Mon, 28 Feb 2022 10:07:02 +0000
Received: from 54-240-197-224.amazon.com ([54.240.197.224]
 helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com)
 by xenbits.xenproject.org with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nOcvl-0004V1-SI; Mon, 28 Feb 2022 10:07:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:
	Subject:Cc:To:From; bh=f3Jb6TzGg/yx/at/IZdJKmtMdmjk5P7HjMANFFUjdOs=; b=1Hf6EM
	NF+7ulziq1Gje4Oec+PyKnNb+WnaNr0P+i8oi/PhGKJ0OZXxBOHdVDF2mfZReFO4gtxi8rpQLtwe1
	Z5v6hbVveBOoad+ESyhgrRFQdvYKlQkV0rRvhdToemmo/B0ma8reaN9yWH4TjCfhnQ/K8FIbVKsdi
	sp9VRE0Rz6Q=;
From: Julien Grall <julien@xen.org>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	Julien Grall <jgrall@amazon.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH] xen/arm: mm: Encode existing constraints of the memory layout
Date: Mon, 28 Feb 2022 10:06:59 +0000
Message-Id: <20220228100659.58089-1-julien@xen.org>
X-Mailer: git-send-email 2.32.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Julien Grall <jgrall@amazon.com>

The boot code expects the regions XEN_VIRT_START, FIXMAP_ADDR(0),
BOOT_FDT_VIRT_START to use the same 0th (arm64 only) and 1st slot.

Add some BUILD_BUG_ON() to confirm that. This is helpful if one wants
to re-order the memory layout.

Signed-off-by: Julien Grall <jgrall@amazon.com>
---
 xen/arch/arm/mm.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
index 8a17222109c6..40423a70f0ae 100644
--- a/xen/arch/arm/mm.c
+++ b/xen/arch/arm/mm.c
@@ -211,6 +211,22 @@ static void __init __maybe_unused build_assertions(void)
 #ifdef CONFIG_DOMAIN_PAGE
     BUILD_BUG_ON(DOMHEAP_VIRT_START & ~FIRST_MASK);
 #endif
+    /*
+     * The boot code expects the regions XEN_VIRT_START, FIXMAP_ADDR(0),
+     * BOOT_FDT_VIRT_START to use the same 0th (arm64 only) and 1st
+     * slot.
+     */
+#define CHECK_SAME_SLOT(level, virt1, virt2) \
+    BUILD_BUG_ON(level##_table_offset(virt1) != level##_table_offset(virt2))
+
+#ifdef CONFIG_ARM_64
+    CHECK_SAME_SLOT(zeroeth, XEN_VIRT_START, FIXMAP_ADDR(0));
+    CHECK_SAME_SLOT(zeroeth, XEN_VIRT_START, BOOT_FDT_VIRT_START);
+#endif
+    CHECK_SAME_SLOT(first, XEN_VIRT_START, FIXMAP_ADDR(0));
+    CHECK_SAME_SLOT(first, XEN_VIRT_START, BOOT_FDT_VIRT_START);
+
+#undef CHECK_SAME_SLOT
 }
 
 void dump_pt_walk(paddr_t ttbr, paddr_t addr,
-- 
2.32.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 28 10:07:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 10:07:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280298.478190 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOcwT-0002ki-77; Mon, 28 Feb 2022 10:07:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280298.478190; Mon, 28 Feb 2022 10:07:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOcwT-0002kb-4D; Mon, 28 Feb 2022 10:07:45 +0000
Received: by outflank-mailman (input) for mailman id 280298;
 Mon, 28 Feb 2022 10:07:44 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nOcwS-0002kP-00
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 10:07:44 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nOcwR-0002MV-Oe; Mon, 28 Feb 2022 10:07:43 +0000
Received: from 54-240-197-224.amazon.com ([54.240.197.224]
 helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com)
 by xenbits.xenproject.org with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nOcwR-0004Yf-GI; Mon, 28 Feb 2022 10:07:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:
	Subject:Cc:To:From; bh=KVCoOox3nA3HgaYBDS9j2yAj0flJel/SfOyIYIak1Ps=; b=Nit+xE
	LNV8iy8Uqf4JZe7qnQRsweoNgwj/BP5EIv7byFjM26Nl0Pii4iYyyQhbAR+Bxbyj1q3ZttaWlIqPt
	9vislkGnav2t4Y45BqqzKElu8bHXNASoskzvlz+8iWcyoXKWgLpZsi05AiAt81AZ9OeuGSesNcz7M
	zHkSbq6ikDc=;
From: Julien Grall <julien@xen.org>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	Julien Grall <jgrall@amazon.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH] xen/arm32: head: Mark the end of subroutines with ENDPROC (take two)
Date: Mon, 28 Feb 2022 10:07:40 +0000
Message-Id: <20220228100740.60332-1-julien@xen.org>
X-Mailer: git-send-email 2.32.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Julien Grall <jgrall@amazon.com>

Commit 2ac705a59ef5 ("xen/arm32: head: Mark the end of subroutines
with ENDPROC") intended to mark all the subroutines with ENDPROC.

Unfortunately, I missed fail(), switch_ttbr(), init_uart() and
__lookup_processor_type(). Add ENDPROC for the benefits of
static analysis tools and the reader.

Signed-off-by: Julien Grall <jgrall@amazon.com>
---
 xen/arch/arm/arm32/head.S | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/xen/arch/arm/arm32/head.S b/xen/arch/arm/arm32/head.S
index b1d209ea2842..13cfc837d39c 100644
--- a/xen/arch/arm/arm32/head.S
+++ b/xen/arch/arm/arm32/head.S
@@ -661,6 +661,7 @@ ENDPROC(launch)
 fail:   PRINT("- Boot failed -\r\n")
 1:      wfe
         b     1b
+ENDPROC(fail)
 
 GLOBAL(_end_boot)
 
@@ -694,6 +695,7 @@ ENTRY(switch_ttbr)
         isb
 
         mov pc, lr
+ENDPROC(switch_ttbr)
 
 #ifdef CONFIG_EARLY_PRINTK
 /*
@@ -711,6 +713,7 @@ init_uart:
 #endif
         PRINT("- UART enabled -\r\n")
         mov   pc, lr
+ENDPROC(init_uart)
 
 /*
  * Print early debug messages.
@@ -798,6 +801,7 @@ __lookup_processor_type:
         mov   r1, #0
 2:
         mov   pc, lr
+ENDPROC(__lookup_processor_type)
 
 /*
  * Local variables:
-- 
2.32.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 28 10:08:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 10:08:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280303.478201 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOcwr-0003Jj-FN; Mon, 28 Feb 2022 10:08:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280303.478201; Mon, 28 Feb 2022 10:08:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOcwr-0003Jb-C6; Mon, 28 Feb 2022 10:08:09 +0000
Received: by outflank-mailman (input) for mailman id 280303;
 Mon, 28 Feb 2022 10:08:08 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nOcwq-0003Hy-1p
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 10:08:08 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nOcwp-0002Nm-OP; Mon, 28 Feb 2022 10:08:07 +0000
Received: from 54-240-197-224.amazon.com ([54.240.197.224]
 helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com)
 by xenbits.xenproject.org with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nOcwp-0004bS-Gg; Mon, 28 Feb 2022 10:08:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:
	Subject:Cc:To:From; bh=P1oGTBOw5wZOVO0AiBiFv8kLi7uHeyJ9lMmo2PgMCeM=; b=Xooswf
	XaWMdK16sLCJRRR9stu30FxAnIzYUFWHV+SGKhuuM8yWEzYmHbX7EY1YFDHzm9afT1/KzbnEcuoF+
	l0eNhW5CP5P33I/s8g1sVpUVsyNaMgKHMYbpwVpPWgDKCiUS29guJwbeDONAmkSHtqwtceBuP7jmk
	fd0YErUdet0=;
From: Julien Grall <julien@xen.org>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	Julien Grall <jgrall@amazon.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH] xen/arm64: head: Mark the end of subroutines with ENDPROC (take two)
Date: Mon, 28 Feb 2022 10:08:05 +0000
Message-Id: <20220228100805.60918-1-julien@xen.org>
X-Mailer: git-send-email 2.32.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Julien Grall <jgrall@amazon.com>

Commit 13c03002c5df ("xen/arm64: head: Mark the end of subroutines
with ENDPROC") intended to mark all the subroutines with ENDPROC.

Unfortunately, I missed fail(), switch_ttbr() and init_uart(). Add
ENDPROC for the benefits of static analysis tools and the reader.

Signed-off-by: Julien Grall <jgrall@amazon.com>
---
 xen/arch/arm/arm64/head.S | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S
index 314b800b3f8e..66d862fc8137 100644
--- a/xen/arch/arm/arm64/head.S
+++ b/xen/arch/arm/arm64/head.S
@@ -800,6 +800,7 @@ ENDPROC(launch)
 fail:   PRINT("- Boot failed -\r\n")
 1:      wfe
         b     1b
+ENDPROC(fail)
 
 GLOBAL(_end_boot)
 
@@ -830,6 +831,7 @@ ENTRY(switch_ttbr)
         isb
 
         ret
+ENDPROC(switch_ttbr)
 
 #ifdef CONFIG_EARLY_PRINTK
 /*
@@ -847,6 +849,7 @@ init_uart:
 #endif
         PRINT("- UART enabled -\r\n")
         ret
+ENDPROC(init_uart)
 
 /* Print early debug messages.
  * x0: Nul-terminated string to print.
-- 
2.32.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 28 10:08:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 10:08:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280309.478211 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOcxB-0003sU-N4; Mon, 28 Feb 2022 10:08:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280309.478211; Mon, 28 Feb 2022 10:08:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOcxB-0003sN-K1; Mon, 28 Feb 2022 10:08:29 +0000
Received: by outflank-mailman (input) for mailman id 280309;
 Mon, 28 Feb 2022 10:08:28 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nOcxA-0003sD-L7
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 10:08:28 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nOcxA-0002O1-CE; Mon, 28 Feb 2022 10:08:28 +0000
Received: from 54-240-197-232.amazon.com ([54.240.197.232]
 helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com)
 by xenbits.xenproject.org with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nOcxA-0004dO-4e; Mon, 28 Feb 2022 10:08:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:
	Subject:Cc:To:From; bh=P1oGTBOw5wZOVO0AiBiFv8kLi7uHeyJ9lMmo2PgMCeM=; b=aCogjA
	84TtatqrfbZZgGVxRQkJ4WjZUi9e8v1uG4EJnqGT8v6scXmi1JzOu7Z64ocqj1umYe07iwZkrMyE9
	EkXlb5F7XWhVpr2k2JU92P6uO4eLD/Z0oOIuN1GZEKXu6gneeZpk7lgZP9Uql6BcT2E0eFhBShdj/
	+B9XeNfMiPE=;
From: Julien Grall <julien@xen.org>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	Julien Grall <jgrall@amazon.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH] xen/arm64: head: Mark the end of subroutines with ENDPROC (take two)
Date: Mon, 28 Feb 2022 10:08:26 +0000
Message-Id: <20220228100826.61339-1-julien@xen.org>
X-Mailer: git-send-email 2.32.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Julien Grall <jgrall@amazon.com>

Commit 13c03002c5df ("xen/arm64: head: Mark the end of subroutines
with ENDPROC") intended to mark all the subroutines with ENDPROC.

Unfortunately, I missed fail(), switch_ttbr() and init_uart(). Add
ENDPROC for the benefits of static analysis tools and the reader.

Signed-off-by: Julien Grall <jgrall@amazon.com>
---
 xen/arch/arm/arm64/head.S | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S
index 314b800b3f8e..66d862fc8137 100644
--- a/xen/arch/arm/arm64/head.S
+++ b/xen/arch/arm/arm64/head.S
@@ -800,6 +800,7 @@ ENDPROC(launch)
 fail:   PRINT("- Boot failed -\r\n")
 1:      wfe
         b     1b
+ENDPROC(fail)
 
 GLOBAL(_end_boot)
 
@@ -830,6 +831,7 @@ ENTRY(switch_ttbr)
         isb
 
         ret
+ENDPROC(switch_ttbr)
 
 #ifdef CONFIG_EARLY_PRINTK
 /*
@@ -847,6 +849,7 @@ init_uart:
 #endif
         PRINT("- UART enabled -\r\n")
         ret
+ENDPROC(init_uart)
 
 /* Print early debug messages.
  * x0: Nul-terminated string to print.
-- 
2.32.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 28 10:09:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 10:09:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280321.478223 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOcyS-0004dH-1X; Mon, 28 Feb 2022 10:09:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280321.478223; Mon, 28 Feb 2022 10:09:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOcyR-0004dA-UN; Mon, 28 Feb 2022 10:09:47 +0000
Received: by outflank-mailman (input) for mailman id 280321;
 Mon, 28 Feb 2022 10:09:46 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nOcyQ-0004d4-Sj
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 10:09:46 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nOcyQ-0002Ow-IF; Mon, 28 Feb 2022 10:09:46 +0000
Received: from 54-240-197-230.amazon.com ([54.240.197.230]
 helo=[192.168.13.237]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nOcyQ-0004iz-Cr; Mon, 28 Feb 2022 10:09:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=BZAt5OO8RmpSFn46WO+UDX0WJCszviouNDdSL0QGEP4=; b=RSYfs+kdEPaxMJ7/Ty+MFBYHhy
	VLzHcwKUNnaFAqQwZi3IlQCmNW6sIKjTR1x/fnMZUQHrhn8YSYXpsgKHroHsRiBRqHyxeAQn946Z0
	xZGIXPrY3TneEye6+SCtoF7hlzABBzkQKv8FeByXf7XO/GjDj/LVn0vZ3k+sOxtQbPIU=;
Message-ID: <60244b45-1b47-acc1-9658-fb260394adc7@xen.org>
Date: Mon, 28 Feb 2022 10:09:44 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.1
Subject: Re: [PATCH] xen/arm64: head: Mark the end of subroutines with ENDPROC
 (take two)
To: xen-devel@lists.xenproject.org
Cc: Julien Grall <jgrall@amazon.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20220228100826.61339-1-julien@xen.org>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220228100826.61339-1-julien@xen.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 28/02/2022 10:08, Julien Grall wrote:
> From: Julien Grall <jgrall@amazon.com>
> 
> Commit 13c03002c5df ("xen/arm64: head: Mark the end of subroutines
> with ENDPROC") intended to mark all the subroutines with ENDPROC.
> 
> Unfortunately, I missed fail(), switch_ttbr() and init_uart(). Add
> ENDPROC for the benefits of static analysis tools and the reader.
> 
> Signed-off-by: Julien Grall <jgrall@amazon.com>

Hmmm... It looks like I sent this patch twice. Please ignore this 
version and instead review:

https://lore.kernel.org/xen-devel/20220228100805.60918-1-julien@xen.org/

> ---
>   xen/arch/arm/arm64/head.S | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S
> index 314b800b3f8e..66d862fc8137 100644
> --- a/xen/arch/arm/arm64/head.S
> +++ b/xen/arch/arm/arm64/head.S
> @@ -800,6 +800,7 @@ ENDPROC(launch)
>   fail:   PRINT("- Boot failed -\r\n")
>   1:      wfe
>           b     1b
> +ENDPROC(fail)
>   
>   GLOBAL(_end_boot)
>   
> @@ -830,6 +831,7 @@ ENTRY(switch_ttbr)
>           isb
>   
>           ret
> +ENDPROC(switch_ttbr)
>   
>   #ifdef CONFIG_EARLY_PRINTK
>   /*
> @@ -847,6 +849,7 @@ init_uart:
>   #endif
>           PRINT("- UART enabled -\r\n")
>           ret
> +ENDPROC(init_uart)
>   
>   /* Print early debug messages.
>    * x0: Nul-terminated string to print.

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Feb 28 10:10:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 10:10:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280328.478234 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOczG-0005z5-AC; Mon, 28 Feb 2022 10:10:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280328.478234; Mon, 28 Feb 2022 10:10:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOczG-0005yy-76; Mon, 28 Feb 2022 10:10:38 +0000
Received: by outflank-mailman (input) for mailman id 280328;
 Mon, 28 Feb 2022 10:10:36 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=A4HT=TL=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nOczE-0005pG-Bh
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 10:10:36 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id aaa0e768-987e-11ec-8539-5f4723681683;
 Mon, 28 Feb 2022 11:10:34 +0100 (CET)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2108.outbound.protection.outlook.com [104.47.17.108]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-27-A8-oh1zoOWOblb4EvY-FVA-1; Mon, 28 Feb 2022 11:10:33 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DB9PR04MB8236.eurprd04.prod.outlook.com (2603:10a6:10:245::24)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.25; Mon, 28 Feb
 2022 10:10:31 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.026; Mon, 28 Feb 2022
 10:10:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: aaa0e768-987e-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1646043035;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=MhV0rwXLk/9UoG+nLDskczyhy8V7ZE8R4qS2txZL3Ic=;
	b=FzS9yYSejVwZHSpWr+zHuFVTC/l8qFdjqT192nWhMwe2IxbUj2qd/DQZTTI4Fjwyo/jSau
	1fklRCbBGscu9tMujqAiObrexZgcMxI+E6JjQNUhW3aKoqkil0dXLY0kYRqUhZ1Uusmw0M
	pp5ocbPZhHprhA39JBbFbfJsTWxOPdc=
X-MC-Unique: A8-oh1zoOWOblb4EvY-FVA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=geoqYE68m9FwhIL/dRcriJA79w4P6rQVlCGap9M/fUYM4T88VilbsoKIngjWFk4fpmNpX2ubxGvk6GBUcgLTvAamMlQwbFxLMIVdEIP7GzMTuZZqaVq4aLkCd6239PFxOCLCCgh3+olM3sRF3en4nMW+eQEmh/vOTWSNcQOi49eKZaUxdwon3UBDdj7PaDem2q5IeDKtqAlcDniNs5Yp6GiF620pdzLa54i0VbndHM4qflT5PSsjPJxj2e7y8C0RHATNYdwr4u07YgTOCwz7FPq/R+Fm3MWUx3cmyTJ5HrGcEnzW5EJ9U86YwnglcaG+l+arapiNQGsvdoXB7ZYI8w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=MhV0rwXLk/9UoG+nLDskczyhy8V7ZE8R4qS2txZL3Ic=;
 b=bnBtOYTO9sL/TPfHL+YQYe316KMFkMqV+4hBsjF9dQ5kR/9srRpBn0N0N7M9SzXKPAFtFRSCJkVJLo951aOmUjXIBRM7d7ogdK+VhU/BmCmsyCKDZb8zVNd9QJnhMkeIv+X/YKDLLiR+C1YQsdU6NTwVKPEmbDvKgAGveq1uy/djtAHYI/Q+3X0uMNAmgSR7g6dj5T02EEKnGTAEYLHR6DUvzVV4UT07OMIxGkZwdd7UjORi6O4mkXmXFcfwiQCkdDPclL2ereCsU/DHCPsiwALOUDwpSSMf8RR44QxBwnT15GgB4MyAN1KPA/vFMyayGCISRSX0RJMjQ5tQfR8eOw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <5d218b78-876f-71c2-ec73-9958c7e472ea@suse.com>
Date: Mon, 28 Feb 2022 11:10:29 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v3 14/19] xen/arm: add Persistent Map (PMAP)
 infrastructure
Content-Language: en-US
To: Julien Grall <julien@xen.org>
Cc: Wei Liu <wei.liu2@citrix.com>, Stefano Stabellini
 <sstabellini@kernel.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 George Dunlap <george.dunlap@citrix.com>, Hongyan Xia <hongyxia@amazon.com>,
 Julien Grall <jgrall@amazon.com>, Wei Liu <wl@xen.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 xen-devel@lists.xenproject.org
References: <20220221102218.33785-1-julien@xen.org>
 <20220221102218.33785-15-julien@xen.org>
 <fea3b34c-d605-be27-f75e-722b39cc48e3@suse.com>
 <ecb68523-1881-214a-b1e4-b239fed6ddce@xen.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <ecb68523-1881-214a-b1e4-b239fed6ddce@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P194CA0005.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:209:90::18) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: df8719f8-54aa-47cb-4f69-08d9faa28d68
X-MS-TrafficTypeDiagnostic: DB9PR04MB8236:EE_
X-Microsoft-Antispam-PRVS:
	<DB9PR04MB8236978D4CD75CE0D8A51117B3019@DB9PR04MB8236.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	pDrONxzPZwdTrLBm5nm1Uak0Gqt713swSX6t26rzlLKNcTxoymebMJtAKl+HlYoQj0jIyPNJo3GBK29QF6U7UgDJ71VyKvJJc1v7OcL1rP1pKWrkt55KQcnHBchr8NaXP16sh5sckqcimPUBunSNmPFmnTWRPWJarSsiJyL9QJ6F//fJ5rjAeL2t5dCnQggFBkoWMWtTYeU4Us/kp394cSard8VBGcNP6/MtzLmfQPQgo2MgAAqy3TtkrGOeNAGiHQinkMr6mALwajWAs4pxhTUk33bpdO4Fj3VvyaCWem5tzVhMsZAK8907gqijXzmGVnsk0QG6xVt8ddE+502AmaUUE14SbRSh5hqXup9kO4grX1G8TnK4QA4BGUDlw7qYsJWGu1renMeSMsigXLI3gN7ni/reFblilzdHpqDDAACI2ILIf2MBx3fbU6k/kOeUsQ4j/fwoENB1nm9+gB6wcUlFIz0MKPTo09iac6n56ykPUr78Ggvaz6EAmIQCQdGOZ1xWpvPPvJIzZRDF07pSrrJgDQcJI4njGEWuVf4a3pPTcHhLkLtsKwG8cTlxr4mg5jpJJjsDpIyHDgk1zh/L4aSkiUIYj3V1Ni5mSeEFajWMuyEShxwIk1iPVivuJ+GC+3srdwsPs3kwsXLDX+lxuzLeJfvxLFdx88LHi9M7mHQMd2cZwwy+k8E9NEcVjoFBAEw1/X2uxTCPqVhOWtjl5xWN5wOw9w9TqpLTYaEtHwU=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(26005)(186003)(6506007)(6512007)(53546011)(2616005)(508600001)(6486002)(54906003)(6916009)(31696002)(8676002)(66946007)(66556008)(66476007)(8936002)(7416002)(5660300002)(4326008)(2906002)(316002)(36756003)(86362001)(38100700002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TTlzaXNrdGx6aWFNamdmYmhEM0JLOG1MbnlvUW5ZTWR5QUVkL2dWb2NFc3Nk?=
 =?utf-8?B?M2UwQ3lETGNCbE5JSy92aGZ3dlhvd3hnWm41YldhV2VTTEVLZkNGcElkU3pt?=
 =?utf-8?B?dVFuSDBXSmtnWXhDb2Q3N3lEc2FyMEpzaUdpY0VQSVdCQzFBOXRxMzhqblRI?=
 =?utf-8?B?K0lJMFBLSXdNNWF4UHBieURqZGdoclpaU3puL080d2UzeEFmU1NoN2NLWUcz?=
 =?utf-8?B?ZnduTXdWWG12eHE4dnU5bFM0MmZRZG83ZDc4RjQwaXkyOEVLN3BydXc5dVc3?=
 =?utf-8?B?UjFCNm5hdjBRYVlVRkdwbWZoTzRUSzE3U29BcXRYOVdnb0NldDl4M2NlbWFw?=
 =?utf-8?B?dmQ3LzdwOHhPZlkzcnc0YTc2MzcvZDhhOTNpcnl6aitrUGFLVlhCZ29ydFFI?=
 =?utf-8?B?ZDd5am5Sa1kwSHR5QWpjdytacFlZY0hZalhGQUlyUkI4aXUzdGtoM0tlTVdy?=
 =?utf-8?B?Z0hKd2gvQ3BGaTNxR2FxdWc0NHdYWE1PcGlMa0hBN2Z6b3BOU1RQeVFHbVVk?=
 =?utf-8?B?c0kyVmFWaGtYZ3daSUY2dGdSSGU3NE5LOWVjSjl6NFdpTFpUNEQwa0lvNFdm?=
 =?utf-8?B?ZVM4anlkQktDcjgwNlNYMzBzWmZBamFvMWlNZ1RIRm1HL0hTcmxaa0ZTTzNY?=
 =?utf-8?B?WmgzekNZaUtaR0R3a2Z2UzhjNkdxd1pGL1gzdHgyUHo1K0xuUVZSVmh6L05r?=
 =?utf-8?B?TXFRWktvdmlxczdVVElBbnE0U2FZM3BUS2pLRlpqMHROZ2k2dVVQdWM5cmli?=
 =?utf-8?B?ekZYWHEwZzVkNXNnYWlOSk1RRzRKU0hmTW1VVm9SYzlVNElEZ25iR0J5WFYy?=
 =?utf-8?B?NnVocytxSzk5eGVVWVVubUR1SFhiaXZrSGc0cXRjWXdvQkdPRmVvSUpyUUE3?=
 =?utf-8?B?MjRINFMvVG5LL0tqM3hDY21QNnBMZ3pGSXdDcnlaa1FmSXJHK0ZjYk1wdVFm?=
 =?utf-8?B?eXdZYUJOZ0daYStuZzNLS0RybGtLSDlKbGpQTDNhQ2NrWXFvdWV1MkdzOTlI?=
 =?utf-8?B?UVNMVU1aaGNucTdwbnorTEhqeGxpOWk0S2x0WnRjS3YwK0UwSENCelc1cXVU?=
 =?utf-8?B?RzY2a1VMUGFna3FWSkZaNWJSSnQ2UHhGSHZ2YnNxaVRncmdTTkdReVpEcUJq?=
 =?utf-8?B?VXVYRDlmeWMxelMwUmwwVUVNNk5CVHpGZm54dlIwYnlvWllzOUtsRDdmOGIy?=
 =?utf-8?B?T0ZpK3JydDl1UC9KeDFLWWhmTFhFTnM4S1F4SndVWlpHbU5UNEY1U0kzYlF2?=
 =?utf-8?B?M1pEMDdJZW1QdUpiWkVMdlpNVk5YMS8xQ1R0c0g1cnVsU1JWUENlS2NRV05n?=
 =?utf-8?B?SmJSL2lLVVVIQnJOaSsyS3dITVo5bDBIVDJjRjlXMXh0MGduSytBUlVKVlBv?=
 =?utf-8?B?MVJUb0FVSXptaXhXZTUzQnJRYnpQR05FUkluYyt6MitjaDlqSmxCWnRXb1VF?=
 =?utf-8?B?SjJDWVorN3grZ3pUUGtIQU5Bc241UHUvWEdvUHpTRFREVk1XQlhkSWRlYkRP?=
 =?utf-8?B?S2NyaWFTbHZOUzRUS2ZPMXZnZ29zUjZsc2NjNU04a1kyWnBXTmwrUkZMSHJz?=
 =?utf-8?B?eExuNytYZVhROEJmK0pxaEJqTk5hUE9VVTNZMzRVekQ0TXFaQ3dUdC9VQTQv?=
 =?utf-8?B?YVNSQjg2WVRvazFwYXZYdHFKWkRIQ3pvcC9uV3lxWUgyeEthUDk1dWRZRUg5?=
 =?utf-8?B?SzRtdTNPRjFneXBZWVJFSklkOVVKZnJzSjBIOGRtdEs3RHhORTgyekxQYUpK?=
 =?utf-8?B?OHBGS1dGZlpkWFpaRHR0YlhCQU9KMXNzS1hNK2FPbXRkZXZqdVVVZXFhU3VO?=
 =?utf-8?B?Rnp0VGFxZXM2MHRyT0I5WW90ODk0a0dRa0lvekRDRkN1bnJFUDFNZW44MFNF?=
 =?utf-8?B?UjAwMXFEaWdJY0xDdThuNkhMYW5tTXJhK3hpMXltWVJ5TXNMYmNEQnRMVkhW?=
 =?utf-8?B?L1JsY0QvRkRWVll0cllhQlJoZExXZ3gzUnpDNUZmOVNOK2dpQTh3cVFubm1k?=
 =?utf-8?B?RHU5VU9YNDZZN2FtMmtSeEhRWnJUMWVybXdFN0FVMzZXMHl4cy9KZDZYRWpB?=
 =?utf-8?B?Qm56WGVjTXlzNC9pQUpibnFPNTRKcUlIeGc1d3cwd3lBUzYwU0ZqZlR5ZnJT?=
 =?utf-8?B?LzliQm1ERlN4a09yQmN2T2JFb1ZZS3p2dTRGT0xER2pSVW8yRlJvMVFiZlJR?=
 =?utf-8?Q?L5zJCVLC/ccaKiXjA5dOxT0=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: df8719f8-54aa-47cb-4f69-08d9faa28d68
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2022 10:10:31.6205
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pQzTvWPF0u/SjYyQ4/vVfzCzAqzGd8iXURBaZdpmKgBzu7myJcby4WpbaZhgvqQACPxqPIx4xbjeG+t0u6r5lQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8236

On 28.02.2022 10:55, Julien Grall wrote:
> On 22/02/2022 15:22, Jan Beulich wrote:
>> On 21.02.2022 11:22, Julien Grall wrote:
>>> +    /*
>>> +     * We cannot use set_fixmap() here. We use PMAP when there is no direct map,
>>> +     * so map_pages_to_xen() called by set_fixmap() needs to map pages on
>>> +     * demand, which then calls pmap() again, resulting in a loop. Modify the
>>> +     * PTEs directly instead. The same is true for pmap_unmap().
>>> +     */
>>> +    arch_pmap_map(slot, mfn);
>>
>> I'm less certain here, but like above I'm under the impression
>> that this comment may no longer be accurate.
> 
> This comment is still accurate for Arm. I also expect it to be accurate 
> for all architectures because set_fixmap() is likely going to be 
> implemented with generic PT helpers.
> 
> So I think it makes sense to keep it in common code. This explains why 
> we are calling arch_pmap_map() rather than set_fixmap() directly.

I guess I was rather after "when there is no direct map" alluding to the
planned removal of it on x86.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 28 10:11:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 10:11:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280335.478245 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOd0V-0006aq-KI; Mon, 28 Feb 2022 10:11:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280335.478245; Mon, 28 Feb 2022 10:11:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOd0V-0006aj-Gx; Mon, 28 Feb 2022 10:11:55 +0000
Received: by outflank-mailman (input) for mailman id 280335;
 Mon, 28 Feb 2022 10:11:54 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nOd0U-0006aZ-2z
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 10:11:54 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nOd0S-0002Sh-Tb; Mon, 28 Feb 2022 10:11:52 +0000
Received: from 54-240-197-224.amazon.com ([54.240.197.224]
 helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com)
 by xenbits.xenproject.org with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nOd0S-000540-Lg; Mon, 28 Feb 2022 10:11:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:
	Subject:Cc:To:From; bh=DoUrmxmwcPTK3PDPM7WZ3Sm53KX/g68Md1TJD3kNGt0=; b=KQX20N
	kYJWJ0OsTE6aSgTqSga4YsjsZwDLnnBk9lOd7x4BdxG4eXnk1ewwxuqvgQSqRpldmsWNPFC192n4Z
	XUm+3II9qsh5vxY50nLqysgmghkO4jhZjWHqd1EJBuUmHNwcZneSin/VoPBcFLVdq904HsWCy3PxZ
	NTfXILCCNVg=;
From: Julien Grall <julien@xen.org>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	Julien Grall <jgrall@amazon.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH] xen/arm32: head: Update the documentation for register r12
Date: Mon, 28 Feb 2022 10:11:50 +0000
Message-Id: <20220228101150.63816-1-julien@xen.org>
X-Mailer: git-send-email 2.32.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Julien Grall <jgrall@amazon.com>

Since commit 54c4ae18d158 ("xen/arm32: head: Rework and document
launch()"), the boot code is not using the register r12.

So update the documentation to show r12 has no specific purpose.

Signed-off-by: Julien Grall <jgrall@amazon.com>
---
 xen/arch/arm/arm32/head.S | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/arch/arm/arm32/head.S b/xen/arch/arm/arm32/head.S
index 13cfc837d39c..78274a1c034f 100644
--- a/xen/arch/arm/arm32/head.S
+++ b/xen/arch/arm/arm32/head.S
@@ -79,7 +79,7 @@
  *   r9  - paddr(start)
  *   r10 - phys offset
  *   r11 - UART address
- *   r12 - is_secondary_cpu
+ *   r12 -
  *   r13 - SP
  *   r14 - LR
  *   r15 - PC
-- 
2.32.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 28 10:19:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 10:19:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280345.478256 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOd7f-0007KV-DU; Mon, 28 Feb 2022 10:19:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280345.478256; Mon, 28 Feb 2022 10:19:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOd7f-0007KO-AI; Mon, 28 Feb 2022 10:19:19 +0000
Received: by outflank-mailman (input) for mailman id 280345;
 Mon, 28 Feb 2022 10:19:18 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=A4HT=TL=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nOd7e-0007KG-2S
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 10:19:18 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e24c069f-987f-11ec-8eba-a37418f5ba1a;
 Mon, 28 Feb 2022 11:19:16 +0100 (CET)
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2059.outbound.protection.outlook.com [104.47.2.59]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-23-pTnm0Q0FN2-aBKV6C8k_Rg-2; Mon, 28 Feb 2022 11:19:15 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AS8PR04MB8118.eurprd04.prod.outlook.com (2603:10a6:20b:3f2::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.26; Mon, 28 Feb
 2022 10:19:13 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.026; Mon, 28 Feb 2022
 10:19:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e24c069f-987f-11ec-8eba-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1646043556;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=AQkt4G9qJAq1JOtf4RGwi8Cs2gY6dB57H2P0CheBc8k=;
	b=RCenuOoyiwwQVO8D6Vt3vCsDFWDSZcPT1u8PUCfdFGx+UPnheKpAIQ4/MMskPHUyWlXdl9
	VqQ7IGrEdNBBQcEnDKaaDhnIVSY5bbINw959/2rTo6eKnJEQ51dV7SM0vOUJgoAYqtU5dC
	b3iJbEfBEAOZmoH2YLvwiE8lj2aTwvc=
X-MC-Unique: pTnm0Q0FN2-aBKV6C8k_Rg-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=BtVcu7HYXGn1KdwK7+FUH2+q27N/YeXYy2eQ0GS7MfbicVaUusywG3PtYNwFcF1oCEUvl1cp4seKXLQDsFgTjfXjD37V+nDOVOo6nwqBEQd0lXh0bPAUGUcyR5xyIxrbCCsN9Ph8zOT30jzbVOGt/12bRIR5K3UwlcYucyPVhmDJ/EFLyzscHQXrDEMCu4NdWhqEsQyLFiILk189Nzjep4VRPVh7ydqFbTMvHMx7gSz5MqGEJZILv/uq5kUUkQdE0VBKjBmu5iP0EQf3e7ed+8GjPnfPsqJNuJP7mVCJFpLq3vED3JF15cRkSh3tqwSYJR+5Lw/Ck1MaQGfX5PO+aw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=AQkt4G9qJAq1JOtf4RGwi8Cs2gY6dB57H2P0CheBc8k=;
 b=Ar4JeWMgvmeijYbBsPHjgBkYK57TTbtJHfJXoXzWv+jkWdwyqcIGwh7objOse7Wg0g2wHW7GQ6VGc3/TLt5k2YN2CC/FYj87BtuJDN8+XrcYiVY3ZyFQz8ugM5T1A11nzDaJqANMVP2+sjlLLiyJrg6MD6lzkzz5c+IFYcFybHZYXROn8J7HYLCkv8UUw4A0MSJ02PrLdtK9pEH1ljxOB5cDKRBzwy7lDwGCRx9A7qbtA2rbJkgBtQJPeAz3To5yHpMJTQ5J2lhPk2xRpN7hqEVZ0lVMJ3GiXj0kelXYD4K/9Y02rPWe1qyBUnEmlywbABlcpE8h7SB68jKAFhBN0A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <3cc8bfca-be9e-cde8-c481-657ef33de7f2@suse.com>
Date: Mon, 28 Feb 2022 11:19:11 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Content-Language: en-US
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH] docs: correct "gnttab=" documented default
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0602CA0001.eurprd06.prod.outlook.com
 (2603:10a6:203:a3::11) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c3ab7e48-751d-47a7-fdbc-08d9faa3c477
X-MS-TrafficTypeDiagnostic: AS8PR04MB8118:EE_
X-Microsoft-Antispam-PRVS:
	<AS8PR04MB8118CA743A26FE6C9A2E23BAB3019@AS8PR04MB8118.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	nNtfc2+5nLEYFCAZ88MKW3ZZYJ/nWo/BTN44XpHylLtOWMcPloD0xovSnP96+Gpi0r6hoed0mdkKZf8M161riQQcjeOXVanOa+hHgDENrWEm2AuCqc970/LjFbRH5TUgx9jTHb/y8fMn+548/Q4QR/0/oenE+cVHYSwM0ZgvhUZuc4qObu5AeR1U2u76LwUjFRnxybf4IWMRIicZgK+494mfB1CuO5lfKoFVZM97YaQY7/ECR0ayfrdLnnAdmGVXTNV4L5R/NllwQKRJuiJW1yQMVi50KPCfNxtxSyD6gcF2BcY6wEFaW/ZQvqLfAKMrRj9w2kt5tH2mBYwx82/QjiFwN5v+ii2WwDQGHcgiNCoqRKKQ3F/kVWSHjllsofVNJ3G20cCL9joPlRATHegYLRiz1LEmvhrrZwE8VVWitzjLa7kC+ZaOHFaD4LCsVEABJRZTioY84nXs9MndZu/zl0FGXmLsMqc7wHhL0vVQoCScYLMuM/tlsORh+QBgICyY+ySmI5c4yZeKjlJOYHsohnfQk6eXp+WD7wfCF9XE10QIzLjq9q+Pm4iDbBIaqBcawS7dZKvPbziG0EwyCmEddCNnQKJgSkTm6G+jRJjUCKm0gec7Vtq113rBjaGkKbNtKHA+S+6LLby8lyb4cOhy54mC89/l6umhJF7dSEOray6QIOFvaRFdox90Q/Khu4iLPbb2DaLjlKbdtRKNpVKe6to2wQU1XEF4Cn8y16tuZdFoFLCyB5ir4Xq/iyxW2At5
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2616005)(6512007)(83380400001)(186003)(26005)(6506007)(36756003)(31686004)(508600001)(6486002)(6916009)(66946007)(316002)(8936002)(54906003)(4326008)(38100700002)(66556008)(66476007)(8676002)(86362001)(2906002)(5660300002)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?clZsSUZDUFBob1hZNkdINFB0a3lEWlhQdVlHRkcvSzNBMzloZkN0QU5ua1Fo?=
 =?utf-8?B?UmkyazNNSEFtWWNzdWthKzNOSXJRYzhaOW9WbGVIYmdoUk1sL2pQdVU2NGd0?=
 =?utf-8?B?enc1Y1ZBbHUxU1hWYVRmSk5jcWwvS0p0cTAwOWFHTnJiU1BLeGNMQk5YTERi?=
 =?utf-8?B?dEE3ZzR6eE9IU1hBN3JtVlVYMWM1T3V5Y284bEJTMnVwL2VGQlBsbkxkT1ZN?=
 =?utf-8?B?Z1REVlBiYWo5eUtmNDF1SGxYQXV6bWtJcVVPMmdGZkhlWGVBUUlKNUVGOHpC?=
 =?utf-8?B?RnhPbzNTelA1S3JSOU91K3lpcHpCbGZXTVpCaGZKKzVaMVhSUVZxTnZrMzlj?=
 =?utf-8?B?dEN2bkUyTC9uQjdxL2ROZjJOejRmQUlLaVdlYmV3Y3dEYzVNMmlQdURaWVhH?=
 =?utf-8?B?Z1dOcGt4N3YwRUFhcURsL0FXeVYyQ0VKWHJBVDZjcnRQZ0hQeHVLckpHRE81?=
 =?utf-8?B?Nk9HNGFyc1ozRU1KT21hR1I5MDl0UWFRREdRZU9BUkNaYzV2cEU4aFpqWm5T?=
 =?utf-8?B?L0FEWU9uMWhKZFpJbFEyTUdHVWRidDFPRStzaGt0K2JDd0k2eWlDVmh4NWdG?=
 =?utf-8?B?eXhuSGhZWkcwTWFHdGJJNHNpV0xBMzBMa00xUzNlRXNVdjZNTWxNcjRqdzVG?=
 =?utf-8?B?dHh4OFhEMUZleEtMVDd2T1R4UU5GTTEwTDU0cXZaMmdNRmszV1pzamM3VW0z?=
 =?utf-8?B?RFl1ZEx1c2JIN2M0RnBYMXh6aU9SS1ZYL1lvRHIzM0wzd2xQazlaR3BwWXZR?=
 =?utf-8?B?WjFadkNTZnUrR2tPSzR0anJ3cWJtbmNDWDdhSVhuZ1VsWTJCbXlXNWpLNWpD?=
 =?utf-8?B?WGIrTmhoczZldFZWcEMyOCtzZno1K1dyVmdjTGNBYUhiUnJKL3Bsc04zZlJH?=
 =?utf-8?B?NXQ0Q21QQjRKdXZGTmNtaXBMYXRtRUR4N1Y3T2pwZzdRTDc2NlRrRE5FTXlF?=
 =?utf-8?B?RFF6Nmd0MGFKNmxqWFp4SHc3QUx6bE9mRWozWUpEQUJKYWMxa3gyekxWUXE3?=
 =?utf-8?B?VFI3TnBYTlZnTVAxN29WMzJqOU41bGVuRVRKY2JkY0k0dGQ4cUVKVkg3M2JU?=
 =?utf-8?B?THFlNmp4cGc4dnR0MTZwR2lJNEFEMDROa1NtRTY3OHJzaUkwblNBSktjTFQ4?=
 =?utf-8?B?b1RhSkRFQm5LMGxncTl0MW5sTmpJMVFMZG9VanIrUGtSMUIyeDBqZjNuM0dC?=
 =?utf-8?B?VU9wejhRYXdFQUNtMzRUM0FOaURmRElQQmpGUlcranRITjMwYlU3bk5zTjBy?=
 =?utf-8?B?T0Rib0IxRzM3Vnc3MkJKd3FUMmt5TG4wYkxZMnBGT0dSTmZYS3ZMOEVKeFQ0?=
 =?utf-8?B?Tm9yaGk1RDhQL2tud3NFRDQxNEpKWnFrWTY5Y3orMXk5TDd4RVUrZDZEWTZ0?=
 =?utf-8?B?b29PeGZrb1hpUGhIYlZTYlM5OHhqN1pNKzhya3R6RFNUNTlPMTV3dWJsR3JT?=
 =?utf-8?B?dStaU1ZtYjVzQ2VLNndLclFRVCt0MUlWM2RrTmQxaUNJSGhqUnpQWlQ2WjF1?=
 =?utf-8?B?dTdBcVNGcGxNRVBHaEpvRmpsUmpmSTVURk9ZSGU1OXF6THY4T2VYL29pcUVa?=
 =?utf-8?B?SlBlSkNNbmZpMmdFWXBZOUx4MVVFd1pJN0tDWk1zcmlqbjZyMTNJV0RXVi9p?=
 =?utf-8?B?bG5ONVNhTGsvR3ptQloyMGt3anZGdW1SZWZWSGRsRncvQms5TzUydEFSNVp6?=
 =?utf-8?B?dFVNNzVHazBtdVJlQytCb2hJTjRiYkVnT2RLck0yUTVsZDc3K0NJTU5odjgz?=
 =?utf-8?B?STh6Qkg5RDdybllMdU1lOWVSSzRwaVVTWmUzYlJHSjV2OVdPSElhUzdLcDVz?=
 =?utf-8?B?dXV4Zm9lUDg1S3BQU1hvSkFEWEpsbDVHQnU3cWU2T3ZUVEgvV1VURFgwQjRU?=
 =?utf-8?B?cU1ZVWJibkZjeEZMRDRPQUVvbUhOakVkcFdWMmlCWVNMYXIzVXEzTXlOZEtr?=
 =?utf-8?B?VkM1UUVzTDFXVFB6RUF0YVFPQy9Ta0hEc2ZtOG9tcmN5K0N4Z1l1Vk9xeWEv?=
 =?utf-8?B?eTB0YW5WcHdWem56U0JUWFl0V29idm1tU1loS3E0UWFUejdrSTJnOFo0RjBY?=
 =?utf-8?B?aW44V282RU9mVXc3NUxjdWpLQnFkbjNDODV3RjVsVmNNNjI5cldBR0lHbzlO?=
 =?utf-8?B?Ny91UFlsRzl1cElDUC83Wmw5aVRIUU9NWW10M2l6NXNCQ0xEU1o2cVpmWkoz?=
 =?utf-8?Q?4qtmHZ66Xk08GPUCR+5DsjA=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c3ab7e48-751d-47a7-fdbc-08d9faa3c477
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2022 10:19:13.3540
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KRHKqhgCFbuqx+eABHn9CDWR/g1TKl+bYO0v0d/hhWx1D8DPJcCjNjdd6f5CqQUov4P2WWHgIQzEatUGghOL1A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8118

Defaults differ for Arm and x86, not the least because of v2 not even
being security supported on Arm.

Also drop a bogus sentence from gnttab_max_maptrack_frames, which was
presumably mistakenly cloned from gnttab_max_frames (albeit even there
what is being said is neither very precise nor very useful imo).

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/docs/misc/xen-command-line.pandoc
+++ b/docs/misc/xen-command-line.pandoc
@@ -1177,7 +1177,8 @@ Specify which console gdbstub should use
 ### gnttab
 > `= List of [ max-ver:<integer>, transitive=<bool>, transfer=<bool> ]`
 
-> Default: `gnttab=max-ver:2,transitive,transfer`
+> Default (Arm): `gnttab=max-ver:1`
+> Default (x86): `gnttab=max-ver:2,transitive,transfer`
 
 Control various aspects of the grant table behaviour available to guests.
 
@@ -1217,8 +1218,6 @@ Specify the maximum number of frames to
 maptrack array. This value is an upper boundary of the per-domain
 value settable via Xen tools.
 
-Dom0 is using this value for sizing its maptrack table.
-
 ### global-pages
     = <boolean>
 



From xen-devel-bounces@lists.xenproject.org Mon Feb 28 10:20:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 10:20:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280352.478266 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOd8S-0000Gq-Qj; Mon, 28 Feb 2022 10:20:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280352.478266; Mon, 28 Feb 2022 10:20:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOd8S-0000Gj-NX; Mon, 28 Feb 2022 10:20:08 +0000
Received: by outflank-mailman (input) for mailman id 280352;
 Mon, 28 Feb 2022 10:20:07 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=A4HT=TL=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nOd8R-0007KG-9m
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 10:20:07 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id fff025cb-987f-11ec-8eba-a37418f5ba1a;
 Mon, 28 Feb 2022 11:20:06 +0100 (CET)
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2057.outbound.protection.outlook.com [104.47.8.57]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-15-s7psJOiJMEKXIMD4acaF3Q-1; Mon, 28 Feb 2022 11:20:04 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DB8PR04MB5801.eurprd04.prod.outlook.com (2603:10a6:10:a8::23) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.25; Mon, 28 Feb
 2022 10:20:02 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.026; Mon, 28 Feb 2022
 10:20:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fff025cb-987f-11ec-8eba-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1646043606;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=Aadmc9oy/kekIDpUESR5X2aTVRaZ+suywBUfbquNEK0=;
	b=chY1QGNK8TU7G3vF11V0oLTdSCiEhsOt0zXnm/lMzQFOJGqzjkIk5j/orwzFvnHO81GU4z
	RHaYpP1v5dT9xp0EaOyjLAgwFe5YFgsIlXn+aaCqT6qOcgIcZjUPv7sig+4hoYRgpysmg7
	RyMYKwJWAsl6Wx7G26Cn9P/+BurCHSI=
X-MC-Unique: s7psJOiJMEKXIMD4acaF3Q-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=f574Tgu6fkzaOnusL3WeddVgRACcEKiVWw3Q16DfYOqAI11U95uRnpM7vlDwcY2Oxuldn1F+1XtJh1Gn+dxbYSnLCl+Imp/cDKf1jywX1ybMK5Prj+zhG5HA2keQcBYUIobpNwdncJnP8zkF00prUYQnS/wmN+BDMd1CZ2Mpf0n6HJh0o8Wzr44SGMzlU3FuOVY5hDQAEcbNqf5Sk2AT3AEBuTAmKwCS03zPOsFVzxpwPDo7vxgz/E/vw4QiwNKRk1cU3nqaRslad9rORmA2HWXB46W9eJeNSknRbw4PPu+4fqNJl+CJoBnPeXNCmt6fWOrYJCzotCd8b2kn7nkegw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Aadmc9oy/kekIDpUESR5X2aTVRaZ+suywBUfbquNEK0=;
 b=ArqhjwoxnuGYDcTG72d05PFQmF2LlwTGG+X2PrpFfiqlYXi/YGi0qEkuXTdA9g/wHk1hHGGFiy14v0qMv3I/mMaYP0FRgBxav82Mjf3Uij38SZbxmC2rtWySEXWI6/sEEXo3fe9FqKe+e4xxwvZH4QwXdn3OhpaNEqGO8wYJQV02lK6HmRU9M61hIB5FkIfO1ySbVshsz5pkgTXdMNqKIONgE7BlHZB95VZ/RfkrHsbFOMsVKOM7nSz2DD7ZK35LIQdF+4eI+A+KCD7T2vnOjGGbzDSQ0a2EJ0P+bNqFrBRrnihuupIB2O520W0mgXt54G+wSzUc64OrGwjDHFeuSQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <329ac1cc-85d4-7ec0-a23d-a3f68c2864f4@suse.com>
Date: Mon, 28 Feb 2022 11:20:00 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Content-Language: en-US
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH] docs: correct x86 MCE command line option info
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0602CA0024.eurprd06.prod.outlook.com
 (2603:10a6:203:a3::34) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: aa47e653-20a3-4416-6a7a-08d9faa3e1a0
X-MS-TrafficTypeDiagnostic: DB8PR04MB5801:EE_
X-Microsoft-Antispam-PRVS:
	<DB8PR04MB580187405BB26AA000183DF4B3019@DB8PR04MB5801.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	BIcuyNaiF2zLeIRFJ6yzpkluTU6BPQgQlMOrjTQE+eHC0QYjRft0iVmy+1HhO7u2swItFZC7kPH94YlKACG9YwSwaXxpDY+YIXP30bO+xVqItyq9dLf1i+hu7vDlVDV+c3hNTcQxjEzHHjL1LyhNiB859rdh+3flGT81RpRRyH22aHUGpLIhv3URduH8lmXs7ET7vW0lKzk/OeTBbveyj4rDtEWYZlC/y6dTTR9egeJVtEFuhJWFNhIzjvbrttqx6VJvwOgBpJUjeNZrYW79fXNlpC6ldLE8Hw0ySd1gbRpjlXCWzYlrGtPoOaz6AATlCOj0p6cGT3d4nT9GX8Nxl9psq1NJQ94+Xy1FD2WfEBSPlBVTDlzKAstoLY94Y7ju3O9wkEM1r85sNxm0+IJUkKjeJ3VcqbRvk6vIR355Lgo+SucPasVRa3RV0ubt7fMyjdiZKhKjVaanK5vL4adk0QGYrcXAAgF0Xq6MVCog2Jc8H9nwj9rB1lsHqmOcJiRgBISIQZ5uHhi2q4WSooJ5MoHMXCpPPK4vfkwExnzs10MsatEn2lZ1AZYQIokir8oxHwIgrKgUOP+sSGIGXX3lDxsk63FloMHeTyfkQyGOJqGj3JnUEoj1D6AVnvqCUNQHFoQYCnUInyZY2gnenqOGiDDzjOsXfW3IWKJBNdW5HA5oDNRZzP60P2Lrnv5JpuWBY+eUHdpiPP/uXYldRzpGD1wlYK9cwOqKlWL0xCG3Oq+WrqyQ32DpMcA4ZyMijCPP
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(31696002)(2616005)(4326008)(6506007)(6512007)(36756003)(26005)(86362001)(31686004)(8676002)(66946007)(66556008)(66476007)(186003)(316002)(54906003)(4744005)(5660300002)(8936002)(6916009)(508600001)(6486002)(38100700002)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Unl5bW4weTV3U3BUdUNiTGEwNFM1ZkhFSDZuMmZMcVRPYmpyMlY0ZVdDT3Nh?=
 =?utf-8?B?N1NibkFLQzdrZXdPOUJsTnpWZTU1VTVsaWlPc25wWUJTQ1FYSW1oQjEzczVs?=
 =?utf-8?B?OFZ3V2kzMnh0dEN6TE5kOU5IenZ3UEE2TGpSaldHUndJa1c4K3duK29pLzd4?=
 =?utf-8?B?d05JVlAvbTJiQ1FvWUplZU94VmMzR2tNdElpcVB6Y01aWEZ1YzhWeXhZd1My?=
 =?utf-8?B?L08zenIvUVZSM3FSWG5IcmhSRlg2NXpoTFdzMUUzelRFUyt6ZzE4QlFUSDh0?=
 =?utf-8?B?MksxYi9nVklXQXA3VE9sdDlvU1VoSC9PTmNJWEl3NEhRblRraW94RVM1L1BR?=
 =?utf-8?B?UUtlNVE5eXNvVFQvWmtDMnV1cnVycDBraFZ1WWpOOUFsMS9CN0tRQ0hFRG14?=
 =?utf-8?B?K3NkbFR3MUM0RzdWem8zL2RZOEY5TXBCQmU4OGZDcjdUMC9rbVhaM3JJUzRC?=
 =?utf-8?B?OGllWVZFRG1yWGJYemlOQ25uM0R3R0Fpc2Q3OGFVbEhzbVpSUDkvNVllL2pi?=
 =?utf-8?B?OFVaVTd4M0FlTXJkRlhXN0MvSzVMSHdjQUZQbytDcEtiMFZEdE9BNWxJR3Ew?=
 =?utf-8?B?MGVHME1ORnhKS0ZPOXVIUmpwTDd4Vms3TnM4SG5uWWJTbGpoL1VyL1lGNXJP?=
 =?utf-8?B?Ynh1eVpxSXM3ck1pYS8vdjhvdzR4cjRLeVVxb21kTVB2R1AvT2pveGZlb3pX?=
 =?utf-8?B?VTJLOEhESmk0NEo5QzY1UzMzeWRQMklTQXdsY2taMXZUeXFYZm5ZMGhYclFq?=
 =?utf-8?B?ZXc2OVBudXVmQktwbEovM1V0SFgxT0VBcXlIWDU1VThVTnBhTVU4NzlXSDUz?=
 =?utf-8?B?SEJoSnd3WW9tQWJ5bGx6dVJRVGthS3NNd3J1ZytJc3N2SDdPS3hhZWFYckJj?=
 =?utf-8?B?Zjk0YWxxME5OOFRUZHh2Q0ZueVVrazJEYkY3NGZPcjZyQS9qMnRoZWlYK0dB?=
 =?utf-8?B?ZkpPdHlFN3g5UTZGMzNidERhT00wdFIvTlNiclJ5Q05uaW1GUFNvMTZ1bEtK?=
 =?utf-8?B?aUg2VEhlNktxbWUwMFFYdnIvNW01SDQyZVVxQ0dhSUhKU2xTanA3VnZDUG8x?=
 =?utf-8?B?cHVaUFVCaEpiNUNsbXpnbkdMcEs0dXpXbVJya3l3NSsvTy9BbXRLNTYxRStZ?=
 =?utf-8?B?a1Mxb2UvcUkvVGgzZHJtMlMrM3ZsK0xyekhkWXp2WExZZEtaV2FYbStBbFVQ?=
 =?utf-8?B?VzFhc0ZnRlZ0a2VyWUNaVVN4UmNocWxSb0p6UjF3dmxQRHplRmtaQXd2WXZH?=
 =?utf-8?B?WkhvajhhTFNZUmVnTVRxNG9GZHVjL1ZaUHM2djhKK2RlVU9JOG5lVFBVY2U4?=
 =?utf-8?B?YXd1UW1OZGU5M2N1M0JOS2NGOFNodlYvUzAvL1dmbWxmT3k0eU56cWJSZG9m?=
 =?utf-8?B?SEN0WUlac1FLS2JKMG0rbkdtcGEyRVdQTktJN1VVUGhWSnZZQVZYK1Z5aGNN?=
 =?utf-8?B?dHVyVTJoRGVNeW1JTDgrWUZUTHRkOGRUQWMwOXZ2aE1sQ0g2UUlEeUNMdnRj?=
 =?utf-8?B?UnFDU3g0VnhEbFV0eW9Zc0tiNitzRldaK1RaU0t5ZHpxcDFVMUdNb3o1WVFw?=
 =?utf-8?B?UDBzSkh1Q0dSMG44RlJxNVk2MDlETEduTmFZQ21vMUlFbmFQNVI5WTBEdU9o?=
 =?utf-8?B?VHZvYlpDZzlsKzhhY1ZhUjlYUzJXdmgxMzJ4VkJFalpNN2tIMkN4Q2hKVEha?=
 =?utf-8?B?LzVFTzc2dTZkYm8rSXR0ZnRzSHQrci9MaHhuc2EvSGxyRVdMRDZqVlNXMkhN?=
 =?utf-8?B?R2g0dkVHWlJVLzNZU0JrOWRIcGdNcVEraE1UZG1uZEl2YkMxcGY0UmlHK1Rn?=
 =?utf-8?B?RGc5YXR0WDZ6bWlDRVpzQkpEZGRYSzZybVpXdzdSQ3IycnpVQ3ZTRW1NNFJn?=
 =?utf-8?B?RkhuNVJVTmRrNlhLKytCaXUzVTdkOGhzaHMvNXNFd29EbWVvNjlRQlVpMHZV?=
 =?utf-8?B?dkR4SktkblY2V29uME9hd0F2Nk9BQzh2VE0rQk9uZUZGKzlIOWo2cXVrTE1a?=
 =?utf-8?B?dzdzb3FLYSt2QlJ3cXBIdVBhWGZnQXBpd2txZi9MemkyUWE3cXNtenZYV1E2?=
 =?utf-8?B?bmFIelFvR0JvNWRyb2JhNHp5RmJUSTI1elZhd2JqcURobFNnaFVLaVhheU55?=
 =?utf-8?B?L0NIRUM3VzNYaEovSElBNmE4ejZic3NKbDVuWS9GNE5IbTlrTXF6bUo3cldM?=
 =?utf-8?Q?8IQklEhFHlA9/hEYdrX3B5Y=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: aa47e653-20a3-4416-6a7a-08d9faa3e1a0
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2022 10:20:02.2416
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 06e3eFGpTQ85xowhZN8mNmAAnV6JkZiVPFcK8VCpZ1Johux781fYpGTxxZPcmI2s/fmgkuFj64QYbrGWjcd1hA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB5801

Not even the types were correct, let alone defaults being spelled out or
the purpose of the options actually mentioned in any way.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/docs/misc/xen-command-line.pandoc
+++ b/docs/misc/xen-command-line.pandoc
@@ -1681,10 +1681,21 @@ one pending bit to be allocated.
 Defaults to 20 bits (to cover at most 1048576 interrupts).
 
 ### mce (x86)
-> `= <integer>`
+> `= <boolean>`
+
+> Default: `true`
+
+Allows to disable the use of Machine Check Exceptions.  Note that this
+may result in silent shutdown of the system in case an event occurs
+which would have resulted in raising a Machine Check Exception.
 
 ### mce_fb (Intel)
-> `= <integer>`
+> `= <boolean>`
+
+> Default: `false`
+
+Force broadcasting of Machine Check Exceptions, suppressing the use of
+Local MCE functionality available in newer Intel hardware.
 
 ### mce_verbosity (x86)
 > `= verbose`



From xen-devel-bounces@lists.xenproject.org Mon Feb 28 10:21:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 10:21:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280359.478278 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOd9I-0000s3-50; Mon, 28 Feb 2022 10:21:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280359.478278; Mon, 28 Feb 2022 10:21:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOd9I-0000ru-1l; Mon, 28 Feb 2022 10:21:00 +0000
Received: by outflank-mailman (input) for mailman id 280359;
 Mon, 28 Feb 2022 10:20:59 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nOd9H-0000rg-9j
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 10:20:59 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nOd9B-0002e9-17; Mon, 28 Feb 2022 10:20:53 +0000
Received: from 54-240-197-230.amazon.com ([54.240.197.230]
 helo=[192.168.13.237]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nOd9A-0005hO-QS; Mon, 28 Feb 2022 10:20:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=SV/mbcYmKNPAzXnoUXei9cS1zKkGbdUlK8boeB4xTss=; b=zsBQjhvPVmQ0TC2HXqnlMDob2Z
	i1H9b4RGOMOdnTdXwO3ZXC8eeBmswfy70B1MwyoRVg5bUtmZ4aUPqfNTJOtW27DKsKWo8YmeBvb1D
	tBbrSpqRMQXAJUVHnfvkTC3c/5juZ+MCsdPigrYYvyAihBLq2kxZ8Lxn3uwCyS3OgPUY=;
Message-ID: <c55d7cb3-3d9d-59d3-6d85-69c115c8da89@xen.org>
Date: Mon, 28 Feb 2022 10:20:50 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.1
Subject: Re: [PATCH v3 14/19] xen/arm: add Persistent Map (PMAP)
 infrastructure
To: Jan Beulich <jbeulich@suse.com>
Cc: Wei Liu <wei.liu2@citrix.com>, Stefano Stabellini
 <sstabellini@kernel.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 George Dunlap <george.dunlap@citrix.com>, Hongyan Xia <hongyxia@amazon.com>,
 Julien Grall <jgrall@amazon.com>, Wei Liu <wl@xen.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 xen-devel@lists.xenproject.org
References: <20220221102218.33785-1-julien@xen.org>
 <20220221102218.33785-15-julien@xen.org>
 <fea3b34c-d605-be27-f75e-722b39cc48e3@suse.com>
 <ecb68523-1881-214a-b1e4-b239fed6ddce@xen.org>
 <5d218b78-876f-71c2-ec73-9958c7e472ea@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <5d218b78-876f-71c2-ec73-9958c7e472ea@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Jan,

On 28/02/2022 10:10, Jan Beulich wrote:
> On 28.02.2022 10:55, Julien Grall wrote:
>> On 22/02/2022 15:22, Jan Beulich wrote:
>>> On 21.02.2022 11:22, Julien Grall wrote:
>>>> +    /*
>>>> +     * We cannot use set_fixmap() here. We use PMAP when there is no direct map,
>>>> +     * so map_pages_to_xen() called by set_fixmap() needs to map pages on
>>>> +     * demand, which then calls pmap() again, resulting in a loop. Modify the
>>>> +     * PTEs directly instead. The same is true for pmap_unmap().
>>>> +     */
>>>> +    arch_pmap_map(slot, mfn);
>>>
>>> I'm less certain here, but like above I'm under the impression
>>> that this comment may no longer be accurate.
>>
>> This comment is still accurate for Arm. I also expect it to be accurate
>> for all architectures because set_fixmap() is likely going to be
>> implemented with generic PT helpers.
>>
>> So I think it makes sense to keep it in common code. This explains why
>> we are calling arch_pmap_map() rather than set_fixmap() directly.
> 
> I guess I was rather after "when there is no direct map" alluding to the
> planned removal of it on x86.
It is one way to interpret it. The other way is that pmap will be used 
when the directmap is not yet in place.

But I guess I could be less specific and refers to the fact the domain 
page infrastructure is not yet setup. Would that be better for you?

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Feb 28 10:30:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 10:30:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280368.478288 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOdIH-0002Pj-TD; Mon, 28 Feb 2022 10:30:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280368.478288; Mon, 28 Feb 2022 10:30:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOdIH-0002Pc-QI; Mon, 28 Feb 2022 10:30:17 +0000
Received: by outflank-mailman (input) for mailman id 280368;
 Mon, 28 Feb 2022 10:30:16 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=A4HT=TL=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nOdIG-0002PW-2v
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 10:30:16 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 67618f65-9881-11ec-8539-5f4723681683;
 Mon, 28 Feb 2022 11:30:09 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2173.outbound.protection.outlook.com [104.47.17.173]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-27-tZKYVeXONsu7q8-aH4W5Bg-1; Mon, 28 Feb 2022 11:30:13 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DB7PR04MB4571.eurprd04.prod.outlook.com (2603:10a6:5:36::13) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.28; Mon, 28 Feb
 2022 10:30:09 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.026; Mon, 28 Feb 2022
 10:30:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 67618f65-9881-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1646044214;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=3uRGGnjNNDfyD4Fb3eAqtsoKlIW1CI8VIMyjIbR8wMY=;
	b=Qpz9b8A6XosFCNYoSQ4iowrRHa06D556aBZJU3fnNpC2d9fNMlt/7hYV7IOplOXAqLmxdI
	emaKobOR+P/9Vv7oY3+voZeiVGyfI8b3pVyG3x9WOsojJOAOe80Vwq0GfENpT/8tzJrpw9
	YlMXhExK/PfJ/o+kvqvXpZF4TjH2s7w=
X-MC-Unique: tZKYVeXONsu7q8-aH4W5Bg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=VEjTO1k6H207ttR3bQ0+7ufA9bwhsKw5ULBGPL4bUgXXpZ8lBJkbNaXeBg4g+7mDfwit7oRoPqArDjSsfr68ETzVAMJ1EaO2UlkhyWAE7hn7J19VCIYBsmAWDio82xEvKtquCOETd8r/sGRhSXEBBhGeg1XAIdMYKwWsDaoT4DAmEo3bRXVTvPxAfuG7KFDstToByOhqHdxAvKI9AffVA3risCk11fhSKOCd9U7LWlY9ZeHZTeEJNBk1S5fiZN2+dZ//6kQnp/xrHeuhJ8GJ91dk0xN85ow4IYF/guiXOXO5SIRZ9bisvbPQyNZacJxfFyCu7BdkK1RAP+uS1noaxQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=3uRGGnjNNDfyD4Fb3eAqtsoKlIW1CI8VIMyjIbR8wMY=;
 b=Ff9fJDt2fLIZ6rOr+CY4oGXpo08AcW/Jv+bXpCH4fTNOuVDHfIkMrVrL/Q6XoNEhPqLUzurgx+lkEtM2YobKF52vhBwhVUr+AjiSeBaMgDHKp6uuq1xuudq5WM1+zQX6VG6tSbhW6tegrRupQYmUd6btQD+RhlFsbzDPJ1MWQgxhWHvOBqwfT/WdElKqeHs5qAcsvoEFBdifx5hFuNNnqFsJnmY0XjYzP9NqFyjqo3XhRX5SiNBZO1Jc2ybiJy43wOK8M0xYVh0eTC9BpBuV6cTd3hTBopesxQyYEvIaNOJ9ASvQ5iyyWRZ/VYwo8doAS8AtjX9o1e3XCoAacHqi6A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <9cb96dda-5450-6127-0eef-66aa2fb670fd@suse.com>
Date: Mon, 28 Feb 2022 11:30:07 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v3 14/19] xen/arm: add Persistent Map (PMAP)
 infrastructure
Content-Language: en-US
To: Julien Grall <julien@xen.org>
Cc: Wei Liu <wei.liu2@citrix.com>, Stefano Stabellini
 <sstabellini@kernel.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 George Dunlap <george.dunlap@citrix.com>, Hongyan Xia <hongyxia@amazon.com>,
 Julien Grall <jgrall@amazon.com>, Wei Liu <wl@xen.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 xen-devel@lists.xenproject.org
References: <20220221102218.33785-1-julien@xen.org>
 <20220221102218.33785-15-julien@xen.org>
 <fea3b34c-d605-be27-f75e-722b39cc48e3@suse.com>
 <ecb68523-1881-214a-b1e4-b239fed6ddce@xen.org>
 <5d218b78-876f-71c2-ec73-9958c7e472ea@suse.com>
 <c55d7cb3-3d9d-59d3-6d85-69c115c8da89@xen.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <c55d7cb3-3d9d-59d3-6d85-69c115c8da89@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0247.eurprd06.prod.outlook.com
 (2603:10a6:20b:45f::14) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 943f5caa-d911-4907-c793-08d9faa54b75
X-MS-TrafficTypeDiagnostic: DB7PR04MB4571:EE_
X-Microsoft-Antispam-PRVS:
	<DB7PR04MB45710F6C2B21173A7BDC3130B3019@DB7PR04MB4571.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Ty0f4wQ4Ookg2NWq8BSc3m1+y/sH9raQn7t4aWLdbNdZ9X6id9sCD+ZNKNK/XZVPdrAJw03/oy8w9iGSn9D/1/sxQFa/EXHgEt128LtAXxqA8/K9IrjZewivBlKgweGx2eFkIWni0dG47PmoEPpGZnOuk+fNITy8xCYErz8xD9Eb6nudm3w78KxcbjBJ4237jmEZTXBnce5uFopEXTYn4egQuSMe+Vsqar47RgwaKlQbUyxfPeFrnJEBvJKbwCGbzsGRK70Wolt1CvygVsz7TG6qweOmfcDl5jJQ1gDrjCNbWiDQhhrJTLGjdMg27ROH6lrLnQxdxI4OlvtxYXrlEbzG+BTm2YFR1otvX6pviPgxfQrVRw+bneHqjY0Wb6xq+f1OmwFOXtQTKLkrwAotBo5d8bxija0ypC+cyk+8DrQbjTs8SZnRYh1PkjIrQB6/DSz/gidJd3/F5yTps+rXl2bADL6u163YQfFyAj7Oew9Q+l8iPwoWPumlMN2NPOe8FlVwW8inoiMpQquuosuVworslcfHghevKb8XpZ5wHmdKQgFu64eO8Wgo9YRkQlFWM0WzX4AwI++62iy8O9SN4AQhBVlSpLtDWyMxRLNoDfq8sfmGVqB6z53W1vUKpfMo6YUbn11AWGyGDzjtfZZSXKobOfE92JRg/bOUM1KR3BkbSDCcXQbIWpef3Us28t7cLETK48hayXFc1SnFNuJhgsT1/YfluPlhtb0r0U4TWdrWdL6F6lDqpnkArAX2r25U
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(186003)(8676002)(26005)(8936002)(66476007)(66556008)(4326008)(31686004)(6486002)(66946007)(38100700002)(5660300002)(36756003)(86362001)(6506007)(316002)(6916009)(54906003)(508600001)(7416002)(53546011)(6512007)(2906002)(31696002)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ekZlNjB4cGZHUmM4NFZEa3Z4b0pJOFM0NCs5anY5V1hmN0xIK2tkcFdEM2dZ?=
 =?utf-8?B?ak9ObTU0U1lrVDBJcTFZTDc0V3g1VmlDbFNMZU5jVHdxSmJHZ1I2QW5lb3hj?=
 =?utf-8?B?RjVVMHF4MHFmNE9SMmF2YWVqSzVzWGRrY0FRZzY3cWFzME1JWkRMVlEreHlv?=
 =?utf-8?B?R0RNYzRsZTcyK2RIN1J4Qk5OOXJENXJ3Y0NrZDJMUTlOWVJ0ZHdNWkdLdjla?=
 =?utf-8?B?THNqUUZuV2Qvd3hUNldST0N3UVhlN1ZDTi9jTXRSSENhM3VMK2x0WVZIU2dS?=
 =?utf-8?B?TVVjTDFlRG0veEQveFlDZGtYclhuV1htbE9TUU04c2VCeTdYeGFzaUk3cngz?=
 =?utf-8?B?TS9CYmFkQVRKeVg0N1VnS0M3SjY1VkZYZHFzM1E2QmNqZWVyd1pidXB4b1BY?=
 =?utf-8?B?SW52bm9zaExQcHIycnpGc1JVVjg3ckZiWnNkZG5yYXlnWXdEcVN3NlJlQmkv?=
 =?utf-8?B?cW1HRHFXU0tvYjZzVUlqRmFKVHdjdTZ5cmF5aTNoQ3pCT1RNNUgvV2YvRkV0?=
 =?utf-8?B?UHIyVVJUTzcwN1dtaFpqcUpRQzlrL2NkTlcvR2RWcWpQRm1USEJ4RXBWM0h3?=
 =?utf-8?B?dGZuMVBhbFBTRElhU0NIMUpQcGM4QU9tN1hzcW1vZUkxd2pUNWlrdWVaZElx?=
 =?utf-8?B?c0ZsNEZqa1hnRmlLT0VBcDMwVjhUdXIrWWI1MURLV3JGc09XRW0vQ2x2L2hP?=
 =?utf-8?B?cWZ6NHIwK3cxSmRwM3M0d0RDMDE2TEo2QUFvZ1VsMkRPODVTNXVoVlhSZUVC?=
 =?utf-8?B?QWFCbkhEMnQzY2ZrOENpeDRuYTNJRnF3MnhzMytwSjU0UEVIbVkxQnh6bkFU?=
 =?utf-8?B?b1UrcnU2c01OZVRLQ05JTmVPTlk2TVgrZzBTN2U4cXZlMXdFK2FkSUtPeUJx?=
 =?utf-8?B?bTFjMFVMdS9EQ2trZ0dXaXdBOWtLTkN5R2cwY2dvOTE5MnJ4TTFURHFzZGRR?=
 =?utf-8?B?MjIrVVhLa3B0VzNOeWhrWkpBUkJUSjhUQUtaSXlHVlZuSFV0MEk0dWErcVc3?=
 =?utf-8?B?UVhuUzg5cDY5WUc2a04xQ0FMREFBL3VXc25CRDJ4bWpmNDV5SGFDd2ZLQk1t?=
 =?utf-8?B?WXdaS3krNG0yL0M1NyszSGRMYWVZYmMxbmdqSTIvUzBpOEJ1Vy8zai90YUl4?=
 =?utf-8?B?UVJOMFV6Tnh0N3M4ZEtaNU5ibG5xWklQRWlwbWd1RXpuSUtsZ1FCN2prcDE5?=
 =?utf-8?B?Z0xXTS85RVd5cDc1QWNmOTh3TERBei90NmkycElzOWFiVXNscXJhbUU3UXEx?=
 =?utf-8?B?MkhiT21TcGkyRVFGMlB1K0hBdnJtYWNPQm5JUjRESTNYd1ZnTGUveEdEWTBB?=
 =?utf-8?B?SDZiVmFaS2pFTVhFMTZBaGpIbGVqb2NkMkFGbVNjZFdVcnRjOGU1cDFzZENT?=
 =?utf-8?B?cTBhdndLaXdIWFk2WER0cVZTcHdaZ2pZN3FpTUJYcDJhczBqNFd1OXFGUjlM?=
 =?utf-8?B?VjhieFVGemc3VDlkZkkxMGZWTUthNGh6Wjc3NjBSNUdHZDErREJQTURXR2hn?=
 =?utf-8?B?YjJsUVBnV2szS3lIcUlLSk9Nd0NVd2E2SWI1WmNkSmgyZWQwaHdDbDRQQVpN?=
 =?utf-8?B?UTRxMzJyZzlCSmVUTGxMWEIyV1U1ajZpQUxOaXZWTGdQaVBLVG1OT2llbnN1?=
 =?utf-8?B?UTQ4SlUraVg2Z1ZZdkFxcmNMZFBkTVZOT1NOenc5SzNFNjlNL1FtYitUQ2U2?=
 =?utf-8?B?S3R5b2xpK2NNeXowTmtBSW11MkpyNXdJTmpmMVhZdnFLTTRRZVpVZitGYXZI?=
 =?utf-8?B?L1dIMCs4MmtZZUtOQ1FXUDg0UWM1a054bEZUNkpkTGlpakZKaW43cnk2U2xD?=
 =?utf-8?B?eHhVS1BFbUhyMzdnVTB3SlNBUU9zeFVzZ1Nuc05ETTFqZjNUVDI0WTc0UjRS?=
 =?utf-8?B?di8zWGl3b0haamoybmFzWTNKQmdzNGxuMjdSUkZ6K3UxVWN0OUVUdXFmalNH?=
 =?utf-8?B?K0xnY2cvR05CdWtxQlVGQ3d1TzJRUTF1dFErRDRaMlZtYjZXcjVPeEQyYUZa?=
 =?utf-8?B?aEF1T0JsNm0xTXl0OVByRUo5STZscGpncUlkclJxUldaM2VFanJBUkpYV0tQ?=
 =?utf-8?B?YjM0U1loR1BRRjZURjF4VVkwTlk1bGVvRjlEVFRkN2txdjVveTVCR3ZNWElV?=
 =?utf-8?B?Umw2V2M2VGtZdDF5TWY2Z3dBYlVUWE5QWTRWNFAxVWt2L2U1TGVYYXBGUjRM?=
 =?utf-8?Q?Y6nS4ZL1Lmp1JS81Hyy3CT0=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 943f5caa-d911-4907-c793-08d9faa54b75
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2022 10:30:09.3287
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2oJLUWToFxzCY2y69aQmP6oA0jHP7wyahfO02AieY969czBNNFEGIMi2EctHM+JT1y87LilnoRj9YdUusLlriw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4571

On 28.02.2022 11:20, Julien Grall wrote:
> On 28/02/2022 10:10, Jan Beulich wrote:
>> On 28.02.2022 10:55, Julien Grall wrote:
>>> On 22/02/2022 15:22, Jan Beulich wrote:
>>>> On 21.02.2022 11:22, Julien Grall wrote:
>>>>> +    /*
>>>>> +     * We cannot use set_fixmap() here. We use PMAP when there is no direct map,
>>>>> +     * so map_pages_to_xen() called by set_fixmap() needs to map pages on
>>>>> +     * demand, which then calls pmap() again, resulting in a loop. Modify the
>>>>> +     * PTEs directly instead. The same is true for pmap_unmap().
>>>>> +     */
>>>>> +    arch_pmap_map(slot, mfn);
>>>>
>>>> I'm less certain here, but like above I'm under the impression
>>>> that this comment may no longer be accurate.
>>>
>>> This comment is still accurate for Arm. I also expect it to be accurate
>>> for all architectures because set_fixmap() is likely going to be
>>> implemented with generic PT helpers.
>>>
>>> So I think it makes sense to keep it in common code. This explains why
>>> we are calling arch_pmap_map() rather than set_fixmap() directly.
>>
>> I guess I was rather after "when there is no direct map" alluding to the
>> planned removal of it on x86.
> It is one way to interpret it. The other way is that pmap will be used 
> when the directmap is not yet in place.
> 
> But I guess I could be less specific and refers to the fact the domain 
> page infrastructure is not yet setup. Would that be better for you?

That or simply add "(yet)" to what is there.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 28 10:52:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 10:52:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280375.478300 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOddh-0004s4-Ng; Mon, 28 Feb 2022 10:52:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280375.478300; Mon, 28 Feb 2022 10:52:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOddh-0004rx-KA; Mon, 28 Feb 2022 10:52:25 +0000
Received: by outflank-mailman (input) for mailman id 280375;
 Mon, 28 Feb 2022 10:52:24 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nOddg-0004rr-CI
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 10:52:24 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nOddb-0003A4-1s; Mon, 28 Feb 2022 10:52:19 +0000
Received: from 54-240-197-230.amazon.com ([54.240.197.230]
 helo=[192.168.13.237]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nOdda-00088S-RW; Mon, 28 Feb 2022 10:52:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=mL6WHjWnkX1s4k/eEgkeRtgtPNPagl79wz+BIyPKcQI=; b=uhzjYr4oz1lJLqZ08unqjCz5nw
	ToGkh9bfbKevbdk1b3kBcWlx61H0QdYsXnCpE3rNfk9EZ35qQ1mo3KsjZD7ZM5D3Ee8HfjpSwSjDO
	S6u8cio5iCiQaFiwqc6jAUmuLziCdOhb7uq1WuMbUskF+s0WXvDv7vM1afT3M3ON9ERk=;
Message-ID: <0fea3c06-b0b5-2726-f25f-10436258782c@xen.org>
Date: Mon, 28 Feb 2022 10:52:16 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.1
Subject: Re: [PATCH v3 14/19] xen/arm: add Persistent Map (PMAP)
 infrastructure
To: Jan Beulich <jbeulich@suse.com>
Cc: Wei Liu <wei.liu2@citrix.com>, Stefano Stabellini
 <sstabellini@kernel.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 George Dunlap <george.dunlap@citrix.com>, Hongyan Xia <hongyxia@amazon.com>,
 Julien Grall <jgrall@amazon.com>, Wei Liu <wl@xen.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 xen-devel@lists.xenproject.org
References: <20220221102218.33785-1-julien@xen.org>
 <20220221102218.33785-15-julien@xen.org>
 <fea3b34c-d605-be27-f75e-722b39cc48e3@suse.com>
 <ecb68523-1881-214a-b1e4-b239fed6ddce@xen.org>
 <5d218b78-876f-71c2-ec73-9958c7e472ea@suse.com>
 <c55d7cb3-3d9d-59d3-6d85-69c115c8da89@xen.org>
 <9cb96dda-5450-6127-0eef-66aa2fb670fd@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <9cb96dda-5450-6127-0eef-66aa2fb670fd@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Jan,

On 28/02/2022 10:30, Jan Beulich wrote:
> On 28.02.2022 11:20, Julien Grall wrote:
>> On 28/02/2022 10:10, Jan Beulich wrote:
>>> On 28.02.2022 10:55, Julien Grall wrote:
>>>> On 22/02/2022 15:22, Jan Beulich wrote:
>>>>> On 21.02.2022 11:22, Julien Grall wrote:
>>>>>> +    /*
>>>>>> +     * We cannot use set_fixmap() here. We use PMAP when there is no direct map,
>>>>>> +     * so map_pages_to_xen() called by set_fixmap() needs to map pages on
>>>>>> +     * demand, which then calls pmap() again, resulting in a loop. Modify the
>>>>>> +     * PTEs directly instead. The same is true for pmap_unmap().
>>>>>> +     */
>>>>>> +    arch_pmap_map(slot, mfn);
>>>>>
>>>>> I'm less certain here, but like above I'm under the impression
>>>>> that this comment may no longer be accurate.
>>>>
>>>> This comment is still accurate for Arm. I also expect it to be accurate
>>>> for all architectures because set_fixmap() is likely going to be
>>>> implemented with generic PT helpers.
>>>>
>>>> So I think it makes sense to keep it in common code. This explains why
>>>> we are calling arch_pmap_map() rather than set_fixmap() directly.
>>>
>>> I guess I was rather after "when there is no direct map" alluding to the
>>> planned removal of it on x86.
>> It is one way to interpret it. The other way is that pmap will be used
>> when the directmap is not yet in place.
>>
>> But I guess I could be less specific and refers to the fact the domain
>> page infrastructure is not yet setup. Would that be better for you?
> 
> That or simply add "(yet)" to what is there.

I will do that in the next version.

Thanks!

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Feb 28 10:55:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 10:55:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280384.478310 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOdgb-0005aA-AY; Mon, 28 Feb 2022 10:55:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280384.478310; Mon, 28 Feb 2022 10:55:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOdgb-0005a3-7R; Mon, 28 Feb 2022 10:55:25 +0000
Received: by outflank-mailman (input) for mailman id 280384;
 Mon, 28 Feb 2022 10:55:24 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=A4HT=TL=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nOdga-0005Zx-QN
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 10:55:24 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id edacf5ee-9884-11ec-8eba-a37418f5ba1a;
 Mon, 28 Feb 2022 11:55:23 +0100 (CET)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2113.outbound.protection.outlook.com [104.47.18.113]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-11-_a3Mkq0eMPGKcom7fCeXjw-1; Mon, 28 Feb 2022 11:55:22 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DB9PR04MB9380.eurprd04.prod.outlook.com (2603:10a6:10:368::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.25; Mon, 28 Feb
 2022 10:55:21 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.026; Mon, 28 Feb 2022
 10:55:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: edacf5ee-9884-11ec-8eba-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1646045723;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=AWMAvVLUzAlPIALvxFzTyfDprfwHU18wpSDT0wk2wt0=;
	b=LtqSeVtIxP3CoBlx509DfXq3RIrDkx/ZCc+kvknz5Bte+R0cKsNwGj1YD0mYPOq1NL5wP/
	rgNcqusuXoxooB95PPrbzKpf0ZLIGeONVhAcqORcW3FKDdAi2eUgyfJdyUijg48OZ8XChK
	Ro3cNGjKSUvm6RTmFxoUB2P0XV9/oew=
X-MC-Unique: _a3Mkq0eMPGKcom7fCeXjw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=EfBxvATKfa3Gza0MUFDkrJFzdi9WJRtWmA0tHhxb2ihU8F8tf4Z4hfyNOmyttMSaz7fI/ftfJM/ZhlBD3iOuYxrMONEv5lUxGBYqJD7Ru/75rXThmkzMyQHFurGuSY0Z74rupAMoYxrI4XDYOU2EoPYNfJuyN7ganCQf3vsDkeOhyb+slFEhWjvka8VCJOwZq/ENJTy1lKZpyyaPMJh+Ln1XVnma1Txd7as/z8FgQle7HmICzSoKotQNeCiJrpJBAiBdTeTkJL0edDm/zpu5FIqpQCmdcWK0lytH8r3mwPn/ZMSBGyueePOEsKCoG8SCTnAE1pjUJbDoStm4mE753g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=AWMAvVLUzAlPIALvxFzTyfDprfwHU18wpSDT0wk2wt0=;
 b=QaEuMa2RwH1z2lDu/EbJ+jdctrvbFOqqU7kFU8u1OMGJwpo7mUwJPT0gCCPWD6f8JRnLXrRWYovpMVB6kqz4LakvkMV8HuXOxGpKZYSU2g6W/MwNse8Am1J9rF6u7tRsfCPZYXO3/KdxW79mJrULNbE8fHI7ZJ5fOSgOO/MQpJ/3DhZcLUk4wB3Vh6hG7Cz6+2Al4rvzFiRFnQDZOqVJIfmfA50t6nXzWBf79cyNRCTHw3bvMcYiR4ApwWwkz1nLynHRIHSP6tje/CIU4MsuIDYiIwGpSzESHFNdJXEUsOKMJG1Gs3OnvNTi0DP3gjadVqUFxHDQ6uDLYXTh3tKwbA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <e9c810a1-47eb-6901-1a55-481a6bf4c0b7@suse.com>
Date: Mon, 28 Feb 2022 11:55:18 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Content-Language: en-US
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH] x86/CPUID: correct FEATURESET_7d2 comment
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR05CA0005.eurprd05.prod.outlook.com
 (2603:10a6:20b:488::12) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7c329dbd-6adc-4ad4-e240-08d9faa8d04c
X-MS-TrafficTypeDiagnostic: DB9PR04MB9380:EE_
X-Microsoft-Antispam-PRVS:
	<DB9PR04MB93808CD5B990070F0891F3E5B3019@DB9PR04MB9380.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	I2M7nui6BmFQdll1VV2P1zPeZyWtTRbCAnAc6W8F9pKge2aIugoOR5gFDFGIZis/8c3TrmiaMs4AhlOpt8kK7/D2RHmI4dzl8oLU9wQZQDf4uxS19rQ8dS6bMe16EPA1s+qOSUEBnJUpyxFGjkaBAARQ+UPVQ14Uj+f4Cel4wLpJoRSgU/baVR9RyAWRkRKe6NKx03cpPVxxfA9RDcTrEA2NtV+Lkdy/m48+vj/Xsz221hqFnrHxEi4Pw8Mifb7uz2sstKh7JGaN8Ab2LdAWuFkUgOXr+LReaUXY2Sn6LCyd4fJ7PrSN1vYj5SpewopffWBGRCmNmW91s1nP/jD6bOMwtpAtq3PUViPC0EXjqq14RpVgaaEBTfK3hcvzQMDEgUPMxUBbM/UwEISK9tc4ajm7EzaWkqoA4j8cYfOq4Kv2XNu+HOepCfrhxYXGFwByl7cwZnk/pPH0m6gztTEaZIiIepQ3Qhgk/3YZ9p3vPZwpSqWthX9gPQEt7jctSttW/la5W4N1SbR9vxCLFaP4slEjRTvd3caTcJJL4ASclNkanGyOnK0VQoqTbzid0OyrQa0fiwYDbCvy6HmJFqi2EAbFchBkgwEF7baiUz7+mCnt1tuk4QteR5uSEVry67kVe79vK8ETAHhDb1jvt/VEXA/QT/YqvqrqsBhObNTkVsMSllcHnjLQwEihMcYyKvmirPd0fa7AheRPEcDzH7CvtRroV3gAyLsc5q2OT6Xue+Y=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(86362001)(186003)(6506007)(6916009)(8936002)(36756003)(31686004)(6512007)(31696002)(2616005)(26005)(508600001)(54906003)(316002)(8676002)(66556008)(6486002)(66946007)(66476007)(4744005)(5660300002)(4326008)(2906002)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?MktoTktWNlJoaEtQcEx5KzVoMmRkMGZTR1E1R29MYmlNdi8xaCtEN25nZ2Ny?=
 =?utf-8?B?cEFxQ2N5ekVZdHk4UVBSeG5DTDdFczJkaytORGpJMFNKa2pWb2gvOE8xTUJW?=
 =?utf-8?B?a01QQjdJZjkzM05KeXRydVZSNngwSTNpUXFCZENwRFpOTVM2bTZtZnhvY01o?=
 =?utf-8?B?RWhmVTNWSGhLTGtTdkF6ZVMyNndlbkVMMVJlWHdRc1hYME5OdXZuQTBQdlQv?=
 =?utf-8?B?Qk5PdnZvbzc1b2FKNFc4VGwvVHVIdzN1bXJRdkRMdElZL09yTGVsVzl0R2tw?=
 =?utf-8?B?ajNiNFYyMURNVlVnamU1dEI4TllFVlM5emxJNEJwbDJZT2s4WjVOaUNsUWV6?=
 =?utf-8?B?akpEYnNFNUdzTzg3aFRHNmZ1cUpIOCszb0xrSzlXSGFrTGVkc2x1NVZ3bzhq?=
 =?utf-8?B?UXo4VU1TRXhuWEJQSGVsUFVPL1ZvWm1vOHVrSFMrci9lQmJobFJXbi9SSjFE?=
 =?utf-8?B?SjV6cXBIMmhlNjB0eGY0Mkp4TlBNdGtkNWZ0eGhRb1JFcVNEVXRGYmpwSlg0?=
 =?utf-8?B?dlhkNWlHS1Rtc1V3RGl2LzB5cmtqRU9FZDRzMUNHZ0JEbjhjSlFVMi83R1JM?=
 =?utf-8?B?dnpSV28rcENwN0dTbWZSTmlHZEV5bkRDN1dWd2hUOXIwWnZGaWtyYnpkTmVz?=
 =?utf-8?B?NFJuc1Y4aDJIbldSUzE2UTF0aVlKQWswaHlZZmg4OTUyS1AwMThPR09WODNq?=
 =?utf-8?B?a3NCRWxhaFd1UGVNNDRQK1p5K3E5c1lneGZJWjJ5V2JULzYyV1dRUGsrNUFy?=
 =?utf-8?B?KzlrVm5VVk5NZ0MzeVNiL2FNOXFGTy9iMHNzRkJVYWxaclFkR0UwMkZUbEJL?=
 =?utf-8?B?Qi83aGJyMDEvcUs2Z1FkZUZBUkh6SVo0ZnQ3dzdYT2xHdkdtR3M2OGZXWVlx?=
 =?utf-8?B?OUJqK1hvTVVtbHNtU0dmaWFRUDNvemx5blJObmdlWXRvVkF4UStjTlg1YVhB?=
 =?utf-8?B?MFVBYWw5dTdqWnFJb2pSVGkwSFNLNFEzWUdlS0p5UmxYVUhidEtlUmd1UW9I?=
 =?utf-8?B?UXpCZWUvcjhzZHZ4YmxCTlkxN3VhbGljNjdsRjVOM1I3QURvM0VmZXFsT3py?=
 =?utf-8?B?ZEl3N1J4QU1RbERzdlZENjdtR0RFVjZHRUJ1bjVucFRZSEFHdmh3ejN3b3Jl?=
 =?utf-8?B?c0RWQWcwd0cxV1p1bkdpaFpSK2FWdmRmNEttZTk0TVZ3THdpR21PMTdMNEh5?=
 =?utf-8?B?YjVqSjREK3RrRnY4TXZua0U2b3BaSVFEc3d5TFpwU2s5OUphK3BmY1BmbjZ0?=
 =?utf-8?B?b3ozMDFkNnViSVpZc1lOMEt2SlJXODNDTThYNC9sSEEvTTdpeWoyVy9nL0NH?=
 =?utf-8?B?bXlBQXhhczFoSU1IM2hqM0RTdW5DMngrMSthYnFWWkU0WHNSMW00UGFBdWc3?=
 =?utf-8?B?bVdLTHdzWG1UMjRNZCs2YWMwT3VydTR6cGQ5a2t5NkxzNEl4NGtNSXNBRWEx?=
 =?utf-8?B?bEdTdnJnbFNRL2g5TElFZkNERWk0bmEveVV2SXhFT1R0UlUzWElyTzNzempR?=
 =?utf-8?B?RW1uaTQyeFhhQVdGOGp5WWtTVFowMHpNNENvQVkydWNnK2x4YnF5bkRMUnpy?=
 =?utf-8?B?OWdIK2dCS21nOHFqbGJBeGoxbDFqVFZKSU52MDR2M0lhWFhaOU9jd3NXK29a?=
 =?utf-8?B?Z3hzMkhVY1Fna3ByakFlcFR4MkRtdThoVHM1aUdrOVV2SFFiQmhTY0t3QXJV?=
 =?utf-8?B?Mll1K2hrQSsvOE54U1NsL3FzQVFaUTJKUHp0TGYxMG1rWFE0TDNUcTc1cWRZ?=
 =?utf-8?B?V0RmNExrOVU4MitqTlhiZDRFcEJraEwrQnpJaXVidkR5YTJBRS9LaThCUDMy?=
 =?utf-8?B?M2ZNSWxyeHpoWXV5aW54UVR5SUE2enZVSVc1MERTSDNmMFNDR2w4OXZrMVVi?=
 =?utf-8?B?Q2Z4dlVyUHRScXN6MjU1V0JMWmpkTXF1RHZ4NkdpSzJRTnQ4WWhGa0kyVkNE?=
 =?utf-8?B?RUxlR1hoczZRTXJ1TzRtWUVXc0hCZXp4QWJVbG5XVzNXaXNxMmJjZ1R2WGRx?=
 =?utf-8?B?MkdISkprSzdkbGt5ODhJKzRaQ1l6ckMyOWhnNXJPbkR5SDBQRFBpQWRPa3Rw?=
 =?utf-8?B?aUdFLzBjY2F6WDlUTWdlUzNxYVhoK3lRZkdBQVd0djFDTE56YjNKQk90OHJu?=
 =?utf-8?B?eWJ5eHpYM0pTRWw1V05jcU1GSkxIOWd5QTZSRVJOaGlQS3hGUkNvMnhvMHNQ?=
 =?utf-8?Q?jJOKdeRMtv3Lvlc5tIpG5U8=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7c329dbd-6adc-4ad4-e240-08d9faa8d04c
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2022 10:55:20.7503
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SQvQCyqW2BqjfSBhficMbrSpDscoZ4MpXZk/4RQk9N/Sez+ZnjYLM4gCpssNSClbR+jkSi9UZVwpQLmqw/V3ng==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9380

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/include/xen/lib/x86/cpuid.h
+++ b/xen/include/xen/lib/x86/cpuid.h
@@ -17,7 +17,7 @@
 #define FEATURESET_7a1   10 /* 0x00000007:1.eax    */
 #define FEATURESET_e21a  11 /* 0x80000021.eax      */
 #define FEATURESET_7b1   12 /* 0x00000007:1.ebx    */
-#define FEATURESET_7d2   13 /* 0x80000007:2.edx    */
+#define FEATURESET_7d2   13 /* 0x00000007:2.edx    */
 
 struct cpuid_leaf
 {



From xen-devel-bounces@lists.xenproject.org Mon Feb 28 10:57:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 10:57:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280392.478322 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOdih-0006Et-Ni; Mon, 28 Feb 2022 10:57:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280392.478322; Mon, 28 Feb 2022 10:57:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOdih-0006Em-KN; Mon, 28 Feb 2022 10:57:35 +0000
Received: by outflank-mailman (input) for mailman id 280392;
 Mon, 28 Feb 2022 10:57:34 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Cvol=TL=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1nOdig-0006Ef-Fu
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 10:57:34 +0000
Received: from ppsw-31.csi.cam.ac.uk (ppsw-31.csi.cam.ac.uk [131.111.8.131])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 36d9d8a6-9885-11ec-8539-5f4723681683;
 Mon, 28 Feb 2022 11:57:26 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:45844)
 by ppsw-31.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.137]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1nOdie-000vQb-Ja (Exim 4.95) (return-path <amc96@srcf.net>);
 Mon, 28 Feb 2022 10:57:32 +0000
Received: from [192.168.1.10] (host-92-12-45-187.as13285.net [92.12.45.187])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id D3AA91FAB7;
 Mon, 28 Feb 2022 10:57:31 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 36d9d8a6-9885-11ec-8539-5f4723681683
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <cf739bff-9405-31b9-5741-e5ec1989dec7@srcf.net>
Date: Mon, 28 Feb 2022 10:57:31 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH] x86/CPUID: correct FEATURESET_7d2 comment
Content-Language: en-GB
To: Jan Beulich <jbeulich@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <e9c810a1-47eb-6901-1a55-481a6bf4c0b7@suse.com>
From: Andrew Cooper <amc96@srcf.net>
In-Reply-To: <e9c810a1-47eb-6901-1a55-481a6bf4c0b7@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 28/02/2022 10:55, Jan Beulich wrote:
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> --- a/xen/include/xen/lib/x86/cpuid.h
> +++ b/xen/include/xen/lib/x86/cpuid.h
> @@ -17,7 +17,7 @@
>  #define FEATURESET_7a1   10 /* 0x00000007:1.eax    */
>  #define FEATURESET_e21a  11 /* 0x80000021.eax      */
>  #define FEATURESET_7b1   12 /* 0x00000007:1.ebx    */
> -#define FEATURESET_7d2   13 /* 0x80000007:2.edx    */
> +#define FEATURESET_7d2   13 /* 0x00000007:2.edx    */

Oops.

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>


From xen-devel-bounces@lists.xenproject.org Mon Feb 28 10:59:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 10:59:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280398.478333 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOdkA-0006oM-1k; Mon, 28 Feb 2022 10:59:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280398.478333; Mon, 28 Feb 2022 10:59:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOdk9-0006oF-Uq; Mon, 28 Feb 2022 10:59:05 +0000
Received: by outflank-mailman (input) for mailman id 280398;
 Mon, 28 Feb 2022 10:59:05 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+aRg=TL=arm.com=Rahul.Singh@srs-se1.protection.inumbo.net>)
 id 1nOdk8-0006o9-O4
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 10:59:04 +0000
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01on060b.outbound.protection.outlook.com
 [2a01:111:f400:fe1f::60b])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6c055f55-9885-11ec-8539-5f4723681683;
 Mon, 28 Feb 2022 11:58:55 +0100 (CET)
Received: from DB6PR0801CA0045.eurprd08.prod.outlook.com (2603:10a6:4:2b::13)
 by AM5PR0801MB1746.eurprd08.prod.outlook.com (2603:10a6:203:3b::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Mon, 28 Feb
 2022 10:58:59 +0000
Received: from DB5EUR03FT023.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:4:2b:cafe::f7) by DB6PR0801CA0045.outlook.office365.com
 (2603:10a6:4:2b::13) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.23 via Frontend
 Transport; Mon, 28 Feb 2022 10:58:59 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT023.mail.protection.outlook.com (10.152.20.68) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5017.22 via Frontend Transport; Mon, 28 Feb 2022 10:58:59 +0000
Received: ("Tessian outbound 341d209a0e52:v113");
 Mon, 28 Feb 2022 10:58:59 +0000
Received: from 934c4f137e48.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 18F71A42-F5AA-4357-BEBE-7B441BA11F73.1; 
 Mon, 28 Feb 2022 10:58:48 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 934c4f137e48.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 28 Feb 2022 10:58:48 +0000
Received: from AM5PR0801MB2020.eurprd08.prod.outlook.com
 (2603:10a6:203:4c::14) by AM0PR08MB3154.eurprd08.prod.outlook.com
 (2603:10a6:208:5d::19) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.25; Mon, 28 Feb
 2022 10:58:46 +0000
Received: from AM5PR0801MB2020.eurprd08.prod.outlook.com
 ([fe80::253a:4d6c:61c9:af60]) by AM5PR0801MB2020.eurprd08.prod.outlook.com
 ([fe80::253a:4d6c:61c9:af60%10]) with mapi id 15.20.5017.026; Mon, 28 Feb
 2022 10:58:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6c055f55-9885-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=xoUexgLwkNBY6TJrBqOMyZkSaJA5m1dC2NBxKn56Wg4=;
 b=AXHBXyQY3gkHXcywVJbpOb97tUA/Gcca/ssapNpmHRz5KEEzUyTiM2y8WYZEmk/M4pB1jM1GgWwxiSKYp25agWBaui0GPNyEjBvgQF4tRLDADh+103on/ue+5p83DrdSN41NodVqe0yoxbruBm+G5eNDpl0EsCRMgX9pJYQ/fvE=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 0d1ec8e5968c1f85
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=UOXHCZhSCDBfXL3xVcjkcl7vicYWM1lJgUwlfSjRvssyoMndc1uKwbzcLMcvSs0Hn5YUKHq3rBXNidDoFZe/9OTg/qFZFlOM44kvr8H2j/Iw630bbmn0SQ316IKrfDNpuyso1rDs1mAj4zmShGSm5Y28p5ZTYu00y/5yvobxeT0oqkJQ2mY5VWD23D08SENlIW+zAMXHJi4vE3V9xDeUJIXiS0qTQfkmPjtkF9ErbbooBWxAsl7SrzxLicm/t4ee9gnd7suS4n+JlQ1z1XGUt8/9Kuoy8YhcRGSKT+zEzVREiS9OMmt/k1KbO7JlCK9j0L5UIDuiW011+/PZRfx4TA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=xoUexgLwkNBY6TJrBqOMyZkSaJA5m1dC2NBxKn56Wg4=;
 b=M+0v4YcP44eiXkkdekYnsycjt+M1RIRklpvaGMLaTDY8l++Di1nmR/nwJZfPKX2uM8tq4l/4tT1rwvBzJ/tdYfSVBoUvx9npNXIw/F+elP0Zmpl35YizmJ3PxKMdN7G8hx3qlCjAryzFvfyhQUtZM+03+DxtQIl/j/Z7rPSPqrUqEt/6Kjq/ZjtsDZAhzaFJ1AoueQ1wINqarMahakyY5mMt8AfLfbMMsLfOgxOeGtJfK1gKEfZl+jtaEI1swuSucszK9lK7vlRPDHAN5DyCN+R4haOjnAn9N6EE4dNRRm91V6UnddIj8u1m3JXxKsV/7DOMNvW63/OfG5sIgpi6cw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=xoUexgLwkNBY6TJrBqOMyZkSaJA5m1dC2NBxKn56Wg4=;
 b=AXHBXyQY3gkHXcywVJbpOb97tUA/Gcca/ssapNpmHRz5KEEzUyTiM2y8WYZEmk/M4pB1jM1GgWwxiSKYp25agWBaui0GPNyEjBvgQF4tRLDADh+103on/ue+5p83DrdSN41NodVqe0yoxbruBm+G5eNDpl0EsCRMgX9pJYQ/fvE=
From: Rahul Singh <Rahul.Singh@arm.com>
To: Julien Grall <julien@xen.org>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Bertrand Marquis <Bertrand.Marquis@arm.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v2] xen/arm: vpci: remove PCI I/O ranges property value
Thread-Topic: [PATCH v2] xen/arm: vpci: remove PCI I/O ranges property value
Thread-Index: AQHYIoHYpqU3AM3970ClQynMQHDrAKyku6EAgAQjqoA=
Date: Mon, 28 Feb 2022 10:58:46 +0000
Message-ID: <AA247D7F-A6FA-400A-9D2E-CB1FCA6B9BE5@arm.com>
References:
 <8ea25f00c8641bfd95a4d8444b82ca2ac3ee5ce0.1644939115.git.rahul.singh@arm.com>
 <dbe2395b-c533-c7f1-bec1-70f4399b430a@xen.org>
In-Reply-To: <dbe2395b-c533-c7f1-bec1-70f4399b430a@xen.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 87bbb78e-7e4a-48dc-9bbf-08d9faa952dc
x-ms-traffictypediagnostic:
	AM0PR08MB3154:EE_|DB5EUR03FT023:EE_|AM5PR0801MB1746:EE_
X-Microsoft-Antispam-PRVS:
	<AM5PR0801MB17460FD1BE742BFBF9CEDE07FC019@AM5PR0801MB1746.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 OIh9QvutfQSQp8MS6Tqd5YtW7EJUAK0LydKaycYJU1f6KsFbn0HESnNA/EGqip+e3v10dV9iKrRQE4SmXPiK4lu1Z6zrnxfl32Efp3gYPX0O3xRnBssIS6ykqFj8V5iE+YuZlORJtqvjLib7UNqCSUez1wQC29VpRWldyLNIOK6QA4zS7qoDgRbh9Aq7Tz+u2KJ1fH7HjSBVWwE/0zOfWz23jnT7BQY4nHg960OLAQlWW85HmjJ4FZciLLl0rgCz4BGiyyaU/3yXqHkvkGQxDAz2+7aVx/saxm1QCkmciDS2pDU2uwS6DIXtO4KvMuqIX+HkyJ5uOJx9UyACt6oiMhfaMZTyZh23feOSZkcB3jU1YbtzWlyAES4VVXkSh0f3q6V4aI63kMU3QOHvcgNaoJ8IkGsPqD79L5y0M2Hhh1aF0IfM7WI/NbGpeMCTf5RWV6HlXhxJ+7Y+syqAHFqJs1r3e2N2eR2azX+BJmRBuA9alicmOCvhLq2q3UZTwEkCxfL+JZ9zh9eVKqwu55aKloQTRsFzItmyvYTMctJADYc5aLE6uELJrlzS+XUlYmu8GWW8gQ9z285A24jhCuXFCaWD5jBjUszy1oxG/Gde3aFvG9+bUiNQWi370LUIyCo8E7oNT8HFZtTt+abIl3IoOFNQimMxLIg40vYMwWq5sOkJi9DWFbxxdrgIQfeLdgzvW8F8nMvfj5ytZF/advBb60FLZGenhX2/+Q6tkEy4ZM7FPM4a+SU/9Cl5Ab1FioQU
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM5PR0801MB2020.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38070700005)(6916009)(5660300002)(2616005)(6486002)(508600001)(83380400001)(54906003)(53546011)(66476007)(316002)(66946007)(91956017)(76116006)(64756008)(66446008)(8676002)(66556008)(4326008)(86362001)(8936002)(122000001)(71200400001)(36756003)(33656002)(38100700002)(186003)(6506007)(2906002)(6512007)(26005)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <F503732964DA9A4F9F58BF525BB6E4CD@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3154
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT023.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	6c4934ce-f3a0-447e-66bc-08d9faa94aeb
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	DLj9V+39ooOZhaXfbaJadifeLCuxxv/7K96kum+xYFogs/96q7lAwR4IOS3g1nz6QRvAXpfhqClTlPNSoRd0W55LwQwh1QNAW4T37rtnF7qnsow6NcV2b39T3GWZL0Qwg0MfGnVAgCwWTHGEAttQdaPI+hwfjgvtCwLExW0GIt1X1g3EE/yv+vMKtWnNLii7yajl3Q2KkLAA8xDTuGs5XzRLkJcWO7pXNiioGwPBhRbl2OgpVzX0PjV7mHMG9TY1k49fqdjvdm6sQLWeOOI4f5O1PsLPAvvPPrQ68QgcYpuJz1v9Kn7taYfTuJmKsL3v6RK33eE8zfrSDnAMzTFeHJziceKtUOTxd9yQmm2xNlIyxgZkW8QiHvGIEhN7KEI3UMRfDT6SOq5q/leSyvmR20BMINBrjVyzWSgrsLcctZyDCXpWv0ffO9D7j/p+D+CEZAVttm8uejkpG+DqQHMlHBBDu0qZTsPuojpsDebNHPBIs8fGizKYxVMWLFW1OSaez7aF8snNRkzHT9diR0Q3qvmG0O6CAbZ1d2WRJSok66+7Naj7VyJ5Nji8ZHAQkweUNNDZnUBN1UVc8LNdY7OH6HDFe0lK3Ju9Li+8ej3AfRah3BSM2qj7ASmt6lk5UV/kDQ482z9W/9lcl+XvYRdWByyS8S2wUFepQpB9djVkI83kGK1QeySFQmm04Rhd2cH5
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(83380400001)(82310400004)(107886003)(316002)(6486002)(508600001)(6506007)(6512007)(356005)(53546011)(54906003)(2616005)(26005)(186003)(336012)(81166007)(33656002)(4326008)(8936002)(47076005)(6862004)(8676002)(5660300002)(40460700003)(2906002)(36860700001)(86362001)(70586007)(70206006)(36756003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2022 10:58:59.6086
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 87bbb78e-7e4a-48dc-9bbf-08d9faa952dc
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT023.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB1746

SGkgSnVsaWVuLA0KDQpUaGFua3MgZm9yIHJldmlld2luZyB0aGUgY29kZS4NCg0KPiBPbiAyNSBG
ZWIgMjAyMiwgYXQgNzo0NiBwbSwgSnVsaWVuIEdyYWxsIDxqdWxpZW5AeGVuLm9yZz4gd3JvdGU6
DQo+IA0KPiBIaSBSYWh1bCwNCj4gDQo+IE9uIDE1LzAyLzIwMjIgMTU6MzYsIFJhaHVsIFNpbmdo
IHdyb3RlOg0KPj4gUENJIEkvTyBzcGFjZSBhcmUgbm90IG1hcHBlZCB0byBkb20wIHdoZW4gUENJ
IHBhc3N0aHJvdWdoIGlzIGVuYWJsZWQsDQo+PiBhbHNvIHRoZXJlIGlzIG5vIHZwY2kgdHJhcCBo
YW5kbGVyIHJlZ2lzdGVyIGZvciBJTyBiYXIuDQo+PiBSZW1vdmUgUENJIEkvTyByYW5nZXMgcHJv
cGVydHkgdmFsdWUgZnJvbSBkb20wIGRldmljZSB0cmVlIG5vZGUgc28gdGhhdA0KPj4gZG9tMCBs
aW51eCB3aWxsIG5vdCBhbGxvY2F0ZSBJL08gc3BhY2UgZm9yIFBDSSBkZXZpY2VzIGlmDQo+PiBw
Y2ktcGFzc3Rocm91Z2ggaXMgZW5hYmxlZC4NCj4+IFNpZ25lZC1vZmYtYnk6IFJhaHVsIFNpbmdo
IDxyYWh1bC5zaW5naEBhcm0uY29tPg0KPj4gLS0tDQo+PiAgeGVuL2FyY2gvYXJtL2RvbWFpbl9i
dWlsZC5jICAgfCAyOSArKysrKysrKysrKysrKysNCj4+ICB4ZW4vY29tbW9uL2RldmljZV90cmVl
LmMgICAgICB8IDY5ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrDQo+PiAgeGVu
L2luY2x1ZGUveGVuL2RldmljZV90cmVlLmggfCAxMCArKysrKw0KPj4gIDMgZmlsZXMgY2hhbmdl
ZCwgMTA4IGluc2VydGlvbnMoKykNCj4gDQo+IEZvciBmdXR1cmUgdmVyc2lvbiwgcGxlYXNlIGFk
ZCBhIGNoYW5nZWxvZy4gVGhpcyBoZWxwcyB0byBmaWd1cmUgb3V0IHdoYXQgY2hhbmdlZCBtb3Jl
IGVhc2lseS4NCg0KT2suIEkgd2lsbCBhZGQgdGhlIGNoYW5nZWxvZyBpbiBuZXh0IHZlcnNpb24u
DQoNCj4gDQo+PiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL2RvbWFpbl9idWlsZC5jIGIveGVu
L2FyY2gvYXJtL2RvbWFpbl9idWlsZC5jDQo+PiBpbmRleCA2OTMxYzAyMmEyLi43Y2ZlNjRmZTk3
IDEwMDY0NA0KPj4gLS0tIGEveGVuL2FyY2gvYXJtL2RvbWFpbl9idWlsZC5jDQo+PiArKysgYi94
ZW4vYXJjaC9hcm0vZG9tYWluX2J1aWxkLmMNCj4+IEBAIC02NDgsNiArNjQ4LDMxIEBAIHN0YXRp
YyB2b2lkIF9faW5pdCBhbGxvY2F0ZV9zdGF0aWNfbWVtb3J5KHN0cnVjdCBkb21haW4gKmQsDQo+
PiAgfQ0KPj4gICNlbmRpZg0KPj4gICsvKg0KPj4gKyAqIFBDSSBJTyBiYXIgYXJlIG5vdCBtYXBw
ZWQgdG8gZG9tMCB3aGVuIFBDSSBwYXNzdGhyb3VnaCBpcyBlbmFibGVkLCBhbHNvDQo+PiArICog
dGhlcmUgaXMgbm8gdHJhcCBoYW5kbGVyIHJlZ2lzdGVyZWQgZm9yIElPIGJhciwgdGhlcmVmb3Jl
IHJlbW92ZSB0aGUgSU8NCj4+ICsgKiByYW5nZSBwcm9wZXJ0eSBmcm9tIHRoZSBkZXZpY2UgdHJl
ZSBub2RlIGZvciBkb20wLg0KPj4gKyAqLw0KPj4gK3N0YXRpYyBpbnQgaGFuZGxlX2xpbnV4X3Bj
aV9pb19yYW5nZXMoc3RydWN0IGtlcm5lbF9pbmZvICpraW5mbywNCj4+ICsgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IHN0cnVjdCBkdF9kZXZpY2Vfbm9kZSAqbm9k
ZSkNCj4+ICt7DQo+PiArICAgIGlmICggIWlzX3BjaV9wYXNzdGhyb3VnaF9lbmFibGVkKCkgKQ0K
Pj4gKyAgICAgICAgcmV0dXJuIDA7DQo+PiArDQo+PiArICAgIGlmICggIWR0X2RldmljZV90eXBl
X2lzX2VxdWFsKG5vZGUsICJwY2kiKSApDQo+PiArICAgICAgICByZXR1cm4gMDsNCj4+ICsNCj4+
ICsgICAgLyoNCj4+ICsgICAgICogVGhlIGN1cnJlbnQgaGV1cmlzdGljIGFzc3VtZXMgdGhhdCBh
IGRldmljZSBpcyBhIGhvc3QgYnJpZGdlDQo+PiArICAgICAqIGlmIHRoZSB0eXBlIGlzICJwY2ki
IGFuZCB0aGVuIHBhcmVudCB0eXBlIGlzIG5vdCAicGNpIi4NCj4+ICsgICAgICovDQo+PiArICAg
IGlmICggbm9kZS0+cGFyZW50ICYmIGR0X2RldmljZV90eXBlX2lzX2VxdWFsKG5vZGUtPnBhcmVu
dCwgInBjaSIpICkNCj4+ICsgICAgICAgIHJldHVybiAwOw0KPiANCj4gDQo+IFRoZSBsb2dpYyBh
Ym92ZSBpcyBleGFjdGx5IHRoZSBzYW1lIGFzIGluIGhhbmRsZV9saW51eF9wY2lfZG9tYWluKCku
IENhbiB3ZSBjcmVhdGUgYW4gaGVscGVyIHRoYXQgY291bGQgYmUgdXNlZCBieSBib3RoIGZ1bmN0
aW9ucz8gVGhpcyB3b3VsZCBoZWxwIHRvIGtlZXAgdGhlIGxvZ2ljIHN5bmNocm9uaXplZC4NCg0K
T2suIEkgd2lsbCBjcmVhdGUgdGhlIGhlbHBlciBuYW1lIOKAnGR0X25vZGVfY2hlY2tfcGNpX2hv
c3RicmlkZ2UoLi4p4oCdLg0KDQo+IA0KPj4gKw0KPj4gKyAgICByZXR1cm4gZHRfcGNpX3JlbW92
ZV9pb19yYW5nZXMoa2luZm8tPmZkdCwgbm9kZSk7DQo+PiArfQ0KPj4gKw0KPj4gKw0KPj4gIC8q
DQo+PiAgICogV2hlbiBQQ0kgcGFzc3Rocm91Z2ggaXMgYXZhaWxhYmxlIHdlIHdhbnQgdG8ga2Vl
cCB0aGUNCj4+ICAgKiAibGludXgscGNpLWRvbWFpbiIgaW4gc3luYyBmb3IgZXZlcnkgaG9zdCBi
cmlkZ2UuDQo+PiBAQCAtNzIzLDYgKzc0OCwxMCBAQCBzdGF0aWMgaW50IF9faW5pdCB3cml0ZV9w
cm9wZXJ0aWVzKHN0cnVjdCBkb21haW4gKmQsIHN0cnVjdCBrZXJuZWxfaW5mbyAqa2luZm8sDQo+
PiAgICAgIGlmICggaW9tbXVfbm9kZSAmJiBkZXZpY2VfZ2V0X2NsYXNzKGlvbW11X25vZGUpICE9
IERFVklDRV9JT01NVSApDQo+PiAgICAgICAgICBpb21tdV9ub2RlID0gTlVMTDsNCj4+ICArICAg
IHJlcyA9IGhhbmRsZV9saW51eF9wY2lfaW9fcmFuZ2VzKGtpbmZvLCBub2RlKTsNCj4+ICsgICAg
aWYgKCByZXMgKQ0KPj4gKyAgICAgICAgcmV0dXJuIHJlczsNCj4+ICsNCj4+ICAgICAgZHRfZm9y
X2VhY2hfcHJvcGVydHlfbm9kZSAobm9kZSwgcHJvcCkNCj4+ICAgICAgew0KPj4gICAgICAgICAg
Y29uc3Qgdm9pZCAqcHJvcF9kYXRhID0gcHJvcC0+dmFsdWU7DQo+PiBkaWZmIC0tZ2l0IGEveGVu
L2NvbW1vbi9kZXZpY2VfdHJlZS5jIGIveGVuL2NvbW1vbi9kZXZpY2VfdHJlZS5jDQo+PiBpbmRl
eCA0YWFlMjgxZTg5Li41NWE4ODNlMGY2IDEwMDY0NA0KPj4gLS0tIGEveGVuL2NvbW1vbi9kZXZp
Y2VfdHJlZS5jDQo+PiArKysgYi94ZW4vY29tbW9uL2RldmljZV90cmVlLmMNCj4gDQo+IElmIEkg
YW0gbm90IG1pc3Rha2VuLCB0aGUgZmlsZSBjb21tb24vZGV2aWNlX3RyZWUuYyBpcyBzbyBmYXIg
b25seSBjb250YWluaW5nIGNvZGUgdG8gcGFyc2UgdGhlIGhvc3QgZGV2aWNlLXRyZWUuIEJ1dCBu
b3cuLi4NCj4gDQo+PiBAQCAtMjE5NSw2ICsyMTk1LDc1IEBAIGludCBkdF9nZXRfcGNpX2RvbWFp
bl9ucihzdHJ1Y3QgZHRfZGV2aWNlX25vZGUgKm5vZGUpDQo+PiAgICAgIHJldHVybiAodTE2KWRv
bWFpbjsNCj4+ICB9DQo+PiAgK2ludCBkdF9wY2lfcmVtb3ZlX2lvX3Jhbmdlcyh2b2lkICpmZHQs
IGNvbnN0IHN0cnVjdCBkdF9kZXZpY2Vfbm9kZSAqZGV2KQ0KPiANCj4geW91IGFyZSBpbnRyb2R1
Y2luZyBjb2RlIHRvIHdyaXRlIHRoZSBkb21haW4gZGV2aWNlLXRyZWUuIEkgdW5kZXJzdGFuZCB0
aGlzIGlzIGJlY2F1c2UgZHRfbWF0Y2hfYnVzKCkgaXMgaW50ZXJuYWwuIEhvd2V2ZXIsIEkgd291
bGQgcmF0aGVyIHByZWZlciBpZiB3ZSBleHBvcnQgZHRfbWF0Y2hfYnVzKCkgJiBjbyBhbmQgbW92
ZSB0aGlzIGNvZGUgdG8gdW5kZXIgYXJjaC9hcm0vcGNpLy4gTWF5YmUgd2Ugc2hvdWxkIGludHJv
ZHVjZSBhIGZpbGUgZG9tYWluX2J1aWxkLmMuDQo+IA0KPiBGdXJ0aGVybW9yZSwgdGhlIG5hbWUg
b2YgdGhlIGZ1bmN0aW9uIGRvZXNuJ3QgcmVhbGx5IG1hdGNoIHdoYXQgdGhlIGZ1bmN0aW9uIGRv
ZXMuIEl0IHdpbGwgZ2VuZXJhdGUgInJhbmdlcyIgZm9yIHRoZSBob3N0YnJpZGdlIGFuZCByZW1v
dmUgdGhlIEkvTy4gV2UgbWF5IHdhbnQgdG8gcGVyZm9ybSBvdGhlciBtb2RpZmljYXRpb25zIG9u
IHRoZSByYW5nZS4gU28gSSB3b3VsZCBuYW1lIHRoZSBmdW5jdGlvbiBzb21ldGhpbmcgbGlrZToN
Cj4gDQo+IGRvbWFpbl9idWlsZF9nZW5lcmF0ZV9ob3N0YnJpZGdlX3JhbmdlKCkNCg0KSSB3aWxs
IG1vZGlmeSB0aGUgY29kZSBiYXNlZCBvbiB5b3VyIGNvbW1lbnQgaW4gbmV4dCB2ZXJzaW9uLg0K
DQo+IA0KPj4gKyAgICBjb25zdCBzdHJ1Y3QgZHRfZGV2aWNlX25vZGUgKnBhcmVudCA9IE5VTEw7
DQo+PiArICAgIGNvbnN0IHN0cnVjdCBkdF9idXMgKmJ1cywgKnBidXM7DQo+PiArICAgIHVuc2ln
bmVkIGludCBybGVuOw0KPj4gKyAgICBpbnQgbmEsIG5zLCBwbmEsIHBucywgcm9uZTsNCj4+ICsg
ICAgY29uc3QgX19iZTMyICpyYW5nZXM7DQo+PiArICAgIF9fYmUzMiByZWdzWygoR1VFU1RfUk9P
VF9BRERSRVNTX0NFTExTICogMikgKyBHVUVTVF9ST09UX1NJWkVfQ0VMTFMgKyAxKQ0KPiANCj4g
R1VFU1RfUk9PVF8qX0NFTExTIGFyZSBvbmx5IHZhbGlkIGZvciBkb21VLiBJbiB0aGVvcnksIHRo
ZXJlIGFyZSBubyBndWFyYW50ZWUgdGhpcyB3aWxsIGJlIGJpZ2dlciB0aGF0IHdoYXQgdGhlIGhv
c3QgZGV2aWNlLXRyZWUgc3VwcG9ydHMuDQo+IA0KPiBTbyB5b3Ugd2FudCB0byB1c2UgRFRfTUFY
X0FERFJfQ0VMTFMgaGVyZS4NCj4gDQo+PiArICAgICAgICAgICAgICAgKiAyXTsNCj4gTG9va2lu
ZyBhdCB0aGUgY29kZSBiZWxvdy4gSSBjb3VsZG4ndCBmaW5kIGFueSBjaGVjayBndWFyYW50ZWlu
ZyB0aGUgc3RhdGljIGFycmF5IHdpbGwgYmUgYmlnIGVub3VnaCB0byBzdG9yZSB0aGUgcmFuZ2Vz
IHByb3ZpZGVkIGJ5IHRoZSBob3N0IERULg0KDQpMZXQgbWUgZml4IHRoaXMgaW4gbmV4dCB2ZXJz
aW9uLg0KDQo+IA0KPj4gKyAgICBfX2JlMzIgKmFkZHIgPSAmcmVnc1swXTsNCj4+ICsNCj4+ICsg
ICAgYnVzID0gZHRfbWF0Y2hfYnVzKGRldik7DQo+PiArICAgIGlmICggIWJ1cyApDQo+PiArICAg
ICAgICByZXR1cm4gMDsgLyogZGV2aWNlIGlzIG5vdCBhIGJ1cyAqLw0KPj4gKw0KPj4gKyAgICBw
YXJlbnQgPSBkdF9nZXRfcGFyZW50KGRldik7DQo+PiArICAgIGlmICggIXBhcmVudCApDQo+PiAr
ICAgICAgICByZXR1cm4gLUVJTlZBTDsNCj4+ICsNCj4+ICsgICAgcmFuZ2VzID0gZHRfZ2V0X3By
b3BlcnR5KGRldiwgInJhbmdlcyIsICZybGVuKTsNCj4+ICsgICAgaWYgKCAhcmFuZ2VzICkNCj4+
ICsgICAgew0KPj4gKyAgICAgICAgcHJpbnRrKFhFTkxPR19FUlIgIkRUOiBubyByYW5nZXM7IGNh
bm5vdCBlbnVtZXJhdGUgJXNcbiIsDQo+PiArICAgICAgICAgICAgICAgZGV2LT5mdWxsX25hbWUp
Ow0KPj4gKyAgICAgICAgcmV0dXJuIC1FSU5WQUw7DQo+PiArICAgIH0NCj4+ICsgICAgaWYgKCAh
cmxlbiApIC8qIE5vdGhpbmcgdG8gZG8gKi8NCj4+ICsgICAgICAgIHJldHVybiAwOw0KPj4gKw0K
Pj4gKyAgICBidXMtPmNvdW50X2NlbGxzKGRldiwgJm5hLCAmbnMpOw0KPj4gKyAgICBpZiAoICFE
VF9DSEVDS19DT1VOVFMobmEsIG5zKSApDQo+PiArICAgIHsNCj4+ICsgICAgICAgIHByaW50ayhY
RU5MT0dfRVJSICJkdF9wYXJzZTogQmFkIGNlbGwgY291bnQgZm9yIGRldmljZSAlc1xuIiwNCj4+
ICsgICAgICAgICAgICAgICBkZXYtPmZ1bGxfbmFtZSk7DQo+PiArICAgICAgICByZXR1cm4gLUVJ
TlZBTDsNCj4+ICsgICAgfQ0KPj4gKw0KPj4gKyAgICBwYnVzID0gZHRfbWF0Y2hfYnVzKHBhcmVu
dCk7DQo+PiArICAgIGlmICggIXBidXMgKQ0KPj4gKyAgICB7DQo+PiArICAgICAgICBwcmludGso
WEVOTE9HX0VSUiAiRFQ6ICVzIGlzIG5vdCBhIHZhbGlkIGJ1c1xuIiwgcGFyZW50LT5mdWxsX25h
bWUpOw0KPj4gKyAgICAgICAgcmV0dXJuIC1FSU5WQUw7DQo+PiArICAgIH0NCj4+ICsNCj4+ICsg
ICAgcGJ1cy0+Y291bnRfY2VsbHMoZGV2LCAmcG5hLCAmcG5zKTsNCj4+ICsgICAgaWYgKCAhRFRf
Q0hFQ0tfQ09VTlRTKHBuYSwgcG5zKSApDQo+PiArICAgIHsNCj4+ICsgICAgICAgIHByaW50ayhY
RU5MT0dfRVJSICJkdF9wYXJzZTogQmFkIGNlbGwgY291bnQgZm9yIHBhcmVudCAlc1xuIiwNCj4+
ICsgICAgICAgICAgICAgICBkZXYtPmZ1bGxfbmFtZSk7DQo+PiArICAgICAgICByZXR1cm4gLUVJ
TlZBTDsNCj4+ICsgICAgfQ0KPj4gKw0KPj4gKyAgICAvKiBOb3cgd2FsayB0aHJvdWdoIHRoZSBy
YW5nZXMgKi8NCj4+ICsgICAgcmxlbiAvPSA0Ow0KPj4gKyAgICByb25lID0gbmEgKyBwbmEgKyBu
czsNCj4+ICsgICAgZm9yICggOyBybGVuID49IHJvbmU7IHJsZW4gLT0gcm9uZSwgcmFuZ2VzICs9
IHJvbmUgKQ0KPj4gKyAgICB7DQo+IA0KPiBNb3N0IG9mIHRoZSBjb2RlIGluIHRoaXMgZnVuY3Rp
b24gaXMgdGhlIHNhbWUgYXMgZHRfZm9yX2VhY2hfcmFuZ2UoKS4gQ2FuIHdlIHJlZmFjdG9yIGl0
IHRvIGF2b2lkIGNvZGUgZHVwbGljYXRpb24/DQoNCk9rIExldCBtZSB0cnkgdG8gcmVmYWN0b3Ig
dGhlIGNvZGUuDQoNClJlZ2FyZHMsDQpSYWh1bA0KPiANCj4+ICsgICAgICAgIHVuc2lnbmVkIGlu
dCBmbGFncyA9IGJ1cy0+Z2V0X2ZsYWdzKHJhbmdlcyk7DQo+PiArICAgICAgICBpZiAoIGZsYWdz
ICYgSU9SRVNPVVJDRV9JTyApDQo+PiArICAgICAgICAgICAgY29udGludWU7DQo+PiArDQo+PiAr
ICAgICAgICBtZW1jcHkoYWRkciwgcmFuZ2VzLCA0ICogcm9uZSk7DQo+PiArDQo+PiArICAgICAg
ICBhZGRyICs9IHJvbmU7DQo+PiArICAgIH0NCj4+ICsNCj4+ICsgICAgcmV0dXJuIGZkdF9wcm9w
ZXJ0eShmZHQsICJyYW5nZXMiLCByZWdzLCBzaXplb2YocmVncykpOw0KPj4gK30NCj4+ICsNCj4+
ICAvKg0KPj4gICAqIExvY2FsIHZhcmlhYmxlczoNCj4+ICAgKiBtb2RlOiBDDQo+PiBkaWZmIC0t
Z2l0IGEveGVuL2luY2x1ZGUveGVuL2RldmljZV90cmVlLmggYi94ZW4vaW5jbHVkZS94ZW4vZGV2
aWNlX3RyZWUuaA0KPj4gaW5kZXggZmQ2Y2QwMGI0My4uNTgwMjMxZjg3MiAxMDA2NDQNCj4+IC0t
LSBhL3hlbi9pbmNsdWRlL3hlbi9kZXZpY2VfdHJlZS5oDQo+PiArKysgYi94ZW4vaW5jbHVkZS94
ZW4vZGV2aWNlX3RyZWUuaA0KPj4gQEAgLTg0OSw2ICs4NDksMTYgQEAgaW50IGR0X2NvdW50X3Bo
YW5kbGVfd2l0aF9hcmdzKGNvbnN0IHN0cnVjdCBkdF9kZXZpY2Vfbm9kZSAqbnAsDQo+PiAgICov
DQo+PiAgaW50IGR0X2dldF9wY2lfZG9tYWluX25yKHN0cnVjdCBkdF9kZXZpY2Vfbm9kZSAqbm9k
ZSk7DQo+PiAgKy8qKg0KPj4gKyAqIGR0X3BjaV9yZW1vdmVfaW9fcmFuZ2UgLSBSZW1vdmUgdGhl
IFBDSSBJL08gcmFuZ2UgcHJvcGVydHkgdmFsdWUuDQo+PiArICogQGZkdDogUG9pbnRlciB0byB0
aGUgZmlsZSBkZXNjcmlwdG9yIHRyZWUuDQo+PiArICogQG5vZGU6IERldmljZSB0cmVlIG5vZGUu
DQo+PiArICoNCj4+ICsgKiBUaGlzIGZ1bmN0aW9uIHdpbGwgcmVtb3ZlIHRoZSBQQ0kgSU8gcmFu
Z2UgcHJvcGVydHkgZnJvbSB0aGUgUENJIGRldmljZSB0cmVlDQo+PiArICogbm9kZS4NCj4+ICsg
Ki8NCj4+ICtpbnQgZHRfcGNpX3JlbW92ZV9pb19yYW5nZXModm9pZCAqZmR0LCBjb25zdCBzdHJ1
Y3QgZHRfZGV2aWNlX25vZGUgKm5vZGUpOw0KPj4gKw0KPj4gIHN0cnVjdCBkdF9kZXZpY2Vfbm9k
ZSAqZHRfZmluZF9ub2RlX2J5X3BoYW5kbGUoZHRfcGhhbmRsZSBoYW5kbGUpOw0KPj4gICAgI2lm
ZGVmIENPTkZJR19ERVZJQ0VfVFJFRV9ERUJVRw0KPiANCj4gQ2hlZXJzLA0KPiANCj4gLS0gDQo+
IEp1bGllbiBHcmFsbA0KDQo=


From xen-devel-bounces@lists.xenproject.org Mon Feb 28 10:59:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 10:59:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280406.478344 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOdkc-0007OI-Dj; Mon, 28 Feb 2022 10:59:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280406.478344; Mon, 28 Feb 2022 10:59:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOdkc-0007OB-AU; Mon, 28 Feb 2022 10:59:34 +0000
Received: by outflank-mailman (input) for mailman id 280406;
 Mon, 28 Feb 2022 10:59:33 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=o1tx=TL=citrix.com=prvs=051234957=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nOdka-0007MA-Is
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 10:59:32 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 80505566-9885-11ec-8eba-a37418f5ba1a;
 Mon, 28 Feb 2022 11:59:31 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 80505566-9885-11ec-8eba-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1646045971;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=yd6GiepE+qP+cJTKWNu0ORjbPnABBCUbM3ZUkWnulqU=;
  b=GBRP2G/82TIDJqiZw0xaqq0vOf3f1EI8HDfnSxYHMCR+XhKgTYzloKN7
   v3GDMlNtglIBsjsdCb6VMrsTUP6z0eGwttfF3sDkIZcXFc4w6l+vpM41o
   dfq8VGHMnbtMSh7rt1xLTsP7RJyidDt8cBAic8ZVWsrNcIoFRFUN4fut2
   4=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 65011458
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:UJKrsqswQR9TyPSokXpS9VsPMOfnVONeMUV32f8akzHdYApBsoF/q
 tZmKTjUb6yNMTGkKtgiOoW+90NVv5/Uz4A2Sldo+y00QixE+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQyw4bVvqYy2YLjW1nX5
 ouoyyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb
 /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo
 Oihu6BcRi85O4DhuekjViAHGj1vB/de6OX8IkaG5Jn7I03uKxMAwt1rBUAye4YZ5vx2ESdF8
 vlwxDIlN07ZwbjsmfTiF7cq1p9LwMrDZevzvll6yj7UF7A+SI3rSKTW/95Imjw3g6iiGN6AO
 pJAMGYyPHwsZTUMGnA8EZk3n9z4h2L4UBcJ9guam/cOtj27IAtZj+G2bYu9lsaxbc9YhFqCr
 2TKuWHwGAgHNce3wCCAtHmrg4fnoyT/X44DEayiwdRjilaT2287BQUfUB2wpvzRokyjXZRZI
 k8d+CsrpIAz8lCmSp/2WBjQiG6JuFsQVsRdF8U+6RqR0ezE7gCBHG8GQzVdLts8u6ceRjE01
 1nPg9LgAxRutqGYTTSW8bL8hSy2ETgYKykFfyBsZQkP7sTnoYozpgnSVdslG6mw5vX3Fiv32
 CuitzUlivMYistj/76g4VnNjjaop57IZg04/APaWiSi9AwRTIy4Y42l73DL4PAGK5yWJmRtp
 1BdxZLYtrpXS8jQymrdG43hAY1F+d6VNRDxoFNRGqB+/ii8wSS7bdpr4w9HcRIB3tk/RRflZ
 0rauAV07ZBVPWe3YaIfX79dG/jG3oC7S427C6m8gs5mJ8EoKVTZpH0GiVu4gji1+HXAh53TL
 ntynSyEKX8BQZpqwzOtLwv2+e96n3turY8/qH2S8vhG7VZ8TCPPIVvmGAHXBgzc0E9iiF+Im
 zq4H5HXoyizqMWkPkHqHXc7dDjm10QTC5HssNBwfeWeOAdgE2xJI6aPne5wK9M8xvgLzregE
 pSBtqlwkgeXaZrvc1jiV5yeQOm3AcYXQYwTZ0TAwmpEK1B8ON3yvc/zhrM8fKU99fwL8BKHZ
 6JtRil0OdwWEm6v021ENfHV9dU+HDz21VPmF3f0O1AXIs8/LzElD/e5J2MDAgFVVXHp3Sb/y
 pX9vj7mrW0rHFwzXJ6LM6v0lztcfxE1wYpPYqcBGfEKEG3E+4l2MS3hyPgxJsAHMxLYwTWGk
 Q2RBH8lSSPl/efZLPGhaXi4krqU
IronPort-HdrOrdr: A9a23:WV0OI64WJI1GVSSriAPXwSuBI+orL9Y04lQ7vn2ZFiY7TiXIra
 yTdaoguCMc6AxxZJkh8erwX5VoZUmsj6KdgLNhRotKOTOJhILGFvAB0WKP+UyEJ8S6zJ8h6U
 4CSdkBNDSTNykCsS+S2mDReLxBsbq6GeKT9J/jJh9WPH5XgspbnmFE42igYylLrF4sP+tEKH
 PQ3LsOm9LmEk5nHPiTNz0gZazuttfLnJXpbVovAAMm0hCHiXeN5KThGxaV8x8CW3cXqI1Su1
 Ttokjc3OGOovu7whjT2yv66IlXosLozp9mCNaXgsYYBz3wgkKDZZhnWZeFoDcpydvfo2oCoZ
 3pmVMNLs5z43TeciWcpgbs4RDp1HIU53rr2Taj8AzeiP28YAh/J9tKhIpffBecwVEnpstA3K
 VC2H/cn4ZLDDvb9R6NqOTgZlVPrA6ZsHAimekcgzh0So0FcoJcqoQZ4Qd8DIoAJiTn84oqed
 MeQP003MwmMG9yUkqp/lWGmLeXLzcO91a9MwU/U/WuonZrdCsT9Tpb+CQd9k1wgK7VBaM0ot
 gsCZ4Y5I2mfvVmHJ6VO91xMvdfKla9Ny4kY1jiaGgOKsk8SgfwQtjMkfEI2N0=
X-IronPort-AV: E=Sophos;i="5.90,142,1643691600"; 
   d="scan'208";a="65011458"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=MQGFBXKxKzK7y3Go9TeUijjT7koQj9ozYkaMSkullJes+2iX+4WOKx11jTWQ2mjZ/BQttaSBfLaEwkHOm0aEPW2oSEOlQTVpfBkt0uWZ0gYUhAXi312rqI7AoXOBXWxPV4y/0Nm8Naa2UYSmwNN6A82FVaF7kHtlkXZr5GKZwb85Cw4xk/I7r+CVYRpxqjjDMPcuaL2WoROSl7eQwkrSDOhXBLW6Sb3nhXsnXbX11WexSWoHbmYkPJ2xrh7LU8n4LWBcSA1C/a2a7hbUac6i40i2eDV8VL9BypqoHMayKZD+eGH60rAXwrM8iUhE6UWidSA07A6p3jrev9TDXPrzKw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=YrpwPK6LCUUns91u6F/DQGdZvgM4sr1DwnnZyCRg7tY=;
 b=ClzJHNfcNPP72knnNkaH2XBV++lVqbmLr/4GFW4XdfzPiFMIIBE3KvcnsBraw2L/R7tC8sIFNFGvvnKa1OD0A18V6rRX/8JCg7PGOleZW9UGwkJarif4TX5EDdZFQ5B/CDj/XWVzV66ZWL0v1M4Vl8p1v+wNIxUyXoSxL8erGsMy5UhRi5lRCXcIdh1WOSbuoa3h9Q4uyPHJr4fbibwutRn0E+BCm27Rpjrzjx1dvCHlIV6iF/wd0prIXqQ4ydC5iAvU8gxIOr50Z6rU/H4pgLrVCDvGKutUtyAJA+ZJbsXlxYFnIW2JaCidp1s9kHMpdedgBCyCzYQG3wgsbvzAkA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=YrpwPK6LCUUns91u6F/DQGdZvgM4sr1DwnnZyCRg7tY=;
 b=ac9KF68ItQzaO0f6XWpolshlHku1i6Y5KxPU51Ev53JbBjGOA14byhC3TD9PmnBE8L0fv3hbWaat1I5Nrf9aWa4/RXKNr64FccmNRvNoC0UquNqvO7CMwXUlp3GPZw0iSUWsyhwd+m3IiJ85uzlKJfv0wrtshljIYZ0nFQ+y+Uw=
Date: Mon, 28 Feb 2022 11:59:15 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Jane Malalane <jane.malalane@citrix.com>, Wei Liu <wl@xen.org>, Anthony
 PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, Andrew
 Cooper <andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>,
	Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Bertrand Marquis
	<bertrand.marquis@arm.com>, Jun Nakajima <jun.nakajima@intel.com>, Kevin Tian
	<kevin.tian@intel.com>, Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v3 1/2] xen+tools: Report Interrupt Controller
 Virtualization capabilities on x86
Message-ID: <YhyrAyxhNtNWi7NY@Air-de-Roger>
References: <20220218172943.12182-1-jane.malalane@citrix.com>
 <20220218172943.12182-2-jane.malalane@citrix.com>
 <0a31970c-c0f8-c995-ce04-67523a4a830a@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <0a31970c-c0f8-c995-ce04-67523a4a830a@suse.com>
X-ClientProxiedBy: MR2P264CA0161.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:501:1::24) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e8b1c23d-6d3a-43fb-44e5-08d9faa95f63
X-MS-TrafficTypeDiagnostic: BL1PR03MB6168:EE_
X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
X-Microsoft-Antispam-PRVS: <BL1PR03MB6168353A63BC25272C8E64658F019@BL1PR03MB6168.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: pkuMIWJBRj0yxbm8HfIB0jUDhUTTzsbqjEhBiwvvqv76lVlnbT7xCiHtxBAc33/z5+YhySohZCK8l3jktQ22w56Hv6UiKYxsfpUhwqi6BNvcTWneXyM3TgnEpdrhbVzT7ERnoGdgCgRyk7j3XfeWtLOxRXHOzlwNWIycF+0GEn/3R1ZO5SDfYlmh4byq3Sh6fXXF/zbcC6+VsAc8BbGK1NQt10ycDkWTjUEnEMBEtl6Tgm0hXjCgW5MYkneVa6cg/sUHzydgF9fpQouUHhjJ2Q7aqwbKS6+PcCEw5t4Vv4hgxMG9WI1jNDGIaX15MJ5e5tgFLl4NQj9pA2ruswhB0C6ZptvdkHhm4ZiiN1WeCpcCT5Ln6L7COm5Qsv73HJQjTi1UpwatCBuP1VsbPwY1QQZp8ExniMKIMOBvsl1T+7XbIQmIqOcD6rXcKRt1LYfmBAZSvd/hZPLapGn1XcpzOxNFIAKLg52da65BJ5bdyxGAHcSJMES7aUOpgivuRyWrUzhIHeUHEH858p1/6C73JcOHzSqhvtsL1J55aPXTu1QmqaYSqMmK76t4B/a/FXPhH7b8UVkL/c1Y0d/Lk/fb38xa1wrfXkPV5P8l9s/e+9+8c9+dekIp1g9W1DzoWzngHtbRNbPg5GFWcQeKj7s3Xg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(4326008)(66556008)(6916009)(83380400001)(66476007)(316002)(33716001)(54906003)(66946007)(8676002)(85182001)(38100700002)(6486002)(5660300002)(7416002)(8936002)(186003)(86362001)(26005)(82960400001)(53546011)(508600001)(9686003)(6666004)(6506007)(2906002)(6512007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YU9jQjRicFpVVmx5V0xiWHB5UEZ6dnRQMnVHUUgvc3dnUTBmeW92d1dBck9L?=
 =?utf-8?B?cHdZVVkzVCt5cFlmUGZqb2dDVWxNZlVRMVdMNFBwNmpzQ3h2WXBodm1OWGdJ?=
 =?utf-8?B?bnNyOXpld3ZGSndqRUw0K2wzYzR3ZDFQelNVZFBnbmYrNzBOMEd5RHRETHZY?=
 =?utf-8?B?WDJJcG5UOU9xOEVPRjh5bzJZSGM0VHVBOGl4VVhpV21jcU82RGJMSk44TVBt?=
 =?utf-8?B?QVpWYkpWNVl0SzZzNWcrM1NPbTNJZm9yMXZoT2M2d3BMQStNOU1hd1BBalZB?=
 =?utf-8?B?ZkVobXBuRGQrZzZheFl6Uzd6eG8rbjljeVFzVzJZZk8zRXZUQnN3RGk3OXlH?=
 =?utf-8?B?TnBzQW1SbkY2bXliQTZZc1BRTHpTaGdaZ3Z0elQ5RzRPWlJ5eDBIeGx3V1lQ?=
 =?utf-8?B?SjlzZ2V6NDd5U1lWODhkelZiclhqTnVXMFU4VFo3b3hobVpIdForWVJ1VTVG?=
 =?utf-8?B?MDVMT3N3NTYvQzRaTEVTcThYS3JjeHh5em9Yd0JYbjNtMVNsU0kxL2pZeFRN?=
 =?utf-8?B?anplRjdFRjNnT1REZHN1a21MSlNVZUhHaUVENVVWVXl1dzBDNEdiMWdqVElm?=
 =?utf-8?B?cTNqRWtGQlhnOGhqZ0xkQzNXUzdnUWwrc2hhY0xweDljSFdkZHlOcnROY3NE?=
 =?utf-8?B?ZXJNRG9KRnZYTmxUdEhqUk5UN3oxKzRWbTNtbHV1RVZFZVFqMVU1RVc1M3pm?=
 =?utf-8?B?aWI4UFJGQ2cweS85WWg3d0Qvd2k5WE5zWFlPRksvYVRLY3BHeFRUbFRRcUlS?=
 =?utf-8?B?ejdyYUFTUEUxYVBnY0M3RTBFQVYxejU4dW5Idm1jVUgxUzRBdFJ0Z1Bkb2hN?=
 =?utf-8?B?NktUZU9wTCtuQ0dBcWsveExHVjltTzVDSWhYZzR6TzAvb3VPV1ErYmlTWGNn?=
 =?utf-8?B?SDh3VlR5ZGRPRG9KbTFEend0Y1dibzM5Y1MyTzJOVWRmNEpETTEwbkFmUEFU?=
 =?utf-8?B?bG1xaURBZG9WRUpOVU1CbTRwL1dERVpZL2Jwd25zTE9FVnhnZlJhbDZMMWsw?=
 =?utf-8?B?U2x5VVBqTVZpYXNaM3FxQVl1RWl5NmNkcVMxM2hMU2xCUlRMSHhLTWdlRWtV?=
 =?utf-8?B?S2k1VUZOdHpPaUpwTE1GQjJRUDArU2IvZSt4am4wZFV4UHI3a1J3RTk5K00v?=
 =?utf-8?B?NXhMSFhQUkR0NFlyQXB1OUN3U3ZkMkNoNXZZY1cyUERraUJFZnVoa0pYbWND?=
 =?utf-8?B?Rm5NcUE3dFVtRlBIc1hBUHg1czJwbnBrWjZsMTZiZWp1eVpidDBWR0w4L1ZS?=
 =?utf-8?B?L1hIb29rb1U1LzZtR2FqcTRxbzE5WDJkK1UxNjFGTU5xUStWNlNReWtmNjE4?=
 =?utf-8?B?S2NGOWx3c3dXYkFobndIQlNScWIvMG5mQi91cXJvaFcxcEM5bHdpaU9obm81?=
 =?utf-8?B?OHNzdGRuK0UwR1lKU3Awa3hJSzhXZjZXQW1JZXdvRjR0Yko4VGt3SzZNRXdo?=
 =?utf-8?B?YjlNWlFMSlJqOUVSL3lML281emdYM2VveE9vdEEvejJmTXhMeS9sVHVIN1U1?=
 =?utf-8?B?VGdrYTYvQ2l1clY3MWd2bWN0TWVUNVVIb1pDSmttODJlWGxwU0haT0RSZitz?=
 =?utf-8?B?TzIrWXdlK1BjdmhQNTA5MUd1a0lVbmdtT1pENW96MXVicGs5WldzSTNDK1NR?=
 =?utf-8?B?UXBKTEhKUnNmVlNybHp5YVpUcytTMmJzTnBPQytLc0dvUjJpYW9BLytrR05O?=
 =?utf-8?B?WmZnVCtxZmRsTkZmRk5XQW9QSTV5dm9BNDRtQTRyTjJuY0haWXBhSU1jNUNW?=
 =?utf-8?B?M2tZb2tYZ21CeStaUzBuMmg2MkhYc3k2VlY5MzhLMXROcGZtV09QMVpWaHpN?=
 =?utf-8?B?cDZpWHQycUcwdExCMDNtd2JzT09jR3FwRzV3UnBCUUsveVdSc05FOWI5Tzdh?=
 =?utf-8?B?TW5YS1hQMVZmWVgyQXlOdXc5ekpuZk5hQVg5TFJ4MlRnOXlSTU9FanVmSkpz?=
 =?utf-8?B?bFFRby9Kd1NpVjd5cmMwOW9mL2t0WkhacFBJc2p3ZFVGS3lrMHdBL3B4K2VR?=
 =?utf-8?B?MGVOVUU0NEpyV0owd0tVOFJwMnVmUnQ4cGJYM2FxT3diTnppbkwvSVBEUzh5?=
 =?utf-8?B?bWRSSUdxb3RhNm5HbU1BTDljcng4ZTl6Wkl1TVNNWHkxeENQNFowQVdTTDRo?=
 =?utf-8?B?UTVod2JCNm9jRkc4ZnpxNnlxRDh6ZmM4M0EzV0JvTStLRDg5L1E4TXNuZXpQ?=
 =?utf-8?Q?ZAYyTjWaoe+ILBNmZsjXcxQ=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e8b1c23d-6d3a-43fb-44e5-08d9faa95f63
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2022 10:59:20.7498
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fGfPQu8vefQZtfY9jgksn6+K+TKg7AC1bYz5xXnECwhLqrHSH5R6xLBE0pQXIjNXzcK6PV0MnkevHwNPmrv60A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR03MB6168
X-OriginatorOrg: citrix.com

On Thu, Feb 24, 2022 at 03:08:41PM +0100, Jan Beulich wrote:
> On 18.02.2022 18:29, Jane Malalane wrote:
> > Add XEN_SYSCTL_PHYSCAP_ARCH_ASSISTED_xapic and
> > XEN_SYSCTL_PHYSCAP_ARCH_ASSISTED_x2apic to report accelerated xapic
> > and x2apic, on x86 hardware.
> > No such features are currently implemented on AMD hardware.
> > 
> > For that purpose, also add an arch-specific "capabilities" parameter
> > to struct xen_sysctl_physinfo.
> > 
> > Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
> > Signed-off-by: Jane Malalane <jane.malalane@citrix.com>
> > ---
> > v3:
> >  * Define XEN_SYSCTL_PHYSCAP_ARCH_MAX for ABI checking and actually
> >    set arch_capbilities, via a call to c_bitmap_to_ocaml_list()
> >  * Have assisted_x2apic_available only depend on
> >    cpu_has_vmx_virtualize_x2apic_mode
> 
> I understand this was the result from previous discussion, but this
> needs justifying in the description. Not the least because it differs
> from when XEN_HVM_CPUID_X2APIC_VIRT would be set as well as from what
> vmx_vlapic_msr_changed() does. The difference between those two is
> probably intended (judging from a comment there), but the further
> difference to what you add isn't obvious.
> 
> Which raises another thought: If that hypervisor leaf was part of the
> HVM feature set, the tool stack could be able to obtain the wanted
> information without altering sysctl (assuming the conditions to set
> the respective bits were the same). And I would view it as generally
> reasonable for there to be a way for tool stacks to know what
> hypervisor leaves guests are going to get to see (at the maximum and
> by default).

I'm not sure using CPUID would be appropriate for this. Those fields
are supposed to be used by a guest to decide whether it should prefer
the x{2}APIC over PV alternatives for certain operations (ie: IPIs for
example), but the level of control we can provide with the sysctl is
more fine grained.

The current proposal is limited to the exposure and control of the
usage of APIC virtualization, but we could also expose availability
and per-domain enablement of APIC register virtualization and posted
interrupts.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Feb 28 11:10:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 11:10:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280415.478355 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOdvG-0001MZ-EQ; Mon, 28 Feb 2022 11:10:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280415.478355; Mon, 28 Feb 2022 11:10:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOdvG-0001MS-A3; Mon, 28 Feb 2022 11:10:34 +0000
Received: by outflank-mailman (input) for mailman id 280415;
 Mon, 28 Feb 2022 11:10:32 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nOdvE-0001MI-7R; Mon, 28 Feb 2022 11:10:32 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nOdvE-0003WZ-4F; Mon, 28 Feb 2022 11:10:32 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nOdvD-0003A8-JV; Mon, 28 Feb 2022 11:10:31 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nOdvD-0001uO-J6; Mon, 28 Feb 2022 11:10:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=9FamLyGuYW+jv8kIQSOCEGS6VvkX7MTu/9kPgakgbNM=; b=nE+UB0TUtkUtfPmJFuk0zeMao6
	eXVMEEFTdcRM0DffRVizO5/bhdYUBm5Hzl0SbA8jfIbwGv3YrieYxCpsdYXRN2vzrJCoG4l4G97JU
	wz5eYVH1pjRmeZc9CfnybGxAC694gE1LOrsK5WWAk14c4CGDSaZiATvSZW4nCVsJCGW8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168251-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 168251: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=854ea58e4ee9dd5521bfb85df97f75381f617cb3
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 28 Feb 2022 11:10:31 +0000

flight 168251 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168251/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              854ea58e4ee9dd5521bfb85df97f75381f617cb3
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  598 days
Failing since        151818  2020-07-11 04:18:52 Z  597 days  579 attempts
Testing same since   168237  2022-02-26 04:19:42 Z    2 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brad Laue <brad@brad-x.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Christophe Fergeau <cfergeau@redhat.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Divya Garg <divya.garg@nutanix.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Emilio Herrera <ehespinosa57@gmail.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Ivan Teterevkov <ivan.teterevkov@nutanix.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jing Qi <jinqi@redhat.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Kim InSoo <simmon@nplob.com>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Lubomir Rintel <lkundrak@v3.sk>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nicolas Lécureuil <neoclust@mageia.org>
  Nicolas Lécureuil <nicolas.lecureuil@siveo.net>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Rohit Kumar <rohit.kumar3@nutanix.com>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  shenjiatong <yshxxsjt715@gmail.com>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tu Qiang <tu.qiang35@zte.com.cn>
  Tuguoyi <tu.guoyi@h3c.com>
  tuqiang <tu.qiang35@zte.com.cn>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Vineeth Pillai <viremana@linux.microsoft.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yasuhiko Kamata <belphegor@belbel.or.jp>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 99017 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Feb 28 11:20:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 11:20:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280428.478366 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOe4l-0002wa-Ir; Mon, 28 Feb 2022 11:20:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280428.478366; Mon, 28 Feb 2022 11:20:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOe4l-0002wT-E2; Mon, 28 Feb 2022 11:20:23 +0000
Received: by outflank-mailman (input) for mailman id 280428;
 Mon, 28 Feb 2022 11:20:22 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=o1tx=TL=citrix.com=prvs=051234957=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nOe4k-0002wN-BA
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 11:20:22 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 691450c0-9888-11ec-8eba-a37418f5ba1a;
 Mon, 28 Feb 2022 12:20:20 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 691450c0-9888-11ec-8eba-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1646047220;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=y4ytSXfK6Nh9Alsu1C63kMxrUJ61iCes5+3YzPOZCEI=;
  b=h9zITVM3q+7AcDDVh8wTIwMNJKmAZMiYXSJ3H6xCb2+5CtSFCQGpe32S
   baSDMUndiFKOLNznFLqkUAvKWJ2p7nKP6KVLh7vkgvyG/5D5MH/nOaZX9
   eNiYTaQUGzXpSmeRk7M8CPJwDBmZ7RfEfqLFK/T1TTYnAkvlEP4/Jl9Jt
   Q=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 65118256
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:mGP4zaNsrZCqLtfvrR1Zl8FynXyQoLVcMsEvi/4bfWQNrUp20TJWy
 TMeDWDVa6yMY2H0f9t2bo2zpEgBvJ7VyYVkQQto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFcMpBsJ00o5wbZj2NEw27BVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zx
 PcUh5DpRgYVLoaWu79MSzoBEioiIvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALNs7kMZlZonh95TrYEewnUdbIRKCiCdpwgmpp35AUQKi2i
 8wxQGQ+cQTHXyV2eVo8FLM8mf2QtkHcSmgNwL6SjfVuuDWCpOBr65DhOcTYUsaHTsJUmgCfv
 G2u13/iHhgQOdibyDyE2nGhnOnCmWX8Qo16PK218LtmjUOewkQXCQYKTh2rrP+hkEm8VtlDb
 UsO9UIGk68280C6S8jnaDexqnWEox00VsJZFqsx7wTl4rXQyxaUAC4DVDEpQN4sudIyRDcq/
 kSUhN6vDjtq2JWXVHac+7G8vT60fy8PIgcqZyAeShAey8L+u4x1hRXKJuuPC4bs0IezQ2uph
 WnX8m5u3N3/kPLnyY233wn1j2ujp6TZZVQWvVTPfTuk5V9mMdvNi5OT1XDX6vNJLYC8R1aHv
 WQZl8X20N3iHa1hhwTWHrxTQejBC+KtdWSF3AUxR8VJGyGFpib7Fb289g2SM6uA3iwsXTbyK
 HHetgpKjHO4FCv7NPQnC25d5ilD8EQBKTgHfq2OBjatSsIoHONiwM2ITRTNt4wKuBJx+ZzTw
 b/BLa6R4Y8yUMyLNgaeSeYHyqMMzSsj327VTp2T5035jefPNCHMEOtbaAvmggUFAEWs+li9H
 zF3bZbi9vmieLemPnm/HXA7dzjm0kTX9bip8pcKJ4Zv0yJtGX07Cu+5/F/SU9cNokihrc+Rp
 ivVchYBkDLX3CSbQS3XOiELQO6+Bv5X8CNkVRHAyH71ghDPl670t/xBH3b2FJF6nNFeIQlcF
 KFUK53dWa0UElwqOV01NPHAkWCrTzzy7SqmNCu5ejkvOZlmQg3C4Nj/eQXzsiIJC0KKWQEW/
 9VMCiuzrUI/ejlf
IronPort-HdrOrdr: A9a23:VioNpasZ4K7HhzVrhLldJh7h7skCmoMji2hC6mlwRA09TyXGra
 +TdaUguSMc1gx9ZJhBo7G90KnpewK6yXdQ2/hqAV7CZnichILMFu9fBOTZsl/d8kHFh4tgPO
 JbAtVD4b7LfCZHZKTBkXCF+r8bqbHtmsDY5ts2jU0dNT2CA5sQkDuRYTzrdHGeKjM2YabQQ/
 Gnl7Z6TnebCD0qR/X+IkNAc/nIptXNmp6jSRkaByQ/4A3LqT+z8rb1HzWRwx9bClp0sPwf2F
 mAtza8yrSosvm9xBOZ/2jP765OkN+k7tdYHsSDhuUcNz2poAe1Y4ZKXaGEoVkO0amSwWdvtO
 OJjwYrPsx15X+UVmapoSH10w2l6zoq42+K8y7tvVLT5ejCAB4qActIgoxUNjHD7VA7gd162K
 VXm0qEqpt+F3r77WjAzumNcysvulu/oHIkn+JWpWdYS5EiZLhYqpFa1F9JEa0HADnx5OkcYa
 RT5fnnlbhrmG6hHjHkVjEF+q3tYp1zJGbNfqE6gL3b79AM90oJjHfxx6Qk7wI9HdwGOtt5Dt
 //Q9RVfYF1P74rhJ1GdZQ8qOuMexvwqEH3QRSvyWqOLtB0B5uKke+z3IkI
X-IronPort-AV: E=Sophos;i="5.90,142,1643691600"; 
   d="scan'208";a="65118256"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=I1oRJgtXGrR7oJZOua6T3j4DSDzUUhcD+v2Aq8pdK0Bjw7K9JIQPoEPxrDS3hREDTH0F7oRtr6C8xAJPSbp+T7wL82kjG1aVZ0NZGPjcyvmT43tIahCajzXQ8TBl57eDgP9QB/gFUDQSqzG8Nk1AHdCDr71FNlPHBArhN5L+7kaPzd4JUqUjr5wcFetwdY0kiaRHKL3okZCiHosmS/Ge3kliNgsYTjU7xb5xK5nN/tmgMhLqjiC2bkkOQpjWDcO+1fZ44pxSvEhfOXbatSm5tNw8JpkYvIb9zudzGa6oJVWtRvkL4LMfkP96jRipKnNvA1cZDYWfajfYsyJmkhSU6w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ed8stpYibYnHXQX7i9FoEI4P3r8EueLvw52VaHs/nr0=;
 b=UHh+hw/9c5K1/TUC7GjDIysJ19QkQjvp8/rLvdiVHlT76HS4tKIhDdX8V+NCo9rUVt9dsj742j94ZMhzu9uTOG8iJwPH0kxQpJ5IyjReFSPie59Q1ML40ovV6Og1i96fV4IXeZEa9FnrNlOpcjZ+zPsJXdq47ZiwooDDi01PoMUbdSmOBozO4F2JevqJ+q7ympL/R46tFTRGMiYGxKbg8PRx7VzxVFYoOooiMVP0jtg4DkciCL2NJGG9b410D5PWgwFSmXyCkkFHkxexcgmTTK6LiYsbaafk3pkj2/AgOVe2Yvm/GOlSOUKQk3fDvpKzsniq6oAAumu/wEl4Lzn87Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ed8stpYibYnHXQX7i9FoEI4P3r8EueLvw52VaHs/nr0=;
 b=XNXnDu8VHtESOm2Hraso+74s1Im0smWImNEvLnHWUAaQNVeNYVOfbLEgTZfiLVrbR58qpDyW/v+bUyO+VlrcQrisDnpe6ZdFlCCd8n669EZG1SxSg+kAL/suEfjTpVCpwibkAo0XDxCGGgepNSWly7Ol04SAlhHbfiLAebevciA=
Date: Mon, 28 Feb 2022 12:20:09 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Jane Malalane <jane.malalane@citrix.com>, Wei Liu <wl@xen.org>, Anthony
 PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, Andrew
 Cooper <andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>,
	Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
	Christian Lindig <christian.lindig@citrix.com>, David Scott
	<dave@recoil.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Xen-devel
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v3 2/2] x86/xen: Allow per-domain usage of hardware
 virtualized APIC
Message-ID: <Yhyv6Ui4ap1wOeNd@Air-de-Roger>
References: <20220218172943.12182-1-jane.malalane@citrix.com>
 <20220218172943.12182-3-jane.malalane@citrix.com>
 <b83773ec-c97a-7aea-e61a-c2e34b270816@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <b83773ec-c97a-7aea-e61a-c2e34b270816@suse.com>
X-ClientProxiedBy: MR2P264CA0089.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:500:32::29) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 646f2ca6-f09d-4ad6-ef6a-08d9faac4a17
X-MS-TrafficTypeDiagnostic: BN6PR03MB3395:EE_
X-Microsoft-Antispam-PRVS: <BN6PR03MB33953938F000D7E63494207B8F019@BN6PR03MB3395.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: GKXi2MsG1tq8tB/EUDafJHNBJ8HnmTEPEUxZiWv4jRe7Jeg6I/81ItTmVNfq7pTzp4l2PJOfYDzMUYeJKB7bYt3qr48fZCGcATfsLWN6xLXWqzO6PYbRtrtC7A689sKeiszarvsKpnp8S1HLzmiXxGmyOcpK6jpLH24DzchvNJruM7cJpsPk57QGspQ0Yji4WD/vawnVzBN/P+kS0h1WFfBXReuxxqw4hAU13AAAmHaAx6QKSaeypZNDQrIy4WnPjRdSA5rBVgEYjdGyS8KCP+rM58IVSLJ7HSk0/zslt9dITtdN94dZ3YmYSriVMSeY8477rlQ3bcaawcbHp8y+XSTsYiBZUc0B5DPAJ/AMnCa8/sfq3TxYdXaMNUq9Fu8r28PAKIYjYCWQSIr7h4K6A5l6BiYYCHG92vmFNSU4QWvVmHmqMGmEpXlync/zpEivZVgicf2lhtkNCK1MTn93JA9+NPI7e0nkpMvRHe/OzHSdqN6LBqG0L2t+y/rJfNj57JO8jDlw8VQpaRPtcPeUhE+nQsy8QbYor6VSbxbuoQn6llyEOtNohZuh5ruTrIgXO3RqsA88qDyXaO6mT7GVQwDJYM3gjPpyVJhkTfUn6S0mrLVITrIji9SWQQET4SWZ6IGl+N4J0h1gz2NPM8BaFw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(66556008)(5660300002)(82960400001)(66946007)(66476007)(8676002)(4326008)(8936002)(316002)(6486002)(6916009)(85182001)(54906003)(38100700002)(2906002)(508600001)(6666004)(6512007)(6506007)(26005)(33716001)(9686003)(53546011)(86362001)(186003)(83380400001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T000b2Q5SUxnMjk5YWpNWVRGWTliL08rSWhQZlhLb29MQjZhSDY3dlR5MVNQ?=
 =?utf-8?B?UFo0bWt4cGFFK3N5TUM3ZzFtVnIxV0JGMjZoWm05WFo2S0xNMmh2UWd5WjFw?=
 =?utf-8?B?bmd6eVNQRDNxbGhBcjdEWkFuUlFpQWo2WGxXYS84amF0WkQveVgxaW1GOUsv?=
 =?utf-8?B?Ymk1RGh0My9maXFmTHVwQXZKMWU3blgySGE4SXR6MkU0TDYwOWtQUlQvUE5X?=
 =?utf-8?B?YnpKVTZpVmZQczRJZWhDU0ZwbFhKOTZlMEwwWmg1RXRmREh4QUR1T0pHcmtC?=
 =?utf-8?B?ODdjYnpJMzJXV2tObWlxZHNGT20xSUJrM1JKUC9JWG1mWFBuY1J0b2Rack1o?=
 =?utf-8?B?TzFKVXV2dG50MlAzR01JUk8yby9VSm1ZaUtFeEhYbnpOWDBqYjJORVJIWUMr?=
 =?utf-8?B?c3RuYk1ZeWRmR0VqQjU5NmcxR0xsWU51S1IzR0ZYaGM0RTI1T0lFeHdkejJh?=
 =?utf-8?B?Q3RmMHdvS1JOTy83M0p1dTdueDl0QWxiR1Z0MWoyVDYrSTkzUWNSMDRRcVRN?=
 =?utf-8?B?Ykh3THBwakFHYVBBaU43Z0hmOVZ6NktGVlZuVGlQcVFZL01OZ3ZOaDRlUWI1?=
 =?utf-8?B?T2JJVXY1RTYzYjNvZEpKY05qQlFjeFEyNmVGY05zMGRKM1NRNWdpQWl5K1ZU?=
 =?utf-8?B?VGh2OVZDQ2sxY1IzclQ1T1hHdlRwVWNIZDBJSHhjWkQ1c0NpMDRvL0t5YVNT?=
 =?utf-8?B?d3liVTB1VEpOTDZhQzhTWkE1OTlvRk9aRlNscGx2SDZUZTdIMzZDMG5xWkxx?=
 =?utf-8?B?ZlMrc1pZRVVONHhXVWtRNzF4QnZBSXlMbU1ydmk2a1Bnb1E1TjJpOEs4Sldx?=
 =?utf-8?B?RSs2KzI0bng5MFZGeUFVeHVMa0NIMnJGM25qZmtoZElKS0xFSDFiYXZWREpP?=
 =?utf-8?B?UXF3blFVOUszZlNMRXJtMnhLbUZIbTF5d0Y3TjBMV2liejJQbEJpV2RlZndV?=
 =?utf-8?B?QmtMcWQyTTBtdDlZUWlDM2MzQVVzSUd6aXBvZmVCeDhIakRJSTBWT01yai9u?=
 =?utf-8?B?dTlPdit3dGpEK0pKSWRMRVA5M2RGeFpleE9EYzdCQW9ycXN4MExqZVdyeThM?=
 =?utf-8?B?eGdpaDN4TnlhVERtaHEzcWZNRit0b3o4R3hYV2NQQWthdmF2V0tPN1UvLy9K?=
 =?utf-8?B?dVllZWFGNFlGV3Z5ZHdwRjFwRkVXVjY0SDN4MCt5Y2xRTXE0VitVQTdIM29I?=
 =?utf-8?B?THRnVlZ3bzRXTmJjR1h3aHJvUTJlQVdScURtc2o4UG9qY0R1dTNJL0Zqd1d0?=
 =?utf-8?B?ZmFpa3BoaVFXR1IvVmlWeDNoTVZPNUlIQWIxUFY1d0RSaVFnQ3A4TjhlS05w?=
 =?utf-8?B?aGhQRkFSMmhFNXIxUXpZMWt6Z21ZTW5CMEp2VzZqRWovQjFrYnI3bHc1QTJO?=
 =?utf-8?B?MmJOZllzMEQ2c09GczZzMElmWllOSTJxd01ReDhPblBJUnNTK1ZsWDBoT1NR?=
 =?utf-8?B?TzdiR01ydlhqMDA5a0ZwZExmSHk4a1IrS2ZJY0xHVm1hdFVSMWtnNW9JRlgx?=
 =?utf-8?B?VmhTeE84c3ZHV0NBT1cyOVFJNUlzdSs5UlFHWnY2K1RCMFdGTE9oNERoMkRI?=
 =?utf-8?B?V2RsOVJvYUplU25CSEZIWDBIdTZqRUNKY29xNndxTHZ2TSt0ZU1YcWdUNDJZ?=
 =?utf-8?B?K2xGTUlPYWZYWGRTY2dtUnVpMkZ2aGNPUzBZZU9OTkZmcVRDempwNzNyZXVW?=
 =?utf-8?B?N0oxbWdlZ0tsRUcxQTlpTkdOREpLS2ZxR1FzbGdMZ0ZWaEw5N2YzME1KUjE5?=
 =?utf-8?B?Q2NDM1lHSFE0ZnNZYXlEQWZVZU5oZFN5ZUVCeVpWSmxiTmhJR0pqeHRVaklp?=
 =?utf-8?B?YzI4NEVOQ2dOVlBrWk1wUWFxZzNmTjgwaS81S3NXbEpzOVd4N0NsUngrQXNo?=
 =?utf-8?B?cTFkM0tabGp0ekoxVTdwTTRDVTZTanNXMmt6cXdISVJMOERodjMrTGpURGlD?=
 =?utf-8?B?Y0hkOWx4cyszRG5aWEE0OVNVVlFQdVBxancvVWV5aGk0RDR6SHNqVVAwRFpV?=
 =?utf-8?B?ajQ0WVhCUU1Sd0hXazNqT2h6VkRTeUNXaGQvSFNHRGFteEFseGlzbmdSQ2VK?=
 =?utf-8?B?SXJUVklNenpmcXVsNUxVVFE5S1MvY1lzNlhWUU42YVpweG1QU3U5aGc2OWhs?=
 =?utf-8?B?RkJkSWlaWHRhamVGUnljMVI0RU15eVdVaGRreGVuNDZoRFdvSVBUdW5uak96?=
 =?utf-8?Q?WqUA1Pnh1JfSU4rZ5W8OVQM=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 646f2ca6-f09d-4ad6-ef6a-08d9faac4a17
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2022 11:20:13.6068
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fi9AnydJhWdI6mQMn1TVPFomINz7tj5OxRxpVBPVH4HTEyBhOHIkBBYtG/0z3O5r0kRFA/g3v8WOT1mjd3SEQw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB3395
X-OriginatorOrg: citrix.com

On Thu, Feb 24, 2022 at 03:16:08PM +0100, Jan Beulich wrote:
> On 18.02.2022 18:29, Jane Malalane wrote:
> > --- a/xen/arch/x86/hvm/vmx/vmx.c
> > +++ b/xen/arch/x86/hvm/vmx/vmx.c
> > @@ -3333,15 +3333,15 @@ static void vmx_install_vlapic_mapping(struct vcpu *v)
> >  
> >  void vmx_vlapic_msr_changed(struct vcpu *v)
> >  {
> > -    int virtualize_x2apic_mode;
> > +    bool virtualize_x2apic_mode;
> >      struct vlapic *vlapic = vcpu_vlapic(v);
> >      unsigned int msr;
> >  
> >      virtualize_x2apic_mode = ( (cpu_has_vmx_apic_reg_virt ||
> >                                  cpu_has_vmx_virtual_intr_delivery) &&
> > -                               cpu_has_vmx_virtualize_x2apic_mode );
> > +                               v->domain->arch.hvm.assisted_x2apic );
> 
> Following from my comment on patch 1, I'd expect this to become a simple
> assignment of v->domain->arch.hvm.assisted_x2apic (at which point the
> local variable could go away), just like ...

I think we want to keep assisted_x{2}apic mapped to
SECONDARY_EXEC_VIRTUALIZE_APIC_ACCESSES and
SECONDARY_EXEC_VIRTUALIZE_X2APIC_MODE respectively, so that in the
future we could add further controls for
SECONDARY_EXEC_APIC_REGISTER_VIRT and interrupt delivery.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Feb 28 11:22:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 11:22:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280435.478376 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOe6q-0003Wq-U0; Mon, 28 Feb 2022 11:22:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280435.478376; Mon, 28 Feb 2022 11:22:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOe6q-0003Wj-Qt; Mon, 28 Feb 2022 11:22:32 +0000
Received: by outflank-mailman (input) for mailman id 280435;
 Mon, 28 Feb 2022 11:22:31 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=fISF=TL=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1nOe6p-0003Wb-AE
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 11:22:31 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b30f570a-9888-11ec-8539-5f4723681683;
 Mon, 28 Feb 2022 12:22:23 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id B8D7B1F894;
 Mon, 28 Feb 2022 11:22:29 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9E0FC13BF2;
 Mon, 28 Feb 2022 11:22:29 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id hQE6JXWwHGJXCwAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 28 Feb 2022 11:22:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b30f570a-9888-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1646047349; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=m7I5A173opEnfcDaFgzNXcoVpGQKDwm933aaAHHQBIg=;
	b=oXmlHk9EdajLlcNjlHupaNKu3FBZB35Y8RY8hCZYH8S9UW5Lp/xl9C+97NWSnKB8AtbEqz
	jI5vZg98fS7fZli3R3hI+BTJlhq/YkIPXJw3xLSbPeAqwuAMJnrRTMXZhU9Ofa4Vr7kMPU
	f3VE1akEbI0YQY28Luz7QWQEBhVbJ7M=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>
Subject: [PATCH] include/public: add command result definitions to vscsiif.h
Date: Mon, 28 Feb 2022 12:22:24 +0100
Message-Id: <20220228112224.18942-1-jgross@suse.com>
X-Mailer: git-send-email 2.34.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

The result field of struct vscsiif_response is lacking a detailed
definition. Today the Linux kernel internal scsi definitions are being
used, which is not a sane interface for a PV device driver.

Add macros to change that by using today's values in the XEN namespace.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 xen/include/public/io/vscsiif.h | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/xen/include/public/io/vscsiif.h b/xen/include/public/io/vscsiif.h
index c9ceb1884d..17a9033b43 100644
--- a/xen/include/public/io/vscsiif.h
+++ b/xen/include/public/io/vscsiif.h
@@ -315,6 +315,33 @@ struct vscsiif_response {
 };
 typedef struct vscsiif_response vscsiif_response_t;
 
+/* SCSI I/O status from vscsiif_response->rslt */
+#define XEN_VSCSIIF_RSLT_STATUS(x)  (x & 0x00ff)
+
+/* Host I/O status from vscsiif_response->rslt */
+#define XEN_VSCSIIF_RSLT_HOST(x)    ((unsigned)x >> 16)
+#define XEN_VSCSIIF_RSLT_HOST_OK         0
+#define XEN_VSCSIIF_RSLT_HOST_NO_CONN    1 /* Couldn't connect before timeout */
+#define XEN_VSCSIIF_RSLT_HOST_BUS_BUSY   2 /* BUS busy through timeout */
+#define XEN_VSCSIIF_RSLT_HOST_TIME_OUT   3 /* TIMED OUT for other reason */
+#define XEN_VSCSIIF_RSLT_HOST_BAD_TARG   4 /* BAD target */
+#define XEN_VSCSIIF_RSLT_HOST_ABORT      5 /* Abort for some other reason */
+#define XEN_VSCSIIF_RSLT_HOST_PARITY     6 /* Parity error */
+#define XEN_VSCSIIF_RSLT_HOST_ERROR      7 /* Internal error */
+#define XEN_VSCSIIF_RSLT_HOST_RESET      8 /* Reset by somebody */
+#define XEN_VSCSIIF_RSLT_HOST_BAD_INTR   9 /* Unexpected interrupt */
+#define XEN_VSCSIIF_RSLT_HOST_PASSTHR   10 /* Force command past mid-layer */
+#define XEN_VSCSIIF_RSLT_HOST_SOFT_ERR  11 /* Retry requested */
+#define XEN_VSCSIIF_RSLT_HOST_IMM_RETR  12 /* Hidden retry requested */
+#define XEN_VSCSIIF_RSLT_HOST_REQUEUE   13 /* Requeue command requested */
+#define XEN_VSCSIIF_RSLT_HOST_DISRUPT   14 /* Transport error disrupted I/O */
+#define XEN_VSCSIIF_RSLT_HOST_FAILFAST  15 /* Transport class fastfailed */
+#define XEN_VSCSIIF_RSLT_HOST_TARG_FAIL 16 /* Permanent target failure */
+#define XEN_VSCSIIF_RSLT_HOST_NEX_FAIL  17 /* Permanent nexus failure on path */
+#define XEN_VSCSIIF_RSLT_HOST_NOMEM     18 /* Space allocation failed */
+#define XEN_VSCSIIF_RSLT_HOST_MED_ERR   19 /* Medium error */
+#define XEN_VSCSIIF_RSLT_HOST_MARGINAL  20 /* Transport marginal errors */
+
 DEFINE_RING_TYPES(vscsiif, struct vscsiif_request, struct vscsiif_response);
 
 
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Mon Feb 28 11:26:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 11:26:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280442.478388 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOeAv-0004Er-Fj; Mon, 28 Feb 2022 11:26:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280442.478388; Mon, 28 Feb 2022 11:26:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOeAv-0004Ej-C1; Mon, 28 Feb 2022 11:26:45 +0000
Received: by outflank-mailman (input) for mailman id 280442;
 Mon, 28 Feb 2022 11:26:43 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nOeAt-0004EZ-Pu; Mon, 28 Feb 2022 11:26:43 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nOeAt-0003nT-MY; Mon, 28 Feb 2022 11:26:43 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nOeAt-0003xN-4c; Mon, 28 Feb 2022 11:26:43 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nOeAt-0002zS-3m; Mon, 28 Feb 2022 11:26:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=CVD+QIHdKbZTh9gVxZWsRUXBykJ93J+hICxKFJxrOX4=; b=yoNGVttxLxcySZSncvLxZL+Kx4
	pPkcmLC5h2BnkQgE9e7uSrAjAuL0kVRCoz26ruPw8xr7xEkqmVdE+en+4ls9vGFZ572INmYilYsHJ
	JY+YDx3TgTpvdPqv2jhHZiq5Nl/DYl7mWzhX8bgHDoWlJr81Zz/3uk404ZEp0sLzkgSo=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168250-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 168250: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=7e57714cd0ad2d5bb90e50b5096a0e671dec1ef3
X-Osstest-Versions-That:
    linux=52a02554673122486ecb36c36387d91cf9544986
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 28 Feb 2022 11:26:43 +0000

flight 168250 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168250/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168247
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168247
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168247
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168247
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168247
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168247
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168247
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168247
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                7e57714cd0ad2d5bb90e50b5096a0e671dec1ef3
baseline version:
 linux                52a02554673122486ecb36c36387d91cf9544986

Last test of basis   168247  2022-02-27 21:39:42 Z    0 days
Testing same since   168250  2022-02-28 03:45:58 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Linus Torvalds <torvalds@linux-foundation.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   52a025546731..7e57714cd0ad  7e57714cd0ad2d5bb90e50b5096a0e671dec1ef3 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Mon Feb 28 11:30:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 11:30:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280455.478399 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOeEs-0005hu-5M; Mon, 28 Feb 2022 11:30:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280455.478399; Mon, 28 Feb 2022 11:30:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOeEs-0005hn-19; Mon, 28 Feb 2022 11:30:50 +0000
Received: by outflank-mailman (input) for mailman id 280455;
 Mon, 28 Feb 2022 11:30:48 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=hgP/=TL=lst.de=hch@srs-se1.protection.inumbo.net>)
 id 1nOeEq-0005hR-NM
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 11:30:48 +0000
Received: from verein.lst.de (verein.lst.de [213.95.11.211])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id df9d61c1-9889-11ec-8eba-a37418f5ba1a;
 Mon, 28 Feb 2022 12:30:47 +0100 (CET)
Received: by verein.lst.de (Postfix, from userid 2407)
 id 1E95C68AFE; Mon, 28 Feb 2022 12:30:43 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: df9d61c1-9889-11ec-8eba-a37418f5ba1a
Date: Mon, 28 Feb 2022 12:30:42 +0100
From: Christoph Hellwig <hch@lst.de>
To: "Michael Kelley (LINUX)" <mikelley@microsoft.com>
Cc: Christoph Hellwig <hch@lst.de>,
	"iommu@lists.linux-foundation.org" <iommu@lists.linux-foundation.org>,
	"x86@kernel.org" <x86@kernel.org>,
	Anshuman Khandual <anshuman.khandual@arm.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>, Joerg Roedel <joro@8bytes.org>,
	David Woodhouse <dwmw2@infradead.org>,
	Lu Baolu <baolu.lu@linux.intel.com>,
	Robin Murphy <robin.murphy@arm.com>,
	"linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"linux-ia64@vger.kernel.org" <linux-ia64@vger.kernel.org>,
	"linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
	"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
	"linux-riscv@lists.infradead.org" <linux-riscv@lists.infradead.org>,
	"linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
	"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
	"tboot-devel@lists.sourceforge.net" <tboot-devel@lists.sourceforge.net>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: Re: [PATCH 08/11] swiotlb: make the swiotlb_init interface more
 useful
Message-ID: <20220228113042.GA10570@lst.de>
References: <20220227143055.335596-1-hch@lst.de> <20220227143055.335596-9-hch@lst.de> <MN0PR21MB309816A344171B46735CA29CD7019@MN0PR21MB3098.namprd21.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <MN0PR21MB309816A344171B46735CA29CD7019@MN0PR21MB3098.namprd21.prod.outlook.com>
User-Agent: Mutt/1.5.17 (2007-11-01)

On Mon, Feb 28, 2022 at 02:53:39AM +0000, Michael Kelley (LINUX) wrote:
> From: Christoph Hellwig <hch@lst.de> Sent: Sunday, February 27, 2022 6:31 AM
> > 
> > Pass a bool to pass if swiotlb needs to be enabled based on the
> > addressing needs and replace the verbose argument with a set of
> > flags, including one to force enable bounce buffering.
> > 
> > Note that this patch removes the possibility to force xen-swiotlb
> > use using swiotlb=force on the command line on x86 (arm and arm64
> > never supported that), but this interface will be restored shortly.
> > 
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> > ---
> >  arch/arm/mm/init.c                     |  6 +----
> >  arch/arm64/mm/init.c                   |  6 +----
> >  arch/ia64/mm/init.c                    |  4 +--
> >  arch/mips/cavium-octeon/dma-octeon.c   |  2 +-
> >  arch/mips/loongson64/dma.c             |  2 +-
> >  arch/mips/sibyte/common/dma.c          |  2 +-
> >  arch/powerpc/include/asm/swiotlb.h     |  1 +
> >  arch/powerpc/mm/mem.c                  |  3 ++-
> >  arch/powerpc/platforms/pseries/setup.c |  3 ---
> >  arch/riscv/mm/init.c                   |  8 +-----
> >  arch/s390/mm/init.c                    |  3 +--
> >  arch/x86/kernel/cpu/mshyperv.c         |  8 ------
> >  arch/x86/kernel/pci-dma.c              | 15 ++++++-----
> >  arch/x86/mm/mem_encrypt_amd.c          |  3 ---
> >  drivers/xen/swiotlb-xen.c              |  4 +--
> >  include/linux/swiotlb.h                | 15 ++++++-----
> >  include/trace/events/swiotlb.h         | 29 ++++++++-------------
> >  kernel/dma/swiotlb.c                   | 35 ++++++++++++++------------
> >  18 files changed, 56 insertions(+), 93 deletions(-)
> 
> [snip]
> 
> > 
> > diff --git a/arch/x86/kernel/cpu/mshyperv.c b/arch/x86/kernel/cpu/mshyperv.c
> > index 5a99f993e6392..568274917f1cd 100644
> > --- a/arch/x86/kernel/cpu/mshyperv.c
> > +++ b/arch/x86/kernel/cpu/mshyperv.c
> > @@ -336,14 +336,6 @@ static void __init ms_hyperv_init_platform(void)
> >  			swiotlb_unencrypted_base = ms_hyperv.shared_gpa_boundary;
> >  #endif
> >  		}
> > -
> > -#ifdef CONFIG_SWIOTLB
> > -		/*
> > -		 * Enable swiotlb force mode in Isolation VM to
> > -		 * use swiotlb bounce buffer for dma transaction.
> > -		 */
> > -		swiotlb_force = SWIOTLB_FORCE;
> > -#endif
> 
> With this code removed, it's not clear to me what forces the use of the
> swiotlb in a Hyper-V isolated VM.  The code in pci_swiotlb_detect_4g() doesn't
> catch this case because cc_platform_has(CC_ATTR_HOST_MEM_ENCRYPT)
> returns "false" in a Hyper-V guest.  In the Hyper-V guest, it's only
> cc_platform_has(CC_ATTR_GUEST_MEM_ENCRYPT) that returns "true".  I'm
> looking more closely at the meaning of the CC_ATTR_* values, and it may
> be that Hyper-V should also return "true" for CC_ATTR_MEM_ENCRYPT,
> but I don't think CC_ATTR_HOST_MEM_ENCRYPT should return "true".

Ok, I assumed that CC_ATTR_HOST_MEM_ENCRYPT returned true in this case.
I guess we just need to check for CC_ATTR_GUEST_MEM_ENCRYPT as well
there?


From xen-devel-bounces@lists.xenproject.org Mon Feb 28 12:10:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 12:10:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280475.478413 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOeqq-0001VZ-8q; Mon, 28 Feb 2022 12:10:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280475.478413; Mon, 28 Feb 2022 12:10:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOeqq-0001VS-5M; Mon, 28 Feb 2022 12:10:04 +0000
Received: by outflank-mailman (input) for mailman id 280475;
 Mon, 28 Feb 2022 12:10:03 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=EMlY=TL=citrix.com=prvs=051191599=Jane.Malalane@srs-se1.protection.inumbo.net>)
 id 1nOeqo-0001Ch-Md
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 12:10:02 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 59739118-988f-11ec-8eba-a37418f5ba1a;
 Mon, 28 Feb 2022 13:10:00 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 59739118-988f-11ec-8eba-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1646050200;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=BoN8B1+cDkPXX9B0BoNFj3nAifW7TvSeiefJpZxzqc8=;
  b=a4tXeBDkoAwZ0K2UHAopTB+vFsjUTNm1fK+pMjK1kkJziKQzVpLO2p9X
   FacPEV1x+7h0jaa+5K8WAp1njjBw6PPLTd6mWqusr/N43F+Xm/98lelYZ
   WSDu7EidEg13x33VfL6Y4gZV94VG5n6SYbm3TmIU5RyCnlMyb1bToJjq+
   w=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 65015440
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:XLo0NKrwzOiuEL/FPBWTdZbNpydeBmKpZRIvgKrLsJaIsI4StFCzt
 garIBnTO/3bM2X8KdkkYIi390sHupPRyYNrHgM//y00Qn9Dp5uZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlVEliefQAOCU5NfsYkidfyc9IMsaoU8lyrZRbrJA24DjWVvX4
 4yq+aUzBXf+s9JKGjNMg068gEsHUMTa4Fv0aXRnOJinFHeH/5UkJMp3yZOZdhMUcaENdgKOf
 M7RzanRw4/s10xF5uVJMFrMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKv+Zvrgc91Zk
 b1wWZKMpQgBPKzHsrw6dBNkSAJ7PfV03JXXEVGumJnGp6HGWyOEL/RGCUg3OcsT+/ptAHEI/
 vsdQNwPRknd3aTsmuv9E7QywJR4RCXoFNp3VnVI7zjfALADSJTKR6zM6PdT3Ssqh9AIFvHbD
 yYcQWQyNE2dP0EXUrsRIK09uPiU21PBSTEClXfI/IQU7W7R9BMkhdABN/KKI4fXFK25hH2wr
 G/c437wBB1cMdWF0CeE6VqlnOqJliT+MKosE7m/+u9vkUek7GUZAx0LVnO2ufC8zEW5Xrp3K
 VESvCwnrqEw9UmiZtj7QxC85nWDu3Y0S9dWVuE39gyJ4q7V+BqCQHgJSCZbb94rv9NwQiYlv
 neKks3oA3pzsbSTYXOb6rqQ6zi1PEA9MmsqdSICCwwf7LHLoos+kxbORdZLC7Oug5v+HjSY6
 zKFti8lnJ0IkNUGka68+DjvmCmwr5LESgo04AT/XW+/6A59Iom/aOSA60Xf7PtGBJaUSB+Gp
 ndspiSFxLlQV9fXznXLGbhTWuHyjxqYDNHCqVxuFLN50BOnxyWAeIAI0hVUNHdAI+9RLFcFf
 3TvkQ9W4ZZSOl6jYql2f5+9BqwW8ETwKTj2fquKN4QTO/CdYCfCpXgzPhDIgwgBhWBxyflXB
 HuNTSq74Z/244xDxSH+eeoS2KRDKssWlTKKHsCTI/hKPNOjiJ+ppVUtbQHmggMRtvrsTODpH
 zB3bZbiJ/J3CrCWX8Uv2dRPRW3m1FBibXwMl+RZd/SYPi1tE3w7BvnazNsJItI5wvUFyb6Ro
 i/lCie0LWYTY1WddG1mjVg5NdvSsWtX9ypnbUTAw37ys5TcXWpfxPhGLMZmFVXW3Odi0eR1X
 5E4lzaoWZxypsD8021FN/HV9dU6HDzy3F7mF3f1MVAXIs87LySUq4CMQ+ca3HRXZsZBnZBl+
 OPIO8KyacdrejmO++6NMKP/lw7q5CNF8A+wNmORSuRulIzX2NECAwT6j+MtItFKLhPGxzCA0
 B2RDwteru7Iy7LZOvGQ7UxYh+9Fy9dDI3c=
IronPort-HdrOrdr: A9a23:DBucRK6FepY72BpIUgPXwWWBI+orL9Y04lQ7vn2ZFiY7TiXIra
 yTdaoguCMc0AxhJU3Jmbi7Scy9qeu1z+873WBjB8bfYOCAghrnEGgC1/qv/9SEIUPDH4FmpN
 5dmsRFeb7N5B1B/LzHCWqDYpcdKbu8gdiVbI7lph8HJ2ALV0gj1XYDNu/yKDwseOAsP+tcKH
 Po3Lsgm9PWQwVxUi3UPAhmY8Hz4/nw0L72ax8PABAqrCOUiymz1bL8Gx+Emj8DTjJm294ZgC
 j4uj28wp/mn+Cwyxfa2WOWxY9RgsHdxtxKA9HJotQJKw/rlh2jaO1aKv6/VXEO0aOSAWQR4Z
 3xSiQbToNOArTqDyeISC7WqkzdOfAVmibfIBGj8CPeSIfCNU0H4oJ69Pxkm13imhAdVZhHod
 N29nPcuJxNARzamiPho9DOShFxj0Kx5WEviOgJkhVkIMAjgRBq3PkiFW5uYd499RjBmcga+S
 hVfbXhzecTdUnfY2HSv2FpztDpVnMvHg2eSkxHvsCOyTBZkH1w0kNdnaUk7zo93YN4T4MB6/
 XPM6xumr0LRsgKbbhlDONERcesEGTCTR/FLWrXK1X6E6MMPW7LtvfMkf8IzfDvfIZNwIo5mZ
 zHXl8dvWkue1j2AcnLx5FP+gClehTKYd0s8LAo23FUgMyOeFOwC1zydLkHqbrTn8ki
X-IronPort-AV: E=Sophos;i="5.90,142,1643691600"; 
   d="scan'208";a="65015440"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=BnIHTwM0iA0HvlJHXxNS9uWCzEVjVERBgVTwkC1U8srKWkMb96BQ/qQRrTQa3lSAWb5VfrYBNeQLd3/uvLKuKye8wtYGvzi8xDvaigP9xGw5eQqua1jprgx+IN6Az1e6ZLhSqRNLRr712LCyQpraCWw9ZDsIteDxxxiCcXHGkDPqhCwy0CaM9jmPvd3+dOqyq/q4UteKaCqDnhJYLrTl/y2m3/uRtucBVc5bmy1u23cqTSRMF9AYY58MWQcV2vLlBb4BVKUNx7r/X3OqzrJe4R+TLVyiH55N4YapJpSetJANSsOIhZVs3hVc76lQPPkodC+4nGbZGRcHyfqctX1Kcw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=BoN8B1+cDkPXX9B0BoNFj3nAifW7TvSeiefJpZxzqc8=;
 b=QZMpHv2b5hkHfazuedXE7SW0AD9FIGA4uWNioNg0B29ozKYF0IUOKazT5kBmOH5AkBrgBvExHRiPkmd8v1TwSqDu0MyWvR/goYrVum7VQhqpf6x6tOt/uFoO2fKG7GpDlxXizY0GczYMERZvVhTCK930+oN0ZphfOi5JB0t+LJj8WwrKE42MjIzEufmNVFwnpjRppmgkijJGJGrw8v8XAcFD4gpCu06wnPcI+zVSafywq8BWQA/CX09J9jjN5nm25ONtu/QqL7EcLEOmV+SuvOzv7g9ISh6n8UBE+UIuOE5GwR3A+wO/P9fCzB3xreAzHThKQsutps9/RFvtC1aTCw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=BoN8B1+cDkPXX9B0BoNFj3nAifW7TvSeiefJpZxzqc8=;
 b=Rsfl9m9D8+P7P0VmgYB20DT3mBQKy1LgC31omIsi1DE23A/YRqbJ0xtsb9h6bnFGTfRGwQJKrFOeP6ztvzLJvmxv9DWWV3Y3IFedWewcASz8kjdoElhG+MSFbWROxBIiOi1+wbIfZoYZyIjDRjC/cyxkeOmjWFZR4r4L654ABJI=
From: Jane Malalane <Jane.Malalane@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Wei Liu <wl@xen.org>, Anthony Perard <anthony.perard@citrix.com>, "Juergen
 Gross" <jgross@suse.com>, Andrew Cooper <Andrew.Cooper3@citrix.com>, "George
 Dunlap" <George.Dunlap@citrix.com>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>,
	Jun Nakajima <jun.nakajima@intel.com>, Kevin Tian <kevin.tian@intel.com>,
	Roger Pau Monne <roger.pau@citrix.com>, Xen-devel
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v3 1/2] xen+tools: Report Interrupt Controller
 Virtualization capabilities on x86
Thread-Topic: [PATCH v3 1/2] xen+tools: Report Interrupt Controller
 Virtualization capabilities on x86
Thread-Index: AQHYJO06JWynylsFtkyl8WR8WaDosKyixjKAgAGyPACABChhAIAATYQA
Date: Mon, 28 Feb 2022 12:09:55 +0000
Message-ID: <b594fe28-6b47-d697-a038-b1a9ee903288@citrix.com>
References: <20220218172943.12182-1-jane.malalane@citrix.com>
 <20220218172943.12182-2-jane.malalane@citrix.com>
 <0a31970c-c0f8-c995-ce04-67523a4a830a@suse.com>
 <22ae35a0-9df8-9357-4b44-2f00586144fc@citrix.com>
 <de431523-ad71-1cb6-a28d-07418886ee23@suse.com>
In-Reply-To: <de431523-ad71-1cb6-a28d-07418886ee23@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: ac19d435-d6bd-4aef-7969-08d9fab33b9e
x-ms-traffictypediagnostic: BN6PR03MB3105:EE_
x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
x-microsoft-antispam-prvs: <BN6PR03MB3105AB5E8FC5E11A26DE316B81019@BN6PR03MB3105.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: L49invFVqbhuJ1oj9ELhvL8mS8VxJI9qMaTnQwUiWVCPnpUNo8bVe5MVvmXCVXvQjqUB9BLsni7salX2mO+/g6foWHv1JgMxMnqmF3KiaDGEOIGYgcIQusGaqsZRcRx32YEF4o0ocxKc0bi10BCOh7goc17GTHgBIA40TfWL/b39/w3E/Hws5u51SeBMm50QHM2wjEoY0kuDClTb56SjcQdcNAMHWNLypJkEG2MVSG4Zhp2jJ6xmjBNXC0QqU69lxvp19nR6qAc6z0XaWBa5RbA17ZboAeoJeE/Cm3JHwT+/MK63UnUP5k0tEq0mQIc+cyBp9BQV2Aw2/YtY+yum5UebbLrMxnDlMgEpWGrzoXtyvmJprtj8auiNQnrZFNN+xd4mp6olLs7C/n8L8afr9cDT/nFQt7cDo7E0ch/TzGT4aYTbHg+K7kyAlD2cFSrC9ym1wcCGnZ1m9rtLP5zIkKx2yygffZU2I2dGStM/R/ldUW+8OtdaAf2sMCneCxrhdt/NTLlnJlm/MBIEVk2ekjNW2vmV58RmHAU3urgLCqv+24EyvEi6+VElfHi3/7B534RWewq+nk9v4xJ0YiYaX+nTJTVbRGDRGpGMBVOSS1f8yuhMJJFUAChZhe9aSABP/zHzSr+Jtuhxe/lCpwdtUIzRFEMUYRzYBOFtRYEbGiWoWWerpQFmQG+NBoChpdru/gofGCticD6e+2eixMQJxW6eMlAciMFNVb5FaKk8VOtok0wZa9mEXbqkhm0J38IQ
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR03MB3386.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(91956017)(82960400001)(38100700002)(55236004)(53546011)(38070700005)(2616005)(6486002)(31696002)(86362001)(26005)(122000001)(186003)(54906003)(83380400001)(508600001)(6916009)(66946007)(76116006)(5660300002)(66476007)(66446008)(64756008)(36756003)(66556008)(4326008)(2906002)(71200400001)(8676002)(7416002)(31686004)(316002)(6506007)(6512007)(8936002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Qk5aSDdPTmtRTG9XNzR0b0krcGxGY09Wc1dvUDgvT3A3VHZlYmdSNm9Ibmx3?=
 =?utf-8?B?TjdpeVVOS0ZGaFNuL1p4VzlHYWVqengvL2JoNUVrTjcyM2NQcDBFZ1lNMStx?=
 =?utf-8?B?VWRsc0xwb3U4YVZPWGludVY5MXBHbE9RazhUMzM3Tm1Rc0NQT3dxaXBneXJI?=
 =?utf-8?B?YlFWcXpDSXRWVUJEL08zUVY5TWU0Mnl2cEY2WE13aFpNT1BjYXMvM2h1MzRj?=
 =?utf-8?B?TTFRb2lKeCtBM1UvU0hINmx2VGxVUUlpMXl1emJIZGFydXpkbWpScmlhZ1Nx?=
 =?utf-8?B?OE9Wc0sxa2RqQ1ViU3Vjb2puWFlwN1M3cWNWZFNmRlY4a0NlZlNsZzFpdk5s?=
 =?utf-8?B?b2xhbms1M3VqM3NkakJxdFR1cnkvdzVHTGwxY1BFR1hPaWtWZDM4cmVCM2Zv?=
 =?utf-8?B?MUlSTytta09SeHdEZHViNEtmK1ZKSFVPSm56VlhrS2RSMThRL0hHVTh2eWZj?=
 =?utf-8?B?bHZnZGY5M2VzdFRXVVVpZVFrVXBJaVZveFZIYVBzWFk1K1h2N3c1M05wMlVI?=
 =?utf-8?B?K2VmdVhhbllOTndaTGdVL0FvUURUWXAwQ3FFN2tuTWNaOEJINUpHbEFHMnM0?=
 =?utf-8?B?T1JWSktZOUwxcmQ5T2ZlMXQ5WEsrOUc3NVFnSWJ5cXJyY0JoRUdZNkhMcmRF?=
 =?utf-8?B?T0plRHQzamp1TnY2TU9PcVQrc0dQRUFJUXErUHF2OHlxUnpudE5vOFVDaitP?=
 =?utf-8?B?SWlsWDFabmowbEJNMEN5R0lwMHlzVEtDei9QS0ZCRlhqQm1PWC8wN0NmVzNU?=
 =?utf-8?B?MlRSTDh1NStxYy9PeG8zaGM5TVZ1bHYrVEdGS1RVNVE4L0g4TlhmaG45TzJI?=
 =?utf-8?B?bTgySTY5Q3NoR3IvVDdad1NzU2VVNjFlT0lsZTlzUHNFRTRidHhQZXNqdG1Q?=
 =?utf-8?B?aGRCSmtla2hxUm5sbnYyeGVNQkRnTUVFRXhqZldleWFmbDhPM3FvZmZXWXBZ?=
 =?utf-8?B?amsvWFR6NGpTdEVvU1JMTkJUcVJ6SUp3SFc1Ykp4N0x2WjhLcnU3TmJvL09V?=
 =?utf-8?B?YjdTcG9FL0dkU1BTWlBFVDQrNzVwVHZjY3F3aU54UGo0bkx6eVR6blQ3S2wx?=
 =?utf-8?B?aS9GaW4xT01VRVI1Vmk5RVB3N2UrV0pibW13QlVjaVJLbTNhUWJ1T2Z2V29H?=
 =?utf-8?B?NnpsTjE1NmxaYmdTSzMyRHZEVEh5MVVGNkcwbGtxVVNGbzB5Nk9FL3crdXQ1?=
 =?utf-8?B?YVFQNU1LTURzSmpFanpEVFdScnBrTi9FNUgweVdBNENMWjhmUlRObTZCYy9L?=
 =?utf-8?B?RmFUU2tyNjhHNWhUYWFZeGFIbmQzdUJrS2lRVmUvaFBVRFh4Mi9mV2FkWlVH?=
 =?utf-8?B?TGtVWjJVN2lzOEI0cWtlUHlRREdteWplbDVVd2p1QWhKN1NDZFB0QmNGcC9L?=
 =?utf-8?B?RWg5Q3AzTmlIajBqbW9aTUQyeVFtbUZyMC8xYnJoV3BmdkdxSjRaWmt1UDhT?=
 =?utf-8?B?RVVJTUFXMTkxaUJzTktIWC9CdmxhZjQ3MHhyMmpmaFRsRFJCMWxhTUl1eTVj?=
 =?utf-8?B?VklYSXNjNVlMN1VmTDNXdTN2eUo0cUFWaVB0bzlITFlFdmNMVlFMNEtjU0xG?=
 =?utf-8?B?ZTRJN25za3RzeFhLbVA5QzF0Nk5OR3A3cnlMR0VNanczS2pJUE9uUU4yQ1dn?=
 =?utf-8?B?RElvUjMzenUwWkMvblUwaXZiQmp2T0w0NTRWeFNsYlIxT2JDVTl2c1Y3U2lF?=
 =?utf-8?B?QVBaZTNPU1JUU0M5ams5cnFjRlZmUDcwWS9KVWVPeU5Hdzd3QzcvRWs4UWJQ?=
 =?utf-8?B?ak96SzBoekliNWo1T0NLeXk5Ymlpc2ZWL0JGa3c2TEgzRVRjV3RKdGtMODFK?=
 =?utf-8?B?VHc0emljQ2E2NFlwaVJKZ0RRUkRLcEJXVzl4blE2MG5ON0R4elR6cTJoYk4w?=
 =?utf-8?B?NXRnbS9pY2p5d0JIRDhjYkljSk1INHcrMzZkRXY5RTZxSVpTbHZpandxK05n?=
 =?utf-8?B?cTByWkpYb2hmSVVmeEs0N2MzdEYzSFVlNGJLeUpjZkFURUltZkhuQWlRWkVm?=
 =?utf-8?B?cXFteHhSenhYWHJzUy9tVy9EMHBFbGgxMmpXMUpOV3JxajhENWZHWjQzM0pF?=
 =?utf-8?B?Z29sTExXcDBsMVN2Tmp5L3dXQWkxbk8xbHJaTFZaU09aRm8wb2lUdW8waDAy?=
 =?utf-8?B?Y0lHalJHQ3dDNGorZERTemNhUmQ4ZEFzaGFJSzF1RkZzb0ZRNXh2MnFGS0hW?=
 =?utf-8?B?ZDV3QUVjVnBuQldGQ2c0Qjk3Zmx6UlR5WklLeTRhRTFsV296Sm5tV2ZoM2dh?=
 =?utf-8?Q?npGSucDbeLVdSsEDh8eBZnFnGP8z/sOAITV5BY0VUI=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <845152238ACFF945B8B65B6796453EBF@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM5PR03MB3386.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ac19d435-d6bd-4aef-7969-08d9fab33b9e
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Feb 2022 12:09:55.4248
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: U15xt6h7t3PRQPqFqriWS+7cFCtW3JfGe3CUPaDTYqFhSmCV1xtbMNMNftT5fkT5NAemqMjrdj2FrGgPfZFjGphq35zLzpgjA9WowAps7VE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB3105
X-OriginatorOrg: citrix.com

T24gMjgvMDIvMjAyMiAwNzozMiwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IFtDQVVUSU9OIC0gRVhU
RVJOQUwgRU1BSUxdIERPIE5PVCByZXBseSwgY2xpY2sgbGlua3MsIG9yIG9wZW4gYXR0YWNobWVu
dHMgdW5sZXNzIHlvdSBoYXZlIHZlcmlmaWVkIHRoZSBzZW5kZXIgYW5kIGtub3cgdGhlIGNvbnRl
bnQgaXMgc2FmZS4NCj4gDQo+IE9uIDI1LjAyLjIwMjIgMTc6MDIsIEphbmUgTWFsYWxhbmUgd3Jv
dGU6DQo+PiBPbiAyNC8wMi8yMDIyIDE0OjA4LCBKYW4gQmV1bGljaCB3cm90ZToNCj4+PiBPbiAx
OC4wMi4yMDIyIDE4OjI5LCBKYW5lIE1hbGFsYW5lIHdyb3RlOg0KPj4+PiBBZGQgWEVOX1NZU0NU
TF9QSFlTQ0FQX0FSQ0hfQVNTSVNURURfeGFwaWMgYW5kDQo+Pj4+IFhFTl9TWVNDVExfUEhZU0NB
UF9BUkNIX0FTU0lTVEVEX3gyYXBpYyB0byByZXBvcnQgYWNjZWxlcmF0ZWQgeGFwaWMNCj4+Pj4g
YW5kIHgyYXBpYywgb24geDg2IGhhcmR3YXJlLg0KPj4+PiBObyBzdWNoIGZlYXR1cmVzIGFyZSBj
dXJyZW50bHkgaW1wbGVtZW50ZWQgb24gQU1EIGhhcmR3YXJlLg0KPj4+Pg0KPj4+PiBGb3IgdGhh
dCBwdXJwb3NlLCBhbHNvIGFkZCBhbiBhcmNoLXNwZWNpZmljICJjYXBhYmlsaXRpZXMiIHBhcmFt
ZXRlcg0KPj4+PiB0byBzdHJ1Y3QgeGVuX3N5c2N0bF9waHlzaW5mby4NCj4+Pj4NCj4+Pj4gU3Vn
Z2VzdGVkLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPg0KPj4+
PiBTaWduZWQtb2ZmLWJ5OiBKYW5lIE1hbGFsYW5lIDxqYW5lLm1hbGFsYW5lQGNpdHJpeC5jb20+
DQo+Pj4+IC0tLQ0KPj4+PiB2MzoNCj4+Pj4gICAgKiBEZWZpbmUgWEVOX1NZU0NUTF9QSFlTQ0FQ
X0FSQ0hfTUFYIGZvciBBQkkgY2hlY2tpbmcgYW5kIGFjdHVhbGx5DQo+Pj4+ICAgICAgc2V0IGFy
Y2hfY2FwYmlsaXRpZXMsIHZpYSBhIGNhbGwgdG8gY19iaXRtYXBfdG9fb2NhbWxfbGlzdCgpDQo+
Pj4+ICAgICogSGF2ZSBhc3Npc3RlZF94MmFwaWNfYXZhaWxhYmxlIG9ubHkgZGVwZW5kIG9uDQo+
Pj4+ICAgICAgY3B1X2hhc192bXhfdmlydHVhbGl6ZV94MmFwaWNfbW9kZQ0KPj4+DQo+Pj4gSSB1
bmRlcnN0YW5kIHRoaXMgd2FzIHRoZSByZXN1bHQgZnJvbSBwcmV2aW91cyBkaXNjdXNzaW9uLCBi
dXQgdGhpcw0KPj4+IG5lZWRzIGp1c3RpZnlpbmcgaW4gdGhlIGRlc2NyaXB0aW9uLiBOb3QgdGhl
IGxlYXN0IGJlY2F1c2UgaXQgZGlmZmVycw0KPj4+IGZyb20gd2hlbiBYRU5fSFZNX0NQVUlEX1gy
QVBJQ19WSVJUIHdvdWxkIGJlIHNldCBhcyB3ZWxsIGFzIGZyb20gd2hhdA0KPj4+IHZteF92bGFw
aWNfbXNyX2NoYW5nZWQoKSBkb2VzLiBUaGUgZGlmZmVyZW5jZSBiZXR3ZWVuIHRob3NlIHR3byBp
cw0KPj4+IHByb2JhYmx5IGludGVuZGVkIChqdWRnaW5nIGZyb20gYSBjb21tZW50IHRoZXJlKSwg
YnV0IHRoZSBmdXJ0aGVyDQo+Pj4gZGlmZmVyZW5jZSB0byB3aGF0IHlvdSBhZGQgaXNuJ3Qgb2J2
aW91cy4NCj4+DQo+PiBPa2F5LCBJIHdpbGwgbWFrZSB0aGF0IGV4cGxpY2l0Lg0KPj4NCj4+PiBX
aGljaCByYWlzZXMgYW5vdGhlciB0aG91Z2h0OiBJZiB0aGF0IGh5cGVydmlzb3IgbGVhZiB3YXMg
cGFydCBvZiB0aGUNCj4+PiBIVk0gZmVhdHVyZSBzZXQsIHRoZSB0b29sIHN0YWNrIGNvdWxkIGJl
IGFibGUgdG8gb2J0YWluIHRoZSB3YW50ZWQNCj4+PiBpbmZvcm1hdGlvbiB3aXRob3V0IGFsdGVy
aW5nIHN5c2N0bCAoYXNzdW1pbmcgdGhlIGNvbmRpdGlvbnMgdG8gc2V0DQo+Pj4gdGhlIHJlc3Bl
Y3RpdmUgYml0cyB3ZXJlIHRoZSBzYW1lKS4gQW5kIEkgd291bGQgdmlldyBpdCBhcyBnZW5lcmFs
bHkNCj4+PiByZWFzb25hYmxlIGZvciB0aGVyZSB0byBiZSBhIHdheSBmb3IgdG9vbCBzdGFja3Mg
dG8ga25vdyB3aGF0DQo+Pj4gaHlwZXJ2aXNvciBsZWF2ZXMgZ3Vlc3RzIGFyZSBnb2luZyB0byBn
ZXQgdG8gc2VlIChhdCB0aGUgbWF4aW11bSBhbmQNCj4+PiBieSBkZWZhdWx0KS4NCj4+DQo+PiBM
aWtlIHRoZSAiY3B1aWQiIHh0ZiB0ZXN0IGFsbG93cyB1cyB0bz8NCj4gDQo+IEkgZG9uJ3QgdGhp
bmsgSSB1bmRlcnN0YW5kIHRoZSBxdWVzdGlvbi4gVGhhdCB4dGYgdGVzdCBpcyBjb25jZXJuZWQN
Cj4gYWJvdXQgY2hlY2tpbmcgdGhlIENQVUlEIG91dHB1dCBpdCBnZXRzIHRvIHNlZSBpdHNlbGYu
IEl0IGRvZXNuJ3QgY2FyZQ0KPiBhYm91dCB3aGF0IG90aGVyIGd1ZXN0cyBtaWdodCBnZXQgdG8g
c2VlLCBub3IgdGhlIG1heGltdW0gYW5kIGRlZmF1bHQuDQo+IA0KPj4gTWFrZXMgc2Vuc2UgdG8g
bWUuIEknbSBoYXBweSB0byB0YWtlIHRoYXQgdXAgYWZ0ZXIuDQo+IA0KPiAiQWZ0ZXIiIHdoYXQ/
DQpTbyBJIG1lYW50IHRvIHNheSB0aGF0IEkgY291bGQgYWRkIHRoZSBYZW4gQ1BVSUQgbGVhdmVz
ICg0MDAwMHguLi4pIHRvIA0KdGhlIHBvbGljeSBzbyB0aGF0IHRvb2xzdGFja3MgY291bGQga25v
dyB3aGF0IGh5cGVydmlzb3IgbGVhdmVzIGd1ZXN0cyANCmFyZSBnb2luZyB0byBzZWUgLSBpbiBh
IGZ1dHVyZSBwYXRjaCwgYXMgdGhpcyB3b3VsZG4ndCBqdXN0IGV4cG9zZSANClhFTl9IVk1fQ1BV
SURfQVBJQ19BQ0NFU1NfVklSVCBhbmQgWEVOX0hWTV9DUFVJRF9YMkFQSUNfVklSVCANCigweDQw
MDAweDA0KSBidXQgb3RoZXIgZmVhdHVyZXMgdG9vLg0KDQpCdXQsIGF0IHRoZSBzYW1lIHRpbWUs
IHcuci50LiB0aGlzIHBhdGNoIGluIHBhcnRpY3VsYXIsIHVzaW5nIA0KWEVOX0hWTV9DUFVJRF9B
UElDX0FDQ0VTU19WSVJUIGFuZCBYRU5fSFZNX0NQVUlEX1gyQVBJQ19WSVJUIHRvIGRldGVjdCAN
CmFzc2lzdGVkIEFQSUMgZ2l2ZXMgdXMgbGVzcyBmbGV4aWJpbGl0eSB0byBhZGQgbW9yZSBmaW5l
IGdyYWluZWQgDQpjb250cm9scyBpbiB0aGUgZnV0dXJlLg0KDQpUaGFua3MsDQoNCkphbmUu


From xen-devel-bounces@lists.xenproject.org Mon Feb 28 12:12:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 12:12:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280482.478425 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOesv-0002M5-LZ; Mon, 28 Feb 2022 12:12:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280482.478425; Mon, 28 Feb 2022 12:12:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOesv-0002Ly-IB; Mon, 28 Feb 2022 12:12:13 +0000
Received: by outflank-mailman (input) for mailman id 280482;
 Mon, 28 Feb 2022 12:12:12 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=EMlY=TL=citrix.com=prvs=051191599=Jane.Malalane@srs-se1.protection.inumbo.net>)
 id 1nOesu-0002Ls-Cm
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 12:12:12 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a6993fc1-988f-11ec-8539-5f4723681683;
 Mon, 28 Feb 2022 13:12:10 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a6993fc1-988f-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1646050330;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=BoN8B1+cDkPXX9B0BoNFj3nAifW7TvSeiefJpZxzqc8=;
  b=VXRU4L2gvlHA3Q2sznwY9+maS7sTL8Nrbvrd0IwP4UjwMmAcq4TXM3te
   JOVMJTuehdnht+rN9ZQF3EXmxthzrEqT+59vch7ETGmmnSpeCRyH2jfGP
   tD6M2ijxPftwhwVQdbswe9Pi/MlSg/Z59oJXU/f8T32n0Qdqt06fiJ92/
   A=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 64557514
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:UneF6Kn9EdmDPfQlRy0OVc/o5gwwJkRdPkR7XQ2eYbSJt1+Wr1Gzt
 xJKW2GEPf6NZjShfNp3ao3lpx4EupSDnIQ2GQE4pSk8QiMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EoLd9IR2NYy24DjWVzV4
 7senuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR
 v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ
 NtxWZOYbxcbH7CWpr0hUjZzHyRXZ6haxOHDGC3q2SCT5xWun3rExvxvCAc9PJEC+/YxCmZLn
 RAaAGlTNFbZ3bvwme/lDLk37iggBJCD0Ic3mHhmwHf8BPIvRZnFTo3B5MNC3Sd2jcdLdRrbT
 5RFNGcwMU2cC/FJEmgzK7R5scCPv3W8aCxGgUinu/Rr7meGmWSd15CyaYGIK7RmX/59lEuCu
 njP+Wi/BxgALcGe0hKM6HfqjejK9QvFX4YVGKy95+RdqlSZzWwOCzUbTVK+5/K+jyaWWc9Zb
 Uod+SMsrK073E2tUtT5GRa/pRasrhMaHtZdDeA+wAWM0bbPpRaUAHAeSTxMY8Bgs9U5LRQp2
 0GImZX1BDVpmLyTVX+ZsLyTqFuaJiw9PWIEIygeQmMt4dPuvYUyhRLnVct4Hei+ididMTP/2
 TeRtwAlmq4ey8UM0s2T5kvbijihopzISA8d5QjNWG+hqARja+aNZZGs6FXdxeZNKsCeVFbpg
 ZQfs5HAtqZUV8jLzXHTBrVWdF202xqbGBvMs39yRad4yzWC0HKmVNpV/A0gIH48Z67oZgTVS
 EPUvApQ4rpaM32rcbJ7buqNNig68UTzPY+7D66JN7KidrA0LVbap382OSZ8ykiwyBBErE0pB
 XuMnS9A514+AL8v8je5Tvx1PVQDlnFnnjO7qXwWIn2aPVuiiJy9FO1t3LimNLlRAEa4TOP9q
 Ys32yyikUg3bQEGSnOLmbP/1HhTRZTBObj4qtZMasmIKRd8FWcqBpf5mO19Jt01wP0MyrmQr
 hlRv3O0LnKl2BUrzi3QNxhehE7HB84j/RrXwwR2VbpX55TTSdn2t/pOH3fGVbIm6PZi3ZZJo
 wotIK297gB0Ym2foVw1NMClxKQ7LUjDrV/ebkKNPWlkF7Y9FlOhxzMRVla2nMX4JnHs7pVWT
 nzJ/l6zfKfvsCw5VJeGMK/0lgjp1ZXf8corN3b1zhBoUByE2KBhKjDrj+9xJMcJKB7ZwSCd2
 RrQChAdzdQhaadlmDUVrchod7uULtY=
IronPort-HdrOrdr: A9a23:SU8YuakqeJutfaBqSa6TWWbM9qTpDfOBimdD5ihNYBxZY6Wkfp
 +V88jzhCWZtN9OYhwdcIi7SdS9qXO1z+8R3WGIVY3SEzUOy1HYUL2KirGSjQEIeheOutK1sJ
 0PT0EQMqyIMbEXt7eY3OD8Kadb/DDlytHouQ699QYUcegCUcgJhG0ZajpzUHcGPzWubaBJT6
 Z0jfA3wwZIDE5nCPhTcUN1ONQryee79q7OUFojPVoK+QOOhTSn5PrRCB6DxCoTVDtJ3PML7X
 XFuxaR3NTij9iLjjvnk0PD5ZVfn9XsjvFZAtaXt8QTIjLwzi61eYVaXaGYtjxdmpDt1L9qqq
 iPn/4TBbU215rjRBDznfIr4Xin7N8a0Q6m9bZfuwq7nSW2fkNjNyMLv/MnTvKQ0TtfgDg76t
 MQ44vRjesnMTrQ2Cv6/NTGTBdsiw69pmcji/caizhFXZIZc6I5l/1VwKr7KuZ0IMvW0vFvLA
 BVNrCV2B+WSyLvU1nJ+m10hNC8VHU6GRmLBkAEp8yOyjBT2HR01VERysATlmoJsMtVcegI28
 3UdqBz0L1eRM4faqxwQO8HXMusE2TIBRbBKnibL1jrHLwOf3jNt5n06rMo4/zCQu1D8LIi3J
 DaFF9Iv287fEzjTcWIwZ1Q6xjIBH6wWDz8o/sukaSReoeMM4YDHRfzO2zGyfHQ08n3KverKc
 qOBA==
X-IronPort-AV: E=Sophos;i="5.90,142,1643691600"; 
   d="scan'208";a="64557514"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=RZy92LsyLFyneych8UrTzw6IdgEVsiu22FuoUM7BcL6afPdAPXU3tN5wru7DH1cNRM2Ao1d0k11pEBkQ4Kcu1lLtU5+dfxisH/LN3KMaPtDlsqs8tvoE3NN7HLVnIHreHSKYfUQqHjd0EIrpFZaFE8ObCavccAq3SW2g70mCFZVqPRtTzXIWZLiVwY7OS0h06O4TXXXLgA82XfjkBsA1cwQ7esbo9LgYg/CiDYGT7edxVf35+2H+oh3066rDOsItJNlFlR8RRjvrW6PdcOKT+7zMwAlD19UXcXCRt6//2HbAkpuEo0HDmHzqQjhXiwTQF//dptklWEU7P5NuUNQayw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=BoN8B1+cDkPXX9B0BoNFj3nAifW7TvSeiefJpZxzqc8=;
 b=EjWnu2PT05DMYzDJp4x0o09cKzVFcEu7j03Q5aE23ykMoRHqQG20v8O+IOOL4X0AQtkn/Kel6LHlyAvvGmYA4BSK2lH3VgpnLIaUXrZ5igAMoGroT7rtVWG+qfoJbNtZ0nCZPl8rt0xVWHj8PlWnW7McMg/khV4SDFeoNaMxiWJ9xY8CAVvIwY8h/X0VL6xqCjD9d+vH2bAP1riKF+9pw0ZItAaf67mcaBR/qWfUcF+cWW8Es8sRFBznR7RyjrIpGtS00oQEn8FjeRScdQmgfyElagblugkyV1CpfjmL87yTWRUUTXdXfw7CBE1GMXgvovOUiqQxqDMgKvlzUGhl9Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=BoN8B1+cDkPXX9B0BoNFj3nAifW7TvSeiefJpZxzqc8=;
 b=V33RfkifVzlaGPpcztpzmvBO4/WBqGnsWgRjSbgIQtpGNUA6nis6YxQYsf1P7TvC8k/VTgW3l1aFM626arTNr6nviAK40OsZbeo7TTrKdIuGTe8z+R2H2D6nHwWkG9JmWKKnMzTrR/pdhXChzR4MjCWB/PzNyAar5SC/mpZLmVs=
From: Jane Malalane <Jane.Malalane@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Wei Liu <wl@xen.org>, Anthony Perard <anthony.perard@citrix.com>, "Juergen
 Gross" <jgross@suse.com>, Andrew Cooper <Andrew.Cooper3@citrix.com>, "George
 Dunlap" <George.Dunlap@citrix.com>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>,
	Jun Nakajima <jun.nakajima@intel.com>, Kevin Tian <kevin.tian@intel.com>,
	Roger Pau Monne <roger.pau@citrix.com>, Xen-devel
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v3 1/2] xen+tools: Report Interrupt Controller
 Virtualization capabilities on x86
Thread-Topic: [PATCH v3 1/2] xen+tools: Report Interrupt Controller
 Virtualization capabilities on x86
Thread-Index: AQHYJO06JWynylsFtkyl8WR8WaDosKyixjKAgAGyPACABChhAIAATiCA
Date: Mon, 28 Feb 2022 12:12:05 +0000
Message-ID: <b1d6a6c6-9a57-e4e2-1c8c-448d6f8af9bf@citrix.com>
References: <20220218172943.12182-1-jane.malalane@citrix.com>
 <20220218172943.12182-2-jane.malalane@citrix.com>
 <0a31970c-c0f8-c995-ce04-67523a4a830a@suse.com>
 <22ae35a0-9df8-9357-4b44-2f00586144fc@citrix.com>
 <de431523-ad71-1cb6-a28d-07418886ee23@suse.com>
In-Reply-To: <de431523-ad71-1cb6-a28d-07418886ee23@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: bf254698-8e23-445b-9a6d-08d9fab3891b
x-ms-traffictypediagnostic: CY4PR03MB2647:EE_
x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
x-microsoft-antispam-prvs: <CY4PR03MB26476C0D47735D730D9D9AE181019@CY4PR03MB2647.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: uNA4cyzZM3Mgg7YRRPKyW4xiqHWQ8shMLoTYun0DuenesPH5bQHnRe+m/K2RAQbyKjnxVmm4OzUUn5/kXVtAB2nfcOnLNvykK6nsUEHPVHzMwfa7ONIi7RmGyWphGjrbe2hkONl1cUuYq4nTkBqMqt/BjoOSwio0AZEVZoES7ii/Cp959EKiaQeefT+cHLNbaqneiz3EfKaKDcnLCdlkAZS9D38iWAJ1cCOkEvPS1h7PN73rvFXP9ERVlF4mrj8k8pGOdUrx3+GzcUMBaXJM/AIMKhhXi2uxlrfBzq7Op78pDULclalwCTL8llDsmqKeSJyjA5ZfQDkoY9h+TrQzXbryUsHtpocpKc69Ui3B4wWaPEjN/P9f7J/k0ajNi540Xswj4Th6SitmLN94McHs9J4VKwetMSn+lG48GTFhLGOOz/ePFWOftYwtAug2KpHceFdyBsg7S7oBTouA2GNgX5l3V7k0iPyLDnR+qC779T1MyQ3LThpq2XbNa+Khpxw9Ju67rQI08dz7s2jao3YlYz4znmskynlDqxI3cBtbN3lOrGud62nJr+AmmJyo/Nc3wKyVH4m27zzxKxh121sVkCCSdDP/PJowemHRBTi7WZk/WYP/hdJo+rGL2SK0TFXVSuwmBj+1W7OQ4aNq9D4KzTSHTxnxHv86K6aLMbaSyeBWnOnezYqsB2aIDbhh7vp7XSwvy7Ta1HcwZQNvlRZqEijj4+0iEAgRY7Rv/iyH/skStN+/3q5ipyeVNYEfBiv/
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR03MB3386.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(82960400001)(6486002)(53546011)(36756003)(38100700002)(6506007)(55236004)(31686004)(71200400001)(83380400001)(508600001)(122000001)(54906003)(6916009)(8936002)(2616005)(316002)(6512007)(86362001)(31696002)(7416002)(5660300002)(38070700005)(26005)(186003)(8676002)(64756008)(66446008)(66476007)(66556008)(76116006)(66946007)(2906002)(91956017)(4326008)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?N3owV05xRERocTN5UzF1ZE4wL2JVRnlsMTVnbDBoOThmbFk1TXlRbFZZditM?=
 =?utf-8?B?UTZReW81Z1l3V3pwOVBYL2x3NTE3RzNCY0I1R043QW5aZEkrVitoMGVza29H?=
 =?utf-8?B?amloeFg1NG1tVzY3SFNCRG5pTm5oTExMdVRYYURaN1FoUnVHckQzRVBGbFpP?=
 =?utf-8?B?ZFdUNUhBSTV4di9Mbkxwc3EvQ1duNnA0NmpqT2JSQjZUR2hiTnBSMmpzTDZN?=
 =?utf-8?B?TytHSW4zZGwzeGw3b2FMTnJmM05tMjYxWmVvYlV3NmZ2KzFSc0VqK2pMZ1NG?=
 =?utf-8?B?OTR6NGh4K0tRN241dHpRT3ZLQkZ1ZnllM0lNN2RmZU0xUGRKYmpldjlXcXRp?=
 =?utf-8?B?M2NRS2xRNEtJaE5ydzNPVE1oWldZZWZ2a1ZHWHlKQ3dYQ1FMeVcrT3FXQ215?=
 =?utf-8?B?MnZRY0NIMjRQL1dja1RmcU5QMWNXcElSb0k5cENRc0tKTC82OWo5ai9oU1ZM?=
 =?utf-8?B?QTV3aHJQRWJLa2hlNEZSTldPdCsvREtoODF5ZjN5OWFkWUZmSlV5U0ZDUWlD?=
 =?utf-8?B?YnFuTjZuL092ZjRuRFg0aFhIb2FHY3NIdEgzZEV1NndYdlBNUXRlRUhYTjJn?=
 =?utf-8?B?cVBhWWtYdGNBYXNoV3Z4Y2xhcHhhR3d2aTBpY0JFMUxoN0cwamlUN3N5bzFk?=
 =?utf-8?B?NEY2SGFYN1AvUlVpL2FqbzN0N2lIK3FqTzh0MmorMC8vamkyZTVnOHBkQ2Uw?=
 =?utf-8?B?b1JtQlp1c0ZteGhwbk9lZVZJWlFRRGFXNlZxZG51QWlNVXBYNGJoNjIyL2JM?=
 =?utf-8?B?dzZkRGNITTREM2dMWDBrRVdSRVBGVVVkS2swSFlPNFRhcDJKRzVBeXVEdkYz?=
 =?utf-8?B?RFlGVVBRdlFpTE0zR2ZGa2FIbHFpdUJ6S2JHb0ZXc3FmVkFEVVJBRkVBL3hq?=
 =?utf-8?B?VDFaRk9yVmlJVE9iN2dlOFpmWGRpWUhidjJTU0FBbW5MWTVZSFJ4QUZTZ1ZY?=
 =?utf-8?B?NXV2U3AyUGxMWU5tUWl6aUgwV3hya3lZZWZFcjd5WTUwMlN4NW16VjlDK3hH?=
 =?utf-8?B?bGpiSnNHTUNiTTZjU2hvSG5aQjRDK2JFeVpINXNhYXpNd3IwNDNZOVlxNGxO?=
 =?utf-8?B?eXdBQnh4WnVER2NqYnV4ZTMyS3ZsMjZvZXBoVld1ZTdIQldIUTJJb29xWFp6?=
 =?utf-8?B?L0tBR1JkSjFnQzlTMk10dWlIKzl1LzJKV01kczgzYUozVFEwRjAzeHl4Yzl2?=
 =?utf-8?B?bGRFKzNKMWJ3WmZXMW16eStrZDRXU3dDV3JzTFNwNSthYlE0U0t5Q3pYUmhV?=
 =?utf-8?B?dHlDTzhrcEJoQkN3azRzUC91NDJXbDRycHJlaG1nSkhqdHdEQzBydzN2d2tm?=
 =?utf-8?B?ZEVNclZZS01vSWh5aGxBWFBvQklZZzdLLzFlNXJ2MysrZUFFUDMyOHRIWnBR?=
 =?utf-8?B?TWNSVTZoaVAzUjlrbTgvR2lGQmJjek5wNG1ITjJXTnZOSldyZVVrUzRqazFC?=
 =?utf-8?B?Mklyay9VNkFlVVcybEZCUCtSQVEwWTNDNUVMT1ZCUUtjSy9tY3VYWDR6dEJ6?=
 =?utf-8?B?S25lNGdMTW5Cb1RYTkpxVUIrR1VKTUhFUk92VkV3VlF5OHVLbDFyaGRmNEZ2?=
 =?utf-8?B?OWt3aU1JTjkvQVR1dFRSV0o0a3pDTTRHSkVMeUQ1akxETVFLVFJyR0hVOGJT?=
 =?utf-8?B?dlNycVg5WHZyRk50dzMzWDRpU1BZMG9xbE4zY0tNb2pNd3FrdG03WlRtUkF4?=
 =?utf-8?B?YWRZaWRISFVkT2VRTm9lVXQxVGRhUk5Hb3cxT3lUeEtlMzBmajFNbXZidnZT?=
 =?utf-8?B?cTJ1cTd4d2tZK2RYT3pVelFrWEdnZGg0RHJlK05YM0Q3MTE5bitQKzlDakhx?=
 =?utf-8?B?Ym40VTJRcDZ4YktXTHZZL3kyVjhyTWM1RURkd3dXVzZSOEhTblZiRGJJamZl?=
 =?utf-8?B?WnpsVVNtblZTcUJJRUNsSkltREwzZGpLZSs5dkhwdTRNZ3JJR0NZeUk0OUJS?=
 =?utf-8?B?UURIdHl3VUozdW9nWUY2SnZvd1ZyTzl5ZmVGWGpzYjJneWxHaXZ0ZVpwdG0x?=
 =?utf-8?B?UDVDeFc5Y2VxSjllVTJieHFleHNCNHQ3Qk9BNU5EM0I1WGZWVnloSmZQdm5C?=
 =?utf-8?B?bkc5L2NSOU5OMWhIdlNGekNSaEdiZ0tFWFJzbHBKK1RLTmtaYTFOd29yUDlh?=
 =?utf-8?B?VFVEN0V5SEludyt1TzNCQjg0elRLS0Jrdnp5eWFjblZXbTVDN3NHRUJSbVUr?=
 =?utf-8?B?bU1Ja3dRQmFtVEhLSHluMXlMK0xrM0Qzb3FwdnFwOHhsN2pVWW04WmxiRUUw?=
 =?utf-8?Q?22jBzh0yfqXoS5yJtWkKxnJTuGwt0pw61WFmGAxDy8=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <A96C57A830C5FD4BB8F5DB7FC1B80F9D@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM5PR03MB3386.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bf254698-8e23-445b-9a6d-08d9fab3891b
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Feb 2022 12:12:05.4451
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: yCT1nlDlndrOGZCaBmLsPXW9CM/AqSFiys8QxzPqUsxZN2qcseRiSQ9osW/M/SPp2F3LC6ZskvUMAUBzY7V99NwI8ai+VNVAxuB/AIZUDT4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR03MB2647
X-OriginatorOrg: citrix.com

T24gMjgvMDIvMjAyMiAwNzozMiwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IFtDQVVUSU9OIC0gRVhU
RVJOQUwgRU1BSUxdIERPIE5PVCByZXBseSwgY2xpY2sgbGlua3MsIG9yIG9wZW4gYXR0YWNobWVu
dHMgdW5sZXNzIHlvdSBoYXZlIHZlcmlmaWVkIHRoZSBzZW5kZXIgYW5kIGtub3cgdGhlIGNvbnRl
bnQgaXMgc2FmZS4NCj4gDQo+IE9uIDI1LjAyLjIwMjIgMTc6MDIsIEphbmUgTWFsYWxhbmUgd3Jv
dGU6DQo+PiBPbiAyNC8wMi8yMDIyIDE0OjA4LCBKYW4gQmV1bGljaCB3cm90ZToNCj4+PiBPbiAx
OC4wMi4yMDIyIDE4OjI5LCBKYW5lIE1hbGFsYW5lIHdyb3RlOg0KPj4+PiBBZGQgWEVOX1NZU0NU
TF9QSFlTQ0FQX0FSQ0hfQVNTSVNURURfeGFwaWMgYW5kDQo+Pj4+IFhFTl9TWVNDVExfUEhZU0NB
UF9BUkNIX0FTU0lTVEVEX3gyYXBpYyB0byByZXBvcnQgYWNjZWxlcmF0ZWQgeGFwaWMNCj4+Pj4g
YW5kIHgyYXBpYywgb24geDg2IGhhcmR3YXJlLg0KPj4+PiBObyBzdWNoIGZlYXR1cmVzIGFyZSBj
dXJyZW50bHkgaW1wbGVtZW50ZWQgb24gQU1EIGhhcmR3YXJlLg0KPj4+Pg0KPj4+PiBGb3IgdGhh
dCBwdXJwb3NlLCBhbHNvIGFkZCBhbiBhcmNoLXNwZWNpZmljICJjYXBhYmlsaXRpZXMiIHBhcmFt
ZXRlcg0KPj4+PiB0byBzdHJ1Y3QgeGVuX3N5c2N0bF9waHlzaW5mby4NCj4+Pj4NCj4+Pj4gU3Vn
Z2VzdGVkLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPg0KPj4+
PiBTaWduZWQtb2ZmLWJ5OiBKYW5lIE1hbGFsYW5lIDxqYW5lLm1hbGFsYW5lQGNpdHJpeC5jb20+
DQo+Pj4+IC0tLQ0KPj4+PiB2MzoNCj4+Pj4gICAgKiBEZWZpbmUgWEVOX1NZU0NUTF9QSFlTQ0FQ
X0FSQ0hfTUFYIGZvciBBQkkgY2hlY2tpbmcgYW5kIGFjdHVhbGx5DQo+Pj4+ICAgICAgc2V0IGFy
Y2hfY2FwYmlsaXRpZXMsIHZpYSBhIGNhbGwgdG8gY19iaXRtYXBfdG9fb2NhbWxfbGlzdCgpDQo+
Pj4+ICAgICogSGF2ZSBhc3Npc3RlZF94MmFwaWNfYXZhaWxhYmxlIG9ubHkgZGVwZW5kIG9uDQo+
Pj4+ICAgICAgY3B1X2hhc192bXhfdmlydHVhbGl6ZV94MmFwaWNfbW9kZQ0KPj4+DQo+Pj4gSSB1
bmRlcnN0YW5kIHRoaXMgd2FzIHRoZSByZXN1bHQgZnJvbSBwcmV2aW91cyBkaXNjdXNzaW9uLCBi
dXQgdGhpcw0KPj4+IG5lZWRzIGp1c3RpZnlpbmcgaW4gdGhlIGRlc2NyaXB0aW9uLiBOb3QgdGhl
IGxlYXN0IGJlY2F1c2UgaXQgZGlmZmVycw0KPj4+IGZyb20gd2hlbiBYRU5fSFZNX0NQVUlEX1gy
QVBJQ19WSVJUIHdvdWxkIGJlIHNldCBhcyB3ZWxsIGFzIGZyb20gd2hhdA0KPj4+IHZteF92bGFw
aWNfbXNyX2NoYW5nZWQoKSBkb2VzLiBUaGUgZGlmZmVyZW5jZSBiZXR3ZWVuIHRob3NlIHR3byBp
cw0KPj4+IHByb2JhYmx5IGludGVuZGVkIChqdWRnaW5nIGZyb20gYSBjb21tZW50IHRoZXJlKSwg
YnV0IHRoZSBmdXJ0aGVyDQo+Pj4gZGlmZmVyZW5jZSB0byB3aGF0IHlvdSBhZGQgaXNuJ3Qgb2J2
aW91cy4NCj4+DQo+PiBPa2F5LCBJIHdpbGwgbWFrZSB0aGF0IGV4cGxpY2l0Lg0KPj4NCj4+PiBX
aGljaCByYWlzZXMgYW5vdGhlciB0aG91Z2h0OiBJZiB0aGF0IGh5cGVydmlzb3IgbGVhZiB3YXMg
cGFydCBvZiB0aGUNCj4+PiBIVk0gZmVhdHVyZSBzZXQsIHRoZSB0b29sIHN0YWNrIGNvdWxkIGJl
IGFibGUgdG8gb2J0YWluIHRoZSB3YW50ZWQNCj4+PiBpbmZvcm1hdGlvbiB3aXRob3V0IGFsdGVy
aW5nIHN5c2N0bCAoYXNzdW1pbmcgdGhlIGNvbmRpdGlvbnMgdG8gc2V0DQo+Pj4gdGhlIHJlc3Bl
Y3RpdmUgYml0cyB3ZXJlIHRoZSBzYW1lKS4gQW5kIEkgd291bGQgdmlldyBpdCBhcyBnZW5lcmFs
bHkNCj4+PiByZWFzb25hYmxlIGZvciB0aGVyZSB0byBiZSBhIHdheSBmb3IgdG9vbCBzdGFja3Mg
dG8ga25vdyB3aGF0DQo+Pj4gaHlwZXJ2aXNvciBsZWF2ZXMgZ3Vlc3RzIGFyZSBnb2luZyB0byBn
ZXQgdG8gc2VlIChhdCB0aGUgbWF4aW11bSBhbmQNCj4+PiBieSBkZWZhdWx0KS4NCj4+DQo+PiBM
aWtlIHRoZSAiY3B1aWQiIHh0ZiB0ZXN0IGFsbG93cyB1cyB0bz8NCj4gDQo+IEkgZG9uJ3QgdGhp
bmsgSSB1bmRlcnN0YW5kIHRoZSBxdWVzdGlvbi4gVGhhdCB4dGYgdGVzdCBpcyBjb25jZXJuZWQN
Cj4gYWJvdXQgY2hlY2tpbmcgdGhlIENQVUlEIG91dHB1dCBpdCBnZXRzIHRvIHNlZSBpdHNlbGYu
IEl0IGRvZXNuJ3QgY2FyZQ0KPiBhYm91dCB3aGF0IG90aGVyIGd1ZXN0cyBtaWdodCBnZXQgdG8g
c2VlLCBub3IgdGhlIG1heGltdW0gYW5kIGRlZmF1bHQuDQo+IA0KPj4gTWFrZXMgc2Vuc2UgdG8g
bWUuIEknbSBoYXBweSB0byB0YWtlIHRoYXQgdXAgYWZ0ZXIuDQo+IA0KPiAiQWZ0ZXIiIHdoYXQ/
DQpTbyBJIG1lYW50IHRvIHNheSB0aGF0IEkgY291bGQgYWRkIHRoZSBYZW4gQ1BVSUQgbGVhdmVz
ICg0MDAwMHguLi4pIHRvIA0KdGhlIHBvbGljeSBzbyB0aGF0IHRvb2xzdGFja3MgY291bGQga25v
dyB3aGF0IGh5cGVydmlzb3IgbGVhdmVzIGd1ZXN0cyANCmFyZSBnb2luZyB0byBzZWUgLSBpbiBh
IGZ1dHVyZSBwYXRjaCwgYXMgdGhpcyB3b3VsZG4ndCBqdXN0IGV4cG9zZSANClhFTl9IVk1fQ1BV
SURfQVBJQ19BQ0NFU1NfVklSVCBhbmQgWEVOX0hWTV9DUFVJRF9YMkFQSUNfVklSVCANCigweDQw
MDAweDA0KSBidXQgb3RoZXIgZmVhdHVyZXMgdG9vLg0KDQpCdXQsIGF0IHRoZSBzYW1lIHRpbWUs
IHcuci50LiB0aGlzIHBhdGNoIGluIHBhcnRpY3VsYXIsIHVzaW5nIA0KWEVOX0hWTV9DUFVJRF9B
UElDX0FDQ0VTU19WSVJUIGFuZCBYRU5fSFZNX0NQVUlEX1gyQVBJQ19WSVJUIHRvIGRldGVjdCAN
CmFzc2lzdGVkIEFQSUMgZ2l2ZXMgdXMgbGVzcyBmbGV4aWJpbGl0eSB0byBhZGQgbW9yZSBmaW5l
IGdyYWluZWQgDQpjb250cm9scyBpbiB0aGUgZnV0dXJlLg0KDQpUaGFua3MsDQoNCkphbmUu


From xen-devel-bounces@lists.xenproject.org Mon Feb 28 12:24:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 12:24:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280491.478436 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOf4d-0003zs-U1; Mon, 28 Feb 2022 12:24:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280491.478436; Mon, 28 Feb 2022 12:24:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOf4d-0003zl-Qs; Mon, 28 Feb 2022 12:24:19 +0000
Received: by outflank-mailman (input) for mailman id 280491;
 Mon, 28 Feb 2022 12:24:18 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+aRg=TL=arm.com=Rahul.Singh@srs-se1.protection.inumbo.net>)
 id 1nOf4c-0003zf-4B
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 12:24:18 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04on0631.outbound.protection.outlook.com
 [2a01:111:f400:fe0d::631])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 57fca620-9891-11ec-8eba-a37418f5ba1a;
 Mon, 28 Feb 2022 13:24:16 +0100 (CET)
Received: from AS8PR04CA0149.eurprd04.prod.outlook.com (2603:10a6:20b:127::34)
 by AM9PR08MB7168.eurprd08.prod.outlook.com (2603:10a6:20b:3de::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.21; Mon, 28 Feb
 2022 12:24:13 +0000
Received: from AM5EUR03FT007.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:127:cafe::28) by AS8PR04CA0149.outlook.office365.com
 (2603:10a6:20b:127::34) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.25 via Frontend
 Transport; Mon, 28 Feb 2022 12:24:13 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT007.mail.protection.outlook.com (10.152.16.145) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5017.22 via Frontend Transport; Mon, 28 Feb 2022 12:24:13 +0000
Received: ("Tessian outbound 741ca6c82739:v113");
 Mon, 28 Feb 2022 12:24:13 +0000
Received: from eeee43340899.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 D2F6062D-3CF1-469D-BC6B-062ED4F6AF9E.1; 
 Mon, 28 Feb 2022 12:24:02 +0000
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id eeee43340899.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 28 Feb 2022 12:24:02 +0000
Received: from AM5PR0801MB2020.eurprd08.prod.outlook.com
 (2603:10a6:203:4c::14) by AM7PR08MB5335.eurprd08.prod.outlook.com
 (2603:10a6:20b:101::16) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.24; Mon, 28 Feb
 2022 12:24:00 +0000
Received: from AM5PR0801MB2020.eurprd08.prod.outlook.com
 ([fe80::253a:4d6c:61c9:af60]) by AM5PR0801MB2020.eurprd08.prod.outlook.com
 ([fe80::253a:4d6c:61c9:af60%10]) with mapi id 15.20.5017.026; Mon, 28 Feb
 2022 12:23:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 57fca620-9891-11ec-8eba-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=j6n9352ehEXwn+lvoYM1eerHSAe4r5q+VxS07xN90xU=;
 b=MTXIGynY0oed0feumJ9Kt/NQ+WCLGuKX1kCTHcZ4GYhSebxoNvOlNVNRpoEecJVZGxbAOzQtjJ9X68nzUfIOUix6ceCOvfNseFMpDiv1hixGQ8QLR9Xx9/m//EzGMehA2ZsHpKzT6COqNtSSr5BO4wpV4YwNMvA84RrsQFwn6+Y=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: c8062bceb6f2b1d6
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=X5EkRqJtHnTWF+Krep/Kea9/H5xJ57PgmstkE+NFj1jQVWSpgE37CdOjMgmFGJW5lwkd46hb1fE9zgIicyVdTf6zTCHf6MO3dWa2EZKv7f+YuphDMc6KoK7FhRVkF5UOwjIymt5ghmRnfrxUqReLbnQ4Ldh+d67T2+K7ktooAZVTPG49w99iQOdGf8eRUPds/eyWqqCTCv87bKnBqJYHdYr8p2D4WOg5lLWwrpTk6u14oCe6qlsPGWZzSFJQvZCSvG78OZGyjifc2zASTQB7vMWAvhCLq6uILf2sg3A+gRttGjo0iHk/8KMxXTmqCKW6u3mME7J4LfGqP+bNZjCqwQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=j6n9352ehEXwn+lvoYM1eerHSAe4r5q+VxS07xN90xU=;
 b=m9NYQFGwWYO6UnB9xchp1IEW6EzsbUmvdWXQdvBkrxRkzNCk/h5jqBMysy7EvfXRBlXcgIUakxiZHBIbxAuPdXSdIWmpmTHq1NXsuTBuRLKg5JJjtz2kPHpAzwFtMol9T0lopaJoUYvDXGevnhsmYXsoulcYzaFqbf56hejASiOlZDqXYBB8bZdc20LS/YAyB4ThmnNz5xbXDY2bpP8XbMdKqhu4juEc3yzIBnetgt2YgoEpzagryYz5/jHJI8OZTyyacgMt8WbsNthixREiPJ43J1EC7PmtPxKAzyeL9e6FCEK2XojQJWQ8JaIG+tqDcizNUwM2S6aX7e3LZCM22A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=j6n9352ehEXwn+lvoYM1eerHSAe4r5q+VxS07xN90xU=;
 b=MTXIGynY0oed0feumJ9Kt/NQ+WCLGuKX1kCTHcZ4GYhSebxoNvOlNVNRpoEecJVZGxbAOzQtjJ9X68nzUfIOUix6ceCOvfNseFMpDiv1hixGQ8QLR9Xx9/m//EzGMehA2ZsHpKzT6COqNtSSr5BO4wpV4YwNMvA84RrsQFwn6+Y=
From: Rahul Singh <Rahul.Singh@arm.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: xen-devel <xen-devel@lists.xenproject.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Jan Beulich <jbeulich@suse.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v2 3/3] xen/vpci: msix: move read/write call to MSI-X PBA
 entry to arch file
Thread-Topic: [PATCH v2 3/3] xen/vpci: msix: move read/write call to MSI-X PBA
 entry to arch file
Thread-Index: AQHYIoCRIEW4rFyZskGyHhvFMB0R0ayj/BWAgAT7AwA=
Date: Mon, 28 Feb 2022 12:23:54 +0000
Message-ID: <CB924115-A4F7-4052-90D1-A9C5A63AAA60@arm.com>
References: <cover.1644937405.git.rahul.singh@arm.com>
 <3e47316052dce3c85bde04ab6b72ba4f48fa0bb8.1644937405.git.rahul.singh@arm.com>
 <YhiRS11TlQjuefHR@Air-de-Roger>
In-Reply-To: <YhiRS11TlQjuefHR@Air-de-Roger>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 84c828c0-ca72-45fe-fc4a-08d9fab53afd
x-ms-traffictypediagnostic:
	AM7PR08MB5335:EE_|AM5EUR03FT007:EE_|AM9PR08MB7168:EE_
X-Microsoft-Antispam-PRVS:
	<AM9PR08MB716835D171B71A9720B82888FC019@AM9PR08MB7168.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 WploVoJ5b8BOtK0c3G+S+Rgzb1ptcN5sz/z1eqT0n3gpjkhxFmxT+mtOwT25maFwdCuerw3oKeee2ok8HNN/73vesaYNcKkjCVS8dbxHftb7wpgvAxEqyeFHJUlJGKHMwuQf9MBy7RycDM8j2jxkt3sWPFRC34nwrHuDkXgPD6Nbm10ujoy3IIqnJk+f+K8WbOA1hdCb8Yw6HuMaCGDqxJkmzN/7bpbkkzGXjnBZXETwa2yo2Ks3shiTeue6O2zX3ELSjoMlAFuJ+FJH6GW8mE8D51H14WDt31Bl43oaP2+3JdRRUWt2FCjSft3TcmoBagGipr5Eash3fWkoaj0iPn3dfOupOac5aqPMqVawpekBzcDmFwXgPODKPmQ2VkuzhySZvNBwrtIhGy98DpF3+RDY+hw6Odx7uiVCbfoPv6B8hdL6Nzb2o+IMcNqJyyNHTIr+B4hfIoBkUPQnJdvKrAsaQ1gPdJ2pKC9D0eCnZTPNBG9PR0IkGlc6QGoeLN2gfqulM6f2dgrZ2GApemqWDAFAH028blzUOj8GQ0/O2b5fftDXxLZSm4K9M3VPMIuHrdCzntvTQIqINLR435mbDkGU3zi/YY0U6ugaELDL4UsqmQR58yJVFqWeaw1ZyKqyJ73QGL97TVy9ZWslCrebyGql1kTlH1v2V1S+s3Jatgw/09OQKu6f7XQjfPG0OODDgJalbna5BHIyPz2xYUIQOhlF5o6dbBghD9i8hsIbUGN26aY2A6cowV7Z0RSPGmE8
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM5PR0801MB2020.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(186003)(33656002)(76116006)(66946007)(316002)(508600001)(66476007)(6916009)(66556008)(54906003)(91956017)(6506007)(122000001)(8936002)(83380400001)(66446008)(26005)(71200400001)(64756008)(5660300002)(36756003)(2616005)(6486002)(6512007)(86362001)(8676002)(2906002)(53546011)(38100700002)(4326008)(38070700005)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <9E2326BAD72E0E44B58ADDF988066320@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5335
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT007.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	0b46e63c-30e2-401e-7938-08d9fab52fe5
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	8yJ5wNaNlORzBBUAliYsueBJI1GB/XlC0M2BSLTT42yauFYUdVLQp0nZ/ERNT3g481eGn6gW1nYnUMYGE5bh8Ez2y+45YUaFTUkM5CtkmtXTyBsWZBkK9wF/jQcHWErN/GGvjnynqGw47jbZPeL3DFSJKau7di9esi97+i/mvWikygaKiLCvca73dt66VOlZ2SLBBmlrOOu9w1YcqqnMWbpktDyJUmx7qd2sRsk6VOMpa18+5EuB9fqKburIJS3CpRttC1kWMQ6/giFlglOEFYPkcXFssIYwAW6Oghdx32/NircQKuLQB6iZWde3H7Vuq68c3OTiRaNM2w56B4r/EM3eyUc6oEl7Hc+ZLFtRWiuVnUR32Y8Dh5DTOLMt4ynaMpgii86cqKDCAUA3Db5zv3sQQkHVwRGtZcVLUphATBpJmPpxMLnqf+rpd6AK72yyNWQlrhbnSPOxDqGYfU9hoEXxvvCdX6siERkqbWCaYNcthWnmBnakQ9j4Z3SnRtEmrLCWwVkdLxTuQWRujuxEJVDHajNzcjDaw5fcAjMJWOUZnmN1aVQ69VhV3j5C6A6GEb7xanMC8tmBLnSTICx20EExrjYaFxDT2ahU+QdP3V6B1pAiWjwefZTo1vhpv4JwwfdmPQFYoxaqUkYumVUKNmvv8WZ5yy0YF7Ly3VIEtsZn9Zc4OkJLsikguVlkusA6
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(36860700001)(40460700003)(36756003)(82310400004)(356005)(81166007)(33656002)(336012)(186003)(26005)(86362001)(2616005)(54906003)(316002)(4326008)(6862004)(70586007)(70206006)(6506007)(6512007)(53546011)(8676002)(6486002)(508600001)(47076005)(2906002)(8936002)(5660300002)(83380400001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2022 12:24:13.4759
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 84c828c0-ca72-45fe-fc4a-08d9fab53afd
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT007.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB7168

SGkgUm9nZXIsDQoNCj4gT24gMjUgRmViIDIwMjIsIGF0IDg6MjAgYW0sIFJvZ2VyIFBhdSBNb25u
w6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPiB3cm90ZToNCj4gDQo+IE9uIFR1ZSwgRmViIDE1LCAy
MDIyIGF0IDAzOjI1OjE4UE0gKzAwMDAsIFJhaHVsIFNpbmdoIHdyb3RlOg0KPj4ge3JlYWQsd3Jp
dGV9e2wscX0gZnVuY3Rpb24gYXJndW1lbnQgaXMgZGlmZmVyZW50IGZvciBBUk0gYW5kIHg4Ni4N
Cj4+IEFSTSB7cmVhZCx3cmllfShsLHF9IGZ1bmN0aW9uIGFyZ3VtZW50IGlzIHBvaW50ZXIgd2hl
cmVhcyBYODYNCj4+IHtyZWFkLHdyaWV9KGwscX0gZnVuY3Rpb24gYXJndW1lbnQgaXMgYWRkcmVz
cyBpdHNlbGYuDQo+PiANCj4+IHtyZWFkLHdyaXRlfXtsLHF9IGlzIG9ubHkgdXNlZCBpbiBjb21t
b24gZmlsZSB0byBhY2Nlc3MgdGhlIE1TSS1YIFBCQQ0KPj4gc3RydWN0dXJlLiBUbyBhdm9pZCBp
bXBhY3Rpbmcgb3RoZXIgeDg2IGNvZGUgYW5kIHRvIG1ha2UgdGhlIGNvZGUgY29tbW9uDQo+PiBt
b3ZlIHRoZSByZWFkL3dyaXRlIGNhbGwgdG8gTVNJLVggUEJBIHRvIGFyY2ggc3BlY2lmaWMgZmls
ZS4NCj4gDQo+IEkgdGhpbmsgd2UgYWdyZWVkIHdoZXJlIGdvaW5nIHRvIHVuaWZ5IHtyZWFkLHdy
aXRlfXtsLHF9IHNvIHRoZXkgY291bGQNCj4gYmUgdXNlZCBpbiBhcmNoLWFnbm9zdGljIGNvZGU/
DQoNCldlIGFncmVlZCB0byBtb2RpZnkgdGhlIHZQQ0kgTVNJeCBjb2RlIHRvIHVzZSBhIHBvaW50
ZXIsIGJ1dCB0aGF0IG5vdCANCmhlbHBlZCBtZSB0byBtYWtlIGNvZGUgYXJjaC1hZ25vc3RpYy4g
SSBkZWNpZGVkIHRvIG1vdmUgdGhlIFBCQSBoYW5kbGluZyBjb2RlIHRvIGFuIA0KYXJjaC1zcGVj
aWZpYyBmaWxlIHRvIG1ha2UgdGhlIGNvZGUgdXNhYmxlLg0KDQpUaGFua3MgZm9yIHRoZSBzZXJp
ZXMgICJ2cGNpL21zaXg6IGZpeCBQQkEgYWNjZXNlc+KAnSBzZXJpZXMgdGhhdCB3aWxsIGhlbHAg
dG8gdXNlIHRoZSANCmNvZGUgZm9yIEFSTSBhcmNoIGFsc28gd2l0aG91dCBhbnkgbW9kaWZpY2F0
aW9uIHRvIHtyZWFkLHdyaXRlfXtsLHF9IC4NCg0KUmVnYXJkcywNClJhaHVsDQo+IA0KPiBUaGFu
a3MsIFJvZ2VyLg0KPiANCg0K


From xen-devel-bounces@lists.xenproject.org Mon Feb 28 12:33:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 12:33:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280498.478446 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOfDi-0005Vr-PZ; Mon, 28 Feb 2022 12:33:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280498.478446; Mon, 28 Feb 2022 12:33:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOfDi-0005Vk-Mf; Mon, 28 Feb 2022 12:33:42 +0000
Received: by outflank-mailman (input) for mailman id 280498;
 Mon, 28 Feb 2022 12:33:42 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=py4b=TL=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1nOfDi-0005Ve-Ca
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 12:33:42 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id a8ee2a16-9892-11ec-8eba-a37418f5ba1a;
 Mon, 28 Feb 2022 13:33:41 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7048D106F;
 Mon, 28 Feb 2022 04:33:40 -0800 (PST)
Received: from [10.57.19.230] (unknown [10.57.19.230])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 02D523F73D;
 Mon, 28 Feb 2022 04:33:38 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a8ee2a16-9892-11ec-8eba-a37418f5ba1a
Subject: Re: [PATCH] xen/arm32: head: Mark the end of subroutines with ENDPROC
 (take two)
To: Julien Grall <julien@xen.org>, xen-devel@lists.xenproject.org
Cc: Julien Grall <jgrall@amazon.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20220228100740.60332-1-julien@xen.org>
From: Michal Orzel <michal.orzel@arm.com>
Message-ID: <ab9157d3-db7c-3eee-7145-fc2479779576@arm.com>
Date: Mon, 28 Feb 2022 13:33:32 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20220228100740.60332-1-julien@xen.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

Hi Julien,

On 28.02.2022 11:07, Julien Grall wrote:
> From: Julien Grall <jgrall@amazon.com>
> 
> Commit 2ac705a59ef5 ("xen/arm32: head: Mark the end of subroutines
> with ENDPROC") intended to mark all the subroutines with ENDPROC.
> 
> Unfortunately, I missed fail(), switch_ttbr(), init_uart() and
> __lookup_processor_type(). Add ENDPROC for the benefits of
> static analysis tools and the reader.
> 
> Signed-off-by: Julien Grall <jgrall@amazon.com>
> ---

I checked and it seems like you covered them all now.

Reviewed-by: Michal Orzel <michal.orzel@arm.com>

Cheers,
Michal


From xen-devel-bounces@lists.xenproject.org Mon Feb 28 12:52:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 12:52:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280505.478458 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOfVV-0007x4-Bo; Mon, 28 Feb 2022 12:52:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280505.478458; Mon, 28 Feb 2022 12:52:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOfVV-0007wx-8g; Mon, 28 Feb 2022 12:52:05 +0000
Received: by outflank-mailman (input) for mailman id 280505;
 Mon, 28 Feb 2022 12:52:04 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=py4b=TL=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1nOfVU-0007wr-22
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 12:52:04 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 384bae3a-9895-11ec-8539-5f4723681683;
 Mon, 28 Feb 2022 13:52:00 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A6F511042;
 Mon, 28 Feb 2022 04:52:01 -0800 (PST)
Received: from [10.57.19.230] (unknown [10.57.19.230])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 69B823F73D;
 Mon, 28 Feb 2022 04:52:00 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 384bae3a-9895-11ec-8539-5f4723681683
Subject: Re: [PATCH] xen/arm64: head: Mark the end of subroutines with ENDPROC
 (take two)
To: Julien Grall <julien@xen.org>, xen-devel@lists.xenproject.org
Cc: Julien Grall <jgrall@amazon.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20220228100805.60918-1-julien@xen.org>
From: Michal Orzel <michal.orzel@arm.com>
Message-ID: <3ba92d6d-07c4-f035-83a9-01175c4000d2@arm.com>
Date: Mon, 28 Feb 2022 13:51:58 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20220228100805.60918-1-julien@xen.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

Hi Julien,

On 28.02.2022 11:08, Julien Grall wrote:
> From: Julien Grall <jgrall@amazon.com>
> 
> Commit 13c03002c5df ("xen/arm64: head: Mark the end of subroutines
> with ENDPROC") intended to mark all the subroutines with ENDPROC.
> 
> Unfortunately, I missed fail(), switch_ttbr() and init_uart(). Add
> ENDPROC for the benefits of static analysis tools and the reader.
> 
> Signed-off-by: Julien Grall <jgrall@amazon.com>
> ---

Reviewed-by: Michal Orzel <michal.orzel@arm.com>

Cheers,
Michal


From xen-devel-bounces@lists.xenproject.org Mon Feb 28 12:58:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 12:58:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280512.478469 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOfbp-0000FB-2H; Mon, 28 Feb 2022 12:58:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280512.478469; Mon, 28 Feb 2022 12:58:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOfbo-0000F4-VR; Mon, 28 Feb 2022 12:58:36 +0000
Received: by outflank-mailman (input) for mailman id 280512;
 Mon, 28 Feb 2022 12:58:35 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=A4HT=TL=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nOfbn-0000Ey-BH
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 12:58:35 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 22d7c7f7-9896-11ec-8eba-a37418f5ba1a;
 Mon, 28 Feb 2022 13:58:34 +0100 (CET)
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2050.outbound.protection.outlook.com [104.47.2.50]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-11-6Wd69oKDMayBQGKWkHkJXA-1; Mon, 28 Feb 2022 13:58:32 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DBBPR04MB6090.eurprd04.prod.outlook.com (2603:10a6:10:c4::22) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.26; Mon, 28 Feb
 2022 12:58:31 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.026; Mon, 28 Feb 2022
 12:58:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 22d7c7f7-9896-11ec-8eba-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1646053113;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=YoSZ/LGH2JLPAvVg1wsK8TIky8uV/2hj0t3L4LzJP6w=;
	b=jEyjwBES2CCYGZhUUIpC/Yt0gpVJpbYjla946bhzSAPOaKj44Z9OqLduYfF+W5vFJn/+7t
	J/pAvAqg1C6/FbpR5RK1rQZ3Z3xx5hWdkclQhKX9Ou2sk6izsquI8PPZD3mv5pSDF9rbFN
	brUDMMqkymS0CwI9FuOVCtd9VZiEpq8=
X-MC-Unique: 6Wd69oKDMayBQGKWkHkJXA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Gp8tM92x7Ec8qwuepvCKYG1V8U/sTol+sdlPw5ez+TPLwUopxzfAf/1xSYx8CWMtj2SXImYzXC9/wO7aOP40sW4GYU70lWF9Pe3OjDlU5o9s1oOE8cIwgThDVKM+4J8D91j+dXDKMkQh1fIWpYeyo+KE29tZAmow1mhcGH24XU95vlFoYepWPNnQDJjX+eOaqasIRyy28cIk2Fc3v7/J4A0FDnAtzRu1LZ8LUkw6r7MhqOyn9KJ5MbQWHNTCZwpJkNBBbNoFGxHfIYMBov+rfyCn2oOO4vGpCY/WlrR0EhNaIL93waAU4wz8ii6E26bLRZSCet6PumS12FNItczn8A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=YoSZ/LGH2JLPAvVg1wsK8TIky8uV/2hj0t3L4LzJP6w=;
 b=dkzQ2Y3ZKORcHdTEykctl1DEydecc+cm47dKzlwp9Cd1lioO4R8hrFHQDvIPTww9JsWL3rt0fLxZVwABJ02vCjZ1akSmtKfBfZldEkaYddQDEUJTRNrSr3HKU2CoEsUUB25J4GZeS4kV8WDOB3bqTjOPK0K/a00glV1Fr5AdvWJeqia4sOyNXsfvLuPjR+hvxr1vNc0QyQoNdxm+xX+kuEl/9Zfxk1RhYWT7+dCOR9FPn9zkjKesBo44DKTJivj3GMPfPZGjIK0iE8ZD0laqInBzeqX4ne3RaxtNhJnvUZmF7beXLqfCIjyNSaSRR+DX8fiIFliPZueW6+dT6RfH6Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <c87b3d0a-3cd2-1fa3-e920-4b6f0c23fbaf@suse.com>
Date: Mon, 28 Feb 2022 13:58:28 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v3 06/70] x86: Introduce support for CET-IBT
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20220222152645.8844-1-andrew.cooper3@citrix.com>
 <20220222152645.8844-5-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220222152645.8844-5-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8P251CA0021.EURP251.PROD.OUTLOOK.COM
 (2603:10a6:20b:2f2::18) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 13fff092-54a7-405c-18f6-08d9faba0523
X-MS-TrafficTypeDiagnostic: DBBPR04MB6090:EE_
X-Microsoft-Antispam-PRVS:
	<DBBPR04MB6090AC7253B95D5C3312C95CB3019@DBBPR04MB6090.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	46ai7EsFgxkUgYnHDFh1lS/6LRB0f3iaZBGABQRoEX15va1lXK8g8OUDmNnXGV3XJ6+c3skbQ474tAnGOE8gxnLywwzx+D/LpGs57dosTjYq2xfJR0HHGaVfU96cmnkh0TwsYdf1aY1hm4GjSPLHDk7TvoUr/ngNGwwsM0Na+IeBOYG8Uen1sj9NKPzxXzub93qllVU52aVT6dQ+SPAH1dgGbizIAaXTZkptVt7hKLRXBCDlLj/494agi/I3WP6CuG41irbJlyh54v71LabM/Yq6OenwJ4pmzLykZ4Am+nPBDtupubF+uBa54olSTvmE9DSYpPB39uPI50nbCdc+/qaSPVg86Tu3iDRtW99qQed+0ea7Unp8Zuejt3g4ysCzNdkonLwKpdUzT5g8Y4kZTRKU0t+yEmTS4urXxJTcBB1YkadriGN/4bYHiw4UQcCdQHKeqK1yvmdb/GXIgXkGY5o+sPmQKF6MMEvJjSGa4gIaWQ4tZYl5/ouiyJziUXjiCvBgwR10Ba5bsLwGiYDOMgIeM+a5nO/zCyVGd60fznXuYHWJZFQKWtTfaXgW01ijwzBv0188y9pyJjE0e9aoQ5tpxOhPiwhrzx3l/qkEvtslYNTQUiAH1Ikkian+3uYjFMP6+B3xK7l1AjE5jizm/WCEDYeA01lTWi+RKoMTRRVD3CuP6p3lw3Ibfg7uZ2gFlAdF3LquDLRRxnlwwPsJzb/zXehN+jr6u33mYgLks2xw4shsx47HWm+PYp2m5rie6IUQuTIQF1MDSQrCNZnIJTCkXQpvk2p7Jag3/mnUI79lHXOCMaAaFYwKMRqSPGyf
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(31686004)(4744005)(66556008)(8936002)(5660300002)(66476007)(8676002)(66946007)(4326008)(6486002)(316002)(36756003)(2906002)(966005)(54906003)(6916009)(508600001)(186003)(26005)(6666004)(53546011)(6506007)(2616005)(83380400001)(31696002)(6512007)(38100700002)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VVlNdUhvdHhSSmlIN3hmKzdvSjJIdG15MlpXSGlkaFdTMTVIVTlCR0N3ZXpE?=
 =?utf-8?B?N204T0g3eS80cEFDOHF5MkxkQ3JCZUJ5QmdsaDBTL0JpdlZ3dUZRd0ZvajBz?=
 =?utf-8?B?SG9tVldWYVQ0N3YyWndhUzBoV0Q1S3Q4SzJpdVVBc3kyV3c1T3BpYkQ3enYy?=
 =?utf-8?B?V29CL2lRNmJieUE4bUIyUjdNRzEzVUQ4aVBrZ2VKeFFvWEV5NHQrZ05PWStE?=
 =?utf-8?B?alhRTkkxM3lzQ1NBQmpWMXV5Q0w0VzZhM256aCs4WnAxeTcyUFk0Rms5VUtv?=
 =?utf-8?B?WTNFZzA4VnMrbHNBK1o1RzY0MkdWc1l5bSsvRmptclJSZ0RZcjF2V0s0a2pY?=
 =?utf-8?B?ZWFmZHJUQnRUa2xuR0NZLytEKy84SjJlaWF2WVRPVUJrcnh5clB3ekQ3ckZj?=
 =?utf-8?B?bktXTlFPT2ZiTHBxT0l2TGxoZ1AzTnc3a0JibnUrSERhd0ZodVo4bjBHYUFx?=
 =?utf-8?B?Ujc1S0o3QWJVQTdWVTRjUlF2dWhHR0tTSUJuRENCRDM5RG14UlowOUpNRzdR?=
 =?utf-8?B?T3BVZGJxMnFLbDlwL1pHSHZmSmFFRXRDUWJTNXpaK2w1YWtLUkJ3VHZTWW5V?=
 =?utf-8?B?eFNsOTgrUERocWRzVzNHS01STG1PWGlpVjAvejlRKzV3RFZuejdwdk9PVEF5?=
 =?utf-8?B?MEJScXd0SllHTzlNNC9POFBOT1llLzF6SVV5TWJKc2U5czA4aTVkU2cwWUc0?=
 =?utf-8?B?b3lKRXZjSXRCRmM2MlZQNnRMK3lTUUxwbkhFYmlpMmxKY3BZODlMbHB1RFpj?=
 =?utf-8?B?NXgwcHhpczdyNC91VWovWTdOTExlYnNUaUdZMXRVMjdXZWdvMExtYVhQTU1n?=
 =?utf-8?B?c3NGOTRyVnROcE5MRWxadTVDNkp3SlZKajhoclBRT0JrU2E5djdva056V0dE?=
 =?utf-8?B?QnY0dXlGT2lSZlNLczlobWV1b0l0S0JxWGJTa1l3MDRseTlod0tVMkcyM2RN?=
 =?utf-8?B?RVpYUlFYaC9YYzlLNGNub1laUzdiNW9ieU0wV0tpUm9WZnVjSG04ak5haWRL?=
 =?utf-8?B?VXQ0Z0IxbGVTY1AyQ0oxU09NWTFOOXM2aXRJQ1VDdW5zeTY5cThoWmswZVRa?=
 =?utf-8?B?Y2NpMWIySmVzL1Z6Q09UWHVBTkRLVnhuS3Ixbk5oNGZaUjNwYmZvR3V3V3ow?=
 =?utf-8?B?V3FXUWY3Tlo1Q3UrV05weHdPZDhnZCt2aFh3VXk4OXkwKzFqbkRDZFRHc1Vw?=
 =?utf-8?B?N25LeW04TlFoTUdFMmNMZWo0YWU1UXBCczVjS1czeWdzU1NBc2o2Vkd1NWRo?=
 =?utf-8?B?aUUvc05YbWdMODg0ZnBoRTd3cDVkU3RIaWY1RnA3a0VCNTdWdUNBWE5BcHRO?=
 =?utf-8?B?RTBBSlh5aHJleFNhL05OK292N3I0bGhDNFJhaHJSU3ZxK01yMXhyQlFyWXZm?=
 =?utf-8?B?UHVjcUwvRHVPMmNDd2tTN2RhcVF3RFRGcUNWbloyVml2dFlVbjBNeXUxRWVQ?=
 =?utf-8?B?L2ZYOXQ4UEdwOERnZUFIL0RlMFRmZ28zenFhVnlGaTE1Wnphc1FPUVhpL3Vu?=
 =?utf-8?B?UlBTNVoyRmZOUXVsS0pNWStSalkwMHRMZnN4Uit2RUh3L25TY0x2b00xUzl6?=
 =?utf-8?B?aWZ6aVpPR3QraHd4Tlg2L1duMGsvK0RiRXEvUUFzakFSWEFVWnNtSnFCTnRN?=
 =?utf-8?B?aElvNzJ0M2FjM3VSelBuNHE5aHFIZDB3RTlvVW9EV1ByL3F2bElraVIxNWRE?=
 =?utf-8?B?Q21sZXA2aWMwUVFwdlUwM1BtSGFtTnFyVXZkQm1PTXpFRDVpNnp1NU5Fem1z?=
 =?utf-8?B?U2xwT3AvdU9sY2VnVXpIcHJYTENmZTdSQTZnbzdQQzRFT3lod1BzRnRCUCt0?=
 =?utf-8?B?QmdKOHFtWEtqVUVLNXZGYzA0ZHlzblZjbUZ5ODFRUis1RXlxWUdRSXp3SVZi?=
 =?utf-8?B?R1VaR1pzK3lDQzFPRFdpRTRQZFZzQS9nTTBZNzF6Z2U5Q25aT3M1RW5wcmxp?=
 =?utf-8?B?T0IyaTNDMmxMR2tyaUU5UUZ2ZVkxNkFHS1AvNzY4ek5iYlAzSThEUCtKbU1T?=
 =?utf-8?B?S3JhamdtR09UMWlBazV2aklMRUcyWTFEbU9hREZsR0lGaE5kdG11R3oxMHVl?=
 =?utf-8?B?RkhucHJ1K1Fyam9SZWhVaTRDVVNHSEhxUWFCNUhsNDJaYk9zUFdxMUE1aThR?=
 =?utf-8?B?N2xjcDBEVU9yV0JrYnFDSEFDOUdJbktOQ2xjazNsUWVTWnV0WU5kQ2x4bXd0?=
 =?utf-8?Q?aDynsG+gwuyDQyS9/ba895M=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 13fff092-54a7-405c-18f6-08d9faba0523
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2022 12:58:31.0120
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zxvejg8t1ESkJGqCPQOae0+p9a8ip6qHycjb5QaixI40zdeTVuInGkQnnKEZ0/XxtlX0c6BglelcQ/12KsvmAA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB6090

On 22.02.2022 16:26, Andrew Cooper wrote:
> --- a/xen/arch/x86/Kconfig
> +++ b/xen/arch/x86/Kconfig
> @@ -40,6 +40,11 @@ config HAS_AS_CET_SS
>  	# binutils >= 2.29 or LLVM >= 6
>  	def_bool $(as-instr,wrssq %rax$(comma)0;setssbsy)
>  
> +config HAS_CC_CET_IBT
> +	# GCC >= 9 and binutils >= 2.29
> +	# Retpoline check to work around https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93654
> +	def_bool $(cc-option,-fcf-protection=branch -mmanual-endbr -mindirect-branch=thunk-extern) && $(as-instr,endbr64)

Noticed only now: Since the commit message doesn't say anything either
way, was it intentional for this to differ from XEN_SHSTK in the EXPERT
dependency?

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 28 13:04:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 13:04:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280519.478480 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOfhV-0001gB-OA; Mon, 28 Feb 2022 13:04:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280519.478480; Mon, 28 Feb 2022 13:04:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOfhV-0001g4-KU; Mon, 28 Feb 2022 13:04:29 +0000
Received: by outflank-mailman (input) for mailman id 280519;
 Mon, 28 Feb 2022 13:04:28 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=py4b=TL=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1nOfhU-0001fy-BX
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 13:04:28 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id f505851d-9896-11ec-8eba-a37418f5ba1a;
 Mon, 28 Feb 2022 14:04:26 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 086801042;
 Mon, 28 Feb 2022 05:04:26 -0800 (PST)
Received: from [10.57.19.230] (unknown [10.57.19.230])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8DB893F73D;
 Mon, 28 Feb 2022 05:04:24 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f505851d-9896-11ec-8eba-a37418f5ba1a
Subject: Re: [PATCH] xen/arm32: head: Update the documentation for register
 r12
To: Julien Grall <julien@xen.org>, xen-devel@lists.xenproject.org
Cc: Julien Grall <jgrall@amazon.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20220228101150.63816-1-julien@xen.org>
From: Michal Orzel <michal.orzel@arm.com>
Message-ID: <e9397250-3d68-d6e6-d95f-93d239fc2ef5@arm.com>
Date: Mon, 28 Feb 2022 14:04:18 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20220228101150.63816-1-julien@xen.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

Hi Julien,

On 28.02.2022 11:11, Julien Grall wrote:
> From: Julien Grall <jgrall@amazon.com>
> 
> Since commit 54c4ae18d158 ("xen/arm32: head: Rework and document
> launch()"), the boot code is not using the register r12.
> 
> So update the documentation to show r12 has no specific purpose.
> 
> Signed-off-by: Julien Grall <jgrall@amazon.com>
> ---
>  xen/arch/arm/arm32/head.S | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/xen/arch/arm/arm32/head.S b/xen/arch/arm/arm32/head.S
> index 13cfc837d39c..78274a1c034f 100644
> --- a/xen/arch/arm/arm32/head.S
> +++ b/xen/arch/arm/arm32/head.S
> @@ -79,7 +79,7 @@
>   *   r9  - paddr(start)
>   *   r10 - phys offset
>   *   r11 - UART address
> - *   r12 - is_secondary_cpu
> + *   r12 -
>   *   r13 - SP
>   *   r14 - LR
>   *   r15 - PC
> 

FWICS, there are still 2 instructions in this file assigning #0 or #1 to r12 and each of them
has a comment "/* r12 := is_secondary_cpu */". 

So I have 2 questions:
1. Do we even need these instructions? (I do not think so)
2. If we need these instructions, do we need these comments?

Cheers,
Michal


From xen-devel-bounces@lists.xenproject.org Mon Feb 28 13:07:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 13:07:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280528.478491 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOfkV-0002RV-9Z; Mon, 28 Feb 2022 13:07:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280528.478491; Mon, 28 Feb 2022 13:07:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOfkV-0002RO-5j; Mon, 28 Feb 2022 13:07:35 +0000
Received: by outflank-mailman (input) for mailman id 280528;
 Mon, 28 Feb 2022 13:07:34 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=A4HT=TL=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nOfkU-0002RI-BM
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 13:07:34 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 64348c96-9897-11ec-8eba-a37418f5ba1a;
 Mon, 28 Feb 2022 14:07:33 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2175.outbound.protection.outlook.com [104.47.17.175]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-14-ULg0KHdnMqGTER4OVB4Ppw-2; Mon, 28 Feb 2022 14:07:31 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM6PR0402MB3943.eurprd04.prod.outlook.com (2603:10a6:209:16::28)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.23; Mon, 28 Feb
 2022 13:07:27 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.026; Mon, 28 Feb 2022
 13:07:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 64348c96-9897-11ec-8eba-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1646053652;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=u0sBbVarfRdbPd8mf0FQyjjqMuEG/CN9bdsDecxtUQE=;
	b=frDZqOxyI7Rz44Eo5v01rLnq+bvclnC4fPoOo+D7YrPPNOncPNdO8vJOwPGElx5UE6Or7d
	QVgw0s49vO+Fy2CEbvPySY85rMi7Wv8wc0NupbhjsQ9QvBd+/WKPqUtQjDdjedouOn3D9v
	U6fiMthZydONHhU7v5mw5jfw5TYzS70=
X-MC-Unique: ULg0KHdnMqGTER4OVB4Ppw-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jEJTS2YImhOS363GhQ6GCC/31Zn4o0We5hTmPAs2LmIY3whI5CfaNz2zm9lNv75a+0cjCi2XnGuMG/xiYqQ/Vjkl49PKjgeSKflxmCJMIzMGmchO3ljr2lu+ms24Mx3yyRrMWxzQsSR4qtVboUl6R1YMuw/0zLJcWwELc+49CWFc3aozO+vOD7j9YRg2xobVM0lcR4ZIXn+B7kKLoB4ZWLAqxcTxcMH3nKcjtoucDmeXS6n/yPeVwozDSINLcbg+4vbeDXkSbdmbbeyCH3CFDN0cb0YpTp+IfVFdp9gJzu3qznIsSdpIFltK1l69JTgVRSCUlwBRDNJMgnPu6nQqvQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=u0sBbVarfRdbPd8mf0FQyjjqMuEG/CN9bdsDecxtUQE=;
 b=GBQXZO5eXpOKLu4fLpFAbvEDBAQv+5welM3mpDsVOSvOHRkLZYUW4W4I8HJIlWVMquIpJ2Bxc095g+HavpSgFRrZRrg9506cFhU7rq98jRb/EVEXohSaM33taNoYlEEJEVnsT2ghggInsQSiZSc+ycfmHvxFg8BIxWEiX2WuRvvGlZ276cLnGOKBBfKexbOtPtBMJRQ3Q04QFA9eUFWhJAqUzRvkmM3zt+WxJj/RFxyKkUrmwQHIM207aQnl370Pi8wyDHJybn3PYCE490L2nmYH6cp2x6mxn2bVDjdrBYQ0E3t6xlug28tQOttGWG9neWo/IgBSD8N9q6kTCppEcw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <1b302f7e-01a8-eb00-f801-2f4cbfbef959@suse.com>
Date: Mon, 28 Feb 2022 14:07:24 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v3 1/2] xen+tools: Report Interrupt Controller
 Virtualization capabilities on x86
Content-Language: en-US
To: Jane Malalane <Jane.Malalane@citrix.com>
Cc: Wei Liu <wl@xen.org>, Anthony Perard <anthony.perard@citrix.com>,
 Juergen Gross <jgross@suse.com>, Andrew Cooper <Andrew.Cooper3@citrix.com>,
 George Dunlap <George.Dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Jun Nakajima <jun.nakajima@intel.com>, Kevin Tian <kevin.tian@intel.com>,
 Roger Pau Monne <roger.pau@citrix.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20220218172943.12182-1-jane.malalane@citrix.com>
 <20220218172943.12182-2-jane.malalane@citrix.com>
 <0a31970c-c0f8-c995-ce04-67523a4a830a@suse.com>
 <22ae35a0-9df8-9357-4b44-2f00586144fc@citrix.com>
 <de431523-ad71-1cb6-a28d-07418886ee23@suse.com>
 <b594fe28-6b47-d697-a038-b1a9ee903288@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <b594fe28-6b47-d697-a038-b1a9ee903288@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0202CA0004.eurprd02.prod.outlook.com
 (2603:10a6:203:69::14) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2eb8538b-1d5d-41f4-f3b8-08d9fabb452c
X-MS-TrafficTypeDiagnostic: AM6PR0402MB3943:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<AM6PR0402MB39439335ADDB6AD436B0CBC8B3019@AM6PR0402MB3943.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	tbiFE5QF/4QLRK5P6vrKY6YQ92ucv7nkUFrJZ9W7ZDqiO3NTq6X9+i2OYKqOULeAxLfkgA3jFEmF8GmTenN3uyY1C5857Qiw8OecyuciLbvcWONLTWoUgOZvB4DSWBCaSkekr95mR7YPf6lGClSnd5hPZFFixJIjk7zNONYv5H5ESnD0/t/EG60we0f4W2yK9ORU7c/GUaWLMQ4cE4wWN8LgCF/P/rtsEd3nQxQ/RPVIFkY7mP9VDMPG1KG74O0K7g5MgQ01xJT6PCr20qcDZWG/13q2sZ3aDBrUE0gKUClIBndtf6kP8swYHCusdytx33yxBPfzk7FNZpCPEks269clgz2M+dytecQiWUYGnTqi703uSu9X3tDE2xs6lCugqleZrNNHlXo5bMiIHk2Y7++1dsGyzhDVBCoEINv4mMLcAOWgEuid9JEHGb2DAauHqkwEE87iZiIIngEF4MmC2fbvQh4uUtkEjlT53DYsDH0jJyEHVf+wHW+BhFTgWG8+SUxH6p4LA44JWiAKSX/QCg0lfSMeU/XCBxCfI5Qa2IWlPvXBAzupuMJ0ooG4hlvKYv6y865/g3bhtYa22Ccgk/HhW6K0j2BFffK3JMTiUXVXHtUlpGFrU8U/CAxoqSKUn08RV318nzYxnNVYq8IiTc/Pt3pGq4RBEXpdDiT1oxw+FvFILGuphIJYj7I5T23ugCsmeWisVtyAys9wqbjS3YMey+2oxZKolrBJU3tFE8tSK627CpM/THwZRAD/r3zq
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6916009)(54906003)(316002)(38100700002)(508600001)(6486002)(36756003)(53546011)(6506007)(2616005)(2906002)(31686004)(26005)(186003)(31696002)(86362001)(8676002)(4326008)(6666004)(66476007)(5660300002)(7416002)(66556008)(66946007)(6512007)(83380400001)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Z1p3UjVNNFhQOWJQc2hTRTVDVnhVNjZ2dXJLWkJoMGFsN2NKVHExOWV4MFp2?=
 =?utf-8?B?MWhyZTZ6WVQ0TFBVaTk0bzRtVWcxdkVIMFpQZ2dPU2Q1OHdYTVIrVW9tRi9X?=
 =?utf-8?B?L0RteFZMOFpQTk1PZmZsMmVVc0pOVFByM3V5WkN4ajh1b3AyTm5ibUZGVDJ6?=
 =?utf-8?B?aXZCZk1YeGZic1k2cThwSE5kVVRJVW50SUJKNjRUZXBQR204Umk3Y1dVb3pE?=
 =?utf-8?B?UWtGMUgrUGxNaVk3V2p3VmplL2pIZE0ydDVRTllmam13WDgyMWhUVVQ0ZXhu?=
 =?utf-8?B?bk5Ec1BScXBXMmZhMEhGY1FGaHNvNUtLcXE4aXVLNStCb1VnN2Y2UXRNMEtj?=
 =?utf-8?B?R21QOTNnVWZ5MU1pMHRxWWVmUkVDYWVlYlJvRTlyREpYbFpOYmxHTFBtQzd6?=
 =?utf-8?B?M0JxWFg4RzZmQVZlNFRZbHhpRXMvM1dYR2NFejFObkxZMkhPYzhmS2JtdGIv?=
 =?utf-8?B?MFpiNy9VNWFzS1R2OGVqUlNqOWE3MUJFRVBwODZCMmpWZDd6bUhBdDRpdXha?=
 =?utf-8?B?WHNidkNjYkxKbjJJamJPS3RTZkdENzdod3E5NW5SaCtHamtFai9ueUczZGc5?=
 =?utf-8?B?dXJkYzJTbXgwdUtUTHBNcXpZNTdWbTEvSEtLZGpkRklaNVBRek9zajE2RFpr?=
 =?utf-8?B?eWRxSTIwMmN0WUkzN2xIQlFmUGE1OUk2WDJ6VUFlR1kzYW9VbHRvaTVISTlV?=
 =?utf-8?B?K1ExV2ZaWldDMzFPcGdsbi92QUlPTXJOVVBkbUF0N2pGdnJxa1gzemVRazNR?=
 =?utf-8?B?YWN4QVdCc1B3WEN1K2lFazArY0E1VWVyMGo2NGJqZGJGN0lWQXFVSWRzVGUw?=
 =?utf-8?B?UXZCaHZqRmM4dlR6cEhGYVN3UndPMFVkbXJDTG9ld3E0M0hMdTQydHc4M0Fx?=
 =?utf-8?B?MEwrRzhGNkM5Yzl5a0RPcjZFT1F5ZWVsOGlsM01hWWFJL0w4UDRWVGdKMkZP?=
 =?utf-8?B?NmNscjFweUduYmJEQmhLMUxSYTdLUUkzZVIzcFhvaGxDZmJGY1NxWkJUZE8x?=
 =?utf-8?B?MkRCeHdyR1ZCY0Zsa1oxeUtvYldrWUZYR0Npcm9lL1ZXVjZOazNuMDRNd2hJ?=
 =?utf-8?B?RFhlM2JxbjlUcUtleHFGYU11L1dTSTBvSmRzelJjU1pqV0Nva3Bua1ZDWUt2?=
 =?utf-8?B?S1lYVzZCZGJYQ1g5V0RkRnlJR3Rac1crZFNUL0hFUWtCVUZzejArT2VTSXZB?=
 =?utf-8?B?OVJHSTdKdnhZWko2YnRKZ0xTZkxLQWwya3JRalI1ekZRR1JaMExHOGJjYkJK?=
 =?utf-8?B?aG1QVXJwczRoRENJMzk4bkJyUmcxaHc5dS9zTnNvdHJPWmxiOGlGVzhPNkFt?=
 =?utf-8?B?WG5RZ1dTVi9YWEg4aHprYXBFaVNMcnA2SHdtaU12RVRtT0Z0U0hsdXN6NnR0?=
 =?utf-8?B?ZUwzdzhxQkxzQVBMRHpFK0xKVkp6WllLSFV2WHZONDQ2ZmJVLzl5ekZJR3hN?=
 =?utf-8?B?Njh0cE94WU12b0VWK3A4dW0yTlRIYkprMzVXZ05ha2JONzFpOTI1VE5RMUlN?=
 =?utf-8?B?YndlT2tHVXVmNXVKQlFvTUwvakU4VmthNFkvVXpHTWMvSVZaYnVXQjFqTnFi?=
 =?utf-8?B?KzY3ckxaNEZJMVJCNGcyekkwc1JVVlh0cjdkRGVLQlpBeWQrWkNNbFVRcXZW?=
 =?utf-8?B?cmhmcUVGWnlTUTRqdmphdWZlVVhKM0dsSkRRR2FObnlObGJCQ0dLbjRLTXBx?=
 =?utf-8?B?b3JMV043SFpZdDFhYUdmR1FXRnhBSnFETnFqUDNxaWlJa0VhUDBvY0RxSE1j?=
 =?utf-8?B?RFZkc05HNGU0cUhUejgrWFdhT3pLRktuQVZRS0Q4Z0x5VVBBNWZQR2kzZmlZ?=
 =?utf-8?B?REV1VElVQWlNZ3NjMHorenp2QVhOZnFtSkFZR1ZlSUFORkZkNy9vUnVEY0Fp?=
 =?utf-8?B?VzdrT2xlc203YXFlSHU4NTVuQ004cHlpaU1rdVIzdkVyblg2a1h0c0Nqa3Vq?=
 =?utf-8?B?VDZ2QmZjMEJqNHM3YVJKYUdsL0htYTcwaG9rbG0xbi9tREpMSG1iQnlkaStq?=
 =?utf-8?B?WUZNdWFhR1cybjhJcjJWbVYydVpoNlVNMTJXTlI0NWUwV0xXUmdOMm1uaEhr?=
 =?utf-8?B?Wkc5REZoZ0xQRWdNeDRJUFVSMENjVndyTmVMcVFrQW41bWgyUjVVWU5RUVRE?=
 =?utf-8?B?bklUWFNvd3VxRVJXYzdDQlFTV2RJRmthRkk5dTRid0tJb1hUMDE0ZjRpOG1L?=
 =?utf-8?Q?ujVznvN7BrNLNeGZFX799QA=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2eb8538b-1d5d-41f4-f3b8-08d9fabb452c
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2022 13:07:27.7444
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0PmxTIwwWKDO04Vpm7BZvtd7hO8SmEg/GvvQxJgIkNEOFkyB3xiVECcOu8hoFVrSWwZl63r059umhkZ1wUE8Fw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR0402MB3943

On 28.02.2022 13:09, Jane Malalane wrote:
> On 28/02/2022 07:32, Jan Beulich wrote:
>> [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments unless you have verified the sender and know the content is safe.
>>
>> On 25.02.2022 17:02, Jane Malalane wrote:
>>> On 24/02/2022 14:08, Jan Beulich wrote:
>>>> On 18.02.2022 18:29, Jane Malalane wrote:
>>>>> Add XEN_SYSCTL_PHYSCAP_ARCH_ASSISTED_xapic and
>>>>> XEN_SYSCTL_PHYSCAP_ARCH_ASSISTED_x2apic to report accelerated xapic
>>>>> and x2apic, on x86 hardware.
>>>>> No such features are currently implemented on AMD hardware.
>>>>>
>>>>> For that purpose, also add an arch-specific "capabilities" parameter
>>>>> to struct xen_sysctl_physinfo.
>>>>>
>>>>> Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
>>>>> Signed-off-by: Jane Malalane <jane.malalane@citrix.com>
>>>>> ---
>>>>> v3:
>>>>>    * Define XEN_SYSCTL_PHYSCAP_ARCH_MAX for ABI checking and actually
>>>>>      set arch_capbilities, via a call to c_bitmap_to_ocaml_list()
>>>>>    * Have assisted_x2apic_available only depend on
>>>>>      cpu_has_vmx_virtualize_x2apic_mode
>>>>
>>>> I understand this was the result from previous discussion, but this
>>>> needs justifying in the description. Not the least because it differs
>>>> from when XEN_HVM_CPUID_X2APIC_VIRT would be set as well as from what
>>>> vmx_vlapic_msr_changed() does. The difference between those two is
>>>> probably intended (judging from a comment there), but the further
>>>> difference to what you add isn't obvious.
>>>
>>> Okay, I will make that explicit.
>>>
>>>> Which raises another thought: If that hypervisor leaf was part of the
>>>> HVM feature set, the tool stack could be able to obtain the wanted
>>>> information without altering sysctl (assuming the conditions to set
>>>> the respective bits were the same). And I would view it as generally
>>>> reasonable for there to be a way for tool stacks to know what
>>>> hypervisor leaves guests are going to get to see (at the maximum and
>>>> by default).
>>>
>>> Like the "cpuid" xtf test allows us to?
>>
>> I don't think I understand the question. That xtf test is concerned
>> about checking the CPUID output it gets to see itself. It doesn't care
>> about what other guests might get to see, nor the maximum and default.
>>
>>> Makes sense to me. I'm happy to take that up after.
>>
>> "After" what?
> So I meant to say that I could add the Xen CPUID leaves (40000x...) to 
> the policy so that toolstacks could know what hypervisor leaves guests 
> are going to see - in a future patch, as this wouldn't just expose 
> XEN_HVM_CPUID_APIC_ACCESS_VIRT and XEN_HVM_CPUID_X2APIC_VIRT 
> (0x40000x04) but other features too.

But doing this in a future patch (i.e. subsequent to this one) would
mean to first introduce the sysctl just to then rip it out again.
Hence my desire to consider the alternative before we settle on the
sysctl.

> But, at the same time, w.r.t. this patch in particular, using 
> XEN_HVM_CPUID_APIC_ACCESS_VIRT and XEN_HVM_CPUID_X2APIC_VIRT to detect 
> assisted APIC gives us less flexibility to add more fine grained 
> controls in the future.

I'm afraid I can't follow: All I'm talking about is how to expose the
same kind of information to the tool stack. I don't see how the
mechanism chosen would limit flexibility going forward.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 28 13:11:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 13:11:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280535.478501 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOfo2-0003ov-Ok; Mon, 28 Feb 2022 13:11:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280535.478501; Mon, 28 Feb 2022 13:11:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOfo2-0003oo-LT; Mon, 28 Feb 2022 13:11:14 +0000
Received: by outflank-mailman (input) for mailman id 280535;
 Mon, 28 Feb 2022 13:11:13 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=A4HT=TL=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nOfo1-0003oi-CA
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 13:11:13 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e6b3f615-9897-11ec-8eba-a37418f5ba1a;
 Mon, 28 Feb 2022 14:11:12 +0100 (CET)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2104.outbound.protection.outlook.com [104.47.17.104]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-19-rQ06ts_1OHagxddGVVvKRQ-1; Mon, 28 Feb 2022 14:11:10 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VE1PR04MB7229.eurprd04.prod.outlook.com (2603:10a6:800:1a3::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.25; Mon, 28 Feb
 2022 13:11:07 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.026; Mon, 28 Feb 2022
 13:11:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e6b3f615-9897-11ec-8eba-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1646053871;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=kD0aGtyTjlr11TReNGT/7qP736xzv7cfeHhdIJ/IuQE=;
	b=OnxM8EAIRGcs6B0ClomdquI+CQwM5/JGH7qkhqGLizXlb4zvhwfXRZglHQKHrrOrgan1F4
	1upr0pHkscRCPQ9Zvv3OfHXKHc9J8TGUT+s+Rths8yi7Y6JG3v3l6VQ/H9vO8QrufrWlBt
	aF/eEInqW+joVJ4eEPMTcws8egnAsjo=
X-MC-Unique: rQ06ts_1OHagxddGVVvKRQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=KxKxxDxPHpb+wAV/hYlwHggDn6AuIXbch6D6RMbM9defQ+e7idbDApS7/myOeHp6+0Z0hV9ZtmE4sZJK9943KB/wRyAhOd9Q0TiBVD42W2uYld5T71C7fp1dvHRqCUPW630mC1Qan3tMnIsENX7BF6KAvACJLglACz59D0dekEk82JZ3ZWFVeK25WiWLwxjsp8y6Zc048Vd8qKLpRPDsv3p/by6h4Dy8xcTIaGTuc2/wtR2qi9oxEM08sQkEk2vBX/QvGlzzvcQYCiDrEkTp5y7uAXtomBOXpPWmGIHif08wL/TwF8tT/CdwXBlmur1WxmBYZQBXA/7VlpuNc3IAYA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=8qZHvWeych6RhHN2ubviait2sJiMss69UsUHHbRKn74=;
 b=mqgPpgqiL2vFdC4FCLfXFQiprvjN/LcS5FMsDuWoMst4X5Siv7sGg2L9GYNvsx5w7HOGAzEt5gEgErbQ/37Hy2+fYeyqS6ndeeXQtSn5ekiiAY9D5zAqsaJMPAhMa5W1aM6Vl/2Tq+AV0/Y3EbX+oiggpXrSiUZCJ7ov3j+x9HMsQjNA3gktuVrsmvTSOhXxtDK4fX8esK+Z8CW1y6tKwB9C+VZZxbGQOXdXJdqjsOp1bNhdCxZmUjleAciQLLAvA5tTcTsz7S+fNQ2FkKFMKc3K1EvfqtJBBQlEWVIp9K6qQ+CYhIc6zyF9eW1YcjBKm3xRkvbPW5e0fjz8RsBOAA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <9aff51c2-0e8c-685c-7bff-0ed7ff7347c7@suse.com>
Date: Mon, 28 Feb 2022 14:11:04 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v3 1/2] xen+tools: Report Interrupt Controller
 Virtualization capabilities on x86
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: Jane Malalane <jane.malalane@citrix.com>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Jun Nakajima <jun.nakajima@intel.com>, Kevin Tian <kevin.tian@intel.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20220218172943.12182-1-jane.malalane@citrix.com>
 <20220218172943.12182-2-jane.malalane@citrix.com>
 <0a31970c-c0f8-c995-ce04-67523a4a830a@suse.com>
 <YhyrAyxhNtNWi7NY@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YhyrAyxhNtNWi7NY@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0403.eurprd06.prod.outlook.com
 (2603:10a6:20b:461::33) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: bfd78576-181a-4649-5eed-08d9fabbc815
X-MS-TrafficTypeDiagnostic: VE1PR04MB7229:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<VE1PR04MB7229DF5214354E237682A488B3019@VE1PR04MB7229.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	CInelCzg5KB9JYGPFzFF6B103vGLeNRih1/obILHvCONuv44HLIOz5AIdvo5i3xdyrNrVzsp9r9GaN/o9wnTYwQzc8zEnUcIQX0lhgOF/UkfLOjyHkvg+m7ZlcFMxNOpdBWUx5hPwISwB9X4GC+kzhUcCJ7B7mPXfYFD65HRaPu8YF4t4B6R8DmG7ZoRANhwUnSPuTl2zKwE9OqhHRIbDR7Tjxss/xdqiUHF4YOdHjM+d/rNzhvXR6tgHy2uZNA2l8L6svC3N1gzetria/cwjY5IcBZVEutjQ/bRsfU4C52dajN9b32UR6S3/zQ0dfJiUKaUtM3wi/6lZOv9Pi1d/X3n0rkgOPkqEpGhiPMTJTrvgKT/OcOZD8f1qk7sgbsM9UUiNt1oJwwrLVREHnSVu974Vb27/OCt5j9EtmSpJTPQxYMd2OSG15YEA9UaTrO6KQKToK63nFERqfDBemOlJtCmDfkwT70uJzSxim5swgDNX7m9H/6pdPycZ3kujUkUD3vyZFAHTATzLRYvr8HOKJZgnDrerG15iAv9pc1tuZql7rAkMBaDMHRjc9EIrL6GOwiRaphsfFbOwFJZY/f/D1CHr7OAtAnM1wSHUAF91DEcHJ9pE4iRaUjN/O++qB5WQMX6tnCO7eBvTxMQKU2HDzuH3G08BXovE02hMh1rwpoeMiHzXQafaAzE454OxbzNbIBAWZ+mArNoMogxEd440u4S9IUs5+mCIY2p2gMFH0J2uKdj8El1q81rI4ftUeYt
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8676002)(186003)(4326008)(2616005)(26005)(83380400001)(2906002)(5660300002)(36756003)(7416002)(8936002)(31696002)(86362001)(6512007)(316002)(6666004)(6916009)(31686004)(54906003)(6506007)(6486002)(53546011)(508600001)(66476007)(66556008)(66946007)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?okXwB14W9cqLkawTOglL8jpJg76wgisTiY80odOsAy+m7/rzHp1GzV+AqfPj?=
 =?us-ascii?Q?+VR+JZ47Fh5PyMr496SRSpo6knO19fst8tJERVvHNBlF/s+3Fjb0YhC/HMgf?=
 =?us-ascii?Q?qzr4TuU7+9l1JC4cleZoNuxpwUc+UEXPHeCDYbFsNMw+Wbvqmvb+PQ9Zs3CW?=
 =?us-ascii?Q?B6RW1wN9Nn8Sqk/cSR2Zo0GaCVa+xw9hyuvxkn4udXg6mvCf21jrvucNbUxe?=
 =?us-ascii?Q?2xWKSVc+txIfj31xDRYR8BayuQWvS5JXlRdq0Cq4zD/PmqSrISxgK6tfAiOl?=
 =?us-ascii?Q?+WdezSSDtrN6oJbYbjO6z2K0na1ydHn3Q0RGrpww6AsE9qV9VVqQ4gTVOlXP?=
 =?us-ascii?Q?6H+w/w7K3UmX9z8pn+PFQxKhYNmTPF4ufCKN7AwLay9/G/3cG9gHE3xutdE1?=
 =?us-ascii?Q?8946l7ta+tHrgAkLRP4ntq4wHtWciY7xIjFuDS+mD7bVH/v0oVfwd/7gNEr/?=
 =?us-ascii?Q?QUl0062XyE5VS1/5UqigH4cLtmaSDFg1P/wab++mAufsYWquXo5LgKOJuP2D?=
 =?us-ascii?Q?hP1i0oIPeo3TXqeFQ7wMn8qveGF5uwkMXKRJ7puzwAjh5hOUrF3cD5xIyVkS?=
 =?us-ascii?Q?BVG2UCHA8xheAI8hpJ70wl8tcrJtRb7sCvVhtO0tIdLJA/jGTADsEQHikTyi?=
 =?us-ascii?Q?jZygmx+7CxnWwwzi9APlrT+RjAAVYruL7XlixDMs9Gt40NPK0ayHxHdPOiYQ?=
 =?us-ascii?Q?7JYhuny9mqO2FyPphPs3VPmbV6p54aBqNAs8XuPwo/iaM8ScHsfURbqp0tdF?=
 =?us-ascii?Q?O7YNYhEmm6u5kiTSEkuAfReEYwIyqzPUfvPRVqEphQeH+n7BNZzYR89cfe7D?=
 =?us-ascii?Q?gH0XG8s7fqsR+xxTeQhg853DabO2bcJBoAlr5CS6cPrjjwqciaDJKIOnJWGr?=
 =?us-ascii?Q?gemFFhvjomrL6OGJZUheBMPszV9Pccj3BvjfcNA3bMvXdKABfa6aLmQ8iiT8?=
 =?us-ascii?Q?xMfnvMTSffwC+LUauzb5K4snTCt4rTAx0O3yaNcClG2iaJ3cCbfeNN+/9UjO?=
 =?us-ascii?Q?sOayjys4cALbd1beDxWIrFARpApHnHWwDQos1JHgSbozh1LPRrfnYU2SKB6U?=
 =?us-ascii?Q?CusDgyBfwf00Eckbspyn6UfGx9OKrFfqHE64inOEfY1ND/GUT7ogcITU+7kt?=
 =?us-ascii?Q?cbbATFMQhvc12nG9Mm/4tb2DkTlc8hDiiAWDJzDxUw9h71aAwKkZjKdCwziy?=
 =?us-ascii?Q?Dd1YAnKw9/iBuPTqYaTEz590HVmWjLOQDfuOMniLxYcz/wTpeIJOE7bmDVNi?=
 =?us-ascii?Q?clLjiif9qGrhpqZTl8uco23w5jXalHnukM1fBUqzcmK4CKPvgMh/oXRvTcTE?=
 =?us-ascii?Q?8753D3+11m40bQp2aVXuSciagQ3+J3//7Au/o5IOuBgGB+ItjTyRF8rNnvrz?=
 =?us-ascii?Q?0MENEXwTKoQQ7l+g/lmACYW7fsSIlw3cyGBQ4dszkcMSJPLdS9zwJMoTCoPn?=
 =?us-ascii?Q?ymaJ3bHRnKl2Ayw3i8FfSTAC4gJqjPMQkxtzN7VKkmQ+LA0m7bt98VbBmnmD?=
 =?us-ascii?Q?B7gHOHY2F1zVKti/FtD/tcEf5v1+C2paMGBCLVQ8O84gnFK83rmheBC1dBjP?=
 =?us-ascii?Q?ZpWcna9doa8QpcfFFZ7GIq2cdAVOeII6rPwAOcwnfZL5OPnS/FD/EbIqSLKP?=
 =?us-ascii?Q?RGCUIraZUD/Df/SJI3+yK9M=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bfd78576-181a-4649-5eed-08d9fabbc815
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2022 13:11:07.3401
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nphEnF64kTJ8lQui2hr3hO/HdVGaiCwpluWf8Wf0Tir9ORbPx7/inf2cdoGmkVjW3shWaDJIlcMLBhEnJVT0gg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7229

On 28.02.2022 11:59, Roger Pau Monn=C3=A9 wrote:
> On Thu, Feb 24, 2022 at 03:08:41PM +0100, Jan Beulich wrote:
>> On 18.02.2022 18:29, Jane Malalane wrote:
>>> Add XEN_SYSCTL_PHYSCAP_ARCH_ASSISTED_xapic and
>>> XEN_SYSCTL_PHYSCAP_ARCH_ASSISTED_x2apic to report accelerated xapic
>>> and x2apic, on x86 hardware.
>>> No such features are currently implemented on AMD hardware.
>>>
>>> For that purpose, also add an arch-specific "capabilities" parameter
>>> to struct xen_sysctl_physinfo.
>>>
>>> Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
>>> Signed-off-by: Jane Malalane <jane.malalane@citrix.com>
>>> ---
>>> v3:
>>>  * Define XEN_SYSCTL_PHYSCAP_ARCH_MAX for ABI checking and actually
>>>    set arch_capbilities, via a call to c_bitmap_to_ocaml_list()
>>>  * Have assisted_x2apic_available only depend on
>>>    cpu_has_vmx_virtualize_x2apic_mode
>>
>> I understand this was the result from previous discussion, but this
>> needs justifying in the description. Not the least because it differs
>> from when XEN_HVM_CPUID_X2APIC_VIRT would be set as well as from what
>> vmx_vlapic_msr_changed() does. The difference between those two is
>> probably intended (judging from a comment there), but the further
>> difference to what you add isn't obvious.
>>
>> Which raises another thought: If that hypervisor leaf was part of the
>> HVM feature set, the tool stack could be able to obtain the wanted
>> information without altering sysctl (assuming the conditions to set
>> the respective bits were the same). And I would view it as generally
>> reasonable for there to be a way for tool stacks to know what
>> hypervisor leaves guests are going to get to see (at the maximum and
>> by default).
>=20
> I'm not sure using CPUID would be appropriate for this. Those fields
> are supposed to be used by a guest to decide whether it should prefer
> the x{2}APIC over PV alternatives for certain operations (ie: IPIs for
> example), but the level of control we can provide with the sysctl is
> more fine grained.
>=20
> The current proposal is limited to the exposure and control of the
> usage of APIC virtualization, but we could also expose availability
> and per-domain enablement of APIC register virtualization and posted
> interrupts.

But then I would still like to avoid duplication of information
exposure and expose through the featureset what can be exposed there
and limit sysctl to what cannot be expressed otherwise.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 28 13:14:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 13:14:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280542.478513 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOfrH-0004QL-7W; Mon, 28 Feb 2022 13:14:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280542.478513; Mon, 28 Feb 2022 13:14:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOfrH-0004QE-4M; Mon, 28 Feb 2022 13:14:35 +0000
Received: by outflank-mailman (input) for mailman id 280542;
 Mon, 28 Feb 2022 13:14:33 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=A4HT=TL=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nOfrF-0004Q8-Qt
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 13:14:33 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5de7bea0-9898-11ec-8eba-a37418f5ba1a;
 Mon, 28 Feb 2022 14:14:32 +0100 (CET)
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2055.outbound.protection.outlook.com [104.47.8.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-6-4Eev3sAWMSeVX_AD0QmVgQ-1; Mon, 28 Feb 2022 14:14:30 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by DBBPR04MB6220.eurprd04.prod.outlook.com (2603:10a6:10:c3::21) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.25; Mon, 28 Feb
 2022 13:14:28 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.026; Mon, 28 Feb 2022
 13:14:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5de7bea0-9898-11ec-8eba-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1646054071;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Um5wEw1f2ufoSKcJchQ47VCEqmRtpI8I7nyn3bbyGfY=;
	b=lAyqKqV9Izxe1MYX7o6f0jJDN8IAF8ED2D1hxW/f+YLYvhW98DRVtFoyDe3CYKuIskRoMI
	BM8UFtCT5OdYtri2i0+HFVHSZvFCfva0aIUrnmxHqqk/D4wE2OaacU4FjdN8P6ZX4H/FV7
	ssBivtl66mrtaJn9YAfWc9dW/LZG+kE=
X-MC-Unique: 4Eev3sAWMSeVX_AD0QmVgQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=I71I0zHNrw5MbMczNt06F6ZFRhRbJMQfXCP2IsDI6woArhrL5DpNaXVS4kmT3CguXnEkrnv4Ouo7qdpo83g6l/stUgFJncRPhgjjr1nVfBWaquG/Lujb59gsGuf6Vlj6PbJJoLgGM3ANWTA7zs3UNdZDi2JRX+sq8/NtBR27aSTmlSCzoyAL6VWtOIccvS246+9kZ+Vtjpvh5y1hRcEk2ctQKvftZ+VymwJ8OEnKZHntwi/hWtI+yl3tLyOv5J2GrldVpzQl1a1pLvihabogmtk6m5Uj6tb17h47nShF3w5i5d3M1T+KnknxOq1aRHZR1QfQKKPAzry0VfarcH7Zww==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=9IKE2iV1JMgL6mQHZgo3tA2XMoT0PL676W0/BB6Faqo=;
 b=btlGAQK/th8TTKmbmbAmQZVeop20hhT49h8BUbVcH1F5Th8WI10GCcD21TsaYSKxw17+dN+bl+RUTh4Fm/duashsh7E83uRmcBUEkYdDbM3Nei/+mQFbWphC3Fk4EOht0qTI7SpfWRWD/FRPpeQu9tIVutmXnAgBWS9HWTqEwApdMozRc0NVJcsuVkviBAGCvIzEN00FZVG6BNZ7miXHvCU6FlTK1RGywZBMkKq1fgPtXZwebcaFB5WfLHfIEPMLlIrca3yqD2tYijSw2GI8TuM/FgIYBnziudKGLqLgHb7SCFWP+WCbgndKXBQU3UQNlXTps5J8NZ2tUTyHqclNPw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <7ad79609-bd67-aa44-56e0-1070f3ee88f7@suse.com>
Date: Mon, 28 Feb 2022 14:14:26 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v3 2/2] x86/xen: Allow per-domain usage of hardware
 virtualized APIC
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: Jane Malalane <jane.malalane@citrix.com>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Christian Lindig <christian.lindig@citrix.com>, David Scott
 <dave@recoil.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20220218172943.12182-1-jane.malalane@citrix.com>
 <20220218172943.12182-3-jane.malalane@citrix.com>
 <b83773ec-c97a-7aea-e61a-c2e34b270816@suse.com>
 <Yhyv6Ui4ap1wOeNd@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Yhyv6Ui4ap1wOeNd@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS8P251CA0010.EURP251.PROD.OUTLOOK.COM
 (2603:10a6:20b:2f2::8) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e59bda3c-9bda-4b84-bfc1-08d9fabc4007
X-MS-TrafficTypeDiagnostic: DBBPR04MB6220:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<DBBPR04MB62208420F97C3FA2F9F2401CB3019@DBBPR04MB6220.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	gwoNfgFJzqAK2HW4X+yaSrSES369qvNuSYQrfVoZ3WmtFATJmTR0Ig9DhF+BSSYPW9Un84/FXnYW+AqcUyNRt8zxqtm7cLUs8rEvLN8H9EcFyNMFUdQD4Qh76VaXInYm9y7mJ1MHmhCBfk9eCtsnLd1Z+Dn9FI6ypQRy2Y4bPMUgVwWJTyERDqJRvKqK7uFYsE6bzFjK7NztKCLHUnEFJBs6FuMqoQCvcePcPE+E+ps665jw/4jbvrAp8oBN2AI7SZSZrXEiAmaQixractMiqSMYra/mGZ8CqeZVl1vsoJzo5+xqltov3yiEX4aa+yZBawvSiLIwa2gwt2HjEpAZ1xkJ5iaPe32akYUWmGcVN299KcHiG0YjW6ouIf1j11PVNzxLcjAfENYcmJ7xZmSBlM0yYi2KFHZUawM16T4poh/GG1XY59r+JV1FVZHaRGE5pt6BehoeM8OUIn3Qnztmri7XDWyerbudaQE/u9vROZ4E6iaYjIQuzi3OzT/vv7PHq7ujCYo0h18A3D1djN0RGgUruOT3n0dAHXG7/6AHYuJBOfg99eCT//HIJ6rgt9a9pzvLn6ReaJwu4qgnQisgQ6cx836Vqv3dHA5hMPWb2vuW02Dx3Umfw5k17wnUgsOLoLknwyh4PNNC6ZQCktCcwYhOMLHllsOKhL/jtuPNjwow/SY96cMQnAdY8+kqnCrsHiub45hthXlubA2f87LFkx10zGzF2C1BjRfTwDTmaqBO97idSGn5ZPW0BPVJ8jVX
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66476007)(4326008)(8676002)(66946007)(31696002)(26005)(6916009)(6512007)(38100700002)(316002)(186003)(53546011)(6506007)(54906003)(66556008)(36756003)(508600001)(6486002)(8936002)(7416002)(2616005)(83380400001)(2906002)(31686004)(86362001)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?6qADXP6qupXQRACkpNo9x9wiFiwbnhN6j/V085FsO0C/xj3L7/Dwtt0l9fvp?=
 =?us-ascii?Q?M+MudJHnbptb77bNUdTU9lvsSLkGZ/nVNJ0T9UkbfA+l1GHZlFK0ofWWmfV6?=
 =?us-ascii?Q?3PeiEO3N+QpCenFuGIglrVFc2eyvH43LqwVjw3IiYryY6amEeX35HuuhwB0n?=
 =?us-ascii?Q?/SMq6Y5rgnhI6lf7cRcAPmgyjU1QPSQM8Xm0R+7SDv3EMXhwGeaXwhPy0FYZ?=
 =?us-ascii?Q?n7CvbPoEkWT18b+A2869cpUDSosH1t60DzDgkPft2jOebVYTv9y03szOCYaF?=
 =?us-ascii?Q?EL1X3j85a8MhGdjZ5IonBxu0BVoyyZyGfMXZVBsFydUVm/EVBgZuDbqTCzRk?=
 =?us-ascii?Q?vNn2OVT9fS7ilfPpAOdfD7s7bVNdezbH/giU99zkTdxqeFix1ag3wrrd3BrT?=
 =?us-ascii?Q?I4DgxoaIsp37NFmknKHxZZ+x38dhc+FGGS7IPYfqq2ZAMyI2sKKbkGXtQ66B?=
 =?us-ascii?Q?wAxsAlyL09jEbNon7sjbo/oxwxx9oJ5NSdXuZbnnefvYQ2WqOP1VQAQF2LqE?=
 =?us-ascii?Q?MmYn+0IwLYdQ60fvmAfGS1dMB/cZ6DEEKARzcQsvvMi3WW7gzJFvTtRFtDNd?=
 =?us-ascii?Q?0KXg83J65H2CqP/78f4lb2dyVJosDsNPm3DYHVclDYakVaF3S5kirLwDpzyB?=
 =?us-ascii?Q?+Tlyc2wwDL9IeViyATT4U+rkQOkGxUjj3wWT8jmrELMznrpo6L5ttczbRrYM?=
 =?us-ascii?Q?x+GsgHRv0WiLH4YpgLuGZe24Kh94/nu2zW/7Nu1sExQq1pPH33NmqH72OYog?=
 =?us-ascii?Q?hmcVA1rBMJSsNbvlRnLX5Rq4khs+/witdvo+4xIKQvSEGf3rMG3+IoPDkxIo?=
 =?us-ascii?Q?/irYZEghwsfRRgCnnhW9sgTFYUL+a+0DbCL7sz5H9HXYYm/5QQ+//mdoqTpy?=
 =?us-ascii?Q?LqbczKb623MYrlkVqHti0B69KOodNhY/XyJLBkndBWBbWAbrTSU3e4RbeSGQ?=
 =?us-ascii?Q?VhkuPebYlssqFHWAz0PaNSRBiYzSRvXi8kwsKzRSjpgj/Yg+oH8Ujxn8Iugs?=
 =?us-ascii?Q?HJDH1b6g3qQIOdSfwlFK9XlNint1aKgUB/m1kP0TGn9Fg9MpeKzPar1/5lGf?=
 =?us-ascii?Q?fa8RfKxEKH+/zVYQCbg6dqcfSGMRX+GjZ2DB3vNej4MCDr7HrmNnnXM7whp9?=
 =?us-ascii?Q?Wj/U3X1ztOneAZQrRaB9I7xasgm9DOC8reDxEGPq+9Lj4qsY4Oi3CBPKzo2Z?=
 =?us-ascii?Q?xydfheF01GOPZ48oDJJveCzJ5a7b0v2HtXbSeAIPcNB37oNfrdlOoFWIeQ6b?=
 =?us-ascii?Q?IDZdh6k8RZcT6rsWekXQ7PUYbM8hgZ112V1fHEbo00q9qe+zVuF9atXGI/7B?=
 =?us-ascii?Q?IapqdoMmqoddNHCXjIfZL4OybbEmtfJCruhOCDp3D/q9svggIKh84b+px1MM?=
 =?us-ascii?Q?DTUHHYXqRvptp8Ab10qLsCIGGNrXcC7CobGgVAhR3UHzdeBuyWocMIu2en6n?=
 =?us-ascii?Q?TrheYCWgE/0XL/EoVF2TKD30umvbZ/GnkGvY4BR84IAGxGCuv7AL/ku1P8CF?=
 =?us-ascii?Q?zZfhWnXLq4l7P/zaS7XXUUlhs0Zc1CUP6xa/ijHUqOXa1j+ZExppw0Pk/3F0?=
 =?us-ascii?Q?U5RAUHo4lJ5F/6WJASUEMFQYjtfbFDsnCL10feAIBGkBNkvEAC0+PrlvjqB4?=
 =?us-ascii?Q?rNMH4jLY9nq7b+IX/fGYIa8=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e59bda3c-9bda-4b84-bfc1-08d9fabc4007
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2022 13:14:28.5774
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pZtMtKLI/e7N56NJR6gP9MrJuCdbaPfzwEtUTHQUk2PxvbIGu7+4vWMppMsEcWusiobWJVGOH7/TiWLv3l5BdQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB6220

On 28.02.2022 12:20, Roger Pau Monn=C3=A9 wrote:
> On Thu, Feb 24, 2022 at 03:16:08PM +0100, Jan Beulich wrote:
>> On 18.02.2022 18:29, Jane Malalane wrote:
>>> --- a/xen/arch/x86/hvm/vmx/vmx.c
>>> +++ b/xen/arch/x86/hvm/vmx/vmx.c
>>> @@ -3333,15 +3333,15 @@ static void vmx_install_vlapic_mapping(struct v=
cpu *v)
>>> =20
>>>  void vmx_vlapic_msr_changed(struct vcpu *v)
>>>  {
>>> -    int virtualize_x2apic_mode;
>>> +    bool virtualize_x2apic_mode;
>>>      struct vlapic *vlapic =3D vcpu_vlapic(v);
>>>      unsigned int msr;
>>> =20
>>>      virtualize_x2apic_mode =3D ( (cpu_has_vmx_apic_reg_virt ||
>>>                                  cpu_has_vmx_virtual_intr_delivery) &&
>>> -                               cpu_has_vmx_virtualize_x2apic_mode );
>>> +                               v->domain->arch.hvm.assisted_x2apic );
>>
>> Following from my comment on patch 1, I'd expect this to become a simple
>> assignment of v->domain->arch.hvm.assisted_x2apic (at which point the
>> local variable could go away), just like ...
>=20
> I think we want to keep assisted_x{2}apic mapped to
> SECONDARY_EXEC_VIRTUALIZE_APIC_ACCESSES and
> SECONDARY_EXEC_VIRTUALIZE_X2APIC_MODE respectively, so that in the
> future we could add further controls for
> SECONDARY_EXEC_APIC_REGISTER_VIRT and interrupt delivery.

If we want to be able to control more (most?) VMX sub-features, it
would seem to me as if this would better be modeled accordingly
right away. At that point there would likely need to be VMX and SVM
specific controls rather than general HVM ones. Plus then it might
make sense to match bit assignments in our interface with that in
the VT-x spec.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 28 13:19:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 13:19:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280551.478524 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOfwO-0005E8-U0; Mon, 28 Feb 2022 13:19:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280551.478524; Mon, 28 Feb 2022 13:19:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOfwO-0005E1-R3; Mon, 28 Feb 2022 13:19:52 +0000
Received: by outflank-mailman (input) for mailman id 280551;
 Mon, 28 Feb 2022 13:19:51 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3PPb=TL=citrix.com=prvs=0512ed4f8=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nOfwN-0005Dv-3h
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 13:19:51 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 199133ee-9899-11ec-8539-5f4723681683;
 Mon, 28 Feb 2022 14:19:49 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 199133ee-9899-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1646054389;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=0kRc8gBjLkYgEVkXNntJvOvykn3mZ64v01dlovW2AXw=;
  b=P3L+SIYp4eEDiYp9wBAX6KMbL2Jr+bihUXqEMToApyZzUq2DC21MnmqP
   9caXoA1zoRUxjWIMyMK3srlS2LM8m/xAb7VgqfIO1Q/fjhECBOM6e7vKn
   58uNg0Q1fxeKO3ohm8tulfvBTeTl7+Eo47sHONA3ufCfk419gcBnlGbGV
   k=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 65020264
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:q/kDkKoGvLGXd8WvNTQUXuo/v3ReBmLdZRIvgKrLsJaIsI4StFCzt
 garIBmHb/+KYjGmftgib4uwpE1T6sTTzNRlHgA/riFkRXxB8ZuZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlVEliefQAOCU5NfsYkidfyc9IMsaoU8lyrZRbrJA24DjWVvX4
 4Oq+qUzBXf+s9JKGjNMg068gEsHUMTa4Fv0aXRnOJinFHeH/5UkJMp3yZOZdhMUcaENdgKOf
 M7RzanRw4/s10xF5uVJMFrMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKv+Zvrgc91Zk
 b1wWZKMpQgBOZbCycAWckZiKDB/E78F5Zj2BFGYiJnGp6HGWyOEL/RGCUg3OcsT+/ptAHEI/
 vsdQNwPRknd3aTsmuv9E7QywJR4RCXoFNp3VnVI5DfVF/s5B7vERL3H/4Rw1zYsnMFeW/3ZY
 qL1bBIxMUyaO0cRZj/7DroRkNqWr2egWQF5l0iph/o7znL11C9Yhe2F3N39JYXRGJQ9clyjj
 nnd423zDxUeNdqe4TmI6HShgqnIhyyTcJ0WPK218LhtmlL77m4ODBwbU3OrrP//jVSxM/pdI
 UEJ/islrYAp6VemCNL6WnWQsHOC+xIRRddUO+k78x2WjLrZ5R6DAWoJRSIHb8Yp3PLaXhRzi
 AXPxYmwQ2Uy7vvFEhpx64t4sxu1AiZECWQjOhU/XAor8Zr+h7AWpzX2G4ML/LGOsvX5HjT5w
 javpSc4hqkOgcNj65hX7WwrkBr3+MGXE1ddChH/Gzv8s1gnPNLNi5mAtACDhcusOrp1WbVoU
 JIsv8GFpN4DApiW/MBmaLVcRer5jxpp3dC1vLKOI3XD32n3k5JAVdoJiN2bGKuPGpxZEdMOS
 BWO0T69HLcJYBOXgVZfOupd8fgCw6n6DsjCXfvJdNdIaZUZXFbZoHw/NRHJhjyzyBhEfUQD1
 XGzK5vE4ZEyU/kP8dZLb71Fje9DKt4Wnws/uqwXPzz4iOHDNRZ5uJ8OMUeUb/BR0U93iF69z
 jqrDOPTk083eLSnOkH/qNdPRXhXfSlTLc2n8KR/K7/cSjeK7Ul8Upc9N5t6INc790mU/8+Vl
 kyAtrhwkwKu1SWaclzRMhiOqtrHBP5CkJ7yBgR1VX6A0Hk/e4e/qqAZcpo8Z7488+J/i/VzS
 pE4lw+oWJyjlhyvF+whUKTA
IronPort-HdrOrdr: A9a23:rF4kiq6mICx/rMeh2QPXwWaBI+orL9Y04lQ7vn2ZFiY7TiXIra
 yTdaoguCMc0AxhJU3Jmbi7Scy9qeu1z+873WBjB8bfYOCAghrnEGgC1/qv/9SEIUPDH4FmpN
 5dmsRFeb7N5B1B/LzHCWqDYpcdKbu8gdiVbI7lph8HJ2ALV0gj1XYDNu/yKDwseOAsP+tcKH
 Po3Lsgm9PWQwVxUi3UPAhmY8Hz4/nw0L72ax8PABAqrCOUiymz1bL8Gx+Emj8DTjJm294ZgC
 j4uj28wp/mn+Cwyxfa2WOWxY9RgsHdxtxKA9HJotQJKw/rlh2jaO1aKv6/VXEO0aOSAWQR4Z
 3xSiQbToNOArTqDyeISC7WqkzdOfAVmibfIBGj8CPeSIfCNU0H4oJ69Pxkm13imhAdVZhHod
 J2NyjyjesnMTrQ2Cv6/NTGTBdsiw69pmcji/caizhFXZIZc6I5l/1VwKp5KuZIIMvB0vFuLA
 CuNrCp2N9GNVeBK3zJtGhmx9KhGnw1AxedW0AH/siYySJfknx1x1YRgJV3pAZMyLstD51fo+
 jUOKVhk79DCscQcKJmHe8EBc+6EHbETx7AOH+bZV7nCKYEMXTQrIOf2sR+2Mi6PJgTiJcikp
 XIV11V8WY0ZkL1EMWLmIZG9xjcKV/NKwgFCvsukKSRloeMNoYDaxfzO2zGu/HQ1skiPg==
X-IronPort-AV: E=Sophos;i="5.90,142,1643691600"; 
   d="scan'208";a="65020264"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=MNlv2XXghfsbtQ6T0rLOFI56OoqBCr/38JUNIcMmjLCF5GBKOPZwHRKeGBhxG0Z1E8d+Q83Qo3/8UsSz9fDbfRilib1zeFi+vGZqegGsPyYHlK0pW3HuYfFv9DVxzc8si+eUvSOHDfwm9Gv7SH01YrwN4dnnFQWRD6I5TW3m8yrPW1zQHC4/2S9R3kL5EQeaE/C8Rz5AV0K4pGCxHv4bX72SrGv1mwMgwoQyyp53rPAi9wg+nXn7VyOEZBNZGbCfnjlW6zmWQWgWf4tqVygHJMnr/ZCImyk7kVSzsVF5TBgDsk54DCpZxTXjLytS42h+kECToILGYZjkYalqr9FPdg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=0kRc8gBjLkYgEVkXNntJvOvykn3mZ64v01dlovW2AXw=;
 b=XOPZv1L9Cq8Y5prbfat5V3rB7nv4YVzDZt4okQC4Ndf9jBO1dKDuW+GJTaXGqmuDeNL3WP83mhTxYejB+iMV8PyxhcEi8q1rr1Fke0hXXQQzvB3bT8NjJXcsUjI+tWv5BkJjs99FdELb+p8+d2TIBzFlftqa+Ytrads8jsnr7o0J4QEMqDqshYf5+BTOCRm5zIXRqxGHeKokrTy0FLNUnTDug1+RBvQxtcMCA/YMFSjjKZMax57if1tWLCga3l0BQXHZXa/4TylxGqwaPxXkRwwNc5fXKJfFUT8FPaPsntrtNPw5zCigfng4NwcBw1qBQzBoj4XGs8Bh/BuKsHlbrQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=0kRc8gBjLkYgEVkXNntJvOvykn3mZ64v01dlovW2AXw=;
 b=P2fltrgOxeDoerCkX+cR/3tOLb9+PVOGc/VQxX6vBUOT8nCj2mrJJzZL+QSS8DoFq2+U3gicpPnlzseEOPmVNSOSyNsYM+Beq3bGJbgF2HYGzPsSFpHTwJEZTdo68ipDb6M4P68fArBUKonPP+SVXG26UUh40AN8VkDtNZ/LGts=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: George Dunlap <George.Dunlap@citrix.com>, Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>, "Roger Pau
 Monne" <roger.pau@citrix.com>
Subject: Re: [PATCH] docs: correct x86 MCE command line option info
Thread-Topic: [PATCH] docs: correct x86 MCE command line option info
Thread-Index: AQHYLIzH3mLmwWw5aEm0tUCG/sGwH6yo8pOA
Date: Mon, 28 Feb 2022 13:19:40 +0000
Message-ID: <81337ddc-afe4-ba82-9495-3f74c53e7041@citrix.com>
References: <329ac1cc-85d4-7ec0-a23d-a3f68c2864f4@suse.com>
In-Reply-To: <329ac1cc-85d4-7ec0-a23d-a3f68c2864f4@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: e1c3ef8a-e6ca-4dc9-0f55-08d9fabcfa50
x-ms-traffictypediagnostic: BL0PR03MB4035:EE_
x-microsoft-antispam-prvs: <BL0PR03MB4035533F70186A8617C893BFBA019@BL0PR03MB4035.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 2VkHdHNPpnjt72Uw/8uvD/U4dJAer/hc+lNW1/z5+KZT6+ntNiLyHUqrJGpKeT3uUvW68WuLghFEipMVtGGXOHxeWDlORKO2uE6DDh2UprH01zywzdnFXf92ut2sndSLMq9FdEErzOeaodPA0xNukWEB8wojc+MiIJc6+FzAQoiCxLlTVdHArqPKkESpqK4UHITuQbPAvl28lLMOMYomTukfOdT6gNWkJpGUUx2FZIXTDmq9JYM9wmmn5YfFy/LAICd7b43dhftzj6yi65skDfjtpjg1+jsUQijDEtbm/sE5FG+whflnP7xALIhGq7+SUL7hFV/iZmMnZzHIMoiodiExb+KfSeRkrT3UIFUMkTxQESIft1FjMTmD8x9gXN/UvNJq7xGUEr1/zruTjP53ysFvYcl97Bo7+oBS9IkKdF06ruI2I0hzt1i/6jbr1cR5UB3Zl729MKr96r6BZcqP+ElkgUbHbwY0fkR4OHTDXE+l/n0cY4YDgi07Lk4rMVWR01z8w3CGRqQDelVwkOVN0UpXUu3wGPaNhi2gQi+Gk4ewA1tKPxnCrqmZE0cGlpdzbmEpuDTXA2u5Wmku4KWyHX83CMBSW743VpG3VrIcJ5oP92lnpUeX1cBZRP/0Ir8NcA7wN4b69igDARpcTk9xdR4JP6YIomizOIY+rSjc26rKJr16FFWebjiA0FnXnHy/MB2bjA1scQNFY9QMf/a7NBbARezHWi8r25NDWYBIIZqlqJ2cYASlvjOG25od/Zw/6igBB85Z9S3TBAr+QzWd4Q==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(8936002)(8676002)(5660300002)(53546011)(31686004)(508600001)(6506007)(6512007)(86362001)(2616005)(26005)(186003)(38100700002)(31696002)(82960400001)(6486002)(107886003)(91956017)(76116006)(66946007)(66556008)(66476007)(66446008)(64756008)(2906002)(110136005)(4326008)(54906003)(36756003)(38070700005)(122000001)(316002)(71200400001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?anprdGo3K3JHZFN0MzRKdHk2emN1YjhiMytXSGV0cm9tK0dad0hXQXZic2ha?=
 =?utf-8?B?dXkxQTlvejdNU1kzT0tqV2M5VnJ1cHFJYUdhRzd0eko4SG9GUlFrNWNqY0Fw?=
 =?utf-8?B?djd0c29Tb0xNRWJuNm5pZnNRL1hkaWlMa3Y1VnI1aHk1N0paR2RSNmFiSnlt?=
 =?utf-8?B?NHlJckhFZU8yTVFTS1h3ZVhCMWZ3dUZxTVhmRTJFVDF4a1kzcFIwMXBsNGJK?=
 =?utf-8?B?cDBYTW1NZk0wMDYzeDVzak40VmYzNExRcHhvQWdJdkh6RENpV3NoRkt2MWRJ?=
 =?utf-8?B?RVF5TXN1OE9hUHBQZWg2Y2xsWmVSdkwvTXM1VTNTR2IvaVlKeHowckM0cDdz?=
 =?utf-8?B?bEtaUGlzaXJ4bnlhK21kaitCTm5MZmhqYUFlKzUxekFTak12Q3hpNWt1eUh3?=
 =?utf-8?B?clVGMnlYN0RZb1doZHZOaFNPZWlmb09ZcDRDcDFFd3oxWGZoNDZabTU4WFhn?=
 =?utf-8?B?VXJxSzdiTHdkb1NUSk5HZkFjWGR2N3YyNEo2Q2RSVWFBSm9SSElRTzU5cWt5?=
 =?utf-8?B?T2QzaUkyR2JldzdBSHQ5ZG9CYUJEbGw3VGFxM3djT0Mzc2RGVXU1WjlSekdH?=
 =?utf-8?B?blROdE5nNEthVDUvZEJpcWMwMTUxYVJoSXdQNlRWTXkwcmpiU0hRKzJLK1Yy?=
 =?utf-8?B?NzZlanBQUno3YkhpWUZiNWZFcGFzSkdhZ0hOTjVuQkF5eHB2Z3BWS2ZPOG45?=
 =?utf-8?B?RC8yZDA0eCtKbFFhRmYzMExFaFV0MDlJUG4remYvbEU0a2hzQXlpZzBwNW9u?=
 =?utf-8?B?Y2Z0QXg5UG81RUFCMTVMMXpNeloxazRrczd3QWdic1FOWVl4YUtkVzhxb251?=
 =?utf-8?B?bitKY25peTFCQzFKTUlwQ3duTmJrdGVwa2M1U0kzR0ZBbGoreVRUOXZrcnVM?=
 =?utf-8?B?TnFHYk5VbElBZzdtVDQ3S2JSOGFRQ2RKTkN5ejJUK28vNi9BK2svZTdnWUVh?=
 =?utf-8?B?TVN2ei9MOEVuNXRtVHBCM0RsR2Y1cUU0dURia2t1S0w1eUt2VnV2dmpzVjZq?=
 =?utf-8?B?Ujd5Tnd4NUpPUU5kYm9BSjM3RFlRMnVXcVRUQm9oR1JVd3FTUFQzcjlVUFVP?=
 =?utf-8?B?cURxNEtsTFZwbkJobGlkdkJDMThXbUZLNG0zQUpuZElMbEJMN0JNQjZjRXlC?=
 =?utf-8?B?UWoySnY2TkpxUDN2WGNMbFVkVDA4NENsRjNveEI5eHA1MUFnRFIzTDNxWjc3?=
 =?utf-8?B?aXlCUjRGWVh0a20vYThTbC9pdHJ0V1BWaDF0QkhCTXkwc2RZSkwrd3FGQ1p5?=
 =?utf-8?B?OUowdmV2SmVITWJKV1pScWxDY1BVb3FSeVBMOTVaWDVOaUVaUnNtL0Z4UUdE?=
 =?utf-8?B?RDJwV2dYaE9QUzI0ajRtdm03cnM1akhtSkc3dVRjY3ZLcGxla3JOdTFYdnJv?=
 =?utf-8?B?RlErV1I5U1h2MXR3dHFURXdhQlp1Rk9CRDFTZG9tbzN0N0h2bENTblo5eGV4?=
 =?utf-8?B?cE1PUkVQZkx1U3JKbFppcldxYjdkZmFpUHBFSXZXQzhxazBQa3daMWl3S25l?=
 =?utf-8?B?ajl5MndZU0dYL3VJRlVPa3VFbEFDY2JqSzdvQWJVOFM5L0hjT0Y4MU42N0tp?=
 =?utf-8?B?TTl6ei9BL3pNL1RKL090YnY3eFJqR2h1a2FvZXZUUTdjcmN1cHJlOTZRb1Ft?=
 =?utf-8?B?blVNVXFKeGY1TWZuczRuQXV0MnE0emhiWmEzaTFzS3FRMEZzVWNZb3Rvb3Ru?=
 =?utf-8?B?WDN2MTN6ZWRtYk1wdm8vOTRBblNmbG53dVMwTlJNZWNLRW1XQWNKRDc3cmk0?=
 =?utf-8?B?OUNONkR1QjBON3RCdkhWSTNCb0lWRGMzSjBvSENpTE9YcTMrbHc1V2x0VG00?=
 =?utf-8?B?Zy94clltRm5kN2ErU1Z2Q2NBMFQ1S1BUaXBLVHArUVlzT2RMSkt6V0JwV2tX?=
 =?utf-8?B?TGE4M212VlUzYUJtbWVQNDVsZmRJMEtwRFYzRUdyQzl6cWdMVnVpWnhuTlYx?=
 =?utf-8?B?bXIrdXV0TFc1eGt3T0h2d1F0R2hhbkk4S2kwQlBGUm96K3Fia0VmZGJ0V2tl?=
 =?utf-8?B?LzB1V0xwaFJ1Q1ZycmFwaHhQOVpPbUdGbldUMldlSXRpSjYydlBhTDIxc1N2?=
 =?utf-8?B?UTZaYnRMRFAwbVBZVCtBc0VIaXNYTzdXNzkxUFlVaVVybXAyckd1cGw3WHJM?=
 =?utf-8?B?SnkyZHlFNDNSSFQrNkhHMnhWTFVqSURjcmxyZXRYRGtoKzc4cFZTeG5zbVB1?=
 =?utf-8?B?dnpndXI0RWJuK0VWcjNIczBJdlo2WTF4T2tCU2R6Q2MxVmpUYUNrZDNNMDFK?=
 =?utf-8?B?bkQzMU5WcTJIVWVoMVFmdFJ0KzlRPT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <0D5E15B2C3CCCC46B8F16A1E66E5534C@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e1c3ef8a-e6ca-4dc9-0f55-08d9fabcfa50
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Feb 2022 13:19:40.9201
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 9GeB0KYGa6lCD4FRiYtGEPIguw18PXLnW7Ee5V6kNEn23qnP+gDr6j83M9fXxKIIn/68JVmRPV2Q8Jr1N601vpAOc02u9HmWML31nqdpWfs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR03MB4035
X-OriginatorOrg: citrix.com

T24gMjgvMDIvMjAyMiAxMDoyMCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE5vdCBldmVuIHRoZSB0
eXBlcyB3ZXJlIGNvcnJlY3QsDQoNCkh1aCB5ZXMuwqAgYy9zIDk3NjM4ZjA4ZjQgd2FzIHBsYWlu
IHdyb25nLg0KDQo+ICBsZXQgYWxvbmUgZGVmYXVsdHMgYmVpbmcgc3BlbGxlZCBvdXQgb3INCj4g
dGhlIHB1cnBvc2Ugb2YgdGhlIG9wdGlvbnMgYWN0dWFsbHkgbWVudGlvbmVkIGluIGFueSB3YXku
DQo+DQo+IFNpZ25lZC1vZmYtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4N
Cj4gLS0tIGEvZG9jcy9taXNjL3hlbi1jb21tYW5kLWxpbmUucGFuZG9jDQo+ICsrKyBiL2RvY3Mv
bWlzYy94ZW4tY29tbWFuZC1saW5lLnBhbmRvYw0KPiBAQCAtMTY4MSwxMCArMTY4MSwyMSBAQCBv
bmUgcGVuZGluZyBiaXQgdG8gYmUgYWxsb2NhdGVkLg0KPiAgRGVmYXVsdHMgdG8gMjAgYml0cyAo
dG8gY292ZXIgYXQgbW9zdCAxMDQ4NTc2IGludGVycnVwdHMpLg0KPiAgDQo+ICAjIyMgbWNlICh4
ODYpDQo+IC0+IGA9IDxpbnRlZ2VyPmANCj4gKz4gYD0gPGJvb2xlYW4+YA0KPiArDQo+ICs+IERl
ZmF1bHQ6IGB0cnVlYA0KPiArDQo+ICtBbGxvd3MgdG8gZGlzYWJsZSB0aGUgdXNlIG9mIE1hY2hp
bmUgQ2hlY2sgRXhjZXB0aW9ucy4gIE5vdGUgdGhhdCB0aGlzDQo+ICttYXkgcmVzdWx0IGluIHNp
bGVudCBzaHV0ZG93biBvZiB0aGUgc3lzdGVtIGluIGNhc2UgYW4gZXZlbnQgb2NjdXJzDQo+ICt3
aGljaCB3b3VsZCBoYXZlIHJlc3VsdGVkIGluIHJhaXNpbmcgYSBNYWNoaW5lIENoZWNrIEV4Y2Vw
dGlvbi4NCg0KVGhpcyBkZXNjcmlwdGlvbiBhcHBlYXJzIGJhY2t3YXJkcy7CoCBFcnJvcnMgaGFw
cGVuIGlycmVzcGVjdGl2ZSBvZiBNQ0UsDQphbmQgd2lsbCBieSBkZWZhdWx0IGNhdXNlIGEgc3lz
dGVtIHNodXRkb3duLg0KDQpNQ0Ugb2ZmZXJzIHRoZSBPUy9WTU0gc29tZSBhYmlsaXR5IHRvIGRl
YWwgd2l0aCBjZXJ0YWluDQpub3QtdG90YWxseS1mYXRhbCBlcnJvcnMgaW4gYSBsZXNzIGltcGFj
dGZ1bCB3YXkgdGhhbiBraWxsaW5nIHRoZSB3aG9sZQ0Kc3lzdGVtLsKgIEFsc28sIGl0IGFsbG93
cyByZXBvcnRpbmcgb2YgY29ycmVjdGVkIGVycm9ycyB3aGljaCBhcmUNCmluZGljYXRpdmUgb2Yg
ZmFpbGluZyBjb21wb25lbnRzLg0KDQpBbHNvLCBpdCdzIG5vdCBzaWxlbnQgLSB0aGUgTUNFIHJl
Z2lzdGVycyBleHBsaWNpdGx5IGRvbid0IGNsZWFyIG9uDQpyZXNldCBzbyB0aGV5IGNhbiBiZSBy
ZWNvdmVyZWQgYWZ0ZXIgd2FybSByZXNldC7CoCBGaXJtd2FyZSBjb2xsZWN0cw0KdGhlc2UgYW5k
IGlzIHN1cHBvc2VkIHRvIGRvIHNvbWV0aGluZyB1c2VmdWwgd2l0aCB0aGVtLCBhbHRob3VnaA0K
InVzZWZ1bCIgaXMgYSBtYXR0ZXIgb2Ygb3BpbmlvbiwgYW5kIGluIHNvbWUgY2FzZXMgZGVwZW5k
cyBvbiBob3cgbXVjaA0KZXh0cmEgeW91J3JlIHdpbGxpbmcgdG8gcGF5IHlvdXIgT0VNLg0KDQp+
QW5kcmV3DQo=


From xen-devel-bounces@lists.xenproject.org Mon Feb 28 13:31:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 13:31:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280558.478535 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOg7a-0007WR-1n; Mon, 28 Feb 2022 13:31:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280558.478535; Mon, 28 Feb 2022 13:31:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOg7Z-0007WK-TW; Mon, 28 Feb 2022 13:31:25 +0000
Received: by outflank-mailman (input) for mailman id 280558;
 Mon, 28 Feb 2022 13:31:24 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nOg7Y-0007WE-KX
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 13:31:24 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nOg7Y-00060P-9f; Mon, 28 Feb 2022 13:31:24 +0000
Received: from 54-240-197-230.amazon.com ([54.240.197.230]
 helo=[192.168.13.237]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nOg7Y-0003bH-3V; Mon, 28 Feb 2022 13:31:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=s/saPo8nAz1LL8LB1pQKEjNTvNJRdkcwepnM+DS8WZo=; b=HRYXWdZodSB5eX5oxW5KdYtun1
	hzHy8q+6LoDTLjWJidmNos+9gcGkWOSbOyjBgSHY0Q5SCOCJ9/Ofx3p+Z0DdBpv3xdKE+zM1UXqQ+
	6HHWuzUCbFHhAbXVvn1PgYC0qADDDjnDPQ4zgi9hZ6QeTxnmXceAKhJnkXIG1ih6PNSw=;
Message-ID: <3ad80c26-e093-f20e-4172-44368d918566@xen.org>
Date: Mon, 28 Feb 2022 13:31:21 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.1
Subject: Re: [PATCH] xen/arm32: head: Update the documentation for register
 r12
To: Michal Orzel <michal.orzel@arm.com>, xen-devel@lists.xenproject.org
Cc: Julien Grall <jgrall@amazon.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20220228101150.63816-1-julien@xen.org>
 <e9397250-3d68-d6e6-d95f-93d239fc2ef5@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <e9397250-3d68-d6e6-d95f-93d239fc2ef5@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit



On 28/02/2022 13:04, Michal Orzel wrote:
> Hi Julien,

Hi Michal,

Thank you for the review.

> 
> On 28.02.2022 11:11, Julien Grall wrote:
>> From: Julien Grall <jgrall@amazon.com>
>>
>> Since commit 54c4ae18d158 ("xen/arm32: head: Rework and document
>> launch()"), the boot code is not using the register r12.
>>
>> So update the documentation to show r12 has no specific purpose.
>>
>> Signed-off-by: Julien Grall <jgrall@amazon.com>
>> ---
>>   xen/arch/arm/arm32/head.S | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/xen/arch/arm/arm32/head.S b/xen/arch/arm/arm32/head.S
>> index 13cfc837d39c..78274a1c034f 100644
>> --- a/xen/arch/arm/arm32/head.S
>> +++ b/xen/arch/arm/arm32/head.S
>> @@ -79,7 +79,7 @@
>>    *   r9  - paddr(start)
>>    *   r10 - phys offset
>>    *   r11 - UART address
>> - *   r12 - is_secondary_cpu
>> + *   r12 -
>>    *   r13 - SP
>>    *   r14 - LR
>>    *   r15 - PC
>>
> 
> FWICS, there are still 2 instructions in this file assigning #0 or #1 to r12 and each of them
> has a comment "/* r12 := is_secondary_cpu */". >
> So I have 2 questions:
> 1. Do we even need these instructions? (I do not think so)

We don't need them. I will drop them and respin the patch.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Feb 28 13:35:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 13:35:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280565.478546 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOgBo-00089o-Ji; Mon, 28 Feb 2022 13:35:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280565.478546; Mon, 28 Feb 2022 13:35:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOgBo-00089h-F7; Mon, 28 Feb 2022 13:35:48 +0000
Received: by outflank-mailman (input) for mailman id 280565;
 Mon, 28 Feb 2022 13:35:47 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nOgBn-00089b-HQ
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 13:35:47 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nOgBn-000650-95; Mon, 28 Feb 2022 13:35:47 +0000
Received: from 54-240-197-232.amazon.com ([54.240.197.232]
 helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com)
 by xenbits.xenproject.org with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nOgBn-00044y-11; Mon, 28 Feb 2022 13:35:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:
	Subject:Cc:To:From; bh=Bn4hKvD9tCHF+9EbFmzzBxbr9GyN25lLdXJIPYnrD3g=; b=Dr8F1w
	cKuWsyhC+ytpO2SIPHUHY/3hQHUek69ei/AmJ/gE3lZmJtdyxIKf+LdH25c+WsSONqoxSiJsXBTX1
	dj+txc3Z46+WZcH5QKLKcIEv7fWOyNqT3YS2t2lBFEitZczZ943q8FSJ5myePkupJij3UXaWwXt8L
	d/q+tgZdXAA=;
From: Julien Grall <julien@xen.org>
To: xen-devel@lists.xenproject.org
Cc: michal.orzel@arm.com,
	Julien Grall <jgrall@amazon.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH v2] xen/arm32: head: Don't set r12 and update the documentation
Date: Mon, 28 Feb 2022 13:35:36 +0000
Message-Id: <20220228133536.57004-1-julien@xen.org>
X-Mailer: git-send-email 2.32.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Julien Grall <jgrall@amazon.com>

Since commit 54c4ae18d158 ("xen/arm32: head: Rework and document
launch()"), the boot code is setting r12 but not read it.

So remove the two instructions setting r12 and update the documentation
to show r12 has no specific purpose.

Signed-off-by: Julien Grall <jgrall@amazon.com>

---
    Changes in v2:
        - Don't set r12.
---
 xen/arch/arm/arm32/head.S | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/xen/arch/arm/arm32/head.S b/xen/arch/arm/arm32/head.S
index 13cfc837d39c..7a906167efca 100644
--- a/xen/arch/arm/arm32/head.S
+++ b/xen/arch/arm/arm32/head.S
@@ -79,7 +79,7 @@
  *   r9  - paddr(start)
  *   r10 - phys offset
  *   r11 - UART address
- *   r12 - is_secondary_cpu
+ *   r12 -
  *   r13 - SP
  *   r14 - LR
  *   r15 - PC
@@ -166,8 +166,6 @@ past_zImage:
 #endif
         PRINT("- Boot CPU booting -\r\n")
 
-        mov   r12, #0                /* r12 := is_secondary_cpu */
-
         bl    check_cpu_mode
         bl    cpu_init
         bl    create_page_tables
@@ -206,8 +204,6 @@ GLOBAL(init_secondary)
         adr   r9, start              /* r9  := paddr (start) */
         sub   r10, r9, r0            /* r10 := phys-offset */
 
-        mov   r12, #1                /* r12 := is_secondary_cpu */
-
         mrc   CP32(r1, MPIDR)
         bic   r7, r1, #(~MPIDR_HWID_MASK) /* Mask out flags to get CPU ID */
 
-- 
2.32.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 28 13:40:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 13:40:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280572.478557 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOgFs-0000QD-4T; Mon, 28 Feb 2022 13:40:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280572.478557; Mon, 28 Feb 2022 13:40:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOgFs-0000Q6-19; Mon, 28 Feb 2022 13:40:00 +0000
Received: by outflank-mailman (input) for mailman id 280572;
 Mon, 28 Feb 2022 13:39:58 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=py4b=TL=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1nOgFq-0000Q0-A1
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 13:39:58 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id ea1e127b-989b-11ec-8eba-a37418f5ba1a;
 Mon, 28 Feb 2022 14:39:57 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4BA671042;
 Mon, 28 Feb 2022 05:39:55 -0800 (PST)
Received: from [10.57.19.230] (unknown [10.57.19.230])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 353393F73D;
 Mon, 28 Feb 2022 05:39:54 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ea1e127b-989b-11ec-8eba-a37418f5ba1a
Subject: Re: [PATCH v2] xen/arm32: head: Don't set r12 and update the
 documentation
To: Julien Grall <julien@xen.org>, xen-devel@lists.xenproject.org
Cc: Julien Grall <jgrall@amazon.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20220228133536.57004-1-julien@xen.org>
From: Michal Orzel <michal.orzel@arm.com>
Message-ID: <33590325-765c-334e-27e9-f8e6122d6dad@arm.com>
Date: Mon, 28 Feb 2022 14:39:47 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20220228133536.57004-1-julien@xen.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

Hi Julien,

On 28.02.2022 14:35, Julien Grall wrote:
> From: Julien Grall <jgrall@amazon.com>
> 
> Since commit 54c4ae18d158 ("xen/arm32: head: Rework and document
> launch()"), the boot code is setting r12 but not read it.
> 
> So remove the two instructions setting r12 and update the documentation
> to show r12 has no specific purpose.
> 
> Signed-off-by: Julien Grall <jgrall@amazon.com>
> 
> ---
>     Changes in v2:
>         - Don't set r12.
> ---

Reviewed-by: Michal Orzel <michal.orzel@arm.com>

Cheers,
Michal


From xen-devel-bounces@lists.xenproject.org Mon Feb 28 13:53:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 13:53:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280579.478567 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOgSQ-0002ix-9A; Mon, 28 Feb 2022 13:52:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280579.478567; Mon, 28 Feb 2022 13:52:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOgSQ-0002iq-6E; Mon, 28 Feb 2022 13:52:58 +0000
Received: by outflank-mailman (input) for mailman id 280579;
 Mon, 28 Feb 2022 13:52:56 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nOgSO-0002ig-L2; Mon, 28 Feb 2022 13:52:56 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nOgSO-0006Lv-I4; Mon, 28 Feb 2022 13:52:56 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nOgSO-0002rw-23; Mon, 28 Feb 2022 13:52:56 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nOgSO-0002S7-1b; Mon, 28 Feb 2022 13:52:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=qtu9lSRUzzjRUVwCk1NIYZfnuS/0jPK5ItpkE6GPOsQ=; b=tvwtmi46JE+8+kXyan/qpXuVNV
	ED254znfZrDi1xPa3qhIbj4iOHug9Kka7ASHK4v3tYD7+F9EdnyExz/pLPdlXkDWGj7PznqmaTyTi
	cAhJa4lgAeV6DiPgQ/uN2aTBasLSPT+ArdGS94DfIagOI6GSywkt2t6jYXy2f7652LNI=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168254-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 168254: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70
X-Osstest-Versions-That:
    ovmf=f1d1c337e7c0575da7fd248b2dd9cffc755940df
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 28 Feb 2022 13:52:56 +0000

flight 168254 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168254/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 b1b89f9009f2390652e0061bd7b24fc40732bc70
baseline version:
 ovmf                 f1d1c337e7c0575da7fd248b2dd9cffc755940df

Last test of basis   168249  2022-02-28 03:11:49 Z    0 days
Testing same since   168254  2022-02-28 10:41:46 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Hao A Wu <hao.a.wu@intel.com>
  Tomas Pilar <quic_tpilar@quicinc.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   f1d1c337e7..b1b89f9009  b1b89f9009f2390652e0061bd7b24fc40732bc70 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Mon Feb 28 14:02:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 14:02:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280590.478579 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOgbb-0004KG-8C; Mon, 28 Feb 2022 14:02:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280590.478579; Mon, 28 Feb 2022 14:02:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOgbb-0004K9-55; Mon, 28 Feb 2022 14:02:27 +0000
Received: by outflank-mailman (input) for mailman id 280590;
 Mon, 28 Feb 2022 14:02:25 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nOgbZ-0004K3-5c
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 14:02:25 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nOgbY-0006cd-1k; Mon, 28 Feb 2022 14:02:24 +0000
Received: from 54-240-197-230.amazon.com ([54.240.197.230]
 helo=[192.168.13.237]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nOgbX-00066L-Rz; Mon, 28 Feb 2022 14:02:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=eSY0EQJWX7LYpS33CDc7DGxbbkpyTuOwp6VT+arYqDY=; b=SLx2DwkRhbOVBdJxdPryUxLIV8
	F8CQa3kPBJh3xRzjj8ip3k/5kTggGm3iQJZr0pDmaTMCl935lSGtr56nuG2CUG5Zeuoo79pnojIQH
	EQPCp9BO8CUl7uCQnaE6V2U7Z0GFyUDniLE8pllJb1pNlhH1CdHtkhA1yZ57w3L9/9xo=;
Message-ID: <4c087383-2f17-5af2-7c2f-77eb9aff9d3d@xen.org>
Date: Mon, 28 Feb 2022 14:02:22 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.1
Subject: Re: [PATCH] docs: correct "gnttab=" documented default
To: Jan Beulich <jbeulich@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
References: <3cc8bfca-be9e-cde8-c481-657ef33de7f2@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <3cc8bfca-be9e-cde8-c481-657ef33de7f2@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Jan,

On 28/02/2022 10:19, Jan Beulich wrote:
> Defaults differ for Arm and x86, not the least because of v2 not even
> being security supported on Arm.
> 
> Also drop a bogus sentence from gnttab_max_maptrack_frames, which was
> presumably mistakenly cloned from gnttab_max_frames (albeit even there
> what is being said is neither very precise nor very useful imo).
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 
> --- a/docs/misc/xen-command-line.pandoc
> +++ b/docs/misc/xen-command-line.pandoc
> @@ -1177,7 +1177,8 @@ Specify which console gdbstub should use
>   ### gnttab
>   > `= List of [ max-ver:<integer>, transitive=<bool>, transfer=<bool> ]`
>   
> -> Default: `gnttab=max-ver:2,transitive,transfer`
> +> Default (Arm): `gnttab=max-ver:1`
> +> Default (x86): `gnttab=max-ver:2,transitive,transfer`

AFAICT, the default would not be correct on x86 when CONFIG_PV=n because 
transfer is not available.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Feb 28 14:32:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 14:32:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280599.478589 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOh4e-0007ng-PY; Mon, 28 Feb 2022 14:32:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280599.478589; Mon, 28 Feb 2022 14:32:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOh4e-0007nZ-Mh; Mon, 28 Feb 2022 14:32:28 +0000
Received: by outflank-mailman (input) for mailman id 280599;
 Mon, 28 Feb 2022 14:32:27 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=A4HT=TL=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nOh4c-0007nT-Sg
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 14:32:27 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3d430d77-98a3-11ec-8539-5f4723681683;
 Mon, 28 Feb 2022 15:32:22 +0100 (CET)
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur03lp2050.outbound.protection.outlook.com [104.47.10.50]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-12-kojNmmaGN8CAbLLU3WlDHQ-1; Mon, 28 Feb 2022 15:32:23 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by HE1PR0402MB3465.eurprd04.prod.outlook.com (2603:10a6:7:80::30)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.24; Mon, 28 Feb
 2022 14:32:20 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.026; Mon, 28 Feb 2022
 14:32:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3d430d77-98a3-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1646058744;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=vd2JdSoXP9lWQu+CWQbnpJ20hEwgjF981/aNZDiOSTU=;
	b=GaHNOufpEoU2uPXh0WJx6fxXKvBrjQrJCvIXDVRA7mewCjpDEEwT1FxNkahfDCMKw3jPvH
	V4trzwvBk4r4oRTcZObkf6Vl9NK6gWhyPNLvDA4bHjmLna635R/1kWv90VOKonsGdEElqf
	6lCE94aqiagx+hdMkFo/SrfL1UjeXMQ=
X-MC-Unique: kojNmmaGN8CAbLLU3WlDHQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=g/e44fCYfhSZWFR8hwmh0J4WPV+b3h8GOrQRRHjZ14s2wxKj9clb208XPq3TzldywhK75T2S7Wt7Y65zFqIpKTmyMAP0R72WyiVMsKPWihXs6FeyoeJmMXUsquqhzvfpFysxCo6Nmwk6MGuAmh7OgIvZJvMhKgDm8/jp8sIk983n5G3s3UVDHHP8AUiaZ/fVPVLG4WDz4N+ypWmSn/5FqqhXnj8LKxoi9yOKaYAvwGYeNllG0aMlV8C8MqHLTZpayBfIPGKKDBjvee9eE5Nucyi0K367V0SaW76hHWM+AMpS+iAZ8xamr27qDujoQbf6rqeamrqAUheiZfYsk8Xutw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=vd2JdSoXP9lWQu+CWQbnpJ20hEwgjF981/aNZDiOSTU=;
 b=U+SKk1wv2Zj1mWpITSUE4yTs4uxU3X0M/Il3K/bU3seqoXr+zCx4pm06e2CZ6RJFxulFnd4ucQMBlRRq2mydFbGBtH/UU6x4FbewHFTyoZrv5arprKtmTbutc16O3+x5h2FjiMTJgLDaSMVlgG31qQriR9ohkJoxLXO8Yg4i4bRdium2TCOfAqAyo2+ggo+G31gwNqCPFs9qFC1SxDMBoVW8Kz0Dy8lse8LhkJHkhXVaH7KQJsdK9q8nShLIB2CTUr4QFg1zDfo3dYwqfR8eurjEAL/CKPUdn9hOzZfJbQft73sFAjSssan+MhkylgvXORKXTcXPdzs7CkyZ1yRmLg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <2025d913-acf9-d3f5-12ba-90b97e34eff2@suse.com>
Date: Mon, 28 Feb 2022 15:32:18 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH] docs: correct "gnttab=" documented default
Content-Language: en-US
To: Julien Grall <julien@xen.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <3cc8bfca-be9e-cde8-c481-657ef33de7f2@suse.com>
 <4c087383-2f17-5af2-7c2f-77eb9aff9d3d@xen.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <4c087383-2f17-5af2-7c2f-77eb9aff9d3d@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P193CA0041.EURP193.PROD.OUTLOOK.COM
 (2603:10a6:209:8e::18) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 156d8110-851a-47cc-19b7-08d9fac72096
X-MS-TrafficTypeDiagnostic: HE1PR0402MB3465:EE_
X-Microsoft-Antispam-PRVS:
	<HE1PR0402MB3465E492805863CB09E68818B3019@HE1PR0402MB3465.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	NXQRZPVas106U4bxdguwOeERT0yp2dTB3lHrk7gk+TcFj06TImof+TSB6piPRbl/X77xMyoyc6oEifaHjgd7KP5kb5vWMcZRVBQjmuqMDfa+gZU4F6O1ely2K+GTV+IvpOLrQz16K+lYdIm9AbWqvTnnrjIwW4qGBBPaYB6doQKqW2uR3GX0EaKJTI20r7TBauDDVCG+aSY3uR9MyDaQzKEq1PY4f7wN/DKKV5Lu3V+UjRl2xSUFJ+5K4lCsZqg+Yen4w9BJjE7382kDv3ohNyOgBLn45BszkHGp3QFahtD63o8yTnPNGwvj+DGXebYVwYm123rWd+sf823YXv3s2Cm+rseLvPJh12qQXZg52FHJ4P2u2l5wwDKnlPx6WcafWczJo1bnRoWGStCAG2tRuKEk4/xrMU9iupEvWuzivnmSioZ4qb+tz2TTZrRW4MINdajR9YwYM0cBx6KLNzpWXgu/MK80G1iAqco2TMRizYK2iUKu7BdhunXP6zDGqYvX86lWVrhvXx6CjsAjygALan3hF5ghvNAb8x7kdfxBjcNF0ghb0oT4EPPc8w7c2cy6tkKSIT2k1btgLEt+EVd6aHPLZAO6y2B1i3NbNVXSD/mm8o9W75wtpaNYtEPGFkWUMD18fqnU72Wt88nWgI8G2MtFa5DnrrjRAVlEpXxTl4kL+QynsPgaHZQ3DBW2N7QC7PgYVxSrd1a2OSUMkdtByxN2rmEhxLKQJhPtwqKcplY=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8936002)(26005)(83380400001)(31696002)(53546011)(86362001)(6512007)(6506007)(6486002)(2906002)(186003)(508600001)(8676002)(5660300002)(2616005)(6916009)(31686004)(4326008)(36756003)(38100700002)(66556008)(66946007)(54906003)(316002)(66476007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?T1BKVG5OYW5adk83L25NbFVCRysweVFHTXpya1ZYWGRmTnpVQjZYUGJwZXpt?=
 =?utf-8?B?Yy9SRFlBMlNMQXVkWlI0U1BCZmdpdzIvTFkxcVhXM2FXYzB4VDVJT2NGd0Rl?=
 =?utf-8?B?Yit5RjM0QnRVZ1JyY25WQUtKTUY2Mk9sWHo5bzR5NEQxd0t2cSt2amxkV0NG?=
 =?utf-8?B?K1ZTeHE4U3cxbTVlQTQxMEJVWW5OcUZPTkFRa0JDT0pIYlhtaENCTkVLMnJS?=
 =?utf-8?B?Q0cxcmZMK0xRT2s5K21tdk9maTRZUVFRamVTS2dTaS90bWdSRTBVOUxEaTc3?=
 =?utf-8?B?RG5hMFJ4Rzk2b1hsK0thSzJTYnFyZVV0M3BGdjd5TXZSSWJ6VUlGOHdMeTk5?=
 =?utf-8?B?UVlOdmx4YUQwaXJnYVl0UEVCc2pQdzNmcDFWZjZmams0TTA2aWs2eCtMa28x?=
 =?utf-8?B?MUF5OTFmSGc0Tzk2QVhJaUZqazlFaXBzOXFWU3hzckd2OFlGTVYrUStmM1ZG?=
 =?utf-8?B?eXo0Q0o1VXQzSW1jQllPTFVwMXV2L3J0b0U0ZGJtcVo4SWZsMmNmcGVndUg2?=
 =?utf-8?B?V2hGcDduUUd2dXpYR3ZxK2pUNFQ5UW9kR25WZDIzRzRYTlpuMEM4K0dIeEZU?=
 =?utf-8?B?OTk2aUU4SHY4ZFJzNjIzWFJBR0NtUDJXQ3ZGTzJrcUxVZldqakpoL0sxWTVE?=
 =?utf-8?B?dW5ZMHNLOC9oTnhKOGx4Mjh4WjJBSzI3b0FFQTRuTmszUU41djZZUEhBSHVk?=
 =?utf-8?B?ZHl4TEVFa3lXcGtQYVZwZjhaWnR3OW9kS21SZkx0TVZlN2s0ZHZiY0MzQXV0?=
 =?utf-8?B?dEJKOHlyVzhJT04wRkd5VlpkNVlRai90aFc2YWgwTWRBVDV5WnNEYS83QU4z?=
 =?utf-8?B?aWVBOVdSOE1zTFloQkQ4YlpKeG5SWUNhRk04bjRLRTAzWnZlbW80WFN3ZVYr?=
 =?utf-8?B?OW5RZTgrZGh1bTJXRDRKb21FcUdNM0wxQUxGVHJoNU5PZHp5YXZHUnhPcWJx?=
 =?utf-8?B?Nm9EZ3BPRGtPdzFOdFl0bkRlMkpTYVBCaWNaU1NFM2N5eERweCsvSGVZUGhz?=
 =?utf-8?B?SC9mN1owUzFleUIrUlJEZ0hnR2tZd01OMFlVYmxlaEhHMWpGK2tBZEtRZGkr?=
 =?utf-8?B?Zmh2TU5YYTB4MUJDcnJnR2dxZEJYNTRQMG9RZlZaZjlmT25EODNJK3UvamEx?=
 =?utf-8?B?c3VrRk9GL3hGbENvVWsxSUZVU0JvVXZkN0R3elBVUjhiekRlemorMS9UT3Bi?=
 =?utf-8?B?MjY3dnY4VkpIV2h3ZGhqdFUzb2RBZi94UkVBaEROeWlSMWgrTk1mdzUyTnB3?=
 =?utf-8?B?YkxabXJTOThsVWoxTmIrbmhhSzlJS3h6K09JN1JIK3AyVUtnc0NJMlB5eHBH?=
 =?utf-8?B?cHF1M1FXOGdKeWxuQ0tnUDJrTkFCeEs2Wis3bUhiLzNpOStkenRxeFAzUGpu?=
 =?utf-8?B?clFaMmxRRnkvWHErYnFYTnRjRVBkMmJQSWJYcGROUUZSU0g2b1d1T1E2OEtn?=
 =?utf-8?B?eVdSR3pvRjQ2Nlh6TFJjMUdzaTJKaTRCcDhIWGZ3V2JTSG12UGJwZGFPNDJJ?=
 =?utf-8?B?TUl1cTY3KzZwdXV2M1dLMHRjTWZpRW9BV2thNXJndDhsa2lrS3MyQXJvb0Iz?=
 =?utf-8?B?YmY4aHl1cXBxeDRITUlEYkJiUjFReWxoRDdEa3htbHBTZFRJTkJiWDRDMFkv?=
 =?utf-8?B?RUdzdGxKQU1QVGNpK3R6Sk1qNjRmNjBBeU44bEhCRjVvdmwxUFV0cTZLU051?=
 =?utf-8?B?L3Q3Wk5IaXpzRnpUSzNyemVTYUMwdER4SnY0RXNPWDVuZ2V5cGtJbDhqMVNl?=
 =?utf-8?B?c0hUeW03T2MzeHljaWZieFloRUt4MjFBQnJRcnpzN1dONExOQ3JNWHVnV2Vk?=
 =?utf-8?B?a0gyekRzZHFHUmlOVm51eUJFNGNYa3RPQWZ2bEJpQjR3NWRHOW9lUFhwOEJq?=
 =?utf-8?B?bGxQNmVSYi9UWCtFeko4TXgxVFkzSVIxRml4NGcyNkx4ZURiNlFYeFBnZ1p4?=
 =?utf-8?B?YjdwS3liVENuK09lM1NuK1RaWHBieTJ0b28yUy9nQytaeUhTQ3hTc0R6YzYr?=
 =?utf-8?B?bTZEMUg0TW0yU0dUWDU4M0JyaUNtS2NaaEkrK0MyUXlFckx1QTM3YWJBeUdm?=
 =?utf-8?B?UFJUR0xyOGNpNTZMaVdkeGJoTC9vVngvWFVaTVovMUlEQUUwa1lSdXNPMzV5?=
 =?utf-8?B?cFZnWS9pVXR6OXI1elMwcjcyK1BGdC9oWFo1VnltaEhWa0x5MGl1MlU0bjhx?=
 =?utf-8?Q?1tMMASX5weDi7FtWSC6Vjvc=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 156d8110-851a-47cc-19b7-08d9fac72096
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2022 14:32:20.4435
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: s1k8kwLlsVKmGlWJlliXwNTBrpyBC+06G7OvDUvZPADY/lmuqxPb2iMi3C0LRyGo+uAh0+e4o7pFArn3ungsQA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0402MB3465

On 28.02.2022 15:02, Julien Grall wrote:
> On 28/02/2022 10:19, Jan Beulich wrote:
>> Defaults differ for Arm and x86, not the least because of v2 not even
>> being security supported on Arm.
>>
>> Also drop a bogus sentence from gnttab_max_maptrack_frames, which was
>> presumably mistakenly cloned from gnttab_max_frames (albeit even there
>> what is being said is neither very precise nor very useful imo).
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>>
>> --- a/docs/misc/xen-command-line.pandoc
>> +++ b/docs/misc/xen-command-line.pandoc
>> @@ -1177,7 +1177,8 @@ Specify which console gdbstub should use
>>   ### gnttab
>>   > `= List of [ max-ver:<integer>, transitive=<bool>, transfer=<bool> ]`
>>   
>> -> Default: `gnttab=max-ver:2,transitive,transfer`
>> +> Default (Arm): `gnttab=max-ver:1`
>> +> Default (x86): `gnttab=max-ver:2,transitive,transfer`
> 
> AFAICT, the default would not be correct on x86 when CONFIG_PV=n because 
> transfer is not available.

I can certainly split it in two x86 lines, one for PV and one for HVM.
I would not have thought I need to go that far, though.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 28 14:38:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 14:38:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280606.478601 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOhAA-00005K-Dn; Mon, 28 Feb 2022 14:38:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280606.478601; Mon, 28 Feb 2022 14:38:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOhAA-00005D-Aj; Mon, 28 Feb 2022 14:38:10 +0000
Received: by outflank-mailman (input) for mailman id 280606;
 Mon, 28 Feb 2022 14:38:09 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=A4HT=TL=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nOhA9-000053-7u
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 14:38:09 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0a21dc4a-98a4-11ec-8539-5f4723681683;
 Mon, 28 Feb 2022 15:38:05 +0100 (CET)
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2052.outbound.protection.outlook.com [104.47.1.52]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-28-0ASX9lpgNSeEQVB0rH4C0Q-1; Mon, 28 Feb 2022 15:38:06 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM0PR0402MB3569.eurprd04.prod.outlook.com (2603:10a6:208:19::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.26; Mon, 28 Feb
 2022 14:38:04 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.026; Mon, 28 Feb 2022
 14:38:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0a21dc4a-98a4-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1646059087;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=oXMtB/ECejQSvXc1GC/abYioSSjm0LoFOvfzTJEEUf0=;
	b=eL2t3oVPW01dbFs6grCP+TjKfNZi9n3GWSg00QLMbbYLVDXQKxq2hGEcdbnhbZF0rD9mAl
	pYbP0OIHkJOGLMO0/ANzKqvhi+Owwn1UHvzvfVxHOUdJOHZ9aABvm0fhWBf+sy1nlxUTA6
	Q1pw24Ur2Tiv3cTGG//dOGMDP+d3sUo=
X-MC-Unique: 0ASX9lpgNSeEQVB0rH4C0Q-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=hZKWZBNgg2nIE8d4u3jdNUB6hKwFh0xb3xQZdOjMX83d5GyUfiI3213ZwtAbHMFkoVTivmsHqGbGdwHd8tGzcx3WakqD3b7DVvU6Ha/szCea7XZnTfBm7FynkF1SWUW6pQ7hsuz6gz2qq/VsPYlKmMhKm6thffdPjOBtjM7EY8AjkHHj9P7Uku2phBZs8PIeqWBV+uDgfecpo71itGE9/FN0XmMvYxUHt1d5N//rez8JSGe5niXSZFO1BYfNeLZtiZeQ5IZIFLeevJJsr4EeXvRcH/rGiaxaoYYX3OiEuH0ChCFe2+e8XzEO7DZsMPBsmV2TjAzZnBrbSyOb7NB1WQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=iuLsF1Lvk7Bho76Bk7zofN0M25wY90SZ5v8n1nERvZM=;
 b=AOSTCjKItAQsLMbDIHPau1Ud47/PizPntbvTlCyMSnDfG2yJNGprCud4XToDep9phqAZdAM4gU4Y4s41y1UPg9GFDC1k+3wUNZd54uAiWret3MWnZgO20ze4GNkAy1dxbil4tErGE7YKVETqAI7egXkGtj4iBgc3zwqHlhfjK4BEmC0JaC/2IS0oLilo9k7zggltRLzqKxJIcqtFDdq/hjABn4f3vRtPbqfqMOx1kkf9MMtYfTSOtBKt74J8OC7xJvCZ/nbKd3h44OpMSIkTsaoj2+3fz7X+K0YcC5d7+U6oerJYR6r35tx9LQm5NkV48kArLjqOMu0TAd8TEY2AtA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <c561767d-0945-7fd8-72f7-762480d98e9f@suse.com>
Date: Mon, 28 Feb 2022 15:38:02 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH] docs: correct x86 MCE command line option info
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
CC: George Dunlap <George.Dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Roger Pau Monne <roger.pau@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <329ac1cc-85d4-7ec0-a23d-a3f68c2864f4@suse.com>
 <81337ddc-afe4-ba82-9495-3f74c53e7041@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <81337ddc-afe4-ba82-9495-3f74c53e7041@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9P194CA0029.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:20b:46d::35) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: fd28f77e-c8a7-45bf-88e2-08d9fac7ed93
X-MS-TrafficTypeDiagnostic: AM0PR0402MB3569:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR0402MB3569C7DC288E922DF74BB06FB3019@AM0PR0402MB3569.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ZScGGQHaXvpc61wezYxfwhs803BL0/Ee6IqOBqFYr/brRLSJRfA60nzUV7k8wymokPB80sZBEEu50cQx5OFJDAlerfCa5784idbfFson+WNEJ63oMSI52VehKeGMAGToNahTuJj7jcst7hZTDbqJccrKiv+iZntnWuzVeNuVPWa7VeYkx1crK24UjQINmIxhrrzmB2ozkbe/sVGjc6SP5ckwAQmPsH9kBMDIeeLWK4zktfDLdtsnVbaVsIvhVPCGAOZXsKrMptL3WEz8kl4g1xp6Rwg9CVZlLSZeTg+7/e4Pc+GeCUI4NsvJipX0FXQynaBi0BRw5hQtfvaTsS97VjQID0RSTz2H7LI9Fl/0VM5pZzYIUmu6yD7Z2iSx9jl4uA7VRDgqxSzg+fQPsmrhHhYMdG1E/NQvkNabvV1D2k4SwCx08Gm/WiV7kLR40iyky3IfgXUicgWnXWXKA40w62nQ3n5RAM9ls5f7YG26yj173irRghA8gB36HgKmAtzWQPgH7BDqNuIvJGrL0o3SrVIbfN/o54YAZnCKW2j1Mz2cifN85XRjRCx76YfR2ICBjnVeliFLQA0Uc7gL7sWY6wNijzc1NOQMylNtCpCQC04LSzuwKSppro89Wtyl1cQP8JietWDrdoB2DIUsDCGlYGo9yAjGuw6jz9VGJTKnVvxUS4IwugfoymHd1VLROD+xwkzMwJegYx9otL/NYiCa+Ft6dLMsIQGQpKToVbAXXBMNwkNmGmwqcPKo+jrrGfUw
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(26005)(186003)(38100700002)(86362001)(66946007)(6486002)(66556008)(66476007)(508600001)(36756003)(2906002)(54906003)(8676002)(31686004)(316002)(4326008)(6916009)(31696002)(6512007)(5660300002)(2616005)(53546011)(8936002)(6506007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?hGse24CUs6Hc8sBmOxmJAz4cIsSCxFm8PGu3ca2UyXrqBUJgfSYXmRf62XAJ?=
 =?us-ascii?Q?WWYFfGIFiNzWBOorVYmegknc6W7Iavl12XDfXRLshkkT5rd38LCtMecaJqHI?=
 =?us-ascii?Q?sUE9WbxVg+Y/f5hvTeQ3DcHGjp7e47M12F913ixqAz4uI9Ql2N9zHtmOY+kz?=
 =?us-ascii?Q?AFbE0mFb1ZcprE3nZMnKnS5J6qMxhYXehp4N1eO4+DT8+2ixhdUp1Ne/oYnF?=
 =?us-ascii?Q?uD5l8LOPsS3QowK0IsxKEQc4+CGyVUqrXn14dVTYwmryUymbD2/tXrbDVMBb?=
 =?us-ascii?Q?2T1ZKJzZo3PObSpJLwlSZsmw2Nuevp0LtAuW6WH5TeRfS0ivnk9ZPrRoItlP?=
 =?us-ascii?Q?cxKuuoPPEPWDpcWdMnMLaC+VjIbZ4EmHlKYQ1xCInsYmc3DRUFvNrMTt7clH?=
 =?us-ascii?Q?iHZ2a11W02Ofde3tF1uBRomQ29xZ632nZiLRrDKbKPYYfDj8tKeJ7cXwv8KW?=
 =?us-ascii?Q?ZqyMgu9KXuchWAdAi+fy9UzYXoa3xhgYHIXiLZ71roEuJmTSRC+ZabWzyIsf?=
 =?us-ascii?Q?C1CzC/z7dmqi/xpUwb4ZiKxPnO2XblKojjFe+HOLQJa85j79DX7SckkGtW3c?=
 =?us-ascii?Q?N7uGD5GWtOz1gZZrMtcav46TnHiMX7UT4MOUtWmAC1AkFRAhaRbwQvQKVBM+?=
 =?us-ascii?Q?cDCS9KwbPr5lw5B80hQezObp9zGskpkqrI3w1GfC6fSajzAc3NDrRNs9uwdg?=
 =?us-ascii?Q?zHWvwabhtDo1a6XMrx6PWjm6cbm3HVAYGlwZmNrNCvPboBqaeWCYH5C/1lvI?=
 =?us-ascii?Q?7N51/JPloq08xtWxlB8IfdttmH6vCmOvVXaAE0aBm+5PL6bOnuM6NbZker33?=
 =?us-ascii?Q?PUv6yGFeme6BoRPI9jlqwBImB3C1jCU4j4ssg3AYHTSowUHdvLwer3n0NeFY?=
 =?us-ascii?Q?E6KGFClw8AsCEzgkC47gQrqa12Knz8Vt6jakr9ZDca8bIcn2avSH/ezdKpnc?=
 =?us-ascii?Q?fCG+lNrBjV/jNcJxNegWV82K0lAIRM0m+AWL11IN440Po8lvwZFasNTh4s6F?=
 =?us-ascii?Q?QHweFa1hZn/O0CL00s+1sSiXw2ZDPHls5rGpDIpC/UK/jtIKRe3XAfbYV+uP?=
 =?us-ascii?Q?PMCP1pKOf0GsJEMV6bYFZ5EPXJPxRDyBOR0Li8JfIa8JPpVKGMm2JzrCRkZk?=
 =?us-ascii?Q?6M7zfEC+m+5eMqczZ4E3U47ShpJc6+Rub0/mBzYcJrI4rg+s8AAic22NSOim?=
 =?us-ascii?Q?YtNV9UvELSsxjRHbP0ZOfqBv0a82NdbK7j1VFSmGPpvY6Cf4QrUJLVb7XtIs?=
 =?us-ascii?Q?Uhdc/bwuKQShXGwIW4rT1g/ZMm/jXeyfOsbr0tCqwWGuKVTO6eL1MVigX9li?=
 =?us-ascii?Q?mEb50h0zNACxjM8S0Kg4AfQZ6uoaFPzQRqLNzYvVbe2VRpTMnrq26xqXvh5O?=
 =?us-ascii?Q?nwDl3w3bpqqHkUy32vDcxVbEPzd0g+FZGmcjJlP9VjdyfOipxOPy/3FmsME0?=
 =?us-ascii?Q?8LZkuJCbiv3phAH5aGuiD6gPsqGs3wgtHIblEb5l17qiT94L9d8QF5ua3Fu/?=
 =?us-ascii?Q?AQ3AryAxuIQleQnZszNwW/OC2BNvI0uFPILSXE3ugXaogMoc6pvjFTukshB8?=
 =?us-ascii?Q?nRYc4VBxF34tVAW1FQOJK1JGfdwEvSdPewrhhQgKa2YWWpwTzNsWHQbgUSwu?=
 =?us-ascii?Q?67xvZYGWFL//HSx2lnohyP0=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fd28f77e-c8a7-45bf-88e2-08d9fac7ed93
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2022 14:38:04.3284
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: v0x50vhuoMYaECw1QGTPC1RFdAP5eLnup0zwp60H914DyMfYXhsjrClMnRDyyIaa46qRpRGC78bJxhlzPuMxqQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0402MB3569

On 28.02.2022 14:19, Andrew Cooper wrote:
> On 28/02/2022 10:20, Jan Beulich wrote:
>> Not even the types were correct,
>=20
> Huh yes.=C2=A0 c/s 97638f08f4 was plain wrong.
>=20
>>  let alone defaults being spelled out or
>> the purpose of the options actually mentioned in any way.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>>
>> --- a/docs/misc/xen-command-line.pandoc
>> +++ b/docs/misc/xen-command-line.pandoc
>> @@ -1681,10 +1681,21 @@ one pending bit to be allocated.
>>  Defaults to 20 bits (to cover at most 1048576 interrupts).
>> =20
>>  ### mce (x86)
>> -> `=3D <integer>`
>> +> `=3D <boolean>`
>> +
>> +> Default: `true`
>> +
>> +Allows to disable the use of Machine Check Exceptions.  Note that this
>> +may result in silent shutdown of the system in case an event occurs
>> +which would have resulted in raising a Machine Check Exception.
>=20
> This description appears backwards.=C2=A0 Errors happen irrespective of M=
CE,
> and will by default cause a system shutdown.

Of course. Would s/this/doing so/ make things more clear? It was certainly
meant that way.

> MCE offers the OS/VMM some ability to deal with certain
> not-totally-fatal errors in a less impactful way than killing the whole
> system.=C2=A0 Also, it allows reporting of corrected errors which are
> indicative of failing components.
>=20
> Also, it's not silent - the MCE registers explicitly don't clear on
> reset so they can be recovered after warm reset.=C2=A0 Firmware collects
> these and is supposed to do something useful with them, although
> "useful" is a matter of opinion, and in some cases depends on how much
> extra you're willing to pay your OEM.

It's still silent as far as Xen disappearing goes. Whether firmware
properly collects and exposes the data isn't something we ought to be
concerned of. If some _simple_ adjustment is going to meet your
approval, I'll be happy to make such an adjustment. If you suggest I
explain machine check machinery here, then I'll simply withdraw the
patch.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 28 14:44:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 14:44:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280613.478612 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOhG2-0001Uf-3k; Mon, 28 Feb 2022 14:44:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280613.478612; Mon, 28 Feb 2022 14:44:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOhG2-0001UY-0d; Mon, 28 Feb 2022 14:44:14 +0000
Received: by outflank-mailman (input) for mailman id 280613;
 Mon, 28 Feb 2022 14:44:12 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nOhG0-0001US-Nm
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 14:44:12 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nOhFy-0007Ib-4t; Mon, 28 Feb 2022 14:44:10 +0000
Received: from 54-240-197-230.amazon.com ([54.240.197.230]
 helo=[192.168.13.237]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nOhFx-0000wx-VN; Mon, 28 Feb 2022 14:44:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=/N0hQt8aoJ6emt33l98XsvOxjPlTQBPCJCiT8gs0f8M=; b=QtS1NGysuwsFAvZ1whI78XJxk6
	YfqKxmPcQUzP8zINYKqno1e/bwBqsHfMbs1xbLeJ43bAqQJC+90GOZ2Zk88hkTi4q/dOfUxhhR8uW
	C7QtvUU6VO6PeZqRxNSgEcNgQk80O9UFqb2oD8X6Zz5TI/b39PZjxSuZiNO32cBfQmZA=;
Message-ID: <4ef27101-9057-6667-e017-fd2d830c942b@xen.org>
Date: Mon, 28 Feb 2022 14:44:08 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.1
Subject: Re: [PATCH] docs: correct "gnttab=" documented default
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <3cc8bfca-be9e-cde8-c481-657ef33de7f2@suse.com>
 <4c087383-2f17-5af2-7c2f-77eb9aff9d3d@xen.org>
 <2025d913-acf9-d3f5-12ba-90b97e34eff2@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <2025d913-acf9-d3f5-12ba-90b97e34eff2@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Jan,

On 28/02/2022 14:32, Jan Beulich wrote:
> On 28.02.2022 15:02, Julien Grall wrote:
>> On 28/02/2022 10:19, Jan Beulich wrote:
>>> Defaults differ for Arm and x86, not the least because of v2 not even
>>> being security supported on Arm.
>>>
>>> Also drop a bogus sentence from gnttab_max_maptrack_frames, which was
>>> presumably mistakenly cloned from gnttab_max_frames (albeit even there
>>> what is being said is neither very precise nor very useful imo).
>>>
>>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>>>
>>> --- a/docs/misc/xen-command-line.pandoc
>>> +++ b/docs/misc/xen-command-line.pandoc
>>> @@ -1177,7 +1177,8 @@ Specify which console gdbstub should use
>>>    ### gnttab
>>>    > `= List of [ max-ver:<integer>, transitive=<bool>, transfer=<bool> ]`
>>>    
>>> -> Default: `gnttab=max-ver:2,transitive,transfer`
>>> +> Default (Arm): `gnttab=max-ver:1`
>>> +> Default (x86): `gnttab=max-ver:2,transitive,transfer`
>>
>> AFAICT, the default would not be correct on x86 when CONFIG_PV=n because
>> transfer is not available.
> 
> I can certainly split it in two x86 lines, one for PV and one for HVM.
> I would not have thought I need to go that far, though.

I thought I would mention it because to me it feels odd to correct the 
default on Arm but keep the x86 one potentially inacurrate.

Anyway, I am ok if you prefer to keep it like that. This is already an 
improvement for Arm:

Acked-by: Julien Grall <jgrall@amazon.com>

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Feb 28 14:46:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 14:46:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280619.478623 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOhIP-0002C8-Hg; Mon, 28 Feb 2022 14:46:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280619.478623; Mon, 28 Feb 2022 14:46:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOhIP-0002C1-EN; Mon, 28 Feb 2022 14:46:41 +0000
Received: by outflank-mailman (input) for mailman id 280619;
 Mon, 28 Feb 2022 14:46:40 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=4KYl=TL=citrix.com=prvs=051d3ddbf=George.Dunlap@srs-se1.protection.inumbo.net>)
 id 1nOhIO-0002Bu-H6
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 14:46:40 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 3ad6cc3b-98a5-11ec-8eba-a37418f5ba1a;
 Mon, 28 Feb 2022 15:46:38 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3ad6cc3b-98a5-11ec-8eba-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1646059598;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:mime-version;
  bh=CRQHGiYeqc0Wu0GmB4mipEgrtqt/vOWrKIatVZMfaMQ=;
  b=JlVIoZQtMjhuWdaIPUEqIayzaRzM5Z9mNR+aSocxl80R0Oqgj9RGstgh
   xGTUxmvz7Zz7pAXW/SKdqiDsS3NZ3VYXKnVd0S+KoxEmjyhGiGSccLODR
   l9MGXpjNAtB9gjPkWRc1Q97Be2wFUW+7lXclgMfQTHoAxEIUOZrxtwkVp
   A=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=hardfail (body hash did not verify [final]) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 67408518
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:oncBt6AH25u43BVW/3Lkw5YqxClBgxIJ4kV8jC+esDiIYAhSlGxQk
 DNbHCvTJK7JMVJBSKkiYYvi9RkF7MTQydAwGQU4qSoyEH8a+ZGZXoSTfkr6ZyieIJGcFhs3t
 JoTN4SQfck6QHONqh2kPunq9iJwiPHVLlaQ5JYoHwgoLeMzYHtx2XqP4tIEv7OEoeRVIiuDt
 YqurZLWYw/4hTV/PG9F5vqK8UI1t6mqsW4TswRmOKEXsAfSmUdOAcNEL8ldDZdZrqq4vAKeb
 7yepF1s1jqBp3/BMvv8zvCjNBdirof6ZWBisFIPM0SZqkUE93RaPpoTbqJGMx8N0WXRxrid9
 f0W3XCOYVZxVkHzsLx1vylwS0mS6oUfpdcriVDm2SCi5xWun0nEmp2CP2lvVWEswc5lAHkmy
 BAtAGtlgiZvJQ6B6OnTpuFE3qzPJSRwVW8VkikIITrxVZ7KTX1fKkljCBAxMDoY36hz8fjii
 8UxaT82dB3JQxl1PE5HJc0ewvvruFX+bGgNwL6VjfJfD2n7yQVw1P7mMcbPe8zMTsJQ9qqaj
 juYpSKjWEhcbYHBj2remp6vrrancSfTd48VDrK1sNJ3hlma3kQYCQEMVEv9qv684qK7c4wAd
 xREp3N+xUQ03Ba5UNvRWweVmUW75gczed5uDtAI8ijYn8I45C7GXzNZH1atcucOttIyRDEs/
 k+EmZXuHzMHmKaOVXuX+7OQrDWzESsYN2kPYWkDVwRty8bniJE+iFTIVNkLOL64iJj5FC/9x
 xiOrTMinPMDgMgTzaK58FvbxTW2qfDhTAQ4+wHWVWKN9R5iaciuYInAwVnE795QIYCBVF6Ds
 XMY3c+E44gmBpaIkS2RXOgXB5m56vCdKjrejFVzWZ47+FyQF2WLJN4KpmskfQEwb5hCKWSBj
 FLvVR155JoKJHKjTatNZZvhJpsKk7SjK/jkSaWBBjZRWaRZeAiC9SBoQEef2WHxjUQh+Z0C1
 YenndWEVihDV/k+pNaib6JEiOJwmHhirY/Gbc2jl3yaPayiiGl5oFvvGH+HdagH4ayNu205G
 P4PZpLRm32zvAATCxQ7ELL/z3hXdxDX5ris8qS7k9JvxCI8RQnN7NeLnNscl3RNxfg9qwsx1
 ijVtrVk4FT+n2bbDg6Bd2pubrjiNb4m8y5mbHxzZA/0hSBzCWpK0Ev5X8FqFVXA3LY+pcOYs
 tFfI5nQahixYm6vF8shgWnV89U5KUXDafOmNCu5ejkvF6OMtCSSkuIIijDHrXFUZgLu7JNWi
 +T5imvzHMpSLyw/XZ2+QK/+kDuMUY01xbsas73geYIIJi0BMeFCdkTMsxPAC5pUeEWbm2DDj
 F7+7NVxjbClnrLZOeLh2Mish4yoD/F/DgxdGWza5qyxLi7U4iyoxooobQpCVWq1uL/ckEl6W
 dho8g==
IronPort-HdrOrdr: A9a23:ayjGBaoiCdzS5yepFGhAS4QaV5uaL9V00zEX/kB9WHVpm5Oj+P
 xGzc526farslsssSkb6K290KnpewK4yXcH2/hsAV7CZnirhILMFu9fBOTZskTd8kHFh41gPO
 JbAtJD4b7LfBdHZKTBkXGF+r8bqbHtmsHJuQ6d9QYXcegDUdA40+4TMHf+LqQCfnghOXNPLu
 v62iMonUvDRV0nKuCAQlUVVenKoNPG0Lj8ZwQdOhIh4A6SyRu19b/TCXGjr1kjegIK5Y1n3X
 nOkgT/6Knmmeq80AXg22ja6IkTsMf9y+FEGNeHhqEuW3TRY0eTFcRcso+5zXIISdKUmRMXeR
 730lMd1vFImjDsl6eO0FzQMkfboXATAjTZuCClaDPY0LLErXQBepJ8bMtiA2vkwltls9dm3K
 1R2WWF85JREBPbhSz4o8PFThdwiyOP0DEfeX56tQ0vbWIyUs4ZkWUkxjIcLH7AJlOP1Kk3VO
 11SM3M7vdfdl2XK3jfo2l02dSpGnA+BA2PTEQOstGcl2E+pgE182IIgMgE2nsQ/pM0TJdJo+
 zCL6RzjblLCssbd7h0CusNSda+TmbNXRXPOmSPJkmPLtBMB1vd75rspLkl7uCjf5IFiJM0hZ
 TaSVtd8XU/fkr/YPf+qqGjMiq9N1lVcQ6duP22vaIJyYEUbICbRBG+dA==
X-IronPort-AV: E=Sophos;i="5.90,142,1643691600"; 
   d="asc'?scan'208";a="67408518"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=TOGlXqWHOWjx8DQXlSh1i756612//yKPez9mSlqDUX+qw5yLgZW+xZ+oZoEKQgY2+X78ha9gmm90RnPNd4zr5413HwsM/3Ity3LdB3vLe5OQqm/TmqZWkJDB5eoFXrP1d/VmFUAeclApkBOOTqds28vYrZRsk0wsr36bRsItU64VvVft/u3hDxN1d2hDsU1hyeeR1t60A5yfAwXCPLgmuQvKuTUGzEQ2sXNmoclTWEorlfucF07CXnsyoR6o6kBKjVgsTfzXscmW2oNyKbUSIa4Ww3LLC5+bui68/XnjwoKwt+IPR32N6dv0f59wU9ll9w4PGrMoY2dJzSvg6WI7SQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=HjS/we3L3lPcknD5mglPZ+bO1PDKFjyeFBW3U618erM=;
 b=TMCXNhXLcQcphnWWqmCrBvETJzc3py3yyXCDL2exJZcjelSt8Wa7Vxcy1K9+JweNniIDYh6gK3xHMXn1w0BguGdKZBzASFxXBTc+4xngzmwN60fj0cKEy4N+B7sVQpRikKogpFyF8jA4ZXr7dn57ySDlq+GHNIKECfOAKlVUL8fS7dBWc7+IqHENYxVJXnENAscSPRmQ+Dwdg4HLS+Fqmh1WZUWEEv25xMLZ04NueSjSvu3uUaekQkuubrN9CZc2pDd6d2hGp0oq+0aIvaloDsYZxTo9+n4rzaudi3FybzyqumYLAAh7Z8e1VD2fqDnABZ62Nmmx83hCq7DkGlUMhA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=HjS/we3L3lPcknD5mglPZ+bO1PDKFjyeFBW3U618erM=;
 b=i7HQDwaIa2IDQSMNh0rqBTntwtqYwxKAs5VI3/7IWSfOaPdSJ+zQCm5Q6iF5u93SvIF0a/THcRcSapNrCX5FNKAidCN3O1R32KrmNvFeK+4jNqSenKopONkPTLyujRUx7MePrX+ZIgIfwQ9/5oEK4ddWtolyuxAQRfLvdcnsnP4=
From: George Dunlap <George.Dunlap@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Ian Jackson <iwj@xenproject.org>, Committers <committers@xenproject.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Andrew
 Cooper" <Andrew.Cooper3@citrix.com>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH] RFC: Version support policy
Thread-Topic: [PATCH] RFC: Version support policy
Thread-Index: AQHXkDev9/QrG+8IgUOEs2JU9EeShqt6ldOAgRojewCAALAsgIAU2gcA
Date: Mon, 28 Feb 2022 14:46:32 +0000
Message-ID: <3BBE2793-C0AF-4873-8F77-5885CB39D67F@citrix.com>
References: <20210813113727.6028-1-iwj@xenproject.org>
 <de32c6c4-5ad5-862e-3988-0e7310ec3ecb@suse.com>
 <C6A7B444-4CFB-43A7-8FA8-AD1049F83912@citrix.com>
 <0bfdf348-8ce3-0f22-d28b-993ddc7242d2@suse.com>
In-Reply-To: <0bfdf348-8ce3-0f22-d28b-993ddc7242d2@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3693.60.0.1.1)
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 1c3460c9-2a14-4320-6815-08d9fac91ce3
x-ms-traffictypediagnostic: DM6PR03MB5162:EE_
x-microsoft-antispam-prvs: <DM6PR03MB5162E4C8CE7CB478BB00B26599019@DM6PR03MB5162.namprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: iqt84juRK0jEnckG0H8/gm1rI5DboUlx2Cl95pmhT36yaYKUL9/+sAafkJ0VanraUN3T3pfpQ2vfcublE/uV1hwQUcBYLlOwXSoNSbIIwVI9AyZ/MhAWgyzBdDmsAIB96Eetyf2PN84sYbYbmOkj6y8tKF+7/dhlmVdYw5YBrcCPH0Hd1VFhpyRhzACtxbmi/8bwkkY85BTPLLM7I294D8a3bW98i0A/86vT7Npu8xO85++J1LcrAsS9GZVgE1dR3MMxz/o8zr/t6OLRx8KgMKvkRQZNoHa3KF/sT+L8wD81YirorlLgdC9Cvux+pIGAJS4/u3m4UaMwdJgUocZ1237HzKwW584KehyIGIkrfx4xs+ZTP3iSaIZN8LafD5x3hYv9G44KPuQM1Mg+ISRP16EJFZ1nPRbNOHqbyEwBBo01MvzXUTcbKyNHjI4XUVQGADrlEQ3P4SxXaZTbdFZQiUTa+mn+SCllfjxfuBrm0nWuHVixeX8C7oNYL62bq4ER8i+LCnXvPcPL0qhKuoJUhBf38MZhn5OhuivC3iULNAkNTlDW1bquqBaVA7hN0McckEXMN6ZU1mJi6lAl5WGDXmdua8BbDjbxNas6nqPWZppWFXmU18Ke3ywT8gAMPya3Zbz45KwL6uKpyn1FXo1pUiEH0HfSoG3HrO2SO+yoYhXpsyrZBvjT0dTtyAsV2AyWtPuZbhUMpnuk6WP8EK4njGNJhhZWoG8dldD/6ZrhF/jG+Mpkc9099IagjWJbW5si
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(86362001)(5660300002)(38070700005)(2616005)(316002)(8936002)(66946007)(66476007)(91956017)(64756008)(76116006)(66446008)(8676002)(66556008)(2906002)(26005)(186003)(33656002)(6506007)(4326008)(38100700002)(36756003)(53546011)(71200400001)(82960400001)(99936003)(6486002)(122000001)(508600001)(83380400001)(54906003)(6916009)(6512007)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?RGRmd2FwQ0dSa0FvMXdUNmlLSE1raUVib3JtMnNzNWtOdEtnbittcncxUlFw?=
 =?utf-8?B?aVd6WkFZbk84dTVmNjB6QUR2SXRPSmFCYWlvOFd0T0JFajlUVThwMTArbUhv?=
 =?utf-8?B?aHd0NVhKdzJZQmdGeGt0YUgvY3BpVzRxTGFNczFRK1Jmb1ptWENqZFpLSXJl?=
 =?utf-8?B?YXZFWEhiZkFBSm5YVjQveThTZlJtYXU3VUdYRHJuTlF2cForL1FGNXRCaG1D?=
 =?utf-8?B?SGZlUXQ3UTJDYkdWaDVTUktTYUZSejZCOGtxRkZLazNqVGpxVWFPSnU4cGJG?=
 =?utf-8?B?V2toWHdaZkxBdzNvaldpUE0rTWdndnNodmlBZ1dMbDdFSjJlWXEybUtrbVBi?=
 =?utf-8?B?N3lYczJ5dUFZQ1hyZ3JPSFlXY0N3dFI5R2t3dFRFWFljOWVhMjNPbWdqbzNi?=
 =?utf-8?B?bDhhZksrR3p0aDd6cFNMVTJ6V01JN09hcGdaY3B6d2dybXIyQ3RCaU1UaVhY?=
 =?utf-8?B?L0tEclF6TDRBR0ZabGh0NzREQ1liTGl6c0FQUStDMktWZEExTTlFNGowdDhW?=
 =?utf-8?B?NUZGZzViL2s1ZmVkWmxuakNGZUU4Y2hWaDNQNjhmcWliM2J4d2FrZEYxY0ZD?=
 =?utf-8?B?dXptVXVzMDVMbDZUUHMwbmZZdnlXUC85MTdsMFcyNjZLQTJrdUVscWd0bmt4?=
 =?utf-8?B?cHBTZVd4cm1XOGFyMUdLVHFxVDBQVkxqWnBwaVhGWXU5Y0QyV2VIZTlYd216?=
 =?utf-8?B?UGFKTFNTOEtiSjNqRTlZbWRpOEdVR3hiYkljQURIR29uOUpaR2UyYjFKYUox?=
 =?utf-8?B?cEQrN3ZBNGJHMU8wbGlpVmMzeUhpMWJqV01VZXFqZ3BWMm5yekhSdFZYMjJn?=
 =?utf-8?B?VXF3RmNCVHR6WWVPckl4bU85aFFKQ2tmOHVUTkl1Nm9WVzc4K3pzQ0tvNnRs?=
 =?utf-8?B?VWtjRy82YjMvMHhudlUzM1dKVFlZT09WSi9FU09iV0dGdXBOOVo0QXNNKzBY?=
 =?utf-8?B?YmxaSTJaTlk0VUgwYkJzVXE3TUc1Z0w3Zyt2SVlhY2ZjSm1mYlJ3bTFWOUNV?=
 =?utf-8?B?ZEl3WkkyTzYxdXU2NUVENXJQWHdDajBDTm5CQWsxdENwSWU2Q2VBTnh5cXdE?=
 =?utf-8?B?QnJVNnVqaFA4eGpJR2N2aW51YjFXaFVVa29zVnpNZHVRTE16NVp2Vk9keUNp?=
 =?utf-8?B?MDJHVDBMZWUrdUVsS1lMbWh2aC9PN0ZhV2YwdW5oMmp0clV3MVNuNTdxYUxz?=
 =?utf-8?B?MndwS0tzVjR0L3hNOXhvZHlDdDhsRUZNNG85NGM0MHNoelVWZHVEWkFhWUdS?=
 =?utf-8?B?RzZwVHorWUR0aVJLZnljbDk3WTdwZHd1MzFDRlNrM3ZZamNOMkJxa1l4SnRa?=
 =?utf-8?B?UWl0TG54TjNBMFl1VVFjNWJHQzhlMFQwVzZlbkZ1VVpqU283UldPdGJTRFli?=
 =?utf-8?B?QUpkREV6Ly82Mi93MktEZnlHUUtRMVNBZXFMaHllVGVtSDdBSGJRTUdTVHRu?=
 =?utf-8?B?REZ4dTl4d0ZvblVOWXI0MEhpSEgzMk5hU2svQm9VK0NONzM3N2VBbms4ckJp?=
 =?utf-8?B?YkRGUDNkdURZSW8xRkdLS1grZjlMa2N5eHpSZmRRSHU2UGd5enJNYk5FL3RB?=
 =?utf-8?B?dnMya3R5L08wcHovYnVkcHRncHFKYXRUclpPcjlZVE84NUxGbVI2V0RNOGlY?=
 =?utf-8?B?QXNrT1hOOEJIU1Z0ajhtVzhGcUVZWGYxUDRtT2l1VERENWdLSVljYWFadWhx?=
 =?utf-8?B?cm5lSWpTR3R2R3pZSGtxZGF4T3RBc0NvSXY3SU0xUXRQMWxwemJjNGEvTG5Z?=
 =?utf-8?B?WUxoWXp6QUY3S0IvT1V0SDhYY2NROWowUlNpMC9Ybkw3bjV2T3JuNFdzSlhI?=
 =?utf-8?B?QXYvSjNmcXVEakpwTFI4L09HakNyVTRjTVdHbytCTU54Q2ZqQ3FOVzFPSjNq?=
 =?utf-8?B?VW0rRE1YYWgyT1E1YURCc2trV0pGK3NOckRBNzZ6dUtJUFg0WEJUM3B0OEw5?=
 =?utf-8?B?d2ZiaStmMVNtc3YrQURKcW1QT05hUjR5cDd1OGdRTkViZVRyMVpuN0FLKzhP?=
 =?utf-8?B?dHY3S1lwajJVSXpnb0dJYkN0TExlZzVoTjVaT3RHTXArdWk1UWYyaEgvZUJm?=
 =?utf-8?B?VktmTUt6TlNsM255M1Q0OHpHcEkrTExINnZQMzdpRSsxRno0ZnExL2xvWWto?=
 =?utf-8?B?Z2x1U1dZbnpzMTRVeEtCWCtydDVJanNvWjA0NjhDOWJITFN6VFBMODRla1Zs?=
 =?utf-8?B?Yy9TSWRMcSthU3JqTHZ3c0pmUVFQSW04TVljdmNmVTFrM2dDZEFNSFV6QjFK?=
 =?utf-8?Q?n0nSW2hsfJUXIgFAjoTN+aAoi2EwY/F5b4db3kTlYg=3D?=
Content-Type: multipart/signed;
	boundary="Apple-Mail=_F2E62668-53D5-45AF-97EB-DAD64F132CCC";
	protocol="application/pgp-signature";
	micalg=pgp-sha512
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1c3460c9-2a14-4320-6815-08d9fac91ce3
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Feb 2022 14:46:32.8578
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: bdNBaYsBdbwBRWf1h+3bN/xIhJ33Ol7gRbAxatb55tbKEYz9ujl5Yim38dVoDtNmYXENVjcUf3KlAiYnvHG5Zlh7fN0Zdhf5zt/25o5XzYE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5162
X-OriginatorOrg: citrix.com

--Apple-Mail=_F2E62668-53D5-45AF-97EB-DAD64F132CCC
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8



> On Feb 15, 2022, at 8:20 AM, Jan Beulich <jbeulich@suse.com> wrote:
>=20
> On 14.02.2022 22:50, George Dunlap wrote:
>>> On Aug 19, 2021, at 10:18 AM, Jan Beulich <JBeulich@suse.com> wrote:
>>> On 13.08.2021 13:37, Ian Jackson wrote:
>>>> The current policy for minimum supported versions of tools, =
compilers,
>>>> etc. is unsatisfactory: For many dependencies no minimum version is
>>>> specified.  For those where a version is stated, updating it is a
>>>> decision that has to be explicitly taken for that tool.
>>>=20
>>> Considering your submission of this having been close to a glibc
>>> version issue you and I have been discussing, I wonder whether
>>> "etc" above includes library dependencies as well.
>>>=20
>>> In any event the precise scope of what is meant to be covered is
>>> quite important to me: There are affected entities that I'm happy
>>> to replace on older distros (binutils, gcc). There are potentially
>>> affected entities that I'm less happy to replace, but at the time
>>> I did work my way through it for example for Python (to still be
>>> able to build qemu, the community of which doesn't appear to care
>>> at all to have their stuff buildable in older environments). The
>>> point where I'd be really in trouble would be when base platform
>>> libraries like glibc are required to be a certain minimum version:
>>> I'd then be (potentially severely) restricted in what systems I
>>> can actually test stuff on.
>>=20
>> The question here is, why would someone running a 10-year-old distro =
that=E2=80=99s been out of support for 6 years want to run a bleeding =
edge version of Xen?  I understand wanting to run Xen 4.16 on (say) =
Ubuntu 18.04, but who on earth would want to run Xen 4.16 on Ubuntu =
14.04, and why?  If such people exist, is it really worth the effort to =
try to support them?
>=20
> I do this, for the very simple reason of wanting (needing) to be able
> to test a large range of Xen versions all on the same small set of
> hardware. Internally we're still maintaining versions back to at least
> 4.4; upon customer request we (I) may end up needing to even play with
> 4.0.

You don=E2=80=99t mention what software you=E2=80=99re talking about for =
versions 4.4 and 4.0, so I assume you mean Xen.

What I=E2=80=99m hearing you say is:

1. You have a handful of test hardware upon which you do your own manual =
testing.

2. You need to test at least as far back as Xen 4.4, possibly as far =
back as Xen 4.0, since you have customers that are using those versions.

3. It=E2=80=99s not feasible to test Xen 4.4 on a modern version of =
SUSE.  Presumably this is some combination of 3a. The customers using =
those versions are in fact using versions of SUSE from that timeframe as =
well, so thats what needs testing and 3b. It=E2=80=99s impractical to =
get Xen 4.4 to build on a modern version of SUSE.

4. It=E2=80=99s not feasible to use different SUSE versions on this =
hardware, such that each version of Xen is being tested with a version =
of SUSE from the appropriate time frame. Presumably this is some =
combination of 4a. You don=E2=80=99t want the hassle of re-installing =
the machine every time you want to test it (and it=E2=80=99s not =
feasible / too much of a hassle to maintain multiple parallel =
installations on the machine) 4b. Newer versions of SUSE wouldn=E2=80=99t =
run on this machine, since it=E2=80=99s so old.

Is that what I=E2=80=99m hearing?

So first of all, you are not an end-user, and running this sort of test =
is not =E2=80=9Crunning Xen=E2=80=9D.  I=E2=80=99m talking about =
end-users actually using Xen 4.16 =E2=80=9Cin anger=E2=80=9D as they say =
in the UK, on Ubuntu 14.04; not for testing, but because they actually =
needed to use virtualization to solve a problem that they had.  Are =
there any people out there who need a hypervisor to solve a problem they =
have, and want to use Xen 4.16 with Ubuntu 14.04?

 -George


--Apple-Mail=_F2E62668-53D5-45AF-97EB-DAD64F132CCC
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="signature.asc"
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEj3+7SZ4EDefWZFyCshXHp8eEG+0FAmIc4EYACgkQshXHp8eE
G+1cpQgAvxtkvCcF4soI1dhuqHIrgDYbo8SYH07vZ5/NNClfbIlBGZoO1b39RV8m
7bNETr2SsttDzy36B89lpgKoRXE1mssVM8D3y7Ao4wv1TRNBtkWHFTfoQZLA779b
BY4ZDBMhUueW5QtH4VM6JWXuupDBHua3RyVyRD/+oaYQHmrXNJzt7j6ePy21BvjG
e1FM4tQc9nGwS/EsXydqACoPy93k05GUjw5wDzhUj0VDw21LipjgY1jqLHSOxN4U
ml/WNTvyu6Tma2W3PtKs+txhzUn4MCHHvz4CKPVU1kBhmeP3mOALrII1umVABbpx
SlosyqyuDAHJJyAS3+k3NSY49xxGzg==
=u5hj
-----END PGP SIGNATURE-----

--Apple-Mail=_F2E62668-53D5-45AF-97EB-DAD64F132CCC--


From xen-devel-bounces@lists.xenproject.org Mon Feb 28 14:55:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 14:55:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280632.478661 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOhR2-0004G7-GT; Mon, 28 Feb 2022 14:55:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280632.478661; Mon, 28 Feb 2022 14:55:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOhR2-0004F2-9X; Mon, 28 Feb 2022 14:55:36 +0000
Received: by outflank-mailman (input) for mailman id 280632;
 Mon, 28 Feb 2022 14:55:35 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=39Co=TL=citrix.com=prvs=0517876bc=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nOhR1-0003h4-3P
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 14:55:35 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7ad1fcd8-98a6-11ec-8539-5f4723681683;
 Mon, 28 Feb 2022 15:55:33 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7ad1fcd8-98a6-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1646060133;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=IsL8G7dlJmiTydy3og1CtH8rtaWEJrFXlKgFdR/ewSU=;
  b=Ks65IDY2hTkw5xW0UzljrXbJE76S3RLMCP9DjAIG5t/y28rt7Au4vBW+
   tO7E16fafil5GHoOtTS02y6zU58IoNm37w9g/qSR4lHAGIhaBP+WMFD+d
   UM9aZvarbPtVDKKEb3pMlh0OuFxekXb3ZTGLkV3Pdj96DA8yz6h9epy7s
   8=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 65542982
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:S3VgZaC7Qrq1FhVW/zXjw5YqxClBgxIJ4kV8jS/XYbTApDIh3mRWx
 zYXXz/UOq2MNDfxeY90bNnk9EtT6pPdndRnQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHWeIdA970Ug5w7Rj0tYx6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhA+
 epr6sO6ZjsXHY/uqLUsAzoJEwBhaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguwqKtXrO4UO/Glt1zjDAd4tQIzZQrWM7thdtNs1rp4TQKqEN
 ppDAdZpRE3CPTJOMwZINLsvlf/0jWWlKSN8tmvA8MLb5ECMlVcsgdABKuH9YceWTM9YmkKZo
 GPu/GnjBBwectuFxlKt+Xu2iujCtSjyQo4VGfuz8fsCqE2ewCkfBQMbUXO/oOKlkQiuVtRHM
 UsW9yEy668o+ySDUd3VTxC+5nmesXYht8F4SrNgrlvXk+yNvljfVjNsoiN9hMIOhf4JY2N13
 HC1ofDLJww+ge22GHK86eLBxd+tAhQ9IWgHbC4CaAIK5dj/vY0+5i7yosZf/L2d1YOsR2ypq
 9yehG1n3uhI05ZXv0mu1Q2f21qRSo71ohnZD+k9dkas9UtHaYGsfOREAnCLvK8bfO51orRs1
 UXoevRyDshTV/lhdwTXGY3h+Y1FAd7fbVUwZnY1QvEcG8yFoSLLQGypyGgWyL1VGsgFYyT1R
 0TYpBlc4pReVFPzM/MqMtLuUp12k/CwfTgAahwyRoATCnSWXFXalByCmGbKhzy9+KTSuftX1
 WinnTaEUi9BVPUPIMueTOYBy747rh3SNkuILa0XOy+PiOLEDFbMEO9tGALXMogRsfPVyC2Io
 o03H5bblH1ivBjWP3C/HXg7dgtRcxDWxPne9qRqSwJ0ClE+STF5VqSImutJlk4Mt/09q9okN
 0qVAidwoGcTT1WdQelWQhiPsI/SYKs=
IronPort-HdrOrdr: A9a23:8vQ6g66BwB1ZfegOxgPXwKvXdLJyesId70hD6qkRc3xom6mj/P
 xG88536faZslwssRIb+OxoRpPufZq0z/cc3WB7B9uftWfd1leVEA==
X-IronPort-AV: E=Sophos;i="5.90,142,1643691600"; 
   d="scan'208";a="65542982"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: <wl@xen.org>, <sstabellini@kernel.org>, <andrew.cooper3@citrix.com>,
	Anthony PERARD <anthony.perard@citrix.com>, Doug Goldstein
	<cardoe@cardoe.com>
Subject: [XEN PATCH 3/4] automation: only run test artifact jobs when needed
Date: Mon, 28 Feb 2022 14:55:22 +0000
Message-ID: <20220228145523.8954-4-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220228145523.8954-1-anthony.perard@citrix.com>
References: <20220228145523.8954-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

Share the same "except" as the one used for tests.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 automation/gitlab-ci/build.yaml | 16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)

diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml
index 26dcfb1c25..cbbe0b8346 100644
--- a/automation/gitlab-ci/build.yaml
+++ b/automation/gitlab-ci/build.yaml
@@ -567,10 +567,16 @@ alpine-3.12-gcc-debug-arm64:
     CONTAINER: alpine:3.12-arm64v8
 
 
+## Test artifacts common
+
+.test-jobs-artifact-common:
+  stage: build
+  except: !reference [.test-jobs-common, except]
+
 # Arm test artifacts
 
 alpine-3.12-arm64-rootfs-export:
-  stage: build
+  extends: .test-jobs-artifact-common
   image: registry.gitlab.com/xen-project/xen/tests-artifacts/alpine:3.12-arm64v8
   script:
     - mkdir binaries && cp /initrd.tar.gz binaries/initrd.tar.gz
@@ -581,7 +587,7 @@ alpine-3.12-arm64-rootfs-export:
     - arm64
 
 kernel-5.9.9-arm64-export:
-  stage: build
+  extends: .test-jobs-artifact-common
   image: registry.gitlab.com/xen-project/xen/tests-artifacts/kernel:5.9.9-arm64v8
   script:
     - mkdir binaries && cp /Image binaries/Image
@@ -592,7 +598,7 @@ kernel-5.9.9-arm64-export:
     - arm64
 
 qemu-system-aarch64-5.2.0-arm64-export:
-  stage: build
+  extends: .test-jobs-artifact-common
   image: registry.gitlab.com/xen-project/xen/tests-artifacts/qemu-system-aarch64:5.2.0-arm64v8
   script:
     - mkdir binaries && cp /qemu-system-aarch64 binaries/qemu-system-aarch64
@@ -606,7 +612,7 @@ qemu-system-aarch64-5.2.0-arm64-export:
 # x86_64 test artifacts
 
 alpine-3.12-rootfs-export:
-  stage: build
+  extends: .test-jobs-artifact-common
   image: registry.gitlab.com/xen-project/xen/tests-artifacts/alpine:3.12
   script:
     - mkdir binaries && cp /initrd.tar.gz binaries/initrd.tar.gz
@@ -617,7 +623,7 @@ alpine-3.12-rootfs-export:
     - x86_64
 
 kernel-5.10.74-export:
-  stage: build
+  extends: .test-jobs-artifact-common
   image: registry.gitlab.com/xen-project/xen/tests-artifacts/kernel:5.10.74
   script:
     - mkdir binaries && cp /bzImage binaries/bzImage
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Mon Feb 28 14:55:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 14:55:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280630.478644 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOhR0-0003ws-PL; Mon, 28 Feb 2022 14:55:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280630.478644; Mon, 28 Feb 2022 14:55:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOhR0-0003wk-Lk; Mon, 28 Feb 2022 14:55:34 +0000
Received: by outflank-mailman (input) for mailman id 280630;
 Mon, 28 Feb 2022 14:55:33 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=39Co=TL=citrix.com=prvs=0517876bc=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nOhQz-0003h4-1c
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 14:55:33 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 78b8ab98-98a6-11ec-8539-5f4723681683;
 Mon, 28 Feb 2022 15:55:31 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 78b8ab98-98a6-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1646060131;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=rocmMjvzUQRs4n7ggDg9sS0cuq8lUwnn9yR5Wesg0oA=;
  b=N5TdfE+w/NQaB4I/vxMjPO8lA3+0QnEiMA2cXi+/F7GCHLhpM6k6ijVH
   9Nw6aCDUj4U46CHIvuoBmh+s3rrNBQkQn/IPh07Qv9oEjPNsu/kpdAqdS
   ED+VlnlwuWF7wpAL4p9pyLkkDJxKr76FQQsIhCgtA18mbFT4LAxbBi6Cl
   A=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 65133088
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:PEvhMKxyTzgDz4lrIol6t+crxirEfRIJ4+MujC+fZmUNrF6WrkVRz
 2YcDG+Eb63cMGGkKYpwPIS380JVvp+Ezt9kHANvqiAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGX9JZS5LwbZj2NYy24jhWmthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 Nplr6O1FzUbJKT2tsMPTBJzEwJjfpxo5+qSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DNYUDunZm3HfBAOwvW5zrSKTW/95Imjw3g6iiGN6AO
 pNCMmI/PHwsZTVkKFomFK4Bjd75uV/SXA1+9XCnprIOtj27IAtZj+G2bYu9lsaxbd5Ogk+Sq
 2bC/mL4KhIXLtqSzXyC6H3EruTGhy/8VaoZHae08fMsi1qWrkQDBRtTWValrP2Rjk+lR8kZO
 0ES4jApr6U56AqsVNaVdwK8iG6JuFgbQdU4LgEhwFjTkOyOuV/fXzVaCG4aADA7iCMobSYV0
 wG7rcngPxJIoqKeYnK+6/SlgyznbED5MlQ+TSMDSAIE5fzqr4cykg/DQ75fLUKlsjHmMWqum
 m7X9UDSk51W1JdWjPvjoTgrlhrx/sChc+Ij2unAsotJBCtdbZXtWYGn4EOzAR1ofNfAFQnpU
 JTpdqGjAAEy4XOlyXblrAYlRujBCxO53Nv02wMH834JrWnFxpJbVdoMiAyS3W8wWir+RRfnY
 VXIpSRa74JJMX2hYMdfOtztVpV6kvG5SYq9Bpg4i+aihLArKWdrGwk0OCatM53FyhBwwcnTx
 7/BGSpTMZrqIfs+l2fnLwvs+bQq2jo/1QvuqWPTlHyaPU6lTCfNE98taQLWBshgtf/siFiFo
 r53aprRoz0CAbKWX8Ui2dNKRbz8BSNgXs6eRg0+XrPrHzeK70l6U66Bme56Itc990mX/8+Rl
 kyAtoZj4AKXrRX6xc+iMxiPtJuHsU5DkE8G
IronPort-HdrOrdr: A9a23:ZvoYWKhGHdzRpoUFRKH8rXIY8XBQXtwji2hC6mlwRA09TySZ//
 rAoB19726StN9xYgBYpTnuAsi9qB/nmKKdpLNhX4tKPzOW3FdATrsD0WKK+VSJcEfDH6xmpM
 JdmsBFebvN5DNB4/oSjjPVLz9Z+qjlzJyV
X-IronPort-AV: E=Sophos;i="5.90,142,1643691600"; 
   d="scan'208";a="65133088"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: <wl@xen.org>, <sstabellini@kernel.org>, <andrew.cooper3@citrix.com>,
	Anthony PERARD <anthony.perard@citrix.com>, Doug Goldstein
	<cardoe@cardoe.com>
Subject: [XEN PATCH 1/4] automation: fix typo in .gcc-tmpl
Date: Mon, 28 Feb 2022 14:55:20 +0000
Message-ID: <20220228145523.8954-2-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220228145523.8954-1-anthony.perard@citrix.com>
References: <20220228145523.8954-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

The name of the field doesn't matter because it's use as a YAML achor,
but it's nicer to have the proper spelling.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 automation/gitlab-ci/build.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml
index cc36428cf5..26dcfb1c25 100644
--- a/automation/gitlab-ci/build.yaml
+++ b/automation/gitlab-ci/build.yaml
@@ -17,7 +17,7 @@
     - /^stable-.*/
 
 .gcc-tmpl:
-  variabes: &gcc
+  variables: &gcc
     CC: gcc
     CXX: g++
 
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Mon Feb 28 14:55:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 14:55:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280629.478633 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOhQz-0003hM-Hi; Mon, 28 Feb 2022 14:55:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280629.478633; Mon, 28 Feb 2022 14:55:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOhQz-0003hF-EH; Mon, 28 Feb 2022 14:55:33 +0000
Received: by outflank-mailman (input) for mailman id 280629;
 Mon, 28 Feb 2022 14:55:32 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=39Co=TL=citrix.com=prvs=0517876bc=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nOhQy-0003h4-9I
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 14:55:32 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7831c168-98a6-11ec-8539-5f4723681683;
 Mon, 28 Feb 2022 15:55:30 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7831c168-98a6-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1646060130;
  h=from:to:cc:subject:date:message-id:mime-version:
   content-transfer-encoding;
  bh=5kZofwA3P8U6tWAC3tKzOr++gyzoNwV7ywxU6kD847M=;
  b=dUzbcINd1Pnjd9jRNdouvYN9qUSGbMUC8m837JKNo3MjUgLih92iJPAw
   XOuLP/hYYRQnVXqUYeOz4DIk0AenDA+XIWaXg5AScVqHM4tqMoOiKr7CU
   khvSMJSOlvjvru70AeT0/u4z6WzUppAFSmcE1v3hMRx64LfUDUNEHNHKQ
   s=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 65542972
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:0yaJK6n+AATqUsIGiDvivR/o5gydJkRdPkR7XQ2eYbSJt1+Wr1Gzt
 xJJX23VMv7fM2v1fdh/OtzgpxxSsZOBn4JjGwBlrSg2FiMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EoLd9IR2NYy24DjWVPV4
 LsenuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR
 v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ
 NtxWZOYUiI0OarupOAhbxBeLBAlDPNG5eboPi3q2SCT5xWun3rExvxvCAc9PJEC+/YxCmZLn
 RAaAGlTNFbZ3bvwme/lDLk37iggBJCD0Ic3s3d8zTbfHLA+TIrKWani7t5ExjYgwMtJGJ4yY
 uJHNGczNkWfOXWjPH8zUap9ofz4l0DxMCFYilOxo5U13TbcmVkZPL/Fb4OOJ43iqd9utl2Du
 mvM8mD9AxcbHN+S0zyI9jSrnOCntSjyQo4VGZWz/+Rmh1DVzWsWYDUGWF3+rfSnh0qWX9NEN
 1dS6icotbI19kGgUp/6RRLQiGGAlg4RXZxXCeJS1e2W4vOKuUDDXDFCF2MfLox93CMredA0/
 kSsgtTuJwBrjIGcT02srYbKrS7rFjdAeAfuehQ4ZQcC5tDipqQ6gRTOUstvHcaJszHlJd3j6
 2vU9XZj3t3/meZOjvzmpg6f31pAs7CUFlZd2+nBYo6yAuqVjqaBbpfg11XU5O0owG2xHgjY5
 yhsdyRzAYkz4XCxeM6lHb9l8FKBva/t3NjgbbhHRcRJG9OFoSPLQGyoyGsiTHqFy+5dEdMTX
 GfduBlK+LhYN2awYKl8buqZUpp2kPmwSo28Cq6MPrKih6SdkifdoUmCgmbKggjQfLUEy/lja
 f93j+72ZZrlNUiX5GXvHLpMuVPa7is/2XnSVfjGI+ePitKjiIquYe5dajOmN7lhhIvd+Vm92
 4sPZqOilkQEOMWjM3a/zGLmBQ1TRZTNLcut8JI/my/qClcOJVzN/NeKmeJxI9E+xv8N/goKl
 1nkMnJlJJPErSWvAW23hrpLMtsDgb4XQaoHABER
IronPort-HdrOrdr: A9a23:02BI9KFhZfL0U1IzpLqFrZLXdLJyesId70hD6qkvc3Jom52j+P
 xGws526fatskdtZJkh8erwXZVoMkmsiaKdgLNhcItKOTONhILGFvAa0WKP+UyCJ8S6zJ8m6U
 4CSdkzNDSTNykDsS+S2mDReLtAoOVvsprY/ts2pE0dKT2CHpsQiTuRfTzrdXGeKjM2Z6YRJd
 653I5qtjCgcXMYYoCQHX8eRdXOoNXNidbPfQMGLwRP0njBsRqYrJrBVzSI1BYXVD1ChZ0493
 LergD/7qK/99mm1x7n0XPJ5Zg+oqqh9jIDPr3NtiEmEESvtu+aXvUlZ1REhkFwnAib0idorD
 ALmWZmAy080QKWQoj/m2qT5+Cp6kdR15al8y7WvVLT5fXjQjQ0EsxAgp8cXCf4xiMbzYhB+Z
 MO5nmesZVPCxPGgWDa3PjnEz9Xtmfcmwt7rQY050YvC7f2rIUh9rA37QdbFowNEzn9751iGO
 5yDNvE7PITal+CaWvF11MfiOBEc05DaCtueHJy8/B9EgIm6UxR3g8d3ogSj30A/JUyR91N4P
 nFKL1hkPVLQtUNZaxwCe8dSY/vY1a9Cy7kISaXOxDqBasHM3XCp9r+56g0/vijfNgNwIEpkJ
 rMXVtEvSo5el7oC8eJwJpXmyq9C1mVTHDo0IVT9pJ5srrzSP7iNjCCUkknl4+6r/AWEqTgKo
 GO0VJtcovexEfVaPV0NlfFKulvwFElIb8oUmFQYSP+nv72
X-IronPort-AV: E=Sophos;i="5.90,142,1643691600"; 
   d="scan'208";a="65542972"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: <wl@xen.org>, <sstabellini@kernel.org>, <andrew.cooper3@citrix.com>,
	Anthony PERARD <anthony.perard@citrix.com>, Doug Goldstein
	<cardoe@cardoe.com>
Subject: [XEN PATCH 0/4] Some improvement for gitlab CI jobs
Date: Mon, 28 Feb 2022 14:55:19 +0000
Message-ID: <20220228145523.8954-1-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

Patch series available in this git branch:
https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git br.gitlab-ci-improvement-v1

Allow build and test jobs to run concurently.

Avoid running "test artifact" jobs on branch "master" and other, when test jobs
aren't runned.

Anthony PERARD (4):
  automation: fix typo in .gcc-tmpl
  automation: add a templates for test jobs
  automation: only run test artifact jobs when needed
  automation: use "needs" instead of "dependencies" for test jobs

 automation/gitlab-ci/build.yaml | 18 ++++---
 automation/gitlab-ci/test.yaml  | 89 +++++++++------------------------
 2 files changed, 37 insertions(+), 70 deletions(-)

-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Mon Feb 28 14:55:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 14:55:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280631.478656 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOhR2-0004Cv-3O; Mon, 28 Feb 2022 14:55:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280631.478656; Mon, 28 Feb 2022 14:55:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOhR1-0004Cm-Un; Mon, 28 Feb 2022 14:55:35 +0000
Received: by outflank-mailman (input) for mailman id 280631;
 Mon, 28 Feb 2022 14:55:34 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=39Co=TL=citrix.com=prvs=0517876bc=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nOhR0-0003h4-IR
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 14:55:34 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 79add183-98a6-11ec-8539-5f4723681683;
 Mon, 28 Feb 2022 15:55:33 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 79add183-98a6-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1646060133;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=IBS59SoJNJD3j28cACuM1zvcsGe3SA8U6CcyY4BYijg=;
  b=Ws0W3fo61IvIZjO4ZFh8Djkt2gXiCXR1uYmRE8v2KnxX0IPqZMLUASiF
   a8FypvxMpt9h3dWL/xxr2ubE2FuWXmMC8UwCMdnwkVqKqWfcY49imFfQr
   q9KAVl1pP+yvYiQwDWOukn9SGYUysjbzv0Nc/TBfDY3Vj4+8tG9PPBJQV
   M=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 65029385
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:FU+Rx6q5tVsYRohNJKqenKCZIHxeBmIEZRIvgKrLsJaIsI4StFCzt
 garIBnTP6qIMWamKYpwOdvloEsPsZ6AytFqTwZlqno0FSMS95uZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlVEliefQAOCU5NfsYkidfyc9IMsaoU8lyrZRbrJA24DjWVvX4
 4Oq+qUzBXf+s9JKGjNMg068gEsHUMTa4Fv0aXRnOJinFHeH/5UkJMp3yZOZdhMUcaENdgKOf
 M7RzanRw4/s10xF5uVJMFrMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKv+Zvrgc91Zk
 b1wWZKMpQgBY7TmtOMlVkFhQxpUDLMW5eHufF+2iJnGp6HGWyOEL/RGCUg3OcsT+/ptAHEI/
 vsdQNwPRknd3aTsmuv9E7QywJR4RCXoFNp3VnVIxDfFDfEgUNbbTr/D/9Nw1zYsnMFeW/3ZY
 qL1bBIxMUyaMkYfZz/7DroltuGMryKhfgRAk2unrIUUwHCO01Buhe2F3N39JYXRGJQ9clyjj
 nnd423zDxUeNdqe4TmI6HShgqnIhyyTcIkbDrG/+9ZhiUefwWFVAxoTPXOrrP/8hkOgVtZ3L
 00P5jFovaU07FasTNT2Q1u/unHslgEYc8pdFas98g7l90bPy1/HXC5eFGcHMYF48p9tLdA36
 rOXt47wLxBoiLjNcCKm3IaK/S7sEHUyJFZXMEfoUjA5y9XkpYgyiDfGQdBiDLO5g7XJJN3g/
 9yZhHNg3utO1Kbnw43+pAma2Gz0+vAlWyZovl2/Y46z0u9uiGdJjaSM4EOT0/tPJZ3xorKp7
 CldwJj2AAzj4PiweM2xrAclQevBCxWtamS0bbtT838JrWnFF5mLJ9043d2GDB01WvvogBewC
 KMphStf5YVIIFyhZrJtboS6BqwClPa8SIW1CamNMoQWMvCdkTNrGgk0OCZ8OEi3zSARfVwXY
 8/HIa5A815AYUiY8NZGb7hEiuJ6rszP7WjSWYr633yaPUm2PxaopUM+GALWNIgRtfrcyC2Mq
 oo3H5bamn13DbylCgGKoNF7ELz/BSVibXwAg5cMLbDrz8sPMDxJNsI9Npt6I901x/kOz7yQl
 px/M2cBoGfCabT8AV3iQhhehHnHAf6TcVpT0fQQAGuV
IronPort-HdrOrdr: A9a23:6vNLG6nwA6h9q/7CATdUxUeaowrpDfIq3DAbv31ZSRFFG/Fxl6
 iV88jzsiWE7wr5OUtQ4OxoV5PgfZqxz/NICMwqTNWftWrdyQ+VxeNZjbcKqgeIc0aVygce79
 YET0EXMqyXMbEQt6jHCWeDf+rIuOP3k5yVuQ==
X-IronPort-AV: E=Sophos;i="5.90,142,1643691600"; 
   d="scan'208";a="65029385"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: <wl@xen.org>, <sstabellini@kernel.org>, <andrew.cooper3@citrix.com>,
	Anthony PERARD <anthony.perard@citrix.com>, Doug Goldstein
	<cardoe@cardoe.com>
Subject: [XEN PATCH 2/4] automation: add a templates for test jobs
Date: Mon, 28 Feb 2022 14:55:21 +0000
Message-ID: <20220228145523.8954-3-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220228145523.8954-1-anthony.perard@citrix.com>
References: <20220228145523.8954-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

Allow to set common configuration from a single place for all tests
jobs.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 automation/gitlab-ci/test.yaml | 73 ++++++++--------------------------
 1 file changed, 17 insertions(+), 56 deletions(-)

diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml
index 47e8704df3..7cf21b7493 100644
--- a/automation/gitlab-ci/test.yaml
+++ b/automation/gitlab-ci/test.yaml
@@ -1,7 +1,15 @@
-# Test jobs
-build-each-commit-gcc:
+.test-jobs-common:
   stage: test
   image: registry.gitlab.com/xen-project/xen/${CONTAINER}
+  except:
+    - master
+    - smoke
+    - /^coverity-tested\/.*/
+    - /^stable-.*/
+
+# Test jobs
+build-each-commit-gcc:
+  extends: .test-jobs-common
   variables:
     CONTAINER: debian:stretch
     XEN_TARGET_ARCH: x86_64
@@ -16,15 +24,9 @@ build-each-commit-gcc:
   dependencies: []
   tags:
     - x86_64
-  except:
-    - master
-    - smoke
-    - /^coverity-tested\/.*/
-    - /^stable-.*/
 
 qemu-alpine-arm64-gcc:
-  stage: test
-  image: registry.gitlab.com/xen-project/xen/${CONTAINER}
+  extends: .test-jobs-common
   variables:
     CONTAINER: debian:unstable-arm64v8
   script:
@@ -41,15 +43,9 @@ qemu-alpine-arm64-gcc:
     when: always
   tags:
     - arm64
-  except:
-    - master
-    - smoke
-    - /^coverity-tested\/.*/
-    - /^stable-.*/
 
 qemu-alpine-x86_64-gcc:
-  stage: test
-  image: registry.gitlab.com/xen-project/xen/${CONTAINER}
+  extends: .test-jobs-common
   variables:
     CONTAINER: debian:stretch
   script:
@@ -65,15 +61,9 @@ qemu-alpine-x86_64-gcc:
     when: always
   tags:
     - x86_64
-  except:
-    - master
-    - smoke
-    - /^coverity-tested\/.*/
-    - /^stable-.*/
 
 qemu-smoke-arm64-gcc:
-  stage: test
-  image: registry.gitlab.com/xen-project/xen/${CONTAINER}
+  extends: .test-jobs-common
   variables:
     CONTAINER: debian:unstable-arm64v8
   script:
@@ -89,15 +79,9 @@ qemu-smoke-arm64-gcc:
     when: always
   tags:
     - arm64
-  except:
-    - master
-    - smoke
-    - /^coverity-tested\/.*/
-    - /^stable-.*/
 
 qemu-smoke-x86-64-gcc:
-  stage: test
-  image: registry.gitlab.com/xen-project/xen/${CONTAINER}
+  extends: .test-jobs-common
   variables:
     CONTAINER: debian:stretch
   script:
@@ -111,15 +95,9 @@ qemu-smoke-x86-64-gcc:
     - debian-stretch-gcc-debug
   tags:
     - x86_64
-  except:
-    - master
-    - smoke
-    - /^coverity-tested\/.*/
-    - /^stable-.*/
 
 qemu-smoke-x86-64-clang:
-  stage: test
-  image: registry.gitlab.com/xen-project/xen/${CONTAINER}
+  extends: .test-jobs-common
   variables:
     CONTAINER: debian:stretch
   script:
@@ -133,15 +111,9 @@ qemu-smoke-x86-64-clang:
     - debian-unstable-clang-debug
   tags:
     - x86_64
-  except:
-    - master
-    - smoke
-    - /^coverity-tested\/.*/
-    - /^stable-.*/
 
 qemu-smoke-x86-64-gcc-pvh:
-  stage: test
-  image: registry.gitlab.com/xen-project/xen/${CONTAINER}
+  extends: .test-jobs-common
   variables:
     CONTAINER: debian:stretch
   script:
@@ -155,15 +127,9 @@ qemu-smoke-x86-64-gcc-pvh:
     - debian-stretch-gcc-debug
   tags:
     - x86_64
-  except:
-    - master
-    - smoke
-    - /^coverity-tested\/.*/
-    - /^stable-.*/
 
 qemu-smoke-x86-64-clang-pvh:
-  stage: test
-  image: registry.gitlab.com/xen-project/xen/${CONTAINER}
+  extends: .test-jobs-common
   variables:
     CONTAINER: debian:stretch
   script:
@@ -177,8 +143,3 @@ qemu-smoke-x86-64-clang-pvh:
     - debian-unstable-clang-debug
   tags:
     - x86_64
-  except:
-    - master
-    - smoke
-    - /^coverity-tested\/.*/
-    - /^stable-.*/
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Mon Feb 28 14:55:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 14:55:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280633.478677 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOhR4-0004nF-Ra; Mon, 28 Feb 2022 14:55:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280633.478677; Mon, 28 Feb 2022 14:55:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOhR4-0004n6-NW; Mon, 28 Feb 2022 14:55:38 +0000
Received: by outflank-mailman (input) for mailman id 280633;
 Mon, 28 Feb 2022 14:55:37 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=39Co=TL=citrix.com=prvs=0517876bc=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1nOhR2-0003h4-Qn
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 14:55:36 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7bea66f8-98a6-11ec-8539-5f4723681683;
 Mon, 28 Feb 2022 15:55:35 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7bea66f8-98a6-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1646060135;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=JfocDo901DGQCPoxMCxuFGFQw5TmZyrp2AuzOSmqN8U=;
  b=b/5p++co3/Q98WEjZv8I0TSQCY93FRQYBUzRPX7kMGBR1geOa8GeI7Az
   4RwefdTt3xsp8VA6DaAE781yCf62hIulbQjNeeSj6zDG/8L7BhsWq+cBn
   ZgA7R8dTQL8+HB/zY+02NZqLKYoTynQZHLLShBtacmv6G9lWtTtVpNXxc
   s=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 65133097
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:razg5qkWn+B5MGhMrRRLZgro5gydJkRdPkR7XQ2eYbSJt1+Wr1Gzt
 xIcWTyDbP/bZ2ekeo8jbITg9B5UuJaDxoUwQARupShgEiMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EoLd9IR2NYy24DjWVPV4
 LsenuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR
 v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ
 NtxWZOYWC5zHreUx+IkdAQHNxtvBosaweSZLi3q2SCT5xWun3rExvxvCAc9PJEC+/YxCmZLn
 RAaAGlTNFbZ3bvwme/lDLk37iggBJCD0Ic3s3d8zTbfHLA+TIrKWani7t5ExjYgwMtJGJ4yY
 uJHNGM0N0yRPHWjPH8TWY48scChhUP4WD54slK4npsF/TDcmVkZPL/Fb4OOJ43iqd9utl2Du
 mvM8mD9AxcbHN+S0zyI9jSrnOCntSjyQo4VGZWz/+Rmh1DVzWsWYDUGWF3+rfSnh0qWX9NEN
 1dS6icotbI19kGgUp/6RRLQiGGAlg4RXZxXCeJS1e2W4vOKuUDDXDFCF2MfLox93CMredA0/
 k6gxfPzXWNpiZqIFlan54yy8QrpZydAeAfuehQ4ZQcC5tDipqQ6gRTOUstvHcaJszHlJd3j6
 2vU9XZj3t3/meZOjvzmpg6f31pAs7CUFlZd2+nBYo6yAuqVjqaBbpfg11XU5O0owG2xHgjY5
 yhsdyRzAYkz4XCxeM6lHb9l8FKBva/t3NjgbbhHRcRJG9OFoSPLQGyoyGsiTHqFy+5dEdMTX
 GfduBlK+LhYN2awYKl8buqZUpp2kPmwSo28Cq6MPrKih6SdkifdoUmCgmbKggjQfLUEy/lja
 f93j+72ZZrlNUiX5GXvHLpMuVPa7is/2XnSVfjGI+ePitKjiIquYe5dajOmN7lhhIvd+Vm92
 4sPZqOilkQEOMWjM3a/zGLmBQ1TRZTNLcut8JI/my/qClcOJVzN/NeKmeJxI9E+xv8N/goKl
 1nkMnJlJJPErSWvAW23hrpLNdsDgb4XQaoHABER
IronPort-HdrOrdr: A9a23:NcER1qu4hdVc2dYkJCm/DEHW7skDFdV00zEX/kB9WHVpm62j9/
 xG+c5x6faaslsssR0b8+xoW5PgfZqjz/FICOAqVN+ftWLd1FdAQrsN0bff
X-IronPort-AV: E=Sophos;i="5.90,142,1643691600"; 
   d="scan'208";a="65133097"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: <wl@xen.org>, <sstabellini@kernel.org>, <andrew.cooper3@citrix.com>,
	Anthony PERARD <anthony.perard@citrix.com>, Doug Goldstein
	<cardoe@cardoe.com>
Subject: [XEN PATCH 4/4] automation: use "needs" instead of "dependencies" for test jobs
Date: Mon, 28 Feb 2022 14:55:23 +0000
Message-ID: <20220228145523.8954-5-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220228145523.8954-1-anthony.perard@citrix.com>
References: <20220228145523.8954-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

Like with "dependencies", the jobs will get artifacts from the jobs
listed in "needs". But the test jobs can run as soon as the build jobs
listed have finished.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 automation/gitlab-ci/test.yaml | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml
index 7cf21b7493..56747fb335 100644
--- a/automation/gitlab-ci/test.yaml
+++ b/automation/gitlab-ci/test.yaml
@@ -21,7 +21,7 @@ build-each-commit-gcc:
     paths:
       - '*.log'
     when: always
-  dependencies: []
+  needs: []
   tags:
     - x86_64
 
@@ -31,7 +31,7 @@ qemu-alpine-arm64-gcc:
     CONTAINER: debian:unstable-arm64v8
   script:
     - ./automation/scripts/qemu-alpine-arm64.sh 2>&1 | tee qemu-smoke-arm64.log
-  dependencies:
+  needs:
     - alpine-3.12-gcc-arm64
     - alpine-3.12-arm64-rootfs-export
     - kernel-5.9.9-arm64-export
@@ -50,7 +50,7 @@ qemu-alpine-x86_64-gcc:
     CONTAINER: debian:stretch
   script:
     - ./automation/scripts/qemu-alpine-x86_64.sh 2>&1 | tee qemu-smoke-x86_64.log
-  dependencies:
+  needs:
     - alpine-3.12-gcc
     - alpine-3.12-rootfs-export
     - kernel-5.10.74-export
@@ -68,7 +68,7 @@ qemu-smoke-arm64-gcc:
     CONTAINER: debian:unstable-arm64v8
   script:
     - ./automation/scripts/qemu-smoke-arm64.sh 2>&1 | tee qemu-smoke-arm64.log
-  dependencies:
+  needs:
     - debian-unstable-gcc-arm64
     - kernel-5.9.9-arm64-export
     - qemu-system-aarch64-5.2.0-arm64-export
@@ -91,7 +91,7 @@ qemu-smoke-x86-64-gcc:
       - smoke.serial
       - '*.log'
     when: always
-  dependencies:
+  needs:
     - debian-stretch-gcc-debug
   tags:
     - x86_64
@@ -107,7 +107,7 @@ qemu-smoke-x86-64-clang:
       - smoke.serial
       - '*.log'
     when: always
-  dependencies:
+  needs:
     - debian-unstable-clang-debug
   tags:
     - x86_64
@@ -123,7 +123,7 @@ qemu-smoke-x86-64-gcc-pvh:
       - smoke.serial
       - '*.log'
     when: always
-  dependencies:
+  needs:
     - debian-stretch-gcc-debug
   tags:
     - x86_64
@@ -139,7 +139,7 @@ qemu-smoke-x86-64-clang-pvh:
       - smoke.serial
       - '*.log'
     when: always
-  dependencies:
+  needs:
     - debian-unstable-clang-debug
   tags:
     - x86_64
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Mon Feb 28 15:36:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 15:36:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280664.478689 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOi4b-00027N-W3; Mon, 28 Feb 2022 15:36:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280664.478689; Mon, 28 Feb 2022 15:36:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOi4b-00027G-SO; Mon, 28 Feb 2022 15:36:29 +0000
Received: by outflank-mailman (input) for mailman id 280664;
 Mon, 28 Feb 2022 15:36:28 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=o1tx=TL=citrix.com=prvs=051234957=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nOi4Z-00027A-V9
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 15:36:28 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2f282252-98ac-11ec-8539-5f4723681683;
 Mon, 28 Feb 2022 16:36:25 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2f282252-98ac-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1646062584;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=hbE2I8LTU0l0qKGfa+V/Rxbvy/vYwpgCj4IJo2o/84U=;
  b=Zg9ufCqgZwrVnIzIY5gAALtdOB/pTrLtFEMJu4CiYpD+PGX6Q+14j5EP
   P3tGGfOyEjoXkFqG0xV07QZBznlnUlZc5i+yDCqiFota/28kIl0+E7VDQ
   BmW6cLMUAH1TYr93EyG3ipFtMjGtcA2wwNiTJLtZxhhrRKB/CGFQSH6Vp
   E=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 65141569
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:NyHkWa2+8cDfbXjIRfbD5WZxkn2cJEfYwER7XKvMYLTBsI5bpz0Ey
 jYXC23UPPzcNmbyf4h/Oovkp08O6p6HmoNiTgs5pC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EE/NtTo5w7Rj2tQy0YDga++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /1AsbycRzsPDpHC28lDUkh2TANvAqR/reqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHxO4wSoDd4xCzxBvc6W5HTBa7N4Le02R9u25kSRKuAN
 qL1bxIxSjqcXhZNCm0SJ5A4pfuwpSfDYjpX/Qf9Sa0fvDGIkV0ZPKLWGNDYYMCQTMNZ2EORv
 Hvb/n/RCwsfcteYzFKtzHWogePemDLhb6gbHra46/1CjUWawyoYDxh+fVmmp7+/g023WdNaI
 mQV/DYjqe4580nDZsnwWVi0rWCJujYYWsFMCKsq5QeV0K3W7g2FQG8eQVZpa9E4tclwWT0j0
 HeImc/kAXpkt7j9YW2Z3qeZq3W1Iyd9BW0IaDIATAAFy8L+u4x1hRXKJv5hH7SylcbdAizrz
 naBqy1Wr64IkccB2qG//FbGqzGhvJ7ESkgy/Aq/dmC46gJ0Yqa1aoru7kLUhcusN67AEAPH5
 iJd3ZHDsqZeVvlhiRBhXs0AGJGF6cqjAAHSwnMxHsgPqBa8xHeaKNU4DC5FGG9lNcMNeDnMa
 UDVuB9M6JI7AEZGfZObcKrqVZ10kPGI+cDNE6mNM4EQOsQZmBqvoXk2DXN8yVwBh6TFfUsXH
 Z6AOfihAn8BYUiM5GrnHrxNuVPHK81X+I8yeXwZ50n9uVZ9TCTMIVvgDLdoRrpkhE9jiF+Im
 +uzz+PQl31ivBTWO0E7C7I7I1EQNmQcDpvrscFRfePrClM4RDxwW6CImO9/I9wNc0FpegHgp
 CzVtqhwkgeXuJE6AV/SNiALhE3HB/6TUk7XzQRzZA31ihDPkK6k7bsFdotfQFXU3LcL8BKAd
 NFcI5/oKq0WElzvom1BBbGg/N0KXEn63mqmYnv6CAXTirY9HmQlDPe/JVCxnMTPZwLq3fYDT
 0qIjVuKEcJeHF05VK47qpuHljuMgJTUo8orN2PgKdhPYkT8to9sLi36lPgsJM8Qbx7Ew1OnO
 8y+WH/0ecGlT1cJzeT0
IronPort-HdrOrdr: A9a23:wxRNxq8A2gC+kqhpOy9uk+DcI+orL9Y04lQ7vn2ZLiYlFfBw9v
 re+MjzsCWetN9/Yh0dcLy7V5VoIkm9yXcW2+cs1N6ZNWGN1VdAR7sC0aLShxHmBi3i5qp8+M
 5bAs1D4QTLfDtHZBDBkWuFL+o=
X-IronPort-AV: E=Sophos;i="5.90,142,1643691600"; 
   d="scan'208";a="65141569"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=FOGeFLJeQWPhesIMS131tf5AsVJsZgC2NBklh1FlbKLKg1ezQ+GcOc4spR2guInGbPXSjfcIp8ODTHWGFpslj7DFM3mEQuF+rXs5HoE0yyY+bZx+BMFj/GSRziyzB6shFycIGHTTFkVwKTstp5HQzUuylbgd8zWsLelfy9V18xQBVh+9jQAJOWi4Ay/kp9FpJqMk8DhClQt8QKy5B9Npk5SdbDKkR1S94AGRl1nh82NENFEOuRD7Ce8xXaulYoJnw+fJbxl1yV3RjyUNxVP5D2epOl47ik4dJ9RNaCNwUdUBnmyYWB6I/RtNF9CSuCYN3caQtFm7+qrA/FwNa5y/Tw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=n7pL3w2ix3aa18oF9XkiRv17MpXqxfIsDMj2l+xGLc4=;
 b=ITOZedBOdHjC4O3X2t/uBW+b+m/FI6sC9hshIgKiLqlEohyjnjuNaqQz4yO2oJnRWot4kqGOQTBCTSu+R7R4UhqHymqon2LJ7qBfTLohgJb+Vnkrmf/maC3ThypmdmgoAfw63Z3Q3x0ydBvGGi1qXLpEQlzXnWgZHsEa4nocjlFeBxlKFYCfLqCrphiAe2UHBVPpMVePDL2YpOEkPauRTRJ5OcyZB/BrKlT73LXroKonKqXmRUULXV24UNbe4F1kv4Bg7sk7M5RQFOxM4nrbwFWYjT9VUkPAyzZmV1NvxP7SbO25uOd7BLSJQrz8zkfAszK7Yp2i8KviAHYvN948OA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=n7pL3w2ix3aa18oF9XkiRv17MpXqxfIsDMj2l+xGLc4=;
 b=i2ZjDc868f2W2EYJLraGRj9d5lTsqzbrS2efOcfosuXgyHy80/K/cVL4KIym0D0xbFoq5T6UCi+rFtGYIv4xHRPjUS++3ew5EB3EoA4+APmYzZE41k4CP8DN4AuUN+d746cYzZOePIKs9fcs6UtBjKDt4VuV5jkJEMIQRT7Tw/0=
Date: Mon, 28 Feb 2022 16:36:15 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Jane Malalane <jane.malalane@citrix.com>, Wei Liu <wl@xen.org>, Anthony
 PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, Andrew
 Cooper <andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>,
	Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Bertrand Marquis
	<bertrand.marquis@arm.com>, Jun Nakajima <jun.nakajima@intel.com>, Kevin Tian
	<kevin.tian@intel.com>, Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v3 1/2] xen+tools: Report Interrupt Controller
 Virtualization capabilities on x86
Message-ID: <Yhzr739VZdRLWnok@Air-de-Roger>
References: <20220218172943.12182-1-jane.malalane@citrix.com>
 <20220218172943.12182-2-jane.malalane@citrix.com>
 <0a31970c-c0f8-c995-ce04-67523a4a830a@suse.com>
 <YhyrAyxhNtNWi7NY@Air-de-Roger>
 <9aff51c2-0e8c-685c-7bff-0ed7ff7347c7@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <9aff51c2-0e8c-685c-7bff-0ed7ff7347c7@suse.com>
X-ClientProxiedBy: FR3P281CA0075.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:1f::23) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5bb60c44-2544-4a5b-d6a9-08d9fad010d9
X-MS-TrafficTypeDiagnostic: PH0PR03MB6640:EE_
X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
X-Microsoft-Antispam-PRVS: <PH0PR03MB6640DE1517B05738F654B4078F019@PH0PR03MB6640.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: KyjF8zhFyaM0fJ44QVEqhMKe+XgNn7b6kdDXgizrsVTzNCffUHCJEQvMkq/Fj/guxPxdSQtjPXR2sJ/rjm1yLCrBWJ20p57gs4mbNQyir0h5jWGJBQuznRfnkbqU/cWCO45XNz9z6LfIoKyJ1J7TVy6+3rAyxob8I75oejpy+QGLahasfJrhpuNYEBvJYkZ4RMZKGAFhfDOG1sSBPx3Aq4HqhZLO0ywdBW4yLrL94q3kBGL7TGKJAqbw2igb+hy4QC9aaS6P6M5Y+j5dFaNeRfi7rEDC2a/WzQlUldflQRw9yRi8gIiB4gQBZgMS5egan9zPWRSVaW5HAW/SP37H18rzy9oJiOccwC1wWpfucSODZs+lec49gJ79lPcX/qXNGCg97XEI7D8ka2WrNQ1TX2wgOwfe/cbj3FZSBFUfzmNoE+9sh9fm15fshcDvieefdvXMRwjTSbQbp+/BUG74j9FbOOtjAdWU1X11v+YDevPW6/xbDJBE263+VysgQOsTEvtSn1i8WT7sD3bcfTTgKLCb5tDt5iUU12P0TL3zFNymb/KJu7g+xpYf0whl8V2sPqNFu3rqcMPAQMIP5sRFL4rSUTYoKboOyKimIEFSb/DjO2IMnqIhJv3ijJLLfgeLBQmLk2sL3NJPLgJxhutaNQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(53546011)(8936002)(83380400001)(2906002)(6512007)(7416002)(9686003)(38100700002)(82960400001)(5660300002)(6666004)(86362001)(85182001)(66556008)(54906003)(508600001)(6916009)(4326008)(8676002)(66476007)(186003)(26005)(33716001)(66946007)(316002)(6506007)(6486002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TmpoZFhLK0ZlQmx1cjRGbndqRUp4T0NQNXFlWW81OHlGZlBvN25Ua3JWR1FI?=
 =?utf-8?B?ZG5aUGdXeVFQakRpamZtL2xubWdpS05DRVIzbHhGWnlpRzBOSnNCYXlMWGtm?=
 =?utf-8?B?T1hpYmFuaTFVQW9qYmpOYzBCWW0reXJVU0o2Zm5sejNMYUNUckpOanlZbm5M?=
 =?utf-8?B?clJsclBiZVRpZDE3MTU3aS93RjdKdktvWkEyZjZzS1NBdi9tekJReHk5T3hE?=
 =?utf-8?B?WmlpZXc0SWNaVzRFZVJzZDcyMlVaVXpBRUpMMTFlZ3JpU2dvZVpZTWl3SzV6?=
 =?utf-8?B?MnNMbFhkZkFWZnRCSjhmSUsrRFp0bzRNdE50TmVSb3RGUGZGSXNwbVRzRDIx?=
 =?utf-8?B?b2xmTjdjcU15SHdwTVZTcVpKdnZyRWNmdy9JbGpzT2V5RFV4bDlXVW9hYWo1?=
 =?utf-8?B?M2N2T2E0RFZWWkxpMFRhQnZxNmJFWlNQdnZ1N2M5azhQSHFQdlUvQWVUMjlS?=
 =?utf-8?B?ZXIwdUN4M25LaWVicjBZYmVWZHJRQXUydEZ6djlGSThzd0UvY3hoQ3ZUb01M?=
 =?utf-8?B?VitTejdWK2NFM2pibmErK0FncXl3cVNQMjdKYjV0Nnd3dGlWME1oL2hNaldX?=
 =?utf-8?B?STBBWTRrM296Y2Z5MG9FMG1OWUtlS2t5VFRtL3dyazFwNzl2R0gxZTRhSDZt?=
 =?utf-8?B?V0F2M3lYU3dEMnBYaHlwR0J6a1BGVkJOaEFFeFdPS1EwTDAxQWJ3aWF5em14?=
 =?utf-8?B?dkloR1ZybUhuNVhVQS9veGV2Z0Frb3VXNE0rVTlsT3BUUDdsSmZNdHJLZjJv?=
 =?utf-8?B?VkhhSGVrVEZoN3RzM2laMzFwSzg2NUwrNWlVYlNkRWRUdi9aT0hpZXBIZWR3?=
 =?utf-8?B?RElwYTNiWWlYVDAyNGJzT0lxd0o1QkFQbk1zZzZ2WG5EU1B1V1BuWXJOb0hz?=
 =?utf-8?B?Z002c0FvZTBpSHZ5Y1BIdzdKa0hwVU8ySmVSODFrUTVYUXVYQlFQTFRCY1E0?=
 =?utf-8?B?cGRwaEVXVWRiZ0kxNkdhZ282Y3d2cS83UXMxQVYyRWdGQ1RjaklOaFovVThE?=
 =?utf-8?B?aWZldnJkWkFOd3FkbHNScmpGTkxSNkdTdFlhOFYxbmFsOE9nYnp3VHZ3eWdi?=
 =?utf-8?B?VzI2UVY1ZlhCTHhJRVpPRElXR0Z0ZEJOK1cwcmdvdVovYXA4WDhOenpCZVli?=
 =?utf-8?B?ZytZZkVSbDJUb0NMdlFCYytxUE9zK1RiUittcmJ4ZmE0T1p1emtyNmtuRi8r?=
 =?utf-8?B?eXRJUHRUZVA1RWtlY3h1R0VYalc3U0ZrMGtwOFBidG5kR0RJV0JRT0phZFE5?=
 =?utf-8?B?dzVMQXF1eklDZ2lDREp4RTF0eEFQZDlpMHNMVXRmeVpteXlzTGN1WVpab2xo?=
 =?utf-8?B?ekRmTjZUU2dWKzliNjZCSzRJM1RTenJRVGYzT0J3YThZSnJFelZNUnF4Q3ov?=
 =?utf-8?B?dXk0SUoxOUZBeXIvUThOK29USzkxSmhFN3N3S0lXL25rdVRhRVZBN2JIcGdS?=
 =?utf-8?B?Ly9ZeUFxS2JQSG5nYUVHQkRPdmxodkZoTTREYlFxdlNEMkVNNFlub2NwekxD?=
 =?utf-8?B?YitXQWEvRktVQVpiTXV0dFd0dGtNYkxnRFlMWjRFSFhDSWJidUF5TXJKdXdh?=
 =?utf-8?B?bnNLTU44bHlyeGtWZzZnQ0xxMUlod2JGU296VlA0TGx4TktTeWJ3Q0xBTXlU?=
 =?utf-8?B?THF3SGR3UlZwZitkckVockEwbmp1cXQ4UDdRYngwVGtZTGloNUtoRDArd0M0?=
 =?utf-8?B?ZDRxS1ZjY1A0akhkcFRvRmtkTStycGNQUDNTbDRwMmdoNEdCc3pia1FOeDVB?=
 =?utf-8?B?T1Jod2Rad2ZvaTNGS09hYjdoejBRb09ITzZTRzVkcUtadFd4UmdiS0h5ekF6?=
 =?utf-8?B?SCt5NW9NbkpZK25jS05Jd200Q24wcGdBaDVmR3VTdnpoaFBwQTJEWllUWFdX?=
 =?utf-8?B?SEs4S0FLLzV0N2VxTUhHbTUxZWZNNWtDMFBrZTFkV3l6OEJ1b0VFdjBFc3lD?=
 =?utf-8?B?ZktTbkQzaFhVWGh5Z3dYSTkyK3VrNkIzaHR0RnJLUGRwU29qMWZ1WnB1dHUx?=
 =?utf-8?B?eVJUVlRyYnh3SDNVa0NaU0R2cUlzd2xyQXpYa1paeGIxTHhETTJtUHlBVDMv?=
 =?utf-8?B?YWZZUUwrSCs0RGNtV29rN284TUZoa0F2Y2VkWWJsdit4a2hhOXVkMGZrVEJ2?=
 =?utf-8?B?R1FIMWdFbUdXcWpXc3NkQi9MZWkrbmFkSm1FSk1VaW1UMlU3aU1xOU1kQnY1?=
 =?utf-8?Q?z7Z8eRu+tf8yVaD+897muWg=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5bb60c44-2544-4a5b-d6a9-08d9fad010d9
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2022 15:36:19.5457
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8PGIE18F7MJSfbnvn446FM5Seb5tPWFrsuO3La/a3m+Loi2C3zzFF1Vlen2CvD+jI82Ds3xCyJya/GI0wgdg4Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6640
X-OriginatorOrg: citrix.com

On Mon, Feb 28, 2022 at 02:11:04PM +0100, Jan Beulich wrote:
> On 28.02.2022 11:59, Roger Pau Monné wrote:
> > On Thu, Feb 24, 2022 at 03:08:41PM +0100, Jan Beulich wrote:
> >> On 18.02.2022 18:29, Jane Malalane wrote:
> >>> Add XEN_SYSCTL_PHYSCAP_ARCH_ASSISTED_xapic and
> >>> XEN_SYSCTL_PHYSCAP_ARCH_ASSISTED_x2apic to report accelerated xapic
> >>> and x2apic, on x86 hardware.
> >>> No such features are currently implemented on AMD hardware.
> >>>
> >>> For that purpose, also add an arch-specific "capabilities" parameter
> >>> to struct xen_sysctl_physinfo.
> >>>
> >>> Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
> >>> Signed-off-by: Jane Malalane <jane.malalane@citrix.com>
> >>> ---
> >>> v3:
> >>>  * Define XEN_SYSCTL_PHYSCAP_ARCH_MAX for ABI checking and actually
> >>>    set arch_capbilities, via a call to c_bitmap_to_ocaml_list()
> >>>  * Have assisted_x2apic_available only depend on
> >>>    cpu_has_vmx_virtualize_x2apic_mode
> >>
> >> I understand this was the result from previous discussion, but this
> >> needs justifying in the description. Not the least because it differs
> >> from when XEN_HVM_CPUID_X2APIC_VIRT would be set as well as from what
> >> vmx_vlapic_msr_changed() does. The difference between those two is
> >> probably intended (judging from a comment there), but the further
> >> difference to what you add isn't obvious.
> >>
> >> Which raises another thought: If that hypervisor leaf was part of the
> >> HVM feature set, the tool stack could be able to obtain the wanted
> >> information without altering sysctl (assuming the conditions to set
> >> the respective bits were the same). And I would view it as generally
> >> reasonable for there to be a way for tool stacks to know what
> >> hypervisor leaves guests are going to get to see (at the maximum and
> >> by default).
> > 
> > I'm not sure using CPUID would be appropriate for this. Those fields
> > are supposed to be used by a guest to decide whether it should prefer
> > the x{2}APIC over PV alternatives for certain operations (ie: IPIs for
> > example), but the level of control we can provide with the sysctl is
> > more fine grained.
> > 
> > The current proposal is limited to the exposure and control of the
> > usage of APIC virtualization, but we could also expose availability
> > and per-domain enablement of APIC register virtualization and posted
> > interrupts.
> 
> But then I would still like to avoid duplication of information
> exposure and expose through the featureset what can be exposed there
> and limit sysctl to what cannot be expressed otherwise.

So you would rather prefer to expose this information in a synthetic
CPUID leaf?

I assume the duplication of information will depend on what we end up
exposing with the sysctl interface, whether it's just support for
SECONDARY_EXEC_VIRTUALIZE_APIC_ACCESSES and
SECONDARY_EXEC_VIRTUALIZE_X2APIC_MODE or there's more to it.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Feb 28 15:49:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 15:49:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280673.478700 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOiGn-0003jO-8F; Mon, 28 Feb 2022 15:49:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280673.478700; Mon, 28 Feb 2022 15:49:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOiGn-0003jH-5C; Mon, 28 Feb 2022 15:49:05 +0000
Received: by outflank-mailman (input) for mailman id 280673;
 Mon, 28 Feb 2022 15:49:04 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=o1tx=TL=citrix.com=prvs=051234957=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nOiGm-0003jB-3T
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 15:49:04 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f29ddffe-98ad-11ec-8539-5f4723681683;
 Mon, 28 Feb 2022 16:49:02 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f29ddffe-98ad-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1646063342;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=SLTMeNAyWp1pOQMj8ghkab6pelZ8+PTmJ+vAsKFTlAY=;
  b=if4JAMK6v0G7iSEQWpoPf48jBkisCFmqY9qNwCXwk5CyisllTtReOBQf
   XehiWwvkhx8g8ggndrOwBXC0o25qvshOPoQtk+2bEqBGz7jqfSNbiZDmN
   JCB0kDUoINKaBwEi94JAuklUBk2SyvgPAQOVsWTMMzMf4esx/L1s+wCv6
   k=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 65138085
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:xA9L36meb9v9dK0vAEbJRjDo5gx9JkRdPkR7XQ2eYbSJt1+Wr1Gzt
 xIfX2mBaPzcZzf1Kdp2PYy/9U8AvJ+EzdVmHlY/qSk9QyMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EoLd9IR2NYy24DjWVPV4
 LsenuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR
 v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ
 NtxWZOYT1gDGb3moOQmcyZFORNSfv1oobnHGC3q2SCT5xWun3rExvxvCAc9PJEC+/YxCmZLn
 RAaAGlTNFbZ3bvwme/lDLk37iggBJCD0Ic3oHZvwCufFf87aZvCX7/L9ZlT2zJYasVmQ6uHP
 JpBOWcHgBLoaEBqPWwOC8IHm6S11lb8Kxty9W+kuv9ii4TU5FMoi+W8WDbPQfSGTNtYtlyVr
 WXH+yL+GB5yHMeE1TOP/3aoh+nOtSD2QoQfEPu/7PECqE2ewCkfBQMbUXO/oOKlkQiuVtRHM
 UsW9yEy668o+ySDcN75WBGppW+eiTQVUdFQDu4S5RmEz+zf5APxLncAZi5MbpohrsBebT4g2
 0KNntjpLSdyq7DTQnWYnp+WsDezNC49PWIEIygeQmMt4db5p5oopgnSVdslG6mw5uAZAhmpn
 WrM9nJnwexO04hbjM1X4GwrnRqq+bLuXiQN5j73YX+P3C86NKD8YYyRvA2zAel7EK6VSVyIv
 X4hkseY7fwTAZzlqBFhUNnhD5nyua/bbWS0bUpHWsB4qm/zoyLLkZV4vWkmTHqFJProbtMAj
 KX7nQpKrKFeM3KxBUOcS9LgUp96pUQM+DmMaxw1UjasSsUrHONk1Hs3DaJ144wLuBJx+U3YE
 c3GGftA9V5AVcxaIMOeHo/xK4MDyCEk3n/0Tpvm1Rmh2rf2TCfLFepUYATXN7xntPPsTODpH
 zB3bZbiJ/J3CrCWX8Uq2dRLcQBiwYYTX/gaVPC7hsbce1E7SQnN+tfawK87epwNokimvrygw
 51JYWcBkACXrSSecW2iMyk/AJuyDccXhS9qZkQEYAf3s0XPlK7ytc/zgbNsJuJ5nAGipNYpJ
 8Q4lzKoWaweGmyaoG1GNfEQbuVKLXyWuO5HBAL8CBAXdJ98XQ3ZvNjiewrk7i4VCSSr88A5p
 tWdOsnzGvLvmywK4B7qVc+S
IronPort-HdrOrdr: A9a23:A+YQDKAdi/peyb3lHehIsceALOsnbusQ8zAXPh9KJyC9I/b2qy
 nxppgmPH/P6Ar4WBkb6La90Y27MA7hHPlOkPUs1NaZLXPbUQ6TTb2KgrGSpgEIdxeOktK1kJ
 0QDJSWa+eAfWSS7/yKmDVQeuxIqLLsndHK9IXjJjVWPHpXgslbnnZE422gYzRLrWd9dP0E/M
 323Ls4m9PsQwVdUu2LQl0+G8TTrdzCk5zrJTYAGh4c8QGLyRel8qTzHRS01goXF2on+8ZuzU
 H11yjCoomzufCyzRHRk0fV8pRtgdPkjv9OHtaFhMQ5IijlziyoeINicbufuy1dmpDk1H8a1P
 335zswNcV67H3cOkmzvBvWwgHllA0j7nfzoGXo90fLkIjcfnYXGsBBjYVWfl/y8Ew7puxx16
 pNwiawq4dXJQmoplWy2/H4EzVR0makq3srluAey1ZFV5EFVbNXpYsDuGtIDZY7Gj7g4oxPKp
 ggMCjl3ocXTbqmVQGbgoE2q+bcHEjbXy32DnTqg/blkgS/xxtCvg4lLM92pAZ2yHtycegB2w
 3+CNUbqFh/dL5kUUtDPpZ1fSKWMB2FffueChPbHbzYfJt3T04l7aSHp4kI2A==
X-IronPort-AV: E=Sophos;i="5.90,142,1643691600"; 
   d="scan'208";a="65138085"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=VXHGh6HxSsCD+kvjqQwo2ZTDx5Mgo07X7xS6qZtGMaP5BWH84Sw0+2tZ+Yukvqs6xbPPzgyy74u0PDO3spqf5Bo9riXltcdFdjpCH//PjLN0rg9s4/9WPT44pVdxbVntJW1mocoShn/LRo+mb8LKBpK4vVMzF+k8maNVX9yhph0NH5kwBa6jIt1n/bWrSh8Ehkyya8L4PFsgzDBSafFmumvAI6g8dGRVB6bE6Fp4UkkrXVzSAHIwzaCK7Eywvh9ScyKoDGIL/A8KR1Sci6TP4xs81kYpGTqTZiR+WiGbyhLrMJINVGUvbYOffl97HV3gYNpZphzVBxxLABJ+FuLioQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=EviJzek/VgaKIwmpYv68rb/xedmx7IJgHzq/Efl13DY=;
 b=YmkTuqsoxQbkfO4A2QoDwjAGY0F8yTAl6Wuscn0rf/wz+V/6nb6WLB4rNeMtpPURoBEm1JkKqDm1jtWUWFoP+85qKAxWKdV6sR/7+LbEePbFY2XtmRIxVmlFfqt0ndZ5zWpimuUpVO+x/IIvz3XQ+gk6HMDJ7XFlhXt5aJS0ofrbra7m0NW+WH9bTUMBVTvijZYRcH35rQI+WcFPL8JtBBZ/YeBhfeRm/8stAx+vyowymiMvhqD52paGkGe1ySbvEnrQ2Gx/SBKBy1ZMssOMhFelo22sTIxXgjThdQvzC6KbwlIf1tH89Cnxk6Pa0yEOvtBpWdw7iYJbJ9y9OaYE2g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=EviJzek/VgaKIwmpYv68rb/xedmx7IJgHzq/Efl13DY=;
 b=HUmGdgK2gRg5mf3cOGIL1PJuKCllSHBhNZUmZdqWJVdPMhJsqFLZ6KyoYzHboYAXMH2sgDMQlNk9GwcQYjqUNb3O535UGyMFVMkLsspm4QTv7KACTYDbN3etK3uYN79OR1h3wFGXGTof7iKnqK7uBm5RQq2jU0+LTGfEiPP36IM=
Date: Mon, 28 Feb 2022 16:48:48 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Jane Malalane <jane.malalane@citrix.com>, Wei Liu <wl@xen.org>, "Anthony
 PERARD" <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, "Andrew
 Cooper" <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Julien Grall <julien@xen.org>, Stefano Stabellini
	<sstabellini@kernel.org>, Christian Lindig <christian.lindig@citrix.com>,
	David Scott <dave@recoil.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v3 2/2] x86/xen: Allow per-domain usage of hardware
 virtualized APIC
Message-ID: <Yhzu4Nl2dY80KXss@Air-de-Roger>
References: <20220218172943.12182-1-jane.malalane@citrix.com>
 <20220218172943.12182-3-jane.malalane@citrix.com>
 <b83773ec-c97a-7aea-e61a-c2e34b270816@suse.com>
 <Yhyv6Ui4ap1wOeNd@Air-de-Roger>
 <7ad79609-bd67-aa44-56e0-1070f3ee88f7@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <7ad79609-bd67-aa44-56e0-1070f3ee88f7@suse.com>
X-ClientProxiedBy: MR2P264CA0013.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:500:1::25) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e94eda04-2200-48cd-df79-08d9fad1d2dc
X-MS-TrafficTypeDiagnostic: BN7PR03MB4402:EE_
X-Microsoft-Antispam-PRVS: <BN7PR03MB4402691BA4FAB9B2D55DEF0C8F019@BN7PR03MB4402.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: fBdUH22/2vyknuhFCOwIdQ82lgLrTKOKVSDxcqIrNPIsrpclLs4r0QC+QYVVuvcV2EbK86xaQE5NDHW7mCVTVBFGSGoHWvfkMLhp+J+rNXcL9tPaidC12XgM1lAZRKxHE2XzfbAKhlm8XLBS5Ml71vRR3uoC+XKYd4CA3T6HJ57b2vKadvp7EYHOtxKyO2rtaF2GYKOfVrYo82nHcA9ToVg7W7n3F9kNFftcDaoBbzPIdbjfeQEp8OnasBysUVF0H8oLBLmBA5fsNFcJubL0yDuHoMQGuiG2glVvyg3sYOjBxth9G+8QnqfxGOv2mktfuMahpYXoum9ToqPuaZVu8AIlAXOrMgoXM6wsQeZ9XcW6lgSYVFFEYrxgHNj1Hzqg4jOskYdApTBQgObxrYyPRzblyRS88+4DdSVGLX4xGHcRfp7DGeqbqzZcwt99TBOZw40SsJzCZxTzlAjNeHjJIUhyq7avvRfJsIIlpZqWCc+m+P9Oczobz1YlXAjIvkmyoHYXy9g4Tk/WbFSmKUPxAVCyh6ppUnrWN0GQv6RR6sEHVza8p1aJyiinGwb9MDGzAx0P34ujrHL84jY48EC3cPqdhZA5vRz5Ym3BtSVbbB1zzGUnBrF+L/quKFMqHGuAqQ0FfVdkIf9rX4+3l9Nlyw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(186003)(26005)(83380400001)(9686003)(6506007)(6512007)(6666004)(53546011)(508600001)(6486002)(54906003)(6916009)(33716001)(8676002)(66946007)(66556008)(66476007)(4326008)(8936002)(5660300002)(2906002)(82960400001)(316002)(85182001)(86362001)(38100700002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dmhTRnNKa1BQd1lSR3VLSlJPZjBzRitZUDk0MktEbkxQY3hFcnpxNmZHREFQ?=
 =?utf-8?B?cWlKVy9BWjcxekZyOHAvVGVTenROdXRlWHE3QUR3dzdheU1hM0lHRGozUnpM?=
 =?utf-8?B?RllQYy9hUWU5Sjl0dVZiYTdZVGNPRWRIMGZqWlI2dEwrY0ZPb09ZN2pFcXNT?=
 =?utf-8?B?cXhCcWw5U1orWldmdXJOTkx5cExWdDZZRWFjRzk1NTFqZklDWVJtci9PaHFj?=
 =?utf-8?B?UVkwNVRid3NJWEU4RTlDOE5vNlpBcmorQmZodDRFUUMrWExtelFmREhGMys1?=
 =?utf-8?B?ZHdJK21hQ0FkWURINDhNK2tPaUF4Nk5JN3owc245eVBlR2FZd1FQNmhNT2tn?=
 =?utf-8?B?SjdjWGloK0VxbTk1S3hlemtxMTRPczY0aVNoN1RaLy9SNGVuMW8yYU5ycFlr?=
 =?utf-8?B?R3g5YUJrelYwSkFyRFloZHcrVzlBNlpJZXc0dk9DQjY0cEJpMVF6SGV6KzZJ?=
 =?utf-8?B?STZIditNS1Fsa1krR292ZmRsWUR5MlhMUThhbjhzRjIwemhPZzdQYW9LK3E2?=
 =?utf-8?B?bmtaU3RvNGlEVnJiSm50NzJxNkowSUpEZUN6dzhlN3JpeUJuelBmNnU0aCs0?=
 =?utf-8?B?NFFFYW5CUlJ6N013b3NZc2dEN242T281YUdGeU5QaHMxMmVRdGRTbFNScjFG?=
 =?utf-8?B?NWF1VXRJYUtPYVdsNXE4WXd2czRIZllyL0REOCtLQ0I4WmU2VlJ6VGNWSzk2?=
 =?utf-8?B?SVd5T2UvWHlwZTV5T1E0T3dsdENsc1NPZERDNlRtUEdmd0N5N2ZCSEc1MHI0?=
 =?utf-8?B?S1FOWUdPSmVKMmxoaTJDVkF1cUIzZmQwUnNsQ25EMmhWbWJZU281QkdOZWgz?=
 =?utf-8?B?NG5aLzdGVHZxSVFZdjNvUGhsUXJsNzJFQkw0bGpaUHhVbm00ckpOSVlyYXkr?=
 =?utf-8?B?VG9NSU5KeGpVWTZCUThmelMzM0dHeVh1WWtzTEJPK0xOSjl6QW44MnlXNEtF?=
 =?utf-8?B?aEkxMzNVbENQd2NIMGJmQXV1cjR6NVoyaTAzWW5yWnFYN28zL05kb0VwZGpS?=
 =?utf-8?B?WkVFLzNlZ3prTnFSOElWa3QwRkxUUG8vb1J6SVJlNDhON3JIREk0ZEVvY1E3?=
 =?utf-8?B?alNNdElkR3drUU5jU0pMNFZMemhxT1cwVy9qQnRONVdJOG50M2xPalY2VEU5?=
 =?utf-8?B?SVFja2RNdGpmdEticytxWlU2RmZBTnFjUWEzTWZYSUdBREpkVHFhZWdpcCs0?=
 =?utf-8?B?enhGRWlVM09SRWdRUzJSQ0UxcXl4RVZuSU5wcnRaa1p3UU9tL0xZYWNtdFR0?=
 =?utf-8?B?SkMvbmFsRzhGTmhPcVJ0ZGtySzlRQ2h6VXdCbjhiMC9iV1h6MWt4NkM1K2Vo?=
 =?utf-8?B?ZS9jZzJPaDBjdHhqTk16Q0JKeUVtSXdRU3NraWpSMWY3M1ZvNmovdGRPb2ox?=
 =?utf-8?B?am5NQjQ4SFQyVEppUXdYdG15cE96Z2REaTBiUzRVN1VUaHNNc0FWUTVRb2Rl?=
 =?utf-8?B?ODFmdDlIdHN3WGdvaUx2WTYyL3lZeUxLUFlaVXBoR0ZyRkx5M1JoMWFGVENO?=
 =?utf-8?B?bEh6MERjS2tmVGpJVlRFU2tMb3FlUWZ6RHB6ZWdWZU10ZzJ1VHlWVGtMWXpD?=
 =?utf-8?B?NGt5UHRRS1lGbmQ4WVg1ZjQ1dS9pUXRjRlJ6RURXVFBoN1ZxNjNNV2xDTUFO?=
 =?utf-8?B?NnNQUEZCUUZuMHlxcmZJWFpQV1VKUWRweiswTVJ5dlBQOUViTzR0bC9nMVYr?=
 =?utf-8?B?TVpmSVlUZ2RmbEtBOURHQVJNL2Z5S21SMndjYlFsVzlvbldVWmJOQkpjQ3c4?=
 =?utf-8?B?aGdaZWE5bzFxTFRmMVFWc2c2b0N4UWpwSUNsNzFYajZKaFhkR2N3bGovMVY0?=
 =?utf-8?B?OFFXRCtvY20xaW5RaXFiWTVvWFBRR3IxVWF1RFVDOC9UVkVKSmFNaFpyNy83?=
 =?utf-8?B?MjJYemRpMkxUTzJoRmtkYjBmYUlJTE9BSmp6K1JLdnJtdjVpQjlvSHJ0S2dX?=
 =?utf-8?B?SFhvOTFGT2h5azdOdmV1a1Zvb3NKYmo1WFJRV0xpd3hjdEo5WUpVRUx6QmlL?=
 =?utf-8?B?aTB6bFVCZmFoVWJRdVhiN1hLZ2lnWnlJbUJqb3dWYXpCT1dLbmxTVTl0UUlL?=
 =?utf-8?B?SDRkZC9uZURZNDUyWmtha2pKRHNlTEhCVFhTTThWcDJzN2E5Tk9hZGYzRDQ3?=
 =?utf-8?B?SXV6UEhydDFmbnpzeDJPY3liUG9YYVZCbDJPWm0yaUhhN2xQbm5vN1RiQVE3?=
 =?utf-8?Q?O2jcMhUDtbqXK22qQwma3QY=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e94eda04-2200-48cd-df79-08d9fad1d2dc
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2022 15:48:54.3854
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: faD1g1MDkTAtHofmOaorcPk+rnNF4jKOHNwkdcuFvT2FU9C+NMxkzwBsCLjEaLIy6CWbZGcVkn6aUD/s5fJfHg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB4402
X-OriginatorOrg: citrix.com

On Mon, Feb 28, 2022 at 02:14:26PM +0100, Jan Beulich wrote:
> On 28.02.2022 12:20, Roger Pau Monné wrote:
> > On Thu, Feb 24, 2022 at 03:16:08PM +0100, Jan Beulich wrote:
> >> On 18.02.2022 18:29, Jane Malalane wrote:
> >>> --- a/xen/arch/x86/hvm/vmx/vmx.c
> >>> +++ b/xen/arch/x86/hvm/vmx/vmx.c
> >>> @@ -3333,15 +3333,15 @@ static void vmx_install_vlapic_mapping(struct vcpu *v)
> >>>  
> >>>  void vmx_vlapic_msr_changed(struct vcpu *v)
> >>>  {
> >>> -    int virtualize_x2apic_mode;
> >>> +    bool virtualize_x2apic_mode;
> >>>      struct vlapic *vlapic = vcpu_vlapic(v);
> >>>      unsigned int msr;
> >>>  
> >>>      virtualize_x2apic_mode = ( (cpu_has_vmx_apic_reg_virt ||
> >>>                                  cpu_has_vmx_virtual_intr_delivery) &&
> >>> -                               cpu_has_vmx_virtualize_x2apic_mode );
> >>> +                               v->domain->arch.hvm.assisted_x2apic );
> >>
> >> Following from my comment on patch 1, I'd expect this to become a simple
> >> assignment of v->domain->arch.hvm.assisted_x2apic (at which point the
> >> local variable could go away), just like ...
> > 
> > I think we want to keep assisted_x{2}apic mapped to
> > SECONDARY_EXEC_VIRTUALIZE_APIC_ACCESSES and
> > SECONDARY_EXEC_VIRTUALIZE_X2APIC_MODE respectively, so that in the
> > future we could add further controls for
> > SECONDARY_EXEC_APIC_REGISTER_VIRT and interrupt delivery.
> 
> If we want to be able to control more (most?) VMX sub-features, it
> would seem to me as if this would better be modeled accordingly
> right away. At that point there would likely need to be VMX and SVM
> specific controls rather than general HVM ones.

I would have to check the AMD interface for hardware APIC
virtualization support, I'm not sure how different the control values
are there.

> Plus then it might
> make sense to match bit assignments in our interface with that in
> the VT-x spec.

That could work for things in secondary_exec_control, but posted
interrupts are controlled in pin based exec control, so we would need
to expose two different fields? Not sure it's worth the extra effort
to match bit positions with the spec (or maybe I'm not understanding
this correctly).

Are you suggesting a (VMX) generic interface where the hypervisor
exposes the raw vmx_secondary_exec_control and possibly
vmx_pin_based_exec_control and let the toolstack play with it, setting
in the VMCS what it gets back from the toolstack?

That would imply quite a rework of the code in order to detect enabled
features based on domain specific VMX fields (instead of using the
global vmx_{secondary,pin_based}_exec_control variables)

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Feb 28 16:12:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 16:12:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280680.478711 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOicy-0007YU-35; Mon, 28 Feb 2022 16:12:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280680.478711; Mon, 28 Feb 2022 16:12:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOicy-0007YN-06; Mon, 28 Feb 2022 16:12:00 +0000
Received: by outflank-mailman (input) for mailman id 280680;
 Mon, 28 Feb 2022 16:11:59 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=A4HT=TL=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nOicx-0007YH-0u
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 16:11:59 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 26c9b2e7-98b1-11ec-8539-5f4723681683;
 Mon, 28 Feb 2022 17:11:57 +0100 (CET)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2054.outbound.protection.outlook.com [104.47.13.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-36-3EmJ1TVfPHmw579lCpig-g-1; Mon, 28 Feb 2022 17:11:55 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by AM6PR04MB5013.eurprd04.prod.outlook.com (2603:10a6:20b:3::20) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.26; Mon, 28 Feb
 2022 16:11:54 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.026; Mon, 28 Feb 2022
 16:11:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 26c9b2e7-98b1-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1646064716;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=usePhEfemX5hy7zllvdwphaC1o+xYGJFNEu6k5DquK4=;
	b=ms5R7eRqQbF5s4LaMeMjjhl6G8pNPW4Cla87ED5P5ssKShkqnITtM99zsASLsR+QBDYXK2
	AG7e22SyBal/tybZoK4lw8IEkwFYFFeXqCQAk/hvblpIusUfudwUACy2hUCeOH5qrJaI1q
	QpgUym3KQYsVK3LJ5aqYY15955Kbqts=
X-MC-Unique: 3EmJ1TVfPHmw579lCpig-g-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=LGGTb4WyNt1LVViqmFMuN3VPf25AB/13s3qIpoOKqEAQawqkRC6XO+0Rd6BI2XIL2VwuaKp3y2bBeozqZNx40169Q67hQg3twJHODcXA6rjcP8lUGVR/7/ozKCJwRmBb0QGvAuFC2FdM67ZKFUsDcPKjaYUbtcxdeaTTcFec6hB4aKMF1bsRIqnqCpQoDwmQ0VHjgFKlHH29L0FamoIuK/HU9RjLoLwiN3ITShRViXE0M+6LgnNeAtnYP2lODLFuwrPK/D6WDGP8Lh8HThWNzLmOlPt7o7OiLE70whqUwkVv3mO600xpZnxInOZb1utp6qZEdGrrD/UAHoNxWsEROg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=usePhEfemX5hy7zllvdwphaC1o+xYGJFNEu6k5DquK4=;
 b=T+hxd5k/H6Ylp+vdXw13J6PDyZb9ew+Il7afiKBWKCwJWIxLzEVQywEhDgrRUdBjnrprRLirYXBTTPuJ3tQS7jvSRsbVX2EWtHaNCO6flJ/r304zVViWTlkogx+z3PDs8yrIFy6m0IAEeZ4cxVXqJz6gIiUPOBJndfBoRfhXU8i/jafhEpCkvLlvtgnQUZ3y/5KevWhc0Yuc3xAFziH3BFgUNGUlDBJfpnCManalN/uhsiXAv9zc3HLeq5fUkk8c720HfUr0W1KFZ6vBFwxmFPBhiMn4a7n8KcgJ9y6WFohTyumj08iECsUNZtR2mndbadGGPp9ZUyHXFsu+7DmRDg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <ff363631-bf5c-83a8-ccc4-15ddd1eb1d3c@suse.com>
Date: Mon, 28 Feb 2022 17:11:52 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Content-Language: en-US
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH] build: export potentially overridden tool chain components
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR08CA0046.eurprd08.prod.outlook.com
 (2603:10a6:20b:c0::34) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: cbac6bf2-6acb-4c42-85d1-08d9fad5090d
X-MS-TrafficTypeDiagnostic: AM6PR04MB5013:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR04MB5013E4D4FF5C42055B2D7569B3019@AM6PR04MB5013.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	W08jzayvsGHQEl2cFmN2RZ6zYjufmIr3JGqNNchEB5NkEUTTlfzFGeRnmsrSGRLHIx86TIlqYmHpctD7KExWY99KZtLtIaVbabVhs0hFdfka4qkZBPo9M57nhQpGQTXv2Bqmmm1U4xGeyyROUonG5l2u0Dp8xlWu+9aqvwpPiyzU2htTmT2rYjqpugf0uMvL1h+7/P+Eub7OPaKoX24SbTsXl2AXu7r7J/2iinoeg7kl8bR9gW8o93RbMyLGPAiFkIglMpaXAnhlgETiBdBGcwv32AZ7AFMervrXGY5XzAuE7YngOIkbTGE+0FjXG6B4kToXQHIMgltXq0bOTQrkJ5iuVTKcJy6wVFSomz1N145DnSJ8aXIyimHxJ6dTUYt17vTxU5Y0xE27a45lmu25i3nqR+UPC+XRWdQ7X3W70zVx0yCMyab1XvZuBllKBL1lKEqfOUYboapF3wAOkhEBQJy83E6mBIo8LT1lbqfBKfM2lOwdWsl+4Ig3C2sLE3SUSdO+kx3xxxwsq8me7191RLfAvELvXbhNLxoyBjxlpGGRVgBkaVVtqci2z/FphT7qe/Tmuwg6MsySruBzhLICR/6ZditWh9lzsb3a82HYBv5/0o1fTYtFXBtuXT+gc+cFtb2pa/XK/xtavsJulcfjTh8FKA16HRJTAsR0rKlEh+WRj+iGs4X01U+0ouLRTtDmDIxa/4uXt3PPpfYoUrxZm8wv7ZXUksg+vwRwYMebfvw=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(86362001)(6512007)(6506007)(36756003)(6486002)(508600001)(8676002)(31696002)(2906002)(5660300002)(66556008)(66476007)(83380400001)(4744005)(8936002)(31686004)(66946007)(38100700002)(186003)(54906003)(26005)(2616005)(6916009)(316002)(4326008)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?T1B0Rmd0WDYxNmlXV1BOaE5jcTV6WGJRbi9kazYyRnM0bHZIczlJazlwVVZG?=
 =?utf-8?B?Mm9KTmxObDR4RlhOclA0Z0w5R05OdjFEMXJZbGdaeTZlNWIzV3BSL1BXLy8v?=
 =?utf-8?B?eFRwMTN3Vmdtdm1HUS8ra2JZZGY3S085aFliZ2hvV1NEb3lFUThtenh3VUQ0?=
 =?utf-8?B?aW5oSm9MTEphdXNoUERHSFJaRFFmRnlzbitjbFFYV0VVVnI3dys0M0E1Z0JV?=
 =?utf-8?B?TEdSMjh6blBRMzJLdzg5V3hqejBBaFJBblBiRXUwSjg1RUpTU0wrVEdVNms5?=
 =?utf-8?B?Rm9xTWxGQlZaMWFTY1pnZFFsQXNvaWZ1SThFZVZiZWZQMXdGWXpoOE8welNu?=
 =?utf-8?B?SG1sRGYvNUVlNlBaUTZIWHhQNXlKb1FHajJvRXNrS2JmS01nelZqa3l5bndW?=
 =?utf-8?B?VTVTWEIyU29BbkY4RHBwZFcyUyt3cEhTY1M5c2s3V0R4OXhxSFR3SnNqSERj?=
 =?utf-8?B?ZG53RlkybHl3Sk5QWWEzNzBlWTJ5K3dvVS95ZVR2eUN5bURWQVRWMDBTY1lQ?=
 =?utf-8?B?enBiNGxqNmdNNW50QmZFMHFpbE1OcXBlYVloODI4Vk9UZHp5Z2ZwVXhMNXpm?=
 =?utf-8?B?S1paREl6akc2Y09odEp5MU9pVTB6dnFOTFV6djNPc2t5OHhvTUtOWW85bndS?=
 =?utf-8?B?ZklzRWNKMHFqTThCdEE0NWRyY3dwNU9tdHZPNWFQWllwSUlleHBtS0JibEpC?=
 =?utf-8?B?clduRlF0VVZNWEZGS21RRVc5cU1uMnYybUlUZVcxd1g2RFZqcWRiY1pzM1kw?=
 =?utf-8?B?dWRISUdhdncwM1hrb0ZiSmhFRkcvTi93S3E2azFFeFVkak5mek9UT1VTR3hZ?=
 =?utf-8?B?eWNZQVJPNDAxM2JqVGlHRXJ6TmdFcUQ5UGx1U1VzWUROMUJuY29INzNEbWth?=
 =?utf-8?B?d2ZYVlFmZjBIVkRvZU9aMlI5M01kVE05eEw0cGxsWHQxaHY0UEN3NkxwZERK?=
 =?utf-8?B?L09BcmJtcHdUeWRzVFB6MkRLRVJMb1E4R1dlcUdyeG1EQnUrVkhSWmtLMG5F?=
 =?utf-8?B?a1RvV243VEpObytoVmJjSUNEOWt5aWEwTjJ4U0ZIUFdZVWFqaFkrdUhlUXdm?=
 =?utf-8?B?ZktqZVpQc28vRTJCeUZLS2plTHhCN1FmUGx5WW9lOG95N3VjaE5FMk5iNDBS?=
 =?utf-8?B?a1NxdDV4K1I1amFCeklhcjJ3ZjJPWUFYUFZnREp5UFpOTXdRbDNRWWtKMnIv?=
 =?utf-8?B?TjU0MWVNcGhMS0hSU2Q2R3VELzdzVHFRR0piMGcwK1gzaUpWckdYK1p2MCtU?=
 =?utf-8?B?SldaYVZvZlIwWHlRNGFWejdJWUIvYWlKTnVWL2VpMXJWRlU3V2RidlBZRENK?=
 =?utf-8?B?UVVkYlRWNnF3aHZpZVFGTXBWdzRrajFxSnpuTktxeDNDOGJGQkhva0lIeEdk?=
 =?utf-8?B?dDJxbFhCb2tyN25nL2NGMXB0djQyVXl0eW1yRS9paWZUN2tLYWZWVGZCKzhv?=
 =?utf-8?B?a0o1R2RxM0c2dzgwbzdxbHQ0aE1ES2krNFVJcWxXb0Z0bktVNWFFZ2lXcDNL?=
 =?utf-8?B?RG1idmdMZlNsbUlSdjJibTdPQlAxSEFHcTdMWVdObklkcWd4RzNRUjk2NDZG?=
 =?utf-8?B?RVJoK0pOKytLUGJWZHlPYjQvQ3RYQlVOWEdqY1IySjZEeDhkVnJrai9nSHZa?=
 =?utf-8?B?Vnh5aEtpYjVKYk1YQTFDTm91K0s4NjRDcFF6dG5BWGRlejRZY20vLzBEM0RF?=
 =?utf-8?B?T09KVCthbVFvVkhYcHBnazFxa3B4MjJXZE0yUVNoYnZQN0l4TXVOS1Bja0ZW?=
 =?utf-8?B?SW1idmpvelFBbzlUZVJiSjgzNDgrMkhoRmI2T1Bja1VSTWF6cTNZWk9aNkxH?=
 =?utf-8?B?ek5PK1VIYmQwVmtjam1MOEFMRThrbENxQmRtMHAyNmM3V2s1N2dqWkVMNWZ6?=
 =?utf-8?B?ZHo3Si83NktjbUtHN1pyd0IzcXJ5VGoxdk9WSTVSUzBwQk1kU0x2NlhxaEtS?=
 =?utf-8?B?REkzeDZLVWlCZ3RRV2MzTDFkOS8xQXB3d2t4M09QbEVkTk1BWW91QlJseWZF?=
 =?utf-8?B?VUxSYWFyN0RhMGdxS0pDZC9idVZ2OEZMODh3WlRzcGxZM28vb2V2Y2NpNjVx?=
 =?utf-8?B?M1dremo2MHpkbUFXZzI4MVFmOWtHUnNHQmpzNU9ONk5DVFdaTE5SR3dhSUwx?=
 =?utf-8?B?eFhSZWdmSVhuM0MzWWUwOXA2OEpXOHgxSWhhcjM0Q3NUb3dDM3JwMmhjN0J0?=
 =?utf-8?Q?MM9BdK7G08GDYc4GeahOwKk=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cbac6bf2-6acb-4c42-85d1-08d9fad5090d
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2022 16:11:53.8838
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kB9QL4Ysf+q2x0kNWMrWdKkwMhSJtHXz+cuGYbW3dEvrfM22br5GIObioRj/n7uilWdTOhd3z6oZt2/EOwZETA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5013

When overriding the tool chain via CROSS_COMPILE, the resulting
components need to be made available to, in particular (but not limited
to) the check-endbr.sh script. Note that we don't allow overriding
ADDR2LINE yet; this would first require additions to some config/*.mk
before it would make sense to export the resulting variable as well.

The lack of NM exporting was apparently not a problem so far, but add it
at this occasion as well - we're using the tool, after all.

Fixes: 4d037425dccf ("x86: Build check for embedded endbr64 instructions")
Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/Makefile
+++ b/xen/Makefile
@@ -55,7 +55,7 @@ export TARGET_ARCH     := $(shell echo $
 # Allow someone to change their config file
 export KCONFIG_CONFIG ?= .config
 
-export CC CXX LD
+export CC CXX LD NM OBJCOPY OBJDUMP
 
 export TARGET := xen
 



From xen-devel-bounces@lists.xenproject.org Mon Feb 28 16:14:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 16:14:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280687.478722 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOifU-00089i-Im; Mon, 28 Feb 2022 16:14:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280687.478722; Mon, 28 Feb 2022 16:14:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOifU-00089b-E9; Mon, 28 Feb 2022 16:14:36 +0000
Received: by outflank-mailman (input) for mailman id 280687;
 Mon, 28 Feb 2022 16:14:35 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=A4HT=TL=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1nOifT-00089V-5V
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 16:14:35 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 841b7d88-98b1-11ec-8eba-a37418f5ba1a;
 Mon, 28 Feb 2022 17:14:33 +0100 (CET)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2051.outbound.protection.outlook.com [104.47.13.51]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-11-AVI7rqiEOCiW6tFtWJEk5Q-1; Mon, 28 Feb 2022 17:14:31 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by HE1PR0402MB3355.eurprd04.prod.outlook.com (2603:10a6:7:81::28)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.24; Mon, 28 Feb
 2022 16:14:28 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.026; Mon, 28 Feb 2022
 16:14:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 841b7d88-98b1-11ec-8eba-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1646064873;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=/iB1gH2B0YDzTRzLQbEQ5yEasgwypiYGXsPhPBKxCzE=;
	b=gPJKPaHrJNihZwYPa81AL99mO7MlvcTSfaplZGC0ckSTmQYsrfLIOyIkEBVjc0E19z0Go/
	ONHSOxYQOxTKIQiF2zLWw6twbzNyBxomXM8BllWQ2TDS9tm6nYSAdnpZX343Qd0O3dcj40
	/Exh4/oaEwqWwJOs8i2CDTfaUxvMOrs=
X-MC-Unique: AVI7rqiEOCiW6tFtWJEk5Q-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ZlvFLfDuUj3daSg0RCzC312dEOVBoVTuRwE5luAzT3X1jXogf4vzVP9MFO0/zfTlFW48Xa5OtbVzoFkdr4sEGPpywXg4Rxt/Sdo3i6lFMzmRMdF74+kE/lFpyTYeEurGklehcCGFX6GoukUFItZXXP53Xf+m9Xufbm05JvWzrP4y9lZ7SVbk5sQtdjSEtkaCe2jRSvwnYOnfJKBqWpyhkfepnvZSu/uf5hqV0HNjuMgPv97y0bv3GJ+GTdo/p3aZT9/y0e/43ZDSOusVMLDq9VPL9bb8U4QHCyM4r8ae9ANIqLZK5z4ESvm6mY5eoIXK0hV1gkg8mkJTYtgYINf4Ow==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=5tlt6OpVr2kmTAbmmEftwGEsWE3Ic2XnKOSvXTcRhPQ=;
 b=WN8ijB4GWKWNNJufbZZH3lUn1ACNFS+rbjz6sGb2lHYThey2eXvCUet7o8W1DFwRKB8NKIsu4keM5TKXi91SSGdtDK3M+qNi3xwODjXTKFxX0AaXOEztc/kXD9aF8C/JE0naHacq7BlQMXKx8ZBo0IHcCqP/sQ7YOpgJAg9r6DkqW1L8FaM4OP3QF4n0HGu+OB+wawjnq7qtwwMyJJfFbJlhK1/5JUeKtLHmiaVK6Ti3Z6TAW6mP+5zuaEQWNR/gUJjJpMbsj+yubS6mOU0o7SvmBtUUfXM7FAbGj9UVxgv+Hox3vF8rqtBuIa+oqAQo3eymQFNnzVkiR7R/66Vohg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <6b59e3ea-01ff-e26c-02d4-3b11594fd7f0@suse.com>
Date: Mon, 28 Feb 2022 17:14:26 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v3 1/2] xen+tools: Report Interrupt Controller
 Virtualization capabilities on x86
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: Jane Malalane <jane.malalane@citrix.com>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Jun Nakajima <jun.nakajima@intel.com>, Kevin Tian <kevin.tian@intel.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20220218172943.12182-1-jane.malalane@citrix.com>
 <20220218172943.12182-2-jane.malalane@citrix.com>
 <0a31970c-c0f8-c995-ce04-67523a4a830a@suse.com>
 <YhyrAyxhNtNWi7NY@Air-de-Roger>
 <9aff51c2-0e8c-685c-7bff-0ed7ff7347c7@suse.com>
 <Yhzr739VZdRLWnok@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Yhzr739VZdRLWnok@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS8PR04CA0104.eurprd04.prod.outlook.com
 (2603:10a6:20b:31e::19) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 8026027e-11ee-49b8-ba64-08d9fad5651b
X-MS-TrafficTypeDiagnostic: HE1PR0402MB3355:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<HE1PR0402MB3355CC5A4DDAC0029784A45EB3019@HE1PR0402MB3355.eurprd04.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	mTwbersICBxpWNG+rloAL6FKi04s2d9eeRwvQPOMCsDnFeo2y8kXLU7unS0D1svIdwunttgsbzbDLu0qJpORbJhH5LZV0KuPsVT/3sDFFWS/knYXl78CjKLYhGAsrBLSZdehl1HfgPSnvk2+t9w7Q+vVjKiOqC5q4sLhroRjnUNkS1q659gnJi88PaQv00zd2NpmgFcyblKC4iu7S3ycWPVbr2k6b9EcgP46SyX+j3bFRbRYy0lBtKdalS3yxZgFzcwQFfBjXH9XYnzc83KdQsRItJAzyf6rIKG8F4JPcblzQUd4HiC5534p86qFr6GM8oH7D68Rr5FG1besjEqg6gRX/qFKPjOtrDqVAPwA+O7bvvepKpPkAz4QZrXuir5UUL8zIbXWnjVNsJ0W3MYM28F7VlWIxyuaNeKzWvWxO7xM1u1Sc9iZ+JLF9MnHt+3Kr5SdY+dtvntHobsY0PUmLanUd+n/fVh0uXp/ohJ1a2CXr/ZJHrptaCRbt0CM/jGIuP+tPqYDmVgS8Y3KqWyZ6nMXwcGPEleIew7z1NLvYEUZA+rNxwQjaWSHD8eEpg7j073RXtTEZchDySiGwiKPTeY/WlRZKdRHJabWMXevmrBCZlHUiWAX7F5E+xI3vI+VhPLXbcADhTZ0Y7jXuLZE1UqKhsXwBpbMmTO71xq2R7i7gnexILzQXvs5FvDWWoBmcu63s4zuWUoV7xsTCkFVdgTZ0S72DRy7rgLfAh8OZeuJlhCdlv+n33vVjUqLDlAb
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2906002)(6486002)(31686004)(83380400001)(53546011)(6512007)(6506007)(7416002)(8936002)(5660300002)(66946007)(31696002)(26005)(186003)(86362001)(66476007)(66556008)(2616005)(36756003)(508600001)(8676002)(4326008)(54906003)(316002)(6916009)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?RaOAdqstYac/p8aoFyFS3Sb8Kg+kp6SHLqM6ZNI6GaARkXhhj0ay8eZ6pZn+?=
 =?us-ascii?Q?rumRbnO76E6of6lU5ErL7PtPxxc0ZI8a9AU/Y5PW0aW/PC5HM50ohLZO1fXz?=
 =?us-ascii?Q?F7waxI3QRIpLf742LSlbJpBjSFX9SY7shbGiMfiicJJJUm23gB0O83UkFBWt?=
 =?us-ascii?Q?ZCYOX0nQ/VT7CJe0Jfn1V8MN0sXKp9mCw3MXwnNDKrioIf5sY2xkYd52TfWl?=
 =?us-ascii?Q?ADBweynxb2dBiufnCHdLv2u6Gt5GZRvgj6SIinmuEBUHdt2Z9pvSXCh9cQ4b?=
 =?us-ascii?Q?WVM4tPHmU69dFxAsdoCXS+sxNVMOAZqDM9BVtJqTMvPYA6hUPlc0fZ103NNS?=
 =?us-ascii?Q?s9u79n7N6mouQ/u3UIJvolX3QbHanP8EDclxdJ6z+JzRWsEwrMAW9vz+98zI?=
 =?us-ascii?Q?OUW0WaNtcffrIRDqOxN5Cf1XVW1IBxL/m7H9OutoFpsa4PLJwZaCQ473r8E5?=
 =?us-ascii?Q?D8jsthsnR0HyN6ORu6malZcWMbXxYe3btuDM13AvjwZNy97YBPcvjtmoyIqr?=
 =?us-ascii?Q?9A2SseXJ0YrAa/773aV7eKXcx55BNAWFxl/ysV4LjXZ5hhrd7fcAS8CzxW7W?=
 =?us-ascii?Q?QEU+i0kg4KpQmiapQjZih57w/eL9GkfpWqymZW/F6zzQSsy0jSEJ3zf2hWFV?=
 =?us-ascii?Q?qa0UihO147CeBh+8yM/s4IoWAADqL5EqgO1eC9DGpgl/B2klZMebFy4cVYqR?=
 =?us-ascii?Q?dcKGLRbolJTZP73O6nBdwgnMjDnms/GOjYdkuXwgEZq7dYsbRtG8UWj5ZUlw?=
 =?us-ascii?Q?Y6D4oi699JW488so9tDvmH2+LNfivjaGZXa354dpO+tqMZQykTo9c+H8oeWD?=
 =?us-ascii?Q?AZmfiDTiOE0AhFcys/9NhMekWyLaKfvqewfJJA90lbvcYeKjvFZcxOMHVm98?=
 =?us-ascii?Q?ZSQPiL1e9BSzZKJdSCWZPfWWPYxk8+cOLSSHcLfurM/1go28uqGDHOFTmMbG?=
 =?us-ascii?Q?cL++/W7LZzIKj9dsdMvglSDH4a53FhBrV6xLwY5tw7O26y3N3r0cpuM+uHfk?=
 =?us-ascii?Q?xmJSMKMMiOwQO5YGGPcePnYCbigfXCCKpUpHBa4REPISEINpvgH7L49cWqJl?=
 =?us-ascii?Q?gceOdRiWya0QSc+dRiaZgUWx3IFeI/7yH1semPN7bNJ6GKCXx+FPK6Vt5orH?=
 =?us-ascii?Q?oftzq14jwBZTsD8QK6PjDC3TiZ4qqmkHPfunwd8Sd5r5dVg3A0nxXHz18uY4?=
 =?us-ascii?Q?Pwr7kRp4oVY0TYb3x6GfDNPt3RygbtMgB/djrFeOdNEAbMGib17MK/iFFCi1?=
 =?us-ascii?Q?YZTuYmjh76OEv9FzVEtH9E3sUwasq3W8Nib4rJTBiF3rttalXqW3QbG7EzYp?=
 =?us-ascii?Q?wOko2RgIU6r30JxqopEewW7NIu3x+oEGco2dRwrDj6j9knp6Ol8x2E9VeAHe?=
 =?us-ascii?Q?+hijCH/MVF27/2xxmFk2LB8Dvm/yw7If+laPRc1Vw98H/U/dad0w8rhDyx/L?=
 =?us-ascii?Q?W4Jbhk/7vUIBFeEWzYFX8e4ZXh/ZTKPyEXC2Sc74POOfzs70FRqXTIoSnEH7?=
 =?us-ascii?Q?l0ZBJx8ojJmLHpaW0MExilvYwn15sAWiaM1Zz/HPZnvctxhNWfzzB1gXriuq?=
 =?us-ascii?Q?JKHGniYtu7eQTs2GZTOM6a+TL2Z/KchCRplXbnRTKDXidkDbs1c5nAS7oaUq?=
 =?us-ascii?Q?vhOwfmos6nnzlFyU0XjMprk=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8026027e-11ee-49b8-ba64-08d9fad5651b
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2022 16:14:28.2492
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kTGxC5Jh7S4EedSqxDnITeUQPlr04wmshpPtnoZNdoUJ2JBZkMI5wwl+3EAhD5snC7wXIkNrNYZ6+xfqkHeAww==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0402MB3355

On 28.02.2022 16:36, Roger Pau Monn=C3=A9 wrote:
> On Mon, Feb 28, 2022 at 02:11:04PM +0100, Jan Beulich wrote:
>> On 28.02.2022 11:59, Roger Pau Monn=C3=A9 wrote:
>>> On Thu, Feb 24, 2022 at 03:08:41PM +0100, Jan Beulich wrote:
>>>> On 18.02.2022 18:29, Jane Malalane wrote:
>>>>> Add XEN_SYSCTL_PHYSCAP_ARCH_ASSISTED_xapic and
>>>>> XEN_SYSCTL_PHYSCAP_ARCH_ASSISTED_x2apic to report accelerated xapic
>>>>> and x2apic, on x86 hardware.
>>>>> No such features are currently implemented on AMD hardware.
>>>>>
>>>>> For that purpose, also add an arch-specific "capabilities" parameter
>>>>> to struct xen_sysctl_physinfo.
>>>>>
>>>>> Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
>>>>> Signed-off-by: Jane Malalane <jane.malalane@citrix.com>
>>>>> ---
>>>>> v3:
>>>>>  * Define XEN_SYSCTL_PHYSCAP_ARCH_MAX for ABI checking and actually
>>>>>    set arch_capbilities, via a call to c_bitmap_to_ocaml_list()
>>>>>  * Have assisted_x2apic_available only depend on
>>>>>    cpu_has_vmx_virtualize_x2apic_mode
>>>>
>>>> I understand this was the result from previous discussion, but this
>>>> needs justifying in the description. Not the least because it differs
>>>> from when XEN_HVM_CPUID_X2APIC_VIRT would be set as well as from what
>>>> vmx_vlapic_msr_changed() does. The difference between those two is
>>>> probably intended (judging from a comment there), but the further
>>>> difference to what you add isn't obvious.
>>>>
>>>> Which raises another thought: If that hypervisor leaf was part of the
>>>> HVM feature set, the tool stack could be able to obtain the wanted
>>>> information without altering sysctl (assuming the conditions to set
>>>> the respective bits were the same). And I would view it as generally
>>>> reasonable for there to be a way for tool stacks to know what
>>>> hypervisor leaves guests are going to get to see (at the maximum and
>>>> by default).
>>>
>>> I'm not sure using CPUID would be appropriate for this. Those fields
>>> are supposed to be used by a guest to decide whether it should prefer
>>> the x{2}APIC over PV alternatives for certain operations (ie: IPIs for
>>> example), but the level of control we can provide with the sysctl is
>>> more fine grained.
>>>
>>> The current proposal is limited to the exposure and control of the
>>> usage of APIC virtualization, but we could also expose availability
>>> and per-domain enablement of APIC register virtualization and posted
>>> interrupts.
>>
>> But then I would still like to avoid duplication of information
>> exposure and expose through the featureset what can be exposed there
>> and limit sysctl to what cannot be expressed otherwise.
>=20
> So you would rather prefer to expose this information in a synthetic
> CPUID leaf?

Depends on what you mean by "synthetic leaf". We already have a leaf.
What I'm suggesting to consider to the give that hypervisor leaf a
representation in the featureset.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Feb 28 16:31:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 16:31:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280696.478733 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOivj-0002Gf-4C; Mon, 28 Feb 2022 16:31:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280696.478733; Mon, 28 Feb 2022 16:31:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOivi-0002GY-Vk; Mon, 28 Feb 2022 16:31:22 +0000
Received: by outflank-mailman (input) for mailman id 280696;
 Mon, 28 Feb 2022 16:31:21 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=o1tx=TL=citrix.com=prvs=051234957=roger.pau@srs-se1.protection.inumbo.net>)
 id 1nOivh-0002GS-5Q
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 16:31:21 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id da3da634-98b3-11ec-8539-5f4723681683;
 Mon, 28 Feb 2022 17:31:18 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: da3da634-98b3-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1646065879;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=wDVtaGfbtrvKea1QgznvqAPc2HZp3sWHr+lsBmRlUlo=;
  b=YQncu7sP6qEchO3v0Vf70IUCtXk8S1lmBJ7L1ho/HhbBcevuTiPXc/dZ
   J3084bWEodephCeQQAlu0Y+nS/SMiYe1IjOccX0Kka8q6PBh0HnUKau5Y
   +furJdIaPEDpua+b40a1hxq293i+luT9AvgEgBR5lBervJQ43RVd3gaK0
   s=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
X-SBRS: 5.1
X-MesageID: 67421947
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:YpoHyaBiIrwJlxVW/5zjw5YqxClBgxIJ4kV8jS/XYbTApDIm3jAPm
 DMZXGmEbP2IM2ejKNFzPYrn9UpX6MCEmNJlQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHWeIdA970Ug5w7Rj0tYx6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhh6
 txmjZW3Ej4QZIjCwdsdTDJDOH1HaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguw5K8bmJsUHs2xIxjDFF/c2B5vERs0m4PcGg2tq35ESQp4yY
 eIlMghMSyzMeyFFHWxJUoJk38qUiFzGJmgwRFW9+vNsvjm7IBZK+LLgKsbPc9qGA8BchF+Fp
 3nu9n78RBodMbS39z2B9X69g/7VqgnyUokSCb6Q++ZjhRuYwWl7IB8LUx29qPqwiE+7UvpeL
 VAZ/mwlqq1a3FymSJzxUgO1pFaAvwUAQJxAHusi8gaPx6HIpQGDCQAsTTNfadpgqM4/QxQr0
 EOEm5XiAjkHmKKRYWKQ8PGTtzzaESofIHIGZCQEZRAY+NSlq4Y25jrNQcxkC7WdlcDuFHf7x
 DXihDMlm7wZgMoP1qO61VPKmTShot7OVAFdzgfKWmOo6CtpaYjjYJangWU39t4ZctzfFAPY+
 iFZxY7Ot4jiEK1higSdYuwmJLiuvM+8ahjS2GFvALI63GiUrivLkZ9r3BlyI0JgM8AhcDDvY
 VPOtQ452KK/LEdGfocsPdvvVp1CIbzIUI28C6uKNoYmjo1ZKVfflByCc3J8yIwEfKIEtagkc
 amWfs+3ZZrxIfQ2lWHmLwvxPFJC+8zf+Y8xbc2hp/hE+eDHDJJwdVvjGAHTBgzexPnZyDg5C
 /4Fa6O3J+x3CYUSmBX//48JNkwtJnMmH53woME/Xrfdflc3SD54UqOPmeNJl2lZc0J9zLqgE
 paVABIw9bYCrSefdVXiho5LMtsDoqqTXVpkZHdxbD5EKlAoYJq17bd3SnfEVeJPyQCX9tYtF
 6NtU5zZWpxnE22bkxxAPciVhNEzL3yD2FPRVxdJlRBiJvaMsSSSoYS6FuYunQFTZheKWTwW+
 OXxhluGGsNYH2yPzq/+MZqS8r94hlBE8MpaVErUONhDPkLq9YlhMSvqifErZcoLLH3+KvGyj
 W563T9wSTHxnrII
IronPort-HdrOrdr: A9a23:m4tEsa5evqhPs1O9hQPXwVOBI+orL9Y04lQ7vn2ZFiY6TiXIra
 +TdaoguSMc6AxwZJkh8erwXpVoZUmsiKKdhrNhQYtKPTOWwldASbsC0WKM+UyEJ8STzJ846U
 4kSdkANDSSNykLsS+Z2njBLz9I+rDum8rE9ISurUuFDzsaEJ2Ihz0JezpzeXcGPTWua6BJc6
 Z1saF81kSdkDksH46G7j5vZZm2m/T70LbdJTIWDR8u7weDyRuu9b7BChCdmjMTSSlGz7sO+X
 XM11WR3NTuj9iLjjvnk0PD5ZVfn9XsjvNFGcy3k8AQbhHhkByhaohNU6CL+Bo1vOaswlA3l8
 SkmWZsA+1Dr1fqOk2lqxrk3AftlB4o9n/Z0FedxUDupMToLQhKQvZptMZ8SF/0+kAgtNZz3O
 ZgxGSCradaChvGgWDU+8XIfwsCrDv0nVMS1cooy1BPW4oXb7Fc6aYF+llOLZsGFCXmrKg6De
 hVCt3G7vo+SyLVU5nghBgt/DWQZAVwIv/fKXJy//B9kgIm00yR9nFohPD2xRw7hdYAo5ot3Z
 WzDk0nrsAIciYsV9MOOA4we7rFNoXze2O4DIuzGyWuKEhVAQOHl3bIiI9Fk91CPqZ4iqcPpA
 ==
X-IronPort-AV: E=Sophos;i="5.90,142,1643691600"; 
   d="scan'208";a="67421947"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=RzbbeAftgU0jaXTb4jDJ/buDhtOMVHKWvL5pAiwtGkPyPTWhDEe/yojITcrinK2G/eebPdholEXXZT/4m5DFWhl9sv2RO+S2jBdnHRkY7ZMHbl/rO8jejFK4Zt4cJVDg03YexlJY57pK8deDgu78OBlo3MYoRV6prtRV0OXbbg6DQzwpRkWrYt6tLlPLoeE4HtU8AA8QMGb6fRmHVLOGDLyRvjK3H6cWkZ3pqvddcVrpuEeG2//OXgXB7rv/4PUlQAZFJgGZIy9oHxoQ8fGNZktX+3CWD3riPJN/KYLJBxr1a67uM1DjSgyyvZpjIpaIdBKY65eQNVpLt/X/sdefOA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=4H06QxMvESAl421R51c3OhWkzGa8V9O0CWDixWNdErw=;
 b=nPZEdE+FqXpp17aCKwbgJk2LjaRwQ76woyROh95QW4lf86cwpsxJPzmFXF+qD2Fx2HBUDQzolLmEK61lBNLVGnZSk8PdV3gbxpvYp49Zt3RE8zcGmAg5N/4RgFqGonEaNBlv7zDUVEQhhpxx8RYw3eEORimMGa0xYtKnw3TLkBw+7HahG5gztGbzIpEIU+mDfOdJOZ5S4ZW8MuxgOEisWc8/WmNpfB6Jjd7CXXrY7QxcXCn4aD8D/K14ZOzsWDwtCk5xBXfv55IYBnydTEM5vb/YcCQbwXdX8N/0q1QdhG9s5ULFu/8Ejw5bq5gPXeixVvIeLCc4KYb7bu97bX4YoA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=4H06QxMvESAl421R51c3OhWkzGa8V9O0CWDixWNdErw=;
 b=ELgub8vui903zepYY0ENCbB5BzGnxEThZgGM75g9thg4Bc8jTE8kMWuBXeDaUZ3OOs8eIuzaG+0PwBrJhl9QlE7zHGevy81xB9/obw2uaGiUrRxez345y9Rutqi1GqaizPoDO/41fMXR/YTWS9VynjN118eNhPuMG/SQb99abrM=
Date: Mon, 28 Feb 2022 17:31:05 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Jane Malalane <jane.malalane@citrix.com>, Wei Liu <wl@xen.org>, "Anthony
 PERARD" <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, "Andrew
 Cooper" <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Julien Grall <julien@xen.org>, Stefano Stabellini
	<sstabellini@kernel.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>, Jun Nakajima
	<jun.nakajima@intel.com>, Kevin Tian <kevin.tian@intel.com>, Xen-devel
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v3 1/2] xen+tools: Report Interrupt Controller
 Virtualization capabilities on x86
Message-ID: <Yhz4yShnpcyq5IDM@Air-de-Roger>
References: <20220218172943.12182-1-jane.malalane@citrix.com>
 <20220218172943.12182-2-jane.malalane@citrix.com>
 <0a31970c-c0f8-c995-ce04-67523a4a830a@suse.com>
 <YhyrAyxhNtNWi7NY@Air-de-Roger>
 <9aff51c2-0e8c-685c-7bff-0ed7ff7347c7@suse.com>
 <Yhzr739VZdRLWnok@Air-de-Roger>
 <6b59e3ea-01ff-e26c-02d4-3b11594fd7f0@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <6b59e3ea-01ff-e26c-02d4-3b11594fd7f0@suse.com>
X-ClientProxiedBy: MR2P264CA0008.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:500:1::20) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ab1da63e-8f79-47b9-edec-08d9fad7badc
X-MS-TrafficTypeDiagnostic: PH0PR03MB6543:EE_
X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
X-Microsoft-Antispam-PRVS: <PH0PR03MB6543390D48CD9650A24DD0FC8F019@PH0PR03MB6543.namprd03.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: LaRujtxKyjEhGuB1ze39lrVeKsnRfuOqDKbAZJ2YjaEyQ0ZzHDrhAGsq1xcbZT8Spj/e1hPklpLHix4AchEuVSf/u49TZzQTt7R+LyqkUDddbn/MPzxvxSoUhiw2XRG6tDFPXbY7mMYTr3TR9bFsrTs9GSfZZsV+YACaPj+B3jDm2FcVX0zsIIPym0BEk/Gq/Q6/pa/AKDeOi3XcV7jqTYIU+fBE2ArWrt3MnnfWDeqDFQzqwCqKplJd/UcvK1FTppfipnaH1qMrrTuGtFC4OzT6Uz6m/7NJRj6JHuYQxjS/6RIq2yI8mNjPIB2/y8XrnlYQ+IiLlLCYenKuiG/aXWAQN9+GpBB4nDId8WQ0d/LEaXRRtVX+Iw1oYNgoYsX4cZ0K59IOEgl6ithWuzZ6LlNUqYpCZp4pNvK3gMqIdRdjlhPagr3QXezO/U+8wRp1yiZ2ZphlhgJ81/lwUgccw1gPFAcMNr8g5/9/c/f1pBFwcSkn9b3SdkZDJmsCCXLme+FcjVNU0atz5YjUx1NoFMFL+f0XvftiDbcfOzTiB/RItyHO8xenZuq0NkJNvRu/cNN92efJaM8QVV0wgChbSOCgom9eyW7sBXBxFPe9+wtnBkysb1+CKOC81f+p/d+qWfDJxsKsFPzWZp51gDjQaA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(9686003)(6512007)(8676002)(66556008)(66476007)(66946007)(26005)(186003)(38100700002)(85182001)(4326008)(7416002)(5660300002)(508600001)(2906002)(6486002)(33716001)(82960400001)(6506007)(316002)(53546011)(86362001)(83380400001)(8936002)(54906003)(6916009)(6666004);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c2NpbkJ1YVFVRk9kdjJGS2FYZnJMbDc2WXVQcXp4QU8vd25iMW9YRXdncUo4?=
 =?utf-8?B?T3FGdGNaeUd5aHRzdHRSZmwySTdWR1Vma2lLaU9qY21oOFNBY2MzZ2g1VVVr?=
 =?utf-8?B?M3NqTXhWMHluTnk2aDlROFpQLzFWOTE2bTJ6Wlp6NHhnOTFBNTJaK2ZFQzBr?=
 =?utf-8?B?YmNsNVFpRXZSU2tRVXFDcFZPTW1HVHVJcktIMzRHQTgySVhCMGZYaXpRTVhJ?=
 =?utf-8?B?bDNLajF3cTZsTW9FMUw1d3NSZFhoMlZ2MWZsTEZZcnBkeWVJeFhtUTU4MGFE?=
 =?utf-8?B?MnJnbEFMdnVpQVUyZjFWUFlyN05OS3pVREl0NC9xTGxYR3RSa1JhdVZOZFBz?=
 =?utf-8?B?ZXVXQlNzMjd0OGRkNWpRc29ZU1RjYXk4RFZiNmhsaWpHVFNIeTlsMDlNVUx0?=
 =?utf-8?B?N3M4N2pCaVFBaVpwak4rZ21wSUt2ZmNRYXhDTy9BVkRNMkJBU1VrajhMZHdB?=
 =?utf-8?B?YlM2S2JQMWM5Mi80Y2hQZGhuZ1JsdlBueTBYczdMSm5keUZidVZQbUNUTEpO?=
 =?utf-8?B?SFhMT2taNE9FSTBUWFk4ZkpaQVZ3dHllSVZRbUYvSXluRUJ6eDkvcHZickgy?=
 =?utf-8?B?YVpjQjErNFg1amhYU0ZzK1RZTUkxaXVGd0RrRUFwejhGamQ0N2NIRVZMMHhP?=
 =?utf-8?B?NFE2N2dVVjBVakgzQWgvRkxHK3cvV1ZWaXdpWTVjbE5TcnpHekh1SW01MlEx?=
 =?utf-8?B?OW91Y0NiZ29VQ3ppS2pOM1lJK0V6RHF2bjJWaDJKUmZjNTR0blk5bVAxWHhW?=
 =?utf-8?B?T0d6SER5R2RrSGV4eXU4N1M3VFgwdlV4WTNBTENUSDV5M3pNMUNkcExWZERX?=
 =?utf-8?B?ZGJZWDhVbjVEVjloQi9kNUo3NUVjOE05aVdVUEswQ2RXRWtRVlRDZDNadVlr?=
 =?utf-8?B?SFYyaHNrS2kvSXozeE16NG5KUXhEcXZ3K3BJcy9lSnhPUS9MdmdMK25rYXBu?=
 =?utf-8?B?YWpJd3NLaTU5amV6eWx0czhnT1I5MnNzRElaSEtSTXoxQ0tDNFh4Ump1TG5n?=
 =?utf-8?B?NGpabHdjRHpHV0tBQmtaQmtaT0pxOHdUSmZ5M0hqWXFJR3VHT2hDbUJNSXEr?=
 =?utf-8?B?eTRyYWp1UEtPbFE2cjRLOGJtemF4K1JTZnpaWkU5WkZqeE9LVlBBRWJJeGJZ?=
 =?utf-8?B?VlYxa0xSSVZOd2x2cnh2ZDgwQXhyM2R5NDBjSUd3MHRIQVFTNllJMU44ZVVE?=
 =?utf-8?B?WkxRc0VJRW5NL0pPbnFLWlFZRlczck1UVHE1N0FjaGNyZHE4RnR4MXhqV0ll?=
 =?utf-8?B?RXlUa1V2WVdaOUNmZE1ENW40bGpxcDYrd1ovc0thM0l1WVYzazlIbjZtbVhh?=
 =?utf-8?B?VW1KbEpma3NDQmNLNWNVd3hkYnhvZXI3M0phYkxoV0d4ZXRsM3lIZzEzT0lQ?=
 =?utf-8?B?Qk5CTnBNUnpCMGk3TWp0S21nUjIzb2JEaDJYNm9NWlBmZy9KYlNVZTBtUFpy?=
 =?utf-8?B?ZVVDVnlDQVZkWENZamNlQytNd0ZJWkdIbkdNQmZ2cmRFNXVqWjJkeFN0cVc2?=
 =?utf-8?B?aW9XMUp3bHFRek5EWkQvL2dWZTRsK1hRYjR3ZmpIOEc0c3ZGdk9VMVZyVFVH?=
 =?utf-8?B?RG05TUlqUG9FMFRyZXJHOUV5dktlRlFTM1FRM3RSTERNQlA3eUlVZlBzVjZQ?=
 =?utf-8?B?Uzlmcm9MdHhhZDk2aDdiTVdzK09XLzJjdHFFV04xRktUWVVOdDdnMTREekV4?=
 =?utf-8?B?T083clBDSkZlODh3ZVFuUzdlN2ZzS3N6dG5LemhGUFZJNjY3Vy9DYklRbFlU?=
 =?utf-8?B?QVlmYS94TGNmL0NxQ0loM2tpdDBjZ1ZQK0ZxSmRmS1FNaVZHTlExdFBRc2Y2?=
 =?utf-8?B?TmhZUW5jZk5KY3M5Wi8zN0k0U1NoNTBRRmRLSVkwWU8wemtqQ01YV2t5S1Jq?=
 =?utf-8?B?Szlia3drcXBnMTVzRDk5UVRDN0M3VHRWb1h2ZytyRlV5OGw1MXRGU0xrcVhx?=
 =?utf-8?B?RFd0a1J5YXdIS1k5eVBNSnJySU5FaTBLYmhBOFVKME1SdjQ2QlBlZ3BST2lh?=
 =?utf-8?B?L1JXa1VrM3NHZ3BQZ3hiZHppVkZZQnJkRUZwMWZSSkNRbWdHU3RlTHIvUFda?=
 =?utf-8?B?KzFRNFppSE5IR0pPdk9GSENzN0Y3NGNEakh6c2xKTEhTdUZzTndyd05CZkFH?=
 =?utf-8?B?NkFKWVBUcjVGSmFFNXJabEZ3YmQwSWhGZGl2djRRTVFER0VBbUkxdzBxRGpH?=
 =?utf-8?Q?4ce1ttmudxbTuiy0+4nKU9k=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ab1da63e-8f79-47b9-edec-08d9fad7badc
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2022 16:31:11.1307
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QqhoSV7kYTcNrt+MjQCIRVcV4i31LyrQnZIpgZVzzdlb2sxCXB8MF2lgZLEJ2AT5Abnu1IuNeXH94ZgBnNwH6Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6543
X-OriginatorOrg: citrix.com

On Mon, Feb 28, 2022 at 05:14:26PM +0100, Jan Beulich wrote:
> On 28.02.2022 16:36, Roger Pau Monné wrote:
> > On Mon, Feb 28, 2022 at 02:11:04PM +0100, Jan Beulich wrote:
> >> On 28.02.2022 11:59, Roger Pau Monné wrote:
> >>> On Thu, Feb 24, 2022 at 03:08:41PM +0100, Jan Beulich wrote:
> >>>> On 18.02.2022 18:29, Jane Malalane wrote:
> >>>>> Add XEN_SYSCTL_PHYSCAP_ARCH_ASSISTED_xapic and
> >>>>> XEN_SYSCTL_PHYSCAP_ARCH_ASSISTED_x2apic to report accelerated xapic
> >>>>> and x2apic, on x86 hardware.
> >>>>> No such features are currently implemented on AMD hardware.
> >>>>>
> >>>>> For that purpose, also add an arch-specific "capabilities" parameter
> >>>>> to struct xen_sysctl_physinfo.
> >>>>>
> >>>>> Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
> >>>>> Signed-off-by: Jane Malalane <jane.malalane@citrix.com>
> >>>>> ---
> >>>>> v3:
> >>>>>  * Define XEN_SYSCTL_PHYSCAP_ARCH_MAX for ABI checking and actually
> >>>>>    set arch_capbilities, via a call to c_bitmap_to_ocaml_list()
> >>>>>  * Have assisted_x2apic_available only depend on
> >>>>>    cpu_has_vmx_virtualize_x2apic_mode
> >>>>
> >>>> I understand this was the result from previous discussion, but this
> >>>> needs justifying in the description. Not the least because it differs
> >>>> from when XEN_HVM_CPUID_X2APIC_VIRT would be set as well as from what
> >>>> vmx_vlapic_msr_changed() does. The difference between those two is
> >>>> probably intended (judging from a comment there), but the further
> >>>> difference to what you add isn't obvious.
> >>>>
> >>>> Which raises another thought: If that hypervisor leaf was part of the
> >>>> HVM feature set, the tool stack could be able to obtain the wanted
> >>>> information without altering sysctl (assuming the conditions to set
> >>>> the respective bits were the same). And I would view it as generally
> >>>> reasonable for there to be a way for tool stacks to know what
> >>>> hypervisor leaves guests are going to get to see (at the maximum and
> >>>> by default).
> >>>
> >>> I'm not sure using CPUID would be appropriate for this. Those fields
> >>> are supposed to be used by a guest to decide whether it should prefer
> >>> the x{2}APIC over PV alternatives for certain operations (ie: IPIs for
> >>> example), but the level of control we can provide with the sysctl is
> >>> more fine grained.
> >>>
> >>> The current proposal is limited to the exposure and control of the
> >>> usage of APIC virtualization, but we could also expose availability
> >>> and per-domain enablement of APIC register virtualization and posted
> >>> interrupts.
> >>
> >> But then I would still like to avoid duplication of information
> >> exposure and expose through the featureset what can be exposed there
> >> and limit sysctl to what cannot be expressed otherwise.
> > 
> > So you would rather prefer to expose this information in a synthetic
> > CPUID leaf?
> 
> Depends on what you mean by "synthetic leaf". We already have a leaf.
> What I'm suggesting to consider to the give that hypervisor leaf a
> representation in the featureset.

Hm, but then we won't be able to expose more fine grained controls,
ie: separate between basic APIC virtualization support, APIC register
virtualization and interrupt virtualization. We would need to keep the
meaning of XEN_HVM_CPUID_APIC_ACCESS_VIRT / XEN_HVM_CPUID_X2APIC_VIRT
(and exposing more fine grained features to guests make no sense).

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Feb 28 16:39:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 16:39:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280703.478744 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOj3A-00031M-Sw; Mon, 28 Feb 2022 16:39:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280703.478744; Mon, 28 Feb 2022 16:39:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOj3A-00031F-P4; Mon, 28 Feb 2022 16:39:04 +0000
Received: by outflank-mailman (input) for mailman id 280703;
 Mon, 28 Feb 2022 16:39:04 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nOj39-000315-WE; Mon, 28 Feb 2022 16:39:04 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nOj39-0001et-SJ; Mon, 28 Feb 2022 16:39:03 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nOj39-0006rm-B4; Mon, 28 Feb 2022 16:39:03 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nOj39-00073p-AZ; Mon, 28 Feb 2022 16:39:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=IKzEgDoADHGPT7p5HyN69LXADJN0tbVnfKexr8dKpzM=; b=gv985nfs94SnxcNLeX9/8h8g2y
	zfXiPR+mlbdbn8+nFv2nDwTQ5YwBLs5Y7u5cCZCzocOVsjBWXx4Ry2YVsoC5EOoJfQhq2HZWOyhyp
	njCLxGKI8M9d4OfS8IfI9YgVHWuPraNgxJ4W1cVoB7s6kjX87dZsCrQpk1G4lFIUls8Y=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168253-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 168253: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=4388144c44c4dd9e9b7df97938ef08ffa85eec07
X-Osstest-Versions-That:
    xen=4388144c44c4dd9e9b7df97938ef08ffa85eec07
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 28 Feb 2022 16:39:03 +0000

flight 168253 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168253/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 168248 pass in 168253
 test-armhf-armhf-xl-rtds     18 guest-start/debian.repeat  fail pass in 168248

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 168248
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168248
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168248
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 168248
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 168248
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168248
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168248
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168248
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 168248
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168248
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168248
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168248
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  4388144c44c4dd9e9b7df97938ef08ffa85eec07
baseline version:
 xen                  4388144c44c4dd9e9b7df97938ef08ffa85eec07

Last test of basis   168253  2022-02-28 07:47:10 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Mon Feb 28 17:21:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 17:21:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280717.478754 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOji5-0008KH-6s; Mon, 28 Feb 2022 17:21:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280717.478754; Mon, 28 Feb 2022 17:21:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOji5-0008KA-40; Mon, 28 Feb 2022 17:21:21 +0000
Received: by outflank-mailman (input) for mailman id 280717;
 Mon, 28 Feb 2022 17:21:19 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=l6xm=TL=microsoft.com=mikelley@srs-se1.protection.inumbo.net>)
 id 1nOji3-0008K4-Ie
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 17:21:19 +0000
Received: from NAM02-BN1-obe.outbound.protection.outlook.com
 (mail-bn1nam07on20724.outbound.protection.outlook.com
 [2a01:111:f400:7eb2::724])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d5ecb13b-98ba-11ec-8539-5f4723681683;
 Mon, 28 Feb 2022 18:21:18 +0100 (CET)
Received: from MN0PR21MB3098.namprd21.prod.outlook.com (2603:10b6:208:376::14)
 by MW4PR21MB1969.namprd21.prod.outlook.com (2603:10b6:303:7c::5) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5061.0; Mon, 28 Feb
 2022 17:21:09 +0000
Received: from MN0PR21MB3098.namprd21.prod.outlook.com
 ([fe80::69f8:51be:b573:e70c]) by MN0PR21MB3098.namprd21.prod.outlook.com
 ([fe80::69f8:51be:b573:e70c%5]) with mapi id 15.20.5038.006; Mon, 28 Feb 2022
 17:21:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d5ecb13b-98ba-11ec-8539-5f4723681683
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=WGROcgBaEOXb7LR3FSSNEbts4Yq/gvHTx+QKUuXbAAY5UqWvNzfG7p7f8KZ/E4oIY2Rg3W/6thQHYo5rve1gDrELKt8iS2YFLRoH9fR/9AjQ2lsrgmn9iDX80UAjlSXOSPjssDUT8bTtfta610/KrIXF2KrxowYbVA72b+NZKjemn6I3Q8qTA8pRTtF8REV/JBSss17jNVGtO1VcQKJc/r0HVJUDodOMK67YsY8jVlw4hKBUGKXamkEqnLxEDesq1hYllQrmCfk3QY6HyBfqf6cbFPKkF3CKIzRlGdswgVbTtwwpkjOaxMQW3IwFnOYSnAGrVG3h0f1J30AqcmDstw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=RpdUqKZ7g1q/KewkZ6ChsRglmfEx00uxvbcobvCdGfU=;
 b=LJMs1KTZ7v/9xPQzWqwE99HpshKHrcrSRvv/ORlRAYjEQ4QMFbz9SSuQz569NU3uSyxbw7qgL8vThmNVrmL+iOoOZ5Q05OOgLdlnVnuyY6rt8CO3+nJ7pO6RhgJs5YRQ6hsBnmgzIr9q4dr/DnKFZ7cId8sNR8mK1kPz+NjJsYmsHCLHbZjW/S2w4xeNV0MBOZwP1OY9w/Pm5csoksYWBXZLx9aLCD2H2wSEQ/aNiJomsEF0PFRWEmgnxrcWHd9g/6DyV5ZH6ZfvKyrunrSO9n+PYyWpqMNlu9SlmdfaxECG9OT8XX/tiZEog93mBNempxlHZOzdJ/YJEFwMvv/XAw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=microsoft.com; dmarc=pass action=none
 header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=RpdUqKZ7g1q/KewkZ6ChsRglmfEx00uxvbcobvCdGfU=;
 b=g9nhUzwY7Vv8E+CpoSKp6JTM3px3JlWNs6F2X8reB07guIM/x41SwxKlqSwheS10FFvB/Fkeq7/rfh8dcoeOfoUnWfG+L0jxfKfrdqdCGm4VlN8iNabrsfcnlk6IAdWKRQX46VsBv09YurvywJ/Jr7kAhgjG5GLHzKCGlZRnNLY=
From: "Michael Kelley (LINUX)" <mikelley@microsoft.com>
To: Christoph Hellwig <hch@lst.de>
CC: "iommu@lists.linux-foundation.org" <iommu@lists.linux-foundation.org>,
	"x86@kernel.org" <x86@kernel.org>, Anshuman Khandual
	<anshuman.khandual@arm.com>, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>, Boris Ostrovsky
	<boris.ostrovsky@oracle.com>, Juergen Gross <jgross@suse.com>, Joerg Roedel
	<joro@8bytes.org>, David Woodhouse <dwmw2@infradead.org>, Lu Baolu
	<baolu.lu@linux.intel.com>, Robin Murphy <robin.murphy@arm.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "linux-ia64@vger.kernel.org"
	<linux-ia64@vger.kernel.org>, "linux-mips@vger.kernel.org"
	<linux-mips@vger.kernel.org>, "linuxppc-dev@lists.ozlabs.org"
	<linuxppc-dev@lists.ozlabs.org>, "linux-riscv@lists.infradead.org"
	<linux-riscv@lists.infradead.org>, "linux-s390@vger.kernel.org"
	<linux-s390@vger.kernel.org>, "linux-hyperv@vger.kernel.org"
	<linux-hyperv@vger.kernel.org>, "tboot-devel@lists.sourceforge.net"
	<tboot-devel@lists.sourceforge.net>, "linux-pci@vger.kernel.org"
	<linux-pci@vger.kernel.org>
Subject: RE: [PATCH 08/11] swiotlb: make the swiotlb_init interface more
 useful
Thread-Topic: [PATCH 08/11] swiotlb: make the swiotlb_init interface more
 useful
Thread-Index: AQHYK+bNn5GdGBwbMEGdpROKeAVKTayoQv4AgACScQCAAGA5YA==
Date: Mon, 28 Feb 2022 17:21:08 +0000
Message-ID:
 <MN0PR21MB3098608AE81E444CC3C25B3ED7019@MN0PR21MB3098.namprd21.prod.outlook.com>
References: <20220227143055.335596-1-hch@lst.de>
 <20220227143055.335596-9-hch@lst.de>
 <MN0PR21MB309816A344171B46735CA29CD7019@MN0PR21MB3098.namprd21.prod.outlook.com>
 <20220228113042.GA10570@lst.de>
In-Reply-To: <20220228113042.GA10570@lst.de>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
msip_labels:
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=09ca4065-c6d1-484e-9620-c278d7ad8315;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2022-02-28T17:15:06Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=microsoft.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: cddbc668-5c1a-4f83-a223-08d9fadeb5d5
x-ms-traffictypediagnostic: MW4PR21MB1969:EE_
x-ms-exchange-atpmessageproperties: SA|SL
x-microsoft-antispam-prvs:
 <MW4PR21MB196937E190D2B2302E542BC1D7019@MW4PR21MB1969.namprd21.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 cWMWzCjniKzqFntSWVtxFr6flL5hbkfMuMWEOfWBvp+rRvG3wx0D3BFme7Yx0KkfWddAX+K0TAjZSoBLG/dbCYqG3J4kOuPfduhdVzscxUWeqlC9sCMkCqC0xiejdz/6IT7f6bapZMAliRvF/vblVA6B2YlRczt5t0sEpaYdr5dazTyWOvIE0KVPw6YW5F/PgZj0YMXKWHad3ywMAD+hHR365wls4O+zcl6VWG7NacfeMBxfTB8Nr+2PhySwoukGk4rzlf6C0OODAj+PoceUmzz6B7ak2FDpI7Hs5qR06yzJdm5EDKWHL9m1v4FwEXi2xJ/kA+nFuVK2YrDBsI0KqQMtV8rp674JXYCFZU3QkL+HedGlbfTYi6d23jn2awU57YHtSy2fQoFZ82WoWOwjEKbhX+lbrpEX9ApOdwVw3S9RUm8hmMDB7RemARCNdIBOnPMRt0n+s1AlgosPl75ZvR59aChrKGJeUPiNSc+5cIffAEKtK70UsCmch8KzNHauzAEuGBCVhe0ad4OAnA/wrjzHa1QNqWU9BBO4zAHWz8/RUx4OtzPqv/q5jZnEDIkvcnrTA1e7sVhEtlDrhAaLXEi9iT5mOAdUaZ+CVshr3g3WBcOUxb8jf1BuTEQoYZCCQEhQLQl2I2x/lcQA04gwYJi3joTUh36T1bkrZdCas1OWQuHFQaDuBk6Tz/A4k+zU15fg6Dh8oVWnyCzEwn1IPkzGbyQPt6KEI4s9I4Vmx0F5qReR6C3txeazzxnncn3L
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN0PR21MB3098.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6916009)(10290500003)(55016003)(33656002)(2906002)(508600001)(54906003)(316002)(82950400001)(86362001)(82960400001)(38070700005)(122000001)(38100700002)(52536014)(76116006)(66946007)(66476007)(66556008)(4326008)(8676002)(66446008)(7696005)(71200400001)(6506007)(64756008)(7416002)(186003)(26005)(5660300002)(9686003)(8936002)(83380400001)(8990500004);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?29qyXTMF81O5S1nx5r+Osp6BQ3ZTLcxu2nBcQagislDsBPG7/Ek1jr6Fh3OJ?=
 =?us-ascii?Q?opz233MPZ2LLUS/xrAR5i+eVc/zjCgiVy/ZZuf3InciYY0kMjj7+5VaO5h5F?=
 =?us-ascii?Q?oRKXGdgstHJssPfSfK2WsKYRNeeviAEFXbmxNfv8bknITEhFH5B4d6jwze4c?=
 =?us-ascii?Q?RWXCGfZNF2gKSkuPcpodmLO0n7bQLJyVr8jAXN+XgCdkV91EVzAAYIUz0Uq2?=
 =?us-ascii?Q?yditzag1mxkeDvx+u3/cN7VJT5I5A5f3wl1WsBcvf6OqUpeRsXsL6w5wps06?=
 =?us-ascii?Q?OeyG5v7grFT6+P+mzpPMYT8SNHnzVUa38NYQWN0X4cFU8K6DyNlWpfpn6zUs?=
 =?us-ascii?Q?MXl9+qxlaYoLCV/Gu/olCdfTvRPkm7Eodi56SkhrywkJLBm2oajaleIuYWgZ?=
 =?us-ascii?Q?8WKC+RGUtlMJg5ivA9cB9olJOCkKlh0E+ruPUFdqZO7Wie3Blz9B5aS4egQk?=
 =?us-ascii?Q?ScpyHViNGJli/C8ys0QP2FW8viCgMAzumWEv4zYc2T7kAwrHxo/a/4w8BCUI?=
 =?us-ascii?Q?S9oSQ8iyUaIrjgFXvC/u/FYkaC+gUt2VBaD38jQfKSKwzADe4iDFJUul2VKU?=
 =?us-ascii?Q?XPLpG/26A6X9zUSa3f2pelG03Q52x2t1kHF6BdmAa6JwPo+bCpqzos58Cdnt?=
 =?us-ascii?Q?126Bg+eFBH6hjPcb3bLc8a4jpbrDeMqMk24DcSPLXYQAe2FrIsduyuGRILDq?=
 =?us-ascii?Q?csTj3oIiSQBfTDJnZll226+FPShkzEpQO1d9rZoxX6n5EpKXblNnTktM+xNN?=
 =?us-ascii?Q?17jXiNYZvs95XMpBYvwqVO6k2OnWdtynypvighqRkDlYRiVWEtcBFdmh1B+8?=
 =?us-ascii?Q?DateI3ggNJxMadDyoNzi/IPwpllwUb7Z381uWK5pgamFLgNUq/0jkKwO0/Wx?=
 =?us-ascii?Q?4mvc5QLQIYLHk7w5Z0Ol56+UsMsGe2eYhrmQ26YoCie5TsFOgvuZYIR/HGqH?=
 =?us-ascii?Q?uDNRa+N9vvPIFo9AZJ7Kp172LlVuDohqcCLzE4HokxuVqpG+6qsemCNBOc/S?=
 =?us-ascii?Q?I5HfA3HwA4LUdCpal4akyxUQz4U//cM6fGRRxFdD66OqmWagCtftMRQV6mkP?=
 =?us-ascii?Q?CMbTal9ZvFOLnTE4bdkS1Y3QgAu7h/tEOq/8pWCANPRmkC/nqavd5Yd6J/MA?=
 =?us-ascii?Q?R5R1P67ITW3DpSXyMGg3AA1wzK5psIK3gkl32DnEjiXmj1WkSEHvNYX6ht5K?=
 =?us-ascii?Q?GPB75YGdMVG7gmxMyCTereGHRheCMA4L0Tsuzz0FkN5brsFZXMNcqQB+h0Jd?=
 =?us-ascii?Q?EFzYZm7uPyaqVuh5aH5HtujJZvEMFrXRhSlYRHvK33rdvCM8j2gqMtVcEbB7?=
 =?us-ascii?Q?W1XkihGMneb+CyMh/KOmYFkqY0Srp/mX97+xBeFPHuMTveuzO7Sg540IMVwp?=
 =?us-ascii?Q?hO/qc1LYfKsSvK1g829RchZje/CiVbp7/4/gEZIYVsOwba0W7dYzYwLPhANY?=
 =?us-ascii?Q?UGF1iEfHAQVHD03WfHcq/MLTHnpj0HHw1yEp6mPS7avfnTkrVuX5dg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: microsoft.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MN0PR21MB3098.namprd21.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cddbc668-5c1a-4f83-a223-08d9fadeb5d5
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Feb 2022 17:21:08.7946
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: vzOn32YAvsUYVAMMexjkwRxJ/GCrUPaTSyZyITipNC05D/kQ57R5+nXhVEq9s2CnE36lzOIxTlRer+N0f7Wm6ohAO+aiDJeeTp61TqSz2jo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR21MB1969

From: Christoph Hellwig <hch@lst.de> Sent: Monday, February 28, 2022 3:31 A=
M
>=20
> On Mon, Feb 28, 2022 at 02:53:39AM +0000, Michael Kelley (LINUX) wrote:
> > From: Christoph Hellwig <hch@lst.de> Sent: Sunday, February 27, 2022 6:=
31 AM
> > >
> > > Pass a bool to pass if swiotlb needs to be enabled based on the
> > > addressing needs and replace the verbose argument with a set of
> > > flags, including one to force enable bounce buffering.
> > >
> > > Note that this patch removes the possibility to force xen-swiotlb
> > > use using swiotlb=3Dforce on the command line on x86 (arm and arm64
> > > never supported that), but this interface will be restored shortly.
> > >
> > > Signed-off-by: Christoph Hellwig <hch@lst.de>
> > > ---
> > >  arch/arm/mm/init.c                     |  6 +----
> > >  arch/arm64/mm/init.c                   |  6 +----
> > >  arch/ia64/mm/init.c                    |  4 +--
> > >  arch/mips/cavium-octeon/dma-octeon.c   |  2 +-
> > >  arch/mips/loongson64/dma.c             |  2 +-
> > >  arch/mips/sibyte/common/dma.c          |  2 +-
> > >  arch/powerpc/include/asm/swiotlb.h     |  1 +
> > >  arch/powerpc/mm/mem.c                  |  3 ++-
> > >  arch/powerpc/platforms/pseries/setup.c |  3 ---
> > >  arch/riscv/mm/init.c                   |  8 +-----
> > >  arch/s390/mm/init.c                    |  3 +--
> > >  arch/x86/kernel/cpu/mshyperv.c         |  8 ------
> > >  arch/x86/kernel/pci-dma.c              | 15 ++++++-----
> > >  arch/x86/mm/mem_encrypt_amd.c          |  3 ---
> > >  drivers/xen/swiotlb-xen.c              |  4 +--
> > >  include/linux/swiotlb.h                | 15 ++++++-----
> > >  include/trace/events/swiotlb.h         | 29 ++++++++-------------
> > >  kernel/dma/swiotlb.c                   | 35 ++++++++++++++----------=
--
> > >  18 files changed, 56 insertions(+), 93 deletions(-)
> >
> > [snip]
> >
> > >
> > > diff --git a/arch/x86/kernel/cpu/mshyperv.c b/arch/x86/kernel/cpu/msh=
yperv.c
> > > index 5a99f993e6392..568274917f1cd 100644
> > > --- a/arch/x86/kernel/cpu/mshyperv.c
> > > +++ b/arch/x86/kernel/cpu/mshyperv.c
> > > @@ -336,14 +336,6 @@ static void __init ms_hyperv_init_platform(void)
> > >  			swiotlb_unencrypted_base =3D
> ms_hyperv.shared_gpa_boundary;
> > >  #endif
> > >  		}
> > > -
> > > -#ifdef CONFIG_SWIOTLB
> > > -		/*
> > > -		 * Enable swiotlb force mode in Isolation VM to
> > > -		 * use swiotlb bounce buffer for dma transaction.
> > > -		 */
> > > -		swiotlb_force =3D SWIOTLB_FORCE;
> > > -#endif
> >
> > With this code removed, it's not clear to me what forces the use of the
> > swiotlb in a Hyper-V isolated VM.  The code in pci_swiotlb_detect_4g() =
doesn't
> > catch this case because cc_platform_has(CC_ATTR_HOST_MEM_ENCRYPT)
> > returns "false" in a Hyper-V guest.  In the Hyper-V guest, it's only
> > cc_platform_has(CC_ATTR_GUEST_MEM_ENCRYPT) that returns "true".  I'm
> > looking more closely at the meaning of the CC_ATTR_* values, and it may
> > be that Hyper-V should also return "true" for CC_ATTR_MEM_ENCRYPT,
> > but I don't think CC_ATTR_HOST_MEM_ENCRYPT should return "true".
>=20
> Ok, I assumed that CC_ATTR_HOST_MEM_ENCRYPT returned true in this case.
> I guess we just need to check for CC_ATTR_GUEST_MEM_ENCRYPT as well
> there?

I'm unsure.

The comments for CC_ATTR_HOST_MEM_ENCRYPT indicates that it is for
SME.   The comments for both CC_ATTR_MEM_ENCRYPT and
CC_ATTR_GUEST_MEM_ENCRYPT mention SEV and SEV-ES (and presumably
SEV-SNP).   But I haven't looked at the details of the core SNP patches fro=
m
the AMD folks.   I'd say that they need to weigh in on the right approach
here that will work for both SME and the various SEV flavors, and then
hopefully the Hyper-V case will fit in.

Michael


From xen-devel-bounces@lists.xenproject.org Mon Feb 28 18:20:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 18:20:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280724.478766 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOkch-0005Xm-Nm; Mon, 28 Feb 2022 18:19:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280724.478766; Mon, 28 Feb 2022 18:19:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOkch-0005Xf-KG; Mon, 28 Feb 2022 18:19:51 +0000
Received: by outflank-mailman (input) for mailman id 280724;
 Mon, 28 Feb 2022 18:19:50 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=VtgV=TL=gmail.com=this.is.a0lson@srs-se1.protection.inumbo.net>)
 id 1nOkcf-0005XX-Tx
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 18:19:50 +0000
Received: from mail-qv1-xf35.google.com (mail-qv1-xf35.google.com
 [2607:f8b0:4864:20::f35])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 01a01c52-98c3-11ec-8539-5f4723681683;
 Mon, 28 Feb 2022 19:19:48 +0100 (CET)
Received: by mail-qv1-xf35.google.com with SMTP id d3so13966050qvb.5
 for <xen-devel@lists.xenproject.org>; Mon, 28 Feb 2022 10:19:46 -0800 (PST)
Received: from development (c-73-166-253-254.hsd1.tx.comcast.net.
 [73.166.253.254]) by smtp.gmail.com with ESMTPSA id
 p20-20020a05620a22b400b00648ca1458b4sm5303454qkh.5.2022.02.28.10.19.44
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Mon, 28 Feb 2022 10:19:44 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 01a01c52-98c3-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=message-id:subject:from:to:cc:date:in-reply-to:references
         :user-agent:mime-version:content-transfer-encoding;
        bh=5yx/d6Vxb/4eHUVrcRLPUEMBCOXADteCGvx/kV/VGSM=;
        b=PnXCi02pjarlYqMAHVYG1Z2Eji2JMmqQNoyUbx3t7UptrnT/ro9EshSdr6stDoNR1J
         32agAXSWu1ltNmdnHeauh1bVe2M7hwzT3PH2JBAiYL8sYs8e43qzwEpEfn1S8CC8kGVo
         ELIW6wqRGtJh5QlhsRBpqNzI55LPXJOAdocf/qkQeB1nGxOBUfVzs77YCotatUEDTQE9
         sU/6GMH9LOLlJVXneDzfEbSv8NlORtCH2OiHIEN3bH9y7o2GjODTH0tWRCzob4ITLVJT
         Stmxzoq7yWNNcDaBj2OjEHbusbQkJcrr8QzqvsuLWahgL/xrPk/MVxQQy0ic6wVQ3cb5
         BkVg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to
         :references:user-agent:mime-version:content-transfer-encoding;
        bh=5yx/d6Vxb/4eHUVrcRLPUEMBCOXADteCGvx/kV/VGSM=;
        b=YcMazFx2BlKiVThzcbz++79stZ17oB/nodG0RjtTSoz3WVJyfJ6wrk2EVI63qQoXJG
         mmbk7Hwy8o4xxOy1OyqG0Sw08vko+RGGlI8E+I8dFxSjFBhY7oFHcexAHb0501m9QMaj
         fMH3y9N2CxQFOdwV7ivhYoC8t0zAEv0WNvw4bT+2CNeRYiuzwAIrsYTU0EYdx/u6XyXY
         k9vZH0GN78plMJ3YsEMqcEf9IsfevTUISVp6OiMmvh6LQgdcTmy4x9RzKtMvcu5WF4f7
         JSGKnaFNsv9PqwXQlngQM0oGgIxw3W5P0Cg1pC10vMvdjm/S0+3CQVou4fvacxC/soMg
         hLqQ==
X-Gm-Message-State: AOAM5318rRmJeyrEj4kxOiOTcc+1Z3S+paxCZBsw32BHVgBEP24QiWIs
	FJFN8JChcurQ7Zp2mevxv90LiLjsOHoBjw==
X-Google-Smtp-Source: ABdhPJyAQJDZroUeWUXPGxWa7C21PdRZq/jdNNzeOfKbW6wPnzHHN/fBrXhL7F7oxLwkNQ8CEqLAeA==
X-Received: by 2002:a05:622a:1713:b0:2de:889:f00d with SMTP id h19-20020a05622a171300b002de0889f00dmr16931778qtk.169.1646072384892;
        Mon, 28 Feb 2022 10:19:44 -0800 (PST)
Message-ID: <3986c91f62cb1bf3a042f669c40b900653f1ab51.camel@gmail.com>
Subject: Re: [PATCH v2 2/2] vpci/msix: fix PBA accesses
From: Alex Olson <this.is.a0lson@gmail.com>
To: Roger Pau =?ISO-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>
Cc: xen-devel@lists.xenproject.org, Jan Beulich <jbeulich@suse.com>
Date: Mon, 28 Feb 2022 12:19:43 -0600
In-Reply-To: <Yhn8rzRIC/TNiPv2@Air-de-Roger>
References: <20220225153956.1078-1-roger.pau@citrix.com>
	 <20220225153956.1078-3-roger.pau@citrix.com>
	 <d8da3251985684ab9099ce95a8329a7e35535a7b.camel@gmail.com>
	 <Yhn8rzRIC/TNiPv2@Air-de-Roger>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.36.5-0ubuntu1 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Hi Roger,

The revised patch looks good.  The PBA writes seen during ioatdma driver
initialization (self-test) complete successfully and the driver doesn't complain
(I see two interrupts per ioatdma device).   The driver has a self-test feature
which appears to exercise MSIX interrupts and has code which appears to cause a
PBA write.

Feel free to add "Tested-by: Alex.Olson@starlab.io" to your patchset.

Thanks also for the pointer to your 2018 work on SR-IOV, I'll give it a try. 


FYI, with this patch,  I was seeing  msix_read() and msix_write() being called
during the driver's self-test on physical address 0xfbc01800, corresponding to
the beginning of the PBA (lspci excerpt below):


02:00.0 System peripheral: Intel Corporation Xeon Processor D Family QuickData Technology Register DMA Channel 0
...
        Region 0: Memory at fbc06000 (64-bit, non-prefetchable) [size=8K]
...
        Capabilities: [ac] MSI-X: Enable+ Count=1 Masked-
                Vector table: BAR=0 offset=00001000
                PBA: BAR=0 offset=00001800
...
        Kernel modules: ioatdma



The functions involved on the Linux kernel side are:

ioat_probe()
 -> ioat3_dma_self_test()
  -> ioat_dma_self_test()
   -> ioat_free_chan_resources()
    ->  ioat_reset_hw()

drivers/dma/ioat/dma.c:   ioat_reset_hw()
...
    ioat_dma->msixpba = readq(ioat_dma->reg_base + 0x1800);
...
    writeq(ioat_dma->msixpba, ioat_dma->reg_base + 0x1800);


Thanks,

-Alex

On Sat, 2022-02-26 at 11:10 +0100, Roger Pau Monné wrote:
> On Fri, Feb 25, 2022 at 11:57:05AM -0600, Alex Olson wrote:
> > I think there is an issue in the spin_lock handling of patch 2 for the
> > "msix_write" function as it results in the lock being taken a second time
> > while
> > held (hangs). 
> > 
> > The lock taken before checking "VMSIX_ADDR_IN_RANGE" isn't unlocked for the
> > non-
> > PBA case and a second lock is attempted just before the call to get_entry()
> > later in the same function.  It looks like either the added lock should
> > either
> > be moved inside the PBA case or the lock before get_entry() should be
> > removed.
> 
> Sorry, was in a rush to send this before leaving yesterday and didn't
> refresh the commit before generating the patch, v2.1 should be fixed.
> 
> Could you provide a 'Tested-by' if it work for you?
> 
> > On my server, upon loading the ioatdma driver, it now successfully attempts
> > an
> > PBA write (which now doesn't crash the system), but I'm not sure I have a
> > way to
> > fully exercise it...
> 
> Urg, that's weird, PBA should be read-only only according to the spec.
> Writes to PBA have undefined behavior.
> 
> > I also see a different (related) issue in which modify_bars is called on a
> > virtual function seemingly before the BAR addresses are initialized/known
> > and
> > will start a different thread for that topic.
> 
> SR-IOV is not supported on PVH dom0 yet, so that's not going to work.
> I've posted a series in 2018 to enable it, but sadly had no time to
> work on it anymore:
> 
> https://lore.kernel.org/xen-devel/20180717094830.54806-1-roger.pau@citrix.com/
> 
> It's likely not going to apply cleanly, and there's a lot of comments
> to be fixed up there.
> 
> Thanks, Roger.



From xen-devel-bounces@lists.xenproject.org Mon Feb 28 18:51:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 18:51:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280731.478777 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOl77-0001Pk-9o; Mon, 28 Feb 2022 18:51:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280731.478777; Mon, 28 Feb 2022 18:51:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOl77-0001Pd-4Z; Mon, 28 Feb 2022 18:51:17 +0000
Received: by outflank-mailman (input) for mailman id 280731;
 Mon, 28 Feb 2022 18:51:16 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nOl76-0001PX-1C
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 18:51:16 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nOl75-0004Eu-Qd; Mon, 28 Feb 2022 18:51:15 +0000
Received: from 54-240-197-238.amazon.com ([54.240.197.238]
 helo=[192.168.13.237]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nOl75-0000Xf-HB; Mon, 28 Feb 2022 18:51:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=l9bWHWXXVhia/n9u7oGRqlBS9yRDTfXgHaHFIdVfX/8=; b=SHFuJMwJOBmlq+TGhuIVrDfvsG
	XR5CDS3yyzl4Xdyzwgq3234syfuMWDzKW1llMjYuE/jt2AdZkIPRVUdzEe6d5UaPbzwxky2KMMbVg
	QYdwqnXoFpAuBamY1g9rpFYsxs82t2KA6qQT8buv3oRT7WzIb8RsByZ8/OpUpPfGZ5+E=;
Message-ID: <48a0712c-eff8-dfc1-2136-59317f22321f@xen.org>
Date: Mon, 28 Feb 2022 18:51:13 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.1
Subject: Re: [RFC PATCH 0/2] Introduce reserved Xenheap
To: Henry Wang <Henry.Wang@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>
Cc: Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>,
 Penny Zheng <Penny.Zheng@arm.com>
References: <20220224013023.50920-1-Henry.Wang@arm.com>
 <6269ec3d-039e-d68f-771d-c5e088631410@xen.org>
 <PA4PR08MB625324910ED4D40383191F9D92019@PA4PR08MB6253.eurprd08.prod.outlook.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <PA4PR08MB625324910ED4D40383191F9D92019@PA4PR08MB6253.eurprd08.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit



On 28/02/2022 07:12, Henry Wang wrote:
> Hi Julien,

Hi Henry,

>> -----Original Message-----
>> From: Julien Grall <julien@xen.org>
>> Sent: Saturday, February 26, 2022 4:09 AM
>> To: Henry Wang <Henry.Wang@arm.com>; xen-devel@lists.xenproject.org;
>> sstabellini@kernel.org
>> Cc: Bertrand Marquis <Bertrand.Marquis@arm.com>; Wei Chen
>> <Wei.Chen@arm.com>; Penny Zheng <Penny.Zheng@arm.com>
>> Subject: Re: [RFC PATCH 0/2] Introduce reserved Xenheap
>>
>> Hi Henry,
>>
>> On 24/02/2022 01:30, Henry Wang wrote:
>>> The reserved Xenheap, or statically configured Xenheap, refers to parts
>>> of RAM reserved in the beginning for Xenheap. Like the static memory
>>> allocation, such reserved Xenheap regions are reserved by configuration
>>> in the device tree using physical address ranges.
>>
>> In Xen, we have the concept of domheap and xenheap. For Arm64 and x86
>> they would be the same. But for Arm32, they would be different: xenheap
>> is always mapped whereas domheap is separate.
>>
>> Skimming through the series, I think you want to use the region for both
>> domheap and xenheap. Is that correct?
> 
> Yes I think that would be correct, for Arm32, instead of using the full
> `ram_pages` as the initial value of `heap_pages`, we want to use the
> region specified in the device tree. But we are confused if this is the
> correct (or preferred) way for Arm32, so in this series we only
> implemented the reserved heap for Arm64.

That's an interesting point. When I skimmed through the series on 
Friday, my first thought was that for arm32 it would be only xenheap (so
all the rest of memory is domheap).

However, Xen can allocate memory from domheap for its own purpose (e.g. 
we don't need contiguous memory, or for page-tables).

In a fully static environment, the domheap and xenheap are both going to 
be quite small. It would also be somewhat difficult for a user to size 
it. So I think, it would be easier to use the region you introduce for 
both domheap and xenheap.

Stefano, Bertrand, any opionions?

On a separate topic, I think we need some documentation explaining how a 
user can size the xenheap. How did you figure out for your setup?

>>
>> Furthemore, now that we are introducing more static region, it will get
>> easier to overlap the regions by mistakes. I think we want to have some
>> logic in Xen (or outside) to ensure that none of them overlaps. Do you
>> have any plan for that?
> 
> Totally agree with this idea, but before we actually implement the code,
> we would like to firstly share our thoughts on this: One option could be to
> add data structures to notes down these static memory regions when the
> device tree is parsed, and then we can check if they are overlapped.

This should work.

> Over
> the long term (and this long term option is currently not in our plan),
> maybe we can add something in the Xen toolstack for this usage?

When I read "Xen toolstack", I read the tools that will run in dom0. Is 
it what you meant?

> 
> Also, I am wondering if the overlapping check logic should be introduced
> in this series. WDYT?

I would do that in a separate series.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Feb 28 19:16:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 19:16:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280745.478793 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOlV6-0004Ej-B6; Mon, 28 Feb 2022 19:16:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280745.478793; Mon, 28 Feb 2022 19:16:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOlV6-0004Ec-7X; Mon, 28 Feb 2022 19:16:04 +0000
Received: by outflank-mailman (input) for mailman id 280745;
 Mon, 28 Feb 2022 19:16:03 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1nOlV5-0004EV-1d
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 19:16:03 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nOlV2-0004fP-Cj; Mon, 28 Feb 2022 19:16:00 +0000
Received: from 54-240-197-238.amazon.com ([54.240.197.238]
 helo=[192.168.13.237]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1nOlV2-0002uB-6J; Mon, 28 Feb 2022 19:16:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=+ebivgdSZz++H5uAdMdU0S7sRir0Zj4rY9Rya5d/fII=; b=fXQQMA4Zpd5YQyS0kyqwly1ehv
	6tz6IPoKQq1Ww8GAgZ8gTvKoIV1+NwnpT+joX84zKUuR1aL6GZS12QKWEA/nvO8oGNEFCny1B9vz0
	1z/T+bUZPszRUTVWhnLmqrb4OMsUIfYpiivsfKd0oG9TUeNiy3Ovp6lmMPgySEsJVtkQ=;
Message-ID: <9d5d7760-ea52-8c0b-b649-319f4c812b14@xen.org>
Date: Mon, 28 Feb 2022 19:15:58 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.1
Subject: Re: [PATCH v2] lib: extend ASSERT()
To: George Dunlap <George.Dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>
Cc: Bertrand Marquis <Bertrand.Marquis@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <Andrew.Cooper3@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Roger Pau Monne <roger.pau@citrix.com>
References: <75125344-b0e1-9663-4c1a-84bb35870fef@suse.com>
 <35d82770-66cf-e030-5bcc-3c030e4463d7@xen.org>
 <3F58400B-5151-42F2-8F39-109DDF50EE1E@arm.com>
 <a89223c8-f59a-24cc-96a7-e40feb28813f@suse.com>
 <DB014136-7797-4A61-9681-33A7D85403AA@citrix.com>
 <732e8e39-36c4-1651-61f3-9b55caf29fe8@suse.com>
 <46408EAE-5EA4-4B22-B685-BA6D313B5D3A@citrix.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <46408EAE-5EA4-4B22-B685-BA6D313B5D3A@citrix.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi George,

Sorry for the late answer.

On 16/02/2022 12:23, George Dunlap wrote:
> 
> 
>> On Feb 16, 2022, at 11:42 AM, Jan Beulich <jbeulich@suse.com> wrote:
>>
>> On 16.02.2022 12:34, George Dunlap wrote:
>>
>>> I am opposed to overloading “ASSERT” for this new kind of macro; I think it would not only be unnecessarily confusing to people not familiar with our codebase, but it would be too easy for people to fail to notice which macro was being used.
>>>
>>> ASSERT_ACTION(condition, code) (or even ASSERT_OR_ACTION()) would be a bare minimum for me.
>>>
>>> But I can’t imagine that there are more than a handful of actions we might want to take, so defining a macro for each one shouldn’t be too burdensome.
>>>
>>> Furthermore, the very flexibility seems dangerous; you’re not seeing what actual code is generated, so it’s to easy to be “clever”, and/or write code that ends up doing something different than you expect.
>>>
>>> At the moment I think ASSERT_OR_RETURN(condition, code), plus other new macros for the other behavior is needed, would be better.
>>
>> Hmm, while I see your point of things possibly looking confusing or
>> unexpected, something like ASSERT_OR_RETURN() (shouldn't it be
>> ASSERT_AND_RETURN()?) is imo less readable. In particular I dislike
>> the larger amount of uppercase text. But yes, I could accept this
>> as a compromise as it still seems better to me than the multi-line
>> constructs we currently use.
> 
> I see what you’re saying with AND/OR; I personally still prefer OR but wouldn’t argue to hard against AND if others preferred it.
> 
> As far as I’m concerned, the fact that we’re reducing lines of code isn’t a reason to use this at all.  As our CODING_STYLE says, ASSERT() is just a louder printk.  We would never consider writing PRINTK_AND_RETURN(), and we would never consider writing a macro like CONDRET(condition, retval) to replace
> 
> if (condition)
>      return retval;
> 
> The only justification for this kind of macro, in my opinion, is to avoid duplication errors; i.e. replacing your code segment with the following:
> 
> if (condition) {
>      ASSERT(!condition);
>      return foo;
> }
> 
> is undesirable because there’s too much risk that the conditions will drift or be inverted incorrectly. But having control statements like ‘return’ and ‘continue’ in a macro is also undesirable in my opinion; I’m personally not sure which I find most undesirable.
> 
> I guess one advantage of something like ASSERT_OR(condition, return foo); or ASSERT_OR(condition, continue); is that searching for “return” or “continue” will come up even if you’re doing a case-sensitive search.  But I’m still wary of unintended side effects.
> 
> Bertrand / Julien, any more thoughts?
The discussion reminds me WARN_ONCE() in Linux. The macro returns a 
value so it can be used like:

if (WARN_ONCE(...))
   return error;

How about introducing a new macro that would return whether the check 
passed and if the check failed crashed in debug build?

I am not suggesting to modify ASSERT() because the compiler may decide 
to not ellide check in production build. Also, the name feels a little 
bit odd.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Feb 28 20:46:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 20:46:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280754.478804 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOmty-0005Fo-8U; Mon, 28 Feb 2022 20:45:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280754.478804; Mon, 28 Feb 2022 20:45:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOmty-0005Fh-4c; Mon, 28 Feb 2022 20:45:50 +0000
Received: by outflank-mailman (input) for mailman id 280754;
 Mon, 28 Feb 2022 20:45:48 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=f/XG=TL=oracle.com=boris.ostrovsky@srs-se1.protection.inumbo.net>)
 id 1nOmtv-0005Fb-FL
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 20:45:48 +0000
Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com
 [205.220.165.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 64e67cce-98d7-11ec-8eba-a37418f5ba1a;
 Mon, 28 Feb 2022 21:45:43 +0100 (CET)
Received: from pps.filterd (m0246617.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 21SIJH9t010133; 
 Mon, 28 Feb 2022 20:45:22 GMT
Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79])
 by mx0b-00069f02.pphosted.com with ESMTP id 3eh1k40tdj-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Mon, 28 Feb 2022 20:45:22 +0000
Received: from pps.filterd (userp3020.oracle.com [127.0.0.1])
 by userp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 21SKjJ2q068547;
 Mon, 28 Feb 2022 20:45:21 GMT
Received: from nam12-mw2-obe.outbound.protection.outlook.com
 (mail-mw2nam12lp2044.outbound.protection.outlook.com [104.47.66.44])
 by userp3020.oracle.com with ESMTP id 3efdnkh3jy-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Mon, 28 Feb 2022 20:45:21 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10)
 by MWHPR10MB1999.namprd10.prod.outlook.com (2603:10b6:300:10a::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.24; Mon, 28 Feb
 2022 20:45:17 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::6d20:6694:a16:56f7]) by BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::6d20:6694:a16:56f7%3]) with mapi id 15.20.5017.027; Mon, 28 Feb 2022
 20:45:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 64e67cce-98d7-11ec-8eba-a37418f5ba1a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date :
 subject : to : cc : references : from : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2021-07-09;
 bh=1wKjj3LnwUWytX/Ia3WLTLQfLa8LC04ESZNTlgZQOEI=;
 b=lC23NQlfrrd2pQnPdQAMEo1ip5xVwnTTBzMrvNwsHbDRbEIA6k+Vo9FNwUscGpQ5RxmR
 4Yk+pcJ8BKquIojX+INN7yGzEiCoS9RBmKm4bj0GFYAz0XkXmqNQ4K9FxvjY4GLgaXJE
 2MdsZdJt9bJER5dmIYF+zOuC4hr1Dv8NFSLe9kiTwLXuLEfS2YC3XrbhT4lZPQuUeZv7
 g2H52LWkf+5O/pd0U5gXE6AQ1QeDaAIrcZZFps9ydqDfeX86PcGmx1oVl0E2/wzWC0rd
 XabPSSpFe6lVr+s9pbVR4/QpBT7pNnry+2Y9WznKgmdOIqnRBvr4Czm2+/2KxfjTYZuw jQ== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=KpKw0++e5B0dNEPyH7Ij5zOB+b3A+7sUBoDQfxv+gJlaBbeZdcjflq3o8M9dZ5SwLJvD4w63QUyDurorhCQUyB+A/BWOX8bkh3lLJYWPUeUgGGJ+sYn6mJrEy90oAWmT+zKAJv5mg14OjnmM1fsc7qg29DiAyeP4bUw59qW2F3xjLrj44D3tTORlZGUOpCTIwnY5IwHIowglret4OwiadRuXcAeCNRSUXmXuf8y+VOT7Ch+4BJ48m4gwsOp6sbk7tJLW+Cw/Nls7KKS6aeaF2fT5wMZ9nV06yqCQnp/nmEqASafUtUyOyA1O04eeoMzJFf1A+5z8k6ZvFMLRt2rHlA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=1wKjj3LnwUWytX/Ia3WLTLQfLa8LC04ESZNTlgZQOEI=;
 b=daihD9HgHpQRln8mgDRIpiRm9KdEukG27Wu+tQ4X72b3r3O8cHZjWoXw1zBlE3tI6E6uNgXUqIniCG95U/eletUytI0D1Vz/YUrGD/YEbsVtCfWaUqDNu6JvySsWEyBWAoh9RZnaRkaMG2xF4BpH2utStHqfeXMwvl62lg7n31I8uYjM8kuEwOXv9dyYVoecKaaJ7bfkm6L0FMBCB0RRzGia7mgFM3AupMVu8i43Spvs/XjTCUBb33V1YVChcKHKzl/Zz2q1LbIPiKUhAtZhiR0Qb5mQdehsx+bkGTSSdeQuItUB/E427cTHpnkXR8pcZFdis2o62Vx/HgBNl9zgVw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=1wKjj3LnwUWytX/Ia3WLTLQfLa8LC04ESZNTlgZQOEI=;
 b=gvg/icPTVj6ajSdzWaQsobNHRSbsr/fLzbbWE4waZ0y9857yyckHteYRxdv2jpioGSbwP+7TqcBd3qvHXdYJgHv+XXulKYhjI6WjbTUL4OA6qb+kJ8AiJoA4XGus+W5lAkH2+/FNW9kzKW2eUqAYv1BkuGCp/9eQkE4oAINDYYU=
Message-ID: <8e3e4716-22e7-8684-394c-b5a457906975@oracle.com>
Date: Mon, 28 Feb 2022 15:45:13 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.1
Subject: Re: [PATCH v3 0/1] xen: fix HVM kexec kernel panic
Content-Language: en-US
To: Dongli Zhang <dongli.zhang@oracle.com>, xen-devel@lists.xenproject.org,
        x86@kernel.org
Cc: linux-kernel@vger.kernel.org, jgross@suse.com, sstabellini@kernel.org,
        tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
        dave.hansen@linux.intel.com, hpa@zytor.com, joe.jin@oracle.com
References: <20220224215049.2845-1-dongli.zhang@oracle.com>
 <9de1059b-6b48-e2c8-60bc-f29b42b217f7@oracle.com>
 <36014dbd-e63c-cf49-dafd-2d7a8b84db5d@oracle.com>
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <36014dbd-e63c-cf49-dafd-2d7a8b84db5d@oracle.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: SN7PR04CA0059.namprd04.prod.outlook.com
 (2603:10b6:806:120::34) To BLAPR10MB5009.namprd10.prod.outlook.com
 (2603:10b6:208:321::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5b4b2d61-127c-4e75-d85b-08d9fafb3a83
X-MS-TrafficTypeDiagnostic: MWHPR10MB1999:EE_
X-Microsoft-Antispam-PRVS: 
	<MWHPR10MB1999A5401E0512596C8AF1A28A019@MWHPR10MB1999.namprd10.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	IB0KzyDtqkq+i5vFBqTvNjT1fYbOMUPLtKSp4Z/JmXS9fpFU0ekslLjaGvCcOE76YcNOOpX2b6rvkonIqhBWaEMUIU9Y5+hByte+hbjO1xtTr2aphtVFS+xKpOZllc2dBLLtmPj0vM6sw4fcwraZ2l+PDrO94QqSjAVNGZflTy5GBSIQj/x0VZBOE/AdTR4bhVrV2hRCXL/Mwi7+Qd/3xbXWanv8gaT8bcwJ4JLExpOma01/B+FQ9hesxqwY09LDeyvsRDtS79yQaPP37Wq7TCOaDeK9Gqf58lAZGnruGor29G63bc9T2Sl98+05YAkWaWT9eilc9iYChCsM1lWQTiDZQdHbjpKdftjqEudNK85K2yeO1JenRZiO62xqvKxB328wuXrrjUXFxJiMruGYHLXaVpXB/lYLnQrzwr04HYzBxbk6YaL1udM3nxjX81KiVSGM7N+h35fqs/B7IPKB3A434UsXBIEFPZ0cnC7jh4wJ1a++yL/paO22LYAkcEr3XnM2sswOHNto6eQPKXg9ZiOKqlnmb9bMXBT5lbM4Z6GG0cn8P0qpKS29uQ0rr2BDWVL061/+fyQ9zPVAKU0iyXRLmCJdAO5odrVsszp9DT6ZUFAW0Oa/x+i36ol09IOeTpP5IPZlfT4FCIpP6G0kBB2e0/2DbDz/MPl6vyes2Hcl8gar/3elX0hpmPYUyw7atWC5KtT6O2YepBQno+3GhpOlM6xmypijSsxbxSBezrlGe+YP8iRQ5QUkPQJ6KUg6
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2906002)(8936002)(38100700002)(86362001)(5660300002)(31696002)(44832011)(7416002)(2616005)(6486002)(316002)(26005)(186003)(6506007)(6512007)(107886003)(31686004)(6666004)(53546011)(508600001)(36756003)(4326008)(8676002)(83380400001)(66476007)(66946007)(66556008)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?K0ZtUVVSZDFLeUtXVFRjWHBBdVppbjVZcWpTVitGaHdva1pVN2JObEtnbkg4?=
 =?utf-8?B?NW9udGovcUIxcVNQOUtmTy9PMnpIbCtveTJtakVUczhlcmMyLzBQdGFoeEdn?=
 =?utf-8?B?NjR3OXE1bVZrUnMzcG1oK29BT0xzQzlyZXRPQzhOa2xTRzdueXI3QUt1SHEv?=
 =?utf-8?B?eEtXV3VBelhEQlR2cXJ2TTE0bkFCeDBzb2NvTFRNdDgwR2dCWFNJL1VLdkxU?=
 =?utf-8?B?MWRHRUMyZ0tkZEJpMTNJdHg5Z0QwMlpIUDBRQkxrSElzV2g3S2x0czFFalUv?=
 =?utf-8?B?aVM0Q2JuWlo0WWN5bmRiRDZBYjMrb1RIOGJqWlFvcXgyRDhrVXVRMWd2QXlQ?=
 =?utf-8?B?emx2NTlRWDRFZGd3YmxKWFVBMWpuMG5Oek1zZzZjL2pzQ001bzY3aXdQNnlO?=
 =?utf-8?B?bjdvZUdLemQ3TlAzdHV6bFhGNEErRWxOVmxOd0xETWF1Tk9FV2Q2Ri9HRmE4?=
 =?utf-8?B?WUJLVlh3OG1Zc0ZYWkcvSW92M21GWXlnY08relcxTG82RkFLeFF1RXRNSi81?=
 =?utf-8?B?TFhGYlY5TVhaajJZaW05dWdyZnYvN09LUWFBaWt2QUsxQ0hzbTVpdEU3MmZZ?=
 =?utf-8?B?ZGNCamV0UE9BajQvN0NXRUZkMUJ3QVBlK1ZEVmkrMDlJbHhwZHk0b1hONlND?=
 =?utf-8?B?OTJaemoxNnpHZjZXSVBpY0pLM0JpekZyTmlDRjJjUmZWRnZFaDJNK0R0Q2xw?=
 =?utf-8?B?WkJIM3pQRmYxTmhIWUF2Y3VtYzNVc2RtZ2ZSYmtNc1JHcE5NV2hZMVRWUm1r?=
 =?utf-8?B?Z3l4QXlRMWJJOWZmeUZPWkJqbnYvbWZxSC92TE9ZYW9sRU5PSG9hc0k3M0hx?=
 =?utf-8?B?VTJIRW5MRjdZb3Y4SVJpdlcxVnB0SWdhTEJBa2lGZ1dqcWljbFFHMzhUdTJD?=
 =?utf-8?B?UEtQelJINVc3UHFOdDlielh6ZldTN2Z0TlBjdkNKOXhjWHZVcEtyak9qOHlP?=
 =?utf-8?B?VlArenBqUUJ3N2VDVUFYUzgyVXZWaXh6enlaREcyM2NGY0JsRjRUZzJWemQw?=
 =?utf-8?B?MWsxc0hhSjlnQ08ycDVvOTFWalFYczlJNkxLamFpcW5abUVydjFWNktsdkFR?=
 =?utf-8?B?QmFpTUxDcExlUnMzcVlUeHd1amtKeCtFZWRqbXBySWFJUFlHQjhNbXRoOFpF?=
 =?utf-8?B?Y25lU0FvL3puVmpkWkM0SWRacHVtcG4zU2o1cG5YbjVEdUxmMXczcVg0dVMr?=
 =?utf-8?B?MlpzajdXMkRhN1NIZ015S2RPNXpScENIcHpDU0ExSVVvYzd2bWZRNWhKLzA2?=
 =?utf-8?B?N2xnYVo3bG9jQXQxNTJYUURqOThINDIzV3k5aHVKSUhhQ2RTYW1IR2pOWHRh?=
 =?utf-8?B?Sm1OQ2g4VWt4R1hrdUNsNDdyM1pEOGt0d1ovYmdqbjIzRXU3YTlHTklWaHhM?=
 =?utf-8?B?S0xxbEtCcGVnTVhDL2xDdWtNU21BVG9BL3dlYTVKK2grOXY1MG9vMEZYOTdi?=
 =?utf-8?B?eFFhMHhYZkdtWXZEYVIwMVJQTm5pa1V1SldacW5RMFVoZ01NRmIzV2xFYWE2?=
 =?utf-8?B?QkZsaXNKdjl5dDRveWt6UlNQNms0c2tPOFFaS0oyZnd5N0tJZzhrd3k1TW5n?=
 =?utf-8?B?ZXZhRnJIWFA0TjFWSkhYV1U5TkdjN3RueDZWVWUxWk16NmpZUDR6MjZzVXlW?=
 =?utf-8?B?dW02eUQwWnJZbnN1Wkpwd3VYWGpWSEZtN3IrdTVISTFFYzJkUlRkZ0NGeVpk?=
 =?utf-8?B?elMzTHVaSVdhZFpLNnVxUHR5bElmeXAxRTJUK0U0U3RFL2Y1Vit6OGtXeFJJ?=
 =?utf-8?B?NVU3NHpGcEw3cHpSLzU0YitqODZtMHhFOWdLNFR0bTZVcHJLeVlKMEVrbmoy?=
 =?utf-8?B?dXA4NE93TDA1Q05oNTVQdlViM3l1RmxpMTByc0czbGhoRlU1YktHcVlETTJQ?=
 =?utf-8?B?QW9WNnc0alpvNFdHL1Z2YlBtNks2ZkJOcjNmV2tyV3RvOU81ajdVWFFmUUwz?=
 =?utf-8?B?bE95dEZ6ZEFFcW1URGZTeFBnM0FReUpSQU9lMk13RFc5d1pQNGttR0JIWkUv?=
 =?utf-8?B?U0w4Mkx2SjR2R1VPOTJpTFJobVd1OFNFQ3JiQWRNRjBqelBlWHhXV2I2Q09J?=
 =?utf-8?B?L1FuWjRzRzhqR0JFZ3N4RU52QTZud2l2SlhZYnAxcHQ3aGI1bVA3K3lsejhy?=
 =?utf-8?B?ZTJQMTZjWERyYjdsK243b2tpbU1MYWs0Y25GVXZlWGp5SFFvdFdUSnkyTkxH?=
 =?utf-8?B?ZkpRU21QNk5pVzNVVDE3emgrZUdKOVFSVlJUU2xlSFpNbm0vWEt1c2luQW4w?=
 =?utf-8?Q?TkGTEYnQIyKWn6E38fjz+Ewm8RJjbM77yNjsac6Kns=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5b4b2d61-127c-4e75-d85b-08d9fafb3a83
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2022 20:45:17.7589
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: U6IHEUtWpBtFsXlTcvByx0SHxwtzSVVbZ7lhxcSPEi16aAwjp+7zH2a6GL31ogOMnzw531dmx1dajwF+oAk01o1lKd8rLpMMeT54uvP1SU4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1999
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10272 signatures=684655
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 bulkscore=0
 adultscore=0 phishscore=0 spamscore=0 suspectscore=0 malwarescore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202280103
X-Proofpoint-ORIG-GUID: aIpQspA_c5pa9-fSlnkase4cvay-cBy2
X-Proofpoint-GUID: aIpQspA_c5pa9-fSlnkase4cvay-cBy2



On 2/25/22 8:17 PM, Dongli Zhang wrote:
> Hi Boris,
> 
> On 2/25/22 2:39 PM, Boris Ostrovsky wrote:
>>
>> On 2/24/22 4:50 PM, Dongli Zhang wrote:
>>> This is the v3 of the patch to fix xen kexec kernel panic issue when the
>>> kexec is triggered on VCPU >= 32.
>>>
>>> PANIC: early exception 0x0e IP 10:ffffffffa96679b6 error 0 cr2 0x20
>>> [    0.000000] CPU: 0 PID: 0 Comm: swapper Not tainted
>>> 5.17.0-rc4xen-00054-gf71077a4d84b-dirty #1
>>> [    0.000000] Hardware name: Xen HVM domU, BIOS 4.4.4OVM 12/15/2020
>>> [    0.000000] RIP: 0010:pvclock_clocksource_read+0x6/0xb0
>>> ... ...
>>> [    0.000000] RSP: 0000:ffffffffaae03e10 EFLAGS: 00010082 ORIG_RAX:
>>> 0000000000000000
>>> [    0.000000] RAX: 0000000000000000 RBX: 0000000000010000 RCX: 0000000000000002
>>> [    0.000000] RDX: 0000000000000003 RSI: ffffffffaac37515 RDI: 0000000000000020
>>> [    0.000000] RBP: 0000000000011000 R08: 0000000000000000 R09: 0000000000000001
>>> [    0.000000] R10: ffffffffaae03df8 R11: ffffffffaae03c68 R12: 0000000040000004
>>> [    0.000000] R13: ffffffffaae03e50 R14: 0000000000000000 R15: 0000000000000000
>>> [    0.000000] FS:  0000000000000000(0000) GS:ffffffffab588000(0000)
>>> knlGS:0000000000000000
>>> [    0.000000] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
>>> [    0.000000] CR2: 0000000000000020 CR3: 00000000ea410000 CR4: 00000000000406a0
>>> [    0.000000] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
>>> [    0.000000] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
>>> [    0.000000] Call Trace:
>>> [    0.000000]  <TASK>
>>> [    0.000000]  ? xen_clocksource_read+0x24/0x40
>>
>>
>> This is done to set xen_sched_clock_offset which I think will not be used for a
>> while, until sched_clock is called (and the other two uses are for suspend/resume)
>>
>>
>> Can we simply defer 'xen_sched_clock_offset = xen_clocksource_read();' until
>> after all vcpu areas are properly set? Or are there other uses of
>> xen_clocksource_read() before ?
>>
> 
> I have tested that below patch will panic kdump kernel.
> 



Oh well, so much for that then. Yes, sched_clock() is at least called from printk path.


I guess we will have to go with v2 then, we don't want to start seeing time going back, even if only with older hypervisors. The only thing I might ask is that you roll the logic inside xen_hvm_init_time_ops(). Something like


xen_hvm_init_time_ops()
{
	/*
	 * Wait until per_cpu(xen_vcpu, 0) is initialized which may happen
	 * later (e.g. when kdump kernel runs on >=MAX_VIRT_CPUS vcpu)
	 */
	if (__this_cpu_read(xen_vcpu_nr(0)) == NULL)
		return;

	...

-boris


From xen-devel-bounces@lists.xenproject.org Mon Feb 28 22:52:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 22:52:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280762.478814 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOorv-0001WT-Di; Mon, 28 Feb 2022 22:51:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280762.478814; Mon, 28 Feb 2022 22:51:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOorv-0001WM-Ao; Mon, 28 Feb 2022 22:51:51 +0000
Received: by outflank-mailman (input) for mailman id 280762;
 Mon, 28 Feb 2022 22:51:50 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3PPb=TL=citrix.com=prvs=0512ed4f8=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1nOoru-0001WF-LH
 for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 22:51:50 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0164172b-98e9-11ec-8539-5f4723681683;
 Mon, 28 Feb 2022 23:51:47 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0164172b-98e9-11ec-8539-5f4723681683
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1646088707;
  h=from:to:cc:subject:date:message-id:mime-version:
   content-transfer-encoding;
  bh=rB3SEPzzkQAvW0/fHf3gf9OHT/NLDK1BJr8fdP433E4=;
  b=Q4FWjZpzg3GsRBKp9dFsf1s7FXcfhWrK9QuEzmcWxG5+PLe7Co3GuAwi
   vlH0W4EhIrBb1sNRD6CfsYhjdCDB1kF4xC7B6IUGKxhku0TOu/Gu294Ja
   4/klsFvNRa5Y9a0to9FEPli10zwkEUSuROgaCdEbNURGMtpGQ+6kqT1aT
   g=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 67453921
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:NbMHf6zRTiLv1Pyoj6J6t+czxirEfRIJ4+MujC+fZmUNrF6WrkUPz
 mEfDGmEOa7fYzDye90kboSwpElSv8WGyodmHgpvqSAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGX9JZS5LwbZj2NYy24jhWWthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 NpllKWIQjsuJf32uOE7UUZ8OAM5PoEbweqSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DFYUToHx/ixreCu4rW8vrSKTW/95Imjw3g6iiGN6AO
 JZEMms1NXwsZTV/ZFIMJpEkrN6tn3vBfiBcqBWOu6Qetj27IAtZj+G2bYu9lsaxbdpRtlaVo
 CTB5WuRKjMwOcGbyDGF2mmxneKJliT+MKoCGbv9+vN0jVm7wm0IFAZQRVa9ueO+iEO1R5RYM
 UN8x8Y1hfFsrgrxFIC7BkDm5i7f1vIBZzZOO8wD0AqxzbGE2SacIGpbahVjL98K6fZjEFTGy
 WS1t9/uADVutpicRnSc6qqYoFuOBMQFEYMRTXRaFFVYurEPtKl210uSFYg7TMZZm/WoQWmY/
 tyckMQpa1z/Z+Yv3r7zw13IiinESnPhHl9svVW/so5IA2pEiG+Zi26AtACzARVodt/xory9U
 J4swZD2AAcmV8zlqcB1aL9RdIxFHt7cWNEmvXZhHoM66xOm8GO5cIZb7VlWfRk1bJ5bImG1O
 RaK6Gu9AaO/2lPwNsebhKrrVqwXIVXIT4y5Bpg4kPIUCnSOSON31H43PhPBt4wcuEMtjbs+K
 f+mnTWEVh4n5VBc5GPuHY81iOZzrghnnD+7bc2rnnyPjOvFDFbIGOhtDbd7Rr1ghE9yiF6Oq
 Ig32grj40g3bdASlQGMqd9DdQ1RdCNjbX00wuQOHtO+zsNdMDlJI5fsLXkJIuSJQ4w9ej/0w
 0yA
IronPort-HdrOrdr: A9a23:nqOVNqyU3ur40HF399rAKrPwKL1zdoMgy1knxilNoHtuA6ulfq
 GV7ZAmPHrP4wr5N0tNpTntAsa9qBDnlaKdg7N+AV7KZmCP0gaVxepZjLfK8nnNHDD/6/4Y9Y
 oISdkaNDQoNykYsS8t2njbL+od
X-IronPort-AV: E=Sophos;i="5.90,144,1643691600"; 
   d="scan'208";a="67453921"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>
Subject: [PATCH] x86/spec-ctrl: Disable retpolines with CET-IBT
Date: Mon, 28 Feb 2022 22:51:17 +0000
Message-ID: <20220228225117.14327-1-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

CET-IBT depend on executing indirect branches for protections to apply.
Extend the clobber for CET-SS to all of CET.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>

I can't decide if this wants a fixes tag or not.  If I'd remembered during the
CET series, it would have been its own patch.  Functionally, it depends on c/s
cdbe2b0a1aec which sets CR4.CET fairly early during boot.
---
 xen/arch/x86/spec_ctrl.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/xen/arch/x86/spec_ctrl.c b/xen/arch/x86/spec_ctrl.c
index 2d4cf5c7ef80..12bf1c5722f9 100644
--- a/xen/arch/x86/spec_ctrl.c
+++ b/xen/arch/x86/spec_ctrl.c
@@ -944,10 +944,11 @@ void __init init_speculation_mitigations(void)
                      boot_cpu_has(X86_FEATURE_IBRS));
 
     /*
-     * First, disable the use of retpolines if Xen is using shadow stacks, as
-     * they are incompatible.
+     * First, disable the use of retpolines if Xen is using CET.  Retpolines
+     * are a ROP gadget so incompatbile with Shadow Stacks, while IBT depends
+     * on executing indirect branches for the safety properties to apply.
      */
-    if ( cpu_has_xen_shstk &&
+    if ( (read_cr4() & X86_CR4_CET) &&
          (opt_thunk == THUNK_DEFAULT || opt_thunk == THUNK_RETPOLINE) )
         thunk = THUNK_JMP;
 
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Feb 28 23:14:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 28 Feb 2022 23:14:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.280769.478826 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOpE7-00044f-93; Mon, 28 Feb 2022 23:14:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 280769.478826; Mon, 28 Feb 2022 23:14:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1nOpE7-00044Y-5i; Mon, 28 Feb 2022 23:14:47 +0000
Received: by outflank-mailman (input) for mailman id 280769;
 Mon, 28 Feb 2022 23:14:45 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nOpE5-00044O-Ev; Mon, 28 Feb 2022 23:14:45 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nOpE5-0000K3-Bz; Mon, 28 Feb 2022 23:14:45 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1nOpE4-0005XY-Ov; Mon, 28 Feb 2022 23:14:44 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1nOpE4-00009K-OD; Mon, 28 Feb 2022 23:14:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ZvVNyiTL0kJMaHpebfwsg1w6dRITYChy5LMtn8a69wU=; b=VEhkdAgDiZXW2pnioOZV82GBrB
	BcudGvuz3yfD2jwQoiEgMZyIPzaTTxs2on/uW1sJYxLmX+sUHdMGAi0hEoD9qGsVSwzyPJqGbBE2O
	gU6vZCeX22ORyfTjx3nZ51s9f3qGD5sta+m7wNvSyCtr5pmk/oAElsWyM15c1MZ1koL4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-168255-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 168255: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=00483d386901173e84c7965f9f0d678791a75e01
X-Osstest-Versions-That:
    qemuu=fa435db8ce1dff3b15e3f59a12f55f7b3a347b08
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 28 Feb 2022 23:14:44 +0000

flight 168255 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/168255/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168230
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168230
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168230
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168230
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168230
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168230
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168230
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168230
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 qemuu                00483d386901173e84c7965f9f0d678791a75e01
baseline version:
 qemuu                fa435db8ce1dff3b15e3f59a12f55f7b3a347b08

Last test of basis   168230  2022-02-25 11:36:57 Z    3 days
Testing same since   168255  2022-02-28 17:08:25 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Peter Maydell <peter.maydell@linaro.org>
  Stafford Horne <shorne@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   fa435db8ce..00483d3869  00483d386901173e84c7965f9f0d678791a75e01 -> upstream-tested